Support local search

Is this a bug report?
NO
Have you read the [Contributing Guidelines on issues]
YES
Environment
None
Steps to Reproduce
None
Expected Behavior
None
Actual Behavior
None
Reproducible Demo
None
Request new feature
I have a website in my intranet, it generated use gitbook. Now i perfer to use the excellent website generator, and deprecated gitbook. But the tool miss local search capability while migrate process. So we have possible to provide local search(like hexo next theme)?

Do you mean Algoria Search locally ?

In my company we are looking for a similar solution using Lunrjs, where you can simply index your article locally. At the moment it looks pretty impossible to workaround reactjs and extend the navigation bar to allow the search field to appear without an algolia setup.

@endiliey when is Docusaurus v2 coming ?

@ntlex Hi. We are in the planning stages now.

We have been evaluating a few tools to generate an internal help system in our company. The help system will be hosted behind the firewall and will not be exposed to public. To use the search feature, we need to have Algolia enabled, which wants the site to be public. Is there a way we can use the Search feature without Algolia? I really like Docusaurus and want to go ahead with it. However, the Search limitation is pulling us back. Will there be an immediate solution to this?

Hi @altafakhai - I think we just responded to your tweet as well. We do not have a simple mechanism to support search behind a firewall at this point. We are looking at options for v2. There is probably a way to embed a search feature on your custom pages, but that is not optimal, of course.
I believe that Algolia has an offline feature, but I have never used it and I don't think it would easily integrate in the current version of Docusaurus.
cc: @s-pace

👋 @altafakhai
You can use DocSearch on your internal network if you run it on your own. You will need to create your own configuration and then run it. We do not feature login so far but we are PR welcome. It is based on top of scrapy
You can inspire the configuration from the Docusarus's one.
Happy to help if you need anything else.

@s-pace I have a question.
If we run the scraper on our own, it will still push the the crawled results to the Algolia index (which is not our own network), and it's not "offline" search. Its just not requiring the website to be publicly accessible (as in to be crawled).
Is this correct ?

@endiliey Indeed.
You can still use algolia offline but regarding the use-case, it is what we will recommend.

Thank everyone provide so much suggests. Now i express my solution:

Generate the index.xml to root directory while build website.
Add search bar on website.
Search from index.xml when search bar text change.

Information for your reference.

Thanks for the help, @JoelMarcey @s-pace
I will try to work with DocSearch and see if we get the desired results. Will keep you all posted with the progress.
Eagerly waiting for v2. 😃

@sbansal3096 is planning to work on this either for v1 or v2.
@endiliey @yangshun - are we planning on offering a local search implementation for v2. Or just a pluggable infrastructure for search?

Just pluggable search box. I think he can try it on v1, the main implementation part is on building the docs index.

I think he can try it on v1, the main implementation part is on building the docs index.

@endiliey Do you mean he should only index *.md files and not worry about trying to index React pages, etc? If so, I think that is ok. I think @sbansal3096 should use an off the shelf indexer like lunr.js and run with that.

Any update on this?

Any update?  Currently looking at static site generators for documentation.  Like most things about Docusaurus except for the search.  This is a nice project :)

I have the same issue here on a Internal project and solve it with a server side search.
I would like to send a PR with this solution at some time. But Unfortunately I do not have time to do it right now. For now it is available in @the-darc/Docusaurus.

Just implemented your fix.  Looks good!!  Cheers.

+1 Local search would be an amazing addition. My use case is that I'd like to use Docusaurus for documentation hosted on an intranet and I can't pass any information to a third-party.

Same use case as @haslam22 for me.

Waiting for this feature to be implemented too!

... it's like being handed the keys to a Porsche .... with no engine :(

Any update on this? Or do I just have to build my own?
Thanks!

Just to set expectations, the Docusaurus core team won't be working on this anytime soon. Our priority is getting feature parity with Docusaurus v1.

Thanks for the quick reply @yangshun! So if I need to get local search running now is there a path you recommend? There are several options listed above but none of them seem to be really ready for primetime.

@JohnSeals
For what it's worth I got @the-darc's fork working for me with some modifications and it didn't take very long.
https://github.com/facebook/docusaurus/issues/776#issuecomment-480805342

@hatzopoulos I tried it here and got it working too. Thanks for the tip and thanks to @the-darc!

Great! @endiliey Can we merge it into v2.

@yanzhiwei147 Endi passed away last month 😔
@yangshun - is this something to be merged into v2?

I don't think we'll make this a core of v2 especially since we don't own the code. It could be left as a community-supported plugin.

I don't think we'll make this a core of v2 especially since we don't own the code. It could be left as a community-supported plugin.

@yangshun What can be possible problems if you make this a core feature? And what code are you talking about, the plugin or lunrjs?

As an alternative to lunsjs, I would like to suggest FlexSearch. It's super fast, less resource hungry and requires no dependencies. This can be turned into a plugin similar to @lelouch77's solution.

problem with the local full text solutions is the the index directly from the source code. This this makes them index unnecessary objects like comments, URLs, code snippets, etc. which add to the final index and look bad when someone searches through that. Algolia on the other hand indexes directly from the final build which removes all the unwanted elements.
What I'm trying to say is, if you need a proper local search, you need to first filter out the unnecessary elements from the raw markdown and then index it.
If you can implement this solution as a core feature in V2, this can be a very strong consideration point when choosing a documentation builder. Currently Docusaurus is behind Vuepress (personal opinion) because Vuepress at least supports native header search assisted by tags.

If Docusaurus got a native full-text search feature, that would be the best thing that happened to documentations. just saying

cc @slorber

since we don't own the code.

The fact that the plugin is built by the community. The scenario I'm afraid of here is that we require patches to the community plugin but the maintainer is no longer active, we would then have to fork the project in order to make updates to it. We might relax the stance here because we're using remark-admonitions now which likewise is built by the community.

If you can implement this solution as a core feature in V2, this can be a very strong consideration point when choosing a documentation builder.

What's wrong with using Algolia and why is there a need for local search? Is it because the docs are behind a VPN?

What's wrong with using Algolia

Nothing. Don't remove algolia. It's just that a local alternative would be super helpful.

why is there a need for local search?

For proprietary software documentation. The index is stored on the algolia servers which can be a problem if ever it gets breached, all the documentation will be public. Though that is a very narrow scenario.
Another case would be if the documentation is stored on a network totally cut off from the internet.
And it will help with PWAs as the index would be available offline.
This would also help beginners as docsearch denies indexing example projects. And not everyone publishes their test projects.
No other documentation builders have proper search other than the ones hosted on their servers. Docsify has a native search but it has the filtering problems I mentioned earlier.
I'm very new to programming in general so I don't really know about the problems that occur while maintaining such a project.

What's wrong with using Algolia and why is there a need for local search? Is it because the docs are behind a VPN?

The reason why I didn't want to use Algolia was mainly to avoid having to read through their terms of service and privacy policy to figure out if and what data they collect from visitors of my website when I load their JavaScript SDK and connect to their servers.

As an alternative to lunsjs, I would like to suggest FlexSearch. It's super fast, less resource hungry and requires no dependencies. This can be turned into a plugin similar to @lelouch77's solution.

Thank you for bringing up FlexSearch! This is certainly an interesting alternative. I will see if using that instead of lunrjs would work for my plugin.

Thanks to the comments on this issue, I have found many helpful links for local search with Docusaurus v2, but I am currently on v1 and curious if anyone can help me out there. Is anyone aware of any established patterns for using local search with Docusaurus v1?

@danforbes  - just curious, is there anything technical stopping you from moving to v2?

Just like general time commitments and stuff...this is something I would like to get taken care of in a week's time. Is migrating to v2 fairly straightforward? How much of an impact will it have on the look-and-feel of our site?

It is pretty quick and easy yes https://v2.docusaurus.io/docs/migrating-from-v1-to-v2/

Impact is neat with the new features such as dark mode and interactive code snippet

And you will soon have a new search UX like on https://docsearch.algolia.com/

@danforbes Yes, depending on the features your v1 site uses, it could be a straightforward conversion. We may have folks who might be able to help convert if you would like a pull request on it.

I have prepared a naive attempt based on the migration guide. At the moment, I'm getting some errors related to missing React dependencies, which I think may be related to some information I found on the migration guide. I'd appreciate any suggestions regarding the React issue as well as any general comments on the branch.

Thank you, @slorber! Are you able to add comments to this commit in GitHub?

Updated commit range, @slorber https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/compare/df/chore/upgrade

@slorber I've also created a draft PR https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/pull/563

I have the same issue here on a Internal project and solved it with a server side search using @weixsong/elasticlunr.js.
I would like to send a PR with this solution at some time. But Unfortunately I do not have time to do it right now. For now it is available in [@the-darc/Docusaurus](https://github.com/the-darc/Docusaurus

I am looking for local search support for Hindi language. Any suggestions or a sulution?

@dhitimedin  You can make use of this https://github.com/MihaiValentin/lunr-languages/pull/6

@ lelouch77 When I try to do that I get series of warning while installing a exception when I npm run swizzle docusaurus-lunr-search SearchBar.
Trace pasted below:
npm WARN deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
Component "SearchBar" doesn't exists. "SearchBar" is swizzled instead of "SearchBar".
Error: SearchBar is an internal component, and have a higher breaking change probability. If you want to swizzle it, use the "--danger" flag.

@dhitimedin Thats happens on version of dosucarus ... Try running npm run swizzle docusaurus-lunr-search SearchBar --- --danger Thanks

These swizzle error messages are tracked in https://github.com/facebook/docusaurus/issues/3408
It's definitively a bug but you should be able to swizzle using the --danger cli flag

Hi everyone, I just created https://github.com/easyops-cn/docusaurus-search-local, which is originally forked from cmfcmf/docusaurus-search-local, but later fully rewritten to reach our goal: up to date, maintainable, robustness, pretty look, and mostly language of Chinese supported. We have already using it in our production (but not public, that's why we need local search, : ).).

https://github.com/easyops-cn/docusaurus-search-local

Great! I will try right away. Does it support Hindi as a language?

Hi everyone, I just created https://github.com/easyops-cn/docusaurus-search-local, which is originally forked from cmfcmf/docusaurus-search-local, but later fully rewritten to reach our goal: up to date, maintainable, robustness, pretty look, and mostly language of Chinese supported. We have already using it in our production (but not public, that's why we need local search, : ).).

UI does not work properly on mobile.

@dhitimedin Hope it will help you. It currently supports all lunr-languages + Chinese, but Hindi is not in it yet.
I actually have not tested it with mobile devices. But it can be fixed easily by apply css media queries. I'll fix it later.

@dhitimedin Hope it will help you. It currently supports all lunr-languages + Chinese, but Hindi is not in it yet.
I actually have not tested it with mobile devices. But it can be fixed easily by apply css media queries. I'll fix it later.

Great! Would be helpful. My users use my site mostly from mobile. Do keep me posted on the steps required to rectify.

Hi everyone, I just created https://github.com/easyops-cn/docusaurus-search-local, which is originally forked from cmfcmf/docusaurus-search-local, but later fully rewritten to reach our goal: up to date, maintainable, robustness, pretty look, and mostly language of Chinese supported. We have already using it in our production (but not public, that's why we need local search, : ).).

Getting the following error while installing it:
node-pre-gyp WARN Using needle for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://github.com/yanyiwu/nodejieba/releases/download/2.4.1/nodejieba-v2.4.1-node-v72-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v72 ABI, unknown) (falling back to source compile with node-gyp)
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.
No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.
gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.5.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--module=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release/nodejieba.node" "--module_name=nodejieba" "--module_path=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release" "--napi_version=6" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v72"
gyp ERR! cwd /Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba
gyp ERR! node -v v12.18.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release/nodejieba.node --module_name=nodejieba --module_path=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release --napi_version=6 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
node-pre-gyp ERR! stack     at ChildProcess. (/Users/nishit/Documents/GitHub/docusaurus3/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
node-pre-gyp ERR! System Darwin 19.5.0
node-pre-gyp ERR! command "/usr/local/bin/node" "/Users/nishit/Documents/GitHub/docusaurus3/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba
node-pre-gyp ERR! node -v v12.18.0
node-pre-gyp ERR! node-pre-gyp -v v0.14.0
node-pre-gyp ERR! not ok
Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release/nodejieba.node --module_name=nodejieba --module_path=/Users/nishit/Documents/GitHub/docusaurus3/node_modules/nodejieba/build/Release --napi_version=6 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v72' (1)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/nishit/.npm/_logs/2020-10-21T08_08_50_492Z-debug.log

@dhitimedin I think this is not the right place to trouble shooting this error. Could you please fire an issue at easyops-cn/docusaurus-search-local?

@dhitimedin I just moved nodejieba from dependencies to peerDependencies (which is only required for language of zh), and a new version has published (v0.7.0), you can try it. It means that you will not get nodejieba installed by default, and the install error above would be no longer an issue.
For further questions, please fire issues at easyops-cn/docusaurus-search-local, thank you.

Any update on this issue?

Nope! I am working on something else these days.
On Thu, Aug 5, 2021 at 12:45 PM Sagar Patil @.***>
wrote:

Any update on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/docusaurus/issues/776#issuecomment-893225077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQKMOYASGFHRIBMRJZITB53T3I3CVANCNFSM4FFF3KJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

I have a working example of a local search here which uses flexsearch. It's similar to lunrjs
live demo https://staging.nodejs.dev/1677/
I'm not using docusaurus but it uses gatsby

My local storage works for english. You can check out the site here. https://dhitimedin.github.io/docusaurus3/en/welcome

Except that it does not work for Hindi

Closing because there are ample community plugins and there seems to be little interest to bring this into the main repo. If you find any problem working with packages like @easyops-cn/docusaurus-search-local or @cmfcmf/docusaurus-search-local, please report to their repos.


[stable/elastalert] Add support to custom SSL certificates

What this PR does / why we need it:
Add support to custom SSL certificates
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#7095
Special notes for your reviewer:
@jertel I hope it will help 👍

/ok-to-test

/assign @jertel

@sneko Looks like the commit needs to be signed off. See this link for more info: https://www.helm.sh/blog/helm-dco/index.html

@jertel yes sorry, I'm not used to it. Seems good now 😃

I signed it!

@jertel read somewhere earlier in the day that "I signed it!" comment would relaunch the check...
Since dco-labeler is pending, what does it need to be done?
Thanks

/lgtm

Thanks for your contribution @sneko, and for the chaart version bump. I noticed all recent PRs are lacking the "Contribution Allowed" label so the bot might be having trouble.

/lgtm


⚠ ClamAV has degraded performance

In 5b259b0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 46 ms

Resolved: ClamAV performance has improved in df39ac5 after 5 minutes.


Inbound chat messages have incorrect timestamps

Reports from @drwasho suggest that inbound chat messages are not reporting the correct timestamp on Android but working on iOS:
Sender (cloud)
[
    {
        "message": "Yo",
        "messageId": "QmQMwKQ3y2evxNzFEkmTkDn3NzUHbHcLUSfmKxszecvujd",
        "outgoing": true,
        "peerId": "QmXgC6fc99c65UAfJgVH1r4uFDQQ4bSDnNig79KgEwPmQy",
        "read": true,
        "subject": "",
        "timestamp": "2019-06-14T05:42:05.999483846Z"
    }
]

Recipient (Android)
[
  {
    "message": "Yo",
    "messageId": "QmQMwKQ3y2evxNzFEkmTkDn3NzUHbHcLUSfmKxszecvujd",
    "outgoing": false,
    "peerId": "QmVBbGn2yHsmUBtU6f6RAA1rGLrvXBGs6LqrevTBLXfBkR",
    "read": true,
    "subject": "",
    "timestamp": "1969-12-31T23:59:58.717372461Z"
  }
]

Recipient (iOS)
[
  {
    "message": "Yo",
    "messageId": "QmPrbSsDLQVmm3StZhaq5CqQpyCG9iQWrkc2iZPFRD2CJD",
    "outgoing": false,
    "peerId": "QmVBbGn2yHsmUBtU6f6RAA1rGLrvXBGs6LqrevTBLXfBkR",
    "read": false,
    "subject": "",
    "timestamp": "2019-06-14T16:18:56.725423+10:00"
  }
]

The mobile server on Android devices returns a timestamp field from GET /ob/chatmessages/:peerId and GET /ob/chatconversations.
Chat messages can be sent from a normal node to the recipient Android mobile server, which will convert it to the incorrect values above.

We believe the issue is related to Android build using the 32-bit APIs exposed by the gomobile framework as the issue appears specific to the produced build. Testing a 64-bit build is dependent on updating the react-native deps to a more recent version. The mobile team is attempting to produce a 64bit build to confirm. Will hold on this issue until more information becomes available.

Resolved by #1549


Theme update for ghostwriter 2.x

The update of ghostwriter to version 2.0.0 broke the Dracula theme. This PR adds the new theme in JSON format, new screenshots as well as updated installation instructions.

@zenorocha Please consider updating the website at times to show the updated installation instructions.

FYI - The website has been updated @totoroot


Fix builds with no-dh

The various functions in bn_const.c return primes that are
specified for use in DH. However they were not being excluded from
a no-dh build - and was therefore causing the build to fail.

Hmm is there a build that does no-dsa and no-dh together..
It looks like hextobn also needs to be #ifdefed if they are both not defined
Hmmm well at least this one is a simple breakage..
As this is happening quite a lot - so dont you think it would be worth running a travis build with a whole lot of -no options so this stops happening (not as part of extended tests).
We should also enable tracing on one of the builds (I tried to before but it was shot down due to speed of build reasons). The counter argument is that it saves us (you) time.

It looks like hextobn also needs to be #ifdefed if they are both not defined in fipsprov.c

Fixed

Ping.

Can we get a list together of all the hex converters and make an attempt to unify them?

Probably this should have been labelled as "urgent" as we have done with the other run-checker break fixing PRs. I have done so now, but won't immediately merge in case of objections. I will merge later.

(It would be good to get confirmation from either @levitte or @t-j-h that you agree with the urgent label)

I don't see a need to mark any of the current PRs that are marked with "urgent" as urgent as none of them are urgent in the sense of the definition of the word. I don't see a need to bypass the normal 24-hour wait period.
If you overuse an exception process then it looses the exception feel.
Also the label changes don't go out in email notification - so it would be best to do a comment like you have noting you added that label in case others want to object - although the concept of urgent means bypass the wait so that you are indicating waiting is okay in this context it really doesn't make sense to actually use. At least that is the logic chain as I read through all these "urgent" items.

I don't see a need to mark any of the current PRs that are marked with "urgent" as urgent as none of them are urgent in the sense of the definition of the word. I don't see a need to bypass the normal 24-hour wait period.

These are build breaks that break our run-checker builds - which we should be seeking to keep clean (in much the same was as with Travis).

Also the label changes don't go out in email notification - so it would be best to do a comment like you have noting you added that label in case others want to object - although the concept of urgent means bypass the wait so that you are indicating waiting is okay in this context it really doesn't make sense to actually use. At least that is the logic chain as I read through all these "urgent" items.

The difference is "short wait" vs "long wait". In the case of an urgent label I would expect at least one other person to agree to it, and no one to object to it. Ideally the urgent label should be applied at the time the PR is created so that the reviewer can implicitly agree to it during the review. In this case that didn't occur, so I added it later and asked for  someone else to take a look and agree to it.
For now I will hold off on applying any of the PRs labelled as urgent since you have objected to it - although that will likely delay the time it will take to get run-checker clean again. It seems OTC (or is it OMC?) should issue more detailed guidance on how to interpret the build/test break 24-hour exception since there appears to be a difference of opinion here.

Pushed. Thanks.


chore: bdd-sbhg-1586004939 to 0.0.1

chore: Promote bdd-sbhg-1586004939 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Investigate modularizing brunch even further

Concat, module wrapping, etc could all be on-by-default plugins

To make it possible, we'll have to thoroughly think of and add several new API methods.
Somewhat of a concern would be inter-plugin dependencies and interaction, as deppack directly needs our default module wrapping, and the module wrapper hooks into deppack.
A plugin architecture therefore needs to be flexible enough to allow this, and not break anything.


Kivymd not working in APK and kivy launcher

Kivy MD not working after converting as APK and in kivy launcjer

@Aathithiya The question is completely incomprehensible.

I have tried the process of converting kivymd and I have successfully made the apk file, but when I upload the apk file to my phone, It just blink a white empty screen for once then exit the app, why does this happen to kivymd?

@Aathithiya adb logcat | grep python


Provide more precise error when querying cosmos against a nonexistent cluster

Host that isn't running DCOS:
$ dcos config set core.dcos_url http://example.com
[core.dcos_url]: changed from 'http://pool-cae8-elasticl-1op07zlyuov6s-277026749.us-west-2.elb.amazonaws.com/' to 'http://example.com'
$ dcos package repo list
This version of the dcos-cli is unsupported for your DCOS cluster. Please use a dcos-cli version < 0.4.0 or upgrade your cluster to DCOS version >= 1.6.1
$ dcos package repo add foo http://foo.com
This version of the dcos-cli is unsupported for your DCOS cluster. Please use a dcos-cli version < 0.4.0 or upgrade your cluster to DCOS version >= 1.6.1
Host that doesn't resolve:
$ dcos config set core.dcos_url http://onstuhoesntuhoesunthoeusntoeusntoe
[core.dcos_url]: set to 'http://onstuhoesntuhoesunthoeusntoeusntoe'
$ dcos package repo list
This version of the dcos-cli is unsupported for your DCOS cluster. Please use a dcos-cli version < 0.4.0 or upgrade your cluster to DCOS version >= 1.6.1
$ dcos package repo add foo http://foo.com
This version of the dcos-cli is unsupported for your DCOS cluster. Please use a dcos-cli version < 0.4.0 or upgrade your cluster to DCOS version >= 1.6.1
Could either:

Have more precise error detection in these cases, providing a different message when they occur.
Failing that, add a clause to existing error message saying e.g. "or set core.dcos_url to something else"

At that point, we'd have to verify that the url is actually for a DCOS cluster.


CLI/Lib Refactor

Motive
Currently there is not enough seperation between the implementation of parts within TSTL. While TSTL does offer a library-like interface this is mostly incidental. TSTL was originally designed with command-line usage in mind.
Objective
Let's identify and discuss changes that will strengthen a separation of concerns between the core implementation, and those bits which implement the CLI

Core: Everything to do with the business of transpilation
CLI: Everything to do with translating command-line arguments and execution environment (variables) into parametric calls into core and reporting issues back to users through stderr/logging, etc.

Currently Identified Issues
Core Catches Exceptions
Currently there are core-ish routines which catch and handle exceptions on behalf of the CLI use-case. This is problematic for library use-cases wherein those errors need to be handled specifically by calling code.
Cases:
https://github.com/Perryvw/TypescriptToLua/blob/master/src/LuaTranspiler.ts#L115
Core Interacts With Process
Core routines should not be in the business of doing things like calling process.exit or participating in any other process management such as watchers.
Cases:
https://github.com/Perryvw/TypescriptToLua/blob/master/src/LuaTranspiler.ts#L49
Reporting
The core should never directly utilize functions like console.log to report information to the user. Instead the core should return structured information to the caller. TSTL's CLI can interpret and format this information for outputting to the console or any other log destination. Similiarly, library users can handle reporting in the way that makes sense in the context of each use-case (such as IDE extensions).
Cases:
https://github.com/Perryvw/TypescriptToLua/blob/master/src/LuaTranspiler.ts#L147
https://github.com/Perryvw/TypescriptToLua/blob/master/src/LuaTranspiler.ts#L149
Core Parametricity
Core routines should take in all of their configuration through parameter arguments and should never reach out to the environment or depend on configuration files. The CLI should be responsible for translating configuration artifacts, environment variables and commnand-line arguments into the correct core routine arguments.

duplicate of #371 closing #371 because this one is more detailed

Totally agree on the first two points, especially since this seems to be done purely for CLI reasons. That should be a relatively small change. I am currently having my doubts if reportErrors belongs in the transpiler at all, will think about that a little.
The last point about core parameters seems pretty vague, it would be nice to make this a bit more concrete.
One thing I did run into was LuaTranspiler always grabbing options from the program parameter at: https://github.com/Perryvw/TypescriptToLua/blob/master/src/LuaTranspiler.ts#L22
A better solution is probably to add an optional options argument to the constructor, and falling back on program.getOptions() when the constructor argument is omitted.

The last point about core parameters seems pretty vague

For sure. I remember when working with the code there was at some point some option that was being taken from somewhere I couldn't directly affect as the caller into that code. But I can't remember exactly what it was... If I end up not being able to remember I'll go ahead and remove this item. Though, it is actually a good principle to "have the board" so to speak as it it is in the spirit of the overall issue.

I updated the issue description with a new section Core Should Be Easily Composed to demonstrate the overal aesthetic(?) or intention behind the changes. There is some example code which shows what the basic use of TSTL would look like from a library use-case perspective. But this is also what the CLI implementation could also look like. I think it hints at a very easy to write beginner's tutorial as well.

One thing I did run into was LuaTranspiler always grabbing options from the program parameter

@Perryvw Assume we grow a module which is focused just on dealing with TS. That is, instantiating a ts.Program and then providing the resulting SourceFiles back to the caller of our module. Is there an argument that we should hide TS completely within the implementation of that module and not expose it as part of the API of the TSTL module itself? I think the complication with the seperation of concerns here is the -p flag and how TS can get some of it's options from tsconfig.json and if it does, then TSTL doesn't know about them -- that's why TSTL has to get the options from the ts.Program. As long as we allow TS to utilize tsconfig.json vs loading tsconfig.json ourselves and passing options to TS manually, we'll always have this sort of shared authority over what the actual options in play are. I'm not sure it's worth the effort to do that unless tsconfig.json options are named the same as their CLI flags or something in which case it would actually be trivial to go that route. Thoughts?

It depends on what we settle on for the rest of the API. I think it is strange we pack options into ts.Program and then immediately unpack it again. I would like to keep open the possibility of calling the same transpilation process with different options, or overriding the default options.
Arguably this is already possible with compileWithOptions, but the way in which seems a little awkward to me. Like I said this also kind of relies on what we do with the rest of the API, so I think we revisit this once that is clearer.

As a recap of yesterday's discussion on Discord, the current setup for building a tstl pipeline in user code would be:
const fileNames = [];
const options = {};

const program = ts.createProgram(fileNames, options);
const transformer = new LuaTransformer(program, options);
const printer = new LuaPrinter(options);

for (const sourceFile of program.getSourceFiles())
{
    const [luaAST, luaLibSettings] = transformer.transformSourceFile(sourceFile);

    const lua = printer.print(luaAST, luaLibSettings);
    writeFileSync(sourceFile.fileName.replace(".ts", ".lua"), lua);
}

This looks fine to me, except that we might be missing a way to load a project and tsconfig. So we should make sure every component here is exported, as well as all the components required to implement an extension of LuaTransformer or LuaPrinter.
Then the one thing I am not entirely sure about is how and from where we are going to expose the project or tsconfig reading.

In my experimental fork, I have created new module Parser.ts which hides ts module completely from the user. You pass the filename of the tsconfig.json and it uses the ts compiler routines to load the tsconfig.json into a CompilerOptions and uses that to create the Program.
This way tstl is the configuration authority and ts is just an implementation detail users don't need to know anything about. I know we talked about it on Discord, but I prefer it much more.


fix import of oidcreducer

Change the way reducers are imported to enable AoT in importing projects
See Issue 250 in NgRx


Following azure-simple getting started documentation produces an error

Description
The following set of commands:
export TF_VAR_remote_state_account=...
export TF_VAR_remote_state_container=...
export ARM_ACCESS_KEY=...

$ terraform init -backend-config "storage_account_name=${TF_VAR_remote_state_account}" -backend-config "container_name=${TF_VAR_remote_state_container}"
$ terraform plan

Produces the following error:
Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

data.azurerm_client_config.current: Refreshing state...
data.azurerm_client_config.current: Refreshing state...

------------------------------------------------------------------------

Error: Error running plan: 3 error(s) occurred:

* module.keyvault.output.keyvault_id: Resource 'azurerm_key_vault.keyvault' not found for variable 'azurerm_key_vault.keyvault.id'
* module.keyvault.output.keyvault_uri: Resource 'azurerm_key_vault.keyvault' not found for variable 'azurerm_key_vault.keyvault.vault_uri'
* module.keyvault.output.keyvault_name: Resource 'azurerm_key_vault.keyvault' not found for variable 'azurerm_key_vault.keyvault.name'

Acceptance Criteria
Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

[ ] Should ‹testable condition that should be satisfied›
[ ] Should ‹testable condition that should be satisfied›
[ ] …

Also, here are a few points that need to be addressed:

Constraint 1;
Constraint 2;
Constraint 3.

Resources
Technical Design Document
Mockups
Tasks
Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)
Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)
Assignee should break down work into tasks here

Thanks for making this official!
Git Bash vs WSL issue?
Within Git Bash, I ran into the same error. However, within WSL I was able to overcome the error with a fresh install of Terraform and Go.  Still can't say for sure that the issue is shell based. We'll have to do a bit more testing before updating the README and closing this out .
For both shells, I was logged in as a service-principal within the AZ CLI using Terraform v.0.11.13 and Go v.1.11.

@TechnicallyWilliams I am on WSL and have the same issues that you see in gitbash.
I'm wondering if your fresh install is contributing to some environment-level changes. I'll deep dive on this today.
Thanks for the added context

@TechnicallyWilliams I have made a breakthrough in debugging...
I had been running the following:
. ../../../.env
Which would essentially execute a series of:
FOO=BAR

I found, though, that this method of setting variables does not make the variables available to sub-processes (https://stackoverflow.com/questions/1158091/defining-a-variable-with-or-without-export) so the variables were not available to any terraform child processes.
The solution can be scripted easily. I'll find a 1-liner that we can add to the README.md file.

$ DOT_ENV=<path to your .env file>
$ export $(cat $DOT_ENV | xargs)

Will update README

https://github.com/microsoft/cobalt/pull/148


Make possible to connect to urls that direct to .pls and .m3u files.

Many radio stations URLs on the web direct to the .pls and .m3u files which are playlist files instead of direct URLs to streams.
More in it on:
https://en.wikipedia.org/wiki/PLS_(file_format)
https://en.wikipedia.org/wiki/M3U
Currently only direct URLs are working.

Added support in #29 pull request.


Historic England: Public Sector APIs

Please fill in the following information:
Base URL:
The URL for the API. For example, https://www.gov.uk/api/content. Please limit this to one URL - if you have sandbox environments or multiple endpoints please add them to the description.
Name:
The name of the API. For example, Gov.uk Content.
Description:
The description of what the API is about. Please make this as detailed as possible to help users search. For example "GOV.UK Content API makes it easy to access the data used to render content on https://www.gov.uk. For any page hosted on GOV.UK you can use the path to access the content and associated metadata for a page."
Documentation URL:
The URL for the API documentation. For example https://content-api.publishing.service.gov.uk/
Maintainer:
Contact details for the team who manage the API, and who will be the first point of contact for a user wishing to access the service. Please don't use an individual's email address.
Provider:
The full name of the department or organisation who provide the API. For example 'Government Digital Service'.
Area Served:
Optional - The geographic area that the API serves. For example: 'Greater London'.
Start Date:
Optional - The date the API comes into service. For example: '2020-07-01'.
End Date:
Optional - The date the API will be retired. For example: '2022-07-01'.
Alternate Name:
Optional - the acronym of the department or organisation. For example: 'GDS'.
Provider URL:
Optional - the canonical URL of the website of the department or organisation. For example: 'https://www.gov.uk/government/organisations/government-digital-service'.
If you have multiple APIs to add, you can use a CSV template with these fields which is available at: https://raw.githubusercontent.com/co-cddo/api-catalogue/HEAD/data/apic-csvtemplate.csv
Optionally, if you have more information you want to share with the API Catalogue community, please add it below.

Public Sector APIs - Historic England.csv

@davidthames Please feel free to reopen this if you spot any issues with the deployed code.


[sync2] Tiny test extension for more consistency

sleep make sense.  the Increment triggers a condition bcast, but does not yield context to other goroutines

Cool, thanks for the explanation and quick merge!


feat(carousel): automatic hiding of navigation buttons when the first…

feat(carousel): automatic hiding of navigation buttons when the first or last image is active
Added 'autoHideControls' feature to ImageSlider for intuitive navigation button visibility.

[x] I have followed the Your First Code Contribution section of the Contributing guide

Gives a nice touch for UX when not needing to move from last image to first one.
Conditional rendering of carousel controls when autoHideControls is true.
https://github.com/themesberg/flowbite-react/assets/36115659/87521d58-b0b4-4d34-bd78-d59b950d10a7
fixes #1205
New optional prop added to Carousel component: autoHideControls with false as default value.
Example:

I like this idea and solution a lot, but like you said, it's not in the vanilla library so we probably shouldn't add it. @zoltanszogyenyi What do you think here? This PR looks good if we want it.


Add the ability to edit the YAML of a Kubernetes resource

We should provide the ability to edit the YAML of a Kubernetes resource for administrator users.
Required changes
Impacted views:

[ ] Resource pool details
[ ] Application details
[ ] Configuration details
[ ] Volume details
[ ] Node details

YAML panel

[ ] Remove the read-only constraint on the YAML editor for administrator users
[ ] Introduce a new action "Update the " next to the Copy to clipboard action (resource being named from the currently managed resource: Update the resource pool, update the node...)

Is there any news on this?

@quantumsheep we're thinking about introducing the ability to use Kubectl directly in the Portainer UI (which would in turn allow you to kubectl edit) as a first mean to achieve this.
We're currently working on this and I'll post a preview image when we have something available to see if that would accomodate users with the need to edit the YAML.

we're thinking about introducing the ability to use Kubectl directly in the Portainer UI

@deviantony that would be great! Can you ping me or reference this issue when it's ready? I would gladly test the feature :)

@quantumsheep great to hear! I'll keep you posted.

We've gone with the approach of introducing the ability to use Kubernetes CLI directly in Portainer.

We are aiming to introduce editing of YAML (and applying of the changes) in EE-2.17 (under ticket EE-2855).


fix: do not use pat secret

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.852%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
437

Relevant Lines:
481

💛  - Coveralls


[#110] Add pre-baked 4.3.0/4.2.11 release images

The pre-baked images, once built, are set up once when the image is run as a container and then is completely restartable. The packages are installed at build time and they will never move because the packages have already been released.
4.3.0 images are based on ubuntu:20.04 and postgres:12.
4.2.11 images are based on ubuntu:18.04 and postgres:10.12.

The following still needs to be done:

Names for the projects
Additional supported platforms
Integrate with stand_it_up.py, run_plugin_tests.py, etc.

In service of #110

Very nice.

I'll open another PR when this concept is more solid. This approach is definitely not the right way to go for this, so I'm going to close this.


Windows installer breaks PSModulePath

I have a number of user-scope modules installed in ~/Documents/WindowsPowerShell/Modules, which is in the PSModulePath by default. After installing via the windows installer, under user variables, my PSModulePath was set to ;C:\Users\justin\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell (note the leading ;, which looks like a failed attempt to append to the existing path), which caused the default path to not be searched, and my modules to all fail to import. This was a simple fix once I had figured out what was going on, but it took some time to discover.

@justinian, thanks for reporting the bug. Do you mean that the installer remove ~/Documents/WindowsPowerShell/Modules from the path too?

I'm actually not sure of the original value, it might have been empty, or it may have contained the default value. According to this MSDN article:

When Windows PowerShell starts, PSModulePath is created as a system environment variable with the
following default value: $home\Documents\WindowsPowerShell\Modules; $pshome\Modules.)

I'm not sure if that means the permanent settings are updated the first time PowerShell runs, or if this is the default if PowerShell is started without a PSModulePath set. I have not explicitly set the variable myself.
However, I do see that the system-wide setting is correct, and had the SDK path properly appended:
%ProgramFiles(x86)%\WindowsPowerShell\Modules;%SystemRoot%\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell

@justinian, that's interesting. I wasn't able to repro this on my machine by installing the SDK for a specific user. Can I ask do you have this problem when you install it system-wide?

(Sorry for the late reply!) I believe I installed it system-wide previously since both the user and system paths were modified. Testing on another machine system-wide, I see that it only touched my system-wide PSModulePath and it looks correct, so ¯\_(ツ)_/¯

I have also experienced that it overwrites the PSModulePath environment variable. This is highly annoying.

Same thing happened to me today.

It seems like the issue happens if the PSModulePath for User is empty initially. We are fixing this in the next cloud SDK release.

@quoctruong I'm glad this will be fixed -- this caused a problem for me with the latest PowerShell 7 preview (and probably in the final release): PowerShell/PowerShell#11172

@deisner This should already be fixed with the latest version of the Google Cloud SDK.

@quoctruong I start out with a PSModulePath environment variable set in the machine scope, but not set at all in the user scope.  After installation, PSModulePath is set in the user scope, to this:
C:\Users\david>set psmodulepath
PSModulePath=C:\Users\david\Documents\WindowsPowerShell\Modules;C:\Users\david\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell

Is this the intended behavior? This is on Windows 10 Enterprise 1909, by the way.

What is the version of your Google Cloud SDK?

C:\Users\david\AppData\Local\Google\Cloud SDK>gcloud version
Google Cloud SDK 272.0.0
bq 2.0.50
core 2019.11.16
gsutil 4.46

I should add that the new behavior of PowerShell 7 preview.6 might be under review -- arguably the user and machine PSModulePath environment variables should be concatenated (or kept concatenated) by PowerShell, which was the previous behavior. See https://github.com/PowerShell/PowerShell/issues/11172#issuecomment-558883569.

I see. So you are using PowerShell 7 in this case? Is it possible to test it under PowerShell 6?

I am using PowerShell 7-preview.6. There was no problem with PowerShell 7-preview.5 or earlier. I just installed PowerShell 6.22, and my PSModulePath looks like this:
PS C:\Users\david> $env:PSModulePath -split ';'
C:\Users\david\Documents\PowerShell\Modules
C:\Program Files\PowerShell\Modules
c:\program files\powershell\6\Modules
C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules

... while in PowerShell 7.0.0-preview.6 it looks like this:
PS C:\Users\david> $env:PSModulePath -split ';'
C:\Users\david\Documents\PowerShell\Modules
C:\Program Files\PowerShell\Modules
c:\program files\powershell\7-preview\Modules
C:\Users\david\Documents\WindowsPowerShell\Modules
C:\Users\david\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell

... and (after uninstalling PS7-preview.6 and re-installing PS7-preview.5), in Powershell 7.0.0-preview.5 it looks like this:
PS C:\Users\david> $env:PSModulePath -split ';'
C:\Users\david\Documents\PowerShell\Modules
C:\Program Files\PowerShell\Modules
c:\program files\powershell\7-preview\Modules
C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules

And, for completeness, here's PowerShell 5.1:
PS C:\Users\david> $env:PSModulePath -split ';'
C:\Users\david\Documents\WindowsPowerShell\Modules
C:\Users\david\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell
C:\Program Files\WindowsPowerShell\Modules
C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\
C:\Program Files (x86)\Microsoft SQL Server\120\Tools\PowerShell\Modules\
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\Sequencer\AppvPkgConverter
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\Sequencer\AppvSequencer
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\

My User PSModulePath environment variable:
%HomeDrive%%HomePath%\Documents\WindowsPowerShell\Modules
C:\Users\david\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell

and finally, my System PSModulePath is
%SystemRoot%\system32\WindowsPowerShell\v1.0\Modules\
C:\Program Files (x86)\Microsoft SQL Server\120\Tools\PowerShell\Modules\
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\Sequencer\AppvPkgConverter
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\Sequencer\AppvSequencer
C:\Program Files (x86)\Windows Kits\10\Microsoft Application Virtualization\

@deisner So what did the Cloud SDK installation do to your PSModulePath?

Just to save time: regarding my previous comment

I should add that the new behavior of PowerShell 7 preview.6 might be under review

It looks like this is indeed a problem with PS7-preview.6, and that the behavior will be fixed: https://github.com/PowerShell/PowerShell/issues/11172#issuecomment-561887323
In short, I don't think it's not a Cloud SDK issue.

I got this problem (my PSModulePath is broken) and actually, I need to use SDK and some modules that are getting fail to import.
Sorry, but I'm a little bit beginner with this, so how I can fix that? To continue to use SDK and my modules.
I mean, how can I get back the PSModulePath working again?


rust: Generated resource bindings can conflict with resource methods

package repro:pkg;
world example {
  resource repro {
    constructor();
    handle: func();
  }
}

generates two conflicting Repro::handle methods; one #[doc(hidden)] internal method and the actual resource method. Same would presumably be true for take_handle and (static) from_handle.

Oops, thanks! For purely internal functions we should probably rename them to _foo or similar, but otherwise we'll probably need to "mangle" WIT-based names that conflict.

Do they need to be methods? Could they just be regular (associated) functions?

Good point yeah, doc(hidden) items can also be associated functions. Using _ as a prefix for those I think would also be reasonable

I guess bindgen will never generate a _ prefix so it doesn't really matter :shrug:


New model support: Qwen

Added support for the online Qwen model, enabling the use of Alibaba Cloud's latest model Qwen-max.

Support for online Qwen has been completed. There is a certain amount of free credit for new registrations. If changes are needed, I will refer to the suggestions for further changes

Cool I heard Minty from the discord discussing this model. I'll definitely mess around with it soon

need more test，and will add tools support.

JurassikLizard said he will add a !wiki directive, I think I don't need to add separate networking tools in the api for Qwen at the moment.

that's all.If there are bugs I will try to fix the code O.o

JurassikLizard said he will add a !wiki directive, I think I don't need to add separate networking tools in the api for Qwen at the moment.

Which networking tools where you thinking of using?

Sorry, I didn't find any new reply after the PR merger.

looks good, though I haven't been able to test it because my api key is unauthorized.

Sorry, I didn't find any new reply after the PR merger. Did you get Qwen's api key but can't use it? If you want to test, I can provide you with a certain amount of key. I can help you if you want your own key.

JurassikLizard said he will add a !wiki directive, I think I don't need to add separate networking tools in the api for Qwen at the moment.

Which networking tools where you thinking of using?
Edit: Wiki command is working, but I need to finalize it more to be able to have a feature PR.

I was going to join a simple crawler that uses request to crawl wiki pages to get relevant content. Then give qwen the right to use the tool function. But then think about it, this should be like you said add '! wiki 'directive, used for all models. You are right bro.


small typo

Challenge http://freecodecamp.com/challenges/waypoint-build-javascript-objects has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
represents should be represent

I have submitted a pull request for this

So we can close this @natac13 ?

You bet @iheartkode

Or am I suppose to do something and I am missing the point here lol?

Lol, I think @LookOnTheBrightSide needs to close it :)  My bad!


[SCB-509] Update jackson's version to 2.9.5

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage remained the same at 87.41% when pulling a7beae51146d5de495dd92804f0f73d8685b36b0 on xuyiyun0929:upgradeJackson into 8a5b9721374e36777376e5d0877adf072da7ea9a on apache:master.


[tensor] ColoTensor supports lazy init

# init a tensor without storage, x is freed
x = ColoTensor(torch.rand(5, 5), lazy_init=True)
# alloc memory for a freed tensor
x.malloc()
# free it again
x.free()
# check whether it's freed
print(x.is_freed)

Tensor's shape, device and dtype won't change after free()/malloc().
A freed tensor cannot take part in computation and communication

Explicitly calling malloc and free can not be named as lazy!
Lazy means when you use it, you implicitly allocate memory for it.
Such API is not user-friendly.

Explicitly calling malloc and free can not be named as lazy! Lazy means when you use it, you implicitly allocate memory for it. Such API is not user-friendly.

We can do this by allocate memory in torch_function, however, the weight initialization is still a problem.


⚠ Spryr has degraded performance

In e51520a, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4997 ms

Resolved: Spryr performance has improved in 25169f1 after 9 minutes.


Potential issue in TD3-BC BC loss calculation.

Hi,
I found a potential issue when using the TD3-BC agent in offline RL.
The question is about the following line.
https://github.com/deepmind/acme/blob/8fbc176ed4b31f869bc468bbbfbd1258ac8f324f/acme/agents/jax/td3/learning.py#L118
It seems that bc_loss is reduced with jnp.mean before adding to the dpg_loss, but the dpg_loss itself not reduced over the batch yet.
https://github.com/deepmind/acme/blob/8fbc176ed4b31f869bc468bbbfbd1258ac8f324f/acme/agents/jax/td3/learning.py#L114
Shouldn't this be
dq_da = grad_critic(critic_params, transition.observation, action)
batch_dpg_learning = jax.vmap(rlax.dpg_loss, in_axes=(0, 0))
loss = jnp.mean(batch_dpg_learning(action, dq_da)) # Reduce over the batch.
if bc_alpha is not None:
  # BC regularization for offline RL
  bc_factor = jax.lax.stop_gradient(bc_alpha / jnp.mean(jnp.abs(dq_da)))
  loss += jnp.mean(jnp.square(action - transition.action)) / bc_factor
return loss # loss already reduced over the batch to dropping the jnp.mean.

Hi @ethanluoyc, thanks for the finding!
If I understand correctly, you suggest to replace jnp.mean(loss + jnp.mean(bc_loss)) by jnp.mean(loss) + jnp.mean(bc_loss).
It won't change the behaviour of the code (the mean operator being linear), but we may get a tiny gain in avoiding the broadcasting, so it is worth to make that change. Thanks!

Oh, that however is an actual bug:
I used dq_da as it was the critic, and actually it's the gradient of the critic loss.
It indeed explains why I needed different values for alpha to make it work.
It's interesting that it worked as well (reproducing similar results)!
Thanks a lot for your careful review, I will correct it!


[SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r)

What changes were proposed in this pull request?
The implementation of TimeSub for the operation of timestamp subtracting interval is almost repetitive with TimeAdd. We can replace it with TimeAdd(l, -r) since there are equivalent.
Suggestion from https://github.com/apache/spark/pull/28310#discussion_r414259239
Besides, the Coercion rules for TimeAdd/TimeSub(date, interval) are useless anymore, so remove them in this PR since they are touched in this PR.
Why are the changes needed?
remove redundant and useless code for easy maintenance
Does this PR introduce any user-facing change?

Yes, the SQL string of datetime - interval become datetime + (- interval)
How was this patch tested?

modified existing unit tests.

Test build #121946 has started for PR 28381 at commit 17b0438.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26622/
Test PASSed.

Test build #121946 has finished for PR 28381 at commit 17b0438.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121946/
Test FAILed.

retest this please

Test build #121960 has started for PR 28381 at commit 17b0438.

cc @cloud-fan, please also notice that the flakiness of CliSuite is still there according the test failure above.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26635/
Test PASSed.

Test build #121960 has finished for PR 28381 at commit 17b0438.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121960/
Test FAILed.

retest this please

Test build #121972 has started for PR 28381 at commit 17b0438.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26647/
Test PASSed.

Test build #121972 has finished for PR 28381 at commit 17b0438.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121972/
Test PASSed.

thanks, merging to master!


Fixed the problem where indentation is reset to zero up when formatting ...

Fixed issue #69: Indentation is reset to zero when formatting a selected range that have non-zero indentation.

Selected text after replacement not fully working, canceling pull request.


Issues with create_backup()

I am using a Raspberry pi as my Unifi controller(version atag_6.0.45_14358), and I am trying to take backup of it.
I get the error message:
Exception has occurred: IndexError
list index out of range
File "C:\Users\mabor\OneDrive - IT Relation\Skrivebord\Python\Private\Unifi\UnifiAP.py", line 31, in
CreateBackup=c.create_backup()
This is basically my code(edited to remove unneeded things and passwords and so on):
from future import print_function
import argparse
import time
from collections import defaultdict
from pyunifi.controller import Controller
ControllerIP="<IP_ADDRESS>"
Username=""
Password=""
Port="8443" #Management port, default is 8443
Version="v5" #Default version is v5
Siteid="default" #Default siteID in Unifi
c = Controller(ControllerIP, Username, Password, Port, Version, Siteid ,ssl_verify = False)
CreateBackup=c.create_backup()
time.sleep(15)
print(CreateBackup)
Backup=c.get_backup(CreateBackup)
print(Backup)
I got it to work by editing the function create_backup().
Before I started:
def create_backup(self, days='0'):
"""Ask controller to create a backup archive file
    ..warning:
        This process puts significant load on the controller
        and may render it partially unresponsive for other requests.

    :param days: metrics of the last x days will be added to the backup.
        '-1' backup all metrics. '0' backup only the configuration.
    :return: URL path to backup file
    """
    res = self._run_command('backup', mgr='system', params={'days': days})
    return res[0]['url']

I changed mgr='system" to mgr='backup' and then it worked. This seems to be due to the fact that run_command uses the mgr in its API call.
I installed pyunifi using pip install pyunifi on my windows machine. I use pyunifi version
pyunifi==2.20.1

Yep.  That is an issue.  Good catch.  I will work on getting a release out that has the mgr updated to equal 'backup'.
Thanks!


Move all compile-time errors to CompileTimeErrorCode

See https://github.com/dart-lang/sdk/issues/42787#issuecomment-662269577 for the context.
We are lying about the kind of the diagnostics, and people try to depend on it.

Yes, this would be great. I'll work around in the in the meantime in the test runner.

Done.
We have only a handful of items left in StaticWarningCode.


Mobile estimation?

It would be helpful to be able to estimate using a mobile device. Is mobile estimation possible with this extension? Thus far it seems that we'd have to switch to desktop mode on the mobile browser, which has difficulties.
If it's not built in, are there workarounds? For example, direct links to estimation sessions.

I played with this a while ago but haven't gotten to it yet:

@cschleiden Looks nice! Is this just a preview?
Currently not very usable on mobile 😕


Error with daily insiders update

VSCode Version: Insiders 1.46.0
OS Version: Windows 10 1909

Steps to Reproduce:

Install in background

Error Log
May 19 08:40:34.752 INFO Starting: C:\Program Files\Microsoft Code OSS\Code - OSS.exe, true
May 19 08:40:34.755 ERRO Bad arguments: Code path doesn't seem to exist: C:\Program Files\Microsoft Code OSS\Code - OSS.exe

Does this issue occur when all extensions are disabled?: Yes/No

Microsoft code OSS?
for the insiders, I could not download/install the update. so I downloaded the latest insiders build and tried to install and I get this message

I thought maybe last time downloaded a 32-bit installer and installed, so I uninstalled both code oss and vs code insiders. tried the latest code insiders install (which is now Microsoft code oss?) made sure I am downloading 64bit version twice, and after installation, there are no old extensions and not even the setting sync option.
tried to download and install the vscode insider and got the

message again.
not sure what is happening.
this is the code version i am on currently

Same

Log:
May 19 11:01:46.613 INFO Starting: C:\Users\Admin\AppData\Local\Programs\Microsoft Code OSS\Code - OSS.exe, true
May 19 11:01:46.615 ERRO Bad arguments: Code path doesn't seem to exist: C:\Users\Admin\AppData\Local\Programs\Microsoft Code OSS\Code - OSS.exe

Same

Log:
May 19 11:01:46.613 INFO Starting: C:\Users\Admin\AppData\Local\Programs\Microsoft Code OSS\Code - OSS.exe, true
May 19 11:01:46.615 ERRO Bad arguments: Code path doesn't seem to exist: C:\Users\Admin\AppData\Local\Programs\Microsoft Code OSS\Code - OSS.exe

i got this error too

duplicate https://github.com/microsoft/vscode/issues/98146

duplicate https://github.com/microsoft/vscode/issues/98147

Looks like release channels for Insiders and OSS got mixed.

the repository itself is showing Microsoft code OSS, is this new? or I am just finding it out now ?

Pretty sure the repo has always said it like that. Code - OSS is the open-source application, VSCode is that + Microsoft-specific additions.

Also control panel/program report a new install of vscode (non-insider) after updater runs

duplicate https://github.com/microsoft/vscode/issues/98149

duplicate https://github.com/microsoft/vscode/issues/98150

Hi, we acknowledge this issue and are working on a fix at the moment.
Unfortunetly since the update is broken you will have to manually download the latest insiders version from our website. You can do that right now:
https://code.visualstudio.com/insiders/
Thank you very much for using insiders and we appologize for this issue.
I will pin this so more users see it.

Fix is in, builds are running, let's see if was get a healthy Insiders build out today.

Though even while the build is still running all our users can safely go to our side and download insiders. The version on the site is now a good one from yesterday.

I'm sure you know already, but for others searching, the same also happens on MacOS. Downloading from the link above and copying over the top of it in Applications sorts it. Thanks for the quick response!

Once again, sorry for all the breakage everyone! Everything should be back to normal by now.

Woohoo... my extensions are all back working and vscode appears to live once more.
Thank you for the fast turn-around


Test Coverage

Perform test coverage on the application.

Completed in pull request #74. Test coverage can be found in the test coverage wiki page.


Refactor top Metrics/AbcSize offenders

I thought it's time to take some steps to make .rubocop_todo.yml look nicer.

I've rebased this, just in case.

:+1: All changes look good to me.

:+1:


Create common Makefile template to be used by all plugins

Makefiles in the plugins have a lot in common.
This PR creates a common Makefile and modifies all plugin's Makefiles to use the common one.

Needs a rebase/conflict resolved?

Makefile template needs documentation still.

Added some documentation. Is there anything else we want to describe in there?


document updation

documentbody attribute of annotation entity is not supported for Data Export Service.
reference for confirmation: https://portal.microsofticm.com/imp/v3/incidents/details/197359010/home

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d51ad6f-b7a7-7abd-f1d1-1d7963dd3d49
Version Independent ID: 4612ff88-8457-2f49-8222-4fd110fd72f6
Content: Replicate data to Azure SQL Database using Data Export Service - Power Platform
Content Source: power-platform/admin/replicate-data-microsoft-azure-sql-database.md
Service: power-platform
GitHub Login: @sabinn-msft
Microsoft Alias: sabinn

@PranjaliShetty
Taking to internal thread.


Panel

Panel
Use this issue to discuss the Panel component.
Preview the panel component
Preview the panel with grey background component
Preview the panel with label component
Find out more about the panel component and when to use it in the NHS Digital service manual.
See our contributing guidelines

Closing these individual placeholder issues.
Please use the NHS digital service manual backlog to discuss the usage of this component. If you're having trouble with the code, or have found a bug, please raise an issue on the NHS.UK frontend backlog


programs.neovim.configure.customRC doesn't work in 22.11

Steps To Reproduce
Steps to reproduce the behavior:

/etc/nixos/configuration.nix
{ config, pkgs, ... }:

{
  imports = [
    ./hardware-configuration.nix
  ];

  # stripped unrelated content

  environment.systemPackages = with pkgs; [
    neovim
  ];

  programs.neovim = {
    enable = true;
    defaultEditor = true;
    configure = {
      customRC = ''
        set nocompatible            " disable compatibility to old-time vi
        set showmatch               " show matching
        set ignorecase              " case insensitive
        set mouse=v                 " middle-click paste with
        set hlsearch                " highlight search
        set incsearch               " incremental search
        set tabstop=4               " number of columns occupied by a tab
        set softtabstop=4           " see multiple spaces as tabstops so <BS> does the right thing
        set expandtab               " converts tabs to white space
        set shiftwidth=4            " width for autoindents
        set autoindent              " indent a new line the same amount as the line just typed
        set number                  " add line numbers
        set wildmode=longest,list   " get bash-like tab completions
        set cc=80                   " set an 80 column border for good coding style
        filetype plugin indent on   " allow auto-indenting depending on file type
        syntax on                   " syntax highlighting
        set mouse=a                 " enable mouse click
        set clipboard=unnamedplus   " using system clipboard
        filetype plugin on
        set cursorline              " highlight current cursorline
        set ttyfast                 " Speed up scrolling in Vim
      '';
    };
  };

  # stripped unrelated content

  system.stateVersion = "22.11";
}

nixos-rebuild switch (I'm using root user)

nvim document, customRC isn't applied, e.g. the line number isn't displayed.

Notify maintainers
@manveru @rvolosatovs
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.108, NixOS, 22.11 (Raccoon), 22.11.3935.60c0f762658`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `"nixos-22.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

This issue has been resolved off-platform. Caused by adding an unnecessary environment.systemPackages = [neovim];


Feat: add configmap trait

Description of your changes

🤖 Generated by Copilot at 79d7d30
Summary
🆕🛠🗑

Improved the configmap trait to support more options and scenarios. Refactored the template logic to a separate cue file for better modularity.

Configmap trait is reborn from the ashes
A new template with more power and features
Patch and output the secrets of the pods
Don't look back at the old and deprecated codes

Walkthrough

Update configmap trait definition to use new cue template (link, link)
Add new cue template for configmap trait to vela-templates/definitions/internal/configmap.cue (link)

Fixes #
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

can you describe a bit more about why we should make it as a built-in trait?

can you describe a bit more about why we should make it as a built-in trait?
@wonderflow When using webservice component, our users hope to configure confimap directly and create corresponding confimap resources simultaneously. Considering that adding configmap resource creation function to webservice will violate the principle of separation of concerns, So consider introducing configmap as a trait approach.

can you describe a bit more about why we should make it as a built-in trait?

When using webservice component, our users hope to configure confimap directly and create corresponding confimap resources simultaneously. Considering that adding configmap resource creation function to webservice will violate the principle of separation of concerns, So consider introducing configmap as a trait approach. @wonderflow

can you describe a bit more about why we should make it as a built-in trait?

When using webservice component, our users hope to configure confimap directly and create corresponding confimap resources simultaneously. Considering that adding configmap resource creation function to webservice will violate the principle of separation of concerns, So consider introducing configmap as a trait approach.

@nuclearwu the storage trait can create configmap in your case.

@nuclearwu the storage trait can create configmap in your case.

storage trait can create configmap in your case.

@wonderflow Yes,I know, however, our users have reported that the storage trait is complicated to use and some parameter configurations are not used, so consider a more simplified confimap trait. So far, I've just extracted confimap from storage. Next, I'm going to remove some of the configuration to make the confimap trait more suitable for typical usage scenarios.

ping @Somefive


Broken install of libratbag/piper on Ubuntu 18.04

Hello ! First, thanks a lot for this library, it's really awesome to have tools like that for Linux gamers.
I tried to install libratbag and piper on Ubuntu, but it didn't go wo well. First I tried to install libratbag from the ppa : https://launchpad.net/~trebelnik-stefina/+archive/ubuntu/ratbag-piper
$ sudo apt install libratbag
[...]
Setting up libratbag (0.9.903.0~bionic) ...
Failed to enable unit: Unit file /etc/systemd/system/ratbagd.service is masked.
dpkg: error processing package libratbag (--configure):
 installed libratbag package post-installation script subprocess returned error exit status 1
Processing triggers for libc-bin (2.27-3ubuntu1) ...
Errors were encountered while processing:
 libratbag
E: Sub-process /usr/bin/dpkg returned an error code (1)

And this is what I got. Then when I try to install piper it says that libratbag is not configured
$ sudo apt install piper
[...]
dpkg: dependency problems prevent configuration of piper:
 piper depends on libratbag; however:
  Package libratbag is not configured yet.

dpkg: error processing package piper (--configure):
 dependency problems - leaving unconfigured

Note that running sudo ratbagd --verbose  outputs:
$ sudo ratbagd --verbose
ratbag debug: Logitech Gaming Mouse G502 is device '/dev/hidraw0'.
ratbag debug: Logitech Gaming Mouse G502 is device '/dev/hidraw1'.
ratbag debug: report ID 01
ratbag debug: report ID 03
ratbag debug: report ID 04
ratbag debug: report ID 10
ratbag debug: report ID 11
ratbag debug: 'Logitech Gaming Mouse G502' is using protocol v4.2
ratbag debug: device has color effects
ratbag debug: device has non-rgb leds
ratbag debug: device has adjustable dpi
ratbag debug: device is at 1200 dpi (variable between 50 and 12000).
ratbag debug: device has adjustable report rate
ratbag debug: device has 4 report rates
ratbag debug: device has onboard profiles
ratbag debug: device is using ROM settings
ratbag debug: ROM settings loaded
ratbag debug: device has configurable mouse button spy
ratbag debug: driver match found: Logitech HID++2.0
event2: "Logitech Gaming Mouse G502", 3 profiles

Any idea how to fix it ?

That's an issue with the package itself which isn't provided by us. You should be able to build it from source.

Indeed, I recommend contacting the PPA maintainer instead, we don't know how that package is built.

Alright thanks for your fast answers. It would be super cool that you release a package with libratbagd/piper because I have had hard time building it from source, and I just think I'm going to surrender since I've spent some hours already without succeed. I feel it would be a really good improvement to have a package which is more user friendly than building a software from source, especially because this package is a super nice tool.

piper has a flatpak available on flathub, but libratbag cannot be packaged as flatpak due to technical restrictions. we don't do distribution packages because there are too many of them to keep track of and we're suffering from lack of time as it is. I recommend you ping your distribution to update the package there, otherwise, building from source is your only option at this point.

@PierreCapo
I will try to fix this tomorrow.
I entered wrong install dependency in debian build file.

@PierreCapo
Try now, I think it should work now.

@muzena Good job man, it's working like a charm.
Tested on Ubuntu 18.10 :
sudo add-apt-repository ppa:trebelnik-stefina/ratbag-piper
sudo apt-get update
sudo apt-get install ratbagd
sudo apt-get install piper

And it works perfectly !
Those commands should really be in the Readme or somewhere else in the doc, it would be definitely more user friendly for new comers in order to run this awesome library.
Thanks for your fast replies and availability guys

@PierreCapo
New PPA

there is following command, that installs most dependencies:
sudo apt install cmake libudev-dev libevdev-dev libsystemd-dev libglib2.0-dev libjson-glib-dev libunistring-dev check valgrind swig
I for my part, needed following on Pop! 20.04 (Ubuntu 20.04):
sudo apt install libjson-glib-dev sudo apt install libunistring-dev sudo apt install python-gi-dev sudo apt install libsystemd-dev sudo apt install python3.8-dev sudo apt install python3.8-full sudo apt install swig sudo apt install check


What is the correct name of property? "arguments" or "parameters"

What is the question:
In the spec, we can see the name is "arguments"

but in the sdk, we can see it is "parameters"

so which is correct?

The documentation is incorrect, as per schema, it is Parameters.
Could I ask you to open an issue on the spec to address that error?

The documentation is incorrect, as per schema, it is Parameters.
Could I ask you to open an issue on the spec to address that error?

Sure, glad to do that. Issue created

Many thanks! Closing this one as a matter of consequence 😉


xUser: Set-LocalUser does not have a 'PasswordChangeableDate' parameter

There is no parameter 'PasswordChangeableDate' on the function Set-LocalUser.
This parameter is being used at line 767 of xUser in the Nano implementation of Set-TargetResource.
It needs to be replaced with a valid way to expire a password on Nano server.
Mariah is already working on this along with other updates to xUser.

@mbreakey3 Is this fixed?

Yup, it's not in the code anymore


Add the ability to refactor variable names, like in VSCode or Eclipse.

Godot version:
v3.1.dev.custom_build.7b63c63
OS/device including version:
Arch Linux 4.17.10-1-ARCH
It would really help, because renaming variables a lot is very annoying. I think it would be
a great feature to add to the GDScript editor.

Also function names.
Also 'Go to variable declaration', 'Go to function definition'.
Also 'Find Usages' for functions and variables, like in QtCreator.

Inactive, closing.

Was in necessary to close this? It's one of the most needed feature request.


make nextConfigDir optional

I'd propose to use ./ as default for nextConfigDir and make the plugin work ootb without providing any configuration (unless you need it).

This is a good idea 💡. Feel free to PR if you’re interested 🙏


Fix: Changing the tab color to some gray shade

Updated GlobalStyle.js to handle focus state styling
Referenced color variables from variables.js for consistency
Ensured accessibility by improving tab focus visibility
Fixes #1

Looks Good! Thank you.

Hi @biswajit-k,
Thank you for the review and for merging the Pull Request! I’m glad to hear that the changes are satisfactory.
Best regards,
Muhammad Salman


sample/shields: Fix printf with float

After that libc printf() switched to cbprintf() as basis (see 7cf9a8c)
there is a need to declare CONFIG_CBPRINTF_FP_SUPPORT=y in every sample
code that needs to print floats out.
NOTE:
This PR is fixing all x_nucleo shields, but there is one other shield, lmp90100_evb, which seems to require same change. I do not have that board to test it out. Nevertheless, the fix seems quite simple and should not break anything. So, let's decide whether to include that shield also in this PR.

Rather it should be done in samples that use floating point formatting.

Of course, this is where that's being done.  It's just doing a few of them.  Lemme see how a tree-wide approach works....

#30058 is another possible solution.

#30058 is another possible solution.

Yes, I know that I'm touching only a few of them. A smart recursive command is of course better. Let me check your command better. It seems the right direction

#30058 is another possible solution.

Yes, I know that I'm touching only a few of them. A smart recursive command is of course better. Let me check your command better. It seems the right direction

@pabigot
It seems, at a first glance, that x_nucleo_iks01a3/sensorhub is somehow missing.

@pabigot
x_nucleo_iks01a3/sensorhub is using shub.conf and not prj.conf. I think that's why.

Also x_nucleo_iks02a1/sensorhub is missing for the same reason. I don't know why I used shub.conf instead of prj.conf, my bad. But I don't think there was any requirement on the conf name, right?

superseeded by #30058


circup: 1.2.3 -> 1.4.0

Diff: https://github.com/adafruit/circup/compare/refs/tags/1.2.3...1.4.0
Changelog: https://github.com/adafruit/circup/releases/tag/1.4.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 264351 run on x86_64-linux 1

2 packages built:

circup
circup.dist


Add or subtract from minX, miny, maxX and maxY

The ability to add or subtract a value from auto calculated minX, miny, maxX and maxY
Is your feature request relasted to a problem? Please describe.
The max or min sits on the edge of the chart, ill look better if their are some 'padding' in the chart
Describe the solution you'd like
LineChartData(maxX: maxX + 2,
                      minX: minX - 2,
                      maxY: maxY + 2,
                      minY: minY - 2,

Additional context

I think it will be cleaner if you add it manually in my opinion.
Because it is a rare use-case, so it doesn't make sense to have it inside the chart features.


Replication groups

Replaces #221.
Previously, the API did not efficiently support mixing component and bundle groups. Under the previous architecture, every archetype with the Replication marker matched a component-based rule, resulting in entities matching any other rule being replicated twice. Additionally, even if rules didn't intersect, an empty entity would still be included in the replication message.
In this PR I tried different approach. Meet replication groups.
Replication Groups
Rather than directly modifying archetypes, I've introduced the ability to register patterns that match archetypes. And internally we match registered rules into archetypes. But now you can also call replicate_group to pass anything that implements ReplicationGroup. We provide blanket impls for tuples, so it's possible to call it like this: replicate_group::<(Name, Transform, Visibility)>. To customize how a group is replicated, user can implement ReplicationGroup for any struct manually. This is where bevy_bundlication comes in by providing a nice derive macro.
Pros:

Solves the mentioned inefficiency.
Allows us to handle superset registrations in replicon. For example, Transform and (Transform, Player) will panic after all plugins initialization.
It's a good replacement for the removed dont_replicate hack.

Cons:

Removals are not very efficient for now. I need to open a small PR into Bevy to provide an iterator over RemovedComponentEvents.

Internal Changes and Notes
I took some renames and ReplicationFns abstraction from #221.
I would suggest to review src/core/replication_rules.rs by looking at the PR's file, the diff is messy.

The safety story around this line needs to be solidified:

I agree. I can rework it as part of this PR or do it in a followup since it's quite similar to what we have with replicate_with. What would you prefer more?

Actually, maybe I should just do a checked get? I don't think that it will have any meaningful impact.

I feel like removal tracking could be less expensive, but don't have any big ideas.

Same thing... But the mentioned PR was merged into Bevy, so in the next release deletions will not only be less costly, but also have any cost only if you have them :)


[4pt]  - Display number of likes for each item on the Homepage - Student A

When the page loads, the webapp the Involvement API to show the item likes and combines them with the data from the base API.
Remember that your page should make only 2 requests:

one to the base API
and one to the Involvement API.

This task does not include displaying the likes button (heart icon on the wireframe) for each item.

Great job! https://github.com/shakerAbuDrais/FreeEpicGames/pull/29


Vue-tsc

I have a project using vue-tsc when I try to use this package it throws a lot of type errors.
Are there any plans on adding vue-tsc to the project to do type checking?

Hello @jasminetracey ! Thanks for your concern, there is indeed some types that needs to be taken care of, most of them are because the underlying implementation  of variants changed slightly. Our idiea for future is to move the variants system to tailwind-variants and also make sure all the types are infered via the new vue sfc.
So replying directly to your question, yes, they will be taken care of :p meanwhile if you qant have some fun, feel free to submit a PR.


VertexAIModelGarden _generate method not in sync with VertexAI API

System Info
LangChain version:
Platform: WSL for Windows (Linux 983G3J3 <IP_ADDRESS>-microsoft-standard-WSL2)
Python version: 3.10.6
Who can help?
@agola11
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
1a. Create a project in GCP and deploy an open source model from Vertex AI Model Garden (follow the provided Colab notebook to deploy to an endpoint)
1b. Instantiate a VertexAIModelGarden object
llm = VertexAIModelGarden(project=PROJECT_ID, endpoint_id=ENDPOINT_ID)

Create a prompt string

prompt = "This is an example prompt"

Call the generate method on the VertexAIModelGarden object

llm.generate([prompt])

The following error will be produced:

../python3.10/site-packages/langchain/llms/vertexai.py", line 452, in <listcomp>
    [Generation(text=prediction[self.result_arg]) for prediction in result]
TypeError: string indices must be integers

Expected behavior
Expecting the generate method to return an LLMResult object that contains the model's response in the 'generations' property
In order to align with Vertex AI api the _generate method should iterate through response.predictions and set text property of Generation object to the iterator variable since response.predictions is a list data type that contains the output strings.
for result in response.predictions:
            generations.append(
                [Generation(text=result)]
            )

@dosu-bot the generate method shouldn't convert the result iterator variable to a dict because the result is just a string that contains the output. It should simply create a Generation object by setting the text property equal to the result

@trevdoz has the problem been solved for you? can we close the issue?

Just started doing some tests with VertexAI Model Garden and got the exact same issue above with the result from the GCP Llama2 not chained correctly into SQLDatabaseChain.
SQL compilation error: syntax error line 1 at position 0 unexpected 'P'. [SQL: P]


checkJs: "Cannot find module" in .html file inline module

TypeScript Version:  3.9.0-dev.20200411, the latest as of writing in the Nightly VS Code extension

Search Terms:

Cannot find module
html file
ts-check
checkJs

Code
Example repo: visit the links in the README to see that the code works, and open the repo in VS Code to see the error.
// src/module.js
export const anything = true;

// src/component.js
import { anything } from './module.js';
// Correct: anything is available, and Go To Definition goes to src/module.js
alert('anything in .js: ' + anything); // true

<!-- src/component.html -->
<script type="module">
  // @ts-check
  import { anything } from './module.js';
  // Error: Cannot find module './module.js'
  alert('anything in .html: ' + anything); // true
</script>

Expected behavior:
ts-check in the html file doesn't raise an error, and Go To Definition works on anything.
Actual behavior:
ts-check errors and Go To Definition only shows references in the html file.

typescript itself doesn't really process or handle .html files on its own.
vscode starts a separate language service with the javascript separated from the html document: https://github.com/microsoft/vscode/blob/release/1.44/extensions/html-language-features/server/src/modes/javascriptMode.ts#L41
Just an educated guess, but the issue might reside on that side. FYI @aeschli

Just discovered a bug in the HTML Language Server, so maybe this is related? https://github.com/microsoft/vscode/issues/95090

I'm having lots of problems trying to type check my inline script modules. They run fine in the browser. So I've filed https://github.com/microsoft/vscode/issues/95344, I really hope it gets fixed soon, it's quite sad to add @ts-check and see a problem that's impossible to fix :<
Thanks for the code link @AviVahl – totally makes sense that the JavaScript(/TypeScript) LSP is used on the contents separately from the HTML LSP.
Maybe this is the problematic line?
https://github.com/microsoft/vscode/blob/release/1.44/extensions/html-language-features/server/src/modes/javascriptMode.ts#L66
getCurrentDirectory: () => '',

I think the linked issue is the root cause here; we don't directly handle HTML files so this would be an editor-side issue


Not found entities return 200 OK

Any request to a non-existent entity (e.g. curl -Hblabla dashboard.mf2c-project.eu/api/service/1) is returning a 200 status instead of a 404. Body is ok.
> GET /api/service/1 HTTP/1.1
> Host: dashboard.mf2c-project.eu
> User-Agent: curl/7.47.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Length: 190
< Content-Type: application/json
< Date: Fri, 12 Apr 2019 11:12:37 GMT
< Server: Aleph/0.4.4
<
{
  "status" : 404,
  "headers" : {
    "Content-Type" : "application/json"
  },
  "body" : {
    "status" : 404,
    "message" : "service/1 not found",
    "resource-id" : "service/1"
  }
* Connection #0 to host dashboard.mf2c-project.eu left intact
}

@rosogon please re-open if this is still a problem


Add a new sas-emitter plugin

Description
Add new *SAS - k8s * Emitter plugin.
This plugin should have following functions:

Read token information from k8s secrets
(token, cloud-oe and access-group)

This will be a extension to https emitter

Populate token and cloud-oe in the https header X-Auth-Token and Cloud-OE-ID resp.

Add  access-group, namespace, features, source-type, timestamp as query parameters

Sample send-frame api should look like:
curl -XPOST 'https://XXX:16100/sas/api/send-frame?access_group=d5043717-ac4b-4316-9c79-d771251aae0a&namespace=<IP_ADDRESS>/some_one&features=os,package,disk,config,file&timestamp=2017-02-27T13:32:05+0000&source_type=container' -H 'Content-Type: application/csv' -H 'Cloud-OE-ID: bluemix' -H 'X-Auth-Token: token-abc' -d @frames.txt

@canturkisci @niltonb ^^

@nadgowdas I want to change 2 points for sas emitter code. 1. Passing token by extraMetadata, 2. Switching On/Off of ssl verification

Passing token by extraMetadata
If extraMetadata is not set, we use file data as sas token, but if set, we use it as a token. In our environment, we need to run multiple crawlers on the same host and use the different token for each crawler. So we easy to use sas emitter if we can pass the token by extraMetadata

Switching On/Off of ssl verification.
We use a self-signed certificate in our development environment and ssl verification is failed in requests.post function. So we want to change on/off of ssl verification for requests.post argument. One new option will be add to crawler.conf to switch it.

If there is no problem, I will add code to sas emitter and create PR. How do you think?

@hitomitak

Passing token by extraMetadata
I think passing as extraMetadata in not secure way to pass tokens. Also, if your token changes (it expires and new token is created) you will have to restart crawler ?
To your use-case, you can still use current mechanism of secret file mounting. You can push multiple secrets to k8s (lets say secret1, secret2 etc.) Then when you start multiple crawlers you can mount the right secret in each crawler instance.

Do you think this will work for me ?

Switching On/Off of ssl verification.
Yes, I agree. You can make it a crawler conf and implement this change.

@nadgowdas  Thank you for a nice suggestion. Indeed, my idea is not secure. If the token is passed by extraMetadata, we can see the token by ps commands... I will push secrets to k8s and run crawlers. For ssl verification option, I will add a few lines to sas emitter and create PR. It is OK to not work for this.

PR #302 and #287 has addressed this issue and merged to master.