create-meta/java: handle null values in ci dict

This fixes #1228 by handling null explicitly.
I'm unsure, if it would be worth to add acceptance tests for all available CIs.

I'm unsure, if it would be worth to add acceptance tests for all available CIs.

That doesn't scale. It's usually better to do this per property. However in this case nearly all properties are nullable.

Hi @kgeilmann,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Cheers!
Should be released with cucumber-jvm:6.8.2.


TEST MODULE SPANISH

tioanime.kmodule.zip
I'm trying to understand the function well so that it runs in the app, when I add it I get that the metadata is missing?

Does it has metadata file?


HSEARCH-3887 Update documentation about routing in the Search DSL

https://hibernate.atlassian.net/browse/HSEARCH-3887

Addressed your comment and merged. Thanks!


Model should be a config option

Done in https://github.com/basicallydan/gpterm/releases/tag/v0.6.1


rebar3 hex docs: Improve error message when building custom docs

I had the proper rebar.config setup:
    {docs, [{edoc_opts, [{preprocess, true},
                         {doclet, edoc_doclet_chunks},
                         {layout, edoc_layout_chunks},
                         {dir, "_build/default/lib/telemetry/doc"}]}

however I kept getting this error:
% rebar3 hex docs
===> Verifying dependencies...
===> No valid hex docs configuration found. Docs will will not be generated
===> Docs were not published since they couldn't be found in '/Users/wojtek/src/telemetry/_build/default/lib/telemetry/doc'. Please build the docs and then run `rebar3 hex docs` to publish them.

It wasn't clear to me how to fix the error.
Turns out I forgot to set {doc, "doc"} in src/<app>.app.src. (https://github.com/beam-telemetry/telemetry/pull/86)
I wonder if we can somehow improve the error message?

@wojtekmach  #263 sorts some of this out, but it doesn't improve on the {docs, "doc"} bit (i.e., if it's missing). I don't know if that was always a convention in rebar3 projects prior to https://github.com/erlef/rebar3_hex/pull/180 but I don't believe there was, definitely not in rebar3_hex (AFAIK). That PR introduced a lot of problems :)
Need to make a decision on whether to even honor that in v7. On one hand, I suppose it's convenient, on the other hand, it's a bit "dangerous", as were the changes in the PR mentioned above (i.e., you can have stale docs lying around and inadvertently publish them). In v7 the goal is to be like mix and ex_doc that everything must be explicit. So for this case, and in  case there is still no ex_doc provider around, what do you think is amenable?
Specifically in https://github.com/erlef/rebar3_hex/issues/221 I have a task to add a --doc-dir vs relying on {doc, Dir} attribute in .app.src; all in effort to make make it all quite explicit. I hope most won't even use that option, but it'll be there for the cases that require it.

I just ran into this very issue with the newest rebar3 (from master branch) attempting to publish erlperf - https://github.com/max-au/erlperf
It felt a bit frustrating as the actual package has been published, and then the error occurred. It feels safer to fail the entire operation (not even attempt to publish the package if docs provider is broken, unless I explicitly specify --without-docs).
I eventually succeeded with this command: rebar3 hex publish docs --doc-dir doc but the error message is indeed confusing.

@max-au Are you on the latest rebar3_hex? There were a lot of fix ups and changes in behaviour in v7

This was discussed, and I think I agree with what was put out there, specifically. We can do this in stages.

Start with a warning before the confirmation prompt about no doc provider configured, etc and in future versions this will be required.
Provide a way to disable the warning
Make the change to raise an error if a doc provider isn't configured.

Still though, you used docs-dir option, so in your case there is no provider?

I just hit this.
I have docs in doc/ and the error message given by rebar3 hex publish doesn't mention anything about how to publish when that is the case, it only talks about doc providers.

@tsloughter  Are you sure you're on the latest and I guess, let me ask what was your exact cli usage and your expectation. If I run rebar3 hex --doc-dir src :
===> Analyzing applications...
===> Compiling rebar3_hex
===> Analyzing applications...
===> Compiling rebar3_hex
===> Verifying dependencies...
===> App rebar3_hex is a checkout dependency and cannot be locked.
===> No doc provider configuration was found, therefore docs can not be published.

You may resolve this by adding a doc provider property to your projects hex config.

To configure rebar3_ex_doc as your doc provider (recommended but requires >= OTP 24)

Add the following configuration to your rebar.config :

{project_plugins, [rebar3_ex_doc]}.

{hex, [{doc, ex_doc}]}.

{ex_doc, [
          {source_url, <<"https://github.com/namespace/your_app">>},
          {extras, [<<"README.md">>, <<"LICENSE.md">>]},
          {main, <<"readme">>}]}.

Alternatively if using OTP < 24 or you prefer edoc, add the following to your rebar.config :

{hex, [{doc, edoc}]}.

If you always intend to publish packages without docs and wish to silence this warning you should use :

rebar3 hex publish package

Note : In version 7.1 this warning will be treated as an error


test(@toss/react): wrote test code for useVisibilityEvent

Overview

A test code has been created to validate the behavior of the useVisibilityEvent.
PR Checklist

[x] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

Just accidentally made a review -- but please have a look at my comments!

@rjsdnql123 thank you for making this pr! can you check review?

@ChanhyukPark-Tech
I'm sorry. 😢
I have been busy lately and didn't pay much attention. I will review and submit the changes for your review within this week.

@raon0211 @ChanhyukPark-Tech
I have made the modifications based on the review. I apologize for the delay 🙏

Great work. Thanks, @rjsdnql123 !


Queries are doubled

Hi all, I'm not sure if it is only me.
When i checked my debug bar I noticed the queries are doubled whenever I retrieve a settings.

Hi all, I'm not sure if it is only me.
When i checked my debug bar I noticed the queries are doubled whenever I retrieve a settings.

Same issue. Anybody fixed this ?


Basic test case: centos-stream in targets

This test case is triggered automatically by our validation script.
- job: copr_build
  trigger: pull_request
  metadata:
    targets:
    - centos-stream-x86_64

/packit build

/packit build

/packit build

/packit build

Replace by #653.


Availability of the structured version of the Mitchell's Newspaper Press Directories

Hi,  It looks like this dataset has been deleted and the link to it is broken.  Will this data be made available?
Thanks

Hi @jimfoundry Data is now available here.

Thanks!

Kaspar,
Thanks very much, I greatly appreciate it.
All the best,
Jim
On Tue, Aug 16, 2022 at 9:17 AM kasparvonbeelen @.***>
wrote:

Hi @jimfoundry https://github.com/jimfoundry Data is now available here
https://github.com/Living-with-machines/PressDirectories/blob/main/data/Press_Directories_1846_1920_JISC_final.csv.zip
.
—
Reply to this email directly, view it on GitHub
https://github.com/Living-with-machines/PressDirectories/issues/8#issuecomment-1216626255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF43TEXQ3YIDGA45GZQRRHLVZOIHBANCNFSM56OUGTYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Http://foundry.ai
Jim Manzi Partner
This electronic message transmission contains information from
Foundry.ai which may be confidential or privileged. The information is
intended to be for the use of the individual or entity named above. If you
are not the intended recipient, be aware that any disclosure, copying,
distribution or use of the contents of this information is prohibited. If
you have received this electronic transmission in error, please destroy
this message and kindly notify the sender by reply email immediately.
Opinions, conclusions and other information in this message that do not
relate to the official business of Foundry.ai shall be understood as
neither given nor endorsed by it.


Make Search more discoverable

Hi Amy!
Wondering how hard it might be to redesign the Search feature in your book (I've been reading Critically Conscious Computing) so the UX is more intuitive. Right now, it seems Search is only accessible as a chapter from the Table of Contents, which was not discoverable for me. I wonder what you'd think if the Search was a bar in the upper right hand corner? Something like that?
Maybe there's a good reason you designed it the way you did. I just wanted to flag your attention to the fact that I wouldn't have discovered Search without a colleague telling me where to find it. :) thanks!
Collette

Thank you for the feedback! I hope to get to this eventually, but it's very much a side project right now.


Add support for namespacing logs from bitcoin backend

Currently all logs coming from the bitcoind backend, such as when importing Neutrino, gets the tag [BTCN]. Internally in Neutrino, each sub system has its own logger with a namespace, but this won't be shown in the lnd logs.
We should add support for showing the internal tags in the lnd logs, either by using the backend tags directly, or adding them to the existing lnd log tag.

[ ] Show backend tags in lnd logs
[ ] Allow setting loglevel on individual backend tags.

Closing this as may not be relevant now


Dynatrace-operator as Kubernetes App on Azure Marketplace

Description
With the change it is possible to package dynatrace-operator as Azure AKS marketplace application. The benefit is that operator can be installed in Azure Native way , leveraging Azure Portal UI.
Detailed documentation of AKS applications: https://github.com/Azure-Samples/kubernetes-offer-samples/blob/main/getting-started/GettingStarted.md
The change

adds azure-marketplace as valid platform (values.yaml)
required azure-extensions-usage-release-identifier annotation to common labels
sets the custom image to required value .Values.global.azure.images.operator.registry .Values.global.azure.images.operator.image .Values.global.azure.images.operator.digest  (Microsoft will maintain copy of the image in their ACR)

How can this be tested?
The whole CNAB artifact is testable in Azure Marketplace.
Reference: https://learn.microsoft.com/en-us/azure/aks/deploy-marketplace?tabs=azure-portal
Checklist

[X] PR is labeled accordingly with a single label
[X] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7b48222) 64.56% compared to head (6a1bcc5) 64.56%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   64.56%   64.56%
=======================================
  Files         243      243
  Lines       16147    16147
=======================================
  Hits        10426    10426
  Misses       4921     4921
  Partials      800      800

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Will be merged with: https://github.com/Dynatrace/dynatrace-operator/pull/2512


60 FPS Video Support

Is your feature request related to a problem? Please describe.
The quality of videos on Bluesky compared to other platforms like Twitter or Mastodon could be better. I've uploaded the same gameplay clip to Bluesky and Twitter and put them side by side and you can see the clear difference:
https://github.com/user-attachments/assets/d49d3efc-1e5d-41d4-8436-1f2cee999925
Source Video:
https://github.com/user-attachments/assets/c4ba6995-8b0c-4bbb-8ef1-6609a90d61a0
Digging into the metadata of the videos reveals that the bitrate is fairly similar, but the Bluesky video is restricted to 30 FPS:
Twitter

Bluesky

Mastodon

Source

Describe the solution you'd like
A simple solution to this degraded quality would be to allow 60 FPS videos on Bluesky and perhaps a slightly higher bitrate, which would clearly cost storage space.
Mastodon here is basically identical to the source video as they take the approach of simply having a hard cut off of 99 MB.
Twitter: 9.9 MB
Bluesky: 6.7 MB
Mastodon: 67 MB
Source: 67 MB
Describe alternatives you've considered
Aside from better encoding formats (maybe VP9 or AV1), little can be done to improve the quality of videos without bumping up the bitrate and/or frame rate.

Oh this is a very interesting discovery because BlueSky doesn't specify these limitations on their website. Out of curiosity, what did you use to identify the metadata for these videos? I'd like to utilize that and examine it more with my videos.

Oh this is a very interesting discovery because BlueSky doesn't specify these limitations on their website. Out of curiosity, what did you use to identify the metadata for these videos? I'd like to utilize that and examine it more with my videos.

Use a method to download the file, whether that's by inspecting the Network tab in your browser's Developer console, or using an extension/app.
Then you can use MediaInfo to view info about the files. https://mediaarea.net/en/MediaInfo

Out of curiosity, what did you use to identify the metadata for these videos? I'd like to utilize that and examine it more with my videos.

I used ffmpeg


Independent deployment of Admin UI frontend in Kubernetes

###Description
As a developer, I want to deploy Admin UI front-end in Kubernetes.
###Acceptance criteria

[x]  plan for separation
[x]  implement
[x] use separate repository for deployment

@zperova done.
UI:

Dev: http://hh-rke-wp-webadmin-20-worker-1.caas.ebi.ac.uk:31450/
Prod: http://hh-rke-wp-webadmin-20-worker-1.caas.ebi.ac.uk:31627/

More documentation: https://www.ebi.ac.uk/seqdb/confluence/display/MouseInformatics/PDX+Admin


Is there a Web UI on the roadmap by any chance?

Is your feature request related to a problem? Please describe.
Our current development environment is dockerised, and dev's will bring up the stack using docker-compose. We can easily add mockoon to the docker-compose file, but without installing the full mockoon, developers will not be able to use the UI to view the logs, and to disable routes and allow proxying of requests etc.
Describe the solution you'd like
It'd be amazing if this functionality could be available via a web ui (similar to https://www.mock-server.com/mock_server/mockserver_ui.html), so a developer could clearly see what requests  / responses are being mocked, and ideally be able to disable the mocked route, bring up the required backed server, and then see the logs for the actual calls - and then ideally have the option to save the response as a mock - as you can in the current desktop UI.
Describe alternatives you've considered
As mentioned above, mock server allows for this via their web based dashboard, but your UX / UI is a wold ahead of that.
I've just stumbled across mockoon today, and really been impressed by what I've seen and been able to play with. Thanks so much for what you've built, I'm keen to take a closer look at how we can use it in the future.

There is currently no UI for the CLI as it was rather built as a companion to the desktop app, than as a standalone tool.
However, this is not the first time this was suggested. So, we may add this in the future.

Thanks for the feedback, yes, I realise that it doesn't make sense to add to the cli, the reason I posted it here was the CLI runs nicely on docker, and I'd love to have closer to the full mockoon experience in a docker-compose environment using a web UI.
Happy for you to close this issue, was just really excited to see what you've built and thinking how it would fit into our development processes.

Let's keep the issue opened for a while to see if there is more interest.
On the desktop side, some "admin" API has also been requested.
If this kind of feature would be added it could take multiple form, but I see two interesting things:

an API to programmatically query what is happening inside the CLI or the desktop UI
a way to control CLIs or deploy Docker containers from the UI


Use crc-any over crc16 crate

crc-any is maintained and more popular over crc16
This also fix a problem where rust-mavlink needs to recompiled
every single time
Signed-off-by: Patrick José Pereira<EMAIL_ADDRESS>

Ping @podhrmic

@podhrmic I kindly reminder, I have update the cargo version to 0.8.3, so if you can, could you push a tag for the cargo deployment ? This will help us with rust-mavlink development speed and test

Sorry about that. Just pushed a new tag, lets see if it compiles.
On a side note, I noticed that travis failed with:
thread '<unnamed>' panicked at 'Couldn't create client:
Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }',
tests/tcp_loopback_tests.rs:51:21

This is not the first time I saw that message - would it make sense to:
a) figure out why travis fails (but it passes on localhost)
b) remove the tests?

OK, so the travis build ended with this: https://travis-ci.org/github/mavlink/rust-mavlink/builds/696138070
Not sure what to think of it?

@podhrmic I have fixed in my last PR #53


Python error

Error: Cannot connect to host storage.googleapis.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')]

What OS are you using?

MacOS

#18
Try what @Kung-Fu-Stalin said

Error: Cannot connect to host storage.googleapis.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)')]

Set param ssl equal to False like: session.get(url, ssl=False)

go to Applications the to folder Python 3.12 dobleclick on Install Certificates.command and re-run the script

IIn MacOS, you might need to install certificates separately. You can do this by running the Install Certificates.command script that comes with Python installations. You can find it in the Python installation directory (usually under /Applications/Python <version>/)
If you are still facing the issue, try uninstalling the Python program from Applications and run brew install python or you can use virtual environment pyenv.
You can find the certificate under /opt/homebrew/opt/python/libexec for ARM architecture. Simply run,
open /opt/homebrew/opt/python/libexec/Install\ Certificates.command

IIn MacOS, you might need to install certificates separately. You can do this by running the Install Certificates.command script that comes with Python installations. You can find it in the Python installation directory (usually under /Applications/Python <version>/)
If you are still facing the issue, try uninstalling the Python program from Applications and run brew install python or you can use virtual environment pyenv.
You can find the certificate under /opt/homebrew/opt/python/libexec for ARM architecture. Simply run,
open /opt/homebrew/opt/python/libexec/Install\ Certificates.command

This fixed my issues from above


Removed "About" Tab from the UEFI menu

Removed "About" Tab and section
Added FW update bar colors
Renamed files to follow number sequence.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: actena-msft sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@dansimp The PR that has been contributed by an internal MS member is available for review. Thanks.


exception handling in celery and formatting log.info()

logs are arriving in kibana, all is working! thanks again for helping me out earlier.
Still two probably simple to cover questions on the code.
I have celery tasks running, related to users. these turn into results.
I now wanted to add results and user details also in kibana, including exceptions (to prevent time-out) when things go bad inside my taks.
I tried the: log.info('info to log') and it puts the "info to log" inside the "raw message" inside kibana.
My two questions:

If I wanted an output that returns a "structured" by kibana interpretable output, so that the message.raw is transformed in message.request.id, message.request.name, etc. How do I do that in an easy way? Or do I manually format my log.info()-input in json-style?

For exception handling, i noticed your "ErrorLogObject"-class. How does it work? As I am in the celery task, and requests are not serialisable, it is impossible to pass it on, does it mean I will not be able to use this here?

EDIT:
I figured out how ErrorLogObject works in views.py:

request is needed - so my question is still valid for the case of a celery task
I used except Exception as e: and used de "e" as exception input
I set duration as an integer being "zero" which allows me to push error notifications to kibana.

EDIT 2:
Tried minimalistic json output in the log.error, something like:
log.error('{{ \'raw\' : {{ \'x\':{0}, \'y\':{1} }} }}'.format( x , y ) )
However, not splitting the "message.raw"  into "message.x" and "message.y"

Exceptions will be formatted if you use log.exception(<your exception>). However, other types of messages will not be formatted, but added as you’ve noticed in the raw key.
I do plan to change that and make a standard message format for this use case. When I started this library, it was only meant for request/response use case.
You can however, and please feel free to do so, add a new type of handler that meets your requirements and submit a PR, if you have the time to do so. :)
One thing that I should change meanwhile, is to not format a dict() message into “raw", which should lead the using of log.info <http://log.info/>({‘key’: ‘value’}) to a solution for your problem.

On 15 Nov 2017, at 16:19, radzia2<EMAIL_ADDRESS>wrote:
logs are arriving in kibana, all is working! thanks again for helping me out earlier.
Still two probably simple to cover questions on the code.
I have celery tasks running, related to users. these turn into results.
I now wanted to add results and user details also in kibana, including exceptions (to prevent time-out) when things go bad inside my taks.
I tried the: log.info('info to log') and it puts the "info to log" inside the "raw message" inside kibana.
My two questions:
If I wanted an output that returns a "structured" by kibana interpretable output, so that the message.raw is transformed in message.request.id, message.request.name, etc. How do I do that in an easy way? Or do I manually format my log.info()-input in json-style?
For exception handling, i noticed your "ErrorLogObject"-class. How does it work? As I am in the celery task, and requests are not serialisable, it is impossible to pass it on, does it mean I will not be able to use this here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/cipriantarta/django-logging/issues/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2skbfqF7AvQcjQngcsV5zy31g-k9d-ks5s2vLZgaJpZM4Qe_qy.

let's say time is not the issue here, but the skill ;)
in about 60% of the things I do, I don't really know what I am exactly doing.
If I come across relevant info, and I can help, I definitely will.
Thanks for the quick feedback!


[BUG] recurring backup job fail with completed status and 502 client timeout

Describe the bug
Hi after upgrade longhorn to 1.4.1 , we have some recurring job fail, the k8s job status is completed and the error is a client timeout, no problem with 1.3.2
time="2023-05-22T03:00:02Z" level=debug msg="Setting allow-recurring-job-while-volume-detached is false"
time="2023-05-22T03:00:02Z" level=debug msg="Get volumes from label recurring-job.longhorn.io/c-cwt2jo=enabled"
time="2023-05-22T03:00:02Z" level=debug msg="Get volumes from label recurring-job-group.longhorn.io/consul=enabled"
time="2023-05-22T03:00:02Z" level=info msg="Found 1 volumes with recurring job c-cwt2jo"
time="2023-05-22T03:00:02Z" level=info msg="Creating job" concurrent=1 groups=consul job=c-cwt2jo labels="{\"RecurringJob\":\"c-cwt2jo\",\"env\":\"dev\"}" retain=3 task=backup volume=pvc-4fc32d81-e82d-45ed-b02e-674350c63d07
time="2023-05-22T03:00:02Z" level=info msg="job starts running" labels="map[RecurringJob:c-cwt2jo env:dev]" namespace=longhorn-system retain=3 snapshotName=c-cwt2jo-3a079e88-c588-4bed-87bb-013820988687 task=backup volumeName=pvc-4fc32d81-e82d-45ed-b02e-674350c63d07
time="2023-05-22T03:00:02Z" level=info msg="Running recurring backup for volume pvc-4fc32d81-e82d-45ed-b02e-674350c63d07" labels="map[RecurringJob:c-cwt2jo env:dev]" namespace=longhorn-system retain=3 snapshotName=c-cwt2jo-3a079e88-c588-4bed-87bb-013820988687 task=backup volumeName=pvc-4fc32d81-e82d-45ed-b02e-674350c63d07
time="2023-05-22T03:01:02Z" level=error msg="Failed to run job for volume" concurrent=1 error="failed to complete backupAndCleanup for pvc-4fc32d81-e82d-45ed-b02e-674350c63d07: Post \"http://longhorn-backend:9500/v1/volumes/pvc-4fc32d81-e82d-45ed-b02e-674350c63d07?action=snapshotCreate\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)" groups=consul job=c-cwt2jo labels="{\"RecurringJob\":\"c-cwt2jo\",\"env\":\"dev\"}" retain=3 task=backup volume=pvc-4fc32d81-e82d-45ed-b02e-674350c63d07

To Reproduce
Steps to reproduce the behavior:
recurring job with external minio s3
Expected behavior
Job k8s with status error, backup success
Log or Support bundle
<IP_ADDRESS> - - [22/May/2023:03:00:02 +0000] "POST /v1/volumes/pvc-4fc32d81-e82d-45ed-b02e-674350c63d07?action=snapshotCreate HTTP/1.1" 502 0 "" "Go-http-client/1.1"
2023/05/22 03:01:02 http: proxy error: context canceled

Engine
[longhorn-instance-manager] time="2023-05-22T12:16:01Z" level=info msg="Snapshotting volume: snapshot c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82" serviceURL="<IP_ADDRESS>:10006"
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:16:01Z" level=info msg="Starting snapshot" snapshot=c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 volume=pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:16:01Z" level=info msg="Requesting system sync before snapshot" snapshot=c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 volume=pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:17:47Z" level=info msg="Starting to snapshot: <IP_ADDRESS>:10150 c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 UserCreated true Created at 2023-05-22T12:17:47Z, Labels map[RecurringJob:c-dqrvdb xlrelease_psql:dev]"
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:17:47Z" level=info msg="Starting to snapshot: <IP_ADDRESS>:10000 c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 UserCreated true Created at 2023-05-22T12:17:47Z, Labels map[RecurringJob:c-dqrvdb xlrelease_psql:dev]"
time="2023-05-22T12:17:47Z" level=info msg="Finished to snapshot: <IP_ADDRESS>:10150 c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 UserCreated true Created at 2023-05-22T12:17:47Z, Labels map[RecurringJob:c-dqrvdb xlrelease_psql:dev]"
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:17:47Z" level=info msg="Finished to snapshot: <IP_ADDRESS>:10000 c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 UserCreated true Created at 2023-05-22T12:17:47Z, Labels map[RecurringJob:c-dqrvdb xlrelease_psql:dev]"
[pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d] time="2023-05-22T12:17:47Z" level=info msg="Finished snapshot" snapshot=c-dqrvdb-d714dacc-930a-4731-a792-36b0b4b69b82 volume=pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e

Environment

Longhorn version: 1.4.1
Installation method kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s 1.24

Number of management node in the cluster: 6
Number of worker node in the cluster: 9

Node config

OS type and version: rhel7
CPU per node: 16
Memory per node: 32
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): vmware
Number of Longhorn volumes in the cluster: 60

Hello @chris93111. A couple of questions:

Is this error continuing to occur with each periodic backup operation, or did it just occur once/some number of times?
Does this error occur with multiple volumes? If so, is there any correlation (e.g. all attached to the same node).
The logs from the job and longhorn-manager appear to have been captured at 2023-05-22T03:01:02Z for pvc-4fc32d81-e82d-45ed-b02e-674350c63d07, but the successful snapshot seems to have been taken at 2023-05-22T12:16:01Z for pvc-c4b4bc0c-6f50-48d0-a0db-d7b7d78c324e-e-e79d3e2d. Is there any engine/instance-manager log correlating to the failure time?

We may need a full support bundle captured shortly after a failure to further debug this issue. Barring that, the answers to the above questions may help.

@ejweber Hi , is all days , but today we see the fail k8s job backup is always play in same node, we have restart this node today we wait to see if this resolve the problem, they are no setting for up the timeout of the snapshot ? when the job fail the snapshot is present in longhorn ui after more time and is can be changed to backup manually

@ejweber the reboot of node no resolve the problem, multiple volume , no correlation between, no same node for the job and volume
the logs

May 24, 2023 @ 05:01:41.456 | time="2023-05-24T03:01:41Z" level=debug msg="Created snapshot c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda with labels map[RecurringJob:c-7rmhls env:dev] for volume pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe" | longhorn-manager-bxx6t
-- | -- | --

  | May 24, 2023 @ 05:01:41.456 | <IP_ADDRESS> - - [24/May/2023:03:00:02 +0000] "POST /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe?action=snapshotCreate HTTP/1.1" 200 478 "" "Go-http-client/1.1" | longhorn-manager-bxx6t

  | May 24, 2023 @ 05:01:41.440 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-e-6e8c4b61] time="2023-05-24T03:01:41Z" level=info msg="Finished to snapshot: <IP_ADDRESS>:10435 c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda UserCreated true Created at 2023-05-24T03:01:41Z, Labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:01:41.440 | time="2023-05-24T03:01:41Z" level=info msg="Finished snapshot" snapshot=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda volume=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:01:41.437 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-e-6e8c4b61] time="2023-05-24T03:01:41Z" level=info msg="Starting to snapshot: <IP_ADDRESS>:10435 c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda UserCreated true Created at 2023-05-24T03:01:41Z, Labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:01:41.435 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-672b6875] time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk metadata file path /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-a737e0c9/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.meta before linking" | instance-manager-r-05ed221af5e2315701d0009584f9ac0d

  | May 24, 2023 @ 05:01:41.435 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk checksum file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-a737e0c9/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.checksum before linking" | instance-manager-r-05ed221af5e2315701d0009584f9ac0d

  | May 24, 2023 @ 05:01:41.435 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-a737e0c9/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img before linking" | instance-manager-r-05ed221af5e2315701d0009584f9ac0d

  | May 24, 2023 @ 05:01:41.434 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-e-6e8c4b61] time="2023-05-24T03:01:41Z" level=info msg="Starting to snapshot: <IP_ADDRESS>:10075 c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda UserCreated true Created at 2023-05-24T03:01:41Z, Labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:01:41.433 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-40ffe34a] time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk metadata file path /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-8fcfa34a/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.meta before linking" | instance-manager-r-e17344e0dce9e5f3ca6d3e1d50c03bef

  | May 24, 2023 @ 05:01:41.433 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk checksum file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-8fcfa34a/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.checksum before linking" | instance-manager-r-e17344e0dce9e5f3ca6d3e1d50c03bef

  | May 24, 2023 @ 05:01:41.433 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-8fcfa34a/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img before linking" | instance-manager-r-e17344e0dce9e5f3ca6d3e1d50c03bef

  | May 24, 2023 @ 05:01:41.431 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-672b6875] time="2023-05-24T03:01:41Z" level=info msg="Replica server starts to snapshot [c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda] volume, user created true, created time 2023-05-24T03:01:41Z, labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-r-05ed221af5e2315701d0009584f9ac0d

  | May 24, 2023 @ 05:01:41.431 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-e1374022] time="2023-05-24T03:01:41Z" level=info msg="Starting to create disk" disk=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda | instance-manager-r-4ac2e0c517547258dee9c8c494a1316e

  | May 24, 2023 @ 05:01:41.431 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk metadata file path /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-9a679ebc/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.meta before linking" | instance-manager-r-4ac2e0c517547258dee9c8c494a1316e

  | May 24, 2023 @ 05:01:41.431 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk checksum file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-9a679ebc/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img.checksum before linking" | instance-manager-r-4ac2e0c517547258dee9c8c494a1316e

  | May 24, 2023 @ 05:01:41.431 | time="2023-05-24T03:01:41Z" level=info msg="Cleaning up new disk file /host/var/lib/longhorn/replicas/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-9a679ebc/volume-snap-c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda.img before linking" | instance-manager-r-4ac2e0c517547258dee9c8c494a1316e

  | May 24, 2023 @ 05:01:41.429 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-40ffe34a] time="2023-05-24T03:01:41Z" level=info msg="Replica server starts to snapshot [c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda] volume, user created true, created time 2023-05-24T03:01:41Z, labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-r-e17344e0dce9e5f3ca6d3e1d50c03bef

  | May 24, 2023 @ 05:01:41.426 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-r-e1374022] time="2023-05-24T03:01:41Z" level=info msg="Replica server starts to snapshot [c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda] volume, user created true, created time 2023-05-24T03:01:41Z, labels map[RecurringJob:c-7rmhls env:dev]" | instance-manager-r-4ac2e0c517547258dee9c8c494a1316e

  | May 24, 2023 @ 05:01:02.774 | time="2023-05-24T03:01:02Z" level=error msg="Failed to run job for volume" concurrent=1 error="failed to complete backupAndCleanup for pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe: Post \"http://longhorn-backend:9500/v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe?action=snapshotCreate\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)" groups=vault job=c-7rmhls labels="{\"RecurringJob\":\"c-7rmhls\",\"env\":\"dev\"}" retain=3 task=backup volume=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | c-7rmhls-28081620-hsfkq

  | May 24, 2023 @ 05:01:02.755 | <IP_ADDRESS> - - [24/May/2023:03:01:02 +0000] "GET /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe HTTP/1.1" 200 9318 "" "Go-http-client/1.1" | longhorn-manager-5cdpt

  | May 24, 2023 @ 05:01:02.740 | <IP_ADDRESS> - - [24/May/2023:03:00:02 +0000] "POST /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe?action=snapshotCreate HTTP/1.1" 502 0 "" "Go-http-client/1.1" | longhorn-manager-5cdpt

  | May 24, 2023 @ 05:00:18.823 | <IP_ADDRESS> - - [24/May/2023:03:00:18 +0000] "GET /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe HTTP/1.1" 200 9318 "" "Go-http-client/1.1" | longhorn-manager-2z7pq

  | May 24, 2023 @ 05:00:02.767 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-e-6e8c4b61] time="2023-05-24T03:00:02Z" level=info msg="Requesting system sync before snapshot" snapshot=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda volume=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:00:02.746 | [pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe-e-6e8c4b61] time="2023-05-24T03:00:02Z" level=info msg="Starting snapshot" snapshot=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda volume=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | instance-manager-e-467f58a1e97ca3b307429f03ca97bdbf

  | May 24, 2023 @ 05:00:02.732 | time="2023-05-24T03:00:02Z" level=info msg="Running recurring backup for volume pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe" labels="map[RecurringJob:c-7rmhls env:dev]" namespace=longhorn-system retain=3 snapshotName=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda task=backup volumeName=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | c-7rmhls-28081620-hsfkq

  | May 24, 2023 @ 05:00:02.716 | time="2023-05-24T03:00:02Z" level=info msg="job starts running" labels="map[RecurringJob:c-7rmhls env:dev]" namespace=longhorn-system retain=3 snapshotName=c-7rmhls-f8a2857f-618a-419e-875d-e771f1b92dda task=backup volumeName=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | c-7rmhls-28081620-hsfkq

  | May 24, 2023 @ 05:00:02.691 | <IP_ADDRESS> - - [24/May/2023:03:00:02 +0000] "GET /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe HTTP/1.1" 200 9318 "" "Go-http-client/1.1" | longhorn-manager-5cdpt

  | May 24, 2023 @ 05:00:02.689 | <IP_ADDRESS> - - [24/May/2023:03:00:02 +0000] "GET /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe HTTP/1.1" 200 9318 "" "Go-http-client/1.1" | longhorn-manager-5cdpt

  | May 24, 2023 @ 05:00:02.686 | <IP_ADDRESS> - - [24/May/2023:03:00:02 +0000] "GET /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe HTTP/1.1" 200 9318 "" "Go-http-client/1.1" | longhorn-manager-5cdpt

  | May 24, 2023 @ 05:00:02.674 | time="2023-05-24T03:00:02Z" level=info msg="Creating job" concurrent=1 groups=vault job=c-7rmhls labels="{\"RecurringJob\":\"c-7rmhls\",\"env\":\"dev\"}" retain=3 task=backup volume=pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe | c-7rmhls-28081620-hsfkq

you can see the snapshot is created but is exceed the timeout ok 60sec for the backup

Thanks @chris93111 for aggregating these logs so clearly! This is starting to clear some things up. Reading the from the bottom up:
At 2023-05-24T03:00:02Z the backup job starts.
At 24/May/2023:03:00:02, longhorn-manager-5cdpt receives a POST request to /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe?action=snapshotCreate from the job.
At 24/May/2023:03:00:02 longhorn-manager-bxx6t receives a POST request to /v1/volumes/pvc-3de43ad7-13af-435b-8d0b-1374d1385bbe?action=snapshotCreate from the job. I'm unfamiliar with how exactly this works, but I think longhorn-manager-5cdpt proxies the request to longhorn-manager-bxx6t. The longhorn-manager function that requests the snapshot is not context-cancellation sensitive and has no obvious timeout.
https://github.com/longhorn/longhorn-manager/blob/705e7704d8ddd978a27d5b6a264e71c977d61eac/api/snapshot.go#L21-L49
At 2023-05-24T03:00:02Z, the engine starts to snapshot by requesting a file system sync.
The sync takes more than a minute. Is there too much disk contention? Is the disk too slow?
At May 24, 2023 @ 05:01:02.740 (exactly one minute after the request was received),  longhorn-manager-5cdpt returns a 502. The job fails.
However, the snapshotting continues. The longhorn-engine function that actually handles the snapshot is not context-cancellation sensitive, and is willing to wait up to one hour for the file system sync to complete.
https://github.com/longhorn/longhorn-engine/blob/1f57dd9a235c6022d82c5631782020e84da22643/pkg/controller/control.go#L183-L215
At 2023-05-24T03:01:41Z (after the job failed), a replica actually starts to take the snapshot.
At May 24, 2023 @ 05:01:41.456 (almost immediately), longhorn-manager-bxx6t reports a successful snapshot and creates a snapshot CR.
Now, the user sees a failed backup (it would have been the job's responsibility to start the backup, had it not failed) and a successful snapshot.
It seems to me that the proxy that sends the snapshotCreate request from the arbitrary longhorn-manager that receives an action=snapshotCreate request can time out and return after 60 seconds, even though the underlying APIs that get called as a result have no timeout.
https://github.com/longhorn/longhorn-manager/blob/705e7704d8ddd978a27d5b6a264e71c977d61eac/api/router.go#L73
WDYT @longhorn/dev-control-plane? Is it reasonable for a file system sync to take >60s? If it is, should we try to ensure that the proxy doesn't return before the underlying API calls complete (in <1 hr)?

@ejweber thanks for the response, and is correct scenario
Maybe disk slow, i need more time for confirmation, but we have no problem before upgrade 1.3.2 -> 1.4.1
The only information for the fail backup is the logs of the jobs or time of last backup in longhorn ui, for observability they are no more information, warning, alert ? in this scenario the snapshot no respect retain params of backup ?
Also exceeded the 60sec they are no solution palliative for backup

Previously, we encountered a similar issue and had the same guessing. Then we tried to use fsfreeze instead of sync before snapshotting. But unfortunately, fsfreeze would lead to a race issue hence we reverted the change.
To be honest, sometimes I suspect, it's the locking or something else rather than sync blocks the snapshot creation. The log does not directly indicate that sync is the culprit.
I am not sure if changing the VM-cache-related configs (vm.dirty_background_ratio, vm.dirty_ratio, ... in /etc/sysctl.conf) would be the workaround.


How to do graceful shutdown of server?

What is your question?

As of Go 1.8, the http server from the std lib has a Shutdown() method to gracefully stop the server. Is there anything similar for the certmagic server?
What have you already tried?

Looking in the godoc's for any .Stop() or .Shutdown() methods.
Include any other information or discussion.

Here's an article that shows how this is done with the http server from Go: https://hackernoon.com/how-to-safely-shut-down-a-server-in-go-aec16dfbc57f
Bonus: What do you use this package for, and does it help you?

Building a production website that hopefully will use this to keep its certs current.

There are several ways you could do this, but this is the simplest, if you don't mind not using the HTTP challenge (and relying solely on TLS-ALPN):
magicLn, err := certmagic.Listen([]string{"example.com"})
if err != nil {
	return err
}
srv := http.Server{
	// configure your server here
}

go srv.Serve(magicLn)

time.Sleep(10 * time.Second)

srv.Shutdown(context.Background())

(Of course, this is a contrived example)
If you want both challenge types you can make a magic := certmagic.NewDefault() and then use that to get a TLS config and HTTP handler like the README examples show.


Fix compile errors from API refactor

I've got my compiler set to treat warnings as errors, surprisingly, not much was needed to clear out the errors. Yes this does break #8 for now. Can still address that when we need it

That's great, thanks a lot.


[1.8] Found unused dependency: ext-session

We need this, because we want to use PHP's session functionality, that is used by symfony/http-foundation and symfony/http-kernel.

I think this is valid case for ignore. Or do you think it is not?


Allow OpenXRCompositionLayer property layer_viewport to always be assigned nullptr

If you have multiple OpenXRCompositionLayer nodes and at least one of them does not have a viewport assigned, users are not able to return an assigned layer_viewport property to its default value (nullptr). This fixes that.

Thanks!


Revert "Update Helm release generic-service to v3"

Reverts ministryofjustice/hmpps-activities-management-api#848

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.95%. Comparing base (48288d4) to head (7d03504).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #854   +/-   ##
=========================================
  Coverage     86.95%   86.95%
  Complexity     3550     3550
=========================================
  Files           372      372
  Lines         12532    12532
  Branches       1021     1021
=========================================
  Hits          10897    10897
  Misses         1164     1164
  Partials        471      471

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


component scope

firstly, thanks for the excellent project, am working through the awesome-vue-typescript template.
Question: are components exported to templates or simply included by file?
from what I can see, e.g. in awesome-vue-typescript/src/main.ts, the components are imported once, then become available everywhere?
import './components/navbar/navbar'
import './components/panel'

Thanks

Yup, just like calling Vue.component('html-tag', {...}) in js makes <html-tag></html-tag> available globally, simply importing a file with the @VueComponent decorator will make the component avilable globally as well.
see https://github.com/itsFrank/vue-typescript/issues/5 for more info on scope and the status on locally scoped components

closing this since https://github.com/itsFrank/vue-typescript/issues/5 should be used for component scope

any thoughts on hot-reloading??

Hmm, i'd have to look into the webpack settings, but i don't see why you shouldn't at least get the same benefits as a standard typescript project. Don't know about vue+webpack's hot reloading however.
In the next release, @VueExtend will be added which should make it easier to hot reload components

I got it working!
These are the steps, roughly:

add "vue-hot-reload-api": "^1.3.3", to package.json

note: must be a version 1.x branch, master is 2.x

add --hot to the command line argument of webpack-dev-server

this goes in the main.ts
  if( module.hot ){
      module.hot.accept()
  }

this goes in each file with a Vue component:
(TODO: I'm sure there is a way to do this one-time, in a parent component, but this works for now).

So, for a LoginPanel component:
   declare var module: any
   if( module.hot ){
        const api = require('vue-hot-reload-api')
        const Vue = require('vue')
        api.install(Vue)
        if( !module.hot.data ){
           api.createRecord('LoginPanel', LoginPanel)
        }
        else {
           api.update('LoginPanel', LoginPanel)
        }
     }

Nice, ill try it out and see if i can't add it as an option with the decorators so you don't have to put it in every file

something like
import {Config} from 'vue-typescript'
Config.hotReload = true;

once in main.ts before importing components should do the trick

that would be very nice.
thanks
Dave


Add connection-wide default keyspace for VTGateV3 queries.

@alainjobart
This makes it possible to specify a per-connection default keyspace for VTGateV3 queries, causing vtgate to assume that keyspace for unqualified table names, rather than using VSchema to look them up. This allows the app to unambiguously refer to tables whose names are not unique across keyspaces, without having to write fully-qualified keyspace.table names in the queries themselves.
Note that the JDBC and PDO wrappers will need to be updated to make use of the new constructors.

This change is

LGTM


Fix 3.14 snapshot builds in Travis after release

https://travis-ci.org/square/okhttp/jobs/518468747
20:07:51:343 [ERROR] Failed to execute goal on project okhttp-testing-support: Could not resolve dependencies for project com.squareup.okhttp3:okhttp-testing-support:jar:3.14.2-SNAPSHOT: Failure to find com.squareup.okhttp3:okhttp:jar:3.14.2-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of sonatype-snapshots has elapsed or updates are forced -> [Help 1]
20:07:51:357 [ERROR]
20:07:51:358 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
20:07:51:360 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
20:07:51:362 [ERROR]
20:07:51:362 [ERROR] For more information about the errors and possible solutions, please read the following articles:
20:07:51:364 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
20:07:51:365 [ERROR]
20:07:51:365 [ERROR] After correcting the problems, you can resume the build with the command
20:07:51:369 [ERROR]   mvn <goals> -rf :okhttp-testing-support
The command "./mvnw javadoc:jar source:jar -B" exited with 1.

Is this blocking you?
https://travis-ci.org/square/okhttp/jobs/519645745
13:43:49:053 [INFO] ------------------------------------------------------------------------
13:43:49:055 [INFO] BUILD FAILURE
13:43:49:055 [INFO] ------------------------------------------------------------------------
13:43:49:057 [INFO] Total time:  9.313 s
13:43:49:057 [INFO] Finished at: 2019-04-13T13:43:49Z
13:43:49:057 [INFO] ------------------------------------------------------------------------
13:43:49:059 [ERROR] Failed to execute goal on project okhttp-testing-support: Could not resolve dependencies for project com.squareup.okhttp3:okhttp-testing-support:jar:3.14.2-SNAPSHOT: Failure to find com.squareup.okhttp3:okhttp:jar:3.14.2-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of sonatype-snapshots has elapsed or updates are forced -> [Help 1]

@swankjesse working in CircleCI, but the travis build failures look almost intentional
https://github.com/square/okhttp/blob/okhttp_3.14.x/.buildscript/deploy_snapshot.sh
Should we be deploying snapshots only off master?

Yes
On Tue, Apr 23, 2019 at 3:11 PM Yuri Schimke<EMAIL_ADDRESS>wrote:

@swankjesse https://github.com/swankjesse working in CircleCI, but the
travis build failures look almost intentional
https://github.com/square/okhttp/blob/okhttp_3.14.x/.buildscript/deploy_snapshot.sh
Should we be deploying snapshots only off master?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/pull/4926#issuecomment-485936540, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAQIEM3DXQ3UP3KOTTVUMLPR5NOLANCNFSM4HFBF2NQ
.


unexpected end of JSON input

Fresh install. Docker compose. Android app returns "unexpected end of JSON input".
version: "3"
services:
  app:
    container_name: waveline-api
    restart: always
    build: ./
    environment:
      - MONGO_URL=mongodb://${MONGO_USERNAME}:${MONGO_PASSWORD}@mongodb/waveline?authSource=admin
      - MUSIC_PATH=/music
      - ART_PATH=/art
      - SPOTIFY_ID=${SPOTIFY_ID}
      - SPOTIFY_SECRET=${SPOTIFY_SECRET}
      - AUTH_ENABLED=true
      - API_KEY=${API_KEY}
      - PORT=5000
      - HOST=https://waveline.${DOMAINNAME}:5000
    volumes:
      - ${MUSIC_PATH}:/music
      - ./.cache:/art
    ports:
      - "5000:5000"
    links:
      - mongodb
    depends_on:
      - mongodb
  mongodb:
    image: mongo:latest
    container_name: "mongodb"
    environment:
      - MONGO_DATA_DIR=/data
      - MONGO_LOG_DIR=/dev/null
      - MONGO_INITDB_ROOT_USERNAME=${MONGO_USERNAME}
      - MONGO_INITDB_ROOT_PASSWORD=${MONGO_PASSWORD}
    volumes:
      - ./data/mongo:/data
    ports:
      - 27018:27017
    command: mongod --auth --logpath=/dev/null

Android version is stock Q running version 1.5.4 of the app.

Does this happen after the QR scanning or when loading the music library?

When trying to add the server manually in the android app. I've wondered where the QR code is supposed to be. Thought it was just planned but not yet implemented.

I got the same error when trying to add the server manually. Seems like it needs to be HTTPS.
Solved it by throwing the Waveline server behind HAProxy with a valid TLS certificate.
Also, I couldn't find where you would get the QR code either. :)


Angular 7 Integration

After reading the docs I can't for the life of me make it work with Angular 7.2.
After running the following command:

It fails with the following output:

Please fix it ASAP

Solution to this is

this one fix problem for me!  @ramarivera

nice trick @sanket30  :+1:


(#82) Add --no-progress to choco commands

This PR adds --no-progress to make the console a bit less spammy to end users. I've also made the choco calls themselves consistent across all files using an array for arguments.
Fixes #82

Sorry, one follow-up. If you'd like to update the secondary CCM Setup file to include the--no-progress as well, that would be ideal. Just keeping the change consistent across all our files.

Fixed this!


Cross compile from macos

Ciao,
when I try to cross-compile with this env from macos,
GOARCH=amd64
GOOS=freebsd
CGO_ENABLED=0

PATH=$GOROOT/bin:$PATH:/usr/local/bin

get this errors:
# github.com/lestrrat-go/libxml2/xsd
../../../github.com/lestrrat-go/libxml2/xsd/xsd.go:29:15: undefined: clib.XMLSchemaParse
../../../github.com/lestrrat-go/libxml2/xsd/xsd.go:40:15: undefined: clib.XMLSchemaParseFromFile
../../../github.com/lestrrat-go/libxml2/xsd/xsd.go:55:12: undefined: clib.XMLSchemaFree
../../../github.com/lestrrat-go/libxml2/xsd/xsd.go:65:10: undefined: clib.XMLSchemaValidateDocument
# github.com/lestrrat-go/libxml2/xpath
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:40:30: undefined: clib.XMLXPathObjectType
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:45:9: undefined: clib.XMLXPathObjectFloat64
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:50:9: undefined: clib.XMLXPathObjectBool
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:74:13: undefined: clib.XMLXPathObjectNodeList
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:91:13: undefined: clib.XMLXPathObjectNodeList
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:124:2: undefined: clib.XMLXPathFreeObject
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:129:14: undefined: clib.XMLXPathCompile
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:149:2: undefined: clib.XMLXPathFreeCompExpr
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:163:17: undefined: clib.XMLXPathNewContext
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:179:9: undefined: clib.XMLXPathContextSetContextNode
../../../github.com/lestrrat-go/libxml2/xpath/xpath.go:179:9: too many errors

with this env:
GOARCH=amd64
GOOS=freebsd
CGO_ENABLED=1

PATH=$GOROOT/bin:$PATH:/usr/local/bin

get this errors:
# runtime/cgo
gcc_freebsd_amd64.c:46:2: error: implicit declaration of function 'SIGFILLSET' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
gcc_freebsd_amd64.c:46:13: error: variable 'ign' is uninitialized when used here [-Werror,-Wuninitialized]
gcc_freebsd_amd64.c:41:14: note: initialize the variable 'ign' to silence this warning

Any idea?
T.I.A. Franco

CGO_ENABLED=0 means it doesn't compile the C/Go bridge. So the first example can't work.
And remember: (pure) Go supports cross platform compilation, but C does not. Therefore you can't cross compile on a mac for freebsd when cgo is in action. Run it on a freebsd machine.

@lestrrat Hi, is that mean if can't work on windows if i dont build it with visual studio or cgywin like?

It's the same as when you are building a C program. You build in the same arch/os as the where you intend to run the program.

It's the same as when you are building a C program. You build in the same arch/os as the where you intend to run the program.

Thanks a lot. Instsall vs environment taks lots of time, so i swich to the ubuntu to "quick fix this issue" :(

That works too!


Timeline View not working

describe the bug
The timeline view doesn't function for some reason, I couldn't find out why just yet but it looks bugged and it doesn't allow me to do anything in the view itself
expected behaviour
I should be able to use the timeline view but for some reason it's not working
screenshots
Default Notion

Notion Enhancer

platform
Windows 10  notion-enhancer/0.10.0 win32-x64 node-v12.16.2

Thank's for reporting, was thinking I was the only one to have this problem.
Seems to happen because of theme.css, see bellow

it's caused because of the z-index: 1; property of theme.css (in DevTools source pannel, it's located in /core/css/theme.css), see bellow

disabling it solves the problem, see bellow

I'm investigating why this line is here and how to prevent CSS leak without breaking anything else.

The bug seems to be fixed in this commit
I think we'll have a fix soon, because this fix seems to be related with #211

Ahh yep. Been having this issue too. Glad it's not not just mine.

should be fixed - colours aren't perfect in themes, but everything is visible/works.


Deploy Checklist: New Expensify 2022-07-25

Release Version: 1.1.86-5
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

https://github.com/Expensify/App/pull/9294

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9423

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9589

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9613

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9677

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9769

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9800

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9834

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9836

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9895

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9906

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9931

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9934

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9942

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9943

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9946

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9956

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9960

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9987

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/9991

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/9994

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10002

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10007

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10008

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10019

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10020

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10023

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10030

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10035

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/10039

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/10043

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10062

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10092

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10096

[x] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10113

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10123

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/10136

[ ] QA
[ ] Accessibility

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/10079
[x] https://github.com/Expensify/App/issues/10083
[x] https://github.com/Expensify/App/issues/10085
[x] https://github.com/Expensify/App/issues/10086
[x] https://github.com/Expensify/App/issues/10087
[x] https://github.com/Expensify/App/issues/10088
[ ] https://github.com/Expensify/App/issues/10094
[ ] https://github.com/Expensify/App/issues/10097
[x] https://github.com/Expensify/App/issues/10098
[ ] https://github.com/Expensify/App/issues/10099
[x] https://github.com/Expensify/App/issues/10100
[x] https://github.com/Expensify/App/issues/10105
[x] https://github.com/Expensify/App/issues/10106
[ ] https://github.com/Expensify/App/issues/10130
[x] https://github.com/Expensify/App/issues/10133
[x] https://github.com/Expensify/App/issues/10134

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.86-0 :rocket:

I believe #10079 is related to a PR that I merged recently. I'm OOO today but will be able to take a look at this first thing tomorrow. Can we take this off the deploy checklist?

@jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

@jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

@luacmartins sorry, that's actually  exactly what I meant! Let's go ahead and revert it, I'll take a look into a fix tomorrow.

Sure, wanna put up a revert? I can review it.

Reverting https://github.com/Expensify/App/pull/9294 because it is causing the issue here https://github.com/Expensify/App/issues/10085

https://github.com/Expensify/App/issues/10094 seems related to removing the getBetas() call

This one https://github.com/Expensify/App/issues/10088 seems related to the same PR we are talking about reverting above (this one). Auto-revert option didn't work so it will need to be reverted and conflicts fixed.

Thanks for the help @marcaaron!

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.86-1 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-1 has been deployed to staging :tada:

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.86-2 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-2 has been deployed to staging :tada:

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.86-4 :rocket:

@luacmartins Regression is completed
PR https://github.com/Expensify/App/pull/9294 Is failing due to https://github.com/Expensify/App/issues/10107. Not a blocker checking off
PR https://github.com/Expensify/App/pull/9423 is failing due to  https://github.com/Expensify/App/issues/10083. We will retest on the newest build
PR https://github.com/Expensify/App/pull/9589#issuecomment-1194410190 - Internal QA
PR https://github.com/Expensify/App/pull/9613 Is failing with KI. Checking off
PR https://github.com/Expensify/App/pull/9677 is failing due to  https://github.com/Expensify/App/issues/10106
PR https://github.com/Expensify/App/pull/9769 is failing due to https://github.com/Expensify/App/pull/9769#issuecomment-1194760400
PR https://github.com/Expensify/App/pull/9800 is failing due to https://github.com/Expensify/App/issues/10079 & https://github.com/Expensify/App/issues/10108 . We will retest and check off
PR https://github.com/Expensify/App/pull/9834
PR https://github.com/Expensify/App/pull/9895 is failing due to https://github.com/Expensify/App/issues/10087. Since blocker is removed, Can I check off?
PR https://github.com/Expensify/App/pull/9906 failing https://github.com/Expensify/App/issues/10104. not a blocker. checking off
PR https://github.com/Expensify/App/pull/9943 is blocked by https://github.com/Expensify/App/issues/10084
PR https://github.com/Expensify/App/pull/10023 was failing due to https://github.com/Expensify/App/issues/10079. Will retest and confirm
and Checking CPs.
Will send updated summary in a bit

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-4 has been deployed to staging :tada:

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.1.86-5 :rocket:

I removed the blocker label from the issues below:

https://github.com/Expensify/App/issues/10100 - this could be a problem, but we can't repro it
https://github.com/Expensify/App/issues/10134 - we couldn't reproduce and it's a small UI/UX issue

@mvtglobally

PR https://github.com/Expensify/App/pull/9895 is failing due to https://github.com/Expensify/App/issues/10087. Since blocker is removed, Can I check off?

Yes, we can check this off. The PR was reverted.

PR https://github.com/Expensify/App/pull/9943 is blocked by https://github.com/Expensify/App/issues/10084

I think this should be productionQA now

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-5 has been deployed to staging :tada:

@mvtglobally could you please send another QA summary?

sure, Will share summary in a bit.

@luacmartins
PR https://github.com/Expensify/App/pull/9423  Retested on the newest build. Checking off
PR https://github.com/Expensify/App/pull/9589#issuecomment-1194410190 - Internal QA
PR https://github.com/Expensify/App/pull/9677 Retested. Issue is still failing. Do we need to wait for push https://github.com/Expensify/Web-Expensify/pull/34424?
PR https://github.com/Expensify/App/pull/9769 is failing due to https://github.com/Expensify/App/pull/9769#issuecomment-1194760400 - Any feedback if we can check it off? We are unable to verify.
 We are double checking now
and checking https://github.com/Expensify/App/pull/10136 which just got added

PR https://github.com/Expensify/App/pull/9677 Retested. Issue is still failing. Do we need to wait for push https://github.com/Expensify/Web-Expensify/pull/34424?

I don't think we should wait for this, since it's a small UI issue and the Web-E deploy can take another day or two. I'm checking it off. Can we retest this next week?

PR https://github.com/Expensify/App/pull/9769 is failing due to https://github.com/Expensify/App/pull/9769#issuecomment-1194760400 - Any feedback if we can check it off? We are unable to verify.

I tested this on staging and could see the expensifail.com room. Checking it off

@mvtglobally any updates on the below?

PR https://github.com/Expensify/App/pull/10092 Android was failing due to https://github.com/Expensify/App/issues/10083. We are double checking now
and checking https://github.com/Expensify/App/pull/10136 which just got added
We are also re-testing 3 Blockers as per your steps

@mvtglobally

I shared the android APK with you on Slack.
Removed the blocker from the issues below since we didn't manage to reproduce them and they only affect beta features:

https://github.com/Expensify/App/issues/10097
https://github.com/Expensify/App/issues/10094
https://github.com/Expensify/App/issues/10097

Let me know once QA finishes and we are ready to deploy!

@luacmartins testers can still repro all issues on the build 1.1.86-5.
https://user-images.githubusercontent.com/43995119/181751995-ddd67164-0aa1-46b0-bf36-951810760c6c.mp4
https://user-images.githubusercontent.com/43995119/181752003-cb7e1677-76aa-4878-a1a0-16ce15b73b34.mov
https://user-images.githubusercontent.com/43995119/181752015-8b169a90-6d3a-40a1-8cd8-010d118e097f.mp4
https://user-images.githubusercontent.com/43995119/181752019-db3bfed3-3b8c-4164-99ad-feea5a4368f7.mp4

@yuwenmemon here’s the latest checklist. I think QA is still able to reproduce a few issues and based on this thread, we have a potential regression in App performance - https://expensify.slack.com/archives/C01GTK53T8Q/p1659018169624599

Sounds good - it looks like we need to start a fire-room as the deploy has been going on for more than 4 days now.

Localize decimal separator was reverted so I'm checking it off

https://github.com/Expensify/App/pull/9423 was mentioned in this comment as being retested, checking off https://github.com/Expensify/App/issues/10077#issuecomment-1197576934

:shipit:


Add fixer?

Overview
Added php fixer to the actions

Coverage decreased (-0.03%) to 88.101% when pulling daec0033dda726a87b3f9327b84dc0b004f769ff on addActionPHPFixer into dfbc61dee0a5b3d983b069ee1608b2e0fc8c0d71 on develop.


Crash from in ppTask (IDFGH-1194)

In our board, we are seeing crash in ppTask.  Below is the partial log.  Attached is the call trace and bootup log.
After the rebooting from the assert, board doesn't recovers, assert keep's happening at the same place.  Using Reset pin or Power cycling the board recovers the problem.
Please check and provide us some pointers.
.
.
.
[Sun May 19 02:01:43.779 2019] assertion "(res == portMUX_FREE_VAL) == (mux->count == 0)" failed: file "C:/ESP_Latest/msys32/home/sjoteppagol/esp-idf-v3.2.beta1.tip/components/freertos/portmux_impl.inc.h", line 106, function: vPortCPUAcquireMutexIntsDisabledInternal
[Sun May 19 02:01:43.795 2019] abort() was called at PC 0x401090bf on core 0
[Sun May 19 02:01:43.795 2019]
[Sun May 19 02:01:43.795 2019] Backtrace: 0x40096e1c:0x3ffe53d0 0x40097049:0x3ffe53f0 0x401090bf:0x3ffe5410 0x40093bdd:0x3ffe5440 0x401758fd:0x3ffe5460 0x401759ff:0x3ffe5480 0x401c6a50:0x3ffe54a0 0x4019c616:0x3ffe5500 0x401893c1:0x3ffe5580 0x40189ccd:0x3ffe55a0 0x4018aa2d:0x3ffe56c0 0x4019437d:0x3ffe56e0 0x4008eb32:0x3ffe5730 0x40094cc5:0x3ffe5770
[Sun May 19 02:01:43.826 2019]
[Sun May 19 02:01:43.826 2019] Rebooting...
Backtraces.txt
bootupLog.txt

Hi @hvishu,
The assertion is failing because one of the "portmux" spinlocks has become invalid, in this case the aes_spinlock variable defined in aes.c. A portmux variable has two 32-bit fields - one is an "owner" field and one is a "count" variable. The assertion is failing because the "owner" seems to be set correctly, but the "count" doesn't match the expected value.
The most likely root cause is that something else has overwritten this memory address when it shouldn't be (Stray pointer, buffer overflow/underflow, etc). Unfortunately this could have happened anywhere in the app.
Can you please try looking at the output of nm -n build/my-app.elf, then look for the value aes_spinlock and look at the values before and after it in the address space? These may be useful clues as these variables have the addresses which are closest to the address of aes_spinlock, so a buffer overflow/underflow may lead to them overwriting the spinlock. But it's also possible for the cause to not be nearby at all.
The fact that a CPU reset doesn't solve the problem is very unusual. What peripherals are you using in your project? Do you have any interrupt service routines configured for them?
A temporary workaround for this exact failure would be to disable AES hardware acceleration, but I think probably the root cause is not in the AES accelerator so the bug will need to be fixed in another way, disabling AES will just cause some other variable(s) to be corrupted instead.

Thanks @projectgus for the details.
Attached is the nm output for your reference.
From the attachment you can see that after aes_spinlock, g_wifi_event_mask is present, I see this variable is coming from 80211 library.
3ffc0264 D rtc_spinlock
3ffc0270 d s_config
3ffc02a0 D g_wifi_osi_funcs
3ffc0424 d aes_spinlock
3ffc042c D g_wifi_event_mask
3ffc0430 D ccmp
3ffc0448 D TmpSTAAPCloseAP
Also, when the crash happens,  below log shows that it seems to be connecting to the network.  So it could be the variable "g_wifi_event_mask" which might be doing the memory corruption, though I am just speculating.
[Sun May 05 07:31:49.460 2019] I (3629) wifi: state: init -> auth (b0)
[Sun May 05 07:31:49.491 2019] I (3649) wifi: state: auth -> assoc (0)
[Sun May 05 07:31:49.507 2019] I (3659) wifi: state: assoc -> run (10)
[Sun May 05 07:31:49.522 2019] assertion "(res == portMUX_FREE_VAL) == (mux->count == 0)" failed: file "C:/ESP_Latest/msys32/home/sjoteppagol/esp-idf-v3.2.beta1.tip/components/freertos/portmux_impl.inc.h", line 106, function: vPortCPUAcquireMutexIntsDisabledInternal
[Sun May 05 07:31:49.538 2019] abort() was called at PC 0x401090bf on core 0
We are trying to get the issue reproduced, if so, I am planning to put a print statement to make sure that this issue is indeed caused by the memory corruption aes_spinlock->count, will let you know.  Any other inputs, or suggestions please let me know.
Regards,
vishwa
nm.txt

Hi vishwa,
Thanks for the details, agree that's a very strong hint about what might be writing out of bounds.
Just to check: Do you get any warnings in the build about submodule mismatch (or anything in the "git status" output that suggests wifi library submodule is not up to date?
If you're able to dump the value of both mux->owner and mux->count when the assert fails, that could be very helpful as well.
Angus

I also noticed you have quite an old development version of v3.3. Please consider updating to v3.3-beta3, or the release/v3.3 branch - which should be compatible with what you have, but more stable. The v3.3 final release should be available soon and you could consider updating to this as well. See Versions for a full explanation of IDF versioning.

Just to check: Do you get any warnings in the build about submodule mismatch (or anything in the "git status" output that suggests wifi library submodule is not up to date?
[Vishwa] Git status doesn't give any warning like that
If you're able to dump the value of both mux->owner and mux->count when the assert fails, that could be very helpful as well.
[vishwa]  Not easy to reproduce the issue, trying to find a reproduce sequence then I will add the prints
Regarding the version, something strange,
git status shows below
On branch release/v3.2
Your branch is up-to-date with 'origin/release/v3.2'.
git log shows
root@vishwanatha-L460:~/esp/esp-idf-v3.2.beta1.tip# git log
commit 8a69ffc36f166c964d7c30188a865847bf199561
Merge: a437e4d 95c7f45
Author: Jiang Jiang Jian<EMAIL_ADDRESS>Date:   Fri Feb 1 21:34:05 2019 +0800
Not sure why the IDF version is showing as 3.3.
To cross check this, we used the release version 3.2 (actually plan is to migrate to 3.2, there it show the IDF version as 3.2 in bootup log)

Hmm, that is unusual - I see the same here with git describe. We tagged v3.3-dev a few commits before v3.2-beta1, due to a late-breaking bug we fast-forwarded the release/v3.2 branch instead of backporting. So there are a few very early commits on the release/v3.2 branch that git describe as v3.3-dev.
Please update to v3.2 release version (including git submodule update --init --recursive) and let us know if this crash still occurs.

Hi @hvishu ,
Did you get a chance to update to the v3.2 release version?
Angus

Still looking at the issue, mainly trying to get the reproduce the sequence with more boards.  WIll keep you posted

@hvishu Thanks for reporting, would you please help share any updates for the issue? Thanks.

Closing due to lack of updates.


Hover area is broken for the Quick Supportal Switcher in OldDot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs reproduction (No access to support portal)
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728336580249879
Action Performed:
Precondition: User has support portal access

Hover over any part of the Quick Supportal Switch in OldDot

Expected Result:
It should be active and clickable
Actual Result:
The switcher is only active/clickable when hovering over the bottom-right corner of the switcher icon. When there is a account banner, it works as expected.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I reproduced easily in staging & in dev 👍  looking into this

The problem is that #bannerAnnouncement is not being hid when there is no banner - the HTML element still overlaps the supportal switch button :/

Something happened in one of these PRs i believe:

https://github.com/Expensify/Web-Expensify/pull/43426
https://github.com/Expensify/Web-Expensify/pull/43744

PR up ^

This is working now, I think we're good to close this out!


matrix-synapse: 1.7.3 -> 1.8.0

Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.8.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test matrix-synapse

@fpletz do you also want to do the backport? :)

Yeah, just ran the the test on 19.09. Pushed: f2b2cad9272e7c6c32d1ffeae6b85419201df976.

Awesome, thanks!


When I run the executable as a service the log does not write in file

I am using Logrus as logger. When I run the app in interactive the logger works perfectly, but when I run it as a Windows Service it does not work.

@marioarizaj did you end up finding a solution? I am also using logrus and am trying to figure out how to get my output. thanks!

@bradrydzewski When you run the executable as a windows service, the current path is "%SystemRoot%\system32" (usually "C:\Windows\System32"), so you need change dirctory to the binary path.
// changed path for service
if !debug {
	path, err := os.Executable()
	if err != nil {
		return err
	}
	path = strings.Replace(path, "\\", "/", -1) // windows
	err = os.Chdir(path[:strings.LastIndex(path, "/")])
	if err != nil {
		return err
	}
}

I add a debug flag for test.

You 666


rpglint NPM package hasn't been updated since 0.17.5

It doesn't look like the standalone rpglint package has been getting updated, can this be fixed? See https://www.npmjs.com/package/@halcyontech/rpglint

Just FYI however, there may be other issues with the latest. When I manually build and run against the main branch I'm getting a "Failed to lint... cannot read properties of undefined (reading 'start')" error on some sources that don't give an error on the old 0.17.5 version.
I haven't looked into that further yet. I was adding a feature to the rpglint CLI to filter the files to only look at changes in a recent set of git commits - ie to run via CI and report errors back.

Yes, the rpglint package needs some love. Didn't think many were using it. I can do that next week.

Right now I'm just playing with it... I'm hoping to start using it for real - I want to add it to our build pipeline to email developers with lint results based on commits to their feature branch. One of our developers is using the linting just as part of the vscode plugin though.
If you have time please take a look at the branch I'm working on and let me know if you have any concerns - https://github.com/brandonp42/vscode-rpgle/tree/add-rpglint-git-filter. I'll submit a PR though sometime soon.

Awesome, thank you!


Improve appinsight distributed trace setup guide and add deployment yamls

Description
Add local forwarder docker and deployment yamls.

Pushed localforwarder docker image to daprio org : https://hub.docker.com/r/daprio/dapr-localforwarder/tags
Updated docs

Issue reference
https://github.com/dapr/components-contrib/issues/207
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

cc/ @RicardoNiepel


Cannot install

Hi
npm install @alpine-collective/toolkit --save
Fail with this error:

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@alpine-collective%2ftoolkit - Not found
npm ERR! 404
npm ERR! 404  '@alpine-collective/toolkit@*' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

wrong repo, this one is for the old v2. alpine-collective/toolkit wasn't published. It should be available now.


Extension has unused properties

Right now the extension has saveAsFile and saveFilePath, neither of which seem to appear anywhere else in the code base. These should probably be removed, or implemented (I'd be happy to do it myself, but I'm not sure which of the above is the approach you'd like to take).
Thanks!

Good catch.
I would really appreciate it if you implemented the feature of saving JSON as a file. It must be useful when somebody wants to use this plugin in polyglot projects and in combination with some other coveralls reporters, such as cpp-coveralls, php-coveralls, python-coveralls etc. (Although nobody seems to be trying it for the moment, I believe somebody will need it someday.)


Table.batch_update

This is not ready for merging, but I wanted to submit a proof of concept for https://github.com/sirupsen/airrecord/issues/66 in case somebody else wants to run with it.
This enables an API for Table.batch_update that can take up to 10 existing records (they must already exist in Airtable) and bulk update them with a single API request, as Airtable's API now allows batches of 10 for created, updates, and deletes.
Still needs:

Better testing of the Table.batch_update function, but I've seen it working in a project.

Example usage
ben = Seat.find("recMxPcmAqeo7iGj7")
ben["Fun Fact"] = Faker::Music::UmphreysMcgee.song
Seat.batch_update([ben])

Other notes and potential breaking changes:

Removes record.hash, I didn't see it being used for anything aside from a test making sure it worked.
Removes record.serializable_fields, I didn't see it being used for anything aside from tests, use record.fields instead.
Adds record.to_h which gives the record format used in batch operations (i.e. includes id and fields)
Adds record.to_h(true) which gives the record format used in batch operations (i.e. includes id and fields), but ONLY includes the updated fields. This can be used for PATCH updates.

Ideal design for this:

Airtable now supports batches of 10 for gets, creates, and updates, and deletes. It would be awesome to have a Table.batch_upsert method that accepts up to 10 records, does a multi-get for the 10 records, figures out which ones already exist and don't exist, then runs Test.batch_create for the records that don't exist and Test.batch_update for the records that do exist. Then you could batch import records by just blasting them into Table.batch_upsert.

It's too bad you can't finish it, is it because you ended up not needing it in your own project?

Given that the gem is in a rough state I think let's close this for now as it adds more complexity, might be something to revisit in the future.


Preparation for 1.0.1 beta1

Updated nuspec and certificate validation date

Looks good @tomkuijsten, ok to merge back.


Text not visible with Azure Devops 'dark' themes

When viewing (for instance) a sequence diagram having chosen one of the 'dark' themes, much diagram text isn't visible. Perhaps change to render diagram onto an opaque white background, so matches 'light' theme?

Hi @kfsdl, thank you for reporting this issue,
I'm going to evaluate a full support for dark theme but this need more time,
at the moment, as you proposed, I could add a white background like the following, I'm going to release this fix in a few days

I tried to deep dive about Mermaid themes, I find out that you can easly change your theme adding %%{init: {'theme':'dark'}}%% in your mermaid file, in this way you can personalize your theme.

That's ... ok for individual use I guess, but in a group where some people use dark, others not, results aren't great when viewing a diagram with theme-dark directive in a non-dark AD theme ... and it seems like you'd have to add the directive to every mermaid file, which is tricky if you don't have permissions on some repos (and/or there are lots of them) ... Maybe the ideal thing would be for the viewer somehow to inject the appropriate directive based on the AD theme ... but short of that or other theme support, I'd personally say adding a white background would be a better option if you're still considering that ...

Ok, I got your point, I'm going to add white background in the next days.

Hi @kfsdl,
as you can see in the PR: https://github.com/daniecas/azure-devops-mermaid-viewer/pull/4
now this Extension support the dark thems
thank you for your report

Hi @kfsdl, as you can see in the PR: #4 now this Extension support the dark thems
thank you for your report

Excellent, thank you!


Members identification as uint32

This PR is a follow-up of https://github.com/keep-network/keep-core/pull/2666/files#r732629138
To reduce costs of storing members on-chain we switched from members identification with addresses to unique uint32 identifiers assigned by sortition pool.
Gas usage before this change:
|  Contract                ·  Method                                                   ·  Min        ·  Max        ·  Avg        ·  # calls      ·  eur (avg)  │
···························|···························································|·············|·············|·············|···············|··············
|  RandomBeaconStub        ·  submitDkgResult                                          ·     754806  ·    2147836  ·    1921703  ·           74  ·          -  │

Gas usage with this change:
|  Contract                ·  Method                                                   ·  Min        ·  Max        ·  Avg        ·  # calls      ·  eur (avg)  │
···························|···························································|·············|·············|·············|···············|··············
|  RandomBeaconStub        ·  submitDkgResult                                          ·     867586  ·    1146408  ·    1095996  ·           74  ·          -  │

Merging to unblock other PRs, review comments will be addressed in separate PRs.

wow, avg. gas from 1921703 to 1095996!


DDC+-dev.3.0: '_Future' is not a subtype of ...

'_Future' is not a subtype of type 'Future<ComponentRef<TestWithNullComponent>>'
This is blocking DDC-dev.30, and Dart2.
Code:
https://github.com/dart-lang/angular/blob/f55fea736cb25040be640e75541acfbcd34e0329/angular/lib/src/core/linker/component_factory.dart#L62-L93
Notably, we can't just unsafeCast ComponentRef<dynamic>:
https://github.com/dart-lang/angular/blob/f55fea736cb25040be640e75541acfbcd34e0329/angular/lib/src/core/linker/component_factory.dart#L88-L91
... because it is an an AppView<dynamic>, not an AppView<T>.
This violates our contract. We have a couple of options:

Always return a ComponentRef<dynamic>: We lose auto-complete/type-safety.
Add a .cast<E> method to ComponentRef and use it = extra work per load.
Try and get the _View{Name}Host to return <T> not <dynamic>.

The last one is the "right" thing to do, but likely not easy.

Oops, turns out we do type this correctly:
https://github.com/dart-lang/angular/blob/f55fea736cb25040be640e75541acfbcd34e0329/_goldens/test/_files/component_loader_pattern.template_release.golden#L52-L59
... or mostly, so there is something else going on.

OK, looks easier than expected to fix.
Looks like something related with type inference in DDC. I'll file a bug.

Nope, we just had a return type of dynamic instead of R. Fixing...


IAMAccessKey Claim through Composition is causing multiple Key creation

What happened?
When creating IAMAccessKey resource using Composition
First issue: During reconciliation, it made multiple call for IAMAccessKey creation which caused it to repeatedly created keys
As current AWS only allow maximum 2 key-pairs , it will stuck with error as follows:
conditions:
  - lastTransitionTime: "2021-06-15T17:07:04Z"
    message: 'create failed: failed to create the IAMAccessKey resource: LimitExceeded:
      Cannot exceed quota for AccessKeysPerUser: 2'
    reason: ReconcileError
    status: "False"
    type: Synced
  - lastTransitionTime: "2021-06-15T17:07:04Z"
    reason: Creating
    status: "False"
    type: Ready

Second issue: Also the deletion process is not completed successfully as IAMUser complaining it cannot delete even the Key has been set to accessKeyStatus:  Inactive
conditions:
  - lastTransitionTime: "2021-06-15T17:15:10Z"
    reason: Deleting
    status: "False"
    type: Ready
  - lastTransitionTime: "2021-06-15T17:14:16Z"
    message: 'delete failed: cannot delete the IAM User resource: DeleteConflict:
      Cannot delete entity, must delete access keys first.'
    reason: ReconcileError
    status: "False"
    type: Synced

How can we reproduce it?
Create composition file , XRD which take parameters for creation of IAMUser and IAMAccessKey attached to it
Also try to delete the Claim resource after that
What environment did it happen in?
Crossplane version: v1.2.1
provider-aws: v0.18.0

@kelvinwijaya I haven't dug into it, but my first guess would be that your composition might be overwriting the external-name annotation of your IAMAccessKey on each reconcile. Are you perhaps patching the annotations of your resource? Or is it possible you're being hit by https://github.com/crossplane/crossplane/issues/2350?

Hi @negz ,
You are right, the resource is doing late Initialization, and my composition patch has metadata.anntotations . After removing this , problem were solved.
Thanks for your prompt reply.
I will proceed to close this case


Make blas dependency explicit

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Xref: https://github.com/conda-forge/r-spatstat-feedstock/pull/11

Xref: https://github.com/conda-forge/r-raceid-feedstock/pull/1

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.