Content-Type header expects duplicate values

Rather than repeat the repro/details, this is an upstream issue to track https://github.com/pact-foundation/pact-js/issues/1106.

It's a bug, in that prior to this version the behaviour was different. Any implementation that allows a user to specify the content-type header (which would be all of them) will have this problem, and you actually want to be able to do this to make the test explicit. Guarding this in the FFI client libraries means a lot of duplication.


Split initiation charge onto separate invoice

per memcom request - initiation fee should be charged as soon as employment verification is complete.

Re-tested with the parallelized stripe calls


add mypy for type check?

https://github.com/fsspec/opendalfs/blob/459710ced41c935c5fc9d335f785e446134e6e78/.github/workflows/ci.yml#L32-L37
https://github.com/python/mypy?tab=readme-ov-file#quick-start

Hello, based on what I understand, the Python code in this repository appears to be a simple wrapper such as __all__ = _opendalfs.__all__. At this stage, type checking is unnecessary.

I'm going to close this issue now. Feel free to reopen it if you still have questions.


💅 bsx chain in new landing

{
    rmrk: 'RMRK',
    snek: 'Snek (Rococo)',
    bsx: 'Basilisk',
}

PR type

[x] Bugfix
[x] Feature

What's new?

[x] PR closes #4065
[x] Add bsx data in new landing
[x] Add bsx in searchbar
[x] snek (rococo) vs basilisk (kusama)

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

[x] Fill up your KSM address: Payout

Screenshot

😍 Perfect, I’ve sent the payout
💵 $50 @ 42.19 USD/KSM ~ 1.185 $KSM
🧗 DVYy1qnocE8t6ZvUfPx3rEjG829khNRXx3YrCGVHHj19Lcb
🔗 0x9dc2b07a6608075c189ba4db6e82bca38c61320e1daf58397dab46d4c8761c9a
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


updated azure cloud-config and cpi to accept a vnet resource group name

updated cloud-config.yml and cpi.yml file to accept a resource group name for vnet in azure if the vnet is shared for different deployments.

@agnelantony2 i think that deserves a dedicated ops file since this is not a default scenario.

i thought you can specify same resource group name if both bosh and deployments are on the same resource group. but, if separate ops file is the go, will update it.

i thought you can specify same resource group name if both bosh and deployments are on the same resource group.

you can, but we dont want to ask user for config that is not required.


compile errors

i now get compile errors on
$ make && make install
Scanning dependencies of target uvc
[ 10%] Building C object CMakeFiles/uvc.dir/src/ctrl.c.o
[ 20%] Building C object CMakeFiles/uvc.dir/src/ctrl-gen.c.o
[ 30%] Building C object CMakeFiles/uvc.dir/src/device.c.o
[ 40%] Building C object CMakeFiles/uvc.dir/src/diag.c.o
[ 50%] Building C object CMakeFiles/uvc.dir/src/frame.c.o
[ 60%] Building C object CMakeFiles/uvc.dir/src/init.c.o
[ 70%] Building C object CMakeFiles/uvc.dir/src/stream.c.o
[ 80%] Building C object CMakeFiles/uvc.dir/src/misc.c.o
[ 90%] Building C object CMakeFiles/uvc.dir/src/frame-mjpeg.c.o
make[2]: *** No rule to make target `/usr/local/lib/libjpeg.dylib', needed by `libuvc.dylib'.  Stop.
make[1]: *** [CMakeFiles/uvc.dir/all] Error 2
make: *** [all] Error 2

any suggestions. i have /usr/local/lib/libjpeg.dylib which is an alias pointing to  -> ../Cellar/jpeg/8d/lib/libjpeg.dylib . tx a bunch

somehow my previous homebrew installs for libjpeg and libusb had gotten lost, reinstalled both with homebrew and all is good again.


[Bug]: Launch template error causing EC2 nodes to fail joining the node group properly

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version
34921232356fb69b5a41094246d488c37c596d97
What is your environment, configuration and the example used?

Terraform 1.1.7

module "eks_blueprints" {
  source  = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=34921232356fb69b5a41094246d488c37c596d97"

  org               = var.org
  tenant            = var.tenant
  environment       = var.environment
  zone              = var.zone
  tags              = var.tags

  // NOTE: Add-ons are not updated automatically when the cluster is updated.
  // You will need to do this at the appropriate time for each addon, if it is required.
  // See: https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/docs/add-ons/index.md
  terraform_version = var.terraform_version

  # KMS
  cluster_kms_key_additional_admin_arns = var.cluster_kms_key_additional_admin_arns

  # Auth
  map_roles         = var.map_roles
  application_teams = var.application_teams
  platform_teams    = var.platform_teams

  # EKS Cluster VPC and Subnets
  vpc_id             = local.vpc_id
  private_subnet_ids = local.private_subnet_ids
  //public_subnet_ids  = local.public_subnet_ids

  # EKS CONTROL PLANE VARIABLES
  cluster_version                  = var.cluster_version
  cluster_endpoint_private_access  = false
  cluster_endpoint_public_access   = true

  # EKS MANAGED NODE GROUPS
  managed_node_groups = {
  ondemand_v1 = {
    node_group_name = "ondemand_v1"

    create_launch_template  = true
    launch_template_os      = "amazonlinux2eks"

    instance_types = ["t3a.large"]
    subnet_type    = "private"
    ami_type       = "AL2_x86_64"
    capacity_type  = "ON_DEMAND"
    disk_size      = 50

    desired_size    = 1
    min_size        = 1
    max_size        = 4
    max_unavailable = 1
  }
}
}

What did you do and What did you see instead?
This will produce 2 node groups, instead of 1.

The node group created by the AWS blueprints module aws-eks-managed-node-groups appears to be correct (the user data looks good), but it also appears to be unused.
Instead, it appears that the underlying https://github.com/terraform-aws-modules/terraform-aws-eks is ALSO creating a launch template and that template is being used by the instance, but is broken.
This template https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/templates/linux_user_data.tpl is being used and is creating multiple bootstrap lines, which is causing the script to fail and therefore causing the node group to fail.
This is what the incorrect script looks like:

Additional Information
No response

We are digging into the terraform modules to track the logic and figure out where the issue is, but any insight would be helpful, as it took us a while to determine that this is the underlying issue.

I'm stumped for the moment...

Hi @spkane! I am going to try and reproduce the issue using the example and get back to you. We definitely don't see the double node group issue in our testing.

@spkane I am able to reproduce the issues you are reporting. We will debug the root cause and have a fix prepared.

I've traced the EC2 node failure to join the cluster issue to https://github.com/awslabs/amazon-eks-ami/pull/893. I see this in the /var/log/cloud-init-out.log on the instance.
mv: cannot stat ‘/etc/eks/iptables-restore.service’: No such file or directory
Exited with error on line 485

Also looks like @vara-bonthu already hit this issue as well. We will keep you posted but you can also follow the issue by adding your +1 there :)

After rerunning the cloud-init my node seems fine, although EKS is still reporting the node group failed to join.
▶ k get pods -A
NAMESPACE     NAME                      READY   STATUS    RESTARTS   AGE
kube-system   aws-node-bnsrv            1/1     Running   0          94m
kube-system   coredns-f47955f89-djlgz   1/1     Running   0          100m
kube-system   coredns-f47955f89-tpl25   1/1     Running   0          100m
kube-system   kube-proxy-7gh4h          1/1     Running   0          94m

▶ k get nodes
NAME                                        STATUS   ROLES    AGE   VERSION
ip-10-0-12-184.us-east-2.compute.internal   Ready    <none>   94m   v1.21.5-eks-9017834

▶ k get cm aws-auth -n kube-system -o yaml
apiVersion: v1
data:
  mapAccounts: |
    []
  mapRoles: |
    - "groups":
      - "system:bootstrappers"
      - "system:nodes"
      "rolearn": "arn:aws:iam::XXXXXXXXX:role/aws-preprod-dev-eks-ondemand_v1"
      "username": "system:node:{{EC2PrivateDNSName}}"
  mapUsers: |
    []
kind: ConfigMap
metadata:
  creationTimestamp: "2022-04-20T04:57:25Z"
  labels:
    app.kubernetes.io/managed-by: Terraform
    terraform.io/module: terraform-eks-blueprints
  name: aws-auth
  namespace: kube-system
  resourceVersion: "913"
  uid: 34cff032-8f26-4498-a22c-f9da2cabb88f

@askulkarni2 Thank you for looking into this. I am really glad to know that this isn't just me.
A few things:

The problem with the node group never showing up as healthy, once the initial failure occurs, is a know AWS issue that is on their roadmap. We should all +1 it.

https://github.com/aws/containers-roadmap/issues/764

I am having trouble tracing the blueprints terraform code and even understanding where the upstream managed node module is getting called. It appears to me that you all are using your own module. What bit of logic am I missing here?

I ran into the issue with the bootstrap.sh script but did not know there was an issue already. That script is not currently idemoptent, because it runs an mv command instead of a cp command for the iptables.

https://github.com/awslabs/amazon-eks-ami/pull/893
This is a problem, but fixing it would only mask the underlying problem, which appears to be that this user-data template is getting used incorrectly and creating a bad user-data script with two bootstrap commands in it.

Also, did you see the multiple node groups created? If so, any idea how that is happening? Maybe because both modules are duplicating a step?

One of these launch groups has a good user-data script, but the other does not, yet the bad one is used. I think somehow the modules are both creating a launch template and this is part of the issue.

I think the most useful next step would be to understand:

How is this template being pulled in? https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/templates/linux_user_data.tpl
And in that template, why is enable_bootstrap_user_data true, when it defaults to false and doesn't appear to be set anywhere.

Making some progress. Creating a minimal managed node group with this definition works fine:
managed_node_groups = {
  ondemand_v1 = {
    node_group_name = "ondemand_v1"

    //create_launch_template  = true
    //launch_template_os      = "amazonlinux2eks"

    //instance_types = ["m5.8xlarge"]
    instance_types = ["t3a.large"]
    //subnet_type    = "private"
    //ami_type       = "AL2_x86_64"
    //capacity_type  = "ON_DEMAND"
    //disk_size      = 50

    //desired_size    = 1
    min_size        = 1
    //max_size        = 4
    max_unavailable = 1
  }
}

and results in this single launch template:

with this contents:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="//"

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex
B64_CLUSTER_CA=AAAA==
API_SERVER_URL=https://AAA.gr7.us-east-1.eks.amazonaws.com
K8S_CLUSTER_DNS_IP=<IP_ADDRESS>
/etc/eks/bootstrap.sh trilambs-sbox-poc2-eks --kubelet-extra-args '--node-labels=eks.amazonaws.com/nodegroup-image=ami-05a282ba7e9059211,eks.amazonaws.com/capacityType=ON_DEMAND,eks.amazonaws.com/nodegroup=ondemand_v1-20220420121245938700000005' --b64-cluster-ca $B64_CLUSTER_CA --apiserver-endpoint $API_SERVER_URL --dns-cluster-ip $K8S_CLUSTER_DNS_IP

--//--

which I am pretty sure is created by the upstream module's code.

Changing the managed node group to this:
managed_node_groups = {
  ondemand_v1 = {
    node_group_name = "ondemand_v1"

    create_launch_template  = true
    launch_template_os      = "amazonlinux2eks"

    //instance_types = ["m5.8xlarge"]
    instance_types = ["t3a.large"]
    //subnet_type    = "private"
    //ami_type       = "AL2_x86_64"
    //capacity_type  = "ON_DEMAND"
    //disk_size      = 50

    //desired_size    = 1
    min_size        = 1
    //max_size        = 4
    //max_unavailable = 1
  }
}

results in two launch templates and now things are broken:

Hi @spkane - hopefully I can help clarify a few details.
This module only uses the upstream terraform-aws-eks control plane - it does not use the upstream functionality for creating self managed node groups, EKS managed node groups, or fargate profiles.
The user data that this module users for EKS managed node groups can be found here https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/aws-eks-managed-node-groups/templates
When  using the EKS managed node group, there are a few scenarios to consider with launch templates:

By default, the EKS managed node group service will create its own launch template. This is what you are seeing here
When you tell the module to create a launch template, that launch template will be merged with the launch template created by the EKS managed node group service. This is why you will see 2 launch templates when you specify create_launch_template = true. This is also where the user data is merged between the user supplied launch template and the user data supplied by the EKS managed node group service. The user data the EKS managed node group service provides is only the bootstrap script invocation to join the node to the control plane and is the last portion of the MIME multi-part script text
If a user specifies an ami_id when using the EKS managed node group service, the bootstrap script user data MUST be supplied because the EKS managed node group service will not supply it and merge it into the user data. That is where these templates come into play https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/aws-eks-managed-node-groups/templates

Thank you @bryantbiggs those details do help make the underlying decision tree clearer.
So, it appears that the merge is what is causing the issue.
One launch template looks like this:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="//"

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex

# User-supplied pre userdata code

# Bootstrap and join the cluster
/etc/eks/bootstrap.sh --b64-cluster-ca 'AAA==' --apiserver-endpoint 'https://AAA.gr7.us-east-1.eks.amazonaws.com'  --kubelet-extra-args "" 'foo-sbox-poc2-eks'

# User-supplied post userdata code

--//--

and the other one that actually gets used looks like this:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="//"

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex

# User-supplied pre userdata code

# Bootstrap and join the cluster
/etc/eks/bootstrap.sh --b64-cluster-ca 'AAA==' --apiserver-endpoint 'https://AAA.gr7.us-east-1.eks.amazonaws.com'  --kubelet-extra-args "" 'foo-sbox-poc2-eks'

# User-supplied post userdata code

--//
Content-Type: text/x-shellscript; charset="us-ascii"
#!/bin/bash
set -ex
B64_CLUSTER_CA=AAA==
API_SERVER_URL=https://AAA.gr7.us-east-1.eks.amazonaws.com
K8S_CLUSTER_DNS_IP=<IP_ADDRESS>
/etc/eks/bootstrap.sh foo-sbox-poc2-eks --kubelet-extra-args '--node-labels=eks.amazonaws.com/sourceLaunchTemplateVersion=1,eks.amazonaws.com/nodegroup-image=ami-05a282ba7e9059211,eks.amazonaws.com/capacityType=ON_DEMAND,eks.amazonaws.com/nodegroup=ondemand_v1-20220420130614890600000001,eks.amazonaws.com/sourceLaunchTemplateId=lt-0f9b98db4d23059b2' --b64-cluster-ca $B64_CLUSTER_CA --apiserver-endpoint $API_SERVER_URL --dns-cluster-ip $K8S_CLUSTER_DNS_IP

--//--

Which now, actually makes me think that the fix is to modify this template (and maybe the other ones) in this blueprints repo to REMOVE the bootstrap.sh call.
https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/aws-eks-managed-node-groups/templates/userdata-amazonlinux2eks.tpl
Maybe, there needs to be a different template when one is providing an AMI and must include bootsrap.sh and when one is just using the default AMI?

This change in the template worked around my immediate issue.
https://github.com/spkane/terraform-aws-eks-blueprints/compare/main...mng-launch-templates
But I think that line is required when one is providing their own AMI, so there likely needs to be some logic to detect when someone passes in an AMI that determines which template to use.

Thank you @vara-bonthu ! I really appreciate it. I could have pulled the PR together, but honestly, this took long enough to track down that I need to focus on my project's more immediate goal for a few days.

I am running some final tests to ensure if it works for all scenarios. We will raise a PR soon.


Cannot Find jsPDF in Ionic 2

I am working on Ionic 2 project and I want to use jsPDF library in that project
First I installed jsPDF like this
"npm install jspdf"
then I included the script in the body of index.html file
like this
after that I am declaring a variable for jsPDF.
var doc = new jsPDF()
but when I declaring it gives me error that cannot find name jsPDF.
Does anyone know how to solve this error ?

I have the same problem.
Did you solved it @ShehramTahir ?

okay!! got this solution => https://stackoverflow.com/questions/41484323/how-to-use-jspdf-with-angular-2/#answer-41499623

Is that solution working for you ?

Look at this solution => https://github.com/MarouaneSH/Ionic-jsPdf-Html2Canvas


docs(plugins): added docs on frontend development for plugins

In the short term this documentation looks good.  Medium term, I'd like to work towards a pre-scaffolded plugin repo that developers can clone.  I'd also like most of the opinions (such as rollup config and provided libraries) to be encapsulated in the @spinnaker/plugin dependency so those opinions can be updated over time.

Thanks for the update @bpowell. lgtm from a writing standpoint.

There is now scaffolding available via this command npx -p @spinnaker/pluginsdk scaffold


option.filter doesn't work.

filter option doesn't work.  My project is completely stagnant because I can't solve it.

I tried to pass a fake one directly to see if it blocks all files, but nothing works, everything passes

install from github master ... https://github.com/node-formidable/formidable/issues/718


WA-234 - Add owners to a safe

Description
This PR allows to add more owners and also increase the threshold if necessary. It also includes the first step of the refactor needed for being more compliant with the future backend service. Now we check every 1.5 seconds if some attributes of the safe which are in Ethereum node have changed.

Travis automatic deployment:
https://staging-38-pr-161-safe-react-gnosis.surge.sh
Storybook book automatic deployment:
https://storybook-staging-38-pr-161-safe-react-gnosis.surge.sh

Travis automatic deployment:
https://staging-38-pr-293-safe-react-gnosis.surge.sh
Storybook book automatic deployment:
https://storybook-staging-38-pr-293-safe-react-gnosis.surge.sh


Improve test code coverage

Using gcov(1) revealed a couple of code paths not covered by the
tests. Some of the uncovered behavior can't be verified using the
current test framework but a potential crash can still be detected.

Thanks for testing and improving this @mptre. Great work! I think this looks ready to merge.

Thanks, merged. See my comment above regarding comment support.


Allow Error to conform to itself

5.0 version of https://github.com/apple/swift/pull/20629.  Includes the patches from #20658 and #20662.
ABI-additive: the stdlib exports some extra symbols.  Not specifically important for convergence, but eventually necessary in order to implement SE-0235 in Swift 5.0.

@swift-ci Please test.


Uninstall/Disable of Copilot disables/uninstalls YAML extension

Describe the bug
When uninstalling/disabling copilot the YAML extension will also be deleted, which causes issue for other VSCode extensions.
Steps to reproduce
Steps to reproduce the behavior:

Have the Dynatrace Extensions Copilot + ms-kubernetes-tools.vscode-kubernetes-tools installed
Go to 'VSCode > Extensions'
Search for 'Dynatrace Extensions' and select it
Click on 'Disable'
See error
Cannot disable 'YAML' extension alone. 'Kubernetes' extension depends on this. Do you want to disable all these extensions?

Expected behavior
Disabling should disable only Copilot not the YAML extension, since it is used in many places.
Same applies for deletion.

Hi @PatrikSteuer - thanks for raising this issue.
Until we find a proper solution, are you able to test this workaround:

Follow steps 1-4 and choose "Disable All"
Enable only the Kubernetes extension

Hi @radu-stefan-dt,
I removed the extension already by removing the entry within
.vscode/extensions/extensions.json
and by removing
.vscode/extensions/dynatraceplatformextensions.dt-ext-copilot-1.2.3-darwin-x64
So I am unable to validate the workaround.


Improvement/reflux

In the pull request I have rewritten the FeatureStore in to following the flux pattern with the reflux library.
So far I have rewritten featureToggles and archivedFeatureToggles. The main benefits are:

Less logic in the view-components.

If we move in this direction there is more work to be done:

A separate store for the error-handling (aka ErrorStore).
ErrorHandling inside the store when polling data.
StrategyStore must be converted to reflux.
EventStore. Here we could also potentially start thinking about pagination and such.

I hope people can look over the code and we can discuss whether we should move in this direction.
(This pull request relates to issue #91. )

Maybe @torarnek also can take a look.

Nice work!

I haven't used Reflux, but one thing that surprised me here is that server interaction is happening in FeatureStore. AFAIK, in a "traditional" Flux arhictecture a store would subscribe to events to update its state, not call out to the server itself. Server interaction would be handled in actions. Or perhaps I've misunderstood something?

I have looked at FeatureToggleStore and its usage, and I think it looks superb! :)
@jarib You are right that the initial Flux architecture had interaction with server/api external to stores, however, with most variations of Flux, like Reflux, this is simplified, by just doing the server-interaction in the Stores.  It is of course possible to do it outside the stores, however, that would require an extra layer of actions, which might be unnecessary with these simple stores.

I could move all server-interactions/ajax-stuff inside the actions.
I'm not sure how large the extra layer of actions would be, but I believe this would require us to have actions like "CreateFeatureToggleFailedAction" etc... Is this correct @torarnek ?
Will this make the design simpler? Would it be easier to understand?

I was basically following this example: https://www.npmjs.com/package/reflux#asynchronous-actions-as-promises

This is an interesting design question. Comparing doing the server-call in actions.js vs in store.js:
3 actions vs 1
Logic in two places(actions.js and store.js) vs logic in one place(store.js)
Are there any special benefits from doing the server-call in actions.js? Retry, undo etc? Anything that can justify 3x number of actions?

You make a valid point @torarnek. I think we should make the implementation as simple as possible for now. There is nothing stopping us moving in that direction later if we see any real benefits.

This has been discussed at length here: https://github.com/spoike/refluxjs/pull/140
I've had success keeping the server stuff in the actions, and triggering new actions (complete/error) when the result comes in. I find it makes for a nice flow of data and events, but at the cost of having more actions (ie. searchLoad, searchLoadComplete, searchLoadError). The store would listen to the *Complete actions, and an error store would listen to *Error actions.
Reflux has sugar for creating these "children" actions: https://github.com/spoike/refluxjs#asynchronous-actions

Thanks for your feedback @msolli. I think this is how we should implemented, mainly because it will keep the stores simpler.

Coverage decreased (-0.18%) to 90.0% when pulling 860a998623f7e12ff252d7d6031c29aee44e59ae on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.

Coverage decreased (-0.18%) to 90.0% when pulling acf74457901f8702ab32a46e4e13bf3572d60e5e on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.

Coverage decreased (-0.18%) to 90.0% when pulling ebb1b3b0b708c886cafe49552325f213a7488855 on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.

Coverage decreased (-0.18%) to 90.0% when pulling 97afc144d4cf3c93c82d3381636c3d31d9324ef9 on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.

Based on your great feedback I have implemented the stores for strategies, feature-toggles. archived-toggles and errors.
Before merging this I will pull the initial-fetch and Timers out of the store into a separate module.

Coverage decreased (-0.18%) to 90.0% when pulling 45871ebb408ecda4bb78929c0c6b9f794feca59c on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.

Coverage decreased (-0.18%) to 90.0% when pulling 9054bf9964fb9a14dd8ac413e49a9f206036300f on improvement/reflux into 94f78797dfbc19b32105476d4a6a2845fcb7ae3d on master.


Read input variables from gEQDSK file

Input_file_handling.py is modified to include a feature that allows cfspopcon to load several input variables from any geqdsk file. A streamlined version of omfit_classes/OMFITeqdsk.py is added to cfspopcon/OMFIT, from which Input_file_handling.py imports the OMFITgeqdskclass. Most of the development is done by @ThomasWangAPAM and @aarooshgr under the supervision of @nelsonand .

Suggest to use https://github.com/freegs-plasma/FreeQDSK instead

@ThomasWangAPAM please take a look at the read_case function:
https://github.com/cfs-energy/cfspopcon/blob/656c65e73ea035f45be788191b66c0fcbe7bcf76/cfspopcon/input_file_handling.py#L15-L17
This already allows for loading a case from a file and overriding certain parameters. Which is essentially what the eqdsk option would do.
I'd suggest keeping the reading quantities from an eqdsk separate from cfspopcon.
And one can use the read_case functionality to overwrite values if one want to run from an eqdsk.


Lore gets cut off

Minecraft version
1.19.3
Plugin version
3.9.0
Describe the bug

To Reproduce
Add an item with lore
Expected behavior
Keeps the lore
Would also be nice if we could have more customization like adjusting the format, where it displays the item lore first, and have everything after, as well as changing around the GUI. Also possible to add player heads support from minecraftheads? Thanks!

I'm checking on this issue.

In the case of format, it is possible to edit even now.
example)

result)

I watched for a long time to see which part of the lore was being cut. lol
I guess it's because I'm not an English-speaking person.

This problem has now been fixed.


chore: init repo

exposes the native endianness or byte ordering of the system
Issue: https://github.com/linuxdeepin/developer-center/issues/5731
Log: init repo

/approve


 Hope you can review this.
You will need to do a composer install.

Hi @nilportugues. Any comments/suggestions on this?

@franbenz I've been all weekend out. Will check when I get home


Remove broker related code, test, and build files

The broker is not under active development at this time. Most of the
code is configuration related which will need to be rewritten from
scratch when we switch over to Galley/MCP. Furthermore, the CRD tests
are adding unnecessary load on the k8s api-server and causing test
flakes in some scenarios.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7c60ba88a5012cf17b418329bfcb4ac6e046174d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7c60ba88a5012cf17b418329bfcb4ac6e046174d
link
/test istio-presubmit

prow/istio-unit-tests.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-unit-tests

prow/istio-presubmit.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
83399671ea8aec7c0b26a078c1ae821369167cb7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid broker seems like an interesting idea.  I get it is being removed for 1.0 as we don't have capacity to finish it up (or really even start it).  Will the broker make a return to Istio, and if so, what will be its general purpose?
tx
-steve

@ayj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj - missed removing the line item in the README about a broker being part of the source as well. Don't know if you want to take that out.

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram, zachgersh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, geeknoid, ldemailly, rshriram, zachgersh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,ldemailly,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj would be nice to pull this into release-1.0 as well?


feature: allow unstructured context in app logger

Reason for This PR

when the multidimensional context  is sent to app_logger using RPC only root elements are exposed on the root level
nested elements are logged as escaped JSON strings
all root elements are cast to strings

Description of Changes

extend config app->allow_unstructured_context (bool)
when allow_unstructured_context is enabled context is sent to app_logger as an array
non-string values are allowed
in case the string is not JSON it will be considered a string
new feature is disabled by default

Contributors

@pfy-oleksii-storozhylov
@cv65kr

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

Summary by CodeRabbit

New Features

Added configuration options to control context handling (AllowUnstructuredContext and ContextJSONUnwrap).
Enhanced logging functionality with new configuration settings.

Tests

Added tests to validate new configuration settings and logging functionality.

Documentation

Introduced a new configuration file (rr-appl-allow-unstructured-context.yaml) with detailed server settings.

Hey @pfy-oleksii-storozhylov 👋
Thank you for the PR 👍 I left a few minor notes on it.
The major note is the name of the plugin. It was app because never exposed. But if you wanted to expose config, we might use app-logger.

@rustatian thanks for the review! I will handle the comments.
regarding the name - I didn't rename the plugin because it is breaking change, do you want to rename only the config section?

There is no configuration previously introduced for this plugin. So, we're free to choose any name :)

Inside the plugin, we can still use package app, but the name can be different and does not depend on the plugin's package name. All these things are resolved automatically by the roadrunner-server/endure project.

I'm also thinking about the following: allow this behavior by default without any configuration options. We just need to check, if the incoming string is JSON. It would be a runtime penalty for such a check for every string in the logs... But logs are not a super critical place and using a *json.RawMessage to check, we should not lose a lot... @pfy-oleksii-storozhylov  WDYT?
This is because I am really don't want to introduce a configuration for that plugin. Because logs: and app-logger would be confusing. Like, why use logs and why app-logger? Without the configuration, it looks like a single logs plugin, but with RPC interface. We unfortunately can't merge them into real one plugin, since it would not be possible to topologically sort them (circular deps).

@rustatian this would be a breaking change, and it doesn't look good, some projects could rely on existing behaviour (escaped JSON)

@pfy-oleksii-storozhylov I need to think about that then. Honestly, I don't want to introduce a configuration for that plugin and separate it (logically) from the main logger and confuse users with that.

@rustatian I don't mind dropping the configuration, but as I said it is a breaking change and it will require RR major version update
Probably we can ask some advice from other maintaners?

during the testing from time to time, I see the following error in RR
goroutine 115 gp=0xc000b3ce00 m=nil [IO wait]:
runtime.gopark(0x0?, 0xba0000c000967c00?, 0x0?, 0x0?, 0xb?)
	runtime/proc.go:402 +0xce fp=0xc0008c08b0 sp=0xc0008c0890 pc=0x440e2e
runtime.netpollblock(0x48f0f8?, 0x408946?, 0x0?)
	runtime/netpoll.go:573 +0xf7 fp=0xc0008c08e8 sp=0xc0008c08b0 pc=0x439af7
internal/poll.runtime_pollWait(0x7f1bb741c438, 0x72)
	runtime/netpoll.go:345 +0x85 fp=0xc0008c0908 sp=0xc0008c08e8 pc=0x472ec5
internal/poll.(*pollDesc).wait(0xc000caf000?, 0xc0007381c4?, 0x0)
	internal/poll/fd_poll_runtime.go:84 +0x27 fp=0xc0008c0930 sp=0xc0008c0908 pc=0x4b7367
internal/poll.(*pollDesc).waitRead(...)
	internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc000caf000, {0xc0007381c4, 0xc, 0xc})
	internal/poll/fd_unix.go:164 +0x27a fp=0xc0008c09c8 sp=0xc0008c0930 pc=0x4b865a
net.(*netFD).Read(0xc000caf000, {0xc0007381c4?, 0xc0000e1ca8?, 0x1cdee80?})
	net/fd_posix.go:55 +0x25 fp=0xc0008c0a10 sp=0xc0008c09c8 pc=0x5dd6e5
net.(*conn).Read(0xc0007364c8, {0xc0007381c4?, 0x25314b0?, 0xc0001be4b0?})
	net/net.go:179 +0x45 fp=0xc0008c0a58 sp=0xc0008c0a10 pc=0x5f0725
net.(*TCPConn).Read(0xc0000e1b94?, {0xc0007381c4?, 0xc0008c0b20?, 0x411cfb?})
	<autogenerated>:1 +0x25 fp=0xc0008c0a88 sp=0xc0008c0a58 pc=0x603205
io.ReadAtLeast({0x2522020, 0xc0007364c8}, {0xc0007381c4, 0xc, 0xc}, 0xc)
	io/io.go:335 +0x90 fp=0xc0008c0ad0 sp=0xc0008c0a88 pc=0x4b1930
io.ReadFull(...)
	io/io.go:354
github.com/roadrunner-server/goridge/v3/internal.ReceiveFrame({0x2522020, 0xc0007364c8}, 0xc000cb06c0)
	github.com/roadrunner-server/goridge/v3@v3.8.2/internal/receive.go:21 +0x4e fp=0xc0008c0c90 sp=0xc0008c0ad0 pc=0x85fe4e
github.com/roadrunner-server/goridge/v3/pkg/socket.(*Relay).Receive(0xc000cc67b8?, 0xc000cb06c0?)
	github.com/roadrunner-server/goridge/v3@v3.8.2/pkg/socket/socket.go:37 +0x75 fp=0xc0008c0cc0 sp=0xc0008c0c90 pc=0x860e35
github.com/roadrunner-server/goridge/v3/pkg/rpc.(*Codec).ReadRequestHeader(0xc000cc6750, 0xc0000b1ea0)
	github.com/roadrunner-server/goridge/v3@v3.8.2/pkg/rpc/codec.go:249 +0x52 fp=0xc0008c0d10 sp=0xc0008c0cc0 pc=0x899f72
net/rpc.(*Server).readRequestHeader(0xc000664fc0, {0x253c088, 0xc000cc6750})
	net/rpc/server.go:587 +0x58 fp=0xc0008c0dd8 sp=0xc0008c0d10 pc=0x7e1038
net/rpc.(*Server).readRequest(0xc000be1770?, {0x253c088, 0xc000cc6750})
	net/rpc/server.go:547 +0x2f fp=0xc0008c0eb0 sp=0xc0008c0dd8 pc=0x7e0bcf
net/rpc.(*Server).ServeCodec(0xc000664fc0, {0x253c088, 0xc000cc6750})
	net/rpc/server.go:462 +0x71 fp=0xc0008c0fb8 sp=0xc0008c0eb0 pc=0x7e0111
github.com/roadrunner-server/rpc/v4.(*Plugin).Serve.func1.gowrap1()
	github.com/roadrunner-server/rpc/v4@v4.0.0-20240606121651-c86faad9f6f4/plugin.go:155 +0x28 fp=0xc0008c0fe0 sp=0xc0008c0fb8 pc=0x8db488
runtime.goexit({})
	runtime/asm_amd64.s:1695 +0x1 fp=0xc0008c0fe8 sp=0xc0008c0fe0 pc=0x478ae1
created by github.com/roadrunner-server/rpc/v4.(*Plugin).Serve.func1 in goroutine 50
	github.com/roadrunner-server/rpc/v4@v4.0.0-20240606121651-c86faad9f6f4/plugin.go:155 +0x21e

Could it be related to the plugin changes or it is something that is related to RPC on the higher level?
I didn't use RPC for logs before, co it could be a reason

I don't mind dropping the configuration, but as I said it is a breaking change and it will require RR major version update

I mean, definitely, no breaking changes should be introduced in the minor versions. But, no configuration should be added as well.

Probably we can ask some advice from other maintaners?

You may ask users on our Discord server in the #RoadRunner channel. But currently I would rather postpone this change.

during the testing from time to time, I see the following error in RR

Hm, looks like after you added configuration to this plugin, it became topologically the same as RPC (both have 2 deps, Logger and Configurer). However, I wrote a weighted graph, so RPC has weight 100 and should be initialized first. Strange error...

during the testing from time to time, I see the following error in RR

it seems it is related to termination process

I mean, definitely, no breaking changes should be introduced in the minor versions. But, no configuration should be added as well.

@rustatian According to semver, extending is allowed in the minor version, since the configuration is optional - it is not a BC

I mean, definitely, no breaking changes should be introduced in the minor versions. But, no configuration should be added as well.

@rustatian According to semver, extending is allowed in the minor version, since the configuration is optional - it is not a BC

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

Yeah, I mention about that earlier. What I'm trying to say, I'm not sure, that we should introduce config for this plugin not only in the future versions, but in general. Because it attached to the general logger plugin under the hood and I wanted to find a solution without configuration at all.

@rustatian
A few propositions to consider

add configuration to the main logger section and parse it directly from there
add some instruction (flag) directly to the context and make decision based on this flag. Example

Let me think about that 😃
But, what was your use case? Is that required for your application or at work?

@rustatian This is a company project, the use-case is collecting logs to Kibana (or other systems) in a JSON format with different structures (nested arrays) and types (eg. sting, number, bool)

Why not to use the Log method? It just writes any string (json-string) into stderr without any formatting from the RR side.

Why not to use the Log method? It just writes any string (json-string) into stderr without any formatting from the RR side.

we are using following configuration for logs in RR

logs:
output: stderr
encoding: json
level: info
mode: production

any raw string will become a "msg" and will be escaped

Let me clarify, app-logger has the Log RPC method, which doesn't use Zap or any internal logger. It just writes any string to the process stderr. So, your message would be printed without any decoration from the RR side.

@rustatian it seems it works like expected, let me doublecheck it

Amazing! This is exactly what I did search for!
@rustatian thank you a lot!
I'm closing the PR, since the log method provides full control on output.

Glad to hear 👍
Keep in mind,that if you need to send key-value pairs, also without any decoration, you may use LogWithContext method.


PowerShell constrained language mode

Seems Some shortcuts are trying to install modules from PSGallery which is NOT allowed to install when we enabled PowerShell constrained language mode for regular domain accounts.

Hmm MadhuSunke is this a big issue and what do you prefer instead? I can be very time consuming to add all of the modules offline in the package, but I can certainly do that if required.


temporal-sql-tool for MySQL doesn't create databases for v0.0.1

Expected Behavior
I was following the helm chart repo to create the Databases and schema for MySQL-Aurora v8 backend.
The command to create the database when a database name is supplied doesn't work. i.e.
./temporal-sql-tool create-database -database temporal_visibility

But, if I just run the below command, it creates a database named temporal.
Actual Behavior
Here is the out put of the command,
/temporal$ ./temporal-sql-tool create-database --database temporal_visibility
Incorrect Usage: flag provided but not defined: -database

NAME:
   temporal-sql-tool create-database - creates a database

USAGE:
   temporal-sql-tool create-database [command options] [arguments...]

OPTIONS:
   --defaultdb value  optional default db to connect to, this is not the db to be created

However, if I create the database by myself and then run remaining commands with the tool to create schemas, then it works.
Steps to Reproduce the Problem

Build the temporal-sql-tool using the instructions provided.
Create MySQL database instance.
Attempt to create the temporal and temporal_visibility
When trying it out, it will produce the error show in actual behavior section.

Specifications

Version: temporal version 1.20.3
Platform: Ubuntu with AWS Aurora-MySQL

Thank you for reporting this issue. The temporal-sql-tool does not currently support specifying a database name with the create-database command. You can create the database yourself and then use the tool to create the schemas, as you have done.
We've added this as a feature request to our backlog, and will consider it for future versions.

Thanks for reporting this issue!
The temporal-sql-tool does not yet support specifying the database name during the create-database command. You can create the database manually and then run the remaining commands to create schemas.
We are working on supporting this feature.
In the meantime, you can use the following workaround:

Create the database manually.
Run the temporal-sql-tool commands to create schemas.

Thanks for reporting this issue.
The -database flag is not a valid flag in temporal-sql-tool. To create a database named temporal_visibility using temporal-sql-tool, run the following command:
./temporal-sql-tool create-database --database temporal_visibility

You can check the temporal-sql-tool documentation for more information on the temporal-sql-tool commands.


⚠ Samsung has degraded performance

In de0b409, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3031 ms

Resolved: Samsung performance has improved in f6f0bbb.


Add a diagram of the component lifecycle

This is about:

[x] Undocumented code

Problem

Add a diagram of the component lifecycle under 'Lifecycle' in the docs.
This issue was originally started in the yewstack/docs - Original issue. I'm just moving it over here as that repo is now archived (as proposed in #1421).
For convenience I'll just echo the original proposal below:
Render Cycle1

create()
view()
yew renders to page
mounted()

Note: should explain how children components are rendered.. (Parent view -> Child view -> Child mount -> Parent mount)
Update Cycle1

trigger event / callback / send message
update()
(optional) view()
yew renders to page

Change Cycle1

render component with new props
change()2
(optional) view()
yew renders to page

1 - Note made in original issue: "'Change  cycle' and 'update cycle' should be altered slightly because they're not 'cycles' as such."
2 - In the original issue this is 'update()' which was a typo, change() is the correct method.
As noted in the original issue the diagram should be in SVG (rather than a PNG etc) as it would offer better resolution.

Here is my try:

I had to pull out the Event loop bits into a different diagram because it was bit too busy for nomnoml to make a clear diagram.
I could draw out a full diagram with the Event loop bit expanded if that's preferable but thought I'd check if all of the above is correct and covers all the requirements.
Still learning about Yew so I'm sure it will need some, or maybe a lot of, tweaking :D
Not sure if it's just worth stating that Children will always be resolved first instead of the way I've tried to show that in the diagram.
Note: Images are PNG because Github doesn't accept SVG here, but the final image for the website would be SVG


allow empty fragments in AnyUrl

On my understanding of the spec, empty fragments are valid:
https://datatracker.ietf.org/doc/html/rfc3986#section-3.5

Change Summary
Allows empty fragments in AnyUrl.
Related issue number
n/a
Checklist

[x] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Sorry to close this @jeremyschlatter I reviewed https://github.com/samuelcolvin/pydantic/pull/2888 before :/
It's now a duplicate.
Thank you for your contribution though 🙏


Add AutoTS Multivariate Operator

This PR adds following to the ADS forecast operator

added the AutoTS multivariate operator,
added the report and model output functions,
added/updated the AutoTS package requirement

Attached Model Outputs (report HTML as pdf as HTML is not supported on GH):

metrics.csv
forecast.csv
autots_report_html.pdf

Internal JIRA id : AutoTS Forecasting Model

Awesome job, thank you!
I was able to run this locally for a different target dataset.


Clangd error

nvim --version: NVIM v0.5.0-dev+1045-g24b60322a
Build type: RelWithDebInfo
LuaJIT 2.0.5
What language server (If the problem is related to a specific language server): clangd
Can you reproduce this behavior on other language server clients (vscode, languageclient-neovim, coc.nvim, etc.): no
Can you reproduce this behavior on other language servers offered in the nvim-lspconfig repo? (pyls -> pyright): not tested
Is the problem isolated to a particular language server: I think so
Operating system/version: archlinux

How to reproduce the problem from neovim startup
Use the default config, so just add
lua << EOF
require'lspconfig'.clangd.setup{}
EOF

in your init.vim
Actual behaviour
I don't even have the autocompletion, here is what the logs show:
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.805] clangd version 11.0.0\nI[18:09:20.805] PID: 24167\nI[18:09:20.805] Working directory: <working dir>\nI[18:09:20.805] argv[0]: clangd\nI[18:09:20.805] argv[1]: --background-index\nI[18:09:20.805] Starting LSP over stdin/stdout\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.805] <-- initialize(1)\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.806] --> reply:initialize(1) 0 ms\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.806] <-- initialized\nI[18:09:20.806] <-- textDocument/didOpen\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.806] Loaded compilation database from /<the directory>\nI[18:09:20.806] --> window/workDoneProgress/create(0)\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.807] Enqueueing 13 commands for indexing\nI[18:09:20.807] ASTWorker building file <the cpp file> version 0 with command \n[<the directory>]\n/usr/bin/c++ --driver-mode=g++ <flags> -c <the cpp file> -fsyntax-only -resource-dir=/usr/lib/clang/11.0.0\nI[18:09:20.807] <-- reply(0)\nI[18:09:20.807] --> $/progress\nI[18:09:20.807] --> $/progress\n"
[ ERROR ] 2021-01-23T18:09:20+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:20.892] --> $/progress\nI[18:09:20.892] --> $/progress\n"
[ ERROR ] 2021-01-23T18:09:21+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:21.118] --> textDocument/publishDiagnostics\n"
[ ERROR ] 2021-01-23T18:09:25+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:25.454] <-- textDocument/didChange\n"
[ ERROR ] 2021-01-23T18:09:25+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:25.454] <-- textDocument/didChange\n"
[ ERROR ] 2021-01-23T18:09:25+0100 ] /usr/share/nvim/runtime/lua/vim/lsp/rpc.lua:455 ]	"rpc"	"clangd"	"stderr"	"I[18:09:25.504] ASTWorker building file <the cpp file> version 4 with command \n[<the directory>]\n/usr/bin/c++ --driver-mode=g++ -pipe -resource-dir=/usr/lib/clang/11.0.0\n"

The logs just then continue as the last one "ASTWorker building file...."
Expected behaviour
That it works. Ever command seems to result in stderr.
Minimal init.vim or init.lua and code sample

Health check
Checkhealth result
health#lspconfig#check
========================================================================
## Checking language server protocol configuration
  - INFO: clangd: configuration checked.
  - INFO: cmake: configuration checked.

Thank you very much in advance for any help.
P.S: Just so you know I come from coc.nvim where I didn't have any problems, so I don't think it comes from my workspace  build/configuration.

You can ignore stderr, it's just logging all of the messages to stderr (it's not implying there is an error). What exactly is the issue?

You can ignore stderr, it's just logging all of the messages to stderr (it's not implying there is an error). What exactly is the issue?

Thank you very much for your quick answer.

When you say you don't have autocompletion, did you install completion.nvim and set it up?

No, and if it's the problem, why isn't it mentioned in the docs ?
Thank you very much in advance.

Thank you very much for your quick answer.

When you say you don't have autocompletion, did you install completion.nvim and set it up?

No, and if it's the problem, why isn't it mentioned in the docs ?
Thank you very much in advance.

We never said we support auto-completion, so I don't see why we would put this in the readme. We support completion via overriding omnifunc which is in the docs. You need to rely on an external plugin. Completion.nvim has the tightest support, but mu-complete and deooplete also have options which use the lsp results.

We never said we support auto-completion, so I don't see why we would put this in the readme. We support completion via overriding omnifunc which is in the docs. You need to rely on an external plugin. Completion.nvim has the tightest support, but mu-complete and deooplete also have options which use the lsp results.

Thank you very much for your time and help :+1:

Thank you very much for your time and help :+1:

Of course :) Sorry for the confusion, hopefully the wiki entry is enough, but if this comes up maybe I'll add something explicit to the docs. I try not to mention external plugins since this is a "core" feature (and core doesn't have autocomplete yet), but I realize that autocomplete is almost an expectation with language servers. That being said, completion.nvim is probably what the implementation would be if it was in core :)

Of course :) Sorry for the confusion, hopefully the wiki entry is enough, but if this comes up maybe I'll add something explicit to the docs. I try not to mention external plugins since this is a "core" feature (and core doesn't have autocomplete yet), but I realize that autocomplete is almost an expectation with language servers. That being said, completion.nvim is probably what the implementation would be if it was in core :)


tcl/tk: 8.6.4 -> 8.6.6

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The error is no space left on device

@vcunat, does this need to go into staging? Otherwise I'd just merge.

It doesn't seem a mass rebuild to me.

Oh, I didn't notice our default python depends on it.

It does not; the expression confused me. I should finally start using nox for this or something.


Add command completion

command line completion for Octo command
For now just the basic commands.
This could be made smarter to also autocomplete issue number after Octo issue edit etc

Thanks!!

Thanks!!


feat: add tictactoe example by hackyguru

@weboko @danisharora099 Can you check? I am not sure if I missed anything necessary to get this in and deployed!

@vpavlin currently there is a problem with hosting Next.js apps - still didn't figure solution

@vpavlin currently there is a problem with hosting Next.js apps - still didn't figure solution

Can you elaborate the problem (in an issue if necessary)?


convert docstring examples to unittests

Inspired by #4039 I propose to go through all old modules and replace the examples in docstring with checked unittests.
The advantage is quite clear - it is possible to verify that the documentation is correct and up-to-date.
A quick regex yielded that there a 55 files affected:
107 ./datetime.d
45 ./xml.d
40 ./net/curl.d
25 ./experimental/logger/core.d
16 ./stdio.d
11 ./file.d
10 ./socket.d
10 ./parallelism.d
9 ./exception.d
7 ./regex/package.d
7 ./range/package.d
7 ./process.d
6 ./net/isemail.d
6 ./base64.d
5 ./uni.d
5 ./random.d
5 ./functional.d
5 ./concurrency.d
4 ./windows/registry.d
4 ./traits.d
4 ./conv.d
3 ./typecons.d
3 ./path.d
3 ./internal/scopebuffer.d
3 ./experimental/allocator/typed.d
3 ./encoding.d
3 ./digest/ripemd.d
3 ./digest/digest.d
2 ./zip.d
2 ./format.d
2 ./experimental/ndslice/slice.d
2 ./experimental/logger/filelogger.d
2 ./experimental/allocator/building_blocks/stats_collector.d
2 ./digest/md.d
2 ./bitmanip.d
2 ./algorithm/setops.d
1 ./windows/syserror.d
1 ./uuid.d
1 ./string.d
1 ./socketstream.d
1 ./signals.d
1 ./math.d
1 ./internal/cstring.d
1 ./experimental/ndslice/package.d
1 ./experimental/logger/multilogger.d
1 ./experimental/allocator/building_blocks/segregator.d
1 ./digest/sha.d
1 ./demangle.d
1 ./csv.d
1 ./container/slist.d
1 ./container/rbtree.d
1 ./array.d
1 ./algorithm/sorting.d
1 ./algorithm/searching.d
1 ./algorithm/package.d

I used this command - in case you want to reproduce it:
for f in $(find . -name '*.d'); do echo $(grep "Example:" $f | wc -l) "$f"; done | grep -v "^0" | sort -nr

Questions
I would be happy to start with this task and go through the modules - maybe I can even automate it.
So there are only two questions

If there is a global module example (like in this PR for uuid), currently the best thing is to add the unittest below the class and add the magic \\\. However this means that the example will be added to the class and not the module. How about using \\\\ for module unittest examples?
Compare http://dlang.org/phobos/std_uuid.html and the generated documentation for this PR.

How "okay" are you with this proposal?
It's a bit of work and it would feel like wasted time if this ends up non-merged.

I would split the PR in multiple parts, so that it's easier to review ;-)
PS/off-topic: Is anyone taking bets how many docstring examples don't work anymore?

Hi @greenify!

Thank you for doing this!
Thanks to @quickfur 's good work, now we can put ddoc-ed unittests at module level (before all members) and they will appear in the documentation. I suggest you try this for this PR, so we can verify this on the documentation autotester.
Have a great day!

now we can put ddoc-ed unittests at module level (before all members) and they will appear in the documentation. I suggest you try this for this PR, so we can verify this on the documentation autotester.

It does work on local machine & the autotester - that's exactly what I was looking for :)
I would say that it makes sense to put it between module and the import statements?

Thank you for doing this!

I would go ahead once I get the okay from an official member - pinging randomly @andralex, @JackStouffer,  @schveiguy, @burner

I would say that it makes sense to put it between module and the import statements?

Personally, I think that it would be a bit cleaner to put the unittest block after the imports, but I'm not sure that it matters much.
As for turning ddoc examples into ddoc-ed unittest blocks. You really don't need permission for that. It's slowly been being done over time. It's just that it's most frequently happening either a PR happens to touch some code that didn't use a ddoc-ed unittest block. Just keep in mind that there are examples that won't work as ddoc-ed unit tests. std.net.curl is a great example of this because of the network stuff that it's doing, and a bunch of the examples in std.datetime shouldn't be converted either, because the functions in question are member functions on templated types, and it's problematic to put unittest blocks inside of templates. Also, in some rare cases, the documentation purposefully has an example in the middle of it, in which case, turning the example into a ddoc-ed unittest block would mess up the documentation. So, don't just automatically convert an example to a ddoc-ed unit test without thinking about it. I expect that that majority of examples that aren't ddoc-ed unittest blocks should be. So, there should be plenty for you to do on that front, but not every example should be converted.
So, feel free to create some PRs which turn examples into ddoc-ed unittest blocks where appropriate, but please make sure that the PRs are of a manageable size - e.g. there's no need to try and fix every example in one PR. If you do it in smaller chunks, it'll be easier to review and verify the changes.

So, feel free to create some PRs which turn examples into ddoc-ed unittest blocks where appropriate, but please make sure that the PRs are of a manageable size

Understood - I regard this PR as completed now.
It turns four examples into unittests, the questionable case is signals.d, but here I hope observedMessageCounter makes it still obvious what is going on.
As a side remark: I moved also the unittests for SList #4039, DList #4040 and RBTree #4041 to the top ;-)

If you do it in smaller chunks, it'll be easier to review and verify the changes

As a further incentive, PRs that affect less files are less likely to encounter merge conflicts.

I even found a case where the docstring isn't displayed: experimental/allocator/building_blocks/stats_collector.d
See:
http://dlang.org/phobos/std_experimental_allocator_building_blocks_stats_collector.html
https://github.com/D-Programming-Language/phobos/blob/master/std/experimental/allocator/building_blocks/stats_collector.d#L195

LGTM

Auto-merge toggled on


Suggestion

Can you give a better explanation about the "Suggestion" activity type and under what circumstances it might be used?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53617abe-a774-a211-390b-b2f0261c5bb6
Version Independent ID: f1533f6c-f340-f838-d95b-ca5b6cd4b6dd
Content: Entities and activity types - Bot Service
Content Source: articles/bot-service-activities-entities.md
Service: bot-service
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

Take a look at the section about this in the Activity Schema. (If it's not already there, I'll add a cross reference to the schema in the Entities and activity types article.

@MCKRUZ Please reopen if this did not answer your question.


How to specify base profiles?

I'm using fhirToFsh(fhir[, options]) to convert a JSON resource to an FSH string...
It's returning an error: Cannot reliably export top-level caret rules for XXX because GoFSH cannot find a definition for its parent: https://YYYY.
I looked through the options for a way to provide the base/parent profile definition, but there doesn't seem to be a way. The only way I can see is to specify a dependency to an IG... But, in this case, the profile I'm converting to FSH is part of the same IG as the base/parent profile, and the IG isn't published.
Is it possible to provide fhirToFsh() the definition of the parent profile to avoid this error? If not, can I request that a change be made to support this?
Perhaps, for example:
const options = {
  dependencies<EMAIL_ADDRESS>  relatedProfiles: [ profile2, profile ],
};
const fsh = fhirToFsh(profile1, options);

The fhirToFsh function takes an array of FHIR resources.  So you could just include the related profiles in the main array you pass in.  If you don't want their FSH, then use the map style so you can easily select the FSH for just the things you want (or remove the FSH you don't want from the resulting maps). The only caveat is that if any of the related profiles have errors converting to FSH, then those will get reported too (even though they might not be the main profiles of interest for you).
I think your suggestion is worth considering, but in the mean time, would the approach described above meet your needs?
E.g.
const options = {
  dependencies<EMAIL_ADDRESS>  style: 'map',
};
const fshMaps = fhirToFsh([profile1, profile2, profile], options);


Patch extraDraftedPerceivedPathCost and extraNonDraftedPerceivedPathCost

In vanilla, these seem to be used only to make pawns ignore pathing through water if possible. Amphibious pawns will need to ignore these two values, otherwise they will prefer to always path over land.
See this for an example implementation: https://github.com/joseasoler/terrain-pathfinding-kit/blob/main/Source/Patches/PathFinder_CurrentGrid_Util.cs

Clean Pathfinding 2 uses these values.


Spine Support

is there gonna be a spine 2d support ?

Hi, @Deorigami, the engine is still in the early development phase, I'm currently focusing on some more basic features (like physics or camera), but anything is possible :)


BaleenCollectionReader.getContentExtractor() results in ClassNotFoundException

Using the following config which I borrowed from the baleen-runner tests:
sample_pipeline.yaml:
collectionreader:
  class: FolderReader
  folders:
    - /tmp/data

annotators:
  - class: regex.Email
  - class: regex.Url

consumers:
  - class: EntityCount

The application generates the following error in the output:
2018-03-19 21:32:32,138 DEBUG uk.gov.dstl.baleen.core.utils.BuilderUtils - Couldn't find class uk.gov.dstl.baleen.contentextractors.StructureContentExtractor in package uk.gov.dstl.baleen.contentextractors
java.lang.ClassNotFoundException: uk.gov.dstl.baleen.contentextractors.uk.gov.dstl.baleen.contentextractors.StructureContentExtractor

Notice, the CNFE has the package spec repeated twice: uk.gov.dstl.baleen.contentextractors.uk.gov.dstl.baleen.contentextractors.StructureContentExtractor
I believe the bug is caused by passing a fully qualified classname AND defaultPackage="uk.gov.dstl.baleen.contentextractors" to BuilderUtils.getClassFromString() here:
https://github.com/dstl/baleen/blob/master/baleen-uima/src/main/java/uk/gov/dstl/baleen/uima/BaleenCollectionReader.java#L178
Another possible fix would be to modify BuilderUtils.getClassFromString() and test if the className parameter contains the defaultPackage:
https://github.com/dstl/baleen/blob/master/baleen-core/src/main/java/uk/gov/dstl/baleen/core/utils/BuilderUtils.java#L64
Lastly, another fix would be to modify BaleenDefaults.DEFAULT_CONTENT_EXTRACTOR so that it does not contain the FQ classname, here:
https://github.com/dstl/baleen/blob/master/baleen-core/src/main/java/uk/gov/dstl/baleen/core/utils/BaleenDefaults.java#L34

Thank you for the detailed error report.
I have had a look at this this morning and cannot replicate your issue.
Please could you let me know how you are passing the pipeline to Baleen? I have tried submitting an identical (other than folder location) pipeline via a baleen config file at startup and also configured by hand using the plankton interface.
Am I right in assuming (given your previous issue) that you are running from a version built from the latest 2.5.0-SNAPSHOT code?
Sorry to not be more helpful...

John, thanks for your quick reply.  The error appears very early in the console logs, and the application continues to bootstrap and run with no further errors.  Here's my configuration:
$ ls -l /tmp/baleen
-rw-r--r--  1 ahalsup  wheel  212079116 Mar 20 10:34 baleen-2.5.0-SNAPSHOT.jar
drwxr-xr-x  3 ahalsup  wheel         96 Mar 20 10:35 data
-rw-r--r--  1 ahalsup  wheel        138 Mar 20 10:38 runner.yaml
-rw-r--r--  1 ahalsup  wheel        192 Mar 20 10:38 sample_pipeline.yaml

$ ls -l /tmp/baleen/data
-rw-r--r--  1 ahalsup  wheel  95 Mar 20 10:34 data.txt

$ cat /tmp/baleen/data/data.txt
This is an example email<EMAIL_ADDRESS>which would correspond with a URL http://example.com

Here's the command to run, and a snippet of the console output:
$ java -jar ./baleen-2.5.0-SNAPSHOT.jar runner.yaml
10:48:10.019 [main] INFO uk.gov.dstl.baleen.runner.Baleen - Baleen starting
10:48:10.021 [main] INFO uk.gov.dstl.baleen.runner.Baleen - Baleen about to run
...
2018-03-20 10:48:10,550 DEBUG uk.gov.dstl.baleen.collectionreaders.FolderReader[sample] - Starting function initialize
2018-03-20 10:48:10,553 DEBUG uk.gov.dstl.baleen.core.metrics.LoggingMetricListener - Created timer 'sample:uk.gov.dstl.baleen.collectionreaders.FolderReader:initialize'
2018-03-20 10:48:10,555 DEBUG uk.gov.dstl.baleen.core.utils.BuilderUtils - Couldn't find class uk.gov.dstl.baleen.contentextractors.StructureContentExtractor in package uk.gov.dstl.baleen.contentextractors
java.lang.ClassNotFoundException: uk.gov.dstl.baleen.contentextractors.uk.gov.dstl.baleen.contentextractors.StructureContentExtractor
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at uk.gov.dstl.baleen.core.utils.BuilderUtils.getClassFromString(BuilderUtils.java:67)
	at uk.gov.dstl.baleen.uima.BaleenCollectionReader.getContentExtractor(BaleenCollectionReader.java:178)
	at uk.gov.dstl.baleen.collectionreaders.FolderReader.doInitialize(FolderReader.java:146)
	at uk.gov.dstl.baleen.uima.BaleenCollectionReader.initialize(BaleenCollectionReader.java:64)
...
2018-03-20 10:48:10,557 DEBUG uk.gov.dstl.baleen.contentextractors.StructureContentExtractor[sample] - Starting function initialize
2018-03-20 10:48:10,557 DEBUG uk.gov.dstl.baleen.core.metrics.LoggingMetricListener - Created timer 'sample:uk.gov.dstl.baleen.contentextractors.StructureContentExtractor:initialize'
...
2018-03-20 10:48:11,401 INFO  org.eclipse.jetty.server.Server - Started @1548ms
2018-03-20 10:48:11,401 DEBUG org.eclipse.jetty.util.component.AbstractLifeCycle - STARTED @1548ms org.eclipse.jetty.server.Server@7eecb5b8
2018-03-20 10:48:11,401 INFO  uk.gov.dstl.baleen.core.web.BaleenWebApi - Server started
2018-03-20 10:48:11,401 INFO  uk.gov.dstl.baleen.core.manager.BaleenManager - Initialisation complete

After stopping the application ctrl+c, I see that the entityCount.tsv file has been created:
$ cat entityCount.tsv
/private/tmp/baleen/data/data.txt	2
/private/tmp/baleen/data/data.txt	2

Thank you for the extra information... now that I have set my logging minlevel to the same as yours I am seeing the same result.
It does look like Baleen is working, despite the error, as the entityCount.tsv file is the default output for the EntityCount consumer that you are using. The output you have suggests you have run baleen twice on your single file and so the file with its two entities have been added to the output file twice.
If you set the minlevel to INFO in runner.yaml, you will suppress a lot of the output and you should also see the results of the print.Entities consumer that you are also running.
2018-03-20 15:20:49,919 INFO  uk.gov.dstl.baleen.consumers.print.Entities[sample] - uk.gov.dstl.baleen.types.semantic.Entity:
        Value<EMAIL_ADDRESS>        Type: uk.gov.dstl.baleen.types.common.CommsIdentifier
        Span: 25 -> 42

2018-03-20 15:20:49,920 INFO  uk.gov.dstl.baleen.consumers.print.Entities[sample] - uk.gov.dstl.baleen.types.semantic.Entity:
        Value: http://example.com
        Type: uk.gov.dstl.baleen.types.common.Url
        Span: 77 -> 95

This should hopefully demonstrates that Baleen is working, despite the errors, and so hopefully you can continue with your use. I will leave this open, as clearly something is not right nonetheless.

@JohnDaws - you rock!  Thanks for looking into this for me.

So I believe this is actually expected behaviour and not a problem (although perhaps a little inefficient). The method used to find the class first checks for the class name in the default package, and then if it can't be found there checks the name on it's own. Doing it in this order prevents someone creating a class with no package with the same name as an existing class and it being picked up by mistake.
In the BaleenDefaults class, the default ContentExtractor is fully specified for clarity. But that means when a component attempts to gets the default content extractor it first checks by prepending the default package name before trying the already-qualified (correct) name. It logs the exception for debugging purposes, but it's only there for information and is nothing to worry about.
So perhaps a little inefficient, but not an issue and can be safely ignored. I'd recommend closing this issue.

👍 Agreed.

Thanks James for providing a detailed answer, I will close the thread.
Andrewm, for info, my goto consumer for testing purposes is the Html5 consumer.
This will write all each input document to an html file wrap a  around each entity with some metadata. It's a bit easier to keep track of than print.entities once you have more than a few results.
pipeline
...
consumers:
  - class: EntityCount
  - class: print.Entities
  - class: Html5
    outputFolder: .\html_out
    css: .\email_url.css

Without a css file, the Html output will just look like plain text in a browser, but if you add the css file below to your html output folder then the entities within the text should appear 20% larger and colour coded by type. Obviously you can add the other types and be a bit more adventurous with the styling if you wish.
email_url.css
span.Url {color:red;}
span.CommsIdentifier {color:blue;}
span.baleen {font-size:120%;}


[Bug] We are unable to create docker-compose.yml file for an SQLite database

What is the problem?
We are unable to create docker-compose.yml file for an SQLite database
2024/04/15 12:47:18 Could not go tidy in new project exit status 1
Error: exit status 1

Operating System
Ubuntu
Architecture Version (x86, x64, arm, etc)
x64
Steps to reproduce

Relevant log output
-

What is the problem?
We are unable to create docker-compose.yml file for an SQLite database
2024/04/15 12:47:18 Could not go tidy in new project exit status 1
Error: exit status 1

Operating System
Ubuntu
Architecture Version (x86, x64, arm, etc)
x64
Steps to reproduce
Relevant log output
-

2024/04/15 12:47:18 Could not go tidy in new project exit status 1
It's module issue - docs here

@adit1o what were the options you selected when creating a new project?

Hi, dunno why, but after i upgrade apt upgrade everything looks fine.
so i'm close this issue

I'm getting this same error. Here are my options:
go-blueprint create --name welcome --framework chi --driver sqlite --advanced --feature htmx --feature tailwind
I'm on an M3 Mac running the latest Go 1.22.4. Happy to provide more details if needed!


[MNT] Move repo to sktime org

To do's
before next release we need to do:

[ ] Bulk replace all "alan-turing-institute/sktime" in main repo
[ ] Bulk replace all "alan-turing-institute/sktime" in all other repos
[ ] Change read-the-docs
[ ] Move to sktime org
[ ] Share new repo via social media

ref changes here: https://github.com/alan-turing-institute/sktime/pull/2926
I also think we should make two releases in short succession - so one release increases MINOR and the only change is the change of refs


[Explore]: FYI https://github.com/google/kf exists

Background
It is licensed under the Apache License 2.0.
Acceptance Criteria
Looking at that code probably can greatly and often help development here.
Timebox
No timebox
Dev Notes
Sorry if this is noise. I couldn't join the slack and felt that it is too important to risk going unmentioned.

Hi @hab25, thanks for stopping by!
We have looked at kf in the past, but the design is quite different from Korifi. Korifi aims to provide a CF compatible API so that the existing CF CLI and other clients can continue to work with it, whereas kf provides a replacement CLI that interacts directly with the Kubernetes cluster. For example, here you can see how it reimplements the cf push command to interact directly with the cluster. As you can imagine, this makes the implementation quite different between kf and korifi.
We also had a CF on K8s working group sync where someone from the kf team stopped by and chatted about it with us. It's recorded here if you're curious and want to watch:
https://www.youtube.com/watch?v=t_LjfBAT7y4
That said, are there specific features of kf that you are interested in that you think Korifi should support? We're always looking for user feedback about what to develop next!
 Or did you just prefer not to. If it's the former and you had some problem with the invite flow on https://slack.cloudfoundry.org/ we would like to help you figure that out.

Cool, glad that worked! We're all in the #korifi-dev channel on CF Slack if you want to have a higher fidelity conversation on any of this.


fix: Unstick heading from anchor

Minor, but some syntax highlighters don't recognize the headings stuck to an anchor. It seems like GitHub was OK with it because of the trailing space after the anchor before

Hi @nschonni,
Thanks for taking time to provide your feedback. Appreciate your effort.
I have incorporated your feedback in the topic. You will see the changes in a couple of days.
Hence, closing the PR.
Expecting lot more feedback that can enhance the customer experience.
Thanks and regards,
Karthik

The changes are live.


Add support for TTS

Add support for the Tiny Test System library from https://jfalcou.github.io/tts/

Furthermore, your toolchain files inside /cmake might be an issue.

Oh ? Why ?
SHould I move them elsewhere or ?

Furthermore, your toolchain files inside /cmake might be an issue.

Oh ? Why ?
SHould I move them elsewhere or ?
Because usually it is not required to set CMAKE_CXX_COMPILER yourself. Users of your library might want to select different compilers.
You already fixed this by not adding the toolchain directory to CMAKE_MODULE_PATH on the master branch. By looking at your latest master branch, I would recomend you use this instead of your latest version tag.

Furthermore, your toolchain files inside /cmake might be an issue.

Oh ? Why ? SHould I move them elsewhere or ?
Because usually it is not required to set CMAKE_CXX_COMPILER yourself. Users of your library might want to select different compilers. You already fixed this by not adding the toolchain directory to CMAKE_MODULE_PATH on the master branch. By looking at your latest master branch, I would recomend you use this instead of your latest version tag.

Well, I don't get it.
Those toolchain files are used for our CI infrastructure. So I don't see how they can interact with w/e an user of the library can do. Especially has it's a header only library.
Now, indeed the version is a bit old. OK, let's close this PR and lemme put up a better version for this integration.
Sorry for th enoise and thanks for the heads up.


Style: Remove inconsistently used @author docstrings

Each file in Godot has had multiple contributors who co-authored it over the
years, and the information of who was the original person to create that file
is not very relevant, especially when used so inconsistently.
git blame is a much better way to know who initially authored or later
modified a given chunk of code, and most IDEs now have good integration to
show this information.
Only a few contributors were using @author comments (probably via an IDE template when creating new files?), please confirm that you're OK with the removal (which is only for consistency's sake and not to remove credit from your contributions, which is centralized for all main contributors in https://github.com/godotengine/godot/blob/master/AUTHORS.md). You can :+1: if you're OK with the change :)

Multiple files: @reduz @BastiaanOlij @AndreaCatania
Single file: @27thLiz @bfloch @cagdasc @djrm @dsnopek @MarianoGnu @marstaik @SaracenOne

I am okay with this, actually there should have been more files that I stamped the @owner tag on, but probably forgot.
I would like to note that I am not actually on the list at https://github.com/godotengine/godot/blob/master/AUTHORS.md , so maybe go through the list and make sure everyone is on that list?
I think it's respectful for everyone to have appropriate credit given regardless of how big/small it is.

I am okay with this, actually there should have been more files that I stamped the @owner tag on, but probably forgot. I would like to note that I am not actually on the list at https://github.com/godotengine/godot/blob/master/AUTHORS.md , so maybe go through the list and make sure everyone is on that list?
I think it's respectful for everyone to have appropriate credit given regardless of how big/small it is.

For the AUTHORS.md list we chose to put a threshold of 10 commits before including people, so that it represents people who have done significant work on the engine (which makes the current list total 200 contributors, as opposed to the 1823 total contributors count if we go down to single-commit contributors). It's completely arbitrary and it can indeed lead to some significant contributors who have made only a handful of big commits being missing from the list. That seems to be your case with 9 commits, I'll add you in my next sync.

Can probably check the number of additions and deletions too, and add contributors if any one of the three metrics goes over a certain threshold?

I have to say that I really loved having my name in there. :-) But I absolutely understand the reasons for removing these, and it's fine.


Add warning for users before/when using Wallet

We would like to add warnings for the following situation:

Make sure users acknowledge they are visiting https://x.forbole.com

Users have to confirm they are using recovery phrase to connect chains when they do so

@kwunyeung Please note

@Rooty2020 @nicoletting Please help on the UI

@rachelhox

Please add your planning poker estimate with ZenHub @rachelhox


Got Bleu_4: 41.9 and CIDEr: 143.9 rather than 42.4 and 144.5 using Salesforce/blip2-flan-t5-xl-coco

Hi, @LiJunnan1992, thanks for your work.
I am trying to replicate the results in Table 3.
I loaded blip2-flan-t5-xl-coco and called the generate function using the following hyper-parameters, the random seed is 42.
But I got Bleu_4: 41.9 and CIDEr: 143.9 on the coco test split.
Any idea? Thanks!
generated_ids = model.generate(**inputs,
                               do_sample=False,
                               max_length=30,
                               min_length=8,
                               num_beams=5,
                              )

Bleu_1: 0.826
Bleu_2: 0.682
Bleu_3: 0.541
Bleu_4: 0.419
METEOR: 0.317
ROUGE_L: 0.616
CIDEr: 1.439
SPICE: 0.257

@xszheng2020 I think they did not fully released the training/evaluation pipeline of blip-flan-t5 related architecture

@SangbumChoi  oh thanks

And btw, this file is empty https://github.com/salesforce/LAVIS/blob/main/lavis/projects/blip2/eval/caption_coco_flant5xl_eval.yaml

Why is this file empty?


Add Jetty web server (bots are using this server)

Jetty provides a web server and servlet container, additionally providing support for HTTP/2, WebSocket, OSGi, JMX, JNDI, JAAS and many other integrations. These components are open source and are freely available for commercial use and distribution.
Jetty is used in a wide variety of projects and products, both in development and production. Jetty has long been loved by developers due to its long history of being easily embedded in devices, tools, frameworks, application servers, and modern cloud services.
Link: https://www.eclipse.org/jetty/

Coverage remained the same at 100.0% when pulling b885aaf0b69f184f9b583d624948f5f940e7aa69 on ayumi-cloud:jetty into c65ad41ee66cc126a7740d929aab706dd7304c1c on WhichBrowser:master.


Unable to get command() to work

When I remap anything to command, nothing happens.
Here is an example of my default.conf:
[ids]

[main]
Remaps the escape key to capslock
esc = capslock
rightalt = toggle(calc)
[calc]
e = command("ls")
q = command(echo "here" &> ~/temp/err.txt)

The command will be run with /bin/sh, '&>' is a bashism. Try echo "Hello World" > /tmp/test.log 2>&1 instead. Having said that, you probably don't want to do this.  You probably don't really want to do this anyway, see #229 and #211.

Thanks for the reply.  Really loving your program.  Thanks for making it!!!
I tried that and it still did nothing.  Can't seem to get it to work with any command.  Tried with notify-send, rofi and various others, but nothing seems to run.
I am using Fedora.  When I check /bin/sh it is simlinked to bash.  Would that make any difference?

Thanks.
To clarify, are you suggesting:
[main]

tab = command(echo "Tab pressed" > /tmp/test)

doesn't create /tmp/test when tab is pressed?
If so, please run the following and post the output after trying to execute a command:
sudo systemctl stop keyd && sudo KEYD_DEBUG=1 keyd

It did not work.
I set up your:
[main]
command(echo "Tab pressed" > /tmp/test)
and I also had
[calc]
q = Command("rofi -show")
I ran your debug command and the rofi menu appeared.  I had to hit escape a few times to get rid of it.  I then hit a few keys, including the tab and then trying ralt followed by q.  Got the following (I am using linux on an old MacBook Pro):
``
> sudo systemctl stop keyd && sudo KEYD_DEBUG=1 keyd
DEBUG: src/keyd.c:555: Debug mode activated
MainStarting keyd v2.4.1 (bb49007-dirty)
socket: /var/run/keyd.socket
device added: 05ac:0274 Apple Inc. Apple Internal Keyboard / Trackpad (/dev/input/event8)
        matched /etc/keyd/default.conf
DEBUG: src/layer.c:81: created [main] from "main"
DEBUG: src/layer.c:81: created [control] from "control:C"
DEBUG: src/layer.c:81: created [meta] from "meta:M"
DEBUG: src/layer.c:81: created [shift] from "shift:S"
DEBUG: src/layer.c:81: created [altgr] from "altgr:G"
DEBUG: src/layer.c:81: created [alt] from "alt:A"
DEBUG: src/layer.c:81: created [calc] from "calc"
        ERROR parsing /etc/keyd/default.conf:7: invalid key or action
        ERROR parsing /etc/keyd/default.conf:42: invalid key or action
DEBUG: src/keyd.c:122: Ignoring Broadcom Corp. Bluetooth USB Host Controller (not a keyboard)
command errorcommand errorcommand errorcommand errorcommand errorcommand errorcommand errordevice added: 05ac:8290 Broadcom Corp. Bluetooth USB Host Controller (/dev/input/event6)
        matched /etc/keyd/default.conf
^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[^[
                DEBUG: src/keyboard.c:315: Activating layer calc
qqqDEBUG: src/keyboard.c:302: Deactivating layer calc
DEBUG: src/keyboard.c:315: Activating layer control
^CYo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!Yo!⏎

Please post the full output of default.conf. Your comment suggests that you did not use the config snippet I provided to you (and the logs seem to corroborate this, hence the parsing errors).
rofi is a bad test program since it relies on DISPLAY (as mentioned in the issues I linked to).
If your goal is to launch graphical programs from keyd I would strongly discourage for reasons I have already outlined in the referenced links. The reason it worked in this case is because keyd inherited your session variables, in general you cannot rely on this.

OK.  Thanks.  I will use my window manager instead.  I just thought it would be nice to include it as a layer.
Here is my config file and thanks again!
[ids]

[main]
tab = command(echo "Tab pressed" > /tmp/test)
One shot the control, meta etc
NB oneshot is a mode where you can tap the key and it will allow for
one click on that layer
shift = oneshot(shift)
meta = oneshot(meta)
control = oneshot(control)
leftalt = oneshot(alt)
#rightalt = oneshot(altgr)
Maps capslock to escape when pressed and control when held.
capslock = overload(control, esc)
Remaps the escape key to capslock
esc = capslock
rightalt = toggle(calc)
[calc]
n = 1
m = 2
, = 3
h = 4
j = 5
k = 6
y = 7
u = 8
i = 9
7 = +
8 = -
9 = *
0 = /
q = Command("rofi -show")

Please surround command output in backticks (```), otherwise github will render it as markdown. In your first post your wrote command(echo "Tab pressed" > /tmp/test), in your second you wrote tab = command(echo "Tab pressed" > /tmp/test). Which of these did you actually test?
According to the log output (parsing error on line 7), you tested the first one, which is probably why it didn't work. Does the issue still occur with the config you actually posted? If so, it is a bug, and I would appreciate your help in fixing it (even if you don't end up using the feature).

I'm assuming this was a configuration error. Feel free to reopen it if you can reproduce the problem using the config I posted.


More Cypress tests, from test plan January 20

The Cypress tests in this PR all succeed at this point, but not all tests that I planned for this issue are yet in. I will make this issue ready-for-review when done.

LGTM!


[RFC] Add config delegate to public api

This is a part of #3670.
I was going to mark ThresholdRule and LazyRegex as deprecated but then I did not know what to suggest to users on how to replace it unless making the config property part of the public api. I think the "nicest" way is to mark the functions whith @UnstableApi but then almost all native rules would have to opt in which also seems weird.
Please let me know your opinion on how to move forward with this.

Sorry, I should have been more specific. The questions are less about the actual implementation but rather about the general way forward.

Should the @Configuration and the config delegates become part of the public api?
Should the new parts of the api be marked with @UnstableApi?
Do we agree that the ThresholdRule and LazyRegeg should be marked as deprecated and will be removed with detekt 2.0?

Should the config property delegates become part of the public api?

I'm not sure here. Do we really want to publish those property delegates? We would then need to keep them stable as part of the API. I really don't see the benefit for end users.

Should the config property delegates become part of the public api?
Should the @Configuration become part of the public api?

I'm not sure here. Do we really want to publish those property delegates and annotations? We would then need to keep them stable as part of the API.

Should the new parts of the api be marked with @UnstableApi?

+1

Do we agree that the ThresholdRule and LazyRegeg should be marked as deprecated and will be removed with detekt 2.0?

+1

My answers would be as follows:

Should the config property delegates become part of the public API? - Yes
Should the @Configuration become part of the public API? - Yes
Should the new parts of the api be marked with @UnstableApi? - Probably no, since we have migrated all detekt rules to @Configuration.
Do we agree that the ThresholdRule and LazyRegex should be marked as deprecated and will be removed with detekt 2.0? - Yes

I am less sure about ActiveByDefault, @Configuration and @RequiresTypeResolution as they are only used to generate the config file and documentation. I do not see any benefit right now to expose those.

@schalkms since you have reviewed this PR, would you mind taking another look again?

@chao2zhang fine for me. Merging this PR helps to close the linked issue as well, since all TODOs are now done.👍

Excuse me please, I overlooked the latest changes in this PR whilst checking my GitHub notifications.

@marschwar Would you be able to write some documentation on this API (both the configuration delegate and all the new annotations) so I can add it to the release notes for 1.18.0?


Capturing a screen screenshot of a virtual desktop in Windows 10

Whether it is possible to directly capture a screenshot of a Windows 10 virtual desktop via a handle

If you mean from an app running in the remote machine you will need https://github.com/lovettchris/wincam, dxcam does not work in a remote desktop for some reason.
If you mean the host machine capturing the contents of the remote desktop window, here's a screenshot showing that working using the wincam/examples/mirror.py script passing the process id of the remote desktop app (mstsc.exe): python mirror.py --process 32216


New Event: Change Character Display Name

I think it could be cool to be able to change a characters display name during a timeline. Maybe this could somehow be added to the Set Value event? Not sure. Alternatively this could of course be a custom event, but I think it would make a fine builtin one.

Is this something we want to do from an event? or should it be reserved to having character names being {custom_variable} and using the Text Input event or Set Variable event to rename that?
I like the idea of being able to modify characters from an event but it feels like it will open a can of worms. It will be really difficult to track the status of all those changes.


Fix for cat with start before start of data

Because output should be equivalent: cat_file(f, start, end) == cat_file(f)[start:end]

@juliospain , did libarchive change, perhaps in the release 13 days ago?
>       open_cb = libarchive.read.OPEN_CALLBACK(ffi.VOID_CB)
E       AttributeError: module 'libarchive.ffi' has no attribute 'VOID_CB'


WIP: Jenkins using different workspace in parallel mode

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.002%) to 42.028% when pulling dfc88e1a71e74f02870c460f68f2f138787fbec8 on eloycoto:JenkinsDifferentWS into 4e333a290d1fbc9b45096ca75c9e6adf36335768 on cilium:master.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please


Issue 247: JBoss integration: use a custom configuration file, fix formatter usage and provide a new fat jar with all dependencies

Hi @dje06,
There are few conflicts on this PR. Will you please resolve those conflicts, so that we can review your change.
Thanks.


ENSCORESW-3518 Changes to make VGNCParser generic for all VGNC species

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
Review the contributing guidelines for this repository; remember in particular:

do not modify code without testing for regression
provide simple unit tests to test the changes
if you change the schema you must patch the test databases as well, see Updating the schema
the PR must not fail unit testing

Description
To enable better handling of running xref for vgnc species for every release.
Use case
To better manage inclusion of new VGNC species in the xref pipeline
Benefits
We dont have to maintain a separate list of species in the ini file.
Possible Drawbacks
NA
Testing
Testing done for single parser runs for 5 VGNC species. Compared with number of xrefs from 101 runs.Number of xrefs added were > 101 runs.
If so, do the tests pass/fail?
NA

Coverage increased (+0.0004%) to 82.33% when pulling 8a3a7466d1fb7de505933bbbb6ffac7205599658 on fix/VGNCParser_n into a5551f68ceb46be624b779a6af8de35630d888e5 on master.

Xref count match for 101 run and the run with the fix. Updated in ticket.


Changed the Registration link text #638

Just a small text change

Coverage remained the same at 55.641% when pulling 2c7b18ac791d98fffdfe148c93e573192d500607 on v2_UI into 5e76fe1f41ae622180c717d6ac461f5e49240193 on dev-v2.


Possibly new information about PRUDPLite/Switch packets?

After reading up on PRUDPLite I attempted to look at my own traffic for research purposes. However none of the packets found in WireShark match that of the structure described here.
None of the packets in my dump have a 0x80 header, however many (if not all) seem to use 32 AB 98 64 as a header. This is true between both MK8D and Splatoon2. Could Nintendo have possibly changed the format? Or is this something different? There's no WebSocket data in the WireShark dumps and it doesn't appear to be going over TCP either. On a whim I also checked PRUDP V0 and V1 (not expecting anything), and unsurprisingly those also did not work.
MK8D WireShark dump 1: https://drive.google.com/open?id=1GLyehZHR7lHMqW61YT4lOZSqyj7Pixzp
MK8D WireShark dump 2 (full dump of race): https://drive.google.com/open?id=1B32NYEWweKr9ZQsmucwljo0VOMt6vjKm
Splatoon2 WireShark dump: https://drive.google.com/open?id=15yJRtBUCxfJDZ7f9WRfLl_hXaaqi5ArJ

UDP packets starting with 32 AB 98 64 are part of the peer-to-peer protocol (from the PIA library). These packets are sent directly from one console to another, without server in between. The PRUDP protocol is only used in communication with the game server.
Your WireShark dumps do actually contain WebSocket/PRUDP packets. Look for packets with g2b309e01-lp1.s.n.srv.nintendo.net as source or destination. You can't actually view the content of these packets though, because the connection is encrypted with TLSv1.2.
You won't see much game server packets during a match by the way. The game server is only responsible for match making and setting up the peer-to-peer connection. There's no server involved in the race itself.

@Kinnay Thank you so much for giving me some insight on this issue!


Consider Adopting dbt-superset-lineage

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3335
Originally created by @pnadolny13 on 2022-03-11 21:28:02

https://github.com/slidoapp/dbt-superset-lineage
Features that would be cool:

pull existing dashboards and set as exposures in dbt project. This allows lineage to be tracked so we know what dashboards model changes will affect.
push dbt docs to Superset

View 1 previous comment from the original issue on GitLab


hw/drivers: Add display driver SSD1673

This code was ported from Zephyr

Thanks @kasjer and @andrzej-kaczmarek! Fixed.