fix: add browser condition to package.json

jest@28 will ship with exports support. But when using jest-environment-jsdom to simulate a browser environment, we don't provide the node condition, meaning it resolves to default. Unless ESM is enabled, this results in a syntax error.

Where I'm not entirely sure is cases, where webpack/rollup would pick the pkg.exports.browser.require path. I think those cases, the overrides in pkg.browser must be taken into account by the bundlers in order to generate a browser-compatible build.
Have you tested this case?

Nope, not tested. However, I don't think those fields are related? At least with main, it is 100% ignored if exports is present, I'd assume browser was the same. So older tools without exports support use browser newer ignores it. Might be wrong, tho 😀

I just ran a quick test: https://github.com/uuidjs/uuid/pull/617/commits/13ceb7949851023efb7ade89caa4928fd6be2f4e
When using require() webpack picks ./dist/index.js as an entry point and then applies the overrides from pkg.browser, i.e. it uses ./dist/rng-browser.js etc.
I have not verified with rollup yet. But at least for webpack, the pkg.browser field is not ignored, however after all it does the right thing.
I think this should be covered in the browser tests. I can't promise when I can find the time to do this though.

I have not verified with rollup yet. But at least for webpack, the pkg.browser field is not ignored, however after all it does the right thing.

Their docs are wrong, then? Seems weird 😅 But if it works like you want it to, all is well?

Ah, seems like browser is just "aliases", it has nothing directly to do with export conditions

Is it even valid to have a "browser" field nested w/in the "exports" block like this?  If so, where might we find some sort of description or spec for how it's interpreted?

https://nodejs.org/api/packages.html#nested-conditions

Ah, seems like browser is just "aliases", it has nothing directly to do with export conditions

Is it even valid to have a "browser" field nested w/in the "exports" block like this? If so, where might we find some sort of description or spec for how it's interpreted?

As @SimenB mentioned the pkg.browser field is different from the browser environment in pkg.exports. Indeed, pkg.browser was introduced by browserify a loooong time ago and we've been using it for ages here as well. However, pkg.exports also allows a browser environment which, according to https://webpack.js.org/guides/package-exports/#target-environment seems to be rather widely supported.
However what I don't really like about the current approach in this PR is that we're mixing to concepts: Through pkg.exports.browser.require we're telling bundlers to use the Node.js CommonJS build at ./dist/index.js and then we're relying on the independent, legacy concept of pkg.browser for the browser specific overrides over the Node.js CommonJS build.
I think a cleaner solution would be to provide a consistent CommonJS build for the browser, e.g. in ./dist/commonjs-browser/index.js. Folks have run into similar issues in the past (1, 2, 3, 4) when misconfiguring their bundlers… I would still argue that this is always an unintended misconfiguration and should not be done, folks should not choose the CommonJS builds of their dependencies for browser builds, they should use the ESM build that natively supports tree shaking instead.
However in this case now with jest-environment-jsdom where a browser env is only simulated within a Node.js process things may actually start looking differently. Thinking about this, however, uncovers an interesting aspect: I believe with this current patch and when using jest-environment-jsdom jest may actually end up executing the CommonJS Node.js code and not the browser code. In practice, this will probably produce the intended results for the test cases. However it's still possible that such test cases will pass with Jest but would fail in a browser since browsers will effectively execute different code.
I'm sorry for the long write up, I guess the main message is that this is complicated…
@SimenB do you have an example of where a syntax error is thrown (what you reference in the original PR description)? I would really like to figure out what happens under the hood when jest runs these tests.

A browser build in CJS would be even better of course 🙂

@SimenB do you have an example of where a syntax error is thrown (what you reference in the original PR description)? I would really like to figure out what happens under the hood when jest runs these tests.

Jest provides ['require', 'browser', 'default'] as conditions, meaning default is returned, which is ./dist/esm-browser/index.js.
https://github.com/SimenB/jest-uuid
Remove comment at top of test.js to see it pass (as Jest then runs in node env and provides node condition instead of browser)

@ctavan how do we unblock this? 🙂 This issue is actually stopping me from using the Jest alpha at work 😅 (although I guess I can just patch package.json, but still)

Sorry for the silence and sorry to hear this blocks you.
I'm happy to help unblock this but I have to admit that I'm not sure what the right way forward is. I experimented with building a browser commonjs build, but that only reveals the actual problem…
If you run jest on jsdom.test.js in https://github.com/uuidjs/uuid/tree/simenb-patch/examples/jest-uuid-main you get:
$ ./node_modules/.bin/jest jsdom.test.js
  console.log
    commonjs-browser RNG

      at Object.<anonymous> (../../dist/commonjs-browser/rng.js:3:9)

 FAIL  ./jsdom.test.js
  ● Test suite failed to run

    crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported

      20 |
      21 |     if (!getRandomValues) {
    > 22 |       throw new Error('crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported');
         |             ^
      23 |     }
      24 |   }
      25 |

      at rng (../../dist/commonjs-browser/rng.js:22:13)
      at Object.v4 (../../dist/commonjs-browser/v4.js:23:32)
      at Object.<anonymous> (jsdom.test.js:5:18)

So the browser commonjs build uses browser APIs (crypto), it has to do this, otherwise we can't sell that as a browser build. However those APIs don't seem to be provided/mocked by jsdom.
I'm currently failing to understand what the expectations are when you run a test case with @jest-environment jsdom? How close to a browser environment is this supposed to be?
If it's not reasonably close, I think that resolving the pkg.exports.browser target for @jest-environment jsdom tests will inevitably cause many problems like the one above, where the code that is offered on the pkg.exports.browser export relies on native browser APIs.
Can you help clarify the expectations?

So the browser commonjs build uses browser APIs (crypto), it has to do this, otherwise we can't sell that as a browser build. However those APIs don't seem to be provided/mocked by jsdom.

That seems perfectly fine to me? "If you want to use uuid in an "old" browser, you need to polyfill". I don't see the issue with that.

I'm currently failing to understand what the expectations are when you run a test case with @jest-environment jsdom? How close to a browser environment is this supposed to be?

As close as possible. If APIs are missing from the env, the module should complain. The fact I want to use CJS instead of ESM is separate from browser vs node. It's not up to this module to say "you cannot use require in the browse", it should just say "here's a browser entry point for CJS" and it's up to the consumer to ensure their environment works for what they're trying to load.

Jest 28 has now been released - which means that Jest and UUID are no longer compatible.
For anyone trying to fix this issue - @dbjorge did a good temp solution here: https://github.com/microsoft/accessibility-insights-web/pull/5421#issuecomment-1109168149
But would be great to have a proper solution to this.

Looping in @dbjorge here since I think this thread is more suitable to discuss the jest/uuid specific issue than https://github.com/uuidjs/uuid/pull/616#issuecomment-1043492062.
First of all, thanks for the great summary @dbjorge!
At the risk of repeating what @dbjorge already summarized perfectly well, I'd like to highlight again:
Jest + UUID just "accidentally" worked in the past because Jest used to pick the Node.js build even in environments like jsdom that were supposed to mimic the browser. Apparently this has worked well for folks in practice, so I think a custom jest resolver like this one is actually a great mitigation for the time being as it just puts us back to where we were before Jest 28.
If we were adding a CommonJS browser build for completeness of the support matrix of uuid, we would still need something like https://github.com/jsdom/jsdom/pull/3352 to make this work with Jest 28. And I stand with my statement that I generally think CommonJS for the browser has no production use case. Requiring a whole new build specifically for testing purposes which has otherwise no production use case to me sounds more like something that should be fixed in the testing library rather than in the libraries being tested… So to that end I'd prefer see ESM support land in Jest.
@SimenB two questions:

Can you foresee if/when Jest will get ESM support?
Assuming, 1. will materialize eventually, could Jest potentially ship fallback resolutions logic for widely spread libraries like uuid that would fall back to resolving the node build (essentially bundling the custom resolver that @dbjorge wrote?)?

I can see how this affects many people, given both jest and uuid are so widespread, I'm just still failing to clearly identify the right solution for this situation.

@ctavan Thanks for the ping!
https://github.com/facebook/jest/issues/9430 is the meta-issue tracking ESM support in Jest. It is a very long and very soul-crushing read. For the purposes of our discussion here, I think it's probably safe to say that it won't happen soon enough for the folks that need Jest+uuid workarounds to unblock Jest 28 updates.
I want to emphasize that, as a user of both libraries, I don't think anyone on the uuid or Jest sides are making unreasonable decisions here; I don't really feel convinced that a workaround really "belongs" in either library. Particularly:

I think it's reasonable for the uuid maintainers to push back on adding a CommonJS + browser export just for the sake of one testing framework
I think the new Jest behavior to try to use browser exports from jest-environment-jsdom is an excellent change overall
If I were a uuid maintainer, I would be very hesitant to touch its exports unnecessarily for fear of breaking backcompat with someone's weird webpack config
If I were a Jest maintainer, I would be very hesitant to establish a precedent of adding package-specific magic to Jest's default resolver

I think there are probably a large number of users that will be impacted by this, but more importantly than that, I want to recognize that neither Jest nor uuid have any obligation to be cross-compatible with one another. I am a thankful user of the work you have both made available for free, and neither project's maintainers owe me (and certainly not my employer) a damn thing; if I have to maintain a few lines of resolver.js to use them together, that's perfectly fine.

Thanks for chiming in @SimenB!

I don't think we'll be adding workarounds for any libraries directly in Jest. The easiest solution would probably be for somebody to create a jest-uuid that people can stick in the moduleNameMapper config. It could just do module.exports = require('uuid') and possibly be a cleaner solution than custom resolvers (as it composes better if people already use a custom resolver).

@dbjorge what do you think about this approach? Would this be something you'd consider to test-drive on accessibility-insights-web?

Or potentially having some well maintained custom resolver people can plug in that looks like the one @dbjorge has built, but supporting more modules than just uuid.

Or maybe rather this second approach?
Given I currently don't have my own use case for this, I don't think I'll be able to provide a solution (like the jest-uuid wrapper), but I'd be happy to contribute (e.g. I'd be open to host such a module in the uuidjs github & npm org).

For anyone coming here looking for a quick workaround, i did the following in my jest config (which i think is more or less @SimenB's suggestion with a  jest-uuid)
moduleNameMapper: {
  "^uuid$": "<rootDir>/node_modules/uuid/dist/index.js",
},

The easiest solution would probably be for somebody to create a jest-uuid that people can stick in the moduleNameMapper config. It could just do module.exports = require('uuid') and possibly be a cleaner solution than custom resolvers (as it composes better if people already use a custom resolver).

@dbjorge what do you think about this approach? Would this be something you'd consider to test-drive on accessibility-insights-web?

I actually tried basically this solution before I went with the custom resolver - I don't think a wrapper package is necessary, you can just do something like:
moduleNameMapper: {
  // This forces Jest/jest-environment-jsdom to use a Node+CommonJS version of uuid, not a Browser+ESM one
  // See https://github.com/uuidjs/uuid/pull/616
  '^uuid$': require.resolve('uuid'),
}

However, I rejected this in favor of the custom resolver because my understanding of the moduleNameMapper option is that it would essentially force every transitive dependency on uuid in my project to resolve to whichever version of uuid happens to be hoisted to the root node_modules folder. I'm already working in a project which has multiple versions of uuid in its dependency tree, but even if I wasn't, this scenario creates a maintenance time bomb if uuid ever releases a v9 with breaking changes. I preferred the custom resolver because it lets each dependency chain continue to use (the CommonJS version of) whatever uuid it was already using.

@dbjorge your analysis is correct though, this forces a single version across the entire tree

For anyone coming here looking for a quick workaround, i did the following in my jest config (which i think is more or less @SimenB's suggestion with a jest-uuid)
moduleNameMapper: {
  "^uuid$": "<rootDir>/node_modules/uuid/dist/index.js",
},

Thanks @dairyisscary :)
I duplicated by mistake this issue : https://github.com/facebook/jest/issues/12790
I added your suggestion and it works ! :muscle:
But, Do developer of Jest will fix it ? Or the uuid module is useless ?

@zak39 The answer is summarized here #616 (comment) - please make sure to skim the discussion first.
And also, let's be considerate and not calling the library useless.

Yeah, I'm sorry, I would not mean this library is "useless". Indeed, the word is stronger... I would mean this library could be replaced or something like this.
And thanks, I didn't see this comment. I skimed it ^^'

Sorry for the silence and sorry to hear this blocks you.
I'm happy to help unblock this but I have to admit that I'm not sure what the right way forward is. I experimented with building a browser commonjs build, but that only reveals the actual problem…
If you run jest on jsdom.test.js in https://github.com/uuidjs/uuid/tree/simenb-patch/examples/jest-uuid-main you get:
$ ./node_modules/.bin/jest jsdom.test.js
  console.log
    commonjs-browser RNG

      at Object.<anonymous> (../../dist/commonjs-browser/rng.js:3:9)

 FAIL  ./jsdom.test.js
  ● Test suite failed to run

    crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported

      20 |
      21 |     if (!getRandomValues) {
    > 22 |       throw new Error('crypto.getRandomValues() not supported. See https://github.com/uuidjs/uuid#getrandomvalues-not-supported');
         |             ^
      23 |     }
      24 |   }
      25 |

      at rng (../../dist/commonjs-browser/rng.js:22:13)
      at Object.v4 (../../dist/commonjs-browser/v4.js:23:32)
      at Object.<anonymous> (jsdom.test.js:5:18)

So the browser commonjs build uses browser APIs (crypto), it has to do this, otherwise we can't sell that as a browser build. However those APIs don't seem to be provided/mocked by jsdom.
I'm currently failing to understand what the expectations are when you run a test case with @jest-environment jsdom? How close to a browser environment is this supposed to be?

JSDOM v20 supports crypto.getRandomValues(), fwiw

JSDOM v20 supports crypto.getRandomValues(), fwiw

@SimenB I'm being lazy here (headed out the door to walk dog, get my day started), but does that mean things should "just work" now?  ... or that work is still needed w/in this module to resolve this issue?

I can confirm that this now works with<EMAIL_ADDRESS>(which has<EMAIL_ADDRESS>as a dependency).

I have released<EMAIL_ADDRESS>that contains this patch. Please try it out and let me know if it fixes the Jest interoperability (to be tested with jest@29.0.0-alpha.1).

I have released<EMAIL_ADDRESS>that contains this patch. Please try it out and let me know if it fixes the Jest interoperability (to be tested with jest@29.0.0-alpha.1).

I just gave it a try and it seems to fix the issue on my side. Looking forward for the stable release(s).
Thanks for your work 💪

@ctavan can confirm it allows us to remove the moduleMapper config at work as well 👍

FWIW, Jest 29 is released (which means jest-environment-jsdom@29 is out, which comes with jsdom@20)

@SimenB @ctavan, When can we expect the release?

I have no idea, Jest 29 has been out for a week

FWIW, Jest 29 is released (which means jest-environment-jsdom@29 is out, which comes with jsdom@20)

Thanks for the info. Awaiting UUID v9 now then :)


Exception in handleOnblur function in multiSelectPicklist in firefox

I'm getting an exception that srcElement is not defined when opening and closing multiSelectPicklist dropdown menu in firefox. In other browsers seems to work ok.

Event.srcElement is indeed non-standard. Event.target should likely be used instead in the controller function. You can probably try this small update directly in your copy of the component to confirm the fix.

Yes this fix works ok in Firefox, Safari and Chrome. Didn't tested in IE yet.

Ok this fixed the error, but I get next error on strike_lookup component not, when embedding whole component/app to VF page:
This page has an error. You might just need to refresh it. Action failed: c:strike_lookup$controller$handleFocusIndexChange [null is not an object (evaluating 'lookupMenu.getElementsByTagName')] Failing descriptor: {c:strike_lookup$controller$handleFocusIndexChange}
Sometimes error is visible directly after page is loaded, sometimes I have to click trough all lookups and picklists for error to show, but no error is thrown if I open everything directly in LEX.

If you are getting a different issue on a different component you should open a new issue.

we will implement this change in our next release

@daneowens3 can you already give a hint when the next release will be published?

@up2go-sschwarz right now it's hard to say. My best guess is that an official release may not surface for a few weeks. A majority of our dev and QA resources are swamped with client work, and the Winter release introduced new bugs that must be fixed as part of our next version so our to do list doubled in size.
The good news is we've already crafted fixes for a majority of the Winter bugs in our client work. Bringing them back to Strike will expedite things, assuming QA gives us the okay.


How to get the file content data on server side when using $upload.http

I can get the content if the file format is .txt or .csv by using:
Object.keys(req.body);
I saw req.body is like:
body: { 'This is a test file created by @yingdanh': '' }
But this way doesn't work for PDF format. Could someone please help?
Btw, another problem when I use $upload.http is that I can only use:
'Content-Type': 'application/x-www-form-urlencoded'
If I use Content-Type as 'application/pdf', I can't see the file data on the server side anymore.
Thank you,
Yingdan

Can you post your code here?

I use yeoman to generate angular full stack code.
Front-end filetrap.controller.js:
$upload.http({
url: '/api/filetrap/' + file.name,
headers: {
'Content-Type': 'application/x-www-form-urlencoded',
'X-Remote-Path': uploadPath
},
data: file
}).progress(function (evt) {
/*var progressPercentage = parseInt(100.0 * evt.loaded / evt.total);
console.log('progress: ' + progressPercentage + '% ' + evt.config.data.name);
        $timeout(function () {
          $scope.progressValue = progressPercentage;
        }, 200);*/
      }).success(function (data, status, headers, config) {
        //console.log('file ' + config.data.name + ' uploaded. Response: ' + data);
        $scope.onNodeToggle($scope.selectedNode);
      });

Front end calls the backend code:
var uploadFile = function (req, res) {
var filename = req.params.filename;
var sftpPath = req.headers['x-remote-path'];
var fileContent = Object.keys(req.body);
console.log(fileContent);
......
}
I only need upload one file at one time. My .txt file has one line: This is a test file created by @yingdanh.
I can see request body: { 'This is a test file created by @yihuang': '' }, then var fileContent = Object.keys(req.body) gives me that line.
.csv works fine, but pdf doesn't work - I saved the .txt file to .pdf.
Thanks a lot!
Yingdan

Why don't you use Upload.upload? What's the reason for using Upload.http?

If you are using $upload.http({}) set the content-type header to file.type instead of application/x-www-form-urlencoded


Unable to get Sanity visual editor working with nuxt site locally

Notes

I tried following the docs for this repo.
I also tried following Sanity's docs

Version
module: 1.13.2
nuxt: 3.14.1592
Nuxt configuration
export default defineNuxtConfig({
  compatibilityDate: '2024-11-01',
  devtools: { enabled: false },
  modules: ['@nuxtjs/sanity'],
  sanity: {
    projectId: 'v39h2x7o',
    dataset: 'production',
    apiVersion: '2021-03-25', // required
    visualEditing: {
      token: process.env.NUXT_SANITY_VISUAL_EDITING_TOKEN,
      studioUrl: 'http://localhost:3333',
    },
  },
});

Reproduction

Create a new sanity project
Checkout repo
https://github.com/cadamsdev/nuxt-sanity-visual-editor-example
Change the sanity project id in both cms and web folders
https://github.com/cadamsdev/nuxt-sanity-visual-editor-example/blob/main/apps/cms/sanity.cli.ts#L5
https://github.com/cadamsdev/nuxt-sanity-visual-editor-example/blob/main/apps/cms/sanity.config.ts#L11
https://github.com/cadamsdev/nuxt-sanity-visual-editor-example/blob/main/apps/web/nuxt.config.ts#L7
In sanity

Create a "viewer" api key
https://www.sanity.io/manage/personal/project/<project_id>/api#tokens
Add cors origin for "http://localhost:3000", check "Allow credentials"

Rename .env.example to .env
Add env var for NUXT_SANITY_VISUAL_EDITING_TOKEN from step 4
Run npm i && npm run dev
Go to http://localhost:3333
Create a movie (Just need the title for this to work)
Go to the presentation tab in sanity studio http://localhost:3333/presentation you should get the error mentioned below.

Link:
https://github.com/cadamsdev/nuxt-sanity-visual-editor-example
What is expected?
I should be able to use Sanity visual editor with nuxt.
What is actually happening?
I am getting error while trying to view my nuxt site using sanity studio in the presentation tab.
500
"undefined" is not valid JSON

at JSON.parse ()
at setupFetcher (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@nuxtjs/sanity/dist/runtime/composables/visual-editing.js?v=ccddcf37:125:14)
at useSanityQuery (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@nuxtjs/sanity/dist/runtime/composables/visual-editing.js?v=ccddcf37:155:7)
at http://localhost:3000/_nuxt/app.js:18:98
at withAsyncContext (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?v=ccddcf37:3396:19)
at setup (http://localhost:3000/_nuxt/app.js:18:74)
at callWithErrorHandling (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?v=ccddcf37:197:19)
at setupStatefulComponent (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?v=ccddcf37:7923:25)
at setupComponent (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?v=ccddcf37:7884:36)
at mountComponent (http://localhost:3000/_nuxt/@fs/home/crazypanda/workspaces/nuxt-sanity-visual-editor-example/node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?v=ccddcf37:5240:7)

Additional information
Checklist

[x]  I have tested with the latest Nuxt version and the issue still occurs
[x]  I have tested with the latest module version and the issue still occurs
[x]  I have searched the issue tracker and this issue hasn't been reported yet

Screenshot

I experience also a json error after upgrading from 1.13.1 to 1.13.2:
500

JSON.parse: unexpected character at line 1 column 1 of the JSON data`

I downgraded @nuxtjs/sanity from 1.13.2 to 1.13.1 and that did fix the issue. So yeah as @silvio-e mentioned looks like there was a regression.

Ok found the issue.
It's a regression from this change.
It's not checking if params is undefined before trying stringify it and parse it.
Changing
      const fetcher = sanity.queryStore!.createFetcherStore<T, E>(
        query,
        JSON.parse(JSON.stringify(params)),
        undefined,
      )

to
      const fetcher = sanity.queryStore!.createFetcherStore<T, E>(
        query,
        params ? JSON.parse(JSON.stringify(params)) : undefined,
        undefined,
      )

fixes it.
Note: params can be undefined e.g
const { data: movies, encodeDataAttribute } = await useSanityQuery<QueryResult[]>(query)

To workaround the issue you can pass an empty object
const { data: movies, encodeDataAttribute } = await useSanityQuery<QueryResult[]>(query, {})


ceph-dashboard: fix TLS cert openssl generation

With OpenSSL version prior 1.1.1 (like CentOS 7 with 1.0.2k), the -addext
doesn't exist.
As a solution, this uses the default openssl.cnf configuration file as a
template and add the subjectAltName in the v3_ca section. This temp openssl
configuration file is removed after the TLS certificate creation.
This patch also move the run_once statement at the block level.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1978869
Signed-off-by: Dimitri Savineau<EMAIL_ADDRESS>

jenkins test centos-non_container-collocation

jenkins test centos-container-collocation

jenkins test centos-non_container-collocation

jenkins test centos-non_container-collocation

unrelated CI failure


Support for Internal Load balancer

Is there an existing issue for this?

[X] I have searched the existing issues

Description
To add support for Load balancer Private IP option instead of pubic IP, It is required for cases where Azure Front Door or Application gateway connect to load balancer private IP using the Private Service link.
New or Affected Resource(s)/Data Source(s)
azurerm_kubernetes_cluster
Potential Terraform Configuration
dynamic "load_balancer_profile" {
  for_each = var.load_balancer_profile_enabled && var.load_balancer_sku == "standard" ? ["load_balancer_profile"] : []

  content {
    name                = var.load_balancer_name
    private             = var.load_balancer_private_mode
    sku                 = var.load_balancer_sku
    subnet_id           = var.private_subnet_id
    frontend_ip_address {
      name                  = "frontend-ip"
      private_ip_address    = var.frontend_private_ip_address
      private_ip_allocation = "Static"
      subnet_id             = var.private_subnet_id
    }
  }
}

References
No response

If I understand correctly your proposed change will create a private IP address to be used of OutBound traffic, not for inbound. The inbound IPs are created dinamically when Kubernetes Services are created.
For Azure Front Door to connect to load balancer private IP using the Private Service link, you can do this with Azure Private Link Service Intergration:
https://cloud-provider-azure.sigs.k8s.io/topics/pls-integration/
Here is a full example with Terraform:
https://github.com/zioproto/istio-aks-example/tree/main/istio-on-aks-with-front-door
The Kubernetes Service that creates the LoadBalancer with the private IP and is connected to private link:
https://github.com/zioproto/istio-aks-example/blob/a558670d26182d5dd005eeebee873a8a024908e8/istio-on-aks-with-front-door/istio-tf/istio.tf#L68-L79
Here the FrontDoor origin.
https://github.com/zioproto/istio-aks-example/blob/a558670d26182d5dd005eeebee873a8a024908e8/istio-on-aks-with-front-door/istio-tf/afd.tf#L49-L68
Please let me know if this solves your problem. I am not sure the change you are proposing is actually necessary.


Run npm audit

@shaunanoordin, I ran npm audit fix. Running locally, it all seems fine and tests pass. If all looks good to you, then this can merge and deploy.

PR Overview
This PR is a basic security update. App compiles fine on localhost and a brief run through the app shows that functionality is fine - LGTM 👍 I'll get this merged and deployed shortly.
Note: there is still 1 warning from running npm audit, but that's the same minor babel-cli > braces warning that @wgranger and me encountered yesterday with Scribes of the Cairo Geniza.


Add $redirect-rule modifier

$redirect-rule should redirects only these requests which are blocked.
For example, rule like this:
*$script,redirect-rule=noopjs,domain=example.org
should redirects pagead2.googlesyndication.com/pagead/js/adsbygoogle.js, because it's blocked by this rule (from Base filter) /pagead2., but it shouldn't redirects requests like this example.org/script.js.
Description - https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#redirect-rule

Let's wait and see how the adoption of it goes

Do I understand correctly that it was implemented?
If so, then I think that it doesn't work correctly or maybe I just don't understand how it should works:)
Steps to reproduce:

Add this rule:
*$script,redirect-rule=noopjs,domain=ghacks.net
Go here -  https://www.ghacks.net/

As far as I understand, this rule should redirects only blocked requests (requests which are blocked by existing rules in filters), but it seems that it also redirects requests which are not blocked by any rule.
Screenshot without redirect-rule

Screenshot with redirect-rule

For now, it is implemented just as an alias for redirect modifier.

Okay I understand, but it works differently in uBO, so I'm not sure if it's a good idea.
For example, there is rule like this (in CJX's Annoyance List):
*$image,redirect-rule=1x1.gif,domain=youku.com
https://github.com/AdguardTeam/FiltersRegistry/blob/722d91981b8e6590b9ffd6f6c059c63138339aa9/filters/ThirdParty/filter_220_CJXsAnnoyanceList/diff.txt#L102
and with current implementation it will blocks (redirects) all images.


Pull request for issue #14350

This pr will fix issue #14350
simulated with
px4_sitl gazebo_standard_vtol
log: https://logs.px4.io/plot_app?log=dfb7a07f-6a15-4744-93cc-94c9bae79882

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/python-setuptools/python3-setuptools_39.0.1-2_all.deb  Could not connect to azure.archive.ubuntu.com:80 (<IP_ADDRESS>), connection timed out
maybe run the Python CI again?

@mlaiacker I think this CI error is unrelated, don'w worry about it.

I think why this could be happening is: For multicopter we had the problem of navigator constantly resending the same waypoints just to update the altitude to track the 3D line which killed all useful trajectory flying in the FlightTaskAuto because the goal waypoint would constantly update. I'm quite sure the trajectory generation for multicopter already does the 3D line for the user and fixed-wing apparently not. I have to do some testing to figure out if I'm right.

FYI @RomanBapst @sfuhrer

Still alive, cool!


[Bug Report] Lspsaga preview_definition: nothing happened

Hello there. Hope you're doing well.
https://user-images.githubusercontent.com/57322459/185334799-642e61b7-0c05-4d86-b4a2-e923347263f9.mp4
To reproduce:

generic gd to make sure I can jump to definition
go back and issue command: Lspsaga preview_definition
no response

Environment
❯ nvim --version
NVIM v0.7.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by builduser

Operating system: Linux
lspsaga commit: eec313a
Any input is much appreciated. Thank you:)

@kohane27  provide some react code that can reproduce will be useful

Hello @glepnir
Thank you for looking into this issue. I appreciate it.
What's strange is that other commands (Lspsaga code_action, Lspsaga hover_doc) work. Only Lspsaga preview_definition doesn't work.

npx create-react-app my-typescript-app --typescript
cd my-typescript-app
npm start
open index.js
go to line 5 (import reportWebVitals from './reportWebVitals';) and put cursor to reportWebVitals
:Lspsaga preview_definition

https://user-images.githubusercontent.com/57322459/185415885-07ed8b10-5920-4795-833f-7c0848489984.mp4
As you can see, the command Lspsaga preview_definition doesn't result in anything. But gd works to jump to definition.
Thank you again!

maybe that's mean there is no response from server . test it later

if you use typescript in react .I don't think there can have a index.js file

Hello @glepnir . I tested again on a lua file and it's working! js/ts is a hit or miss however. Not sure why but I guess it's nothing to do with lspsaga. Thanks again!

hmm you can test the lua vim.lsp.buf.definition() in that file . if this work then lspsaga definition still have some bug in that file.

lsp_finder work on 0.7 . preview definition works on my local

@glepnir
Lspsaga lsp_finder works perfeclty but Lspsaga preview_definition still doesn't.
https://user-images.githubusercontent.com/57322459/185910593-d0320d35-e1c1-49ff-b161-3f248525551b.mp4

when you press command it show a diagnostic widnow? this window not belong the lspsaga

The hover window is from the following code:
vim.cmd([[
" show line diagnostics automatically in hover window
autocmd CursorHold,CursorHoldI * lua vim.diagnostic.open_float(nil, { focus = false })
]])

I commented it out and tested again:
https://user-images.githubusercontent.com/57322459/185932217-308bac64-52e5-4442-8fe4-93705c332ada.mp4
Given it works on the lua file I suspect it's js/jsx related. Thank you anyway!

which server typescript-language-server ? I had test in 0.7 preview definition works fine.

Lspsaga preview_definition doesn't work for me on React files. I'm using neovim 0.7.2.

I will add a message in preview definition then you can report it in there. I can't reproduce this issue on my local .so need more useful information Thanks . reopen.

Thanks for reopening it. I'll report more info when I can.

I had add a notify in preview definition so you can try it and if there has messages post it in there.

Great news! With the log I figured it out.
It's the LSP attach order:

Once I change the order to attach tsserver first, preview_definition is working:
 Client: tsserver (id: 2, pid: 193872, bufnr: [14, 13, 20])
 	filetypes:       javascript, javascriptreact, javascript.jsx, typescript, typescriptreact, typescript.tsx
 	autostart:       true
 	root directory:  /home/username/my-app
 	cmd:             typescript-language-server --stdio

 Client: cssmodules_ls (id: 3, pid: 193873, bufnr: [14, 13, 20])
 	filetypes:       javascript, javascriptreact, typescript, typescriptreact
 	autostart:       true
 	root directory:  /home/username/my-app
 	cmd:             cssmodules-language-server

Thank you again!

Okay found problem because there has multiple servers that both support definition method . fix it later

Confirmed it's working even with the following lsp attached order:
 Client: cssmodules_ls (id: 3, pid: 193873, bufnr: [14, 13, 20])
 	filetypes:       javascript, javascriptreact, typescript, typescriptreact
 	autostart:       true
 	root directory:  /home/username/my-app
 	cmd:             cssmodules-language-server
 Client: tsserver (id: 2, pid: 193872, bufnr: [14, 13, 20])
 	filetypes:       javascript, javascriptreact, javascript.jsx, typescript, typescriptreact, typescript.tsx
 	autostart:       true
 	root directory:  /home/username/my-app
 	cmd:             typescript-language-server --stdio

Thank you!


Breakage from Querying Selection of all Reference Objects without WHERE Clause

Type of Issue
Select the type of issue:

[x] Bug report (to report a bug)
[ ] Feature request (to request an additional feature)
[ ] Tracker (I am just using this as a tracker)
[ ] Refactor request
[ ] Documentation Ask

Description
Title explains issue. Motivation due to this error:
TypeError: cannot unpack non-iterable NoneType object
Traceback (most recent call last):
  File "agents/craftassist/craftassist_agent.py", line 568, in <module>
    sa.start()
  File "/private/home/aqib/fairo/agents/core.py", line 23, in start
    self.handle_exception(e)
  File "/private/home/aqib/fairo/agents/droidlet_agent.py", line 296, in handle_exception
    raise e
  File "/private/home/aqib/fairo/agents/core.py", line 21, in start
    self.step()
  File "/private/home/aqib/fairo/agents/droidlet_agent.py", line 301, in step
    super().step()
  File "/private/home/aqib/fairo/agents/core.py", line 26, in step
    self.perceive()
  File "agents/craftassist/craftassist_agent.py", line 298, in perceive
    self.draw_map_to_dashboard()
  File "agents/craftassist/craftassist_agent.py", line 414, in draw_map_to_dashboard
    detections_for_map = self.get_detected_objects_for_map()
  File "agents/craftassist/craftassist_agent.py", line 399, in get_detected_objects_for_map
    search_res = self.memory.basic_search("SELECT MEMORY FROM ReferenceObject")
  File "/private/home/aqib/fairo/droidlet/memory/sql_memory.py", line 369, in basic_search
    return self.searcher.search(self, query=query, get_all=get_all)
  File "/private/home/aqib/fairo/droidlet/memory/memory_filters.py", line 516, in search
    vals = self.handle_output(agent_memory, query, memids, get_all)
  File "/private/home/aqib/fairo/droidlet/memory/memory_filters.py", line 451, in handle_output
    return [agent_memory.get_mem_by_id(m) for m in memids]
  File "/private/home/aqib/fairo/droidlet/memory/memory_filters.py", line 451, in <listcomp>
    return [agent_memory.get_mem_by_id(m) for m in memids]
  File "/private/home/aqib/fairo/droidlet/memory/sql_memory.py", line 305, in get_mem_by_id
    return self.nodes.get(node_type, MemoryNode)(self, memid)
  File "/private/home/aqib/fairo/droidlet/memory/memory_nodes.py", line 690, in __init__
    super().__init__(agent_memory, memid)
  File "/private/home/aqib/fairo/droidlet/memory/memory_nodes.py", line 624, in __init__
    "SELECT x, y, z FROM ReferenceObjects WHERE uuid=?", self.memid
TypeError: cannot unpack non-iterable NoneType object

Current Behavior
See error message above.
Expected Behavior
A selection query from the ReferenceObjects relation should not result in errors
Steps to reproduce
git checkout the aqib branch to see my code implementation for getting detected obstacles for the Craftassist agent from memory. The dashboard should properly display detected obstacles upon first initialization, but if you issue a command to the agent to change elevation (i.e. dig a hole), the necessary update to detected obstacles yields in a query selection error.
Links to any relevant pastes or documents
n/a
Checklist
Use this checklist if you are using this issue as a tracker:

[ ] Task 1
[ ] Task 2
[ ] Task 3 ...

@aqibisbiqa can you paste the command to repro this ?

Ah ok, this issue needs some updating.
Arthur suggested that I could bypass this issue by adding a dummy WHERE clause to the query that caused the problem. Originally, the code was:
def get_detected_objects_for_map(self):
    search_res = self.memory.basic_search("SELECT MEMORY FROM ReferenceObject")

But I've since altered it to this:
def get_detected_objects_for_map(self):
    # FIXME should not be using WHERE clause hack
    search_res = self.memory.basic_search("SELECT MEMORY FROM ReferenceObject WHERE y>-500")

So while the issue doesn't appear anymore on my branch, this is still something that exists. To reproduce, the extra step to do now is remove the "WHERE y>-500" part from the query, and then run the dashboard + cuberite + agent and issue the command dig a hole. I've updated the corresponding section as well

closed in https://github.com/facebookresearch/fairo/pull/1200


Style Project Creation

Overview
Styles the Project creation page and fixes a disabled button issue.
Demo

Notes

The wireframes show a disabled card for the districts, rather than hiding the whole card as above. If you would like me to do this, let me know!
This is responsive, just because it's another form like "Sign up" that someone might want to fill out on a phone. I recognize that the meat of the app won't be usable that way, but seemed worthwhile here.
I noticed some issues with the buttons I'd styled previously: the cursor was wrong and hover was showing for disabled buttons. Those issues are resolved here.
I added some reusable text variant to our theme: variant: "text.h1" & the like. Some of them feel way too big and might not be useful, but I figured going by the established text scale still made sense. IDK, open to feedback.

Testing Instructions

git pull
Go to http://localhost:3000/create-project
Hover on the "Create Project" button. It should show the not-allowed cursor and display no hover.
Add your project name.
Select a state from the select.
Click one of the radio inputs. The Create button should no longer be disabled.
Click the "Custom" option. Note the new input. The Create button should be disabled.
Enter a value into the input.

Closes #275

@jfrankl this is ready for another look.

Very long radio option title + custom on its own line

More vertical spacing under section titles


Carousel

Description
Heyy,
So I was thinking of adding a carousel automated so the idea is that:

It'll automatically change on it's own every few seconds.
It will also have buttons to switch from right to left and left to right.
I would start by adding the services you provide on each window and there will be links in button so the user can click on it and read the specifics.
It'd give the user a bit idea about what the website is offering primarily.

I have attached a sample screenshot
Since you  know first impressions are really important I would like to work on that.
Thank you
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@mayu-z assigned


Integrated Windows Authentication fails when app's jar does not have Implementation-Version: 2.0 in the manifest

Integrated Windows Authentication fails when app's jar does not have Implementation-Version:  in the manifest, or it is lover than 2.0
root cause of that is
getProductVersion() in HttpHeader

I believe this issue was fixed. Please reopen is needed.


✨ limit PoC

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
1792

Relevant Lines:
1792

💛  - Coveralls


[CARBONDATA-1932]Add version info for CarbonData

Add version info for CarbonData.
The way of generating version info is the same as spark.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@jackylk @xubo245 @chenliang613 please review, thanks.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2418/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1194/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2422/

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1198/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2424/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1200/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2610/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2613/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2439/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1216/

@jackylk @chenliang613 @xubo245 fixed according to comments, please review again, thanks.

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2635/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2636/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2456/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1229/


Add some extra wording to the connect wallet dialogue to make the benefits of browser vs snap clearer

The Chore
Extend the messaging on wallet connect to be a bit more informative as per the below
Tasks

[x] Jon to add the text
[x] Separate out the options a bit more graphically so it is clearer the two primary CTAs are browser wallet and snaps
[x] Update the text in line with below
[x] Test it

Full Text
NB. In each case the text in regular brackets is some sort of subscript or maybe pill component to be displayed next to the name given.  The square brackets indicate where the message needs to change based on the onboarding status or the browser used.
Vega Wallet (Full Featured)
[Install / Connect] Vega Wallet extension for [Chrome/Firefox] for access to all features including key management, asset breakdown, and detailed transaction views from your browser.
Metamask Snap (Quick Start)
Connect directly via Metamask with the Vega Snap for single key support without advanced features.
Advanced options

Desktop Wallet (Legacy)
CLI Wallet (Developers)
View as party

Metamask Snap
Additional details / background info

My personal opnion is we should choose either Advanced or other options.
Rather than have the / split. But other than that it looks good.


Create Radix_Sort.js

made a javascript file for radix sort.
Assigned Issue Number?
#001
Language Opted?
C/C++/Python/Java/...
Number of files added or updated?
1/2/3
Name of these files?
main folder => sub_folder => ... => ... =>  file.py
example :
Algorithms => Searching => Linear_Search => Linear_Search.py
Checklist

[ ] I was assigned for this otherwise my PR will be rejected.
[ ] I've read the contribution guidelines.
[ ] I've referred the correct issue number.
[ ] I've filled up this entire template correctly.

:star2: this repository and support.

made the pull request .


Transfer data from frontend to backend

Recently, I have been learning Next.js to implement the front, But I have some questions to discuss. In crates-pro, some data needs to be calculated in real time. For example, calculating the dependencies of any two libraries, which could have an infinite number of combinations. If we pack the data into a PG and the front end fetches the data offline, it may not be displayed. Or is it ok if we just implement functionality that can be displayed offline? @benjamin-747 @genedna

Discussed in #67


Properly initialize and free entropy mixing hash contexts

Summary: The entropy context contains a SHA-256 or SHA-512 context for entropy mixing, but doesn't initialize / free this context properly in the initialization and freeing functions mbedtls_entropy_init and mbedtls_entropy_free through a call to mbedtls_sha{256/512}_init resp. mbedtls_sha{256/512}_free. Instead, only a zeroization of the entire entropy structure is performed. This doesn't lead to problems for the current software implementations of SHA-256 and SHA-512 because zeroization is proper initialization for them, but it may (and does) cause problems for alternative implementations of SHA-256 and SHA-512 that use context structures that cannot be properly initialized through zeroization.
This PR fixes this.
Found and fix suggested by @ccli8 in https://github.com/ARMmbed/mbed-os/issues/5853.
Internal Reference: IOTSSL-2014

This can be closed as the fix has been merged in #993.


SQL error when a pad is first edited

The statement was aborted because it would have caused a duplicate key value in a unique or primary key constraint or unique index identified by 'SQL100312004647941' defined on 'PAD_SQLMETA'.
Once one pad has been edited, the first time each subsequent pad is edited, this error is thrown.
(Imported from Bitbucket #1 reported by maxg on 2010-03-12)

Fixed in cbf556829bbd9118f3e31ce32f6ef79acd93e86a. The version column seems to store the pad rep version, and should always be the same.
(maxg on 2010-05-12)


Add promotion requirements

@hemangsk raised this as https://gitlab.com/coala/cobot/issues/39
That'll come in handy whenever a contributor is to be promoted

It would be helpful to store our pending promotion requests inside corobo.
Then we can also interact with those requests in the chat rooms more easily.


Footer element shouldn't be styled by default

Hello,
I believe it's a bad idea to style footer element, as this is a semantic element in HTML5.
You should probably use a class, like .footer instead, allowing people to define a footer without having to use the MaterializeCSS design.

Done in 27fa7c3c711e266a7d4b7c121351848fb72db450


Add broadcast target to tplink

Description:
Related issue (if applicable): fixes #29503
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11373
Example entry for configuration.yaml (if applicable):
tplink:
  discovery: true
  target: <IP_ADDRESS>

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Thanks for the PR! Looks straightforward to me, so this can be merged after the documentation is done. #23218 is partially related to this, too.

@rytilahti @frenck  I have updated the PR with the docs PR.

I started to wonder if target is too ambiguous as a config key; would something like discovery_target be better?

I can make that change. I’ve had the same thought.

Looking good, please use black to format the file and I'll merge this after the "checks" are all green. Thanks for the contribution again :-)

I’ve been tracking down the error in the unit tests. It looks like somewhere the function async_get_discoverable_devices which was modified is called as a generic discovery function by the core tests. This expects the function to have only a single parameter. I’ll work on getting these tests run locally as well as a couple ideas to fix the code.

@mbrancato any updates on this PR? :)


On fresh install, ENOENT error for .cache/functions

Describe the bug
On a fresh install of Gatsby, the plugin fails to build due to a missing .cache/functions directory.
────────────────────────────────────────────────────────────────
  Plugin "@netlify/plugin-gatsby" failed
────────────────────────────────────────────────────────────────

  Error message
  Error: Error message
  ENOENT: no such file or directory, lstat '.cache/functions'

This was fixed in #26, so we need to do a release

Released in 0.0.2


bigger/better chests? chesttools ones

Suggested by MCLV. Look into it.

Currently evaluating on the test server.

Installed.


update addon status from more than one collectors

https://issues.redhat.com/browse/ACM-1930
Signed-off-by: marcolan018<EMAIL_ADDRESS>

/lgtm

/retest


Documentation for APPROX_COUNT_DISTINCT is wrong.

APPROX_COUNT_DISTINCT(x, e)
Returns the approximate count of distinct values of x with defined expected error rate e

But specifying precision does not work:
omnisql> SELECT APPROX_COUNT_DISTINCT(x, 0.001) FROM (SELECT 1 AS x) t;
Exception: Exception occurred: org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to line 1, column 42: Cannot apply 'APPROX_COUNT_DISTINCT' to arguments of type 'APPROX_COUNT_DISTINCT(<INTEGER>, <DECIMAL(4, 3)>)'. Supported form(s): 'APPROX_COUNT_DISTINCT(<ANY>)'
'APPROX_COUNT_DISTINCT(<ANY>, <INTEGER>)'

omnisql> SELECT APPROX_COUNT_DISTINCT(x) FROM (SELECT 1 AS x) t;
EXPR$0
1
1 rows returned.
Execution time: 17 ms, Total time: 18 ms

And it's unclear what precision would be if I don't specify it.

You're right, we will correct the documentation.
If present, e should be an integer from 1 to 100. If e is absent, the approximate count will be calculated using the hll-precision-bits system-wide configuration setting to control the precision.
Thanks for the feedback!


[3pt] Refine scripts for AHPS preprocessing

As the ahps evaluation evolves, refine scripts and existing functions to address inconsistencies with AHPS.  'Beautify' scripts.
This is a subtask to Agile Story #91

Able to address many of the 'edge' cases which were special exceptions.

Able to address many of the 'edge' cases which were special exceptions.


#19 removed unused code

Coverage remained the same at 94.444% when pulling 3f5b12447713d8c3f5faa08f85ea3e8d8a51e0b9 on salikjan:19 into 950d9adb0e064ff5c1fa48222c3b6babd9e51cb5 on decorators-squad:master.


(nRF51) The RSSI signal does not rise above -44 dBm

Describe the bug
The RSSI signal from the bluetooth beacon does not rise above -44 dBm even when the beacon is at a distance of 1 cm. But at the same time, the value decreases only at a distance of 25 cm or more. I use the NRF51_BLE400 debugging board as the receiver, and the factory beacon on the NRF51822 as the transmitter.
Here my code: https://github.com/Trubochkin/ble-gsm-gateway.zephyrproject/blob/fffd5c04624ac5ba11e491fda99f2ae5554aba1e/src/f_bluetooth.c#L95
Expected behavior
I need the RSSI to change over the entire range of distance. In the android application (nRF_Connect), I see that the RSSI value changes at any distance from the beacon. I can get a value of -20 dBi (at a distance of 1 cm) and below (at a distance). Maybe someone knows what could be the problem?
Screenshots or console output

Environment (please complete the following information):

OS: Windows 10
Zephyr OS build v2.0.0-rc1

The RSSI is calculated by the phone’s radio and stack, not by Zephyr. I will change this to a question and copy additional people.

The RSSI is calculated by the phone’s radio and stack, not by Zephyr.

Yes, the value comes from the Radio hardware. Did you try your Zephyr scanner on a nRF51/nRF52  Development Kit?

Yes, the value comes from the Radio hardware. Did you try your Zephyr scanner on a nRF51/nRF52 Development Kit?
I tried, but the result is the same.

Yes, the value comes from the Radio hardware. Did you try your Zephyr scanner on a nRF51/nRF52 Development Kit?

Yes

And was it better than the BLE400?

And was it better than the BLE400?

No, all the same

Updated to v2.0.0rc3 and this solved the problem. Now the value of RSSI rises above -44 dBm 👍


Nested component variant restriction bug

I'm seeing a bug with nested components connected with variant restrictions.
When I view the Code Connect code from the parent component the child component code ignores the variant restrictions  and just renders the first code connect code sample. However if I view each nested component individually the correct code appears.
Breadcrumb (parent)

vs. Breadcrumb item (child)

My figma.tsx file is here https://github.com/carbon-design-system/carbon/pull/16348/files#diff-38ea233b4b838e2f4e41e8bbd621f7524ce7496d17ef86aa3826b33f7157f9b3R16

Hi Alison, thanks for the report! The team is aware of this issue and we'll be hopefully solving it soon. Will keep you posted in this thread when the fix gets released.

Confirmed this is fixed, thanks ya'll! 🥳


Save exception after setting a value into the configuration

When using the configuration framework at a bukkit plugin, the save method generates a exception of NoSuchMethodException because of snakeyaml (Even if that is not used in the framework)

The problem was related to a Bukkit old snakeyaml dependency that was conflicting with our new version.


Missing migration

Hi, migrate command says that I have missing migration:
Your models have changes that are not yet reflected in a migration, and so won't be applied.
  Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.

When I ran the command ./manage.py makemigrations cuser it generated the new migration file for me with
migrations.AlterField(
            model_name='cuser',
            name='email',
            field=models.EmailField(error_messages={'unique': 'A user with that email address already exists.'}, max_length=254, unique=True, verbose_name='email address'),
        ),

This looks odd because we have the same email field parameters in initial migration. Maybe it is due to that I use SQLite database for my small project. Anyway, I gonna to make PR with this odd missing migration.
Does anybody observe the same issue?

Thanks for reporting this! It was a Python 2 / 3 thing. This has been fixed by<PHONE_NUMBER>c51208b727b3f9182f4d1f966efe2d


Zuta Daniel Narh  Module 1

WS2_M1E1_Submission.docx

Thank you for your successful submission to the practice exercise! Please be sure to fill out the post-Module survey.


Version 0.1

Initial release.

Yes. In fact, it should already be extending it 😕
Which is odd because dependents that extend EvaluableInterface depend on ValueAwareInterface not ContextInterface ... and yet their tests pass.

@mecha, I know, right!? I saw code that depends on ValueAwareInterface. Dunno why this isn't there.

I'm on Gitter, by the way, but you haven't replied since yesterday...

@mecha, following our discussion on Gitter, please re-name project to dhii/expression-interface, and re-factor the code.


feature: oneMKL migration

Description:
Feature: Migration from FPKs to oneMKL
Summary:
This PR updates the oneDAL codebase to ensure compatibility with oneMKL. It includes various fixes and modifications across multiple files to address issues related to the integration with the new libraries.
Key Changes:

Updating Public CI Environment:

Since MKL FPKs are no longer used, publicly available oneMKL packages have been added to the CI environment.

Removing macOS Public CI Step:

As oneMKL does not support macOS, the macOS step has been removed from the CI pipeline.

Bazel Changes:

Instead of using two different Bazel libraries (mklcpu and mklgpu), a unified MKL library is now utilized.

Service Functions:

The first set of FPK service functions has been replaced with public oneMKL functions, and the remaining ones have been replaced with standard C++ library functions.

Naming Updates:

References to FPK have been removed or replaced with MKL.

Macros Usage and CPU Instructions Updates:

As oneMKL does not allow switching between CPU instruction sets, all DAAL_MKL_CALL macros have been replaced with fname_fargs macros to call the equivalent functions in oneMKL.

Sparse API Updates:

The deprecated spBLAS stack from MKL has been replaced with the new oneMKL Inspector-Executor API.

PCA Algorithm Refactoring:

With the removal of the micromkl library, the PCA algorithm has been migrated to use GPU functions (syevd, gesvd).

Makefile Updates:

Library names and paths have been updated to support oneMKL.

Known Issues/Looking for Help:

Syevd and Gesvd Tests:

Assistance needed with these tests.

Public Build for Windows (WindowsMakeVC Step):

Guidance required to obtain a public build for this step.

Removing Unnecessary CPU Instructions and Macros:

Help needed with this cleanup.

Fixing Path Substitution for Windows:

Need to correct the substitution of \, /, and $ for proper Windows path handling.

Fixing the Linux Bazel Release_Dynamic Test:

Requires attention to resolve issues with this test.

Copying libmkl_sycl and Updating CMake Templates:

Need to fix issues with copying libmkl_sycl and updating CMake templates to include oneMKL dependencies.

@Alexandr-Solovev You'll need to work on mircomkl integration in the CI systems, and please include an informative description (or is this still supposed to be in draft?)

/azp run CI

/azp run CI

@Alexandr-Solovev please mark this as a DRAFT, if it is still under the development.

Link to the job with oneMKL: http://intel-ci.intel.com/ef7b39b8-64f0-f1ec-91a0-a4bf010d0e2d

Question: do we need to update scikit-learn-intelex deps in case of these migration?

https://github.com/intel/scikit-learn-intelex/pull/2066 is merged.
@Alexandr-Solovev you can launch the CI for the scikit-learn-intelex main.


Needs option for offset

I live close to Bihlplatz and there's a lot of vvs-traffic. It takes me 5mins to put on my shoes and walk to the platform, so if I look at my mirror at 12:00, the earliest U-Bahn that makes sense for me is at 12:05. For high-traffic stations, there's more connections between 12:00 and 12:05 than I'm showing on my mirror so I have to use the VVS App anyway.
Yes, I know there's the option to exclude uninteresting connections but it would still be a nice feature. If I find the time before you do, I'll try and implement this myself and make a pull request.
Danke und bis bald

Hi akraus53,
thx for the suggestion.  I'm fine with adding a new config to address an offset to the current departure time.
I just checked the API of VVS and there is the itdTime and itdDate parameter we could add to the request fetching data. So far I couldn't find out if, by adding those parameters, also the delayed departures are included. Would need some more investigation.
In addition to only show the in future scheduled departures I think we should also note the time or the offset somewhere in the UI, so that not only the owner of the magic mirror knows of this offset. What do you think?
Unfortunately I'm quite busy these day, so feel free to send a PR.  👍🏻

Sounds great! I'm buzy at the moment, too, but I'll look into it when I find the time.
My approach would have simply been
if(departure_time - current_time > offset){
  // Don't show this connection
}

Your idea by putting it to the top sound great.
Unfortunately there is no (publicly) available documentation about the vvs api. It is, since years planned that they will release shortly a documentation on their OpenData portal (https://www.openvvs.de/pages/api). To get the necessary information I reverse engineered the api.

I have added a parameter offset to the configuration:
https://github.com/niklaskappler/MMM-vvsDeparture/pull/11


Different autoprefixer settings for different .css files?

Is it possible to have e.g. different autoprefixer browser list for desktop.css and mobile.css?

It is with Grunt's targets and target-specific options http://gruntjs.com/configuring-tasks#task-configuration-and-targets


Extensions want to add VSCODE_GIT_IPC_HANDLE

I am seeing this issue:
https://github.com/microsoft/vscode/issues/102727
in 1.68.1
Note, in my setup:

I work with Remote containers
I have setup devcontainer.json to have the setting: "remote.containers.gitCredentialHelperConfigLocation": "none"

This happens every time I "reopen" VSCode when I closed it with the window connected to the Container open.
There should be no need for VSCode to configure Git IPC Handle in this case.

@Tyriar, given that you handled the linked issue, do you mind taking a look at this? Thank you!

@lszomoru do you know how remote.containers.gitCredentialHelperConfigLocation and the git.* setting interact?

The git extension does not use gitCredentialHelperConfigLocation setting.
Adding @chrmarti to see if the remote containers extension uses any of the git.* settings.

do you know how remote.containers.gitCredentialHelperConfigLocation and the git.* setting interact?

@chrmarti, could you please shed some light on this? Thank you very much in advance!

The gitCredentialHelperConfigLocation decides where Dev Containers sets its credential helper, that can be /etc/gitconfig, ~/.gitconfig or not at all. It does not affect any git settings in VS Code and I'm not aware of any side-effects there.

I'm guessing there's something going wrong with the environment variable collection caching and workspace identifiers. If each time the dev container is opened it is treated as a new unique workspace, it will not have a cache of environment variables to use so any changes that are made after by the activated extensions after the first terminal has displayed will show the diff there. Note that this only happens if relaunching silently is not possible.


Front Page - 3 Images and Better Text

Service, Corporate, Social text and some better images

Fixed with #10


How do I validate properties with a custom schema?

cfn-lint Version
cfn-lint 0.78.1
Provide additional details e.g. code snippets. Be sure to remove any sensitive data.
I want to use aws-sso-util and cfn-lint together. aws-sso-util provides a macro which fakes a custom type called SSOUtil::SSO::AssignmentGroup.
My template looks like this:
AWSTemplateFormatVersion: "2010-09-09"
Transform: AWS-SSO-Util-2020-11-08

Parameters:
  InstanceArn:
    Type: String
    Default: arn:aws:sso:::instance/ssoins-ffffffffffffffff

Resources:
  ReadOnly:
    Type: AWS::SSO::PermissionSet
    Properties:
      Name: ReadOnly
      InstanceArn: !Ref InstanceArn
      ManagedPolicies:
        - arn:aws:iam::aws:policy/ReadOnlyAccess

  AssignmentGroup:
    Type: SSOUtil::SSO::AssignmentGroup
    Properties:
      Name: ReadOnly
      InstanceArn: !Ref InstanceArn
      Principal:
        - Type: USER
          Id: ffffffff-ffff-ffff-ffff-ffffffffffffffff
      PermissionSet:
        - !GetAtt ReadOnly.PermissionSetArn
      Target:
        - Type: AWS_OU
          Id: ou-zzzz-zzzzzzzz

By default cfn-lint of course fails to recognize the custom type.
$ cfn-lint --template Macro-Test.yaml --region eu-central-1
E3001 Invalid or unsupported Type SSOUtil::SSO::AssignmentGroup for resource AssignmentGroup in eu-central-1
Macro-Test.yaml:19:5

I think I'm supposed to use --registry-schemas to solve this, but I've had limited success because of the missing documentation.
#2321 says that to lint Datadog::Monitors::Monitor you need to pass a directory of third-party resource schemas and points to #1732 for a partial solution.
SSOUtil::SSO::AssignmentGroup is not a real registered type, but is faked by macro preprocessing, so there is no schema to download. As far as I know, no one ever wrote that schema.
I created a file called custom-schema/AssignmentGroup.json with this content:
{
    "typeName": "SSOUtil::SSO::AssignmentGroup"
}

cfn-lint produces no output when I pass the the folder name, which I think means it now at least accepts the type name.
$ cfn-lint --template Macro-Test.yaml --region eu-central-1 --registry-schemas custom-schema/

I also want to validate the properties, and this is where I get lost.
I extend the custom schema to look like this:
{
    "typeName": "SSOUtil::SSO::AssignmentGroup",
    "properties": {
        "Color": {
            "Type": "String"
        }
    },
    "required": ["Color"]
}

My intention is to declare a required Color property. This should make cfn-lint fail again because my template doesn't have a Color property anywhere.
But cfn-lint still gives no output in this case.
There might be something wrong with the schema, but I'm unsure how to validate it.
What am I missing?

This should no be much easier in v1.  Where registry is a folder of json schemas.
cfn-lint -s registry -- template.yaml
E3003 'Color' is a required property
template.yaml:4:5


RDD 6 extraction: add frames suggestion to help

frames commandline parameter processing was updated in #38
After discussion with @matthewmarks-bbc:
However, it's still difficult for the user to know what the value should be. Perhaps just add a suggested value to the help e.g. 0-500? (why not make it very large like this?) or 0-50?
Is there any automatic checking that a complete description_text value has been extracted?

I've created https://github.com/bbc/bmx/pull/45 that hopefully addresses this issue. It adds 0-500 as an example and the description goes into why a range is needed. There is automatic checking for a complete description text and the extraction process stops if all program description texts are complete.


Mac CTRL_LEFT/RIGHT doesn't register initially.

Using the Macbook Pro 2017, if you hold CTRL+Left/Right, the editor will do nothing and not see it as an input.
However, if you hold left initially and then hold CTRL, it will register and perform correctly.

Hmm looks like this is actually just something innate to macs (or at least this version of it). Closing.


Homogenize .git directories in the project

💡 Issue: Remove Redundant .git Directories
📝 Description
The current project structure includes multiple .git directories scattered across various scripts and contracts. For streamlined development and version control, the project should have only one centralized .git directory at the repository's root.
The task involves:

Identifying project directories containing separate .git directories.
Removing these redundant .git directories while ensuring that the root .git directory remains intact.

🔢 Steps

Research the project structure to locate all .git directories outside the root.
Delete the identified .git directories.
Verify that the project functions correctly under a single global .git directory.

✅ Acceptance Criteria

All redundant .git directories are removed.
The repository contains only the root .git directory.
Development workflows (e.g., commits, pushes, pulls) are unaffected and operate as expected.

Can I work on this when it is available?

@danielcdz I can handle this and make PR in 5hrs from when this task will be assigned to me. Thanks

@danielcdz I would love to handle this.
I'll follow all steps listed above and ensure the development workflow remains unaffected
Eta 3 hours

Hey Sir, @danielcdz. Can I take care of this issue?


Add Archway <> JUNO IBC

@JeremyParish69
Noticed here looking at JUNO<>OSMO: https://github.com/cosmos/chain-registry/blob/614bb87ba1daff10b6e0e6de1fcb56d8b57b9c2d/_IBC/juno-osmosis.json#L34
Not able to IBC CW20 token (GLTO) using our relayer. is it because we need something like the above?

@JeremyParish69 Noticed here looking at JUNO<>OSMO:
https://github.com/cosmos/chain-registry/blob/614bb87ba1daff10b6e0e6de1fcb56d8b57b9c2d/_IBC/juno-osmosis.json#L34
Not able to IBC CW20 token (GLTO) using our relayer. is it because we need something like the above?

CW20 tokens need a special CW20-to-ICS20 contract on the originating chain and another channel to be able to IBC transfer them; that's what that port is--the contract

Any doc around this I can follow to get this going <3

Might start here, @Rizbe ?
https://github.com/CosmWasm/cw-plus/tree/main/contracts/cw20-ics20


[SVLS-4850] Generate lambda enhanced CPU system, user, and total metrics

What does this PR do?
This PR introduces three new enhanced lambda metrics. Each of the metrics are emitted once per invocation and represent CPU time spent running the lambda function.
The three new metrics are:

aws.lambda.enhanced.cpu_system_time - time spent by the CPU running in kernel mode
aws.lambda.enhanced.cpu_user_time - time spent by the CPU running in user mode
aws.lambda.enhanced.cpu_total_time - sum of aws.lambda.enhanced.cpu_system_time and aws.lambda.enhanced.cpu_user_time

Motivation

Users want insight into CPU resources used by their function
Product spec

Additional Notes
The values we generate for these metrics differ from those reported by lambda insights. The difference likely has to do with the point at which we collect CPU data with respect to the invocation start and end.
I collected a small sample of requests in this spreadsheet, trying the collection within callInvocationHandler vs. in the payload.EventType == Invoke block.
Possible Drawbacks / Trade-offs

Testing

Build the lambda extension
Create a lambda function with the extension built in previous step
Turn on lambda insights / add the lambda insights extension to your function
Invoke the function
View the new enhanced metrics in metrics explorer or this dashboard
Compare with lambda insight metrics

/merge