Add support for FTP on admin-lists.js

Closes #330
This adds support for fetching adminlists via FTP.
This can be done by adding a source like the following to adminLists in config.json:
"adminLists": [
  {
    "type": "ftp",
    "ftp": {
        "host": "XXX.XX.XXX.XX",
        "port": 12345,
        "user": "username",
        "password": "p@ssw0rd"
    },
    "source": "/SquadGame/ServerConfig/Admins.cfg"
  }
]

As I am pretty new to Node JS and more professional JS projects I'm pretty sure some part of code does not follow best practices. Please give me some advice if you find some bad code here :)
Apart from code this seems to work pretty fine on my own Squad server.

Just realized that to complete this issue I would have to add the info above to the ReadMe.
Would appreciate to first have a code review before adding info to ReadMe that doesn't fit the final solution.


WIP: Release notes and Doc update

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019

AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Fix compiling using Visual Studio 2010|2013|2015|2017|2019.
Fix building using either cmake/ninja or cmake/visualstudio.
Fix testing using cmake/ninja.
Improve Windows compatibility.
All existing tests passed using all Visual Studio versions mentioned.
Make sure you have checked all steps below.
Jira

[X] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-2955
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
*** Imported a couple of files (getopt.h/getopt_long.c) from FreeBSD with modification for Windows. BSD licensed sources should be compatible with the license here.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
*** No new functionality added. All existing tests passed.

Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does
*** No new functionality added.

@kiyolee The PR is messed up somehow. It contains many unrelated commits.
Also the following files have no licence headers:

lang/c/src/getopt/getopt.h
lang/c/src/getopt/getopt_long.c

@martin-g Didn't aware the last pull rebase was messed up. Now fixed.
The following files are originated from FreeBSD and modified to work with MSVC:

lang/c/src/getopt/getopt.h
lang/c/src/getopt/getopt_long.c
The license per file does exist and are kept unchanged. What have I missed?

The license per file does exist and are kept unchanged. What have I missed?

The RAT test fails because the new files do not have the ASLv2 license.
Since you are copying files from elsewhere we need to add an entry to the NOTICE file about that.


Update compatibility matrix for v1.57.x

Which problem is this PR solving?
Resolves #2574
Description of the changes
Updated compatibility matrix with the following map:

Jaeger Operator
Kubernetes
Strimzi Operator
Cert-Manager

v1.57.x
v1.19 to v1.28
v0.32
v1.6.1

How was this change tested?

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[ ] I have signed all commits
[ ] I have added unit tests for the new functionality
[ ] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

Thanks!


Add freeagent support for bankfeeds

Description
Update integration.js and add support for freeagent bankfeeds:
/bank-feeds-api/overview
Type of change

[x] New document(s)/updating existing

@jmyorston this is fine, but do we also need some supporting material about how to set up that integration for bank feeds?


docs(ru): Translation update

Closes #
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
Updates of

docker.md
vercel.md
faq.md
folder-structure.md
t3-collection.md
next-auth.md
prisma.md
trpc.md

Screenshots
[Screenshots]
💯

@AmadeusTwi @ronanru

Going to review in a hour or so.

Ready to merge :)


added devise closes #21

Coverage remained the same at 100.0% when pulling c555488f2779c1406e43245fec2d12408dafea1c on devise-#21 into 51a7e9b755888049c955f149b09a2aacbdc68a12 on develop.


Improve support for multiple tabs open

Use Service Workers to detect which tab has focus when possible
Expose App.uiHelper.tabId and App.uiHelper.tabHasFocus()
Clear chat notifications in other tabs once the last messages are seen.

Since only one serviceworker can be registered for a given scope, it might be worth renaming the focusworker.js script to a more generic serviceworker name in case more uses for serviceworkers are desired in future.


Feat:Preloader And Page Transition

Describe the feature
Preloaders and page transitions are UI/UX techniques used to enhance the user experience by providing smooth transitions between different states or pages in an application, making the app feel more responsive and polished. Here's a breakdown of these features in the context of a React application:
Add ScreenShots
Improved User Experience: Reduces perceived wait time by providing feedback and smooth transitions.
Polished UI: Makes the application feel more professional and responsive.
Visual Consistency: Maintains a cohesive feel when navigating through th
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this issue

go for it #25
assigned @itznayan


DNS Resolution Fails Sporadically - Crashes Server

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong Proxy 3.1.0 Kong Ingress 2.8.0
Current Behavior
Kong keeps crashing with DNS resolution errors.
If I restart kong it will work for 15 min or so, then all requests will fail and the website goes down.
If I exec into the kong pod directly I’m able to run nslookup commands fine.
Does anyone know why this may be happening? EKS 1.24 Kong Proxy 3.1.0 Kong Ingress 2.8.0
[notice] 1132#0: *436443 [kong] handler.lua:181 [mysite-auth] :mys_lua: resty - validation api call encountered error [cosocket] DNS resolution failed: dns lookup pool exceeded retries (1): timeout. Tried: [“(short)auth.web.svc.mysite.com:(na) - cache-miss”,“auth.web.svc.mysite.com.kong.svc.mysite.com:33
The other error I’m seeing frequently is:
[warn] 1132#0: * [lua] batch_queue.lua:183: failed to process entries: nil, context: ngx.timer”
Expected Behavior
No DNS Resolution Errors.
Steps To Reproduce
It happens sporadically, if I delete the kong pod and let it recreate it, it will work for some time before showing those errors and taking the web site offline.
Anything else?
EKS 1.24

Same issue.  However, we have always happened that the gateway service is not normal and cannot connect to the internal readis cluster
[cosocket] DNS resolution failed: dns client error: 101 empty record received. Tried: ["(short):(na) - cache-miss",".kong.svc.cluster.local:33 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".svc.cluster.local:33 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".cluster.local:33 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".ap-northeast-1.compute.internal:33 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",":33 - cache-hit/dns client error: 101 empty record received",".kong.svc.cluster.local:1 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".svc.cluster.local:1 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".cluster.local:1 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".ap-northeast-1.compute.internal:1 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",":1 - cache-hit/dns client error: 101 empty record received",".kong.svc.cluster.local:5 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".svc.cluster.local:5 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".cluster.local:5 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",".ap-northeast-1.compute.internal:5 - cache-miss/scheduled/querying/try 1 error: bad name/scheduled/querying/try 2 error: bad name/dns lookup pool exceeded retries (1): bad name",":5 - cache-hit/dns client error: 101 empty record received"], client: <IP_ADDRESS>, server: kong_admin, request: "POST /web3-gateway/caches HTTP/1.1", host: "xxxx"

Hi @NickTheSecurityDude @0xRook1e could yoy attach a tcpdump during the time the error happened (when Kong receives error/timeout, but normal nslookup is fine)?


Support sum-type discriminant field.

Proper tagged union support requires precise discriminant field names.
Support this with OAS3's Discriminator Object.

Fixed.


Calling callback(s) when bulb becomes inactive to avoid blocking

When a light is removed from the power, the pending callback(s) will never be called and therefor the accessory and all others are waiting for a timeout (triggered by homebridge?). This can take multiple minutes (in my case).
This change tries to trigger the timeout earlier. Once lifxnode notifies about the bulb being offline, the open callback(s) are closed, and the all other accessories can be resolved.
I only have access on one lifx bulb, so this change might need some testing in a multibulb scenario before merging into master.
In my setup i reduced messageHandlerTimeout to 20000  and lightOfflineTolerance to 2, because this solution relies on the light-offline event.

See also #21

@Krizzzn thanks for this, I'm going to run this at home for the next week, just to check that it's running smoothly, before I merge it.


Cannot use your sdk without a team token

Hi Superannotate team, thank you for sharing your great work!
I downloaded your SDK. While I found I am not able to test your SDK without initializing the SDK. In order to initialize it with "superannotatecli init", I need a team token. With a free account, I could not find where to create a team token. I am writing to check with you if I can test your SDK with a free account or not.
Many Thanks

Hi,
Sorry, we currently allow SDK to PRO accounts. Only functions that don't access online platform, e.g., annotation format converters, will work with a free account.
Thanks,
Hovnatan


|| HOw Do you use this Utility ||

Can we have a document how to use this utility .... I bit confused since it is a windows utility ... remote execution is more important
Thanks & Regards,
Neil

Reflective compiled DLL is added, you can use this DLL. For example with Cobalt Strike.


Should we dissable teams by default?

This would be a breaking change for teams users, but they could re-enable pretty easily.

I have already made changes that enable and disable teams with a single flag.
I will also update the installation documentatiuon to make it clear to new users.
It will remain on by default for existing users and new users will be directed to set the flag as part of the setup.

PR coming soon.


Enhancement: Save As... shouldn't reset Configuration per file...

SUGGESTION:
Save As... in the Spyder editor, shouldn't reset the the Run>Configuration per file... info. That info should carry over to the newly named source file.
MOTIVIATION:
Because you're saving the file "as" another filename, not doing a "Save copy as...", all settings associated with the editor file should remain the same.
I use a primitive version control scheme where periodically I save the file under a new name ("program10.py, program11.py, program12.py") in case I need to go back to an earlier version because I screwed up somehow.
This misfeature (reset of the info) is unfortunate - the Configuration per file... box pops up on the first run of each renamed file,  often necessitating tedious re-entry of the command line options.

Good idea. You're welcome to try to fix it because (unfortunately) we don't have time to do it, sorry.

I'm well aware you guys are going nuts with Spyder 5 bugs.
This is, obviously, low priority and can wait (that's why I said "Enhancement:"). But best to get the ticket in while I'm thinking of it.
Unfortunately I have neither the time not skill to help do it myself - I did just toss a few $$ into the kitty to help. :-)


polymorphic pixel type reader

When using an ITK reader one needs to specify a pixel type, but many file formats, including DICOM, are polymorphic and the actual data type is only known by reading the file.
Slicer includes a layer that queries the data type and then uses macros so that the native data type of the file can be returned.  This is all implemented in the VTK code that wraps ITK, such as these examples:
https://github.com/Slicer/Slicer/blob/master/Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx#L190
https://github.com/Slicer/Slicer/blob/dac2a3d60e91aeee5912751509455be2217f69fd/Libs/vtkITK/vtkITKArchetypeImageSeriesScalarReader.cxx#L90
It would be great if ITK implemented a more native support for this pattern to simplify the logic for users of the code.
This was discussed as an issue on the Slicer forum topic here:
https://discourse.slicer.org/t/slicer-dicom-scalar-volume-plugin-relies-on-old-gdcm-why-do-we-not-use-dcmtk/354/11

@fbudin69500  Do you think the approach implemented in ITKPython could be generalized ?

The advantage of ITKPython is that it is... in Python. So wrapping all the possible types is possible (see 1).
In C++, the problem comes with the templates. @pieper : In the example you shared, it seems that you are wrapping only scalar types. I used a similar paradigm (macros) to wrap more types (see 2 and 3). [2] is difficult to read and applied to a complex case, but something similar could be done in ITK. [3] is a more straightforward reader. The example I shared supports scalar, vector, and RGB/RGBA images. One could extend it to other types of images too.

Hi Francois -
You're right, I only sent the scalar types, but of course in Slicer we
actually instantiate the scalar, vector, color, and even tensor types  : D
They are broken up in multiple classes because the compilers wouldn't
support them all in one compilation unit (the code is all over 10 years
old).  Looks like the same issues keep coming up over the years, so maybe
it's time for some of the useful and clean paradigms to make their way to
ITK proper or as a remote module.
Cheers,
Steve
On Tue, May 30, 2017 at 8:00 PM, Francois Budin<EMAIL_ADDRESS>wrote:

The advantage of ITKPython is that it is... in Python. So wrapping all the
possible types is possible (see 1
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Wrapping/Generators/Python/itkTemplate.py#L419-L481
).
In C++, the problem comes with the templates. @pieper
https://github.com/pieper : In the example you shared, it seems that
you are wrapping only scalar types. I used a similar paradigm (macros) to
wrap more types (see 2
https://github.com/BlueQuartzSoftware/ITKImageProcessing/blob/develop/ITKImageProcessingFilters/Dream3DTemplateAliasMacro.h
and 3
https://github.com/BlueQuartzSoftware/ITKImageProcessing/blob/develop/ITKImageProcessingFilters/ITKImageReader.cpp#L155-L229).
[2] is difficult to read and applied to a complex case, but something
similar could be done in ITK. [3] is a more straightforward reader. The
example I shared supports scalar, vector, and RGB/RGBA images. One could
extend it to other types of images too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KitwareMedical/ITKDICOM/issues/7#issuecomment-305042713,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHsfUcPadZLcC1kNeFST7gzDBGrRBmUks5r_K24gaJpZM4Nq2zN
.

@pieper thanks for adding the report!


IBC enabled Digital Token Identifiers(DTIs) Module

One of the primary focuses of the IBC-enabled Digital Token Identifiers (DTIs) module is to facilitate the sharing of token information across different chains within the IBC network.
DTIs serve as a standardized representation of digital tokens that can be recognized and understood by participating blockchains. They provide a common language for token identification and information sharing.
With DTIs, blockchains can communicate and exchange token-related information, such as token name, symbol, and metadata. This sharing of token information enables seamless interoperability and cross-chain transfers of tokens.
DTIs help address the challenge of different blockchains using different native token standards or naming conventions. By providing a standardized format for token identification, DTIs enable blockchains to recognize and process tokens from other chains, even if they have different token standards.
The sharing of token information through DTIs opens up various possibilities, including cross-chain asset transfers, decentralized exchanges, and token bridging. It allows tokens to flow across different chains, enabling users to transfer and interact with tokens on different blockchains within the IBC ecosystem.
In summary, DTIs play a crucial role in enabling the sharing of token information and promoting interoperability between different chains, ultimately fostering a more connected and accessible blockchain network.

Take a look at this material
https://www.iso.org/obp/ui/#iso:std:80602:en


cleanup phpdoc and BatchResult interface

mainly adjusting the exceptions, but i also went over the BatchResult interface. we had duplicated methods and i reordered them to be consistent.
isSuccessful and hasResponseFor are the same
as are isFailed and hasExceptionFor
i went with isSuccessful and isFailed, but maybe hasExceptionFor / hasResponseFor would be more straightforward. wdyt?

I think isSuccessful and isFailed are better from a domain point of view. We are curious about if the request was successful or failed after all.

BatchException never neds to have a previous exception, right? it currently does not have that option, but it also would not make much sense.

Agreed. Actually there are several previous exceptions which are exposed through a custom API.

this looks ready from my point, please merge if you agree. i added https://github.com/php-http/utils/pull/12 to adjust the BatchResult implementation.

Do you want to add tests for TransferException prior to merging?

added the TransferExcpetion spec back. ready to merge i hope?

Go ahead once tests are finished.


[Bug] Rule 'not-allowed-char-in-name' handles non-ASCII chars (?) badly

What happened?
When I have line
-c not-allowed-char-in-name:pattern:[Á],
in my config file, Robocop crashes with trackback ending with
File "C:\Users\cen89549\AppData\Local\Programs\Python\Python37\lib\encodings\cp1250.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 147: character maps to <undefined>

It looks like Robocop treats the config file as if it were in CP1250 encoding; however, file utility says it is in UTF-8. This might be source of the error.
Operating System
Windows
Robocop version
1.11.0

Thank you for the report - I can reproduce the bug. And I fixed it locally by using the same solution we did for fixing encoding issues with disablers (use external method for loading the file content which is encoding-secure).

@MoreFamed New version of Robocop 1.11.2 was released that includes the fix for this. You can grab it by running pip install -U robotframework-robocop 😃


Removes tags of files not found

I have to use two separate Obsidian vaults (work and personal) but one Zotero Library (one account). The issue is that tags are removed from Zotero items when Obsidian Vault files are not found, which occurs when I switch between work and personal Vaults. This seems reasonable behavior to clean up tags, but of course causes problems across multiple vaults.
Perhaps a workaround could be, 1) option for tags be not removed at all, and/or 2) tags searched for items only in specific collections.

Hi @jakepog -- can you help me understand this use case? Will you describe what your setup for 2 vaults and one library is?
It sounds like switching about your usecase means that either the path that MarkDBConnect is searching for MD files changes, or the location of the MD files changes? Is that true?
It's possible to have, on one computer, 2 Obsidian vaults and 1 Zotero library, where the tags are not removed when you switch vaults. It just requires that MarkDBConnect path and the location of the MD files don't change.

Hi @jakepog -- can you help me understand this use case? Will you describe what your setup?
It's possible to have 2 Obsidian vaults and 1 Zotero library, where the MarkDBConnect tags are not removed when you switch vaults. It just requires that the path to the MD files in MarkDBConnect's settings doesn't change, and that the location of the MD files doesn't change.
It sounds like switching vaults leads to a change, either in the path that MarkDBConnect searches for MD files, or in the location of the MD files. Is that true?

Setup is one Zotero library, two Obsidian libraries, and two computer user accounts (work and personal). Each user account has one Obsidian vault and the shared Zotero library (via sync).
Yes, switching between vaults/user accounts causes changes to MarkDBConnect Zotero tags according to which Obsidian library is available. The file paths also change, as the vaults are located in different user name folders and vault names, and have different vault search paths (different vault structure). I suppose I could organise the vaults so that their file structure is similar.

@jakepog please try https://github.com/daeh/zotero-markdb-connect/releases/tag/v0.0.21 and see it works for you. In the advanced preferences, there's an option to turn off the remove-tag behavior.

addressed by 3fff8d34f7ff00e0a18d7bff8c099892fcba9f8f

hi @jakepog — Was this issue resolved by the release (0.0.22 or above)? Please let me know either way. I'll close the issue if I don't hear from you.

Apologies, didn't see notifications. Yes, brief testing in both libraries appears to show that no item tags are removed with remove-tag option selected. Many thanks to adding this behavior! Bit of a work around, but it will do.


Landing page for new users

This PR fixes issue #70

Desktop view

Mobile view - iPhone 5/SE

iPad

I thought we were going to have screens which ask for first name, last name and username after we click on Get Started 🤔
Or is it not so?

Not sure about those, we need to ask @ankushdharkar about that. When the user signs up using GitHub, we will be redirecting them to this page, and when they click on the get-started button, will take them to the signup form.

I thought we were going to have screens which ask for first name, last name and username after we click on Get Started thinking
Or is it not so?

Not sure about those, we need to ask @ankushdharkar about that. When the user signs up using GitHub, we will be redirecting them to this page, and when they click on the get-started button, will take them to the signup form.

The design link is there in the issue description itself 😅

#143 closing this PR because it's messed up so much!


Support Ollama microservice

Description
Support Ollama microservice
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
None
Tests
Local test.

Please add e2e test for the new microservice.


Compute vertex positions in the shader

Compute the vertex positions of solid and gradient quads in the vertex shader instead of passing explicit vertex and index buffers.
The solid, gradient, and image quad pipeline now do not need to create and bind vertex and index buffers, only per-instance vertex buffers are required.

Is there a problem with the PR? It's been a while...

@hecrj why did the tests not run? This looks like a cool PR


Get hex session id from sdp

There are some rtsp streams, the session id in sdp is hex, such as
103bdb6f
0X103bdb6f
There will be an sdp: invalid numeric value ``103bdb6f`` (o=- 103bdb6f 1 IN IP4 <IP_ADDRESS>) error

Hello, thanks for this contribution, please fix linting errors and this will get merged.

merged, thanks


Make Streaming Sync

Safe because there are no &self methods on Streaming<T> that access any of its non Sync members.
Fixes #81
Closes #84

So I'm not sure this is the correct approach, we should instead add them via bounds.

Closes #84

done in #84 thank you for the help <3


Support gensim4 LdaModel

Resolves NLeSC/litstudy#70
The name of the module providing LDA model support has changed between versions 3 and 4 of gensim. Besides that, the call to LdaModel() had to be modified.

If you could run black and commit, that would fix the only failing test in the CI.

Thanks @larsgrobe , is the pull request ready to be merged at this point, or are you still working on it?

It should be ready, at least I am using the code as such. Note that I also added the "ensemble LDA model", which aims at getting more stable topics from the LDA algorithm. This would need documentation, the concept is decribed here:
BRIGL, Tobias, 2019, Extracting Reliable Topics using Ensemble Latent Dirichlet Allocation [Bachelor Thesis]. Technische Hochschule Ingolstadt. Munich: Data Reply GmbH. Supervised by Alex Loosley. Available from: https://www.sezanzeb.de/machine_learning/ensemble_LDA/
Best, Lars.

Great! Thanks for your contributions. I am very happy to see support for the new ensemble LDA. I would like to have more topic modeling algorithms in litstudy that have been developed in recent years.
I have you have more ideas on topic modeling or are experimenting with other NLP processing techniques, do not hesitate to open a pull request, discussions, or issue to discuss your idea or your findings!


apiref_generator.py style fixes

Hello @samaid! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sdc/datatypes/hpat_pandas_series_functions.py:

Line 48:1: E302 expected 2 blank lines, found 1
Line 2929:23: E712 comparison to False should be 'if cond is False:' or 'if not cond:'


Webpack plugin: Only create precache manifest for a specified entrypoint

Library Affected:
workbox-webpack-plugin
Issue or Feature Request Description:
We’ve a Webpack configuration with several entry points which represent (somewhat) isolated parts. I’d like to build the precache manifest JSON file only for the files which are being used in one entry point of the project -- files and assets (managed via file-loader) from other entry points should not appear in the generated manifest.
I tried using both, the chunks and the excludeChunks settings, but neither give me the desired result:

when I use chunks and set it to the relevant entry point (e.g. entrypoint1), my manifest does not contain the assets (e.g. images) which are referenced in the entry point

when I use excludeChunks, the manifest contains all assets (e.g. all images from the entire project, no matter whether in which entrypoint they're being referenced)

A minimal example project which demonstrates my issue can be found here:
https://github.com/qqilihq/workbox-chunk-issue
Steps to reproduce:

Clone the repo
yarn
yarn build
Check dist/precache-manifest.af8924052142092476d2b7a9665c1d2e.js -- I'd expect it to contain an image beside the JS file
Modify webpack.config.js and toggle comments in line 18 and 19 to use excludeChunks
Check dist/precache-manifest.89bef461327312c73acadd63bd01a11a.js -- I'd epxect it to contain one image (the one from entrypoint1.js), however it also contains an image from entrypoint2.js

This sounds similar to #1859. I'll take this into account when testing out the new Workbox v5 behavior.

Looking into this a little more, when I try a webpack build, the output is:
Hash: 24f9195c1c0424db6903
Version: webpack 4.35.2
Time: 794ms
Built at: 07/02/2019 2:04:15 PM
                                      Asset      Size       Chunks             Chunk Names
        entrypoint1.6e7b84eea984685841ae.js  4.35 KiB  entrypoint1  [emitted]  entrypoint1
        entrypoint2.79bbf4af966bc2af7d10.js  4.34 KiB  entrypoint2  [emitted]  entrypoint2
kitten.97c7ec9e215a8d0d51f1e7205c94c50c.jpg   904 KiB               [emitted]
 puppy.3fc56dd1d4dd7ef3a30cb9a56b537fd5.jpg  34.6 KiB               [emitted]
                          service-worker.js  2.44 KiB               [emitted]
                        workbox-1997d11f.js  55.7 KiB               [emitted]
Entrypoint entrypoint1 = entrypoint1.6e7b84eea984685841ae.js
Entrypoint entrypoint2 = entrypoint2.79bbf4af966bc2af7d10.js
[./src/entrypoint1.js] 95 bytes {entrypoint1} [built]
[./src/entrypoint2.js] 92 bytes {entrypoint2} [built]
[./src/images/kitten.jpg] 89 bytes {entrypoint1} [built]
[./src/images/puppy.jpg] 88 bytes {entrypoint2} [built]

You'll notice that neither of the .jpg files have a value in the Chunk Names column.
Similarly, when I look into the compilation stats inside of the v5 webpack plugin, I can't find anything that maps those .jpg files to a named chunk:

(Apologies for sharing a screenshot, but that's the best representation I could find.)
My conclusion is that the file-loader doesn't actually create a chunk association when it adds the file assets to the webpack compilation. There's unfortunately no way for the Workbox plugins to infer that association.
https://github.com/webpack-contrib/file-loader/issues/28 seems to imply that that's the case as well.
I think you're going to have to use exclude/include instead of something chunk-based.

This should be addressed by the current Workbox v5.0.0 alpha.


x/build/cmd/release: windows installer propose to remove detected old version in installation directory

What version of Go are you using (go version)?
go1.6.3.windows-386.msi
What operating system and processor architecture are you using (go env)?
set GOROOT=C:\Program Files\Go
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_386
set GO15VENDOREXPERIMENT=1

What did you do?
Run installer go1.6.3.windows-386.msi, it didn't detect existing 1.6.2 installation, so I thought that maybe it is a feature to run multiple versions of Go side by side. Pointed it to existing C:\Program Files\Go installation.
What did you expect to see?
Expected it at least to warn about non-empty directory, then tell me what is he going to do with it:

remove
blend its files inside
fail

What did you see instead?
I see request for administration privileges to continue installation.

The current instructions mention:

If you are upgrading from an older version of Go you must first remove the existing version.

@0xmohit yea, I saw that, but many open source projects automate this in installer - for example VLC installer detects old installation and proposes several actions:

https://github.com/videolan/vlc/tree/master/extras/package/win32

Related: #16305
We don't have a Windows installer expert on the team. Any help is wanted.

Warning as displayed to install Go 1.12beta1 seems to solve the issue:

Thanks. Will close then.


Release to npm

This would be a good project to have published to npm with some good usage docs.

I'm working on this.

Lets work together on this what u say? release this ASAP

I'm not sure how that would work because it's just one command in the terminal from the owner of the repo. Anyway, I forgot to close this item when I published it about 3 hours ago. 🙂

Closing this as I have published the first version to npm - v1.0.0


How grpc server work with TLSchema client.

You used grpc and protobuff in server codes but for client you used the official telegram source codes which is using TLSchema serialization I wonder how this two can work together?
Can you help me?

Read source code: https://github.com/nebula-chat/chatengine/blob/master/mtproto/codec_schema.tl.pb.go

So you mean you customized grpc encoding/decoding?


421 email receipts not working

API CHANGES

Update report service to always return a tuple
Update notification service to use this tuple and have an early return from sending the email if there is an error generating the PDF
Added Version numbers for the report and notify APIs to the env.sample

UI Changes

Update Business Email Component to use the new name for mailing address (contacts)
Add type hints to index page for injected content to get rid of IDE errors
Make accessing business info safer on index page to prevent hydration issues when there is no business

/gcbrun

Temporary Url for review: https://business-ar-dev--pr-423-w91vgp96.web.app


Create nginx.conf/default

I think you have direct commit rights, but I'll merge this PR anyway thanks!


[th] Fix handling of digit 1

Apparently the digit 1 is written as "เอ็ด" only if it is the last digit in a multidigit integer part of a number. So "1100" should be written as "หนึ่งพันหนึ่งร้อย" and not as "หนึ่งพันเอ็ดร้อย".
I've received this feedback from Thai speaking person. Some additional information:

This rule works both for regular numbers and currency.
This rule doesn't applies for the digits after decimal separator. So for example 111.01 should be written as "หนึ่งร้อยสิบเอ็ดจุดศูนย์หนึ่ง" (the last digit "111" is "เอ็ด" and the last digit in ".01" is "หนึ่ง")
MS Office BAHTTEXT function transforms "1101" into "หนึ่งพันหนึ่งร้อยเอ็ดบาทถ้วน" (only last digit is written as "เอ็ด") so it does work according to this rule.

Ilya, thanks for your great fix! László


'There are no more files' error with Ruby 2.7..3 & Windows 7 (might be ffi related)

This might be related to ffi but wanted to post here to see if others have experienced a similar issue. This issue has appeared after having the application running without any errors. When I try starting up Sidekiq on a custom application, I get the following error:
C:/Ruby27/lib/ruby/gems/2.7.0/gems/ffi-1.15.4-x86-mingw32/lib/ffi/library.rb:145:in block in ffi_lib': Could not open library 'C:/Ruby27/lib/ruby/gems/2.7.0/gems/sassc-2.4.0/ext/libsass.so': There are no more files.\r (LoadError)`
Has anyone else had this issue? The file exists in the location so it's not missing.
I've tried reinstalling sassc gem and install goes okay, but I still have this issue when trying to run the application. Again it was originally working and nothing changed between start/stop of the application.

why do you load sassc in sidekiq? do you have any background jobs that compile sass at runtime? these gems are usually disabled on the production
the error means that that library cannot be opened, usually because there're some missing dependent libraries. Do you have a devkit installed? https://github.com/sass/sassc-ruby/pull/224 could be related, but it's just a guess. You need a better backtrace than this.


Wrong item selected

I have this weird behaviour: the selected item returns the item to the left, and not the one in the middle of the screen. I'm using .resizeType = .FloatWithSpacing(10.0) and 1 item per screen.
Anyone noticed this ?

I don't observe that on the puppy selector though..

Found a "hack" to go around that problem by using .tag of UIView as index... Still now clue where it's coming from.

Is that behavior in our examples as well?

No it's not, and I couldn't figure out what difference makes it bug in my code.

Could you try to reproduce the bug using the settings of a carousel you have in your project? Maybe that way we can try to find the issue. For now I'm ¯_(ツ)_/¯

Ok I figured out: the problem is that I create the carousel with:
 carousel = SwiftCarousel(frame: carouselFrame, items: [UIView()])
and then I set the corrects views.
If I create it with
carousel = SwiftCarousel(frame: carouselFrame)
I don't have this problem.

Perfect! Yeah, you don't need to specify your items in init, you can do it later. Thanks for resolving the issue! 🎉


In Lua plugin, response transform hook hangs indefinitely if the response contents are empty

ATS Version: 7.1 (compiled using --enable-experimental-plugins)
Debian Jessie within Docker 17.11

Lua plugin:
function transform_response(data, eos)
    ts.debug("transform_response") -- Never printed
    return data, eos
end

function do_global_txn_start()
    ts.hook(TS_LUA_RESPONSE_TRANSFORM, transform_response)
    return 0
end

Steps to reproduce:

Configure ATS using the lua plugin above
Make forward proxy request to an http page with 0 byte body
Request hangs forever, transform_response is never invoked

let me take a look tomorrow

Yeah. I confirmed the behavior in the master branch as well. With a remap rule going to http://httpbin.org/status/200

It is actually a corner case in which the input vio is not available.
One quick question. In this case you would still want a lua function to be called or not?

ok... let me assume that you still want a lua function to be called in this case.
Will provide a patch soon.

Thanks for checking this issue!
I think it's a good idea to call the lua function regardless of the input size for consistency sake. This is especially useful if we are initializing variables in the lua transform function.

can you try out PR #2939 ?


Support MPT

ggml's had a MPT example submitted: https://github.com/ggerganov/ggml/pull/145
We should be able to support this without too much trouble.

You'll probably have to convert it using that PR's Python: https://github.com/ggerganov/ggml/blob/b43281ab20a7d175a46af0c50ab3563509c59ed5/examples/mpt/convert-h5-to-ggml.py


TypeScript cannot resolve correct overload

while testing #21004:
In my hello world extension I just replaced the showInformationMessage by this:
        vscode.window.showWarningMessage('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: true },
             { title: 'world', isCloseAffordance: true }
        );

This works fine and TS does not show an error.
Then I changed the first 'isCloseAffordance' to 'false:
        vscode.window.showWarningMessage('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: false },
             { title: 'world', isCloseAffordance: true }
        );

Now I get this TS error:

So TS can no longer infer the correct overload for showWarningMessage.
Adding an explicit generic typ parameter fixes that:
        vscode.window.showWarningMessage<vscode.MessageItem>('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: false },
             { title: 'world', isCloseAffordance: true }
        );

I would expect that TS does not complain in this case.

This is not VSCode specific and is the expected behavior for TypeScript here.
For the code:
 vscode.window.showWarningMessage('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: false },
             { title: 'world', isCloseAffordance: true }
        );

The type of of { title: 'hello', isCloseAffordance: false }, is { title: string, isCloseAffordance: false }. This becomes the inferred type T in showWarningMessage. However, the type of    { title: 'world', isCloseAffordance: true }  is ``{ title: string, isCloseAffordance: true }which TypeScript cannot match withT`.
Two possible fixes:
 vscode.window.showWarningMessage('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: false as boolean },
             { title: 'world', isCloseAffordance: true }
        );

 vscode.window.showWarningMessage<MessageItem>('hello world', { modal: false },
             { title: 'hello', isCloseAffordance: false },
             { title: 'world', isCloseAffordance: true }
        );

@jrieken @joaomoreno this TS "feature" results in an awkward API usage experience. I had no idea what was going on and had to ask for help...

I'd say this is very bogus because the MessageItem is defined like this
	export interface MessageItem {
		title: string;
		isCloseAffordance?: boolean;
	}

So, because isCloseAffordance is defined as boolean I expect it to be a boolean. Otherwise it doesn't make sense that title is valid because the type can be made more strict by inferring title: 'hello' instead of title: string.
@mhegazy can you clarify?

@mjbvz analysis is accurate. boolean is just an alias to true | false. when the compiler is inferring for type T, it pick us {title: string, isclosedAffordance: false} as the type of the first argument, then {title: string, isclosedAffordance: true} for the second, where true and false are not compatible. so you either need to specify the type argument explicitly or cast to boolean as @mjbvz noted.
alternatively, the declaration can be changed to drop the generic type parameter and just use MessageItem.

@mhegazy does the same logic apply to the type numberas well? Would the use of two different values 0 and 1 result in the same problem?

No. but it would have applied to unions of literal types of numbers. e.g. 1 | 2

@mhegazy So that the fact that T is defined as T extends MessageItem and that MessageItem defines isCloseAffordance as boolean is ignored?

The fact that it is boolean tells the compiler to try and figure a more specific type, in this case true then false; then it is left with two infrances that do not match.
Think of f(t: T): T; you want the output to be 'false' if the input was 'false' and not just boolean.


[bug] npm run tauri dev - Error The "beforeDevCommand" terminated with a non-zero status code.

Describe the bug
When running "npm run tauri dev" i got this error:
><EMAIL_ADDRESS>tauri
> tauri dev

     Running BeforeDevCommand (`npm run start --port 1420`)

><EMAIL_ADDRESS>start
> ng serve 1420

Error: Invalid values:
  Argument: project, Given: "1420", Choices: "tauri"
       Error The "beforeDevCommand" terminated with a non-zero status code.

Reproduction
Create new tauri project with typescript and angular and run tauri dev after install packages
Expected behavior
No response
Platform and versions
Environment
  › OS: Windows 10.0.22621 X64
  › Webview2: 112.0.1722.64
  › MSVC:
      - Ferramentas de Build do Visual Studio 2019
  › Node.js: 18.16.0
  › npm: 9.5.1
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.26.0
  › rustc: 1.69.0
  › cargo: 1.69.0
  › Rust toolchain: stable-x86_64-pc-windows-msvc

Packages
  › @tauri-apps/cli [NPM]: 1.2.3
  › @tauri-apps/api [NPM]: 1.2.0
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Error("unexpected end of input while parsing minor version number")', src\info.rs:502:41
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Stack trace
No response
Additional context
I fixed the bug changing 2 lines in tauri.conf.json but it should generate the file with correct port after selecting options.
On build section, i change these 2 lines:
    "beforeDevCommand": "npm run start --port 1420",     "devPath": "http://localhost:1420",
to
    "beforeDevCommand": "npm run start",     "devPath": "http://localhost:4200",

Hi @amrbashir, looking on the commit i think the problem will persists because on angular the default port is 4200 and not 1420.

@andreescocard create-tauri-app's config will overwrite angulars default port: https://github.com/tauri-apps/create-tauri-app/commit/ca260fbefb9479db66a28e64730ff4d745eccee9#diff-c94484f43dcb633988ff7e0efa705554827c65bfc08ac8d82148869119381b37R5 - this also means you'd have to re-generate your template (or add the extra -- to your beforeDevCommand in tauri.conf.sjon) to see the PR changes in action.
(In the other templates this is handled by a config file but ig angular can only do it as a cli flag?)

@andreescocard create-tauri-app's config will overwrite angulars default port: ca260fb#diff-c94484f43dcb633988ff7e0efa705554827c65bfc08ac8d82148869119381b37R5 - this also means you'd have to re-generate your template (or add the extra -- to your beforeDevCommand in tauri.conf.sjon) to see the PR changes in action.
(In the other templates this is handled by a config file but ig angular can only do it as a cli flag?)

You are right, tested here on a new project and it is working fine.
Thanks for explanation

hello,I have the same problem,can you tell me how to fix that bug?

Hi, I also ran into this problem, I was helped by changing the postcss configuration extension with .js on .cjs


fix forbid parallel outfile if pipeline engine enabled.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #43437
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No colde files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Release note

None

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


HWI Examples: Updates, typos and simplification

Nice project :-)

@instagibbs  @achow101 Anything else you'd like to see here?

LGTM?

ACK 621d2bfffdd3e2aba3a6b30f896316450e72ab3a


JAWS and NVDA not detecting heading inside legend

Bug Report
What is the issue?
When using an <h#> element within the <legend> as per the 'Fieldset as page heading' pattern Jaws and NVDA will not treat this as a heading, therefore it does not display in the list of headings.
What steps are required to reproduce the issue?
Access any page with a <h#> inside a <legend> with Jaws or NVDA
What was the environment where this issue occurred?

Device: Laptop
Operating System: Windows 10
Browser: Chrome
Browser version: Latest
NHS.UK frontend package version: 2.3.1

I cant replicate this issue with my set up
would like to go through this with you when possible

Hey folks,
I think we've been made aware of the same issue and will be tackling this in this issue on GOV.UK Frontend: https://github.com/alphagov/govuk-frontend/issues/1605

Thanks @nickcolley, @Fenwick17 found it to the be the overflow: hidden; on the fieldset which was causing the problem for us (https://github.com/nhsuk/nhsuk-frontend/pull/542).
When Adam was testing this, he also tested GOVUK frontend and found it not to be an issue with the GOVUK fieldset. It looks like this particular fix was made to the GOVUK fieldset back in September (https://github.com/alphagov/govuk-frontend/pull/1548).
So I'm not sure if this is a different issue but I'll leave this open for discussion and maybe we can help, Adam may be able to add more info to this.

We've fixed the original issue raised in release 3.0.0.
Related: https://github.com/alphagov/govuk-frontend/issues/1605#issuecomment-545484044
I'll close this issue for now.


Install from source instructions

Hi,
I would like to package this into an RPM (when I have time, in a few months). Some documentation is missing about installing this from source. If you add these instructions such as dependencies and build steps to README.md, then I might create an RPM soonish for Fedora.

I don't believe it is possible to compile to RPM in Godot anyway, but you can compile to .86 and .86_64

@thenamesweretakenalready that makes no sense :) RPM is just a way to distribute software, it's not a binary. With dependency and build information I can create an RPM to distribute it on e.g. Fedora systems.

All you can with the project in godot is exporting it, if you want to compile godot check the docs
http://docs.godotengine.org/en/3.1/development/compiling/index.html


Multiple inhertance crash when iterating over the types after loading the assembly

After adding more than one inheritance on a class(baseType + interface), Coral crashes after calling type->GetBaseType(); on said type.
C# Example:

public interface IRespawnable {
    void Respawn() {}
}

public Player : Entity, IRespawnable { }

C++ crash:
m_GameAssembly = m_LoadContext.LoadAssembly(absoluteAssemblyPath);

for (auto& type : m_GameAssembly.GetTypes())
{
	auto baseType = type->GetBaseType(); // Crash here
	std::cout <<  std::string(type->GetBaseType().GetFullName()) << std::endl;
}

Hmm yeah I can see how this would cause crashing, Coral currently assumes a single base type. I'll see if I can get this fixed


webgl memory leak

在官网的例子中，我似乎发现了内存泄漏，每次平移或者缩放时，内存就会增加，特别是数据量较大的时候，浏览器会因为内存的增加而变得卡顿
下面是我打开官网的例子测试的情况，可以看到内存一直在增加且无法清除

Could you please test again with the main branch and report here whether the issue still happens? Thank you!

   Hi @jahow .  about VectorLayer.js——renderer.generateBuffers(this.batch_, transform).
   If submit a big batch of features to render, webworker of webgl always report "RangeError: Invalid array length".
   If cut the big batch to some small batch, then submit the small batches, webgl can show much more features, but the features can't be selected rightly.  Click feature A, but return Feature B.
   How to cut the big batch into many small batch to render and click, aim to load much more features.  thank you.

   Hi @jahow .  about VectorLayer.js——renderer.generateBuffers(this.batch_, transform).
   If submit a big batch of features to render, webworker of webgl always report "RangeError: Invalid array length".
   If cut the big batch to some small batch, then submit the small batches, webgl can show much more features, but the features can't be selected rightly.  Click feature A, but return Feature B.
   How to cut the big batch into many small batch to render and click, aim to load much more features.  thank you.


Rhiros 142 show historical data

Description:
Showing historical data for 45 days
Jira: https://issues.redhat.com/browse/RHIROS-142

Codecov Report

Merging #115 (8e7523e) into main (5ef2303) will decrease coverage by 1.73%.
The diff coverage is 4.70%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   20.52%   18.79%   -1.74%
==========================================
  Files          37       39       +2
  Lines         692      777      +85
  Branches      129      140      +11
==========================================
+ Hits          142      146       +4
- Misses        513      587      +74
- Partials       37       44       +7

Impacted Files
Coverage Δ

...ponents/HistoricalDataChart/HistoricalDataChart.js
0.00% <0.00%> (ø)

src/Components/HistoricalDataChart/Util.js
0.00% <0.00%> (ø)

src/Routes/RosSystemDetail/RosSystemDetail.js
0.00% <0.00%> (ø)

src/Utilities/api.js
0.00% <0.00%> (ø)

src/constants.js
75.75% <100.00%> (+3.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef2303...8e7523e. Read the comment docs.


feat: user deactivation

close: #65
what does this PR do
This PR introduces the functionality for deactivating user accounts. It ensures that users are properly authenticated and that their accounts are correctly updated in the database. Additionally, it includes an email notification to inform users about the account deactivation.
How should this be manually tested?

Authenticate a User:

Send a POST request to /api/v1/auth/login to authenticate a user and obtain a JWT token.

Deactivate User:

Send a PATCH request to /api/v1/users/deactivate with the following request body:

Request
{
  "confirmation": true,
  "reason": "your reason to deactivate"
}

Response
{
 "status_code": 200,
 "message": "Account Deactivated Successfully"
}

Ensure that the user account status is updated to deactivated in the database.
Verify that the user receives an email notification about the account deactivation.

Checklist of what you did

[x] Implemented authentication check to ensure the user is authenticated with a valid JWT token.
[x] Restricted the endpoint to accept only PATCH requests.
[x] Added logic to update the user status to deactivated in the database.
[x] Implemented email notification to inform users about the account deactivation.
[x] Added unit tests for deactivateUser methods.
[x] Ensured proper handling for scenarios such as user not found, invalid confirmation, and already deactivated accounts.
[x] Updated exception handling to provide detailed error responses.

Notes:

Make sure to test the endpoint with different scenarios to verify that all cases are handled correctly.
Review the email template for the account deactivation notification to ensure it meets the requirements.

@Cobidex this pr changes how the routes are structured, since it was the patch(":id") that was above so it was taking the requests coming for Patch("deactivate"), so changing their position accommodates both the endpoints


Very similar to fsnotify/fsnotify

Hello there,
The very recent creation of this repository was brought to my attention, with some concern about the extreme similarity with fsnotify/fsnotify.  It sounds somewhat unfortunate to have a project that is so similar to a very well known project, from known contributors to the community, and with the exact same project name.
I would suggest donating this repository to Nathan Youngman in respect for his many contributions, and creating the similar project in a different repository that would more clearly identify itself in a distinct way.
Thanks for your understanding.

it's even worse. if i try to download fsnotify as dependency via gopkg.in the default location for the fsnotify package is this repo. i realized this when trying to build oauth2_proxy:
➜   curl -i gopkg.in/fsnotify.v1
HTTP/1.1 404 Not Found
Date: Tue, 20 Mar 2018 22:53:19 GMT
Content-Length: 106
Content-Type: text/plain; charset=utf-8

GitHub repository at https://github.com/go-fsnotify/fsnotify has no branch or tag "v1", "v1.N" or "v1.N.M"%

@jodok Right, gopkg.in always resolves gopkg.in/foo as go-foo/foo, unambiguously.

Turns out the issue is even more problematic, because fsnotify/fsnotify was in fact named go-fsnotify/fsnotify before being renamed:
https://github.com/fsnotify/fsnotify/commit/9297c46340639aebbb6820f260c699465528fb60
As a consequence, there are actual projects in the wild attempting to import this project, and breaking right now. Once there is code here, they will transparently build the diverging code, silently. Unless there is some agreement here, I may have to block this repository, which is a first for gopkg.in.
Ironically, the rename creates exactly the sort of breakage that gopkg.in is meant to avoid in the first place. But we of course can't prevent people from moving the code around.

I recently had a build break with the same 404 @jodok posted above. It seems like until this repository is taken down, dep ensure will continue to fail.
Out of curiosity, @niemeyer if this was the only place fsnotify resolved to on gopkg.in, how did this dependency ever resolve properly? Does gopkg.in define some kind of fallback repository URL which points at fsnotify/fsnotify?

@xjtian I've just responded to that above. Code worked because this was the real repository name before it got renamed. Nothing will fix your code to point to the right location until the code is fixed, because the repository location was changed by the maintainers of fsnotify/fsnotify.

Hi, I just pushed a readme on master to explain what is going on. This account/repository were registered to block potential dependency takeover attacks.

@go-fsnotify Thanks, but who are you?

Hey, the go-fsnotify org is now under @nathany 's control. I'll write a short piece about Go dependency injection later this month, I'll be sure to mention it on Gopher's slack.

I'm struggling to understand what all of this is about. It all sounds like someone intentionally broke everyone depending on gopkg.in/fsnotify to prove a point?

The question is: Whoever did that.. have you tried to reach anyone about this exploit prior breaking everyone depending on gopkg.in/fsnotify? Maintainers of gopkg.in or fsnotify?
The problem is quite bad now because the whole redirect was to gracefully perform the migration to new import. Now it's almost impossible.
@nathany if you got control of this org, maybe it's worth to clone the fsnotify here temporarily as mitigation?

However, this was poorly handled and has led to preventable frustration. First, theres absolutely no reason why this repo remained undocumented and empty for well over 8 hours. The lack of a readme or any contact from the opener of this repo caused no small amount of chaos and confusion in consumers of fsnotify. Also, that the maintainer of gopkg.in was not also notified immediately prior to opening this repo is also sloppy because they had equal or greater stake in this security problem than the maintainer of fsnotify.
If you must break a bunch of people’s stuff in the name of claiming the discovery of a vulnerability, please do a better job of making your intentions known to the people you broke next time.

@DamareYoh We have no evidence that the intentions were actually good, and in terms of data points we still haven't heard from @nathany.
I'll patch gopkg.in today to make it redirect to the proper repository.

@niemeyer, on that, I went digging in the gophers slack yesterday, and I found this: https://gophers.slack.com/archives/C029RQSEE/p1521584215000430
So @nathany seems to be aware of the problem, and has been in contact with the opener of this repo.
But still, the communication is obnoxiously poor. And for seemingly no reason.

Hi, I registered the account yesterday in order to test a theory (which I honestly thought would fail) where it is possible to register an account that is being used by a Github "redirect". I expected Github would block this and it clearly did not. I instantly notified the maintainer (through Twitter and Email) and we started the process of delegating the account in order to mitigate eventual breakage. I think Nathan has been AFK for over 12 hours now, so that is why the communication is poor. I'm not in control of this org/repo any longer.
As you can see in the Slack converstion linked previously, I was first told to fork the legitimate repository, but that would have been silently poisoning projects (with legitimate code). This would be a half-measure, since the project would eventually be out-of-sync. Silently forking the repository would also mean that a large amount of projects would never notice that the projects they are pulling does not come from the right repository. I think this is why I was then told to put a notice message stating why things were broken, and how to fix it (to the best of my understanding at the time).
Fixing this right now: If you use gopkg, simply fix your imports to point to the fsnotify/fsnotify.v1 repository.
gopkg.in/fsnotify.v1 → gopkg.in/fsnotify/fsnotify.v1
Again, sorry I broke your builds, this could have been handled better. I'm working on enumerating all vulnerable packages and will coordinate with @niemeyer and vulnerable package owners in order to mitigate this once and for all. When this will be done, the plan is to send it to Github to make it no longer possible to register accounts that are redirects, mitigating this type of situation. This is especially bad considering someone could be transparently serving malicious code through this repository.

Thanks for the clarification. In turn, I'd also like to clarify that my concern is not that the builds were broken (I think breaking them in this case was the right thing to do) but that it took 8 hours for us to find out why they were broken.

@ldionmarcil Agreed, you forking the repository would have been even worse as people would wonder if the content was legitimate. To be clear, I'm not blaming you either. The point I made was that really we have to actual evidence about whether the intention is good or not because the only data we have is the conversation here, which was started by the community after the fact.
About the coordination with me, note that this all unrelated to gopkg.in, in that any repository that moves away and leaves the original URL unattended will have the exact same issue. Having gopkg.in here actually helps because we can move people back to the right location, but I have no plans on doing that regularly.

@guineveresaenger Clearly I'm all for stability and although it's not an issue in gopkg.in, I'll add a workaround to fix a problem today so you don't need to fix everything else there.
With that said, I'm personally giving the creator of that problem the benefit of the doubt. We have no proof that the intention was good, but we also have no proof that the intention was bad. Registering a project in GitHub is very quick and uncontroversial, and easy to miss the dimension of the problem created for others.

@niemeyer appreciated; thanks! I'll follow this thread.

@guineveresaenger you can simply fork the pinned version you need and apply the one-line fix for this issue. Just saved you a few day of work ;)

Okay, https://gopkg.in/fsnotify.v1 now redirects to the renamed repository.
I also took the chance to move the server into Google Compute Engine. So please let me know if you see any issues related to this or otherwise.

@isra17 unfortunately it's not a direct dependency. I can submit a patch to the version though. :)

@guineveresaenger Take your time now.. that redirect won't go away while gopkg.in exists.

@niemeyer I can't seem to go get that:
go get gopkg.in/fsnotify/fsnotify.v1
# golang.org/x/sys/unix
../../../golang.org/x/sys/unix/syscall_darwin.go:49:9: undefined: RawSockaddrDatalink

@guineveresaenger That's an error outside of the package. The repository retrieval and compilation is working fine here, at least.

Thanks @niemeyer for adding the gopkg.in redirect.
Apologies for the poor communication on this. It was my mistake for relying on the GitHub redirect and not considering the security implications.
See also https://github.com/fsnotify/fsnotify/issues/108 for the original reasoning behind moving away from gopkg.in and version numbers in import paths (this happened over two years ago).

I'm restating this here since it's where the information around this problem is being centralized.
@ldionmarcil stated this elsewhere:

Hi. I am in the process of reporting this to affected organizations. Yes, you can mitigate this by pointing directly to github.com/fsnotify/fsnotify. You can still use gopkg.in if you need a specific version of this project in order to fetch the repository but be sure to always use gopkg.in/{org_name}/{repo_name}.

This is completely incorrect information, and helps no one. Not even you @ldionmarcil, as I bet you'd rather be providing correct information in your comments as a security researcher.
There's zero benefit in using "go-project/project.v1" vs. simply "project.v1" for repositories that are named like this. The problem that affected the "fsnotify" occurred because the project renamed their repository from "go-fsnotify" to "fsnotify". If they were using "gopkg.in/go-fsnotify/fsnotify" as the import path or even "github.com/go-fsnotify/fsnotify", and renamed the repository, the exact same problem would happen.
So the problem is completely unrelated to gopkg.in, and the main lesson here is also general: do not make leave your existing URL unattended if you know the community is trusting it to be there. In fact, that's true even if you have a custom domain name.

I agree that discussing on the other repository is not productive. Let's take it back here.
I think there is value in mentioning that gopkg.in will append go- to the repository name if it is not specified. This is the sort of behaviour that can lead developers into not realizing (or forgetting) that using the gopkg.in/{repo_name} import value is actually pointing to github.com/go-{repo_name}/. It took literally two years for people to notice that their gopkg.in/fsnotify imports was actually pointing to a non-existing organization.
Had the developers been recommending gopkg.in/{org_name}/{repo_name} initially, users of the library would have noticed the break and it could have been mitigated instantly, unstead of leaving an insecure open redirect dormant for literally two years. You are free to think I am saying nonsense, but I will continue to state that the default behaviour of gopkg.in is weird and it will definitely lead to this type of scenario again in the future.

The entirety of your message is incorrect, @ldionmarcil. You don't understand even at a trivial level how gopkg.in works (hint: there's documentation about it in the front page), and also don't understand why that github.com URL has exactly the same problem. Please don't create more damage than you already did and do a bit of home work, Louis.

You seem to think I am putting blame on the gopkg.in project, and I'm not sure why. What I am stating is that the default behaviour when no organization/username is used is weird, and I stand by that. I'm not saying you caused this, or anything close to that. I recommended that users use the full {name}/{package} for a reason: it is immensely more clear where your package actually comes from. I don't appreciate the hostility, especially since I am trying to verbalize the behaviour of your project.

Hey, I was the one defending your back a few message above, remember?
It's not about blame, and I couldn't care less if you like gopkg.in or not. It's about factually incorrect statements such as the one I quoted above. Your messages were also edited several times after I said to please do some research, because they were also factually incorrect.
So I'm simply asking to please stop and do some research so you can understand better what happened, so that people can trust you in the future, and so that I don't need to go after your traces fixing these bogus comments.
Thank you!

If anyone still having problems and uses dep – that worked for me:
[[override]]
  name = "gopkg.in/fsnotify.v1"
  source = "github.com/fsnotify/fsnotify"


Crawler search processor

Details

[x] Added a crawler processor over REQUEST_QUEUE
[x] Associate a requestId with IPFS to filter easily downstream
[x] Some refactoring

Tests

[x] Submit a search request -> shows up in requestQueue -> eventsFound -> added to ipFsQueue for content building

search request submitted via api got through blockchain crawler


Add the Build ID as a comment on the Build Report pages

Currently, we have a comment that shows the version_id for the build, but it'd be useful to also have the builds.id available.

Are you referring to the individual build pages? If so the reason they don’t have it is because it’s in the URL :)

That's an extremely good point 😂


release artifacts for release 0.0.1

Release artifacts for preview release 0.0.1
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/hold

/unhold


How do I get the scores for the selected feature?

Is there any way that I can get the scores for the selected k features?

You can set return_scores = True in your function call. returns tuple (features, relevance, redundancy)


File tree collapses by itself

Prerequisites

[x] Can you reproduce the problem with Debug -> Reload Without Extensions?
[X] Did you perform a cursory search to see if your bug or enhancement is already reported?
[X] Did you read the Troubleshooting guide?

Description
File tree collapses when clicking sub directory. Console shows the following error when clicking on a sub directory:

/preferences/PreferencesBase.js:666
Uncaught TypeError: Cannot create property 'C:/path/to/folder/here/' on string ''

I can make the file tree work by changing line 266 in /project/ProjectManager.js
ActionCreator.prototype.setDirectoryOpen = function (path, open) {
  this.model.setDirectoryOpen(path, open).then(_saveTreeState);
};

to this
ActionCreator.prototype.setDirectoryOpen = function (path, open) {
  this.model.setDirectoryOpen(path, open);
};

Steps to Reproduce

Click directory on the file tree
Click sub directory

Expected behavior: The sub directory should expand.
Actual behavior: The parent directory collapsed.
Versions
Windows 10
Release 1.13 build 1.13.1-17699 (windows-release-1.13.1 fc2ebbeea)

Is this happening with all folders or just this one? I am not able to reproduce this.

It happening in all folders. I see this bug in my laptop but not in my desktop. Both have Windows 10 and similar software environment. Started having this issue after a Brackets update, but don't remember anymore which one was it unfortunatelly.


Not working properly after the lastest HA updates

The icons don't show up after the latest HA Update. Could you please check. Thanks.

It's working for me. Can you please provide some more information:

Exact HA Version
simpleicons component version
Browser/App you are using to access HA

Don't worry, it's working fine with Edge, Chrome, Opera, Silk(under alexa) and Firefox. I was running it as an app using Chrome extension and there is when the problem occurs.

The icons do not show up for me.  I have removed and reinstalled the integration under HACS and still no icons.
Home Assistant 2023.4.1
Supervisor 2023.04.0
Operating System 9.5
Frontend 20230406.1 - latest
SI version 2.2.0

please try the newest si version and the newest home assistant version and open a new issue if you still have problems


[Feature Request] Add --cap-add and --cap-drop equivalents in Portainer

Description
With creating Docker containers in the commandline, there is an option to specifically give or take a certain capability to or from a container. This is important to have accurate control over what a container is allowed to do. (see: https://docs.docker.com/engine/reference/run/)
In Portainer, when creating a container, there is no such option implemented yet.
Suggested solution
One could add all these capability keys to Portainer's create container section under "Security/Host" in form  of checkboxes or some other UI element.

You can add this functionality via a stack in a compose file but then you loose a lot of the power of Portainer for adhoc service definitions, such as the config and secret management. I am stuck between the stacks and services ui options and really need the cap-add and cap-drop added to the services ui options.

+1 for this

For those interested to test this feature, it's available with the preview image portainer/portainer:pr2078 (Linux amd64 only)

Looking forward to this one.
This will allow portainer.io to support netdata containers without having to drop into a command line.

@WriteCodeEveryday well it's part of Portainer 1.19.2 :-)

@deviantony greatest crossover update ever!


Do not run transaction for an empty Multi

This change bypasses the transaction for a Multi that has no operations.

@michalmuskala please merge after you review it. :)

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

Thanks @andrewtimberlake


Authentication Anomaly When Using Multiple Applications and Owin-MixedAuth

I have two mvc 5 applications setup using OWIN-MixedAuth deployed to the same server. Each application is inside a separate folder and configured with its own app pool as follows:
xyz.domain.com/MySiteA

xyz.domain.com/MySiteB

Web config for each is as follows
<system.web>
   <customErrors mode="Off"/>
   <authentication mode="None" />
   <compilation debug="true" targetFramework="4.5.2" />
   <httpRuntime targetFramework="4.5.2" />
</system.web>
<!-- Enable Mixed Auth -->
<location path="MySiteA/MixedAuth">
   <system.webServer>
       <security>
        <authentication>
            <windowsAuthentication enabled="true" />
        </authentication>
       </security>
    </system.webServer>
</location>
<system.webServer>
    <modules>
        <remove name="FormsAuthentication" />
    </modules>
    <handlers>
        <remove name="ExtensionlessUrlHandler-Integrated-4.0" />
        <remove name="OPTIONSVerbHandler" />
        <remove name="TRACEVerbHandler" />
        <add name="ExtensionlessUrlHandler-Integrated-4.0" path="*." verb="*" type="System.Web.Handlers.TransferRequestHandler" preCondition="integratedMode,runtimeVersionv4.0" />
    </handlers>
</system.webServer>`

 <system.web>
   <customErrors mode="Off"/>
   <authentication mode="None" />
   <compilation debug="true" targetFramework="4.5.2" />
   <httpRuntime targetFramework="4.5.2" />
</system.web>
<!-- Enable Mixed Auth -->
<location path="MySiteB/MixedAuth">
   <system.webServer>
       <security>
        <authentication>
            <windowsAuthentication enabled="true" />
        </authentication>
       </security>
    </system.webServer>
</location>
<system.webServer>
    <modules>
        <remove name="FormsAuthentication" />
    </modules>
    <handlers>
        <remove name="ExtensionlessUrlHandler-Integrated-4.0" />
        <remove name="OPTIONSVerbHandler" />
        <remove name="TRACEVerbHandler" />
        <add name="ExtensionlessUrlHandler-Integrated-4.0" path="*." verb="*" type="System.Web.Handlers.TransferRequestHandler" preCondition="integratedMode,runtimeVersionv4.0" />
    </handlers>
</system.webServer>`

When a user logs into one applications, the user is automatically logged into the second application as well even though they are not a registered user in the second application.
similarly loggin out of one application automatically logs the user out of the second application.
This is happening if I authenticate using a Form or windows. How can I prevent this happening?
This is my login code on both applications:
    [AllowAnonymous]
    public ActionResult Login(string returnUrl)
    {
        // If user is already logged in
        if (HttpContext.Request.IsAuthenticated)
        {
            return RedirectToAction("Index", "Manage");
        }

        ViewBag.ReturnUrl = returnUrl;
        return View();
    }

I've managed to fix by adding a cookie name to startup.auth:
var cookieOptions = new CookieAuthenticationOptions
{
    AuthenticationType = DefaultAuthenticationTypes.ApplicationCookie,
    CookieName = "MySiteA",
    LoginPath = new PathString("/Account/Login"),
    Provider = new CookieAuthenticationProvider
    {
        // Enables the application to validate the security stamp when the user logs in.
        // This is a security feature which is used when you change a password or add an external login to your account.
        OnValidateIdentity = SecurityStampValidator.OnValidateIdentity<ApplicationUserManager, ApplicationUser>(
            validateInterval: TimeSpan.FromMinutes(30),
            regenerateIdentity: (manager, user) => user.GenerateUserIdentityAsync(manager))
    }
};

app.UseCookieAuthentication(cookieOptions);
 app.UseMixedAuth(cookieOptions);

Yes, Most probably, because both apps are under the same domain.
Thanks for the feedback!


How to set config that the admin files lying inside the admin folder?

Hi
I want all controllers for the admin panel and all the view lay in the admin folder.
I use
'path' => [
       ...
        'routes'            => base_path('routes/admin.php'),
        'controller'        => app_path('Http/Controllers/Admin/'),
        'views'             => base_path('resources/views/admin/'),
        ...
    ],
    'namespace' => [
      .....
        'controller'        => 'App\Http\Controllers\Admin',
        ....
    ],
    'prefixes' => [
        'route' => 'admin',
        'path' => '',
        'view' => 'admin',
        'public' => '',
    ],

After I get this result:
Controllers
-- Admin
--- ProductController.php

and views (l move "layouts" in admin)
views
-- admin
--- layouts
--- admin
---- products
----- files .... each has @extends('layouts.app')

where there is no namespace admin
and in route admin.php
Route::get('admin/products', ['as'=> 'admin.products.index', 'uses' => 'ProductController@index']);
....

Where there is no namespace Admin.
What could be the problem?

I am having the same problem. Basically I would like to use the scaffold in an admin area together with the AdminLTE Theme, but it seems I can't tell the generator to look for the files in the admin folder / namespace.
Like @mrKorg i moved the views/layouts to views/admin/layouts, but they are still extended extends('layouts.app'). How can I tell the generator to extend these files from admin.layouts.app ?

@matthib from where you are including this admin.php route file? You can specify namespace directly there. so if it's included from web.php then you can do something like,
Route::group(['namespace' => 'Admin'], function () {
    include "admin.php";
});

about extend admin.layout. you can publish templates. Check docs here.
Then you can update all files where it uses @extends('layouts.app'), and replace with @extends('admin.layout').
That way, your new generated files will take these updated files.
ALSO MAKE SURE, YOU DELETE ALL OTHER FILES FROM PUBLISHED TEMPLATES, THAT YOU DON'T NEED TO CHANGE.

@mitulgolakiya
Thank you for the quick reply!
I followed your advice to publish the templates and changed all the templates to @extends('admin.layout') and it works great :+1:
I also deleted the unused template files, but I am wondering why it is so important to delete them, even if I didn't change them?
Using an 'admin' prefix in the config (I guess it is the path one?) helps to create the controllers in the Admin namespace, like Admin\ACMEController@index, so I got this one covered as well.

@matthib so once you publish the files, your templates are taken from there when generator creates files. It does not use the files from vendor directory.
so whatever new changes are coming to those files will not be reflected. so it's always good to publish only files which you need.


Discovery only finds API gateways

Describe the bug
Discovery only shows API gateways. It is missing VPC, subnets, SG, Lambda, DDB, s3 buckets, cloudfront and other resources. The discovery process seems to be running normally from https://docs.aws.amazon.com/solutions/latest/aws-perspective/debugging-the-discovery-component.html
To Reproduce
v1.1.0.
Expected behavior
Expect to see VPC, subnets, SG, Lambda, DDB, s3 buckets, cloudfront and other resources
Screenshots

Browser (please complete the following information):

Chrome
Version 93.0.4577.63 (Official Build) (64-bit)

Additional context
The solution/account being inspected has been deployed with minimum privilege roles, however this should not be causing any issues due to the perspectives IAM roles.

This looks like the install of AWS Config has gone wrong somewhere. Is the account you're importing the Perspective account or a different one? If it's the Perspective account Can you check the CloudFormation stack called aws-perspective-<account-no>-eu-west-1-DiscoveryImport-* and see if there are any errors there. If it's not the Perspective account, can you go to the to the account where you installed the regional-resources.template file and see if there are any errors there.

Thanks for your help.
I have perspectives in a different account to what I am inspecting.
I am pretty sure the template I installed was called global-resources-*.template (this is what I have downloaded), so I am checking my config. Having to wait for an ultra-slow password reset because browser did not remember my login. Is this something that is disabled by the sign-in form? I notice that autocomplete="off". This means I can't use the browser to remember the auto-suggested, secure password, and I have to store it in a different, non-secure location.
The UI was very unclear about what CFN gets installed where. And I followed the trouble shooting guidance before creating an issue. I will report back later (hopefully the password reset arrives before it times out)

You need to install the global-resource.template in the account you're importing (this just contains an IAM role, which only needs to be done once per account as IAM is a global service)  and then you need to install the regional-resources.template  in the region you wish to import  (this sets up AWS Config, which is a regional service). There is more information on this in the section entitled Step 3. Import a Region in the documentation here.

Thank you. The section titled 'What template do I need to download?' made this sound like an either/or, ie deploy the global or the regional resource for a brand new account. I just deployed the global.
I have now deployed the regional CFN to Sydney and US-East-1. Both CFN deployed to completion without errors.
I am now seeing data for 323 resources.

Ah good stuff. We can look at making the wording a bit less ambiguous there then.

I just experienced this same thing, and had read the documentation in the same manner as @datamystic

Same issue here,
deployed in account X,
Imported account Y via global config - seeing same phanomen.
Trying to import regional config - got errors on stack

We have updated the UI in v2.0.0 to make this much clearer.


_WD_Shutdown: Directories related to temporary profiles aren't being deleted automatically.

Bug report
Describe the bug
Directories related to temporary profiles aren't being deleted automatically.
https://www.autoitscript.com/forum/topic/209877-webdriver-is-not-deleting-the-folder-named-scoped_-at-the-end-of-the-execution-with-edge-browser/?tab=comments#comment-1515043
How to reproduce
Call _WD_Shutdown immediately after calling _WD_DeleteSession
Expected behavior
Temporary directories to be automatically deleted.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
System under test
Please complete the following information.

OS: [e.g. Windows 10]
OS Arch.: [e.g. X64]
Browser [e.g. firefox]
Browser version [e.g. 96.0.3]

_WD_Shutdown is a wrapper for __WD_CloseDriver, which is where all the action takes place.
A quick "fix" is to insert a short 2 second pause in _WD_Shutdown to allow the webdriver console to complete any post processing before passing control to __WD_CloseDriver.

The Chromium based webdrivers all support a /shutdown  endpoint that can be called to gracefully exit the console.

The `/shutdown' endpoint won't be added to the W3C standards and won't be added to geckodriver, so I'm inclined to avoid using this endpoint.


display errors and other minor fixes

Issue #4
added try-catch to handle and display errors
fixed opening html tag with lang
removed unused variable, removed unnecessary div closer
added .idea in .gitignore

LGTM


C# to Python or Julia doesn't work.  Indicates footer issue.

Describe the usage question you have. Please include as many useful details as  possible.
I am writing a struct array in C# using the following code:
        var structField = new StructType(
            new []
            {
                new Field("field1", new StringType(), nullable: false),
                new Field("field2", new Int64Type(), nullable: false)
            });

        StringArray stringArray = new StringArray.Builder()
            .AppendRange(new[] {"angel", "bobby", "charlie"})
            .Build();
        Int64Array intArray = new Int64Array.Builder()
            .AppendRange(new[] { 1L,2,3 })
            .Build();

        StructArray structs = new StructArray(structField, 3, new IArrowArray[] { stringArray, intArray }, ArrowBuffer.Empty, nullCount: 0);

        var recordBatch = new Apache.Arrow.RecordBatch.Builder()
            .Append("col1", false, structs)
            .Build();

        using (var stream = File.OpenWrite("test.arrow"))
        using (var writer = new Apache.Arrow.Ipc.ArrowFileWriter(stream, recordBatch.Schema, true))
        {
            await writer.WriteRecordBatchAsync(recordBatch);
            await writer.WriteEndAsync();
        }

But when I try to read it in julia I get an error:
using Arrow
table = Arrow.Table("test.arrow")
@show table
@show table[1]

ERROR: LoadError: MethodError: no method matching iterate(::Nothing)
Closest candidates are:
  iterate(::Union{LinRange, StepRangeLen}) at range.jl:872
  iterate(::Union{LinRange, StepRangeLen}, ::Integer) at range.jl:872
  iterate(::T) where T<:Union{Base.KeySet{<:Any, <:Dict}, Base.ValueIterator{<:Dict}} at dict.jl:712
  ...
Stacktrace:
 [1] getdictionaries!(dictencoded::Dict{Int64, Arrow.Flatbuf.Field}, field::Arrow.Flatbuf.Field)
   @ Arrow ~/.julia/packages/Arrow/P0wVk/src/table.jl:409
 [2] getdictionaries!(dictencoded::Dict{Int64, Arrow.Flatbuf.Field}, field::Arrow.Flatbuf.Field)
   @ Arrow ~/.julia/packages/Arrow/P0wVk/src/table.jl:410
 [3] macro expansion
   @ ~/.julia/packages/Arrow/P0wVk/src/table.jl:339 [inlined]
 [4] macro expansion
   @ ./task.jl:454 [inlined]
 [5] Arrow.Table(blobs::Vector{Arrow.ArrowBlob}; convert::Bool)
   @ Arrow ~/.julia/packages/Arrow/P0wVk/src/table.jl:321
 [6] Table
   @ ~/.julia/packages/Arrow/P0wVk/src/table.jl:295 [inlined]
 [7] #Table#98
   @ ~/.julia/packages/Arrow/P0wVk/src/table.jl:290 [inlined]
 [8] Table (repeats 2 times)
   @ ~/.julia/packages/Arrow/P0wVk/src/table.jl:290 [inlined]
 [9] top-level scope

Similar error for:
stream = Arrow.Stream("test.arrow")
for d in stream
    @show d
end

I've also tested it with Python:
table = feather.read_table("test.arrow")
print(table[0])

OSError: Verification of flatbuffer-encoded Footer failed.

So it seems to be an issue with the footer maybe not being written in C#.
Component(s)
C#

I'm unable to reproduce this.  I'm attaching the test.arrow file that gets created when I run your code (zipped so that github will allow it).  This file is readable in python just fine:
>>> import pyarrow.ipc as ipc
>>> with ipc.RecordBatchFileReader("test.arrow") as f:
...   f.read_all()
...
pyarrow.Table
col1: struct<field1: string not null, field2: int64 not null> not null
  child 0, field1: string not null
  child 1, field2: int64 not null
----
col1: [
  -- is_valid: all not null
  -- child 0 type: string
["angel","bobby","charlie"]
  -- child 1 type: int64
[1,2,3]]
>>> import pyarrow.feather as feather
[test.arrow.zip](https://github.com/apache/arrow/files/11124084/test.arrow.zip)
>>> feather.read_feather("test.arrow")
                                 col1
0    {'field1': 'angel', 'field2': 1}
1    {'field1': 'bobby', 'field2': 2}
2  {'field1': 'charlie', 'field2': 3}

Can't get it to work, how strange.  I am running python 3.9 with arrow ^11.0.0 on a Macbook M1.

Can you upload the file that gets created?

test.arrow.zip

This is quite strange.  It's almost like the footer is written and then the last part of the file is rewritten.  In other words, if the file was:
ABCDEFGHIJKLMNOP
you have:
ABCDEFGHIJKLMNOPMNOP

Do you know if there is anything that could be modifying the file after you have written it?

No, that was the entire script.

It might be interesting to write the batch to a MemoryStream instead and then inspect its contents.


grub-mkrescue can be called grub2-mkrescue

The Makefile calls grub-mkrescue util for creation for an image generation.
But this utils is called grub2-mkrescue in Fedora Linux and maybe other
rpm based distros.
This patch updates Makefile, so we will check existence of grub-mkrescue
or grub2-mkrescue before.

This looks good to me. Does anyone else have any thoughts?

Thanks @0xAX !

Thanks @0xAX !

@steveklabnik Thanks for merge 👍


fix: Disable Spinnaker app endpoint expansion

The default behavior for the /applications/{appName} Spinnaker endpoint
will expand to return metadata for all clusters for the given application.
In most cases, this is fine, but for large applications that have thousands
of clusters, this can cause damaging high load.
@lorin @tomaslin PTAL

LGTM


fix a typo

when i was using:
docker search --automated -s 3 nginx
told me:
Flag --automated has been deprecated, use --filter=automated=true instead
Flag --stars has been deprecated, use --filter=stars=3 instead
and when i use:
docker search --filter=automated=true --filter=stars=3 nginx
told me:
Error response from daemon: Invalid filter 'automated'
and i found out that the correct command should be:
docker search --filter=is-automated=true --filter=stars=3 nginx

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:daniel48/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM except DCO

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:daniel48/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353908512
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

thanks！This is my first pr to docker, i hope there will be more in the future~

It's appreciated, things like this are easily overlooked.
Congratulations with your first PR!

@daniel48 some tips; we have a contributors guide that may help setting up your environment; https://docs.docker.com/opensource/project/software-required/#task-3-install-make
I see you opened this PR from your master branch, which often complicates things if your PR is being reviewed, and you need to "rebase". It's best to open a "feature branch" for each pull request, so that you can work on different pull requests, without having issues rebasing etc.

thanks very much! i'm an undergraduate and am not so familiar with these rules. thank you for your suggestion, i will read it asap.

No worries, I was scared as hell when I opened my first PR, and had to figure out how the workflow was, and getting used to rebasing, etc. If you need help, also feel free to join the Docker Community Slack channel (http://dockr.ly/community), and ping / DM me when needed

thanks! i'm now studying the guide, and registering for the slack channel.

all green, merging 👍


If an environment diff looks like json, use a json differ like jd

Sometimes a environment diff is actual plain json, diffed on one big single row.
As a result an entire screen is coloured red/green without really helpful semantics.
Even the --character-oriented is not really of great help at times (when the diff is a little bigger).
It might be possible to use  something like https://github.com/josephburnett/jd to make the result more intelligible.
Since these tools are no haskell, a good way would be to optionally write files with old/new environments to disk, it then becomes trivial to do the semantic diffing by hand.

I was able to copy chunks manually together from the output, but that's rather brittle.

Yeah, we run into this same issue at work, too where the diff fares poorly on large JSON files.  The tool can probably auto-detect JSON and use a more intelligent diff for that case

A colleague just hinted me at https://github.com/jeffkaufman/icdiff -- which I happily forward really just for general knowledge & inspiration in the context of this issue.


 throws validation error with @layer

When validating a <hairpin> element I get:
element hairpin: Relax-NG validity error : Invalid attribute layer for element hairpin
In MEI 2.1.1, @layer is definitely allowed. It seems like it should be allowed in 3.0.0, but I can't confirm this. Was @layer removed from this in 3.0.0?

I also get the same error for <trill>.

@layer is definitely available in 3.0.0 -- <hairpin> is a member of att.hairpin.log, which is a member of att.controlevent, which is a member of att.layerident, which defines @layer. Whew!
I have no problem validating <hairpin form="cres" tstamp="1.25" tstamp2="0m+1" layer="3"/> or <trill xml:id="trill01" tstamp="1" layer="4"/>.
What is the error message you're getting?

Didn't read your original message carefully enough.  Sorry.  What parser are you using?

I'm using xmllint.

Do you get an error from oXygen?  If you don't have it, you can mail me your markup and I'll give it a go.
Are you using a schema generated from develop-perry or something else?  Can you mail me the schema too please?

I figured out the problem with this -- the validation error was misleading. The value of @hairpin in the problematic files was 0. Changing it to a value >0 fixed it.


driver: i2c: cc13xx_cc26xx: to support i2c scan

Sending address without data, make i2c scan I2C_0 work.

@jadonk  I think you fork the upstream zephyr, but actually not.

upstream PR: https://github.com/zephyrproject-rtos/zephyr/pull/38584


feat: override vra configuration cache

This pr allows the following configurations to be overridable via env vars:

access_token (access token for API operations) with env var VMWARE_VRA_ACCESS_TOKEN
refresh_token (refresh token for API operations) with env var VMWARE_VRA_REFRESH_TOKEN
url (base url for API operations) with env var VMWARE_VRA_URL
reauthorizeTimeout (timeout for how often to reauthorize the access token) with env var VMWARE_VRA_REAUTHORIZE_TIMEOUT

The changes look good.  I'm not sure why the prerequisites failed due to an auth issue, but you need to regenerate the rest of the pulumi files like this:
make build_sdks

Then add them to the PR.

@schmidtw sounds good, just regen the sdks
regarding the gh check failure, I think it's expecting to find a token in my fork repo but there's nothing there


x11 with flatpak

Is there a way to specify to Flatpak to run using x11?

@menachem1 what do you mean exactly?
if you want to run something else than sdl-freerdp flatpak run --command=xfreerdp com.freerdp.FreeRDP does that for you

👍🏻


Colorblend attachment count must match subpass colorAttachmentCount

Spec says that attachmentCount from pipeline's ColorBlendStateCreateInfo must match the colorAttachmentCount of "subpass" meaning the single subpass referenced in ColorBlendStateCreateInfo, but core_validation currently checks against each active subpass of the active renderpass.
The check should only apply to the single subpass at index "subpass", and not each subpass as they become active.
Relevant spec sections are concerning "VkGraphicsPipelineCreateInfo":
If pColorBlendState is not NULL, The attachmentCount member of pColorBlendState must be equal to the value of colorAttachmentCount used to create subpass

And concerning "VkPipelineColorBlendStateCreateInfo":
attachmentCount is the number of VkPipelineColorBlendAttachmentState elements inpAttachments. This value must equal the colorAttachmentCount for the subpass in which this pipeline is used.

I think VulkanSamples issue 63 addresses at least part of this in that if the are no color attachments in the subpass, you shouldn't pass pColorBlendState at all.  I'm not sure what the answer is for 2 different subpasses with differing numbers of color attachments - that still needs to be addressed

This has been corrected with the changes in pull request #350 [https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/350]


added five.canadian

Please add your tests eh.

Suggestion: Québécois
five.quebecois = function() { return 'cinq eh'; };

If you could add a test and fix your indentation I would absolutely merge this :smile: :maple_leaf: