ft(rbac): Cyclops login page for authentication & Integration of Cerbos for Authorization

closes #48
Preview
https://github.com/cyclops-ui/cyclops/assets/43869046/f4344c17-d6af-4e12-86c5-548cadebc64f
📑 Description

Added Login Page
Added authentication context provider, for auth state management

✅ Checks

[ ] I have updated the documentation as required
[ ] I have performed a self-review of my code

ℹ Additional context

Integrated Cerbos for authorization.
Added a login controller and handler for username and password based login:

Returns a JWT access token, which the auth middleware uses to verify each endpoint.

Created Cerbos policies for each resource.
Added a Cerbos service to Docker Compose for local development.
For user and password verification it uses kubernetes secrets

currently the way of creating a user is
apiVersion: v1
kind: Secret
metadata:
  name: cyclops-user-1
  namespace: cyclops
  labels:
    app.kubernetes.io/part-of: cyclops
    app.kubernetes.io/type: user
    app.kubernetes.io/name: siddhant
data:
  password: c2lkZGhhbnQ=
  roles: dXNlcg==
  username: c2lkZGhhbnQ=
type: Opaque

the query will be based on the labels
  labels:
    app.kubernetes.io/part-of: cyclops
    app.kubernetes.io/type: user
    app.kubernetes.io/name: siddhant

app.kubernetes.io/name: siddhant same as the username

Further required enhancement

need to refer sample k8s cerbos setup https://github.com/cerbos/demo-rest/blob/main/deploy/k8s.yaml and add this to part of cyclops installation

This looks awesome. Is there a reason you separated this PR from the other?

I believe, I should close the other PR because I require rbac changes for the UI changes, and I also need to work on the latest branch instead of the rbac branch due to updates in the controller.

Got it. Could you then close the other PR? Is this one ready for review

You can review this i'll close that one, and update the Additional Context for this

Thanks, will do!

Also before merging the changes, we need to have Further required enhancement part too, and a way to generate admin user

Hey @siddhantprateek, I started reviewing the PR, but could you separate it into smaller PRs? It's going to be easier to review it and discuss the solution. Especially if we still have some parts of the solution we need to discuss

Could we also have a logout button in the sidebar? Make sure to resolve conflicts and pick up the latest main branch

Thanks for the clarification! I often forget to ask where exactly to place the logout button. I’ll also make sure to resolve any conflicts.

@siddhantprateek can we put the logout button in the top right on the navbar? Also, we could add the username and role currently used


[Request] Config option to nerf brewing potions in cauldrons

I'm currently trying to create a pack including Inspirations, and while I want to keep the cauldron's ability to brew potions, the presence of fire retaining blocks much earlier than netherrack means that the player is able to brew potions way earlier than he should, not to mention the fact that cauldron brewing doesn't require blaze powder. For this reason, I'd like to ask whether it would be possible to add a config option in order to nerf the cauldron's potion output so it makes a single potion per set of ingredients instead of 3, like the brewing stand.

In the lat re st version, it makes two options per ingredient


ThaliCore: better error description

If a peer is not found in the list of available peers, an illegalPeerID error is thrown, it's the same error description for malformed peerIDs and it's not appropriate in this case.
https://github.com/thaliproject/thali-ios/blob/e5c34a5aeaa442ce0ebdb20102aa2eb404c01437/ThaliCore/MultipeerConnectivity/Browser.swift#L154

Fixed https://github.com/thaliproject/thali-ios/commit/f3a4038c4f53f20fb4045170dc06c6e1791dd8df


feat: added draft for a summarizer of the chat history

Currently, the ChatEngine implementations always send all messages to the LLM. If the chat history is too large, this approach quickly exceeds the maximum token size.
This PR proposes to extract the chat history (the array of ChatMessage) into its own ChatHistory interface.
There are two implementations: SimpleChatHistory which behaves like the existing chat history and
SummaryChatHistory which summarizes the chat history.

Note: This is just a draft PR to discuss the design changes, SummaryChatHistory is currently triggering the summary process each time a new message is added. If the design changes are okay, the next step is to define what are good conditions to trigger the summary process.

Thanks for the PR. This looks good. We probably want to call this Memory to align with Python but we can do it in another PR.

@yisding Thanks for merging! What about the open TODOs in this PR? Wanna discuss them privately? You can drop me an email<EMAIL_ADDRESS>


Frontend: Support relative paths site wide

To deploy using URL path routing, the entire app will need to be able to run out of any root directory (such as /app/). It is currently wired up with what appears to be a number of absolute links in various files which prevents it from running in a relative root.
Acceptance Requirements:
Verify site can be deployed and run entirely from any subdirectory (such as /dev/test/app)

Easiest way to test this in Azure:

Set up Azure CLI if you don't have it set up yet.
Run npm run deploy-azure-dev
See if this works: https://cdc.simplereport.org/dev/app
Run npm run deploy-azure-prod
See if this works: https://cdc.simplereort.org/app

I'll give this one a shot, and when I fail, I pass it along!

This was fixed by adding some environment variables to the package.json for the build scripts.


After Issue #300 Is Addressed, Move TestInetEndPoint from noinst_PROGRAMS Back to check_PROGRAMS

After GitHub issue #300 is addressed, move the Inet layer unit and functional test, TestInetEndPoint from noinst_PROGRAMS back to check_PROGRAMS in src/inet/tests/Makefile.am.

@yunhanw-google, any updates on this?

This has been deprecated through the deprecation of autotools-based builds and has been resolved in the GN-based build.


Looking for Help : Trying to use v4l2src instead of videotestsrc

Hi, i'm a student on an internship, trying to implement a live stream with webRTC. The recent update of Gstreamer head me to this API and Demo.
I'm a new be on WebRTC and this Gstreamer API for WebRTC.
So here is my problem. When i use the "https://webrtc.nirbheek.in/" + the demo everything work fine i'm able to watch the ball moving. I was also able to hear the sound ! But i have disable it :)
My problem is "switching from videotestsrc pattern = ball. to v4l2src isn't working" [The video stream doesn't show in the  HTML5 ]  I have looked at http://blog.nirbheek.in/2018/02/gstreamer-webrtc.html But my low skill on C language is slowing me.
And it's a bit weird because JUST changing videotestsrc to v4l2src doesn't show any error :/
I supposed it's a SDP problem. But i have any clue ! And i also supposed that you have already tryied to replace this by a webcam =)
Thank you for reading my post ! I hope you can help me =)
P.S I have read : http://blog.nirbheek.in/2018/02/gstreamer-webrtc.html  and the link it shares

Ok, i have invistigated and it's seems this pipeline isn't working for me :
gst-launch-1.0 v4l2src ! queue ! vp8enc ! rtpvp8pay !
application/x-rtp,media=video,encoding-name=VP8,payload=96 !
webrtcbin name=sendrecv
The error is
GstPipeline:pipeline0/GstV4l2Src:v4l2src0 : Internal data stream error
streaming stopped, reason not-negotiated (-4)
So i have invistigated the caps. Everythings look fine the compatibility beetween the elements of the pipeline seems good.
The good point is it's "just" a gstreamer problem.

Try adding a videoconvert element after v4l2src.

It's working now ! Still lot of bad things "low framerate don't know why" But it's work !!
Thank you ystreet

Try vp8enc deadline=1

Yeah, thank you it's better now it could improve but that "good".
Thank you tp-m


How to fix “App Already Bootstrapped with this Element”?

I am initializing and opening a model from GWT using $wnd.angular.bootstrap($doc, ['fmEventLogApp']);
After closing the model, when I try to open the model again, it is trying to reinitialize the model and throwing an error as "uncaught exception: com.google.gwt.event.shared.UmbrellaException: One or more exceptions caught, see full set in UmbrellaException#getCauses"
But when I see the actual error message, it says "App Already Bootstrapped with this Element".
How to solve this problem in case of a model window? Please help.

Batarang was the cause for me.

I would look and see if there any other dependancies you trying to load in your code. For me my issue was that I was trying to utilize Google API feed and it had a "document.load" type intitialization. I would also check and make sure that you only have one module per website. To prevent having multiple modules and causing unneeded load times you can easily place this inside of your main body tag.


Display of namespace mapping in restore object

Issue/Feature Description:
Why this issue to fixed / feature is needed(give scenarios or use cases):
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

With V.1.0 RC Restore API manages namespace mapping.
Please feel free to reopen the issue


Fix a broken regular expression in the docId unit-test (issue 13838, PR 13813 follow-up)

The current regular expression contains a typo, leading to intermittent test-failures for certain docIds; sorry about that!
Fixes #13838

/botio unittest

Thanks!


Update SAM so we can pass in the environment and other variables

Update the SAM template so that the environment code (dev, stg, prd) can be passed in when running builds/deploys.
Also ensure that all SSM parameters are setup for each env.

Got this working by setting parameter_overrides in thesamconfig.toml file and adding some parameters to the template.yaml that fetch values from SSM.


Provide top level image tag in values files

Problem: Currently image tags are duplicated throughout the values file.
Potential Solution: Provide a top-level image tag for defining the Cortex version.

(cleaning up older issues)
current chart utilizes a single container image setting


Update learning.md

Feel free to note improvements in wording, etc

I'll just aggregate a set of changes in a clone of this repo and then create a large PR later on

FYI Dark is leaving OCaml.


[PWEB-12817] Rails 5.1 Param Safety

About
This applies a Rails 5.1 PR from the Virtus gem into our fork, along a branch/1_0_5 which we will maintain for long running changes. Hopefully this all gets deprecated soon.
Once this is ready, I will point Babylon to this branch of the fork.
Related PRs
https://github.com/solnic/virtus/pull/388
Related JIRA
https://perchwell.atlassian.net/issues/PWEB-12817?jql=ORDER BY created DESC

Any thoughts on this before I merge and point Babylon to this fork? @jonmoniaci-perch @rhaus @dmartin-perchwell

Ideally we would never pass controller params deeper than maybe a service object. And therefore would never even have to fork this gem... But, unfortunately that's what Babylon engineers have done over time and this is a "single touch point" to ease the pain.

Agreed on so many levels.
Also add, "Babylon engineers should not let things go stale"... to the 10 Commandments of Perchwell Engineering we need.


Enable diasble Maximize and Minimize Buttons

resolves #49

@Cristian006 Hey, I think the release hosted at NPM still doesn't have these changes.


boards: stm32l496g: Minor fixes on dts and docs

This PR addresses the following issues:

LPUART 1 mapping was not correct
The sublists on the docs did not appear as expected

Codecov Report

Merging #11316 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11316   +/-   ##
=======================================
  Coverage   51.55%   51.55%
=======================================
  Files         216      216
  Lines       27665    27665
  Branches     6937     6937
=======================================
  Hits        14263    14263
  Misses      10653    10653
  Partials     2749     2749

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0670ba6...66ef9ac. Read the comment docs.

recheck

@erwango It seems that kernel timer api fails one check. It's strange, since my change seems trivial.

recheck

@gon1332

@erwango It seems that kernel timer api fails one check. It's strange, since my change seems trivial.

Yeah, I don't know exactly why you'd be the only one impacted.
Can you rebase your change and push again?


Provide consistency for inspecting Docker SwarmKit services and tasks

Docker Version: Docker version 1.12.0-rc3, build 91e29e8, experimental
OS: Windows 10.0.10586
There's a UX inconsistency in the inspect command, pertaining to Docker SwarmKit services and tasks.

Inspecting a SwarmKit service requires: docker service inspect
Inspecting a task in a SwarmKit service requires: docker inspect task

There are other cases in Docker where this is inconsistent (eg. networking, images, containers), however this issue pertains specifically to SwarmKit services and tasks.
Proposed Design Fixes
Here are a few proposed design fixes:

Move docker service inspect to docker inspect service
Create a task root context, so we would do: docker task inspect
Create a task context under service, so we would do: docker service task inspect

Cheers,
Trevor Sullivan
Microsoft MVP: Cloud & Data Center Management
https://trevorsullivan.net
https://twitter.com/pcgeek86

@pcgeek86 thanks for the report.
This is related to https://github.com/docker/docker/issues/24150 and https://github.com/docker/docker/issues/24152 I think 👼

Sorry! I thought I searched well enough for duplicates. :angel: I'll go ahead and close this one.

thanks for testing, and reporting @pcgeek86 it's appreciated!


how can i use it in real time？

I wish to use it in real time,but i don't know how to do with it.

Hi, Have you succeeded in running it in real-time? As far as the readme tells and instructs, it takes time to train an audio to a sample face, and it is not real-time at all.


models(llama3): add llama3 to embedded models

Description
This PR adds llama3 to the embedded models.
I'm also prepping to move the gallery over here so it's easier to maintain.

cc @jimmykarily as he was interested in trying this locally


Reduced order models: AeroDisk and Simplified-ElastoDyn (SED)

This PR is NOT ready for merging.
Feature or improvement description
Two new modules are added for low fidelity modeling of aerodynamics and structure.  These modules are intended for use as very low fidelity turbines in a FAST.Farm simulation in order to speed up the overall simulation.  In such a use case, these might be placed in the front few rows of a FAST.Farm simulation where only the turbines in rows further back are of interest, but the wake effects from the leading turbines are needed.

AeroDisk -- This module provides a very simple disk actuator model for the aerodynamics as an alternative to AeroDyn 15 and AeroDyn 14.
Simplified-ElastoDyn (SED) -- This module provides a very simple 2 DOF elastic model that only includes yaw and generator speed.  This module is not compatible with SubDyn, HydroDyn, or any mooring codes.

Impacted areas of the software

glue code changes

new mesh mappings are introduced to map loads and motions from ADsk and SED to other modules
additional logic to accommodate the new modules
minor code restructuring as needed
checks to ensure SED and ADsk are not used with certain combinations that are not allowed

FAST.Farm changes

Minor updates to FAST_Wrapper to pass correct Cp and Ct values

Additional supporting information

Test results, if applicable
Three new OpenFAST test cases are added as modifications of the 5MW_Land_DLL_WTurb case:

5MW_Land_DLL_WTurb_SED -- SED instead of ED
5MW_Land_DLL_WTurb_ADsk -- AeroDisk module instead of AD15
5MW_Land_DLL_WTurb_ADsk_SED -- AeroDisk instead of AD15, and SED instead of ED

New module tests are also included for SED and ADsk.
To complete

[x] Verify correct SED and ADsk behaviour after merging dev
[x] Phase shift in GenPwr for 5MW_Land_DLL_WTurb_ADsk_SED case (possibly mesh issue in glue code?)
This was an input file issue
[x] SED + AD15 can result in tower strike event (possible mesh issue, or maybe setup -- not investigated yet)
This was a setup issue
[x] Disable blade flexibility in ElastoDyn when ADsk is used with ED
[x] Add VS build projects for ADsk and SED drivers
[x] Add a simple FAST.Farm case with a simplified turbine
[x] add OpenMP directive in AWAE module (high res)
[x] Add plots here illustrating comparison to 5MW_Land_DLL_WTurb case (AD15 + ED with controller)
[x] update api_change.rst

Figure 1: XY slice at hub-height with case TSinflow (two 5MW turbines, both with AeroDyn and ElastoDyn).

Figure 2: XY slice at hub-height with case TSinflowADskSED (the leading turbine from the TSinflow case is replaced with the reduced order model using AeroDisk and SED).  The results in the wake hitting turbine 2 is very similar resulting in loads on turbine 2 that are very similar to when the leading turbine uses the full AeroDyn + ElastoDyn model.


[DRAFT] Text selection overlaps in listview widgets

Steps to reproduce
Add a SelectableText() widget to a normal listview with a normal texts and select any word or anything.
Now that selection handle widgets appears and now if you scroll up or down you will see that instead of text selections scroll with listview viewport, it over laps any top or bottom widgets.
Attaching video and image of the same.
Expected results
The expected result for this is to selection handle should scroll within listview view port only and does not overlaps the other widgets
Actual results
The selection handles overlaps the top and bottom widgets.
Code sample
Code sample
[Paste your code here]

Screenshots or Video
No response
Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Thanks for the report. SelectableText is using EditableText internally (same to TextField). There are similar issues at https://github.com/flutter/flutter/issues/59229, https://github.com/flutter/flutter/issues/13182. I will close this issue in favor of these issues. Please follow up on them for updates.


Use embassy-executor instead of nostd_async

For the needs of our examples, a much simpler executor would suffice. But it doesn't hurt to use a full-blown executor, the code doesn't become more complicated that way.

I'm happy with this but I'd like to see the use declarations kept in some kind of order. Probably:

core imports
Hal alias
Hal imports
imports from other crates

Yes, sorry, I didn't care about the placement but just left them where rust-analyzer put them.

I'm still concerned about the confusion between rp2*-hal and embassy's own embassy-rp. We already regularly get questions from people trying to mix the two. I'm afraid this would only increase this issue.
@jamesmunns told me about  https://mycelium.elizas.website/maitake/ a few months back and I think it'd be a good alternative candidate.
I haven't had the time to look into it though.

I'm still concerned about the confusion between rp2*-hal and embassy's own embassy-rp. We already regularly get questions from people trying to mix the two. I'm afraid this would only increase this issue.

rp2*-hal + embassy-executor looks like a very good combination, and I don't think we should discourage that because of possible confusion. We should however explain it in our documentation. Both that it's only one possible executor and there are others, and that rp2*-hal and embassy-rp are alternatives and should not be used at the same time.

@ithinuel, I had a quick look at maitake. It's definitely interesting, but it doesn't seem to provide a ready-made executor we could easily use in our examples. Therefore I'd still propose to go with embassy-executor, for now. That does not rule out a later switch to an alternative. Especially as the HAL itself doesn't depend on the executor at all. Only the examples need it.

I'm fine merging this and changing it later if we need to.
Another option is lilos but it currently doesn't support RISC-V.

Yes, let's not get paralyzed by too many choices. Merging this now, feel free to propose a better alternative any time.


Volume readonly icon too small

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
See https://github.com/dotnet/aspire/pull/5572
Expected Behavior
Icon should be:

16x16
Vertical middle aligned with text

Steps To Reproduce
View container with readonly volume in dashboard details view.
Exceptions (if any)
No response
.NET Version info
No response
Anything else?
No response

I tried it at 20 and 16 and felt both looked too large.

Icon didn't look properly aligned with text which is probably why it looked bad unless small. The state icon is 16x16:


String validation without rules causes Node to run out of memory

String validation without rules causes Node to run out of memory and crash (example below)

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

It would be good to for some error to be thrown eg:
String validation must have rules
or
Rules can not be empty array
Instead of running out of memory and crashing
Maybe just TSC error about empty array? (if that's possible)
Package version
@adonisjs/validator version 7.2.1
Node.js and npm version
Node v14.4.0
NPM 6.14.5
Sample Code (to reproduce the issue)
  public schema = schema.create({
    timeFrame: schema.string({}, [
      // rules.regex(/^(hour|day|week|month)$/),
    ]),
  })

Nvm, it was not default validator problem, it was custom provider problem


No share type provider for share type 1000

Shown when Einstein picks "Marie (guest)"

[Tue Oct 18 12:29:32.164950 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] ScienceMeshProviderFactory returns its ScienceMesh share provider
[Tue Oct 18 12:29:32.164994 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: Creating share!
[Tue Oct 18 12:29:32.165062 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: getSharedWith!
[Tue Oct 18 12:29:32.167564 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: Creating ScienceMesh share!
[Tue Oct 18 12:29:32.167644 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: addSentShareToDB!
[Tue Oct 18 12:29:32.177554 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: getRawShare!
[Tue Oct 18 12:29:32.178627 2022] [php7:notice] [pid 26] [client <IP_ADDRESS>:36136] SMSP: createShareObject!

Undefined property: OCA\\ScienceMesh\\ShareProvider\\ScienceMeshShareProvider::$cloudIdManager
I think this is where it should just be doing the call to reva. updated that.
Now:
[Tue Oct 18 12:50:35.659357 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] sending Share to reva
[Tue Oct 18 12:50:35.660858 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] share detail 'sourcePath': '/home/ljh/'
[Tue Oct 18 12:50:35.660883 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] share detail 'targetPath': '/ljh/'
[Tue Oct 18 12:50:35.660891 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] share detail 'type': 'dir'
[Tue Oct 18 12:50:35.660897 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] share detail 'recipientUsername': ''
[Tue Oct 18 12:50:35.660904 2022] [php7:notice] [pid 9] [client <IP_ADDRESS>:48776] share detail 'recipientHost': ''

it's now actually calling the reva client but obviously getting a Missing recipientHost exception.

Done


Establish build / publish pipeline

The tooling in this repo is configured for a crossplaneio stack release, which is opinionated about using tools such as Jenkins and Sonar. It will need to be updated with any testing / publishing tools that are suitable for Packet.
cc @jmarhee @jasmingacic

Thanks, noted! We're currently discussing this; Drone is, currently, our (Packet's) preferred (but not the only one in-use) solution, but Jenkins is absolutely on the table, and seems sensible to me (and I believe @jasmingacic concurred) to keep consistent with the other stacks, if at all possible. I'll keep you updated.

@jmarhee If that's the case then let's proceed with Jenkins?

v0.0.2 included the common Crossplane Jenkinsfile, Makefile, and build sub-module, but this has not been wired up to a Jenkins instance.
That said, I'm thinking Drone or Github Workflows (perhaps with GoReleaser) may be a better fit for this project since it doesn't live under the https://github.com/crossplane org.

The manual process that I used in the last release was modeled after:
git tag -s v0.0.2
kubectl crossplane package build
kubectl crossplane package publish

I deviated a bit because the publish command expects the following to exist (and they don't):

https://hub.docker.com/r/packethost/crossplane-provider-packet-arm64
https://hub.docker.com/r/packethost/crossplane-provider-packet-amd64

I don't see why these extra repositories should be necessary, providers like provider-gcp combine the amd64 and arm64 images into a single repository.

I've been using GitHub Actions recently and I'm fairly confident we can take that approach, especially with https://github.com/docker/setup-buildx-action#about and https://github.com/displague/packet-actions-example

@displague let me know if I can provide any assistance as you get those set up :+1:

We now have a build pipeline in place, which includes E2E testing (building the provider and installing it in a Kind cluster).
We do not create Equinix Metal infrastructure with this E2E testing currently, I think the need for that can be determined in a new issue when the need arises.
What we will need to close out this issue is a release pipeline.  The release pipeline will need to produce images for multiple architectures (preferably as a single multi-arch image, not requiring multiple images).
I may run goreleaser by hand again so that we can get recent revisions published in Docker (/u/equinix) and the Upbound registry (also under the Equinix org).

My thrown together publishing command-line, for now, is:
ver=v0.0.4;
git tag -m $ver -s $ver
git push --tags origin $ver

for tag in $ver latest; do
  for img in "" "-controller"; do
    target=equinix/crossplane-provider-equinix-metal$img:$tag;
    for root in "" "registry.upbound.io/"; do
       docker tag equinix/crossplane-provider-equinix-metal$img-amd64:$ver $root$target;
       docker push $root$target;
    done;
  done;
done

Several of the new and existing upstream projects have adopted GitHub Actions:
https://github.com/crossplane-contrib/provider-in-cluster/tree/master/.github/workflows
These workflows look like they could be a direct drop-in, except for the expectations around Upbound and S3 creds secrets.

Now that this project is in the github.com/crossplane-contribs GH org, it is possible to take advantage of community publishing pipelines and credentials.
We'll need to figure out if the existing Docker images (equinix/crossplane-provider-equinix-metal and registry.upbound.io/equinix/provider-equinix-metal) will continue to be the primary images.

Closing for #69
Build pipeline is present in https://github.com/crossplane-contrib/provider-jet-equinix


Support load patterns for AMD, node, and the browser

https://github.com/umdjs/umd/blob/master/returnExports.js I believe.

This is old. Going to continue any discussion of module loading in https://github.com/jackbearheart/email-addresses/issues/43


CSS and JS are broken on meltano.com

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2785
Originally created by @DouweM on 2021-06-07 16:56:29

As reported by a user on Slack
Loading https://meltano.com/ gives two 404s:

https://meltano.com/assets/css/0.styles.906e5e8d.css
https://meltano.com/assets/js/app.6e6306c2.js

View 10 previous comments from the original issue on GitLab


希望增加 ajv 对 Schema 进行校验

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

http://drip-table.jd.com/drip-table/props/ajv 最新版已可用。


Automated cherry pick of #9450 on release-6.2

Automated cherry pick of #9450 on release-6.2
Cherry pick of #9450 on release-6.2.
/cc  @weblate
NONE

The tests are failing.

Yes, I wonder if this is because we did not cherry pick the last weblate PR :thinking:

The missing message is in the previours PR, here:
https://github.com/weblate/mattermost-webapp/blob/f2ba922c4cec14d3cd6ca9c1d40a4c71a070ee75/i18n/es.json#L694-L695

/update-branch

I don't know what the correct solution is, but if the previous PR needs to be cherry-picked too, that's fine to me.

/update-branch

@puerco @amyblais anything that we need to update here?

I'll backport the previous weblate PR to try to complete the stringset that is causing the test to fail.

OK, let's see if merging this one first fixes it:
https://github.com/mattermost/mattermost-webapp/pull/9468

OK, I've found the problem. It seems the branches have diverged and translations cannot be cherry-picked because master and release-6.2 require a different set of strings.
The translation string that is breaking the cherry-pick admin.data_retention.note.description exists in release-6.2:
https://github.com/mattermost/mattermost-webapp/blob/bedf9b58d4804b7de7a6c0fe508123fa265b3f77/components/admin_console/admin_definition.jsx#L5394
But it was removed in this commit to master:
https://github.com/mattermost/mattermost-webapp/commit/c54cc7b35b269ea0fd4d33114caf19d39f3aabdc#diff-128483fb9ca10b5b50926c114c9f7b76158c7520591249b993c7d4e8c1c4a051L5393
It seems the commit was never cherry-picked to the release branch. @hmhealey can this change be backported to release-6.2?

Yeah, that should be fine to cherry-pick over. The only functional change in it is the search text that changed to cause this conflict.

https://github.com/mattermost/mattermost-webapp/pull/9481

/update-branch

OK, that did the trick. Thanks a lot @hmhealey !!


No possibility to activate second LED on Meowbit

Describe the bug
It is possible to light LED2 in neowbit, but not LED1. There is only one Variable LED which means the second LED of the meowbit.
To Reproduce
Add Extension edge-connector
Expected behavior
There should be LED1 and LED2
Screenshots

No plans to address in the near future


Skip remaining field tests as soon as one of them fails

Currently, when we want to skip following tests for a field when one of its tests fails, we have to use skipWhen() multiple times like this:
import { create, test, enforce, skipWhen } from 'vest';
const suite = create('user_form', (data = {}) => {

  test('username', 'Username is required', () => {
    enforce(data.password).isNotEmpty();
  });

  skipWhen(suite.get().hasErrors('username'), () => {
    test('username', 'Username is weak', () => {
      enforce(data.password).longerThan(8);
    });
  });

  skipWhen(suite.get().hasErrors('username'), () => {
    test('username', 'Username is too long', () => {
      enforce(data.password).shorterThan(50);
    });
  });

  test('password', 'Password is required', () => {
    enforce(data.password).isNotEmpty();
  });

  skipWhen(suite.get().hasErrors('password'), () => {
    test('password', 'Password is weak', () => {
      enforce(data.password).longerThan(8);
    });
  });

  skipWhen(suite.get().hasErrors('password'), () => {
    test('password', 'Password is too long', () => {
      enforce(data.password).shorterThan(50);
    });
  });

});
export default suite;

It would be useful to have a less boilerplate way to do that.
Two solutions suggested here:
1°) A general purpose solution could be to have a function named like breakOn(condition, testCallback), where the condition would be evaluated after every test() execution in the testCallback.
For example :
import { create, test, enforce, skipWhen } from 'vest';
const suite = create('user_form', (data = {}) => {

  breakOn(suite.get().hasErrors('username'), () => {

    test('username', 'Username is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('username', 'Username is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

  breakOn(suite.get().hasErrors('password'), () => {

    test('password', 'Password is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('password', 'Password is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

});
export default suite;

Or to stop at the first error:
import { create, test, enforce, skipWhen } from 'vest';
const suite = create('user_form', (data = {}) => {

  breakOn(!suite.get().isValid(), () => {

    test('username', 'Username is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('username', 'Username is weak', () => {
      enforce(data.password).longerThan(8);
    });

    test('password', 'Password is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('password', 'Password is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

});
export default suite;

2°) Another alternative solution, based on features provided by most test frameworks, would be to have a beforeEach(callback) hook that could be used globally or in a test group. The callback would be called before each test, and if the returned value is falsy, the test is skipped.
For example:
import { create, test, enforce, skipWhen } from 'vest';
const suite = create('user_form', (data = {}) => {

  group('username tests', () => {

    // Executed before each test of this group
    beforeEach(() => !suite.get().hasErrors('username'));

    test('username', 'Username is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('username', 'Username is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

  group('password tests', () => {

    // Executed before each test of this group
    beforeEach(suite.get().hasErrors('password'), () => {

    test('password', 'Password is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('password', 'Password is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

});
export default suite;

Other example:
import { create, test, enforce, skipWhen } from 'vest';
const suite = create('user_form', (data = {}) => {

  // Executed globally before each test
  beforeEach(() => !suite.get().isValid())

  test('username', 'Username is required', () => {
    enforce(data.password).isNotEmpty();
  });

  test('username', 'Username is weak', () => {
    enforce(data.password).longerThan(8);
  });

  group('password tests', () => {

    test('password', 'Password is required', () => {
      enforce(data.password).isNotEmpty();
    });

    test('password', 'Password is weak', () => {
      enforce(data.password).longerThan(8);
    });

  });

});
export default suite;

Hi @gbcreation, thanks for the feedback and suggestions.
This correlates with a plan I have for adding an "eager" support, which is intended to behave similarly to the way you require:
const suite = create((data = {}) => {
	eager();

	test('username', 'username is required', () => {
		enforce(data.username).isNotBlank();
	});

	test('username', 'username is too short', () => {
		enforce(data.username).longerThan(2);
	});
});

Calling eager in this scenario would make it so that tests of the same name will be skipped if any of them already failed.
However, each of your approaches have their benefits, which I like.
breakOn
breakOn allows a general purpose condition stopping execution. Could be due to result of a test, or due to some other condition. This is pretty powerful, and can be used in variety of situations.
breakOn's drawbacks

The conditional is a boolean value, it cannot be re-evaluated at every run. Luckily this is easy enough to fix by using a function as the conditional:

breakOn(() => suite.get().hasErrors('password'), () => {
	test(/*...*/)
})

breakOn introduces another level of nesting for tests, when factoring in group, skipWhen and each it can get pretty deep. I'd like to avoid as much as I can adding APIs the nest tests unless it is really worth it (which I don't say it doesn't!).

beforeEach
This still needs some tweaking, I don's see there's a clear relationship between the return value of this function and the instruction to vest to break the current execution - this might make it harder for people to understand how it works. I do think, though, it can lead the way to a more general purpose beforeEach for performing pre-test actions.
It also adds a really nice touch because it can be added at any nesting level, without nesting more tests under it.

As it seems, each approach (including mine) has its own benefits and drawbacks. I'd like to take a couple of days to draft a few ideas, and share them here in this thread, because I obviously see the value such a solution would bring. In the meantime, I'll try to come up with a workaround you could use that would bridge that gap.

Yes, you're perfectly right! breakOn() must take a function as first parameter. Thanks for correcting me.

Regarding beforeEach(), the name is indeed confusing. Maybe something like shouldRunTest()?

Yes, this is better suited, for this scenario. I am thinking if this discussion will lead to some sort of a test interception api, excluding tests before and after their run, and maybe modifying their outputs.
While I'm still looking into it, I am wondering if this consumer-land approach might work for you:
import {create, test, enforce, skipWhen} from 'vest';

const suite = create((data = {}) => {
  const test = conditionalTest(() => suite.get().hasErrors('username'))

  test('username', 'username is required', () => {
    enforce(data.username).isNotEmpty()
  })

  test('username', 'username is too short', () => {
    enforce(data.username).longerThan(2)
  })
})

function conditionalTest(conditional) {
  return () => {
    skipWhen(conditional, () => {
      test(...args)
    })
  }
}

I tested it, and it seems to be able to do everything you need. It might give us some time to discuss the optimal solution and still not block you.

@gbcreation Here's a thought.
What if skipWhen could work both upwards and downwards:
When provided a callback, skipWhen skips whatever's in the callback. When a callback is not provided, it behaves as your suggested shouldRunTest - skips all the tests in the current scope.
I like it because it doesn't require adding new interfaces to Vest, but I dislike it because it makes the same API do two (similar, but) different things. I'll fiddle with it a bit more.

@gbcreation, not sure if you're still interested in this feature, but I will be soon adding the "eager" mode functionality #793, I believe your breakOn suggestion works in the "plugin" realm. I am researching the possibility of allowing consumers to "intervene" at certain points in the suite and maybe make alternative decisions.


Make sure .leojs file format has no state bits in file, and instead all saved in db.

When saving to a .leojs file, the expanded, marked, etc. bits should only be put in the db, like for standard .xml leo file.
They should be saved in, and pulled from, the db. Just like for regular .leo Files.
Also make sure it's the same in the original Leo itself !!

Fixed in devel with commit be45070976b977fd75a5f704af00927cf2b307d3


version: do updates on version

update the version to 2013-08-01
expose a way to choose the api version in userland

/cc @WesleyYue @dmcquay

To state what the importance of this commit/patch, in the best practices article:

Use the Latest API Version
The Amazon Product Advertising API makes frequent releases. Each release either adds functionality or increases the accuracy, speed, and stability of the Amazon Product Advertising API. Most releases do both

And you could check the latest version number of the product advertising API at this link.

Ping

Hey, thank you for the pull request. I'll update the documentation to reflect the added parameter.

Whoops accidentally closed the request before I merged it.

haha, my pleasure :)


JDBC Driver: Column type are flipped from Integer from BigInt

This was observed with the MySQL connector.
A column defined as an int(11), once read through Presto, comes back as JDBC Type -5 (BigInt).

This is expected, since the only integer type currently supported is bigint, so all integer types will be converted to that.

I'm going to close this for now since it is actually a Presto problem, not an issue with the JDBC driver. We have discussed adding smaller integer types and will likely do so in the future, at which we point we can support this in the MySQL connector (and then the JDBC driver will return the expected original type).


allow tag to be used in mbed import

Fix  for  IOTCORE-1104
Branching strategy is changing starting 5.12 for example.  mbed import currently doesn't allow the user to specify branches/tags. There was a check which explicitly restricting to import tags other than latest or tip  maybe there is some limitation.
This change will have minimal impact on user workflow they can continue using the same command

Example for branch mbed import https://github.com/ARMmbed/mbed-os-example-blinky#mbed-os-5.12 blinky-5-12 -vvv
Example for tag  mbed import https://github.com/ARMmbed/mbed-os-example-blinky#mbed-os-5.12.0-rc2 blinky-5-12-rc2 -vvv

@screamerbg can you please review it.
cc @theotherjimmy @bridadan @SenRamakri

Also as note, this affects what mbed add can accept as well. Part of the Mbed CLI goals is to always create a reproducible build/source state. However, since branches (and technically tags as well) can "move", we want to be sure that when you invoke mbed add with a branch or tag that the actual commit is written to the .lib file. This way the existing "reproducible build" functionality is preserved while still enabling the behavior requested in this issue.
We tested this locally and this is the behavior that we saw, so that behavior still seems to be preserved!

I did a bit more testing, and there is a change that this introduces. This allows existing .lib files in programs to be able to specify branches and tags instead of just commits, which is a change in behavior. I'd say this behavior change is outside the scope of this PR.

This is a generic change which allows the user to provide tags/branches across. if the user wants to point a .lib to a branch/tag he/she should have the flexibility to do so on the same lines of mbed import  and mbed add. This behavior change/ feature addition is in line with the requirement where the user should have the flexibility to provide branches/tags.
I also thought of "reproducible build" part but all the bets of off when we allow mbed import  and mbed add to specify branches.

Example for tag mbed import https://github.com/ARMmbed/mbed-os-example-blinky#mbed-os-5.12.0-rc2 blinky-5-12-rc2 -vvv

What is the blinky-5-12-rc2 here? I would expect to only have to specify one tag ?

What is the blinky-5-12-rc2 here? I would expect to only have to specify one tag ?

blinky-5-12-rc2 is optional positional arguments specifying the destination name where we want to import the project.
C:\>mbed import --help
usage: mbed import [-h] [-I] [--depth [DEPTH]] [--protocol [PROTOCOL]]
                   [--insecure] [--offline] [--no-requirements] [-v] [-vv]
                   url [path]
Imports mbed program and its dependencies from a source control based URL
(GitHub, Bitbucket, mbed.org) into the current directory or specified
path.
Use "mbed add <URL>" to add a library into an existing program.

positional arguments:
  url                   URL of the program
  path                  Destination name or path. Default: current directory.

I did a bit more testing, and there is a change that this introduces. This allows existing .lib files in programs to be able to specify branches and tags instead of just commits, which is a change in behavior. I'd say this behavior change is outside the scope of this PR.

The existing behavior with the error was removed in this PR, so perhaps the error can just be moved to when reading .lib files?

The behavior of what .libs can have is not documented alteast https://os.mbed.com/docs/mbed-os/v5.11/tools/working-with-mbed-cli.html or in the help text. Some background can be found in  https://github.com/ARMmbed/mbed-cli/issues/224 thanks @bridadan for providing the issue.

@bridadan have made suggested changes can you re-review. if a named branch is added in .lib it will error. Its inline with current behavior have made the error message more verbose than before.
[mbed] Working path "/home/arm/delthis2/mbed-os-example-blinky" (program)
[mbed] ERROR: named branches not allowed in .lib, offending lib is sd-driver.lib


USB + Bluetooth + upgrade to Android 14 SDK

This is not compiling yet, because I can't find a way to integrate the AAR files

I opened this against the wrong repo, specially given it's a WIP. This is the correct PR: https://github.com/ehungry/cordova-starprnt/pull/1/files, which at some point will be integrated to #62.


gender inclusive language

change "him" to "them"

@emberstevens : Thanks for your contribution! The author, @jeevansd, has been notified to review your proposed change.


[AutoPR storage/resource-manager] Add storage/resource-manager/readme.typescript.md

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4021

(message created by the CI based on PR content)

Typescript


onChangeText not working on Input

"react-native": "0.41.1"
"native-base": "^2.0.1"
React Native TextInput has method onChangeText, example:
<TextInput
    onChangeText={(text) => {this.setState({text}); }}
    value={this.state.text}
/>

From docs Native base Input is React Native's TextInput implementation, but when adding onChangeText to Input it's not working, example:
<Input
    onChangeText={(text) => {this.setState({text}); }}
    value={this.state.text}
/>

I'm testing it on IOS simulator on Mac OSX El Capitan.

Seems to work fine. Please attach a sample of your use case.

Have same issue.
Not work:
<Item floatingLabel>
    <Input placeholder="Token" onChangeText={console.log} value={this.state.token} />
</Item>

Work:
<Item>
    <Input placeholder="Token" onChangeText={console.log} value={this.state.token} />
</Item>

Difference in floatingLabel attribute. I don't know why.

cc @shivrajkumar

@sankhadeeproy007 I was testing also with floatingLabel and scenario was exactly same as your uploaded  gif, except it was not logging anything.

Yes, it'll be fixed with the next update.

Find one bug also, refs to other component doesn't work:
Here is my code:
<Form style={ Styles.login_form }>                                 <Item>                                     Uporabniško ime                                     <Input                                         autoCapitalize="none"                                         onChangeText={ (text) => this.setState({ UserName: text }) }                                         onSubmitEditing={ (event) => {                                             this.refs.Password.focus();                                         }}                                     />                                 </Item>                                 <Item>                                     Geslo                                     <Input                                         secureTextEntry={ true }                                         autoCapitalize="none"                                         onChangeText={ (text) => this.setState({ Password: text }) }                                         ref={'Password'}                                         onSubmitEditing={ (event) => {                                             this.onPressButton();                                         }}                                     />                                 </Item>                                 <Button style={ Styles.login_button } onPress={ () => this.onPressButton() } light block><Text>Prijava</Text></Button>                             </Form>
Here is error which i get after press submit button in UserName field:
undefined is not a function (evaluating '_this3.refs.Password.focus()')

Replace this.refs.Password.focus(); by this.refs._root.Password.focus();

Still same error

Is that the case for floating label? Can you try with regular label and check?

Console.log gives my undefined for this.refs._root.
I am using  without floating label just normal input
<Item inlineLabel>                                     Uporabniško ime                                     <Input                                         autoCapitalize="none"                                         onChangeText={ (text) => this.setState({ UserName: text }) }                                         onSubmitEditing={ (event) => {                                             this.refs._root.Password.focus();                                         }}                                     />                                 </Item>

@peter1a Upgade "native-base" to latest version i.e, "2.0.5".
That should solve your issue

Already have<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Fixed with v2.0.6

There is still problem with Refs, works perfect when using TextView.

Yes i have the same issue :/ !

@sankhadeeproy007 Reopened because 2 people say that it is not fixed. Let's check this.

It's actually a different issue. The one with refs.

@peter1a this.refs.Password._root.focus() should work

Works, tnx!

Still not working on 2.2.0

Second what EdwardNelson said, however with 2.3.0 having the same problem.

can i get the name of tool on the video?, developer's tool .....

@EdwardNelson Finding same issue yet?

@PineLover Thats licecap

onChangeText is working fine.

hi,
i am new to react native,  when using onChangeText with  i can able to type, but text not showing in input box.
`

<Input
onChangeText= { term => this.setState({ term })}
value={this.state.term}
/>

<Button
onPress={() => console.log(this.state.term)}
>
Search

  </View>`


build: initial test attempts

this will not work , I mean the test works locally but it is not generating traces
 PASS  src/e2e.test.js
  App.js
    ✓ Should click in the button (124 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.834 s, estimated 1 s
Ran all test suites.

These kind of headless browser test are not loading the tracing.js file.


ISPN-13454 Ickle DELETE should not allow usage of Query.startOffset/maxResults

also prevent use of projections with Query.entryIterator() because
projecting anything other than key and value would work against the
purpose of entryIterator
use proper i18n for some newly added exceptions
prefer throwing CacheException in case of api misusage instead of other less specific RuntimeExceptions

https://issues.redhat.com/browse/ISPN-13454

CI failures are not related.
This needs to be backported to 13.0.x also. Changes are trivial so should be very low risk.

Merged, thanks


Improve JSONDecodingError

On client devices most JSON decoding errors will simply be "give up" types of cases.  But some applications might want to log the error and report it back to a server via some metrics/usage channel.
In server uses, being able to get more details about bad inputs from clients will likely help debug the clients as well as for better server side logging to help detect DoS attacks vs. bad clients.
So…
Currently JSONDecodingError provides no real context of what went wrong.  Some of them can easily include the sub part of the JSON that was bad (.malformedDuration, .malformedTimestamp, .unrecognizedEnumValue).  In almost all cases, also including a line number/column number (or atleast offset into the blob) being parsed would likely help.

Is this issue still open? and do you want help with it?

Yes, still open.  Adding associated values for the additional context is what would be useful.

Okay, I’ll work on it during the weekend 😁

main has gotten the infrastructure for a new error model that won't be api breaking, so new errors can have more details. However moving existing errors to that new model was counted as api breaking. So I'm closing this off as we won't actually evolve JSONDecodingError, but at some future point with 2.0 work, the existing errors could be given more context like this.


Fix Deprecated Devise Test

When running the test suite I get the following warning:
[Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/bills_controller_spec.rb:3)
DEPRECATION WARNING:           [Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/graphs_controller_spec.rb:3)
DEPRECATION WARNING:           [Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/teams_controller_spec.rb:3)
DEPRECATION WARNING:           [Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/units_controller_spec.rb:3)
DEPRECATION WARNING:           [Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/user_buildings_controller_spec.rb:3)
DEPRECATION WARNING:           [Devise] including `Devise::TestHelpers` is deprecated and will be removed from Devise.
          For controller tests, please include `Devise::Test::ControllerHelpers` instead.
 (called from <top (required)> at /Users/mzagaja/GitHub/cambridge_energy_app/spec/controllers/users_controller_spec.rb:3)

Actually never mind, this appears to have been fixed in #242.


German data added

This change is

"Bulk-Deletion" isnt really translated and i think you could replace "DM" with something more german like "Privatnachrichten"

"Bulk-Deletion" isnt really translated and i think you could replace "DM" with something more german like "Privatnachrichten"

Fixxed

Isn't this a bit deceptive to offer a description in german but the whole application is in english?
Unfortunately I don't have the resources to maintain multiple languages in this project. And then I have no way of supporting issues and discussions in languages other than english. I can barely reserve the time to, read, tag, reply, and work on issues already...


DRAFT:minor improvements

Continuing as discussed. For now:

add spaces between parameters in method declaration (readability)

More to come, hence "draft".

Yuck, all that JavaScript overload: Github won't let me set "draft", the JS fails. So please let's stick with the prefix – I'm afraid if you set it to draft I cannot finalize…

No worry,

This pull request is still a work in progress
Draft pull requests cannot be merged.

let's me know when it's ready for Merge.
Thanks.

Ugh – no I'm curious: did you make it draft? Or did the "DRAFT:" prefix do? Or did the button work with a delay? :thinking:

https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests
Preview button;

Thanks @BaseMax – if you create a normal pull request, there's also a link to convert it to draft next to "Reviewers", which didn't seem to work for me (no reaction) – so I assumed you might have turned the key. Nevermind, in the end I'll try to remove the "DRAFT:" prefix and see what happens. Somewhere must be a way to remove the draft status.
OK, another commit was added. I've fixed parseCategories() (which was now missing the array) to parsing available categories directly from play, using the page of GMail (which hopefully won't disappear anytime soon), and added PHPDoc to the methods. Your header at the start of the file doesn't really meet PHPDoc specifications (the @keys you used there are not valid). I've left that for now, pending your review. Let me know if I can turn them to "valid keys" as well (will be necessary if you want to use an API generator, which otherwise might complain).
In the meantime, I maybe check for the "summary iterator" (if my time permits).

Okay, so send PR and I will merge it.
We can try iterator later in next PR. @IzzySoft

Thanks, I change status of PR from draft to normal. then merged.

Your header at the start of the file doesn't really meet PHPDoc specifications

What's your suggest?
I have follow this structure in hundreds of tanks.
But maybe your suggestion is also interesting and will make me follow this in the next repositories too.
Regards,

Your comment (PHPDoc) was excellent.
I liked. :+1:

Thanks, I change status of PR from draft to normal. then merged.

Ugh… The idea was that I can tell when I'm ready. Now I again have commits locally I can no longer push to this PR. Can we, with future PRs, organize this? :wink:

Your header at the start of the file doesn't really meet PHPDoc specifications
What's your suggest? I have follow this structure in hundreds of tanks.

Which is why I now left this untouched.

But maybe your suggestion is also interesting and will make me follow this in the next repositories too.

Let me see what it would be to meet the specs:
/** Crawl information of a specific application in the Google Play Store
 * @class     GooglePlay
 * @version   0.3
 * @author    Max & Izzy
 * @copyright MIT https://github.com/BaseMax/GooglePlayWebServiceAPI/blob/master/LICENSE
 * @date      2020-10-19, 2020-10-25, 2020-10-29, 2020-10-30, 2020-12-05, 2020-12-06
 * @webpage   repository https://github.com/BaseMax/GooglePlayWebServiceAPI
 **/

Though the @date tag seems to expect a single date. Not sure how useful the list of dates is, and to what; if you wanted, we could turn that into a history:
@log 2020-10-19 initial version
@log 2020-10-25 something has changed
@log 2020-10-29 something was added

etc. Depending on the doc tool to be used, list of available tags differs. I'd need to find the reference for what I use for ages, but here are some example references:

phpDocumentator. According to its changelog it was last updated 2007? Yuck.
I have been using phpDocGen for about 20 years (development unfortunately stopped after 2014), which can be downloaded here. No online reference available, but I could copy it from my docs here if you wish. This is what I've used here, and also in the file.

Maybe better switch to something that's still supported, if I only could find it…

My review:

I had just done that (and being on it, also changed existing $var="value" to $var = "value" etc). But it wasn't yet pushed. Will see if it has conflicts after pulling updates.

PS: Here's the list of tags used with phpDocGen:
@attribute [public|protected|private] <type> <name>
@author <name>
@block <unsplittable_text>
@brief <comment>
@bug [fixed] <comment>
@class <name>
@constant <type> <name>
@constructor <name>
@copyright <name>
@date <date>
@deprecated <text>
@extends <class name>
@inherited
@function <name>
@global <name>
@link <name> <comment> (link 2 item/doc)
@log <date> <comment> (ChangeLog)
@method [static] [public|protected|private] <name>
@package <name>
@param [optional] [reference|ref] <type> <name> <comment> (ref: passed by ref)
@private
@protected
@public
@return [reference|ref] [<type>] [<comment>]
@see <comment>
@since <comment>
@static
@todo <comment>
@use <name> (uses global var)
@variable <type> <name>
@verbatim (all current comment will be <pre>)
@version <comment>
@webmodule <html_path>
@webpage [path] <page>

Got it.
Thanks for prepare this list.

organize this?

Sure, Sorry for this.
I understand that others respond late to the Pull Request.
I do not want anyone like me to feel this way in the past.
I did not mean it )

Hehe… No finger-pointing, no. Just wanted to make sure our communication didn't fail :laughing:
OK, next PR on its way. Do you want me to update the header as well (as shown above)? If so, shall I convert the "date list" into a log? Though that would require some digging to attach the right comments on what has changed. Further, if one really needed a log, there's the commit history. So we could stick with the @date line as-is – and decide when some DocGen complains.

:)
Yes, please change header comment.
If we had to keep just one date, we can keep date created this repository.
Thanks
We can add logs, But I not remember date of old logs.
Maybe we can get help from this:
https://github.com/BaseMax/GooglePlayWebServiceAPI/commits/main

No prob. We can use the @log and limit it to 2 entries: created, and last updated.
Btw: expect some interesting new fields in the next PR :smile:


toFraction() behavior

Best described by example
http://jsfiddle.net/a6t784am/2/
.toFraction() seems to land on a denominator based around the DECIMAL_PLACES config variable when a MaxD is not supplied. A MaxD in range of a known denominator give the correct solution.

The behaviour is as expected.
When you call toFraction, you are calling it on the number 3.08218318695106649937, not on the rational number 4913/1594 (which cannot be stored as a BigNumber as it has a non-terminating decimal expansion).
To clarify:
var BN = BigNumber;
BN.config(20);
var n = BN(4913).div(1594);

n.toString();    // 3.08218318695106649937
n.toFraction()    // [ "308218318695106649937", "100000000000000000000" ]

BN.config(10);
n = BN(4913).div(1594);

n.toString();    // 3.082183187
n.toFraction()    // [ "3082183187", "1000000000" ]

Do you follow?

Thanks for the quick response Mike. I understand how it applies now. I'll have to track the rational expression separately.
Cheers,
-Thomas


Dependency issues even with 0.0.111 version

"npm install" is working fine without langchain. This is happening for past 3-5 days.
When I add langchain - 0.0.111 it is breaking. This was working fine earlier.
I even tried with the latest version 0.0.148 still the same issue. Please help me out. Thanks!

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/cohere-ai
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/chromadb
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/langchain
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/langchain
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!

Hey @ghostenginesio, can you try running with npm install --legacy-peer-deps for now? We'll aim to resolve this and push a release shortly.

Actually, just tried from a fresh project and it looked like npm install -S langchain worked for me. Can you try clearing any build caches?

Works fine now. Thanks!


Add missing decoder types: transfer, cancel order, ...

https://github.com/binance-chain/javascript-sdk/blob/a089e04aa3299ebb9719e44380a1cd694a7829c4/src/decoder/types.js#L1
The type choices in this file are very random and this should be improved.

We only add rpc related types before

You can get these over RPC (tx, tx_search, ...)

So it's time to add all the stuffs

+1 on this. We had to write our own. Would much rather use the officially supported one:
https://github.com/ferrumnet/bnb-tx-decoder


Better documentation on the use of kpt pkg sync set

The documentation of sync doesn't contain any links to the description of the sync set command. This adds this link and adds some clarification on how to use the sync set command.
Ref #308
@pwittrock

plz resolve conflicts

Resolved conflict


acceptance-tests: bump to BOSH release 0.0.2

Description
The bumps the cf-acceptance-tests-release to 0.0.2.
Motivation and Context
This adds the cf tail plugin, which makes many tests pass.
How Has This Been Tested?
Run CATS locally.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Got the following, which is expected at this point:
Summarizing 18 Failures:

[Fail] [apps] Uploading and Downloading droplets [It] Users can manage droplet bits for an app
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/apps/droplet_uploading_and_downloading.go:76

[Fail] [v3] droplet features [BeforeEach] copying a droplet can copy a droplet
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] droplet features [BeforeEach] copying a droplet creates an audit.app.droplet.create event for the copied droplet
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] process [BeforeEach] terminating an instance /v3/apps/:guid/processes/:type/instances/:index restarts the instance
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] process [BeforeEach] terminating an instance /v3/processes/:guid/instances/:index restarts the instance
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] buildpack With a single buildpack app [BeforeEach] Stages with a user specified admin buildpack
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] buildpack With a single buildpack app [BeforeEach] Downloads the correct user specified git buildpack
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] buildpack With a single buildpack app [BeforeEach] uses buildpack cache for staging
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] buildpack With a multi buildpack app [BeforeEach] Stages with multiple admin buildpacks
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] package features with a valid package [BeforeEach] can copy package bits to another app and download the package
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] package features when the package contains files in unwriteable directories [BeforeEach] can still stage the package
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] Healthcheck [BeforeEach] when the healthcheck is set to process starts up successfully
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] Healthcheck [BeforeEach] when the healthcheck is set to port starts up successfully
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] Healthcheck [BeforeEach] when the healthcheck is set to http starts up successfully
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] v3 buildpack app lifecycle with a ruby_buildpack [BeforeEach] can run apps with processes from the Procfile
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [v3] v3 buildpack app lifecycle with a java_buildpack [BeforeEach] can run spring apps
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers/v3.go:469

[Fail] [apps] loggregator cf logs --recent [It] makes loggregator buffer and dump log messages
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/apps/loggregator.go:93

[Fail] [apps] Environment Variables Groups Staging environment variable groups [It] Applies environment variables while staging apps
/var/vcap/packages/acceptance-tests/src/github.com/cloudfoundry/cf-acceptance-tests/apps/environment_variables_group.go:135

Ran 84 of 214 Specs in 3585.844 seconds
FAIL! -- 66 Passed | 18 Failed | 1 Pending | 129 Skipped
--- FAIL: TestCATS (3587.73s)
FAIL

Ginkgo ran 1 suite in 59m55.075058561s
Test Suite Failed


Kwxm/test mpj fixpoint sharing

This adds some serialisation figures based on a version of the PlutusTx compiler which shares the fixpoint combunator.  See docs/plutus-core/Merklisation/FixpontSharing.md .

Looks like it gets only very marginally worse. I'm somewhat baffled that it's worse at all - I guess we add some type signatures, but the comparison here erases them.
I think it's still worth having since smaller uncompressed code is good for prior processing steps.


Player

Hey, It's really good. This is probably the only app that allows me to select, copy, and perform other actions with text. And it has a great design. But there is one problem. Player. Please add a player. I learn the language by reading the lyrics, and it is important for me to be able to rewind and pause to listen a particular phrase again.
So far, your app isn't much better than just opening text on genius. But if you make a normal player that can be conveniently controlled, it will be the best that is available at the moment.

Hi, thank you for your interest in my project.
The goal of this app is to display the lyrics from the current playing song on Spotify. I do think it's better than "just opening text on genius" as it saves you the search (and can fetch other sites if your lyrics aren't on Genius).
Currently, I do not plan to include a custom Spotify player in the app as it's quite a lot of work and not the initial goal of the project. Controlling the music is up to the user and you may use whatever is at your disposal to do it easily.
I'm keeping this idea, maybe one day I'll include more content such as player, video links, etc :wink:


RFC: HLSA for CSS variables

I love the way GraphiQL uses hlsa as the standard for their CSS variables - this lets them blend colors and control alpha a lot more easily, and possibly do some automatic-contrasting.
E.g.:
body:not(.graphql-light) .graphiql-container {
  --color-primary: 338, 100%, 67%;
  --color-secondary: 243, 100%, 77%;
}

.cm-s-graphiql {
  color: hsla(var(--color-neutral),var(--alpha-tertiary));
}

Think about whether or not we can benefit from a design choice like this earlier on. I think it'd honestly make it easier to generate secondary palette colors for sure.

I ran into this again with some other frameworks, but they go the RGB route. Might be a bit more understandable for our team so I might lean that way instead.

Obsolete in beta.1. Theming is done via MUI and TSS


in roomword sample; in word class; import androidx.room.ColumnInfo; "can't resolve ColumnInfo

Make sure you've added the room dependency and synced the project


Add type traits for global attributes

Problem
#19112
To use the type traits for global attributes present in cluster-objects.h requires you to do so through the namespace of a specific cluster. This kind of runs counter to the fact the definition and type of a global attribute is independent of its inclusion in any given cluster.
Fix
Add type traits within the existing chip::app::Clusters::Globals::Attributes.

Closing in favor of #19128


Fix: flaky golang-network sandbox

fix https://github.com/envoyproxy/envoy/issues/28543
func CreateUpstreamConn(addr string, filter api.UpstreamFilter) {
        // call envoy to async connect with the upstream addr
	h := uint64(uintptr(cgoAPI.UpstreamConnect(libraryID, addr)))

       // store the golang filter for later used by 'onPoolReady' or 'onPoolFailure'
       // if the async connecting is faster than cgo callback, it cannot find the golang filter so it will panic
	_ = UpstreamFilters.StoreFilter(h, filter)

the cgo callback from cgoAPI.UpstreamConnect may take times (depending on the golang runtime), if the async connecting with upstream returns faster then the cgo callback, then it will fail to get the golang filter and panic.
the solution is to store the golang filter earlier than the cgo call.

/retest

/retest

@doujiang24 @wangfakang @phlax PTAL, thanks


Build a test framework

According to @you06 , cases in tipocket are managed manually, a typical work flow is:
user create the cluster to test -> run test binary (tipocket) -> witness and check -> user teardown cluster
Obviously, the lifecycle and configuration of cluster is not managed in the case.  I propose to adopt ginkgo as the test framework and abstract common operations as lib, e.g. provision cluster, apply chaos.
Ideal work flow after this issue get resolved (persudo code):
ginkgo.BeforeEach(func() {
	chaos := NewChaosClient()
        tidbOps := NewTiDBOperationInterface()
})

ginkgo.Context("CDC: CDC should tolerant xxx chaos ", func() {
	instance := tidbOps.DeployCdcCluster(&CdcCluster{
               Source: &TiDBCluster{},
               Target: &MySQLTarget{},
         })
        chaos.PodKill(instance, &Config{Interval: "60s"})
        go func() {
              // case actions
        }()
        go func() {
             // case verifications
        }()
}

Finally run with:
ginkgo --untilItFails --focus "CDC"

@you06 PTAL and help at the person needs to be involved, thanks!

LGTM. Since the chaos operator focuses on making chaos, and tipocket on rand SQLs, doing test with them still require many manual works. We need a manager for the test jobs, which should control all tests in k8s including br/cdc/binlog/dm.
Related issues

https://github.com/pingcap/chaos-operator/issues/32

https://github.com/pingcap/chaos-operator/issues/33

https://github.com/pingcap/chaos-operator/issues/34

https://github.com/pingcap/chaos-operator/issues/35

@zhouqiang-cl, @cwen0, @YangKeao, @mapleFu, @5kbpers, @overvenus, @amyangfei PTAL

LGTM

Hopefully I will open a PR tomorrow

The test issues are called for setting up working groups. IMO, this test  framework would be a better working group topic.

It's a great work! But this week we still need to write binary for special week （;￣O￣）

It's a great work! But this week we still need to write binary for special week （;￣O￣）

For example?


Smooth the segment brush in a way that doesn't cause it to sometimes cut off part of the path

Right now we have 2 options

Segment brush has a million points and is hard to edit
Segment brush gets smoothing when you lift mouse, but smoothing sometimes destroys part of the path

If possible we want to write an improved smoothing algorithm.

I found a few instances where the "blob" seems to be getting smoothed too much which leads to irregular strokes.
Andrew

Timebox this ~1day


Update label_smooth_cn.rst

add label support float16.

close due to the following PR is merged:

#5642


*_visible method doesn't work as documented

Environment

Operating System (Mac / Windows / Ubuntu e.t.c.)

mac

What Gems / Versions you are using (Specifically site_prism and capybara)

site_prism 2.9
capybara 2.13.0

How you're interacting with the Framework (Cucumber Tests / RSpec Units / Minitest)

rspec

Browser/s Driver/s being used - with version numbers

webkit
Expected Behavior
According to the documentation here: https://github.com/natritmeyer/site_prism#methods-supporting-capybara-options I should be able to do this
class CreateJobPage < SitePrism::Page
  element :items_modal, '.modal'
end

...
@create_job_page.wait_until_items_modal_visible text: 'Job name'

Actual Behavior
NoMethodError:
       undefined method `zero?' for {:text=>"Job name"}:Hash
     # /Users/rra/.asdf/installs/ruby/2.3.4/lib/ruby/2.3.0/timeout.rb:74:in `timeout'

@rodrigovrm  - can you add the full stack trace please?

We require a full reproduction scenario to try diagnose this. These kind of tests are readily covered in both Unit Tests and Integration tests, so we'd need to understand how you are generating this issue


Transfer learning

Hi Team,
Amazing work. Thank you.
Is it possible to train on DocBank dataset and use custom dataset to do fine tuning or transfer learning?
Because we have limited custom dataset which is around 200 to 300 pdf documents. Is this data enough to train from scratch or is it possible to use DocBank trained model as base model?
Thank you

Hi, we haven't conducted these experiments but you can try it. Please report your results if you tried this experiment. Custom datasets try to collect more than ~1k, otherwise, it probably is not enough to train from scratch.

@Sharathmk99 : did you try transfer learning? did it work?

No i couldn't get time to try. Will update once i try.

@Sharathmk99 : sorry for asking you a silly question. Can you tell me what does B, N, T represents in the code(I am new to this NLP field)

@Sharathmk99 : sorry for asking you a silly question. Can you tell me what does B, N, T represents in the code(I am new to this NLP field)


Pause messages of type

Hi @schollii. I am interested to know whether it is possible to put a stop on messages being sent for a while. The idea is a follows:

A sends a message x
It is consumed by B, C, D, ..., H
Each of B, C, D, ... , H process their message, and send a message, each of which is consumed by A.
Upon receipt of each message, A publishes another message y(B), y(C), ..., which is consumed by other entities. Let's say each message y is of topic "Z" and the kwargs are a dictionary with say key1 = "AA" and key2 = "BB".

What I would like is that I prevent A from sending the messages y(B), Y(C), ... etc. until the "last" message is received from H.
The kind of thing I am imagining is:
with pub.withhold("Z", kwargs["key1"] == "AA", kwargs["key2"] == "BB"):
    pub.sendMessage(x)

pub.sendMessage("Z", **kwargs)

The reason for considering this idea is that each of the messages y generates redundant activity so that it needs only be sent once.
I understand that this process may go against the spirit of asynchronous messaging, but I feel it is an interesting pattern.

The main problem is that in a pub/sub architecture there is no builtin way for A to know which components receive the message, and even less so when it has received all the messages. The beauty of pubsub is decoupling, asynchronicity and fire-and-forget. What you are trying to do between A and recipients introduces a lot of coupling between the components, goes against pubsub. What you are describing is more like a message queue, but that's not even quite right.
So you need to revisit whether pubsub is the right architecture for your app, and if it is then you need to take a step back and challenge your idea that your approach is the only way, because it breaks pubsub design. You need to think about how you can design your messaging without these feedback loops. Your design will gain a lot from this.

Thanks for the prompt reply! I did expect your answer, and know you are right.  I will make some changes to handle these types of cases.
Note, however, in the suggestion above pub.withhold, it doens't have to know about A at all. It only needs to know what messages to stop publishing. But to be clear, I agree that my suggestion is against the spirit of such messaging.

OK cool I hope you find a good solution. I will close this issue.


Add TruFont.app v0.3.0

Thank you for the contribution. It needed some fixes, so they were made in 1f37d5958f3f195a6a08dccb857224a22ffedfab. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Android browser [Multiple select boxes] cannot remove the selected option

Multiple select boxes works fine on desktop (chrome, safari, firefox, IE). When I test on mobile device (Android browser), I managed to remove all the option after selected however the only option cannot be removed is the 2nd option - Hawaii, please refer to the https://select2.github.io/examples.html and run on mobile device (Android browser).
Android Version - 4.4.2

I just tested this out on the Android emulator (Thanks Sauce Labs!) and I was able to reproduce the issue. I can't reproduce it on Android Chrome in 5.0 or the stock browser in 4.2.
As you can see in the recording, I struggled to get to the event section to figure out what events were being triggered. My guess is that this is going to be the key to solving the issue, figuring out what events are being triggered (and which ones shouldn't be).

I can confirm this on android 4.4.2 stock browser.
No matter what you select first, when unselecting an item the first option gets selected. Practically, it becomes impossible to unselect the first option.

+1

For some reason, the android browser adds the first option as selected. Fortunately, this first option is not present in the "unselecting" event, so we can do this as a workaround (which also closes keyboard on mobile):
```
$("#myautocompleter").on("select2:unselecting", function (e) {
$(this).data('predeleted', $(this).select2('data'));
});
$("#myautocompleter").on("select2:unselect", function (e) {
var new_data = [];
new_data$.each($(this).data('predeleted'), function (key, value) {
if (value['id'] != e.params.data.id) {
new_data.push(value['id']);
}
});
setTimeout(function() {
elem.select2('close');
elem.val([]).trigger("change");
elem.val(new_data).trigger("change");
}, 1);
});

I notice the same thing happening (release 4.0.3, using FireFox and Chrome desktop browsers, with multiple and tags enabled). No matter what options are selected or unselected, the first <option> of the <select> element is always marked as selected='selected', even if it is unselected and not shown in the tags area. So when the page posts back to the server, it always sees the first item as a selected choice.

@Loadmaster That sounds like a different issue, any chance you can break that out into a separate ticket?

@kevin-brown Yep, see #4406.


Can't use spliceSlot on arrayfield with m-f-v

When you call spliceSlot on an array field, it eventually tries to call destroy on the widget (and the field's sub-widgets if an object field). At a guess, that's here but for whatever reason (at a guess due to m-f-v taking over the actual DOM rendering) there is no element returned by this.getElementWrapper(), so the next line errors out.
This is currently stopping me from implementing a "remove pet" feature in ED.

Wasn't sure if this was mutt-forms or mutt-forms-vue, but being as the problem occurs when using mutt-forms-vuew, I figured I'd put it here. It's possible mutt-forms will have to actually include the fix, however.

Ahh I have managed to bypass the logic that does this by passing false to the second parameter of spliceSlot (updateWidget). I feel that this is still something of a hack and that m-f-v should either proxy spliceSlot and silently pass that false in for me, or it should otherwise be addressed, so I'll leave the issue open, but obviously you know the lib better than I do, so by all means close.

@alexrussell yeah you are right, it's not ideal right now. The is a bit of work underway to decouple the HTML widgets from Mutt, so mutt doesn't have this sort of problems when used with a different interface - like mfv.
Will leave open for now so we remember to address this specifically.


Update README.md

Remove locale form links to honor user's language preferences
Replace post-deployment steps with reference to public docs as single source of truth
Propose minor tweaks to section headings

Suggested changes to readme.md to be merged when the updated docs are published.

@lmasieri FYI

@nickrm101 the linked content is live. Feel free to merge at your convenience.


Full Support for Guilds

Support for Guild Routes were added in #15, only thing left is the actual functions themselfs which I'm gonna be doing.


Data on 2nd VCP

I've have an implementation of this with 2 virtual comms ports and a custom HID. I have the HID and 1 VCP working fine. The 2nd VCP only seems to be able to recieve data from the computer and sending fails with USBD always busy.
Has this been seen before / confirmed multiple VCPs work for tx and rx? Most likely my issue...

This is on an stmf401, which if I'm right only has 3 in and 3 out end points therefore with 2 vcp and 1 hid I've gone over?


tox command failing on x86_64 and arm64

I have been working on installing and testing flask-pymongo package for x86_64 and arm64 architectures on my local server. While testing this package using tox –e py38 I am getting the below error. It would be really helpful if you could share some pointers on it.
AssertionError: too many tox-docker mongo port env vars (found 0)
Test output at x86_64: test_flaskpymongo_x86_py38.txt
Test output at arm64: test_flaskpymongo_arm64_py38.txt

@dcrosta Is there any update for the above issue?

There's no tox environment py38. Flask-PyMongo uses tox a little differently, specifically, it uses tox to manage the testing matrix of pymongo, flask, and mongodb versions (via tox-docker). Your tests will run in whatever python you invoke tox with. Check tox -l for a list of environments we test with.
(In CI, we test will all supported Python versions, as well, but not typically on local machines, at least I haven't been).

E ImportError: cannot import name 'json' from 'itsdangerous'

This is resolved in flask > 1.1.4, I guess flask 1.0 is abandoned at this point. I'll accept a pull request to remove it from the test matrix

E ImportError: cannot import name 'soft_unicode' from 'markupsafe'

This probably should be reported against Jinja, if they still support Jinja 2.x. If they don't, then we should remove Flask 1.1 from the test matrix as well.

AttributeError: 'TestenvConfig' object has no attribute '_docker_containers'

I don't get this error in the official azure pipeline ... I don't know what you're configured differently. Probably it means that either the docker python module isn't installed or docker itself isn't installed or working.
Why are you trying to set up CI for flask-pymongo anyway?


Add module option in run_tests

Signed-off-by: feihujiang<EMAIL_ADDRESS>Usage:
./bin/run_tests [-m Module]
Options:
-h          print usage and exit
-m Module   only run tests of module, <core, validator, mktplace, bond, arcade>

@vaporos Could you please review this PR?  Running ./bin/run_tests totally costs too much time, this PR could run tests of specified module.

@vaporos I udpated this PR, please take a look.


Block chooser doesn't show enough options on initial view

Is your proposal related to a problem?
The block chooser consistently has a vertical scrollbar which makes choosing a block more difficult than it needs to be, as the user isn't aware of what is below the fold (unless they are very familiar with the system).
The search option that is shown at the top can significantly improve the speed of adding a block, however without having pre-existing knowledge of what the avaliable blocks are named, it's not great for new users of the system.
Existing example:

Describe the solution you'd like
With the above in mind, I'd suggest optimising the chooser to ensure that more blocks are avaliable without the need to scroll. Initial thoughts are:

Introducing multiple columns
Reducing the amount of space between items
Refining the category titles
Giving the items a more sensible order (Alphabetical?)
Reducing the h2-h5 options into a single heading, and relying on the formatting options within the RTE to apply h2-h5

I've attached some mockups illustrating how the suggested solutions could potentiallly work:
Single column that just makes better use of the space, meaning more items are displayed initially without the need to scroll:

Double column, which maximises even more so, without covering too much more of the RTE below:

On both versions I've removed the heading from the initial group of inline/formatting blocks, rationale being that users are typically familiar with these items (and if custom ones are added their training should cover these).
I've also moved to ordering the blocks within each group alphabetically, as this can aid findability when you're scanning a list. I appreciate that some editors may want to display their most used blocks first, however, I'm hoping that now more, if not all, blocks are displayed then alphabeticalising will be the logical way forward.

Figma: https://www.figma.com/file/h67EsVXdWsfu38WGGxWfpi/Wagtail-Design-System?node-id=9639%3A107556&t=gGBfzyg6Md6w5C3W-1


Loosen maven enforcer rules temporarily to permit use of AdoptOpenJDK builds

See https://jira.odpi.org/browse/EGERIA-2 for full description.
Temporarily loosening java version check to 1.8 instead of 1.8.0_151 to allow openjdk builds to be used

Closing


UI Metrics: create local dev setup for Bonitoo folks

Background
For local cloud development, we have the ability to write metrics locally. That doesn't exist for local OSS development, so we should add it. That way, Bonitoo can add metrics calls to code we care about and test that it works locally while working under the assumption that it will work properly in prod. So what it writes locally should match what gets written in prod. If it's good locally, it'll be good in prod.
Acceptance Criteria

There is a simple process by which any developer can add metrics calls using the event method and have it write metrics to the local default bucket.

There is supporting documentation where applicable

closed with this repo being published: https://github.com/influxdata/oss-ui-metrics-proxy/


Chapter 10, SimpleButtonDemo Test Failed

testLetterAfterButtonClickIsB() test doesn't success.
It failed with below error log:
java.lang.AssertionError: Failed to assert the following: (Text + EditableText contains 'B' (ignoreCase: false))
The node is no longer in the tree, last known semantics:
Node #8 at (l=457.0, t=1075.0, r=624.0, b=1188.0)px
Role = 'Button'
Focused = 'false'
Text = '[A]'
Actions = [OnClick, RequestFocus, GetTextLayoutResult]
MergeDescendants = 'true'
Original selector: Text + EditableText contains 'A' (ignoreCase: false)

Hello. Thanks for opening this issue. I will have a look and return shortly.

Sincere apologies for taking so much time on this. Here is the fixed test case:
@Test
fun testLetterAfterButtonClickIsB() {
    rule.onNodeWithText("A")
        .performClick()
    rule.onNode(matcher = hasClickAction())
        .assert(hasText("B"))
}

hi, for anyone that saw @tkuenneth message late 😓 i created a alternative solution:
    @Test
    fun testLetterAfterButtonClickIsB() {
        val buttonUnderTest = rule.onNodeWithTag(TAG1)
        buttonUnderTest.assertTextEquals("A")
        buttonUnderTest.performClick()
        buttonUnderTest.assertTextEquals("B")
    }

and add modifier = Modifier.testTag(TAG1), to the button in main class.
I prefer this solution because proposed one won't work in case more nodes have click actions.


Duplication check for individuals in collections

#53

Codecov Report

Merging #56 (dbe28e9) into master (4557a4c) will increase coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   37.59%   37.70%   +0.10%
==========================================
  Files          11       11
  Lines        1149     1159      +10
  Branches       54       54
==========================================
+ Hits          432      437       +5
- Misses        663      668       +5
  Partials       54       54

Impacted Files
Coverage Δ

src/Poseidon/Utils.hs
11.76% <0.00%> (-0.74%)
:arrow_down:

src/Poseidon/Package.hs
40.66% <55.55%> (+0.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4557a4c...dbe28e9. Read the comment docs.


Azure AD Access Token support for DatabaseTarget

Provide support for setting an Azure AD Access Token when creating a SqlConnection
Add a package reference to System.Data.SqlClient for the netstandard2.0 target
Update the System.Security.Principal.Windows package version in support of adding the System.Data.SqlClient package

Sorry to disappoint you. But any solution that involves adding dependencies to the NLog-nuget-package is a complete no-go.

So what I don't understand about how it's currently built is for the netstandard 2.0 target (and the other netstandard targets), it's loading an assembly of "System.Data.SqlClient" in SetConnectionType. Without a package reference to System.Data.SqlClient either in NLog or the referencing application, this will blow up for netstandard x.x, as SqlClient is not included as part of the netstandard API. Is this intentional that you want a runtime-level exception to happen if the calling application does not have a reference to this package/DLL?
I can attempt to set the property via reflection if you absolutely cannot have a reference to that package. However, this feels to me just as dangerous as what I described above, for the same reason that it will cause a runtime exception instead of being caught at compile time.

I can attempt to set the property via reflection if you absolutely cannot have a reference to that package

@anxkha Looked at the DbType-assignment code and it is rather complex with probe-logic and conversion logic from DbType-enum to System-Types.
Take a look at the class PropertyHelper with the method SetPropertyFromString. It is a helper method for assigning property-values using reflection. It is not the fastest method, but it can get you started.

@anxkha
To elaborate on the references: NLog is currently dependency free. So if you don't need the database target, you don't need that package. Also the database targets works for a lot of database types with (runtime) dependencies, like the Oracle and MySQL, see https://github.com/NLog/NLog/wiki/Database-target#dbprovider-examples
Another option would be to make a new target (and optionally inherited from the database target) and a new nuget package and also a new git repo is preferred. For example see https://github.com/NLog/NLog.MailKit

I've made an alternative approach, based on this PR! https://github.com/NLog/NLog/pull/3825
Thanks @anxkha for the input!

@304NotModified You're welcome! Thank you for saving me from my still-limited knowledge of NLog internals ;)
I actually first started out by trying to make my own AzureDatabaseTarget that basically did the same thing as DatabaseTarget, except there are a couple of functions that are internal to NLog that seemed rather import to the operation of DatabaseTarget, so without those functions being made public or attempting a drastic, completely different approach, I wasn't able to go that route :(

@anxkha no problem :) I think it's also a nice feature to have.
Would it be possible to test the pre-release package for us?

@304NotModified Absolutely (as you saw on the other PR). I assume it's safe to close this PR now that yours exists?

yes I think also :)


fix: package fails to install

🐛 The bug
Module will not insatll anymore when using pnpm
test@tests-MacBook-Pro test_project % npx nuxi@latest module add link-checker
ℹ Installing nuxt-link-checker@latest development dependency                                                         11:04:45 PM
 WARN  9 deprecated subdependencies found<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Already up to date
Progress: resolved 1253, reused 1149, downloaded 0, added 0, done
 WARN  Issues with peer dependencies found
.
├─┬ @nuxt/scripts 0.7.1
│ └─┬ @nuxt/devtools-ui-kit 1.3.14
│   └─┬ @vueuse/integrations 11.0.1
│     └── ✕ unmet peer fuse.js@^7: found 6.6.2
└─┬ @nuxtjs/turnstile 0.9.3
└── ✕ unmet peer<EMAIL_ADDRESS>found 0.7.1
Done in 3.1s
 ERR_PNPM_MISSING_PACKAGE_NAME  pnpm add requires the package name
ERROR  Command failed with exit code 1: corepack pnpm add -D                                                         11:04:49 PM
at makeError (/Users/moshetanzer/.npm/_npx/b95349761371180e/node_modules/nuxi/dist/chunks/index7.mjs:578:11)
at handlePromise (/Users/moshetanzer/.npm/_npx/b95349761371180e/node_modules/nuxi/dist/chunks/index7.mjs:1504:26)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async executeCommand (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bddf6fd1.mjs:43:3)
at async addDependency (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bddf6fd1.mjs:205:3)
at async addDependency (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.bddf6fd1.mjs:234:5)
at async Object.setup (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/chunks/add2.mjs:145:19)
at async runCommand$1 (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.d8541eab.mjs:1620:5)
at async runCommand$1 (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.d8541eab.mjs:1639:11)
at async runCommand$1 (/Users//.npm/_npx/b95349761371180e/node_modules/nuxi/dist/shared/nuxi.d8541eab.mjs:1639:11)
❯ Install failed for nuxt-link-checker@latest. Do you want to continue adding the module to nuxt.config?
○ Yes / ● No
🛠 To reproduce
just install with modue add link-checker
🌈 Expected behavior
It to install :)
ℹ Additional context
No response

update: this seems to be an upstram issue with nuxi. Installing without @latest does work at the moment 🤷