Rewrite SSL_dup

SSL_dup did not work correctly. There were multiple fields that were not
being duplicated, and crashes could occur if the BIOs were set.
Previously each field was copied individually. In this rewrite we copy
the whole structure and then go back and fix up the malloc'd objects.
Fixes #8138

I rebased this due to a conflict with master. Still looking for a reviewer...

There is no problem, I think.

Travis red cross is not relevant

Ping?

Ping?

FWIW, we've found that no one really uses this function and removed a long time ago. As it's rather a headache to support, I might suggest deprecating it for future removal.

FWIW, we've found that no one really uses this function and removed a long time ago. As it's rather a headache to support, I might suggest deprecating it for future removal.

Actually I think that's a really good idea. The semantics of this function are just weird and confusing (sometimes it dups and sometimes it up-refs dependent on the state of the SSL object). The fact that #8138 went undiscovered for over 20 years demonstrates how rarely this function is used.
I've pushed another commit deprecating this. That commit won't be backported to 1.1.1. The others will.

Rebased this as well due to a conflict with master.

Ping Ping?

What do you mean by Ping Ping

What do you mean by Ping Ping

A slightly more insistent form of "ping"! (a request for a committer to review this PR)

What do you mean by Ping Ping

A slightly more insistent form of "ping"! (a request for a committer to review this PR)

understood...

I don't think that this is unused. I disagree with assertion.

Can you explain why this is useful? It its called after the handshake has started then it does the same thing as SSL_up_ref() - and that is a more appropriate function to call . If it is called after BIOs are set but before the handshake has started then this is clearly unused (because it was broken for 20 years and nobody noticed). So that leaves it being called between creation time and when BIOs are set. This is really about setting config settings and then copying them to new SSL objects - which is really what an SSL_CTX is supposed to be for.

The analysis in #8138 is simply incorrect - this was not a broken API for 20 years - this was a problem introduced in 2016 with BIO_up_ref itself was added it it didn't allow for a NULL BIO to be passed in when it was introduced and calls to it added in in SSL_dup - that call simply was not present - and it was the addition of that call that broken things.  See commit 2e7dc7cd6886b8006386e9f37e1defef66cbab55
BIO_dup_state uses BIO_ctrl which always had a NULL catch check (as did many of the functions and as should all the functions that take pointers from the user in our API) - its usage was okay.  That is where the analysis in #8138 goes wrong - you don't get to the individual BIO handlers when the BIO reference is NULL itself.
SSL_dup is used in the BIO handling for duplication of a BIO. Its concept was always to have an independent SSL created that ended up with the same settings as an existing SSL - at least that is precisely what its semantics were when it was introduced in SSLeay-0.9.0 back in 1998 - there was no concept of this being a reference to the same SSL ever. That semantic change was introduced in the DANE additions in 2015 in commit 919ba009429b3617e975933f37a23be996a33b8d and with no documentation update either to indicate that change had been made.

The analysis in #8138 is simply incorrect - this was not a broken API for 20 years - this was a problem introduced in 2016 with BIO_up_ref itself was added it it didn't allow for a NULL BIO to be passed in when it was introduced and calls to it added in in SSL_dup - that call simply was not present - and it was the addition of that call that broken things. See commit 2e7dc7c

Thanks for that info - that's useful. I think the commit you meant to reference is 65e2d672 - that's the one which adds BIO_up_ref() to SSL_dup.

BIO_dup_state uses BIO_ctrl which always had a NULL catch check (as did many of the functions and as should all the functions that take pointers from the user in our API) - its usage was okay. That is where the analysis in #8138 goes wrong - you don't get to the individual BIO handlers when the BIO reference is NULL itself.

I think you misunderstand the analysis in #8138. You are correct that BIO_dup_state() uses BIO_ctrl, and that does have a NULL check. However it is the destination BIO that #8138 is talking about being NULL not the source. Assume that the source rbio is set. We then hit this code in SSL_dup():
https://github.com/openssl/openssl/blob/cc838ee2d66f7295bf7a7e6695aab1080d6791e9/ssl/ssl_lib.c#L3852-L3864
Note that BIO_dup_state() (which is really BIO_ctrl) using the source BIO as the main object (which is non NULL) and then passes &ret->rbio as a parameter. At this point ret->rbio is NULL. What is actually being passed here is a BIO ** not a BIO *. The code seems to assume that BIO_dup_state() will create the BIO for it. But that's not what BIO_dup_state() does! The destination BIO must already exist, and it expects it to be a BIO * not a BIO **. For example take this implementation for a BIO_f_buffer():
    case BIO_CTRL_DUP:
        dbio = (BIO *)ptr;
        if (!BIO_set_read_buffer_size(dbio, ctx->ibuf_size) ||
            !BIO_set_write_buffer_size(dbio, ctx->obuf_size))
            ret = 0;
        break;

As you can see it expects the argument to be a BIO * and assumes that it is already created.

Closing an unloved PR.


pce.services object contains a bulk_create method, but the services API endpoint does not support bulk create

The pce.services object should not have an available bulk_create() method since this api endpoint does not support it.
Expected Result
The pce.services object should not have an available bulk_create() method since this api endpoint does not support it.
Actual Result
raise IllumioApiException(message) from e
illumio.exceptions.IllumioApiException: API call returned error code 406. Errors:
input_validation_error: Input validation failed. Details: {The property '#/' of type array did not match the following type: object in schema sec_policy_services_put.schema.json}

Steps to reproduce
    @staticmethod
    def chunker(seq, size):
        return (seq[pos:pos + size] for pos in range(0, len(seq), size))

    def bulk_create_services(self, services):
        for group in self.chunker(services, 999):
            self.pce.services.bulk_create(group)

This is true of all API objects since they use the common _PCEObjectAPI internal class. This is being worked on for the next version.


button: accept download prop when button is an anchor element

Download is a valid attribute for anchor tags. Since the Button component uses anchor tags when an href attribute is present, it should allow the download attribute.

Resolved with #342.


Graphical glitches in beta and GM macOS High Sierra 10.13

Had successfully running on Sierra, updated to High Sierra beta and screen saver no longer works. Will load up but images appears distorted. You can tell movement is occurring in the background, but the image itself does not correctly display. Attempted to uninstall and reinstall to no avail. Checked the logs and do not see any errors that have to do with the screen saver
I attempted taking a screenshot of the distortion so that you could see what I mean and the screen shot actually shows the correct image.
The image is displayed correctly very briefly prior to the image being distorted. It appears that when the image starts moving is when the distortion occurs.
Disabling automatic graphic switching prevents the issue from occurring. This was not the case prior to High Sierra.

I attempted taking a screenshot of the distortion so that you could see what I mean and the screen shot actually shows the correct image.

I just want to add 👍 to @ultiferrago's 👆 comment.
To me it looks like the frames are playing out of order - or the video is being rendered twice?
👾 💜

Duplicate of #365  .
They are rewriting the window manager to use Metal 2, so graphical glitches are to be expected while this work is ongoing. But please please please report these issues to Apple using the Feedback app.

I was having problems with the videos playing weirdly too!

Thanks, @alistairmcmillan!!
👾 💜

I have witness the problem on a 16:10 display (MacBook Air MID 2013) but not on a 16:9 display (Mac Mini MID 2011 attached to a HD TV). Both running 10.13 GM. Hope it helps narrow it down.

It is work on High Sierra for me on my iMac Retina and on a 2015 MacBook Pro. It is not working on a brand new MacBook Pro with Touch Bar.

On my MacBook Pro (13-inch, Late 2016, Two Thunderbolt 3 ports) - the non-touchbar version - it generally works, but right at the start of the screensaver it appears to start frozen for a split second, then flicker as if it would try to rescale, then start playing normally (at what I believe is the correct aspect ratio). For what it's worth this is tested on internal screen only, running the new default resolution of what looks like 1440x900. Running the GM - 10.13 Beta (17A360a).

@sn0wyfall @affrae @fgladu @mhyatt18 @jbozanowski I hope you're all using the Feedback app to report this to Apple. Not sure if there is much that John can do about glitches that Apple have introduced into their own drivers or frameworks.

Hi @alistairmcmillan I sure have. I can also report that with the GM of High Sierra the problem appears to have disappeared for me.
However that should not also preclude reporting here as sometimes software can break across upgrades. The number of apps updated shortly after a new OS release that list changes as "Now compatible with New Version of OS" or "Fix Issues with New Version of OS" are testament to that.
By notifying here as well as with Apple, the best chance exists for the right person to identify the issue. I did not assume the problem was with Aerial, or with Apple. I just reported on both fronts.
👾 💜

I can confirm I have the same issue on my 2017 15in Touchbar MBP with the High Sierra GM only when running integrated graphics. Switching to discrete graphics works, and is my current work around.

What do you mean by “discrete graphics”?

On Sep 24, 2017, at 10:10 PM, garrisoncarter<EMAIL_ADDRESS>wrote:
I can confirm I have the same issue on my 2017 15in Touchbar MBP with the High Sierra GM only when running integrated graphics. Switching to discrete graphics works, and is my current work around.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/JohnCoates/Aerial/issues/377#issuecomment-331766581, or mute the thread https://github.com/notifications/unsubscribe-auth/AeqNPUeBjHLVCO80O4WFZ4xXA8jmdOkLks5slxmggaJpZM4PSjmM.

I can confirm that using discrete graphics works as a workaround on my 2017 15in Touchbar MBP.
By discrete graphics we mean the Radeon Pro chipset.  The MBP switches automatically to the Intel HD Graphics chipset to save power and only turns on the Radeon Pro when it detects that it's needed.

The screen saver stopped working when I installed macOS High Sierra 10.13.0, on my Mac Pro Late 2013.  The screensaver floats the message "You cannot use the Aerial screen saver with this version of macOS.  Please contact the vendor to get a newer version of the screen saver."

Getting this issue as well on my mid 2015 15" mbp using integrated graphics - discrete chip works fine.

I have a 2017 MBP 13" w/o discreet graphics and I am encountering this issue

Never used High Sierra beta, just updated to High Sierra public release on a 15" MacBook Pro 2017 and this screensaver doesn't work. Whenever it's triggered, it gives the same glitchy effect you see when you have GPU issues.

I have the same problem when I play Final Fantasy XIV or War Thunder in my MacBook Pro 13" 2016 without Touch Bar at the release version of macOS High Sierra.

Also having flickering issues on my MacBook Pro 15" Mid2015 model after updating to HS

I'm having the issue with MacBook Pro 15" Touch Bar 2017 - talked to Apple support and they don't seem to have a real solution yet. Turing off Automatic Graphics Switching does make the issue appear less often though.

Adding my stats here to potentially help debugging. I am having this flickering issue on my MacBook Pro (Retina, 13-inch, Early 2015)
Processor 3.1 GHz Intel Core i7
Memory 16 GB 1867 MHz DDR3
Graphics Intel Iris Graphics 6100 1536 MB

adding my specs and some more context...
I have a MacBook Pro w/Touchbar (13-inch, 2017)
when connected to a Samsung 23.5-inch monitor, the Aerial videos work fine (on both screens)
but without the external monitor connected, the video is distorted as described above.
This started happening after upgrading to High Sierra.

Same issues here on a Macbook 13 inch 2014 after the update to HS

Having similar issues on my 15" mid 2017 MBP. Switching the integrated Intel Iris graphics card off helped.

I'm also seeing the issue on a 13" Retina MBP Early 2015 and 15" Retina MBP 2013. However, I suspect the graphic flickers are a general High Sierra issue rather than specific to Arial.

Also seeing this on my MacBook Pro touch Bar (15-inch, 2017) running High Sierra (10.13 17A365) when trying to view on the built-in display. Worked fine when connected to external display, but think that the issue is battery vs. power supply. Turning off Settings > Energy Saver > Automatic graphics switching allows the screensaver to work fine.

I've read through this thread twice, and I don't see a referenced Radar with Apple for High Sierra GM--am I missing it?  Are we sure it's an Apple bug, and not a problem with how Aerial works?

Here's what it looks like on my MBP 2017.

@AsydRayn I have exactly the same screen like your photo. I also posted an issue (closed due to replicate of this thread) #398

@mayhew1955 Oddly, I don't have any of those options under "energy saver" on my MBP w/TB 2017. Under Displays setting, I have Default or Scaled.

You can force the MBP to use the Radeon Pro chipset in the Energy Saver panel in Settings.

apparently these options aren’t available on a 13” MBP. it doesn’t come with the alt chipset

Just to confirm @drewwilliams' comment, on a 15" 2017 MacBook Pro running High Sierra 10.13, de-selecting "Automatic graphics switching" in System Preferences Energy Saver allows video playback in Aerial without problem. Re-enabling this setting and the graphics glitching returns.

It appears the new supplemental high Sierra update that just dropped fixed the issue on my MBP15" in integrated gfx mode.

Having the same issue on my 2017 13" MacBook Pro w TouchBar. It works fine on my 27" 4K Monitor. Do we know this happens on the internal display but not on an external?

@jackhcurtis For me it's limited to the internal display; works fine on external displays.

Yeah, with external it works. Macbook 12inch 2017. Worked fine on the same OS version with 2015 macbook I think.
BTW the workaround "show with clock" works, but of course - it's with clock :)

Thanks for the workaround "show with clock", it's better than nothing !

I have two MBP 15" with touchbar.. aerial is not working on the more recent one. Both have automatic graphics switching checked in the settings/energy saver stop screen.. I wonder whether this issue I am experiencing only on the latest MBP is due to differences in graphics cards..
The one that has no issue has Intel HD Graphics 530 (24-Bit Color).. the latest MBP has Intel HD Graphics 630 (30-Bit Color)

I have a 2017 Macbook Pro 13" without touch bar; I consistently see the same screen as @AsydRayn. Graphics switching isn't an option in my Energy Saver preferences, so I don't know how to fix. I'm on the latest versions of Arial and of High Sierra.

@Luke, there is no fix yet. But you can get it to work by turning on the clock.
On Oct 11, 2017, at 9:36 PM, Luke Deen Taylor <notifications<EMAIL_ADDRESS>wrote:
I have a 2017 Macbook Pro 13" without touch bar; I consistently see the same screen as @AsydRaynhttps://github.com/asydrayn. Graphics switching isn't an option in my Energy Saver preferences, so I don't know how to fix. I'm on the latest versions of Arial and of High Sierra.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/JohnCoates/Aerial/issues/377#issuecomment-335994965, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfEZ8ZkSiWCNmFm7uR1POdLpzIu7_hsRks5srW0wgaJpZM4PSjmM.

Do you think this has to do with Metal 1 vs Metal 2? If so, a rewrite/recompile might be needed.

i have the same problem MacBook Pro 13.

I'm curious how this works when the clock is enabled, yet it won't work when not. If it's a driver issue what is it that the clock toggle "patches" to make it work.

any update yet?

there are another problem like this even it works... when going back to desktop if the macbook are closed with an external montor

Installing 10.13.1 seems to have fixed the problem for me. Is anyone still getting the glitches with 10.13.1 installed?

@alistairmcmillan Nope, mine still has the same picture as @AsydRayn posted, with 10.13.1 installed :(

10.13.1 but same problem

I still have this problem on 10.13.1
On Sat, Nov 4, 2017 at 2:03 PM Sagitt<EMAIL_ADDRESS>wrote:

10.13.1 but same problem
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JohnCoates/Aerial/issues/377#issuecomment-341917532,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yr7Lg3avTQStk0UJaTub2LQFcFB4lks5szKcDgaJpZM4PSjmM
.

I still have this problem on 10.13.1
rMBP2017 with Touch Bar

I'm having this problem, 15" touchbar MBP 2017 running 10.13.1. It's solved with discrete graphics mode.

Same screensaver problem on MacBook Pro (Retina, 13-inch, Early 2015)

same here: MacBook Pro (Retina, 13-inch, Early 2015) macOS High Sierra(10.13.1)

same problem on a 2017 macbook pro 13", high sierra 10.13.1. Strangely it works fine on all displays clock-free if any external display is connected, but looks like the display is dead if it's showing only on the internal display. Displaying the clock with just the internal display also works fine for whatever reason

I'm running 10.13.1 macOS High Sierra on my MacBook Pro 17" with 2.8 GHz Intel Core 17 Processor and, following ultiferrago's suggestion, the graphical glitches I was getting in Safari (extreme pixellation, negative imaging on at least one e-newspaper site), I disabled Automatic Graphics Switching in Energy Saver in Preferences, and issues seems to be resolved.

Thanks @ultiferrago, disabling "Automatic graphic switching" prevents the issue from occurring.

I'm on High Sierra (version 10.13.1), MacBook Pro 15" 2017

I'm experiencing the same issue. Here's a rubbish video.
10.13.1 on MacBook Pro (15-inch, 2017)
When notifications appear, the image returns to normal before breaking again as soon as the notification disappears.

Please test it on external display, it works on my mbp 13 with touchbar but when touch the mouse with closed display but external monitor I see glitches running

Same issue here on my MacBook Pro 2015. It seems related to the camera, as it only glitches when someone moves in front of the camera

Same issue here. MacBook (Retina, 12-inch, 2017), 8 GB 1867 MHz LPDDR3, 1,3 GHz Intel Core i5,  Intel HD Graphics 615 1536 MB running MaOS High Sierra (10.13.1 (17B48)) - with clock toggle it works.

I observed that when I was working to document this bug using Quicktime to perform a screen capture appears to also resolve the issue. Anytime I was running a screen capture Aerial played back great. When I was not running a screen capture I ran into the same described interlacing issue.

+1

This is an ongoing issue in High Sierra. I hope a fix is forthcoming!

Me too!

same issue , its not fixed yet on latest HS 10.13.3

Confirmed issue still appearing on 10.13.3. Using a 2017 Macbook, so no option to change graphics chipset.

Is it me or turns out I fixed it by enabling "Show with clock" in the screen saver settings?
Config:
MacBook Pro (13-inch, 2017, Two Thunderbolt 3 ports)
macOS High Sierra 10.13.3

@buzzb0x : Yes, when you enabling "Show with clock" this prevent you macbook to switch from your graphic card to the Intel HD Graphics. If you don't want the clock on your screensaver just disable "Automatic graphic switching" on your macbook settings ("Energy Saver" tab)

I found some weird behavior. When I only use internal display of my MBP 13 2017, It glitches. but when I use my iMac as target display mode, It's working. even in MBP display. Hope this will helps for fixing issues..

I have a MacBook Pro 13" (MacBook Pro (13-inch, 2017, Four Thunderbolt 3 Ports) with integrated graphics, running 10.13.3. Enabling the clock feature results i smooth video; without the clock option, I get the zigzag garbled video. So for me this is a workaround for the moment as also noticed by @buzzb0x

2017 MBP with touch bar. Showing clock also fixes the problem for me. I do think though this might be a problem with the hardware and not necessarily the software. Im going to head into an apple store and show them this thread. I actually already had the display replaced because of this issue but it seems its still happening to me.

There is no such a problem on earlier macOS versions, so it's definitely software problem.

Ah ok. Didnt noticed that in this thread. Ill go over it again, thanks.

Didn't read the whole thread - but I have a brand new Macbook Pro 13" 2017 model, and the issue is reproducible as long as I don't select Show with clock. If I do select that setting, the screensaver works fine. There is only integrated graphics on this laptop as well, no discrete chip.

It looks like this is resolved with 10.13.4. I just updated, and tried the screen saver, removing the show with clock option, and after an initial video stutter the playback is smooth.

Mine isn't :-(

I suppose I should mention that my hardware is MacBookPro14,3 w/ Intel HD Graphics 630 & Radeon Pro 560. (i.e. MBP 15" 2017 w/TouchBar)

I can also confirm that the clock workaround is no longer needed for my setup with 10.13.4:
MacBook Pro (13-inch, 2017, Four Thunderbolt 3 Ports)
Intel Iris Plus Graphics 650 1536 MB

Just noticed that when I received a notification about a received email, the screensaver started playing correctly, but as soon as the notification faded it distorted again.

This has resolved for me with 10.13.4 on a MacBook Pro Touch Bar (15-inch, 2017).

@gwynnebaer I have the same setup as you and it's still not fixed for me when I untick clock. @newtonuk, your experience is exactly the same as mine...clock unticked, I get screen scramble until a notification arrives. Once the notification disappears, it's back to the garbled screen again.

While macOS 10.13.4 may have resolved this issue for those of you using a MacBook Pro it is definitely still crashing on my new 2017 MacBook. Interestingly enough, it was never an issue on my 2015 MacBook that was running the screen saver on the same version of macOS.

This issue was resolved for my 2017 MacBook in the macOS 10.13.5 public beta. I no longer have to use the "Show with clock" option to get the screen saver to work.

Still a problem for me with 10.13.4 when "show with clock" is off or integrated graphics is on. I'm getting the version with a cropped, zoomed in central video and a second zoomed-out copy playing behind it, visible above and below.

I'm getting a horizontally-stretched version of the video flickering across the screen whilst the brightness of the monitor changes—at all other times it's back to normal in 10.13.4.
Another rubbish video. Auto-brightness response triggered with a torch.

OSX 10.13.4, 15" 2017 MBP (w/touch bar)
Issue resolves by disabling graphics switching in energy saver settings.
Issue appears to be with integrated graphics solution (drivers?! what is this, a PC?), but not with the discrete graphics chip on systems w/touch bar.
I do not have this issue on my other MBP (13" 2015) or Air (2015).

I have a 2017 15-in MacBook Pro. I see the same scrambled images and have now twice seen spontaneous reboots, which I attribute to Aerial.

Fixed in Mojave Developer Beta 6 for me

Works for me in this iteration, even without the clock, on a 2017 13" MB Pro w/Touchpad that doesn't have an "automatic graphics switching" option.

Fixed in macOS Mojave 10.14 Beta (18A353d)

So this is the same as https://github.com/JohnCoates/Aerial/issues/487, I'll close this one and keep the other one open.
Afaik Mojave fixes those issues, and our version 1.4 may fix the issue with 10.13 with the new show description option.


Update README.md

Sentence corrected.
PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

Grammatical errors.
Issue Number: N/A
What is the new behavior?
Grammatical changes.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Thanks


Number 1 is accepted for enum [1.0]

I was using justify in a unit test to validate my API output format and noticed that a property of type "number" with value 1 validates against the enum [1.0]. I expected it not to validate, because 1 is not strictly equal to 1.0.
For me, the difference is important. When my API outputs 1, a client could think that the number is always integer. When it outputs 1.0 instead, they understand that it is a floating point value.

Hello @wromijn
Thank you so much for using this library.
In JSON world, 1.0 strictly equals to 1 because there is no distinction between integer and floating number.
JSON Schema specification explains instance equality
at http://json-schema.org/latest/json-schema-core.html#rfc.section.4.2.3.
both are numbers, and have the same mathematical value

Alsp note that integer in JSON Schema means a number without fractional part
or with only zeros in fractional part.
Therefore 1.0 must be treated as a valid integer in JSON Schema.
Please see the test case at
https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/master/tests/draft7/optional/zeroTerminatedFloats.json.

 The specification also says: "Whitespace and formatting concerns, including different lexical representations of numbers that are equal within the data model, are thus outside the scope of JSON Schema.". I will need to test this in another way then. Thank you for your quick answer!


Allow hiding tab UI

What's the Problem?
I do not intend to use tabs in Files.
Therefore, for me it is just takes up lots of UI space and makes the UX more complicated for something I do not use.
Solution/Idea
Allow us to disable the tab features by hiding its UI.
Alternatives
Not to allow users to hide it.
Priorities

Capability
Priority

This proposal will allow end users to disable/hide tab specific UI if desired
Should

Files Version
No response
Windows Version
No response
Comments
No response

We don't have plans to implement this change.


Surface Check and Dashboard changes

Description
The surface check for historical count is added. The count for historical data and the total resource count on Azure API for FHIR and FHIR service are added in the dashboard.
The logging for failure of export/import is added. The error message is now capture and store in table storage and application insight.
The failure message is also shown in dashboard.
Testing

Unit Testing.

@shashanknarang27 - looks like there are some merge conflicts with this PR.

@shashanknarang27 - looks like there are some merge conflicts with this PR.

@erikhoward : We have resolved the merge conflicts.


allow changing location of train_log itself

log files are huge and i would like to change to location the train_log folder, say to a different drive.

You can use logger.set_logger_dir(/mounts/trainlogs/myproject') instead of logger.auto_set_dir()

thanks. would be nice to have an option in auto_set_dir to change 'train_log' but still use the base_name logic

logger.set_logger_dir('/project/logs/' + os.path.basename(__file__)) would work fine.


Title: Adding theme features on Multiply Math game

Which pre-existing JavaScript project will you be working on?
i had worked on changing the UI design of the project
Describe your enhancement/improvement
i would like to add the light and dark theme functionality in the UI by having this feature the user will be able to change the theme as per their wish
Anything you need to say to the Reviewers
No
Add any other context or relevant screenshots about the enhancement here.
No response

@RithikaSundaram Thank you for providing your insight but it is not required as of now.


Python PIP test-on-install

PIP package is built and installed in a Docker container. Then the Python unit tests in the TF source are moved to a separate folder and ran with the plain Python environment without Blaze.
Four out of 151 tests were skipped for now due to dependency on modules in TF source that are not publicly exported.
Tests performed: Jenkins experimental builds for CPU and GPU Python test-on-install, see passing results at:
http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-cpu-python27-copt_pip_install-test/1/consoleFull
http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-gpu-python27-copt_pip_install-test/1/consoleFull

Can one of the admins verify this patch?

Can you either sign the CLA for your other email address or amend the
commits (or squash them) to use only your CLA-ok email?
On Fri, Jan 29, 2016 at 08:30 caisq<EMAIL_ADDRESS>wrote:

PIP package is built and installed in a Docker container. Then the Python
unit tests in the TF source are moved to a separate folder and ran with the
plain Python environment without Blaze.
Four out of 151 tests were skipped for now due to dependency on modules in
TF source that are not publicly exported.
Tests performed: Jenkins experimental builds for CPU and GPU Python
test-on-install, see passing results at:
http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-cpu-python27-copt_pip_install-test/1/consoleFull
http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-gpu-python27-copt_pip_install-test/1/consoleFull
You can view, comment on, or merge this pull request online at:
https://github.com/tensorflow/tensorflow/pull/935
Commit Summary

Python PIP test on install
Improving test_on_install.sh
Minor topy fix

File Changes

M tensorflow/tools/ci_build/Dockerfile.cpu
https://github.com/tensorflow/tensorflow/pull/935/files#diff-0 (8)
M tensorflow/tools/ci_build/Dockerfile.gpu
https://github.com/tensorflow/tensorflow/pull/935/files#diff-1 (9)
A tensorflow/tools/ci_build/builds/test_on_install.sh
https://github.com/tensorflow/tensorflow/pull/935/files#diff-2 (120)
A tensorflow/tools/ci_build/ci_test_on_install.sh
https://github.com/tensorflow/tensorflow/pull/935/files#diff-3 (81)

Patch Links:

https://github.com/tensorflow/tensorflow/pull/935.patch
https://github.com/tensorflow/tensorflow/pull/935.diff

—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/935.

HI Martin,
I thought the email<EMAIL_ADDRESS>the only Google email I have) should
have been registered. Anyway, if necessary, I can fill out the CLA. What is
the "google group email address" I should put in the form?
Thanks,
Shanqing
On Fri, Jan 29, 2016 at 7:08 PM, Martin Wicke<EMAIL_ADDRESS>wrote:

Can you either sign the CLA for your other email address or amend the
commits (or squash them) to use only your CLA-ok email?
On Fri, Jan 29, 2016 at 08:30 caisq<EMAIL_ADDRESS>wrote:

PIP package is built and installed in a Docker container. Then the Python
unit tests in the TF source are moved to a separate folder and ran with
the
plain Python environment without Blaze.
Four out of 151 tests were skipped for now due to dependency on modules
in
TF source that are not publicly exported.
Tests performed: Jenkins experimental builds for CPU and GPU Python
test-on-install, see passing results at:

http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-cpu-python27-copt_pip_install-test/1/consoleFull

http://ci.tensorflow.org/view/Experimental/job/experimental-cais-tensorflow-gpu-python27-copt_pip_install-test/1/consoleFull

You can view, comment on, or merge this pull request online at:
https://github.com/tensorflow/tensorflow/pull/935
Commit Summary

Python PIP test on install
Improving test_on_install.sh
Minor topy fix

File Changes

M tensorflow/tools/ci_build/Dockerfile.cpu
https://github.com/tensorflow/tensorflow/pull/935/files#diff-0 (8)
M tensorflow/tools/ci_build/Dockerfile.gpu
https://github.com/tensorflow/tensorflow/pull/935/files#diff-1 (9)
A tensorflow/tools/ci_build/builds/test_on_install.sh
https://github.com/tensorflow/tensorflow/pull/935/files#diff-2 (120)
A tensorflow/tools/ci_build/ci_test_on_install.sh
https://github.com/tensorflow/tensorflow/pull/935/files#diff-3 (81)

Patch Links:

https://github.com/tensorflow/tensorflow/pull/935.patch
https://github.com/tensorflow/tensorflow/pull/935.diff

—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/935.

—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/935#issuecomment-177026119
.

--
Shanqing Cai
Software Engineer, Tools and Infrastructure
Applied Machine Intelligence
Google, Inc.
<EMAIL_ADDRESS>

One of the commits is created using "cais<EMAIL_ADDRESS>maybe just squash the commits, then you should be fine.

I'm closing this pull request and creating a new one to address wicke's comments and the cla issue. See https://github.com/tensorflow/tensorflow/pull/939


Cannot run the service behind corporate proxy

Our proxy rules ban AWS. As the service is starting it does an attempt to download the latest selenium drivers and fails. The startup fails even when there are already some downloaded binaries from previous runs (downloaded via direct Internet access).
Proposed solution:
Make the download optional - e.g. don't reject the promise when the download fails and let Selenium run with an older driver (if exists).
If you accept such a solution I am willing to create a pull request with the change.

I had the same problem. I developed a workaround by downloading the selenium server java file and chromedriver manually, using gulp plus node run cmd package to run dual cmds, updating some  arguments in capabalities, and removing the reference in wdio.conf which refers to services. Here is my solution: https://github.com/inspiraller/cucumber-boilerplate-behind-corporate-network


Windows support?

Also see #2. I think there are two options:

Invoke the bash scripts from Windows. I'm not sure how / whether this can be done. Will require WSL to be installed. Not sure if there are further issues with access permissions etc. Will require some investigation.
Create Windows versions of find_files.sh and find_within_files.sh (the scripts in the extension that invoke fzf). This may be the nicest solution as it's a native implementation, but requires Windows shell scripting, which I'm not familiar at all.

If you're a Windows user, please vote on this ticket using 🚀  for the first solution, 🎉  for the second, or 😕  for don't know / don't care as long as you do something. Votes will compel me to take action (and learn windows batch file scripting).
If you're interested in implementing solution 2 and supporting it, please shoot me a message! The extension is built in such a way that implementing this solution requires writing two scripts that invoke the terminal commands, and there are reference implementations in bash shell script.

Not a user of this, but i thought i'd provide a bit of rambling which may help.

Ripgrep was internalized into VScode some time ago see package.json.

FZF is tricker. The simplest install is the binaries via chocolatey or scoop. But IMO before you added win support here, fzf should be added to winget since that ships by default win11, related issues here:

https://github.com/microsoft/winget-pkgs/issues/906
https://github.com/junegunn/fzf/issues/2661

https://github.com/tomrijndorp/vscode-finditfaster/pull/18
I just downloaded the windows versions of bat, fzf and ripgrep. The extension scripts are all powershell scripts.

Native Windows support is implemented as of version 0.0.20 now :)


Support of hosted environments

Microsoft.Extensions.DependencyModel.DependencyContext.Default was null in CoreCLR hosted environments (CoreCLR hosted in native app). The reason is that System.Reflection.Assembly.GetEntryAssembly() is null

Hey, just wanted to let you know I've seen this, but I haven't reviewed its contents. I hope to have free time in the next 7 days or so to take a closer look.
-Nate

Thanks Nate for your Information.
BR,
Gerald
Von: Nate McMaster<EMAIL_ADDRESS>Gesendet: Dienstag, 8. Oktober 2019 17:34
An: natemcmaster/DotNetCorePlugins<EMAIL_ADDRESS>Cc: COPA-DATA Productmanagement<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Betreff: Re: [natemcmaster/DotNetCorePlugins] Support of hosted environments (#80)
Hey, just wanted to let you know I've seen this, but I haven't reviewed its contents. I hope to have free time in the next 7 days or so to take a closer look.
-Nate
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnatemcmaster%2FDotNetCorePlugins%2Fpull%2F80%3Femail_source%3Dnotifications%26email_token%3DAGRYQZ43MUFEYT4Y3H67AOTQNSR4XA5CNFSM4I6NKEAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAUTFKA%23issuecomment-539570856&data=02|01||57cce1cba7bb48b3d57708d74c04e091|898f296943e24aa0a4f5ac6069317381|1|0|637061456142157379&sdata=5cGlGlOueehgR9ZfyzmnGdG2t057InJLHDwklbNhSyE%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGRYQZ522OUQURFLAWZE3ELQNSR4XANCNFSM4I6NKEAA&data=02|01||57cce1cba7bb48b3d57708d74c04e091|898f296943e24aa0a4f5ac6069317381|1|0|637061456142167372&sdata=tr%2Bd5RCYv7rV%2BFVfkTs3oKpxFa0s07NA6184PSdAktc%3D&reserved=0.

Thanks for the contribution! This is now available in the 0.3.1 release.


WIP: Module install fix

🚧 WIP, DO NOT MERGE 🚧
This should do the trick...

@porteri This PR should be ready to merge.

@zbeekman I just saw your comment. I opened a PR against your branch module-install-fix from nrc-fuels/vtkmofo master branch to bring in the latest fixes so that your PR will have those coming into this repo.  Ping me when you have merged and want me to approve this PR (or maybe you want to rebase your branch on nrc-fuels/vtkmofo? Whatever you think is best.

@porteri This is ready to ship


message

FYI you appear to have 2 github accounts, csiret and CharlesS940. This may be error prone in the future


Missing information in python interface

A file_storage_path attribute was added to SharedEnv.h. But it looks like the attribute is not exposed in the Python interface.
Please also check if any other update in the C++ interface is not updated in the Python interface.

Added file_storage_path to the binding and pushed to develop


[SPARK-7287] [SPARK-8567] [TEST] Add sc.stop to applications in SparkSubmitSuite

Hopefully, this suite will not be flaky anymore.

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <[spark] [SPARK-7287] [SPARK-8567] [TEST] Add sc.stop to applications in SparkSubmitSuite (#7027)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Merged build triggered.

Merged build started.

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [spark] [SPARK-7287] [SPARK-8567] [TEST] Add sc.stop to applications in SparkSubmitSuite (#7027)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Test build #35809 has started for   PR 7027 at commit c0167e2.

Test build #35809 timed out     for PR 7027 at commit c0167e2     after a configured wait of 175m.

Merged build finished. Test FAILed.

@vanzin How about we get this one merged first to make tests pass? Then, we can investigate the root cause under SPARK-8643?

How about we get this one merged first to make tests pass?

If it's a real big problem and you're sure it helps, I'm not strongly against it; but it feels wrong, since it seems to just be masking the real issue, not resolving it. For example, why are executors being killed before SparkContext.stop() is called? Maybe there are other shutdown hooks doing things in the wrong order and causing a race somewhere?

test this please.

Merged build triggered.

Merged build started.

Test build #35882 has started for   PR 7027 at commit c0167e2.

Test build #35882 has finished for   PR 7027 at commit c0167e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM, merging into master 1.4. @vanzin if there is an issue with the shutdown hooks I'm sure we'll see another manifestation of it. I think it's higher priority to unblock development and increase the community confidence in our tests.


Number vs collection

This PR has two commits. The first is the fix and the second is the test, which includes a dependency on sympy (for the sympy Zero object).
I couldn't come up with a quick way of testing if this works with things like Zero but I assume this sympy dependency is surplus to requirements. If you know of a better way, I'd be happy to fix this, otherwise perhaps just run the tests for proof that it works, and then just merge the first commit.

Ok, I've added the skipTest.

@jamiebull1 thanks for the PR! :+1:  When we do CI (https://github.com/greginvm/pyclipper/issues/4) we can include sympy in tests but still don't require it for regular installations. This way we ensure this test is actually executed when we update the lib.
I'll merge when you add the sympy.Zero check.

Sure. I checked that manually in the debugger, but I'll add the explicit
test too.
On Wed, 17 Aug 2016, 12:32 Gregor Ratajc<EMAIL_ADDRESS>wrote:

@jamiebull1 https://github.com/jamiebull1 thanks for the PR! 👍 When we
do CI (#4 https://github.com/greginvm/pyclipper/issues/4) we can
include sympy in tests but still don't require it for regular
installations. This way we ensure this test is actually executed when we
update the lib.
I'll merge when you add the sympy.Zero check.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/greginvm/pyclipper/pull/6#issuecomment-240374542, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADo-yC71dgOZI-ZZWWGVxnI5sDhNQlLGks5qguMagaJpZM4JmRE1
.


[Bug] Settings do not save when no scene is present

Describe the bug

To Reproduce
Create a world with no scenes and try to change settings of the module.

Hotkeys do not save, cannot apply to all users
Cannot create/edit pings and pointers

Thanks for the bug report.
I do not think this is a huge issue, since not having a scene is kind of a rare edge case, especially if one wants to use this module.
I'll still take a look at this at some point, but time is scarce currently and i think the priority isn't high here. If someone disagrees, feel free to send a PR fixing this issue. (PRs are always welcome to all my modules)


Issue with k8s.io/docs/tutorials/kubernetes-basics/deploy-interactive/

kubectl proxy command hungs at starting server on port 8001

This is a...

[ ] Feature Request
[ ] Bug Report

Problem:
Proposed Solution:
Page to Update:
http://kubernetes.io/...

I think can see that you get an impression that the command still runs in the foreground, but actually, if you were to ignore that and just click on the next step, you will see that it all works okay.
I'm tempted to close this, ping @BenHall.

Indeed. Sadly kubectl proxy doesn't output any messages so it looks like nothing is happening, but it's actually by design.
We've tried to make this clear in the docs, but we'll have another look.

Maybe make the command kubectl proxy &, so it's clearer?
On Mon, 5 Feb 2018 at 14:24 Ben Hall<EMAIL_ADDRESS>wrote:

Indeed. Sadly kubectl proxy doesn't output any messages so it looks like
nothing is happening, but it's actually by design.
We've tried to make this clear in the docs, but we'll have another look.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/7237#issuecomment-363098912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS_V-yc5uMu_PyTxK1aiHxksq012oks5tRw8ggaJpZM4R5XVf
.


Stricter tsconfig

Type-only imports
Enable noImplicitReturns, noUnusedLocals

@davidzhao It prevents accidentally non-type import (increase build size). But since LiveKit JS only has 1 build output, it is only for explicit "documentation" purpose. Will revert that commit if it is not worth extra check.

@davidzhao I reverted noImplicitReturns and importsNotUsedAsValues to minimize changes. Keep noUnusedLocals check which is similar to Go.

thanks! this looks good.


compile doris 1.1.5 error base on docker image build-env-for-1.2[Bug]

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.1.5-rc02
What's Wrong?
According to the description on the official website, i cannot be compiled doris code， error is
/var/local/thirdparty/installed/include/parallel_hashmap/phmap.h:3256:27: error: no match for call to '(doris::BrpcClientCachedoris::PBackendService_Stub::get_client(const string&)::<lambda(phmap::priv::parallel_hash_map<8, phmap::priv::raw_hash_set, std::mutex, phmap::priv::FlatHashMapPolicy<std::__cxx11::basic_string, std::shared_ptrdoris::PBackendService_Stub >, std::hash<std::__cxx11::basic_string >, std::equal_to<std::__cxx11::basic_string >, std::allocator<std::pair<const std::__cxx11::basic_string, std::shared_ptrdoris::PBackendService_Stub > > >::mapped_type&)>) (std::pair<const std::__cxx11::basic_string, std::shared_ptrdoris::PBackendService_Stub >&)'
3256 |         std::forward(f)(*ptr);
|         ~~~~~~~~~~~~~~^~
What You Expected?
it can be compiled successfully
How to Reproduce?
1 clone code from github
2 checkout branch to 1.1.5-rc02,
3 install docker image build-env-for-1.2
4 run a docker and mount directory for src
5 sh build.sh --clean --be --fe
but i can not compile doris code successfully, it seem like the c++ problem
Anything Else?
no
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

please use docker image apache/doris:build-env-for-1.1.0


Fix environment for uploading to PyPI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.482%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
2202

Relevant Lines:
2736

💛  - Coveralls


Support for darwin_ARM64 (Apple Macbook Pro with M1 chip)

Can we add support for Macbook pro users with an M1 chip? When running an init i get the following error message:
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/aztfmod/azurecaf v1.2.2 does not have a package available for your current platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all platforms. Other versions of this provider may
│ have different platforms supported.

The current workaround is not ideal: Use a Docker Development environment in VSCode.

Should be resolved now, let us know if you are still facing the issue.

I'm still facing this issue
Provider registry.terraform.io/aztfmod/azurecaf v1.2.6 does not have a package available for your current platform, darwin_arm64.

@arnaudlh could you help with this?


refactor: ♻ changes containerPath variable name in component generator (#70)

Resolves #70
The containerPath variable in internals/generators/container/index.ts should be named componentPath to avoid confusion.

Pull Request Test Coverage Report for Build 264878131

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.673%

Totals

Change from base Build 241460498:
0.0%

Covered Lines:
245

Relevant Lines:
245

💛  - Coveralls


Implement podcast queries

closes #158

BREAKING CHANGE: ChannelID is renamed to ArtistChannelID - allows for new PodcastChannelID also.


Example .env file

It would be very good to have a .env.example file in the repo with sample values for all the key env variables used in the repo.
This would be quite useful for anyone starting to contribute and doesn't know of all the env variables present
e.g
REACT_APP_API_BASE_URL='<API URL from backend>'
SERVICE_ID='<Vite service ID from blahblahblah>'

etc

Issues was addressed in last sprint ✅


[WIP] Auth Upgrade

Cool! I'll try it out

It seems that npm run build is failing on this branch but not on the main branch?

I tried npm ci && npm run build && npm start and then visit http://localhost:8080 and I see no UI showing up, but instead see this error in the browser developer tools console:
Uncaught (in promise) TypeError: Cannot read property 'handleIncomingRedirect' of undefined
    at _callee$ (index.ts:28)
    at tryCatch (runtime.js:63)
    at Generator.invoke [as _invoke] (runtime.js:293)
    at Generator.next (runtime.js:118)
    at asyncGeneratorStep (asyncToGenerator.js:3)
    at _next (asyncToGenerator.js:25)
    at asyncToGenerator.js:32
    at new Promise (<anonymous>)
    at asyncToGenerator.js:21

@michielbdejong
auth-upgradede merged to main and apparently working.
There was a changes due to upgrading dependencies.


v2.6.4 Release Task - Release System-Agent

Rancher Backend Engineering Task
This is a Rancher backend engineering task for (https://github.com/rancher/rancher/issues/36375) for the rancher engineering release captain:

[ ] Tag the release onto the correct branch and push the https://github.com/rancher/system-agent

https://github.com/rancher/system-agent/releases/tag/v0.2.3


Ingotnito keyboard support

I use Gboard which supports an incognito mode in apps that request it, it will not learn new words so they are not added to the learned word list and autocomple. Reason being you don't want booru searches being stored and suggested outside the app in the keyboard.

Looks like it's doable with this parameter:
https://api.flutter.dev/flutter/widgets/EditableText/enableIMEPersonalizedLearning.html
Thanks for the suggestion!

Brilliant, but the toggle is disabled upon app restart when I think it should be permanent until being disabled. Also I think it should be turned on by default.


Bump version to 0.6.0

Signed-off-by: Jeremy Phelps<EMAIL_ADDRESS>

recheck

recheck

recheck

Core-test reference was missed. Replacing with #25


all examples now run on v0.23

channel-select

... in channel-select/channel-select.cr:1: undefined constant T

<FromGitter> <mverzilli> the T there is a free variable, so it needs to be quantified
<FromGitter> <sdogruyol> forall is kind of underdocumented :P

json

undefined method 'json_object' for String::Builder

JSON has new syntax now.

Thank you @tzekid @mjago 👍


Request for Documentation: HTTPS + WSS protocol usage for Posts

Mattermost user ahmad.danial from https://community.mattermost.com has requested the following be documented:

Q: When a message is posted to channel, does it only use HTTPS / SSL protocol for encryption since WSS is mainly for facilitating real time data transfer between the client and server or are both protocols being used at the same time?
A: Both HTTPS and WSS are used simultaneously. (SSL is typically enabled for both, unless only HTTP or WS is used)

See the original post here.
This issue was generated from Mattermost using the Doc Up plugin.

Comprehensive encryption product documentation is available at docs.mattermost.com. Closing.


Error: Dynamic require of "/inlinedQRL.js" is not supported when site requested from Netlify Edge Function

Qwik Version
Qwik: 0.9.0, Qwik City 0.0.111
Operating System (or Browser)
Chrome, mac OS
Node Version (if applicable)
No response
Which component is affected?
Qwik City
Expected Behaviour
I see a successful deploy in Netlify and can visit my site.
Actual Behaviour
I get an error when visiting my site and the an error in my Edge Function logs:

This edge function has crashed
An unhandled error in the function code triggered the following message:
The deployment failed while serving the request.
Connection details
Netlify internal ID: 01GDNNS55951CJ15AGR0JKZ73E

5:57:58 PM: Error: Dynamic require of "/inlinedQRL.js" is not supported
    at file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:4875:9
    at Object.importSymbol (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:4917:22)
    at resolve (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:2481:37)
    at AsyncFunction.resolveLazy [as $resolveLazy$] (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:2485:53)
    at _useStyles (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:3190:26)
    at useStylesScopedQrl (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:3166:3)
    at file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:3201:3
    at invoke (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:70:42)
    at file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:2497:59
    at then (file:///root/netlify/edge-functions/entry.netlify-edge/entry.netlify-edge.js:28:79)

Additional Information
The repo is here: https://github.com/philwolstenholme/lasttramfrom-qwik
Site is here: https://silver-griffin-03ccbb.netlify.app/

Netlify build log
5:57:24 PM: Build ready to start
5:57:26 PM: build-image version: d7b3dbfb0846505993c9a131894d1858074c90b4 (focal)
5:57:26 PM: build-image tag: v4.10.1
5:57:26 PM: buildbot version: 1c362ef848ac5e35535bdb572ebca893db28c8a0
5:57:26 PM: Building without cache
5:57:26 PM: Starting to prepare the repo for build
5:57:26 PM: No cached dependencies found. Cloning fresh repo
5:57:26 PM: git clone https://github.com/philwolstenholme/lasttramfrom-qwik
5:57:26 PM: Preparing Git Reference refs/heads/main
5:57:27 PM: Parsing package.json dependencies
5:57:28 PM: Starting build script
5:57:28 PM: Installing dependencies
5:57:28 PM: Python version set to 2.7
5:57:28 PM: Attempting node version '16' from .node-version
5:57:28 PM: Downloading and installing node v16.17.1...
5:57:28 PM: Downloading https://nodejs.org/dist/v16.17.1/node-v16.17.1-linux-x64.tar.xz...
5:57:29 PM: Computing checksum with sha256sum
5:57:29 PM: Checksums matched!
5:57:30 PM: Now using node v16.17.1 (npm v8.15.0)
5:57:31 PM: Started restoring cached build plugins
5:57:31 PM: Finished restoring cached build plugins
5:57:31 PM: Attempting ruby version 2.7.2, read from environment
5:57:31 PM: Using ruby version 2.7.2
5:57:31 PM: Using PHP version 8.0
5:57:32 PM: No npm workspaces detected
5:57:32 PM: Started restoring cached node modules
5:57:32 PM: Finished restoring cached node modules
5:57:32 PM: Installing NPM modules using NPM version 8.15.0
5:57:32 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
5:57:32 PM: npm WARN config location in the cache, and they are managed by
5:57:32 PM: npm WARN config     cacache.
5:57:32 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
5:57:32 PM: npm WARN config location in the cache, and they are managed by
5:57:32 PM: npm WARN config     cacache.
5:57:35 PM: added 283 packages, and audited 284 packages in 3s
5:57:35 PM: 125 packages are looking for funding
5:57:35 PM:   run npm fund for details
5:57:35 PM: found 0 vulnerabilities
5:57:35 PM: NPM modules installed
5:57:36 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
5:57:36 PM: npm WARN config location in the cache, and they are managed by
5:57:36 PM: npm WARN config     cacache.
5:57:36 PM: Started restoring cached go cache
5:57:36 PM: Finished restoring cached go cache
5:57:36 PM: Installing Go version 1.17 (requested 1.17)
5:57:41 PM: unset GOOS;
5:57:41 PM: unset GOARCH;
5:57:41 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.17.linux.amd64';
5:57:41 PM: export PATH="/opt/buildhome/.gimme/versions/go1.17.linux.amd64/bin:${PATH}";
5:57:41 PM: go version >&2;
5:57:41 PM: export GIMME_ENV="/opt/buildhome/.gimme/env/go1.17.linux.amd64.env"
5:57:41 PM: go version go1.17 linux/amd64
5:57:41 PM: Installing missing commands
5:57:41 PM: Verify run directory
5:57:42 PM:
5:57:42 PM: ────────────────────────────────────────────────────────────────
5:57:42 PM:   Netlify Build
5:57:42 PM: ────────────────────────────────────────────────────────────────
5:57:42 PM:
5:57:42 PM: ❯ Version
5:57:42 PM:   @netlify/build 27.18.4
5:57:42 PM:
5:57:42 PM: ❯ Flags
5:57:42 PM:   baseRelDir: true
5:57:42 PM:   buildId: 632de574b515e82dd3a32224
5:57:42 PM:   deployId: 632de574b515e82dd3a32226
5:57:42 PM:
5:57:42 PM: ❯ Current directory
5:57:42 PM:   /opt/build/repo
5:57:42 PM:
5:57:42 PM: ❯ Config file
5:57:42 PM:   /opt/build/repo/netlify.toml
5:57:42 PM:
5:57:42 PM: ❯ Context
5:57:42 PM:   production
5:57:42 PM:
5:57:42 PM: ────────────────────────────────────────────────────────────────
5:57:42 PM:   1. build.command from netlify.toml
5:57:42 PM: ────────────────────────────────────────────────────────────────
5:57:42 PM:
5:57:42 PM: $ npm run build
5:57:43 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
5:57:43 PM: npm WARN config location in the cache, and they are managed by
5:57:43 PM: npm WARN config     cacache.
5:57:43 PM: > build
5:57:43 PM: > qwik build
5:57:43 PM: tsc --incremental --noEmit
5:57:43 PM: vite build
5:57:43 PM: vite build --ssr src/entry.netlify-edge.tsx
5:57:44 PM: vite v3.1.1 building for production...
5:57:44 PM: transforming...
5:57:45 PM: ✓ 50 modules transformed.
5:57:45 PM: rendering chunks...
5:57:45 PM: dist/q-manifest.json        11.59 KiB
5:57:45 PM: dist/build/q-18dadcff.js    0.06 KiB / gzip: 0.07 KiB
5:57:45 PM: dist/build/q-66fccbab.js    0.26 KiB / gzip: 0.22 KiB
5:57:45 PM: dist/build/q-df84ea43.js    0.19 KiB / gzip: 0.17 KiB
5:57:45 PM: dist/build/q-7584bb0c.js    4.80 KiB / gzip: 2.31 KiB
5:57:45 PM: dist/build/q-78a9a428.js    0.77 KiB / gzip: 0.30 KiB
5:57:45 PM: dist/build/q-9cfd76e0.js    1.49 KiB / gzip: 0.84 KiB
5:57:45 PM: dist/build/q-a7d11805.js    0.83 KiB / gzip: 0.49 KiB
5:57:45 PM: dist/build/q-b169bcd0.js    0.89 KiB / gzip: 0.47 KiB
5:57:45 PM: dist/build/q-a3f59757.js    0.20 KiB / gzip: 0.16 KiB
5:57:45 PM: dist/build/q-d9c9934f.js    0.30 KiB / gzip: 0.22 KiB
5:57:45 PM: dist/build/q-06c44d87.js    0.25 KiB / gzip: 0.18 KiB
5:57:45 PM: dist/build/q-bc557db0.js    0.26 KiB / gzip: 0.20 KiB
5:57:45 PM: dist/build/q-ed037dc6.js    0.11 KiB / gzip: 0.11 KiB
5:57:45 PM: dist/build/q-faf6ade2.js    1.16 KiB / gzip: 0.55 KiB
5:57:45 PM: dist/build/q-6bdd8e58.js    0.87 KiB / gzip: 0.46 KiB
5:57:45 PM: dist/build/q-5700c3ab.js    0.42 KiB / gzip: 0.29 KiB
5:57:45 PM: dist/build/q-cc7cabba.js    0.41 KiB / gzip: 0.28 KiB
5:57:45 PM: dist/build/q-6fea75db.js    35.76 KiB / gzip: 14.74 KiB
5:57:45 PM: dist/build/q-0ed7aa64.js    5.17 KiB / gzip: 1.56 KiB
5:57:45 PM: dist/service-worker.js      2.13 KiB / gzip: 1.01 KiB
5:57:45 PM: dist/build/q-83b02ad9.js    0.38 KiB / gzip: 0.29 KiB
5:57:45 PM: dist/build/q-fecf0061.css   0.37 KiB / gzip: 0.23 KiB
5:57:45 PM: ✓ Built client modules
5:57:46 PM: ✓ Built server (ssr) modules
5:57:46 PM: ✓ Type checked
5:57:46 PM:
5:57:46 PM: (build.command completed in 3.9s)
5:57:46 PM:
5:57:46 PM: ────────────────────────────────────────────────────────────────
5:57:46 PM:   2. Edge Functions bundling
5:57:46 PM: ────────────────────────────────────────────────────────────────
5:57:46 PM:
5:57:46 PM: Packaging Edge Functions from netlify/edge-functions directory:
5:57:46 PM:  - entry.netlify-edge
5:57:51 PM:
5:57:51 PM: (Edge Functions bundling completed in 4.3s)
5:57:51 PM:
5:57:51 PM: ────────────────────────────────────────────────────────────────
5:57:51 PM:   3. Deploy site
5:57:51 PM: ────────────────────────────────────────────────────────────────
5:57:51 PM:
5:57:51 PM: Starting to deploy site from 'dist'
5:57:51 PM: Creating deploy tree
5:57:51 PM: Creating deploy upload records
5:57:52 PM: 0 new files to upload
5:57:52 PM: 0 new functions to upload
5:57:52 PM: Site deploy was successfully initiated
5:57:52 PM:
5:57:52 PM: (Deploy site completed in 1.3s)
5:57:52 PM:
5:57:52 PM: ────────────────────────────────────────────────────────────────
5:57:52 PM:   Netlify Build Complete
5:57:52 PM: ────────────────────────────────────────────────────────────────
5:57:52 PM:
5:57:52 PM: (Netlify Build completed in 9.6s)
5:57:52 PM: Starting post processing
5:57:52 PM: Post processing - HTML
5:57:52 PM: Caching artifacts
5:57:52 PM: Started saving node modules
5:57:52 PM: Finished saving node modules
5:57:52 PM: Started saving build plugins
5:57:52 PM: Finished saving build plugins
5:57:52 PM: Started saving pip cache
5:57:52 PM: Finished saving pip cache
5:57:52 PM: Started saving emacs cask dependencies
5:57:52 PM: Post processing - header rules
5:57:52 PM: Finished saving emacs cask dependencies
5:57:52 PM: Started saving maven dependencies
5:57:52 PM: Finished saving maven dependencies
5:57:52 PM: Started saving boot dependencies
5:57:52 PM: Finished saving boot dependencies
5:57:52 PM: Started saving rust rustup cache
5:57:52 PM: Finished saving rust rustup cache
5:57:52 PM: Started saving go dependencies
5:57:52 PM: Finished saving go dependencies
5:57:52 PM: Post processing - redirect rules
5:57:53 PM: Post processing done
5:57:54 PM: Build script success
5:57:55 PM: Uploading Cache of size 172.4MB
5:57:56 PM: Site is live ✨
5:57:56 PM: Finished processing build request in 30.457880026s

is there a repo/stackblitz i can take a look?

@manucorporat ah sorry, I messed up the formatting so the repo link got a bit buried.
The repo is here: https://github.com/philwolstenholme/lasttramfrom-qwik
Site is here: https://silver-griffin-03ccbb.netlify.app/

I am having the same issue, i follow the docs but when i try to run node server/entry.static.js i get the following:
Duration: 198.7 ms
Average: 198.7 ms per page

worker error: Error: Dynamic require of "/inlinedQRL.js" is not supported

Node Version: 16.17.0

This should be fixed in the latest release, we went through a big refactor of the build process!


Added documentation for Analyzers

Need to be re-read but I think that it contains enough for now.

cool stuff. thanks so much


onViewportChange Function Not Updated When Dependencies Change in useEffect Hook

What platform were you using when you found the bug?

React Flow / Svelte Flow version: 12.1.1
Browser and version: n/a
OS and version: n/a

Live code example
https://codesandbox.io/p/sandbox/cocky-leftpad-w9z9nz
Describe the Bug
There is a bug in the useEffect hook within the zoomPane setup code where the onViewportChange function is used. The useEffect hook does not include onViewportChange in its dependency array. As a result, if the onViewportChange function is updated, the effect continues to reference the stale closure of the function, leading to unexpected behavior where the old version of the function is called instead of the new one.
Steps to reproduce the bug or issue

Open sandbox and run preview
Click "Use ViewportStore2" Button
Try to move or zoom the pane

Expected behavior
The pane should move. But since the stale onViewportChange changes the ViewportStore1, all changes will be applied to that. When you switch back you will see exactly that.
Screenshots or Videos
No response
Additional context
No response

Fixed by #4578

Thanks @alexanderhorner ! This is fixed in 12.2.1


[Android] react-native run-android: Parsing of AndroidManifest.xml wrong

I saw that for the command react-native run-android you guys are getting the package name of the application out of app/src/main/AndroidManifest.xml. This is ok if you change the application package in the gradle file AND in the AndroidManifest.xml.
A better way would be to look at the final generated AndroidManifest.xml in the build directory to find the actual application id to start up the application.

A PR is welcome to improve the process.

I changed the Application ID and **not ** the package name.  the result is I can compile and launch the app for android via Android Studio.. but running from the command line results in
Error type 3
Error: Activity class {com.foo/com.foo.MainActivity} does not exist.

To respect applicationId in android/app/build.gradle then try to start activity by {applicationId}/{originalPackage}.MainActivity
Keeping MainActivity in original path is good for future migration.
--- a/local-cli/runAndroid/runAndroid.js
+++ b/local-cli/runAndroid/runAndroid.js
@@ -149,6 +149,11 @@ function run(args, reject) {
   }

   try {
+    const applicationId = fs.readFileSync(
+      'app/build.gradle',
+      'utf8'
+    ).match(/applicationId "(.+?)"/)[1];
+
     const packageName = fs.readFileSync(
       'app/src/main/AndroidManifest.xml',
       'utf8'
@@ -161,7 +166,7 @@ function run(args, reject) {
     if (devices && devices.length > 0) {
       devices.forEach((device) => {

-        const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', packageName + '/.MainActivity'];
+        const adbArgs = ['-s', device, 'shell', 'am', 'start', '-n', applicationId + '/' + packageName + '.MainActivity'];

         console.log(chalk.bold(
           `Starting the app on ${device} (${adbPath} ${adbArgs.join(' ')})...`

I have pushed a PR  #8950  to solve this issue. I am using the advice given by @fkrauthan and am reading the package name from the final generated AndroidManifest.xml in the build directory. The real difficulty in the task is to figure out the path for the the generated manifest file as it depends upon the build type, product flavor as well the architecture that the build is run for.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-react-native-run-android-parsing-of-androidmanifestxml-wrong
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

Ammm... Isn't it in react-native cli?

No looks like this issue is still valid. I can't believe that no one accepted the PR that someone already made.

This thing is still alive? Im experiencing problems with this now, aswell are others: http://stackoverflow.com/questions/41771892/react-native-app-wont-start-when-using-applicationidsuffix
Also the productpain page is not working anymore: "Oops! We couldn't find the page you were looking for."

New product pains link: https://react-native.canny.io/feature-requests/p/android-support-varying-application-ids-for-different-build-variantsflavors

yep. issue still occurs, and it is annoying.


Speaker volume after turning back on is too low

Hi all,
Great plugin which has been working really well for me recently.
Have a small issue where if I turn off my bedroom Sonos one speaker via HomeKit using the switch service, upon power on again the volume is 1% and not the last state before turning off the speaker.
Funnily enough, my other speaker works perfectly when powered off and on(same volume state as when I powered off)
Is this something I need to set in the Sonos app? My bedroom speaker is an airplay device whereas the other is a play1 if that makes any difference.
Thanks

I don’t know, apparently my zone players are too old and don’t support AirPlay.  I suppose the player could keep a different volume for different inputs, or change the volume when automatically switching inputs, similar to the PlayBar switching to TV input.
If you cannot find a corresponding setting in the Sonos app, you could create a HomeKit scene that turns the player on and sets the volume, and use that instead of the switch.  You need to create the scene in Eve, but after that, it can be recalled from Apple’s Home app.


Schema v3

This epic is to capture all design, implementation, testing and documentation required for the next version of our linkage schema.

I guess I delete the milestone then...

Merged in


Search for article and get their replies in one go

Currently "search for article using text" and "get the reply using article ID" are separate steps.
Actually it's possible to combine the two queries into one:

Hope this helps simplifying the implementation :)

Another thing is that, 80% similarity can be achieved by supplying minimimShouldMatch:

Sorry that we did not provide enough documentation on the parameter. The param will be passed to more_like_this query, thus the format matches its official doc.

significantly helpful information, I will improve it when I got any chance. I deeply agree reduce the requests to confacts database is most important thing to do, will tag high prio for this issue. Thanks for pointing out 👍

Haha actually the server load on Cofacts side is ok. I think we can manage 3x of the current audiences for now, since the short-message filter is in-place and the server load has dropped significantly. Even in the most busy day (Dec. 25) the service is still running with decent responsiveness.

Actually the server is just running on a single 4GB-ram Linode. I am quite impressed with how the server could handle load.
Actually 2 simple GraphQL queries v.s. 1 nested query has very little difference. I think the latter actually costs more because it will load all replies for all search hits, while the former only loads replies for the most relevant article.
It's just that combining the 2 queries should both reduce the networking overhead between 美玉姨 and Cofacts API, and hopefully can drop the code complexity on 美玉姨's side. After all, using nested queries to fetch all data you want at once is the most prominent benefit of GraphQL, don't be shy to leverage it :)

@CarolHsu the PR https://github.com/CarolHsu/rumors-api-client/pull/9 tried to merge two queries into one.
I didn't utilize minimumShouldMatch because I'm not sure if that works as your expectation. Leave it to you.
@MrOrz thanks for the pro tips!


[Source Request]

PLEASE READ THIS
I acknowledge that:

I have checked that the extension does not already exist:

In the list of existing extensions in the application
In the multi-source spreadsheet: https://tachiyomi.org/extensions
By searching the GitHub repository for the extension and verify it does not appear in the code base

I have searched the existing GitHub issues and this extension does NOT have an open request
I will fill out the title and the information in this template

Note that the issue will be automatically closed if you do not fill out the title or requested information.
DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT

Source website

Name: anoBoy
Link: https://anoboy.live/home/
Language(s): Indonesia

Other details
Streaming Anime

Duplicate of #76

Link Update: https://<IP_ADDRESS>/

Duplicate of #76


[[FIX]] Handle multi-line template literal return statements

Closes #1814

@jugglinmike could you review this one? it was the quickest hack i could come up with to support multi-line tokens in return statements

Coverage increased (+0.0%) to 94.75% when pulling 67d6bef33a7a68a5a565b0752cb976ee4f3781be on caitp:issue-1814 into 33612f8cedce779d0d22571b72da4216d18bee9c on jshint:master.

Hey Cait! It looks like this is indicative of a larger problem that exists for all multi-line structures: https://github.com/jshint/jshint/blob/33612f8cedce779d0d22571b72da4216d18bee9c/src/lex.js#L1377-L1386
For instance, this also fails:
/* jshint multistr: true */
function foo() {
  return 'start\
    end';
};

I know your patch is intended as a quick hack, but what would you say to trying to resolve the problem a bit more generally? Here's what I'm thinking that would look like:
Multiline structures would need to track their last line and first line. I think it would make the most sense to change the current semantics around and have line refer to the first line. A new lastLine property (and maybe lastLineChar?) would be defined for multi-line structures only. (We could also try keeping line behavior as-is and defining a new firstLine property, but I think that would be more confusing.)
Do you think it would be that easy? Or maybe not and better to try in a follow up patch?

@jugglinmike in general, I don't think it is a problem. It is a problem for templates, because a single template token can span multiple lines. But as far as I'm aware, no other token fits that category

@caitp It's also a problem for multi-line string literals.

few extra bits added to work for string literals too... i think this can be generalized more cleanly, but i'll do that in a different patch

Coverage increased (+0.0%) to 94.75% when pulling c79498012812b03c3889047814186871461a0d16 on caitp:issue-1814 into 33612f8cedce779d0d22571b72da4216d18bee9c on jshint:master.


Clicking outside keyboard shortcut 'window' should dismiss it.

I had expected clicking outside the keyboard shortcut help screen would dismiss it, but it doesn’t.

Should probably have an X in the corner as well.

Fixed by #1960


Deploy the OSS Fabric Console to the Kubernetes Test Network

The feature/fabric-operations-console branch has some progress on an integration with the OSS Fabric Console.  This work is most of the way there but it needs a little bit of work to see it out the door.  Three factors complicating a landing into the Kube test network are:

OSS Console still has a dependency on the system channel.  The test networks, on the other hand, rely on the Channel Administration SDKs, and do not bootstrap the network with a system channel / genesis block.    The branch above runs through the integration by downgrading the network to bootstrap from a system channel, which is ... not ideal.

The Console requires a sequence of association actions to be performed immediately upon importing the test network into the GUI.  While this is manageable for the "test-network" (1x orderer + 2x peers), the typing burden necessary to associate identities for 3x orderers and 4x peers on the test-network-k8s is ... not ideal.

Fabric console makes extensive use of a Kubernetes Ingress, made available at the CONSOLE_URL, and tunneling through an Nginx controller to route traffic into the cluster from the web GUI.  For network routes coming "into" the console from the GUI, this works OK as traffic can be directed via an Ingress host alias to the appropriate service.   However, in some cases the network traffic - between pods - is redirected out to the host network, and back into the Fabric network over the ingress controller / nginx.  For systems that have a dual-homed, or multiple NICs, this is not a problem as the ingress controller can be bound to the external NIC and resolved via DNS.  For single-NIC systems, or in virtual Kubernetes environments such as KIND, it's virtually impossible to find a stable technique to identify a single DNS host entry that successfully resolves to the port binding the ingress.  The test branch relies on either hacking system DNS with dnsmasq, or clever use of wildcard DNS domains (e.g. my-server.nip.io, *.my-net.vcap.me, etc.)    While this works, it doesn't work "well enough" to provide a simple route forward on all environments.  This is a "non-issue" in the target k8s environments, largely based on OCP Route resources exposed to a NIC / DNS on the Internet.

Some recent developments make an integration with the OSS console viable.  The target user interaction is:

bring up a local test network and console running on a dev k8s:

./network up
./network channel create
./network console up

user logs in to<EMAIL_ADDRESS>user imports a zip archive generated by "console up"
user can immediately work with the test network - create channels, chaincode, query blocks, etc.

Regarding the "rough edges" above:

The network bootstrap script can support an optional code path to either bootstrap the orderers using a system channel, or use the channel admin APIs.  When OSS console supports the migration from system channel, this route can be removed.  It's fine if the user has to set something in the env, e.g. TEST_NETWORK_USE_SYSTEM_CHANNEL=true.

The console bulk import zip files have the ability to declare associations at import time.  Track down the required yaml / etc. and include these in the import archive.

With the option to run the kube test network on Rancher Desktop (k3s / containerd), the networking stack does NOT rely on the odd hacks embedded into KIND that are required for access to a TCP port bound to the host OS/NIC at host.docker.internal.  In other words, k3s and Rancher make it really easy to set a stable property for the CONSOLE_URL, routing traffic from within the cluster out to the ingress controller.

It's not a huge push but would be a nice way to highlight the ease of use and benefits from working with the OSS Console, all within the cozy confines of a local, single-node development workstation.  Couple this with Gateway and Chaincode-as-a-Service running locally within an IDE/debugger, and it's a short hop to a production blockchain.

cc: @varadgit @denyeart @mbwhite


Add generic NFS driver

Summary
A user expects to be able to work with generic NFS providers. The goal is to allow libStorage clients to mount network paths with custom mount options that may be necessary for optimizing connectivity. The benefit is that libStorage can become relevant to any storage platform that advertises NFS exports.
New Feature

User must be able to define custom mount options
Docker does this natively and so does K8
Can the “custom mount options” part of this be abstracted/generic enough to also work for ext4/XFS?
Does this require an introduction of a new driver, or can the integration driver be refactored to allow direct access to the OS mount functionality? Server interaction is not required for this -- do we - want to enforce it for any reason? (same question/situation as #473)
If server interaction is performed, do we just return success for attach/detach commands? Or should attach() perform a showmount -e command to verify that the NFS server has an export that is accessible to the client?

Goal:
Given an existing NFS server with valid export to a libStorage client, said client can call the libStorage Mount API with the remote network path and mount options (this implies dependence on #471)

Issue moved to codedellemc/rexray #962 via ZenHub


settings: Move presence-enabled setting to 'Account & privacy'.

The presence setting is more suited in 'Account & privacy'
section as it is not related to notifications in anyway
and resembles privacy of user by allowing user to hide
his status of being online.

GIFs or screenshots:

A follow-up would be to take it out kf notification settings in backend and maybe change the API endpoint for changing this setting too.

Can we add a /help/ link to the the documentation on how presence works?  I think that'd be helpful.
Re: API, I think ultimately we'll want to just have a single /settings endpoint rather than separate ones for display/notifications, which is basically a historical artifact; for that reason I don't think it's worth spending time on moving settings between endpoints to match the UI.

Hmm, I am not sure where to add the help link. We are using the Privacy heading and do not have any sub headings. And keeping it with the actual setting might look odd.

@alya thoughts on that question?

Can we try adding it at the end of the option text? I think that's the most reasonable place to put it.

Hmm this looks better than I thought initally, any feedback?

Yeah, that looks great, merged, thanks @sahil839!


CSS colors: both fg & bg must be explicitly defined

This is a Bug Report

Problem:

Proposed Solution:
Both fg & bg must be explicitly defined
Page to Update:
https://kubernetes.io/...

/remove-lifecycle stale

Is any update there?

I'll mark this as
/area web-development
@532910 nearly all contributions to Kubernetes are from volunteers. So progress here pretty much depends on someone looking for an issue to pick up and then contributing a fix
That label might help make it a bit more discoverable.

Looks fine now.


Vscode opens removed file always

VSCode Version: 1.46.1
OS Version: Ubuntu 20.04

Description:
Hi, I have a strange problem with vscode. I removed a file from my folder and when I open vscode it opens that removed file all the time.
When I open vscode in a specific directory, vscode opens twice, once where I wanted and second with the removed file.
If I open normally (without specifying folder or project) that fille will appears in vscode.
That file is unsaved (according to vscode) but when I save it, vscode still opens it on start.
It's really hard to reproduce (or even no-reproducible) because I have vscode on Windows 10 and the second laptop with ubuntu 20.04 and this situation does not occur.
I tried to clear cache (from vscode and removed from folders Cache and CachedData
Steps to Reproduce:

Remove file
Open vscode

Does this issue occur when all extensions are disabled?: Yes

That file is unsaved (according to vscode) but when I save it, vscode still opens it on start.

VSCode will always restore files that are not saved, we call this "hot exit". Can you check the log what happens when you save the file or close it without saving?

Hi @bpasero
I don't know if render2.log is the correct one:
[2020-07-03 13:19:25.151] [renderer2] [error] Error: [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat '/home/moleszek/scripts/python/if_4c.py'
[2020-07-03 13:19:25.151] [renderer2] [error] [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat '/home/moleszek/scripts/python/if_4c.py'
[2020-07-03 13:19:25.929] [renderer2] [error] Unable to write file 'vscode-userdata:/home/moleszek/.config/Code/User/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519' (NoPermissions (FileSystemError): Error: EACCES: permission denied, open '/home/moleszek/.config/Code/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519'): Error: Unable to write file 'vscode-userdata:/home/moleszek/.config/Code/User/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519' (NoPermissions (FileSystemError): Error: EACCES: permission denied, open '/home/moleszek/.config/Code/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519')
    at e.writeFile (file:///snap/code/35/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1692:701)
[2020-07-03 13:20:14.990] [renderer2] [error] Error: EACCES: permission denied, unlink '/home/moleszek/.config/Code/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519': NoPermissions (FileSystemError): Error: EACCES: permission denied, unlink '/home/moleszek/.config/Code/Backups/1593592716811/file/ac17be7c8d032294d4f0f0dad12fa519'
    at Object.d [as createFileSystemProviderError] (file:///snap/code/35/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1642:38)
    at r.toFileSystemProviderError (file:///snap/code/35/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1713:184)
    at r.delete (file:///snap/code/35/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1709:453)

but according to that line
[2020-07-03 13:19:25.151] [renderer2] [error] Error: [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat '/home/moleszek/scripts/python/if_4c.py'

there is no file like if_4c.py and this is correct because I've removed it.
However, it still opens in vscode (when I save it and open again vscode, it still appears as a unsaved file)
Maybe, there is a lack of permission (I'm not super Linux user)

Yeah that sounds like the issue, somehow VSCode is not able to remove the backup in /home/moleszek/.config/Code/Backups. Can you manually remove it?

Yes, I can remove it and the problem gone ;)

Thanks, @bpasero for help ;)


[jenkins] feat: add jenkins support

Add Jenkins pipeline support.  This reuse the shared library pipeline.

I am afraid I have no experience with Jenkins, I won't be able to provide a meaningful review.
If the CI works and it integrates nicely with GitHub... I won't complain 😊


Check if more than one selector is created

Tested: make test

/assign @adrianludwin
/assign @yiqigao217

/lgtm
/hold cancel

tracked at #1123


misc/makerelease: move to sub-repository

This issue is a proposal that we create a new "go.release" sub-repo and put
makerelease and associated files there.

Rationale:

The makerelease tool reads in various files from misc/makerelease during execution.
Because the makerelease tool is inside the Go repository it is entwined with our release
process. Changes are usually made to makerelease around release time, and it's not
always clear whether the changes should be made to the main or release branches. This
ambiguity would be resolved entirely by keeping the makerelease tool entirely separate
to the go repository.

Any objections?

Sure, sounds like the build subrepo would work.

We should just delete it, since we're moving to using x/build/cmd/release anyway.

It will be deleted when the tools/cmd/release tool is done.
On 7 July 2015 at 13:28, Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

We should just delete it, since we're moving to using x/build/cmd/release
anyway.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/8472#issuecomment-119310026.


EmbedReport in HomeController in App Owns Data project is failing

File: HomeController.cs
Method: EmbedReport(string username, string roles)
Issue:
var authenticationResult = await authenticationContext.AcquireTokenAsync(ResourceUrl, ClientId, credential);
This method is giving AADSTS70002: The request body must contain the following parameter:
'client_secret or client_assertion.
Are supposed to use different approach?

Please register AAD application as native app and try again.

Hi,
I have registered my app as Native App already


Error in Thesaurus logic

The built-in thesaurus function returns wrong results. Instead of list of synonyms it is returning (very log) list of fuzzy words.
Steps to reproduce the error:

Download thesaurus file from Moby Project
Convert to proper format perl -ple 's/\r?\n|\r/\n/g' mobythes.aur > mobythes.txt
Point vim to mobythes.txt set thesaurus+=/home/jsmith/mobythes.txt
Open new file in vim, enter insert mode, type word 'return' and press <C-x><C-t>

The result is a very long list of words as in the screenshot (3045 words).

This is not correct result. To see what should be the correct result open mobythes.txt file in Vim and do /^return. You will find a line which is containing expressions (not single words) separated by commas(there is 415 of them not 3 thousand). They are synonyms to 'return' which is first word in this line. They should be presented each as a single entry.
return,CRT spot,DM display,Doppler signal,IF signal,IM display,RF echoes,about-face,acknowledge,acknowledgment,action and reaction,advent,advert,afford,alternate,alternation,amends,answer,answer back,answering,antiphon,arrival,
...
wheel around,winnings,witty reply,witty retort,yes-and-no answer,yield

Apparently Vim is returning all single words from all lines containing word return.  And this is wrong result.
That's it.
If you continue with these error reproduction steps and delete the last character you suddenly get much shorter list. I don't understand where these results come from. But this behaviour isn't  necessarily a bug.
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar 30 2017 20:20:13)
MacOS X (unix) version
Included patches: 1-525

The format of that file is not what is expected.  The thesaurus option expects words separated by non-word characters.  This file has comma separated terms, which can include a space.
Also, the lines are too long, Vim only supports up to 512 characters.
Also also, Vim uses all lines where the word matches, while the intention of the file is to only match the first word.
Making this work requires a different implementation of the thesaurus implementation.

Oouh, that explains the "wrong" results I have been getting. I am sorry.
However the idea of thesaurus is that both input and output could be multiple words. We have different synonyms for "return", "return to" and "tax return". And results could be multiple words as well (up to 7 words in Moby Thesaurus).
Moby Thesaurusu is free and the largest. There is some frustration bubbling on the Internet about the current thesaurus login in VIM.

Oouh, that explains the "wrong" results I have been getting. I am sorry.
However the idea of thesaurus is that both input and output could be multiple words. We have different synonyms for "return", "return to" and "tax return". And results could be multiple words as well (up to 7 words in Moby Thesaurus).
Moby Thesaurusu is free and the largest. There is some frustration bubbling on the Internet about the current thesaurus login in VIM.

It would be a bit of work to support the comma-separated format.
Perhaps entries in 'thesaurus' could have the addition "@comma", so that
the format is specified per file.
Would also have to fix the fixed maximum line length.
--
hundred-and-one symptoms of being an internet addict:
255. You work for a newspaper and your editor asks you to write an
article about Internet addiction...in the "first person."
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

using the link provided in :h thesaurus (https://github.com/vim/vim/issues/629#issuecomment-443293282) i am encountering the error described by chew-z when this issue was initially opened:

in order to diagnose the issue i created an extremely simple thesaurus file, and the completion seems to mostly work:

is it intended that words on the lines following the line that begins with our word be in the completion list?
:h thesaurus mentions "Each line in the file should contain words with similar meaning, separated by non-keyword characters (white space is preferred)."

does this mean that there are other "non-keyword characters" that can be used aside from white space?
if so, could it be possible to include phrases (with white space) in our list of similar words?

why is the provided thesaurus file not working correctly? from what i can tell it is formatted exactly as my test thesaurus is
if it is a matter of formatting, how exactly should the file be formatted?

thanks

poking around some more, if my file is formatted correctly, then i think my second screen shot is unintended behavior:

CTRL-X CTRL-T

Works as CTRL-X CTRL-K, but in a special way. It uses
the 'thesaurus' option instead of 'dictionary'. If a
match is found in the thesaurus file, all the
remaining words on the same line are included as
matches, even though they don't complete the word.
Thus a word can be completely replaced.

the remaining words on the same line are included as matches
if my file is incorrectly formatted please let me know.
if that is the issue then h: thesaurus is not very clear

Can this issue be closed?
Since the patch 8.2.3520, Vim provides :help 'thesaurusfunc' which gives much more control over the suggestions given by C-X C-T, and which can be leveraged to bypass all the issues mentioned in the OP.
There is an example at :help compl-thesaurusfunc.  It relies on aiksaurus(1).  If for some reason, the OP really want to use a file instead, here is how they can get the desired results:
vim9script

var synonyms_file: string = '/tmp/synonyms.txt'
&thesaurus = synonyms_file
var lines: list<string> =<< trim END
    return,CRT spot,DM display,Doppler signal,IF signal,IM display,RF echoes,about-face,acknowledge,acknowledgment,action and reaction,advent,advert,afford,alternate,alternation,amends,answer,answer back,answering,antiphon,arrival
    wheel around,winnings,witty reply,witty retort,yes-and-no answer,yield
END
lines->writefile(synonyms_file)

&thesaurusfunc = 'Thesaurusfunc'
def g:Thesaurusfunc(findstart: bool, base: string): any
    if findstart
        return searchpos('\<', 'bnW', line('.'))[1] - 1
    endif
    var l: list<string> = synonyms_file->readfile()
    if l->empty() | return [] | endif
    var idx: number = lines->match('^' .. base)
    if idx == -1 | return [] | endif
    var synonyms: list<string> = lines[idx]->split(',')
    return synonyms
enddef

I think all these todo items can be removed:

Many users don't like 'thesaurus' to match so many words. (#4667, #1611)

when the match with the first word is partial, don't add other words on that
line.
support other file formats, such as comma separated.  Indicate by a prefix
to the file in the 'thesaurus' option.
'threglookexp' option: only match with first word in thesaurus file.
(Jakson A. Aquino, 2006 Jun 14)

lines 661-667 in runtime/doc/todo.txt.
'thesaurusfunc' can be used instead to get the same results.


您好  看了文档结合代码还是没明白权限该如何写

Question
How to use component s-table paging
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.


Unable to reverse lookup role list with a principal name matching the wildcard

When adding members to a role, it is possible to use wildcards in the member names. However, even when executing getPrincipalRoles with a principal name that matches the wildcard, it is not possible to retrieve a list of roles.
For instance, when a member with a wildcard, such as athenz.test-service* , is added to athenz:role.test-role , executing getPrincipalRoles with the principal name athenz.test-service-2 does not return athenz:role.test-role as a role to which the principal belongs. Instead, it results in a 404 error.
The likely cause of this issue, we believe, is that the principal_id of athenz.test-service* and athenz.test-service-2 being different.
https://github.com/AthenZ/athenz/blob/bfa83a8dae13e8fc2e0ebe219037a979c1ad7a1f/servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java#L250-L259

Yes. The lookup roles principal api only returns the roles that that given principal is explicitly included. It cannot take into account wildcards. To provide such functionally the system needs to go through all the principles with wildcards and see which one matches the given one.
We actually discourage the use of wildcards. There are only a few cases where we actually expect the principal to include wildcards, a primary one being ‘*’ to allow everyone.
A better choice if you want to take into account wildcards is to use the role access api in ZTS which handles the principal in a given domain only and does process wildcards as expected.

Thank you for your response. I understand and will close this now.


[BUG] OS and k3OS versions are reported incorrectly

Describe the bug
Based on version history https://github.com/rancher/harvester-installer/commit/c462023fc110b49d38e0fe84fdab8cfa48855ca3 k3OS version on Harvester v0.1.0 should be at least "v0.19.4-dev.5" but now it is reported as "v0.1.3-dirty" which is harvester-installer version, not actual k3OS version.
Other issue is that on /etc/os-release is describing k3OS when it should describe Harvester and it's version (or example say k3OS - Harvester edition to clarify difference between these two.
To Reproduce

Install Harvester v0.1.0
Login to console
Run these commands:

cat /etc/os-release
k3os --version
k3s --version

Expected behavior
OS and version informations are clear and unambiguous.
Environment:

Harvester ISO version: v0.1.0
Installation Mode: ISO
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Surface Pro

Validated on master-head


Need shortKey in plist

See http://robofont.com/documentation/building-tools/extensions/extension-file-spec/#menu-item-description. Without this, Mechanic will choke.

thanks


Setup the env before spawn the go server, fix #1513

Sorry, seems to mess up with the previous pull request.
I think there should be a check for --env=prod/stage/dev before setup the env variable; but I didn't find a easy way to get that --env variable.

LGTM
thanks!