proposal: cmd/go: import the latest version by default if no version specified

What version of Go are you using (go version)?

$ go 1.15

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
mac os , linux and windows
go env Output
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/Users/XXX/go/bin"
GOCACHE="/Users/XXX/Library/Caches/go-build"
GOENV="/Users/XXX/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/XXX/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/XXX/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/35/83b9r4213sj5pvm379c5cb0m0000gn/T/go-build349298857=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Hi, we are Oracle SDK team, currently we are developing new services and sometimes also need to update the existing service APIs, so making breaking changes are somehow unavoided, after we enabled Go Mod feature, we always need to add "import...../xxxxverson" in each go file, the problem is when users using our SDKs, once we do breaking change, they are also impacted, should update all their go files for import part, this is not very user friendly. I understand specifying the version should be necessary, however, it would be nice if don't specify the version,but by default just point to the latest version, otherwise, it is really painful for us to follow go version bump policy -

A semantic version has the form vMAJOR.MINOR.PATCH.

Increment the MAJOR version when you make a backwards incompatible change to the public API of your module. This should only be done when absolutely necessary.

Increment the MINOR version when you make a backwards compatible change to the API, like changing dependencies or adding a new function, method, struct field, or type.

Increment the PATCH version after making minor changes that don't affect your module's public API or dependencies, like fixing a bug.

https://github.com/oracle/oci-go-sdk/blob/master/analytics/analytics_client.go#L15
What did you expect to see?
import ( 	"context" 	"fmt" 	"github.com/oracle/oci-go-sdk/common"   //it should work and point to github.com/oracle/oci-go-sdk/v35/common 	"github.com/oracle/oci-go-sdk/common/auth" 	"net/http" )
What did you see instead?
error reported, no version specified.

Maybe don't release a major version every week.
Alternative: Use version 0 which explicitly makes no guarantees on API stability.

We tried to avoid doing breaking change, however, we have so many services adding new features, which is not easy to control breaking changes, but we also need to follow Go version bump rules, have to do major version bump for breaking changes. If we don't import version in our xxx.go files, the released packages can't be added to https://pkg.go.dev/github.com/oracle/oci-go-sdk?tab=versions, so it is really painful for users to use. I think not only us, but others also have the same problem, I checked some other cloud go sdk, they also have to add breaking changes, however, they did minor and patch version bump, did not follow Golang version bump rule, so I really hope Golang can resolve this, thanks!

Should this issue be considered a proposal? If so please do:

@gopherbot, please add labels Proposal,modules

@D1CED , thank you so much!

@ianlancetaylor can this issue be added to the proposal milestone and slot into the Incoming proposal project section.
This proposal should also be retitled to something like: proposal: import current version by default if no version specified
But I think this needs some more clarification by the author.
Any immediate thoughts?
Thanks.

Do you mean you want consumers of your library to be able to just automatically get the latest version at all times, or just that your library doesn't have to refer to itself using the /v{num} format inside its own packages?

Since you ask, I'll make this a proposal, but I don't see how it could possibly work.  In Go different packages must have different import paths.  Permitting the same import path to mean different versions of a package can't work.

CC @bcmills @jayconrod

Related: https://github.com/golang/go/issues/40323

This goes against a key design goal of modules: building with a reproducible set of dependency versions. If a module author releases a new major version with incompatible changes, their users shouldn't immediately be broken by those changes.

we are developing new services and sometimes also need to update the existing service APIs, so making breaking changes are somehow unavoided

Can you give more detail about why breaking changes are unavoidable? This proposal seems to be aiming to undo an explicit design element of #24301, and revisiting that design means that we need evidence that was not already taken into account when the decision to accept that proposal was made.
Looking at the changelog in https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md, I see that the breaking changes seem to fall into a number of categories, many of which are addressed (directly or indirectly) in https://blog.golang.org/module-compatibility.
To take a few examples:

Header Parameter Etag in Operation ListAppCatalogListingResourceVersions response was removed from the Core service
Property VnicId in model Ipv6 was removed from from the Core service
Const GetObjectArchivalStateAvailable was removed from operation GetObject response from the Object Storage service

Why did these need to be removed, instead of deprecated?

Property IdcsAccessToken in model CreateBlockchainPlatformDetails changed from optional to required in the Blockchain Platform service

Why was it necessary to make that property required? If it was necessary in order to reduce user error (perhaps from users forgetting to set that property when appropriate), why was it done as a breaking change to an existing model rather than, say, deprecating the old model and introducing a new, corrected one?

Method GetLifecycleState()'s return type in the interface ConfigurationSourceProviderSummary was changed from ConfigurationSourceProviderSummary to ConfigurationSourceProviderLifecycleStateEnum

Why was the type of the existing method changed, rather than introducing a new method with a different name and return type and deprecating the existing method?

All of these changes look to me like very reasonable things to do in an evolving, unstable API — but an evolving, unstable API would be major version 0, not a “stable” major version. (See https://semver.org/#doesnt-this-discourage-rapid-development-and-fast-iteration.)
For a Go package at a stable major version, the expectation is that the package author will make a significant effort to avoid unnecessary breaking changes, even if that means keeping around parts of the API that would otherwise be deprecated or redundant, or providing shims to translate from an old way of doing things to a newer way.

A couple questions for clarification:

Am I right in the assumption that an import would behave differently when it is used in a package of the current module versus an external module?
How would that interact with importing a version v0 or v1 of the same module?
How would that interact with releasing a newer version?

Examples:
Lets assume the latest major version of mymod is v5.

-- mymod/mypkg.go@v5 --
import "mymod/otherpkg" // this would resolve to "mymod/v5/otherpkg"

-- othermod/mypkg.go --
import "mymod/otherpkg" // this would resolve to "mymod/v1/otherpkg"

Now we release a new major version of mymod (v6).
-- mymod/mypkg.go@v6 --
import "mymod/otherpkg" // resolves to "mymod/v6/otherpkg" as it is the latest
-- mymod/mypkg.go@v5 --
import "mymod/otherpkg" // applying 'latest' literally this resolves to "mymod/v6/otherpkg" which breaks this version

All of these changes look to me like very reasonable things to do in an evolving, unstable API — but an evolving, unstable API would be major version 0, not a “stable” major version.

To be clear, "stable" and "unstable" are not well-defined terms; even the links to the SemVer FAQ make this clear. They are relative and context-dependent. It is entirely possible that a major version bump each week means a project in one domain is "stable", and that a major version bump every six months means a project in another domain is "unstable".
The definition you're using here is toward one end of the spectrum, but not every module consumer requires, or even benefits, from this stricter definition of stability. And because Go modules has a monopoly claim on package management in the Go ecosystem, it is not free to assert these more specific definitions of subjective terms, without artificially excluding participating in the ecosystem.


Generate library for beyondcorp.googleapis.com

This should live in google/cloud/beyondcorp/.  There are multiple services, all in:
https://github.com/googleapis/googleapis/tree/master/google/cloud/beyondcorp

The only bit remaining is supporting Bazel on Windows, which is blocked on external bugs (cl.exe does not support long paths, or Bazel generates too long of a path, or the proto names are too long, take your pick).

I filed something with the Bazel team: https://github.com/bazelbuild/bazel/issues/15961


Unnecessary code in code playground.

There is unwanted code in code playground which prints this statement.

The return statement appears at top left corner.

Thank you for reporting this issue
Closed as fixed


Code server must be upgraded and drop dependency on Node.js 16

Currently, code-server (and openvscode-server) depends on Node.js 16 in nixpkgs, for the upcoming release of NixOS 23.11, this dependency must be dropped, and all upgrades must be performed to Node.js 18.
From what I see on https://github.com/coder/code-server — Node.js 18 is supported as an engine.
Otherwise, those programs are to be dropped.
Please pick up the pieces @offlinehacker @henkery @code-asher.
cc @figsoda

Drop will be performed in https://github.com/NixOS/nixpkgs/pull/264358.


UI of CAV Flow View #1: Sidemenu + Navbar

Since the CAV UX is ready, we are able to start building the UI design of CAV View "Sidemenu + Navbar". Referred by the attached image or this link

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.
Belonging to Epics:

[EPIC] #449 - CAV Flow View #1: Sidemenu + Navbar

@ashwinkjoseph I'm confused. Is this related to UI Design or to the actual implementation?


Getting UA0002 with no clear explanation why and what to fix

Describe the bug
When running upgrade assistant get following:

Diagnostic UA0002 with the message This type is not supported on .NET Core/.NET 5+ and should be replaced with a modern equivalent. generated

And it is not clear, what type, why. I've scanned through migration guide and could not find anything related.
To Reproduce
Create new web project:
dotnet new web

and add class into Program.cs:
public class OverrideSuccessResponseCode : ResultFilterAttribute, IApiResponseMetadataProvider
{
    public int StatusCode { get; }
    public Type Type { get; } = typeof(void);

    public OverrideSuccessResponseCode(int statusCode) => StatusCode = statusCode;

    public override void OnResultExecuted(ResultExecutedContext context)
    {
        if (context.HttpContext.Response.StatusCode == (int)HttpStatusCode.OK)
        {
            context.HttpContext.Response.StatusCode = StatusCode;
        }
    }
    void IApiResponseMetadataProvider.SetContentTypes(MediaTypeCollection contentTypes)
    {
    }
}

After running
upgrade-assistant.exe analyze .\test-upgrade.csproj

You should get:
PS C:\temp\test-upgrade> upgrade-assistant.exe analyze .\test-upgrade.csproj
-----------------------------------------------------------------------------------------------------------------
Microsoft .NET Upgrade Assistant v0.3.310801+057ffba0656270dc5d83c015748ac56daed55886

We are interested in your feedback! Please use the following link to open a survey: https://aka.ms/DotNetUASurvey
-----------------------------------------------------------------------------------------------------------------

[08:26:03 INF] Loaded 6 extensions
[08:26:03 INF] Using MSBuild from C:\Program Files\dotnet\sdk\6.0.201\
[08:26:03 INF] Using Visual Studio install from C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional [v16]
[08:26:05 INF] Writing output to C:\temp\test-upgrade\AnalysisReport.sarif
[08:26:05 INF] Recommending executable TFM net6.0 because the project builds to an executable
[08:26:06 INF] Reference to .NET Upgrade Assistant analyzer package >(Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers, version 0.3.310801) needs to be added
[08:26:07 INF] Reference to Newtonsoft package (Microsoft.AspNetCore.Mvc.NewtonsoftJson, version 6.0.4) needs to be added
[08:26:07 INF] Running analyzers on test-upgrade
[08:26:08 INF] Identified 1 diagnostics in project test-upgrade
[08:26:08 INF] Diagnostic UA0002 with the message This type is not supported on .NET Core/.NET 5+ and should be replaced with a modern equivalent. generated

upgrade-asstant.clef file contains line:

{"@t":"2022-04-14T05:26:08.3477296Z","@mt":"Diagnostic {Id} with the message {Message} generated","Id":"UA0002","Message":"This type is not supported on .NET Core/.NET 5+ and should be replaced with a modern equivalent.","SourceContext":"Microsoft.DotNet.UpgradeAssistant.Steps.Source.DiagnosticAnalyzerResultProvider"}

AnalysisReport.sarif file contains:
{
      "tool": {
        "driver": {
          "name": "API Upgradability",
          "semanticVersion": "0.3.310801",
          "informationUri": "https://docs.microsoft.com/en-us/dotnet/core/porting/upgrade-assistant-overview",
          "rules": [
            {
              "id": "UA0002",
              "fullDescription": {
                "text": "Types should be upgraded"
              },
              "helpUri": "about:blank"
            }
          ]
        }
      },
      "results": [
        {
          "ruleId": "UA0002",
          "message": {
            "text": "This type is not supported on .NET Core/.NET 5+ and should be replaced with a modern equivalent."
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "file:///C:/temp/test-upgrade/Program.cs"
                },
                "region": {
                  "startLine": 20
                }
              }
            }
          ]
        }
      ],
      "columnKind": "utf16CodeUnits"
    }

From this information it is not clear what and how to fix.
Running assistant with upgrade command does not change source in any way.

@dziedrius Thanks for the issue, makes sense we will look into making this warning more actionable.

I'm also getting that error but only on VSCode, doesn't show on VS2022 (17.1.6)
I also tried using the dotnet upgrade-assistant and the *.sarif file generated points to the same issue. We're talking about plain old controllers and public methods being flagged with that warning
"ruleId": "UA0002",           "message": {             "text": "This type is not supported on .NET Core/.NET 5+ and should be replaced with a modern equivalent."           }
any ideas of what this is about would be very appreciated.


Issue with PoolSettingsProvider and PoolStatisticsProvider after failover

After a fail over, there is no longer pool server side stats nor capabilities.

to provide more context : we found a regression in ehcache3, where ehcache server stats do not show up after a fail over.
In tc platform, we already have a test for stats after failover, this is why I believe this issue is particular to ehcache 3

I'll wait for @AbfrmBlr to complete our work for https://github.com/ehcache/ehcache3/pull/2293 first.
He has planned on changing some IT tests so I will take his updates before adding yours and see what's wrong.

@anthonydahanne @myronkscott : I think there's a bug in voltron. Some addNode() calls that we are doing are discarded by platform and never received from the IStripeMonitoring interface


Modifier -> SwiftUI -> View styles: presentedWindowStyle(_:)

Doc: https://developer.apple.com/documentation/swiftui/view/presentedwindowstyle(_:)

[ ] Swift implementation
[ ] Elixir implementation

According to the @supernintendo @carson-katri @shadowfacts we won't support this


Better first code example

For reference:
primes = filterPrime [2..]
  where filterPrime (p:xs) =
          p : filterPrime [x | x <- xs, x `mod` p /= 0]

Most developers are not interested in calculating prime numbers.
It's like saying "this is just an academic toy language for math problems"
I think the where syntax is not the best part of haskell.

When you start reading you're like "mh, from which unqualified import was that function imported" until you reach the where: "oh, it's defined here.
After I've already used it :see_no_evil:".
So definitely not a syntax feature I would present upfront.
List comprehension is kind of cryptic and there are more beautiful ways to write the same code

I think we should rather present a short example where there is maybe a short function to generate some value (map, filter, or similar) and then do something IO related. E.g. http request, database read, …. Maybe use https://archives.haskell.org/projects.haskell.org/diagrams to generate a graphic.
People often have the notion that Haskell is too academic (https://news.ycombinator.com/item?id=8803128), therefore the first example should exactly counter this and not support it like at the moment.
Other languages have better examples. E.g. https://racket-lang.org does some GUI and web server stuff, https://elixir-lang.org presents messages and fault tolerance.

Hi @adius and thanks for the comments. The example on the front page is something that has gone through many variations, and I fear it will always be something over which people will bikeshed.
See:

https://github.com/haskell-infra/hl/pull/8
https://github.com/haskell-infra/hl/issues/46
https://github.com/haskell-infra/hl/issues/87
and I think some others that I'm missing from a quick search.

If you want to present some alternatives and you can get a fair backing behind one of them, I wouldn't necessarily be opposed to changing the example (I can't speak for everyone else on the team). But please do check out the above discussions and understand the reasons why this example has been chosen. This discussion is not a new one by any means :).

Haha, thanks for the references. I wasn't aware ...
I pitched the idea already in the functional programming slack and folks seemed to agree that other languages have better examples and that the current one is playing into the hands of the sceptics.
But yeah, really coming up with a better example is the hard part 😅. I'll mull over it the next weeks. Hopefully I'll get an enlightenment =P

Going to close this for now to bump it out of my queue, then.


Switch from nose to vanilla unittest (#78)

Fixes #78

Thanks @zware!  I'll apply your patches in Debian until upstream applies them.

Quick question, @zware - do your series of patches have the same licensing conditions as the original software? Thank!

Hi Zachary and all, thanks so much for your contribution. In 2019 we created a startup building on these software packages. It was acquired in 2020 and I was away working full time in industry. I just came back and am rebuilding my research group. Hence there has been very little work on these in the past few years.
We will improve these packages, processing your pull requests, and more. This may take us a few weeks. But we will get it done and release a new version, as these packages have proven very useful (been used in many companies). Thank you for your patience, and if you have more to contribute, please do not hesitate to send it our way. Regards, AnHai Doan (UW-Madison).


Documentation page next/previous buttons result in 404 in functions section

The referenced markdown files do not exist and so the "Next" and "Previous" buttons on the bottom of pages surrounding them result in 404 Not Found errors
Motivation
Avoid 404 Error when navigating documentation.
Modifications
Removes references to files which do not exist.
Verifying this change
This change is a trivial rework
Does this pull request potentially affect one of the following parts:
None
Documentation
Bug fix only

@slominskir Can you please fix the sidebar in the versioned_docs as well?


The login/signup option is too close to the dark mode switch

Is your feature request related to a problem? Please describe.
The sign up logo and dark mode toggle are touching, ruining the UI
Describe the solution you'd like
add a padding between the toggle and the login logo

ANSHIKA-26 please assign this to me

a pr is fixing this


DRM Support

I have this m3u format :
#EXTM3U
#KODIPROP:inputstream.adaptive.license_key=[licence-server]
#EXTINF:-1 group-title="Noticias",example
https://URL/example.mpd
this m3u work in DRM player support (widevine).
i put this meu in XTEVE and dont work.
help me please.
thanks

Anyone go update on this? All i can find on internet is that kodi supports it but no way how to make it work with xteve. I don't want kodi on my server. Is it possible? i found that ffplay has some cenc_decryption_key option that might work

xTeVe will not undergo any further modifications. Please consult one of the forks with a active dev. Sry


Fix #5620 issue about join_use_nulls setting

Make setting join_use_nulls get no effect for types that cannot be inside Nullable
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):

Bug Fix

Short description (up to few sentences):
Make setting join_use_nulls get no effect for types that cannot be inside Nullable

Test is needed


How to set a field to unique ? for example e-mail

I can not figure how to set a variable to unique value.
For example usernames, emails...
Is there any way to do it ?

were you able to do it?

I don't remember clearly but I think it will be useful
override suspend fun provideUserCollection(): CoroutineCollection<User> {         val userCollection:CoroutineCollection<User> = provideDatabase().getCollection()         userCollection.createIndex("{'username':1}",IndexOptions().unique(true))         return userCollection     }


svkbd: init at 0.3

Motivation for this change
svkbd - Simple Virtual Keyboard.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Reverted in c8870b462514eb27bac22379de26a4a1b7f22589.
svkbd was already added in 2fab56654ba1017ef81695d0c8e83edc55045c7e and that package is even better arguably. Most significantly though having the svkbd attribute defined twice in all-packages.nix causes a failure at parse time.
Curiously, @SuperSandro2000 even merged both PRs.

I was just victim of stale ofborg checks. :P

Curiously, @SuperSandro2000 even merged both PRs.

I can't remember all PRs I have merged. There are just to many.


x/tools/cmd/stringer: "declared but not used" even though variable is used

What did you do?
Run go generate on the following program:
package main

/*
struct A {
	int flag;
};
*/
import "C"

//go:generate stringer -type Flag
type Flag int

const (
	FlagSet Flag = 1
)

func main() {
	var flag = FlagSet
	A := C.struct_A{
		flag: C.int(flag),
	}
	_ = A
}

What did you expect to see?
I expect go generate to run without error.
What did you see instead?
stringer: checking package: stringercgo.go:18:6: flag declared but not used
stringercgo.go:10: running "stringer": exit status 1

System details
go version go1.8.1 linux/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/joe/gop"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build547335153=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
GOROOT/bin/go version: go version go1.8.1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.8.1 X:framepointer
uname -sr: Linux 4.8.0-49-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.23-0ubuntu7) stable release version 2.23, by Roland McGrath et al.
gdb --version: GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.04) 7.11.1

@alandonovan, @griesemer, @mdempsky, is this because go/types doesn't understand cgo?

@bradfitz Yes, that's the cause. gotype reports the same error. That said, go/types could probably do better here.
Temp. work-around: _ = flag .

Thanks for the confirmation.
I'm doing exactly that workaround :)


Hi, is there a base with players of other rarity?

Hi, is there a database with players by rarity?
Like this one:
https://eafc25.content.easports.com/fc/fltOnlineAssets/25E4CDAE-799B-45BE-B257-667FDCDE8044/2025/fut/items/web/players.json

No.


Fastq file has read bases as N

Hi,
I am running the UnifiedConsensusMaker.py on the unaligned bam file generated by Picard FastqToSam.
I used taglen as 3 becuase the UMI is the first three bases of the data read for both read 1 and read 2.  The actual data read starts at Base 6 for both read 1 and read 2 so I used the --spacerlen as 2.
I used this command to run:
python ~/Git_Repos/Duplex-Sequencing/UnifiedConsensusMaker.py --input $name.unaligned.bam --prefix $name --taglen 3 --spacerlen 2
I get three outputs from running this command. First, a $name_temp.sort.bam file and 2 fastqs. My question is: Is this the bam file after collapsing? If so, I can see all the reads in this bam. However, my fastq 1 and 2 both have N's as the bases in my reads. Also their sizes are very small (~2015 reads), whereas my bam is pretty huge ~2.2 GB. Is there something that I am doing wrong. Can you please help me fix the issue.
Thank you.

I strongly suspect that you don't have enough tag diversity. You only have, at best, a total of 4^6=2048 possible tag sequences. When consensus calling takes place it almost certainly grouping unrelated reads together which leads to high numbers of N's you're seeing.

On May 8, 2017, at 2:48 PM, abolia<EMAIL_ADDRESS>wrote:
Hi,
I am running the UnifiedConsensusMaker.py on the unaligned bam file generated by Picard FastqToSam.
I used taglen as 3 becuase the UMI is the first three bases of the data read for both read 1 and read 2. The actual data read starts at Base 6 for both read 1 and read 2 so I used the --spacerlen as 2.
I used this command to run:
python ~/Git_Repos/Duplex-Sequencing/UnifiedConsensusMaker.py --input $name.unaligned.bam --prefix $name --taglen 3 --spacerlen 2
I get three outputs from running this command. First, a $name_temp.sort.bam file and 2 fastqs. My question is: Is this the bam file after collapsing? If so, I can see all the reads in this bam. However, my fastq 1 and 2 both have N's as the bases in my reads. Also their sizes are very small (~2015 reads), whereas my bam is pretty huge ~2.2 GB. Is there something that I am doing wrong. Can you please help me fix the issue.
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for replying. Is there a work around this problem where it doesn't group unrelated reads. Ideally, it should only group reads that have same barcode and start. And shouldn't it print out all the singletons still as singletons?
Thank you.

You'll want to use the version in the Nature Protocols paper which can be found in the folder of the same name.

On May 10, 2017, at 7:26 AM, abolia<EMAIL_ADDRESS>wrote:
Thanks for replying. Is there a work around this problem where it doesn't group unrelated reads. Ideally, it should only group reads that have same barcode and start. And shouldn't it print out all the singletons still as singletons?
Thank you.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Great. I will try that.
Thank you.


Adding verbiage for slack and how to edit docs.

Quick and dirty!
Feel free to tell critique.

Thanks @joshmccall221 !!!
I love the community section but I'd prefer to drop the jekyll docs mention from the README if that's cool. I see that as "how to stand up/build/run the docs website" myself and prefer to keep that as clean/n' simple as possible :)

ping ;) hey @joshmccall221 did you want to drop the jekyll stuff so we can merge in this epic PR ?
Much appreciated dude!

But how do we encourage peeps to update docs???
Yeah, I'll drop the jekyll stuff... give me a sec

There we go!


improve logging

Description
Improves logging in our controllers
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

[ ] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

80 of 91 (87.91%)  changed or added relevant lines in 8 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 88.835%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controller/osm/ingress_cert_config_reconciler.go
9
10
90.0%

pkg/controller/keyvault/placeholder_pod.go
11
13
84.62%

pkg/controller/ingress/concurrency_watchdog.go
15
18
83.33%

pkg/controller/keyvault/event_mirror.go
23
28
82.14%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller/keyvault/event_mirror.go
1
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
2029

Relevant Lines:
2284

💛  - Coveralls

/ok-to-test sha=996e000


One json example in docs has a syntax error

If you search for "retain: true here:
https://github.com/danecreekphotography/node-deepstackai-trigger/wiki/Configuration#
"retain: true should be "retain": true
I don't know how to update this, so I'm dropping the information here.
Hope this helps 👍 .

Oops! Thanks, will fix later today.

Fixed!


⚠ Bofrost.be has degraded performance

In fa2dcfa, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1355 ms

Resolved: Bofrost.be performance has improved in b17a2b4 after 6 minutes.


Adding Exception dates to node CRON

Is there any standard way to add exception to the cron dates? For example I don't want to run the cron job on national holidays. I think there should be some standard way to handle such exception dates array.

That isn't the way that cron itself works. This is intended to be a minimal project. A scheduler would be a better place to handle this kind of feature imo.


[11.x] Remove duplicated assertion in SupportArrTest

On my search for something else, I stumbled upon #49769 and noted that an assertion added there was present in both test methods (testShuffleProducesDifferentShuffles and testShuffleActuallyShuffles), which seems like an unintended duplicate to me.

@driesvints I mishit my Enter button and thus created this before adding a full description body, my bad. Can you reread the (now present) description?

@jnoordsij maybe best if you resend the PR.

Cool, thanks!


Use linked-hash-map to implement OrderedDocument

The ordered::OrderedDocument is a temporary solution while the linked-hash-map crate can only be compiled with nightly. But now, linked-hash-map can be compiled with the latest stable rustc v1.7 (https://github.com/contain-rs/linked-hash-map/issues/28).
So I suggest that we could migrate it to linked-hash-map.

How would this impact current use of bson?

Currently the OrderedDocument is implemented as Vec + BTreeMap pair to maintain insertion order. Which means that we need to do a O(n) search on the Vec and store the String key twice.


ios14beta crash

ios14beta crash
ios14bata download link : https://www.ios14beta.com/ios-14-beta-download-direct-links-ipsw/

same question occoured

Please help me resolve it

Hi @didiao11300
Can you please provide your flutter doctor -v,
your flutter run --verbose
and your pubspec.yaml.
Thank you

@iapicca

i am facing same issue, Any solution

I have similar issues on my device, iPhone 6s. However, it seems that only debug builds are crashing. I have an app installed in release mode and it is working fine. It was installed about 3 months ago. I haven't actually rebuilt any of them and they were all installed before the update.

Hi @kakanote  @didiao11300  @JohnSnooow @HenryQuan
Please upgrade to Xcode 12 for iOS 14 support
https://developer.apple.com/documentation/xcode-release-notes/xcode-12-beta-release-notes/

Note: It's Xcode 12 isn't fully supported yet https://github.com/flutter/flutter/issues/60133


[BEAM-121] Add DisplayData for IO transforms

Moved to apache/incubator-beam: https://github.com/apache/incubator-beam/pull/123


Unfortunate spelling issue

Hello,
There is a rather unfortunate spelling issue in the loadbalancer check code.
"interfaeces"
:-)
Darryl

thanks, will be fixed in next version


support workaround rootless loopback listening

fixing  https://github.com/containerd/nerdctl/issues/86

I'd rather prefer:

https://github.com/containerd/nerdctl/issues/814

I'd rather prefer:

rootless: run the puller/pusher in the host netns (but still in the userns) #814

Thanks for your feedback, SGTM

I'd rather prefer:

rootless: run the puller/pusher in the host netns (but still in the userns) #814

@AkihiroSuda  So what you are suggesting is to enable bypass4nets to puller/pusher  ?

are planning to releasev2.0.0 soon ?

@AkihiroSuda are planning to release rootlesskit v2.0.0 in the next few days ?

We need at least a few weeks to experiment detach-netns with nerdctl before releasing RootlessKit v2 GA.

@AkihiroSuda are planning to release rootlesskit v2.0.0 in the next few days ?

We need at least a few weeks to experiment detach-netns with nerdctl before releasing RootlessKit v2 GA.

OK so let me integrated the --detach-netns to nerdctl

#2723 will be ready soon, so let me close this


Update semanticdb-scalac to 4.4.16

Updates org.scalameta:semanticdb-scalac from 4.4.0 to 4.4.16.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "semanticdb-scalac" } ]

labels: library-update, semver-patch

Superseded by #127.


[MM-41852] - Add Start Trial to final stage of onboarding checklist

Summary
This PR adds a CTA to open the start trial modal on the final onboarding screen of the checklist
Ticket Link
MM-41852
Release Note
NONE

Hey @neallred , how do we get the task list showing on the test servers? I already set MM_FEATUREFLAGS_USECASEONBOARDING=true for this one but it's still not showing

I see it when I log in on https://mattermost-webapp-pr-9843.test.mattermost.cloud/acme/channels/town-square as sysadmin now. I checked the settings with the cloud command and it looked like the right settings were set. Based on that, I'm guessing you followed the instructions correctly (https://community-daily.mattermost.com/private-core/pl/e5duwp1mr7n4jmokrre1xa3czo) . Maybe it took longer to update the config than the time you tried it in?

I was also looking at the wrong spinwick (your other PR) at first and didn't see it, so I reran through the steps to be double sure, then noticed I was on the wrong spinwick. So I didn't see this spinwick until I ran through the steps again myself to be sure.

/update-branch

@AGMETEOR I completed all of the steps but it didn't prompt me to start the trial. If you can reset it all I'll go through it all again though to be sure.
Along the way I noticed that the link to Playbooks asks me to log in again but fails to go any further even when I log in.

@stevemudie I have set up a new one


🧹 Spring cleanup

Do you feel Bocadillo has expanded too much? That it has accumulated bloat? Or that it hast lost focus? I do!
I've been having doubts about how massive the Bocadillo code base and documentation have become.
I have a feeling there are many features that were added just for the sake of it, yet they're not actually used by anyone.
So, time for a spring cleanup 💐
Features I don't think are necessary and should be removed:

[x] [#245] Named routes and url_for(): we're not aiming at building template-based/MVT applications, yet that's the main area where I'd see those useful. But these features include a lot of complexity; some currently open issues would just disappear if they were removed.
[x] [#241] res.media and the whole "media" thing. It's been called media to represent an abstraction layer: JSON is a format among others, and we could in theory support YAML, MessagePack, etc… Yet, who builds APIs out of YAML? Out of MessagePack? Most web services use JSON.
~[ ] Default HTTPError handler being text: it should be JSON.~
[x] [#239] app.run(): it forces to use if __name__ == "__main__" which is both ugly and beginner-averse, with little advantages compared to the uvicorn command.
[x] [#239] Debug mode: if we remove app.run(), its only use is a) to enable hot reload and b) to display tracebacks in the browser. a) is covered by uvicorn --reload. I don't think b) is actually useful.
[x] [#238] Synchronous stuff: Bocadillo is an async web framework, after all, so why support both sync and async versions of stuff (views, hooks, error handlers…) when all-async does the trick?
[x] Queso (the CLI): unless we find a very good use for it, if app.run() is removed then Queso has no reason to exist anymore.

All these features have a poor developer need vs. implementation complexity balance. They create more problems for us to solve than they solve developers' problems.
Also, because of the lack on focus on REST, implementing incredibly useful stuff such as data validation (#8) and API documentation (#122, #125) is so much more difficult, because we need to make a distinction between REST endpoints and other HTTP endpoints.
Anyway, I'd be more than happy to have anyone's feedback on features they think are not necessary, hinder productivity or developer experience, or seem unclear!

My experience with bocadillo is a fairly narrow use-case, so my responses will be based on that. (The project is https://github.com/cs01/termpair)

Templates: the only use for templates I've personally found (and seen in others' projects) is to use it to serve a frontend app's index.html, or any HTML page that is actually not a Jinja-templated page.

I like the built in tempates, and use it to pass data from the server to the client. My use case is generally to pass a Python dict to the frontend and store it as some initial JavaScript data in the page. I am surprised nobody is using Jinja templates.

res.media and the whole "media" thing. It's been called media to represent an abstraction layer: JSON is a format among others, and we could in theory support YAML, MessagePack, etc… Yet, who builds APIs out of YAML? Out of MessagePack? Most web services use JSON.

Agreed about yaml, I think that should be removed. I haven't used media personally so have no opinion besides removing yaml.

Default HTTPError handler being text: it should be JSON.

No opinion here

Hooks: do you even know what they are/what they're for? I never had a practical use of it. Maybe it's just me.

Just looked these up. They seem pretty cool, but would probably apply to larger projects. Probably wouldn't be a big deal to developers if they were removed, and might be worth it if it saves bocadillo dev's substantial mental overhead.

app.run(): it forces to use if name == "main" which is both ugly and beginner-averse, with little advantages compared to the uvicorn command.

What is the uvicorn command? In Flask and sometimes Bocadillo I was sometimes confused as to where parameters went: in the App() instantiation or in the run() call.

Debug mode: if we remove app.run(), its only use is a) to enable hot reload and b) to display tracebacks in the browser. a) is covered by uvicorn --reload. I don't think b) is actually useful.

Agreed

Synchronous stuff: Bocadillo is an async web framework, after all, so why support both sync and async versions of stuff (views, hooks, error handlers…) when all-async does the trick?

I suppose if folks want synchronous they can use Flask or one of the other frameworks out there. If you go all-async, I suggest making the docs very explicit and friendly about how to convert synchronous code to async code with some examples of common patterns users might be looking for.

Queso (the CLI): unless we find a very good use for it, if app.run() is removed then Queso has no reason to exist anymore.

To be honest I do not know what queso does. I looked at https://bocadilloproject.github.io/queso/reference/#overview and couldn't quickly tell what it does or why I'd want it. If it is something like click-web, I think that would be interesting!
Things I love about Bocadillo:

built in websocket support (flask doesn't have this)
built in compression (flask didn't have this last time I used it, not sure if it does now)
excellent documentation (it is as good or better than Flask's)
friendly/responsive community
clean APIs and patterns

I haven't spent too much time building web apps lately, but I know things I wanted in the past were: dead simple ways to create REST API's with validation built in (like django-rest-framework) and auto-documentation (swagger/open API). Also easy GraphQL support seems really interesting because of how powerful GraphQL is.
Why did you build Bocadillo in the first place? For fun? To learn? To be the go-to GraphQL-friendly web framework? Or most database-friendly? Or an async Flask replacement to be the go-to web framework for everyone? Knowing your mission and target audience might help you keep focus on the project.

Thanks a ton for your thorough write up @cs01. Gathering feedback and user needs is exactly what I need at the moment to move Bocadillo forward. :+1:

I like the built in tempates, and use it to pass data from the server to the client. My use case is generally to pass a Python dict to the frontend and store it as some initial JavaScript data in the page. I am surprised nobody is using Jinja templates.

I see! I was probably over the top to consider removing Jinja templates. It's quite a self-contained feature after all, and it can be useful for prototyping.
That said, I'm more concerned about named routes and URL reversal — i.e. app.url_for(). It adds a lot of complexity because it's the only reason apps and routes need to have a name. In templates, the alternative is to use the full path, e.g. /foo/{{ some_param }}.
Do you think this feature has been/would be useful to you?

Agreed about yaml, I think that should be removed. I haven't used media personally so have no opinion besides removing yaml.

YAML isn't included by default; we just have a how-to guide on adding YAML media handlers. But yeah, I think we should keep things simple and introduce res.json = ..., which would also be a much more straight-forward API IMO.

What is the uvicorn command?

It's the CLI command provided by the uvicorn ASGI web server. app.run() is merely a wrapper around that command that sets flags based on app configuration and keyword arguments.

In Flask and Bocadillo I was sometimes confused as to where parameters went: in the App() instantiation or in the run() call.

I actually share the same feeling. I've been working on #230 which brings configuration via a single entrypoint (app.configure()), and adds a global settings object accessible from anywhere in the code base as soon as an app has been configured. Feel like this could help relieve the confusion?

I suppose if folks want synchronous they can use Flask or one of the other frameworks out there. If you go all-async, I suggest making the docs very explicit and friendly about how to convert synchronous code to async code with some examples of common patterns users might be looking for (as you have been doing 😄).

Absolutely! We should definitely add some friendly hints on getting started with async. Adding patterns and conversion examples is a very good idea!

To be honest I do not know what queso does.

Yes, exactly. I initially envisioned Queso to be a development toolkit for Bocadillo (so not a similar thing to click-web), but now it seems like a distraction from improving the framework itself. I'm not even sure that building dev tools should be something to aim for — ideally Bocadillo should be simple enough to use that we shouldn't need any extra tooling, right?

Things I love about Bocadillo:

Thank you so much for sharing this list! 🙏 Means a lot to me, plus it always helps to know what parts of the framework people really like. :-)

Dead simple ways to create REST API's with validation built in (like django-rest-framework) and auto-documentation (swagger/open API)

We have #122 and #125 open for the autodoc part, which I agree would be a huge benefit. Data validation is also on the agenda — #8. FastAPI has both of these, and people seem to really like it. I'd love to see these in land Bocadillo too!

Also easy GraphQL support seems really interesting because of how powerful GraphQL is.

Yep, we also have an issue open for that: #220. The Python async GraphQL space seems to be evolving at the moment, so I'll sure be watching for potential integrations. Be sure to check out the issue if you have any recommendations/thoughts. :-)

Why did you build Bocadillo in the first place?

I initially built Bocadillo to learn about Python async and web frameworks, and also for fun. I didn't have an actual product vision at the start, e.g. "let's build an async version of Flask", and I've been working on building a clearer one lately.
But I like this way to put things: " the go-to async web framework for everyone". I think that's quite close to what I'd like to see Bocadillo become: a framework that makes building async web stuff so obvious it could be someone's first framework, but also ensures power users get (mostly) all the features they need to be productive. The thing is, this means Bocadillo needs to include a lot of stuff to be usable, and I can see how there's a risk of losing focus in the process.

Absolutely! We should definitely add some friendly hints on getting started with async. Adding patterns and conversion examples is a very good idea!

A couple of votes for this.  I am pretty new to asyncio and web development so I'm struggling a bit with how a site would be architected.  Based on my current understanding all the first level handling of user input would be async from the framework and you want to minimize synchronous code to keep the site responsive.  If an input triggers extensive processing, you would need to either hand it off using multiprocesssing or sprinkle in asyncio.sleep(0) in the synchronous code.  Using threads isn't desirable if you are CPU bound and if the processing is I/O intensive it seems like you would just use asnycio?

Okay, I've moved this "all-async" thing to its own issue so we can tackle it later: #238.
@EricE: Yes, asyncio (and single-threaded task-based concurrency in general) wasn't built with high CPU loads in mind — quite the opposite in fact: it's made for I/O-intensive applications that can keep the CPU available for switching between tasks as they finish I/O operations.
Now, I can understand how async can be confusing — especially for folks who also get started in web development.
We have some documentation here and there on async in Bocadillo. Did you find that useful? Are these pieces of docs not visible enough? Should they contain more information on app architecture, as you said?

Okay, app.run() and debug mode no longer exist: #240 🎉

I have personally not used named routes, nor do I think I ever have on my other projects. Seems like a 20% use case. (A rule of thumb I read somewhere is that 20% of features are used by 80% of  users, the remaining 20% of users use the other 80% of features.)

ideally Bocadillo should be simple enough to use that we shouldn't need any extra tooling, right?

Yes that idea is probably out of scope for Bocadillo core, but would be a cool project to make with Bocadillo!

The thing is, this means Bocadillo needs to include a lot of stuff to be usable, and I can see how there's a risk of losing focus in the process

Sounds like a good goal! Would it make sense to capture a list of everything Flask does, prioritize, then implement each thing, one-by-one, in Bocadillo?
A few months ago I saw your announcement tweet about Bocadillo in response to Kenneth's tweet when he started responder, so I have been following from the very start. I have been really impressed with what you have created and honestly don't really know how you made it all so quickly. I think the project deserves more attention and :star: s.

I had read the links you provided and they are useful if you have a broad enough sense of how you would use an async web framework.  When I read

"WSGI was not designed to handle multiple clients at a time — a property known as concurrency. If processing a request requires running a 10-second long database
query, other clients have to wait, period."

then it sounds like most websites should be async to maintain a responsive UI.
In my case, I have some tasks for a site that involve lots of REST queries, number crunching, database accesses and page generation.    Clearly the REST queries are perfect for async, but that is only a part of what is going on.  So how do you balance the async parts with the sync parts, i.e. how much has to be async before you should use Bocadillo over Flask.  Are the async web frameworks just designed to grab a little data from a database and spit it out as JSON or to be an alternate to Flask for general purpose sites?
I have done asyncio apps with Tkinter and am looking to move to a web interface.  I was attracted to Responder and then Bocadillo since it looked more full featured.  I have a number of sites I'd like to create for personal and side projects at work and most of them have elements of time consuming tasks where the rest of the site/UI should stay responsive.  For reference, I think I am a solid intermediate Python programmer but I do electronics for robots in my day job.  Probably doesn't matter but I'm also mostly a Windows user since most EE and ME CAD tools are still Windows only.
For "app architecture", I think the above could cover it.  I looked at #238 and it looks good but I would add a "d." (or expand "c.") that talks about how to mix async with sync if you do have CPU intensive operations.  It looks like there is good coverage with async database libraries but there are still plenty of libraries that don't have async replacements.  Also, some words on using a Javascript framework like Vue with Bocadillo would be welcome if it is appropriate :)
Your responsiveness is wonderful!

. Also, some words on using a Javascript framework like Vue with Bocadillo would be welcome if it is appropriate :)

I second this, but for React. My go-to stack is Python backend+React frontend. So some kind of instructions or boilerplate code would be helpful I think. I can probably add docs for this if you want. Another thing I liked was the Docker examples to get Bocadillo running. Expanding on that might be nice, like example systemd files.

 It sounds like an advanced frontend architecture (in Angular you’d use observables for this, in Vue I’m not sure how this would be done) and I don’t think Bocadillo can do much more — Bocadillo itself is already asynchronous so it will be able to manage the multiple requests you’d make on the frontend. :-)

Are the async web frameworks just designed to grab a little data from a database and spit it out as JSON or to be an alternate to Flask for general purpose sites?

They can do so much more than exposing JSON over web endpoints! The “async” part just refers to the execution model. It unlocks superpowers like WebSocket (which Flask does not support) for bidirectional communication with clients. You can check out @cs01’s TermPair project as an example, and also the official tutorial. 😄

^ Duh, misclick on the close button.

Also, some words on using a Javascript framework like Vue with Bocadillo would be welcome if it is appropriate :)

Absolutely! I’m also interested in investigating this because Python/JS is my favorite backend/frontend stack as well. I’m more of a Vue user at the moment, but I’d love to have your input on setting up a Bocadillo/React project, @cs01. I think setting up an example repo people could fork (or a cookie cutter?) could be a good way to take this off.

Your responsiveness is wonderful!

My pleasure! 😄

Seems like a 20% use case.

Agreed @cs01. I’m trying to cut the long trail with this spring cleanup, and url_for() does seem to be part of it. :)

Would it make sense to capture a list of everything Flask does, prioritize, then implement each thing, one-by-one, in Bocadillo?

Never thought of that, but I think the experiment could be worthwhile. I think we already cover a lot, but that would give better visibility. :)

I have been really impressed with what you have created and honestly don't really know how you made it all so quickly. I think the project deserves more attention and ⭐ s.

Thank you so much! 👏 If you have any ideas to help spread the Bocadillo love, I’m all ears! I’ve been wanting to write some blog posts, but no time available unfortunately. I think publishing an “Introducing Bocadillo” post once 0.14 is out (lots of improvements in there) and cross-posting it to Medium could help.

Quick update: 400 LOC just vanished out of existence. url_for() and named routes are now gone! #248

Final update: Queso has retired! https://github.com/bocadilloproject/queso https://pypi.org/project/queso
Spring cleanup complete. 🧹✨ Thanks for participating!


Refine Delivery Service Auth for Alias names

To become a new delivery service user, a user must submit their signed UserProfile and their EnsName to the DS. The delivery service then creates a session for that user to check if incoming messages are addressed to that user.
The requirements to sign up are:

The profile signature matches the UserProfile.
The EnsName resolves to the address that signed the profile.

The dm3 default client using the address 0x123 would use 0123.addr.dm3.eth as a session key.
This works fine when only the default dm3 name is used. However, once other alias names are used, it is no longer possible for the delivery service to determine the correct receiver of the message.
This is because the DS is not aware of other alias names the receiver might have, as it uses the session key as the identifier. There are two possible ways to deal with this issue:
Use address instead of Session for the session ID

DS accepts every message regardless of its name, as long as it has a session for the resolved address.
This might introduce troubles for the client since different profile keys can be used to encrypt the message on the sender side.
Nonce could also be a profile when different profiles are used

Each Alias has to independently register at the DS

DS keeps the current way of authentication.
The client has to create a session for every alias the address wants to use.
The client has to fetch messages for every alias.

After consultation with @steffenkux Use address instead of Session for the session ID is the way to go

[ ] add tld resolver to delivery:incoming message. resolve deliveryInformation.to its corresponding address
[ ] migrate addSession and setSession so they use the address as a key
[ ] on handleMessageFromDeliveryService the client has to check if it has the keys to decrypt a message
[ ] only acknowledge messages that could be processed.


Tagging hairdresser=barber

Could support for the tag hairdresser=barber please be added, it was recently introduced for tagging barber shops.
Many thanks for creating this app, I use it on a daily basis!

https://github.com/Zverik/every_door#presets-and-translations
There is a preset for this tag, but you need to wait for the next Every Door update
https://github.com/openstreetmap/id-tagging-schema/pull/1165

Yup, will be available in 5.2.


wikibase: Test failure when run on non-English locales

When running the test suite with a French locale, I get:
[ERROR] Failures:
[ERROR]   PreviewWikibaseSchemaCommandTest.testWarningData:147 expected [country] but found [pays]

This is a symptom of the fact that https://github.com/OpenRefine/OpenRefine/pull/6895 (cc @sunilnatraj) picks the language in which to fetch the labels based on the system locale.
Instead, we should change the command to take this language from the HTTP request so that it can match the language used in the UI (which is often not the same thing as the system locale).
As a temporary workaround, one can change the locale used by Maven to get the test suite to pass.

@wetneb As the unit test is checking the value of the label, this test case is tied to the en language. My proposal is to update the test to validate the label if the language is "en" and for other languages we validate the label is not empty.
                if (Locale.getDefault().getLanguage().equals("en")) {                     assertEquals(addedPropertyLabel.asText(), "country");                     assertEquals(itemEntityLabel.asText(), "Canada");                 } else {                     assertTrue(addedPropertyLabel.asText().length() > 0);                     assertTrue(itemEntityLabel.asText().length() > 0);                 }

That's a quick workaround, but I would prefer to fix the underlying issue. The command should not rely on the JVM's default locale in the first place, because this locale will often be different from the language used in OpenRefine's web UI.
As a result, this risks that the labels added in the backend are fetched in a language that's inconsistent with the rest of the interface, which will be odd for users.
That's why I would rather change the command so that it takes the language as a parameter. This would also ease testing.

@wetneb  I did check the language preference setting flow from the UI, it is updating the JVM locale.  Did i miss something here?
        if (prefName.equals("userLang")) {             LocaleUtils.setLocale(valueString);         }

Ah, I forgot about that… well then we're even less ready for multi-user support than I thought!
Well then, perhaps just set the locale to English before the test (in a @BeforeMethod) and restore it afterwards (in an @AfterMethod)? Along the lines of this, but for TestNG

@wetneb Thank you; raised PR


Implement pull-model documentDiagnostics

Implements LSP 3.17.0's pull-model documentDiagnostics request, which fix stale squiggly issues after fixing an error due to the relationship between code in two files. When using pull-model documentDiagnostics, we disable the push-model publishDiagnostics to avoid reporting them twice.

(this gif was using a temporary "pulldiag" source name to verify that it wasn't publish diagnostics in action)
Fixes #500

Two questions before I publish this PR:

@ahoppen Good news! I got this to work and it fixes some of the stale squiggly cases we knew of. Can you check the two comments I left on the PR as well? Thanks for the earlier pointers!

@ahoppen

One request though: Could you also write a test case for diagnostic pulling?

I'll do my best. I was under the impression that the sourcekit-lsp tests weren't working on Windows and my macOS-fu is poor at best. :/

@ahoppen

One request though: Could you also write a test case for diagnostic pulling?

I'll do my best. I was under the impression that the sourcekit-lsp tests weren't working on Windows and my macOS-fu is poor at best. :/

The tests worked (at one point) on Windows.  They cannot be built currently due to the swift-syntax dependency and SPM miscompiling code. You should be able to roll back to prior to the swift-syntax adoption, port your code to that point and run the tests.
Alternatively, you can enumerate all test cases into a manifest, add CMake rules, and build the tests locally with CMake.

Or someone could ask swift-ci to build and test this PR for me? 😅 I have added a simple test mimicking the publish diagnostics test so there's a nonzero chance that it'll pass without me having to do much local build shenanigans... this time around.

@swift-ci please test

Or someone could ask swift-ci to build and test this PR for me? 😅 I have added a simple test mimicking the publish diagnostics test so there's a nonzero chance that it'll pass without me having to do much local build shenanigans... this time around.

Sorry, I have meant to reply to this one and then forgot. I ran the test case locally and it had a few syntactic issues but I was able to fix them easily. Unfortunately, I forgot about the changes and discarded them. I can fix your test case again after you addressed https://github.com/apple/sourcekit-lsp/pull/746#discussion_r1194117022.

@ahoppen On it! Sorry I was pulled into other things momentarily but I aim to get this all wrapped up and merged by EOW.

No worries, @tristanlabelle. Thanks for doing this work in the first place.

@swift-ci test

@swift-ci test windows

@swift-ci test

I would appreciate a ci kick. I'm still writing the unit test blindly due to current Windows build limitations. (@ahoppen if you get a chance to build locally that'd be super helpful)

@swift-ci test

I just ran the test locally and if you apply the following diff, they pass
diff --git a/Tests/SourceKitLSPTests/PullDiagnosticsTests.swift b/Tests/SourceKitLSPTests/PullDiagnosticsTests.swift
index fa2b43f8..a28f23f4 100644
--- a/Tests/SourceKitLSPTests/PullDiagnosticsTests.swift
+++ b/Tests/SourceKitLSPTests/PullDiagnosticsTests.swift
@@ -16,6 +16,10 @@ import SKTestSupport
 import XCTest

 final class PullDiagnosticsTests: XCTestCase {
+  enum Error: Swift.Error {
+    case unexpectedDiagnsoticReport
+  }
+
   /// Connection and lifetime management for the service.
   var connection: TestSourceKitServer! = nil

@@ -61,8 +65,7 @@ final class PullDiagnosticsTests: XCTestCase {
     }

     guard case .full(let fullReport) = report else {
-      XCTFail("Unexpected diagnostics report type: \(report)")
-      return
+      throw Error.unexpectedDiagnsoticReport
     }

     return fullReport.items

Thank you, @ahoppen ! I applied your diff.

@swift-ci Please test

@swift-ci test windows

Windows builds need to be started separately unfortunately.

Woo! All green :D

@tristanlabelle Can you also cherry-pick this PR to the release/5.9 branch? I think it would be useful to get this into the 5.9 release.

Cherry-picked to #751 (after requashing - this PR was completed by merging so there's a bit of my dirty laundry in the history now)


FileNotFoundError when using an s3 bucket as the model_dir with HuggingFace model server

/kind bug
First of all, I'd like to say thank you for the work on KServe! It's been delightful so far playing around with KServe. But we found a small bug while testing out the HuggingFace model server (which we're aware is a very new addition as well).
What steps did you take and what happened:

Created an InferenceService using the HuggingFace model server (yaml pasted below)
Specified an s3 bucket as the model_dir (I suspect this might happen for anything that's not a local dir)
Observed that the model is succesfully downloaded to a tmp directory and loaded, but then encountered the FileNotFoundError right after

Logs:
% k logs huggingface-predictor-00003-deployment-8659bb8b9-m945b
Defaulted container "kserve-container" out of: kserve-container, queue-proxy
INFO:root:Copying contents of s3://kserve-test-models/classifier to local
INFO:root:Downloaded object classifier/config.json to /tmp/tmpckx_trr1/config.json
...
INFO:root:Successfully copied s3://kserve-test-models/classifier to /tmp/tmpckx_trr1
INFO:kserve:successfully loaded tokenizer for task: 4
INFO:kserve:successfully loaded huggingface model from path /tmp/tmpckx_trr1
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/huggingfaceserver/huggingfaceserver/__main__.py", line 69, in <module>
    kserve.ModelServer(registered_models=HuggingfaceModelRepository(args.model_dir)).start(
  File "/huggingfaceserver/huggingfaceserver/huggingface_model_repository.py", line 24, in __init__
    self.load_models()
  File "/kserve/kserve/model_repository.py", line 37, in load_models
    for name in os.listdir(self.models_dir):
FileNotFoundError: [Errno 2] No such file or directory: 's3://kserve-test-models/spam-classifier'

What did you expect to happen:
I expected that this would work, as the model was successfully downloaded and loaded. But I did find a tmp workaround below and I think I know where the issue is!
What's the InferenceService yaml:
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: huggingface
spec:
  predictor:
    serviceAccountName: huggingface-sa
    containers:
    - args:
      - --model_name=spam-classifier
      # - --model_id=xyz (see workaround below)
      - --model_dir=s3://kserve-test-models/classifier
      - --tensor_input_names=input_ids
      image: kserve/huggingfaceserver:latest
      name: kserve-container

Anything else you would like to add:
A temporary workaround I found is to supply the model_id argument. It can have any value, as the model_dir will override it anyway during loading:
https://github.com/kserve/kserve/blob/5172dc80b0a23d2263757de70a02eeef08b18811/python/huggingfaceserver/huggingfaceserver/model.py#L91-L94

I have verified that this workaround works (expand to see logs).
% k logs huggingface-predictor-00004-deployment-946b4d6c8-pk5nj -f
Defaulted container "kserve-container" out of: kserve-container, queue-proxy
INFO:root:Copying contents of s3://kserve-test-models/classifier to local
INFO:root:Downloaded object classifier/config.json to /tmp/tmppwjsica7/config.json
...
INFO:kserve:successfully loaded tokenizer for task: 4
INFO:kserve:successfully loaded huggingface model from path /tmp/tmppwjsica7
INFO:kserve:Registering model: classifier
INFO:kserve:Setting max asyncio worker threads as 5
INFO:kserve:Starting uvicorn with 1 workers
2024-02-09 18:57:33.228 uvicorn.error INFO:     Started server process [1]
2024-02-09 18:57:33.229 uvicorn.error INFO:     Waiting for application startup.
2024-02-09 18:57:33.234 1 kserve INFO [start():62] Starting gRPC server on [::]:8081
2024-02-09 18:57:33.234 uvicorn.error INFO:     Application startup complete.
2024-02-09 18:57:33.235 uvicorn.error INFO:     Uvicorn running on http://<IP_ADDRESS>:8080 (Press CTRL+C to quit)

I think the issue is here:
https://github.com/kserve/kserve/blob/5172dc80b0a23d2263757de70a02eeef08b18811/python/huggingfaceserver/huggingfaceserver/__main__.py#L63-L72

model.load() will succeed, so we jump to line 68
It checks for args.model_id, which is empty, so we go inside the if block
It will try to instantiate HuggingfaceModelRepository with model_dir, which is pointing to an s3 bucket and not a local directory, thus causing the FileNotFoundError
This is how I came up with the workaround of passing model_id, so that the else block is executed instead (because the model did load succesfully, so doing kserve.ModelServer().start([model] if model.ready else []) won't be a problem)

Environment:

Cloud Environment: aws
Kubernetes version: (use kubectl version): v1.27.9-eks-5e0fdde
OS (e.g. from /etc/os-release): Ubuntu 22.04.3 LTS

Thanks for the detailed report. I sent a fix in https://github.com/kserve/kserve/pull/3424.


[BUG] toolchain README Documentation link is broken

Describe the bug
https://github.com/dojoengine/dojo/pull/1523  update dead links
but dojobook toolchain part seems update

for every part(eg.katanta)  overview page point to https://book.dojoengine.org/toolchain/katana, not katana/overview
toolchain every part have overview, but missing general overview, so in dojoup/README.md [Documentation](https://book.dojoengine.org/toolchain/dojoup) is missing

To Reproduce
just open link
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
Add any other context about the problem here.

Closed in #2036.


Configure control plane services

Depends on https://github.com/charmed-kubernetes/charm-lib-kubernetes-snaps/pull/4

Ready for review. I'm leaving it in draft since I'll need to update requirements.txt after https://github.com/charmed-kubernetes/charm-lib-kubernetes-snaps/pull/4 lands.

Ready for review. I'm leaving it in draft

i updated the reqs.txt.  i'll let you decide if that's enough to un-draft this.  it's a +1 from me; merge at will.


Refactor release.createFromUrl tests to async-await

Change-type: patch
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


kafka 1.0 subproject

Added subproject for #16
Unless I've missed something in kafka's release notes it didnt require any additional changes to make it work, similiar to 0.11.x
I've also added missing 0.11 tutorial to README.md
I wasn't sure how to name this subproject because kafka10 was taken, I went with kafka1x but I'm open to other suggestions
Lack of changes makes me wonder what is the source of bad compatibility? Potential use of new features? I can run all (except kafka8) tests successfully while running both Kafka 1.0 and kafka 0.11 and atm I'm testing my own application which uses monix-kafka-10 while having Kafka 1.0 and so far it looks promising

Is the 0.10.x monix Kafka compatible against Kafka 1.0.0?
I can check that by myself but was curious to know if someone already tried this?

@joesan I've used it in a project with Kafka 1.0.0 environment and didn't have any issues so far


Input simulation doesn't work if speech is not supported on dev machine

Describe the bug
Camera controls (rotation, movement) is not working in editor despite Emulation Mode being set no "none".
To reproduce
Steps to reproduce the behavior:

Create an empty project in unity 2018.3.12
Change platform to UWP
Enable VR with Mixed Reality Toolkit
Import MRTK v2 Core
Click "Add to scene and configure"
Launch project
Hold right mouse button and move

Expected behavior
Instead of camera rotating, nothing happens.
Your Setup (please complete the following information)
Windows 10 Pro
Unity 2018.3.x (not working on any version)
MRTK v2 RC
Additional context
This is however working on my home machine. The only difference is my work computer (the one it's not working on) I don't have speech recognition, and thus get an error on play.

UnityException: Speech recognition is not supported on this machine.
UnityEngine.Windows.Speech.KeywordRecognizer..ctor (System.String[] keywords, UnityEngine.Windows.Speech.ConfidenceLevel minimumConfidence) (at C:/buildslave/unity/build/Runtime/Export/Windows/Speech.cs:221)
Microsoft.MixedReality.Toolkit.Windows.Input.WindowsSpeechInputProvider.Enable () (at Assets/MixedRealityToolkit.Providers/WindowsVoiceInput/WindowsSpeechInputProvider.cs:95)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterServiceInternal (System.Type interfaceType, Microsoft.MixedReality.Toolkit.IMixedRealityService serviceInstance) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:843)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterServiceInternal[T] (T serviceInstance) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:858)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterService[T] (System.Type concreteType, Microsoft.MixedReality.Toolkit.Utilities.SupportedPlatforms supportedPlatforms, System.Object[] args) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:199)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.RegisterDataProvider[T] (System.Type concreteType, Microsoft.MixedReality.Toolkit.Utilities.SupportedPlatforms supportedPlatforms, System.Object[] args) (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:280)
Microsoft.MixedReality.Toolkit.Input.MixedRealityInputSystem.Enable () (at Assets/MixedRealityToolkit.Services/InputSystem/MixedRealityInputSystem.cs:219)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.EnableAllServices () (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:973)
Microsoft.MixedReality.Toolkit.MixedRealityToolkit.OnEnable () (at Assets/MixedRealityToolkit/Services/MixedRealityToolkit.cs:772)

Is a speech recognition mandatory to emulate the input in edior?

Speech should not be mandatory, but it looks like the input system runs into an exception when registering data providers. Since input simulation is registered after speech it never gets to the point where it initializes that service. If possible we should check if speech is supported before registering the data provider.

Thank you for replying. So it is speech recognition after all.
Is there any way to disable it, so the input system would be registered correctly?

Hi, I haven't tested this myself (don't have a machine that doesn't support speech), but could you please try disabling speech and dictation in your input configuration profile? You just need to delete the two entries in red by hitting the '-' button on the right

Also, if possible it would be great to also post this question to stackoverflow (tagged with 'mrtk') so we can reference this issue in case other people hit it in the future.

Lukas, do you have some time to take a look at this? If not, please feel free to un-assign yourself. Since it's blocking people from using MRTK it seems important to look at.

Fixed in mrtk_development by catching the exception, same as WindowsDictationInputProvider does already.

Hi, I haven't tested this myself (don't have a machine that doesn't support speech), but could you please try disabling speech and dictation in your input configuration profile? You just need to delete the two entries in red by hitting the '-' button on the right.
Also, if possible it would be great to also post this question to stackoverflow (tagged with 'mrtk') so we can reference this issue in case other people hit it in the future.

Yes, this works without any issues so far. Thank you Julia.


[Cherry pick into v1.6.x] Fix build for ios app using grpc as cc_library

For ios build,  bazel build needs to be invoked with:
--ios_multi_cpu=armv7,arm64 build.  This in turn gets picked as
cpu based on the docs:
--[no]experimental_enable_objc_cc_deps default: "true"
Allows objc_* rules to depend on cc_library and causes any objc dependencies to be built with --cpu set to "ios_<--ios_cpu>" for any values in --ios_multi_cpu.
This diff explicitly adds darwin config for cpu being ios_x86_64, ios_armv7,
ios_armv7s and ios_arm64.  This is the pattern followed by protobuf build too
https://github.com/google/protobuf/blob/master/BUILD

Question - I also see branch for 1.7.  Should I cherry pick into that too or will it be re-synced with master soon?


Error building on iOS with firebase_messaging plugin imported

Ozcan:quiztime ozc$ flutter doctor -v
[✓] Flutter (Channel master, v0.11.12-pre.6, on Mac OS X 10.13.6 17G65, locale en-TR)
    • Flutter version 0.11.12-pre.6 at /Users/ozc/Development/flutter
    • Framework revision c80244d1ca (2 hours ago), 2018-11-28 16:19:28 -0800
    • Engine revision 72c7a75672
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/ozc/Library/Android/sdk/
    • Android NDK at /Users/ozc/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/ozc/Library/Android/sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 28.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.2.1)
    • IntelliJ at /Users/ozc/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 26.0.3
    • Dart plugin version 182.3569.4

[✓] VS Code (version 1.26.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.14.0

[✓] Connected device (1 available)
    • Özcan's iPad • 2aa500015a4c8246d5bafced8ea56264474ebaf5 • ios • iOS 12.0

• No issues found!

Ozcan:quiztimeio ozc$ flutter clean
Deleting 'build/'.
Ozcan:quiztimeio ozc$ flutter run
Launching lib/main.dart on Özcan's iPad in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: <Removed>
Running pod install...                                       3.7s
Starting Xcode build...
Xcode build done.                                            5.1s
Failed to build iOS app
Error output from Xcode build:
↳
    2018-11-29 05:52:33.166 xcodebuild[16428:33232164]  DTDeviceKit: deviceType from 2aa500015a4c8246d5bafced8ea56264474ebaf5 was NULL
    ** BUILD FAILED **

Xcode's output:
↳
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:79:33: error: type-id cannot have a name
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
                                    ^~~~~~~~~~~~~~~~~~~
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:79:53: error: expected ')'
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
                                                        ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:79:32: note: to match this '('
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
                                   ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:79:31: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
                                  ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:81:15: error: use of undeclared identifier 'error'
              if (error != nil) {
                  ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:82:63: error: use of undeclared identifier 'error'
                NSLog(@"getToken, error fetching instanceID: %@", error);
                                                                  ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:85:20: error: use of undeclared identifier 'instanceIDResult'
                result(instanceIDResult.token);
                       ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:79:9: error: no visible @interface for 'FIRInstanceID' declares the selector 'instanceIDWithHandler:'
            instanceIDWithHandler:^(FIRInstanceIDResult *_Nullable instanceIDResult,
            ^~~~~~~~~~~~~~~~~~~~~
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:99:11: warning: incompatible integer to pointer conversion initializing 'BOOL *' (aka 'signed char *') with an expression of type 'BOOL' (aka
    'signed char') [-Wint-conversion]
        BOOL *value = [[FIRMessaging messaging] isAutoInitEnabled];
              ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:100:37: warning: incompatible pointer to integer conversion sending 'BOOL *' (aka 'signed char *') to parameter of type 'BOOL' (aka 'signed
    char'); dereference with * [-Wint-conversion]
        result([NSNumber numberWithBool:value]);
                                        ^~~~~
                                        *
    In module 'Foundation' imported from /Users/ozc/Development/quiztimeio/ios/Pods/Headers/Public/Flutter/Flutter/FlutterBinaryMessenger.h:8:
    /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSValue.h:100:36: note: passing argument to parameter 'value' here
    + (NSNumber *)numberWithBool:(BOOL)value;
                                       ^
    /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:158:1: warning: conflicting return type in implementation of 'application:didReceiveRemoteNotification:fetchCompletionHandler:': 'BOOL' (aka
    'signed char') vs 'bool' [-Wmismatched-return-types]
    - (bool)application:(UIApplication *)application
    ^  ~~~~
    In file included from /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.m:5:
    In file included from /Users/ozc/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-2.1.0/ios/Classes/FirebaseMessagingPlugin.h:5:
    In file included from /Users/ozc/Development/quiztimeio/ios/Pods/Headers/Public/Flutter/Flutter/Flutter.h:51:
    In file included from /Users/ozc/Development/quiztimeio/ios/Pods/Headers/Public/Flutter/Flutter/FlutterAppDelegate.h:11:
    /Users/ozc/Development/quiztimeio/ios/Pods/Headers/Public/Flutter/Flutter/FlutterPlugin.h:116:1: note: previous definition is here
    - (BOOL)application:(UIApplication*)application
    ^  ~~~~
    4 warnings and 6 errors generated.

Could not build the precompiled application for the device.

Error launching application on Özcan's iPad.
Ozcan:quiztimeio ozc$

Looks somewhat similar to #18340

@zoechi following #18340 give some different errors, so I've ended up creating a new project and moving files one by one to that one.
Feature request:
I don't know if there exists similar command, bu flutter tool may have a new command, like recreate, which backups+deletes all files (not just build) except lib directory and recreate the project with lib directory intact.

@ozc I'm not exactly sure what you mean, but if you use Git there shouldn't be a need for recreate.
Just delete ios/ and android/ run flutter create . and re-apply manual changes.

@ozc
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/564. Any further collaboration will be done there.


Add Dockerfile

Add Dockerfile
Put dev database in data directory

ping @philipmuir @saurabh-g @pedelman

:+1:

Looks good to me! :thumbsup: