Feature request: support secure HTTPS local dev environnement

Right now, I'm developping locally with a compiled Jekyll with a self-signe cert. To use Netlify Dev, I would need it to support secure environment and the ability to either produce it's own self-signed cert, or be able to pass mine as argument.

Wondering the update on this...it's February 2020...

http://localhost is already treated as Secure Context by major browsers, so, you don't really need an https:// address.
Or are you using a custom hostname for local development? In which case I would suggest using localhost instead.
Please elaborate on your problem if this doesn't work for you!

Use case: several web projects and each of them has its own context (cookies, service workers, local storage…). If you expose all of them on http://localhost, you mix the contexts. You'd rather want independant self-signed certs on development domains to be able to work on several contexts without interferences.

Use case: several web projects and each of them has its own context (cookies, service workers, local storage…). If you expose all of them on http://localhost, you mix the contexts.

Thanks @borisschapira, can this issue be resolved by using a different port per context?

@erezrokah Yes, it could, with the appropriate certificate.

@borisschapira, I think was not clear with my suggestion.
Won't http://localhost:8000 and http://localhost:9000 have different context (cookies, service workers, local storage…)?
So to resolve your use case you could run each project on a different port via the --port option?

I think this is needed. Gatsby CLI for example supports running an HTTPS environment via the "-S" flag which uses some library to automatically provision the needed self-signed certificates (I think it's called "devcert".)
localhost isn't enough in a lot of cases to bypass the need for HTTPS, for example some browser APIs won't work without being in an explicit SSL context.

for example some browser APIs won't work without being in an explicit SSL context.

Thank you for the additional information @probablyup, can you share those APIs and cases? That would make it easier to verify those work when the CLI is running in HTTPS mode.

@erezrokah https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts

@erezrokah https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts/features_restricted_to_secure_contexts

The link at the bottom of that page to Secure contexts shows that localhost is a secure context:

We have a lot of code that depends on an internal OAuth client hardcoded to require the https protocol. I know this could be fixed with code changes, but I also would really love to be able to have this. I build my frontend with parcel serve --https which has worked great in the past, but it's unfortunate that I can't make it work with netlify-dev.

Agreed. It's also something that's made very easy with https://github.com/davewasmer/devcert
Would love to see it made available!

Any plans to add this functionality netlify team?

Any plans to add this functionality netlify team?

ButcherBox is interested in sponsoring a bug bounty for this feature, if a maintainer could chat me.

ButcherBox is interested in sponsoring a bug bounty for this feature, if a maintainer could chat me.

Hello 👋  We are planning on adding this feature (we don't have a timeline yet).
I think the implementation would auto generate a self signed certificate with an option to override it.
https://github.com/davewasmer/devcert installs a root CA and requires admin/sudo access so we would like to avoid it.

Hello 👋  We are planning on adding this feature (we don't have a timeline yet).
I think the implementation would auto generate a self signed certificate with an option to override it.
https://github.com/davewasmer/devcert installs a root CA and requires admin/sudo access so we would like to avoid it.

 Thanks, keep us posted.

 Thanks, keep us posted.

Following up here after an internal discussion we had.

That should also work with the live tunnel --live --secure, although the tunnel connection is already secure by default.

Will the above suggestion cover your use cases? cc @mmiller42, @probablyup, @borisschapira
You should get an https URL to access your local dev environment when running netlify dev --live.
If that doesn't work, it would be great if you can provide a reproduction for it.

Following up here after an internal discussion we had.

That should also work with the live tunnel --live --secure, although the tunnel connection is already secure by default.

Will the above suggestion cover your use cases? cc @mmiller42, @probablyup, @borisschapira
You should get an https URL to access your local dev environment when running netlify dev --live.
If that doesn't work, it would be great if you can provide a reproduction for it.

@erezrokah I'm not comfortable allowing remote access just so I can use a secure context locally

@erezrokah I'm not comfortable allowing remote access just so I can use a secure context locally

@erezrokah I ran into this in the weekend too.
My usecase is:

I have an OAuth login to an API that requires an HTTPS redirect URL
I am using Netlfiy functions

I got around the first point by following https://dev.to/nakib/using-https-on-next-js-local-development-server-bcd, which uses mkcert to issue a cert. But that has downsides such as creating a root CA like you mentioned in https://github.com/netlify/cli/issues/455#issuecomment-754121681.
This works well for being able to serve my local site over HTTPS, but the Netlify functions return 404 - I suppose they only work with netlify dev?
It'd be great if we could point a certificate and key to netlify dev and tie these two together. (Maybe configurable in a netlify.toml.local too?)

Thanks @seanarnold, that use case makes sense. You're correct about Netlify functions - netlify dev starts the server for those.

Hi all 👋 Support for HTTPS local development support is released in v3.18.0. See more here.
I've opened a follow up issue https://github.com/netlify/cli/issues/2136 to auto generate certificates.

I can't find this in the current version nor in the docs. This file is no longer exist in the main branch
Is this option dropped along the way?

I can't find this in the current version nor in the docs. This file is no longer exist in the main branch Is this option dropped along the way?

It is still documents in the docs site: https://docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev:~:text=https%3A property that specifies an SSL/TLS certificate and key file for the Netlify Dev local server. By default%2C Netlify Dev starts an HTTP server%2C but you can configure a certificate and key file if you require HTTPS. The https configuration is an object with the following properties%3A
Most docs were moved to the docs site from this repository.
Note that Netlify support is available at https://answers.netlify.com/

Thanks @ramonsnir


Add lakeFS 1.11.1 to Spark client compatibility matrix

Thanks!  You're on a roll, let's see if you can manage the lakeFS release PRs review challenge!


Plex Error: actor: xxxx not found

I have collections for concerts that search for title and actor. The metadata on concerts is not very consistent so searching on both a band name and the members will get me good result. But since the latest changes this has stopped working. If the actor in the plex search doesnt exist then the collection will fail
templates:
  Bands:
    sync_mode: sync
    collection_order: release
    name_mapping: "- Bands/<<collection_name>>"
    plex_search:
      title: <<collection_name>>

collections:
  King Crimson:
    template:
      name: Bands
    actor:
      - Robert Fripp

Scanning King Crimson Collection                                                                   |
| Plex Error: actor: Robert Fripp not found

I also wonder if I can use lists with the templates? I'm quite sure I did it before but now it crashes if I do something like this:
templates:
  Bands:
    sync_mode: sync
    collection_order: release
    name_mapping: "- Bands/<<collection_name>>"
    plex_search:
      title: <<collection_name>>
      actor: <<members>>

collections:
  Led Zeppelin:
    template:
      name: Bands
      members:
        - Jimmy Page
        - Robert Plant
        - John Paul Jones
        - John Bonham

i can have it continue if it cant find the actor and I haven't tried lists in templates ill try it out and see if I can fix it

Makes more sense to treat it like not found instead of aborting the search

The search works now, but the output looks a bit strange
| Scanning King Crimson Collection                                                                   |
| Plex Error: actor: Robert Fripp not found                                                          |
|                                                                                |
| Sync Mode: sync                                                                                |
|                                                                                |
| Processing Plex Search: )                                                                          |
| No items found to add to this collection                                                           |
|                                                                                |
| Processing Plex Search: title(King Crimson)                                                        |
| King Crimson Collection | + | King Crimson: Rock in Rio                                            |
| 1 Movie Processed                                                                                |

This part Processing Plex Search: ). Looks like it's searching even though it already can't find the actor

ok try it again


branch-2.0 Add more indexed column reader be unit test

Proposed changes
Issue Number: close #xxx

cherry-pick from master(#25652 )
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Added Scan and mail run to ORACLE case file

Fingers crossed this one will work. My steps:

Created new fork
Pulled fork
Created new branch
Edited this case
Commit change
Pushed to my repo/fork
Created this PR

"Could not find a usable config.yml, you may have revoked the CircleCI" > I can see CircleCI's config so thats not it

Hmm - fixed it (I think)

Yes you did, now you just have ‘normal’ build errors:
There are 4 errors in the Jekyll build log, not good enough!
ERROR CasesPlugin: Case DIVD-2022-00038, does not have a author set
ERROR CasesPlugin: Case DIVD-2022-00038, does not have a lead set
ERROR CasesPlugin: Case DIVD-2022-00038 does not have an excerpt or the default excerpt
ERROR CasesPlugin: Case DIVD-2022-00038, has invalid status ', should be 'Open' or 'Closed'

Yea, I noticed... These fields exist in the case file though..... So I'll have a look later.

Fixed the issue - it wasn't the missing field but I messed up the yaml syntax


Improve perf and ring buffers performance

It is well known that cgo has bad performance when calling c code, and even worse when calling go callbacks from c (see, for example, https://about.sourcegraph.com/go/gophercon-2018-adventures-in-cgo-performance/).
This is actually not a problem for most of the use cases of libbpfgo, where we just need to load a program and attach it, or update a map, as these operations are not that frequent. It may become a problem, however, when we need to poll for events coming from the kernel through one of the perf/ring buffers, as these are much more frequent.
Suggestion: for buffers polling (either perf or ring buffers) let's implement the logic in pure go. These functions can be added as an alternative API for the already existing functions, and will offer high performance where needed.
Specifically, these are the libbpf functions that we will need to implement: C.perf_buffer__poll() and C.ring_buffer_poll() (both are called by the PerfBuffer/RingBuffer poll() function)

It is well known that cgo has bad performance when calling c code, and even worse when calling go callbacks from c (see, for example, https://about.sourcegraph.com/go/gophercon-2018-adventures-in-cgo-performance/).
This is actually not a problem for most of the use cases of libbpfgo, where we just need to load a program and attach it, or update a map, as these operations are not that frequent. It may become a problem, however, when we need to poll for events coming from the kernel through one of the perf/ring buffers, as these are much more frequent.
Suggestion: for buffers polling (either perf or ring buffers) let's implement the logic in pure go. These functions can be added as an alternative API for the already existing functions, and will offer high performance where needed.
Specifically, these are the libbpf functions that we will need to implement: C.perf_buffer__poll() and C.ring_buffer_poll() (both are called by the PerfBuffer/RingBuffer poll() function)

hello, The conclusions of 2018 are not necessarily appropriate for now,
for example, https://about.sourcegraph.com/go/gophercon-2018-adventures-in-cgo-performance/).

duplicate of #42


sending SMS only in critical ?

i've seen that twilio phone calls are only used for critical level alert .
i was wondering if it's possible to do the same for SMS.
something like for critical alert level , choose between phone call or SMS ?

It would be good for a check to be able to define an escalation pattern, if
you had a proposal of how to implement it I would be happy to review...

as i'm more a sysadmin that a dev, my python knowledge is quite light . so i won't be able to make a PR (see i'm still struggling with the alert-plugin :) )
but, here is the idea.
add an option in the User configuration panel to choose if the he (the user) will be reach by phone or sms for any critical alert triggered .
for the escalation pattern, here is what i think.
add 2 options in the services/instances panel:

escalation user. (User defined in django framework)
escalation debounce (INT)

the escalation user will be reach if a critical alert is triggered when the number of checks defined in the escaltion debounce is reach.
i'm not sure if i'm clear, please correct me if i'm wrong

OK i found how to send sms only for critical alert :-) i'll think about escalation process

i'll close this issue and make a PR one i have a working PoC for escalation process
(if i'm able to make it work :) )


Ingestion Script for Portland Ridership Data Added

This script takes the files provided by Portland's TRIMet Public Records department, and formats the dataset to match our data model. The original data was provided at the day type (Saturday, Sunday, Weekday), season, and stop_id level. For this reason, I restructured the data set to map the provided averages to the corresponding datetime value for 2023.

Note that  Portland's TRIMet Public Records department only provided data for 2023 and for the seasons spring and summer. I emailed the department to ask for clarification as to why we were only provided with data for the spring and summer and I requested the missing seasons as well (it is possible that this is due to the summer having the largest number of route changes); I am waiting to hear back.

Tests passed
Note: the tests are designed to run locally to test the data set stored in our box folder, I cannot get it to pass automatically.

It seems like theres an error with pandas not being added to poetry. Can you please poetry add pandas so the default check works? Thanks!

hmm I have added Pandas in my pyproject.toml and my poetry.lock, but for some reason Pandas is not getting installed during the automatic checks. The tests pass when I run the code in the virtual env from my local computer: e.g. (route_rangers_db_env) MacBook-Air-8:backend jimenasalinas$ poetry run pytest. Do the automatic checks take the last commits?

E           FileNotFoundError: File /Users/meganmoore/Documents/se_for_civic_tech/RouteRangers/backend/tests/../data/pdx_ridership.json does not exist

../../../../miniconda3/envs/route_rangers/lib/python3.11/site-packages/pandas/io/json/_json.py:960: FileNotFoundError
============================================= short test summary info =============================================
ERROR tests/test_portland_ingest.py::test_no_duplicates - FileNotFoundError: File /Users/meganmoore/Documents/se_for_civic_tech/RouteRangers/backend/tests/../data/pdx_r...

Sorry I didn't realize earlier that it was being taken in by manually downloading and not by ingestion which makes this not super transferable or scalable or integrateable for the time being. I think there are 2 options:

if the csv is small enough to put in a data file in the repo we can do that though that is not ideal because it may get out of sync with the current state of things
look into programmatically pulling the csv, maybe using the requests package or sodapy/Socrata it seems like it should be possible to make a request with the API key and get json or csv data back.


Bulk Changing FOIPPA Section - Doesn't Work and App Crashes

Describe the bug in current situation
In the pilot user session, a few users raised that there was an issue with bulk changing redaction codes. After trying to bulk change redactions, the changes didn't apply, and then the app crashed. However, this issue was fixed with a refresh.
This needs to be investigated further to determine cause.
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Undetermined
Chance of Occurring (high/medium/low/very low)
Undetermined
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Actual/ observed behaviour/ results
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Test after #4196 back to QA

@divyav-aot when we do bulk changing FOIPPA Sections, then changes not happening if there is a redaction box inside the other one on the same page.

Created a separate ticket for the above mentioned issue. https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/issues/gh/bcgov/foi-flow/4553
Closing this one as working as expected.


Feature/guidelines

Fixes #1344
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan

[ ] I have verified that I have not introduced new warnings in this PR (or explain why below)
[ ] I have run the unit tests with this PR
[ ] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
[ ] I have tested Android, Java SE, and Java EE

Summary
Adding Guidelines file to Java_suite repo for code formatting.
CLA

[ ] I have signed the CLA

We ended up putting the style guide on the Wiki in the repo here: https://github.com/smartdevicelink/sdl_java_suite/wiki/Java-Suite-Style-Guide


BackendMenu issue with duplication of permission

Every time I update and save a menu item in the BackendMenu, it duplicates the permissions for each of the side-menus.
Example:
 permissions:
                    - voilaah.astar.manage.groups
                    - voilaah.astar.manage.groups
                    - voilaah.astar.manage.groups

Thanks for the report. This should be fixed in v1.1.4


Melisma - Melodic Density Highlighting on Text column

Resolves #7
Melisma: a syllable that has 6 or more neumes
[x] Highlight melisma with a visible background cover (i.e., does not affect other text highlighting for ornamental neumes)
[x] User input for the number of melisma

Looking good!


Feature: option for disabling caching

This pull requests adds a new option to the Memento configuation: disableCachingPatterns, which is an array of objects that have a method and pattern properties.

The method property is a case insensitive HTTP method.
The pattern property is a glob tested against the incoming URL (the minimatch package is used as an implementation).

Fixes #54 .

Codecov Report

Merging #56 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   99.04%   99.06%   +0.02%
==========================================
  Files          21       21
  Lines         417      427      +10
  Branches       41       43       +2
==========================================
+ Hits          413      423      +10
  Misses          1        1
  Partials        3        3

Impacted Files
Coverage Δ

src/domain/entity/index.ts
100% <ø> (ø)
:arrow_up:

src/domain/usecase/RespondToRequest.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f871218...4f3416c. Read the comment docs.

Here's another suggestion for the option name: requestIgnorePatterns.
{
  "requestIgnorePatterns": [{
    "method": "GET",
    "urlPattern": "/pokemon/*/abilities"
  }]
}

From what I see, only the URL can match against the pattern. It would make sense to mention the term "url" in the "pattern" key name.

I definitely like urlPattern more than pattern! Not really about requestIgnorePatterns, I think that disableCachingPatterns is more explicit in the sense that this option... disable caching.
Request are not ignored, they are forwarded using Memento, they just aren't cached.


[flink] Decouple tag Auto Creation logic

Purpose
Decouple tag Auto Creation logic

Tests

API and Format

Documentation

@yuzelin PTAL，thanks.

I don't fully understand why we need to decouple tag Auto Creation logic.

https://docs.oracle.com/javase/tutorial/java/javaOO/nested.html
Compelling reasons for using nested classes include the following:

It is a way of logically grouping classes that are only used in one place: If a class is useful to only one other class, then it is logical to embed it in that class and keep the two together. Nesting such "helper classes" makes their package more streamlined.
It increases encapsulation: Consider two top-level classes, A and B, where B needs access to members of A that would otherwise be declared private. By hiding class B within class A, A's members can be declared private and B can access them. In addition, B itself can be hidden from the outside world.
It can lead to more readable and maintainable code: Nesting small classes within top-level classes places the code closer to where it is used.

So from my perspective, unless:

nested classes become very complex
nested classes need to be used by multiple classes

In this cases, nested class should be an external separate class.
But now, I don't think it is too complicated or used by multiple classes.


Snapshot timestamp t not updated in while loop for simulation

Timestamp t is initialized at this line. In the while loop for simulation, t is used at this line for generating snapshot, but is never updated in the while loop, so no snapshot is actually generated.

It seems that this feature is not maintained any more?

It seems that this feature is not maintained any more?

Yes. Since snapshot can only save the state of verilator, it is difficult to save the state of other Difftest components (e.g., nemu), we don't use snapshot much anymore but use lightsss instead.


Not able to download from mirror set

Describe the bug
Running vcpkg install. It fails as the mirror link is not working.
Environment

OS: [Windows 10]
Compiler: VS Community 2022, v-17.7.6

To Reproduce
Steps to reproduce the behavior:

I am trying to build pico torrent. (https://github.com/picotorrent/picotorrent#building-picotorrent)
I am running the terminal in VS community 2022, version 17.7.6
I am trying to run the last step of build.
dotnet cake --platform=x64 --configuration=Release
The build is failing.

Expected behavior
I am expecting vcpkg to install automatically.
Failure logs
PS C:\Users\Sujeet\Desktop\pico\picotorrent> dotnet cake --platform=x64 --configuration=Release
The assembly 'Cake.CMake, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
is referencing an older version of Cake.Core (1.0.0).
For best compatibility it should target Cake.Core version 3.0.0.
========================================
Clean
========================================
Generate-Project
CMake Deprecation Warning at CMakeLists.txt:3 (cmake_policy):
The OLD behavior for policy CMP0115 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances.  Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- Running vcpkg install
Detecting compiler hash for triplet x64-windows...
Detecting compiler hash for triplet x64-windows-static-md...
The following packages will be built and installed:

boost-crc[core]:x64-windows-static-md -> 1.82.0#1
boost-logic[core]:x64-windows-static-md -> 1.82.0#1
boost-math[core]:x64-windows-static-md -> 1.82.0#1
boost-multiprecision[core]:x64-windows-static-md -> 1.82.0#1
boost-scope-exit[core]:x64-windows-static-md -> 1.82.0#1
libiconv[core]:x64-windows-static-md -> 1.17#1
libtorrent[core,iconv]:x64-windows-static-md -> 2.0.8
nlohmann-json[core]:x64-windows-static-md -> 3.11.2
openssl[core]:x64-windows-static-md -> 3.1.0#4
sqlite3[core]:x64-windows-static-md -> 3.40.1#3
Additional packages (*) will be modified to complete this operation.
Restored 0 package(s) from C:\Users\Sujeet\AppData\Local\vcpkg\archives in 219 us. Use --debug to see more details.
Installing 1/10 libiconv:x64-windows-static-md...
Building libiconv[core]:x64-windows-static-md...
warning: -- Using community triplet x64-windows-static-md. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: C:\Users\Sujeet\Desktop\pico\picotorrent\vendor\vcpkg\triplets\community\x64-windows-static-md.cmake
-- Using cached libiconv-1.17.tar.gz.
-- Cleaning sources at C:/Users/Sujeet/Desktop/pico/picotorrent/vendor/vcpkg/buildtrees/libiconv/src/v1.17-84a471678e.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/Sujeet/Desktop/pico/picotorrent/vendor/vcpkg/downloads/libiconv-1.17.tar.gz
-- Applying patch 0002-Config-for-MSVC.patch
-- Applying patch 0003-Add-export.patch
-- Applying patch 0004-ModuleFileName.patch
-- Applying patch clang-fortify.patch
-- Using source at C:/Users/Sujeet/Desktop/pico/picotorrent/vendor/vcpkg/buildtrees/libiconv/src/v1.17-84a471678e.clean
-- Found external ninja('1.10.2').
-- Getting CMake variables for x64-windows-static-md
-- Using cached msys-gzip-1.11-1-x86_64.pkg.tar.zst.
-- Using cached msys-bash-5.1.008-1-x86_64.pkg.tar.zst.
-- Using cached msys-autoconf-2.71-3-any.pkg.tar.zst.
-- Using cached msys-diffutils-3.8-2-x86_64.pkg.tar.zst.
-- Using cached msys-binutils-2.37-5-x86_64.pkg.tar.zst.
-- Using cached msys-libtool-2.4.7-3-x86_64.pkg.tar.zst.
-- Using cached msys-file-5.41-2-x86_64.pkg.tar.zst.
-- Using cached msys-zlib-1.2.11-1-x86_64.pkg.tar.xz.
-- Using cached msys-libbz2-1.0.8-3-x86_64.pkg.tar.zst.
-- Using cached msys-coreutils-8.32-2-x86_64.pkg.tar.zst.
-- Downloading https://repo.msys2.org/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirror.yandex.ru/mirrors/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirrors.tuna.tsinghua.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirrors.ustc.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirror.selfnet.de/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz;https://mirrors.sjtug.sjtu.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz -> msys-grep-3.0-2-x86_64.pkg.tar.xz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from C:\Users\Sujeet\Desktop\pico\picotorrent\vendor\vcpkg\vcpkg-bundle.json
[DEBUG] Failed to open: C:\Users\Sujeet\Desktop\pico\picotorrent\vendor\vcpkg\vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
Downloading https://repo.msys2.org/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://mirror.yandex.ru/mirrors/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://mirrors.tuna.tsinghua.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://mirrors.ustc.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
warning: Download failed -- retrying after 1000ms
warning: Download failed -- retrying after 2000ms
warning: Download failed -- retrying after 4000ms
Downloading https://mirror.selfnet.de/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
Downloading https://mirrors.sjtug.sjtu.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz
error: Failed to download from mirror set
error: https://repo.msys2.org/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://mirror.yandex.ru/mirrors/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://mirrors.tuna.tsinghua.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://mirrors.ustc.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: WinHttpSendRequest failed with exit code 12007
error: https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: WinHttpSendRequest failed with exit code 12007
error: https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: WinHttpSendRequest failed with exit code 12007
error: https://mirror.bit.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: WinHttpSendRequest failed with exit code 12007
error: https://mirror.selfnet.de/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
error: https://mirrors.sjtug.sjtu.edu.cn/msys2/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz: failed: status code 404
[DEBUG] D:\a_work\1\s\src\vcpkg\base\downloads.cpp(961):
[DEBUG] Time in subprocesses: 0us
[DEBUG] Time in parsing JSON: 15us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 4237us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 14 s (13858035us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):
  Failed to download file with error: 1
  If you are using a proxy, please check your proxy setting. Possible causes are:

  1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
     to `https://address:port`. This is not correct, because `https://` prefix
     claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
     , etc..) is an HTTP proxy. Try setting `http://address:port` to both
     HTTP_PROXY and HTTPS_PROXY instead.

  6. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
     set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
     The value set by your proxy might be wrong, or have same `https://` prefix issue.

  7. Your proxy's remote server is out of service.

  If you've tried directly download the link, and believe this is not a temporary
  download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
  to report this upstream download server failure.

Call Stack (most recent call first):
scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
scripts/cmake/vcpkg_acquire_msys.cmake:26 (vcpkg_download_distfile)
scripts/cmake/vcpkg_acquire_msys.cmake:67 (z_vcpkg_acquire_msys_download_package)
scripts/cmake/vcpkg_acquire_msys.cmake:216 (z_vcpkg_acquire_msys_declare_package)
scripts/cmake/vcpkg_configure_make.cmake:228 (vcpkg_acquire_msys)
ports/libiconv/portfile.cmake:29 (vcpkg_configure_make)
scripts/ports.cmake:147 (include)
error: building libiconv:x64-windows-static-md failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+libiconv
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[libiconv]+Build+error&body=Copy+issue+body+from+C%3A%2FUsers%2FSujeet%2FDesktop%2Fpico%2Fpicotorrent%2Fbuild-x64%2Fvcpkg_installed%2Fvcpkg%2Fissue_body.md
-- Running vcpkg install - failed
CMake Error at vendor/vcpkg/scripts/buildsystems/vcpkg.cmake:892 (message):
vcpkg install failed.  See logs for more information:
C:\Users\Sujeet\Desktop\pico\picotorrent\build-x64\vcpkg-manifest-install.log
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.28/Modules/CMakeDetermineSystem.cmake:170 (include)
CMakeLists.txt:9 (project)
CMake Error at CMakeLists.txt:9 (project):
Generator
Visual Studio 17 2022

could not find any instance of Visual Studio.
-- Configuring incomplete, errors occurred!
An error occurred when executing task 'Generate-Project'.
Error: CMake: Process returned an error (exit code 1).
Additional context
Add any other context about the problem here.

How will I do that ? Where to find vcpkg folder ?

Thanks.

I have the same error and git pull does not solve the issue,

I have the same error and git pull does not solve the issue,

Make sure you are not using an old fork or tag.


feat: add leaf index prediction for LightGBMClassifier

feat: add leaf index prediction for LightGBMClassifier
Keunhyun Oh<EMAIL_ADDRESS>

@imatiach-msft for a review

/azp run

@mhamilton723 Can I see failure logs for unittests?

@ocworld  it seems to be a serialization issue:
[info] - Serialization Fuzzing *** FAILED ***
[info]   java.io.FileNotFoundException: File file:/tmp/SavedModels-5551618842720005323/fitStage/data_9 does not exist
[info]   at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:539)
[info]   at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:752)
[info]   at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:529)
[info]   at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:409)
[info]   at org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.(ChecksumFileSystem.java:142)
[info]   at org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:346)
[info]   at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:766)
[info]   at org.apache.spark.ml.Serializer$.readFromHDFS(Serializer.scala:99)
[info]   at org.apache.spark.ml.ObjectSerializer.read(Serializer.scala:143)
[info]   at com.microsoft.ml.spark.core.serialize.ConstructorReader$$anonfun$1.apply(ConstructorWriter.scala:84)
[info]   ...
[info]   + Creating a spark session for suite VerifyLightGBMClassifier

/azp run

@ocworld  I reran the build and it is getting same serialization error in the test suite, I can take a look maybe sometime this week to see if I can spot the issue by getting the branch and debugging locally

@imatiach-msft Thank you for your review and providing error logs. About error call stacks, can I see more logs including failed code line in VerifyLightGBMClassifier.scala? In my new test case, any file is not read expect for bank.tain.csv.  So, It is hard to assume that where is a failed line and what test case is failure.

@ahnlab-oss

/azp run

/azp run

@mhamilton723  @ocworld got the branch locally today, I found that there was a parameter missing in objects to save which caused the serialization test to fail.  The tests now pass locally for me, hopefully the build should be green too now.


311-dev CI failures [2024-03-16]

Current failures in 311-dev CI are due to a fiona/geopandas compatibility issue that is being resolved in https://github.com/geopandas/geopandas/pull/3209. @martinfleis recommend ignoring. Creating this issue merely for sanity check.

xref: https://github.com/pysal/spaghetti/issues/762

Resolved in current CI.


[SPARK-44872][CONNECT][FOLLOWUP] Deflake ReattachableExecuteSuite and increase retry buffer

What changes were proposed in this pull request?
Deflake tests in ReattachableExecuteSuite and increase CONNECT_EXECUTE_REATTACHABLE_OBSERVER_RETRY_BUFFER_SIZE.
Why are the changes needed?
Two tests could be flaky with errors INVALID_CURSOR.POSITION_NOT_AVAILABLE.
This is caused when a server releases the response when it falls more than CONNECT_EXECUTE_REATTACHABLE_OBSERVER_RETRY_BUFFER_SIZE behind the latest response it sent. However, because of HTTP2 flow control, the responses could still be in transit. In the test suite, we were explicitly disconnecting the iterators and later reconnect... In some cases they could not reconnect, because the response they last seen have fallen too fare behind.
This not only changes the suite, but also adjust the default config. This potentially makes the reconnecting more robust. In normal situation, it should not lead to increased memory pressure, because the clients also release the responses using ReleaseExecute as soon as they are received. Normally, buffered responses should be freed by ReleaseExecute and this retry buffer is only a fallback mechanism. Therefore, it is safe to increase the default.
In practice, this would only have effect in cases where there are actual network errors, and the increased buffer size should make the reconnects more robust in these cases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
ReattachableExecuteSuite.
Did more manual experiments of how far the response sent by client can be behind the response sent by server (because of HTTP2 flow control window)
Was this patch authored or co-authored using generative AI tooling?
No.

cc @hvanhovell @dongjoon-hyun

It seems that another suite starts to fail. Is it related?

Just to confirm, will the case mentioned by  https://github.com/apache/spark/pull/42560#issuecomment-1718968002 also be fixed in this PR?

@LuciferYang I tried looking at https://github.com/apache/spark/pull/42560#issuecomment-1718968002 but did not reproduce it yet. If you have more instances of CI runs where it failed with that stack overflow, that could be useful.
Inspecting the code, I don't see how that iterator could get looped like that...

Merged to master.

@LuciferYang I tried looking at #42560 (comment) but did not reproduce it yet. If you have more instances of CI runs where it failed with that stack overflow, that could be useful. Inspecting the code, I don't see how that iterator could get looped like that...

https://github.com/apache/spark/actions/runs/6215331575/job/16868131377
https://github.com/apache/spark/actions/runs/6209111340/job/16855995643
https://github.com/apache/spark/actions/runs/6201858651/job/16839435036

It seems that this issue is relatively easy to reproduce on Github Action. In the past three days, daily tests on Scala 2.13 have all experienced 'StackOverflowError'`

dev/change-scala-version.sh 2.13
build/sbt "connect/test" -Pscala-2.13

@juliuszsompolski When I run the above command during local test, it is easier to reproduce StackOverflowError.

@LuciferYang I tried looking at #42560 (comment) but did not reproduce it yet. If you have more instances of CI runs where it failed with that stack overflow, that could be useful. Inspecting the code, I don't see how that iterator could get looped like that...

Although it seems quite magical, after https://github.com/apache/spark/pull/42981 eliminated an ambiguous references in org.apache.spark.sql.connect.client.CloseableIterator, the test abandoned query gets INVALID_HANDLE.OPERATION_ABANDONED error no longer occurs java.lang.StackOverflowError  in my local tests, let's monitor the GA test with Scala 2.13.

@dongjoon-hyun @juliuszsompolski I think branch-3.5 also need this pr

Let me backport it to 3.5.

Thanks @hvanhovell


attempt to fix issue #1170

for me this works fine, seems something got not copied when migrated from PDOAdapter to AbstractAdapter!
Perhaps additional checks are needed but my use cases fork fine again!

Thanks!


Allow (Path)DataLoader to index files

Right now DataLoader (and PathDataLoader as introduced in [edit: Gitlab Issue 90] in particular) can only load files provided to them. To allow for a more flexible approach it might be an idea to offer a find_files / index method or similar which provides the loader with a path to a folder and allows it to discover all loadable data within it.
Upsides of such an approach:
No need to wory about file extensions. The loader can discover all files it can load (and might use the extension for that), but the user doesn't need to provide one.
Support for more "complicated" data types which do not consist of a single file (e.g. ros bags)
Downsides:
Adds more complexity to the code (there must be an index method, however this could be overloaded / inherited for "simple" loaders)
Only really useful for the time series loader (where this problem originally arose).
@mknitt perhaps you have an opinion on this? This could be a relatively simple solution to your "rosbag problem" as well as the problem of different length data from different sources.
(Gitlab Issue 113, created by @ChristianWieck)

There is a new proposal in #110 for this.


docs: update SUPPORT with OSM and K8s version support

Signed-off-by: Zach Rhoads<EMAIL_ADDRESS>Description: Provide details on which versions of OSM are supported on which versions of Kubernetes in support file.
Testing done: Verified file displays correctly.
Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ x ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? yes

Codecov Report

Merging #4853 (4147d03) into main (8cf4c94) will decrease coverage by 0.52%.
The diff coverage is 31.16%.

@@            Coverage Diff             @@
##             main    #4853      +/-   ##
==========================================
- Coverage   67.93%   67.40%   -0.53%
==========================================
  Files         197      198       +1
  Lines       16002    16155     +153
==========================================
+ Hits        10871    10890      +19
- Misses       5078     5212     +134
  Partials       53       53

Flag
Coverage Δ

unittests
67.40% <31.16%> (-0.53%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/catalog/mock_catalog_generated.go
0.00% <0.00%> (ø)

pkg/certificate/certificate.go
82.97% <ø> (ø)

pkg/certificate/fake_manager.go
75.53% <0.00%> (-4.06%)
:arrow_down:

pkg/certificate/providers/compat.go
62.50% <0.00%> (-8.93%)
:arrow_down:

pkg/certificate/providers/mrc.go
33.33% <0.00%> (-3.04%)
:arrow_down:

pkg/certificate/types.go
100.00% <ø> (ø)

pkg/k8s/mock_controller_generated.go
3.33% <0.00%> (-0.11%)
:arrow_down:

pkg/k8s/types.go
100.00% <ø> (ø)

pkg/utils/mesh_config.go
0.00% <0.00%> (ø)

pkg/certificate/mrc_reconciler.go
13.63% <13.63%> (ø)

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Block header hash calculated not properly

Can't reproduce block hash calculation:
{ number: 200,
  hash: '0xc9e562b66933fb390bc935c046eac4223c47f338bc666c4debde94778c2c7534',
  parentHash: '0x51c9c3fb1d99d7fe9a66e57235983ac5e4d0954032ace9408b28a6754d5efd63',
  mixHash: '0x0000000000000000000000000000000000000000000000000000000000000000',
  nonce: '0x0000000000000000',
  sha3Uncles: '0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347',
  logsBloom: '0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  transactionsRoot: '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421',
  stateRoot: '0x2037312fee597a6aef9529de0bbf7c00a2688994d23530c4669fe4a18fe3522a',
  receiptsRoot: '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421',
  miner: '0x0000000000000000000000000000000000000000',
  difficulty: 0,
  totalDifficulty: 0,
  extraData: '0x',
  size: 1000,
  gasLimit:<PHONE_NUMBER>4415,
  gasUsed: 0,
  timestamp:<PHONE_NUMBER>,
  transactions: [],
  uncles: [] }

Here is raw BlockHeader constructed with ethereumjs-block/blockFromRpc:
[ <Buffer 51 c9 c3 fb 1d 99 d7 fe 9a 66 e5 72 35 98 3a c5 e4 d0 95 40 32 ac e9 40 8b 28 a6 75 4d 5e fd 63>,
  <Buffer 1d cc 4d e8 de c7 5d 7a ab 85 b5 67 b6 cc d4 1a d3 12 45 1b 94 8a 74 13 f0 a1 42 fd 40 d4 93 47>,
  <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00>,
  <Buffer 20 37 31 2f ee 59 7a 6a ef 95 29 de 0b bf 7c 00 a2 68 89 94 d2 35 30 c4 66 9f e4 a1 8f e3 52 2a>,
  <Buffer 56 e8 1f 17 1b cc 55 a6 ff 83 45 e6 92 c0 f8 6e 5b 48 e0 1b 99 6c ad c0 01 62 2f b5 e3 63 b4 21>,
  <Buffer 56 e8 1f 17 1b cc 55 a6 ff 83 45 e6 92 c0 f8 6e 5b 48 e0 1b 99 6c ad c0 01 62 2f b5 e3 63 b4 21>,
  <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ... >,
  <Buffer >,
  <Buffer c8>,
  <Buffer 0f ff ff ff ff ff>,
  <Buffer >,
  <Buffer 5c 01 21 61>,
  <Buffer >,
  <Buffer 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00>,
  <Buffer 00 00 00 00 00 00 00 00> ]

And hash of this raw data (utils.rlphash(block.header.raw)):
0xf579b522fd8e0f024333c6af3df45061501dd5efa37b553c532cfd5ed89d0035

is not equal to original block hash:
0xc9e562b66933fb390bc935c046eac4223c47f338bc666c4debde94778c2c7534

Related to https://github.com/ethereumjs/ethereumjs-block/issues/2#issuecomment-443178876

Possibly related to https://github.com/trufflesuite/ganache-cli/issues/387

I think I discovered the issue. Ganache-core is using a very old version of ethereumjs-block (1.2.2). There was a bug fix in 2.0.0 (https://github.com/ethereumjs/ethereumjs-block/pull/42) that ensures that the nonce field is always 8 bytes long. Prior to that release, the default nonce value is an empty buffer. This is the reason the hash value is incorrect.
So the fix is to upgrade ethereumjs-block to 2.0.0 or later

@vpulim, thanks for looking into this! Feel free to make a PR with the updated version. If you want to add a test for this that'd be amazing, but if not, one of us at Truffle can add the tests before merging into develop.

@davidmurdoch No problem!
https://github.com/trufflesuite/ganache-core/pull/238


fix: delete individual ds without blocking other ds

Description
Delete individual datasource without blocking other datasources to be deleted while the deletion is in progress.
Fixes #17550
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=4d80329

Tested this PR on the localhost created with the fix branch.

I am able to delete other datasources even before one of the DS is completely deleted. The delete on others no longer has the busy symbol
However, as compared to release the deletion of each DS seems a tad slower on this PR (MySQL and GS, Deleted MySQL first, and then GS, MySQL took almost 5 seconds to get deleted, as against about 1 second in the Release url).
Also, refer the performance test link above. I do see a lot of red numbers. Is that anything of concern here? I bring this up as we are starting to look at this link as well - as a QA process to test in the Needs QA pipeline.
@AmanAgarwal041  @rohan-arthur

/ok-to-test sha=4ff2344

After the changes by Aman, the functionality looks good.

Adding the label Test Plan Approved as the issue is moved to QA done pipeline.

Adding the label Test Plan Approved as the issue is moved to QA done pipeline.

thanks @AmanAgarwal041  - missed that!


python311Packages.langchain: 0.0.320 -> 0.0.325; python311Packages.langsmith: 0.0.49 -> 0.0.53

Description of changes

python311Packages.langchain: 0.0.320 -> 0.0.325
Diff: https://github.com/langchain-ai/langchain/compare/refs/tags/v0.0.320...v0.0.325
Changelog: https://github.com/hwchase17/langchain/releases/tag/v0.0.325

python311Packages.langsmith: 0.0.49 -> 0.0.53
Diff: https://github.com/langchain-ai/langsmith-sdk/compare/refs/tags/v0.0.49...v0.0.53
Changelog: https://github.com/langchain-ai/langsmith-sdk/releases/tag/v0.0.53

python311Packages.openapi-schema-pydantic: remove
It has been removed since it is no longer maintained

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 264368 run on aarch64-darwin 1

10 packages failed to build:

pentestgpt
pentestgpt.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.langsmith
python310Packages.langsmith.dist
python311Packages.langchain
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist


Selections surround the icons on Gantt bug

Instead of just centering the selection, the selection should surround the icon clicked. This is what happens on implementation of gantt in MAR:

Why is this a bug?

I am not sure if it is a bug or if it really is a feature request because the code is functioning as designed. It is aligning the selection in the center of the row but in reality it should surround the event that is clicked, wherever that is aligned in the row.

So this is an enhancement for selection indicator to conform to the shape of the icon?

Not just match the shape of the icon, but also the placement within the row. But I guess so... yes. If it encompasses the icon, it should align to wherever the icon is placed in the row. So maybe it is already covered by: https://github.com/cerner/carbon-graphs/issues/5 ?

If so then can we close this?

This is covered by #5 so I am closing.

Separating this as a separate issue to the selection shape.

Separating this as a separate issue to the selection shape.


Resurrect framian pt. 1

This is a lil bit of work to try and get framian in a better place:

Drop 2.10.x support (cross publishing, macros)
Kill framian-json
Revbump shapeless from 2.0.0 => 2.3.0 (everything seems to be fine locally (JDK 8)... tests pass)
Update travis.yml to not cross build and use jdk7/8 (unsure if this will actually pass... Travis is still seems finicky)

There's more I wish to do but didn't want to let the PR get too large:

Change organization and the source headers to be not-Pellucid (your choice here)
Fix publishing (perhaps use sbt-release here) and publish under whatever organization, perhaps not-Bintray as well
Fix ScalaDoc publishing, maybe using a combination of sbt-ghpages and sbt-site and maybe pushing it to the *.github.io domain?
Bump sbt plugins (and perhaps figure out what's going on here... https://github.com/tixxit/framian/blob/0494ee1a1eb5adb69c1f51bf552ef636daeca7f4/project/plugins.sbt#L6-12)
Fast-forward compile/test dependencies where possible, fix compilation issues that will arise from skipping lots of version numbers. I wasn't able to drop in spire 0.11.0 from 0.8.2 due to some compile errors that I didn't want to tackle just yet.
specs2 => ScalaTest if that's desireable (I know it is by me :D, but I remember you saying you were thinking about doing this a long time ago, seems doable but a largely mechanical task)

:pray: Please let me know if I missed anything or if you'd like something else not mentioned above. :pray:

Broken jdk7 buid on Travis appears to be a common thing: https://github.com/travis-ci/travis-ci/issues/5227

(also https://github.com/travis-ci/travis-ci/issues/5669)

This all looks great. If you don't mind the net.tixxit org for now, I have that set up for publishing on sonatype and can add the release pluging tonight. I'll probably just copy the config over from delimited which is set up for publishign scaladocs and releasing to sonatype already.
Definitely :+1: to specs2 => scalatest

Feel free to merge.

@tixxit cool - I'll leave the publishing and doc build settings unfiddled-with so you can drop in your stuff to do so later.


Nested tags property and eliminate extra tag creation

#574, potentially #582 and #473

The tests pass, there are tests for looping nested children, not sure if you have a different use case?

ok, this fails if I put the tag inside a second div, so need to check at all levels, not sure what would be a good way, maybe walk back until either a tag or body is found checking for 'each' along the way, or maybe this can be flagged in the walk, will investigate.

I think we should be good with nesting levels in a loop, updated test for 0-3 levels deep

awesome job man :clap:

@rsbondi I think with your pull request now we cannot detect all the tags after an each loop. May you check whether it's possible to switch back the isLoop flag to false again?

@please switch to the branch bug/599 to check my tests


Utils plugin missing error

Hey! You have only PHP and CakePHP in requirements but this plugin needs Utils plugin to work. Also in Composer there is no Utils plugin in requirements so it doesn't install itself.
Just plain error when trying to install by your Quick Start Guide. If you have time, please look at it, it's just a minute. Thanks! :)

Still unresolved.


Help with what version to install?

I have a cuda compute capability 3.0 GPU ,AMD processor and running on windows 10 64bit . So when I checked the official tensorflow website it says requires cuda compute capability 3.5 or higher.
So which version should I install from the repository to support cuda 3.0 and run on my computer.

https://www.tensorflow.org/install/gpu

TensorFlow officially supports NVIDIA GPU. For using AMD gpu you have to compile TensorFlow using OpenCL. Please read this [setup guide] (https://developer.codeplay.com/computecppce/latest/getting-started-with-tensorflow) to get more insights on TensorFlow AMD Setup.

TensorFlow officially supports NVIDIA GPU. For using AMD gpu you have to compile TensorFlow using OpenCL. Please read this setup guide to get more insights on TensorFlow AMD Setup.

Actually I have a NVIDIA GPU but it is cuda compute capability 3.0 GPU but tensorflow gpu support 3.5. So I was looking for a workaround.

That's right: our supported capabilities are 3.5 and 5.2. It may be possible to build for 3.0 from source, but we don't support that configuration, and some of the standard kernels may use features that require a more powerful GPU.


Gdi+ capability check revision

Reference Issue
Following the remarks in #502 by @H1Gdev
What does this implement/fix? Explain your changes.
Added a function to query gdi+ capabilities in the SVGDocument and changed the working of the document load to call an ensure function that will throw the gdi exception instead of having a large try-catch block with multiple exception type queries. The new functions are "tested" in 2 simple unittests that allows developers to check their capabilities by executing the tests.
Also updated the csproj of the SVG project to only include the mac version for the targeted framework (I encoutered some issues with targeting).

@gvheertum - thanks for the PR! Could you please rebase (or reimplement) your commit to a new branch branched from master? Otherwise it may get complicated with the conflicts...

I’ll see if I can do this. Still struggling with git sometimes. I did make my own master up to date with your master and branched from there, but now I see it tries to push a whole lot more commits in the PR...

I usually make a new branch from origin master for each PR, and do not use my own master at all. Or I rebase --hard my own master to origin master and go from there, otherwise all these merge commits get in the way... I could also do the rebasing for you, if you have trouble.

What I would do in your case: create a new branch from origin master, and cherry-pick the relevant commit there (resolving conflicts if needed).

Thanks, I sometimes get confused with multiple origins (only used to local and 1 main origin). With your tips I was able to make a new PR (#512) with only the 3 commits that are relevant.


Code search broken

Description
When trying to search for code on any section of the site (explore, org, repo) the following error occurs:
An error occurred:

Render failed, failed to render template: repo/search, error: template error: builtin(bindata):repo/search:56:87 : executing "repo/search" at <Safe>: wrong type for value; expected string; got template.HTML
----------------------------------------------------------------------
												{{.FormattedLines | Safe}}
												                                                                    ^
----------------------------------------------------------------------

Gitea Version
1.21.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
Rootful docker image
Database
SQLite

As the bug report template says:
3. Make sure you are using the latest release and
take a moment to check that your issue hasn't been reported before.

->  Error rendering code search page #28580
->  Searching commits gives error 500 #28575
It should have been fixed by " Fix 500 error of searching commits (#28576) #28579 " in 1.21 nightly.
Sorry for the bug.

You're right, sorry for not checking the already closed issues. Thank you for the fix :)


[entropy_src,sw] Make KAT test more robust

The entropy_src KAT test's use of non-blocking data reads is important. However it leaves the test vulnerable to false failures due to timing
delays within the IP.   This commit issues a number of retry attempts
whenever the ENTROPY_DATA register is read.
Signed-off-by: Martin Lueker-Boden<EMAIL_ADDRESS>

Thanks @martin-lueker :+1: If this PR is done from your side, I can implement @moidx's feedback and get this merged? Then it would be off your table

Thanks @martin-lueker 👍 If this PR is done from your side, I can implement @moidx's feedback and get this merged? Then it would be off your table

Hi Andreas,  Sure if you like.  In my opinion though, it has not been a high priority (which is why it has collected some dust). I threw this one up when I was barking up the wrong tree for a top-level CI error at some point.   May be a "nice-to-have" for M2

Thanks for the feedback @martin-lueker , I'll take care of rebasing this and implementing the minor changes. It's always good to get things out of the way if possible.

I've now implemented the remaining feedback points and afterwards also rebased this on current master. Now running the chip-level tests in parallel to CI.

The top-level test passed with Verilator, Xcelium and VCS. We can merge this once CI ran through.


Producer hangs when Retry.Max is 0

(This is also poor behaviour in other configurations in that it can "waste" some of the configured retries, but is otherwise not a problem - it doesn't break ordering or anything.)
The leaderDispatcher function only knows to check for a new leader when it receives a message with a new retry value, but there are at least two cases (possibly more?) where for various reasons the flusher fails but never sends a retriable message to the leaderDispatcher:

all of the messages are at their retry limit, and get returned to the user instead
there is a topic/partition led by that broker, but with no messages in the current batch, when the broker connection dies

In both of the above cases, we can end up with a leaderDispatcher whose broker is toast, but doesn't know it and so doesn't try and get a new one.
In the normal case, the next message (not at the retry limit) will get spun around anyways and kick things off the way it should; this is less than ideal (we waste a retry for the message(s) in question) but not a very severe problem as by default we have three retries configured and typically only need one.
However, in the case where someone sets MaxRetries to 0, every subsequent message is immediately returned to the user and the producer ends up stuck.

The following test will pass/fail this issue, it should be copied into producer_test.go when this is fixed.
func TestProducerOutOfRetries(t *testing.T) {
        seedBroker := NewMockBroker(t, 1)
        leader := NewMockBroker(t, 2)

        metadataResponse := new(MetadataResponse)
        metadataResponse.AddBroker(leader.Addr(), leader.BrokerID())
        metadataResponse.AddTopicPartition("my_topic", 0, leader.BrokerID(), nil, nil, NoError)
        seedBroker.Returns(metadataResponse)

        client, err := NewClient("client_id", []string{seedBroker.Addr()}, nil)
        if err != nil {
                t.Fatal(err)
        }

        config := NewProducerConfig()
        config.FlushMsgCount = 10
        config.AckSuccesses = true
        config.RetryBackoff = 0
        config.MaxRetries = 0
        producer, err := NewProducer(client, config)
        if err != nil {
                t.Fatal(err)
        }

        for i := 0; i < 10; i++ {
                producer.Input() <- &MessageToSend{Topic: "my_topic", Key: nil, Value: StringEncoder(TestMessage)}
        }

        prodNotLeader := new(ProduceResponse)
        prodNotLeader.AddTopicPartition("my_topic", 0, NotLeaderForPartition)
        leader.Returns(prodNotLeader)

        for i := 0; i < 10; i++ {
                select {
                case msg := <-producer.Errors():
                        if msg.Err != NotLeaderForPartition {
                                t.Error(msg.Err)
                        }
                case <-producer.Successes():
                        t.Error("Unexpected success")
                }
        }

        seedBroker.Returns(metadataResponse)

        for i := 0; i < 10; i++ {
                producer.Input() <- &MessageToSend{Topic: "my_topic", Key: nil, Value: StringEncoder(TestMessage)}
        }

        prodSuccess := new(ProduceResponse)
        prodSuccess.AddTopicPartition("my_topic", 0, NoError)
        leader.Returns(prodSuccess)

        for i := 0; i < 10; i++ {
                select {
                case msg := <-producer.Errors():
                        t.Error(msg.Err)
                case <-producer.Successes():
                }
        }

        leader.Close()
        seedBroker.Close()
        safeClose(t, producer)
        safeClose(t, client)
}

I feel the solution should be that we have a way to actively invalidate (remove) metadata as soon as we encounter a problem, so the subsequent message has no choice but to request fresh metadata. Maybe we should invalidate all cached metadata for a broker in disconnectBroker?

The problem is not actually in the client - the metadata in the client is correctly invalidated in this case. The problem is that the leaderDispatcher keeps a local "cache" of its brokerProducer (via the local output variable), and it relies on a "retried" message to come back in order to invalidate that cache.

Once #300 happens there are several easy ways to solve this. One of them is to fetch the brokerProducer on every iteration of the leaderDispatcher (which would require tweaking how we reference-count those slightly). Another is to send a dummy "trigger" message (using flags) around on failure to all the affected leadersDispatchers, even if they didn't have a message in the batch.

Hello. So it looks like my issue #509 is a duplicate of this bug. Do you have any plan to fix that issue?
Now I am trying to configure built-in retry mechanism, but I have a question. Are you retrying network and circuit breaker errors? I am using a round robin partitioner and it will be great if you can automatically reassign partition in case of circuit breaker or network error.

Do you have any plan to fix that issue?

Yes, it's just slow going as it mostly depends on the refactoring in #300. That is almost done however.

Are you retrying network and circuit breaker errors?

The producer retries only errors resulting from actual Produce requests. Errors from metadata requests and similar are not retried in the producer because they are already retried at the client level. Errors from circuit-breakers are not retried, because that would defeat the entire purpose of having the circuit-breaker.

Errors from metadata requests and similar are not retried in the producer because they are already retried at the client level.

And what about network errors when producing a message? Is this the same case?

Errors from circuit-breakers are not retried, because that would defeat the entire purpose of having the circuit-breaker.

You can automatically assign an available partition when using random or round robin partitioner. Ordering is not important for that messages.

And what about network errors when producing a message?

Network errors when producing a message are retried.

You can automatically assign an available partition when using random or round robin partitioner. Ordering is not important for that messages.

Hmm, yes that would be a good improvement. Perhaps file a separate enhancement request to track this idea.

Does anyone know if this is still an issue. Can we close it now? @bai @eapache

Hmmm, doesn't seem so — I'm going to close it but feel free to reopen if you think otherwise 🙌


Update readme, comments and docs

Before merging, we could update some things based on the notes that we made about the docs and the methods  🤷♀ (?) @zehsilva @oddaspa

Before merging, we could update some things based on the notes that we made about the docs and the methods 🤷♀ (?) @zehsilva @oddaspa

I don't want to increase the scope of this PR as this is mostly about the readme and docs. Let's add that to the backlog and do it as soon as possible after the experimentations.


Doesnt compile for production

Jodit Version:  3.4.xxxxx
Browser:
OS:
Is React App:
Code
// A *self-contained* demonstration of the problem follows...

Expected behavior:
Compiles for production
Actual behavior:
Doesnt compile for production. Doesnt work.

./node_modules/jodit/src/core/selection/select.ts:91:31
Type error: Property 'getSelection' does not exist on type 'ShadowRoot'.

  89 |  get sel(): WindowSelection {
  90 |          if (this.j.o.shadowRoot) {
> 91 |                  return this.j.o.shadowRoot.getSelection();
     |                                             ^
  92 |          }
  93 |
  94 |          return this.win.getSelection();

How to fix it ?


Unable to access documentation

Hi,
I am unable to view the API documentation at http://docs.fullscale.co/elasticjs/ . Please check the same.
Regards,
Suhas

Still not accessible :(

Yes, documentation appears to be down. =(

Still inaccessible.   :(

Still down

We started using this fork today: http://github.com/ErwanPigneul/elastic.js
It seems to have active development and its documentation is here: https://cdn.rawgit.com/ErwanPigneul/elastic.js/master/dist/docs/ejs.html

entire domain is down...what happened? did the guys quit?

If they dissolved they should at least let everyone know. Also I'm not sure how active the ErwanPigneul fork is. Last commit was November of last year.

Anyone still using this project? Does not look like its actively managed and documentation site is still down?


learning-logs: should handle multiple URLs when there are multiple activities under a single entry

Acceptance

[ ] All links appear next to entries where they are expected. I.e. each activity is linked properly, not the whole entry (which contains multiple activities).

Tasks

[ ] TBD

Analysis
When the input looks like this:

The current output looks like this:

This is not ideal. The link here is for the first activity. However, the second and third activities have a different link. In this case, the entry should not have a link and all individual activities should be linked instead.
There can be other cases too:

Activity number 2 (3, or more) could have a link and activity 1 could have no URL associated with it, therefore only the activity 2 should have a link.
There could be a single activity, in which case it must not be linked (current behavior is to link the entry -> this is as expected).
There could be multiple URLs under a single entry due to having multiple activities, but the link could be the same for all these activities. If this is the case, then only the entry should be linked, not all activities pointing to the same URL.

As soon as there are at least two distinct URLs under a given entry, then all activities with an associated URL should be linked and the entry should not be linked.

WONTFIX: I don't use this tool anymore for the time being, I can live with the fact it's slightly broken in an almost unnoticeable way.


Improvement suggestion for deployment

Resource Graph related error still exists for installation despite elevated privs, consider checking if module exists and just running import.
As you do with the workspace, consider asking to use an existing Action group or create new

Deployement now uses custom portal UI.


[Bug]: api/v1/applications is throwing 401 intermittently

Is there an existing issue for this?

[X] I have searched the existing issues

Description
This issue is observed in CI, where on navigating to a page ( Eg: /settings/general) api/v1/applications is throwing 401 error. As a result page is throwing unauthorised error.

Steps To Reproduce

Visit any page in appsmith( Eg: /settings/general)

Public Sample App
No response
Environment
Release
Issue video log
https://user-images.githubusercontent.com/119562824/233984612-5cc19dbf-0ea9-4c60-94aa-1e6b05497920.mp4
https://user-images.githubusercontent.com/119562824/233987073-83a00f06-29a6-43a4-b96e-6c0c49dfe31a.mp4
Version
Release

Recent runs with above failure run1 run2

Recent runs with above failure run1 , run2

The only way to replicate this scenario is when the SESSION cookie isn't present, so this is the most likely scenario.


Override API connection via step inputs

Checklist

[ ] I've read and followed the Contribution Guidelines
[ ] step.yml and README.md is updated with the changes (if needed)

Version

Requires a MAJOR/MINOR/PATCH version update
Context

Changes

Investigation details

Decisions

Looks good.


Fixed broken link

https://releases.hashicorp.com/consul/0.5.2/consul_0.5.2_${os}_amd64.zip is correct.

Thanks, @lwoydziak!


Include OSRM's profiles/lib/destination.lua for Destination Signs

https://github.com/Project-OSRM/osrm-backend/pull/2328 adds a new profiles/lib/destination.lua Lua library for Destination Sign handling. Tracking here so we don't forget about it.

Done.


do somthing about magic numbers?

should i read em from a file or is that too fancy for a joke project?

well burn that bridge when we get there


Duplicate calendar

Summary

Copy to New Schedule functionality
Enforce unique schedule names when creating new duplicates

Test Plan
Issues
Closes #1034
Future Followup

Can reuse getNextScheduleName to enforce unique schedule names on generic schedule creation

While you're here, can you replace the dropdown with a list of buttons? There's no reason to select, then having to press a button.

Update: discussed with AA team to prioritize a simpler and more familiar duplication functionality (e.g. Make a Copy from Google Docs). The copy schedule modal is now only going to allow the making of duplicate schedules, removing "Copy to All Schedules" and "Copy to Schedule".

Currently when the user tries to duplicate a schedule, a unique schedule name is enforced upon schedule creation, even if what they enter already exists.
For example, if Winter-2025 exists, and a schedule tries to be duplicated with the name Winter-2025, a number (e.g. (1)) will be appended to the schedule name upon creation.
However, users are still able to have schedule with duplicate names in these cases:

They have existing schedules with duplicate names already
They rename a schedule to an already existing schedule name
They create a new schedule using an already existing schedule name

To help migrate towards a system where all schedule names are unique, we should enforce the same naming validation in the duplicate schedule feature for 2 and 3 (renaming and creating schedules).


[WFLY-15018] Manage the BouncyCastle Jakarta Mail dependency with Wil…

…dFly Core
Jira issue: https://issues.redhat.com/browse/WFLY-15018
Requires https://github.com/wildfly/wildfly-core/pull/4670

/retest

core-upgrade-needed label can be removed, the failure on the Dependency Tree is because this PR was created requiring the core upgrade, it could be ignored now

@yersan The WF Preview jobs fail with this:
https://ci.wildfly.org/viewLog.html?buildId=267211&buildTypeId=WF_WildFlyPreviewLinuxJdk11&tab=buildLog
https://ci.wildfly.org/viewLog.html?buildId=267213&buildTypeId=WF_Ee9BootableJarLinuxJdk8&tab=buildLog

@bstansberry The problem with the EE 9 Jobs was the Jobs are not using a merge commit and were executed with my topic branch behind the WildFly Core upgrade that incorporates the required changes; I should have rebased the changes before as soon as core as merged in full. I've rebased and pushed them up, here are the new links:
https://ci.wildfly.org/viewLog.html?buildId=267372&buildTypeId=WF_WildFlyPreviewLinuxJdk11&tab=buildParameters
https://ci.wildfly.org/viewLog.html?buildId=267374&buildTypeId=WF_Ee9BootableJarLinuxJdk8&tab=buildParameters
They should be fine now, we have even run an integration Job for EE9 preview even before merging the wildfly core changes, let's see how they go now.


Add Reply section to comments

Is your feature request related to a problem? Please describe.
Reply feature is not present in comments
Describe the solution you'd like
We can add it

@harsh-9in Please give me points for raising this issue

https://gitter.im/NWoC20/Blogger this is the gitter room of blogger in this i have shared a sheet in which there is detail of points which corresponding pr and issues. You can checkout this if you find any missing point then ping me there : )

@harsh-9in Please provide this issue label of it's dificulty as well as label of nwoc.

@harsh-9in I would like to contribute to this issue under DWOC program. Could you please assign this issue to me?

Jahnavi i will be working on it as the issue is raised by me.

Okay @Vrindagupta6828. Not a problem. Thanks for confirming :)

Currently, we are not proceeding with this issue : )

Why?

Why?

Currently, we will focus on bugs and improvement of ui.


QQ: dockerize?

I'm looking for something very much like this but i'd like to be able to run it using docker containers. I'm not that familiar with the vagrant part. Wondering if you have suggestions on how to make this work within docker?

bash provision scripts can be converted easily to docker file's
apt-get instal -y pkgname -> RUN apt-get instal -y pkgname

but see https://docs.vagrantup.com/v2/provisioning/docker.html
;)
i'm replacing this repo with https://github.com/hillar/CDMCS, but it takes time....


padding: 0 for defaultPaginationStyles root

Bug fix for issue #1049.

Coverage remained the same at 77.308% when pulling 624858c44350f3ec3ec59c39f6c3187cf864528f on joshwaiam:bugfix/issue-1049-pagination-padding into 2d37c383beeebb039fae2b6e0b531ddb7959e2ce on gregnb:master.

Hey @joshwaiam, thanks so much for getting involved!
I'm trying to test the change, but I'm having trouble finding where the breakage occurs normally. On master, this is how the table looks in mobile mode in my dev tools:

I also can't reproduce this. I went to https://www.material-ui-datatables.com/ on my phone and then clicked one of the examples in the sidebar (which pops a codesanbox example) and it seems to be displaying correctly.

I'm sorry for wasting everyone's time on this.  I tried it in a new project and it does appear to be working fine without this fix.

No worries! I’m a heavy user of this table so I appreciate people looking into things like this.

I think I've been able to figure out when this happens, but not sure it's something readily fixable.  When trying to use the MUIDataTable inside of MUI's Container or a Grid, the padding of those parent containers causes the footer row to shift.  Looking through the mui-datatables docs to see if there is something I'm missing to address this, as using the datatable within a layout seems a common use-case!


Label Column

So we left the training dataset as a schema only, but the training data set has the label column. Doesn't that mean that we must also have this label column when submitting requests to the web service?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32d73d2c-7862-8b41-9266-7174c9bc9a37
Version Independent ID: 39d5b95f-d3b8-8eb9-0f27-a6442328eada
Content: Step 5: Deploy the Machine Learning web service
Content Source: articles/machine-learning/studio/walkthrough-5-publish-web-service.md
Service: machine-learning
GitHub Login: @YasinMSFT
Microsoft Alias: yahajiza

@wechuli You would only need the schema to submit a web service request.

@YutongTie-MSFT, my point is that the webservice would expect the label column as part of the input(since it is using the same schema as the training data set), but this is the same column I am trying to predict so I don't have it (doesn't make sense to predict something you already know).

@YasinMSFT Hi, can you please check the follow-up here? Thanks!

@YasinMSFT Can you please share how to file a bug here?

https://msdata.visualstudio.com/AzureML/AzureML Team/_workitems/create/bug

@wechuli
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[WIP] Lexicon-based API doc generation

I've started to look at a follow-up to #398 using Lexicon.jl. It does a good job generating the API docs.  The main change here is to include a build.jl script in the doc dir that runs Lexicon.
Now we have to work out the last steps of generating the package, and there are two potential routes.

Stick with dcjones's Judo.jl.  It currently hangs because Judo tries to run any code blocks (fenced with triple backticks or indented by 4-spaces).  We would have to decorate all of these with {.julia execute="false"} (except any that we'd like to run as examples, of course).

Judo now has a branch that uses Julia's markdown processing to ditch the pandoc dependency.  That's nice.

Switch to mkdocs, which is recommended by Lexicon. One nice feature that it has is the ability to deploy docs to gh-pages with a single command.  But it is an additional dependency for package writers.

Any thoughts?

Sweet!
I don't have strong opinions here, and am happy to be guided by your preferences (if you have them). I do have python installed, and I imagine I can figure out any problems in getting mkdocs working on my machine, if that's the direction you're leaning in.
Presumable this is something that won't be a concern for PRs, right? It would be just you, me, and a few others who might generate the docs from time to time?

Hmm, it looks like I accidentally updated the docs for this repo while working on this.  I was trying to test on my fork, but it looks like the mkdocs gh-deploy command pushes to origin instead of what's set in the mkdocs.yml configuration.
That said, I think the result looks pretty nice.  To get here, it's just a matter of julia docs/build.jl; mkdocs gh-deploy --clean.  I will package this up in just a bit, hopefully this evening.

See #431


feat: allow filtering based on log levels

Problem
With #1672 , we introduced ability to categorize logs based on different levels: info|warn|error. However, it is currently not possible to view these logs with the filter applied.
Solution

switch from console.x() to log()
allow filtering based on wildcards

Notes

example usage:

DEBUG=js-waku:*
DEBUG=js-waku:info:*
DEBUG=js-waku::*:connection-manager

I just noticed DEBUG=js-waku:*
I strongly recommend to revert this change and stick to DEBUG=waku*~. Why adding the js-`? breaking all docs, CIs and scripts to add redundant value?

I'm of the favour to keep it js-waku. Please let me know if you think otherwise @fryorcraken

Please revert before next release due to customer impact cc @waku-org/js-waku-developers


Cannot generate docs with autodoc

For some reasons, both GitHub Actions and a local Ubuntu distro cannot regenerate docs via the command:
tox -e docs

Reported error:
Extension error (sphinx_autodoc_typehints):
  Handler <function process_docstring at 0x7f4cc3d27f70> for event 'autodoc-process-docstring' threw an exception (exception: no signature found for builtin <slot wrapper '__len__' of 'cbytesparse._c.BlockView' objects>)
  ERROR: InvocationError for command /home/runner/work/cbytesparse/cbytesparse/.tox/docs/bin/sphinx-build -E -b html docs dist/docs (exited with code 2)

The latest commit being compiled successfully was: 12a874aa303ea014412dfe8309e2895bad5f8998
See: https://github.com/TexZK/cbytesparse/actions/runs/1655319251/attempts/1
However, any new attempts of the very same commit are failing.
See: https://github.com/TexZK/cbytesparse/actions/runs/1655319251/attempts/2
See: https://github.com/TexZK/cbytesparse/actions/runs/1655319251/attempts/3
There must be something weird in some PyPI or Ubuntu packages, as I cannot see any reasons why this happens...

The problem has gone, for even more unknown good reasons :-)


Latest news order

At what URL is the content that needs updating?
'https://renci-beta.netlify.app/'
Describe why this change is necessary
This needs updating because third position item on the News list is from 2005
Existing Content
Existing order of blogs, news seems to be somewhat random - not with the newest on top
New Content
I don't think new content is needed - but different sorting is.
btw, consider this submission also as a testing of the github-issue driven request routine! So far, i love it!
Thanks!

@asia23 thanks! i'll take a look and get back to you.

i'm not able to see this behavior. you see something different than what is shown in this screenshot when you land on https://renci-beta.netlify.app/?

 RENCI website redesign and rebuild

@trel thanks for confirming!

See the screen shot: just top 3 entries: 2020, 2021, 2005
@.***D739F8.ED43B8B0]
Asia Mieczkowska (she/her/hers)
<EMAIL_ADDRESS>From: Matt Watson @.>
Reply-To: RENCI/renci-website @.>
Date: Friday, April 23, 2021 at 4:32 PM
To: RENCI/renci-website @.>
Cc: Asia Mieczkowska @.>, Mention @.***>
Subject: Re: [RENCI/renci-website] Latest news order (#229)
i'm not able to see this behavior. you see something different than what is shown in this screenshot when you land on https://renci-beta.netlify.app/?
[Image removed by sender. Screenshot from 2021-04-23 16-30-41]https://user-images.githubusercontent.com/6019870/115926703-46ad4980-a451-11eb-8748-2a8a1e7b7498.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RENCI/renci-website/issues/229#issuecomment-825909892, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG7OAPN7QJ5W6LSZ2562333TKHKMVANCNFSM43OZXCSQ.

@asia23 thanks for catching this Chrome.-specific issue i believe it's fixed now.


Add 22

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The documentation already says that JDK 22 is available: https://docs.aws.amazon.com/corretto/latest/corretto-22-ug/docker-install.html#alpine-images which isn't true :(

Bump - is there anything blocking the release of JDK 22 images?


Error on loop/pagination.php in Woocommerce

Hi everyone, I've discovered an issue of pagination in Woocommerce template, when nagivate to shop page, I haven't found pagination, it still showing in product archive page, however when switch to new page, Products loop still remain and haven't change at all. All i have to do is copy original pagination.php from Woocommerce to child theme to make it work

Hi,
do you have a link to your site to check?
I've set the loop to 8 products per page here https://dev.bootscore.me/shop/ and pagination seems to work fine?

Did you set up the amount of products before pagination in the Customizer settings? Don't do that, use a simple function and pagination will work fine:
function wpsites_query($query) {
  if ($query->is_archive() && $query->is_main_query() && !is_admin()) {
    $query->set('posts_per_page', 8);
  }
}
add_action('pre_get_posts', 'wpsites_query');

Sorry for my late comment, thanks about your reply, when replace original woocommerce pagination code i notice some minor different but not significantly so i forgot it ^^

So, it works fine now?


TS-4026: Disable clustering

Alternative approach to #966

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/722/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/618/ for details.

👍 - Looks good


The first i batch should be 0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.983%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1549

Relevant Lines:
1684

💛  - Coveralls


WebApiError does not capture reason

When calling player endpoints (such as play or pause), if an error occurs the web API returns a player error object which includes a reason string saying why the request failed. It would be incredibly useful if this information was passed on in the returned WebApiError object.

I agree, I needed this for an integration I am building. I opened a PR #294 to fix this.


docs: Add home page to documentation

Description
This pull request changes the following:
Adds new home page to the official Solo Documentation.
Related Issues

Closes #406

:tada: This PR is included in version 0.28.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


STENCIL-3107 - don't load images below the fold

What?
Implementing lazyload to prevent images below the fold from loading
before they’re needed. Focus is on product card images.
Tickets / Documentation

STENCIL-3107

Screenshots (if appropriate)
Currently live on https://bigcommerce.support/ for testing

Hey @bookernath, thanks for doing the changes. I'm still not sure about the SVG spinner, because, AFAIK, it doesn't work in IE at all (even in Edge). I'm wondering if we need to use a spinner at all? I think a simple fade-in effect might work well?  What do you think?

@davidchin I do think the icon is important so that the elements in the DOM take up a little space and also so that users know to expect content to load there - but I'm more than happy to use a different icon.

Updated with a new icon that's a little more on-brand, similar to loading animations we use in the CP. I've confirmed it looks OK on Bold. I've also confirmed it'll render as a static image on IE, which should still convey the right idea. :)

Sorry about the delay on this one, but I finally got a clean regression run. Did some manual clicking around as well... LGTM 💚


Still being maintained?

Hello! We're in the process of updating our Xamarin (Native) app from the v4 Adobe Analytics to this. This looks great -- thanks for building the Xamarin bindings! -- but I'm a bit confused why the version is 0.0.1 and it hasn't been updated in a year even though the native packages have had many updates. Is this supported for production applications and will continue to be updated?
Thanks!

Hi @IGx89 ,
We're working on the 1.0.0 release with the latest native packages/binaries, the build will be out very soon.
Thanks,
Yansong

That's great news, thanks for the update Yansong!

Hi @IGx89,
We have updated ACPCore wrapper to 1.0.0, more details here: https://aep-sdks.gitbook.io/docs/resources/upgrading-to-aep/current-sdk-versions#xamarin.  And we are planning to update ACPAnalytics to 1.0.0 shortly.  We keep you posted once the wrapper for Analytics is done.
Thanks,
Stephen

Thanks! Ready to start testing once ACPAnalytics is updated

Hello @stcheng-adobe! Any ETA on the ACPAnalytics update? Trying to decide if we go forward with testing/rolling out 0.0.1, or if we should wait for 1.0.0. Thanks!

Hi @IGx89,
We are planning to  release the update this week.  I will let you know once the build is ready.
Thanks,
Stephen

Hi @IGx89 ,
We have released ACPAnalytics 1.0.0 today.  I am closing this issue for now and please let us know if you are running into other issues.
Thanks,
Stephen


Add container event support to containerd

This PR adds container event support (https://github.com/kubernetes/enhancements/issues/3386) to containerd, by implementing GetContainerEvents() CRI API that supports single-caller and returns all container events (i.e. not filtered by container ID or other filters) to the caller.
To-do list before un-drafting:

[X] add sandbox server support
[X] Merge the CRI change in k/k repo

/ok-to-test

Some CI checks failed. Most of the failures seem irrelevant:
go<EMAIL_ADDRESS>unrecognized import path "gopkg.in/yaml.v2": reading https://gopkg.in/yaml.v2?go-get=1: 502 Bad Gateway
	server response: Cannot obtain refs from GitHub: error reading from GitHub: net/http: request canceled (Client.Timeout exceeded while reading body)
make: *** [integration] Error 1
Makefile:[21](https://github.com/containerd/containerd/runs/7813786735?check_suite_focus=true#step:9:22)3: recipe for target 'integration' failed

One failure on the new test added TestContainerEvents:
        	Error Trace:	/home/runner/work/containerd/containerd/container_event_test.go:49
        	Error:      	Received unexpected error:
        	            	assertContainerEventResponse: wrong sandbox name. Expected sandbox_foobar2, got sandbox
        	Test:       	TestContainerEvents

Looking.

btw I am getting
+ run_crictl
+ /usr/local/bin/crictl --runtime-endpoint=unix:///run/containerd-test/containerd.sock info
FATA[0000] getting status of runtime failed: rpc error: code = Unimplemented desc = unknown service runtime.v1alpha2.RuntimeService

when running sudo make cri-integration. Looking into it as well.

Update: adding CONTAINERD_RUNTIME solves this issue ( sudo FOCUS=TestContainerEvents CONTAINERD_RUNTIME=io.containerd.runtime.v1.linux make cri-integration)

Can you try io.containerd.runc.v2 (this should be the default) and io.containerd.runc.v1 as well?

, but now I am seeing "failed to create containerd task: cgroups: cgroup mountpoint does not exist: unknown"

Are you perhaps using a machine with cgroups v2 configured?  I believe the v1 shim depends on cgroups v1.

Can you try io.containerd.runc.v2 (this should be the default) and io.containerd.runc.v1 as well?

Thanks Samuel! sudo CONTAINERD_RUNTIME=io.containerd.runc.v2 make cri-integration works for me.
Also I have figured out the previous failure:
Error Trace:	/home/runner/work/containerd/containerd/container_event_test.go:49
        	Error:      	Received unexpected error:
        	            	assertContainerEventResponse: wrong sandbox name. Expected sandbox_foobar2, got sandbox
        	Test:       	TestContainerEvents

When running all tests together, all tests will make containerd generate events and send them to the channel. The events will be stuck in the channel because no one is reading from it. When container_event_test starts and reads from the channel, it will first read the events emitted by previous tests. So I added some logic to drain the event channel before asserting the event content.

/retest

/retest

Rebased the PR against main branch, which has CRI changes now.

@ruiwen-zhao how goes.. needs a rebase.

Needs rebase.. and needs changes to pick up the merged pr from https://github.com/kubernetes/kubernetes/pull/111384

Did the rebase.
For cri-api change, the v1alpha2 API has been removed in https://github.com/kubernetes/cri-api/commit/cd17af26e578534d864885e3c0f6f576119c3ad9, before the evented pleg related CRI change is merged. So I guess we need to remove the v1alpha2 dependency from containerd repo first.

Uh so sbserver tests are part of CI testing, and they are failing:
        	Test:       	TestContainerEvents
    asm_amd64.s:1594:
        	Error Trace:	/home/runner/work/containerd/containerd/container_event_test.go:112
        	            				/home/runner/work/containerd/containerd/asm_amd64.s:1594
        	Error:      	Received unexpected error:
        	            	rpc error: code = Unimplemented desc = method GetContainerEvents not implemented

So i cannot leave out the sandbox server implementation.

The three windows failures are all
mv: cannot remove 'C:/Windows/Temp/test-integration/containerd.log': Device or resource busy

The linux failure is
convert_test.go:50: failed to copy: httpReadSeeker: failed open: failed to do request: Get "https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/6c/6c41b8874ee0854485419a5a94634aa66bc23a57c48fd903878825c0962af39b/data?verify=1669158604-LaKrXNpdRtYaT1TKeXDUH5wlOUg%3D": read tcp <IP_ADDRESS>:40942-><IP_ADDRESS>:443: read: connection reset by peer

I dont think these are related to this change.
/retest

I've kicked off a rerun.

The tests were all passing just now, but now are failing with
Run script/test/test2annotation.sh *-gotest.json
jq: error: Could not open file *-gotest.json: No such file or directory

Error: Process completed with exit code 2.

Can we re-run the tests again?

waiting for confirmation that https://github.com/kubernetes/kubernetes/pull/114351 is merged into a k/k v1.26 release

Updated the code to skip sending events with nil PodSandboxStatus. See the TODO issue (https://github.com/containerd/containerd/issues/7785) for context and next step.

samuelkarp￼requested review from mikebrow

I hit the wrong button there, sorry!

@fuweid and @samuelkarp expressed interest in reviewing


Allow Azks parallelism to be configurable

This PR is stacked on #456. It refactors Azks parallelism in the following ways:

Simplifies parallelism logic in get_append_only_proof_helper
Removes the parallel_azks feature in favor of explicit configuration (see next point), to avoid interactions between multiple configuration methods.
Creates an AzksParallelismConfig struct, allowing users to set parallelism for different operation types (insertion and preload). Each operation can have one of the parallelism settings:

No parallelism
Static parallelism
Dynamic parallelism (derived from core count)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.35%. Comparing base (3ce5335) to head (bd1a762).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   88.61%   88.35%   -0.27%
==========================================
  Files          39       38       -1
  Lines        9109     8450     -659
==========================================
- Hits         8072     7466     -606
+ Misses       1037      984      -53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests