feature(line): split line plot

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SAK-29660 - Pages with several tools do not refresh properly.

Pages with several tools do not refresh properly.

This seems strange.  Let me review this one more carefully.

The approach in trunk and the approach in PR#871 won't work. I think that the only solid solution is a page-reset. I can take this over and develop the page-reset code if you like.
It would actually be pretty easy to make it so that navigating to a page always reset all tools. But then hitting the refresh button with no navivation click would also reset. The need for tool-reset and now page-reset is so we can do the reset only at the moment that the left-hand-link is created but not do the reset when the user presses refresh.
So it is like a GET-Redirect-GET pattern to leave a non-resetting URL in location bar

Perfect @csev , let's close this PR.


Unable to install golang 1.9.7 or the latest version on windows 10

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.9.7
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
amd64,windows
What did you do?
Trying to install go using .msi installer from official site.
If possible, provide a recipe for reproducing the error.
Attached the snapshot.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
Software should be atleast installed.
What did you see instead?
Its not even installing and creating a very bad experience.

Did you run the installer as administrator ? I don't use Windows, though I think you have to have the admin rights to install directly on C:\

Also double check your av software is not getting in the way. This is a very common problem on windows machines.

On 7 Jul 2018, at 19:55, Prim3val<EMAIL_ADDRESS>wrote:
Did you run the installer as administrator ? I don't use Windows, though I think you have to have the admin rights to install directly on C:\
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Create a wiki page for the new extension type: listener

Since listener extensions are stable now, they should be well documented in the wiki

any advancements on this documentation?

Sadly no. I haven't had the time to write proper documentation yet.
And with version 2.0 around the corner, it's hard to make time for both.


Esri service not loading

I'm trying to upload an Esri service to seasketch.org/esi. The service URL is:
https://services2.arcgis.com/C8EMgrsFcRFL6LrL/arcgis/rest/services/Alabama_ESI_2007_test/FeatureServer
SeaSketch finds the service but when I try to add it to my project, SeaSketch hangs on "Evaluating services (4/16)". The service loads fine in Esri's map viewer.

Fixed in latest deployment. ArcGIS integration was failing to properly handle switching to tiled requests.


Add support for UUID and BigDecimal

~Stacked on the top of #31. Only the most recent commit is actually related to UUID/BigDecimal.~

@cchantep rebased directly onto master

@cchantep merge? I can't do it unfortunately myself :/


Apostrophes in answers break VisibleIf

See https://plnkr.co/edit/3UG0Vk3KaRyUovWW7EiQ?p=preview - I took the SurveyJS demo and added correlating apostrophes in an answer and a visibleIf setting using that answer. Having apostrophes in answers breaks visibleIf, because of how the quotes work.
Are you requesting a feature, reporting a bug or asking a question?
Reporting a bug
What is the current behavior?
Using apostrophes in answers breaks the visibleIf functionality for those answers
What is the expected behavior?
That users can use apostrophes within answers
How would you reproduce the current behavior (if this is a bug)?
https://plnkr.co/edit/3UG0Vk3KaRyUovWW7EiQ?p=preview
Provide the test code and the tested page URL (if applicable)
https://plnkr.co/edit/3UG0Vk3KaRyUovWW7EiQ?p=preview
Tested page URL:
Test code
your_code_here

Specify your

browser:
browser version:
surveyjs platform (angular or react or jquery or knockout or vue):
surveyjs version:

You nned to escape quotas in conditions.
Here is the fixed plunk - https://next.plnkr.co/edit/bRuXkYM1seoXAEFz

General users don't know about escaping and will try to use apostrophes without espcaing. Could a fix to the library be to use backticks?

@lady3bean Do you mean in SurveyJS Editor?
I think yes, we should.
Thank you,
Andrew

@lady3bean Here is the bug in Editor repo
Thank you,
Andrew

Duplicetd of the fixed https://github.com/surveyjs/editor/issues/476


Can't close unsaved file

Describe what happened:
When in a Live Share session, I can't close an unsaved editor. While this is normal VS Code behavior, I'd expect to be able to close an unsaved file if another participant has it open.
What was your system configuration?
Product and Version [VS/VSCode]: VS Code
OS Version[macOS/Windows]: macOS Big Sur
Live Share Extension Version: 1.0.4070
Target Platform or Language [e.g. Node.js]: n/a
Steps to Reproduce / Scenario:

Open a Live Share session with someone else
Have the other person edit a file
Open that file
Try to close it

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
Screenshots
If applicable, add screenshots to help explain your problem.

Hey @cjdenio , that's a good point. Unfortunately, this behavior is provided by VS Code today, and I'm not sure there's a good way for us to side-step it. Besides, we'd have to maintain some kind of ref count across all participants so that we do prompt you if you happen to be the last participant with the file open.
But I totally agree this is a weird experience, especially in the case where you click "Don't Save," expecting your unsaved changes to be discarded, but then they're not, because the file is still open elsewhere.
I just don't think this is something we'll be able to prioritize in the near future, but will keep it open as a feature request to track and see if there's more interest.
Is this mildly annoying/confusing to you as a user? Or annoying to the point that it makes the product unusable?
Thanks for the input!

The major issue is that if I click "Don't Save", it seems to undo the changes for every other user who has the file open.

Oh! Looks like I got that backwards here

But I totally agree this is a weird experience, especially in the case where you click "Don't Save," expecting your unsaved changes to be discarded, but then they're not, because the file is still open elsewhere.

Isn't discarding the changes the expected behavior when you click "Don't Save"? That's what would happen locally.

My main annoyance is that I can't close a file that someone else is editing without discarding their changes. I suppose that's what I'd expect from clicking "Don't Save", but I'd also expect there to be some way to close the file.
Again, I know this is normal VS Code behavior and might not be a realistic fix (unless I'm misunderstanding). Thank you for your time!

Yes, that's definitely annoying.
I'll keep this issue open since it's a fair point, but I don't know if it's possible to act on it at the moment, or if we'd be able to prioritize doing so.
Thanks for the feedback!

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.


Replace @everywhere with remotecall

Since we're running things on a single process, I think remotecall might be better. I'm a bit suspicious about my use of @sync here but the reasoning was that we wouldn't want the execution to move on without the previous line finishing execution, and remotecall calls the function asynchronously in the given process. Tested locally on 1.8.5.

Codecov Report
Base: 38.60% // Head: 15.18% // Decreases project coverage by -23.42% :warning:

Coverage data is based on head (f646f86) compared to base (89aa686).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   38.60%   15.18%   -23.42%
===========================================
  Files           4        4
  Lines         158      158
===========================================
- Hits           61       24       -37
- Misses         97      134       +37

Impacted Files
Coverage Δ

src/allocations.jl
30.66% <100.00%> (-17.34%)
:arrow_down:

src/utils.jl
0.00% <0.00%> (-64.87%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Release 0.1.0

Blocked on https://github.com/str4d/rage/pull/225.

Codecov Report

Merging #19 (47a5952) into main (a3857b5) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #19   +/-   ##
=====================================
  Coverage   2.07%   2.07%
=====================================
  Files          8       8
  Lines        483     483
=====================================
  Hits          10      10
  Misses       473     473

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3857b5...47a5952. Read the comment docs.


Phantom git:/ virtual paths sometimes appear in Problems View

VSCode Version: Code - Insiders 1.10.0-insider (40fecfaa77f01672e8a147be71f6f7ccb9cf8a12, 2017-02-27T14:15:13.224Z)
OS Version: Windows_NT ia32 10.0.14393

Repro steps:

create new php file with an error - e.g. a.php

<?php

function a () {

Open the problems view
Switch to a different tab, switch back
Notice that two problems appear in view

Additional notes:

the folder is not under source control (I know the screenshot above shows that it is, but it was also broken before initializing the repo)
I've also seen the issue appear for ESLint files as well, so it's not just PHP, although I haven't been able to find a small and consistent repro for this one (the following case was under source control, but still made no sense to me)

The issue cannot be reproduced when you launch from the latest bits in master scripts/code.bat (and I haven't seen any recent changes that would have addressed this issue)
The issue doesn't appear to reproduce for all extensions (or at least not that I've seen)
The issue does not reproduce in v1.9.1, so this is a regression.
sometimes the errors linger after issue in the actual file is addressed, and sometimes they do not.
the phantom virtual file only appears for one file at a time unless the error lingers
attempting to navigate to the phantom file yields a totally blank and un-editable file

More info: #19627, #20859
cc @Microsoft/vscode

To mitigate this for now I added a hard coded rule to exclude git:// from validation.

@joaomoreno  can you provide some additional info? #20859 is forward looking discussion, #19627 was closed for 1.9. How do they solve the issue at hand?

This was mitigated by changing the file extension of git: resources, minimising the number of extensions which would create diagnostics for those resources. Usually those extensions filter file events on file extensions, like ESLint does.
Then, this becomes a duplicate of #20859: we need fine grained control of what features are enabled for what resources.


Add docker support back for CentOS7

Add docker support back for CentOS7
The reset OS supports podman

[test]

[test]

This fixes #57


Ply writer doing something weird

I am seeing a very weird behavior when saving a mesh to a .ply using the generate_mesh rosservice.
When I visualize the mesh in RVIZ, it is clear that the mesh is at positive y, while z is up.
Yet when I write the mesh I see the values of y being the ones of z, and the ones of z being the ones of -y.

Here the RVIZ visualization:

Here the mesh loaded in another visualizer:

Here a sample of the ply file: (I had to use cloud compare to convert from binary to ascii to make it readable)

Are you sure you are visualizing the mesh in the same frame that it is created in? I.e., the "world_frame" frame ID? Because the ply writer really does not do anything special and I really do not see how this would happen:
https://github.com/ethz-asl/voxblox/blob/master/voxblox/include/voxblox/io/ply_writer.h#L72-L98

Thanks @helenol seems like it was just an intricate combination of frames of reference.


[Feature] FE support IPV6

Signed-off-by<EMAIL_ADDRESS>Why I'm doing:
StarRocks need to deploy in IPV6 env.
What I'm doing:
FE support IPV6.
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@xyllq999  Excellent work 👍🏻, thanks for the contribution. We will start the code review very soon.


fix strdup memory leak

Hi, would you please review this PR? It fixes a memory leak we found in our nightly asan build. Thanks!

pthread_setspecific stores the pointer given to it, not the values pointed to by the pointer. With your code s_pthread_key_name will be left pointing to freed memory. Previous discussion here: https://github.com/emilk/loguru/issues/59


Pin reuse version to 2.1.0

This PR fixes issue #1590
Closes #1590

@upsj here is a PR in their repo: https://github.com/fsfe/reuse-tool/pull/909


selected_variables must include output fields of update() with depth > 0

Hi,
There is a discrepancy with the selected_variable parameter used in the update() function:

With depth not set (no overlap), the selected_variables parameter does not need to include the updated fields
With depth set to > 0 (overlap), the selected_variables parameter must include the updated fields. Not setting the output fields in the selected_variables will trigger a KeyError

I think it would be better to have the same behavior in these two cases. Best case is not having the output fields in selected_variables as it can reduce the number of reading operations of the zcollection.
Anyway, I have set up a simple case to illustrate the problem :
### IMPORTS
from __future__ import annotations

import datetime
import pprint

import dask.distributed
import fsspec
import numpy

import zcollection
import zcollection.tests.data

print(zcollection.__version__)
>> 2023.3.2

### ZCOLLECTION CREATION
def create_dataset():
    """Create a dataset to record."""
    generator = zcollection.tests.data.create_test_dataset_with_fillvalue()
    return next(generator)

ds = create_dataset()
ds.to_xarray()

fs = fsspec.filesystem('memory')

cluster = dask.distributed.LocalCluster(processes=False)
client = dask.distributed.Client(cluster)

partition_handler = zcollection.partitioning.Date(('time', ), resolution='M')

collection = zcollection.create_collection('time',
                                           ds,
                                           partition_handler,
                                           '/my_collection',
                                           filesystem=fs)

collection.insert(ds)

### UPDATE
def callback(zds):
    new = 2*zds["var2"].values
    return dict(var1=new)

print(collection.update(callback, selected_variables=["var2"]))
>> None

collection.update(callback, selected_variables=["var2"], depth=1)
>> 2023-05-03 09:57:11,122 - distributed.worker - WARNING - Compute Failed
>> Key:       callback-6791e733b811dfee47c879a54d34aad9
>> Function:  wrap_function
>> args:      (('/my_collection/year=2000/month=01', '/my_collection/year=2000/month=02', '/my_collection/year=2000/month=03', '/my_collection/year=2000/month=04', '/my_collection/year=2000/month=05', '/my_collection/year=2000/month=06'))
>> kwargs:    {}
>> Exception: "KeyError('var1')"

Fixed in development branch.


Add Math

https://github.com/rossant/awesome-math

Please read the contributing guidelines and the awesome manifest.

https://github.com/sindresorhus/awesome/blob/master/awesome.md#include-contribution-guidelines

https://github.com/sindresorhus/awesome/blob/master/awesome.md#include-contribution-guidelines

thanks
https://github.com/rossant/awesome-math/blob/master/contributing.md

thanks
https://github.com/rossant/awesome-math/blob/master/contributing.md


resolve issue #84

support StdoutLoggerf that allows control log level

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (22bed02) to head (2ee4088).

Files with missing lines
Patch %
Lines

providers.go
0.00%
16 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   69.88%   68.33%   -1.56%
==========================================
  Files          11       11
  Lines         704      720      +16
==========================================
  Hits          492      492
- Misses        169      185      +16
  Partials       43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add mmibordeaux topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

The BUT MMI Bordeaux has only increased in value over the last few years, and this topic allows the promotion of student projects. And even if few repositories still use this topic, this number is constantly increasing.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

👋  Hi, @MisterAzix! Thanks for this contribution.
As mentioned in our contributing docs:

We are likely to consider suggestions to curate a topic or collection that is valuable to GitHub's community. Valuable topics, for example, include those that are already widely used by repositories and could benefit from the addition of important information. When suggesting content, please consider how to make your contribution broadly useful and relevant to others, rather than serving a specific use case.

In this case, only 39 repositories use the mmibordeaux topic, and it's a little tricky to see how it could be broadly useful and relevant for others. One option for curating repositories that I recommend checking out is the new Lists feature, which is in public beta.


it only  displays error after the file has been saved

i don't get any error reports while i am typing, it only shows up whenl i save the file. i am using neovim lsp.

Not a bug. Currently the odin check gets called after saving. There is also some error reporting on syntax that can happen when typing from core:odin/parser, but the real error comes after saving.

okay thanks.


[cherry-pick release/6.0][Sema] Allow unrecognized platforms  in @backDeployed and @_originallyDefinedIn

Don't emit attr_availability_need_platform_version for a @backDeployed or @_originallyDefinedIn that have a single unrecognized platform name.
rdar://134207783

Explanation: This change is required for open source Swift to compile using and support compiling against the SDKs in Xcode 16.
Radar (and possibly SR Issue): rdar://134207783
Scope: Building on Apple platforms.
Risk: None anticipated.
Testing: CI, building Swift locally.
Reviewed By: Doug Gregor (DougGregor), Allan Shortlidge (tshortli)

@swift-ci test

@ian-twilightcoder could you cherry-pick to release/6.0.0 as well?

@ian-twilightcoder could you cherry-pick to release/6.0.0 as well?

Sure. https://github.com/swiftlang/swift/pull/76128

@swift-ci test


Support for "private" Urls

I add links for many private / internal Urls to my Logseq notes (Logseq Desktop on Mac) - eg, to a Google doc that only myself and people within my company.

When I add this GDoc url to my Logseq notes the logseq-plugin-confirmation-hyperlink fetches it's title as Error 403 Forbidden!!1 rather than the document's title.

It would be great if I could somehow share my browser's (Chrome) session credentials with logseq-plugin-confirmation-hyperlink so that t could extract the correct title.
Is this possible?

Access to private documents that require login, etc., is not possible through the Logseq plugin. This is necessary for security and privacy reasons. If the document is publicly available, the title will be fetched.
Regarding error codes, it is necessary to remove them from the input field, so I will make that correction.

Perhaps, if the title is a hyperlink, copying and pasting that title into Logseq might create a hyperlink. I have not tried this before.


Hide the list , when apply animation with ion-list

I have use this library to animate list but it hides my whole list .

@santoshshinde2012 Hello, can you please post a pen explaining your problem?


[newrelic-logging] Decouple logging PodSecurityPolicy from infrastructure chart

Is this a new chart
Nope
What this PR does / why we need it:
Removes unnecessary dependency for between newrelic-logging's PodSecurityPolicy and newrelic-infrastructure chart.  Allows the newrelic-logging chart to be configured when the newrelic-infrastructure chart is disabled.
Fixes issue rendering nri-bundle with these values.yaml:
 infrastructure:
  enabled: false
logging:
  enabled: true
newrelic-logging:
  nodeAccess: true
  pspEnabled: true

Without this, we get template "newrelic.fullname" not defined.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [mychartname])

I removed the changes to bump newrelic-logging in nri-bundle because it'll be a nightmare for merge conflicts.   Happy to add them on again later, or in another PR if it would help.

Hi @neilfordyce , thank you for the PR!!! 💪
Happy if you bump nri-bundle as you mentioned

Ahh lint, I must be doing something wrong here.  I think I need to bump newrelic-k8s-metrics-adapter to 0.1.1 in nri-bundle too.

Hi @neilfordyce  could you separate the nri-bundle chart bump into a different PR. Thanks!

Hey sure.  I've reverted the changes to the nri-bundle chart.  I can raise another PR for nri-bundle once this is merged.  Assuming all these commits above will be squashed on merge.  Didn't want to pop the commits off to avoid confusing reviewers by force pushing, but can do that if you prefer.


Here are the base commands:

    account          : Manage subscriptions.
    acr              : Manage Azure container registries.
    acs              : Manage Azure Container Services.
    ad               : Synchronize on-premises directories and manage Azure Active Directory
                       resources.
    appservice       : Manage your Azure Web apps and App Service plans.
    batch            : Manage Azure Batch.
    cdn              : Manage Azure Content Delivery Networks (CDN).
    cloud            : Manage the registered Azure clouds.
    cognitiveservices
    component        : Manage and update Azure CLI 2.0 (Preview) components.
    configure        : Configure Azure CLI 2.0 Preview or view your configuration. The command is
                       interactive, so just type `az configure` and respond to the prompts.
    disk             : Manage Azure Managed Disks.
    dla              : Commands to manage Data Lake Analytics accounts, jobs, and catalogs.

See https://github.com/Azure/azure-cli/pull/3238

Awesome.


Question: Query db by MongoDate

Hello,
first want to say that your extension is awesome!
I have one question... I have mongodb collection saved with models that have column type "Date". When I access that collection I see that column with Date type is actually MongoDate object.
My question is how I can query by that column? I have tried next scenarios with no success:
DB::connection('mongodb')->collection('names')->where('date', '<', new MongoDate())
DB::connection('mongodb')->collection('names')->where('date', '<', new DateTime())
DB::connection('mongodb')->collection('names')->where('date', '<', time())
DB::connection('mongodb')->collection('names')->where('date', '<', date('Y-m-d'))

Thanks,
Milos

I am facing the issue with new version..

@sebastiaanluca : u can use MongoDate::toDateTime as given in following link
http://php.net/manual/en/mongodate.todatetime.php

@jenssegers The whereBetween query doesn't work with Carbon date, only MongoDate. Using v2.2.4.
    $startDate = Carbon::createFromDate(2015, 4, 1);
    $endDate = Carbon::createFromDate(2015, 4, 30);
    $users = User::whereBetween('created_at', array($startDate, $endDate))->get();
    //Return empty result

    $startDate = new MongoDate(Carbon::createFromDate(2015, 4, 1)->timestamp);
    $endDate = new MongoDate(Carbon::createFromDate(2015, 4, 30)->timestamp);
    $users = User::whereBetween('created_at', array($startDate, $endDate))->get();
    //Return correct results

Is the Carbon date support not applicable to this case? Thanks!

I am facing the issue with new version..²

@saraht129 @jenssegers I've tired your solution and still get empty result! Also tried (for example)
User::where('created_at','>',$startDate)->where('created_at','<',$endDate)->get();
still get empty result.
I don't know why it doesn't work with more than one where clause :disappointed:


Docs for attack example

Does it make sense to make some docs for the attack examples which listed in the Threat model
For example, why get the "Decrypted Delegation Key + Decrypted Snapshot Key + Notary Service write-capable credentials" can leads a "limited Freeze attack"

@HuKeping That would be great!  Probably nothing terribly elaborate, but one or two sentence examples would be great!

Hi @cyli ,actually I file this issue for seeking help :smile:

@HuKeping Ah ok!  Sure we can try to add that :)


Support NotModified (304) for REST responses

Re-opening #6275
There's currently no way to avoid sending a snapshot of configuration via a discovery response using REST, without Envoy considering it a failure.
For the situation where the configuration available on the control plane, and the configuration available on the envoy proxy are the same, a REST control plane must either:

Return a 200 OK with the full snapshot of configuration
Do something outside the norm, resulting in metrics being emitted that indicate an xDS update failure, in addition to warnings emitted to logs

I'd like to allow HTTP 304 Not Modified as a way of indicating that Envoy doesn't need to make any changes to configuration.

Okay at this point I have tried my best with this thing, I don't know C++, and either it throws errors because the parameter is missing, or now because the parameter is unused. Any light on how to do this would be amazing.

I can't really decipher what is wrong with this code based on the broken ci test

/retest

/retest

@dio , not sure what happened to the macos build 😨 is it possible to rerun it?

/retest

@cetanu it's running now...

@htuch, do you mind to take a look? Thanks!

@jmarantz do you mind to take a look at this as well? Thanks!

Currently digging around to see where to add the relevant docs.
There isn't really a designated place for people who are looking to build their own REST-based control-planes.
Should I just add a note to this section?:
https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/v2_overview#rest-endpoints

@cetanu just linking back to the proto field will link to the API docs, e.g. see https://github.com/envoyproxy/envoy/blame/master/docs/root/intro/version_history.rst#L23

I pushed a commit for the docs portion, hopefully it is appropriate.

Hey all, I was looking to adopt this feature, and I'm not sure what the expected flow should be to know if we can safely return a 304. Typically this would require some If-Modified-Since or If-None-Match, and I see no way to convince Envoy to do this.
I've attempted to send both a Last-Modified and ETag header on my responses, and neither the headers of Envoy's request or the POSTed body change on subsequent requests.
Without this information, there's no way to track server-side if we should send back an update or not. Since it's REST, there's no tracking of envoy being disconnected or even simply restarted to know if it should issue a full 200 response or a 304.
Am I missing something here? I was super excited for this feature.

@mattrobenolt interesting. Could you raise another issue so we can track and discuss it better?

@mattrobenolt
It was indeed my intention to use the version_info to determine if there are any changes to the config or not
Specifically, in the control-plane I'm using, if the version_info in both the DiscoveryRequest and DiscoveryResponse are the same, it simply returns a 304.


Investigate libsodium bench results

https://github.com/jedisct1/libsodium has benchmarks which can be run by different backends
If you build the test wasm and run it like so, you can use wazero recently https://github.com/jedisct1/webassembly-benchmarks/issues/1#issuecomment-1019372687
$ WASI_RUNTIME=wazero ./dist-build/wasm32-wasi.sh --bench

Once these are built, it seems analogous to running like this:
$ wasmer test/default//shorthash.so
1580000
$ wasmtime run test/default//shorthash.so
1800000
$ wazero run test/default//shorthash.so
6730000

There's probably a good reason why our performance is slower especially as our existing benchmarks usually win. At first, I thought it was about pre-compilation until @mathetake helped me understand all the timing is done in-wasm, so our compilation won't matter except its end result. It would be good to get to the bottom of this and at least understand what's up.
@jedisct1 if you see any misunderstanding above, let us know.

I hacked in our experimental function listener to see what was happening and one thing interesting is the clock choice is realtime (0) not monotonic (1). That seems an odd choice for benchmarks, but not necessarily an issue.
You can see the arg for clock id in wasi_snapshot_preview1.clock_time_get(id=0,precision=1000,result.timestamp=1048536)
Here's the whole dump
--> .$9()
	--> .$33()
		--> .$33()
		<--
		--> .$8()
		<--
	<--
	--> .$8()
	<--
	--> .$33()
	<--
	--> .$41(1052608,16)
		--> .$37(1052608,16)
			--> .$36(1052632,32)
				==> wasi_snapshot_preview1.random_get(buf=1052632,buf_len=32)
				<== ESUCCESS
			<-- 0
			--> .$38(1052664,1048464)
			<--
			--> .$38(1052664,1048464)
			<--
			--> .$38(1052728,1048464)
			<--
			--> .$38(1052792,1048464)
			<--
			--> .$38(1052856,1048464)
			<--
			--> .$38(1052920,1048464)
			<--
			--> .$38(1052984,1048464)
			<--
			--> .$38(1053048,1048464)
			<--
			--> .$38(1053112,1048464)
			<--
			--> .$10(1052608,1052664,16)
			<--
			--> .$11(1052664,0,16)
			<-- 1052664
		<--
	<--
	--> .$12(1048560)
		==> wasi_snapshot_preview1.clock_time_get(id=0,precision=1000,result.timestamp=1048536)
		<== ESUCCESS
	<-- 0
	--> .$12(1048560)
		==> wasi_snapshot_preview1.clock_time_get(id=0,precision=1000,result.timestamp=1048536)
		<== ESUCCESS
	<-- 0
	--> .$22(1051184,1050631,1048544)
		--> .$23(0,1050631,1048520,1048320,1048480)
		<-- 0
		--> .$18(1051184)
		<-- 0
		--> .$23(1051184,1050631,1048520,1048320,1048480)
			--> .$19(1050631,0,1051184)
				--> .$10(1051512,1050631,0)
				<--
			<--
			--> .$24(1040528,12,1048520)
			<--
			--> .$19(1050282,0,1051184)
				--> .$10(1051512,1050282,0)
				<--
			<--
			--> .$19(1040512,7,1051184)
				--> .$10(1051512,1040512,7)
				<--
			<--
			--> .$19(1050635,1,1051184)
				--> .$16(1051184,1050635,1)
					==> wasi_snapshot_preview1.fd_fdstat_get(fd=1,result.stat=1040056)
					<== ESUCCESS
					--> .$15(1051184,1050635,1)
						--> .$14(1,1040064,2)
							==> wasi_snapshot_preview1.fd_write(fd=1,iovs=1040064,iovs_len=2,result.nwritten=1040060)
6380000
							<== ESUCCESS
						<-- 8
					<-- 1
				<-- 1
				--> .$10(1051512,1050636,0)
				<--
			<--
		<-- 8
	<--
<--

Adjusting the clock takes the time down, but not enough to be close to the others.
$ wazero run test/default//shorthash.so
5600000

So, if someone wants to pick this up, basically the critical part would be between in function 9, between calls to function 12
shorthash.so.gz is the wasm

ps results above are from x86_64 macbook pro. if someone can run against arm, much obliged.

The entire set of wasm files used for the benchmark is here: https://github.com/jedisct1/webassembly-benchmarks/tree/master/2022-12/wasm
(but you already figured out how to reproduce them :) )

another interesting thing is wasmer perf is more close to us on x86 if singlepass
$ wasmer run  test/default//shorthash.so
1620000

$ wasmer run --singlepass test/default//shorthash.so
5780000

as at best our compiler backend is singlepass (eg no-global optimizations) plus in pure-Go JIT comes with a lot of constraints by the Go runtime (for example multiple registers are reserved by the Go runtime and  available to JIT, etc).
Anyway next year we are heading for optimizing compiler to improve the perfo https://github.com/tetratelabs/wazero/issues/777

@jedisct1 so basically the results you had from last night seem legit based on the current arch of our go compiler engine. Doing dimensions for arm64 or other single-pass runtimes might be neat, but at least we know what's up. Cheers!

one blindspot we can take action on is that our current benchmarks don't run a function in a loop inside wasm. So, folks running our benchmarks may not be aware that multi-pass backends will make that pattern faster and we won't (yet). I'll raise a PR to make this more transparent.

one thing why amd64 is much slower vs arm64 is better that is we can't use call instruction at all (hence function calls are really heavy), but anyway enough detail on the Go runtime constraints

SUMMARY:
wazero's current compiler backend won't win vs multi-pass where optimizable functions are called in a big loop (as well other optimizable code). End users can only optimize beforehand for now (ex wasm-opt or compiler flags).
Different code will have different impact, and results will vary on different architectures. For example, in the benchmark we looked at arm64 would not be quite as slow, possibly percentage vs factors, due to its call instruction which we use.
Before seeing this, we had a blind spot because our "representative wasm" benchmarks wasn't representing a case of something called in a thousand or more scale loop in wasm. We fixed that blind spot in #948 so that when people run our benchmarks, they'll see we don't always win.
Many thanks to @jedisct1 for doing these benchmarks as in hindsight ours really weren't diverse enough and mostly focused on memory access and host functions, not crunching something in a loop.


Stop requiring recid for summary

recid doesn't make sense for summary rows

I do not think it would be correct to do that as recid is user extensively internally. Also, functions such as .get(), .set(), etc will not work without it. However, you can generate some fake recid, it just needs to be unique, when you insert a record and it fixes the problem.


Cannot authenticate in my CI/CD CircleCI workflow

I'm trying to integrate netlify deploys to my CI/CD workflow in CircleCI but I am running into authentication issues.
I've set up the NETLIFY_AUTH_TOKEN env variable in the circleci project and i've also tried connecting to the container via SSH and setting it manually via export NETLIFY_AUTH_TOKEN=XXXX.
I've also tried using netlify deploy --auth xxxx.
This all results in:
Logging into your Netlify account...
Opening https://app.netlify.com/authorize?response_type=ticket&ticket=xxxx
---------------------------
Error: Unable to open browser automatically

Please open your browser & open the URL below to login:
https://app.netlify.com/authorize?response_type=ticket&ticket=xxxx
---------------------------

Why is this happening?
My project does not have netlify config files. What I want to do is create a new site for every PR.
This is the workflow:
  deploy-netlify-preview:
    docker:
      - image: circleci/node:10
    steps:
      - attach_workspace:
          at: ~/
      - run:
          name: "Set site name"
          command: site="EMPLOYERS-PR-${CIRCLE_PR_NUMBER}"
      - run:
          name: "Set Netlify Token env variable"
          command: export NETLIFY_AUTH_TOKEN=${NETLIFY_AUTH_TOKEN}
      - run:
          name: "Install Netlify CLI tools"
          command: sudo npm install -g netlify-cli
      - run:
          name: "Fetch sites from Netlify"
          command: sites="$(netlify sites:list)"
      - run:
          name: "Create site if it doesn't exist"
          command: |
            if [[ ! "$sites" =~ "$site" ]]
            then
              netlify sites:create --name "$site" -a ${NETLIFY_TEAM_SLUG}
            fi
      - run:
          name: "Deploy site"
          command: netlify deploy --prod -s "$site" --dir build

It actually hangs at "Fetch sites from Netlify" (stuck loading without error);
When connecting to the container via SSH and trying to deploy manually, login message occurrs. If I printenv I can see NETLIFY_AUTH_TOKEN is set properly.
Env:

Node: v10
Docker image: circleci/node:10
netlify-cli/2.11.23 linux-x64 node-v10.16.0

intention is that you'd use netlify login to get your auth setup, and check that auth into your repo where circle would use it.  Then you'd set a NETLIFY_AUTH_TOKEN and between the config saved on the filesave and the CLI seeing that value, authentication should be non-interactive.

@fool Sorry, I don't completely follow.
Is this what you mean?:

I use netlify login in my computer, this generates a .netlify folder in my home folder.
I (move?) that folder into my repo and check it
I create a Personal Token and set it as an env variable in CircleCI.

Im sure I got that wrong, but I just have a hard time understanding it.

As a temporary fix I just used the netlifyctl tool like this:
  deploy-netlify-preview:
    docker:
      - image: circleci/node:10
    steps:
      - attach_workspace:
          at: ~/
      - run:
          name: "Download Netlify CLI tools"
          command: wget https://github.com/netlify/netlifyctl/releases/download/v0.4.0/netlifyctl-linux-amd64-0.4.0.tar.gz
      - run:
          name: "Unpack Netlify CLI tools"
          command: |
              tar -xzvf netlifyctl-linux-amd64-0.4.0.tar.gz
              ./netlifyctl version
      - run:
          name: "Deploy site"
          command: |
              pr_number=$(echo ${CI_PULL_REQUEST} | cut -d/ -f7)
              site_name="employers-pr-${pr_number}"
              sites="$(./netlifyctl sites -A $NETLIFY_AUTH_TOKEN)"
              echo "The site name is $site_name"
              echo "The sites we have are $sites"
              if [[ ! "$sites" =~ "$site_name" ]]
              then
                echo "Site doesn't exist, will create it now"
                echo "Creating site with name $site_name"
                ./netlifyctl site create -n "$site_name" -A $NETLIFY_AUTH_TOKEN
              fi
              yes n | ./netlifyctl deploy -n "$site_name" -b build -A $NETLIFY_AUTH_TOKEN || true

Hey @mikirobles
Did you try a deploy command like so:
netlify deploy --prod --dir /your-dir --message "site deployed yay" --auth $NETLIFY_AUTH_TOKEN --site $NETLIFY_SITE_ID

This should work or we have a regression on our hands

The current flow does this:
Check for auth https://github.com/netlify/cli/blob/master/src/commands/deploy.js#L23
Which calls https://github.com/netlify/cli-utils/blob/master/src/index.js#L80-L81
If no token found, it will try and pop open the browser.

I'm curious to know if command: export NETLIFY_AUTH_TOKEN=${NETLIFY_AUTH_TOKEN} is setting a null value.
Adding echo $NETLIFY_AUTH_TOKEN the build command should tell us
      - run:
          name: "Deploy site"
          command: echo $NETLIFY_AUTH_TOKEN && netlify deploy --prod -s "$site" --dir build

@DavidWells
Theres a couple problems with that:
1- I might not have a site id yet (if pull request was just created, the site id will be a new one)
2- If I want to check if I have a site id for that PR, I'd have to run netlify sites:list which is stuck Loading (maybe an auth problem).
This is the log for that:
circleci@9bb24b754099:~/project/build$ DEBUG=* netlify sites:list
  @oclif/config reading core plugin /usr/local/lib/node_modules/netlify-cli +0ms
  @oclif/config loadJSON /usr/local/lib/node_modules/netlify-cli/package.json +0ms
  @oclif/config loadJSON /usr/local/lib/node_modules/netlify-cli/oclif.manifest.json +7ms
  @oclif/config:netlify-cli using manifest from /usr/local/lib/node_modules/netlify-cli/oclif.manifest.json +0ms
  @oclif/config reading user plugins pjson /home/circleci/.local/share/netlify-cli/package.json +0ms
  @oclif/config loadJSON /home/circleci/.local/share/netlify-cli/package.json +1ms
  @oclif/config loading plugins [ '@oclif/plugin-not-found',
  '@oclif/plugin-plugins',
  '@oclif/plugin-help',
  'netlify-dev-plugin' ] +1ms
  @oclif/config reading core plugin /usr/local/lib/node_modules/netlify-cli/node_modules/@oclif/plugin-not-found +0ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+3ms
  @oclif/config reading core plugin /usr/local/lib/node_modules/netlify-cli/node_modules/@oclif/plugin-plugins +0ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+0ms
  @oclif/config reading core plugin /usr/local/lib/node_modules/netlify-cli/node_modules/@oclif/plugin-help +0ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+0ms
  @oclif/config reading core plugin /usr/local/lib/node_modules/netlify-cli/node_modules/netlify-dev-plugin +0ms
  @oclif/config loadJSON /usr/local/lib/node_modules/netlify-cli/node_modules/netlify-dev-plugin/package.json +0ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+1ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+0ms
  @oclif/config loadJSON /usr/local/lib/node_modules/netlify-cli/node_modules/netlify-dev-plugin/oclif.manifest.json +1ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+0ms
  @oclif/config loadJSON<EMAIL_ADDRESS>+0ms
  @oclif/config:@oclif/plugin-plugins using manifest from<EMAIL_ADDRESS>+0ms
  @oclif/config:netlify-dev-plugin using manifest from /usr/local/lib/node_modules/netlify-cli/node_modules/netlify-dev-plugin/oclif.manifest.json +0ms
  @oclif/config:@oclif/plugin-help using manifest from<EMAIL_ADDRESS>+0ms
  @oclif/config:@oclif/plugin-not-found using manifest from<EMAIL_ADDRESS>+0ms
  @oclif/config config done +5ms
  @oclif/config start init hook +1ms
  netlify:netlify-cli:hooks:init start /usr/local/lib/node_modules/netlify-cli/src/hooks/init +0ms
  netlify:netlify-cli:hooks:init done +31ms
  @oclif/config init hook done +246ms
  netlify init version<EMAIL_ADDRESS>argv: [ 'sites:list' ] +0ms
  @oclif/config runCommand sites:list [] +3ms
  @oclif/config:netlify-cli require /usr/local/lib/node_modules/netlify-cli/src/commands/sites/list.js +258ms
  @oclif/config start prerun hook +257ms
  @oclif/config prerun hook done +0ms
  netlify options: { userAgent: 'netlify/js-client',
  netlify   scheme: 'https',
  netlify   host: 'api.netlify.com',
  netlify   pathPrefix: '/api/v1' } +0ms
Loading your sites...

3- If I run the command you just said without a site id, I get asked if I want to link an existing site or create a new one. Either option tries to open a browser to log in even if my NETLIFY_AUTH_TOKEN is set.
4- echo $NETLIFY_AUTH_TOKEN prints auth token correctly. This is the same variable used with the netlifyctl flow and it's working fine there.
My ideas:

maybe NETLIFY_AUTH_TOKEN is only used on deploy and not for any other command?

The --auth flag isn't used on the netlify sites:list command https://github.com/netlify/cli/blob/master/src/commands/sites/list.js#L11
Is that netlify sites:list command returning a list of sites? (if so, the token is good and something else is happening here)

netlify sites:list is stuck on Loading your sites... .

Is NETLIFY_AUTH_TOKEN being used for that method?

Odd indeed.
The netlify sites:list command hits the same auth function: https://github.com/netlify/cli/blob/master/src/commands/sites/list.js#L11
Then checks for process.env.NETLIFY_AUTH_TOKEN here https://github.com/netlify/cli-utils/blob/master/src/index.js#L81
It shouldn't be hanging like that.
How any sites does your account have? There might be a timeout happening with a large large list of sites because we are querying for all of them here https://github.com/netlify/cli/blob/master/src/commands/sites/list.js#L13

40 sites tops, and I just changed the credentials to an account with only 2 sites

cli-utils has not been updated and pushed. So the code that works isn't in the globally installed CLI...
(╯°□°)╯︵ ┻━┻
Stay tuned while we bump versions and re-release

Just released netlify-cli/2.11.24
Install that and give it a go. All commands should now respect process.env.NETLIFY_AUTH_TOKEN

It's working now after the updates, thanks!

🎉🎉🎉🎉🎉🎉🎉🎉🎉
Thanks for the report
Holler if you need anything else!


Review RDBMS data types e.g. should we add date/time types

Adding more detail: This would require updating the WIT, the related factor(s), the sdks and cloud support.
Anything else required?

@michelleN @itowlson is this considered closed per https://github.com/fermyon/spin/pull/2895?

@vdice We've not done MySQL yet but we can close this in favour of a more specific issue if that would be preferable?

@itowlson no preference; my motivation is to clean up the 3.0 project/milestone.  If we'd like to keep this open to track MySQL, let's just untether from 3.0 and move to 'Post-Release', even though one half (Postgres) is in.


'yuanchuan' is not in the npm registry

sudo npm install -g markdown-preview giving following error
npm ERR! 404 'yuanchuan' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it

Oh!
Would you please tell me the npm version?

My npm version is 1.3.10
Output from terminal for the command :sudo npm install -g
markdown-preview is below
npm http GET https://registry.npmjs.org/markdown-preview
npm http 304 https://registry.npmjs.org/markdown-preview
npm http GET https://registry.npmjs.org/commander
npm http GET https://registry.npmjs.org/marked/0.3.5
npm http GET https://registry.npmjs.org/mime
npm http GET https://registry.npmjs.org/node-watch
npm http GET https://registry.npmjs.org/open
npm http GET https://registry.npmjs.org/yuanchuan/redis-commands/0.0.4
npm http GET https://registry.npmjs.org/showdown
npm http 304 https://registry.npmjs.org/node-watch
npm http 304 https://registry.npmjs.org/mime
npm http 304 https://registry.npmjs.org/commander
npm http 304 https://registry.npmjs.org/marked/0.3.5
npm http 304 https://registry.npmjs.org/open
npm http 304 https://registry.npmjs.org/showdown
npm http 404 https://registry.npmjs.org/yuanchuan/redis-commands/0.0.4
npm ERR! 404 'yuanchuan' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, or http url, or git url.
npm ERR! System Linux 3.16.0-38-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "markdown-preview"
npm ERR! cwd /home/murali
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! code E404
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/murali/npm-debug.log
npm ERR! not ok code 0
On Wed, Dec 23, 2015 at 07:42:05AM -0800, Yuan Chuan wrote:

Oh!
Would you please tell me the npm version?
?
Reply to this email directly or [1]view it on GitHub.*
References:
[1] https://github.com/yuanchuan/markdown-preview/issues/8#issuecomment-166926453

--
Regards,
Murali Kodali

The package  "https://registry.npmjs.org/yuanchuan/redis-commands/0.0.4" is actually a scoped package, which npm v1.3.10 failed to recognize.
I've removed the redis-commands package and published a new version,  please check if it works now :D

On Wed, Dec 23, 2015 at 09:06:41PM -0800, Yuan Chuan wrote:

The package "[1]https://registry.npmjs.org/yuanchuan/redis-commands/0.0.4" is
actually a scoped package, which npm v1.3.10 failed to recognize.
I've removed the redis-commands package and published a new version, please
check if it works now :D
?
Reply to this email directly or [2]view it on GitHub.*
References:
[1] https://registry.npmjs.org/yuanchuan/redis-commands/0.0.4
[2] https://github.com/yuanchuan/markdown-preview/issues/8#issuecomment-167043212

Problem solved
Thank you
--
Regards,
Murali Kodali


Bug: Leave app running cannot be started by specifying a location to open

Description
If you enter "files C:" on the command line, the launched Files should open the C drive, but if leave app running is on, it will only open tabs according to the launch settings and will not open the C drive. This is also true if Files is the default file manager.
Steps To Reproduce

Turn on leave app running.
Close the app.
Enter "files C:" on the command line.
The app will not open the C drive.

Requirements
Open appropriate tabs as if leave app running were off.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3324
Log File
n/a

Thank you for reporting this issue.


CPS-0017? | Settlement Speed

This CPS defined the settlement problem for Cardano and supports CIPs like Peras, Anti-Grinding, and changes to the active-slot coefficient.

(rendered latest document)

very good then @bwbush let's put this on Review for the next CIP meeting (https://hackmd.io/@cip-editors/101) and hopefully confirm this should be promoted to Last Check then.


registerWithAutocomplete on didInsertElement

In some cases, when transitioning to a view that uses ic-autocomplete, I was getting the error Cannot read property 'focus' of null, which refers to this line:
https://github.com/instructure/ic-autocomplete/blob/c14fac737a21072352f7d8d0ebd59af1df6c38fa/lib/autocomplete-option.js#L124
It seems like the component is trying to access its element before the element exists. Changing willInsertElement to didInsertElement fixes the bugs for me.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: rorysaur:x: torcasitasYou have signed the CLA already but the status is still pending? Let us recheck it.


[Bug] Unexpected ")" in CSS

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
I'm migrating a project to ESBuild and since got the following error:
[WARNING] Unexpected ")"
node_modules/pintura/pintura.css:7:7749:
7 │ ...}.PinturaRoot>.PinturaNav:empty(){display:none!important}.Pintur...

The relevant CSS is:
.PinturaRoot>.PinturaNav:empty(){display:none!important}

The :empty() is probably not valid CSS, so maybe ditch the ()
Reproduction
Try including Pintura with ESBuild.
Environment
- Device: iMac
- OS: macOS Monterey 12.0.1
- Browser: Latest Google Chrome

Hi, just pushed Pintura 8.16.8 which removes this invalid selector. I'll close the issue because this isn't related to FilePond.


feat: add a random seed for the hash table

Closes #327.
A seed is added to the meta page and used to salt the hash function for the hash-table. We draw this from high quality OS randomness.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#341  👈
#340
#339
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite


[BEAM-12384] Set output typeDescriptor explictly in Read.Bounded transform

R: @boyuanzz @kennknowles

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java_Examples_Dataflow_Java11 PreCommit

Run Java PreCommit

Run Java_Examples_Dataflow_Java11 PreCommit

I cherry-picked @boyuanzz commit from the other PR notice however that I could not get the Type to be preserved after the two DoFns are applied.
In OutputSingleSource I was able to export correctly the type by overriding
    @Override
    public TypeDescriptor<SourceT> getOutputTypeDescriptor() {
      return (TypeDescriptor<SourceT>)
          new TypeDescriptor<Source<T>>(getClass()) {}.where(
              new TypeParameter<T>() {}, source.getOutputCoder().getEncodedTypeDescriptor());
    }

but in the second DoFn BoundedSourceAsSDFWrapperFn
I did not find a way to recover the real type of T when overwriting getOutputTypeDescriptor. Any suggestion for this? Otherwise I suppose the solution on Read is good enough.

I cherry-picked @boyuanzz commit from the other PR notice however that I could not get the Type to be preserved after the two DoFns are applied.
In OutputSingleSource I was able to export correctly the type by overriding
    @Override
    public TypeDescriptor<SourceT> getOutputTypeDescriptor() {
      return (TypeDescriptor<SourceT>)
          new TypeDescriptor<Source<T>>(getClass()) {}.where(
              new TypeParameter<T>() {}, source.getOutputCoder().getEncodedTypeDescriptor());
    }

but in the second DoFn BoundedSourceAsSDFWrapperFn
I did not find a way to recover the real type of T when overwriting getOutputTypeDescriptor. Any suggestion for this? Otherwise I suppose the solution on Read is good enough.

I would say, let's unblock you first : ) Can you file a JIRA issue on this? I think we should find a ultimate solution there.

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit


Typo?

https://github.com/mui-org/material-ui/blob/a0f416173d2f5b78546f52e572a0f64dcc3751e9/docs/src/pages/components/snackbars/ConsecutiveSnackbars.js#L24
const handleClick = (message) => () => {
I think it should be
const handleClick = (message) => {

Not typo
It return a function.

Arrow function that returns arrow function, kinda weird for me. And after I
delete the second arrow function, my snackbar starts working. But if it is
a good way to write, then I should read about it.
On Sat, Jul 10, 2021 at 10:12 PM Yumin Gui @.***> wrote:

Not typo
It return a function.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/27221#issuecomment-877689458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEIZYIE6WQZHSABX27UYMR3TXCLSPANCNFSM5AENAJZQ
.

Maybe you just need to read more?


Changing optimizer during the training gives weird results.

I am trying to change the var_list provided to the minimize() function after some iterations. I am trying to implement a two step finetuning, where for first "n" iterations, I am training the last layer of the network and after that finetuning the whole network. So for first "n" iterations i am providing variables of last layer in var_list and after "n" iterations i am providing all variables in the network.
It seems like whole network is being reinitialised when I change the optimizer after "n" iterations.

This question is better asked on  StackOverflow since it is not a  bug or feature request.  Presumably you are running variable initialization a second time, but there is no way to know from the information provided.


Many failing tests on windows 8.1

I'm on Windows 8.1, node v0.10.29, and all test files have failing asserts except core.js.

Looks like noone has any care whether this module's test cases pass on Windows or not over these two years. I discovered this whilst trying to make a fix for #106 and found that there's really no point writing a test case to verify my fix. Thanks for issuing #54, @Evgenus , I'll incorporate it into our project's fork.

@fresheneesz can you try rerunning the tests on Windows on latest master?

@ljharb Looks like the tests work now!


llvm4: unconditionally set triples, not just on musl.

Split off from #42454 as requested.
Boxes I've checked below aren't actually for this exact commit,
but the original I sent to master and actually the one I tested on
a slightly older master before moving to staging.
Basically these really should apply but who can say :).
Build in-flight anyway :).

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tests.cc-wrapper-libcxx-4 tests.cc-wrapper-clang-4

Failure on x86_64-darwin (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-llvm-4.0.1.drv-0/llvm/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-llvm-4.0.1.drv-0/llvm/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/3kpdhxrwp51z0v0p7pkjy1q1sw8dghrq-llvm-4.0.1.drv' failed with exit code 1
cannot build derivation '/nix/store/289q198div0fy3z052pg7a9dwxr2p9ab-clang-4.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qm8g588yi1pzy5nd4caad8lg380wjy07-clang-manpages-4.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i2zmpbn1gsi47dhysfmkslyg8kahic02-clang-wrapper-4.0.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lrvx0qy6f4lrpm6zbisl8amfnh94v674-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xh5p84p4gaz09p3hzn1ak1rgg9b1mr68-cc-wrapper-test.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xh5p84p4gaz09p3hzn1ak1rgg9b1mr68-cc-wrapper-test.drv' failed

Success on aarch64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
checking whether compiler builds valid C binaries... ok
checking whether compiler builds valid C binaries... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler uses NIX_LDFLAGS... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler uses NIX_LDFLAGS... ok
/nix/store/332ym6qw5m16chkpk2gshwjq85bk39gb-cc-wrapper-test
/nix/store/6mkzrlgq9bipvixx3p6q4k5p4ibqmcxj-cc-wrapper-test

Success on x86_64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
Selected multilib: .;@m64
checking whether compiler builds valid C binaries... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler builds valid C++ binaries... ok
checking whether compiler uses NIX_CFLAGS_COMPILE... ok
checking whether compiler uses NIX_LDFLAGS... ok
checking whether compiler uses NIX_LDFLAGS... ok
/nix/store/3qwxpf6x2pjxqf35d576zdy0f1vky4jk-cc-wrapper-test
/nix/store/944lp1msyv4fhxqvsbw3njkgqv1ynn07-cc-wrapper-test

@GrahamcOfBorg build tests.cc-wrapper-libcxx-4 tests.cc-wrapper-clang-4

Success on x86_64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
/nix/store/3qwxpf6x2pjxqf35d576zdy0f1vky4jk-cc-wrapper-test
/nix/store/944lp1msyv4fhxqvsbw3njkgqv1ynn07-cc-wrapper-test

Success on aarch64-linux (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
/nix/store/332ym6qw5m16chkpk2gshwjq85bk39gb-cc-wrapper-test
/nix/store/6mkzrlgq9bipvixx3p6q4k5p4ibqmcxj-cc-wrapper-test

Failure on x86_64-darwin (full log)
Attempted: tests.cc-wrapper-libcxx-4, tests.cc-wrapper-clang-4
Partial log (click to expand)
[ 22%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/Analysis.cpp.o
[ 22%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/AssumptionCache.cpp.o
[ 22%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BasicAliasAnalysis.cpp.o
building of '/nix/store/3kpdhxrwp51z0v0p7pkjy1q1sw8dghrq-llvm-4.0.1.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/289q198div0fy3z052pg7a9dwxr2p9ab-clang-4.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qm8g588yi1pzy5nd4caad8lg380wjy07-clang-manpages-4.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/i2zmpbn1gsi47dhysfmkslyg8kahic02-clang-wrapper-4.0.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lrvx0qy6f4lrpm6zbisl8amfnh94v674-stdenv-darwin.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xh5p84p4gaz09p3hzn1ak1rgg9b1mr68-cc-wrapper-test.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xh5p84p4gaz09p3hzn1ak1rgg9b1mr68-cc-wrapper-test.drv' failed

Well seems to have worked for llvm 3.8, 3.9--or at least no obvious fires were started as a result :).
Darwin looks good: https://hydra.nixos.org/build/76526688 (might not be first build containing change, but look at log to see we're setting triples as expected and such).
Let's try 4!


Add analytics

Would be nice to know how the site is being used once it goes live.

Google Analytics temporarily added in 399536186ad4e8da211438558eb1e4787ec0b775


scipy.stats.binom.rvs cannot handle large numbers

It doesn't seems to be possible to use a "n" argument that doesn't fit on int32 :
binom.rvs(n,p) returns an error when n >= 2^31
input :
n = 2**(31)
p = 0.5
print(binom.rvs(n,p))

output :
File "****\Python39\lib\site-packages\scipy\stats\_distn_infrastructure.py", line 2997, in rvs
    return super(rv_discrete, self).rvs(*args, **kwargs)
  File "****\Python39\lib\site-packages\scipy\stats\_distn_infrastructure.py", line 1004, in rvs
    vals = self._rvs(*args, size=size, random_state=random_state)
  File "****\Python39\lib\site-packages\scipy\stats\_discrete_distns.py", line 41, in _rvs
    return random_state.binomial(n, p, size)
  File "mtrand.pyx", line 3360, in numpy.random.mtrand.RandomState.binomial
TypeError: Cannot cast scalar from dtype('int64') to dtype('int32') according to the rule 'safe'

for my use case, I have n=175739161428149077951009774698216011, which is arround 2^117, is it possible to use binom() ?

@r4ph0u Thanks for reporting this. SciPy relies on NumPy's binomial RNG for this.
n = 2**(31)
p = 0.5
np.random.binomial(n, p)

OverflowError: Python int too large to convert to C long

So I don't think much can be done about it on this side. I'm going to close this here, but please consider opening it over there.


added Homepage

Added homepage and navbar
@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
2, because the PR involves changes across multiple CSS files, addition of new components, and updates to the package.json. The changes are mostly straightforward, involving styling and basic React component structure, but reviewing the CSS for best practices and ensuring the new dependencies are properly used requires some effort.

 🧪 Relevant tests
No

 🔍 Possible issues

Possible Performance Issue: The use of high-resolution images in CSS for backgrounds might slow down the page loading time.

Consistency Issue: The removal of some styles and addition of new ones without a clear replacement might affect the consistency of the design across different pages.
 🔒 Security concerns
No

 Code feedback:
relevant fileclient/frontEnd/src/App.css
suggestion

Consider using a more efficient file format like WebP for background images to improve loading times and performance. [important]

relevant linebackground-image: url('./assets/background.png');
relevant fileclient/frontEnd/src/Styles/home.css
suggestion

Ensure background images are optimized for web use to prevent performance issues, especially on mobile devices. [important]

relevant linebackground-image: url("../assets/background1.png");
relevant fileclient/frontEnd/src/Components/Navbar.jsx
suggestion

Add PropTypes for isNavbarVisible to improve type checking and maintainability of the component. [medium]

relevant lineconst NavBar = ({ isNavbarVisible }) => {
relevant fileclient/frontEnd/package.json
suggestion

Verify that all newly added dependencies are used within the project to avoid bloating the bundle size. [important]

relevant line"react-parallax": "^3.5.1",

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, require_can_be_split_review, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Notification invalid config after each boot

Hi the backup does work but each time after rebstartin HA im getting a notifaction:

I picked up somebody posting this:
show_name: true
show_icon: true
type: button
tap_action:
  action: toggle
entity: automation.restore_samba_backup_sensor_on_startup
name: Restore SMB Backup Sensor

The Manual backup button i made works perfect.:
But even that is not working and i was hoping for a solution.
The addon itself is superior GREATE!!
``
host: <IP_ADDRESS>
share: backup
target_dir: homeassistant
username: homeassistant
password: uwanneknow,iknow
keep_local: all
keep_remote: all
trigger_time: "23:00"
trigger_days:

Tue
Wed
Thu
Fri
Sat
Sun
Mon
exclude_addons: []
exclude_folders: []
log_level: info
backup_name: "{type} {version} {date}"

ha keeps spamming me it, while it does works do

The screenshot you've posted, has nothing to do with this addon. The error tells you that there is something wrong with your Home Assistant configuration.yaml file regarding the backup integration --> https://www.home-assistant.io/integrations/backup/

The screenshot you've posted, has nothing to do with this addon. The error tells you that there is something wrong with your Home Assistant configuration.yaml file regarding the backup integration --> https://www.home-assistant.io/integrations/backup/

Ok thanks for repsoning man, iill dive deepet into the hassio backup service i use:
show_name: true
show_icon: true
type: button
tap_action:
  action: call-service
  service: hassio.backup_full
  target: {}
  data:
    compressed: true
name: Backup Hassio Full
icon: mdi:cloud-upload


tar: call os.Chmod after os.LChown

Fix the TODO introduced and discussed in #462 calling os.Chmod after the
os.LChown for all files except symlinks.

LGTM

lgtm, thanks


Add format to metric aggregations that support it

This commit adds a Format property to metrics aggregations that support it.
Closes #4327

ported to master bd51ef111897b85a4be3de990f0893d39bd23c5c


Anyone was able to make flipper work?

Basically I followed this steps on freshly-generated PizzaApp with --expo flag.
https://blog.expo.dev/developing-react-native-with-expo-and-flipper-8c426bdf995a
Having "No Application Detected" error in Flipper.
Tried upgrading latest expo via expo upgrade. tried matching the flipper version to flipper desktop app.
No Bueno.
Anyone?

@jamon and Joel configured and used flipper with ignite in this video, https://www.youtube.com/watch?v=XvzMGhy3Sos

Whilst I appreciate the link, with no timestamp, no video comments and basically no description it's kinda useless - I can't search through over an hour of video just to find the right 30 seconds I need :worried:

Okay I found it, it's around the 40 minute mark. However it's clear they're using a non-expo project, so the setup is different and not directly transferable to an expo project. Still haven't got Flipper working with my ignite expo setup...

@finnmerlett have you managed to get Flipper working on your Expo project? Keep in mind you'll probably have to build your own expo-dev-client to get this working. Here are some walk throughts:
https://blog.expo.dev/developing-react-native-with-expo-and-flipper-8c426bdf995a
https://github.com/jakobo/expo-community-flipper

I'm going to close this issue due to inactivity. However, if you have any issue in the future with the latest version of Ignite, please open a new issue stating the problem and the output of npx ignite-cli doctor.
Also, you can check out https://community.infinite.red to get help with us (and a bunch of other RN devs!) directly in Slack.


Cannot find 2FA input field

Hello!
Got some trouble while running the script

Log
Logging into account <>
Waiting - Cannot find 2FA input field - Possible captcha requiring completion
Traceback (most recent call last):
File "Free_Games.py", line 307, in
log_into_account(*credentials)
File "Free_Games.py", line 179, in log_into_account
browser.find_element_by_id('code').send_keys(pyotp.TOTP(two_fa_key).now()) # 2FA login code
File "C:\Program Files (x86)\Python38-32\lib\site-packages\pyotp\totp.py", line 45, in now
return self.generate_otp(self.timecode(datetime.datetime.now()))
File "C:\Program Files (x86)\Python38-32\lib\site-packages\pyotp\otp.py", line 40, in generate_otp
hasher = hmac.new(self.byte_secret(), self.int_to_bytestring(input), self.digest)
File "C:\Program Files (x86)\Python38-32\lib\site-packages\pyotp\otp.py", line 57, in byte_secret
return base64.b32decode(self.secret, casefold=True)
File "C:\Program Files (x86)\Python38-32\lib\base64.py", line 231, in b32decode
raise binascii.Error('Non-base32 digit found') from None
binascii.Error: Non-base32 digit found

I put login, password, and rescue 2FA code into .env (also tried with normal 2FA code from the app) but after I complete captcha script cannot proceed

Thanks for submitting an issue! Hopefully we can get this figured out.
Judging by the error log and some Googling, it seems as though your 2FA code might be messed up somehow. Try generating a new one and pasting it into the .env file just after the "=" like this:
EPIC_TFA_TOKEN=29387498237948239846823
(Not a real token, just garbage showing exactly where to place it)

EPIC_TFA_TOKEN=29387498237948239846823
Oh, thanks, it is literally a token from the 2FA setup step and not a rescue code. It was a bit not clear to me in the documentation


Metrics seems to fail when not defining a Hawkular Endpoint

When not defining a Hawkular Endpoint hostname metric collection fails, it should fallback to the providers hostname.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1340721
Issue: https://github.com/ManageIQ/manageiq/issues/9024

@miq-bot add_label providers/containers, bug
@simon3z @zeari @moolitayer please review

@zeari thanks :+1:

@yaacov have you applied this fix to Einat's appliance to make sure it handles the entire issue she's experiencing? (And maybe not just part of it).
Have you reproduced the issue yourself (without this PR) and then verified that these changes are indeed fixing the (entire) issue?
Thanks.

@simon3z checked now on my machine against molecule and this PR helps when I create a provider with empty hawkular hostname.
I will update again after checking with Einat.

@miq-bot add_label darga/yes
@miq-bot assign yaacov
@moolitayer @zeari can you review?

If we always want to have a hawkular endpoint regardless of if a user wants it then LGTM.
Could there be a scenario where a user wouldnt like to have that defined for a particular provider?
I would maybe fill out default values for the user in the UI under the hawkular tab and let him delete them if he doesnt want a hawkular endpoint.
@AparnaKarve What happens the rest of the project with these endpoints?

@simon3z @abonas This kind of connects with the discussion on https://github.com/ManageIQ/manageiq/issues/9029. We could use authentication_status_ok? if a hawkular endpoint isnt forced on the user.

have you applied this fix to Einat's appliance to make sure it handles the entire issue she's experiencing? (And maybe not just part of it).

@simon3z we created a new appliance in qa  , and it collects metrics, no daily rollups yet, i will update when we have graphs.

LGTM :+1:
@moolitayer can you review?
@miq-bot assign chessbyte

@zeari We do not have the Monitoring -> Utilization option for other provider types, so I guess this situation does not arise.
@blomquisg Do you anticipate any other issues if we do not define non-default endpoints for Cloud or Infrastructure providers?

@simon3z We have metrics for the first day on the qa machine Einat set up :-)
No hostname for hawkular:

Metrics for one day:

@blomquisg can you merge this?

Ping? @chessbyte @blomquisg


Update chart version for integration tests and tutorials

How to categorize this PR?

/area testing
/kind test
/priority 3
What this PR does / why we need it:

This pull request updates the version of the ingress-nginx chart that is used in the tutorials and integration tests.
The tests are now using the "real" helm deployer for this chart.
The helm deployer sets the phase Succeededafter collecting export data. This solves issue #445 .

Which issue(s) this PR fixes:
Fixes #445
Special notes for your reviewer:
Release note:

NONE

/test

/test

/test

/test


Add dynamic workload identity config block

GCP Docs:
https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity
Terraform Docs: https://www.terraform.io/docs/providers/google/r/container_cluster.html#workload_identity_config

Hi @lerms thanks for your PR.
Just so I understand this correctly, what would the k8s service account be called? Would it default to the value of 'var.alternative_default_service_account' if specified or the project name? Would you need to ensure a service account with the same name exists in GCP IAM?

Is this PR still active or should I create another @robmorgan ?

Hi @MeNsaaH this PR is still active, but I need my question above answered and it would also need to be updated with the master branch. If you would like to implement a different approach, feel free to submit a separate PR or simply update this one.

Closing in favor of https://github.com/gruntwork-io/terraform-google-gke/pull/105


[Feature]: Ensure Consistency of Starting Requirements Across the Repository

What problem or use case are you trying to solve?
There are inconsistencies in the software requirements mentioned in our documentation, such as the Node.js version required for components like react-router.
For instance:

This page notes "NodeJS >= 20.x"
This page noted Node 18.17.1 (until very recently)

Describe the UX of the solution you'd like
We would like to systematically review all documentation and ensure that all requirements mentioned in the documentation actually match the requirements in "pyproject.yaml" (backend) and "package.json" (frontend). To do this, we can first read these two files, which are the source of truth with respect to versions, and then grep through all the documentation files to find stated version numbers for requirements, and fix any ones that are inconsistent with the source of truth.

OpenHands started fixing the issue! You can monitor the progress here.

A potential fix has been generated and a draft PR #5908 has been created. Please review the changes.

This issue was fixed already.


[Enhancement] adjust max thread num of publish

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #21367
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

https://github.com/apps/mergify backport branch-3.0


Adds 2019 I2CNER report

Summary of changes

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Associated Issues and PRs

Issue: #

Associated Developers

Dev: @

This PDF seems to be missing many of the fixes that you checked off here: https://github.com/arfc/i2cner/issues/81#issuecomment-492334494.
The tables are all still missing titles, the sections include bare bullets... etc.
Why were these ever checked off if they were not completed?

I didn't commit the right tex/pdf file to either repository. Should be fixed now.

Please look over this a little more carefully once again. The tables 3,4,&5 are not mentioned in the text. It's clear you expect them to appear right after the hanging colons on page 4. But latex moves tables around. Instead of the hanging colons, please refer directly to the tables.
Since these edits are the same edits I recommended before and that were checked off (i.e. all tables and figures should be referred to in the text), I'm not inclined to review this again until you're 100% confident it has satisfied all of the corrections that I have already requested. Please, take some time to look this over carefully before sending it back to me.

Here is the spot on page 4 to which I'm referring:

I think all these issues are fixed now.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Changed the regular expression .
@willnorris @cdibona @dberlin @google-admin @marga-google
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

@googlebot  I signed it!


Update kernel signature to use kwargs, migrate all rules

Has a remaining bug that I will still fix tomorrow.
@j-towns: Another bug is the following: Whenever the output slice is empty, the core crashes (reproduce with disabled tests). Do you know why CI is not triggered?
I updated lazy_lax_test.py directly for a better diff and left delayed_lax_test.py untouched for now, we should replace that after merging.

This looks absolutely brilliant Julius! Looking forward to reviewing tomorrow. Will also take a look at the empty out slice bug.

This looks absolutely brilliant Julius! Looking forward to reviewing tomorrow. Will also take a look at the empty out slice bug.


Don't include unit test sources in code coverage (RIPD-1132)

Migrates all unit tests under src/ripple to src/test.  A unit test is any cpp that has the BEAST_DEFINE_TESTSUITE* macro in it.   This will exclude the unit test implementation from contributing to code coverage.

Standardize unit test file names to foo_test.cpp
A handful of tests were in the same cpp as the feature being tested, e.g. Workers.cpp.  I broke the test out to a standalone file in these cases.
A handful of tests were only in the unity builds or excluded from all builds (at least under VS) and are now included in both unity and non-unity.
There were two hash_speed_impl_test.cpp files, but one was not included in any configuration and looked to be an older version of the one that was.  I deleted the old one.

Things I don't like:

src\unity\test_unity.cpp is big and takes a long time to compile.
I added snappy include directory for all unit test sources in scons and cmake, but only the nodestore tests need them.
beast_Zero_test.cpp caused ADL issues in the unity build.  I changed a namespace to workaround and it is still testing ADL now, but someone with more ADL-fu may have a better solution.

ICE on rocksdb (Travis)

Yeah I agree, if test_unity.cpp is choking up builds then we should address. Its very easy, just split the file into N pieces (e.g. test1_unity.cpp, test2_unity.cpp, ...) and give each of them a roughly equal amount of work.

I could also mirror the modules/directories in the src/ripple tree and have unity per each of those.

@bachase I'm not sure what the value is on echoing the layout of the modules. Its something we can always do later. And its likely that we will reshuffle files around (especially in src/ripple/app).

@vinniefalco Since I'm new to code base it just helps me get my bearings. But if that structure is in flux, then clearly not worthwhile.

No Travis report?

I forgot to rebase, but not sure why Travis is missing.  Will investigate some later today/tomorrow, but can close the PR if is too noisy.

No need to close the PR

reviewers? @vinniefalco and @mellery451

I just had a really uhh... stupid/smart idea. We can put the test files in src/test/ripple/test. And then set the added C++ include path to src/test. This way, the include lines will read like #include <ripple/test/Logic_test.cpp> for example, but we still get the directory separation.

Is this rebased against 0.33.0-b7 ?

Yes, should be 0.33.0-b7 looking at my local gitlog.
I'll ponder the alternate directory strucutre.  Moving things like that is enough if it makes more sense.

Is there a way to kick appveyor and travis again?  Appveyor appears to have timed out grabbing a dependency.  travis timed out uploading code coverage results.
Inspecting travis buils manually:
Old (0.33.0-b7)
117 suites, 485 cases
lines......: 71.8% (50294 of 70038 lines)
functions..: 81.4% (15567 of 19116 functions)
New
118 suites, 483 cases
lines......: 64.9% (33980 of 52355 lines)
functions..: 79.9% (13270 of 16617 functions)

I kicked them both

Looks like the discrepancy in number of test cases is due to RIPPLE_ROCKSDB_AVAILABLE no longer being defined in Backend_test.cpp.  Will track it down later and push one more update.  Maybe CI will be happy this time.

Current coverage is 65.14% (diff: 100%)

Merging #1825 into develop will decrease coverage by 6.66%

@@            develop      #1825   diff @@
==========================================
  Files           872        763     -109
  Lines         70038      52355   -17683
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          50294      34107   -16187
+ Misses        19744      18248    -1496
  Partials          0          0

Powered by Codecov. Last update 8687f64...fe1d22d

I just had a really uhh... stupid/smart idea. We can put the test files in src/test/ripple/test. And then set the added C++ include path to src/test. This way, the include lines will read like #include <ripple/test/Logic_test.cpp> for example, but we still get the directory separation. I'm not saying to do that. But its something to think about.

Since #include <test/Logic_test.cpp> and similar are only in the test_unity*.cpp files, I don't see a big advantage of supporting #include <ripple/test/Logic_test.cpp> instead.  Although, I admit seeing ripple in that path is nice to help mirror how things are organized in src.

👍

Files modified:
M       .gitignore
M       Builds/VisualStudio2015/RippleD.vcxproj
M       Builds/VisualStudio2015/RippleD.vcxproj.filters
M       CMakeLists.txt
M       SConstruct
D       src/ripple/app/tests/AccountTxPaging.test.cpp
D       src/ripple/app/tests/AmendmentTable.test.cpp
D       src/ripple/app/tests/CrossingLimits_test.cpp
D       src/ripple/app/tests/DeliverMin.test.cpp
D       src/ripple/app/tests/Flow_test.cpp
D       src/ripple/app/tests/HashRouter_test.cpp
D       src/ripple/app/tests/LoadFeeTrack.test.cpp
D       src/ripple/app/tests/MultiSign.test.cpp
D       src/ripple/app/tests/Offer.test.cpp
D       src/ripple/app/tests/OfferStream.test.cpp
D       src/ripple/app/tests/OversizeMeta_test.cpp
D       src/ripple/app/tests/Path_test.cpp
D       src/ripple/app/tests/PayChan_test.cpp
D       src/ripple/app/tests/Regression_test.cpp
D       src/ripple/app/tests/SHAMapStore_test.cpp
D       src/ripple/app/tests/SetAuth_test.cpp
D       src/ripple/app/tests/SetRegularKey.test.cpp
D       src/ripple/app/tests/SusPay_test.cpp
D       src/ripple/app/tests/Taker.test.cpp
D       src/ripple/app/tests/Transaction_ordering_test.cpp
D       src/ripple/app/tests/TxQ_test.cpp
D       src/ripple/app/tests/ValidatorList_test.cpp
D       src/ripple/basics/tests/CheckLibraryVersions.test.cpp
D       src/ripple/basics/tests/KeyCache.test.cpp
D       src/ripple/basics/tests/RangeSet.test.cpp
D       src/ripple/basics/tests/StringUtilities.test.cpp
D       src/ripple/basics/tests/TaggedCache.test.cpp
D       src/ripple/basics/tests/base_uint.test.cpp
D       src/ripple/basics/tests/contract.test.cpp
D       src/ripple/basics/tests/hardened_hash_test.cpp
D       src/ripple/basics/tests/mulDiv.test.cpp
D       src/ripple/beast/clock/tests/beast_abstract_clock_test.cpp
D       src/ripple/beast/clock/tests/beast_basic_seconds_clock_test.cpp
D       src/ripple/beast/container/tests/aged_associative_container.test.cpp
D       src/ripple/beast/core/LexicalCast.cpp
M       src/ripple/beast/core/SemanticVersion.cpp
M       src/ripple/beast/core/core.unity.cpp
D       src/ripple/beast/define_print.cpp
D       src/ripple/beast/hash/impl/hash_speed_test.cpp
D       src/ripple/beast/hash/tests/hash_append_test.cpp
D       src/ripple/beast/hash/tests/hash_speed_test.cpp
M       src/ripple/beast/net/detail/Parse.h
M       src/ripple/beast/net/impl/IPAddressV4.cpp
D       src/ripple/beast/net/tests/IPEndpoint.test.cpp
D       src/ripple/beast/net/tests/beast_asio_error_test.cpp
D       src/ripple/beast/nudb/test/beast_nudb_callgrind_test.cpp
D       src/ripple/beast/nudb/test/beast_nudb_recover_test.cpp
D       src/ripple/beast/nudb/test/beast_nudb_store_test.cpp
D       src/ripple/beast/nudb/test/beast_nudb_verify_test.cpp
D       src/ripple/beast/unity/beast_clock_unity.cpp
D       src/ripple/beast/unity/beast_container_unity.cpp
M       src/ripple/beast/unity/beast_hash_unity.cpp
M       src/ripple/beast/unity/beast_net_unity.cpp
D       src/ripple/beast/unity/beast_nudb_unity.cpp
M       src/ripple/beast/unity/beast_utility_unity.cpp
M       src/ripple/beast/utility/src/beast_Debug.cpp
M       src/ripple/beast/utility/src/beast_PropertyStream.cpp
D       src/ripple/beast/utility/test/beast_Journal_test.cpp
D       src/ripple/beast/utility/test/beast_Zero_test.cpp
D       src/ripple/beast/utility/test/beast_tagged_integer_test.cpp
D       src/ripple/beast/utility/test/beast_weak_fn_test.cpp
M       src/ripple/core/impl/Workers.cpp
D       src/ripple/core/tests/Config.test.cpp
D       src/ripple/core/tests/Coroutine.test.cpp
D       src/ripple/core/tests/SociDB.test.cpp
D       src/ripple/core/tests/Stoppable.test.cpp
D       src/ripple/json/tests/Object.test.cpp
D       src/ripple/json/tests/Output.test.cpp
D       src/ripple/json/tests/Writer.test.cpp
D       src/ripple/json/tests/json_value.test.cpp
D       src/ripple/ledger/tests/BookDirs_test.cpp
D       src/ripple/ledger/tests/Directory_test.cpp
D       src/ripple/ledger/tests/PaymentSandbox_test.cpp
D       src/ripple/ledger/tests/PendingSaves_test.cpp
D       src/ripple/ledger/tests/SkipList_test.cpp
D       src/ripple/ledger/tests/View_test.cpp
D       src/ripple/nodestore/tests/Backend.test.cpp
D       src/ripple/nodestore/tests/Basics.test.cpp
D       src/ripple/nodestore/tests/Database.test.cpp
D       src/ripple/nodestore/tests/Timing.test.cpp
D       src/ripple/nodestore/tests/import_test.cpp
D       src/ripple/nodestore/tests/varint_test.cpp
D       src/ripple/overlay/tests/TMHello.test.cpp
D       src/ripple/overlay/tests/cluster_test.cpp
D       src/ripple/overlay/tests/manifest_test.cpp
D       src/ripple/overlay/tests/short_read.test.cpp
D       src/ripple/peerfinder/tests/Livecache.test.cpp
D       src/ripple/peerfinder/tests/PeerFinder_test.cpp
D       src/ripple/protocol/tests/BuildInfo.test.cpp
D       src/ripple/protocol/tests/IOUAmount.test.cpp
D       src/ripple/protocol/tests/InnerObjectFormats.test.cpp
D       src/ripple/protocol/tests/Issue.test.cpp
D       src/ripple/protocol/tests/PublicKey_test.cpp
D       src/ripple/protocol/tests/Quality.test.cpp
D       src/ripple/protocol/tests/STAccount.test.cpp
D       src/ripple/protocol/tests/STAmount.test.cpp
D       src/ripple/protocol/tests/STObject.test.cpp
D       src/ripple/protocol/tests/STTx.test.cpp
D       src/ripple/protocol/tests/SecretKey_test.cpp
D       src/ripple/protocol/tests/Seed_test.cpp
D       src/ripple/protocol/tests/XRPAmount.test.cpp
D       src/ripple/protocol/tests/digest_test.cpp
D       src/ripple/protocol/tests/types_test.cpp
M       src/ripple/resource/impl/Entry.h
D       src/ripple/resource/tests/Logic.test.cpp
D       src/ripple/rpc/tests/AccountInfo_test.cpp
D       src/ripple/rpc/tests/AccountLinesRPC.test.cpp
D       src/ripple/rpc/tests/AccountObjects_test.cpp
D       src/ripple/rpc/tests/AccountOffers.test.cpp
D       src/ripple/rpc/tests/AccountSet.test.cpp
D       src/ripple/rpc/tests/Book.test.cpp
D       src/ripple/rpc/tests/GatewayBalances.test.cpp
D       src/ripple/rpc/tests/JSONRPC.test.cpp
D       src/ripple/rpc/tests/KeyGeneration.test.cpp
D       src/ripple/rpc/tests/LedgerData.test.cpp
D       src/ripple/rpc/tests/LedgerRequestRPC.test.cpp
D       src/ripple/rpc/tests/RobustTransaction.test.cpp
D       src/ripple/rpc/tests/ServerInfo.test.cpp
D       src/ripple/rpc/tests/Status.test.cpp
D       src/ripple/rpc/tests/Subscribe.test.cpp
D       src/ripple/server/tests/Server_test.cpp
D       src/ripple/shamap/tests/FetchPack.test.cpp
D       src/ripple/shamap/tests/SHAMap.test.cpp
D       src/ripple/shamap/tests/SHAMapSync.test.cpp
D       src/ripple/test/impl/BasicNetwork_test.cpp
D       src/ripple/test/impl/WSClient_test.cpp
D       src/ripple/test/jtx/impl/Env_test.cpp
D       src/ripple/unity/app_tests.cpp
M       src/ripple/unity/basics.cpp
M       src/ripple/unity/beast.cpp
M       src/ripple/unity/core.cpp
M       src/ripple/unity/json.cpp
M       src/ripple/unity/ledger.cpp
M       src/ripple/unity/nodestore.cpp
M       src/ripple/unity/overlay.cpp
M       src/ripple/unity/peerfinder.cpp
M       src/ripple/unity/protocol.cpp
M       src/ripple/unity/resource.cpp
M       src/ripple/unity/rpcx.cpp
M       src/ripple/unity/server.cpp
M       src/ripple/unity/shamap.cpp
M       src/ripple/unity/soci_ripple.cpp
M       src/ripple/unity/test.cpp

There's a lot of translation units in one folder and its hard to browse. We should bring some of the hierarchy back:
test/app/
test/basics/
test/beast/
test/core/
test/json/
test/ledger/
test/nodestore/
test/overlay/
test/peerfinder/
test/protocol/
test/resource/
test/rpc/
test/server/
test/shamap/

// These loose files can go in test/ and we
// can figure out what to do with them later:
src/ripple/test/impl/BasicNetwork_test.cpp
src/ripple/test/impl/WSClient_test.cpp
src/ripple/test/jtx/impl/Env_test.cpp

See previous GitHub comment for the original list of modified and deleted files to know what goes where.

Will do. I can make corresponding unity sources for those took rather than the arbitrary numbering.

test/app is going to be over-represented I think, you might have to break that up into a couple of unity files (not sure though).
Also, not for this PR but the code in src/ripple/test is all test code (the jtx framework in particular) and will have to be moved but its not quite a simple rename.

Updated the directory structure.  I also added a call to lcov --remove src/ripple/test to ignore that from code coverage for now.  I suppose the remove approach could've been done instead of moving all the files around, but it seems worth having the tests out of the src/ripple tree anyway.
AppVeyor died downloading dependencies again =(

@bachase Over time I want to migrate the structure of the repository to resemble Boost with test separate, doc directory, etc.. and hopefully parts of rippled broken up into individual libraries that are stand-alone (Ed's work on this is promising).

Link errors building debug/unity
1>app_main.obj : error LNK2019: unresolved external symbol "public: void __cdecl ripple::LedgerMaster::setMinValidations(int,bool)" (?setMinValidations@LedgerMaster@ripple@@QEAAXH_N@Z) referenced in function "public: virtual bool __cdecl ripple::ApplicationImp::setup(void)" (?setup@ApplicationImp@ripple@@UEAA_NXZ)
1>app_misc.obj : error LNK2019: unresolved external symbol "public: int __cdecl ripple::LedgerMaster::getMinValidations(void)" (?getMinValidations@LedgerMaster@ripple@@QEAAHXZ) referenced in function "public: virtual class Json::Value __cdecl ripple::NetworkOPsImp::getServerInfo(bool,bool)" (?getServerInfo@NetworkOPsImp@ripple@@UEAA?AVValue@Json@@_N0@Z)
1>

Hrmm, my VS debug unity from scratch just went through ok.  I ran scons again but don't see any diffs in the project files...

I suspect one of the unity.cpp files is missing an include. Find the translation unit that has the missing symbol, and try to convince yourself that it is being included in the unity build.

Yes, that is what I tried,  setMinValidations is defined https://github.com/ripple/rippled/blob/1ee6ebcf6251c2a4f847e59276de2de9a74406e7/src/ripple/app/ledger/impl/LedgerMaster.cpp#L1323.
I see LedgerMaster.cpp in https://github.com/ripple/rippled/blob/1ee6ebcf6251c2a4f847e59276de2de9a74406e7/src/ripple/unity/app_ledger.cpp#L40
And I see app_ledger.cpp in
https://github.com/ripple/rippled/blob/1ee6ebcf6251c2a4f847e59276de2de9a74406e7/Builds/VisualStudio2015/RippleD.vcxproj#L3271

Hmm... goofing around with app_ledger.cpp and then reverting it made the problem disappear for me. I'm willing to chalk it up to Microsoft suck.

Great job
:+1:

Part of #1831 now