[Android] Input.Date and Input.Time value/min/max consistency

Platform
What platform is your issue or question related to? (Delete other platforms).

Android

Issue
The Input.Date value/min/max properties should only be recognized if they are of the form YYYY-MM-DD. The Input.Time value property should only be recognized if it's of the form HH:MM. The Android code should use the shared model's DateTimePreparser::TryParseSimpleDate and DateTimePreparser::TryParseSimpleTime methods added in #2450 to ensure consistency.

@almedina-ms assigning to you to take a look

Fixed by #2732


docs: change webpack example configuration to relative URL

This will fix the webpack tutorial for people who develop on remote machines.

Thanks, fixed it on a different PR.


customize message field with json formatter

This add MessageField option to JSONFormatter to customize the message field
name instead of the default msg.
For example, to change the message field to message
log.SetFormatter(&logrus.JSONFormatter{MessageField: "message"})

Fix #367

Thanks, @dqminh. I'll take a look at this pull request sometime this week.

@aarongreenlee have you had the chance to look at this ?

Why not allow the parameterization of any of the fields?

Looks like #396 addresses this, as well.

@stevvooe yep, #396 also does this. I will just close this one since i think #396 is reasonable.


renaming things / refactoring / modifying output

[ ] :term should be :coefname => same as MixedModels
[ ] mres.X.Xs is confusing => mres.designmatrix

[ ] think about saving non-timexpanded designmatrix. Could be useful
[ ] think about dynamically generated designmatrix (i.e. mres.X calls modelcols(mres.formula) or something

[ ] fit should give one output

[ ] factor out condense_long,
[ ] reprogram to DataFrame(UnfoldModelResult)

[ ] think hard what the model fields should really be. Currently beta is the same for all models, but we could have an abstract type, not entirely sure how that would work
[ ] we should think about putting in an abstract UnfoldModel  and 4 subtypes UnfoldLinearModel, UnfoldLinearMixedModel, UnfoldLinearMixedModelContinuousTime and UnfoldLinearModelContinuousTime
Or maybe UnfoldLMM UnfoldLM UnfoldLMMcontTime and UnfoldLMcontTime. Not sure. "UnfoldLinearMixedModelContinuousTime" is pretty darn long. That would allow for nicer multiple dispatch
[ ] follow the syntax of RegressionModels e.g. https://github.com/JuliaStats/MixedModels.jl/issues/514 or https://github.com/JuliaStats/StatsBase.jl/blob/master/src/statmodels.jl

we should think about putting in an abstract UnfoldModel and 4 subtypes UnfoldLinearModel, UnfoldLinearMixedModel, UnfoldLinearMixedModelContinuousTime and UnfoldLinearModelContinuousTime
Or maybe UnfoldLMM UnfoldLM UnfoldLMMcontTime and UnfoldLMcontTime. Not sure. "UnfoldLinearMixedModelContinuousTime" is pretty darn long. That would allow for nicer multiple dispatch

I think having 2 subtypes UnfoldLinearModel, UnfoldLinearMixedModel should suffice. ContinuousTime should be handled in getdata()

The internal datastructures are different though.
I.e. UnfoldLMMContinuous has a single LMM per channel, whereas UnfoldLMM is ntime-LMMs. While the extracted coefficients are the same (nchannel x ntime), the internal datastructure is quite different.
I want to keep the LMMs around because then things like predict & Likelihood-Ratio-Testing are much easier

[ ] modify TimeExpand to allow non-timeexpanded modelcols/coefnames etc. Not yet sure how to do. This would allow to plot the "normal" aka non-timeexpanded designmatrix without manually constructing that model

I was thinking again, and a proper API would be helpful. Will try to implement this
modelmatrix(::UnfoldModel) # normal designmatrix
modelcols(::UnfoldModel,timeexpand=true) # timeexpanded designmatrix (current X.Xs)

formula(::UnfoldModel)

coefTable(::UnfoldModel)# => condense_long
coefDataFrame(::UnfoldModel)# => DataFrame(coeftable)

coef(::UnfoldModel)# => mres.beta => A matrix representation of the coefficients results [what to do with random effects?]

predict(::UnfoldModel,::DataFrame)


Dev ilknur

login and signup pages edited, added gitignore, added nodemon, node modules added git ignore

merged branches


Add some simple DB caching mechanism on the Rust side

We require this as the realm API pre-processes the database information into an actual tree. We really don't want to do that for every single request. That said, caching -- as it's a performance optimization -- should really not be our concern right now. We should start with a very very simple cache and always lean towards less caching ("correctness over performance").

We talked about caching recently and there were some interesting points.

We can basically distinguish between "in Rust" caching and "external cache" (like memcache). This issue is just about the "in Rust" caching. Personally, I'm probably also against external caches.

Then there are basically two approaches: always up to date cache and time based cache.

Always up to date: the cache should always contain up to date information and never be stale. A stale cache is considered a bug. This requires manually invalidating the cache when the data updates, so we need to add code everywhere we change anything.
Time based: we accept stale data and just cache stuff for a few seconds, for example. This does not require any cache specific code to invalidate the cache, but obviously have a few major disadvantages. Most of the time, if data is a few seconds out of date, that doesn't matter. But if a user just changed sth and the change is not immediately visible, that makes for a bad user experience. Potentially worse: if we combine multiple sources of data and those sources have a different age, we can throw most of our assumptions about our data out of the window.

If we have multiple Tobira instances, an "always up to date" cache is not really possible. When something is changed, one would have to send cache invalidation messages to all other instances. This in itself would already mean putting time into developing such an internal API for doing that. But that wouldn't even solve it because you always have network delays. One could add a time-based fallback to invalidating caches, but in general this solution adds quite a bit of complexity and in the end one can't be 100% sure about whether the data is stale anyway.

Load balancer usually have sessions which allows them to route the same user to the same instance every time. That would make these effects a bit less problematic.

We probably want Tobira to run with multiple instances.

The conclusion for now is: no caching, just hit the DB every time. We still need to remove the RealmTree cache (which is never invalidated right now).


Set PLAYWRIGHT_BROWSERS_PATH to "0" only when not explicitly set by the user

Fixes #992
Set PLAYWRIGHT_BROWSERS_PATH to "0" only when not explicitly set by the user

Basically this is OK, but I am thinking would it be possible to write a test for this?


RequestFailed when trying to get a CSV

Hi All,
Thanks for a really great tool! It's been amazing how much cleaner code looks when using the puppeteer apis vs other tools. I'm having trouble getting the contents of a csv. It looks to be working fine up to and including the response headers but then the request fails and I'm unable to get the contents of the csv.
Steps to reproduce
Tell us about your environment:

Puppeteer version: 0.12.0
Platform / OS version: Ubuntu 17.04
URLs (if applicable):

What steps will reproduce the problem?
Please include code that reproduces the issue.

Create a csv

test.csv
a,b,c
c,b,a

Host it somewhere on the internet

Here we use ngrok but you can use anything
> python -mSimpleHTTPServer 8000
> ngrok http 8000

Try to get the contents of the csv

index.js
const puppeteer = require('puppeteer');

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage();

  page.on('request', r => {
    console.log('request: ' + r.url + ' ' + r.method);
  });
  page.on('requestfailed', r => {
    console.log('request failed: ' + r.url + ' ' + r.method);
  });
  page.on('requestfinished', r => {
    console.log('request finished: ' + r.url + ' ' + r.method);
  });
  page.on('response', r => {
    console.log('response: ' + r.url + ' ' + JSON.stringify(r.headers));
  });

  await page.goto('http://bd5e3284.ngrok.io/test.csv');
})();

> npm install puppeteer
> node index.js

What is the expected result?
Request Finished event with page.contents() returning a promise of the csv as a string.
What happens instead?
Request failure. The response headers and content type and content length all seem correct but it emits a request failure. I've also been unable to get the contents of the file, either with page.content() or response.text().
request: http://bd5e3284.ngrok.io/test.csv GET
response: http://bd5e3284.ngrok.io/test.csv {"date":"Fri, 20 Oct 2017 13:42:30 GMT","last-modified":"Fri, 20 Oct 2017 13:02:27 GMT","server":"SimpleHTTP/0.6 Python/2.7.13","connection":"keep-alive","content-length":"12","content-type":"text/csv"}
response: http://bd5e3284.ngrok.io/test.csv {"date":"Fri, 20 Oct 2017 13:42:30 GMT","last-modified":"Fri, 20 Oct 2017 13:02:27 GMT","server":"SimpleHTTP/0.6 Python/2.7.13","connection":"keep-alive","content-length":"12","content-type":"text/csv"}
request failed: http://bd5e3284.ngrok.io/test.csv GET

Looks like a duplicate of #299 to me.

Indeed! Closing.


SAA-2208: Add retries to prison api client

Codecov Report
Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (fe6cc65) to head (dd6b51b).

Files with missing lines
Patch %
Lines

...agementapi/client/prisonapi/api/PrisonApiClient.kt
94.20%
1 Missing and 3 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1200      +/-   ##
============================================
+ Coverage     84.45%   84.57%   +0.12%
- Complexity     3749     3757       +8
============================================
  Files           385      385
  Lines         12714    12767      +53
  Branches       1098     1098
============================================
+ Hits          10737    10798      +61
+ Misses         1470     1459      -11
- Partials        507      510       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding parentheses as a negative format for Decimal and Integer aliases (100)

A negative number can be represented by either a dash -100 or parentheses (100).
As of now, only the following format is supported -100.
Is it possible to add this feature?
Also a user doesn't have to go all the way to the left of the number to add the negative sign; Pressing the - key anywhere in the input field, should "toggle" the negative sign ( Either add - to the left of the number, or wrap it in () depending on the user configuration).

@YoussefTaghlabi ,
I'm working on the () as negationsymbol.  But I have a question about.  Does the parentheses have to surround the prefix/suffix symbols or not??    $ (123) or ($ 123)


fix: bug where regex would always fail when validating against multiple allowed file mime types

Thank you!


Add custom offsets feature

This extends MarkOffset/MarkPartitionOffset and ResetPartitionOffset/ResetPartitionOffset methods, using which can fetch consumed offset from Kafka.

Sorry, really not a fan of this.  I also think Kafka may reject that, if you try to update a non-subscribed offset with your member/generation IDs


diagnose slowdown in processSubscriptions() (2)

I think we pretty much analyzed this one last week, it's largely correlated to the number of transactions that we're processing at this point so the optimization work on this is going to go into the next phase of the indexer.


feat: add svelte support

cc @OSpoon given your expertise adding support for Preact and Vue, could you help reviewing this one?

@akadotsh
This is a great PR. I have found that it seems there is a lack of hot updating capability. Could you please confirm this?

Thank you for the feedback, @OSpoon. I’ve reviewed the code, and you're right hot updating is not working properly. I’ll work on that and update the PR.

Thank you for the feedback, @OSpoon. I’ve reviewed the code, and you're right hot updating is not working properly. I’ll work on that and update the PR.

Here are some options related to hot updates, you can refer to them:
https://github.com/sveltejs/svelte-loader#hot-reload


🗑 Cleanup after minimization

Cleanup

Move the below entities in libs/shared/data

[x] libs/ui/shared/elements/flag
[ ] libs/ui/shared/elements/icon
[x] libs/ui/shared/elements/image

Started in https://github.com/usama251993/itinerary-assistant/commit/8ac831802d32b517126eea75c87d29594f84da9d

Closed in https://github.com/usama251993/itinerary-assistant/commit/1124bbba4260959ac847c8fc5ec3dbd45d661c52


Bing engine fails on large BLOB of text

I noticed that the Bing engine fails to break a big BLOB into smaller part, while the Google one does not have this problem. Google engine has a limit on the text size, I assume you do multiple requests to overcome this limitation. It seems this does not happen for the Bing engine.

File input is always broken down into lines (for all engines). There is no special circumvention for Google Translate at all.
If something works for Google Translate but not Bing, then it means you've reached Bing's free quota of requests per IP per sec. (and that cannot be solved simply by breaking a file further.)


Add CONDA_ENV to specify conda environment to use in runner

Description
Make it easier for users to install another Python version.
I will add an example to the docs on the improv/docs branch :+1:

Not sure if we can just modify the PATH variable instead of actually calling conda activate.
As per their docs they:

Activation entails two primary functions: adding entries to PATH for the environment and running any activation scripts that the environment may contain. These activation scripts are how packages can set arbitrary environment variables that may be necessary for their operation. You can also use the config API to set environment variables.

I see. I had a look at the activate script and figured I might as well just change the PATH myself. Will change it to activation of the environment and test it :+1:

Changing the else in the bootscript to:
    source /opt/conda/etc/profile.d/conda.sh \
        && conda activate "$CONDA_ENV" \
        && /usr/local/bin/bootstrap-kernel.sh

ends up in the kernel not starting. Not really sure what is going on there.
(Also changed the CONDA_ENV in the Dockerfile to "base")

Well... we might have to find an alternative to conda run: https://github.com/conda/conda/issues/2904

To test. Create an environment containing:
conda create -y -n py38 python=3.8 future
conda install -y -n py38 ipykernel jupyter_client ipython_genutils pycryptodomex future
conda run -n py38 pip install orchest

Next set two environment variables (I recommend using project environment variables):

CONDA_ENV=py38
JUPYTER_PATH=/opt/conda/envs/py38/share/jupyter

Looks like conda shell.bash hook is recommended in a number of places and used by the conda project itself in various places (e.g. here).
LGTM like this!


add demo to simulate usage in a game engine

It has been observed in amethyst/amethyst#780 that if you use Rayon in an environment where you are not CPU bound, you may end up using many more CPU cycles than necessary. This pull request adds an example of this problem to the demo project as a starting point towards finding a way to improve efficiency in this scenario.
The life demo now has a play mode where the same comparison of serial and parallel occurs, but with a frame (generation) per second limit in place and comparing CPU time measurements at the end.
Example output for my Ryzen 7 1800X with hyperthreading (16 logical processors) in Windows 10:
$ rayon-demo life play
  serial: 59.93 fps
    cpu usage: 4.7%
parallel: 59.97 fps
  cpu usage: 55.3%
par_bridge: 59.94 fps
  cpu usage: 1164.1%

Once there are ways to improve the overhead they should be incorporated into this demo as an example. If there are already ways to improve the demo let me know and I can try to implement them now.

bors r+


[ERROR]⛔  Looking up a deactivated widget's ancestor is unsafe.

With get.off, I am preventing the splash screen page from going back.
Get.off (() => LoginScreen ());

After coming to the LoginScreen page;
Get.to (() => PhoneOTPScreen ());

If you want to switch to the PhoneOTPScreen page, I get the following error.
======== Exception caught by widgets library =======================================================
The following assertion was thrown building PhoneOTPScreenBody(dirty, state: _PhoneOTPScreenBodyState#4bfae):
Looking up a deactivated widget's ancestor is unsafe.

At this point the state of the widget's element tree is no longer stable.

To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by calling dependOnInheritedWidgetOfExactType() in the widget's didChangeDependencies() method.

The relevant error-causing widget was:
  PhoneOTPScreenBody file:///Users/xxxx/Desktop/xxxx/xxxx/lib/screens/phone_otp/phone_otp_screen.dart:9:14
When the exception was thrown, this was the stack:
#0      Element._debugCheckStateIsActiveForAncestorLookup.<anonymous closure> (package:flutter/src/widgets/framework.dart:3864:9)
#1      Element._debugCheckStateIsActiveForAncestorLookup (package:flutter/src/widgets/framework.dart:3878:6)
#2      Element.dependOnInheritedWidgetOfExactType (package:flutter/src/widgets/framework.dart:3893:12)
#3      Localizations.of (package:flutter/src/widgets/localizations.dart:472:48)
#4      ApplicationLocalizations.of (xxxx/utils/locale/app_localization.dart:14:26)

main dart :
  runApp(MainApp());
}

class MainApp extends StatefulWidget with WidgetsBindingObserver {
  @override
  _MainAppState createState() => _MainAppState();
}

class _MainAppState extends State<MainApp> {
  @override
  Widget build(BuildContext context) {
    SystemChrome.setPreferredOrientations([
      DeviceOrientation.portraitUp,
    ]);
    return GetMaterialApp(
      navigatorKey: Get.key,
      enableLog: true,
      defaultTransition: Transition.fade,
      opaqueRoute: Get.isOpaqueRouteDefault,
      popGesture: Get.isPopGestureEnable,
      transitionDuration: Get.defaultTransitionDuration,
      defaultGlobalState: Get.defaultOpaqueRoute,
      debugShowCheckedModeBanner: false,
      logWriterCallback: localLogWriter,
      theme: theme(),
      home: SplashScreen(),
      supportedLocales: [
        Locale('en', 'US'),
      ],
      locale: Utils.appLocale,
      localizationsDelegates: [
        const AppLocalizationsDelegate(),
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate
      ],
    );
  }

  void localLogWriter(String text, {bool isError = false}) {
    print("Log : " + text);
  }
}

My advice to Flutter developers is never build your project based on 3rd party (and unrelated) libraries.

Initially, follow the issue opening form. Without a replay code, it is not possible to analyze a possible problem.
Furthermore, it is not possible to verify any problem with a code snippet where you have:
SplashScreen> Get.off> Get.to
Furthermore, the error is clearly not related to this library. You are trying to access a state of a disabled StatefulWidget after the widget leaves the tree.


Added travis config.

@elibixby can you take a quick look?

tox command not found

@lesv Can you take a look?


Using a different configuration file name from QT

At the moment both QT and QML gui apps are using the same naming convention for configuration files (Bitcoin*.conf), so separating guiconstants.h file from QT, copying it from src/qt to src/qml and updating QAPP_APP_NAME_* constants values will avoid them clashing with each other trying to persist/ read same or different settings (e.g. configuration file for QT on signet will be still named as Bitcoin-Qt-signet.conf, as of today, while QML will start using a separate file named Bitcoin-Qml-signet.conf - before this fix, currently sometimes a user can get a warning on reading incorrect settings or values: QVariant::load: unknown user type with name BitcoinUnits::Unit.).
This could be a temporary fix (? - gui constants file contents has been cleaned up as suggested) so instances from both QT and QML gui apps don't interfere between them during QML development. This change will be transparent for both QT gui app and users.

Sample of a separate QT config file on signet (Bitcoin-Qt-signet.conf).
[General]
DisplayBitcoinUnit=@Variant(\0\0\0\x7f\0\0\0\x13\x42itcoinUnits::Unit\0\0)
MainWindowGeometry=@ByteArray(\x1\xd9\xd0\xcb\0\x3\0\0\0\0\x2\xa3\0\0\x1v\0\0\x5\xb0\0\0\x3^\0\0\x2\xa3\0\0\x1v\0\0\x5\xb0\0\0\x3^\0\0\0\0\0\0\0\0\a\x80\0\0\x2\xa3\0\0\x1v\0\0\x5\xb0\0\0\x3^)
PeersTabBanlistHeaderState=@ByteArray()
PeersTabPeerHeaderState=@ByteArray()
RPCConsoleWindowGeometry=@ByteArray(\x1\xd9\xd0\xcb\0\x3\0\0\0\0\x2q\0\0\x1\x8f\0\0\x5T\0\0\x3<\0\0\x2q\0\0\x1\x8f\0\0\x5T\0\0\x3<\0\0\0\0\0\0\0\0\a\x80\0\0\x2q\0\0\x1\x8f\0\0\x5T\0\0\x3<)
RPCConsoleWindowPeersTabSplitterSizes=@ByteArray(\0\0\0\xff\0\0\0\x1\0\0\0\x2\xff\xff\xff\xff\xff\xff\xff\xff\0\xff\xff\xff\xff\x1\0\0\0\x1\0)
SubFeeFromAmount=false
enable_psbt_controls=false
fCoinControlFeatures=false
fHideTrayIcon=false
fMinimizeOnClose=false
fMinimizeToTray=false
fRestartRequired=false
nSettingsVersion=279900
strDataDir=/home/pablo/.bitcoin
strThirdPartyTxUrls=

Sample of a separate QML config file on signet (Bitcoin-Qml-signet.conf).
[General]
blockclocksize=0.4166666666666667
dark=true
height=665
width=640
x=755
y=339

Concept ACK. Wonder if we need all of the other constants with the new application?

I haven't investigated yet, the main purpose for this change was to get the config file separate from QT and I clarified at the top that we could do the cleanup later, in case there are features that we don't have/ use in QML at the moment but we'll need them later, but I'm open, we could do the cleanup now and bring the constants back as soon as we need them (if we ever need them).

I tried deleting everything else from that file and the only constant being used is DEFAULT_SPLASHSCREEN. I think we should only keep the constants we are using, I don't think its a good idea to add lines of code that aren't used.
so something like
// Copyright (c) 2011-2024 The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.

#ifndef BITCOIN_QML_GUICONSTANTS_H
#define BITCOIN_QML_GUICONSTANTS_H

static const bool DEFAULT_SPLASHSCREEN = true;

#define QAPP_ORG_NAME "Bitcoin"
#define QAPP_ORG_DOMAIN "bitcoin.org"
#define QAPP_APP_NAME_DEFAULT "Bitcoin-Qml"
#define QAPP_APP_NAME_TESTNET "Bitcoin-Qml-testnet"
#define QAPP_APP_NAME_SIGNET "Bitcoin-Qml-signet"
#define QAPP_APP_NAME_REGTEST "Bitcoin-Qml-regtest"

#endif // BITCOIN_QML_GUICONSTANTS_H

DEFAULT_SPLASHSCREEN

I think not even that one, all command line args described in bitcoin.cpp::SetupUIArgs are useless (so far), but regarding the splash-screen (which I mentioned in the wallet intro PR review), @GBKS confirmed, on a designers call a couple of weeks ago, that we are not using that on this project, it's an old fashion approach nowadays.
I'll update the file soon. Thanks!

Updates:

Addressed @johnny9's feedback.

Updates:

Addressed @hebasto's feedback on file naming convention.


Feature: Reauthentication after disconnect

Is your feature request related to a problem? Please describe.
The feature request is related to improve the security.
Describe the solution you'd like
For security reasons, we want that when a user disconnects, he has to re-authenticate. It would be great if we could have a "setting" that could be set per user to control the disconnect behaviour.
Describe alternatives you've considered
None.

Hello @giezi we are currently working on a time-based peer expiration, where peers activated by users will require authentication after N hours (from 1 hour to 180 days).

Hello @giezi we are currently working on a time-based peer expiration, where peers activated by users will require authentication after N hours (from 1 hour to 180 days).

Would there be a setting to disable the expiration? e.g. for a peer that is used for a service (like a DNS server) rather than a user endpoint

@e-renna yes the feature will be enabled for new accounts. For existing accounts you can choose to enable in the account settings and you can also choose to disable expiration for specific peers.

See https://github.com/netbirdio/netbird/releases/tag/v0.14.2


Use new buildin SVG feature to draw graphs

Viewflow pro has a new module called viewflow.charts that has SVG functionality.

@codingjoe graphviz is still listed in requirements-dev.in, requirements-dev.txt and .travis.yml. Should it be removed?


SchemaUpdateStrategyTest is broken and not run

Describe the bug
Schema integration tests in SchemaUpdateStrategyTest are not run because they are not added in https://github.com/apache/pulsar/blob/master/tests/integration/src/test/resources/pulsar.xml.
Some of the tests also appear to be broken

@congbobo184 Can you  help take a look this issue?

like this？

 <classes>
            <class name="org.apache.pulsar.tests.integration.cli.CLITest" />

            <class name="org.apache.pulsar.tests.integration.cli.HealthCheckTest" />

            <class name="org.apache.pulsar.tests.integration.compaction.TestCompaction" />

            <class name="org.apache.pulsar.tests.integration.cli.AdminMultiHostTest"/>

            <class name="org.apache.pulsar.tests.integration.cli.FunctionsCLITest"/>

            <class name="org.apache.pulsar.tests.integration.cli.SchemaUpdateStrategyTest"/>

        </classes>

seems the current test is running well in current ci. would like to close this issue


New version: Genivia.ugrep version 4.3.1

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Executable-Error


Fix lookup code to pass functions with the same name as built-ins

Fix https://github.com/godotengine/godot/issues/58017

Thanks!


crash on right click event

Describe the bug
right click any block and you'll crash
Expected behavior
no crash
Screenshots
NA
Desktop (please complete the following information):

OS: Windows
Launcher: CurseForge
Memory: 8GB
Modpack Version 2.5 Beta

Additional context
caused by https://github.com/ixDarkLorD/UltimineAddition/issues/11

been fixed by the dev of ultimine for next update :)


Pulumi.LogException during Integration tests

What happened?
Hi,
We are doing xUnit integration tests with Pulumi and we often get Pulumi.LogException:
Pulumi.LogException : Error occurred during logging
   Error Message:
    Pulumi.LogException : Error occurred during logging
 ---- Grpc.Core.RpcException : Status(StatusCode="Unavailable", Detail="Error connecting to subchannel.", DebugException="System.Net.Sockets.SocketException: Connection refused")
 -------- System.Net.Sockets.SocketException : Connection refused
   Stack Trace:
      at Pulumi.Deployment.EngineLogger.LogAsync(LogSeverity severity, String message, Resource resource, Nullable`1 streamId, Nullable`1 ephemeral)
    at Pulumi.Deployment.Runner.LogExceptionToErrorStream(Exception exception)
    at Pulumi.Deployment.Runner.HandleExceptionsAsync(IEnumerable`1 exceptions)
    at Pulumi.Deployment.Runner.WhileRunningAsync()
    at Pulumi.Deployment.<>c__DisplayClass80_0.<<RunInlineAsync>b__1>d.MoveNext()
 --- End of stack trace from previous location ---
    at Pulumi.Automation.WorkspaceStack.UpAsync(UpOptions options, CancellationToken cancellationToken)
    at Pulumi.Automation.WorkspaceStack.UpAsync(UpOptions options, CancellationToken cancellationToken)
    at AllegroPay.IaC.Azure.IntegrationTests.EphemeralInfrastructureFixture.InitializeStackAsync[TStack](String module, String projectName, Action`1 configure, Action`1 action) in /_/tests/AllegroPay.IaC.Azure.IntegrationTests/EphemeralInfrastructureFixture.cs:line 86
    at AllegroPay.IaC.Azure.IntegrationTests.EphemeralInfrastructureFixture.InitializeAsync() in /_/tests/AllegroPay.IaC.Azure.IntegrationTests/EphemeralInfrastructureFixture.cs:line 29
 ----- Inner Stack Trace -----
    at Grpc.Net.Client.Balancer.Internal.ConnectionManager.PickAsync(PickContext context, Boolean waitForReady, CancellationToken cancellationToken)
    at Grpc.Net.Client.Balancer.Internal.BalancerHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
    at Grpc.Net.Client.Internal.GrpcCall`2.RunCall(HttpRequestMessage request, Nullable`1 timeout)
    at Pulumi.GrpcEngine.LogAsync(LogRequest request)
    at Pulumi.Deployment.EngineLogger.LogAsync(LogSeverity severity, String message, Resource resource, Nullable`1 streamId, Nullable`1 ephemeral)
 ----- Inner Stack Trace -----
    at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
    at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
    at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
    at Grpc.Net.Client.Balancer.Internal.SocketConnectivitySubchannelTransport.TryConnectAsync(ConnectContext context, Int32 attempt)

All tests fails at once. I suspect that the SDK is sending log requests to the engine which shuts down prematurely. How to print engine logs?
Example
The error is not persistent. It usually happens in CI pipeline. Our tests are set up as follows:
[Collection(nameof(EphemeralInfrastructureTestCollection))]
public class EphemeralInfrastructureFixtureTests : StackTestFixture
{
    private readonly EphemeralInfrastructureFixture _fixture;

    public EphemeralInfrastructureFixtureTests(EphemeralInfrastructureFixture fixture, ITestOutputHelper output) : base(output)
    {
        _fixture = fixture ?? throw new ArgumentNullException(nameof(fixture));

        _fixture.StackStatus.ForEach(
            stack =>
            {
                output.WriteLine($"{stack.Key} : {Enum.GetName(typeof(UpdateState), stack.Value)}");
            });

        _fixture.StandardOutput.ForEach(
            stack =>
            {
                output.WriteLine($"STDOUT {stack.Key} : {stack.Value}");
            });

        _fixture.StandardError.ForEach(
            stack =>
            {
                output.WriteLine($"STDERR {stack.Key} : {stack.Value}");
            });
    }

    [Fact]
    public void GivenEphemeralNetworkFixture_WhenInitialized_ThenFixtureNameIsNotNull()
    {
        // Assert
        _fixture.Name.Should().NotBeNullOrEmpty();
        Output.WriteLine($"Fixture: {_fixture.Name} created");
    }
}

and we set up the fixture as:
    private async Task InitializeStackAsync<TStack>(
        string module,
        string? projectName = null,
        Action<IConfigurationBuilder>? configure = null,
        Action<IImmutableDictionary<string, OutputValue>>? action = null)
        where TStack : Stack
    {
        var stack = await WorkspaceStackFactory.Create<TStack>(
            module: module,
            stackName: Name,
            projectName: projectName,
            configure: configure);
        var result = await stack.UpAsync();
    }

where WorkspaceStackFactory.Create is:
        <...>
        var program = PulumiFn.Create<TStack>(
            ServiceProviderFactory.Build(
                cb =>
                {
                    configure?.Invoke(cb);
                }));
        var inlineProgramArgs = new InlineProgramArgs(
            projectName: pn,
            stackName: stackName,
            program: program)
        { EnvironmentVariables = Constants.Environment.Concat(envVars ?? new Dictionary<string, string?>()).ToDictionary() };

        var stack = await LocalWorkspace.CreateStackAsync(inlineProgramArgs);
        <...>

Output of pulumi about
CLI
Version      3.112.0
Go Version   go1.22.1
Go Compiler  gc

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Your pulumi about output shows 3.112.0 of the CLI is being used. Is this version being used in your CI pipeline? It's quite old (latest version is 3.137.0). Not sure if it'll matter in this case, but do you still hit this when using the latest version of the CLI?


Add performance benchmark for RNN ops

This patch adds a benchmark to measure the performance of RNN ops that are LSTM, GRU and RNN.
Signed-off-by: Tung D. Le<EMAIL_ADDRESS>

LGTM, hope you appreciated the new interface.

Yes, it's quite convenient.

Jenkins Linux ppc64le Build #3777 [push] Add performance benchmar... started at 00:37

Jenkins Linux amd64 Build #4640 [push] Add performance benchmar... started at 23:33

Jenkins Linux s390x Build #4656 [push] Add performance benchmar... started at 00:33

Jenkins Linux s390x Build #4656 [push] Add performance benchmar... passed after 57 min

Jenkins Linux ppc64le Build #3777 [push] Add performance benchmar... passed after 59 min

Jenkins Linux amd64 Build #4640 [push] Add performance benchmar... passed after 1 hr 4 min


Remove UTF-8 characters from strings

The http_conn_validator try_sleep parameter has unnecessary UTF-8
quote characters which cause errors on some Puppet installs.  This
changes them to US-ASCII single quote characters.

thanks a lot, @dvorak!


Support Mixtral-8x7B-v0.1

Currently the best open model so maybe worth incorporating as soon as some other stuff gets a bit more completed and stabilized in the project.

Yes, I plan to add one as soon as this is stabilized. Here is the Candle implementation, for future reference.

mistral.rs has an implementation, closing.


Add AnimationFrame to not render too often

Performance with images is pretty bad. Maybe this helps
http://package.elm-lang.org/packages/elm-lang/animation-frame/latest/AnimationFrame

we do should be able to update more often then the draw. Also double check if input is handled correctly. Aka if messages come in correct order

Done in the image render update


Wrong hydrogen atoms placed with ACE group

Dear hydride developers!
I want to thank you for developing this great tool. I like it a lot.
I noticed a problem when adding hydrogen atoms to a polypeptide containing ACE and NME groups when using a *.pdb file-format as input.
Issue:
The protonated output is, next to ACE group, chemically wrong.
I used the additional flag "--charges 7.0", but the issue also exists without the flag.
Do you have any ideas on how to work around this issue?
Best regards!
Input files:
ace-ala7-nme_exH.zip

Hi, thanks for reporting this.
At first the --charges options should not have an effect here, since this option (and the underlying estimate_amino_acid_charges()) assigns charges only to canonical amino acids. Probably this behavior should be clarified in the documentation. To set protonation for other residues, the charge need to be set manually. Otherwise a neutral charge is assumed.
Regarding the issue of wrongly assigned hydrogen atoms, I will have a look into this problem.

Thank you for your feedback!
Regarding the problem with the protonation, I want to share additional information that I found out.
In the *.zip that I provided, there is also a *.mol file of the same test-case as the *.pdb. If I add the hydrogen atoms to the structure, loaded from the .*mol, the carbonyl group of the ACE residue gets reduced to an alcohol. I found out, that RDkit wrote a bond-order of 1 into the *.mol file by mistake, so the result from the Hydride package with the (wrong) *.mol file seems to be correct. Also, if I change the bond-order to 2, the protonation yields the expected result.
With the PDB-file, I expect that the problem comes from bonding estimation. I assume that the Bond between Residue 1 (ACE) and 2 (ALA) is missed. This leads to additional Hydrogens, where instead the N-C bond should be.
Thank you for your support.

PDB files unfortunately do not provide information about bond order. Since this information is vital for hydrogen placement, Hydride uses Biotite's connect_via_residue_names() to estimate these bonds and ditches the bonds from the PDB file. Although this is quite easy for intra-residue bonds using information from the Chemical Component Dictionary (CCD), this is difficult for bonds between residues: The algorithm creates bonds between two consecutive residues, if they are either peptide- or nucleotide-linking (again using the CCD). However, NME and ACE are both non-polymer, so the algorithm expects no bond between them and the peptide chain.
However, a bond between NME and the peptide chain is still formed. I investigated this and found a small bug in connect_via_residue_names(), so thank you for that!
Now to the most relevant part: How to fix this problem for you application. Via the CLI this unfortunately impossible at the moment, if you want to use a PDB file as input. However, if you would like to use Python instead, the following approach should fix the problem for the current Hydride version.
import biotite.structure.io.pdb as pdb
import biotite.structure as struc
import hydride

atoms = pdb.PDBFile.read("ace-ala7-nme_exH.pdb").get_structure(
    extra_fields=["charge"], model=1, include_bonds=True
)

# Expect that all ANY bonds are actually SINGLE bonds
bond_array = atoms.bonds.as_array()
bond_array[:,2] == struc.BondType.ANY
atoms.bonds = struc.BondList(atoms.array_length(), bond_array)
# Update bond order information
# with the reliable values from 'connect_via_residue_names()'
atoms.bonds = struc.connect_via_residue_names(atoms).merge(atoms.bonds)

# Actual hydrogen addition
atoms, _ = hydride.add_hydrogen(atoms)
atoms.coord = hydride.relax_hydrogen(atoms)

# Write atoms into new PDB file
pdb_file = pdb.PDBFile()
pdb.set_structure(pdb_file, atoms)
pdb_file.write("out.pdb")

### OPTIONAL: Visualization ###
import ammolite
ammolite.launch_interactive_pymol()
pymol_object = ammolite.PyMOLObject.from_structure(atoms)
pymol_object.show_as("sticks")

The output looks very promising and correct now.
Thank you for your help!


Fix experimental:preprocessor links

@eldakesh-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Pre-rendered KaTeX breaks

[placeholder for not forgetting about this and reminder to talk to @shancarter about why this happens]

@colah \o/


Provide Operator for Converge on common developer tools - Odo/Devfiles

Epic: Converge on common developer tools - Odo/Devfiles

The golang parser for devfiles appears to be here:
https://github.com/openshift/odo/tree/master/pkg/devfile/parser
We're assuming it just parses v1 devfiles now.

I've been looking for a place to organize my thoughts.... this is as good a place as any.  Please feel free to correct any technical misunderstandings that you see here.  We are only going to speak of v2 devfiles here.
There are two important artifacts (so far) that deal with devfiles - the devfile registry, and the devfile itself.  The devfile registry appears to function as the stack-index / stack-hub does.  It is a JSON file that contains a list of all the devfiles that are available.  For each devfile there is a little bit of information about what that particular stack is, and where it's actual devfile is located.  Example:
[
  {
    "displayName": "Maven Java",
    "description": "Upstream Maven and OpenJDK 11",
    "tags": [
      "Java",
      "Maven"
    ],
    "projectType": "maven",
    "language": "java",
    "links": {
      "self": "/devfiles/maven/devfile.yaml"
    }
  },
  {
    "displayName": "NodeJS Express Web Application",
    "description": "Stack with NodeJS 10",
    "tags": [
      "NodeJS",
      "Express",
      "ubi8"
    ],
    "projectType": "nodejs",
    "language": "nodejs",
    "links": {
      "self": "/devfiles/nodejs/devfile.yaml"
    }
  }
]

You will notice that there is a link to the actual devfile, as well as some describing information about what the stack is.
The devfile itself is YAML, I am not going to inline one here because it is quite large.  It contains the container images that are used to build and run an application that uses this stack.  It looks like it contains some plugin information that might be used by an IDE.
The current proposal (and it's just a proposal) is to have the Kabanero operator generate a devfile registry based on the currently active Stack CR instances, and then host that devfile registry via an external route so that developers can point odo (or whatever needs to read the devfile) at it.
My thoughts and questions include:

The Stack CR instance currently can have multiple versions of a stack.  It would seem like the version struct could contain a link to the devfile that goes with it, and that the Kabanero operator could then retrieve that devfile from that URL and use it when hosting the devfile registry (to point back to the devfile).
It's not clear to me whether the information in the devfile registry (ie project type, etc) is important to tooling, or if it's just there to help someone understand what it's pointing at.  If it's important to tooling, then there needs to be some way to encode that information into the Stack CR instance so that it can be included in the devfile registry that the Kabanero operator is going to host.
It has been suggested that the Kabanero operator shouldn't need to look at the devile itself, only generate a registry.  If that's the case, then it's not clear to me how Kabanero would ever be able to do things like digest checking on the stack container images, since that information is in the devfile yaml, not the devfile registry json.


minimize html

exactly which files do you want minimized?

theres 3 index.html file one in the root dir and the others in 2015 and 2016 these are the files to be minimized and outputted to the dist file with their event.json in the same dir

theres also comments at the top of the page you'll need to remove

@butlerx Hi sir,
i actually wanted to contribute to this repo and cloned it to my machine yesterday. I was having problems while setup process as the terminal showed me some errors while npm install command execution. Moreover, i wasn't able to run gulp command to run index.html file at localhost. Can you please guide me ?

what where your errors with the npm install

@butlerx i sorted it out . now it's working ! Can you assign me for this issue ? And what else is to be minimised in index.html apart from removing comments at top?
Thanks.

removing the whitespace and comments should be everything
i also can assign you the issue as you arnt part of the repo or the organisation

Is this issue resolved? @butlerx

this issue isnt resolved but @shivamluthra only said he was goign to work on it yesterday

@butlerx I am done with the minification part. Just remind me again that do i have to place all three index.html files along with their event.json in dist directory only or let them be there in different folders only as it is there before?

put them in the dist directory with the event beside them but they need to keep their folder structure so you should have ./dist/index.html, ./dist/event.json, and ./dist/2015, ./dist/2016 with theire index and event.json in them


fix: undefined dns_resolver

fix for
Error: Unsupported attribute

  on .terraform/modules/oci_lz_orchestrator.oci_lz_network/dns.tf line 113, in locals:

 113:       vcn_value.dns_resolver != null ? vcn_value.dns_resolver.attached_views != null ? [

This object does not have an attribute named "dns_resolver".

Fix added to v0.6.9.


Run AVD Manger in virtual machine

hello i create virtual machine 16Go Ram Intel Xeon
but i can't run avd manger
how enable nested virtualization manually
pls help

@da-production
this issue doesn't seem to describe a bug or a feature request
if you need assistance with your code please follow the link I want help writing my application in the new issue menu

Hi @da-production
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself.
Thank you


GHA Analysis pybind11 Fix

This PR resolves the error that has been failing the Analysis workflow the last few nights. The failrue was due to using a CMake config in the find module where possible, which could define an imported target that I was already defining. Now the find module only defines the target if it doesn't yet exist.
I have also removed the paths-ignore option in the CI workflow triggers. Ignore paths currently doesn't work with repos that have required checks setup for branch protection. More on that here:
https://github.community/t5/GitHub-Actions/Feature-request-conditional-required-checks/td-p/36938

Successful test Analysis run with these changes:
https://github.com/michdolan/OpenColorIO/actions/runs/95517162

A dedicated PR only containing the 'macos' fix is coming.


ConsolePanel should not render if there is no session

Description
The ConsolePanel component has a connect prop to sessionWrapper. If this prop is undefined / null, the component crashes when attempting to destructure the prop with an error "Cannot destructure property 'config' of 'sessionWrapper'". This component should not be rendered at all if sessionWrapper is undefined.
Steps to reproduce

Run DHC such that it requires PSK for login
Login
Open a file (this seems to be necessary to fail the logout)
Logout

Expected results
There should be no console errors. Login and logout should log the user in and out respectively.
Actual results
On login there is a console error "Cannot destructure property 'config' of 'sessionWrapper'". On logout, the same error occurs, and login fails.
Additional details and attachments

Versions
Engine Version: 0.31.0-SNAPSHOT
Web UI Version: 0.56.0
Java Version: 21.0.1
Barrage Version: 0.6.0

This may actually be 2 separate bugs. I tried returning null from the component when the sessionWrapper is undefined. This got rid of the console error, but the session still persisted when logging out if a file is open. Closing the file and logging out works as expected.


Loading a media randomly leads to a timeout issue

I use the following flow and latest branch (refactoring) :
var chromecast = await TestHelper.FindChromecast();
var client = new ChromecastClient();
await client.ConnectChromecast(chromecast);

var status = await client.LaunchApplicationAsync("B3419EF5");

var media = new Media
{
    ContentUrl = "https://commondatastorage.googleapis.com/gtv-videos-bucket/CastVideos/mp4/DesigningForGoogleCast.mp4"
};

var mediaStatus = await client.GetChannel<IMediaChannel>().LoadAsync(media);

Most of the time, the application "SharpCaster Demo Receiver" launch successfully, but calling LoadAsync(media) leads to a timeout issue 90% of the time (thrown by TimeoutAfter method).
Btw, the unit test TestLoadingMedia fails (timeout issue) and the test ConnectToChromecastAndLaunchApplicationTwice fails because both LaunchTransportId are same.

Load media is not really failing because of a timeout issue. It's failing since Chromecast responds with "Close" message and the current logic doesn't handle that message and just responds to timeout.
So there is something wrong on the logic that sends the Load Media and the strange thing here is that Chromecast sometimes accepts it.
Will need to check ConnectToChromecastAndLaunchApplicationTwice test, since it should be working. Might be that I have broken it or the test case is not stable enough. The test cases will cover all of the use cases of the SDK and will be used to verify the stability of SDK.
The refactoring branch is still "Work In Progress" and I wouldn't recommend using it currently. It is still missing some features and the MediaChannel still has quite a lot of problems. Also, it will still have a lot of changes before I land it into Dev and later to Master.


[bug] yarn tauri dev window crashes and restart with no any error message printed.

Describe the bug

When using yarn tauri dev, the window closes after executing a tauri::command and automatically reopen. With no any panic message.
When yarn build and then using cargo run, the program works just fine, no any error occurs. Which is wired.

I guess this is a bug of @tauri/cli.
Reproduction

git clone https://github.com/Tnze/ffxiv-best-craft.git
git checkout e804ed40496595fb3143f38bf641b2f62c15dc07
yarn install
yarn tauri dev
Click the second button

Expected behavior
Expecte the cli doesn't close and reopen my window.
Platform and versions
yarn-run-tauri 1.1.1
  › Node.js: 18.10.0
  › npm: 8.19.2
  › pnpm: Not installed!
  › yarn: 3.2.1
  › rustup: 1.25.1
  › rustc: 1.66.0-nightly
  › cargo: 1.66.0-nightly
  › Rust toolchain: nightly-x86_64-pc-windows-msvc

Packages
  › @tauri-apps/cli [NPM]: 1.1.1
  › @tauri-apps/api [NPM]: 1.1.0
  › tauri [RUST]: 1.1.1,
  › tauri-build [RUST]: 1.1.1,
  › tao [RUST]: 0.14.0,
  › wry [RUST]: 0.21.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:5173/
  › framework: Vue.js

App directory structure
  ├─ .git
  ├─ .vscode
  ├─ .yarn
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src
  └─ src-tauri

Stack trace
DOESN'T EXIST

Additional context
The tauri::command executed is this one:
https://github.com/Tnze/ffxiv-best-craft/blob/e804ed40496595fb3143f38bf641b2f62c15dc07/src-tauri/src/main.rs#L107-L111
The defining of app_state is tauri::State<'_, AppState> which has to write a '_ lifetime for pass the compiling. That is different from other commands. Is that expected?

I connect the db file in read-only mode: sqlite:./assets/xiv.db?mode=ro. Is sqlite still writing that file?

Seems like .taurignore doesn't fix the problem, am I do someting wrong?

I connect the db file in read-only mode: sqlite:./assets/xiv.db?mode=ro. Is sqlite still writing that file?

Not sure how sqlite databases work, maybe it still creates a lockfile or something?

But is it possible to only ignore the single .db file?

If assets/ works /assets/dbname.db or /assets/*.db should work too, if the .db file is the problem

Thank you, I think we absolutely need to let cli print some information when detecting file changes. It's so wired.

By using #5428, I find out the changed file is
        Info File C:\....\ffxiv-crafting-assistant\src-tauri\assets\xiv.db-shm changed!

But for .taurignore file, assets/, /assets/ works, but assets/*, /assets/*,  /assets/xiv.db-shm doesn't.


Add conformance echo-server code and image build (echo-basic)

What type of PR is this?

/kind test
/area conformance
What this PR does / why we need it:
Add codebase and image build step for echoserver image used in conformance tests. Prevent to update https://github.com/kubernetes-sigs/ingress-controller-conformance when we need to tweak base image for conformance.

add code from Ingress Controller Conformance Repo
update build-and-push.sh to also build this image
create Dockerfile.echo-basic
add go.work at root with reference to ./conformance/echo-basic
add delay support to echo-basic (one of the main reasons for this PR)
relates to #2445
discussed in #2254

Which issue(s) this PR fixes:

Fixes #2445
Does this PR introduce a user-facing change?:

NONE

@robscott @frankbu please take a look at this PR. We will also need a followup PR once the image is built, to update the images used in conformance tests.

@robscott @frankbu please take a look at this PR. We will also need a followup PR once the image is built, to update the images used in conformance tests.

@SRodi as soon as this merges, I can update #2254 to use it for one service, sort of a canary test 😃 If that works out, then we can do a followup PR to change the rest of the services to use the new image.

@SRodi as soon as this merges, I can update #2254 to use it for one service, sort of a canary test 😃 If that works out, then we can do a followup PR to change the rest of the services to use the new image.

@frankbu that sounds good. I will keep #2437 open (as a draft for now) so that I can proceed with the general image update once you confirm your "canary test" works.

Thanks @SRodi!
/lgtm
/approve


Make Draw Polyline Work On Chrome For Touch+Mouse Devices

When drawing PolyLine vertices in Chrome on a device that supports both touch and mouse inputs
- clicking the mouse would call both the touch and mouse events and create two vertices at once
- you would be unable to close the PolyLine shape while using the mouse
To fix draw polyline:

Store last time the mouse up handler fired
Check that more than 10ms have passed since the mouseUp handler fired when the onTouch handler tries to call it
This way if a mouse in a touch browser has already fired mouseUp, it won't fire again

Connects #548

@arottersman why was this closed?

@baikon - We decided to use our own fork for the project (https://github.com/azavea/Leaflet.draw)
Would be happy to reopen if anyone thinks this would be useful!

Cool! Is there anything else on this fork other than the updates on this pull request?

Yeah, the azavea fork is actual a fork of michaelguild13/Leaflet.draw, and in addition to the one fixing the touch device issue, there's a commit that makes the draw vertices big. You could cherrypick the Draw Polyline fix though

@arottersman just to be clear, this doesn't fix the touch event though does it? just makes it work with click?

@baikon We were having the issue described here: https://github.com/WikiWatershed/model-my-watershed/issues/1190 - where we could close polyline's on touch devices just fine, but if a device was running chrome and had touch and mouse capabilities, we couldn't close the shape with a mouse.
Do touch events not work for you?

@arottersman ah, it looks like my issue is when browser has both touch and mouse capabilities, the issue is repro'd where the initial touch or mouse event will fire two events so it actually enables the tool and then clicks the first vertex right away.

@arottersman i think the polyline tool will work with touch events if i can get this part sorted out. i need to complete the shape after counting how many vertexes were added to the map:
map.on('draw:drawvertex', function(e) {
      if (Object.keys(e.layers._layers).length > 1) {
        // need to close polyline here
      }
});

would you have any ideas or suggestions on how to do that?


Unable to run listOSPolicyAssignments in Google Cloud Function

I'm trying to consume the listOSPolicyAssignments API, and I consistently get the following error:
callListOSPolicyAssignments failure:  TypeError: Cannot read property 'apply' of undefined"
I'm using the code from sample provided in this git project (nodejs-os-config).
I thought it might be a permissions issue, but I was able to get the listVulnerabilityReportsAsync sample to run.

@johndbro1 Thanks for your report.
Can you provide a reproducible steps and files? It will help us understand the issue.
I briefly took a look at the documentation at:
https://cloud.google.com/compute/docs/os-configuration-management/manage-os-policy
It seems like OSPolicyAssignment Viewer (roles/osconfig.osPolicyAssignmentViewer) is required. Just in case, does your service account have this role?
Thanks,

Thank you for looking at this for me.
I can confirm that my service account has the OSPolicyAsignment Viewer.  I've also confirmed that I can access the listVulnerabilityReportAsync method and it returns the correct data.
I've attached my index.js and package.json (both as text files) for you.
Steps to reproduce:

Create a cloud function using the provided javascript code and packaging. Change the name of the project as appropriate
execute the cloud function using the 'test' button

Expected results: a list of os-config policies for the specified project and zone
Actual results: callListOSPolicyAssignments failure: TypeError: Cannot read property 'apply' of undefined"
index.js.txt
package.json.txt

Thanks! I'll try to reproduce.

I've successfully reproduced this issue, and reached out to the API team for further guidance.

Update: it seems that this is a generator issue. I've reached out to @alexander-fenster for help.


Fix ActiveRecord link

Thanks, but this one was already fixed with #121. :) It's not merged into master yet, but the next Pop release is in a few days.


Rename renderers

The d3 renderer doesn't actually require d3, and would more properly be called the svg renderer.  As part of renaming it, remove any dependencies that do exist on d3 (some features will still require d3, such as the color legend).
Do we also want to rename the vgl renderer to webgl or just gl?

@aashish24 Can you weigh in on whether we should rename the vgl renderer, and, if so, what it should be renamed to?
As part of renaming renderers, I propose we rename the src directories associated with them, too.

As a related topic, the dom renderer might alternately be called the ui renderer.  Within the dom renderer, we call things widgets.  For all other renderers, we call things features.  Should this terminology be changed (should everything be a feature, for instance)?  If we should change the terminology, we can do so in a separate issue.

rename to webgl


End a/b test on homepage

Ending A/B test on the homepage and replacing with the test winner - https://app.asana.com/0/654820789891907/1120659490583466
Left the support to implement and track a/b test in the future. We can use the user property testGroupNumberUS to implement a/b test for US users, or testGroupNumber for worldwide users, and use trackABResult to track the results in google analytics.

Yeah thats a good point, I was in double minds about removing everything, and specifically getHomePageTestGroup. But we might do some more a/b testing in a few weeks, so I left it there.


Ruby script execution fail (incompatible library version)

New Issue Checklist

[X] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I am trying to execute a ruby script from within my fastfile with the line
sh("ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/")
But the script fails. Any idea what the reason might be? (Sorry, i am not familiar with the whole ruby ecosystem)
By the way, thats the script i am trying to execute from within the fastlane process
https://github.com/cvknage/iOS-AcknowledgementGenerator
Complete output when running fastlane, including the stack trace and command used
[23:13:55]: -------------------------------------------------
[23:13:55]: --- Step: Verifying required fastlane version ---
[23:13:55]: -------------------------------------------------
[23:13:55]: fastlane version valid
[23:13:55]: ------------------------------
[23:13:55]: --- Step: default_platform ---
[23:13:55]: ------------------------------
[23:13:55]: Driving the lane 'ios beta' 🚀
[23:13:55]: -----------------------
[23:13:55]: --- Step: cocoapods ---
[23:13:55]: -----------------------
[23:13:55]: $ pod install
[23:13:58]: ▸ Analyzing dependencies
[23:13:58]: ▸ Downloading dependencies
[23:13:58]: ▸ Using Bolts (1.7.0)
[23:13:58]: ▸ Using Crashlytics (3.7.2)
[23:13:58]: ▸ Using DGActivityIndicatorView (2.0)
[23:13:58]: ▸ Using FBSDKCoreKit (4.13.1)
[23:13:58]: ▸ Using FBSDKLoginKit (4.13.1)
[23:13:58]: ▸ Using Fabric (1.6.7)
[23:13:58]: ▸ Using KissXML (5.0.3)
[23:13:58]: ▸ Using Mixpanel (2.9.9)
[23:13:58]: ▸ Using QBImagePickerController (3.4.0)
[23:13:58]: ▸ Using SimulatorStatusMagic (1.8)
[23:13:58]: ▸ Generating Pods project
[23:14:00]: ▸ Integrating client project
[23:14:00]: ▸ Sending stats
[23:14:00]: ▸ Pod installation complete! There are 9 dependencies from the Podfile and 10 total pods installed.
[23:14:00]: ------------------------------------------------------------------------------------------------------------------------------------
[23:14:00]: --- Step: ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/ ---
[23:14:00]: ------------------------------------------------------------------------------------------------------------------------------------
[23:14:00]: $ ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/
[23:14:01]: ▸ /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require': incompatible library version - /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml_ruby.bundle (fatal)
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
[23:14:01]: ▸ from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:8:in `rescue in <top (required)>'
[23:14:01]: ▸ from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:4:in `<top (required)>'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
[23:14:01]: ▸ from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbLibXMLParser.rb:3:in `<top (required)>'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
[23:14:01]: ▸ from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbCFPropertyList.rb:98:in `<top (required)>'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
[23:14:01]: ▸ from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/CFPropertyList.rb:3:in `<top (required)>'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
[23:14:01]: ▸ from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
[23:14:01]: ▸ from ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb:51:in `<main>'
[23:14:01]: Variable Dump:
[23:14:01]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios beta"}
[23:14:01]: Exit status of command 'ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/' was 1 instead of 0.
/usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require': incompatible library version - /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml_ruby.bundle (fatal)
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:8:in `rescue in <top (required)>'
	from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:4:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbLibXMLParser.rb:3:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbCFPropertyList.rb:98:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/CFPropertyList.rb:3:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb:51:in `<main>'

+------+---------------------------------------------------------------+-------------+
|                                  fastlane summary                                  |
+------+---------------------------------------------------------------+-------------+
| Step | Action                                                        | Time (in s) |
+------+---------------------------------------------------------------+-------------+
| 1    | Verifying required fastlane version                           | 0           |
| 2    | default_platform                                              | 0           |
| 3    | cocoapods                                                     | 4           |
| 4    | ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator. | 0           |
+------+---------------------------------------------------------------+-------------+

[23:14:01]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

[23:14:01]: Error finding relevant GitHub issues: undefined method `map' for nil:NilClass

[!] Exit status of command 'ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/' was 1 instead of 0.
/usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require': incompatible library version - /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml_ruby.bundle (fatal)
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:8:in `rescue in <top (required)>'
	from /Library/Ruby/Gems/2.0.0/gems/libxml-ruby-2.9.0/lib/libxml.rb:4:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbLibXMLParser.rb:3:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/cfpropertylist/rbCFPropertyList.rb:98:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /Library/Ruby/Gems/2.0.0/gems/CFPropertyList-2.3.2/lib/CFPropertyList.rb:3:in `<top (required)>'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
	from /usr/local/lib/fastlane_lib/bundle/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb:51:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# If you want to automatically update fastlane if a new version is available:
#update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.98.0"

default_platform :ios

platform :ios do
  before_all do
    cocoapods
  end

desc "Build and distribute build to Crashlytics"
  lane :beta do
    # Generate acknowledgements
    sh("ruby ../Beatsnap/Resources/Licenses/acknowledgementGenerator.rb Beatsnap/Settings.bundle/ Beatsnap/Resources/Licenses/")
  end

end

Environment
fastlane version (run fastlane -v):
fastlane 1.98.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
No

Hi @mlostekk It looks like you are using ruby 2.0 can you upgrade (using RVM) to 2.3? I want to see if you are still affected by this issue. Thanks!

Ah! Thanks, using RVM with ruby 2.3 fixed all issues! Thanks and keep up the awesome work!


Add HOST to API blueprint from API_DOMAIN

For apiary.io console tests it is required to fill the HOST variable with the API URL
As this is already defined in API_DOMAIN I think it would be useful for everyone using the doc feature
Thank you.

Sorry moved here https://github.com/dingo/blueprint/issues/17


Add property to specify the exact path for the PdfEngine

Resolve #63
This allows me to use a "portable" version of MikTex's pdflatex.exe.

thanks


To add table under section decimal/2421 convertor for better understanding

Is your feature request related to a problem? Please describe.
To add table under section decimal/2421 convertor for better understanding

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018

Go ahead
Deadline 10 May,2021


writing base language files to output as well

Coverage remained the same at 100.0% when pulling df6004920653611ec074b70d5914eeb748de4286 on dlockhart:include-primary-langs into be287f8dd8b3a91eab86225158a11cba50aeac49 on Brightspace:master.


networking.defaultGateway: add new option for preferred source address

Description of changes
This adds srcAddress option for cases when we have several ip addresses on a same interface and want to set one of them as preferable for outgoing connections. Works both for IPv4 and IPv6.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thank you for your contribution, sorry it took a while.

Please rename (& rebase) your commits according to the CONTRIBUTING guide.
Please add a release note in 23.05 mentioning this change.


Support eudplib type hints

Related issue: https://github.com/armoha/euddraft/issues/89
Type hints are keep added on eudplib, for example all trigger actions and conditions are all typed (mypy compliant)
Trigger Actions: https://github.com/armoha/eudplib/blob/master/eudplib/core/rawtrigger/stockact.py#L102-L762
Trigger Conditions: https://github.com/armoha/eudplib/blob/master/eudplib/core/rawtrigger/stockcond.py#L30-L312

Works on https://github.com/zuhanit/epscript-lsp/tree/support-eudplib-type-hints


New class Parameter. Added names for DNNLayer. Update optimizer. [WIP]

A new Parameter class has been created. Added names for DNNLayer. Names are included in the optimizer.py for GradientDescent. The necessary changes to the 'test_neural_net.py' have been made.

In the GradientDescent tests, I changed the number of layers and the test failed. Previously layers were with shape [n, n] and I changed to [m, n] (n != m). I will look at the transfer between the layers in more detail. It would be great if you also watched, maybe I missed something.

Good catch on the backpropagation error--it should be fixed in commit c89b07eb


Y24-276 - (Pre-MVP) Create stories for new scRNA Core PBMC pooling strategy

Description
https://github.com/sanger/limber/issues/1611 has been on hold while R&D were coming up with the PBMC pooling strategy for scRNA Core. Abby has now shared a draft strategy in the form of an Excel spreadsheet -
Phase 2 pooling, cell counting & chip loading approaches for PSD (2).xlsx
Acceptance Criteria:

[ ] Create & size stories to implement pooling strategy as described in the shared spreadsheet.
[ ] Document any remaining uncertainties.

Who the primary contacts are for this work
Katy, Abby

Could you confirm what is needed to be reviewed here?  Thanks.

I'm splitting this story to reflect the two stage approach that we've decided to do.
The outcome of this story is the following 5 stories to support the (pre-MVP) end to end pipeline test that R&D are doing:

https://github.com/sanger/limber/issues/1909
https://github.com/sanger/limber/issues/1914
https://github.com/sanger/limber/issues/1915
https://github.com/sanger/limber/issues/1779
https://github.com/sanger/sequencescape/issues/4337

The second half, which I will create a new story for, will be to develop whatever else is needed to create the MVP. I already have the draft stories in this google doc.


How do I use this?

How do I even use this lol

Maybe you shouldn't. Issues like this are definitely not going to get anybody anywhere.

bruh i just want to use thus


Update README and file structure

Add Table of Contents to README
Update file structure (move dict files to test/resources, etc.)

Thanks @rssdev10 for suggestions


Widow prevention setting nbsp between 2nd and 3rd to last words.

I would expect the   to be between the last and second to last word. Perhaps there's some configuration I could tweak? I've looked through the file but don't see anything.
Thanks for any help!

That's where it should be, yes. There are a number of config settings related to Widows that you can tweak:
https://github.com/nystudio107/craft-typogrify/blob/v1/src/config.php#L165

Hm, I didn't change any settings but the nbsp was in the second to last gap not the last. Site-wide. I will investigate further.


ForcedClusterUpgrade feature do not work as expected?

Hi folks!
I'm going to upgrade the RayCluster.
I found that in order to update RayHead pod by rayoperator we should specify --forced-cluster-upgrade arg in ray-operator manager.
Now it become try to update RayHead pod but it stuck in ininfinite reconcile loop, because the head pod contains several containers [ray-head, autoscaler].
the next line of code return true every time when we try to compare autoscaler container, because this container not listed in HeadGroupSpec.Template.Spec.Containers. autoscaler container generated by autoscaler options by RayCluster.
https://github.com/ray-project/kuberay/blob/197fcc225a5507d944fee270ffe671f8d9b9d8ce/ray-operator/controllers/ray/utils/util.go#L395
Since the number of containers in template and actual pod will be allways different it lead to infinite loop delete head pod -> create new -> compare -> delete head pod.
Is it a bug or such upgrade operation should be covered in some other way?
What workaround can i use?
Thanks in advance!

Thank you for reporting this issue! I will recommend you not use ForcedClusterUpgrade. This feature is totally maintained by the Ray maintainers and is fully maintained by the community. The Ray does not natively support rolling upgrades, and it must have a lot of friction between Ray and ForcedClusterUpgrade.
If you require no downtime in your cluster, consider checking out RayService, which supports zero-downtime upgrades for serving, and RayJob for other workloads.

Deprecate ForcedClusterUpgrade. We should use suspend instead.
https://github.com/ray-project/kuberay/pull/2075


pythonPackages.nbsphinx: init at 0.4.2

Motivation for this change
Need for a project where we would like to embed jupyter notebooks in sphinx output. Needed to upgrade nbconvert.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2Packages.nbsphinx python3Packages.nbsphinx

@GrahamcOfBorg build python2Packages.nbsphinx python3Packages.nbsphinx


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: CharanBR sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


php - incorrect data dependency

When I do inter-procedural taint analysis on PHP code, I find that there are data dependencies that seemed incorrect. The PHP code is shown below.
<?php
function getString() {
    return "111";
}
function runShell($cmd) {
    system($cmd);
}
$str = getString();
runShell($str);
?>

The system function in the function runShell is dependent on the argument $cmd. But the PDG generated by joern does not seem to reflect this dependency.
digraph "runShell" {
"17" [label = <(METHOD,runShell)7> ]
"20" [label = <(METHOD_RETURN,ANY)7> ]
"4" [label = <(PARAM,$cmd)7> ]
"19" [label = <(system,system($cmd))8> ]
  "19" -> "20"  [ label = "DDG: $cmd"]
  "19" -> "20"  [ label = "DDG: system($cmd)"]
  "17" -> "4"  [ label = "DDG: "]
  "17" -> "19"  [ label = "DDG: "]
}

This incorrect data dependency led to inter-procedural taint analysis fail.
When I use joern to parse similar C code, joern can produce the correct data dependencies
#include <stdio.h>

char *getString() {
    return "111";
}

void runShell(char *cmd) {
    system(cmd);
}

int main() {
    char *str = getString();
    runShell(str);
}

digraph "runShell" {
"13" [label = <(METHOD,runShell)7> ]
"18" [label = <(METHOD_RETURN,void)7> ]
"14" [label = <(PARAM,char *cmd)7> ]
"16" [label = <(system,system(cmd))8> ]
  "16" -> "18"  [ label = "DDG: cmd"]
  "16" -> "18"  [ label = "DDG: system(cmd)"]
  "13" -> "14"  [ label = "DDG: "]
  "14" -> "16"  [ label = "DDG: cmd"]
  "13" -> "16"  [ label = "DDG: "]
}

The problem seems to be related to the $ in front of the PHP variable name.
When building the data dependency graph, the reach definition analysis is completed. The result(I get it by debugging) of the runShell function analysis is that, the runShell argument $cmd can reach the identifier $cmd and identifier $cmd can then reach the system function call. So the result of reach definition analysis is correct.
the result is then used to construct a UsageAnalyzer object:
  // class ReachingDefPass
  val problem = ReachingDefProblem.create(method)
  ...
  val solution = new DataFlowSolver().calculateMopSolutionForwards(problem)
  val ddgGenerator = new DdgGenerator(s)
  ddgGenerator.addReachingDefEdges(dstGraph, method, problem, solution)

  def addReachingDefEdges(
    dstGraph: DiffGraphBuilder,
    method: Method,
    problem: DataFlowProblem[StoredNode, mutable.BitSet],
    solution: Solution[StoredNode, mutable.BitSet]
  ): Unit = {
    implicit val implicitDst: DiffGraphBuilder = dstGraph

    val numberToNode = problem.flowGraph.asInstanceOf[ReachingDefFlowGraph].numberToNode
    val in           = solution.in
    val gen          = solution.problem.transferFunction.asInstanceOf[ReachingDefTransferFunction].gen

    val allNodes      = in.keys.toList
    val usageAnalyzer = new UsageAnalyzer(problem, in) // here

This class seems to be used to filter reach definition that really used by current node:
private class UsageAnalyzer(
  problem: DataFlowProblem[StoredNode, mutable.BitSet],
  in: Map[StoredNode, Set[Definition]]
) {

  val numberToNode: Map[Definition, StoredNode] = problem.flowGraph.asInstanceOf[ReachingDefFlowGraph].numberToNode

  private val allNodes             = in.keys.toList
  private val containerSet         = Set(Operators.fieldAccess, Operators.indexAccess, Operators.indirectIndexAccess)
  private val indirectionAccessSet = Set(Operators.addressOf, Operators.indirection)
  val usedIncomingDefs: Map[StoredNode, Map[StoredNode, Set[Definition]]] = initUsedIncomingDefs()

  def initUsedIncomingDefs(): Map[StoredNode, Map[StoredNode, Set[Definition]]] = {
    allNodes.map { node =>
      node -> usedIncomingDefsForNode(node)
    }.toMap
  }

  private def usedIncomingDefsForNode(node: StoredNode): Map[StoredNode, Set[Definition]] = {
    uses(node).map { use =>
      use -> in(node).filter { inElement =>
        val inElemNode = numberToNode(inElement)
        isUsing(use, inElemNode)
      }
    }.toMap
  }

  def isUsing(use: StoredNode, inElemNode: StoredNode): Boolean =
    sameVariable(use, inElemNode) || isContainer(use, inElemNode) || isPart(use, inElemNode) || isAlias(use, inElemNode)

  private def sameVariable(use: StoredNode, inElement: StoredNode): Boolean = {
    val res = inElement match {
      case param: MethodParameterIn =>
        nodeToString(use).contains(param.name)
      case call: Call if indirectionAccessSet.contains(call.name) =>
        call.argumentOption(1).exists(x => nodeToString(use).contains(x.code))
      case call: Call =>
        nodeToString(use).contains(call.code)
      case identifier: Identifier => nodeToString(use).contains(identifier.code)
      case _                      => false
    }
    res
  }

This class uses sameVariable method to compare whether the argument of function call is the same as the variable that reaches. This method uses nodeToString function to convert node to a string and then compares it with the name of the arriving variable. The left-hand side of contains is "$XXX", and the right-hand side of contains is "XXX"(no $), which is obviously not equal. So the reach definition of argument of runShell is filtered out

I remove the code related to "$" in php2cpg/astcreation/AstCreator.scala and the PDG of runShell is correct:
digraph "runShell" {
"17" [label = <(METHOD,runShell)7> ]
"20" [label = <(METHOD_RETURN,ANY)7> ]
"4" [label = <(PARAM,cmd)7> ]
"19" [label = <(system,system(cmd))8> ]
  "19" -> "20"  [ label = "DDG: cmd"]
  "19" -> "20"  [ label = "DDG: system(cmd)"]
  "17" -> "4"  [ label = "DDG: "]
  "4" -> "19"  [ label = "DDG: cmd"]
  "17" -> "19"  [ label = "DDG: "]
}
"""

@johannescoetzee Excuse me, is there any progress on this issue?

It seems that there is still this issue in the latest version, is there any plan to fix this issue @johannescoetzee


Including Jade Filters

Im not sure this ticket belongs here, sorry if not's the case.
How can I use Jade filters? Im trying to use a markdown filter and i always get:
In order to apply the transform markdown you must install one of "marked","supermarked","markdown-js","markdown"
Warning: Jade failed to compile src/index.jade. Use --force to continue.

Thanks @tkellen, works here! :+1:


Wrong exchange rate used for US sales when "Lateinamerika und Karibik (USD)" is present in currency data file

When there is a row for "Lateinamerika und Karibik (USD)", the wrong exchange rate is used for "Nord- und Südamerika (USD)".
You already handle that USD can appear twice in currency data, but in fact it can occur three times when there were sales in Latin America and the Caribbean.
This code would need to be changed to account for this:
https://github.com/no-comment/plutus-financial-slicer/blob/b2eb5a891fdc4e3f42ddac3c59c8331327e83855/Sources/PlutusFinancialReportSlicer/PlutusFinancialReportSlicer.swift#L81-L92
Here are three example lines from a German currency data .csv file:
"Rest der Welt (USD)","3","26.37","26.37","0","0","0","26.37","0.92074","24.28","EUR",
"Lateinamerika und Karibik (USD)","2","19.53","19.53","0","0","0","19.53","0.92063","17.98","EUR",
"Nord- und Südamerika (USD)","253","2381.72","2381.72","0","0","0","2381.72","0.92080","2193.09","EUR",

In this case I had USD sales in Dominican Republic (DO) and Nicaragua (NI).
When importing this file, the exchange rate 0.92063 is used for Apple Inc. sales instead of the 0.92080 exchange rate, resulting in wrong invoice totals for US sales.
Thanks for the great tool!

Thank you so much for reporting this!

Hi there, please consider reporting issues like this upstream as well :)


Error: [NVM MGR]	failed to open nvm file

When I ran this project, I found the project report the error. I use the root account, and run sh ycsb.sh.
Caused by:
process didn't exit successfully: /home/xx/Falcon/target/release/deps/n2db-d18d0518254f145d ycsb_test_sync --nocapture (exit status: 255)

There are 3 NVM files here, NBTree, Dash and Falcon, which NVM file can not open and is the path correct?

After I run ycsb.sh with root, it shows:
running 1 test
creating a new pool
pool opened at: 0x5f0000000000
/mnt/pmem0/pmem_btree.data
[NVM MGR]	failed to open nvm file
error: test failed, to rerun pass --lib

After I run ycsb.sh with root, it shows:
running 1 test
creating a new pool
pool opened at: 0x5f0000000000
/mnt/pmem0/pmem_btree.data
[NVM MGR]	failed to open nvm file
error: test failed, to rerun pass --lib

It seems to be a problem with NBTree. It may be necessary to create the file in advance.
I don't have an experimental environment at the moment, I'll try it later. You can use "printf("errno=%d\n",errno);" on NBTree/tree/src/btree.cpp line 52 for more detail

When I create the file in advance, I can open the file. However, I still run this project. Seems to be a problem with NBtree.
The problem  is following:
thread 'main' panicked at 'called Result::unwrap() on an Err value: IO(Os { code: 21, kind: IsADirectory, message: "Is a directory" })', src/storage/nvm_file.rs:96:62
stack backtrace:
0: rust_begin_unwind
at /rustc/d9c13cd4531649c2028a8384cb4d4e54f985380e/library/std/src/panicking.rs:593:5
1: core::panicking::panic_fmt
at /rustc/d9c13cd4531649c2028a8384cb4d4e54f985380e/library/core/src/panicking.rs:67:14
2: core::result::unwrap_failed
at /rustc/d9c13cd4531649c2028a8384cb4d4e54f985380e/library/core/src/result.rs:1651:5
3: core::result::Result<T,E>::unwrap
at /rustc/d9c13cd4531649c2028a8384cb4d4e54f985380e/library/core/src/result.rs:1076:23
4: n2db::storage::nvm_file::NVMTableStorage::init_test_database
at ./src/storage/nvm_file.rs:96:27
5: n2db::test_nbtree
at ./src/main.rs:58:5
6: n2db::main
at ./src/main.rs:120:5
7: core::ops::function::FnOnce::call_once
at /rustc/d9c13cd4531649c2028a8384cb4d4e54f985380e/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.

It reports that "Is a directory". Is the path on src/customer_config.rs(line3)  is a directory? It should be the path of a file in NVM

I run this project successfully.  This is a very good project and worthwhile for people on the topic of OLTP transactions on NVM.
I suggest you modify README.md to make it easier for the programmer behind you to run it directly. The subprojects of a project cannot be downloaded automatically via git pull --recurse-submodules. The pmem_btree.data file needs to be created manually. The other can be created automatically.
Thank you.


[CMT-847-1200] Bug: blog layout is broken for mobile

The mobile layout needs some work.
Landscape is alright, but needs improvement, and portrait is unreadable.
tested on firefox android, brave android

@Major-Eth reminder check homepage mobile

I got it fixed on a branch https://github.com/yearn/yearn-comms/compare/english...MarcoWorms:english but I saw that Major made a PR for this already so I didn't open another one :)
I think this issue should be closed then?


Namespace for a function call

Hello,
I could very well be doing something wrong, but I'm trying to access a third party SOAP API that has a namespace for their functions.
<soapenv:Envelope ...>
   <soapenv:Header/>
   <soapenv:Body>
      <impl:getPricing>
      </impl:getPricing>
   </soapenv:Body>
</soapenv:Envelope>

I'm having trouble figuring out how to add the "impl:" before "getPricing".  Any assistance would be much appreciated!
Thanks,
Darryl

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Here's my hack to deal with the namespace, pass the ignoredNamespaces the soap.createClient options.
{
"ignoredNamespaces": {
namespaces: [ns']
},
}
And then add the namespace manually. It's ugly, but it works.
{
...
"impl:getPricing": "foobar"
...
}

@geoffreyburdett - thankyou! I don't suppose you worked out how to add an additional namespace to the Soap Envelope as well, did you?....

Have a look at https://github.com/vpulim/node-soap/issues/672 its a bit of a hack but you can add an additional namespace.

@geoffreyburdett can you give a better example? How can I add the namespace manually?

Add the namespace to the property key
{"impl:getPricing": "foobar"}

1


Escape-hatch for an entirely declarative configuration

I understand that the project's philosophy as such is to provide LSP whenever possible and having everything setup automagically for you. But I still believe that having an escape-hatch to have an entirely declrative would be extremely useful.
My use case is: I have an NixOS setup and I have all my lsps declared on home-manager's configuration plus I setted up all lsps through lspconfig, but the thing is, this seems cumbersome, it would be better to have a single declarative source of truth, and lazy-lsp could provide that if this was possible. Also, on my work's desktop I still need to figure out how to do a proper home-manager configuration, and if I could atleast have the lsps setup on my neovim configuration through lazy-lsp it would already ease the pain of not needing to worry about that as of now.

I don't think I understand, what is the concrete issue and is there anything the plugin could do differently to enable the use case?

I just think it would be interesting to have a disable_automatic_installssetting. Such that the only lsps that are going to be installed and enabled must be on  the preferred_servers setting.

I see now. This is indeed a bit outside of the plugin philosophy. Given the servers are not installed upfront but only lazily when a given type of file is opened, I am not convinced to add additional complexity by having an extra option for this.


tableRow can not choose, if using setState in onRowSelection

Problem Description

Versions

Material-UI:
React:
Browser:

Hi,
I have exactly the same issue :-1:

The issue description here is a real winner.

For my problem I talk about a graphical select row bug if there is a setState in onRowSelected in Table.
The problem from my code ?

I'm in the same issue :(

i think mui V15 has this issue, mui V14.0.4 is right.

Is there a solution to this problem? if i call setState in onRowSelected it stops from showing me selected rows with highlight but row numbers appear in console correctly. (this state setting shouldnt couse rerendering , i jast pass it to another component) Thanks.

I have the same problem. Why is this closed? In my case the selection updates state which should update another component. The selection never is visualized in the table.

It seems that the bug has been fixed in the latest version .I solved this problem by  'npm install material-ui'

this is still broken in 0.18.1

there is an issue with material-ui's table "forgetting" its checked status each render.
to overcome this problem you can specifically set the checked state in the map function like so:
            <TableRow key={index}
              selected={this.state.selectedRows.indexOf(index) !== -1}>
            </TableRow>

now that you maintain the checked status yourself you should have something like
  onRowSelection(selectedRows) {
    this.setState({ selectedRows });
  }

and
      <Table
        onRowSelection={this.onRowSelection}

and
  constructor(props) {
    super(props);
    this.onRowSelection = this.onRowSelection.bind(this);
  }


num_checkpoints_to_keep of CheckpointSaver doesn't work when the training is resumed

** Environment **
PyTorch information
PyTorch version: 1.13.1+cu117
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A
OS: Ubuntu 18.04.6 LTS (x86_64)
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
Clang version: 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
CMake version: version 3.10.2
Libc version: glibc-2.27
Python version: 3.8.3 (default, Jul  2 2020, 16:21:59)  [GCC 7.3.0] (64-bit runtime)
Python platform: Linux-5.4.0-131-generic-x86_64-with-glibc2.10
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: Quadro RTX 6000
Nvidia driver version: 470.141.03
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
Versions of relevant libraries:
[pip3] numpy==1.22.4
[pip3] pytorch-ranger==0.1.1
[pip3] torch==1.13.1
[pip3] torch-optimizer==0.3.0
[pip3] torchmetrics==0.11.3
[pip3] torchvision==0.14.1
[conda] Could not collect
Composer information
Composer version: 0.13.2
Composer commit hash: None
Host processor model name: Intel(R) Xeon(R) Silver 4210 CPU @ 2.20GHz
Host processor core count: 20
Number of nodes: 1
Accelerator model name: Quadro RTX 6000
Accelerators per node: 1
CUDA Device Count: 1
** To reproduce
Steps to reproduce the behavior:

Set num_checkpoints_to_keep=1 in the CheckpointSaver callback instance
Start the training. On the second epoch, stop the training. Then resume again from the saved checkpoint
After the second epoch finishes, checkpoints from both the first and second epochs are in the checkpoint folder. But only the last epoch checkpoint should be there because num_checkpoints_to_keep=1.

Expected behavior
Only the checkpoints of the last num_checkpoints_to_keep epochs should be in the checkpoint folder.

Additional context
CheckpointSaver._rotate_checkpoints() needs self.saved_checkpoints to work, but self.saved_checkpoints is not saved into the checkpoint file, so when the training resumes the self.saved_checkpoints is empty again. I think self.saved_checkpoints needs to be saved into the checkpoint, it can reload self.saved_checkpoints when training resumes.

@RolandGao I believe the intention with num_checkpoints_to_keep was to be set per run. The reasoning here was that if a run is resumed, we don't want to delete previous checkpoints since they are not "owned" by the active run and might lead to confusing user behavior. In short, we tend to defer to being less aggressive when deleting checkpoints because accidentally deleting a checkpoint is a very bad outcome.
With that said, would you mind elaborating on your use case? Maybe there's a better design that can satisfy what you are doing as well.

I see your point. It would be bad to lose a checkpoint one wants.
I train my models on a slurm server that often preempts and requeues my jobs, so I use MosaicML's autoresume feature. My disk space is limited, so I set num_checkpoints_to_keep=1. When a job finish, I would often realize that there are 10 checkpoints, probably because the job got preempted and requeued 10 times. This costs 10 times as much storage space, so I would have to manually delete previous checkpoints when I'm super low on disk space.

Hm... I see.
Here is one suggestion: You can write a callback which runs on Event.AFTER_LOAD. In this callback, I would just delete everything inside save_folder -- it will essentially purge all run data

Hm... I see. In this case, I would recommend adding your own callback that deletes an older checkpoint whenever a newer version gets written for now. In the mean time, we'll see if there's a better way to support this on our end, possibly with a flag.

Thanks! I will try writing a callback myself.