Add more callback functions

I request to add more callback functions in the mob defintions. self is always the ObjectRef of the mob in question.

[x] on_punch(self, puncher, time_from_last_punch, tool_capabilities, dir): Same as for registered entities.
[X] on_replace(self, pos, oldnode, newnode): When the mob is about to replace oldnode at pos. oldnode is the current node, newnode is the node to set in place of the current node. If the the callback returns with false, the the node is not replaced
[x] on_breed(self, parents): Called when a child mob has just been created by breeding. parents is the table of its parents
[x] on_grow_up(self): Called when a child becomes an adult, either by growh or feeding

Example use cases:

on_punch: Teleport away after attack
on_replace: Sheep: Regrow wool after eating grass. Cow: Moo after eating grass
on_breed: Customizing the child after birth, e.g. mix stats, textures, size, etc., based on the parent's “genome”

Added above functions with changed, on_breed(parent1, parent2)

Thank you very much!


FORCEAPPSHUTDOWN process list

It would be useful to have a list of what executables FORCEAPPSHUTDOWN looks for/closes. There are times (e.g. deploying Visio/Project to existing installs via ConfigMgr) when it's better to have leave FORCEAPPSHUTDOWN=false and prompt the user to close conflicting apps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95a0b1ff-0498-505a-6024-b813980d310f
Version Independent ID: b8057930-b4bd-1304-17ce-5561f837e901
Content: Configuration options for the Office Deployment Tool - Deploy Office
Content Source: DeployOffice/office-deployment-tool-configuration-options.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Add support for Intel Z170 chipset to sdiahci.c

Seems to have difficulty with one of the ports, causing it to hang.  Not sure why at this point, but if you skip it, it boots.
Signed-off-by: Graham MacDonald<EMAIL_ADDRESS>

The easiest thing to do is another commit with clang-format. I think we should do that with the whole code base, personally.

It hangs in ahciidle for port 5.  This happens during boot, when calling iapnp in sdiahci (which then calls newctlr, then achiidle).  It tries to dereference port->cmd as so: if((*p & Arun) == 0)

There shouldn't be anything to unusual about the hardware, other than it's more recent than the code.

@rminnich we have .clang-format at the root of the repo but it breaks the coding convention.
the specific issue was pointer alignment. consider the trivial example here
Exectab*
lookup(Rune *r, int n) {
  return 0;
}

clang format unfortunately will format the pointer either to left
Exectab*
lookup(Rune* r, int n) {
  return 0;
}

right:
Exectab *
lookup(Rune *r, int n) {
  return 0;
}

or everyone's favorite middle :shrug:
Exectab *
lookup(Rune *r, int n) {
  return 0;
}

Last time I tried to make clang-format a required check, that's where it fell apart.
And it wasn't even a stylistic issue, it just broke semantics. @dancrossnyc explained why left aligned pointers are evil
Having said that, while it might break the semantics, it enforces style consistency. Which we're not doing great on :/
For instance
right aligned: https://github.com/Harvey-OS/harvey/blob/main/sys/src/9/amd64/apic.c#L163
left aligned: https://github.com/Harvey-OS/harvey/blob/main/sys/src/9/amd64/apic.c#L192
so it ended up that the :smiling_imp: left aligned pointers made their way in anyways.
Anyways maybe we should take a page from the go book, pick a style and live with it.  We can start by enabling a required check only for the lines that have been edited.  What do you think?

Tidied code and comment.  As mentioned, I think the AHCI port 5 issue is a separate issue to the identification of the motherboard, so can be handled separately.

take a page from the go book, pick a style, and live with it. Accept it will never have perfect results. Accept that.
Let's just do it.


[feature request] Adding boolean query method

The existing boolean query feature could be done from the index.parse_query, as long as we type the correct characters like +, - for must and must_not respectively.
However, there could be cases that users would like to create their inner query dynamically, or for the sake readability that they would like a container for their other query types like FuzzyTermQuery and PhraseQuery.
Currently the rust tantivy package allows creating the boolean query from the Struct tantivy::query::BooleanQuery. Will tantivy-py also have the boolean_query staticmethod for the Query class?

However, there could be cases that users would like to create their inner query dynamically, or for the sake readability that they would like a container for their other query types like FuzzyTermQuery and PhraseQuery.

I agree with you that parse_query covers a lot of ground, using the tantivy query language. With my maintainer hat on, I see that as less code in tantivy-py, compared to adding extra explicity query types.  However, the request does come up a fair bit and so I was wondering whether you could describe a specific use case here?

Sure, let's use a common ground for easier discussion, consider the following elasticsearch query:
{
    "query": {
        "bool": {
            "must": [
                {
                    "dis_max": {
                        "queries": [
                            {
                                "match": {
                                    "title": {
                                        "query": "sea whale",
                                        "boost": 2
                                    }
                                }
                            },
                            {
                                "match": {
                                    "body": {
                                        "query": "white dog",
                                        "boost": 1.5
                                    }
                                }
                            }
                        ],
                        "tie_breaker": 0.3
                    }
                }
            ]
        }
    }
}

The current parse_query method is impossible to construct this query as the tantivy query language currently cannot parse other query types say regex or disjunction max queries. However, this functionality is available in Rust's BooleanQuery and PyLucene's equivalent method.
For tantivy-py's case, we might consider the following function signature:
class Query:
    ...
    @staticmethod
    def boolean_query(subqueries: Iterator[tuple[Occur, Query]]) -> Query:
        ...

This requires the introduction of Occur enum in tantivy rust package.
The above elasticsearch syntax can be then transformed to:
Query.boolean_query(
    [
        (
            Occur.MUST,
            Query.dis_max_query(
                [
                    Query.phrase_query("title", "sea whale", boost=2),
                    Query.phrase_query("body", "white dog", boost=1.5)
                ],
                tie_breaker=0.3
            )
        )
    ]
)

which providers 3 benefits to developers:

Easier syntax (compared to tantivy's query language and even elasticsearch) and better maintainability.
Easier unit-testing the syntax as we are building the query block by block, instead of crumbling them into a single query string.
Enable other currently not-supported query types in tantivy's query language, e.g. ConstScoreQuery, DisjunctionMaxQuery, ExistsQuery.

Thanks for taking the time to write it out. You've explained it well 👍🏼
We are currently tracking progress on wrapping these query types in this comment in #20. I see BooleanQuery is already there along with the disjunction max and the regex query.

Added pull request for the implementation #243

PR has been merged, thanks!


net/url: Request with %2F is not transmitted correctly

go version 1.4.2, Linux x64
When trying to form an URL with escaped "/" (%2F) the handling in net/url either removes the escaping or does double escaping (in which case the requested URL is wrong).
http://play.golang.org/p/1vDHT_p-cZ
The same issue of course makes calling the http.NewRequest also impossible as the given URL is not honored (escaped characters are removed, since the method calls url.Parse) and the wrong URL is called on the other end.
Expected result: QueryEscaped URL should not be modified. Has resemblance to issue #2782

Please see http://golang.org/pkg/net/url/#URL
Note that the Path field is stored in decoded form: /%47%6f%2f becomes
/Go/. A consequence is that it is impossible to tell which slashes in the
Path were slashes in the raw URL and which were %2f. This distinction is
rarely important, but when it is a client must use other routines to parse
the raw URL or construct the parsed URL. For example, an HTTP server can
consult req.RequestURI, and an HTTP client can use URL{Host: "example.com",
Opaque: "//example.com/Go%2F"} instead of URL{Host: "example.com", Path:
"/Go/"}.


Bump spec version to v0.8.0

This change bumps the CDI Spec version to v0.8.0.
There were no spec-specific changes in the spec, but the version is being bumped due to there removal of the .ToOCI() functions from the spec types.

cc @bart0sh


Images are not processed

After the latest update (1.1.0), I keep retrieving the same exception while trying to use the package. The exception is:
TypeError: Cannot read property 'slice' of undefined
    at getMIMEType (/srv/app/node_modules/gulp-jimp-wrapper/dist/index.js:25:51)
    at Transform.through__default.default.obj [as _transform] (/srv/app/node_modules/gulp-jimp-wrapper/dist/index.js:62:24)
    at Transform._read (/srv/app/node_modules/gulp-jimp-wrapper/node_modules/readable-stream/lib/_stream_transform.js:177:10)
    at Transform._write (/srv/app/node_modules/gulp-jimp-wrapper/node_modules/readable-stream/lib/_stream_transform.js:164:83)
    at doWrite (/srv/app/node_modules/gulp-jimp-wrapper/node_modules/readable-stream/lib/_stream_writable.js:409:139)
    at writeOrBuffer (/srv/app/node_modules/gulp-jimp-wrapper/node_modules/readable-stream/lib/_stream_writable.js:398:5)
    at Transform.Writable.write (/srv/app/node_modules/gulp-jimp-wrapper/node_modules/readable-stream/lib/_stream_writable.js:307:11)
    at write (/srv/app/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:623:24)
    at flow (/srv/app/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:632:7)
    at DestroyableTransform.pipeOnReadable (/srv/app/node_modules/vinyl-fs/node_modules/readable-stream/lib/_stream_readable.js:664:5)

And I am using the package like this:
return gulp.src(imagesConfig.source)
                .pipe(function (image) {
                    image.resize(size.width, size.height);
                    image.crop(crop.x, crop.y, crop.width, crop.height);

                    return image;
                })
                .pipe(gulp.dest(imagesConfig.destination));

Is there any solution for me in this situation?

slice() is called when getting the MIME type of the image.
const getMIMEType = img => MIME_TYPES[img.extname.slice(1).toLowerCase()]

It seems the property extname is somehow undefined in the Vinyl instance.
Can you provide some examples of your imagesConfig.source?


FIPS support for RabbitMQ

When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode.
This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO 1.
Jira: #OSPRH-4668
Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/448

/test rdoproject.org/github-check

recheck

ci failure test_live_block_migration_with_attached_volume  is unrelated to this change

/override rdoproject.org/github-check


fix(default-flatpaks): Install/uninstall system flatpaks regardless i…

…f current user has permissions or not
Fixes: https://github.com/ublue-os/bling/pull/93
To make notify-send working for --system systemd units, I have to thank @gerblesh for his code & idea in ublue-updater.
I tested this in Silverblue & it works.
However, I would like this to be tested in other DEs like Kinoite too, to see if it's working correctly.
Feel free to improve code if you find some space for that.
@lorduskordus

Great news, notify-send works in KDE too!
I believe there is nothing else to do here, I think this can be merged.


Rearranging the format of the "Add Event" Form

Please provide a summary of the feature
The form could use some behavior fixes. Wonjae, Rhyse, and I brainstormed some ways to re-arrange the form to make it more user-friendly.
Here's our idea for the new form layout:
Note: "--------------" represents space between elements
FIRST PAGE: The descriptive info for the event

Title
Description
Location
Discord Username
Back Button ------------ Next Button

SECOND PAGE: The date, time, and recurrence info for the event

Recurring radio selector with "Daily, Weekly, and Monthly" options
Another checkbox for days of week if a weekly recurrence is selected
Start Date -------------- Start Time
End Date --------------- End Time
Back Button ------------ Next Button

(Note: End date is set equal to start date's value if the event is not recurring)
THIRD PAGE: A page with all the event data displayed for the user to check. The user can go back if they want to change the data.

Back Button                - SUBMIT button

*** Please let us know if you have any feedback for this layout! ***
Are there any potential issues you foresee with this feature
This could create some merge errors with some of the other issues regarding the Add Event Form, e.g. Issue #157
It would be good to collaborate with @MatthewBozin and whoever has "(=☉ᆽ☉=)✧" as a Discord username to make sure our branches won't collide to hard.
Is this feature related to any current or past issues? Please provide the
This issue was brainstormed while working on Issue #153
Additional context
Add any other context or screenshots about the feature request here.
Which Branch should this fix be Pulled into?
PR into development (I think?)
If you're interested in working on this feature, please comment so you can be assigned

Quick update the end the year out. I went ahead and did a basic rearranging of the forms fields per the given design. I did this in order to line up with the soft security code for Issue #153. The event form team plans to complete the rest of the listed functionality at a later time.

Quick update the end the year out. I went ahead and did a basic rearranging of the forms fields per the given design. I did this in order to line up with the soft security code for Issue #153. The event form team plans to complete the rest of the listed functionality at a later time.


Fix apply function

closes #9234
I've locally updated the test for epochs.apply_function() and I'm a bit surprised / wondering if there's another bug in there.  Marking as draft until I've figured it out one way or another.  It seems like when applied channel-wise it gets applied to an ndarray that is (n_epochs, n_times) and it's not clear to me that that's the right thing to do (maybe it should really be epoch-wise and channel-wise?)
cc @nordme and @vpeterson

FYI for @vpeterson and @nordme: after a dev discussion on Discord, it was decided to change the behavior here.  What you implemented for epochs.apply_function(..., channel_wise=True) would pass an n_epochs × n_times array to the applied function.  What I've now implemented will pass only a 1-D time series (one channel within 1 epoch) to the applied function.

Thanks @drammock !


Kicked out Neighbors

Describe the bug
Node is up since 2 Days with one static neighbor. After adding a second one, it kicked out the first, and dont added the second.
Now i just have autopeered neighbors since 30 minutes.
After a restart, the first neighbor was instant peered, and could catch up very fast :-) But at his side i was not showing in his dashboard with my dns anymore, but with my ip.
The second neighbor did not connect to me, was just waiting at both sides. Waited for another 10 minutes (not helped).
He restarted, then we was instant peered. But at my side he showed not with his dns, but with his ip.
From the fist neighbor:
connected with IPHERE [alias: Snoopy007] [feature set(s): Chrysalis-Pt1]
Peering        error EOF
To Reproduce
Steps to reproduce the behavior:

Added a second neighbor at high tps (600-900)

Update a day later:
Current 200tps, both static neighbors was kicked out.
Restarted my node.
Both neighbors was on waiting. Tried to re-add a neighbor, dont helped.
On my neighbors side i showed as "not connected".... He restarted his node.
After this, on his side: connected with (IPHERE) [alias: Snoopy007] [feature set(s): Chrysalis-Pt1] error EOF error failed to send message: write tcp (IPHERE)->(IPHERE): write: broken pipe
On my side: INFO Peering handshaking with incoming connection from (IPHERE) WARN Peering error (IPHERE): peer is already connected
But we where connected and synct. On my side he showed again not via his added dns in the config, but with his ip.
Environment information:

OS: Windows 10
RAM: 32GB
Cores: 6 Cores
Type: 8700K @5.1GHz
Browser Brave
HORNET version: Version 0.5.0-rc13

The error described above leads to (static) neighbors without a static IP address permanently losing the connection when changing the IP every day. The DNS entry in peering.json is not used.

The "waiting" bug should be fixed with #650
The other bug is that incoming connections are only shown by their IP, but not their DNS entry. I will investigate.

Thx for your help!
Node alias should be correctly shown now with #650
Please open a new ticket if still something goes wrong.


Compatibility issues with Optifine

When FlatColoredBlocks and Optifine run together error occurse on main menu, and console filled with
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: java.lang.reflect.InvocationTargetException
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at java.lang.reflect.Method.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at Reflector.callVoid(Reflector.java:336)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1399)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1076)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.client.main.Main.main(SourceFile:124)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at java.lang.reflect.Method.invoke(Unknown Source)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
[22:43:10] [Client thread/INFO]: [Reflector:handleException:914]: 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
[22:43:10] [Client thread/INFO]: [java.lang.Throwable:printStackTrace:-1]: Caused by: java.lang.NoClassDefFoundError: com/mojang/realmsclient/gui/ChatFormatting
[22:43:10] [Client thread/INFO]: [java.lang.Throwable:printStackTrace:-1]: 	at mod.flatcoloredblocks.gui.GuiScreenStartup.func_73863_a(GuiScreenStartup.java:53)
[22:43:10] [Client thread/INFO]: [java.lang.Throwable:printStackTrace:-1]: 	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:382)
[22:43:10] [Client thread/INFO]: [java.lang.Throwable:printStackTrace:-1]: 	... 14 more

For some reason with optifine installed, the realmsclient classes are missing, not sure why that would be. Sounds like an issue on its own.
That said I used the wrong class, and switched to the TextFormatting class instead which is what is normally used, which will probobly resolve the issue.
https://minecraft.curseforge.com/projects/flat-colored-blocks/files/2338922
But to be frank, this crash isn't FCB's fault.


Updated U.S. GDP norm peak plot for May 27 data

This PR updates the U.S. GDP normalized peak plot to include the May 27 data.

Codecov Report

Merging #12 (024b3fe) into master (778b13c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   95.12%   95.12%
=======================================
  Files           2        2
  Lines         164      164
=======================================
  Hits          156      156
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778b13c...024b3fe. Read the comment docs.


.NET 4.7.1 installer crashes on server core

How to repro:
Grab a Server Core 2016 and just run the installer as is on an interactive session by running the setup exe with no parameters.
Expected result:
Either the install works or at least detects and warns that you should only run in quiet mode on server core.
preferably, it should be smart about running on core and just do it's job to install in quiet mode, but not crash.
work around: run the installer in quiet mode ( -q switch )
Please do test the installer on server core as well with defaults and handle this use case.
Some of us hate the idea of GUI's on servers.

I sent mail to the team to ask for help / insight.

Still a problem installing v4.8 on core servers - there is no warning in the GUI, you just get to the "Install" button at the licence agreement, and it simply closes down. Took finding this issue in Github to find the solution and use "-q" on the installer.
I do recommend the following in a command-prompt (not Powershell) so you get an idea when it's completed:
start /wait ndp48-x86-x64-allos-enu.exe /q /norestart
It won't instantly come back but waits for the installer to conclude, and won't reboot automatically.

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275

This repo is no longer actively monitored. Closing up old issues that have not had activity in while. If this is still an issue, please open a new issue in an appropriate repo listed in microsoft/dotnet#1275


Possibility to pass exception to Laravel

Is it possible to ignore or pass exceptions to laravel instead of handling them in this package
Example: AuthenticationException gets dispatched by the  package: result --> the auth middleware doesn't redirect you to the login page anymore

Will be released in v2.0.2


Improve file list in submission dialog

[ ] timestamp in a format "last modified 1 minute ago"
[ ] the bullet points of the submitted files list in the submissions dialog are ever so slightly cut off from the left.

here!

here!


Remote Project Archive locked to 32-bit

Describe the bug
This is halfway between a bug and a feature request.
It appears that remote Project Archives (rPA) default to 32-bit pointer size and that there is not mechanism to enforce 64-bit sizes.  One particularly noticeable side effect of this is that structs with pointer fields will gain a number of undefined entries if unaligned, or shrink if aligned.
To Reproduce
Steps to reproduce the behavior:

Stand up a remote project...
Import a 64-bit file to the remote project
Create a dummy structure with pointer-type fields, in the imported file's File Archive
Through the Data Type Manager, create a Project Archive
Copy the dummy structure from the File Archive to the Project Archive

the dummy structure will have incorrect pointer sizes, and may change size of "Align" is set
attempts to force the type back to 64-bit via the generic_clib_64 archive will silently fail

Rename the dummy structure in the Project Archive
Copy the renamed dummy structure from the Project Archive back to the File Archive

the structure will return to 64-bit form if "Align" is not set
the structure returns to 64-bit form with offsets preserved (@dev747368)

Expected behavior
Expected archive size to be settable or modifiable, or for some override mechanism (forcing types to use generic_clib_64) to properly set pointer sizes to 64-bit.
Note: Through the Ghidra API, local/remote file and local project archives can have their pointer size's modified.  However, an extended search for a similar operation on remote project archives did not appear fruitful (though that definitely does not rule such a mechanism out entirely).
Environment (please complete the following information):

OS: Windows 10 - 64 bit
Java Version: 11.02
Ghidra Version: 9.0.4

When a data type is copied to an archive and is not attached to a program anymore (which is where the data type organization is specified), yes, sizes may change in some types.
If that data type is copied back into a compatible program, the structure definition will match the original.
The other issues you raise (remote, various pre-built data type archives) aren't really relevant.
The main deciding factor (for structures) is the alignment option.  Alignment "on" means "use current compiler / language settings".  Alignment "off" means "user defined offsets".
Of course, even with alignment off, the fields could still change size, but they will stay at the offset you originally defined.
The pre-built data type archives that are included in Ghidra follow the same rules.  If you copy an aligned struct meant for windows 32 bit and put it in a 64 bit linux binary, the fields could be resized and re-aligned and probably won't make much sense.
You may see stuff about linkages between data types in data type archives and where they are copied to.  That it a mechanism to allow updating / synchronizing changes to shared archives into your program.

My concern with alignment was that a type which had its size modified due to alignment would not be corrected when imported back into a 64bit program.  I tested this and it performs as you've described, and so I'll update the original issue to reflect that.  Thank you for your explanation of this.
The intent of using a separate project archive and placing all data structures strictly within this separate archive was to avoid needing to commit/update (i.e. via the linkages) between archives of multiple different files. Do you have recommendations for how to achieve this other than manually committing/updating each file on changes?

I'm not sure if I'm completely understanding your question, but it seems like you are asking about reducing the work associated with maintaining a data type archive that could be shared between multiple related programs.
In general, each program that has data types that are linked to an external data type archive will need to perform a "Update Datatypes from" -> "your_external_archive" whenever it was appropriate to pull in updated data types.
Think of it in terms of source control, where the developer typically chooses when to checkin, pull, revert, etc.

That answered my question exactly, thank you very much. I'll go ahead and close the issue as well as it doesn't seem like there was actually an underlying bug to begin with. Thanks again!


Fix burst coordinates

Use integers values (in swath and bursts) for pixel and line coordinates instead of integers plus 0.5. NOw there are aligned with calibration paramteres coordinates.
Previus swath dataset:
Dimensions:  (line: 13509, pixel: 21632)
Coordinates:
  * line     (line) float64 0.5 1.5 2.5 3.5 ... 1.351e+04 1.351e+04 1.351e+04
  * pixel    (pixel) float64 0.5 1.5 2.5 3.5 ... 2.163e+04 2.163e+04 2.163e+04
 ...

Current swath dataset:
Dimensions:  (line: 13509, pixel: 21632)
Coordinates:
  * line     (line) int64 0 1 2 3 4 5 6 ... 13503 13504 13505 13506 13507 13508
  * pixel    (pixel) int64 0 1 2 3 4 5 6 ... 21626 21627 21628 21629 21630 21631
 ...

Codecov Report

Merging #56 (dbbac81) into main (268a30d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   92.67%   92.69%   +0.02%
==========================================
  Files           7        7
  Lines         614      616       +2
  Branches       68       68
==========================================
+ Hits          569      571       +2
  Misses         24       24
  Partials       21       21

Impacted Files
Coverage Δ

xarray_sentinel/sentinel1.py
92.59% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268a30d...dbbac81. Read the comment docs.


Build from master fails - need to use patched cmake

cargo.toml:
[package]
name = "demo"
version = "0.1.0"
edition = "2021"
resolver = "2"
rust-version = "1.77"

[[bin]]
name = "demo"
harness = false # do not use the built in cargo test harness -> resolve rust-analyzer errors

[profile.release]
opt-level = "s"

[profile.dev]
debug = true    # Symbols are nice and they don't increase the size on Flash
opt-level = "z"

[features]
default = []

experimental = ["esp-idf-svc/experimental"]

[dependencies]
log = "0.4"
esp-idf-svc = { version = "0.49", features = ["critical-section", "embassy-time-driver", "embassy-sync"] }

[patch.crates-io]
esp-idf-svc = { git = "https://github.com/esp-rs/esp-idf-svc" }
esp-idf-hal = { git = "https://github.com/esp-rs/esp-idf-hal" }
esp-idf-sys = { git = "https://github.com/esp-rs/esp-idf-sys" }
[build-dependencies]
embuild = "0.32.0"
cc = "=1.1.30" # Necessary until a new version of `esp-idf-sys` is released

log:
   Compiling esp-idf-svc v0.49.1 (https://github.com/esp-rs/esp-idf-svc#e1d0f285)
error[E0599]: no method named `no_default_flags` found for mutable reference `&mut Config` in the current scope
   --> /home/hanhaiyang/.cargo/git/checkouts/esp-idf-sys-d4c2e811b42d99d6/e8ef996/build/native/cargo_driver.rs:461:10
    |
457 | /     cmake_config
458 | |         .generator(cmake_generator.name())
459 | |         .out_dir(&out_dir)
460 | |         .no_build_target(true)
461 | |         .no_default_flags(true)
    | |         -^^^^^^^^^^^^^^^^ method not found in `&mut Config`
    | |_________|
    |

same probleme here

@leaderiop You can try this, I haven't had a chance to try it yet hardware-check build fails with "unknown target riscv32imc_zicsr_zifencei-esp-espidf

@ivmarkov hi, Why does this error occur when I delete the patch for esp-idf-sys?

@ivmarkov hi, Why does this error occur when I delete the patch for esp-idf-sys?
  Using managed esp-idf repository: RemoteSdk { repo_url: None, git_ref: Tag("v5.2") }
  Using esp-idf v5.2.0 at '/home/hanhaiyang/.espressif/esp-idf/v5.2'

  error occurred: unknown target `riscv32imc_zicsr_zifencei-esp-espidf`

Because the newly released cc-rs crate does not support this trick anymore.
There is a long discussion about it in the chat room if you are interested, search there for zicsr


Text align input mask

Hi. I want input switching from text-align: right => text-align: left is how to do? Thank you

rightAlign: false is not working

@johnqiuwan ,
Can you provide some more info about the mask you use and the options.  Also in which browser and OS.  I tested it here locally and it works fine.


Improve foreign keys API

Proposed API
The library supports foreign keys described in the Table Schema specification. It means if your data package descriptor use resources[].schema.foreignKeys property for some resources a data integrity will be checked on reading operations.
Consider we have a data package:
DESCRIPTOR = {
  'resources': [
    {
      'name': 'teams',
      'data': [
        ['id', 'name', 'city'],
        ['1', 'Arsenal', 'London'],
        ['2', 'Real', 'Madrid'],
        ['3', 'Bayern', 'Munich'],
      ],
      'schema': {
        'fields': [
          {'name': 'id', 'type': 'integer'},
          {'name': 'name', 'type': 'string'},
          {'name': 'city', 'type': 'string'},
        ],
        'foreignKeys': [
          {
            'fields': 'city',
            'reference': {'resource': 'cities', 'fields': 'name'},
          },
        ],
      },
    }, {
      'name': 'cities',
      'data': [
        ['name', 'country'],
        ['London', 'England'],
        ['Madrid', 'Spain'],
      ],
    },
  ],
}

Let's check relations for a teams resource:
from datapackage import Package

package = Package(DESCRIPTOR)
teams = package.get_resource('teams')
teams.check_relations()
# tableschema.exceptions.RelationError: Foreign key "['city']" violation in row "4"

As we could see there is a foreign key violation. That's because our lookup table cities doesn't have a city of Munich but we have a team from there. We need to fix it in cities resource:
package.descriptor['resources'][1]['data'].append(['Munich', 'Germany'])
package.commit()
teams = package.get_resource('teams')
teams.check_relations()
# True

Fixed! But not only a check operation is available. We could use relations argument for resource.iter/read methods to dereference a resource relations:
teams.read(keyed=True, relations=True)
#[{'id': 1, 'name': 'Arsenal', 'city': {'name': 'London', 'country': 'England}},
# {'id': 2, 'name': 'Real', 'city': {'name': 'Madrid', 'country': 'Spain}},
# {'id': 3, 'name': 'Bayern', 'city': {'name': 'Munich', 'country': 'Germany}}]

Instead of plain city name we've got a dictionary containing a city data. These resource.iter/read methods will fail with the same error as resource.check_relations does if there is an integrity issue. But only if relations=True flag is passed.

@pwalsh
Please take a look. It uses your design.

@roll I like it :). Shall we get some Api review from @amercader or @vitorbaptista too? Are you good with this, as an enhancement on the first iteration, or .... ?

@pwalsh
It's hard to judge for me because I'm not really familiar with real-world uses cases for FK in data packages. But after update I think it's nicer and as we discussed more efficient by default (FK opt-in).
May be we also could get some comment from @Stephen-Gates in addition to Adria's and Vitor's.

Here are my thoughts for foreign key use.
From a data publisher perspective:

Too many codes

I have a list of codes in my table
there are too many to put in an enum Constraint for
I create a separate look up table and use FK for validation

What does the code mean?

I have a list of codes in my table
without documentation they are meaningless
I create a separate look up table with the code and description
use FK for validation

Consistent codes for multiple datasets (novice)

I have a set of codes I want everyone to use
They're important so I got them published as an open .CSV (I'm a novice and don't know about data packages yet)
I ask my peer organisations to use the codes in their data publications
Some of my peers know about data packages, others don't
I need to easily discover instructions, examples, and tools to help me and others publish and use the shared code list
for peer organisations that understand data packages, could they reference the external CSV and create a FK relationship?

Consistent codes for multiple datasets

I have a set of codes I want everyone to use
They're important so I've got them published online as data package
I ask my peer organisations to use the codes in their data publications
They use external FK relationship in their data packages to comply

Consistent codes but breaking change

I have a set of codes I want everyone to use
They're important so I've got them published as a data package
My peer organisation are using the codes in their data publications
I have to make major changes to the code list. Some codes are no longer valid.
How do I tell others what's happening (who is using my code list?)
How do I safely make the change (versions, date ranges on codes?)
What do I tell users of code-list to do?

Thinking as a Data Package Tool Provider:

Help users understand the meaning of codes

The table displayed has a column with codes
The codes and their meaning have a FK relationship to this column
When I hover my mouse over the code, a tooltip showing its meaning is displayed
When a user clicks the code, show the related row in the FK table (where they may discover more than just the meaning of the code)

As a data consumer:

Make it easily for me to download

I'm comforted by the effort you've taken to validate the data and apply consistent codes
your efforts give me confidence to explore the data further
give it to me in one big dereferenced table so I can explore it using tools I know like Excel.

@Stephen-Gates
Thanks! That's a great input.

It seems there are no objections and other opinions. So merging because anyway those changes include important internal improvements. I think we have a few days before v1 release for late call feedback.


[dv,i2c] Add I2C fcov covergroups

Some cleanup and adding covergroups.
Closes: https://github.com/lowRISC/opentitan/issues/17447

@hcallahan-lowrisc do you mind having a look at this? If you give the OK, I'll approve and merge it.

Removed comments of yet-to-be-implemented cg's, follow up issue to implement these is here : TODO.


Fix the filename to an absolute path when saving static terrain information

The following files need to be modified.

[ ] tms_ss/tms_ss_terrain_static/launch/tms_ss_terrain_static_launch.py
https://github.com/irvs/ros2_tms_for_construction/blob/00eb51944062663660f46132b17a672f91066d33/tms_ss/tms_ss_terrain_static/launch/tms_ss_terrain_static_launch.py#L8-L13

[ ] tms_ss/tms_ss_terrain_static/tms_ss_terrain_static/tms_ss_terrain_static.py
https://github.com/irvs/ros2_tms_for_construction/blob/00eb51944062663660f46132b17a672f91066d33/tms_ss/tms_ss_terrain_static/tms_ss_terrain_static/tms_ss_terrain_static.py#L24

[ ] tms_ss/tms_ss_terrain_static/tms_ss_terrain_static/tms_ss_terrain_static_mesh.py
https://github.com/irvs/ros2_tms_for_construction/blob/00eb51944062663660f46132b17a672f91066d33/tms_ss/tms_ss_terrain_static/tms_ss_terrain_static/tms_ss_terrain_static_mesh.py#L24

Absolute path is not good solution. Because the absolute path is different for each environment.


router: refactor RetryPolicy

Signed-off-by: Yan Xue<EMAIL_ADDRESS>
Introduce a base class RetryPolicy
Rename current RetryPolicy to CoreRetryPolicy
Extract RetryPolicyImpl from config_impl.cc

Description: refactor RetryPolicy
Risk Level: High
Testing: Existing Tests + Unit tests
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: https://github.com/envoyproxy/envoy/issues/9946
[Optional Deprecated:]

Working on tests.


debugging main thread per instruction causes electron to crash

Hi all.  Here are the steps and some supporting info:
cdieringer@Snapper-osx:~/node/coinstac$ node-inspector -v
Node Inspector v0.12.3
cdieringer@Snapper-osx:~/node/coinstac$ electron -v
v0.30.6
cdieringer@Snapper-osx:~/node/coinstac$ node-inspector
Node Inspector v0.12.3
Visit http://<IP_ADDRESS>:8080/?ws=<IP_ADDRESS>:8080&port=5858 to start debugging.

in a new terminal
cdieringer@Snapper-osx:~/node/coinstac$ electron --debug .
Debugger listening on port 5858

The electron window opens.  In a browser, opening http://<IP_ADDRESS>:8080/?ws=<IP_ADDRESS>:8080&port=5858 triggers causes 'Electron unexpectedly quit'.  I've attached the failure output here.
Let me know if i can provide anything more.  Thanks,
Chris

The --debug flag was broken in v0.30.6, you should update to >= v0.31.1 to get the fix.


[osgearth] Update to 3.5

Fixes #34689.
All features passed with following triplets:
x64-windows
x64-windows-static

Usage test passed on x64-windows.

Pinging @LilyWangLL  for response. Is work still being done for this PR?

https://github.com/gwaldron/osgearth/commit/7cb2f3dbb20eb7681e2550e3c9e1e404aea3a2d5
Has it been resolved yet?

Not yet - working on a patch release - please stand by.

Duplicate of https://github.com/microsoft/vcpkg/pull/41322


[WIP] sys/metrics: Add framework for logging events data

This is proposed framework for logging aggregated data for events.
The idea is simple: there is an event which has multiple metrics we want to log. Each metric is either a simple value (overwritten each time) or data series (appended each time). When event is (re)started each data logged from now on is aggregated internally. At the end of event its contents can be serialized using CBOR and written to mbuf for further processing or writing to logging subsystem (need to add append_mbuf API to logging for this). Now event can be restarted and this starts again.
There is no limit for number of events other than memory capacity.
There is tentative limit for number of metrics for each event (32) due to internal state variabled, but can be increased in future if necessary.
There is sample app which shows intended usage, however there is one thing that needs more explanation. Once metrics are defined, each have name and value type, e.g.:
METRICS_SECT_START(my_metrics)
    METRICS_SECT_ENTRY(val1, EVENT_METRIC_TYPE_SINGLE)
    METRICS_SECT_ENTRY(u8, EVENT_METRIC_TYPE_SERIES_U8)
    METRICS_SECT_ENTRY(u16, EVENT_METRIC_TYPE_SERIES_U16)
    METRICS_SECT_ENTRY(u32, EVENT_METRIC_TYPE_SERIES_U32)
METRICS_SECT_END;

For data series there are separate types for storing 8, 16 and 32-bit values since it does make difference in terms of memory usage. For single values it does not really matter so internally this is always stored as 32-bit value.
The metric name is, unfortunately, only used for serializing and accessing it via e.g. shell (tbd) as it does not generate any symbol to actually pass it to APIs. Thus, APIs identify each metric by ordinal number - as defined, starting from 0. I'd really like to make this smarter, but without adding to much extra macros or need for additional definitions in user code - have no idea at the moment so any comments are welcome here. As a workaround, app can define a simple enum with symbols corresponding to each metric and since its auto-numbered from 0 it can be easily rearranged as required.

cc @InternetOfAwesome, @wes3, @vrahane, @ccollins476ad

latest commits are not cleaned up nicely so I'd recommend to look through all the changes at once - will fix this later

This now depends on changes from PR #933 (included here but apparently GitHub was not smart enough to figure this out automatically).

Can we update & merge this?

hey @andrzej-kaczmarek -- just wanted to see about updating & merging.
Also, one thought occurred to me: it would be good to capture the start time and end time of the metrics events in wall-clock time if available, that way we'd know when things actually happened.


Find all references does not show references to imports

Version 1.2.0-insider
Commit 7ccb21d7e7256a7d42f3dda8b2d3721b8e59724f
Date 2016-05-30T12:59:38.593Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0
Steps to Reproduce:
foo.ts
export enum X {  A, B, C}

bar.ts
import foo = require("foo");

module Main {
    import X = foo.X;
}

Click on the word foo on line 1 of bar.ts
Press Shift + F12 to get all references

EXPECTED: it shows the import as an usage of foo
ACTUAL: it doesn't show any usage and seems like it is unused in bar.ts

This issue was moved to Microsoft/TypeScript#9018


@jonallured: add an elasticsearch index for orgs #migration

This adds elasticsearch indexing for Organization objects, using a Searchable concern that backs onto our own estella gem. A searchable block is placed in the model which details which fields to index.
This adds indexing callbacks on creation, updates (via #save! only) and destruction of Organization objects. Indexing is performed in the background using Sidekiq jobs - indexing a document should take no longer than 10ms or so.
Additionally a rake task is provided to reindex all the Organization objects.
Elasticsearch is now required to be running in order to run some of the test suites. I've added this to the setup script and I've also attempted adding a docker image to the circleci config, though I will probably need to play around with that to get it working. We don't quite mirror this setup elsewhere, as hokusai handles all the container config for CI in our other apps using ES containers.
The next step will be to produce a search endpoint with a custom ES query for auto-completing organization names, as required for our reference show creation lookup in Volt.
Issues
Searching by website url currently doesn't work very well, due to our default analysers not really being designed for url strings. Estella declares four analysers for a string field defined with FULLTEXT_ANALYSIS and here's what the tokens look like for http://www.example.com:
default:

[ "http", "www.example.com" ]

ngram:

[ "ht", "htt", "http", "ww", "www", "www.", "www.e", "www.ex", "www.exa", "www.exam", "www.examp", "www.exampl", "www.example", "www.example.", "www.example.c", "www.example.co", "www.example.com" ]

shingle:

[ "http", "http www.example.com", "www.example.com" ]

snowball:

[ "http", "www.example.com" ]

The easiest fix for this is to parse out the hostname and just index that rather than the full url. That's easier than adding more custom analysers, but it does mean the website is not necessarily linkable when presenting search results. I don't believe searching by website is our main use-case but it would be nice to have.
Our main use-case for reference shows is auto-completion based on Organization name, and the ngram analyzer provides us what we need for that.
Migration
In a Rails console:
Organization.create_index!

In production CLI:
bundle exec rake elasticsearch:reindex

I've been reading through this and it's looking really good, thank you @cavvia!!
Looks like the failures are because you've shadowed a relation name, this fixed it for me:
class Organization < ApplicationRecord
  # ...
    searchable do
      # ...
      field :tag, using: :tag_names, type: 'string', analysis: FULLTEXT_ANALYSIS, factor: 0.5
  # ...
  def tag_names
  # ...
end

That way there isn't a collision between the search method and the tags relation from ActiveRecord.

Thanks for catching that! Updated now with the fix. I've also added the ELASTICSEARCH_URL config var to Heroku for staging and production.

Well, I think this is ready to merge and deploy - you good with that @cavvia?

Sure - go for it! I will then try to run the migrations on staging before prepping a deploy PR as per the Deployment doc.


fix: properly trigger prompt modal close

Fix the issue of: https://github.com/mckaywrigley/chatbot-ui/issues/308
https://user-images.githubusercontent.com/1320925/228838777-04bc2433-f92d-4c2e-ab08-b73df022c1d5.mp4

Great fix


D3D11CreateDevice+Hardware crashes and fallback doesn't work

          @Sewer56 looks like this PR break Angle/DX on my machine:

[OpenGL]Unable to initialize ANGLE-based rendering with DirectX11 : 'System.ArgumentException: Value does not fall within the expected range.
   at Avalonia.Win32.DirectX.DirectXUnmanagedMethods.D3D11CreateDevice(IntPtr adapter, D3D_DRIVER_TYPE DriverType, IntPtr Software, UInt32 Flags, D3D_FEATURE_LEVEL[] pFeatureLevels, UInt32 FeatureLevels, UInt32 SDKVersion, IntPtr& ppDevice, D3D_FEATURE_LEVEL& pFeatureLevel, IntPtr* ppImmediateContext)
   at Avalonia.Win32.OpenGl.Angle.AngleWin32EglDisplay.CreateD3D11Device(IDXGIAdapter1 chosenAdapter, D3D_FEATURE_LEVEL[] featureLevels) in E:\Work\Projects\AvaloniaCopy1\src\Windows\Avalonia.Win32\OpenGl\Angle\AngleWin32EglDisplay.cs:line 175
   at Avalonia.Win32.OpenGl.Angle.AngleWin32EglDisplay.CreateD3D11Display(Win32AngleEglInterface egl) in E:\Work\Projects\AvaloniaCopy1\src\Windows\Avalonia.Win32\OpenGl\Angle\AngleWin32EglDisplay.cs:line 106
   at Avalonia.Win32.OpenGl.Angle.D3D11AngleWin32PlatformGraphics.TryCreate(Win32AngleEglInterface egl) in E:\Work\Projects\AvaloniaCopy1\src\Windows\Avalonia.Win32\OpenGl\Angle\D3D11AngleWin32PlatformGraphics.cs:line 77'
[OpenGL]Unknown requested PlatformApi 'DirectX11'

There are couple of problems:

D3D11CreateDevice+HARDWARE fails here with invalid argument. Don't really know why.
D3D11CreateDevice+SOFTWARE fails too, but UNKNOWN works fine.
D3D11CreateDevice return type should be "int" (non-void), and PreserveSig = false should be removed, if you want to implement fallback logic.
Before each fallback, there should be a warning log message, so developers can easier find this problem. Something like:

Logger.TryGet(LogEventLevel.Warning, LogArea.Win32Platform)?.Log(null, "Unable to create hardware ID3D11Device, error code = {ErrorCode}", $"0x{result:X}")

Originally posted by @maxkatz6 in https://github.com/AvaloniaUI/Avalonia/issues/16035#issuecomment-2177788039

This is technically fixed by

https://github.com/AvaloniaUI/Avalonia/pull/16063

And the feedback was implemented in:

https://github.com/Sewer56/Avalonia/commit/ec04ffacc56a5484c10ece72e9f1685d606bc9c0

As per https://github.com/AvaloniaUI/Avalonia/pull/16035#issuecomment-2177884713, I'm not sure what the current course of action should be.


Add inifnity and negative infinity to integers

I see (and write) a lot of code to does something like this:
var recency = getDaysSinceLastSession();
if (recency != null && recency < 7) {
  // ... do something
}

The problem is that getTimeSinceLastSession can't easily communicate that there is no last session other than by using null or by returning some kind of proprietary "very large value".
With double values, this is easy to fix: the function will just return double.INFINITY. But int doesn't have this. I wonder if this decision could be revisited, especially if we also ponder non-nullability-by-default.
(Link to Seth's SO question from 2015 on this very topic.)

I'm pretty certain we won't be adding any infinite values to integers.
It's obviously not impossible to add an infinite integer (doubles did it), and since Dart has arbitrary sized integers, we are not limited to a fixed number of bits. so adding a bigint-infinity isn't impossible.
It's just impractical.
It's also the reason that this is necessary. If we had an INT_MAX that was at least as great as any int, you could use that instead of an infinity.
We'd need to decide what it means when integer infinity occurs in arithmetic expressions. What is inf + 4, inf - inf, -4 ~/ inf, inf~/inf. For doubles, some of those operations become NaN - so maybe we would need an integer NaN too? (That alone is reason enough to say no!)
Should 4 ~/ 0 be infinity instead of throwing? Are we just reinventing doubles?
Also, if we ever choose to restrict integers to a fixed number of bits, we'd lose the infinities again.
All in all, the use-cases are rare enough, and the complications complex enough, that I don't think it will be worth it to add non-integers to the int  type.
What you can do is to use num recency = double.infinity; and work from there.
It'll likely be slightly slower, because the code can't optimize for "integers only", but it will be correct (up to ~1e+308 at least - then your integers will become double infinity when compared).

But.. why aren't Infinity / Nan on num in the first place?


add a page with link to UML diagrams.

Hi, as an aid to learning the code/data layout I generated some UML diagrams for neptune-core and related crates.
The diagrams can be viewed at tinyurl.com/neptune-diagrams.
I thought they might be useful for other developers onboarding, hence this PR.

Notes
This PR add a 1 line markdown file with a link to the UML diagrams.
The diagrams are being auto-generated and pushed to github nightly in a repo of mine.
If there are any other related/relevant crates you think I should add, please let me know.
The present list is neptune-core, twenty-first, tasm-lib, tasm-lang, triton-vm.
If you should wish to have the diagrams under the Neptune-Crypto account, you could fork my neptune-diagrams repo and either grant me push access, or run the generator yourself from cron.   The cron command looks like:
0 2 * * * /path/to/ml/contrib/autogen/gen_and_push_to_github.php git@github.com:dan-da/neptune-diagrams.git  /path/to/neptune_diagrams/neptune-crates.json 2>&1 > /tmp/neptune-diagrams.log```

Please note the diagrams tend to be more readable with smaller crates.   The 'bare' diagrams are easiest for seeing relations between entities while 'compact' and 'full' are useful for seeing data fields and member functions respectively.

Very nice. Thanks for generating these diagrams. LGTM.


include/swift/AST/DiagnosticEngine.h:993: Assertion `!ActiveDiagnostic && "Already have an active diagnostic"' failed

this issue was copied over from the vscode-swift repository.

Describe the bug
custom operators crash the extension if it has not also indexed the file containing the operator definitions.
this is often the case, because the extension cannot consistently locate sibling files if in a nested Packages/ editable package.
example:
enum MaskedVersion
{
    func ?= (pattern:MaskedVersion?, version:Self)
    {
        pattern ?= .init(version)
    }

    init?<S>(_ string:S) where S:StringProtocol
    {
    }
}

To Reproduce
open the attached project in vscode
Expected behavior
the extension should not crash
Environment

swift: DEVELOPMENT-SNAPSHOT-2022-08-18-a
Visual Studio Code version: 1.70.2
vscode-swift version: 0.7.0

there is a .devcontainer in the attached project
sourcekit-lsp-crash.zip

Probably missing a flush() somewhere. The active diagnostic is unwrap_with_default_value.
cc @xedin


Add GHA samza tests

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

idk why samza tests run on Java Precommits...

@fernando-wizeline is this something that your team already has a pr in flight for or is in progress? Want to make sure we're not duplicating work here

@fernando-wizeline is this something that your team already has a pr in flight for or is in progress? Want to make sure we're not duplicating work here

Hi Danny!
Yeah, it looks like the validatesRunner part is being worked on PR23267. The sickbay validation though is not.
Tagging @MarcoRob just to doublecheck.

ok great i can wait until https://github.com/apache/beam/pull/23267/ goes in

stop reviewer notifications


feat(icon): add poetry icon

Fixes #2861
Superior version of #2979 (PR meant to be closed if this one succeeds)
Changes proposed:

[X] Add

Regarding changes compared to the latest PR:

Fixed SVG:

64x64 width/height -> 32x32 viewbox
Title tag

Not sure why, but I cannot see this icon in AI:


fix: resizing along the edge should affect only one axis

Current behavior
Irrespective of where the resize action originates from, both width and height are updated
Expected behavior
The one shown under "Resizing" at interactjs.io
When resizing an item from:

top/bottom edge: the item can be resized only vertically
left/right edge: the item can be resized only horizontally
corner: the item can be resized both vertically and horizontally

Hey @qmhc, any chance you can have a quick look at this?
It'd be a very nice addition for us as the resize is not working as intended


app.UseWebpackDevMiddleware throw error

At app.UseWebpackDevMiddleware(new WebpackDevMiddlewareOptions { HotModuleReplacement = true });
I got this error after npm package updated from 2.0.3 to 3.0.0 and my Asp.Net Core app updated from 2.0 to 2.1.
NodeInvocationException: Error: Cannot find module 'webpack-dev-middleware'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at attachWebpackDevMiddleware (C:\work\Traveller\Traveller.Web.Portal\node_modules\aspnet-webpack\WebpackDevMiddleware.js:72:13)
at C:\work\Traveller\Traveller.Web.Portal\node_modules\aspnet-webpack\WebpackDevMiddleware.js:271:25
at Array.forEach ()
at Server. (C:\work\Traveller\Traveller.Web.Portal\node_modules\aspnet-webpack\WebpackDevMiddleware.js:234:36)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:106:13)
at Server.emit (events.js:208:7)
at emitListeningNT (net.js:1394:10)
at _combinedTickCallback (internal/process/next_tick.js:135:11)
at process._tickCallback (internal/process/next_tick.js:180:9)

yarn/npm should have had a warning about missing peer dependencies. webpack-dev-middleware is now a peer dependency of aspnet-webpack for backwards compatibility. If you are using webpack 4 just install the latest webpack-dev-middleware and add it to your dev-dependencies.

Thanks, it is working now!


Need help to debug error

I am getting below error. Can any one one help me in this. I am training a custom dataset, with 11 classes. But I am training for 3 classes. 'd50 is one of the label but I am not training it. datasettype is VOC'
KeyError: Caught KeyError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/torch/utils/data/_utils/worker.py", line 198, in _worker_loop
data = fetcher.fetch(index)
File "/usr/local/lib/python3.7/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/usr/local/lib/python3.7/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/content/YOLOX/yolox/data/datasets/datasets_wrapper.py", line 121, in wrapper
ret_val = getitem_fn(self, index)
File "/content/YOLOX/yolox/data/datasets/mosaicdetection.py", line 91, in getitem
img, _labels, _, _ = self._dataset.pull_item(index)
File "/content/YOLOX/yolox/data/datasets/voc.py", line 145, in pull_item
target = self.load_anno(index)
File "/content/YOLOX/yolox/data/datasets/voc.py", line 126, in load_anno
target = self.target_transform(target)
File "/content/YOLOX/yolox/data/datasets/voc.py", line 64, in call
label_idx = self.class_to_ind[name]
KeyError: 'd50'

seems your are using custom dataset, please make sure "d50" in your classes name


No action taken

I find the bookmarklet stopped working.
It just doesn't do anything anymore.

Still works for me. When have you last updated it?


Test on PHP 7.3 on Travis

apply https://github.com/mercari/dietcube/pull/30

I tried and found out that this is more than just adding php version but upgrading the whole dependencies.


How do i make the cutscene work at the end of a song?

Describe your problem here.
the title says so
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

#230


Longitude lost focus

Focus jumps from Longitude to Localities each time you change anything in Longitude.
Example:

Edit an Observation whose Longitude has several (>=3) decimal digits.
Click in the end of the Longitude field (to the right of the numbers)
Back space (delete) one digit at a time.
Depending how fast you do this, the Localities field will auto update to match the updated Longitude and focus jumps to the start of the Localities string.
Repeat until you've erase the decimal point (and focus ups to the end of Localities.)
Now try to restore Longitude to multiple decimal digits. Painful, because each time you enter anything in Longitude, focus shifts to Localities.

Yeah, i've experienced this. It's a little mind boggling to fix. What needs to happen is something like the "keep button", or a "lock" icon on the Locality input.
It is tricky differentiating between someone who wants to move the point of the obs and potentially change the locality, and someone who is futzing with their lat/lng.
What's the actual use case, though? (Not saying there isn't one, just that i couldn't think of one...) Why would people be trying to tweak the lat/lng numbers instead of clicking on the map? If people have a lat/lng they're trying to enter manually, it should work if they "Clear location", but the easiest way to adjust a point is by clicking a different place on the map.

@nimmolo: I noticed it because I needed to both add a lat/lng and correct the Location for one of my Observations.
I forget the exact sequence of events an keyboard presses. It was a struggle to get things exactly right.
But if it doesn't come up that much, it's a lower priority. We all have bigger fish to fry.

Ok. I'm sure others will encounter it too, but for the record the easier path when you're doing that is to hit the "Clear location" button, add the lat/lngs, and then pick a locality.
As long as one lat/lng field is blank, it will leave you alone until you fill both. You have to be quick with the second one, though, because as soon as it thinks it has a viable lat/lng pair of any number of digits, it starts looking for a Locality after a one-second delay.
We could just try to increase the Location-search delay, huh? What do you think

I don't like longer delay.
Maybe add something to the instructions.


First Teapot

Discussed in https://github.com/schwa/Ultraviolence/discussions/2

Originally posted by schwa October 31, 2024
The current state of main (as of $TODAY) renders a red rectangle to a texture and saves it to disk. Not exactly inspiring
The next goal is to create a SwiftUI app with a view that renders a teapot (flat shading is probably fine for now). Colour & position of teapot should be user definable, as is camera position.
Goal right now isn't performance or a great API - that will evolve (we can also ignore those little purple triangles in the Xcode Metal debugger for now).

Implemented


Add #[diagnostic(forward(field_name), code(...))]

This PR solves a problem I imagined. Not sure if it's real or not yet. I made a demo though: https://gist.github.com/cormacrelf/09ef573df0f5b41c9fa252f5866336ba
There are bugfix components of this that unquestionably need to be merged, but they were done on top of the other work so I'd have to redo it basically.
As described in #36:

The forwarding branch, in addition to that, adds a forward(field_name) arg that must be used with a code(...) like any other arg. When you supply it, it makes any unspecified things forward their implementation to the specified field. It works with named and unnamed (forward(0)) structs and enum variants. The test suite shows what you can do with it -- the ForwardsTo struct is used for the snippets, all the other bits of info can be overridden.
The question before we land this PR is a bikeshed, whether these two different argument names for arguably the same functionality are a good idea or not. Which is preferable of these?

Only diagnostic(transparent)
diagnostic(transparent), diagnostic(code(...), forward(field_name)) as described
diagnostic(transparent), diagnostic(code(...), transparent(field_name))
diagnostic(transparent), diagnostic(code(...), default(field_name). I kinda like this but I only just thought of it.

quick comment: I went to some lengths to make sure that all the gen methods were infallible, so any issues would be found out as early as possible, during the parsing phase. I haven't read this PR in detail yet, but it would be nice if we could keep those infallible generators.

Ah yes, originally I peppered a few Results in there, but realised what you were going for later. I just forgot to remove the Result from the main gen() method. It did indeed turn out cleaner with the fallible parts in the parse phase.

One side benefit is that for use of transparent on structs with !=1 field, what used to be a rendered _ => compile_error!("...")  is now a properly spanned error, since it's now DiagnosticDefArgs::Transparent(Forward) constructed with Forward::for_transparent_field()?.

hey how's it going with this? Just a heads up that I'm about to start making some potentially really big breaking changes to the way snippets are defined and I'm afraid to conflict with this stuff.

I did mark it draft, but there's nothing left to do.

Basically it's whether you want it or not!

Actually there are some conflicts now, thumbs up react if you want me to resolve em

Please go ahead

The failing tests are the same ones that are failing on main due to a change in the number of ------- after printing the code

yay! Great job, and thanks :)


Add Continuous Integration

Issue description
Currently, Travis CI installs software, but does not run any tests
Acceptance criteria

[X] Lint relevant files

~IBM/Kubernetes-container-service-GitLab-sample#27~

[ ] Test deployment

[ ] Non master branches and pull requests can use docker-compose

IBM/Kubernetes-container-service-GitLab-sample#29
Deploys to Kubernetes from non-protected branches are tricky for security reasons
minikube does not work in Travis CI

[ ] All master events should trigger a deploy to Kubernetes

IBM/Kubernetes-container-service-GitLab-sample#30 would be nice.


pl.rank_gene_groups using gene_symbols key word not working

Hello Team,
sc.__version__
'1.7.0rc2.dev6+g5fc12f4a'

I just pulled the latest master to see if the issue was just in my earlier version.
I'm trying to plot rank_gene_groups dot plot
sc.pl.rank_genes_groups_dotplot(adata, n_genes=4, values_to_plot='logfoldchanges', cmap='bwr', gene_symbols='Uniq_Name', use_raw=False)
However it doesn't work with the following tranceback:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-43-4ca50e495f54> in <module>
----> 1 sc.pl.rank_genes_groups_dotplot(adata, n_genes=4, values_to_plot='logfoldchanges', cmap='bwr', gene_symbols='Uniq_Name', use_raw=False)  # swap_axes=True)

~/projects/scanpy/scanpy/plotting/_tools/__init__.py in rank_genes_groups_dotplot(adata, groups, n_genes, groupby, values_to_plot, min_logfoldchange, key, show, save, return_fig, **kwds)
    656     """
    657
--> 658     return _rank_genes_groups_plot(
    659         adata,
    660         plot_type='dotplot',

~/projects/scanpy/scanpy/plotting/_tools/__init__.py in _rank_genes_groups_plot(adata, plot_type, groups, n_genes, groupby, values_to_plot, min_logfoldchange, key, show, save, return_fig, **kwds)
    435             from .._dotplot import dotplot
    436
--> 437             _pl = dotplot(
    438                 adata,
    439                 var_names,

~/projects/scanpy/scanpy/plotting/_dotplot.py in dotplot(adata, var_names, groupby, use_raw, log, num_categories, expression_cutoff, mean_only_expressed, cmap, dot_max, dot_min, standard_scale, smallest_dot, title, colorbar_title, size_title, figsize, dendrogram, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, swap_axes, dot_color_df, show, save, ax, return_fig, vmin, vmax, vcenter, norm, **kwds)
    940         del kwds['color_map']
    941
--> 942     dp = DotPlot(
    943         adata,
    944         var_names,

~/projects/scanpy/scanpy/plotting/_dotplot.py in __init__(self, adata, var_names, groupby, use_raw, log, num_categories, categories_order, title, figsize, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, expression_cutoff, mean_only_expressed, standard_scale, dot_color_df, dot_size_df, ax, vmin, vmax, vcenter, norm, **kwds)
    130         **kwds,
    131     ):
--> 132         BasePlot.__init__(
    133             self,
    134             adata,

~/projects/scanpy/scanpy/plotting/_baseplot_class.py in __init__(self, adata, var_names, groupby, use_raw, log, num_categories, categories_order, title, figsize, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, ax, vmin, vmax, vcenter, norm, **kwds)
    109         self._update_var_groups()
    110
--> 111         self.categories, self.obs_tidy = _prepare_dataframe(
    112             adata,
    113             self.var_names,

~/projects/scanpy/scanpy/plotting/_anndata.py in _prepare_dataframe(adata, var_names, groupby, use_raw, log, num_categories, layer, gene_symbols)
   1864         groupby.remove(groupby_index)
   1865     keys = list(groupby) + list(np.unique(var_names))
-> 1866     obs_tidy = get.obs_df(
   1867         adata, keys=keys, layer=layer, use_raw=use_raw, gene_symbols=gene_symbols
   1868     )

~/projects/scanpy/scanpy/get.py in obs_df(adata, keys, obsm_keys, layer, gene_symbols, use_raw)

KeyError: "Could not find keys '['KY.Chr1.1190', ..., 'KY.Chr9.987']' in columns of `adata.obs` or in gene_symbols column `adata.var[Uniq_Name].values`."

I cant see how to use gene_symbols in the tl.rank_gene_groups either. Am I missing something?

This seems mostly fine. I would definitely suggest updating to a more recent version, as there could definitely be issues in pre-release builds.
If that doesn't solve your problem, could you confirm if "KY.Chr1.1190" in adata.var["Uniq_Name"]?

sc.__version__
'1.8.0.dev78+gc488909a'

It seems to be working but I'm currently on a different dataset. What I noticed was that if I didn't have the same ID columns in my adata.var when setting adata.raw I couldn't use gene_symbols. After setting adata.var so it had the same IDs before setting adata.raw made it possible.
In other words if adata.raw was missing the notation it failed for me (different error though).
I will give an update when I get back to the dataset above. Just to make sure it's the same issue.

What I noticed was that if I didn't have the same ID columns in my adata.var when setting adata.raw I couldn't use gene_symbols.

Ah, if you're using the values in raw for differential expression the column used for gene_symbols should be in raw.var this is because raw can have a different set of variables than the main object. So this case, at least, is expected.

Getting back to this. I still have the same issue as before.
For some reason this does not work on my data. I don't have any raw set at all in this data.
sc.tl.rank_genes_groups(adata, 'celltypes', method='t-test')
sc.pl.rank_genes_groups_matrixplot(adata, n_genes=5, cmap='viridis', gene_symbols='Uniq_Name')

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-41-3b246f8b6bcc> in <module>
----> 1 sc.pl.rank_genes_groups_matrixplot(adata, n_genes=5, use_raw=False, cmap='viridis', gene_symbols='Uniq_Name')

~/projects/scanpy/scanpy/plotting/_tools/__init__.py in rank_genes_groups_matrixplot(adata, groups, n_genes, groupby, values_to_plot, min_logfoldchange, key, show, save, return_fig, **kwds)
    823     """
    824
--> 825     return _rank_genes_groups_plot(
    826         adata,
    827         plot_type='matrixplot',

~/projects/scanpy/scanpy/plotting/_tools/__init__.py in _rank_genes_groups_plot(adata, plot_type, groups, n_genes, groupby, values_to_plot, min_logfoldchange, key, show, save, return_fig, **kwds)
    448             from .._matrixplot import matrixplot
    449
--> 450             _pl = matrixplot(
    451                 adata, var_names, groupby, values_df=values_df, return_fig=True, **kwds
    452             )

~/projects/scanpy/scanpy/plotting/_matrixplot.py in matrixplot(adata, var_names, groupby, use_raw, log, num_categories, figsize, dendrogram, title, cmap, colorbar_title, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, standard_scale, values_df, swap_axes, show, save, ax, return_fig, vmin, vmax, vcenter, norm, **kwds)
    345     """
    346
--> 347     mp = MatrixPlot(
    348         adata,
    349         var_names,

~/projects/scanpy/scanpy/plotting/_matrixplot.py in __init__(self, adata, var_names, groupby, use_raw, log, num_categories, categories_order, title, figsize, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, standard_scale, ax, values_df, vmin, vmax, vcenter, norm, **kwds)
    109         **kwds,
    110     ):
--> 111         BasePlot.__init__(
    112             self,
    113             adata,

~/projects/scanpy/scanpy/plotting/_baseplot_class.py in __init__(self, adata, var_names, groupby, use_raw, log, num_categories, categories_order, title, figsize, gene_symbols, var_group_positions, var_group_labels, var_group_rotation, layer, ax, vmin, vmax, vcenter, norm, **kwds)
    109         self._update_var_groups()
    110
--> 111         self.categories, self.obs_tidy = _prepare_dataframe(
    112             adata,
    113             self.var_names,

~/projects/scanpy/scanpy/plotting/_anndata.py in _prepare_dataframe(adata, var_names, groupby, use_raw, log, num_categories, layer, gene_symbols)
   1864         groupby.remove(groupby_index)
   1865     keys = list(groupby) + list(np.unique(var_names))
-> 1866     obs_tidy = get.obs_df(
   1867         adata, keys=keys, layer=layer, use_raw=use_raw, gene_symbols=gene_symbols
   1868     )

~/projects/scanpy/scanpy/get/get.py in obs_df(adata, keys, obsm_keys, layer, gene_symbols, use_raw)
    270         alias_index = None
    271
--> 272     obs_cols, var_idx_keys, var_symbols = _check_indices(
    273         adata.obs,
    274         var.index,

~/projects/scanpy/scanpy/get/get.py in _check_indices(dim_df, alt_index, dim, keys, alias_index, use_raw)
    165             not_found.append(key)
    166     if len(not_found) > 0:
--> 167         raise KeyError(
    168             f"Could not find keys '{not_found}' in columns of `adata.{dim}` or in"
    169             f" {alt_repr}.{alt_search_repr}."

KeyError: "Could not find keys '['KY.Chr1.1388', 'KY.Chr1.1475', 'KY.Chr1.2070', 'KY.Chr1.2214', 'KY.Chr1.2297', 'KY.Chr1.686', 'KY.Chr11.93', 'KY.Chr13.413', 'KY.Chr2.1171', 'KY.Chr2.1545', 'KY.Chr3.405', 'KY.Chr4.246', 'KY.Chr4.468', 'KY.Chr5.382', 'KY.Chr7.503', 'KY.Chr7.846', 'KY.Chr8.1168', 'KY.Chr8.473', 'KY.Chr9.813', 'KY.Chr9.912']' in columns of `adata.obs` or in adata.var['Uniq_Name']."

The KeyError is odd. adata.var['Uniq_Name'] Contains the actual gene identifiers. The ones in KeyError is in adata.var_names. So it looks like it searches for the var_names in Uniq_Name for some reason.
I pulled from this repo just now.

Surprisingly sc.pl.rank_genes_groups(adata, n_genes=25, sharey=False, gene_symbols='Uniq_Name') works just fine.

Ah, I think this is a bit of a known issue with a fix in the works here: #1529. Essentially there is a bug in some of the rank_genes_groups_* functions with how they handle gene_symbols.

Closing to consolidate discussion to #1796


Dev jokes js to ts

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Here i have tried to change dev jokes from JavaScript to typescript .
Fixes #563
Type of change

[ ✅] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
It has been tested by me in my local system for all edge cases.
Checklist:

[ ✅] I have performed a self-review of my own code
[✅ ] I have commented my code, particularly in hard-to-understand areas
[✅ ] I have made corresponding changes to the documentation
[✅ ] My changes generate no new warnings
[ ✅] I have added tests that prove my fix is effective or that my feature works
[✅ ] New and existing unit tests pass locally with my changes
[ ✅] Any dependent changes have been merged and published in downstream modules

hey @koustov  please give it a look ...

@yung-coder , Can you add the meaningful title for the PR?

hey @Sachin-chaurasiya  updated give it a look

Done

Should I change the name of interface @Sachin-chaurasiya ..?

Should I change the name of interface @Sachin-chaurasiya ..?

@yung-coder , Yes, please see the suggested changes.

done @Sachin-chaurasiya

done @Sachin-chaurasiya

done @Sachin-chaurasiya  i think its all good now

hey @atapas  can you review this ..?


Epub font style, text, line, paragraph display

Issue
Epub font style, text, line, paragraph display when custom option is not selected in yomikiru and EPUBReader.

I compared the EPUBReader and your app display of the text.
In EPUBReader, when As defined in the book option is selected, it displays the text, as defined in the book.
In Yomikiru, I think some spacing are not displayed as defined in the book.
I uploaded a video for comparison. Please chekc it.

https://user-images.githubusercontent.com/127277950/235143116-8f48773f-2bef-4b0b-a6c2-b84333d312b7.mp4

At the end, above and below the TL Note, there is a double line, it is not displayed in yomikiru.
I also did not select custom font, so shouldn't the font be displayed as per the epub file's specified rule?
I also did not select spacing for line, paragraph, they should also be displayed as per the epub file's rule.

Yomikiru, I think some spacing are not displayed as defined in the book.

There is no font defined in the book for this epub, So app is using default font from app.
Same goes for all other settings, but they are as defined in the book.

I also did not select spacing for line, paragraph, they should also be displayed as per the epub file's rule.

In the above page there is no specified rule for line height and paragraph spacing in the epub file.

At the end, above and below the TL Note, there is a double line, it is not displayed in yomikiru.

That is because of no specified width for line. I will make 100% as default with some vertical margin .
Close the issue if everything cleared.

If the buttons are not checked / ticked, then the settings (font family, line, paragraph spacing) are as defined in the opened EPUB file / chapter?

Yes, I found it redundant to write "custom" in front of every option.

Can i get source of epub you gave so i can test on multiple files when have to?


Messages from Webhooks empty

Summary
Contents of build failure messages from incoming webhooks with markupare not rendered.
Environment Information

Device Name: iPhone 5 SE
OS Version:
Mattermost App Version: 1.0 (22)
Mattermost Server Version: 3.7.3

Steps to reproduce
Configure incoming webhook for build notifications from Gitlab. Trigger a build. Receive the notification in iphone app.
Expected behavior
Build notifications should be rendered as a box with a vertical colored bar on the left, red for failure, green for succes.
Observed behavior
The notification is on the screen, but the contents is not rendered at all. See the three webhook messages in the center of the screenshot below.
Possible fixes
I suspect that rendering of this specific markdown or html is not yet supported in the native app beta.

Hi @realrolfje thanks for the report - we have a ticket here to track adding support for this: https://mattermost.atlassian.net/browse/PLT-5974

This should be fixed by this PR: https://github.com/mattermost/mattermost-mobile/pull/555
It will be available in beta apps build 31+


CameraComponent position type for children component

Current bug behaviour
When adding a component with a viewport position type, it moves along with viewfinder.
Expected behaviour
component with viewport position stays in place
Steps to reproduce
class Children extends PositionComponent {
  final paint = Paint()
    ..style = PaintingStyle.stroke
    ..strokeWidth = 3
    ..color = const Color(0xff87c4e2);

  @override
  PositionType get positionType => PositionType.viewport;

  @override
  void render(Canvas canvas) {
    canvas.drawRRect(
      RRect.fromRectAndRadius(
        Rect.fromLTWH(0, 0, 50, 50),
        const Radius.circular(5),
      ),
      paint,
    );
  }
}

class CameraOwner extends PositionComponent {
  late CameraComponent _camera;

  late World _world;

  @override
  Future<void> onLoad() async {
    final viewport = MaxViewport();

    _world = World();

    final viewfinder = Viewfinder()..anchor = Anchor.topLeft;
    _camera = CameraComponent(
      world: _world,
      viewport: viewport..anchor = Anchor.topLeft,
      viewfinder: viewfinder,
    );

    _world.addAll([
      Children(),
    ]);

    await add(_world);
    await add(_camera);
  }

  @override
  void update(double dt) {
    _camera.viewfinder.position = Vector2(
      _camera.viewfinder.position.x - 1,
      _camera.viewfinder.position.y,
    );
  }
}

class MyGame extends FlameGame {
  @override
  Future<void> onLoad() async {
    add(CameraOwner());
  }
}

When using the CameraComponent you don't use the positionType, you add the component directly to the viewport instead of adding it to the world.

@spydon When I add a component to the viewport, it does not call the render method in the child
final viewport = MaxViewport();
viewport.add(Children());

Did you remove the positionType too?


ASP.NET Core app with React  out of date

Search for Once the project is created, Solution Explorer should look like this:
Looks like when this doc was written a Web API app was used. It's currently using minimal APIs so there's no controller, no WeatherForcast.cs file, etc.
The current template looks much different.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f5beb7f5-5d28-d5e5-92ba-3e04c75e44b5
Version Independent ID: 867e3a3f-2387-ba46-c911-10822f8c4a81
Content: Create an ASP.NET Core app with React - Visual Studio (Windows)
Content Source: docs/javascript/tutorial-asp-net-core-with-react.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@Mikejo5000 I'm working on this.

Updates in linked PR now merged.


Mention MacPorts as install option on dbeaver.io/download

Please consider mentioning MacPorts as alternative install option on https://dbeaver.io/download, similar to "brew cask". The command to install dbeaver-community via MacPorts is
sudo port install dbeaver-community

This makes sense

Done


Missing Headers in Automate Pages

:nut_and_bolt: Description: What code changed, and why?
The headers are missing the Automate pages. Some H5 should be H4.
:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Fixed changes in different PR.


Clean up tracing logic - prepare for new tracing functionality.

Clean up the distributed tracing functionality in preparation for new OpenTelemetry semantic conventions - See this for more information

Made Context immutable (including marking the static ApplicationContext as const
Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
Changed Az.Namespace value from being the package name to being the service name.
Change test SpanExporter to fully capture exported values rather than keeping references to the values.

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

/check-enforcer override


git_commit files

data "git_commit" "repo" {
  directory = "."
  revision  = "@"
}

commit_files = substr("${join(", ", [for s in data.git_commit.repo.files : format("%q", s)])}", 0, 126)

commit_files seems to be set with every file in the repo, i would think it would just be the files that were committed.
something like :
git diff head~1 --name-only
forgot to mention also tried:
data "git_commit" "repo_last_head_rev" {
  directory = "."
  revision  = "HEAD^" // revision  = "HEAD~1"
}

Yeah that is what it is supposed to do (ref for me: https://github.com/metio/terraform-provider-git/blob/main/internal/provider/data_source_commit.go#L184). I'll check what's going wrong and let you know - thanks for reaching out & sorry for the trouble!

That link doesn't work, pretty good provider btw.

OK all tests are passing & the next release will happen on Friday (2024-01-12)

That's odd about the link since it points to this very same repository 😰 however I think I found the root problem of your initial issue in #235 and upstream at go-git/go-git#307

Interesting the link works now..

OK all tests are passing & the next release will happen on Friday (2024-01-12). Thanks again for opening this issue!

Just tested this and works great. thank you sir


PostgreSQL hfj_search does not reference large objects with oid

Describe the bug
The database schema for hfj_search table when using PostgreSQL is:
CREATE TABLE public.hfj_search
(
    pid bigint NOT NULL,
    created timestamp without time zone NOT NULL,
    failure_code integer,
    failure_message character varying(500) COLLATE pg_catalog."default",
    last_updated_high timestamp without time zone,
    last_updated_low timestamp without time zone,
    num_found integer NOT NULL,
    preferred_page_size integer,
    resource_id bigint,
    resource_type character varying(200) COLLATE pg_catalog."default",
    search_last_returned timestamp without time zone NOT NULL,
    search_query_string text COLLATE pg_catalog."default",
    search_query_string_hash integer,
    search_type integer NOT NULL,
    search_status character varying(10) COLLATE pg_catalog."default" NOT NULL,
    total_count integer,
    search_uuid character varying(36) COLLATE pg_catalog."default" NOT NULL,
    search_deleted boolean,
    search_param_map oid,
    optlock_version integer,
    CONSTRAINT hfj_search_pkey PRIMARY KEY (pid),
    CONSTRAINT idx_search_uuid UNIQUE (search_uuid)
)

The problem is that search_query_string column is text, even though it actually references a large object.
ca/uhn/fhir/jpa/entity/Search.java:
	@Lob()
	@Basic(fetch = FetchType.LAZY)
	@Column(name = "SEARCH_QUERY_STRING", nullable = true, updatable = false, length = MAX_SEARCH_QUERY_STRING)
	private String mySearchQueryString;

If we run tools such as vacuumlo it will delete those large objects because there is no references from oid type of fields to them and leave the database in inconsistent state (and HAPI FHIR cannot resolve this as it fails to clean up the search).
Expected behavior
hfj_search table column search_query_string type is oid
Environment (please complete the following information):

HAPI FHIR Version 5.2.0

@jamesagnew any insight on this?

Fixed by #3016. I'm closing this.


feature: unittests

This is a tryout to add UnitTests to tracevis
we can now test by python -m unittest discover test -b
It is not complete yet so PR should wait until most of important tests be complete

It is not complete yet so PR should wait until most of important tests be complete

Yeah. It's already a good start to have these unit tests and we can add more. Perhaps, it would be cool to add a GitHub action for running tests automatically at every commit and PR before merging, if you have time for that!

Thanks for the review and comments
Yes we should add more tests specially for core functionalities but it can be progressive and every new test can be added to previous ones in the future
So it is a good idea to start having actions for the ones already exist
I also think having a code coverage test in actions can help and show how much of the codebase is under test

test_config_file unittest fixed for missing keys in config file
Now it tests against existing keys in config file and ignores the rest (the rest of keys are defaults which previously tested in test_defaults)

Added coverage package to make code covarage test possible
adding coverage before test command makes test report and coverage report shows it

partying_face Thanks for the improved tests! Could you also commit a github action that runs tests at every commit and pull request? pray

Hi @bassosimone , I added the unittest action file.
for code coverage test we can have similar action file wich only can show pass or fail result. so to show coverage percent in README.md we need to generate a custom badge. we have three options:

Use cloud test providers (e.g. codecov) which will need GH_TOKEN to generate badge for us
Calculate percentage using simple bash and use badge generator URLs like googleapi or shields.io, which need to include external URL in README.md and update README file on every push (this adds additional change to README which is  unrelated to commit subject)
Generate badge using python in action file and store its image in somewhere (e.g. .github dir) and use it in README.md

What is your opinion? Which one is the best approach?

@RYNEQ At OONI, we generally use codecov or coveralls and link their badge, which, as you say, requires to setup some form of communication between GitHub and one of those services. The other two options that you mention strike me as a bit more work, so perhaps we should try to avoid using them, unless there's some reason not to trust an external coverage service. In such a case, I would just ignore generating the badge and make hack some code to make the GitHub action fail if the coverage decreases by more than, say, 0.5%.


ASTScope: Clean up handling of PatternBindingDecls and AccessorDecls

@swift-ci Please smoke test

@davidungar Yes, when I disabled the specialized check for PatternBindingDecls, another assertion fired later on about overlapping source ranges.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility


Competition detault

The unofficial kaggle API (https://github.com/floydwch/kaggle-cli) has a nice feature to default to a specific competition if you omit the -c parameter, see $ kg config -g -u <username> -p <password> -c <competition>
It would be very nice to have this on the official kaggle api.

You could achieve this using a simple bash function actually. For example, adding something like this to your .bashrc or .bash_profile:
function kgcomp() {
    kaggle competitions ${@:1:1} -c jigsaw-toxic-comment-classification-challenge ${@:2}
}

Running:
kgcomp submit -f submission.csv -d "description"
should then just be equivalent to:
kaggle competitions submit -c jigsaw-toxic-comment-classification-challenge -f submission.csv -d "description"

Hey @antorsae and @mxbi , thanks for your suggestions. We are gathering user feedback on the beta release and we will then look at V1.1 incorporating changes based on this feedback. Cheers, Daniel

Thanks for all the suggestions! This is added now to the new API v1.1. You can now set a competition via kaggle config set -n competition -v [competition].


Not working for pull - when files are changed

I made a simple test, two remote repositories (dev, lib). Clone dev, git stree lib in the dev subfolder.
git stree push works as expected.
If I edit a file in cloned lib outside of dev stree, add and commit and then do the git stree pull lib in the dev I get the merge conflict in this edited file. Everytime.
This is sadly useless for any edits made upstream in the library. I thought that this will solve all my problems as it looked very promising. Sadly it does not work at all, every edit in the original lib is conflicting with the untouched files in the imported stree... :(
It works the other way around, but mostly I will need the library updates pulled... which is completely broken.
Can anyone use this at all?

Hey Bob,
This is very weird.  There are some use-cases that don't work, as in #39, and we're investigating this very soon (so sorry we're submerged for now), but it's been working quite well in similar scenarios on a number of codebases. Simple pulls of updated stree remotes on untouched local stree codebase works for a lot of people. I'm quite puzzled as to what the failure conditions are.
We're going to change the underlying mechanism anyway, to fix other, unrelated issues. Chances are the new mechanism will remove that elusive failure condition anyway.
Sorry this doesn't cut the mustard for you. I hope we can fix this over the holidays.

Yes, now that I look at it, this is almost the same as #39. Hope you will get this fixed, as this stree is otherwise a very nice idea!


Created profile

This is an optional description
@elezar Have a look

@elezar Can you have a second look before I merge?

LGTM :+1: :ship: :shipit: :gun:

🚢


Add new REST API to request vc info

Add new REST API to request vc info

Pull Request Test Coverage Report for Build 600

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 77.193%

Totals

Change from base Build 564:
1.0%

Covered Lines:
587

Relevant Lines:
710

💛  - Coveralls


Improve version regex and add tests

Pull request
Description
This PR updates the regex used to validate the version of the library.
Changes made

Self-explanatory.

Checklist

[x] Your branch has been rebased onto the main branch.
[ ] APIs have been properly documented (if relevant).
[ ] The documentation has been updated (if relevant).
[x] New unit tests have been written (if relevant).
[ ] The demo has been updated (if relevant).
[ ] All pull request status checks pass.

I'll check the workflow regex on my fork before we can merge this.

The PR status points to the wrong PR.
This PR builds successfully, as it can be seen here.


Gradle: Upgrade detekt to version 1.4.0

See https://arturbosch.github.io/detekt/changelog.html#140.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

Appveyor issues are unrelated, thus merging is ok.