Are all of our unit tests running?

It is possible that a unit test exits half way through, and the second half of the test never gets run.
For instance, this test was exiting early, and so we weren't actually running the next 20 lines of hypothetical test code:
https://github.com/terrapower/armi/blob/8b6ea1abcfe6ea4587ab0a2622f4d7c03e214e83/armi/reactor/tests/test_components.py#L302-L306
So, how can we test if our unit tests are actually doing anything?  Easy!
We should run code coverage against ARMI, and change the coverage so it COVERS THE UNIT TESTS.  Then just hand-check any test file that isn't 100%, to see what unit tests are exiting earlier than we thought.
Just change this one line:
https://github.com/terrapower/armi/blob/8b6ea1abcfe6ea4587ab0a2622f4d7c03e214e83/.coveragerc#L16-L20
~MAYBE we could even have a GitHub Action Jenkins job that ensure if we do this that each test file has 100% code coverage. Though that could get a bit iffy.~

I think we should manually run coverage on the unit tests occasionally to see if this is a big issue, and make issues to update tests when we see problematic ones.
But I think that we should continue to exclude tests in our main coverage metrics, as that can artificially inflate the total coverage (because at least most tests run during testing).

I've run the framework tests locally in recent PRs and didn't see any differences in terms of passing using pytest but didn't check if the automated version on GitHub captures the same number of tests.

I am running a test for this locally.
Though Tony and I found one test today that exited early and didn't run at all.  So, they are out there.

I note that we have a couple NucleardataIO unit tests that never run because they are incomplete or broken (or our code is broken?):
https://github.com/terrapower/armi/blob/40519daa1d9b817644c0e01c70baa658d6d539ae/armi/nuclearDataIO/cccc/tests/test_dlayxs.py#L311-L314
https://github.com/terrapower/armi/blob/40519daa1d9b817644c0e01c70baa658d6d539ae/armi/nuclearDataIO/cccc/tests/test_dlayxs.py#L939-L942


Change Button Placement

How do you change the tab order or button placement?
I tried this without success: var toggle =
player.controlBar.addChild('theaterModeToggle', options, 4);
Didn't work.
It is placing the button close to progress bar and far from the fullscreen button, which I'd like it to sit right in front of.
How can I move it or tell it to go before the fullscreen button?

Hey @casbboy, do you have a page or anything up that shows the problem? I built the plugin against video.js 5, and notice you're using video.js 6 syntax for the #addChild function. The indexopt (4) wasn't available when originally built, so this line is responsible for placing the theater mode button just before the fullscreen button:
https://github.com/jgubman/videojs-theater-mode/blob/master/src/videojs.theaterMode.js#L49
Here's what it's supposed to look like:
video.js 6.2: https://jsfiddle.net/qwv0n9m3/2/
video.js 5.19: https://jsfiddle.net/qwv0n9m3/

Hey @jgubman - It turns out a skin I had wasn't completing before running yours, so the skin had the same line for two other buttons, and so they'd get priority since would run after the theater mode button.
The skin has since added a "finished" trigger, so I wait for that and then run the theatermode.
I used to have my expand player function inside this:
player.on('theaterMode', function(elm, data) {
    if (data.theaterModeIsOn) {
      expandtaplayer();
    } else {
     expandtaplayer();
    }

But it would run upon load every time, so deleted the above and just went with....
$(document).on('click', ".vjs-theater-mode-control-open,.vjs-theater-mode-control-close", function() {
			  expandtaplayer();
			  });

Since that single function checks whether expanded or not yet.
Cheers!
Ryan

You can see the theater mode button in action here: https://www.traileraddict.com/thor-ragnarok/feature-trailer


Cluster specific configuration built into image. This image could only be used in one specific cluster.

https://github.com/Microsoft/pai/blob/7c7065d878e64a4a9df2bc92ac24e0b360af7ae1/pai-management/src/watchdog/dockerfile.template#L39

should put this configuration in deployment of watchdog instead of hard coding in image.
Fix is on the way.


Feature Req: Tie Generated text to Keys

Per @brandonwillard 's suggestion, I'm adding a feature request to allow generated text to be tied to a variable for easy access; useful in the case where one prompt has multiple pieces being generated, and you want access to each.
guidance offers a feature that looks like this:
prompt = '''
Here's one sentence: {{gen "SENTENCE_1"}}
Now, another sentence: {{gen "SENTENCE_2"}}
'''
out = guidance(prompt)()

print(out['SENTENCE_1'])
# <prints what the LLM generated>

print(out['SENTENCE_2'])
# <prints the other sentence>

Already, outlines allows this from the generation side:
prompt = '''
Here's one sentence: [a-z]{0,50}
Now, another sentence: [a-z]{0,50}
'''

But the user would have to parse each sentence out themselves.
Python has a syntax that allows this for instance, perhaps we copy that?
pattern = r"(?P<day>\d{2})-(?P<month>\d{2})-(?P<year>\d{4})"
text = "The date is 25-12-2021"
match = re.search(pattern, text)

edit: upon experiment, that date pattern already works great with outlines and generates a valid(ish) date. Our regex parser already respects the naming syntax then, apparently!

@freckletonj thank you for opening an issue! Would you mind moving your message to #305 so we can consolidate requirements there?

This is #305, do you mean add it to #182? I've left a comment over there: https://github.com/outlines-dev/outlines/issues/182#issuecomment-1741672594

Yes sorry 😅


Not able to predict

File "predict.py", line 96, in
main(args)
File "predict.py", line 87, in main
boxes = yolo.predict(image)
File "/content/drive/FLUX/keras-yolo2/frontend.py", line 462, in predict
image_h, image_w, _ = image.shape
AttributeError: 'NoneType' object has no attribute 'shape'
I have this error when I try to predict the image in some folder. Also how can I know the training is completed in my case I started training after 1 epoch its not going further

This error shows when you gave wrong path to image


Port nextcloud server patch to 24-stable branch

As discussed in today's meeting

Can I know more about this issue?

Where is this branch? I could not find it in [https://github.com/pondersource/server](Nextcloud server) or in [https://github.com/pondersource/nc-sciencemesh](Sciencemesh app) :(

I found this branch on Original Nextcloud repository. Is it true?

I don’t think it’s necessary to build nextcloud/server, see https://github.com/cs3org/ocm-test-suite/blob/main/servers/nextcloud/Dockerfile
@mrvahedi68 can you post the link here that told you to build nextcloud/server?

When I try to make Nextcloud I got ERROR in Cannot find module 'eslint'
I install eslint separately but error is the same:

changed 111 packages, and audited 112 packages in 16s```

  26 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
    mrv@mrv-pc:~/Desktop/Projects/ocm-test-suite/nextcloud$ make
    rm -rf dist
    make: Circular dev-setup <- all dependency dropped.
npm run build

><EMAIL_ADDRESS>build
> NODE_ENV=production webpack --progress --config webpack.prod.js

assets by status 9.66 MiB [cached] 51 assets
orphan modules 1.9 MiB [orphan] 1237 modules
runtime modules 173 KiB 495 modules
built modules 15.8 MiB [built]
  modules by path ./node_modules/ 13.2 MiB 1352 modules
  modules by path ./apps/ 1.78 MiB
    javascript modules 1.74 MiB 147 modules
    asset modules 32.8 KiB 20 modules
  modules by path ./core/ 797 KiB
    javascript modules 783 KiB 40 modules
    asset modules 14.5 KiB 5 modules
  modules by mime type image/gif 2.4 KiB
    data:image/gif;base64,R0lGODlhAQABAIAA.. 92.3 bytes [built] [code generated]
    data:image/gif;base64,R0lGODlhKAAoAIAB.. 2.31 KiB [built] [code generated]
  util (ignored) 15 bytes [built] [code generated]
  util (ignored) 15 bytes [built] [code generated]

ERROR in ./node_modules/linkify-string/dist/linkify-string.module.js 1:0-46
Module not found: Error: Can't resolve 'linkifyjs' in '/home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkify-string/dist'
resolve 'linkifyjs' in '/home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkify-string/dist'
  Parsed request is a module
  using description file: /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkify-string/package.json (relative path: ./dist)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkify-string/dist/node_modules doesn't exist or is not a directory
      /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkify-string/node_modules doesn't exist or is not a directory
      /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules
        single file module
          using description file: /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/package.json (relative path: ./node_modules/linkifyjs)
            no extension
              /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkifyjs doesn't exist
            *
              /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkifyjs* doesn't exist
            .js
              /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkifyjs.js doesn't exist
            .vue
              /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkifyjs.vue doesn't exist
        /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/linkifyjs doesn't exist
      looking for modules in /home/mrv/Desktop/Projects/ocm-test-suite/node_modules
        single file module
          using description file: /home/mrv/Desktop/Projects/ocm-test-suite/package.json (relative path: ./node_modules/linkifyjs)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /home/mrv/Desktop/Projects/ocm-test-suite/node_modules/linkifyjs doesn't exist
            *
              Field 'browser' doesn't contain a valid alias configuration
              /home/mrv/Desktop/Projects/ocm-test-suite/node_modules/linkifyjs* doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /home/mrv/Desktop/Projects/ocm-test-suite/node_modules/linkifyjs.js doesn't exist
            .vue
              Field 'browser' doesn't contain a valid alias configuration
              /home/mrv/Desktop/Projects/ocm-test-suite/node_modules/linkifyjs.vue doesn't exist
        /home/mrv/Desktop/Projects/ocm-test-suite/node_modules/linkifyjs doesn't exist
      /home/mrv/Desktop/Projects/node_modules doesn't exist or is not a directory
      /home/mrv/Desktop/node_modules doesn't exist or is not a directory
      /home/mrv/node_modules doesn't exist or is not a directory
      /home/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
<EMAIL_ADDRESS>2:64455-64480
 @ ./apps/user_status/src/menu.js 28:0-59 48:30-36

ERROR in Cannot find module 'eslint'
Require stack:
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/eslint-webpack-plugin/dist/getESLint.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/eslint-webpack-plugin/dist/linter.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/eslint-webpack-plugin/dist/index.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/eslint-webpack-plugin/dist/cjs.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/webpack.common.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/webpack.prod.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/webpack-cli/lib/webpack-cli.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/webpack-cli/lib/bootstrap.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/webpack-cli/bin/cli.js
- /home/mrv/Desktop/Projects/ocm-test-suite/nextcloud/node_modules/webpack/bin/webpack.js

webpack 5.72.1 compiled with 2 errors in 196918 ms
make: *** [Makefile:17: build-js-production] Error 1

For running nextcloud we need to run make command on root of the nextcloud source code. This is because of the missing JavaScript packages.

I could send token from Einstein to Marie and after accepting by Marie finally Einstein see her in his contacts.

OK, is the branch for this published and linked from the docs?


refactor(window): block main thread when creating a new window

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

Ref #4121 #3597


Usage of the HTTP-API

Hey,
is it possible to use the HTTP-Api, without using curl?
URL for relevant page?
What products and version are you using?
Where did you look before opening the issue?

@philippde04, yes, you can use any HTTP client that sends HTTP requests and returns HTTP responses. curl and wget are the most commonly used command line tools, but you can also use language-specific client libraries to integrate with the InfluxDB API.

Hey, thanks for your Answer.
I have one more Question. Is there a easy way to convert a QueryResult to a normal Javastructure like for every Column a Array?

Von: Scott Anderson<EMAIL_ADDRESS>Gesendet: Dienstag, 19. November 2019 17:07
An: influxdata/docs.influxdata.com<EMAIL_ADDRESS>Cc: philippde04<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [influxdata/docs.influxdata.com] Usage of the HTTP-API (#2515)
@philippde04https://github.com/philippde04, yes, you can use any HTTP client that sends HTTP requests and returns HTTP responses. curl and wget are the most commonly used command line tools, but you can also use language-specific client librarieshttps://docs.influxdata.com/influxdb/v1.7/tools/api_client_libraries/ to integrate with the InfluxDB API.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/influxdata/docs.influxdata.com/issues/2515?email_source=notifications&email_token=AMFWUFOU36OVROCAYA4252LQUQFMRA5CNFSM4JPC7LOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEOXEIQ#issuecomment-555577890, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMFWUFLQCGM6VKJSUAUKHRDQUQFMRANCNFSM4JPC7LOA.

There may be, I'm not sure. InfluxDB returns results in JSON, so it shouldn't be too hard to convert to the format you need, but it would have to be done client-side.


Use rowid instead id, allowing custom primary keys

This PR intent is improve liteseach making it rely in the rowid instead the id as it does actually. This will allow to work with custom TEXT primary keys and maybe clear the way for composite keys.
I've found that

"Whenever you create a table without specifying the WITHOUT ROWID option, you get an implicit auto-increment column called rowid. The rowid column store 64-bit signed integer that uniquely identifies a row in the table."
"If a table has the primary key that consists of one column, and that column is defined as INTEGER then this primary key column becomes an alias for the rowid column."

Knowing this, if we use the rowid instead the id column, it doens't matter what kind of primary key we use.
It also adds the possibility of set a custom primary key name, then this kind of setup will work:
class CreateUsers < ActiveRecord::Migration[7.1]
  def change
    create_table :users, id: false do |t|
      t.string :user_id, null: false, primary_key: true, default: -> { "lower(hex(randomblob(16)))" }
      t.string :name

      t.timestamps
    end
  end
end

class CreatePosts < ActiveRecord::Migration[7.1]
  def change
    create_table :posts, id: false do |t|
      t.string :post_id, null: false, primary_key: true, default: -> { "lower(hex(randomblob(16)))" }
      t.references :author, type: :string
      t.string :title
      t.text :content

      t.timestamps
    end
  end
end

class User < ApplicationRecord
  self.primary_key = "user_id"

  has_many :posts, foreign_key: :author_id

  include Litesearch::Model
  litesearch do |schema|
      schema.fields %w[ name ]
      schema.primary_key :user_id
  end
end

class Post < ApplicationRecord
  self.primary_key = "post_id"

  belongs_to :author, class_name: "User", primary_key: :user_id

  include Litesearch::Model
  litesearch do |schema|
      schema.fields %w[ title content ]
      schema.field :author, target: "users.name", primary_key: :user_id
      schema.primary_key :post_id
  end
end

Notes:

Test pass, but I didn't add this kind of scenario for sequel tests. Need some help there.
To get similar to work with the rowid, it does an extra query to read the rowid of the object. There is the alternative to "expose" the rowid attribute adding a default scope in the models when including litesearch, but I think too many things can go wrong doing it and one extra query just for running similar doesn't looks too bad.

I have looked into rowid stability as per my comment in #112  and it seems rowids are still not guaranteed to remain stable after a vacuum. see the quirks section of the rowid docs. Relying on rowid would mean users need to rebuild the index after any vacuum operation or they might get the wrong results.

I still think it is the right thing to do though, this will expand the support to any rowid table, and we could highlight the potential need to rebuild the index after the vacuum in the documentation


Mask Works Poorly with Partial Transparency

The mask algorithm seems to only mask at total transparency. The problem is that a lot (maybe most) images have some sort of dither or fade at the border to blend in better with the background (or provide a transparent shadow).

For many images it is probably better to mask out anywhere that there is partial transparency on the outside edge. However the inside edge would want to use the current logic still.

Came here to raise this exact issue with this exact image as well. Glad someone else wants to use the token border. For now this means i'll keep using tokenstamp.
Even if partial transparency was left as is, maybe a circular mask layer? Or per-layer masking.

Vtta-tokenizer is deprecated and replaced by vtta-tokens, which uses a rewritten algorithm that addresses this issue specifically.

Welcome back. 😃 Linking the new module (does not yet seem available for install) for anyone looking at this issue in the future: https://github.com/VTTAssets/vtta-tokens


envoy/lds: move mesh related filter chain code to its file

Description:
Moves code related to building outbound mesh filter chain
to the inmesh.go file which deals with in-mesh listener components.
Signed-off-by: Shashank Ram<EMAIL_ADDRESS>
Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2094 (010a1da) into main (f20c7b5) will decrease coverage by 0.11%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main    #2094      +/-   ##
==========================================
- Coverage   58.71%   58.59%   -0.12%
==========================================
  Files         144      144
  Lines        5920     5920
==========================================
- Hits         3476     3469       -7
- Misses       2442     2449       +7
  Partials        2        2

Impacted Files
Coverage Δ

pkg/envoy/lds/listener.go
27.08% <ø> (-11.76%)
:arrow_down:

pkg/envoy/lds/inmesh.go
85.18% <84.00%> (-1.03%)
:arrow_down:

pkg/catalog/catalog.go
77.41% <0.00%> (-22.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20c7b5...010a1da. Read the comment docs.


Uses values from constants in documentation

There were some discrepancies between the code documentation and the actual values. This suggested pattern will prevent that, or at least make it obvious to update or catch in PRs by having the summary close to the actually value.
This is how it looks after:

Microsoft Reviewers: Open in CodeFlow

/azp run


CSS NETWORKING - Added TLS 1.3 to Edgio SKUs

Added TLS 1.3 to the Edgio SKUs in the table to bring it in line with reality and this doc: https://learn.microsoft.com/en-us/azure/frontdoor/front-door-cdn-comparison#service-comparison

@duongau
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Clearer error handling in tests

This doesn't change the logic, but hopefully it makes the logic for handling errors a bit more obvious.

Needs a ticket for compliance reasons.

Took the liberty to push a couple of fixes. Hope that was okay.

Thank you!


High vulnerabie dependency found when installing the package

I received the message below when run 'npm install truncate-html@latest'
css-what  <5.0.1
Severity: high
Denial of Service - https://npmjs.com/advisories/1754
fix available via npm audit fix --force
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/cheerio/node_modules/css-what
css-select  <=3.1.2
Depends on vulnerable versions of css-what
node_modules/cheerio/node_modules/css-select
cheerio  0.19.0 - 1.0.0-rc.3
Depends on vulnerable versions of css-select
node_modules/cheerio
truncate-html  >=0.0.2
Depends on vulnerable versions of cheerio
node_modules/truncate-html

css-what is an indirect dependency of cheerio, which is the only dependency of truncate-html.
truncate-html is using<EMAIL_ADDRESS>by now, and  cheerio's latest version 1.0.0-rc.10 has removed css-select, that should fix this issue.
I'll try to update to latest stable release of cheerio when it's officially available.
Thanks for your feedback.

any updates @oe ?

Sorry for the delay. cheerio is still in beta, I'll try to make a beta release based on its latest beta release in the next few days.

Hey, any idea on when you'll release this version plz ?

By this weekend, stay tuned

I've just released a beta version, you guys can install it via yarn add truncate-html@beta
There are several changes:

no vulnerabilities

cheerio can now  handle CJK characters correctly
if you are using custom cheerio instance with this library, you should set the third parameter of cheerio.load to false  to get rid of extra wrappers, see load for details.
better support for typescript

check the  update-cheerio branch for code changes

just released a stable version v1.1.0


Feature request: Fixed nodes per move

I would really like to see support for cutechess "nodes=N" mode in Lakas.
Reason:
I found out that training with a fixed depth doesn't work. With fixed depth training I always get parameter sets where the engines runs in a lot of fail-high/fail-lows (which gives many nodes while staying inside the max depth) while playing real games with real time control with this parameter set you just don't get the needed depth and fail badly.
I could believe that training with fixed nodes works better while still avoiding real time controls and the related inaccuracy by CPU load etc.

There is new v0.29.2 that support --nodes. It also supports float param values. --hash is now removed. Hash setting can be done in --common-param.

Great! Will test soon. Thanks.

Seems to work as expected.


template the erase_if and export_batch_if API

APIs like erase_if and export_batch_if use function pointer to enable multiple policies to match the keys in table. But It can easily lead to issues like memory access error, misaligned address(#125), performance downgrade.
This PR change the APIs with approach of Templating which avoid issues above.

There is a trade-off issue with constructing PredFunctor inside or outside the API, which the former is fast and the latter can more flexibly manipulate the behavior of the functor.

/blossom-ci

Hi @Lifann, please drop the commit in the head and rebase on the master. Thank you!

/blossom-ci


voteproducer Ricardian Contract needs to include additional clause forbidding automated re-voting

the voteproducer action of the system contract needs, in its matching Ricardian contract, to forbid automatic re-voting (vs vote strength decay)
We will have a function of the voting system that older votes will be less powerful than more recently cast votes; a voter can refresh their vote and bring them to full strength by manually and deliberately re-affirming them.
It shall be a violation of the contract to use or allow to be used any automated system of refreshing a vote. All refreshes must be cast manually and intentionally by the voter.

We recognize that it is not possible to prove someone didn't automate the process, we merely wish to discourage the provable automatic voting via on-chain smart contracts.


Added Cricket player analysis

Cricket Player Analysis
Issue No. #885
This repository contains a Jupyter Notebook that performs an analysis of cricket players. The notebook aims to provide insights into player performances using various metrics and visualizations.
Overview
The Cricket player analysis.ipynb notebook is designed to analyze cricket players' performances based on provided data. The analysis includes statistical summaries, visualizations, and comparisons of player metrics to identify key patterns and trends.
Notebook Contents

Introduction: An overview of the analysis objectives and the dataset.
Data Loading: Code to load the cricket player data into a pandas DataFrame.
Data Cleaning: Steps to clean and preprocess the data.
Exploratory Data Analysis (EDA): Visualizations and statistical summaries of the data.
Player Performance Analysis: Detailed analysis of individual player performances using various metrics.
Comparative Analysis: Comparisons of players based on different criteria.
Conclusions: Summary of findings and insights gained from the analysis.

@bristiHalder do add a detailed Readme.md file describing the project.

@bristiHalder just 2 or 3 plots that's it?


track: method: should just require a simple promise not a response

to simplify integration and prevent integration mistakes, track: method should just expect a naive promise that either resolves or not, but should have no expectations as in what to expect in return

https://github.com/DePayFi/widgets/pull/70


DRP - Input Preset Name instead of Dates

I'd like to know if there is a built-in option to display custom date range presets as names instead of the actual start and end dates.

I'm not sure if I am getting this correct or this is still not figured out yet.
But you could set preset text the way you want -
const presets = [{
        text: moment('01/01/2018').format('l') + '-' + moment('01/01/2019').format('l'),
        start: moment('01/01/2018'),
        end: moment('01/01/2019')
      }]

@klapouchy this comment might be of some help to you. https://github.com/airbnb/react-dates/issues/930#issuecomment-354846359
I don't think the DRP can have an input like you've described above but the DayPickerRangeController can.


multiple definition of TFT Functions

Describe the bug
When I try to compile Arduino Examples, IDE said that this functions have multiple definitions
chrtbl_f72, chr_f72_20, chr_f72_2D, chr_f72_2E, chr_f72_30, chr_f72_31, chr_f72_32, chr_f72_33, chr_f72_34, chr_f72_35, chr_f72_36, chr_f72_37, chr_f72_38, chr_f72_39, chr_f72_3A, widtbl_f72, TFT_eSPI::readByte(), TFT_eSPI::pushBlock(unsigned short, unsigned int), TFT_eSPI::pushSwapBytePixels(void const*, unsigned int), TFT_eSPI::pushPixels(void const*, unsigned int), dmaHAL, TFT_eSPI::dmaBusy(), TFT_eSPI::dmaWait(), TFT_eSPI::pushPixelsDMA(unsigned short*, unsigned int), TFT_eSPI::pushImageDMA(int, int, int, int, unsigned short const*), TFT_eSPI::pushImageDMA(int, int, int, int, unsigned short*, unsigned short*), dc_callback(spi_transaction_t*), spi_host, TFT_eSPI::initDMA(bool), TFT_eSPI::deInitDMA(), spi,
I guess problem is that we have a little reference mess because
M5Display.h -> In_eSPI.h -> In_eSPI_ESP32_S3.h -> In_eSPI.h
To reproduce

Open any Example
Verify skecth

Expected behavior
Skecth should compile correctly.
Screenshots
No response
Environment

OS: Windows 10
IDE &IDE Version: Arduino IDE 1.6.x or Arduino IDE 2.x
Repository Version: First release (it doesn't have tag)

Additional context
Full error message
"
multiple definition of chrtbl_f72'; C:\...\Fonts\Font72rle.c:237: first defined here multiple definition of chr_f72_20'; C:...\Fonts\Font72rle.c:28: first defined here
multiple definition of chr_f72_2D'; C:\...\Fonts\Font72rle.c:32: first defined here multiple definition of chr_f72_2E'; C:...\Fonts\Font72rle.c:37: first defined here
multiple definition of chr_f72_30'; C:\...\Fonts\Font72rle.c:42: first defined here multiple definition of chr_f72_31'; C:...\Fonts\Font72rle.c:65: first defined here
multiple definition of chr_f72_32'; C:\...\Fonts\Font72rle.c:81: first defined here multiple definition of chr_f72_33'; C:...\Fonts\Font72rle.c:97: first defined here
multiple definition of chr_f72_34'; C:\...\Fonts\Font72rle.c:115: first defined here multiple definition of chr_f72_35'; C:...\Fonts\Font72rle.c:133: first defined here
multiple definition of chr_f72_36'; C:\...\Fonts\Font72rle.c:151: first defined here multiple definition of chr_f72_37'; C:...\Fonts\Font72rle.c:173: first defined here
multiple definition of chr_f72_38'; C:\...\Fonts\Font72rle.c:187: first defined here multiple definition of chr_f72_39'; C:...\Fonts\Font72rle.c:209: first defined here
multiple definition of chr_f72_3A'; C:\...\Fonts\Font72rle.c:231: first defined here multiple definition of widtbl_f72'; C:...\Fonts\Font72rle.c:10: first defined here
multiple definition of TFT_eSPI::readByte()'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:96: first defined here multiple definition of TFT_eSPI::pushBlock(unsigned short, unsigned int)'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:254: first defined here
multiple definition of TFT_eSPI::pushSwapBytePixels(void const*, unsigned int)'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:306: first defined here multiple definition of TFT_eSPI::pushPixels(void const*, unsigned int)'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:395: first defined here
multiple definition of dmaHAL'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:38: first defined here multiple definition of TFT_eSPI::dmaBusy()'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:652: first defined here
multiple definition of TFT_eSPI::dmaWait()'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:672: first defined here multiple definition of TFT_eSPI::pushPixelsDMA(unsigned short*, unsigned int)'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:689: first defined here
multiple definition of TFT_eSPI::pushImageDMA(int, int, int, int, unsigned short const*)'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:721: first defined here multiple definition of TFT_eSPI::pushImageDMA(int, int, int, int, unsigned short*, unsigned short*)'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:752: first defined here
multiple definition of dc_callback(spi_transaction_t*)'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:841: first defined here multiple definition of spi_host'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:55: first defined here
multiple definition of TFT_eSPI::initDMA(bool)'; C:\...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:\...\src\utility\In_eSPI_ESP32_S3.cpp:853: first defined here multiple definition of TFT_eSPI::deInitDMA()'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:899: first defined here
multiple definition of `spi'; C:...\M5AtomS3-main\utility\In_eSPI.cpp.o:c:...\src\utility\In_eSPI_ESP32_S3.cpp:31: first defined here"
Issue checklist

[X] I searched for previous reports in the issue tracker
[X] My report contains all necessary details

Would you like to use PlatformIO and one more try?

Fixed https://github.com/m5stack/M5AtomS3/commit/3fa7452ef0e8047c4d70cd2444c96cebbfa2538c


Allow admin to pause/unpause subdao

Also fixed some typos and removed unused msg.rs from dao-dao-core
#737

also now that i think of it, i'm not sure how i feel about the fact that pausing / unpausing can be done by different parties. don't have a solution off the top of my head right now, but something to think about.

also now that i think of it, i'm not sure how i feel about the fact that pausing / unpausing can be done by different parties. don't have a solution off the top of my head right now, but something to think about.

Had similar thoughts initially, but eventually warmed up to it as a nice change that Neutron introduced. This feature is most relevant in the context of SubDAOs. For DAOs without an admin, nothing changes. As a parent DAO is in full control of its SubDAOs, it makes sense that that control should also extend to pausing and unpausing a SubDAO.
For example, the Juno Charter has departments that may become inactive due to lack of members or activity. Rather than having to do all the work of moving around treasuries, vesting, etc., the SubDAO can simply enter a paused state until the parent DAO decides what to do with it.
The Parent DAO (admin) can already pause a SubDAO, I think it is useful and safest to allow them to unpause it. To be clear there is only one party that can unpause it, and that is the Parent DAO. Otherwise, nothing changes.

that makes sense!

this is really interesting; i have some thoughts! sorry for the long ass brain dump but i want to make sure we know exactly what we're doing, and this is me working it out out loud 😁
both allowing the parent DAO and DAO itself to bypass the pause, AND moving the paused check to execute_proposal_hook, effectively change the behavior of what pause is
before: "lock contract, frozen until expiration or forever if no expiration set"
after: "prevent proposals from being able to execute anything"
interestingly, proposals can still be created and voted on. they just won't be executable until the DAO is unpaused. i think this is fine, and we can disable proposal creation in the UI while paused to enforce the expected behavior that you shouldn't be creating proposals in a paused DAO.
our goals (what we want from pause):

ensure DAO or parent DAO can pause the DAO in case of emergency
ensure DAO or parent DAO can indefinitely lock the DAO, likely upon DAO death
ensure parent DAO can unpause a paused DAO
ensure parent DAO can operate on the DAO while paused (in order to rescue assets, update membership, etc.)

all of these are achieved by both allowing the parent and DAO itself to call execute while paused (and no one else), AND moving the pause logic to the proposal execution hook.
something else to consider though: authz allows an account to execute on behalf of another account. if the DAO has authorized (authz granted) a wallet the authority to do something as the DAO, there is no way for us to prevent action being taken while paused, since the wallet authz executes as the DAO itself. we cannot prevent the wallet from updating membership, for example, since the voting module would allow that if it comes from the DAO when authz executed by the wallet. we also couldn't prevent the wallet from calling messages on the DAO itself, IFF we allow the DAO to execute messages on itself (which we have to allow if we want to let the parent tell the DAO to execute messages while paused, like to add/remove a voting or proposal module). now, it'd be very silly for a DAO to give generic authz power on or as the DAO to a wallet—that effectively sets them as admin, so maybe it's not a case we really need to design for, but we should definitely know how it will interact with this pause logic. most likely, DAO-given authz will be for very specific actions, like trading on a DEX or managing staking. in these instances, we can't do anything about them anyways, and the DAO/parent needs to know to revoke any outstanding authz grants when they go to pause. that is something the UI can help solve, and there's nothing the contracts can do about it either way. additionally, a DAO may want to give a trusted wallet or DAO (maybe a security SubDAO) the ability to pause/unpause using authz, so in all cases we must allow both the parent DAO and DAO itself to bypass the pause and execute things, as long as the proposal hook is blocked.
so the question really is: should pausing simply mean halting the governance process (by disallowing proposal module execution)? i think that sounds right, but now i'm curious what @0xekez had in mind at the beginning when putting the auth logic at the top level like this. since there was no ability to unpause early and no ability for the parent to execute while paused, it acts as a complete emergency freeze until the expiration (or indefinitely if no expiration). if we want to give the parent DAO the power to execute as the DAO and on the DAO, which it seems like we do, we are changing what paused means—and we need to allow the parent DAO to execute at least execute_admin_msgs as well as the DAO itself to execute anything (so the parent DAO can use execute_admin_msgs to update config, voting modules, etc.).
it seems that both keeping the paused logic in the top-level execute function (with the addition that the parent and DAO itself can still execute anything) and simply moving the paused logic to the execute_proposal_hook function have the same security guarantees.
wdyt @ismellike @JakeHartnell @bekauz ?

one more doomer thought regarding the authz revoking above:
the number of things that we need to consider when adding features like this makes me somewhat paranoid of getting to the point where adding something new will require us explicitly addressing numerous other features previously added without considering something like this. not sure if this constitutes feature creep, internal dependency hell (is that a thing?), or something else, but i think you get what i mean. veto feature was giving me similar feelings at the start, but ended up being quite encapsulated.

@NoahSaso could we revoke all authorizations on pause? should we? just pondering here.

nope 🤩
i don't think we can force the DAO to revoke all authorizations on pause without adding some way to register all of the authorizations that already exist. even if we did that, i suspect we'd run into gas limit issues if too many authorizations had been granted, thereby preventing pausing.
instead, this is something we should surface in the UI when attempting to pause. we can display all outstanding authorizations to make it clear that certain executions will still be possible, and even prompt to add actions to revoke them all in the same proposal.

one more doomer thought regarding the authz revoking above:
the number of things that we need to consider when adding features like this makes me somewhat paranoid of getting to the point where adding something new will require us explicitly addressing numerous other features previously added without considering something like this. not sure if this constitutes feature creep, internal dependency hell (is that a thing?), or something else, but i think you get what i mean. veto feature was giving me similar feelings at the start, but ended up being quite encapsulated.

yeah... i think we are choosing to play the game on hard mode here. we can't avoid this problem if we want to add features. we should strongly seek to solve problems without modifying the core contract when possible, but pause has to be done directly like this. i mean, pause should really be the only feature that has to be implemented so bluntly like this. most other features have to do with proposal and voting modules.
we should be paranoid. we're building smart contracts that give the users full power to change anything about the contract and its relationship to other accounts. most other contracts aren't susceptible to this because they don't allow generic message executions, but we're basically creating a passthrough contract with some wrapper logic. i think this is the best we can do 🤷🏻♂

alright @ismellike, i think we're good to go on moving the paused check back to the beginning of the execution function, and skipping it if the sender is the admin or the DAO itself :D

seems like you need to recreate the schema and then the linter will pass


Move nix files into a nix directory

The top level directory is getting quite cluttered with nix files. Even more so if my module pr gets merged.
It may make sense to move more files into a nix/ directory.
One downside i can see is that having the default.nix (for the package) and the shell.nix for developing inside the nix folder would make it more cumbersome for non flake users.
However, this repo is only packaged in flakes at the moment so most/all of the people that would utilize these files can do so through the flake.
As @diniamo is the one who implemented all the nix things until now he might have an opinion about this.

No, I prefer to have it this way, especially until we don't have a home-manager module.
I imagine there might be edge cases where having the package as defaul.nix, and the shell as shell.nix is helpful.

Ah, your pr adds the home-manager module... well I'd prefer to have only that in a separate directory.

Sounds good :)

closed by #15


Adding new pages to label document

I am using python-docx to automate the filling in of cells of a label template which I open in python-docx. What I need to do is add a page containing a table that matches the formatting of the original table on the first page of the template each time the number of cells is exceeded for the current page (this is normally done just by tabbing on the last cell of the page). I believe I can do this by adding a page_break then adding a table to new page (and setting the formatting), but I have not got the code to work so far.

This sounds like a topic best taken up on StackOverflow @ronyan1
Make sure you actually formulate your question before you post (above is a statement, not a question) and tag it with 'python-docx'.


Create a shared Constants file

ADAL/MSAL both communicate with STS/IDPs using essentially the same vocabulary of keywords, constants, headers, query params, etc.
Because the shared components will likely need to access these constants, we'll need to make the constants themselves common so as to avoid circular dependencies.

To name a few constants files with potential for code sharing:
ADAL

AuthenticationConstants
EventStrings

MSAL

Constants
EventConstants
HttpConstants
OAuthConstants

Partially completed in #17

Done


fix locale of arb files, #43

workaround for #43 : add a script to fix the @@locale value inside the arb files

that's where "fastlane" would be super important - in the meanwhile, please document the process

I added some doc in README.md and in the script.

what happens when the source is finally correct - already with the right "locale"? Does it still work? (I never used sed) (I'm rather an awk guy)

Then it does nothing. The script is just a regular expression to replace "@@locale" : "en" by "@@locale" : "fr_FR" (with fr_FR coming from the name of the file: intl_fr_FR.arb)

I hope the process is simple, because translating into 149 languages (with most of the time English sentences) looks like wasted energy - unless it's the same amount of work as for 3 languages

We have been using Crowdin to translate the OFF web site and apps, it works quite well. I think @teolemon generated the .arb files from CrowdIn only once 6 months ago, but if we synch them from CrowdIn again today, I'm guessing many more translations will be there. But the app is still going to evolve a lot, so we are likely to add / change a lot of strings. We can worry about translations later. I was just wondering why I was still having everything in English in the app while there was some translated data in the .arb files.


all: install and use SF Mono font

This is the same font used in Xcode and GitHub's file viewer.
https://developer.apple.com/fonts/

Example:


Dropdown sidebars

Hi,
Just wanted to know if it is possible to branch out side tabs on drop down menu in bootstrap as shown in the attached image. If so, then can you please guide me on how i can archive it

.

@alvinrahulchauhan Sub dropdown menus are not supported in Bootstrap 3 though they are relatively simple to add back via http://bootsnipp.com/snippets/featured/multi-level-dropdown-menu-bs3. This cannot and would not be supported by the bootstrap team though.
Also, for future reference per CONTRIBUTING.md please do not use the issue tracker for personal support requests. Stack Overflow (twitter-bootstrap-3 tag) or Slack, or IRC are better places to get help with these subjects.


Add WARN logs for slow requests

Reference: https://github.com/Azure/azure-sdk-for-java/issues/5130

@samvaity - do you mind providing more information on what is needed from the Azure Resource Manager(ARM) team, especially since the issue you referenced in the description is Closed.

Issue referenced is closed. I'd close this issue as well, please open a new one, and provide more information on what is needed from the Azure Resource Manager (ARM) team.


app dosn't run when add plugins in dependencies

After add plugins in dependencies flutter project not run and give below error
ERROR:/Users/amir/.gradle/caches/transforms-3/f59d0fe8a4989db0778358dd7ee2dcf1/transformed/lifecycle-livedata-core-2.8.0-runtime.jar: D8: java.lang.NullPointerException

Please upgrade PayTabs Flutter plugin to:
flutter_paytabs_bridge: ^2.6.12
Additionally, upgrade the Kotlin version to:
id "org.jetbrains.kotlin.android" version "1.9.23" apply false. You can find it in the android project directory in settings.gradle


Error running ./setTensorFlowEV.sh

Seems like there's no longer avro-1.8.0 version in the mirror so it fails to configure.
You need to make a tensorflow patch to tensorflow/workspace.bzl.
Find "avro_archive" and change url, sha256 and strip_prefix to this:
url = "http://www-us.apache.org/dist/avro/avro-1.8.1/cpp/avro-cpp-1.8.1.tar.gz",
sha256 = "6559755ac525e908e42a2aa43444576cba91e522fe989088ee7f70c169bcc403",
strip_prefix = "avro-cpp-1.8.1",

@kiyoon this URL is dead :(
I used this one:
url = "https://www.apache.org/dist/avro/stable/cpp/avro-cpp-1.8.2.tar.gz",
sha256 = "5328b913882ee5339112fa0178756789f164c9c5162e1c83437a20ee162a3aab",

I am still getting the following error  /mnt/abhi/tensorflow/tensorflow/contrib/avro/BUILD:13:1: no such package '@avro_archive//': Prefix avro-cpp-1.8.0 was given, but not found in the archive and referenced by '//tensorflow/contrib/avro:example_h'


SIGSEGV on startup of esdf/tsdf_server

When running the "Using the voxblox for planning" code, and only running the voxblox_node (removing "my_voxblox_planner"-node) the server dies after startup.
roslaunch -v voxblox_ros my.launch
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

... loading XML file [/opt/ros/melodic/etc/ros/roscore.xml]
... executing command param [rosversion roslaunch]
Added parameter [/rosversion]
... executing command param [rosversion -d]
Added parameter [/rosdistro]
Added core node of type [rosout/rosout] in namespace [/]
... loading XML file [/root/catkin_ws/src/voxblox/voxblox_ros/launch/room_cloud.launch]
Added parameter [/my_robot/voxblox_node/tsdf_voxel_size]
Added parameter [/my_robot/voxblox_node/tsdf_voxels_per_side]
Added parameter [/my_robot/voxblox_node/publish_esdf_map]
Added parameter [/my_robot/voxblox_node/publish_pointclouds]
Added parameter [/my_robot/voxblox_node/use_tf_transforms]
Added parameter [/my_robot/voxblox_node/update_mesh_every_n_sec]
Added parameter [/my_robot/voxblox_node/clear_sphere_for_planning]
Added parameter [/my_robot/voxblox_node/world_frame]
Added node of type [voxblox_ros/esdf_server] in namespace [/my_robot/]
started roslaunch server http://882c76a13c30:41967/

SUMMARY
========

CLEAR PARAMETERS
 * /my_robot/voxblox_node/

PARAMETERS
 * /my_robot/voxblox_node/clear_sphere_for_planning: True
 * /my_robot/voxblox_node/publish_esdf_map: True
 * /my_robot/voxblox_node/publish_pointclouds: True
 * /my_robot/voxblox_node/tsdf_voxel_size: 0.2
 * /my_robot/voxblox_node/tsdf_voxels_per_side: 16
 * /my_robot/voxblox_node/update_mesh_every_n_sec: 1.0
 * /my_robot/voxblox_node/use_tf_transforms: True
 * /my_robot/voxblox_node/world_frame: odom
 * /rosdistro: melodic
 * /rosversion: 1.14.10

NODES
  /my_robot/
    voxblox_node (voxblox_ros/esdf_server)

ROS_MASTER_URI=http://localhost:11311

process[my_robot/voxblox_node-1]: started with pid [227586]
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1606736459" if you are using GNU date ***
PC: @     0x7f3016ba2320 tf2_ros::Buffer::Buffer()
*** SIGSEGV (@0xa) received by PID 227586 (TID 0x7f3018814280) from PID 10; stack trace: ***
    @     0x7f3016e43040 (unknown)
    @     0x7f3016ba2320 tf2_ros::Buffer::Buffer()
    @     0x7f301845362f tf::Transformer::Transformer()
    @     0x7f30184633d6 tf::TransformListener::TransformListener()
    @     0x7f301780ea6b voxblox::Transformer::Transformer()
    @     0x7f301781a77f voxblox::TsdfServer::TsdfServer()
    @     0x7f30177da28f voxblox::EsdfServer::EsdfServer()
    @     0x7f30177dabde voxblox::EsdfServer::EsdfServer()
    @     0x55db14ab3c8a (unknown)
    @     0x7f3016e25bf7 __libc_start_main
    @     0x55db14ab3daa (unknown)
[my_robot/voxblox_node-1] process has died [pid 227586, exit code -11, cmd /root/catkin_ws/devel/lib/voxblox_ros/esdf_server -alsologtostderr pointcloud:=cloud_pcd voxblox_node/esdf_map_out:=esdf_map __name:=voxblox_node __log:=/root/.ros/log/bd50908a-31b3-11eb-95ce-0242c0a8b002/my_robot-voxblox_node-1.log].
log file: /root/.ros/log/bd50908a-31b3-11eb-95ce-0242c0a8b002/my_robot-voxblox_node-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete
done

Is it possible, that I somehow messed up the build? I remember changing a non-capital t to a capital T (guess in one of the dependencies) on transformer related code,  in order to get the build succeed, I just don't remember exactly :-/...maybe someone can make sense of the above output?!
Happy to share more env/config info
EDIT: sim.launch works fine
I made sure to ingest a pointcloud and adjust the topic in remap
EDIT 2:
when downloading the basement dataset and running basement.launch, I will get a 'FATAL" Time is out dual 32-bit range from rosbag/play and the same "*** Aborted at [timestamp} (unix time) try "date -d @[execution timestamp]" if you are using GNU date"

turned out that completely rebuilding (Docs: "Installation") solved the issue for me


fix: gpg import

This commit removes the obsolete --allow-secret-key-import option from the gpg call, and
adds --batch to prevent errors when importing the secret key.
Before fix:
importing gpg key...
gpg: directory '/root/.gnupg' created
gpg: keybox '/root/.gnupg/pubring.kbx' created
gpg: /root/.gnupg/trustdb.gpg: trustdb created
gpg: key FFFFFFFFFFFFFFFF: public key "John Doe<EMAIL_ADDRESS>imported
gpg: key FFFFFFFFFFFFFFFF/FFFFFFFFFFFFFFFF: error sending to agent: Inappropriate ioctl for device
gpg: error building skey array: Inappropriate ioctl for device
gpg: error reading '/secrets/key.gpg': Inappropriate ioctl for device
gpg: import from '/secrets/key.gpg' failed: Inappropriate ioctl for device
gpg: Total number processed: 0
gpg:               imported: 1
gpg:       secret keys read: 1

After fix:
importing gpg key...
gpg: directory '/root/.gnupg' created
gpg: keybox '/root/.gnupg/pubring.kbx' created
gpg: /root/.gnupg/trustdb.gpg: trustdb created
gpg: key FFFFFFFFFFFFFFFF: public key "John Doe<EMAIL_ADDRESS>imported
gpg: key FFFFFFFFFFFFFFFF: secret key imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg:       secret keys read: 1
gpg:   secret keys imported: 1
/root/.gnupg/pubring.kbx
------------------------
sec   rsa3072/FFFFFFFFFFFFFFFF 2021-04-08 [SC]
      FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF
uid                 [ unknown] John Doe<EMAIL_ADDRESS>ssb   rsa3072/FFFFFFFFFFFFFFFF 2021-04-08 [E]

🚀


README

README
User Story
As a Boot Camp Student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the pre-work project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

Completed


Micro interpreter test fails for FVP target

Try running
make -j$(nproc) -f tensorflow/lite/micro/tools/make/Makefile  CO_PROCESSOR=ethos_u OPTIMIZED_KERNEL_DIR=cmsis_nn TARGET=cortex_m_corstone_300 TARGET_ARCH=cortex-m55 test_micro_interpreter_test
It does not work.

@mansnils @advaitjain
Is this something that works before but stop working lately?  If it used to work, but stop working lately, then I think it may be related with https://github.com/tensorflow/tflite-micro/pull/798
Basically, the change in #898 requires a larger RAM than before and in #798, we have to increase the RAM for certain platforms.  The target that you listed is not in our CI and therefore not caught.
A couple of options:

increase your RAM configuration on your simulation (see #798 for how to do it)
I can also try to tuning down the RAM request  a bit.

Yes it used to work and yes I think it is related to what you are referring to. My intention was to disable it for now and then fix it later. However I recall you still run this platform as a nightly test, am I wrong?

Yes, this is run as a nightly build: https://github.com/tensorflow/tflite-micro/blob/6b82d6aca5a340f29ee630e4faf3c65112bfaaac/.github/workflows/cortex_m.yml#L52
Disabling helped the build be green and fixing the issue and reenabling sounds good to me.


grid test keeps failing once we disabled mocha retry in runTest.sh

I got 3 grid test failures in a row once I changed mocha retry 3 times to no retry in runTest.sh
https://travis.ibm.com/composer/kui/jobs/14647690

see the comment here: https://github.com/IBM/kui/blob/master/plugins/plugin-grid/src/test/grid/grid.ts#L167


"brew audit --online" shouldn't check endoflife.date for private taps

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
<EMAIL_ADDRESS>
Warning: You have the following deprecated, official taps tapped:
  Homebrew/homebrew-cask-fonts
Untap them with `brew untap`.

Warning: Unbrewed dylibs were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae and may need to be deleted.

Unexpected dylibs:
  /usr/local/lib/libMsgCom.dylib
  /usr/local/lib/libSysCtlCom.dylib
  /usr/local/lib/libwep_airdrop.dylib
  /usr/local/lib/libwep_burn.dylib
  /usr/local/lib/libwep_cbcarbon.dylib
  /usr/local/lib/libwep_cbcocoa.dylib
  /usr/local/lib/libwep_chrome.dylib
  /usr/local/lib/libwep_dutil.dylib
  /usr/local/lib/libwep_ff.dylib
  /usr/local/lib/libwep_icloud.dylib
  /usr/local/lib/libwep_mail.dylib
  /usr/local/lib/libwep_post.dylib
  /usr/local/lib/libwep_printer.dylib
  /usr/local/lib/libwep_screen.dylib

Warning: Found Ruby file outside myco/house tap formula directory.
(/opt/homebrew/Library/Taps/myco/homebrew-house/Formula):
  /opt/homebrew/Library/Taps/myco/homebrew-house/ghe_download_strategy.rb

Found Ruby file outside go-vela/vela tap formula directory.
(/opt/homebrew/Library/Taps/go-vela/homebrew-vela/Formula):
  /opt/homebrew/Library/Taps/go-vela/homebrew-vela/template.rb

Warning: Some installed formulae are missing dependencies.
You should `brew install` the missing dependencies:
  brew install openjdk@21

Run `brew missing` for more details.

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 4.3.6-2-g088afff
ORIGIN: https://github.com/homebrew/brew.git
HEAD: 088affff3f2a8e7bccd390ebd136fc2bfeb10ba2
Last commit: 30 hours ago
Core tap HEAD: aa51087b9aac8339df207b0a20d987f8b36f60dd
Core tap last commit: 12 days ago
Core tap JSON: 17 Jun 19:34 UTC
Core cask tap HEAD: 4b2b7a2eafa9023e2dc76db3ce8feb67c4ef31dc
Core cask tap last commit: 12 days ago
Core cask tap JSON: 17 Jun 19:34 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_BAT_THEME: DarkNeon
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 10
HOMEBREW_SORBET_RUNTIME: set
HOMEBREW_VERIFY_ATTESTATIONS: set
Homebrew Ruby: 3.3.3 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 15.0.0 build 1500
Git: 2.45.2 => /opt/homebrew/bin/git
Curl: 8.4.0 => /usr/bin/curl
macOS: 14.4.1-arm64
CLT: <IP_ADDRESS>.1.1708646388
Xcode: N/A
Rosetta 2: false

What were you trying to do (and why)?
When I run
brew audit --debug --verbose --tap myco/house --online --strict --display-cop-names --display-filename

where myco/house is an internal tap containing 99% internal packages and not pinned copies of homebrew/homebrew-core formulae, I noticed that the auditor checks https://endoflife.date for every package. None of these will ever succeed unless there's an accidental name collision with a package that EOLdate tracks, in which case the response will be confusingly inaccurate.
What happened (include all command output)?
In one of the formulae, called bifrost, I see this output:
==> Auditing Formula bifrost on os sonoma and arch arm
/usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Mozilla/5.0\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 10_15_7\)\ AppleWebKit/605.1.15\ \(KHTML,\ like\ Gecko\)\ Version/17.0\ Safari/605.1.15 --header Accept-Language:\ en --connect-timeout 15 --max-time 25 --retry 3 --retry-max-time 25 --dump-header - --output /private/tmp/20240618-81316-o7xuhh --location https://git.myco.com/someorg/bifrost
/usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.6-2-g088afff\ \(Macintosh\;\ arm64\ Mac\ OS\ X\ 14.4.1\)\ curl/8.4.0 --header Accept-Language:\ en --retry 3 --location https://endoflife.date/api/bifrost/0.json
/usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.6-2-g088afff\ \(Macintosh\;\ arm64\ Mac\ OS\ X\ 14.4.1\)\ curl/8.4.0 --header Accept-Language:\ en --retry 3 --location https://endoflife.date/api/bifrost/0.5.json

What did you expect to happen?
No accession of endoflife.date except for packages it tracks.
It seems like https://endoflife.date/api/all.json outputs that, so perhaps retrieve and cache that for the brew audit run or like 24 hrs, and only access endoflife.date if a package it has maps to one being audited.
I reckon exposing internal package names to endoflife.date makes security people uncomfortable, esp. when some may be particularly named instead of creatively so.
Step-by-step reproduction instructions (by running brew commands)
brew audit --debug --verbose --tap myco/house --online --strict --display-cop-names --display-filename

Would review a PR to make this only apply to official taps.


[Bug]: Inconsistent evaluations when enabling / disabling chunked_prefill?

Your current environment

The output of `python collect_env.py`
Collecting environment information...
 Here are two runs that I have:
Run 1
lm_eval \
    --model vllm \
    --model_args pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct,gpu_memory_utilization=0.6 \
    --tasks scrolls_narrativeqa_llama_16k \
    --gen_kwargs temperature=0 \
    --apply_chat_template \
    --limit 256 \
    --batch_size auto

With output:
vllm (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct,enable_chunked_prefill=False), gen_kwargs: (temperature=0), limit: 256.0, num_fewshot: None, batch_size: auto
|            Tasks            |Version|Filter|n-shot|Metric|   |Value |   |Stderr|
|-----------------------------|------:|------|-----:|------|---|-----:|---|------|
|scrolls_narrativeqa_llama_16k|      2|none  |     0|f1    |↑  |6.1901|±  |   N/A|

Run 2
lm_eval \
    --model vllm \
    --model_args pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct,gpu_memory_utilization=0.6,enable_chunked_prefill=False \
    --tasks scrolls_narrativeqa_llama_16k \
    --gen_kwargs temperature=0 \
    --apply_chat_template \
    --limit 256 \
    --batch_size auto

With output:
vllm (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct), gen_kwargs: (temperature=0), limit: 256.0, num_fewshot: None, batch_size: auto
|            Tasks            |Version|Filter|n-shot|Metric|   | Value |   |Stderr|
|-----------------------------|------:|------|-----:|------|---|------:|---|------|
|scrolls_narrativeqa_llama_16k|      2|none  |     0|f1    |↑  |17.0421|±  |   N/A|

The only difference is whether I disabled chunked prefill. But the results are drastically different. I think there might be something broken since chunked prefill should preserve the same output quality?
Side node: also using vllm gives me very different result than using hf backend (same task, same param, etc) which gives me a score of f1 = 22.3774.
Thanks a lot for helping!
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Just found this issue #9670. I also tried enforce_eager=True, which seems to close the gap quite a bit but not yet matching. Is this related to the cuda-graph problem?


ARROW-7894: [C++] Move preprocessor definitions from cmake files to arrow/config.h.cmake

Removes the need for add_definitions() calls which wrap cmake options, simplifying build configuration.
Some options have been renamed to accommodate this:

ARROW_ENABLE_TIMING_TESTS -> ARROW_WITH_TIMING_TESTS
ARROW_BUILD_BENCHMARKS_REFERENCE -> ARROW_WITH_BENCHMARKS_REFERENCE

Aside: do you think we may be moving toward an arrow/config.h header (for options that affect built libraries)?

We will need to move toward arrow/config.h, otherwise it forces users on using cmake/pkgconfig.

I'll add arrow/config.h.in, which will be configured/installed by DefineOptions similar to parquet_version.h. Users who wish to use !cmake can configure that header manually. Is there a place we put doc for !cmake users?

Perhaps there should be a default arrow/config.h which gets overridden by the generated one?

Probably not a candidate for moving to config.h:
parquet/CMakeLists.txt:135
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.9")
  add_definitions(-DPARQUET_USE_BOOST_REGEX)
  list(APPEND PARQUET_BOOST_LINK_LIBS ${BOOST_REGEX_LIBRARY})
endif()

I don't think I can assimilate the ARROW_STATIC macro either. It's not a project-wide option; it must be set when building a static library (and only when building a static library).

@fsaintjacques I only extracted the options for which I saw #ifdef blocks. I'll ensure that everything in DefineOptions.cmake is included.

@pitrou I seem to be hitting inconsistent linkage on Windows due to getting the macro ARROW_EXPORTING incorrect. I'm not familiar with unity builds, does any obvious fix come to mind?

I'm skeptical this has anything to do with unity builds. Chances are something in the PR broke the exporting logic, IMHO.

Closing since this has grown stale. Feel free to reopen again when the issues have been addressed


TypeError: fetch failed

TypeError: fetch failed
    at async SingleProductPage (./app/product/[productSlug]/page.tsx:26:24)
Cause: Error: read ECONNRESET
    at TCP.onStreamRead (node:internal/stream_base_commons:217:20)
    at TCP.callbackTrampoline (node:internal/async_hooks:130:17) {
  errno: -4077,
  code: 'ECONNRESET',
  syscall: 'read'

I adjusted the database according to myself, did the migrations and ran it, everything was working fine, there was no problem in the project, the database was working in Prisma Studio, I reset the computer and when I connected to the site again, I started getting this error and my database was gone. The interesting thing is that there is still data on the site, but it gives this error in some elements.

I understand. The data is still on the website because of caching, but something happened to the database. I don't know what could cause the database to disappear. If you find a solution to the problem, please feel free to post it here.

npx prisma migrate dev --name init
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db": MySQL database "singitronic_nextjs" at "localhost:3306"

Error: P1001: Can't reach database server at `localhost`:`3306`

Please make sure your database server is running at `localhost`:`3306`.

I get this error when i run "npx prisma migrate dev --name init " It related to database I'm trying to fix it right now

I fixed it. I didn't run the sql server lol.I wasn't even aware,thanks for the quick reply @Kuzma02


Credit Button

We should support credit button style.
In theory that should be all it takes to support credit flow, since we're entering/exiting the checkout flow at the same point, and the rest of the credit set-up is tokenized in the payment token, which we are agnostic to.

Need to involve the credit team to support Canceled transactions

This is now ready to push, targeted for this week.

Pushed.


[FEATURE-736] integrate ldap authentication

What is the purpose of the pull request
impletments FAETURE [#736] to integrate ldap authentication
Brief change log
(for example:)

format code in package org.apache.dolphinscheduler.api.security
add ldap config in application-api.properties,config use online mock ldap server
core logic in LdapAuthenticator(for user login ) and LdapService (for ldap auth)

Verify this pull request
This change added tests and can be verified as follows:
(example:)

Added LdapAuthenticatorTest to test authenticate.
Added LdapServiceTest to test ldap auth.
Change SecurityConfigTest  to SecurityConfigPassWordTest fro password auth.
Added SecurityConfigLDAPTest  fro ldapauth.
refactor authentication with ldap and password

Codecov Report

Merging #3743 into dev will decrease coverage by 0.02%.
The diff coverage is 37.86%.

@@             Coverage Diff              @@
##                dev    #3743      +/-   ##
============================================
- Coverage     39.98%   39.96%   -0.03%
- Complexity     2901     2908       +7
============================================
  Files           457      460       +3
  Lines         21665    21726      +61
  Branches       2637     2642       +5
============================================
+ Hits           8662     8682      +20
- Misses        12185    12229      +44
+ Partials        818      815       -3

Impacted Files
Coverage Δ
Complexity Δ

...nscheduler/api/security/impl/ldap/LdapService.java
5.40% <5.40%> (ø)
2.00 <2.00> (?)

...che/dolphinscheduler/api/service/UsersService.java
74.77% <42.85%> (+0.41%)
81.00 <1.00> (+1.00)

...uler/api/security/impl/ldap/LdapAuthenticator.java
87.50% <87.50%> (ø)
3.00 <3.00> (?)

...phinscheduler/api/security/AuthenticationType.java
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

.../dolphinscheduler/api/security/SecurityConfig.java
68.42% <100.00%> (+3.71%)
5.00 <0.00> (+1.00)

...duler/api/security/impl/AbstractAuthenticator.java
100.00% <100.00%> (ø)
8.00 <2.00> (?)

...r/api/security/impl/pwd/PasswordAuthenticator.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

...er/master/processor/queue/TaskResponseService.java
33.33% <0.00%> (-21.57%)
5.00% <0.00%> (-1.00%)

...rver/master/processor/queue/TaskResponseEvent.java
49.01% <0.00%> (-9.81%)
9.00% <0.00%> (-5.00%)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3942740...cd375d8. Read the comment docs.

Codecov Report

Merging #3743 into dev will decrease coverage by 0.02%.
The diff coverage is 37.86%.

@@             Coverage Diff              @@
##                dev    #3743      +/-   ##
============================================
- Coverage     39.98%   39.96%   -0.03%
- Complexity     2901     2908       +7
============================================
  Files           457      460       +3
  Lines         21665    21726      +61
  Branches       2637     2642       +5
============================================
+ Hits           8662     8682      +20
- Misses        12185    12229      +44
+ Partials        818      815       -3

Impacted Files	Coverage Δ	Complexity Δ
...nscheduler/api/security/impl/ldap/LdapService.java 5.40% <5.40%> (ø) 2.00 <2.00> (?)
...che/dolphinscheduler/api/service/UsersService.java 74.77% <42.85%> (+0.41%) 81.00 <1.00> (+1.00)
...uler/api/security/impl/ldap/LdapAuthenticator.java 87.50% <87.50%> (ø) 3.00 <3.00> (?)
...phinscheduler/api/security/AuthenticationType.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
.../dolphinscheduler/api/security/SecurityConfig.java 68.42% <100.00%> (+3.71%) 5.00 <0.00> (+1.00)
...duler/api/security/impl/AbstractAuthenticator.java 100.00% <100.00%> (ø) 8.00 <2.00> (?)
...r/api/security/impl/pwd/PasswordAuthenticator.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...er/master/processor/queue/TaskResponseService.java 33.33% <0.00%> (-21.57%) 5.00% <0.00%> (-1.00%)
...rver/master/processor/queue/TaskResponseEvent.java 49.01% <0.00%> (-9.81%) 9.00% <0.00%> (-5.00%)
... and 4 more
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3942740...cd375d8. Read the comment docs.

LdapService.java need Ldap service to test, the online demo ldap service is not stable for continue delivery.
so I didn't add LdapServiceTest.java to the pom file

dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java
Is this abstraction necessary?
这种抽象有没有必要？

if I don't refactor a AbstractAuthenticator , sonar will detect the duplicate and can not pass...

ok  i see😅😅😅发自我的iPhone------------------ Original ------------------From: geosmart<EMAIL_ADDRESS>Tue,Sep 15,2020 9:19 AMTo: apache/incubator-dolphinscheduler<EMAIL_ADDRESS>felix.wang<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Re: [apache/incubator-dolphinscheduler] [FEATURE-736] integrate ldapauthentication (#3743)
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java
Is this abstraction necessary?
这种抽象有没有必要？
if I don't refactor a AbstractAuthenticator , sonar will detect the duplicate and can not pass...
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838",
"url": "https://github.com/apache/incubator-dolphinscheduler/pull/3743#issuecomment-692402838",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Codecov Report

Merging #3743 (9084c88) into dev (e24e690) will increase coverage by 0.01%.
The diff coverage is 37.86%.

@@             Coverage Diff              @@
##                dev    #3743      +/-   ##
============================================
+ Coverage     43.17%   43.18%   +0.01%
- Complexity     3169     3177       +8
============================================
  Files           467      470       +3
  Lines         21668    21729      +61
  Branches       2621     2626       +5
============================================
+ Hits           9355     9384      +29
- Misses        11414    11447      +33
+ Partials        899      898       -1

Impacted Files
Coverage Δ
Complexity Δ

...nscheduler/api/security/impl/ldap/LdapService.java
5.40% <5.40%> (ø)
2.00 <2.00> (?)

...che/dolphinscheduler/api/service/UsersService.java
74.13% <42.85%> (+0.43%)
79.00 <1.00> (+1.00)

...uler/api/security/impl/ldap/LdapAuthenticator.java
87.50% <87.50%> (ø)
3.00 <3.00> (?)

...phinscheduler/api/security/AuthenticationType.java
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

.../dolphinscheduler/api/security/SecurityConfig.java
68.42% <100.00%> (+3.71%)
5.00 <0.00> (+1.00)

...duler/api/security/impl/AbstractAuthenticator.java
100.00% <100.00%> (ø)
8.00 <2.00> (?)

...r/api/security/impl/pwd/PasswordAuthenticator.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
3.00% <0.00%> (-1.00%)

...org/apache/dolphinscheduler/remote/utils/Host.java
13.43% <0.00%> (-2.99%)
5.00% <0.00%> (-1.00%)

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
18.00% <0.00%> (-1.00%)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24e690...9084c88. Read the comment docs.


🐛 BUG: wrangler dev fails with "Error while creating remote dev session:"

Which Cloudflare product(s) does this pertain to?
Wrangler
What version of Wrangler are you using?
2.8.0
What operating system are you using?
Windows
Describe the Bug
I run wrangler dev and get an error:
✘ [ERROR] Error while creating remote dev session: SyntaxError: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

      at JSON.parse (<anonymous>)
      at parseJSON
  (C:\Users\kjk\src\filestore\upload\node_modules\wrangler\wrangler-dist\cli.js:117213:17)
      at createPreviewSession
  (C:\Users\kjk\src\filestore\upload\node_modules\wrangler\wrangler-dist\cli.js:125000:51)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async start
  (C:\Users\kjk\src\filestore\upload\node_modules\wrangler\wrangler-dist\cli.js:127410:9)

My wrangler.toml:
name = "upload"
main = "src/index.js"
compatibility_date = "2023-01-21"

# workers_dev = true
route = { pattern = "upload.filestore.dev", zone_id = "7aca111cc4dd5c8af033246fba8d4e43", custom_domain = true }

[[r2_buckets]]
binding = "FILESTORE_BUCKET"
bucket_name = "filestore"
preview_bucket_name = "filestore-dev"

This is the log of workers dev --log-level debug >out.txt:
out.txt
The problem seems to be that it sends a request to https://filestore.dev/cdn-cgi/workers/preview/?s0=Ac9OfirVWz-O8NoRieYPFBJeb1kY0nry0pWlzllc3Hs9ARA9u-JNX2nDDadmhTBDw71VOzB3LYTXmiS6t8QD2vo1kbzjMChWprIYZgefVgRyCT1YKh5GlWai5N-jZrj8MX-_UXTDe7mThfavIjAXshWlo6ovRB-YuOO97P6JLuK2aiuPlGT115YPivCTEPQkt1CoMaX08rA5wkqacQwc9ohpPuTRbFeHtbN7jfcz_hEFK-bY5raNQM-7NaS944xI8wkr502KSDqr9D0WPdUr5r7yK8M93eFvqjuoge_AILclpriDxvbjVWbjyaNkyLuK2w but that returns an HTML page about "Invalid Workers Preview configuration" instead of (presumably) upload.filestore.dev (since my worker is configured to that custom domain).
The client should detect that error condition (getting HTML instead of JSON).
But also it should just work.

Fixed in https://github.com/cloudflare/workers-sdk/pull/2651


multiple lines via backslash

I'm new to elm and therefor reading the elm introduction.
In the section < Core Language - If Expressions > there is this example:
over9000 powerLevel = \
|   if powerLevel > 9000 then "It's over 9000!!!" else "meh"

And the following description:

Using a backslash in the REPL lets us split things on to multiple lines.

I did try that but only got the following error:
-- SYNTAX PROBLEM -------------------------------------------- repl-temp-000.elm

The = operator is reserved for defining variables. Maybe you want == instead? Or
maybe you are defining a variable, but there is whitespace before it?

3|   over9000 powerLevel = \
                         ^
Maybe <http://elm-lang.org/docs/syntax> can help you figure it out.

I'm getting the same error in your REPL online.

I think this question is better for http://elmlang.herokuapp.com/ or https://groups.google.com/forum/#!forum/elm-discuss. Maybe you have spaces before the definition, but I'd need more information to know. The folks on Slack and the mailing list are friendly and happy to help out. They can get you going, and if there's something wrong, they can help make an issue on the elm-repl repo


$sce issue with youtube.

while i am opening your demo page, all are ok. When i embed it into my project i got this issue. Error: [$interpolate:noconcat] Error while interpolating: http://www.youtube.com/embed/{{v}}{{querys}} Strict Contextual Escaping disallows interpolations that concatenate multiple expressions when a trusted value is required.  See http://docs.angularjs.org/api/ng.$sce http://errors.angularjs.org/1.5.0/$interpolate/noconcat?p0=http%3A%2F%2Fwww.youtube.com%2Fembed%2F%7B%7Bv%7D%7D%7B%7Bquerys%7D%7D

Thank you, but I am current no longer to maintain this project.
If you wish, welcome to any fork, pull-request, or etc.

Ok, i will checkup.


Module not found: Can't resolve '../ThirdParty/pako_inflate' in 'E:\react\react-cesium-demo\node_modules\cesium\Build\CesiumUnminified\Workers'

please what can i do?

@iamgithubym Our team doesn't officially support the react-cesium-demo.  If you make a comment in https://github.com/markerikson/cesium-react-webpack-demo @markerikson should be able to help you.  Thanks!


Win-Key resets scroll location

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.295]
Windows Terminal version (if applicable): Version: 0.3.2171.0

Steps to reproduce

Pick a shell (any shell) ✨
Run any commend (or just mash the enter key) that produces enough output to push the screen down (not sure what the technical phrase for this is).
Scroll back up to look at some portion of the output
Push the Win-key

Expected behavior
Terminal scroll position is not affected
Actual behavior
Terminal scroll position is returned to the current prompt location/line
Particularly annoying as trackpad scrolling is also broken

Awesome, thanks @frieb98 & @DHowett-MSFT !

That was all @freib98's work :smile:

I am having the exact same issue. Please help.  Terminal Version: 1.3.2651.0 Windows 10 2004


Allow custom thread init in AsyncIterator

Currently it isn't possible to use custom dataloaders with AsyncIterator unless they are part of the dataload module itself. The main problem is that there is currently no way to require the Lua modules containing the custom dataloaders in AsyncIterator's threads.
This PR introduces an additional constructor argument to AsyncIterator which allows the user to pass in a custom thread initialization function.
For example, let's say I have my own dataloader called NswDives. I can now wrap it with an AsyncIterator as follows:
require('diving.NswDives')
dataloader = dl.NswDives('/data/nsw-dives/')
dataloader = dl.AsyncIterator(dataloader, 2, nil, nil, function()
  require('diving.NswDives')
end)

For reference, omitting the custom thread init functions results in the following error:
FATAL THREAD PANIC: (read) /root/torch/install/share/lua/5.1/torch/File.lua:343: unknown Torch class <dl.NswDives>

@anibali Great idea. Thanks for PR!


CDN Installation

Is there a CDN installation for this library? The project I'm working on doesn't have a bundler and we're using CDNs as we transition towards React. Thanks for the great library btw!

Hey @poroia, sorry, but we don't have a CDN build currently. Marking this as a feature request.

@poroia So, why you can not use vanilla javascript in that case?


test of what happens in rebase and merge

no merge commit is created, the commits goes on top of the base branch


Add package swift file & fix compile error

I agree that it would be better to just have "Koala"
But since "koala" is actual repo name if dev would use "git clone" to get code to work locally there would be "koala" folder and for drag and drop folder name should be the same as package.
Maybe we could change repo name?

Can decide what to change, but I agree that is important to have consistency.

I agree that it would be better to just have "Koala"
But since "koala" is actual repo name if dev would use "git clone" to get code to work locally there would be "koala" folder and for drag and drop folder name should be the same as package.
Maybe we could change repo name?

Changed repo name to Koala

Thanks @fawkeswei , I updated package.swift


fix: 26178 Context menu does not close after user goes to the previous page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/26178
PROPOSAL: https://github.com/Expensify/App/issues/26178#issuecomment-1713463856
Tests

Open a chat
Send a message
Reply in thread of the message sent
Hold on the last sent message inside the thread (Or we can open the emoji picker)
Click on the back button
Verify that the context menu closes after user goes back to the previous page

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Open a chat
Send a message
Reply in thread of the message sent
Hold on the last sent message inside the thread (Or we can open the emoji picker)
Click on the back button
Verify that the context menu closes after user goes back to the previous page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/389668b5-cc0c-4006-8c1b-fcbeb0eddbce

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/d1d295fb-174b-4ba4-b4f8-f340d2d54d98

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/c2fd4674-687d-4403-9520-86bc5e968a7c

Desktop

https://github.com/Expensify/App/assets/113963320/01b3cc32-57c1-4c1a-b484-a8a021c22435

iOS

https://github.com/Expensify/App/assets/113963320/35312642-63d2-496d-98ea-140f0abe1523

Android

https://github.com/Expensify/App/assets/113963320/35312642-63d2-496d-98ea-140f0abe1523

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.72-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix very slow in some use cases, and EnhancedRenderLeaderLayer._theaterRectRelativeToLeader's localToGlobal takes a large portion in flamechart

Codecov Report

Merging #86 (5e4c4be) into master (86b189b) will increase coverage by 0.28%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   78.59%   78.87%   +0.28%
==========================================
  Files          10       10
  Lines         766      781      +15
==========================================
+ Hits          602      616      +14
- Misses        164      165       +1

Flag
Coverage Δ

main-tests
78.87% <88.23%> (+0.28%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lib/src/portal.dart
78.57% <0.00%> (ø)

lib/src/portal_target_theater.dart
77.77% <ø> (ø)

...ted_transform/flutter_src/rendering_proxy_box.dart
80.00% <93.75%> (+1.59%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Move unreleased schemas that are not expected to be worked to Unused folders

Diego, I think you can also move GeoModeler schema - it is an application specific schema for GeoModeler (ACDP) which was cancelled a while ago.


Add Support to SPM

please add support to the swift package manager.

Hi shshalom, I've taken scihant's excellent work on this library, made a SwiftUI version and released it as a Swift Package Manager Package https://github.com/Appracatappra/SwiftUIPanoramaViewer. Since I made so many changes that take it away from its initial design, I've released it as a new library instead of making a pull request on this one.

Added by #67


wandb.plots.ROC for multilabel classification

Is there any way to plot roc curve for multilabel classification using wandb.plots.ROC ?
format:
y_true = [[0, 1, 1], [1, 0, 1]]
y_pred = [[1, 1, 0], [1, 0, 0]]

Hey @awsaf49 , I'm not quite sure. Let me check with the team regarding this.

Hi @awsaf49, currently, the wandb.plots.roc_curve(y_true, y_pred) expects the following format:

y_true is a sequence of length N, where each entry is a class index
y_pred is a sequence of shape NxC where each row is the class probabilities for each class.

A simple example would be:
y_true = [0,1,2,0,1,2,0,1,2]
y_pred = [
    [0.1, 0.2, 0.0],
    [0.2, 0.4, 0.4],
    [0.3, 0.6, 0.1],
    [0.4, 0.1, 0.5],
    [0.5, 0.1, 0.4],
    [0.1, 0.1, 0.8],
    [0.2, 0.2, 0.6],
    [0.3, 0.4, 0.3],
    [0.4, 0.6, 0.0]
]

Since this format does not support multi-class classification today, a workaround would be to simply remap your predictions such that each row corresponds to a single class. Consider this converter function:
def convert(multi_true, multi_pred):
    t = []
    p = []
    for i, pred in enumerate(multi_pred):
        for clss in multi_true[i]:
            t.append(clss)
            p.append(pred)
    return t, p

In this case multi_pred is the same shape as y_pred before, but multi_true would look something like: [[0,1],[0,1],[1],[0,1,2],[0],[2],[0,2],[1,2],[2]] where each entry is a list of classes.
I think this will solve your problem in the short run, and we can log a ticket to support this natively. Please let me know (:
Thanks!


[C] Ignore resting subscribers when calculating publication image join position

If resting subscribers aren't ignored a new subscription can end up joining at a position in an invalid term, leading to bogus data and potential corruption of the rcv_position.

Xcode CI failure looks to be unrelated.

Hmm Java Topology Tests failing this time, looks unrelated again to my eye.

I pulled on this string and the issue went further. I've clean up the applicable cases.


[DPE-2765] Add timescaledb package

Issue
Add packed to support timescaledb plugin/extension

Solution

Added timescaledb-2-postgresql-14 package which contains timescaledb plugin/extension

Building time:
5m04.77s # before the PR
6m01.25s # after the PR
Snap size:
-rw-r--r-- 1 yevs yevs 181186560 Feb 15 14:27 charmed-postgresql_14.10_amd64.snap # before the PR
-rw-r--r-- 1 yevs yevs 266682368 Feb 15 14:36 charmed-postgresql_14.10_amd64.snap # after the PR

Hi @TakoB222 , thank you for the contribution!
@delgod , @7annaba3l : can we use foreign timescaledb binary? Should we PPA it first?

Just for the history, we are waiting for timescaledb package built in Canonical. (c) @7annaba3l

@TakoB222 we have updated timescaledb package with verified content and licenses OSI compliance (built with -DAPACHE_ONLY=1).
Please rebuild snap and re-check it to merge PR.
https://launchpad.net/~data-platform/+archive/ubuntu/postgresql-14-timescaledb
Tnx!

@TakoB222 we have updated timescaledb package with verified content and licenses OSI compliance (built with -DAPACHE_ONLY=1). Please rebuild snap and re-check it to merge PR.
https://launchpad.net/~data-platform/+archive/ubuntu/postgresql-14-timescaledb
Tnx!

Done


Name of subscription should be blurry

Name of subscription should be blurry in few of above screen shots of blades.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ccf20f6-c70a-8372-5764-534fea16e7f4
Version Independent ID: 40eeda07-3d7a-b064-3d10-0c9a1f1f2d72
Content: Use Azure portal to get started with Data Lake Storage Gen1
Content Source: articles/data-lake-store/data-lake-store-get-started-portal.md
Service: data-lake-store
GitHub Login: @nitinme
Microsoft Alias: nitinme

@jpchauhan
Thanks for the feedback! We are currently investigating and will update you shortly.

@nitinme we have a suggestion to take a look at blurring subscription names in the screenshots here:
https://docs.microsoft.com/en-us/azure/data-lake-store/data-lake-store-get-started-portal#create-an-azure-data-lake-store-account

In reviewing the article, this issue has been addressed, so I'm closing this PR. Thanks!