Unsafe identifier renames

Minifiers only rename variable/function/parameter bindings and not any other identifier like properties because it's almost impossible to guarantee the program still works then.
Example input file:
class A {
  get() {
    return document.querySelector("#foo");
  }
}

humanify output:
class MyClass {
  getElementById() {
    return dom.findElement("#foo");
  }
}

I think thats the only change necessary but it needs some testing:
https://github.com/jehna/humanify/blob/4dfe05e20f530a8919e6d1e9f89564be5bb874e0/src/openai/rename-variables-and-functions.ts#L16
- Identifier: (path) => {
+ BindingIdentifier: (path) => {

Or how about renaming all variables to something unique so it doesn't mix up minified ones and then supplying a list of binding names it is allowed to change in the prompt?
Also it can happen that a variable gets renamed but another one with the same name already exists in the scope, or the code gets split up in such a way that not all references are renamed.
Maybe use babel's scope-aware rename that also handles these conflicts (have to find a way of getting rid of the _ prefix): https://astexplorer.net/#/gist/7283141e13dab314521744603a95e9b7/05b11370db8d5ef257550b2916b87d6e72e4eb1d

Or how about renaming all variables to something unique so it doesn't mix up minified ones and then supplying a list of binding names it is allowed to change in the prompt?

I've laid out some of my thoughts on this concept in general, in the following issues/comments:

https://github.com/j4k0xb/webcrack/issues/21#issuecomment-1807290502 (and my later comments)
https://github.com/pionxzh/wakaru/issues/34#issuecomment-1807393509 (and my later comments)

Also it can happen that a variable gets renamed but another one with the same name already exists in the scope, or the code gets split up in such a way that not all references are renamed.

Off the top of my head, if it's not easily solved via tweaking the prompt, you could potentially have it do a 'refinement/feedback round' where you provide feedback to the LLM + get it to correct the issues (which could be repeated up to X times) eg.

The following variables were already defined in the scope, so we can't use the names you chose. Please choose a new name for them so that they don't clash:

X
Y
Z

copilot now has a similar feature: https://code.visualstudio.com/updates/v1_87#_rename-suggestions
worth looking into how they've done it

Release detailed here:

https://github.com/microsoft/vscode/releases/tag/1.87.0

https://github.com/microsoft/vscode/compare/1.87.0...1.86.2

Couldn't see any overly relevant commits in that range, but did find the following searching the issue manually:

https://github.com/microsoft/vscode/issues/206335
https://github.com/microsoft/vscode/issues/206498

Which lead me to this label:

https://github.com/microsoft/vscode/issues?q=is%3Aopen+label%3Arename+sort%3Aupdated-desc

And these issues, which sound like there are 'rename providers' used by the feature:

https://github.com/microsoft/vscode/issues/115354
https://github.com/microsoft/vscode/issues/183075

More docs about rename providers here:

https://code.visualstudio.com/docs/editor/editingevolved#_rename-symbol
https://code.visualstudio.com/api/references/vscode-api#:~:text=registerRenameProvider(
https://code.visualstudio.com/api/references/vscode-api#RenameProvider

RenameProvider
The rename provider interface defines the contract between extensions and the rename-feature.

prepareRename
Optional function for resolving and validating a position before running rename. The result can be a range or a range and a placeholder text. The placeholder text should be the identifier of the symbol which is being renamed - when omitted the text in the returned range is used.

provideRenameEdits
Provide an edit that describes changes that have to be made to one or many resources to rename a symbol to a different name.

https://code.visualstudio.com/api/language-extensions/programmatic-language-features

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename

Prepare Rename Request (:leftwards_arrow_with_hook:)
The prepare rename request is sent from the client to the server to setup and test the validity of a rename operation at a given location.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_rename

Rename Request
The rename request is sent from the client to the server to ask the server to compute a workspace change so that the client can perform a workspace-wide rename of a symbol.

https://vshaxe.github.io/vscode-extern/vscode/RenameProvider.html
https://github.com/vshaxe/vscode-extern/blob/master/src/vscode/RenameProvider.hx

Based on the above, and the release notes explicitly mentioning copilot, I suspect the implementation will be in the Copilot extension itself (which isn't open-source):

https://marketplace.visualstudio.com/items?itemName=GitHub.copilot
Downloading that gives GitHub.copilot-1.168.741.vsix, which seems to just be a .zip file:

⇒ file GitHub.copilot-1.168.741.vsix

GitHub.copilot-1.168.741.vsix: Zip archive data, at least v2.0 to extract, compression method=deflate

Though unzipping that and searching for provideRename didn't seem to turn up anything useful unfortunately.

Hi VS Code PM here,
A team member pointed me to this issue because it links to one of our VS Code issues.
I wanted to share that reverse engineering GitHub copilot is violating the general terms of the use agreement https://github.com/customer-terms/general-terms
Feel free to reach out to me if I can help with the general terms clarification<EMAIL_ADDRESS>Thank you
Isidor

@isidorn It's less about "reverse engineering GitHub copilot" and more about "trying to figure out where the 'rename suggestions' change mentioned in the release notes was actually implemented; and what mechanism 'integrates' it into VSCode'".
The above is assumptions + an attempt to figure that out; but if you're able to point me to the actual issue/commit on the VSCode side (assuming it was implemented there), or confirm whether it's implemented on the closed source GitHub Copilot extension side of things (if it was implemented there), that would be really helpful.
If it was implemented on the GitHub Copilot extension side of things, then confirming whether the VSCode extension 'rename provider' is the right part of the VSCode extension API to look at to implement a similar feature would be awesome.

@ulugbekna Awesome; thanks for pointing that out! Shall have a closer read :)

I renamed all variables to unique names, and then ran the unminify code, most of the stuff was unminified, but i still had some random code, which wasnts, so i added a check to only rename variables which are in the pattern of my naming convention, and instructed the same to GPT, solved the issue

Also it can happen that a variable gets renamed but another one with the same name already exists in the scope, or the code gets split up in such a way that not all references are renamed.

See also:

https://github.com/jehna/humanify/issues/67

Also it can happen that a variable gets renamed but another one with the same name already exists in the scope, or the code gets split up in such a way that not all references are renamed.

Off the top of my head, if it's not easily solved via tweaking the prompt, you could potentially have it do a 'refinement/feedback round' where you provide feedback to the LLM + get it to correct the issues (which could be repeated up to X times) eg.

The following variables were already defined in the scope, so we can't use the names you chose. Please choose a new name for them so that they don't clash:

X
Y
Z

Just made a similar suggestion for this pattern while debugging another issue, referencing it here for continuity:

The proper fix would be to use toIdentifier from @babel/types

@j4k0xb @jehna From a 2sec search I couldn't find rendered docs, but here's the relevant source for each:

isValidIdentifier: https://github.com/babel/babel/blob/a2025d7d695b0f3b0506f66225d6b15bcfa1cf6a/packages/babel-types/src/validators/isValidIdentifier.ts#L7-L25
toIdentifier: https://github.com/babel/babel/blob/a2025d7d695b0f3b0506f66225d6b15bcfa1cf6a/packages/babel-types/src/converters/toIdentifier.ts#L4-L26

toIdentifier definitely seems like a more robust approach than the current 'prefix with _' approach for sure.
Though I wonder if a 'proper fix' should also involve tweaking how we prompt for/filter the suggestions coming back from the LLM itself as well. Like instead of just forcing an invalid suggestion to be valid (with toIdentifier), we could detect that it's invalid (with isValidIdentifier) and then provide that feedback to the LLM, asking it to give a new suggestion; probably with some max retry limit; after which we could fall back to using the invalid suggestion run through toIdentifier, or log a warning and leave it un-renamed or similar.
Originally posted by @0xdevalias in https://github.com/jehna/humanify/issues/117#issuecomment-2381046017

Using BindingIdentifier instead of Identifier now, thanks for reporting this! Closing for now, should be fixed


Earlgrey: List of files which don't work with Verilator/UHDM

List of files which don't work in Earlgrey project with Verilator/UHDM.
Created according to information from the PR https://github.com/antmicro/verilator/pull/41

[ ] prim_generic_ram_1p.sv
[ ] ibex_counter.sv
[ ] prim_clock_gating.sv (silent error: %Error: Exiting due to 1 error(s))
[ ] prim_ram_1p.sv (prim_generic_ram_1p.sv fault)
[ ] ibex_icache.sv (requires prim_ram_1p.sv)
[ ] ibex_cs_registers.sv (ibex_counter.sv fault)
[ ] ibex_if_stage.sv (requires ibex_icache.sv)
[ ] ibex_core.sv (requires ibex_if_stage.sv ibex_cs_registers.sv prim_clock_gating.sv)

I created separate issues for every file.


disappear time fix.. not working?

its look like the "disappear time fix" its not working? https://github.com/favll/pogom/commit/a219d550a0050c6e57d9fb6d2a132211db83ef7d
i have severals icons, on top of each others, with +500 hrs disappear time... and here are others reports of this: https://www.reddit.com/r/pokemongodev/comments/4wqidn/pogom_is_back_with_the_fastest_map_available/?sort=new
maybe is a regional setting/format thing? im from latin america.
Thanks!

I actually see no new pokemons with 500h+ but I still see old from before fix ;/

@kamieniarz Drop your database or run a SQL query to remove them. (To drop just delete the .db file in your pogom directory)
Sent from my iPhone

On 15 Aug 2016, at 02:34, kamieniarz<EMAIL_ADDRESS>wrote:
I actually see no new pokemons with 500h+ but I still see old from before fix ;/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mwaraya did you do the same? The fix does not remove existing long spawn pokemon from before the fix from the database so they'll still remain on the map

Dupe


Change some docs to point to new location

Changing some stuff from fhunleth -> nerves-project, and also updating the readme to point to the hex.pm version of this package instead of directly at github.
If this isn't right, feel free to close.

Nice! You just took an item off my todo list that I didn't even post anywhere. Thank you so much for taking the time to update this.


Fix travis StackOverflow

=
<
<=
Don't check null values before ..

The problem is this: in operators, we use operators, and produce StackOverflow


expose configuration metadata for property 'feign.hystrix.enabled'

Codecov Report

Merging #40 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
+ Coverage     76.07%   76.24%   +0.16%
  Complexity      283      283
============================================
  Files            36       36
  Lines          1183     1183
  Branches        183      183
============================================
+ Hits            900      902       +2
+ Misses          206      204       -2
  Partials         77       77

Impacted Files
Coverage Δ
Complexity Δ

...bbon/HttpClientFeignLoadBalancedConfiguration.java
96.77% <0%> (+6.45%)
2% <0%> (ø)
:arrow_down:

I dont recall us adding this file anywhere else, and we have it documented.  I can see that this would add additional information in the IDE.  @spencergibb thoughts?


Shell-scripts

This program is what I was looking for,
and it works great using python, like the example,
but for some reason, it doesn't work with shell-scripts,
for example:
#!/bin/sh
echo "stdout"
echo "stderr" >&2
is all in white in the gnome-terminal (ubuntu 11.10 + gnome3)

I'm not sure if shell is using write() to print the messages. Let's check that.

Noticed the same problem. :/

Ok guys, I will strace it and we'll see what the problem is.

Possibly related: error messages from gcc (g++) is not catched and printed in red. Same system config. as OP.


add: andOPT (#345)

Logo from: https://github.com/andOTP/andOTP

Thanks for this. Please can you follow the template in https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md
We're trying to make the icon as small as possible.

I updated the SVG file. Can you please check if it's correct now

@ofarukcaki  thanks. Please can you look at the other files to see the template we're following. Your file has too much whitespace - and is named incorrectly.


Result form(s) for labs

Right now there is a generic result field for labs.  At some point we should support generation of result forms like the following:

The same technology solution we need for #90 is what we need here. Form-builder capability.

@taras this is another example of where a configurable form component is needed.

@tangollama again we should be able to use this addon for this: https://github.com/toddjordan/ember-cli-dynamic-forms

This feature should be implemented using the custom-form component available in the app:
https://github.com/HospitalRun/hospitalrun-frontend/wiki/Custom-Form-Component

This feature can be implemented by extending the custom forms feature to work with labs.  This means doing the following:

Add a new form type to https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/admin/custom-forms/edit/controller.js#L77-L82
Modify https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/labs/edit/route.js to setup custom forms for new objects.

  customForms: inject.service(),

  getNewData() {
    let customForms = get(this, 'customForms');
    let newData = {
      customForms: Ember.Object.create()
    };
    return customForms.setDefaultCustomForms(['lab'], newData);
  },

Add the following to https://github.com/HospitalRun/hospitalrun-frontend/blob/master/app/labs/edit/template.hbs:

{{custom-form-manager model=model formType="lab"}}

This will allow custom forms to be created and added to lab results.


Implement Navigation Controller Suffix rule

Resolves a swiftlint rule issue which produced a warning when NavigationController was used as a suffix for a subclass of UINavigationController.

Closed since the latest .swiftlint.yml moved to another location


[Usage]: Internvl2 takes forever to generate response

Your current environment
PyTorch version: 2.3.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
How would you like to use vllm
I used this script to start the server:
vllm serve OpenGVLab/InternVL2-8B --trust_remote_code --chat-template examples/template_chatml.jinja
request:

curl http://localhost:8000/v1/chat/completions
-H "Content-Type: application/json"
-d '{
"model": "OpenGVLab/InternVL2-8B",
"messages": [
{"role": "system", "content": "You are a helpful assistant."},
{"role": "user", "content": "Who won the world series in 2020?"}
]
}'

I got this in the log and the request never finish:
INFO 08-05 15:09:11 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 0.0 tokens/s, Running: 0 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.0%, CPU KV cache usage: 0.0%.

INFO 08-05 15:09:16 async_llm_engine.py:173] Added request chat-79478648dc964a728b624eae407d9e74.
INFO 08-05 15:09:16 metrics.py:406] Avg prompt throughput: 6.0 tokens/s, Avg generation throughput: 0.8 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.0%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:21 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 77.3 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.1%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:26 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 76.7 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.2%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:31 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 75.9 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.3%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:36 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 75.7 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.3%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:41 metrics.py:406] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 75.4 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.4%, CPU KV cache usage: 0.0%.
INFO 08-05 15:09:41 async_llm_engine.py:180] Aborted request chat-79478648dc964a728b624eae407d9e74.

cc @ywang96 @DarkLight1337
looks like the request runs for many tokens, and then being aborted.

cc @Isotr0py

Can you include the command that is used to launch the server?

@vestal-doublekuan Please make sure you set stop tokens in the parameters, otherwise the model will generate until the max context length. Feel free to look at the example here https://github.com/vllm-project/vllm/pull/6514#issuecomment-2258716685
The reason is that model repo itself has an issue about this and I don't think vLLM should be responsible for dealing with such issue.


Update to latest PACs and resolve the (numerous) resulting errors

Well, this ended up being a monumental task 😅 Hope I never need to do anything like this again.
Apologies for the massive PR but unfortunately it's not really possible to do this incrementally. I'm not sure how well this can reasonably be reviewed, but things that should be focused on (IMO) include:

Crypto peripherals

I had to rewrite the alignment helper to use pointers; based on my testing the crypto examples still seem to work, but I have not tested extensively across devices.

I2S and UART

Other PRs were merged while I was working on this, and I had to rebase on main. I believe I have not broken anything but some additional confirmation will be needed

I will try to do another review of my changes (though I'm a little tired of looking at all this 😂) and do some more testing on hardware.
No user-facing changes here, so I have not updated CHANGELOG.md.

The AES driver specifically probably needs some eyes on it. Example seems to work but not super confident in my changes.

I have self-reviewed this, and other than the aforementioned drivers I think everything should be okay.

Fixed the issue, based on my limited testing all crypto peripherals seem to be working now.

RSA on ESP32-C6 seems to be broken (just the multiplication_example function), guess I tested every other crypto peripheral 😅 Looking into it.
Will test on other chips as well.
EDIT: ESP32 and ESP32-S3 both fail in the same way, other crypto examples seem fine. Really strange issue.

Oh yeah, I had forgot. Since the alignment changed, we have to update the bit shifting.
https://github.com/esp-rs/esp-hal/pull/984/commits/df8a53ee4e01b76ad47d17afc7dea101062b2e8c fixes it.
I'll test those new changes with my implementation of bignum in esp-mbedtls

Considering that this PR is basically blocking all others, what would you think about merging as is and hammering out the remaining issues later?

I've done a few testing with my current bignum impl. Self-tests and sync_server works, but both will soft-lock if I try to run them in release mode. I cannot tell if it's my implementation or a bug in the driver, as it's doing this when also using  the current origin before the changes in the PACS.

Okay, thanks for the updates. If the behaviour is the same prior to these changes then I will just go ahead and merge this to get other PRs unblocked. At least we're not in any worse shape than we were before, we can address these issues in a subsequent PR.


Cant play any music when connected with iPad

Whenever I boot the RPi and i see the log on the dashboard, this comes up:
amixer: Unable to find simple control 'PCM',0
i ignore it, as i do not think it will affect anything. I connect my iPad(or whatever device i am using) to the bluetooth and start playing some music. when i hear nothing, i go back to the log and see a lot of errors in there. the errors are:
/usr/bin/bluealsa-aplay: Couldn't open PCM: No such device

ALSA lib pcm_dmix.c:1052:(snd_pcm_dmix_open) unable to open slave

/usr/bin/bluealsa: SBC decoding error: No such file or directory

/usr/bin/bluealsa: Missing RTP packet: 4157 != 4156

however, when i press pause on my ipad, the errors stop spitting out. all this time, there is absolutely no sound coming through the speakers, which i have tested. i really want to be able to use bluetooth with these speakers. please resolve this issue immediately.
From,
VoxelTek

Which Pi are you using?

I am using a Raspberry Pi 3B

Have you tried reinstalling?

Yes, multiple times. I have had the same error every time.

Are you using the on board jack or a external sound card (USB, GPIO, etc.)?

The on board jack.

Try it please with:
apt-get update && apt-get install --reinstall alsa-utils
(In the bluetooth-audio container which is aviable at the cloud dashboard)

Ok thanks

Try it please with balenaOS 2.38.0+rev1 production this was a solution in #47 which had the same errors.

@VoxelTek Did it help?

Unfortunately, I have been too busy to try any of these solutions. I should be able to try them in 2 days time.

Ok

Hey @VoxelTek, whenever you have time, please feel free to try again with the latest version of balenaOS as Alex suggested. Cheers!

I have a fresh install of this on a raspberry pi 3B and I'm experiencing the same issue.  I connected my galaxy phone through spotify connect and bluetooth and nothing comes out of the audio port.  same error logs.

@willenglishiv Can you give me the health test reports please?  You can get it at the bottom left of the dashboard.


Windows colours too dark

Would you be able to change the colors used on windows ? They are all the "dark" version of them, and it's pretty much eye killing...
The brighter versions are much more visible, as pointed out here: https://stackoverflow.com/questions/4053837/colorizing-text-in-the-console-with-c
Or alternatively, and easier way to specify your own colour rather than using std:cout ?

Actually, I believe it's already using the brightest version, the only exception being red, which looks better in my opinion.

Not really, this is how it looks on windows: https://prnt.sc/stfy0m
Some are bright, some are dark, very confusing to the eye.

Wow, it does look horrible on your screenshot. Here it is on my windows

Wow, it does look horrible on your screenshot. Here it is on my Windows 10.

Are you using Windows 7?
Try changing colors.h:46 to 12 and let me know if that looks better.

Yeah I told you, don't know why thought as it's default win 10.


Make "Explain how you've gained experience in law" required

What's included?
title
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Answer under "Relevant qualifications" > "Are you applying under Schedule 2(3)?" > Yes > "Explain how you've gained experience in law." should be required
Related permissions
Have permissions been considered for this functionality?

No permission changes required
Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@KoWeiJAC I'm getting Fb error when trying to login to the preview url:


Splitting the repository

Considering the functionality of parts of the current onyo codebase and issue #298 (which this issue is strongly related to, but not quite the same), I suggest splitting the codebase into two different packages. One package should focus on direct user interaction via the CLI, and the other should be the core onyo code that we currently call the API (or lib). For explanation purposes, I will call the former onyo-cli and the other onyo-core. This should naturally assist into decoupling categorically different aspects of the codebase as well.
The onyo-cli package
/onyo-cli
↪ /commands
  ↪ __init__.py
  ↪ base.py
  ↪ get.py
  ↪ cat.py
  ↪ ...
↪ /cli
  ↪ console.py
  ↪ shell_completion.py
↪ __init__.py
↪ _version.py
↪ main.py
/tests
/docs
setup.py
...

onyo-cli is a collection of scripts that can be accessed through a CLI. It is not a Python module because it is not intended to be imported by external code. This is the kind of package you would install via apt rather than pip, because it's a tool. It will have onyo-core and rich as dependencies.
The purpose of this package is to receive user input, pass it on to onyo-core, which then generates or retrieves the requested output and passes it back to this package, which then outputs it to console. Therefore, it should only contain CLI-related code such as argparsing, commands and subcommands, console printing (via rich), and shell completion.
The file structure above is an example of what this package could look like. Notably:

It has its own setup.py for declaring, among others, its dependencies and an entry point
It has its own _version.py separate from onyo-core

In addition to logically separating the code, it also streamlines the inclusion of new interfaces. For example, if there is a desire for a web interface then a separate onyo-web package can be created with onyo-core as a dependency. There is no need for this project to have anything to do with onyo-cli, nor do we want to extend our scope with more interface options. There is also no need to fork the onyo repository to make a web-interface compatible version, which may prevent the fork from receiving our updates.
The onyo-core Module
/onyo-core
↪ /skel
  ↪ ...
↪ onyo.py
↪ __init__.py
↪ _version.py
/tests
/docs
setup.py
...

The onyo-core module is a Python module that has no entry-point. It is a library called by onyo-cli to perform inventory management tasks. This package is an excellent fit for PyPi and should be installed using pip, because its only use is to be imported by external applications such as onyo-cli or the hypothetical onyo-web. Beyond logging this module does not interact with the console. Its classes and functions are called by other tools to generate output those tools then display.
Above is a very rough sketch of what this package would initially look like. We're keeping everything from lib/onyo.py but move it to the module root, and keep skel around as well. I have more suggestions on how to structure this package, but it's best we focus on one step at a time.
The advantage of having a core package is the extensibility of the tool altogether. A user could write an onyo-web package, but it is also possible to create a standalone importer to translate the contents of one inventory management system to onyo. All of this will add unwanted bloat to onyo, but as separate packages can live in their own spaces.
The full picture
This change is not just a logical separation making the codebase easier to interpret for other programmers, but it also streamlines the extension of functionality. Furthermore, both onyo-core and onyo-cli will have their own testing suites. Note that with respect to testing it is important that tests from one package do not bleed over to another package (e.g., a test in onyo-cli asserting that an onyo-core function works as intended -- we should assume that the functions from external code, which onyo-core in this example is, work as intended).
The documentation is separated and split to accommodate different target audiences. onyo-cli's target group are surface-level users and the documentation generated from the codebase should function as an instruction manual for using the onyo CLI. On the other hand, onyo-core is intended to be explored by users who want to get more from onyo than is possible through the CLI. They can write their own Python scripts to perform more elaborate actions with the core codebase alone. The documentation generated from this codebase should therefore be a technical one, rather than an instruction manual.
All of this has the added benefit of making deprecation more obvious. If the arguments to how onyo-core handles onyo new are changed, it may break onyo-cli in the process. Thus, we get to be more aware of (and careful with) major breaking changes, which becomes all the more pressing as we make a steady advance to our first major version increase.
The only downside to this I can come up with is the extra work in refactoring the code. For example, there is still a lot of code in the commands that should be in onyo-core rather than onyo-cli. This will take some time to get working, but I think the payoff is worth it.

I am still very much in favor of this. At the very least we should have separate setup.py installers for the CLI and API side of things.

This issue, and related ideas, were a bunch of times discussed.
We always came to the conclusion that we maybe want to do something like this later but never came to a satisfying conclusion how and what we exactly want to seperate. However, many of the current efforts did in fact separate the code.
Thereby I will close this issue until an actual need or concrete idea arrises.


Add circular dma copy nd operation and pass to insert them

This PR adds a new circular dma copy nd operation which represents an indefinite copy from the source to the target logical objectfifo. This operation waits for data to be produced on the source logical objectfifo and produces into the target logical objectfifo. This PR is an intermediary one to prepare for adding the AMDAIEToAIEWorkgroup pass and to simplify the review process: https://github.com/nod-ai/iree-amd-aie/compare/main...jornt_peeled_matmul_e2e#diff-45372414f96b9a5e4b0da5d7b089c11e8cf5cbe68f92eda0fe96d0c8c03bb010R290

@yzhang93 I merged this as you didn't block and I addressed your comments. As for the question whether this warrants a separate pass, we can always merge it back into a subsequent pass later if it becomes an issue, but I think it's better standalone. Let me know if there is anything else and I will take care of it in a follow-up.


Add width/height multiplier support, upsidedown text and text smoothing

Alright worked a bit on adding some text features.
Firstly upside-down text. Simple enough.
Text smoothing. Effective on text stretched to 4x height or width.
Width/Height.
Escpos has a GS ! command similar to the ESC ! that was currently in use for text size
The GS ! command supports up to 8x scaling of the width and/or height of fonts.
I do not know what printer support is like for the GS ! vs Esc ! command.
So if the width/height is set to 1 or 2 or combination thereof we use the old method of ESC ! but if height/width > 2 then we use the GS ! method. This maintains full backwards compatibility, sending the same commands down the wire for existing users.
I also fixed a typo in constants.py
There was a comment in the set method that it supported a "B2" text style.
There is no second bold style I could find supported by the escpos command set.
I removed this line.
Cheers

Looks good to me, thank you!
I checked it with my old T88II and the GS-commands seemed to work. I did not know this.
The only thing that seemed to be ineffective is smoothing, but maybe my test case wasn't good enough.
You are right, I could not find B2 neither, that's a documentation error.
The only thing that could be done is, you could instead of letting pass through the KeyErrors (when someone sets e.g. width=9) throw a self-created error (see exceptions.py and its usage)

Smoothing is easily visible with width=4 and height=4.
Anything less than that it is barely noticeable. I can confirm it definitely is working on my TM-T88V
I'll look at the error code stuff.
That's something new to me so I'll see what I can do.
The only other functions I've seen to play with is 90 degree printing and character spacing.
Text functions are fairly complete now

Alright I think I got it.
Checks for out of range and non-integer fields

Github got mad at me for the way I was checking values so I changed it
Let me know what you think of the error checking.
I made some assumptions based on the other code.

OK, I merge this now, I like it! :+1: Or do you want to directly implement text rotation? Then we could put it with the this stuff in this pull request (simply commiting to you branch will add it to the PR)
The thing with the error codes is just something I took on, when I started working on this project. Maybe we should check someday how other projects do it and what the best practice is (maybe there is a PEP).
By the way: I tried out 4x4 with smoothing. The smoothing my T88II does looks really awkward but it works!

Yeah the smoothing can look a bit funny
Please merge what is done. I don't need 90 degree printing and am not sure when I will get around to playing with it.

OK, thanks again!


Feature: Relay features field for safe apps

This PR implements https://github.com/safe-global/safe-config-service/issues/755
I also adjusted the documentation and test json data with the latest changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 13 (92.31%)  changed or added relevant lines in 4 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 31.37%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/common/models/backend/safe_apps.rs
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/safe_apps/converters.rs
1
48.28%

src/common/converters/tests/safe_app.rs
5
56.52%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
13019

Relevant Lines:
14771

💛  - Coveralls


Fix some flickering in ie

Looks like ie bugs out a bit with animation unless the overflow: hidden is directly above the element (or something else, but putting this here fixes the problem)

Dibs.


Histograms: not all examplars are ingested

What did you do?
Exposed exemplars alongside classic buckets, but also exposed a native histogram.
What did you expect to see?
The native histogram should be ingested together with all the exemplars assigned to the classic buckets.
What did you see instead? Under which circumstances?
Only the first exemplar is ingested.
Notes
See https://cloud-native.slack.com/archives/C02KR205UMU/p1688414381799849 for the findings.
It's unclear if that happened with scrape_classic_histograms set or not, but that has to be checked in any case.

The protobuf parser seems to do the right thing. Multiple exemplars per histogram is covered by tests. So we have to assume that the exemplars are thrown away later in the process. Investigating…

Fixed in 2.46.0. :tada:

Can you clarify whether this was a problem when using solely classic histograms?

It's not a problem with classic histograms because there will be at most one exemplar per bucket, which translates into one exemplar per ingested sample, which works fine.


Reevaluate lua profiles

We need to reevaluate the lua profiles. Performance is fine during routing because we cache profiles, the biggest issue it the performance of the instruction generation.
Options are:

Improve performance of lua-profiles.
Use other tech to define profile, we could use C# and embed these.

Related to:
https://github.com/itinero/routing/issues/73

Closing this, already in the roadmap.


Haul crashes trying to make a TTY adapter when run via child_process.spawn

Current Behavior
If haul is spawned with require('child_process').spawn it attempts to create a TTY session, which throws and fails out causing packaging not to run.
Expected Behavior
It should be able to either:

Fallback to previous behavior (prior to RC0) where no TTY session was used, or
Provide a CLI option to opt out of the TTY session

I can work around the issue by forcing haul into test mode by spawning with the NODE_ENV set to test, but that's not really an appropriate work around.
require('child_process').spawn('npx', args, {
  env: Object.assign({}, process.env, { NODE_ENV: 'test' })
});

https://github.com/callstack/haul/blob/v1.0.0-rc.0/src/server/ui.js#L72

We plan to release a node API so you don't need to spawn the process manually. Thanks for posting a workaround though!

As @thymikee said, Haul node API will be a way to go. However before that once the new version of react-slate comes out, Haul won't crash.

@msluther Can you install haul from next branch and check if the issue still occurs?? It should be fixed with https://github.com/callstack/haul/pull/427

@zamotany Sorry for the delay, I was finally able to get this tested out with ^1.0.0-rc.10 and everything seems to be working when run from a child_process spawn now.  Thanks all!


save and load parquet with MultiIndex (row) index and columns

I'm experimenting with Koalas. My pandas dataframes use MultiIndex both for rows and columns. Such pandas dataframes can be saved to / loaded from parquet files using PyArrow. Koalas can successfully translate such dataframes to/from pandas. However, Koalas cannot save/load such dataframes directly to/from parquet. Having to go through Pandas just to load/store the data severely limits the supported data size and kind of defeats the purpose of using Koalas.
PyArrow stores the information necessary to reconstruct MultiIndex in parquet metadata. It would be nice to have Koalas use the same approach for better compatibility, maybe even reuse PyArrow lib. Pointers to PyArrow implementation:

construct_metadata()
_reconstruct_columns_from_metadata()
_reconstruct_index()

Right now Koalas supports MultiIndex save/load for rows, but it requires specifying index_col parameter for each to_parquet()/read_parquet() call, which is inferior to PyArrow approach.

FYI: for the read path, it was resolved at #1695.


eInk display noise on USB connection

Summary
When you power up the last firmware using an USB cable, sometimes it can't use because it presents noise. With battery works fine.

This issue has been fixed. f27161ff002ecfa25aa0a129351e5da3844b4d64


train unet problem

i use unet and loss is only generalized dice loss
i found the loss first decrease ,but quickly increase like the picthure below

i tried trained it more time , finally the loss increase to 1, i don't know why

What optimizer/learning rate are you using ? Is this with the generalized dice loss alone ?

i use adam optimizer,and lr i tried from 0.001 to 0.00001. i use ISLES2018 dataset, i divided the original 256256 pictures into 6464 patches , i tried GDL, GDL with bundaryloss and ce loss, but it didn't work.
if i just use original picture 2562565, it have train and val dice like 0.7, but the test dice is only 0.3, i don't know how to solve it?

Closing that one in favor of #30


Chore: Evaluation Context must only contain unique values

https://github.com/open-feature/spec/pull/120
Add test to cover new requirement on evaluation context

Codecov Report

Merging #32 (c3f6b51) into main (4446810) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   99.32%   99.66%   +0.33%
==========================================
  Files          15       15
  Lines         297      297
  Branches       22       22
==========================================
+ Hits          295      296       +1
+ Partials        2        1       -1

Impacted Files
Coverage Δ

src/OpenFeature/Constant/Reason.cs
100.00% <ø> (ø)

src/OpenFeature/Error/FeatureProviderException.cs
100.00% <ø> (ø)

src/OpenFeature/Extension/EnumExtensions.cs
100.00% <ø> (ø)

...enFeature/Extension/ResolutionDetailsExtensions.cs
100.00% <ø> (ø)

src/OpenFeature/Hook.cs
100.00% <ø> (ø)

src/OpenFeature/Model/ClientMetadata.cs
100.00% <ø> (ø)

src/OpenFeature/Model/EvaluationContext.cs
100.00% <ø> (ø)

src/OpenFeature/Model/FlagEvaluationOptions.cs
100.00% <ø> (ø)

src/OpenFeature/Model/FlagEvalusationDetails.cs
100.00% <ø> (ø)

src/OpenFeature/Model/HookContext.cs
100.00% <ø> (ø)

... and 6 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Implement av stack sync v2

This is the new sequencer based av stack sync implementation.
From this version, the command does the git fetch and GitHub API call at
the beginning at once. This makes it faster than before, which runs git
fetch for every branch.
The command now asks if the user wants to push branches to remote. This
prompt is shown only when it's needed. Also this can be controlled by
the CLI flag. Also the command now asks if the user wants to delete
merged branches.
git-push will do an atomic push for all modified branches. This makes
the command faster than before, which runs git push for every branch
one-by-one.
Closes #247, #239
https://github.com/aviator-co/av/assets/21878/af886b2e-0b93-4d70-886a-3d4d35d12900

I feel like I should break this down more.


max_vocab_count won't work for CATEGORICAL integerized in tfdf.keras.GradientBoostedTreesModel

Hi All,
versions:
python 3.9
tensorflow_decision_forests==0.2.6
tensorflow==2.9.1
Running on AWS instance type: ml.m5.24xlarge
Problem description:
When setting max_vocab_count in tfdf.keras.FeatureUsage and in tfdf.keras.GradientBoostedTreesModel to 20, features of type: CATEGORICAL integerized won't be affected and original vocabulary size will be used, while in features of type: CATEGORICAL has-dict max_vocab_count will be applied correctly:
Please see the statistics on the log for example, both using the same feature usage:
"request_id" CATEGORICAL integerized vocab-size:8806 no-ood-item
"request_tile" CATEGORICAL has-dict vocab-size:21 num-oods:2823 (0.0014115%) most-frequent:"851fb467fffffff" 2395895 (1.19795%)
request_id is ignored by the guide and doesn't use the max_vocab_count,
request_tile is handled correctly.
Will appreciate your help, Thank you

Hi,
thank you for the report.
Version 0.2.6 of tf-df is fairly outdated, the project is at Version 1.5.0 now. Can you please confirm that the issue occurs on the latest version of TF-DF?
Best,
Richard

Hi, I looked into the code a bit more deeply and the behaviour you're seeing is expected and probably hasn't changed since 0.2.6.
Pre-Integerized categorical features (i.e., categorical features represented as integers) are not post-processed using the guide information to allow users a fine-grained control of how values are processed by TF-DF. This is why guide settings like max_vocab_count are not applied to them.
The simplest fix is to feed the feature as a string instead of an int, so TF-DF will not assume it's pre-integerized.
Alternatively, you can continue feeding the values as integers and set every value but the max_vocab_count most  frequent to 0 (which represents out-of-dictionary items). When doing this, you have to set advanced_arguments=tfdf.keras.AdvancedArguments(disable_categorical_integer_offset_correction=False) as an argument of the model constructor to allow TF-DF to properly recognize this. Also note that for integerized columns, the human-readable summary of the data spec (printed above) does not correctly count the number of ood items - this is a bug to be fixed in one of the next versions.

Hi,
Thank you for your quick reply.
The suggested workaround seems reasonable, however, I'm limited to data manipulation (we want to serve it in production and are limited by the latency and data types), in addition, the tfdf model is used as a layer in a bigger deep architecture, so I we are facing limitation both in versions and data manipulations.
If I want to avoid data manipulation, can you please point me to the code where I can apply the guide to Pre-Integerized categorical features as well?
I saw this src that is relevant to the release we are using: , using it as a custom fix will be the best solution facing our limitation.
Thank you for your help!

Hi,
The relevant piece is in this function. If you read through it, you'll see some preprocessing is not applied if the column is integerized. You'll have to make sure that the parameter max_number_of_unique_values is correctly applied even for integerized columns. I think this is not going to be completely trivial, since no statistical information (how often does each integer appear) is collected for integerized columns; that means you'll have to make sure this information is computed properly.
Note that this code resides in the Yggdrasil Decision Forests repository, which is a C++ library (developed by the same team as TF-DF). During compilation (with bazel), you'll have to make sure your local, modified copy of Yggdrasil Decision Forests is used. Finally, follow these instructions for building the old TF-serving with the old TF-DF. Unfortunately, our team does not have the bandwidth to support you in this process.
If this is too cumbersome, I suggest you also try to just exclude the request_id column from the model and measure model performance. Very often, a tree model is not able to discern useful information from such columns, especially if most entries are out-of-vocabulary (but this depends, of course, on your individual use case).


Move session cache to a different Redis DB

Right now, the general cache and the session cache are in the
same DB, so if we want to clear cached pages, it results in everyone's
sessions (and logins) being deleted.
By putting the sessions in a different Redis DB, we should
be able to clear the general cache without affecting sessions.

Nice. :candy:


Figure out error reporting

http://simpleprogrammer.com/2016/01/15/eric-smith-makes-error-reporting-breeze-exceptionless/

Look into:

https://rollbar.com/
https://exceptionless.com/
https://davidwalsh.name/track-errors-google-analytics


From reddint user /u/sansanity: Failed to read QR code from bitcoin.com and Bitpay on Send screen

Issue as reported:
The UI looks really clean, I like it a lot so far.
Ran into a problem with QR scanning on the Send function. I tested it against the Bitcoin.com and BitPay wallets using the following steps:

Brought up Receive QR Code on Bitcoin.com Wallet

Selected Send in Electron Cash

Clicked on QR Scanner

Highlighted QR code on Bitcoin.com wallet

At that point Electron seemed to recognize the code and went back to the Send page, but the address wasn't populated. I tried it with legacy and cash addrs on both of the wallets.
Let me know if you need more info, or want me to try anything.

Just a little extra info, non of the fields populated if I used a Receive QR code that specified an amount or fee.

I had the same problem scanning a cashaddr QR code, but when I scanned a legacy QR code (from explorer.bitcoin.com) it did work and the address was populated.

Likely there are multiple "URL formats" (yes, these things get encoded as URLs) that I was unaware of and need to implement.
Thanks so much to the both of you for reporting this and giving me more info.  This is great.  Like I said previously -- this is exactly the sort of thing I was hoping for when asking others to look and test.
I'll look into it either today or tomorrow and expect a fix soon.  It's likely something simple.
Thanks!

Yeah thanks guys.  I fixed the bug.  Yep... I had broken the QR scanning code late 2 nights ago.  Internally it was throwing an error.  I am a little embarrassed I broke it and didn't notice.
Thanks so much for testing and for catching this! This was a relatively serious (or annoying) bug and I'm glad it's caught!!
It's addressed in the latest build which has gone up on TestFlight just now.  Open the TestFlight app to get the latest build.
It should work now on any style payment requests (Including bitpay!).
I tested it and it works.
If you guys write back and tell me you don't have problems, I can go ahead and close the issue. Will wait on you guys though.  Thanks so much!

It's always the late night check-ins. Thats what we're here for though.
I just grabbed the new build.
I tried all three address formats and everything worked perfectly. lgtm :100:

Yeah man! Yay!  Ok, closing issue.


Failed to create Fabric SDK Client: failed to initialize configuration

export variables OK
export FABPROXY_CONFIG=${GOPATH}/src/github.com/hyperledger/fabric-chaincode-evm/examples/first-network-sdk-config.yaml  export FABPROXY_USER=User1 root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric/peer# export FABPROXY_ORG=Org1 root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric/peer# export FABPROXY_CHANNEL=mychannel root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric/peer# export FABPROXY_CCID=evmcc root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric/peer# export PORT=5000
build OK
root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric/peer#
cd $GOPATH/src/github.com/hyperledger/fabric-chaincode-evm/
root@6985ac657a8b:/opt/gopath/src/github.com/hyperledger/fabric-chaincode-evm#
 go build -o fab3 ./fabproxy/cmd
run  ./fab3 failed.
result 👎
Failed to create Fabric SDK Client: failed to initialize configuration: unable to load endpoint config: failed to initialize endpoint config from config backend:
network configuration load failed: failed to load channel configs: failed to load network TLSConfig: failed to load orderer/peer TLSConfig : failed to load orderer cert: failed to load pem bytes from path /opt/gopath/src/github.com/hyperledger/fabric-samples/first-network/crypto-config/ordererOrganizations/example.com/tlsca/tlsca.example.com-cert.pem: open /opt/gopath/src/github.com/hyperledger/fabric-samples/first-network/crypto-config/ordererOrganizations/example.com/tlsca/tlsca.example.com-cert.pem: no such file or directory
Bust...
any ideas ? export = $HOME/go may be ...
many thanks.

@engiwip Run these commands (https://github.com/IBM/loyalty-points-evm-fabric#2-setup-fab3) in a new terminal.  These should not be running in the cli container

Updated instructions here: https://github.com/IBM/loyalty-points-evm-fabric/commit/4725c2233db0e6a47baccdac6fb4a392e596910d


Quick question about ObjectMapper library

Is there any possibility to combine the PromiseKit/Alamofire with ObjectMapper library?
Thanks

Everything is possible, I have no experience with this library though so could not write the PromiseKit extension.

okay @mxcl  thanks for your fast reply. I really would like to implement this library onto my current project that using ObjectMapper. But it seems I couldn't apply it for now.
Thank you so much


Upgrade aws-sdk dependency to ^2.2.9

This PR upgrades aws-sdk dependency to ^2.2.9
Signed-off-by: Hans Kristian Flaatten<EMAIL_ADDRESS>

@Starefossen, if you would like to automate these kind of requests, you could use http://greenkeeper.io

Thanks for this @anthonyringoet, have you tried it?

I'm using it and it's pretty handy.
You get automatic pull requests, tests run because of that.
Housekeeping is minimized to merging PR's or fixing it on that branch :)

Cool! We should definitely set that up for this project :smile: :rocket:


Drop uproot 3 dependency

The current uproot library (aka uproot 3) will soon be replaced fully by uproot 4 (package currently called uproot4). While uproot4 is already used in the core cabinetry code, file writing still relies on uproot 3. The transition of uproot4 -> uproot is expected to happen before December 1, 2020 (see this talk). Once file writing exists in uproot 4, the uproot 3 dependency should be dropped completely.

File writing with uproot (which is now the name for what used to be called uproot4) will soon become possible: https://github.com/scikit-hep/uproot4/issues/25#issuecomment-802917934.


add okhttp

@aleffert  please review
add okhttp support.
here is an issue for using newrelic with okhttpclient
https://discuss.newrelic.com/t/error-using-retrofit-1-9-and-okhttp-2/25699/3

cc @1zaman

:+1:


Allow result memory to be allocated from per-call Allocator

Remove the existing Client.Pool for pooling memory used by cache results and replace it with an optional per-call Allocator. The per-call allocator allows callers to determine the correct lifecycle for anything allocated.
Signed-off-by: Nick Pillitteri<EMAIL_ADDRESS>

Note that the Allocator interface here returns []byte as opposed to *[]byte. We use both in Mimir for our various byte pooling functionality. []byte means copying the slice header (24 bytes) when getting something from the pool but can be used without needing to be dereferenced. Anyone have an opinion on what we should do here?

Note that the Allocator interface here returns []byte as opposed to *[]byte. We use both in Mimir for our various byte pooling functionality. []byte means copying the slice header (24 bytes) when getting something from the pool but can be used without needing to be dereferenced. Anyone have an opinion on what we should do here?

I don't have a strong opinion... have you benchmarked both options to see if there's a significant difference?

Overall LGTM.
One thing that this might be missing: a test to confirm that the allocator set with WithAllocator() is actually used.

Well, it turns out the current unit tests depend on being able to run a local memcached. If there's no memcached binary available (which there isn't because CI runs in a standard ubuntu image), they're skipped. So none of the tests have actually been running: https://github.com/grafana/gomemcache/blob/master/memcache/memcache_test.go#L39

The tests for the client need a lot of work so I'm going to merge this as-is and will follow up with a test to ensure the allocator is used and some other cleanup.


feat: Voting Node Service - Build Block0

Add groundwork for deploying the voting stack for local environments.

Removes chain-evm from the workspace.
Adds services/voting-node with python service to deploy jormungadr nodes.

Leader0 node gathers information to build block0 for voting event

Adds docker-compose file to deploy nodes needed for voting events.

Dockerfiles for jormungandr (with jcli) and vit-servicing-station are in place, as well as the one for the FastAPI service (voting-node). All will need refinement.
Next task is to automate buiding with cargo make and to add a docker-compose.yml to add the services. @stevenj FYI.

Removed the chain-evm crate, as well as the evm feature in all dependent crates.
This has significantly improved build times and image size of the catalyst-core-base to 40% of the previous size..
❯ docker images
REPOSITORY                     TAG                  IMAGE ID       CREATED        SIZE
jormungandr                    latest               97c431c10d92   2 hours ago    217MB
catalyst-core-base             latest               cb2b6449bd40   3 hours ago    3.65GB
vitss                          latest               fec3aafae961   24 hours ago   187MB

This is ready for merging.

A few notes.
It's late into the design process, but I wonder how much this tool can be simplified by tying it into Kubernetes. It appears to be emulating exactly what a Kubernetes operator does but doing so in a self-contained matter which has drawbacks:

Operates more like a black box: seeing the inner state when managing so many subprocesses is challenging.
More difficult to configure: many things are hardcoded into source code, making it difficult to change on the fly.
More challenging to troubleshoot: since we're dealing with subprocesses, discerning their state is not trivial.
Hard to package: the container would need both jorm and jcli packaged, making it difficult to discern the exact versions in the container image.

As a counter-example, many of the above items are addressed if we step back and substitute subprocesses with containers (which is what an operator would do). We could also objectify many different abstractions: node configurations could be ConfigMaps (making them easier to manipulate), schedules and events could be custom resources for better visibility, etc.
An operator would consume events from the database and then create an environment in Kubernetes which is auditable and easily troubleshot (i.e., I could inspect what event is currently running, check the block0 hash, etc.). It's a relatively large shift (although a lot could be brought over), but just throwing it out there before we get too far into the weeds. I'm doing a presentation on Kubernetes operators this Friday, and it just so happens that the one I wrote is in Python :)

A few notes.
It's late into the design process, but I wonder how much this tool can be simplified by tying it into Kubernetes. It appears to be emulating exactly what a Kubernetes operator does but doing so in a self-contained matter which has drawbacks:

More difficult to configure: many things are hardcoded into source code, making it difficult to change on the fly.
More challenging to troubleshoot: since we're dealing with subprocesses, discerning their state is not trivial.
Hard to package: the container would need both jorm and jcli packaged, making it difficult to discern the exact versions in the container image.

As a counter-example, many of the above items are addressed if we step back and substitute subprocesses with containers (which is what an operator would do). We could also objectify many different abstractions: node configurations could be ConfigMaps (making them easier to manipulate), schedules and events could be custom resources for better visibility, etc.
An operator would consume events from the database and then create an environment in Kubernetes which is auditable and easily troubleshot (i.e., I could inspect what event is currently running, check the block0 hash, etc.). It's a relatively large shift (although a lot could be brought over), but just throwing it out there before we get too far into the weeds. I'm doing a presentation on Kubernetes operators this Friday, and it just so happens that the one I wrote is in Python :)

A few notes.
It's late into the design process, but I wonder how much this tool can be simplified by tying it into Kubernetes. It appears to be emulating exactly what a Kubernetes operator does but doing so in a self-contained matter which has drawbacks:

I also think that it's a bit late into the design process to consider changing, also, I think that the scope of this service is more aligned with gathering the steps manual process done for prior voting events and automating them, as well as to have a low-barrier deployment solution for community devs. I think that it's meant to serve at this moment in time, but that will evolve and eventually fade into sturdier software. But I think that this is something for which @stevenj is best informed.

More difficult to configure: many things are hardcoded into source code, making it difficult to change on the fly.

There is continuing work on this, and making changes on the fly is something that will be done using environment vars. Currently the templates are hardcoded with random data that is overwritten as the information is gathered by the service.
Upcoming features include detecting changes in the DB and deciding whether to re-run the schedule or not, whether the event has started or not, for example.

More challenging to troubleshoot: since we're dealing with subprocesses, discerning their state is not trivial.

We are counting on the open-telemetry stack to inform ourselves of the running jormungandr subprocesses. With jcli, we only care to know the statuscode for the process or the relevant output.

Hard to package: the container would need both jorm and jcli packaged, making it difficult to discern the exact versions in the container image.

The docker image for the voting-node includes the binaries generated by the jormunganr image, so we have control of their versions.

As a counter-example, many of the above items are addressed if we step back and substitute subprocesses with containers (which is what an operator would do). We could also objectify many different abstractions: node configurations could be ConfigMaps (making them easier to manipulate), schedules and events could be custom resources for better visibility, etc.
An operator would consume events from the database and then create an environment in Kubernetes which is auditable and easily troubleshot (i.e., I could inspect what event is currently running, check the block0 hash, etc.). It's a relatively large shift (although a lot could be brought over), but just throwing it out there before we get too far into the weeds. I'm doing a presentation on Kubernetes operators this Friday, and it just so happens that the one I wrote is in Python :)

Look forward to learning more about this.


Import GRCh38 reference genome.

GRCh38 reference FASTA with index and sequence dictionary:

/gscmnt/gc9005/info/model_data/2887491634/build4ec1c5bd1f6941b8a99f2e230217cb91/all_sequences.fa
/gscmnt/gc9005/info/model_data/2887491634/build4ec1c5bd1f6941b8a99f2e230217cb91/all_sequences.dict
/gscmnt/gc9005/info/model_data/2887491634/build4ec1c5bd1f6941b8a99f2e230217cb91/all_sequences.fa.fai

These have been uploaded to my home project.


Minor build/test tweaks.

Remove ember-data from build.  This library does not use ember-data, and occasionally having ember-data in the build causes test failures (ember-data 1.0.0-beta.16.1 does not work with Ember canary at this point).
Test across many versions of Ember.
Use ember-cli-babel instead of custom preprocessor.
Fix style warning on 1.12.0-beta.1+.

Awesome stuff, thanks Rob!


Docker updates - all dependencies added

Looks like the container builds fine. Let's proceed further with the docker-compose.


Result producer should propagate header in node scan

https://github.com/opencypher/cypher-for-apache-spark/blob/3afbaabb55d6ec808e7b181f80911e332fef8aa1/src/main/scala/org/opencypher/caps/impl/spark/physical/PhysicalResultProducer.scala#L57

Related to #194


Added support to convert TextSize to Legacy FontSize

fixes #7

fixes issue #7

Thank you for making this pull request! The only change I would make would be to remove the unused "ChangeRbxassetidCheckbox_Copy_Checked" from the .xaml and .xaml.cs file, then it would be ready to merge.


chore(package): update eslint to version 3.17.0

Connect to #117
https://greenkeeper.io/

Storybook Hub is building storybooks for every commit in this PR.
Latest Storybook: https://8a328d24-3712-400d-bb48-4802657f7511.sbook.io/
( Visit here for more info )

This comment is automatically added by Storybook Hub


[Core] Fix some typo and format some code

Fix some typo and format some code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.hongli.wwj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@luoyuxia
Hi, thanks for your review.
I have resolved your comments, please cc, thx.

rebased onto main to trigger tests.

rebased onto main to trigger tests.

Thx，Done


How to initialize first generation child nodes?

I'm curious about the way you explored the possible child nodes in training phase. For the 1st round playout, for a given question, randomly list several child nodes as possible first step for resolving the question? In AlphaZero, it's straightforward to randomly pick grid cells. Thanks

I'm curious about the way you explored the possible child nodes in training phase. For the 1st round playout, for a given question, randomly list several child nodes as possible first step for resolving the question? In AlphaZero, it's straightforward to randomly pick grid cells. Thanks

You can refer to the instruction in readme, about how to construct the training of the round 1.


Update k8s.io/kubernetes to fix CVE

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update k8s.io/kubernetes to fix CVE
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm
/approve


allow sending semicolon

Some dragonrealms commands use the semicolon character (;), sing and chant, for example.
I can't get the outlander client to send a semicolon, even putting it in a script. Please allow this, with escaping or whatever is necessary.
Possible docs issue - maybe there's a way but it needs to be in the README.

Right now the semicolon is used to send multiple commands at once:
put say hello;say DragonRealms

This will send say hello and say DragonRealms as put commands.
There is no way to escape the semicolon currently.

Bummer, that breaks sing and chant.
https://elanthipedia.play.net/mediawiki/index.php/Sing_command

I should be able to fix this without too much trouble.  I'm not sure how soon since I am out of town.  May see how far I can get on it on my train ride today.

Great. I'm impressed that you read these.

Fixed in v0.7.3


Add support for R Shiny with webR

This is a fairly large PR with several moving parts. My apologies that it is not broken up into more manageable pieces.
This set of commits extends Shinylive's infrastructure to include running R Shiny apps using webR. The addition of the webR Wasm engine is based heavily on the Pyodide implementation, to the point of some duplication. In the future we might want to abstract shared pieces out, but hopefully this is OK for now.
The new code for loading webR into the page, executing R code, and setting things up for running Shiny is contained in the files hooks/useWebR.tsx and webr-proxy.ts.

New (but similar to existing) functions have been added to messageporthttp.ts and messageportwebsocket-channel.ts for handling traffic for R Shiny apps separately to Python Shiny apps.
When webR loads a Shiny app, a httpuv app object is created and stored in a global registry. When HTTP requests are received from the service worker, they are converted into rook-style objects and the correct abbObj$call() is invoked directly for a response. When a WebSocket connection is initialised, traffic is handled via callbacks from R. Proxy R object references to the callback functions are stored and used to send WS traffic from the client to the Shiny server.
Going the other way, WS traffic from the server to the client is first serialised then sent via a standard webR output channel to be handled by Shinylive. A map of Shiny app names to specfic app's toClient() functions is maintained and then used to forward the WS output message content onto the correct Shiny client.

When a Shiny client launches in an iframe and opens a WebSocket, an openChannel message is fired to the containing window. This happens for both Shiny and R and causes cross-talk if both engines are running at the same time. The handlers for these messages have been tweaked so that a communication channel is only opened with a specific Wasm engine if that Wasm engine recognises the app name in its .shiny_app_registry (for webR) or _shiny_app_registry  for (Pyodide).

The selection of which Wasm engine will be used is handled in App.tsx. The App component has a new attribute appEngine, of type AppEngine = 'python' | 'r'. The function runApp() now also takes the Wasm engine as an optional argument. The chosen Wasm engine is loaded into the page by using the argument's value to select which of the engine's hooks are used.
The new appEngine argument is optional and defaults to a defined constant in build.ts. By default, build.ts sets the default appEngine to "python". The intention here is that current scripts and CI set up for building the Shinylive website and assets pack will hopefully be unaffected by these changes, by defaulting to using "python" as before.
However, when build.ts is invoked with --r as one of its arguments, the behavior is changed so that the default value for the appEngine argument is 'r' instead. With this, a version of the Shinylive website that loads Shiny for R, running on webR, can be built and served at some other URL, perhaps something like shinylive.io/r/.
In any case, for either type of build both R and/or Python are available to be used in a web page by invoking runApp() with either r or python as the appEngine argument. The same Shinylive asset pack and service worker script can be used to launch both engines. This will be useful later when loading multiple apps in the same page, such as with quarto-shinylive.

Several make recipes have been added to Makefile:

make webr - Copy the webR distribution from node_modules into the shinylive assets tree. This step has also been added to make all.
make serve-r, make serve-prod-r - Build and serve a version of the Shinylive website for R Shiny.
make buildjs-prod-r - Build a version of the Shinylive website for R Shiny.

These commands are useful for building versions of the Shinylive editor and examples website that defaults to using webR and loading R examples, rather than Python.
The previous make serve, make buildjs etc. recipes have been left as-is. They should continue to build the Shinylive website with Python as the default engine, as before.

The examples directory has been reorganised into python and r subdirectories, and I have added some of the examples from https://github.com/rstudio/shiny-examples. The Shinylive website checks the appEngine argument provided to the root App component and filters out the examples that don't match.

The Editor and other React components have been updated to detect Shiny for R apps, by extending the search to include app.R and server.R.
The "Format code" button is hidden when running under webR. Probably more work can be done later to add a full LSP server for R, running under webR. But right now, the editor just doesn't handle any of those extra features when running with the webR engine.
The Terminal component is extended to support webR. The component is tweaked a little so that the correct prompt string is shown (>, or other prompts from R, rather than a fixed >>>), and a Ctrl-C handler has been added so that running R code can be interrupted.

WebR requires that the containing web page is Cross-Origin Isolated (COI) to work when running with Shinylive. This happens when the page is served with certain HTTP headers set. The following changes have been made to assist in loading a webR Shinylive app under COI:
The build.ts dev server has been tweaked to serve its content with the required headers, but only when the --r argument is supplied.
The shinylive service worker is extended so that it can inject the required HTTP headers if they are missing. The service worker has not been set up to do this by default, because it can break Shinylive for Python examples that rely on loading cross-origin assets into the page (e.g. the Map example). So, in this PR the service worker has been set up to only inject the COI headers for webR if it has been asked to, by setting the URL of the loading page (or the referrer URL) to contain the query parameter "coi=1". Servers where files are already served with COI headers don't need to include the query.
The runApp() function has been tweaked so that if the engine argument is 'r', and the page is not already COI, and the query parameter is not in the URL already, then the coi=1 query is added to the page URL and the page refreshed. By adding this, if a webR Shinylive app is used in a web page (e.g. part of a quarto-shinylive document) and the page is not already COI, then the page will refresh after the first load and the service worker injects the required headers. This fixes running Shinylive apps in non-COI contexts, such as GitHub pages.

Note that loading webR's Shiny takes a fair while longer than Pyodide's Shiny for Python. This is due to package downloading. We might still be able to improve this in time by reducing Shiny's prerequisite R package download sizes.
For this initial introduction, the standard webr npm package is bundled with Shinylive. However, in the future I'd like to instead use a different version of the package built specially for Shinylive that already includes all the R packages required to launch R Shiny on its virtual filesystem. That should improve startup time quite a lot.

I think that's pretty much all the major changes. Please let me know if you have any questions or see anything that looks broken or like it won't work.
Example Shinylive for R deployment: https://georgestagg.github.io/shinylive/examples/
Example Quarto doc with Shiny for R & Shiny for Python examples: https://georgestagg.github.io/quarto-shinylive-demo/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Improvements in face unlocking system.

Here in my project whenever a face matches with the faces database then it shows a string "FACE UNLOCK" else it shows only "FACE LOCKED". So sometimes the same face matches but it shows FACE LOCKED.

Can I contribute to this issue?

Yes

Assigning you

Join Discord channel for discussion.
discord.gg/f9jftkcw


ServiceNow Config is exposed to all Mattermost users

Security Issue
Severity: Medium - 6.4
Description
When a ServiceNow Plugin is installed and configured, a regular Mattermost user who has not connected their ServiceNow account, is allowed to make a request and fetch all the ServiceNow configurations via /plugins/mattermost-plugin-servicenow/api/v1/config API endpoint. This API endpoint responds back with sensitive configurations like ServiceNowOAuthClientID, ServiceNowOAuthClientSecret, EncryptionSecret, WebhookSecret.
Impact
Any Mattermost user, including Guest Users, can fetch this information and use it to send Phishing Notifications to the subscribed channels. Alternatively, the user can also use this information and create tampered OAuth requests.
Suggested Fix
This configuration is only used in the System Console and hence only a system admin should be allowed to request this API endpoint.

@asatkinson These are fixed so please verify and close

@mickmister the issue is fixed. Please verify and close


Environment Configuration Management

Description
Look into implementing multiple environment configuration
Acceptance Criteria

[x] Establishing distinct environment configurations, such as local and production settings.
[ ] Considering the use of json-server for local environment testing as an alternative to a MongoDB Atlas instance.

We will hold off some of the changes here until Node 20.x which will natively support passing of env files. We will not be using separate json-server for development since MongoDB Atlas cloud solution is pretty decent. We will however, look at creating seeders for different environments which will be part of a separate ticket.


[Windows] The input line is too long error when running a sample

Steps to reproduce:

Build the ballerina lang repo in a linux environment- 17-04-2018
Copy the runtime pack to a windows environment
Run a sample
ballerina.bat run samples\hello-world.bal

Issue
The following error is logged.
The input line is too long.
The syntax of the command is incorrect.

When searching the root cause for the error in the web, it says the error can be due to an issue in the java path. But, the samples are working successfully when it is run against a pack that is downloaded via the windows installer.
OS, DB, other environment details and versions:
Windows 7

@ChanakaCooray is looking into this

Observed this issue again when installing the pack with the Ballerina Platform Installer.
Verified in both Windows 7 and 10 OS's. Hence, reopening

@dilinisg, please check and verify this with the latest installer.

Verified in beta13 and it is fixed now. Hence, closing.


Added St Angela's Ursuline School

@iMidnights First stage of verification passed, official domain for St Angela's Ursuline School is stangelas-ursuline.co.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@iMidnights Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Feature request: Change the Modifier Bucket Magnet behavior

As it is now, the magnet button on the locks all modifiers in place. However, if any modifier is latter added, it remains stacked up with the previously added.
Consider a scenario where the "locked" modifiers represent global conditions that will apply more generally to almost anyone - e.g. visibility, bad footing. Under the current behavior, for instance, if you add range modifiers to an attack, you must then manually remove it later on, as it might differ for a different actor but it will be permanent on the modifier bucket.
I propose the magnet button locks modifiers up until the point it's clicked - as if creating "global conditions" for all tokens on a scene. If further modifiers are added after this point, they are discarded as usual after the roll.
I think I might be rambling a bit, if so I can clarify further.

You know, this is an interesting suggestion, but what would also be cool is if GGA could have conditions like "bad footing" and could "know" how to apply those penalties, e.g., -2 on all attack rolls, but -1 on defense rolls. That would be pretty amazing. The same is true of shock penalties. Once it's applied, there's a marker, but one still has to apply the modifier to the bucket. Not sure of the best way to accomplish all that, because it can't really auto-populate the bucket, I would imagine, with a -2 to hit/-1 to defend (but wouldn't it be cool if it could?).


Migrate to modern error handling and Rust 2018

Hey there! This is an unsolicited PR updating some underpinnings of this crate. I decided to do it while running into issues updating the error handling for the @NZXTCorp's CAM project, where std::error::Error (now the de-facto point of error interoperability in current Rust) is an important part of the story. In order to resolve this, I've swapped out the usage of failure (which implies a certain set of tradeoffs for an abstract error type the Rust community didn't reach consensus on) for thiserror, which is much more interoperable with Rust's current ecosystem nowadays.
I've also included some other updates, like a migration to Rust 2018, that you may not care for. I'm not sure what the MSRV for this crate is, if there is one, but it may affect people using Rust older than 1.34.
See individual commits for more details. I've tried to be fairly detailed, but I'm definitely not writing any significant prose yet.

Just for the record, I think that these changes might merit a 0.3 release -- enough changes with the error handling story that it might require some manual work for users to migrate to use it, esp. in code that relied on failure::Fail.


Question about error record overwritting rules

In the current reri spec chapter 2.5, listing 1 describes the overwriting rules of the error record. However, it doesn't mention the following situation:

If the new_error has the same severity and priority as the current logged error record.

What actions should hardware take in this situation?
BTW, is there any hardware modeling for reri spec?

If the two errors have same severity then MO is set to 1 (line 3). However, if they have the same priority then condition at line 6 evaluates to false and there is no overwrite. The net of this is that a second error of the same priority and severity sets the multiple-occurred (MO) bit but the first error is retained.

1.          if ( severity(new_status) == severity(status_i) )
2.              // Second errors of the same severity set MO
3.              status_i.mo = 1
4.              // Second error of same severity overwrites previous error if it
5.              // has higher priority (status_i.pri).
6.              if ( new_status.pri > status_i.pri )
7.                  overwrite = TRUE;
8.              endif
9.          endif

BTW, is there any hardware modeling for reri spec?

I am not aware of an open source implementation.

Thanks!


not able to capture svg image

not able to capture svg image ..
Any Solution  ,Please help

+1, also running into this issue.

+1 here is a codesandbox that reproduces the issue:
https://codesandbox.io/s/wo3oww275k

I want to add another solution based on above one for dynamic created svg's which you can not add width or height staticly. I faced that problem with amcharts, which i can not add width and height to created svg charts.

html2canvas(this.ImageCanvas,
		{
            onclone: (element) => {
                const svgElements: any[] = element.body.getElementsByClassName("printable-area")[0].getElementsByTagName("svg");
                Array.from(svgElements).forEach((svgElement) => {
                    const bBox: any = svgElement.getBBox();
                    svgElement.setAttribute("width", bBox.width);
                    svgElement.setAttribute("height", bBox.height);
                });
            },
        }).then((canvas) => {
            document.body.appendChild(canvas);
        });

Thanks @muratcatal , this fixes most of our issues.

Thanks @muratcatal

Just adding here for SEO, this only happened on Chrome for me, not on Safari


CMake warning messages

CentOS7
cmake 3.13.5
cuda 10.0
when I run cmake: /bin/cmake3 -DCMAKE_BUILD_TYPE=Release -DFLASHLIGHT_BACKEND=CUDA -G "CodeBlocks - Unix Makefiles" /home/isaac/flashlight
I get below warnings
-- ArrayFire found (include: /opt/arrayfire-no-gl/include, library: ArrayFire::afcuda)
-- CUDA found (library: /usr/local/cuda-10.0/lib64/libcudart_static.a;-pthread;dl;/usr/lib64/librt.so include: /usr/local/cuda-10.0/include)
-- Found CUDNN: (lib: /usr/local/cuda-10.0/lib64/libcudnn.so include: /usr/local/cuda-10.0/include)
-- CUDNN found (library: /usr/local/cuda-10.0/lib64/libcudnn.so include: /usr/local/cuda-10.0/include)
CMake Warning (dev) at flashlight/contrib/modules/CMakeLists.txt:16 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "ContribModules" has a relative path.
Call Stack (most recent call first):
  flashlight/contrib/CMakeLists.txt:12 (include)
  CMakeLists.txt:205 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/autograd/CMakeLists.txt:16 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Autograd" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:231 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/autograd/CMakeLists.txt:79 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Autograd" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:231 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/common/CMakeLists.txt:23 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Common" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:234 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/dataset/CMakeLists.txt:24 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Dataset" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:237 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/distributed/CMakeLists.txt:19 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Distributed" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:240 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Gloo not found
-- Determining NCCL version from the header file: /usr/include/nccl.h
-- NCCL_MAJOR_VERSION: 2
-- Found NCCL (include: /usr/include, library: /lib64/libnccl.so)
-- NCCL found
-- MPI_CXX found
-- MPI_CXX compile flags:
-- MPI_CXX include path: /usr/include
-- MPI_CXX LINK flags path: -Wl,-rpath -Wl,/usr/lib64 -Wl,--enable-new-dtags -pthread
-- MPI_CXX libraries: /usr/lib64/libmpi.so
-- MPI_C found
-- MPI_C compile flags:
-- MPI_C include path: /usr/include
-- MPI_C LINK flags path: -Wl,-rpath -Wl,/usr/lib64 -Wl,--enable-new-dtags -pthread
-- MPI_C libraries: /usr/lib64/libmpi.so
CMake Warning (dev) at flashlight/meter/CMakeLists.txt:18 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Meter" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:243 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/nn/CMakeLists.txt:43 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "NN" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:246 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at flashlight/optim/CMakeLists.txt:15 (target_sources):
  Policy CMP0076 is not set: target_sources() command converts relative paths
  to absolute.  Run "cmake --help-policy CMP0076" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

  An interface source of target "Optim" has a relative path.
Call Stack (most recent call first):
  CMakeLists.txt:249 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/isaac/flashlight

Is this fine?

@ThisIsIsaac — yep, you can ignore these messages. Newer versions of CMake enforce this policy, but everything should be backwards compatible.


MUIDataTable can't remove count property of the options prop

@gregnb would it possible to make the count property of the options prop not required? For the datatable I'm working on, I need to only display the number of rows on the page without the 'of ${count}' part. I tried removing the count property entirely from the options prop and the display is how I want it to be, but this causes the inability to access the next page of rows.

@gregnb Looks like the material ui pagination component uses the labelDisplayedRows prop to allow customization of the row display label. We could expose this via an option. Do you think this is a worthwhile enhancement?

you can do whatever you whant with the labelDisplayedRows prop, if you dont want nothing to be showed you can do this : labelDisplayedRows={() => {}}, but i think this will solve your problem:
labelDisplayedRows={({ count }) => ${count}}


Support Test::Unit::TestCase and more assertions

To get Test::Unit::TestCase to work I mainly had to change #ancestor_names a bit. It couldn't handle module names with more than two parts before.

support Test::Unit::TestCase
support assert_empty
support assert_kind_of
support assert_instance_of

Could you split this up into separate PRs, please? Thanks.

@jaredbeck will 2 PRs do? one for the test class and one for the assertions? or do you want one for each assertion?

Two is fine thanks
On Tue, Oct 16, 2018 at 03:48 Janosch Müller<EMAIL_ADDRESS>wrote:

@jaredbeck https://github.com/jaredbeck will 2 PRs do? one for the test
class and one for the assertions? or do you want one for each assertion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaredbeck/minitest_to_rspec/pull/23#issuecomment-430136131,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXPiX19WTUBKVqGXXIhyZXaphnxesyiks5ulY8rgaJpZM4Xck9O
.

--
Jared Beck •<PHONE_NUMBER> •<EMAIL_ADDRESS>

closed in favor of #25, #26


ToolbarAndroid title and subtitle cannot be styled by StyleSheet

As per the documentation they can only be styled via props (titleColor and subtitleColor).
It appears only the toolbar's backgroundColor and height can be styled via StyleSheet.

cc @foghina

I swear I started writing a comment on this at some point, but I can't find it.
Anyway, I'd say that this is by design. The toolbar's title and subtitle appearance (anything else than color) can only be customized via style resources (see setTitleTextAppearance), which can only be changed by recompiling the APK. Furthermore, we don't (and probably won't) have a mapping between StyleSheet and Android's TextAppearance.
If you need advanced control over the text appearance of your toolbar, you might want to implement the whole widget in JS.

Also the toolbar actions cannot have a color applied to them in my tests.