Refactor ReportScreenIDSetter to using withOnyx instead of a hook

Details

this is a fix for regression after https://github.com/Expensify/App/pull/44155
this change was introduced originally in here https://github.com/Expensify/App/pull/44155 to prepare the app for future usage of React concurrent mode; I expected for useOnyx to behave the same as withOnyx and the safer choice to use in the app, however this introduced the bug - I don't yet fully understand why
reverted the changes on the file, the file is now back to using withOnyx HOC

Fixed Issues

$ https://github.com/Expensify/App/issues/44442
PROPOSAL:
Tests

use the original reproduction description from issue

Offline tests

QA Steps

use the original reproduction description from issue

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3929868/7f94f8b4-9dac-4a3a-b708-4a3be9ba2c64

MacOS: Desktop

@roryabraham fully agree but the bug seemed serious, so I just did this fix so that it could be merged. Deeper investigation can be done later.
Lint job is failing but its not because of lint errors, but rather some memory problems related to eslint. Don't know yet how to handle those

Lint job is failing but its not because of lint errors, but rather some memory problems related to eslint. Don't know yet how to handle those

try merging main. I increased the memory available to ESLint in a PR yesterday, and that should hopefully fix it.

Furthermore, this bug can be fixed by making only report use withOnyx while the other Onyx values use useOnyx. Strange...

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://github.com/Expensify/App/assets/59907218/bb3b2475-52d0-4387-8871-b25d4ac4fbae

Reverted changes looks good and fixes regression.

Furthermore, this bug can be fixed by making only report use withOnyx while the other Onyx values use useOnyx. Strange...

@roryabraham should this solution be applied or are we good to go with current reverted changes


Fix window flashing background with unspecified size

Proposed Changes
The original fix to the window background being visible before the context was to add this in the update callback to AwtWindow:
AwtWindow(
    ...
    update = {
        ...
        if (!it.isDisplayable) {
            it.makeDisplayable()
            it.contentPane.paint(it.graphics)
        }
    }
)

Unfortunately, if the window/dialog size is Unspecified, setSizeSafely calls pack() on the window, to determine its preferred size, making is displayable, and so the code above isn't called.
This PR does the following

Always call pack() in setSizeSafely to avoid an inconsistent state.
Call revalidate instead of pack to force composition+layout.
Improve the check for when the window is shown for the first time.
Remove window.makeDisplayable() from AwtWindow. Not sure why it was needed.
Make setSizeSafely a bit more easy to understand.

Testing
Test: Added new unit tests.
Issues Fixed
Fixes: https://github.com/JetBrains/compose-multiplatform/issues/1794

Please take a look at failing WindowStateTest.set window size by its content when window is on the screen good test case, that is not handled, when size become Unspecified

Noticied the changes in setSizeSafely. But setSizeSafely theoretically can be not called. In a case when the window is already this size. So, we won't call pack.

@igordmn setSizeSafely must be called at least once, because the check is
            if (state.size != appliedState.size) {

and the initial value of appliedState.size is null.

Changes in the latest commit:

setSizeSafely now always calls pack(), even if the window is already displayable. That was what causing the WindowStateTest.set window size by its content when window is on the screen test to fail.
setSizeSafely is now responsible for updating the composition size after measuring its preferred size, instead of the Window/Dialog update function. It's better because setSizeSafely is the one responsible for "breaking" it.
The Window/Dialog update function is now responsible only for drawing the first frame.


CDN version 2.6 notworking.

I typed cdn version 2.6, but "Your connection is not private
" message pop up.

This Link works fine for me, it seems you have a connection issue.


See Commits and Changes for more details.

See Commits and Changes for more details.

Created by  pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )
Originally posted by @pull in https://github.com/tharkhay/docs/pull/2

``


Updating documentation for b10

Documentation and updated certificate reflecting (b)(10)

coverage: 94.256%. remained the same when pulling b93f3aa5c62d89b263d283bb3534e7beead26942 on reshma-b10-cert into 7fcb0daa1ab9a80aa1341f818c9a5bd1e4c3c64d on main.


feat: SequenceDiagram shows row's message in the throughput column

Fixes #7324

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

seems reasonable, thanks!
/lgtm


Forge test auto create

Component
Forge
Describe the feature you would like
Hi team,
Hi team,
I was wondering if Foundry currently offers an option to automatically create a Solidity test file. I wasn’t able to find any such functionality and find it a bit tedious to manually create a new test file each time I write tests for a smart contract.
If this feature doesn’t exist yet, I’d like to propose adding a new command, something like:
forge create-test ContractName
This command would generate a basic test template for the specified contract, for example:
pragma solidity ^0.8.0;

import "forge-std/Test.sol";
import "../src/{contract_name}.sol";

contract {contract_name}Test is Test {
    {contract_name} public contractUnderTest;

    function setUp() public {
        contractUnderTest = new {contract_name}();
    }

    function testExample() public {
        // Add your test logic here
    }
}

Optional Dependencies
To make this even more versatile, we could add an option to include additional dependencies during test file creation. For example:
forge create-test ContractName --dependencies UniswapV2Library
If specified, the tool would automatically resolve the dependency path using remappings.txt and include the correct import statement in the generated test file. Here’s an example of the output:
pragma solidity ^0.8.0;

import "forge-std/Test.sol";
import "../src/ContractName.sol";
import<EMAIL_ADDRESS>
contract ContractNameTest is Test {
    ContractName public contractUnderTest;

    function setUp() public {
        contractUnderTest = new ContractName();
    }

    function testExample() public {
        // Example test logic using UniswapV2Library
        uint256 value = UniswapV2Library.getAmountOut(1000, 5000, 10000);
        assertEq(value, 1666); // Replace with actual expected value
    }
}

Additional context
No response

@tskoyo please use forge init hello-world for such, see https://book.getfoundry.sh/reference/forge/forge-init

I could though misunderstood your request, reopening to clarify

Hi @tskoyo, thanks for your suggestion.
I would recommend using snippets in your code editor / IDE. I don't think this should be part of Foundry.
See: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_create-your-own-snippets
Marking as not planned


psychatrist workflow

https://www.figma.com/design/7deDsVo0b5PB1o6NoQVY9u/TNMSS?node-id=49-454&node-type=canvas
@Coderlearner41 go through the psychiatrist workflow in the Figma file and prepare the workflow. once it's done create a pull request to the main- but make sure your branch is up to date with main

thanks @Coderlearner41 . The corresponding pull request has been merged into the Main


(Play Store) Your device isn't compatible with this version

Accessing the play store entry listed from the Readme/ Github front page displays "Your device isn't compatible with this version."  (This requires using the link to an on device browser and then letting it jump to the play store before or after hitting install.  Incompatible apps aren't normally listed in the Play Store search it seems.) This seems to be the case across accounts and Android phones (all modern).  I see that the app has been recently updated, are there additional requirements for Android phones or tablets?

Hi. In accordance to Google Play store, more than 14000 devices are supported.  I intentionally removed some watches (because of instable Android implementation) and all phones with larger screen formats as the UI is not adjusted for tablets and larger.
If the device is not a tablet, please post specific device and I can check the list, if it is there.

Thanks!
One of the phones is the Samsung Galaxy S23 Ultra, another is a Samsung Galaxy  (unknown number S series but I can get it) Active.
Watches are Samsung Galaxy Watch 4s.

@Foxpace Just checking if there is any activity on this before timelines require us to move to other solutions.  No pressure just checking in before switching up.

Hi, sorry for late response again. I had hectic last couple of days.
I checked the device support. Support is absent because of forgotten screen size restriction in manifest here:
https://github.com/Foxpace/SensorBox/blob/master/app/src/main/AndroidManifest.xml
It is there, because the app had not supported the landscape UI for quite long time, but it has been added later on. So many people using tablet complained about it, so I put the restriction.
It is redundant now. Mainly with increased screen sizes since 2017 when I put it there 😄
I am not able to fix it till the end of the weekend, maybe next week, but no promise there too as I am busy with other app currently 😢 But definitely, I want to remove it.


[Scope Change] table 263 "Intrastat Jnl. Line", procedure IsVendorPrivatePerson

Please change the scope of procedure IsVendorPrivatePerson to public.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update iterator.md, fix word spelling error

change exercise 8 to be editable.

Someone has made the same PR. I will close this one.


No Module named image

The main.py scripts throws an Import Error. I tried installing image from pip but the problem is still he same.

Pull request sent to address the issue.

Validation failed
Kindly edit at your end

@dhuadaar
That error can be rectified by editing feature.py

Install PIL(Python Imaging Library) using:
pip install Pillow
Remove import Image as im
Replace image = im.open(imagepath) as image = Image.open(imagepath)
It will work without any error :)


HDFS-16431. Truncate CallerContext in client side.

JIRA https://issues.apache.org/jira/browse/HDFS-16431
Description of PR
The context of CallerContext would be truncated  when  it exceeds the maximum allowed length in server side. I think it's better to do check and truncate in client side to reduce the unnecessary overhead of network and memory for NN.
How was this patch tested?
Add some UTs to test the context would be truncated correctly .
For code changes:

Refactor CallerContext.Builder constrctor to simplify usage
Do context truncate before CallerContext.Builder.build()

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 42s

trunk passed

+1 :green_heart:
compile
23m 51s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 11s

trunk passed

+1 :green_heart:
mvnsite
4m 28s

trunk passed

+1 :green_heart:
javadoc
2m 48s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 22s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m 14s

trunk passed

+1 :green_heart:
shadedclient
24m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  7s

the patch passed

+1 :green_heart:
compile
26m  7s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
26m  7s

the patch passed

+1 :green_heart:
compile
22m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 59s
/results-checkstyle-root.txt
root: The patch generated 6 new + 119 unchanged - 2 fixed = 125 total (was 121)

+1 :green_heart:
mvnsite
4m 18s

the patch passed

+1 :green_heart:
javadoc
3m 11s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m 38s

the patch passed

+1 :green_heart:
shadedclient
25m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  5s

hadoop-common in the patch passed.

+1 :green_heart:
unit
234m 45s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
21m 14s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

508m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3909

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 35a0cc69ab32 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 043e5dd52ca39c01c381caa63c77fb430ff83ab8

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/1/testReport/

Max. process+thread count
3365 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m  2s

trunk passed

+1 :green_heart:
compile
24m 30s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 59s

trunk passed

+1 :green_heart:
mvnsite
4m  5s

trunk passed

+1 :green_heart:
javadoc
3m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 22s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 38s

trunk passed

+1 :green_heart:
shadedclient
24m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
23m 35s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 35s

the patch passed

+1 :green_heart:
compile
20m 41s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 54s
/results-checkstyle-root.txt
root: The patch generated 2 new + 119 unchanged - 2 fixed = 121 total (was 121)

+1 :green_heart:
mvnsite
4m  8s

the patch passed

+1 :green_heart:
javadoc
3m  5s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m  0s

the patch passed

+1 :green_heart:
shadedclient
24m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 17s

hadoop-common in the patch passed.

+1 :green_heart:
unit
377m 27s

hadoop-hdfs in the patch passed.

-1 :x:
unit
32m 48s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

658m 54s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3909

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 412b4648a089 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da97e441f4aba50a87937010946a4411e9235dad

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/2/testReport/

Max. process+thread count
2003 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The checks failed seems because the unrelated tests failed for timeout, @jojochuang colud you help take a look?

Hi @jojochuang @sodonnel @Hexiaoqiao , could you please help take a look?

trigger jenkins

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 53s

trunk passed

+1 :green_heart:
compile
24m 36s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m  8s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 51s

trunk passed

+1 :green_heart:
mvnsite
4m  5s

trunk passed

+1 :green_heart:
javadoc
3m  6s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 23s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 26s

trunk passed

+1 :green_heart:
shadedclient
24m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
23m 43s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 43s

the patch passed

+1 :green_heart:
compile
20m 59s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 59s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 50s
/results-checkstyle-root.txt
root: The patch generated 1 new + 119 unchanged - 2 fixed = 120 total (was 121)

+1 :green_heart:
mvnsite
4m  3s

the patch passed

+1 :green_heart:
javadoc
3m  0s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
4m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 59s

the patch passed

+1 :green_heart:
shadedclient
24m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
26m 44s

hadoop-common in the patch passed.

+1 :green_heart:
unit
380m 45s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
33m 22s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

671m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3909

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8579feb2e775 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cb5e03a4bfd8bc51a803e149894a9cb9bb8a78da

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/3/testReport/

Max. process+thread count
2261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3909/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @jojochuang @sodonnel @Hexiaoqiao @ferhui  , could you please help take a look?

Thanks @smarthanwang involve me here. I am not very familiar with CallerContext. I think @jojochuang should be the good candidate to review it.

Thanks @smarthanwang involve me here. I am not very familiar with CallerContext. I think @jojochuang should be the good candidate to review it.

@Hexiaoqiao thanks for your reply~

@jojochuang @ferhui cloud you take a look?


public PlotArea

Hi,
I need to draw things in the background of the plot area at precise position. For now I just modified source code to get access to PlotArea, but I would not want to modifie source code.
Maybe Chart object could provide a background canvas to draw on, or is their a better way already present.
Ps : Is there a better place to discus about Live Chart (forum, etc) or is this the place to ?

please see
https://github.com/beto-rodriguez/Live-Charts/blob/master/ChartsTest/Line Examples/UiElementsLine.xaml.cs
Plot are is privite but LiveChart lets you get the the current Canvas.
By now this is the way to discuss about LiveCharts, you can try StackoOverflow but since this is a new project maybe I will be the one anwering your question

please let me know if this solves your issue.

Nice, that's what I need, thank you very much.
Le 14/01/2016 13:12, Alberto Rodriguez a écrit :

please see
https://github.com/beto-rodriguez/Live-Charts/blob/master/ChartsTest/Line Examples/UiElementsLine.xaml.cs
Plot are is privite but LiveChart lets you get the the current Canvas.
By now this is the way to discuss about LiveCharts, you can try
StackoOverflow but since this is a new project maybe I will be the one
anwering your question
—
Reply to this email directly or view it on GitHub
https://github.com/beto-rodriguez/Live-Charts/issues/62#issuecomment-171628550.


Immutability

Description
Hi Prof is immutability just having a setter method that returns a new object? Shouldn't the client create a new object instead of relying on the setter method of an existing object?
Topic:
Specific Topics this question is related to (If Any)
Screenshots
Screenshots (if any)
`

I believe immutability is simply ensuring that your created objects do not undergo state modification.
If I remember correctly, prof discouraged the use of setter methods because they easily violate the principle of encapsulation if you forgot to tweak your code in certain areas such as:

Creating a new instance for setters
OR
Including private and final modifiers

Hence you are right that setter methods are technically irrelevant. We should instead create a separate method that allows instancing of new objects.
But the key idea here is that there is no fixed way of doing something. Someone might decide to include a setter method that does not violate the OOP principles. It is perfectly valid. Find a style you are comfortable with to create maintainable code.
I hope this paints a better image of OOP.

One does not typically write a setter method just to set certain properties.  Take for example, scaling a Circle by a certain factor.  Although we can have setRadius(double r) method, it is more appropriate to have the method scale(double factor).  Now we have to consider what is the return type of scale.  If it's void, then we have mutable state, which is undesirable.  To preserve immutability, the return type should be Circle, and hence
   return new Circle(this.centre, this.radius * factor);
}```
Notice that from the client's perspective, the use of the `scale` method is simply `circle.scale(2.0)`, rather than violating Tell-Don't-Ask as in `circle.setRadius(circle.getRadius() * 2.0)` or `new Circle(circle.getCentre(), circle.getRadius() * 2.0)`.  Also realize from the latter that relying on the client to deal with creating immutable objects via `new` is too cumbersome.


Max throughput of Random traffic

Hi,
I got the max throughput of 2d 6x6 Mesh with Random traffic is about 0.07 flits/node/cycle for 1 VC (4 buffers).
Is this an expected result ?  Thanks
---Z. Liu

// This is the said test configuration:
class MyNoC6x6Config extends NoCTesterConfig(NoCTesterParams(NoCParams(
topology        = Mesh2D(6, 6),
channelParamGen = (a, b) => UserChannelParams(Seq.fill(1) { UserVirtualChannelParams(4) }),
ingresses       = (0 until 36).map { i => UserIngressParams(i) },
egresses        = (0 until 36).map { i => UserEgressParams(i) },
flows           = Seq.tabulate(36, 36) { (s, d) =>
if (s != d) Some(FlowParams(s, d, 0)) else None }.flatten.flatten,
routingRelation = Mesh2DDimensionOrderedRouting()
)))

How are you measuring throughput? When the offered traffic exceeds the capacity of the network, throughput will plummet. Here is an example result from PPIN:

Hi, Jerry.  Thanks for the valuable info.  I increased the ROB entry size to 1024 in TestHarness.scala, and make sure each Node (Ingress node) can only allocated up to 16 entries (16 * 36 < 1024),  and the packet size is 1 flit.  Then I run the test with random traffic for 10^6 flits totally.  I print the throughput using "total_flits/total_cycles/36",   as "flits per cycle per node".   Based your above graph, my test probably corresponds to the decreasing region ?

From PPIN:

The capacity is deﬁned as the best possible throughput, assuming perfect routing and ﬂow control, that could be achieved by the network under the given trafﬁc pattern.

You may want to look at running the EvalHarness classes, those will throttle traffic and measure the throughput for you.


Go to definition misses the target if a region is unfolded

Type: Bug
Steps to reproduce:

Create some method in one .cs file, surround it by a #region and fold/collapse that (the method must be 2 or 3 pages into the region to actually see the issue)
Open another .cs file and call the first method
Place the text cursor on the method call and press F12 (or select "Go to definition" from the context menu)

Now the file that contains the definition is activated and the region around the method is unfolded/expanded. But the scroll position is now wrong. The method definition is scrolled out of view and no longer visible. I need to go back to the previous file with Ctrl+Tab and press F12 again to finally get to the definition (or use the mouse to bring the scrollbar down to the cursor position).
I'm not sure if this is a VSCode core problem, but it's this extension that provides the F12 feature, so I'd start here.
Extension version: 1.25.2
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T16:59:02.252Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.71GB (7.78GB free)

Process Argv
--folder-uri file:///c%3A/Source/Komprenu/Kappa-Indect/core-daemon-cs --crash-reporter-id 1b00a758-578c-4b77-a258-fe145c18e004

Screen Reader
no

VM
22%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1cf:30587006
2e4cg342:30602488
pyind779cf:30647092
89544117:30613380

Also affects links to source files from the process output, for example exception stack traces. When Ctrl+clicking on such a file and line number, the file is opened and the relevant region is expanded, but only after scrolling to the (collapsed) region. The target line is not visible then and another Ctrl+click is needed.


PR updated. Main index file unchanged.

I undo all the changes that I made in main index file and is now generating a new PR.
Fixes #231
Thank you soo much for contributing to our repository 💗

Thank you @uzmaansari23 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Arun9739 done sir!

@uzmaansari23 Plz add the entry of your game into the main README file.

@Arun9739 I've to add the entry in the main readme file or create a readme file for my game in its folder?

@uzmaansari23 Remove the .vscode folder and resolve branch conflicts.

@Arun9739 done sir

we are already having the game and you are having same UI also we can't have exact same games !!!!

Thank you  @uzmaansari23 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Update packages and ocaml to 4.13.1

tls-lwt needs to be upgraded so letters works with sihl-email. I took the opportunity to update all other packages and OCaml (but not to 5, as not all of the OCaml environment is ready for it yet)

@joseferben Please review


make different Texstyle in TimePickerThemeData

hi, can you help me how to make different styles for hourMinuteTextStyle, I need to change the line height in the input filed

without line height, this is the result:

Originally posted by @yousefak007 in https://github.com/flutter/flutter/issues/131247#issuecomment-2041111359

@yousefak007
this is probably the wrong channel for this request, you can find the link when you open an issue at the bottom

hi @iapicca, I think this is an issue because TimePickerThemeData doesn't allow you to make different styles for different input modes, you just have hourMinuteTextStyle to make the TextStyle, and as you see in the images above, you can't manage the height of the line in input filed.
i need to make different line heights for hourMinuteTextStyle based on different input mode
timePickerTheme: TimePickerThemeData(
             ...
              hourMinuteTextStyle:
                  FontTheme.r38.copyWith(height: 2),
            ..
),

@yousefak007 I see the height still can be applied as the demo below (on Flutter 3.19.5):

Demo

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
          timePickerTheme: const TimePickerThemeData(
        hourMinuteTextStyle: TextStyle(fontSize: 20, fontWeight: FontWeight.bold, height: 3.0),
      )),
      home: const NewWidget(),
    ),
  );
}

class NewWidget extends StatelessWidget {
  const NewWidget({
    super.key,
  });

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TextButton(
          child: const Text('Show'),
          onPressed: () {
            showTimePicker(context: context, initialTime: TimeOfDay.now());
          },
        ),
      ),
    );
  }
}

What is your current Flutter version? If your Flutter version is not the latest one, please try upgrading and retry. Otherwise, please provide all information indicated in the issue template so that we can address the issue properly (See bug issue template here)


Release Alpha.0

[ ] Improve measure calls
[ ] Animation examples .. "web-ish" maybe 😂
[ ] Improve JSI usage
[ ] Test each prop supported
[ ] Name this Layout

Many names for the layout have been suggested. I am going to list them here.
<Flex/>
<Grid/>
<Container/>

I would suggest creating 3 base elements for layout. Flex, Grid & Container. The Container can be styled as both grid/flex as needed while Flex & Grid follow their respective layouts. This will give a clear understanding of layout at a glance.
<Box/>

This is also a great option. Short & Concise. Already  used by many web UI libraries in their design systems.
<DivLayout/>

If we want to stick to the nativescript way of naming layouts, this seems most suitable I think.
And here's a list of other name suggestions that were discussed upon:
<TriniDiv/>
<Layout/>

<FlexLayout/>

<DiView/>
<MasonView/>
<Block/>
<Structure/>


cargo apk -- build --release doesn't build in release profile anymore

I'm trying to use cargo-apk to only build a shared library from Rust which then I'll load and use from a "regular" (Java+Kotlin) Android project - so I don't need any APK generation, code signing, etc. from cargo-apk.
I was using cargo apk -- build --release for this, as suggested here: https://github.com/rust-windowing/android-ndk-rs/issues/326#issuecomment-1214638774
This used to work well, however, since then, it has stopped building in release mode for some reason, as can be seen here:
https://github.com/torokati44/ruffle-android/actions/runs/3623790481/jobs/6110051919

Perhaps this was caused by https://github.com/rust-windowing/android-ndk-rs/pull/363.

This is specifically caused by https://github.com/rust-windowing/android-ndk-rs/pull/363/commits/e2b9db4235138ee7e24d2c57c797a6c85698e0b2 as args.update_from_arg_matches(&m).unwrap(); is setting Args::release back to false if --release wasn't present in the new args.
I'll investigate if this is intended, if there's a way around it, or if I should just revert that specific commit.

Thank you for the quick fix, now it works just as well as before!


revert: don't make loadUserInfo configurable because web disabled it

Description
As discussed here https://github.com/owncloud/ocis/pull/7714#issuecomment-1812047910 we're removing the env var for making the LoadUserInfo bool configurable. Reason is that oC Web disabled fetching the userinfo via oidc entirely. There are different endpoints in oCIS where we get all the userinfo, so we want to omit the userinfo request entirely.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

Tooling question: is it safe to git revert the merge commit? There is a lot of documentation related CI magic happening (updating last modified dates, updating env var parts in the documentation). What's better, crafting a fresh commit which manually undos the changes or git revert the merge commit?

@kulmann Thanks for taking care. Pls merge before codefreeze.


jlcpcb production files for v3

May I kindly request if you could provide the bom, xml and cpl files as part of the v3 final release? I understand that it's not hard to produce them using kicad, however given the amount of options that a user can configure while producing the files, it's a bit less intimidating, and more beginner friendly if they can bypass kicad completely.
Thanks again for your awesome work and for considering my request!

JLCPCB has a howto on this exact topic.
https://jlcpcb.com/help/article/16-How-to-generate-Gerber-and-Drill-files-in-KiCad-6
These instructions are for version 6 of kicad, but the dialog sections and options are all still the same on kicad version 8.

Sorry, I will no longer be updating for v3 🙏


mobile browser, withattr textarea, fast typing

If fast typing, often not all symbols are displayed, displayed with a delay
iphone 4 + ios 7, safari
It is inevitable for weaker phones? You had such a problem?
var config = {
onkeypress: m.withAttr("value", c.value),
value: c.value()
};
m("textarea", config);

I have a textarea in my sample app, it works perfectly fine using oninput
m('textarea#pad.col-md-6[placeholder="Write your text here"].full-height',{oninput: m.withAttr('value', ctrl.content) })

with ctrl.content just being a simple m.prop()

There may be a meaningful distinction between oninput — which simply reacts to native form input behaviour — and onkeypress, which is a lower-level event which has the capability of interrupting, transforming or cancelling native input behaviour.

yeah, as others said, use oninput. Onkeypress is not reliable


What About BowerCDN?

Hi!
I could not find a better way to reach out other than IRC, I wanted to see if the project maintainers were interested in working with me on the BowerCDN service. It is located at https://bowercdn.net and works very simple.

Search a package on bower
Select a version
Use CDN URLs

The hosting is done on a redundant server setup and then through a Cloudflare account which I have sponsored since 2013 and will continue to sponsor.
What I would like to do is just attach the CDN service to the project and work with the maintainers to make sure it is operating correctly. Regardless of the state of Bower, I believe these projects continue to serve a useful purpose.
Please let me know your thoughts.
Thank you!

Hello,
We recommend community to focus on one package ecosystem, which admittedly npm's. For this there are already cdn solutions available: https://unpkg.com/
Even then CDN are way of centralising and single point of failure. In fact I think the worst thing about Bower is that it even has a  registry, because it'll stop working as soon as we turn server down.
I've done something like this before: https://rails-assets.org/ and while at the time it seemed a good idea, a far better solution would be to create tool that can install bower packages in rails directly from source (github). Now we need to maintain and pay money for maintaining this CDN.
I'm sorry but personally I'd discourage you to pursue this project. If you still do, best of luck! :)

Thanks for that. Noted.


Infinite loop on obtaining yammer groups

Closes #4048

Thank you @MathijsVerbeeck
We'll review it ASAP!


Show build status from Travis CI on README.md

This PR updates README.md to show build status. The status is from Travis CI.

@dmikurube Please take a look when you have time

Thank you! Merged.


[BUG] operation is not set

Hi !
To start the script, I getting this error on Fedora 36
sudo ./dnf-export-import-pkgs.sh
./dnf-export-import-pkgs.sh: line 81: operation is not set

Hi @0n1cOn3, thanks for reporting that!
Looks like that slipped through my checks after one of the latest changes since I initially tested that case for sure and it should have returned help message.
In fact, I'm now redesigning the whole approach to include flatpak as well and include test automation. I'll make sure to cover the case.
Will comment again when new version with the fix is released.
Thanks again!

I have written a script myself but I just can't get the function to read in the created list from dnf^^.
And now I am in the same place with your script.
sudo ./dnf-export-import-pkgs.sh -o import -p /home/backup/files
= It doesn't load, it exports instead :S


⚠ ClamAV has degraded performance

In d101ce6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 212 ms

Resolved: ClamAV performance has improved in fe0dc6d.


Fix the WASM build

For some reason it was panicking when trying to import json.{dumps,loads}, so I just switched to using plain rust functions straight from json.rs.

I am going to merge this just in order to stop the CI builds from failing, but I feel like the VM methods are a good compromise for concerns regarding leaking internals.


Use steps.Compile for mach package on Buildbot

We use ./mach package -r to package Android APKs on the android-nightly builder; the next step is then to upload the built package via S3.
Currently, the packaging step is broken (should be fixed by #290); however, even though it fails, Buildbot still tries to run the next step of uploading to S3. This is because there is no heuristic for ./mach package and it is run as a regular ShellCommand.
Instead, we should add a heuristic in the make_step function in the buildbot/master/files/config/factories.py file that checks for ./mach package and uses steps.Compile to create that step. This a) is a closer semantic match (we're "compiling" the APK), and b) will stop the build if the packaging fails, so Buildbot doesn't try the S3 upload step.
This can simply check for package as an argument to mach instead of using a more complicated regex as the other heuristics do, because currently there is only one type of packaging: Android APK.

I would like to implement this. If I understand correctly, we should check that mach_arg re.matches "package"and assignstep_class = steps.Compile`. Right?
I'll get to it later today

@lucasloisp that's correct! I've assigned this to you, leave a comment if you have any questions.
Note: there are currently two copies of make_step, make sure to update both of them.

Fixed by #503.


module import precedence mistake in the Python imports article

Hello,
First of all excuse me if this isn't the right place to post this, i didn't really know how to get in touch so I figured a Github issue would be the best way to do it.
I was reading your post regarding imports (https://chrisyeh96.github.io/2017/08/08/definitive-guide-python-imports.html), which I found instructive & well written, but there's a small point I think is wrong.
Here's the excerpt:

The Python documentation goes on to mention the following:

The directory containing the script being run is placed at the beginning of the search path, ahead of the standard library path. This means that scripts in that directory will be loaded instead of modules of the same name in the library directory.

This seems to be a mistake. For example, calling import math in start.py will import the standard math module, NOT my own math.py file in the same directory.

The documentation is correct: the described behavior applies to modules in the standard library directory. The math module is a builtin module (like the sys module), guaranteed to be always available, and thus not implemented as a separate Python file in the standard library.
If you name your own module argparse for example, it will indeed have precedence over the argparse module in the standard library.
Hope I was clear, and thanks again for your excellent post. Cheers !

It`s strange if you do somethings like these inside test dir

touch collections.py
python
import collections

the collections standard module will be imported other than the collections.py
Also Ipython behaves different than the standard python interpreter, Ipython will always import the standard library instend of random.py / collections.py under test dir
Env: virtualenv python3.6.5

@chrisyeh96 ，thanks a lot for your well-organized and instructive post regarding python import. For module import precedence on built-in modules , similar to this article, it's proved on my computer (MacOS Mojave, python 3.6/3.7)  that math is not in sys.builtin_module_names and the math.py file in my working directory will be imported before builtin module math. So, I think only those "builtin modules" in sys.builtin_module_names have precedence over the directory containing the script.
ps: here, builtin modules refer to those

Some modules are written in C and built in to the Python interpreter

. reference python doc.
Below is the output information of math module.
`
>>> import math
>>> math
<module 'math' from '/Users/xxxx/.pyenv/versions/3.6.5/lib/python3.6/lib-dynload/math.cpython-36m-darwin.so'>
`


Fix DWC export month field

Thanks @LordFlashmeow. @mabecabrera this should fix the month problem you saw in DwC export.


Avoid conda 24.3.0 breaking conda-build

Checklist

[X] Used a static YAML file for the patch if possible (instructions).
[ ] Only wrote code directly into generate_patch_json.py if absolutely necessary.
[x] Ran pre-commit run -a and ensured all files pass the linting checks.
[ ] Ran python show_diff.py and posted the output as part of the PR.
[X] Modifications won't affect packages built in the future.

conda 24.3.0 deprecated some stuff that conda-build still used (see https://github.com/conda/conda-build/pull/5221).

If we end up updating the run-constraint in https://github.com/conda-forge/conda-feedstock/pull/232, then this repodata patch is actually not strictly speaking necessary (but still doesn't hurt). Inversely, now that we have the repodata-patch, we don't categorically need the run-constraint, but it would IMO be the cleaner (because more explicit) way to do it.

Thanks all!

BTW, upstream is preparing some CI checks such that we should catch these things much earlier: https://github.com/conda/conda-build/pull/5244 .


"Unexpected token *" when used "**"

Hi!
in VS Code used Code Runner v0.12
I try to run code in js file (js-file.js):
let x = 2;
console.log(x**3);
instead of expected = 8, output:
js-file.js:2
console.log(x**3);
^
SyntaxError: Unexpected token *
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:549:28)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.runMain (module.js:611:10)
at run (bootstrap_node.js:387:7)
at startup (bootstrap_node.js:153:9)
[Done] exited with code=1 in 0.236 seconds
P.S.:
I have already reinstalled VS Code and Code Runner, but the issue is the same...
WHAT and WHERE should be to do to fix it????????????????????????????????????
P.S.#2:
An answer similar to:
"This seems like an issue with your code, configuration/project setup, or the code runner extension", -
that's NOT the answer!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
IF you don't understand why -> NO action is taken to FIX the issue!.!

Sorry, VS Code is not running your code. Node or an extension is running your code. If there is a runtime error then it's going to be an issue with your code or system configuration. If you think that vscode is doing the wrong thing, then please explain what vscode is doing wrong.
From the error, maybe you are using an old version of node.

 Or cant read?
"instead of expected = 8, output:
<...>
SyntaxError: Unexpected token *"
The issue is NOT reproduced in browser AND on other comp!
I need steps to fix it!


Define good default chunks for seismic CDP gathers

Intro
This is regarding regularized CDP offset gathers and is pre-stack.
We need to define good default chunk sizes that satisfy multiple use cases (see access patterns below).
Keys
3D acquisition:

Inline
Crossline
Offset (or Angle)

2D acquisition:

CDP
Offset (or Angle)

+ Time or depth for both.
Access Patterns

Full traces for a geographic point ([il, xl] or CDP)
Visualization (tiled rendering); means we chunk sample axis
Be able to re-chunk into offset/angle volumes (i.e., split the ensemble in 3D)
Power of 2 chunk sizes for ML applications
(holy grail, but rare) also support time slices on offset/angle planes

Sizes

Support 2D and 3D CDP gathers
3,000 - 7,000 time or depth samples
100 - 300 offset values (or 5 - 25 angle values). Usually more offsets on 2D.
4TB+ files

will do this later as a part of MDIO v1.


Error picking mysql as database (typo on config.py)

Error picking mysql as database
transifex_project [my-site]:
Select database:
1 - postgresql
2 - mysql
Choose from 1, 2 [1]: 2
Select elasticsearch:
1 - elasticsearch6
2 - elasticsearch5
Choose from 1, 2 [1]:
Unable to create file '{{cookiecutter.package_name}}/config.py'
Error message: 'cookiecuteter' is undefined

ops. duplicated with #8


pkg/strconv: ParseFloat does not parse anything

What version of CUE are you using (cue version)?

$ cue version
cue version v0.3.0-beta.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?

$ printf "import \"strconv\"\nstrconv.ParseFloat(\"1.356\", 64)" | cue eval -

What did you expect to see?
1.356

What did you see instead?
invalid float

This, however, does work:
$ printf "import \"strconv\"\nstrconv.Atoi(\"1\")" | cue eval -
1

diff --git a/internal/core/convert/go.go b/internal/core/convert/go.go
index 2f0fdc50..2ded0396 100644
--- a/internal/core/convert/go.go
+++ b/internal/core/convert/go.go
@@ -356,12 +356,16 @@ func convertRec(ctx *adt.OpContext, nilIsTop bool, x interface{}) adt.Value {
        case float64:
                n := &adt.Num{Src: src, K: adt.FloatKind}
                _, _, err := n.X.SetString(fmt.Sprintf("%g", v))
-               ctx.AddErr(errors.Promote(err, "invalid float"))
+               if err != nil {
+                       return ctx.AddErr(errors.Promote(err, "invalid float"))
+               }
                return n
        case float32:
                n := &adt.Num{Src: src, K: adt.FloatKind}
                _, _, err := n.X.SetString(fmt.Sprintf("%g", v))
-               ctx.AddErr(errors.Promote(err, "invalid float"))
+               if err != nil {
+                       return ctx.AddErr(errors.Promote(err, "invalid float"))
+               }
                return n

        case reflect.Value:

I'm new to this, but can take a look, if somebody can hold my hand if I get stuck or lost :-)
I think this is not a bug in strconv, but in convert. So it also affects instance.Fill() etc.
convert has tests for this, but convert.GoValueToValue() that is used for the tests doesn't notice whether the context has an error. I'm not sure whether GoValueToValue() should return an error value in this case, like for instance GoTypeToExpr() does. If I make this change, then all test pass, except that the tests for the buggy floats now trigger. Then, the patch in my previous comment makes the tests pass again.

This issue has been migrated to https://github.com/cue-lang/cue/issues/749.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


[modify] gws/report : create memo notice in report notification (m43)

Coverage decreased (-0.02%) to 79.466% when pulling d5589a8870b3b048aaeee3e0c0924a018e9c504e on itowtips:fix-gws-43 into 1ff03a721b7a9e64f2742821e72a20c36188534f on shirasagi:master.


Added support to pass application id to user agent string

Resolves https://github.com/Azure/azure-sdk-for-java/issues/14729

This looks fine pending @hemanttanwar's comment about possibly waiting on this

Plan is to merge this to resolve the customer reported issue. When ClientOptions is actually released, we will preferentially chose that over HttpLogOptions app Id


Disable on mobile & Poster Feature

Hi,

as you ask for feature request. I'm thinking of disabling video playback
on mobile because of perfomance.
This would mean you only add the video Tag dynamically if you aren't on
mobile.
Thats my approach to this (in jQuery):
  $.fn.videoBackground = function(video, callback) {
    var that = this;

    //append a video tag to the target element
    that.append($('<video id="vide-showreel">')
        .attr({'autoplay': 'autoplay', 'muted': 'muted', 'loop': 'loop'}));

   $("#vide-showreel").append($("<source>").attr({"src": video, type: "video/mp4"}));

    callback();
  }

    var mobileTest = false;

    if (/Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent)) {
      mobileTest = true;
    }

    if(!mobileTest) {
      $('.fullscreen-video').videoBackground("#vide-showreel", function() {
        video = new videoResize({element: '#vide-showreel', fit: 'cover'});
        video.init();
      });
    }

HTML:

You think thats a good approach to solve this kind of problems?

Fullscreen Video - Image Fallback - thats something I'm missing here.

Regards Kevin

Hey Kevin,
I've spent the last few days looking into what will make mobile loading more efficient. I've come up with a bit of an experimental approach, it'll all be documented in the v0.6.6 release which I'll post later.
Could you explain what you mean for 2) in a bit more detail?
Cheers,
Rob

The second seems just to be a image until the video loads.

The poster image will be replaced by the first frame of the video once it loads, so it makes sense to derive that image from the same first frame.

Here is my finished approach to disable on mobile. It isn't very modular, so no real options
can be passed. Not good for public use
HTML
    <div class="fullscreen-video">
         data-background="<?php echo get_template_directory_uri()."/bg_image.jpg" ?>"
         data-video-src="showreel.mp4">
    </div>

JS
  $.fn.videoBackground = function(video, callback) {
    var that = this;

    var videoID = "#"+video;

    //append a video tag to the target element
    that.append($('<video id="'+video+'">')
        .attr({'autoplay': 'autoplay', 'muted': 'muted', 'loop': 'loop'}));

   $(videoID).append($("<source>").attr({"src": that.data("videoSrc"), type: "video/mp4"}));

    callback();
  }

  var fscreenVid   = $('.fullscreen-video');

  if(mobileTest) {
    fscreenVid.fadeIn("fast").videoBackground("vide-showreel", function() {
      video = new videoResize({element: '#vide-showreel', fit: 'cover'});
      video.init();
    });
 } else {
      // mobile stuff
      fscreenVid.css({"background-image" : 'url('+fscreenVid.data("background")+')'});
    }

I've just updated it to v0.6.6 which will do all this automatically. So what you can do is leave the <source tags out of the <video> and add them as a sources argument, like this:
video = new videoResize({element: '#vide-showreel', sources: 'video.mp4'});

And then your <video> tag would be like this:
<video id="vide-showreel" poster="video.jpg" autoplay loop></video>

Then using the mobileBreak option specify the screen width at which you want to transfer to the mobile layout.
video = new videoResize({element: '#vide-showreel', sources: 'video.mp4', mobileBreak: 480});

Hope that works, let me know.
R


Fixes app_store_build_number when finding latest version

Fixes #11712
Wuuuuttttt

app_store_build_number assumed build version numbers were only integers and sorted by that

Build version number can actually be strings and should be semantic versioned
Now uses Gem::Version to order build numbers
This works for integers, floats, string, and semantic strings
Will properly order - [3,'1','2.3',9,'6.5.4','11.4.6',5.6]

This no longer works after this was merged.
increment_build_number(
  build_number: latest_testflight_build_number + 1,
  xcodeproj: "mfa.xcodeproj"
)

How do I increment by one? Do I need to cast to numeric?

So AFAIK, this is returning a String now, when version_number could be either a String or a Number but to avoid breaking your current code we might just cast to a number, what do you think @joshdholtz


adding an offset parameter to support paging through all activities

Adds an optional parameter to support offset in the recent_activity method on League.
The benefit of this is the code for retrieving recent activity (1000 events in my example) can be more finely controlled.
league = League(...)
activity = league.recent_activity(1000)

is now
league = League(...)
offset = 0
limit = 25
for True: # Implement a stopping condition
    activity = league.recent_activity(limit=limit, offset=offset)
    offset += limit

Looks like my editor also removed some blank space, I can add that back if it makes the PR tougher to read.

Codecov Report
Patch coverage: 70.00% and no project coverage change.

Comparison is base (81f8967) 80.36% compared to head (c22e9a2) 80.36%.
Report is 4 commits behind head on master.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   80.36%   80.36%
=======================================
  Files          60       60
  Lines        2109     2109
=======================================
  Hits         1695     1695
  Misses        414      414

Files Changed
Coverage Δ

espn_api/baseball/league.py
65.54% <50.00%> (ø)

espn_api/wbasketball/league.py
40.94% <50.00%> (ø)

espn_api/basketball/league.py
85.44% <66.66%> (ø)

espn_api/football/league.py
94.52% <100.00%> (ø)

espn_api/hockey/league.py
84.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nice, this is a great addition to recent activity! Thanks for creating a PR and adding this!


Additions of Bypass and fixes to compilation errors

What changes were proposed in this pull request?
initial merging of work
How was this patch tested?
None yet

On a second read through of this I think the line we want to branch off on is here: https://github.com/apache/spark/blob/6a064ba8f271d5f9d04acd41d0eea50a5b0f5018/core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java#L162
Which is a little lower than how it's been done here. I'll give this a try...


Document report: [User Manual | Introduction + Installing]

Description

Check your eligibility

This part could be in only two page

Android
iOS

Are you sure that the way to get the version of the OS is the same on all Android devices?

Installing

Maybe a preview of what the page on Play Store or iOS will look like could be nice

Severity

Critical (Severe impact)

Version
430dc9b
Expected Correction

You should put the tutorial for checking the OS version for iOS on one page and Android on another page.
At the moment, you have 7 pages for only this part.

Other Details
No response

Everything is on one page for each version, however, Android are build the same way no matter which brand you're using, and regarding the Play Store / iOS, maybe we should ask @habicll to produce to do it.

05a1390543d00cef6af39899a9adc1a3bad7856b

The pages are well separated.
Good point, the program manager should have created this page. @LucasAub


macOS: App name is the slug version of the app, not the 'friendly name'

It would be nice if the app had a name of Music assistant rather than the internal productName

I think this might be fixed now. Im gonna try to release a new version later today but im not sure it will work because i dont have the rights to change the signing keys in the github repo.

Thanks for the quick fix! I'll give it a try locally shortly and report back if there's any issues


Query bean miss field definition.

If an entity field with a size annotation, it will be missed in generated query bean:
@Column(unique = true, columnDefinition = "text")
@Size(min = 1, max = 100)
String name;
The name field will be not exist in query bean.
Root cause is the field type returned by field.asType is:
(@javax.validation.constraints.Size(min=1, max=10) :: java.lang.Strring)
It should be escaped by regexp in ProcessingContext.getPropertyType method:
private static final Pattern ESCAPER = Pattern.compile("\(.+ :: (.+)\)");
private static String excape(String typeNameWithAnno) {
Matcher m = ESCAPER.matcher(typeNameWithAnno);
if (m.matches()) {
return m.group(1);
} else {
return typeNameWithAnno;
}
}
...
PropertyType type = propertyTypeMap.getType(excape(currentType.toString()));

I can not reproduce this issue ... I tried using https://github.com/ebean-orm-examples/example-java8
Are you able to fork that and create a branch that fails?

I found the root cause:
validation-api 1.0.0 is fine:

javax.validation
validation-api
1.0.0.GA

But validation-api 2.0.1 fail:

javax.validation
validation-api
2.0.1.Final

Ah cool, thanks.  I'll have a look at reproducing with that later ...
Cheers, Rob.
On 16 Feb 2018 7:40 p.m., "54446776"<EMAIL_ADDRESS>wrote:

I found the root cause:
validation-api 1.0.0 is fine:
javax.validation
validation-api
1.0.0.GA
But validation-api 2.0.1 fail:
javax.validation
validation-api
2.0.1.Final
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ebean-orm/querybean-generator/issues/18#issuecomment-366156255,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMwTTC707KuzudGPGV0SR8T3VK6ZuYyks5tVSLjgaJpZM4SHBNh
.

Hi rbygrave,
Could you please reproduce this issue and fix it?
Hibernate Validator 5x is not compatible with validation-api 1.0.x, and I have to use validation-api 2.x.

Ok yes, reproduced with
    <dependency>
      <groupId>javax.validation</groupId>
      <artifactId>validation-api</artifactId>
      <version>2.0.1.Final</version>
      <!--<version>1.0.0.GA</version>-->
    </dependency>

Working on it ...

Thanks for the investigation etc.  Fixed and released as 11.1.2


How about adding more clear error message for some builtin functions?

Now, % and randint just throw args error; it is difficult to understand why the function failed.
~/go/src/github.com/elves/elvish> % 2 0
Exception: args error
[tty], line 1: % 2 0
~/go/src/github.com/elves/elvish> randint 100 0
Exception: args error
[tty], line 1: randint 100 0

How about adding better error messages for them?

Yes! I would like to have such errors be structured too, like:
type SingleArgError struct {
    Which int
    Want string
    Got string
}

func (err SingleArgError) Error() string {
    return fmt.Sprintf("error with argument #%d: want %s, got %s", err.Which, err.Want, err.Got)
}

Although Want and Got are now strings, in future they can potentially be structured too, as some kind of representation of types.

See also the discussion in issue #966 for why introducing, and consistently using, Elvish structured error types rather than Go's error type is a good idea as it makes it easier to write robust unit tests and makes it easier to provide meaningful introspection of exceptions from elvish code.

I believe this has been addressed by changes made since this issue was opened. Specifically, the two examples in the original problem description has been addressed:
> randint 100 0
Exception: bad value: high value must be larger than 100, but is 0
> % 2 0
Exception: bad value: divisor must be number other than exact 0, but is exact 0

There are undoubtedly other instances which would benefit from such improvements, but without specific examples it's hard to know what to do. I know that I've created several changes recently that replace general errors with specific errors. I recommend closing this issue as, at least mostly, resolved.


Update actions/cache to 3.0

This action throws deprecation notice related to actions/cache due to Node.js 12 being deprecated.

thanks for the heads up!

cc #12

I believe this has been specifically resolved with #12; please reopen though if other deprecation warnings emerge.


All code files need license information in header

Goal: Legal protection
All source code in this repository may potentially be released to customers.  Our standard contracts for Mistral include terms and conditions that cover the licensing and use of source code, we just need to add a copyright statement and a "refer to your contract for full terms" statement to each code file in this repo.
Exact language of the comment to be confirmed.

It was decided to release this code with an MIT license that is in the repository. Does this still need to be done?


Band math when for getTile and getRegion

Would it be possible to provide some sort of callable that will perform a mathematical operation on a single band when tile serving?
Let's say I have some massive Digital Elevation Model (DEM) and I want to dynamically produce Hillshade maps from it. Ideally, I'd like to have the tile server do this automatically when serving the tiles.
I imagine this being some sort of option for both getRegion and getTile so that I can serve tiles with the math applied or get a small ROI with the math applied.
Example math:

import numpy as np

# https://github.com/earthlab/earthpy/blob/9ad455e85002a2b026c78685329f8c5b360fde5a/earthpy/spatial.py#L564
def hillshade(arr, azimuth=30, altitude=30):
    """Create hillshade from a numpy array containing elevation data.
    Parameters
    ----------
    arr : numpy array of shape (rows, columns)
        Numpy array with elevation values to be used to created hillshade.
    azimuth : float (default=30)
        The desired azimuth for the hillshade.
    altitude : float (default=30)
        The desired sun angle altitude for the hillshade.
    Returns
    -------
    numpy array
        A numpy array containing hillshade values.
    """
    try:
        x, y = np.gradient(arr)
    except ValueError:
        raise ValueError("Input array should be two-dimensional")

    if azimuth <= 360.0:
        azimuth = 360.0 - azimuth
        azimuthrad = azimuth * np.pi / 180.0
    else:
        raise ValueError(
            "Azimuth value should be less than or equal to 360 degrees"
        )

    if altitude <= 90.0:
        altituderad = altitude * np.pi / 180.0
    else:
        raise ValueError(
            "Altitude value should be less than or equal to 90 degrees"
        )

    slope = np.pi / 2.0 - np.arctan(np.sqrt(x * x + y * y))
    aspect = np.arctan2(-x, y)

    shaded = np.sin(altituderad) * np.sin(slope) + np.cos(
        altituderad
    ) * np.cos(slope) * np.cos((azimuthrad - np.pi / 2.0) - aspect)

    return 255 * (shaded + 1) / 2

NOTE: This is for a personal project

I could see this being doable for getTile but not necessarily for getRegion as that is really just a wrapped call to gdal.Warp under the hood. With that in mind, I'm wondering if large_image can provide any assistance in performing band math on large images?

Currently, if you add a sufficiently complicated style, we don't just use gdal.Warp -- instead we apply the style and then generate output from that.  This is less efficient, but allows the same style to be used for tiles and regions.
I like this as a concept -- you could apply any available python function that takes a numpy array and emits a numpy array of equal dimensions, and the style would have something like functions=["module1.function1", "module2.submodule2.function2"].  Maybe it would be better for the function to optionally take multiple parameters (, ) -- I'm not sure if anything else would be useful; it would still just return a numpy array.

@banesullivan This ends up being useful for other purposes, too.  We can do the band math on a per-tile basis (which means regions will end up being affected as they are just made of tiles).  There are some limitations: if the math needs a larger area than the tile itself, the function will end up being more complex.  See PR #960.


Comment out print statements

Description
Describe:

Print statements were left in which pollutes stdout for users. This breaks tests of users which use regex to find matching strings in stdout.

References
Fix #66
Checklist

[x] Code lint checked via inv lint
[ ] Tests added

@Sillocan Thanks for the pr :) for this to be merged, could you please:

remove the prints instead of commenting them
make a branch like bugfix/issue-66-remove-debug-print-statements and add a 66.bugfix file inside changes directory with Remove debug print statements as content, so that the CI will pass
Thanks a lot, looking forward to merging this and releasing a new version

@protoroto Do you want this branch made on your repo, or is via a fork OK? (I don't have permissions to create new branches 😄)

Closing this one in favor of https://github.com/nephila/giturlparse/pull/67 with the correct branch name (can't change forks branch)


Add-more-ways-to-recognize-Supercharger-locations

Add more ways to recognize Supercharger locations by treating charge as "at Superchager" when fast charger brand is "Tesla".
I have tested it on my recent trip, and the total cost for Supercharger charges is the same vs what I calculated manually.

For all of my data, it added over £200 worth of charges to the count, in line witch my charging payments on my Tesla account.

Hi, @JakobLichterfeld, do you think can be used?

Hi, @JakobLichterfeld, do you think this can be used?

Generally speaking: yes. Perhaps @jheredianet can take a look into it.

If the old vehicles do not recognize the "Tesla" brand, then the output visible will just be like the current one and they will still need to do a Supercharger Geo-fences. I think.

If the old vehicles do not recognize the "Tesla" brand, then the output visible will just be like the current one and they will still need to do a Supercharger Geo-fences. I think.

Yes, you are right. I've tested and worked ok.
@JakobLichterfeld lgtm

Perfect, thank you both


[tsp-client] Support generating from local spec

See comment: https://github.com/Azure/azure-sdk-tools/pull/6887#discussion_r1332632573
For more information: https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/TypeSpec-Project-Scripts.md#typespec-project-syncps1

Can we not require a commit and repo when doing an init from a local spec? If we do this, then we cant create a valid tsp-location.yaml file so the init would be "incomplete" in that sense.

Cannot do an init with incomplete information


optimize symbolic-related updates in graphs

llama 8b 6gpus:
enqueue in   2.01 ms
total   6.99 ms, 143.01 tok/s, 3084.66 GB/s, param 2299.00 GB/s

vs
enqueue in   4.65 ms
total   7.85 ms, 127.42 tok/s, 2748.32 GB/s, param 2048.32 GB/s

llama 8b 4gpus:
enqueue in   1.39 ms
total   7.28 ms, 137.34 tok/s, 2696.59 GB/s, param 2207.06 GB/s

vs
enqueue in   3.14 ms
total   7.30 ms, 136.99 tok/s, 2689.75 GB/s, param 2201.46 GB/s

If I understand correctly, this dedups the launch_dims that are the same across kernels?


⚠ ClamAV has degraded performance

In 2292fc1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 484 ms

Resolved: ClamAV performance has improved in a9f9a66.


Zero (or little) downtime for Kubernetes upgrades

What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):
Upgrade a Rancher provisioned Kubernetes cluster.
Result:
During the upgrade process, there is service interruption and downtime.
Other details that may be helpful:
According to the docs at https://rancher.com/docs/rancher/v2.x/en/cluster-admin/editing-clusters/

"During the upgrade, your cluster is unavailable."

Ideas/Solution:
For Kubernetes deployments with two or more control planes, two or more workers, and three or more etcd servers, customers have the expectation that the cluster is fault tolerant and highly available. This includes the ability to perform Kubernetes upgrades with zero or minimal downtime. Stating "During the upgrade, your cluster is unavailable." is just not acceptable.
To make upgrades more fault tolerant and HA, the following can be considered:

Make sure the control plane components are updated in a rolling fashion. If you have 3 control plane nodes running 3 kube-apiservers, only bring down and upgrade one kube-apiserver at a time. Once it's confirmed to be up, move on to the next one. Do the same for kube-scheduler and kube-controller.
For etcd nodes, upgrade one at a time.
For worker nodes, have the option to drain all workloads and cordon the node during the kubelet and kube-proxy upgrades.
Consider allowing the end user to specify the batch size for worker node upgrades. Could be worker number or percentage (example, 5 workers at a time, or 20% of workers at a time).
Make sure the upgrade order/process used by Rancher is documented so users know how the upgrade is happening.

Note, appears to have overlap with this issue - https://github.com/rancher/rancher/issues/17057
See also: https://kubernetes.io/docs/setup/release/version-skew-policy/

Yes, I was just testing upgrades out on a 3 master, 3 worker cluster, and first the api server became unavailable, however only for a very short time. Then all the ingresses became unavalable, also only for a rather short time. I can however see that my normal workloads kept running through the upgrade, but were just unreachable due to the ingress controllers being unavailable.
I have been running kops clusters previously, where the process of upgrading nodes, start with masters and then worker. And only one node is first cordoned and drained, and then terminated. Due to AWS autoscaling groups new nodes are provisioned, and finally kops validates that all nodes are ready, and that all kube-system workloads are ready. Then it moves on to the next node.
This method has the added benefit of respecting Pod Disruption Budgets, due to draining the nodes before the upgrade.

Closing in favor of https://github.com/rancher/rancher/issues/23038


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.14.241",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=44651522941c623e20882b3b443f23f77de1ea8b"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "44651522941c623e20882b3b443f23f77de1ea8b",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "scsi: libfc: Fix array index out of bound exception\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.241 by commit<PHONE_NUMBER>1c623e20882b3b443f23f77de1ea8b. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001411


[CONTINT-3702] fix(sbom): Fix mount path retrieval from overlayfs

What does this PR do?
This PR fixes mount path retrieval from overlayfs snapshotter. We also make sure to avoid scanning twice the same image if the cache should not be used
First commit: In containerd, GraphData is empty and cannot be used to check if the image is unpacked with the overlayfs snapshotter.
Second commit: Rename collector.cache as collector.persistentCache and add a useCache argument to clarify when the cache should be used. It should not be used with the new method.
Third commit: Move the ScanFromOverlayfs out of the default function for code clarity

Motivation
Fix scanning directly from snapshotter.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Deploy the agent with the following env var
    - name: DD_SBOM_CONTAINER_IMAGE_OVERLAYFS_DIRECT_SCAN
      value: "true"

And the following settings in helm:
  sbom:
    host:
      enabled: true
    containerImage:
      enabled: true
      uncompressedLayersSupport: false

The error new error should be:
Error: unable to marshal report to sbom format for image sha256:9806192403a17aedfbf50d1996bd3e511ba159497993ed516d1e9fa65175d31f, err: walk filesystem: walk dir error: unknown error with .: stat .: no such file or directory

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

/merge


feat: support passing io.Reader to lockfile parsers

Resolves #176, branched off #186

Landing #260 has made this a bit more complex, because now the requirements.txt parser supports reading extra files based on the contents of the file currently being parsed which would involve another sizable change to the interface.
As such I'm going to put this PR on the backburner until the appropriate internal conversations have happened :)

I'm going to close this for now since it requires rebasing + further discussion anyway, and the changes will still be retained by GitHub in case we want to dig up the implementation.


Not working with SDK 6.3.0

On Titanium 6.3.0.GA module goes in runtime error:
11-21 15:07:08.521   688   688 D AndroidRuntime: Shutting down VM
11-21 15:07:08.523   688   688 E AndroidRuntime: FATAL EXCEPTION: main
11-21 15:07:08.523   688   688 E AndroidRuntime: Process: it.aci.informatica.useyourcard.merchant, PID: 688
11-21 15:07:08.523   688   688 E AndroidRuntime: java.lang.ClassCastException: org.appcelerator.kroll.common.TiMessenger$2 cannot be cast to java.lang.Boolean
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at dk.napp.drawer.DrawerProxy.handleMessage(DrawerProxy.java:68)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:98)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:154)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6165)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:888)
11-21 15:07:08.523   688   688 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:778)

Experienced this today as well. After a lot of debugging it seems, Appcelerator has added a new setting to the TiApp.XML
true
Put that with the other properties before  declaration and it should fix it.

Hi @Marchief
I sorry, but i don't understand. Which setting i must add to tiapp.xml?

I have this module working with 6.3.0.GA on both iOS and Android.

Sorry, forgot markdown, updated my comment.
@trkfabi it works with new projects as the new property is added by default, however, it is not for legacy projects that are upgrading to 6.0 +

@Marchief It works!
Thank you!


Enhance the StyleWrapper classNames generator by adding look around c…

…lassNames depending on the sorounding previous/next blocks.
We've been using this to fine adjust the vertical spacing in our last projects. I had doubts about to push this for core, but I decided that could be beneficial for Volto. The drawback is that they could add quite a lot of classnames to the block, but still, my experience and feedback is quite good. Any help that could come from the code in order to style the blocks is welcomed.

@tiberiuichim I think it's implemented as you commented, soryy I didn't updated the docs, I will do. Take a look at the tests.

@ksuess @tiberiuichim please review again!

@davisagli crap after merge GH updated the page with your comment! I will manually fix it!

typo: https://github.com/plone/volto/pull/4268


assert_result_within_score_range() always uses range of 0-to-1 over range values passed as arguments

Describe the bug
The function assert_result_within_score_range() in presidio-analyzer/tests/assertions.py always uses 0 and 1 as the expected min and max range boundaries, regardless of what range values are passed in through the expected_score_min and expected_score_max arguments.
To Reproduce
Steps to reproduce the behavior:

Choose any recognizer test from presidio-analyzer/tests/
Change the range values to conflict with the current expected range (forcing it to fail)
The test still passes

Expected behavior
Min/max expected range arguments should take precedence over global min/max and constrain range of expected values beyond 0 and 1.
Additional context
The problem is that calls to min() and max() are swapped in the utility library, here:
https://github.com/microsoft/presidio/blob/master/presidio-analyzer/tests/assertions.py#L23-L24

Hi @willsthompson  ,
Thank you for raising this issue and fixing it in the PR :)


International Official Account

Hi,
Does the library support International Official Account?
Thank you.
Regards,
Levente

Could you show me the Document URL?
I guess they have the same rules.

This is what i found:
http://open.wechat.com/cgi-bin/newreadtemplate?t=overseas_open/faq&symbol=faqs-oa-technical

Thank you!
I sampled some APIs, they have the same rules, but different domain name. I'll check more later.
For example:
China - https://api.weixin.qq.com/cgi-bin/menu/create?access_token=ACCESS_TOKEN
International - https://api.wechat.com/cgi-bin/menu/create?access_token=ACCESS_TOKEN

It seems APIs for International Version is very similar.
Does there many developers need the International Official Account support?

@leventeolahx can you leave me an Email address to<EMAIL_ADDRESS>We are planning to create the International Official Account SDK project, before that I have to study something about the OA in foreign countrise.

@JeffreySu I sent you an email

Thanks!


Empty non void tags

Fix #6.
I'd add a unit test but I'd be adding a purescript-halogen dev dependency, as well as a test framework, so I'd prefer input before doing so.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry this got left! Thanks.