Silently ignore matches at the end

I hit the case of index == text.len() a bit.

Oof, that's quite bad. Thanks for the PR! At the risk of being nitpicky, I'd like to be a bit more explicit here, e. g.:
// in the loop
if index == text.len() {
    continue;
}

if mask[index].is_none() {
    mask[index] = Some(rule.do_break());
}

Also, please add a test. Locally I found that this reproduces the error:
    #[test]
    fn ignores_last_match_index() {
        let rules =
            SRX::from_str(&fs::read_to_string("data/segment.srx").expect("example file exists"))
                .expect("example file is valid")
                .language_rules("en");

        rules.split("Hello! ");
    }

Thanks!

Would if index >= text.len() work?
Just thinking of funny cases…

Sure, we can do that.

LGTM. Thanks!

I released a patch 0.1.2 including this fix.


Don't register glazed flags as PersistentFlags()

Currently, as a workaround for making aliases work, we register glazed helper flags as PersistentFlags() so that they get bubbled down to aliases.
This is because we moved the alias framework from sqleton to glazed, and sqleton commands all had the glazed flags registered.
Once we have cleaned up the declarative flags stuff, we will be able to pass down the registered glazed flags along with the command specific flags to aliases, and register them normally. This will probably happen in a second refactor step.

This is done as part of #173


Allow cargo-check to run without waiting for the lock file

I am using IDE (Intelij in my case, but this specific is not important), which runs in-flight check via cargo check and highlights errors and warnings in-line in the editor. I also use cargo watch -x run in separate terminal window to recompile and launch my rust HTTP server-binary application continuously. These 2 are complimentary to each other. However, both are waiting on the same lock file. Tacking into account slow build time, feedback loop is significantly delayed.
I understand, the lock file has got it's reasons for concurrent build tasks, writing to the same target folder. However, cargo check is 'read-only' step, which does not touch binaries (should be as far as I imagine it). I propose to enable cargo check (or maybe all read-only ops) to run without waiting for the lock file. Would it be a big deal to achieve it?

cargo check still emits files from rustc, they're just metadata-only.

Ah yeah unfortunately both of these steps are still writing artifacts into the build directory so they need to be synchronized. @avkonst can your setup be configured for two different target directories perhaps?

@alexcrichton could you please clarify how I configure the cargo run via command line arguments to use different (non-default) target directory? Note: I can not configure cargo check, because it is out of my control (invoked by IDE and uses default target as far as I understand).

@avkonst oh the CARGO_TARGET_DIR env var should do the trick

@alexcrichton great! thank you

Ok! In that case I'll close this, but feel free to comment if it's still not working!

value of CARGO_TARGET_DIR should be added to .gitignore, otherwise cargo watch does not work properly.

Is it possible to set cargo's check dir to something else and keep target as the dir for build?

Yes. It is possible. Set this environment variable before launching your editor. In this case cargo check invoked by ide will use the configured dir.


Azure Storage Explorer crash on Windows Server 2012 R2

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
<IP_ADDRESS>
Regression From
1.18.0
Architecture
x64
Storage Explorer Build Number
No response
Platform
Windows
OS Version
Windows Server 2012 R2
Bug Description
Storage Explorer crash on Start.
C:\Users\Administrador\AppData\Local\Programs\Microsoft Azure Storage Explorer>S
torageExplorer.exe --debug
C:\Users\Administrador\AppData\Local\Programs\Microsoft Azure Storage Explorer>
[9772:0523/212129.835:ERROR:node_bindings.cc(418)] Error parsing Node.js cli fla
gs
electron: [DEP0062]: node --debug and node --debug-brk are invalid. Please u
se node --inspect and node --inspect-brk instead.
Assinatura do problema:
Nome do Evento de Problema:	APPCRASH
Nome do Aplicativo:	StorageExplorer.exe
Versão do Aplicativo:	<IP_ADDRESS>
Carimbo de Data/Hora do Aplicativo:	63ed2870
Nome do Módulo de Falhas:	StorageExplorer.exe
Versão do Módulo de Falhas:	<IP_ADDRESS>
Carimbo de Data/Hora do Módulo de Falhas:	63ed2870
Código de Exceção:	80000003
Deslocamento de Exceção:	01512080
Versão do sistema operacional:	6.3.96<IP_ADDRESS>.272.7
Identificação da Localidade:	1046
Informações Adicionais 1:	f304
Informações Adicionais 2:	f304717eeed43189b7c0d7c053f4a949
Informações Adicionais 3:	de07
Informações Adicionais 4:	de075008503a364672d73c1d55c762a6
Leia nossa política de privacidade online:
http://go.microsoft.com/fwlink/?linkid=280262
Se a política de privacidade online não estiver disponível, leia nossa declaração de privacidade offline:
C:\Windows\system32\pt-BR\erofflps.txt
Steps to Reproduce

Launch Storage Explorer

Actual Experience
Storage Explore crash immediatelly launch.
Expected Experience
No response
Additional Context
No response

@rpotalara if my memory is serving me correctly, this is likely due to your machine having a global environment variables set that is incompatible with the node runtime the current version of Electron we are using includes.
Can you go to your Windows environment variable settings and look for any variables related to NodeJS development, for example NODE_OPTIONS? And then if possible, delete those? Let us know if you don't find anything or if you have something but you can't delete it (and tell us why). Also feel free to share a screenshot of your environment variables too, like this:

Feel free to redact things like I have, but if possible, at least try to leave variable names unredacted.

@rpotalara if my memory is serving me correctly, this is likely due to your machine having a global environment variables set that is incompatible with the node runtime the current version of Electron we are using includes.
Can you go to your Windows environment variable settings and look for any variables related to NodeJS development, for example NODE_OPTIONS? And then if possible, delete those? Let us know if you don't find anything or if you have something but you can't delete it (and tell us why). Also feel free to share a screenshot of your environment variables too, like this:

Feel free to redact things like I have, but if possible, at least try to leave variable names unredacted.

HI!, I can´t find any Node reference:
ALLUSERSPROFILE=C:\ProgramData
APPDATA=C:\Users\Admin\AppData\Roaming
CommonProgramFiles=C:\Program Files\Common Files
CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
CommonProgramW6432=C:\Program Files\Common Files
COMPUTERNAME=SERVER
ComSpec=C:\Windows\system32\cmd.exe
DokanLibrary2=C:\Program Files\Dokan\Dokan Library-2.0.3
DokanLibrary2_LibraryPath_x64=C:\Program Files\Dokan\Dokan Library-2.0.3\lib
DokanLibrary2_LibraryPath_x86=C:\Program Files\Dokan\Dokan Library-2.0.3\x86\lib
ES_HEAP_SIZE=1800m
FP_NO_HOST_CHECK=NO
HOMEDRIVE=C:
HOMEPATH=\Users\Admin
JAVA_HOME=C:\Program Files\Java\Search\Java\jre1.8.0_111
LOCALAPPDATA=C:\Users\Admin\AppData\Local
LOGONSERVER=\SERVER
NUMBER_OF_PROCESSORS=8
OS=Windows_NT
Path=C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;%TFSPowerToolDir%;%BPADir%;C:\Program Files\Azure Data Studio\bin;C:\Program Files\dotnet;C:\Program Files\Git\cmd;C:\Users\Admin.dotnet\tools;C:\Program Files\Azure Data Studio\bin
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
PROCESSOR_ARCHITECTURE=AMD64
PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 44 Stepping 2, GenuineIntel
PROCESSOR_LEVEL=6
PROCESSOR_REVISION=2c02
ProgramData=C:\ProgramData
ProgramFiles=C:\Program Files
ProgramFiles(x86)=C:\Program Files (x86)
ProgramW6432=C:\Program Files
PROMPT=$P$G
PSModulePath=C:\Windows\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\PowerShell\Modules
PUBLIC=C:\Users\Public
SEARCH_ES_INDEX_PATH=D:\TfsData\Search\IndexStore
SESSIONNAME=RDP-Tcp#66
SystemDrive=C:
SystemRoot=C:\Windows
TEMP=C:\Users\ADMIN\AppData\Local\Temp\3
TMP=C:\Users\ADMIN\AppData\Local\Temp\3
USERDNSDOMAIN=DOM.LOCAL
USERDOMAIN=DOM
USERDOMAIN_ROAMINGPROFILE=DOM
USERNAME=admin
USERPROFILE=C:\Users\Admin
VS140COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools
windir=C:\Windows

@rpotalara hmmmm. Alright then. Can you check the properties for whatever shortcut you are using to launch Storage Explorer then? For example, if you are launching the start menu and then searching for Storage Explorer, then do that but instead of launching, right click on the result and click something like "open file location".

Once you are at your shortcut, right click on it and choose properties. Then, go to the Shortcut tab, and look for the Target field. Do you see anything in that text box other than the path to where you have Storage Explorer installed? Feel free to share the value of the text box if you are comfortable.

If this isn't the cause, then I have to admit I'll be at a bit of a loss for what could be causing this. Ultimately we're looking for something that is polluting either the environment variables, or command line flags, when Storage Explorer is launched.

Hi @MRayermannMSFT ,

@rpotalara so that is the actual .exe. Can you try to find whatever shortcut you are using to launch the app?
Also, I just realized what also could be causing this....Storage Explorer no longer support Windows Server 2012 is no longer supported, due to Electron not supporting it: https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice
The last version of Storage Explorer to use an Electron that supported server 2012 was 1.28. Can you try installing and trying that from here: https://github.com/microsoft/AzureStorageExplorer/releases/tag/v1.28.1

@MRayermannMSFT , I no have any other shortcut. I tested version 1.28.1 and you are right! With this version in Windows Server 2012 R2 worked well. :( No updates for me anymore.

I saw that support was extended to October 2023?

Support for Chrome 109/Electron 22 were extended to October 2023, however, we update to a newer version of Electron for each release. You can continue to use Storage Explorer 1.28.1 through October, but you will need to refrain from updating to newer releases.

Correct, thank´s so much.


Unable to place blocks when in proximity of an OP.

Description
Blocks are unable to be placed down for a non-op player, when said player is in range of a OP.

BlockPlaceEvent is not cancelled, and the corresponding block is removed from the player’s inventory after being placed, but the block disappears immediately.

Reproduction Steps

Give one player luckperms.autoop

Have corresponding auto op features enabled.

Have a non op player place a block near the opped player.

Expected Behaviour
The block will disappear, but will not be return to the player’s inventory.

Disablement of the LuckPerms plugin through Plugman fixes the problem.
The OP is not affected.
If no OPs are online, both players are not affected.

Server Details
PaperMC 1.12.2 b1612
LuckPerms Version
v5.4.88
Logs and Configs
No response
Extra Details
No response

Runtime loading/disabling/reloading of LP with Plugman or similar is not supported. Restart your server.
As for the actual issue, LP does not touch any ingame events i.e. block break, another plugin is at fault.


init morefine-m600

The Morefine M600 is an AMD-powered Mini PC
CPU options (all 6000-series mobile):
• R9-6900HX
• R9-6850H
• R7-6850U
• R7-6800H
• R5-6600U
If bought with RAM + HDD, you would be getting DDR5 RAM @ 4800MHz and a NVMe drive, however, it can also be purchased “barebone”.
Things done

[x] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input (will do when I reboot)

bors merge


⚠ Jenkins Plugins Artifactory has degraded performance

In 761fcaa, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1355 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 74574a7 after 25 minutes.


eCAL Mon is not installed

Describe the bug
The new eCAL Mon TUI is not packed into the eCAL Setup. The issue exists on Windows and Linux.

It seems that it is missing the install instructions.
ecal_install_app
see e.g. ecal_play
https://github.com/eclipse-ecal/ecal/blob/0a15d5b7c55a23b4a6f479338d8cc59416b3b405/app/play/play_cli/CMakeLists.txt#L63


Cannot install pyarrow in docker of Apple M1 Mac

One of our team members has experienced issues installing  pyarrow package in the 2.0.2MWAA local runner (Device used:t Apple M1 Mac). It is working as expected in Intel Macs.


Can't install with scheme-less URL

Currently, the app hardcodes the URL provided during installation to lots of (all?) links / references. This causes problems if you want to run the site over HTTP and HTTPS. The easiest solution is to install with a scheme-less URL, e.g. //example.com rather than http://example.com
Unfortunately the installer reports this as an invalid URL (Scheme-less URLs aren't validated by filter_var), so you can't install it like that (Although manually editing the config post-install works well).

Out of interest, why not just use https?

Be careful with schemeless urls. I'm not even sure if they are valid in HTTP, or only in HTML...
many libs may translate "//example.com" into "http://example.com//example.com".

I think the solution is not to allow an url without a scheme but to allow multiple url's (and choose a default one)

Out of interest, why not just use https?
A fair comment. If I was installing anew I probably would, unfortunately I have some repos that I don't control and can't easily change set up with HTTP webhooks, so didn't want to risk breaking those by changing.
An alternative to allowing scheme-less URLs would be to use relative URLs rather than absolute, but not sure if that's feasible.
Either way, this probably sits right at the bottom of any priority pile ;) The workaround is straightforward, and maintainable.

Schema less is a valid URL from RFC-3986 section 4.2 but some external library can manage it in the wrong way, we can:

ignore the problem
use relative path only in the generated markup
have multiple base url, and try to detect the current one

I vote for the second solution, and use schemaless for external dependencies (JS/CSS from CDN).


Remove bonus xp

Description
Resolves #2226.
There are occasional "low effort" submissions from students to gain the early submission bonus XP. This PR fixes this while not changing the workload for the avengers.
Previously, bonus XP will be awarded once students finalize submission. Now, when a student finalizes submission, there will be a check whether the autograder scored the submission as 0 or not. If a 0 was given, bonus XP will be 0. Else it will be the full amount. After the tutor marks finish the submission, another check will be done. If the submission is still a 0. bonus XP will be 0. Else, the full amount will be given.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Case 1: If the submission is 0

Submit a submission where the autograder gives 0
Go to the grading page and grade the submission but do not give any xp
The bonus xp shown is 0

Case 2: If the autograder gives xp

Submit a submission where the autograder does not give 0 (paths)
Go to the grading page the submission bonus xp is given

Case 3: If the autograder is 0 but the avenger awards xp

Submit a submission where the autograder gives 0
Go to the grading page and grade the submission and give some xp
The bonus xp shown is given

Checklist

[x] I have tested this code
[ ] I have updated the documentation

coverage: 94.621% (-0.2%) from 94.822%
when pulling 27c3a6f8269190c6dd3a174bbbcc1c91ca2e9844 on thortol:remove-bonus-xp
into 2f0746b833b036f1038a984e0ea26aeb5a5c35b8 on source-academy:master.

Can we fix the tests?

I fixed the test cases but I found a bug where the bonus xp is given through current time not submission time. This creates a bug where bonus xp is given when the grader grades rather than when the user submits. I'll be working on fixing this before it can be merged.

Can I check that this does not require any frontend change?

Yes, this does not require any frontend change.


df.max()/min() on 1 column df leads to "could not broadcast input array from shape (6,) into shape (5,)" what from parquet loaded with ray

I am still trying to reliably save and load from parquet, but running into new problems.
It seams most of my problems are windows related, as on Linux the experience is a lot less painful.
While atempting to get managable .parquet chunks, I used a partition column.
But modin.read_parquet does not support partition columns and is defaulting to pandas, which exploses my RAM.
ray.from_parquet works though, and with .to_modin() I get a modin dataframe again, that looks fine.
but when I do
df['z'].max()
I get
could not broadcast input array from shape (6,) into shape (5,)

those 2 ints are not always the same though. They depend on the file I load, and I think on the set partitions.
But I cant seam to figure out what they mean.
I tried repartitioning but that did not help.
Any hint whats going on here?
To make my code run on windows as well, it would be great if I could use this workaround. On Linux it seams the modin load and save to parquet methods work a lot better

probably the same issue as here: https://github.com/modin-project/modin/issues/7383


Automated cherry pick of #3778: treewide: 避免使用fmt.Print记录日志

Cherry pick of #3778 on release/2.13.
#3778: treewide: 避免使用fmt.Print记录日志

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@e2b44b1). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #3782   +/-   ##
==============================================
  Coverage                ?   6.94%
==============================================
  Files                   ?     499
  Lines                   ?   84204
  Branches                ?       0
==============================================
  Hits                    ?    5850
  Misses                  ?   77858
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.94% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/loadbalancer_backendstatus.go
0% <ø> (ø)

pkg/cloudcommon/db/models.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b44b1...39ca790. Read the comment docs.

/lgtm

/approve


Updated conda and git commands

Best practices now for conda are not to source activate env but to conda activate env, and similarly for deactivate. We'd need to check if this breaks for people using older versions of conda (verify Anaconda versions!). The Github section contains now a handy command to just git clone the repo eliminating some steps for unfamiliar users.

A new comment on CUDA-enabled GPUs for those people with a GPU around, so that we alert them to check if their GPU is compatible. This way they can install Pytorch with CUDA backend now and avoid issues later.


[CI] Make first release

Closes #75

Release Notes
First release of the Neurobagel deployment recipe. This release introduces different deployment profiles and an automated process for setting up a graph store using Docker Compose, as well as various environment variables for configuring the behaviour of Neurobagel services using a single .env file.

Checklist
This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

@surchs,

making an extra issue and an extra PR per release seems like a lot of overhead, do we need to / want to keep doing that as opposed to just releasing off of the most recent feature/non-zero-diff PR?

I actually think we want to avoid this generally, and release off of a non-zero-diff PR whenever possible. In this case, it was necessary to make a new PR to trigger the release process with the release label, because we have:
https://github.com/neurobagel/recipes/blob/7286a53faff9e13de716126748095072bd23d5d5/.autorc#L2
and there weren't any other open PRs or quick-fix issues that I could attach the release to.
For the same reason,

do we want to use CI as the PR name for this or make a new RL release one?
I don't think so, because we want to discourage doing that.


Print agent version in the initial message

Needed for

https://github.com/metalbear-co/mirrord-vscode/issues/50
https://github.com/metalbear-co/mirrord-intellij/issues/79

I think this wrongly affects the operator as well? @DmitryDodzin wdyt?

I think in general it means you can't use older cli with newer images, I wouldn't touch the agent-ready message, maybe just add another message beforehand if we want to keep the log-parsing code

I think in general it means you can't use older cli with newer images, I wouldn't touch the agent-ready message, maybe just add another message beforehand if we want to keep the log-parsing code

I believe this change is backwards-compatible. Previous CLI version used line.contains("agent ready"). Adding a suffix should not be a problem


feat: :memo: add code of conduct

Hi !
Thanks for this project :)
Here is a little PR to add a code of conduct, the same introduced on terraform-aws-cli here.
Thanks to @vat0599 for the original PR.

I had to rebase the version-update branch, I'll have to rebase once the other is merged.


Change es6-shim version to satisfy<EMAIL_ADDRESS>

Removes warning:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
As mentioned in #162.

thanks!


Need some waiter for opening new window

Case:
Click on button. Open`s new window.
Then I use swichTo().window("window title"), BUT, sometimes new window opened but still loading and it dont have correctly title. So, in this place my test failing.
Need some waiter to checking page while it will be loaded and then get window title.

This is similar to #212 - Selenide waits for frame and alert, but not for window. We must fix it.

Fixed in Selenide 3.1, will be released soon


feat: add govukTextarea() component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

165 of 165 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 98.534%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1294

Relevant Lines:
1302

💛  - Coveralls


fix(build): bump core to 5.0.2

:tada: This issue has been resolved in version 0.65.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add internal__index param, walled behind auth

Fixes

Fixes #2070 by @dhruvkb
Description

This PR

adds a new query param, called internal__index
this param, only accessible behind authentication, allows choosing a different index to use when searching
this param conflicts with the qa param, and only one of the two can be set at a time

Testing Instructions

Check out the PR and run the dev server.
Using the ingestion server API, create a new index for image and audio, name it something like index-foo and audio-bar.
Search for something. Note the top few results. They should be the same when searching the default index and from the new one.
Randomly delete some of the top few results from the new index. You can do this in Elasticvue.
Observe no change when searching the default index but new results when searching the new one.
Use can also keep an eye on the logs because it will print which index is being used for the search.

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal given the priority of this PR and @sarayourfriend's AFK, I've added you as a reviewer to this PR. Thank you!

Code works well for me, so the only requested change is to either confirm that we absolutely want to allow anyone with any API key to access this feature (I am sceptical that that is what we want).
@stacimc here are some tips based on my testing of this PR that might be useful for the future, especially for Elasticvue:

just ingestion_server/ingest-upstream can be used to make the call to the ingestion server easier. I used just ingestion_server/ingest-upstream image index_param_test for example.
You can use Elasticsearch's delete by query API to delete a document based on the Openverse identifier to avoid needing to dig up the document ID
Elasticvue has a "REST" tab at the top that makes it easier to send HTTP requests to Elasticsearch without needing to juggle JSON formatting in cURL. I sent this request, for example, to delete the first result on a queryless image request locally:

"""
POST /image-index_param_test/_delete-by-query

{
	"query": {
		"match": {
			"identifier.keyword": "379c8a05-1aca-4256-8ab3-59c5d801e394"
		}
	}
}

Drafting to address review changes.

@sarayourfriend I need a bit more information about your comment regarding scopes. I don't understand how the throttling-scopes could be used for authentication and limiting access to a parameter.

I don't understand how the throttling-scopes could be used for authentication and limiting access to a parameter.

I'm not referring to the throttle scopes (per-se) but the ThrottledApplication rate-limit models:
https://github.com//WordPress/openverse/blob/098925afa90b26881b4b4d3e2baffa69049692c0/api/api/models/oauth.py#L37-L39
We could reuse those (which would unfortunately overload the meaning). Though after thinking about it more, I think we should use User permissions on the Django User model, that's the "correct" way to do these sorts of things.
is_request_anonymous will return False as long as any token is included on the request, but for kind of a weird reason. If the request is authenticated, there is no user on the request. request.user is None. If the request has no token, request.user is AnonymousUser. That was surprising to me. It turns out we don't have our OAuth clients wired up to Django Users, which now that I think about it makes sense. If we used the Django permissions approach, we'd need to wire them up, which would take extra time, even though it is the "correct" way to manage access control for individual features in Django (theoretically). Or we could do the quick and dirty approach and add a new rate limit model for them, but again, that significantly overloads what "rate limit model" is for.
My suggestion would be to put this PR on hold and for us to have a high priority issue to resolve what we mean by "walled behind auth" and to either confirm this is the behaviour we expect (anyone with any token) or whether we want to be able to restrict it further. If it's anyone with any token then I am kind of sceptical for why it's even needed in the first place. Anyone who wanted to abuse these parameters would be able to do so trivially. What are we getting by hiding them behind authentication at this level?
However, it's apparent to me that this isn't a question that affects only this PR. is_request_anonymous was added as part of other work and other features exist behind it that have the same problem. With that in mind, we could also merge this as is but with the stipulation that we'd need to urgently re-evaluate our "walled behind auth" idea. As I said above, either we should confirm that we really want this effectively useless guard on the feature (or else define why this is useful, I can't come up with a reason other than to make using it tedious) or decide on a more specific approach. I'm not familiar with the urgency of this PR though to say whether it's worth merging this before addressing what we mean by "walled behind auth". If we need this tomorrow for some reason, then I won't block on this. Otherwise, if isn't needed ASAP and we can take ~1 or 2 weeks to confirm or take a better approach, it's worth it.
Basically, all this boils down to:

What do we mean by "walled behind auth"?
Does that match the current behaviour (any request with any token)?
If so, what is the point of that restriction? At best, as far as I can tell, it makes using the feature tedious for us as maintainers and does nothing to prevent it from being misused by a malicious actor or abused otherwise.
If not, then we should change how we manage access to these features in a high or even critical priority issue (considering there are features live in production using this same approach).
Likewise (if we need to make changes to the "walled behind auth" approach), do we need this feature ASAP? If not, it can be put on hold for the fix and never be introduced in a way that could cause someone to attack us by using it maliciously to cause errors if there are any unexpected behaviours caused by this.

@sarayourfriend this PR (or more accurately, the issue this PR addresses) was discussed as something to implement in the data refresh process when we did the postmortem for the outage. The milestone has the overall priority of "🟧 high".
As for auth, I do feel it's worth discussing a proper mechanism for authentication rather than trying to rush this PR out the door.
When working on the PR, the main intention for auth, in my mind, was only to rate-limit and have a log of users accessing this endpoint. I did not intend for this endpoint to only be something that staff can access, especially because the exact name of any yet-to-be-promoted index would not be known to any party other than the ingestion server and the data-refresh DAG.


Allow leading zeros for NumberedFileInputSplit

Issue Description
Update NumberedFileInputSplit to allow "prefix0004.suffix" formatting, which is suitable for, e.g., Hadoop mapfiles spit out by a Spark ETL pipeline.
PR with update already available.

PR: https://github.com/deeplearning4j/DataVec/pull/420


Add W/R check for meshes used by the map generator

added with https://github.com/hunterdyar/daily-golf-project/commit/943bfd0121d655f9cd5effac204f7ac70c1d845e


Mark user as staff

Because Admin app is unsupported, how can I mark user as staff in dashboard?
If no way - is should we improve the /dashboard/users/ or user-detail page with new actions (mark as staff) available for superuser?

Currently the only place to do this is though the admin (which works, even though the dashboard is in theory a replacement for it), or through the shell.
The dashboard has a number of limitations which need to be addressed as part of a wider conversation on the purpose/functionality of the dashboard.

@solarissmoke So I just enable Admin app back.

Yes - you can do this through the admin or the shell.


Fix golint build issue (wrong import)

This PR fixes the golint import path, which is currently causing travis builds to fail.

Thanks! Mountain pic per our agreement is on Twitter - hard to upload via mobile!


Error: view._hlp(...) is not a function. is hard to track down

Life is improving but I'm hoping it will keep getting better.
I see you have some TODOs in the code and you have some hooks which are not documented (to my knowledge).   I am often tempted to start writing documentation for jsrender (I don't use jsviews yet) but I know the code is in flux so keep waiting.
I see you have $.views.settings with some debug options.  I can also tie into $.views._err but I fear that that might change.
The templates appear to have a debug option.  One suggestion is instead of this:
		+ (tmplOptions.debug ? "debugger;" : "")

do
		+ (tmplOptions.debug ? tmplOptions.debug : "")

Then the user can set debug = "debugger;" or another string of his choosing.
Eventually what I'd like is a general hook or perhaps two -- one for syntax errors and another for execution errors.  What I intend to do with those hooks is to have an empty tag with an id and then just append the errors to the tag.  It would be nice to be able to have the template name and what helper or tag is being used.  I assume line numbers is not possible.

Closing "After V1.0" issues for now - to reopen as appropriate.


TextTiling cutoff_policy (HC is not set properly)

The TextTiling code Line 297 - 300 shows:
297:        if self.cutoff_policy == LC:
298:            cutoff = avg - stdev / 2.0
299:        else:
300:            cutoff = avg - stdev / 2.0
Line 300 should be
300:            cutoff = avg + stdev / 2.0

I don't believe that this is correct. As per Hearst, Marti A.. “Text Tiling: Segmenting Text into Multi-paragraph Subtopic Passages.” Comput. Linguistics 23 (1997): 33-64.:

A higher precision but lower recall can be found by setting the
limit to be depth scores exceeding avg - stdev/2 (the conservative measure, HC) instead of
avg - stdev [which is LC].

So, HC should be avg - stdev / 2.0, while LC should be avg - stdev, as implemented in #2936:
https://github.com/nltk/nltk/blob/b35b4c6b027a017fa65c29c43771701533d5dc63/nltk/tokenize/texttiling.py#L294-L297


No indication of output directory if no output directory is given

If you try to build without the output directory set (i.e. kotatsu build client --babel --config ./webpack.config.js), it doesn't indicate where it builds.
It could be a good idea to either disallow this or at least print where it built.

Yes, printing the output directory would be a good idea. Let me add this.


DOC: docker db size warning

Changes proposed in this pull request
Warning in docs about this satanic issue poldracklab/mriqc#666 :smiling_imp:
Documentation that should be reviewed
It's a matter of if you like the chunk of code inside the warning or not

I will also send a PR for mriQC

@erramuzpe may I ask you to:

add the warning first that we recommend mounting a work directory
then, if the user does not want to mount the work directory for whatever reason, keep the modifications you already have included in the pr, but indicating that we do not advise this route.
Add a link to the documentation bit that @emdupre suggested above.


Bump swagger2openapi version to avoid yargs prototype pollution

Hi, due to detected prototype pollution in yargs (https://nodesecurity.io/advisories/1500) please upgrade used version of swagger2openapi to at least<EMAIL_ADDRESS>(where they bumped yargs version).

Oh there is swagger2openapi issue: https://github.com/Mermade/oas-kit/issues/218

this isn't an issue for us as yargs is applicable only in node environment. Also we explicitly remove this from our final bundle
using our webpack config
https://github.com/mrin9/RapiDoc/blob/cb34cdd52fae504dea7249ba53234ea0aae5a843/webpack.config.js#L58
However, I am keeping the issue open as we plan to upgrade this package, it does involve to deal with some breaking changes and take care of certain corner cases

packages are updated in release 8.3.0


Migrate Travis-CI.org

Travis-CI.org is being merged with Travis-CI.com, and the former will be shut down and rendered read-only eventually.
We have to migrate the repo over to a Travis-CI.com account manually.

This is now  urgent, as Travis-CI.org has gone read-only as of June 15th.

Took at stab at this, but I think only @AureumChaos is able to migrate it over.
The instructions are here, but unnecessarily complicated and seems to be written by laweyers.
I think it's as simple as signing up at travis-CI.com by linking your GitHub account, then clicking the "migrate" tab to bring the LEAP test run config over from travis-CI.org.

I think we want to nip the root problem here, by setting up co-ownership of the LEAP repo.  See #159

Luke has set up github actions for our CI pipeline, thus making this irrelevant.  Closing.


setRefreshToken unexpectedly removed since v5.2.0

Hello,
I'm following the official OAuth2 developer guide from this URL:
https://www.dropbox.com/lp/developers/reference/oauth-guide#using-refresh-tokens
Also, from the /oauth2/token documentation, I understand that Dropbox v2 API supports short-lived tokens with refresh tokens:
https://www.dropbox.com/developers/documentation/http/documentation#oauth2-token
However, i'm surprised to see that in v5.2.0, the setRefreshToken method was removed from the SDK.
https://github.com/dropbox/dropbox-sdk-js/compare/v5.1.0...v5.2.0#diff-fb89f29edccb776d0def9b404e7645a9
Is that intentional? If yes, is there another way to refresh tokens and use short lived tokens?

Hello, I am sorry to hear you are running into this issue.  You are correct, Dropbox v2 API now supports short lived tokens with refresh and this is the preferred way to authenticate requests.  However, when I go to the link you posted for showing the diffs, I am not seeing any diff.  If I compare v5.1.0 to v5.2.0 directly I don't see any removal of the setRefreshToken method.
Can you give a little more information about what versions of the SDK, node, etc you are using? Are you using JS or TS?

Hi @rogebrd, thanks for checking this.
I'm referring to the dropbox_types.d.ts typescript definitions file.
Up until v5.1.0, the setRefreshToken method exists:
https://github.com/dropbox/dropbox-sdk-js/blob/v5.1.0/generator/typescript/dropbox_types.d.ts#L84
Since v5.2.0, it doesn't:
https://github.com/dropbox/dropbox-sdk-js/blob/v5.2.0/generator/typescript/dropbox_types.d.ts
Thanks,
Avner

I see, that does seem to be a bug, I can get that resolved asap.  We are going to be pushing an update in the next few days so we can add this change into that update as well.

Thanks!

Thanks @rogebrd. indeed this one a breaking changes for TS since the long live token is considered as deprecated and not recommended and refreshToken is missing from the lastest version.

I ran into a related problem recently and notice that the type signature for getAuthenticationToken was also broken in 5.2.0:
-    getAuthenticationUrl(redirectUri: string, state?: string, authType?: 'token' | 'code', tokenAccessType?: 'legacy'|'offline'|'online', scope?: Array<String>,includeGrantedScopes?: 'none'|'user'|'team', usePKCE?: boolean): string;
+    getAuthenticationUrl(redirectUri: string, state?: string, authType?: 'token' | 'code'): string;

    /**

This should be fixed now as of the latest version. Please give it a try and let us know if you're still seeing any issues. Thanks!


Please invite me to the community

Name
NFT knight
Additional Context
No response

Welcome to Infraform! @BestCryptoKnight


muso: fix darwin build

Motivation for this change
ZHF: #122042
cc @NixOS/nixos-release-managers
Hydra failure: https://hydra.nixos.org/build/142996880/nixlog/2
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build muso


Tooltip: Tooltip increases height of containers

Info
You can replicate this with the following code:

  <goa-tooltip content="Trying some more long form text here to see how it's rendered">
    <goa-icon type="information-circle" />
  </goa-tooltip>

  <goa-icon type="information-circle" />

The first div will be 37px in height, the second div will be 29px in height, despite the actual visible content being the exact same.
Acceptance Criteria:

Tooltip doesn't increase the height of containers it's in

Talked to Thomas, as per Figma, 4px of margin is requried b/w the tooltip and the Icon, so we need to keep the margin in the .tooltip-target class.
An alternative is e.g. to change the .tooltip-target class to margin: 0 and add a margin of 4px to the .tooltip-text.top class instead... and so on to other such classes, but these are hacky solutions.
Below is a cleaner way of making both divs to have some height. The only caveat is the user needs to be aware of the mt and mb props

  <goa-tooltip content="Trying some more long form text here to see how it's rendered">
    <goa-icon type="information-circle" />
  </goa-tooltip>

  <goa-icon type="information-circle" mt="2xs" mb="2xs"/>

In the above example, the bottom div which is initially 8 px shorter in height, but after adding mt="2xs" mb="2xs", this div gets the same height as the one above.

Closing this issue as the proposed solution doesn't actually work, and the actual solution is to just increase margin around any non-tooltip icons in the same container.


Apply all non-valid props to the wrapper element

Possible fix for https://github.com/CookPete/react-player/issues/167
@oyeanuj any thoughts on this? The only possible issue is that we now call lodash's omit on every render, but I'm not sure it will affect performance that badly.

Hey @CookPete! The lodash omit part looks good, I'd be surprised if it affects performance. I did have one question though - we are attaching the events/props to the div wrapper which can enclose multiple players (if I am correct in the understanding of how renderPlayers function is working.
I feel like for the original case I mentioned in #167, one would need these controls on individual players - like hovering on an individual player should only show that player's controls.
Thoughts?

we are attaching the events/props to the div wrapper which can enclose multiple players (if I am correct in the understanding of how renderPlayers function is working.

Multiple players are only ever rendered when preload is set and youtube or vimeo players need to be "primed" by starting in the background. These players are never displayed so it doesn't make a difference.

Oh, I see. Well, since they don't show up visually, then all of this looks good! Thanks so much!


Fetches experiment name from environment

This change looks for the REANA_WORKFLOW_ENGINE_EXPERIMENT env variable and uses its value for the experiment field when creating jobs.
I'm running reana in Openshift under a non-default namespace ("reana"), and I need the jobs created in the same namespace as the volume claims.

@diegodelemos @dinosk BTW we can take advantage of this PR and clean the usage of REANA_WORKFLOW_ENGINE_EXPERIMENT also elsewhere in the code base:
(1) Note that Serial engine does not default to "default":
$ git grep -Hni -A 1 REANA_WORKFLOW_ENGINE_EXPERIMENT
reana_workflow_engine_serial/tasks.py:77:                "experiment": os.getenv("REANA_WORKFLOW_ENGINE_EXPERIMENT",
reana_workflow_engine_serial/tasks.py-78-                                        "serial_experiment"),

(2) Note that Yadage uses REANA_WORKFLOW_ENGINE_YADAGE_EXPERIMENT still.

@dleehr Thanks! One small question regarding AUTHORS file: we have a habit of linking to ORCID profiles of REANA contributors in places like https://reana.readthedocs.io/en/latest/authors.html and elsewhere.  Do you use ORCID and is 0000-0003-3221-9579 well your ID?

Yes that's my ORCID

@dleehr thanks! could you please rebase against latest master?

@dleehr I am adding you as an author in a different PR (see here), thanks a lot for the contribution :)


Update code example for truncate component.

The current example is too short to show the truncate effect on larger screens. Therefore I used the text from the second example in the first aswell to make sure it is long enough to always show up.

@fabiankaegy Awesome! Thank you! I'll take care of that merge conflict :)


Add puppeteer dependencies

puppeteer dependencies would allow to execute html-formatter/javascript non-regression tests automatically.

I've pushed the puppeteer recommended way to make it usable in a docker image as found here: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#running-puppeteer-in-docker
At the moment, it requires puppeteer to be launched with the --no-sandbox flag. So as-is, we would have to update html-formatter/javascript. That fix would actually be quite simple.
We could try to fix cucumber-build image to avoid the need for --no-sandbox. But it may impact the image more deeper. We may need to make the cukebot user and group as system for example.
I would go for the first option: adding --no-sandbox. That way the impact on the docker image remains small. But we may look for potential security issues regarding the developer's hosts machines.
@aslakhellesoy @mpkorstanje what are your opinion about that?

What does the --no-sandbox flag do?

But it may impact the image more deeper. We may need to make the cukebot user and group as system for example.

https://github.com/GoogleChromeLabs/lighthousebot/blob/master/builder/Dockerfile#L35-L40
Doing this for cuke bot looks fine to me.

What does the --no-sandbox flag do?
This is to prevent using the linux sandboxing with chrome/chromium

But it may impact the image more deeper. We may need to make the cukebot user and group as system for example.

https://github.com/GoogleChromeLabs/lighthousebot/blob/master/builder/Dockerfile#L35-L40
Doing this for cuke bot looks fine to me.

I'll test that today

But it may impact the image more deeper. We may need to make the cukebot user and group as system for example.

https://github.com/GoogleChromeLabs/lighthousebot/blob/master/builder/Dockerfile#L35-L40
Doing this for cuke bot looks fine to me.

I just spent some times trying to make the cukebot user and group as system but I was not able to figure out how to make it work. It actually broke other things.
As this PR aims to fix the CI for the npm-workspaces PR in the cucumber mono-repo, for a single puppeteer test, would you have any objection to merge that PR as-is and executing the puppeteer test using --no-sandbox?

Sure. Lets revisit this if/when we start doing more with puppeteer.


Websocket connection fails with TLS error

[grpcweb-example-e8d1556b-1]2018-02-04T10:32:22.149534773Z WARN[2018-02-04T10:32:22.149392233Z] Failed to create transport: connection error: desc = "transport: authentication handshake failed: tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config"
[grpcweb-example-e8d1556b-1]2018-02-04T10:32:22.150669434Z DEBU[2018-02-04T10:32:22.150324609Z] Closed connection
[grpcweb-example-e8d1556b-1]2018-02-04T10:32:22.150696443Z 2018/02/04 10:32:22 http: TLS handshake error from <IP_ADDRESS>:35418: EOF

This seems to be happening only for websocket requests. Could be a problem with the proxy itself.

Fixed it :)


Change help text of the tmt --root option

Change help text of '-r' option.
The original text was a bit confusing according to issue https://github.com/teemtee/tmt/issues/371
If you have another suggestion, let me know.

I've just updated the commit message to match our recommendations.

I've just updated the commit message to match our recommendations.

@psss  Thanks, still learning :-)


[HELP] Language for sending event messages

Hi, I'm a beginner in programming. I wanted to make changes to your project, but I can't compile it. Many errors are due to the fact that it is impossible to find something in the project. Although I forked it and everything should work.
I want to make changes in order to gain a little experience. I want to change the ability to receive a message about the start of a fight with a boss, to study a new area in your project. I receive messages about the start of an attack on the base in English, I wanted to change it to Russian.
I will at least try to implement all this in reality, although I am not confident in my abilities.
build_log.txt

I forked the project, but I don't know how to change the answers about the event name from English to Russian.

I understand that we need to work with Localization here. But in general, it seems to me that it would all be simplified if the dedicated server was launched in Russian.
using System;
using System.Collections.Generic;
using HarmonyLib;
using UnityEngine;

namespace DiscordConnector.Patches;
internal class RandEventPatches
{

    [HarmonyPatch(typeof(RandomEvent), nameof(RandomEvent.OnActivate))]
    internal class OnActivate
    {

        private static void Prefix(ref RandomEvent __instance)
        {
            bool active = __instance.m_active;
            float duration = __instance.m_duration;
            string name = __instance.m_name;
            float time = __instance.m_time;
            float remaining = duration - time;
            Vector3 pos = __instance.m_pos;
            Plugin.StaticLogger.LogDebug(
                $"Random event OnActivate {name}: {active} for {duration} at {pos}. (time: {time})"
            );

            List<String> involvedPlayers = new List<string>();
            foreach (ZNet.PlayerInfo playerInfo in ZNet.instance.GetPlayerList())
            {
                if (RandEventSystem.instance.IsInsideRandomEventArea(__instance, playerInfo.m_position))
                {
                    involvedPlayers.Add(playerInfo.m_name);
                }
            }
            Plugin.StaticLogger.LogDebug(
                $"Involved players in event: {(string.Join(",", involvedPlayers.ToArray()))}"
            );

            if (__instance.m_time > 0)
            {
                if (Plugin.StaticConfig.EventResumedMessageEnabled)
                {
                    string message = MessageTransformer.FormatEventMessage(
                        Plugin.StaticConfig.EventResumedMessage,
                        Localization.instance.Localize(__instance.m_endMessage),
                        Localization.instance.Localize(__instance.m_startMessage)
                    // string.Join(",", involvedPlayers.ToArray()) //! Removed with event changes
                    );
                    if (!Plugin.StaticConfig.EventResumedPosEnabled)
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventResumed, message);
                        return;
                    }
                    if (Plugin.StaticConfig.DiscordEmbedsEnabled || !message.Contains("%POS%"))
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventResumed, message, pos);
                    }
                    else
                    {
                        message = MessageTransformer.FormatEventMessage(
                            Plugin.StaticConfig.EventResumedMessage,
                            Localization.instance.Localize(__instance.m_endMessage),
                            Localization.instance.Localize(__instance.m_startMessage),
                            // string.Join(",", involvedPlayers.ToArray()), //! Removed with event changes
                            pos
                        );
                        DiscordApi.SendMessage(Webhook.Event.EventResumed, message);
                    }
                }
            }
            else
            {
                if (Plugin.StaticConfig.EventStartMessageEnabled)
                {
                    string message = MessageTransformer.FormatEventStartMessage(
                        Plugin.StaticConfig.EventResumedMessage,
                        Localization.instance.Localize(__instance.m_endMessage),
                        Localization.instance.Localize(__instance.m_startMessage)
                    // string.Join(",", involvedPlayers.ToArray()) //! Removed with event changes
                    );
                    if (!Plugin.StaticConfig.EventStartPosEnabled)
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventStart, message);
                        return;
                    }
                    if (Plugin.StaticConfig.DiscordEmbedsEnabled || !message.Contains("%POS%"))
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventStart, message, pos);
                    }
                    else
                    {
                        message = MessageTransformer.FormatEventStartMessage(
                            Plugin.StaticConfig.EventResumedMessage,
                            Localization.instance.Localize(__instance.m_endMessage),
                            Localization.instance.Localize(__instance.m_startMessage),
                            // string.Join(",", involvedPlayers.ToArray()), //! Removed with event changes
                            pos
                        );
                        DiscordApi.SendMessage(Webhook.Event.EventStart, message);
                    }
                }
            }
        }
    }

    [HarmonyPatch(typeof(RandomEvent), nameof(RandomEvent.OnDeactivate))]
    internal class OnDeactivate
    {

        private static void Prefix(ref RandomEvent __instance, ref bool end)
        {
            bool active = __instance.m_active;
            float duration = __instance.m_duration;
            string name = __instance.m_name;
            float time = __instance.m_time;
            Vector3 pos = __instance.m_pos;
            Plugin.StaticLogger.LogDebug(
                $"Random event OnDeactivate {name}: End?{active} for {duration} at {pos}. (time: {time})"
            );

            List<String> involvedPlayers = new List<string>();
            foreach (ZNet.PlayerInfo playerInfo in ZNet.instance.GetPlayerList())
            {
                if (RandEventSystem.instance.IsInsideRandomEventArea(__instance, playerInfo.m_position))
                {
                    involvedPlayers.Add(playerInfo.m_name);
                }
            }
            Plugin.StaticLogger.LogDebug(
                $"Involved players in event: {(string.Join(",", involvedPlayers.ToArray()))}"
            );

            if (!end)
            {
                if (Plugin.StaticConfig.EventPausedMessageEnabled)
                {
                    string message = MessageTransformer.FormatEventMessage(
                        Plugin.StaticConfig.EventPausedMessage,
                        Localization.instance.Localize(__instance.m_endMessage),
                        Localization.instance.Localize(__instance.m_startMessage)
                    // string.Join(",", involvedPlayers.ToArray()) //! Removed with event changes
                    );
                    if (!Plugin.StaticConfig.EventPausedPosEnabled)
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventPaused, message);
                        return;
                    }
                    if (Plugin.StaticConfig.DiscordEmbedsEnabled || !message.Contains("%POS%"))
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventPaused, message, pos);
                    }
                    else
                    {
                        message = MessageTransformer.FormatEventMessage(
                            Plugin.StaticConfig.EventPausedMessage,
                            Localization.instance.Localize(__instance.m_endMessage),
                            Localization.instance.Localize(__instance.m_startMessage),
                            // string.Join(",", involvedPlayers.ToArray()), //! Removed with event changes
                            pos
                        );
                        DiscordApi.SendMessage(Webhook.Event.EventPaused, message);
                    }
                }
            }
            else
            {
                if (Plugin.StaticConfig.EventStopMessageEnabled)
                {
                    string message = MessageTransformer.FormatEventEndMessage(
                        Plugin.StaticConfig.EventStopMessage,
                        Localization.instance.Localize(__instance.m_endMessage),
                        Localization.instance.Localize(__instance.m_startMessage)
                    // string.Join(",", involvedPlayers.ToArray()) //! Removed with event changes
                    );
                    if (!Plugin.StaticConfig.EventStopPosEnabled)
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventStop, message);
                        return;
                    }
                    if (Plugin.StaticConfig.DiscordEmbedsEnabled || !message.Contains("%POS%"))
                    {
                        DiscordApi.SendMessage(Webhook.Event.EventStop, message, pos);
                    }
                    else
                    {
                        message = MessageTransformer.FormatEventEndMessage(
                            Plugin.StaticConfig.EventStopMessage,
                            Localization.instance.Localize(__instance.m_endMessage),
                            Localization.instance.Localize(__instance.m_startMessage),
                            // string.Join(",", involvedPlayers.ToArray()), //! Removed with event changes
                            pos
                        );
                        DiscordApi.SendMessage(Webhook.Event.EventStop, message);
                    }
                }
            }
        }
    }

}

Yeah I haven't looked into the localization part at all. But all the existing code does is ask the server for the strings to use, I would expect launched it with Russian as the language would fix. But not sure how that would work, and perhaps the localization is all client-side.
If that's the case, there likely is some localization class that can provide the event strings for the specified language?

Yeah I haven't looked into the localization part at all. But all the existing code does is ask the server for the strings to use, I would expect launched it with Russian as the language would fix. But not sure how that would work, and perhaps the localization is all client-side.
If that's the case, there likely is some localization class that can provide the event strings for the specified language?

It seems to me that nothing needs to be changed in the code, and it is enough to change the launch of the dedicated server valheim in Russian. Such information is missing. On the other hand, I'm not sure that this is enough. Maybe on a dedicated server everything will be in Russian, but the answers will still be in English. How complicated it all is...

What package did you connect for Localization?

here you can see that the server is running with English localization. how do i fix this?

Re: server localization -- I have no idea. Never tried it.
Re: Which localization package -- It's one of the classes from Valheim itself. If you want to take a look at all the classes, an easy tool to do this with is ILSpy which can decompile C# programs. You can use it to poke around in the Valheim code and see the classes and stuff.

I did it. True, it didn't take me much trouble, but it would be more interesting to do it with code. At least change the configuration file to start the server by choosing the language. I opened the file assemble_goitils. All that's left is to wait for the event to start and get a message in the discord, I'll write later whether it helped or not.


WMIC and Setting the MDT Driver Path

Regarding the portion of the article:

The preceding folder names are selected because they match the actual make and model values that MDT reads from the machines during deployment. You can find out the model values for your machines via the following command in Windows PowerShell:
Get-WmiObject -Class:Win32_ComputerSystem
Or, you can use this command in a normal command prompt:
wmic csproduct get name

Prior to update 2, I have used the command wmic computersystem get model and manufacturer to build the MDT folders in out of box drivers. With the latest PE litetouch I am not getting the same result back from WMIC and therefore my driver injection is failing.  I have verified the difference in output by booting from an old boot media created prior to update 2 and issuing the command from a prompt. I will attach screens of the wmic computersystem list output on the two versions. You mention csproduct. Is this a functional change from the previous MDT releases?

This is the issue: https://social.technet.microsoft.com/Forums/en-US/9a9cc1ba-d6f2-4e20-841d-c8b809647b66/windows-mdt-2013-update-1-injecting-driver-problems?forum=mdt&prof=required

@randytho If you are still having problems, you should contact Microsoft Support.  Thanks!


Add pho testing support

Contribution Type: new plugins
Primary Area: plugins
Adding a link for a new plugin to support pho
Reference #751

@AustP - Happy to merge - Please can you write up some documentation for your Pho plugin for me?

See discussion in https://github.com/Block8/PHPCI/pull/761


bugfix: Fix "unknown argumet: '-static'" when compiling on Darwin

The code
option(BUILD_SHARED_LIBS "Build shared libraries by default"
  $<PLATFORM_ID:Windows,Darwin>)

doesn't set the option BUILD_SHARED_LIBS to YES on Darwin. I found that it
always return 0.  I tried to use $<IN_LIST> generator but it also returned
0.
Fixes #2

I think that this has been improved upstream, please re-open if the latest CMake still causes issues.


Gabriel Kalani - Exercicio 10 - Resolvido

Fiz na pressa essa porra
Já que exclui o antigo markdown :rage:

This branch has conflicts that must be resolved
Use the command line to resolve conflicts before continuing.


Add support for Ugoos AM6b+.

Is it possible to get support for this device added?

Works fine on my AM6B+
Enable ADB in settings

Thanks, I had to enable wireless debugging. Is there any way to make it automatically reboot upon launch of the apk?


[melonvod] Add new extractor for vod.melon.com

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
Melon is a South Korean online music service. This extractor extracts videos served from http://vod.melon.com, example http://vod.melon.com/video/detail2.htm?mvId=50158734

Cherry-picked, thanks.


LORE finetuning gives wierd bounding boxes.

Hello, thank you for the great work you did with LORE.
I am trying finetuning the small version of LORE on a custom dataset but it seems that when I do the model results are getting worst.
I tried some zero-shot inference with ckpt_ptn model weights.

I also produced annotations similar to the ones you provided in the subset of PubTabNet. I can provide an example if necessary.
Am I doing something wrong in the script?
Thank in advance!

Thank you. We have fixed some issue in the training scripts, please try the latest version. If the problem persists, feel free to contact us!

Hi @BrownXing
Are the scripts to convert datasets like Pubtabnet or Fintabnet included in this repo, I can't seem to find them. I mean the scripts to convert Jsonl/HTML annotations to coco with logic_axis. Thanks

Hi @BrownXing Are the scripts to convert datasets like Pubtabnet or Fintabnet included in this repo, I can't seem to find them. I mean the scripts to convert Jsonl/HTML annotations to coco with logic_axis. Thanks

We have not release such a script in this repo, but you could get the logical axis from HTLM labels by first preorder traversing the HTML sequence and computing the logical axis according to the hierarchy and the row_span/column_span attributes of .


[Event Grid] Support aeg-sas-token and aeg-sas-key for authentication

Azure Event Grid supports both SAS token & key via aeg-sas-token and aeg-sas-key headers when doing auth.  See https://docs.microsoft.com/en-us/azure/event-grid/security-authentication for more details.
Interestingly @azure/ms-rest-js exports TopicCredentials that can be used for aeg-sas-key, but there is no support for token
This issue is to track the work required to create two dedicated EventGrid credentials and ship them as part of the @azure/eventgrid package

EventGridSASKeyCredential (Copy over TopicCredentials from @azure/ms-rest-js and rename)
EventGridSASTokenCredential (Use the above as reference and use a different header)

Current workaround is for users to define their own credential following the model of TopicCredentials and using the right header

As of<EMAIL_ADDRESS>we now have support for using a SAS key with eventgrid.  You can see how to do so in the README.md.


Creating directories broke!

Creating directories broke!
I discovered that someone had broken a very good thing that worked perfectly before.
Earlier I commonly when saving new files, simply specify a desired path, and if it did not exist, then all the required directory created automatically to any depth and saves the file with the specified name. like this... in 1.1 stable
func seve_file():
	FILE_PATH = "res://SAVED_DATA/new_NONEXISTENT_directory/test/test.txt"
	FILE = File.new()

	if (FILE.file_exists(FILE_PATH) == false && VOX_FILE.is_open() == false):
		FILE.open(FILE_PATH, File.WRITE)
		FILE.store_string("string_12345678")
		FILE.close()

but now when I tried to save a file in a directory that previously did not exist, I was suddenly was refused and I had to rewrite the old code which previously worked fine using a single string, and create a whole monster which added all a bunch of blocks in which it was necessary to rewrite each directory selected call options to create the directory manually, and this shit for automation ...
in 2.0.1 stable
func seve_file():
	var dir = Directory.new()
	dir.make_dir("res://SAVED_DATA/new_NONEXISTENT_directory")
	dir.make_dir("res://SAVED_DATA/new_NONEXISTENT_directory/test")

	FILE_PATH = "res://SAVED_DATA/new_NONEXISTENT_directory/test/test.txt"
	FILE = File.new()

	if (FILE.file_exists(FILE_PATH) == false && VOX_FILE.is_open() == false):
		FILE.open(FILE_PATH, File.WRITE)
		FILE.store_string("string_12345678")
		FILE.close()

simply return how it worked before, it was perfect!!!

 I apologize for the confusion, and that perhaps brought someone misleading or hurt, I close this issue ...
But still very much I want it to work so, without crutches, and the invention of wheels ...

Don't worry, I don't think anyone was hurt :)
About the bug itself, I think the behaviour in 2.0.x is what it should be. Creating files and creating directories are different operations, so it's normal that you need to create the directories manually when they're missing, trying to opening a non-existing file should not create all the directories that would lead to it, it should just throw an error.

I meant that the directories created only in the moment when a file already written to disk, but not at the time of verifying the existence or opening for operations, ie, directories are created at the last moment before putting there the finished to record the file after editing it, if for this operation is have enough free space ...


chore: bump storyly version and adapt new api spec

✅ Checklist

[x] npx changeset was attached.
[ ] Covered by automatic tests.
[x] Impact of the changes:

new major version of storyly-web

📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Can you link the JIRA ticket in your PR's description (under Context) please ?


#1228 Configure a default logger for access services samples

See #1228 for details
Signed-off-by: Nigel Jones<EMAIL_ADDRESS>

Note that this PR makes two changes

Adds logback to access client sample. Configures for >INFO. Result is no debug logging no error
Adds a jar with dependencies for each so they can be run directly


Export mesh not working after training a model with nerfstudio data

Description
I successfully trained a model with nerfstudio-data, but when exporting the data to a mesh, I get the following error:
Extract mesh with marching cubes and may take a while
Traceback (most recent call last):
  File "/usr/local/bin/ns-extract-mesh", line 8, in <module>
    sys.exit(entrypoint())
  File "/root/sdfstudio/scripts/extract_mesh.py", line 139, in entrypoint
    tyro.cli(tyro.conf.FlagConversionOff[ExtractMesh]).main()
  File "/root/sdfstudio/scripts/extract_mesh.py", line 125, in main
    get_surface_sliding(
  File "/usr/local/lib/python3.10/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/root/sdfstudio/nerfstudio/utils/marching_cubes.py", line 159, in get_surface_sliding
    combined.merge_vertices(digits_vertex=6)
AttributeError: 'list' object has no attribute 'merge_vertices

To Reproduce
Train with:
ns-train neus-facto --pipeline.model.sdf-field.inside-outside False --vis viewer --experiment-name shoe nerfstudio-data --data shoe
And export mesh with:
ns-extract-mesh --load-config outputs/shoe/neus-facto/2023-09-08_161804/config.yml --output-path meshes/shoe.ply

Hi, how is the model looks like in the viewer or in wandb? Could you try to uncomment this line to check if the mesh is extracted successfully https://github.com/autonomousvision/sdfstudio/blob/master/nerfstudio/utils/marching_cubes.py#L149?

I tried that but still getting that error, the viewer does not load the visualization but the data looks good (and I tried with Nerfstudio and it is working). This is what the viewer looks like:

I'm also facing the same issue for some scenes of my private dataset. The 'combined' list is empty instead of being a Trimesh datatype. On a closer look, I found that the learned SDF doesn't have a zero level set (hence, it cannot enter the Marching cubes code block). A quick way to check would be to print(f"Min SDF: {np.min(z)}, Max SDF: {np.max(z)}, Level: {level}") above the line.
So turns out it's not a mesh extraction code issue but a NeuS training issue for my case. Your issue may be different, but might be worth checking out the SDF.

I'm also facing the same issue for some scenes of my private dataset. The 'combined' list is empty instead of being Trimesh datatype. On a closer look, I found that the learned SDF doesn't have a zero level set (hence, it cannot enter the Marching cubes code block). A quick way to check would be to print(f"Min SDF: {np.min(z)}, Max SDF: {np.max(z)}, Level: {level}") above the line.
So turns out it's not a mesh extraction code issue but a NeuS training issue for my case. Your issue may be different, but might be worth checking out the SDF.

Hey, i'm having the same issue with a bakedangelo model.
Extract mesh with marching cubes and may take a while Min SDF: -0.6122978329658508, Max SDF: -0.5027145147323608, Level: 0 Min SDF: -0.6156349182128906, Max SDF: -0.505859911441803, Level: 0 Min SDF: -0.6124227046966553, Max SDF: -0.5026049017906189, Level: 0 Min SDF: -0.6124935150146484, Max SDF: -0.5062590837478638, Level: 0 Min SDF: -0.6747320294380188, Max SDF: -0.48882657289505005, Level: 0 Min SDF: -0.6608027219772339, Max SDF: -0.5282750129699707, Level: 0 Min SDF: -0.6763045787811279, Max SDF: -0.4956194758415222, Level: 0 Min SDF: -0.6555583477020264, Max SDF: -0.534900963306427, Level: 0 AAAAAAAAAAAAAAAAAAAAAAAAA Traceback (most recent call last):   File "/root/anaconda3/envs/sdfstudio/bin/ns-extract-mesh", line 8, in <module>     sys.exit(entrypoint())   File "/home/vrai/repos/sdfstudio/scripts/extract_mesh.py", line 139, in entrypoint     tyro.cli(tyro.conf.FlagConversionOff[ExtractMesh]).main()   File "/home/vrai/repos/sdfstudio/scripts/extract_mesh.py", line 125, in main     get_surface_sliding(   File "/root/anaconda3/envs/sdfstudio/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context     return func(*args, **kwargs)   File "/home/vrai/repos/sdfstudio/nerfstudio/utils/marching_cubes.py", line 161, in get_surface_sliding     combined.merge_vertices(digits_vertex=6) AttributeError: 'list' object has no attribute 'merge_vertices'
i printed that line but the level here is 0. Any suggestions?

I also encountered the same problem. After I trained bakedangelo, I encountered the same error when trying to extract mesh.AttributeError: 'list' object has no attribute 'merge_vertices'

train bakedangelo:ns-train bakedangelo --machine.num-gpus 2 --pipeline.datamanager.train-num-rays-per-batch 1500 --pipeline.model.sdf-field.inside-outside False --vis wandb --experiment-name bakedangelo-dtu65 sdfstudio-data --data data/dtu/scan65
extract mesh:

I also encountered the same problem. After I trained bakedangelo, I encountered the same error when trying to extract mesh.AttributeError: 'list' object has no attribute 'merge_vertices'

train bakedangelo:ns-train bakedangelo --machine.num-gpus 2 --pipeline.datamanager.train-num-rays-per-batch 1500 --pipeline.model.sdf-field.inside-outside False --vis wandb --experiment-name bakedangelo-dtu65 sdfstudio-data --data data/dtu/scan65

extract mesh:

In my experience, this error occurs when the model isn't training right, either because of the dataset being invalid or some other error like this. Have you checked the training parameters? Also, you could try and change the flash "save only last checkpoint" to false, so you can check all the checkpoints previous to that. One time I had that error as iteration 200k and I had to go down to 160k to get a valid mesh extraction.
Nonetheless, I can suggest to retrain the model and see if that helps.

I also encountered the same problem. After I trained bakedangelo, I encountered the same error when trying to extract mesh.AttributeError: 'list' object has no attribute 'merge_vertices'

train bakedangelo:ns-train bakedangelo --machine.num-gpus 2 --pipeline.datamanager.train-num-rays-per-batch 1500 --pipeline.model.sdf-field.inside-outside False --vis wandb --experiment-name bakedangelo-dtu65 sdfstudio-data --data data/dtu/scan65
extract mesh:

In my experience, this error occurs when the model isn't training right, either because of the dataset being invalid or some other error like this. Have you checked the training parameters? Also, you could try and change the flash "save only last checkpoint" to false, so you can check all the checkpoints previous to that. One time I had that error as iteration 200k and I had to go down to 160k to get a valid mesh extraction.
Nonetheless, I can suggest to retrain the model and see if that helps.

Hello, I tried several weights and still got the error. The training parameters are those of the author and I have not changed them. The only change is this --pipeline.datamanager.train-num-rays-per-batch 1500. I used two 3090, 24g gpu.


Document all components on a single page

I don't think this idea has been covered before, but @niqjohnson suggested that having a page like Bootstrap's showing every component would be helpful. I tend to agree.
The one thing that gives me pause is the maintenance headache of having to update two repos (the actual component and then the docs) any time you make a change that requires updating the docs.
I have a couple ideas to get around that:

Come up with some way to dynamically generate the page client-side by fetching the latest code/docs from each component's repo
Figure out how to use GitHub's webhooks to trigger a doc rebuild whenever a component is updated

Thoughts, @cfpb/front-end-team-admin @cfpb/front-end-team-write ?

To elaborate a little more: I've used Bootstrap to prototype/design in the browser for a while, and there are a few things about their docs that make that job a lot easier:

The docs are (usually) authoritative and up to date, so I know I can go to one place to find out how to use any component I need (and be pretty confident that, if I can't find the component there, it doesn't exist)
The docs show how different components can be combined, so I know how to use, say, a dropdown inside a navbar
The docs have lots of easily copy-and-pasteable snippets, so I can drop a complex component in a prototype really quickly

I'd love it if Captial Framework had something similar—basically, a single page (or very small collection of pages) where I can grab any component I need, drop it into an HTML prototype, and learn how to modify or extend it.

I agree something like that would be useful. Especially for something like the more visual components like cf-icons.
We could revamp the demo pages and link to those, however that really doesn't show how the components can be combined. That would seem to require some human curation.

We didn't end up using them in a single page, but we did create a sandbox that removes all the documentation to make it easier to see just the components. @niqjohnson take a look at https://cfpb.github.io/capital-framework-sandbox/components/ and let me know if that's about what you were looking for. It's built upon this repo's gh-pages but with a few tweaks.

The sandbox plus the new documentation pages have been working great for me lately. 👍

Awesome. Let's consider this resolved and if a future problem arrises we can address it in a new issue.


Ubuntu - Launching with desktop icon doesn't remember open folders

VSCode Version: Code 1.14.0 (b8cd5b9556d8b70ea560d35b903422363f6c5c40, 2017-07-10T20:36:40.018Z)

Note: This was occurring on the prior version as well.

OS Version: Linux x64 4.8.0-58-generic (Ubuntu 16.10 64-bit)
Extensions: none

Steps to Reproduce:

Install fresh version of VSCode 1.14.0 (cleared local cache files, ~/.vscode, ~/.config/Code)
Launch VSCode, open a folder within VSCode, close VSCode (either by top-right X, or Ctrl+Q)
Reopen VSCode from desktop icon created by installer

Expected functionality:
VSCode should reopen the previously opened folders
Actual functionality:
VSCode opens to the main startup screen with no folder opened.
I cannot reproduce this by launching a terminal and running /usr/share/code/code. However, if I close the terminal's instance of VSCode and launch one from the desktop, then close that one and open VSCode from the same terminal, the folders remain forgotten (as expected, I think).
I can provide any relevant debugging or screenshots / screencaptures.
As an update, I can confirm clicking "reload" when an extension installs keeps the folders open, for whatever that's worth.

As additional data point, Code doesn't reopen folder on Fedora/Gnome either, regardless of the window.restoreWindows value. This behaviour started with 1.13.


Why karma-phantomjs-launcher is in the "dependencies" ?

Currently, I work on a side project with Atom Electron, and I use this libs to access GitHub API.
But when I package the application, I found the size added more than 40M. Finally, and I found the  karma-phantomjs-launcher is the reason, I think it should be in "devDependencies".

Yikes, really? When'd that happen? Will push a fix to that momentarily, thanks for letting us know!

@aendrew Thanks for your quick fix.
When use the Electron to package the application, it will also package the  node_modules. In the prev verison, the libs karma, phantomjs was depended by karma-phantomjs-launcher, those packages will also be package to application. the size of karma almost 30M, and  phantomjs will be 15M.

@phodal Yep, is definitely a problem. Would also be problematic for Browserify and Webpack users.


Update link to Go docs

The Cloudflare provider is now at v5. The Go docs pointed to v3, which didn't have any (useful) types.

Thanks!


How to solve this sqlstate error?

echodeMacBook-Pro:blog echopan$ sudo php artisan canvas:install
Password:
Welcome to the Canvas Install Wizard! You'll be up and running in no time...
An unexpected error occurred. Installation could not continue.
✘ SQLSTATE[HY000] [2002] No such file or directory
Migrations were rolled back. Please run the installer again.
If this error persists please consult https://github.com/cnvs/easel/issues.

My environment:
Mac OS 10.12.3
php -v
PHP 5.6.28 (cli) (built: Dec  6 2016 12:38:54)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
mysql 5.5.42

http://stackoverflow.com/a/20733001/2807030

@angelfreedomv Did the link above give you any further clarity on the issue?

Try this: mysqld

I've gotten that before when I had the wrong database name in .env

@angelfreedomv Has the latest update to Easel fixed this issue for you?

Your MySQL might not be started and perhaps that error thrown is because the application is unable to find mysql.sock.

Still error showing on XAMPP Environment in Mac but changing localhost to <IP_ADDRESS> suggested in  http://stackoverflow.com/a/20733001/2807030 is solve problem.


Add an HTML Minifier

HTML minification was an old feature of vulcanize (https://github.com/Polymer/vulcanize/issues/185).
html-minifier seemed to hang in my evaluation. An AST based minifier with dom5 would probably be the safest route.

Would this help? This article mentions a configuration for html-minifier:
https://jongeho.wordpress.com/2015/06/24/endeavors-with-polymer-1-0-vulcanize-crisper-html-minifier/

@arthurevans I tried the config given in the link you shared. Its also used in https://github.com/StartPolymer/polymer-starter-kit-plus.
Here's the vulcanize task config I tried:
// Vulcanize imports
gulp.task('vulcanize', function () {
  var DEST_DIR = 'dist/elements';

  return gulp.src('dist/elements/elements.vulcanized.html')
    .pipe($.vulcanize({
      stripComments: true,
      inlineCss: true,
      inlineScripts: true
    }))
    .pipe($.crisper())
    // Minify elements.vulcanized.html
    // https://github.com/PolymerLabs/polybuild/issues/3
    .pipe($.if('*.html', $.htmlmin({
      customAttrAssign: [
        {source:'\\$='}
      ],
      customAttrSurround: [
        [ {source: '\\({\\{'}, {source: '\\}\\}'} ],
        [ {source: '\\[\\['}, {source: '\\]\\]'}  ]
      ],
      removeComments: true
    })))
    .pipe($.if('*.js', $.uglify()))
    .pipe(gulp.dest(DEST_DIR))
    .pipe($.size({title: 'vulcanize'}));
});

It hangs for me too.

after
.pipe($.vulcanize({
      stripComments: true,
      inlineCss: true,
      inlineScripts: true
    }))
.pipe($.crisper())

i use
.pipe($.minifyHtml())
.pipe($.minifyInline())

and got a file smaller than polybuild

Now Polybuild dont need minifier because we have https://github.com/PolymerLabs/polyclean ? Do we need include its inside polybuild or just add to pipeline?

I believe that polybuild now includes optional minification with the  --maximum-crush flag. Can this ticket be closed, @azakus, or are there still outstanding issues?

There's still no html minification in polybuild, nor in polyclean.
I admit to not really looking at this issue recently, as I've seen wildly different outcomes for HTML minimizing tools depending on the input HTML.
I haven't seen a single tool that works reliably for all use cases, and that makes me wary of adding one here.

Oh, duh. Was confusing HTML minification with the JS minification option. Never mind.

Starting out with comment and whitespace removal would be a nice start.

So I did some analysis and whitespace removal would be a lame start.
In my case, HTML/CSS make up about 10% of the final output, so the maximum HTML/CSS minification could save is 10%.  Then I dug into the 30KB of HTML/CSS code and found that the biggest waste of space were comments and unused styles and SVG icons imported by paper-button and elements depending on paper-styles.
I compared the size of the raw and minified CSS from Bootstrap and Foundation after compression with gzip and minification only shaved off an additional 1.5K and 4K respectively (18.5K->17K and 22K->18K).
I'm sure there are other optimizations to be made, such as using CSS shorthand, but we definitely need holistic analysis of the HTML, CSS, and JS.

I just tried out the following setup which seemed to work for me just fine:
gulp.task('build', function() {
  return gulp.src('app/index.html')
  .pipe(polybuild({
    maximumCrush: true,
    suffix: ''
  }))
  .pipe(load.if('*.html', load.minifyHtml({
    quotes: true,
    empty: true,
    spare: true
  })))
  .pipe(gulp.dest('dist/.'));
});

Maybe just a mention in the README about the HTML minification could instruct how developers can enable HTML minifying if they desire so.


Overlay components cannot find the component to present from

Short description of the problem:
Opening an overlay component in ionViewDidEnter never actually presents the component because the overlay cannot find the component that it should present from.
This is the NavPortal when opening an overlay component in ionViewDidEnter:

This is the NavPortal when opening an overlay component in a timeout in ionViewDidEnter:

Steps to reproduce:

Try to open an overlay component such as a loading or alert in ionViewDidEnter

Which Ionic Version? 2.0.0-beta.11

Debugging notes: cant seem to reproduce this with the latest master

Added a test for this with this pr: https://github.com/driftyco/ionic/pull/7606

Since this issue was added to the beta.12 milestone, is it safe to bet that a fix won't be released until then? That's totally fine and understandable if that's the case- that's life working with (amazing) beta software. Are there any instructions anywhere on how to properly downgrade back to a previous beta version that would be recommended?

@TheBrockEllis Good question! We normally do a few nightly releases before doing another full beta release, so the fix for this should be available before beta.12 (its already fixed on the master branch). Also, just so you know the workaround for this is to just wrap your logic that is in your ionViewDidEnter with a setTimeout. To downgrade back to beta.10 (although i would not recommend it as beta.11 has a ton of fixes for issues in beta.10) you can just follow the upgrade steps in our changelog backwards haha. Thanks for using Ionic! Finally, I added a test for this issue in my above pr (that has since been merged) so that we can watch out for this issue in the future.

Thanks a bunch, @jgw96! I'm working on 3 separate ionic apps right now and use the loading component pretty extensively. I'll move forward and use the setTimeout with the Loading component inside of the ionViewDidEnter page event. I'll also start migrating a lot of the logic out of my Page's constructors and into the page event instead. Thanks so much for all the helps, the tips and all the community work you do here.

Thanks for all the kind words! 😃

Hmmm, does not seem to be fixed in the latest nightly, will be looking further into this.

When I set the type to LoadingController tslint complains about not being able to assign type Loading to LoadingController. I am not sure if this is related to this issue or if it is a linting problem!!
Setting the type to any seems to load the current page, but when navigating to another page with a loading component, an error exception:
browser_adapter.js:84 EXCEPTION: Error: Uncaught (in promise): TypeError: Cannot read property 'create' of undefined
Makes the Loading component unusable.

LoadingCtrl = handles creating loading views
Loading = instance of a loading view
You shouldn't have problem with TS lint if you do this:
let l:Loading = loadingCtrl.create(...);
l.present();

Setting the type as Loading helped. The problem was I was not importing it from ionic-angular.
Thanks for pointing out that one. @Kobzol

is there a schedule for fixing the issue?
the loadingcontroller caused my app black screen for 1 -2 second on ios device when transfer to another page.

Note to team: this seems to be isolated to tabs apps, cant seem to repro with the test i added or a sidemenu app, but can repro with a tabs starter.

Can anyone point out a hack around this? setTimeout?

@EralpB the current workaround is to put your ionViewDidEnter logic in a setTimeout. Sorry for any hassle this issue causes for you!

@jgw96 put my ionViewDidEnter logic in a setTimeout ? which page?

setTimeout(()=> {
let loadingCtrl = new LoadingController(Global.myApp);
}, 0);
put the loadingController int setTimeOut

ngOnInit() {
let loading: Loading = this.presentLoading('Carregando notícias');
this.getNoticias(5, 0)
  .then(res => {
    this.noticias = res;
    loading.dismiss();
  });

}
presentLoading(texto: string): Loading {
let loader: Loading = this.loadingController.create({
content: texto
});
setTimeout(() => {
  loader.present();
}, 300);

return loader;

}
workaround...

loadingCtrl.create is throwing the following error suddenly
(index):29 Uncaught EXCEPTION: Error in build/pages/page1/page1.html:13:21 ORIGINAL EXCEPTION: TypeError: Cannot read property 'create' of undefined ORIGINAL STACKTRACE: TypeError: Cannot read property 'create' of undefined     at Page1.findCentre (http://localhost:8100/build/js/app.bundle.js:230:39)     at DebugAppView._View_Page10._handle_click_20_0 (Page1.template.js:502:28)     at http://localhost:8100/build/js/app.bundle.js:32355:24     at http://localhost:8100/build/js/app.bundle.js:45802:36     at http://localhost:8100/build/js/app.bundle.js:45888:111     at ZoneDelegate.invoke (http://localhost:8100/build/js/zone.js:323:29)     at Object.onInvoke (http://localhost:8100/build/js/app.bundle.js:37722:41)     at ZoneDelegate.invoke (http://localhost:8100/build/js/zone.js:322:35)     at Zone.runGuarded (http://localhost:8100/build/js/zone.js:230:48)     at NgZoneImpl.runInnerGuarded (http://localhost:8100/build/js/app.bundle.js:37755:78) ERROR CONTEXT: [object Object] http://localhost:8100/build/js/zone.js Line: 260
tried various workarounds but can't seem to fix
please help at the earliest

Hello all! Thanks for all the info. I am happy to report that this has been fixed and will be in the beta.12 release. Thanks for using Ionic!


chore(jsdocs): enhance JSDoc examples across multiple hooks and functions

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR introduces enhancements related to wallet interactions, contract calls, and event monitoring in the application.
Detailed summary

Added functionality to pre-authenticate users via email or phone number
Enhanced wallet connection components with account abstraction and gas sponsorship options
Updated wallet connection buttons to support account abstraction and gas sponsorship
Improved wallet information retrieval with examples
Expanded capabilities for fetching wallet balances for native and specific tokens
Enhanced contract call preparation with examples of different method signatures and value options
Improved contract event monitoring with event extensions and custom event watching
Updated contract read hooks to automatically update on contract changes

The following files were skipped due to too many changes: packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts, packages/thirdweb/src/transaction/actions/send-transaction.ts, packages/thirdweb/src/react/web/hooks/transaction/useSendTransaction.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3908  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite


comm: move from getopts to clap

Closes #1940
tests are passing and there is no problem with clippy and rustfmt

Excellent, thanks!


Patch compilation time

ASV spotted a regression in compilation time, see spike here on https://github.com/devitocodes/devito/commit/891bfc4c
This patch fixes it.
It also speeds-up filter_ordered (now key only computed once) and adds a simple tree visitor test

And btw, are compilation times with this patch basically the same or better than before the regression?

And btw, are compilation times with this patch basically the same or better than before the regression?

TTI-forward would seem mildly better. Definitely not slower


API access to list of icon names

It would be nice to have access to a list of icon names (and categories?).

@opet could you give an example on the format you wish to receive?
I started building a JSON like the one here (without .svg in each name):
{
  all: ['nrk-logo-nrk', 'nrk-logo-mp3', 'nrk-media-play'],
  logo: ['nrk-logo-nrk', 'nrk-logo-mp3'],
  media: ['nrk-media-play']
}

But any change is of course possible :)

I guess that works pretty well. I don't really have a preference.

Closed by #26