Always create Delayed object for store

Pulls some changes out of PR ( https://github.com/dask/dask/pull/2980 ).
Instead of handling the compute=True and compute=False cases of store through two different mechanisms, always create a Delayed object at the end. Then either call compute on the object if compute=True or return the Delayed object if compute=False.

Seems fine to me

Thanks for taking a look. Wasn't sure if there was any advantage to using compute_as_if_collection compared to calling compute on a Delayed object. If not, seems like using the same strategy for both would be nicer.
Failure is due to issue ( https://github.com/dask/dask/issues/2996 ). So should be cleared up once that is resolved.

Planning on merging tomorrow if there are no other comments.

Ok. Happy to revert. That said, I’m away from the computer currently (on mobile sans git).

No big rush, we've been doing the compute=False approach here badly for a
long while.  I would just roll in changes to the larger PR.
On Fri, Dec 15, 2017 at 6:39 PM, jakirkham<EMAIL_ADDRESS>wrote:

Ok. Happy to revert. That said, I’m away from the computer currently (on
mobile sans git).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3000#issuecomment-352145715, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszLNS6ly3U6AJqQUlaVZKKFmzuIqoks5tAxFMgaJpZM4RCYnI
.

Ok, I'll assign myself so I don't forget.

Have added PR ( https://github.com/dask/dask/pull/3005 ) to revert this.


vnclip operands reversed?

Section 13.6 has
# Narrowing signed clip,  vd[i] = clip(round(vs1[i] + rnd) >> vs2[i])
#                                     SEW           2*SEW                 SEW

which treats vs1/rs1/imm as a 2SEW value which doesn't make much sense.  A vector reg can be 2SEW but rs1/imm are not normally treated as 2*SEW.  Also, the previous section for scaling shift has
vssrl.vv vd, vs2, vs1, vm   # vd[i] = ((vs2[i] + round)>>vs1[i])

which is more sensible looking but has reversed operands from the vnclip definition.  I think the vnclip definition is wrong.

Yes, vnclip was incorrect. Fixing.  Thanks.


Paste Color Code Doesn't Save After Reload

I created my color code in m64mm3 so i paste my color code into the paste color code box of sm64js, but when i do that, it doesn't save it when i reload to go to a new map or something like that so i have to keep pasting it. Check the GIF below to see what i mean.

Temporary fix, but to fix this just move an ambient slider back and forth in the on-site customizer, this will refresh the save.
Good report though.

that is what i sometimes do but will this be fixed?

Yes, at some point i will fix this. Just do that for now.


DestroyHoisting: support of begin_apply and end_apply instructions

This enables destroy hoisting when accessor co-routines are not yet inlined.
https://bugs.swift.org/browse/SR-11675
rdar://problem/56704059

@swift-ci test

@swift-ci benchmark

Build failed
Swift Test OS X Platform
Git Sha - fbd41f7f6647473c45b3830a62031aae06b6ca2f

@swift-ci test

@eeckstein Awesome, thank you! This is affecting the performance of an upcoming SwiftNIO feature. Do you think this would be safe enough to backport to swift-5.1-branch? The patch looks quite innocent to me :)

@weissi Unfortunately not. The whole destroy hoisting optimization is not on the 5.1 branch yet.

@eeckstein got it, thank you!


Install php@74 error

curl: (22) The requested URL returned error: 404
Error: Failed to download resource<EMAIL_ADDRESS>Download failed: https://ghcr.io/v2/shivammathur/php/php%407.4-7.4.16.big_sur.bottle.tar.gz
Has retaped before installing refer to issue245

@nicecp
Check your brew version, it should be 3.1.1 or newer.
brew --version

else, Please update your brew
brew update

Then install php, if it fails again, provide the complete logs

it`s still 404...
cp@cpdeMacBook-Pro ~ % brew --version
Homebrew 3.1.2
Homebrew/homebrew-core (git revision f8462fccd0; last commit 2021-04-15)
Homebrew/homebrew-cask (git revision 1fb47889db; last commit 2021-04-15)
cp@cpdeMacBook-Pro ~ % brew install<EMAIL_ADDRESS>==> Installing<EMAIL_ADDRESS>from shivammathur/php
==> Downloading https://mirrors.ustc.edu.cn/homebrew-bottles/openssl%401.1-1.1.1k.big_sur.bottle.tar.gz
==> Downloading from<EMAIL_ADDRESS>#=#=-#  #
curl: (22) The requested URL returned error: 404 Not Found
Trying a mirror...
==> Downloading https://ghcr.io/v2/homebrew/core/openssl%401.1-1.1.1k.big_sur.bottle.tar.gz
#=#=-#  #
curl: (22) The requested URL returned error: 404
Error: Failed to download resource<EMAIL_ADDRESS>Download failed: https://ghcr.io/v2/homebrew/core/openssl%401.1-1.1.1k.big_sur.bottle.tar.gz

ok, This is unrelated to this tap.
https://mirrors.ustc.edu.cn/homebrew-bottles/openssl%401.1-1.1.1k.big_sur.bottle.tar.gz should be https://mirrors.ustc.edu.cn/homebrew-bottles/bottles/openssl%401.1-1.1.1k.big_sur.bottle.tar.gz.
To fix this, set your mirror correctly.
http://mirrors.ustc.edu.cn/help/homebrew-bottles.html
Set HOMEBREW_BOTTLE_DOMAIN to https://mirrors.ustc.edu.cn/homebrew-bottles/bottles
export HOMEBREW_BOTTLE_DOMAIN=https://mirrors.ustc.edu.cn/homebrew-bottles/bottles

it`s correct right now~, ths!


Adds subsection for IOHK Binary cache

This provides the ability to link to this section from other
projects.

bors merge


InputMaybe should explicitly include undefined

Which packages are impacted by your issue?
@graphql-codegen/add
@graphql-codegen/cli
@graphql-codegen/typescript
@graphql-codegen/typescript-operations
Describe the bug
When using the typescript compiler option "exactOptionalPropertyTypes": true, the fact that InputMaybe<T> does not explicitly include undefined makes it hard to use as you can no longer pass optional values to query variables.
InputMaybe should explicitly include undefined to allow passing optional values to optional variables in queries.
Your Example Website or App
https://stackblitz.com/edit/github-txjvxl?file=query.ts
Steps to Reproduce the Bug or Issue

Open repro
Look at compilation error (if it doesn't show in the editor, run npx tsc to see it)

Expected behavior
No compilation error. Since input variable id is optional, it should allow an optional value to be set to it.
Screenshots or Videos
No response
Platform

OS: macOS
NodeJS: 18.20.3
graphql version: ^16.2.0
@graphql-codegen/add version: ^5.0.0
@graphql-codegen/cli version: ^4.0.1
@graphql-codegen/typescript version: ^4.0.1
@graphql-codegen/typescript-operations version: ^4.0.1

Codegen Config File
import { CodegenConfig } from "@graphql-codegen/cli";

const config: CodegenConfig = {
  schema: "schema.graphql",
  documents: "document.graphql",
  generates: {
    "types.ts": { plugins: ["typescript", "typescript-operations"] },
  },
};

export default config;

Additional context
No response

Hi @ericbf
inputMaybeValue can be used to add undefined like this:
const config: CodegenConfig = {
  // ...
  generates: {
    'path/to/file.ts': {
      plugins: ['typescript'],
      config: {
        inputMaybeValue: 'T | null | undefined' // Add undefined to inputMaybeValue
      }
    }
  }
}

I'll close this issue, but if this doesn't answer your question, please @ me and let me know to re-open 🙂

I should have specified I’m using the client preset, and this option doesn’t work when using the client preset.

@eddeee888 I should have specified I’m using the client preset, and this option doesn’t work when using the client preset.

We are having the same Problem.
Being able to set inputMaybeValue with the client preset would solve the problem for us.


HamiltonianEvolution refactor

I thought this was going to be addressed in #69 but can we get one class that computes the hamiltonian evolution and then just calls three different functions like hamevo_exp(H, t, ...)?
The three classes that are wrapped by HamiltonianEvolution are not necessary, because they are reconstructed with every call to HamiltonianEvolution.forward, so they could just be functions.
Additionally, more robust tests would be really great.
@jpmoutinho if you want to take this on feel free to assign yourself (and add whatever else you think would be good to have from a refactor) :)

done in the remake, feel free to check @nmheim


Small font size

All text that isn't part of an image is very small.

Screen Resolution is 1920x1080
I have tried using grub-mkfont to make a new .pf2 font file from the minecraft regular otf, but with the --size option set to bigger (tried 60 and 240), then putting that into the theme folder and changing the various mentions of Minecraft Regular 30 to Minecraft Regular 60 (or 240 for that) in theme.txt, but that didn't produce a noticeable effect.
I am using Grub Customizer to change the names of options, but this was a problem since before I started using that.

Did anyone find a way to sign the fonts so that GRUB can load them without disabling secure boot?


acss-fraction fix

Requesting a pull to zorkow:master from tvraman:acss-fraction
Trivial PR, mostly to test my end-to-end github workflow

Can you make a PR into develop branch. Master branch is only for stable versions.

sigh! could you just do a git pull  this time?

You should be able to use the "edit" button to the right of the PR title to edit the branch that the PR is targeted to merge into.  Since the branch is from develop, that should put everything into order.  You should inly see Raman's two commits at that point.

@zorkow, I don't have write access to this repo, or I would have done it for you.  I think either you or @tvraman can do it.

"Davide P. Cervone"<EMAIL_ADDRESS>writes:
that "edit" button is what I'm trying to avoid.
My changes are trivial -- 2 char change:-)
will continue to noodle on this when I have time.

You should be able to use the "edit" button to the right of the PR
title to edit the branch that the PR is targeted to merge into. Since
the branch is from develop, that should put everything into order. You
should inly see Raman's two commits at that point.
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

--

Sorry, I mac not have been clear.  The "edit" button I am talking about allows you to retarget the PR to a different branch (from master to develop).  It is not about editing the files within the PR.  It is a trivial thing, but I can't do it because I don't have write permission to the repository.  Volker should be able to do that for you.

"Davide P. Cervone"<EMAIL_ADDRESS>writes:
I understand, for context, I'm trying to do this without  using a
browser on github.com.
I think I just managed to push the pullreq to the develop branch.> Sorry, I mac not have been clear. The "edit" button I am talking about

allows you to retarget the PR to a different branch (from master to
develop). It is not about editing the files within the PR. It is a
trivial thing, but I can't do it because I don't have write permission
to the repository. Volker should be able to do that for you.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

--

I'm trying to do this without  using a browser on github.com

Ah, sorry.  Now I understand.  Sorry to be a pest.

Merged in PR #372

Sorry I closed without seeing that I there has been a significant thread.
Indeed I should have just rebased myself (I assume I could have done that). But honestly I was not aware of the little edit trick either. I usually just close and open a new PR.
Thanks @dpvc, I shall remember that trick in the future.

Of course now I can't change the base anymore, as the there are no diffs to develop.
But it seems, like I could have done that too.
Closing again.


[MWPW-126441] Unblock style-linting by lowercasing all t-shirt sizes in classnames

Updates all CSS rules to use lowercase t-shirt sizes
Updates all JS files that set classnames to use lowercase t-shirt sizes
Should allow us to get a clearer picture of style-linting errors moving forward

Resolves: MWPW-126441
Test URLs:
(Note that these should both look the same, but the After view uses lowercase t-shirt size classnames)

Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/media?martech=off
After: https://ebartholomew-kebab-case-tshirts--milo--adobecom.hlx.page/docs/library/blocks/media?martech=off

Love it! However, we use some of these classes in bacom. What's your plan for updating the consumers without any disruption to the frontend?

@meganthecoder
For this PR I think we're ok with doing a co-ordinated merge of PRs at the same time.  Looking at bacom only the stats and tree-view blocks are affected.
If it was more complicated, we probably would have to have the PR in Milo support both upper and lower cases temporarily until all consumers had been updated.
@elan-tbx We also need to check the other milo consumers before merging this.

@meganthecoder Sounds good! Thanks for the heads up

@chrischrischris @meganthecoder Hey y'all, I've made a corresponding PR in bacom that aligns with this one. As far as I can tell, that's the only consumer repo that requires further updates... I've checked bacom, bacom-blog, dc, cc, and fedpub. Is there anything else I should do? Maybe a general heads up to devs in Slack about the changes?

Bacom and DC/frictionless do have live pages that most likely use some of these blocks.


Channel Won't Sync with the Category

Hi so when i have my category perms so that some people can't see different modmails. Well when ever it is in the modmail section and I move it over to one of the teams i have in my server the mods can still see it when they should not but when i go in channel settings it ask me to sync the perms. Is there a way the bot can this auto because I see it works for other servers were you can't see the channel but for me its  not working. Please let me know if you have an answer thanks.

Se the syncPermissionsOnMove option to true in your config and it should sync the perms automatically.
This should really be enabled by default, not sure why it's not.

Thanks! It worked. Not sure why it was not not like before. Appreciate the help!


refactor: Remove ITelemetryProperties and replace with equivalent ITelemetryBaseProperties

Description
Removes the deprecated ITelemetryProperties and replaces its internal uses with the equivalent ITelemetryBaseProperties.
Breaking changes
The ITelemetryProperties export is removed from @fluidframework/core-interfaces.
Reviewer Guidance
The review process is outlined on this wiki page.

Closing in favor of https://github.com/microsoft/FluidFramework/pull/19752 that includes these changes.


Specifying flags through command line and env variables still requires a config.yml

What happened
Tried to issue download and deploy commands by specifying credentials through command line args as well as environment variables without a config.yml file but commands failed with error:

Could not find config file at ..

Calling an initial get creates a config.yml but looking to issue commands without doing this.
What I expected to happen
The cli would use the given credentials without checking for the existence of a config.yml file.
Steps to reproduce

From a directory without a config.yml file, specify password, store url, and theme id as command line flags.
Setting the corresponding environment variables results in the same error.

My Environment
OS (including version): Mac OS Sierra 10.12.6
Themekit version: ThemeKit 0.8.1 darwin/amd64
Editor (including version): vim 8.1
Ignore Files(if any): None

Okay, this is a regression, themekit should allow a configless setup.

What version were you using before? Was it a 0.6x series or 0.7.x series because it seems like the 0.7.x would have this same problem as well.

Okay so I can run theme get -p=[password] -s=[store] -t=[theme_id] without a config but I cannot run deploy without a config file.

@samkim Okay I have a PR to handle this. Please install it and test it by running theme update --version=v0.8.2-prerelease

Any ETA for v0.8.2? And is node-themekit will be updated too?
Thanks!

@mathieuforest I am not sure I will release until the new year. This because the next release will have to be a v1.0.0 release because of breaking changes and right now I am sure plenty of shops are changing their themes for Christmas traffic. I do not want to interrupt that flow. When I release that version though I will check with the team that maintains node-themekit as well to see if they would like to update to that version.


remove only if dataset not affected too much

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Context

[x] Closes #8108

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

🤖[deprecated] Generated by Copilot at 3aa3a30
Improved activity chart by filtering out outliers if they are not too prevalent. Modified ActivityChart.vue to implement this logic.

🤖[deprecated] Generated by Copilot at 3aa3a30

The data is corrupted by the outliers
They distort the truth and the vision
But we have a CUTOFF to defy them
And a condition to avoid division

or we can compare the dataset size before and after outlier removal, and only remove if less then (10%?) of points have been remove
i.e clean/dirty > 0.9
from https://github.com/kodadot/nft-gallery/issues/8108#issuecomment-1822634671

since it's quick and easy, i went ahead and implemented
@yangwao if you don't agree with this solution, lmk

Which charts tells more? I would propose make that checkbox, which could be enabled by default [x] hide outliers and anyone can uncheck it, cc @exezbcz on design
this pr

vs canary

@yangwao yeah mentioned somewhere that I would put it to the settings

by default, it would be on.
option to turn it off

will create issue with the design

Yessir, waiting on the checkbox. Drafting for now

@daiagi

simple as that
https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1287%3A18959&mode=design&t=l9ITDxHsKHJcI9sz-1

closing
alt solution in #8234


Added code for calculating factorial using recursion

I have added for calculating the factorial of a number using recursion in C language.

I have added C language code for a program that functions without main.


[vpj] Support user-friendly input data format for partial update + incremental push

[vpj] Support user-friendly input data format for partial update + incremental push
This PR adds a new input format for partial update when running incremental push.
For field update, user will only need to provide the subset dataset they need to update and VPJ will convert each record into partial update record.
For example:
Store value schema: {F1: String, F2: Int, F3: Array}
User can create a dataset with:
[ {key: k1, value: {f1: "foo", f3: [1, 2]}}, {key: k2, value: {f1: "bar", f3: [3,4]}}]
And after the run, the f1, f3 field of key k1, k2 will be updated and other fields will remain untouched.
How was this PR tested?
New Integration Test added
Added new unit test for Avro record reader logic
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

You need to fix the unit test coverage failure.

Thanks! That's weird, all I changed is a comment... let me retry it.


Rollback fails to remove step functions

Update rollback for the operator library stack does not delete all the state machines cleanly. To reproduce, try to deploy with a stack name that is too long (e.g. 64 characters stack name long). That will cause a rollback. Then the rollback will fail and you'll be left with step functions that need to be manually deleted.

Fixed by #266


Memory optimization for image chunk preparation

There is no need to load all images into memory during chunk preparation
Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Enhanced image loading process for improved performance during task creation.
Introduced a new loading mechanism for images, allowing for better memory management.

Bug Fixes

Streamlined image handling logic to ensure accurate processing and loading.

Documentation

Updated method signatures to reflect changes in image loading functions for clarity.

Codecov Report
Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (4354f72) to head (29151a6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8581      +/-   ##
===========================================
+ Coverage    74.24%   74.28%   +0.04%
===========================================
  Files          403      403
  Lines        43287    43290       +3
  Branches      3914     3914
===========================================
+ Hits         32137    32160      +23
+ Misses       11150    11130      -20

Components
Coverage Δ

cvat-ui
78.77% <ø> (+0.10%)
:arrow_up:

cvat-server
70.47% <69.23%> (+<0.01%)
:arrow_up:

Add a changelog entry, please.


ParamProofConfigStore

based on https://github.com/keybase/client/pull/13779, will rebase once that is merged. requires https://github.com/keybase/keybase/pull/2877 tests to pass
loads known parameterized proof configurations from the server dynamically

merging and will apply the review comments to https://github.com/keybase/client/pull/13830


Load leaflet maps only when visible on screen

Drastically reduces the loading time of the page on mobile devices.

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #447   +/-   ##
=====================================
  Coverage      20%    20%
=====================================
  Files         160    160
  Lines        1235   1235
=====================================
  Hits          247    247
  Misses        988    988

Impacted Files
Coverage Δ

src/components/CenteredMap/LoadableCenteredMap.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef8ad4...2fe454b. Read the comment docs.


run hql script fail

HQL
select * from hduser05db.alte5new limit 100
ERROR
2019-07-25 22:12:48.012 ERROR Request engine failed, possibly due to insufficient resources or background process error(请求引擎失败，可能是由于资源不足或后台进程错误)!
2019-07-25 22:12:48.012 ERROR DWCException{errCode=20010, desc='ClassNotFoundException: org.apache.hadoop.mapreduce.TaskAttemptContext', ip='bdpdwc010003', port=12350, serviceKind='hiveEntrance'}
at com.webank.wedatasphere.linkis.entrance.execute.EngineRequester$EngineInitThread.notifyThread(EngineRequester.scala:108)

Thanks for your issue,  we strongly recommend hive 1.2.1 and hadoop2.7.2 as your version in your organization. We have fixed your issues by updating pom.xml in HiveEM. Now hadoop2.7.2 won't be excluded


Question: Build Error

Hi Rick. I'm trying to use Kmm-ViewModel in my project. I am getting the following error. Any idea how I can resolve this?
Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class com.rickclephas.kmm.viewmodel.KMMViewModel, unresolved supertypes: androidx.lifecycle.ViewModel
Adding -Xextended-compiler-checks argument might provide additional information.

Edited:
I figured it out. I was missing viewmodel dependency in the android module.

Hi, I've read the READ.ME and in principle added all the dependencies. Still, I'm getting the same error as you. Probably, I'm doing something wrong. Could you provide how your dependencies look like. Thank you

@pabloski0000 This is how my build.gradle file looks like:

sourceSets {
         sourceSets["androidMain"].dependencies {
            implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1")
        }

        sourceSets["commonMain"].dependencies {
            implementation("com.rickclephas.kmm:kmm-viewmodel-core:1.0.0-ALPHA-8")
        }
}

Let me know if this helps.

Yes, it worked. I was missing the first library. Thank you very much.


unfreeze conductr-lib

fixes #473

test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1292/consoleFull

[info] Project conductr-lib------------: SUCCESS (project rebuilt ok)


linux-rockpi-4b: Load spidev overlay by default

Changelog-entry: Load spidev overlay by default
Signed-off-by: Alexandru Costache<EMAIL_ADDRESS>

@balena-ci I self-certify!


BUG: etcd container can`t restart

Sealos Version
v4.1.6
How to reproduce the bug?
Sealos  v4.1.6   k8s 1.26  use docker runingtime   , When the cluster runs for a period of time, it will inexplicably hang up，etcd container cant up ，use docker start cli err is
Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to create new parent process: namespace path: lstat /proc/23674/ns/ipc: no such file or directory: unknown
Error: failed to start containers: 7d10ef08273c

What is the expected behavior?
Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to create new parent process: namespace path: lstat /proc/23674/ns/ipc: no such file or directory: unknown
Error: failed to start containers: 7d10ef08273c
What do you see instead?
Sealos  v4.1.6   k8s 1.26  use docker runingtime   , When the cluster runs for a period of time, it will inexplicably hang up，etcd container cant up ，use docker start cli err is
Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to create new parent process: namespace path: lstat /proc/23674/ns/ipc: no such file or directory: unknown
Error: failed to start containers: 7d10ef08273c

Operating environment
- Sealos version:4.1.6
- Docker version:23.0.1
- Kubernetes version:1.26
- Operating system: centos 7.6
- Runtime environment:
- Cluster size:
- Additional information:

Additional information
No response

升级一下runc应该可以解决


Feature Request: Integrate video trailers (and perhaps newsfeed)

Would it be possible to integrate Darklin's Steam Update Newsfeed and the video trailers from the extra metadata plugin in the detail page?
Perhaps with configuration option to enable / disable it?

done in v2.8


Avoid retaining all rustc output in memory.

There are still a few cases where all output is buffered. They are:

Running discovery commands like rustc -vV, rustc --print xxx, etc.
Build script output.
Testsuite's debug .stream() function.

This should cover the concern of the issue, though, which is normal compilation.
Closes #6197

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 17b6df9c42b61777d8482a465814822ac58b397a has been approved by alexcrichton

:hourglass: Testing commit 17b6df9c42b61777d8482a465814822ac58b397a with merge eeb3e16b68aac8d3180bb2a235cd3a0c6d26540d...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing eeb3e16b68aac8d3180bb2a235cd3a0c6d26540d to master...


Temperatures still shown in Celsius when Fahrenheit is selected in settings.

Hi,
Gave your app a try. I changed the "Degrees" setting to Fahrenheit and restarted the app. The symbol for the units did, indeed, change to "F" from "C", but the numerical values did not change.
Thanks!

Hi, try updating the data. On the main screen, swipe down. This is due to the fact that the data is entered in db and for this it is necessary to update.

That fixed it, thanks.
------- Original Message -------
On Monday, May 8th, 2023 at 7:04 AM, Yoshi - notifications at github.com @.***> wrote:

Hi, try updating the data. On the main screen, swipe down. This is due to the fact that the data is entered in db and for this it is necessary to update.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Update auth.yaml

update yaml to use apps/v1 because kind: deployment in extensions/v1beta1 is deprecated

@googlebot I signed it!


Figure out a C# CLI argument parser to incorporate into the email project

https://github.com/commandlineparser/commandline


Fix autocorrect for T::Helpers methods

Motivation
While there is already code to suggest inserting extend T::Helpers when methods called sealed!, final!... are not found, Sorbet is actually not suggesting the autocorrect.
This is because the type passed to maybeSuggestExtendTHelpers is already the type of the attached class, while maybeSuggestExtendTHelpers tries to extract it again.
This PR fixes this problem by passing the attached class directly. See the associated test for an example.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_Hzd6wDiPqCtFyE


hosting environment confusion

AZURE_FUNCTIONS_ENVIRONMENT is missing here. And it's unclear how this variable relates to ASPNETCORE_ENVIRONMENT since documentation is entirely missing on this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18aa54fd-3aa1-37c5-925c-51a0195b1030
Version Independent ID: 60198016-1ea9-e7ae-b00b-2c665d5ad8ca
Content: App settings reference for Azure Functions
Content Source: articles/azure-functions/functions-app-settings.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@paululvinius Thanks for the feedback! We are currently investigating and will update you shortly.

@fabiocav Any thoughts here ?

@paululvinius I have assigned the issue to the content author to evaluate and update as appropriate.

It looks like this question has been answered in https://github.com/Azure/azure-functions-host/issues/4491, but we should still update the docs.


Don't assign IPv6 address when using calico-ipam

IPv6 isn't enabled by default on some hosts.
We should make it a user configurable option to turn it on.

We should make it a user configurable option to turn it on.

Why don't we just do this rather than rip out all the ipv6?

I'm not ripping it all out. I'm just telling our IPAM not to allocate IPv6 since we are not in a position to use the result. I don't have time for a more complete solution so I'd like to get this in as is.

Sure, if you think a more complete solution would take too much time that's fine.
My first impression was that making this configurable would have been two, maybe three lines of code, but perhaps there is more to it.
LGTM.

Easy to do as another PR then :smile:


option for vedio quality .

Checklist

[x] I'm reporting a feature request
[ ] I've verified that I'm running youtube-dl version 2019.12.25
[ ] I've searched the bugtracker for similar feature requests including closed ones

Description

WRITE DESCRIPTION HERE - currently which quality is downloaded cannot be control , can you add an option to download say , 1080 or 2k  or 4k   or  any type

read https://github.com/ytdl-org/youtube-dl#format-selection.


Encrypted entries compatible with DayOne?

I read in issue #329 that the Narrate android app can be used with jrnl entries as it uses the DayOne format. I'm worndering if DayOne and Narrate can read encrypted jrnl entries, or it's only compatible as long as they're not encrypted?

DayOne support and encrypted journals are two separate formats as far as jrnl is concerned.  DayOne itself does not support encryption.  Does Narrate support encryption?  If so, I imagine support could be added in a straight-forward manner.

Ok thanks, I don't know if Narrate supports encryption, I don't think so. Ok so I understand that if you want encryption then forget about compatibility with DayOne/Narrate. Fair enough, I guess...

@drkarl, Let's say your journal is stored at ~/Dropbox/Narrate/, and it is encrypted.  Also, let's say jrnl is enhanced to read the encrypted ~/Dropbox/Narrate/.  How will Narrate read the encrypted file if Narrate doesn't support that file format?  Isn't that a bit like encrypting a .jpg and expecting Preview.app to read it?

Yes, I totally understand that, as I said you have to choose, either compatibility with DayOne/Narrate or encryption. I choose encryption anytime... but if you don't need encryption for some of your journals you can open them with OneDay/Narrate, which is convenient :)

If you want, you can label this as "question" and close it.


Accessibility

Checked page for accessibility. Applied fixes for the following:

Page title: no issues found
Image text alternatives (alt attributes): added missing
Headings: updated hierarchy
Contrast ratio: no issues found
Resize text: no issues found
Keyboard access: no issues found
Forms, labels, errors: add for to labels
Moving, Flashing, or Blinking Content: no issues found
Multimedia (video, audio) alternatives: no issues found
Basic structure check: no issues found

@LionRouge1 I was going to submit my previous comment for second review but the status of my project is already "SUBMIT". Not sure how to move forward... should I submit and merge now? Thank you!

🥳 🎉🥇 💯  💥 🎆 🎈 STATUS: APPROVED 🥳 🎉  🥇  💯  💥   🎆 🎈 🎉

@balatstar  ✋🏼
Your project is great. 🎉 I approve of it. There is nothing else to say other than... it's time to merge it. You can submit this project on your dashboard.

💯 Highlights 💯

Well done show the line of the codes that you change according to the report.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! 💻 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
GitHub | LinkedIn | Twitter
Reviewed by Ahmet Bozacı


A map with a QR code may drop.

If a player receives a map with a QR code through the "/2fa enable" command and then this player dies, then the map may drop and other players can receive this map in this way.
I think it would be nice to prevent this.

Is implemented and merged will be added in the next release.

Version 1.6.0 is out with a fix to this issue!
Thanks to GersomR-afk for the fix to this bug.


Demo gif

Description
Is it just me or does the gif feel slow?

Eh.. not sure if it is just the preview but it seems kinda slow to me and weirdly grainy... let me see if I can get it to look better.

I will switch this to the postgres destination in a future PR. for some reason I cannot get the postgres destination to connect to a my local postgres...


CMO: Implement View Shipment button on order page

When an order is already "In Preparation" a View Shipment  button should be available. Otherwise the user can create multiple shipments from the same order.
Also, the status of the order should be "In preparation".
This was not included in the mockups.

@klivit it is ok that the order could inherit the shipment status?

@klivit it is ok that the order could inherit the shipment status?

Originally, the "In Preparation" status was assigned to the Order (as you propose). During one of the meetings, where we presented the mockups, the point was that it would be more logical and better to move it to Epic 2 and entitle Shipment with this Status, giving better clarity of the physical preparation of the Shipment.
We have another tricky element: Shipment is created without the shipment ID as, again, was clarified during one of the mockup demos; the Courier gives the shipment code. But the Courier is getting in the flow later.
This discussion brings me to the first approach we had, where Order can be "In preparation" and "Ready for Dispatch", and this all is part of Epic 1. The Epic 2 can start from the Shipment being added by the Courier, and some of the elements will be inherited from the Order.
P.S. The idea was that Shipment inherits the Order ID until it is given its Shipment ID (added by the Courier).


Not enforce system notifications to user settings

Revert a small part from #9227.
Full explanation in https://github.com/DefectDojo/django-DefectDojo/pull/8824#issuecomment-1986098912

Dropped a comment in the other PR since that is where the bulk of the context around this PR is: #8824 (comment)
Maybe we could add an additional check for the event type to determine if the system level notifications should trump the user level. Something like this (I could get suggestions to work here):
if event in ["user_mentioned", "review_requested"]:
    # merge the system level notifications with the personal level
    # this allows for system to trump the personal
    merged_notifications = Notifications.merge_notifications_list([system_notifications, recipient_notifications])
    merged_notifications.user = recipient_notifications.user
    logger.debug('Sent notification to %s', merged_notifications.user)
    process_notifications(event, merged_notifications, **kwargs)
else:
    # Do not trump user preferences and send notifications as usual
    logger.debug('Sent notification to %s', recipient_notifications.user)
    process_notifications(event, recipient_notifications, **kwargs)

Thank you @Maffooch for your reaction.
Purely technically, yes, this sounds like an alternative that would work.
However,

This creates an anti-pattern in the systematic handling of notification

I suppose it puts evaluation (of how and if a notification should be processed) logic in the place where it should not be.

It would create undo documented behavior solving one (sorry, two) specific use-case(s).

I believe @Maffooch thought process and approach seems the best here

@grendel513 Thanks for chiming in - I've been meaning to comment on this for far too long.
Basically, I agree with the idea of checking the event from @Maffooch - I'm thinking that if I were a user who opted out of a notification, I'd be irritated if I got one anyway - excluding mentions or specific requests for me.
Matt's 2 cents

Ok, I will change the implementation to what @Maffooch offered.
But I will add an option to customize a list of events via EnvVars (loaded in Settings) with default ["user_mentioned", "review_requested"] - to allow admins to easily change this behavior.

Hi @mtesauro / @devGregA / @Maffooch / @cneill / @blakeaowens. I would like to ask for a review.
It is an enabler for #8824 and it would be nice to have them both in the following release.

@kiblik

Ok, I will change the implementation to what @Maffooch offered. But I will add an option to customize a list of events via EnvVars (loaded in Settings) with default ["user_mentioned", "review_requested"] - to allow admins to easily change this behavior.

Fair enough - that's a great middle ground. Thanks for that addition :+1:

@mtesauro, can I ask for a merge please?

@kiblik Sure thing - merging now


CCDB atsec/1 - Section B.1.4

FCS_COP.1/PBKDF
Comment:
The SFR FCS_COP.1/PBKDF requires the iteration number for the assignment must be greater than or equal to 1000. Such a lower bound is not specified in the SFR for PBKDS in other protection profiles (e.g., https://www.niap-ccevs.org/MMO/PP/PP_MDF_V3.2.pdf). A lower round of PBKDF should be allowed to use in conjunction with another mitigation method to protect against brute force attack.
Proposal:
See Stanley Potter`s proposal on 2022-04-26 in section 6 of this document.
Priority: 2

Resolved with TD DSC0001

Thank you, Brian! Congratulations on the first TD!


Max App not identified as "Video" sensor and shows up as "Unknown"

Preconditions

[X] Requirements fulfilled
[X] The bug is not a known issue
[X] The bug has not been solved in the past or the solution that was provided in the past does not work on my system
[X] There is currently no other opened issue that describes this bug
[X] I cannot find any solution to the problem in GitHub discussions
[X] I am certain that the problem that I am having is a bug

Analysis
When exposing the media type as sensors, the (HBO) Max app on Apple TV triggers the "Unknown" sensor and not the "Video" sensor as intended. URL for media is com.wbd.stream .
Expected Behavior
The Max app should trigged the "Video" sensor.
Steps To Reproduce

Expose media types as sensor for both video and unknown.
Launch (HBO) Max app.
Play anything on app.
Sensor will show as "Unknown."

Logs
[4/14/2024, 9:17:05 PM] [Apple TV Enhanced] [I] Update check: Attempting to update AppleTV Enhanced to version 1.3.1
[4/14/2024, 9:35:42 PM] [Apple TV Enhanced] Restarting child bridge...
[4/14/2024, 9:35:42 PM] Got SIGTERM, shutting down child bridge process...
[4/14/2024, 9:35:47 PM] [Apple TV Enhanced] Child bridge process ended
[4/14/2024, 9:35:47 PM] [Apple TV Enhanced] Process Ended. Code: 143, Signal: null
[4/14/2024, 9:35:54 PM] [Apple TV Enhanced] Restarting Process...
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] Launched child bridge with PID 89479
[4/14/2024, 9:35:55 PM] The plugin "homebridge-appletv-enhanced" requires Node.js version of ^20.11.1 || ^18.19.1 which does not satisfy the current Node.js version of v20.9.0. You may need to upgrade your installation of Node.js - see https://homebridge.io/w/JTKEF
[4/14/2024, 9:35:55 PM] Registering platform 'homebridge-appletv-enhanced.AppleTVEnhanced'
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] Loaded homebridge-appletv-enhanced v1.3.0 child bridge successfully
[4/14/2024, 9:35:55 PM] Loaded 0 cached accessories from cachedAccessories.0EBA4E73C1F0.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Platform: Finished initializing platform: Apple TV Enhanced
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Update check: The update checker is configured to check for updates every 60 minutes, excluding betas. Auto updating is turned on.
[4/14/2024, 9:35:55 PM] Homebridge v1.7.0 (HAP v0.11.2) (Apple TV Enhanced) is running on port 52551.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [W] Update check: There is a new version of AppleTV Enhanced available (excluding betas): 1.3.1. You are currently using 1.3.0
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [E] Update check: Could not determine the path where to install the plugin since the environment variable UIX_CUSTOM_PLUGIN_PATH is not set.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Update check: Attempting to update AppleTV Enhanced to version 1.3.1
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Starting python check.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: plugin dir exists.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Python 3.11.9 is installed and supported by the plugin.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Virtual environment already exists.
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Venv is using current system python version (3.11.9).
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Venv pip version: 24.0
[4/14/2024, 9:35:55 PM] [Apple TV Enhanced] [I] Python check: Checking if there is an update for venv pip ...
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Python check: Venv pip is up-to-date
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Python check: Python requirements are satisfied.
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Python check: Finished
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Platform: Starting device discovery ...
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Platform: Adding Apple TV Living Room Apple TV ((removed for privacy))
[4/14/2024, 9:35:56 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): verifying credentials ...
[4/14/2024, 9:35:57 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): Credentials are still valid. Continuing ...
[4/14/2024, 9:35:57 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): Exposing Apple TV as accessory of type set-top box.
[4/14/2024, 9:35:57 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Finished initializing
[4/14/2024, 9:35:57 PM] Apple TV Living Room Apple TV 5AB7 is running on port 63558.
[4/14/2024, 9:35:57 PM] Please add [Apple TV Living Room Apple TV 5AB7] manually in Home app. Setup Code: 654-08-494
[4/14/2024, 9:35:58 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Active State: on
[4/14/2024, 9:35:58 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Media Type State: unknown
[4/14/2024, 9:35:58 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Current App: com.wbd.stream
[4/14/2024, 9:35:58 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:38:04 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:38:07 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:38:14 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:38:20 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:38:55 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:39:29 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:40:00 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:40:03 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:40:08 PM] [Apple TV Enhanced] Restarting child bridge...
[4/14/2024, 9:40:08 PM] Got SIGTERM, shutting down child bridge process...
[4/14/2024, 9:40:13 PM] [Apple TV Enhanced] Child bridge process ended
[4/14/2024, 9:40:13 PM] [Apple TV Enhanced] Process Ended. Code: 143, Signal: null
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] Restarting Process...
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] Launched child bridge with PID 89706
[4/14/2024, 9:40:20 PM] The plugin "homebridge-appletv-enhanced" requires Node.js version of ^20.12.1 || ^18.20.1 which does not satisfy the current Node.js version of v20.9.0. You may need to upgrade your installation of Node.js - see https://homebridge.io/w/JTKEF
[4/14/2024, 9:40:20 PM] Registering platform 'homebridge-appletv-enhanced.AppleTVEnhanced'
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] Loaded homebridge-appletv-enhanced v1.3.1 child bridge successfully
[4/14/2024, 9:40:20 PM] Loaded 0 cached accessories from cachedAccessories.0EBA4E73C1F0.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Platform: Finished initializing platform: Apple TV Enhanced
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Update check: The update checker is configured to check for updates every 60 minutes, excluding betas. Auto updating is turned on.
[4/14/2024, 9:40:20 PM] Homebridge v1.7.0 (HAP v0.11.2) (Apple TV Enhanced) is running on port 52551.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Update check: You are using the latest version of AppleTV Enhanced (excluding betas): 1.3.1
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Python check: Starting python check.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Python check: plugin dir exists.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Python check: Python 3.11.9 is installed and supported by the plugin.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Python check: Virtual environment already exists.
[4/14/2024, 9:40:20 PM] [Apple TV Enhanced] [I] Python check: Venv is using current system python version (3.11.9).
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Venv pip version: 24.0
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Checking if there is an update for venv pip ...
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Venv pip is up-to-date
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [W] Python check: Python requirements are not satisfied. Installing them now ...
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: aiohttp==3.9.3 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 1)) (3.9.3)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: aiosignal==1.3.1 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 2)) (1.3.1)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: annotated-types==0.6.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 3)) (0.6.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: async-timeout==4.0.3 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 4)) (4.0.3)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: attrs==23.2.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 5)) (23.2.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: certifi==2024.2.2 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 6)) (2024.2.2)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: cffi==1.16.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 7)) (1.16.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: chacha20poly1305-reuseable==0.12.1 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 8)) (0.12.1)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: charset-normalizer==3.3.2 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 9)) (3.3.2)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: cryptography==42.0.5 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 10)) (42.0.5)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: frozenlist==1.4.1 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 11)) (1.4.1)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: idna==3.6 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 12)) (3.6)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: ifaddr==0.2.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 13)) (0.2.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: mediafile==0.12.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 14)) (0.12.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: miniaudio==1.59 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 15)) (1.59)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: multidict==6.0.5 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 16)) (6.0.5)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: mutagen==1.47.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 17)) (1.47.0)
[4/14/2024, 9:40:21 PM] [Apple TV Enhanced] [I] Python check: Collecting protobuf==5.26.1 (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 18))
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Downloading protobuf-5.26.1-cp37-abi3-macosx_10_9_universal2.whl.metadata (592 bytes)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: pyatv==0.14.5 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 19)) (0.14.5)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Collecting pycparser==2.22 (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 20))
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Downloading pycparser-2.22-py3-none-any.whl.metadata (943 bytes)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Collecting pydantic==2.6.4 (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 21))
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Downloading pydantic-2.6.4-py3-none-any.whl.metadata (85 kB)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 85.1/85.1 kB 2.4 MB/s eta 0:00:00
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: pydantic_core==2.16.3 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 22)) (2.16.3)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: requests==2.31.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 23)) (2.31.0)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: six==1.16.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 24)) (1.16.0)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: srptools==1.0.1 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 25)) (1.0.1)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: tabulate==0.9.0 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 26)) (0.9.0)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Collecting typing_extensions==4.11.0 (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 27))
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Downloading typing_extensions-4.11.0-py3-none-any.whl.metadata (3.0 kB)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: urllib3==2.2.1 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 28)) (2.2.1)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Requirement already satisfied: yarl==1.9.4 in ./appletv-enhanced/.venv/lib/python3.11/site-packages (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 29)) (1.9.4)
[4/14/2024, 9:40:22 PM] [Apple TV Enhanced] [I] Python check: Collecting zeroconf==0.132.0 (from -r /usr/local/lib/node_modules/homebridge-appletv-enhanced/requirements.txt (line 30))
[4/14/2024, 9:40:23 PM] [Apple TV Enhanced] [I] Python check: Downloading zeroconf-0.132.0.tar.gz (170 kB)
[4/14/2024, 9:40:23 PM] [Apple TV Enhanced] [I] Python check: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 170.3/170.3 kB 7.2 MB/s eta 0:00:00
[4/14/2024, 9:40:23 PM] [Apple TV Enhanced] [I] Python check: Installing build dependencies: started
[4/14/2024, 9:40:24 PM] [Apple TV Enhanced] [I] Python check: Installing build dependencies: finished with status 'done'
[4/14/2024, 9:40:24 PM] [Apple TV Enhanced] [I] Python check: Getting requirements to build wheel: started
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Getting requirements to build wheel: finished with status 'done'
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Preparing metadata (pyproject.toml): started
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Preparing metadata (pyproject.toml): finished with status 'done'
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Downloading protobuf-5.26.1-cp37-abi3-macosx_10_9_universal2.whl (404 kB)
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 404.0/404.0 kB 10.4 MB/s eta 0:00:00
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Downloading pycparser-2.22-py3-none-any.whl (117 kB)
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 117.6/117.6 kB 14.4 MB/s eta 0:00:00
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Downloading pydantic-2.6.4-py3-none-any.whl (394 kB)
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 394.9/394.9 kB 21.3 MB/s eta 0:00:00
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Downloading typing_extensions-4.11.0-py3-none-any.whl (34 kB)
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Building wheels for collected packages: zeroconf
[4/14/2024, 9:40:25 PM] [Apple TV Enhanced] [I] Python check: Building wheel for zeroconf (pyproject.toml): started
[4/14/2024, 9:41:27 PM] [Apple TV Enhanced] [I] Python check: Building wheel for zeroconf (pyproject.toml): still running...
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Building wheel for zeroconf (pyproject.toml): finished with status 'done'
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Created wheel for zeroconf: filename=zeroconf-0.132.0-cp311-cp311-macosx_14_0_arm64.whl size=3560624 sha256=df6468c4d359ee0553fc896d94a204fddebcd3b3b76a9da9d9d43d28fe2853a8
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Stored in directory: /Users/caleb/Library/Caches/pip/wheels/04/94/5d/f916e2d4b15c7332477b421e5f86b518751fa3c27b58fce148
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Successfully built zeroconf
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Installing collected packages: zeroconf, typing_extensions, pycparser, protobuf, pydantic
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Attempting uninstall: zeroconf
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Found existing installation: zeroconf 0.131.0
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Uninstalling zeroconf-0.131.0:
[4/14/2024, 9:42:18 PM] [Apple TV Enhanced] [I] Python check: Successfully uninstalled zeroconf-0.131.0
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Attempting uninstall: typing_extensions
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Found existing installation: typing_extensions 4.10.0
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Uninstalling typing_extensions-4.10.0:
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Successfully uninstalled typing_extensions-4.10.0
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Attempting uninstall: pycparser
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Found existing installation: pycparser 2.21
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Uninstalling pycparser-2.21:
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Successfully uninstalled pycparser-2.21
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Attempting uninstall: protobuf
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Found existing installation: protobuf 4.25.3
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Uninstalling protobuf-4.25.3:
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Successfully uninstalled protobuf-4.25.3
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Attempting uninstall: pydantic
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Found existing installation: pydantic 2.6.3
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Uninstalling pydantic-2.6.3:
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Successfully uninstalled pydantic-2.6.3
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Successfully installed protobuf-5.26.1 pycparser-2.22 pydantic-2.6.4 typing_extensions-4.11.0 zeroconf-0.132.0
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Python check: Finished
[4/14/2024, 9:42:19 PM] [Apple TV Enhanced] [I] Platform: Starting device discovery ...
[4/14/2024, 9:42:22 PM] [Apple TV Enhanced] [I] Platform: Adding Apple TV Living Room Apple TV ((removed for privacy))
[4/14/2024, 9:42:22 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): verifying credentials ...
[4/14/2024, 9:42:22 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): Credentials are still valid. Continuing ...
[4/14/2024, 9:42:22 PM] [Apple TV Enhanced] [I] Living Room Apple TV ((removed for privacy)): Exposing Apple TV as accessory of type set-top box.
[4/14/2024, 9:42:23 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Finished initializing
[4/14/2024, 9:42:23 PM] Apple TV Living Room Apple TV 5AB7 is running on port 63767.
[4/14/2024, 9:42:23 PM] Please add [Apple TV Living Room Apple TV 5AB7] manually in Home app. Setup Code: 654-08-494
[4/14/2024, 9:42:24 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Active State: on
[4/14/2024, 9:42:24 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Media Type State: video
[4/14/2024, 9:42:24 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Current App: com.hulu.plus
[4/14/2024, 9:42:24 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing
[4/14/2024, 9:42:34 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:43:47 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Media Type State: unknown
[4/14/2024, 9:43:47 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Current App: com.apple.TVMusic
[4/14/2024, 9:43:47 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: idle
[4/14/2024, 9:44:00 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): Current App: com.wbd.stream
[4/14/2024, 9:44:00 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: paused
[4/14/2024, 9:44:05 PM] [Apple TV Enhanced] [I] Apple TV Enhanced ((removed for privacy)): New Device State: playing

Configuration
"name": "Apple TV Enhanced",
    "mediaTypes": [
        "music",
        "tv",
        "unknown",
        "video"
    ],
    "deviceStates": [
        "paused",
        "playing"
    ],
    "deviceStateDelay": 0,
    "avadaKedavraAppAmount": 15,
    "disableVolumeControlRemote": false,
    "setTopBox": true,
    "discover": {
        "multicast": false,
        "unicast": [
            "<IP_ADDRESS> (removed for privacy)"
        ]
    },
    "forceVenvRecreate": false,
    "logLevel": 3,
    "updateCheckLevel": "stable",
    "deviceSpecificOverrides": [
        {
            "overrideMediaTypes": false,
            "overrideDeviceStates": false,
            "overrideDeviceStateDelay": false,
            "deviceStateDelay": 0,
            "overrideRemoteKeysAsSwitch": false,
            "overrideAvadaKedavraAppAmount": false,
            "avadaKedavraAppAmount": 15,
            "overrideCustomInputURIs": false,
            "overrideDisableVolumeControlRemote": false,
            "disableVolumeControlRemote": false,
            "overrideSetTopBox": false,
            "setTopBox": false
        }
    ],
    "_bridge": {
        "username": "(removed for privacy)",
        "port": (removed for privacy)
    },
    "platform": "AppleTVEnhanced"
}

Operating System
Mac Os
Operating System: Bits
64-bit
Operating System: Distribution
N/A
Operating System: Distribution Version
N/A
Docker
no
Docker Image
None
Docker Image Tag
No response
Homebridge Version
1.7.0
Homebridge Config UI Version
v4.56.1
Homebridge Storage Path
/Users/caleb/.homebridge
Homebridge Apple TV Enhanced Version
v1.3.1
Node Version
20.9.0
NPM Version
10.1.0
Python Version
3.11.9
PIP Version
24.0.0
HDMI Hops
No response
Audio Output
no
Same Subnet
yes
Additional Context
No response

That's an issue of the HBO Max app, not the plugin.


GL line width + pixel ratio woes

This is the new home of the GL line width sub-issue in https://github.com/AnalyticalGraphicsInc/cesium/issues/8113
There are two problems with using GL lines with varying resolution scale:

Some vendors don't support line widths greater than 1, which results in very thin lines at high pixel densities:

Width 1 at low resolution scale

Width 1 at high resolution scale

RenderState doesn't have access to FrameState which has the pixelRatio value. So even if we wanted to multiply the line width with pixel ratio, it would require a refactor.

My thinking is we shouldn't be using GL lines for anything, mainly because of the first problem, and should instead use polylines. Chances are this issue will stay on the back-burner for a while since this is low-impact problem, but glad to hear other's thoughts.

There's been some discussion here https://github.com/AnalyticalGraphicsInc/cesium/issues/6694 on switching polygon outlines to polylines for both the line thickness and ability to clamp it to terrain.

My thinking is we shouldn't be using GL lines for anything, ... and should instead use polylines.

👍

Hey @OmarShehata  @emackey , can this get a priority assigned? I just started working with some data from a system that replicates a lot of Cesium's drawing primitives but their backing engine handles shapes with both stroke and fill as you'd expect, so there's an obvious difference when drawing the same thing on their system vs mine.  I added a separate polyline when it's a basic polygon, but there's going to be more work involved for circles, ellipses, corridors (especially those), etc.  It would be great if Cesium handled the heavy lifting here.

It would be great to see too, this but I'm not sure when exactly we'll be able to get to it.

I just noticed another place where this is a problem -- when you load GeoJSON (with GeoJsonDataSource), it takes a strokeWidth option, but it doesn't actually work when the feature is a polygon.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/security-guard-approvers
/assign knative/security-guard-approvers
Produced by: knative-sandbox/knobots/actions/update-deps

/approve
/lgtm


To upgrade from .NET Core 3.1 to 6.0 (LTS)

Since .Net Core 3.1 is retired, shall we consider upgrading tstypegen to .NET Core 6.0 (LTS) ?

@avensia-oss/tstypegen 3.0.0  has dotnet 6


Integrating Sync Cache with Goland's Shared Indexes

Description of the feature request:
Storing the sync results into Goland's shared indexes to enable sharing with other machines.
What underlying problem are you trying to solve with this feature?
Not requiring to do a Bazel sync on earch machine.
What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.
All. For now we are only interested in Go.
Have you found anything relevant by searching the web?
https://bazel.build/remote/caching and https://www.jetbrains.com/help/go/indexing.html
Any other information, logs, or outputs that you want to share?
No response

While this is a useful feature we'd love to have, we don't have the bandwidth to implement it right now. We're open to PRs, and I'm happy to provide guidance/reviews if I can.

So I have officially started working on such feature. I'm considering disabling it by default and implementing it incrementally. The method I'm considering is imitating the STARTUP sync type, copying the files from a remote repo and just running a STARTUP sync.
I know that we need to make that the cache is in sync with the local files etc... but let's take it one step at a time.

After thinking thoroughly about it and especially the case of loading a part of a mono-repo, I'll do this first and I think I know what I need to do it.

1- Add a method that creates a compressed file containing all the intellij-info files. This is to be used by CI/CD tools mainly to populate a central repo.
2- Upon synchronization, the plugin should first parse the targets and then try to get their intellij-info files from the remote cache. If they do exist, then we can run a NO_BUILD sync which creates the project's proto cache.
3- Versioning of cached intellij-info files need to be considered.
4- I'm also considering using the native IntelliJ Shared Indexing

What about version management? How can we be sure that we are pulling the correct version?

If using the Bazel remote cache, the ide-info files generated by the aspect will be cached based on the hashes of the input files. So, if a version changes (either on a third party dependency, on the IDE, or in your source code), the cache key of the ide-info will change, so invalidation is transparent.
I agree with @tpasternak that using Bazel's remote cache is "free" and correct if you already have it set up.


Fix BasePipeline.forecast when prediction intervals are estimated on history data with presence of NaNs

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes
Look #899.
Closing issues
Closes #899.

Codecov Report

Merging #1291 (a5ee7d8) into master (f4509bb) will increase coverage by 0.33%.
The diff coverage is 92.59%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   87.74%   88.08%   +0.33%
==========================================
  Files         187      187
  Lines       10859    10883      +24
==========================================
+ Hits         9528     9586      +58
+ Misses       1331     1297      -34

Impacted Files
Coverage Δ

etna/pipeline/base.py
95.62% <92.59%> (-0.28%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


User should see previous Explore view when returning to Explore screen

Describe the bug
Right now, the Explore view isn't sticky, which means if a user changes the Explore filters, navigates away from the Explore screen, and then navigates back to Explore, they will see their previous filters without their previous view.
To Reproduce
Steps to reproduce the behavior:

Go to Explore via the bottom tab bar
Search for Hong Kong as a filtered location
Switch to Observers view instead of the default Species view
Tap MyObservations on bottom tab bar
Tap back to Explore
See that the Explore screen still displays Hong Kong, your filtered search, but the view is back to Species View

Expected behavior
We should show users the entirety of the previous Explore screen, including their previous Explore view, rather than picking and choosing which parts to preserve.

@abhasinat can you sign off on this? I feel like you and I disagree about how this should work so I just want to be clear about what you want.


fix(api): Make advanced funcs work with WellSeries

overview
During testing by @nusrat813 and myself, we realized that advanced functions could not handle multi-well transfers (kinda the whole point). This is because the new WellSeries class was not properly handling when to return a WellSeries. Aside from accessing a single well, the LegacyLabware class should always return a WellSeries. This PR addresses that, along with other issues found along the way.
changelog

Fix advanced function tests (they were not using specified instruments, so multichannels were never being tested)
Fix WellSeries handling for multichannel
Create nested WellSeries for any rows or columns calls
Add a bunch of weird functions that you were somehow able to do with WellSeries
Check in commands.py for new wellseries and handle it

review requests
Test with this protocol:
from opentrons import labware, instruments, robot

tiprack1 = labware.load('opentrons-tiprack-300ul', '1')
tiprack2 = labware.load('opentrons-tiprack-300ul', '4')

trough = labware.load('usascientific_12_reservoir_22ml','2')
plate = labware.load('corning_96_wellplate_360ul_flat', '3')

pip = instruments.P300_Single(mount='right', tip_racks=[tiprack1])
pip_multi = instruments.P300_Multi('left',tip_racks=[tiprack2])

#Well Behavior

# wells = [well for well in plate.wells()]
pip.transfer(50, trough.wells('A1'), plate.wells())
pip.transfer(50, trough.wells('A1'), plate.wells(1))
pip.transfer(50, trough.wells('A1'), plate.wells('A1'))
pip.transfer(50, trough.wells('A1'), plate.wells(['A1', 3, 'A3']))
#pip.transfer(50, trough.wells('A1'), plate.wells(1, length=3, step=6))
pip.transfer(50, trough.wells('A1'), plate.wells(1, length=3, step=-4))
pip.transfer(50, trough.wells('A1'), plate.wells(1, length=-3))
pip.transfer(50, trough.wells('A1'), plate.wells(x=0, y=1))
pip.transfer(50, trough.wells('A1'), plate.wells(x=-2))
pip.transfer(50, trough.wells('A1'), plate.wells(0, x=1))
pip.transfer(50, trough.wells('A1'), plate.wells([0,3], x=1))
pip.transfer(50, trough.wells('A1'), plate.wells([0, 1], length=2, step=2))
pip.transfer(50, trough.wells('A1'), plate.wells([0, 1], 3))
pip.transfer(50, trough.wells('A1'), plate[0])
pip.transfer(50, trough.wells('A1'), plate['A1'])
pip.transfer(50, trough.wells('A1'), plate.well(0))
pip.transfer(50, trough.wells('A1'), plate.well('A1'))

#Row Behavior
pip.transfer(50, trough.wells('A1'), plate.rows())
pip.transfer(50, trough.wells('A1'), plate.rows)
pip.transfer(50, trough.wells('A1'), plate.rows(1))
pip.transfer(50, trough.wells('A1'), plate.rows('B'))
pip.transfer(50, trough.wells('A1'), plate.rows()[1])
pip.transfer(50, trough.wells('A1'), plate.rows['B'].wells(0, length=2))
pip.transfer(50, trough.wells('A1'), plate.rows(1).wells(0, length=2))

#Column Behavior
pip.transfer(50, trough.wells('A1'), plate.cols())
pip.transfer(50, trough.wells('A1'), plate.columns())
pip.transfer(50, trough.wells('A1'), plate.cols)
pip.transfer(50, trough.wells('A1'), plate.columns)
pip.transfer(50, trough.wells('A1'), plate.cols(1))
pip.transfer(50, trough.wells('A1'), plate.cols('2'))
pip.transfer(50, trough.wells('A1'), plate.cols()[1])
pip.transfer(50, trough.wells('A1'), plate.cols()['2'])
pip.transfer(50, trough.wells('A1'), plate.cols[1])
pip.transfer(50, trough.wells('A1'), plate.cols['2'])
pip.transfer(50, trough.wells('A1'), plate.cols[1].wells(0, length=2))
pip.transfer(50, trough.wells('A1'), plate.cols('2').wells(0, length=2))

pip_multi.transfer(50, trough.wells('A1'), plate.cols())
pip_multi.transfer(50, trough.wells('A1'), plate.columns())
pip_multi.transfer(50, trough.wells('A1'), plate.cols)
pip_multi.transfer(50, trough.wells('A1'), plate.columns)
pip_multi.transfer(50, trough.wells('A1'), plate.cols(1))
pip_multi.transfer(50, trough.wells('A1'), plate.cols('2'))
pip_multi.transfer(50, trough.wells('A1'), plate.cols()[1])
pip_multi.transfer(50, trough.wells('A1'), plate.cols()['2'])
pip_multi.transfer(50, trough.wells('A1'), plate.cols[1])
pip_multi.transfer(50, trough.wells('A1'), plate.cols['2'])
pip_multi.transfer(50, trough.wells('A1'), plate.cols[1].wells(0, length=2))
pip_multi.transfer(50, trough.wells('A1'), plate.cols('2').wells(0, length=2))

No longer doing backcompat in this way. Closing the PR as it's not relevant anymore.


Launching serverless-offline fails with<EMAIL_ADDRESS>

This is a Bug Report
Description
Using config based on the example, after upgrading to<EMAIL_ADDRESS>serverless-offline fails to start with the following error:
Serverless Error ---------------------------------------

  No matching handler found for 'handler'. Check your service definition.

The same config works fine with<EMAIL_ADDRESS>Minimal(ish) repro: https://github.com/haines/serverless-webpack-issue
Additional Data

Serverless-Webpack Version you're using: 2.2.0
Webpack version you're using: 3.4.1
Serverless Framework Version you're using: 1.18.0
Operating System: Mac OS X 10.12.5
Stack Trace (if available): N/A

I fixed the example. The handler definition must include the path so that the Serverless framework and the plugin knows the location of the handler.
functions:
  first:
    handler: src/handler.hello

I will check the other examples too.

It is important that the handler points to the correct directory. Other plugins also might need the location and will fail if you do not set it - this is the same behavior as with Serverless without the plugin.

Thanks for the quick response! I've updated the config as suggested, and it starts up ok, but now I get an error when I hit the endpoint:
Serverless: Error while loading hello
[ 'Error: Cannot find module \'/Users/haines/work/serverless-webpack-issue/.webpack/src/handler\'',
  'at Function.Module._resolveFilename (module.js:469:15)',
  'at Function.Module._load (module.js:417:25)',
  'at Module.require (module.js:497:17)',
  'at require (internal/module.js:20:19)',
  'at Object.createHandler (/Users/haines/work/serverless-webpack-issue/node_modules/serverless-offline/src/functionHelper.js:35:21)',
  'at handler (/Users/haines/work/serverless-webpack-issue/node_modules/serverless-offline/src/index.js:480:40)',

you have to use --location .webpack with the offline plugin.

This is how we invoke offline in our projects:
node ./node_modules/serverless/bin/serverless offline --location .webpack --noTimeout --dontPrintOutput

I took it out because it seems to make things worse, with --location .webpack the error is
Cannot find module  '/Users/haines/work/serverless-webpack-issue/.webpack/.webpack/src/handler'

note the .webpack/.webpack/src. Without --location it tries to load .webpack/src/handler. I'm assuming it should be loading .webpack/handler?

can you try the lib.entries variant I mentioned above, or use "src/handler.js" as filename?

Nice, it's working with lib.entries, which has made it bundle to .webpack/src/handler.js instead of .webpack/handler.js, and it loads correctly.
Adding --location .webpack still causes it to fail trying to load .webpack/.webpack. Omitting --location works though, so we'll roll with that!
Thanks for your help.

👍

@HyperBrain I'm bitten by this bug too and I followed your advice to use entry: slsw.lib.entries, but I get this error when running Webpack:
$ node_modules/.bin/webpack
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.entry should be one of these:
   object { <key>: non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function
   The entry point(s) of the compilation.
   Details:
    * configuration.entry should NOT have less than 1 properties ({
        "keyword": "minProperties",
        "dataPath": ".entry",
        "schemaPath": "#/oneOf/0/minProperties",
        "params": {
          "limit": 1
        },
        "message": "should NOT have less than 1 properties",
        "schema": 1,
        "parentSchema": {
          "minProperties": 1,
          "additionalProperties": {
            "oneOf": [
              {
                "description": "The string is resolved to a module which is loaded upon startup.",
                "minLength": 1,
                "type": "string"
              },
              {
                "description": "All modules are loaded upon startup. The last one is exported.",
                "$ref": "#/definitions/common.nonEmptyArrayOfUniqueStringValues"
              }
            ]
          },
          "description": "Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.",
          "type": "object"
        },
        "data": {}
      }).
      object { <key>: non-empty string | [non-empty string] }
      Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.
    * configuration.entry should be a string.
    * configuration.entry should be an array:
      [non-empty string]
    * configuration.entry should be an instance of function
      function returning an entry object or a promise..

This is my webpack.config.js:
const path = require('path');
const webpack = require('webpack');
const slsw = require('serverless-webpack');

const config = {
  entry: slsw.lib.entries,
  target: 'node', // Ignores built-in modules like path, fs, etc.

  output: {
    libraryTarget: 'commonjs',
    path: path.resolve(`${__dirname}/.webpack`),
    filename: '[name].js',
  },

  module: {
    rules: [{
        test: /\.elm$/,
        exclude: [/elm-stuff/, /node_modules/],
        use: {
          loader: 'elm-webpack-loader',
          options: {}
        }
      }],
  },
};

module.exports = config;

Any idea?

@ringods Hi. Thanks for asking 👍 . Can you additionally post the function definition from your serverless.yml? The error (webpack config error) points somehow to a handler resolution problem.
What you can do too, is a console.log(slsw.lib.entries) in the config, so that we see what is put in there by the plugin. Please let me know of this information.
FYI: I never used the elm-loader (and do not know anyone who uses it ;-) ). But normally it should work with any available webpack loader.

@ringods Oh, I just saw that you invoked webpack directly from the commandline. Then the serverless-webpack context will not be set -> that should be the reason for the failure. Using the lib extensions of the plugin needs to have webpack invoked by the Serverless framework.
Can you try to invoke the webpack build with serverless package or serverless webpack?

serverless.yml:
service: integrations

provider:
  name: aws
  runtime: nodejs6.10

plugins:
  - serverless-webpack
  - serverless-offline

custom:
  serverless-offline:
    location: .webpack
    dontPrintOutput: true

functions:
  hello:
    handler: .webpack/hello.handler # Refers to function `handler` exported from `Hello/api.js`
    events:
      - http:
          integration: lambda-proxy
          path: /
          method: ANY

All of serverless and plugins are devDependencies. I added this npm script:
"package": "serverless package"
Here is the output:
$ SLS_DEBUG=* npm run package

><EMAIL_ADDRESS>package /Users/ringods/Projects/releasequeue/rq-business-integrations
> serverless package

Serverless: WARNING: Plugin ServerlessWebpack uses deprecated hook before:deploy:createDeploymentArtifacts
Serverless: WARNING: Plugin ServerlessWebpack uses deprecated hook after:deploy:createDeploymentArtifacts
Serverless: Bundling with Webpack...
Time: 33ms

ERROR in Entry module not found: Error: Can't resolve './.webpack/hello.js' in '/Users/ringods/Projects/releasequeue/rq-business-integrations'

  Error --------------------------------------------------

  Webpack compilation error, see above

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Stack Trace --------------------------------------------

Error: Webpack compilation error, see above
    at BbPromise.fromCallback.then.stats (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless-webpack/lib/compile.js:24:17)
    at emitRecords.err (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:269:13)
    at Compiler.emitRecords (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:375:38)
    at emitAssets.err (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:262:10)
    at applyPluginsAsyncSeries1.err (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:368:12)
    at next (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/tapable/lib/Tapable.js:218:11)
    at Compiler.compiler.plugin (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:99:4)
    at Compiler.applyPluginsAsyncSeries1 (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/tapable/lib/Tapable.js:222:13)
    at Compiler.afterEmit (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:365:9)
    at require.forEach.err (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:354:15)
    at /Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/node_modules/async/dist/async.js:421:16
    at eachOfArrayLike (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/node_modules/async/dist/async.js:991:9)
    at eachOf (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/node_modules/async/dist/async.js:1051:5)
    at Object.eachLimit (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/node_modules/async/dist/async.js:3145:5)
    at emitFiles (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/webpack/lib/Compiler.js:319:21)
    at /Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/mkdirp/index.js:30:20
    at FSReqWrap.oncomplete (fs.js:135:15)
From previous event:
    at ServerlessWebpack.compile (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless-webpack/lib/compile.js:14:8)
From previous event:
    at Object.before:deploy:createDeploymentArtifacts [as hook] (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless-webpack/index.js:113:10)
    at BbPromise.reduce (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/lib/classes/PluginManager.js:236:55)
From previous event:
    at PluginManager.invoke (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/lib/classes/PluginManager.js:236:22)
    at PluginManager.run (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/lib/classes/PluginManager.js:255:17)
    at variables.populateService.then (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/lib/Serverless.js:99:33)
    at runCallback (timers.js:800:20)
    at tryOnImmediate (timers.js:762:5)
    at processImmediate [as _immediateCallback] (timers.js:733:5)
From previous event:
    at Serverless.run (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/lib/Serverless.js:86:74)
    at serverless.init.then (/Users/ringods/Projects/releasequeue/rq-business-integrations/node_modules/serverless/bin/serverless:39:50)
    at <anonymous>

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Forums:        forum.serverless.com
     Chat:          gitter.im/serverless/serverless

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           8.1.2
     Serverless Version:     1.19.0

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>package: `serverless package`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>package script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/ringods/.npm/cache/_logs/2017-08-15T21_27_18_254Z-debug.log

Looking at your serverless.yml, the handler definition is the issue. It should point to the handler js file, not into the webpack directory. This should be done for all functions. It is important, that Serverless knows the location of the handlers.
Sample:
functions:
  forms:
    handler: src/Forms/api.handler     <-- HERE!

The handler must reference the export in the actual handler file, not the compiled one. If you change these accordingly it should work.
BTW: You can use ^3.0.0-rc.1 as serverless-webpack version. Then you can try the V3 already ;-)
I will check with your test project later today, but you already can try my suggestion.

@ringods If it works with the corrections, would you mind that I put your example project into the official serverless-webpack examples? It would be a great addition to have an elm-loader example there 🙌

@ringods I did a PR to the repo (https://github.com/ktonon/elm-serverless-demo/pull/2) which makes it work. It is your decision to keep sls-webpack v3 in or use 2.2.0. Both should work.


add support for BackstopJS report UI

This adds support for the BackstopJS report UI. There's a new method called BackstopJS which extends LocalCompare. When tests run the tests results are recorded in a config file for BackstopJS and the report UI opens at the end of the test run.
Happy to help if there are any questions with this since it's a rather large change.

Sorry for the force push... I saw an npm issue and it looks like my local was out of sync before I opened the PR. Should be set now.

I was running node 8 so I guess if the open package doesn't support node 6 I should be able to swap that out for a similar package.


Unlisted device addendum support

This PR adds an undocumented feature to add devices directly to the browser list.

:+1:


update pom.xml

@wu-sheng Thanks for you quick comment. I have added apache-rat as the release audit tool.

What is release audit tool? Do you plan to provide something besides the documents and commands?

Oh, you mean here, in this PR. You need to set exclusion rules for this.

What is release audit tool?
I didn't know Rat until you told me. So I turned to Apache Rat main page and found:
What Is Rat?

Do you plan to provide something besides the documents and commands?

Yes. You add the right rat plugin. But it would fail, please run locally, and find out what it says. You could take skywalking pom.xml as an example, we have it too.

Hi @wu-sheng, I have responded your comments in 3f31012ee17c97cd4e0ee99350e2583c761ad45d. Any more comments?

Pull Request Test Coverage Report for Build 7083

0 of 0   changed or added relevant lines in 0 files are covered.
249 unchanged lines in 19 files lost coverage.
Overall coverage increased (+0.6%) to 71.252%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/optimizer/engine/sharding/query/QueryOptimizeEngine.java
1
95.74%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/parsing/parser/sql/dml/insert/AbstractInsertParser.java
1
90.91%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/optimizer/engine/encrypt/EncryptDefaultOptimizeEngine.java
1
0.0%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/parsing/parser/sql/dml/insert/InsertStatement.java
2
75.0%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/parsing/parser/clause/InsertValuesClauseParser.java
2
96.3%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java
3
87.74%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/parsing/antlr/extractor/impl/PredicateExtractor.java
4
89.91%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/optimizer/OptimizeEngineFactory.java
4
37.5%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/parsing/parser/clause/InsertSetClauseParser.java
6
20.0%

sharding-core/sharding-core-rest/src/main/java/org/apache/shardingsphere/core/routing/router/sharding/ParsingSQLRouter.java
9
85.19%

Totals

Change from base Build 7062:
0.6%

Covered Lines:
11188

Relevant Lines:
15702

💛  - Coveralls


Consider dropping ControlPlane with purpose=exposure logic

How to categorize this issue?

/kind cleanup
What would you like to be added:
According to https://github.com/gardener/gardener/blob/636b955d347fc95d56490a9d89bf5ae507af8a4e/docs/extensions/controlplane-exposure.md#L19, ControlPlane with purpose exposure is NOT deployed when SNI is enabled.
SNI is enabled unconditionally since longtime. This suggests that the extensibility concept ControlPlane with purpose.exposure is not needed anymore and can be removed.
Why is this needed:
Drop potentially dead code after SNI is enabled unconditionally.

/assign Kostov6

/good-first-issue

/remove-good-first-issue

/remove-lifecycle stale


.SetFloat64() has incorrect results.

Again, forgive me if I've overlooked something
f := 8e+19
b := new(decimal.Big)
b.Context.Precision = 9999
b = b.SetFloat64(f)
fmt.Println(b.String())

>>><PHONE_NUMBER>161793536

Nah, that's right. It's fine if I remove the
if s := uint(-shift); s < 64 { ... }
branch and just use big.Int. ¯\_(ツ)_/¯


Some updates, clean-up, etc.

This change no longer unwraps the Circe or Argonaut results.

Codecov Report

Merging #65 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage    99.1%   99.06%   -0.05%
==========================================
  Files           7        7
  Lines         112      107       -5
==========================================
- Hits          111      106       -5
  Misses          1        1

Impacted Files
Coverage Δ

src/main/scala/io/circe/benchmarks/Foo.scala
100% <ø> (ø)
:arrow_up:

src/main/scala/io/circe/benchmarks/Benchmark.scala
100% <ø> (ø)
:arrow_up:

...n/scala/io/circe/benchmarks/CirceDefinitions.scala
100% <100%> (ø)
:arrow_up:

.../scala/io/circe/benchmarks/Json4sDefinitions.scala
100% <100%> (ø)
:arrow_up:

...in/scala/io/circe/benchmarks/PlayDefinitions.scala
100% <100%> (ø)
:arrow_up:

...cala/io/circe/benchmarks/ArgonautDefinitions.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05d141...234e843. Read the comment docs.