MovieContext -> RazorPagesMovieContext

This tutorial should be corrected in section "Use SQLite for development, SQL Server for production":
The context should be corrected to "RazorPagesMovieContext" from "MovieContext" - this change is necessary to properly build at this step, and is not necessarily intuitive to new new developers or those new to dotnetcore.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Yep, I'm having trouble understanding what is that for. New to web apps.

I agree. I was not able to run "dotnet build" until I changed "Movie Context" to "RazorPagesMovieContext" This was very unclear.I appreciate the comment by thx1766 to help out

Had the same issue and was unable to build until I tried your solution. Thanks.

I agree. I was not able to run "dotnet build" until I changed "Movie Context" to "RazorPagesMovieContext" This was very unclear.I appreciate the comment by thx1766 to help out

Do you mean
// Startup.cs

      public void ConfigureServices(IServiceCollection services)
      {
         services.AddRazorPages();

-        services.AddDbContext<MovieContext>(options =>
+        services.AddDbContext<RazorPagesMovieContext>(options =>
            options.UseSqlite(
                Configuration.GetConnectionString("MovieContext")));

      }


Merge pull request #65 from MaedaSunthorn/Maeda

T์heNoblequran

the last file can't be run by php artisan serve
symfony\polyfill-intl-normalizer\bootstrap.php on line 15
i got this massege

the last file is not working
symfony\polyfill-intl-normalizer\bootstrap.php on line 15
is can't running by php artisan serve

how can i change the files


Overlapping with SVG z-index issues

I am using select2 + charts done via SVG with dynamic tooltips. The tooltip is contained in a SVG rect, and sometimes overlaps the select2 element.
When this happens, the select2 box is on top of the tooltip. SVG elements can't be assigned z-index (Z index in SVG is defined by the order the elements appear in the document).
Is there a way to have the tooltip on top of the select2 element? (w/o select2, the tooltip is correctly displayed on top the the HTML select element).

Closing this off because of the lack of activity. If this is not fixed in 4.0, and you are interested in seeing it fixed, add a :+1: to the ticket to bring it to our attention.
If you can add additional details, that would also be useful.


add support for definition lists (=defn)

I think that the Perl 6 glossary would look better if the IRC Lingo entries were a single definition list, but it appears that Pod-To-HTML doesn't support definition lists yet.

This seems to be a rakudo pod issue.

This should have been fixed by @tbrowder in one of the next Rakudo releases.

In principle, closed by 326838cd26be12f863ecc1504624f10da76f4857


Task remove obsolete content

Description
Removing obsolete files and content from AB3.

Codecov Report

Merging #218 (e9415d6) into master (5e9a101) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #218   +/-   ##
=========================================
  Coverage     72.30%   72.30%
  Complexity      580      580
=========================================
  Files            94       94
  Lines          1903     1903
  Branches        205      205
=========================================
  Hits           1376     1376
  Misses          449      449
  Partials         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9a101...e9415d6. Read the comment docs.


Office 365 links are opening in its own chrome window

When opening links in Office 365, the links do not open as a new tab in one of the open browsers (e.g. chrome for me, version 63.0.3239.108)
Expected Behavior
Links open in a new tab of a already open browser window.
Current Behavior
Links open in its own chrome window.
Your Environment

Franz Version used: 5.0.0-beta14
Operating System and version: Ubuntu 16.04

Possible duplicate of https://github.com/meetfranz/franz/issues/381, https://github.com/meetfranz/franz/issues/244, and https://github.com/adambirds/recipe-office365-owa/issues/7?

Yup I think so. Thank ya.


tunnel

hi guys,
on my iMac the map works great.
i install the ipokego app, start a tunnel on forwardhq.com and use the link, but i don't see any pokemon.
can someone help me? tnx

Can you view the server in your browser?

I close the issue, please open an another issue if you still have this problem.


drivers: cmake: fixes some No SOURCES given to Zephyr library: warnings

This fixes some of the No SOURCES given to Zephyr library: warnings after merging #37512. This is caused by zephyr_library() call without any source files being included in the library.
Note that some of the warnings are caused by enabling a driver type but none of the drivers, for example, CONFIG_PINMUX=y but no pinmux drivers enabled. This is simply configuration errors.

The solution from #31068 could be reused there actually, just add the empty file to the sources.

The solution from #31068 could be reused there actually, just add the empty file to the sources.

That doesn't seem like a solution we really should be going with.  We should either decided to remove the warning or fix up Kconfig's.

@dcpleung we still have this issue regarding net and ethernet drivers on esp32 build:
  No SOURCES given to Zephyr library: drivers__net

  Excluding target from build.

CMake Warning at ../../../../CMakeLists.txt:718 (message):
  No SOURCES given to Zephyr library: drivers__ethernet

  Excluding target from build.

Is there anything we can do on esp side or it needs a new PR following this one?

This is probably caused by having CONFIG_ETHERNETand CONFIG_NET_L2_ETHERNET enabled but none of the drivers. Disable these and the warning should go away (given that you don't need ethernet and net drivers).

This is probably caused by having CONFIG_ETHERNETand CONFIG_NET_L2_ETHERNET enabled but none of the drivers. Disable these and the warning should go away (given that you don't need ethernet and net drivers).

Hi, ESP32 requires those configs to enable L2 layer. Considering it does not use the available drivers, any recommendation?

Hm... can try adding something like this https://github.com/zephyrproject-rtos/zephyr/blob/698a28663cb364b0601eabd48c73a206fe1f715c/drivers/serial/CMakeLists.txt#L43 just for ESP32? Not really recommended though.


Update tutorials/libraries.md for MSBuild/csproj

Developing Libraries with Cross Platform Tools

https://docs.microsoft.com/en-us/dotnet/articles/core/tutorials/libraries
https://github.com/dotnet/docs/blob/master/docs/core/tutorials/libraries.md

xref https://github.com/dotnet/docs/issues/1574

@cartermp @terrajobst hey guys, wondering if any of you would have some bandwidth to update this guidance this month?
We should also move that .NET Standard table to an include file so that we only have to update one place when updating that table since the same info is also found at https://docs.microsoft.com/en-us/dotnet/articles/standard/library.

I should be able to dedicate some time to this, yes.

Assigning to you then @cartermp. #1693 is also related to this topic. Thanks!

FYI, I'm midway through this.  Lots of fundamental changes have to be made to this article, unfortunately.  It's coming along.


[Vue warn]: Computed property was assigned to but it has no setter.

For some reason, I get the following error when using mapMultiRowFields:
vue.runtime.esm.js?2b0e:619 [Vue warn]: Computed property "entries" was assigned to but it has no setter.

Anything wrong with the following syntax?
<MilestonesList v-model="entries" :months="months" />

import { mapFields, mapMultiRowFields } from 'vuex-map-fields'

export default {
    computed: {
        ...mapMultiRowFields({
           entries: 'updated.brand.general_info.milestones.entries'
        })
    }
})

Same result for:
export default {
    computed: {
        ...mapMultiRowFields(['updated.brand.general_info.milestones.entries'])
    }
})

This workaround leads to an error in `MilestonesList`:

computed: {
entries: {
get() {
return this.$store.state.updated.brand.general_info.milestones.entries
},
set(value) {
this.$store.commit('updateField', {
path: 'updated.brand.general_info.milestones.entries',
value: value
})
}
}
}

You can't use v-model on entries. When you want to use mapMultiRowFields() You must iterate over entries and use v-model on each entry.
See: https://github.com/maoberlehner/vuex-map-fields#component-5

Hi @maoberlehner, I came across the same issue while trying to use mapMultiRowFields on a Vuetify.js  v-autocomplete with chips. Do you have any suggestion for that case? Thank you, the library is super useful.


Fix Yoga podspec casing

Fix incorrect filename case
Test plan:
Run scripts/process-podspecs.sh

@javache I just want to double check about this. I think we'll need to do this as two separate commits. Changing the casing of a file is tricky with git. In one commit, you completely change the name of the file (i.e. change more than just the casing). In the second commit, you rename the file to the final name you want.

It seems to have landed correctly, could you try pulling and verifying you have the commit with the right case?

@javache, @alloy This change looks good to me. I thought more about my past experiences. Here are the problems I've run into with changing the casing of a file in git but it looks like you've avoided them:

Somebody tries to rename a file but ends up checking in two files: one with the old casing and one with the new casing.
Somebody tries to change and rename a file on a case insensitive file system. Git doesn't notice that the file has been renamed so the file has the old casing after the commit. To force git to notice the rename, you have to do git mv <old-casing> <new-casing>.

I didn't understand the problems well enough until now to realize they could be avoided in a single commit.


document and smooth the CA experience

related is #52 (for adjusting / decreasing the resources for a specific person)
@TheLortex tried to use the remote-tls endpoint and the albatross-client-remote-tls. Noteworthy things:

albatross-provision-ca sign of an intermediary (sub)CA is allowed even if there are no CPU -- which is slightly useless
it could as well check there to be at least one VM

Also, the albatross-client-remote-tls takes in a (client) certificate and the CA certificate -- but it expects an entire client CA chain and could locally verify that it's a good certificate before connecting to the remote (and transferring the entire unikernel). The "CA sign" could output a bundle instead of a single certifcate (though it may not know the entire chain... if there's more than one level of delegation involved).

addressed in the mentioned PRs.


Side menu transition build failed

Issue Checklist
I have read the guidelines for contributing and I understand:

[ ] My issue is happening in the latest version of SideMenu.
[x] My issue was not solved in the README.
[x] My issue can not be answered on stackoverflow.com.
[x] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[ ] My issue is reproducible in the demo project.

Issue Description
I am trying to build a project on Xcode 7.3.1 using the pod version 1.2.1 because my project has SWIFT_VERSION 2.3.
The build failed showing the following errors:

I hope you can help me, thanks!

@mjurfest Sorry, but I'm only supporting the latest version of SideMenu. You'll have to fix the SideMenu code as suggested by Xcode -- shouldn't be hard.


Better reporting of certificate parsing issues

Summary
Currently, if there is an error in certificate parsing either in the facter or the HFT host manufacturing within the module, the errors are silently eaten and create unhelpful message(s) later down the line when the connection fails. Given that in most cases a problem will result in no certs parsed, we can error out early but we don't.
Dev info:

Facter cert management
Client cert management

Steps to Reproduce
Steps to reproduce the behavior:

Setup puppet w/ self-signed CA cert
2 Setup clean Windows host ready (don't run agent yet)
Setup conjur HFTs
Configure all relevant Conjur facts but use a bad ssl_certificate param
Run the agent on the node

Expected Results
Well formed and descriptive errors that there's a problem parsing the certificate(s)
Actual Results (including error logs, if applicable)
Error about "certificate verification failure"
Reproducible

[x] Always
[ ] Sometimes
[ ] Non-Reproducible

Version/Tag number
Tested on Puppet 6 and pre-3.0.0 version but this error would be visible on puppet 5 and any older version as well probably.
Environment setup
Puppet Master: Docker-compose, v6
Puppet Agent: Windows 2012r2 VM in VirtualBox
Conjur Master: Docker-compose, v5
Additional Information
N/A

Released with v3.0.0rc3. Closing.


Implement FileUploadField with usage examples in product form

Examples in ProductForm:

priceList: A single file to be uploaded, the FileUpload ID is stored  in the Products entity directly
datasheets: Multiple files, the FileUpload IDs are stored in a relation table (Product_datasheets)

PR Checklist

[x] Verify if the change requires a changeset. See CONTRIBUTING.md
[x] Link to the respective task if one exists: COM-858

It would be useful to see this endpoints actually in use... Could you implement the public uploads field in this PR as well?

What are the public uploads used for?

Uploads, that should not be in the DAM
Unauthenticated users submitting a form with attachments
(this should be in the docs)

For both use cases the API does not need to be public as we either have a user or a BFF

@jamesricky could you please rebase this PR? Thanks!

Can we target main for this?


can't input in internal shell

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

in windows os, use remote connection to another windows pc with vscode
use vscode to connect another remote pc with arch linux kernal 5.10.160-1
close the windows remote window, do nothing
open the pc with vscode (OS windows)
can't input anything at this vscode open window shell

Please provide a screenshot or a gif illustrating the problem (attaching images won't work via email, you need to go to github.com). See this wiki page for more general info on how to report actionable terminal issues.
/label "info-needed"

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


fix emit "pending" when running pending test

Closes #1706.
Runnable.run(fn) wasn't passing an instance of Pending to the
callback when a pending test was ran. Therefore, Runner was not
firing a "pending" event.
Added a test which currently fails due to the skippedTest:
[TypeError: Object #<Object> has no method 'skip']. How does
one skip the current running test synchronously?
Also: why are we throwing a Pending instance? Couldn't we set pending = true in .skip(), and then check test.pending again at https://github.com/mochajs/mocha/blob/master/lib/runner.js#L475 ?

I forgot there was work pending on this one. Adding to my to-do list.

This is a valid issue - however, this PR has been inactive for a very long time. Let's revisit if we see a need.


pps no payments

Good afternoon. Help me to understand.
I set up a new pool of mpos + nomp. the main one chose the pps. started everything works but there are no payments. what am I doing wrong?

Please disable PPS if you are not aware what it does and re-create your pool.  You pay out of pocket until a block is found.
You can't pay out because there are no coins in the pool yet.

OK. is there a minimum amount that should be on the pool? if Yes how many?

No, as much as you need to pay out users. If it gets low, add more.


Adding Read instances for Formula, Judgement, and Proof types

Codecov Report

Merging #7 (7a03c51) into main (9c76663) will increase coverage by 2.27%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   67.66%   69.93%   +2.27%
==========================================
  Files          19       19
  Lines        1005     1031      +26
  Branches      119      122       +3
==========================================
+ Hits          680      721      +41
+ Misses        206      188      -18
- Partials      119      122       +3

Impacted Files
Coverage Δ

src/AutoProof/Formula/Types.hs
88.88% <94.11%> (+12.25%)
:arrow_up:

src/AutoProof/Judgement.hs
96.00% <100.00%> (+29.33%)
:arrow_up:

src/AutoProof/Proof/Types.hs
68.89% <0.00%> (-0.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c76663...7a03c51. Read the comment docs.


⚠ Adacta-fintech.com has degraded performance

In 93867ff, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 1665 ms

Resolved: Adacta-fintech.com performance has improved in cd9b14c after 12 minutes.


Always run integration-only scenarios

What does this PR do?

Additional Notes

Review checklist
Please check relevant items below:

[ ] This PR includes all newly recorded cassettes for any modified tests.

[ ] This PR does not rely on API client schema changes.

[ ] The CI should be fully passing.

[ ] Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

Codecov Report

Merging #155 (9222963) into master (79ae98e) will decrease coverage by 4.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   39.25%   35.20%   -4.06%
==========================================
  Files         762      764       +2
  Lines       65872    66995    +1123
==========================================
- Hits        25859    23585    -2274
- Misses      40013    43410    +3397

Impacted Files
Coverage Δ

...ib/datadog_api_client/v2/api/incident_teams_api.rb
10.81% <0.00%> (-68.25%)
:arrow_down:

...datadog_api_client/v2/api/incident_services_api.rb
10.81% <0.00%> (-68.25%)
:arrow_down:

lib/datadog_api_client/v2/api/incidents_api.rb
10.88% <0.00%> (-68.03%)
:arrow_down:

...ib/datadog_api_client/v2/api/key_management_api.rb
8.69% <0.00%> (-63.46%)
:arrow_down:

lib/datadog_api_client/v2/api/roles_api.rb
8.90% <0.00%> (-62.91%)
:arrow_down:

lib/datadog_api_client/v2/api/logs_metrics_api.rb
11.67% <0.00%> (-60.59%)
:arrow_down:

lib/datadog_api_client/v2/api_error.rb
28.57% <0.00%> (-57.15%)
:arrow_down:

lib/datadog_api_client/v2/api/users_api.rb
9.67% <0.00%> (-55.65%)
:arrow_down:

lib/datadog_api_client/v2/api/processes_api.rb
20.00% <0.00%> (-55.00%)
:arrow_down:

lib/datadog_api_client/v2/api/logs_api.rb
32.96% <0.00%> (-47.26%)
:arrow_down:

... and 573 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ae98e...9222963. Read the comment docs.

Codecov Report

Merging #155 (9222963) into master (79ae98e) will decrease coverage by 4.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   39.25%   35.20%   -4.06%
==========================================
  Files         762      764       +2
  Lines       65872    66995    +1123
==========================================
- Hits        25859    23585    -2274
- Misses      40013    43410    +3397

Impacted Files
Coverage Δ

...ib/datadog_api_client/v2/api/incident_teams_api.rb
10.81% <0.00%> (-68.25%)
:arrow_down:

...datadog_api_client/v2/api/incident_services_api.rb
10.81% <0.00%> (-68.25%)
:arrow_down:

lib/datadog_api_client/v2/api/incidents_api.rb
10.88% <0.00%> (-68.03%)
:arrow_down:

...ib/datadog_api_client/v2/api/key_management_api.rb
8.69% <0.00%> (-63.46%)
:arrow_down:

lib/datadog_api_client/v2/api/roles_api.rb
8.90% <0.00%> (-62.91%)
:arrow_down:

lib/datadog_api_client/v2/api/logs_metrics_api.rb
11.67% <0.00%> (-60.59%)
:arrow_down:

lib/datadog_api_client/v2/api_error.rb
28.57% <0.00%> (-57.15%)
:arrow_down:

lib/datadog_api_client/v2/api/users_api.rb
9.67% <0.00%> (-55.65%)
:arrow_down:

lib/datadog_api_client/v2/api/processes_api.rb
20.00% <0.00%> (-55.00%)
:arrow_down:

lib/datadog_api_client/v2/api/logs_api.rb
32.96% <0.00%> (-47.26%)
:arrow_down:

... and 573 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ae98e...9222963. Read the comment docs.


fix: add absent argument for nvim_create_augroup

[x] Have you read CONTRIBUTING.md?

Thanks. Applied manually with e4a6028c3de1a31c0f0c638fc9274d245919d222


#13726 Add coloring by range for text

If both foreground colors are set:

If no foreground color is set:

If only one foreground color is set:

Foreground color doesn't change if no background color is set

Verified


[Bug] Wrong case in path to test file on macOS

On macOS, calling vim.loop.cwd() on my machine returns /Users/mats/Code/... - notice the capital C. On my hard drive, that folder name is code with small case. This creates trouble when I use the neotest-go adapter, since the go test command is case sensitive and thus the test won't run.
A workaround is to rename the /Users/mats/code directory to /Users/mats/Code, but my OCD doesn't approve. Not sure if this should be reported to the Neovim team instead, but... What do you think?
I'm using macOS Ventura 13.0.1, Neovim 0.8.2 and Neotest v2.6.4.

Yeah that's pretty bizarre... As it's a core bug I would like to see it discussed in the Neovim repo before taking any action. It could be a luv/libuv bug.

Thanks, I will raise an issue there in stead. I guess this one can be closed then.
Thanks for creating this awesome plugin.

Closing issue in this repo


Custom AI battle

I wrote my simple version of AI. And my friend wrote his own.
Is it possible to run one versus the other? Our only built-in one is now supported?
I read the documentation but didn't any way to do it.

Unfortunately multi-agent isn't supported yet, though it is something we're working on supporting.

Out of curiousity, what type of bots did you write, and which map(s) are you wanting to play on?

@tewalds
Just to clarify: We are also unable to setup player vs custom AI as well correct? Asking for a friend.

You can only control one player. The second player must be one of the built in bots, not one you wrote. You can play on ladder maps or whichever map you'd like. Supporting multiplayer is high on our todo list, but it isn't available yet.

@tewalds what about versus human players? I understand it's not possible now, but is it also in the works?
Specifically interested in setups where AI is on Linux and human is on Windows machines.

Playing human vs ai is clearly a useful feature in the future, though hasn't been discussed much yet. It will require consideration to decide which limitations to enforce in multiplayer to avoid cheating and other bad behavior. @KevinCalderone do you have anything to add?

Human vs Bot currently works with scripted bots in our C++ library. It is up to DeepMind whether they want to add support for that in PySC2.
Currently multiplayer is restricted to have both SC2 instances on the same machine. However, it should work to have your bot code running on Linux connect to a Windows SC2 client.
I agree we should have a no-cheating mode. We will probably add a flag to disable things like RequestDebug. It wouldn't be very fair if you bot just spawns in a giant army with the debug cheats :).

I'm poking at a solution for bot vs bot as well, exploring the hits you take on something like ngrok to control a remote instance so you can battle friends.

@Xeizzen
Ahh My problem was that I had an older version of the Starcraft Linux package. Switching to 4.0.2 did the trick!
Thanks so much!


table with partition cannot be showed correctly in thrift-server

spark 2.4.4 thrift server 通过spark.sql.extensions org.apache.spark.sql.TiExtens 添加tispark，执行一下语句：
show table extended like 'test_users_dt' PARTITION (ds ='20171011')

实际返回值为下面语句返回值，执行时丢失分区信息：
show table extended like 'test_users_dt'

@melin Thanks for reporting. After some investigation, we already found the root cause.
When we do show tables, we did not consider partitioned table. We will fix it as soon as possible.

@melin Thanks for reporting. After some investigation, we already found the root cause.
When we do show tables, we did not consider partitioned table. We will fix it as soon as possible.
大概什么时候可以修复

@melin 请问这个问题在你们这里优先级高吗？

@melin 请问这个问题在你们这里优先级高吗？

比较高的，辛苦尽快修复一下

@melin
Ok, We will fix it as soon as possible.

@melin could you tell us you are using hive partition table or tidb partition table?

@melin could you tell us you are using hive partition table or tidb partition table?

hive partition table


board/cxd56xx/audio: Fix CXD56 audio initialization

Summary
Fix PCM decoder config where it is always initialized assuming
it was enabled despite being optional.
Impact
CXD56xx
Testing
Test that nxplayer on spresense/audio config works well with/without CONFIG_AUDIO_FORMAT_PCM

Let's ignore the compile warning which is fixed by https://github.com/apache/incubator-nuttx/pull/6799


Borderlands 2 strange stuttering

Please describe your issue as accurately as possible.
I have been looking for optimizing guides for borderlands 2 because i have a laptop with pretty good specs and the fps drops were crazy in that game so thats why i installed dxvk butt an abnormal stuttering had appeared after putting the d3d9 and dgi files in the win 32 borderlands 2 folder i waited because maybe something was loading but after an hour the stutter didnt stop. Is there any way of fixing it or any step im missing?
If you use Windows, please check the following page: https://github.com/doitsujin/dxvk/wiki/Windows
Software information
Name of the game, settings used etc.
System information

GPU:
Driver:
Wine version:
DXVK version:

Apitrace file(s)

Put a link here

For instructions on how to use apitrace, see: https://github.com/doitsujin/dxvk/wiki/Using-Apitrace
Log files
Please attach Proton or Wine logs as a text file:

When using Proton, set the Steam launch options for your game to PROTON_LOG=1 %command% and attach the corresponding steam-xxxxx.log file in your home directory.
When using regular Wine, use wine game.exe > game.log 2>&1 and attach the resulting game.log file.

You didn't provide any logs, information about your system or the apitrace.
What you're seeing is probably shader compilation but you've given us nothing to work with so guessing is the best we can do.

And how do i fix that?

Don't use dxvk or get a driver that supports VK_EXT_graphics_pipeline_library which is only Nvidia at the moment afaik.
Even then some engines like UE4 might still stutter, but that is because the engine itself doesn't prepare shaders in advance by default.

and where can i get those drivers and what do i need to do with them?

The only driver that supports VK_EXT_graphics_pipeline_library on Windows is nvidia's, and it does so by default for a while now. If you have a GPU from a different vendor, there is nothing you can do on windows.

Yes if you are not using Nvidia all you can do is wait.

im using nvidia and i still get the fps drops and dxvvk doesnt work

What do you mean it doesn't work and what is your driver version.
fwiw these unreal engine games are usually extra bad since alot of them don't load shaders up front which means they are first compiled when encountered ingame. I don't remember how Borderlands 2 behaves in that regards specifically.

i have a 3060 like the laptop version and an i 7 and the last drivers available i use like dxvk and the stuttering stays there

Make sure your drivers are up to date.
Aside from that, there's nothing we can do with the limited amount of information you've given us.

i use like dxvk and the stuttering stays there

Does that mean that the game stutter with DXVK in the same way it does without DXVK? In that case I don't see any issues here anyways, since DXVK's goal isn't really to fix or improve games.

it stutters worse the fps is overall normal but it stutters a lot like the game doesnt run smoothly


Migration from Staging To Master

@kkellerlbl: Hey Keith, do you think it's worth redeploying feature_values service in prod with these changes now or we would rather wait until we migrate it to SDK?

I'd say that unless it's critical or blocking something, we may as well wait till the service migrates to SDK.  Do you know whether there are serious issues fixed by this PR?


Appstudio update test-component-pac-odpc

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-odpc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
sanity-inspect-image

✅ Succeeded
5 minutes
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-odpc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
sanity-inspect-image

✅ Succeeded
5 minutes
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-odpc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
6 seconds
sanity-label-check

✅ Succeeded
6 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-odpc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
6 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
sanity-label-check

✅ Succeeded
6 seconds
show-summary


(chores) camel-avro: avoid shadowing variables

More GH tests

Components tested:
Total	Tested	Failed ❌	Passed ✅
1	1	0	1

Nice 👍

Components tested:
Total	Tested	Failed ❌	Passed ✅
1	1	0	1

Nice 👍

Thanks! I hope this will be easier / nicer to read


Match participants with excludes

Hohoho! Want to be Santa's little helper? The first one to come up with working code gets a 50 Euro CoolBlue voucher.
Write an algorithm that assigns every participant to another participant.
Given participants A, B, C, D, E.
Could result in A -> B -> C -> D -> E -> A (randomization is required)
Multiple loops like A -> B -> A + C -> D -> E -> C are allowed
A -> A is not allowed
Must work with an odd number of participants (so don't just make pairs).
Participants can have (multiple) excludes. Eg this must work:
A: exclude C, D, E
B: exclude A, D, E
C: exclude A, B, E
D: exclude A, B, C
E: exclude B, C, D
In this case the only valid list is A -> B -> C -> D -> E -> A
The solution must error-handle a situation that can't be resolved. Eg with participants A, B, C:
A: exclude C
B: exclude C
C: -
This would result in A -> B -> A and a C that can't be assigned.
Must run in an acceptable time with > 200 participants.
Programming language is not a requirement. PHP would be nice, but Java, JavaScript, ... or even Prolog are fine as long as I can verify the scenario's on my machine.
Add your solution as a comment (link to gist, github repo, ...).

This should work
public function test()
    {

        $participants = ['A', 'B', 'C', 'D'];

        $excludes = [
            ['A' => 'C'], ['B' => 'C']
        ];

        $matrix = [];

        //Create adjacency matrix.
        foreach ($participants as $key => $participant) {
            //make every entry possible
            $matrixEntry = array_fill(0, count($participants), 1);
            //Exclude own entry, participant can't give to himself
            $matrixEntry[array_search($participant, $participants)] = 0;

            //loop over the excludes and set them unavalable in the matrix
            array_walk_recursive($excludes, function ($receiver, $giver) use ($participant, $participants, $matrix, &$matrixEntry) {
                if ($participant == $giver) {
                    $matrixEntry[array_search($receiver, $participants)] = 0;
                }
            });

            $matrix[] = $matrixEntry;
        }

        $match = $this->matchParticipants($matrix, $participants);

        //translate to participants
        $result = [];
        foreach ($match as $receiver => $giver) {
            $result[$participants[$receiver]] = $participants[$giver] ?? null;
        }

        die(var_dump($result));
    }

    public function matchParticipants($matrix, $participants)
    {
        // An array to keep track of the givers assigned to receivers. The value of match[i] is the giver number assigned to receiver i,  the value -1 indicates nobody is assigned.
        $match = array_fill(0, count($participants), -1);

        // Initially everything is possible, loop over the participants
        for ($giver = 0; $giver < count($participants); $giver++) {
            // Mark all receivers as not seen for the next giver
            $seen = array_fill(0, count($participants), false);

            // Find if the giver  can give something to a receiver
            $this->search($matrix, $giver, $seen, $match, $participants);
        }

        return $match;
    }

    // A Depth first search based recursive function that returns true if a matching for vertex is possible
    public function search($matrix, $giver, &$seen, &$match, $participants)
    {
        // Try every receiver one by one
        for ($receiver = 0; $receiver < count($participants); $receiver++) {
            // If giver has marked receiver in the matrix and is not visited already
            if ($matrix[$giver][$receiver] && !$seen[$receiver]) {
                // Mark v as visited
                $seen[$receiver] = true;

                //If receiver is not assigned to a giver OR the previously assigned giver for receiver has an alternative receiver available.
                //Since receiver is marked as visited in the above line, match[$receiver] in the following recursive call will not get the receiver again
                if ($match[$receiver] < 0 || $this->search($matrix, $match[$receiver],
                        $seen, $match, $participants)) {
                    $match[$receiver] = $giver;

                    return true;
                }
            }
        }

        return false;
    }

My entry:
https://gist.github.com/robvanderleeintracto/00ca934315c064c081b4f4db1eac1260
Sample output:
`rob@Firebird ~/Desktop/Intracto/Projecten/SecretSanta $ php public/SecretSanta510.php
Case 1
array(5) {
["A"]=>
string(1) "B"
["B"]=>
string(1) "C"
["C"]=>
string(1) "D"
["D"]=>
string(1) "E"
["E"]=>
string(1) "A"
}
Case 2
Unacceptable festive dilemma! Participant B cannot give his present to anyone!Case 3
It took 6 seconds to process 500 participants.`

My entry: https://github.com/jorimvanhove/secret-santa-codechallenge-510

For extra bragging rights, ported my PHP solution to C#:
https://github.com/jorimvanhove/secret-santa-matcher
Matching 250 participants takes roughly 20 ms. Includes unit tests.

closing this. Still need to review everything

closing this. Still need to review everything


Merge branch-24.04 into main

Change version to 24.04.0
Note: merge this PR with Create a merge commit to merge

Build PASS

Build PASS


DO NOT MERGE: Try modules in advance of 6.20 (v2)

TODO:

[x] ~Remove -Wl,--exclude-libs hack is it might have been fixed by https://github.com/root-project/root/commit/08e767cb06717d3c90ddf6834a82cec0cb91937a~ The hack is still needed.
[x] Disable builtin_ftgl (https://github.com/conda-forge/staged-recipes/pull/10561)
[x] Remove SetLibraryPath() in rootx/src/rootx.cxx in ROOT when -Drpath=ON (currently patched with sed(https://github.com/root-project/root/pull/4757)
[ ] Check that all Python packages in lib/ are being symlinked correctly

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Python 2.7 + macOS couldn't find OpenGL... But the other Python versions on macOS could?

Yup and it still works for 6.18.04, I haven’t tried reproducing it locally yet.

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.


Move st2tests to a job

Instead of running st2tests as a pod, this runs it as a job.
To ensure the job only runs once, and fails if a test fails, I've added:
      restartPolicy: Never
  backoffLimit: 0

Which means it'll never Back off / or retry.

I think we can just drop this PR, I've made a misunderstanding on how these tests work, and that they for use with the helm test command.
Internally we use helm template and then kubectl apply to deploy helm charts to our k8s cluster - this seemingly had the side effect of deploying the tests pod as part of the deploy - which AFAIK is now a mistake on our part and us misusing this pod.
Please let me know if I've yet again misunderstood how this is meant to work...

I think we can just drop this PR, I've made a misunderstanding on how these tests work, and that they for use with the helm test command.

Yeah. helm test is the primary use case for this. Having some kind of canary job might be interesting if you have an idea of what that job should do.
So far, I've added one st2canary job to help catch common issues around packs volumes:
https://github.com/StackStorm/stackstorm-k8s/blob/93e3f265b451acd00e1bd71c09dde2b7b3c4397d/templates/jobs.yaml#L491-L604
Any ideas on potential st2canary jobs?

Internally we use helm template and then kubectl apply to deploy helm charts to our k8s cluster - this seemingly had the side effect of deploying the tests pod as part of the deploy - which AFAIK is now a mistake on our part and us misusing this pod.

Ah yes. That's a common gotcha (at least where I work). I've been encouraging my coworkers to use helm install and helm upgrade because doing helm template bypasses a lot of the safety checks helm does during install/upgrade. To me, helm seems a bit more graceful than kubectl apply.
That said, I wonder if there is a way to exclude the helm test hooks when running helm template? Or maybe we can skip rendering the tests stuff in helm template with a new value (or maybe helm exposes some metadata we can use here)? Please submit a PR if there's something the chart can do to avoid the helm template gotcha.

Please let me know if I've yet again misunderstood how this is meant to work...

:smile: You've got it now. The idea of canary jobs is very intriguing though...


Add type check to Variable.__eq__

Variable.__eq__ fails to check if the other value is actually a Variable object before comparing member properties. This fixes the exception that gets raised when comparing a Variable against something else.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I added a second eq to this, for MediumLevelILOperationAndSize; it will return True when compared against its corresponding MediumLevelILOperation as well as if other is the same size/operation

Hah! I was about to open a review about the missing return false but noticed it in the other commit before I did. ;-)
Thanks, looks good.


to attach or to extend?

Hi,
thanks a lot for the work of adding an abstract layer to d3, although I'm still climbing the learning curve.
I'm trying to add a layer to the contributed chart d3.chart.candlestick in the miso project page...The layer depends on another set of data namely a set of transactions. I initially tried extend the chart as I thought I was only adding a layer, however as the dataset now consists of additional data, the whole base chart functions break down. What is the strategy for such as case, should I be composing 2 charts in one using .attach and <?>.demux ? one doubt I have is that both charts share the same scales, so not sure how to re-use was is available in the candlestick chart.
thanks,
Stefan

If I understand your problem correctly, this sounds like a case for attach. You should be able to re-use the scales; how you do it depends on how you structure your code. Here are two approaches that come to mind:

You could define a single chart that initializes the chart you wish to extend, retrieves references to that instance's scales immediately following initialization, and defines the new layer in terms of that reference.
You could define two charts. "Chart A" would define the layer you want to add, and it would accept a set of scales as an initialization option. "Chart B" would create one instance of the chart you wish to reuse and one instance of Chart A, passing in the scales as appropriate. Finally, Chart B would use attach to hook up the draw cycles.

The second approach requires more abstraction, but it's also more composable and potentially more flexible for it. Would either work for you?


Mitchell/jamie blog post

Mitchell Johnson and Jamie Schmidt's blog post.
A summary of the work we completed this summer
How to use the code we completed.

@mitchelljohnson3 @schmi710 also, please also date the post for 08-20 (the last day of the workshop)


SQL Server 2022 released

Included some for SQL Server 2022.
Can you also include SQL Server 2022 in https://aka.ms/sqlserverbuilds? Or is that for someone else and will it be included later?

Learn Build status updates of commit bcb9b6a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/sql/general/determine-version-edition-update-level.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@ingebeumer Hi! For future changes, you can directly create PR in this repo: SupportArticles-docs-pr as a Microsoft member. Thanks.

Learn Build status updates of commit 52054eb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/sql/general/determine-version-edition-update-level.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


fix(urls): prefix relative urls with base href

Closes #28

Coverage increased (+0.3%) to 96.203% when pulling 3b687e07b0211b5d92eeab79e4bbc2f4437413c1 on intellix:base-href-urls into 40c6aa489ab747bb1f65fb335355648fddeec9f1 on cloudflare:master.

Coverage increased (+0.3%) to 96.203% when pulling e1e20b6650eb14aee2d363903916183d108dfbfc on intellix:base-href-urls into 40c6aa489ab747bb1f65fb335355648fddeec9f1 on cloudflare:master.

Coverage increased (+0.3%) to 96.203% when pulling e1e20b6650eb14aee2d363903916183d108dfbfc on intellix:base-href-urls into 40c6aa489ab747bb1f65fb335355648fddeec9f1 on cloudflare:master.

Coverage increased (+0.4%) to 96.25% when pulling f1ea3b7b89b43fb8f1ed926f512ec20a5131a108 on intellix:base-href-urls into 40c6aa489ab747bb1f65fb335355648fddeec9f1 on cloudflare:master.

Coverage increased (+0.5%) to 96.341% when pulling a8f36000fd235820d447ae97232e2258ad535016 on intellix:base-href-urls into 40c6aa489ab747bb1f65fb335355648fddeec9f1 on cloudflare:master.

Man.... 0.12 is painful :P


dude where's my tree? (add recenter camera)

Playing around with the tutorial I realized that if a user zooms "too much", you can't bring back your tree, like here:

In case it helps this is the error in the console:

Anyway, perhaps it will be worth adding a "recenter" button?

This is a really good point, agreed that having a "recenter" button would be useful. This functionality (if it doesn't already exist in the JS code somewhere?) would also be very useful to automatically apply when changing layouts, since the tree's bounding boxes differs for each layout. (Also, I like the issue name ;)
I'm not sure the tree missing here is related to the console warnings (those show up during normal usage of Empress, which may be something to fix in and of itself) -- I think it's more likely that the tree is still drawn somewhere but it's just super difficult to "find" due to the new camera position after zooming being so far off. (In the GIF, I can see the tree sort of go flying towards the bottom of the camera as the camera is zoomed in above where the tree is positioned.)

That's a good suggestion - and even better title. I think a recenter camera button would be great to add.


Fix refreshable bug

When I pull down on the MoviesView.refreshable() I get Something went wrong: cancelled. What's causing the request to be cancelled?

Resolved in the new movies view.


FIRMessagingRemoteNotificationsProxy updated to use GULAppDelegateSwizzler

Changes required for #2591

GULAppDelegateSwizzler - remote notifications methods support
FIRMessagingRemoteNotificationsProxy - swizzling of Application delegate updated to use GULAppDelegateSwizzler

NOTE: FIRMessagingRemoteNotificationsProxy still swizzles UNUserNotificationDelegate methods in its own way. I think, we should refactor it as a separate PR once we finish refactoring of app delegate swizzling in all libraries.

@chliangGoogle I tested basic use-cases like receiving messages sent from the console. Are there any cases I need to pay a specific attention to.

Receiving messages are not enough for testing swizzling, if you look at the implementations, we swizzle because for a few reason. A. to be able to track analytics events, so would be great to check if Analytics is able to track notification_open or notification_foreground event; You can use the "debug mode" on Analytics console to see if a notification is opened or in foreground; B. when APNS token is updated, we need to notify FCM, so would be great if we can also make sure that logic is called. Basically we need to make sure all the "swizzled logic" is actually getting triggered. Does that make sense?

@maksymmalyhin Please make sure to test it with Analytics to ensure the notification tracking still works.


Create new assets for some documentations

New Graphics for most documentation (most likely will replace the headers)
ie. Instead of this:

It'll be a seperate image, instead of using the md-badges logo
The GitBook version will be kept the same, without any graphics.

assets were added in https://github.com/inttter/md-badges/commit/a65f2d0145826093b63bb41dc7f90a6c077b2b8d
actual changes to add the new assets in were added in https://github.com/inttter/md-badges/commit/11205e35ba562ecf8ad4e298c9623b32d0d73448


Version-decoupling for Observability

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

can you link the main issue for version-decoupling to give some context?


[5.5] Don’t crash from circular swift_name attributes

Cherry-pick of #37940 to release/5.5.

If a swift_name attribute’s context referred to the same declaration it was attached to, or a different declaration whose own swift_name referred to the current one, we would recurse infinitely and eventually overflow the stack. This commit makes us instead detect the cycle, diagnose it with a warning, and drop the affected declaration.
Fixes rdar://79370809.

@swift-ci please test


Feature/Release Notes - Added to Home Page under What's New

Link to demo site: https://wright4i.github.io/docs/
Uses GitHub API to grab details of a public repo (vscode-ibmi)
Home Page

Dynamic latest version number
Only link to Release Notes. I felt like it didn't need to be a sidebar item - thoughts?

Release Notes

Dynamically pulls latest 5 releases. githubAPI.ts's fetchFromGithub() has a default limit: number = 5 so we can adjust to taste.
Button at bottom linking to release page for vscode-ibmi

Packages added to project
Server side only, no performance impact
dotenv
Reason - Best practices. Needed .env files for API_GITHUB_TOKEN. Created .env.example for local development.
marked
Reason - Release notes from API was in markdown. marked converted to HTML so I could set the innerHTML of the astro component.
Tasks to Build on Merge

[ ] Needs a new GitHub API token with public_repo scope
[ ] Token should be added to Repository secrets as API_GITHUB_TOKEN
[x] .github/workflows/astro.yml was updated to import API_GITHUB_TOKEN
[ ] (optional, recommended) update build workflow in vscode-ibmi to trigger build on docs so Release Notes are always current

@Wright4i Interesting. Why is the token required? Can you not access the public API for released without a token?

@Wright4i Interesting. Why is the token required? Can you not access the public API for released without a token?

You'd think, but I tried and it didn't work. Guessing so that can track you for rate-limiting/abuse purposes.

@Wright4i @worksofliam Shouldn't we try and complete this? Would be great to have in the docs... 😍

@chrjorgensen you're right! I completely forgot this was out here open.
@worksofliam any issues with the API key usage? If not I can address the conflicts and we can get this merged in.

@Wright4i No problem with token usage! This would be cool to have.


Message container vars

This adds three bools to message_container object which calculate bools
where the "(EDITED)" label should appear:

edited_in_left_col -- when label appears in left column.
edited_along_sender -- when label appears alongside sender info.
edited_status_msg -- when label appears for a "/me" message.

@timabbott all but the last commit can be merged. Need a review on the last one

Merged as the series of commits ending with 1f76374e32a547bfcf10096422ad89fc3d585c65, thanks @vrongmeal!  I squashed a few of the commits where there wasn't a good reason to have them split into two:

It's never useful to have a commit that adds tests for another commit; the test should just live with the code change that makes it useful.
It's better to have a single commit that extracts part of a function from another function and gives it a name (rather than one that makes the new function and another that starts using it); that way, git show in modern Git can show the changes correctly as a code move.

Thanks @vrongmeal!

Thanks for the suggestions. I'll take care in the future :)


Add typescript definition

Fix #293

When will this be merged ?

Why has this not been merged?  Any reasons specifically?

Sorry, I hadn't gotten around to this issue yet.

@davwheat Please update npm package

@alex-chuev Pushed beta update: 1.1.0-beta.2

@davwheat I think you have missed adding the declaration file on build.


Quitting application and re-opening only persists one window

VSCode Version: 1.4.0
OS Version: OS X 10.11.6

Steps to Reproduce:

Open more than one vscode window
Quit the app
Re-open the app

Expected: all previously open windows should be restored
Actual: only one window is restored

Try with setting: "window.reopenFolders": "all"

Thanks, but this setting doesn't seem to be working for me?

What happens?

Only one folder opens, not sure which one (most recently viewed?)
On Thu, 8 Sep 2016 at 17:55 Benjamin Pasero<EMAIL_ADDRESS>wrote:

What happens?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/11379#issuecomment-245663982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4QCRNg4ZWIapQk-E1p6nH3E9Q4DH0Iks5qoD31gaJpZM4JygNe
.

@OliverJAsh can you try this:

set "window.reopenFolders": "all" in your user settings (NOT workspace settings)
open 2 windows on a folder (we do NOT restore empty windows)
File > Quit
Launch again

Works?

Here is my settings file, located at:
/Users/OliverJAsh/Library/Application Support/Code/User/settings.json

I followed your steps again and it seemed to work this time round. Odd! Thanks

Ok then I do not see an issue here 👍


Missing Android permissions

Steps to Reproduce
When adding image support to the Chat tutorial app,  the Android Camera and Media permissions are missing. On a Nexus 6P running Android O my screen was blank when clicking the camera icon until adding the permissions to the Android Manifest.
Suggested fix: Add the following to AndroidManifest.xml
<uses-permission android:name="android.permission.CAMERA"/>
<uses-permission android:name="android.permission.MEDIA_CONTENT_CONTROL"/>

Hi, just confirming, is this in this codelab? https://codelabs.developers.google.com/codelabs/flutter-firebase/

Yep, sorry if that wasn't clear. It's the last step "Add Image Support".
On Monday, June 12, 2017 9:46 AM, Michael Thomsen<EMAIL_ADDRESS>wrote:

Hi, just confirming, is this in this codelab? https://codelabs.developers.google.com/codelabs/flutter-firebase/—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

cc @LarkAscending

Added new section "Enable camera and media content access on Android" to Step 10. PTAL:
https://codelabs.developers.google.com/codelabs/flutter-firebase/#9
Will verify shortly - feel free to beat me to it!

As part of a larger update cycle for plugin upgrades, I tested the codelab on a 5x without these permissions and could not repro. For me there was no issue with accessing the camera and images on the device without these permissions.
Access also works with them (of course). So I left them in the codelab, assuming they will help other users out there.
Thanks for this issue!


Fixed onViewableItemsChanged function

Fixed the issue #120, added the section property to items of viewableItems which defines the origin section of an item.

Thank you so much for the pull request is very appreciated!
Will be released on the next version.


YARN-10491: Fix deprecation warnings in SLSWebApp.java

What? :: Fix deprecation warnings in SLSWebApp.java & TestSLSWebApp.java

toString(URI uri) Deprecated.

Use toString(URI, Charset) instead.

readFileToString(File file) Deprecated.

Use readFileToString(File, Charset) instead.

@aajisaka Can you please review this?
Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 30s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
shadedclient
18m  2s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 47s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 44s

trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 15s
/patch-mvninstall-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch failed.

-1 :x:
compile
0m 16s
/patch-compile-hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-sls in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
javac
0m 16s
/patch-compile-hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-sls in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
compile
0m 15s
/patch-compile-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-sls in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.

-1 :x:
javac
0m 15s
/patch-compile-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-sls in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

-1 :x:
mvnsite
0m 16s
/patch-mvnsite-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 57s

patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 18s
/patch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-sls in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.

-1 :x:
javadoc
0m 19s
/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)

-1 :x:
findbugs
0m 19s
/patch-findbugs-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 18s
/patch-unit-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch failed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

81m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2519

JIRA Issue
YARN-10491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 794c1b741f55 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e2c1268ebd5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/testReport/

Max. process+thread count
597 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
31m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 54s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
shadedclient
17m 53s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 46s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 44s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 20s

hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 17s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 48s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 47s

the patch passed

_ Other Tests _

-1 :x:
unit
11m 48s
/patch-unit-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

120m 59s

Reason
Tests

Failed junit tests
hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2519

JIRA Issue
YARN-10491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ba07bad2d4ee 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e2c1268ebd5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/testReport/

Max. process+thread count
513 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hey @aajisaka, Thank you for your review.
As suggested, I have added StandardCharsets.UTF_8 instead of Charset.forName(String). Can you please review?
Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 23s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
shadedclient
17m 55s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 47s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 44s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 20s

hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 18s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

-0 :warning:
checkstyle
0m 13s
/diff-checkstyle-hadoop-tools_hadoop-sls.txt
hadoop-tools/hadoop-sls: The patch generated 6 new + 14 unchanged - 0 fixed = 20 total (was 14)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 51s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 47s

the patch passed

_ Other Tests _

-1 :x:
unit
10m 31s
/patch-unit-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

90m 52s

Reason
Tests

Failed junit tests
hadoop.yarn.sls.appmaster.TestAMSimulator

hadoop.yarn.sls.TestReservationSystemInvariants

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2519

JIRA Issue
YARN-10491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0165b7a53559 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ad40715690c

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/testReport/

Max. process+thread count
596 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hey @aajisaka, Suggested change has been done. Thank you for the review.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  1s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
shadedclient
17m 47s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 45s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 44s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 21s

hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 17s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

-0 :warning:
checkstyle
0m 12s
/diff-checkstyle-hadoop-tools_hadoop-sls.txt
hadoop-tools/hadoop-sls: The patch generated 6 new + 14 unchanged - 0 fixed = 20 total (was 14)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 13s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 46s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
11m 52s

hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

93m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2519

JIRA Issue
YARN-10491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 79ba89100251 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da1ea2530fa

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/testReport/

Max. process+thread count
511 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 10s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
shadedclient
21m 48s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  1s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 26s

hadoop-tools_hadoop-sls-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 23s

hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
19m 32s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
1m 16s

the patch passed

_ Other Tests _

-1 :x:
unit
12m 20s
/patch-unit-hadoop-tools_hadoop-sls.txt
hadoop-sls in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

108m 48s

Reason
Tests

Failed junit tests
hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2519

JIRA Issue
YARN-10491

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7b11eb280ca9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da1ea2530fa

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/testReport/

Max. process+thread count
619 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TestAMSimulator: https://issues.apache.org/jira/browse/YARN-9843

Hey @szilard-nemeth, Can you please review this?


Since todays updates all arrows are blu

Hi,
really like this card and i use it oftenY. But since the update today all arrows became blue instead of white.
This happens with standard theme and both light and dark themes. How can i change only the 'arrow' color?
Thx for your work here!

Currently not possible.

@Alia5
i tried adding
icon-color: var(--rba-white-color)
to my theme but this didnt work. Do you know what exactly i have to add?

@Alia5 Could you please help me to do this?

I'm facing a similar problem, the arrows appear black on fresh install of the card on all devices.
My theme however defines primary-text-color: "#FFFFFF"
Anyone having the same, or is there a know fix?
Pretty sure something is "missing" with my theme since using HomeAssistant's default dark theme the arrow becomes white.

Same still here, my workaround is using 0.0.3 but thats not really a fix.
@Alia5 Pls help

I delete the cache of the companion app on Android (in application settings) and the arrows turned white.
Still black on desktop but that must be a cache issue somehow.


🐛 [BUG] Outstanding bugs

What is the issue?

[x] Url copied - the whole div shows pointer cursor but copy works by clicking the button. Should remove cursor pointer from its parent div
[x] The chain link icon displayed alongside mock route in the dashboard shrinks in size inverse to the length of the route
[x] The user management screen does not load users properly due to conditionally invoked get users call
[x] Restrict special characters in /api/put/da`^*()/gg (route, mock name, query params etc....)
[x] Response Type and Uploaded file has different type. eg: response type is audio/mp3 and uploaded file is csv format
[x]  Update request headers and request body not working
[x] Delete Mock dialog box text is misleading need to change it
[x] Card Status Badge (Deleted) is misplaced after adding copy url icon. Need to fix it
[x] User password update modal is not getting unmounted automatically which displays it when the user opens the modal and directly jumps to settings screen
[x] #165
[x] #163
[x] #164
[x] Delete user not working properly. throwing CORS error (Happens when user name has invalid characters. This has been addressed with validations on both UI & backend)

Outstanding items are being tracked as separate issues mentioned in the description


Allow check for abstract class

Hello, currently abstract class cant pass transformAndValidate type check.
When export declare type ClassType<T> = new (...args: any[]) => T;, abstract class validate can't pass type check.
abstract class User {
    @IsString()
    @MinLength(5)
    name: string;
}

let user: User = {
    name: 'hello'
};

transformAndValidate(User, user);

Use export type ClassType<T> = {prototype: T}; to allow check for abstract class, and plain object also cant pass check

@wwwzbwcom It solves the args problem but makes an issue for the receiver - you can't do new Foo() anymore as without new signature the type with prototype is not newable.
And I think TypeScript do a good job here - abstract class in abstract, you shouldn't be able to create an instance of such class. transformAndValidate does exactly that, returning you an instance of abstract User class.
I think you should change the way you define your abstract and non-abstract classes.


Evaluator close button should first unlink, then close

When an evaluator has a linked pane, the close button in the evaluator should appear as the hidePane16 icon, and its action should be to close and unlink the linked pane.
When the evaluator has no linked pane, the close button should appear with the close icon (as it always does now) and its action should be to close the evaluator.
Thus, to close an evaluator with a linked pane, you click twice -- once to close the linked pane and change the appearance of the button, and again to close the evaluator.

Implemented in commit  637d1baa, currently only in martinDev.

This was merged to main in commit  d334dfdb, May 26.


OSM 0.9.0 does not work on OpenShift

Bug description:
OpenShift requires the osm-controller RBAC to have permission to delete secrets for the garbage collection of Envoy secrets. Without this (as is the case in 0.9.0), pods in the mesh are not schedulable in OpenShift.
Affected area (please mark with X where applicable):

Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        []
CLI Tool                   [ ]
Metrics                    [ ]
Certificate Management     [ ]
Sidecar Injection          [X]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
Demo                       [ ]
CI System                  [ ]

Expected behavior:
Pods can be scheduled in the mesh.
Steps to reproduce the bug (as precisely as possible):
Deploy meshed pods on OpenShift with OSM 0.9.0
How was OSM installed?:
Demo script
Anything else we need to know?:
{"level":"error","component":"kube-controller","error":"secrets \"envoy-bootstrap-config-888a79b4-4ec2-489a-a0f8-886b30d1959e\" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>","time":"2021-06-21T22:14:31Z","file":"announcement_handlers.go:61","message":"Failed to update OwnerReference for Secret bookbuyer/envoy-bootstrap-config-888a79b4-4ec2-489a-a0f8-886b30d1959e to reference Pod bookbuyer/bookbuyer-6bb8ddbb99-ltdbm"}

Environment:

OSM version (use osm version): 0.9.0
Kubernetes version (use kubectl version): v1.19.0
Size of cluster (number of worker nodes in the cluster): 3
Others: OpenShift

@ksubrmnn I'm closing this since we fixed it in v0.9.1


Make "switch login" button more responsive/dynamic

Indicate the current logged in user if there is one (but this can't just be from the RepoOwner.getUsername() method, since some users -- like me -- just use a GitHub API token for the username).

Don't start it with the ambiguous "Switch login" text... Can be confusing.

Another reason this is important: in the user study, people kept trying to log in right away and then not knowing if it worked or not.

Login button now updates to the username. It does display an API token if one was used for the username, but I don't think that's a huge concern, especially since it makes it clear how you are logged in for that repo.


Download blockchain hangs on checksum error.

I've tried a few times now but when downloading the blockchain it hangs on a checksum error every time at the same point. See attached Pic of the console output attached.

Thanks for the report. This was the torrent dowload, right?

Yes, it was the torrent which is the only download option in the latest
version of raspiblitz at the moment.
Op di 4 sep. 2018 21:46 schreef Christian Rotzoll<EMAIL_ADDRESS>
:

Thanks for the report. This was the torrent dowload, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rootzoll/raspiblitz/issues/73#issuecomment-418494598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSKfcM-uW7VfhPhzuYqXwcdCKSyjsYxks5uXtiSgaJpZM4WWyTA
.

Hmm, I checked yesterday before posting this issue and I'm sure 2018-07-17b
was the version linked in the Readme. Anyway, I see there is a newer
version now dated 2018-08-28. Downloading it now. I'll let you know hoe it
goes. How was the hackday? 😎
Op di 4 sep. 2018 22:23 schreef Christian Rotzoll<EMAIL_ADDRESS>
:

Working on improving FTP/Torrent at the moment - it the moment its still
too slow and unstable. But there should be two download options in the
latest version >0.86: FTP or Torrent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rootzoll/raspiblitz/issues/73#issuecomment-418505455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSKfUEkJk5N-4yFC2P9yQKSLIihKc5Aks5uXuFQgaJpZM4WWyTA
.

make sure to clean your HDD for a fresh start - just format it (FAT, etc) on another computer before retry.
the hackday was awesome :D still recovering ;)

I will close this issue - because of old version. Reopen if you have still problems with it with the new version.


[Bug] Windows Corner/Side Snapping

Describe the Bug
When using the "Enable Transparency" Toggle in BD, Discord cannot be resized/split/quartered by dragging the title bar to the side of the screen.
To Reproduce

Enable Transparency
drag Window title bar to the top/side/corner of the screen

Expected Behavior
Normal Window tiling behaviour
Screenshots
Enabled

Disabled

Discord Version
Stable
Additional Context
Microsoft Powertoys can handle the interaction.

Known, it's an issue with electron. Nothing BD can do about it.

Gotcha, thanks!


Move all languages into their relevant dir.

Consolidate scripts and bring a sort of
framework. To install new packages by
just dropping in a script inside these relevant
directories.

Testing in progress, reviews welcome!


Fixes error on postgresql on 2FA column

Fixes https://github.com/cachethq/Cachet/issues/346

I think this caused issues with mysql 5.6.

I've tested on the latest version of Homestead with MySQL Distrib 5.6.19, for debian-linux-gnu (x86_64) and (PostgreSQL) 9.4.0. Maybe for another dist?

Also, this shouldn't be a separate migration file anyway. We should just be editing the existing migrations until we actually tag v1.0.0.

Yeah that's true, this is only fixing one click install on Heroku for now.

Cool.


Render default_view in empty hash.

@timabbott we should test this properly. I did a bit of manual testing on my own, but I am not 100% sure these are all the changes we need to do for this.

@amanagr can you rebase this when you get a chance?

OK I also did what I think is a complete review on this.

Ready for review.


chore: cancel in-progress build on PR update

This change modifies the pull request build definition so that previous builds of a pull request are cancelled when a new change is pushed. This avoids redundant pull request builds continuing to run to completion and wasting build resources.

You can see that a force-push to the PR branch cancelled an in-progress build of the previous PR state:
https://github.com/substrait-io/substrait-java/actions/runs/9305341696


Add Snapp Pay driver

Hi,
This pull request adds the Snapp Pay gateway, which facilitates installment payments. When creating a transaction, you need to pass the basket details to the gateway. The image below illustrates a simple basket with the required data.

🔹گایدلاین ارسال دیتا در سرویس پیمنت توکن 🔹

➖مقادیر شامل در discountAmount :
کارت هدیه + کد تخفیف + امتیاز کاربر + کوپن

➖مقادیر شامل در externalSourceAmount :
کیف پول کاربر

➖ مقادیر شامل در shippingAmount :
بسته بندی + کادو پیچ + هزینه ارسال + هزینه بسته بندی محرمانه

➖ مقادیر شامل در totalAmount :
حاصل جمع مبالغ آیتم ها با در نظر گرفتن تعداد و هزینه tax و shipping

This driver includes the following methods:

eligible: Ensures that you can offer the credit option to users.
settle: Finalizes the payment after the verify method is called.
revert: Refunds the payment to the user if the order cannot be completed (after verify).
status: Retrieves the status of the payment.
cancel: Cancels the payment (after settle).
update: Changes the items in the basket, ensuring the final amount is less than the original amount.

Below is an image showing the process flow:

How has this been tested?
An account was set up in the staging environment of this gateway, and the following methods were tested:

[x] oauth/token
[x] eligible
[x] token
[x] verify
[ ] settle
[ ] revert
[ ] status
[ ] cancel
[ ] update

Thanks.

@khanzadimahdi
Thanks for the review. I have fixed the issues. Honestly, I copied the implementation from the Digipay gateway and didn't check the private/public status of those methods. :)
In #231, I also fixed the digipay driver.


Error "http 400"

Hello,
in many cases, we can see problems while using the code from the hygiene station. Code is "http 400" and text "Nepodařilo se nám odeslat data."
Screenshot: https://prnt.sc/uz4w9l
Thank you for checking it.
L.

Yes we are aware about it, it's a production issue we are currently investigating. Fix should hopefully be on the server side without the need for app update.

The issue should be fixed and you should no longer see HTTP 400 in the app.


Make #107 compatible and found HttpReadStream resource leak

Hello, I'm Ruo-Chun Tzeng, who'd like to participant in GSoC 2017.
As a test, I was assigned to fix #112.
There're 2 changes:

I add unit tests for checking file-descriptor leak of local compressed files
and caught gzip, bz2 are not properly closed  on python 2.6.9 (failed my file-closing test)
I do a quick fix to make #107 compatible with make_closing function. so that HttpReadStream work with compressed formats
However, I found the HttpReadStream is not properly closed, the contents is still readable after closing the stream.with smart_open.smart_open('https://github.com/RaRe-Technologies/smart_open/blob/master/smart_open/tests/test_data/crlf_at_1k_boundary.warc.gz', 'r') as fin:
    print(fin.read())
fin.read()

Thanks for investigating closing but the most important of this PR is that new unit tests need to be added when some gzipped/bz2 file is opened via http.

OK, my bad, I've add unit tests for read/write mode tests and close tests for bz/gz2 over http.
Also, since there's file-handle leak on

local bz/gz2(python2.6.9) and
bz/gz2 over http,

the unit test for file-handle leak tests are commented.

@lubebul  Please see tests and code in #112

Fixed in #112


Add bin, bout, hrsp_4xx, hrsp_5xx to proxy.frontend include list

It fixes issue which was hidden before we started using multiple LB nodes:
2017-11-09 06:17:21,214 ERROR ioloop.py:612 Exception in callback <functools.partial object at 0x7f97ba5ca838>
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/tornado/ioloop.py", line 592, in _run_callback
    ret = callback()
  File "/usr/local/lib/python2.7/dist-packages/tornado/stack_context.py", line 275, in null_wrapper
    return fn(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/appscale/hermes/stats/stats_app.py", line 300, in write_stats_callback
    profiler.write(stats)
  File "/usr/local/lib/python2.7/dist-packages/appscale/hermes/stats/profile.py", line 307, in write
    summary.bytes_in_out += proxy.frontend.bin + proxy.frontend.bout
TypeError: unsupported operand type(s) for +: '_MissedValue' and '_MissedValue'

https://ocd.appscale.com:8080/job/Daily Build/4397/


Migrate RCTWebView to WKWebView.

Motivation
https://github.com/facebook/react-native/issues/321 - Use WKWebView instead of UIWebView, because WKWebView is faster, consumes less memory, and is more stable.
This is meant to be a drop-in replacement for the existing UIWebView-based RCTWebView.
Test Plan
Used a web view loosely based on RNTester's WebViewExample.js, and tested in an ejected AwesomeProject. Browsed around the internet.
Release Notes
[IOS][ENHANCEMENT][RCTWebView] - Migrate RCTWebView to use WKWebView instead of UIWebView.

Is there some way to test/fix the flow check locally? I did not change any JavaScript code in this PR, so I am not sure how this broke it.
node 6:

npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>flow /home/circleci/react-native
flow "check"
Error: node_modules/metro-bundler/src/Bundler/util.js.flow:46
46: ): Ast {
^^^ identifier Ast. Could not resolve name
Found 1 error
npm info lifecycle<EMAIL_ADDRESS>Failed to exec flow script
npm ERR! Linux 4.4.0-97-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "flow" "--" "check"
npm ERR! node v6.11.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>flow: flow "check"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>flow script 'flow "check"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-native package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     flow "check"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-native
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-native
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/circleci/react-native/npm-debug.log

and node 8:

<EMAIL_ADDRESS>flow /home/circleci/react-native
flow "check"
Error: node_modules/metro-bundler/src/Bundler/util.js.flow:46
46: ): Ast {
^^^ identifier Ast. Could not resolve name
Found 1 error
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>flow: flow "check"
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>flow script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2017-11-11T19_25_11_051Z-debug.log
Exited with code 2

This looks really awesome. Thanks for working on it.
BTW, not only is WKWebview faster, consumes less memory and stable, but it's required by Apple now.
Starting in iOS 8.0 and OS X 10.10, use WKWebView to add web content to your app. Do not use UIWebView or WebView.

https://developer.apple.com/documentation/webkit/wkwebview

Thanks @randyzhao! I'd love to hear any issues that you (or anyone else) run into with the WKWebView version of RCTWebView.

@ide @grabbou Should the web view move into a standalone module?

That's my understanding. Also, there's already quite interesting community implementation, called react-native-wkwebview that I've been using myself.

@bowerman0 @grabbou @ide one reason I'd like to see this hit rn is so that expo will have it without having to eject. So either it'd need to be supported by the expo team (they pull in some modules like this I guess) or it'd have to go in here (in order to use it in expo without ejecting). https://expo.canny.io/feature-requests/p/wkwebview-support - as you can see the request is pretty low in priority :/

Any updates from the React team on this? This is a crucial part of my app and it would be awesome to not have to eject my expo app.

I am pretty sure WebView will remain part of Expo regardless, but you can
ask this on their support forum just in case :)
On Fri, 9 Feb 2018 at 02:04 James Heald<EMAIL_ADDRESS>wrote:

Any updates from the React team on this? This is a crucial part of my app
and it would be awesome to not have to eject my expo app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/16792#issuecomment-364301920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxjv5Otn7o2J2gjSh1rxIL_qEFpyQks5tS5mPgaJpZM4QaUMH
.

Any updates for this pr?

A new WKWebView implementation was recently merged into this repository, and then extracted to react-native-webview. Since this PR seems to be addressing a problem that was already solved, I'm going to close it.


Added Whitelist Feature and Exclude No License Feature

You can also use a whitelist now for checking licenses.
<whitelist> <param>mit</param> </whitelist>
You can toggle if dependencies without license information should fail the build
 <excludeNoLicense>true</excludeNoLicense>
Added a little bit of error handling. Removed some empty catch blocks.

Awesome. Sorry it took me so long to get to it!