[JDA] Use Message#getContentDisplay

Message#getContentRaw will not resolve any mentionables, such as users and channels. This makes the content <#241774576822910976> <@115552359458799616> instead of #general @Griffin.
I personally can't think of a reason why you would need the raw format. If you want the mentions, you should use arguments.
Closes https://github.com/ProjectEdenGG/Jayce/issues/1

Wouldn't this break argument parsing for Discord objects? Last I checked the argument parsing for things like Channel and Role relies on using the raw input to see the object id that was mentioned, but if you use getContentDisplay then these ids aren't available anymore.. I could be mistaken though

Hmm, you're right. I'll come up with a different solution.

Perhaps this could be added to the context via the processor?
see: this
Although the event is already in the context there so theoretically you could already get the content in that format, not sure if want to bloat the context even more but I'm open to it.

I'm not sure how exactly you would implement it in the context.
The only solution that I've come up with that I think sounds "correct" is to replace the content with the display content if the object it is parsing does not implement IMentionable, but I'm not familiar enough with the framework to know how to do that, and the tokenized queue complicates that


feat/implement open lookup evaluated

revert using ref_aliases.h
add move constructors and unit tests on ProverQuery and VerifierQuery
implement Open() on LookupEvaluated

Please change "build(zk): tidy up bazel build" to "refac(zk): tidy up headers"

Please include 6dd577c4675d6f08dcd5bb1139f94653c08f242c in "feat(zk): revert using ref_aliases.h" for reference.


Files is saved empty to the download folder

Hello. On some phones (or Android systems), files are saved with a weight of 0 bytes. In other directories everything is saved normally.
NetworkRepository.DownloadService.downloadAppealFileAndroid(this.item?.code, item).then(async (response) =>  {
    let base64Str = response.data;
    let fileName = item.name;
    let data = base64Str;
    let encoding = "base64";
    try{
      await ScopedStorage.openDocumentTree(true).then(async (file) => {
        await ScopedStorage.writeFile(file.uri, fileName, '*/*',  data, encoding, false).then(() => {
          this.isAppealFileLoad = false;
        })
      });
    } catch (e) {
      this.isAppealFileLoad = false;
      console.log(`***error*** ${e}`)
    }
  });

@AlmiranteTim You are not allowed to save files in Downloads folder or even take permission of that directory in Android 11 and 12. Hence the issue.
To solve this, don't take permission of Downloads folder root as it won't work on Android 11 and Above. If you really want to save something in the Downloads folder, use createDocument method which allows saving a file there.

@AlmiranteTim You are not allowed to save files in Downloads folder or even take permission of that directory in Android 11 and 12. Hence the issue. It works normally on older android versions.
To solve this, don't take permission of Downloads folder root as it won't work on Android 11 and Above. If you really want to save something in the Downloads folder, use createDocument method which allows saving a file there.

I tried, but the pdf file still saves with a size of 0 bytes. Android - 7.1.2, phone - meizu M6 Note

@AlmiranteTim The library is being used in a project with thousands of users and I haven't had such a report or issue. I will try to reproduce in emulator & older android versions. Have you tried to reproduce it in a emulator with android 7 installed?

@AlmiranteTim The library is being used in a project with thousands of users and I haven't had such a report or issue. I will try to reproduce in emulator & older android versions. Have you tried to reproduce it in a emulator with android 7 installed?

Yes, i tried. We also received a couple of messages from users about this problem on android 28,29

Does it cause an issue in the emulator?

Does it cause an issue in the emulator?

No

I have the same problem as this issue


dead link on readme.md

"internal flutter team doc" ends in a 404 page

404 is the error many Google-internal links give when you don't have access to the content, so this is the expected behavior.


S3 basic_external doesn't work

The signed S3 URL doesn't work for uploading.
Git LFS receives a 401 when uploading.

I believe this to be related to the configuration for signature version in the boto3 client here: https://github.com/datopian/giftless/blob/5b3f7204321e8775b9eac3953a4894988ad78b7c/giftless/storage/amazon_s3.py#L29
See this issue in botocore: https://github.com/boto/botocore/issues/2109. If the fix indicated at the bottom were implemented it may correct the issue.
I'm receiving a similar message: "The request signature we calculated does not match the signature you provided. Check your key and signing method." when I try to run git push after following the tutorial for google cloud storage, but modified to run against s3.

Feel free to try it and make a PR.  I'm at a conference this week but I can probably get to it next week (disclaimer: I don't work for Datopian, so my time to work on this is entirely at my management's discretion, so if stuff is blowing up, I won't, but at least right now it seems like I should be able to, since that looks like a very small change).

I'll give it a shot. I need to adjust my setup to try and use local giftless.

@devinnasar did you get a PR in on this?

@devinnasar @athornton any thoughts on this?

Yeah, I think I completely forgot this existed and utterly dropped the ball.  Sorry.
I should take a look again.


feat(chore): remove support for node v14,v12,v10

Description

Version 14, v12, v10 of Nodejs reached its end of life

BREAKING CHANGE:
End of life of node v14, node v12 and node v10

GH-20
Fixes #20
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

This should have not gone with the feature type -- requesting changes in other similar PR

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How can i create a new component without sidebar and navbar ?

You can for example show/hide sidebar and navbar conditionally with *ngIf directive. Store the variable that will be passed to the *ngIf in some global service and update it on the route change.


Which OS should be used for SDN infrastructure VM ?

In section create Create the VHDX file,  it said "SDN uses a VHDX file containing the Azure Stack HCI operating system (OS) as a source for creating the SDN virtual machines (VMs). The version of the OS in your VHDX must match the version used by the Azure Stack HCI Hyper-V hosts", but in the following examples, it uses WindowsServerDatacenter image for create VHDX file.
And if I use Azure Stack OS to create VHDX file and use it as SDN VMs (NC, Gateway or Mux), then in Events of each SDN VM, it will prompt an Warning Azure Stack HCI needs to join a cluster within 30 days of installing the operating system. Create a new cluster or join an existing one. every hour, but in general, this VM will not be add to cluster for hosting virtualization workload.
So the question is:

Which OS should be used for SDN infrastructure VM  (if SDN is used for Azure Stack HCI cluster)?
If used Azure Stack HCI OS for SDN VMs,  should we add SDN VMs to a Azure Stack HCI cluster? If we do not add to cluster, what will happen after 30 days?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 01571ef6-1345-ed10-4033-6d031b769dac
Version Independent ID: 7943811e-8822-7e0d-ba9a-172daf986312
Content: Deploy an SDN infrastructure using SDN Express - Azure Stack HCI
Content Source: azure-stack/hci/manage/sdn-express.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @v-dasis
Microsoft Alias: v-dasis

Thanks for the feedback , am investigating...

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@v-dasis I have an another question, if we use both Azure Stack HCI cluster and Windows Server 2019 (SDDC) cluster in same datacenter and managed by same SDN infrastructure,  what OS we should use for SDN infrastructure VMs?

SDN infrastructure VMs should be on same OS type as the underlying hosts. So, if you have a HCI cluster, the SDN VMs should be on the HCI OS. And if you have a Windows Server cluster, the SDN VMs should be on the Server Datacenter OS. One SDN cluster cannot manage a mix of HCI and Server hosts.
The SDN VMs use the Azure Stack HCI OS. Although the event comes up and can be annoying, it will not have an adverse effect. Customers will be able to use SDN VMs even after 30 days.
Hope this helps...

SDN infrastructure VMs should be on same OS type as the underlying hosts. So, if you have a HCI cluster, the SDN VMs should be on the HCI OS. And if you have a Windows Server cluster, the SDN VMs should be on the Server Datacenter OS. One SDN cluster cannot manage a mix of HCI and Server hosts.
Hope this helps...

Can you officially confirm this?  It's a hardcoded technical constraints , or license limitation (but actually works), or just not the best practice?  We have customer using SDDC clusters currently and have plan to use Azure Stack HCI for part of workload only if the SDDC clusters and HCI clusters will co-exist in same SDN infrastructure.

It may work, there is no hardcoded technical constraint right now. But, it is not officially supported.
Please reach out to<EMAIL_ADDRESS>We can discuss available options for the customer.

@AnirbanPaul @v-dasis Thanks for you comments, and we will contact SDN team with customer scenario.

We will close this now as this is being taken offline.

I would like to see this reopened.  Both WAC and the current SDNExpress automation appear to fail if an Azure Stack HCI OS 21H2 image are used.

HI
Can you please tell us where you see the failure? And can you provide the failure details.
Thanks
Anirban
From: aricbernard @.>
Sent: Wednesday, March 30, 2022 5:28 PM
To: MicrosoftDocs/azure-stack-docs @.>
Cc: Anirban Paul @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-stack-docs] Which OS should be used for SDN infrastructure VM ? (#1523)
I would like to see this reopened. Both WAC and the current SDNExpress automation appear to fail if an Azure Stack HCI OS 21H2 image are used.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-stack-docs%2Fissues%2F1523%23issuecomment-1083849974&data=05|01|anpaul%40microsoft.com|3013e4a7cb134e4d7af308da12ad4168|72f988bf86f141af91ab2d7cd011db47|1|0|637842832595583255|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=0IPBeLgXejL%2FNJjvaFpP4iD40JLOdXV7zqH7asm2IBg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEBB63NN53UUCFAAYMHAXC3VCTWPPANCNFSM47GA5GRQ&data=05|01|anpaul%40microsoft.com|3013e4a7cb134e4d7af308da12ad4168|72f988bf86f141af91ab2d7cd011db47|1|0|637842832595583255|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5M%2B5%2BmoV2SzLsJ%2Bifor2Psv%2F7eHQ2rHZ5OIGJVpUn9c%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi Anirban,
Aric is my colleague and we have been working on this together.
We see the same failure in 3 different lab setups.
The screenshot you see is from the network controller VM after it has been created by WAC.

Thanks for the feedback. I would like to take a look at logs for the deployment. If you are using Windows Admin Center for deploying Network Controller, the logs will be in the Documents folder of the first HCI host. You can send the logs to<EMAIL_ADDRESS>NOTE: You should be using an Azure Stack HCI vhdx file for NC deployment on an Azure Stack HCI cluster.
Also, would you be willing to get on a call to discuss the issue if needed?
Thanks
Anirban
From: xYorickx @.>
Sent: Thursday, March 31, 2022 12:52 AM
To: MicrosoftDocs/azure-stack-docs @.>
Cc: Anirban Paul @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-stack-docs] Which OS should be used for SDN infrastructure VM ? (#1523)
Hi Anirban,
Aric is my colleague and we have been working on this together.
We see the same failure in 3 different lab setups.
The screenshot you see is from the network controller VM after it has been created by WAC.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-stack-docs%2Fissues%2F1523%23issuecomment-1084222853&data=05|01|anpaul%40microsoft.com|195d673828f844564ebb08da12eb6279|72f988bf86f141af91ab2d7cd011db47|1|0|637843099436286071|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=xdsyikw3vvQ7SBZSQLiiN90Go3GLOglqeKyTOPDrp7Y%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEBB63ORMPECG5QKUT3TWHLVCVKTHANCNFSM47GA5GRQ&data=05|01|anpaul%40microsoft.com|195d673828f844564ebb08da12eb6279|72f988bf86f141af91ab2d7cd011db47|1|0|637843099436286071|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=gjDIctaVgop%2BPZxzNtSJGY4dnfDWBJ34nsdNQM0yKPs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I think part of the issue may have been the lack of good instructions for creating an Azure Stack HCI VHDX.  We created one and ran sysprep within it.  However that seem to break the VHDX.  The process documented to create the VHDX in the docs was broken (we reported this bad link) . We connected with someone in support that provided additional guidance for the VHDX creation.  We are close to being able to test again.  I will report back more soon.

@AnirbanPaul creating the VHDX using Convert-WindowsImage (once I worked through the bad links links in the Docs etc.) did work and allowed me to deploy an NC using the image (with SDNExpress).  However, something is not shaking out properly with the SDN deployment even through SDNExpress says it completed successfully.  Where is the best place to start troubleshooting?  Are there logs?  EventLogs on the NC maybe?

Can you provide more details on what is failing? That will given an idea on how to investigate further and what logs to collect. Alternatively, we could discuss over a call as well.
Thanks
Anirban
From: aricbernard @.>
Sent: Thursday, March 31, 2022 6:25 PM
To: MicrosoftDocs/azure-stack-docs @.>
Cc: Anirban Paul @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-stack-docs] Which OS should be used for SDN infrastructure VM ? (#1523)
@AnirbanPaulhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAnirbanPaul&data=05|01|anpaul%40microsoft.com|586966130ce5454bc92208da137e7eab|72f988bf86f141af91ab2d7cd011db47|1|0|637843731267159259|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2BXZT%2B1YBFaxc98mTxQzaHSDWXVJ%2FyrL7GfQo3rPcBjU%3D&reserved=0 creating the VHDX using Convert-WindowsImage (once I worked through the bad links links in the Docs etc.) did work and allowed me to deploy an NC using the image (with SDNExpress). However, something is not shaking out properly with the SDN deployment even through SDNExpress says it completed successfully. Where is the best place to start troubleshooting? Are there logs? EventLogs on the NC maybe?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-stack-docs%2Fissues%2F1523%23issuecomment-1085297343&data=05|01|anpaul%40microsoft.com|586966130ce5454bc92208da137e7eab|72f988bf86f141af91ab2d7cd011db47|1|0|637843731267159259|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=kYRXAIg9SJVV3k57rYs9fgqjjO%2BIaKFfaSTDowPJoTg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEBB63IU2IBLD456PCCF3ELVCZGAHANCNFSM47GA5GRQ&data=05|01|anpaul%40microsoft.com|586966130ce5454bc92208da137e7eab|72f988bf86f141af91ab2d7cd011db47|1|0|637843731267209238|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=WP15bVhS2gvvknlsJt9cq%2F5dVwUrkpqvEF4Gyl%2BDp18%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Happy to have a call next week.  I am in GMT-8 but can be somewhat flexible.
My latest attempt to deploy is using WAC (instead of SDNExpress) and it is 'hanging' in the "Network Controller creation" following successfully executing "Virtual machine creation".

BTW - GitHub is blocking the display of all email addresses, so I cannot email you the logs.

Please send mail to sdn_feedback at microsoft.com with the logs. We can figure out a time slot for a call as required.


⚠ Bofrost.fr has degraded performance

In 2b4171b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1538 ms

Resolved: Bofrost.fr performance has improved in 6b868e6 after 13 minutes.


Rotate snapshot key to server when initializing new notary repos

Default to having notary server manage the snapshot key when pushing a new repo with docker content trust.  This makes it easier to get started with delegations, and users can always reclaim their snapshot key to their local storage with a notary key rotate command if they wish (tracked in https://github.com/docker/notary/issues/605)
also, here's a cute aardvark:

Signed-off-by: Riyaz Faizullabhoy<EMAIL_ADDRESS>

ping @endophage @diogomonica please have a look

LGTM

LGTM


Who can share me the working 4 compiled jar files against the 6.6 Opencast?

I spend too much time on getting it working with Opencast, but always no luck. So, I want to have a try with your working files, please.

No offense, but this issue tracker is supposed to track issues and tasks the maintainers (i.e. me) are supposed or want to do at some point. Your title suggests that this is a request towards the community, which is better served on a community platform. Since the annotation tool does not have something like that at the moment, I would direct you towards on of the Opencast mailing lists. See also here.
For a general solution, we already have #250 to remind me to provide what you want in a a way easily consumable by everyone. I even changed the title just now to reflect that. :wink:

FWIW: You could try to gather the necessary jars from here: https://github.com/opencast/annotation-tool/tree/m2/org/opencast/annotate


Preact?

https://preactjs.com/

Is this an issue?

not really, but preact support would be nice

Got it, I'd certainly be willing to merge PRs for increased compatibility.  I'm not a Preact user so I'm not sure of the issues.

might be a bad idea after all, a fork would probably be a better idea

If the changes don't bring negative side effects, we can make them here.  Though, I could see issues with regressions since I'm not sure how we'd test for Preact compatibility when shipping new features and fixes.

https://preactjs.com/guide/switching-to-preact
you basically have to replace every import of react/react-dom or alias it, but idk about the other libraries used

Yep, this would need some investigation on a PR to figure out how to solve.  I'm sure there will be lots of broken features.  In a library like ours, we use many things that I'm betting are not supported, like event.nativeEvent.stopImmediatePropagation() or ReactDOM.unstable_renderSubtreeIntoContainer().
Again, I'd be willing to look over and merge PRs from the community on increasing compatibility with other libraries 👍

I think preact-compat just needs to alias .nativeEvent there. We have the other API for sure.

Sorry to comment on a very old issue, but does this work today? @levithomason

No idea, I've never used Preact.
@davezuko may possibly have some insight?  I think he may have converted some SUIR powered apps to Preact recently.

Most of this should be handled by [preact-compat])https://github.com/developit/preact-compat) without any work from SUIR itself. I think it's a far better tradeoff to include the extra ~2kb for the compat layer than to fork SUIR specifically for Preact.
I, however, defer to @developit since he maintains Preact :P.

@ForsakenHarmony Haven't you tried to use SUIR with preact-compat?
I want to use SUIR without introducing React into the runtime bundle.
However, not sure if we can get rid of React or preact-compat just act as a compatible layer on the top of React's base.

@redstrike if you would like to add an Example Project to the SUIR documentation that shows how a SUIR project would be configured with preact and preact-compat, PRs are definitely welcome.

Will you plan to add some supports or official docs for Preact users?

Will I specifically? No, as I have no need or incentive for Preact.  However, I am in full support of a community effort to accomplish this and will help move things along as much as I can.


add benchmark

incl https://github.com/open2b/scriggo-bench

and benchstat for comparing pre-0.25 versions with current

it's in https://github.com/grol-io/scriggo-bench though still need to add more of the tests, add risor


Create ehtp.txt

I added Hassania School for Public Works' information. In order to permit the students of EHTP can apply for students' licence

@AyoubTe First stage of verification passed, official domain is ehtp.ac.ma as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@AyoubTe Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thanks


Extract logging logic

Previously logging logic was scattered over OS class implementations
with plenty of duplication. Major changes in this commit:

Extracted logging logic into a separate Logger hierarchy. It allows
easy configuration of logging mechanism depending on compile-time or
run-time configuration.

Implemented RotatedFileLogger which is usually used with StdLogger,
providing persistency of logs. It is often important to be able to
obtain logs of the game even in production to be able to understand
what happened prior to some problem. On mobile there previously was
no way to obtain the logs aside from having the device connected to
your machine.

flush() is not performed in release mode for every logged line. It
is only performed for errors.

I have two small requests:

could you please do an isatty() on the stdout logger and not send the ANSI codes if it's false
could you please change the ANSI codes to named constants or #defines?

Other than that it looks great!

Were mostly ok to merge this one, could you please consider @hpvb changes so that we can merge it ? :)
Great work BTW, this is a cool feature !


fix: Launchpad plugin path: keep namespace

Launchpad plugins path should follow URL approach defined for regular apps as stated in this file below: "cds-plugin-ui5 uses the appid as default route (combination namespace + component)"

@Regloom :
I would suggest to first perform a check to see if cds-plugin-ui5 is loaded before enforcing this convention. (like e.g. https://github.com/geert-janklaps/cds-launchpad-plugin/blob/054ec1bade6d0e91bf8fc8a0ea3c01afcd31205e/src/index.ts#L150C5-L150C80)
This plugin has no hard dependency on cds-plugin-ui5, so we need to make sure that we have backwards compatibility for projects not using cds-plugin-ui5.

I faced the same issue today. TypeScript launchpad plugin fails to load.
JavaScript plugin loads just fine.
My observations are as follows:

Original code of cds-launchpad-plugin

JavaScript plugin URL http://localhost:4004/jsplugin/webapp/Component.js - works fine
TypeScript plugin URL http://localhost:4004/tsplugin/webapp/Component.js - does not work

Solution proposed in this PR (url: component + "/webapp",)

JavaScript plugin URL http://localhost:4004/com.ns.jsplugin/webapp/Component.js - does not work
TypeScript plugin URL http://localhost:4004/com.ns.tsplugin/webapp/Component.js - does not work

My approach to fix it (url: component,)

JavaScript plugin URL http://localhost:4004/com.ns.jsplugin/Component.js - works fine
TypeScript plugin URL http://localhost:4004/com.ns.tsplugin/Component.js - works fine

As this pull request seems pretty much dead and there is no consensus, what the actual fix should be, I suppose I will be better off with my own fork that I will refer to in my project.

@rasmk: do you have a minimal reproducible example I can use to do some analysis?

@geert-janklaps my project is anything but minimal 🙂
But I removed everything unrelated and only left two launchpad plugins: one implemented in JS and one in TS
You can use this repo to reproduce the problem. See README.md for further details.
I hope this helps.


[AMORO-2118] Dynamic chart in transactions page

Why are the changes needed?

Close #2118.
Brief change log

Dynamic chart in transactions page

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Please push complied files


Support same name for static method and instance method

This has been discussed in https://github.com/mdn/content/discussions/5121 and there's general agreement that something needs to be done, but no concrete proposal on the table. https://github.com/whatwg/fetch/pull/1392 will not be possible to document until this is resolved.
@teoli2003 can you label this proposed for Q3 2022?

Done!

This has been discussed in mdn/content#5121 and there's general agreement that something needs to be done, but no concrete proposal on the table. whatwg/fetch#1392 will not be possible to document until this is resolved.
@teoli2003 can you label this proposed for Q3 2022?

AFAIK there is a concrete proposal: https://github.com/mdn/content/discussions/5121#discussioncomment-785747 which is waiting for implementation. We talked about this the other day and thought it would be much easier to implement once we had page types for Web/API, which I think we will get done in the next few weeks (https://github.com/mdn/content/issues/16255).
cc @Rumyra .

Thanks for filing this OWD project proposal!
I'm a bit unclear what is the scope here. It would be nice if that could be clarified so I can then run this against the  OWD prioritization criteria which guides us to make decisions.

Is this asking us to do the page renaming project as per the MDN discussion?
Or to solve the question how to document Response.prototype.json and a static Response.json on MDN/BCD?
Something else?

(We do have page types now.)

Or to solve the question how to document Response.prototype.json and a static Response.json on MDN/BCD?

This is the motivating case, to make it possible to document these at the same time, in a pattern that can be followed by other cases in the future. Even if that's something unsightly like https://developer.mozilla.org/en-US/docs/Web/API/Response/json_static for now, I'd still consider this resolved.

Another problem here which isn't being addressed at the moment AFAIK is slugs: we need a way to have different URLs for static/instance methods/properties. Maybe either:
Request/
Instance_methods
/json
Static_methods
/json
or:
Request/
/json
/json_static
? I think I like the first better, but there's much more stuff in it.

Related BCD issue: https://github.com/mdn/browser-compat-data/issues/16613

See also https://github.com/orgs/mdn/discussions/264 (I wish GitHub added links for discussions).

Things we need for this to get done:

[ ] merge https://github.com/mdn/yari/pull/7335
[ ] merge another Yari PR, to make the sidebars understand short-title
[ ] definitive consensus on page titles, including l10n and any concerns around title length
[ ] many automated PRs to retitle Web/API pages along the lines of https://github.com/orgs/mdn/discussions/248#discussioncomment-3797416
[ ] definitive consensus on slug changes: https://github.com/orgs/mdn/discussions/264
[ ] implement any page moves required by slug changes

Nice to see progress here! The new titles are great.
There's some cleanup to do still I think, e.g.

https://developer.mozilla.org/en-US/docs/Web/API/DOMRectReadOnly says "DOMRectReadOnly.x" as link text (maybe should be just "x"?)
https://developer.mozilla.org/en-US/docs/Web/API/DOMMatrixReadOnly/flipX is listed as an instance method (should be static method)

Nice to see progress here! The new titles are great.

Thanks for the nice feedback!

There's some cleanup to do still I think, e.g.

https://developer.mozilla.org/en-US/docs/Web/API/DOMRectReadOnly says "DOMRectReadOnly.x" as link text (maybe should be just "x"?)

Yes, link text is a separate thing from titles and will take some thinking about. There's a mini-thread about this here: https://github.com/orgs/mdn/discussions/248#discussioncomment-4102050 .
I agree with you that in this context just the member name x is good, but in other contexts link text needs the interface name as well. For that lots of people like lowercasing the initial letter of the interface, like headers.append(), but cases like DOMRectReadOnly make this tricky to automate as we wouldn't want dOMRectReadOnly :). So there are things to work through here. But we will get there.
The next piece though, which is needed to support static and instance members with the same name, is to give them different URLs: https://github.com/orgs/mdn/discussions/264.

https://developer.mozilla.org/en-US/docs/Web/API/DOMMatrixReadOnly/flipX is listed as an instance method (should be static method)

It doesn't seem to be, from the IDL: https://drafts.fxtf.org/geometry/#dommatrixreadonly , am I missing something?

I'm trying to understand what if anything we need to do about domxref here.
I think that after adding the _static suffix, existing domxref links will still work, because of redirects. So for instance: https://github.com/mdn/content/blob/f29d8a648ef7ada05a00c358bfb9e9f67f3bc90d/files/en-us/web/api/abortsignal/index.md?plain=1#L25 will still work, because https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/abort will redirect to https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/abort_static.
This does mean that if people ever make an "instance version" of one of the 42 currently existing static method/property, we will get errors.
For new statics, like https://github.com/mdn/content/issues/21550, people will need to call domxref like:
{{domxref("Response.json_static", "Response.json()")}}

...which is a bit ugly. We could add something to domxref that removes the _static suffix for the link text, so people can do something like:
{{domxref("Response.json()_static")}}

? @teoli2003 , wdyt, am I missing something here?

I think that after adding the _static suffix, existing domxref links will still work, because of redirects. So for instance: https://github.com/mdn/content/blob/f29d8a648ef7ada05a00c358bfb9e9f67f3bc90d/files/en-us/web/api/abortsignal/index.md?plain=1#L25 will still work, because https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/abort will redirect to https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/abort_static.

Yes, they will still work, but this will raise a flaw too (as it is a redirect)

This does mean that if people ever make an "instance version" of one of the 42 currently existing static method/property, we will get errors.

Yes, the redirect file will not like it and we will need to fix it. I don't expect this to happen, though.
If a non-static version of one of these 42 static members is ever created (and we fix the redirect file), the macros will then point to the non-static version.

For new statics, like mdn/content#21550, people will need to call domxref like:
{{domxref("Response.json_static", "Response.json()")}}

...which is a bit ugly. We could add something to domxref that removes the _static suffix for the link text, so people can do something like:
{{domxref("Response.json()_static")}}

We can add this, sounds like a good idea. Anyway, we need to fix the existing ones (we'll do this while fixing flaws), as if we create a non-static version in the future, they will suddenly point to the wrong page.
Macros are painful to maintain: regular links would "just" work and we'll have been automatically fixed already (yarn content move fixes regular MD links).


Upgrade upstream broccoli-sass-source-maps node-sass dep

There's no ability to add this to the repo so I'll file here. Broccoli-sass-source-maps relies on node-sass ^3.1.0 and 3.2.0 was released about a month ago.
Can we bump that to ^3.2.0?

:+1:

I've pushed an update to master, can someone please test for me? I'm don't have any up-to-date Ember.js projects to test on right now. Thanks for pointing out that issues were disabled, that's been fixed.

All the tests are passing on release, beta and canary so I've published v4.0.0. Let me know if there's any issues.

x

The only change I see is to the README.md from 4.0.1 to master. What, specifically, do you want us to test? I have several Ember apps I'd be willing to test on.

Yes, thanks. I've fixed and pushed v4.1.0.


How to get a vertical line before the first tab

I want to set up vertical line before the first tab like Neovim

+1


Properly handle bad access tokens

modified access_via_token(), so that when the embedded verify_token() fails, we actually redirect to the returned redirect, rather than treating it as a user_id
added test for bogus token (confirm redirect to landing)

Perfect - thank you.


add whitelisted addresses to lookup response message

https://github.com/yzernik/squeaknode/pull/372


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.54 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Style hook for chat-messages is commented out

Is there any particular reason why
/*@apply --chat-window-messages;*/

is commented out?
I'd like to  add style hooks to the chat-messages area of the comment.
As a workaround I've uncommented that line on a fork of this repo, but was curious to find out why you disabled it in the first place.

It's because it was renamed to --chat-messages and is used slightly differently. The documentation will be updated today.

Cool, thanks. Looking forward to the update.

Added doc fixes to #0.5.1 (Polymer 1.x based) and released a Polymer 2.0 based hybrid version with #0.6.0. Class-based will be 1.0.


Access to low level (cairo) context

to have opportunity of adding custom information. For example I have several sets of points and I need to draw an error ellipse for every point set. I guess it would be simpler to do using a cairo context.

Any geom* Function has direct access to the cairo context. Have a look at geomPoint and geomLine.

Ah, yes, didn't look.
P.S. I have another small question but don't know where to ask it - here in issues or in DlangScience. For example I need to have uniform scale on all axes.

Setting axis is being worked on. I wanted to add support for logarithmic axis at the same time. Problem is to do that we can't rely on cairo.Context anymore, so it will be a bit of a bigger job.

The latest release added better control of axes. Closing this for now.
Did you manage to get a geomEclipse working? Feel free to re open if you need help for that :)


Spring Boot Starter For Azure Media Services

adds Spring Boot Starter For Azure Media Services
adds checkstyle ,factorypath, springBeans ,bin to git ingore to prevent unnecessary files being commited
Using this instead of #30
cc @yungez @xscript @aovechki

@rajadilipkolli,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@rajadilipkolli really appreciate your work on this.

@ZhijunZhao  I will incorporate the changes and update the PR. I will do it when I get free cycles it might take couple of days


Imagetest local build support

Allow local testing for builds so the dev process is faster, though currently only supported for one test suite at a time and AMD 64 linux
Example invocation (assuming zone, project, and images are set, and this is run from the imagetest folder):
outspath=/home/username/out
./local_build.sh -o $outspath -s disk
cd $outspath
./manager -zone $ZONE -project $PROJECT -images $images -filter disk -local_path $outspath
Alternatively, if invoking from another folder, the imagetest root can be passed in.
If invoking from guest-test-infra,
./imagetest/local_build.sh -o $outspath -s disk -i imagetest

/hold

/unhold

/lgtm


Ringing never stops for calls

Bug description:

When I call someone in Slack or in Skype then ferdi sounds the ringing sound but this continues after the call starts. The only way to stop this is to quit the Ferdi app.
Steps to reproduce:

Go to Skype in Ferdi
Click on someone to call
A browser window opens for the call and you hear the ringing sound
Call is answered but the ringing persists

Expected behavior

The ringing should stop when the call is answered.
Screenshots

Environment:

Operating System:

Ferdi Version:

Server:
macOS Big Sur
Ferdi Version 5.6.0-beta.5 (5.6.0-beta.5.2741)

Debug information:

I also have this issue:
Environment:
Operating System: macOS Big Sur Version 11.2.3
Ferdi Version:
Version: 5.6.0
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
Platform: macOS Big Sur
Arch: x64
Build date: Sun Jul 18 2021 16:17:34 GMT+0100 (British Summer Time)
Git SHA: 7b09fe7
Git branch: release
Server:
Debug information:


Back to treating rdfa as nodes

I'm really glad we had time to try using marks! In the end I think we can conclude it creates more problems than it solves.
This pr reverts the inline_rdfa from a mark back to a node and removes associated datastore logic and nodespecs that served as workarounds for invisible rdfa. It also includes adjusted list commands to make them work as expected (aka the reason we tried marks in the first place).
Still feel like there's room for improvement but at the moment we don't even really understand what works and what doesn't, so let's continue like this.
Other things that seem interesting to play with:

normalize rdfa on initial load, and work with a clear distinction of subject/predicate/object nodes in the PM schema
try a custom datastructure for storing the triplestore, one that's more aware of the document tree. PM's decoration tree could serve as inspiration there. There's still a dream of a purely rdf way of inserting content and knowledge there

thanks, will look into those before merging

in the end we won't do this yet, but let's keep the branch for future reference


[Bug] Mesh viewer is blank for Print Screen captures only

Description

Instead of mesh there is grey Void
Steps to reproduce
I tell RenderDoc to launch my application and auto-capture on frame 3 or 4 or something. I scroll through the Event Browser and select a particular draw call. I open the Mesh Viewer pane. It shows me my mesh, yay expected behavior ✨
I tab back into my still-running application. I adjust the camera and take another capture using the "print screen" button. Again I scroll through the Event Browser, select a draw call, and open the mesh viewer pane. There is no mesh, only gray 😞
I save the capture. I close RenderDoc and my application. I open RenderDoc. I open the saved capture. Now my meshes display. ✨
I try testing again. I close RenderDoc and my application. I take a capture with Print Screen. The bug reproduces, no mesh 😞
Analysis
The problem does not occur for captures taken automatically by the Launch Application pane and does not occur with captures loaded with Open Capture. It only happens for captures taken with Print Screen after the application has been started.
Because the same capture that could not display meshes was able to display meshes when I saved the capture and reloaded it, I conclude the problem is with the mesh viewer UI and the capture was fine.
I have the saved capture. I can send it to you but suspect you will find only that it is a perfectly good capture. I would prefer to send it via email or something rather than post it publicly on github if this is possible.
Environment
I am running a newly downloaded Renderdoc v1.6 on Windows 10 10.0.18363 Build 18363. AMD Radeon R9 390 Series graphic card, "Radeon Software Version 20.2.1" (I think this is driver version??). My application uses OpenGL and it is drawing into a framebuffer vended from the Oculus API.
I have not tried rebooting the computer.

This is unfortunately a known AMD driver bug. With OpenGL captures, any time you open a second capture (all displays will be super "zoomed in" essentially, so what you're seeing in your screenshot is an extremely zoomed version of the checkerboard background.
Unfortunately until a fix lands in AMD's drivers the only known workaround is to restart RenderDoc every time you open a capture. I've checked with AMD and there isn't another hack in the meantime :(.
Also for next time please use the bullet list template for the environment, it's a bit easier to parse.


jedi-language-server starts running after exit vscode

Issue Type: Bug
steps to reproduce

start vscode and then do nothing
exit vscode
after exiting, cpu usage immediately goes up, due to this process: .vscode/extensions/ms-python.python-2021.3.680753044/pythonFiles/run-jedi-language-server.py
if Launch with code --disable-extensions, this issue doesn't occur

Extension version: 2021.3.680753044
VS Code version: Code 1.55.1 (08a217c4d27a02a5bcde898fd7981bda5b49391b, 2021-04-07T15:01:24.315Z)
OS version: Linux x64 4.15.0-140-generic snap

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 2899)

GPU Status
2d_canvas: unavailable_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
1, 1, 3

Memory (System)
15.56GB (7.31GB free)

Process Argv
--no-sandbox --crash-reporter-id ca029753-a8f9-43db-8221-f34ad9a4dfb9

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry914:30276682
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554:30281908
pythontb:30283811
openwslfolder:30282073
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30276952
pythondataviewer:30285071
vscus158:30286553

@lliu-kc This should be fixed in the insiders version. Can you try with that? You can always download and install latest insiders build form here https://pvsc.blob.core.windows.net/extension-builds/ms-python-insiders.vsix .

Closing since this doesn't happen anymore.


Navbar is not sticky in contact page

I want to solve this problem .can you allow me to solve this problem??

@Aman1143  since it's just a one short page so sticky navbar is not required


[Beam-517] Check versions of pip and cython

I have added a check so that the setup fails if pip <= 0.7.0 is not installed.
In addition, I have added cython as an optional dependency, so that it's installed only if the user decides to do so, e.g., via
pip install -e .[cython]
The Readme file has also been updated, although I think that it may need some refactoring in the future, when/if the project is packaged and deployed on pypi as apache-beam. In that case, it would be possible to execute something like:
pip install apache-beam[cython]

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

For more details about the issue, see the jira issue: https://issues.apache.org/jira/browse/BEAM-517

R: @jbonofre

Python build failed. I'm checking why.

Hey JB, I'd like to make sure the owners of the Python SDK/runner are the ones to review this code, and then maybe they can ask you to merge (if @robertwb is not available).
R: @charlesccychen @chamikaramj @mariapython

@mbuccini Thank you for doing this.
I have a concern about making cython an optional dependency.
If a user has cython already installed and they installed the beam package as pip install -e . this will not check for the required version of cython but still use it. Since the setup code will try to import it.
Could we check the version requirement similar to the one check you do for pip? If cython is importable use pkg_resources to get the version and compare against our requirement.

@dhalperi agree. Let's the Python guys review it ;)

Mmh, it seems that Travis has an older version by default. However, the fact that Jenkins never failed before implies that the environments are different (some tests use the option "--no-binary" of pip 7+, e.g., test_no_staging_location). I wonder how we should proceed now.

I propose this, keep the change in the README. And convert the exceptions in the setup.py to soft warnings (log messages) that says something along the lines of "You are using version ... of pip/cython however at least ... version of that is recommended.".
This also makes sense for our users. For cython SDK works with older versions, for pip SDK works with older version except for one case where we use the --no-binary flag. There might be some users with older version of a pip and who never use this feature, we do not want to break them. And they will also be aware that if they experience a problem in the future they should first try upgrading their pip.

@mbuccini any update on this one?

Travis failure is due to https://issues.apache.org/jira/browse/BEAM-721 and not related to this change.
I believe this change is ready except for the one comment I added above.

This change LGTM.
The last travis error is still due to https://issues.apache.org/jira/browse/BEAM-721 and not related to this change. (It might be useful to rerun travis since the underlying issue is fixed in https://github.com/apache/incubator-beam/pull/1068)

@mbuccini Is this PR ready to be merged?
I am adding R: @robertwb for review and merge.

@aaltay yeah, I think so!

This PR has been merged and can be closed.


Cannot create using alias and InvokableFactory

I try to get service using alias. Alias is linked to factory with InvokableFactory. I get exception:
InvokableFactory requires that the requested name is provided on invocation; please update your tests or consuming container

After debug I have found that requested name in InvokableFactory is alias name.
It's occur in 2.7.

Which version - v2.7.2 or v3?
On Jan 13, 2016 6:10 AM, "Witold Wasiczko"<EMAIL_ADDRESS>wrote:

I try to get service using alias. Alias is linked to factory with
InvokableFactory. I get exception:
InvokableFactory requires that the requested name is provided on invocation; please update your tests or consuming container
After debug I have found that requested name in InvokableFactory is alias
name.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-servicemanager/issues/66.

@weierophinney 2.7. I have provided falling test for this case

That's really odd; the changes made were introduced due to testing plugin managers under identical circumstances (e.g. zend-barcode). However, I've imported your test case locally, and can verify it. Looking into a solution now.

Oof, figured it out; it's due to the fact that v2 canonicalizes the names when storing the keys for the factories. In this particular case, the InvokableFactory is receiving zendtestservicemanagertestassetinvokableobject as the $canonicalName, which, if it weren't canonicalized, would be correct.
The reason the change worked in zend-barcode is due to having the $autoAddInvokableClass flag enabled; all the various plugins in that component are invokable classes, and, as such, when the plugin manager cannot resolve to a workable factory, that logic kicks in.
A patch will be tricky, but it's a priority for our migration, so I'll be working on it today.

Thanks, it makes a sense

this seems wrong:

    public function testCanGetServiceUsingAliasAndBuildByInvokableFactory()
    {
        $this->serviceManager->setAlias('foo', 'ZendTest\ServiceManager\TestAsset\InvokableObject');
        $this->serviceManager->setFactory('ZendTest\ServiceManager\TestAsset\InvokableObject', 'Zend\ServiceManager\Factory\InvokableFactory');
        $result = $this->serviceManager->get('foo');
        // following assertion was corrected: (you were comparing against a string)
        $this->assertInstanceOf('ZendTest\ServiceManager\TestAsset\InvokableObject', $result);
    }

@Ocramius Yes; found that when working on my patch locally as well. It still fails; almost have a patch ready.

@Ocramius fail. However as @weierophinney said: still fails.

Fixed with #69.


[WIP] snowpack dev

Background: https://www.pika.dev/npm/snowpack/discuss/114
Right now we get a lot of freedom from the fact that we let you use any dev server that you'd like. We even have a list of recommended here in our docs: https://www.snowpack.dev/#installing-a-dev-server
But...
 There's no reason that Snowpack can't have a similarly easy dev experience to Create React App or webpack-dev-server, but without the heavy toolchain. This would be huge for adoption, since setup continues to be a tricky part for new users.
Right now, this WIP branch pulls in the meat of @lukejacksonn's  servor, with most of the opinionated config removed. This alone actually gets you pretty far (it's already enough for pika.dev's local dev environment). But, I want to keep adding a few features on top of this:

hot module replacement for ESM: This would be incredible if we could crack it for the general user. See previous art  https://github.com/SevInf/heiss. /cc @SevInf
If the project is TypeScript, run tsc --watch via snowpack dev and report issues.
Zero babel config environment: We should provide a default babel config for you, based on what we know about your project (if TypeScript, add preset-typescript. If React, add preset-react. Etc.) This would give a similar "zero config" experience as Create React App.
We may want to pull this into its own package.

Creating this PR now for early feedback, and to collect ideas for addition features/behaviors that people would like to see. Please comment below if you have any!

Given that this is purely additive and marked as experimental, I'm fine with merging now and then continuing to work on it off of master.
@christophe-g curious to hear your thoughts on this as well, given your work on Toast. If we could offer you a great dev server, would you be interested in building Toast on top of it? (we bring the generalized Hot Module Replacement, you bring the more opinionated app layout)

sounds cool. Toast will need the HMR stuff talked about here at some point too so if toast can take advantage of a snowpack-offered server that would be great(using servor right now personally). Toast will also need to be able to programmatically control the server in some way. As a simple example: Running a toast development process and the webserver at the same time

Feature request: if at all possible, have the HMR/live-reloading support projects with multiple .html files, instead of just one.
This feature is missing from every dev server I've tried (except for Parcel 1's, but it broke at some point), which is weird because that's what websites are: sets of .html files!

Yes! @jonikorpi +1, that's another great example of a bundler/tooling limitation (chunking complexity skyrockets when dealing with multiple entrypoints) that we don't have to deal with

Made some good progress on this this week! Here's an early look:

Up next: Smarter warnings if we see you trying to ESM import CSS, images, fonts, etc.
Note: you still need to provide your own, already set-up Babel config. Part of this work will be to decide how much is the responsibility of snowpack dev, and how much is the responsibility of a create-snowpack-app starter template that can give you something like an already-configured babel config.

Just want to say how I would appreciate such a thing: I was seduced by the 'no tooling' experience and it's been a few hours of frustration to setup a React+TS project.
I don't think I will use snowpack without an 'drop in' experience like webpack/create-react-app provides.

@lodi-g thanks! Snowpack is still a young project, but features like this can help lower the bar for new users. The vision coming together here would pair nicely with a create-snowpack-app project that got you up and running quickly, and maintained some config for you.
Did some more work on this this this weekend, and we now have the ability to define/configure different pluggable build tools into your dev environment. This will useful for supporting PostCSS, TypeScript, etc. without the maintenance cost/weight of a whole new "loader" plugin system that you'd find in Webpack, Parcel, etc. Instead, It feels a lot more like pluggable npm/yarn scripts.

also good news: config support is finally in a good enough spot that you can start to play around with this without modifying the code itself. Just add the following to your snowpack.config.js/json file:
{
  // ...
  dev: {
    port: 3000,
    dist: 'dist', // the directory where you build/serve your site, usually either dist/ or cwd
    fallback: 'shell.html', // optional, always serve this HTML instead of a 404, good for SPAs
  },
  // "scripts": Different tasks to run during development, similar to package.json scripts
  // Simple, uniform format for each: "category:name::optional-modifier"
  // Run `snowpack dev` to see it in action
  scripts: {
    'lint:tsc': 'tsc --noEmit',
    'lint:tsc::watch': '$1 --watch',
    'build:static': 'cp -r public/* dist/static',
    'build:snowpack': 'cp -r web_modules dist/static/web_modules',
    'build:babel': 'babel src --out-dir dist/static/js --extensions ".ts,.tsx"',
    'build:babel::watch': '$1 --watch'
  }
}

The "scripts" solution was unexpected, since I'd originally assumed that we'd be a live server transforming source code as we served it (ex: ts -> js). While that was all technically possible, in practice you ended up using your dev file structure during local development and then a totally different set of URL/file paths for all of your assets in production. I tried this out for a while and even confused myself a few times, and that was before even getting to how third-party plugins might work.
This "scripts" solution solves that by instead helping you build your application and then serving that simple built directory. That way you are guaranteed to have the same URL layout in both dev and prod.
It's simple, lightweight, and a lot less magic. Funny enough, it may also end up solving our other big unanswered question: "how do I build all of my other assets (not just JS) without the complexity of a bundler?"

Added the ability to "mount" directories for pass-through file serving during dev, which removes the need for boilerplate,  expensive, and sometimes overwriting file copies of your public directories. This also keeps us going down the path of "building" your app, where we would go ahead and copy these files during a traditional (not watching) build.
   dev: {
     port: 3000,
     dist: '../../dist',
     fallback: 'shell.html',
+    mount: [
+      // Mount your web_modules/ directory to "/web_modules/*" URL path
+      'web_modules',
+      // Mount your public/ directory to "/*" URL path
+      ['public', '.'],
+    ],
   },
   scripts: {
-    'build:static': 'cp -r public/* dist/static',
-    'build:snowpack': 'cp -r web_modules dist/static/web_modules',
     'build:tsc': 'tsc --noEmit',
     'build:tsc::watch': '$1 --watch',
     'build:babel': 'babel src --out-dir ../../dist/static/js --extensions ".ts,.tsx"',
     'build:babel::watch': '$1 --watch',
   },

   dev: {
     port: 3000,
     dist: 'dist',
     fallback: 'shell.html',
     mount: [
-      'web_modules',
+      ['web_modules'],
       ['public', '.'],
     ],
   },
   scripts: {
     'lint:tsc': 'tsc --noEmit',
     'lint:tsc::watch': '$1 --watch',
-    'build:babel': 'babel src --out-dir ../../dist/static/js --extensions ".ts,.tsx"',
+    'build:babel': 'babel src --out-dir $DIST/static/js --extensions ".ts,.tsx"',
     'build:babel::watch': '$1 --watch',
   },

"snowpack build" has been added! "build" now writes your website build to disk, so that "dev" can now be completely ephemeral (no files written to disk during development). Also cleaned up the mount syntax based on some more user testing.
I think that we're close to feature complete here! The code needs a ton of cleanup and testing, and then we'll need docs, but so far this feels like a great foundation to build on top of. Once this is merged, we can also get started on a "create-snowpack-app" / "snowpack-scripts" project for a drop-in, zero-config experience.

Started work on the Create Snowpack App templates, and added some differentiation between the different script categories that we support:

"build:*" - build a single file type, on demand. This is the preferred option, as long as your tooling supports simple unix piping to the command (stdin  -> command -> stdout).
"buildall:*" - build multiple files at once. Useful for tooling that can only run holistically on your app (ex: tsc).
"lint:*" - Useful for running something like tsc --no-emit to do type checking during development.

WIP Create Snowpack App (CSA) already supports both starter CRA templates (JS & TS). Even better,  it's naturally configurable so that you can gradually "eject" different file types. Will post an example when it's closer to ready.

re: detecting useful output from your scripts section, you could support the informal 'problem matchers' format which both VSCode and GitHub Actions support for a few tools you care about but somehow expose the regex for others
https://code.visualstudio.com/Docs/editor/tasks#_processing-task-output-with-problem-matchers

https://github.com/actions/setup-node/blob/master/.github/tsc.json
https://code.visualstudio.com/docs/editor/tasks#_defining-a-problem-matcher

Ah that's fantastic! I built a custom pattern matcher for the tsc --watch output, but was curious how we could make that pluggable for more / 3rd party matchers.
It would be great if we could just borrow from vscode's existing matchers, although they seem to be pretty coupled to the vscode codebase. Also it may be worth doing something less complex. VSCode is trying to parse a ton of different info in theirs, but ince we're a CLI, we can show the actual CLI output to the developer. All we really need is to be able to detect "status" (GOOD, RUNNING, ERROR).

Alright, we're now running successfully on 3 different apps! (pika.dev's super custom repo layout, and then two Create Snowpack App starter apps, JS + TS). We also got test running working in CSA, which was the last of the 4 main create-react-app 'scripts' to support. Major items left to do:

Get a POC going of a zero-config bundle post-build step via Parcel.
Clean up the code!
docs + get CSA repo ready to go

  // snowpack.config.js
  dev: {
    port: 3000,
    src: 'src',
    out: 'build',
    dist: '/_dist_',
+   bundle: process.env.NODE_ENV === 'production',
    fallback: 'index.html',
-   mount: [['public', '.'], ['web_modules', '/web_modules']],
  },
  scripts: {
+   'mount:public": "mount --from public --to /',
+   'mount:web_modules": "mount web_modules',
    'build:js::ts,tsx': 'babel --no-babelrc',
    'lint:tsc': 'tsc --noEmit',
    'lint:tsc::watch': '$1 --watch',
  },

We're feature complete! The new, optional "bundle" option passes your final build through Parcel for a final, automatic production optimization. And the new "mount:" script cleans up the original ad-hoc config for serving local directories at URL paths (ex: public/foo/bar.ext is served out of /foo/bar.ext in the final build).
Now its time for code cleanup and user feedback. My goal for the weekend is to create some new docs, clean up the code, and hopefully get Create Snowpack App in front of a few people to test. I'd love to launch with a few different templates, and not just React.

  // snowpack.config.js
  dev: {
    port: 3000,
    src: 'src',
    out: 'build',
    dist: '/_dist_',
    bundle: process.env.NODE_ENV === 'production',
    fallback: 'index.html',
  },
  scripts: {
-   'mount:public": "mount --from public --to /',
+   'mount:public": "mount public --to /',
    'mount:web_modules": "mount web_modules',
-   'build:js::ts,tsx': 'babel --no-babelrc',
+   'build:ts,tsx': 'babel --no-babelrc',
    'lint:tsc': 'tsc --noEmit',
    'lint:tsc::watch': '$1 --watch',
+  "plugin:svelte": "@snowpack/svelte-plugin",
  },

This branch is now available to install as snowpack@next, but be warned it is VERRRRY rough still. I keep saying it's time to clean it up, but now I really mean it. Not just for stability, but speed too (we're doing some very inefficient things with the file system and zero caching).
in addition to cleaning up the script syntax a bit more, i also added the ability to define scripts as JS plugins for when a bash script just won't cut it. This ended up being required for the more complex transformations like Svelte and Vue which involves building JS, CSS, and HTML all in one file.
We now have beta plugins for both Svelte and Vue, which means that our "Create Snowpack App" will be completely framework independent /w multiple official templates to choose from. This is a wild idea (Create React App for everyone!) if we get the execution right.
I hope to have an actual stable snowpack@next plus a preview of CSA available sometime this week.
Some Screenshots!

If you've made it this far, thanks again for reading. Not yet ready to make the Create Snowpack App repo public, but I can share a sneak preview:
# run this :D
npx create-snowpack-app new-dir --template @snowpack/app-template-react [--use-yarn]

Based on the new docs written for #291, the following work is now required before we can cut v2.0.0:
This PR

[ ] rename 'mount:' script to 'copy:'
[ ] add babel macro support in CSA

Followup PR

[ ] cleanup config options to match new interface, remove deprecated options
[ ] --source pika should be default on, but still opt-out allowed
[ ] snowpack add/rm support
[ ] "webDependencies" should only be allowed in package.json, needed for add/rm to work

Getting ready to merge this PR to master soon (possibly tonight) with a follow-up PR to tackle the remaining cleanup work needed for a v2 release.


using SDL_getenv_unsafe (renamed of SDL_getenv) until we decide if th…

This is a fix since SDL_getenv has been removed with the arrival of a new thread-safe API. For now I have thus replaced usages of the old name in the SDL_mixer extension by the new name SDL_getenv_unsafe.
I am too unfamiliar with the library to implement the new multi-threaded API for now. I am slowly getting by bearings with this library.
Thank you,

I guess the proper patch to use current SDL3 apis should be like the following. CC: @slouken
diff --git a/examples/playmus.c b/examples/playmus.c
index 97a67b4..4812b99 100644
--- a/examples/playmus.c
+++ b/examples/playmus.c
@@ -205,7 +205,7 @@ int main(int argc, char *argv[])
     Mix_VolumeMusic(audio_volume);

     /* Set the external music player, if any */
-    Mix_SetMusicCMD(SDL_getenv("MUSIC_CMD"));
+    Mix_SetMusicCMD(SDL_GetEnvironmentVariable(SDL_GetEnvironment(), "MUSIC_CMD"));

     while (argv[i]) {
         next_track = 0;
diff --git a/src/codecs/music_timidity.c b/src/codecs/music_timidity.c
index 726a7f9..cdbc8a0 100644
--- a/src/codecs/music_timidity.c
+++ b/src/codecs/music_timidity.c
@@ -59,7 +59,7 @@ static int TIMIDITY_Open(const SDL_AudioSpec *spec)

     (void) spec;

-    cfg = SDL_getenv("TIMIDITY_CFG");
+    cfg = SDL_GetEnvironmentVariable(SDL_GetEnvironment(), "TIMIDITY_CFG");
     if(!cfg) cfg = Mix_GetTimidityCfg();
     if (cfg) {
         return Timidity_Init(cfg); /* env or user override: no other tries */
diff --git a/src/effects_internal.c b/src/effects_internal.c
index a1d81f7..f110867 100644
--- a/src/effects_internal.c
+++ b/src/effects_internal.c
@@ -37,7 +37,7 @@ int _Mix_effects_max_speed = 0;

 void _Mix_InitEffects(void)
 {
-    _Mix_effects_max_speed = (SDL_getenv(MIX_EFFECTSMAXSPEED) != NULL);
+    _Mix_effects_max_speed = (SDL_GetEnvironmentVariable(SDL_GetEnvironment(), MIX_EFFECTSMAXSPEED) != NULL);
 }

 void _Mix_DeinitEffects(void)
diff --git a/src/music.c b/src/music.c
index ed42ea0..1efd381 100644
--- a/src/music.c
+++ b/src/music.c
@@ -1495,7 +1495,7 @@ SDL_bool Mix_SetSoundFonts(const char *paths)

 const char* Mix_GetSoundFonts(void)
 {
-    const char *env_paths = SDL_getenv("SDL_SOUNDFONTS");
+    const char *env_paths = SDL_GetEnvironmentVariable(SDL_GetEnvironment(), "SDL_SOUNDFONTS");
     SDL_bool force_env_paths = SDL_GetHintBoolean("SDL_FORCE_SOUNDFONTS", SDL_FALSE);
     if (force_env_paths && (!env_paths || !*env_paths)) {
         force_env_paths = SDL_FALSE;

I guess the proper patch to use current SDL3 apis should be like the following. CC: @slouken

Yep, this looks good.

I guess the proper patch to use current SDL3 apis should be like the following. CC: @slouken

Yep, this looks good.

OK, I'll be updating SDL_mixer and SDL_image. Leaving sdl2-compat to you.

Thank you sezero I understand how to new call should be used.

OK, main (SDL3) branches of SDL_mixer and SDL_image are patched now.


Update texture.pyx

texture_create_from_data  defaults to  mipmap=False
so if we try, and fail to find  im.have_mipmap
then we pass, and continue with default value.
solves this issue:
flip = Texture .create_from_data(self .image, mipmap = False) .flip_horizontal()
File "kivy/graphics/texture.pyx", line 585, in kivy.graphics.texture.texture_create_from_data (kivy/graphics/texture.c:7399)
AttributeError: 'Sprite' object has no attribute 'have_mipmap'

I don't really work with core (at least not with this part), but try-except-pass seems bad enough to me. At least ping the user with Logger that something happened.

is self.image here an ImageData instance, what is the Sprite class here ? you don't give a lot of info about what you are trying to do.
Even if the usage is correct, you'd want to use hasattr('has_mipmap', im) instead of try/except/pass.


silx.io.h5py_utils: improve log

For a specific version of h5py I get the following log each time I access a file.
Which makes logs complex to read.
        # File locking behavior has changed in recent versions of libhdf5
        if HDF5_HAS_LOCKING_ARGUMENT != H5PY_HAS_LOCKING_ARGUMENT:
            _logger.critical(
                "The version of libhdf5 ({}) used by h5py ({}) is not supported: "
                "Do not expect file locking to work.".format(
                    h5py.version.hdf5_version, h5py.version.version
                )
            )

Could we consider emitting it one time only and / or only when locking will be requested ? The second option seems to me the most appropriate. I can do a PR if we agree on the behavior.

discussed in #4092


Certificate vs Client Secret flow

So I finally have basic examples of both Certificate and Client secret token requests working using our organization's tenant. Now I'm trying to figure out why use one vs the other?  Is it just a matter of taste or security policy to choose the secret vs certificate flow?  Or are their functional or usability differences?

There aren't any functional differences per se... It's mostly a tradeoff between management overhead/ease of use and security.  For some applications a shared secret will be perfectly sufficient, while others will have strict security policies in place.
The one usability difference I can think of is that at this time you can manage client secrets in the Azure Portal, while certifcate mgmt must be done through powershell or through the application manifest.


Non-null value for "tcp_acceptor_port" parameter

Operation System: Windows 10
Beaker Version: <IP_ADDRESS>
safe-browser.crust.config file has a non-null value for "tcp_acceptor_port" parameter (5483). I would understand this value for a vault. But for a client program that seems a bit unsafe.
If there isn’t any reason for this value, then I suggest putting back the null value for this parameter.

Thank you for helping us by inputting this concern.
Tasked for review: https://maidsafe.atlassian.net/browse/MAID-2372

This is fixed in beaker browser v0.8.1.


Can't build/debug - "Failed to apply plugin [id 'com.android.internal.application']"

Hello!
I have the most recent version of android studio, of the project (on master branch), of kotlin, gradle and windows 10. Still can't build.
This is what it says:
Build file 'C:\Users\<user>\AndroidStudioProjects\architecture-samples\app\build.gradle' line: 1

A problem occurred evaluating project ':app'.
> Failed to apply plugin [id 'com.android.internal.application']
   > The option 'android.enableUnitTestBinaryResources' is deprecated.
     The current default is 'false'.
     It has been removed from the current version of the Android Gradle plugin.
     The raw resource for unit test functionality is removed.

I've basically only cloned it and now attempted to start it on my OnePlus 8. What am I doing wrong?
/ Lorentz

Fixed it locally by setting android.enableUnitTestBinaryResources=false in gradle.properties, for anyone else who runs into the issue.

for my case it was android.enableBuildCache=true, its is removed from gradle version 7, just comment or remove #android.enableBuildCache=true

There is no need in newer version of Android for enableUnitTestBinaryResources in the file since it has been deprecated and is set to false by default.
Simply go to the gradle.properties file and remove this line entirely and your app should compile.
android.enableUnitTestBinaryResources=true

Fixed it locally by setting android.enableUnitTestBinaryResources=false in gradle.properties, for anyone else who runs into the issue.

Not worked dude jsjsj


Automated cherry pick of #4168: fix: 避免创建安全组规则时未能接收到安全组参数

Cherry pick of #4168 on release/2.12.
#4168: fix: 避免创建安全组规则时未能接收到安全组参数

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@59ec24d). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #4169   +/-   ##
==============================================
  Coverage                ?   6.88%
==============================================
  Files                   ?     501
  Lines                   ?   84782
  Branches                ?       0
==============================================
  Hits                    ?    5834
  Misses                  ?   78454
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.88% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ec24d...0dbd655. Read the comment docs.

/lgtm

/approve


Fix github action rerun failed

What is the purpose of the pull request
Fix github action rerun failed
update resource service test

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev-resource-tree@865c95f). Click here to learn what that means.
The diff coverage is 85.71%.

@@                 Coverage Diff                  @@
##             dev-resource-tree    #2067   +/-   ##
====================================================
  Coverage                     ?   24.44%
  Complexity                   ?     1316
====================================================
  Files                        ?      317
  Lines                        ?    16880
  Branches                     ?     2079
====================================================
  Hits                         ?     4127
  Misses                       ?    12293
  Partials                     ?      460

Impacted Files
Coverage Δ
Complexity Δ

.../org/apache/dolphinscheduler/api/enums/Status.java
100% <100%> (ø)
4 <0> (?)

...dolphinscheduler/api/service/ResourcesService.java
63.58% <83.33%> (ø)
65 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865c95f...68a2797. Read the comment docs.


HADOOP-18446. Add a re-queue metric to RpcMetrics.java to quantify the number of re-queue RPCs

Description of PR
Add a reQueue metric to RpcMetrics.java to quantify the number of RPCs reQueued. Because Observer NameNode will re-queue the rpc if the call processing should be postponed.
There is no any metric to quantify the number of re-queue RPCs, so I think we should do it.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 36s

trunk passed

+1 :green_heart:
compile
25m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
22m 16s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 35s

trunk passed

+1 :green_heart:
mvnsite
3m 49s

trunk passed

+1 :green_heart:
javadoc
2m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 50s

trunk passed

+1 :green_heart:
shadedclient
26m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 28s

the patch passed

+1 :green_heart:
compile
24m 56s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 56s

the patch passed

+1 :green_heart:
compile
22m  6s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 27s
/results-checkstyle-root.txt
root: The patch generated 2 new + 303 unchanged - 0 fixed = 305 total (was 303)

+1 :green_heart:
mvnsite
3m 45s

the patch passed

+1 :green_heart:
javadoc
2m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 53s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m  1s

the patch passed

+1 :green_heart:
shadedclient
27m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 32s

hadoop-common in the patch passed.

+1 :green_heart:
unit
383m 58s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 45s

The patch does not generate ASF License warnings.

643m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4871

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 465687b9ebe0 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 224a9451a11d44f7f7a04c6b0e4c306ca3bbfa91

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/1/testReport/

Max. process+thread count
2070 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@xkrogen Sir, can you help me review this patch? This metric is used to quantify the number of RPCs reQueued in Observer NameNode,

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 51s

trunk passed

+1 :green_heart:
compile
25m 40s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
22m 11s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 28s

trunk passed

+1 :green_heart:
mvnsite
3m 47s

trunk passed

+1 :green_heart:
javadoc
2m 48s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 51s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 51s

trunk passed

+1 :green_heart:
shadedclient
26m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 27s

the patch passed

+1 :green_heart:
compile
24m 38s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 38s

the patch passed

+1 :green_heart:
compile
22m 13s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 20s
/results-checkstyle-root.txt
root: The patch generated 1 new + 303 unchanged - 0 fixed = 304 total (was 303)

+1 :green_heart:
mvnsite
3m 44s

the patch passed

+1 :green_heart:
javadoc
2m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 55s

the patch passed

+1 :green_heart:
shadedclient
27m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 31s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
379m 34s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
3m 17s

The patch does not generate ASF License warnings.

639m  2s

Reason
Tests

Failed junit tests
hadoop.http.TestHttpServer

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4871

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d294f6262762 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce4297011ac789ab917fbd4db90f4da603d54a56

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/3/testReport/

Max. process+thread count
2449 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 16s

trunk passed

+1 :green_heart:
compile
29m 26s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 18s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 33s

trunk passed

+1 :green_heart:
mvnsite
3m 58s

trunk passed

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m  9s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 16s

trunk passed

+1 :green_heart:
shadedclient
27m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s

the patch passed

+1 :green_heart:
compile
27m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
27m 33s

the patch passed

+1 :green_heart:
compile
23m  6s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
23m  6s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 24s
/results-checkstyle-root.txt
root: The patch generated 1 new + 303 unchanged - 0 fixed = 304 total (was 303)

+1 :green_heart:
mvnsite
3m 56s

the patch passed

+1 :green_heart:
javadoc
2m 51s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 52s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m  6s

the patch passed

+1 :green_heart:
shadedclient
27m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 27s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
369m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 27s

The patch does not generate ASF License warnings.

641m 50s

Reason
Tests

Failed junit tests
hadoop.http.TestHttpServer

hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4871

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 33b6a9371a95 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce4297011ac789ab917fbd4db90f4da603d54a56

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/4/testReport/

Max. process+thread count
3144 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4871/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The failing test in TestHttpServer was just added 2 days ago in PR #3972 and has been failing consistently since it was added (see this comment). So we can ignore that failure.
Merging to master, thanks for the contribution @ZanderXu !


Add {category} permalink template variable

Add a {category} permalink template variable that takes a posts categories and concatenates them alphabetically into a url slug, e.g:
/category-a/category-b/

Implemented by 1c7fbf51e0f5b4f41f77a499b9fb4939cc8eceb1


test the performance on fashion-mnist

Great job, it would be interesting to see how it performs on Fashion-MNIST. It's a drop-in replacement of the original MNIST for benchmarking algortithms. Dataset is available here https://github.com/zalandoresearch/fashion-mnist

Thank you. Yes, you can try, would be interesting to see!


Add rbi definition for Enumerator#+

Motivation

Was added in Ruby 2.7.0
https://ruby-doc.org/core-2.7.0/Enumerator.html#method-i-2B

Test plan

I am not familiar with this repo at all. If I need to update some tests somewhere please let me know!

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_R0sUDpfeBncnJk
→ https://go/builds/bui_R0sUA6I6yn8kmy
→ https://go/builds/bui_R0sUQh9cW5UwnX

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_R2mgSnOK94bcvx
→ https://go/builds/bui_R2mgw0A5432PZy
→ https://go/builds/bui_R2mgmlWET2yN33

Sorry for the delay. There was a problematic commit that had landed on Sorbet master that needed to be fixed, which made it look like your change introduced failures. We've resolved that, re-tested, and things look good.
Thanks for the ping and thanks for the contribution.


Disable specific Dates?

I've been looking though the source code and there doesn't seem to be a way to be able to disable specific dates, particularly if they're in the in min-max range. Am I wrong about this?

You're right, there is currently no way to disable specific dates. If somebody wants to implement this functionality, feel free to open a PR.

+1. I want that useful option. Only enable specific ates.

How that would be ideal to work? Set an array of disabled dates? Or maybe just a function to disable a specific date and defer logic to developer?

I've added an isDisabled(date, mode) callback that developers can override to disable certain dates. Thanks @rodrigosiqueiradev for the suggestion.

Hi I have overrided the isDisabled callback function to return true however it doesn't seem to disable the date. Also the function doesn't seem to get called ?
https://jsbin.com/qofigoz/edit?html,js,console,output

how to disable selected start date after dates are disabled

I've called a function disable_date(month_year,date_value) and then added a disabled class,
but this will only change the date of the current month as i don't know the "on monthChange()". I'll update it when ever i resolve it.
https://codepen.io/jittu1992/pen/xyEdYd


GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python PreCommit

Failures look like known flakes in MacOS

Failures look like known flakes in MacOS

FYI I think I fixed the flake in data_plane_test in #12637, so let me know if you see it again.

FYI I think I fixed the flake in data_plane_test in #12637, so let me know if you see it again.

Yep thank you for the fix! This run was before that was merged

Failure is due to flake BEAM-10866


How to provide secrets via dynamic id in an array?

""apimCertificates": [
{
"reference": {
"keyVault": {
"id": "[resourceId(parameters('vaultSubscription'), parameters('vaultResourceGroupName'), 'Microsoft.KeyVault/vaults', parameters('vaultName'))]"
},
"secretName": "[parameters('secretName1')]"
}
}
{
"reference": {
"keyVault": {
"id": "[resourceId(parameters('vaultSubscription'), parameters('vaultResourceGroupName'), 'Microsoft.KeyVault/vaults', parameters('vaultName'))]"
},
"secretName": "[parameters('secretName2')]"
}
}
]
Or infact generate this via a copy loop.
When we use this, we get the error that the parameter is not expected. i.e it is not decoding the reference and getting the secret, but creating an object with the whole json containing the reference.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70505efb-d7ac-0dbc-6b57-2ce6a2a78ef2
Version Independent ID: 0d5a06ac-190e-78d2-c031-ca9d5c09347f
Content: Key Vault secret with Azure Resource Manager template
Content Source: articles/azure-resource-manager/resource-manager-keyvault-parameter.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@vicky08 - is apimCertificates defined in the parameters section of your nested template? You would have to break it into two separate parameters as you can't add the array brackets around it.

#please-close


'||' isn't supported for the 'when' context value of explorer view?

Steps to Reproduce:
I'd like to show customized explorer view with combined conditions, e.g.
"explorer": [
                {
                    "id": "testExplorer",
                    "name": "Test Explorer",
                    "when": "resourceExtname == '.javahtml' || resourceLangId == 'java'"
                }
            ]

However, when I used '||', the when condition totally does not work. Does context value 'when' support '||' or '&&' now? Or I used it wrongly? Thanks.

This is not supported for context keys. There is already a feature request for this imho
fyi @alexandrudima


committed range iterator

Codecov Report

Merging #1126 (ae06523) into master (cafc28e) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   46.96%   47.00%   +0.03%
==========================================
  Files         182      183       +1
  Lines       14301    14332      +31
==========================================
+ Hits         6717     6737      +20
- Misses       6689     6697       +8
- Partials      895      898       +3

Impacted Files
Coverage Δ

graveler/committed/range_iterator.go
62.50% <62.50%> (ø)

graveler/committed/iterator.go
73.33% <77.77%> (-0.36%)
:arrow_down:

catalog/mvcc/cataloger_create_branch.go
81.53% <0.00%> (-3.08%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
62.96% <0.00%> (+3.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafc28e...bdd4b65. Read the comment docs.


UploadFile not working with FastAPI Integration

Afternoon,
We have an azure function using v2 and fastapi integration:
function_app.py
from typing import List
import logging
import azure.functions as func
import fastapi

fastapi_app = fastapi.FastAPI()
@fastapi_app.post("/api/asdf")
async def asdf(file: fastapi.UploadFile = fastapi.File(None)):
    logging.info(str(file))

app = func.AsgiFunctionApp(app=fastapi_app, http_auth_level=func.AuthLevel.ANONYMOUS)

The logging always print None, even I am posting file with file key.

Error in postman, local file didn't exist...


Fixes Calc issue

Related Issuse
Scroll calculator automatically on toggle down  #95
Describe the changes you've made
Now , If Any Topic is opened and if we toggle calculator if it is open than our window smoothly scroll to the calculator .

@sairish2001 I am sorry for Opening pull request again , I am facing some issues while pulling changes from upstream.


Function signatures inconsistency between write_file_json and read_file_json

read_file_json takes string view as file name argument, while write_file_json only takes std::string which is less useful. write_file_json should also take string_view as argument for file name, so more types can be used with function without need of conversion to std::string.
write_file_json is marked as [[nodiscard]] inline write_error, while read_file_json has only inline parse_error. read_file_json should also be marked [[nodiscard]], so they both report error if user forgot to handle returning value.

Thanks for this. You could make a pull request, or I'll get to this next week.

@melg8, I've merged your requested changes. Thanks for the feedback.

Note that the file_name buffer must be null terminated. I was using std::string before for more safety, but I think the flexibility of std::string_view is more important. However, it is now up to the user to ensure that the file_name is null terminated.


support darwin

Why did you modify the test case?
If you want to fix the test case, please submit other Pull Req.

Why did you modify the test case?
If you want to fix the test case, please submit other Pull Req.

why defer in for loop？
Do you just want to keep the file opened?
I did a test on the mac, and started to report an error when the size was 8192, and returned -1. I guess it was because shm_open opened too many files

why defer in for loop？
Do you just want to keep the file opened?

It is my mistake.
I will fix it.


Add metrics handler in controller manager.

LGTM (this is exactly the same code as in scheduler).
Will merge on green.