Tweaks to deal with new warnings from latest ReSharper.

This one is very popular:
https://www.jetbrains.com/help/resharper/UsageOfDefaultStructEquality.html
It suggests that default generated runtime comparisons for structs are usually slow, and we should use our own code for equality checks. I've done so, but I worry a bit that we now have more code to maintain in the event that a member is added to a struct. (Interestingly in the act of doing this, I noticed that Model.TransitionGroup.LossId already has its own equality comparer, but doesn't include all its members in that - I've left a CONSIDER comment there)

Brendan isn't convinced that all these new equality methods are worth the churn, and I'm not either. Backing those out and busting that Warning down to a Suggestion is certainly a reasonable option.

BTW @brendanx67 that curious equality method I mentioned in Model.TransitionGroup.LossId is yours - it looks like we're forbidding its use between precursor and fragment, but I wonder if we want to see if fragment types are equal (and if we don't, maybe we can have a comment saying why we don't)

I guess the way to verify is to time the execution with and without the change and see the actual difference in runtimes. This might entail a greater effort than it is worth.
On Tuesday, December 10th, 2024 at 3:17 PM, Brian Pratt @.***> wrote:

Brendan isn't convinced that all these new equality methods are worth the churn, and I'm not either. Backing those out and busting that Warning down to a Suggestion is certainly a reasonable option.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

This might entail a greater effort than it is worth.
I think that's the feeling, yeah.

Our general rubric is 1) make the code as readable and maintainable as
possible, 2) focus on performance in bottleneck situations and prove the
value of more complex code with profiling statistics.
On Tue, Dec 10, 2024 at 4:01 PM Brian Pratt @.***>
wrote:

This might entail a greater effort than it is worth.
I think that's the feeling, yeah.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/3272#issuecomment-2533260468,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUBQVVZMQZY4KWSYAKD2E56EZAVCNFSM6AAAAABTMFGINWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZTGI3DANBWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Especially in UI, you could waste a lot of time and complexity optimizing
code that has no visible impact on the user experience.
On Tue, Dec 10, 2024 at 6:04 PM Brendan MacLean @.***>
wrote:

Our general rubric is 1) make the code as readable and maintainable as
possible, 2) focus on performance in bottleneck situations and prove the
value of more complex code with profiling statistics.
On Tue, Dec 10, 2024 at 4:01 PM Brian Pratt @.***>
wrote:

This might entail a greater effort than it is worth.
I think that's the feeling, yeah.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/3272#issuecomment-2533260468,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUBQVVZMQZY4KWSYAKD2E56EZAVCNFSM6AAAAABTMFGINWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZTGI3DANBWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I'm going to issue a new PR with a clean history, and that warning busted down to a suggestion.


Release Issues

cordova.plugins.Keyboard.hideKeyboardAccessoryBar is a private API that Apple may reject upon app submission. The ionic keyboard plugin version 2.0 removed this API to avoid this. However, with 2.0 the keyboard appears with an accessory view, which makes the app look very non-native.

Our app does not use 2.0 so we do not have the accessory view; however, the app may be rejected because of this. Hopefully Ionic will release an updated version of the API.

Migrate iOS push notifications to production server. Android may need similar config change

Need an explanation of the rules on first time app launch and available elsewhere

Review view headers

Apple can reject your app for using only FB login  but not providing social features. We might have to provide a feature like "share what this person wrote on FB!"

Explanations for rules


Treat tagged template literal as a function call expression

function foo(x = number) {
   return true;
}

var x = foo`world`;

foo`world`  should be validated as a call-expression, including both the template-literal (`world`) being validated as the first argument, as well as the return value type being implied to x.

Actually, template tag functions of course always have an array of strings (str[]) as their first argument... so the foo call-site shape should fail to match the function signature as indicated by that function declaration.


make demo book functionality

a demo book will function as follows

log in not required
click a link which leads to a sheets:sheet view
the sheets_backend will be prompted for a new book
a function in django will populate the new book with the demo data

every time someone requests /sheets/book_demo// a new book will be generated. since this is a simple page accessible by anyone, someone could easily saturated the storage and database with new books
added new field to book model: is_demo. if true, the book view does not require authenticated user.


Config File ".doctron" Not Found in "[C:\Users\Administrator]"

Config File ".doctron" Not Found in "[C:\Users\Administrator]"

Config File ".doctron" Not Found in "[C:\Users\Administrator]"

You can give the  --config param or copy https://github.com/lampnick/doctron/blob/master/conf/default.yaml to C:\Users\Administrator folder.


[WIP] Fix NullPointerException on pulsar 2.9.0-SNAPSHOT

Currently pulsar has a hangs problem, we need fix pulsar side problem then upgrade pulsar dependency.

Pulsar 2.9.0 current don't expose getZkClient(), I need find a way to use getLocalMetadataStore() instead.


Add explicit encoding

Issue #, if available:
Description of changes:
Add explicit encoding='utf-8' argument when cfn-lint loads .yml file.
Some languages' environment such as Windows in Japanese, default encodings is not UTF-8. UTF-8 encoded template file could not be read without implicit encoding argument. For example, when cfn-lint runs template with comment in Japanese in Japanese-Windows environment, it cannot work because system interprets that file is written in cp932 despite done in UTF-8. These users must set encoding option when use read() method in Python.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing in favor of #2298.  Thanks @shunkt just added a new commit to cover the rest of the files in the main program.  I didn't include the test files.


Make groupby.apply in pandas<0.25 run the function only once.

groupby.apply in pandas<0.25 runs the functions twice for the first group, so if the function has a side effect, it could cause an unexpected behavior.
>>> import pandas as pd
>>> pd.__version__
'0.24.2'

>>> kdf = ks.DataFrame({"d": [1.0, 1.0, 1.0, 2.0, 2.0, 2.0], "v": [1.0, 2.0, 3.0, 4.0, 5.0, 6.0]})
>>> acc = ks.utils.default_session().sparkContext.accumulator(0)
>>> def sum_with_acc_frame(x) -> ks.DataFrame[np.float64, np.float64]:
...   global acc
...   acc += 1
...   return np.sum(x)
...
>>> kdf.groupby("d").apply(sum_with_acc_frame)
    c0    c1
0  3.0   6.0
1  6.0  15.0
>>> acc.value
4

whereas:
>>> import pandas as pd
>>> pd.__version__
'0.25.3'

...

>>> acc.value
2

The acc.value should be 2 since there are only 2 groups and the function should be called twice.

Codecov Report

Merging #1462 into master will decrease coverage by 0.15%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##           master    #1462      +/-   ##
==========================================
- Coverage   93.88%   93.72%   -0.16%
==========================================
  Files          36       36
  Lines        8373     8386      +13
==========================================
- Hits         7861     7860       -1
- Misses        512      526      +14

Impacted Files
Coverage Δ

databricks/koalas/groupby.py
89.74% <6.66%> (-2.16%)
:arrow_down:

databricks/koalas/generic.py
93.10% <0.00%> (-0.32%)
:arrow_down:

databricks/koalas/frame.py
95.53% <0.00%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b4147...6d07bb7. Read the comment docs.

LGTM. Nice fixing.


Add edit distance DP problem

(Put an X inside the [ ] to denote check mark [X].)

[ ] If creating a new file :

[ ] added links to it in the README files ?
[X] included tests with it ?
[X] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[ ] if done some changes :

[ ] wrote short description in the PR explaining what the changes do ?
[ ] Fixes #[issue number] if related to any issue

[ ] other

Pull Request Test Coverage Report for Build 745

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 71.552%

Files with Coverage Reduction
New Missed Lines
%

algorithms/linkedlist/is_palindrome.py
1
93.33%

Totals

Change from base Build 742:
0.0%

Covered Lines:
4306

Relevant Lines:
6018

💛  - Coveralls

Thank you! There wasn't a test file for dp algorithms so I added one in the tests folder. I moved my test there and updated the edit distance file accordingly. Please let me know if I need to change anything else.

@goswami-rahul just a friendly bump. I think I took care of the requested changes!

@vinceajcs looks like unit tests are currently failing.
Could you check if they are passing in your local environment?

@keon you're right; I'm sorry about that. When I try running the unit tests (like tests/test_dp.py), I get a ModuleNotFoundError: No module named 'algorithms'. I searched for a while to see if I could figure out why I get this error, but I can't seem to fix it (I tried adding an init file in the dp folder). Is there any chance you could help me out? I want to get this working.

Hi @vinceajcs  , you miss the _init_ file. I help you fix it. Thanks contribution.
@keon It works okay now.

@danghai thank you so much!


feat/added invoice list, create invoice functionality

Updates:

Tutors can see their list of invoices in dashboard
Tutors can click Create New invoice -> redirects to InvoiceCreateView

Todo:

Link student dropdown into InvoiceCreateView (right now it is still manual input)
Status button (Paid/unpaid) in InvoiceListView is not linked to database yet.

note: SubscriptionsView is not doing anything at the moment, just a placeholder


Redial API for reconnects

Presently theoretical, but design work has been done, and this is the key shared-code bit between RT and Launcher repositories.

Reason text field added.


change approval line style

For uvhydro, dvhydro, and fiveyrgwsum.
Now the approval line is made of points with the type "I"/73 (rather than a really thick line). I also added y.intersp=1.5 to increase the vertical space between legend entries.

Coverage remained the same at 87.361% when pulling 82fe492a5f8163c6d9ff649105398e9607ed7c7e on lindsaycarr:master into d4902bcbd71a7067670374954da387d781917af4 on USGS-R:master.


PyPi component not

Describe the bug
Unable to get component details for pypi component https://pypi.org/project/shield34/

To Reproduce
Steps to reproduce the behavior:

Go to https://pypi.org/project/shield34/
Open the extension

Expected behavior
Expect to see component information of component
Desktop (please complete the following information):

Browser Chrome

Additional context
Failed to load resource: the server responded with a status of 400 ()

The extension is calculating the correct PURL for the Component on this page: pkg:pypi/shield34@1.0.408?extension=tar.gz - however, Sonatype IQ Server does not appear to know about this component and returns:
"matchState": "unknown",

I believe this is because there is no .tar.gz component published for<EMAIL_ADDRESS>- see https://pypi.org/project/shield34/#files
We are currently hard-coding the extension to be .tar.gz as we assume every PyPi package has a source archive published.
FYI @maurycupitt


also use IndexedSeq in path

whilst we're at it and using IndexedSeq for list properties
Vector was used before and that's an IndexedSeq as well, so we're not
really changing much besides using a more general api

I'm not so sure.
As you noted, Vector is more specific than IndexedSeq, and return type is covariant, not contravariant, so the API change is technically breaking.
The actual types used are not changed by this (Vector.empty is the same as IndexedSeq.empty), only the declared return type.
However, this may makes the code harder to read, e.g. https://github.com/ShiftLeftSecurity/overflowdb/blob/58f0804b68dd44dc0a80660f7ed8d95a6265a43c/traversal/src/main/scala/overflowdb/traversal/PathAwareTraversal.scala#L15
IndexedSeq.appended is N(log N) for Vector and instances share storage (i.e. two long paths branching off share the memory allocations for the initial piece). For ArraySeq appending is O(N) and no memory is shared, leading to O(N^2) cost for constructing a path of length N.
Hence, calling .appended on IndexedSeq is an immediate red flag -- if we go through with this change, we should definitely add source code comments that these are really Vector, to simplify the job of understanding the code for "future us".

I'm not so afraid of breaking api changes at this point (esp in this rarely used area), but the performance considerations make sense.
I just thought it's a nice consolidation, but probably not worth it.

There are no performance impacts of this PR -- just readability considerations: the old code has obviously the right complexity class, and the new code has non-obviously the right complexity class. So we could change this if there is a good reason, and then add lots of source-code comments to replace the lost readability.


Add SafeHtmlAttr, SafeCSS template function

This allows a template user to keep a safe HTML attribute or CSS string
as is in a template.
This is implementation of @anthonyfok great insight
Fix #784, #347

Hi @tatsushid, thank you for your great contributions and kind words!  Merged (cherry-picked) as f5946ea.


Epoch status ux

Improve information for Carpe users, so they know when they are above or below threshold.
Changes the layout of Miner Slightly


Design Database schema for the Flask Server

Few things that I believe we need to store:

User info like email, password, location
Browser activity time of the user

ID
Date
User ID
Total time(min)

Total Break

ID
User ID
total Break they took
Recent Break activity id

A list of activity they can do during breaks

ID
Activity
Picture link

Optional:
User Accomplishment

date
total no. of task
total no. of task they completed

Daily task

user
task
status

Am I missing anything here? @JENNIFER-E

Made the first draft of the db

Changed the schema a bit to add all the required data


Content type serde

Added implementatin for Serialization and Deserialization trait.
This is the same pull request as my old one but I failed to change the branch, so I re-forked the repository. Sorry for the complications!

I'm sorry for the long waiting time! Here's another attempt. @paolobarbolini


better hello message

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: xieweicarl2018
If they are not already assigned, you can assign the PR to them by writing /assign @xieweicarl2018 in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/meow

@xieweicarl2018:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test this


Any plans to support long stack traces / causality chains?

A long stack trace could be very useful for debugging purposes.  For example see: https://github.com/kriskowal/q#long-stack-traces.

Sounds like a good idea. Although not sure how we'd achieve that in C#. Got any ideas?

I like the idea, took - one could record stack traces manually via the StackTrace class, and then pass traces to the next promise. But sounds like a pretty complicated task, and I'd guess that selectively activating/deactivating the feature may be not so easy to accomplish, because it sounds like a lot of overhead processing. Would it be possible to let "debuggable promises" inherit from the default implementation?

That's a great idea. zone.js is probably a good inspiration, too.

Any update on this? It would be very useful.

What would a long stack trace look like compare to what we got today?

FYI I have this working in my ProtoPromise library. The steps are to capture the current stack trace whenever a new Promise is created. Set that trace to the currently running trace before the callback is executed (in a [ThreadStatic] field). When the stack trace is captured, append it to a list of all the previous stack traces (I store it in a CausalityTrace class that handles it cleanly).


add docker, drop MetaData and optional for blocks

optional for blocks
drop MetaData
add docker for deploy

Codecov Report

Merging #11 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0686cc0...ca6fce6. Read the comment docs.

Sorry for deleting the develop branch...

I didn't protect this branch.....🤣 now I know protect branch is important....


Cannot read property 'clientHeight' of undefined

2.2.8 is the last version that works for me (tried both Chrome and Safari). 2.2.9 and all later versions fail with:
scroll-into-view.min.js:1 Uncaught TypeError: Cannot read property 'clientHeight' of undefined
    at n (scroll-into-view.min.js:1)
    at r (scroll-into-view.min.js:1)
    at scroll-into-view.min.js:1

Here is the failing invocation (elem is neither undefined nor null):
scrollIntoView(elem, {
        behavior: 'instant',
        scrollMode: 'if-needed',
        block: 'nearest',
        inline: 'nearest',
      });

Figured it out. Was trying to scroll to an element before it had been added to the DOM. Apparently this works or is a no-op in 2.2.8 but fails in later versions.

Interesting! I’m going to re-open this issue and investigate how native browsers handle this, and if it’s included in the CSSOM View spec what should happen.
IMO we should either no-op or provide a better error message than "clientHeight" on undefined 🤔

Hi @stipsan is there any update on this? We are using this plugin but because of this bug we may have to find another solution if this doesn't get fixed soon so hoping your close to releasing a fix? Thanks!

Hey sorry to have kept you waiting! I will take care of this today 🙂
tor. 4. okt. 2018 kl. 17:12 skrev John Hancock<EMAIL_ADDRESS>
Hi @stipsan https://github.com/stipsan is there any update on this? We
are using this plugin but because of this bug we may have to find another
solution if this doesn't get fixed soon so hoping your close to releasing a
fix? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stipsan/scroll-into-view-if-needed/issues/369#issuecomment-427056879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFAPQAd92Evt2aVHUf5NO6peV1FNs3iks5uhiVbgaJpZM4VhEbH
.

:tada: This issue has been resolved in version 2.2.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@bluecaret please let me know if v2.2.17 didn't solve it 🙂

Awesome! Glad I said something ;) I'll take a look tomorrow. Thanks for the fast reply and work!

@stipsan It worked great! And FYI we are using the smooth-scroll addon so it works with that as well. Thanks again!

Great to hear! 🎉


⚠ Bofrost.lu has degraded performance

In 8a59b98, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1013 ms

Resolved: Bofrost.lu performance has improved in 5c841a7 after 7 minutes.


effective genome size

Hi. I had used the method named "epic-effective"  to calculate  effective genome size ("https://www.biostars.org/p/185948/). My data is paired-end 150bp and species is Sus. Our final results is 0.9720847535129595.  Is it normal? maybe too high??

For mammals, around 90% is about right.
Changing the setting to eg 85% isn’t going to change much. Also, the order of the results will be the same, but you might get fewer/more regions with a significant FDR.

For mammals, around 90% is about right.
Changing the setting to eg 85% isn’t going to change much. Also, the order of the results will be the same, but you might get fewer/more regions with a significant FDR.

The EGS does not affect the order of results but does affect FDR. Thanks for your reply.

The EGS does not affect the order of results but does affect FDR. Thanks for your reply.


'RNGzipSpec.h' file not found

'RNGzipSpec.h' file not found

This looks like a new architecture issue. Does anyone have a fix for this?

Same issue here


printTicket - Stapling not working

I am trying to get Stapling to work using a PrintTicket.
Like this:  https://stackoverflow.com/questions/48450487/print-pdf-in-c-sharp-with-staples
My printer supports stapling (since I can hit the print dialog, choose staping, and it staples).
However, using this code:
 var queues = server.GetPrintQueues();
            using (var queue = queues.FirstOrDefault(x => x.FullName == printerName))
            {
                var printTicket = queue.DefaultPrintTicket;
                printTicket.Collation = Collation.Collated;
                printTicket.Stapling = Stapling.StapleTopLeft;
                queue.UserPrintTicket = printTicket;
                queue.CurrentJobSettings.CurrentPrintTicket = printTicket;
                var ret = queue.MergeAndValidatePrintTicket(queue.UserPrintTicket, printTicket);
         }

Does NOT make the "Stapling.StapleTopLeft" option work on the print ticket.
This must be a bug, and need to figure this out.
Thanks,
Darren

Do you have troubles on .NET Framework or .NET Core? (did you try both?)
Do you have same problems in other environments? (different printer, different machine)

On the dot NET Framework but I would assume it would happen on the core as
well.
On Wed, Oct 31, 2018, 11:56 AM Karel Zikmund<EMAIL_ADDRESS>wrote:

Do you have troubles on .NET Framework or .NET Core? (did you try both?)
Do you have same problems in other environments? (different printer,
different machine)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/core/issues/2034#issuecomment-434739290, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AqjdfVtbA_eKKYPs8I8YAV_xo--9wfbLks5uqcgzgaJpZM4YD_hu
.

And also I've tried it on Windows 7 and Windows 10 but I only have the one
printer that can do stapling. I assume this problem is happening other
people since other people have reported it on stack overflow.
On Wed, Oct 31, 2018, 12:59 PM Darren Cox<EMAIL_ADDRESS>wrote:

On the dot NET Framework but I would assume it would happen on the core as
well.
On Wed, Oct 31, 2018, 11:56 AM Karel Zikmund<EMAIL_ADDRESS>wrote:

Do you have troubles on .NET Framework or .NET Core? (did you try both?)
Do you have same problems in other environments? (different printer,
different machine)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/core/issues/2034#issuecomment-434739290, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AqjdfVtbA_eKKYPs8I8YAV_xo--9wfbLks5uqcgzgaJpZM4YD_hu
.

We do not track .NET Framework bugs on GitHub. You can either contact Microsoft support or use VS Developer Community portal for that - see details: https://github.com/dotnet/core/blob/master/README.md#getting-help

For anyone stumbling upon this.
I had the same problem.  printTicket.Stapling = Stapling.StapleTopLeft; would not work.  Worked for some printers, but not for the Canon using their Canon Generic Plus driver (the main one used on their printers).  The .GetPrinterCapabilities show no staple option available.  Yet from other apps you could control the stapling, such as from Word.
I found that printQueue.GetPrintQueueCapabilitiesAsXml() revealed the stapled capability.   From there, updated the printing ticket XML and it worked.  Basic steps were:

Get the XML from the printQueue's printTicket.GetXmlStream().
Update the XML with the setting you need.
Load the XML back in using PrintTicket contructor.
And assign the new print ticket to the printQueue.UserPrintTicket.
Do printQueue.Commit().

See: the https://docs.microsoft.com/en-us/dotnet/api/system.printing.printticket?view=net-5.0


Implement Change Passcode Feature:

https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/3f6c0678-7313-409c-a7b7-ca66692fa3e3/specs/
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/b29fb3ef-ae97-4bba-afea-8ce69b0dcf06/specs/

@cakesoft-shashank , I have added a the flow of change passcode but there is an issue in the saga function which we discussed in the call. Please have a look into it. Below is the PR link:
https://github.com/bithyve/bitcoin-keeper/pull/3921/files

Verified this issue on keeper app v 1.2.0(319)


Adding containerization, and updating README accordingly

Hi, have you tested? I not sure if python ./main.py can work in this kind of flask structure.

Merge to branch docker.


[alert]Alerts are not working, importing security_manager returns NoneType object

After enabling "Alerts" and configuring one, I cannot see any triggers and email notifications being sent to me. I am sure that SQL query should return rows to trigger alert and, also, Alert Log is not showing any triggers.
Using Celery for email notifications. Maybe, I am missing some Celery configs in superset_config.py?
Expected results
I want to be able to trigger alerts.
Actual results
Email notifications are working, it means something wrong with alerts. After checking the Docker logs, I found a possible issue, there is an error in models/alerts.py while importing security_manager. Not sure what causes this error. In addition, within the above error there is another error:
sqlalchemy.exc.InvalidRequestError: Table 'alert_owner' is already defined for this MetaData instance.  Specify 'extend_existing=True' to redefine options and columns on an existing Table object.

More logs below.
Screenshots (logs)
Docker logs:
class Alert(Model):
  File "/usr/local/lib/python3.6/site-packages/superset/models/alerts.py", line 60, in Alert
    owners = relationship(security_manager.user_model, secondary=alert_owner)
  File "/usr/local/lib/python3.6/site-packages/werkzeug/local.py", line 347, in __getattr__
    return getattr(self._get_current_object(), name)
AttributeError: 'NoneType' object has no attribute 'user_model'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/celery", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.6/site-packages/celery/__main__.py", line 16, in main
    _main()
Loaded your LOCAL configuration at [/opt/superset/superset_config.py]
  File "/usr/local/lib/python3.6/site-packages/celery/bin/celery.py", line 322, in main
    cmd.execute_from_commandline(argv)
  File "/usr/local/lib/python3.6/site-packages/celery/bin/celery.py", line 499, in execute_from_commandline
    super(CeleryCommand, self).execute_from_commandline(argv)))
  File "/usr/local/lib/python3.6/site-packages/celery/bin/base.py", line 289, in execute_from_commandline
    argv = self.setup_app_from_commandline(argv)
  File "/usr/local/lib/python3.6/site-packages/celery/bin/base.py", line 509, in setup_app_from_commandline
    self.app = self.find_app(app)
  File "/usr/local/lib/python3.6/site-packages/celery/bin/base.py", line 531, in find_app
    return find_app(app, symbol_by_name=self.symbol_by_name)
  File "/usr/local/lib/python3.6/site-packages/celery/app/utils.py", line 376, in find_app
    sym = imp(app)
  File "/usr/local/lib/python3.6/site-packages/celery/utils/imports.py", line 111, in import_from_cwd
    return imp(module, package=package)
  File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.6/site-packages/superset/sql_lab.py", line 44, in <module>
    from superset.db_engine_specs import BaseEngineSpec
  File "/usr/local/lib/python3.6/site-packages/superset/db_engine_specs/__init__.py", line 36, in <module>
    from superset.db_engine_specs.base import BaseEngineSpec
  File "/usr/local/lib/python3.6/site-packages/superset/db_engine_specs/base.py", line 54, in <module>
    from superset.models.sql_lab import Query
  File "/usr/local/lib/python3.6/site-packages/superset/models/__init__.py", line 17, in <module>
    from . import (
  File "/usr/local/lib/python3.6/site-packages/superset/models/alerts.py", line 43, in <module>
    Column("alert_id", Integer, ForeignKey("alerts.id")),
  File "<string>", line 2, in __new__
  File "/usr/local/lib/python3.6/site-packages/sqlalchemy/util/deprecations.py", line 139, in warned
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/sqlalchemy/sql/schema.py", line 542, in __new__
    "existing Table object." % key
sqlalchemy.exc.InvalidRequestError: Table 'alert_owner' is already defined for this MetaData instance.  Specify 'extend_existing=True' to redefine options and columns on an existing Table object.

How to reproduce the bug
No idea.
Environment
Docker image: python:3.6-jessie

superset version: 0.37.2
python version: 3.6.9
node.js version: not installed

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
No additional context

@VMois are you still facing this issue? The alerting functionality has been successfully used recently so likely this bug is addressed. If you are still facing the issue please reopen.

@VMois are you still facing this issue? The alerting functionality has been successfully used recently so likely this bug is addressed. If you are still facing the issue please reopen.

Hi.. I am still facing the issue.. could you please help me out on this

Hey @sunkuteja123. I have changed jobs quite some time ago, so I don't remember the details. What version of Superset do you have? I think, when I upgraded to version 1.0, I was able to send notifications to email/slack, and, probably, alerts were working too. So I suggest trying 1.0.

Hi,
Thanks for your reply . Ia m using 1.3 version and we facing issues even
after changing the config file. Is there any other setup is required for
this if you can recall would really help. Thanks
Regards,
Teja
On Thu, 20 Jan, 2022, 2:26 pm Vladyslav Moisieienkov, <
@.***> wrote:

Hey @sunkuteja123 https://github.com/sunkuteja123. I have changed jobs
quite some time ago, so I don't remember the details. What version of
Superset do you have? I think, when I upgraded to version 1.0, I was able
to send notifications to email/slack, and, probably, alerts were working
too. So I suggest trying 1.0.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/issues/12809#issuecomment-1017249961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY7LIZSQPDJUTLZOF7QCVTUW7E5JANCNFSM4WXCUVVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


Add date ranges to source table to match PDAP and provides year info with query

Use column names used by PDAP: https://docs.pdap.io/activities/data-sources/explore-data-sources


Correction to rows returned without ESCAPE

"If ESCAPE and the escape character aren't specified" then the "!" would not be treated as the escape character and instead would be part of the string being searched for. Therefore, it would return any rows with the string "30!", not "any rows with the string 30."

@Rob-S : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Rob-S Thank you for catching this. I will approve the change.
#sign-off


Update how-to-identity-based-service-authentication.md

The previous command did not work:
az ml workspace show -w  -g
--query containerRegistry
Tested this new command I wrote in this PR with the latest CLI version and it works.
Note: Also edited other commands that were using "-w" instead of "-n". As of the latest CLI version, -n is the correct way to reference workspace name. This can be seen in several commands in our reference, such as workspace create:
https://learn.microsoft.com/en-us/cli/azure/ml/workspace?view=azure-cli-latest#az-ml-workspace-create

@J-Silvestre Thanks for helping improve the docs!
#sign-off


Web API Authorization

Category

[ X ] Question
[ ] Bug
[ ] Enhancement

Question
I was wondering how one might add authorization to the webapi calls. Because, right now it looks like the webapi calls are open to anyone, and in production I feel like we would want to limit that to only allow our applications to make calls to this webapi. I'm thinking along the lines of a custom action filter. But not sure how to implement that. Any suggestions?
Thanks for your contribution! Sharing is caring.

If your APIs are hosted in Azure App Services then you could benefit of Azure App Service Authentication. Without changing your API code you could secure your APIs with Azure Active Directory. From the web part you would then follow the same approach as when connecting to Microsoft Graph using OAuth implicit flow.
If you host your APIs elsewhere then you would indeed need a custom security implementation. The key point here is to implement it in a way so that authentication to your APIs can happen in a non-interactive way. Otherwise AJAX calls will return redirect responses or HTML which require additional effort to be processed in the web part.

Thanks Waldek!
I was assuming that the APIs were going to be hosted in Azure, sorry I forgot to point the out. Please correct me if I'm wrong. One downside to having the APIs registered in AAD, would be that the client secret would need to be stored somewhere in the app, which could be hacked, right? Also using the Microsoft Graph approach the user would have to sign-in to AAD via the webpart and then the token would also need to be stored either in a variable in the app or in local storage, which again could be hacked, right?
Just trying to make sure that I understand the risks currently involved using those two solutions. Thanks again!

Storing a secret in a client-side application would be a security issue indeed, which is why there is the OAuth implicit flow which is based on the publicly-known client id and the application URL. In the OAuth implicit flow no secret is used and the trust is established based on the URL of the application. In OAuth implicit flow you're not getting a refresh token but only the access token. When it expires the user has to reauthenticate with AAD to obtain a new access token.
Hope this clarifies it a bit.

Waldek -
Thanks! That definitely clarifies it a ton! Thanks for being so helpful!

Glad to hear I could help :)

Waldek -
Sorry to bug you ... I'm able to get a bearer token and with it I can access the Microsoft Graph API successfully in my sharepoint framework web part. However, when I try to pass the same bearer token to my .NET Web API secured by AAD, I get an (401 Unauthorized) error. I have implicit flow enabled on both applications. Is there anything that pops out at you that might be causing this issue?
I should mention that I registered my sharepoint framework web part using apps.dev.microsoft.com, while I used portal.azure.com to register by .NET Web API with AAD. Not sure if that could be the source of the problem.
Thanks!

Not at all! :)
Implicit flow is meant for use by client-side applications only. A .NET app capable of storing a secret, should use a regular flow with client id and secret. This is of course only valid for how you acquire the token. Once you have a valid token, it doesn't matter what type of client uses it.
Could it be that your token expired or that it doesn't contain sufficient permissions for what you're trying to do? Is the AAD with which you registered the application the same AAD as the one associated with your O365 subscription? If not then you might need to consent your application to be used on the O365 tenant.

Thanks Waldek! Both are applications are using the same tenant, and I just checked the token expiration and that doesn't appear to be the issue. It definitely could be a permissions issue with trying to communicate between the two applications. The client application that I setup in apps.dev.microsoft.com has Graph Permissions for User.Read, however, I don't have any application permissions. In apps.dev.microsoft.com it doesn't allow me to give my client application access to the .NET Web API web app. However, if i log into portal.azure.com and look at my active directory applications, my client app shows up but it won't allow me to update any of the settings for some reason, I just get an error.
Also for my .NET Web API application that I setup in AAD through the portal, i did not generate a client secret for the app, could this be part of my problem? And even if I did generate a client secret how would I use that in the .NET Web API application? because the way i have the code now in the startup.cs file is this:
        app.UseWindowsAzureActiveDirectoryBearerAuthentication(
            new WindowsAzureActiveDirectoryBearerAuthenticationOptions
            {
                TokenValidationParameters = new TokenValidationParameters
                {
                    ValidAudience = ConfigurationManager.AppSettings["Audience"]
                },
                Tenant = ConfigurationManager.AppSettings["Tenant"]
            });

there doesn't appear to be a use for a client secret, unless i'm totally missing something?
also would it be easier if I uploaded my code to github and posted the link for you to look at?
Thanks again for all the help! I truly appreciate it! I've tried looking around for examples of this but haven't found any and I feel like I'm just blindly poking around with this code :)

Waldek -
So I finally figured this one out. The first problem was that I had registered my client app in apps.dev.microsoft.com and this doesn't (from what I've tried) allow you to grant permissions to access another app in your tenant. So I needed to register both my apps in AAD inside the azure portal.
Also I was initially using hellojs instead of adal and adal-angular. Hellojs is great for interacting with applications registered at apps.dev.microsoft.com but adal and adal-angular works WAY better with apps registered in the azure portal.
After these changes everything worked! Hope this makes sense and helps someone in the future. Thanks again for all the guidance!
@waldekmastykarz


People are randomly muted

Over the course of 3 hours I was muted twice without having pressed the mute button.  Other people were muted as well.  (evening of Dec 24)

Thanks! This happens when the system detects that you're running behind because of either CPU or network issues, and you would be causing a problem for the person after you. The interface is currently pretty bad: randomly and inexplicably muting people is much worse than saying "you've been muted due to lag" and offering a button to try again.
I have a better UI for this coming in #146.
@gwillen looks like even with your improved catching up code this is still triggering

Thanks! This happens when the system detects that you're running behind because of either CPU or network issues, and you would be causing a problem for the person after you. The interface is currently pretty bad: randomly and inexplicably muting people is much worse than saying "you've been muted due to lag" and offering a button to try again.
I have a better UI for this coming in #146.
@gwillen looks like even with your improved catching up code this is still triggering

The better user interface for this is now live

The better user interface for this is now live


Command to start json-server is not working.

I am trying to start JSON server with following command
$ json-server --watch db.json
I am not able to start the server. I am getting command not found error
“json-server: command not found”
I referred
https://github.com/typicode/json-server
http://www.betterpixels.co.uk/projects/2015/05/09/mock-up-your-rest-api-with-json-server/
I am using iMac (Mid 2010) with latest OS (macOS Sierra) version 10.12
Please help me to resolve the issue. Thanks

Hi @KavyaKn
I would suggest double checking if the flag -g was set when running npm install -g json-server. It's usually a common mistake that results in command not found.
If it doesn't work, can you tell me what's your version of node and npm? What did you use to install Node?

Hi..
I had used the same command “npm install -g json-server”
The node and npm version which i am using is
node -> v6.6.0
npm - > 3.10.3
and i had downloaded the node from this URL
https://nodejs.org/en/

I'm having the exact same issue as well
node v6.7.0
npm v3.10.7

If you try to install another CLI tool, do you have the issue too? For example:
$ npm install --global gulp-cli
$ gulp

Yes i am getting the issue  "-bash: gulp: command not found".
For the command
$ npm install --global gulp-cli
$ gulp

Thank you for the test.
I think it might be related to your Node installation actually. PATH may be missing some Node paths and so your terminal fails to find installed CLIs.
I've not tried Node installer on Sierra so I can't say much, but you can try reinstalling it or you can check if there's not something that is modifying PATH.
Personally, I like to use nvm and it works on Sierra.

Thank you very much. Reinstalling node with nvm worked for me
On Thursday, 13 October 2016, typicode<EMAIL_ADDRESS>wrote:

Thank you for the test.
I think it might be related to your Node installation actually. PATH may
be missing some Node paths and so your terminal fails to find installed
CLIs.
I've not tried Node installer on Sierra so I can't say much, but you can
try reinstalling it or you can check if there's not something that is
modifying PATH.
Personally, I like to use nvm https://github.com/creationix/nvm and it
works on Sierra.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/typicode/json-server/issues/370#issuecomment-253481489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVvu6AQ7M2L1aiq8JrpumZdLUxA-J0Wxks5qzg6PgaJpZM4KHvmB
.

Glad it worked :+1:
Is it ok for you too @KavyaKn?

Did you try sudo npm install -g json-server.
executing this as sudo solved issue for me (ubuntu 14.04, node installed without nvm)

[POSSIBLE SOLUTION]I had the same problem. Did the following steps.

installed JSON-Server with
sudo npm install -g json-server

Tried to start the server in the same terminal
json-server db.json
Got the same error.

Started a fresh terminal and started the server and it worked fine.

I had this problem because my $HOME/.npm-global/bin was not in the $PATH.
Works for me.
export PATH=$PATH:$HOME/.npm-global/bin
tip: Is possible get json-server install in return message of npm install -g json-server  command.

use "json-server db.json" db.json is my json file name replace it with your file name

I know this is rather old, but I had the same issue and got solved by installing json-server package globally, that's all.
Meaning, I run this command
npm install -g json-server
before running
json-server --watch db.json
I didn't have to re-install node or npm, or use nvm or anything else.

I have a problem that json server not working.
Error Showing: ERR! code ELIFECYCLE
Error Showing: ERR! errno 1
json-server --watch db.json not woking and showing error
i got the answer
while start json-server it compiling the db.json file and if any type mistake in db.json file it show the error

bash: json-server: command not found
am using windows 10 trying to use it on reactjs...Please help

fixed this by following the steps are being described here https://stackoverflow.com/questions/43465086/env-node-no-such-file-or-directory-in-mac

@iamgodswill
I am using Mac mini and was stuck in the same issue some days ago.
Try using _

sudo npm install -g json-server

👍
_

Hello, I'm building something that I wish someone could use without having to install json-server globally themselves.
Is there a way to make it so json-server would be ready to use as soon as the other person would download + npm install my app?

npx json-server --watch db.json

да, с npx оно типо его запустило, но ничего он не подгружает, файл с базой видит отлично, а достучаться к нему нельзя
...оставил пока так как есть)...хоть запустился...

npx json-server --watch db.json solved the problem for me

This also helped me resolve the issue.
PS: I use Windows

npm install -g  json-server --save has worked for me...... its good option

npx json-server --watch db.json solved the problem for me

Very helpful

npx json-server --watch db.json solved the problem for me

thanks for this!

Did you try sudo npm install -g json-server.
executing this as sudo solved issue for me (ubuntu 14.04, node installed without nvm)

this works for me, thank you!

Try sudo npm install -g json-server , it's work for me

This works npx json-server --watch db.json - thanks @abdelalimah

npx json-server --watch db.json solved the problem for me

Thank you  @caprica-Six it is working for me.

npx json-server --watch db.json benim için problemi çözdü

Thank you @caprica-Six it's working

Мне помогла не локальная установка , а глобальная .

npx json-server --watch db.json solved the problem for me

Thank you so much. This works

I was trying to use it with Vue JS in Linux and came across the same issue:

npm install json-server
It will install the package locally and inside the Vue project there is a node_modules folder and the executable is in .bin.
So running the following command will work.

./node_modules/.bin/json-server --watch data/db.json

  \{^_^}/ hi!

I was trying to use it with Vue JS in Linux and came across the same issue:

npm install json-server
It will install the package locally and inside the Vue project there is a node_modules folder and the executable is in .bin.
So running the following command will work.

./node_modules/.bin/json-server --watch data/db.json

  \{^_^}/ hi!

Did you try sudo npm install -g json-server.
executing this as sudo solved issue for me (ubuntu 14.04, node installed without nvm)

it work!

Did you try sudo npm install -g json-server.
executing this as sudo solved issue for me (ubuntu 14.04, node installed without nvm)

it work!

npx json-server --watch db.json worked for me

For me too. npx json-server --watch db.json worked. I didn't install globally, I installed locally.

For me too. npx json-server --watch db.json worked. I didn't install globally, I installed locally.

It didn't work for me.. I am getting command not found: json-server.
Can anyone please help me? I am using Windows 10

The common mistake  is not installing the package globally
Use : npm install -g json-sever

For me too. npx json-server --watch db.json worked. I didn't install globally, I installed locally.

and its working well.

I fixed the error by running this command again.
sudo npm install -g json-server

I was trying to use it with Vue JS in Linux and came across the same issue:

npm install json-server
It will install the package locally and inside the Vue project there is a node_modules folder and the executable is in .bin.
So running the following command will work.

./node_modules/.bin/json-server --watch data/db.json

  \{^_^}/ hi!

Thanks ! So no need to install this global)

npx json-server --watch db.json solved the problem for me

God bless you, sir, and thank you from my heart! @abdelalimah

npx json-server --watch db.json solved the problem for me

thanks for this!

Thanks this works for me also


Generate python dependencies

Regenerates python dependencies and adds in a link to the scikit-learn license (which couldn't be found by default)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

cc/ @robertwb


Add OutpointFilter to filter wallet-based outputs

This should significantly simplify wallet APIs such that contract interfaces will now return only a state which is specific to some wallet descriptor.

NB: this does not (yet) provides guarantees that the issuer does not lie about the amount of the issued asset.
To ensure that the issuer can't fake issuedSupply value in genesis we need an AluVM script checking the sum of pedersen commitments of the spent assets. I am working on adding it (but at least you can start playing with the new API since the API wouldn't change)


Making the LUT table static

For the activation function, the initiation of LUT is taking too much CPU time
during csim. To fix this issue, change the table to be a static varibles, which will
remain in memory for the running lifetime. Also only call the initiation function by
checking the table value, making the initiation function got called only once.

@zhenbinwu Awesome!


Update Webots version to R2019b

Ditto.

test me

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/561/consoleText

test me

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/564/consoleText

I tested locally and I don't have any compilation issue.
I will check deeply once #421 is merged and included in this PR as it could cause some conflicts.

test me

:+1:

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/568/consoleText

It seems there is still an issue with the test suite.
I will check the config file.

test me

oops, I saw the green tick (and not the yellow dot) and I though that the test was passed.
Locally everything is working correctly. It is strange that the compilation of the test suite worlds blocked on the jenkins machine.

I think that it was not the compilation in itself but Webots was stuck at startup:
OpenGL version      : 4.5.0 NVIDIA 384.130

### api test

FAILURE: Some tests have not been executed
- expected number of worlds: 123
- number of worlds actually tested: 0)

Webots complete STDOUT log:

Webots complete STDERR log:

### physics test

FAILURE: Some tests have not been executed
- expected number of worlds: 24
- number of worlds actually tested: 0)

Bu this is probably fine now that welcome dialog is not displayed anymore.

I confirm the test_suite is working now on the develop branch.


gcc darwin fixes

Motivation for this change
These changes seem to get gcc48, gcc5, and gcc6 working on Darwin. I need to verify that Linux gcc's still work though.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Still getting:
The directory that should contain system headers does not exist:
  /usr/include
make[3]: *** [Makefile:2829: stmp-fixinc] Error 1

The versions you mentioned still build on linux.

Ok so I've got my Macbook running without the Command Line Tools. I'll see what is fixable.

Does anyone know if gcc 4.6 can be deleted? It's not reachable right now in the code AFAICT.

Most likely yes, probably cbb055c1d9e16e6333a199b6df0380c14af55825 forgot to remove it by mistake.

stdenv.libc doesn't exist on Linux. Still, stdenv.cc.libc should be portable AFAIK.

(Note: in any case, it shouldn't be merged to master directly.)

Staged.


fix(definition): remove builder pattern

What this PR does / why we need it:

fix(definition): remove builder pattern

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):
Fixes #125
Special notes for your reviewer:
/assign @Jimexist
/assign @ddysher
/kind cleanup
Release note:

Remove builder pattern for definition

/lgtm

does it even make sense to have something like convert from v1 to v2, since we are at very early stage of this framework and there's not too many projects using this just yet.

@kdada LGTM, but please add config test first :)

@Jimexist
Converter is a kind of operator. We don't need it in the beginning.

/lgtm

/lgtm cacnel

/lgtm cancel

/lgtm

/approve


Update the examples post restructuring

Restructuring the repo has broken some examples. We should fix this (should be an easy fix)

depends https://github.com/NethermindEth/starknet.go/issues/393


Fin Tool bar is Grey when on an Octopus site

I have a server (Octopus_VM) which I access my Octopus instance. When I go to it I don't see any of the features of Blue Fin even after restarting Chrome?
I'm running version 3.x of Octopus

Okay is just started working, but the icon is still grey


Get poetry to use the current python version

Works in turo/orion: https://github.com/turo/orion/actions/runs/6634155111


Device - Message Actuator

When a message acts / arrives on the device, when loading the page, the message disappears.
Message has arrived.

When reloading the page, message is not found.

Solved in #1246


Update CODEOWNERS

What this PR does / why we need it
Update CODEOWNERS to the OCM Maintainer team

@frewilhelm should work now. Was a mismatch between Maintainer / Maintainers. I renamed the team to Maintainers now.

Related to https://github.com/open-component-model/ocm-project/issues/243


unify plugin loading

Right now bot, web, feeds and so on keeps track of plugins on their own, this is really not needed.

https://github.com/jonas747/yagpdb/commit/8cb4d931319d2e8945bf582e32d50dbd3fdcdc5b


Consider putting Open Sample in it's own block or in the top block

🧰 Task
With all the new options in the File menu, it's a bit harder to quickly find the Open Sample menu, which is super useful for demos or testing:

Maybe we should think about moving it to it's own block between the New... and Open... blocks?

cc: @DragaDoncila

Maybe we should think about moving it to it's own block between the New... and Open... blocks?

You think that people use drag'n'drop when opening files, not menu?

Not sure I follow?
I think people do use drag and drop, but we should support the menu.
My point is that Open Sample is now harder to spot and use, that's all. It's also a slightly different role than file IO.

For a teacher, samples are useful. But for normal user, "Open" looks more useful and should be easier accessible.

Ok, then put Open Samples after the Open block, before Save.
I don't care 🤷

@psobolewskiPhD totally agree it gets a little lost now, I've had the same experience. What do you think about putting IO Utilies and Acquire in its own group? That way Open Sample gets "anchored" to the bottom of Open?

I like that @DragaDoncila, it's similar to how it was before this way.


Multi-Cluster Support

Now that we have Quilkin running as a xds management server, we want to extend that capability to multiple clusters, as currently it needs to run in the same cluster as where the gameservers are hosted where as we want to be able to place Quilkin at the edge in more regions than just the ones that contain gameservers.
To do this I'd like to propose a very simple addition to our current architecture. Which is the introduction of a kind of "relay" service that sits on-top of the management servers. Each management server would send a message to the relay to give its IP address, and then the relay server would initiate an xDS discovery stream with the management server, and then load balancers would connect to the relay service as a management server which would serve the aggregation of all the management servers.
Having the management servers initiate to relay to start the communication is important, because that allows the relay to serve N management servers dynamically as they pop up and shut down, the rest is just using the same xDS logic that we already have.

I haven't gone deep on this, but could we use  https://github.com/envoyproxy/xds-relay ?


[Feature] Add support for hierarchies in Skosmos wrapper

Implement getTop, getAncestors, and getNarrower.
For API documentation, refer to: http://api.finto.fi/doc/

There is an implementation already. Since we want to publish 1.0.0 soon, we might need to move refinement of the Skosmos wrapper into a patch release.


Investigate better format for StorageHistory

Describe the feature
Comments from this thread: https://github.com/paradigmxyz/reth/pull/978#discussion_r1085377222
Additional context
No response

Makes sense to convert the StorageHistory table to a dusport table, is consistent with how we've set up PlainState as well.


Fix mapping from CLI arg to config

Proposed changes:

Closes #10132

Problem was CLI arguments being mapped to a key not used by the TrainingTrackerProvider (augmentation instead of augmentation_factor), so when the component config (generated from the CLI args) was merged with the default config, the default value for augmentation_factor was never replaced

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[X] reformat files using black (please check Readme for instructions)

So me and Tobi had a think about this yesterday and it's a bit of a nightmare to test (since IMO the problem is that CLI params are packed into a dict and we have no way of validating that dicts structure through all the layers, so we can test any one layer but that doesn't guarantee we actually respect the structure at the other layers). I could do a unit test for just this bit of the recipe to make sure that if the dict is constructed the way the CLI constructs it now, it maps correctly, but I'm not sure how we'd test to make sure the mapping isn't actually broken in future?

Is it possible to add a test to tests/cli/test_rasa_train.py where we actually pass the --augmentation flag and then spy on the TrainingTrackerProvider to see it get's the value passed to its __init__?
If it's too time consuming don't worry though.

I think that would be difficult because most of the tests there will invoke the CLI on the shell, where we can't mock things very easily (had a similar problem with markers recently) - so unless the value of the parameter was logged somewhere we would probably have a hard time intercepting it. I could add a logging line to facilitate this though if that sounds good?

Was thinking about testing as well, this seems like such a sneaky bug.. only reason I found it is because I was stepping through the code. I wonder if there are other instances like these where it might not be clear if the arguments aren't making it to the component? Not an urgent thing atm, but in general would be nice to have tests for all the components

Maybe a compromise for now is a unit test for the recipe like you suggested @usc-m - just to stop a regression for this specific bug.

I think long run we might want to think about refactoring this somehow to get the type checker to make sure things are mapped properly, and then also maybe think about a better testing strategy for the CLI overall (like some harness that invokes main directly with a parameter string and then we can mock things and check the internals - alongside some shell execution tests)

So when I was looking for where to add a new test, I noticed test_tracker_generator_parameter_interpolation actually tested the old functionality (with the incorrect mapping - which as a result was failing on this branch), so I've updated it and I think that should catch regressions of this kind now


Bounties system setup & wiki description

Propose board the bounty system.
Perhaps something like:
Direction with quarterly budget - to be approved by board.
Coordinator approves bounties - and suggest budgets
Maintainers suggest bounties
Fix bounties size ($100, $250, $500, $1k, $2k, $3k)??
Collect who is using bounties how.

I kind of like the https://docs.opencollective.com/help/contributing/development/bounties with labels on github issues - and instructions in github repo templates.
There is also:
https://www.boss.dev/
https://bountysource.com/
https://gitcoin.co/

https://github.com/topics/bounties

Set up categories and decide on allocation with Governing Board.

The current solution at https://roadmap.maplibre.org offers everything we need:

card format with topic title and a visual
voting system (people provide email address when up-voting)
life-cycle stages

under consideration
in progress
released

The current solution uses MapTiler's productboard account, thanks @klokan for letting MapLibre use MapTiler's resources.
I propose that we get our own productboard account, it is USD 140 per year. https://www.productboard.com/pricing/ If there are no objections I will get us an account and set up the roadmap board by Thursday, Nov 3rd, 2022 hopefully.

Portal starts at $80 / month plan - not at $20…
It is not ideal for open-source community project IMHO
Voting with GitHub account would be better.
For the costs - we could even develop open-source HTML+Next.js GitHub API
backend based web roadmap - on top of Issues - showing an image from the
issue description in a responsive layout similar to current
roadmap.maplibre.org - with tags for bounties for example…
Next.js hosting is free on Cloudflare now BTW
On Wed, 2 Nov 2022 at 13:44, Oliver Wipfli @.***> wrote:

The current solution at https://roadmap.maplibre.org offers everything we
need:

card format with topic title and a visual
voting system (people provide email address when up-voting)
life-cycle stages

under consideration
in progress
released

The current solution uses MapTiler's productboard account, thanks @klokan
https://github.com/klokan for letting MapLibre use MapTiler's resources.
I propose that we get our own productboard account, it is USD 140 per
year. https://www.productboard.com/pricing/ If there are no objections I
will get us an account and set up the roadmap board by Thursday, Nov 3rd,
2022 hopefully.
—
Reply to this email directly, view it on GitHub
https://github.com/maplibre/maplibre/issues/125#issuecomment-1300327993,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOPFG5RULHJK3FZ7W3IGDWGJO27ANCNFSM6AAAAAAQZ3E45A
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
PETR PRIDAL
CEO
Zug, Switzerland
+41 (0)41 511 26 12
www.maptiler.com
https://www.maptiler.com?utm_source=transactional&utm_medium=email&utm_campaign=2022+|+General+|+Brand&utm_id=2022+|+General+|+Brand&utm_content=footer+|+link
https://twitter.com/maptiler/ https://www.facebook.com/MapTiler/
https://www.linkedin.com/company/maptiler/
https://www.instagram.com/maptiler/

Thanks for the feedback. Yuri and I discussed the implementation of the Bounty feedback system yesterday and we came to the conclusion that we would like to keep the barrier for people to participate as low as possible. The best way to achieve this in our opinion is to use GitHub Discussions. People are already logged into GitHub and they just need to press the green button to suggest a new Bounty and they can up-vote proposed Bounties with a +1.

https://www.boss.dev/ uses their own payment system. I would like to do everything via OpenCollective so boss seems not an option.

https://bountysource.com/about/fees/ has a 10 percent fee which they don't explain well. We already pay OpenCollective 10 percent, so let's not use that...

https://gitcoin.co/ I don't understand what it is, but it also seems to be not using OpenCollective.

I suggest we start with these t-shirt sizes:

S: $100
M: $250
L: $500

Then we can still do:

XL: $1k
XXL: $2k
XXXL: $3k

The GitHub API might help us query all the open bounties and show them in a nice overview website as @klokan suggested above.

I think the approach of managing Bounties in the respective repo works well for MapLibre GL JS and MapLibre GL Native, these probably will be the "Core Projects" in the definition of #132. If we define which projects are "Supported Projects", then they can also use the same Bounty template as the core repos.

I just want to make it clear for people how they can suggest a bounty, how they can vote for one, and how we will decide and approve bounties.

I guess we can document the rules for the bounty system here: https://github.com/maplibre/maplibre/wiki/Bounty-System and then then everyone will make sure that the same process is followed in the different repos.

Sounds good to me.

are the labels we could use

The stages could mean the following:

voting: Initial stage after someone submitted a suggestion for a Bounty. We will give people time to share feedback if they think this is a good idea. They can upvote the Bounty with :+1:.
looking for taker: A maintainer found that the Bounty in the voting stage received sufficient support and approves it. Now it is in the looking for taker stage where people can apply to take the task.
taken: Once a person has claimed the task, they are assigned the GitHub Issue and the taken-label shows that this Bounty is now being worked on.

Note that people need to be cleared as Developers to be able to work on Bounties. Like this, we know who they are, where they live, and that we can pay them with OpenCollective. The Developer role is described here: https://github.com/maplibre/maplibre/wiki/Developer-Role

Proposal: Coordinator allocates a small fraction of all bounties to get the system started. Ask Governing Board for approval.

We could start with a framework for collecting input and ideas from people. This could be as simple as a GitHub discussion...

https://github.com/maplibre/maplibre/discussions/156

Pick 3 to 5 most important directions from https://github.com/maplibre/maplibre/discussions/categories/bounties-cross-project-directions?discussions_q=category%3A"Bounties+-+cross-project+directions"+sort%3Atop and suggest to the Governing Board a split of the allocated USD 50,000 on Bounties in the budget period December - February on the directions. Goal is to have the allocation on directions published by the end of the next sprint.


[feature] strip URL params on odysee side for api.na-backend.odysee.com

Is your feature request related to a problem? Please describe.
here i'm using curl to attempt to find whether a video URL is valid (whether the video actually exists) on odysee.com by querying api.na-backend.odysee.com
in this case the JSON output correctly contains the text "name": "NOT_FOUND":
curl --header 'authority: api.na-backend.odysee.com' --header 'content-type: application/json-rpc' --data-raw '{"jsonrpc":"2.0","method":"resolve","params":{"urls":["@gonetothesnowdogs:d/no-video-here:5"]}}' --  'https://api.na-backend.odysee.com/api/v1/proxy?m=resolve'
however if the URL contains a parameter (@gonetothesnowdogs:d/no-video-here:5?param), the result is not entirely expected:
"error": "@gonetothesnowdogs:d/no-video-here:5?blah is not a valid url"
Describe the solution you'd like
i would propose that it might be best if URL params were dealt with (ignored) on the odysee side rather than having to strip them beforehand

We have a separate repo for the backend, but this issue probably won’t be tackled. That field is expecting an exact odysee or lbry url, which don’t have params natively. Best to do it on the client side before sending


Please add iCasa ICZB-KPD18S

Device description
Model	ICZB-KPD18S
Vendor	iCasa
Description	Zigbee 3.0 Keypad Pulse 8S
Supports	click, action, brightness, scenes
MQTT message with device information
{"ieeeAddr":"0xccccccfffe89fa99",
"type":"EndDevice",
"networkAddress":6014,
"model":"ICZB-KPD18S",
"vendor":"iCasa",
"description":"Zigbee 3.0 Keypad Pulse 8S",
"friendly_name":"Switch",
"manufacturerID":4644,
"manufacturerName":"icasa",
"powerSource":"Battery",
"modelID":"ICZB-KPD18S",
"hardwareVersion":0,
"softwareBuildID":"2.5.3_r20",
"dateCode":"NULL",
"lastSeen":1590433139448}
MQTT messages from device
Off:
{"linkquality":49,"battery":50,"rate":50,"brightness":245,"click":"off"}
Longpress Off, brightness is counting down
OnPress
{"linkquality":76,"battery":50,"rate":50,"brightness":92,"action":"rotate_left"}
OnRelease
{"linkquality":76,"battery":50,"rate":50,"brightness":92,"action":"rotate_stop"}
On:
{"linkquality":60,"battery":50,"rate":50,"brightness":92,"click":"on"}
Longpress On:
On Press, brightness is counting up
{"linkquality":76,"battery":50,"rate":50,"brightness":92,"action":"rotate_right"}
OnRelease:
{"linkquality":60,"battery":50,"rate":50,"brightness":92,"action":"rotate_stop"}
S1
{"linkquality":60,"battery":50,"rate":50,"brightness":182,"click":1}
S2
{"linkquality":52,"battery":50,"rate":50,"brightness":182,"click":2}
S3
{"linkquality":60,"battery":50,"rate":50,"brightness":182,"click":3}
S4
{"linkquality":60,"battery":50,"rate":50,"brightness":182,"click":4}
S5
{"linkquality":60,"battery":50,"rate":50,"brightness":182,"click":5}
S6
{"linkquality":57,"battery":50,"rate":50,"brightness":182,"click":6}
MQTT state change commands
If device supports state change put MQTT topics + payload examples to change device state here
Thanks in Advance!!

Yes, i also have an iCasa KPD18S.
It would be great to get it work.

Could you please update plugin and check

I did an update.
The log in domoticz says: this plugin does not support zigbee device with model "ICZB-KPD18S" yet
It is visible in zigbee2mqtt (under Custom tab) when i pair it in Domoticz.

Probably the plugin wasn't updated for some reason, could you please check that you have the latest version from master branch

Thanks a lot! I did an update an the device appeared in the Domoticz devices list.
One Selector Switch with 'on', 'off' and 'S1' to 'S6' levels.
One Dimmer Switch to control the Brightness.
Three General Devices for Battery and Link Quality Status and one for Voltage.
It seems that it works pretty well, but it throws a message in the logs, when I try to switch a level directly in domoticz. It Wer I'll also not switch the scene. Using the Hardware is working. This is the Mrssage:
(Zigbee2Mqtt) Update command has not been implemented for device "iCasaSW (State)"
I assume, that is has something to do with MQTT state change commands, that I've not specified (because of lack of knowledge), possible?

Probably the plugin wasn't updated for some reason, could you please check that you have the latest version from master branch

Yes, found it.
New device with s1 to s6, on off etc.
Testing the next days.
Thanks a lot

The device is visible in domoticz and switches, but doesnt switch while pressing a button on the icasa device, or while select ON, S1, S2 etc on the switch in domoticz

@TheOlfer could you please update once again and check.
@maxwicky what do you mean by doesnt switch while pressing a button, does it mean that status is not updated in Domoticz when you press button on device. @TheOlfer do you have the same issue?

Yes, when i set to ON, it doesnt switch to ON but stays OFF (see picture)
Also when pressing wallswitch ON button it stays OFF

@stas-demydiuk I did and the controller itself is working flawlessly for me. I'm on latest beta at dodoticz, if this helps.
Details:
Pressing On button - - > Dmtcz changes Selector Switch to  Level On and changes State to On
Pressing Off button - - > Dmtcz changes to Level Off and changes State to Off
Pressing Buttons S1 to S6 changesevel accordingly
Long press Off will decrease the dimmer switch value and it stops on release.
Long press On will increase the dimmer switch value and it stops on release
Tests in Domoticz without HW
Selector Switch state is Off, Level is Off:
Pressing Icon in UI to to turn Device On - - > nothing happens, no log entry, no UI popup
Changing Level to On - - > popup appears with info, that device will switch on. Device State will stay Off, log entry:
2020-06-03 21:22:40.647 (Zigbee2Mqtt) Update command has not been implemented for device "iCasa SW (State)"
2020-06-03 21:22:40.610 Status: User: Admin initiated a switch command (298/iCasa SW (State)/Set Level)
Almost the same if Device State is On:
Pressing Icon in UI to turn device Off--> popup appears to inform that device will switch off, device will stay On, level will not change, log entry:
2020-06-03 21:26:28.921 (Zigbee2Mqtt) Update command has not been implemented for device "iCasa SW (State)"
2020-06-03 21:26:28.902 Status: User: Admin initiated a switch command (298/iCasa SW (State)/Off)
Same for Device state is On
Changing level in UI - - > popup appears to inform that level will change. State will not change, entry in log:
2020-06-03 21:31:05.235 (Zigbee2Mqtt) Update command has not been implemented for device "iCasa SW (State)"
2020-06-03 21:31:05.219 Status: User: Admin initiated a switch command (298/iCasa SW (State)/Set Level)

It is working.
I had 2 zigbee2mqtt plugin-folders (dont know why), i updated both and now it is working.


MONDO:0017454 triphalangeal thumb-polysyndactyly syndrome

Mondo term (ID and Label):
MONDO:0017454 triphalangeal thumb-polysyndactyly syndrome
Xref that should be fixed (ID and label):
Add? OMIM 190605 https://www.omim.org/entry/190605
What is Mondo doing with OrphaNet:2950? https://www.orpha.net/consor/cgi-bin/OC_Exp.php?Expert=2950 "This entity has been excluded from the Orphanet nomenclature of rare diseases and moved to Tibial hemimelia-polysyndactyly-triphalangeal thumb syndrome"
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here
Other comments:
I am struggling to differentiate between the diseases on https://omim.org/entry/174500 and https://www.omim.org/entry/190605   Clearly these are highly similar phenotypes, linked to the same underlying molecular cause, so probably a fuzzy spectrum but OMIM has determined they are different enough to warrant splitting to two records. (Also,  OMIM 's alt name on 174500 conflicts with 190605 al name, so MedGen will have to figure out which record gets that name...  right now it's on the term with the Mondo ID and obsolete OrphaID, but should either of these MIM#s map to this Mondo record??)

Based on my analysis, this is what should be done:
1) MONDO:0017454-’triphalangeal thumb-polysyndactyly syndrome'
(currently Orphanet:2950, but this orphanet was replaced by orphanet:988)
to do:
[ ] make Orphanet:2950 : MONDO:equivalentOBSOLETE
- Based on the definition, the orphanet replacement is not appropriate (it is more specific) to be equivalent to this MONDO term.
- In orphanet, Orphanet:2950 is mapped to OMIM:174500, but it does not look appropriate based on the definition
[ ] OMIM:190605 should be added as an Equivalent
2) MONDO:0008572, MONDO:0020306, MONDO:0018052 should be merged

Based on the orphanet definition, MONDO:0008572 and MONDO:0020306 refer to the same disease.
Based on orphanet record replacement, MONDO:0018052 should be merged to MONDO:0020306

x-ref to review:
Orphanet:3332 (= OMIM:188740) → was replaced with ORPHA:988 → should be MONDO:equivalentObsolete
MESH:C566046 should be “preferred”
UMLS:CN204341 → should be MONDO:equivalentObsolete

3) OMIM:174500 vs OMIM:190605

note that OMIM:174500 has RIPHALANGEAL THUMB, INCLUDED; TPT, INCLUDED
these 2 terms do share some synonyms. It is unclear what the difference between these 2 terms is.
To do: ask @ahamosh

sounds like a good plan!

OMIM:174500 and OMIM:190605 are 2 different entries in omim:
a variation in the enhancer leads to a change in the shh pathway in the hand development. The outcome is due to "chance", but the outcome is different, and therefore 2 different entries were created

I think this issue is done and can be closed


Add support for DuckDB arrays when using Arrow's FixedSizeList

c5c104c commit is main change.
For Arrow's FixedSizeList, it should translate to a fixed size array in DuckDB.

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.19%. Comparing base (b82db39) to head (666a649).
Report is 14 commits behind head on main.

Files
Patch %
Lines

src/vtab/arrow.rs
0.00%
4 Missing :warning:

src/vtab/logical_type.rs
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   61.50%   65.19%   +3.68%
==========================================
  Files          36       36
  Lines        2146     2333     +187
==========================================
+ Hits         1320     1521     +201
+ Misses        826      812      -14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


extend executable create tensor APIs

@jbobba yes updated now to pass memory_pointers to CPUTensorView. Will see if there is a unittest we can extend/reuse, or add.

Just curious:
What are the possible uses/benefits of passing the memory_pointer for tensor creation for backends other than (CPU/Interpreter)? The backend will read/write to/from the memory pointer passed in the read write api calls.

Adding @MrGeva to comment on this API. Is it ok if we pass in the TF raw pointers in like executable->create_tensor() rather than backend->create_tensor(). This will require some code changes from your end in the nnpi-transformer?

some backends want to directly DMA the data from framework buffer into device memory. Without this memory_pointer (from framework), ngraph tensor will have to allocate/maintain intermediate buffer.
2 new APIs, wait_to_read and wait_to_write, will be added to ngraph::tensor to support this use-case. Instead of read/write calls, users would call these wait_to_xx APIs (no read/write memory pointer needed, these APIs will be implemented by each backend to indicate when the tensor is computed)


Add [MajidBND] #wallet GBEWMS…KV75B2

Address: GBEWMSMBDKLPP77HINZLZFGGIN6TEX7NTMASYLMA554J2ALR5YKV75B2
Tags: wallet
Title: MajidBND
Requested by @majibnd

Hello @MajiBND
Can you give more details to what your reported issue is. It appears that maybe you are requesting to have your personal wallet labeled. With over 7 million accounts it is not something that we add to our database about information on the Stellar blockchain. I am sure you can understand this point.
Looking towards the future with you,
Rob

@MajiBND
If you have additional information to report please feel free to reopen this issue,
Looking towards the future with you,
Rob


Release Google.Maps.FleetEngine.Delivery.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Maps.FleetEngine.Delivery.V1-1.0.0-beta01


Do not generate consumes for requests without body

If you define something like
consumes: application/json

on top of your swagger file and then generate Spring MVC controller interfaces for a
GET /myResource

endpoint, the following annotation will be generated:
@RequestMapping(value="/purchase-orders", method=RequestMethod.GET , consumes={ "application/json" })

The Spring docs say about consumes:

The format is a single media type or a sequence of media types, with a request only mapped if the Content-Type matches one of these media types.

And Spring is pretty strict here: if the Content-Type header is missing, it will return a 400 status code. This does not seem to be what we want here: Defining a Content-Type header without sending a request body makes no sense, and GET requests are not meant to have a request body. So i guess, it is better to just leave this out for methods without body.

I would say you should not use consumes: application/json at the top level of your file, just for this reason.
But yes, the consumes property obviously only applies to operations which have a request body.

@BGehrels
I agree with @ePaul here.
But try out version 0.4.30. Let me know about issues with that version or close this issues if you think it's fixed.

Seems to me everything working as expected? Reopen if needed.


Add Browser user agent to order

I've had a couple of issues where it would have been useful to see what browser / device was used when the order was placed.
This pull request adds the user agent to the order table. This is visible in the order summary page within the dashboard.

I can see where this would be useful.
My only concern is in regards to the GDPR, I'm under the impression that you wouldn't be able to store this data and remain compliant, perhaps because it's not part of the minimum amount of data required to place the order. (I'm aware it's likely to be in the webserver's access logs though)
So this might also need to be something that is configurable, and off by default.

Yes you correct,
I'll add an option to the orders setting page so this can be switched on.

@Mesuva I have made those changes.
You can now choose to log the user agent, off by default.

Looks great, all merged. Appreciate your contribution!


Integration of various contributions

Jake,
Hi, This represents a set of changes that I have integrated from various contributors. I have tested this for a few weeks now and not found any problems.
I will publish this as a new module, but if you take in this pull request I will remove it.
Thanks
Mike

Thank you Mike, I really appreciate it. It's been too long since I updated this library and I have been hoping to give it some attention before the end of the year and this will help very much with that effort. I will take a closer look and merge these changes in sometime towards the end of this week.

Jake,
No worries, it is a testament to the quality of the code how little
needs fixing :)
Mikw

I'm (finally) making a point release to catch up on some of these outstanding issues:

Add instructions to install from npm

Yes, merged.

Added tryTo method

Held this one back, it doesn't feel like a good idea - the caller should know whether or not a transition is allowed. I'd like to see a real use case for it.

Added grunt build automation

Partial - I did switch to using uglify for minification (and removed the need for Java YUI Compressor and Ruby rake task) - but skipped need for grunt build - just use raw npm instead npm run minify

added transitionTo and fixed bug in can(e)

Partial - I did fix the bug in can(e), but I held back transitionTo - Firstly, my preferences is that if you need to transition to a given state you should explicitly define an event for that transition. Secondly, the given solution finds the first event that transitions to that state and executes it - which feels very arbitrary (there can be multiple events that transition to that state, why the first one). I'd like to give this some thought in v3 and provide a solution that simply transitions without having to find an existing event.

Demo can send event regardless of status

Skipped this, the ability to dynamically enable/disable buttons when transitions are innapropriate is an important part of the demo.


Wrap plugin style isn’t shown inside a list

It was working as expected into Argon Alt template but isn’t with Read The DOKUS template.

Did you put "admonition,danger,caution,note,tip" to wrap plugin's "noPrefix" option as my document says? If so remove them and it would work fine. Wrap plugin uses "wrap_tip" class so you can't put "tip" into that option.
This means if you want to use both wrap plugin tip and readthedokus admonition, you can't use wrap plugin for readthedokus admonition.

Oh, I did. Strange is that it's there but Wrap still works outside of the lists as expected. Not sure what's going on. Anyway, I'll use BatchEdit to change all wrap styles for the template style. Thank you!


Awake does not working

Microsoft PowerToys version
0.41.4
Running as admin

[ ] Yes

Area(s) with issue?
Awake
Steps to reproduce
The new feature Awake is impossible to start.
It starts passive, as in the settings, but every menu action yuo try to click in order to disable screen saver does absolutely nothing and everything remains the same (Passive).
Tried as administrator and rebooting PC.
✔ Expected Behavior
No response
❌ Actual Behavior
Nothing
Other Software
No response

Same thing here.  I can only change it in the PowerToys GUI, not through the system tray icon context menu.
Currently I use Caffeine ( https://zhornsoftware.co.uk/caffeine/ ) and it works fine.
With Awake should I be able to turn it on / off by double clicking the system tray icon?
I'm on Windows 10 Pro 21H1 (19043.1081), it's a pretty fresh/clean install only done a week or two back.

Duplicate of https://github.com/microsoft/PowerToys/issues/12145
Work to solve it is being done in https://github.com/microsoft/PowerToys/pull/12215
In the meantime, using the settings to change Awake's behavior is the current workaround.


Is SC a P2P comm?

Hi everyone. I just have a simple question. SC is for Realtime communication as I understand. Now I wonder when I publish a message to a channel and another user is subscribed to that channel, are we two connected directly or always everything passes from server?
Are we using P2P comm in SC? If not, how we call it realtime? maybe I'm wrong in defining realtime, but I though in realtime there should be no middle thing.

Real-time just means that the message is pushed to the user with very little delay. You can build P2P servers using SocketCluster but it's not a WebRTC framework..


Firebase Push notification Problem

Scene1:
When i tried to send push notifications manually via Firebase coud Messaging console,it shows notifications without sound alert
Scene2:
When i disconnect my device then Restarted the "Run" in Adroid studio,its not receiving any Notifications, [I MUST HAVE TO Go to my Mobile settings>Notifications>selecting the app then toggle between Turn Off And Turn On the "Show Notifications"]
Scene3:
Even I have typed onresume(),onmessage(),onLaunch() functions,Its not showing notifications after closing the app
Scene4:
When i try to trigger Firebase Realtime Database,[When a entry is added or deleted i must receive notifications] its not working,But the code itself is deployed successfully??
Scene5:
Scheduled notifications are working fine with sound alerts too..but firebase notificationsare not working
Device: REDMI 4
IDE: VsCode ,Android Studio,

I think this needs more information.

output of flutter doctor
what is the content of the messages you sent?
did you follow all the steps in the plugin README.md?

I think for sound notification: {sound: 'default', ... is required.
For notifications to be received when the app is not running data: { click_action: 'FLUTTER_NOTIFICATION_CLICK', ... needs to be added.

@zoechi  the sound issue is fixed by adding ur line.
Now the only issue is,when the app is minimized it shows notification,when the app is opened and i'm viewing the app its not showing notifications.
So I created a testing app with schedule notification library example,it shows notification even the app is opened and minimized,theres no issues.
then i decided to Add this shcedule notification project's .dart file as a new page
on my Existing project,but this time the schedule ntofication is also not showing anything

See also https://stackoverflow.com/questions/50849185/flutter-firebase-push-notification-50-not-working

@zoechi its me, the same person brother

@rajeshjeshar can this issue be closed?

@zoechi yes this can be closed and notifications are working 100%,now i'm writing a medium post on the way so it can be closed now thanks

Thanks for the update.
Please post the link when the article becomes available.

@zoechi here is the post in medium thanks>>
https://medium.com/@rajeshjr/flutter-firestore-push-notification-on-data-change-youtube-style-subscribing-notifications-one-to-b09654db19e0

when i try to onBackgroundMessage its says unknown paramter

when i try to onBackgroundMessage its says unknown paramter

There is no onBackgroundMessage inf Firebase messagiung Plugin.Hope you are asking about the OnLaunch() OnResume() methods ??

Yes there is in the new version of flutter_messaging plugin
On Fri, Oct 4, 2019 at 7:46 PM rajeshjeshar<EMAIL_ADDRESS>wrote:

when i try to onBackgroundMessage its says unknown paramter
There is no onBackgroundMessage inf Firebase messagiung Plugin.Hope you
are asking about the OnLaunch() OnResume() methods ??
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/18192?email_source=notifications&email_token=AGKYYNH7Q7GMFJ4TWKKR2ZDQM5XQFA5CNFSM4FDJLQO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMHQIQ#issuecomment-538474530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGKYYNBV4DNDHYSO2H46UGDQM5XQFANCNFSM4FDJLQOQ
.

when i try to onBackgroundMessage its says unknown paramter

There is no onBackgroundMessage inf Firebase messagiung Plugin.Hope you are asking about the OnLaunch() OnResume() methods ??

I think there is in the new flutter_messaging plugin version

when i try to onBackgroundMessage its says unknown paramter

There is no onBackgroundMessage inf Firebase messagiung Plugin.Hope you are asking about the OnLaunch() OnResume() methods ??

I think there is in the new flutter_messaging plugin version

Yeah! sorry Just now i've seen that change Log.

@rajeshjeshar
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/809. Any further collaboration will be done there.

const payload = {
                notification: {
                    title: 'You have a new trip to '+dropLocation,
                    body: 'You have a trip to '+ dropLocation+' at ' + tripTime + ' on '+ tripDate,
                    sound: 'default',
                }
            };

            captainFirebase.messaging().sendToDevice(_token.data().token, payload);

I am using this code but the sound in not there when the notification is delivered.

@shikharvaish28 did you find any solution yet ?


im not able to set default value

how to show selected value in ngModel ? in first?

ngModel is a two-way binding directive. So you just need to give your variable a value, it will auto select the value.
For example, you can make it change when ngOnInit is fired.
@Component({
  selector: 'app-root',
  templateUrl:
    '<select2 [options]="options" [(ngModel)]="optionSelected"></select2>'
})
export class AppComponent implements OnInit {
  options: any[] = ['1-1', '1-2', '1-3', '1-4', '1-5'];
  optionSelected: any;

  ngOnInit() {
    this.optionSelected = '1-1';
  }
}

if its in key value pair ? how should i set ?

We use {id, text} pair in select2.

how to set default can u give example ?

@Component({
  selector: 'app-root',
  templateUrl:
    '<select2 [options]="options" [(ngModel)]="optionSelected"></select2>'
})
export class AppComponent implements OnInit {
  options: any[] = [{id: '1-1value', text: '1-1key'}, {id: '1-2value', text: '1-2key'}, {id: '1-3value', text: '1-3key'}];
  optionSelected: any;

  ngOnInit() {
    this.optionSelected = '1-2value';
  }
}

Could you please clone the demo and run it on your machine? Any more question, please put your code here.

can i keep placeholder for this? Thankyou in advance

You can set the placeholder through settings, see Select2 options API.

hello, thankyou for support, i have done for setting default value: like this,
@Component({
selector: 'app-root',
templateUrl:
'<select2 [options]="options" [(ngModel)]="optionSelected">'
})
export class AppComponent implements OnInit {
options: any[] = [{id: '1-1value', text: '1-1key'}, {id: '1-2value', text: '1-2key'}, {id: '1-3value', text: '1-3key'}];
optionSelected: any;
ngOnInit() {
this.optionSelected = this.options[0].text;
}
}
its not showing value ? help me

You should bind ngModel to the value. That means to use this.optionSelected = this.options[0].id; instead of this.optionSelected = this.options[0].text;.


Sunburst chart not resizing based on window size

I am using sunburst chart in one my application. When I resize the window, the chart will not adjust accordingly without a screen refresh. Is there any solution available for this ?

See nv.d3.js file and look for functions,
innerRadFunction and outerRadFunction.
These are what you need.
And try having your own radius using
$(document).width() and $(document).height()


fix: silence sleep_heartbeats in unusedTactic

Found thanks to the large-import label on #12339.

I added the sleep_heatbeats exception to the unusedTactic linter.  Let me know if you this is preferable to simply do nothing, as I can see arguments both ways.

On the one hand, I expect sleep_heartbeats to (almost) never make it into final code, so having to silence it by setting the linter option is certainly a reasonable expectation.
On the other hand, sleep_heatbeats is mostly a debugging/testing tool, so it also makes sense that you would not have to want to add clutter by having to further silence the linter, or see its warnings.

I am happy either way!

Thanks!
bors r+


ClosePseudoConsole does not close the process handle to conhost

Windows Terminal version
N/A
Windows build number
10.0.22631.4037 (Windows 11 Pro, 23H2)
Other Software
(None, just Kernel32)
Steps to reproduce
Run the EchoCon sample and observe its handles before/after the ClosePseudoConsole call.

Add a breakpoint at ClosePseudoConsole(hPC)
Start debugging
Run handle.exe -p EchoCon.exe -a | findstr Process when the program breaks at ClosePseudoConsole(hPC)
Step over
Run handle.exe -p EchoCon.exe -a | findstr Process

Expected Behavior
ClosePseudoConsole closes the handle to conhost.exe.
Actual Behavior
ClosePseudoConsole does not close the handle to conhost.exe (leaks the handle).
This looks like a Kernel32 version of #8706.
D:\>REM break just before ClosePseudoConsole(hPC)

D:\>handle -p EchoCon.exe -a | findstr Process
   E0: Process       conhost.exe(34388)

D:\>REM step over ClosePseudoConsole(hPC)

D:\>handle -p EchoCon.exe -a | findstr Process
   E0: Process       <Nonexistent process>(34388)

I checked the corresponding branch internally and it doesn't include the CloseHandle fix. The good news at least is that 24h2 doesn't have this issue.

We can probably close this as fix-checked-in, right? I'm not sure we can backport that...
(if you want to backport it, go for it)

Thank you! I'm glad to hear this is already fixed in the insider build. I have confirmed the fix with 10.0.26120.1542 (Dev Channel).
If backporting is not planned, please feel free to close this as fixed.


Workaround for parsing colons in partial URLs

Whenever a URL contains no host part, the presence of a colon will make
PHP's parse_url fail. To workaround this bug, we need to encode the
colon in this situation.
However we do not encode colons for full URLs.
Fixes https://github.com/fruux/sabre-uri/issues/9
@evert would you accept a backport for this to the sabre-uri 1.0 series ? (not sure how to proceed, no stable branches ?)
Please review

Fixed indents

Hey!
This is a good patch, but I'm going to spend an hour or so trying an alternative route: a full regexp replacement of parse_url. The reason for this is because there is also issue #11 and I might be able to kill two birds with one stone. If I'm not successful within the hour I will give up and merge this instead.
I'll also open a 1.0 branch and backport this change.

Ah this patch is actually flawed. It urlencodes any : as far as I can tell.

Ah this patch is actually flawed. It urlencodes any : as far as I can tell.

Yes, but only does it for relative URLs, not absolute URLs. Somehow the PHP bug only affects relative URLs.
Anyway, will check your other patch. Thanks!