images retrieve

hi folks, i have a doubt about cri-o container runtime,when i use cri-o as  container runtime ,why some local images can only retrieve by ctictl --runtime-endpoint "/var/run/crio/crio.sock" images,and docker images or atomic images list can't find them.Don't all imags respect the OCI Image Format Specification  ? Is this because of storage or docker-shim? thanks a lot.

CRI-O and Docker use different storage backends.  If you use podman images, you should see the images.
We are working on integrating atomic and podman, by adding a varlink interface to podman and then atomic will be able to list images stored in containers/storage created by buildah/podman or CRI-O.

@rhatdan thanks.


Deprecate and move to prometheus-junkyard…

…once https://github.com/prometheus/prometheus/issues/1605 is done.

Since the CLI will not work with Prometheus 1.0.0 anymore, we should move it to the junkyard right now, even without the querying functionality in promtool.
@brian-brazil @fabxc Any objections?

sgtm

I'll move this over now and send an announcement mail.


docs: make docs produces unexpected changes

Thanos, Prometheus and Golang version used:
Thanos PR https://github.com/thanos-io/thanos/pull/2989
Golang version 1.14 darwin/amd64

Object Storage Provider:
What happened:
$ git diff
diff --git a/docs/components/compact.md b/docs/components/compact.md
index ee924bfd..20e7276d 100644
--- a/docs/components/compact.md
+++ b/docs/components/compact.md
@@ -80,7 +80,7 @@ In order to achieve this co-ordination, blocks are not deleted directly. Instead
 ```$
 usage: thanos compact [<flags>]

-continuously compacts blocks in an object store bucket
+continuously compacts blocks in an object store bucke

 Flags:
   -h, --help                    Show context-sensitive help (also try
@@ -110,8 +110,8 @@ Flags:
                                 https://thanos.io/storage.md/#configuration
       --objstore.config=<content>
                                 Alternative to 'objstore.config-file' flag
-                                (lower priority). Content of YAML file that
-                                contains object store configuration. See format
+                                (lower priority). Content of YAML file tha
+                                contains object store configuration. See forma
                                 details:
                                 https://thanos.io/storage.md/#configuration
       --consistency-delay=30m   Minimum age of fresh (non-compacted) blocks
@@ -136,7 +136,7 @@ Flags:
                                 runs and bucket refreshes. Only works when
                                 --wait flag specified.
       --downsampling.disable    Disables downsampling. This is not recommended
-                                as querying long time ranges without
+                                as querying long time ranges withou
                                 non-downsampled data is not efficient and useful
                                 e.g it is not possible to render all samples for
                                 a human eye anyway
.
.
.
(lots more like this)

What you expected to happen:
No changes.
How to reproduce it (as minimally and precisely as possible):
make docs
Full logs to relevant components:
$ make docs
all modules verified
>> building Thanos binary in /Users/annanay/Desktop/git/go/bin
 >   thanos
msg=success
sed: 1: "./CODE_OF_CONDUCT.md": invalid command code .
make: *** [docs] Error 1

Anything else we need to know:

I guess make docs actually adds in the changes for the documents so that make check-docs pass.

@annanay25  It looks like a OS X issues. OS X uses BSD-based tooling. In scripts we use GNU-based tooling. This could be related to that.
Could you please check this page and give it another shot with that tooling.

I'll take a look as soon as I can :)


Tagging (phase-III) lets center environment into minipage

I encountered the following with a verbatim environment inside a centered minipage. Without tagging, the minipage is centered, but the verbatim content inside the minipage is not centered (as desired).  With tagging, the verbatim material is centered.
\DocumentMetadata
{
	pdfstandard = a-4f,
	pdfversion  = 2.0,
	lang		= en-US,
	testphase = {phase-III}, % <==== with testphase, the verbatim code becomes centered.
}
\documentclass[11pt]{article}

\newcommand*{\Sphinx}{I won't say. }

\begin{document}

\begin{center}
\begin{minipage}{0.8\textwidth}
\begin{verbatim}

\Sphinx\Sphinx\Sphinx\Sphinx\Sphinx\Sphinx\Sphinx
\Sphinx\Sphinx\Sphinx\Sphinx\Sphinx
\Sphinx\Sphinx\Sphinx

\end{verbatim}
\end{minipage}
\end{center}

\end{document}

Well it is not the minipage. You get similar problems without it. The problem is that the display environments do not reset the para-instance. That means they inherit from the center environment.   You can change that with the optional argument
\begin{verbatim}[para-instance=justify]

Generally, in standard LaTeX a list resets parts of the values, e.g. the leftskip is always 0pt. But it doesn't look very consistent, e.g. a \raggedleft outside gives a \raggedright inside the list, so I'm not sure if that is by design ...
\documentclass[11pt]{article}

\usepackage{lipsum}
\begin{document}

\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\raggedright
\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\raggedleft
\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\end{document}

With the block code one could reset the para-instance:
\DocumentMetadata
{
	pdfstandard = a-4f,
	pdfversion  = 2.0,
	lang		= en-US,
	testphase = {block}, %
}
\documentclass[11pt]{article}

\usepackage{lipsum}
\begin{document}
\RenewDocumentEnvironment{itemize}{!O{}}
    { \UseInstance{blockenv}{itemize} {para-instance=justify,#1} } %<-----------
    { \endblockenv }

\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\raggedright
\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\raggedleft
\lipsum[1][1-4]
\begin{center}
\begin{itemize}
\item \lipsum[1][1-4]
\end{itemize}
\end{center}

\end{document}

This gives always justified paragraphs inside the list. But I couldn't setup a para-instance that reproduce the standard latex setup and I'm not sure what we really want here.

I think the expectation is that verbatim is verbatim, thus in  an LR document it should always be left aligned. One can argue about whether or not other lists should inherit values or not, but for verbatim I think it is simply a bug.
\EditInstance{blockenv}{verbatim}{ para-instance=justify }

fixes that, but I think it should be set this way in latex-lab-block already.

For verbatim this is fixed in develop. For other lists this is now referenced in #546

Confirming fixed in dev and closing.


max longitude

I was following your example method to get the map region in MapViewController and noticed a minor issue. I haven't tried to run this code, but figured I'd point it out for posterity:
https://github.com/kevinvanderlugt/Swift-Walk-Tracker/blob/master/walktracker/MapViewController.swift#L147
I believe that location.coordinate.latitude > maxLongitude should be location.coordinate.longitude > maxLongitude

Howdy,
Thanks so much for looking at my project and taking the time to write up this issue.  You are correct in finding this issue.  I will try to get it fixed up shortly since I want to move to swift 2.0 soon as well.
Cheers! :beers:


[Project]: Hello world

Name
Test
Email Address
<EMAIL_ADDRESS>Email Addresses of Team Members
<EMAIL_ADDRESS>Project Description
test
Inspiration behind the Project
test
Tech Stack
test
Hackathon Track
Undergraduate
Project Repo
test
Demo Video/Photos
test
Anything Else?
test
Rules and Code of Conduct

[X] I agree to follow this BostonBridge hackathon's Rules and Code of Conduct

🎉 Thank you for submitting your project to the BostonBridge Hackathon 2024! 🎉
Hi @leiDnedyA!! We've successfully received your submission. Here's a quick rundown of what happens next:

Submission Review: Our judges will review your submission to ensure it meets all the hackathon criteria.
Presentation: You will be invited to present your project to the judges and other participants, you will have 3 minutes to present your project and 2 minutes for Q&A.
Notification: You'll be updated about the status of your submission as soon as the review is complete.

🔍 In the Meantime:

If you need to update your submission or have any queries, feel free to reply to this issue.
Keep an eye on this thread for any updates or further instructions.

🍀 Good Luck!
We're thrilled to see your innovative solution and wish you the best in the hackathon.
Best Regards,
BostonBridge Hackathon Team


Release idle agents

This PR generates a process that runs every 60 seconds and check if an agent was idle for more that 24 hours. In that case, the agent is shut down, releasing locked lmdb files and terminating its doers.

When a client boot an agent or connect to the agent, KERIA instantiates the Agent that opens several databases. That agent lives until KERIA is restarted. So, every time a client connects to its agent, KERIA  locks many LMDB databases forever or until KERIA is restated, causing file locks and virtual memory consumption. We detected that when the amount of users grows, it may impact performance of the OS slowing down KERIA responses.
Regarding your questions:
1- Yes
2- The long running escrows will be terminated. You should launch it again. However, we set an idle time for 24hours because no escrows last that much, at least as far as I know.
3- same as above. It's the same scenario that KERIA already have when the escrows timeout, usually after 1 hour. In the IPEX case, the user should connect again and 're-join" a multisig event.

Also, what do you think about a Releaser base class, with subclasses like EscrowReleaser, etc?
What's the purpose of subclassing here?

When a client boot an agent or connect to the agent, KERIA instantiates the Agent that opens several databases. That agent lives until KERIA is restarted. So, every time a client connects to its agent, KERIA locks many LMDB databases forever or until KERIA is restated, causing file locks and virtual memory consumption. We detected that when the amount of users grows, it may impact performance of the OS slowing down KERIA responses. Regarding your questions: 1- Yes 2- The long running escrows will be terminated. You should launch it again. However, we set an idle time for 24hours because no escrows last that much, at least as far as I know. 3- same as above. It's the same scenario that KERIA already have when the escrows timeout, usually after 1 hour. In the IPEX case, the user should connect again and 're-join" a multisig event.

Also, what do you think about a Releaser base class, with subclasses like EscrowReleaser, etc?
What's the purpose of subclassing here?

@rodolfomiranda okay thank you for the additional context!
I would prefer the following be a part of this PR but would be open to follow-on issues/PRs:

Make the release timing configurable.
Log when a release occurs in case it introduces some unexpected behavior, at least we could see in the logs that it was triggered and perhaps lead to some unexpected situations.
Tests for the Releaser.


IGNITE-8995: Catch and proper propagate uncatched exceptions from filter

and transformer to client.

The ticket is resolved, closing PR.
Please close PRs for your resolved tickets and other non-needed PRs.
Alternatively, ask a committer

to use GitHub UI (committer  can associate accounts here: https://gitbox.apache.org/setup/ )
or /scripts/apply_pull_request.sh from Apache Ignite source.
or mention in commit message 'Fixes #(a number of PR)'.

These methods will automatically close PR.
Feel free to reopen this PR if it is actual.


Fix docs for printFileSizesAfterBuild

Closes https://github.com/facebookincubator/create-react-app/issues/2357

Great, thanks so much!


[WIP] Support for elasticbeanstalk envs and apps

Description
Fixes #000.

TODOs
Read the Gruntwork contribution guidelines.

[x] Fix tests: figure out why eb env waiter times out
[ ] Finish writing + verifying tests
[x] Update the docs.
[ ] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.
[ ] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].
Migration Guide

Thanks for closing this @zackproser. Will look into this in the future and pick up where you left off! :)

@hongil0316 Roger - sounds great! I heard you are hard at work on some awesome refactoring for cloud-nuke - super cool and keep up the great work :clap:


tinkerbell: replace alpine base image

Updates the docker image as docker build fails to build the image due to
cfssl package not being present anymore in alpine packages.
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec): Step
4/5 : RUN apk add --no-cache --update --upgrade
--repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
---> Running in 11cf4dd5fd38
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
fetch
http://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
fetch
http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
fetch
http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
ERROR: unable to select packages:
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
cfssl (no such package):
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec):
required by: world[cfssl]
module.tinkerbell_sandbox.libvirt_domain.provisioner (remote-exec): The
command '/bin/sh -c apk add --no-cache --update --upgrade
--repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing cfssl'
returned a non-zero code: 1

Upon further inspection, the cfssl package is not part of Alpine
packages anymore.
https://pkgs.alpinelinux.org/packages?name=cfssl&branch=edge&maintainer=None
Signed-off-by: Imran Pochi<EMAIL_ADDRESS>

@ipochi took care of it in https://github.com/kinvolk/lokomotive/pull/1483/commits the last commit https://github.com/kinvolk/lokomotive/pull/1483/commits/05e21962d73688b45982bfe1cf206ff376fc96c7.

@ipochi took care of it in https://github.com/kinvolk/lokomotive/pull/1483/commits the last commit 05e2196.

https://github.com/kinvolk/lokomotive/pull/1483/commits/05e21962d73688b45982bfe1cf206ff376fc96c7#r648258126
Shall I close this and you'll separate out the commit from your PR ?

closing in favour of #1491

Can we remove branch as well?


Fire Bypass on factions with Lightning

Players can use the lightning enchant in other factions to cause fires, like a bypass to using a flint and steel in there base.

Hmm not sure if I will fix this. There are people that do like this. Ill close it for now. If you want ask on the discussions page what people want. You can alway turn the doFireTick off. Maybe that will do what you wanted.


[docs] Image cleanup

The Problem/Issue/Bug:
Images could generally use some tidying.
How this PR Solves The Problem:

Uses high-DPI-friendly SVG logo in readme.
Consolidates screenshots and images into content/images/ directory for easier maintenance, consistently using lowercase filenames with hypens (-) rather than underscores (_) as word separators. (Markdown references updated.)
Deletes a few unused images.
Adds alt text in a few cases where it was missing or not meaningful.
Losslessly optimizes all PNG files for ~50% savings in file weight.
Crops a number of screenshots to exclude useless cruft.
Adds step callouts to /sbin/nfsd selection screenshot.
Updates container diagram to remove redundant notes, correct casing, prioritize important pieces, and drastically reduce file weight while staying high-DPI-friendly.
Fixes squished favicon and adds a multi-resolution ICO variant.

Manual Testing Instructions:
https://ddev.readthedocs.io/en/stable/developers/testing-docs/#preview-changes
Automated Testing Overview:
n/a
Related Issue Link(s):
More #4188.
Release/Deployment notes:
n/a

Shouldn't the preview URL be https://ddev--4336.org.readthedocs.build/en/4336/ ?

What do you think about changing the container-diagram.png to mermaid, https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams#creating-mermaid-diagrams ?

Shouldn't the preview URL be https://ddev--4336.org.readthedocs.build/en/4336/ ?

It should, but I don’t understand why you’re asking. 🤔

What do you think about changing the container-diagram.png to mermaid, https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-diagrams#creating-mermaid-diagrams ?

I like the idea of using it, just not sure about the rabbit hole of styling and visual control.

Ready to roll pull!


Rename comment to description in profile's selector message

Summary
Description plays better with the FE.
Related: #3722
Change Type

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
N/A
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

There are quite a few failing checks, are we sure there isn't something to fix?

There are quite a few failing checks, are we sure there isn't something to fix?

Yes, I apologize. There were some utility functions that were using the old field. But I still think it's OK to rename the field in a backwards-compatible manner because we never implemented the handlers that would let you create selectors.


doc(init): added org-wide health files

Proposed changes
organization-wide PR template
Types of changes
What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
-/-

Does this work?

Yes. github.blog/changelog/2019-02-21-organization-wide-community-health-files

Neat, can you add a security template too?

Also, Codeowners.
* @ScuffleTV/maintainers

ready


simple chat coding exercise

Please check loom video here: https://www.loom.com/share/bf857f198af74d6f9638eb3c8b4f4114?sid=27f9a253-fc4a-406a-b48c-3a92bf8729a7

Description: My commit messages are not that descriptive. Here is high level architecture:

Server: I use a HashMap to save state about users based on socket/address. Server is not backed by persistent, if needed I can add persistent and have data backed by a db. Here, if we shutdown server, state is lost
The server keeps listening for join requests and messages from clients and send back to other connected clients. I am using Tokio crate.
Client: A client can send message to server using SEND . It can also leave whenever it wants to.

also both mypickly and rsouvik are just me; let me know if any other info is needed!!


add Icon

Build is broken here @SimonCropp

one test failing. but it looks un-related to this change

Can you tweak the icon a little bit on the site?

docfx build docfx_project/docfx.json -o /docs
cd docs
docfx serve


CLIMATE-564 - Managing multiple netcdf files stored on a local machine

A new file loader load_multiple_files can read netcdf files with common file name patterns.

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Passed.

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Passed.


clean up the repository

@Math-TECH-Hub → can we check what we can clean up a bit in this Repo after merging #14 ?

[ ] do we need the picture?
[ ] can we have all files in Markdown .md format?
[ ] proper file naming can be improved a bit?
[ ] anything else?

@PyGamma @gibertgibs @chardso anything to add?

@PyGamma @gibertgibs @chardso anything to add?

Will share my comment soon...just have to re-pass through the project.

Will share my comment soon...just have to re-pass through the project.

@gibertgibs :+1:

@gibertgibs :+1:

I think it will not change the direction of the activities, do or don't.

I think it will not change the direction of the activities, do or don't.

I guess we can go for this one? @gibertgibs also to solve #17

I guess we can go for this one? @gibertgibs also to solve #17


GLTFWrapper is missing alpha mode parameters

The alpha mode operations have to be added to the GLTFWrapper.  This should be a small change.

Created a PR for this #7

Merged


Docs

Improve docs. Move away from docusaurus to simple markdowns in the repo and better comments for GoDoc.

Drop docusaurus: https://github.com/emcfarlane/larking/pull/31


Cannot find ihook.node after build in electron-forge bases electron app

Expected Behaviour:
iohook should work after the electron build using electron forge on Windows
Current Behaviour:
When I run electron-fore start
I am getting
Cannot find the module
'C:\Users\Windows.User1\Desktop\Projects\desktop-screen-capture.webpack\main\builds\electron-v87-win32-x64\build\Release\iohook.node'
Require stack:

C:\Users\Windows.User1\Desktop\Projects\desktop-screen-capture.webpack\main\index.js
C:\Users\Windows.User1\Desktop\Projects\desktop-screen-capture\node_modules\electron\dist\resources\default_app.asar\main.js
This is my current setup:
"iohook": {
"targets": [
"node-83",
"electron-87"
],
"platforms": [
"win32",
"darwin"
],
"arches": [
"x64",
"ia32"
]
},
iohook is in my dependencies
"dependencies": {
"@sentry/electron": "^2.4.1",
"axios": "^0.21.1",
"check-disk-space": "^3.0.1",
"copy-webpack-plugin": "^6.2.1",
"electron-squirrel-startup": "^1.0.0",
"iohook": "^0.9.3",
"source-map": "^0.7.3",
"winston": "^3.3.3",
"winston-loggly-bulk": "^3.2.1"
}

Your Environment
electron : 12.0.4
node: 14.0
Operating System and version (desktop or mobile): Windows 10

If you added the "iohook": {"targets": [... to your package.json after installing iohook, you probably just need to reinstall iohook, that way its install script will detect the needed versions and download the prebuilds.

@marcelblum I have done this 2-3 times already. But still getting the same error in both local builds and prod build.
I can see binaries in  node_modules/iohook/builds folder.

one more things setting
externals: {
iohook: "iohook"
}
in the mainprocess webpack config make it work in dev mode. But in release mode when I build executable its shows the same error.

Sorry I don't have experience using the Webpack plugin in Forge but that may be the source of your issue, the Webpack docs on externals says:

The externals configuration option provides a way of excluding dependencies from the output bundles. Instead, the created bundle relies on that dependency to be present in the consumer's (any end-user application) environment

I do have an Electron 12 project that uses Electron Forge with iohook and I don't have any such problems. My Forge config has a line that ensures the iohook files get included in the packaged app, I am using asar but exclude the binaries from the asar to avoid issues:
packagerConfig: {
		asar: {
			unpack: "**/*.+(node|"+((process.platform == "darwin") ? "dylib" : "dll|exe")+")",
			smartUnpack: true
		},
                ...

I am not using asar packaging.
The final dependency of the packaged app is empty (i.e node_modules)
Can you try that and let me know . It's a boilerplate from forge
https://www.electronforge.io/templates/webpack-template.
It should not take you 10-15 min to test.

@deepanshushukla I'm not really sure what you're asking me to test at that template link. I'm not that familiar with Webpack (and honestly don't understand why it would be used in an Electron project but that's a different discussion...). I think your best bet, rather than trying to get Webpack to cooperate, is to add a specific Forge config directive such as postPackage to explicitly place a copy of the needed iohook files in the packaged app's node_modules.


Flash address

Hello, I want to konw if I use the FLASH_DOWNLOAD_TOOLS to flash the binary, where can I find the 0x00000.bin and what the address should I flash the program bin into? Because I tried different addr but all failed.

Hi, I will try to help you.
Honestly I don't know what you mean for ' FLASH_DOWNLOAD_TOOLS': a specific program or a generic program to flash the chip so can be I totally don't understand you question.
Anyway, using esptool I have to put:
at address 0x000 the bootloader that you can find at bootloader/firmware_prebuilt/rboot.bin.
at address 0x1000 a blanck config that you can find at bootloader/firmware_prebuilt/blank_config.bin
at address 0x2000 your program.
I hope I been useful,
Paolo

Flash download tool  is a binary download tool that can be found from the official website，and I have got the answer,thank you very much for your reply!
I will close it.


Uninstall deprecated helm release during migration process

Is your feature request related to a problem? Please describe.
Sometimes a helm release is moved to a different namespace or is renamed and moved to different helmfile.
In order to provided a smooth otomi upgrade scenario there has to be a way to automate removal of deprecated deprecated releases.
E.g.:
In release 0.16.1:
The gatekeeper-operator has been renamed to gatekeeper release and moved to from default to gatekeeper-system namespace. Therefor  gatekeeper-operator needs to be removed before applying gatekeeper` release to avoid collision of cluster wide resources.
Describe the solution you'd like A clear and concise description of what you want to happen.
Add helmfile that allows to uninstall charts.
Describe alternatives you've considered A clear and concise description of any alternative solutions or features
you've considered.
Additional context Add any other context or screenshots about the feature request here.

Logs from otomi apply
  otomi:cmd:apply:applyAll:log gatekeeper-operator      default         1               2022-04-13 14:16:56.598122605 +0000 UTC deployed        gatekeeper-v3.2.2       v3.2.2 +1s
  otomi:cmd:apply:applyAll:log release "gatekeeper-operator" uninstalled +12s

Important note: destructing running apps is not migrating them and must be avoided if those have state.
So can you please update the title to reflect this? And suggest another solution? We can think about it together...

Yes, that is correct. We need to create a document that clearly explain deprecation process.


currency conversion tool

Create a currency conversion tool in html,css and javascript.
--
Add this to your pr message
Title
Number of files/folder added
changes made
I have;

[ ] Read contibuting.md
[ ] Followed all the guidelines
[ ] Linked my tool to the index.html file
[ ] updated readme.md

I would like to work on this issue. @shubham2704

Can I work on this issue?


Zenodo update

Motivations:

zenodo.json is used by zenodo when a new DOI is created automatically when a new cut of the repo is released.
CITATION.cff is not used by zenodo when zenodo.json file also exists. So we nuke it.
The DOI to be cited is published by zenodo.org and therefore only the zenodo.json file matters.
The zenodo.json file allows for richer content, including:

creators: list of authors to be included in bibtex for DOI, these authors will incur a citation count when the DOI is referenced in published articles.
contributors: Others that contributed to the repo, including a specification of their role. These are not included in the citation for the DOI.
references:: List other articles/DOIs that the code uses/references. This allows repos generated from this base-template to reference the base-template DOI. This solves the need to include authors of the template in the contributors of the child repo.

Zenodo docs on this topic:

zenodo.jon docs
zenodo docs on contributors vs creators

Caveats:
zenodo.json is currently overloaded. It exists as both the citation of authors for the base-template DOI itself, i.e., https://zenodo.org/records/14052740 AND a simple reference of all possible SSEC authors (and importantly their orcid IDs) for the author of the child repo to prune from (saves new repo authors from having to find this elsewhere). Due to the latter use, all authors will be cited by the base-template DOI. We can either be ok with this (I am) or we can create a new auxiliary file with all orcid IDs in as reference.

@ryanhausen Waiting on #152 for that file to be added, so I've deferred to #159.

@jamienoss sounds good.

@ryanhausen This is ready for review, please. Note that I also resolved #159 in this PR. Thanks 👍


Groups restructure

@bobnik, Feel free to point out anything you want to talk about. This still has a lot of stuff broken.

Sorry my response has been so delayed - January was rough work-wise. I know this is a work-in-progress, so some of my comments may not ultimately be relevant.

Why did the layerSlice implementation need to change (removed parentId for effects, broke persisted state logic, etc)?
Why can't Shape just be a Layer (asking again)? I know we’ve discussed this, but I’m still struggling to understand the separation and its complexity.
Morph (currently) feels extraneous.
The renamed selector variables and methods seem like a personal choice, and are going to take some getting used to.

It's probably best for me to wait until you complete your changes and stabilize the branch, and we can regroup after that?

Sorry my response has been so delayed
No worries. I need to get back into this. I have lost a little familiarity already as I have gone back to work.

Why did the layerSlice implementation need to change (removed parentId for effects, broke persisted state logic, etc)?
I think this was the whole point? The layerSlice didn't match what we wanted to be able to do with groups and this entire restructure.

Effects are "owned" by the layer, not the shape. There is one big 'byId' list of them, but that is only for redux optimization. Each layer has a list of effect ids, and the ids don't need to know their parents. The persistent state logic was broken just because it was not in the MVP and I was making breaking changes. It should be easy to fix now. We also wanted to be able to save/load state, so I'm not sure persistent state is done the way we will want it, so I just removed it.

Why can't Shape just be a Layer
Layers have one kernel shape. The layer has a type, which helps us figure out which shape to use. Shapes don't have effects. Shapes don't have origins, or scale, they are just kernels. Why can't Shape be it's own class, separate from Layer?

Morph (currently) feels extraneous
I talked a bit about morph in the other comment. I am not sure what part feels extraneous. But I am happy to consider it again with you.

The renamed selector variables and methods seem like a personal choice, and are going to take some getting used to.

It felt very messy and confusing to me before. Sorry if I broke it from you. We don't have the same brain, so there is going to be some compromise. Maybe just some more comments would help, or some refinement (like orderedLayerIds) would let us both grok it right away. I was working in a vacuum a little.
Some of the most confusing things to me were the fact that we have a Circle.js, which contains code to take a json object and return a vector of points. But the state saved in the redux state isn't a Circle object, it is just the json object with the options. My brain is not used to that at all. So I was trying to make it more clear when we had the model class, and when we had the json object that describes the options. Most of the movement was to make that clearer (to me, anyway).
I don't want to spend all our time arguing over the names of things. But it does matter a lot in this project. I just don't look at the code often. So when I return, I need something that makes sense. Maybe some more comments would help. Or a cheatsheet/glossary for me.
I'm not sure if the difference is mostly because I don't work in Javascript/redux/react on anything else, or if it just because we don't work together often enough. We ought to be able to find some names that we both agree on.

RE: your various comments: makes sense. For now, I'll stay out of the code base. Let me know when you want me to look again.

This is obsolete, per #275


[semver:patch] Add suggestions from partnership review

Hey @brivu ,
Thank you so much for taking a look and for the links, your comment clarified a lot.
I have injected the parameter into the bash script via an environment variable with the most recent pushes. I believe this should address all comments mentioned on issue #3 and from my testing everything was working well, but please let me know if we missed something and we will fix it in this PR.
Thanks again!

Hey @brivu, just wanted to bump this to see if you had any extra suggestions and comments. Thank you again for all the help so far!


using helloworld example with mount

Hi everyone!
Thank you again for that nice crate!
I've been using it to implement a fuse driver for pcloud but I'm having some issue to make it work with mount or systemd. So I went back to basics and tried to use it with one of your examples, the hello-world.
I created a simple project, built it, put it in /usr/local/bin/hello-world-fuse and updated my /etc/fstab as follows
hello-world-fuse	/mnt/hello-world	fuse	ro,allow_other

But when I run sudo mount /mnt/hello-world, it hangs... Am I doing something wrong?

Thanks!
Hmm, unfortunately I've never tried using a fuser binary as part of fstab. The only thing I can think of is that maybe it's expecting some kind of handshake that fuser doesn't perform properly. I would try enabling the MountOption::AutoUnmount option. That goes through a different code path, so could have different behavior.

Enabling MountOption::AutoUnmount doesn't change anything 🤔

This may not be working because /usr/local/bin is probably removed from the PATH search when mount.fuse is eventually executed.  You could try see if putting hello-world-fuse in /sbin works for you.  This may or may not work.
My preferred way to support fstab (or systemd) mounts is to create a filesystem specific mounting binary mount.fstype in your case e.g. mount.helloworld  (avoid -'s etc because systems are weird)
If we implemented it as a shell script that looks like this:
#!/bin/sh

/usr/bin/local/hello-world-fuse mount "$@"

Some notes: You just have to take care that your binary accepts mount compatible options in args.
I've indicated that below by introducing a sub-command called mount -- you have to accept -t for filesystem type, i would suggest using that to name your fuse filesystem and make sure you accept -o ...
Hopefully this helps.


Remove version: OpenJS.NodeJS.LTS version 18.16.0

Replaced by another Pull Request
Microsoft Reviewers: Open in CodeFlow

https://www.github.com/microsoft/winget-pkgs/pull/143386#issuecomment-1986949152 [Policy] Needs-Author-Feedback

Close with reason: See discussion in above linked issue;


This page needs to state what permissions Role (Viewer, Contributor, Member, Admin) is REQUIRED to copy a report.  I spent many hours trying to get a user who had Build permissions + Viewer role the ability to copy a report to a different workspace, and it doesn't work.  Would have been nice to have known that from the documentation!!!

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83c63999-09de-cccf-ae53-ef7fcfbc1186
Version Independent ID: 39407557-14d4-f78b-bfcb-ea95cf501c47
Content: Copy reports from other apps or workspaces - Power BI
Content Source: powerbi-docs/connect-data/service-datasets-copy-reports.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thank you for the feedback, @sjs210 and for taking the time to make us aware of this. What a frustrating experience! I'm assigning this to the author of the article to consider adding those prerequisites to help future readers.

Hi, @sjs210 -- good point! I'm adding the info and a link to the article about roles in workspaces.


how to remove installed model?

I downloaded a mistral AI model, but now I want to delete this model.
However, I've searched through the entire UI and couldn't find any way to remove this model.

Currently there's no delete command from VSC, but you can go {$HOME}/.aitk/models/ folder to delete the model folder manually.

thx, resolved


Exhibits updated/created dates

This will add updated_at and created_at date fields so that caching will work properly. Please note that it does perform a data update within the migration.

Coverage increased (+0.0%) to 93.8% when pulling ccc8375923941a92fffd0911649054348490e485 on DEC-275 into b02ad5ed150303cb764b76ec62095402bbfe01a3 on master.

:+1:

Coverage increased (+0.0%) to 93.8% when pulling ec8c4f721e8b8f4a240e8c598bce08e35b193bc6 on DEC-275 into b02ad5ed150303cb764b76ec62095402bbfe01a3 on master.

:+1:


EPG

Hi @alex-ahl - thank you for your efforts on this project. I have a question with regards to the EPG data that is pulled via xtream. Does this also get proxied? I am planning to route the network of this container via a separate VPN container and I am wondering if truly everything would get proxied.
Thanks for your help!

Hi,
No worries.
The xtream data and also the individual links inside said data should be proxied.
I can't make any guarantees tough since it was a long time since I had time to work on this project.


exclude_lines in .coveragerc not being respected

Describe the bug
exclude_lines in .coveragerc are not being respected for excluding import statements and pragma: no cover.
To Reproduce
How can we reproduce the problem?  Please be specific. Don't link to a failing CI job. Answer the questions below:

What version of Python are you using? 3.8.17
What version of coverage.py shows the problem?

coverage debug sys
-- sys -------------------------------------------------------
               coverage_version: 7.2.1
                coverage_module: /opt/homebrew/lib/python3.8/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                   configs_read: /Users/jacqueline.lee/jkl/prototype/.coveragerc
                    config_file: /Users/jacqueline.lee/jkl/prototype/.coveragerc
                config_contents: b'[run]\nrelative_files = True\n# omit =\n#     # omit anything in a .local directory anywhere\n#     */.local/*\n#     # omit everything in /usr\n#     /usr/*\n#     /opt/**/*.py\n\nomit=*/site-packages/*,*/tests/*,*/.eggs/*\n\nsource =\n    /Users/jacqueline.lee/jkl/prototype/*\n\n\n[report]\n# number of digits after the decimal point to display for reported coverage percentages\nprecision = 2\n\nexclude_lines =\n    # skip any line with a `pass` (such as may be used for @abstractmethod or @suffixed_method)\n    pass\n    # skip any line with import\n    import\n\n    # standard pragma\n    pragma: no cover\n    #\\s*(pragma|PRAGMA)[:\\s]?\\s*(no|NO)\\s*(branch|BRANCH)\n\n    # skip blocks reserved for type checking\n    if TYPE_CHECKING:\n\n\n# Any line of your source code containing a match for one of these regexes is excluded from being reported as missing.\n# You can exclude lines introducing blocks, and the entire block is excluded. If you exclude a def line or decorator line, the entire function is excluded.\n# https://coverage.readthedocs.io/en/latest/excluding.html#excluding\n\nskip_empty = True'
                      data_file: -none-
                         python: 3.8.17 (default, Jun  6 2023, 17:41:59) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]
                       platform: macOS-13.5.2-arm64-arm-64bit
                 implementation: CPython
                     executable<EMAIL_ADDRESS>                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 71618
                            cwd: /Users/jacqueline.lee/jkl/prototype
                           path: /opt/homebrew/bin
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>                                 /opt/homebrew/lib/python3.8/site-packages
                    environment: GRPC_PYTHON_BUILD_SYSTEM_OPENSSL = 1
                                 GRPC_PYTHON_BUILD_SYSTEM_ZLIB = 1
                                 HOME = /Users/jacqueline.lee
                                 PYENV_SHELL = bash
                                 PYENV_VIRTUALENVWRAPPER_PREFER_PYVENV = true
                                 PYENV_VIRTUALENVWRAPPER_PYENV_VERSION = 3.6.15
                                 PYENV_VIRTUALENV_INIT = 1
                                 VIRTUALENVWRAPPER_PYTHON = /Users/jacqueline.lee/.pyenv/versions/3.6.15/bin/python
                   command_line: /opt/homebrew/bin/coverage debug sys
         sqlite3_sqlite_version: 3.43.1
             sqlite3_temp_store: 0
        sqlite3_compile_options: ATOMIC_INTRINSICS=1, COMPILER=clang-14.0.3, DEFAULT_AUTOVACUUM,
                                 DEFAULT_CACHE_SIZE=-2000, DEFAULT_FILE_FORMAT=4,
                                 DEFAULT_JOURNAL_SIZE_LIMIT=-1, DEFAULT_MMAP_SIZE=0, DEFAULT_PAGE_SIZE=4096,
                                 DEFAULT_PCACHE_INITSZ=20, DEFAULT_RECURSIVE_TRIGGERS,
                                 DEFAULT_SECTOR_SIZE=4096, DEFAULT_SYNCHRONOUS=2,
                                 DEFAULT_WAL_AUTOCHECKPOINT=1000, DEFAULT_WAL_SYNCHRONOUS=2,
                                 DEFAULT_WORKER_THREADS=0, ENABLE_API_ARMOR, ENABLE_COLUMN_METADATA,
                                 ENABLE_DBSTAT_VTAB, ENABLE_FTS3, ENABLE_FTS3_PARENTHESIS, ENABLE_FTS4,
                                 ENABLE_FTS5, ENABLE_GEOPOLY, ENABLE_MATH_FUNCTIONS,
                                 ENABLE_MEMORY_MANAGEMENT, ENABLE_PREUPDATE_HOOK, ENABLE_RTREE,
                                 ENABLE_SESSION, ENABLE_STAT4, ENABLE_UNLOCK_NOTIFY, MALLOC_SOFT_LIMIT=1024,
                                 MAX_ATTACHED=10, MAX_COLUMN=2000, MAX_COMPOUND_SELECT=500,
                                 MAX_DEFAULT_PAGE_SIZE=8192, MAX_EXPR_DEPTH=1000, MAX_FUNCTION_ARG=127,
                                 MAX_LENGTH=1000000000, MAX_LIKE_PATTERN_LENGTH=50000,
                                 MAX_MMAP_SIZE=0x7fff0000, MAX_PAGE_COUNT=1073741823, MAX_PAGE_SIZE=65536,
                                 MAX_SQL_LENGTH=1000000000, MAX_TRIGGER_DEPTH=1000,
                                 MAX_VARIABLE_NUMBER=250000, MAX_VDBE_OP=250000000, MAX_WORKER_THREADS=8,
                                 MUTEX_PTHREADS, SYSTEM_MALLOC, TEMP_STORE=1, THREADSAFE=1, USE_URI

What versions of what packages do you have installed?

pip freeze
black==22.8.0
bump2version==1.0.1
bumpversion==0.6.0
click==8.0.4
dataclasses==0.8
distlib==0.3.6
filelock==3.4.1
importlib-metadata==4.8.3
importlib-resources==5.4.0
isort==5.10.1
lxml==4.9.2
mypy==0.971
mypy-extensions==1.0.0
packaging==21.3
pathspec==0.9.0
pbr==5.11.0
pep517==0.13.0
pip-tools==6.4.0
platformdirs==2.4.0
plotly==5.15.0
py-spy==0.3.14
pyparsing==3.1.0
PyYAML==6.0
sphinx2rst==1.1.0
stevedore==3.5.2
tenacity==8.2.2
tokei-pie==1.2.0
tomli==1.2.3
typed-ast==1.5.4
typing_extensions==4.1.1
virtualenv==20.16.6
virtualenv-clone==0.5.7
virtualenvwrapper==4.8.4
zipp==3.6.0

What code shows the problem?
See main branch on https://github.com/tingilee/coverage-prototype/

What commands should we run to reproduce the problem?
$ git clone git@github.com:tingilee/coverage-prototype.git
$ coverage run --debug=config --rcfile=/Users/jacqueline.lee/jkl/prototype/.coveragerc --append --branch -m pytest ~/jkl/prototype/ && coverage lcov   -o /tmp/output_coverage_jkl
Verify the debug output contains the custom config.
$ genhtml --output ~/jkl/genhtml /tmp/output_coverage_jkl
Then, open the generated ~/jkl/genhtml/index.html and see the attached screenshot for result.

Expected behavior
Line 1 & 2 should be excluded without reporting hit or missing, to respect the configurations in .coveragerc.
https://github.com/tingilee/coverage-prototype/blob/main/test_jkl.py#L1-L2
Here's .coveragerc to exclude lines of import statements and pragma: no cover.
https://github.com/tingilee/coverage-prototype/blob/main/.coveragerc#L20-L27

genhtml is downloaded from brew install lcov. https://github.com/linux-test-project/lcov/blob/master/bin/genhtml and it's a tool to help visualize lcov files. Here's the lcov content:
TN:
SF:test_jkl.py
DA:1,1,mUDsnWRiqW9R9nTILGKIZg
DA:2,1,3QNj+DkOnaTvpnIwAiI3Uw
DA:4,1,NxIa0sVNftaSOeuKKM9NCQ
DA:5,1,lTOFy5prvzMQc1MdN7tkoQ
DA:6,1,X6gPYOlvig8TUShq060KfQ
DA:7,1,hn+m5M7Ya5u0W/sLhVQRkw
DA:8,1,4hQYWCByYJ7KOpJ/K/mtdQ
DA:10,1,0PMxynBwwrK++xNpS9EpEA
DA:12,1,tVVJRENRBGwuAT3Tc8Hl5w
LF:8
LH:9
BRDA:10,0,0,-
BRDA:8,0,1,1
BRF:2
BRH:1
end_of_record

You're right that it's only reproable on lcov which is the coverage format that we use. I would be happy to create a PR to address this. Would you be willing to accept patches to coverage==6.4.1?

Created a PR: https://github.com/nedbat/coveragepy/pull/1685

This is fixed in 37e12147 and finished in 3e011a59

This is now released as part of coverage 7.3.2.

This is now released as part of coverage 7.3.2.


Ignored node_modules and .env file.

I think you forgot to add this file in your video. I fixed it. Thanks.

I think you forgot to add this file in your video. I fixed it. Thanks.

Thanks Dude

You are correct. Sorry it took so long to see this. I already have updated the code to include those changes.


Cannot read properties of undefined (reading 'cookie')

We are keeping getting the below undefined errors
"@hotjar/browser": "^1.0.9",

import Hotjar from '@hotjar/browser';

....

Hotjar.init(xxxx(hotjarId), 6);

TypeError Cannot read properties of undefined (reading 'cookie')
    https://script.hotjar.com/modules.7532ebbcfaf7feae351e.js:1:7384 u.clear
    https://script.hotjar.com/modules.7532ebbcfaf7feae351e.js:1:10288
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:2355:40 Y.<computed>
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:402:30 m.invokeTask
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:171:46 a0.runTask
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:483:33 invokeTask
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:472:47 invoke
    node_modules/.pnpm/zone.js@0.13.0/node_modules/zone.js/fesm2015/zone.js:2335:31 h.args.<computed>

We are initializing hotjar in our app with the hotjar js script. Getting the same cannot read properties of undefined(reading 'cookie') error - fired off over 17k times in the last 24 hours.

We also started seeing this error using the tracking code script, 8 events affecting 6 users today.

We've also started seeing this issue and another seemingly related issue: TypeError: undefined is not an object (evaluating 'this.cookie')

Same here. And we started to see these errors at 2023-09-19 1:43PM UTC. And worth pointing out is that we have not done any configuration changes nor script version update in conjunction to this.


infinite isFetching

Describe the bug
In condition when queryClient.clear() is run while some request  are in progress even after request is complete tanstack query doesn't resolve .
Your minimal, reproducible example
https://stackblitz.com/edit/tanstack-query-zyumu7lg?file=src%2Findex.tsx&preset=node
Steps to reproduce
Go to provided link click on press me
Expected behavior
Item should refetch or get resolved
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
All System
Tanstack Query adapter
None
TanStack Query version
v5.53.3
TypeScript version
No response
Additional context
No response

You’re removing the value (query) we’re trying to set the state to, so we can’t set the state to success afterwards.
Generally, calling an unconditional clear() while you are having queries mounted isn’t a good idea. You can use queryClient.removeQueries(filters) with filters to remove what you want more granuarly.


OnRowOrError() returns "json: cannot unmarshal object into Go struct field DataSetCompletion.OneApiErrors of type string"

Reopening the original issue #124
I have a log for the reproduction of the issue - it also worth fixing the "%v" printing of the json.RawMessage
@AsafMah @yogilad
'json parsing failed: [123 34 70 114 97 109 101 84 121 112 101 34 58 34 68 97 116 97 83 101 116 67 111 109 112 108 101 116 105 111 110 34 44 34 72 97 115 69 114 114 111 114 115 34 58 116 114 117 101 44 34 67 97 110 99 101 108 108 101 100 34 58 102 97 108 115 101 44 34 79 110 101 65 112 105 69 114 114 111 114 115 34 58 91 123 34 101 114 114 111 114 34 58 123 34 99 111 100 101 34 58 34 76  ... (see below the unmarshalling) .... 114 109 97 110 101 110 116 34 58 102 97 108 115 101 125 125 93 125]';'json: cannot unmarshal object into Go struct field DataSetCompletion.OneApiErrors of type string';

the json that is printed there as byte array is:
    "FrameType": "DataSetCompletion",
    "HasErrors": true,
    "Cancelled": false,
    "OneApiErrors": [
        {
            "error": {
                "code": "LimitsExceeded",
                "message": "Request is invalid and cannot be executed.",
                "@type": "Kusto.Data.Exceptions.KustoServicePartialQueryFailureLimitsExceededException",
                "@message": "Query execution has exceeded the allowed limits (80DA0003): The results of this query exceed the set limit of 64 MB, so not all records were returned (E_QUERY_RESULT_SET_TOO_LARGE, 0x80DA0003). See https://aka.ms/kustoquerylimits for more information and possible solutions..",
                "@context": {
                    "timestamp": "2023-04-23T12:44:59.8860252Z",
                    "serviceAlias": "FOO",
                    "machineName": "KENGINE000001",
                    "processName": "Kusto.WinSvc.Svc",
                    "processId": 2984,
                    "threadId": 4716,
                    "clientRequestId": "KGC.execute;aaaaaaaa-6fda-43da-a536-6fdf7bf82491",
                    "activityId": "aaaaaaaa-ad00-436c-a8f6-93e2f97b67ac",
                    "subActivityId": "aaaaaaaa-ad00-436c-a8f6-93e2f97b67ac",
                    "activityType": "GW.Http.CallContext",
                    "parentActivityId": "aaaaaaaa-ad00-436c-a8f6-93e2f97b67ac",
                    "activityStack": "(Activity stack: CRID=KGC.execute;aaaaaaae-6fda-43da-a536-6fdf7bf82491 ARID=507e15c1-ad00-436c-a8f6-93e2f97b67ac > GW.Http.CallContext/aaaaaaaa-ad00-436c-a8f6-93e2f97b67ac)"
                },
                "@permanent": false
            }
        }
    ]
}

Looks like the problem is that OneAPIErrors field (in DataSetCompletion) is expected to be a []string, where it is actually a list of jsons
consider changing it to []any
Originally posted by @liranms in https://github.com/Azure/azure-kusto-go/issues/124#issuecomment-1519061201

Thank you!
I missed your comment after the issue was closed
Fixed in #183, I'll release a version soon

Fixed in v0.12.1 - please re-open if you still encounter this.


Is the project alive?

I can see 101 pull requests, some of them are critical. This is the most popular pure js slider lib, so would be really great to see it maintained.

@tylik1 most of them are from greenkeeper, I will take a look at the other PRs in the next couple of days! Thanks for heads up


Use print functions if there is no format

Sprintf and Printf are slower than Sprint and Print. And if there is no format argument, it is redundant to use format functions. So color works now faster and consumes less memory:
benchmark                     old ns/op     new ns/op     delta
BenchmarkPrintNoFormat-4      6892          6768          -1.80%
BenchmarkStringNoFormat-4     1362          1345          -1.25%

benchmark                     old allocs     new allocs     delta
BenchmarkPrintNoFormat-4      10             9              -10.00%
BenchmarkStringNoFormat-4     13             13             +0.00%

benchmark                     old bytes     new bytes     delta
BenchmarkPrintNoFormat-4      120           104           -13.33%
BenchmarkStringNoFormat-4     152           152           +0.00%

Also, I renamed printColor and printString to colorPrint and colorString respectively. I think, it's clearer now what do these functions, because printString doesn't actually print.

Thanks @bogem


Initial functionality provided for action items for improving records

Provides basic functionality for action items stated in #5
It has some styling issues, but before working on it anymore, I wanted to check if the current approach is reasonable.

This is fantastic work @emredalkiran, thank you!

@dashersw thanks for the feedback and kind words. record.vue has some problems, it doesn't repsresent _id key properly, by adding additional nesting of id in the form of an array. On top of that, if you delete all the documents on a query result or left a few documents in the collapsed mode, the alternating background also gets removed because of the wrapping html element's size has shrunken (in order to support scrolling and keeping alternate between collapsed/open rows, I alternated the background color of the wrapper element).  The border of the records view remains same though, which creates an awkward view. I'll try to address these problems as well as the ones you mentioned above.
In addition to that, it is not very clear which document has focus for deleting. I think adding some sort of highlighting for active document would also be beneficial.
I think font size for record displaying can be decreased a little bit and color of the records text can be darkened a little, towards a greyish white, considering dark background color.

Thank you! I agree. I think overall the font sizes are too big in the project :) we should decrease them.


feat: implement focus visible

Description
We need to use :focus-visible instead of :focus: to allow keyboard navigation to still use visible focus, but remove instances in which pointer interaction shows focus indication.
Pull Request Checklist

[x] Ask the contributors if a similar effort is already in process or has been solved.
[x] Review the contribution guidelines.
[ ] Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
[x] Ensure all gulp scripts successfully compile.
[ ] Update, remove, or extend all affected documentation.
[x] Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] Request a review from Brad Paugh, David Becher, or Drew Chandler.

Obligatory GIF (super important!)

seems corresponding polyfills should be add separately, to not forget about that are we going to add some documentation for this case?

seems corresponding polyfills should be add separately, to not forget about that are we going to add some documentation for this case?

Yeah, we have a ticket to add focus-visible and polyfill documentation to dialpad.design, so it's ok.


unknown file attribute: v

Hi,
is it possible that when the name of the app contains parentheses, it tries to treat it as an argument? It gives me the error "unknown file attribute: v".
Thank you
Tom

Maybe your shell does this. Try single or double quotes around the label.


Update run test suite gh action

I think that the issue may be with how the branches were specified. Maybe a shot in the dark though.

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[x] Reviewers requested with the Reviewers tool :arrow_right:

From the the CI log:
29 Fetching the repository
30 /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +9c0200741124668183ee6fbf7dc7d1e1e4e9097a:refs/remotes/pull/12/merge

So, looks like this should fix it.


Funder template status changed

I see we flag when the funder template has changed. What does this denote (changes since customisation, or changes per se?) and have we built any functionality around this e.g. saying what has changes, alerts to prompt those who have customised changes templates...

For Strathclyde uni, I get many more entries where the funder template has changed

@sjDCC this may have been fixed in #365 (v0.2.6)

This is actually likely still an issue after that PR.
'Original funder template has changed' denotes that the underlying template which has been customised by the uni has changed.
This means that the org-admin must click 'edit customization' in order to bring their customizations through into the new template.  Once they click this, upon refreshing the templates index page, they will simply see 'published' and be allowed to edit the draft of their template (which they can also publish).
As far as I am aware, no additional notification functionality has been built in around this.

This strikes me as something that would benefit from UX input @JEK-III in future to improve workflow and notifications
For now if we flag that a newer version of the template is in use and that their customisation is inactive that should be sufficient. We should make it clearer that they need to 'edit customisation' to transfer this through to the new template though (I assumed it still showed), and ideally it would be unpublished first until they've checked and made any changes needed.
How about changing the action line to 'Transfer customisation' instead of 'Edit customisation' and make it unpublished at first? That should prompt them to check their content is still valid and make any changes needed.
Is it feasible to implement those steps? Happy to help mock something basic up with you

Bouncing the UX question to @rhu001, who is handling the admin interface.

Also note there's a related ticket #232

@sjDCC are the template changes occurring because the local admins are changing them or because they are changing from the funder and the local admin doesn't realize they have changed until they see the status on the table? Would like to understand the use case before advising on UX changes. Thanks.

Hi @rhu001, essentially it's the second case you describe.
This notification text that "Original funder template has changed!" appears in the table when an institution has customised the funder template and the funder has subsequently released a new version. Essentially it's an alert that something has changed so they need to check their customisation is still valid. The local org admins don't have permissions to change the funder template, only their customisations on it. It seems the customisation only transfers through to the new funder template version when the org-admin clicks to 'edit customisation' and saves changes.
I don't fully understand your second question:
"Also, is there a case where there are more than one local admin or a super admin who might change the template that the other local admin has to account for and re-adjust for their institution?"
There may be more than one org-admin at an institution but we don't set any alerts when one of them has changed their template. Funders (or more like Steph and me) administer the funder templates. Organisations can customise these, but this is effectively overlaid institutional content (example answers, guidance and additional sections) on a single version of the funder template, not new versions of the funder template.

Hi @sjDCC I was asking that second question because I wanted to know who was the "user" who could potentially be the one putting the new funder template into the DMP system. Super admins like you and Stephanie and potentially the funder themselves? If that's the case then it might be good to have on their end when they upload the new updated funder template to have some sort of button that says "Notify org admins of change" then that would send out both an email notification as well as put a notification on the org admin's dashboard notifying them that an "action" would need to occur in order for them to fully update their customized local version of a funder template. In the CDL DMP system, we are going to have a dashboard for all admins (both super and local org) that they see as soon as they login that will have all of their outstanding action items on it. That way the notification that a template has changed is not so buried. Does this make sense?

This sounds perfect and also addresses the point @stephaniesimms raised in #232 It's good for the template owner / admin to control the notifications as sometimes you're just fixing typos, not doing anything substantive that would affect any institutional customisations.
I guess we need to ensure the customisations are transferred to new versions of templates though when there aren't notifications. One for devs @xsrust @vyruss and @briri to consider...

Great. Additional clarification... only super admins and funders have ability to upload a new funder template right? Local org admins (even if there are more than one local admin) don't have the ability to do this?

Correct. Org-admins can only administer their own institutional templates (though I don't think many have these in DMPTool). It's only funders or super admins who can make changes to funder templates

Will the researcher end-users who may be in the midst of creating a plan based on a local customized template need to be notified that they need to re-work their plans as well?

@sjDCC it is impossible to transfer customisations automatically as it is impossible to determine what the template owner will have changed, whether it is adding a comma or deleting a phase and add 3 new ones. It's the same issue as "minor change/major change" and we decided there should be no such differentiation. A change in any Funder template creates a new template version and thus renders the customisations of the old version outdated.
@rhu001 it is impossible to change a published template, so the plan the end-users will be working on is not affected. By notifying users of this, I think we'd be building functionality into the tool to fix something which is their responsibility, i.e. making sure that they're using the latest template.

Hi @vyruss. Can you explain what happens to any institutional customisations when a new version of a funder template is released. From what Sam said earlier, I understand they are in limbo until the org-admin verifies they are still appropriate and re-publishes? If that's the case we need to make it clear what steps an org-admin needs to follow when a new version of a funder template is released. The current messaging that "Original funder template has changed!" doesn't really explain what they need to do.
10 days ago I suggested we make it clearer that they need to click the link to 'edit customisation' to transfer their customisations through to the new template. If these don't show automatically on new versions of the template they would ideally switch to being unpublished until the org-admin has checked and made any changes needed.
My suggestion was to change the text in the action line to 'Transfer customisation' instead of 'Edit customisation' and make it unpublished at first. That should prompt org-admins to check their content is still valid and make any changes needed.
@stephaniesimms noted that sometimes the changes we make to a published funder template are trivial e.g. fixing typos, so super-admins should have the ability to turn these notifications off and essentially just push through new versions of templates without requiring action from all org-admins who have added institutional customisations. Essentially if we know the changes won't have affected any suggested answers, guidance or additional sections, we shouldn't prompt them all the validate changes. We can address this use case as part of the MVP release though under #232
For now the main issue is to clarify any steps org-admins currently need to follow when the "Funder template has changed" notice appears, and make these clear in the MVP 0.3 release code.

changing the text to 'Transfer customization' should be trivial.
Is that the only change which would need to be made to clarify the steps to org-admins?

I think so, as well as ensuring their customisations are unpublished on the release of a new version of a funder template. Currently they still show as published so it's not clear you need to do anything.
Thinking about this some more it would actually really help to know exactly what happens to their content (guidance, suggested answers etc) when a new version is released....
I've just looked into one template with this "Original funder template has changed!" warning to test things out. When I clicked 'edit customisation' I could see my annotations. On returning to the front template table screen, the warning has now appeared. I guess the act of me clicking 'edit customisation' has pulled all my content through to the new version of the template and published it. There was no indication it was unpublished at any point.
If the scenario above is accurate, I would suggest:

change 'edit customisation' to 'transfer customisation' in cases where a new version of a funder template has been released
on clicking 'transfer customisation' we should pull through any institutional customisations to the new version of the funder template, but not auto-publish
Ensure institutional customisation is 'unpublished' when a new version of a funder template is released and remains so until the org-admin has checked/amended their content AND clicked to republish it. Feasibly the changes could be new questions and sections so we don't want to auto-publish when transferred, which seems to be what is happening currently.

Does that sound right @stephaniesimms @rhu001 @JEK-III
If so there are two changes - adjusting 'edit customisation' to 'transfer customisation' and making institutional customisations unpublished until verified and republished by org admin.

Have just tested this and new workflow works. Thanks @xsrust Closing out.


fix: Improve ZAPI template selection

edge cases covered. Thanks @cgrinds for the code improvements.

applied the review comments and validated with 9.10.1


[MenuTitleWrapper] Menu not aligned with UX recommandations

Issue and Steps to Reproduce

Versions
Latest version (v1.2.0)
Screenshots
From the story book :

Expected

Actual
Additional Details
The menu names shouldn't be in bold and not underlined

Installed packages

Do you think it's still current ?

According to the design system (https://axaguildev.github.io/react-toolkit/latest/design/molecules/navigation/) yes it's still current


update to 1.12.0

bumped version and sha256
removed libprotobuf constraints in favor of cbc.yaml pin
improved metadata
added setuptools, wheel

Oops @varlackc I missed your comment. It's not really a problem though. libprotobuf is pinned by cbc.yaml, but it could be pinned, theoretically, to any version. The practical consequence of cbc.yaml and the protobuf bound is that we're locked into 3.20.1


Type of an unitialised variable

It seems to be String?
I have this simple program:
For i = 0 To 10
   x = x + 1
   xyz.Print(x)
EndFor

With MS SmallBasic, this prints the numbers 1 to 11; in ISB it's 1, 11, 111, 1111, 11111 .... - Of course I can just write x = 0 at the beginning, but I wondered if this actually wanted, or rather some kind of bug.

There is a slight difference between ISB and MSB when adding an empty/uninitialized value to a number.
It is reasonable to be compatible with MSB here I guess.


Use System.arraycopy instead of Arrays.copyOf to get compatibility back ...

...with Froyo devices (API Level 8)

Awww snap! It sneaked in again! Thanks


USB host support

The RP2040 is able to operate as a USB host. TinyUSB has support for this mode of operation. Could rp-hal get it too?

This is a work in progress, see https://github.com/rp-rs/rp-hal/pull/660


Generic data member accessor with std::function to comparision in when statement

Hi!
Nice Work and looking for the Cpp17 version!
i got user_exists, to get user existence, but i wanted to generalized in gen_exists by capturing type of table T and data_member_accesor by calling like this:
using test_prot::Users;
std::function<string(test_prot::Users)> data_member = &Users::username;
gen_exists<test_prot::Users>(username, data_member);

So i would do the comparison with the correct column for generic tables like in:

where( data_member_accessor(table) == unique_val )

template<typename T>
bool gen_exists(string unique_val, std::function<string(T const&)> data_member_accessor){
    auto & db = mysql_db::get_db_lazy().db;
    T table;
    if (!db(select(table.json).from(table).where( data_member_accessor(table) == unique_val )).empty()){
        return false; //Already exists;
    }
    return true;
}

bool user_exists(string username){
    auto & db = mysql_db::get_db_lazy().db;
    test_prot::Users usr;
    if (!db(select(usr.json).from(usr).where(usr.username == username )).empty()){
        return false; //Already exists;
    }
    return true;
}

But im looking in the generated code and there is some nesting and im loosing it.
How would it be?
Much thanks!

Hi,
I am a bit confused by this line:
std::function<string(test_prot::Users)> data_member = &Users::username;

What is the string doing there? Also, the column type has a call operator, but this seems overkill in Age of Lambda.
How about the following:
template<typename T>
auto get_data_member = [](){};

template<>
auto get_data_member<Users> = [](){ return Users{}.username; };

Best,
Roland

Wohaa! works perfectly, much much thanks!
Closing this!


Docker setup

Completed
Created Docker files for both Polkadex Node and Worker.
Pending
Create Docker compose file to run in the following order:-

Polkadex Node
Openfinex
Polkadex-worker
Client

Will close #9

@haerdib, the docker setup will not work due to how openfinex is configured and how the enclave and node interact.  @zktony  can explain to you the issues with this method. I suggest we move on with bare-metal deployment and testing everything there.

Closing this PR for the time being


Leader election

Description
Observed Behavior:
Randomly getting the below errors. The incident involved frequent deprovisioning and service outage noting that PDBs are set.
E0626 20:00:18.625437       1 leaderelection.go:367] Failed to update lock: Put "[https://<IP_ADDRESS>:443/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election](https://<IP_ADDRESS>/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election)": context deadline exceeded
E0626 19:38:37.928683       1 leaderelection.go:330] error retrieving resource lock karpenter/karpenter-leader-election: Get "[https://<IP_ADDRESS>:443/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election](https://<IP_ADDRESS>/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election)": net/http: TLS handshake timeout
E0626 19:35:58.115419       1 leaderelection.go:330] error retrieving resource lock karpenter/karpenter-leader-election: Get "[https://<IP_ADDRESS>:443/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election](https://<IP_ADDRESS>/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election)": http2: client connection lost

and another set of logs that are weird and are asking me to file a report
"level":"ERROR","time":"2023-06-29T14:15:21.662Z","logger":"controller.pod_state","message":"invariant violated registering host port usage, IP=<IP_ADDRESS> Port=8125 Proto=UDP conflicts with existing HostPort configuration IP=<IP_ADDRESS> Port=8125 Proto=UDP, please file an issue","commit":"d7e22b1-dirty","pod”:”xxxx/xxxx-djkh9"}

2
{"level":"ERROR","time":"2023-06-29T14:15:21.688Z","logger":"controller.pod_state","message":"invariant violated registering host port usage, IP=<IP_ADDRESS> Port=8125 Proto=UDP conflicts with existing HostPort configuration IP=<IP_ADDRESS> Port=8125 Proto=UDP, please file an issue","commit":"d7e22b1-dirty","pod”:”xxxx/xxxx-djkh9"}

Pods were restarting

We scaled the karpenter deployment to 4. Still seeing some weird logs.

I see 2 logs which I'd like to know more about and how they might relate to the incident.
failed to renew lease
client-side throttling

Apparently this was the leader or trying to be.
What does panic mean in the logs and why was there so many timeouts. It shouldn't be normal to see that much errors right?

Expected Behavior:
Not getting these errors
Reproduction Steps (Please include YAML):
No clear steps so far
Versions:

Chart Version:  v0.27.3
Kubernetes Version (kubectl version): v1.25.9-eks-5f89878
Node OS Version: Bottlerocket OS 1.14.1 (aws-k8s-1.25)   5.15.108

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

How much memory and cpu are you giving Karpenter? What kind of scale is your cluster running under? Typically we are seeing client-side throttling or logs like this when there are extremely large scale-ups or there are a lot of events on your cluster all happening at one time.

@jonathan-innis The resource limits were left as default (non set). In terms of scale we currently have 1394 pods which is everything on the cluster, 37 nodes managed by Karpenter, and 8 nodes for critical workloads (like Karpenter) that are under a Managed Node Group. Well in terms of events we are migrating some services to the cluster, but I don't think that was the case for the incident that is being addressed in this issue.

Hi @jonathan-innis, we are experiencing this as well:
2023-07-27T02:35:23.658Z	ERROR	controller	error retrieving resource lock karpenter/karpenter-leader-election: Get "https://<IP_ADDRESS>:443/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election": context deadline exceeded
	{"commit": "c3d4e73-dirty"}

We have a large cluster (scales up to over 700 nodes). I increased the Karpenter resource reuqests this is still happening.
          resources:
            requests:
              cpu: "2"
              memory: 2Gi

im having the same issue as above :(

Digging into this. @nalshamaajc, you absolutely should be setting cpu/memory, or you may get client side throttling. Given the other reports, I think there may be something going on with the EKS Control Plane. I'll raise this with the team. In the meantime, please submit a support ticket to EKS to diagnose these client timeouts.

HI @ellistarn , I have opened a support ticket -<PHONE_NUMBER>1. If you need any logs/details attached there, let us know.

Chart Version: v0.27.5
Kubernetes Version (kubectl version): v1.24.16-eks-2d98532
Node OS Version: AL2

having same issue on the above env, only about failed to renew lease. hope to solve soon

It may be worth trying out a FlowSchema here where the coordination APIs for Karpenter are prioritized so that the apiserver is less likely to drop leader election requests during periods of high traffic
apiVersion: flowcontrol.apiserver.k8s.io/v1beta3
kind: FlowSchema
metadata:
  name: karpenter-leader-election
spec:
  distinguisherMethod:
    type: ByUser
  matchingPrecedence: 300
  priorityLevelConfiguration:
    name: leader-election
  rules:
  - resourceRules:
    - apiGroups:
      - ""
      namespaces:
      - '*'
      resources:
      - endpoints
      - configmaps
      verbs:
      - get
      - create
      - update
    - apiGroups:
      - coordination.k8s.io
      namespaces:
      - '*'
      resources:
      - leases
      verbs:
      - get
      - create
      - update
    subjects:
    - kind: ServiceAccount
      serviceAccount:
        name: '*'
        namespace: karpenter

I think it might also make sense to assign the workload-high priority to any request coming from the Karpenter controller as well
apiVersion: flowcontrol.apiserver.k8s.io/v1beta3
kind: FlowSchema
metadata:
  name: karpenter-service-account
spec:
  distinguisherMethod:
    type: ByNamespace
  matchingPrecedence: 1000
  priorityLevelConfiguration:
    name: workload-high
  rules:
  - nonResourceRules:
    - nonResourceURLs:
      - '*'
      verbs:
      - '*'
    resourceRules:
    - apiGroups:
      - '*'
      clusterScope: true
      namespaces:
      - '*'
      resources:
      - '*'
      verbs:
      - '*'
    subjects:
    - kind: ServiceAccount
      serviceAccount:
        name: karpenter
        namespace: karpenter

@shay-ul, checking in here. Does any of the information above or given by the support ticket help out?

We actually got a crash/panic on Karpenter when leadership election failed. (When this happened it appeared the EKS Control Plane was going through some changes/issues that do not have me surprised that requests failed/had issues):
{"level":"ERROR","time":"2023-09-29T21:04:52.458Z","logger":"controller","message":"Failed to update lock: Put \"https://<IP_ADDRESS>:443/apis/coordination.k8s.io/v1/namespaces/karpenter/leases/karpenter-leader-election\": context deadline exceeded\n","commit":"34d50bf-dirty"}
{"level":"INFO","time":"2023-09-29T21:04:52.458Z","logger":"controller","message":"failed to renew lease karpenter/karpenter-leader-election: timed out waiting for the condition\n","commit":"34d50bf-dirty"}
{"level":"INFO","time":"2023-09-29T21:04:52.458Z","logger":"controller","message":"Stopping and waiting for non leader election runnables","commit":"34d50bf-dirty"}
panic: leader election lost

goroutine 442 [running]:
github.com/samber/lo.must({0x1e2e580, 0x4010cb2d60}, {0x0, 0x0, 0x0})
        github.com/samber/lo@v1.38.1/errors.go:53 +0x1dc
github.com/samber/lo.Must0(...)
        github.com/samber/lo@v1.38.1/errors.go:72
github.com/aws/karpenter-core/pkg/operator.(*Operator).Start.func1()
        github.com/aws/karpenter-core@v0.29.2/pkg/operator/operator.go:170 +0x7c
created by github.com/aws/karpenter-core/pkg/operator.(*Operator).Start
        github.com/aws/karpenter-core@v0.29.2/pkg/operator/operator.go:168 +0xd0

@njtran we actually had no progress with that regards, unfortunately.
However, this is not Karpenter-related. The same thing also happens on all components which are implementing leader election using the Kubernetes API. On our use case, it also includes:
aws-load-balancer-controller
karpenter
keda-operator
ebs-csi-controller
efs-csi-controller
I believe this is the API Server unable to handle the load. We are continuing to investigate with AWS Support.

P.S the "API Priority and Fairness" (PriorityLevelConfiguration and FlowControl) solution for Karpenter may work and fix this issue for Karpenter, but to be honest - KEDA, ALB Controller, EBS and EFS CSI Controllers are also very important system components.
We would like to avoid entering this rabbit hole altogether. The fact that the control plane is caving under some pressure is disturbing, as EKS should support scale without the need to go through such customization.
Is there a plan to add this FlowControl as a default to the helm chart, as in this draft PR?
thanks for the help!

Update on our case<PHONE_NUMBER>1):
The AWS Support team found evidence that during the time frames for this issue, etcd is going through "defragmentation" process due to large volume of the database. This process causes etcd to become read-only, blocking any write operations (for Karpenter - this means timeout for leader election).
Here are two articles on the matter:
https://aws.amazon.com/blogs/containers/explore-etcd-defragmentation-in-amazon-eks/
https://aws.amazon.com/blogs/containers/managing-etcd-database-size-on-amazon-eks-clusters/
needless to say, this is a huge problem, since this means EKS may be able to handle steady prefictable scale, but is unable to handle large auto scaling events.

The fact that the control plane is caving under some pressure is disturbing

Agreed. We're still looking into the details onto the control-plane side to see what's causing the apiserver/etcd to just start throwing errors. We're also seeing this error on our test clusters as well.

Is there a plan to add this FlowControl as a default to the helm chart

As far as the FlowControl stuff goes, yes we want to get this in with the default helm chart, but I want to confirm through some more testing and discussing with some other SIGs that this is the right direction to go with how we think about our API Priority and Fairness.

The fact that the control plane is caving under some pressure is disturbing

Agreed. We're still looking into the details onto the control-plane side to see what's causing the apiserver/etcd to just start throwing errors. We're also seeing this error on our test clusters as well.

Is there a plan to add this FlowControl as a default to the helm chart

As far as the FlowControl stuff goes, yes we want to get this in with the default helm chart, but I want to confirm through some more testing and discussing with some other SIGs that this is the right direction to go with how we think about our API Priority and Fairness.

I'd almost expect for flow control that karpenter should be able to just re-use one of the predefined FlowSchemas/PriorityLevelConfigurations for leader-election or workload-high

Makes sense to me, haven't really dug into either resource that heavily other than knowing they've been improving since 1.22.

We just hit this again. Should Karpenter really panic and crash when it is unable to hit the leader election endpoint? Or should it just backoff and retry?
This ends up triggering paging alerts when karpenter crashes multiple times in a short period of time. Of note, we're on version 0.31 and have not migrated Karpenter to the kube-system namespace as now is recommended.

@jonathan-innis the helm-chart should be updated to supply these FlowSchemas are actually created if the namespace changes from kube-system

I'm going to close this out. As far as I know this is no longer an issue that occurs and we haven't seen this at all in our testing for a few months.
You can definitely still hit this issue if you get heavily throttled by the container CPU limits. Ensure that you give Karpenter enough requests so that it has enough CPU cycles to be able to refresh the leader election resource and you should be fine. Out of the box, Karpenter's default of 1 CPU should be enough to continually refresh this thread.


'No search results' text shown although no search was performed.

Description of bug
'No search results' message was shown although no search was performed. When a 'Search Module' is added to a page, the message 'No search results' is shown every time that page is loaded even though there is no search performed.
Steps to reproduce
List the steps to reproduce the behavior:

Add the Search Module to the home page.
After the page reloads by itself, the text 'No search results' is shown when no search was performed.
At any time the home page loads, the text 'No search results' will be shown.

Current result
'No search results' message was shown although no search was performed.
Expected result
No message should be shown unless a search is performed. As per current behavior we do not perform search if the search query is less than 2 characters.
Screenshots
Screenshots after the fix and showing all conditions
No message shown when no search performed.

Valid Search Shown when search performed

Message shown when Invalid search is performed

Affected version

[X] 10.0.0 alpha build
[X] 9.4.1 alpha build
[X] 9.4.0 latest supported release

Merged


fix Default implementation of Image so that size and data match

Before using this image resulted in an Error in Queue::write_texture: copy of 0..4 would end up overrunning the bounds of the Source buffer of size 0

Hmm yeah this seems reasonable to me. I kind of liked that Image::default() didn't allocate, but empty images aren't "valid" to wgpu, so we should probably disallow that entirely. This also illustrates a problem: allowing people direct access to these fields also allows them to define data and descriptors that are out of sync. We should probably disallow that / hide the fields to ensure people can only construct "valid" Images. But I won't block this on that :)

bors r+