Proposal: Language Packs

Language Packs (under construction)
A while ago we opened VS Code's language set to contribution from the community by moving the translation database to Transifex. Since then quite some languages got added. However there is currently no vehicle to install these languages with a stable version of VS Code. The stable version still only ships with the 9 core VS Code languages. Two extra languages (pt_br and hu) have been added to the insider build.
Instead of pre-bundling all new languages with VS Code we should come to a model where these languages can be installed later on like users install additional feature via extensions.
How is VS Code localized
I will first outline how VS Code is localized today. The localization consists of the following parts:

the developer tagging strings to be translated.
automatic extraction of the strings to be translated.
pushing the strings to be translated to Transifex.
pulling translation from Transifex.
building translation bundles.

Tagging strings to be translated
VS Code uses a tagging approach to mark strings to be translated directly in the source code. It therefore provides a translation function nls.localize. Strings pass to that function as an argument are tagged for translation. Strings in single quotes are in general treated as 'technical' which don't require any translation. Strings in double quotes outside a localize function call are treated as strings that need translation but aren't and are flagged by a linter rule as untranslated. A typical nls.localize call looks like this:
nls.localize('TaskService.ignoredFolder', 'The following workspace folders are ignored since they use task version 0.1.0: ');

We also maintain an npm module that allows for the same approach in extension code. The npm module is called vscode-nls.
 This ensures for quick turn around cycles during development time. Furthermore it is important to note that the truth of the strings is in source code (TypeScript and JavaScript). VS Code doesn't maintain resource bundles or property files in other formats.
Extracting strings
Strings to be translated are automatically extracted from the source code during build time. This extraction process does the following things:

extracts the key and the value and puts them into a special meta data file (json format).
replaces the key with an index
removes the value from the call.

The meta data file contains all strings with their key / value pair that are used inside VS Code. It is named nls.metadata.json and it is produced during the build process and ships with VS Code.
The above example looks like this in a version we ship:
nls.localize(17, null);

Pushing to Transifex
The content of the nls.metadata.json is then used to upload the strings to be translated to Transifex. Since VS Code has thousands of strings the translation is grouped into smaller projects to make them easier to handle in Transifex. The following source file describes how these strings are grouped into projects: https://github.com/Microsoft/vscode/blob/master/build\lib\i18n.resources.json#L1
Pulling translations from Transifex
Translations are pull from Transifex and stored alongside the source in the VS Code GitHub repository. They are all under the i18n folder. Storing the translation together with the source code is necessary to be able to version source code and translations together. Otherwise it would for example be very hard to do a recovery build on an older version with exactly the same translations. The translated strings are stored under the i18n folder where the first sub folder is the translated language. The structure underneath the langue folder is isomorphic to the source code folder structure under the src folder. However ts/js source files which don't contain any translatable strings will not have a corresponding i18n.json file. The files in the  i18n folder are all machine generated and should never be edited by a developer.
Building translation Bundles
During build time (when we build s shippable version of VS Code) the build process will also generate translation bundles per supported language (currently the 9 code languages). These translation bundles do have the same granularity as the source bundles have. For example there is a workbench.main.js (which bundles most of our workbench code). So there are corresponding workbench.main.nls.${lang}.js files which contain the translated strings.
These translation bundles are optimized for memory footprint and low CPU consumption when looking up strings. This is achieved using the following two techniques:

all key values from the source code are replaces with index lookups in arrays (see above). The index used is a sequence number for the nls.localize call per TS/JS source file.
unknown translations are replaced with their default value using the normal language mode rule lookup (de_ch -> de -> en). As a result the translation bundles are always complete during runtime and only one set needs to be loaded and no dynamic lookup is happening.

A translation bundle is statically linked to a VS Code version and it is very likely not functioning correctly with a different VS Code version.
This optimization happens for all VS Code core code and our built in extensions. The mechanism and the necessary build tools are also available for outside extensions via the vscode-nls-dev npm module.
Language Packs
It is desirable that language packs come as extensions and are managed by the market place. We don't want to add another channel to host language packs nor do we want to ship all languages in the box (size, language deprecation, ...). To provide such language pack extensions we need to explorer wo things:

how would we build such language pack extension
do we have special extension related requirements for such a language pack extension

Building Language Packs
Especially the optimization we do when building translation bundles (key -> index replacement and default language lookup during build time) makes it harder for third parties to produce language pack extensions. In general we have three choices:

we implement a second translation bundle solution for non core languages which don't make use of the optimization described above.
we publish all our nls related build tools as standalone npm packages so that third parties can publish translations using the same optimizations as own extensions.
we publish all language extensions.

Option 1
Basically we would still replace the key by an index during build time. However during runtime we would do the following for non core languages:

load the nls.metadata.json file into memory
reverse translate index to key (this information is part of the nls.metadata.json
load non core languages bundle files into memory and build up hash tables (these bundles would be key/value maps)
look up the message using the key from a message bundle installed as an extension.
if no message is found we follow the language lookup rules (de_ch -> de -> en) and load other language bundles until we find a valid value for a give key (which we do at least for English)

We could think about giving up on the current solution later on and only use a dynamic runtime solution instead of the optimized statically linked build time solution. This would avoid loading the nls.metadata.json file but would leave the key in the generated JS file.
Option 2
We publish all build tools that are currently inside the code VS Code repository as standalone npm package so that third parties can run the same scripts to bundle translation files.
Option 3
We publish all language extensions to the market place during build time. The translations itself would still come from Transifex. However the translations would also go into the i18n folder like our core languages do and our build scripts would generate language extensions and publish them to the market place.
Option 4
We either include all languages available in the normal VS Code build or we have two different VS Code builds. A first which includes the nine core languages and a second call VS Code International which includes all language currently available in Transifex. The advantage would be no changes to build scripts, loader / start up code or extension installation. However we would need to create and manage these additional builds.
Proposal
I am favoring Option 3. Pros are:

we can treat core languages the same way and basically ship VS Code only with English out of the box.
only minor changes to how we read and manage translation bundles during runtime (we only need additional lookup locations).

Cons are:

the language pack must match the VS Code version number. So a language pack produced for version 1.18 will not work for version 1.19.
we will add more translation files to our GitHub repository (under the i18n folder). However that folder can fully be ignored during development time. The average size of the files for a language is currently 500KB.

I don't like Option 1 since it will add a second translation bundle runtime story with its own set of bugs (at least for a while; I am convinced that the optimization we do are worth it especially during startup time). If we stick with two different solutions (core / contributed languages) core language and contributed languages will look different and we will always ship all core languages in the box. The only advantage I can see with option 1 is that it would allow to start VS Code with an old outdated language pack since missing strings will dynamically fall back to English during runtime.
Option 2 would be doable and would allow us to treat core and contributed languages the same. However from the experiences with maintaining a separate repository and npm module it might not be worth compared to option 3. In addition we would end up with more outdated language packs when we ship a new version of VS Code.
Language Pack Extensions
Since option 3 (as option 2) language packs are statically 'linked' against a VS Code version we would need the following features for extensions (if not already present):

exact version matching
auto updating. This means when a user installs a new version of VS Code we should automatically update all language packs to the matching VS Code version. If no language pack version is available we would disable the language pack.

@egamma added Option 4
/cc @chrisdias

@dbaeumer Another thought for option 1:
Let's call that index to key translation indexing. Could we index a Marketplace extension at the time the extension is installed/updated? Possibly also after Code itself is updated? And we wouldn't load the translation until that indexing has been done? That way, indexing only happens once and loading up the extension is fast and would be exactly the same as the core languages.

@joaomoreno nice idea.

Moved to December to continue discussion

@joaomoreno I liked the idea of indexing at run time. Adding to it, can we make them selectable as themes. User can install multiple language extensions and can select the language using a picker. We can do the indexing when the language is selected and reload the window?

That's trickier since UI labels are present in the main process too (menus).

We do have some sort of picker: F1 > Configure Language
The picked language is a special setting since we need to read it very early in the startup phase to configure the nls plugin of the loader correctly. So it is not stored in the usual settings.

That's trickier since UI labels are present in the main process too (menus).

How about prompting to quit and restart VS Code for the changes to apply?

The picked language is a special setting since we need to read it very early in the startup phase to configure the nls plugin of the loader correctly. So it is not stored in the usual settings.

Can we write the selected language into that file after selection?

Yes, that is what is currently happening when you use F1 > Configure Language.

Right, F1 > Configure Language is currently opening the file.
My thought is to show a picker of languages to select, once selected, we can write into the file and ask the user to restart. Not sure if this functionality is already exists.

Yes, that could directly write to the file and restart VS Code. I had an item for this but we closed it since users don't change language often. Usually only once.

//cc @aeschli

@aeschli and I discussed this on how to best structure the content of a language pack (at least for translations inside the VS Code core (no extensions)). The conclusion was to pre-compute as much as possible and to have files as large as possible. For the code I therefore propose the following structure:
{
	"data": {
		"vs/code/electron-main/main": [
			"Guten Tag",
			"Gute Nacht"
		]
	},
	"keys": {
		"vs/code/electron-main/main": {
			"goodMorning": 0,
			"goodNight": 1
		}
	},
	"hashes": {
		"vs/code/electron-main/main": "Key sequence hash"
	}
}

As seen the file already contains the messages stored as an array. If the hash value matches the one we will store in nls.metadat.json then we can simply take the array. The assumption behind this is that we not change strings in existing files. We most of the time make new strings in new files. If the hashes don't match we take the key information to recompute the array. We also decided to fall back right to English if a string is missing. So if a user requests de_ch and we are missing strings we will insert the English string and not the German string. This will avoid to many lookups during startup in case we need to recreate the nls bundle.
I did some first performance testing and we should be able to fully regenerate a bundle in ~200ms. This is only a price we pay when a new release is installed. A second startup will not pay that price. And it will only happen for translation we don't ship in the box.
A big unknown is currently translations for bundled extension. The reason is that we don't do any bundling here and therefore there are quite some files to write which is performance wise not good. To not block the startup for too long we could do this in parallel when the workbench already loads. We would only need to synchronize with the extension host startup.

Actually with the work @joaomoreno is doing we could generate the files during the install process at least for Windows and Mac.


added jasmine-core to devDependencies

added jasmine-core to devDependencies
While trying to understand unit tests I stumbled across the little bug, that the jasmine-core is not a devDependency. The tests with karma and jasmine wont be able to run, unless you have the jasmine-core already installed globally.

I signed it!


Allow parameterization of Ingress TSL secret name

Feature description
see title
Suggested solution
No response
Code snippets
No response

@lreneral: Would that be sufficient for you?
# CKAN ingress
# ...
#...
tls:
- hosts:
{{- range $domains }}
  - {{ . }}
{{- end }}
    secretName: {{ (coalesce .Values.ingress.tls.secretName .Values.global.ingress.tls.secretName (printf "%s-%s" (first $domains) "tls" )) | quote }}
# ...
# ...

This would allow to:

Set a tls secet name for all Ingress using .Values.global.ingress.tls.secretName
Overwrite the tsl secret name for each Ingress with: .Values.ingress.tls.secretName
If none of those is set, it will default to the first entry in the ingress.domains list appended by -tls. For instance:

global:
  ingress:
    domains:
      - abcd.de
      - cdef.de

==> TLS secet name=abcd.de-tls

Resolved in https://github.com/tum-gis/sddi-ckan-k8s/releases/tag/sddi-ckan-1.2.2.


Release new version

Hi,
I have added Xero Gradle dependency to my build.gradle. Everything is fine till I want to use a specific method (createBankTransactions) in my code. Exploring the XeroClient.class in eclipse, I can't locate this method. Following is the missing code comparing to github version:
  public List<BankTransaction> createBankTransactions(List<BankTransaction> bankTransactions) {     ArrayOfBankTransaction array = new ArrayOfBankTransaction();     array.getBankTransaction().addAll(bankTransactions);     return put("BankTransactions", objFactory.createBankTransactions(array)).getBankTransactions();   }
I am using ver 0.13 in my build file. Am I missing something?

There code was added after 0.13 was released. There is no currently released version with that method. I cannot release a new version until the XML schemas are fixed. See https://github.com/XeroAPI/XeroAPI-Schemas/issues/32

Is it time to give up on XeroAPI-Schemas ? The xero-java-client is unusable now for me due to the known issues everyone has, coupled with the fact Xero don't care about keeping it up to date or even use it themselves for validation.
I have a colleague working on a simple POJO entity approach w/ Jackson that just tracks the Xero API docs directly (rather than the retrofitted schema supplied by Xero). Right not we are just implementing the objects we need (related entities involved in Invoice creation) but happy to commit a branch back once it is ready if other folks want to add entities they care about.

I just added a note to the README about this, but Connectifier was recently acquired. As a result, our accounting systems will be changing to better integrate with our new parent company and this repository will no longer be maintained. I'd recommend forking the repo.


The DOS prompt is missing its backslash!

If you use this exact character, you will get a backslash that the CSS parser allows through its checks:
∖
It's a math symbol that means something or other. Specifically, it should go in the subscribers text, as so: C:∖>
Magic Backslash Ahoy!

Nice find!
I plan to make a wiki for eliteshell at some point, and this will definitely be going in there.


Gradient (linear/radial) support for DOM rendering of circles/rectangles

Another potential fix for https://github.com/phetsims/scenery/issues/211 and https://github.com/phetsims/acid-base-solutions/issues/97. IE9 does not have support, so we would have to feature-detect.

No longer an issue, closing.


Move encoding question

Hello,
I would call "MakeMove(move);" on your engine.
How do I have to encode the "move" when I have "e2e4" or "d7d8Q" (in case of pawn promotion)?
Thank you and regards,
Frank

You can call GetMoveFromString("e2e4").  Make sure everything is lower case though.


Box Volume, OnLeave function not called when leaving Room

If a Box Volume is put next to a portal, the onLeave function is not called when Lara leave the Box Volume to enter a different room.

On example picture Box Volume is put on red square (2D map) next to 2 portals. If Lara leaves Box Volume Eastward or Southward, onLeave function is never called, as she leaves the room and enters a different room.
But OnLeave function is called if Lara leaves the Box Volume and stay in the same room (West and North direction here).
OnEnter function works fine.

Lwmte said it is not supported so closing.

While it is not supported or implemented (yet?), it should be documented because it's not obvious for builders and may lead to confusions ;)


TS-5107: init_customizations() isn't new in Docutils 0.13

We can use it in 0.12 and 0.13.
@jsime Thanks for merging #1303. Sorry for the mistake! If you approve, can you please merge this correction?

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1395/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1289/ for details.

@jablko As much my fault as anything on #1303 for not testing against the same package versions as the doc server. This PR builds fine for me now with sphinx 1.4.8 and docutils 0.12.0. Thanks for the fixes!

@jsime Thank you!


Building for node v18.13.0 and Electron 22.0.0

I'm trying to build for node version 18.13.0 and Electron 22.0.0 but i get the following error:
node build.js --upload=false                                                                                 70%   1 Mbps  ─╯
Building iohook for node v18.13.0>>>>
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: spawn /home/scorpion197/chronly-test/chronly-electron/node_modules/iohook/node_modules/.bin/node-gyp ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn /home/scorpion197/chronly-test/chronly-electron/node_modules/iohook/node_modules/.bin/node-gyp',
  path: '/home/scorpion197/chronly-test/chronly-electron/node_modules/iohook/node_modules/.bin/node-gyp',
  spawnargs: [
    'configure',
    'rebuild',
    '--target=18.13.0',
    '--arch=x64',
    '--v8_enable_pointer_compression=1',
    '--build_v8_with_gn=false',
    '--enable_lto=false'
  ]
}

Node.js v18.13.0

Have you solved this?

@Ankit-Devslane nope I ended up with writing something similar with Rust


Release with angular 5 support

When reporting a bug, please be sure to include the following:

[X] A descriptive title
[ ] An isolated way to reproduce the behavior (example: GitHub repository with code isolated to the issue that anyone can clone to observe the problem)
[ ] What version of angular-meteor you're using, and the platform(s) you're running it on
[ ] What packages or other dependencies you're using
[ ] The behavior you expect to see, and the actual behavior

See here for more detail on what is expected of a bug report.
When you open an issue for a feature request, please add as much detail as possible:

[X] A descriptive title
[ ] A description of the problem you're trying to solve, including why you think this is a problem
[ ] An overview of the suggested solution
[ ] If the feature changes current behavior, reasons why your solution is better

Do you mean for the Angular CLI + Meteor client bundler or the Meteor CLI?

Please open the issue if the problem is still continuing.
Thank you!


fix($animate): invalid CSS class names should not break subsequent elements

The postDigest handler was not being added if the first element in
to modify the CSS classes contained invalid CSS class names. This meant
that subsequent valid CSS class changes were not being handled since we
were not then adding the handler for those correct cases.
Closes #12674

Here is the Plunker showing the issue with the fixed version of Angular: http://plnkr.co/edit/Zux7ICpKvsh6oa25vlzr?p=preview

The diff looks more complicated that it is. I pulled two functions, updateData and handleClassChanges, from out of the addRemoveClassesPostDigest function. This means that we are not having to recreate them on every call and also makes the addRemoveClassesPostDigest easier to grok.

Without the refactor, it would be easier to see what actually changed semantically, though ;)

LGTM. Excellent work.

@Narrate you're right. I should have made two commits

Here is the plunker with the most recent fix: http://plnkr.co/edit/ppS7j623Wz4DifRRBjtu?p=preview

@Narretz - there I have broken the PR into two commits.

@petebacondarwin I almost down dare to say it, but ... it's actually refactor, not refact.

Doh!

@Narretz shouldn't you be asleep?


Vim plugins

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

the darwin failure is quite strange,  there does not seem to be any warning :s a fluke ?

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim, vimPlugins.coc-nvim, vimPlugins.nvim-hs-vim, vimPlugins.vim-lion

the rebase fixed the failure. @timokau Ready to merge  IMO


'install' is undefined, function name appears to have been removed by uglification

EDIT I'm bundling with Webpack.  I think the problem is the script is getting run in strict mode.
I just installed and tried to use this.
When I load my page I get an 'install' is undefined error.
Looking at the code in node_modules/immutable-devtools/dist/index.js, it looks like src/index.js is transformed from this:
// Check for globally defined Immutable and add an install method to it.
if (typeof Immutable !== "undefined") {
  Immutable.installDevTools = install.bind(null, Immutable);
}

// I imagine most people are using Immutable as a CommonJS module though...

let installed = false;
module.exports = function install(Immutable) {
...

To this:
Immutable.installDevTools=install.bind(null,Immutable));var o=!1;n.exports=function(n){if("undefined"==typeof window)
As you can see, uglification removed the name of the install function.
Looking forward to using this though, thanks!

Does moving the install function up to the top fix it?

yup!  basically what I did in a fork to go ahead and get it running

Closed?

@andrewdavey Closed?

function name should not affect actual export. Also this should be resolved by #15


SSR / BMapLib.TextIconOverlay causes break right away on import

[BUG 反馈] SSR / BMapLib.TextIconOverlay causes break right away on import
浏览器版本号

Vue 版本号
2.6.x
组件库版本号
0.21.20
现象描述
When rendering a Vue SSR page with only import XXX from 'vue-baidu-map' it causes exception stopping rendering

完整异常信息
navigator is not defined

This reporting tool is unfortunately so bad I'll have to write more in the actual Github issue when it's been created.

在线示例 / 仓库 URL
www.doesnotexist.com
复现用例
example

预期输出
-

实际输出
-

More specifically, this is caused by the BMapLib.TextIconOverlay lib, which is used by Lushu and MarkerClusterer. Since everything is imported right away, this causes all SSR to not work. This is unfortunate, as it's best practice to import frontend libs also in SSR build (to avoid having to many different code bases) - even if we are only rendering any map components in the frontend.
A possible workaround seems to be to only import selected modules.
One solution is to not import/export the extra components in the main file.


Remove app-c, app-h and app-o prefixes

To maintain consistency with the coding conventions in Frontend, where we're removing these prefixes.
This PR removes all app related prefixes
Trello ticket: https://trello.com/c/WLxTUttG/871-update-design-system-styles-to-follow-new-conventions

You can preview this change here:
Built with commit a5a613f7db96b1117681e1969de9b20eedea254a
https://deploy-preview-228--govuk-design-system-preview.netlify.com


Add a cleanup function to API and/or plugins that removes unnecessary infrastructure

As an example of why this is necessary, imagine the user creates a multicloud rule on an instance but deletes the rule afterwards. Currently, this will not tear down the multicloud infrastructure (it may be used by other rules!). We should implement a cleanup that is either regularly called by the orchestrator or is initiated by the user to remove any costly infrastructure that is not currently being used.

@smcclure20 any chance this could be "good first issue" or at least "help wanted"?

I think its a good help wanted at least - will update


run "carthage update" in command line

Xcode 7 beta 5 caused APIKit/Request.swift to fail to build:
*** Fetching APIKit
*** Fetching Result
*** Checking out APIKit at "1.0.0-beta2"
*** Checking out Result at "0.6-beta.1"
*** xcodebuild output can be found in /var/folders/zs/nrb9j0ws1q79l86sbfstq3180000gn/T/carthage-xcodebuild.TMppnX.log
*** Building scheme "Result-Mac" in Result.xcodeproj
*** Building scheme "Result-watchOS" in Result.xcodeproj
*** Building scheme "Result-iOS" in Result.xcodeproj
*** Building scheme "APIKit-Mac" in APIKit.xcworkspace
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal x86_64 /Users/user/Projects/Demo/Carthage/Checkouts/APIKit/APIKit/Request.swift
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)
/Users/user/Projects/Demo/Carthage/Checkouts/APIKit/APIKit/Request.swift:92:51: error: 'stringByAppendingPathComponent' is unavailable: Use stringByAppendingPathComponent on NSString instead.
A shell task failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal x86_64 /Users/user/Projects/Demo/Carthage/Checkouts/APIKit/APIKit/Request.swift
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

This is already addressed in #58, so you should specify master branch or 17af19306697b94ae61e73d6e4793010f13ad216 in your Cartfile at the moment.

thanks!


Modified dummygram logo

This PR closes issue no. #820
Added a blue tint and a little design to logo. I created a new component for it as it is getting used in about 4 places.

Hi @Palakkgoyal if you're active, please let me know If I should merge this one first or your other prs. Sorry I was travelling and all for last 2 days


Creating HasIslands component with useRequestContext in react-renderer

What is the feature you are proposing?
I would like to create a component called HasIslandWithReactRenderer so that island will work even when using react-renderer.
Currently there is only a HasIsland component that supports the hono/jsx context, so if I use reactRenderer I get an error: RequestContext is not provided.
For your information, I made it in my repository and it worked, how about you?
Reference implementation:
import { useRequestContext } from "@hono/react-renderer";

const HasIslandWithReactRenderer: FC<PropsWithChildren> = ({ children }) => {
  const c = useRequestContext();
  return <>{c.get(IMPORTING_ISLANDS_ID) ? children : <></>}</>;
};

Hi @yossydev
That will be very helpful for React-users! But honox/server should not export HasIslandWithReactRenderer as the same as HasIsland.
I'm planning to make the helper methods for using React as a renderer like this:
import { createClient } from 'honox/react/client'

Or creating a package:
import { createClient } from '@honox/react/client'

So, it's a good idea to make HasIslandWithReactRenderer or simply HasIsland in honox/react or @honox/react.
However we're in the process of designing it now, so we can't get started right away.

Thank you for your comment! @yusukebe
I understand! Someone wanted to use shadcn/ui in honox, but shadcn/ui depends on react, so I was touching things up to make the development experience there better!


The 'Query builder' action is disabled after clearing the query in text editor

Storage Explorer Version: 1.29.0-dev
Build Number: 20230330.2
Branch: feature/table-explorer-react
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.2.1 (Apple M1 Pro)
Architecture: ia32/x64/arm64
How Found: From running test cases
Regression From: Previous release (1.28.1)
Steps to Reproduce

Expand one storage account -> Tables.
Right click one table -> Click '[2] Open' -> Add one entity.
Click 'Query' -> Open the text editor.
Clear the text editor.
Check whether the 'Query builder' action is enabled.

Expected Experience
The 'Query builder' action is enabled.

Actual Experience
The 'Query builder' action is disabled.

@v-kellyluo I have not observed this behavior for some time. Please reverify with a new build.

@v-kellyluo How did you clear the query? Did you click the Clear Query button, or did you backspace until the text was gone?

@craxal , I pressed backspace until the text was gone.
Verified this issue on the build main 20230406.3, it doesn't reproduce if pressing backspace until the text was gone, but it still reproduces if selecting all then pressing backspace.

@craxal , verified this issue on the build 20230508.1, the 'Query builder' action is still disabled if selecting all then pressing backspace, which is different from previous release, so we are going to reopen it.

@v-kellyluo I cannot reproduce on either 20230506.4 or 20230508.1. Can you provide a screenshot or GIF or a more detailed description of what you are doing and observing?

OK, I was able to reproduce if selecting all the text and deleting is the first thing I do. Before deletion, I can go back to the builder. Bit odd, and I'll look into it, but there is a workaround: edit the text and delete again.

Verified this issue on the build main 20230531.3. Fixed.


CodeGen: add Flutter support

[ ] add Component/Controler logic
[ ] add spec file (if applicable)
[ ] add HTML/XML/View (if applicable)
[ ] add styles
[ ] add readme
[ ] add export to stackblitz (or other external editor)
[ ] add unit test
[ ] add entry to the editor menu

See getting started: https://flutter.dev/docs/get-started/codelab

Love it can i work on that!?

hey @romulocintra, do you have any updates on this issue? If you need any help just ping us.

Hi, @Jefiozie  did not had time to look deeply on that .
But i found that code needed for flutter to paint the components will very different that one we output.
Meaning a simple Css equivalent file would be something like :

TextStyle(
  color: Colors.white,
  fontSize: 24.0,
  fontWeight: FontWeight.w900,
);

or something like :
 color: Color.fromRGBO(0, 0, 0, 0.8),
    fontFamily: 'NotoSans',
    fontSize: 32.0,
    fontStyle: FontStyle.normal,
    fontWeight: FontWeight.bold,

This means we must create some transforms to be really applied as style , beside of that all layout part isn't easy to apply at this stage.
I saw this article that talks about a possible web implementation but i see easy to implement a Dart export than the flutter at this point.

@manekinekko  any friend from google involved ? to give us a hand on this !?

I wrote a simple design document that should highlight some points about how we can implement Flutter in CodeGen assuming a minimal knowledge of the xLayers flow (CodeGen services). https://docs.google.com/document/d/1xO6GvXif8AAubMrvTeC2PglcpQrWdVmvIY2bDfxOQl4/edit?usp=sharing

I wrote a simple design document that should highlight some points about how we can implement Flutter in CodeGen assuming a minimal knowledge of the xLayers flow (CodeGen services). https://docs.google.com/document/d/1xO6GvXif8AAubMrvTeC2PglcpQrWdVmvIY2bDfxOQl4/edit?usp=sharing

Very good 👍


Website updated - missing @EnableScheduling added to spring configuration classes

@vicianm Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@vicianm Thank you for signing the Contributor License Agreement!

@acogoluegnes @garyrussell perhaps you folks understand the intent here?

Quote from https://spring.io/guides/gs/scheduling-tasks/:
@EnableScheduling ensures that a background task executor is created. Without it, nothing gets scheduled.

It's possible that the @EnableScheduling annotation is necessary on other than the 3 aforementioned tutorials. So far I tested only on these. Without the annotation no TutNSender#send() method gets fired.

Looks like it is because publishers in all 6 Spring tutorials rely on @Scheduled for periodic task execution. Why are we only updating 3 tutorials then and not all of them? Only tutorial 1 at the moment
uses @EnableScheduling:
grep -R "EnableScheduling" site
site/tutorials/tutorial-one-spring-amqp.md:import org.springframework.scheduling.annotation.EnableScheduling;
site/tutorials/tutorial-one-spring-amqp.md:@EnableScheduling

Why am I updating only 3 tutorials?
As I already mentioned, because so far I didn't test the rest of them. I tested only the first three tutorials. If rest of the tutorials also rely on @Scheduled the @EnableScheduling should be probably added.
Why the tutorial might work for somebody?
The one who doesn't need explicit @EnableScheduling declaration might have declared the annotation implicitly in some dependency (see for example this link: https://stackoverflow.com/questions/43204377/spring-boot-scheduler-runs-without-enablescheduling-annotation)

@EnableScheduling only needs to be on one configuration class.
It is already there on the RabbitAmqpTutorialsApplication class further down in the tutorial.
https://github.com/rabbitmq/rabbitmq-website/blame/live/site/tutorials/tutorial-one-spring-amqp.md#L149

@EnableScheduling only needs to be on one configuration class.
It is already there on the RabbitAmqpTutorialsApplication class further down in the tutorial.
https://github.com/rabbitmq/rabbitmq-website/blame/live/site/tutorials/tutorial-one-spring-amqp.md#L149

I see. My bad.
I generated the project with Spring's Initializr (https://start.spring.io/) and did not copy the whole content from you tutorial.

Thank you @garyrussell 👏.


Error in qcsummary.py

Under version 0.9.8, the following error will be triggered if kraken is enabled:
Traceback (most recent call last):
  File "/usr/local/bin/bcbio_nextgen.py", line 4, in <module>
    __import__('pkg_resources').run_script('bcbio-nextgen==0.9.8', 'bcbio_nextgen.py')
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/setuptools-23.0.0-py2.7.egg/pkg_resources/__init__.py", line 719, in run_script

  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/setuptools-23.0.0-py2.7.egg/pkg_resources/__init__.py", line 1504, in run_script

  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio_nextgen-0.9.8-py2.7.egg-info/scripts/bcbio_nextgen.py", line 226, in <module>
    main(**kwargs)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio_nextgen-0.9.8-py2.7.egg-info/scripts/bcbio_nextgen.py", line 43, in main
    run_main(**kwargs)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 43, in run_main
    fc_dir, run_info_yaml)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 87, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 186, in variant2pipeline
    samples = qcsummary.generate_parallel(samples, run_parallel)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 44, in generate_parallel
    samples = run_parallel("multiqc_summary", [samples])
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"])(joblib.delayed(fn)(x) for x in items):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 800, in __call__
    while self.dispatch_one_batch(iterator):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 658, in dispatch_one_batch
    self._dispatch(tasks)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 566, in _dispatch
    job = ImmediateComputeBatch(batch)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 180, in __init__
    self.results = batch()
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 72, in __call__
    return [func(*args, **kwargs) for func, args, kwargs in self.items]
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 51, in wrapper
    return apply(f, *args, **kwargs)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 139, in multiqc_summary
    return qcsummary.multiqc_summary(*args)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 916, in multiqc_summary
    samples = report_summary(samples, os.path.join(out_dir, "report"))
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 1151, in report_summary
    samples = _merge_metrics(samples)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 1244, in _merge_metrics
    dt = pd.DataFrame(m, index=['1'])
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/pandas/core/frame.py", line 224, in __init__
    mgr = self._init_dict(data, index, columns, dtype=dtype)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/pandas/core/frame.py", line 360, in _init_dict
    return _arrays_to_mgr(arrays, data_names, index, columns, dtype=dtype)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/pandas/core/frame.py", line 5241, in _arrays_to_mgr
    return create_block_manager_from_arrays(arrays, arr_names, axes)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/pandas/core/internals.py", line 4004, in create_block_manager_from_arrays
    construction_error(len(arrays), arrays[0].shape, axes, e)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/pandas/core/internals.py", line 3966, in construction_error
    raise e
ValueError: could not broadcast input array from shape (40) into shape (1)

Proposed fix is available below:
#1439

Thanks so much for the issue notification and the fix. I merged the PR.
many thanks!


ci: allocate capacity fitting the runner specs

hopefully should make tests go faster by allocating (almost) all the available space of the runner

@davidcassany @Itxaka I've also tweaked the packer template and boosted cpu/ram there. Default was 1CPU/512MB of ram, that could explain why it was so flaky...


⚠ Auth has degraded performance

In c08abd4, Auth (https://auth.k2lin.com) experienced degraded performance:

HTTP code: 200
Response time: 17143 ms

Resolved: Auth performance has improved in a5e1844.


Replace test using CLIEngine class with ESLint class.

This change is a preparation for ESLint v8 support.

LGTM!
(Is this ready to merge? You haven't requested review. If it is, feel free to go ahead and merge it.)
Speaking of v8, seems like we'll have to add some hasSuggestions properties as well. Want me to make a PR?

Speaking of v8, seems like we'll have to add some hasSuggestions properties as well. Want me to make a PR?

Oh, I missed it. I will open that PR.


[BUG] - [Chat] - ReadReceipts are not stored for Threads with more that 20 Participants

Library name and version
Azure.Communication.Chat 1.1.1
Describe the bug
Hi,
We are using ACS Chat for multi-user text based communications.
We noticed that some of our Threads do not have the "Message Seen" icon, which is rendered in the React UI controls by default.
When checking the data for these Threads, we noticed that there are no ReadReceipts returned from the API calls.
Although there are successful POSTs for ReadReceipts, there GET never returns any data and is just an empty Array.
After doing some manual tests, we found the Threads exhibiting this behavior contained many Participants.
As such, I wrote a C# POC that performs a looping Test, whereby it;

Creates a User -> the Thread creator
Creates a Thread
Adds UserCount Participants to the Thread
Adds a Message for every Participant using the Participant's Id
Adds a ReadReceipt for every Messages using the Creator's Id
Checks that there is at least 1 ReadReceipt after adding all the ReadReceipts

When executed, the test always fails when there are more that 20 Participants added to the Thread.
So, any Thread with more than 20 Participants does not have ReadReceipts, and as a result does not display the "Message Seen" indicator.
Thanks in advance for your time.
Expected behavior
A Thread with more than 20 Participants can have ReadReceipts stored.
Actual behavior
Threads with more than 20 Participants cannot store ReadReceipts
Reproduction Steps
Please run the following;

Unzip to a local folder
dotnet build
Execute

ConnString -> your ConnectionString
UserStart -> 17 -> Starting with a Thread containing 17 Participants
UserEnd -> 22 -> Ending with a Thread containing 22 Participants

.\bin\Debug\net6.0\AcsChatReadReceipts.exe "endpoint=https://XXX.com.communication.azure.com/;accesskey=/YYYYueicCOV1Lmtg==" "17" "22"
AcsChatReadReceipts.zip
The output will be something like;
> PS C:\alex\code\Apps\AcsChatReadReceipts\Test> .\bin\Debug\net6.0\AcsChatReadReceipts.exe "endpoint=https://XXX.com.communication.azure.com/;accesskey=/YYYYueicCOV1Lmtg==" "17" "22"
> ReadReceipts Test started for [17] Users to [22] Users for Site [https://XXX.com.communication.azure.com/]
>
> ExecuteReadReceiptTest - Count [17/22] - Started
> Added Users [17] to Thread<EMAIL_ADDRESS>> Total Users [17] -> Thread<EMAIL_ADDRESS>added Messages [18]
> Total Users [17] -> Thread<EMAIL_ADDRESS>added ReadReceipts [18]
> Success -> Total Users [17] -> ReadReceipts [1]
> ExecuteReadReceiptTest - Count [17/22] - Completed
>
> ExecuteReadReceiptTest - Count [18/22] - Started
> Added Users [18] to Thread<EMAIL_ADDRESS>> Total Users [18] -> Thread<EMAIL_ADDRESS>added Messages [19]
> Total Users [18] -> Thread<EMAIL_ADDRESS>added ReadReceipts [19]
> Success -> Total Users [18] -> ReadReceipts [1]
> ExecuteReadReceiptTest - Count [18/22] - Completed
>
> ExecuteReadReceiptTest - Count [19/22] - Started
> Added Users [19] to Thread<EMAIL_ADDRESS>> Total Users [19] -> Thread<EMAIL_ADDRESS>added Messages [20]
> Total Users [19] -> Thread<EMAIL_ADDRESS>added ReadReceipts [20]
> Success -> Total Users [19] -> ReadReceipts [1]
> ExecuteReadReceiptTest - Count [19/22] - Completed
>
> ExecuteReadReceiptTest - Count [20/22] - Started
> Added Users [20] to Thread<EMAIL_ADDRESS>> Total Users [20] -> Thread<EMAIL_ADDRESS>added Messages [21]
> Total Users [20] -> Thread<EMAIL_ADDRESS>added ReadReceipts [21]
> Unhandled exception. System.ArgumentException: Failed -> Total Users [20] -> ReadReceipts [0]
>    at AcsChatReadReceipts.Program.ExecuteReadReceiptTest(CommunicationIdentityClient client, Uri connEndPoint, Int32 participantCount) in C:\alex\code\Apps\AcsChatReadReceipts\Test\Program.cs:line 99
>    at AcsChatReadReceipts.Program.Main(String[] args) in C:\alex\code\Apps\AcsChatReadReceipts\Test\Program.cs:line 52
>    at AcsChatReadReceipts.Program.<Main>(String[] args)
>
>

Environment
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19044
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.401\
global.json file:
Not found
Host:
Version:      6.0.9
Architecture: x64
Commit:       163a63591c
.NET SDKs installed:
3.1.402 [C:\Program Files\dotnet\sdk]
5.0.203 [C:\Program Files\dotnet\sdk]
5.0.301 [C:\Program Files\dotnet\sdk]
5.0.402 [C:\Program Files\dotnet\sdk]
6.0.100 [C:\Program Files\dotnet\sdk]
6.0.201 [C:\Program Files\dotnet\sdk]
6.0.302 [C:\Program Files\dotnet\sdk]
6.0.400 [C:\Program Files\dotnet\sdk]
6.0.401 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.11 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.39396873,Service Bus:0.13119923,Extensions:0.063790865'

Closed and move to the following;
https://github.com/Azure/communication-ui-library/issues/2364
Apologies.


How we can use these given model in detecting object in videos?

Hi
I am working on detection of objects in videos and want to use the given models in videos to detect.
Kindly help

I think faster rcnn is not suitable for detecting objects in videos because it can only reach about 7fps,and I guess YOLO or SSD can do this for you...

Ok Thanks.


Configre the default namespace generated by "dotnet new stylet" CLI command.

I created a project with the CLI command dotnet new stylet, and the default namespace generated is "Company.WpfApplication1".
Is there somewhere I can configure it? I prefer it to be the same with the project name.

dotnet new stylet ProjectName

dotnet new stylet -o MyStyletProject, as the README says.

That's exactly what I did, the default namespace still is "Company.WpfApplication1".

Interesting. It should have out all of the files in another namespace. I'm busy this weekend, will have a look next week.

Any news?

My bad, this slipped off my radar sorry!
This was a typo in the template: it'll be fixed in the next release

I just wondered if this had been fixed yet.  I just used dotnet new to create a new .NET 5 project and the default namespace is still Company.WpfApplication1.  Thanks!

Looks like I made the fix but haven't released it. I want to get a few things fixed for .NET 5 this weekend, so hopefully I can get a release out then.

Thank you!

Fixed in 1.3.5


Update Crashed

I'm submitting a

[x] Bug report
[ ] Feature request
[ ] Other

Bug Report 😨

What is the current behavior?
The startup version of the app when you select yes to update it crashes because it cant find the zip because its using current directory to find it but because the computer is launching the program its current directory is C:\Windows\System32

Please tell us about your environment:

Version: V1.2.1 Updating to V1.2.2
Operating System: Windows 10
Is this a school computer: Yes, also the same happens for non school pc as well
List any other information you may think may be relevant here:

If the current behavior is a bug, please provide the steps to reproduce and submit a screenshot along with the error message.

Use the startup mode and update the app through the startup version and it will crash

What is the expected behavior?

The program to update and not crash.

Fixed in #9


Improve ordering of legend for group variable

For treatment (or any variable with a numeric equivalent), it would be good to order the legend by TRTN so that it is ordered Placebo, Xano Low, Xano High. (via @rzink01)

This is non-trivial. There is an option available to order the legend, but sorting the legend based on a second variable would require custom implementation.


Verify the trigger and format of request counter logs

What type of PR is this?
/kind feature

What this PR does / why we need it:
This change uses the newly added timewrapper package for creation of a new test: TestLog(). This test simply ensures all request counters within a Network Monitor will log correctly. It does NOT test the frequency or order of the logs, as doing so requires much more complicated synchronizations with goroutines. In the future, request counters can individually verify their logging frequency by explicitly testing the watch() function.
Which issue(s) this PR fixes:
Part of #358
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Creating TestLog() to verify the triggering and format of request counter logs.

cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering

/assign @amwat

After discussion with @amwat, it has been decided to abandon directly testing NetMonitor.Log() in favor of directly testing a resource counter's watch function. This will simplify the testing strategy to avoid independent goroutine synchronizations.
/close

After discussion with @amwat, it has been decided to abandon directly testing NetMonitor.Log() in favor of directly testing a resource counter's watch function. This will simplify the testing strategy to avoid independent goroutine synchronizations.
/close

Makes sense. +1


Blescanner.py cannot detect any BLE devices

Hi, I was going through this instruction ==> "http://docs-europe.electrocomponents.com/webdocs/12eb/0900766b812eb651.pdf" and then when I'm trying to run python code to scan other BLE devices it cannot detect any while there so many around it. Basically, I'm seeing something like this, can someone help me with this?

That visible sequence of hex bytes translates per asciitohex.com as follows:
<--- enter ASCII 0 to reboot in dfu

Fortunately, this tells you exactly what you have to do. Your BLED112 is programmed with non-standard firmware, running some BGScript application. This means that it will not respond as expected to any BGAPI protocol commands. You will need to reboot in DFU mode and then use BLE GUI (or dfutool.exe via command line) to reflash the .hex file from the "usbcdc" example project that comes with the SDK. It should then start working as expected.

Thank you, it's been fixed


Feature/1149 pathfinder

Submisison Checklist

[x] Run tests: ./runCmdStanTests.py src/test
[x] Declare copyright holder and open-source license: see below

Summary:
Add method pathfinder to CmdStan with argument num_paths (name subject to change).
If num_paths == 1, run single path pathfinder, else run multi-path pathfinder.
Intended Effect:
Expose new service methods from PR https://github.com/stan-dev/stan/pull/3123
How to Verify:
unit tests
Side Effects:
N/A
Documentation:
will be created as separate PR on docs repo
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

currently a WIP - needs:

review current user-facing names
unit tests
performance tests

closing - work continues in https://github.com/stan-dev/cmdstan/pull/1155


some fix in stringtable and debug info

good catch with the stringtable. Added that one also to the 96 branch by myself now.
There where some more like that after the chinese translation was contributed.
Thanks for finding them :)


Fix a cuml parameter has not been updated bug

When users call estimator.fit(df, {parameters}), it first copies the parameters into estimator, but it can't propagated them into cuml parameters.

build

Should we just apply the spark params to cuml params mapping on the fly just before invoking fit and transform instead of maintaining a separate cuml_params dictionary?
The dictionary would only be used for cuml params set directly in the constructor and would be overridden by any corresponding Spark Param.

Hmm, yes, the idea of updating on the fly is ok for the training/transform. But the PR overriding the copy can also fix the copy() API itself issue. Please take a look at the new test I added.

build

build


Overlapping fruit label use

I suppose the raster mask wont capture overlapping labels in a meaningful way? This probably is the first case of moving away from rasters altogether and using SVG directly in ML training code. Thoughts?

Here is an example: https://www.dropbox.com/s/6uk8rksbavbq7tc/P2379L1070CappleIframe621.jpg.png?dl=0

It is possible to have rasters with that information (see frame621gray.png at https://www.dropbox.com/home/kumar-prec-ag/temp which does not seem to show up properly on the dropbox preview), but I agree that SVG is better for capturing this information.

New averages use "overlap-aware" values.


Use connected account's avatar on accounts icon

When connected to an account, either your Microsoft or your GitHub account, replace the accounts icon of the side bar with the connected account's avatar. If there is no avatar, use the current default icon.

We discussed doing this when first designing the accounts feature and thought this would generate too much noise on the activity bar. Right now all of the other icons are somewhat consistent with each other and have similar colors. Also, the behavior when you are signed into multiple accounts is unclear.


Metrics refactor

Motivation
WIP: adjust the iOS metrics SDK to the updated proposal and also streamline it's API so that it's closer to the Android SDKs.
Metrics is now part of AGSCore. To use metrics you can either use:
AgsCore.instance.sendDefaultMetrics()

or:
let metrics: AgsMetrics = AgsCore.instance.getMetricsService()
metrics.publish(MyMetrics())

@pb82 Really sorry for highjacking your PR. I created new PR on upstream to better collaborate without pushing to your fork. All my comments were addressed there already to save you troubles.


Update Google Maps 2.7.0

VS bug #742855

Hi, I'm waiting for an update to 2.7.x too, 2.5.x is a very old version.

@pizzaeater We have this on our TODO list and have plans to be updated in the following weeks, but community contributions are also very welcome!
If someone wants to update just the binding project, that would be enough help for us. We can help you in the process and with the other files


[Jira] Pressing on enter but it did not open jira task on dropdown items

Extension
https://www.raycast.com/raycast/jira
Raycast Version
v1.83.2
macOS Version
No response
Description
Pressing on enter but it did not open jira task on dropdown items, when I selected my special filter from JIRA
Steps To Reproduce
Pressing on enter but it did not open jira task on dropdown items
Current Behaviour
No response
Expected Behaviour
No response

Could you share a recording? It'll make it easier to see what's happening.

Uploading vid.mov…
I am attempting to open a ticket details through my custom filters using open raycast-jira extension, but it's not opening as on the video.
thanks

Does it happen for all tickets across all the extensions' commands (e.g., My Filters, Active Sprints, Search Issues, etc.)?

Does it happen for all tickets across all the extensions' commands (e.g., My Filters, Active Sprints, Search Issues, etc.)?

It does happen for ‘My Filters’ named ‘Me’ which I created on Jira specifically as on the video.

Does it happen for all tickets across all the extensions' commands (e.g., My Filters, Active Sprints, Search Issues, etc.)?

When I select the custom filter I created in Jira, I am unable to open the ticket details by pressing Enter.

I unfortunately can't reproduce it so it's a bit hard to debug. Could you check it out locally and hopefully come up with a PR? If yes, here's our guide on extension contributions so that you can open up a pull request. Feel free to contact me here or in the Slack community if you need further help.

I'm closing this issue to maintain a clean backlog. Feel free to comment it if you still have the problem.


Fix invites page - button to sign up below content list

This should only be showing 1 row of content, so you don't have to scroll down a bunch to sign up.
Also check the logic on page load - think there's some action that tries to happen before the preferences are loading and it will say 'account not ready'.
Ensure the invite page still calls the referrer API.odysee.com call successfully.

This should be a quick one too - at least add the create account/skip to the top section for now.

17699f2e073c004876becbeb6e83b750b1b339e4


[REQUEST] Web JSON API of users and replays

Is your feature request related to a problem? Please describe.
It would be nice to have API data of the website.
Describe the solution you'd like
JSON example when searching "https://api.osureplayviewer.xyz/userProfile.php?id=11630662"
{
        "5dcc686ccaa77": {                            //ReplayID
            "Title": "Sunglow",
            "Author": "Yamajet",
            "Source": "crossbeats REV. SUNRISE",
            "etc":"etc",
            "Difficulty": {
                "Mode": 0,
                "Stars": 5.89,
                "Name" : "Melody",
                "CS": 4,
                "AR": 9.7,
                "etc":"etc"
            },
            "Replay":{
                "Score": 879270,
                "300": 675,
                "Geki": 82,
                "100": 314,
                "Katsu": 130,
                "50": 59,
                "Misses": 191,
                "maxCombo": 78,
                "accuracy": 63.72
            }
        }
    },
    "5dc31485eb164": {
        "Title": "Yoru no Kodomo tachi",
        "Author": "Roses Epicurean",
        "Source": null,
        "etc":"etc",
        "Difficulty": {
            "Mode": 0,
            "Stars": 4.28,
            "Name" : "Hard",
            "CS": 3.5,
            "AR": 8.5,
            "etc":"etc"
        },
        "Replay":{
            "Score": 613045,
            "300": 119,
            "Geki": 36,
            "100": 0,
            "Katsu": 0,
            "50": 0,
            "Misses": 0,
            "maxCombo": 168,
            "accuracy": 100.00
        }
}

Additional context
Would be nice if there would be a page where you can search a user by name in the link (https://api.osureplayviewer.xyz/search.php?input="SpeckyYT"  [which would return:] https://api.osureplayviewer.xyz/userProfile.php?id=11630662)

I think it would be better to switch the id out with the title so you can more easily use the json api to make a search system for mass search without having to make it too complex also the Search for user should return a JSON array/table with the username, id and some more info about the user.

It was only an example, it can be changed on decisions of the devs at any times.

Great idea, I'll keep this for the v2.


[archer2] Add initial configuration

This should be working, but I'm having lots of troubles with submitting the jobs.  I believe this is at least in part related to the fact ARCHER2 compute nodes can't access the home directory, but it isn't clear to me what is trying to access the home directory, I'll need to investigate more.
Fix #43

This is part of the issue, but there is more to it: https://github.com/spack/spack/issues/33265.

With the last two commit, to work around the issues I mentioned above, I was able to successfully run the example benchmark on archer2:
[==========] Running 1 check(s)
[==========] Started on Thu Oct 13 10:55:33 2022

[----------] start processing checks
[ RUN      ] SombreroBenchmark /cc391b86 @archer2:compute-node+default
[       OK ] (1/1) SombreroBenchmark /cc391b86 @archer2:compute-node+default
P: flops: 1.16 Gflops/seconds (r:1, l:None, u:None)
[----------] all spawned checks have finished

[  PASSED  ] Ran 1/1 test case(s) from 1 check(s) (0 failure(s), 0 skipped)
[==========] Finished on Thu Oct 13 10:58:03 2022

============================================================================================================================================================================================================================================
PERFORMANCE REPORT
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[SombreroBenchmark /cc391b86 @archer2:compute-node:default]
  num_tasks: 1
  num_gpus_per_node: 0
  num_tasks_per_node: 1
  num_cpus_per_task: 1
  performance:
    - flops: 1.16 Gflops/seconds (r: 1 Gflops/seconds l: -inf% u: +inf%)
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Interesting, I've got all compilers with spack compiler find on a login node.  Anyway, I removed the extra compilers and set fflags for GCC >= 10.


Replace github.com/hidetatz/kubecolor with github.com/kubecolor/kubecolor

https://github.com/hidetatz/kubecolor
https://github.com/kubecolor/kubecolor
https://github.com/aquaproj/aqua-registry/tree/main/pkgs/hidetatz/kubecolor
https://github.com/aquaproj/aqua-registry/tree/main/pkgs/kubecolor/kubecolor

We don't replace hidetatz/kubecolor with kubecolor/kubecolor because they are different repositories.
Instead, we'll add kubecolor/kubecolor.

https://github.com/aquaproj/aqua-registry/pull/21900

v4.162.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.162.0


Add the possibility to select the AP to use in cargo-flash

This should be done automatically lateron. For now --ap <num> can be used to select the proper AP.

This functionality is actually not neede. The memory AP is always AP 0 if I am not mistaken, and this was an experiment to test this on the locked nRFs.


Bunch of MicroWin error

I get these error messages. Any idea what should I do? Win11 24H2 iso.
What I did:

I tried to run the tool with powershell and with exe as well
releases folder / oscdimg.exe is downloaded and placed next to the tool, in local and in system32

The class is not registered

Access Denied

Package removal error

Creation failed

It created the ISO for me, but I had a bunch of errors as well and wanted to put here in case it can help identify the problem.
> Selected: Windows 11 24H2 (Build 26100.1742 - 2024.10), Home/Pro/Edu, English International, [x64]                      Downloading 'Win11_24H2_EnglishInternational_x64.iso' (5.0 GB)...                                                       Moving ISO file. Please wait...                                                                                File path C:\Users\Gokhan\Downloads\Win11_24H2_EnglishInternational_x64.iso                                             You have enough space for this operation.                                                                               Mounting Iso. Please wait.                                                                                Done mounting Iso MSFT_DiskImage (ImagePath = "C:\Users\Gokhan\Downloads\Win11_24H2_En..., StorageType = 1)             Iso mounted to 'G'                                                                                Setting up mount dir and scratch dirs                                                                                Mounting Iso. Please wait.                                                                                Done setting up mount dir and scratch dirs                                                                              Scratch dir is C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901                                   Image dir is C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901                                            Copying Windows image. This will take awhile, please don't use UI or cancel this step!                                  Copy 1158 file(s) from G: to C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901                            Copy complete! Total Time: 0m16s
> Getting image information C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901\sources\install.wim
> Finding suitable Pro edition. This can take some time. Do note that this is an automatic process that might not select the edition you want.
> Selected value '6 : Windows 11 Pro'.....
> Done reading and unpacking ISO
>
> *********************************
> Check the UI for further steps!!!
> Target ISO location: C:\Users\Gokhan\Desktop\Win11- MicroWin.iso
> Index chosen: '1' from 1 : Windows 11 Home
> Mounting Windows image. This may take a while.
> Mounting complete! Performing removal of applications...
> Remove Features from the image
> You can re-enable the disabled features at any time, using either Windows Update or the SxS folder in <installation media>\Sources.
> Removing features complete!
> Removing OS packages
> 27 package(s) could not be removed. Your image will still work fine, however. Below is information on what packages failed to be removed and why.
>
> - Permanent package cannot be uninstalled.
>
>   1) Package_for_DotNetRollup_481~31bf3856ad364e35~amd64~~10.0.9266.1
>   2) Package_for_RollupFix~31bf3856ad364e35~amd64~~26100.1742.1.10
>
> - The specified package is not valid Windows package.
>
>   1) Microsoft-Windows-Telnet-Client-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1742                             2) Microsoft-Windows-TerminalServices-AppServer-Client-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1            3) Microsoft-Windows-TerminalServices-AppServer-Client-FOD-Package~31bf3856ad364e35~wow64~en-GB~10.0.26100.1            4) Microsoft-Windows-StepsRecorder-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1742                                 5) Microsoft-Windows-StepsRecorder-Package~31bf3856ad364e35~wow64~en-GB~10.0.26100.1                                    6) Microsoft-Windows-StepsRecorder-Package~31bf3856ad364e35~wow64~~10.0.26100.1742                                      7) Microsoft-Windows-WinOcr-FOD-Package~31bf3856ad364e35~wow64~en-GB~10.0.26100.1                                       8) Microsoft-Windows-WinOcr-FOD-Package~31bf3856ad364e35~wow64~~10.0.26100.1742                                         9) HyperV-OptionalFeature-VirtualMachinePlatform-Client-Disabled-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1  10) Microsoft-Windows-TerminalServices-AppServer-Client-FOD-Package~31bf3856ad364e35~wow64~~10.0.26100.1                11) Microsoft-Windows-TFTP-Client-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1742                                                                                Removing Items                                                                                Deleting C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\OneDriveSetup.exe      [                                                                                ]        12) Microsoft-Windows-WinOcr-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1742                                                                                Removing Items                                                                                Deleting C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\OneDrive.ico           [                                                                                ]        13) Microsoft-Windows-InternetExplorer-Optional-Package~31bf3856ad364e35~amd64~en-GB~11.0.26100.1                       14) Microsoft-Windows-MediaPlayer-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1742                                  15) Microsoft-Windows-MediaPlayer-Package~31bf3856ad364e35~wow64~en-GB~10.0.26100.1                                     16) Microsoft-Windows-DirectoryServices-ADAM-Client-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1               21) Microsoft-Windows-SimpleTCP-FOD-Package~31bf3856ad364e35~amd64~en-GB~10.0.26100.1                                                                                Removing Appx Bloat                                                                                [INFO] In Your local takeown expects 'Y' as a Yes answer.                                                               [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\WebThreatDefSvc\*: Access is denied.
> C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\WebThreatDefSvc\*: Access is denied.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\WebThreatDefSvc\*: Access is denied.
> C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901\Windows\System32\WebThreatDefSvc\*: Access is denied.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> [INFO] In Your local takeown expects 'Y' as a Yes answer.
> Removal complete!
> Create unattend.xml
> Done Create unattend.xml
> Copy unattend.xml file into the ISO
> Done Copy unattend.xml
> Create FirstRun                                                                                Done create FirstRun                                                                                Copy FirstRun.ps1 into the ISO                                                                                Done copy FirstRun.ps1                                                                                Copy link to winutil.ps1 into the ISO                                                                                Copy checkinstall.cmd into the ISO                                                                                Done copy checkinstall.cmd                                                                                Creating a directory that allows to bypass Wifi setup                                                                   Loading registry                                                                                Disabling Teams                                                                                Done disabling Teams                                                                                Fix Windows Volume Mixer Issue                                                                                Bypassing system requirements (system image)                                                                            Removing Windows Expedited App: EdgeUpdate                                                                              Removing Windows Expedited App: DevHomeUpdate                                                                           Removing Windows Expedited App: OutlookUpdate
> Removing Windows Expedited App: CrossDeviceUpdate
> Setting all services to start manually
> Enabling Local Accounts on OOBE
> Disabling Sponsored Apps
> Done removing Sponsored Apps
> Disabling Reserved Storage
> Changing theme to dark. This only works on Activated Windows
> Unmounting Registry...
> Cleaning up image...
> Cleanup complete.
> Unmounting image...
> Exporting image into C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901\sources\install2.wim
> Remove old 'C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901\sources\install.wim' and rename C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901\sources\install2.wim
> Windows image completed. Continuing with boot.wim.
> Mounting boot image C:\Users\Gokhan\AppData\Local\Temp\Microwin_20241010_044616_901\sources\boot.wim into C:\Users\Gokhan\AppData\Local\Temp\MicrowinScratch_20241010_044616_901
> Loading registry...
> Bypassing system requirements on the setup image
> Unmounting Registry...
> Unmounting image...
> Creating ISO image
> [INFO] Using oscdimg.exe from: C:\Users\Gokhan\AppData\Local\Temp\oscdimg.exe
>                                                                                OSCDIMG 2.56 CD-ROM and DVD-ROM Premastering Utility                                                                    Copyright (C) Microsoft, 1993-2012. All rights reserved.                                                                Licensed only for producing Microsoft authorized content.                                                                                Scanning source tree (1000 files in 97 directories)                                                                     Scanning source tree complete (1056 files in 103 directories)                                                                                Computing directory information complete                                                                                Image file is<PHONE_NUMBER> bytes (before optimization)                                                                                Copying File                                                                                Progress                                                                                [                                                                                ]                                                                                0.00 MB / 4,846.75 MB                                                                                After optimization, image file is<PHONE_NUMBER> bytes
> Space saved because of embedding, sparseness or optimization = 15710208
>
> Done.
> OSCDIMG Error Level : 0
> Copying target ISO to the USB drive
> VERBOSE: Performing the operation "Copy File" on target "Item: C:\Users\Gokhan\Desktop\Win11- MicroWin.iso Destination:
>  F:\Win11- MicroWin.iso".
> File copied to Ventoy drive F
> Done Copying target ISO to USB drive!
>  _____
> (____ \
>  _   \ \ ___  ____   ____
> | |   | / _ \|  _ \ / _  )
> | |__/ / |_| | | | ( (/ /
> |_____/ \___/|_| |_|\____)
>
>
> Performing Cleanup...
> Done. ISO image is located here: C:\Users\Gokhan\Desktop\Win11- MicroWin.iso


Limit search results by Molecular Weight

Is it possible to limit the search by global additive properties such as molecular weight?

Yes, it is possible to do this efficiently. The algorithm first computes the "combinatorial hits", i.e. all synthon combinations that match. Then one could compute these additive properties for the synthons, and then when looping over all synthon combinations one could assemble only the combinations that are within the specified range. I will consider to include this in some way in the GUI.


hevcd: use VAProfileHEVCSccMain444_10 for scc-main444-10

VAProfileHEVCSccMain444_10 is defined in VA-API for scc-main444-10, so
we should use VAProfileHEVCSccMain444_10 instead of
VAProfileHEVCSccMain444

A media-driver fix is needed, https://github.com/intel/media-driver/pull/966

LGTM.

@xhaihao , can you please rebase? Thanks!

@dmitryermilov rebased, thanks.

@dmitryermilov, I checked Windows code and ran a Hevc_SCC_444_10b clip, Windows driver already defined GUID - DXVA_Intel_ModeHEVC_VLD_SCC_Main444_10Profile, and Windows MSDK also chooses it to decode Hevc_SCC_444_10b clip, so Windows does not have this issue.

Thanks!


Data retention?

I think this is more a question then an issue.
But I've recently changed the retention on my influxDB. With this covid-19 script stopped working:
Traceback (most recent call last):
  File "/home/pi/covid-19/covid19.py", line 77, in <module>
    client.write_points(measurements)
  File "/home/pi/.local/lib/python3.7/site-packages/influxdb/client.py", line 599, in write_points
    consistency=consistency)
  File "/home/pi/.local/lib/python3.7/site-packages/influxdb/client.py", line 676, in _write_points
    protocol=protocol
  File "/home/pi/.local/lib/python3.7/site-packages/influxdb/client.py", line 410, in write
    headers=headers
  File "/home/pi/.local/lib/python3.7/site-packages/influxdb/client.py", line 369, in request
    raise InfluxDBClientError(err_msg, response.status_code)
influxdb.exceptions.InfluxDBClientError: 400: {"error":"partial write: points beyond retention policy dropped=40584"}

Looking briefly at the code it seems that everyday you pull all the data and rewrite the db, is this statement correct?
Would it be possible to have a "incremental" or too much hassle?
Thanks

Hey,
Yeah when i wrote the script the datasources were changing so much that it was easier to just drop and recreate every time than attempt anything incremental.
I've not made any changes to this in quiet some time but if i get a chance ill take a look at adding an Incremental vs drop+Recreate switch to the script.
In terms of your error, partial writes are 'ok' in the sense that its just dropping the points that are past the retention period, probably just needs a try catch in there to allow for the error it returns.
Regards


core.util.WKTParser.fromWKT does not correctly determine holes

AFAICT, the WKTParser in core.util.wkt never constructs polygons with holes, since it never passes a holes keyword argument.
This came up because I've gotten a MultiPolygon parser working (I think) on the examples at the bottom of that file. In testing it, I was correctly parsing the Multipolygon, but the Polygon parser was never correctly determining what was the exterior ring and what was the interior ring.
Page 2-8 of the OGC Simple Features specification says Polygons should be:

1 exterior ring and 0 or more interior boundaries.

And, as far as I can tell, the exterior ring is always be first, with an arbitrary number of holes listed afterwards. I can't find that in the spec.

Relatedly, I'm not sure exactly how we can encode multi-polygons with multiple holes into WKT with our readers/cg model, since we don't record which holes go with which exterior rings.

The following is an edit of the Polygon dataset where holes are added.
One component of the multipolygon has 2 holes, the other has one. Once it's read in, there's no information about which holes are associated with which part.
This means that, when it gets passed to other packages via its geo_interface, the resulting polygon is invalid, since there are holes outside of rings.
MultiPolygon.tar.gz
I think we could solve this by making polygon.holes a list of lists wherepolygon.holes[i] corresponds to polygon.parts[i]. This would mean we could recover the OGC-style exterior ring [, holes] out of zip(polygon.parts, polygon.holes), but I'm concerned about how much that'd adjust the CG architecture.


Number of diagnostics doesn't disappear when deleting plan

The number of diagnostic displayed next to the tool icon doesn't disappear when the plan is deleted. It create an exception if clicked on.
[Enter steps to reproduce:]

Create a plan, run it and delete it;
Click on the number of diagnostics, the exception is thrown.

Atom: 1.18.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.5
Thrown From: molecule-dev-environment package 0.4.0
Stack Trace
Uncaught TypeError: Cannot read property 'remove' of undefined
At /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/react-dom/lib/ReactErrorUtils.js:51

TypeError: Cannot read property 'remove' of undefined
    at areSamePlans (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/lib/ExecutionControlEpic/PlanConfigurationFeature/Model/PlanManipulators.js:10:18)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/lib/ExecutionControlEpic/TaskExecutionFeature/Selectors/Tasks.js:102:21
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:3086:23
    at List.__iterate (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:2208:13)
    at IndexedIterable.filterSequence.__iterateUncached (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:3085:16)
    at seqIterate (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:606:16)
    at IndexedIterable.IndexedSeq.__iterate (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:322:14)
    at IndexedIterable.forEach (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:4383:19)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:2071:14
    at List.Map.withMutations (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:1355:7)
    at new List (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:2069:20)
    at reify (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:3572:37)
    at List.filter (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/immutable/dist/immutable.js:4730:14)
    at selectTasksOfPlan (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/lib/ExecutionControlEpic/TaskExecutionFeature/Selectors/Tasks.js:102:6)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/lib/ExecutionControlEpic/DiagnosticsFeature/Containers/ToolDiagnosticsTraveller.js:123:10
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/withProps.js:19:62
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/mapProps.js:19:22
    at createEagerElementUtil (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/utils/createEagerElementUtil.js:18:12)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/createEagerFactory.js:18:49
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/mapProps.js:19:14
    at createEagerElementUtil (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/utils/createEagerElementUtil.js:18:12)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/createEagerFactory.js:18:49
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/mapProps.js:19:14
    at createEagerElementUtil (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/utils/createEagerElementUtil.js:18:12)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/createEagerFactory.js:18:49
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/mapProps.js:19:14
    at createEagerElementUtil (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/utils/createEagerElementUtil.js:18:12)
    at /Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/createEagerFactory.js:18:49
    at render (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/recompose/lifecycle.js:30:16)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (/Users/gauthier/IdeaProjects/atom-molecule-dev-environment/node_modules/react-dom/lib/ReactCompositeComponent.js:799:30)

Commands

Non-Core Packages
molecule-dev-environment 0.4.0

Fixed ?


mde_installer is selecting ubuntu 18.04 when running on 22.04

see these lines:
https://github.com/microsoft/mdatp-xplat/blob/a2a4164f98da865243ed83739f2c3f3f3267f08c/linux/installation/mde_installer.sh#L716-L717
mdatp is available for ubuntu jammy at https://packages.microsoft.com/ubuntu/22.04/prod/ so the installer script should probably allow 22.04 here instead of falling back to the bionic repo

Seeing same issue. Submitted Pull#48 to resolve.

Hi @pmooo , I see you submitted a PR regarding this issue and it's been merged too. Can I go ahead and close this issue?

@agarwalneetu as requested the pull request

Resolved


Changing opaque type to type alias results in MAJOR bump

module Foo exposing (Foo)

type Foo =
     Foo Int

Gets changed to
module Foo exposing (Foo)

import Internal

type alias Foo =
     Internal.Foo

module Internal exposing (Foo)

type Foo =
     Foo Int

where Internal is not in "exposed-modules". Conceptually, this doesn't change anything for the calling code of this package, as it is still the same type, just it's implementation details changed slightly (but being able to do that was the point of making it opaque in the first place). As such, this should be a PATCH change.
However, elm diff gives:
---- Foo - MAJOR ----

    Added:
        type alias Foo =
            Internal.Foo

    Removed:
        type Foo

Elm: 0.19
Operating System: OSX 10.14.3

Changing the custom type to a type alias essentially exposes a constructor to it, so it makes sense the way it is now. Recusing down the types to figure out if it's possible to actually construct that type alias is probably quite a lot of effort.

Changing the custom type to a type alias essentially exposes a constructor to it

In which case should this be a MINOR change, equivalent to adding a new function?

I don’t believe this is true: the constructor is not exposed in either scenario.


Performance Testing

So I realised that we most definitely do not want to merge this into the mainline in it's current form, if it includes tests for a large number of contracts. It will greatly increase CI time for subsequent commits.
Probably makes sense to just keep separate, and we can reverse-merge to check performance on an ad-hoc basis.
If you agree, maybe consider changing the title just to avoid accidental merge.


Demo Architecture

Text localhost:4318 repeated in diagram "OTel Collector" in this page https://opentelemetry.io/docs/demo/architecture/

Thanks for reporting this @abhishekujjain. Would you like to put up a PR to fix the repetition?

can i work on this issue ?

Hi @Tharanishwaran. Let's give @abhishekujjain a chance to resolve this one first, if they want to. Thanks!

Hi @maryliag . I am interested in fixing this good first issue as an Outreachy contributor, can you grant me permission please

Hi @Blessing-Mba, thanks for your interest! Someone else has already asked to work on this issue, so we'll need to give them a chance first.
Since we haven't heard from @abhishekujjain, I think it's okay for you to fix this issue, @Tharanishwaran, if you're still interested.

I am still interested in fixing this issue @tiffany76

Hi @Blessing-Mba, I see that you already put up a PR to fix this. Thanks for taking the initiative!
For the future, we do recommend that you read through all the comments on an issue before starting work, just to make sure that no one else has claimed the issue before you. @Tharanishwaran, my apologies.

My apologies and this information is duly noted @tiffany76


New package: BenchmarkPlots v0.1.0

Registering package: BenchmarkPlots
Repository: https://github.com/JuliaCI/BenchmarkTools.jl
Created by: @vchuravy
Version: v0.1.0
Commit: 51a918d1e85eff46a793717b1f91150da5098200
Reviewed by: @vchuravy
Reference: https://github.com/JuliaCI/BenchmarkTools.jl/commit/51a918d1e85eff46a793717b1f91150da5098200#commitcomment-53068662

@vchuravy :slightly_smiling_face:
[noblock]