SDK promote method miss annotations

https://github.com/kubeflow/kfserving/blob/8c261457b3ec8017736b882c4ffd3379914471ac/python/kfserving/kfserving/api/kf_serving_client.py#L295-L297

steps:

create isvc by sdk

annotations['autoscaling.knative.dev/target'] = '99'
default_endpoint_spec = V1alpha2EndpointSpec(
            predictor=V1alpha2PredictorSpec(
                custom=V1alpha2CustomSpec(
                    container=V1Container(
                        image=image,
                        name=srv_name,
                        ports=ports,
                        resources=V1ResourceRequirements(
                            requests=res_request,
                            limits = res_limit)))))
isvc = V1alpha2InferenceService(api_version=api_version,
                                    kind=constants.KFSERVING_KIND,
                                    metadata=client.V1ObjectMeta(
                                        name=srv_name, namespace=namespace, annotations=annotations),
                                    spec=V1alpha2InferenceServiceSpec(default=default_endpoint_spec))
KFServing = KFServingClient()
KFServing.create(isvc)

Describe of the isvc's pod, autoscaling.knative.dev/target: 99:
root@k8s-master:custom# kubectl describe pods -n cqs-test-ns resnet-predictor-default-77q75-deployment-849ccc95c-5vv94
Name:           resnet-predictor-default-77q75-deployment-849ccc95c-5vv94
Namespace:      cqs-test-ns
Priority:       0
Node:           k8s-gpu/<IP_ADDRESS>
Start Time:     Mon, 13 Apr 2020 19:45:51 +0800
Labels:         app=resnet-predictor-default-77q75
                pod-template-hash=849ccc95c
                serving.knative.dev/configuration=resnet-predictor-default
                serving.knative.dev/configurationGeneration=1
                serving.knative.dev/revision=resnet-predictor-default-77q75
                serving.knative.dev/revisionUID=f03aeb27-1a14-48bc-bd57-e689be98c961
                serving.knative.dev/service=resnet-predictor-default
                serving.kubeflow.org/inferenceservice=resnet
Annotations:    autoscaling.knative.dev/class: kpa.autoscaling.knative.dev
                autoscaling.knative.dev/target: 99
                cni.projectcalico.org/podIP: <IP_ADDRESS>/32
                queue.sidecar.serving.knative.dev/resourcePercentage: 20
                serving.knative.dev/creator: system:serviceaccount:kfserving-system:default
                traffic.sidecar.istio.io/includeOutboundIPRanges: *
Status:         Running

create canary:

canary_endpoint_spec = V1alpha2EndpointSpec(
            predictor=V1alpha2PredictorSpec(
                custom=V1alpha2CustomSpec(
                    container=V1Container(
                        image=image,
                        name=srv_name,
                        ports=ports,
                        resources=V1ResourceRequirements(
                        requests=res_request,
                        limits=res_limit)))))

  KFServing = KFServingClient()
  KFServing.rollout_canary(srv_name, canary=canary_endpoint_spec, percent=percent,
                             namespace=namespace, watch=False, timeout_seconds=120)

Describe of the canary isvc's pod, autoscaling.knative.dev/target: 99:
root@k8s-master:custom# kubectl describe pods -n cqs-test-ns resnet-predictor-canary-h9l92-deployment-56848f5858-q695g
Name:           resnet-predictor-canary-h9l92-deployment-56848f5858-q695g
Namespace:      cqs-test-ns
Priority:       0
Node:           k8s-gpu/<IP_ADDRESS>
Start Time:     Mon, 13 Apr 2020 19:47:13 +0800
Labels:         app=resnet-predictor-canary-h9l92
                pod-template-hash=56848f5858
                serving.knative.dev/configuration=resnet-predictor-canary
                serving.knative.dev/configurationGeneration=1
                serving.knative.dev/revision=resnet-predictor-canary-h9l92
                serving.knative.dev/revisionUID=de0818f7-0067-4020-9e98-5a8e630ce263
                serving.knative.dev/service=resnet-predictor-canary
                serving.kubeflow.org/inferenceservice=resnet
Annotations:    autoscaling.knative.dev/class: kpa.autoscaling.knative.dev
                autoscaling.knative.dev/target: 99
                cni.projectcalico.org/podIP: <IP_ADDRESS>/32
                queue.sidecar.serving.knative.dev/resourcePercentage: 20
                serving.knative.dev/creator: system:serviceaccount:kfserving-system:default
                traffic.sidecar.istio.io/includeOutboundIPRanges: *
Status:         Running

call promote

KFServing.promote(srv_name, namespace=namespace, watch=False, timeout_seconds=120)

Describe the final pod, autoscaling.knative.dev/target: 1:
root@k8s-master:custom# kubectl describe pods -n cqs-test-ns resnet-predictor-default-47skq-deployment-57f95b754b-4b2tc
Name:           resnet-predictor-default-47skq-deployment-57f95b754b-4b2tc
Namespace:      cqs-test-ns
Priority:       0
Node:           k8s-gpu/<IP_ADDRESS>
Start Time:     Mon, 13 Apr 2020 19:48:30 +0800
Labels:         app=resnet-predictor-default-47skq
                pod-template-hash=57f95b754b
                serving.knative.dev/configuration=resnet-predictor-default
                serving.knative.dev/configurationGeneration=2
                serving.knative.dev/revision=resnet-predictor-default-47skq
                serving.knative.dev/revisionUID=dedd4807-1714-4e2b-8b68-fb6447e921bb
                serving.knative.dev/service=resnet-predictor-default
                serving.kubeflow.org/inferenceservice=resnet
Annotations:    autoscaling.knative.dev/class: kpa.autoscaling.knative.dev
                autoscaling.knative.dev/target: 1
                cni.projectcalico.org/podIP: <IP_ADDRESS>/32
                queue.sidecar.serving.knative.dev/resourcePercentage: 20
                serving.knative.dev/creator: system:serviceaccount:kfserving-system:default
                traffic.sidecar.istio.io/includeOutboundIPRanges: *
Status:         Running

Thanks for the information. So the issue is in fact in the promote api we set name and namespace as metadata only, but in fact the metadata(of V1ObjectMeta type) can contain other information.
Suggest we not only add annotation, but directly use the metadata of current inferenceservice.

Thanks for the information. So the issue is in fact in the promote api we set name and namespace as metadata only, but in fact the metadata(of V1ObjectMeta type) can contain other information.
Suggest we not only add annotation, but also include other information in metadata(better use metadata directly if possible or as most as we can)

Yes, it is better use metadata than  only annotation , I will re-send a PR later.

Thanks for the information. So the issue is in the promote api we set name and namespace as metadata only, but in fact the metadata(of V1ObjectMeta type) can contain other information.
Suggest we not only add annotation, but also include other information in metadata(better use metadata directly if possible or as most as we can)

The PR is failed, because he metadata are different between V1ObjectMeta and current_isvc['metadata'], It is diffcult to initialize the V1ObjectMeta, can you give me any suggestions?


Where is the code for the toolbox module?

The file mod_numerical.f90 has many lines such as
use toolbox, only: sort
Where is the code for this module?

Hi, a few programs use the sort subroutine in Fehr and Kindermann's toolbox which is publicly available here:
I added an explanation in the README

https://github.com/fabiankindermann/ce-fortran/blob/main/installation/toolbox/toolbox.f90

Thanks.


incoming message queue, alreadyHaveEvent check, msg.send catch

Add incoming messages to processing queue and process them on setInterval, so we don't block UI processing
Optional alreadyHaveEvent param to relayInit so you can skip JSON.parse and event callback, if you already have the event in memory
Catch errors in ws.send(msg)
Resolve untilOpen on ws.open

This is so weird, I was looking into adding this exactly this moment, after you told me these tricks more than a week ago.


Optimize pulsar simulator dialog

Codecov Report

Merging #120 (a2cd9a3) into main (7034a16) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #120      +/-   ##
============================================
+ Coverage     23.41%   23.44%   +0.03%
  Complexity      147      147
============================================
  Files            80       80
  Lines          1307     1305       -2
  Branches         72       70       -2
============================================
  Hits            306      306
+ Misses          985      983       -2
  Partials         16       16

Flag
Coverage Δ

unittests
23.44% <0.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...zj/dev/simulator/pulsar/PulsarClientSimulator.java
0.00% <0.00%> (ø)

.../dev/simulator/pulsar/PulsarConsumerSimulator.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7034a16...a2cd9a3. Read the comment docs.


BUG - Service document (at service root) does not contain the available entities

Related Feature
Feature request: no idea
Description
When using the @sap-ux/axios-extension to fetch available OData v2 services, we fetch the service document of the catalog service first to determine which entity set we need to use to get the serviced recommended/available for UI development. While testing it with the mock server we noticed that it is not correctly returning the entities and that it doesn't support the $format=json parameter.
Steps to Reproduce
Steps to reproduce the behavior:

Create a project with any metadata.xml
Call the mocked service root with the url parameter $format=json
See response

Expected results
A JSON document like
{
  "d": {
      "EntitySets": [
      "Annotations",
      "Vocabularies",
      "ServiceCollection",
      "ServiceNames",
      "TagCollection",
      "EntitySetCollection",
      "CatalogCollection",
      "RecommendedServiceCollection",
      "ScopedServiceCollection"
    ]
  }
}

Actual results
<app:service xmlns:app="http://www.w3.org/2007/app" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata" xmlns:sap="http://www.sap.com/Protocols/SAPData" xml:lang="en" xml:base="/sap/opu/odata/IWFND/CATALOGSERVICE;v=2">
  <app:workspace> </app:workspace>
  <atom:link rel="self" href="/sap/opu/odata/IWFND/CATALOGSERVICE;v=2"/>
  <atom:link rel="latest-version" href="/sap/opu/odata/IWFND/CATALOGSERVICE;v=2"/>
</app:service>

Two issues:

workspaces should contain the entity sets
it should be json

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

Do you have a sample V2 service where i could check the result ?

I used the v2 catalog service at /sap/opu/odata/IWFND/CATALOGSERVICE;v=2. You should find it on any ABAP system

This is fixed


Fixed instanceTraffic update problem after enhanced the storage session mechanism.

[x] Explain briefly why the bug exists and how to fix it.

After the session mechanism is enhanced, the older InstanceTraffic data of timeBucket will always be cached in the context.
And because of the logic of combine method in InstanceTraffic, we will continue to use the older timeBucket when updating.
This causes OAP to update InstanceTraffic and report an error after cleaning up the index related to InstanceTraffic that has reached the specified TTL.
Because we have got the start time of the instance in other ways, I don't think we need to save the older timeBucket.

[x] Update the CHANGES log.

Good cache, but we need to discuss how to fix it. If we keep updating the instance, then the instance could be inserted multiple times in the index.

Replaced by #7334


image create should allow for setting data disk skus.

Similar to #4263 but for image create. At the very least, it should allow one to specify what sku setting should be used for the disks in general, if not for individual disk luns.
cc: @yugangw-msft

This requires compute service end change

closing this due to lack of team bandwidth and lack of urgency of the issue


[2.0] Ability to generate/rotate secrets

Something like feathers generate secret which at the very least spits out a new secure secret to copy to your .json config files or .env or something.
Depending on how we want to handle secret rotation and what shakes out of https://github.com/feathersjs/feathers-configuration/issues/24 we might be able to auto-rotate.

related to https://github.com/feathersjs/feathers-authentication/issues/309

Added in the latest generator (feathers-cli@2.0.0-pre), see https://github.com/feathersjs/generator-feathers/pull/163


Detect browser

Inform a user that Chrome is a requirement and other browsers may not function properly

added in https://github.com/pbca26/hw-vote/commit/341f1e56f6f6e3e1fa483753d901b5b45e2fcfd0


[MINOR][DOC]update the condition description of BypassMergeSortShuffl…

…eWriter
What changes were proposed in this pull request?
These three condition description should update, follow #23228  :
no Ordering is specified,
no Aggregator is specified, and
the number of partitions is less than
spark.shuffle.sort.bypassMergeThreshold.

1、If the shuffle dependency specifies aggregation, but it only aggregates at the reduce-side, serialized shuffle can still be used.
2、If the number of output partitions is 16777216 , we can use serialized shuffle.
How was this patch tested?
N/A

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Are there more changes like this? they should be in one PR if they're logically related.

Test build #4463 has started for PR 23281 at commit b0a86db.

Test build #4463 has finished for PR 23281 at commit b0a86db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Are there more changes like this? they should be in one PR if they're logically related.
I agree, but  only found this one

Test build #4465 has started for PR 23281 at commit b0a86db.

Test build #4465 has finished for PR 23281 at commit b0a86db.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

I'm merging to master because the test failure is a known issue in SparkR and this is a doc change that can't have caused it


[Bug]: Exception thrown: 'Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException' in System.Private.CoreLib.dll with version 6.6.x

Describe the bug
Please improve problem reporting.
After upgrading from 6.4.0 to 6.6.2, the swagger.json file was not generated. Downgrading to 6.5.0 fixed the issue. Nor 6.6.1 neither 6.6.2 version worked, however.
The project (ASPNET Core API) was recently upgraded to net8 from net6 (historically it undergone upgrades from 2.2 -> 3.1 -> 6 -> 8)
The SwaggerUI page loads but it shows error:
Failed to load API definition.
Fetch error
response status is 500 /swagger/v1/swagger.json
Browser (Chrome current) shows following error for request https://localhost:44355/swagger/v1/swagger.json
500 Internal Server Error
Something got wrong. Error correlationId: de3b5347-48fd-4bcb-ac52-50675a5e6a96
VS Output shows:
Exception thrown: 'Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException' in System.Private.CoreLib.dll
Before sending this bug report I found out the root cause of the problem. There was used IFormFile with attribute [FromForm]. I was quite lucky to find the problem by removing controllers from the project (there are approx 70 controllers), But the error message really didn't help.
Expected behavior
The swagger file is generated or reasonable error/exception is emitted
Actual behavior
The swagger file fails to generate and Swagger UI shows error 500
Steps to reproduce
add method with signature to a controller:
public async Task<ActionResult> UploadFile([FromRoute] int assessmentId, [FromForm(Name = "file")] IFormFile file)
Exception(s) (if any)
Exception thrown: 'Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException' in System.Private.CoreLib.dll
Swashbuckle.AspNetCore version
6.6.x
.NET Version
8.0.303
Anything else?
No response

Can you provide a stack trace or a minimal repro of the issue?

There was no stack trace, that's the point. No clue, just a single line in VS output window:
'Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException' in System.Private.CoreLib.dll
The repro steps are described - just add a method with the signature described into a controller and it should be reproduced.
Using up to date Visual Studio, net8.
Printing out the full exception with the stack trace is actually all I would like to have for troubleshooting :)

That just seems really weird. What if you configure Visual Studio to break whenever that type of exception is thrown?
I would expect that Visual Studio would normally either break at that point if it's genuinely unhandled, or the developer exception page to show you something.
Plus we have tests for form handling, which is why I asked if there's a more specific repro. If not we can look into it, it just seems odd that there's no way for you to see the exception at all with all with Visual Studio, as it can clearly see enough to tell you there's an exception happening at all.
Stack traces in issues also mean I can guess at what's wrong just from issues on my phone when I'm not at a computer 🙂

I added the following to our existing FromFormParamsController class used in our tests:
[HttpPost("github-issue-2989/{assessmentId}")]
public async Task<ActionResult> GitHubIssue2989([FromRoute] int assessmentId, [FromForm(Name = "file")]  IFormFile file)
{
    await Task.CompletedTask;
    throw new System.NotImplementedException();
}

Running the tests, I get this failure:
    Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException: Failed to generate Operation for action - Basic.Controllers.FromFormParamsController.GitHubIssue2989 (Basic). See inner exception
 ---> Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException: Error reading parameter(s) for action Basic.Controllers.FromFormParamsController.GitHubIssue2989 (Basic) as [FromForm] attribute used with IFormFile. Please refer to https://github.com/domaindrivendev/Swashbuckle.AspNetCore#handle-forms-and-file-uploads for more information
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateParametersAsync(ApiDescription apiDescription, SchemaRepository schemaRespository, Func`3 parameterGenerator) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 512
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateParametersAsync(ApiDescription apiDescription, SchemaRepository schemaRespository) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 550
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperationAsync(ApiDescription apiDescription, SchemaRepository schemaRepository, Func`3 parametersGenerator, Func`3 bodyGenerator, Func`3 applyFilters) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 322
   --- End of inner exception stack trace ---
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperationAsync(ApiDescription apiDescription, SchemaRepository schemaRepository, Func`3 parametersGenerator, Func`3 bodyGenerator, Func`3 applyFilters) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 345
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperationAsync(ApiDescription apiDescription, SchemaRepository schemaRepository) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 373
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperationsAsync(IEnumerable`1 apiDescriptions, SchemaRepository schemaRepository) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 268
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GeneratePathsAsync(IEnumerable`1 apiDescriptions, SchemaRepository schemaRepository, Func`3 operationsGenerator) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 207
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GeneratePathsAsync(IEnumerable`1 apiDescriptions, SchemaRepository schemaRepository) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 229
   at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GetSwaggerAsync(String documentName, String host, String basePath) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 56
   at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider) in C:\Coding\domaindrivendev\Swashbuckle.AspNetCore\src\Swashbuckle.AspNetCore.Swagger\SwaggerMiddleware.cs:line 64
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

I get the same error from 13 failing tests if I add [FromForm(Name = "file")] to this controller method.
If I remove [FromForm(Name = "file")] as the link states, then I get this:
Assert.Empty() Failure: Collection was not empty
Collection: [Declared path parameter "assessmentId" needs to be defined as a path parameter at either the path or operation level [#/paths/~1github-issue-2989/post/parameters/0/in]]

This failure is part of an end-to-end test and the exception is from the HTTP response content, so I can only assume that you have configured your site and/or Visual Studio in some way that obscured the exception from your view. If you fix whatever the reason for that is, you should see the exception in your logs somewhere pointing you to the documentation on how to fix your endpoint.


Add "Java Stdin and Stdout II" in JavaHackerrank Section

Add a perfect solution to the given challenge.
Refer:-https://www.hackerrank.com/domains/java

I will work on this issue


Allow params as a string

To add flexibility (in situations like #48), a param option (string) should be exposed. It should be combined with other existing options like filter or pagination.

Implemented in 4.0.0-beta.4. Request options can receive a params property which can be an array of strings (e.g. ['a=1', 'b=2']) or objects with key and value properties (e.g. [{key: 'a', value: '1'}, {key: 'b', value: '2'}]


Demonstrate JSON file request

Produce notebooks that do the following

[ ] Demonstrate request for JSON files
[ ] Demonstrate "watch data following" -- we want this on the Monitor tab on website

[ ] y-axis: depth, x-axis: time
[ ] automatic refreshing every 5 secs

PR #22 satisfy data request for JSON format.
PR #24 will be able to fulfill "Demonstrate "watch data following" -- we want this on the Monitor tab on website" More development is needed in terms of design for pushing the streaming dataframe via REST API for the front end.

Notebooks to come in demonstrating these capabilities.


[GO_ROUTER] Browser navigation history is incorrectly sorted when using query parameters.

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?

Yes
Dependency versions
pubspec.lock
Generated by pub
See https://dart.dev/tools/pub/glossary#lockfile
packages:
_fe_analyzer_shared:
dependency: transitive
description:
name: _fe_analyzer_shared
sha256: eb376e9acf6938204f90eb3b1f00b578640d3188b4c8a8ec054f9f479af8d051
url: "https://pub.dev"
source: hosted
version: "64.0.0"
analyzer:
dependency: transitive
description:
name: analyzer
sha256: "69f54f967773f6c26c7dcb13e93d7ccee8b17a641689da39e878d5cf13b06893"
url: "https://pub.dev"
source: hosted
version: "6.2.0"
args:
dependency: transitive
description:
name: args
sha256: eef6c46b622e0494a36c5a12d10d77fb4e855501a91c1b9ef9339326e58f0596
url: "https://pub.dev"
source: hosted
version: "2.4.2"
async:
dependency: transitive
description:
name: async
sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
url: "https://pub.dev"
source: hosted
version: "2.11.0"
boolean_selector:
dependency: transitive
description:
name: boolean_selector
sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
build:
dependency: transitive
description:
name: build
sha256: "80184af8b6cb3e5c1c4ec6d8544d27711700bc3e6d2efad04238c7b5290889f0"
url: "https://pub.dev"
source: hosted
version: "2.4.1"
build_config:
dependency: transitive
description:
name: build_config
sha256: bf80fcfb46a29945b423bd9aad884590fb1dc69b330a4d4700cac476af1708d1
url: "https://pub.dev"
source: hosted
version: "1.1.1"
build_daemon:
dependency: transitive
description:
name: build_daemon
sha256: "5f02d73eb2ba16483e693f80bee4f088563a820e47d1027d4cdfe62b5bb43e65"
url: "https://pub.dev"
source: hosted
version: "4.0.0"
build_resolvers:
dependency: transitive
description:
name: build_resolvers
sha256: d912852cce27c9e80a93603db721c267716894462e7033165178b91138587972
url: "https://pub.dev"
source: hosted
version: "2.3.2"
build_runner:
dependency: "direct dev"
description:
name: build_runner
sha256: "10c6bcdbf9d049a0b666702cf1cee4ddfdc38f02a19d35ae392863b47519848b"
url: "https://pub.dev"
source: hosted
version: "2.4.6"
build_runner_core:
dependency: transitive
description:
name: build_runner_core
sha256: "6d6ee4276b1c5f34f21fdf39425202712d2be82019983d52f351c94aafbc2c41"
url: "https://pub.dev"
source: hosted
version: "7.2.10"
built_collection:
dependency: transitive
description:
name: built_collection
sha256: "376e3dd27b51ea877c28d525560790aee2e6fbb5f20e2f85d5081027d94e2100"
url: "https://pub.dev"
source: hosted
version: "5.1.1"
built_value:
dependency: transitive
description:
name: built_value
sha256: ff627b645b28fb8bdb69e645f910c2458fd6b65f6585c3a53e0626024897dedf
url: "https://pub.dev"
source: hosted
version: "8.6.2"
characters:
dependency: transitive
description:
name: characters
sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
url: "https://pub.dev"
source: hosted
version: "1.3.0"
charcode:
dependency: transitive
description:
name: charcode
sha256: fb98c0f6d12c920a02ee2d998da788bca066ca5f148492b7085ee23372b12306
url: "https://pub.dev"
source: hosted
version: "1.3.1"
checked_yaml:
dependency: transitive
description:
name: checked_yaml
sha256: feb6bed21949061731a7a75fc5d2aa727cf160b91af9a3e464c5e3a32e28b5ff
url: "https://pub.dev"
source: hosted
version: "2.0.3"
clock:
dependency: transitive
description:
name: clock
sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
url: "https://pub.dev"
source: hosted
version: "1.1.1"
code_builder:
dependency: transitive
description:
name: code_builder
sha256: "315a598c7fbe77f22de1c9da7cfd6fd21816312f16ffa124453b4fc679e540f1"
url: "https://pub.dev"
source: hosted
version: "4.6.0"
collection:
dependency: transitive
description:
name: collection
sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
url: "https://pub.dev"
source: hosted
version: "1.17.2"
convert:
dependency: transitive
description:
name: convert
sha256: "0f08b14755d163f6e2134cb58222dd25ea2a2ee8a195e53983d57c075324d592"
url: "https://pub.dev"
source: hosted
version: "3.1.1"
crypto:
dependency: transitive
description:
name: crypto
sha256: ff625774173754681d66daaf4a448684fb04b78f902da9cb3d308c19cc5e8bab
url: "https://pub.dev"
source: hosted
version: "3.0.3"
csslib:
dependency: transitive
description:
name: csslib
sha256: "706b5707578e0c1b4b7550f64078f0a0f19dec3f50a178ffae7006b0a9ca58fb"
url: "https://pub.dev"
source: hosted
version: "1.0.0"
dart_style:
dependency: transitive
description:
name: dart_style
sha256: abd7625e16f51f554ea244d090292945ec4d4be7bfbaf2ec8cccea568919d334
url: "https://pub.dev"
source: hosted
version: "2.3.3"
fake_async:
dependency: transitive
description:
name: fake_async
sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
url: "https://pub.dev"
source: hosted
version: "1.3.1"
ffi:
dependency: transitive
description:
name: ffi
sha256: "7bf0adc28a23d395f19f3f1eb21dd7cfd1dd9f8e1c50051c069122e6853bc878"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
file:
dependency: transitive
description:
name: file
sha256: "5fc22d7c25582e38ad9a8515372cd9a93834027aacf1801cf01164dac0ffa08c"
url: "https://pub.dev"
source: hosted
version: "7.0.0"
fixnum:
dependency: transitive
description:
name: fixnum
sha256: "25517a4deb0c03aa0f32fd12db525856438902d9c16536311e76cdc57b31d7d1"
url: "https://pub.dev"
source: hosted
version: "1.1.0"
flutter:
dependency: "direct main"
description: flutter
source: sdk
version: "0.0.0"
flutter_lints:
dependency: "direct dev"
description:
name: flutter_lints
sha256: a25a15ebbdfc33ab1cd26c63a6ee519df92338a9c10f122adda92938253bef04
url: "https://pub.dev"
source: hosted
version: "2.0.3"
flutter_secure_storage:
dependency: "direct main"
description:
name: flutter_secure_storage
sha256: ffdbb60130e4665d2af814a0267c481bcf522c41ae2e43caf69fa0146876d685
url: "https://pub.dev"
source: hosted
version: "9.0.0"
flutter_secure_storage_linux:
dependency: transitive
description:
name: flutter_secure_storage_linux
sha256: "3d5032e314774ee0e1a7d0a9f5e2793486f0dff2dd9ef5a23f4e3fb2a0ae6a9e"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
flutter_secure_storage_macos:
dependency: transitive
description:
name: flutter_secure_storage_macos
sha256: bd33935b4b628abd0b86c8ca20655c5b36275c3a3f5194769a7b3f37c905369c
url: "https://pub.dev"
source: hosted
version: "3.0.1"
flutter_secure_storage_platform_interface:
dependency: transitive
description:
name: flutter_secure_storage_platform_interface
sha256: "0d4d3a5dd4db28c96ae414d7ba3b8422fd735a8255642774803b2532c9a61d7e"
url: "https://pub.dev"
source: hosted
version: "1.0.2"
flutter_secure_storage_web:
dependency: transitive
description:
name: flutter_secure_storage_web
sha256: "30f84f102df9dcdaa2241866a958c2ec976902ebdaa8883fbfe525f1f2f3cf20"
url: "https://pub.dev"
source: hosted
version: "1.1.2"
flutter_secure_storage_windows:
dependency: transitive
description:
name: flutter_secure_storage_windows
sha256: "5809c66f9dd3b4b93b0a6e2e8561539405322ee767ac2f64d084e2ab5429d108"
url: "https://pub.dev"
source: hosted
version: "3.0.0"
flutter_test:
dependency: "direct dev"
description: flutter
source: sdk
version: "0.0.0"
flutter_web_plugins:
dependency: "direct main"
description: flutter
source: sdk
version: "0.0.0"
frontend_server_client:
dependency: transitive
description:
name: frontend_server_client
sha256: "408e3ca148b31c20282ad6f37ebfa6f4bdc8fede5b74bc2f08d9d92b55db3612"
url: "https://pub.dev"
source: hosted
version: "3.2.0"
get_it:
dependency: "direct main"
description:
name: get_it
sha256: f79870884de16d689cf9a7d15eedf31ed61d750e813c538a6efb92660fea83c3
url: "https://pub.dev"
source: hosted
version: "7.6.4"
glob:
dependency: transitive
description:
name: glob
sha256: "0e7014b3b7d4dac1ca4d6114f82bf1782ee86745b9b42a92c9289c23d8a0ab63"
url: "https://pub.dev"
source: hosted
version: "2.1.2"
go_router:
dependency: "direct main"
description:
name: go_router
sha256: "5668e6d3dbcb2d0dfa25f7567554b88c57e1e3f3c440b672b24d4a9477017d5b"
url: "https://pub.dev"
source: hosted
version: "10.1.2"
graphs:
dependency: transitive
description:
name: graphs
sha256: aedc5a15e78fc65a6e23bcd927f24c64dd995062bcd1ca6eda65a3cff92a4d19
url: "https://pub.dev"
source: hosted
version: "2.3.1"
html:
dependency: transitive
description:
name: html
sha256: "3a7812d5bcd2894edf53dfaf8cd640876cf6cef50a8f238745c8b8120ea74d3a"
url: "https://pub.dev"
source: hosted
version: "0.15.4"
http_multi_server:
dependency: transitive
description:
name: http_multi_server
sha256: "97486f20f9c2f7be8f514851703d0119c3596d14ea63227af6f7a481ef2b2f8b"
url: "https://pub.dev"
source: hosted
version: "3.2.1"
http_parser:
dependency: transitive
description:
name: http_parser
sha256: "2aa08ce0341cc9b354a498388e30986515406668dbcc4f7c950c3e715496693b"
url: "https://pub.dev"
source: hosted
version: "4.0.2"
injectable:
dependency: "direct main"
description:
name: injectable
sha256: "5217c45fec809286a7b1b4fbcbd70aab1662bf18d9eb207490df421323f7883f"
url: "https://pub.dev"
source: hosted
version: "2.3.0"
injectable_generator:
dependency: "direct dev"
description:
name: injectable_generator
sha256: "5c21787f854dfb94c9e50c43788f93232867ad80ada38a6db81e0bbb51ee5905"
url: "https://pub.dev"
source: hosted
version: "2.4.0"
io:
dependency: transitive
description:
name: io
sha256: "2ec25704aba361659e10e3e5f5d672068d332fc8ac516421d483a11e5cbd061e"
url: "https://pub.dev"
source: hosted
version: "1.0.4"
js:
dependency: transitive
description:
name: js
sha256: f2c445dce49627136094980615a031419f7f3eb393237e4ecd97ac15dea343f3
url: "https://pub.dev"
source: hosted
version: "0.6.7"
json_annotation:
dependency: transitive
description:
name: json_annotation
sha256: b10a7b2ff83d83c777edba3c6a0f97045ddadd56c944e1a23a3fdf43a1bf4467
url: "https://pub.dev"
source: hosted
version: "4.8.1"
lints:
dependency: transitive
description:
name: lints
sha256: "0a217c6c989d21039f1498c3ed9f3ed71b354e69873f13a8dfc3c9fe76f1b452"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
logging:
dependency: transitive
description:
name: logging
sha256: "623a88c9594aa774443aa3eb2d41807a48486b5613e67599fb4c41c0ad47c340"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
matcher:
dependency: transitive
description:
name: matcher
sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
url: "https://pub.dev"
source: hosted
version: "0.12.16"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
url: "https://pub.dev"
source: hosted
version: "0.5.0"
meta:
dependency: transitive
description:
name: meta
sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
url: "https://pub.dev"
source: hosted
version: "1.9.1"
mime:
dependency: transitive
description:
name: mime
sha256: e4ff8e8564c03f255408decd16e7899da1733852a9110a58fe6d1b817684a63e
url: "https://pub.dev"
source: hosted
version: "1.0.4"
package_config:
dependency: transitive
description:
name: package_config
sha256: "1c5b77ccc91e4823a5af61ee74e6b972db1ef98c2ff5a18d3161c982a55448bd"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
path:
dependency: transitive
description:
name: path
sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
url: "https://pub.dev"
source: hosted
version: "1.8.3"
path_provider:
dependency: transitive
description:
name: path_provider
sha256: a1aa8aaa2542a6bc57e381f132af822420216c80d4781f7aa085ca3229208aaa
url: "https://pub.dev"
source: hosted
version: "2.1.1"
path_provider_android:
dependency: transitive
description:
name: path_provider_android
sha256: "6b8b19bd80da4f11ce91b2d1fb931f3006911477cec227cce23d3253d80df3f1"
url: "https://pub.dev"
source: hosted
version: "2.2.0"
path_provider_foundation:
dependency: transitive
description:
name: path_provider_foundation
sha256: "19314d595120f82aca0ba62787d58dde2cc6b5df7d2f0daf72489e38d1b57f2d"
url: "https://pub.dev"
source: hosted
version: "2.3.1"
path_provider_linux:
dependency: transitive
description:
name: path_provider_linux
sha256: f7a1fe3a634fe7734c8d3f2766ad746ae2a2884abe22e241a8b301bf5cac3279
url: "https://pub.dev"
source: hosted
version: "2.2.1"
path_provider_platform_interface:
dependency: transitive
description:
name: path_provider_platform_interface
sha256: "94b1e0dd80970c1ce43d5d4e050a9918fce4f4a775e6142424c30a29a363265c"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
path_provider_windows:
dependency: transitive
description:
name: path_provider_windows
sha256: "8bc9f22eee8690981c22aa7fc602f5c85b497a6fb2ceb35ee5a5e5ed85ad8170"
url: "https://pub.dev"
source: hosted
version: "2.2.1"
platform:
dependency: transitive
description:
name: platform
sha256: ae68c7bfcd7383af3629daafb32fb4e8681c7154428da4febcff06200585f102
url: "https://pub.dev"
source: hosted
version: "3.1.2"
plugin_platform_interface:
dependency: transitive
description:
name: plugin_platform_interface
sha256: da3fdfeccc4d4ff2da8f8c556704c08f912542c5fb3cf2233ed75372384a034d
url: "https://pub.dev"
source: hosted
version: "2.1.6"
pool:
dependency: transitive
description:
name: pool
sha256: "20fe868b6314b322ea036ba325e6fc0711a22948856475e2c2b6306e8ab39c2a"
url: "https://pub.dev"
source: hosted
version: "1.5.1"
pub_semver:
dependency: transitive
description:
name: pub_semver
sha256: "40d3ab1bbd474c4c2328c91e3a7df8c6dd629b79ece4c4bd04bee496a224fb0c"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
pubspec_parse:
dependency: transitive
description:
name: pubspec_parse
sha256: c63b2876e58e194e4b0828fcb080ad0e06d051cb607a6be51a9e084f47cb9367
url: "https://pub.dev"
source: hosted
version: "1.2.3"
recase:
dependency: transitive
description:
name: recase
sha256: e4eb4ec2dcdee52dcf99cb4ceabaffc631d7424ee55e56f280bc039737f89213
url: "https://pub.dev"
source: hosted
version: "4.1.0"
shelf:
dependency: transitive
description:
name: shelf
sha256: ad29c505aee705f41a4d8963641f91ac4cee3c8fad5947e033390a7bd8180fa4
url: "https://pub.dev"
source: hosted
version: "1.4.1"
shelf_web_socket:
dependency: transitive
description:
name: shelf_web_socket
sha256: "9ca081be41c60190ebcb4766b2486a7d50261db7bd0f5d9615f2d653637a84c1"
url: "https://pub.dev"
source: hosted
version: "1.0.4"
sky_engine:
dependency: transitive
description: flutter
source: sdk
version: "0.0.99"
source_gen:
dependency: transitive
description:
name: source_gen
sha256: fc0da689e5302edb6177fdd964efcb7f58912f43c28c2047a808f5bfff643d16
url: "https://pub.dev"
source: hosted
version: "1.4.0"
source_span:
dependency: transitive
description:
name: source_span
sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
url: "https://pub.dev"
source: hosted
version: "1.10.0"
stack_trace:
dependency: transitive
description:
name: stack_trace
sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
url: "https://pub.dev"
source: hosted
version: "1.11.0"
stream_channel:
dependency: transitive
description:
name: stream_channel
sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
stream_transform:
dependency: transitive
description:
name: stream_transform
sha256: "14a00e794c7c11aa145a170587321aedce29769c08d7f58b1d141da75e3b1c6f"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
string_scanner:
dependency: transitive
description:
name: string_scanner
sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
term_glyph:
dependency: transitive
description:
name: term_glyph
sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
url: "https://pub.dev"
source: hosted
version: "1.2.1"
test_api:
dependency: transitive
description:
name: test_api
sha256: "75760ffd7786fffdfb9597c35c5b27eaeec82be8edfb6d71d32651128ed7aab8"
url: "https://pub.dev"
source: hosted
version: "0.6.0"
timing:
dependency: transitive
description:
name: timing
sha256: "70a3b636575d4163c477e6de42f247a23b315ae20e86442bebe32d3cabf61c32"
url: "https://pub.dev"
source: hosted
version: "1.0.1"
typed_data:
dependency: transitive
description:
name: typed_data
sha256: facc8d6582f16042dd49f2463ff1bd6e2c9ef9f3d5da3d9b087e244a7b564b3c
url: "https://pub.dev"
source: hosted
version: "1.3.2"
universal_html:
dependency: "direct main"
description:
name: universal_html
sha256: "56536254004e24d9d8cfdb7dbbf09b74cf8df96729f38a2f5c238163e3d58971"
url: "https://pub.dev"
source: hosted
version: "2.2.4"
universal_io:
dependency: transitive
description:
name: universal_io
sha256: "1722b2dcc462b4b2f3ee7d188dad008b6eb4c40bbd03a3de451d82c78bba9aad"
url: "https://pub.dev"
source: hosted
version: "2.2.2"
vector_math:
dependency: transitive
description:
name: vector_math
sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
watcher:
dependency: transitive
description:
name: watcher
sha256: "3d2ad6751b3c16cf07c7fca317a1413b3f26530319181b37e3b9039b84fc01d8"
url: "https://pub.dev"
source: hosted
version: "1.1.0"
web:
dependency: transitive
description:
name: web
sha256: dc8ccd225a2005c1be616fe02951e2e342092edf968cf0844220383757ef8f10
url: "https://pub.dev"
source: hosted
version: "0.1.4-beta"
web_socket_channel:
dependency: transitive
description:
name: web_socket_channel
sha256: d88238e5eac9a42bb43ca4e721edba3c08c6354d4a53063afaa568516217621b
url: "https://pub.dev"
source: hosted
version: "2.4.0"
win32:
dependency: transitive
description:
name: win32
sha256: "9e82a402b7f3d518fb9c02d0e9ae45952df31b9bf34d77baf19da2de03fc2aaa"
url: "https://pub.dev"
source: hosted
version: "5.0.7"
xdg_directories:
dependency: transitive
description:
name: xdg_directories
sha256: "589ada45ba9e39405c198fe34eb0f607cddb2108527e658136120892beac46d2"
url: "https://pub.dev"
source: hosted
version: "1.0.3"
yaml:
dependency: transitive
description:
name: yaml
sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5"
url: "https://pub.dev"
source: hosted
version: "3.1.2"
sdks:
dart: ">=3.1.1 <4.0.0"
flutter: ">=3.7.0"

Steps to reproduce
As shown in the video

Press login
Press login(GO TO OTP)
Press browser backbutton to go back to login
Press browser backbutton to go back to screen1. Expect it doesent let you go there because as shown in the video the history is incorrect order when navigating with queryParams.

Expected results
I expect the backbutton to work in all cases.
Actual results
Backbutton is not working when going to login -> otp -> login as shown in the video
Code sample
Code sample
Entire code needed to reproduce issue
https://pastebin.com/rFv6A71H

Screenshots or Videos

Screenshots / Video demonstration
VIDEO
https://github.com/flutter/flutter/assets/36403567/4a59501b-cbec-4cc8-b7c8-ca93df3d94ba

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.3, on macOS 13.5.2 22G91 darwin-arm64, locale en-FI)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc3)
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ✗ Unable to get list of installed Simulator runtimes.
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
[✓] VS Code (version 1.81.1)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

I sincerely hope this gets markes as something that is instantly fixes since this literally disallows the users from navigating out of the screen

Hi @patrikheinonen. Thanks for filing this. This seems to be similar to https://github.com/flutter/flutter/issues/115353. Can you confirm it is??

I realized I only mentioned the queryParams only in the title sorry about that.

I researched further and app bar backbutton still works correctly so can someone just delete that file that messes up the web history.

I researched further and app bar backbutton still works correctly so can someone just delete that file that messes up the web history.

Hi @patrikheinonen. Not sure I fully understand this. By app bar back button, do you mean adding an in app backbutton to the login screen works fine? Also, are you able to identify the file that messes the web history, if yes, can you share?
Thank you

Hi @dam-ease  I mean the app bars backbutton works fine but the browser back button doesent. Ill show you an example video.
As you can see in the end of the video navigating back with browser back buttons is not working from login to screen1.
https://github.com/flutter/flutter/assets/36403567/71bfaf5b-f0d5-40aa-946e-3e2e04e9f403

I need this fixed fast im building a huge web app :sweatsmile: if someone has some workaround that would be appreciated

I see can temporary work around this by using pushNamed instead of goNamed for navigating to Login page for instance:
GestureDetector(
  onTap: () {
    context.pushNamed(
      'login',
      queryParameters: <String, String>{'next': '/screen1'},
    );
  },
  child: const Text(
    'LOGIN',
  ),

Demo
https://github.com/flutter/flutter/assets/104349824/e6fd2639-b0a0-45dd-98f1-58bc8b4d6763

But there will be no synchronization between the browser stack and the app stack if the user uses both navigation button at the same time. This makes me think of https://github.com/flutter/flutter/issues/108114 which might allow you to disable the browser stack, which seems suitable for your situation.

@huycozy That doesent fix the issue that you cant navigate back with the browsers backbutton tho does it?

So what I have to do now is to store the queryParams inside a database...

Perhaps you can use state management for the workaround as well.
Reproduced this issue on Web. When removing queryParameters, the issue doesn't appear.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.13.5, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.13.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12fccda598 (31 hours ago), 2023-09-19 13:56:11 -0700
    • Engine revision bd986c5ed2
    • Dart version 3.1.2
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 117.0.5938.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.14.0-14.0.pre.432, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.14.0-14.0.pre.432 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 68d5c1760b (50 minutes ago), 2023-09-21 22:14:19 -0400
    • Engine revision e726798410
    • Dart version 3.2.0 (build 3.2.0-187.0.dev)
    • DevTools version 2.28.0-dev.12
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 117.0.5938.62

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Please move to fixing

this does look bad. @hangyujin can you take a look at this one?

Any update on this issue?

I think it's because the query parameters contains '/'

I had to downgrade my Flutter SDK to v3.10.6 (with GoRouter v1.11.1) and it started working fine. This is blocker for using the latest Flutter SDK for my project.

@yjbanov Can you please check this ^

Can we get an update on this issue? I can confirm GoRouter works fine with path params but fails in browser history with switch to query params.
Path params is a valid workaround but is limiting

Is there any update regarding this issue ^?


Add Arrays.constantTimeAreEquals(char[], char[])

Arrays contains various methods to compare two arrays in constant time.
This PR adds a method to compare char arrays.

Thanks for the patch, merged. Will show up in 172b01 (hopefully in a couple of days).


Put the settings scrollbar back

I screwed up when fixing the roles screen so this is rather important...

panik


Use canImport(UIKit)/canImport(AppKit) instead of os(iOS)/os(macOS)

I think this would be useful for supporting other Apple platforms such as tvOS and visionOS. However, this would require Swift 4.1, so you probably need to add swiftLanguageVersions: [.v4_2] to Package.swift. I was going to make a PR but I didn't know if you actually want to support other platforms (since builds would be broken due to missing SDK features).

Good idea:
https://github.com/migueldeicaza/SwiftTerm/pull/321

tvOS and visionOS should work now.


select() again in wait_event() if interrupted by sigwinch

The current behaviour breaks code that polls for events like this (Such as demo/keyboard.c):
while (tb_poll_event(&ev) == TB_OK) {
        switch (ev.type) {
        ...
        }
}

select() is interrupted by the SIGWINCH handler and returns EINTR, which causes termbox to return the error value TB_ERR_SELECT. This change will make it retry select()-ing again if it was interrupted, allowing the above code to work properly.
A workaround is to poll as follows:
for (;;) {
    switch ((tb_poll_event(&event))) {
    case TB_OK:
        break;
    case TB_ERR_SELECT:
        continue;
    default:
        return;
    }

   switch (event.type) {
      ...
   }

Hi @git-bruh, thank you for the contributions.
My concern with loop-retrying on EINTR is that it may potentially ignore a signal genuinely intended to interrupt the program. It looks like this probably can't happen on glibc as we are only installing a handler for SIGWINCH and glibc's select wrapper restarts if the underlying syscall returns ERESTARTNOHAND when there is no default handler (e.g., SIGCHLD, SIGURG). However this mechanism may not exist on other systems. I'm not sure.
That said I agree it feels broken to return an error code since we expect SIGWINCH on resize events. What do you think about retrying once upon encountering EINTR?

@adsr Can you elaborate on "may potentially ignore a signal genuinely intended to interrupt the program." ? Doesn't EINTR mean that select() was cancelled to execute a signal handler?
Retrying once seems fine too, but not sure if it would be as "robust". Also this PR ignores EAGAIN. Is it appropriate to return an error in that case and indicate failure to the caller? continue in case of EAGAIN would be bad since it could result in infinite loop.

@adsr Can you elaborate on "may potentially ignore a signal genuinely intended to interrupt the program." ? Doesn't EINTR mean that select() was cancelled to execute a signal handler?

Imagine a case in which an application installs a signal handler for SIGINT and sets a flag done = 1. If we swallow all EINTR in wait_event instead of returning control to the application, the application will not be able to handle the done == 1 case until we can return an event, which may be never.
I think I have a simple solution here. I don't know why I didn't think of this yesterday. I think we can safely swallow EINTR if we know that it was our signal handler that just ran:
https://gist.github.com/adsr/0e670edf4e5a29e92d010a865c1f5b25
For some TDD, you can try running the test included in that diff without the rest of the patch and you'll see it will fail with TB_ERR_SELECT as you described.

maybe the best option is to return -1 to the caller and document that he should check errno in context of select() ?

Documented TB_ERR_SELECT return code of tb_peek/poll_event as suggested.


Native bar chart styling

todo

[x] When the section number is correctly adjusted, the widget's pull request should be updated with the section number.
[x] Merge only when widget is released.

This is ready to go :)

This PR targeted a few docs which were affected by the Mx9 migration. Therefore Isa opened a new PR with the same changes: https://github.com/mendix/docs/pull/2987
It has been merged, so this PR can be closed.

This PR targeted a few docs which were affected by the Mx9 migration. Therefore Isa opened a new PR with the same changes: https://github.com/mendix/docs/pull/2987
It has been merged, so this PR can be closed.


Add sharing selected target view and slide in / out animation

About

Add sharing selected target view
Add slide in / out animation

Note

remove the mocked entry button later

Codecov Report

Merging #31 into v5.2 will decrease coverage by 1.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             v5.2      #31      +/-   ##
==========================================
- Coverage   80.57%   79.52%   -1.06%
==========================================
  Files         163      164       +1
  Lines        6385     6470      +85
==========================================
  Hits         5145     5145
- Misses       1240     1325      +85

Impacted Files
Coverage Δ

LineSDK/LineSDK/SharingUI/SelectedTargetView.swift
0% <0%> (ø)

...ineSDK/LineSDK/SharingUI/ShareViewController.swift
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d50086...298e624. Read the comment docs.


uv building of casadi fails

When trying to build casadi with uv the build fails with:
CMake Error at swig/python/CMakeLists.txt:32 (file):
  file STRINGS file
  "/home/andiradulescu/.cache/uv/builds-v0/.tmpJ6W54S/include/patchlevel.h"
  cannot be read.
Call Stack (most recent call first):
  swig/python/CMakeLists.txt:62 (CasadiGetPythonVersionMajor)

This is because /home/andiradulescu/.cache/uv/builds-v0/.tmpJ6W54S/ folder doesn't seem to exist:
ls: cannot access '/home/andiradulescu/.cache/uv/builds-v0/.tmpJ6W54S/': No such file or directory

CasADi uses this in it's setup.py:
'-DPYTHON_INCLUDE_DIR=' + self.include_dirs[0],

Debugging this further, self.include_dirs has (for uv pip install):
[
'/home/andiradulescu/.cache/uv/builds-v0/.tmpaqg9V9/include',
'/home/andiradulescu/.pyenv/versions/3.12.4/include/python3.12'
]

Where pip install - that builds successfully has:
[
'/home/andiradulescu/.pyenv/versions/3.12.4/include/python3.12'
]

I tested all of this by:

downloading the latest casadi source files, so that I can also be able to add logs
creating a venv - uv venv
running either uv pip install --verbose . or pip install --verbose .

This is because /home/andiradulescu/.cache/uv/builds-v0/.tmpJ6W54S/ folder doesn't seem to exist:

This may be a red herring. That directory is cleaned up and deleted when the program exits, so it won't exist after the failure.
Does the package install successfully with pip install --use-pep517?

Does the package install successfully with pip install --use-pep517?

Yes, builds fine. Doesn't seem to be a difference.

Also, trying to list the contents of self.include_dirs[0] in casadi setup.py build_extension, while using uv pip install still complains it doesn't exist:
error: [Errno 2] No such file or directory: '/Users/andiradulescu/Library/Caches/uv/builds-v0/.tmpYVB1tp/include'

The temporary directory changes every time though -- how would you be checking if it exists?

For what it's worth, python -m build also fails with the same error. That suggests to me that it's a bug in the package, though not sure what.

CMake-based packages should use scikit-build-core, not setuptools. :) I'd say '-DPYTHON_INCLUDE_DIR=' + self.include_dirs[0], is invalid, there's no guarantee in setuptools that the first include dir will be the Python include dir. sysconfig.get_path("include") is the correct way to get the Python include dir.

🙇  Thank you. Any idea why the build directory is present in uv and build but not pip? That part is a mystery to me.

I would have thought it would be present if any packages used the wheel include folder. Maybe it's created no matter what in build/uv and only created if needed in pip? Adding pybind11-global is a way to get a package that using the include wheel folder for testing. Is the folder empty?

The temporary directory changes every time though -- how would you be checking if it exists?

In setup.py, in def build_extension(self, ext): I do a os.listdir() e.g.
cmake_args = [
    ...
    '-DPYTHON_INCLUDE_DIR=' + self.include_dirs[0],
    ...
]
logger.info(os.listdir(self.include_dirs[0]))
logger.info(os.listdir(os.path.dirname(self.include_dirs[0])))

CMake-based packages should use scikit-build-core, not setuptools. :) I'd say '-DPYTHON_INCLUDE_DIR=' + self.include_dirs[0], is invalid, there's no guarantee in setuptools that the first include dir will be the Python include dir. sysconfig.get_path("include") is the correct way to get the Python include dir.

This sounds much better than self.include_dirs[0]. Thanks @henryiii! Will try this out.

I would have thought it would be present if any packages used the wheel "includes" folder. Maybe it's created no matter what in build/uv and only created if needed in pip? Adding pybind11-global is a way to get a package that using the includes wheel folder for testing. Is the folder empty?

The include dir in the tmp folder does not exit. These are the folders in the tmp dir, at running time:
bin
get_requires_for_build_wheel.txt
pyvenv.cfg
CACHEDIR.TAG
.gitignore
lib

I think uv's behavior is correct, so gonna close.

Thanks for the help!
For me it still doesn’t make sense why there is a non-existent “include” dir there, but in ‘pip’ isn’t, as you also said.
I would like to investigate this whole issue myself. Any pointers where this dir is injected?
As for casadi I will try to implement the correct approach suggested earlier.
Again, thanks!


How to trigger animations on click event using Graph (GUI editor)?

Lets say I have various takes in an animation or I've multiple @scene animations on different nodes of a model.
Using Graph (GUI), lets say I've placed multiple choice component (radio button) and I want to trigger each of these animations based on the choice of the options.
How can I do this using Graph (GUI) ?

@jagenjo I think this would only set the value of the variable take. But how do I trigger the animation and its take?
I noticed that LS.PlayAnimation.play method plays animation but getAnimation and getTake gets the animation and its takes respectively.
Hence, please show using the Graph GUI:
How we can execute the play a selected take of an animation?
How can we trigger another function on start_animation and end_animation events?


Suggest for elements of remote.extensionKind would be helpful

From @alexr00
After typing the following in settings, it would be nice to put my cursor inside the { and trigger suggest to get suggestions for the extension ID based on the extensions I currently have installed.

Suggestions with installed extensions is shown as follows:

@alexr00 Please confirm if this is what your recommendation is too?

That is exactly what I was thinking. Thanks!


Trouble playback on Iphone

Hello,
On safari Iphone, I am testing on Iphone 6s or with simulator 6s/6s plus, VAST and VPAID can not be played, when remote debug using safari develop extension, I dont see any error in console log. Video cannot start playback too, with black screen, no play button available.
On Demo videojs-vast-vpaid site, I can see video can play well, even when ads cannot.
Since I got no error log, I dont know how to provide detail information, can you provide some step to debug?
Thanks,

Hi @whatvn please provide us with the VAST tag (url) or VAST XML so we can try to debug.
When you play the video you should see some requests in the network tab, one of them if you click should show you some VAST XML.
<VAST version="2.0">
    <Ad>
        ...
    </Ad>
</VAST>

@Fetz I use the same VAST tag as your demo: http://servedby.flashtalking.com/imp/1/31714;812030;208;xml;DailyMail;640x360VASTHTML5/?cachebuster=%�CHEBUSTER%%
On Chrome desktop, firefox and safari desktop it's ok, but not on Iphone.

I'm testing in iPhone Simulator (the iPhone 6s IOS 9.2)  and in a real iPhone device (6plus IOS 9.2) and both that  VAST tag and the VPAID Html5 Innovid test tag are working.
Do you have ad blocker on?
Did you press update button after you change the selectbox?

No, I dont have adblocker.
As I said, when testing on videojs-vast-vpaid demo page, ads and video worked, but when I use it with videojs on my implementable, it only works on desktop browser, not on Iphone safari (and chrome).
The demo site works fine. Do you have any method to debug in this situation, I aslo catch adError event but did not get any error log.
The video is freeze as well.

Oh sorry now I get it.
First check if you are using the same version of videojs we are using in the demo.
In the browser console:
> videojs.VERSION
< "4.12.15"

If it is, then sadly you have to do manual debugging... Would be cool to get some feedback so we can improve the debugging of the plugin

Sorry this's problem I forget to talk about, I use videojs v5, which is the branch @wmcmurray has forked. Maybe that's the problem.
The strange thing is, there's no error at all, so I cannot know how to start debugging...

can you try the new 5x branch #126 ?

the 5x branch has now been merged into master

@whatvn you can check the demo here: http://mailonline.github.io/videojs-vast-vpaid/index_5.html.
If still have issue with iphone please reopen the issue


ARROW-6677: [FlightRPC][C++] Document Flight in C++

Adds StatusDetail to the docs
Fixes the Doxygen config to work with ARROW_FLIGHT_EXPORT
Adds error codes to the format docs (though they're not part of the formal format)
Touches up some docstrings and adds missing classes to the API docs
Add a basic description of how to set up a Flight server/client in C++

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b780c56). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5491   +/-   ##
=========================================
  Coverage          ?   89.23%
=========================================
  Files             ?      768
  Lines             ?   112435
  Branches          ?        0
=========================================
  Hits              ?   100328
  Misses            ?    12107
  Partials          ?        0

Impacted Files
Coverage Δ

cpp/src/arrow/status.h
93.54% <ø> (ø)

cpp/src/arrow/flight/types.h
100% <ø> (ø)

cpp/src/arrow/flight/server.h
100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b780c56...df8dc13. Read the comment docs.

Rebased and fixed conflict.

Triggered a build on my Travis-CI account: https://travis-ci.org/pitrou/arrow/builds/589333559
Will merge when green.

C++ and docs build green at https://ci.appveyor.com/project/pitrou/arrow/builds/27651743 and https://travis-ci.org/pitrou/arrow/builds/589335380


use new --print-deps option

Fixes https://github.com/flutter/flutter/issues/8514

no idea if the logic is sound, but the code is fine.
LGTM
Test?

There are already Tests for this and they are still passing after this refactoring. Since this doesn't add new functionality, there should not be a need to add new tests.


fix faild test for frontend/server package

ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go test -cover
# github.com/ericwq/aprilsh/frontend/server [github.com/ericwq/aprilsh/frontend/server.test]
./server_test.go:863:31: too many arguments in call to newMainSrv
        have (*Config, func(conf *Config, exChan chan string, whChan chan workhorse) error)
        want (*Config)
./server_test.go:925:29: too many arguments in call to newMainSrv
        have (*Config, func(conf *Config, exChan chan string, whChan chan workhorse) error)
        want (*Config)
./server_test.go:1116:25: too many arguments in call to newMainSrv
        have (*Config, func(conf *Config, exChan chan string, whChan chan workhorse) error)
        want (*Config)
./server_test.go:1167:31: too many arguments in call to newMainSrv
        have (*Config, func(conf *Config, exChan chan string, whChan chan workhorse) error)
        want (*Config)
./server_test.go:1238:31: too many arguments in call to newMainSrv
        have (*Config, func(conf *Config, exChan chan string, whChan chan workhorse) error)
        want (*Config)
./server_test.go:1293:29: undefined: runWorker
./server_test.go:1293:29: too many arguments in call to newMainSrv
        have (*Config, unknown type)
        want (*Config)
./server_test.go:1350:28: undefined: runWorker
./server_test.go:1350:28: too many arguments in call to newMainSrv
        have (*Config, unknown type)
        want (*Config)
./server_test.go:1435:31: undefined: runWorker
./server_test.go:1435:31: too many errors
FAIL    github.com/ericwq/aprilsh/frontend/server [build failed]

unit test coverage.
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/frontend/server       3.537s  coverage: 81.8% of statements

unit + integration test coverage.
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go tool covdata percent -i=./coverage/unit,./coverage/int
        github.com/ericwq/aprilsh/frontend/server               coverage: 89.8% of statements

over 91%.
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/frontend/server       3.342s  coverage: 82.2% of statements
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go tool covdata percent -i=./coverage/unit,./coverage/int
        github.com/ericwq/aprilsh/frontend/server               coverage: 91.0% of statements

84.7% and 93.1%.
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/frontend/server       3.511s  coverage: 84.7% of statements
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ go tool covdata percent -i=./coverage/unit,./coverage/int
        github.com/ericwq/aprilsh/frontend/server               coverage: 93.1% of statements

verified
build server start: 2024-03-06 23:09:19
build server end  : 2024-03-06 23:09:31
output server to  : /home/packager/aports/main/aprilsh/src/aprilsh-0.6.8/bin/apshd
build client start: 2024-03-06 23:09:31
build client end  : 2024-03-06 23:09:36
output client to  : /home/packager/aports/main/aprilsh/src/aprilsh-0.6.8/bin/apsh
ok  	github.com/ericwq/aprilsh/encrypt	0.003s
ok  	github.com/ericwq/aprilsh/frontend	5.709s
ok  	github.com/ericwq/aprilsh/frontend/server	3.176s
ok  	github.com/ericwq/aprilsh/network	3.856s
ok  	github.com/ericwq/aprilsh/statesync	0.032s

test failed on darwin platform.

for linux:
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ APRILSH_APSHD_PATH=~/.local/bin/apshd go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/frontend/server       3.485s  coverage: 84.8% of statements

for mac:
qiwang@Qi15Pro server % APRILSH_APSHD_PATH=~/.local/bin/apshd go test -cover . -args -test.gocoverdir=./coverage/unit
ok  	github.com/ericwq/aprilsh/frontend/server	3.958s	coverage: 84.8% of statements

for linux:
ide@openrc-nvide:~/develop/aprilsh/frontend/server $ APRILSH_APSHD_PATH=~/.local/bin/apshd go test -cover . -args -test.gocoverdir=./coverage/unit
ok      github.com/ericwq/aprilsh/frontend/server       4.013s  coverage: 85.1% of statements

for mac:
qiwang@Qi15Pro server % APRILSH_APSHD_PATH=~/.local/bin/apshd go test -cover . -args -test.gocoverdir=./coverage/unit
ok  	github.com/ericwq/aprilsh/frontend/server	5.481s	coverage: 82.8% of statements


System saves mixture ambiguous monomers as alternatives ambiguous monomers

Steps to Reproduce

Toggle to Macro - Flex
Load from clipboard way: PEPTIDE1{(D,N,I)}$$$$V2.0
Load from clipboard way: PEPTIDE1{(D+N+I)}$$$$V2.0

Save canvas to HELM

Actual behavior
System saves both monomer as alternatives

Expected behavior
Resulted HELM should be PEPTIDE1{(D,N,I)}|PEPTIDE2{(D+N+I)}$$$$V2.0
Versions

Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
Chrome Version 128.0.6613.114 (Official Build) (64-bit)
Win10

Reference issues: https://github.com/epam/Indigo/issues/2188

Ketcher generate ket with only one tenplate:
{
    "root": {
        "nodes": [
            {
                "$ref": "monomer89"
            },
            {
                "$ref": "monomer90"
            }
        ],
        "connections": [],
        "templates": [
            {
                "$ref": "ambiguousMonomerTemplate-_D___Aspartic acid_N___Asparagine_I___Isoleucine"
            },
            {
                "$ref": "monomerTemplate-D___Aspartic acid"
            },
            {
                "$ref": "monomerTemplate-N___Asparagine"
            },
            {
                "$ref": "monomerTemplate-I___Isoleucine"
            }
        ]
    },
    "monomer89": {
        "type": "ambiguousMonomer",
        "id": "89",
        "position": {
            "x": 9.52500000000001,
            "y": -8.9
        },
        "alias": "%",
        "templateId": "_D___Aspartic acid_N___Asparagine_I___Isoleucine"
    },
    "ambiguousMonomerTemplate-_D___Aspartic acid_N___Asparagine_I___Isoleucine": {
        "type": "ambiguousMonomerTemplate",
        "id": "_D___Aspartic acid_N___Asparagine_I___Isoleucine",
        "alias": "%",
        "subtype": "alternatives",
        "options": [
            {
                "templateId": "D___Aspartic acid"
            },
            {
                "templateId": "N___Asparagine"
            },
            {
                "templateId": "I___Isoleucine"
            }
        ]
    },

Verified.

Versions

Ketcher Version 2.25.0-rc.3 Build at 2024-09-18; 16:24:03
Indigo Toolkit Version 1.24.0-rc.3.0-g692080c62-wasm32-wasm-clang-19.0.0
Chrome Version 129.0.6668.59 (Official Build) (64-bit)
Win10


[wip] Allow callbacks to be restored not just during training

What does this PR do?

Fixes #20137

Before submitting

[x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20403.org.readthedocs.build/en/20403/

hey @chualanagit thanks for the contribution!
looks reasonable to me, can you please add an example of usage to the linked issue?

hey @chualanagit thanks for the contribution!
looks reasonable to me, can you please add an example of usage to the linked issue?

will do, thanks for the review, I'm still doing some testing, will get back to you all here soon!

Can someone shed some light on this Probot / required-jobs (pull_request)  timeout

Looks good, merging! Thanks for the PR @chualanagit


Separator state type

This PR switches from pushing the AppendedSeparator value to the stack to using a Separator state type to identify whether computation is within a separator.
This is preferable to #47, since it doesn't require any differentiation by the user between different types of separators. Plus, this passes some edge cases that #47 doesn't.
Fixes #41 and #48.

Codecov Report

Merging #49 (1a193b0) into 0.6.0 (e0a437e) will increase coverage by 0.80%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##            0.6.0      #49      +/-   ##
==========================================
+ Coverage   87.63%   88.44%   +0.80%
==========================================
  Files           9        9
  Lines         566      571       +5
==========================================
+ Hits          496      505       +9
+ Misses         70       66       -4

Impacted Files
Coverage Δ

src/pda.rs
84.00% <90.90%> (+2.18%)
:arrow_up:

src/lib.rs
92.30% <100.00%> (+0.30%)
:arrow_up:

tests/integration.rs
100.00% <100.00%> (ø)

word_filter_codegen/src/pda.rs
86.06% <100.00%> (+0.23%)
:arrow_up:

word_filter_codegen/src/type.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a437e...1a193b0. Read the comment docs.


Plotly vs ggplot?

Hi @meztez! Hope you're well. I'm currently adding some new functionality (including some new plots) to the app, and was wondering about the benefits of using an interactive javascript library like ploty (as you did for the BGC futures plot) vs a static renderPlot output (my plots are currently ggplot2). Assuming they don't need to have any interactivity, is there any benefit to converting them to plotly? Thanks!

@kdaust here is my unsolicited input: I'm generally moving over to plotly as i do think the interactive functionality adds quite a bit to the user experience. see the "choose models" tab in my cmip6-bc app. Much better than the static version in my ccsummary  apps.

Thanks @cmahony! I agree with you - certainly works great in the choose models plot! I haven't used plotly much before - I'll have to get into it!

With plotly I don't have to think about recomputing the plot when the user change the browser window dimension. It is an esthetics choice.

Thanks! Appreciate the feedback :)


No location detected when killing an application on Android 10

Location is not detected when the application is killed
At startup I select "Allow all" on dialog
Android 10
RN 0.63.3

What you mean 'Location is not detected? You mean BackgroundGeolocation.on('location', (location) => {callback or POST request withpostTemplate`?

What you mean 'Location is not detected? You mean BackgroundGeolocation.on('location', (location) => {callback or POST request withpostTemplate`?

Yes. The BackgroundGeolocation.on ('location', (location) => {callback} callback only works if the application is running or in the background.
As soon as the application turns off, the icon remains lit in the tray that geolocation is working, but in fact the coordinates are not collected.

Yes. The BackgroundGeolocation.on ('location', (location) => {callback} callback only works if the application is running or in the background.
As soon as the application turns off, the icon remains lit in the tray that geolocation is working, but in fact the coordinates are not collected.

@Adigezalov That's normal behavior.
You should use url, httpHeaders, postTemplate to keep track on location change even your app is terminated.
(Which means you need server to receive background POST requests)

@Adigezalov That's normal behavior.
You should use url, httpHeaders, postTemplate to keep track on location change even your app is terminated.
(Which means you need server to receive background POST requests)

@darron1217 Hmm ... for some reason I thought it should update locally when turned off. Thanks for the answer! I will redo =)
But then the next question arises. How to turn off the geolocation service after a specified period of time when the app is turned off?

@darron1217 Hmm ... for some reason I thought it should update locally when turned off. Thanks for the answer! I will redo =)
But then the next question arises. How to turn off the geolocation service after a specified period of time when the app is turned off?

@Adigezalov
You can check the manual
Android headless task
https://github.com/darron1217/react-native-background-geolocation#android-headless-task-experimental
IOS background task
https://github.com/darron1217/react-native-background-geolocation#quick-example
    BackgroundGeolocation.on('location', (location) => {
      // handle your locations here
      // to perform long running operation on iOS
      // you need to create background task
      BackgroundGeolocation.startTask(taskKey => {
        // execute long running task
        // eg. ajax post location
        // IMPORTANT: task has to be ended by endTask
        BackgroundGeolocation.endTask(taskKey);
      });
    });

@Adigezalov
You can check the manual
Android headless task
https://github.com/darron1217/react-native-background-geolocation#android-headless-task-experimental
IOS background task
https://github.com/darron1217/react-native-background-geolocation#quick-example
    BackgroundGeolocation.on('location', (location) => {
      // handle your locations here
      // to perform long running operation on iOS
      // you need to create background task
      BackgroundGeolocation.startTask(taskKey => {
        // execute long running task
        // eg. ajax post location
        // IMPORTANT: task has to be ended by endTask
        BackgroundGeolocation.endTask(taskKey);
      });
    });

Or you can use paid version.
There's stopAfterElapsedMinutes option.
https://transistorsoft.github.io/react-native-background-geolocation/interfaces/_react_native_background_geolocation_.config.html#geolocation-options

Or you can use paid version.
There's stopAfterElapsedMinutes option.
https://transistorsoft.github.io/react-native-background-geolocation/interfaces/_react_native_background_geolocation_.config.html#geolocation-options

@Adigezalov
You can check the manual
Android headless task
https://github.com/darron1217/react-native-background-geolocation#android-headless-task-experimental
IOS background task
https://github.com/darron1217/react-native-background-geolocation#quick-example
    BackgroundGeolocation.on('location', (location) => {
      // handle your locations here
      // to perform long running operation on iOS
      // you need to create background task
      BackgroundGeolocation.startTask(taskKey => {
        // execute long running task
        // eg. ajax post location
        // IMPORTANT: task has to be ended by endTask
        BackgroundGeolocation.endTask(taskKey);
      });
    });

Not working in headless task, only works for about 10s then nothing works in background


RuntimeException when updating from 1.6 to 1.7.1

[RuntimeException]
Error Output: PHP Fatal error:  Call to undefined method Illuminate\View\Compilers\BladeCompiler::directive() in /home/vagrant/projects/askme2/vendor/bican/roles/src/Bican/Roles/RolesServiceProvider.php on line 46
PHP Stack trace:
PHP   1. {main}() /home/vagrant/projects/askme2/artisan:0
PHP   2. Illuminate\Foundation\Console\Kernel->handle() /home/vagrant/projects/askme2/artisan:36
PHP   3. Illuminate\Foundation\Console\Kernel->bootstrap() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:92
PHP   4. Illuminate\Foundation\Application->bootstrapWith() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:195
PHP   5. Illuminate\Foundation\Bootstrap\BootProviders->bootstrap() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:183
PHP   6. Illuminate\Foundation\Application->boot() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/BootProviders.php:15
PHP   7. array_walk() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:686
PHP   8. Illuminate\Foundation\Application->Illuminate\Foundation\{closure}() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:686
PHP   9. Illuminate\Foundation\Application->bootProvider() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:685
PHP  10. Illuminate\Container\Container->call() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:703
PHP  11. call_user_func_array:{/home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Container/Container.php:523}() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Container/Container.php:523
PHP  12. Bican\Roles\RolesServiceProvider->boot() /home/vagrant/projects/askme2/vendor/laravel/framework/src/Illuminate/Container/Container.php:523
PHP  13. Bican\Roles\RolesServiceProvider->registerBladeExtensions() /home/vagrant/projects/askme2/vendor/bican/roles/src/Bican/Roles/RolesServiceProvider.php:24

Could you please check that?
Kindest regards
Christian

Are you on Laravel 5.1?

No, 5.0.x

Sorry, 1.7.1 seems to work, only dev-master seems to not work.

Yes. Because dev-master is for Laravel 5.1 now.

Can we pull dev-master if we're using Laravel 5.1 ?

Yes.

Hm...it seems I can't find that branch here?

It's master.

Thanks


[AutoPR sql/resource-manager] Sensitivity labels: Disable/Enable recommended sensitivity labels

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5083

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/2261


MySql don't install

If I try to install with mysql after I fill the data by pressing the next button , nothing happens. However using SQLLite if it works.

Same Problem

We released the Pagekit Beta today. I close this issue because the code base completely changed. Please open a new issue if it still exists.


Some proofs in seqproperties extremely flaky, admitted for now

Some of the proofs in seqproperties.fst like those for split_5 and lemma_swap_slice_commute are extremely flaky. They have unpredictable failure behavior that seems to depend on lots of things:

like the power and load of the machine
the contents of the rest of the file, even definitions that appear after the failing ones
the name of the file in which they reside
whether the --logQueries flag is set or not

I've admitted these proofs until we figure out what is happening and come up with reliable proofs.
PS: Here are the error messages for lemma_swap_slice_commute
[hritcu@detained pub]$ fstar.exe --admit_fsi FStar.Set --admit_fsi FStar.Seq set.fsi heap.fst st.fst seq.fsi classical.fst seqproperties.fst
seqproperties.fst(304,0-304,137): post-condition at seqproperties.fst(303,23-303,105)
seqproperties.fst(304,47-304,137): assertion failed
Error: 2 errors were reported (see above)

and split_5 (although for this one sometimes the error is just Unknown assertion failed):
seqproperties.fst(191,0-191,27): post-condition at seqproperties.fst(187,16-187,
48)

No more admits in seqproperties. Closed


HealthCheck endpoint configurability

Currently, the healthcheck endpoint checks both rabbitmq and redis, and this will be fetched from CELERY_BROKER_URL.
But in practice, only one of these two will be used.
Currently, this means that one of the checks will always be failing. This is an issue, because the endpoint returns a 500 error if any of the checks are failing, so we can't use any automated checking tools that will just check the status code.
I think there are 2 ways to go about this:

Have separate REDIS_URL and RABBITMQ_URL configs, and choose the BROKER_URL from one of them (preferring one over the other if both are supplied), and only add a healthcheck for each of those if they're supplied.
Have separate BROKER_URL, REDIS_URL, and RABBITMQ_URL, and use the celery healthcheck to check the BROKER_URL, and the redis and rabbitmq healthchecks to check the others, also only adding the healthchecks if the config values are supplied.

I think the issue for 2 is that if the celery worker is down, we don't want to be alerting or restarting the django web process, because there's nothing wrong with it, the issue is with the celery worker. But we still want to be able to alert if Django cannot contact the message broker. For that reason I'm leaning towards 1.

I think adding either ofthe test options to INSTALLED_APPSin dev and production settings with respectable URLs will be the cleanest solution


'email code' blocker

I'm hitting:
"No 2FA Given
email code:"
prompt when i reach the rh.login(username=USERNAME, password=PASSWORD) step
Have not been able to proceed past this step.
which prevents me from

Checklist

[ ] I am on the latest pyrh version.
[ ] I have searched the issues of this repo and believe that this is not a duplicate.

Description

Steps/Code to Reproduce

Results

Versions

I'm not sure if you are still running into this issue but I found a way around this by using pyotp and also enabling 2FA in robinhood app and using the google authenticator option it should look something like this:
import pyotp
import robinhood_stocks as r
totp = pyotp.TOTP("codefromRH").now()
print("Current OTP:", totp)
totp = pyotp.TOTP("codefromRH").now()
login = r.login(username='username', password='password', mfa_code=totp)


Add consistent hashing InputMatcher

Tracks adding a simple InputMatcher that takes a configurable threshold and will consistently hash the input string, matching if the resulting hash value is above the configured threshold:
match = (hash(input) % 100) > threshold

This would allow users to configure a match rule that will consistently match X% of requests based on a random input string (e.g. a tracing header).

@snowp
At which level would you prefer this matching should be added to? Supposing there are actually 3 opts:

extending as a separate match logic for SinglePredicate InputMatcher;
extending as a new match rule for StringMatcher;
adding as a new ConsistentHashMatcher type.
Thanks.

@snowp
At which level would you prefer this matching should be added to? Supposing there are actually 3 opts:

extending as a separate match logic for SinglePredicate InputMatcher;
extending as a new match rule for StringMatcher;
adding as a new ConsistentHashMatcher type.
Thanks.

I would add this as a CustomMatcher extension for use within the SinglePredicate. I don't recall off the top of my head whether we've wired up the extension factory logic here, so that might be part of it

I would add this as a CustomMatcher extension for use within the SinglePredicate. I don't recall off the top of my head whether we've wired up the extension factory logic here, so that might be part of it


Vercel install instruction

Cloudflare Workers is slower and has limitations. Vercel is more convenient for deployment. Please make instructions for installation on Vercel.

I am writing up updated instructions but I am unsure how to use Vercel in the same way as Cloudflare.
If you can provide me a good guide I can add those instructions for Vercel.


Add I2S example for M5Core2 in readme

Description

Motivation and Context
Information
How Has This Been Tested?

Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[ ] New feature (non-breaking change which adds functionality to code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[x] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[ ] My code follows the code style of this project (only if there are changes in source code).
[ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[x] I have read the CONTRIBUTING document.
[ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[ ] I have added new tests to cover my changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: henrivw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@henrivw please don't forget to sign the license so we can merge ;-) And thanks a lot for your contribution!

@henrivw thanks again and please don't forget to sign the license/cla otherwise we won't be able to merge.


Add awesome-webrtc

Please read the instructions for creating a new list, contributing guidelines and the awesome manifest.
Especially this part:

Wait at least a couple of weeks after creating a list before submitting to give it a chance to mature.

Ping me here in a few weeks and I'll reopen ;)

Link additions should be added to the bottom of the relevant category.

The formatting in your needs work.

Linkify text instead of prepending the verbatim link. RTCPeerConnection 'on one page', i.e. without signaling: http://simpl.info/rtcpeerconnection/
Many of the links could use a short description. Like these: https://github.com/OpenRTC-IO/awesome-webrtc#video-chat
Don't use the actual link as title, but rather the actual name of the thing: https://github.com/OpenRTC-IO/awesome-webrtc#chat


New org assigned to Gabriel Bobis: FAR.AI

Ready, check https://github.com/riceissa/aiwatch/commit/a5bb60c27238a18aac48f8844680d2272c2ed2d9

Gabriel: "It was an organization with very comprehensive information, as most of its team (both current and former members) had access to various sources of information. Despite some temporal gaps in the Wayback Machine, there were no major difficulties in pinpointing the exact dates, with only a few exceptions. The core area of this organization is "AI safety," as its activities encompass technical research on AI security, support for the research community in this field, and the creation of initiatives to bring together AI leaders globally."


section fixes and extra content

added descriptions to different libraries/APIs
included new section for AI chatbot creation

Yesssss, the bot worked... 😂


Get rid of mpi4py-mpich dependency

mpi4py-mpich is not properly maintained on PyPI. We plan to have a dependency on mpi4py only.

Related to #334.


If ValidationScenario(s) removed, invalid job flips to valid

When the link to the ValidationScenario is removed, job reverts to valid.  This is not terribly surprising, but might be confusing to users if they have long-living jobs in Combine, but modify or remove Validation scenarios.

Arguably too in the weeds to address. Can reopen if this comes up again, but a bit more complex than not cascade deleting the validation failures with a loss fo the validation scenario, as the reporting would not understand what the failure related to.


add support for instance relabeling

This change addresses an issue where users can relabel the instance label using prometheus relabelling rules, causing the sidecar to skip sending metrics it shouldn't because it fails to retrieve the metadata on the affected metrics.
The sidecar will now look at the Prometheus ScrapeConfig via the API and create a map of job name -> remapped instance label

Separate from the PR here, we should add to the README to say that instance relabeling is dangerous and that we detect it in certain conditions. We'd like users to suspect they're in danger; they can request other ways to configure their identifying labels.


Non re-entrant lock blocking extension use with msal~=0.4.1

Repro:

Clone this repository on MacOS or Windows
Create new virtual environment
Run pip install, ensure pip list | grep msal (or similar command outside of bash) is greater or equal to 0.4.1.
Run pytest

Expected:

Tests will pass

Actual:

Tests hang indefinitely.

What happened is that in 8a7495a006eafd75179c0975b7fc52fddf733ca5 the add function got refactored to call self.modify. In doing so, because of the inheritance involved, it is calling our FileTokenCache's implementation of these functions and causing us to try to take a second lock on a file we're already locked on. This is causing an indefinite hang.
Amusingly, this is the exact problem talked about here: https://www.youtube.com/watch?v=YXiaWtc0cgE

I think this issue is an indicator that we should probably setup a nightly CI run for this repository. Would have helped detect this error earlier. A step further, would be running the extension's tests as part of CI in the upstream repository.


Changelog update to reflect encryption to be enabled by default

It seems in the 1.5.0 release the default config has encryption enabled (https://github.com/neo4j/neo4j-python-driver/blob/1.5/neo4j/v1/security.py#L52) which causes an exception to thrown if the Python version is less than  2.7.9.
I was wondering whether this Changelog should be updated to reflect this?

While the code here has changed, the default has been to open encrypted connections for a long time.

Thanks @technige for the quick response. In previous versions of the driver we would get the warning though in 1.5.0 the exception is raised.
Referring to the code from 1.4.0 (https://github.com/neo4j/neo4j-python-driver/blob/1.4/neo4j/v1/security.py) if SSL_AVAILABLE is False this implies that ENCRYPTION_DEFAULT = 0, which means that the encrypted = 0 (assuming that the encrypted key in the config is undefined or None). The warning is displayed and the if statement on line 63 evaluates to False.
In 1.5.0 assuming the same configuration, it seems the new default_config is used if the encrypted config key is undefined which defaults to True (https://github.com/neo4j/neo4j-python-driver/blob/1.5/neo4j/config.py#L52) and thus the warning is no longer displayed and the if statement evaluates to True causing the exception to be thrown.

Hi @john-bodley
I copy paste the default value wrongly. There was no intention to change the default value in 1.5. We will fix this unexpected change in next patch.
Sorry for causing this error to you. Please override the wrong default encryption config in your code for now.
Thanks again for raising this issue to us.
Zhen

Hi @john-bodley
We've already release 1.5.1 which contains the fix for this issue.
Thanks,
Zhen


Make setMergedConfig public method

Can be useful from the outside in certain scenarios.

Question: wouldn't you want to reset the mergedConfigObject property any time this is called?

Hm, yeah you probably would... I was unsure about that, because if the instance of the Config object has been fetched already somewhere in the app and you set it to a new one, then you'll have two separate, diverged Config instances (the originally fetched one (now out of date), and the updated one in the module manager. Of course, if you're working with straight arrays, you'll always have this problem since you're returning copies and not references; so in the case of using arrays,that would be unavoidable.

I'll go ahead and make it always reset it, since I think ending up with two diverged instances would at least be less confusing than the Config object simply not being updated.

Merged!