Ionic 2 -  doesn't show numeric only keypad.

In my app's login page , I use  for entering phone number. But in android device (Samsung S6) it doesn't show numberic keypad. Usual keypad is showing. How I can solve it?
Ionic version:  (check one with "x")
[ ] 2.x

Does the keyboard on the Samsung device actually have a numeric only keyboard? Have you seen it do this (for example on the contacts app)? Sometimes the numeric keyboard just adds a row of numbers to the top of the keyboard.

Hello! While we appreciate you opening an issue with us i am going to close this issue and ask that you open a new one that has the issue template filled out please. Thanks for using Ionic!

@dylanvdmerwe , yes. Samsung device have a numeric only keyboard.

@dylanvdmerwe,  @jgw96

<form [formGroup]="loginForm">
  <ion-item  >
    <ion-label floating>Phone number</ion-label>
    <ion-input type="number" formControlName="uname" [(ngModel)]='username' maxlength="10" ></ion-input>
  </ion-item>

  <ion-item>
    <ion-label floating>Password</ion-label>
    <ion-input type="password" formControlName="pword" [(ngModel)] = "password"></ion-input>
  </ion-item>
  <ion-item>
    <button ion-button block color="bluedevider" [disabled] = "!loginForm.valid" (click)='login()'>Submit</button>
  </ion-item>
</form>

this is my code

`
<form [formGroup]="loginForm">
  <ion-item  >
    <ion-label floating>Phone number</ion-label>
    <ion-input type="number" formControlName="uname" [(ngModel)]='username' maxlength="10" ></ion-input>
  </ion-item>

  <ion-item>
    <ion-label floating>Password</ion-label>
    <ion-input type="password" formControlName="pword" [(ngModel)] = "password"></ion-input>
  </ion-item>
  <ion-item>
    <button ion-button block color="bluedevider" [disabled] = "!loginForm.valid" (click)='login()'>Submit</button>
  </ion-item>
</form>

`

i am trying to disable dot('.') in numeric keypad in ionic 2 but i didn't got a proper way to handle this situation ,is any one having even idea also appreciated,i am struggling with this issue from past one week,my client is rushing for it ......many thanks in advance

is it possible to made go button for text control to move focus to next control of any type in ionic2 application please help me to get out from this situation,it is working fine with numeric key pad and text control to text control but the next one is other then text it is not working any sample code /idea/opinion were appreciable ...thank in advance

ion-input  type="tel"

Try type="number" pattern="[0-9]*" to disable the dot. Works on iOS 9/10 and for Android on apps using the Chrome Webview (i.e. Android 5+)

@oddcb  not working

@oddcb works perfectly! I was using type="tel" because type="number" was way worse since it showed the whole alphabet keys.
But combining it with pattern="[0-9]*" did the trick. Thanks!

But android mobile allow other special character keys.@mrmgomes your tricks won't work.Tell me other way to achieve only number [0-9]

I am having the same issue. I prevent dot . and dash - from keyboard, and it works. The input is not recognized and do not return the value of the keypress event. BUT! The dot and the dash are written in the input. No matter what validation i set.

For troubleshooting you can test different patterns in browser here: http://inputtypes.com/
On Android from 5 and forward Ionic should use the built in Chrome webview which hopefully (more or less) corresponds to the Chrome version you have installed on the phone.

this cordova plugin are use
mx.ferreyra.callnumber 0.0.2 "Cordova Call Number Plugin"

Code
   <ion-fab left bottom>
    <a href="tel:number" class="button" ion-fab color="light">
        <ion-icon name="keypad"></ion-icon>
    </a>
</ion-fab>

Keyboard not open in kiosk mode some one help me.

pattern="\\d*"

// my code
<ion-input [(ngModel)]="phone" (keypress)="codeInput($event)" type="tel">
codeInput(event) {
//48 - 57
let pass = /[4][8-9]{1}/.test(event.charCode) || /[5][0-7]{1}/.test(event.charCode);
if (!pass) {
return false;
}
}


Decompile -> Compile Apps for target SDK 28 crashes after start

Information

Apktool Version (apktool -version) - Latest from github compiled
Operating System (Mac, Linux, Windows) - Windows
APK From? (Playstore, ROM, Other) - Other

Stacktrace/Logcat
Include stacktrace here

Steps to Reproduce

Using APK easy tool simply decompile and compile and signing with no changes. App don't run on devices.

Frameworks
No Framework
APK
https://mega.nz/#!GEQDAaKA!fFzh3UhTjlXTuf_LvXmVI4Sz9hkH-NQVLxRfmcnwDeY
Old version ( Working Compiled ) -> https://mega.nz/#!TNwxlCZS!BcF6lAYqBtWuAKth7JHg9MKeeC5MOLKRRmGAxSFQGvY
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? - Yes
If you are trying to install a modified apk, did you resign it? - Yes
Are you using the latest apktool version? - Yes

Previous versions of the App was for target SDK 25 and the compiling was working. After this version the target SDK is 28 and after decompiling and compiling it again with no changes the app is crashing after it's opened. Is the issue in the apktool or the app itself?

  If you can meet me with those details we can investigate further to see if its a resource packed improperly, etc.
Closing.


Is there a way to read only 1 worksheet from workbook?

I have a workbook with a lot of worksheets but i only need to parse 1 single sheet. I want to reduce the total time taken by XLSX.read function.
I am using booksheets and bookprops options to read workbooks's metadata and then want to read only 1 worksheet using that metadata.
var workbook = XLSX.readFile('1546891304230_1373_2.xlsx',{bookSheets:true,bookProps:true});
var sheetname = workbook.SheetNames.sort()[0];
I couldn't find any function in documentation which can achieve that. Is it possible?

Have you solved it?

I couldn't solved it.
SheetJS Team, Any solution for this problem?
On Thu, Nov 14, 2019 at 1:05 AM Chae Hyeong<EMAIL_ADDRESS>wrote:

Have you solved it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SheetJS/sheetjs/issues/1406?email_source=notifications&email_token=ABWMG37YGRYNEZDZNXMLOSTQTTTDLA5CNFSM4GQXRN2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEAWJZI#issuecomment-553739493,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWMG374MQWZSSOEFJZQCMDQTTTDLANCNFSM4GQXRN2A
.

For anyone still looking: you can accomplish this with the sheets property of the readFile function. It's listed in the properties section here
var workbook = XLSX.readFile(filename,{sheets: ['sheet1','shee2']});

The sheets option to read and readFile was added in version 0.15.5 -- please update


Ap 122

This task is about an association between application and proceeding type codes when an application is created. commits from this branch has been cherry-picked to - https://github.com/ministryofjustice/laa-apply-for-legalaid-api/pull/19

Closing in favour of https://github.com/ministryofjustice/laa-apply-for-legalaid-api/pull/19 which replaces this.


No open entity in HA

Hi, I just installed this for use with a Nuki 3.0 and everything is ok except I'm missing the open door entity, I just have lock and unlock.
Any idea why?
Thanks

Thanks for the reply, I just found it, it's a service not an entity, great work!


compiling doctest in 32-bit with __stdcall calling convention fails

Description
compiling doctest in 32-bit with __stdcall calling convention gives the following two error messages
doctest.h(4264): error C2440: '=': cannot convert from '_crt_signal_t' to 'void (__stdcall *)(int)'
doctest.h(4264): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast
doctest.h(4298): error C2664: '_crt_signal_t signal(int,_crt_signal_t)': cannot convert argument 2 from 'void (__stdcall *)(int)' to '_crt_signal_t'
doctest.h(4298): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast
signal.h(62): note: see declaration of 'signal'
the problem could be solved with the following patch:
doctest-gitdiff-cdecl.txt
Possibly also by defining a well known macro substitution CDECL for example
#ifndef CDECL
#define CDECL __cdecl
#endif

Steps to reproduce
compile doctest in 32-bit with __stdcall calling convention

Extra information

doctest version: git current
Operating System: Windows 10
Compiler+version: Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29914

or
#if !defined(CDECL) && defined(_WIN32)
#define CDECL __cdecl
#else
#define CDECL
#endif

or
#if !defined(CDECL) && defined(_WIN32)
#define CDECL __cdecl
#else
#define CDECL
#endif

would that cause problems for 64 bit mode?

or
#if !defined(CDECL) && defined(_WIN32)
#define CDECL __cdecl
#else
#define CDECL
#endif

would that cause problems for 64 bit mode?

No, as far as I understand _WIN32 is defined by the MS compiler in x86, x64 and ARM and surely by most other well-known compilers as well. FYI not to be confused with the WIN32 define which is defined by the user. In 64-bit both _WIN32 and _WIN64 is defined by the compiler but the latter is rarely used.
MSDN: Predefined macros

I meant adding __cdecl in 64 bit builds as I'm not familiar enough with calling conventions

I meant adding __cdecl in 64 bit builds as I'm not familiar enough with calling conventions & if it would cause problems with stdcall & whatnot

No, it doesn't matter. You can add any calling convention prefix to suit your needs __cdecl, __stdcall, __fastcall etc. As far as I understand all 64-bit compiles become __fastcall regardless anyway. In 32-bit, the __stdcall calling convention is commonly used by Microsoft libraries and tools. The issue usually becomes a problem when functions that take function pointers as parameters are supplied with function pointers without a specified calling convention, that is functions are defined without a calling convention and rely on the underlying calling convention which usually is __cdecl but sometimes is __stdcall.
The solution in this case is thus:
void (CDECL *FatalConditionHandler::prev_sigabrt_handler)(int);
MSDN: __cdecl

pushed in dev


Invoking OAuth2 Service from OAuth2 Token Endpoint

Concern
In wso2-extensions/identity-inbound-auth-oauth repo OAuth2TokenEndpoint class [1], the following parameters are passed into the OAuth2AccessTokenReqDTO object which in turn passed into the OAuth2 Service in order to issue an access token.

Wrapped Http Servlet Request [2]
Http Headers [3]
Client Secret [4]

But these parameters should not be passed into the OAuth2 core since they do not abide with OAuth2 specification.
Suggestions

1st and 2nd Parameters - The necessary attributes (that are used inside the OAuth2 Service) can be extracted from these parameters and those attributes can be sent to the service instead of the parameters.
3rd Parameter - Client Secret is only used in one place after calling the OAuth2 Service. It is to trigger a diagnostic log event in case of a null OAuthClientAuthnContext object [5]. But logging a client secret would be a security concern. Therefore, it is suggested to remove the client secret from the above log. After that, the Client Secret parameter can be completely removed from the OAuth2AccessTokenReqDTO object as it is not needed anymore.

[1] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v6.7.144/components/org.wso2.carbon.identity.oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/token/OAuth2TokenEndpoint.java
[2] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v6.7.144/components/org.wso2.carbon.identity.oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/token/OAuth2TokenEndpoint.java#L343
[3] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v6.7.144/components/org.wso2.carbon.identity.oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/token/OAuth2TokenEndpoint.java#L341
[4] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v6.7.144/components/org.wso2.carbon.identity.oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/token/OAuth2TokenEndpoint.java#L333
[5] - https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/v6.7.144/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/AccessTokenIssuer.java#L160

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Chat warning customizations

It would be nice to be able to customize the messages the detector sends in the same fashion that we can change colours currently the only option is to edit the code manually.

dupe of #70


[react-stately][useControlledState] value param should be optional

🐛 Bug Report
In the useControlledState function, the first prop, value, can be optional. However, the typescript doesn't allow the value param to be optional.

🤔 Expected Behavior
The example below doesn't have any type errors, assuming that validDefaultValue and validOnChange have the right types.
useControlledState(undefined, validDefaultValue, validOnChange)

😯 Current Behavior
The first param has the typescript error: Argument of type 'SomeType | undefined' is not assignable to parameter of type 'Value'.   Type 'undefined' is not assignable to type 'Value'.ts(2345)
useControlledState(undefined, validDefaultValue, validOnChange)

💁 Possible Solution
Solution is simple: change the current https://github.com/adobe/react-spectrum/blob/a71a0a7/packages/%40react-stately/utils/src/useControlledState.ts, which has param value: T to be value: T | undefined.
I can make a pull request fixing.

🔦 Context
I was trying to use the useControlledState to make a component optionally controlled (written in typescript), but then I got the typescript error.

💻 Code Sample
useControlledState(undefined, true, () => {})

🌍 Your Environment

Software
Version(s)

react-spectrum
<EMAIL_ADDRESS>

Browser
Not applicable

Operating System
Windows

🧢 Your Company/Team
None

🕷 Tracking Issue (optional)

@ChocolateLoverRaj Mind making a sandbox to reproduce the issue? I tried here but I don't get a typescript error: https://codesandbox.io/s/distracted-minsky-ufupl?file=/src/App.tsx

@LFDanLu The reason why your sandbox did not have a typescript error is because the value type implicitly because number | undefined. But when calling useControlledState<number>(), there is a typescript error. In this sandbox: https://codesandbox.io/s/use-controlled-state-bug-kwy9q?file=/src/App.tsx, useControlledState<number>() is used so that blah will be number, and not number | undefined, so that add() can be called without any typescript errors or needing to use blah as number. If you remove the <number> part, there will be a typescript error when doing add(blah) because blah could be undefined.

Interesting, we do exactly this here
https://github.com/adobe/react-spectrum/blob/main/packages/%40react-stately/numberfield/src/useNumberFieldState.ts#L86
where value is defined<EMAIL_ADDRESS>is optional<EMAIL_ADDRESS>But I'm not seeing a TS error for our repo and I am for codesandbox, which means either newer TS is less forgiving or we have some option set that is allowing this.

I think it's because of the strictNullChecks option. When set to false, it lets you use undefined as values I think. In the codesandbox, the strict option was set to true in tsconfig.json, which includes the strictNullChecks option. You can try turning it on and off to see the error appear / go away in the sandbox.

The tsconfig.json file in the packages you linked doesn't have a strict or strictNullChecks option.

@ChocolateLoverRaj thanks for the info, IMO this should be a ok change to make then since it would fix this issue for users w/ strict set to true but wouldn't break it for users who don't have strictNullChecks enabled. @snowystinger thoughts?

seems reasonable, thanks for checking on that, with the extra info it sounds like it would be non-breaking

It's not just the value param that should be optional. The default value and onChange function should also be optional.
Use 1: Not controlled.
useControlledState(undefined, 10, undefined) // Should be fine

Use 2: Controlled.
useControlledState(5, undefined, () => {}) // Should be fine

So in a normal optionally controlled / default value component, the props would be similar to this
import { FC, Dispatch } from 'react'

interface Props {
  value?: number
  onChange?: Dispatch<number>
  defaultValue?: number
}

const OptionallyControlledComponent: FC<Props> = props => {
  const { value: propsValue, onChange, defaultValue } = props

  // propsValue, defaultValue, and onChange could all be undefined
  const [value, setValue] = useControlledState(propsValue, defaultValue, onChange)

  return <>Something</>
}

yep, default should be able to be undefined, and should just be TS to handle it
the callback however will likely need a check in useControlledState in addition to typings so we don't try to invoke undefined as a function

@snowystinger It already checks if onChange is undefined or not: https://github.com/adobe/react-spectrum/blob/a71a0a7/packages/%40react-stately/utils/src/useControlledState.ts#L34.

I have this issue too, and I also found this line of code which I believe could be problematic: https://github.com/adobe/react-spectrum/blob/main/packages/%40react-stately/utils/src/useControlledState.ts#L20
I think ?? is better here to avoid ignoring a perfectly valid false or 0 value with the defaultValue. Just a heads up in case it was an oversight.

A workaround in case it's useful to anyone!
In a declaration file, put this:
declare module "@react-stately/utils" {
  function useControlledState<T>(
    value?: T,
    defaultValue?: T,
    onChange?: (val: T, ...args: any[]) => void
  ): [T, (val: T | ((prevState: T) => T), ...args: any[]) => void];
}


Assert HTTP responses and prettify errors.

High-level description
The current retrying/wait implementation waits for a condition to become
true. This is hard to debug in error cases. Even with extra logging one
has to find the correct log lines. This change introduces the use of
a different assertions for responses from HTTP requests. The error
prints the actual status code and body, e.g.
This should ease debugging since the JUnit XML file generated by pytest
will include this message at the top.
Corresponding DC/OS tickets (obligatory)

DCOS_OSS-2115

@mesosphere-mergebot label Ready For Review

Hey @jeschkies - This is interesting! Look at the oddity teamcity/dcos/test/azure/arm  failed whereas the same test with onprem installer succeed.

Since this test is succeeding in other platforms and if we could we re-run on Azure to get more stats on this.

@mesosphere-mergebot bump-ee

Hi @jeschkies  - Look at the status now, it is green! - https://teamcity.mesosphere.io/viewLog.html?buildId=971521&tab=buildResultsDiv&buildTypeId=DcOs_Open_Test_IntegrationTest_AzureArm
The failure was due to timeout (and yes, ofcourse a bug in marathon) to exhibit a flaky behavior at higher level.

@orsenthil, I've upgraded to the latest master. I think we saw a similar issue in our system integration tests as well. Good to know that we caught this earlier :).

@mesosphere-mergebot bump-ee

@mesosphere-mergebot ship_it_label_status_check

@mesosphere-mergebot label Ship It

@mesosphere-mergebot label Ship It

@jeschkies  - You notice @mesosphere-teamcity teamcity/dcos/test/aws/onprem/static failure, That should be addressed first.

@mesosphere-mergebot override-status
teamcity/dcos/test/aws/onprem/static https://jira.mesosphere.com/browse/DCOS_OSS-2115

@mesosphere-mergebot bump-ee

@jeschkies  - can you bring this change into 1.11 (1.10) branch too? I was trying to cherry-pick. But instead, I think, this needs to be squashed can be brought in a single commit.


Football project

I ran out of API requests on the previous PR and so I had to create a new pull request based on a new API project
In this PR:

I have fully implemented the app and it is functional.
I have also worked on the tests

Here is a video demo for the app
https://github.com/mohammadnewton/react-capstone/assets/79839603/ceb71a0d-c3ae-447b-a83f-5397baab8ca8
Here is a screenshot of the tests

Feel free to give a feedback and I'll take it with a smile :blush:

To the next CR: As an exception, please proceed to review the PR.
Do your review as if it were a first review, and then open a zendesk ticket so we can record your review as the first review also on our database.


Make Java tracker have formal versioned dependency on core

The current dependency is by pointing to the subproject directory with project(":snowplow-java-core"). It would be nicer, if we change it to snowplow-java-tracker:snowplow-java-tracker-core:+.

Won't fix, doing #116 instead


Link tool at csaf.io

The official website of the standard has a list of tools that support CSAF. Any objections of being added there?

I would very much like to see SecObserve being listed there, see https://github.com/oasis-open/csaf-documentation/pull/57


merge from konsum-frontend-svelte

package.json

chore(deps): add ^3.46.5 remove ^3.46.4 (devDependencies.svelte)

:tada: This PR is included in version 1.31.13 :tada:
The release is available on:

v1.31.13
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow multiple triggers

I changed the code to allow multiple triggers and to allow styling the created mentions

+1 @gmartini20 is the component setup code any different with for this ?

@harshq is it possible to merge this pr please?

can you check this please @harshq looking good to me.


Issues in Self Registration form

Describe the issue:
We came across the following issues while trying out the Self Registration form in API Manager.

Email validation does not happen properly in the form. Email addresses with the format someone@wso2 are recognised as valid emails even though .com part is missing. Even the regexp set in the management console for email claims doesn't seem to affect the validation in the form.

The Sign In link in the form always redirect to /myaccount. There seems to be no configurations to change this URL and point to a different location in our product.

Environment information:

Product Version: APIM-3xx, APIM-4.0.0, IS versions parellel to those APIM versions
OS: Ubuntu 20.04 LTS

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Vertices values "off" when converting to .g3db format

When converting an fbx model from blender to .g3dj, the desired vertex positions are correct, however when converting to .g3db, a good portion of the vertices are very slightly "off".
http://i.imgur.com/EhveAW4.png
The above window shows the proper coordinates created in blender and converted to .g3dj, where the bottom window shows the coordinates generated in the .g3db file.

That's correct, the g3dj file format is slightly less accurate than the g3db format because for g3dj the numbers are rounded to 6 digits for the textual representation, while for g3db the numbers are used as is. That's why you see a difference when comparing the 6 digit rounded g3dj number to your 8 digit rounded numbers textual representation. That's to be expected.


Improve project setup experience

[x] Provide Docker option for running locally.
[x] Make sure README is fully up-to-date.
[x] Describe how to run the project locally and verify that the steps work.
[x] Describe how to run the tests.
[x] Include sample data for local development.

We don't need sample data since we just point to the API URL, closing this.


ImageBase64Plugin doesn't catch images

After a new release 3.1.1, ImageBase64Plugin + TypeScript does not process images. At the beginning everything looks fine:

But scroll down and see:

Looks like TS compiler trying to resolve png before ImageBase64Plugin.
Here is TS Config:
{
    "compilerOptions": {
        "allowSyntheticDefaultImports": true,
        "jsx": "react",
        "module": "commonjs",
        "noImplicitAny": true,
        "outDir": "./dist/",
        "preserveConstEnums": true,
        "removeComments": true,
        "sourceMap": true,
        "target": "ES6"
    },
    "include": [
        "./src/**/*"
    ],
    "types": ["jest"]
}

And module declarations to avoid lint errors:
declare module '*.jpeg';
declare module '*.jpg';
declare module '*.gif';
declare module '*.png';
declare module '*.svg';

@steppefox but does it break your build?

@nchanged nope, but as result it doesn't include any PNG assets. In dist js file, modules for that files are empty, no base64 strings =(

@steppefox oh, that's a regression. I will see it fixed and release a patch soon enough.

@steppefox are you sure that it's not working?
I've just tested it
___scope___.file("client/assets/characters.png", function(exports, require, module, __filename, __dirname){
module.exports.default = "data:image/png;base64,iV" ......});

@steppefox please verify the fix in<EMAIL_ADDRESS>

@nchanged 👍  it works!

https://github.com/fuse-box/fuse-box/releases/tag/v3.1.3


website: CSS fixes

CSS fixes to website refactor introduced by #103:

Bold font for active link in navbar
Make download icon visible in game list table
remove excess margin below links below ttitle

I reviewed this last night and it LGTM but I couldn't post it as on my phone which wasn't logged in to GH, glad we communicated telepathically somehow about this :)


Update intranet-governance.md

Added a suggestion in the measurement section based on some feedback I got in a recent presentation.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


docs: Add horeaporutiu.github.io to the showcase

Not sure if my local changes are shown in this commit...directions on https://gohugo.io/community/contributing/#showcase-additions dont seem to reflect the docs submodule. Please let me know if this worked or not.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Use this https://github.com/gohugoio/hugoDocs
For docs changes.


pylint support

We should add pylint support (either in documentation, with a script, in setup.py, ....)

It would be nice to recommend pylint in the developer documentation, e.g. in section "7.5 Coding rules and standards" instead of pyflakes and to start using it ourselves of course.
See for example this blog on why pylint is the best tool for static code analysis:
https://blog.codacy.com/review-of-python-static-analysis-tools-ff8e7e27f972

Codacy uses prospector, a tool which tries to intelligently combine the output of various Python linters of which pylint is the most comprehensive. We could also recommend prospector instead, probably with a recommended level of strictness, to help get a quick check if your code is any good according to Codacy before committing.

Could we also add a prospector check to the setup.py, so I could run "python setup.py check" or something?

Sure, I could add a command ./setup.py lint that does that? check is already taken.

Sounds good, thanks!


please add flask admin image upload example

Upload tab does not appear in flask admin and please add full example with upload in flask admin

Example added: https://github.com/greyli/flask-ckeditor/tree/master/examples/flask-admin-upload

IMO, you may forget to call ckeditor.load() in the template after set config variable in Python script.


Add functionality to retain listeners when the document is reopened

These changes will preserve the event listeners, which are added for detecting changes in values of the variable, on reopening the document. This will allow the user to share the document.

How is this process going? Hesitant to look too much if it's a draft still.

@irmerk it's going great. I have to find a way to enumerate the variables so that I can attach the listeners accordingly. Yes, you don't need to review this now :sweat_smile:


Where and how do I host the own server?

Absolutely amazing project, I really liked it.
I wanted to test this, how do I deploy own server? And where do I deploy it?

Absolutely amazing project, I really liked it.
I wanted to test this, how do I deploy own server? And where do I deploy it?


Add a Socketplane Agent Restart option.

Add restart as an option to the...

socketplane agent command

E.g.,

socketplane agent restart

#87 fixes this issue


About the different parameters between building model and localization.

I find you extract local features with diffearent extraction parameters when building colmap model and  evaluating the localization. Why?

What parameters are different? The ratio test? Generally localization and reconstruction are two different algorithms, and the optimal settings might be different.


docs: Add workaround for configuration_aliases tf bug

Put an x into the box if that apply:

[ ] This PR introduces breaking change.
[ ] This PR fixes a bug.
[ ] This PR adds new functionality.
[ ] This PR enhances existing functionality.
[X] This PR updates documentation

Description of your changes
As noted in the change, there is a bug affecting terraform validate
when used with a module that also requires multiple aliased providers.
There is little activity on this bug, leave it an open question on if
or when it will be fixed. This documents a couple of workaround options
in the interim.
Fixes #330
How can we test changes
Define a module with configuration aliases as described in #330, and run terraform validate.  This should error out.
Following the instructions provided in the documentation update prevents the error and offers workarounds other than disabling the terraform_valdiate hook.

@mbainter please confirm that this PR is ready to be merged or do you want to add something else?
Thanks a lot for this PR!

I'm guessing those emoji responses didn't generate any notifications for you - but this is fine by me if you're happy with it.  I can squash these two commits together now to clean up the history or you can when you merge it - up to you.

@mbainter Thank you. You are right, emojis are nice but not they don't produce any notifications in my inbox. :)

This PR is included in version 1.63.0 :tada:

I cannot for the life of me get the exclude directive to work as expected for the root of the repo

The example listed throws an error. This ^([^/])+$ seems to work with identity but it doesn't stop terraform from running in the wrong dir with terraform_validate


patch post api usage

Fixed an incorrect api usage of during a POST request which could prevent POST data from being sent to the remote.

Thanks a lot!


Fix a race condition that could allow same Salt/IV to be reused

If the attacker have precise timing, it could be possible for it to trick ss into accept multiple connection with the same Salt/IV if they all pass the Salt/iv test at the same time if while other connection c.Encrypter(salt) is in process, and before they add that IV into the anti-replay pool.
This PR does not solve any protocol weakness.

Thanks for the PR! :)


Class-based WebSocket views

Is your feature request related to a problem? Please describe.
Writing WebSocket views feels kind of cumbersome and perhaps error-prone: we need to accept and close the connection ourselves, surround with try/except to handle exceptions, and handle some of them ourselves. For example, making sure some piece of code gets executed when the client disconnects is not straight-forward.
We also don't have any inheritance mechanism as is provided by class-based views for HTTP.
Describe the solution you'd like
WebSocket view lifecycle:

before_connect
on_connect
handle
on_disconnect

Convert these into callbacks that allow to perform specific actions while preventing some typical logic flaws.
User errors should be caught and dealt with in .handle() directly. We should also catch WebSocketDisconnect errors if necessary.
The generated view would look like this:
async def view(ws: WebSocket):
    try:
        await before_connect(ws)
        async with ws:
            await on_connect(ws)
            await handle(ws)
    finally:
        await on_disconnect(ws)

Example usage on the chat example:
from bocadillo import API

api = API()

@api.websocket_route("/chat")
class Chat:
    clients = set()
    history = []

    async def on_connect(self, ws: WebSocket):
        self.clients.add(ws)
        for message in self.history:
            await ws.send(message)

    async def handle(self, ws: WebSocket):
        async for message in ws:
            self.history.append(message)
            if message["type"] == "message":
                for client in self.clients:
                     await client.send(message)

    async def on_disconnect(self, ws: WebSocket):
        self.clients.remove(ws)

Note:

It is still possible to reject connection requests by performing checks in before_connect().
We keep value_type etc in the websocket_route because these are properties of the WebSocket object, not the view itself.

Class-based views would unlock the power of inheritance: we could build "generic views" that provide behavior for common use cases. For example, we could build a generic WebSocket view that listens to a message's type and calls an appropriate handler declared on the class, e.g. on_message() for the above. This would be similar to socket.io but more lightweight. Another idea would be to add automatic client tracking, and provide utilities such as .send_all().
Describe alternatives you've considered
/
Additional context

Chat example (docs)

There's isn't a pressing need for this feature at the moment I believe. We'll see in the future if this becomes interesting to implement!


Add note that django-query-builder requires Postgres

The requirements section of the readme does not list Postgres which is a requirement.

@hekevintran thanks for pointing that out. The docs now list postgres as a requirement.


Reload an exported glTF model, its vertex winding and node transform are incorrect.

Repro

Bug repro on https://playground.babylonjs.com/#CZQA3A:

vs

var delayCreateScene = function () {

    var scene = new BABYLON.Scene(engine);
    let fanDescendants;
    BABYLON.SceneLoader.ImportMesh(
        null,
        "/Playground/scenes/",
        "fileName.glb",
        scene,
        function (meshes) {
            scene.createDefaultCameraOrLight(true, true, true);
            scene.createDefaultEnvironment();
            console.log(meshes[0].position);
            fan = meshes[0];
            fan.position.x = 20;
            fanDescendants = fan.getDescendants(false);
            console.log(fanDescendants);
    });

    return scene;
};

Expected result:

The glTF model which is exported from glTFExported should match to the original glTF model.

Current result:

The glTF model after exporting will have wrong vertex winding and the attached node transform is wrong.
Screenshots
The screenshot after loading from glTFLoader

The screenshot after loading from an exported glTF model

Desktop (please complete the following information):

OS: [e.g. iOS] Mac OS
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] Version 95.0.4638.69

Additional context
Per my investigation, I notice BabylonJS uses left-handed coordinate system and glTF model is right-handed system, so we transform its root node at glTFLoader.ts. However, in glTFExporter, we didn't invert the transform correctly. We are supposed to transform back from left to right handed system when exporting. After adding glTFNode.scale = [1, 1, 1]; at glTFExporter.ts, the vertex winding issue is resolved at least. I need to dig into more about how to correct the root transform when applying attached nodes.

Adding @bghgary
(Please also note that we state really clearly in the template that we expect you to have a discussion on the forum first)

Yup, looks like a bug. You can workaround it by setting the scene to right handed for now.
https://playground.babylonjs.com/#CZQA3A#1


Update labeled value component in PD

Acceptance criteria

Labels for this component are now bold and Aa case
Update the labeled value component that displays pipette information on the file details page

Design

@howisthisnamenottakenyet Should form labels have the same style?

@umbhau Decided on no. In PD there's a bunch of form fields all packed together and I think that'd make it look more cluttered.

@howisthisnamenottakenyet sounds good.
To summarize:

Value labels will be in Title Case, e.g. "Left Pipette"
Field labels will be in Sentence case, e.g. "Tip rack"
Field 'category headers' (?) will be in SMALL CAPS, e.g. "TECHNIQUE", "CHANGE TIP", and "FLOW RATE"

Is that right?

@umbhau yup! I updated the component pages for form fields and labeled values in zeplin to reflect that

How does this affect Run App? Not sure if I'm following

@IanLondon The component for pipettes in the run app calibration flow is the same as ours for file details

@howisthisnamenottakenyet Double-checking: this is just changing the LabeledValue component instances inside the pipette group component (called InstrumentGroup), and NOT changing all LabeledValues across PD + Run App, right?


README.md: Remove descriptions of the unimplemented API + random fixups.

Signed-off-by: Philip Tricca<EMAIL_ADDRESS>

resolved in 86f7f44cc98f2f4a0d142f7f8c83245c7983f032


214 change add project form state managmant

I added new state management to useForm and Zod validations.
Added translations for the modal as well.
The form is not 100% done but this pr is focused on changing the state of the form.

The form can be submitted (your ide console should print the data after the form is submitted) but right now there is no UI feedback to the user.
Also fixed the direction of the form according to the language


[EXAMPLES] Added more current model  (Yolov5s) example to the tensorflow object detection lineup

I added a Yolov5s example to the examples repository (including model and labels), because the inputs/outputs are quite different than mobilenet and detectnet the scripts had to be adjusted quite a bit, so i thought it warranted a new example. Its pretty self contained so there are no extra requirements (other than what you would need for the examples that already exist).
I tested this on the raspberry pi 5 with the camera module v3.

Hi, thanks for this example. It looks like a nice and simple self-contained demo, so it would be nice to merge it.
A few things to sort out first. Could you check the contribution guidelines? I don't think there will be too much, but I'm sure it will want some cosmetic changes. We should also target it at the "next" branch, and make sure it's signed off.
One extra thing to think about. The use of the RGB888 lores stream means it will only work on a Pi 5. Is there any way to make this work on (for example) a Pi 4? I guess maybe there's just too much computation in which case perhaps we could quit and make it clear what the problem is, maybe
from picamera2 import Platform

and then somewhere
    if Picamera2.platform != Platform.PISP:
        print("Sorry, only supported on Pi 5")
        sys.exit(-1)

or something like that?

Ill read the guidelines, thanks! Thats an excellent suggestion! I added compatibility code so that it should work also on systems that only support YUV420, the colorspace is just converted to RGB888 inside the matrix with numpy/opencv!

These are my test results, the drm overlay doesnt work on my system, but im sure it has nothing to do with the example i added since it fails normally too.
picamera2/tests/test_list.txt']
Running 84 tests

Running tests in /home/zanza/picamera2/tests/test_list_drm.txt
Running /home/zanza/picamera2/examples/overlay_drm.py... 	FAILED
====================    STDOUT    ====================
[78:03:15.950849183] [397953]  INFO Camera camera_manager.cpp:284 libcamera v0.2.0+46-075b54d5
    [78:03:15.961191002] [397958]  INFO RPI pisp.cpp:662 libpisp version v1.0.4 6e3a53d137f4 14-02-2024 (14:00:12)
    [78:03:15.971028838] [397958]  INFO RPI pisp.cpp:1121 Registered camera /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a to CFE device /dev/media0 and ISP device /dev/media1 using PiSP variant BCM2712_C0
    [78:03:15.972371989] [397953]  INFO Camera camera_manager.cpp:284 libcamera v0.2.0+46-075b54d5
    [78:03:15.981477675] [397961]  INFO RPI pisp.cpp:662 libpisp version v1.0.4 6e3a53d137f4 14-02-2024 (14:00:12)
    [78:03:15.991434623] [397961]  INFO RPI pisp.cpp:1121 Registered camera /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a to CFE device /dev/media0 and ISP device /dev/media1 using PiSP variant BCM2712_C0
    [78:03:15.994406370] [397953]  INFO Camera camera.cpp:1183 configuring streams: (0) 640x480-XBGR8888 (1) 1536x864-BGGR16_PISP_COMP1
    [78:03:15.994522148] [397961]  INFO RPI pisp.cpp:1405 Sensor: /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a - Selected sensor format: 1536x864-SBGGR10_1X10 - Selected CFE format: 1536x864-PC1B
    Exception in thread Thread-2 (thread_func):
    Traceback (most recent call last):
      File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.11/threading.py", line 975, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/lib/python3/dist-packages/picamera2/previews/null_preview.py", line 29, in thread_func
        callback(picam2)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 83, in handle_request
        picam2.process_requests(self)
      File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1278, in process_requests
        display.render_request(display_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 74, in render_request
        self.render_drm(self.picam2, completed_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 153, in render_drm
        raise RuntimeError("Failed to reserve DRM plane")
    RuntimeError: Failed to reserve DRM plane
    Traceback (most recent call last):
      File "/home/zanza/picamera2/examples/overlay_drm.py", line 20, in <module>
        picam2.set_overlay(overlay)
      File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1781, in set_overlay
        self._preview.set_overlay(overlay)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 120, in set_overlay
        self.render_drm(self.picam2, None)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 153, in render_drm
        raise RuntimeError("Failed to reserve DRM plane")
    RuntimeError: Failed to reserve DRM plane

Running /home/zanza/picamera2/examples/preview_drm.py... 	ERROR
	     raise runtimeerror("failed to reserve drm plane")
Running /home/zanza/picamera2/tests/drm_stop_restart.py... 	TIMED OUT
====================    STDOUT    ====================
[78:03:23.478478009] [397987]  INFO Camera camera_manager.cpp:284 libcamera v0.2.0+46-075b54d5
    [78:03:23.487299936] [397992]  INFO RPI pisp.cpp:662 libpisp version v1.0.4 6e3a53d137f4 14-02-2024 (14:00:12)
    [78:03:23.496893697] [397992]  INFO RPI pisp.cpp:1121 Registered camera /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a to CFE device /dev/media0 and ISP device /dev/media1 using PiSP variant BCM2712_C0
    [78:03:23.498119904] [397987]  INFO Camera camera_manager.cpp:284 libcamera v0.2.0+46-075b54d5
    [78:03:23.506980145] [397995]  INFO RPI pisp.cpp:662 libpisp version v1.0.4 6e3a53d137f4 14-02-2024 (14:00:12)
    [78:03:23.516855333] [397995]  INFO RPI pisp.cpp:1121 Registered camera /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a to CFE device /dev/media0 and ISP device /dev/media1 using PiSP variant BCM2712_C0
    [78:03:23.524566146] [397987]  INFO Camera camera.cpp:1183 configuring streams: (0) 640x480-XBGR8888 (1) 1536x864-BGGR16_PISP_COMP1
    [78:03:23.524695609] [397995]  INFO RPI pisp.cpp:1405 Sensor: /base/axi/pcie@120000/rp1/i2c@88000/imx708@1a - Selected sensor format: 1536x864-SBGGR10_1X10 - Selected CFE format: 1536x864-PC1B
    Exception in thread Thread-2 (thread_func):
    Traceback (most recent call last):
      File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.11/threading.py", line 975, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/lib/python3/dist-packages/picamera2/previews/null_preview.py", line 29, in thread_func
        callback(picam2)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 83, in handle_request
        picam2.process_requests(self)
      File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1278, in process_requests
        display.render_request(display_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 74, in render_request
        self.render_drm(self.picam2, completed_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 153, in render_drm
        raise RuntimeError("Failed to reserve DRM plane")
    RuntimeError: Failed to reserve DRM plane
    Exception in thread Thread-3 (thread_func):
    Traceback (most recent call last):
      File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.11/threading.py", line 975, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/lib/python3/dist-packages/picamera2/previews/null_preview.py", line 29, in thread_func
        callback(picam2)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 83, in handle_request
        picam2.process_requests(self)
      File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 1278, in process_requests
        display.render_request(display_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 74, in render_request
        self.render_drm(self.picam2, completed_request)
      File "/usr/lib/python3/dist-packages/picamera2/previews/drm_preview.py", line 153, in render_drm
        raise RuntimeError("Failed to reserve DRM plane")
    RuntimeError: Failed to reserve DRM plane

Running tests in /home/zanza/picamera2/tests/test_list.txt
Running /home/zanza/picamera2/examples/capture_circular_nooutput.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_dng.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_dng_and_jpeg.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_dng_and_jpeg_helpers.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_full_res.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_headless.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_helpers.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_mjpeg.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_old_request.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_png.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_to_buffer.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_video.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_video_multiple.py... 	PASSED
Running /home/zanza/picamera2/examples/capture_video_multiple_2.py... 	PASSED
Running /home/zanza/picamera2/examples/controls.py... 	PASSED
Running /home/zanza/picamera2/examples/controls_2.py... 	PASSED
Running /home/zanza/picamera2/examples/display_transform_qtgl.py... 	PASSED
Running /home/zanza/picamera2/examples/dual_encode.py... 	PASSED
Running /home/zanza/picamera2/examples/easy_capture.py... 	PASSED
Running /home/zanza/picamera2/examples/easy_video.py... 	PASSED
Running /home/zanza/picamera2/examples/exif_custom.py... 	PASSED
Running /home/zanza/picamera2/examples/exposure_fixed.py... 	PASSED
Running /home/zanza/picamera2/examples/frame_server.py... 	PASSED
Running /home/zanza/picamera2/examples/h264_constant_qp.py... 	PASSED
Running /home/zanza/picamera2/examples/metadata.py... 	PASSED
Running /home/zanza/picamera2/examples/mp4_capture.py... 	PASSED
Running /home/zanza/picamera2/examples/opencv_face_detect_2.py... 	PASSED
Running /home/zanza/picamera2/examples/opencv_mertens_merge.py... 	PASSED
Running /home/zanza/picamera2/examples/overlay_gl.py... 	PASSED
Running /home/zanza/picamera2/examples/overlay_null.py... 	PASSED
Running /home/zanza/picamera2/examples/overlay_qt.py... 	PASSED
Running /home/zanza/picamera2/examples/pick_mode.py... 	PASSED
Running /home/zanza/picamera2/examples/preview.py... 	PASSED
Running /home/zanza/picamera2/examples/preview_x_forwarding.py... 	PASSED
Running /home/zanza/picamera2/examples/raw.py... 	PASSED
Running /home/zanza/picamera2/examples/rotation.py... 	PASSED
Running /home/zanza/picamera2/examples/still_capture_with_config.py... 	PASSED
Running /home/zanza/picamera2/examples/still_during_video.py... 	PASSED
Running /home/zanza/picamera2/examples/switch_mode.py... 	PASSED
Running /home/zanza/picamera2/examples/switch_mode_2.py... 	PASSED
Running /home/zanza/picamera2/examples/switch_mode_persist.py... 	PASSED
Running /home/zanza/picamera2/examples/timestamp_capture.py... 	PASSED
Running /home/zanza/picamera2/examples/title_bar.py... 	PASSED
Running /home/zanza/picamera2/examples/tuning_file.py... 	PASSED
Running /home/zanza/picamera2/examples/video_with_config.py... 	PASSED
Running /home/zanza/picamera2/examples/window_offset.py... 	PASSED
Running /home/zanza/picamera2/examples/zoom.py... 	PASSED
Running /home/zanza/picamera2/tests/app_dual.py... 	SKIPPED
Running /home/zanza/picamera2/tests/app_full_test.py... 	PASSED
Running /home/zanza/picamera2/tests/app_test.py... 	PASSED
Running /home/zanza/picamera2/tests/autofocus_test.py... 	PASSED
Running /home/zanza/picamera2/tests/async_test.py... 	PASSED
Running /home/zanza/picamera2/tests/bitrate_check.py... 	PASSED
Running /home/zanza/picamera2/tests/check_timestamps.py... 	PASSED
Running /home/zanza/picamera2/tests/close_test.py... 	PASSED
Running /home/zanza/picamera2/tests/close_test_multiple.py... 	SKIPPED
Running /home/zanza/picamera2/tests/codecs.py... 	PASSED
Running /home/zanza/picamera2/tests/colour_spaces.py... 	PASSED
Running /home/zanza/picamera2/tests/config_with_sensor.py... 	PASSED
Running /home/zanza/picamera2/tests/configurations.py... 	PASSED
Running /home/zanza/picamera2/tests/context_test.py... 	PASSED
Running /home/zanza/picamera2/tests/display_transform_null.py... 	PASSED
Running /home/zanza/picamera2/tests/display_transform_qt.py... 	PASSED
Running /home/zanza/picamera2/tests/easy_video2.py... 	PASSED
Running /home/zanza/picamera2/tests/encoder_start_stop.py... 	PASSED
Running /home/zanza/picamera2/tests/ffmpeg_abort.py... 	PASSED
Running /home/zanza/picamera2/tests/large_datagram.py... 	PASSED
Running /home/zanza/picamera2/tests/mjpeg_server.py... 	PASSED
Running /home/zanza/picamera2/tests/no_raw.py... 	PASSED
Running /home/zanza/picamera2/tests/null_encoder.py... 	PASSED
Running /home/zanza/picamera2/tests/mode_test.py... 	PASSED
Running /home/zanza/picamera2/tests/multicamera.py... 	SKIPPED
Running /home/zanza/picamera2/tests/multicamera_2.py... 	SKIPPED
Running /home/zanza/picamera2/tests/preview_cycle_test.py... 	PASSED
Running /home/zanza/picamera2/tests/preview_location_test.py... 	PASSED
Running /home/zanza/picamera2/tests/preview_start_stop.py... 	PASSED
Running /home/zanza/picamera2/tests/quality_check.py... 	PASSED
Running /home/zanza/picamera2/tests/qt_gl_preview_test.py... 	PASSED
Running /home/zanza/picamera2/tests/stop_slow_framerate.py... 	PASSED
Running /home/zanza/picamera2/tests/allocator_test.py... 	PASSED
Running /home/zanza/picamera2/tests/allocator_leak_test.py... 	PASSED

Hi again, thanks for the updates. I'm very nearly good to merge - just two final things!

Could you squash your commits together into one? I think it would be tidier and it would be easier for folks to understand if there's just a single commit which has everything correct.
I couldn't get OpenCV to build using pip3 install opencv-python=<IP_ADDRESS>. I tried a completely clean up-to-date image with all updates applied, but it failed saying that it couldn't build numpy. Instead if I used sudo apt install python3-opencv before making the venv, it was fine. Should we amend the instructions?

Thanks!

Hi again, thanks for the updates. I'm very nearly good to merge - just two final things!

Could you squash your commits together into one? I think it would be tidier and it would be easier for folks to understand if there's just a single commit which has everything correct.
I couldn't get OpenCV to build using pip3 install opencv-python=<IP_ADDRESS>. I tried a completely clean up-to-date image with all updates applied, but it failed saying that it couldn't build numpy. Instead if I used sudo apt install python3-opencv before making the venv, it was fine. Should we amend the instructions?

Thanks!

I've done both of those, as for the requirements, i think i just had that text in the file from before, theres no reason why the version would be pinned to that and why PIL was needed, so i removed the version requirement and set it to be headless (since imshow is never used, and picamera2's gui is used for previewing). Also added instructions for how to install on system python

Thank you very much!!


wait() messes with DecimalNumber position in updater

Description of bug / unexpected behavior

In the tutorial Manim's building blocks, section Animations subsection Creating a custom animation, in the scene CountingScene, the updater which is supposed to center the number doesn't work (see the animation rendered on the page).
Expected behavior

The updater (lambda number: number.move_to(ORIGIN)) does not work until the play() animation is finished. Weirdly enough, removing the first self.wait() solves the problem.
How to reproduce the issue

Code for reproducing the problem, copy pasted from the tutorial page
from manim import *

class Count(Animation):
    def __init__(self, number: DecimalNumber, start: float, end: float, **kwargs) -> None:
        # Pass number as the mobject of the animation
        super().__init__(number,  **kwargs)
        # Set start and end
        self.start = start
        self.end = end

    def interpolate_mobject(self, alpha: float) -> None:
        # Set value of DecimalNumber according to alpha
        value = self.start + (alpha * (self.end - self.start))
        self.mobject.set_value(value)

class CountingScene(Scene):
    def construct(self):
        # Create Decimal Number and add it to scene
        number = DecimalNumber().set_color(WHITE).scale(5)
        # Add an updater to keep the DecimalNumber centered as its value changes
        number.add_updater(lambda number: number.move_to(ORIGIN))

        self.add(number)

        self.wait()

        # Play the Count Animation to count from 0 to 100 in 4 seconds
        self.play(Count(number, 0, 100), run_time=4, rate_func=linear)

        self.wait()

Additional media files

MP4 file

After removing the first self.wait():
https://github.com/user-attachments/assets/1f9eed72-32b6-48f6-90ee-5070c7b94519

Hello, we've tried to reproduce the problem but could not successfully find any differences between having wait() and not, would you be able to clarify the issue?


Nightly build failure on Windows

Starting from Jan.11, the nightly build started to fail. (commit: 61763fa)
See https://dev.azure.com/pytorch/778b86d3-09b9-4636-a34b-315646862684/_apis/build/builds/18418/logs/122.

This error still happens, when activating pytorch...
Python 3.8.10 (default, May 26 2023, 14:05:08)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import torch
torch._custom_ops
Traceback (most recent call last):
File "", line 1, in
AttributeError: module 'torch' has no attribute '_custom_ops'

The code that is generatated when creating a wheel for pytorch vision, uses torch._custom_ops which should be, I understand, torch._C?
torchvision-0.15.0%2B0b41ff0-cp38-cp38-linux_aarch64.whl#sha256=ad8d24697eb2bfdcf4f4a7205433b0b66fa47723162040952e748b1cd8966955


Base model

Combine functionality shared across models. @pzhanggit I wasn't exactly sure how to separate the graph layer initialization from the multi-head init, but I think this moves in the direction we discussed. Kind of the same thing, should we have forward propagation functions with and without multi-heads?

Combine functionality shared across models. @pzhanggit I wasn't exactly sure how to separate the graph layer initialization from the multi-head init, but I think this moves in the direction we discussed. Kind of the same thing, should we have forward propagation functions with and without multi-heads?

@streeve  Not sure either. Could we do something like define a class with GNN structures only, without forward propagation and loss etc.  and then use it as a layer before the multi-head part where we define the model with init, forward and loss?

@streeve do you want me to approve the merge request?

This is not ready to merge - I need to fix some mistakes

I updated with new tests across all models after I realized in the initial version I didn't correctly inherit from the new base class for anything but PNN, but it passed anyway since we didn't test the other model types.

@pzhanggit this is ready for review, but won't pass tests at least until #27 is merged

Okay @allaffa @pzhanggit this is ready for final review. I'm ready to merge if you approve


<EMAIL_ADDRESS>Openssl Problem

Description
I installed glances using brew install glances.
But once tapped glances on shell, it emitted:

ImportError<EMAIL_ADDRESS>2): Library not loaded<EMAIL_ADDRESS>
It seems to be openssl's version problem still, I tried to change $PATH but it didn't work.  I don't know how to fix it. My machine has several versions of python and theirs dependencies like openssl, which exists in /usr/local/Cellar/, use/bin/ and /usr/local/opt/.  But I really don't  know the calling  connection.  Can anyone teach me how to manage them, Please?
Versions

Darwin Kernel Version 19.6.0

Logs
----------:  Search glances.conf file in /usr/local/etc/glances/glances.conf
WARNING:  PsUtil can not grab processes io_counters ('Process' object has no attribute 'io_counters')

glances.log

Hi @haotianmichael, thanks for opening this issue.
This seems to be a very specific issue on how homebrew decides to do the plumbing to overlay your system library and frameworks with the ones installed via homebrew.
It seems like the issue might be complicated by a potential failure in dependency tracking.
Anyway you would be best served by asking this question in the homebrew support channels, as there is very little that we can offer on these matters!

Please consider closing this issue, and including a link to the issue or mailing list to which you will forward your question, so other users encountering a similar problem could follow your issue and find relevant answers.

Please consider closing this issue, and including a link to the issue or mailing list to which you will forward your question, so other users encountering a similar problem could follow your issue and find relevant answers.

Thanks for your answer!  But I found  libssl.1.0.0.dylib is also in<EMAIL_ADDRESS>which was exactly the same in /usr/local/Cellar/openssl/1.0.2s/libssl.1.0.0.dylib.  Is this normal?  I don't remember  if it was me who changed that content... Sorry for that. I forgot why. But if libssl.1.1.dylib should have been there, is it Recommended to reinstall<EMAIL_ADDRESS>through brew despite its warnning:

Error: Refusing to uninstall<EMAIL_ADDRESS>because it is required by  pygobject3, python, python@2, <EMAIL_ADDRESS>( almost 30 softwares listed ) which are currently installed.
You can override this and force removal with:
brew uninstall --ignore-dependencies<EMAIL_ADDRESS>

These are questions for the homebrew developers.  OpenSSL does not install this way by default.

Sorry, But I mean that maybe it's neither brew nor openssl's fault, maybe it's me who exchanged the lib for some reason.....Can you send me a link where I can  download the built version to check.

We don't release binaries, only source.
On www.openssl.org you can find the official release tarballs, which contain the instructions on how to compile.
But in this case, if you want to avoid to complicate the situation further, I would advise not to install from source, and instead contact the homebrew support channels to figure out how to restore your homebrew install to a proper state.
Seems like something went wrong there, and installing from source without following homebrew recipes and dependencies will probably make things worse.

OK, I' will send a link here once I forward a issue to brew, then I'll  close this one. Again Thanks for your time!


fix(mis-server): 修复导入用户功能在获取集群中已有用户时，有账户没有用户的情况时报错的问题

导入用户功能需要首先获取集群中已有的用户，获取已有用户是通过slurm.sh -l all获取的。这个命令在发现一个没有用户的账户时会有以下输出，之前没有处理。
a_t2
There is no user in account !

Codecov Report
Base: 64.46% // Head: 64.47% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (30e4fc6) compared to base (db7450f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   64.46%   64.47%   +0.01%
==========================================
  Files         103      103
  Lines        2910     2911       +1
  Branches      364      366       +2
==========================================
+ Hits         1876     1877       +1
  Misses        990      990
  Partials       44       44

Impacted Files
Coverage Δ

apps/mis-server/src/utils/slurm.ts
95.83% <100.00%> (+0.18%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

在这种情况下，就会导入一个没有用户的账户，scow中允许没有用户的账户存在吗？

在这种情况下，就会导入一个没有用户的账户，scow中允许没有用户的账户存在吗？

不允许，已修改，获取已有账户用户时会忽略没有用户的账户


Drilldown not working with require or import (ES6)

Hi!
First of all thanks for the great work on this lib, i really appreciate it!
I have tried everything i can think of to make the drilldown work with a pie chart, but its not possible no mather how i try. Here is my code for the import section:
const Highcharts = require('highcharts')
const ReactHighcharts = require('react-highcharts')
const highchartsData = require('highcharts-data')

const higchartsDrilldown = require('highcharts-drilldown')

then later i try to
  class Chart extends Component {

  componentDidMount () {
    highchartsData(Highcharts)
    higchartsDrilldown(Highcharts)
  }

  componentWillUnmount () {
    this.chart.destroy()
  }

  render () {
    return (
      <div className='chart__chart-item'>
        <Highcharts config={this.props.config} callback={() => console.log('callback test from HChart')} />
      </div>
    )
  }
}

Chart.propTypes = {
  config: PropTypes.object.isRequired
}

export default Chart

The config is provided by a parent component and follows the standard structure from Highcharts website. I have a pie chart with som drilldowns. Does anyone know if this is a known bug?
Feel a bit weird that something as simple as importing a js lib has gotten harder to do with the new syntax(s), am i missing something obvious here?

update: i have also tried to follow this: (http://stackoverflow.com/questions/36942613/highcharts-drilldown-not-working-when-module-is-imported-react) example, it doesnt work either...

Hey Rasmus, really sorry it gives you trouble.
Have you tried applying the lib right away?
const Highcharts = require('highcharts');
const ReactHighcharts = require('react-highcharts');
const highchartsData = require('highcharts-data');

const higchartsDrilldown = require('highcharts-drilldown');
higchartsDrilldown(Highcharts);

My guess is that you're currently doing it too late.

I will give that a try, thank you!

Hi!
Unforthunately it doesnt work, i've ran into another problem instead.
When using the follwing requires:
const Highcharts = require('highcharts')
const ReactHighcharts = require('react-highcharts')
const HighchartsDrilldown = require('highcharts-drilldown/drilldown.js')
HighchartsDrilldown(Highcharts)

To following error is received:
drilldown.js:17 Uncaught ReferenceError: Highcharts is not defined

Update: i also tried,
var Highcharts = require('highcharts')
window.Highcharts = Highcharts
const ReactHighcharts = require('react-highcharts')
const HighchartsDrilldown = require('highcharts-drilldown/drilldown.js')
HighchartsDrilldown(Highcharts)

Then i get error:
drilldown.js:1Uncaught ReferenceError: HighchartsAdapter is not defined(…)
This is very strange...

var Highcharts = require('highcharts')
const ReactHighcharts = require('react-highcharts')
console.log(Highcharts);
console.log(ReachHighcharts);

Hi!
Its actually working now, im using:
var Highcharts = require('highcharts')
const ReactHighcharts = require('react-highcharts')
const HighchartsDrilldown = require('highcharts/modules/drilldown')
HighchartsDrilldown(Highcharts)
its not working with external package 'highcharts-drilldown'

Thanks, make sense

For those who uses ReactHighcharts:
HighchartsDrilldown(ReactHighcharts.Highcharts);


Updates to validating with Rego and CEL

This PR adds more validation features to Genval.

Validation of Kubernetes resource manifests with Rego policies
Validation of Terraform .tf resource files  with rego policies -  closes #8
Validation of Kubernetes resource manifests with CEL policies. -  Closes #11
Adds helper mode --showjson to show JSON representation of the input, this would help users write custom Rego/CEL policies. Closes #10
Now Genval can validate/generate multiple Kubernetes/CRDs config files in cue mode. The generated manifests will be stored in ./output directory. - Coses #9

@MrAzharuddin

@santoshkal , resolve the conflicts please

@santoshkal , resolve the conflicts please

got some conflicts, Please resolve and getback with the above mentioned changed required.

@MrAzharuddin @devopstoday11
Resolved the conflicts and is now ready to be merged.

@santoshkal , Please move the build file to root and make it executable anywhere. Instead of ./genval , This should be genval [Command]

Update the Makefile path for genval executable to cwd instead of ./bin/genval currently.
Thanks!


it might be a typo

There are some countries in the world using "custome" instead of "custom". And I was having errors when applying this library and then realise that in index.js there are instead of "customSiteTitle", there are "customeSiteTitle". I would be glad if this bit of information is helpful to anyone seeing this issue.

I never noticed that when I forked the project; probably as it looks to only be customeSiteTitle internally  and all external APIs are expecting customSiteTitle. Not sure how it caused you issues but it is inconsistent to say the least. I fixed the type-o here (8b68ccdef680fdc47665f9a7c8831431b09747b0) and will get it in the next release.
Sorry for the very very late response I changed jobs at the top of the year and am back to doing C++ work so I let my Node.js projects slide while I was ramping back up on the latest in C++. I'll try to be more responsive going forward.


Html anchor element

Added support for HTMLAnchorElement ().

Removed wiered behaviour in getAttribute.

Thanks!

@christophehurpeau Hello, could you please merge this. Seems there are a lot of dependencies updates from last build of master. Hope we can continue working on library.

Thank you!


Spelling Mistake 'SHH'

... to use Ed25519 SHH keys ...

SHH should be SSH

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fc17b52-0b92-3afb-bdb3-e2e2c226dcae
Version Independent ID: 2f237d65-0e67-429c-16c3-fe7573e05c44
Content: Can't use Ed25519 SSH keys for Azure Linux VMs - Virtual Machines
Content Source: support/azure/virtual-machines/ed25519-ssh-keys.md
Service: virtual-machines
GitHub Login: @genlin
Microsoft Alias: genli

@Viajaz  Thanks for pointing out the typo. It was fixed now.


Installation error with python 3.12

Hello,
I see an error occurred when try to install rxnmapper in python 3.12 environment.
pip install rxnmapper
It seems like rxnmapper requires pytorch >=1.5.0,<2.1, while pytorch only supports python 3.12 staring from v2.4 (https://pytorch.org/blog/pytorch2-4/).
Do you have the plan to upgrade recently? Thanks.

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."

Hi,
I upgraded the package and relaxed this constraint. Can you try installing rxnmapper again (version 0.3.1)?

It works, thanks a lot!


I want to be able to run concurrent threads of the same test

In it's current state the test runs each use case once, randomly one after the other for each application. Instead I want the application to run the same set of scenarios multiple (3-5?) times.
@jeremyf: Feel free to provide more details

There are a few things I would like explored:

There are around 40 specs. Can we run those specs both randomly and concurrently (e.g. 4 specs at a time)
I would like a Jenkins scenario that we can launch which will concurrently run the test suite multiple times (e.g. spawn 2 to 5 test controllers then allow each of them to run the full 40 specs in random order)


BacksolveAdjoint: include calculation of start and stop time gradients

Is it possible to extend the current backsolveadjoint method such that gradients can be calculated for t1 (and t0) as well? I think this should be possible according the referenced paper https://arxiv.org/pdf/1806.07366.pdf.

A PR would be great. In our use case we optimize a stiff ODE problem for the initial values and integration time. Latter can be quite long, hence a memory efficient method to calculate the Jacobian would be interesting.


[BUG] Snapshot policies fail to create/delete snapshots

What is the bug?
Snapshot policies are failing to create or delete snapshots.
I am able to manually create snapshots writing to the same snapshot repos I've specified for the snapshot policies, however the snapshot policies themselves consistently fail to create or delete a snapshot. There is no error message printed to the indicate the cause of the issue and I am unable to locate related logs in any of the OpenSearch cluster logs.
I have 4 different policies with different schedules (hourly, daily, weekly, monthly) all of which are failing.
How can one reproduce the bug?

Register S3 bucket as snapshot repo
Create snapshot policy scheduling snapshots to write to the registered repo
See error when the snapshot policy attempts to create a snapshot

What is the expected behavior?
Snapshots should be created successfully and, if not, some kind of relevant error message should be printed to the output.
What is your host/environment?

OS: AWS managed OpenSearch cluster
2.11
Operating in AWS govcloud environment

Do you have any screenshots?

Do you have any additional context?
No

Were you able to resolve this problem @adamdepollo?
Catch All Triage - 1 2 3 4 5

@dblock No, I would say this is still a problem.
I was only able to figure out why these snapshots were failing after opening a ticket with AWS support. It turned out the problem was my snapshot policies were trying to run snapshots on indexes in cold storage, which cannot be snapshotted.
So technically the snapshot policies were working as expected.
However, I would still say there is an issue here in that there are no useful logs printed to the UI to indicate the cause of the issue. The logs are also not output to any of audit/error logs that are available to customers running AWS-hosted OpenSearch. The only way to identify the problem was to open a support ticket and have support engineers identify the issue.
Perhaps this issue could be updated to more of a feature request for better/more obvious logging on issues with index snapshots.


Expired Content is still added to the sitemaps

it looks like sitemaps are still being generated with content that is expired, this leads to broken pages being set for indexing

Hi! Any updates on this issue?

Hi @benhamino and @MiaHolmberg,
I tried to reproduce this on a clean Alloy demo site, but it seems to work. Which version of EPiServer are you using?

Closing this because of lack of response. Feel free to reopen if needed.


RSDK-8341: log on main thread

Jira ticket
If a user doesn't give their thread the time to log (i.e. the user is using a while loop), the logs will never show since the logs are never being awaited. This fix changes logs so that they are being printed in the main thread, which means that logs aren't dependent on the users.
There is a potential problem with this solution. If someone were to call getLogger() in their thread, then the same problem can occur, so a comment was added to the function.
Tested using both our SDK's complex_module as well as @hexbabe 's module.

7/25/2024, 5:07:32 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 8 log_ts UTC

7/25/2024, 5:07:32 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 7 log_ts UTC

7/25/2024, 5:07:32 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 6 log_ts UTC

7/25/2024, 5:07:22 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 5 log_ts UTC

7/25/2024, 5:07:22 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 4 log_ts UTC

7/25/2024, 5:07:22 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 2 log_ts UTC

7/25/2024, 5:07:22 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 3 log_ts UTC

7/25/2024, 5:07:22 PM info rdk.heart-beat module.py:27 This is a log that should log repeatedly, but does not. Count: 1 log_ts UTC

Testing with my repro: getting the then-invisible logs now with these changes!

This looks good to me, but I will officially approve after all requested changes in and I re-test it with my repro module!

After running into some other issues already with this solution. Here is what I propose
diff --git a/src/viam/logging.py b/src/viam/logging.py
index b61d8ef..3abe1d5 100644
--- a/src/viam/logging.py
+++ b/src/viam/logging.py
@@ -3,6 +3,7 @@ import logging
 import sys
 from copy import copy
 from datetime import datetime
+from threading import Thread, Lock
 from logging import DEBUG, ERROR, FATAL, INFO, WARN, WARNING  # noqa: F401
 from typing import TYPE_CHECKING, Dict, Iterable, List, Optional, Union

@@ -13,28 +14,61 @@ import viam
 if TYPE_CHECKING:
     from .robot.client import RobotClient

-
 LOG_LEVEL = INFO
 LOGGERS: Dict[str, logging.Logger] = {}
 _MODULE_PARENT: Optional["RobotClient"] = None

-class _ModuleHandler(logging.Handler):
-    _parent: "RobotClient"
-    _logger: logging.Logger
+class SingletonEventLoopThread:
+    _instance = None
+    _lock = Lock()
+
+    def __new__(cls):
+        # Ensure singleton precondition
+        if cls._instance is None:
+            with cls._lock:
+                if cls._instance is None:
+                    cls._instance = super(SingletonEventLoopThread, cls).__new__(cls)
+                    cls._instance._loop = None
+                    cls._instance._ready_event = asyncio.Event()
+                    cls._instance._thread = Thread(target=cls._instance._run)
+                    cls._instance._thread.start()
+        return cls._instance
+
+    def _run(self):
+        self._loop = asyncio.new_event_loop()
+        asyncio.set_event_loop(self._loop)
+        self._ready_event.set()
+        self._loop.run_forever()
+
+    def stop(self):
+        if self._loop is not None:
+            self._loop.call_soon_threadsafe(self._loop.stop)
+            self._loop.close()
+
+    def get_loop(self):
+        if self._loop is None:
+            raise RuntimeError("Event loop is None. Did you call .start() and .wait_until_ready?")
+        return self._loop
+
+    async def wait_until_ready(self):
+        await self._ready_event.wait()

+
+class _ModuleHandler(logging.Handler):
     def __init__(self, parent: "RobotClient"):
+        super().__init__()
         self._parent = parent
         self._logger = logging.getLogger("ModuleLogger")
+        self._worker = SingletonEventLoopThread()
         addHandlers(self._logger, True)
-        super().__init__()
         self._logger.setLevel(self.level)

     def setLevel(self, level: Union[int, str]) -> None:
         self._logger.setLevel(level)
         return super().setLevel(level)

-    def handle_task_result(self, task: asyncio.Task):
+    async def handle_task_result(self, task: asyncio.Task):
         try:
             _ = task.result()
         except (asyncio.CancelledError, asyncio.InvalidStateError, StreamTerminatedError):
@@ -49,23 +83,27 @@ class _ModuleHandler(logging.Handler):

         try:
             assert self._parent is not None
-            try:
-                loop = asyncio.get_event_loop()
-                loop.create_task(
-                    self._parent.log(name, record.levelname, time, message, stack), name=f"{viam._TASK_PREFIX}-LOG-{record.created}"
-                ).add_done_callback(self.handle_task_result)
-            except RuntimeError:
-                # If the log is coming from a thread that doesn't have an event loop, create and set a new one.
-                loop = asyncio.new_event_loop()
-                asyncio.set_event_loop(loop)
-                loop.create_task(
-                    self._parent.log(name, record.levelname, time, message, stack), name=f"{viam._TASK_PREFIX}-LOG-{record.created}"
-                ).add_done_callback(self.handle_task_result)
+            loop = self._worker.get_loop()
+            asyncio.run_coroutine_threadsafe(
+                self._asynchronously_emit(record, name, message, stack, time),
+                loop,
+            )
         except Exception as err:
-            # If the module log fails, log using stdout/stderr handlers
             self._logger.error(f"ModuleLogger failed for {record.name} - {err}")
             self._logger.log(record.levelno, message)

+    async def _asynchronously_emit(self, record: logging.LogRecord, name: str, message: str, stack: str, time: datetime):
+        await self._worker.wait_until_ready()
+        task = self._worker.get_loop().create_task(
+            self._parent.log(name, record.levelname, time, message, stack),
+            name=f"{viam._TASK_PREFIX}-LOG-{record.created}",
+        )
+        task.add_done_callback(lambda t: asyncio.run_coroutine_threadsafe(self.handle_task_result(t), self._worker.get_loop()))
+
+    def close(self):
+        self._worker.stop()
+        super().close()
+

 class _ColorFormatter(logging.Formatter):
     MAPPING = {
@@ -76,8 +114,8 @@ class _ColorFormatter(logging.Formatter):
         "CRITICAL": 41,  # white on red bg
     }

-    def __init__(self, patern):
-        logging.Formatter.__init__(self, patern)
+    def __init__(self, pattern):
+        logging.Formatter.__init__(self, pattern)

     def format(self, record):
         colored_record = copy(record)

running into some other issues already with this solution

def _wait_until_worker_running(self, max_attempts=5, timeout_seconds=1):
        """
        Blocks on camera data methods that require the worker to be running.
        Unblocks once worker is running or max number of attempts to pass is reached.

        Args:
            max_attempts (int, optional): Defaults to 5.
            timeout_seconds (int, optional): Defaults to 1.

        Raises:

        """
        cls: Oak = type(self)
        attempts = 0
        while attempts < max_attempts:
            if cls.worker.running:
                return
            time.sleep(timeout_seconds)
            attempts += 1
        raise ViamError(
            "Camera data requested before camera worker was ready. Please ensure the camera is properly "
            "connected and configured, especially for non-integrated models such as the OAK-FFC."
        )

I await this function call in get_image and other APIs that wait for the camera to be ready. Because time.sleep blocks in the main thread, logs are suppressed. I would rather not have to write asynchronous code in these methods.


Gen yaml annotations for flow proto

Please ensure your pull request adheres to the following guidelines:

[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.

Add yaml annotations to generated flow proto as discussed in https://github.com/cilium/cilium/pull/28873#discussion_r1377689955
Requires: https://github.com/cilium/cilium/pull/28943
cc: @chancez @glibsm
Add yaml annotations to generated flow proto.

LGTM. I'll approve after https://github.com/cilium/cilium/pull/28943 is merged and the base image + CI passes.

Can you add justification in the commit msgs for why the changes are needed?

@christarazi Added.

Fine by me, but will unfortunately conflict with #28945. Given both are currently blocked by the Cloudflare outage, let's just see which one gets in first and rebase the other one.

Rebased.

@marqc Can you rebase again. Unfortunately main was broken due to a merge race (c.f. https://github.com/cilium/cilium/pull/28745). Thanks!

/test

/test

Travis took a nap :-(. If this PR doesn't need any more pushes, then a close-and-reopen will do the trick.

/test

I just realized that names generated with this plugin are inconsitent with json tags. This would make a mess in the API. I will close this and instead I will use different YAML parser that works with json tags  sigs.k8s.io/yaml


Update docfx.json

Docs Build status updates of commit 324ae2d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

SP-Framework/docfx.json
:bulb:Suggestion

Details

SP-Framework/docfx.json

Line 48, Column 31: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'spdevdocs' is not a valid Microsoft alias.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


 I assumed since it was in the public headers in Build Phases, I would have access to the definitions (based on this SO post), but apparently not.
I have access to the other definitions in public headers from swift. To illustrate, here's me not having access to PINImage or PINImageView

but then being able to use things like PINRemoteImageCategoryManager

Also, as a follow up, I'm not sure if I should be embedding these Swift extensions in the PINRemoteImage framework, or if it should be in a new PINRemoteImageSwift framework. Two reasons:

If this goes through, I think everyone using PINRemoteImage.framework will have to ship the swift runtime with their applications
anyone importing PINRemoteImage will have access to both the pin. namespace, and the pin_ prefixed methods. To rectify this in one target, we'd need to add deprecation warnings to the namespace functions.

Right now, to me, making a second target makes more sense (albeit more complicated 😕). But I'll wait until I hear from a contributor to go either way 😊

@AndrewSB issue number one you point out is a no-go for me simply because it would make it so we can't use the framework here at Pinterest.
(sorry for the lack of response on this so far, we've been super busy over here the last few weeks)

Don't sweat it at all! Loved all of your work on texture, this PR is
minuscule compared to that 😋
I think I'll go ahead and create a PINRemoteImageSwift framework that just
wraps this library with a more swift focused API.
Would you guys be interested in hosting it under Pinterest/, or would you
rather have me create it under my account?
On Mon, Apr 24, 2017 at 10:15 AM Garrett Moon<EMAIL_ADDRESS>wrote:

@AndrewSB https://github.com/AndrewSB issue number one you point out is
a no-go for me simply because it would make it so we can't use the
framework here at Pinterest.
(sorry for the lack of response on this so far, we've been super busy over
here the last few weeks)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/PINRemoteImage/pull/343#issuecomment-296751942,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo1dG_-cdeK_QVNUJiiX4KykxJ2YaPzks5rzNiEgaJpZM4M3zEF
.

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger

@AndrewSB that might be something we'd consider in the future, but it should definitely start outside of Pinterest. Once it's all ready to go I'd be happy to point to it in the README! And if it's successful and well maintained that might be the time to consider making it an official part of the library.

🚫 CI failed with log

I'm not sure why the build log only contains part of the output, here's what else happened:
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal arm64 /Users/Shared/buildkite/builds/iosf-VMgI1sNHYyXB.dyn.pinadmin.com-1/pinterest/pinremoteimage/Source/Classes/Image Categories/PINImageVIew + Pin.swift
	CompileSwift normal arm64 /Users/Shared/buildkite/builds/iosf-VMgI1sNHYyXB.dyn.pinadmin.com-1/pinterest/pinremoteimage/Source/Classes/Image Categories/Pin.swift
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(3 failures)
A shell task (/usr/bin/xcrun xcodebuild -project /Users/Shared/buildkite/builds/iosf-VMgI1sNHYyXB.dyn.pinadmin.com-1/pinterest/pinremoteimage/PINRemoteImage.xcodeproj -scheme PINRemoteImage -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal arm64 /Users/Shared/buildkite/builds/iosf-VMgI1sNHYyXB.dyn.pinadmin.com-1/pinterest/pinremoteimage/Source/Classes/Image Categories/PINImageVIew + Pin.swift
	CompileSwift normal arm64 /Users/Shared/buildkite/builds/iosf-VMgI1sNHYyXB.dyn.pinadmin.com-1/pinterest/pinremoteimage/Source/Classes/Image Categories/Pin.swift
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(3 failures)

make: *** [carthage] Error 1
Build status: 'pid 4913 exit 2'

FYI, I may use this PR to debug the CI which may mean it posts a lot of build failure comments to it, sorry in advance!

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger

🚫 CI failed with log

The latest build log should be correct.

haha cool, this can be closed then. I'll implement it sometime in the future, and comment on this PR when I think it's ready to go

Cool, thanks!


How to get the list of owners of a given package on nuget.org

@Jericho commented on Wed Mar 14 2018
How can I get the list of owners of a given package hosted in nuget.org? What I'm looking for is the information circled in red in this screenshot:

When I query nuget with the following code, the Owners property is always null. So I'm wondering if there is an alternative?
var providers = new List<Lazy<INuGetResourceProvider>>();
providers.AddRange(NuGet.Protocol.Core.Types.Repository.Provider.GetCoreV3());
var packageSource = new PackageSource("https://api.nuget.org/v3/index.json");
var sourceRepository = new SourceRepository(packageSource, providers);
var nugetPackageMetadataClient = sourceRepository.GetResource<PackageMetadataResource>();
var packageMetadataResult = await _nugetPackageMetadataClient.GetMetadataAsync("Cake.Email", true, true, new Logger(), CancellationToken.None);
var mostRecentPackage = packageMetadataResult
    .OrderByDescending(p => p.Published)
    .First();
var owners = mostRecentPackage.Owners;

@rohit21agrawal commented on Fri Mar 16 2018
@joelverhagen does the v3 feed not send the owners metadata?

@Jericho commented on Tue Mar 20 2018
@joelverhagen can you help me figure out why the Owners property is always null and/or suggest an alternative to get the owners of a given package hosted on nuget.org?

@joelverhagen commented on Tue Mar 20 2018
Hey @Jericho, today there is no official way on NuGet.org to fetch the current list of owners on a package. This is a known shortcoming of our API and (in my own personal opinion) should be improved in the future. I will move this issue to the NuGetGallery repository to track this feature request.

@shishirx34 can you confirm what Priority - 3 means?  Just wondering where this feature lands in amongst the others.  Thanks.

Our priorities are roughly:

Priority 1 means:  will be fixed within a month
Priority 2 means: will be fixed within a few months
Priority 3 means: will be fixed in the near future

Also, there are two ways you can determine a package's owners:

Use the unofficial owners.json API
Use the package's repository signature

The unofficial owners.json API

:warning: This API is unofficial and undocumented. The NuGet team may change it at any time.

There's an unofficial API that lists all packages and their owners: https://nugetprod0.blob.core.windows.net/ng-search-data/owners.json.
The schema is:
[
  [
    "PackageName",
    ["Owner1", "Owner2"]
  ],
  [
    "Newtonsoft.Json",
    ["jamesnk"]
  ],
  ...
]

You should be able to download this JSON blob and figure out the owners of all packages using it. This is what the NuGet search service uses to figure who owns what packages.
Repository Signatures
In the near future, packages on nuget.org will be repository signed. You can use a package's repository signature to determine its owners through the signature's metadata. To do so, you will need to use this code inside of the NuGet.Packaging NuGet package. Let me know if you need help doing that.

This would be awesome or make the owners.json a rest api we can search from! :)

Hello you should be able to use the NuGet client SDK. For example, to find the owners of the package Newtonsoft.Json on nuget.org:
ILogger logger = NullLogger.Instance;
CancellationToken cancellationToken = CancellationToken.None;

SourceRepository repository = Repository.Factory.GetCoreV3("https://api.nuget.org/v3/index.json");
PackageSearchResource resource = await repository.GetResourceAsync<PackageSearchResource>();
SearchFilter searchFilter = new SearchFilter(includePrerelease: true);

IEnumerable<IPackageSearchMetadata> results = await resource.SearchAsync(
    "packageId:Newtonsoft.Json",
    searchFilter,
    skip: 0,
    take: 1,
    logger,
    cancellationToken);

foreach (IPackageSearchMetadata result in results)
{
    Console.WriteLine($"Found package {result.Identity.Id} with owners: {result.Owners}");
}

See:
Search API documentation: https://docs.microsoft.com/en-us/nuget/api/search-query-service-resource#search-result
Search SDK documentation: https://docs.microsoft.com/en-us/nuget/reference/nuget-client-sdk#search-packages

This change has been implemented in PROD. For example:

@joelverhagen Thank you for keeping us in the loop. I confirm that I get ownership info when I search for packages like so:
var logger = NullLogger.Instance;

var providers = new List<Lazy<INuGetResourceProvider>>();
providers.AddRange(NuGet.Protocol.Core.Types.Repository.Provider.GetCoreV3());  // Add v3 API support
var packageSource = new PackageSource("https://api.nuget.org/v3/index.json");
var nugetRepository = new SourceRepository(packageSource, providers);

// Search for multiple packages
var searchTerm = "Cake";
var take = 1000;
var skip = 0;
var filters = new SearchFilter(false)
{
	IncludeDelisted = false,
	OrderBy = SearchOrderBy.Id
};
var nugetSearchClient = nugetRepository.GetResource<PackageSearchResource>();
var searchResult = nugetSearchClient.SearchAsync(searchTerm, filters, skip, take, logger, CancellationToken.None).ConfigureAwait(false).GetAwaiter().GetResult();
Debug.Assert(searchResult.First().Owners != null, "The ownership information is missing when searching for multiple packages");

This is great!
However, I still do not get ownership information when I retrieve a specific package metadata using code similar to the sample I provided back in 2018.
var logger = NullLogger.Instance;

var providers = new List<Lazy<INuGetResourceProvider>>();
providers.AddRange(NuGet.Protocol.Core.Types.Repository.Provider.GetCoreV3());  // Add v3 API support
var packageSource = new PackageSource("https://api.nuget.org/v3/index.json");
var nugetRepository = new SourceRepository(packageSource, providers);

// Retrieve the metadata for a single package
var name = "Cake.Email";
var nugetPackageMetadataClient = nugetRepository.GetResourceAsync<PackageMetadataResource>().GetAwaiter().GetResult();
var packageMetadata = nugetPackageMetadataClient.GetMetadataAsync(name, true, false, new SourceCacheContext(), logger, CancellationToken.None).GetAwaiter().GetResult();
var mostRecentPackage = packageMetadata.OrderByDescending(p => p.Published).First();
Debug.Assert(mostRecentPackage.Owners != null, "The ownership information is missing when retrieving a specific package's metadata");

@Jericho - apologies on the miscommunication of the scope here. The technologies used to enable our various server-side endpoint on NuGet.org vary. For the search results (first sample) we have compute (Azure App Services + Azure Search) so making this change was quick and low risk. The data was already in the search index and we simply populated it in the search JSON.
For the registration "package metadata" endpoint (second sample), it is much harder for us to surface the owners since the backing technology is static, pre-rendered JSON blobs in blob storage. In other words there are literally millions of JSON files on Azure Blob Storage to cover all of the package IDs and versions on NuGet.org. This is not feasible for us to rollout right now unless there is an urgent business/product need for it.
If you'd like ownership information about a specific package ID, I recommend using the first sample with var searchTerm = "packageid:Cake" for an exact match on package ID.


Investigate missing eks coverage in functional tests

Investigate potential missing eks coverage in functional tests.
https://github.com/radius-project/radius/pull/8033 adds dapr to radius installation, but this change requires an eks cluster to be created by following dapr docs. The tests did not catch the scenario. This is not a radius bug.
But we have to decide whether we want our tests to cover basic functionality on all of kind, aks and eks and add tests based on the decision.
AB#13818

@nithyatsu please provide more context on this. We may need an additional team discussion.


Galaxy S4 battery use

Reported by jb1988 on 5 Mar 2014 19:48 UTC
After installing FreeOTP and adding 3 tokens, battery use is severerly impacted when the app is running in the background.
This has been confirmed using GSam Battery Monitor. The app can completely run down the battery overnight on the S4.

Comment by npmccallum on 28 Mar 2014 18:06 UTC
This should be fixed in this commit: [7f02f57572149f243be526788987aced6a6626ba/android].
This should appear in the next release.

Comment by npmccallum on 28 Mar 2014 20:30 UTC
Fix released v1.4 (r13).


fbp-generator: add support for DECLARE statement v2

Differences from v1:
- each generated fbp type has its own type store and the JSONs will be stored in a common type store.
- changed the generated C code, to split the creation of fbp type into functions, creating them recursively.
Now the generator handles the declaration and usage of new types in the FBP itself.
e.g.
DECLARE=MyType:fbp:my-type.fbp
my_node(MyType) OUT -> ...
In the generated C code now, we split the creation of fbp types into functions, creating them recursively.

I'll apply the comments and merge it, thanks for the review!


flutter test host binaries should compile with dart asserts enabled

@a-siva asked me today for us to turn on dart asserts in our hosted flutter test pre-compiled binaries.  He says there are a ton of things they would catch and as long as we compile with -O2 or above they should be relatively fast.
Hopefully I got that right. :)  Please correct me if I'm wrong.
@abarth @chinmaygarde or @jason-simmons are probably the best folks to wire this up.  He mentioned @zanderso would know the right flags if we need help.
Thanks!

The GN flag is dart_debug:
https://github.com/dart-lang/sdk/blob/master/runtime/BUILD.gn#L13
At the moment this sets -O1, but we can bump it to -O2 if needed.

I believe the patch would be to set that arg in this else:
https://github.com/flutter/engine/blob/master/sky/tools/gn#L66
@zanderso or @jason-simmons would you be willing to write the patch to do so?

@jason-simmons looked at this afternoon.  dart_debug defines DEBUG, however our current flutter test host binaries are built optimized with NDEBUG defined.  So we'd either have to swap our flutter test configuration over to using unoptimized (debug) builds or we'd have to create separate "release" vs. "debug" configurations for flutter test (host) binaries.  Neither sound ideal.  Since we're going to rejigger all our testing in a few weeks after merging with the dartlang/sdk repository, lets punt on this for now.  FYI @johnmccutchan

We're using unopt for our host builds now, so this is now something we should be able to do.

This is being tracked in https://github.com/dart-lang/sdk/issues/29458 and hence closing this.