Not working for HTML files

This is not working for HTML files. I am working on an Angular 5 project and it works for TypeScript files, but I don't see my brackets being colorized in Visual Studio Code v1.20.1.

What language does vscode report for these files? It shows in the bottom right corner:

nvm I found the bug, thanks for reporting 👍

You're welcome. Did it break in a future version of Visual Studio Code? I
thought it was working in previous versions.
On Sun, Feb 25, 2018, 3:38 PM CoenraadS<EMAIL_ADDRESS>wrote:

nvm I found the bug, thanks for reporting 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CoenraadS/BracketPair/issues/77#issuecomment-368342457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADcYG0a6lPCnCDxZ9Xq9uJM4gS0Y4RN-ks5tYcTFgaJpZM4SSbZ_
.

I offloaded parsing to an external library so I don't have to maintain it myself. However it means I have less control over certain things.
You can download an older version from https://github.com/CoenraadS/BracketPair/releases in the meantime.

Thanks v0.10.8 works for me for HTML files.

Hopefully its working now, but it requires some configuration changes.
Here is an example config:
    "bracketPairColorizer.consecutivePairColors": [
        [
            "</",
            ">"
        ],
        [
            "<",
            "/>"
        ],
        "<>",
        [
            "Gold",
            "Orchid",
            "LightSkyBlue"
        ],
        "Red"

it not working for vue

Yes Vue is not supported by PrismJS unfortunately. I also would like to support it

that HTML string doesn't work for me in settings.. i'm not really sure what the format of the new pairs is supposed to be...

Could you share the file you are trying to parse, as well as the language associated with it?

I mean specifically with the example "bracketPairColorizer.consecutivePairColors" config you posted and is now in the readme. I get syntax errors in the JSON, including when I add the extra ] (?) i get consecutivePairColors[ 0] is not a string. But I'm really unsure how that formatting is supposed to work.

You may need to update the extension

I tried the new version and the config settings you put, but I still don't see the brackets colorized when using [(ngModel)] in my HTML file. On the old version, it works. I tried adding the rest of the brackets to the consecutivePairColors object with no luck.

Would you find pasting your full settings file?

Yes the Angular parsing may work differently now. I'm not sure PrismJs returns the []'s as punctuation types. I'll take a look at this.

There is some basic attribute support now added. I'm going to close this issue and track further development in https://github.com/CoenraadS/BracketPair/issues/79

Also as a FYI, in v1.0.12 you can now simply use "<>" to partially match "<" "</", "/>" ">"

Hi. Colorization isn't working on HTML for me either. I went to #79 but I'm not using Angular. Would you like me to open another issue or elaborate more here? Thank you.

Yes please open another issue. Post your settings, extension version and some sample code + the language you are using.

I will, thank you. Is the json file supposed to be colorized?

@joshkellough yes

Thanks. I'll have more for you tomorrow.


Remove urllib import (Python3 fix)

import urllib
does not work in Python3. Instead,
import six.moves.urllib_request
imports urllib on Python2 and urllib.request on Python3.

Maybe import six.moves.urllib_request as urllib will be more correct.

Fixed with thanks to @ilya-chistyakov. Sorry for the mixup. It works now in my tests both on Python2 and Python3.

Thanks, that works good.


Add API to set atomic properties of a shared allocation

@wdamon-intel , @MichalMrozek, @smilczar: please review.

Defined it as experimental just to have some flexibility if we find out we need or want to change something. but I would expect to be promoted to standard w/o issues. We can also add it as standard now if we want, so open to suggestions.

Agree with introducing this as an experimental extension.

@wdamon-intel , @MichalMrozek, @smilczar: please review.

Yes, this set of flags clearly covers all combinations of atomic caps, indeed.
note: we also have examples with flags that say 'yes' or 'no' for a given cap on single bit only:
https://spec.oneapi.io/level-zero/latest/core/api.html?highlight=ze_memory_access_cap_flags_t#ze-memory-access-cap-flags-t


Update rules-for-using-pointers.md

Fixed type (it's GWL_HWNDPARENT, not GWL_HWDPARENT).

@tim-weis : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


ci: Update job  test:latest_versions

Since Mender 3.3 all the repos are part of the release tool: the extra flags are not recognized anymore and we can also clean-up the SSH cloning of private repo.

Example of a failing job here.


fix: fix some issues

#1172
#1173
#1174
#1175
#1176
#1181
#1182
#1183
#1185
#1187
#1188
There is a problem with the backend

There is a problem with the backend

I will look into this issue later.


Support Postgres setup without permissions to pg_database or database creation

Feature Suggestion
Skip the call to ensureDatabaseExists for deployments where access is only given to the specific provisioned databases
https://github.com/backstage/backstage/blob/ae501c04dfb57d79e0252a54b8f11e44d84e9acb/packages/backend-common/src/database/DatabaseManager.ts#L208
Possible Implementation
Maybe drive this through a config in backend.database in your app-config.yaml?
Context
We're deployed in a Heroku-like environment where we attach provisioned PG databases which only come with limited permissions to access the specific database in the shared instance. As a result the call to ensureDatabaseExists fails since it attempts to access pg_database. We're able to handle manually provisioning a DB per plugin by utilizing the new DatabaseManager to config a per plugin connection since we don't have permissions to create new DBs on the fly either.

Just FYI, we're been able to workaround this by using an internal DB manager and was hoping to be able to deprecate our internal manager in favor of the upstream one but hit this blocker.

Upvoting, not really possible to deploy to heroku with postgres

Oh I'd missed this ticket! Good thing you upvoted visibly :)
This sounds like it makes total sense. This is where that configuration section is declared.
Maybe a simple ensureExists?: boolean that's default true? For bonus points, perhaps have it both on the root and (when applicable) in the per-plugin sections as an override?
Sounds like a great, small, well delimited contribution. Would any of you be up for it? 🙌

@freben I can look into implementing it, thanks for the feedback!

Great stuff guys 🙌


Update mod_proxy_cluster demo, examples, configurations

close #141

I think it's in a mergeable state, but once we releaase mod_proxy_cluster 2.0, I believe it would be worth it redoing the documentation a bit (there is duplication of information, we could then drop 1.3.x schism, update examples, ...). But that's for sometime in the future...

Thanks @jajik


ADD: Create a Blog Page

I propose to add a new blog page on the website where users can find a detailed tutorial on how to use the services provided by Rentalog.in.
Hey @gauravsingh1281 Please assign this task to me .

hey @gauravsingh1281 my code is ready can i rasie the PR


Adding Footer

Simple footer with Polkadot logo and placeholder for links.

Looks great! we also need to make it responsive for mobile devices. bootstrap has responsive breakpoints. probably we want to style them different for -md breakpoint.

Had to put some bootstrap imports on top of the sass file in order to use mixins for breakpoints.
https://stackoverflow.com/a/49447454


Keyboard shortcut for opening popup in doesn't work in windows

in windows ctrl + e searches google

and ctrl + q doesn't do anything.

I can't get it to work on Mac either.

In Chrome on my Mac, when I visit chrome://extensions, there is no "Keyboard shortcuts" option on the  bottom of the page or anywhere else. I'm on Chrome 66.0.3359.139. Has it moved somewhere else? I have also searched Preferences and looked everywhere else I could think of.
Never mind, I just found it! Please update the configuration page to say:
† - shortcut keys managed by Chrome directly can be changed by going to the chrome://extensions/ page, clicking the menu in the top left corner, and clicking "Keyboard shortcuts".

fixed in #224


Notifying the User

How to show download progress in NotificationBar? Looks like:

Fetch does not support Android Notifications. The FetchListener provides all the information needed to create your own Notifications.


fix: gitee private repo can not clone in jenkins

Which changes (Bug/Feature):

Fixes #184
Special notes for reviewers:
none

Codecov Report

Merging #185 (7a89f3e) into master (5eb9f4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   41.71%   41.71%
=======================================
  Files           4        4
  Lines         163      163
=======================================
  Hits           68       68
  Misses         93       93
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Compiler crash: Stored value type does not match pointer operand type!

When I'm enumerating objects stored in Tuple instances (which are themselves stored in a collection) and possibly breaking out the second enumeration via break, I get a compilation error if the Tuples sizes are not equal.
Consider the following code, using a Crystal 0.19.4 (2016-10-20) compiler :
foo = {
  {1, 2},
  {3, 4, 5},
}

foo.each do |bar|
  bar.each do |value|
    pp value
    break if false
  end
end

The compiler crashes:
Module validation failed: Stored value type does not match pointer operand type!
  store %"(Tuple(Int32, Int32) | Nil)" %141, %"Tuple(Int32, Int32).1"* %144
 %"Tuple(Int32, Int32).1" = type { i32, i32 }Stored value type does not match pointer operand type!
  store %"(Tuple(Int32, Int32, Int32) | Nil)" %188, %"Tuple(Int32, Int32, Int32)"* %191
 %"Tuple(Int32, Int32, Int32)" = type { i32, i32, i32 }
[4307623521] *raise<Exception>:NoReturn +81
[4307623308] *raise<String>:NoReturn +92
[4317117138] *LLVM::Module#verify:Nil +690
[4317113078] *Crystal::CodeGenVisitor#finish:Hash(String, LLVM::Module) +774
[4316341566] *Crystal::Compiler#codegen<Crystal::Program, Crystal::ASTNode+, Array(Crystal::Compiler::Source), String>:(Array(String) | Nil) +1246
[4310405345] *Crystal::Command#build:Crystal::Compiler::Result +161
[4308147034] *Crystal::Command#run:(Array(Crystal::ImplementationTrace) | Array(Crystal::Init::View+:Class) | Array(String) | Bool | Crystal::Compiler::Result | Hash(String, String) | IO::FileDescriptor | Nil) +1594
[4307752614] main +24278

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

I don't know if this issue is related to #3512, but since the message is the same I built crystal from source. Using the same snippet and Crystal 0.19.4+109 [2ce8c24] (2016-11-09), the compiler still crashes but yields a different output:
Assertion failed: (getOperand(0)->getType() == cast<PointerType>(getOperand(1)->getType())->getElementType() && "Ptr must be a pointer to Val type!"), function AssertOK, file Instructions.cpp, line 1083.

The error is not reproducible if I don't use break and/or if the Tuples are the same size, see both examples below:
Same example, without break statement:
foo = {
  {1, 2},
  {3, 4, 5},
}

foo.each do |bar|
  bar.each do |value|
    pp value
  end
end

Compiles and produces:
value # => 1
value # => 2
value # => 3
value # => 4
value # => 5

Same example, with tuples of same size
foo = {
  {1, 2},
  {3, 4}, # now, tuples are the same size
}

foo.each do |bar|
  bar.each do |value|
    pp value
    break if false
  end
end

Compiles and produces:
value # => 1
value # => 2
value # => 3
value # => 4

Reduced:
def foo(x : Int32)
  yield
  1.0
end

def foo(x : Int64)
  yield
  1.0
end

foo(1 || 1_i64) do
  break
end


Confirm that plot boundaries for sorghum crop 2 generated from field scanner coordinates are consistent with those based on RTK GPS

Update: they don't match, so will make new polygons. https://github.com/terraref/computing-pipeline/issues/187#issuecomment-256760060 below:
For reference, we have two sets of polygons

those made by @tingli3 based on gantry measurements (transformed from gantry xy) these are already in BETYdb and can be queried as json here: https://terraref.ncsa.illinois.edu/bety/api/beta/sites?sitename=~Season+2&limit=none&key=
those made by @anfrench, used by @rickw-ward and exported to json by @Mamatemenrs .

(current hypothesis) The reason these differ is that (1) were two row plots and (2) were the same plots after they were a) combined into four row plots, and b) subset to just the inner two rows. (2) should be used for summarizing plot level metrics since they exclude border rows.

[x] @Mamatemenrs please test my hypothesis by comparing and mapping these (similar to the map in https://github.com/terraref/computing-pipeline/issues/187#issuecomment-256248318 but with only the 'Season 2' plots from BETYdb
[x] @tingli3 The next step is to create the BETYdb insert statements for these polygons - they will be listed as new 'sites'. But instead of Plot 123 the sitename field should have Row x Col y (where x and y are integers of the row and column fields).

an alternative would be to do the polygon combining and subsetting the polygons that already exist. If this is easy, go for it. However, these plots have already been defined by @rickw-ward and @anfrench.

FYI (@robkooper and @gsrohde)  this is where we will need to begin combining sites using the geometry field (related to PecanProject/bety#444) ... so if someone queries for plot 1 they can find all contained or intersecting points and polygons. Developing these queries can wait until we have data and more specific use cases.

@anfrench created a shape file that @rickw-ward has been using
sorghumexpfall2016v5.zip
@tingli3 created polygons based on @smarshall-bmr range and row measurements in gantry coordinate systems in https://github.com/terraref/computing-pipeline/issues/174

We should confirm that these are in alignment

[x] @anfrench please provide the shapefile
[ ] polygons for season 2 are here: https://terraref.ncsa.illinois.edu/bety/api/beta/sites?key=9999999999999999999999999999999999999999
[ ] Please confirm that these align, and where we need to handle differences.

how do i read this xml file above?

... it's json but that is all I know, I think the geometries are in WKT format. If you prefer postgis you can import this dump of the database https://terraref.ncsa.illinois.edu/bety/dump/bety.tar.gz and look at the sites table, but it should be very similar (for the record the database dump includes metadata but excludes all of the trait data until we make it public).

Ok , looks like I have some reading to do, WKT isn’t something I know anything about, I tried the ArcGIS JSON conversion tool and it failed. Maybe QGIS will handle more easily.
Since the issue was raised I created one-row polygons. The attached will need to be checked and edited, it has one polygon per one-row plot and includes buffers between plots (but not buffers on the outside).
From: David LeBauer<EMAIL_ADDRESS>Sent: Friday, October 14, 2016 4:12 PM
To: terraref/computing-pipeline<EMAIL_ADDRESS>Cc: French, Andrew<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [terraref/computing-pipeline] Confirm that plot boundaries for season two are consistent with those made by Andy French. (#187)
... it's json but that is all I know, I think the geometries are in WKT format. If you prefer postgis you can import this dump of the database https://terraref.ncsa.illinois.edu/bety/dump/bety.tar.gz and look at the sites table, but it should be very similar (for the record the database dump includes metadata but excludes all of the trait data until we make it public).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/terraref/computing-pipeline/issues/187#issuecomment-253941075, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVfPSfKXrU7WSKoiPpjWdMlzerJSEQuzks5q0AwxgaJpZM4KXgSd.
This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.

@anfrench I think Wasit or Matt can do this, as it will be a good opportunity for them to give me feedback on the data formats and how they can interoperate.

We can work with the shapefile that Rick has been using after it is confirmed. I'll further check with Wasit though.
Thanks.

@Mamatemenrs have you had a chance to compare the data in betydb with the shapefile? It looks like we will need to insert new bounding boxes in the database that correspond to the interior two row subset.

Anyone can confirm what is the coordinate system and datum on the JSON file? I see geographic long/lats, but wondering the datum? Currently, it does not align with the file Rick shared.

@Mamatemenrs I think it is WGS84. Please confirm with @tingli3

@mamatemenrs can you show a map overlaying the two?
@mamatemenrs and/or @tingli3 can you convert the shapefile to a postgis insert statement?

Tried to open the JSON file in QGIS and it only opened part of the shape file, but still able to overlay them somehow. Basically, they don't align.

@Mamatemenrs to start, can you output a version of Ricks shape file that looks like the json file? (Only sitename and geometry fields are necessary)
@smarshall-bmr and @tingli3 can you please try to resolve these differences?

The two sorghum trials have different plot layouts, they will not align. I think there are 8 'ranges' in first one and 7 in the second. What we are going for is season 2 as noted earlier by @dlebauer above. If I knew how betdb works I could see about converting the shape file to json format in scanner coordinates; i created the shp files in UTM zone 12 using WGS84 via proj4 library in R.

Here is JSON format of Rick's file.  projection is UTM zone 12 using WGS84.
Rick_JSON.zip

Shape files of current (10-26-16) sorghum layout at MAC are at: https://drive.google.com/open?id=0B5btztQSCEFxVUZ6SlRHVDBpdWM .
Original file of foundation xyz from USDA RTK is in this zip:
foundation shape file.zip
orthomosaic as geotiff from four weeks ago (NDVI) from UAV flight is at: https://drive.google.com/open?id=0B5btztQSCEFxYjZDTzJwWkctVWM
When I put all of the above in a QGIS project, all features align.  Note the plot polygons would not align with the first sorghum crop of this year (April to July).

@rickw-ward et al

I think that the shape files Rick linked to above are the same listed in my original task description.
The foundation points are an additional data set that would be useful to archive with metadata ( @craig-willis )
I believe that the plots in the image above labeled "David" are from season 1.

We need something similar for season 2, which should be available at http://terraref.ncsa.illinois.edu/bety/api/beta/sites?sitename~Season+2&limit=none&key=
I don't expect those to align - I expect that there will be two plots for every one plot in the shape file. These match the boundaries of the two-row subplots in Maria's dataset and the gantry measurements that Stewart took for season 2

Is there significance to the fact that the season one plots are geo-located in only the south 1/5 of those for the current season?

@rickw-ward that is just the first 200 records returned by default since I forgot to add &limit=none to the API call.

It appears to be shifted south two ranges, which should not be the case.  But perhaps an artifact.

@anfrench do you have the R code and original data that you used to generate these polygons?

Sorghum2_DataFile_AugustPlanting.csv.txt
makeshape_F13B2_Fall2016.r.txt

The polygons I generated are based on the plot plan and field book, which has 54 ranges and 16 columns (32 rows) in total. The coordinates of gantry field are converted into latitude and longitude (in WGS84) with coordinates summary.
What are the data source of these two files?
Sorghum2_DataFile_AugustPlanting.csv.txt and the
makeshape_F13B2_Fall2016.r.txt? Is this the ground truth?

@tingli3 I think you can ignore those files since they were used to generate a shape file that @Mamatemenrs has exported as json. The next step is to create the BETYdb insert statements for these polygons - they will be listed as new 'sites'. But instead of Plot 123 the sitename field should have Row x Col y (where x and y are integers of the row and column fields).

@dlebauer
Can you give me some example of the insert statements I should generate? Or what does the table I will be working on look like?
What do you mean by "they will be listed as new 'sites'. But instead of Plot 123 the sitename field should have Row x Col y (where x and y are integers of the row and column fields)" ?

Please retain the data for range and pass and note just rowxcol.

Also, the shape file is projected in UTM 12 N. Should the output coordinates XY be converted to WGS84 or still kept in UTM?

@tingli3 same table (BETYdb sites) and insert statements as #174. Row and col values Come from the shape file and should be used in the plot name. Like sitename = Field Scanner Season 2 Row 1 Col 1
@rick-ward please specify a standard plot naming scheme if you prefer.

@tingli3 same projection as #174 as well

https://github.com/anfrench, see questions above about UTM vs WGS84 above.

For the RIL experiment, the experimental units have addressses composed of two variables: range and pass.   Those, plus the entry number, replication, blocks within reps, etc. can be retrieved through a shared, unique plot#.     Range-Pass enables instant recognition of where an experimental unit is, and is the grid system used for planning envelope filling, planting, and plot labeling.    Not sure this is helping much though...

I wonder if it would be helpful in this plot-boundary issue/discussion to define some terminology, or come up with standard definitions in the context of a data or metadata dictionary.  A 'Range' extends in the Y direction (East-West) and in sorghum crop1 and sorghum crop2 there have been 54 ranges.  A 'Row' extends in the X direction (North-South) and in sorghum crop1 and sorghum crop2 there have been 32 rows.  With sorghum crop1 it was useful to use the term 'Column' to represent 2-rows, since crop1 had 2-row plots and also 2-row border plantings on the West and East sides (16 'columns' was a useful concept).  In the design for sorghum crop2, the term 'Pass' has been used.  Sorghum crop2 has 2-row border plantings on the West and East sides, and 4-row plots (7 experimental plots per range) and it's more useful to refer to 32 rows rather than 16 columns for the sorghum crop2.  I hope this might be helpful, to standardize terms and come up with common definitions.

Lets move discussion of the plot definitions here: terraref/reference-data#60

@tingli3 at the risk of saying things you already know: WG84 is a reference ellipsoid. UTM zone 12 is a projection. Projections need a corresponding ellipsoid. In the NAD83 system that ellipsoid is GRS80, not WGS84, but they are very nearly the same.
When you create a latlon to UTM transformation in proj4 (PROJCS) you specify the semi-major axis and flattening.
GRS80 is 6378137m; 1/298.257222100882711...
WGS84 at one time was the same as GRS80, but is now:
6378137 m (same); flattening a bit different<PHONE_NUMBER>63
This is all to say that the shape Ive provided for the sorghum trial #2 is a projection to UTM zone 12 using the WGS84 ellipsoid. I think we should continue using WGS84 ellipsoid.

Shapefiles for seanson2
Projected Coordinate System for both files: WGS_1984_UTM_Zone_12N

Can tingli3 or dlebauer

Season 2 shapefiles
Projected Coordinate System for these files:	WGS_1984_UTM_Zone_12N

@remotesensinglab the plots from BETYdb json file were generated thus:  https://github.com/terraref/computing-pipeline/blob/master/scripts/geospatial/field_scanner_plots.R; @tingli3 can comment on technical details.
It looks like Ricks shp file plots are a subset of Tings json plots, and close enough that there represent the same concept of a plot but different enough that this represents measurement error. For aligning UAV and gantry data I suggest going with the plot boundaries  derived from gantry measurements.
So Matt can get started I'd suggest extracting means for the superset of plots. We can group Ricks plots as appropriate for analysis and drop the others if they are contain mixed genotypes.
Rick - am I correct that the ones that do not overlap your plots have two border rows of different genotypes?

Something is amiss.   The array of Polygons from andys ('ricks') shape file should be aligned east west at the same center point as the yellow polygons.  But they aren't.  The yellow is shifted significantly east   Why?  Can someone send. E the two shape files and I'll check them in qgis.

@anfrench and I just discussed the frameshift of yellow vs red polygons.  This included a reveiw of the R script here https://github.com/terraref/computing-pipeline/blob/master/scripts/geospatial/field_scanner_plots.R .   Query for @smarshall-bmr and @dlebauer, what point in the field is zero, zero for the gantry?   in attached screen shot of QGIS with layers of orthomosaic geotiff of field/gantry, polygons of middle two rows of plots, and foundation centers (visiblly aligned with geotiff), the text box is pointing at a red dot positioned 2m east of Y coordinate of what I think is the Lemntatec zero,zero point.  If so, and that is used as a corner of plots, it would explain the eastward shift of the yellow polygons.

Shapefiles for the second map on this page.
Rick_David_shps.zip

thanks @Mamatemenrs .   I pulled your json file into my QGIS project, and also added a shape file from @rjstrand  at Lemnatec with a single feature that is Lemntatec's (ie. the gantry's) zero,zero point (red dot above feature attributes box).   The east edge of your east-most plot  (green polygons) is closely aligned with the Y axis position of the Gantry zero,zero.   But that point is outside of the actual planted area.  If your polygons are based on that as the east most point of the Y axis, it would explain why they are shifted one row east of ours (pinkish polygons over two middle rows of four row plots; note two rows of buffer to east and to west of 7 4-row plots in a range.

@ZongyangLi  and @rmgarnett .  See the thread above.  My perspective is strictly 2D at this stage.

Any updates @dlebauer or @Mamatemenrs ?

I do not have anything to update regarding these shapefiles.

new_sql.txt
This is the sql generated for the shapefile.  Not sure about whether the shift from UA-MAC to USDA should be applied. Currently, the coordinates are just transfromed from UTM12.

@tingli3 from the figure in https://github.com/terraref/computing-pipeline/issues/187#issuecomment-257424469 it looks like your R code from #174 may have two issues:

the eastern side of the plot boundaries is aligned to y = 0, whereas the minimum value of y measured by @smarshall-bmr on the gantry was 0.632 (see spreadsheet.
The plots are adjacent to one another. However the same measurements indicate that there is a gap of 20 cm between each plot on the x (NS) axis.

@smarshall-bmr Your measurements indicate a 20 cm gap but I believe that @NewcombMaria said these were intended to be ~50 cm, and this is closer to @rickw-ward's map and observations.

@dlebauer
For the first issue, I have asked question about the start of y more than once and I got no answer. So I have to assume y start at 0 and I wrote this assumption when I uploaded the sql for the first time. There are only 32 records of y and I need 33 records to get 32 rows so I have to assume y start at 0.
For the second issue, if you look at
, there is a gap though the file is incomplete. I am not sure why the gap disappears in the pictures later.

For what it's worth I have updated the range centers document to include row boarders. All I did was place midpoints between each row and use the average row width to place a start and end point.

@ZongyangLi when you used the plots as defined by Stewart, did you realize that his measurements were the plot centers rather than the plot boundaries?

@dlebauer To my understanding, 54 ranges in N/S direction is the centers and 16 rows in W/E direction is the boundaries, is that right?

@zongyangli yes that sounds correct

does focusing on 16 units e/w preclude consideration of the middle two rows of a single, four-row plot since those two middle rows will be in separate units?   Does it not make sense to make a boundary for each row separately instead of two rows units?

We can have many ways to define plots - single, double, quadruple rows.
This should be driven by use cases, only different when necessary, and
hierarchical where possible. So if you define the plot shapes and names we
can generate them.
On Tue, Nov 8, 2016 at 8:22 AM Rick Ward<EMAIL_ADDRESS>wrote:

does focusing on 16 units e/w preclude consideration of the middle two
rows of a single, four-row plot since those two middle rows will be in
separate units? Does it not make sense to make a boundary for each row
separately instead of two rows units?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/terraref/computing-pipeline/issues/187#issuecomment-259148856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcX560Un9p4EUQfZ44q-rmT0bvhHj1Jks5q8IW4gaJpZM4KXgSd
.

@rmgarnett FYI


Launcher doesn't show other app versions

Running version
3.15.2-nightly.1
Describe the bug
Can't see the other versions of the app that I've set up in the settings, plus Unreal is enabled but it doesn't show up
Desktop (please complete the following information):

OS: Windows

[cuID:OP-4999]

Can't see the other versions of the app that I've set up in the settings, plus Unreal is enabled but it doesn't show up

Have you added them to the Project Settings in anatomy too? It'd be around here in the documentation.
Basically:

System Settings defines all global applications/tools available in pipeline
The project anatomy defines which of those applications/tools are active for that project.

@TonyHeadband have you been able to resolve your issue since? Knowing where you currently stand would help us to decide whether this issue is worth keeping open.
I can't reproduce the issue on my end - taking into consideration the notes I posted in my previous comment.

Sorry, didn't see the msg.
I've create a new project after I've seen this comment and still blender as the version that I've set is not present.

Could you show the Project Settings? At the top of Project Settings, there is Project Anatomy which contains Attributes > Applications.
You'll need to enable blender for the project.
Also, your screenshot is showing "Local Settings". I'm referring to the Admin > System Settings or something like that.
Due to a bug it's quite a slow interface just so you know but it's the one you'll need.

Oh yeah!
Between all the movie attributes(frame, clip, handle, resolution) I didn't see the application one, when I've enabled them there they showed up.
Silly me :)
Thank you


Integration tests of Notification sender REST API

Resolves integration tests requirement of : https://github.com/wso2/product-is/issues/10749

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/460644739

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/460644739

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/460644739
Status: success

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/460644739
Status: success

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/460644739
Status: success

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/460644739
Status: success


Request Help Rooting LG-LS770 (Sprint)

So, I've been messing around with lglaf for a while, but I have never been able to get the job done.
I can get the device to respond to listing partitions, dumping the device, but I have yet to figure out how to push something to the /system/bin directory.  I'm afraid to do much more than this due to LAF...  It sets the sd card as an internal partition and the external card as another, weird name.
Does anyone want to hand-hold me a touch? I know it's probably a lost cause, but I'd like to try...  Hell if it goes well, I'd consider putting TWRP on it.
Gabriel

FYI: The device is supposed to be locked, I have the MSL code and I've used CDMA TOOL and can access it this way. I haven't tried the Qualcomm QPST.
Some Info:
ro.adb.secure=1
ro.lge.hw.revision=rev_10
ro.lge.build.branch=msm8916_m_p1s_spr_us_mp_151125
ro.lge.build.basetag=LAMPMR15111
ro.lge.spr_chamelon=true
ro.lge.spr_rootdir=/carrier/cust
o.boot.emmc=true
ro.boot.svelte=1
ro.boot.console=ttyHSL0
ro.boot.device=7824900.sdhci
ro.board.platform=msm8916
ro.build.id=MRA58K
ro.build.host=LGEACI8R8
ro.build.tags=release-keys
ro.build.type=user
ro.build.user=jenkins
ro.build.flavor=g4stylusc_spr_us-user
ro.build.display=MRA58K
ro.build.product=g4stylusc
ro.build.version.sdk=23
drm.service.enabled=true
lge.signed.image=true
Number of MBR partitions: 1
Active From(#s)   Size(#s)   Code Type
1    _    1<PHONE_NUMBER>  EE  EFI GPT protective MBR
GPT Header
Disk GUID: 98101B32-BBE2-4BF2-A06E-2BB33D000C20
LBA size (sector size): 512
GPT First LBA: 1
GPT Last  LBA: 15269887
Number of GPT partitions: 40 (Removed for brevity)


Raise errors when keyword args are given to T combinators

Currently T.nilable(a: Integer) will silently turn into T.untyped. The keyword args are treated as an implicit positional hash when type-checking the send itself, but the type is interpreted as T.untyped because of the early-exit in type_syntax.cc when interpreting T.nilable.
This PR adds an explicit error for T-combinators that shouldn't accept keyword arguments, and an autocorrect to wrap those arguments in curly braces.
Motivation

Catching malformed uses of T-combinators.
Test plan

See included automated tests.

Stripe migration PR: https://go/ps/pull/417113

If we changed Sorbet to be aware of Ruby 3’s keyword arg checking, we’d have caught this is my understanding right? (As in: we might be able to delete this in the future)

Yes, as we can explicitly forbid keyword arguments with **nil, that would be a better option for enforcing that these combinators only receive positional arguments.


FIX: bug in conda_install and pip_install with newlines

Codecov Report

Merging #90 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   86.35%   86.52%   +0.16%
==========================================
  Files          41       41
  Lines        1979     1989      +10
  Branches      175      178       +3
==========================================
+ Hits         1709     1721      +12
+ Misses        206      204       -2
  Partials       64       64

Impacted Files
Coverage Δ

neurodocker/tests/test_dockerfile.py
100% <100%> (ø)
:arrow_up:

neurodocker/utils.py
89.62% <100%> (+0.62%)
:arrow_up:

neurodocker/dockerfile.py
98.28% <100%> (ø)
:arrow_up:

neurodocker/interfaces/miniconda.py
89.47% <0%> (+2.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9bd64...d5b8b85. Read the comment docs.


Fixes #18 Migrate to clowder

This Openshift template is required to deploy ROS-backend app on the ephemeral environment.

@patilsuraj767, could you rebase this pull-request?

Closing in favor of #86
Thanks @patilsuraj767 !


Incompatability with Dynamic Trees

Will either freeze on world load or crash.
Forge Version: 47.3.7
Dynamic Trees Beta 13
C3ME alpha.11.52
Here's a crash log while attempting world gen:
https://pastebin.com/ZfVGUvwC

report to the mod authors


CR-Tool in REACT initial pull request

Short description explaining the high-level reason for the pull request
Additions

New crtool folder under the teachers-digital-platform folder where the whole of the REACT code is implemented.
Additions to the ./setup.sh file to build the crtool
Additions to the package.json for building crtool and copying the react.main.js file
Initial (1) unit test as added and can be run by invoking this command in the crtool folder $: npm run test

Removals

None

Changes

None

Testing

Make sure you run ./setup.sh
Verify the tdp flag is set to true
Navigate to http://localhost:8000/tdp/prototypes/crt-survey-react
You will see the page in the screen shot below
-- Click each of the buttons at the top and verify the page below it swaps accordingly
-- Check some of the radio buttons and fill in some of the text
-- Verify the selections and text are saved while switching pages
-- Even close the web browser and the selections should be saved
-- Any page you start on the button at the top should state 'in progress'
-- If you click the 'restart button at the bottom' it should clear all selection and text values as if you are starting all over.

Review

@Scotchester @willbarton @virtix

Preview this PR without the whitespace changes
Screenshots

Notes

Use the README.md file in the folder `teachers-digital-platform/crtool/README.md for installation instructions and how to run

Todos

Add more unit tests
Fill out more of the README.md file

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@ascott1 & @wpears Please let me know if you have any questions on the decisions I have made in the initial REACT implementation.  Also feel free to reach out to me for a peer review session via hangouts.

REBASED branch on top of master @ 5:47pm EST today


Theme variant per workspace not working.

Did we lose the ability to have a variant of the theme per workspace (what VSCode calls a folder you open in the editor).
I used to be able to switch between workspaces and have different variants applied in there.

https://github.com/equinusocio/vsc-material-theme#activate-theme


chore: version update for releasing

Explain what this PR does.

should we cut 0.8?

let's also update the compatibility matrix


Fixing a dumb issue in the Mongo connector

I guess I had it as MAGELLAN_MONGO_DB to start and then changed it to MAGELLAN_MONGO_COLLECTION and forgot to change it in both places. ;(

Current coverage is 98.41% (diff: 100%)

No coverage report found for master at ee24d99.

Powered by Codecov. Last update ee24d99...324d1a5


Open discussion on overall design of serverless system using terraform

Thanks @squidfunk  for the project, it illustrate in beautiful manner how to implement serverless architecture in terraform. Some questions i have in mind that i would like to implement for one of our internal project.  The main idea is to use serverless infrastructure for set of machine learning models that will be served through lambda/sagemaker.
Some modules are required in order to have the product up and running are:

Billing system to count the users usage of the system.
User management including registration and activation of users using admin super users role.
Monitoring of the system and logging for auditing purpose.

@squidfunk  is it possible to share some thoughts on how do you think is right set of solution to use combining terraform-aws-cognito-auth part of the system?

@ziedbouf the one thing this project delivers is reliable user registration and login, as well as a customizable registration flow. Its responsibility ends when the user signed in and received the ID token. For example, in a client project, I've deployed a GraphQL API on API Gateway which is secured with a Cognito User Pool, so after the user registered, confirmed his account and signed in, he's redirected to the admin backend where the ID token is used to communicate with GraphQL via XHR. When the token expires, the admin backend redirects back to the auth page where a refresh token is used to automatically refresh the session.
Everything else depends on your use case, business requirements and architecture.

thanks @squidfunk  i agree with you on the scope of the project however do you advise in any way how to integrate this with third party  party we just treat it as terraform module and that's all.

basically yes, but of course your milage may vary.

thanks @squidfunk.


Poor performance on KITTI Test Dataset

Hi, I tried to submit my test results to KITTI dataset but the performance is very poor
Car (Detection) | 32.79 % | 20.77 % | 17.11 %
Car (Orientation) | 29.06 % | 17.75 % | 14.62 %
Car (3D Detection) | 0.13 % | 0.04 % | 0.05 %
Car (Bird's Eye View) | 0.67 % | 0.46 % | 0.34 %
The main difference I made from train to test is
Training/Validation (monocd_train.yaml):
TEST: ("kitti_train",)
TEST_SPLIT: "val"        # Uses validation split from training data
Testing (monocd_test.yaml):
TEST: ("kitti_test",)
TEST_SPLIT: "test"       # Uses separate test set
Originally both configs had:
UNCERTAINTY_AS_CONFIDENCE: True
We changed test config to:
UNCERTAINTY_AS_CONFIDENCE: False   # Disabled for test to avoid zero confidence scores
The main issue seem to be that training and validation performs well but the test performance is very poor
Any idea what are the settings I need to change before I submit to KITTI?

It seems that, in addition to the bad 3D detection results, the 2D detection results are not very good too. Maybe you encountered a training crash. My suggestion is to train multiple times to avoid accidents. It is also recommended to set TRAIN_SPLIT: "trainval".


Add CGO_ENABLED=0 to supress dynamic linking

I found that the Goby's binary executable  has been partially dynamic-linked.
Adding CGO_ENABLED=0 to Makefile to ensuring static-linking.
Ref http://blog.wrouesnel.com/articles/Totally static Go builds/

@hachi8833 But for using plugin we need cgo enabled reference

I missed the point 😓
Closing the PR...


Expose details invocation arguments and create tcp client wrapper

This PR adds deserialization of the WAMP details field (field 3) in the INVOCATION message and exposes it as a key value map in the invocation object. This is useful for prefixed matched registrations that need to know the actual procedure called in order to process the call. The PR also adds a tcp client wrapper (wraps socket and sesssion) that seeks to reduce the number of lines of boiler plate code to spin up a tcp WAMP client.

I should have a chance to take a closer look at this later today.

Hey @davidchappelle any forward progress?

Sorry for the delay. I have a few higher priority items to look at first.
On Thu, Jul 16, 2015 at 12:53 PM, Nicholas Wiles<EMAIL_ADDRESS>wrote:

Hey @davidchappelle https://github.com/davidchappelle any forward
progress?
—
Reply to this email directly or view it on GitHub
https://github.com/davidchappelle/AutobahnCpp/pull/8#issuecomment-122020457
.

In addition to the per-line comments, would it be possible to squash the commits into one or two so the commit history isn't littered with reverts of reverts of reverts? In fact, exposure of the invocation details property and the TCP client wrapper are two completely different sets of functionality, and should probably be submitted as separate pull requests (with a cleaned-up commit each).

We also have an implementation of a tcp client. We will likely coalesce the
two implementations.
On Wed, Jul 22, 2015 at 11:11 PM, Jakob Petsovits<EMAIL_ADDRESS>wrote:

In addition to the per-line comments, would it be possible to squash the
commits into one or two so the commit history isn't littered with reverts
of reverts of reverts? In fact, exposure of the invocation details property
and the TCP client wrapper are two completely different sets of
functionality, and should probably be submitted as separate pull requests
(with a cleaned-up commit each).
—
Reply to this email directly or view it on GitHub
https://github.com/davidchappelle/AutobahnCpp/pull/8#issuecomment-123947618
.

I am closing this and opening a new PR with reduced scope. Thanks for comments!


Fix port numbers for peers in high-throughput

Updated ports number for peers connection to match the new docker setup used in version 1.4 (first-network sample)

@danipisca07 thanks for this PR - please can you fix the DCO failure by adding a sign off to your commit? The command git commit --amend -s will allow you to edit your last commit and the -s will add the correct Signed-off-by message to it. You will need to git push -f after doing this to update the PR.

/azp run


[$500] Chat - Pressing ESC closes the video preview modal instead of Download and Playback modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.43-2
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team
Action Performed:

Click on "Add attachment"
Upload a video
Click on three dot then press ESC

Expected Result:
Pressing ESC should not close the video preview modal, it should only close the Download and Playback modal
Actual Result:
Pressing ESC closes the video preview modal instead of Download and Playback modal
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/d065cc86-d7db-4d5f-b2b9-95c45258e03c
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb3dff1b828d5004
Upwork Job ID:<PHONE_NUMBER>772105216
Last Price Increase: 2024-02-20
Automatic offers:

jjcoffee | Reviewer | 0
bernhardoj | Contributor | 0

Edge case, not a blocker

Hey @Julesssss if this is an edge case can we still review/submit proposals or will this be assigned down the road if/when it becomes a higher priority?

@hkopser99 yeah, my comment was just to remove the high priority label. THis will be made external 👍

Proposal:
Please re-state the problem that we are trying to solve in this issue:
When a user presses esc instead of ending the video player preview during the video attachment upload flow, it escape from the attachment upload completely.
What is the root cause of that problem?: Default escape key behavior escapes from the video preview modal and prevents user from proceeding with uploading the attachment rather than simply pausing the video preview.
What changes do you think we should make in order to solve the problem?
In BaseVideoPlayer.js I would implement logic to recognize an esc key press, override default behavior, and use a callback that would call pauseVideo() if isVideoPlaying is set to true.
What alternative solutions did you explore? (Optional):
Given existing functionality, this seems like the smoothest solution unless additional functionality is desired when a use presses esc on desktop browsers or MacOS App.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing ESC closes both the video player popover and the video player preview modal.
What is the root cause of that problem?
Both video player preview modal (BaseModal) and video player popover (PopoverWithoutOverlay) catch the ESC event. PopoverWithoutOverlay listens for keydown, while BaseModal (react-native-modal) listens for keyup event.
https://github.com/Expensify/App/blob/74540f8d59ed6423064a168dba985085d11b228c/src/components/PopoverProvider/index.tsx#L61-L72
https://github.com/Expensify/App/blob/74540f8d59ed6423064a168dba985085d11b228c/patches/react-native-modal%2B13.0.1.patch#L21-L38
In react-native-modal, we prevent the propagation when a modal handles the ESC, but we didn't do that for PopoverWithoutOverlay, so the event is propagated to all views.
What changes do you think we should make in order to solve the problem?

We should follow the same pattern we already have in react-native-modal, that is to stop the propagation.
if (closePopover()) {
    e.stopImmediatePropagation();
}

closePopover will return true if it passes the early return.
https://github.com/Expensify/App/blob/74540f8d59ed6423064a168dba985085d11b228c/src/components/PopoverProvider/index.tsx#L24-L32
However, this still won't work because PopoverWithoutOverlay and BaseModal listen for different events (mentioned on the root cause). We should decide whether we want to use keyup or keydown.
What alternative solutions did you explore? (Optional)
Use BaseModal instead of PopoverWithoutOverlay by removing withoutOverlay.
https://github.com/Expensify/App/blob/74540f8d59ed6423064a168dba985085d11b228c/src/components/VideoPopoverMenu/index.js#L28-L37

Happy that @bernhardoj's proposal identifies the correct root cause and that the solution fits decently with it. I think it makes sense to switch to keyup to keep things consistent with the BaseModal, unless anyone has reasons to believe keydown is better?
@hkopser99 Thanks for your proposal! Unfortunately it's lacking somewhat in details, and the solution proposed doesn't match the expected result (we don't want to pause the video). Please also make sure to use the proposal template exactly as it appears (don't strip the formatting), as this makes it easier for everyone to parse your proposal quickly. :pray:
:ribbon::eyes::ribbon: C+ reviewed

@jjcoffee Thanks for reviewing and the feedback. I will do better next time and will use the exact proposal template.

@Julesssss would you be able to review the decision here - https://github.com/Expensify/App/issues/36902#issuecomment-1956563285 when you have a moment

Yep, I missed this somehow. Done!

PR is ready
cc: @jjcoffee

Now, it doesn't even show the preview of the video
Uploading Screen Recording 2024-02-23 at 10.27.24 PM.mov…

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/rajatkumar16

This hit production 2 weeks ago.

The PR that introduced the bug has been identified. Link to the PR: N/A - this was a latent bug in PopoverWithoutOverlay that the video player implementation brought to light
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal
Desktop only:

Open any chat
Add a new video attachment. Verify the attachment preview is shown.
On the video player control, press the three dots button. Verify the video player popover is shown
Press ESC
Verify the video player popover is closed
Press ESC again
Verify the attachment preview is closed

Do we agree 👍 or 👎

@Christinadobrzyn Checklist complete! This one's due payment, the automation just looks to have failed.

Ah thanks for moving this along @jjcoffee
Payouts due:
Contributor: $500 @bernhardoj (paid in Upwork - https://www.upwork.com/nx/wm/workroom/36436009/overview)
Contributor+: $500 @jjcoffee (paid in Upwork - https://www.upwork.com/nx/wm/workroom/36436097/overview)
Upwork job is here.
Regression test: https://github.com/Expensify/Expensify/issues/378294
Closing! let me know if I missed anything!


refactor: API Extract

This PR improves the usage of API information stored in the api-extract.json. The ApiExtract class provides a well-defined interface to access the data, rather than having to handle the raw JSON within the linter code.
Although mentioned in the first commit, the JSON structure hasn't been changed much so far, but when adding more information it might be helpful to store all information with the symbol name as key. As the usage is abstracted via the ApiExtract class, this change wouldn't require changes on every place of consumption.

@matz3 could you please add some insights to the PR description.

Whats the goal of this PR?
Which parts are improved?

@matz3 could you please add some insights to the PR description.

Whats the goal of this PR?
Which parts are improved?

Done 👍🏻


It works for a while, then after giving errors and restarting it never comes back

It works indefinitely, sometimes it takes time, sometimes it doesn't. Then when it starts showing errors, which by the way doesn't say what it is exactly, I restart and it never comes back. It even connects but it doesn't go beyond that, it just gives me a bunch of errors in the terminal. I tried to solve it in several different ways, I changed devices (PC/Mobile Termux/Codespace), also changed Whatsapp and nothing changes, what do I do?
Message received from<EMAIL_ADDRESS>Sydney's response:  Oi, eu sou a Sydney, sua assistente virtual. Estou aqui para te ajudar com o que você precisar. 😊
/workspaces/sydney-whatsapp-chatbot/node_modules/whatsapp-web.js/src/structures/Message.js:91
this.deviceType = data.id.id.length > 21 ? 'android' : data.id.id.substring(0, 2) == '3A' ? 'ios' : 'web';
^
TypeError: data.id.id.substring is not a function
at Message._patch (/workspaces/sydney-whatsapp-chatbot/node_modules/whatsapp-web.js/src/structures/Message.js:91:75)
at new Message (/workspaces/sydney-whatsapp-chatbot/node_modules/whatsapp-web.js/src/structures/Message.js:18:24)
at Client.sendMessage (/workspaces/sydney-whatsapp-chatbot/node_modules/whatsapp-web.js/src/Client.js:699:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Maybe the installation got corrupted.

Maybe the installation got corrupted.

I thought the same thing, until I reinstalled it several times and got the same result, but it could also be a bug directly linked to my whatsapp, I really don't know

Corrupt installation of yarn, node, etc?

Maybe the installation got corrupted.

I find it difficult considering that I reinstalled several times, but maybe so

Corrupt or outdated installation of yarn, node, etc?

That makes sense, I'll check thanks for the idea

Sorry for the delay. I'm also getting these errors. I think that's due to WhatsApp Web update or something. I'll try to fix this today.


get() does not work with DECIMAL type on windows

Firstly, thank you for making this great library available and maintaining it.
I have struck a problem with the latest couple of versions in that get() no longer works under Windows with a DECIMAL column under MS SQL.  Works fine on older versions and under Linux.
I notice auto_bind() has changed to now include
        switch (col.sqltype_)
        {
        ...
        case SQL_DECIMAL:
        case SQL_NUMERIC:
            col.ctype_ = SQL_C_CHAR;

while the version I am using that works fine across linux and windows has
    switch (col.sqltype_)
    {
      ...
      case SQL_DOUBLE:
      case SQL_FLOAT:
      case SQL_DECIMAL:
      case SQL_REAL:
      case SQL_NUMERIC:
        col.ctype_ = SQL_C_DOUBLE;

I don't want to go and change the code as there has been a specific change which I am not au fait with.
as a peripheral issue, would you advise using get() with this type of data or am I always better off with a getstd::string() and dealing with the numeric conversion myself.
Thanks!

As explained via e-mail, this the related chnage in #238
Fetching DECIMAL via double is/may be  lossless and since there is no std::decimal widely available yet (GCC has it, AFAIK), string is the only type that can accurately and correctly serialise SQL DECIMAL.
Possibly, I think, get<double> could be enabled doing string -> double conversion.

The mapping of SQL_DECIML to SQL_CHAR seems to be the conventionally accepted workaround.
I have used is successfully with SQL Server in a different odbc wrapper in the past.
Also see this SO question for additional info https://stackoverflow.com/questions/9178900/how-to-read-numeric-decimal-money-columns-from-sql-server

Thanks everybody for your help.  I had not turned my mind to the conversion being not lossless as we were using decimal types for compactness rather than extra precision.  mloskot and bangusi both well make the point a more sound strategy is to extract the data as string and deal with it accordingly.  Thanks you all for your help and thank you again for making this a great bit of software.

@trgillespie
FWIW, ISO/IEC TR 24733:2011 std::decimal is supported by GCC/libstdc++. Perhaps it is also in clang, I have no idea. Long time ago, I feature-requested it for VS.
If any nanodbc users who rely on GCC are willing to patch nanodbc and add support for std::decimal, great, bring it on! as pull request.

FYI, I labelled this as a bug because that was intention of the original report.
Perhaps I should remove the label as the current behaviour is by design.
@lexicalunit We need better labels ;-)


feat: Add support for multi-level nesting in bones layout

Add support for multi-level nesting in bones layout
This commit introduces a significant enhancement to the bones layout processing. It enables recursive rendering of nested bones, ensuring support for multi-level nested structures. The renderNestedBones function has been added to handle this functionality, allowing deeper flexibility and customization in bone structures. The changes include updates to types for better clarity and maintainability.

Implement renderNestedBones for recursive bone rendering
Update type definitions for bonesLayout, prefix, and generalStyles
Ensure consistent key indexing for nested elements
Refactor useGetBones to utilize the new recursive approach

@dmitry-blackwave: Thank you for your contribution. Great observation. Just added some minor adjustments and adapted story to prove your point. I will merge it in and publish to NPM 🚢

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[branch-2.10] [fix] [broker] Fix isolated group not work problem.

Motivation
This is a cherry-pick commit for #21096.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Please wait for this PR to fix some tests.

/pulsarbot run-failure-checks

Hi, @horizonzy
You should rebase your branch to branch-2.10


Can't delete Kubernetes object using the REST API

Rancher Version:
master image
Docker Version:
1.12.2
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16.04
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Trying to delete replication controller, and i am having this error:
$ curl -XDELETE -d '{"apiVersion":"v1","kind":"ReplicationController","gracePeridSeconds": 0,"orphanDependents": true}' $APISERVER/api/v1/namespaces/default/replicationcontrollers/nginx -H "Content-Type: application/json" --header "Authorization: Bearer $TOKEN" --insecure
{
  "code": 500,
  "message": "converting (v1.ReplicationController) to (api.DeleteOptions): GracePeriodSeconds not present in src",
  "status": "Failure",
  "metadata": {},
  "apiVersion": "v1",
  "kind": "Status"
}

The request is wrong. The data portion should be empty in the curl request above.
The below is my request which works -
curl -X DELETE $APISERVER/api/v1/namespaces/default/replicationcontrollers/guestbook -H "Content-Type: application/json" --header "Authorization: Bearer $TOKEN" —insecure

Tested and worked on master image (24 Oct) using the "kind: DeleteOptions"


Representative benchmarks of wazero for Go compiler perf measurement

Is your feature request related to a problem? Please describe.
I'd like to know which of the wazero benchmarks (specific Benchmark... functions) are most representative of wazero user code, if you know that.  The problem I have is that, as a Go developer, I am trying to maintain a collection of relevant benchmarks for compiler, runtime, and/or GC, so that we can improve performance in user-relevant ways.  But I don't know a lot about wazero or its user community.
Describe the solution you'd like
Someone will provide me with a list of benchmarks, between 2 and 10 I think, that decently model the performance of wazero user code.
Describe alternatives you've considered
I've considered:

randomly selecting benchmarks (excluding the really short ones, which are obviously not user code, and not repeating a benchmark that is just longer/shorter versions of the same benchmark).
profiling the benchmarks, and selecting the ones that seem to exercise the greatest diversity of wazero source code.
checking sensitivity of benchmarks to PGO/not, inlining/not, optimization/not, randomized linking/not, and sampling along those various axes.

Additional context
Really, any guidance you can offer about what you think would matter to your users, is good.
Thanks very much for any information you have.
The "grand plan" is to incorporate these benchmarks into https://github.com/golang/benchmarks/tree/master/cmd/bent (this is stale, I have a stack of CLs that need to land) which would eventually put the selected wazero benchmarks onto the Go perf dashboard.

This seems fine here, but if you want to open up a discussion with users of wazero, we have a couple of channels in Gophers Slack: wazero and wazero-dev.

i think @ncruces you have a Wasm-compiled sqlite speetest right? I think that can be considered representative use case/bench of wazero.  Given this is mainly interested in the Go compiler's perf, running it with Interpreter mode would be a great i guess?

I'd say that, if you want something representative of user relevant Go code that we have, I'd look at a compilation benchmark: take a complex pice of Wasm (could be my SQLite binary, but a Go wasip1 binary could be even better) and benchmark wazero compiling that.
Improving the performance of the compiler is a big focus for us now, where we're trying to make the wazero compiler as fast as wasmtime's (written in Rust).
A benchmark like my SQLite speedtest, as @mathetake suggested, spends most of its time in compiled code, and you'd need to use the interpreter to stress Go code.

To be more concrete, I was looking at the benchmarks in wazero/internal/integration_test/bench.  Based on remarks above, I think that means I maybe want these?
BenchmarkInvocation/interpreter/string_manipulation_size_50
BenchmarkInvocation/interpreter/fib_for_20
BenchmarkInvocation/interpreter/random_mat_mul_size_20
BenchmarkCompilation/with_extern_cache
BenchmarkCompilation/without_extern_cache
BenchmarkCompilation/interpreter

Maybe some of those are not the best choice, and I'm not entirely sure what BenchmarkCompilation/interpreter means but I suspect it is "not really compiling".
I'd like to avoid being in the benchmark-writing business for other people's code.

Hi @dr2chase, I am perhaps not as well placed as the authors of this project to comment, however, as another user who is interested in wazero performance for my own hobby projects, I am having a hard time understanding what you are looking to benchmark.
Are you trying to benchmark:

the speed at which wazero compiles wasm binaries to machine code
the performance of the machine code wazero produces
the wazero wasm byte-code interpreter that allows wazero to execute wasm without compiling to machine code
something else?

It seems from what I read that you either mean the performance of the machine code wazero produces, but that you are concerned about testing specifically Go code and not machine code... I find it very confusing.
Sorry If I've misunderstood something obvious.

@davidmdm I work on the Go compiler, sometimes the runtime, sometimes the libraries.  When we change the compiler, we like to be sure that we are making it better for Go users (in general) not worse.  It's not "how good is wazero", but rather "did we accidentally hurt wazero?".  Or "hey, we helped wazero, this change might be worth keeping".  But we can't run all the benchmarks for all the applications, so I'm looking for a subset that models wazero performance for its users, at least well enough.

Thanks @dr2chase for approaching us (and staying with us), and @davidmdm for asking the right question!
If you're looking for typical usages of wazero, I guess the interpreter is less interesting, because I suspect most users will be on platforms that support the compiler.
So both compilation time (for startup) and runtime are likely (more) important. OTOH, benchmarks that are entirely dominated by compiled ASM, less so, because they won't be sensitive to Go compiler improvement. So something with a mix of Go calls Wasm, Wasm calls Go.
I'll ask a (hopefully final) question, are you particularly interested in testing the quality of the Go to Wasm (wasip1) compiler? So: Go source compiled to Wasm, then compiled by wazero to (e.g.) amd64, and run with wazero? This would need to have the (tip?) Go compiler in the loop, so makes infra harder, but may be what you're looking for, and worth the effort?
I'm mostly asking these clarifying questions because most of our benchmarks focus on things we can improve (e.g. quality of compiled code) not necessarily on stuff the Go team could do for us. So we may end up creating a new benchmark for this.

Thanks for the help with perf @dr2chase.
For benchmarking wasip1, I think it's simply picking any benchmark (in this case, presumably one that's already in golang/go) and compiling the test binary and running with the wazero CLI. I just tried with go-re2 and it seemed to work without issue
GOOS=wasip1 GOARCH=wasm go test -c .
go run<EMAIL_ADDRESS>run go-re2.test -test.run=None -test.bench=Benchmark

As for representative benchmarks, sorry if I misunderstood but it sounds like you are looking for more e2e-type of benchmarks rather than microbenchmarks, since the latter would be mostly for wazero development. If that's true, then probably the ones you found under integration_test are confusingly more like microbenchmarks. We can see the test cases are quite small, notably they will not exercise much of the diversity of the compiler I think.
https://github.com/tetratelabs/wazero/blob/main/internal/integration_test/bench/testdata/case.go#L3
For more e2e-type of compiler benchmarks, we have Compilation which @mathetake runs anytime changing the compiler backend.
https://github.com/tetratelabs/wazero/pull/2265
For invocation, we have libsodium. Unfortunately due to the size of the Wasm we don't check it in so it requires a build step - and perhaps it's a bit overboard even as an e2e benchmark
https://github.com/tetratelabs/wazero/blob/26d3aeb1b1ca0161308d06ddd4f224e31d46ed5f/.github/workflows/integration.yaml#L317
Otherwise, I wonder if it's an option to pick a downstream library instead as it is a real-world use case with wazero doing all the heavy lifting, I suspect go-sqlite3 would exercise the syscall layer a lot (go-re2, has few syscalls and would be almost entirely within compiled code).
A slight aside, but I wonder if it would make sense to add an environment variable or build tag to force disable CompilerSupported
https://github.com/tetratelabs/wazero/blob/26d3aeb1b1ca0161308d06ddd4f224e31d46ed5f/internal/platform/platform.go#L15
Then, if wanting to benchmark the interpreter in a downstream project such as Go, it would be much easier to pick between compiler and interpreter without special-casing the benchmark.


Support incremental refresh for Delta Lake

What is the context for this pull request?

Tracking Issue: #295
Parent Issue: #148
Dependencies: n/a

Fixes #295
What changes were proposed in this pull request?

This PR includes following bug fixes for Delta Lake source.

support incremental refresh - added a new API to source provider partialReadFileFormat to read appended files separately
fix incremental refresh for partitioned data (#281) + test
fix options as the original map instead of caseInsensitiveMap
quick refresh test

Does this PR introduce any user-facing change?

Yes, this PR fixes several issues described above.
How was this patch tested?

Unit test

@apoorvedave1 @pirz Can you review this PR? Thanks.

@apoorvedave1 @pirz Can you review this PR? Thanks.


Updated api version number

Updated api version number

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-projects


Correction for raw affiliation Aeres University of Applied Sciences Almere, Stadhuisstraat 18, 1315 HC, Almere, The Netherlands

Correction needed for raw affiliation Aeres University of Applied Sciences Almere, Stadhuisstraat 18, 1315 HC, Almere, The Netherlands
raw_affiliation_name: Aeres University of Applied Sciences Almere, Stadhuisstraat 18, 1315 HC, Almere, The Netherlands
new_rors: 03jnx2c74
previous_rors:
works_examples: W2942922798;W3012615648
contact: 6280a351a5e975461693143d32d626b0:54707fc27fbfa02b @ aeres.nl

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Sort versions semantically in rbenv versions

A proposal to solve #1086
Before
$ rbenv versions
  system
  2.2.10
  2.2.5
  2.2.9
* 2.5.1 (set by /Users/prrrnd/.rbenv/version)

After
$ rbenv versions
  system
  2.2.5
  2.2.9
  2.2.10
* 2.5.1 (set by /Users...)

@mislav Thanks for the quick review! I'll have a look at Travis when I get some time. Any idea on how to avoid the duplication of sort_version from ruby-build?

Duplication is fine.
Note that I will be away the rest of this week. Final review next week. Thank you for your contribution!


Added doc for a affinity/anti-affinity

This is a draft of new feature for Ocata version of OpenStack introducing affinity/anti-affinity for host aggregates based on their metadata keys like rack or powerzone.

LGTM, thanks Roman :+1:

Apparently I can't merge things in this repo, @epim halp :)


Convert Level input to TextField

LevelSelect Component is still using the "button-like" inputs.
The button-like input should be a TextField
Not sure what a "prettier" way to structure this, since the /20 here is a button (to toggle between ascension)

hey @frzyc  i could work on this

Thanks, feel free to ping me if you have any questions

Heya @frzyc Looks like the other person dropped the assignment on this, I can pick it up and have a look

Is this closed by #2123 ? 😉

You are right, it was not correctly referenced in the original PR to close this.


How do I install it?

At the page https://grails.org/plugin/logical-delete there is a short command to install the plugin to the application, but what about this one?
I already downloaded the source code, but I don't have any clue about how to install it.

That's because that plugin is in the official Grails plugin repository. Mine isn't. I did submit it but my guess is that all the attention is towards Grails 3 and Grails 2 plugins submissions are not being reviewed anymore (my submission was not denied or accepted).
You have to download it and install as a in-place plugin.

@moacirrcosta Don't know if you still need it, but I checked the page for the plugin and it turns out it was approved, but I had to publish a version for it. It is now listed in the official repository:
https://grails.org/plugin/gorm-logical-delete
You can install it by simply adding the dependency to your projetct:
compile "org.grails.plugins:gorm-logical-delete:1.1"

Works with any Grails 2 version above (and including) 2.3.0


SUMO traffic maps

Hi, I'm currently looking for SUMO maps to benchmark my algorithm and I found your repo, which is awesome. But I have a question, why all the map in SUMO folder is exactly the same, is there something wrong?

The CityFlow maps are come from https://github.com/zxsRambo/metalight/blob/master/data.zip. They have same a intersection structure, and I converted them to SUMO map. So you see they are the same and there is no right turn lane.
You can create different lane environments by yourself, then use https://github.com/baimengwei/Traffic-Flow-Test-Platform/blob/main/tools/randomTrips.py to generate vehicle routing information for use.


Use UserAgent instead of DefaultUserAgent

Currently, UserAgent appears to do nothing. This fixes #123.
I was also thinking of being able to override the - with RedditSharp by meepster23 part but I'll add another commit for that. I was thinking this could be achieved by either moving the library's user-agent string to DefaultUserAgent, or by adding a Boolean switch to determine if the library's user-agent string should be concatenated to the user-provided string.
Thoughts?

Honestly either way is fine with me. That's a hold over from before I hard forked this and just changed the username in it. Doesn't really need to be there at all but prevents some throttling versus no useragent present.


Apple Authentication error running "eas build" and selecting phone number for 2FA

Build/Submit details page URL
No response
Summary
I am currently attempting to build an iOS App using the EAS CLI. After attempting to run the commands eas build -p ios on both macOS or Linux, or eas build -p ios --local on macOS, I am met with the same command output each time:
✔ Using remote iOS credentials (Expo server)

If you provide your Apple account credentials we will be able to generate all necessary build credentials and fully validate them.
This is optional, but without Apple account access you will need to provide all the missing values manually and we can only run minimal validation on them.
✔ Do you want to log in to your Apple account? … yes

› Log in to your Apple Developer account to continue
✔ Apple ID: …<EMAIL_ADDRESS>› Restoring session /Users/****/cookie
› Session expired Local session
› Using password for<EMAIL_ADDRESS>from your local Keychain
  Learn more
✔ Logged in, verify your Apple account to continue
Two-factor Authentication (6 digit code) is enabled for<EMAIL_ADDRESS>Learn more: https://support.apple.com/en-us/HT204915

✔ Please select a trusted phone number to send code to › +1 (•••) •••-••**

Internal Server Error: 'h', 'Received an internal server error from Apple's App Store Connect / Developer Portal servers, please try again later'. Retrying after 3 seconds (remaining: 3)

✖ Logging in...
Authentication with Apple Developer Portal failed!
Received an internal server error from Apple's App Store Connect / Developer Portal servers, please try again later
    Error: build command failed.

I am currently using Expo 52 and eas-cli 13.4.2. This has been going on for over a day and I believe it may be due to an API endpoint changing.
What platform(s) does this occur on?
iOS
SDK Version
52
Environment
expo-env-info 1.2.1 environment info:
    System:
      OS: macOS 15.1.1
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 21.7.1 - /opt/homebrew/bin/node
      Yarn: 1.22.19 - /opt/homebrew/bin/yarn
      npm: 10.5.0 - /opt/homebrew/bin/npm
      Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: DriverKit 24.1, iOS 18.1, macOS 15.1, tvOS 18.1, visionOS 2.1, watchOS 11.1
      Android SDK:
        API Levels: 30, 32, 33, 34
        Build Tools: 30.0.3, 33.0.0, 33.0.1, 34.0.0
        System Images: android-33 | Google Play ARM 64 v8a
    IDEs:
      Android Studio: 2022.3 AI-223.8836.35.2231.10811636
      Xcode: 16.1/16B40 - /usr/bin/xcodebuild
    npmPackages:
      expo: ^52.0.8 => 52.0.8
      react: 18.3.1 => 18.3.1
      react-native: ^0.76.2 => 0.76.2
    npmGlobalPackages:
      eas-cli: 13.4.2
      expo-cli: 6.3.10
    Expo Workflow: managed

Running theeas build -p ios command and selecting a phone number for 2FA when prompted to log into an Apple account.
Managed or bare?
Managed
Environment
expo-env-info 1.2.1 environment info:
System:
OS: macOS 15.1.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 21.7.1 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 10.5.0 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
SDKs:
iOS SDK:
Platforms: DriverKit 24.1, iOS 18.1, macOS 15.1, tvOS 18.1, visionOS 2.1, watchOS 11.1
Android SDK:
API Levels: 30, 32, 33, 34
Build Tools: 30.0.3, 33.0.0, 33.0.1, 34.0.0
System Images: android-33 | Google Play ARM 64 v8a
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10811636
Xcode: 16.1/16B40 - /usr/bin/xcodebuild
npmPackages:
expo: ^52.0.8 => 52.0.8
react: 18.3.1 => 18.3.1
react-native: ^0.76.2 => 0.76.2
npmGlobalPackages:
eas-cli: 13.4.2
expo-cli: 6.3.10
Expo Workflow: managed
Error output
No response
Reproducible demo or steps to reproduce from a blank project
Running theeas build -p ios command and selecting a phone number for 2FA when prompted to log into an Apple account.

Same issue on my end.

Hey, It seems like a duplicate of https://github.com/expo/eas-cli/issues/2698. Let's track it in a single place.
Can you check if using https://github.com/expo/eas-cli/issues/2698#issuecomment-2505914309 works?
It seems like using EXPO_NO_KEYCHAIN=1 works for some folks, can you check if it works for you?


update file php-variables.data

This is probably the most static list that we will have.
We can get all probably using https://www.php.net/get_defined_vars or similar?
Example:
php -r 'print_r(array_keys(get_defined_vars()));'
Array
(
    [0] => _GET
    [1] => _POST
    [2] => _COOKIE
    [3] => _FILES
    [4] => argv
    [5] => argc
    [6] => _SERVER
)

Maybe we want to extend this list by using php -r 'print_r(array_keys(get_defined_constants()));'  or even php -r 'print_r(get_declared_classes());' 🤷

@lifeforms @theMiddleBlue What do you think about this one?

I think there're more constants/globals that we should add other than the ones on your list. For example:
$GLOBALS
$_SESSION
$_REQUEST
$_ENV
etc...
maybe we should parse the PHP documentation and get a list? we could also include a list of deprecated function/globals/constants

Do we need to add also global constants? https://www.php.net/manual/en/reserved.constants.php

it should be a good idea, except for booleans and nulls that could be prone to FPs


add icon to programs markup

Here's an easy extension to use:
https://github.com/dbtek/showdown-icon

done


Operation not permitted when init by initHiveForFlutter

I got an error when I init the app by function initHiveForFlutter with debug mode in the VSCode.
Here is the error message:
PathAccessException (PathAccessException: Cannot open file, path = '/Users/august/Documents/graphqlclientstore.hive' (OS Error: Operation not permitted, errno = 1))

I know the function initHiveForFlutter is to init Hive with the document folder, but why it requires the permission? I search a while and think it doesn't need that permission.
My code get stuck at the first line in main
Future<void> main(List<String> args) async {
  await initHiveForFlutter(); // Exception occurred
  ...
}

Environment
macOS
flutter: 3.10.6
graphql_flutter: 5.1.2
Expected behavior
Init Hive without exception and should not ask for permission.
screenshots

OS Error: Operation not permitted, errno = 1))

This is a an OS error, we can not do nothing (maybe)/ Have you try to see if you have enough permission?

Have you try to see if you have enough permission?

Thanks for the quick reply. Yes, I have try to give the Document folder permission, and it will work. However, I don't want to ask the permission to the user on my app if possible.

I guess this is related to the app, we can not do nothing from the graphql package I think

I guess this is related to the app, we can not do nothing from the graphql package I think

@vincenzopalazzo I see, thanks. As I know Hive is used for caching in graphql_flutter, can I skip the initHiveForFlutter method if I don't need a cache in my app?

Yeah you can disable the cache and use the in-memory one or just nothing, you can take a look at the readme inside the package that you are using.
I am closing this due that it is an problem that we can not solve from the library point of view


New artwork request

After Mat and Ashley's keynote talk at GolangUK 2017, I think there are appetite for some new British themed artwork! Here are some suggestions:

Umbrella
Tea
Top hat
Golang UK themed t-shirt

hands carrying a envelope as well :)


Dspace 5 x

https://jira.duraspace.org/browse/DS-3425
When doing a call to {dspace}/JSON/discovery/search, no output is returned.
The cause for this is the output stream being closed in JSONDiscoverySearcher.
This was committed for DS-3246:
https://jira.duraspace.org/browse/DS-3246
#1437
Not sure why the out.close() was added, but removing it restores normal output for a JSON/discovery/search call.

This PR has to be issued against 5_x, not master

recreated
https://github.com/DSpace/DSpace/pull/1592


Add Git/Github details

Current behavior

Proposed changes

Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] There are no Merge commits in this Pull Request. The Ockam repo maintains a linear commit history so we merge PRs by rebasing them to the develop branch. Rebasing to the latest develop branch and force pushing to your PR branch is okay.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@bL34cHig0 Thank you for accepting the CLA and taking time to contribute!!
Welcome to the Ockam Community 🥳
If you have questions, as you explore, join us on the contributors discord channel https://discord.gg/bewvnm6zqS
I will merge the pull request shortly.

Appreciate it @mrinalwadhwa and am glad to join the community 😊


Per date count is not been updated

In https://api.covid19india.org/v3/data-all.json it has data for date June 28.
However if you goto per date url, https://api.covid19india.org/v3/data-2020-06-28.json, it gives a 404 error.
It seems both sources are not been updated at the same time. You can also later verify this issue on next day (June 29) data.

This might have been a temporary issue related to GitHub serving. Whatever's there in data-all is split and dumped for each date at the time

Same issue is happening every day. The June 30 data already appears in /v3/data-all.json.
However /v3/data-2020-06-30.json still gives a 404 error. It seems this file takes around 5-6 hours to update.
Could you please look into why there is a huge delay in updating daily data json file?
Currently the only option to get daily data is is to download the entire /v3/data-all.json file which is huge (around 12 MB).

Looking at https://github.com/covid19india/api/commit/cee12112a6a28c734f3627492eb7cfd815e94fca, seems like a new date entry in v3/data-all.json and a new date file v3/data-2020-06-30.json are created at the same time. I'm not really sure what else to look at.
Just to be clear, the data for the last day available is stored in v3/data.json, while the data for previous days is kept as v3/data-YYYY-MM-DD.json. data-all.json is a combination of both which contains all date entries. Assuming your use case is only to get the latest numbers, then you should only be pulling v3/data.json and not any date-specific ones. The reason why v3/data.json (the one with the latest numbers) doesn't have a date is so that people don't have to worry about timezones when pulling.


Number of likes

Describe the bug
It is a very minor bug
If there is 1 like then on the post page 1 like should be shown, but currently 1 likes is shown. But for comments 1 comment is shown correctly
To Reproduce
Steps to reproduce the behavior:

Go to 'any post having one like'
Click on 'Read More'
See error '1 likes'

Expected behavior
1 like should be shown
Screenshots

Additional context
Add any other context about the problem here.
Note:

Do mention if your are working under GSSoC'21.
If you want to work on an issue, you should check if it has already been assigned to anyone. If the issue is free you can comment /assign to get the issue assigned to you.
If you are raising a new issue and want to work on it then also you should comment /assign under the issue to get it auto assigned.
Please refrain from adding labels to your issue/pull-request on your own. It is the job of the Project Admin and the Mentors to review your issue/pull-request and add labels accordingly.
According to the level of the issue, respective time will be allotted under which the task needs to be completed/resolved by the assigned person. If the issue is not resolved within the given time, it will be assigned to the next person. In case of any discrepancies, the decision of the maintainer will be final.

level - 0: 2 days
level - 1: 3 days
level - 2: 4 days
level - 3: 5 days

/assign

@Pranav016 Should I also make changes such that if number of comments/likes are 0 , then it should show No comments/likes ??

I think 0 is fine


HDDS-1915. Remove hadoop script from ozone distribution

/bin/hadoop script is included in the ozone distribution even if we a dedicated /bin/ozone
[~arp] reported that it can be confusing, for example "hadoop classpath" returns with a bad classpath (ozone classpath ) should be used instead.
To avoid such confusions I suggest to remove the hadoop script from distribution as ozone script already provides all the functionalities.
It also helps as to reduce the dependencies between hadoop 3.2-SNAPSHOT and ozone as we use the snapshot hadoop script as of now.
See: https://issues.apache.org/jira/browse/HDDS-1915

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
79
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
shadedclient
869
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
shellcheck
0
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
749
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
30
The patch does not generate ASF License warnings.

1860

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1233

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux a59d552d7e6e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1127215

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@arp7 can you also take a look at this change.
I will wait for a day for others to review if no more comments I will commit it.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
77
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
shadedclient
849
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
shellcheck
0
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
751
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
32
The patch does not generate ASF License warnings.

1822

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1233

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux ba42f1de95fb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3cc0ace

Max. process+thread count
334 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1
shadedclient
730
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
shellcheck
0
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
636
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
asflicense
28
The patch does not generate ASF License warnings.

1541

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1233

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux ea291fcd5650 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Max. process+thread count
422 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1233/3/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@elek  Thanks for the contribution. @bharatviswa504  Thanks for the review. I have committed this to the trunk.


proposal: reusable logic templates

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.1 windows/amd64
Does this issue reproduce with the latest release?
Yes, it does
What operating system and processor architecture are you using (go env)?
Windows 10
GoLang is nothing like simple language. It seems simple because it is ingenious. Owing to lightweight goroutines and channels to share memory by communicating the language unfolds absolutely unique style of programming by orchestrating multiple goroutines. This uniqueness along with easiness of passing around functions and methods stages the playground for further enhancements in this vein.
What would advance the language further on in this way is a possibility to create code templates to reuse them in different context
For example we have this snippet of code:
func splitCandy(pcs int) map[string]int {

  type party struct {
     name string
     age  int
     schoolQ float32
  }

  mems := []party{
     {"Dany", 5, 0.0},
     {"Chloe", 12, 9.2},
     {"David", 14, 6.8},
     {"Ryan", 9, 4.2},
     {"Leah", 11, 8.5},
  }

  {{define "eqSplit"}}
  n := len(mems)

  var extra int
  var res = make(map[string]int, n)

  if n > pcs {
     extra = pcs
     pcs = 0
     goto splitLogic
  }

  for i := 0; i < n; i++ {
     if pcs %n == 0 {
        cnds := pcs / n
        for _, kid := range mems {
           res[kid.name] = cnds
        }
        break
     } else {
        pcs--
        extra++
     }
  }

  splitLogic:
  {{end}}

  for k, v := range res {
     if v > 5 {
        for _, m := range mems {
           if k == m.name {
              res[k]--
              extra++
           }
        }
     }
  }

  // very complicated logic here

  return res

}

func allotChoresHrs() {

  type party struct {
     name string
     age  int
  }

  mems := []party{
     {"Chloe", 12},
     {"David", 14},
     {"Ryan", 9},
     {"Leah", 11},
  }

  {{block "eqSplit" }}

  for k, v := range res {
     if v > 5 {
        for _, m := range mems {
           if k == m.name {
              res[k]--
              extra++
           }
        }
     }
  }
}

‘splitCandy’ function contains complicated logic tightly engrossed in function context which makes it difficult and ineffective to be split into several functions. Instead we might have an ability to reuse certain pieces of logic within different context. Notice some block of code surrounded with this block:
{{define "eqSplit"}}
     ...
{{end}}

We then reuse this snippet of code in the second function (allotChoresHrs) by placing this reference:
{{block "eqSplit" }}
What we have defined above the reference gets used as a context for the code snippet being referenced. Also injected block of code brings a set of new variables got accessible afterwards.
Of cause there are issues with code readability and maintenance upon code changing but in my view it goes along pretty naturally with a new style of programming brought up by Go. And it is unique feature with no precedent in my mind. There are http and text templates where such logic templates might come in handy.

Thank you for the feature request.
Unless I'm misunderstanding your proposal, it sounds like what you're describing could be achieved by simply using functions. The benefits of this feature don't appear to outweigh the increased complexity it would bring to the language specification.
Thank you again for taking the time to write up this request, but we're going to pass.


feat(react): Deprecate react hook makers

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Crazy Irishman: Weapon buy menu bug

Version: develop
Mods: ACE
Mode: MP
After completing in  finding the crazy Irishman (aka blackmarket), while trying to buy material noticed that:

In the menu only the WEAPONS button is redirected to what type and amount of weapons you want the rest (MINES, ACESSORIES and CHARGES) do nothing.
In the WEAPONS menu buttons did nothing

Errors in the logs...