BeforeEach Called twice on entry

Adding before each to the router, seems like something is causing it to trigger twice on the client side.
the router file can be changed like so in this project to see the issue
export function createRouter () {
  const router = new Router({
    mode: 'history',
    scrollBehavior: () => ({ y: 0 }),
    routes: [
      { path: '/top/:page(\\d+)?', component: createListView('top') },
      { path: '/new/:page(\\d+)?', component: createListView('new') },
      { path: '/show/:page(\\d+)?', component: createListView('show') },
      { path: '/ask/:page(\\d+)?', component: createListView('ask') },
      { path: '/job/:page(\\d+)?', component: createListView('job') },
      { path: '/item/:id(\\d+)', component: ItemView },
      { path: '/user/:id', component: UserView },
      { path: '/', redirect: '/top' }
    ]
  })
  router.beforeEach((to, from, next) => {
    console.log('Before Each')
    next()
  })
  return router
}

Doe this happen when you navigate to routes other than ``/` ?
For / this is expected because of the redirect:
  { path: '/', redirect: '/top' }

No. it is coming from all entries. it seems like when the createRouter function is called it's executing it.


Not important issues

works very well so far. issues i noticed is that

when clicking the pinned shortcut it takes 2 seconds to show the group's apps (it isn't instant, click - launch - done)
from the moment you click on the pinned icon on the taskbar and quickly move the cursor away from the taskbar during the 2 seconds it will take it to show the group, it will show the group anywhere the cursor is resting randomly on the screen. it doesn't stay locked above the pinned icon above the taskbar

Since we don't know exactly where the icon is on the taskbar, it is hard to fix that issue since we currently grab the mouse.
Once thing we can do is take a picture of the desktop, use some image recognition to find the group icon on whichever taskbar and then go from there but that is more of an advanced solution. I will see what I can do though this solution may increase load time for the group.
Optimizations I will look into to make it more instant but it isn't as easy maybe because of us using Windows Forms instead of WPF. This was considered in #72  but that is still up in the air. There is a port to it (https://github.com/xXNicksonXx/taskbar-groups) that you can try building and see if it has the same issues.


4.0 wip

Your MenuWrapper returned NULL on Android 4.0.x for the UP MenuItem (itemID==android.R.id.home).
This resulted in onOptionItemSelected being called with NULL.
I left the 2 log-statements in there to show when exactly this happens and also added some code to make this bullet proof in case a future Android version changes it's behavior slightly (e.g. comparison by instance instead of itemID of MenuItems failing).

Thanks! I pulled in your changes manually since the pull request was against the wrong branch. I also chose to be a bit less forgiving (at least for now) when looking up items. If I see a lot of errors coming up I'll change it to be more forgiving but I prefer to fail fast for now.


WelcometoHacktoberfestWthNm.java

It's a simple program with name of the user, and the Welcome 👍  (New on git)
What does the program do ?
The program welcomes users
In what programming language it is written?
Java

This pull request do not contains files in specific folders. Please fix it and reopen


Merge pull request #60 from FCCColumbus/staging

Staging

Deploy preview for fcccolumbus processing.
Built with commit 9b95e2cb658818729d6a51d2093129c91305d6d0
https://app.netlify.com/sites/fcccolumbus/deploys/5b119b4db13fb1605de07725


(feat) added feature to disable colorful output with --no-color flag

Description
The --no-color flag removes color from the output. It also disables color from the logs genearted by tracing crate.
Fixes #195
Additional Information
I am modifying the TERM env variable to disable color. This is referenced from here. The changes made to the TERM variable using env::set_var("TERM", ...) are specific to the current process and its child processes. Once the process terminates, the environment variable will revert to its previous value.

@viccuad I have never written e2e tests in bats. I will look into it and write a test soon. Thanks for the feedback.

I use bash function that removes colors from output, maybe it helps you in the test:
kwctl load &| sed -r 's:\x1b\[[0-9;]*[mK]::g'

@viccuad I have never written e2e tests in bats. I will look into it and write a test soon. Thanks for the feedback.

I use bash function that removes colors from output, maybe it helps you in the test:
kwctl load &| sed -r 's:\x1b\[[0-9;]*[mK]::g'

Thank you for the suggestion but I checked if the output contains ANSI escape sequence.


threads: extract arch-independent scheduling logic

Part of #157.
This PR:

introduces an Arch trait for arch-specific logic in the scheduler
extracts the arch-independent scheduling logic out of the cortex_m module.

Details of the new Arch trait will probably still change once a second arch is added, but I think this is already a useful first step.
Wdyt?
Reviewing by commit might be easier; I tried to split it up a bit.

I think this goes into the right direction.
BTW, we'll need benchmarks. I used to test using the RIOT-c benchmarks, but we can't use them at the moment.
But the riot-rs::rt::benchmark() function can be used to clock how fast the scheduler is.
E.g. with sth like this: https://gist.github.com/kaspar030/bde630c06dd6f20babcaf0668d3f7e12
I was surprised, this PR is as fast as main. Zero Cost Abstractions FTW! :)

I think this is good to go. If possible fix the "super" vs "crate" import.


TennisTV Extractor not working anymore

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.02.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-f', '3180', '-p', 'PRIVATE', '-u', 'PRIVATE', 'https://www.tennistv.com/videos/marseille-2019-hoang-simon']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.02.18
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17763
[debug] exe versions: ffmpeg N-89951-g3caecf7ce8, ffprobe N-89951-g3caecf7ce8
[debug] Proxy map: {}
[TennisTV] Logging in
[TennisTV] marseille-2019-hoang-simon: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpw73a_6nx\build\youtube_dl\extractor\common.py", line 605, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpw73a_6nx\build\youtube_dl\YoutubeDL.py", line 2225, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Description of your issue, suggested solution and other information
The TennisTV extractor is not working anymore. It worked until yesterday.
I can provide account/login info via some secure channel (don't know if DMs are possible here on GitHbub?).

seems to work again now, so probably was just a temporary issue on the host's site.


Anyway to inject DLCs into games via Lua Scripts?

I just wish I don't need to purchase everything again since MHRise is originally launched on nintendo switch and I've already purchased once :/

I tried look into snow.DlcManager & snow.DlcMounter, still confused on how the thing works

Probably. Don't ask about it here.


Style.method_30938 -> withUnderline

I've also added Javadoc in the style of all the other with* methods' Javadocs.

this method doesn't have a name even in Voldemap lol

Probably because nobody ever uses it because withFormatting(Formatting.UNDERLINE) works on both sides


Certificate validation failed

I have configured everything and also used local fingerprint, but i got this error "Certificate validation failed"

Hi,
Can you elaborate a bit? What steps have you taken to determine the cause of the error?


Add example for jQuery

Due to the integration with statically-wp, can we provide more examples for jQuery? Just to give an idea so that people can easily apply it to their website, especially when they use jQuery.

It’s already in the FAQ section: Can I integrate it with jQuery?
Do I have to set a live example too for jQuery users?

Done.


Fix bug in root repo import where catalog-info.yaml.hcl file breaks import

Hey, I just made a Pull Request!
When importing a repository from GitHub using the root repo url, if the repo has any templated catalog-info files (as is the case with the backstage repo itself, the search analyser finds the .hcl file and attempts to import it as a location. This breaks the import with a unclear 500 error

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

I'm creating a fresh PR as this got messed up by DCO fixes and endless rebases https://github.com/backstage/backstage/pull/25081


[GitHub, CI] Update GitHub Workflows to use Azure/PowerShell action

Description
Closing #931
Workflows that interact with Azure now use the Azure/PowerShell action, limiting the time it takes to set up the runner environment.
Pipeline references

Pipeline

Type of Change
Please delete options that are not relevant.

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (readme)
[x] I did format my code

@MariusStorhaug the settings.json and the global variables are still referencing your env?

I'm happy with the changes. Good one @MariusStorhaug. I have question, in the scenarios where we need to bring in a custom module, like the one we use for the environment variables YAML, should we just move that 'install-module' to that specific task? or are we going to continue to support the Set-EnvironmentOnAgent script?

Can this be implemented for ADO as well? Or better: since we have Az PS tasks in ADO (https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops) maybe it's already the case that we can get rid of the Setup environment step in ADO as well and have GitHub and ADO aligned.

We use already the AzurePowerShell task. However the only difference is, that the task comes with the link to the ServiceConnection. We're still dependent on what is installed on the agents. The same is true for the Agents in GitHub too by the way.

Can this be implemented for ADO as well? Or better: since we have Az PS tasks in ADO (https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops) maybe it's already the case that we can get rid of the Setup environment step in ADO as well and have GitHub and ADO aligned.

We use already the AzurePowerShell task. However the only difference is, that the task comes with the link to the ServiceConnection. We're still dependent on what is installed on the agents. The same is true for the Agents in GitHub too by the way.

@MrMCake I understand the suggestion would be to keep the Setup agent step besides the AzurePowerShell task in ADO or action in GH. This would be since that is expected not to be time consuming for the pipeline to be executed in case Az PS modules are already there. My point is in both cases, both if we decide to remove and if we decide to keep it, that should be consistent between ADO and GH. So either we remove that from both or we keep it in both.

Can this be implemented for ADO as well? Or better: since we have Az PS tasks in ADO (https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/azure-powershell?view=azure-devops) maybe it's already the case that we can get rid of the Setup environment step in ADO as well and have GitHub and ADO aligned.

We use already the AzurePowerShell task. However the only difference is, that the task comes with the link to the ServiceConnection. We're still dependent on what is installed on the agents. The same is true for the Agents in GitHub too by the way.

@MrMCake I understand the suggestion would be to keep the Setup agent step besides the AzurePowerShell task in ADO or action in GH. This would be since that is expected not to be time consuming for the pipeline to be executed in case Az PS modules are already there. My point is in both cases, both if we decide to remove and if we decide to keep it, that should be consistent between ADO and GH. So either we remove that from both or we keep it in both.

Hey @eriqua, gotcha - and agree. Just wanted to make the point about the type of task. :)


Clicking 'x' should be equivalent to clicking No on survey prompts and survey should not show for interactive window

For https://github.com/microsoft/vscode-jupyter/issues/6730

Codecov Report

Merging #6767 (7d53465) into main (a0c3dd3) will decrease coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff          @@
##            main   #6767   +/-   ##
=====================================
- Coverage     68%     68%   -1%
=====================================
  Files        411     411
  Lines      28581   28581
  Branches    4271    4271
=====================================
- Hits       19497   19488    -9
- Misses      7420    7430   +10
+ Partials    1664    1663    -1

Impacted Files
Coverage Δ

src/client/datascience/dataScienceSurveyBanner.ts
76% <50%> (ø)

src/client/common/application/debugService.ts
46% <0%> (-7%)
:arrow_down:

...datascience/editor-integration/codelensprovider.ts
81% <0%> (-3%)
:arrow_down:

.../datascience/editor-integration/codeLensFactory.ts
84% <0%> (-2%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
84% <0%> (-2%)
:arrow_down:

...ient/datascience/editor-integration/codewatcher.ts
68% <0%> (-1%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
75% <0%> (-1%)
:arrow_down:

...t/common/variables/environmentVariablesProvider.ts
77% <0%> (ø)

src/client/datascience/baseJupyterSession.ts
69% <0%> (+<1%)
:arrow_up:

...t/datascience/notebook/vscodeNotebookController.ts
77% <0%> (+<1%)
:arrow_up:

... and 1 more


Settings.use_editable()

Is it compulsory to use settings.use_editable() in my view for  customized admin register_setting
Why do we need to flush the db cache to pick up new settings ?
I think it should automatically pick up the new settings without me mentioning it in my view.
Regards,
Sreedhar

Please post this to the mailing list, thanks.

Thanks for your reply , Posted to mailing list
regards,
Sreedhar


[7.67.x][JBPM-10141] - Clarify PIM documentation/README.md regarding Flyway DDL auto-creation

Backport of https://github.com/kiegroup/process-migration-service/pull/86/commits/31e9240745d5be5278cff03307aa42afaddecceb

@mareknovotny please merge


jdk_lang_0 java/lang/ProcessBuilder/checkHandles/CheckHandles.java fails with hotspot|openj9 jdk15 on windows

https://github.com/AdoptOpenJDK/run-aqa/runs/1559739592?check_suite_focus=true
TEST RESULT: Error. Use -nativepath to specify the location of native code
--------------------------------------------------
Test results: passed: 837; error: 1

Looks like a new native tests, which should be disabled.

https://github.com/AdoptOpenJDK/run-aqa/runs/1572889491?check_suite_focus=true. Close this.


change: fix build directory in scripts/build_all.py

Description of changes:
Forgot to change this as part of the 1.4.1 upgrade. Tested in my personal account as much as I could (basically up until the local GPU tests, which don't work in our sandboxed builds at the moment).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Allow a default handler to be used

I want to take advantage of the content type guessing this library does, while at the same time specifying which editor the PrettyPageHandler should use.
This PR allows this behaviour by supporting a default handler to be used if no content specific one is in use

Good idea 👍
I prefer it to be configured using a method, instead a constructor. Do you mind to change it to something like this?
$middleware[] = (new Whoops())
    ->defaultHandler(new PlainTextHandler());

And if you can provide a test and edit the README with this new option, it would be great
Thanks!

Mmm, I see.
I think this can be tested mocking the php_sapi_name native function.
You can see an example here: https://github.com/middlewares/client-ip/blob/master/tests/ClientIpTest.php#L136
this middleware uses the native function file_get_contents that is mocked in the tests using the eloquent/phony-phpunit package.

I understand.
The problem is that it requires to install the uopz extension to run the tests and i'd prefer to avoid that if with Phony we have the same result with more compatibility and easy to install.

I can skip the tests if uopz isn't installed, and make it an optional dependency if you'd like?

I understand.

Well, I lied :)
I don't understand what is the problem with Phony to do not use it for testing? I've tried this and works fine:
public function setUp()
    {
        Phony::stubGlobal('php_sapi_name', 'Middlewares')->returns('phpunit');
    }

    public function tearDown()
    {
        Phony::restoreGlobalFunctions();
    }

It works at the moment because you're using php_sapi_name() in the Middlewares namespace.
Because a function called php_sapi_name() doesn't exist in the Middlewares namespace, PHP then goes and looks for a function in the root namespace (\php_sapi_name()).
This is a double function lookup, so is wasted effort, and it is currently one of the big reasons we can't have autoloaded functions yet. It is better if you explicitly call the root namespace function, either by doing \php_sapi_name(), or:
use function php_sapi_name;
...
php_sapi_name();

The benefit of this is that it doesn't do the duplicated function lookup. This is a good habit to get into because there are certain functions that PHP can optimize as long as it knows you want the root namespaced version (see here) for some discussion around this

Ok, got it.
Would it be posible to move this detection to other method, for example private function isCli(): bool, in order to mock this method instead the global function?

That sounds fine, but I don't really have any more time to work on this now sorry. I can delete the uopz stuff and tests if you want to merge this pr and and refactor the code after?

Ok, don't worry. I'll merge this as is, and then will make these changes.
Thanks for your work!

That's great, thanks for the project :+1:

Mmm, one question.
Do you want use the default handler even if the request has the text/html value in the Accept header?

For my specific use case yes, as I want to basically replace the PrettyPageHandler with my handler.
But I guess it should be more flexible than that. Perhaps we should pass in a HandlerFactory that can receive the content type (or any other context) and provide the appropriate handler?

Yes. That sounds to a PSR-11 container, so internally the middleware could do something like this:
$accept = $request->getHeaderLine('Accept');
$handler = $this->container->get($accept);

Using a container would be a bit limiting, as you've only the generic string to pass to get().
By creating a HandlerFactory we can support any other options that come up in the future, or just pass the whole request to it:
$handler = $this->factory->getHandler($request);

Yes, you're right but I prefer now to rely on PSR interfaces for a better interoperatibility.
I've commited the new WhoopsHandlerContainer. You could create a new container extending this and ovewrite the desired method (json(), html(), etc). Let me know if this covers your use case.

Yep that should work for my use case, thanks :+1:

Will you be tagging a new release for this soon?

v1.1.0 released.
(I hope Whoops release a new version soon fixing the PHP 7.2 issues)


Remove validation from git repo url on material list

Summary
Remove .git validation on git repo url
Motivation
https://github.com/devtron-labs/devtron is now a valid git url in material list.
Proposal

fixes #453  partially


Gift Entry - Error toast shown when validation rule is broken

DESCRIPTION:
If I set a validation rule for the Data Import Object, and then attempt to enter a gift in Single Gift Entry that violates the validation rule, I am shown the following error modal instead of my selected error method in the rule:

Error
,"DMLErrorFieldNameMapping":}
If I perform the same action in Batch Gift Entry, I see the expected error message I chose when setting up the rule (Error message at the top of the page):
STEPS TO REPRODUCE

Navigate to Setup > Object Manager > NPSP Data Import
Set up a validation rule for that object to throw an error if a value in the Donation Amount field entered in Gift Entry is over $50 (npsp__Donation_Amount__c>50)
Navigate to the Gift Entry and click New Single Gift
Enter a new Gift that is over $50
Error toast is shown

EXPECTED BEHAVIOR:
User should see this error message instead:

IMPACT TO END-USER :
Bad UX, even though the rule is still firing when expected
WI: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B00000096WNbIAM/view

This issue can no longer be replicated.
We have tried to reproduce this with a validation rule on npsp__Donation_Amount__c setting the Error Location to Top of Page or Field: Donation Amount.


Error on initial scan. Duplicate entry

Just got it up and running in a docker but scanning always errors out.
[Illuminate\Database\QueryException]
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '??I' for key 'artists_name_unique' (SQL: insert into artists (name, updated_at, created_at) values (??INXS, 2016-09-16 18:51:49, 2016-09-16 18:51:49))
[PDOException]
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '??I' for key 'artists_name_unique'

What's your OS?

@mgworek have a look at https://github.com/phanan/koel/issues/404 where the user had the same exact same issue with docker.

I hit the same issue, followed https://qoba.lt/koel_with_docker.html for the initial setup.
Connect to mysql as root and ran:
ALTER DATABASE forge CHARACTER SET utf8 COLLATE utf8_unicode_ci;
ALTER TABLE artists CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci;
ALTER TABLE albums CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci;
ALTER TABLE songs CONVERT TO CHARACTER SET utf8 COLLATE utf8_unicode_ci;

No luck, so I ran the alter table command against every table in forge but continue to see the error. Is there another command I should be running? For now, I'm able to move the problematic Artists out to avoid the issue.

i'm having the same issue, i don't use docker though.
my db setup is using mysql (mariadb 10.1.19), the tables are all set to utf8 (utf8_unicode_ci) - changing the charset or collation around doesn't fix it

anyone? this is a pretty serious issue imo because this error blocks further song scanning & fills up the DB with varying amounts of questionmarks depending on the length of the unicode/cjk name that is inserted into the db

Can you send me one of the problematic songs?
On Friday, December 9, 2016, Robin B<EMAIL_ADDRESS>wrote:

anyone? this is a pretty serious issue imo because this error blocks
further song scanning & fills up the DB with varying amounts of
questionmarks depending on the length of the unicode/cjk name that is
inserted into the db
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/452#issuecomment-265845340, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrt0qtel69KbevcfXugTWTi1n_C-dXiks5rGGdvgaJpZM4J_PT2
.

Closing due to inactivity.


java.io.IOException when getting data from error response

Hi, I have implemented a simple post to an api to make login
return runBlocking {
            val (request, response, result) =  manager.post(URL + resource, params).awaitStringResponseResult()
            result.fold(
                { data ->
                    println(data)
                    return@runBlocking ApiResponse(data,null)
                },
                { error ->
                    return@runBlocking ApiResponse(null,apiResponse.error)
                }
            )
        }

When  the response is ok, there is no problem. The problem occurs when I try to get the data response from an error request. The data that I get is this :
{
    "code": 10,
    "error": "These credentials do not match our records."
}

And this comes with an 401 Unauthorised response. I've just want to get the message from de request.
 Cannot evaluate com.github.kittinunf.fuel.core.Response.toString()
If I try result.error.errorData  it throws Method threw 'java.io.IOException
Here is the exmple post with postman

Any clue how can I get the response?

This only happens when I run it with blocking. If I run it with the async I can do
String(result.error.response.data) and I get the message that I need

New advance!! If I put this to the fuel manager, it works fine
manager.addResponseInterceptor(LogResponseInterceptor)

New advance!! If I put this to the fuel manager, it works fine
manager.addResponseInterceptor(LogResponseInterceptor)

This is really weird. I'm using RX extension for Fuel and also have that problem when receive something what isn't 200.
With LogResponseInterceptor looks good (thanks for that hack @adriamt) but seems like that's bug.
Even if I put whole RX stream to I/O thread, receiving NetworkOnMainThreadException.


Add ability to see user profiles via "View Profile" buttons

-Wrapped each "profile" button in a link conditional to each developers url


rename B50512D to B50612D

I do not believe the broadcom chip is model number "B50512D".  In fact, no such chip exists.  From carefully zooming in on whatever JPEG pics of this chip, I believe it is B50612D.  Also https://stm32world.com/wiki/ColorLight_5A-75B does say

2 1Gb Ethernet PHYs (Broadcom B50612D, just like the RV901T)

So B50612D does seem more likely to be the actual chip.
In this PR, I have renamed B50512D to B50612D and carefully edited in Paint to change that 5 to a 6.
Please confirm by carefully looking at your board before accepting my PR.

Eric,
Due to conflicting PR #104, I've manually updated hardware.md to the right part number. If you also want the image to be updated, can you update this PR?
Tom

Sorry about that conflict.  I have put a new PR #106 which is only changing that 5 to 6 in the picture.


fix issues from golangci-lint

Made to show the issues raised by golangci-lint for issue https://github.com/openshift/kube-compare/issues/22

/ok-to-test

/lgtm
/approve
Linter in CI with another PR


fix typos

"crated" should be "created"
"one failover groups" should be "one failover group"

@talloula : Thanks for your contribution! The author, @anosov1960, has been notified to review your proposed change.

Verified corrections.


blog: canary release in Kubernetes

Signed-off-by: Navendu Pottekkat<EMAIL_ADDRESS>New blog post about canary release in Kubernetes with Apache APISIX.

Hi @bzp2010, please have a read when available 😉


Allow the available costs editable

Right now the available costs are static.  Allow it to be set in the settings.

I ditto this. Would love more customizable costs.

Should be available in the latest version.


Make the game_menu example even drier

Just a small addition to your set of changes from   https://github.com/bevyengine/bevy/pull/12008 This cleanups some oddly places curly braces

LGTM! Thanks for the help!


(ios)@next: on LazyPagerViewer and PagerViewer .setPage could stuck, .setPageWithoutAnimation works fine

Environment
<EMAIL_ADDRESS>react-natve-pager-view-6.0.0-rc.1
iOS 15
Description
Using LazyPagerView and/or PagerView in the @next version on iOS when using ref.setPage(page + 1) the user continues on the "page", if he clicks again he will go to page + 1.
I have a list with 10 items, and another with 3 items. The list with 10 items hangs at each item. I don't think code is needed, but you can see mine below.
When using setPagePageWithoutAnimation everything happens as it should.
Reproducible Demo
<PagerContainer
    ref={listViewerRef}
    initialPage={page}
    data={data}
    buffer={1}
    maxRenderWindow={5}
    scrollEnabled={false}
    orientation="horizontal"
    transitionStyle="scroll"
    renderItem={renderItem}
    keyExtractor={item => item.id}
    onPageSelected={e => setPage(e.nativeEvent.position)}
/>

I'm on a project for release, sorry for not providing a source code. If necessary, I will do my best to provide for it.

I believe it is the same problem as https://github.com/callstack/react-native-pager-view/pull/520, my objective-c abilities are still under development, this PR is a fix for the version 5, I believe is not 100% adaptable.

I just found out that this also happens with PagerView, not just LazyPagerView

You could try v6.0.0-rc.0. If it works there, the issues is likely c558f98a859f3f147cf60cc2091b70e0c585c622.

Solves in https://github.com/callstack/react-native-pager-view/pull/547


Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open e.cash in Web
Navigate to a conversation that has some messages
In a message that only contains text, use the copy function. For web, hover over the message and a menu should appear
Paste the message in a text box

Expected Result:
The message must be shown in the text box without issues
Actual Result:
The size of the compose field there are 2 line breaks before and after the copied text
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/125724351-a00d8af8-c879-4c67-9771-120a4a4325d8.mp4

Expensify/Expensify Issue URL:
View all open jobs on Upwork

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru Not able to reproduce, Could you please try pasting the same copied content here http://madebyevan.com/clipboard-test/
And share the output with us. It will help us debug.

Hi @kavimuru, I'm also not able to reproduce on Chrome, E.cash version v1.0.78-1. I tried a couple of different languages.
For now I'm removing the labels.

Hi @parasharrajat , I'm still able to reproduce with version v1.0.78-1. Attaching video  which included reproducible steps and output from http://madebyevan.com/clipboard-test/
https://user-images.githubusercontent.com/43996225/125782809-45a83e8a-a33f-4b86-8b3b-4fe341ada409.mp4

@kavimuru here's what I'm seeing with the same message:

Clearly this is still occurring for you so lets keep the issue open, but there's no need to block release for this.

mmm I'm also able to reproduce this on my side Web version 1.0.78-1 (Windows / Chrome)

Hmm, I wonder what the differences between our environments is? 🤔
To rule everything out, here is what I'm using:
MacOS Big Sur: `11.4`
Chrome version:  `91.0.4472.114` ✅
Safari version: `14.1.1 (166<IP_ADDRESS>.4)` ✅
Expensify.cash version: `v1.0.78-1`

I wonder if OS system language could be to blame? Or perhaps specific user accounts?

I'm more inclined to the OS system part since it's the only difference in our environments and I was able to reproduce in different testing accounts. 🤔

Issue reproducible during KI retests

Issue reproducible during KI retests

Just retested and I'm still not seeing the error 😕
Sharing this in Slack to get additional testers.

I've tried this on prod v1.0.79-4 in Chrome 91.0.4472.101 and can't replicate at all 🤔

I've also just tried in v1.0.79-4 in Chrome 91.0.4472.114 and can't replicate

v1.0.79-4 on Firefox, also can't replicate.

Are you testing on Mac or Windows? I'm also unable to replicate on my MacOS, but in Windows it has been reproducible since this was reported.

I'll test it on Windows. I am sure that it exists on Windows. I'll try to find the cause and fix it.

All Mac here yes. 🤔

I confirm this is reproducible on Windows Platform. Finding solution now.

I have found the core issue and Solution as well. May be we can triage this issue and I can apply the fix. Or If we are no triaging then you can assign this to me and I will apply the fix.
Exaplanation:

On window platform, copy works a little differently. Its appends and prepends html  & body  tags to the html fragments. And each tag following a newline. HTML tags are successfully trimmed by Str.stripHtml in HTML to MD conversion. but not the newlines between tags.

<span style="color: rgb(0, 0, 0); font-family: "Times New Roman"; font-size: medium; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: pre-wrap; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">test message

Fix:

We have to add another rule where we specify these special tags which need to be trimmed with the ending newline. For now HTML and body tag. We can trimmed the converted string as it is possible that there were  tags for the converted newlines.

I think it would be good to match the ending newline chars with each tag. Thus updating regex of each tag to match this.

Unix tends to use \n as a line separator; Windows tends to use \r\n as a line separator and Macs (up to OS 9) used to use \r as the line separator. (Mac OS X is Unix-y, so uses \n instead; there may be some compatibility situations where \r is used instead though.)

Would you like to take this issue @parasharrajat?

Yeah Sure. My pleasure. I am already tackling other paste-related issues.

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Julesssss just a reminder we need to have a Contributor Manager and Contributor Manager Engineer assigned the issue along with the Contributor, so that we can ensure the job is posted to Upwork + the contributor is hired and paid, and that the CME is able to review the PR.

Job posted on Upwork https://www.upwork.com/jobs/~0112eb53bb4c90676c

Issue reproducible during KI retests

Oh sorry I missed yo update the lib version on NewDot

Issue not reproducible during KI retests (Fixed 🎉)

Paid @parasharrajat 👍🏽


ENUM

Working on Business Central V13.
Trying to import a list of records with 1 enum field via the configuration package. Unfortunately, for some reason, the enum field is ignored. Could you please supply information on ENUM with Config package?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c17285d-1100-c2f7-aa54-588c98bd6834
Version Independent ID: 823c90f0-592f-7d40-6c97-1ac7b7adcf13
Content: How to Prepare a Configuration Package - Business Central
Content Source: business-central/admin-how-to-prepare-a-configuration-package.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Hello,
Thank you for your feedback. Since your question is not about the Help, we suggest that you contact technical support. For more information, see Report a Problem.