sync has become extraordinarily slow

Which version of the AzCopy was used?
10.16.2
Which platform are you using? (ex: Windows, Mac, Linux)
linux
What command did you run?
azcopy sync fpgs-files https://redacted.file.core.windows.net/gs-fp-files?se=2023-01-06t13%3A34%3A38z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-01-06t12%3A34%3A38z&sv=2020-10-02 --delete-destination=true

What problem was encountered?
azcopy sync used to be blazingly fast....now it seems to really struggle
network tests seems ok
ethtool reports linke speed of 10000 mb/s
How can we reproduce the problem in the simplest way?
attempt so sync around a 1000 files in folders to azure file storage
repeat sync
Have you found a mitigation/solution?
no
azcopy sync ouput, 8 minutes to sync 1,000 files????
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 1 Done, 0 Failed, 0 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
Job a1291151-3187-1b49-550f-8e319bcce5f4 Summary
Files Scanned at Source: 1316
Files Scanned at Destination: 1316
Elapsed Time (Minutes): 8.0031
Number of Copy Transfers for Files: 0
Number of Copy Transfers for Folder Properties: 1
Total Number Of Copy Transfers: 1
Number of Copy Transfers Completed: 1
Number of Copy Transfers Failed: 0
Number of Deletions at Destination: 1
Total Number of Bytes Transferred: 0
Total Number of Bytes Enumerated: 0
Final Job Status: Completed
"timestamp":"2023-01-06T12:42:38.756Z","msg":"2023/01/06 12:34:38 AzcopyVersion  10.16.2
2023/01/06 12:34:38 OS-Environment  linux
2023/01/06 12:34:38 OS-Architecture  amd64
2023/01/06 12:34:38 Log times are in UTC. Local time is 6 Jan 2023 12:34:38
2023/01/06 12:34:38 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2023-01-06T12:34:33Z or --include-after=2023-01-06T12:34:33Z
2023/01/06 12:34:38 Any empty folders will be processed, because source and destination both support folders
2023/01/06 12:34:45 Job-Command sync fpgs-files https://REDACTED.file.core.windows.net/gs-fp-files?se=2023-01-06t13%3A34%3A38z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-01-06t12%3A34%3A38z&sv=2020-10-02 --delete-destination=true
2023/01/06 12:34:45 Number of CPUs: 8
2023/01/06 12:34:45 Max file buffer RAM 4.000 GB
2023/01/06 12:34:45 Max concurrent network operations: 128 (Based on number of CPUs. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2023/01/06 12:34:45 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2023/01/06 12:34:45 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2023/01/06 12:34:45 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2023/01/06 12:34:45 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2023/01/06 12:34:45 Max open files when downloading: 1048047 (auto-computed)
2023/01/06 12:34:45 Final job part has been created
2023/01/06 12:34:45 scheduling JobID=a1291151-3187-1b49-550f-8e319bcce5f4, Part#=0, Transfer#=0, priority=0
2023/01/06 12:34:45 Final job part has been scheduled
2023/01/06 12:34:45 INFO: [P#0-T#0] has worker 32 which is processing TRANSFER 0
2023/01/06 12:34:45 WARN: [P#0-T#0] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2023/01/06 12:34:46 PERF: primary performance constraint is Unknown.  States: X:  0, O:  0, M:  0, L:  0, R:  0, D:  0, W:  0, F:  0, B:  0, E:  0, T:  0, GRs: 128
2023/01/06 12:35:16 100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
2023/01/06 12:35:18 PERF: primary performance constraint is Unknown. States: X:  0, O:  0, M:  0, L:  0, R:  0, D:  0, W:  0, F:  0, B:  0, E:  0, T:  0, GRs: 128
2023/01/06 12:35:18 100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
2023/01/06 12:35:20 PERF: primary performance constraint is Unknown. States: X:  0, O:  0, M:  0, L:  0, R:  0, D:  0, W:  0, F:  0, B:  0, E:  0, T:  0, GRs: 128
2023/01/06 12:35:20 100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
2023/01/06 12:35:22 PERF: primary performance constraint is Unknown. States: X:  0, O:  0, M:  0, L:  0, R:  0, D:  0, W:  0, F:  0, B:  0, E:  0, T:  0, GRs: 128
2023/01/06 12:35:22 100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
2023/01/06 12:35:24 PERF: primary performance constraint is Unknown. States: X:  0, O:  0, M:  0, L:  0, R:  0, D:  0, W:  0, F:  0, B:  0, E:  0, T:  0, GRs: 128
2023/01/06 12:35:24 100.0 %, 0 Done, 0 Failed, 1 Pending, 1 Total, 2-sec Throughput (Mb/s): 0
2023/01/06 12:35:26 PERF: primary performance constraint is Unknown. States: X:  0, O:  0, M:

any progress on this? 10 minutes for 14 files????!!
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
.... many more rows....
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
0.0 %, 0 Done, 0 Failed, 14 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
15.0 %, 3 Done, 0 Failed, 11 Pending, 14 Total, 2-sec Throughput (Mb/s): 0.581 (Disk may be limiting speed)
54.4 %, 5 Done, 0 Failed, 9 Pending, 14 Total, 2-sec Throughput (Mb/s): 1.5229 (Disk may be limiting speed)
79.3 %, 8 Done, 0 Failed, 6 Pending, 14 Total, 2-sec Throughput (Mb/s): 0.9629 (Disk may be limiting speed)
79.3 %, 8 Done, 0 Failed, 6 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
94.6 %, 11 Done, 0 Failed, 3 Pending, 14 Total, 2-sec Throughput (Mb/s): 0.5934 (Disk may be limiting speed)
96.6 %, 13 Done, 0 Failed, 1 Pending, 14 Total, 2-sec Throughput (Mb/s): 0.0766 (Disk may be limiting speed)
96.6 %, 13 Done, 0 Failed, 1 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
100.0 %, 14 Done, 0 Failed, 0 Pending, 14 Total, 2-sec Throughput (Mb/s): 0.132
Job f19e901e-382c-2442-7fde-3937742cd754 Summary
Files Scanned at Source: 1373
Files Scanned at Destination: 1377
Elapsed Time (Minutes): 9.7702
Number of Copy Transfers for Files: 12
Number of Copy Transfers for Folder Properties: 2
Total Number Of Copy Transfers: 14
Number of Copy Transfers Completed: 14
Number of Copy Transfers Failed: 0
Number of Deletions at Destination: 116
Total Number of Bytes Transferred: 967484
Total Number of Bytes Enumerated: 967484
Final Job Status: Completed

updated to latest but problem still persists
been reading through the log file to try and work out why its so slow...
per file to upload there are up to 9 tries where it fails....with "http error" assuming some sort of t.o. from the following lines containing ": dial tcp <IP_ADDRESS>:443: i/o timeout...
2023/05/11 23:20:23 ==> REQUEST/RESPONSE (Try=9/30.000283391s[SLOW >3s], OpTime=8m38.346650472s) -- REQUEST ERROR
   PUT https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg?se=2023-05-12T00%3A11%3A37Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-05-11T23%3A11%3A37Z&sv=2020-10-02&timeout=901
   User-Agent: [AzCopy/10.17.0 Azure-Storage/0.8.0 (go1.19.2; linux)]
   X-Ms-Cache-Control: []
   X-Ms-Client-Request-Id: [8cb0e1cd-42b7-423d-7872-3f0f3c65f6c7]
   X-Ms-Content-Disposition: []
   X-Ms-Content-Encoding: []
   X-Ms-Content-Language: []
   X-Ms-Content-Length: [33007]
   X-Ms-Content-Type: [image/jpeg]
   X-Ms-File-Attributes: [None]
   X-Ms-File-Creation-Time: [now]
   X-Ms-File-Last-Write-Time: [now]
   X-Ms-File-Permission: [inherit]
   X-Ms-Type: [file]
   X-Ms-Version: [2020-10-02]
   --------------------------------------------------------------------------------
   ERROR:
-> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/vsts/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.4-0.20220425205405-09e6f201e1e4/pipeline/error.go:157
HTTP request failed

Put \"https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg?se=2023-05-12T00%3A11%3A37Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-05-11T23%3A11%3A37Z&sv=2020-10-02&timeout=901\": dial tcp <IP_ADDRESS>:443: i/o timeout

On the 10th attempt we start to see successful attempts.....
2023/05/11 23:21:21 96.6 %, 13 Done, 0 Failed, 1 Pending, 14 Total, 2-sec Throughput (Mb/s): 0 (Disk may be limiting speed)
2023/05/11 23:21:23 ==> REQUEST/RESPONSE (Try=10/12.948023ms, OpTime=9m38.361855038s) -- RESPONSE SUCCESSFULLY RECEIVED
   PUT https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg?se=2023-05-12T00%3A11%3A37Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-05-11T23%3A11%3A37Z&sv=2020-10-02&timeout=901
   X-Ms-Request-Id: [03baea2c-901a-006a-5f5f-8436ec000000]

2023/05/11 23:21:23 ==> REQUEST/RESPONSE (Try=1/18.24325ms, OpTime=18.48271ms) -- RESPONSE SUCCESSFULLY RECEIVED
   PUT https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg?comp=range&se=2023-05-12T00%3A11%3A37Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-05-11T23%3A11%3A37Z&sv=2020-10-02&timeout=901
   X-Ms-Request-Id: [03baea2d-901a-006a-605f-8436ec000000]

2023/05/11 23:21:23 ==> REQUEST/RESPONSE (Try=1/10.55775ms, OpTime=10.638922ms) -- RESPONSE SUCCESSFULLY RECEIVED
   HEAD https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg?se=2023-05-12T00%3A11%3A37Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=f&st=2023-05-11T23%3A11%3A37Z&sv=2020-10-02&timeout=901
   X-Ms-Request-Id: [03baea2e-901a-006a-615f-8436ec000000]

2023/05/11 23:21:23 INFO: [P#0-T#3] UPLOADSUCCESSFUL: https://[[REDACTED]].file.core.windows.net/[[REDACTED]]/2023-05-12/NMC6243097.jpg
2023/05/11 23:21:23 JobID=f19e901e-382c-2442-7fde-3937742cd754, Part#=0, TransfersDone=14 of 14
2023/05/11 23:21:23 all parts of entire Job f19e901e-382c-2442-7fde-3937742cd754 successfully completed, cancelled or paused
2023/05/11 23:21:23 is part of Job which 1 total number of parts done


[FEAT]: Add loader when waiting for data

Is your feature request related to a problem? Please describe.
While data is being retrieved from the server, it takes few seconds.
Describe the solution you'd like
I feel it would be good to add a loader/spinner so that people know what is going on.
https://www.awesomescreenshot.com/video/14770143?key=384aecf364dee47f72fe4b462aa2179e

Hi @Ananya2001-an
I would like to contribute to this issue

Hi @Ananya2001-an
I would like to contribute to this issue

Sure go ahead.

Hey @msboffl are you still working on this?

Still not yet started, this will be completed by Saturday.


I'm thinking of making some simple system of noticication to let the user know when something works and doesn't work.

Codecov Report

Merging #636 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   14.74%   14.61%   -0.13%
==========================================
  Files          57       58       +1
  Lines         902      910       +8
==========================================
  Hits          133      133
- Misses        769      777       +8

Impacted Files
Coverage Δ

src/controls/main/index.js
0% <0%> (ø)
:arrow_up:

src/panes/Settings.js
0% <0%> (ø)
:arrow_up:

src/controls/main/gc.js
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d731fd...6f2500a. Read the comment docs.


Uncaught InstagramScraper\Exception\InstagramNotFoundException: User with this id not found in

When i try to get the username by getAccountById('193886659') the script return
this error Uncaught InstagramScraper\Exception\InstagramNotFoundException: User with this id not found
I tried with my id account and the return is same.

@filippodicostanzo could you provide steps to reproduce this issue?
Because on test cases everthing works as expected

I have this problem too
[23-Mar-2017 20:34:53 UTC] PHP Fatal error:  Using $this when not in object context in /home/artnema/public_html/instagram/scraper/InstagramScraper/Instagram.php on line 268 [23-Mar-2017 20:42:59 UTC] PHP Fatal error:  Uncaught exception 'InstagramScraper\Exception\InstagramNotFoundException' with message 'User with this id not found' in /home/artnema/public_html/instagram/scraper/InstagramScraper/Instagram.php:299 Stack trace: #0 /home/artnema/public_html/instagram/instabot.php(197): InstagramScraper\Instagram->getAccountById('25025320') #1 /home/artnema/public_html/instagram/instabot.php(224): callback(Array) #2 {main}   thrown in /home/artnema/public_html/instagram/scraper/InstagramScraper/Instagram.php on line 299
and this
[23-Mar-2017 20:34:53 UTC] PHP Strict Standards:  Non-static method InstagramScraper\Instagram::getAccountById() should not be called statically in /home/artnema/public_html/instagram/instabot.php on line 197 [23-Mar-2017 20:34:53 UTC] PHP Strict Standards:  Non-static method InstagramScraper\Instagram::getContentsFromUrl() should not be called statically in /home/artnema/public_html/instagram/scraper/InstagramScraper/Instagram.php on line 294

Update to the last library version


Sort cards more like Arena does

closing out in favor on new branch which will 1) work with the recent refactor, and 2) only sort in certain cases and therefor allow users to drag within a column


Updated open-simplex to have const functions wherever possible

Hello,
This is a propagation of the changes made on the master branch of the "open-simplex-in-c" project.
I updated the module accordingly to allow the noise functions to be called from const ones.
Some other parts (getters, parameters) were also missing the const so I added it to them.
I think this should also be added to the 3.2 branch.
Best regards!

We don't modify thirdparty libraries unless we strongly need to, so here it would be better if you updated the whole library to the latest upstream commit, and not just this specific change. That would also solve the indentation issues introduced by the manual backport.
The new commit being included should be documented in thirdparty/README.md:
https://github.com/godotengine/godot/blob/master/thirdparty/README.md#core

Yes my deepest apologies, I also noticed I forgot to fix the const ref to match the clang-format.
I'm fixing all this and I'll amend the commit hoping not to forget anything.

I fixed the indentation issues and updated the thirdparty/README.md accordingly so I hope it'll be fine now.
Thank you for your time!

Thanks! And congrats for your first merged Godot contribution :tada:

Cherry-picked for 3.2.4.

Cherry-picked for 3.2.4.

Since the commit must be slightly modified in order to be merged and work for the 3.2.4 (Vector does not exist in this version so we should fall back to the PoolVector), does it fall under the category of "easily cherry-picked" PR or should I make another PR for it?

The past tense means that I've done the cherry-pick already :) (in my local branch, I push them as batch once I have a number of commits queued locally).

Thanks for the info :)


docs: add more instructions how to create user

Signed-off-by: João Vanzuita<EMAIL_ADDRESS>

close this issue before merging this PR https://github.com/kubefirst/kubefirst/issues/1146


added profiling = false args to api, controllerManager, and scheduler

Resolves CIS 1.5 issues in regards to profiling of controller manager, api server, and scheduler.

Issue: https://github.com/rancher/k3s/issues/1896


Exception handling

There seems to be quite a bit of unhandled exceptions, which doesn't really help the protecting users principle in the design guide. The below for example tries to change the backup directory to a file and then errors out. However, the backup path in .shallow_backup is changed anyways.

I think program execution should halt gracefully before the users get an ugly traceback and the program's state turns to gobbledygook.
I could start on this if you'd like, I just don't know if you have a preference of how exceptions should be handled.  Will follow that format.

You bring up some great points here. (On mobile, sorry for the unorganized mess of thoughts.)

I think program execution should halt gracefully before the users get an ugly traceback and the program's state turns to gobbledygook.

100% agreed.

I could start on this if you'd like

This would be awesome + very much appreciated. I'm heading out on vacation at the moment, but as soon as I'm back in a week, I can review any PRs you open.
One approach we may want to take is adding logging with something like loguru or even just the built-in logging module so we can avoid showing scary errors to the user while also not losing any helpful debug info.
I would always prefer giving the user a chance to fix non-critical errors as opposed to returning -1 after printing an error message. Erroring out should be a last resort.

The below for example tries to change the backup directory to a file and then errors out. However, the backup path in .shallow_backup is changed anyways.

Well, that's definitely a logic error... Nice catch. Let's make sure to fix it.


How to manage store across components? [question]

Hi,
I have a general question since I'm new to the redux/sagas/reselects/reducers etc...
I'm trying to figure out how does the data flow thorough the app with this organization (default)?
For instance if I would like to fetch the data in Container A, add it to the store, and then read from it in Container B, C, D...?
Now I've been reading through the documentation, issues and code and I'm missing some part(s) definitely :)
How do I access the store in those Containers to push the data and to subscribe to the store?

I must say, Dan Abramov explains it nicely on egghead.io


is there a way to create a page with lists of posts?

I would like to be able to recreate these two pages:
http://www.verona.se/tags.html
http://www.verona.se/archives.html
They are lists of blog posts with just the headings. One is sectioned with dates, the other with categories.
Is this possible?

The /post/ URL works similar to archives (try the demo page at https://sourcethemes.com/academic/post/ ). As for tags, we may add a tags widget in the near future. In the meantime, if you wish to customize any of the layouts yourself, there is lots of info on these topics in the Hugo forum.


The disabled property does not actually disable the button

Adding the disabled property does not have any impact on the button, it continues to work normally, I force pass true and false values and in both cases it does nothing
In addition to this, it would also be useful to be able to define styles for the button and text when it's disabled, something like:
disabledButtonStyle and disabledButtonTextStyle, to match the rest of the property names used in the component
or just a parameter to add a color and opacity value when disabled
Thank you very much for this component.
Note: I only tested on android

Hey, @Pkcarreno have achieved this functionality for disabling style?

Hey @sami3898, I created an internal implementation that uses react-native-select-dropdown and what I did was to manipulate the styles manually with inline styles according to the disabled value that I passed to my component.


RangeError

couchbackup: latest master branch
node: v10.14.1
Changes log file: 2.8GB
--mode full
The changes files gets written but when couchbackup goes to fetch the records, I get this:
buffer.js:270
    throw err;
    ^

RangeError [ERR_INVALID_OPT_VALUE]: The value "3785602604" is invalid for option "size"
    at Function.allocUnsafe (buffer.js:292:3)
    at Function.concat (buffer.js:474:23)
    at Request.<anonymous> (/home/couchbackup/node_modules/request/request.js:1133:30)
    at Request.emit (events.js:187:15)
    at Request.self._source.emit (/home/couchbackup/node_modules/@cloudant/cloudant/lib/eventrelay.js:78:21)
    at Gunzip.<anonymous> (/home/couchbackup/node_modules/request/request.js:1083:12)
    at Object.onceWrapper (events.js:273:13)
    at Gunzip.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1094:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Is this because you are trying to load the log file which is 2.8GB into a node 1GB max buffer? Is there any workaround for this?

Please complete the issue template fully when opening issues. In the absence of the complete information from that template I'm going to assume you are using the same options you outlined in your previous issue #262, in particular --buffer-size 10000.

Is this because you are trying to load the log file which is 2.8GB into a node 1GB max buffer?

No, we stream the log file line by line. The buffer in question here is, I believe, the response from the server with the document revisions.

Is there any workaround for this?

Reduce the --buffer-size so that fewer document revisions are being fetched at once so that their total size does not exceed 1GB per batch. Unfortunately this can be a bit trial and error unless your document size and number of revisions is fairly consistent in which case you can make an estimate.

Node's internal 1GB buffer limit should only be impacted by the number of revisions that get fetched at once. Specifically there will be a new Buffer for each of the HTTP responses, so as long as the --buffer-size is low enough that limit should not be reached. However, the number of HTTP responses being processed in parallel is controlled by the --parallelism. The problem then becomes overall memory consumption - so if you managed to choose a --buffer-size that results in (decompressed) responses of exactly 1 GB and had --parallelism 10 you would need at the very least 10 GB of memory available for the response buffers (and significantly more to account for the various other overheads).
See also #170.

I discovered the problem. It's related to your new changeStream function. This was modified since 2.3.1 and it on your master branch. To solve for it, I forked from tag 2.3.1 and added my incremental code to that. Make sure you test your code on a large database before promoting it to the next version.
New version
https://github.com/cloudant/couchbackup/blob/17c8c155f25cfbb414db6158d65eb79c657e152c/includes/spoolchanges.js#L65
2.3.1 version
https://github.com/cloudant/couchbackup/blob/747f6a733df806d93f7f3eacf085303476ff01b5/includes/spoolchanges.js#L65

We're unable to reproduce this issue. Can you provide us an example dataset we can use to reproduce this issue? Thanks.

I wish I could, but my data contains PHI. Seems that it was happening for any database over 150GB during the backup process.

Thanks @wmbutler we've reproduced the issue now, it is a bug in the Nano 7.x dependency. We won't release the new version of couchbackup until that issue is resolved.
I'll leave this issue open because I think we will want to bump our minimum @cloudant/cloudant version and it in turn should probably bump it's minimum Nano version to ensure the fix is included.


Replace normal tables with Material UI tables for Display of Address list in Profile Panel and Seller Panel

Currently Normal Tables are present with no better functionalities and UI.
Material UI Provides Rich UI Tables with different features such as column sorting, better stacking, adaptive tables etc.
Refer this Material UI Tables

Note

Material UI is already in package

I want to work on this.

should I implement it using DataGrid component or basic MUI table?

Data grid would be good.
Use this for reference :
https://mui.com/api/data-grid/data-grid/

@yash-jain24 any progress

Yeah, I am working on it.

made a PR, review it.

Issue Resolved Closing it Now


Added rough guide on how to cache a docker image

This is a very rough guide on how to use the cache task to speed up docker builds. Would love to hear feedback on how to get this in a good state to merge.

@lawrencegripper : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Any thoughts on getting this merged or updated?

Hi @willsmythe - Could you review the pull request and indicate whether it can be merged? Thanks.

@johnterickson is probably the right person to review.

Hi @johnterickson - Are you able to review the PR and indicate whether it should be merged? Thanks.
Note that you don't show up as a user in the GitHub Assignees feature (top right), which indicates that your GitHub account isn't fully linked to your Microsoft account as described in Link your GitHub and Microsoft accounts; I can't assign the PR to you.

Thanks for submitting this @lawrencegripper !
Have you compared to what we have here: https://github.com/microsoft/azure-pipelines-tasks/issues/11034#issuecomment-560174730 ?
We found "docker load" from local file to be slower than pulling it from a remote registry 😬

So the approach detailed here? https://github.com/fadnavistanmay/Scripts/blob/c7739a722528d7e27cc0f4f6e1adbaf4a1392977/docker.yml
In terms of simplicity I'd rather use the cache than have to setup container registries etc seems like a painful amount of admin. Competitors in this space do this nicely -> https://circleci.com/docs/2.0/docker-layer-caching/
One approach I tried was to identify the docker storage driver used and backup the layers directly from the /lib/docker file but the cache task wasn't running as a user with the appropriate permissions.
In terms of speed I've also observed the approach being slow one reason appears to be because the throughput when downloading the image from cache is slower than I'd expect. I was expecting the cache to be a mounted pageblob onto the VM from Azure Blob rather than a download step (essentially bring the data to the node not have the node download the data).
The docker load call takes around 2mins
-------> Restoring docker image
Loaded image: devcontainer:latest

real	2m9.119s
user	0m0.608s
sys	0m1.735s

Any updates?

Gonna close this one off as there are different approaches maybe it's better suited to a blog post.
For discoverability it would be awesome to see one of the preferred approaches highlighted in the caching dock even if only to say "Don't use the cache feature for docker images, push them to a repository instead it's better"

@lawrencegripper I tried your take on caching docker layers and the buildkit one. Yours seems to only cache the first stage and not the second stage of the dockerfile I used: https://dev.azure.com/wirelab-test/Docker caching/_build/results?buildId=749&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=efa2bfe1-554a-50c8-79b6-ef106ad3c7c2
Here is the buildkit run: https://dev.azure.com/wirelab-test/Docker caching/_build/results?buildId=750&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=bd05475d-acb5-5619-3ccb-c46842dbc997


Coefficients in the loss function and random shifting?

Hi @bdrhtw @hongtaowu67,
In the paper, it seems that the coefficient for every term is 1:

But when I train the policy, it seems that using a higher coefficient on L_arm improves performance.
My loss function looks like this. If it's wrong please let me know...
def masked_loss(pred, target, mask, skip_frame=0, loss_func=F.mse_loss):
    if skip_frame == 0:
        new_pred = pred
    else:
        new_pred = pred[:, :-skip_frame]
    new_target = target[:, skip_frame:]
    new_mask = mask[:, skip_frame:]
    data_shape, mask_shape = new_pred.shape, new_mask.shape
    loss = loss_func(new_pred, new_target, reduction='none')
    for _ in range(len(data_shape) - len(mask_shape)):
        new_mask = new_mask.unsqueeze(-1)
    loss = (loss*new_mask).sum() / new_mask.sum() / math.prod(data_shape[len(mask_shape):])
    return loss

loss = {}
loss['rgb_static'] = masked_loss(pred['obs_preds'], pred['obs_targets'], batch['mask'], cfg['skip_frame'], F.mse_loss)
loss['rgb_gripper'] = masked_loss(pred['obs_hand_preds'], pred['obs_hand_targets'], batch['mask'], cfg['skip_frame'], F.mse_loss)
loss['action_arm'] = masked_loss(pred[ 'arm_action_preds'], batch['actions'][:, :, :6], batch['mask'], 0, F.smooth_l1_loss)
loss['action_gripper'] = masked_loss(F.sigmoid(pred['gripper_action_preds']), batch['actions'][:, :, -1:], batch['mask'], 0, F.binary_cross_entropy)
total_loss = loss['rgb_static'] + loss['rgb_gripper'] +100*loss['action_arm'] + loss['action_gripper']

What coefficient do you use? By the way, in random shifting #5, what padding value do you use?
class RandomShiftsAug(torch.nn.Module):
    def __init__(self, pad):
        super().__init__()
        self.pad = pad # what's the pad value here?

    def forward(self, x):
        x = x.float()
        b, t, c, h, w = x.size()
        assert h == w
        x = x.view(b*t, c, h, w)  # reshape x to [B*T, C, H, W]
        padding = tuple([self.pad] * 4)
        ...

Hi @StarCycle , the coefficients for arm loss, gripper loss, and video loss is 1, 0.01, 0.01. For the padding value, we use 10 for static rgbs and 4 for hand rgbs.

Hi @bdrhtw , great thanks for this answer!


Migrate to purescript 0.12

Thanks for the PR!

@np I've taken the liberty of uploading my own version that is stable for purs v0.12.x and react v16.x. Sorry for the delay, and this wasted effort!


[SSPARK-22769][CORE] When driver stopping, there is error: RpcEnv already stopped

What changes were proposed in this pull request?
When driver stopping, there is a error: org.apache.spark.rpc.RpcEnvStoppedException: RpcEnv already stopped:
17/12/12 18:20:44 INFO MemoryStore: MemoryStore cleared
17/12/12 18:20:44 INFO BlockManager: BlockManager stopped
17/12/12 18:20:44 INFO BlockManagerMaster: BlockManagerMaster stopped
17/12/12 18:20:44 ERROR TransportRequestHandler: Error while invoking RpcHandler#receive() for one-way message.
org.apache.spark.rpc.RpcEnvStoppedException: RpcEnv already stopped.
at org.apache.spark.rpc.netty.Dispatcher.postMessage(Dispatcher.scala:152)
at org.apache.spark.rpc.netty.Dispatcher.postOneWayMessage(Dispatcher.scala:134)
at org.apache.spark.rpc.netty.NettyRpcHandler.receive(NettyRpcEnv.scala:570)
I think the log level should be warning, not error.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #84851 has started for PR 19965 at commit 4d95a7a.

Test build #84851 has finished for PR 19965 at commit 4d95a7a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84851/
Test PASSed.


dlopen _tensor_forest_ops.so failed cause dead lock

Click to expand!
Issue Type
Bug
Source
source
Tensorflow Version
tf 1.14
Custom Code
Yes
OS Platform and Distribution
Linux 4.9.70-040970-generic #201712161132 SMP Sat Dec 16 16:33:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Mobile device
No response
Python version
3.7.2
Bazel version
unknown
GCC/Compiler version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
CUDA/cuDNN version
no
GPU model and memory
no
Current Behaviour?
I got a hang, and gdb got stack trace like bellow, I thought it may be dead lock, why?

#0  __lll_lock_wait_private () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:95
#1  0x00007ff3657fa0f1 in __new_exitfn (listp=0x7ff365b86050 <lock>, listp@entry=0x7ff365b845f8 <__exit_funcs>) at cxa_atexit.c:79
#2  0x00007ff3657fa2a9 in __internal_atexit (listp=0x7ff365b845f8 <__exit_funcs>, d=0x7ff2a5904000, arg=0x7ff2a5905798 <std::__ioinit>, func=0x7ff33dc88830 <std::ios_base::Init::~Init()>)
    at cxa_atexit.c:35
#3  __GI___cxa_atexit (func=0x7ff33dc88830 <std::ios_base::Init::~Init()>, arg=0x7ff2a5905798 <std::__ioinit>, d=0x7ff2a5904000) at cxa_atexit.c:58
#4  0x00007ff2a54b19aa in _GLOBAL__sub_I_generic_tree_model_extensions.pb.cc () from /usr/lib/python3.7/site-packages/tensorflow/contrib/tensor_forest/python/ops/../../libforestprotos.so
#5  0x00007ff3665456fa in call_init (l=<optimized out>, argc=argc@entry=15, argv=argv@entry=0x7ffca53a7848, env=env@entry=0x7ff364844180) at dl-init.c:72
#6  0x00007ff36654580b in call_init (env=0x7ff364844180, argv=0x7ffca53a7848, argc=15, l=<optimized out>) at dl-init.c:30
#7  _dl_init (main_map=main_map@entry=0x7ff2a6d35700, argc=15, argv=0x7ffca53a7848, env=0x7ff364844180) at dl-init.c:120
#8  0x00007ff36654a922 in dl_open_worker (a=a@entry=0x7ffca539b280) at dl-open.c:575
#9  0x00007ff3665455a4 in _dl_catch_error (objname=objname@entry=0x7ffca539b270, errstring=errstring@entry=0x7ffca539b278, mallocedp=mallocedp@entry=0x7ffca539b26f,
    operate=operate@entry=0x7ff36654a510 <dl_open_worker>, args=args@entry=0x7ffca539b280) at dl-error.c:187
#10 0x00007ff366549de9 in _dl_open (file=0x7ff2a6cd1710 "/usr/lib/python3.7/site-packages/tensorflow/contrib/tensor_forest/python/ops/_tensor_forest_ops.so", mode=-2147483646,
    caller_dlopen=0x7ff345bc2fca <tensorflow::internal::LoadLibrary(char const*, void**)+26>, nsid=-2, argc=<optimized out>, argv=<optimized out>, env=0x7ff364844180) at dl-open.c:660
#11 0x00007ff3655bcf09 in dlopen_doit (a=a@entry=0x7ffca539b4b0) at dlopen.c:66
#12 0x00007ff3665455a4 in _dl_catch_error (objname=0x7ff36480e590, errstring=0x7ff36480e598, mallocedp=0x7ff36480e588, operate=0x7ff3655bceb0 <dlopen_doit>, args=0x7ffca539b4b0) at dl-error.c:187
#13 0x00007ff3655bd571 in _dlerror_run (operate=operate@entry=0x7ff3655bceb0 <dlopen_doit>, args=args@entry=0x7ffca539b4b0) at dlerror.c:163
#14 0x00007ff3655bcfa1 in __dlopen (file=<optimized out>, mode=<optimized out>) at dlopen.c:87
#15 0x00007ff345bc2fca in tensorflow::internal::LoadLibrary(char const*, void**) () from /usr/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.1
#16 0x00007ff345bc14f7 in tensorflow::(anonymous namespace)::PosixEnv::LoadLibrary(char const*, void**) () from /usr/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.1
#17 0x00007ff34582708d in tensorflow::LoadLibrary(char const*, void**, void const**, unsigned long*) () from /usr/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.1
#18 0x00007ff34d710557 in TF_LoadLibrary () from /usr/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#19 0x00007ff34894a758 in _wrap_TF_LoadLibrary () from /usr/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#20 0x00007ff365e40ff9 in _PyMethodDef_RawFastCallKeywords (method=0x7ff35dc6ce00 <SwigMethods+14944>, self=<optimized out>, args=0x7ff2f84e3998, nargs=1, kwnames=<optimized out>) at Objects/call.c:694
#21 0x00007ff365e410b5 in _PyCFunction_FastCallKeywords (func=0x7ff35dca85e8, args=<optimized out>, nargs=<optimized out>, kwnames=<optimized out>) at Objects/call.c:730
#22 0x00007ff365e183b4 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at Python/ceval.c:4568
#23 _PyEval_EvalFrameDefault (f=<optimized out>, throwflag=<optimized out>) at Python/ceval.c:3093
#24 0x00007ff365e0fec0 in function_code_fastcall (co=<optimized out>, args=<optimized out>, nargs=1, globals=<optimized out>) at Objects/call.c:283
#25 0x00007ff365e40bef in _PyFunction_FastCallKeywords (func=<optimized out>, stack=<optimized out>, nargs=<optimized out>, kwnames=<optimized out>) at Objects/call.c:415
#26 0x00007ff365e195e6 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at Python/ceval.c:4616
#27 _PyEval_EvalFrameDefault (f=<optimized out>, throwflag=<optimized out>) at Python/ceval.c:3093
#28 0x00007ff365e0fec0 in function_code_fastcall (co=<optimized out>, args=<optimized out>, nargs=1, globals=<optimized out>) at Objects/call.c:283
#29 0x00007ff365e40bef in _PyFunction_FastCallKeywords (func=<optimized out>, stack=<optimized out>, nargs=<optimized out>, kwnames=<optimized out>) at Objects/call.c:415
#30 0x00007ff365e195e6 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at Python/ceval.c:4616

Standalone code to reproduce the issue
no code

Relevant log output
No response

`
(gdb) f 9
#9  0x00007f03a529f5a4 in _dl_catch_error (objname=objname@entry=0x7ffdf17302e0, errstring=errstring@entry=0x7ffdf17302e8, mallocedp=mallocedp@entry=0x7ffdf17302df,
operate=operate@entry=0x7f03a52a4510 <dl_open_worker>, args=args@entry=0x7ffdf17302f0) at dl-error.c:187
187	dl-error.c: No such file or directory.
(gdb) p errstring
$1 = (const char **) 0x7ffdf17302e8
(gdb) p *errstring
$2 = 0x7f03a4fe8750 <_Py_NoneStruct> "4U\001"
`

Hi @haolujun !
Could you provide a reproducible code.
Thank you!


feat(catalog): add an ldap processor

This is the early implementation of an LDAP org data ingestor.
LDAP is pretty free form. Things are just bags of attributes that you kinda hope adhere to some form of a schema, and there are multiple possible such schemas and people add overlays and stuff that may or may not be according to some standard. This makes a processor tricky to make generic/turnkey enough that it's quickly useful, but flexible enough that it can be adapted to the various data layouts out there.

@Rugvip i think that's it (changes in the second commit)

Good stuff, let's get this hooked up somewhere! :grin:


ld: error: undefined symbol: DobbyHook

Spent 6 hours trying to link the static lib dobby to my Android JNI project but to no avail, i'm always getting undefined symbol no matter how I configured on Android.mk.
What's the correct way to link the static lib? I'm not really expert in makefile

paste the link error ?

Lol i somehow got it work by accidently after reverting some changes in Android.mk
Here's my Android.mk if anyone is curious
LOCAL_PATH := $(call my-dir)
LOCAL_DISABLE_FORMAT_STRING_CHECKS := true
LOCAL_DISABLE_FATAL_LINKER_WARNINGS := true

include $(CLEAR_VARS)
LOCAL_MODULE := dobby
LOCAL_SRC_FILES := dobby/libs/$(TARGET_ARCH_ABI)/libdobby.a
include $(PREBUILT_STATIC_LIBRARY)

include $(CLEAR_VARS)
LOCAL_MODULE := private

LOCAL_CFLAGS := -Wno-error=format-security -fvisibility=hidden -ffunction-sections -fdata-sections -w
LOCAL_CFLAGS += -fno-rtti -fno-exceptions -fpermissive -Wextra
LOCAL_CPPFLAGS := -Wno-error=format-security -fvisibility=hidden -ffunction-sections -fdata-sections -w -Werror -s -std=c++17
LOCAL_CPPFLAGS += -Wno-error=c++11-narrowing -fms-extensions -fno-rtti -fno-exceptions -fpermissive
LOCAL_LDFLAGS += -Wl,--gc-sections,--strip-all, -llog
LOCAL_LDLIBS := -llog -landroid -lz -lGLESv2 -lc -lm -ldl -L$(LOCAL_PATH)
LOCAL_ARM_MODE := arm

LOCAL_C_INCLUDES        := $(LOCAL_PATH)/private
LOCAL_C_INCLUDES += $(LOCAL_PATH)/dobby/include

#traverse all the directory and subdirectory
define walk
  $(wildcard $(1)) $(foreach e, $(wildcard $(1)/*), $(call walk, $(e)))
endef

#find all the file recursively under jni/
ALLFILES = $(call walk, $(LOCAL_PATH)/private/)
FILE_LIST := $(filter %.c, $(ALLFILES))
FILE_LIST += $(wildcard $(LOCAL_PATH)/private/*.c)

LOCAL_SRC_FILES := $(FILE_LIST:$(LOCAL_PATH)/%=%)

LOCAL_SRC_FILES += private.cpp

LOCAL_STATIC_LIBRARIES := dobby
include $(BUILD_SHARED_LIBRARY)


Add MidoNet to the list of 3rd party software

Relevant MidoNet commit:
https://github.com/midonet/midonet/commit/4aec3b372b54a6cf0e46e17bcb60fa4300407bb6
Signed-off-by: YAMAMOTO Takashi<EMAIL_ADDRESS>

Thanks! I left some comments on the commit to help you improve the output.


unbranded, PATCH op getting null response model in PetStore

https://github.com/allenjzhang/typespec-e2e-demo/blob/main/petstore/clients/java/src/test/java/petstore/PetsTests.java
curl seems correct.
Not sure about the cause yet.

Previous clientcore cannot handle PATCH with response of chunked encoding.
Alan upgraded the minimum SDK to 17, and switched the HTTP client to the JdkHttpClient.


allowed_methods doesn't work

I tried using :
    'routes' => [
        [
            'path' => '/',
            'middleware' => 'Application\HelloWorld',
            'allowed_methods' => [ 'GET' ],
        ],
   ],

When I tried to call "/" via POST method, it get blank page with 200 status.

or if I set 'allowed_methods' as ['POST'], if I call '/' with 'GET', I still get 200 status.

@samsonasik I think the PR https://github.com/zendframework/zend-expressive/pull/73 fixes this issue. Remember that you need to use also the PR https://github.com/zendframework/zend-psr7bridge/pull/2. Can you try, please? Thanks!

is zendframework/zend-psr7bridge required? we have in "suggest" in composer.json?
Warm regards,
Abdul Malik Ikhsan
Pada 18 Agt 2015, pukul 20.21, Enrico Zimuel<EMAIL_ADDRESS>menulis:

@samsonasik I think the PR #73 fixes this issue. Remember that you need to use also the PR zendframework/zend-psr7bridge#2. Can you try, please? Thanks!
—
Reply to this email directly or view it on GitHub.

@samsonasik it's used by Zf2 route adapter, and it's included in require-dev.

ok, I will try it now

@ezimuel I've just tried and get error: "500 Internal Server Error" :
PHP Deprecated:  Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead. in Unknown on line 0

for note: my composer configuration pull your repo and branch:
{
    "require": {
        "zendframework/zend-expressive": "dev-fix/40",
        "league/plates": "^3.1"
    },
    "repositories" : [ {
        "type" : "vcs",
        "url" : "git://github.com/ezimuel/zend-expressive.git"
        }
    ],
    "autoload":{
        "psr-4": {
            "Application\\": "src"
        }
    }
}

@ezimuel I've retried your repo and branch with disabled error handler template, and it works now.

it can be closed if #73 will be merged

oh, but still, in php log, I still get error:
[Tue Aug 18 21:30:42 2015] PHP Deprecated:  Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead. in Unknown on line 0

@samsonasik That error is unrelated to zend-expressive or any ZF2 components, as we do not access that. Most likely you have an extension that's reading that value; are you trying the Z-Ray Standalone beta, by any chance?

ok, will try that if there is a chance

@weierophinney I've set in php.ini:
always_populate_raw_post_data=-1

and now the error is gone.

closed in favor of #73


localCI: add missing environment variables

with this patch localCI exports next environment variables
before start a process:

LOCALCI_PR_NUMBER

fixes #163
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

lgtm


No way to close Path / Path2D manually

There is no way to close Path and Path2D manually while editing by clicking on it's first point - while it is possible while editing polygons ie. It's only possible by clicking the "close path" button which is quite unusable.

paths are not meant to be closed, so the button to close it was added


Dns watch

:+1: would like to get the travis-ci tests working before we merge anything in

Isn't it possible to do this without a shell script?
Use the new DNS feature in 1.6? http://blog.haproxy.com/2015/10/14/whats-new-in-haproxy-1-6/

ansible-haproxy/requirements.yml
install upstart

Reopen when ready


HBASE-27456 Upgrade the dockerfile used in nightly and pre commit to …

…ubuntu 22.04

I could build the docker image locally, but not sure if it could work in pre commit, especially that we upgrade ruby to 3.0...

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/1/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/1/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  3s
Maven dependency ordering for patch

+1 :green_heart:
hadolint
0m  0s
There were no new hadolint issues.

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 35s
patch has no errors when running spotless:check.

_ Other Tests _

+0 :ok:
asflicense
0m  0s
ASF License check generated no output?

8m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4857

Optional Tests
dupname asflicense spotless hadolint shellcheck shelldocs

uname
Linux aa641fa1cd64 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dc4fa05a2b

Max. process+thread count
34 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/1/console

versions
git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s
master passed

+1 :green_heart:
compile
6m 24s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
6m 18s
the patch passed

+1 :green_heart:
javac
6m 18s
the patch passed

+1 :green_heart:
hadolint
0m  0s
There were no new hadolint issues.

+1 :green_heart:
rubocop
0m  3s
There were no new rubocop issues.

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
7m 53s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4857

Optional Tests
dupname asflicense spotless hadolint shellcheck shelldocs javac rubocop hadoopcheck xml compile

uname
Linux 24280797c8c0 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dc4fa05a2b

Default Java
Temurin-1.8.0_352-b08

Max. process+thread count
139 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console

versions
git=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0 rubocop=1.37.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
1m 42s
master passed

+1 :green_heart:
shadedjars
3m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s
the patch passed

+1 :green_heart:
compile
1m 46s
the patch passed

+1 :green_heart:
javac
1m 46s
the patch passed

+1 :green_heart:
shadedjars
3m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
255m 58s
root in the patch passed.

284m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4857

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 90cea5e6c6cd 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dc4fa05a2b

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/testReport/

Max. process+thread count
4823 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 56s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 18s
master passed

+1 :green_heart:
compile
1m 27s
master passed

+1 :green_heart:
shadedjars
4m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
4m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
375m  5s
root in the patch passed.

404m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4857

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9eb7887305af 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dc4fa05a2b

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/testReport/

Max. process+thread count
4751 (vs. ulimit of 30000)

modules
C: hbase-shell . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/3/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4857/3/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.


Introduce strategic prefetching

Addresses #13

Current coverage is 71.46% (diff: 71.42%)

Merging #85 into master will increase coverage by 0.43%

@@             master        #85   diff @@
==========================================
  Files            22         22
  Lines          3130       3171    +41
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2223       2266    +43
- Misses          698        706     +8
+ Partials        209        199    -10

Powered by Codecov. Last update d71e221...67df7d2


Regarding Spleeters internal data size

I want to develop a similar dataset like your internal datasets. Can you tell us how many hours of internal training data you have used for training the model.

Hi @Parvez2017,
the dataset we gathered was ~200h of audio. Be aware that besides volume, the diversity of the data is also very important. Using realistic data (and not random mixes of sources without musical constraints) can also help. Note that some models can also have very good performances with only public data (such as the musdb dataset).


Retinanet custom backbones

Hello,
I was just wondering if it's possible to use a custom backbone for retinanet saved locally (ie one that is not provided by this library, and not widely available in general).
Thank you so much in advance, and please let me know if there's anything I can clarify!

@Steven-Palayew from what I know it's not very easy to do so. What kind of custom backbone do you have?

Any chance that its a mmdet, or torchvision model?


Validate Repo Integrity

Motivation and Context
Why is this change required? What problem does it solve?:
Validate the integrity of repo data and commit history.
Description
Describe your changes in detail:

crytographic hash of all data (read from disk) and commit refs
validate integrity of commits, data, branches, and historical provenance.
working in manual tests, not automated yet.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[ ] Ready for review
[x] Work in progress

How Has This Been Tested?
Put an x in the boxes that apply:

[ ] Current tests cover modifications made
[ ] New tests have been added to the test suite
[ ] Modifications were made to existing tests to support these changes
[x] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@hhsecond can you take a look at this. The tests aren't complete, it needs documentation, and there are a few corner cases to take care of, but I'd like your opinion on if I'm missing anything significant.
My TODO list right now is:

Handle cases where key / values are slightly malformed. We need to catch exceptions thrown by any parsing methods encountered on the way to the integrity module (I'll highlight concerning regions below)
Acquire the writer lock before running. These methods don't actually write anything, but it wouldn't be fun to deal with changing world state while the checks run.

Also, i'm not sure if I want to be raising a RuntimeError at every point some issue is found? I like the current implementation because:

We don't do any unnecessary work. As soon as an issue is encountered the world comes crashing down and everything stops.
Deliminating issues in the code via a prominent raise RuntimeError(msg) statement is rather nice in terms of readability. There's no guessing what the issue encountered is, or where it was found since theres a detailed error message right there.

HOWEVER, raising errors in this fashion means that it's not really possible to generate a list of issues should there be multiple things wrong . In addition to stopping at the first error it encounters, this doesn't return a machine readable description of the issue. In its current form, there's not any reasonable path towards effective logging or automated attempts to recover data.
These seem like issues for the future, but I'm not sure if you have other thoughts?

TODOS complete and tests finished. When you have a chance, would love to hear your thoughts @hhsecond. No rush.


Collective's host is showing up in various places while not approved yet

Describe the bug
While a collective is pending for approval, we show the host in various places:

Transactions list

Expense(s) page

And probably in some other places where we display the host.
To Reproduce
Steps to reproduce the behavior:

Go to '/create`
Create a collective
Submit an application to the host
Visit pages mentioned above like /expenses

Expected behavior
By default, the host should never be displayed before the collective is approved.
Proposed fix

In collective.host resolvers (v1 + v2), don't return the host if not approved yet
Add a pendingApplication endpoint to fetch the collective's pending host

Also on the expense reimbursement form

I tried proposed fix 1 by returning null for the host resolver if collective.isApproved() is false but I don't think this is a viable option.
For example: my collective's application is pending with HackerGarageMX (pic 1) but if we just don't return the host from the resolver, the frontend doesn't know I have an application in (pic 2)

Also if we don't return a host, we would be able to submit any expenses until it's approved, although maybe this would be a desired behaviour.

I think we could do a 3rd solution, which is to just read collective.isApproved() on the frontend and if so, add a "pending" tag after the host name.

I tried proposed fix 1 by returning null for the host resolver if collective.isApproved() is false but I don't think this is a viable option.
For example: my collective's application is pending with HackerGarageMX (pic 1) but if we just don't return the host from the resolver, the frontend doesn't know I have an application in (pic 2)

That's why the specs propose:

In collective.host resolvers (v1 + v2), don't return the host if not approved yet
Add a pendingApplication endpoint to fetch the collective's pending host

I think we could do a 3rd solution, which is to just read collective.isApproved() on the frontend and if so, add a "pending" tag after the host name.

Checking isApproved on the frontend side is ok, it's arguably less reliable because we'll need to do that check everywhere host is used. Also conceptually, you don't have a host until you've been approved.
But it may be simpler to implement, so I have no strong preference. Choose what you think is best :slightly_smiling_face:

Right, I see, options 1 & 2 were meant to go together! Ok I will think about it.


Influx CLI: Make cli case insensitive

I'm trying to fix #8590 . It's my first PR, happy to hear any comments.
Required for all non-trivial PRs

[x] Rebased/mergable
[x] Tests pass
[x] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

Can anyone help to review this. I'm OK to close it if it's not issue.

@mark-rushakoff Can you review this?


ISPN-15202 Mask Hot Rod and database credentials when serializing con…

https://issues.redhat.com/browse/ISPN-15202

@tristantarrant I tried making work an example with the. branch locally, but is a bit long. So I'm just wondering, is the REST API config also being masked by these changes? on the config side of things for admin users

Thanks @tristantarrant

Don't forget to backport to 14.0.x :slightly_smiling_face:


Set interval timeout for certificates via environment variable

There's no need to run certificate renewal every hour, making it at least configurable would at least allow people such as myself to configure this to a more suitable interval by defining the interval against the environment variable CERT_INTERVAL_TIMEOUT in milliseconds.
There's a further discussion about this over on #677
Note that with the current implementation using setInterval (docs) there are limits to the maximum value of just shy of 25 days due to the value being a 32-bit signed integer.

is this bug fixed https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3580

is this bug fixed #3580

No, this is something completely unrelated.

Closing this issue due to the timer not really having any use due to everything being reloaded once an hour - an oversight on my part. Apparently v3 is being worked on so maybe it'll be fixed then.


chore: tweak module name, follow go mod major version update docs

Update module path to github.com/kevwan/mapreduce/v2.
https://go.dev/doc/modules/major-version

Codecov Report

Merging #3 (bb8b13a) into main (2f778ee) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          209       209
=========================================
  Hits           209       209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f778ee...bb8b13a. Read the comment docs.


Fix: Build errors and double tapping of TimeTravel button

Fixes #237
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[x] If you have multiple commits please combine them into one commit by squashing them.

High level comment: it's generally better to have PRs focused on one particular issue (ie fix the build OR do a bug fix). Otherwise you can get a PR blocked on agreement on one part of it when the other part might be easy to agree on and merge.  (Also, if you ever need to roll something back, it's easier to focus on rolling back one thing).
Lastly - an apology for my slowness at replying. Sky Map is kinda dormant and only gets attention from me now and again.

@jaydeetay No problem at all! Its really good that you are reviewing our PRs.
I'll fix the requested changes.

@jaydeetay PR is updated.

Thanks! And again, sorry for slow responses. I'm probably only going to be able to do reviews once per week at best.
BTW - question for you - there seems to have been a recent uptick in people creating pull requests for Sky Map. I'm very curious - why is this? What prompted you to want to to work on this? (I'll pose the same question to the other recent contributors).

OK, it's good that the 1000ms is now a named constant. However, this seems like a 'band aid' solution rather than a complete fix. I was wondering if you'd considered disabling the buttons on click, and then re-enabling them when the dialog closes. Is that not feasible?

See also: https://github.com/sky-map-team/stardroid/pull/242

@jaydeetay So I should proceed with that fix to disable button after clicking?
We are contributing to this project since this coincides with this year's GSoC 2019 proposal ideas.

Ah thanks, that explains it. There was a thread about that here https://github.com/sky-map-team/stardroid/issues/180 last year that went cold. I don't recall signing up to anything - I wouldn't have had the time to do a decent job unfortunately. I'm a little surprised that Sky Map is on the list for GSoC without  my knowledge. Or perhaps I've just forgotten.

Here's the AOSSIE 2019 project:
https://aossie.gitlab.io/#ideasModal7
...and Gitter channel:
https://gitter.im/AOSSIE/Stardroid
Looks like it's proposing a hard fork, patterned after an iOS version that was developed.

Thanks Sean.
Regarding this PR, I do think it's a bit of a bandaid that we might want to revisit, but I'm happy to try it for now and revisit.


Pleasing clippy

Codecov Report

Merging #1253 (abc41f6) into main (395303b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   94.20%   94.16%   -0.04%
==========================================
  Files         206      206
  Lines       34962    34949      -13
==========================================
- Hits        32935    32911      -24
- Misses       2027     2038      +11

Impacted Files
Coverage Δ

common/src/bitset.rs
98.70% <ø> (ø)

query-grammar/src/user_input_ast.rs
97.77% <ø> (ø)

src/collector/top_score_collector.rs
96.82% <ø> (ø)

src/directory/file_slice.rs
95.08% <ø> (ø)

src/lib.rs
98.82% <ø> (ø)

src/postings/stacker/expull.rs
93.83% <ø> (-0.47%)
:arrow_down:

src/reader/mod.rs
86.90% <ø> (ø)

ownedbytes/src/lib.rs
95.43% <100.00%> (ø)

src/directory/file_watcher.rs
100.00% <100.00%> (ø)

src/fieldnorm/writer.rs
98.48% <100.00%> (-0.09%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395303b...abc41f6. Read the comment docs.


v0.3.15 error darwin x64

:warning:Please attach $TMPDIR/vscode-java-installer/log.txt for more details.
version: 0.3.15
env:
JAVA_HOME: undefined
PATH:
/usr/bin
/bin
/usr/sbin
/sbin
JDKs:
/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home	DefaultLocation

log:
[上午11:00:32] AdoptOpenJDK-11-x64
[上午11:02:28] RequestError: Error: read ETIMEDOUT
[上午11:02:28] Retry downloading ... [1]
[上午11:05:46] Error: read ECONNRESET
[上午11:05:46] Retry downloading ... [2]
[上午11:07:12] RequestError: Error: read ETIMEDOUT
[上午11:07:12] fallback to Adopt API v3
[上午11:08:41] Error: read ETIMEDOUT
[上午11:08:41] Retry downloading ... [1]
[上午11:09:34] Download JDK ... [Completed]
[上午11:09:34] Install JDK
[上午11:09:45] Error occurred
[上午11:09:45] Error: Command failed: installer -pkg /var/folders/00/23hgpnl172zchv_p0lqk5y000000gn/T/vscode-java-installer/binaries/jdk/11/x64/AdoptOpenJDK-11.pkg -target /

info: Started {"timestamp":"2021-09-24T02:23:04.310Z"}
verbose: Ids: {"uiKind":1,"appRoot":"/private/var/folders/00/23hgpnl172zchv_p0lqk5y000000gn/T/AppTranslocation/1C8DD4B6-702D-40F9-9A82-4B3A3E51D5B3/d/Coding Pack for Java.app/Contents/Resources/app.asar","isTelemetryEnabled":true,"machineId":"6c9d2bc8f91b89624add29c0abeae7fb42bf539fa1cdb2e3e57cd668fa9bcead","sessionId":"024bfa35-3ca3-4a5e-848a-c67f9324a5d01632450184187","timestamp":"2021-09-24T02:23:04.314Z"}
verbose: Packed binaries: {"timestamp":"2021-09-24T02:23:08.154Z"}
verbose: Found JDKs in env.JAVA_HOME {"jdks":[],"timestamp":"2021-09-24T02:23:08.157Z"}
verbose: Found JDK {"timestamp":"2021-09-24T02:23:08.160Z"}
verbose: Found JDK {"timestamp":"2021-09-24T02:23:08.163Z"}
verbose: Found JDKs in env.PATH {"jdks":["/usr","/usr"],"timestamp":"2021-09-24T02:23:08.165Z"}
verbose: Found JDKs in WindowsRegistry {"jdks":[],"timestamp":"2021-09-24T02:23:08.166Z"}
verbose: Found JDKs in DefaultLocation {"jdks":["/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home"],"timestamp":"2021-09-24T02:23:08.171Z"}
error: release file not found {"javaHome":"/usr","timestamp":"2021-09-24T02:23:08.171Z"}
warn: Unknown version of JDK /usr {"timestamp":"2021-09-24T02:23:08.171Z"}
verbose: java_home candidate: {"candidate":{"home":"/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home","sources":["DefaultLocation"],"version":8},"timestamp":"2021-09-24T02:23:08.174Z"}
verbose: Installed components: {"vscode":{"homedir":"/Applications/Visual Studio Code.app","version":"1.60.2"},"jdk":{"name":"JDK","homedir":"/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home","version":"8"},"extensions":[],"timestamp":"2021-09-24T02:23:08.176Z"}
verbose: jdk metadata {"release_name":"jdk-11.0.12+7","release_link":"https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7","timestamp":"2021-08-03T10:21:50Z","release":true,"binaries":[{"os":"mac","architecture":"x64","binary_type":"jdk","openjdk_impl":"hotspot","binary_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_size":191257594,"checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz.sha256.txt","installer_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_size":191643541,"installer_checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg.sha256.txt","installer_download_count":67239,"version":"11","version_data":{"openjdk_version":"11.0.12+7","semver":"11.0.12+7"},"heap_size":"normal","download_count":87275,"updated_at":"2021-08-01T13:50:48Z"}],"download_count":724718}
info: Started {"timestamp":"2021-09-24T03:00:27.582Z"}
verbose: Ids: {"uiKind":1,"appRoot":"/private/var/folders/00/23hgpnl172zchv_p0lqk5y000000gn/T/AppTranslocation/387D35DC-CDD7-489D-AAF7-376D3EF53432/d/Coding Pack for Java.app/Contents/Resources/app.asar","isTelemetryEnabled":true,"machineId":"6c9d2bc8f91b89624add29c0abeae7fb42bf539fa1cdb2e3e57cd668fa9bcead","sessionId":"386da24d-50a2-4a0b-b634-9ead242b30fe1632452427406","timestamp":"2021-09-24T03:00:27.585Z"}
verbose: Packed binaries: {"timestamp":"2021-09-24T03:00:30.734Z"}
verbose: Found JDKs in env.JAVA_HOME {"jdks":[],"timestamp":"2021-09-24T03:00:30.736Z"}
verbose: Found JDK {"timestamp":"2021-09-24T03:00:30.740Z"}
verbose: Found JDK {"timestamp":"2021-09-24T03:00:30.742Z"}
verbose: Found JDKs in env.PATH {"jdks":["/usr","/usr"],"timestamp":"2021-09-24T03:00:30.743Z"}
verbose: Found JDKs in WindowsRegistry {"jdks":[],"timestamp":"2021-09-24T03:00:30.744Z"}
verbose: Found JDKs in DefaultLocation {"jdks":["/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home"],"timestamp":"2021-09-24T03:00:30.746Z"}
error: release file not found {"javaHome":"/usr","timestamp":"2021-09-24T03:00:30.747Z"}
warn: Unknown version of JDK /usr {"timestamp":"2021-09-24T03:00:30.747Z"}
verbose: java_home candidate: {"candidate":{"home":"/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home","sources":["DefaultLocation"],"version":8},"timestamp":"2021-09-24T03:00:30.753Z"}
verbose: Installed components: {"vscode":{"homedir":"/Applications/Visual Studio Code.app","version":"1.60.2"},"jdk":{"name":"JDK","homedir":"/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home","version":"8"},"extensions":[],"timestamp":"2021-09-24T03:00:30.762Z"}
verbose: jdk metadata {"release_name":"jdk-11.0.12+7","release_link":"https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7","timestamp":"2021-08-03T10:21:50Z","release":true,"binaries":[{"os":"mac","architecture":"x64","binary_type":"jdk","openjdk_impl":"hotspot","binary_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_size":191257594,"checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz.sha256.txt","installer_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_size":191643541,"installer_checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg.sha256.txt","installer_download_count":67239,"version":"11","version_data":{"openjdk_version":"11.0.12+7","semver":"11.0.12+7"},"heap_size":"normal","download_count":87275,"updated_at":"2021-08-01T13:50:48Z"}],"download_count":724718}
verbose: jdk metadata {"release_name":"jdk-11.0.12+7","release_link":"https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7","timestamp":"2021-08-03T10:21:50Z","release":true,"binaries":[{"os":"mac","architecture":"x64","binary_type":"jdk","openjdk_impl":"hotspot","binary_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_size":191257594,"checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz.sha256.txt","installer_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_size":191643541,"installer_checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg.sha256.txt","installer_download_count":67239,"version":"11","version_data":{"openjdk_version":"11.0.12+7","semver":"11.0.12+7"},"heap_size":"normal","download_count":87275,"updated_at":"2021-08-01T13:50:48Z"}],"download_count":724718}
verbose: jdk metadata {"release_name":"jdk-11.0.12+7","release_link":"https://github.com/adoptium/temurin11-binaries/releases/tag/jdk-11.0.12%2B7","timestamp":"2021-08-03T10:21:50Z","release":true,"binaries":[{"os":"mac","architecture":"x64","binary_type":"jdk","openjdk_impl":"hotspot","binary_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz","binary_size":191257594,"checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.tar.gz.sha256.txt","installer_name":"OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg","installer_size":191643541,"installer_checksum_link":"https://github.com/adoptium/temurin11-binaries/releases/download/jdk-11.0.12%2B7/OpenJDK11U-jdk_x64_mac_hotspot_11.0.12_7.pkg.sha256.txt","installer_download_count":67239,"version":"11","version_data":{"openjdk_version":"11.0.12+7","semver":"11.0.12+7"},"heap_size":"normal","download_count":87275,"updated_at":"2021-08-01T13:50:48Z"}],"download_count":724718}
info: JDK downloaded. {"timestamp":"2021-09-24T03:09:34.897Z"}
error: Command failed: installer -pkg /var/folders/00/23hgpnl172zchv_p0lqk5y000000gn/T/vscode-java-installer/binaries/jdk/11/x64/AdoptOpenJDK-11.pkg -target /
{"code":1,"timestamp":"2021-09-24T03:09:45.870Z"}
verbose: Found JDKs in env.JAVA_HOME {"jdks":[],"timestamp":"2021-09-24T03:12:07.861Z"}
verbose: Found JDK {"timestamp":"2021-09-24T03:12:07.882Z"}
verbose: Found JDK {"timestamp":"2021-09-24T03:12:07.886Z"}
verbose: Found JDKs in env.PATH {"jdks":["/usr","/usr"],"timestamp":"2021-09-24T03:12:07.887Z"}
verbose: Found JDKs in WindowsRegistry {"jdks":[],"timestamp":"2021-09-24T03:12:07.888Z"}
verbose: Found JDKs in DefaultLocation {"jdks":["/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home"],"timestamp":"2021-09-24T03:12:07.889Z"}
error: release file not found {"javaHome":"/usr","timestamp":"2021-09-24T03:12:07.890Z"}
warn: Unknown version of JDK /usr {"timestamp":"2021-09-24T03:12:07.891Z"}

VS Code Java tools require JDK 11+ to launch, and it's possible that AdoptOpenJDK installer was broken due to networking issue.
Can you check file hash of  /var/folders/00/23hgpnl172zchv_p0lqk5y000000gn/T/vscode-java-installer/binaries/jdk/11/x64/AdoptOpenJDK-11.pkg?
Workaround is to download and install a JDK 11 on your own.

Root cause found. AdoptOpenJDK API v3 changed.
E.g. https://api.adoptopenjdk.net/v3/binary/latest/11/ga/mac/x64/jdk/hotspot/normal/adoptopenjdk now points to a .tar.gz file instead of .pkg

fixed in 0.3.16


Fix window getting moved out-of-place while in maximised state

Closes #4070
The issue is coming from the window implementation setting WindowState to Normal regardless of whether it is maximised or not, which causes the window to potentially have its position changed according to the config while being in maximised state.
This also adds SDL_RestoreWindow(handle) to normal state for correct window state updating, as, previously, switching from maximised/minimised state to normal state via WindowState property would do absolutely nothing.

I've tried to look for more elegant ways to solve this, but this is the least inelegant solution I came up with.
Another way could be to just not change position if the window is in maximised state (inside WindowState.Normal switch case), which would win to the current solution in terms of not having to stay for a whole frame stuck in Fullscreen/FullscreenBorderless state while WindowMode is already set to Windowed, but would break switching from maximised state to normal state via WindowState property (as, with this PR, switching to normal state would be restoring the window from maximised/minimised state).
Would appreciate feedback on whether the current pushed solution or the other given solution would work out best here.

I think the "not change position if the window is in maximised state" variant sounds like a saner thing to do seeing whatever that fullscreen workaround is doing, but I'm not sure I'm understanding what the caveat about setting WindowState with that variant would be - would you mind to elaborate what the problem is there?

WindowState already has a Maximised enum state, and would expect Normal to be that the window should be in unmaximised state, in which the window can be moved around the display with no issues.
Choosing the other variant would mean breaking one case of WindowState switching via property setter, as I've already mentioned in the description:

but would break switching from maximised state to normal state via WindowState property (as, with this PR, switching to normal state would be restoring the window from maximised/minimised state).

Quoting the OP again does not answer my question. I was asking since I don't understand the reasoning provided there to begin with.

Ah, my bad, I got driven by my words without looking back at them. using the other variant would cause switching into Windowed mode always makes the window unmaximised regardless of what state it was in, as I've added SDL_RestoreWindow(handle) there for fixing switching from Maximised/Minimised into Normal not causing any effects.

Just as a loose idea, maybe storing info about whether or not the window was maximised previously could be of help? Hesitant to suggest that as the windowing code is close to reaching critical density again, but maybe there is a way to store and use that info in a legible manner...

Hmm, I've tried doing that by window event IDs, and failed to work for me (couldn't tell if an SDL_WINDOWEVENT_RESTORED means from maximised state or from minimised state), but I think I can do this by checking the flags every window event (basically inside the updateWindowSpecifics method), it may not look that good but would 100% be better for getting rid of the "unsynced window state with mode" issue that is present in the pushed solution. Good suggestion, I'll look into doing it tomorrow.


Error submitting deposits on Maya

Current behavior
All deposit transactions on the Maya chain are currently failing with the error below:
Error: Broadcasting transaction failed with code 6 (codespace: sdk). Log: all coins must be native to BASEChain: unknown request
at GA.broadcastTxSync
at async GA.broadcastTx
at async BA
at async Je$1.eval [as deposit]

How to reproduce:
const client = createSwapKit();
await client.connectKeystore(Chain.Maya, phrase);
const hash = await client.deposit({
    assetValue: new AssetValue({
      value: 1,
      decimal: 10,
      chain: Chain.Maya,
      symbol: 'CACAO',
    }),
    memo: test,
    recipient: '',
});

Also fails when registering a MayaName since it also a deposit:
const hash = await client.registerMayaname({
  name: 'test1',
  chain: Chain.Maya,
  assetValue: new AssetValue({
    value: getMAYANameCost(1),
    decimal: 10,
    chain: Chain.Maya,
    symbol: 'CACAO',
  }),
  address: 'maya1.....',
});

Expected behavior
It should work like it does for THORChain.
Functionality

[ ] Swap
[ ] Liquidity
[ ] Savers
[ ] Loan
[ ] Wallet
[X] Transactions
[ ] Api
[ ] Other

Packages

[X] @swapkit/sdk
[X] @swapkit/core
[ ] @swapkit/api
[ ] @swapkit/helpers
[ ] @swapkit/tokens
[ ] @swapkit/types
[X] @swapkit/toolbox-cosmos
[ ] @swapkit/toolbox-evm
[ ] @swapkit/toolbox-utxo
[ ] @swapkit/wallet-evm-extensions
[ ] @swapkit/wallet-keepkey
[ ] @swapkit/wallet-keplr
[ ] @swapkit/wallet-keystore
[ ] @swapkit/wallet-ledger
[ ] @swapkit/wallet-okx
[ ] @swapkit/wallet-trezor
[ ] @swapkit/wallet-wc
[ ] @swapkit/wallet-xdefi

Details
Package versions:
# Paste the output of `<npm|yarn|pnpm|bun pm> ls --depth=0 | grep @swapkit` here

@mattgabriel could you try with newest version? We currently testing Maya and it seems working fine for actions 🤔


remove unwanted log level set to debug in rfx

I saw on debian packages (that have -DWITH_DEBUG_ALL=ON) remotefx logs always to
debug without respect log-level and log-filters settings making difficult
debugging of issue on other parts.
After a search I found this that set loglevel to debug that akallabeth confirmed
is unwanted, this patch remove it.
Closes #6606
I tested it and now respect log-level and log-filters.
Can this backported to next 2.2 stable please? Already tested: http://debomatic-armhf.debian.net/distribution#buster-backports/freerdp2/2.2.0+dfsg1-1~bpo10+1.1

codeql fail is not related to this patch:
 E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/pulseaudio/libpulse0_11.1-1ubuntu7.10_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
Fetched 26.4 MB in 1s (35.5 MB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/pulseaudio/libpulse-mainloop-glib0_11.1-1ubuntu7.10_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/p/pulseaudio/libpulse-dev_11.1-1ubuntu7.10_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

@akallabeth done a PR as you requested, patch already tested

@freerdp-bot test

@Fantu github seems to have broken the builder with an update, we´ll have to wait until it builds again


Fix placeholder resolving in FileWriter

I relied pretty much on the resolving of environment variables in filenames supplied to FileWriter and noticed that occasionally the placeholders would not be replaced at all.
My analysis is as follows:

Previously not all constructors of FileWriter resolved the path.

org.pmw.tinylog.PropertiesLoader#loadWriter makes use of java.lang.Class#getDeclaredConstructors, which, according to the Javadoc, does not return constructors in a particular order, and org.pmw.tinylog.PropertiesLoader#areCompatible, which is responsible for making the two signatures
 FileWriter(java.lang.String, boolean, boolean)                     (1)
 FileWriter(java.lang.String, java.lang.Boolean, java.lang.Boolean) (2)

compare identical.

The constructor was chosen at random (with higher chance of selecting (1)), replacing environment variables most of the time, but leaving the filename as-is in some instances using (2).

My initial fix is adding the missing call to PathResolver.resolve.
I doubt there is actually a need for maintaining both constructors. Maybe there are even more defects  due to the fact that PropertiesLoader does not consistently select the same constructor, like missing  optional values causing an NPE when coerced to one of the primitive types.  I'll leave it up to you to amend the PR with a removal.

Codecov Report

Merging #70 into v1.3 will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##               v1.3      #70   +/-   ##
=========================================
  Coverage     93.01%   93.01%
  Complexity     1325     1325
=========================================
  Files            66       66
  Lines          3464     3464
  Branches        505      505
=========================================
  Hits           3222     3222
  Misses          154      154
  Partials         88       88

Impacted Files
Coverage Δ
Complexity Δ

...inylog/src/org/pmw/tinylog/writers/FileWriter.java
92.5% <100%> (ø)
13 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57695be...363fff7. Read the comment docs.

Thank you for reporting and fixing the bug!

I have just released the fix: http://www.tinylog.org/news#89

Thank you very much, @pmwmedia!
When can I expect 1.3.4 to appear in Maven Central?

It seems that the automatic upload to Maven Central did not work during releasing. I'll analyze it and upload the artifacts manually to Maven Central tonight, if necessary.

@f4lco: tinylog 1.3.4 is available on Maven Central now (http://search.maven.org/#artifactdetails|org.tinylog|tinylog|1.3.4|jar)


App Crashes on devices with versions below Marshmallow

Hi @cinder92 . We experienced an app crash on Android Kitkat (API 19) inside the method: getAll().
We couldn't get the specific line on the stacktrace but we noticed that the error happens inside the new Thread() block. We have managed to bypass the issue by removing the block of code inside the new Thread() block and just let the ContentResolver be executed in the Main Thread.
https://github.com/cinder92/react-native-get-music-files/blob/bd9c9b445a10d311b26bae7207aa2b3b9b501e9c/android/src/main/java/com/reactlibrary/RNReactNativeGetMusicFilesModule.java#L124
When we did that, the App crash ceased to exist. Do you know why this happens? Also, I'm not sure about this, but is it safe to execute a ContentResolver inside a background thread? I think this causes the app crash. Note: We couldn't get the specific line (stacktrace) because the block was inside a thread. We noticed this error showing up though:
E/MediaPlayer-JNI: QCMediaPlayer mediaplayer NOT present
What do you think about this issue?

Hello, thanks for submitting issues, yes, it's better to run that code in a separated thread  for get info of songs faster and prevent to block UI, I will test on device with KitKat, and check what's happening when I have time

fixed on 2.1


Deletion watcher should also work for manual reports

if those are also send to the Tavern on a delay
example :  https://chat.stackexchange.com/transcript/message/43700467#43700467
post was deleted way before the 5 minute mark, but still posted in the Tavern
https://chat.meta.stackexchange.com/transcript/message/6818125#6818125
Please don't do that for already deleted posts

This is specifically a problem with manually reported answers (questions work fine). When we manually report an answer, we don't know the question ID so it can't listen to it for deletions.

@quartata Aren't we fetching the parent for post._parent (so we have a title)?

This was before scan and report were merged

Before we did not fetch the parent as it was only needed for !!/scan

I've gone through the code again and it seems this issue has been fixed. Good to close?

Yeah it looks like it works. If post.parent.post_id is filled in (which it is) then handle_spam automatically calls add_post_site_id_link


Update determine-which-queries-are-holding-locks.md

This sample does not work in Azure SQL Database because Azure SQL Database does not support these ones used in this sample:

sys.server_event_sessions
CREATE EVENT SESSION FindBlockers ON SERVER
ALTER EVENT SESSION FindBlockers ON SERVER
sqlserver.lock_acquired and sqlserver.lock_released event
sys.dm_xe_session_targets

@mufukuha : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Fixed instead by private PR #12531.
Thus now permanently Closing public PRs #3154 and #3155, without merging them into master.
Even though these two public PRs are Closed unmerged, they were successful in that their attempt alerted us o the problem, and helped us to implement an alternative fix for the problem.
@mufukuha Thank you for submitting these PRs. We hope to hear from you again.


GeoGebraClassic v6.0.592.0

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

OfficialEsco we haven't been clear about manifest version.  Our intent is that over time, we will likely have changes to the keys and behavior in a manifest. The 0.1 value represents what the client "currently" support. As we add new keys and other requirements, we will increment the version of the manifest so future clients will know how to take advantage of the changes, and "older" clients encountering newer manifests will be able to appropriately handle them, or be informed that breaking changes happened, and that they should upgrade.

@denelon i was actually thinking it was something like that, just had to test, good to be sure tho, will it say anywhere what version we should use? or will it be the WinGet version?


Update NetQASM to 0.12.1

Looks good. Could you also create a PR for the netqasm repo, updating the squidasm requirement to >=0.10?
I myself will make a release-0.10 branch and also tag this commit as v0.10.0, so that it gets pushed onto pypi. I will write down this procedure somewhere in the near future so that you (and others) can then also do it yourself for future updates.


Update models

Description
Refactoring/cleanup some code based on technical feedback from @SimonBoothroyd

[x] Use Literals in Pydantic models
[x] PotentialHandler.name -> PotentialHandler.type
[ ] Explicitly use Field where possible

[ ] Add descriptions
[ ] Other things that are optional but useful?

[ ] Try out sphinx-pydantic
[x] Make PotentialHandler.expression a Literal
[x] Make PotentialHandler.independent_variables a property, not a field
[ ] Remove duplicated code in openff/system/components/smirnoff.py

[ ] Try out GenericModel?

[ ] Write more validators

[ ] PotentialHandler.parameters (just to make sure the names of the parameters are actually in the expressions)
[ ] Make sure that slot_map and potentials are self-consistent

[ ] Fix L323 in smirnoff.py
[x] SMIRNOFFElectrostaticsMetadataMixin.method validator could be rewritten as a Literal

[ ]  Look into if the Literal class can do some string comparison

[x] Split out contents of misc.py into more explicitly targeted modules
[ ] Make SMIRNOFFPotentialHandler.from_toolkit class methods
[ ] Use SMIRNOFFPotentialHandler.from_toolkit class methods in to_openff_system

Not done with everything I aimed to do originally, but this is already a large set of changes. I'll do the next bits in follow-up PRs.


fix: Update package.json

Fixes #4300
Description
botbuilder-azure v4.16.0 depends on azure-storage v2.10.2 which has a dependency on validator v9.4.1
validator.js prior to 13.7.0 is vulnerable to "Inefficient Regular Expression Complexity"
More details: https://github.com/advisories/GHSA-qgmg-gppg-76g5
The ask is to bump up the version of azure-storage to v2.10.7 which depends on validator v13.7.0
Specific Changes

Updated the version number of azure-storage to 2.10.7 in package.json

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.003%) to 84.522%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
19845

Relevant Lines:
22240

💛  - Coveralls


Change formatter

PR Type

Improvement

Related Links

Description

To use more strict formatters, I changed to use ClangFormat and Black.
Review Procedure

Please check the settings.
Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[ ] Read pull request guidelines
[ ] Code follows coding guidelines
[ ] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the guidelines.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Will merge in the internal repo and sync.


fix: toString utils should unref the Ref<T>

fix #12884

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the main branch for v2.x (or to a previous version branch)
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Vue3 has a replacer parameter in JSON.stringify that call in toDisplayString but as same purpose toString doesn't
I'm not sure if I need to add that parameter or just do unref for Ref<T>

don't depend v3, use type


Webhook retry logic

Description of the change: Add a note about retry logic to the event webhook start guide
Reason for the change: Retry logic was only documented on the troubleshooting page
Closes #5811

Hello @astuteape,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Move FOV-related EventFields stuff into GetFovEvent

Try to make EventFields stuff more self-documenting by moving them into the event classes themselves

Implemented already :D