Send to Registrar button to only show for current or future terms

#382

If the selected term is a current term or future term, the "Send to Registrar" button shows up.
If it is a past term, the button does not show up.
A property for term object called isFutureTerm has been created, which returns True, if the term is a future term, or False, if the term is not a future term.

There is a conflict to resolve.


Type Error:argument of type 'NoneType' is not iterable

Loading config from:  ./projects/ngp/configs/ngp_base.py
load train data
Traceback (most recent call last):
File "/home/featurize/JNeRF/python/jnerf/utils/registry.py", line 33, in build_from_cfg
module = obj_cls(**args)
File "/home/featurize/JNeRF/python/jnerf/dataset/dataset.py", line 111, in init
self.load_data()
File "/home/featurize/JNeRF/python/jnerf/dataset/dataset.py", line 150, in load_data
if 'h' in json_data:
TypeError: argument of type 'NoneType' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/featurize/JNeRF/tools/run_net.py", line 54, in
main()
File "/home/featurize/JNeRF/tools/run_net.py", line 44, in main
runner = Runner()
File "/home/featurize/JNeRF/python/jnerf/runner/runner.py", line 24, in init
self.dataset["train"]   = build_from_cfg(self.cfg.dataset.train, DATASETS)
File "/home/featurize/JNeRF/python/jnerf/utils/registry.py", line 37, in build_from_cfg
raise TypeError(e)
TypeError: <class 'jnerf.dataset.dataset.NerfDataset'>.argument of type 'NoneType' is not iterable
could you help me?

me too，anyone can help?

You need to change this
https://github.com/Jittor/JNeRF/blob/a6f419b6ab24fcfe0f2ea7fc6ca37c9cc1fc2294/projects/ngp/configs/ngp_base.py#L39
to where the folder is located, did you?


Updating API Generation

PR for #99
This is the first step for migrating to the openapi spec at https://api.slack.com/specs/openapi/v2/slack_web.json. From this brief first look, I guess that this will be a breaking change. But we will see.
ToDo:

[x] Parse openapi spec
[x] Generate modules
[x] Generate types
[x] Generate sync methods
[x] Generate async methods
[ ] Test new API

Notes:

I tried to use https://crates.io/crates/openapi, however, it is not able to parse the spec from slack. Guess they do not completely adhere to the definition... The types I use were taken from openapi and were modified till they worked...
I have the problem I'm creating the same types multiple times, because the generator cannot tell that they are the same. Currently I'm solving this using numbers xyz, xyz1, xyz2... Not sure whether there is a better way.
So far it looks like error messages are sometimes missing. And the error message descriptions are always missing...

@brownjohnf @dvaerum @dten
After quite some efford this is ready for testing. As you @dten said, the openid slack spec is not perfect and requires some corrections, still I'm (so far) quite happy about it.
Any chance you folks have them time to help me testing? Also @dten feel free to have a look to check whether this goes into the right direction.

Hey thanks for this gargantuan effort. It's gonna take me a few days to get some time to go through it. 😯😯😯

Three thoughts -
One, merging in scraped results is probably still needed as the OpenAPI specs are super stale.
Two, the 'correct_xx' methods that are empty seem like pure noise: given the use of a wildcard match anyway, I think it would be a much smaller codebase to maintain if only the exceptions were present. e.g. in codegen/src/adapt/admin/apps/mod.rs have fn correct_approve but not correct_restrict. This places no future restriction on such fixups existing in future, but means we don't have a manual set today.
Three, rather than pulling the openapi spec from the web, if we use a git submodule, we could have a fork where these fixes are applied as a patch to the JSON schema directly, rather than in code to the parsed data structure. This might make it easier to maintain and drop them as things get fixed.


added Identity and Threat Protection license

#4862

@mjcaparas The PR that addresses issue #4862 is available for review. Thanks.


ESConnection. isClosed() check error

If I use sql4es driver in apache-comon-dhcp library, Connection initialization error occurs as follows
"initializeConnection: connection closed"
The isClosed () method of ESConnection class may need to be modified as follows:
public boolean isClosed() throws SQLException {
return !active;  // old version <-- active
}

hi seongjookim, congratulations you are the first to open an issue for the driver :). Thanks for reporting this bug. Apparently none of the clients I use perform this check upon connection initialization. I have fixed it according to your suggestion.


Define the public API

I think we should try to define the public API as soon as we can, and then the rest of the implementation can follow. What methods will consumers of this gem be calling?

The only method I plan on adding is .as_gql.


Make sure all our http clients exhaust body before closing.

as per: https://github.com/prometheus/prometheus/pull/5479
This is to make sure we can reuse keep-alive in HTTP1 as much as possible

Merged that so closing this.


Recursive visibility modifier

Currently, using nestify looks very clear and concise for private structs and fields (example from README):
nest! {
    struct UserProfile {
        name: String,
        address: struct Address {
            street: String,
            city: String,
        },
        preferences: struct Preferences {
            newsletter: bool,
        },
    }
}

But this gets cluttered pretty quickly with public fields and structs:
nest! {
    pub struct UserProfile {
        pub name: String,
        pub address: pub struct Address {
            pub street: String,
            pub city: String,
        },
        pub preferences: pub struct Preferences {
            pub newsletter: bool,
        },
    }
}

I'd argue that this is one of the main use cases of the library (modeling public API responses), so maybe improving on it would be a huge improvement for many people.
Would it be feasible to make the pub visibility modifier recursive, just like for attributes? An example would be:
nest! {
    pub* struct UserProfile {
        name: String,
        address: struct Address {
            street: String,
            city: String,
        },
        preferences: struct Preferences {
            newsletter: bool,
        },
    }
}

I think this is an excellent idea and fully in the scope of the project! I currently don't have much time to work on this feature but I should have more time in a few weeks. If anyone would like to contribute than this would be a great place to start.

Thanks! I'd lend a hand myself if I had any knowledge of proc macros, but I'm woefully useless at that.

Don't fear! This is on the roadmap. I will get to it as soon as I can. Again, if someone wants to step in to expedite the process feel free but don't feel obligated. Nestify is still unstable, pre 1.0 release. I plan to include this feature before the stable release!


chore(main): release 1.0.2

:robot: I have created a release beep boop
1.0.2 (2023-02-07)
Bug Fixes

Fix deployment (a6d9090)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/RickCoxDev/exobrain-util/releases/tag/v1.0.2 :sunflower:


docs: update title for mod doc cli guide

Description
Adding "rhoas" to the title of the CLI command ref guide that is generated for modular docs.
Type of change

[ ] Documentation

@pmuir


Cloudwatch logs exports

Corresponding Issue(s):

PRs should have a corresponding issue. If no issue exists, provide details in the Reason for Change(s) section

Summary of change(s):
Enable RDS logs to be exported to CloudWatch logs
Reason for Change(s):

If a bug, describe error scenario, including expected behavior and actual behavior.

If an enhancement, describe the use case and the perceived benefit(s).

Will the change trigger resource destruction or replacement? If yes, please provide justification:
No
Does this update/change involve issues with other external modules? If so, please describe the scenario.
No
If input variables or output variables have changed or has been added, have you updated the README?
Yes
Do examples need to be updated based on changes?
Note to the PR requester about Closing PR's
Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.
This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

Hi @gdelvalle / @johnctitus - looks like I am not authorised to merge this PR, could anyone of you please merge it?


Browser extension

Would a autoredirect browser extension be possible?
I found this: https://addons.mozilla.org/en-US/firefox/addon/farside/
and
https://addons.mozilla.org/en-US/firefox/addon/privacy-redirect/
and this is relevant: https://github.com/SimonBrazell/privacy-redirect/issues/329

There are instructions on how to integrate Farside into a redirector browser extension in the wiki: https://github.com/benbusby/farside/wiki/Browser-Extension
I think it's preferable to use an existing browser extension like the one documented in the wiki, rather than having a specific extension just for Farside.

Thanks


Fixed typographical error, changed accross to across in README.

@martinisoft, I've corrected a typographical error in the documentation of the chef-rvm project. You should be able to merge this pull request automatically. However, if this was intentional or if you enjoy living in linguistic squalor, please let me know and create an issue on my home repository.

Closing due to inactivity.
If this is still an issue please reopen or open another PR.
Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


[[]] does not work for current file

What happened?
Can't query from current note or file
DQL
task from [[]]

table list
from [[]]
flatten file.lists as list

JS
No response
Dataview Version
0.5.41
Obsidian Version
0.15.6
OS
Windows

Can you try [[#]]? I'll try to repro this meanwhile and verify.

Can you try [[#]]? I'll try to repro this meanwhile and verify.

Also doesn't work.
task
from [[#]]

Now I have some crutch query as:
task
where file.name = this.file.name

But if I understand right, its get data from all notes and than filter it.
So it's can be a little bit slower query on big vault.
Am I right?

You are correct.

is you note linking to other notes? [[]] will query all notes linked from the current note, not the current note
https://blacksmithgu.github.io/obsidian-dataview/query/sources/
There was a workaround someway to get the data from the current note though.

You can implicitly reference the current file via [[#]] or [[]]

@dredhorse sorry for the mistake there. I misunderstood the docs and turns out we're both wrong lol. [[]] is all files that link to the current file. I'll fix this in the upcoming doc revamp.

So, there is no way to get query from current file. Yeah?
Only get all files and then filter .

Pretty much. It should be possible to add a from current file type syntax but I don't think I can get around to adding it anytime soon. For now, where file.path = this.file.path is the way for now.

could you try:
<%*  var file = app.workspace.getActiveFile() var t = await app.vault.read(file) task from t %>

could you try: `<%*
var file = app.workspace.getActiveFile()
var t = await app.vault.read(file)
task from t
%>`

is it dataview syntax?

could you try this, where  <% thisDocument %>   equals the filename including path in "
templater code:
let path = tp.file.folder(true)
let thisDocument = """ + path +"/" + title + """
TASK
FROM <% thisDocument %>
WHERE !completed

I never followed up on this but what was the original use case? Perhaps we should zoom out a bit and look at the big picture here.

I personally use this for a meeting log of a repeating meeting and display all the open tasks of those meetings at the top of the document.
this code does work and only displays all open tasks which are in thisDocument, so I guess you need to update the documentation again 😀
This isn't my code IIRC or at least I got some help from somewhere, can't remember.

I never followed up on this but what was the original use case? Perhaps we should zoom out a bit and look at the big picture here.

I also use it for create smth like "Top 3 task todo on this page"

could you try this, where <% thisDocument %> equals the filename including path in "
templater code: let path = tp.file.folder(true) let thisDocument = """ + path +"/" + title + """
TASK
FROM <% thisDocument %>
WHERE !completed

So, i think that if the path change , the link to will be broken, Yeah?

So, i think that if the path change , the link to will be broken, Yeah?
yes, you could try if enclosing the full link in [[]] will work

It's worth repeating that the best way to refer to "current file" without going through other plugins is via where file.path = this.file.path.

which is even better as it will work with renaming and moving the file, thanks.
You should update that part of the documentation 😀


select into from CSV() doesn't work

Trying to insert data from csv to interval table using select * into table from CSV() statement, but it's not working.
SQL:
CREATE table tab(c1 integer);

INSERT INTO tab VALUES (1),(2); -- just for test inserting works correct

SELECT count(*) c1
INTO  tab
FROM
       CSV("https://rawgit.com/thephpleague/csv/master/examples/data/prenoms.csv");

SELECT * INTO HTML("#res1", {headers:true}) FROM tab;

Result is
c1
1
2

After SELECT INTO FROM CSV() content of tab doesn't changed.
Same issue described here

Are you sure you are getting only 3 answers? You hve 4 statements...
Please remember the csv contains no data named c1


[wip]check

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3352/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3553/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11619/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3360/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11627/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3560/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3366/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11633/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3569/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3400/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3603/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11667/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3411/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3614/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11678/

LGTM


HDFS-13734. Allow HDFS heapsizes to be configured seperately

Adds option for HDFS_NAMENODE_HEAPSIZE, HDFS_SECONDARYNAMENODE_HEAPSIZE, HDFS_JOURNALNODE_HEAPSIZE and HDFS_DATANODE_HEAPSIZE to hadoop-env.sh so that hdfs daemon JVM heapsizes can be separately configured. This matches the configuration of YARN daemon's heapsizes.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
1078
trunk passed

+1
mvnsite
152
trunk passed

+1
shadedclient
640
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
31
Maven dependency ordering for patch

+1
mvninstall
105
the patch passed

+1
mvnsite
120
the patch passed

+1
shellcheck
24
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
716
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
132
hadoop-common in the patch passed.

+1
unit
57
hadoop-hdfs in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3248

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux ebde2c5ef778 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cd967c7

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/1/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
105
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
33
Maven dependency ordering for branch

+1
mvninstall
1208
trunk passed

+1
mvnsite
153
trunk passed

+1
shadedclient
755
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
133
the patch passed

+1
mvnsite
153
the patch passed

+1
shellcheck
33
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
820
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
149
hadoop-common in the patch passed.

+1
unit
72
hadoop-hdfs in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

3775

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 0e8fb099a989 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7c7a88

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/2/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
28
Maven dependency ordering for branch

+1
mvninstall
1099
trunk passed

+1
mvnsite
145
trunk passed

+1
shadedclient
657
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
116
the patch passed

+1
mvnsite
141
the patch passed

+1
shellcheck
24
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
729
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
138
hadoop-common in the patch passed.

+1
unit
69
hadoop-hdfs in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3345

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 581146b907eb 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/3/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/3/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
1082
trunk passed

+1
mvnsite
135
trunk passed

+1
shadedclient
692
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
31
Maven dependency ordering for patch

+1
mvninstall
104
the patch passed

+1
mvnsite
116
the patch passed

+1
shellcheck
25
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
666
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
117
hadoop-common in the patch passed.

+1
unit
57
hadoop-hdfs in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3210

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 3a4b2e4f7a5a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/4/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/4/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
1049
trunk passed

+1
mvnsite
128
trunk passed

+1
shadedclient
641
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
28
Maven dependency ordering for patch

+1
mvninstall
105
the patch passed

+1
mvnsite
118
the patch passed

+1
shellcheck
25
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
654
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
117
hadoop-common in the patch passed.

+1
unit
56
hadoop-hdfs in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

3102

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux b5d9c343524e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/5/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/5/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
1042
trunk passed

+1
mvnsite
134
trunk passed

+1
shadedclient
670
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
104
the patch passed

+1
mvnsite
113
the patch passed

+1
shellcheck
25
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
674
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
117
hadoop-common in the patch passed.

+1
unit
64
hadoop-hdfs in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3153

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 6bf06abe3338 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/6/testReport/

Max. process+thread count
447 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/6/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
1250
trunk passed

+1
mvnsite
148
trunk passed

+1
shadedclient
739
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
28
Maven dependency ordering for patch

+1
mvninstall
118
the patch passed

+1
mvnsite
133
the patch passed

+1
shellcheck
31
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
810
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
139
hadoop-common in the patch passed.

+1
unit
64
hadoop-hdfs in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3667

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux f7736e01f271 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/7/testReport/

Max. process+thread count
341 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/7/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
1095
trunk passed

+1
mvnsite
154
trunk passed

+1
shadedclient
688
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
30
Maven dependency ordering for patch

+1
mvninstall
117
the patch passed

+1
mvnsite
136
the patch passed

+1
shellcheck
30
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
719
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
174
hadoop-common in the patch passed.

+1
unit
68
hadoop-hdfs in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

3424

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 10c12519d4cf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/8/testReport/

Max. process+thread count
415 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/8/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
1
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
1200
trunk passed

+1
mvnsite
160
trunk passed

+1
shadedclient
792
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
121
the patch passed

+1
mvnsite
150
the patch passed

+1
shellcheck
33
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
803
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
139
hadoop-common in the patch passed.

+1
unit
66
hadoop-hdfs in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3679

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-403/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/403

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux ff25e9534df2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/9/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-403/9/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


tsconfig: default esModuleInterop & allowSyntheticDefaultImports

Enables projects that use this library to also have esModuleInterop set to false (which is the more strict options), improving ease of use.

I modified the original change request from @candrews so that now the tsconfig default value is used,
which is the same as he intended to use.
This way we have less customs and have the desired outcome.

thanks for the improvement, @candrews .
looking forward having it released in the next days.

@candrews
I got the impression, that you are running your own webpack process on the source code of this project.
If so: Could you elaborate why you are re-packing this library downstream ? It is already in a packed version available, right?
Some background: I want to incorporate a better SPDX license expression validation process. therefore, I wanted to utilize a module which requires esModuleInterop to be enabled, again.

Caused by #271
Might need to reopen this, to get https://www.npmjs.com/package/spdx-expression-parse in
this package exports like module.exports = function () {}
which requires the usage like import {default as foo} from '...'.
And this requires to enable esModuleInterop to be enabled.
Having esModuleInterop not enabled was the purpose of this PR.
So the new code would revert this PR. :-/
any advice, @candrews

see https://github.com/CycloneDX/cyclonedx-javascript-library/pull/547/files#r1136676122

Could you elaborate why you are re-compiling this library downstream ? It is already in a compiled version available, right?

I'm using it in my fork of Snyk CLI that generates CycloneDX SBOMs: https://github.com/candrews/snyk-cli
Here's the PR to the Snyk project which shows exactly the changes in my fork: https://github.com/snyk/cli/pull/3983
This library is imported using:
import * as cdx from '@cyclonedx/cyclonedx-library';

Ah, I remember. Thanks.
So all good, as long as the type declarations consumed downstream do not require esModuleInterop nor allowSyntheticDefaultImports?


add unit tests for connected components (components / views)

relates to #19
edit: guide for testing connected components
https://github.com/reactjs/redux/blob/master/docs/recipes/WritingTests.md#connected-components

still need to figure out how to do bootstrap component


Add wildcard * to Log

Would like to print all columns that start with same name, eg the output of a split.text wrangle. As it stands, I have to declare each one.
Also, may want to allow the same thing in Write output, at least when writing to a file.

This is because the logic to deal with wildcards is applied to the property named input, which most wrangles use.
It needs altering to cover columns.

Added wildcard in log columns
wrangles:
  - log:
      columns:
         - Col*   # Will print all Col1, Col2...

Added also an escape character
wrangles:
  - log:
      column:
        - Col\*  # If there is an column with an asterisk in name it will print only that column


Mountain induced moist baroclinic wave (Hughes et al. 2023)

[ ] Test surfaces with sharp cusps in elevation (verify element edge behaviour of metric terms)
[x] Mountain induced moist baroclinic wave test : verify / implement config following https://gmd.copernicus.org/articles/16/6805/2023/


Different redirect url than http://localhost:7890/redshift/

Driver version

redshift-connector 2.0.917
Redshift version
Not related.
Client Operating System

Ubuntu 22.04.2 LTS running code-server on Kubeflow Notebook in AWS EKS.
Python version

Python 3.10.6
Table schema

Not related.
Problem description

Expected behaviour:
Login with following script should work:
import redshift_connector

conn: redshift_connector.Connection = redshift_connector.connect(
    iam=True,
    database=redacted,
    host=redacted,
    cluster_identifier=redacted,
    credentials_provider='BrowserSamlCredentialsProvider',
    login_url=corporate_sso_login_url,
    region=region,
    preferred_role=redacted
)

This results with a successful login with the IdP but the redirect to the http://localhost:7890/redshift/ is not suitable for me because the redshift_connector is running on a remote server with code-server.

Actual behaviour:
It should be possible to define different redirect url.

Error message/stack trace:

Any other details that can be helpful:
I'm thinking of some solution using proxy but then the redirect url would have to point to the proxy server.
Also, code-server has the functionality to create a proxy for open ports. For example, running the script above creates an endpoint like https://kubeflow.example.com/notebook/nb_ns/nb_name/proxy/7890/.
Any other ideas on how this scenario can be handled are very much welcomed.

Python Driver trace logs

Not related.

Hey @kromanow94,
Thanks for reaching out regarding this. For reference, here is where we implement BrowserSamlCredentialsProvider. The problematic piece of code is the run_server() method, which hardcodes HOST to localhost. One work around to implement a class which extends BrowserSamlCredentialsProvider and modify the run_server() method to use a different value for HOST, and if needed PORT. Unfortunately this is a bit messy given how run_server() is implemented. for example
class myPlugin(BrowserSamlCredentialsProvider):
  def run_server(self, listen_port, idp_response_timeout) -> str:
    HOST = "your_host"
   PORT = "your_port"
   # rest of method

redshift_connector.connect(
    ...,
    credentials_provider="your.path.to.myPlugin",
   ...,

Hey @Brooke-white ,
Thanks for explaining. I'll give it a try. Thanks!

@Brooke-white wouldn't you agree that maybe this should be possible to pass as additional argument (host,port) as part of the redshift_connector?


WIP: virt-controller, hot plug: Avoid race between status update and annotation update

What this PR does
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/cc @AlonaKaplan

@AlonaKaplan @EdDev
do we want this or to close it ?

i am closing it, if someone will see it is important we can reopen


Error compiling dartdevc module:

Error compiling dartdevc module:std_web_store|lib/view/dialogs/order_details_wnd.unsound.ddc.js
We're sorry, you've found a bug in our compiler.
You can report this bug at:
https://github.com/dart-lang/sdk/issues/labels/web-dev-compiler
Please include the information below in your report, along with
any other information that may help us track it down. Thanks!
-------------------- %< --------------------
dartdevc -k arguments: --dart-sdk-summary=C:\Program Files\Dart\dart-sdk/lib/_internal/ddc_sdk.dill --modules=amd --no-summarize -o C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\std_web_store\view\dialogs\order_details_wnd.unsound.ddc.js --source-map --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\meta\meta_meta.unsound.ddc.dill=packages/meta/meta_meta --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\meta\meta.unsound.ddc.dill=packages/meta/meta --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\shopisss_server\src\elements\command.unsound.ddc.dill=packages/shopisss_server/src/elements/command --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\http\src\boundary_characters.unsound.ddc.dill=packages/http/src/boundary_characters --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\pedantic\pedantic.unsound.ddc.dill=packages/pedantic/pedantic --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\utils.unsound.ddc.dill=packages/collection/src/utils --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\algorithms.unsound.ddc.dill=packages/collection/src/algorithms --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\iterable_zip.unsound.ddc.dill=packages/collection/src/iterable_zip --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\comparators.unsound.ddc.dill=packages/collection/src/comparators --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\priority_queue.unsound.ddc.dill=packages/collection/src/priority_queue --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\src\canonicalized_map.unsound.ddc.dill=packages/collection/src/canonicalized_map --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\collection\collection.unsound.ddc.dill=packages/collection/collection --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\typed_data\src\typed_buffer.unsound.ddc.dill=packages/typed_data/src/typed_buffer --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\typed_data\typed_buffers.unsound.ddc.dill=packages/typed_data/typed_buffers --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\typed_data\src\typed_queue.unsound.ddc.dill=packages/typed_data/src/typed_queue --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\charcode\ascii.unsound.ddc.dill=packages/charcode/ascii --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\charcode\html_entity.unsound.ddc.dill=packages/charcode/html_entity --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\charcode\charcode.unsound.ddc.dill=packages/charcode/charcode --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\path\path.unsound.ddc.dill=packages/path/path --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\term_glyph\src\generated\ascii_glyph_set.unsound.ddc.dill=packages/term_glyph/src/generated/ascii_glyph_set --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\source_span\source_span.unsound.ddc.dill=packages/source_span/source_span --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\string_scanner\src\eager_span_scanner.unsound.ddc.dill=packages/string_scanner/src/eager_span_scanner --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\http_parser\http_parser.unsound.ddc.dill=packages/http_parser/http_parser --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\http\http.unsound.ddc.dill=packages/http/http --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\shopisss_server\element_lib.unsound.ddc.dill=packages/shopisss_server/element_lib --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\shopisss_server\controller_lib.unsound.ddc.dill=packages/shopisss_server/controller_lib --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\he_text.unsound.ddc.dill=packages/client_app/model/language/he_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\date_symbols.unsound.ddc.dill=packages/intl/date_symbols --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\src\date_format_internal.unsound.ddc.dill=packages/intl/src/date_format_internal --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\number_symbols.unsound.ddc.dill=packages/intl/number_symbols --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\number_symbols_data.unsound.ddc.dill=packages/intl/number_symbols_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\clock\clock.unsound.ddc.dill=packages/clock/clock --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\src\intl\bidi.unsound.ddc.dill=packages/intl/src/intl/bidi --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\intl\intl.unsound.ddc.dill=packages/intl/intl --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\de_text.unsound.ddc.dill=packages/client_app/model/language/de_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\ar_text.unsound.ddc.dill=packages/client_app/model/language/ar_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\ru_text.unsound.ddc.dill=packages/client_app/model/language/ru_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\es_text.unsound.ddc.dill=packages/client_app/model/language/es_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\fr_text.unsound.ddc.dill=packages/client_app/model/language/fr_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\language\en_text.unsound.ddc.dill=packages/client_app/model/language/en_text --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\controller\ui_util.unsound.ddc.dill=packages/client_app/controller/ui_util --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\view\elements\colors_for_msg.unsound.ddc.dill=packages/client_app/view/elements/colors_for_msg --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\view\elements\callout_dlg.unsound.ddc.dill=packages/client_app/view/elements/callout_dlg --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\view\elements\modal_box.unsound.ddc.dill=packages/client_app/view/elements/modal_box --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\view\elements\note_dlg.unsound.ddc.dill=packages/client_app/view/elements/note_dlg --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\data\product_data.unsound.ddc.dill=packages/client_app/model/data/product_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\data\sale_data.unsound.ddc.dill=packages/client_app/model/data/sale_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\view\store_app\elements\bread_crumb.unsound.ddc.dill=packages/client_app/view/store_app/elements/bread_crumb --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\controller\cmd_event_controller.unsound.ddc.dill=packages/client_app/controller/cmd_event_controller --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\std_web_store\view\elements\bread_crumb.unsound.ddc.dill=packages/std_web_store/view/elements/bread_crumb --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\std_web_store\model\content\base_content.unsound.ddc.dill=packages/std_web_store/model/content/base_content --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\data\supplier_data.unsound.ddc.dill=packages/client_app/model/data/supplier_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\data\tag_data.unsound.ddc.dill=packages/client_app/model/data/tag_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\model\data\group_data.unsound.ddc.dill=packages/client_app/model/data/group_data --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\std_web_store\view\elements\ui_parts.unsound.ddc.dill=packages/std_web_store/view/elements/ui_parts --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\client_app\controller\home_page_controller.unsound.ddc.dill=packages/client_app/controller/home_page_controller --summary=C:\Users\shlomob.L008717\AppData\Local\Temp\scratch_space7e54fab5\packages\std_web_store\model\content\brand_content.unsound.ddc.dill=packages/std_web_store/model/content/brand_content --packages=.dart_tool/package_config.json --module-name=packages/std_web_store/view/dialogs/order_details_wnd --multi-root-scheme=org-dartlang-app --multi-root=. --track-widget-creation --inline-source-map --libraries-file=file:///C:/Program%20Files/Dart/dart-sdk/lib/libraries.json --experimental-emit-debug-metadata --used-inputs-file=C:\Users\SHLOMO~1.L00\AppData\Local\Temp\ddk_builder_79e0363\used_inputs.txt package:std_web_store/view/dialogs/order_details_wnd.dart --no-sound-null-safety
dart --version: 2.14.1 (stable) (Wed Sep 8 13:33:08 2021 +0200) on "windows_x64"
Crash when compiling null,
at character offset null:
Reference to package:std_web_store/view//elements/bread_crumb.dart is not bound to an AST node. A library was expected
#0      Reference.asLibrary (package:kernel/canonical_name.dart:457:7)
#1      LibraryDependency.targetLibrary (package:kernel/ast.dart:673:57)
#2      SourceLoader.computeFullComponent (package:front_end/src/fasta/source/source_loader.dart:1051:38)
#3      SourceLoader.computeHierarchy (package:front_end/src/fasta/source/source_loader.dart:1068:38)
#4      KernelTarget.buildOutlines. (package:front_end/src/fasta/kernel/kernel_target.dart:333:14)

#5      withCrashReporting (package:front_end/src/fasta/crash.dart:121:12)

#6      IncrementalCompiler.computeDelta. (package:front_end/src/fasta/incremental_compiler.dart:304:38)

#7      _compile (package:dev_compiler/src/kernel/command.dart:341:32)

#8      compile (package:dev_compiler/src/kernel/command.dart:51:12)

#9      _CompilerWorker.performRequest (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/bin/dartdevc.dart:68:18)

#10     AsyncWorkerLoop.run (package:bazel_worker/src/worker/async_worker_loop.dart:35:20)

#11     main (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/bin/dartdevc.dart:31:5)

#0      Reference.asLibrary (package:kernel/canonical_name.dart:457:7)
#1      LibraryDependency.targetLibrary (package:kernel/ast.dart:673:57)
#2      SourceLoader.computeFullComponent (package:front_end/src/fasta/source/source_loader.dart:1051:38)
#3      SourceLoader.computeHierarchy (package:front_end/src/fasta/source/source_loader.dart:1068:38)
#4      KernelTarget.buildOutlines. (package:front_end/src/fasta/kernel/kernel_target.dart:333:14)

#5      withCrashReporting (package:front_end/src/fasta/crash.dart:121:12)

#6      IncrementalCompiler.computeDelta. (package:front_end/src/fasta/incremental_compiler.dart:304:38)

#7      _compile (package:dev_compiler/src/kernel/command.dart:341:32)

#8      compile (package:dev_compiler/src/kernel/command.dart:51:12)

#9      _CompilerWorker.performRequest (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/bin/dartdevc.dart:68:18)

#10     AsyncWorkerLoop.run (package:bazel_worker/src/worker/async_worker_loop.dart:35:20)

#11     main (file:///C:/b/s/w/ir/cache/builder/sdk/pkg/dev_compiler/bin/dartdevc.dart:31:5)

@johnniwinther This looks like it's coming from a call to IncrementalCompiler.computeDelta() on package:dev_compiler/src/kernel/command.dart:341:32. Are you aware of any recent changes that could be related?
Not sure if this is a red herring but I noticed the error message includes a path with an extra / in the middle. 'package:std_web_store/view//elements/bread_crumb.dart'.

Maybe it related to https://github.com/dart-lang/sdk/issues/46706
@jensjoha Can you take a look at this?

You are right
The reason for the error is the extra /
But I think this kind of error should have been discovered before the compiler stage

I've reproduced this (e47850a197c5d2522e67a1b8dd11427829ce6f04).
Caveat: The below has ended up in a semi-unstructured brain-dump, and I apologize, but will post it anyway.
This is what happens:

For URIs "a/b/c.dart" and "a/b//c.dart" are different. For (some? most? all?) file systems they're the same file though.
In this case one "module" has serialized the "a/b/c.dart" version and another module has used (and found on disk because the file system doesn't care) the "a/b//c.dart" version (while not serializing it itself), but saving a reference to it.
When reading the modules we have no "a/b//c.dart" version because it was never serialized (but is still referenced) --- so when we try to follow that reference we get the crash.

We've also seen this issue before with weird error messages like "Foo is not Foo" because a class "Foo" from lib "a/b/c.dart" is not a class "Foo" from lib "a/b//c.dart".
Furthermore this problem generalizes - at least on Windows - where "a/b/c.dart" and e.g. "a/b/C.dart" also yields the same file, but are two different URIs and thus becomes two different libraries.
In many ways this is equivalent to the build system not giving us all needed files, something we expect not to happen, which is why we (evidently) don't check for it. Maybe we should? (/cc @johnniwinther ) (I don't know how expensive that is). But also, at that point what are we actually supposed to do? I doubt we can actually give a good error message. (Maybe the part of the system that picks out the stuff that we want to serialize could give an error if given something we're not expecting? (say we're asked to compile "lib.dart" and given from dill a library "a/b/c.dart" and returned back "lib.dart", "a/b/c.dart" and "a/b//c.dart") --- but still this feels to late and can we get a good error message?).
Ideally we would give an error when importing the "wrong" version (say "a/b//c.dart" or "a/b/C.dart"), but how can we know if it's the wrong version? Can we define in the language that importing or exporting a uri with a double-slash is an error or a warning or something, and/or that if a program is importing and exporting something where two or more uris are duplicates in their lower-case-representation it's a warning or an error or something? (/cc @lrhn ) (on (most?) linux machines that could otherwise be a perfectly valid program).
Can we somehow from the filesystem extract what a "canonical" representation of the file identifier is? (so that we silently just rewrite the import).
What does the analyzer do in situations like this? (/cc @bwilkerson )

The analyzer ignored the problem and did not present the situation as a problem.

@jensjoha If there is a solution here it sounds like it will be handled by the CFE. I'm going to move this to a different area label. If you think it should come back tot he web please feel free to update it.

No one from the analyzer team has explained what the analyzer does in situations like this. That it doesn't crash for instance doesn't mean it's doing the right thing (whatever that might be).
No one from the language team has explained what they'd expect happen in a situation like this, if there is a way to get the "canonical path" from the filesystem etc.
In many ways this is (also) a failing of the build system --- it provides the CFE with what is basically invalid/incomplete data.
Having one "area" label here does not seem to do justice to the issue.
I'll try to /cc people agian: @johnniwinther @bwilkerson @lrhn

The current language specification is clear: If the URIs are different, they're defining different libraries. From the language's perspective, that's all there is to it. (It doesn't know about build systems or serialized code. It doesn't even know what a file system is, that's considered an implementation detail.)
I have a request for allowing the front-ends to be smarter about URIs in source code, but nothing has happened yet, so the specification stands.
That doesn't mean that tools can't be smarter about everything other than import URIs in source code.
Command line paths is one case where we read something as either a URI or a file path, and it's perfectly reasonable to be clever about making that distinction (as long as all our tools agree on how to be clever). The language doesn't care how you get to the URI used for the entry point script, as long as it gets one.
We can also choose to warn about any source URI containing double-slashes, or even any upper-case letters, because you really just shouldn't use those by accident.
So, from my perspective: Do whatever makes things work, as long as it's consistent.


⚠ Bofrost.at has degraded performance

In ddcd08b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1188 ms

Resolved: Bofrost.at performance has improved in ca8e733.


Load _data

Hi guys,
How I can read the contents of _data object?
I'm using the customer method to check if a Customer already exists!!
br,

@fl0at1n9 How did you do this? Thanks!

@jhnferraris Sorry, but I stopped using the Chargify implementation because Chargify didn't fit our pricing model


Create endpoint for getting recent github PR of selected repos

Description
Create endpoint for getting recent github PR of selected repos, this api will be consumed from the frontend to display the most recent PRs on the landing page of dzcode.io
Check List

[x] setup route(s)
[x] setup controller(s)
[x] setup service(s)

Additional Comments
i'm not sure if you need github credential for calling their APIs

closing as done


Use near-workspaces for integration tests

We already using this for ACL. Other tests using cross-contract calls will also be moved to use this pattern.


minitest: add hamsternz display port

@acomodi This minitest seems to expose more of the GTP logic than the SATA test case (714 unknown bits in DisplayPort test vs 357 unknown bits in SATA).
With the latest results, how many unknown bits are left in this DisplayPort minitest?

@acomodi This minitest seems to expose more of the GTP logic than the SATA test case (714 unknown bits in DisplayPort test vs 357 unknown bits in SATA).
With the latest results, how many unknown bits are left in this DisplayPort minitest?

@litghost With the latest fuzzers for the GTP merged, the count is:

SATA: 15 unknown bits, which correspond to:

Clock PIPs in the GTP_COMMON_MID (for the 200T only
IBUDFS_GTE2 --> GTP_COMMON direct connection
PIPs in the GTP_INT_INTERFACE tile that seem to increase the signal path, as it bounces to a DELAY node (unsure how this is triggered)

For DisplayPort there are a total of 53 unknown bits. Most of these, though, do not correpsond to the GTP, but rather to the IOB/INT/HCLK segment of another clock region. I am not sure why these show up though. If we take only the unknowns corresponding to the GTP, we are down to 8 unknown bits (PIPs and IBUFDS_GTE2 --> GTP_COMMON).

@litghost With the latest fuzzers for the GTP merged, the count is:

SATA: 15 unknown bits, which correspond to:

Clock PIPs in the GTP_COMMON_MID (for the 200T only
IBUDFS_GTE2 --> GTP_COMMON direct connection
PIPs in the GTP_INT_INTERFACE tile that seem to increase the signal path, as it bounces to a DELAY node (unsure how this is triggered)

For DisplayPort there are a total of 53 unknown bits. Most of these, though, do not correpsond to the GTP, but rather to the IOB/INT/HCLK segment of another clock region. I am not sure why these show up though. If we take only the unknowns corresponding to the GTP, we are down to 8 unknown bits (PIPs and IBUFDS_GTE2 --> GTP_COMMON).

For DisplayPort there are a total of 53 unknown bits. Most of these, though, do not correpsond to the GTP, but rather to the IOB/INT/HCLK segment of another clock region. I am not sure why these show up though. If we take only the unknowns corresponding to the GTP, we are down to 8 unknown bits (PIPs and IBUFDS_GTE2 --> GTP_COMMON).

That likely points to a missing IOB feature.  This probably needs to be fixed, but might not block the GTP/PCIe efforts.

For DisplayPort there are a total of 53 unknown bits. Most of these, though, do not correpsond to the GTP, but rather to the IOB/INT/HCLK segment of another clock region. I am not sure why these show up though. If we take only the unknowns corresponding to the GTP, we are down to 8 unknown bits (PIPs and IBUFDS_GTE2 --> GTP_COMMON).

That likely points to a missing IOB feature.  This probably needs to be fixed, but might not block the GTP/PCIe efforts.

PIPs in the GTP_INT_INTERFACE tile that seem to increase the signal path, as it bounces to a DELAY node (unsure how this is triggered)

Presumably this is just the router fixing a hold violation.  You should be able to toggle the DELAY by using route_via on those paths.

PIPs in the GTP_INT_INTERFACE tile that seem to increase the signal path, as it bounces to a DELAY node (unsure how this is triggered)

Presumably this is just the router fixing a hold violation.  You should be able to toggle the DELAY by using route_via on those paths.

For DisplayPort there are a total of 53 unknown bits.

I was able to replicate this using the latest prjxray-db!

For DisplayPort there are a total of 53 unknown bits.

I was able to replicate this using the latest prjxray-db!


Implement efficient unit testing

Integration testing is good, but takes a long time. Implement simpler, efficient unit testing. Efficient in this case means avoiding any actions that involve network calls if possible. This means vendoring Django in order to build a tmp project environment without making a network call, ie a simple pip install django.

[x] Make a vendor/ directory, and download Django, django-bootstrap5 and requests to this directory.
[x] Install pytest.
[ ] Have pytest build a tmp project directory with the sample project, and install requirements from the vendor directory.
[ ] Run this offline to verify no network calls are happening.
[ ] Write a simple unit test for work related to the ALLOWED_HOSTS setting.
[ ] Verify that none of this is included in the next release.

Notes

Add a package to vendor/: pip download --dest vendor/ package_name

Small tasks

[ ] Copy sample project to temp directory.
[ ] Run simple_deploy against sample project.
[ ] Write two test functions.
[ ] Make sure setup work is only being done once.

Mocking heroku create

When we call manage.py simple_deploy, it expects us to have already run heroku create. We need the output of heroku apps:info in order to run simple_deploy successfully.
How mock heroku apps:info?

One idea was to add fake info to the test instance of the sample project, but apps:info queries Heroku for information about the given app. That won't work for a fake project.
Need to add a testing flag to simple_deploy, so we can call it in a way that uses mock testing output.

Merging

I messed up, and started the branch unit_testing directly without merging the fixes from windows_bugfix.
So, now unit_testing and windows_bugfix are both off of stale branches.
[ ] Carry changes from windows_bugfix over to unit_testing.
[ ] Test all versions locally.
[ ] Test on Windows.


Minimap

On behalf of @Logan7432
For those who don't know what it is, tiny map on some part of the screen showing a zoomed-out view area.

I have minimap code and the minimap.png but i dont know how to code it into the game so that it shows up in the browser when i start the server. How do i give you or the public the code and picture in case you have the time to code into the game?

It would be a good idea to create a new gist that contains all your code https://gist.github.com/

https://gist.github.com/Logan7432/57014a3f4dffbcebea47 Heres the link to the code :) im not sure how to give you the minimap.png

Isn't that code from one of the unofficial Agario websites?

I am noob on how to use canvas, but i think this feature request is important. For something like a litle Spectate mode inside the gameplay. That would be awesome .

This could probably be implemented using a minimap plugin such as the jQuery one.


feat(patternplate): allow configuring patterns via single file

Allows configuring patterns by defining a single file at the root of the
repository. .commitlint-patterns.json contains an array of patterns. Fallback
to the previous method (which to be honest I do not understand at all) is
provided when there's no such file, or there's an error parsing the JSON.
Small documentation change in its README.

Thanks for your contribution. I understand this is motivated by #109?
Could you explain your use case?
Are you using https://github.com/sinnerschrader/patternplate?
If you want to define scopes for your project you can do so by configuring the type-enum rule:
// commitlint.config.js
module.exports = {
  extends: ['@commitlint/config-angular'],
  rules: {
    'scope-enum': [2, 'always', ['something', 'other']]
  }
};

I think having a single file without having to mess with the config or having the aforementioned dir structure could be highly beneficial. Maybe a different config if it doesn’t make sense to integrate into this one?

Sorry, I don't understand what you are getting at. commitlint.config.js is the single file users expect commitlint related things to happen in.
config-patternplate has a very narrow use case related to the patternplate OpenSource project I also maintain. If you do not use it you most likely do not want to use config-patternplate.
Are you using patternplate?
If you want to use scopes specific to you project you'll want to configure that via commitlint.config.js. If you insist on keeping scopes in a different file you already can do so like this:
// commitlint.config.js
const scopes = require('./.commitlint-patterns.json');

module.exports = {
  extends: ['@commitlint/config-angular'],
  rules: {
    'scope-enum': [2, 'always', scopes]
  }
};

@blackxored Could you have a look at my questions? Thanks!

You’re right. I agree on the single config, so at the end of the day it’s more of a documentation issue. I found it handy to be able to just share a config on npm for doing this, but it should be a separate one at best.

Closing this accordingly. PRs with docs improvements welcome!


Added WebSocketClient protocol for mocking

up

Sorry about the delay in responding. I have been going back and forth on this. I get the usefulness for mocking in creating the WebSocketClient protocol, but it does add a little bit of complexity just for the sake of mocking. I'm kinda of indecisive on if that is a trade off worth making. Not to drag this out any longer, but let me get some feedback from some folk. Thank you for your patience in my indecision 😄.

up

@daltoniam Im currently working on a branch that moves the connection logic out of the main WebSocket class into a dedicated class. The idea being users can switch in and out that connection class if needed to support things like custom proxies etc and taking over of existing connections. Maybe we could merge this concept of mocking into that in that there is a dedicated connection class that is set up for mocking that would not pollute the main code base.

I did some refactor work for Swift 4 (version 3.0.0) and add this in. Sorry it took so long to get in, but all joy now 😄. Thanks for the PR!


No type and Provided by when setting's not assigned value

It's with the latest version sbt 0.13.6-SNAPSHOT built from the sources today:
> about
[info] This is sbt 0.13.6-SNAPSHOT
[info] The current project is {file:/Users/jacek/sandbox/so/conditional-setting/}conditional-setting 0.1-SNAPSHOT
[info] The current project is built against Scala 2.10.4
[info] Available Plugins: sbt.plugins.IvyPlugin, sbt.plugins.JvmPlugin, sbt.plugins.CorePlugin, sbt.plugins.JUnitXmlReportPlugin, com.typesafe.sbt.SbtProguard, growl.GrowlingTests, sbtman.Plugin, np.Plugin, com.timushev.sbt.updates.UpdatesPlugin
[info] sbt, sbt plugins, and build definitions are using Scala 2.10.4

With the following build.sbt the setting doesn't get the type and Provided by printed out with inspect.
$ cat build.sbt
lazy val xxx = settingKey[String]("Test setting")

//xxx := "Hello"
$ xsbt
[info] Loading global plugins from /Users/jacek/.sbt/0.13/plugins
[info] Loading project definition from /Users/jacek/sandbox/so/conditional-setting/project
[info] Set current project to conditional-setting (in build file:/Users/jacek/sandbox/so/conditional-setting/)
> inspect xxx
[info] No entry for key.
[info] Description:
[info] 	Test setting
[info] Reverse dependencies:
[info] 	*:check
[info] Delegates:
[info] 	*:xxx
[info] 	{.}/*:xxx
[info] 	*/*:xxx

When build.sbt has the setting assigned a value (the line with xxx := "Hello" gets uncommented) inspect shows the type and Provided by.
> inspect xxx
[info] Setting: java.lang.String = Hello
[info] Description:
[info] 	Test setting
[info] Provided by:
[info] 	{file:/Users/jacek/sandbox/so/conditional-setting/}conditional-setting/*:xxx
[info] Defined at:
[info] 	/Users/jacek/sandbox/so/conditional-setting/build.sbt:5
[info] Reverse dependencies:
[info] 	*:check
[info] Delegates:
[info] 	*:xxx
[info] 	{.}/*:xxx
[info] 	*/*:xxx

I'd call it a bug as there's no way to know the type of the setting.

So, can this be closed?


Add an option to remove 'Playing {song name}'

yeah. Pretty self explanatory.

As of the latest commits to the review branch, this will update to show the number of servers if multiple servers are playing music.

How would I go about using that branch? Would I just git-clone it?

You should be using review regardless. No other version is supported anymore. You can get it by cloning, and then git checkout review

I'm probably not going to add an option to remove the np message entirely.  It's fixed for multiserver, but if you want to disable it you can tweak the code yourself.  That would be the update_now_playing function.


GraphQL support! 🎉

This is very exciting!
Summary of changes:

Add GraphQL support!
Move types into types.ts
Tidied tsconfig

Things left to do in this PR:

Update the documentation.

Things out of scope for this PR:

There are no tests for GraphQL here. I largely blame this on us using out of date versions of fetch-mock and xhr-mock which used to not be the easiest to test with. In their latest iterations, they provide much nicer ways to be tested, so instead of throwing together some really bad hacked tests now, I'm going to immediately begin the upgrade to the latest fetch-mock and xhr-mock and rewrite the tests from scratch.
The main file needs splitting into smaller files, but we're currently using global objects for FetchMock and XHRMock. Once again, this can be solved by upgrading the libraries and creating instances of each and we can pass them around to imported functions.
GraphQL support only works for client libraries that use fetch for now. Once I've upgraded xhr-mock, I'll add GraphQL support for clients using XHR.

Things left to do:

[ ] Merge operations from the same GraphQL url when enabling a scenario
[ ] Stop attaching the same handler multiple times for Fetch.post and Fetch.get when considering GraphQL

Okay, with the exception of documentation, I think I've addressed your points @kenneth-gray
@all - thoughts?

Okay I think I've handled all that shiz now and I've updated the documentation.
Any final thoughts from anyone?

How are we feeling about merging this bad boy?


When generateEnumAsType, integer enums are generated as string

Enum on the source is correctly typed as integer

However types are generated as string therefore it breaks interfaces using types
export type VatRatioChoices = "0" | "1" | "8" | "10" | "18" | "20";

This is a bug. I will fix it.

Released: v6.5.1


Resolved.


RUF001 gives a false-positive with an emoji

I tried to find if there were any existing issues, but I couldn't find anything.
I think I found a small false positive in RUF001. The ℹ contains the smaller unicode letter \u2139 which looks a lot like the letter "i". So when pasting the emoji ℹ into my code I got a Ruff error that my code includes an ambiguous unicode character.
I can circumvent this by pasting the full unicode version of the emoji (\u2139\ufe0f), but this doesn't improve readability. Nor do I think that there is a chance that people conuse the emoji ℹ with the letter "i".
Is this intended behaviour, or is this indeed a small false positive? If it's a bug I would be willing to look into it! :)
Ruff playground example here.

Thanks. Yeah this seems off. We try to match VS code's behavior. I would have to look into it how they solve it, possibly by looking at grapheme clusters rather than characters.

Apologies if I'm doing something wrong here, but I'm having trouble reproducing this issue. When I click on the playground link, what I see is that the playground editor backend highlights the emoji with a warning, but Ruff itself is not emitting a diagnostic. I also tried running previous versions of Ruff (with preview turned on) against this example and can't get it to flag the emoji. Is anyone able to help me reproduce this issue?

Just in case someone else (like me) is having trouble reproducing this: I had to surround the emoji in quotes in the playground example before actually getting a Ruff diagnostic emitted (before that only the underlying editor backend for the playground emits a warning.)
Playground link


Updated gget cellxgene tutorial to reflect workflow updates

Hi all,
There were some requirement clashes between cellxgene-census and other gget dependencies (especially tiledbsoma was causing some problems depending on the environment). Hence, I removed the cellxgene-census package from the standard gget requirements and added it as an optional installation to gget setup (similar to the gget alphafold workflow).
In this PR, I adjusted the gget tutorial as follows:

Add gget.setup("cellxgene") command to install optional dependencies
Changed named version of gget to 0.25.7 (since 0.25.6 was yanked)
Moved Google Colab link into text since the button does not work on the Census website

FYI: The new version of gget cellxgene now also includes the census_version argument.
Best,
Laura

Will be merged in #490 to pass black tests.


can not run install https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-ui-templates/ts

Hello
after run yarn install received error;
Syntax Error: Expected ":" or blank space but "\n" found.

Thanks for reporting this issue, we will check this and get back to you.

@Enghouse-CCSP-PS - We checked the tab-ui-templates sample.
We got this error

We deleted the yarn.lock file and re-ran the yarn install command. It started working again.

It looks like you are getting a different error, could you please let us know if you have all the prerequisites.

Indeed after deleting yarn.lock , yarn install completed successfully, But then I got below error when
started yarn start:

Please also pay attention that it opened on port 3000 and not on http://localhost:3978 as documentation said.

@Enghouse-CCSP-PS - Please continue using the app in Teams, it will work in Teams app. And the sample runs on 3000 port only, we will inform respective team to update the port number to 3000 in the doc.

[script.ScriptExecutionError]: Script ('npm install --no-audit') execution error: npm WARN ERESOLVE overriding peer dependency npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN
I get this error when i try to launch with teams toolkit


All Spotify links give: no matches found

System Operating System (OS)
MacOS
Python Version
3.9 (CPython)
Install Source
pip / PyPi
Install version / commit hash
3.9.5
Expected Behavior vs Actual Behavior
No response
Steps to reproduce
I just installed spotdl and it runs ok... but it doesn't accept any links (playlist, artist, album). I generate the links in Spotify premium, but I have also tried links from a no-login public connection. In all cases I get zsh: no matches found: https://open.spotify.com/playlist/2U5KpqAdc.... What did work was spotdl --user-auth saved (it started searching for the songs but I killed it before it started downloading as I have too many liked songs with no particular scheme or organization...).
Any pointers would be much appreciated.
Traceback
patrick@Patricks-MacBook-Pro ~ % spotdl https://open.spotify.com/playlist/2U5KpqAdcdiCzH0YZPdwqF?si=c601008fca6542b5
zsh: no matches found: https://open.spotify.com/playlist/2U5KpqAdcdiCzH0YZPdwqF?si=c601008fca6542b5

Other details
No response

Duplicate of #1385


Use annotation for old secret name instead of label

How to categorize this PR?

/area usability
/kind bug cleanup
What this PR does / why we need it:
panic: 6 errors occurred:
	* failed to create a temporary secret Secret "tmp-managedresource-shoot-core-kube-proxy-worker-remote-v1.24-e3b0c442" is invalid: metadata.labels: Invalid value: "managedresource-shoot-core-kube-proxy-worker-remote-v1.24-e3b0c442": must be no more than 63 characters
	* failed to create a temporary secret Secret "tmp-managedresource-shoot-core-kube-proxy-worker-f8blv-v1.27-5f0350de" is invalid: metadata.labels: Invalid value: "managedresource-shoot-core-kube-proxy-worker-f8blv-v1.27-5f0350de": must be no more than 63 characters
	* failed to create a temporary secret Secret "tmp-managedresource-shoot-core-kube-proxy-worker-hb2ub-v1.26.5-28fc7969" is invalid: metadata.labels: Invalid value: "managedresource-shoot-core-kube-proxy-worker-hb2ub-v1.26.5-28fc7969": must be no more than 63 characters
	* failed to create a temporary secret Secret "tmp-managedresource-shoot-core-kube-proxy-worker-hb2ub-v1.26-479c5685" is invalid: metadata.labels: Invalid value: "managedresource-shoot-core-kube-proxy-worker-hb2ub-v1.26-479c5685": must be no more than 63 characters
	* failed to create a temporary secret Secret "tmp-managedresource-shoot-core-kube-proxy-worker-fqi0o-v1.24-e3b0c442" is invalid: metadata.labels: Invalid value: "managedresource-shoot-core-kube-proxy-worker-fqi0o-v1.24-e3b0c442": must be no more than 63 characters
...

Which issue(s) this PR fixes:
Follow-up of https://github.com/gardener/gardener/pull/8812
Special notes for your reviewer:
FYI @dimityrmirchev
Release note:

NONE

/lgtm
We never come close to the 253 character limit for the names of our managed resource secrets, don't we? Otherwise, adding tmp- prefix to the names could cause an issue too.

Yes, I don't think we get even close to this limit. Thanks for checking!
/approve


shutdown_all does not check VALIDATE_KG_CERT

When shutting down a notebook after shutdown_all has been called, the following is thrown:
[W 12:31:06.868 NotebookApp] SSL Error on 10 ('x.x.x.x', 8443): [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:765)
This adds the same validate_cert logic to shutdown_all which is used for fetch_kg

Sorry for the long delay. I think I'm not getting notifications for this repo. I'll check my settings.


Resurrect CI

The tests work, only junit fail. I'm not sure how useful that is, having never used it.


Please upgrade version of lens in brew (cask)

Current version: 4.2.5
Latest version: 5.0.0

We do not own that cask. So we cannot update it.


[#noissue] Enabling caching on Travis CI

Codecov Report

Merging #5836 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5836      +/-   ##
==========================================
- Coverage   40.72%   40.72%   -0.01%
==========================================
  Files        2935     2935
  Lines       88161    88161
  Branches    11591    11591
==========================================
- Hits        35904    35900       -4
- Misses      49159    49164       +5
+ Partials     3098     3097       -1

Impacted Files
Coverage Δ

...collector/receiver/grpc/ShutdownEventListener.java
0% <0%> (-25%)
:arrow_down:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
75% <0%> (-10%)
:arrow_down:

...rp/pinpoint/rpc/server/PinpointServerAcceptor.java
84.1% <0%> (-4.64%)
:arrow_down:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
66.66% <0%> (-2.57%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.28% <0%> (+1.05%)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
73.37% <0%> (+1.29%)
:arrow_up:

...cluster/zookeeper/ZookeeperClusterDataManager.java
54.83% <0%> (+1.93%)
:arrow_up:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
59.57% <0%> (+2.12%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24591ad...e854285. Read the comment docs.


Ignore breathe and /doc/sphinx-bootstrap-theme directories in git

These are created when building the library and makes the directory dirty. This is annoying when using cppformat as a submodule since the submodule always will show up in the diff as dirty.
Personally I'd prefer to not modify the source directory at all when configuring and building. It should rather create files in the build directory, but I don't know if that is possible in this case.

Thanks for the PR but sphinx-bootstrap-theme is no longer used and breathe is installed in virtualenv which is already ignored in the current version. Which version do you use?

You're right. I can't reproduce it anymore on 2.0.0 or master. I was pretty sure it was 2.0.0, but I'm starting to doubt that now. I'll close the issue.


Support Transformers >=4.40.0

The Issue
I would like to be able to load GPTQ models with the newest transformers version. This requires optimum, but optimum is not compatible with the newest transformers version.
System Info
Linux, Python 3.11, Optimum 1.19.0

Who can help?
@SunMarc
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)
pip install "transformers>=4.40.0" "optimum>=1.19.0"

Expected behavior
No dependency conflict.

Hi @saattrupdan, transformers version have been pinned in the latest version of optimum. See PR here. I guess the easier solution for now is installing optimum==1.18.0 in order to use gptq with transformers.

Hi @saattrupdan, transformers version have been pinned in the latest version of optimum. See PR here. I guess the easier solution for now is installing optimum==1.18.0 in order to use gptq with transformers.

Thanks @SunMarc! I found that 1.18.0 still has the upper bound requirement, but 1.17.1 works. Thanks for that hotfix 🙂


[Backport 2.x] Fix SegmentReplication flaky integ tests

Backport https://github.com/opensearch-project/OpenSearch/commit/0c7ba945806893ab07c705324de890f21bd623cc from https://github.com/opensearch-project/OpenSearch/pull/8134.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/19122/
CommitID: 5a77782
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Failure was related to PressureServiceStats:
java.lang.AssertionError: Expected non-empty readers
	at __randomizedtesting.SeedInfo.seed([3E8142758780CC4C]:0)
	at org.opensearch.index.translog.RemoteFsTranslog.deleteStaleRemotePrimaryTermsAndMetadataFiles(RemoteFsTranslog.java:418)
	at org.opensearch.index.translog.RemoteFsTranslog.trimUnreferencedReaders(RemoteFsTranslog.java:388)
	at org.opensearch.index.translog.InternalTranslogManager.trimUnreferencedReaders(InternalTranslogManager.java:388)
	at org.opensearch.index.engine.InternalEngine.flush(InternalEngine.java:1973)
	at org.opensearch.index.shard.IndexShard.flush(IndexShard.java:1398)
	at org.opensearch.action.admin.indices.flush.TransportShardFlushAction.lambda$shardOperationOnPrimary$1(TransportShardFlushAction.java:110)
	at org.opensearch.action.ActionListener.completeWith(ActionListener.java:342)
	at org.opensearch.action.admin.indices.flush.TransportShardFlushAction.shardOperationOnPrimary(TransportShardFlushAction.java:109)
	at org.opensearch.action.admin.indices.flush.TransportShardFlushAction.shardOperationOnPrimary(TransportShardFlushAction.java:63)
	at org.opensearch.action.support.replication.TransportReplicationAction$PrimaryShardReference.perform(TransportReplicationAction.java:1260)
	at org.opensearch.action.support.replication.ReplicationOperation.execute(ReplicationOperation.java:158)

created an issue on how to resolve this failure: https://github.com/opensearch-project/OpenSearch/issues/8443.


List the minimum services required to connect to Oracle XE

If the student sets up Oracle the night before and then starts a new VM instance, listener service may not start.

Need to add this troubleshooting step.

I added the lsnrctl status command image to the lab. I also explained how to start the listener manually if the student restarts the VM, as you mentioned.


Fix invalid pubspecs in the fuchsia directory.

These pubspecs are causing issues with the technical_debt__cost.dart test. They need to have valid names and version numbers.

Closing in lieu of https://github.com/flutter/flutter/pull/160609/files


Updated link in free-programming-books-cs.md

What does this PR do?
Updates dead link with a new one.

Forgot to add (PDF) indicator. Made a new pull request.


kubectl-gadget: 0.29.0 -> 0.30.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/inspektor-gadget/inspektor-gadget/releases.
meta.description for kubectl-gadget is: Collection of gadgets for troubleshooting Kubernetes applications using eBPF
meta.homepage for kubectl-gadget is: https://inspektor-gadget.io
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.30.0 with grep in /nix/store/pbvyyq8zh8llvq0hpy3f7py5vlc93qaf-kubectl-gadget-0.30.0
found 0.30.0 in filename of file in /nix/store/pbvyyq8zh8llvq0hpy3f7py5vlc93qaf-kubectl-gadget-0.30.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

kubectl-gadget

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pbvyyq8zh8llvq0hpy3f7py5vlc93qaf-kubectl-gadget-0.30.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kubectl-gadget https://github.com/r-ryantm/nixpkgs/archive/77164ae97c3a72dbc37a1c21d59b11963eb9178f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/77164ae97c3a72dbc37a1c21d59b11963eb9178f#kubectl-gadget

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pbvyyq8zh8llvq0hpy3f7py5vlc93qaf-kubectl-gadget-0.30.0
ls -la /nix/store/pbvyyq8zh8llvq0hpy3f7py5vlc93qaf-kubectl-gadget-0.30.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kubectl-gadget

Maintainer pings
cc @kranurag7 @devusb for testing.


nix: Nix cannot be install without libcrypto.so.1.1 in the environment

Describe the bug
During the installation of Nix on CentOS 7.8.2003 with nix-user-chroot, it complains:
/nix/store/4vz8sh9ngx34ivi0bw5hlycxdhvy5hvz-nix-2.3.7/bin/nix-store: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory
It's true that there is no libcrypto.so.1.1 (other versions of libcrypto.so are available in /usr/lib), but I think Nix should be able to download one itself and use it to ensure reproducibility.
I haven't tested in without nix-user-chroot (for that requires building a vm), and I don't have the root privilige of the machine where the issue occurs.
I have also filed an issue at nix-community/nix-user-chroot, which is issue 18.
To Reproduce
Steps to reproduce the behavior:

Boot into CentOS 7.8.2003 on a x86-64 machine
Make sure that libcrypto.so.1.1 is not in the sysstem
Make sure that user namespaces are available for unpriviliged users, i.e.

$ unshare --user --pid echo YES
YES

Download nix-user-chroot-bin-1.0.3-x86_64-unknown-linux-musl from nix-community/nix-user-chroot release 1.0.3
Rename the above binary to nix-user-chroot and move it to a directory you like, said, mydir
6). Do

cd mydir
chmod +x ./nix-user-chroot
mkdir -m 0755 .nix
./nix-user-chroot $PWD/.nix bash -c "curl -L https://nixos.org/nix/install | bash"

Expected behavior
Nix get installed without error.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

Different versions of libcrypto in the environment

$ find /usr/lib -name "*libcrypto*"
/usr/lib/.libcrypto.so.1.0.2k.hmac
/usr/lib/.libcrypto.so.10.hmac
/usr/lib/libcrypto.so.1.0.2k
/usr/lib/libcrypto.so.10
/usr/lib/pkgconfig/libcrypto.pc
/usr/lib/libcrypto.so.0.9.8e
/usr/lib/libcrypto.so.6
/usr/lib/.libcrypto.so.0.9.8e.hmac
/usr/lib/.libcrypto.so.6.hmac
/usr/lib/libcrypto.so

libcrypto in the half-finished /nix directory.

$ find .nix | grep libcrypto
.nix/store/0x3bf23q5lmdq77x5icr7c0ngvz25ms3-openssl-1.1.1g/lib/libcrypto.so

Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Nix hasn't been installed yet.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: nix
# a list of nixos modules affected by the problem
module:

can you check that

LD_LIBRARY_PATH is empty
ldd on nix only reports libs in the nix store ?

@symphorien

LD_LIBRARY_PATH is empty.
Nix hasn't been (successfully) installed yet. There is no file named ldd in /nix.

This issue seems very much specfic to nix-user-chroot. I'm closing this here to focus the discussion on: https://github.com/nix-community/nix-user-chroot/issues/18


Use Airbnb Style guide

Our code style is pretty much same as https://github.com/airbnb/javascript so we can switch to https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb ESLint config (and maybe add couple of restrictions/overrides). Should simplify support

Absolutely not, but with a couple important modifications, it's good.

I meant it to be a base one. Eslint allows to extend/override any config
values. Since people usually care about deprecating/updating rules and we
won't need to spend time on this kind of maintenance.

Cool. :+1:
Let's work up a diff and see what would really have to change to make it happen.