Attempt to unmount FUSE on process exit

Cleaning up the FUSE mount point on graceful termination can be
beneficial.  For example, when running bb_clientd under Kubernetes with
mountPropagation=Bidirectional, it is advised that "any volume mounts
created by containers in pods must be destroyed (unmounted) by the
containers on termination"
(https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation).
This also improves user ergonomics, since manual unmounting after clean
(e.g. "Ctrl-C" or "docker stop") termination of bb_clientd is no longer
required.

Accompanying bb-remote-execution PR: https://github.com/buildbarn/bb-remote-execution/pull/95
My use case is that I'm trying to run bb-clientd as a sidecar container in k8s, and trying to make it "well-behaved" for mount propagation. I guess this PR is not strictly sufficient, since the mount would not be cleaned up if bb-clientd crashes, but thought it might still be a worthwhile UX improvement...? Let me know what you think.

Hi @scele!
Even though I sympathise to the change, I have also observed that a change like this is not sufficient. It is indeed the case that kubelet will lock up if you leave a mount behind in an emptyDir that's shared between containers. This logic will only take care of the graceful case, but as you mentioned, in case of crashes/involuntary terminations, it still goes wrong.  In my opinion we should file a bug against Kubernetes for that.
That said, I can share with you that if you stick to the following rules, Kubernetes won't lock up:

Use a hostPath instead of an emptyDir to hold the FUSE mount.
Place the FUSE mount inside of a subdirectory of the hostPath volume; don't place it at the root.
Don't use subPath, not on the bb_clientd side, nor the Bazel side.

In addition to that, apply the following rule to make sure you don't end up with stale FUSE mount entries in the host's fstab (i.e., outside Kubernetes):

Make the mount path of the hostPath identical to the original path on the host file system.

I'd rather not make a change like this, as there is no way we can get it perfect on the bb_clientd side. In my opinion it should be up to the execution environment/launch service/... to clean up any straggling resources, as it's the only piece of software that can get it right.

Thanks @EdSchouten for these pointers and quick response!
Hmm.. trying to understand how this would work.

I'm trying to have a (Jenkins) Pod that has bazel in one container and bb-clientd in another container. By using a hostPath, how would it work if I have multiple Pods on one Node? Would I need to include the Pod name in the FUSE mount path, something likefuse: {
   mountPath: "/run/bb_clientd_mounts/$POD_NAME/fusemount"
}

with a hostPath mount of /run/bb_clientd_mounts:/run/bb_clientd_mounts mounted to each Pod? Or do you only have experience from one-pod-per-node configurations?
Something still needs to call unmount even when using hostPath volume, right? Taking it one layer up from bb-clientd, my next attempt would be to adjust the bb-clientd container CMD to be something like trap EXIT { umount /run/bb_clientd_mounts/$POD_NAME/fusemount } && bb-clientd /configs/bb_clientd.jsonnet so that the unmount would happen even if bb-clientd crashes. That still would not work if somebody forcibly kills the whole container, but I don't see how to do better than that...?
I still need to use mountPropagation=Bidirectional together with hostPath mounts, right?

Don't worry if you don't have answers to these, I can experiment myself. Just in case you have experience about some working configuration.

Re. questions 1+2:
With regards to multiple pods on one node, I have no experience with that yet. Using the pod name could work, but that has the downside that your bb_clientd_mounts directory fills up over time. It would be nice if Kubernetes had some kind of node-local number pool/allocation feature, so that the number of directories you'd need to create remains bounded. That also means that you don't need to care too much about doing unmounts.
Wild idea: Kubernetes already has this feature:
https://kubernetes.io/docs/concepts/policy/resource-quotas/#resource-quota-for-extended-resources
Would there be some way for kubelet to report with n'th of those got allocated?
With regards to question 3: Yes, you still need to use mount propagation.
That said, I would still suggest talking to the Kubernetes developers to ask them why Kubelet is incapable of cleaning up stale mounts. That would prevent the need for hostPath entirely.

Thank you Ed for these suggestions! Closing this PR.


robo: 4.0.4 -> 4.0.6

Description of changes
It also fixes the build.
Changes:
https://github.com/consolidation/robo/compare/4.0.4...4.0.6

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

robo

Add a :+1: reaction to pull requests you find important.

@ofborg build phpPackages.robo

@LeSuisse Could you please adjust the commit message (I updated the PR title myself) ?

Done, thanks!

@ofborg build robo


CryptoCoinInfo crash fix

CryptoCoinInfo was crashing when passing ETHEREUM coin value. Now CryptoCoinInfo can support ETHEREUM value and it is not crashing.
`./gradlew test
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.3/userguide/command_line_interface.html#sec:command_line_warnings
BUILD SUCCESSFUL in 1s
3 actionable tasks: 1 executed, 2 up-to-date
`

@craigraw let me know if this would help.
If I had time I would port this over to Kotlin, but we are a bit tight on time.

Thanks, lgtm.


Node contract cancel events gets emitted twice when a contract is canceled

In the current code base this doesn't seem to occur


Add testing for fileOffset being set correctly.

We have tests for the expected kernel output, from e.g. transformations, but this does not include fileOffsets.
This means changes to the fileOffsets (like 220543) are untested and potential regressions are uncaught.
We should consider adding testing for fileOffsets as well - for instance as part of the regular expect files, or as a new set of expects.

Printing expect files with token offsets in them doesn't work well, e.g. from this call out/ReleaseX64/dart -DshowOffsets=true pkg/kernel/bin/dump.dart out/ReleaseX64/vm_platform_strong.dill:
[6471]      if([-1] [-1]![6487] [6487] [6476] [6476] [-1] [-1] this.{asy::_AsyncStarStreamController::controller}{asy::StreamController<asy::_AsyncStarStreamController::T%>}.{asy::StreamController::hasListener}{core::bool})

I don't think anyone is any wiser here.
Also just printing them doesn't show how (for instance) the VM will react to it.
In my opinion something like this has to be tested through coverage tests and/or debugging tests as mention in https://dart-review.googlesource.com/c/sdk/+/220543.


Load Puzzle

``
Load Puzzle from file

[x] CLI can recognize a load command

[x] Load command takes a filename argument

[x] Find the given filename and load it into play

[x] If filename is not found, tell user it is not found

[x] CLI should also recognize if a game is already loaded or playing

[x] Game should ask user if they want to save their current game, and after input filename should be loaded.

Primary: @Joperezc

Secondary: @nrhoopes

Size: LARGE

Actual Size:

Actual Time:
``

Loading a json save is currently working

Finished Loading


Lapin Sandbox

I've started to work a lot with elixir and I've noticed the best frameworks are the ones that provide some sort of sandbox for a developer to substitute in when they write test cases. Currently, to test against lapin, I need to have an actual rabbitmq host running. It would be nice to have an in-memory sandbox that I could substitute in to test against.
The scope would look something like this:

doesn't require an amqp server
allows the control of messages through test harnesses (I can determine when I wish to send a message)
allows messages to be prepopulated on the queue

I've just added Travis CI integration to the master branch. Travis automatically runs tests and provides RabbitMQ in the test sandbox, so tests are automatically executed against a real broker with no setup overhead on our part.
AMQP allows you to declare configuration as part of the protocol, setting up exchanges and queues. Lapin does this automatically by default. I think this is more practical than setting up a custom test environment for now.

Ah I think the sandbox is more for people integrating with your library rather than testing internally.

Ok, so I guess some kind of mock simulating the broker interaction. I guess this is interesting. Do you have a pointer to an existing library which does this for tests for reference?

I wrote one on this open source repo here: https://github.com/lswith/analytics-elixir
The sandbox can be swapped out for the actual Genserver. This allows our tests to make sure that the lib is being called without actually making the http requests.

See also https://github.com/jcabotc/hare/blob/master/lib/hare/adapter/sandbox.ex for a concrete rabbitmq example.

Thanks guys, I'll look into the examples. As my time is currently limited I'm going to be prioritizing  other features though.
Also, the current travis setup already allows for easy instantiation of a real rabbitmq broker in the sandbox and at least on mac running rabbit locally is a no brainer.


[sc-26860]: Update QML cache strategy to allow for refreshing of cache

Title: Add ability to refresh cache for QML CI/CD
Summary:
This pull request aims to add a new feature to the QML CI/CD pipeline by allowing the refreshing of cache. Previously, you either had to use existing cache, or completely ignore cache. There was no way to update/refresh the cache without using workarounds.
After this pull request is merged, users will be able to use the existing ignore-qml-cache label which now build fresh each time, but also refresh the cache with the new results each time. Once the label is removed, the most recent cache will be used for subsequent build.
Please note that this is vastly different from prior behavior. Before this PR, if the ignore-qml-cache was attached to a PR, it would ignore the cache but never update it. So removing the label was never an option to use the cache again, which slowed down a lot of PRs.
This pull request brings the following key changes:

The Python venv will no longer be cached
The cache key for items has been updated

Pros:

Builds will always fetch the latest libraries
Initial build of PRs will fetch the latest libraries at the time the PR is opened.
No further changes are required in PRs to support a cache refresh. The existing qml-ignore-cache label can be used.

Cons:

Build times will increase by 3-7 minutes

Relevant references:

sc-26860

Possible Drawbacks:
Please see Cons list above.
Since this PR updates most cache keys, once it is merged, all existing caches will be invalidated. This should not impact anything but expect a longer build time on the very first build .. similar situation to when this workflow was first launched.
Related GitHub Issues:
None.

Thanks for the replies @rashidnhm, good to merge for me!


bug: card with button directive in infinite scroll page lags scroll up on ios

Bug Report
Ionic version:

[x] 5.x
Current behavior:

scrolling a page with multiple loaded cards with button directives inside a infinite scroll page has a janky scroll up animation on iOS . it feels like it jumps immediatly to the first element again.
Expected behavior:

scrolling should be smooth.
Steps to reproduce:

scroll to the top of the page. then continue to scroll up (as if you would try to reload the page).
Related code:
https://stackblitz.com/edit/ionic-v4-angular-tabs-1247a2

Other information:

only on iOS devices with a bundled/served app (not in browser environment)
Ionic info:

Ionic:

   Ionic CLI                     : 5.4.16
   Ionic Framework               : @ionic/angular 5.0.4
   @angular-devkit/build-angular : 0.900.5
   @angular-devkit/schematics    : 9.0.5
   @angular/cli                  : 9.0.5
   @ionic/angular-toolkit        : 2.2.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : ios 5.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.3, (and 20 other plugins)

Utility:

   cordova-res                          : not installed
   native-run (update available: 0.3.0) : 0.2.9

System:

   ios-deploy : 1.9.4
   ios-sim    : 8.0.2
   NodeJS     : v10.16.3 (/usr/local/bin/node)
   npm        : 6.14.2
   OS         : macOS Catalina
   Xcode      : Xcode 11.3.1 Build version 11C504

Thanks for the issue. Can you provide this reproduction as a standalone GitHub repo? I need to run this as a standalone app, but StackBlitz doesn't always export the project properly.

reproduction repo: https://github.com/capc0/ion-card-btn-infinite-scroll-lag
run with serve-ios-device (do not forget to set dev team in Xcode on first run)
I figured out that the scrolling issues disappears if I remove one or both of the following

button directive of the card
<ion-card-subtitle> in the card header

Thanks for the follow up. Yeah, I've seen this behavior before. I think it is a bug in WebKit when using transitions (in this case the card button) and rubber band scrolling.
I will see if there is an open WebKit bug/a workaround.

I opened a new issue here: https://bugs.webkit.org/show_bug.cgi?id=209968.
It looks like this particular issue is related, but the workaround is slightly different. As a workaround, you will need to disable the text-transform on the ion-card-subtitle:
ion-card-subtitle {
  text-transform: none;
}

You can either type the text in all caps yourself or call .toUpperCase() on the string if you are generating these cards dynamically.
For updates regarding the WebKit issue, please refer to the WebKit link I included above. Thanks!

I will keep track at the webkit issue.
Unfortunatly the workaround does not work in my particular environment. I even encounter the bug without any <ion-card-subtitle>  or even the entire <ion-card-header>

In that case you will likely need to also disable the scale effect on the card:
ion-card.ion-activated {
  transform: none;
}

You can have it change its background color instead for an activated effect.


Fail2Ban

root@ip-172-31-35-69:/etc/nginx/common# fail2ban-client reload
ERROR  Found no accessible config files for 'filter.d/nginx-forbidden' under /etc/fail2ban
ERROR  No section: 'Definition'
ERROR  No section: 'Definition'
ERROR  Unable to read the filter
ERROR  Errors in jail 'nginx-forbidden'. Skipping...

Hello @wiroy,
To fix this issue, you just need to download the missing filter :
wget -O /etc/fail2ban/filter.d/nginx-forbidden.conf https://virtubox.github.io/ubuntu-nginx-web-server/files/etc/fail2ban/filter.d/nginx-forbidden.conf

And then to run fail2ban-client reload again.
I will add this missing line asap


How to embed view flow

I want to add a video stream chart to the dashboard for real-time monitoring by the webcam. What should I do?

Closing this since it's not a bug, but you might want to try to start up a conversation in an Ideas thread on Github Discussions, or start up a conversation in #customizing-superset on Superset Slack.
That said, I'm not sure what you mean by monitoring a webcam.... like... bandwidth data? Audio signal?
In any case, Superset isn't set up for realtime data all that well, though it can refresh periodically. The ECharts-based line chart supports a stream chart mode, so you would just need to have it connect to that data (whatever the source is) and refresh frequently.


Brazillian portuguese sheet link

The sheet was missing a few things, including the column break down that i should have caught previously.

Wanted to cc @shana and @felipedau since you've both worked in this realm.
I've kept the pt section, so we can keep that translation (I believe this was a concern as mentioned here: https://github.com/github/training-kit/pull/328#issuecomment-126795227).
I've also renamed the directory to be more appropriate and named pt_BR
Thoughts?

also cc @loranallensmith since this effects some upstream changes we're looking at. Once this gets merged in we can take care of other works we are doing to make this reflected on the page itself.

@brntbeer I'm running everything locally and it looks good to me as far as structure goes.  :+1:

Wanted to cc @shana and @felipedau since you've both worked in this realm.

Thanks!

Thoughts?

I believe everything is good with the Brazilian cheat sheet.
I would say that the pt-PT link could be hidden until the cheat sheet is done, because the current PDF is just another version of the pt-BR. If there is already a pt-PT branch somewhere then just ignore what I said :P

@brntbeer Thanks for doing this, this is awesome!

I would say that the pt-PT link could be hidden until the cheat sheet is done, because the current PDF is just another version of the pt-BR. If there is already a pt-PT branch somewhere then just ignore what I said :P

Hiding the link until it's done is a good idea, it's better to do that than have the two be the same (that will likely make people complain). I started working on it but haven't finished because [insert need more hours of the day complaint here]. I'll invest some more hours in it and do a PR based on this one :smile:
In a completely unrelated note, have you thought about having a booklet git cheat sheet like the one we have for the GitHub flow? The small format of the GitHub flow booklet makes it very easy to carry around, it's very popular in the booths I've manned.

welcome

I would say that the pt-PT link could be hidden until the cheat sheet is done, because the current PDF is just another version of the pt-BR. If there is already a pt-PT branch somewhere then just ignore what I said :P

My apologies, I actually didn't notice that the .pdf version of the cheat sheet was the version of pt_BR before @felipedau updated it a few months ago (https://github.com/github/training-kit/pull/328) and because of a comment in another repo prompting me to make this PR. @felipedau @shana I'll revert the move of the pdf to a pt/ folder and fix some things around. @shana a PR on eventually adding a pt_PT translation would be :zap: :zap: :zap: :gem: :gem: :gem:
I'm guessing it's best to just render the .html for the Brazilian translation? Since that's the most updated version of this, that seems to be best.

@brntbeer looks like that pt_PT link removal is :+1: for me locally here.  And the pt_BR link goes to the .html cheatsheet in pt_BR.  :sparkles:

I'm guessing it's best to just render the .html for the Brazilian translation? Since that's the most updated version of this, that seems to be best.

I really like the html layout, I am just wondering if people would expect something to download (because the website says available for download...) such as a pdf. Maybe all of the cheat sheets could be in html and then have a download button somewhere to save a pdf in case they really want to have it?

@brntbeer looks like that pt_PT link removal is :+1: for me locally here. And the pt_BR link goes to the .html cheatsheet in pt_BR. :sparkles:

It also looks good here :)

@felipedau understandable, unfortunately we don't have someone to continuously turn these .htmls into pdfs to keep them updated (If I knew how to do that, I'd do it. May look into alternatives like .pdf style sheets).
Thanks all for the review!

@felipedau understandable, unfortunately we don't have someone to continuously turn these .htmls into pdfs to keep them updated (If I knew how to do that, I'd do it. May look into alternatives like .pdf style sheets).

Oh, that's right. I remember you said that.

Thanks all for the review!

Thank you.


How do I get the source code from the TVM model?

I've got the REEF's sample code and reef-artifacts/evaluation all working, and I'd like to use my own model.
But when I ran script/tvm_generate_model.py, the json and param files output what looks correct, but the cu file is 0 bytes.
I assume that I need to customize TVM, but do you have any plans to publish the details of the customization to TVM and the procedure to obtain the cu file?

Hi @battleonthebridge , I just upload a patch for generating REEF models using TVM, see  https://github.com/francis0407/tvm/tree/reef.
To generate a model like models in resource, you can:

use a script like script/tvm_generate_model.py, which will generate 4 files, including the device code (.cu), the tvm schedule, the host call trace, and the parameters.
then, use the script script/generate_final_schedule.py to merge the tvm schedule and host call trace files into the final reef schedule file.

I installed CUDA and built the TVM you uploaded and was able to generate the cu file successfully.
It looks like I can now convert my own model.
Thank you very much, @francis0407. I sincerely appreciate it.

I installed CUDA and built the TVM you uploaded and was able to generate the cu file successfully. It looks like I can now convert my own model.
Thank you very much, @francis0407. I sincerely appreciate it.

Hello. I've now got a final_schedule.json file via script/tvm_generate_model.py and script/generate_final_schedule.py, how do I get the final .cu file next?Also, I am using nvidia-gpu.
Looking forward to your reply! 🌹


Add Canonical Logo

I am the MLOps Product Manager at Canonical, the publisher behind Ubuntu. We have been using KFServing and these days KServe for model inference. With the release of 1.7 (Beta goes live on the 8th of March), it will be part of the default bundle. Until now, it could have been related manually.
We are packaging KServe as a charm, which is going to be published on https://charmhub.io/
Daniela Plasencia is part of our engineering team who mainly worked on the technical side of it. Repo for reference: https://github.com/canonical/kserve-operators
-Added Charmed Kubeflow from Canonical, the publisher behind Ubuntu, as an adaptor

Add Canonical logo to the website. Logo is available here

@andreeamun thanks for adding the logo ! I think you need a rebase from the main branch.


Adding Go to SDK landing page

@neilpeterson : Thanks for your contribution! The author, @, has been notified to review your proposed change.


show data when hovering over the slot

I want to contribute to it. Please assign me this.

implemented


[JS] [KeyVault] Address PR feedback

Back when we did PR #3020, @schaabs mentioned several non-blocking feedback points that haven't been addressed. We'll track progress here:

~Regarding Promise<Secret> as the return value of updateSecretAttributes, when it returns this.getSecretFromSecretBundle(response): https://github.com/Azure/azure-sdk-for-js/pull/3020/files/6081d2fdf057d5a98ecaa5ed5fbffdee72953d1b#r285722703~ The return value here is correct, it can't be Promise since getSecretFromSecretBundle returns a Secret.
Regarding backupSecret returning  Promise<Uint8Array | undefined>. Why is this | undefined? https://github.com/Azure/azure-sdk-for-js/pull/3020/files/6081d2fdf057d5a98ecaa5ed5fbffdee72953d1b#r285723246
does it still make sense to have distinct options types for each of the operations?, from: https://github.com/Azure/azure-sdk-for-js/pull/3020#discussion_r285724709
Should the id property be on the ParsedKeyVaultEntityIdentifier?, from: https://github.com/Azure/azure-sdk-for-js/pull/3020#discussion_r285725517

I'm addressing the only point I know how to address, the rest is up to you, @jonathandturner :sun_with_face:

Are the last two point still relevant? @schaabs

This issue is stale. I'll close it.


the data generated by outpainting has obvious discontinuous traces at the mask boundary.

Hello author, your work is really great. When studying your work, I found that using the parameters and test data provided by the author, the data generated by extrapolation has obvious discontinuous traces at the mask boundary. Is there any way to eliminate it.
I really hope to receive your letter.

First of all, I have to say that i;m not related to the author in any way and this is an unofficial implementation.
Secondly, yeah it is because the way I blend the original masked image with the output of the model is very naive so sometimes it will show a small white boundary

Thank you very much for receiving your answer！ @thuanz123.

Thank you so much for providing this implementation @thuanz123!!!. The fundamental reason for the small white boundary might be the irregular value of the mask, the same as I've encountered in an inpainting work. I checked the value of the mask image in '/data' and found the mask values have other values apart from 0 and 255 at the boundary of the masked region, which may result in blurry edges or the above white boundary.

Thks @Lanxin1011!!! After using correct mask, the issue seems gone so I think I can safely close this issue now. Simply correcting the mask and the masked image does the trick here


SCSB boundwiths fetched from Alma do not have holdings in the correct format

Part of https://github.com/pulibrary/bibdata/issues/1255 and follow-up to https://github.com/pulibrary/bibdata/pull/1303
When a scsb boundwith record is pulled from Alma via the API, its holdings data is returned in an 'AVA' field. For SCSB this data needs to be translated into the expected MARC fields (e.g. 852, 876).

close in favor of https://github.com/pulibrary/bibdata/issues/1320


Require linebreaks in curly braces in JSX attributes and expressions to be consistent (react/jsx-curly-newline)

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-newline.md
We want either both curly braces have a line break directly inside them, or no line breaks are present.
When consistent or { multiline: "consistent", singleline: "consistent" } is set, the following patterns are considered warnings:

  { foo
  }

  {
    foo }

  { foo &&
    foo.bar
  }

The following patterns are not warnings:

  { foo }

  {
    foo
  }

Shipping in standard 14.


NPE in RTR with multiple threads for task assignment

Multiple threads in task assignment causes NPE.
Seems to have been introduced by https://github.com/druid-io/druid/pull/2521
2016-04-15T09:56:11,335 ERROR [rtr-pending-tasks-runner-2] io.druid.indexing.overlord.RemoteTaskRunner - Exception while trying to assign task: {class=io.druid.indexing.overlord.RemoteTask
Runner, exceptionType=class java.lang.NullPointerException, exceptionMessage=task, taskId=<TASKID>}
java.lang.NullPointerException: task
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:229) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner.tryAssignTask(RemoteTaskRunner.java:638) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner.access$1400(RemoteTaskRunner.java:116) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner$3.call(RemoteTaskRunner.java:568) [druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner$3.call(RemoteTaskRunner.java:556) [druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_60]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_60]
2016-04-15T09:56:11,336 ERROR [rtr-pending-tasks-runner-2] io.druid.indexing.overlord.RemoteTaskRunner - Exception in running pending tasks: {class=io.druid.indexing.overlord.RemoteTaskRun
ner, exceptionType=class java.lang.NullPointerException, exceptionMessage=taskRunnerWorkItem}
java.lang.NullPointerException: taskRunnerWorkItem
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:229) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner.taskComplete(RemoteTaskRunner.java:1048) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner.access$1500(RemoteTaskRunner.java:116) ~[druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner$3.call(RemoteTaskRunner.java:577) [druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at io.druid.indexing.overlord.RemoteTaskRunner$3.call(RemoteTaskRunner.java:556) [druid-selfcontained-7aaf2b3.jar:7aaf2b3]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_60]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_60]

@nishantmonu51 i think i see a race between task assignment and shutdown. can you confirm if this happened in a scenario where a call was made to shutdown one or more tasks? if that is the case then having a null check in runPendingTasks() would solve the issue. also, this shouldn't have had any bad impact and overlord should have been able to make progress... did it continue to make progress after the error?
will send a PR to if what i said above is true.

No, I was not using shutdown. I just tried an overlord update and hit it.
I think the race I hit was as follows -

thread 1 and 2 both make a copy of pendingTasks
thread 1 goes ahead and assigns the task, does putIfAbsent in tryAssignTasks, assigns the task and then finally remove the task from tryAssignTasks
now thread 2 tries to assign the same task calls a tryAssignTasks.putIfAbsent which succeeds and it then tries to read the task payload which was earlier removed by thread 1.

For the impact, i can confirm that the overlord was able to make progress and the task assignment also worked after this. I did not see any tasks failing after this. I noticed this when i saw a bunch of alert mails for this.

hmmm, good to know that it does not have a bad impact but only error logs. null check is still the correct solution. will fix it soon.


SLIM-460 reimplement device authorizations

DeviceFunctionMapping to map DeviceFunctionGroup values to lists of DeviceFunction values is put into a database table instead of using a hard coded map of the enum values in the SecurityService.
This should provide some more flexibility to alter this mapping without changing the application code.
Authorization checking based on ownership is added to the smart meter device web service processing.
The DeviceRequestMessageService in OSGP core no longer has an exception for the smart meter domain to exclude authorization checking based on organization, device and device function.

All is well.

All is well.


Make LgtmServlet use the custom workflow

This pull request introduces 1 alert when merging 0609426c00edcc1f5132a481c3eadb8b08b5f925 into e2ea60c0087e0655705e1a933012198330e56f89 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 62392804abba4ae6ef0c1a1f76b4c36cec0eca45 into e2ea60c0087e0655705e1a933012198330e56f89 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Comment posted by LGTM.com

This pull request introduces 1 alert when merging c7db8818a7aefdb16ee485ab68f49477f5126eba into e2ea60c0087e0655705e1a933012198330e56f89 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 27b211ccab1f9343a2bd7b994970ce47582efe8d into e2ea60c0087e0655705e1a933012198330e56f89 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Comment posted by LGTM.com

Looks good to me. @nickfyson Please merge if you are happy with the changes.

This pull request introduces 1 alert when merging 1812695f5f020823449bfdf8a04fd422933790a6 into e2ea60c0087e0655705e1a933012198330e56f89 - view on LGTM.com
new alerts:

1 for Dereferenced variable may be null

Comment posted by LGTM.com


EoCompileAction.java:48-49: Create tests for the action...

The puzzle 20-388ae4cb from #20 has to be resolved:
https://github.com/objectionary/eo-intellij-plugin/blob/3a34fe81090ee76ca15dd73b906e8f06c1420060/src/main/java/org/eolang/jetbrains/EoCompileAction.java#L48-L49
The puzzle was created by @mximp on 18-Aug-22.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@mximp take this one


Add input file flag to set frequency that distf is written out for (gyro)kinetic species

Currently distribution functions are written out at every frame. This takes up a large amount of disk space. It would be useful to set a frequency relative to the num_frames, like distf_freq = 0.1. If you have a flag to set the total number of distf frames output, as we did in g2, you have to remember to update it if you extend t_end and output frames, whereas with a frequency it will happen automatically.

Addressed in PR #484


Copying "unknown" reparse points

Hi, this might be an odd request, but it seems that a lot of windows internal knowledge is in these libraries. Since at least 2018 windows has a special kind of reparse point ( 0x8000001b ) that acts similar to a symlink but contains some extra data ( that seemingly gets passed on to checking for executable permissions etc. when executing files through it... things are rather bad documented here.. )
Would it be possible that the junction tool ( or maybe it fits better into any other?? ) can copy reparse points verbatim? Or even create the attached data from a file or similar?
It happens sometimes that one of these special reparse points gets deleted, and sometimes the only solution is to reinstall windows, but all that was really needed is to (re)create that reparse point...

Hi Jeffrey,
This is absolutely not an odd request, but this is definitely a more difficult one than it looks.
The reparse point type 0x8000001B is for UWP "App Exec Links".
All I know about them comes from this blog post, and from my own experiments thereafter. For that I created a dedicated script called AppExecLink.bat (not (yet?) published in SysToolsLib), dumping their contents. I published a summary of what I found in this message.
But I still don't understand enough about UWP applications startup to generate modified App Exec Links for use in a copy.
Actually what's your use case for doing such a copy?
As far as I can tell, these links are only used in the "C:\Program Files\WindowsApps" directory for pointing at installed UWP applications. Copying them to another place, or worse still to another PC, does not seem very useful.
Do you know of other cases where they're used?

Does it contain more than the data fsutil dumps?
From what I understand the actual .exe being started in the WindowsApps Folder contains a special condition for being executed (look in the explorer right click properties dialogue, there will be a new column checking for some string, which matches the first string contained in the data of that reparse point ).
I think the case of wsl this is kinda being used as setuid mechanism, where it is checked that was run through the "symlink" contained in the users appdata folder, and then the wsl can with elevated credentials startup its vm...
Anyways, my usecase might be a bit special, but the whole ordeal is. Due to some misunderstandings, the local users AppData folder was being deleted, along with all the necessary app exec links for wsl. Now all uninstalling and reinstalling of wsl did not work, and as such starting it as a user won't work ( as the .exe files in the WindowsApps folder cannot be started as a normal user, unless started through that special link).
All attempts to re-create them from scratch for me failed so far, so I was thinking about, that if they do only consist of all the information that fsutil can also display, that feeding that data block to some tool and then re-creating the link might do the deal.
M$ support answer is simple as always: just reinstall windoze.
Another usecase to be able to create them with arbitrary data might be to play around and see how they work. Decompiling windows code to figure out whats going on is really tedious and leads to too much dead ends ;)

Does it contain more than the data fsutil dumps?

No, as far as I can tell, everything is in fsutil output.
I could easily create a new dedicated tool for managing AppExecLinks. (Displaying the content of existing ones, or creating new ones.)
The problem with recreating new AppExecLinks from scratch is that it'd be difficult for the user of that tool to figure-out what strings to put in these new links. For example for Microsoft Edge, the strings are:
C:\JFL\Temp>AppExecLink.bat "C:\Users\Larvoire\AppData\Local\Microsoft\WindowsApps\MicrosoftEdge.exe"
Microsoft.MicrosoftEdge_8wekyb3d8bbwe
Microsoft.MicrosoftEdge_8wekyb3d8bbwe!MicrosoftEdge
C:\WINDOWS\system32\SystemUWPLauncher.exe
1
C:\JFL\Temp>

The third string is the target executable. But as shown above, it's not always directly related to the target application.
The fourth string seems to be a number encoded as a string. I've seen cases where it's "0"; Others where it's "1". No idea what it means, nor how it's used.
Note that the AppExecLink.bat script I used above is just a simple wrapper around fsutil.exe. It only converts the hexadecimal dump to readable strings. And it only works with ASCII strings. The final tool should support any Unicode character.

My hope here would be that while it would initially be difficult, having a tool to play with will one day lead to more knowledge about what works and what doesn't....


search ignore white spaces

I think it would be really convenient to have a search toggle that allows us to search while ignoring any whitespace.
For example, if the code contains the word Github but you search for Github    , you won't get any results because of the space.
This is a feature that I liked in Dreamweaver (enabled by default for all searches) and that is missing from VS Code.

VS Code has most of the options seen above, such as Match Case, Match Whole Word and Use Regular Expressions, but it doesn't have Ignore White Spaces.

It seems like the easiest thing to do is to not add whitespace to your query. I don't really see the benefit of this.

It seems like the easiest thing to do is to not add whitespace to your query. I don't really see the benefit of this.

The fact that I have not given the best of examples - in favor of simplicity - doesn't mean that there aren't benefits.
So here's another example. There are many code tutorials, snippets and fixes on the Web which require you to search and add or replace code.
Try searching for this:
if(...)
{

var hello;
}

When in reality it is like this:
if (...) {
    var hello;
}

Yeah, no luck.
There have been many occasions where I couldn't locate the suggested code (and eventually I had to be much more specific in my queries) because of whitespace differences! You name it - tabs, trailing spaces, new lines etc.
And in any case, does it matter whether I can express the benefit of it? Adobe has it in their product enabled by default. There have to be benefits, one would think, right? Plus, it is the only option missing from VS Code's search. It'd be a good thing to have it.

This would require us to either rewrite the query into a regex that can match different things or to build an index of the codebase that we can fuzzy search. We investigated the second and rejected it as being too complicated for a "simple/lightweight" code editor.

Well, maybe someone can come up with a good implementation if we don't dismiss the idea. After all, these days VS Code is an all-in-one editor rather than a "simple" editor like Dreamweaver - yet the latter has had this neat feature for a long time.


Documentation for Public Methods

Rust documentation can be improved overally, but mainly in two places:

Instantiating and setting up an IPFS node
All of the methods in the Ipfs struct, i.e. the main functions that a Rust programmer will use to interact with an IPFS node

To find the remaining places, uncomment src/lib.rs #![warn(missing_docs)].
When developing docs, the docs are catered towards https://docs.rs/ipfs distribution. This basically means generating the docs with the latest nightly (or what docs.rs is using), then running cargo +nightly doc --workspace --no-deps --open. We are still a bit undecided of the #![allow(private_intra_doc_links)] but possibly leaning towards allowing it when it becomes possible with stable rust. So don't worry about cargo +nightly doc warning about private_intra_doc_links.

After #392 we are now about 60% documented according to docs.rs.
If you are interested in helping out, probably easiest way to find anything to work on is to either:

clone, commend out src/lib.rs:18, run cargo check

this will produce around 180 errors but works well with rust-analyzer and an IDE

browse docs.rs/ipfs

Updated the issue description with the nightly/docs.rs hints, lint recommendations.


Implementation Of Queue Using Linked List

Related Issue

Implementation Of Queue Using Linked List (Closes #1117  )

Proposed Changes

Implementation of Queue using Linked List performing different operations such as insertion, deletion and display of elements in a queue.
Changes in the readme

Additional Info

Organize the content of the readme

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 🎀 I have updated the README accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

Implementation of Queue using Linked List performing different operations such as insertion, deletion and display of elements in a queue.
I have created 3 functions:

Insert() -To insert elements
Delete() -To delete elements
Display() -To display elements

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Test Case 1
Test Case 2

 |

Please review this PR.

@Mrjoy832 @Lakhankumawat  please review my pr.
This is my second pr.
My first sucessfully merged pr is #1125


md5&sha256 code is incorrect

Reminder

[X] I have searched the Github Discussion and issues and have not found anything similar to this.

Environment
- OS:Ubuntu 20.04
- Python:3.10
- PyTorch:2.0.1+cu118
- CUDA:11.8

Current Behavior
the md5&sha256 code of transfoemers package is incorrect in "conda-lock.yml"

Expected Behavior
md5: 8e1add862a24a58cfdfd710805eb884b
sha256: 1ff6b32750a2c6fc1823ea3f440939de05e05c44114f5709d2120007b00a4ec5
Steps to Reproduce
I find this error when build docker image from Dockerfile
Anything Else?
No response

build docker image from Dockerfile

would you please provide your sample code to reproduce this error? Thanks!

docker build .

Thank you for noticing us! I just checked you are correct.


Hillas calculation failed for some telescopes in camera-frame

Describe the bug
I'm using the latest ctapipe version (v0.16.0) with a subsample of Prod5b. When running the process tool, the Hillas calculation failed (either zeros or nan) for some telescopes in camera-frame.
To Reproduce
Steps to reproduce the behavior:

$ ctapipe-process -i /data3/users/nieto/Prod5b_sample/Prod5b_LaPalma_AdvancedBaseline_NSB1x_gamma_North_20deg_DL0_1e6evt/gamma_20deg_0deg_run126___cta-prod5b-lapalma_desert-2158m-LaPalma-dark.simtel.zst --progress --write-images --write-parameters --write-showers --camera-frame

Expected behavior
Hillas calculation should be also working when camera-frame is selected.
Supporting information
Screenshot with corrupted tables for tel 3 (LST) and tel 6 (MST with NectarCam):

Provenance log:
ctapipe-process.provenance.log
Additional context
It would be also great to store the information about the camera-frame in the meta data and just keep one naming convention for the parameter tables, i.e. removing the prefix "camera_frame_"

I suspect the problem is that for these telescopes the first event is not reconstructible, we then provide the wrong default container and that messes up all following events.
Let me check

Yes, this is the case. We return the global DEFAULT_IMAGE_PARAMETERS, which always contains the telescope_frame variant.
I'd solve this by just going ahead and removing the --camera-frame option to be honest and not add further complication for something we do not intend to support anymore.

On the other hand, the fix wasn't too hard...


areCommandsDifferent still true for all commands

Cause: localOptions is always empty. So commands appear different if the application command has at least one option


Update toc.yml (Typo "Azure functions"→"Azure Functions")

https://docs.microsoft.com/en-us/dotnet/architecture/serverless/durable-azure-functions
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Hi @hyoshioka0128 , thank you for submitting this PR. Looks good.


feat: Add Makefile

I opted for Makefile here as it is ubiquitous and I hope the limitations of the language can keep us from creating overly complex build systems.
@lut99: Let me know what you think.
This is draft material, please review thoroughly; however due to the broken nature of our current make file, I would lean to merging as soon as this works for you too.
I rather have something that kinda works and me sending another PR, than having to tell people to run an old version.
fixes: #172, fixes: #149

Looks good to me! Been I while since I did proper Makefiles but I think it makes sense.
So I'm all for pushing this ASAP. It looks like you're not replacing make.py but just adding it in conjunction, right? If so, then let's merge this so that we can tell people how to get going. Then there's a few steps that I want to do before we can fully migrate, but I'll just put those in some tracking issue. So for now, let's go with this!


Maximum Depth of Binary Tree

Given the root of a binary tree, write an algorithm to find its maximum depth.

The maximum depth of a binary tree is the number of nodes along the longest path from the root node down to the farthest leaf node.

Input:

A binary tree's root node.

Output:

An integer representing the maximum depth of the binary tree.

Constraints:

The number of nodes in the tree is in the range [0, 10^4].
The depth of an empty tree is 0.

Example 1:
Input:
    3
   / \
  9  20
     /  \
    15   7

Output: 3

Explanation: The longest path is root -> 20 -> 7, which has 3 nodes.

Example 2:
Input:
    1
     \
      2

Output: 2

Explanation: The tree has a maximum depth of 2, since the longest path is root -> 2.

Example 3:
Input: None (Empty tree)

Output: 0

Explanation: The tree is empty, so the maximum depth is 0.

Hey @indrakishore !
Kindly assign me this task.

plz assign this task to me and also add hactoberfest tag........


[BUG] Upload component and large file (800 mb )

Version
1.6.0
Environment
Chrome 69.0.3497.100
Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-hozp9w
Steps to reproduce
Select lager file (which is bigger than 2 Gb  ) - result: immediately crash tab
OR
Select lager file (which is bigger than 800 Mb  ) result: When progress bar value was about 40 % and next crash tab
What is expected?
The tab should not crash
What is actually happening?
The tab is crash
Other?

plz try https://ng.ant.design/components/upload/zh#components-upload-demo-custom-request

The result is the same
(Also, I try to do it on https://ant.design/components/upload/, there I don't get a crash tab)

@cipchk plz check this.

Is there any way to use manual upload as file selector then preview the selected file if it an image

@abdelrahmannasr You can use nzPreviewFile property.


third party is not feed when dowloading Vulkan-Samples

I spend Two day tryng to install your sample to be used with Android studio an windows OS. I put the mess intalling new EDI in my hold project. A lot of time losed.
And i just find out that Vulkan-Samples-master\third_party is empty. So it is impossible to compile because android native ndk do not hold these cpp hpp ... files.
regards.

Did you follow the instructions in the readme? specifically the way to clone it:
git clone --recurse-submodules https://github.com/KhronosGroup/Vulkan-Samples.git
cd Vulkan-Samples

If yes you should have received everything in third_party if you still haven't please submit a complete log of what's the output of that command. Otherwise its very hard to help with the information you have provided.

Hi,
I already use Github for dowloading zip version but i did not know that some folder could be hided. To use git i must install it and bacause i do not use it for project participation i never done it.
The problem is that you cannot see if the donwloading project is complete or not.
The sample is also done for android so it is not out of the scope. Gradle for example depends on the IDE version for NDK which depends from the API version. It all related in fact. And when you change the IDE many yhings must be change in old projects like the gradle wrapper. It is a little mess all the time, new syntax, new obligation. It is a real nightmare ;)).
So if i new that the donwload was not complete i would have donwloaded the missing folder first before changing IDE.
Why allowing a donwload with half of the need ? This should have been explain or i should have be able to find it out.
In the donwload the third party folder look fine. nobody could know that it is empty when donwloaded. And if i go further some missing file could be for more deep in the tree and i will have to look at all the folder to find the missing one.
Why make it avalaible for donwload if it is not complete ? why to force using installing git if not real use ?
Any way it does not matter but i am sur that i am not the only one in this case.  I will look at all folder and donwload the needed one.

That's unfortunately nothing we can change. The zip files are generated by github, and github simply does not put the submodules into those zip files.
So the recommended way is to pull the repository via git, which will pull all the submodules.

I just donwloaded GitHubDesktopSetup.exe and and error SeDefaultDllDirectories  in KERNEL32.dll.
I am sorry but it look like something is missing inside again ;)) . I am joking now but in you case i better watch out what you are doing because 2 time in 3 days it a little bit to much for your réputation.
can you tell me which git can be used directly with android. Something working would be better.
;)) i like to joke. It is a pitty because it is a good idea to share compute information and code.
Bonne continuation.

Happy end ;))
I manage to get everything using Git. And i am quite surprise of the sample work. It seems very complete. So bravo to the team. And sorry for been a little bit rude. To old to change ;)).
sincerely Bravo.


DS-4493 prevent empty string assignment for language

References

https://jira.lyrasis.org/browse/DS-4493
Fixes #7827

Description
Prevent empty string assignment for language during Item Import.

@bram-atmire : Just an FYI, this PR is failing in Travis CI because of code style failures. https://travis-ci.com/github/DSpace/DSpace/builds/164239100#L4323

@bram-atmire : Any chances you could update this tiny PR?  Looks like something we could minimally get into 7.1, if possible.

Closing, replaced by #8701


Fix OAuth scopes in _modify_relationship in internal.py

I seem to have found some mistakes in the _modify_relationship function in internal.py: it doesn't pass a scope value of modcontributor to the @restrict_access decorator of the local do_relationship function when the relationship is set to banned or contributor, despite the API documentation saying that the modcontributor relationship requires that scope. The same is true for the wikibanned and wikicontributor relationships, except they also require the modwiki scope on top of the modcontributor scope.
The first commit fixes the banned and modcontributor relationships (or at least tries to do so), but, to fix the other two, I need an answer to this rookie question: How can one pass two or more scopes to the @restrict_access decorator? Edit: apparently, that's currently impossible
Of course, since I'm quite inexperienced with PRAW and the Reddit API, I might be completely wrong about all of this, in which case, sorry for wasting the time of anyone that read this. Edit: It seems that not having the two lines that this PR would add causes remove_contributor and add_contributor to not work and raise the following exception if logged in via OAuth:
Traceback (most recent call last):
  File "<pyshell#17>", line 1, in <module>
    r.get_subreddit("automodtestsub").remove_contributor(r.user.name)
  File "C:\Python27\lib\site-packages\praw\decorators.py", line 346, in wrapped
    raise errors.LoginRequired(function.__name__)
LoginRequired: `do_relationship` requires a logged in session

...and the following exception if logged in via cookie authentication (the login() method):
Traceback (most recent call last):
  File "<pyshell#23>", line 1, in <module>
    r.get_subreddit("automodtestsub").remove_contributor(r.user.name)
  File "C:\Python27\lib\site-packages\praw\decorators.py", line 342, in wrapped
    raise errors.ModeratorRequired(function.__name__)
ModeratorRequired: ``do_relationship` requires a moderator of the subreddit` requires a logged in session

And this happens regardless of whether you're a moderator and have access permissions or not.

I believe multiple scope restrictions are not yet supported, but @bboe may be able to correct me. Using multiple @restrict_access decorators above a function raises AssertionError here, but we also don't have the ability to give it a list or space-separated words.
This is something we will have to discuss and implement before we can add the two-scope decorators like wikibanned.
I've just created the modcontributors refresh token for the test user, so if you're so inclined you may use this opportunity to try writing some test cases for the scopes you're working on. For the modcontributors scope, the test would probably look similar to test_scope_modothers_modself, except with adding an approved submitter instead of a moderator.
This PR is appreciated, but I think we need to work out a couple of things before we can merge. bboe wanted to release PRAW 3.1.0 pretty soon here so these features might become part of 3.2.0. We will keep in touch about this.

I believe multiple scope restrictions are not yet supported, but @bboe may be able to correct me. Using multiple @restrict_access decorators above a function raises AssertionError here, but we also don't have the ability to give it a list, or a space-separated string.
This is something we will have to discuss and implement before we can add the two-scope decorators like wikibanned.

Ah, I see.

This PR is appreciated, but I think we need to work out a couple of things before we can merge. bboe wanted to release PRAW 3.1.0 pretty soon here so these features might become part of 3.2.0. We will keep in touch about this.

Understood.

Thanks for all the scope related PRs. To make things simpler for us, it would be great if you added some tests as @voussoir mentioned. PRs with tests that show an increase in code coverage where code was added means we can pretty much merge them without any verification. Without them, we should write the tests before your code can be merged which can delay the merge.
We can both help you get up to speed writing tests for PRAW if that's something you're interested in. It's totally worth it if you anticipate becoming a regular PRAW contributor.
Thanks again!

Thanks for all the scope related PRs. To make things simpler for us, it would be great if you added some tests as @voussoir mentioned. PRs with tests that show an increase in code coverage where code was added means we can pretty much merge them without any verification. Without them, we should write the tests before your code can be merged which can delay the merge.
We can both help you get up to speed writing tests for PRAW if that's something you're interested in. It's totally worth it if you anticipate becoming a regular PRAW contributor.

Well, while I don't promise to make frequent bigger-than-minor changes to the code, but if I spot something I'd like to change/add that's also within my coding ability to change/add, I'll probably change it, so a briefing on how tests are written shouldn't hurt. Thanks in advance.

I tested this a bit, and it looks like not having the two lines that this PR adds causes remove_contributor and add_contributor to not work and raise the following exception if logged in via OAuth:
Traceback (most recent call last):
  File "<pyshell#17>", line 1, in <module>
    r.get_subreddit("automodtestsub").remove_contributor(r.user.name)
  File "C:\Python27\lib\site-packages\praw\decorators.py", line 346, in wrapped
    raise errors.LoginRequired(function.__name__)
LoginRequired: `do_relationship` requires a logged in session

...and the following exception if logged in via cookie authentication (the login() method):
Traceback (most recent call last):
  File "<pyshell#23>", line 1, in <module>
    r.get_subreddit("automodtestsub").remove_contributor(r.user.name)
  File "C:\Python27\lib\site-packages\praw\decorators.py", line 342, in wrapped
    raise errors.ModeratorRequired(function.__name__)
ModeratorRequired: ``do_relationship` requires a moderator of the subreddit` requires a logged in session

And this happens regardless of whether you're a moderator and have access permissions or not.

Closed due to PR #455 accomplishing this and more.


(5.5) Check for unsupported runtime upgrade paths.

This PR adds a pre-upgrade check that validates that the upgrade path between the installed runtime and the new runtime exists. About https://github.com/gravitational/gravity/issues/1064.
Upgrade path is considered valid if one of these is true:

Direct upgrade is supported.
Upgrade via intermediate runtimes is supported and there are suitable intermediate runtimes.

Versions where direct/intermediate upgrades are supported from are kept in the code so we'll need to be updating them when releasing new major/minor versions which is fine since it doesn't happen too often.
Things that would be nice to have but a bit out of scope for this so postponing them for later:

Having some gravity command that would print supported upgrade paths, incl. in machine-readable format (json/yaml) so 3rd party tools (like robotest) can parse it.
Have a force flag to upgrade to potentially skip this check, however I'm not very sure about usefulness of this one.

Needs forward-ports to 6.1, 6.3 and master (minus the intermediate runtimes part since intermediate upgrades haven't been forward-ported yet).

Yeah, good call on the upgrade policy comment, I added it. That ticket you linked to is actually specifically requesting downgrades which is probably not something we wanna do (short-term at least) as it would require some significant redesign. As for the errors, in case of unsupported upgrade path, the users will see errors like shown here: https://github.com/gravitational/gravity/blob/39633651fe4367ebccd2fb11d10e3e9ebf49eac1/lib/ops/opsservice/versions.go#L243-L256.


Audio Conferencing complimentary dial-out period

The complimentary-dial-out-period should be in a different section as it does not fall into the Accessibility-and-Regulatory category, it is more suited under a Life-cycle subsection to Skype for Business ie. https://docs.microsoft.com/en-us/SkypeForBusiness/Life-cycle/complimentary-dial-out-period

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fee2f094-5a08-489c-03ee-654a9f259b32
Version Independent ID: 813cfbf3-bb73-70ab-610d-68fbf302f6bb
Content: Complimentary dial-out period
Content Source: Skype/SfbOnline/accessibility-and-regulatory/complimentary-dial-out-period.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

I will consider renaming the parent topic. Thanks for the feedback.


bug(meta): Hummock's operations consume a lot of meta cpu

Describe the bug
In a production environment, we found that the meta's cpu cores were full, affecting the behavior of compaction.
Observations:

huge number of ssts
large version size

Speculation:

compaction picker algorithm complexity is too high, when the number of sst is large, the impact is more obvious
version size is too large, the overhead of apply is too large.

Error message/log
No response
To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

We do some investigation on dev env about the meta load.
performed segmented time consumption statistics on the behavior of the meta and found that the apply_version part of the in-memory operation took a lot of time, causing other meta operations to block.

with further analysis, there are only metrics and notification operations here, and a comparison test eventually revealed that the overhead comes from the behavior of metrics label and with_label_values.

It can be observed that as the time spent decreases, the meta CPU load also decreases.

After the Event loop consumption is normalized, the compaction efficiency improves.


Automatically delete head branches

Now:

@ArieGato I suggest to enable this

I deleted some your branches manually.
I have no access for repo settings.

done


azure-rest-api-specs-pr pipeline failing to mark PR with "BreakingChangesReviewRequired"

The PR pipeline bot in azure-rest-api-specs-p failed to add the "BreakingChangesReviewRequired" label to https://github.com/Azure/azure-rest-api-specs-pr/pull/11562 when this PR failed the "Breaking Change (Cross-Version)" PR check:

Here's another instance: https://github.com/Azure/azure-rest-api-specs-pr/pull/11560

Another instance: https://github.com/Azure/azure-rest-api-specs-pr/pull/11517
This PR is failing the “Swagger Breaking Change” PR Check:

But the pipeline did not add the “BreakingChangesReviewRequired” label (maybe because the break is only to a preview api-version in the internal repo?).
The PR reviewer decided to add the label by hand:

About a week later the pipeline was retriggered and the bot removed the label:

In this particular case, a review is needed because the changes in the PR violate our Breaking Change policy – breaking changes are allowed when the break is to a prior preview and not a GA version, but only if the break is done in a new api-version, which was not the case here.

Related email thread:
Sent: Friday, March 17, 2023 8:00 AM
Subject: Breaking Changes labeling in the azure-rest-api-specs repo


i3status: add module

Description
An i3status module, built in the spirit of RFC 42, if not the letter. It deviates from the RFC 42 settings set because order matters for order entries in the config file. Instead, general and modules.<name>.settings are each built like RFC 42 settings. general contains the contents of the config files general entry, and modules.<name>.settings contains the contents of an i3status <name> module. modules.<name>.position is used to arrange the order entries.
I opted to put the default i3status configuration behind an enableDefault option (enabled by default) so the user doesn't have to individually disable 8 different modules to get a bare configuration.
Checklist

[x] Code formatted with ./format.

[x] Code tested through nix-shell --pure tests -A run.all.

[x] Test cases updated/added. See example.

[x] Commit messages are formatted like
{component}: {description}

{long description}

See CONTRIBUTING for more information and recent commit messages for examples.

If this PR adds a new module

[x] Added myself as module maintainer. See example.

[x] Added myself and the module files to .github/CODEOWNERS.

Looks good to me! I just had a concern about the defaults. But I don't know anything about i3status myself so I can't tell whether my question makes any sense or not 🙂
About

P.S. I don't have an entry in nixpkgs maintainers to use in meta.maintainers.

you can add yourself to modules/lib/maintainers.nix and put
meta.maintainers = [ hm.maintainers.JustinLovinger ];

in the module.

you can add yourself to modules/lib/maintainers.nix and put
meta.maintainers = [ hm.maintainers.JustinLovinger ];

in the module.

Done.

Thanks! Rebased to master in ecc1f2310c15e0b2ee9b0fbd2134ef37ded67dd7.

What wrong with my pull request? I had it open for long time and I was ready to introduce changes, but was waiting for review, but this one got merged right away. I am just asking as i want to make more pull requests, but am concerned if they get merged? https://github.com/rycee/home-manager/pull/715

I am closing my pull request as this one seems better and was already merged: https://github.com/rycee/home-manager/pull/715

@offlinehacker Sorry, I had completely forgotten about your PR 😕

@offlinehacker Sorry. I didn't know about your pull request when I made this one.

no problem, I think @JustinLovinger implementation is a bit nicer anyway 🙂


Allow shift-click to input hatches

Allow users to shift-click items into hatches, similar to other containers.

Assuming you're running 1.10.2 as mentioned https://github.com/zmaster587/AdvancedRocketry/issues/662 I've tried testing with the latest minecraft build and have had no problems shift clicking into input hatches.

As mentioned in 662, I think I've made the embarassing error of failing to double-check my version.  Will update this issue momentarily to confirm.

Confirmed non-issue.  You've fixed this already.
Not sure I can explain how I forgot to double-check version.  Apologies.


Replication of Results from KITTI Object Detection network example

Hello,
I am having problems replicating the results from the Object Detection network example. I have tried on several DIGITS 4.0 installations on different computers with different arrangements of GPUs (Titan X, Titan X (Pascal) GTX 1080s). Following the instructions step by step as written in the example I created a KITTI dataset using the prepare_kitti_data.py. I then created a model with lr 0.0001 and the ADAM solver. I specify the network from examples/kitti/detectnet_network.prototxt and used the pretrained weights from dl.caffe.berkeleyvision.org/bvlc_googlenet.caffemodel. Running with the network defaults for batch size (attached image) and then also a batch size of 2 and batch accumulation of 5 as shown in the example.

I have been unable to achieve the shown performane the mAP and recall and precision is consistently 10 to 15 points lower then what is shown in your example graph.

Additionally our loss_coverage starts much higher is it possible we are using a different pretrained model then was used in the example? Can you share the batch size and lr reduction strategy used to generate the results in the example?
Also I'd mention the % accuracy y right axis is very confusing as I thought our network wasn't converging because at first it seems like the mAP number were being plotted on that axis not the Loss axis on the left.
Any insight would be great.

Additionally our loss_coverage starts much higher is it possible we are using a different pretrained model then was used in the example?

I don't think so. I'm using this one:
https://github.com/BVLC/caffe/blob/rc3/models/bvlc_googlenet/readme.md

Can you share the batch size and lr reduction strategy used to generate the results in the example?

We don't have any secret sauce for training DetectNet that we're hiding from you. I follow the steps exactly when I do a training. Sometimes it works and sometimes it doesn't - seemingly due to random initializations. Messing with the learning rate is sometimes helpful. And if you ever get a network that makes good progress, you can start with those trained weights for your next training and it will likely help.

Also I'd mention the % accuracy y right axis is very confusing as I thought our network wasn't converging because at first it seems like the mAP number were being plotted on that axis not the Loss axis on the left.

Yeah I know. Feel free to upvote https://github.com/NVIDIA/DIGITS/issues/900. We had an intern working on a solution (https://github.com/NVIDIA/DIGITS/pull/810), but he ran into problems with the graphing library and it stalled.


Bulk upload traits for PMID 33563976

Please bulk upload the following list of 718 traits to the Curation App:
https://app.zenhub.com/files/2995118/9a460179-9677-40ad-8c5a-10b5d89e6908/download

Closing this issue as I managed to get it to go through myself.


Placeholder api support

I added support for PAPI so that placeholders of all kinds can be used throughout the config of LitePlaytimeRewards. So instead of just being able to use the placeholder %player%, there are now hundreds of placeholders available, which I really needed for some commands that I run in my rewards.

This merge request is a mess at this point (especially all the conflicts with IDEA and target files etc.). I will create a completely fresh new branch and merge request.

This merge request is a mess at this point (especially all the conflicts with IDEA and target files etc.). I will create a completely fresh new branch and merge request.


Fix assertion rendering on mock failures

Fixes #35 by using the utilities implemented in zio/zio#7641

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I see the #render() method on assertions was rolled back in zio/zio#7713, I'm going to convert this to draft until a new one gets implemented

@SirStoke hello 👋 do you have capacity to rebase your PR? very interested in that lovely fix 😄

Hmm, actually the render method has been reverted due to some other issues, we need to give it a bit more thought

Any news on when this PR can be updated and merged?

@mikail-khan It's not ideal, but you can extend your spec with MockSpecDefault to render the mock failures information.

Is this back on the table now with https://github.com/zio/zio/pull/8498?

Is this back on the table now with zio/zio#8498?

Hi! It seems like it would be, but I'm not involved with zio at work anymore, so I don't really have the motivation or time to fix the PR. Sorry about that.
FWIW, unless something major has changed in zio-mock, it should be really easy to port this fix using the new method


"A new release has been found: 3.0.4. Please consider updating." Doesn't reference Traefik

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I used an old version of Traefik, 3.0.4.
What did you see instead?
I saw: "A new release has been found: 3.0.4. Please consider updating."  I saw it in a log filled with all kinds of output and in the context of the log data, it wasn't clear what software was out of date.
What version of Traefik are you using?
3.0.4
What is your environment & configuration?
# (paste your configuration here)

If applicable, please paste the log output in DEBUG level
Assuming I can do the code, would a pull request to change: "A new release has been found: 3.0.4. Please consider updating." to "A new release of Traefik has been found: 3.0.4. Please consider updating." be accepted?

Hello @jmcbri,
Thanks for reaching out.
With the other maintainers, we think that opening a PR makes sense.
However, please create it on the branch v2.11 which is still maintained.
Thank you so much for your participation.

Hello @nmengin, if @jmcbri isn't already assigned I could make a PR on the v2.11 branch.

Hello @neckerio,

Hello @nmengin, if @jmcbri isn't already assigned I could make a PR on the v2.11 branch.

I haven't seen any PR addressing this topic so you can open one.
Thanks.

I did a pull request, but I don't really know what I'm doing, and I'm no
longer convinced the change is justified.  Really appreciate both your
attention, and your patience.
On Mon, Jul 15, 2024 at 3:20 AM Nicolas Mengin @.***>
wrote:

Hello @neckerio https://github.com/neckerio,
Hello @nmengin https://github.com/nmengin, if @jmcbri
https://github.com/jmcbri isn't already assigned I could make a PR on
the v2.11 branch.
I haven't seen any PR addressing this topic so you can open one.
Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/traefik/traefik/issues/10883#issuecomment-2227845372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA43ALKLJGBUM4TZESOWCTZMNZ4LAVCNFSM6AAAAABKOOJIBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXHA2DKMZXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello @jmcbri,
The modification looks good to me, but the PR description should be improved.
Could you please modify the title and the description with something like this PR description?
Concerning the motivation, just add Fixes #10883, thus your PR will close this issue.
Thanks in advance.

I updated, but not sure it was what you wanted.  Also, I think I have to
read the PR guidelines again.
On Tue, Jul 16, 2024 at 3:07 AM Nicolas Mengin @.***>
wrote:

Hello @jmcbri https://github.com/jmcbri,
The modification looks good to me, but the PR description should be
improved.
Could you please modify the title and the description with something like
this PR description?
Concerning the motivation, just add Fixes #10883, thus your PR will close
this issue.
Thanks in advance.
—
Reply to this email directly, view it on GitHub
https://github.com/traefik/traefik/issues/10883#issuecomment-2230176611,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA43AJD6CJTUDOGDLG4JADZMTBEBAVCNFSM6AAAAABKOOJIBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGE3TMNRRGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @jmcbri,
Let's continue the discussion directly on the PR 😄


[Question]: neural search 排序模型cross_encoder web_service.py 使用tensorRT出错

请提出你的问题
config use_encryption model here None
[DAG] Succ init
[PipelineServicer] succ init
2023/01/19 15:57:35 start proxy service
W0119 15:57:38.186408 16534 analysis_predictor.cc:1118] The one-time configuration of analysis predictor failed, which may be due to native predictor called first and its configurations taken effect.
I0119 15:57:38.246953 16534 analysis_predictor.cc:881] TensorRT subgraph engine is enabled
--- Running analysis [ir_graph_build_pass]
--- Running analysis [ir_graph_clean_pass]
--- Running analysis [ir_analysis_pass]
--- Running IR pass [adaptive_pool2d_convert_global_pass]
--- Running IR pass [shuffle_channel_detect_pass]
--- Running IR pass [quant_conv2d_dequant_fuse_pass]
--- Running IR pass [delete_quant_dequant_op_pass]
--- Running IR pass [delete_quant_dequant_filter_op_pass]
--- Running IR pass [delete_weight_dequant_linear_op_pass]
--- Running IR pass [delete_quant_dequant_linear_op_pass]
--- Running IR pass [add_support_int8_pass]
I0119 15:57:39.121083 16534 fuse_pass_base.cc:57] ---  detected 425 subgraphs
--- Running IR pass [simplify_with_basic_ops_pass]
--- Running IR pass [embedding_eltwise_layernorm_fuse_pass]
--- Running IR pass [preln_embedding_eltwise_layernorm_fuse_pass]
--- Running IR pass [multihead_matmul_fuse_pass_v2]
--- Running IR pass [multihead_matmul_fuse_pass_v3]
--- Running IR pass [skip_layernorm_fuse_pass]
I0119 15:57:39.446327 16534 fuse_pass_base.cc:57] ---  detected 25 subgraphs
--- Running IR pass [preln_skip_layernorm_fuse_pass]
--- Running IR pass [conv_bn_fuse_pass]
--- Running IR pass [unsqueeze2_eltwise_fuse_pass]
--- Running IR pass [trt_squeeze2_matmul_fuse_pass]
--- Running IR pass [trt_reshape2_matmul_fuse_pass]
--- Running IR pass [trt_flatten2_matmul_fuse_pass]
--- Running IR pass [trt_map_matmul_v2_to_mul_pass]
I0119 15:57:39.483711 16534 fuse_pass_base.cc:57] ---  detected 74 subgraphs
--- Running IR pass [trt_map_matmul_v2_to_matmul_pass]
I0119 15:57:39.491195 16534 fuse_pass_base.cc:57] ---  detected 24 subgraphs
--- Running IR pass [trt_map_matmul_to_mul_pass]
--- Running IR pass [fc_fuse_pass]
I0119 15:57:39.572584 16534 fuse_pass_base.cc:57] ---  detected 74 subgraphs
--- Running IR pass [conv_elementwise_add_fuse_pass]
--- Running IR pass [tensorrt_subgraph_pass]
I0119 15:57:39.604351 16534 tensorrt_subgraph_pass.cc:145] ---  detect a sub-graph with 17 nodes
I0119 15:57:39.609318 16534 tensorrt_subgraph_pass.cc:433] Prepare TRT engine (Optimize model structure, Select OP kernel etc). This process may cost a lot of time.
failed to create predictor: Log_id: 0  Raise_msg: (InvalidArgument) The input [layer_norm_37.tmp_2] shape of trt subgraph is [-1,-1,768], please enable trt dynamic_shape mode by SetTRTDynamicShapeInfo. (at /paddle/paddle/fluid/inference/tensorrt/engine.h:118)
ClassName: LocalPredictor.load_model_config..create_predictor_check  FunctionName: create_predictor_check

装的是tensort的paddlepaddle版本吗？请问环境是啥？

装的是paddle的tensort版本：paddlepaddle_gpu-2.3.2.post101-cp36-cp36m-linux_x86_64.whl
tensort版本：TensorRT-<IP_ADDRESS>.CentOS-7.6.x86_64-gnu.cuda-10.1.cudnn7.6.tar.gz


update to use the local DNS resolver by default

update to use the local DNS resolver by default， update the file conf/conf.yaml.
close https://github.com/apache/incubator-apisix/issues/1378

merged @dabue
many thx


Update controller.js to update the value of the scopes leds array.

This will help to make sure that the leds array is synced up when calling send directly instead of through the update method
Should Address Issue #1 if this fix is acceptable.
Motivation
when calling send directly, I expect that the scoped leds array will be updated, so that calling update later on, I know that the leds array is maintained from a previous state.
Issues closed
Issue #1
Intended version

[ ] Patch
[X] Minor
[ ] Major

I will create a test for this case and when this passes, I will merge the PR.


The wizard "Select a capacity model" will disappear after selecting "vCore cluster" option

OS: Windows 10
Build Version: 20241116.1
Regression: Not a Regression
Repro Steps:

F1 -> Select "Azure Databases: Create Server..." -> Select "Cosmos DB for MongoDB" -> Enter a name -> Select "vCore cluster" option.
Navigate to VS Code.
Check whether the wizard "Select a capacity model" still exists or not.

Expect:
The wizard "Select a capacity model" still exists.

Actual:
The wizard "Select a capacity model" disappears.
More Info:
The wizard "Select a capacity model" still exists after selecting "Learn more..." option.

This is unclear... selecting "Learn more..." should not make the wizard disappear, if that happens, it's a bug but I can't reproduce that. Selecting "vCore Cluster" behaviour is intended, the wizard stops there since there is currently no way to proceed from there. Users will need to read the documentation and come back. A full E2E experience to create MongoDB clusters will come with a later release.


fix(webpack): revert back to webpack 4

Codecov Report

Merging #175 (8fa7655) into master (922aaee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   62.36%   62.36%
=======================================
  Files          54       54
  Lines        2864     2864
  Branches      586      586
=======================================
  Hits         1786     1786
  Misses        943      943
  Partials      135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922aaee...8fa7655. Read the comment docs.


Add COSE support

A prototype of notation cose support has been completed.
This tracks:

[x] Complete remote signing support: veraison/go-cose #9
[ ] Notary Spec support of COSE #48
[ ] Add support for COSE, through the veraison/go-cose project

The COSE support should be through notation-core-go, where notation-core-go implements COSE support through the veraison/go-cose project.


fix queries for new version of grammar

This change accommodates https://github.com/tree-sitter/tree-sitter-julia/pull/106
Fixes #10
Tree-sitter grammars do not appear to provide version information, so users should be warned to upgrade in parallel.

Thank you very much @RalphAS !!