HDDS-1775. Make OM KeyDeletingService compatible with HA model

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
477
trunk passed

+1
compile
244
trunk passed

+1
checkstyle
61
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
790
branch has no errors when building and testing our client artifacts.

+1
javadoc
146
trunk passed

0
spotbugs
312
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
495
trunk passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
429
the patch passed

+1
compile
249
the patch passed

+1
cc
249
the patch passed

+1
javac
249
the patch passed

-0
checkstyle
36
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
638
patch has no errors when building and testing our client artifacts.

+1
javadoc
149
the patch passed

+1
findbugs
518
the patch passed

_ Other Tests _

+1
unit
241
hadoop-hdds in the patch passed.

-1
unit
162
hadoop-ozone in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

4919

Reason
Tests

Failed junit tests
hadoop.ozone.om.ratis.TestOzoneManagerRatisServer

hadoop.ozone.om.TestKeyDeletingService

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 41ac9836c91f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 738c093

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/1/testReport/

Max. process+thread count
1319 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Let's add an HA test case.
+1 with the test case added.

Fixed failing tests and add unit tests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
102
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
697
trunk passed

+1
compile
343
trunk passed

+1
checkstyle
101
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
1018
branch has no errors when building and testing our client artifacts.

+1
javadoc
192
trunk passed

0
spotbugs
444
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
706
trunk passed

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

+1
mvninstall
735
the patch passed

+1
compile
309
the patch passed

+1
cc
309
the patch passed

+1
javac
309
the patch passed

-0
checkstyle
41
hadoop-ozone: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1
mvnsite
0
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
741
patch has no errors when building and testing our client artifacts.

-1
javadoc
101
hadoop-ozone generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1
findbugs
609
the patch passed

_ Other Tests _

+1
unit
364
hadoop-hdds in the patch passed.

-1
unit
2958
hadoop-ozone in the patch failed.

+1
asflicense
40
The patch does not generate ASF License warnings.

9387

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestSecureOzoneManager

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.om.TestOmMetrics

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.hdds.scm.pipeline.TestSCMRestart

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 3edb16226876 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4a70a0d

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/artifact/out/diff-checkstyle-hadoop-ozone.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/artifact/out/whitespace-eol.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/testReport/

Max. process+thread count
4995 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks for the reviews @anuengineer and @bharatviswa504.
I have opened a new Jira HDDS-1814 to address the Java 8 method reference comments.
Fixed the checkstyle issues.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
487
trunk passed

+1
compile
273
trunk passed

+1
checkstyle
70
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
830
branch has no errors when building and testing our client artifacts.

+1
javadoc
157
trunk passed

0
spotbugs
333
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
543
trunk passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
454
the patch passed

+1
compile
265
the patch passed

+1
cc
265
the patch passed

+1
javac
265
the patch passed

-0
checkstyle
37
hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
650
patch has no errors when building and testing our client artifacts.

-1
javadoc
86
hadoop-ozone generated 3 new + 12 unchanged - 0 fixed = 15 total (was 12)

+1
findbugs
529
the patch passed

_ Other Tests _

+1
unit
273
hadoop-hdds in the patch passed.

-1
unit
1486
hadoop-ozone in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

6497

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.TestStorageContainerManager

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 27867ac4aa2e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d429d74

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/artifact/out/diff-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/testReport/

Max. process+thread count
5290 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank you all for the reviews.

When you commit the next JIRA, you might want to take care of 2 CheckStyle and 3 JavaDoc. If you click on the links you will see the errors. Thank you for getting this done. Appreciate it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
87
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
576
trunk passed

+1
compile
270
trunk passed

+1
checkstyle
79
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
916
branch has no errors when building and testing our client artifacts.

+1
javadoc
184
trunk passed

0
spotbugs
340
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
602
trunk passed

_ Patch Compile Tests _

0
mvndep
22
Maven dependency ordering for patch

+1
mvninstall
449
the patch passed

+1
compile
265
the patch passed

+1
cc
265
the patch passed

+1
javac
265
the patch passed

+1
checkstyle
77
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
710
patch has no errors when building and testing our client artifacts.

-1
javadoc
106
hadoop-ozone generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)

+1
findbugs
584
the patch passed

_ Other Tests _

+1
unit
384
hadoop-hdds in the patch passed.

-1
unit
2317
hadoop-ozone in the patch failed.

+1
asflicense
48
The patch does not generate ASF License warnings.

7925

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.om.TestOzoneManager

hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1063

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc

uname
Linux 3fc217d56237 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 71c21f0

Default Java
1.8.0_212

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/6/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/6/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/6/testReport/

Max. process+thread count
4342 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1063/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


operator project-quay (3.12.2)

Add 3.12.2 to community operators

/merge possible

/merge possible


Find and validate profile timing

I haven't found a way to profile Rust code on Windows. Specifically, the TypeReader takes almost a second to construct due to the sheer size of the default (mostly Win32) metadata. I already spotted some obvious bottlenecks (here, here, and switching to HashMap here), but proper profiling is needed to dig deeper.
As a bonus, having some profile timing that the CI build can measure and guard against regressions would be nice.

Visual Studio comes with a Profiler, that doesn't need anything more than a binary and debug symbols (Debug -> Performance Profiler...). Have you tried using that already?
You will need to instruct the compiler to generate debug symbols. This can be done by adding the following to your Cargo.toml file:
[profile.release]
debug = true

The profiler can be run from the command line as well, which might be useful for the CI task, though I don't have any experience with that.

Have you got that to work? I tried it yesterday and it complained that the executable produced by the Rust compiler was not supported.

Never mind, I only tried the command line tools. The Visual Studio IDE via Debug -> Performance Profiler seems to work. Thanks for the tip!

Do you happen to recall the exact error message you were getting, Kenny?
While trying to move #851 forward, I, too, ran into issues with the profiler. At this time it looks as though rustc produces (partially) incorrect PDBs. I've filed a bug report with the compiler team. Do the quoted error diagnostics read familiar?

Yes, that's the same error. I'll mention your bug report to some internal tooling folks. Perhaps they can shed some light.

Tim, does this still work for you? I just tried using the IDE and I get this errror:
Exception of type 'Microsoft.DiagnosticsHub.Diagnostics.CollectionStartFailedHubException' was thrown.

Profiling from the IDE in CPU sampling mode still works for me. I've verified this for:

Visual Studio 2017 15.9.44
Visual Studio 2019 16.11.10
Visual Studio 2022 17.1.0 Preview 5.0

The target was compiled (release configuration with debug symbols) using Rust 1.58.1.
I wonder if a recent fix for Visual Studio 2017 is in any way related to the failure.


decrease memory usage of DFA with variable width delta encoding of instruction pointers

(This is a ticket that I feel has limited scope, and as such, I'd be happy to mentor it. I think I'd consider this "medium" if one has worked with finite automata before, and probably "hard" if not.)
The lazy DFA works by computing states as they are visited during search. At most one state is created per byte of the haystack. In the vast majority of cases, the time it takes to do state construction is negligible because they are reused throughout search. However, the DFA does have pathological cases that can lead to exponential blow up in the number states. In particular, the worst case is when every byte of input results in a new state being created. For this reason, the DFA puts a bound on how many states are stored. If that bound is reached, all existing states are deleted and the DFA continues on (possibly recomputing states that were previously deleted). Since creating states can be slow, if the DFA clears the state cache too frequently, then the DFA will give up and a slower matcher will run in its place.
Therefore, given some fixed memory requirement of N bytes, it makes sense to try and figure out how we can store as many states as possible in N bytes. The more states we can fit into N bytes, the less frequently we flush the cache, which in turn increases the number of regexes and haystacks that we can process with the DFA.
Let's take a look at how State is defined:
struct State {
    next: Box<[StatePtr]>,
    insts: Box<[InstPtr]>,
    flags: StateFlags,
}

next corresponds to the state's transitions. insts corresponds to the set of NFA states that make up this single DFA state. flags indicates some facts about the state, such as whether it is a match state, whether it observes word characters (to support word boundary assertion lookaround) and whether any of its NFA states correspond to empty assertions.
One somewhat straight-forward way to reduce the memory requirements is to optimize this representation. flags is probably as small as it's going to get: it's a single byte. next is also unfortunately as small as it will get since it must support fast random access. Notably, it is used inside the DFA's inner loop. insts however is not used in the DFA fast path and is only used during state construction. State construction is permitted to be somewhat slow, which means we should be able to optimize for space at the expense of time.
Currently, insts is a sequence of 32 bit pointers to instructions in an NFA program. This means that every NFA state in a DFA state occupies 4 bytes. Some DFA states can contain many NFA states, especially regexes that contain large Unicode character classes like \pL. It is also my hypothesis that the set of instruction pointers in each DFA state probably occur close together in the NFA graph. This means that the overall delta between the pointers is probably small.
This means that we should be able to take advantage of delta compression. That is, insts would change its representation from a Box<[InstPtr]> to a Box<[u8]>, where we would write delta encoded pointers. For example, consider this sequence of instruction pointers:
[2595, 2596, 2597, 2598, 2599, 2600, 2601]

These are real instruction pointers extracted from the (a|b|c|d) portion of the regex \pL(a|b|c|d). The actual program can be seen using the regex-debug tool:
$ regex-debug compile '\pL(a|b|c|d)' --dfa
...
2595 Split(2596, 2597)
2596 Bytes(a, a) (goto: 2602)
2597 Split(2598, 2599)
2598 Bytes(b, b) (goto: 2602)
2599 Split(2600, 2601)
2600 Bytes(c, c) (goto: 2602)
2601 Bytes(d, d)
2602 Match(0)

Notably, each of these instruction pointers could be represented with two bytes, but they are always represented by four bytes today. In fact, we can do better with a delta encoding. After applying a delta encoding, here's what the new instruction pointers look like:
[2595, 1, 1, 1, 1, 1, 1]

Now, only the first pointer requires two bytes while the remaining require a mere one byte. All we need to do is apply this delta encoding to our insts list, then encode the resulting pointers using a variable-length encoding, like the one used in protocol buffers. We would then need a way to decode and iterate over these pointers, which is needed here: https://github.com/rust-lang-nursery/regex/blob/2ab7be3d043a1ef640dc58ec4a4038d166ba1acd/src/dfa.rs#L644
And that should do it.
Here are some other thoughts:

It would be cool to get the memory usage down low enough to improve the sherlock::repeated_class_negation benchmark, although I think it might not be quite enough. (I think its DFA requires around 5MB of space, and I don't think this optimization will eliminate more than half of the memory required, but maybe it will.)
Ideally, we don't use unsafe and don't use any additional dependencies. I think the encoding scheme is simple enough that we can hand roll it. We shouldn't need any unsafe because we just don't care that much about CPU cycles spent here.
Tests may be hard. Currently, the only real test that is even close to this issue is dfa_handles_pathological_case in tests/crazy.rs, but it's not clear how that can be used to tese this optimization in particular. My feeling is that the most important tests for this addition already exist. The benchmarks will also catch us if we do something really dumb like increase the memory requirements.

Hey @BurntSushi, I may be interested in working on this!
I've been meaning to work on regex (because it's really interesting), but I haven't had much time. I haven't done much work with finite automata (outside of my theoretical CS courses), so it'll probably take me some time to get started. (If you want to get this done quickly, I'll gladly let someone else take over, of course.)

@killercup No need to have it done quickly! I'm happy to mentor any experience level. :-)

@killercup To adjust the difficulty level a bit: I think the actual optimization work should not be that bad, since it's really just a simple encoding/decoding scheme. The reason why I ranked the difficulty higher than that is because the DFA code is dense and it may take a bit of time to grok it!

Note that PR #202 changes the representation of State somewhat. In particular, the transitions are no longer stored in a State proper. So the representation now looks like this:
struct State {
     insts: Box<[InstPtr]>,
    flags: StateFlags,
}

I think everything I said above still applies.
Another though: if insts goes to a Box<[u8]>, then it seems sensible to store the flag byte in the first byte of insts, which should shave off 7 bytes of overhead per state object because of struct alignment/padding. This means that State simply becomes struct State(Box<[u8]>). Cool!

Very nice! Thanks for the heads up. I'll keep that in mind :smiley:

@killercup Did you end up deciding whether you wanted to tackle this?

@BurntSushi Yes, I still want to do this! I have spend some time experimenting and thinking about this, but haven't had enough time yet to do something meaningful. I hope that changes in the next weeks. I'll keep you up-to-date :)

@killercup Great! Look forward to it. I tried assigning you to this issue, but I guess I can only assign project members. Sorry. :-(

@killercup It turns out that this doesn't help the repeated_class_negation benchmark. It simply requires too many states. Of course, even if we did fix it, there will always be regexes that exceed the cache size. Still, this change should expand the class of regexes executable by the DFA.


Fix deprecated string:strip calls

Compiling with OTP 21 gave deprecation warnings for string:strip. Replaced the calls with string:trim.

I guess if compatibility with older OTP releases is required, it might be better to turn off warnings as errors instead.

@kjw1 thanks for the PR, but I don't think breaking previous OTP versions is an option for us. I opened #14 to add OTP 21 testing in travis, and I don't see the problem there or locally with OTP 21.1... it seems to just work as-is. I don't see any errors. It seems that string:strip/1,2,3 functions are obsolete rather than deprecated, meaning they're not unicode compatible. What version of OTP 21 are you seeing an issue with?

This is what my erlang RELEASES file tells me:
%% coding: utf-8
[{release,"Erlang/OTP","21","9.2.1",
      [{kernel,"5.4.2","/usr/local/lib/erlang/lib/kernel-5.4.2"},
       {stdlib,"3.4.3","/usr/local/lib/erlang/lib/stdlib-3.4.3"},
       {sasl,"3.1.1","/usr/local/lib/erlang/lib/sasl-3.1.1"}],
      permanent}].

When I run rebar3 compile it gives me this:
===> Verifying dependencies...
===> Compiling eini
===> Compiling src/eini_parser.erl failed
src/eini_parser.yrl:109: string:strip/3: deprecated; use string:trim/3 instead
src/eini_parser.yrl:109: string:strip/3: deprecated; use string:trim/3 instead

rebar3 --version
rebar 3.5.0 on Erlang/OTP 21 Erts 9.2.1

Same error when I use the in repo rebar.

Hmm, I am on OTP 21.1.2, and I see:
$ cat ~/bin/kerl.d/21.1.2/releases/RELEASES
%% coding: utf-8
[{release,"Erlang/OTP","21","10.1.2",
          [{kernel,"6.1","/Users/nal/bin/kerl.d/21.1.2/lib/kernel-6.1"},
           {stdlib,"3.6","/Users/nal/bin/kerl.d/21.1.2/lib/stdlib-3.6"},
           {sasl,"3.2.1","/Users/nal/bin/kerl.d/21.1.2/lib/sasl-3.2.1"}],
          permanent}].

and rebar3:
$ rebar3 --version
rebar 3.6.1 on Erlang/OTP 21 Erts 10.1.2

It surprises me that your ERTS is a full version behind mine ERTS 9.x corresponds to OTP 20.x, and I am wondering how you have set up your Erlang installation.

It looks like I'm installed from source, I must have needed a patch for something and forgotten about it. It works with the mainline release of erlang. Thanks for looking at this with me, the pull request seems unneeded.

Glad you got it figured out! I previously said that the functions are "obsolete" rather than "deprecated," and I am wondering if there was some point in 21 development where they were actually deprecated (which would have caused the warnings you saw) before someone changed their mind.
Anyway, I am thinking it may be useful to do a platform_define and conditionally use the new functions on newer OTP in any case. I don't think there's a technical need to, given that I don't think our use case for trimming is particularly unicode sensitive, but I'm guessing those functions will get deprecated in the next OTP release in any case.


[ResolveTool] Add an json dumping option

This adds option to to dump resolution information in JSON format in the
hidden resolve tool.

@ddunbar mind if I add this mode? Looks like resolve tool is hidden anyway
This will help in extracting and saving dependency data from real world repos.

LGTM

@swift-ci please test

@swift-ci please test


Dealing with existing vhost files

So I've noticed that if a particular vhost already has a file in the vhost.d/ directory, the default template from nginx-proxy doesn't pick up the changes made to default.  This basically means that those hosts won't have the /.well-known/ path... any way to deal with this?

If a particular vhost already exists in vhost.dit is modified has the default.
Can you double check ?

Ah, yea... it works.  The problem was that I was using a wildcard domain for VIRTUAL_HOST and then drilling down to one specific host for LETSENCRYPT_HOST.
Now that I have VIRTUAL_HOST contain a list of hosts, LETSENCRYPT_HOST has one of those hosts and vhosts.d/ contains one entry for every VIRTUAL_HOST things work just fine.


NextRequest #84 ; BART #96 ; LAPD #18

Description
This is intended to build out a library enabling easier scraping of NextRequest FOIA portal data, fulfilling #84 . Two versions of the sites are supported by this library.
The Bay Area Rapid Transit Police Department (BART / BART PD) scraper is prepared as an example of the library and fulfills #96 .
The library has been tested against a different version of a NextRequest site used by the Los Angeles Police Department and fulfills #18
Summary of Changes
-- Creates an easy-to-use NextRequest library, with an easier-to-use library that works on two versions of NextRequest document folders.
-- Creates a BART PD scraper as an examplar of this library.
-- Creates a LAPD scraper as a cautionary tale of how weird scraping index files can get.
Related Issues
-- NextRequest #84
-- BART PD #96
-- LAPD #18
How to Review
However you'd like. This includes a library, an implementation in one format, and an implementation in the other format I've found.
The BART PD scraper is significantly simpler, as the entirety of their records are in a single NextRequest folder.
LAPD required recursion and also identified a number of edge cases.
The NextRequest code has grown in complexity to handle edge cases, but while readability suffered it should be more robust..
Notes

It's possible, perhaps even likely, that other compatibility problems in the NextRequest library will be found the more it is used.
It's possible, perhaps even likely, that other versions of NextRequest sites will be discovered, and that will require some rework. The BART template is used on more than one site, at least.

The rebase made it show changes to files I didn't touch. At least some of these are current things already in dev.

ca_bay_area_rapid_transit_pd.json
ca_los_angeles_pd.json
Sample metadata here

@stucka one small merge conflict here, but if you can update this I can get this merged in this week and unblock some more work


settings for dependent packages should be respected

Consider a paket.dependencies file:
source api.nuget.org/etc/etc

nuget A
nuget B content: none

and a paket.references file in a project that just specifies a dependency on A
Now imagine that B is a dependency of A
Right now on install for a project we take the full set of packages [A,B] and extract from it the top-level dependencies of the project, resulting in [A].  We then configure the installSettings for this dependency, which in this case is the empty InstallSettings.
After we build the top-level map we augment it with the n-tier dependencies of each top-level dependency, and use the parent's configured InstallSettings only.  This results in an install of package B where the content: none directive is not honored.
This pull request resolves the settings for the n-tier dependencies in a similar manner to the top-level dependencies, while allowing any top-level dependency settings to override the settings configured for the lower-level package if any are present.

very cool thx.


Translate to Prollog

A function that take a tuple with 5 arguments and returns a tuple with 3, will be translated to a predicate with 8 arguments.
You need to define a transpiration scheme, for tuples.
Tramspiler is something that converts from a language into the same languages.

The function body should be translated to terms.
if tuple_item is a term than translation is one to one.
If tuple you have to decompose it.
Variable, encode it in the result.
Invocation is the most difficult part. Separate issue for that.


New ExplicitInt type

Description
Introduce a new ExplicitInt type in the kotools.types package having the same feature of the kotools.types.number.IntHolder type.
Checklist

[x] Add the kotools.types.ExplicitInt interface.
[x] Add binary operations to the new type.
[x] Add conversions to the new type.
[x] Deprecate the kotools.types.number.IntHolder type.
[x] Update Work in progress section in changelog.

Done.

Add the rem operations to this new ExplicitInt type.

Done.


$page.url.hash does update on moving through browser history

Describe the bug
I want my app to react on changes in the URL-hash.
Unfortunately $page.url.hash does not update on routing through browser history.
Reproduction
https://codesandbox.io/p/sandbox/sveltekit-hash-navigation-example-rlxmtv?file=/README.md:3,183
Logs
No response
System Info
System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.59 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.0 - /opt/homebrew/bin/node
    Yarn: 1.22.18 - ~/.yarn/bin/yarn
    npm: 9.8.0 - /opt/homebrew/bin/npm
    pnpm: 7.29.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 116.0.5845.96
    Safari: 16.5.2
  npmPackages:
    @sveltejs/adapter-vercel: ^3.0.3 => 3.0.3
    @sveltejs/kit: ^1.23.0 => 1.23.0
    svelte: ^4.2.0 => 4.2.0
    vite: ^4.4.2 => 4.4.9

Severity
serious, but I can work around it
Additional Information
With the SvelteKit next-version it works.

Noticed the same with Edge and Firefox.


Bumping react-fast-pdf to v1.0.12

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/37724
PROPOSAL: https://github.com/Expensify/App/issues/37724#issuecomment-1989219526
Tests

[X] Verify that no errors appear in the JS console

Go to any chat.
Upload two single-page PDFs: one with a long page and another with a short page.
Click on the PDF preview to open each document.
Ensure that both PDFs are centered properly. Check that the longer PDF displays correctly without the top padding being chopped off.

Offline tests

Go to any chat.
Upload two single-page PDFs: one with a long page and another with a short page.
Click on the PDF preview to open each document.
Ensure that both PDFs are centered properly. Check that the longer PDF displays correctly without the top padding being chopped off.

QA Steps

[X] Verify that no errors appear in the JS console

Go to any chat.
Upload two single-page PDFs: one with a long page and another with a short page.
Click on the PDF preview to open each document.
Ensure that both PDFs are centered properly. Check that the longer PDF displays correctly without the top padding being chopped off.

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

We have verified podfile action failed. I don't get much of the detail, but it seems that there was a failure while setting up the node.

@abzokhattab Could you try pull the latest main to fix the failing action?

Friendly bump @abzokhattab

sorry I missed the notification.
just merged to main again

@ishpaul777 @parasharrajat @Beamanator The action verify podfile is keep failing. I'm not sure what the problem is since the upgrade doesn't reproduce a podfile-lock file. Besides that the test looks good to me.

Asked here.
@abzokhattab Let's try to pull the main one more time.

For me, it looks like the "Setup Node" action is... stilllllll running??

@Beamanator Can we try to re-run the action manually?

@abzokhattab Let's try to pull the main one more time.

Done

Huh, looks like pulling main worked!!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.69-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


this is garbage

The beer I mean! What is all that dust doing in in it?

We really need to work on quality control

We really need to work on quality control

I dream of a day when you’ll judge this code not by the color of its color-scheme, but by the content of its characters

I'm sure you would make a fierce Content Manager


Say.js stoped working on Windows 10

Error: At line:1 char:1

    at Socket.<anonymous> (...\node_modules\say\platform\base.js:44:16)
    at Object.onceWrapper (events.js:422:26)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:280:11)
    at Socket.Readable.push (_stream_readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

That's cool 😆

Same thing happening to me, I have no idea how to fix it

Same thing happening to me, I have no idea how to fix it

just allow threat in windows defender


Suggestion: Using Google Charts

It would be nice to see some Google charts, https://developers.google.com/chart/interactive/docs/gallery, with the themes of AdminLTE.

@Leon-O you can use any charts library with AdminLTE. I chose the few we have because of their simplicity and to provide an example. However, there are many awesome charts libraries out there like HighCharts, jqPlot and Google Charts.
You can report any problems that may occur when integrating Google charts with AdminLTE here. Thanks for the suggestion!


Update NPM

Hi there,
I installed normally using yarn and noticed that the npm package is outdated. By specifically using the github repository works fine.
It would be good to update the npm version to the latest.

Project is dead 👎🏻


Fix .label return

This PR changes the return value for Period.label from a numpy.array to be an xarray.DataArray which makes it easier to be used in .groupby operations (same as #14 )

@Kirill888 not sure why black is failing here thinking - locally all is good and nothing is to be re-formatted

most likely version mismatch of black, I recently noticed that they changed how ** operator is padded with spaces for example, but maybe more other things. We should really pin these things I guess

updating the env fixed it, looks like it was indeed the ** padding,


feat: Select widget default value checks

Description
Checks for Select widget Default Value
Fixes #13664
Fixes #12531
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit Test

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=6728ec1
Note: testing perf tests, nothing related to this PR.

/ok-to-test sha=9d4b85f

/ok-to-test sha=740912a

/ok-to-test sha=1584ae5

/ok-to-test sha=38ed2fb

@Tooluloope App crash on entering query for Default value
https://www.loom.com/share/8a45f2617651469e82fb531e629a89ed

/ok-to-test sha=7ec2e30

/ok-to-test sha=1c6874e

@Tooluloope App crash on entering query for Default value https://www.loom.com/share/8a45f2617651469e82fb531e629a89ed

@vivekverma2312 This is fixed

/ok-to-test sha=df60a18

If label is not same between options and default {label, value}; We show the default from the list of options
The selectedOptionLabel and selectedOptionValue should populate data of value from default and label from options

The selectedOptionLabel is populating label from default and not from options

@vivekverma2312 Can you confirm the label is in the option

/ok-to-test sha=16ee224

@vivekverma2312 Can you confirm the label is in the option
if the label isn't in the options, it would show that from default.

@Tooluloope label is not available in options

Exactly, once label isn’t in options it would take the one from Default options
@vivekverma2312

@Tooluloope Thanks clearing the doubt. It worked fine.

/ok-to-test sha=462aad4

/ok-to-test sha=494d17a

/ok-to-test sha=985cc1a

/ok-to-test sha=3bb8d99


Add a button to open code in editor

Is your feature request related to a problem? Please describe.
When a remote environment is launched and it's ready for development it would be very useful to take users directly to the code to start developing on the new environment.
Describe the solution you'd like
Based on the path to the docker-compose file, a button can be added to open an editor at the same path. On a first iteration, we can create just an "Open in VSCode" button, being VSCode one of the most popular editor nowadays. But in the future we could add support for other editors.

VSCode button mock:

Editor selector mock:

please assign me this issue

Awesome @semi-infiknight , thanks for participating in Hacktoberfest!

@semi-infiknight would you be able to work on this?
This would be a great addition. Docker is offering 15 personalized macro keypads to the best docker extension contributors worldwide, and we would like to propose this issue to the contest

ok i will
On Thu, 20 Oct, 2022, 2:57 pm Pablo Chico de Guzman, <
@.***> wrote:

@semi-infiknight https://github.com/semi-infiknight would you be able
to work on this?
This would be a great addition. Docker is offering 15 personalized macro
keypads to the best docker extension contributors worldwide, and we would
like to propose this issue to the contest
—
Reply to this email directly, view it on GitHub
https://github.com/okteto/docker-desktop-extension/issues/73#issuecomment-1285219247,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXE2HXPUS2PIJYB44YL3SBDWEEF6XANCNFSM6AAAAAAQTC4XTA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can I work on this if this is still pending?

Hey @rlamana, This one seems to be dormant for quite some time. Is it still actively being developed ?

Not at all. Since @semi-infiknight couldn't continue with this issue, @HeartBeat1608 or @ckragarwal if you are still interested, this would be a great addition to the extension.


[BUG]: Invalid date from relational queries

What version of drizzle-orm are you using?
0.27.2
What version of drizzle-kit are you using?
0.17.6
Describe the Bug
All dates from relational queries inside with are Invalid date
const project = await db.query.projects.findFirst({
  columns: {
    id: true,
  },
  with: {
    deployments: {
      columns: {
        id: true,
        startedAt: true,
      },
      with: {
        commit: {
          columns: {
            id: true,
            createdAt: true,
          },
        },
      },
    },
  },
})

const deployment = await db.query.deployments.findFirst({
  where: eq(deployments.id, project.deployments[0].id),
  with: {
    commit: {
      columns: {
        id: true,
        createdAt: true,
      },
    },
  },
  columns: {
    id: true,
    startedAt: true,
  },
});

// console.log(project);
{
  id: 1,
  createdAt: '2023-07-15T19:20:18.694Z',
  deployments: [{
    id: 1,
    startedAt: Invalid Date,
    commit: {
      id: 1,
      createdAt: Invalid Date
    }
  }]
}

// console.log(deployment);
{
  id: 1,
  startedAt: '2023-07-15T19:20:19.490Z',
  commit: {
    id: 1,
    createdAt: Invalid Date
  }
}

Expected behavior
// console.log(project);
{
  id: 1,
  createdAt: '2023-07-15T19:20:18.694Z',
  deployments: [{
    id: 1,
    startedAt: '2023-07-15T19:20:19.490Z',
    commit: {
      id: 1,
      createdAt: '2023-05-10T16:15:21.912Z'
    }
  }]
}

// console.log(deployment);
{
  id: 1,
  startedAt: '2023-07-15T19:20:19.490Z',
  commit: {
    id: 1,
    createdAt: '2023-05-10T16:15:21.912Z'
  }
}

Environment & setup
Projects model
import { users } from '@/db/models/users';
import { InferModel } from 'drizzle-orm';
import { pgTable, serial, timestamp, varchar, integer } from 'drizzle-orm/pg-core';
import { relations } from 'drizzle-orm';
import { projectEnvironments } from './project_environments';
import { repositories } from './repositories';

const PROJECT_TYPE = ['client', 'server'] as const;

export type ProjectType = (typeof PROJECT_TYPE)[number];

export const projects = pgTable('projects', {
  id: serial('id').primaryKey(),
  name: varchar('name').notNull(),
  slug: varchar('slug').notNull(),
  type: varchar('type', { enum: PROJECT_TYPE }).notNull(),
  userId: integer('user_id')
    .references(() => users.id)
    .notNull(),
  updatedAt: timestamp('updated_at').defaultNow().notNull(),
  createdAt: timestamp('created_at').defaultNow().notNull(),
});

export type Project = InferModel<typeof projects>;

export const projectsRelations = relations(projects, ({ many }) => ({
  deployments: many(deployments),
}));

Deployments model
import { integer, pgTable, serial, text, timestamp, varchar } from 'drizzle-orm/pg-core';
import { projects } from './projects';

import { InferModel, relations } from 'drizzle-orm';
import { commits } from './commits';

const DEPLOYMENT_STATUS = ['doing', 'error', 'success'] as const;
export type DeploymentStatus = (typeof DEPLOYMENT_STATUS)[number];

export const deployments = pgTable('deployments', {
  id: serial('id').primaryKey(),
  slug: varchar('slug').notNull(),
  status: varchar('status', { enum: DEPLOYMENT_STATUS }).notNull().default('doing'),
  projectId: integer('project_id')
    .references(() => projects.id)
    .notNull(),
  commitId: integer('commit_id').references(() => commits.id),
  endedAt: timestamp('ended_at').defaultNow(),
  startedAt: timestamp('started_at').defaultNow().notNull(),
});

export type Deployment = InferModel<typeof deployments>;

export const deploymentRelations = relations(deployments, ({ one }) => ({
  project: one(projects, {
    fields: [deployments.projectId],
    references: [projects.id],
  }),
  commit: one(commits, {
    fields: [deployments.commitId],
    references: [commits.id],
  }),
}));

Commits model
import { integer, pgTable, serial, timestamp, varchar } from 'drizzle-orm/pg-core';
import { deployments } from './deployments';
import { InferModel, relations } from 'drizzle-orm';
import { users } from './users';

export const commits = pgTable('commits', {
  id: serial('id').primaryKey(),
  htmlUrl: varchar('html_url').notNull(),
  message: varchar('message').notNull(),
  sha: varchar('sha').notNull(),
  author: varchar('author').notNull(),
  userId: integer('user_id').references(() => users.id),
  branch: varchar('branch').notNull(),
  updatedAt: timestamp('updated_at').defaultNow().notNull(),
  createdAt: timestamp('created_at').defaultNow().notNull(),
});

export type Commit = InferModel<typeof commits>;

export const commitRelations = relations(commits, ({ many, one }) => ({
  deployments: many(deployments),
}));

Also seeing this! My first impression of Drizzle has been great overall but this feels like a showstopper.

Also seeing this! My first impression of Drizzle has been great overall but this feels like it might be a showstopper for my ability to migrate over.

Can you please confirm this is still an issue? if it is, a reproduction repo would be great!

@Angelelz thanks for responding, and sorry for the late response! This was user error, but I would love better error messages. I was using knex/Objection.js before this, which did not distinguish between timestamp in postgres and timestamp with time zone. I updated all my timestamps to use { withTimezone: true } and this problem went away.
@joris-gallot FYI it looks like this might be your issue as well!

Should be fixed in drizzle-orm@beta. I would appreciate some feedback to confirm whether this issue has been resolved in this tag.
I plan to release it in version 0.30.0 tomorrow or within the next few days; I simply aim to address this substantial set of issues we're encountering. I'll be duplicating this message across all similar issues we're facing.

Fixed in<EMAIL_ADDRESS>Please check release notes for more info


PauliSum/Lineardict missing some input checking

If you multiply a paulisum by another paulisum (which is not currently supported), lineardict allows the computation until it fails cryptically in LinearDict.clean.

Can you give an example to reproduce this issue @trevormccrt ?

I believe that PauliSum now supports multiplication so this is obsolete.
Example
a = cirq.NamedQubit('a')
p = (cirq.PauliString([cirq.X(a)]) + cirq.PauliString([cirq.Z(a)])) * (cirq.PauliString([cirq.X(b)]) + cirq.PauliString([cirq.Z(b)]))

returns a valid cirq.PauliSum


Included an stopping criteria test for KKT on LQR problem - [merged]

In GitLab by @cmastalli on Dec 3, 2018, 13:20
Merges topic/unittest -> devel
This PR includes a very simple unit-test for stopping criteria in LQR problem. Basically, we build and solve a KKT problem (computeKKTPoint https://gepgitlab.laas.fr/loco-3d/cddp/blob/topic/unittest/unittest/ddp.py#L184).
After that, we check that the gradient of the Lagrangian is equals zero.
Some extra comments:

The KKT problem is built by computing the Hessian of the problem, the Jacobian for the constraints (dynamics one) and cost function, and the constraint function. All these terms are computed by assuming an LQR problem, i.e. by using the quadratic approximation of the cost and the linear approximation of the dynamics. This routine is defined in buildKKTProblem (https://gepgitlab.laas.fr/loco-3d/cddp/blob/topic/unittest/unittest/ddp.py#L138).
The gradient of the Lagrangian computation assumes LQR problem, it doesn't work for nonlinear problems.

This proposes a solution for the #17.

In GitLab by @cmastalli on Dec 3, 2018, 13:23
merged

In GitLab by @cmastalli on Dec 3, 2018, 13:23
mentioned in commit 29307f825ecc8d10114cab1a7cee7f7898126e58


Add ability to disable sensitive data logging in restler (e.g. full network log)

Add the ability to disable logging in restler that could lead to leaked personal or sensitive information. I.e. request/response data sent to and received from the server.

To clarify further: this option was proposed for the use case where the user has a RESTler setup where --logsUploadRootDirPath is set, and wants to avoid storing raw network logs.  This primarily applies for cases where RESTler may not be filtering authentication information (e.g. if added in custom headers).
However, wouldn't any bug bucket contain a replay log with the sent request, which would contain the above data?

Yes, this work item sounds ill-defined. RESTler and the Swagger spec define request going in and the service under test defines what is contained in responses. The RESTler is already in full control of where to store (or keep) network logs. (And telemetry does not include any network traffic.) So what is this item about? Please clarify (possibly with a clear scenario or example). Otherwise, I suggest to close this item.

To clarify further: this option was proposed for the use case where the user has a RESTler setup where --logsUploadRootDirPath is set, and wants to avoid storing raw network logs. This primarily applies for cases where RESTler may not be filtering authentication information (e.g. if added in custom headers).
However, wouldn't any bug bucket contain a replay log with the sent request, which would contain the above data?

The replay log does indeed contain this data, however the creation of the log could be disabled while still performing the replay, if desired.

Closing this as out-of-scope for RESTler.  Such clean-up/log management can be done by the agent or user that invokes RESTler.


Release 1.1 does not start

When I run release 1.1 by double-clicking the .app file, OSX tells me I should move it to the trash. When I run release 1.1 by right-clicking and selecting Open, I get this crash report:
Process:               KnightTouchBar2000 [83572]
Path:                  /Volumes/VOLUME/*/KnightTouchBar2000.app/Contents/MacOS/KnightTouchBar2000
Identifier:            com.AnthonyDaMota.KnightTouchBar2000
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           KnightTouchBar2000 [83572]
User ID:               503

Date/Time:             2017-10-26 12:02:24.229 +0300
OS Version:            Mac OS X 10.12.6 (16G29)
Report Version:        12
Anonymous UUID:        B2C52937-7170-76D6-6A1F-118EC0AF5AC1

Sleep/Wake UUID:       F26CFE90-858F-482A-893E-28C722EC9230

Time Awake Since Boot: 510000 seconds
Time Since Wake:       4600 seconds

System Integrity Protection: enabled

Notes:                 Translocated Process

Crashed Thread:        0

Exception Type:        EXC_CRASH (Code Signature Invalid)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace CODESIGNING, Code 0x1

kernel messages:

VM Regions Near 0 (cr2):
-->
    __TEXT<PHONE_NUMBER>c9f000-0000000100ca7000 [   32K] r-x/rwx SM=COW   [w:5(]

Thread 0 Crashed:
0   ???                           	0x00000001033d0000 _dyld_start + 0

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000000000000  rbx: 0x0000000000000000  rcx: 0x0000000000000000  rdx: 0x0000000000000000
  rdi: 0x0000000000000000  rsi: 0x0000000000000000  rbp: 0x0000000000000000  rsp: 0x00007fff5ef60ae8
   r8: 0x0000000000000000   r9: 0x0000000000000000  r10: 0x0000000000000000  r11: 0x0000000000000000
  r12: 0x0000000000000000  r13: 0x0000000000000000  r14: 0x0000000000000000  r15: 0x0000000000000000
  rip: 0x00000001033d0000  rfl: 0x0000000000000200  cr2: 0x0000000000000000

Logical CPU:     0
Error Code:      0x00000000
Trap Number:     0

Binary Images:
       0x100c9f000 -        0x100ca6fff +??? (0) <9C9F24AF-E51B-344D-A06D-98215A9C4CAC> (null)
       0x1033cf000 -        0x10340cdc7 +??? (433.5) <322C06B7-8878-311D-888C-C8FD2CA96FF3> (null)

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 44895153
    thread_create: 0
    thread_set_state: 97

VM Region Summary:
ReadOnly portion of Libraries: Total=392K resident=0K(0%) swapped_out_or_unallocated=392K(100%)
Writable regions: Total=8400K written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=8400K(100%)

                                VIRTUAL   REGION
REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
STACK GUARD                       56.0M        2
Stack                             8192K        2
__DATA                             232K        4
__LINKEDIT                         112K        3
__TEXT                             280K        3
shared memory                        8K        3
===========                     =======  =======
TOTAL                             64.6M       11

Model: MacBookPro13,3, BootROM MBP133.0226.B25, 4 processors, Intel Core i7, 2,6 GHz, 16 GB, SMC 2.38f7
Graphics: Intel HD Graphics 530, Intel HD Graphics 530, Built-In
Graphics: Radeon Pro 450, AMD Radeon Pro 450, PCIe, 2048 MB
Memory Module: BANK 0/DIMM0, 8 GB, LPDDR3, 2133 MHz, 0x802C, 0x4D5435324C31473332443450472D30393320
Memory Module: BANK 1/DIMM0, 8 GB, LPDDR3, 2133 MHz, 0x802C, 0x4D5435324C31473332443450472D30393320
AirPort: spairport_wireless_card_type_airport_extreme (0x14E4, 0x15A), Broadcom BCM43xx 1.0 (<IP_ADDRESS>.1a1)
Bluetooth: Version 5.0.5f1, 3 services, 27 devices, 1 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
USB Device: USB 3.0 Bus
USB Device: USB2.0 Hub
USB Device: USB-C Digital AV Multiport Adapter
USB Device: iBridge
USB Device: USB3.0 Hub
Thunderbolt Bus: MacBook Pro, Apple Inc., 22.1
Thunderbolt Bus: MacBook Pro, Apple Inc., 22.1

Do you have XCode?

Yes :)

I'm also experiencing this issue. Not sure if it's related to High Sierra or not...

Can confirm on 2017 model @ 10.12.6

@AkdM unfortunately still doesn't work for me
`Process:               KnightTouchBar2000 [1799]
Path:                  /private/var/folders/*/KnightTouchBar2000.app/Contents/MacOS/KnightTouchBar2000
Identifier:            com.AnthonyDaMota.KnightTouchBar2000
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           KnightTouchBar2000 [1799]
User ID:               501
Date/Time:             2018-05-19 19:52:55.927 +0400
OS Version:            Mac OS X 10.13.4 (17E199)
Report Version:        12
Bridge OS Version:     3.0 (14Y664)
Anonymous UUID:        C04A4A46-9155-FD26-DB38-D9220F927B28
Sleep/Wake UUID:       010B69D6-2CA0-4544-AE20-B209193360FE
Time Awake Since Boot: 10000 seconds
Time Since Wake:       4300 seconds
System Integrity Protection: enabled
Notes:                 Translocated Process
Crashed Thread:        0
Exception Type:        EXC_CRASH (Code Signature Invalid)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY
Termination Reason:    Namespace CODESIGNING, Code 0x1
kernel messages:
VM Regions Near 0 (cr2):
-->
__TEXT<PHONE_NUMBER>852000-000000010085a000 [   32K] r-x/rwx SM=COW  P []
Thread 0 Crashed:
0   ???                           	0x00000001088c119c _dyld_start + 0
Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000  rbx: 0x0000000000000000  rcx: 0x0000000000000000  rdx: 0x0000000000000000
rdi: 0x0000000000000000  rsi: 0x0000000000000000  rbp: 0x0000000000000000  rsp: 0x00007ffeef3adad0
r8: 0x0000000000000000   r9: 0x0000000000000000  r10: 0x0000000000000000  r11: 0x0000000000000000
r12: 0x0000000000000000  r13: 0x0000000000000000  r14: 0x0000000000000000  r15: 0x0000000000000000
rip: 0x00000001088c119c  rfl: 0x0000000000000200  cr2: 0x0000000000000000
Logical CPU:     0
Error Code:      0x00000000
Trap Number:     0
Binary Images:
0x100852000 -        0x100859fff +??? (0) <247B3159-36C6-3833-83BC-D5621A8DBD8C> (null)
0x1088c0000 -        0x10890a9df +??? (551.3)  (null)
External Modification Summary:
Calls made by other processes targeting this process:
task_for_pid: 0
thread_create: 0
thread_set_state: 0
Calls made by this process:
task_for_pid: 0
thread_create: 0
thread_set_state: 0
Calls made by all processes on this machine:
task_for_pid: 6168
thread_create: 0
thread_set_state: 0
VM Region Summary:
ReadOnly portion of Libraries: Total=464K resident=0K(0%) swapped_out_or_unallocated=464K(100%)
Writable regions: Total=8404K written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=8404K(100%)
                            VIRTUAL   REGION

REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
STACK GUARD                       56.0M        2
Stack                             8192K        2
__DATA                             236K        4
__LINKEDIT                         132K        3
__TEXT                             332K        3
shared memory                        8K        3
===========                     =======  =======
TOTAL                             64.7M       11
`

Hi, sorry for the dupe... I thought I'd checked the other threads! Keep up the great work!

I just released version 1.1.1.
Can you confirm it works now?
Thanks and sorry for the issue!

not working

Thanks, I'll check it!
On Sun, Mar 31, 2019 at 11:56 AM Skyhill53<EMAIL_ADDRESS>wrote:

I just released version 1.1.1.
Can you confirm it works now?
Thanks and sorry for the issue!
not working
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AkdM/KnightTouchBar2000/issues/7#issuecomment-478327637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQPUuFuv_Ed_PVq-OXngV81z45RBQ7i9ks5vcIZXgaJpZM4QHO3w
.

Hi! V1.1.1 still not working for me with the warning dialogue when I try to open the .app saying "You should move this to the Trash" and no option to do anything else. Clicking the '?' opens Mac Help: "There may be a problem with this app. Although the app was signed by an identified developer, the certificate for the app has been revoked, and it cannot be opened."


Output reflects srcDir structure

Hi, first of all, great plugin!
Is it possible to generate the css files that reflects the directory structure of srcDir?
e.g. assuming srcDir = '/src' and outDir = '/dst'
/src/app.scss and /src/foo/bar.scss
would generate respectively
/dst/app.css and /dst/foo/bar.css
Regards.

Hi,
thank you. It certainly should be possible to improve implementation in the way you've described.
I'm going to implement it.
With regards,
Miro

It's fixed and the new version has been deployed to plugins.gradle.org.
See example: https://github.com/kravemir/GradleSassPlugin/tree/cba1e05e77682575428e8ab4d68816faee90eac2/examples/01-HelloSass

Thank you.

You're welcome. I'm glad you like the plugin. The feature you wanted is useful, worth implementing.

Hi Miroslav,
Thank you again for the enhancement.
Another enhancement you may wish to consider is to produce both the
minified, and non-minified css files at the same time,
so that dev can switch to the non-minified version for debugging.
I actually ended up implementing the plugin locally.  In addition to
maintaining the directory structure (which you have implemented),
and outputting both minified and non-minified versions,
I also use the gradle IncrementalTaskInputs facility so that when a scss
source is deleted, the target css is also deleted during build.
-cs
On 9/5/2016 2:23 PM, Miroslav Kravec wrote:

You're welcome. I'm glad you like the plugin. The feature you wanted
is useful, worth implementing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kravemir/GradleSassPlugin/issues/1#issuecomment-244795830,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEHzhpm4N48OjArOTG4G815BCUKF4wr_ks5qnF41gaJpZM4Jw8Y2.

@ctzen I have not yet needed this in my hobby projects, in which I use the plugin. However, in sounds to be useful when these projects are going to be production(publishing) ready.
You may open a pull request, if you would like to contribute. If not, then I will implement them on my own, some time later.


mime: ExtensionsByType is non-deterministic for image/jpeg

What version of Go are you using (go version)?

$ go version
go version go1.14.3 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="${HOME}/Library/Caches/go-build"
GOENV="${HOME}/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY="${PRIVATE_REPO}"
GONOSUMDB="${PRIVATE_REPO}"
GOOS="darwin"
GOPATH="${HOME}/go"
GOPRIVATE="${PRIVATE_REPO}"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/8p/p5rdrmpd5n1gwqv8c6dxb0hc0000gn/T/go-build696615722=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I ran the following code:
https://play.golang.org/p/oVTZQTyxzS_q
The relevant bit is here:
exts, _ := mime.ExtensionsByType("image/jpeg")

What did you expect to see?
I expected to see a consistent result. One of the following would have worked, so long as it were deterministic:

[.jpg]
[.jpeg]
[.jpg .jpeg]
[.jpeg .jpg]

What did you see instead?
I saw either [.jpg] or [.jpeg], which changed as I re-ran the program.
Perhaps these extensions are completely interchangeable, but I think they should be deterministic. This affects e.g. unit tests which rely on ExtensionsByType somewhere in the code path.
(Personally, I prefer .jpg over .jpeg.)

FYI, it seems similar to issue #36524 mime: wrong extensions list for content type "image/jpeg" when using built-in types.
A fix was merged back in Feb 25, but seems like it didn't find its way in the initial Go 1.14.3 tag.
I don't know if it was backported in a later stage.
Could you try re-running your example with the latest version of Go, maybe using gotip? It seems to be working correctly for me.

Yes, this should be fixed in the upcoming 1.15 release.  Sorry for the difficulties.


how can i export the maps

it works
but how can export the created mindmaps
is there any shortcut to copy it t?

Duplicate of https://github.com/dundalek/atom-markdown-mindmap/issues/5, it is now implemented.


Added ExperienceOrb and Item implementation

Added Multi-world support
Added Entities list in World

I think that the Dimension method shouldn't be used for the over world/nether. It gives the false impressions of the boundaries in my own opinion.

Mhmm, what do you suggest?

@TheLightMC Minecraft's term for Overworld/Nether/The End is "Dimension", so it should be used.
Bounds should instead be represented by a "WorldSize", "WorldBounds" or "Bounds".

I suggest leaving Dimension, it's the term Minecraft uses internally to describe predetermined worlds OVERWORLD/NETHER/END
It has connotations of Generation as well.

In that case I agree that we should remain with Dimension @WeeSkilz . My bad @j0ach1mmall3.


Question - Is it possible to get this running on a Pi running picoreplayer only

Hi,
Firstly, this is a fantastic program, even I managed to managed to get it running on a pi running volumio, and also managed to make some changes to get what I wanted until I killed something and it stopped working, so going to have to a fresh install.
Anyway, back to the question, I run a LMS server on one Pi, and then have picoreplayer on a second pi which has an official touch screen. I want to add a LCD screen to the pi running picoreplayer, to display system info and music data (bitrate etc). Is there any way of getting pydpiper running on picoreplayer?  If it is possible, is there any guidance anywhere?
Thanks

It should be possible.  The challenge is to either get Docker installed or alternatively to get all of pydPiper's dependencies installed.
I don't have time at the moment but I'll add this as something to look into.

Many thanks, would be brilliant if you could work your magic and get it working.

Following on from above, is there a list of dependencies anywhere, as happy to have a play and see if I can get it working outside of docker.

Hi dhrone,
I have been having a play with max2play and have managed to update the 'musicdata_lms.py' file so that samplerate and bitdepth (bitdepth only works on FLACs / files greater than 320kbps) can be displayed. I have included the lines below, as thought you could add it to the hosted file. The lines are added at line 284. Also added my modified file.
musicdata_lms.py.txt
try:
self.musicdata[u'samplerate'] = urllib.unquote(str(self.dataplayer.request("songinfo 2 1 url:"+url+" tags:T", True))).decode(u'utf-8').split(u"samplerate:", 1)[1]
except:
self.musicdata[u'samplerate'] = u""
try:
self.musicdata[u'bitdepth'] = urllib.unquote(str(self.dataplayer.request("songinfo 2 1 url:"+url+" tags:I", True))).decode(u'utf-8').split(u"samplesize:", 1)[1]
except:
self.musicdata[u'bitdepth'] = u""
I also commented out the bitdepth and samplerate lines under UNSUPPORTED VARIABLES.
This leads on to a quick question. The sample rate is coming out as a full number, e.g. 44100 (Hz), but I would prefer this to be in kHz. Is there a way to easily divide this number by 1000 to get the kHz value i.e. 44.1 (kHz)? I have tried various ways, but my lack of knowledge is not helping.
Thanks again.


[QT wallet] Font size for the help message is very large

Description:
In QT wallet Windows platform, observed Font size for the help message is very large on the page - Contacts, Accounts.
Please refer the below screenshot for more details.

The issue exist under the windows is Windows Screen scale is 200%  (it is default value for the high definition display).
The BrowserText control doesn't handle that. I am trying to change the control, will see if it helps

I tested under the Windows and MacOS. Now it looks the same. Font size now is QT standard (it is not flexible any more) but now it handles retina displays.
Also please check if Linux will look fine as well

Tested with MacOs and now Font in Help windows looks good, hence closing this ticket.


link request "required" at LDO level overrides "schema" level

We would copy "required" from the LDO level into the parameters object (even if it was undefined), instead of just using the one in "schema".
Posted a PR before filing the issue: cloudflare/json-schema-example-loader#5
@Relequestual (or anyone) were you relying on this?  We will bump the version number before publishing this, but I might have some other fixes before then.

We are relying on this, yes, but I agree that it doesn't really make sense. Also I found a mistake in our generation code =/
Anyway. It makes sense to use the one found in the LOD schema. Is required even valid at the LOD level (draft-4+)? Doesn't look like it.

Is required even valid at the LDO level (draft-4+)? Doesn't look like it.

Nope.  There are a couple of things in json-schema-example-loader that are against the spec, and I'm prioritizing fixing those ASAP.  This, the treatment of "additionalProperties", and the nonstandard "rel": "self" in place of "$ref": "#" inside of "schema" and "targetSchema" are the main ones.
Other than that there are things we don't support, but we just ignore them so they are less critical.

This is merged and will be fixed in the next release of json-schema-example-loader.  I've marked it as needing a release note when we roll the version.  There are several more changes that I want to get all in one release before that happens (basically the ones mentioned in the previous comment).


7.10.1 release

This PR bump chart version and Docker images to test 7.10.1.
See New branching model for more details.

jenkins test this please


Using git tags when releasing new versions

Hi,
it would be nice if you could use git tag to the corresponding tag when you release a new version, e.g.:
git tag -a -m "Tagging version 3.1.0.' v3.1.0
git push --tags
This would make following/tracking updates on jsuites so much easier.
Regards,
Daniel

We have improved this practise. But, if you are looking on specific version, you can look on NPM where it is better tracked.

Hi,
I'm not sure I understand - are you saying you're going to push tags in git (there are none yet).
Regards,
Daniel

It's there now, thank you!


I ran into this error while trying to run the provided sample app

Can you tell me where is my mistake?

Hi @skripsimu
Fixed. You can try it now

btw, you should use version: 0.0.2
dependencies:
    infobip_mobilemessaging: '^0.0.2'


Update to new App Store Receipt Signing Certificate before January 24, 2025

Context

Starting January 24, 2025, if your app performs on-device receipt validation and doesn't support a SHA-256 algorithm, your app will fail to validate the receipt.

https://developer.apple.com/news/?id=b6tejt6f
Expectation
I could be wrong as I am not an expert, but from what I've seen in the codebase, TPInAppReceipt currently uses the SHA-1 hash to validate the receipt. https://github.com/search?q=repo%3Atikhop%2FTPInAppReceipt SHA-&type=code
We would need to update the code to use SHA-256 to validate the receipt.

Hi @StevenMasini, thanks for bringing this up.
If I remember correctly, this has been discussed here.
In short, there is no change, as I understood in this part of verification and it only affects verification of the certificate chain of trust.
Thank you!


Provide support for contextDir in the s2i strategy

Idea:
This is coming from this comment, where when modifying the following build sample we realized that the usage of spec.source.contextDir is not supported in the source-to-image strategy.
@adambkaplan fyi

/assign @adambkaplan

We are going to try and cut the v0.4.0 milestone this week.  With @adambkaplan being on PTO this won't be getting done in time for that, so I've moved it to v0.5.0


Moving page from one document to another

Can we simply move page from one document to another without copying. As currently it gives Page is from foreign document error. Is there a way to simply move a page from one document to another at a specific index without copying? As i don't want original document to be maintained?

Yes. I've provided examples in several other issues showing how to do this. If it's not working for you, please fill out the new bug report form.

@Hopding can you please point me where you have given an example?


[Revision History] Move to end of document

Signed-off-by: Rob Dolin<EMAIL_ADDRESS>

Please merge #928 first to minimize conflict.

Hmm, I would expect to merge this before #928, because #928 contains the changes from this PR without mentioning them?

Closing this one since it is covered by #928


Export DataTree to csv through showSaveDialog

Webviews run in isolated contexts that cannot access local resources. Because of this webviews could an issue with opening hyperlinks.

Suggested fix is to use showSaveDialog from vscode api
Users can choose file name/path
Show success/error message after
Depends on signal added in https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/938

Fixes #66

@hriday-panchasara, should this PR be set to Draft for you to rework, given its failing CI build herein?

@hriday-panchasara, should this PR be set to Draft for you to rework, given its failing CI build herein?

Yup, keeping it as draft until its dependency (https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/938) gets reviewed


Added definition for putability / rearranged

Category

[x] Content fix
[ ] New article

Related issues

fixes #465

Docs Build status updates of commit eebc314:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Community/glossary.md
:bulb:Suggestion
View
Details

CHANGELOG.md
:white_check_mark:Succeeded

Community/microsoft365-maturity-model--management-of-content.md
:white_check_mark:Succeeded
View

Community/glossary.md

Line 201, Column 34: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/sharepoint/organization-news-site' will be broken in isolated environments. Replace with a relative link.
Line 203, Column 127: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/SharePoint/home-site' will be broken in isolated environments. Replace with a relative link.
Line 339, Column 1: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows-server/administration/windows-commands/powershell' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel