Support a "getCombinedCodeFix" service

Fixes #14549
Does not fix #20315
Each code fix may come with a groupId object. This groupId may then be passed to a getCombinedCodeFix services method which generates a code action combining all code fixes in that group.
This would be a good time to consider changes to the API, such as if we want fixes to be able to have multiple groupIds or if we want to give groupIds a human-readable description too.
Also, we might want to design the signature of getCombinedCodeFix to allow for other possible scopes in the future; such as taking { type: "file", fileName: "..." } instead of just a filename directly.
For the implementation: For the most part, services could be written so that their main body is a function taking a changeTracker, and we can then iterate over every error in the file and apply changes to the tracker. Some were more difficult due to creating strings directly instead of nodes (via checker.typeToString) -- it would probably be better to use checker.typeToTypeNode instead?

We've had some problems in the past when we've tried to make multiple changes to the same range in a single ChangeTracker.  Do we have some reason to believe that won't occur when combining code fixes?

We've had some problems in the past when we've tried to make multiple changes to the same range in a single ChangeTracker. Do we have some reason to believe that won't occur when combining code fixes?

We know that ChangeTracker can't handle all possible sequences of changes because some would be nonsensical -- so it's a codefix's responsibility to ensure it's doing the possible and not e.g. making any changes twice (see the many addToSeen calls).
Since ChangeTracker already has the responsibility of making multiple changes, I think it's best to make all changes through there and make improvements to ChangeTracker if any problems come up. (
There was one problem that came up when deleting the last and next-to-last items in a list, fixed in this PR.) That should be easier than trying to combine raw text changes.

I don't want to bikeshed on naming, but it seems strange that a CodeFix is a CodeAction with an (optional) actionId.  If the ID is for the action, why isn't it on the action?  Maybe a CodeFixAction is a CodeAction with a fixId?  @mhegazy?

I'm not quite clear on the difference between a CombinedCodeAction and a CodeActionAll.  Do we just use different names in different layers?

I'm not quite clear on the difference between a CombinedCodeAction and a CodeActionAll. Do we just use different names in different layers?
Yeah, that was an incomplete renaming.

I don't want to bikeshed on naming, but it seems strange that a CodeFix is a CodeAction with an (optional) actionId. If the ID is for the action, why isn't it on the action? Maybe a CodeFixAction is a CodeAction with a fixId? @mhegazy?

seems reasonable. no better ideas for name though.. maybe just CodeAction & { fixId }

Is this based on Roslyn's implementation? Using theirs as a model might help us avoid making the same mistakes.

We have based most new APIs on Roslyn's if they exist. what does the Roslyn API look like here?

@mhegazy I believe this is the corresponding Roslyn code:
http://source.roslyn.io/#Microsoft.CodeAnalysis.EditorFeatures/Implementation/Suggestions/FixAll/FixAllGetFixesService.cs,20
This is the extra ID I was thinking of:
http://source.roslyn.io/#Microsoft.CodeAnalysis.Workspaces/CodeActions/CodeAction.cs,48

This is the extra ID I was thinking of:
http://source.roslyn.io/#Microsoft.CodeAnalysis.Workspaces/CodeActions/CodeAction.cs,48

so we should generate that from all the inputs to the codefix to make sure they are unique?

@mhegazy I think it's more or less equivalent to what we're calling action/fix ID and we have the option of incorporating the code in the future if that turns out to be interesting.

Does VS offer all levels of repetition for all code fixes or do code fixes somehow indicate that they can be repeated?  If they indicate that they can be repeated, do they somehow indicate which choices would be sensible?  (e.g. don't offer 'project' if all occurrences are in 'file')

Roslyn appears to offer all scopes when repetition is offered, but not always offer repetition (e.g. add missing member).

@amcasey @mhegazy I've made the API changes internal for now (and marked with #20538). I'd like to get this PR in soon since it touches a lot of files.

@andy-ms Do we have a way to signal that some code fixes can't be repeated?  Or, at least, can we add that later without affecting back-compat?  Otherwise, LGTM.

I think we can do that by just not supplying a fixId.

Can you please add a comment to that effect on the declaration?  I'm worried that future implementers (i.e. me) might forget that that's an option and try to add a flag.


Add a corpus structure editor

This PR is based on the #13 pull requests and includes all its current changes. If #13 is merged to develop, it should be easier to see what files have been changed in this PR.
It adds a corpus structure editor user interface and some minimal project management code in the core bundle to open an existing Salt project and notify the corpus structure editor when changes to the structure are made. This central handling is necessary to later implement an undo-functionality. The project manager currently only reads the corpus structure, not the actual SDocumentGraphs and should be easy to adapt to further extensions for handling the document graphs and other project based related things (like storing the whole project or single documents).
To ease debugging, a logging bundle org.corpus_tools.hexatomic.logging was added, too.
Logging capability was added to the org.corpus_tools.hexatomic.core bundle.
This is based on SL4FJ and Logback: other bundles only need to use the SL4FJ interfaces and don't need to depend on this bundle at all.

Two major points:
* Logging with Logback is non-functional

This should be fixed now.

* No tests. Think it'd be good to stick to good practice from early on and include unit tests where they make sense.

The Controller-style classes that could be tested without GUI tests are currently still quite simple. Also, I'm not sure if adding test execution and a test framework is in scope of this already bloated PR.


Update k8s.io/ja/docs/setup/pick-right-solution/

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
Outdated content content/ja/docs/setup/pick-right-solution.md.
content/en/docs/setup/pick-right-solution.md 65 insertion(+), 12 delettion(-)

Proposed Solution:
Update content content/ja/docs/setup/pick-right-solution.md.
For details, please execute the following command.
git diff 551489f 7b07d19 -- content/en/docs/setup/pick-right-solution.md

Page to Update:
https://kubernetes.io/ja/docs/setup/pick-right-solution/

これやります。

/close


[bugs] some issues i found

not sure if its just temp or not working, but the screen on the toolgun is not there, and in third person the toolgun is like 90 degrees right, trails still follow it funnily enough.
in the dynplates menu if you do not press enter, you are locked in the spawn screen till you do.
undo seems to not work, if that's not in yet then maybe that's why.

The toolgun fixes #6 were merged last night, and I thought I published a new build on asset.party but I was having some trouble with the recompiling step (seems to have some s&box bugs...) so maybe the published one is missing that somehow...
That Dynplates menu is definitely pretty rough UX - it is intentional that the spawnmenu stays open when you let go of Q while in a textfield in the menu, I believe Gmod had this same behaviour - but if thats not what you're observing, it might be a regression.
I don't fully understand how keybinds/Actions work in the current APIs, but I've consistently had Undo working fine since I added it to S+ last week - do you perhaps need to bind Undo in the Settings page when starting a server?

its probably the last part, but no such issues than that so far, very cool work
the dynplates i ment like if you dont press enter, it will lock you in the spawn menu entirely, till you go back to that page, then press enter
there currently isnt a way to bind it from the ingame settings menu, but the undo works by making a console command bind.

i found another weird bug, if you undo a welded wire entity it insta crashes

Fixed Undo not having a keybind!
I'm not able to reproduce that crash, can you be more specific about what you did?

basically this, i think i did say it pretty weird.
https://github.com/Nebual/sandbox-plus/assets/12705993/ffc70621-3c99-482c-8108-f897bfded593

Honestly it's probably worth closing this, as things have changed a lot since. We should reopen if replicable in new code.

not a prob, makes sense lol


Add instructions for Ubuntu 18.10 Cosmic Cuttlefish

Release schedule
Release date: October 18th, 2018

Need to update screenshots as there is a new default theme.

https://nuvola.tiliado.eu/nuvola/ubuntu/cosmic/


Release 4.6.0

Added

Support importing time series currency (e.g. USD, EUR, etc.) and other units
Support deleting time series points with known time specified
Support for replacing existing time series points when importing
Added dedicated Snowflake reader for faster data export
Support for Feather file format for faster data export and import
Support for using CUSIP as company identifier
Scripts for deleting time series and time series points

Changed

Improved scripts for listing and deleting entites with progress tracking
Improved script for deleting entities with multithreading
Including known_time info when using script for getting time series

Deprecated

The argument --create-tag for importing time series is ignored, as the tags are no longer supported.

Removed
Fixed

Fixed when setting project argument different than credentials project for BigQuery export

This change is


Markup panel resizing

Resizing the details pane wacks out the entire panel formatting.

Review the TextArea for the description field.  See how that box pushed the panel underneath.

Fixed


Fix search paginator gap

Fixes #334
Describe the changes you have made in this pr -
Fix gap in search_paginate_renderer.rb
Screenshots of the changes (If any) -

looks good can merge it 👍

@satu0king Is there something left to be done in this pr? The search seems to down on the website for some time.


Develop Lua Async System

For calling functions which runs on a thread, getting a callback to lua is going to be a bit hard.
So need to develop a good solution to making sure the async call can be called back properly.
Previous solution does not work since it's often crashes the game.
Current idea is to uses the coroutine system already implemented in Wicked Engine, hope this works well.

Completed, with universal system across async tasks all over the game between C++ code and Lua scripts!


Click on Icon does not work

I tried to click on an icon but the click event is not happening:
Icon removeIcon = _get(Icon.class, s -> s.withId("club-contest-discipline-registration-details-remove-2-2"));
_click(removeIcon);

What's the correct way to click on an icon?

That is the correct way to click an icon. Let me check please.

The tests pass - if you have added the listeners via icon.addClickListener() then _click() should fire them properly.

In that case I think I see the problem.
I had to register the listener like this:
 removeIcon.getElement()
      .addEventListener("click", e -> removeListener.accept(disciplineRegistration))
      .addEventData("event.stopPropagation()");

Because I must stop the event propagation as the icon is in the summary of the details component.
This issue is still open: https://github.com/vaadin/flow/issues/1363
In that case there is no way that my click listener will receive the even?

You're right, good catch! That's a DOM event listener which needs to be fired a bit differently: https://github.com/mvysny/karibu-testing/tree/master/karibu-testing-v10#firing-dom-events
However, I agree that the current behavior is confusing. Either:

_click() fires the DOM event listener as well, along with the higher-level .addClickListener(), OR
_click() should contain a huge warning that it doesn't fire the DOM click event.

I'm leaning towards the 1. but we need to test this thoroughly, to prevent double-firing of the higher-level click listener. What do you think @simasch  ?

would be great!

Implemented :+1:  Meanwhile you can fire the DOM click event manually, via https://github.com/mvysny/karibu-testing/tree/master/karibu-testing-v10#firing-dom-events

Implemented in 9c64e80411362d65e54a12ac2d00b39dfb158ba7 , KT 2.0.3/1.3.25

Great. Thanks @mvysny


SMTP Error: Client network socket disconnected before secure TLS connection was established

Trying to setup Email SMTP notification but keep getting this error when testing.
I've used the same setting for other services and they work fine.
Tried playing around with the settings and changing ports and what not. Nothing works.

Can't find related issues.
I suggest you could check/uncheck the "Secure".
https://github.com/louislam/uptime-kuma/issues/140#issuecomment-890712067

Yes i've tried that setting, nothing works.

Found a possible reason, the smtp's TLS probably too old and Node.js no longer supports it.
https://github.com/nodejs/node/issues/21088#issuecomment-486149589
If you installed the Uptime Kuma via Docker, I built-in Apprise, which also supports SMTP and it is based on Pyhton, it maybe works:
https://github.com/caronc/apprise/wiki/Notify_email

Thanks! I'll give Apprise a try.


Add Sprig ternary function

The ternary function was added to Sprig 2.15.0 and is supported by Helm >= 2.10.0.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: amirschw sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Looks good to me, just looping in a couple of the Helm folks for approval.  Thanks!


Possible wrong pagination urls on index page

Hi, I found a possible error in the URL addresses of the Newer posts and Older posts buttons on the index page. Are the addresses correct? Details in pull request #86 .

Yes, they are correct.

The sources have changed to the correct endpoint (see main/routes.py#L41), you may close this issue and related PR.


Fixing Build and updating dev dependencies

Updating dev dependencies and unit tests, as well as fixing build settings to avoid warnings/errors.
I checked that this works in my own travis build as well: https://travis-ci.org/mportuga/angular-gridster/builds

Thank you!


Fix for for issue 16182 - std.traits.fullyQualifiedName Bug

https://issues.dlang.org/show_bug.cgi?id=16182
It is beyond my comprension as to why this irrelevant change helps
fixes #16182. I believe there is something amiss becuase expression
fqnSym!(__traits(parent, T)) ~ '.' is returning a char[] while
fqnSym!(__traits(parent, T)) ~ "." returns a string. This while
expression fqnSym!(__traits(parent, T)) returns a string.

You should rename your PR fix Issue 16182 - std.traits.fullyQualifiedName Bug
You should amend your commit and change the message to fix issue 16182 - ...

The sharp is not recognized by the dlang-bot. If you don't do so, the issue in the bug tracker cannot be closed automatically. Parts of the changelog are also generated using the commit (or the PR ?) message.

thx !

add a unittest that shows that the PR fixes the issue plz. dont forget to add a comment // bugzilla 16182  at the right of the unittest keyword.

You must either amend (without change will work, a new SHA will be generated) or rebase the commit to relaunch Travis CI tester, there has been a case of misfortune here.

@BBasile I reset it

This seems to have been caused by a regression in the compiler.
I think this should not be pulled and the compiler code be fixed instead.

When 2.072 will show the tip of his nose and if https://issues.dlang.org/show_bug.cgi?id=16183 is not fixed then it still will be time to take this library solution.

We can just push it. It is faster then track this PR

Auto-merge toggled on


CORE-8625 Update JPA backing store entities to follow best practice

Summary
The JPA backing store entities, which abstract access to the uniqueness DB, have been updated to follow engineering guidance defined here. These comprise:

Using "plain" instead of data classes for JPA entities
Marking all JPA entity classes as internal, and moving into the package where they are used accordingly
Add additional unit tests to check for equality consistency

Testing
Ensured all existing unit, integration and smoke tests pass. New unit tests added to check for equality consistency.

Looks like have a compilation issue on the failing CI there @relyafi
[2023-02-28T18:02:37.515Z] e: file:///var/jenkins/workspace/Corda5_corda-runtime-os_PR-3270/components/uniqueness/backing-store-impl/src/backingStoreBenchmark/kotlin/net/corda/uniqueness/backingstore/impl/JPABackingStoreImplBenchmark.kt:114:13 Cannot access 'JPABackingStoreEntities': it is internal in 'net.corda.uniqueness.backingstore.impl'

[2023-02-28T18:02:37.515Z] e: file:///var/jenkins/workspace/Corda5_corda-runtime-os_PR-3270/components/uniqueness/backing-store-impl/src/backingStoreBenchmark/kotlin/net/corda/uniqueness/backingstore/impl/JPABackingStoreImplBenchmark.kt:114:37 Cannot access 'JPABackingStoreEntities': it is internal in 'net.corda.uniqueness.backingstore.impl'

Looks like you have a compilation issue on the failing CI there @relyafi
[2023-02-28T18:02:37.515Z] e: file:///var/jenkins/workspace/Corda5_corda-runtime-os_PR-3270/components/uniqueness/backing-store-impl/src/backingStoreBenchmark/kotlin/net/corda/uniqueness/backingstore/impl/JPABackingStoreImplBenchmark.kt:114:13 Cannot access 'JPABackingStoreEntities': it is internal in 'net.corda.uniqueness.backingstore.impl'

[2023-02-28T18:02:37.515Z] e: file:///var/jenkins/workspace/Corda5_corda-runtime-os_PR-3270/components/uniqueness/backing-store-impl/src/backingStoreBenchmark/kotlin/net/corda/uniqueness/backingstore/impl/JPABackingStoreImplBenchmark.kt:114:37 Cannot access 'JPABackingStoreEntities': it is internal in 'net.corda.uniqueness.backingstore.impl'

Thanks @ronanbrowne - yes I'm looking at resolving this now


Remove component struct

Struct that doesn't serve any purpose: unnecessary gas costs incurred during rebalance,issue,redeem

Pull Request Test Coverage Report for Build 2636

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2632:
0.0%

Covered Lines:
558

Relevant Lines:
558

💛  - Coveralls


SWCLK pullup footprint isn't accessible

Whoops, issue was observed with the first spin of these boards, the version in the repo already has this fixed...


note about imported as Sprites

I see there is note about the images in the spriter project:
IMPORTANT: Make sure that all the images referenced in the .scml are imported as Sprites.
But I don't remember this was necessary on my previous test with SpriterDotNet.Unity
I see in the demo package this is fine, all the images are aprites, but even when I make this change to every image it doesn’t work on my current test. I have to make it BEFORE I import the spriter project.
Do you use any script to convert the images to sprites on the import step on the fly? I doesn’t seem to work now. I think I see this set on the previous version I test, but I'm not sure.
This will be a new part of the work flow ?

It was always necessary since the importer tries to load Sprites. I just added the notice later.
If you change the images to the Sprite type you should reimport all .scmls that reference those sprites.
Changing the type of referenced images while loading the .scml is a good idea - I'll investigate if that's possible in Unity. If you know how can it be done feel free to submit a PR.


Java WinAppDriver: Application does not have NativeWindowHandle property, how to attach using process name?

Hi,
I am using WinAppDriver release 1.2 on a Classic Windows application using Java.  Since my Windows application has a splash screen, I wanted to add the Attach to existing Window functionality so I could start building my test scripts on the attached window more rapidly.
Here is the application login window details on using inspect.exe
How found:	Mouse move (813,120)
	hwnd=**0x000000000023187E** 32bit class="#32770" style=0xFFFFFFFF94C008C4 ex=0x10101
ControlType:	UIA_TitleBarControlTypeId (0xC375)
LocalizedControlType:	"title bar"
BoundingRectangle:	{l:661 t:108 r:1249 b:143}
IsEnabled:	true
IsOffscreen:	false
IsKeyboardFocusable:	true
HasKeyboardFocus:	false
ProcessId:	32356
RuntimeId:	[2A.23187E.3.80000001.23187E.FFFFFFFE.0]
AutomationId:	"TitleBar"
IsContentElement:	false
ProviderDescription:	"[pid:43300,providerId:0x0 Annotation:Microsoft: Annotation Proxy (unmanaged:uiautomationcore.dll); Main(parent link):Microsoft: MSAA Proxy (unmanaged:uiautomationcore.dll)]"
IsPassword:	false
IsDialog:	[Not supported]
LegacyIAccessible.ChildId:	0
LegacyIAccessible.Description:	"Displays the name of the window and contains controls to manipulate it"
LegacyIAccessible.Role:	title bar (0x1)
LegacyIAccessible.State:	focusable (0x100000)
LegacyIAccessible.Value:	"Flight Explorer logon"
Value.IsReadOnly:	false
Value.Value:	"Flight Explorer logon"
IsAnnotationPatternAvailable:	false
IsDragPatternAvailable:	false
IsDockPatternAvailable:	false
IsDropTargetPatternAvailable:	false
IsExpandCollapsePatternAvailable:	false
IsGridItemPatternAvailable:	false
IsGridPatternAvailable:	false
IsInvokePatternAvailable:	false
IsItemContainerPatternAvailable:	false
IsLegacyIAccessiblePatternAvailable:	true
IsMultipleViewPatternAvailable:	false
IsObjectModelPatternAvailable:	false
IsRangeValuePatternAvailable:	false
IsScrollItemPatternAvailable:	false
IsScrollPatternAvailable:	false
IsSelectionItemPatternAvailable:	false
IsSelectionPatternAvailable:	false
IsSpreadsheetItemPatternAvailable:	false
IsSpreadsheetPatternAvailable:	false
IsStylesPatternAvailable:	false
IsSynchronizedInputPatternAvailable:	false
IsTableItemPatternAvailable:	false
IsTablePatternAvailable:	false
IsTextChildPatternAvailable:	false
IsTextEditPatternAvailable:	false
IsTextPatternAvailable:	false
IsTextPattern2Available:	false
IsTogglePatternAvailable:	false
IsTransformPatternAvailable:	false
IsTransform2PatternAvailable:	false
IsValuePatternAvailable:	true
IsVirtualizedItemPatternAvailable:	false
IsWindowPatternAvailable:	false
IsCustomNavigationPatternAvailable:	false
IsSelectionPattern2Available:	false
FirstChild:	[null]
LastChild:	[null]
Next:	[null]
Previous:	"" document
Other Props:	Object has no additional properties
Children:	Container has no children
Ancestors:	"Flight Explorer logon" dialog
	"Desktop 1" pane
	[ No Parent ]

My problem is this with the code I am writing below to attach to this:
DesiredCapabilities desktopCapabilities = new DesiredCapabilities();
desktopCapabilities.setCapability("platformName", "Windows");
desktopCapabilities.setCapability("app", "Root");
desktopCapabilities.setCapability("deviceName", "WindowsPC");
desktopCapabilities.setCapability("ms:experimental-webdriver", true);
WindowsDriver<WindowsElement> windowsDriver = new WindowsDriver<WindowsElement>(new URL("http://<IP_ADDRESS>:4723"), desktopCapabilities);
WebElement appWindow = windowsDriver.findElementByXPath("//Window[@Name='logon'][@ClassName='#32770']/TitleBar[@AutomationId='TitleBar']");
String appWindowHandle = appWindow.getAttribute("NativeWindowHandle");

Since the inspect does not have NativeWindowHandle, I am getting the value of this as 0.  Hence, this does not allow me to attach to my application.  This is the header of that Window, so if I try to use some other Windows Element in that login page, even though it provides some Native Window Handle, it is not the top level window, and hence the converted Hex based Window Handle does not work out for any other element when used instead of the Title Bar element.
However, I tried one thing, I directly copied the hwnd from inspect output above - 0x000000000023187E, and used that hardcoded hwnd to attach.  Then it worked fine:
DesiredCapabilities capabilities = new DesiredCapabilities();
capabilities.setCapability("deviceName", "WindowsPC");
capabilities.setCapability("appTopLevelWindow", "**0x000000000023187E**");
windowsDriver = new WindowsDriver<WindowsElement>(new URL("http://<IP_ADDRESS>:4723"), capabilities);
windowsDriver.findElement(By.name("Connect")).click();

But I am not able to figure out how I can get the value of this hwnd property since NativeWindowHandle of my top level window is not defined in inspect, and always returns a 0 when accessed through code.
Other thing I noted in inspect.exe is "ProcessId".  I noted that "ProcessId" property is the same for all inspected elements, so I thought there must be some way to figure out the window handle from process id in Java.  But I am unable to find one.
Have the following questions:

Is there a way to access hwnd property through Java for my element (as shown in the How Found section of inspect.exe), and use that to attach each time my test runs?
If the above is not possible, is there a way in Java that I could use the ProcessId I grabbed from inspect using getAttribute, and then reverse look up the Window Handle or hwnd based on fetched ProcessId?
Any other way you could recommend for attaching when the top level window does not have a NativeWindowHandle property in inspect?

Anything which works should help.
Any help would be greatly appreciated on this.  Please let me know if there is any information needed from my side.
Thanks,
Anukul

Check #1091


feat/checkbox

Infos
Task
What is being delivered?
Update Checkbox styles and create Checkbox component to Vue.
I've talk with Lucas Ramalho about new styles as here:

What impacts?
Now, We could use Checkbox component at Vue projects.
Reversal plan
Revert it, make changes and update.
Evidences
Vue:

React:

DoD checklist

[x] Related code finished
[x] Documentation updated (if exists)
[x] Unit tests written and passing
[ ] Any configuration or build changes documented
[ ] Project builds without errors
[ ] Lint errors fixed

I didn't find this in the files, but on react docs the component name is Input as showed on yours evidences hahahhaha maybe the evidence is just out of date, but 🤷🏾♂ hahhahaha

I didn't find this in the files, but on react docs the component name is Input as showed on yours evidences hahahhaha maybe the evidence is just out of date, but 🤷🏾♂ hahhahaha

You're totally right! hahahahahaha I did not notice.
It is in PROD too, I will remove.

Why you removed the error place?

@carloshrabelo and @viniciuscr, Lucas Ramalho and Raquel Mendes have talked about it (error message) and he ask me to remove because, by them, we won't use. hehe 😜  I understood that we have not been use it, but if there is some place with it send me a print and I will show for them.

@carloshrabelo and @viniciuscr, Lucas Ramalho and Raquel Mendes have talked about it (error message) and he ask me to remove because, by them, we won't use. hehe 😜 I understood that we have not been use it, but if there is some place with it send me a print and I will show for them.

I need to wait add venice-icons at WebCustomer(LV) and Colosseum.

It needs to wait add venice-icons at WebCustomer(LV) and Colosseum.


hdrs_check doesn't work as intended

LibTiff/BUILD file looks like:
package(default_visibility=["//visibility:public"])

cc_library(
    name = "tiff",
    hdrs = glob(["**/*.h"]),
    srcs = glob(
        ["tif*.c"],
        exclude = ["tif_win32.c", "tif_unix.c", "tif_wince.c", "tif_vms.c"]
    ),
    includes = ["."],
    deps = [
        "//libs/freeimage/Source/LibJPEG:jpeg",
        "//libs/freeimage/Source/Zlib:zlib",
    ],
    hdrs_check = "loose",
)

Zlib/BUILD looks like:
package(default_visibility=["//visibility:public"])

cc_library(
    name = "zlib",
    hdrs = glob(["*.h"]),
    srcs = glob(["*.c"]),
    includes = ["."],
)

$ cd LibTiff && bazel build :tiff
ERROR: /Users/applmak/Desktop/chi-video-wall/libs/freeimage/Source/LibTIFF4/BUILD:3:1: undeclared inclusion(s) in rule '//libs/freeimage/Source/LibTIFF4:tiff':
this rule is missing dependency declarations for the following files included by 'libs/freeimage/Source/LibTIFF4/tif_zip.c':
  'libs/freeimage/Source/ZLib/zlib.h'.
Target //libs/freeimage/Source/LibTIFF4:tiff failed to build

Necessary bit of LibTiff/tif_zip.c:
...
#include "tif_predict.h"
#include "../ZLib/zlib.h"

#include <stdio.h>
...

Two problems:

The hdrs_check isn't being disabled when I use 'loose'.
zlib.h is included in the glob of :zlib, but is still tripping the header checker, despite being added as a dep.

I'm unable to reproduce this issue with a toy example:
$ ls LibTiff
BUILD  tif_zip.c
$ cat LibTiff/BUILD
package(default_visibility=["//visibility:public"])

cc_library(
    name = "tiff",
    hdrs = glob(["**/*.h"]),
    srcs = glob(
        ["tif*.c"],
    ),
    includes = ["."],
    deps = [
        "//Zlib:zlib",
    ],
    hdrs_check = "loose",
)

$ cat LibTiff/tif_zip.c
#include "../Zlib/zlib.h"

$ ls Zlib
BUILD  zlib.c  zlib.h
$ cat Zlib/BUILD
package(default_visibility=["//visibility:public"])

cc_library(
    name = "zlib",
    hdrs = glob(["*.h"]),
    srcs = glob(["*.c"]),
    includes = ["."],
)
$ cat Zlib/zlib.c  # empty file
$ cat Zlib/zlib.h # empty file
$ cd LibTiff
$ bazel build :tiff
Extracting Bazel installation...
......
INFO: Found 1 target...
Target //LibTiff:tiff up-to-date:
  bazel-bin/LibTiff/libtiff.a
  bazel-bin/LibTiff/libtiff.so
INFO: Elapsed time: 1.239s, Critical Path: 0.12s

Can you provide a complete repro?

Hmm, I'm surprised by your simple repro. The only additional information I might be able to provide is that my WORKSPACE file is slightly farther away in  /Users/applmak/Desktop/chi-video-wall and, I'm using a Mac OS X computer. I'll see if I can find a minimum zip that demonstrates the problem.

Closing due to old age and non-reproducibility.


Optimize Error Handling and Regex Caching in Tensor Loading

This PR introduces two key enhancements to the tensor loading process: (Fixes #220)

Improved error handling within ThreadPoolExecutor to provide detailed logs for failures during parallel tensor loading.
Implementation of caching for regex operations in get_load_path_str to reduce computational overhead and improve loading efficiency.

These changes aim to enhance the robustness and performance of tensor loading, particularly in distributed computing environments.

Hey! I'm happy to see a limit set for the memory usage in LRU Cache. Would it be possible for you to roll a test for this change? I think a pytest test would suffice.

Perhaps path_tuple_to_string can also utilize the LRU cache, as well. Just a thought.

After delving a bit. I now think 32MB in LRU cache may be too much overkill. I don't think more than 250kb at most should be necessary.

"delving" hahahaha (for reference: https://twitter.com/JeremyNguyenPhD/status/1774021645709295840)

"delving" hahahaha (for reference: https://x.com/JeremyNguyenPhD/status/1774021645709295840)

Hadn't seen this, and the stat doesn't really correspond with anything related to ChatGPT. I most certainly didn't need to use ChatGPT to come to that conclusion.
I recommend trying both ways and running benchmarks to see which provides the best performance improvement.


Resample directly in logspace

This should be complemented with make the "W" attribute of the Weight class be a property.

I think the residual resampling can be adapted with very little effort by normalizing in the logspace when passing the residual weights to the multinomial resampler but I'm not really sure about the ssp one. Maybe it can be rephrased in terms of logit functions

You can merge a subpart of the commit if you wish to.
I don't understand your point about the under/overflow. I am not addressing normalisation here.
Also note that something like this would work as a normalizer preventing underflow/overflow:
from scipy.special import logsumexp

def normalise(lw):
    return lw - logsumexp(lw)

See this:
https://colab.research.google.com/drive/1riyVPiuNqCxGPpNPuc36IVSzGUEvHol8?usp=sharing

I fixed manually the following issues in the master branch:

the unreferenced name in resampling.resampling
the issue with the int dtype, which turns out to be more complicated that I thought, see below.

Regarding the "resampling on log-scale", I will think about it, but right now (as the book is about to get published) I'd rather not introduce extra features in the core packages. Thus, I'm going to close this issue. Again, thanks a lot for your feedback.
Issue with dtype
Boring point for most ppl, but I'm going to document this here in case this issue bites me again in the future. In numpy this instruction is legit:
x = np.zeros(3, dtype='int')  # use a string to choose dtype; default int type is int64
However, recent versions of numba refuse to compile this instruction. I thought it was because of the string, but apparently this is due to the fact that you need to specify precisely which type of ints you want; e.g.
x = np.zeros(3, dtype=np.int64)  # works in numba
At some point, I fixed this issue by putting np.int32 in the two-three functions that were using numba; but the other parts of the module were still using "int", which agains defaults to int64 in numpy. From now on, the package use explicitly int64 everywhere (in module resampling).


state-bridge: Census peer scoring

Problem
The Census only keeps track of all available peers, and their liveness is checked once per hour.
When peers are requested for a given content id, census filters out all peers whose radius doesn't include provided content, and returns first X (4 at the moment of writing).
Ideally, we should have some reputation or scoring system for the peers and use it when selecting them.
High level idea
Firstly, we should still filter out peers that are not interested in the content (as we do now). Then, each peer will be assigned weight, and X peers will be selected randomly based on their weight.
The weight can be calculated as product of following: distance, reputation and recency weights
Note: All constants can be configurable parameters. Given values are picked by feeling and could be a good starting point (unless somebody has some other suggestions).
Distance weight
This is the main weigh: peers should be selected based on their distance to the content.
distance_weight = u16::MAX - distance(peer_id, content_id).as_u16()

The as_u16 function takes 16 most significant bits (2 bytes) of the U256 distance metric
Reputation weight
This is the main penalty weight: peers with recent failed attempts should be penalized.
reputation_weight = 1 / (2^recent_failed_attempts) as f64

The recent_failed_attempts is the number of recently failed OFFER requests to the peer. Only last 16 OFFER requests should be considered. Rejected offers shouldn't be counted as failures .
Each failed attempt lowers the weight by factor of 2.
Recency weight
This is the main recovery function: it "rewards" peers that weren't offered content in a long time.
Peers that were failing requests in the past but have recovered in the meantime would have hard time being selected, and this weight should help with that.
recency_weight = 2 ^ ((now - last_offer_timestamp).as_seconds() / 300)

For every 5 minutes that we didn't offer content to the peer, their weight increases by factor of 2
Assuming all peers are healthy, this shouldn't play big factor because of the high volume and random distribution of content ids (meaning all peers should be selected before this weight grows too big).
This only starts playing important role for peers that are penalized by reputation_weight, in which case it takes 5 minutes to recover one failed attempt.
Future improvements
Some ideas omitted from the initial approach as I want to start with something simple and add more complexity afterwards if needed.

Latency weight - reward/penalize peers based on their latency/bandwidth
How to handle peers that seem offline (e.g. failed PING request)? Should we keep pinging them (e.g. with exponential backoff period) until we eventually drop their info.

ok

I'll propose an alternate framework.  Weights are all additive to avoid multipliers, making it much easier to reason about the ranges for different values.

The base set of peers is the known peers who's data_radius has them in-range for the content.
Peers start with 0 weight.
Peers can have a maximum of 200 weight.
Peers can have a minimum of -200 weight.
Weight is tracked on a rolling 15 minutes time window.  Events that move out of this window no longer effect a peer's weight.
Failing a transfer deducts 10 from a peer's weight.
Succeeding a transfer adds 5 to a peer's weight.

Given the list of interested peers, a weighted random selection should be made from the calculated weights.
The main thing I'd like to augment this with would be data transfer rate which I think requires us to have an actual ongoing measurement of each individual peer's throughput in something like bytes/sec.  With that we can award additional weight based on how they do in comparison with the other peers.

Since you didn't mention it, do you think it's important to prioritize / give higher weigh to nodes that are closer to the content?

Peers can have a maximum of 200 weight.
Peers can have a minimum of -200 weight.

...
Given the list of interested peers, a weighted random selection should be made from the calculated weights.

Can you elaborate, from probability/algorithm point of view, how negative weights would be used?
To my knowledge, most commonly used sampling uses positive weights for sampling where probability for element i being selected is:  $p(i) = {w_i} / {\sum{w_i}}$ .
I guess your idea can be used in the same way as if starting weight is 200 and min-max range is 0-400, but I'm not sure if probability distribution you had in mind is different.
--
I'm also pretty sure we can implement multiple different "peer scoring" algorithms and compare performance (e.g. percentage of failed attempts).

For the range, I imagined that implementations would treat this as a weight in the range 0-400.  It felt awkward to define the algorithm with each node have a starting weight of 200.  Also worth saying that the exact numbers here are utterly arbitrary and I'm totally open to suggestions for better numbers.

Since you didn't mention it, do you think it's important to prioritize / give higher weigh to nodes that are closer to the content?

No, I don't think distance should be apart of this.  The neighborhood gossip should take care of getting content to the closest nodes and I don't think it is likely to improve our primary performance metric (rate-or-speed of gossip) to push it to the closest nodes, nor do I think it improves network health.

If we were able to have throughput measurements, then I would suggest this modification.

Let MBR be the average/mean bit rate for recent transfers for all successful transfers.
After a successful transfer, in addition to the bonus +5  weight for the success..

if the bitrate was above the MBR the peer gets an extra 1 weight
if the bitrate was below the MBR the peer gets deducted 1 weight

I also think that we should add extra penalties for failed transfers.  In theory we could do this by measuring wasted bandwidth and time.  The MBR tells us how long a transfer should take on average.  We should be able to combine this with the payload size to get a time T which would be the expected mean transfer time.  Ideally we'd want to deduct additional weight for them taking extra long to fail and we'd want to deduct extra points for them using extra bandwidth beyond the base bandwidth that would have been needed for transfering the base payload....  I hope this makes sense.

Before you implement this in trin, can you make sure that we have measurable metrics for knowing whether the change improved the throughput of the bridge...

One thing to note is currently we filter out ultralight nodes, peer scoring mainly helps with peers what don't peer form well. As our networks grow bad peers will grow.
Currently, filtering out Ultralight made a big different; I think peer scoring is the right way to do this, as we shouldn't discriminate a node based on implementation but on performance. Bad nodes blocks throughput we can be using for working nodes.
In a perfect world something like this wouldn't make a difference. My assumption is as the networks grow the importance of peer scoring grows

Because of the Devcon, we didn't update our state bridges in a while. So final census improvements (peer scoring) was pushed yesterday.
Conclusion
Improved average gossip time 2-2.5 times. Which resulted in higher gossip rate.
All of this is probably a consequence of significant reduction of failed attempts.
We might be able to get even better performance if we tweak peer scoring parameters, or implement different peer scoring algorithm. Something to be considered for the future.
Charts
testnet-ams3-1: blocks: 0 - 500K

testnet-nyc3-1: blocks: 500K - 800K

testnet-sgp1-1: blocks: 800K - 1M

Chart explanation:

Looking at the 2 day period, vertical dotted line represents when the push happened
Top row:

Left chart tells us average time it took to gossip one content key/value pair
Right chart tells us how many content key/value pairs we were able to gossip per minute

Bottom row:

The rate of sending content key/value pair to other peers, split per result (each chart) and content type (line)

Worth noting: Almost all content is declined (expected as content is already present at the network)

Those are some significant improvements.  Really appreciate the measurements to demonstrate that the change had a tangible effect.  Very cool.

@morph-dev Just curious, are you also checking the radius of nodes before gossiping content to them? In Fluffy we cache the radius of all nodes which we contact. This cache is then used to check if the content is within the expected radius of the node before sending the offer.

Yes, we store radius of all nodes (and update it periodically). And we only consider nodes that are interested in content.


Added docs in README

includes project start up guide and maintenance related guides.

@TimothyGu Thanks grammarly

They are not grammar things though


Least size in the same video height.

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.12.03. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.12.03

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.12.03
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
This is a simple feature request, especially for those formats where video dimensions and video size is provided in -F output.
What I want is to get the file with small size when there are two or more with same video height.
[height=720] && [size=min]

worstvideo[height=720] should work

It picks the format with the lowest bitrate, which is 247.  It happens to have a larger filesize, but it does work as intended.

Ok, but how take least size then?

Can we use that? Worst mistake will be 50M. Need del all line feed.
youtube-dl -f "worstvideo[height=720][filesize<200M]/worstvideo[height=720][filesize<250M]/worstvideo[height=720][filesize<300M]/worstvideo

[height=720][filesize<350M]/worstvideo[height=720][filesize<400M]/worstvideo[height=720][filesize<450M]/worstvideo[height=720]

[filesize<500M]/worstvideo[height=720][filesize<550M]/worstvideo[height=720][filesize<600M]/worstvideo[height=720][filesize<650M]/worstvideo

[height=720]+worstaudio" https://www.youtube.com/watch?v=yZbWFMURfB8

Somtimes, this does't work too...
247          webm       1280x720   720p 1513k , vp9, 25fps, video only, 329.73MiB
136          mp4        1280x720   720p 1750k , avc1.4d401f, 25fps, video only, 295.85MiB

Will prefer 329 although worstvideo[height=720][filesize<300M]... :(

it can be done by using -F and then piping it to a file or something and then using regex and some comparisons inside a bash or batch script. but that's a hassle and it's better if it's incorporated inside youtube-dl.

come on, somebody reply with a solution. or at least open the closed issue


Update package version to 2.9.1.

I think this will let source builds appear as newer than the stable PyPI release that was just published (https://pypi.org/project/iree-turbine/2.9.0/). We can iterate on the release process sequencing next week. Maybe we shouldn't touch this version, or maybe we should update the minor version instead of the patch version, I'm not sure.

I would suggest to increment the minor version instead but as 3.0.0 is to be released soon, we even might want to set the version to 3.0.0.dev already which nightlies building as 3.0.0rc202411*. I will add docs to iree.dev soon.


Add pry gem

Makes development so much easier!

Feel free to send a PR :)

Ah I'm going to close this actually - I've been pulled on to another project so I won't be using pry on this project (in the near future at least!)


Add xrootd to known implementations on fsspec site

https://filesystem-spec.readthedocs.io/en/latest/api.html#other-known-implementations

Completed by https://github.com/fsspec/filesystem_spec/pull/1646


added licence in README

Readme.md follow the rules and template of community,
a. where the original repo information is shared
b. Snapshots of how it will look in harmony is shared. images from Harmony emulator / device
gradle.properties should not have sonar local properties
systemProp.sonar.host.url=http://localhost:9000
build.gradle at project level
modify sonar for sonarcloud
property "sonar.host.url", "http://localhost:9000"
follow this
https://sonarcloud.io/project/configuration?analysisMode=GitHubActions&id=applibgroup_UniversalPickerDialog
config.json
Device type can be made "default" to support all the device forms

No difference between default picker and multipicker

changed it

Background and can be made same as original library

changed it

Readme.md follow the rules and template of community,
a. where the original repo information is shared
b. Snapshots of how it will look in harmony is shared. images from Harmony emulator / device
gradle.properties should not have sonar local properties
systemProp.sonar.host.url=http://localhost:9000
build.gradle at project level
modify sonar for sonarcloud
property "sonar.host.url", "http://localhost:9000"
follow this
https://sonarcloud.io/project/configuration?analysisMode=GitHubActions&id=applibgroup_UniversalPickerDialog
config.json
Device type can be made "default" to support all the device forms

modified the README.md
remove the "systemProp.sonar.host.url" property from gradle.properties
modified the "sonar.host.url" to "https://sonarcloud.io/" let me know if any more change is necessary
modified the library(universalpickerdialog) module's config.json device type to "default", but when I change the example apps config.json it fails to deploy on the emulator.

First push should be the base version from where the version is taken.

I didn't understand what base version are you taking about ?

Hi prashanth better we cancel this pull request and apply new one.

Push the android library first and then pull the harmonyOS library on top of that.
refer other libs, since the env is not setup here, there are some backend issues with this pull.
DO this and raise the pull request will merge.


Changing font color in dark.tcl doesn't change anything

I was trying to change the foreground colour of disabled labels in the dark theme (dark.tcl), but changing it didn't have any effect.
Changing it at azure.tcl did bring the expected results.
Am I missing something?
dark.tcl:
namespace eval ttk::theme::azure-dark {
    variable version 2.0
    package provide ttk::theme::azure-dark $version

    ttk::style theme create azure-dark -parent clam -settings {
        proc load_images {imgdir} {
            variable I
            foreach file [glob -directory $imgdir *.gif] {
                set img [file tail [file rootname $file]]
                set I($img) [image create photo -file $file -format gif]
            }
        }

        load_images [file join [file dirname [info script]] dark]

        array set colors {
            -fg             "#ffffff"
            -bg             "#333333"
            -disabledfg     "#aaaaaa"
            -disabledbg     "#737373"
            -selectfg       "#ffffff"
            -selectbg       "#007fff"
        }

azure.tcl:
source [file join [file dirname [info script]] theme light.tcl]
source [file join [file dirname [info script]] theme dark.tcl]

option add *tearOff 0

proc set_theme {mode} {
	if {$mode == "dark"} {
		ttk::style theme use "azure-dark"

		array set colors {
            -fg             "#ffffff"
            -bg             "#333333"
            -disabledfg     "#ffffff"
            -disabledbg     "#737373"
            -selectfg       "#ffffff"
            -selectbg       "#007fff"
        }

#46 Would not be working as intended.

Actually this is somewhat intended, but it's a terrible hack.
Originally only the dark.tcl file needed these colors. Then, when azure.tcl was added, I simply copied the color dict into it.
So you can change some things in dark.tcl and light.tcl file and some things in the main azure.tcl file. Blaaahhh


ImportError

Whenever I try to import the initial command I get the following:
ImportError: cannot import name 'Load_Data' from 'DeepImageSearch'
Thank you for your work, I hope you can help.

I have updated the entire library. You can find the complete changelog here: https://github.com/TechyNilesh/DeepImageSearch/releases/tag/v_25.
Bugs have been removed and additional features have been added.


Crash, cannot start /usr/sbin/arangod

ArangoDB Version:        3.6.2
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   Manual Start
Infrastructure:               own
Operating System:        Centos 7

I was running manual start via /usr/sbin/arangod, as my install couldn't find the service file. It is working fine, but suddenly while I was working on webbrowser, it stop connecting, so I went try to restart again, and I couldn't
root@localhost sbin]# pwd
/usr/sbin
[root@localhost sbin]# find -name arangod
./arangod
[root@localhost sbin]# ./usr/sbin/arangod
-bash: ./usr/sbin/arangod: No such file or directory

less /var/log/arangodb3/arangod.log
2020-04-14T01:59:59Z [27920] INFO [33eae] hangup received, about to reopen logfile
2020-04-14T01:59:59Z [27920] INFO [23db2] hangup received, reopened logfile
2020-04-14T04:02:46Z [27920] WARNING [ebe22] Failed to update Foxx store from GitHub.
..same message
2020-04-14T10:07:28Z [27920] WARNING [ebe22] Failed to update Foxx store from GitHub.
2020-04-14T15:32:04Z [27920] WARNING [3ad54] {engines} slow background settings sync: 1.200316 s
2020-04-14T15:52:16Z [27920] WARNING [ebe22] Failed to update Foxx store from GitHub.
.. same message
2020-04-14T18:06:23Z [27920] WARNING [ebe22] Failed to update Foxx store from GitHub.
/var/log/arangodb3/arangod.log (END)

This is just test server , I was creating/deleting 1 collection with 1 document only.

My bad, it should be /usr/sbin/arangod


Fix/16697: Remove all colons in search value in emoji picker

Details

When the user enters some redundant colons, there is no result found. So we need remove all colons in search term
Fixed Issues

$ https://github.com/Expensify/App/issues/16697
https://github.com/Expensify/App/issues/16697#issuecomment-1491247274
Tests

Open the app
Open any report
Open emoji picker
Search for any emoji with colons at the start, between and end as we do for emoji suggestions (ex: :he::art:)
Verify that the results are display as entering heart

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Open the app
Open any report
Open emoji picker
Search for any emoji with colons at the start, between and end as we do for emoji suggestions (ex: :he::art:)
Verify that the results are display as entering heart

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Gonals @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

We just reverted the search picker on mobile. So in this PR, I only update in index.js file

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Gonals in version: 1.2.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.95-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix typo in helper text

Duplicate to #147
Sorry! dev is the latest dev branch but we have to set master branch as the main branch to lead the users to download the master release.


fix: Some months in the Persian Calendar show the 30th as the first day of the month

Changes are based on this GitHub source, Also I'm not good at adding test 😢🙏
https://github.com/pasoonate/pasoonate-js/blob/master/src/calendar/JalaliCalendar.js
Closes https://github.com/adobe/react-spectrum/issues/5960, https://github.com/adobe/react-spectrum/issues/3757
Related PR https://github.com/adobe/react-spectrum/pull/5946
https://github.com/adobe/react-spectrum/assets/17789047/4998db3e-2f8a-4660-865b-02772c5a07e5

Context for video
1 === ۱
30 === ۳۰
31 === ۳۱
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Thanks for the PR! Would you mind signing the CLA and then closing and reopening the PR so that build step can pass?

I signed CLA @LFDanLu

@epr3
After conversation with flat-internationalized-date maintainer he did fixed this issue I'll close this PR, he will submit new PR soon :heart:


Panicked at examples/uart_loopback_test.rs

Dear SAM Team,
I am afraid the UART examples are not working out of the box on the SAM V71 Xultra (blue) Board anymore (? I can't confirm it ever did, first time I try it).
Maybe I am doing something wrong, or oversight of a minimum (undocumented) wiring here ?

Sounds like a Clock issue as we can easily track this error msg down to uart.rs:358 (might want to try and play with both MCK and PCK values).
I have the (exact) same situation for both the examples/uart_loopback_test.rs and the examples/uart_interrupts, while both examples/usart_loopback.rs (using a small wiring PB00-PB01 on J505) and examples/usb_serial_echo.rs (using second 9target) USB port) are working just fine.
Any hint/correction/suggestion is welcome here ! :)
Cheers,
Ben

@blietaer for clarity as you haven't mentioned. Is it on released version (which one?) or from top of development branch?
Maybe @martinmortsell would have a quick hint for you?

Wow many thanks to both of you for this super quick feedback.

@blietaer for clarity as you haven't mentioned: Is it on released version (which one?) or from top of development branch?
Ah yes, this is development branch, sorry.

Have you changed anything in the example code anywhere else?
No no, this is a vanilla clone from repo.

The problem is that there's a requirement that mck needs to be at least 3 times bigger than pck, and this is not fulfilled as the prescaler value is set to 1. Changing the HccPrescaler should fix this issue.
Yes, this is my understanding just reviewing uart.rs: mmmh let me check if I can play with HccPrescaler directly from the example code, without touching anything under the HAL/PAC hood.

Changing the pres value (second parameter of configure() ) from 1 to 3 seems indeed to fix this:

@blietaer PR this change, please.

Will do, but actually I was a bit quick: this only solves the example\uart_interrupts.rs but not the example\uart_loopback_test: I can't have anything printed (and I wired the same) not sure if my modification is suspicious here...can't hardly debug it :/
Trying different Tx/Rx pin (loop-wired too..), but not joy...


expand installer template to set extra SSH pub keys

SUMMARY
This will allow to specify multiple SSH key paths
to be applied at day1 and SSH can be performed
from multiple sources.
ISSUE TYPE

Enhance role

Tests

[] TestBos2 -
[x] TestDallas - https://www.distributed-ci.io/jobs/bb8bee10-a34d-4883-b71d-e2b5008d62a9/jobStates

TestBos2: virt libvirt:ansible_extravars=dci_operators:[] libvirt:ansible_extravars=enable_lso:false libvirt:ansible_extravars=enable_odf:false

recheck


Apply Absorption Law when normalizing markers

E.g., python_version < '3.11' or (python_version < '3.11' and implementation_name == 'cpython') should be reduced to python_version < '3.11'.

I wonder if we should do something like this: https://docs.rs/boolean_expression/latest/boolean_expression/enum.Expr.html#method.simplify_via_bdd

Alternatively, maybe we can just apply this in the or and and methods (make them smart constructors)?

I think smart constructors are the way to go, but I think it's a big task. To make smart constructors work, you have to make sure they are the only things capable of constructing the internal representation. You also need to make all normalization steps inductive. On top of this, I think the normalization logic (which would need to be ported to smart constructors in pep508_rs) currently lives in uv-resolver because it relies on a pubgrub type. So that dependency on pubgrub would probably need to be broken.
I would love to do this personally as I love smart constructors and they've worked out great when I used them in the past (like in regex-syntax). But it's a meaty task I think.

I'm not sure the smart constructor helps with the simplification. For example, the expression ((x and y) or z) is fully simplified, but combining that with or y we get ((x and y) or z) or y, which simplifies to y or z. Importantly, the complete simplification cannot be performed inductively, so a SAT algorithm (such as this) should be performed after the entire marker tree has been constructed.
I think it would be helpful to know what kind of cases the lockfile generates to see how far we need to take this. We can solve this issue using our current recursive approach and see whether more complex cases come up. It's totally possible that an inductive approach that only looks one layer deep is enough for us, but I would hesitate to add smart constructors and them end up not being useful because we need to do a recursive solve anyways.

Confusingly there are Python versions that do not match either of those bounds. For example, 3.11.0a0 would not match either.

Confusingly there are Python versions that do not match either of those bounds. For example, 3.11.0a0 would not match either.

I don't feel like that's a correct interpretation of Python version numbers.
When you are installing into a specific version of Python there is only one version number available. So if you are installing into Python 3.11.0a0 then all versions of Python available (i.e. the one you are installing into) are pre-releases and therefore python_version>= 3.11 matches 3.11.0a0.
But that's just me thinking out loud, when I get a moment I'll check what pip does and read through the spec.

I think per the spec it's correct. I actually agree that we should probably simplify that, but I think that's why it doesn't get simplified today.
python_version>= 3.11 is implicitly python_version>= 3.11.0, and 3.11.0a0 is not >= 3.11.0, right?

and 3.11.0a0 is not >= 3.11.0, right

My understanding is per PEP 440 3.11.0a0 matches >= 3.11.0, when 3.11.0a0 is the only version available because then pre-releases are implied. So my logic was that when you are installing into Python it's version is the only version available, and therefore you can always take pre-releases to be applied.
But, this was just all off the top of my head, I should of really waited to get home and test it out. I will do so later.

Got home and ran some tests and read some docs and I still think uv isn't correct here, I created a seperate issue: https://github.com/astral-sh/uv/issues/4714

I filed a separate issue for that normalization here: https://github.com/astral-sh/uv/issues/4719. (It's different than what's described in this issue.)


ability to recover wallet with passphrase

Expected behavior
ability to recover a wallet with passphrase using GUI.
It is currently only possible using CLI.
Actual behavior
cannot enter a passphrase when recovering a wallet using seed words

I should've opened a feature request issue not bug report, I was too fast.
bug label can be removed.

Hey @MarnixCroes, thanks for the request.
I agree, this is something that should be possible.
However, this is not supported via the JM API yet as far as I know (I have not verified).
Is this something theoretical or a real practical need of yours?

Hey @MarnixCroes, thanks for the request. I agree, this is something that should be possible. However, this is not supported via the JM API yet as far as I know (I have not verified).
Is this something theoretical or a real practical need of yours?

it's alright.
low priority issue imo as these are non standard JAM created wallets.


Simplify Operator.Role

Simplifying Operator.Role to panic when unable to determine team role for an operator instead of returning an error.
This is possible since we have a test in place verifying that each operator has a role assigned.
The only scenario where the function can panic if it is called on unitialized an Operator (with value 0).
Since we only use Operator.Role internally, we can assure this doesn't happen.
While at it, I also added ordering for the source code of operator roles in 42c5f9ef10. I was irritated that the generation of the operator roles map wasn't deterministic, making it hard to git diff the changes, i.e. when a new operator is added.
This is now possible.

Good idea on sorting the map! I noticed this as well


Fixing Return Shape

Currently we return a weird 1D Numpy array where all the column names are one element and all the np arrays for each quarter are a single element as well. Issue was making the final value data unique after all the data jargon words were collected sequentially.

Actual issue was with fromiter forcing a 1d array. Fixed that with np.stack so I put back the unique data as it is now harmless, and sorts our data.


[bug]: WebUI resets to default every session on 2.3.0

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
8GB
What happened?
Every time I start a web session all settings are reset to default. This has only started since updating to stable 2.3.0 - didn't happen with 2.2.5 or 2.3 release candidate 4 which was the only one I tried. Thanks!
Screenshots
No response
Additional context
No response
Contact Details
discordname jonathanljs#0290

Hi, probably something in the browsers local storage has gone sideways. Please reset it fully by opening your web browser's JavaScript console and running the following command:
localStorage.clear()
Then refresh the page. All the settings should be remembered now.

Thanks for this - unfortunately I get an 'undefined' error when I do this. When I try doing it through the Applications tab, I get a string of errors on refresh, see attached.

Chrome on Windows, latest version.


Edited docs/discovery.md

Signed-off-by: NanXiao<EMAIL_ADDRESS>

@NanXiao
Thanks for your contribution.
Two things:

see my comment;
can you squash two commit into a single one?

LGTM


[WIP] summed_op - implement chop_summands

Summary
This will fix issue #1096
I am implementing a chop_summands function in summed_op.py to remove summands from a list of operators if its coefficients are less than a given threshold. This implementation is similar to WeightedPauliOperator.chop.
Details and comments
This code does not work yet. I am looking to get some feedback and guidance about where to go from here. This is my first contribution and I'm a little lost at the moment. Any help would be appreciated.

@spencerking Is this something you are interested in continuing - if not please close this. If I do not hear back in a while I will close this, but of course it could still be re-opened if for some reason you had not seen this comment and it has been closed.


[PLAT-6884] GCP from fleetcommand fails

This is enables batching for resources that support it and prevents node pool creation from failing with
rateLimitExceeded

This does nothing for the problem.

This does nothing for the problem.

I wasnt able to reproduce the issue with batching enabled. I'm open to  constructive suggestions as to how to solve this with  either batching or parallelism on.


map won't load ... is it because of new google api?

The map on the post edit screen shows up but there is no search button, only location.  If i manually type in the address etc, the data saves, but teh map doesn't show.  If i use the geolocate button to add my own location the map refreshes but doesn't show any new data.  WHen i hit save map goes back to default location.  Any ideas?  on my edit page i'm getting this error:
"This service requires an API key.  For more information on authentication and Google Maps Javascript API services please see: https://developers.google.com/maps/documentation/javascript/get-api-key"

Google requires an api for maps now, I should have add (and will now add) that caveat to the readme. ACF provides a guide to registering an API and adding to your functions.php and then this plugin should work correctly:
https://www.advancedcustomfields.com/blog/google-maps-api-settings/


Add paparazzo

Project URL

https://github.com/avito-tech/Paparazzo
Description

Custom iOS camera and photo picker with editing capabilities
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          2 Warnings

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

:warning:
Found 6 link issues, a project collaborator will take care of these, thanks: )

Link issues by awesome_bot

Line
Status
Link

374
301
https://github.com/SyncDB/Sync redirects tohttps://github.com/3lvis/Sync

382
301
https://github.com/SyncDB/DATAStack redirects tohttps://github.com/3lvis/DATAStack

901
404
https://github.com/MessageKit/MessageKit-iOS

1652
301
https://github.com/jackyzh/awesome-ios-animation redirects tohttps://github.com/jackymelb/awesome-ios-animation

2330
301
https://github.com/mojilala/VideoSplashKit redirects tohttps://github.com/svtek/VideoSplashKit

2436
Error
https://iconresizer.com/  Connection refused - connect(2) for "iconresizer.com" port 443

  Generated by :no_entry_sign: Danger

Thx


Can't close TextBlockMessage

When the keybinds window or an error window pops up there's no way to close it other than using a hotkey (for the keybinds menu) or killing the process from Task Manager.
This can probably be fixed by changing false at workspacer.Share/TextBlockMessage.Designer.cs line 68 to true.

Feel free to test, and if it works, send in a PR :)

@josteink I have tested it with the keybinds window and it works but I wasn't able to test it with the error window. Should I send a PR or wait for someone to test it?

Feel free! It's certainly better than nothing. 👍

Just a quick question did you try maximising either window by double-clicking it the border? This should reveal the buttons at the bottom right, at least it does for me. Either way it's not a great situation so a fix would be great!

Closing the issue as it was fixed in #191, tested and confirmed


Install failed

Complie error:
$ gem install cityhash
  Building native extensions.  This could take a while...
ERROR:  Error installing cityhash:
    ERROR: Failed to build gem native extension.

    /home/gsmetal/.rvm/rubies/ruby-2.0.0-p0/bin/ruby extconf.rb
creating Makefile

 make
compiling city.cc
cc1plus: warning: command line option ‘-Wdeclaration-after-statement’ is valid for C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option ‘-Wimplicit-function-declaration’ is valid for C/ObjC but not for C++ [enabled by default]
city.cc: In function ‘uint32 Hash32Len0to4(const char*, size_t)’:
city.cc:145:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
city.cc: In function ‘void CityHashCrc256Long(const char*, size_t, uint32, uint64*)’:
city.cc:531:5: error: ‘_mm_crc32_u64’ was not declared in this scope
city.cc:540:5: error: ‘_mm_crc32_u64’ was not declared in this scope
city.cc:550:5: error: ‘_mm_crc32_u64’ was not declared in this scope
make: *** [city.o] Error 1

Cityhash from googlecode without -msse4.2 compiles successfully.
PS:
$ cat /proc/cpuinfo
processor   : 0
vendor_id   : GenuineIntel
cpu family  : 6
model       : 23
model name  : Intel(R) Core(TM)2 Duo CPU     P8600  @ 2.40GHz
stepping    : 6
microcode   : 0x60c
cpu MHz     : 800.000
cache size  : 3072 KB
physical id : 0
siblings    : 2
core id     : 0
cpu cores   : 2
apicid      : 0
initial apicid  : 0
fdiv_bug    : no
hlt_bug     : no
f00f_bug    : no
coma_bug    : no
fpu     : yes
fpu_exception   : yes
cpuid level : 10
wp      : yes
flags       : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe nx lm constant_tsc arch_perfmon pebs bts aperfmperf pni dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 lahf_lm dtherm tpr_shadow vnmi flexpriority
bogomips    : 4788.61
clflush size    : 64
cache_alignment : 64
address sizes   : 36 bits physical, 48 bits virtual
power management:

@nashby  I am getting same issue when installing this gem. I am using ubuntu 12.04.
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
/home/rails/.rvm/rubies/ruby-2.2.2/bin/ruby extconf.rb

creating Makefile
make "DESTDIR=" clean
make "DESTDIR="
compiling cityhash.cc
compiling city.cc
city.cc: In function ‘uint32 Hash32Len0to4(const char*, size_t)’:
city.cc:145:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
city.cc: In function ‘void CityHashCrc256Long(const char*, size_t, uint32, uint64*)’:
city.cc:531:5: error: ‘_mm_crc32_u64’ was not declared in this scope
city.cc:540:5: error: ‘_mm_crc32_u64’ was not declared in this scope
city.cc:550:5: error: ‘_mm_crc32_u64’ was not declared in this scope
make: *** [city.o] Error 1
make failed, exit code 2
Gem files will remain installed in<EMAIL_ADDRESS>for inspection.
Results logged to<EMAIL_ADDRESS>

I am also getting the same error while installing it using bundle install
Gemfile
gem "cityhash", "0.8.1"
$ gcc --version
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04 LTS
Release:	14.04
Codename:	trusty
Error trace
Using ffi 1.9.10
Using childprocess 0.5.6
Installing cityhash 0.8.1 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
/home/rails/.rvm/rubies/ruby-2.2.2/bin/ruby -r ./siteconf20150911-25746-12dgsbl.rb extconf.rb

creating Makefile
make "DESTDIR=" clean
make "DESTDIR="
compiling city.cc
city.cc: In function ‘uint32 Hash32Len0to4(const char*, size_t)’:
city.cc:145:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < len; i++) {
^
city.cc: In function ‘void CityHashCrc256Long(const char*, size_t, uint32, uint64*)’:
city.cc:524:31: error: ‘_mm_crc32_u64’ was not declared in this scope
z = _mm_crc32_u64(z, b + g);
^
city.cc:531:5: note: in expansion of macro ‘CHUNK’
CHUNK(0); PERMUTE3(a, h, c);
^
city.cc:524:31: error: ‘_mm_crc32_u64’ was not declared in this scope
z = _mm_crc32_u64(z, b + g);
^
city.cc:540:5: note: in expansion of macro ‘CHUNK’
CHUNK(29);
^
city.cc:524:31: error: ‘_mm_crc32_u64’ was not declared in this scope
z = _mm_crc32_u64(z, b + g);
^
city.cc:550:5: note: in expansion of macro ‘CHUNK’
CHUNK(33);
^
make: *** [city.o] Error 1
make failed, exit code 2
Gem files will remain installed in<EMAIL_ADDRESS>for inspection.
Results logged to<EMAIL_ADDRESS>An error occurred while installing cityhash (0.8.1), and Bundler cannot continue.
Make sure that gem install cityhash -v '0.8.1' succeeds before bundling.

FWIW, we also ran into this issue on AWS. We were compiling cityhash within a docker build on C4 instances. When we went to run the image on a C3 instance, the Ruby VM crashed with:
/usr/local/bundle/gems/cityhash-0.8.1/lib/cityhash.rb:11: [BUG] Illegal instruction at 0x007fee4cc25764

Removing -march=native fixes the issue: https://github.com/remind101/cityhash/commit/915151cdb5c012de3f3b80c07652432160468dc9.
I'm not sure if this gem is still maintained, but I would suggest that the default CFLAGS don't include -march=native so that bundled gems are more portable across machines.

@ejholmes thanks for following up. I just merged PR that removed default -march=native. But obviously CRC methods wont work on instances without sse4. Any suggestion how we should handle it? (As you can see master branch is failing on travis because of it)

@nashby good question! We don't actually use the CRC methods, so I never noticed https://github.com/nashby/cityhash/blob/master/ext/cityhash/city.cc#L514 before.
Maybe instead of removing -march=native, there could be any easier way to remove it via --with-cppflags (I couldn't see a way to get around the previous logic to remove it from CPPFLAGS without actually altering extconf.rb).

Hey guys! Yeah, it's been 5 years already, sorry. I just released 0.9.0 version that should compile without CRC methods. Please give it a try!


how can i get a thumbnail in multiple image

Laravel Version: 5.5.40
Voyager Version: 1.0.17
PHP Version: 7.1
Database Driver & Version: MYSQL 5.6

Description:
how can i get a thumbnail in multiple image?
I'm using the code below but only returning the original image
 <img class="img-fluid" src="{{Voyager::image(json_decode($veiculo->thumbnail('small', 'imagem'))[0])}}"   alt="Veiculo">

This is (now) in our docs:
https://docs.laravelvoyager.com/core-concepts/helper-methods


Issue with array types in IDL

Hi -
I'm trying to add an array type to one of my interface classes (originally was String[], but I see the issue with UInt16[], etc as well so doesn't seem to be related to the contained type) and I get the following errors:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2672	'unbox_value_type': no matching overloaded function found (compiling source file Generated Files\XamlTypeInfo.g.cpp)	ArrayTest	C:\Users\ddally\source\repos\ArrayTest\ArrayTest\Generated Files\winrt\Windows.Foundation.h	3066
Error	C2665	'winrt::impl::consume_ArrayTest_IMainWindowwinrt::ArrayTest::IMainWindow::MyProperty': none of the 2 overloads could convert all the argument types	ArrayTest	C:\Users\ddally\source\repos\ArrayTest\ArrayTest\Generated Files\XamlTypeInfo.g.cpp	88
It's definitely possible that I'm missing something on my side, is it a matter of needing to include an additional header somewhere?  I did see mention made of certain template specializations related to unboxing only being available if Windows.Foundation.h is included but it's in my pch.h.
Steps to reproduce:
Change "Int32 MyProperty" to "Int32[] MyProperty" in MainWindow.idl of newly created project and update header and source with generated stub functions.
Thanks,
Derek

That appears to be an XAML compiler issue, as the error is in XamlTypeInfo.g.cpp

Yes, I'd suggest raising the issue with the Xaml team (https://github.com/microsoft/microsoft-ui-xaml).


Consider removing PPLAF from the docs

According to @glebi574,

It isn't that good for projects with lots of custom entities, which it was made for, because of extensive memory usage.

Decision was made to remove PPLAF from the docs.


Model conversion from ONNX to TensorRT on RTX-2080?

How do I modify these reference to convert onnx model to TensorRT for the Higher end GPUs like RTX 2080, a5000.
Or does it only support Jetson family. Bigger questions: Does these GPUs support TensorRT?
Here are steps that I performed to convert yolo-v4 converted onnx model to tensorrt:
This is on a machine with an RTX 2080S.
I am using the following nVidia docker image for TensorRT:
https://docs.nvidia.com/deeplearning/tensorrt/container-release-notes/rel_20-09.html#rel_20-09
I am running it with the following command:
docker run -it --rm --ulimit core=-1 --ipc=host --gpus=all --volume=/home/ccai/code/project:/app nvcr.io/nvidia/tensorrt:20.09-py3
I rebuilt the ldd/plugins/libyolo_layer.so library since the one checked is for arm64 with:
make clean && make
I am also installing the following dependencies in the container to run the conversion utilities:
apt update
apt install -y protobuf-compiler libprotoc-dev
pip install onnx==1.4.1 protobuf
Here is the error I am getting:
root@c1fe9394c820:/app/yolo# python3 yolo/onnx_to_tensorrt.py -c 1 -m tiny-yolov4-optical-640x480
Loading the ONNX file...
Adding yolo_layer plugins...
python3: yolo_layer.cu:413: virtual nvinfer1::IPluginV2IOExt* nvinfer1::YoloPluginCreator::createPlugin(const char*, const nvinfer1::PluginFieldCollection*): Assertion `input_multiplier == 8 || input_multiplier == 16 || input_multiplier == 32' failed.
Aborted (core dumped)

Below is the backtrace of the core file which shows the same spot in the plugins/yolo_layer.cu file, line 413.
gdb shows the following backtrace:
Core was generated by `python3 yolo/onnx_to_tensorrt.py -c 1 -m tiny-yolov4-optical-640x480'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
[Current thread is 1 (Thread 0x7f1331615740 (LWP 755))]
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f133104a921 in __GI_abort () at abort.c:79
#2  0x00007f133103a48a in __assert_fail_base (fmt=0x7f13311c1750 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7f12fbc33ab0 "input_multiplier == 8 || input_multiplier == 16 || input_multiplier == 32",
    file=file@entry=0x7f12fbc33843 "yolo_layer.cu", line=line@entry=413,
    function=function@entry=0x7f12fbc33c80 <nvinfer1::YoloPluginCreator::createPlugin(char const*, nvinfer1::PluginFieldCollection const*)::__PRETTY_FUNCTION__> "virtual nvinfer1::IPluginV2IOExt* nvinfer1::YoloPluginCreator::createPlugin(const char*, const nvinfer1::PluginFieldCollection*)") at assert.c:92
#3  0x00007f133103a502 in __GI___assert_fail (assertion=0x7f12fbc33ab0 "input_multiplier == 8 || input_multiplier == 16 || input_multiplier == 32", file=0x7f12fbc33843 "yolo_layer.cu", line=413,
    function=0x7f12fbc33c80 <nvinfer1::YoloPluginCreator::createPlugin(char const*, nvinfer1::PluginFieldCollection const*)::__PRETTY_FUNCTION__> "virtual nvinfer1::IPluginV2IOExt* nvinfer1::YoloPluginCreator::createPlugin(const char*, const nvinfer1::PluginFieldCollection*)") at assert.c:101
#4  0x00007f12fbbdfcbf in nvinfer1::YoloPluginCreator::createPlugin(char const*, nvinfer1::PluginFieldCollection const*) () from ../plugins/libyolo_layer.so
#5  0x00007f132f9af1c6 in void pybind11::cpp_function::initialize<tensorrt::lambdas::{lambda(nvinfer1::IPluginCreator&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, nvinfer1::PluginFieldCollection const*)#16} const&, nvinfer1::IPluginV2*, nvinfer1::IPluginCreator&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, nvinfer1::PluginFieldCollection const*, pybind11::name, pybind11::is_method, pybind11::sibling, pybind11::arg, pybind11::sibling, char const*>(tensorrt::lambdas::{lambda(nvinfer1::IPluginCreator&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, nvinfer1::PluginFieldCollection const*)#16} const&, nvinfer1::IPluginV2* (*)(nvinfer1::IPluginCreator&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, nvinfer1::PluginFieldCollection const*), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&, pybind11::arg const&, pybind11::sibling const&, char const* const&)::{lambda(pybind11::detail::function_call&)#3}::_FUN(pybind11::detail::function_call) [clone .lto_priv.2598] ()
   from /usr/lib/python3.6/dist-packages/tensorrt/tensorrt.so
#6  0x00007f132f9c3fa0 in pybind11::cpp_function::dispatcher(_object*, _object*, _object*) () from /usr/lib/python3.6/dist-packages/tensorrt/tensorrt.so
#7  0x0000000000566ddc in _PyCFunction_FastCallDict ()
#8  0x000000000050a783 in ?? ()
#9  0x000000000050c1f4 in _PyEval_EvalFrameDefault ()
#10 0x0000000000507f24 in ?? ()
#11 0x0000000000509c50 in ?? ()
#12 0x000000000050a64d in ?? ()
#13 0x000000000050c1f4 in _PyEval_EvalFrameDefault ()
#14 0x0000000000507f24 in ?? ()
#15 0x0000000000509c50 in ?? ()
#16 0x000000000050a64d in ?? ()
#17 0x000000000050c1f4 in _PyEval_EvalFrameDefault ()
#18 0x0000000000509918 in ?? ()
#19 0x000000000050a64d in ?? ()
#20 0x000000000050c1f4 in _PyEval_EvalFrameDefault ()
#21 0x0000000000507f24 in ?? ()
#22 0x000000000050b053 in PyEval_EvalCode ()
#23 0x0000000000634dd2 in ?? ()
#24 0x0000000000634e87 in PyRun_FileExFlags ()
#25 0x000000000063863f in PyRun_SimpleFileExFlags ()
#26 0x00000000006391e1 in Py_Main ()
#27 0x00000000004b0dc0 in main ()

RTX 2080 and RTX A5000 should both work.  You could refer to README_x86.md for modifications required for x86 platforms.

python3: yolo_layer.cu:413: virtual nvinfer1::IPluginV2IOExt* nvinfer1::YoloPluginCreator::createPlugin(const char*, const nvinfer1::PluginFieldCollection*): Assertion `input_multiplier == 8 || input_multiplier == 16 || input_multiplier == 32' failed.

This indicates an assertion failure in the code.  In fact, you are not using the latest code in this repo.  Please update it.  You could refer to the latest source code here:
https://github.com/jkjung-avt/tensorrt_demos/blob/25adc48c43580d8a70f92032da3ac67c1a7bd70e/plugins/yolo_layer.cu#L354-L355

Thanks for the quick response, I will go over the modifications you suggested on both the machines and will update this thread over next week.

Still getting the same error with the latest code. I put a print statement to get the multiplier value, it turns out it is 42.
Loading the ONNX file...
Adding yolo_layer plugins...
input_multiplier = 42
python3: yolo_layer.cu:415: virtual nvinfer1::IPluginV2IOExt* nvinfer1::YoloPluginCreator::createPlugin(const char*, const nvinfer1::PluginFieldCollection*): Assertion `input_multiplier == 8 || input_multiplier == 16 || input_multiplier == 32 || input_multiplier ==64' failed.
Aborted (core dumped)

Could you provide your custom cfg file?  I will take a look.

sure, here are the contents of cfg file: tiny-yolov4-640x480.cfg
[net]
# Testing
batch=1
subdivisions=1
# Training
#batch=64
#subdivisions=16
try_fix_nan=1
width=640
height=480
channels=1
momentum=0.9
decay=0.0005
angle=0
saturation = 1.5
exposure = 1.5
hue=.1
adam=0

learning_rate=0.00261
burn_in=1000

max_batches = 6000
policy=steps
steps=4800,5400
scales=.1,.1

mosaic = 1
#cutmix = 1

#weights_reject_freq=1001
#ema_alpha=0.9998
#equidistant_point=1000
#num_sigmas_reject_badlabels=3
#badlabels_rejection_percentage=0.2

[convolutional]
batch_normalize=1
filters=32
size=3
stride=2
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=64
size=3
stride=2
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=64
size=3
stride=1
pad=1
activation=leaky

[route]
layers=-1
groups=2
group_id=1

[convolutional]
batch_normalize=1
filters=32
size=3
stride=1
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=32
size=3
stride=1
pad=1
activation=leaky

[route]
layers = -1,-2

[convolutional]
batch_normalize=1
filters=64
size=1
stride=1
pad=1
activation=leaky

[route]
layers = -6,-1

[maxpool]
size=2
stride=2

[convolutional]
batch_normalize=1
filters=128
size=3
stride=1
pad=1
activation=leaky

[route]
layers=-1
groups=2
group_id=1

[convolutional]
batch_normalize=1
filters=64
size=3
stride=1
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=64
size=3
stride=1
pad=1
activation=leaky

[route]
layers = -1,-2

[convolutional]
batch_normalize=1
filters=128
size=1
stride=1
pad=1
activation=leaky

[route]
layers = -6,-1

[maxpool]
size=2
stride=2

[convolutional]
batch_normalize=1
filters=256
size=3
stride=1
pad=1
activation=leaky

[route]
layers=-1
groups=2
group_id=1

[convolutional]
batch_normalize=1
filters=128
size=3
stride=1
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=128
size=3
stride=1
pad=1
activation=leaky

[route]
layers = -1,-2

[convolutional]
batch_normalize=1
filters=256
size=1
stride=1
pad=1
activation=leaky

[route]
layers = -6,-1

[maxpool]
size=2
stride=2

[convolutional]
batch_normalize=1
filters=512
size=3
stride=1
pad=1
activation=leaky

##################################

[convolutional]
batch_normalize=1
filters=256
size=1
stride=1
pad=1
activation=leaky

[convolutional]
batch_normalize=1
filters=512
size=3
stride=1
pad=1
activation=leaky

[convolutional]
size=1
stride=1
pad=1
filters=33
activation=linear

[yolo]
mask = 3,4,5
anchors = 10,14,  23,27,  37,58,  81,82,  135,169,  344,319
classes=6
num=6
jitter=.3
scale_x_y = 1.05
cls_normalizer=1.0
iou_normalizer=0.07
iou_loss=ciou
ignore_thresh = .7
truth_thresh = 1
random=1
resize=1.5
nms_kind=greedynms
beta_nms=0.6
#new_coords=1
#scale_x_y = 2.0

[route]
layers = -4

[convolutional]
batch_normalize=1
filters=128
size=1
stride=1
pad=1
activation=leaky

[upsample]
stride=2

[route]
layers = -1, 23

[convolutional]
batch_normalize=1
filters=256
size=3
stride=1
pad=1
activation=leaky

[convolutional]
size=1
stride=1
pad=1
filters=33
activation=linear

[yolo]
mask = 1,2,3
anchors = 10,14,  23,27,  37,58,  81,82,  135,169,  344,319
classes=6
num=6
jitter=.3
scale_x_y = 1.05
cls_normalizer=1.0
iou_normalizer=0.07
iou_loss=ciou
ignore_thresh = .7
truth_thresh = 1
random=1
resize=1.5
nms_kind=greedynms
beta_nms=0.6
#new_coords=1
#scale_x_y = 2.0

Hi @jkjung-avt, I figured out the issue is with recent changes done to yolo_layer.cu and plugins.py, the code is not correctly identifying the dynamic dimenstions. Ex: 640x480.
The current code works with symmetric dimensions. Ex:416x416
I tried running the latest code over AGX as well and it gave me the same assertion error, somehow input_multiplier is getting values like 42,21 (So it's a generic bug, not just for x_86 machines)
I ran with an older version of code on AGX and on RTX-3070, it worked fine for dynamic dimensions too.

@shivamordanny  Thanks for reporting this issue.  This is indeed a bug introduced by myself with the July 18 merge request.  It is now fixed with the f9f349 commit.
In addition, I also fixed some other issues for channels=1 (i.e. using grayscale images as inputs) custom models.  The latest code in the repo should work for your custom model now.

Great!!
The other fix was also needed, I used to change the channel parameters in onnx_to_tensorrt.py from 3 to 1 to get it working for grayscale images.
Closing this issue.


How to measure multiple points distance?

Hi @westnordost,
How can I measure multiple points distance in one frame.
As of now App is supporting only single direction distance.
My requirement is like, I am having four points AB, BC, CD, DA. I want to measure distance between all of them.
Could you please help me to achieve that .
Thanks

It is not possible with this app to measure multiple points distance.

Hi @westnordost,
If possible, could you please help me out to find or share code. Or how to implement multiple points measurement code in this repo.
I badly needed this.


adding rtl support

when I try to use this in rtl device the slider getting stuck and I can't move it.
react-native 0.60.4

I am the same issue too, Do you find any way to do that?

I have found that the npm package is not using the last repo version if you want to add rtl just copy the slider file content and added as a component in you project

You can use react-native-slider3 it is a fork of this library but with RTL support


Consider moving items Map in activity into state

Items Map is mutable collection. Kinda defeats the purpose of immutable state if kept outside. Keep items as a map in state and unpack into array for render.

Either way need to regen map on state mod to truncate.


Add Ternary for Displaying Placeholder If Book Lacks Cover

Sometimes the results from the API don't contain a cover image for the book. This means the BookItem just has a broken image link and displays the alt text. I would like a placeholder icon in place of the non-existent cover img. Maybe the ImageNotSupported icon from MUI could work. If you want to work in another ternary for the icon to have a "Placeholder icon: cover for [book.title] not found", that works.

Hi @livoszlak, I would like to work on this

@Sarveshk76 Absolutely! I'll assign you right away. Thank you! 🌷


Html

``

@ansari900 Is there anything you want me to look into? I'm not sure what to make of this ticket.


[v6 alpha 11] Theme Color change in KS does not work correctly for MD theme

Framework7 version: v6.0.0 alpha 11
Platform and Target: Mac 10.11.6 El Capitan with Safari 11.1.2 browser

Describe the bug
Theme color change from "Color Themes" page of KS included in f7 v6 alpha 11 does not work correctly for MD theme.
I think this is due to this recent change: https://github.com/framework7io/framework7/commit/8ec605996e4ed1652b5838ea82aaabad5e0993c6

Fixed in v6 branch