relay: create channel bindings and relay data

Here is a short demo:
Relay
You can run this locally using the ./run_smoke_test.sh shell-script. It is not reliable enough yet to be used in CI but I used one if its outputs to make a regression test.

Need to fix the tests and add some automated ones for the channel bindings. Once that is done, I'd like to merge this because it is  a really big PR already :)

The examples work (sometimes)! :D
Next step is writing some automated tests and make the examples reliable so that I can use them in CI as tests.

Btw, updated your base to latest cloud.

Modified steps I used to get this to run on aarch64 (e.g. Apple M1) under Docker:

Clone thomas's fork
Add aarch64-unknown-linux-musl target to rust/rust-toolchain.toml
docker run --rm -it -v $(pwd)/rust:/root rust:alpine
Then you can follow the steps inside that container:

apk add musl-dev
cargo build --target aarch64-unknown-linux-musl
RUST_LOG=relay=trace RELAY_LISTEN_IP4_ADDR=<IP_ADDRESS> RELAY_PUBLIC_IP4_ADDR=<IP_ADDRESS> cargo run --target aarch64-unknown-linux-musl --bin relay &
cargo run --target aarch64-unknown-linux-musl gateway &
cargo run --target aarch64-unknown-linux-musl client &

Still getting Connection refused though when running the gateway:
     Running `target/aarch64-unknown-linux-musl/debug/examples/gateway`
2023-05-20T19:26:32.347454Z TRACE relay: Received binding request from <IP_ADDRESS>:53396
2023-05-20T19:26:32.347507Z TRACE relay: Sending binding success response to <IP_ADDRESS>:53396
Our external address is <IP_ADDRESS>:53396
Error: Connection refused (os error 111)

Similar behavior running natively on macOS. I'm sure getting this running in Docker on GitHub CI should iron things out. It would be nice to be able to test locally with Docker Desktop on macOS/Windows (aarch64/x86_64)
Nice work!

Yeah it doesn't work with docker yet. I wasted about 3 hours trying to set up a docker-compose script but for some reason, it is still way to hard to get proper caching to work for docker images.
Hence I gave up on that for now. We are going to deploy this on Linux only anyway right? So I think having that tested in CI is a good starting point.
Have you tried running it locally without docker? Don't see a reason why that shouldn't work on Mac.

Have you tried running it locally without docker? Don't see a reason why that shouldn't work on Mac.

The relay started just fine, but the gateway and client both exit with Connection refused for some reason -- the same error I was getting in Docker (perhaps to no surprise). I tried with the macOS firewall both on and off with no change. In any case I agree with not wasting time getting it running on non-Linux platforms.
Once CI is working (and aarch64 target added) I'm sure it won't be a big hassle to test locally on Win/Mac/Linux.

Have you tried running it locally without docker? Don't see a reason why that shouldn't work on Mac.

The relay started just fine, but the gateway and client both exit with Connection refused for some reason -- the same error I was getting in Docker (perhaps to no surprise). I tried with the macOS firewall both on and off with no change. In any case I agree with not wasting time getting it running on non-Linux platforms.
Once CI is working (and aarch64 target added) I'm sure it won't be a big hassle to test locally on Win/Mac/Linux via Docker Desktop.

@jamilbk Did you start the redis container? That one is required as a signalling server (i.e. the job that the portal will fulfill).

This is now passing tests. I also added a short shell-script that you can use to run it locally. If you want to compile for a different architecture, set the TARGET variable accordingly. Requires docker to be installed and running.
I am no longer very happy with the design of the regression tests. I'll likely adapt them to smaller unit tests that don't depend on wire input because that is too cumbersome and nobody can read that anyway unless you natively speak HEX-encoding :)
But that is for a future PR. I think this is a good baseline to merge.

Have you tried running it locally without docker? Don't see a reason why that shouldn't work on Mac.

The relay started just fine, but the gateway and client both exit with Connection refused for some reason -- the same error I was getting in Docker (perhaps to no surprise). I tried with the macOS firewall both on and off with no change. In any case I agree with not wasting time getting it running on non-Linux platforms.
Once CI is working (and aarch64 target added) I'm sure it won't be a big hassle to test locally on Win/Mac/Linux via Docker Desktop.

@jamilbk Did you start the redis container? That one is required as a signalling server (i.e. the job that the portal will fulfill).

I did, but perhaps I needed to forward ports to expose it to the gateway/client on localhost. I'll give it another test after this is merged.

@thomaseizinger I think GH is complaining that some commits aren't signed. I'll override for now but you may want to double-check (unless the rebase somehow messed with it)

Aaayyyy getting promising output on macOS using run_smoke_tests.sh:
[  relay] 2023-05-23T00:32:05.590102Z  INFO relay: Listening for incoming traffic on UDP port 3478
[  relay] 2023-05-23T00:32:05.708230Z  INFO relay: Created new allocation for <IP_ADDRESS>:54520 on <IP_ADDRESS>:53432 and lifetime 600s
[ client] Allocated relay address: <IP_ADDRESS>:53432
[gateway] Our external address is <IP_ADDRESS>:53077
[ client] Retrieved gateway address: <IP_ADDRESS>:53077
[ client] Created channel to gateway
[  relay] 2023-05-23T00:32:05.825148Z  INFO relay: Bound channel 16384 between <IP_ADDRESS>:54520 and <IP_ADDRESS>:53077 on allocation AID-1
[gateway] Client's relay address is <IP_ADDRESS>:53077
[gateway] Sent ping to client: a77e490114e9813d0ea8a5ee59bdcb80416a9606281577430f414dd44f708a5c
[ client] Pushed relay address to gateway
[  relay] 2023-05-23T00:32:05.827380Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:53077 to <IP_ADDRESS>:54520 via channel 16384
[ client] Received buffer from <IP_ADDRESS>:53077: a77e490114e9813d0ea8a5ee59bdcb80416a9606281577430f414dd44f708a5c
[  relay] 2023-05-23T00:32:05.827825Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:54520 to <IP_ADDRESS>:53077 via channel 16384
[gateway] Received pong from client: a77e490114e9813d0ea8a5ee59bdcb80416a9606281577430f414dd44f708a5c
[gateway] Sent ping to client: 76c5b3166c7b1bc060f4f0f3f5a87a658b8bb03638f8dcbd658d89981342de2b
[  relay] 2023-05-23T00:32:05.880402Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:53077 to <IP_ADDRESS>:54520 via channel 16384
[ client] Received buffer from <IP_ADDRESS>:53077: 76c5b3166c7b1bc060f4f0f3f5a87a658b8bb03638f8dcbd658d89981342de2b
[  relay] 2023-05-23T00:32:05.880908Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:54520 to <IP_ADDRESS>:53077 via channel 16384
[gateway] Received pong from client: 76c5b3166c7b1bc060f4f0f3f5a87a658b8bb03638f8dcbd658d89981342de2b
[gateway] Sent ping to client: 838f0f48be69118f0a3237ecc2c748961ee24662ed353b7ddaea853dcc27b2a1
[  relay] 2023-05-23T00:32:05.933642Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:53077 to <IP_ADDRESS>:54520 via channel 16384
[ client] Received buffer from <IP_ADDRESS>:53077: 838f0f48be69118f0a3237ecc2c748961ee24662ed353b7ddaea853dcc27b2a1
[  relay] 2023-05-23T00:32:05.934124Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:54520 to <IP_ADDRESS>:53077 via channel 16384
[gateway] Received pong from client: 838f0f48be69118f0a3237ecc2c748961ee24662ed353b7ddaea853dcc27b2a1
[gateway] Sent ping to client: 2f7aa0582046c0128d33ce7847e99aced99a45b4d2d9dafeb8be80498a5e96c5
[  relay] 2023-05-23T00:32:05.986780Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:53077 to <IP_ADDRESS>:54520 via channel 16384
[ client] Received buffer from <IP_ADDRESS>:53077: 2f7aa0582046c0128d33ce7847e99aced99a45b4d2d9dafeb8be80498a5e96c5
[  relay] 2023-05-23T00:32:05.987231Z DEBUG relay: Relaying 32 bytes from <IP_ADDRESS>:54520 to <IP_ADDRESS>:53077 via channel 16384
[gateway] Error: deadline has elapsed
./relay/run_smoke_test.sh: line 6: 69995 Terminated: 15          $client 2>&1
     69996                       | sed "s/^/${RED}[ client]${NC} /"
./relay/run_smoke_test.sh: line 6: 69997 Terminated: 15          $relay 2>&1
     69998                       | sed "s/^/${GREEN}[  relay]${NC} /"

[gateway] Error: deadline has elapsed

I doesn't work every time unfortunately but you can try run it multiple times :)

@thomaseizinger I think GH is complaining that some commits aren't signed. I'll override for now but you may want to double-check (unless the rebase somehow messed with it)

Yep, that is due to rebasing. Rebasing changes the parent hash so the commit hash changes and thus the signature is void.


Spellfix extension on android

Hello,
I just want to know how exactly can i use spellfix extension on android?
i noticed that on iOS we should use:
sqlite3.ensureExtensionLoaded(SqliteExtension.staticallyLinked('sqlite3_spellfix_init'));
but what about android?
thank you

On iOS, you also need to add a dependency on sqlite3/spellfix to compile the module. On Android, we unfortunately can't really have a mechanism to make individual extensions available as modules.
You'd have to use the NDK to compile the spellfix extension as an additional shared library that you ship with your app. You can take a look at what I'm doing to compile sqlite3 on Android as a starting point. Then, you'd need to load that library and then use SqliteExtension.inLibrary to load it.


feat!: Implement BlobTx

Description
This PR is the core portion of the implementation of https://github.com/celestiaorg/celestia-app/issues/951
Leaving as a draft for now, but we can start the review process of this PR either now or after we break it up. The only thing left is to break it up into smaller chunks, as there a lot of different changes scattered across the repo. pls see #892 for more details.
Closes: #892

My feedback is primarily around naming

I was meant to explicitly ask for help on this! thx lol

I attempted to documented the transaction flow that is implemented in this PR with particular attention to the Tendermint mempool. I'd def appreciate your feedback @evan-forbes

opening this up for review, as I think we can begin proceeding with all of the changes required for removal of the wire tx. more PRs in the app and one more here are to follow

Do we use a CHANGELOG?

we just generate a default one in the release atm


Sign off

Signed-off-by: Samuel<EMAIL_ADDRESS>

Hi,
So I did a rebase to avoid signing of all my previous commits. Sorry If that is not the best way. Doing a rebase is what I found on stackoverflow.
Added functionalities :

If you want to test a subprogram but the sub program is passed a linkage section you would want to stub that part for the program to be able to run without dependences.

example:
 LINKAGE SECTION.
 COPY COPY002.
 PROCEDURE DIVISION.

TO
      * LINKAGE SECTION.

       COPY COPY002.

       PROCEDURE DIVISION.

You might declare SQL cursors within your working-section which will need to be stubbed

example:
           EXEC SQL
              DECLARE NAME-CUR CURSOR FOR
              SELECT FIRST_NAME, LAST_NAME FROM TEXEM
           END-EXEC.

TO
      *      EXEC SQL
      *        DECLARE NAME-CUR CURSOR FOR
      *        SELECT FIRST_NAME, LAST_NAME FROM TEXEM
      *      END-EXEC.

If you have SQL copybook you might want to use the variables within the copybook but discard other information.
example:

       EXEC SQL INCLUDE TEXEM  END-EXEC.

TO
       01  TEXEM.
           10 FIRST-NAME           PIC X(10).
           10 LAST-NAME            PIC X(10).
           10 TMS-CREA             PIC X(26).

@dakaa16
I didn't want to make a instant of reader in the generate class to use readAsOneStatement() that is why I created the getter()

Hi @dakaa16 I'll get those fixed in a bit :)

Done should be better :)

Hi @sam94dion
These changes were implemented in pull request https://github.com/openmainframeproject/cobol-check/pull/278
I am therefore closing this PR.
Thank you :-)


Logging

Complete use of logging; logs to job-specific file using morf_id (a unique hash of job configurations)


change cla branch

I have read the CLA Document and I hereby sign the CLA

Codecov Report

Merging #69 (7a20c59) into main (691308b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   89.89%   89.89%
=======================================
  Files          15       15
  Lines         366      366
=======================================
  Hits          329      329
  Misses         26       26
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691308b...7a20c59. Read the comment docs.

recheck


Use recommended rxjs import form

Importing 'rxjs/Rx' or 'rxjs' is not recommended. We should switch all imports to use the recommended form, which is import { Observable } from 'rxjs/Observable ';.

Doing this may cause problems in the Lab and Temperate; the improper imports in this project seem to be enabling functionality that wouldn't otherwise work in those projects. That's not a blocker, but all three will need to be tested.


Add dependency manager

Currently only SIMDJSON is used as a submodule. But in the future there may be other dependencies (for example, a third-party HTTP server or exclude getopt from the codebase).
Submodules are very inconvenient, not very effective, and tie the project to a version control system, which should not be the case.
Probably better solution will be use dependency manager. CPM is lightweight and written in pure CMake.

a good idea. Will try it when we will have more dependencies to justify and improve ROI

Besides CPM, there are Hunter and Conan.io .
But Conan.io in my opinion is not very convenient.
I didn't use Hunter, probably it's more flexible than CPM, but CPM written in pure CMake and mostly satisfies my requirements.

@rdementi, @opcm, which would you prefer to use?

I can try to integrate CPM, if you want.

@artiomn rdementi is supposed to be on vacation this week, don't make him work so hard ;-)

@artiomn rdementi is supposed to be on vacation this week, don't make him work so hard ;-)

Ok, I'm waiting. :-)

Thanks for volunteering!
I discussed it with @twillhal . Adding cmake/CPM.cmake would potentially require an internal review and approval. We will do it but unfortunately I can't give a timeline.

I can do this, if you approve this change.

adding CPM.make has been approved. It is now in the master branch: https://github.com/intel/pcm/blob/master/cmake/CPM.cmake


Unable to tap button using Selector during microsoftonline log in process

Is there an existing issue for this?

[X] I have searched the existing issues

Steps to reproduce
Created PatrolTest for logging into Android app using Active Directory log in process.
Shop code entered via app.
Microsoft Online account email created
Password entered
Microsoft Stay signed in? dialog box is displayed but unable to find or press any button or check box.
patrolTest('Check login works with valid store number',
        config: patrolConfig, nativeAutomatorConfig: nativeAutomatorConfig, nativeAutomation: true, (PatrolTester $) async {
      await initialiseStorage();
      await $.pumpWidgetAndSettle(const ProviderScope(child: MyApp()));
      // When
      await $.tester.shortToMediumPause();
      await $.tester.enterKeypadNumber('0043');
      await $.tester.clickNumberKeypadNextButton();
      await $.tester.shortToMediumPause();

      await $.native.enterTextByIndex('WxxxxDxxxxSxxxx13', index: 0);
      await $.native.tap(Selector(text: 'Sign in'));
      await $.native.pressBack();
      await $.native.enterTextByIndex('WxxxxDxxxxSxxxx13', index: 0);
      await $.native.tap(Selector(text: 'Sign in'));
      await $.native.pressBack();
      await $.native.enterTextByIndex('WxxxxDxxxxSxxxx13', index: 0);
      await $.native.tap(Selector(text: 'Sign in'));
      await $.native.tap(Selector(text: 'Yes'));

      await $.tester.doNotFindShopLoginConfirmationButtons();
    });

Actual results
The test purposely signs in 3 times to try and prove there is reliable interaction between PatrolTest and the sign in dialog boxes as well as using other native features like pressBack().
In the test when the line below is commented out the test passes, but when this line is uncommented the test fails:
await $.native.tap(Selector(text: 'Yes'));
The attached video runs the test twice. First run of the test, this test passes as the above line is commented out. The second run of the test fails as the Selector does not find the 'Yes' button.
PeterBriggsSelectorFailsv01.txt
Video0.webm
Logs

Logs
<!-- Replace this line with your logs. Do not remove the backticks! -->

[PeterBriggsSelectorFailsv01-verbose.txt](https://github.com/leancodepl/patrol/files/11213340/PeterBriggsSelectorFailsv01-verbose.txt)
Patrol version
patrol: ^1.0.8
patrol_CLI 1.1.3
Patrol Doctor output

Patrol Doctor output
<!-peterbriggs@Peters-MBP-2 gotg_apps_grecords % patrol doctor
Patrol CLI version: 1.1.3
Program adb found in /Users/peterbriggs/Library/Android/sdk/platform-tools/adb
Env var $ANDROID_HOME set to /Users/peterbriggs/Library/Android/sdk
Program xcodebuild found in /usr/bin/xcodebuild
Program ideviceinstaller found in /usr/local/bin/ideviceinstaller
Program ios-deploy found in /usr/local/bin/ios-deploy
>

Flutter Doctor output

Flutter Doctor output
<!-- peterbriggs@Peters-MBP-2 gotg_apps_grecords % fvm flutter doctor -v
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.2.1 22D68 darwin-x64, locale en-GB)
    • Flutter version 3.7.7 on channel stable at /Users/peterbriggs/fvm/versions/3.7.7
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (5 weeks ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc2)
    • Android SDK at /Users/peterbriggs/Library/Android/sdk
    • Platform android-33, build-tools 34.0.0-rc2
    • ANDROID_HOME = /Users/peterbriggs/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • macOS (desktop)              • macos         • darwin-x64     • macOS 13.2.1 22D68 darwin-x64
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 112.0.5615.49

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!
 -->

Hi, thanks for creating this issue, and sorry for the problems.
I can't really help you since the reproduction steps provided aren't reproduction steps – meaning, I can't just git clone your repo and run it on my machine to debug it. If you can't share the whole project (which you probably can't - totally understandable), then create a minimal, reproducible example instead.

Closing to not clutter the issues.

Hi @bartekpacia,
Thanks for your reply. I'm in the process of getting a small subset of our application which covers the problem running in a separate project & repo for you to investigate further.
Do you want me to open a new issue when I have the repo ready for you ??
Thanks

Thanks a lot for preparing the example repo - that is always of great help.
I reopened this issue, you can simply edit it with the new info :)

Will load the example repo on Monday (17APR23).

Hi @bartekpacia,
The link below is a link to my repository which contains an example app for you to run debug on.
https://github.com/PeterBriggsGreggs/sign-in-example-v01/tree/main/sign_in_example
Please note that the example in this repo does not find the Microsoft password field either by the   enterTextByIndex  or using the  enterText with a Selector. Whilst this is not exactly the same as the error in the video I attached to this call. I think it is very similar and if you are able to fix this issue I think it could also help with fixing the problem with tapping the  Yes   button on the Stay signed in?  dialog.
Please tell me if you have any problems or if you need me to do anything else.
Thank you for your help and support.
Kind regards

Hi @bartekpacia,
Just a quick follow up to ask whether you and the team have been able to investigate this issue further as yet ?
Thanks

Hi Peter, unfortunately I haven't yet had time to do it. I'm currently focusing on pushing a new 10x feature. After it's done, we plan to focus on bug bashing and overall stability :)

OK... Thanks for the update

Might be a duplicate of #1159

The link below is a link to my repository which contains an example app for you to run debug on.
https://github.com/PeterBriggsGreggs/sign-in-example-v01/tree/main/sign_in_example

This repository doesn't exist.

Closing - lack of response.


[WIP] Add away mode support for generic thermostat

Description:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#4202
Example entry for configuration.yaml (if applicable):
climate:
  - platform: generic_thermostat
    name: Study
    heater: switch.study_heater
    target_sensor: sensor.study_temperature
    away_temp_cool: 14
    away_temp_heat: 34

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Not sure I need to call the function in turn_away_mode_on and turn_away_mode_on or not.
self.schedule_update_ha_state()

Would be nice if you could also allow an option to link this directly to an entity providing home / away status. Most people group all device trackers under a "Presence" or "Family", so that could be used as trigger automatically without extra automation.
Unsure if it's realistic, but would make the component even more useful with default config only.

I've done a few more fixes and integrated part of your changes in this PR #11325
I will update documentation once people decide the pull request is ok considering I have some breaking changes to functionality on the way states are represented and one startup setting.


Unable to find PHP binary

Hi,
I'm not sure whether this is a plugin problem or something else, but I've run out of ideas.
I've migrated from another compose plugin to this but I'm unable to make it work as when I try to run any command, I get messages like this:
> Executing task: "/usr/local/bin/composer" diagnose -d '<path to my project>' <

env: php: No such file or directory
The terminal process "/usr/local/bin/zsh '-c', '"/usr/local/bin/composer" diagnose -d '<path to my project>''" terminated with exit code: 127.

Terminal will be reused by tasks, press any key to close it.

Path to composer is ok, I can execute it from VSCode's terminal (or any other terminal). php is in path.
I'm not quite sure what to set so that PHP is also recognised (but also unsure who needs the binary? is it the companion plugin?)
Thanks

Hello @andrei-dascalu, could you provide the following info?

Your OS
VSCode version (run code -v)
Composer version (run composer -V)
PHP version (run php -v)

Could you confirm that PHP is actually in the PATH env variable? Sometimes the binary is just named, for example, php71 and php (without the version) is missing.
You can also try setting the complete path to composer and php binaries in settings, respectively:

composerCompanion.executablePath
php.validate.executablePath

Changing the setting terminal.integrated.persistentSessionReviveProcess to never may help if the above didn't.

closing due to inactivity, reopen if necessary


Documentation:  Update Roxygen Examples with library(pkg_name) rather than pkgname::function()

Please select a category the issue is focused on?
Function Documentation
Let us know where something needs a refresh or put your idea here!
Update all functions with roxygen examples using the pkgname::function() way.
See #1235 for additional guidance and discussion,

02Nov2022: confirmed in our standup meeting that we want Roxygen examples to use library(pkgname) and function() instead of pkgname::function() in Roxygen examples. Note that this is the opposite of what is needed in unit tests (testthat folder).

@esimms999-gsk Triple colons allow you to access objects in a package that are not exported to the Namespace.  https://stat.ethz.ch/R-manual/R-devel/library/base/html/ns-dblcolon.html


Ping Frames with no data

These are the relevant spec sections:
https://tools.ietf.org/html/rfc6455#section-5.2
https://tools.ietf.org/html/rfc6455#section-5.3
The spec says that the mask key must not influence the payload data and length. From the section "5.2. Base Framing Protocol", you can see that the masking key is meant to be optional.
So I think the library has currently an incorrect behaviour for the ping frames, assuming that ping frames can be sent without any data. (I might be wrong, please correct me if so!)
The issue is in line 235 in WebSocketFrame.js:
    var output = new Buffer(this.length + headerLength + (this.mask ? 4 : 0));

The output buffer will be longer than its data (because this.length is 0 in an empty ping frame with no payload data), because the mask will never be written in it.
So the current behaviour is that it might get asynchronous by the 4 bytes of the mask if an empty ping frame is sent.

According to Section 5.2 of the specification, all frames from client to server have the mask bit set to 1:
   Mask:  1 bit

      Defines whether the "Payload data" is masked.  If set to 1, a
      masking key is present in masking-key, and this is used to unmask
      the "Payload data" as per Section 5.3.  All frames sent from
      client to server have this bit set to 1.

That means that it is not optional.  Ping frames from client to server with no payload will still always have a 4-byte mask.  It's true that later on in the code that those last 4 bytes are not written if the payload length is zero, but that won't cause loss of sync in the parser on the receiving end, because there will be four bytes there where it's expecting to find the mask key.  Those bytes will be uninitialized, and so will be random bytes from the heap.  So while that won't cause any errors, and is correct behavior according to the spec, that's actually a potential security vulnerability, as the contents of four bytes of random memory locations will be transmitted with each ping.

I don't think this is a high-priority security issue, however, because it only applies when using Node as a WebSocket client, not as a server, because servers don't mask any frames sent to the client.  Comparatively few people, to the best of my knowledge, are using node as a WebSocket client to connect to an untrusted or potentially malicious server over a public network.

Fixed and released as v1.0.16


foliate: 3.1.0 -> 3.1.1

Description of changes
Update foliate: 3.1.0 -> 3.1.1. Relevant issue https://github.com/NixOS/nixpkgs/issues/301398
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 301770 run on x86_64-linux 1

1 package built:

foliate


modulo flag not added for "0001" time axis

Reported by Jonathan S Callahan on 10 Apr 2003 20:31 UTC
According to the Ferret v5.3/4 release notes, the modulo flag should be added
to any netCDF time axis encoded as year 0000 or 0001:
http://ferret.pmel.noaa.gov/Ferret/Documentation/Release_Notes/v53_v54.html#NetC
DF modulo
This doesn't seem to be the case as exemplified by the following session.
    NOAA/PMEL TMAP
    FERRET v5.51
    Solaris 5.8 - 02/28/03
    10-Apr-03 13:29

yes? use "http://www.cdc.noaa.gov/cgi-bin/nph-
nc/Datasets/ncep.reanalysis.derived/tropopause/air.mon.ltm.nc"
yes? set region/x="190":"200"/y="40":"50.0"/z="200.00":"200.00"/t="01-Aug-
0000 ":"01-Aug-0000 "
yes? show axis time
name       axis              # pts   start                end
TIME      TIME                12 i   01-JAN      00:00    01-DEC      00:00
T0 = 01-JAN-0001 00:00:00
Axis span (to cell edges) = 8748
yes? set axis/modulo time
yes? show axis time
name       axis              # pts   start                end
TIME      TIME                12mi   01-JAN      00:00    01-DEC      00:00
T0 = 01-JAN-0001 00:00:00
Axis span (to cell edges) = 8748 (modulo length = axis span)
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/529

Comment by<EMAIL_ADDRESS>on 12 May 2003 17:44 UTC
fixed and checked in 3/31/03  in cd_get_1_axis.F


Pagination fails when data is in a $scope variable

My data is in $scope, as in $scope.data, Pagination seems to be working, as in the no. of pages in the footer are correct, but instead of being split into pages, entire list is displayed,
Here is the code : http://plnkr.co/edit/exzi2J?p=preview

You need to change this line:

... to:

Notice the $ in front of the data


VhdTransformer: use vhd_path

use vhd_path instead of custom_blob_name because the custom blob name is not always provided.

Corrects a mistake in #3546


Pick_Channels Returns AttributeError: 'NoneType' object has no attribute 'items

Description of the problem
Hello,
I am trying to select a subset of the channels in my Raw instance using the pick_channels function. However,  it appears that the Raw instance has orig_units set to None, causing an error. Despite this, I'm actually still able to select the subset as the error seems to occur after the issue has happened. I'm able to get around this by using try... except, but I wanted to alert the team of this possible error.
For reference, this raw instance was created by reading from NKT file, accessing the data and filtering it directly, and then making a new raw file with the filtered data. Here is what the workflow looks like:
# load data from test_file
raw = mne.io.read_raw_nihon(test_file, preload=True

# filter data
arry = raw.get_data()
filtered_arry = utils.filter_eeg(arry, fs=fs, l_freq=l_freq, h_freq=fs/2-h_freq_cap, notches=fnoises).T # custom sos filter
new_raw = mne.io.RawArray(filtered_arry, raw.info)
new_raw.set_annotations(raw.annotations)

# select subset of channels
eeg_channels = ['Fp1', 'Fp2', 'F3', 'F4', 'C3', 'C4', 'P3', 'P4', 'O1', 'O2', 'F7', 'F8', 'T3', 'T4', 'T5', 'T6', 'Fz', 'Cz', 'Pz', 'T1', 'T2']
raw_copy = new_raw.copy()
raw_copy.pick_channels(eeg_channels)

Error message:
AttributeError                            Traceback (most recent call last)
/home/roy/Desktop/github/mTBI_FITBIR/notebooks/feature_engineering_scratchwork.ipynb Cell 18 in <cell line: 2>()
      [1](vscode-notebook-cell://ssh-remote%2Bdestroyer.ece.rice.edu/home/roy/Desktop/github/mTBI_FITBIR/notebooks/feature_engineering_scratchwork.ipynb#X22sdnNjb2RlLXJlbW90ZQ%3D%3D?line=0) eeg_channels = ['Fp1', 'Fp2', 'F3', 'F4', 'C3', 'C4', 'P3', 'P4', 'O1', 'O2', 'F7', 'F8', 'T3', 'T4', 'T5', 'T6', 'Fz', 'Cz', 'Pz', 'T1', 'T2']
----> [2](vscode-notebook-cell://ssh-remote%2Bdestroyer.ece.rice.edu/home/roy/Desktop/github/mTBI_FITBIR/notebooks/feature_engineering_scratchwork.ipynb#X22sdnNjb2RlLXJlbW90ZQ%3D%3D?line=1) raw_copy.pick_channels(eeg_channels)

File <decorator-gen-47>:12, in pick_channels(self, ch_names, ordered, verbose)

File ~/anaconda3/envs/jupyterEnv/lib/python3.10/site-packages/mne/channels/channels.py:682, in UpdateChannelsMixin.pick_channels(self, ch_names, ordered, verbose)
    647 """Pick some channels.
    648
    649 Parameters
   (...)
    679 .. versionadded:: 0.9.0
    680 """
    681 picks = pick_channels(self.info['ch_names'], ch_names, ordered=ordered)
--> 682 return self._pick_drop_channels(picks)

File <decorator-gen-49>:12, in _pick_drop_channels(self, idx, verbose)

File ~/anaconda3/envs/jupyterEnv/lib/python3.10/site-packages/mne/channels/channels.py:834, in UpdateChannelsMixin._pick_drop_channels(self, idx, verbose)
    831 if isinstance(self, BaseRaw):
    832     self.annotations._prune_ch_names(self.info, on_missing='ignore')
    833     self._orig_units = {
--> 834         k: v for k, v in self._orig_units.items()
...
    835         if k in self.ch_names}
    837 self._pick_projs()
    838 return self

AttributeError: 'NoneType' object has no attribute 'items'

Steps to reproduce
# load data from test_file
raw = mne.io.read_raw_nihon(test_file, preload=True

# filter data
arry = raw.get_data()
filtered_arry = utils.filter_eeg(arry, fs=fs, l_freq=l_freq, h_freq=fs/2-h_freq_cap, notches=fnoises).T # custom sos filter
new_raw = mne.io.RawArray(filtered_arry, raw.info)
new_raw.set_annotations(raw.annotations)

# select subset of channels
eeg_channels = ['Fp1', 'Fp2', 'F3', 'F4', 'C3', 'C4', 'P3', 'P4', 'O1', 'O2', 'F7', 'F8', 'T3', 'T4', 'T5', 'T6', 'Fz', 'Cz', 'Pz', 'T1', 'T2']
raw_copy = new_raw.copy()
raw_copy.pick_channels(eeg_channels)

### Link to data

_No response_

### Expected results

Should just run without error

### Actual results

AttributeError: 'NoneType' object has no attribute 'items'

### Additional information

Output exceeds the [size limit](command:workbench.action.openSettings?%5B%22notebook.output.textLineLimit%22%5D). Open the full output data[ in a text editor](command:workbench.action.openLargeOutput?2463ca9b-cc87-428b-888e-90d4e994d2b9)
Platform:         Linux-5.15.0-48-generic-x86_64-with-glibc2.35
Python:           3.10.4 | packaged by conda-forge | (main, Mar 24 2022, 17:38:57) [GCC 10.3.0]
Executable:       /home/roy/anaconda3/envs/jupyterEnv/bin/python
CPU:              x86_64: 64 cores
Memory:           1006.6 GB

mne:              1.2.1
numpy:            1.21.1 {OpenBLAS 0.3.20 with 64 threads}
scipy:            1.8.1
matplotlib:       3.5.2 {backend=module://matplotlib_inline.backend_inline}

sklearn:          1.1.1
numba:            0.55.1
nibabel:          3.2.2
nilearn:          0.9.1
dipy:             1.5.0
openmeeg:         Not found
cupy:             Not found
pandas:           1.4.4
pyvista:          0.34.0 {OpenGL could not be initialized}
pyvistaqt:        0.9.0
ipyvtklink:       0.2.2
vtk:              9.1.0
qtpy:             2.2.0 {PyQt5=5.15.3}
ipympl:           0.9.2
...
mne_features:     Not found
mne_qt_browser:   0.3.1
mne_connectivity: Not found
mne_icalabel:     Not found

Hello, thank you for reporting the issue.
Could you share a file that raises this error, otherwise it will be difficult to reproduce?
Also, could you try in an environment running the latest development version. You can install it with:
$ pip install git+https://github.com/mne-tools/mne-python

I think this bug was already fixed in #11160

Or running the latest stable version, 1.2.0 or 1.2.1, the fix should be released already.

Hi, thank you for the response.
My mne version is up to date at 1.2.1. However, while trying to create a simple code to replicate the issue, I figured out the issue seems to be due to the pickle saving protocol. Saving the files as .fif format seems to fix it, even after loading with pickle, but since I'm working with a lot of raw files I have been opting to save entire lists of raw files at once with pickle.
Here is my code that reproduces the error. I'm not sure how to upload my data file, but I suspect that saving any raw file with pickle could yield the same error.
import mne
import pickle
# load data
sample_file = '/home/roy/Desktop/github/mTBI_FITBIR/sample_data/raw_sample.pickle'
with open(sample_file, 'rb') as f:
    raw_sample = pickle.load(f)
# select subset of channels
eeg_channels = ['Fp1', 'Fp2', 'F3', 'F4', 'C3', 'C4', 'P3', 'P4', 'O1', 'O2', 'F7', 'F8', 'T3', 'T4', 'T5', 'T6', 'Fz', 'Cz', 'Pz', 'T1', 'T2']
raw_copy = raw_sample.copy()
print(raw_copy.ch_names)
raw_copy.pick_channels(eeg_channels)

Oh, most likely yes and someone might be able to pinpoint what went wrong, but that would take me too long to figure out. Pickle is not a long-lasting format, as such it is not supported by MNE and I can't recommend using it.
If you have many recordings to work with, you should define a clear naming schema that can be programmatically generated. For instance, if you have multiple subjects, multiple sessions and multiple runs per session, you could define a file name as:
sub_idx = 123
ses_idx = 1
run_idx = 5
f"sub-{str(sub_idx).zfill(3)}_ses-{str(ses_idx).zfill(2)}_run-{str(run_idx).zfill(2)}-raw.fif"
# >>> "sub-123_ses-01_run-05-raw.fif"

Or you could use the BIDS standard and mne-bids which will handle the file location/name.


Replaced Visibility with VisibilityLevel in Webhooks

GitLab doesn't return Visibility with string type anymore. It returns VisibilityLevel with int type.

@svanharmelen Can you please review this?

@smit-modi we've migrated the repository over to GitLab.com.
Please see https://github.com/xanzy/go-gitlab/issues/2060#issuecomment-2532116371 for more context.


Improvements to PrintMatlab [print-matlab]

Make Operator::PrintMatlab virtual, and output zero entry in last row and column to preserve matrix size.
Resolves #2515.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#2578
@pazner
@tzanio
@tzanio + @bslazarov
09/28/21
⌛due 10/12/21
⌛due 10/19/21

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Thank you, Will!
Would it be possible to leave a comment in blockmatrix.cpp and sparsemat.cpp to explain why we write the 0.0 to the output file? I think it would make it easier for others to understand.

Would it be possible to leave a comment in blockmatrix.cpp and sparsemat.cpp to explain why we write the 0.0 to the output file? I think it would make it easier for others to understand.

Sure, I added a short comment in both places.

Thanks a lot!

Sure, I added a short comment in both places.

Merged in next for testing...

Perhaps a comment can be provided to recommend to users how to make use of this function, maybe specifically pointing them to load + spconvert.


Use  instead of  for string properties

To better handle larger amounts of text in strings it would be better to switch to a textarea that can be scaled vertically to show more text.
To optimize the height of the textarea it should scale automatically according to how much text is currently entered.
Example: https://codepen.io/vsync/pen/czgrf
To not got overboard with ∞ text length, a maximum should be defined where the textarea can be scrolled.

Solved via push of #586


Change condenser to normalize algebraic expressions

The condenser should "normalize" algebraic expressions:

It should perform computations on constants (done in the evaluator in a pending PR)
It should pull ' operators across linear operators to the inside until they reach a column
It should also be the responsibility of this component to detect double applications of ' and so on.

Just a quick thought: If we implement elements of an extension field as a user-defined type, then maybe this normalization could be a trait on the extension field type which then returns an expr (or a pair of exprs).
We could also implement the whole normalization described in the issue here inside pil.
So maybe in the end, the type we want to have at constraint / statement level is anything that implements
trait ToConstraint<T> {
  to_constraint: T -> constr[],
}


Create a page to display all the shorcuts

Just get a reference to command manager, it's getCommands() method provides all the registered commands. Iterate through all the command defs and generate the shortcut list in a table. We need to add an additional property to command defs to carry a description about each command. ATM, a command def looks like below.
           command: {
                id: "undo",
                shortcuts: {
                    mac: {
                        key: "command+z",
                        label: "\u2318Z"
                    },
                    other: {
                        key: "ctrl+z",
                        label: "Ctrl+Z"
                    }
                }
            }

Moved back from https://github.com/ballerina-lang/composer/issues/351

Composer is discontinued hence closing the issue.


2022.8: convert async_setup_platforms to async_forward_entry_setups

https://developers.home-assistant.io/blog/2022/07/08/config_entry_forwards/
deadline for this change is 2022.12

Had to revert the change, as it was causing synchronization issues with sending over the network (sockets were getting closed and removed from the device in between checking if the socket was available and closing it.


Yaw Damper implementation

The yaw damper combats adverse yaw. It is a washout filter that counteracts the high frequency yaw resulting from the adverse yaw.

The yaw damper is implemented. I also changed the saturation code to warn you of bad input. Perhaps this is something we should put in the style guide? Essentially if you create a function it should warn about invalid input?
In any case the yaw damper works and is integrated. It is VERY reliant on matching the Aerodynamic coefficients if the washout filter gain y_kr and filter bandwidth p_wo to work. (See the UAV book chapter 6 section on Yaw Damper for more). We should at some point add documentation on how to tune yaw damper in the absence of a good aero model.


Can't link helloworld from examples on MacOS..

Update: Brew install gives the same error.
Note: i just checked for libressl, and it wasn't installed. Tried to install through macports, but there was openssl conflict. Could this be causing it. OpenSSL is needed by many other installs so i couldn't deactivate. I will try through brew..
Sorry, i see similar issues, but i didn't want to add this to them, in case they were related to something different..
ponyc --version
0.9.0-490e818 [release]
compiled with: llvm 3.8.1 -- Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Xcode: 8.1
Gina-Haggs-MacBook-Pro:ponyc ginahagg$ ponyc examples/helloworld
Building builtin -> /usr/local/lib/pony/0.9.0-490e818/packages/builtin
Building examples/helloworld -> /Users/ginahagg/pony/ponyc/examples/helloworld
Generating
Reachability
Selector painting
Data prototypes
Data types
Function prototypes
Functions
Descriptors
Optimising
Writing ./helloworld.o
Linking ./helloworld
Error:
unable to link: ld -execute -no_pie -dead_strip -arch x86_64 -macosx_version_min 10.8 -o ./helloworld ./helloworld.o -L"/usr/local/lib/pony/0.9.0-490e818/bin/" -L"/usr/local/lib/pony/0.9.0-490e818/bin/../lib" -L"/usr/local/lib/pony/0.9.0-490e818/bin/../packages" -L"/usr/local/lib" -L"/opt/local/lib"  -lponyrt -lSystem

Which version of xcode do you have installed?

Xcode: 8.1

And how did you install ponyc?
If you build using ponyc -d, do you get the same error?

i installed ponyc first with Brew. When that didn't link, i cloned from GitHub and built it. But i realized i was missing libressl, so i tried to do a port install, but couldn't due to openssl conflict. So i went back to Brew and do the whole Brew install again..(and all the required libraries through Brew).
Saying that i am sure it is something in my environment, hopefully this weekend i will be able to trace the problem. I will let you know what is happening..Thank you!!

@ginahagg have you installed the XCode command line tools? If not, give that a try.
xcode-select --install

@ginahagg sorry for the long delay. work things have been cutting into pony OSS time.
What version of OSX are you using Sierra?
I can't reproduce this.
@Theodus is going to check out on Sierra under the assumption that you are using Sierra.

I cannot reproduce this on MacOS Sierra with LLVM 3.9.0 and Xcode 8.1

sorry, i also didn't have much time. i will work on it today. Yes, it is sierra and i have command tools installed as first thing always. I will get back to you. :) Thank you so much..

Hi, after doing bunch of brew doctor's and prune's and cleaning up, I got it to work. Thank you so much for all your help. I will close this issue now.


Issue #502 - Create separate page for Field reported data

Added a tab called 'View Data' to both the Admin and Volunteer UI.
Added one new page, 'ListResourceCheckinsByDisaster'.  This was pretty much an exact copy of 'ListByDisaster'.
Added one new partial, _FilterResourceCheckinResults. This uses the same view model, CheckinListsResultsViewModel, as _FilterResults.  However, the VolunteerCheckins and OrganizationContacts are just empty lists and are not used in _FilterResourceCheckinResults.cshtml.
Created two new controller actions in the Volunteer controller: ListResourceCheckinsByDisaster and FilterResourceCheckins. I thought this was an awkward place to put them.  I was tempted to place these methods in a new controller, but I think a better time to do that would be after point  1 on Issue #500 is completed.
Removed the 'Field Data' (ResourceCheckins) section  from the 'View Checkins' Page. Left the ResourceCheckins property on the CheckinListsResultsViewModel, however only an empty list of ResourceCheckins is returned to the 'View Checkins' Page.
There was a slight bug in MenuExtensions.cs that would highlight all tabs instead of the one selected that should be fixed.
There was a small bug where the Volunteer tabs would show before login that should be fixed.  I probably should have rolled that into another pull request.  I did not realize that was already issue #606.

After a bit more consideration, this is obviously not the place to fix the bug where the Volunteer tabs would show before login that should be fixed.  There is a much better way to fix that.  I will remove that change and open another pull request that addresses #606.

@andrewhart098 Thanks for your contribution.  I reviewed the code this morning, and this looks great.
I'm reading your comment above, and I want to make sure you've finished the work you described in the 2nd comment. (It looked that way to me, but I want to make sure.)
Once you reply that both are ready, I'll merge them in.

Hi Bill. Happy to contribute.  Yes, I have finished the work described in my second point.


Incorrect cursor position in RTL TextField

Steps to reproduce
Hello everyone, I am facing a problem with the TextField and the TextFormField widget when I set the app language to an RTL language.
When I try to enter the password, the cursor position is wrong
i think this issue is same like this https://github.com/flutter/flutter/issues/110416
Expected results
Position of the cursor at rtl language is on right side of textinput
Actual results
Position of the cursor at rtl language is on left side of text input
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:flutter_localizations/flutter_localizations.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      locale: const Locale("ar"),
      localizationsDelegates: const [
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate,
      ],
      supportedLocales: const [Locale("ar")],
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: const Center(
        child: Padding(
          padding: EdgeInsets.all(16),
          child: TextField(),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]
https://github.com/flutter/flutter/assets/16118227/50b53b66-c9d5-46c8-986d-1fcc008f166e

Flutter Doctor output
Doctor output

Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.16.5, on macOS 14.2.1 23C71 darwin-x64, locale ru-RU)
    • Flutter version 3.16.5 on channel stable at /Users/romanreed/flutter
    ! Warning: `dart` on your path resolves to /usr/local/Cellar/dart/3.0.5/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/romanreed/flutter. Consider adding
      /Users/romanreed/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 78666c8dc5 (3 weeks ago), 2023-12-19 16:14:14 -0800
    • Engine revision 3f3e560236
    • Dart version 3.2.3
    • DevTools version 2.28.4
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/romanreed/Library/Android/sdk
    • Platform android-34, build-tools 33.0.0
    • ANDROID_HOME = /Users/romanreed/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C65
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (3 available)
    • iPhone 14 (mobile) • D9F64614-F08E-4E2E-8CED-2983A577CFC9 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64     • macOS 14.2.1 23C71 darwin-x64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 120.0.6099.199

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Expected results
Position of the cursor at rtl language is on right side of textinput

Could you elaborate on the expected behavior? Since the paragraph's writing direction is RTL, it should be placed on the left side otherwise it weakens the password security by revealing the bidi properties of the password right?

@LongCatIsLooong If you try to enter a password in the ltr locale you will see this
https://github.com/flutter/flutter/assets/16118227/9a338d89-3999-4015-bc22-c34ae94117bc
but in the rtl language
https://github.com/flutter/flutter/assets/16118227/6c86ac98-408c-4b19-a633-eb3e5c1340f7
Expected results:
when you enter a password with the obscure position the cursor must be on the right side of textinput

@romreed I think this is similar to https://github.com/flutter/flutter/issues/71318 which had a correct sample code reproducing the issue (your sample code above is missing some TextField attributions: obscureText, textDirection). Could you confirm this?

@huycozy i think similar


[Enhancement] Option-click on menu bar icon to trigger capture

Per title, option-click on the TRex menu bar icon to trigger capture mode (or another default action, configured within settings).

Amazing! Thanks

There seems to be a minor bug with the option key graphic (at least on macOS 14.7.1)

@Mateus109 thanks, fixed in 1.8.1


Getting a Field Integrity Exception

Hey guys,
I'm starting the design for a Jira integration app, so decided to use SLDS.
I just installed the unmanaged package and followed the tutorial to create a new Aura app, but when I try to save, I get:
Failed to save undefined: No COMPONENT named markup://sldsx:button found: [markup://c:JiraLightning]: Source
<aura:application access="GLOBAL">
	<ltng:require styles="/resource/sldsx/assets/styles/salesforce-lightning-design-system-vf.css"/>

        <sldsx:button type="neutral">Button</sldsx:button>

</aura:application>

Any thoughts?
Paul

Hi,
I am getting the same error. Were you able to get around this ?

Hey @webtop and @vinodr - the readme is a little inaccurate. Assuming your org isn't namespaced, just use "c" instead of "sldsx" for component prefixes. So, using the above example, it should be:

        <c:button type="neutral">Button</c:button>

If you do have your own namespace set, then use that as the prefix instead. More info here: https://developer.salesforce.com/docs/atlas.en-us.lightning.meta/lightning/namespaces_intro.htm

Thanks, I'll give that a go.


Added some more themes

Looks good to me at a first glance. I will test everything tomorrow and merge it since it is very late at night right now.

Hello again just woke up,
I also saw that you added a way for void users to install gowall , pretty cool :)
have you tested it to make sure it works? I really have no idea how void does their stuff
( spin up a quick vm and check on a fresh install if you haven't please )
I also saw you fixed the internal links , im guessing now it takes you to correct section, good job.
One change i would want is to please add a Community themes section under the Theme section so the users dont get overwhelmed by the amount of themes
ex.

Tokyo-moon
Onedark

Community Themes (emoji to convey something along the lines of a theme)

Monokai
Material
Atom One Light
Sweet
Synthwave 84
Atom Dark
Oceanic Next
Shades of Purple
Arc Dark
Sunset Aurant
Sunset Saffron
Sunset Tangerine

Just finished testing your PR
Everything is fine except for the sweet theme which produces really bad images so i would like to remove it. ( You can see the 3 examples below )
Example 1: https://freeimage.host/i/dTILp0G
Example 2: https://freeimage.host/i/dTIQvkl
Example 3: https://freeimage.host/i/dTIZHEg
I plan to merge a PR soon which will allow anyone to just pass a config of a theme so future users can just use whatever theme they like.
As soon as you remove the sweet theme and give me the okay that the void installation of gowall works i will merge this

Thank you for contributing :0 !

Hello again just woke up,
I also saw that you added a way for void users to install gowall , pretty cool :) good job have you tested it to make sure it works? I really have no idea how void does their stuff ( spin up a quick vm and check on a fresh install if you haven't please , unless you installed gowall on your void install this way)
One change i would want is to please add a Community themes section under the Theme section so the users dont get overwhelmed by the amount of themes
ex.

Tokyo-moon
Onedark

Community Themes (emoji to convey something along the lines of a theme)

Monokai
Material
Atom One Light
Sweet
Synthwave 84
Atom Dark
Oceanic Next
Shades of Purple
Arc Dark
Sunset Aurant
Sunset Saffron
Sunset Tangerine

Did the testing everything works fine.

Mad a new PR.


Plotting Components Plugin

A plugin for handling Components Plotting that uses PlottingInterface
this includes

Making the ComponentInspector plugin items are dragable to be dragged into the plotting interface

Making a gazebo-plugin to handle charts subscription to that components and updates the plotting interface

This class diagram shows the design and the integration between it and plotting interface

Features worked really well. Just a small comment. After it's resolved then I think this PR will be ready.
 $ ign gazebo levels.sdf
free(): invalid pointer

invalid pointer warning upon shutdown. I believe this is introduced by the plotting.cc/hh code after cross comparing with the master branch and testing the ComponentInspector code only.


Update markdown

Perhaps this will fix #55413

@Potapy4 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@potapy4 Thanks for this pull request. It looks like the fix has already been applied and is in master. We'll close this PR.


[top_darjeeling] Top level block diagram

desc
Create top level block diagram for Darjeeling

Please see block diagram and integration diagram

This has been done here (restricted audience for now).


Feature/redirect after comment login

Description
This PR resolves an issue on the blog site that comes up when a user that's not logged in tries to comment on a blog post as seen on issue #323
The changes made would login a user, and redirect to the comments-section.
It also addresses #290
Changes Made

[ ] Added new feature
[x] Fixed bug
[ ] Refactored code
[ ] Other (please describe):

Test Plan
I ran the tests on the READme
Checklist

[x] I have read the contributing guidelines
[ ] I have added tests to cover my changes and they all pass in addition to the existing tests.
[ ] I have added documentation for my changes (if appropriate)

Great work!


Improve remote abandonment

Harvesters and haulers should not be sent to a franchise with one or more danger creeps, or where room is reserved by hostile
Reservers should not be sent to a franchise with one or more danger creeps
Remote defenders should be sent to franchises with one or more danger creeps, unless the detected hostile force is stronger
Civilian creeps should avoid pathing through rooms with one or more danger creeps

Making progress; however, cost tracking currently only kicks in if the franchise is active (has been harvested). In certain edge cases where a harvester never makes it to the source (e.g. pathing failure) the remote will not be correctly abandoned. We need to track costs when there has been an active harvesting mission, rather than when the remote has been actively harvested.


Update apps_using_this_library.md

Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I have resolved any merge conflicts.
[x] I have followed the coding style, and reviewed the contributing guidelines. Confirmation: ____

This fixes issue
What's in this pull request?

Current coverage is 64.25% (diff: 100%)

Merging #1896 into release_7.3 will increase coverage by 1.59%

@@           release_7.3      #1896   diff @@
=============================================
  Files               63        106     +43
  Lines             2378       3458   +1080
  Methods            643        866    +223
  Messages             0          0
  Branches           153        195     +42
=============================================
+ Hits              1490       2222    +732
- Misses             812       1147    +335
- Partials            76         89     +13

Powered by Codecov. Last update 929f1d8...2669123

@jessesquires ops, wrong base branch. Sorry.

@Lucashuang0802 -- let's cherry-pick this into develop

@jessesquires appreciate it.


The relationship between Install instructions section 'How to use' and 'Build executables'

I was a little confused when I go over the instructions for sections 'How to use' and 'Build executables'. Is the latter necessary if I want to open it through the command line? Would be great if you can add some lines explaining the relationship between these two parts, or more specifically, when will a person follows the instructions under the section 'Build executables'.

No, the last part is not needed to run eVAS from the command line. If you have set up everything related to the Python section, then python eVAS.py is sufficient to run eVAS from the command line.
Building executables can be useful when researchers have modified the code for whatever reason (maybe their own specific project?) and want to create standalone executables as they can be easier to use.
I have updated the README file slightly to have more information on this (commit).
Should I add more information?

looks good to me! thanks


Feature Request: Command line compatibility

I also do love the idea of creating a lightweight CLI tool to interact with lrclib instead of a clunky webview-based app. But for the moment you may find some good CLI tools for finding lyrics at https://github.com/topics/synced-lyrics


python311Packages.stripe: 8.6.0 -> 8.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.stripe is: Stripe Python bindings
meta.homepage for python311Packages.stripe is: https://github.com/stripe/stripe-python
meta.changelog for python311Packages.stripe is: https://github.com/stripe/stripe-python/blob/v8.8.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.8.0 with grep in /nix/store/dx8i7i9w31lhmy5r2wr1fiqw9gpdq0sh-python3.11-stripe-8.8.0
found 8.8.0 in filename of file in /nix/store/dx8i7i9w31lhmy5r2wr1fiqw9gpdq0sh-python3.11-stripe-8.8.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
gigalixir
khoj
python311Packages.stripe
python312Packages.stripe
sourcehut.metasrht

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dx8i7i9w31lhmy5r2wr1fiqw9gpdq0sh-python3.11-stripe-8.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.stripe https://github.com/r-ryantm/nixpkgs/archive/4791d06dbb28ef8a188bb921bc39f01951351adc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4791d06dbb28ef8a188bb921bc39f01951351adc#python311Packages.stripe

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dx8i7i9w31lhmy5r2wr1fiqw9gpdq0sh-python3.11-stripe-8.8.0
ls -la /nix/store/dx8i7i9w31lhmy5r2wr1fiqw9gpdq0sh-python3.11-stripe-8.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages failed to build:

khoj
khoj.dist
sourcehut.metasrht
sourcehut.metasrht.dist

6 packages built:

gigalixir
gigalixir.dist
python311Packages.stripe
python311Packages.stripe.dist
python312Packages.stripe
python312Packages.stripe.dist

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.stripe is: Stripe Python bindings
meta.homepage for python311Packages.stripe is: https://github.com/stripe/stripe-python
meta.changelog for python311Packages.stripe is: https://github.com/stripe/stripe-python/blob/v8.9.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.9.0 with grep in /nix/store/z4197skfwm0s7mj4rq5milyyvw5y25aa-python3.11-stripe-8.9.0
found 8.9.0 in filename of file in /nix/store/z4197skfwm0s7mj4rq5milyyvw5y25aa-python3.11-stripe-8.9.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
gigalixir
khoj
python311Packages.stripe
python312Packages.stripe
sourcehut.metasrht

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z4197skfwm0s7mj4rq5milyyvw5y25aa-python3.11-stripe-8.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.stripe https://github.com/r-ryantm/nixpkgs/archive/1be3a217cb76d6a7ca212f667439123fddb3de8e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1be3a217cb76d6a7ca212f667439123fddb3de8e#python311Packages.stripe

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z4197skfwm0s7mj4rq5milyyvw5y25aa-python3.11-stripe-8.9.0
ls -la /nix/store/z4197skfwm0s7mj4rq5milyyvw5y25aa-python3.11-stripe-8.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages failed to build:

khoj
khoj.dist
sourcehut.metasrht
sourcehut.metasrht.dist

6 packages built:

gigalixir
gigalixir.dist
python311Packages.stripe
python311Packages.stripe.dist
python312Packages.stripe
python312Packages.stripe.dist

Maintainer pings


pou-lua and pou-search

Hello! I can't find any contact information, so I'll use this issue to contact you.
Earlier this year I found your repos called pou-lua and pou-search, where you had reverse-engineered the Pou API used by the app for online accounts. Since then, I've made my own research on Pou's API and Pou vs Pou. But one day when I went to search your repos, they weren't there anymore.
I would like to ask you if there's any chance you can publish the source code of those repos back. Alternatively, at least I would like to know your knowledge on Pou's avatar data minInfo.
Greetings
btw, we can speak spanish if you want to

Hello!
I removed pou-search repository due to a request (via reddit by an "r/pou" mod) that said that it would violate copyright (like other "Pou RTX" apps [made by other people] that were also taken down due to trademark infringement)
After doing that, I also decided to remove (by myself) pou-lua.
I still have the source of the repos.
About the "minInfo" (aka "minI") I see that fields like "ouf", "nek", "hat", etc; are probably concatenated IDs, I still don't know much about this.
These are some of the fields available in the "minInfo" object:
sz=Size of pou
ob=Obesity of pou
bCo=Body Color
eCo=Eye Color
ouf=Outfit (t-shirt,shirt,etc)
ela=Eye lashes
esh=Eye shadow color
nek=Neck accessory
hat=Hat
stk=Sticker (could be flags, zodiac signs, etc)
sho=Shoes

(there are more fields)
Also, the "hP" field located in the "site/login" response is to check if the account has a password (yes, you can also decide to not put a password to your account temporally after creating it) , and that explains why does "sentNewPassword" bool appears in "site/check_email" response (it indicates that a new password was sent to your email because your account didn't have a password, it's shown when you login again to your account)
And, the "notification/claim" endpoint serves for claiming notifications, and these notifications serve the purpose of giving an award to the player's pou (for example, coins). These notifications were available in Pou events (for example, christmas) in which you needed to save your account progress to get the notifications and claim them.

Thank you so much for answering! I wasn't aware of the takedown request, now I understand what happened.
Also thank you for the additional information about claiming notifications and the account password


[GEP-26] Add CredentialsBinding API

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
Add the CredentialsBinding API from GEP-26: Workload Identity - Trust Based Authentication

The API is slightly modified compared to what was described in the GEP, the references to credentials providers are not on the root level of the resource but moved under credentialsRef struct
...
secretRef:
  name: my-provider-account
# namespace: namespace-other-than-'garden-dev' // optional
workloadIdentityRef:
  name: my-provider-account
# namespace: namespace-other-than-'garden-dev' // optional

vs
...
credentialsRef:
  secret:
    name: my-provider-account
  # namespace: namespace-other-than-'garden-dev' // optional
  workloadIdentity:
    name: my-provider-account
  # namespace: namespace-other-than-'garden-dev' // optional

Which issue(s) this PR fixes:
Part of #9586
Special notes for your reviewer:
Draft until it is registered in the API server.
Release note:

/assign

/assign

/retest

What about making it even more "future-ready" like this (ref):

Sounds good, I will change the API accordingly.
PS. I guess you wanted to link Object references section?

/retest

/retest

/lgtm

/approve

/area ipcei

/label ipcei/workload-identity


add / fix unit teset

Hello, @nothingzhl ,
The typo in the method name should be fixed.
The added tests, however, may not increase the coverage because the target code is already covered by other tests.
https://mybatis.org/mybatis-3/ja/cobertura/org.apache.ibatis.reflection.property.PropertyCopier.html
https://mybatis.org/mybatis-3/ja/cobertura/org.apache.ibatis.reflection.factory.DefaultObjectFactory.html
I have removed the tests and merged the PR.
Thank you!


Bluetooth Device Not Work / Duplicate Alarm

After Update 1.2.3 -> 1.3.0
My Bluetooth device (LYWSDCGQ/01ZM) temperature e umidity Xiaomi non work.
And i have duplicate Alarm (but in state unaviable)
TY

And i have duplicate Alarm (but in state unaviable)

+1
One alarm has a valid domain and is displayed on the integration page, the second is displayed only in the list of entities
Screenshot: https://cloud.mail.ru/public/sFsX/ormWq7TNS

After updating the integration to the latest version, my devices LYWSD03MMC and LYWSDCGQ/01ZM also stopped working

Had BLE devices working fine on 1.3.0 but after a power outage my hub rebooted and now they're all unavailable... Strange

Should be fixed in v1.4.1. Probably you need reboot gateway and wait some time for collection BLE data


Task - SRS - Section 1 - Purpose of the Project

Complete section 1.1 and 1.2 of the SRS.

We already have a detailed problem statement and goals in the problemstatement.pdf, perhaps it's best to hyperlink to that document to avoid redundancy? I will do so and then ask TA if that is acceptable.


Isue with placeholder + scope + variable replacement

Hi guys!
I'm having a trouble with placeholder translation. I'm trying to translate a placeholder from an <input> element that has a ng-model with it. I've read that translate-attr-* has his own scope, so the model won't work.
By the other hand, the variable replacement only works in placeholder by doing it with translate-attr-placeholder. There is a sample of my code:
<input type ng-model="user.rating" translate translate-attr-placeholder="RATING_PLACEHOLDER" translate-value-name="{{ user.name }}">

And my translate text:
var translations = {
     'RATING_PLACEHOLDER': 'Write the rating for {{ name }}'
}

Anyone know's how I can do my purpose?

Try using the filter in the placeholder Attribute directly.

No way. If I put the filter in the placeholder attr then I can't pass my scope var. I tried this:
<input type="text" placeholder="{{ 'RATING_PLACEHOLDER' | translate:'{name: user.name}'}}">

But obviously didn't work.

Please make a small demo with your code -- as simple as possible.

Ok, Demo:
HTML:
I have this angular model:
var user = {
       name: 'John',
       rating: 0,
       ....
}

And I want to put this placeholder over a textarea: 'Write the rating for John', but, obviously, I want to change the name dynamically, for this, I need to put a variable in the placeholder.
This can be solved by using translate translate-attr-placeholder. But, with this, I can't user ng-model for capture the rating.
So, this code works for printing the user name, but does not store the user rating:
<input type ng-model="user.rating" translate translate-attr-placeholder="RATING_PLACEHOLDER" translate-value-name="{{ user.name }}">

By the other hand, this code works for storing data in ng-model, but I can't pass the user name:
<input type="text" ng-model="user.rating" placeholder="{{ 'RATING_PLACEHOLDER' | translate:'{name: user.name}'}}">

The message that print this is: 'Write the rating for'
This plunker is an example of the issue. For numbers, it works, but not for strings and variables.

I found passing the values as an object instead of a string got me access to the outer scope:
<input type="text" ng-model="user.rating" placeholder="{{ 'RATING_PLACEHOLDER' | translate:{name: user.name} }}">

http://plnkr.co/edit/GmjJ0tpKvo37eEvLU5N4

Yes! It works! My problem was that I was passing a string to the translate filter and not an object. All the examples of Angular-translate docs are passing a string to the filter and not an object, maybe it must be added to docs for other users can solve the same issue.

I have the same problem — translate with translate-attr-title just does not work in some cases: http://plnkr.co/edit/TNUzo6DsxyJg2oEuW73g?p=preview

@mateullull, I found passing the values as an object instead of a string got me access to the outer scope:
<input type="text" ng-model="user.rating" placeholder="{{ 'RATING_PLACEHOLDER' | translate:{name: user.name} }}">

http://plnkr.co/edit/GmjJ0tpKvo37eEvLU5N4

Yes, it works for me, thanks you very much


Update to new arithmetic sponge params

* Update to latest version
* Update names to be more obvious and match proof-systems names
    * pasta_{p,q} -> Legacy: pasta_{p,q}_legacy
    * pasta_{q,q}_3 -> Kimchi: pasta_{p,q}_kimchi
* Need to update submodules once proof-systems and snarky PRs are approved

Closes #10446

Related PRs
snarky https://github.com/o1-labs/snarky/pull/625
proof-systems https://github.com/o1-labs/proof-systems/pull/350


Show Parameters Won't Work in Inspector

The "Show Parameters" feature of my clips in the inspector will not open any parameter window.
M2 Max Macbook Pro / Ventura 13.2.1 / Final Cut Pro 10.6.5 / BRAW Toolbox 1.06(44)

That's very odd. Is the file path in the Inspector valid?

Closing in favour of #111.


[DOCS#2082] Documents configurations for CNI policy-setup timeouts

Product Version(s):
OSS 3.28 (EE 3.19 EP2 to come at a later date)
Issue:
https://tigera.atlassian.net/browse/DOCS-2082
Link to docs preview:
https://deploy-preview-1373--calico-docs-preview-next.netlify.app/calico/next/reference/configure-cni-plugins#enabling-policy-setup-timeout
https://deploy-preview-1373--calico-docs-preview-next.netlify.app/calico/next/reference/felix/configuration  (See manifest section -> EndpointStatusPathPrefix field)
https://deploy-preview-1373--calico-docs-preview-next.netlify.app/calico/next/reference/resources/felixconfig similar to previous link

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

Thanks @ctauchen , yes I think we're good to merge :rocket:


Local var rename incorrectly include "mut" in the rename textbox

let mut variable = 42;

In vscode, attempting to rename variable will cause the rename textbox to show up with the text "mut variable" in it.
(3b4c506f338d03a633419459bb32daf331153d5e)

When you perform the rename does it replace the mut?

Ok it doesn't. Weirdly enough it looks like we don't set the placeholder text anymore and I'm assuming the range is off since it covers the mut but the actual rename operation doesn't alter the mut.

My guess is that the "prepare rename" request is not doing the right thing but the "rename" request is.

The range returned from handle_prepare_rename includes the mut which I think is wrong. Maybe find_all_refs needs a flag to ignore the binding?
I remember this working at one point.

This seems to be working, time to close?

Yes, it now seems to be working.

I cna't reproduce it either


Error for extracting pdf

Basically, it grabs your data and is a possible RAT.
Also, if you enter in a non-pdf, stuff happens

This is a standalone program and it locally extracts text from PDF files given by users. All are under the user's control. Comments would be more useful when they are made after actual test.


WsServer: allow binding to existing HTTP server

Addressing issue #43
This PR makes it possible to pass an existing server when initializing BridgePlugin, so that Express and OSC can work together on the same server.
I made the changes also to WebSocketServer Plugin, but that is not tested (I've only used Bridge so far).
Usage example:
  // Create a web server to serve files and listen to WebSocket connections
  const app = express();
  app.use(express.static('www'));
  const server = http.createServer(app);

  const osc = new OSC({ plugin: new OSC.BridgePlugin({
    udpServer: { port: 57100 },
    udpClient: { port: 57120 },
    wsServer: {  server }, // here we pass our HTTP server to OSC
  })});
  osc.open();

  // start http server
  server.listen(process.env.port || 8081);

Done, please have an eye on it, it's my first time with esdoc, and feel free to rephrase or change anything as you see it fits :)

Finally I had time to look at this again! I'm really sorry for the delay, been busy with other projects .. :crying_cat_face: But thank you so much for this contribution @elgiano !

Thank you!!


Global stats coming up a bit short on matching totals between "total events" and "events breakdown"

Might be partially fixed with #21 but not going to do that tonight.

Missing festivizer removed event was causing this. Fixed in 0.8.1


put_object_acl example?

I've managed to upload a file to S3 bucket, but how would I grant public access to the uploaded file?
I've checked docs, but could know how to..
Is there any example about using put_object_acl ?

What have you tried so far?

I've tried other library {:arc, "~> 0.8.0"} which can upload file to S3 and make it public using @acl :public_read inside the custom module that uses Arc.Definition

I've now made this more clear via https://github.com/ex-aws/ex_aws/blob/master/ISSUE_TEMPLATE.md, but the issue tracker is not really the place to ask for help. Please ask on the forums, IRC, or slack about how to use arc or ExAws.

I am facing the same issue, @benwilson512. There is a #FIXME in the code at put_object_acl and the arity is 3 with no config passed in. I would have expected a ExAws.Config.new(:s3) to go in as first argument. Not getting this to work…

put_object_acl creates an operation struct, it isn't the place for config, config is used on request. As noted in the comment you are replying to, this is not the place to seek help. Please do so on the forms, irc, or slack.


Unseal classes to allow extension

The following classes are sealed which means we cannot extend them in the same way that we do  in Angular.

FirestoreDb.cs
CollectionReference.cs
DocumentReference.cs

In Angular we extend the Firestore classes to allow us to handle some common data we set on all objects in our databases. We have tried to do the same in C# but at the moment this relies on extension methods. This is not fool proof, if we could extend the classes we could achieve this.

No, we will not be doing this. These classes are not designed for inheritance, and we follow the guideline of "design for inheritance or prohibit it". For example, various places in the code assume that CollectionReference and DocumentReference are immutable. If they're not sealed, there's absolutely no guarantee that that's the case. My experience is that controlling inheritance carefully leads to more reliable code.
If you could give more details on what you're trying to achieve, I may be able to advise an alternative design strategy, but it won't involve deriving from those types.

Completely understand the design decision. I would say the most pressing issue is we set default data on all update, set, add.
Additionally, we do use IEnlistmentNotification to handle both firestore and sql transactions which would be nice to add to an inherited class.

I would suggest either wrapping the existing classes, or just using extension methods, possibly with a Roslyn code analysis rule to ensure that your code never uses the "regular" methods. It sounds like you've probably got it in hand though in terms of design strategies, so I'll close this issue now. If there are ways that we can help you that don't involve undermining the existing design, I'm happy to listen to suggestions.


Pillarbox Web is available in a WebView

Use case description
As a Pillarbox web developer, I'd like the web player to be available in a mobile webview, so I can easily test the web player in this context.
Acceptance criteria

Pillarbox web is available in a webview
A DRM example is available
The URL to embed in the WebView is https://srgssr.github.io/pillarbox-web/

Proposed solution
Resources

Webviews
Interacting with media
WWDC 2022: embedding encrypted media
WWDC 2021: WKWebView additions

Alternatives considered
No response
Is there an existing similar feature request?

[x] I have searched existing features and found no similar request.

[x] I have browsed the available API and found no way to achieve the use case I described.

I encountered an issue with integrating the Pillarbox web into the WebView. However, the problem doesn't seem to be related to the WebView because I'm also unable to play DRM content with Pillarbox web in Safari 17.1 and 17.2.


[flaky-test] Increase test idempotent produce timeout time

Fixes: #1053
Motivation
After examining the timeout test log, no blocking phenomenon was found. So the current solution is to increase test idempotent produce timeout time. Maybe it took too much time to send 1000 messages.

It looks like this test is still flaky, see https://github.com/streamnative/kop/runs/5439450488?check_suite_focus=true.

It looks like this test is still flaky, see https://github.com/streamnative/kop/runs/5439450488?check_suite_focus=true.

Yes, I saw it, too, I'll check it out.


Update sbt-scalajs, scalajs-compiler to 1.3.0

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler

from 0.6.33 to 1.3.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-major

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Sema: Update inheritance availability checking exception

The changes from https://github.com/swiftlang/swift/pull/62327 need to be updated for compatibility with the SDKs accompanying Xcode 16.
Resolves rdar://132438383 and https://github.com/swiftlang/swift/issues/75175.

@swift-ci please smoke test


move DelegateFSGroupToCSIDriver featuregate

due to  https://github.com/kubernetes/kubernetes/pull/117655

/retest

This, IIUC, should target at 'dev-1.28' branch rather than 'main'?

@tengqm  thanks for your guide. please view  #41007


feat: json update promotion step

closes: https://github.com/akuity/kargo/issues/2961
This PR adds json-update promotion step that allows one to automate JSON updates within the Kargo promotion workflows

I think the library you're using already accounts for preserving the formatting of the original JSON, but it would be good to add a test case that verifies that, because this is an incredibly important aspect of this.

@fykaa this is very good overall. I know I made a lot of comments, but the majority of them can be directly traced back to the quirkiness of the codegen that creates Go structs from JSON schema.
I think with some slight modifications to the schema, everything else will fall into place.

if you could please update UI code as well - read this PR for reference (skip the icons)


Log Button

What feature do you want to see added?
A button at job level that shows logging of the polling action. I can't get this plugin to work and I also can't find any logs written on the Jenkins machine, so I can't debug why it is broken. URLTrigger has a convenient Log button.
Upstream changes
None

has added


Compile functests with go test -c

Instead of using ginkgo's wrapper around go test -c, use go test -c
directly. This allows us to compile the tests in environments where the
ginkgo binary does not exist.
Signed-off-by: Daniel Belenky<EMAIL_ADDRESS>Release note:

NONE

/approve


🧹 Set up regression testing for PyPy

Currently Failing

PyArrow doesn't appear to support PyPy (https://issues.apache.org/jira/browse/ARROW-2651)


[FLINK-11887][metrics] Fixed latency metrics drift apart

What is the purpose of the change
Use System.currentTimeMillis to replace System.nanoTime in LatencyMarker,
in order to fix latency metrics drift apart.
Verifying this change
LatencyMarker  only affect one latency metric.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thank for your comment.
We don't use System.nanoTime for compute latency metrics directly.
Because, when a shuffle happened bewteen source(A node) and operator(B node), the latency value is endTime - startTime.
startTime is produced by source(A taskManager), but endTime is produced by operator(B taskManager), and as we know,System.nanoTime() is guaranteed to be safe within a single JVM instance.
So, it would not be a right way that change LatencyStats to use System.nanoTime() instead.
Come back to this issue FLINK-11887.The original way that we get startTime is use SystemProcessingTimeService#scheduleAtFixedRate to accumulate a fixed time interval periodicity.
With time going on, there is no guarantee that startTime and actual time don't drift apart.Especially if they are executed on different machines.In my cluster environment,I found the startTime is much later than actual time.
If we change LatencyStats to use SystemProcessingTimeService#scheduleAtFixedRate to acquire endTime，it will be unable to avoid time drift apart in different nodes.
In many data center,different linux machines use Network Time Protocol to synchronize time. So we use System.currentTimeMillis (endTime) - System.currentTimeMillis (startTime) is a relatively accurate way.


Add support for lock and private on unix like systems

This change originally comes from the mapr crate and is the only
reason that fork exists. Getting it upstreamed would mean that there
would be one less fork of memmap.

I'm closing this PR in favour of https://github.com/RazrFalcon/memmap2-rs/issues/51 and will open a new PR then.


feat: change visitors API

New API for openapi-cli custom rules

Since we're making a breaking change to the API, it seems like a good time to improve the error messages.

Superseded by https://github.com/Redocly/openapi-cli/pull/146


Adiciona template de issues e prs

Adicionei template de PR, e dois para isses
Resolves #44, Resolves #62

@JoseRenan


Fix bug where Jinja dictsort would complain about undefined

In Jinja dictsort would raise an exception if dictsort was being passed undefined, for instance when a param was not present.
This caused issues with alphagov/digitalmarketplace-briefs-frontend#354

I assume this is something that we can't easily test? Or are the functional tests sufficient?

Tests would be nice.
Ideally we'd have a full Python test suite for this repo... See this tech debt ticket https://trello.com/c/gw8q0xdl/1436-we-dont-have-comprehensive-python-tests-for-digitalmarketplace-govuk-frontend
In lieu of that I've added a simple test to the existing Python tests, hopefully we will clear that tech debt ticket soon.


SharePoint Listview URL Filtering

Hello All,
Could someone please explain to me if possible why MS chose to only allow the Equal (=) operator for filtering list view using URL query string in SharePoint Online?
For example, I can use the following URL to filter my listview: it will display all items with "numberColumn" having exactly "12" as value.
?useFiltersInViewXml=1&FilterField1=numberColumn&FilterValue1=12
But what should I do if I wanted to see all items having "numbercolumn" LessThan "12"?
People also need to display items with value that are GreaterThan, LessThan, Containing this OR that value....
How would they do that?
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac77ab44-dbe6-f6bc-951e-a7e6d44fb8aa
Version Independent ID: ac77ab44-dbe6-f6bc-951e-a7e6d44fb8aa
Content: Query String URL Tricks for SharePoint and Microsoft 365
Content Source: Community/query-string-url-tricks-sharepoint-m365.md
Service: sharepoint-online
GitHub Login: @PatD
Microsoft Alias: daisyfeller

@sympmarc
Thank you for your reply.
I am aware of the view filters with create/edit a view.
What I am looking for is, as you mentioned, use the dynamic filtering on the fly.
I created a command set extension. Once the user clicks on the command, it prompts for a value, and uses the entered value to filter the list on the fly.
I am puzzled that MS offered the url trick for an "=" operator only... If they can do it for "=", why can't they do the same for "<", or ">" or "contains", "endsWith"....

I think the use cases for those extra options would be less common. That said, you should propose the enhancement in the SharePoint Feedback Hub.


No likes available problem

without script

with script

See issue: https://github.com/tajnymag/tinder-deblur/issues/44


Change the infamous chmod 777 for something more sensible

chmod 777 are evil. You don't want to grant anyone who has a shell on
your machine the right to see and edit your data.

You need to be able to execute to browse folders.

Not rusted at all.
The +x permission on folders is neccessary for the directory listing, but has nothing to do with the execute permission on files. (You can't execute a folder, no matter how hard you try)

This PR has been merged in a bulk merge.


fixes auto update bug for WinGSM 1.22.1+

see https://github.com/WindowsGSM/WindowsGSM/issues/57#issuecomment-983924499

Before repair

https://github.com/WindowsGSM/WindowsGSM/issues/57#issuecomment-983924499
After repair

[12/02/2021-02:40:40][#1] Checking: Version (7776781) => (7803590)
[12/02/2021-02:41:11][#1] Server: Updated (7803590)

[2021-12-02 02:40:45] Loaded 0 apps from install folder "F:\WindowsGSM\bin\steamcmd\steamapps\appmanifest_*.acf".
[2021-12-02 02:40:46] Loaded 1 apps from install folder "f:\windowsgsm\servers\1\serverfiles\steamapps\appmanifest_*.acf".
[2021-12-02 02:40:47] AppID 1690800 scheduler update : Priority First, not played for<PHONE_NUMBER> seconds, update disabled for 0 seconds
[2021-12-02 02:40:47] AppID 1690800 state changed : Update Required,Fully Installed,Update Queued,Update Started,
[2021-12-02 02:40:47] AppID 1690800 state changed : Update Required,Fully Installed,Update Queued,Update Running,Update Started,
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,Reconfiguring,
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,
[2021-12-02 02:40:47] AppID 1690800 update started : download 782534448/782534448, store 0/0, reuse<PHONE_NUMBER>/3457830866, delta 462882187/462882187, stage<PHONE_NUMBER>/8641305085
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,Staging,
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,
[2021-12-02 02:40:47] AppID 1690800 update changed : Running,Verifying,
[2021-12-02 02:40:47] Update auto validation: enabled for all clients
[2021-12-02 02:40:47] Update auto validation (1690801): clean bytes tally of 0 bytes is less than threshold of 2048 MB, forcing full validate
[2021-12-02 02:41:09] AppID 1690800 update changed : Running,
[2021-12-02 02:41:09] AppID 1690800 update changed : Running,Committing,
[2021-12-02 02:41:09] AppID 1690800 starting commit from "f:\windowsgsm\servers\1\serverfiles\steamapps\downloading\1690800" to "f:\windowsgsm\servers\1\serverfiles" : 529 updated, 0 moved, 33 deleted files
[2021-12-02 02:41:11] AppID 1690800 state changed : Fully Installed,Update Queued,Update Running,
[2021-12-02 02:41:11] AppID 1690800 finished update, 2 mounted depots (BuildID 7803590) : 1004<PHONE_NUMBER>424864031),1690801<PHONE_NUMBER>23183639),
[2021-12-02 02:41:11] AppID 1690800 update changed : Running,
[2021-12-02 02:41:11] AppID 1690800 update changed : None
[2021-12-02 02:41:11] AppID 1690800 state changed : Fully Installed,Update Queued,
[2021-12-02 02:41:11] AppID 1690800 state changed : Fully Installed,
[2021-12-02 02:41:11] AppID 1690800 scheduler finished : removed from schedule (result No Error, state 0xc)


chore(deps)!: update proto-loader to 0.6.11

gax generated code in /protos import long. With upgrade tolong v5, it cause compiling error similar in https://github.com/grpc/grpc-node/issues/2111.
Thanks to @murgatroid99 fixed in https://github.com/grpc/grpc-node/pull/2112.
Now library could compile with version 0.6.11

https://github.com/googleapis/gax-nodejs/pull/1253 should fix the issue. Close for now.


change of .show() to work better from the command line

Minor change in underlying functions for .show() so that within the command line, the .show() function works in a similar way as matplotlib. This approach doesn't allow for adaptive resizing that is common with matplotlib based plots.
Fixes issue #5

Codecov Report

Merging #7 (248d059) into main (6bfceed) will decrease coverage by 0.30%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   67.69%   67.39%   -0.31%
==========================================
  Files           7        7
  Lines         681      687       +6
==========================================
+ Hits          461      463       +2
- Misses        220      224       +4

Impacted Files
Coverage Δ

src/cowpatch/svg_utils.py
60.90% <25.00%> (-1.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bfceed...248d059. Read the comment docs.