help enable source link for Rx.NET

@onovotny reported a couple of days ago that SourceLink 2.0.2 did not work for him on the AppVeyor builds. It resulted in embedding all of the files. I guessed that it was a conflict with what GitVersion was doing to the git repository, but was wrong. Will need to dig deeper to see what is going on and if this is a SourceLink bug.

If it helps, we do build PR's so easy to test by starting a PR and updating that branch. happy to accept anything that works :)

@onovotny I am unable to reproduce the issue from my ctaggart/rx-net AppVeyor. Only on dotnetfoundation/rx-net-la3iv AppVeyor does the C# compiler set the directory name to source in the debug documents. dotnetfoundation/rx-net-la3iv is not using the appveyor.yml. Any change you could make it use the appveyor.yml again? Are there cache settings being used in the config? Are you using the Visual Studio 2017 image? Does a paid AppVeyor account do cloning differently than a non paid one?
https://ci.appveyor.com/project/ctaggart/rx-net/build/4.0.0-sourcelink2.107.build.7
dotnet sourcelink print-documents "C:\Users\camer\Downloads\System.Reactive.4.0.0sourcelink2.107\lib\net46\System.React
ive.dll"

2dce25745d3bf724e498ec9f0e2795a1c778e9c4 sha1 csharp C:\projects\rx-net\Rx.NET\Source\src\System.Reactive\Observable.Extensions.cs
059d8221fd2f1dda5261a633fe4eb2ab1891c76f sha1 csharp C:\projects\rx-net\Rx.NET\Source\src\System.Reactive\AnonymousObservable.cs

I don't understand why this isn't the case on
https://ci.appveyor.com/project/dotnetfoundation/rx-net-la3iv/build/4.0.0-PullReq00337.103.build.153
dotnet sourcelink print-documents "C:\Users\camer\Downloads\System.Reactive.4.0.0-PullReq00337.99\lib\net45\System.Reactive.dll"

2dce25745d3bf724e498ec9f0e2795a1c778e9c4 sha1 csharp C:\projects\rx-net-la3iv\Rx.NET\source\src\System.Reactive\Observable.Extensions.cs
059d8221fd2f1dda5261a633fe4eb2ab1891c76f sha1 csharp C:\projects\rx-net-la3iv\Rx.NET\source\src\System.Reactive\AnonymousObservable.cs

@ctaggart That build uses the following AppVeyor file:
https://github.com/Reactive-Extensions/Rx.NET/blob/develop/appveyor.rx.yml
We split it to improve CI build times since check-ins to Rx rarely had an impact on Ix and vice-versa.
We're not doing any special caching or anything else special....

https://github.com/Reactive-Extensions/Rx.NET/pull/338 is building. Root cause fix is:

@ctaggart that seems really fragile...how does the case in the powershell path affect this at all?

@onovotny I agree, but it works. I'm sure this will become more robust as more people adopt it. I'll open up a new issue to track this. For this issue, we'd have to look at how the powershell path affects the C# compiler call. Hopefully, there is an msbuild property that can we can override with Path.GetFullPath to make this more robust.

Indeed, a very strange interaction!

Thanks for merging it! Please do report back when source link enabled binaries make it to NuGet Gallery. And please help spread the word that enabling source link will help the whole .NET community. It would be great to see more adoption from additional .NET Foundation projects.
Created #172 to track down that strange interaction.

It's not on NuGet but it is on MyGet -- https://twitter.com/ReactiveX/status/842474985348304898

bug #197

The current SourceLink solution for Rx.NET is now using SourceLink.Create.GitHub in Directory.Build.props files. This is for 4.0.0 that is currently in beta.

Ix.NET/Source/Directory.build.props
Rx.NET/Source/Directory.build.props

Here are the related changes. SourceLink is enabled when it is not a test project.
<Project>
  <PropertyGroup>
    <IsTestProject>$(MSBuildProjectName.Contains('Test'))</IsTestProject>
  </PropertyGroup>
  <ItemGroup Condition="'$(IsTestProject)' != 'true' and '$(SourceLinkEnabled)' != 'false'">
    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.0" PrivateAssets="All" />
  </ItemGroup>
</Project>

The appveyor.yml files have been updated

appveyor.rx.yml

init:
  - git config --global core.autocrlf input


Tile pruning too agressive?

1.0 master:

0.7:

Git bisect points to https://github.com/Leaflet/Leaflet/commit/a4e8f4e1a8fd10c0cd701997c85bafe9894b216f
@mourner @IvanSanchez any clue, or should I investigate? :)

Yeah, at some point I removed it and then didn't readd it back. Need to look whether it's worth doing at all.

Yeah, at some point I removed it and then didn't readd it back. Need to look whether it's worth doing at all.

@mourner, not sure what "it" refers to in your sentence ;)

I'm unable to see how the bisected commit affects tile pruning :-S
Maybe it's time to see if #3551 is not a bad idea after all?

@yohanboniface I referred to retaining tiles on the current zoom when panning. I removed it when reworking the logic meaning to add it back some time later, but never did. I'm not sure we should though — or maybe we should but in a limited form (e.g. retain tiles only within X pixels from the current screen). Retaining already loaded tiles is different from #3551 though (which is loading yet unseen tiles).

Can be checked visually on #4206. I recommend keeping at least one tile in memory on each sides.
What is the downside of keeping more tiles? Higher memory usage?

@hyperknot Bloated DOM,

I think this can be fixed after rc1.

One scenario where this will matter is smooth zooming with zoomSnap = 0, zoomAnimation = false and trackpad scrolling.
On current master, this trigger thousands of tile loads even with a simple zoom-out, zoom-in.
http://playground-leaflet.rhcloud.com/cap/2/edit?output
(might need trackpad to reproduce smoothness)

The amount of tiles retained on each side should be configurable.

On mobile devices this effect is very annoying even in wifi env. The tiles load to slow if you just scroll around the map. It takes several seconds to load a new tile, displaying white background.
Gmaps does solve this way better: It loads a very low res version of the tile around the (invisible) edges of the current view and then when they become visible loads and renders the higher resolution version. And it also keeps them in memory.
So when you move back and forth on the map no further than one screen everything stays sharp and ready.

Hello,
Just wanted to add my "+1" to this issue with my use case.
In my case, I handle online/offline scenarios. When offline, the tile content is grabbed asynchronously from a file on the hard drive, the binary stream (image) is opened, the content is encoded as a base64 string and I set the tile.src value.
So the process of displaying a single tile is not just setting the src to an img and letting the browser download the image but in my case, it can involve some I/O operation, which are quite costly. If many tiles are requested, the browser starts lagging. I guess many mobile devs who use phonegap and such to create offline maps will have the same issue.
Behavious was acceptable in 0.7.7 but really laggy in 1.0.x. because of what @yohanboniface explains.
I am not sure what the best solution is here, having a configurable tile buffer kept in memory (@hyperknot) could work in some situations (panning) but zooming in and out would still suffer from the same issue. I think having some kind of tile queue kept in memory with a Time-To-Live or a "last seen" parameter would be a better solution. That queue would have a configurable max length (0 by default if you want to keep the existing behaviour) but like @pke says, it is annoying even in wifi envrionnements, so the default value should be more than 0 in my opinion.
Fabien

Hello,
I had a go at this issue. At first I tried having an array as a property of the GridLayer for unused tiles like in leaflet 0.7.7 but I realized that the "this._tiles" object already had a similar purpose and the change could just be in the value of the "retain" property on tiles.
Current implementation says that only "current" tiles (= in the viewport) should be retained:
https://github.com/Leaflet/Leaflet/blob/master/src/layer/tile/GridLayer.js#L390
I added a simple check based on diff between now and the "loaded" timing. If inferior to a value configurable in the options (no value by default = recycling disabled), the tile is retained
Here is the PR if you want to give it a try:
https://github.com/Leaflet/Leaflet/pull/4648
Add the option to your tileLayer, such as tileRecycleDelay: 15, which means that tiles loaded in the last 15 seconds are retained.
What do you think?
Fabien

thanks @fnicollet for the effort! While its a good solution I think it does not help to adhere to the expectations user have from panning and zooming a map. When the user pans a map back and forth, even after 15secs she expects the the tiles that have been loaded in the surrounding to be still there.
All native map implementations on iPhone and Android phones manage that just fine, without wasting a huge amount of memory. Granted, they use vector tiles, but still, they retain them in memory for much longer.
I would say we could try the following prune trigger:
The tile is either 2 view width/heights away from the current view borders and older than xx secs.
Also this patch of yours does not solve the problem of loading tiles that are only some pixels off the current view borders. They experience is then to see a white background when you try to pan around the borders.

I think pruning based on tile age is useless. I would maybe have one configurable parameter for the number of tile rows loaded outside the visible area. And another configurable parameter for the number of loaded tiles kept in a FIFO buffer cache.

Yes, the patch doesn't solve the problem of loading tiles that are just off the border but @IvanSanchez "bufferSize" does solve this (different) problem, see his commit just before my message
You can't really compare vector maps and image tiles. The data size is different and the other issue with image tiles is the "bloated" DOM, which can make the map slow if too many DOM objects are on the map, wether or not they are currently displayed.

So now we have:

#4614: the buffer solution. Loads more tiles than strictly needed
#4648: the timeout solution. Might unload tiles more aggresively than needed
#4649: the FIFO MRU solution. What we want??

So now we have:

#4614: the buffer solution. Loads more tiles than strictly needed.
#4648: the timeout solution. Might unload tiles more aggresively than needed.
#4649: the FIFO MRU solution. Not trivial to set a good value for the size of the FIFO.
#4650: the dual tileRange solution. Loads as normal, marks for pruning as the buffer solution.

I'm waiting for a fifth option to decide.

Until a new version in verse from @IvanSanchez I'm on the FIFO too: it gives better results when a user only goes in one direction and back, or when zooming.
Nice work anyway as usual Ivan :)

Amazing work @IvanSanchez :)
I would go for both the buffer and the FIFO MRU solution.
The buffer allows for pre-loading, which is a nice to have on desktop but should be disabled on mobile because of bandwidth
The FIFO MRU as a sizeable cache, which can be configured depending on the use-case as well. Like on mobile, it should be set to a reasonable amount (say 15) while on the desktop you could have a bigger value because your PC can handle it easily in RAM (say 100 for confort)

Really nice work @IvanSanchez. I think the solution is a combination of #4649 and #4650.

also dynamically calculating tiles to keep based on map size. We might just do a simple floor(map_width * map_height) / (256 * 256) * 2 or something like that.

@yohanboniface
My code sure has a pile
of bugs, the kind most vile
but I'll go the extra mile
and I'll edit the source file
(without need to compile)
to better prune your tile.
This might take a while.

<3 <3 <3
Github is missing a feature to merge a comment into the code.

Now we have a Leaflet T-Shirt:
https://teespring.com/leaflet-t-shirt#pid=389&cid=100019&sid=front

I just noticed that the MRU FIFO (#4649) is not a viable option.
It keeps tiles of non-active zoom levels... normally that's not an issue, but for semitransparent tiles, or for GridLayers without a solid background, this will glitch heavily.
Shall we merge #4650 instead and let this be over?

Yes, #4650 looks very simple and perfect. I'd just call it noPruneRange since it's actually the non-pruning tiles.

@hyperknot Renamed.

Seems like everyone thinks that #4650 is the way to go. @hyperknot promised to whip up a few unit tests, so the plan is to wait a couple of days for that to happen.

Thanks! I'd like to test this in my mapbox app. However mapbox still uses leaflet 0.7. How can I force it to use the newest version?

@pke you won't :-) Mapbox is using MapboxGL JS now and you can use Mapbox maps in Leaflet rc1 very simply!

@hyperknot mapbox-js is not MapboxGL. Its still supported isn't it? How would I load mapbox maps in leaflet?

Is it somehow possible to delay or cancel the "tileunload" event? Then everybody would be able to implement his own unloading strategy.

@AndreasSchmid1 sorry, no, the pruning algorithm isn't customizable like that for now.


erlang.log goes to 5 max

Environment

OS: ALL
Erlang/OTP: ALL
EMQ: ALL

Description
I want to increase the number of log file count > 5 in debug mode. I tried by updating settings and then restart but it's still rotating in 1 to 5 and overwriting old ones.

@nagendraK6 https://github.com/emqtt/emq-relx/pull/176

@nagendraK6 The issue has been fixed in v2.3.5.


Update data model with latest notation spec

This PR addresses some comments from previous plugin PRs and updates the data model to the latest version, defined in https://github.com/notaryproject/notaryproject/pull/158.
The main change is that notation.Payload is now agnostic to the envelope type thanks to the JWS specific claims being generalized and moved to notation.JWSProtectedHeader.

Signature envelope definition is moved to notation-core-go in this merged PR and has been updated to include recent changes like - expiry, signing time and signing agent.
Refactoring of notation-go to use envelope types from notation-core-go and updates to Payload type are addressed in this open PR

@qmuntal @shizhMSFT @priteshbandi

Resolve as duplicate?

Signature envelope definition is moved to notation-core-go in this merged PR and has been updated to include recent changes like - expiry, signing time and signing agent.
Refactoring of notation-go to use envelope types from notation-core-go and updates to Payload type are addressed in this open PR

@qmuntal @shizhMSFT @priteshbandi

Agree!


[GCB] Create a PROD integration test

We prefer running our integration tests against emulators because they're much faster and less flaky (usually). However, we should have at least one build that runs the integration tests against actual production servers.
Today we have macOS and Windows builds on Kokoro that hit production when running integration tests, but we may want to disable those integration tests on macOS and Windows. If we do, we'll need to be running them on GCB.
Depending on our server-side quota limitations, we could run these builds on every PR and CI (might be slow), or we could run them nightly, or N times per day. We have options.

Just something to consider as you restructure these: currently ci/cloudbuild/builds/integration.sh runs the tests for service A, then service B, then service C, etc.  That is wasting opportunities for parallelism when running against production. It was (more or less) unavoidable when running against emulators (and less important because the emulators are "fast"), but when running against production there is value in running as many tests in parallel as possible.

Thinking out loud here to help me reason through this:

The goal is to test each library against production: that is what matters to our customers.
Running against production is slow, and fraught with flakiness, and quota issues so we prefer to use emulators.
Using the emulators creates a few coverage (as in "feature coverage", not "line coverage") gaps: e.g., verifying the actually endpoints are correct, and that authentication works, and that the headers we include with each RPC are not rejected.
In addition, the emulators do not support all features.  We test those features by running a small subset of the tests using production.
Largely, running that handful of tests against production closes the previous gap.

So I think in general the answer would be:

If we have a library / service tested against the emulator, then we just need a handful of tests using production.

So I would say we do NOT need a separate build.  With the following caveat:
I cannot recall if all libraries that use the emulator at least one test using production.  In some cases (e.g. storage signed URLs) the library is not used to hit the production service at all. I think your recollection / knowledge is better than mine at this point.
PS: I am not sure how to apply this reasoning to the interaction between the production tests on macOS and Windows vs. the other tests... I think there is a case for "don't test on Linux if you already tests on macOS and Windows".

Thanks. OK, so at this point, it sounds like there's nothing explicit that we need to do.
If at some point we decide to stop running the prod-facing integration tests on mac or windows, at that point we may need to make sure that prod-facing integration functionality exists on GCB. Until then, I think we can close this.


zplug changed the $PATH order.

Problem Summary
The $PATH order has changed because the $ZPLUG_HOME is empty on https://github.com/zplug/zplug/blob/master/base/core/core.zsh#L102
System Information

uname -a

Linux tndl.net 4.5.7-200.fc23.x86_64 #1 SMP Wed Jun 8 17:41:50 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
```

zsh version

zsh 5.1.1 (x86_64-redhat-linux-gnu)
```

zplug version/commit

366bf354e4b3e315fb2fe93da513464167f6031c
```
Minimal zshrc
Create a minimal reproducing set of configurations for this issue. Please
remove all unnecessary parts!
source ~/.zplug/init.zsh

Steps to Reproduce

exec zsh

$ echo $PATH | sed -e 's/:/\n/g'
/usr/lib64/qt-3.3/bin
/usr/lib64/ccache
/usr/local/bin
/usr/bin
/home/test/bin
/usr/local/sbin
/usr/sbin

2. `source ~/.zplug/init.zsh`

$ echo $PATH | sed -e 's/:/\n/g'
/home/test/.zplug/bin
/bin
/usr/lib64/qt-3.3/bin
/usr/lib64/ccache
/usr/local/bin
/usr/bin
/home/test/bin
/usr/local/sbin
/usr/sbin

Thank you for reporting. Give me a second, let me check...
Note:
--- before	2016-08-21 15:26:36.000000000 +0900
+++ after	2016-08-21 15:26:14.000000000 +0900
@@ -1,3 +1,5 @@
+/home/test/.zplug/bin
+/bin
 /usr/lib64/qt-3.3/bin
 /usr/lib64/ccache
 /usr/local/bin

In the meantime, it may be better to use stable version ( zplug "zplug/zplug", at:2.1.0 )

@eru Try fix-230 branch!

@b4b4r07 Thank you for the quick response! It works.


Is there a follow-up development plan?

We need the rust version of sdk, and if it's not that fast, we'd like to implement it ourselves based on protobuf once.

We need the rust version of sdk, and if it's not that fast, we'd like to implement it ourselves based on protobuf once.

For now, we are planning to start it on 1st July, most of things should be done before Sep.

Thks 4 amazing work!

Hey @yah01, have you taken a look at my work in https://github.com/codabrink/milvus-sdk-rust ?

Hey @yah01, have you taken a look at my work in https://github.com/codabrink/milvus-sdk-rust ?

Sure, I replied to your email, guess you missed that...


Decrease Size of @celo/utils

Expected Behavior
utils package should be smaller
look at replacing usage of lodash (currently just used for memoize) with a lodash.memoize or a different memoize function
see about replacing google-libphonenumber with smaller https://github.com/catamphetamine/libphonenumber-js
is it nessessary to have both bigNumber and bn.js as dependencies?
Current Behavior
bundlephobia currently lists @celo/utils at over 1mb minified. https://bundlephobia.com/result?p=<EMAIL_ADDRESS>google-libphonenumber and lodash together make up over 50% of that.

found while trying to reduce bundlesizes on web. this only effects the faucet page there.


Free Code Camp Weather API needs a list of all the possible weather outcomes and descriptions.

Challenge Name

Show the Local Weather
Free Code Camp Weather API Pass-through
Issue Description

We need a list of all the possible outcomes for that the weather API  JSON at "weather[0].main" and their descriptions at "weather[0].description".
The code pen example gives 6 outcomes for weather[0].main but none for weather[0].description.  The API example call gives an additional out come for a total of 7.
Known  out comes:

weather[0].main
weather[0].description

Drizzle

Clouds

Rain
moderate rain

Snow

Clear

Thunderstorm

Mist
mist

Also, I don't know if weather[0].main is directly linked to weather[0].description, for example, if Rain can have more than one description. So that would be worth looking into as well.
Screenshot

Api example call:

Add "Smoke" to the list. A friend got this output just now:
Image
It is accurate. He said "There are wildfires up wind".

is this a workaround to another api? if so, you could maybe go there and find the list.

The FCC weather API uses data from openweathermap. I'm including a link here that shows the meaning for the weather icons and a list of the descriptions based on their id. As for main, I think the first number of the id describes the group, though I could be wrong on that.
https://openweathermap.org/weather-conditions
I'd be happy to add this into the description page for the FCC API if desired. Just need to know where to go to do that. #15878 mentions a repo for it, but it's not owned/created by FCC so I'm not sure if it'll really work for the FCC endpoint or not.

@andrejarboe Thanks for bringing this to our attention. I agree - we should clarify the different possible weather outcomes right in the challenge instructions. Would you be interested in adding (or updating) a user story to specify the possible outcomes that the open weather API can return?

@guiKailu Yes - though I wouldn't use "e.g."
How about this:
User Story: I can see a different icon or background image that corresponds to the current weather. (The weather could be rain, snow, clouds, drizzling, clear, thunderstorm, fog, or smoke).

@QuincyLarson Yes, that grammar does clarify it. I found a few more weather conditions though, thanks to this post by @merlincatman
Perhaps all should be included, but with a license to combine subcategories under the same image, as @merlincatman has done with || operators in his post?
How about this? Maybe a bit too long now:
User Story: I can see a different icon or background image that matches the current weather. The weather could be rain, shower rain, light rain, moderate rain, snow, few clouds, scattered clouds, broken clouds, clouds, drizzling, clear sky, thunderstorm, mist, fog, or smoke. (The icon or image could be the same for shower rain, light rain, etc.)
The last sentence could be left out, with people figuring that idea out for themselves.

@guiKailu Awesome - I like that user story copy even better! I don't think it's too long. It succeeds in making things clearer.
Would you be interested in opening a pull request to update the copy in the challenge?

How do I help out and make changes?

@QuincyLarson Yes, I would be interested! I was going to let you know once I'm done :grinning:, but then I read the instruction, "Let us know you are working on it" :sweat_smile:
@QuincyLarson Thank you so much for everything you do here at FCC! I'm loving it.
I'll go back to learning about making a pull request now... :innocent:


TwitterAPI module

TwitterAPI module is required for connect rasa chatbot to Twitter
Proposed changes:

my previous pull request's build was needed this module, so i was changed this file

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

Hi @soundaraj, please do not request reviews from our team, once we check out your pull request, one of us will decide who is most appropriate for review.
That being said, if you have something that is required for another PR, that change should go in that PR, not a separate one, as that would lead to introducing code that does not function in between PRs.


post-robot in React - cannot read properties of undefined (send)

I have install the post-robot package to my react project.
My project works as a web app which is embedded into a Web Client application and displayed within an IFrame. I know this web client uses post-robot library to handle communication events and I also know it is has an EventListening set on "loading".
Like any other packages, I have imported post robot in my main app component
import { postRobot } from 'post-robot'

I tried to send the corresponding message the webclient is expecting :
const sendMessage = (message, success) => {
    //parent window is the holding web client, message is "loading", success is false
    postRobot.send(window.parent, message, success)

however, when this function is called in the hook at runtime, an error occurs saying that React does not recognize '.send()' as a valid method.

I am puzzled. React seems to not recognize post-robot package, however, VS does not preventively throw any warning/errors (like it usually does) which would mean the package has been installed successfully. Am I doing this wrong or is post-robot not meant to be used on a React project ?

You need to use the default export
import postRobot from 'post-robot'; // will work

Not a named export
import { postRobot } from 'post-robot'; // won't work

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import

@zackspear , thank you for the answer. It works.


No custom icon for azure-pipelines YAML file

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2
OS Version: macOS Monterey

Steps to Reproduce:

Install the extension ms-azure-devops.azure-pipelines
Create .vscode/settings.json
Copy the following code:

{
  "files.associations": {
    "**/ci/**/*.yml": "azure-pipelines"
  }
}

Create the file ci/pipeline.yml

You will see that the icon is not a yaml icon, but just the fallback icon
Actual:

Expected:

@aeschli do you know how is this sort of thing normally handled? Azure Pipelines contributes their own language which breaks the icon, and then that breaks the default language extname. Can it be solved in their extension/core as opposed to adding an azure-pipelines language icon to every icon theme?
cc @misolori

The best way would be to add an icon for the azure-pipelines language.
I just added new API that languages can provide a default icon: https://github.com/microsoft/vscode/issues/140047

Please file an issue against https://github.com/Microsoft/azure-pipelines-vscode/issues/ to provide an icon with the new API.

We have to see if the language icons looks out of place. For some very specific file icon themes that might be the case, but I believe we will be fine with the common ones (Seti, VSCode Icons) which are very varied themselves.
The next step is of course to file feature request against the file icon themes to adopt the language.
We currently don't have a notation that a language extends a different language.
The icon is only one aspect there. When editing a azure-pipelines file, you will only get the language support provided for   azure-pipelines and not the yaml support.


Kanban Board Planning

In this project, we planned the kanban board for the next 2 weeks, please find the link to the kanban here

We are a team of 4 people : @Profsain @wassimchakib @Kweeka1 @KIsmoilov

Hi Team,
In my opinion, you are ready to move on to the next step! ⏭
Good luck! 🎉
Highlights

Good job meeting all the requirements 👍

Optional suggestions

Consider adding labels to help with filtering with types of tasks and distinguishing types of tasks

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.
Cheers and Happy coding!👏👏👏

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


linux-samus: remove

The package is out-of-date and has no maintainer.
I don't own a chromebook device and therefore don't know
if an mainline kernel could be used instead.
cc @lheckemann @zohl

I've never used it myself, +1 for removing maintainerless packages though.


json test unfair

Some framework use simplejson as default(flask), some use built-in json module(tornado).

Yes, and what is wrong? It's all about default features which user has from chosen framework. If Flask uses simplejson by default and tornado built in I don't see any problem. I don't want to hack test for speedups. I trying to be close to default configuration for each framework.


Podman Machine Create form is missing cpu/memory sliders after pfirst podman installation

Bug description
If I have a fresh podman desktop installation and I go through the onboarding workflow for podman and podman machine, I do not see sliders for configuring the hyperv Machine when creating one.
This is what I get after I go through the podman onboarding and then proceed with podman machine onboarding (creating a machine via onboarding workflow):

After restarting the PD I got correct state:

Operating system
Windows
Installation Method
Installer from website/GitHub releases
Version
next (development version)
Steps to reproduce

Have fresh state of machine, HyperV feature is enabled
Install podman Desktop
Start onboarding workflow -> Podman onboarding
Install Podman (5.2.5)
Assert: Podman is installed
Process in onboarding with creating a podman machine
Assert: I am able to create Podman Machine with HyperV provider with an option to adjust mem/cpu
Actual result: Sliders for cpu/memory/disk size are not visible

Workaround: Restart PD
Relevant log output

Additional context
No response

@odockal I see the same. No sliders. Restarting PD does not help for my Windows 10 Pro installation. Tried with PD 1.14 and latest pre-release.

@dgolovin I have both providers (hyperv and wsl), although if I switch to hyperv in the dropdown after restart, it works for me well. I recall having only hyperv also worked after restart.

@odockal I tried it again today while testing #10356 and still have no sliders.

@dgolovin Strange. In any case, we see that sliders are missing when one tries to create podman machine after podman installation.


Unable to access PWD host/cluster via Portainer

Usually, I connected Portainer to PWD either when starting Portainer via the CLI with the -H flag or via the UI by defining a new endpoint.
I used to manage the PWD endpoints using the following url pattern ip10_0_XX_XX-2375.play-with-docker.com:80.
Example:
$ docker run -d -p 9000:9000 portainer/portainer -H tcp://ip10_0_XX_XX-2375.play-with-docker.com:80

Yesterday, when I tried it again I was not able to connect to PWD either from Portainer or via the CLI using this URL pattern. After a short discussion on twitter with @marcosnils (https://twitter.com/marcosnils/status/831108149860036608), he told me to update the URL pattern to ip10_0_XX_XX.play-with-docker.com.
Now, this is working fine when I use the Docker CLI with the -H flag but it's not working anymore with Portainer (either using the -H flag or when defining the endpoint from the UI).
Portainer tries to proxy the request to the PWD host/cluster and gets a 502 Bad Gateway issue.

@deviantony the problem is that portainer is making requests to PWD with the host header set as localhost:9000 when running locally.
here's a tcpdump capture of the info request portainer does
..GET /info HTTP/1.1
Host: localhost:9000
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/55.0.2883.87 Chrome/55.0.2883.87 Safari/537.36
Accept: application/json, text/plain, */*
Accept-Encoding: gzip, deflate, sdch, br
Accept-Language: en-US,en;q=0.8,pt-BR;q=0.6,pt;q=0.4,es;q=0.2,nb;q=0.2
Referer: http://localhost:9000/
X-Forwarded-For: ::1

You need to make sure that Host header is set to the PWD endpoint in order for it to work. I believe that's a problem with the portainer proxy. We made a change that relies on the Host sent by the caller in PWD and in this case an incorrect header is being sent.

Thanks for the update ! Have these changes related to the Host added recently ? Because it was working 2 weeks ago.

Yes, we deployed some changes regarding the Host header.
sent from mobile
On Feb 14, 2017 2:36 AM, "Anthony Lapenna"<EMAIL_ADDRESS>wrote:

Thanks for the update ! Have these changes related to the Host added
recently ? Because it was working 2 weeks ago.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/franela/play-with-docker/issues/93#issuecomment-279613023,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABgV2oKTaQavghQszGtr4l3t6NDk33zQks5rcT1cgaJpZM4MAAtM
.


Inject on multi frameworks project

Hello I have an issue with the integration please. I have a multi frameworks iOS project. I installed injectorIII and I did all the configuration (other linker flags...)
But when I make a change in a view controller  nothing change.

I have the same issue both for UIKit and swift ui views.
Any idea please?

Hi, difficult to say without more information. Do you have an @objc function injected() method on the ViewController which redraws when you inject? Looks like the code is being injected, just not called again to see the changes take effect. See the InjectionIII readme for details and information about what you need to do for SwiftUI.

Hello thank you yes it's work now. But I have many issues with embedded controllers or tableviewcell. Call to the viewdidload is insufficient

Hello again maybe a complete example will be great.
this my code now. first I made an extension for UIViewController.
public extension UIViewController {
static func loadFromNib<T: UIViewController>() -> T {
 T(nibName: "\(self)", bundle: nil)
        Inject.ViewControllerHost(T(nibName: "\(self)", bundle: nil)) as! T
}

  @objc func injected() {
     viewDidLoad()
    }
}

and I use viewController like this
let viewController = MyController.loadFromNib()
This work with viewController when I change every thing work. But I have a pain points with subViews like collectionViewCell, TableViewcell or any customViews. I think when I change my customcellView, injector compile only the class or struct and didn't reload the hall view.
Hope, it's more clear now.

Hi, you're getting the idea now. All Injection does is re-wire your program so function bodies are replaced, it's up to the user to arrange for those bodies to be called again so they can take effect typically using the injected() mechanism. If you come up with a clean abstraction for a common idiom that could be of use to other programmers like your loadFromNib() function file a PR and we can include it in Inject. A couple of ideas, have you explored using a class method returning type Self instead of a generic though it amounts to pretty much the same?


Observations and issues faced during migration of Hibernate-MySQL app to CloudSpanner

Creating an umbrella issue to track the problems faced. For the problems worth fixing, more granular issues can be created from the problems described at doc.

Broke this into individual issues, closing this bug.


Use dateutil to parse the date as the strptime does not support 'Z' time zone offset format

At least I'm getting timestamps with Z offset while accessing service api with my credentials.
eg. 'parkingTimeUTC': '2021-02-14T20:50:27Z'

At least I'm getting timestamps with Z offset while accessing service api with my credentials.
eg. 'parkingTimeUTC': '2021-02-14T20:50:27Z'

That looks like the raw data returned from the API, or is this really parsed data?
The API returns timstamps in format '%Y-%m-%dT%H:%M:%S%z' and parsed data is working fine with datetime strptime:
>>> from datetime import date, datetime
>>> val = "2021-02-15T13:14:02Z"
>>> datetime.strptime(val, "%Y-%m-%dT%H:%M:%S%z")
datetime.datetime(2021, 2, 15, 13, 14, 2, tzinfo=datetime.timezone.utc)

At least I'm getting timestamps with Z offset while accessing service api with my credentials.
eg. 'parkingTimeUTC': '2021-02-14T20:50:27Z'
That looks like the raw data returned from the API, or is this really parsed data?

RAW.

The API returns timstamps in format '%Y-%m-%dT%H:%M:%S%z' and parsed data is working fine with datetime strptime:

Yeah, it works python3.7 and newer. I was testing on vm which had 3.6 per default and it doesn't work there. Anyway I will close this as it works on newer python releases.


docs: update notes about pullrequest triggers

Why:
Closes: #22501
What's being changed (if available, include any code snippets, screenshots, or gifs):
--
Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Hi @lecoursen
It seems the pull request was removed from merge queue due to previously failed check, can you please look at it once again 🙏


update capacity unit metrics

change the capacity units throughput metric to read MB(megabyte) instead of Mb(megabit) to reflect how the metric is displayed for that resource in Azure Metrics, discussed this with support.

@quaintance : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#reassign:surajmb

@surajmb - Could you review this pull request from June? Thank you.

Hi @quaintance and @ktoliver , throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

Hi @quaintance and @ktoliver , throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

@quaintance The article author has feedback in your pull request for when have a chance to review it. Thanks.

throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

@quaintance The article author has feedback in your pull request for when have a chance to review it. Thanks.

Hi @quaintance and @ktoliver , throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

I had an in depth conversation with support about this and trying to clarify a difference between what I was observing and how the documentation read, they informed me that the document incorrectly categorized this as bits instead of bytes. If you're telling me that it is indeed correct then I'll go with that, unfortunately at this point it's been so long I don't have the detailed memory to recall exactly what issue we were seeing.

Hi @quaintance and @ktoliver , throughput (sent + received bytes) metric in Azure monitor is represented in bytes and not bytes per second and capacity unit definition is 2.22 Mbps (mega bits per second) using which a lot of billing calculations are done. So I don't see the need to change this to mega bytes here, that might further create confusion. Can you elaborate otherwise?

I had an in depth conversation with support about this and trying to clarify a difference between what I was observing and how the documentation read, they informed me that the document incorrectly categorized this as bits instead of bytes. If you're telling me that it is indeed correct then I'll go with that, unfortunately at this point it's been so long I don't have the detailed memory to recall exactly what issue we were seeing.

We'll close the pull request. Thank you.


No gruntfile found at: "" on Ubuntu 14.04

Hello,
on Ubuntu 14.04 Brackets Grunt plugin can't find gruntfile even though gruntfile.js in project location exists. Screenshot of this issue here http://55146.w46.wedos.ws/screenGruntIssue.png.
Thanks for any help.

Hi @holdav I've added support for gruntfiles that starts with lower case in #43

Thank you very much. Now it works!


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4681

Questions ?
Please refer to the Backport tool documentation


org.chromium.iossocketscommon not working with appgyver build service

Hi,
we are trying to get chrome.sockets.udp api working with Appgyver`s build service. Inserting this plugin as a dependency we are getting the following error. This happens on iOS builds only.
Adding {“source”:“org.chromium.iossocketscommon”} which is required by chrome.sockets.upd via  is the reason for the build error on iOS.
The build error log mentions the following
ld: 66 duplicate symbols for architecture armv7
pastebin.com/138Uz4gH
The build services resolves all dependencies for android – build successful.
Running the app via cca command line tool + inserting sockets permissions in the manifest.json file works for both iOS and Android!
"sockets": {
"udp": {
"bind": "",
"send": "",
"multicastMembership": ""
},
}
Thanks!

We don't have any concrete changes planned to address this, so closing for now.


making recursive = TRUE

Just adding a simple PR to make folders recursive in the dir.create() function if we want to download a file into a folder that doesn't exist yet.
Not 100% sure on why some lines are considered changed in this pr just based on formatting, but the only thing I did was make recursive = TRUE on the dir.create function

@christopherjin , I will merge this and another PR that I will likely create myself with something else that I was working on, and then I will create a new release.
Quick question before I merge and out curiosity: did you run any tool to clean extra spaces?

I'm not sure actually, I think it might just be Rstudio default formatting for some differences


v7.3.1 Preview Release preparations

Codecov Report

Merging #1083 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #1083      +/-   ##
============================================
- Coverage     54.55%   54.47%   -0.08%
+ Complexity     3373     3365       -8
============================================
  Files           124      124
  Lines         28755    28755
  Branches       4769     4769
============================================
- Hits          15686    15665      -21
- Misses        10803    10814      +11
- Partials       2266     2276      +10

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
43.95% <0%> (-3.3%)
15% <0%> (-1%)

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
55.97% <0%> (-1.5%)
15% <0%> (-1%)

...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java
59.76% <0%> (-1.19%)
34% <0%> (-1%)

...ooglecode/concurrentlinkedhashmap/LinkedDeque.java
27.69% <0%> (-0.77%)
19% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
44.1% <0%> (-0.27%)
326% <0%> (-4%)

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
38.79% <0%> (-0.22%)
43% <0%> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
68.66% <0%> (-0.12%)
0% <0%> (ø)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
61% <0%> (-0.1%)
0% <0%> (ø)

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
51.39% <0%> (-0.07%)
419% <0%> (-2%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
47.3% <0%> (ø)
112% <0%> (+1%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c9d83...56e7b9b. Read the comment docs.


CustomsearchService paging bug

I am using that api and paging doesnt work for me.

       var svc = new Google.Apis.Customsearch.v1.CustomsearchService(new BaseClientService.Initializer { ApiKey = apiKey });
        var listRequest = svc.Cse.List("site:www.mysite.com");
        listRequest.Cx = cx;
        listRequest.Start = 1;
        var search = listRequest.Execute();

and then i loop with changing  listRequest.Start = 11, 21, 31 and etc.
It stop working on 111, but in in search.Queries I see "nextPage" Query and it said TotalResults = 1098
Is it some limits on that api which not show more then 10 pages? Or I do something wrong?

I'm afraid I don't know much about that API - it's unlikely that it's the .NET client library that's causing the problem... I suspect you're best off asking on Stack Overflow with the google-custom-search tag.

You didn't say what you meant by stop working it should give you an error message.
However:
The default quota for Google custom search is

requests per day  100
requests per 100 seconds per user

If you want to use it more then that you will need to enable billing here is the pricing list

I dont think it is related to limits per day or per seconds, because it doesnt work at all if i put more then more then 100 and it show strange error like that
Invalid Value [400]
Errors [
	Message[Invalid Value] Location[ - ] Reason[invalid] Domain[global]
]

remove

listRequest.Start = 1;

@LindaLawton if I remove Start param then how to get other pages?

I tested it using Google apis exploer and it returns.
{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "invalid",
    "message": "Invalid Value"
   }
  ],
  "code": 400,
  "message": "Invalid Value"
 }
}

Which means this is an issue with the API and not an issue with the client library.   The client library is returning the same message as the API.   You should seek help on Stackoverflow   as to how to use the API.

@LindaLawton  if that api bug then it should be handled by Google api team. Can i wrote them somehow?

I think your first step would be to check with the people on stackoverflow before bothering the api team.  You need to be sure first that you are making your request correctly.
You can try there support forums but there doesn't appear to be much there.

and when I changed the code to Page.Num=12, it again generates error

I was getting this error as well.  Page num has to equal 1 and end with 10.
start = 1
end = 10
If you want a 100 results, iterate 10 times
start = 1
end = 10
start = 11
end =20
start = 21
end = 30
.....

That definitely sounds like this is an API quirk - it's unfortunate, but not something we can really change within the autogenerated client libraries. (Basically, we're faithfully passing along the user data to the server, which is what these libraries are meant to achieve.) It sounds like the workaround for providing the start/end each time works though.


spec: class: add __ctor, __dtor and __xdtor aliases

Signed-off-by: Luís Ferreira<EMAIL_ADDRESS>

Should we also refer to this on structs ?

There's no linked bugzilla issue, so what's the idea behind this PR? It's already specified that identifiers starting with a double underscore are reserved.

There's no linked bugzilla issue, so what's the idea behind this PR? It's already specified that identifiers starting with a double underscore are reserved.

Yes, but this has a special purpose, and as I said above, it is noted in some specification examples such as traits and structs. We should also follow the same struct section, which specifies the behaviour of __postblit and __xpostblit.

@ljmf00 can you please rebase your PR?

@ljmf00 can you please rebase your PR?

Yes, I'll add to my TODO list.

ping @ljmf00


Managed group API implementation 1/?

This PR implements the new managed API. All functions needed for the integration test are implemented.
Things that are not covered in this PR:

No new tests (integration test was written ahead of time
The Update Policy is not evaluated
Persistence

This PR is so big! Please, split it 😊

Sorry about this, the refactoring increased the PR quite a bit. I don't think it makes sense to split it though, because everything is sort of linked.

Looks good in general. I think some logging would be good, though. I don't think I saw any in-line.

True, there is no logging. I think we should define the logging levels in general and have a separate PR to add logging everywhere.

Only a couple nits left. We don't have to get the builder pattern right for ManagedGroupCallbacks now but we should find a solution for process_message. What I think would work as well is setting None and calling the error callback in the else case (if you don't want to use continue or some other control flow mechanisms).

I changed it so that it now uses continue. I can change the callback constructor in a follow-up PR if you point me to some documentation on what you would like to see exactly.


Optimizing Struct Field Alignment

Overview
In file: report_reflect.go, the fields of the formatValueOptions struct are organized in a way that takes more memory. The fields of the struct can be sorted in a way that takes less memory than the initial alignment.
type formatValueOptions struct {
	// AvoidStringer controls whether to avoid calling custom stringer
	// methods like error.Error or fmt.Stringer.String.
	AvoidStringer bool

	// PrintAddresses controls whether to print the address of all pointers,
	// slice elements, and maps.
	PrintAddresses bool

	// QualifiedNames controls whether FormatType uses the fully qualified name
	// (including the full package path as opposed to just the package name).
	QualifiedNames bool

	// VerbosityLevel controls the amount of output to produce.
	// A higher value produces more output. A value of zero or lower produces
	// no output (represented using an ellipsis).
	// If LimitVerbosity is false, then the level is treated as infinite.
	VerbosityLevel int

	// LimitVerbosity specifies that formatting should respect VerbosityLevel.
	LimitVerbosity bool
}

For the above alignment, the size of the struct is 24 bytes (for 64-bit systems). It can be reduced to 16 bytes by aligning the fields as follows:
type formatValueOptions struct {
	// VerbosityLevel controls the amount of output to produce.
	// A higher value produces more output. A value of zero or lower produces
	// no output (represented using an ellipsis).
	// If LimitVerbosity is false, then the level is treated as infinite.
	VerbosityLevel int

	// AvoidStringer controls whether to avoid calling custom stringer
	// methods like error.Error or fmt.Stringer.String.
	AvoidStringer bool

	// PrintAddresses controls whether to print the address of all pointers,
	// slice elements, and maps.
	PrintAddresses bool

	// QualifiedNames controls whether FormatType uses the fully qualified name
	// (including the full package path as opposed to just the package name).
	QualifiedNames bool

	// LimitVerbosity specifies that formatting should respect VerbosityLevel.
	LimitVerbosity bool
}

Sponsorship and Support:
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed - to improve global software supply chain security.
The bug is found by running the iCR tool by OpenRefactory, Inc. and then manually triaging the results.

Thanks, but no thanks. Outside of some very narrow performance-critical scenarios, we prefer code clarity over optimizing away every possible byte.
It's possible that a future version of the Go compiler will automatically reorder fields for optimal packing.


Breaking app

Hi Philipp, your demo looks great. I just ported to Flow Router today and love it so far. Unfortunately, when I add this package it immediately breaks my app, before I even try to implement anything. Any idea what I might be missing?

This error was due to the Flow-Router update to version 1.9.0, which changed the way you can get the route name.
Should be fixed now. Just update the momentum-flow-router package to 0.0.3
36411deca96e85fcaea7c8e4318991b24332408c

There is still some weirdness happening when changing routes.. seems to apply the wrong transition sometimes.. i'll look into it real quick

Alright back to normal again :)
Now the package is using Flow-Router 1.9.0 and working as usual.
The demo is also updated and deployed.

Thanks for the quick response. I updated and it fixed the errors. Unfortunately I'm having some trouble implementing in my app, but I'm guessing it's just confusion on my part. Is it possible to use this between different flow layouts? Or does it have to be the same layout?

Haven't tried different layouts yet. But that should not be a problem..

Yes switching layouts is a problem, since the html nodes that change are not wrapped inside the momentum flow router anymore..

So I did some research and it turns out, that momentum uses Meteors _uihooks in order to perform animations once a DOM node gets inserted. These only work for nodes, that get manipulated by Blaze, not nodes that you insert manually using jQuery or normal javascript. This is problematic since FlowLayout uses jQuery to render a new Layout to the DOM. And this is probably what would need to change in order to get this working...

worked on the flow-layout package and got it working:
http://flow-layout-transitions.meteor.com/
Made a Pull Request on the FlowLayout for this.. If that gets merged we'll have layout transitions :)

Hey, would you mind sharing the code for http://flow-layout-transitions.meteor.com/. I'd like to support it. But somehow I don't like the way you done it in the PR.

The Code is here: https://github.com/PhilippSpo/momentum-flow-router-demo/tree/flow-layout-transitions
I would be glad to reason about and improve the code :)


Speed-up processing with the multiprocessing module

Implement an option to apply multiprocessing where chromosomes are processed individually so that results can be obtained faster.
Consider limiting processes to number of physical cores instead of logical cores.

Fixed in a6dd0a8 and cf978bc.
Note that finding shared DNA does not benefit from parallelization currently. Perhaps due to this: https://stackoverflow.com/a/15641148


Fix MRL convert mines, reformat code

MineResetLite
Migrates

Region
Teleport Location
Mine blocks

Fix X-Prison can't migrate MineResetLite's mine (tried with latest version but look like it will work with other version)
Reformat code
Update depend
Fix build

https://github.com/Drawethree/X-Prison/pull/51/commits/3b02c0eca520d1bc1ac22df38ff10754757c928b Tested on 1.19.4 and worked

166df8d: Not tested yet


[BUG] Navbar component not found in releases after tag 1.0.0-beta.12

Describe the bug
When I run yarn add @nextui-org/react my package.json is updated with:

"@nextui-org/react": "^1.0.0-beta.12"

and the Navbar component doesn't seem to be included. It's not in my node_modules, and if I look in your repo, the Navbar is not exported in any of the tags after 10.0.0-beta12. When I tried changing my package.json to:

"@nextui-org/react": "1.0.0-beta.12"

and then run yarn install again, I get the Navbar component. I tried repeating it in Stackblitz, but had no problem finding the Navbar there. I run yarn 3.1.0 and Stackblitz run yarn 1.22.19, perhaps that's the problem, but it sounds weird since the component is not there in your repo either. All other components seems to be working. I use Typescript.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Set yarn version to 3.1.0
Run yarn add @nextui-org/react
Notice "@nextui-org/react": "^1.0.0-beta.12" in package.json
Try to import the Navbar on a page or component
Notice the error: Module '"@nextui-org/react"' has no exported member 'Navbar'.

Expected behavior
Being able to import the Navbar component like I can with all other components without making any changes to package.json after having run yarn add @nextui-org/react.
Screenshots or Videos
node_modules/@nexui-org folder with "@nextui-org/react": "^1.0.0-beta.12" in package.json:

node_modules/@nexui-org folder with "@nextui-org/react": "1.0.0-beta.12" in package.json:

Screenshot of error in vscode:

Operating System Version
macOS
Browser
Chrome

I am facing the same problem :(

You can fix this by locking the version in your package.json: "@nextui-org/react": "1.0.0-beta.12" (notice the removed ^)

If you look at my issue above, you can see that I have "solved" it the same way. I still think it's a bug, I don't think that I should have to make changes to my package.json after install. It should be fixed so that the correct version is downloaded when I run yarn add @nextui-org/react.

It is just caused due to the versioning system used and is probably not compatible with the standard SemVer versioning system NPM uses.

Hey guys sorry for the delay please upgrade to V2

@jrgarciadev please add Container , Row and Col etc. in 2.2.9V because its available in beta -v.


Bug report: Updating an app for teams gives a 403.

Description
When i try to push a new version of the Teams app, i get a 403 unauthorized error. The user i am using are a global administrator. I've even created a new global admin, just to verify.
I successfully log in using this method:
m365 login --authType password --userName brandnewusername --password password
m365 teams app update --id guid --filePath  "d:\temp\TeamsApp_buildId-dev.zip" --verbose
But when i run the last command i get this error:
Updating app with id '0fb5f49b-a660-4b24-a118-d191bc8e42c3' and file 'd:\temp\TeamsProjectPortalApp_9811-dev.zip' in the app catalog...
Error: Request failed with status code 403
Steps to reproduce
m365 login --authType password --userName brandnewusername --password password
m365 teams app update --id guid --filePath  "d:\temp\TeamsApp_buildId-dev.zip" --verbose
m365 teams app list: shows me the correct output
m365 status: shows me that i am connected as the correct user also.
Expected result
The expected result would be to successfully update the app in the app catalog.
Actual result
Error: Request failed with status code 403
Environment
Using M365-Cli v3.4.0.
i have tried multiple node versions. (15.6.0 and 14.15.4).

Thanks for reporting @eiriksanderfjeld apologies for the trouble, we will take a look ASAP.
Can I ask whether this is the first time you have used the command or has this just stopped working?

Thanks for reporting @eiriksanderfjeld apologies for the trouble, we will take a look ASAP.
Can I ask whether this is the first time you have used the command or has this just stopped working?

This worked before new year. It worked both locally and in Azure DevOps deploy pipeline.

This worked before new year. It worked both locally and in Azure DevOps deploy pipeline.

Thanks for the extra information, it seems like we've introduced a regression when refactoring the code base to remove some dependencies.
Again, apologies for the trouble, we will aim to get you unblocked ASAP.

Thanks for the extra information, it seems like we've introduced a regression when refactoring the code base to remove some dependencies.
Again, apologies for the trouble, we will aim to get you unblocked ASAP.

Hey @eiriksanderfjeld, I can't reproduce the issue using the latest preview version. Could you please give it a try and see if the issue is still there? If you're still seeing the issue, could you please run the command with --debug and share with us the detailed output (don't forget to truncate the access token). Appreciate your help.

Hey @eiriksanderfjeld, I can't reproduce the issue using the latest preview version. Could you please give it a try and see if the issue is still there? If you're still seeing the issue, could you please run the command with --debug and share with us the detailed output (don't forget to truncate the access token). Appreciate your help.

Right, thanks. Here is the output from debug. I've removed ids, token and data buffer. If i decode the token i get this scp:
"scp": "AllSites.FullControl AppCatalog.ReadWrite.All Directory.AccessAsUser.All Directory.ReadWrite.All Group.ReadWrite.All IdentityProvider.ReadWrite.All Mail.Send Reports.Read.All TermStore.ReadWrite.All User.Invite.All User.Read.All",
`

& "node$exe"  "$basedir/node_modules/@pnp/cli-microsoft365/dist/ind ...

+ CategoryInfo          : NotSpecified: (Executing comma...utput":"json"}}:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError

Updating app with id '123123123123123' and file 'd:\temp\App_9811-dev.zip' in the app catalog...
Existing access token  still valid. Returning...
Request:
{
"url": "https://graph.microsoft.com/v1.0/appCatalogs/teamsApps/123123123123123",
"method": "put",
"data": {
"type": "Buffer",
"data": [
...removed..
]
},
"headers": {
"common": {
"Accept": "application/json, text/plain, /"
},
"delete": {},
"get": {},
"head": {},
"post": {
"Content-Type": "application/x-www-form-urlencoded"
},
"put": {
"Content-Type": "application/x-www-form-urlencoded"
},
"patch": {
"Content-Type": "application/x-www-form-urlencoded"
},
"user-agent": "NONISV|SharePointPnP|CLIMicrosoft365/3.4.0",
"accept-encoding": "gzip, deflate",
"content-type": "application/zip",
"authorization": "Bearer "
},
"responseType": "text",
"decompress": true
}
Request error
{
"status": 403,
"statusText": "Forbidden",
"headers": {
"cache-control": "private",
"content-type": "application/json",
"request-id": "",
"client-request-id": "",
"x-ms-ags-diagnostic": "{"ServerInfo":{"DataCenter":"West Europe","Slice":"SliceC","Ring":"5","ScaleUnit":"000","RoleInstance":"AGSFE_IN_76"}}",
"strict-transport-security": "max-age=31536000",
"date": "Fri, 22 Jan 2021 09:11:22 GMT",
"connection": "close",
"content-length": "640"
},
"data": "{\r\n  "error": {\r\n    "code": "Forbidden",\r\n    "message": "Failed to execute AuthService backend request GetSkypeTokenRequest. Workload Unknown. Request Url: https://authsvc-server.teams.microsoft.com/v1.0/authz, Request Method: POST, Response Status Code: Forbidden, Response Headers: Strict-Transport-Security: max-age=31536000; includeSubDomains\r\nDate: Fri, 22 Jan 2021 09:11:22 GMT\r\nServer: Kestrel\r\n, Reason Phrase: Forbidden",\r\n    "innerError": {\r\n      "date": "2021-
01-22T09:11:23",\r\n      "request-id": "",\r\n      "client-request-id": "d"\r\n    }\r\n  }\r\n}"
}
Error: Request failed with status code 403
`

Right, thanks. Here is the output from debug. I've removed ids, token and data buffer. If i decode the token i get this scp:
"scp": "AllSites.FullControl AppCatalog.ReadWrite.All Directory.AccessAsUser.All Directory.ReadWrite.All Group.ReadWrite.All IdentityProvider.ReadWrite.All Mail.Send Reports.Read.All TermStore.ReadWrite.All User.Invite.All User.Read.All",
`

& "node$exe"  "$basedir/node_modules/@pnp/cli-microsoft365/dist/ind ...

+ CategoryInfo          : NotSpecified: (Executing comma...utput":"json"}}:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError

Updating app with id '123123123123123' and file 'd:\temp\App_9811-dev.zip' in the app catalog...
Existing access token  still valid. Returning...
Request:
{
"url": "https://graph.microsoft.com/v1.0/appCatalogs/teamsApps/123123123123123",
"method": "put",
"data": {
"type": "Buffer",
"data": [
...removed..
]
},
"headers": {
"common": {
"Accept": "application/json, text/plain, /"
},
"delete": {},
"get": {},
"head": {},
"post": {
"Content-Type": "application/x-www-form-urlencoded"
},
"put": {
"Content-Type": "application/x-www-form-urlencoded"
},
"patch": {
"Content-Type": "application/x-www-form-urlencoded"
},
"user-agent": "NONISV|SharePointPnP|CLIMicrosoft365/3.4.0",
"accept-encoding": "gzip, deflate",
"content-type": "application/zip",
"authorization": "Bearer "
},
"responseType": "text",
"decompress": true
}
Request error
{
"status": 403,
"statusText": "Forbidden",
"headers": {
"cache-control": "private",
"content-type": "application/json",
"request-id": "",
"client-request-id": "",
"x-ms-ags-diagnostic": "{"ServerInfo":{"DataCenter":"West Europe","Slice":"SliceC","Ring":"5","ScaleUnit":"000","RoleInstance":"AGSFE_IN_76"}}",
"strict-transport-security": "max-age=31536000",
"date": "Fri, 22 Jan 2021 09:11:22 GMT",
"connection": "close",
"content-length": "640"
},
"data": "{\r\n  "error": {\r\n    "code": "Forbidden",\r\n    "message": "Failed to execute AuthService backend request GetSkypeTokenRequest. Workload Unknown. Request Url: https://authsvc-server.teams.microsoft.com/v1.0/authz, Request Method: POST, Response Status Code: Forbidden, Response Headers: Strict-Transport-Security: max-age=31536000; includeSubDomains\r\nDate: Fri, 22 Jan 2021 09:11:22 GMT\r\nServer: Kestrel\r\n, Reason Phrase: Forbidden",\r\n    "innerError": {\r\n      "date": "2021-
01-22T09:11:23",\r\n      "request-id": "",\r\n      "client-request-id": "d"\r\n    }\r\n  }\r\n}"
}
Error: Request failed with status code 403
`

Using the same account, can you update the same app through the Teams UI?

Using the same account, can you update the same app through the Teams UI?

Yes, i have no issues when i add the same app through the Teams UI. (Microsoft Teams admin center).

Yes, i have no issues when i add the same app through the Teams UI. (Microsoft Teams admin center).

Do you get the same error when trying to update another app using CLI?

Do you get the same error when trying to update another app using CLI?

Closing due to lack of response

If this is still an issue, could you run the reconsent command and see if that fixes the issue for you?
m365 cli reconsent


Updates for daily loading, kibo, sqlalchemy 2.

This PR:

Updates SQLAlchemy code to SQLAlchemy 2 (now installed at NERSC).
Add a convert() method to database objects (ORM classes). Basically each table knows how to convert data tables into database objects.
Adds some configuration needed to load kibo.
Adds support for tile-based loading, which will be needed to support loading daily.
Adds code for patching daily exposure and tile files based on another specprod.

Note that there is some remaining work to be done:

Remove redundant code now that all database objects have a convert() method. This should be included in this PR.
Some additional work is needed to support tile-based updates (in the SQL UPDATE sense). This may or may not end up being included in this PR.

Also make sure to keep the tests in #12 in mind. To recap:

If one or more tables in a given specprod schema contain columns that are not described by the associated ORM object(s), that's OK.
If one or more ORM objects describe columns that are not in an associated table in a given specprod schema, that's BAD.

In other words, if we have to add columns for kibo, we have to preserve a version that does not have those columns in order to work with iron.
Finally, we may need to preserve an environment that contains SQLAlchemy 1.x in order to work with fuji.

Note: this PR, changes the size of Exposure.goaltype and Tile.goaltype relative to iron. Make sure this change works with iron.  There should not be any other column changes relative to iron in this PR. If necessary, revert those changes for the purposes of making a DR1 tag, then update the sizes for kibo.

I tested iron with an updated tutorial notebook. Based on that, I'm going to merge and tag a version that we know still works with both iron and SQLAlchemy 2.


Option to render page before PageLoadData has been received

Describe the problem
Hello guys,
is there a way  to optionally tell SvelteKit to not wait for the Page Load Data and start rendering the page?
Especially in areas with slow internet connection or with a big load data response I'd like to show a loading spinner after page has initially rendered but is waiting for the Page Load Data to arrive, because this is helpful to motivate users to keep waiting. Otherwise the page might look like freezing when navigating. Even pages that have been previously been rendered will look like freezing if internet is slow and the user returns to that page and page data needs some secs to arrive.
Describe the proposed solution
Allow page to render without first receiving Page Data, for example with a flag in +page.svelte.
There should be available two variables or readable stores i.e. isLoading and isValid (to know if there was a error) to allow for different handling like showing a spinner.
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

Duplicate of #7213.


PR: #97: Added functionality to the home page and user page search bar.

Currently they both redirect to an empty search results page if an input is given. I will update this later on to include search results based on how we will store multiple user information. An issue I have right now is styling, as after I changed the search bar on the home page it is no longer centered.

Why is the search bar all the way to the left now?


Bash completions

It would be great to have tab-completion work for the various commands.

I am wondering whether it makes sense to implement this in Python language. If that is acceptable, I could implement one with relatively smaller effort due to the former work that I have done in the other projects. I choosed Python because it turns out similar auto-completion would need much more effort in C.
The auto-completion affect that can be implemented using the similar codes would be something like following. After running, we can run "./mpifileutils" to go to interactive mode. And we can select sub-command (e.g. dcp, dcmp etc) in the command. And of course, the sub-command can be auto-completed when typing tab. And after selecting sub-command, e.g. dcp, all the options (i.e. -d -g -i -p etc. for dcp) can be autocompleted. And not only command options, the file patch can be auto-compelted too.
This would need a lot of work. And quite some Python codes will be introduced. Thus need to know whether that is what everyone wants for this project. :)

I don’t think the ‘interactive mode’ use case is very helpful for this project (except maybe for the dsh tool). I know there is some overhead of interaction with multiple MPI tasks, which is probably too much of a complication.
Out of curiosity, what is the name of the python tool?
Thank you very much for volunteering! We would welcome your contributions elsewhere in this project.

No problem. I will look for other things that I can help. :)
The tool is a series of commands for Lustre on Demand which is used for fetching and syncing the data between a global large (slow) Lustre and a small quick Lustre that are used for caching for each job.

@LiXi-storage , thanks for offering to help.
We've had some people asking for improved support on sparse files, e.g., https://github.com/hpc/mpifileutils/issues/294.  I just created some new issues of areas where I think we could benefit.  At LLNL, we don't have a lot of users who write sparse files nor do we have the file systems needed to fully test the code, e.g., asking for file extents.  Since you originally contributed this feature, I was wondering if you'd be willing to look to extend it to other tools and to test it.
Similarly, I think the group lock optimization could be extended to other use cases, perhaps it makes sense to add it to dbz2 or dstripe?  Again, that's one that we can't test at LLNL, and so it's not easy for us to develop.


Pretrained checkpoint and configuration for reaching the described reward.

Thanks so much for sharing this implementation, I think it's a really fantastic implementation.  I would love to try it out and see if I can duplicate the results but I'm running into some issues.
When I run ./train_baseline.sh I see messages like this:
Discarding 130 old rollouts, cut by policy lag threshold 10000 (learner 0)
and the learner doesn't seem to learn anything.  I know this can be fixed by setting the --max_policy_lag but the fact it's coming up now implies that either my local setup is different (maybe versions?) or a different configuration was used?  If it's the latter would be possible to share a working configuration?
I tried training from scratch by removing the train_dir which increased the episode_len without marginal increase to the reward before running into the same "discarding old rollouts" issue.
Discarding 130 old rollouts, cut by policy lag threshold 10000 (learner 0)
Similarly when using the run.sh script the reward seems to be a lot less than what is described.  Perhaps the checkpoint doesn't contain a fully trained policy?
[2022-02-24 21:05:07,513][06642] Episode finished for agent 0 at 49393 frames. Reward: 34.000, true_reward: 34.000
[2022-02-24 21:05:07,513][06642] Avg episode rewards: #0: 41.200, true rewards: #0: 41.200
[2022-02-24 21:05:07,514][06642] Avg episode reward: 41.200, avg true_reward: 41.200

Thanks for reporting this! Not freezing all versions bites me yet again (one day I will learn). Try installing pip install nle==0.7.3 (the version this was built on), and run.sh will run much better. pip install nle==0.8.0 seems to work, too. Below is my complete pip freeze for reference (it contains some extra packages).
@heiner I do not see bigger changes in the changelog for v0.8.1, but the performance of training/evaluating drops here + evaluating becomes very slow (agent could be stuck in menus or code could be running slow).  And my apologies if we broke NLE.
Are you positive it was changes from 0.8.0 to 0.8.1 that caused this? Because as far as I can tell, we changed two things only:

How NLE gets nethack settings (no longer uses env variables as they introduce race conditions). I hope this isn't the cause of the issue, and I also can't imagine how it would still run at all but be problematic here.
We made a breaking change to the action space, adding all SEE* actions. This would impact already-trained models, but I hope it wouldn't change things (much) when you train from scratch?

Ah! That was it, doh :). My eyes checked the first part of the 0.8.1 log but skipped the next, quite important section of "breaking changes". My bad! Sorry for the trouble! All is good (except pretrained models, unsurprisingly).
@ngoodger I also tried training with nle==0.8.1 and it works as expected, there are no Discarding 130 old rollouts, cut by policy lag threshold 10000 warnings for me. I am running Ubuntu 20.04LTS with 16 cores and RTX 2080Ti. Check that the trainer process is correctly running (there should be one Python process that is at 100% CPU usage and uses plenty of GPU).

@Miffyli: Thanks for the update. And thanks for this great baseline btw, we've learned a lot from it. @condnsdmatters has grabbed a number of ideas from this and put it into a moolib agent that I hope we can release at some point.

Amazing, thanks both!  Really appreciate the assistance.
Can confirm I was able see much higher reward when using using the run.sh script on nle==0.7.3.
Thanks for sharing your configuration and thanks for testing again.  I'm using a  Ubuntu 20:04 in WSL with 8 cores and a 3090 so I guess the learner should be faster but I can't run as many workers.  Anyway I feel a lot more confident now you have tested it recently, so I should be able to to get it work.  Thanks again.

Thank you for the kind comments, they are always welcomed :). Good luck tinkering with NLE!
Closing as resolved.


Multiple routes within the controller

Hi @TownedCrown,
I noticed your "Multiple routes within the controller #40" issue. Could you please provide more details on what you mean by "Multiple routes within the controller"?
This will help us better understand your needs.
Thanks!


[ DOCUMENTATION ] Improve navigation menu

I've been using Semantic for about 2 months now, and I'm finding the navigation menu difficult to use.
Problem: the side menu is very long
Might be an idea to convert it to a Mega Menu.
Problem: The categorisation is weak
There's a lot of hunting around to find things:

Things like Rail, Modal, Segment, Grid, Card should be moved to something like "Layout"
Form elements should go in their own "Forms" section

I may know up a demo then a PR to suggest.

Sorry, just realised there's a Documentation repo. I'll use that.


"check mount for updates" non-functional

Hi, great app!
I noticed that if you click on installed APPs and then "check mount for updates" button, it brings up a blank window with just a 'search' button that the top. When this is clicked, it appears to open a non-related search for the window underneath.  Just thought I'd let you know that the mount is not populating when trying to check for updates.

Hm, ok. I guess I was just trying to use it with a local directory (I manage my games/updates locally, not on a mirror). It doesn't seem to be working with a local directory.  Not a big deal, but figured you might want to know!
Thanks

You can make local folder like alias by rclone.conf (https://wiki.vrpirates.club/en/Howto/sidenoder#making-your-resilio-sync-folder-accessible-as-the-remote-tab)
You need folder "Quest Games" at the root of this "remote" for updates checking


test,job: Fix deadlock in TestOneShot_RetryRecoverNoShutdown

This test asserts that the function under test is called again if the first call to the callback returned an error. A channel is used to signal to the test function that the callback has started, this signal being the closure of a channel. But channels are only allowed to be closed once, so the code would set the channel to nil after closing it and wrap the closing code in a nil-check. This works 99.999% of the time since the consumer of the channel will continue. However, it sometimes happens that the channel is set to nil before the consumers flow has been started, resulting in a deadlock since reading from a nil channel always blocks. So, to fix it, we now simply look at the i variable and don't set the channel to nil anymore.
Fixes: #25276
Fixed flake in pkg/hive/job tests.

/test

All codeowner teams covered and all tests green, marking ready-to-merge


AttributeError on 'BERTPreprocessor'

Hey @amaiya
There is no issue for loading and preprocess the data using texts_from_csv and texts_from_df, but after this step, I wanted to load the pretrained BERT model and pass the preproc to it then I hit this issue which is
AttributeError: 'BERTPreprocessor' object has no attribute 'max_features'
I did set up the max_features in the load data methods and I have tested the return preproc object and there is no 'max_features' attribute.

Thank you for reporting this issue.  This should now be fixed.  Please upgrade ktrain to v0.3.1.

Thank you for the upgrade.


Enabling ansible-lint action

Setting it to be optional for now. Also adding the requirements.yml needed for all roles in this repo

@tonyskapunk @fredericlepied PTAL I think this is what we talked about during our sync


Volume paths arent working

Question:
Hi,
I seem to be having an issue where the mounts for a certain container dont seem to be working. The docker runs fine but when i go to the actual file location from another computer all folders are empty

We need substantially more information to be able to provide any assistance. Error logs, screenshots, etc.

No problem!
So created a docker as i always do using the following mounts
},
"HostnamePath": "/var/lib/docker/containers/cfbedbe5bbe38684cebac4e7a3d1ee23ace5594f3d5f1ed600fd4531b674b5fb/hostname",
"HostsPath": "/var/lib/docker/containers/cfbedbe5bbe38684cebac4e7a3d1ee23ace5594f3d5f1ed600fd4531b674b5fb/hosts",
"Id": "cfbedbe5bbe38684cebac4e7a3d1ee23ace5594f3d5f1ed600fd4531b674b5fb",
"Image": "sha256:c7bba63f2189919032c4e1d47ab13cd231c4d2eb63fdecad1d05cc41eff30e2a",
"LogPath": "/var/lib/docker/containers/cfbedbe5bbe38684cebac4e7a3d1ee23ace5594f3d5f1ed600fd4531b674b5fb/cfbedbe5bbe38684cebac4e7a3d1ee23ace5594f3d5f1ed600fd4531b674b5fb-json.log",
"MountLabel": "",
"Mounts": [
{
"Destination": "/data",
"Mode": "",
"Propagation": "rprivate",
"RW": true,
"Source": "/mnt/nfs-1/minecraft/data",
"Type": "bind"
},
{
"Destination": "/mods",
"Mode": "",
"Propagation": "rprivate",
"RW": true,
"Source": "/mnt/nfs-1/minecraft/mods",
"Type": "bind"
},
{
"Destination": "/config",
"Mode": "",
"Propagation": "rprivate",
"RW": true,
"Source": "/mnt/nfs-1/minecraft/config",
"Type": "bind"
}
],
When i try and look at the locations from a seperate computer they are empty

Here is the last set of logs from when it looks like i restarted portainer
2020/04/29 02:15:38 Starting Portainer 1.20.1 on :9000
2020/04/29 02:16:03 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2020/04/29 02:16:03 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2020/04/29 02:16:03 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2020/04/29 02:16:32 http error: Invalid credentials (err=Unauthorized) (code=422)
2020/04/29 02:16:32 http error: Invalid credentials (err=Unauthorized) (code=422)
2020/04/29 12:47:25 http error: Invalid JWT token (err=Invalid JWT token) (code=401)

Ok so as you are using bind mounts, you need to check the mounts are actually working on the host.
Type “mount” and look to see if you have a nfs mount for nfs-1
Go to the host via ssh, and navigate to /mnt/nfs-1/minecraft
See if there are any folders in it.
Type “touch testfile.txt”
Go to your other pc and see if that testfile is visible.
My guess; the nfs mount to the docker host has failed/is not working.

I think your guess is correct, i am able to navigate to the folder in SSH and see the associated folders withing /mnt/nfs-1/minecraft. I created the testfile and confirmed i can see it using ls
but when i go to and check from the PC i cannot see the file and when i check the properties of the network folder it is blank


Change address of claim to court being filed in

Instead of asking for the address of the claim, focus on what court is being filed in.

The venue/court will be based on either (1) the plaintiff's/s' address(es), (2) the defendant's/s' address(es), or another court. So we can offer those as options on the court selection page, plus give the user the option to select another court.


API should have a /mods method to list mods

I'm writing a packaging system for solder mods. With the current API, it's impossible to list all mod slugs. This feature would be immensely useful for not needing to hook into the mod repository directly.

Alternatively /api/mod could return an array of mods if no mod is specified. Like /api/modpack currently does.

This should be closed, one step closer to 0.7.3 :+1:

@GenPage this has been complete for 6 months now, can we close it out?

@Indemnity83 Sorry about that. Thanks for the reminder. Closing


Writer.prototype.parse to cache by tags in addition to template string

Resolve #617
Because the results of Writer.prototype.parse depends on both the template string and the tags, it should cache by both

@dasilvacontin Addressed your comment -- good catch! I actually meant to test the template with Mustache.tags as the delimiters, with it being braces.

@dasilvacontin Awesome, thanks!

I started refreshing my memory about the other PR, but I don't have enough time today. Will do tomorrow morning.

@dasilvacontin no rush! Thanks!

I am afraid this PR caused breaking change for us.
We are doing following:

parse our template with custom tags
render the template - according to mustache.js:465 our custom tags are not used, hence the tokens are different and custom tags are not recognized

@petrkoutnysw a bug fix landed after this got merged: https://github.com/janl/mustache.js/pull/664. This is also what's included in v2.3.1 of mustache.js.
Are you sure you're using the latest version? Or have I misunderstood and you have found another bug?

@phillipj Yeah I have 2.3.1.
It is quite easy - if you take a look at parse function (line 465), it creates a cache using tags if cache does not exist already.  Then you call render function that calls parse internally without specifying tags. Thus it is getting wrong tokens. Hope it makes sense, I have not been reading mustache code previously.
Anyway, we froze our mustache to 2.3.0.

@petrkoutnysw Do you have replication steps (the template you used and how you made the call to render it)?

@petrkoutnysw
It tried the following code:
mustache.parse('<<foo>>bar', ['<<','>>']);
mustache.render('<<foo>>bar', { foo:'biz'})

Which outputs "<>bar" as expected.
Then, if I do:
mustache.tags=['<<','>>']
mustache.render('<<foo>>bar', { foo:'biz'});

It outputs "bizbar", again as expected.
How are you setting the custom tags (there's only one way as far as I can tell) and calling the render function?

@raymond-lam Give me some time please, I am on conference and don't have time to reply right now. Thanks.

Maybe these two gives valuable input here? https://github.com/janl/mustache.js/issues/669 & https://github.com/janl/mustache.js/pull/662

@phillipj @petrkoutnysw Ah yes I see those reported issues now -- I'll have a look.


Add Atom feeds to judgment browse URLs

Adds an Atom XML feed for each of the browse urls. You can access the atom feeds by appending "/feed.xml" to the url, e.g. /ewca/civ/2017/feed.xml

Looks like it will do the job; we might want to tidy up to merge the HTML and Atom views into one, and use content negotiation, but I'm happy to let this through for now in the interests of speed (and me not knowing how to suggest how that refactor would work).


Cannot build using riscv gcc on Debian

Hello, I tried to build some examples for a RISC-V architecture on a Debian machine having installed the requirements specified in this repo's description, but ran into a error. However, using a RISC-V compiler from SiFive's GNU Embedded Toolchain — v2020.12.8 works.
$ dpkg -l | grep gcc-riscv64-unknown-elf
ii  gcc-riscv64-unknown-elf                       <IP_ADDRESS>9.08+dfsg-1                   amd64        GCC compiler for embedded RISC-V chips
$ dpkg -l | grep picolibc-riscv64-unknown-elf
ii  picolibc-riscv64-unknown-elf                  1.5.1-2                                all          Smaller embedded C library for RISC-V development
$ uname -a
Linux matei-debian 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux
$ which riscv64-unknown-elf-gcc
/usr/bin/riscv64-unknown-elf-gcc
$ make RISCV=1
 DIR        ../../libtock/build/cortex-m0
  CC        ../../libtock/internal/alarm_internal.c
  CC        ../../libtock/internal/nonvolatile_storage_internal.c
  CC        ../../libtock/adc.c
  ...........................................................................................
  AR        ../../libtock/build/cortex-m7/libtock.a
 DIR        ../../libtock/build/rv32imac
  CC        ../../libtock/internal/alarm_internal.c
In file included from ../../libtock/tock.h:4,
                 from ../../libtock/internal/alarm.h:3,
                 from ../../libtock/internal/alarm_internal.c:1:
/usr/lib/gcc/riscv64-unknown-elf/8.3.0/include/stdint.h:9:16: fatal error: stdint.h: No such file or directory
 # include_next <stdint.h>
                ^~~~~~~~~~
compilation terminated.
make: *** [../../TockLibrary.mk:154: ../../libtock/build/rv32imac/alarm_internal.o] Error 1```

Has anybody experienced this issue before?

<IP_ADDRESS>9.08+dfsg-1 that 2019 is conspicuously old.
I don't believe we have anyone who uses Debian as their primary distribution, so I don't think we have a sense of which packages are necessary on Debian-proper. If you have a path to a working toolchain / install directions for Debian, I imagine we would appreciate a PR updating the README with directions for Debian. @bradjc might have a better sense of the risc-v packaging.
I still live in a pretty ARM-only universe. All I do is keep building RISC-V off by default, because their toolchain installation is sadly still a mess (which, this unfortunately just continues to serve as evidence of :/ ).

You are missing a libc, which libtock-c expects.
You can build it yourself, which the README describes, just look for the section If you would rather compile your own newlib-based libc, follow the steps below. Section [newlib-nano](https://github.com/tock/libtock-c/blob/master/newlib-nano) describes some extra config options to build a size optimised newlib.
For Debian you should also be able to use picolibc though. You should be able to just install the package https://packages.debian.org/stable/devel/picolibc-riscv64-unknown-elf which includes support for 32-bit RISC-V

I had a go at updating the documentation to include instructions using Debian. Try following this and let me know how it goes: https://github.com/alistair23/libtock-c/tree/alistair/rv32-support

I've tried the following with no success:
~/libtock-c/examples/c_hello$ git checkout alistair/rv32-support
Branch 'alistair/rv32-support' set up to track remote branch 'alistair/rv32-support' from 'origin'.

As I've already mentioned, yes.
$ dpkg -l | grep picolibc-riscv64-unknown-elf
ii  picolibc-riscv64-unknown-elf                  1.5.1-2

For debugging it's useful to see the command being run, that can be enabled with V=1.


Initial on-boarding requires homeassistant authentication provider

Home Assistant release with the issue:
0.77.3

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):
Docker

Component/platform:
authentication providers

Description of problem:
From a clean install, the initial on-boarding process requires that the homeassistant authentication provider is configured.  For example, if only the legacy_api_password authentication provider is configured, the initial on-boarding process prompts the user to create a user account which fails.  This also occurs using the trusted_networks authentication provider by itself.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
homeassistant:
  name: Home
  latitude: 40.6892
  longitude: -74.0445
  elevation: 5
  unit_system: imperial
  time_zone: America/New_York

  auth_providers:
#    - type: homeassistant
    - type: legacy_api_password

frontend:

config:

http:
  server_port: 8123
  base_url: homeassistant.local
  api_password: "abc123"

conversation:

history:

logbook:

tts:
  platform: google

group: !include groups.yaml
automation: !include automations.yaml

Traceback (if applicable):
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 242, in data_received
    messages, upgraded, tail = self._request_parser.feed_data(data)
  File "aiohttp/_http_parser.pyx", line 519, in aiohttp._http_parser.HttpParser.feed_data
aiohttp.http_exceptions.BadStatusLine: invalid HTTP method
2018-09-10 22:07:07 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 390, in start
    resp = await self._request_handler(request)
  File "/usr/local/lib/python3.6/site-packages/aiohttp/web_app.py", line 352, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 106, in impl
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/static.py", line 66, in staticresource_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/real_ip.py", line 34, in real_ip_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/ban.py", line 67, in ban_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/auth.py", line 68, in auth_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/real_ip.py", line 34, in real_ip_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/ban.py", line 67, in ban_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/auth.py", line 68, in auth_middleware
    return await handler(request)
  File "/usr/src/app/homeassistant/components/http/view.py", line 113, in handle
    result = await result
  File "/usr/src/app/homeassistant/components/http/data_validator.py", line 47, in wrapper
    result = await method(view, request, *args, **kwargs)
  File "/usr/src/app/homeassistant/components/onboarding/views.py", line 86, in post
    provider = _async_get_hass_provider(hass)
  File "/usr/src/app/homeassistant/components/onboarding/views.py", line 107, in _async_get_hass_provider
    raise RuntimeError('No Home Assistant provider found')
RuntimeError: No Home Assistant provider found

Additional information:

If you are on a "clean install", you should not have any "auth_providers:" config section. HA will auto config auth providers. That already stated in release note, default config, and documentation.

All I recall seeing in the documentation is that if I do not want to configure anything Home Assistant will take care of it automatically.  As I stated here, from a clean install (maybe I should have stated this as a clean install with a defined config file) all I wanted was legacy_api_password or trusted_network.  I do not recall seeing where the documentation states that I must have homeassistant.  There are even examples in the documentation that do not specify the homeassistant auth provider:
homeassistant:
  auth_providers:
   - type: trusted_networks

# Temporary, this will be moved to be part of auth provider config
# https://github.com/home-assistant/home-assistant/issues/16149
http:
  trusted_networks:
    - <IP_ADDRESS>
    - ::1
    - <IP_ADDRESS>/24
    - fd00::/8

homeassistant:
  auth_providers:
   - type: legacy_api_password

http:
  api_password: !secret http_password

As document said it is advanced usage, and you have to understand what you are dealing with.
homeassitant auth provider is not necessary, but user is necessary. If you don't have user setup, we will direct you to onboarding process.
You can have several way to workaround it.

Create user via onboarding process by enable homeassistant auth provider, then remove homeassistant auth provider.

Or you call auth_manager API to create user, even edit .storage/auth file to manipulate your users.

Note: neither way will get support from me although I am giving your workaround solution.
I am going to lock this thread since it is not a bug.


Feature request: Possible to filter "Object Type" when comparing models with ALM Toolkit?

Hi,
It would be very helpful to filter on the "Type" field when comparing models.
For example if I only want to compare "Measures" between two models and ignore the other differences I could put a filter on type = measure.
If this is already possible please point me in the right direction for how to do this.

Sorry I missed this. This is not planned, but will keep it in mind!


SCRIPT438: Object doesn't support property or method 'yadcf'

Hi,
I am getting the following run time  error when trying to open the developer tools, Could you please help me with the same
Thanks,
Suman

Post your datatables and yadcf code for a better answer.
p.s question should be asked on stackoverflow, use github for issues/feature requests only