FlowControlHandler is passing read events when auto-reading is turned off

Expected behavior
Not passing read events onto the pipeline (calling ctx.read() which results in reading from the client socket) when the queue is empty and auto-reading is turned off for the channel. I would suggest that the expected behavior should look something like the following piece of code:
if (dequeue(ctx, 1) == 0) {
	shouldConsume = true;
	ctx.read();
} else if (ctx.channel().config().isAutoRead()) {
	ctx.read();
}

Actual behavior
Read events are passed onto the pipeline in every case regardless of the auto-reading configuration of the channel.
Steps to reproduce

Let's suppose we have a channel with a FlowControlHandler in its pipeline.
Turn auto-reading off for the channel.
Manually call ctx.read()
For every ctx.read() call, the FlowControlHandler's read method will pass the read event onto the pipeline which will result in reading from the client socket.
If the messages, which we read are not processed fast enough according to our custom logic, all of this can lead to a significant amount of data being stored in memory which leads to out-of-memory errors.

Minimal yet complete reproducer code (or URL to code)
n/a
Netty version
4.1.85.Final and above
JVM version (e.g. java -version)
any
OS version (e.g. uname -a)
any

@ivanangelov can you do a PR with the suggested changes and a unit test ? We love contributions


vitest dot reporter is not used in CI (jenkins)

Describe the bug
with viteconfig
test: {
    globals: true,
    environment: 'jsdom',
    setupFiles: './tests/setup.ts',
    reporters: ['dot'],
    coverage: {
        provider: 'v8',
        reportsDirectory: './reports/coverage-vitest',
        reporter: [['lcov']],
        lines: 3,
        functions: 3,
        branches: 3,
        statements: 3,
    },
},

or command line
npx vitest --reporter dot

work on "my machine" (osx)
but it doesn't in CI (jenkins)

Reproduction
hard to build env with jenkins and share it,
System Info
10:28:09  + npx envinfo --system --npmPackages '{vitest,@vitest/*,vite,@vitejs/*}' --binaries --browsers
10:28:10  npm WARN exec The following package was not found and will be installed<EMAIL_ADDRESS>10:28:11
10:28:11    System:
10:28:11      OS: Linux 5.4 Amazon Linux 2
10:28:11      CPU: (16) x64 Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
10:28:11      Memory: 121.03 GB / 124.36 GB
10:28:11      Container: Yes
10:28:11      Shell: 4.2.46 - /bin/bash
10:28:11    Binaries:
10:28:11      Node: 16.20.0 - /usr/local/lib/nodejs/node-v16.20.0-linux-x64/bin/node
10:28:11      npm: 8.19.4 - /usr/local/lib/nodejs/node-v16.20.0-linux-x64/bin/npm
1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

In CI the terminal is not interactive, meaning that terminal cannot be cleared.
What is the expected output a dot reporter would produce in this kind of environment? Currently this is intentionally disabled:
https://github.com/vitest-dev/vitest/blob/f4e6e99fa3a81fd7a97fb9b435da367dddba7fa4/packages/vitest/src/node/reporters/dot.ts#L10-L16

not sure I understand - I was expecting this (actual dot report) instead : green check marks + files names

I think we could render the dots of the test final stage (green/red) and don't care about test-in-progress (yellow dots).

I'd love to WYSIWYG (what you see is what you get) here. The main issue it would solve is the end the holy war between FE and devops devs. When devops sees tons of info (sometimes red/or exceptions) - they point out - it our fault. I want to output ass less as possible info easy to investigate when you have 1 page of logs instead of 5) ;-) - so I'd really like to see same output everywhere (regardless where vitest is running - local os CI)
Thanks!
p.s.
Should I open a PR or something  - once you pointed the code...

just saw pr welcome tag - I guess that answers my question


feat: Secretsmanager secret rotation for master user password

Description
Fixes https://github.com/terraform-aws-modules/terraform-aws-rds/issues/527
https://github.com/hashicorp/terraform-provider-aws/pull/34180
Motivation and Context
Fixes https://github.com/terraform-aws-modules/terraform-aws-rds/issues/527
Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 6.4.0 :tada:


TAXIICollectionSource.query() only returns the first page

I noticed that the TAXIICollectionSource methods query(), relationships(), ... only operates with the first page returned by the associated TAXII 2.0 server.
I did tests with a local Medallion server v1.1.0 which have a default max_page_size of 100.
By calling TAXIICollectionSource.query() I can get only 100/10000 objects. Also, when calling relationships(stix2_id) the results are limited to those 100 objects.
The only solution I found is increasing that max_page_size, so all objects are returned in one call.

It is likely that the same issue is present for a query to a TAXII 2.1, but thanks for bringing this up. We'll need to look at this...


⚠ Cioos Pacific CKAN has degraded performance

In 27db68b, Cioos Pacific CKAN (https://catalogue.cioospacific.ca) experienced degraded performance:

HTTP code: 200
Response time: 7307 ms

Resolved: Cioos Pacific CKAN performance has improved in 40b24da after 2 hours, 3 minutes.


Move Data

To prevent the problem of sharing data from one Circle in another Circle. It should be possible to move the data. This will prevent that members first have to download it, delete it, and then upload it again.
The feature will be added with a new property value, which by default is set to false. The reason for this, is that it is a rather aggressive feature, as it can potentially be considered data theft. The feature will require that the member has administrative access to the source Circle and write access in the destination circle.
Task is to add a new Action, MOVE, which will be used in a ProcessData request, and also extend the ProcessDataRequest Object with a destination CircleId, and optionally a destination FolderId.

Issue has been implemented, documented & tested together with the COPY feature (#40). Work has been completed so issue can be closed.


Testing bolts 1.8.4 version fails while building in visual studio

Pre-reqs:
Provide information on your environment.
•OS Version Win10 10586.104
•Visual Studio 2015
•Islandwood SDK version  3a18ee2
Repro steps:
I have copied the code from mac book and went into the directory to create *.sln file using vsimporter.
I have opened the *.sln file by double clicking it. As shown in the below images it opens properly with Bolt-ios as a build dependency. But while building it gives the shown below error.
Expected behavior:
build smoothly without errors on importing some files from Bolts framework
Actual behavior:
Bolts.lib (BFExecutor_F456FB2F.obj) : error LNK 2019: unresolved external symbol _pthread_get_stackaddr_np referenced in function remaining_stack_size
Bolts.lib (BFExecutor_F456FB2F.obj) : error LNK 2019: unresolved external symbol _pthread_get_stacksize_np referenced in function remaining_stack_size

There are currently no UWP apis that allow us to control/read the stack size, so this functionality won't work on windows.


Reject authority header in cronet

Cronet does not allow :authority header passed as metadata. This PR rejects the ops which consists of this header field and cancel the call.

Added new end2end test and added comment

Thought about it and decided to make authority_not_support a test case for all fixtures, not just for Cronet end2end test. Need to merge the test framework in #8241 to make it work.

Do not merge until #8241 is approved.

failed tests seem unrelated or already failing; merging


Add version to each mongodb-org package

In the docs you can see that if you want to install a specific version, you must list each package in the mongodb-org metapackage separately with the specified version. Otherwise, the latest version will always be installed.

Thanks! :smile: Can you change that indent to just two tabs and drop mongodb-org=$MONGO_VERSION down with the rest on its own line too?

Hyper-verbose, but makes sense.
LGTM :+1:

LGTM


On the listening TextField input problem

Problem description
When I wanted to listen to the input, I found a question about TextField that did not provide the API. I used onChange to listen to what I typed, and when the callback function listened to the blank space will remove the space, it seems that this is enough to solve the problems I encountered, but when the content is empty, I enter space, my hintText content Disappeared, I entered a second time in the hintText appeared again.
Because the disappearance of hintText will determine whether the content is empty, when I enter spaces, value is not empty, and my onChange method can only be modified after this input.
After I solved the problem, I modified the handleInputChange method in \material-ui\TextField\ TextField.js:
-hasValue: isValid (event.target.value)
+ HasValue: isValid (event.target.value.trim ())

Should we provide the handleInputChange method for us to modify?
Steps to reproduce
I used onChange to listen to what I typed, and when the callback function listened to the blank space will remove the space, it seems that this is enough to solve the problems I encountered, but when the content is empty, I enter space, my hintText content Disappeared, I entered a second time in the hintText appeared again.
Versions

Material-UI: "^0.15.4",
React: "^15.3.2",

Your onChange() function could ignore empty values with .trim() as well and set the value according to it, something like:
onChange (event) {
  const value = event.target.value;

  event.target.value = value.trim();
}

In fact, onChange() function is the same as handleInputChangefunction

@wss534857356: any feedback on this? is this solved?

@lucasbento Thank you, I still revised the handleInputChange method, onChange () position to solve the problem.
 _this.handleInputChange = function (event) {
      if (_this.props.onChange) _this.props.onChange(event, event.target.value);
      _this.setState({ hasValue: isValid(event.target.value), isClean: false });

I still think we should be onChange () method ahead.


[Doc] Question about Trident requirements for aggregate

Describe the bug
I am presently setting up trident backend environment. (of following page)
https://netapp-trident.readthedocs.io/en/stable-v20.10/kubernetes/operations/tasks/backends/ontap/index.html
It get stacked in Sec.6. Digging into the log. it says root aggregate is not supported.
Trident requirements for aggregate is not clear. (not documented)
Is non-root aggregation  enough for Trident?

For all ONTAP backends, Trident requires at least one aggregate assigned to the SVM.

https://netapp-trident.readthedocs.io/en/stable-v20.10/kubernetes/operations/tasks/backends/ontap/ontap-nas/preparing.html
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version: 20.10
Trident installation flags used: default
Container runtime: Docker 19.03
Kubernetes version: 1.18.5
Kubernetes orchestrator: Not used
Kubernetes enabled feature gates: default
OS: Ubuntu 18.04
NetApp backend types: Simulate ONTAP 9.7
Other:

To Reproduce
Follow the following page and Stopped at Section 6 (kubectl get pods --wait)
https://netapp-trident.readthedocs.io/en/stable-v20.10/kubernetes/deploying/operator-deploy.html#provision-your-first-volume
Expected behavior
Persistent Volume Created successfully.
Additional context
Looking into the event, it says
  Type    Reason                Age                     From                                                                                Message
  ----    ------                ----                    ----                                                                                -------
  Normal  Provisioning          3m47s (x39 over 157m)   csi.trident.netapp.io_trident-csi-5b5b74f78b-8rf6c_2d964978-5bb7-465a-b77d-cd0f2c0172fb  External provisioner is provisioning volume for claim "default/basic"
  Normal  ProvisioningFailed    3m47s (x30 over 148m)   csi.trident.netapp.io                                                                    (combined from similar events): encountered error(s) in creating the volume: [Failed to create volume pvc-bdd1507b-ec11-46a9-bc8b-252a0bc06210 on storage pool aggr0_ontapsim_01 from backend ontapnaseco_<IP_ADDRESS>: backend cannot satisfy create request for volume trident_pvc_bdd1507b_ec11_46a9_bc8b_252a0bc06210: (ONTAP-NAS-QTREE pool aggr0_ontapsim_01/aggr0_ontapsim_01; Flexvol location/creation failed trident_pvc_bdd1507b_ec11_46a9_bc8b_252a0bc06210: error creating Flexvol for qtree: error creating Flexvol: API status: failed, Reason: Cannot provision volume "trident_qtree_pool_trident_PQMDUXOECR" on root aggregate "aggr0_ontapsim_01". Provisioning a volume on a root aggregate is not supported., Code: 15675)]
  Normal  ExternalProvisioning  2m10s (x622 over 157m)  persistentvolume-controller                                                              waiting for a volume to be created, either by external provisioner "csi.trident.netapp.io" or manually created by system administrator

The root aggregate is really only for system-internal use. You'd need at least one data aggregate and assign that to the SVM you intend to use.
Noticed that you run the simulator. You might want to look into Ontap Select as an alternative. Less limitations than the simulator (capacity etc.), easier to deploy if you have access to a VMware environment and has an evaluation mode built in.

The root aggregate is really only for system-internal use. You'd need at least one data aggregate and assign that to the SVM you intend to use.
Noticed that you run the simulator. You might want to look into Ontap Select as an alternative. Less limitations than the simulator (capacity etc.), easier to deploy if you have access to a VMware environment and has an evaluation mode built in.


Eth2.0 HD wallet derivation path (BIP44)

Regarding BLS/ETH2.0 keys that are BIP44 compliant, there a few possibilities I have come up with:
0. Use it as it is:
We keep m / 44' / 60' / 0' / 0 and have no distinguishment between Eth1 and Eth2.
Pros:

Simple

Cons:

No way of distinguishing between Eth1 and Eth2

1. Spend the change :
Start using the (currently unused) change field (dependent on EIP84)
m / 44' / 60' / 0' / 1'
Pros:

Uses unused field
Reuses coin type

Cons:

Abuse of the change field
"Requires" hardening of change (Non BIP44 compliant)
Confusing
Breaks compatibility with those who have not adopted EIP 84

2. Use a new coin type:
Chose a new coin type (my proposal is 60^2=3600) to indicate the new version:
m / 44' / 3600' / 0' / 0
Pros:

Complete separation between Eth1 and Eth2
Doesn't break compatibility with anyone (including those that haven't adopted EIP 84)

Cons:

New coin

BIP44 is what determines the path in the tree. It was designed for Bitcoin and has a few fields that are not useful for Eth1, let alone Eth2. There have been several attempts to correct this namely EIP 84, EIP 600, & EIP 601. (There is an open PR against BIP 43 for alt coin support but "BIPs are for Bitcoin only and should not dictate a scheme for alts" 🤦♂). If we are going to define a new tree KDF, then we may as well define a path structure that is more inclusive (and can hopefully be adopted by all those choosing BLS).


Add license check CI workflow

We need to use something like fossa to check the licences of the libraries we use in the project.

We already have FOSSA scan, is it enough or we want  more? https://github.com/weaveworks/tf-controller/blob/main/.github/workflows/scan.yaml#L15-L25


large file crashes

Good Morning,
So in my session [session.sftp connect] I am successfully using method contentsAtPath.
It is working successfully on WIFI, (5MB file), but when I switch to cellular, I'm guessing because of the slow connection, it just crashes the program everytime.
Is something getting timed out?  Is there something I can do to prevent this?
Thank you!!

It's hard to guess from here without any errors or exceptions that might get thrown before the app terminates.


Make update notification permanently dismissable

It will keep showing up if you close it.  We should perhaps have a "do not remind me again" checkbox or button.
Possibly a regression?
Should it be just for that session?  The text could be "Do not remind me for this session".  Or should it be until the version is updated?  In which case the text could be "Do not remind me for this version".

Uhh wrong repo.


Write manual test cases for "NavadaPage"

Please write a manual test case for the following pages, which involves breaking down the functionality of the webpage into specific steps that can be tested.
NavadaPage: https://prayersconnect.com/mosques/search/Las%2520Vegas%252C%2520Nevada%252C%2520United%2520States/36.1699412%2C-115.1398296/36.1699412%2C-115.1398296
Please use this Google Sheet for your test cases.
https://docs.google.com/spreadsheets/d/1FT33mi7lZ9RcyDcln0vpu1PTX4RUNqeuBdA3uGEAOsE/edit?usp=sharing

Done.


Update README archetype generate command

Expected Behaviour
Pasting the archetype generate command from the README to the terminal should result in a successfully generated project.
Actual Behaviour
Pasting the archetype generate command from the README to terminal results in The desired archetype does not exist (com.adobe.aem:aem-project-archetype:23) error message.
Changing -DarchetypeGroupId to com.adobe.granite.archetypes resulted in a successful build for me.
Steps to Reproduce

Copy, paste mvn archetype:generate -DarchetypeGroupId=com.adobe.aem -DarchetypeArtifactId=aem-project-archetype -DarchetypeVersion=23 -DaemVersion=cloud -DappTitle="My Site" -DappId="mysite" -DgroupId="com.mysite" -DfrontendModule=general -DincludeExamples=n to terminal.

Run command.

Results in error.

Platform and Version
Archetype 23, Mac OS Mojave

@austen-wade thx for the report. Your right, the GroupId change does not apply the the archetype 23 example in the README until next release.
reverted the change with commit a0ff35bb34b9941d5b0fb0535c3476076363a6b8


Crontab schedule change

@azurebrd Thanks for checking this out.
No, the pubmed update only happens once a week (on saturday) and we don't want to change that.
While the DQM loading script is running every night so on Saturday these two scripts were running simultaneously and overlapped for a 45-minute interval. That is the reason I moved the pubmed update script from 9am to 8am.

Oh, I see. @azurebrd


css bug

make Section "group" and have fun
fix it, but you must check all such places
admin.css

Can you describe a little more what this PR does? We also don't accept pull requests against master as we do all our development work on the integration branch

make Section "group" and have fun
fix it, but you must check all such places
admin.css
-->
mean the columns has 50%, not 100% (.group > * !!! =))
i working on code, then will make commit to integration branch, ok. later
question -> what diff beetween v2.2.last & v3.0 ? speed? design?


The bash module unconditionally sets HISTFILE

to .bash_history by default.
This is not necessarily desirable?

You mean you want to unset it to disable the history file?

No, I'm starting bash and setting the HISTFILE env var when I call it.


Installed on google cloud, can access web UI ,but it disconnects every time I start trading...

Note: for support questions, please join our Discord server

I'm submitting a ...
[X ] bug report
[ ] question about the decisions made in the repository

Action taken (what you did)
Installed on google cloud, can access web UI ,but it disconnects every time I start paper trader,maarket watcher,or tradebot...

Expected result (what you hoped would happen)
connect api and start trade...

Actual result (unexpected outcome)
It will shows disconnected .
The error log 👍

TypeError: _.get is not a function
at pipelineRunner (/home/server/gekko/web/routes/startGekko.js:86:10)
at Object.message (/home/server/gekko/core/workers/pipeline/messageHandlers/r                                                                 ealtimeHandler.js:15:9)
at ChildProcess. (/home/server/gekko/core/workers/pipeline/parent.                                                                 js:29:12)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at emit (internal/child_process.js:772:12)
at _combinedTickCallback (internal/process/next_tick.js:141:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
server@gekko:~/gekko$ disconnect

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
Thanks

problem solved gekko-develop\web\routes\startGekko.js:86
needed to be changed to  if(event.log) line

Yea that is something that has been fixed, please download the latest version!


[10.x] Tests for Str and Stringable isMatch method

This PR is an addition for https://github.com/laravel/framework/pull/46303 that was merged.
Added tests for both Illuminate\Support\Str and Illuminate\Support\Stringable isMatch method.

Seems like something went wrong with branching here as there's commits appearing that have been merged already. Please resubmit this with only your new commit, thanks.

My fault, resubmitted


Higher level read-write API

The Read/Write interfaces mostly deal with bytes. However, many people may wish to use it for reading strings instead -- for example people doing webdev from languages like Python or even TCP users in C++ are used to a simpler interface, and they find the writer API verbose. Having some utility methods that work with strings and handle the buffer allocation would be nice.
see also: https://github.com/rust-lang/rust/issues/25066

Perhaps a external library?


Drop object-assign.

babel should cover it.

Coverage remained the same at 100.0% when pulling 5550bda66bda8764a25c73489a7352fe29f7e16b on wtgtybhertgeghgtwtg:master into 355c6ec30fe77a505f4b3c8d4c37db421e5109c8 on ben-eb:master.


Ensure Specification(June 2018) Compliance

Motivation
Juniper currently produces code which is not allowed by the GraphQL specification. To ensure that these errors are fixed, a test suite is required. The test suite ensures that configurations which are not compliant to the specification, can not successfully compile.
Implementation
Each GraphQL type has a Type Validation chapter. Therefore, each of the constraints must be checked. An isolated Rust source snippet is created for each of these constraints. An external library compiles these snippets. The library ensures that the output of the compilation process is equal to an expected output. With the process it is ensured that these problems can not reoccur silently   in the future.
Goals (Progress)

[ ] Provider better error messages
[ ] Ensure that everything is specification conform
[ ] Implement GraphQLTypeAsync for missing parts (required for the test suite)

Related

https://github.com/graphql-rust/juniper/issues/630
https://github.com/graphql-rust/juniper/issues/627

Before I continue, I would like to get some feedback for the implemented error handling (@LegNeato). I wonder if the current design is acceptable or are there any problems?
Why?
A change is preferable because panics messages are not precise. Instead syn::Error allows specifying a context for an error. The following two errors are a result of that.
error: #[derive(GraphQLUnion)] expects at least one field/variant
 --> $DIR/derive_no_fields.rs:2:1
  |
2 | enum Character {}
  | ^^^^^^^^^^^^^^^^^

error: #[derive(GraphQLObject)] does not allow multiple fields/variants with the same name. There is at least one other field with the same name `test`
 --> $DIR/derive_fields_unique.rs:4:5
  |
4 | /     #[graphql(name = "test")]
5 | |     test2: String,
  | |_________________^

Since there are errors shared between the different implementations, there are shortcuts for shared errors (including no duplicates, not empty,  etc.). Errors which are unique are also propagated through the error framework.
To let the error generator know what kind of macro is used, all macros must provide a context at the beginning. This context is used to generate prefixes like #[derive(GraphQLObject)]. Maybe this is not required at all since the current errors are pointing directly to the error.

This is perfect and very close to what I was planning on doing when I got some time. Thank you!
I wonder if instead of referring to the derive we refer to "GraphQL" in general as most of these aren't requirement of the derive but instead a spec requirement.
So
error: #[derive(GraphQLObject)] does not allow multiple fields/variants with the same name. There is at least one other field with the same name `test`
 --> $DIR/derive_fields_unique.rs:4:5

Becomes
error: GraphQL objects must not contain multiple fields/variants with the same name. There is at least one other field with the same name `test`
 --> $DIR/derive_fields_unique.rs:4:5
  |

What do you think?

And maybe an optional link to the spec section?

Thanks for the response. That is a good idea.
I wonder if we should use https://docs.rs/proc-macro-error/1.0.2/proc_macro_error/struct.Diagnostic.html for errors. This allows to specify notes and help information. The underlying mechanism is not on stable yet. Therefore, not everything is supported. Information about the used GraphQL specification could be put in a note.

That sounds like a good plan, we already were thinking about it:
https://github.com/graphql-rust/juniper/issues/435

The proc-macro-error crate is nice to use. With your previous feedback, an error looks like the following.
error: GraphQL object expects at least one field
  --> juniper_benchmarks/src/lib.rs:97:1
   |
97 | impl Mutation {}
   | ^^^^^^^^^^^^^^^^
   |
   = note: https://spec.graphql.org/June2018/#sec-Objects

As you can see there are errors are located in the benchmark module which tries to implement empty objects. What should be done here? Remove the non-compiling snippets?
The current implementation wraps all parsed attributes into a SpanContainer<T> which contains additional Span information for that attribute. This is required because all these information are lost during the parsing. Not sure if the SpanContainer<T> is the best approach. Maybe you have a better idea.

I think for benches it is just an oversight. We can use EmptyMutation and EmptySubscription to fix those (and probably the "no fields on object" error should suggest those).
For User, we can just remove the empty proc macro and use the derive instead.

SpanContainer sounds like a good solution for now. The error message looks great!

@LegNeato maybe you can resolve this question. Resolver functions for objects, e.g., test(&self) -> String can have various signatures. What is the smallest possible variant of this construct. The reason for this question is that after some refactoring in favor of the error messages, I found ~10 resolver functions which do not use &self. So which of the following functions must compile?

fn test() -> String
fn test(&self) -> String
fn test(&self, context: &C) -> String
fn test(context: &C) -> String

Oh weird! AFAIK we should have tests for this. The two middle should compile, the first and last should not. &self is required and context is optional (as is the executor) but if it is there it needs to be a reference.

Ah, what I remember seeing is for the resolve function:
https://github.com/graphql-rust/juniper/blob/master/juniper_codegen/src/util/parse_impl.rs#L74
It looks like we don't require &self:
https://github.com/graphql-rust/juniper/blob/master/integration_tests/juniper_tests/src/codegen/derive_object.rs#L85
I think it makes sense to always require &self even though it is a breaking change, do you agree? I'm not sure what is more idiomatic.

Having the requirement for &self for each functions increase the consistency. For example,
https://github.com/graphql-rust/juniper/blob/master/integration_tests/async_await/src/main.rs sometimes has a &self. Therefore, introducing a &self makes it clear that the function requires an underlying object. fn() -> T could suggest that there are no requirements for the function.
An obvious downside is the breaking change which may result in changing a lot of functions. However, currently I tend to introduce the breaking but I am not fully convinced.

This release is already breaking a ton so let's just do it.

This PR is getting a little bit larger. I had to refactor the GraphQLInputObject which allows applying my error scheme. Now the GraphQLInputObject has a similar form like GraphQLObject and the others. Since GraphQLInputObject was the last construct which used a different argument parse, it now does not allow using string scalars like "DefaultScalarValue". I mentioned this breaking change in the changelog.
One last thing, since GraphQLInputObject is missing the async trait, some of the tests fail with a different error message. So there are two possibilities:

add GraphQLTypeAsync in this PR
disabled tests until it is implemented

Thanks for your review.
Additionally, I added a marker trait to detect non-object within the context of unions. Now it is not possible to use non-objects as values for unions.
Besides your recommendations, I added the __ constraint for all fields, types and arguments. The only exception are internal objects, types, etc.
Finally there is support to rename an argument inside an object impl block. This was required to test the __ for arguments. Notice that the __ tests can only be tested with #[graphql] annotations. The function to_camel_case function can not return a name with a __ prefix.

I notice that interface testing is not possible at the moment, since it is still a declarative macro. Enforcing the requirements of the specification seems not possible. I disabled the test. After the macro is replaced the test should be re-enabled.
Maybe you can take a close look at the GraphQLTypeAsync impl for input objects. The input object now implements the async type. No functions are required to implement for the async trait since input objects are constructed by the other two traits (ToInputValue, FromInputValue)?!

The only way to switch the expected output is to have two crates with different expected output. But testing only on nightly should be fine. This way we notice possible changes since. Stable does not implement most of the features, thus the output should not change at all (until the Diagnostic API lands).

Excellent! I think we just need to record the output again and we're good to merge!

Implementing the constraints that arguments have the property IsInputType(arg) == True is bit tricky. I use a marker trait IsInputType which has an arbitrary method. For each  argument,
<#arg_type as IsInputType<#scalar>>::mark() is generated. The compiler can check if each arg has the IsInputType implemented. This seems to work. However, this must be implemented for interfaces as well. Since interfaces are generated by declartive macros, there is no way to express the previous statement.
        $crate::__juniper_impl_trait!(
            impl<$($scalar)* $(, $lifetimes)* > GraphQLType for $name {
                fn mark() {
                    $(
                        <$return_ty as $crate::marker::IsOutputType<$($scalar)*>::mark();
                    )*
                }
            }
        );

The reason why this does not compile is because of the nested $(...)*. The only possible fix I see right now is to remove the declarative macro and replace it with a proc macro.

Yeah, the plan is to remove all macros and replace them with proc macros in this release for just that reason. We just did so a couple weeks ago with graphql_scalar.
The declarative macros were from way back from when proc macros were not available on stable.
If you want to skip that check in this PR so we can land it I'm totally fine with that.
Also, I'd love to add you as a maintainer for Juniper, let me know if you would be interested. You're doing a ton of high-quality work.

Thanks again!


Django 4.0

Annoyingly Travis CI seems to have broken since I last worked on this. I ran tox locally, so I'll release as is and crossing my fingers....

@mx-moth I think Travis-CI might be gone altogether... :( I've moved a couple of my projects to GitHub Actions. It seems to support many of the same features, but it seems you'll have to completely rewrite the CI configuration.


[IMPROVEMENT] Size of the elements, spacing & colors

[ ] Reduce size of the font of the chats screen to something very similar to Telegram;
[ ] Reduce size of the font of the messages screen to something very similar to Telegram; Make the same font size as the text box;
[ ] Change color of mentions on reply/quote banner to something a blue lighter. Right now is almost impossible to read it;
[ ] Use different font style for read/unread channels on the chats list; Here you can use bold in the name of the channel when there's any unread message and change the date label color to the same blue we have in the "unread bubble" and if the chat has no unread messages you simply use semi-bold font and the same color you're using today for date on the date label;
[ ] Change animation to open/close an activity to something faster (see how Telegram is doing);
[ ] Support dragging from left to right to close messages activity;

@rafaelks @filipedelimabrito Can I work on this?

@Rish02Sharma @filipedelimabrito Is already on it. But feel free to work in other-related improvements!


How to run rover -a destroy with -p tfplan artifact?

How to run plan for destroy and output the tfplan so the destroy can use tfplan artifact to destroy it.
As of now, the -a destroy it immediately without having the plan (in pipeline) to decide whether to proceed or not.

@arnaudlh Do you have any idea?

hi @khaman-pet, I believe this is what you are looking for:
rover -lz /tf/caf/examples \
-var-folder /tf/caf/examples/networking/virtual_network/100-simple-vnet-subnets-nsgs \
-env contoso-sandpit -level level1 -tfstate test-pr1638-10.tfstate \
-a plan -destroy

Let me know how it goes!

Thanks @arnaudlh
it works on my AzDO multi-stage pipeline.
Plan stage (as above), publish the artifact. Then ran Destroy stage with approval.
/tf/rover/rover.sh -lz ${BUILD_REPOSITORY_LOCALPATH}$(LANDINGZONE_PATH)
-tfstate $(tfstateName)
-var-folder ${BUILD_REPOSITORY_LOCALPATH}$(configPath)
-tfstate_subscription_id $(SUBSCRIPTION_ID)
-target_subscription $(SUBSCRIPTION_ID)
-parallelism=30
-level $(level)
-env $(ENVIRONMENT)
-p $(Pipeline.Workspace)/drop/$(tfstateName).tfplan
-a destroy


Display Name Bug

version 3.6.3
Quests does not seem to recognize any sort of quest that has color formatting in the name. It is possible to add formatting, however, after adding formatting, it's impossible to go into the editor or take the quest ("/quests take [Quest]") that has formatting in it's name, resulting in the error "quest not found".
To further experiment on this, I removed the formatting "&6&l" from the name and the editor and take commands worked just fine.
Premade Quest:
https://pastebin.com/at1PqUsX

Correct. This is because it would require users to include the associated color codes in the /quests take [quest] command - codes which many users are not familiar with. And although Quests could strip color codes from names at loadtime, that would introduce problems if there were multiple quest of similar names (for example, it'd be bad if &2MyQuest and &7MyQuest would both be loaded as MyQuest).
As such, there are no plans to support color codes in quest names.

Okay, so color coding support was removed from quests. Got that. but the same thing happens if I put a space in the name as well. if I make a quest named "Quest Test" and do /quests take Quest Test, I'll still get "Quest not found". Was support for name spacing removed as well?

I’m not sure that color codes were ever supposed in names.
As for spacing I think that’s supported. Have you given it a try?
Sent with GitHawk

They were. I used to add color formatting to quests all the time in earlier versions. For example, [&7Beginner&f] First Quest . this used to work so long as I typed /quests take First Quest.
And I have given it a try. I think the command string "/quests take" doesnt support the spacing in quest names. I think its demanding the entire name in one part of the string. As in: "/quests take First Quest" might only be accepting "/quests take First" and that's why it can't find it?

Interesting. If you can determine which version removed the ability to use color, I'd be willing to take a closer look. However, there's a good chance it was removed the reasons I mentioned earlier.
Was just able to accept the default "Mob Hunter" and "Iron Miner" quests with the /quests take command. I'm not sure what's stopping you from using spaces in quest names, but I'll have to ask you open a new issue with an example quest if you'd like to explore this further.


[DOC] Alerting Dashboards Content Gaps

What do you want to do?

[ ] Request a change to existing documentation
[X] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
https://github.com/opensearch-project/alerting-dashboards-plugin

@vagimeli - Is this issue still valid? Thanks.


Formatted the raw contents and added what was missing

Unfurled the scrambled contents
Added the one missing item
Updated the description for the UserVoice forum.

My point of reference for these changes: https://docs.microsoft.com/en-us/windows/application-management/app-v/appv-for-windows

Thank you, @skycommand


Mobile tooltip update gallery

Please @kodadot/internal-dev do refactor as well as needed
chains are perfect now! thanks to everyone involved
but oops, seems like mobile is wrong again:

Originally posted by @prury in https://github.com/kodadot/nft-gallery/issues/6448#issuecomment-1660269992

👋


Traccar upgrades from 2.xx to 3.1 and problems

Hi,
I have upgraded traccar from version 2.x to 3.1 and I can't connect anymore.
a) From the web interface, I get NullPointerException...
b) I have tried to track my android phone on port 5005, and I get
2015-09-21 09:31:06  WARN: [FCD806CE] error - String index out of range: 0 - StringIndexOutOfBoundsException (... < T55ProtocolDecoder.java:121 < ExtendedObjectDecoder.java:39 < ...)
Any help?

What database are you using? Have you updated your database schema?
Here you can find some more info regarding update:
https://www.traccar.org/update-from-2-x-to-3-0/
https://www.traccar.org/update-from-3-0-to-3-1/

I am using mysql, and I think I have updated the database correctly. I have followed above links for upgrading.
I have changed the port in android port to 5055 and is working now.
but still I can't connect to web interface.

In table user the following fields are NULL.
map,
language,
distanceUnit,
speedUnit

Is the server table empty? Try to add a record there.

THANKS, it worked
INSERT INTO traccar.server (id, registration, map, language, distanceUnit, speedUnit, latitude, longitude, zoom) VALUES (NULL, b'1', NULL, NULL, NULL, NULL, '0', '0', '0');


tintColor is now being properly set

Related issue: https://github.com/ArtSabintsev/Harpy/issues/139

Nice solution and thinks for consolidating the duplicate code. I'll review this tonight and then accept the PR after I test it.

Confirmed to work! Thank you!
Merging!


Client rework with DTO/Serializer

Use Symfony Serializer to parse data from API and create DTO for each API endpoint.
The idea is to bring a strong typed model with utility functions to be able to access all data easily.
Endpoints to update:

ProfileApi
ProgressionApi
RankApi
StatisticApi

Resources:

https://dzone.com/articles/practical-php/practical-php-patterns-data (just for the idea of what is a DTO, I will prefer to use public attributes over useless get/set methods)
https://symfony.com/doc/current/components/serializer.html

Regarding DTO:
I use https://github.com/jenssegers/model when I want things like this, but I do use laravel on my sites. So not sure how you'd feel about that.
General Thoughts:
For the DTO, it would be nice to have helper methods to group the constants as well. Something like pve()/pvp() etc.

Thanks for commenting !
About the lib you linked, we can't really use it since it's only Laravel-related and I would prefer to make a more generic client. In future we could make bridge to Laravel/Symfony or other frameworks if needed :)
About helpers I totaly agree ! I'll try to make a draft model / serializer with Profile API this week to let you see how you could do this ;)

Finally last step to make dev-master clean again :+1: (and unit tests running as they should be :wink:)
I only made simple models for all endpoints, there must be some possible improvement (and even more for StatisticApi endpoint)
@stygiansabyss if you want to take a look at all theses and try something you're free to go ! :wink:


EPERM on windows

I use watchify as a npm task in windows, and periodically it stops watching and logs
{ [Error: EPERM, rename 'c:\Users\dmitry\Dropbox\Projects\mod\dist\mod.js']
  errno: 50,
  code: 'EPERM',
  path: 'c:\\Users\\dmitry\\Dropbox\\Projects\\mod\\dist\\mod.js' }

Restarting fixes it for a while utill the next EPERM error.

+1, first reported on 15th Aug 2014 and still no official fix...

+1

+1, I had this issue and using the fork @manuelcabral recommended above fixed it.

+1 This is part of the reason I've been using webpack instead.

:+1: same here, annoying bug.

+1. Trying to fork from @manuelcabral  and if that doesn't work, it's webpack time.

I'm seeing this as well using 2.4.0 on Windows 7 using Sublime.

+1
PhpStorm, Windows 7, the first time it compiles without problem, but as soon as i change something and the compilation start, it reports the blocked file.
As long as watchify is running i can't do anything with the file, windows reports ownership as "unable to determine" and doesn't let me do anything with it.
Restarting watchify makes it compile once, but as soon as i chang sth. it is the same all over again, rendering watchify virtually useless.
It started hapening yesterday, after investigating a while i couldn't make out any change i made to the system other that adding and including a new file to my project, very strange indeed...

As i mentioned before, the error occurred every time i changed a file and watchify kicked in, i didn't install or updated anything previous to the first time the error occurred, i simply added more code (via an extra module).
Removing some modules and therefore reducing the compile / clean time let the problem disappear, so it seems to be related to the time the different tasks need.
In my case, every time my clean task took more than x ms, i would get the EPERM message.
gulp.task('clean', function () {
    return gulp.src( './dist/' )
    .pipe(vinylPaths(del))
    .on('error', gutil.log);
});

I don't know why that is, but this seems to be the trigger (tested with various complexities of my program).
Maybe somebody better versed in gulp can figure this one out.

Anyone who is interested (@liddellj, @ryan1234, @flq) can give me feedback on my watchify fork. It just retries the rename if there is an error.
I'm planning to make a PR, but I'm having trouble replicating the EPERM with watchify, so I don't know if this fixes it. If you test my fork, you should see retrying and not EPERM in the log.
I also have to clean up the logs before I make the PR.
To test:

clone the fork
checkout the fix-eperm branch
run npm link to give you the command

cmd.js not cli.js ;)

Thanks, fixed.

I think I've got a fix for this in https://github.com/substack/watchify/pull/169 - think because I've only tested it in a Win7 VM. Can a few of you give it a test drive and comment on the PR? I'd like to merge this fix in fast so I can get these other goodies out https://github.com/substack/watchify/issues/168

The fix was published as<EMAIL_ADDRESS>

<EMAIL_ADDRESS>on win 8.1  looks good!
Just tested saving a file with an error then correcting the error and resaving several times. No problems.
Nice work, thanks.

Just had an extensive session on a Windows10 Preview VM, no problems. Definitely a much nicer experience, thanks for the work!

I am seeing this issue as long as the folder the file is contained in is open in Sublime Text 3. I'm not certain if this is an issue with the editor, watchify or something else, unfortunately.

This issue only exists in Windows (reproduced on Windows 7); on Ubuntu I do not encounter the same permissions issues.


Please build a wheel for mxnet--1.9.1 for windows

Description
On the Get Started instructions for MXNet version 1.9.1 say to simply run "pip install mxnet". This does not work. There doesn't appear to actually be a wheel for version 1.9.1. In fact, there doesn't seem to be a wheel compiled for anything above version 1.8.0.
Running "pip install mxnet -f https://dist.mxnet.io/python/cpu" will only install version 1.8.0, regardless of python 3.7, 3.8, or 3.9.
Libraries that rely on MXNet (for instance, AutoGluon) have already moved on to require MXNet version >1.9.0.
Could you please make version 1.9.1 available to Windows users via pip?

The Windows build was suffered from too many CUDA and BLAS combinations and the corresponding issue has not been fixed since sometime around version 1.7. If you want to build a wheel for specific CUDA and BLAS, you can check this link for a reference.


[CARBONDATA-4317] Fix TPCDS perf issues

Why is this PR needed?
The following issues has degraded the TPCDS query performance

If dynamic filters is not present in partitionFilters Set, then that filter is skipped, to pushdown to spark.
In some cases, some nodes like Exchange / Shuffle is not reused, because the CarbonDataSourceSCan plan is not mached
While accessing the metadata on the canonicalized plan throws NPE

What changes were proposed in this PR?

Check if dynamic filters is present in PartitionFilters set. If not, pushdown the filter
Match the plans, by converting them to canonicalized and by normalising the expressions
Move variables used in metadata(), to avoid NPE while comparing plans

Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6146/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/537/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4403/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4404/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6147/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/538/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4406/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6149/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/540/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6152/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4409/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/543/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4414/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6157/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/548/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6158/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4415/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/549/

retest this please

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4419/

Build Failed  with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/553/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6162/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6164/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/555/

LGTM

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6175/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4431/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/6179/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/4435/

Build Success with Spark 3.1, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_3.1/570/


Update README.md

Codecov Report

Merging #16 (e88d52f) into master (a78d7f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   52.99%   52.99%
=======================================
  Files           6        6
  Lines         117      117
=======================================
  Hits           62       62
  Misses         55       55

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support for TRT İzle

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://www.trtizle.com/belgesel/dunya-tarihinin-donum-noktalari/dunya-tarihinin-donum-noktalari-1-bolum-125583 (requires signing in)
Live stream of the channel: https://www.trtizle.com/canli/tv/trt-2 (do not require signing in)
Playlist: https://www.trtizle.com/listem (requires signing in)

Description

This is the state television company of Turkey, and therefore it's a legal site. However, watching the episodes of programs or making a private list require signing in. Obtaining account credentials is simple: register on the site with an email.

In the first example, a manifest and thumbnail is found in the <figure class="show-detail--image hasVideo"> element, without needing to log in.
The livestream apparently needs to be traced with JS enabled to reveal the stream URLs.
The playlist needs a login. Am I right to guess that personal lists are behind the login?
There are also Programs URLs, eg the master list of shows https://www.trtizle.com/programlar, a list for one show (eg https://www.trtizle.com/belgesel/dunya-tarihinin-donum-noktalari), ...
The program page for "Dünya Tarihinin Dönüm Noktaları" looks very similar to the page for episode 1 (which has /dunya-tarihinin-donum-noktalari-1-bolum-125583 added to the URL), so there should be a separate playlist extractor for that; the episode list is in the page.
In the

@dirkf

The playlist needs a login. Am I right to guess that personal lists are behind the login?
Correct, and as far as I am aware it doesn't have a feature to share lists (hence there also isn't public lists).
Also I've just realized there are some other master lists I've just noticed (other than documentaries and programs): https://www.trtizle.com/engelsiz and https://www.trtizle.com/diziler
And yes, while viewing the episode page without signing in is same as the program page, it directly shows the episode in the video player on episode page (hence the almost exact screen that can be seen in the livestream pages), and nothing else.


Update Member UI to use MDL (dev: yarn memberui) & update reading list

begin porting to Material Lite (via elm-mdl)
add white text logo
added elm-live
add memberui npm script to work on member ui stuff - run with yarn memberui

Deploy preview failed.
Built with commit 1e93410e2fffcac104cd3471d27ed9a3fd2970d8
https://app.netlify.com/sites/voteflux/deploys/59c0815dcf321c50050c8e27


Bug 2277928: [release-4.12]Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR

This is a manual backport of #2579

/bugzilla refresh


Question: why not generalize over Semiring?

Pretty much everything you have would work if you replaced Int with an arbitrary Semiring.
Would you be interested in that approach at all?
Edit: e.g. you could use "rationals" constructed from polynomial rings.

I don't see why not. Maybe we should add a more general Ratio?
data Ratio a = Ratio a a
type Rational = Ratio Int


panic: runtime error: invalid memory address or nil pointer dereference

What version of Turborepo are you using?
1.0.4
Describe the Bug
I'm trying out turborepo in my existing monorepo that uses pnpm workspaces, and when I define a specific packages task, I get the following error:
~/development/raulmelo-studio(test-turbo-repo*) » npx turbo run build --scope=website
• Packages in scope: website
• Running build in 1 packages
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x13fa6c8]

goroutine 114 [running]:
turbo/internal/run.(*RunCommand).Run.func3({0xc0000a9880, 0xa})
        /Users/jared/dev/vercel/turbo/cli/internal/run/run.go:375 +0x188
turbo/internal/core.(*scheduler).Execute.func1({0x1443e40, 0xc0006b0cd0})
        /Users/jared/dev/vercel/turbo/cli/internal/core/scheduler.go:107 +0x1bd
github.com/pyr-sh/dag.(*Walker).walkVertex(0xc00049fe60, {0x1443e40, 0xc0006b0cd0}, 0xc00068a300)
        /Users/jared/go/pkg/mod/github.com/pyr-sh/dag@v1.0.0/walk.go:377 +0x2ff
created by github.com/pyr-sh/dag.(*Walker).Update
        /Users/jared/go/pkg/mod/github.com/pyr-sh/dag@v1.0.0/walk.go:300 +0xf85

Config
I'm not sure if my config is correct though:
{
"turbo": {
    "baseBranch": "origin/main",
    "pipeline": {
      "lint": {},
      "build": {
        "outputs": [
          "dist/**",
          ".next",
          "functions/**",
          "build/**"
        ]
      },
      "test": {
        "outputs": [
          "coverage/**"
        ]
      },
      "website#build": {
        "dependsOn": [
          "core#build",
          "mdx-prism-2#build"
        ]
      }
    }
  }
}

What I want to accomplish
Since my website rely on packages/core and packages/mdx-prism-2, I want to test/build them first and only then build the website.
Expected Behavior
Running the pipeline or at least getting a handled error message.
To Reproduce
The PR I'm trying this is the following: https://github.com/raulfdm/raulmelo-studio/pull/1141
If this is not only a matter of configure stuff, I can try to recreate a smaller version of my repository. Even though it's open source, building rely on .env files.

Going to look into the nil pointer issue, but i I think you want to add regardless:
"build": {
   "dependsOn":["^build"],
}

this makes sure deps are built first. I also think you probably want to set lint's outputs: [] so that you don't cache dist or build folders needlessly while linting

Hey @jaredpalmer ... I've notice that the pointer problem was caused by the website#build configuration. When I remove it it just works.
{
  "turbo": {
    "baseBranch": "origin/main",
    "pipeline": {
      "lint": {
        "outputs": []
      },
      "build": {
        "dependsOn": [
          "^build"
        ],
        "outputs": [
          "dist/**",
          ".next",
          "functions/**",
          "build/**"
        ]
      },
      "test": {
        "outputs": [
          "coverage/**"
        ]
      }
    }
  }
}

Also ran into this issue when I had a misspecified turbo.json. I think this will happen whenever you have a specific package#task dependency with a task not in your graph.
For the sake of completeness, here's an abbreviated before/after config. In my repo, all tests depend on a shared jest config package named @adj/jest-config.
Failing:
{
    "pipeline": {
        "transpile.cjs": {
            "dependsOn": ["^transpile.cjs", "rust.build.ts-bindings"]
        },
        "test": {
            "dependsOn": ["jest-config#transpile.cjs"],
            "outputs": []
        }
    }
}

working:
{
    "pipeline": {
        "transpile.cjs": {
            "dependsOn": ["^transpile.cjs", "rust.build.ts-bindings"]
        },
        "test": {
            "dependsOn"<EMAIL_ADDRESS>            "outputs": []
        }
    }
}


Notification logs table updates

Main Features

Notification log table only displays the most recent log associated with a notification.
When "Log Details" is clicked a drawer opens and all other logs associated with a notification can be viewed

Other Notable Improvements

The state for users and notification logs has been moved to their respective components.
All references to the backend-sdk have been removed.
Typing added for UsersTable and LogsTable which has been moved to a types directory.

All features looking good.


Fix list image and share image to use content

fixes https://github.com/frontity/saturn-theme/issues/180

@DAreRodz ready for review

:tada: This PR is included in version 0.12.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Track Egress always send muted: true message on websocket

I started using StartTrackEgress on LiveKit and checked the message it sends on websocket when the track is muted and unmuted. In the logs, I can see that mute changes to true/false but the message sent on websocket is {"muted": "true"} in each case.

I do see muted: false messages coming through. Are you on the latest version?
2023-04-12T22:19:23.863Z	DEBUG	egress	sdk/appwriter.go:141	track muted
2023-04-12T22:19:23.867Z	INFO	egress	test/track.go:242	received text message "{\"muted\":true}"
2023-04-12T22:19:33.649Z	DEBUG	egress	sdk/appwriter.go:144	track unmuted
2023-04-12T22:19:33.651Z	INFO	egress	test/track.go:242	received text message "{\"muted\":false}"

I wasn't on the latest version but now I've tried it with the latest LiveKit (v1.4.1) and Egress (v1.6.3) and it works well. Thank you!


Configuration switch for On-Behalf-Of authentication

This PR adds additional configuration switch to azsettings.AzureSettings which can control availability of the On-Behalf-Of feature in Azure Data Explorer datasource.
Proposed configuration in Grafana config:
[azure]
managed_identity_enabled = true

# Enable/disable On-Behalf-Of authentication using AAD client configured in a datasource
client_obo_enabled = false

Access in frontend:
import { config } from '@grafana/runtime';
...
const clientOnBehalfOfEnabled = config.azure["clientOnBehalfOfEnabled"];

Access in backend:
azureSettings, err := azsettings.ReadFromEnv()
if err != nil {
	backend.Logger.Error("failed to read Azure settings from Grafana", "error", err.Error())
	return nil, err
}
...
clientOnBehalfOfEnabled := azureSettings.ClientOnBehalfOfEnabled

Related to: https://github.com/grafana/azure-data-explorer-datasource/issues/359
@andresmgot @yaelleC

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Breadth first search tests

I have added tests for BFS example, BFS shortest path and BFS minimum spanning tree.
In order to add these tests I had to change the example functions. Here are a summary of the changes:

Made simple example return a list of explored nodes

Previously it was printing explored nodes inside of function

Made shortest path return a shortest path graph

Previously it was printing shortest paths inside of function

Implemented equality on edges, graphs and nodes to allow for tidy asserts
Changed simple example to used node.visited flag instead of storing separate "seenNodes" list

I made a few small tweaks to the text, but other than that I'm very happy with it. Thanks again!

 Thank you for all of the tips and advice! :smile:


Is disableGlobbing available on files paths?

I have a file with parentheses that I want to unwatch but it seems that it does not work. It works with other files that don't have parentheses (or any other special character I guess).
Is there a workaround that I can use about that?
Thanks!

not for now https://github.com/paulmillr/chokidar/issues/765


How to navigate forth and back without losing searched text

I want to search something
when search page show similar item then i want to navigate to new screen with selected search result
when i press back i want to go back to search page instead of main screen with searched text on search bar
and then again able click on another search result.
any suggestion on how can i do it ?

There is currently no way of doing this. It could be implemented as a new option, something like persistent: true

Thanks for help


Unable to access file store in Storage account file share:

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.28.1
Regression From
No response
Architecture
i86
Storage Explorer Build Number
20230309.1
Platform
Windows
OS Version
Windows 10
Bug Description
Unable to access file store in Storage account file share:
Unable to retrieve child resources.
Details:
{
"name": "FetchError",
"message": "request to https://eastus2app4ee.file.core.windows.net/?comp=list failed, reason: unable to get local issuer certificate",
"stack": "FetchError: request to https://eastus2app4ee.file.core.windows.net/?comp=list failed, reason: unable to get local issuer certificate\n    at ClientRequest. (C:\Users\U8012993\AppData\Local\Programs\Microsoft Azure Storage Explorer\resources\app\node_modules\se-file-extension\dist\src\index.js:2:118601)\n    at ClientRequest.emit (node:events:513:28)\n    at TLSSocket.socketErrorListener (node:_http_client:481:9)\n    at TLSSocket.emit (node:events:513:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)\n    at emitErrorCloseNT (node:internal/streams/destroy:122:3)\n    at process.processTicksAndRejections (node:internal/process/task_queues:83:21)",
"type": "system",
"errno": "UNABLE_TO_GET_ISSUER_CERT_LOCALLY",
"code": "UNABLE_TO_GET_ISSUER_CERT_LOCALLY"
}
Steps to Reproduce
Launch Explorer
Got to storage blob
Expand FileShare
Actual Experience

Attached image
Expected Experience
No response
Additional Context
No response

Can you please try using system proxy? https://learn.microsoft.com/en-us/azure/storage/common/storage-explorer-network#use-system-proxy-preview

Closing due to lack of response. If you still have this problem, please open a new issue.


Body Fat Calculator

Enter calculator name -
Body Fat Calculator
Describe calculator functionality -
You may refer - https://www.calculator.net/body-fat-calculator.html
Under which category you wish to place it -
[] Computer Science
[] Mathematics
[] Physics
[] Chemistry
[] Biology
[] Finance
[] Scientific
[x] Health
[] Sports
[] Let project owner decide
[] Suggest a new category - (Answer here)

Hi @SarthakKeshari can you assign this to me!. Also please specify the details.

Hi @SarthakKeshari i can work on this issue

Hey @Saksham-245,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\health\BodyFat
Issue completion deadline - 3rd Oct 8:00:00 pm IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

Ok Sure Thank You! @SarthakKeshari

Hey @7twik,
Good to see you active again. We are following first come first serve. If deadline is not met, then it can be assigned to a new participant.
Happy contributing🎉

@Saksham-245, For details you may refer the link provided under "Describe calculator Functionality"

@SarthakKeshari I have just one question Do I need to implement tab like functionality and gender specific also.

@Saksham-245, May you elaborate please.

Like in the website it has tabs for US Units and Metric Units and in both units there is 2 radio buttons for gender male and female. Do I need to implement like that only or just One unit.

@Saksham-245, Do the way you find it the most appropriate. I am ok.

Ok Thanks!


For HHKB Professional JP keyboard, "right-cmd" and "lang" keys are not detected

I'm using HHKB Professional JP keyboard, but "right_command" and "lang1"&"lang2"(英数&かな) keys are not detected in Karabiner-EventViewer while the other keys are recognized well.
If I removed the check of "HHKB Professional JP" in [Devices]-[Modify events from this device] table, these events are detected by the event viewer. However, if I removed that check, key modifier does not work.
environments

macOS Sierra 10.12
Karabiner-Elements: 0.90.84
OS Locale: English
Mac Pro (Mid 2012)
keyboard: HHKB Professional JP

Latest driver for HHKB provided by PFU is installed.

HHKB Pro JP without PFU driver works fine on my machine.
The PFU driver might be conflicted with Karabiner-Elements.

I uninstalled the PFU driver, but I still find the same problem.
Do you have an idea on possible causes that I can test?

Did you change the DIP switches?
Please try to reset the DIP switches.

Macintosh mode (SW1) and swapping left alt and command (SW5) are on.
Although I turned off these two and restarted my computer, things didn't change. Event-Viewer does not show any responses against "right_command", "lang1", and "lang2".

@yohm
In my environments, lang and right-cmd are now detected after adding the following settings.

For lang1

PCキーボードの変換キー

For lang2

PCキーボードの無変換キー

For right-cmd

PCキーボードのかなキー

environments

macOS Sierra 10.12.3
Karabiner-Elements: 0.90.67 (with a little patched with manual build)
OS Locale: Japanese
MacBook Pro (Late 2016)
Keyboard: HHKB Professional2 Type-S JP

Latest driver for HHKB provided by PFU is installed.

@hioki-daichi Thanks! I'll try your proposal maybe during next week.

@hioki-daichi Following your advice, I could remap the keys as I intended.
After I reinstalled PFU devices, I remapped the keys as following. Thanks!


add default time values for transfos

to fix https://github.com/LI3DS/api-li3ds/issues/5

infinity and -infinity behave as expected. See https://www.postgresql.org/docs/current/static/datatype-datetime.html.

Ok, followed by  https://github.com/LI3DS/api-li3ds/commit/823776c8f88f9cae34a584f4581efe39b12026ba to add the same behavior with the api.
For travis, the error isn't related to these commits, the build failed before that on :
pyembedpg.PyEmbedPgException: Cannot download file http://download.osgeo.org/postgis/source/postgis-2.2.2.tar.gz. Error: b'404: Not Found\n'

Investigating...

Build's green. Merging. Thanks @ldgeo.


Code for CUB

Thank you very much for your work.
Could you please release the code for the CUB dataset?

Hello,
thanks for your interest in our work. We released a new improved version of our code, including the code for the CUB dataset.


fix convert error if long int such as<PHONE_NUMBER>40853127

if model filed type is BigInt, such as<PHONE_NUMBER>40853127,  to be convert<PHONE_NUMBER>40853120 overflow.

fix use decimal


Add Feature to Show Dependent Children

Add wxTreeCtrl menu feature to display the dependent children from the chosen node

passed all devel tests

passed all devel tests


CTF meas_id

Not sure if this is related to #4990, but I'm running into a problem with meas_ids not serializing correctly.
To replicate.
import os.path as op
from mne.io import read_raw_ctf, read_raw_fif
from mne.datasets import testing
import tempfile

ctf_dir = op.join(testing.data_path(download=False), 'CTF')
ctf_fname_somato = op.join(ctf_dir, 'testdata_ctf_short.ds')

raw_orig = read_raw_ctf(ctf_fname_somato)

temp_file = tempfile.NamedTemporaryFile(suffix='-raw.fif')
raw_orig.save(temp_file.name, overwrite=True)
raw_fif = read_raw_fif(temp_file.name)

for k in ['secs', 'usecs']:
    print('orig %s - %s' % (k, raw_orig.info['meas_id'][k]))
    print('fif  %s - %s' % (k, raw_fif.info['meas_id'][k]))
    print('')

If you round-trip again do you at least get the same ID that time?
Can you try git bisect? First might be to try one commit before that PR was merged (f5e3399ad6d0c163f3b86f002fd3c6fb687e6315) and then the commit where it was merged (d77cc95b0cf56b1df5886c9ebc52261a55695331).

round-tripping a second time works. Meaning that saving the fif file and reading it back in results in the same meas_id structure.
My guess is that the ctf reader, specifically:
https://github.com/mne-tools/mne-python/blob/ab4571a83c4e5d5de0dcb2e9346f809f113dd619/mne/io/ctf/info.py#L420-L423
is a different convention (ie packing everything in secs instead of usecs?) then what is used for fif files?
Let me know if you still want me to mess with git bisect. I might have some time tonight to try it out.

It's still worth doing at least git checkout f5e3399 (before that PR was merged) and then running these tests again. Based on what you say I think the result will stay the same, namely that the problem existed before that PR and is probably a CTF-related bug.

This is a bug that seems to effect all IO not just CTF
import os.path as op
from mne.io import read_raw_fif
from mne.datasets import testing
import tempfile

data_dir = op.join(testing.data_path(download=False), 'MEG','sample')
fif_fname = op.join(data_dir, 'sample_audvis_trunc_raw.fif')
raw_orig = read_raw_fif(fif_fname)

temp_file = tempfile.NamedTemporaryFile(suffix='-raw.fif')
raw_orig.save(temp_file.name, overwrite=True)

raw_fif = read_raw_fif(temp_file.name)

for k in ['secs', 'usecs']:
    print('orig %s - %s' % (k, raw_orig.info['meas_id'][k]))
    print('fif  %s - %s' % (k, raw_fif.info['meas_id'][k]))
    print('')

yields
orig secs -<PHONE_NUMBER>
fif  secs - 0

orig usecs - 0
fif  usecs -<PHONE_NUMBER>

my guess is that this code
https://github.com/mne-tools/mne-python/blob/ab4571a83c4e5d5de0dcb2e9346f809f113dd619/mne/io/meas_info.py#L1219-L1231
needs to be updated post #4990

actually if i do git checkout f5e3399
the above code still give something strange...
orig secs -<PHONE_NUMBER>
fif  secs -<PHONE_NUMBER>

orig usecs - 0
fif  usecs - 88141

Am I wrong to expect these to be the same?

Actually I think this was the intended behavior of #4990. As an anonymization step it's better not to save the date when the file is written. So secs==0, usecs==2147483647 is a shorthand for None (since you would never in practice write usecs >= 1e6 in this format)

ok so its safe to assume that secs and usecs in meas_id are not preserved
through file IO. So I can remove that part of the test from the
io/ctf/test/test_ctf.py?
On Tue, Jun 5, 2018 at 10:51 AM Eric Larson<EMAIL_ADDRESS>wrote:

Actually I think this was the intended behavior of #4990
https://github.com/mne-tools/mne-python/pull/4990. As an anonymization
step it's better not to save the date when the file is written. So secs==0,
usecs==2147483647 <(214)%20748-3647> is a shorthand for None (since you
would never in practice write usecs >= 1e6 in this format)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/5258#issuecomment-394739360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFU7nao4dz1ZbfblmtvFHK6rDXSxNg16ks5t5pr8gaJpZM4UZC4p
.

Better yet, ensure it's equal to DATE_NONE

if you don't call anonymize I would not expect any change of the meas_id
do I miss something?

You're right, DATE_NONE should only be used when the date is unknown, or when anonymizing.
So it seems like there is some bug. @bloyl can you see if just doing read_info(...) followed by write_info(...) has this problem of setting info['meas_id'] == DATE_NONE? It will help isolate the problem.

I added a fix and tests to #5255 so lets move the conversation there.


Fix Footer

Signed-off-by: Javier Canossini<EMAIL_ADDRESS>

Many thanks @javiercanossini this looks amazing! 🎉 🚀


bootstrap-node.js should check check for Array.isArray in removeGlobalNodeModuleLookupPaths

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.72 (latest main)
OS Version: macOS 12.6.1

Steps to Reproduce:

yarn && yarn watch
./scripts/code.sh

In the console output logs, we've been seeing failures at startup like this:
[85180:1102/151514.317775:INFO:CONSOLE(231)] "%c  ERR color: #f33 [Extension Host] TypeError: Cannot read properties of null (reading 'length')
	at Module._resolveLookupPaths (/Users/zube/vscode-distro/out/bootstrap-node.js:83:38)
	at Module._resolveLookupPaths (/Users/zube/vscode-distro/out/bootstrap.js:84:18)
	at node_module._resolveLookupPaths (/Users/zube/vscode-distro/out/vs/workbench/api/node/extHostExtensionService.js:23:39)
	at Module._resolveFilename (node:internal/modules/cjs/loader:941:20)
	at o._resolveFilename (node:electron/js2c/utility_process_init:17:848)
	at Module._load (node:internal/modules/cjs/loader:832:27)

It appears that bootstrap.js makes this check on line 85 and when making this change in our fork this fixes bootstrap-node.js from exhibiting this issue as well.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Done via https://github.com/microsoft/vscode/pull/165289


Exposed optional ports

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] I have read the CONTRIBUTING.md document.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Closes #63

Looks great overall! I have only one question. It seems like the port was defaulted to None in some cases or to 0 in the rest (except the view_statistics in the datasources which does not have a default). Is that the desired behaviour, does it depend on the function? If not, we can apply the same method to each function to make it more consistent.

Thanks! Made it consistent to 0 :-)


Fix typo

This is a minor typo fix.
refreshed -> refresher

Closing as the older PR #274 contains the same fix, but thanks again!


Instancing Rework

📝 Description
This aims at reworking instancing, as of now, not in major ways, simply taking current systems and refining them / making them sane.
🎯 Goals

Make the instancing system cleaner
Make the instancing system simpler
Fix any issues related to the instancing system

❌ Non Goals

Rework the instancing system in fundamental ways

🚦 Testing
Currently testing is done in single player by shooting and doing any actions a player could do, also there are terrorist and soldiers.
⏮ Backwards Compatibility
I hope it can be.
📚 Related Issues & Documents
#248
📖 Added to documentation?

[ ] 📜 README.md
[ ] 📑 Documentation
[x] 📓 Javadoc
[x] 🍕 Comments
[ ] 🙅 No documentation needed

😄 What gif best describes this PR or how it makes you feel?

@coderabbitai review


Update Linux examples to new runner directory

This was changed in https://github.com/flutter/flutter/pull/153812

test-exempt: code refactor with no semantic change

not sure why ci failed, @robert-ancell can you rebase and see if it passes the ci

It seems to be related to running the API test and the runner directory not existing for some reason. Still investigating.

I've got the build to complete by changing the working directory for the smoke tests.
Without this change the build fails when you run:
$ cd dev/tools
$ dart examples_smoke_test.dart
00:00 +0: loading /home/bob/git/flutter/flutter/examples/api/integration_test/smoke_integration_test.dart
Building Linux application...
CMake Error at CMakeLists.txt:58 (add_subdirectory):
  add_subdirectory given source "runner" which is not an existing directory.

CMake Error at CMakeLists.txt:61 (add_dependencies):
  Cannot add target-level dependencies to non-existent target
  "flutter_api_samples".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.

CMake Error at CMakeLists.txt:67 (set_target_properties):
  set_target_properties Can not find target to add properties to:
  flutter_api_samples

CMake Error at CMakeLists.txt:94 (install):
  install TARGETS given target "flutter_api_samples" which does not exist.

00:00 +0 -1: loading /home/bob/git/flutter/flutter/examples/api/integration_test/smoke_integration_test.dart [E]
  Failed to load "/home/bob/git/flutter/flutter/examples/api/integration_test/smoke_integration_test.dart": Unable to generate build files
  package:flutter_tools/src/base/common.dart 10:3                    throwToolExit
  package:flutter_tools/src/linux/build_linux.dart 174:5             _runCmake
  ===== asynchronous gap ===========================
  package:flutter_tools/src/linux/build_linux.dart 81:5              buildLinux
  ===== asynchronous gap ===========================
  package:flutter_tools/src/linux/linux_device.dart 67:5             LinuxDevice.buildForDevice
  ===== asynchronous gap ===========================
  package:flutter_tools/src/desktop_device.dart 120:7                DesktopDevice.startApp
  ===== asynchronous gap ===========================
  package:flutter_tools/src/test/integration_test_device.dart 55:39  IntegrationTestTestDevice.start
  ===== asynchronous gap ===========================
  package:flutter_tools/src/test/flutter_platform.dart 546:49        FlutterPlatform._startTest.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/async_guard.dart 111:24             asyncGuard.<fn>

00:00 +0 -1: Some tests failed.
Running "/home/bob/git/flutter/flutter/bin/flutter test --reporter=expanded --device-id=linux /home/bob/git/flutter/flutter/examples/api/integration_test/smoke_integration_test.dart" in /home/bob/git/flutter/flutter/examples/api exited with code 1

The above is running flutter test from examples/api, the change in this PR changes to examples/api/integration_test.
I don't know why CMake is failing in the other directory and not enough about flutter test to be sure this change is valid. @stuartmorgan do you know if this change is suitable or can propose something else?

(triage) I am not a Linux expert, but looks like there may be a directory mismatch? cc @stuartmorgan, can you take a look at this pr again?

Sorry, I missed that question. I'm not sure what the implications on flutter/flutter CI of changing the working directory for the test would be; a repo expert would be better equipped to answer that.
I'm confused as to why we would need to though, because the code that is throwing passes an explicit working directory to cmake. @robert-ancell What are the values of sourceDir and buildDir here with and without that change?

(triage) Hi @robert-ancell , do you have plan to come back to this PR? Looks like Stuart had pointed some direction to triage the error.

(triage): Spoke to @robert-ancell last week and he said this is back on his radar.


hi, how to support chinese

hi, how to support chinese

You can use Stanford libraries for Chinese support,

https://nlp.stanford.edu/projects/chinese-nlp.shtml
http://www.nltk.org/_modules/nltk/tokenize/stanford_segmenter.html

Once you have features generated rest is language independent.


Very high CPU usage

Hi,
I'm using Ebitengine on a personnal (private) project.
I'm running it on a Manjaro with KDE (Xorg).
Linux : 5.15.41
Go : 1.18.2
I was stuck a long time on version v1.11.3 because there was an issue with high DPI screen (#1774) on my computer.
It's now fix since the v2.2.0-alpha.15 and I decide to upgrade to ebiten/v2 but I still have some issues with the v2.3.2.
The main issue is an high CPU usage when I load a scene that contain a lot of images (~100 smalls images).
With the v1.11.3, the scene takes ~1Go of RAM and has a little CPU usage spike (normal because of the heavy scene).
On my computer, there is a freeze of 2-3 seconds (I considered adding a progress bar one day but if was ok for now).
With the v2.3.2 the takes takes ~1.5Go of RAM (with eratic allocation and deallocation) and a long high CPU usage.
Still on my computer, now, there is a freeze of almost 30s ( :sob: ).
I cannot make a simple reproducer and I cannot pinpoint the exact commit or version (because of the issue explained above).
I believe it's a regression and it's a blocker for me :disappointed:
Is the issue known ?

Do you see this issue even with a very simple hello-world example?
Thanks,

No I don't see the issue on a light scene (a kind of hello word ^^). The CPU and RAM are low with 10 images (1 is big because of the background).
To reproduce it, I have to pass through 2-3 scenes without any issue.
It's only when I load the heavy scene that the issue occurs.

I added screenshots of KSysGuard widgets after my tests.
You can see that on the 1er test (with 2.3.2), one of my CPU is maxed (blue) then the second (orange) just after.
During that time, RAM is weird :confused:

Thanks!
Unfortunately, I couldn't do anything without a (minimal) reproducible case. I'd appreciate if you could make one, but I understand this is difficult as you have already said.
THanks,

I think I have a reproducer. I simulate some part on the complete scene in a "short" example.
Maybe it can be simplify to keep the issue but, in doubt, I prefere to give more than less.
myIssue.tar.gz
myIssue2.tar.gz
The main idea is to make a scene loading a lot of different images (in the example, it's the same image but I reload it to simulate this).

myIssue is in 2.3.2
myIssue2 is in 1.12.12

Both should be the same (if I did not make mistake). But we can see a very different CPU and RAM consumption.
I look into it with go tool pprof http://localhost:6060/debug/pprof/heap :

heapDynamic{version}.png is the result with current code (dynamic means "allocation with function call" in that case)
heapStatic{version}.png is the result with commented code (static means "direct allocation" in that case)

The "static version" seems to be the same between 2.3.2 and 1.12.12 so it explains why most of usage don't have the issue.
The "dynamic version" differs between 2.3.2 and 1.12.12. I believe it's because of the evolution of Ebiten. Function calls are not the same so I think the issue can be around that.
I hope it helps, if you need more informations, I can try giving them to you :relaxed:

Thanks, I'll take a look later!

Thanks, I think I understand the issue: creating an image and replacing pixels are now heavy in the atlas package. The atlas package creates the 1px border part for one image, and this allocates memories and consumes CPU.

I'm happy to help you figure out the issue :smiley:
Thanks a lot for your time (and the game engine ^^).
Can't wait the v2.4.0 :wink:

This is a note to myself: can we avoid copying pixels by remembering its address? If the same addresses are used before graphics commands are flushed, then the pixels are copied.

Hmm, I read your main.go and you called NewImageFromImage in Draw. You should use ReplacePixels instead of NewImage*.

The "static version" seems to be the same between 2.3.2 and 1.12.12 so it explains why most of usage don't have the issue.
The "dynamic version" differs between 2.3.2 and 1.12.12. I believe it's because of the evolution of Ebiten. Function calls are not the same so I think the issue can be around that.

So, we should use the static version (not generating images every frame) whenever possible.

Hmm, I read your main.go and you called NewImageFromImage in Draw. You should use ReplacePixels instead of NewImage*.

Hum ... I don't understand how I can use ReplacePixels to load a new image. NewImageFromImage allows to load an image from the binary/disk. ReplacePixels allows to replaces pixel in a sub-image. That's not the same purpose.
My example can obviously be optimised in a lot of way, but my purpose was to pinpoint the issue. If you prefere, imagine that evey square is a different new image.

So, we should use the static version (not generating images every frame) whenever possible.

I agree the static version is better and I use that design when I can, but in some case, I need a more dynamic design. And because it's a regression from 1.12.12 I was pretty sure it can be fixed. I'm suprised you won't fix it.
I agree in that case the draw() function is heavier than in the static version but it's a trade that I'm willing to pay in some case but I was expected the same cost between 1.12.12 and 2.3.2.

Hum ... I don't understand how I can use ReplacePixels to load a new image. NewImageFromImage allows to load an image from the binary/disk. ReplacePixels allows to replaces pixel in a sub-image. That's not the same purpose.

NewImage creates a new image instance and you should not have to call this every frame. You can cache an image an call ReplacePixels on the cached image.

I agree the static version is better and I use that design when I can, but in some case, I need a more dynamic design. And because it's a regression from 1.12.12 I was pretty sure it can be fixed. I'm suprised you won't fix it.

This might be fixable but the fix would not be simple, and again, calling NewImage every frame should be avoided so I don't think it would be worth fixing.


Soundness issues

Wakers contain a pointer to stack-allocated tasks, and nothing prevents the task from being deallocated while there still are wakers pointing to it.
Stack-allocated tasks are not pinned. You can mem::forget the JoinHandle (preventing the task from getting unlinked by JoinHandle drop) which releases the borrow on the task, and then move the task, which will break the linked list pointers.
cargo miri test and cargo miri run --example ... fail. I haven't looked deep in the code to know whether this is due to the above issues, or to other issues.

As of 9ff2b37f559a99f84c484edc6c9d258b43119fa6, Miri no longer complains.

the other issues still stand though!
it's fundamentally unsound to allocate tasks in the stack and wakers point directly to the tasks.

@Dirbaio I think I have a solution, currently sitting in pinned_tasks. Both futures_util::pin_mut! and core::pin::pin! take ownership of the task, ensuring that they cannot be core::mem::forgeted.

That doesn't fix the 1st issue "Wakers contain a pointer to stack-allocated tasks, and nothing prevents the task from being deallocated while there still are wakers pointing to it.".
Wakers are 'static. Once you get a waker pointing to a task, you can store it literally anywhere, forever. If the task is pinned then you're guaranteed its Drop will run, but there's no way to make Drop "recall" all the wakers pointing to the task that could be stored anywhere across the whole program.
It's possible to do if you add indirection to the wakers. Like, store a "task ID" in wakers, executor contains an id->pointer map so you can mark the id as "stale" on task drop to "deactivate" all the wakers. This adds complexity and hurts perf tho.
I've looked at this hard over the years and my conclusion is the only two good designs are either to alloc+refcount tasks (what most std executors do) or statically allocate tasks so they live forever (what embassy-executor and RTIC do). There's no way to stack-allocate tasks with good perf.

Yes, Wakers are the unsolvable issue.
I'd originally written this crate way back in 2020 when as far as I could see there wasn't really a way of doing async on bare metal. Since then both embassy and RTIC have flourished, and if fact I use embassy for my personal projects. As such, I think it's time to deprecate and retire nostd_async.
Do you by any chance know how I might do this?
Possibilities include:

Posting on the Github page that the project is retired
Yanking all versions of nostd_async
Publishing a new version with a compile error notifying users to use something else


[5.2] Validator : no need to merge an empty array

https://github.com/lucasmichot/framework/commit/c7af46f914db84d38bb0491ba605aef6ddcadc30 : No need to merge an empty array
https://github.com/lucasmichot/framework/commit/e99ff132fbc29b8152d58070cb47c811165833b8 : Extract logic to \Illuminate\Validation\Validator::formatArray (\Illuminate\Validation\Validator::addExtensions and \Illuminate\Validation\Validator::addReplacers are doing exactly the same thing)

Please squash to one commit.

Going to hold off on this one.


s3-fix: Add conditional logic to account for s3 bucket structure

Hey, wanted to submit this for you to look at. Noticed the file parsing wasn't working with the s3 choice, mostly because the browse calls were missing the optional bucket argument. This is a simplistic fix really, just pulling the name of the bucket for the custom directory. Should prolly use the browser to select the directory and allow bucket selection through that interface. More to come if you like it.
Also, if you want to merge this in at all, could you add the label hacktoberfest-accepted? Trying to get my approved PRs 🥇

Hey Code4Cakes, that's great! I've been prodding for help with S3 for a while, as I don't have a bucket set up, so this will save some annoyance.
I'll take a look and add the label! Small note, I'm going to change the target branch to dev, as master automatically updates the release in this repo. I'll then update the release info and merge back into master.
Thanks for the help

Also, if you want to take on general S3 improvements for further hacktoberfest submissions, I'm totally open to that too.
Thanks


add-lower-scored-trusty-package

add-lower-scored-trusty-package

Summary of packages with low scores
Minder detected that this PR is adding dependencies whose score is lower than the threshold configured with
Minder profiles. Below is a summary of the packages with low scores and their alternatives.

 Pkg
 Name
 Score
 Alternative Name
 Alternative Score

pypi
python-oauth2
4.6
oauthlib
7.8

pypi
python-oauth2
4.6
requests-oauthlib
7.6


feat: ✨ support sharding in snyk code

this adds sharding to getAnalysis. No client change needed despite increasing the version number. Takes the hash of the project path as shard.

It looks like a integration test _090_getAnalysis fails now.

It looks like a integration test _090_getAnalysis fails now.

just re-run tests, all passed. looks like it was glitch on backend.


Develop Add a chinese version of document Example_Simple.md

Make sure set the target branch to develop
What is the purpose of the change
To add a chinese version of document
Brief changelog
translation English to Chinese
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.06%) to 54.136% when pulling 4d773cef6bdbbce06e8fc49189184c28886753a4 on haoran-pku:develop into 160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop.

Codecov Report

Merging #3041 (4d773ce) into develop (2b236c3) will decrease coverage by 0.24%.
The diff coverage is n/a.

:exclamation: Current head 4d773ce differs from pull request most recent head a983cfb. Consider uploading reports for the commit a983cfb to get more accurate results

@@              Coverage Diff              @@
##             develop    #3041      +/-   ##
=============================================
- Coverage      47.91%   47.67%   -0.25%
+ Complexity      4559     4536      -23
=============================================
  Files            552      552
  Lines          36629    36629
  Branches        4844     4844
=============================================
- Hits           17552    17463      -89
- Misses         16848    16935      +87
- Partials        2229     2231       +2

Impacted Files
Coverage Δ

.../broker/subscription/SubscriptionGroupManager.java
54.11% <0.00%> (-16.48%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-13.44%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
71.15% <0.00%> (-7.70%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...apache/rocketmq/remoting/netty/ResponseFuture.java
85.00% <0.00%> (-5.00%)
:arrow_down:

...ketmq/client/impl/consumer/PullMessageService.java
75.55% <0.00%> (-4.45%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
43.47% <0.00%> (-4.35%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
51.67% <0.00%> (-4.31%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
58.11% <0.00%> (-4.28%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b236c3...a983cfb. Read the comment docs.

pls dont comment with Chinese for someone dont understand it.
i would close the PR and free to open another one, -_-


Monitoring - Unable to configure additional parameters via upgrading Rancher-Monitoring APP by GUI

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Enable the cluster monitoring for a cluster:

The container prometheus in pod prometheus-cluster-monitoring-0 hits the memory limit, which is 500Mi by default (This happens only when lots of workload exist in cluster. Whether the container hits the memory limit has no impact on following steps and results):

Track the memory limit spec in prometheus resouce object:
# while true;do date;kubectl get -n cattle-prometheus prometheus cluster-monitoring -o jsonpath='{.spec.resources.limits.memory}{"\n"}';sleep 2;done
Tue Mar  5 07:12:31 CET 2019
500Mi
Tue Mar  5 07:12:33 CET 2019
500Mi
Tue Mar  5 07:12:35 CET 2019
500Mi
Tue Mar  5 07:12:38 CET 2019
500Mi

Increase the memory limit for prometheus container by adding a parameter which is not present on the upgrading APP page by default, and upgrade the Rancher-Monitoring APP:

Those parameters in the red circle are present when open the upgrading page of Rancher-Monitoring APP by default, while the last one is newly added to increase the memory limit of prometheus.
Result:
After upgrading the APP, the newly added parameter first takes effect for several minutes waiting for old prometheus pod to remove, but then change back to the default value by itself when new prometheus pod gets up:

I've tried several other additional parameters, which are not present on the upgrading APP page by default, and they behaved similarly.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): Rancher 2.2.0-rc2
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Imported
Machine type (cloud/VM/metal) and specifications (CPU/memory): VM with 4 CPU and 16G MEM
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.3-1+fee411aca93f0e", GitCommit:"fee411aca93f0e786995cc125cf8f9783484f958", GitTreeState:"clean", BuildDate:"2018-12-04T06:49:44Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.3-1+fee411aca93f0e", GitCommit:"fee411aca93f0e786995cc125cf8f9783484f958", GitTreeState:"clean", BuildDate:"2018-12-04T06:45:24Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

Docker version (use docker version):

Client:
 Version:         1.13.1
 API version:     1.26
 Package version: docker-1.13.1-88.git07f3374.el7.x86_64
 Go version:      go1.10.2
 Git commit:      07f3374/1.13.1
 Built:           Thu Dec  6 07:01:49 2018
 OS/Arch:         linux/amd64

Server:
 Version:         1.13.1
 API version:     1.26 (minimum version 1.12)
 Package version: docker-1.13.1-88.git07f3374.el7.x86_64
 Go version:      go1.10.2
 Git commit:      07f3374/1.13.1
 Built:           Thu Dec  6 07:01:49 2018
 OS/Arch:         linux/amd64
 Experimental:    false

Please configure them in monitoring setting page