SPK service create should validate helm chart repo is valid URL format

Describe the bug:
If the helm chart repo doesn't have http:// or https:// Fabrikate will not recognize it. This could be a Fabrikate issue instead. Depends where it should be fixed.
No http:// or https://
INFO[27-01-2020 18:59:07] 🚁  Component 'chart' requesting helm chart in path 'dev.azure.com/abrig/spk/_git/helm-charts' from git repository 'master'
INFO[27-01-2020 18:59:07] 🚁  Component requested latest commit: fast cloning at --depth 1
INFO[27-01-2020 18:59:07] 🚁  Component requested branch 'master'
INFO[27-01-2020 18:59:07] 🚁  Cloning dev.azure.com/abrig/spk/_git/helm-charts@master:head => /var/folders/lj/9dqdzw193jg2jhjp9x19fyb00000gn/T/b985f7d6-2cb1-4f33-a80f-42cc5e02483f
ERRO[27-01-2020 18:59:07] 🚫  Error occurred while cloning: 'dev.azure.com/abrig/spk/_git/helm-charts@master:head'
exit status 128: fatal: repository 'dev.azure.com/abrig/spk/_git/helm-charts' does not exist
Error: exit status 128
Usage:
  fab install [flags]

Flags:
  -h, --help   help for install

Global Flags:
  -v, --verbose   Use verbose output logs

ERRO[27-01-2020 18:59:07] exit status 128

With http:// or https://
INFO[27-01-2020 19:00:14] 🚁  Component 'chart' requesting helm chart in path 'http://dev.azure.com/abrig/spk/_git/helm-charts' from git repository 'master'
INFO[27-01-2020 19:00:14] 🚁  Component requested latest commit: fast cloning at --depth 1
INFO[27-01-2020 19:00:14] 🚁  Component requested branch 'master'
INFO[27-01-2020 19:00:14] 🚁  Cloning http://dev.azure.com/abrig/spk/_git/helm-charts@master:head => /var/folders/lj/9dqdzw193jg2jhjp9x19fyb00000gn/T/fd753910-6f47-4f69-a9ac-ce517e2c2fbb
INFO[27-01-2020 19:00:14] 🚚  Copying /var/folders/lj/9dqdzw193jg2jhjp9x19fyb00000gn/T/fd753910-6f47-4f69-a9ac-ce517e2c2fbb => /Users/andrebriggs/Code/spk-ab/tests/spk-env/fabrikam-hld/fabrikam-frontend/fabrikam-frontend-service/master/helm_repos/chart
INFO[27-01-2020 19:00:14] 🚁  Updating helm chart's dependencies for chart in '/Users/andrebriggs/Code/spk-ab/tests/spk-env/fabrikam-hld/fabrikam-frontend/fabrikam-frontend-service/master/helm_repos/chart/fabrikam-frontend/chart'
INFO[27-01-2020 19:00:14] 👈  Finished install for component: chart
INFO[27-01-2020 19:00:14] ✅  Installed successfully: fabrikam-frontend-service
INFO[27-01-2020 19:00:14] ✅  Installed successfully: master
INFO[27-01-2020 19:00:14] ✅  Installed successfully: static
INFO[27-01-2020 19:00:14] ✅  Installed successfully: chart
INFO[27-01-2020 19:00:14] 🙌  Finished install

To Reproduce:
Run spk service create . -n "$repo_dir_name-service" -p "$repo_dir_name/chart" -g $helm_repo_url -b master where $helm_repo_url does not have http:// or https://
Git push changes. let build pipelines run and approve PR. Look at HLD to Manifest repo
Expected behavior:
Either validation should have in spk service create or we open a bug in Fabrikate.
Does this require updates to documentation?:
YES

@evanlouie let's match what git expects and change if needed.
@bnookala I see you removed yourself from this. Is this still in progress?


executeround, exerciseround, mintoptionforround, startdeposiforround,…

… update keeper func

@0xriazaka
Take a look at this requests.


When training the model, the memory usage continues to increase until the memory overflows.

Environment

Python=3.8  pytorch=1.12  cuda=10.2
mmcv-full=1.7.2  mmdet=2.28.2

The command of training
python tools/train.py configs/exp/faster_rcnn_r50_fpn_1x_mydataset.py --work-dir /xxx/xxx --gpu-id 0 --auto-scale-lr

Except for some hyperparameter adjustments, no changes were made to the model.

Forgot to say one important thing. The usage of video memory does not occur soon after training, and the video memory overflow occurs. Instead, it took a while to train, and in fact, the model went through more than 4,000 iterations before there was a memory overflow. Over the course of more than 4,000 iterations, the memory grew slowly.

Forgot to mention one important thing. Memory usage does not cause memory overflow soon after training. Instead, it was trained for a period of time. In fact, the model went through more than 4,000 iterations before memory overflow occurred. Over the course of more than four thousand iterations, the memory slowly grew.

Forgot to mention one important thing. Memory usage does not cause memory overflow soon after training. Instead, it was trained for a period of time. In fact, the model went through more than 4,000 iterations before memory overflow occurred. Over the course of more than four thousand iterations, the memory slowly grew.

same problem :(
My vram was increasing steadily while training the Cascade Mask R-CNN.


Remove duplicate prefix functionality

The acceptance of duplicate prefixes may confuse users as they might forget that the newest duplicate prefix overrides the older one. The removal of this function where the commands only accept one prefix except for tags will make user experience more pleasant.
Old functionality
Command: addstudent -n sammy -p 999 -n james -p 123
Response:

James
phone: 123
email:
address:
tags:

New functionality
Command: addstudent -n sammy -p 999 -n james -p 123
Response:
Duplicate prefix -n is not allowed
The first duplicate prefix detected will be rejected. However, multiple tags are still allowed.
Command: addstudent -n sammy -p 999 -t hansome -t geek
Response:

sammy
phone: 999
email:
address:
tags: hansome, geek

Warning: This PR changes how ArgumentMultimap and ArgumentTokenizer work by making them reject duplicate prefixes that are not tags.

Codecov Report

Merging #76 (693487f) into master (292ee39) will decrease coverage by 1.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
- Coverage     63.62%   62.19%   -1.44%
+ Complexity      499      489      -10
============================================
  Files            96       96
  Lines          1787     1788       +1
  Branches        183      184       +1
============================================
- Hits           1137     1112      -25
- Misses          577      605      +28
+ Partials         73       71       -2

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/ArgumentTokenizer.java
97.36% <ø> (ø)

...va/seedu/address/logic/parser/TeachWhatParser.java
75.00% <ø> (-1.20%)
:arrow_down:

...a/seedu/address/logic/parser/ArgumentMultimap.java
100.00% <100.00%> (ø)

.../seedu/address/logic/parser/EditCommandParser.java
0.00% <0.00%> (-92.60%)
:arrow_down:

...java/seedu/address/logic/commands/EditCommand.java
95.52% <0.00%> (-1.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292ee39...693487f. Read the comment docs.


Fix ModuleLikeClass for nested scopes

#1
  class A
    module B
      include C
    end
  end

#2
module A
  class B
    class << self
      include C
    end
  end
end

Can't reproduce :(


nixify

I would probably not move compat to a separate file -- it's an old convention. It's just better to have two files in the root which never change than three)

But otherwise, LGTM!
Just interested, did you use https://github.com/cab404/vscode-direnv/blob/master/flake.nix as a reference?

I would probably not move compat to a separate file -- it's an old convention. It's just better to have two files in the root which never change than three)

:heavy_check_mark:

Just interested, did you use https://github.com/cab404/vscode-direnv/blob/master/flake.nix as a reference?

i did! i tried a few different things (including npmlock2nix and reusing the node_modules from the package for the dev shell) but in the end was happiest with your approach
also that problem with vsce and the broken symlink inside deps would have stumped me forever so thanks for figuring it out!


Allow refund status to patch transaction

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Add refund status to TransactionService.
Why
Bug fixes.
Known limitations
N/A

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr618.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr618.previews.kube001.services.stellar-ops.com/


Fix commands related to maturin in building docs

This PR fixes two things in the building docs :

Documentation suggests to install latest maturin version, but the version pinned in pyproject.toml is ~=1.4.0, resulting in this warning :⚠  Warning: You specified maturin ~=1.4.0 in pyproject.toml under `build-system.requires`, but the current maturin version is 1.7.6

Build commands in docs use --cargo-extra-args option but it is removed since version O.13 :❯ maturin build --cargo-extra-args="--features llvm14-0"
error: unexpected argument '--cargo-extra-args' found

  tip: a similar argument exists: '--target'

Usage: maturin build <--quiet|--jobs <N>|--profile <PROFILE-NAME>|--features <FEATURES>|--all-features|--no-default-features|--target <TRIPLE>|--target-dir <DIRECTORY>|--manifest-path <PATH>|--ignore-rust-version|--verbose...|--color <WHEN>|--frozen|--locked|--offline|--config <KEY=VALUE>|-Z <FLAG>|--timings=<FMTS>|--future-incompat-report|ARGS>

For more information, try '--help'.

@microsoft-github-policy-service rerun


Implement WARP2 charger wakeup using evse/control_pilot_disconnect API or start/stop

Is your feature request related to a problem? Please describe.
The WARP2 charger allows direct control of the control pilot signal to the car, allowing simulation of a full unplug/replug of the charging cable via evse/control_pilot_disconnect API (see https://www.warp-charger.com/api.html#features_section and https://www.warp-charger.com/api.html#evse_control_pilot_disconnect) but EVCC does not include this feature for it's charger wakeup function (no API.Resurrector for WARP2).
Describe the solution you'd like
It would be great to see the use of the evse_control_pilot_disconnect API endpoint being used for charger car wakeup (as available for e.g. OpenWB) if it is available. If it is not available (in case of using WARPs load management) similar functionality is also available by stopping and starting the charge on WRAP (via API evse/stop_charging and evse/start_charging) especially when EV Wakeup is also configured in WARPs Charge settings.
Describe alternatives you've considered
None
Additional context
I have a Hyundai Kona EV 2020 that sometimes does not wakeup after it's been idle for too long. Bluelink integration triggers the wakeup and charge but is sometimes not available (503 Service unavailble) and also is only triggered once every 15 Minues (by default due to API Limits) hence why the charger wakeup using my WARP2 would be preferrable.

Dieser Wert kann über evse/control_pilot_disconnect_update mit dem selben Payload aktualisiert werden.

Mhhhm was muss da wohl geschrieben werden?

evse/control_pilot_disconnect via HTTP returns (without a car connected as I'm not home atm):
{"disconnect":false}

so presumably it is just a bool true but I don't know if it automatically resets after it's done or if you have to reset it manually back to false back again. I can check that once I have the car back on the charger tomorrow.

I think this is only relevant if no WEM (warp energy manager) is installed.
In case of that, the wem is controlling the CP disconnect.

No quite- that's the delay between our tries (up to 3). Sofar all boxes we've encountered were doing "atomic" wakeups. This is a bit unfortunate since we'd also need to handle the timing:

You have to set it back to false to reconnect CP.

Since Warp already does this it seems we shouldn't. Or is CP disconnect not used at all without WEM?

Or is CP disconnect not used at all without WEM?

Only the API to control the disconnect is deactivated with the WEM. (To not interfere with the phase switching) With and without the WEM, the charger will disconnect CP and reconnect it four seconds later if the car does not react in 30 seconds.

... the charger will disconnect CP and reconnect it four seconds later if the car does not react in 30 seconds.

But only if EV Wakeup is configured in Charge Settings, correct?
This doesn't seem to work at times for some cars (maybe the 4 second wait is indeed not enough). What seems to work for me in these cases is stopping and restarting the charge via Warp's WebUI but that might be a coincidence. Hence my fallback suggestion to use stop_charging, followed by an immediate start_charging for the wakeup feature (maybe as a configuration option for EVCC?).

But only if EV Wakeup is configured in Charge Settings, correct?

Correct.

maybe the 4 second wait is indeed not enough

We are currently (as of half an hour ago) testing a new firmware that retrys the CP disconnect a second time, but for 30 seconds, if the 4 second disconnect did not wake up the car. If you want to, you can test this firmware:
warp2_firmware-NIGHTLY_2_2_1_65dca55f_2aa5b51ad4b2067_merged.bin.zip
(Extract it first. Github does not allow attaching .bin files, but .zip works)

Is this firmware also working with the custom firmware for the wem you have published me at the e208 thread?

Seems this request can be replaced by better Warp firmware- tentatively closing.


Reverted to src/app for tests/imports

Reverting 243497925a786dfbbd5cc99f0c16ac3d6b6f3b22.  May look at making component creation more first-class in the future.

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #118   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          32     32
  Lines         671    671
  Branches       82     82
=====================================
  Hits          671    671

Flag
Coverage Δ

#builder
100% <100%> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

config/webpack/test.webpack.config.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912f5c2...4e3b07e. Read the comment docs.


Blog module ignores "modify page details" setting

When I add the blog module to a page, the page title is changed to the blog title regardless of the checkbox setting "Modify Page Details". Basically, in this instance I don't want the page title to change, but the page title is set to the blog title no matter what.
We are using the blog for "news" posts. I am showing a single category from the blog on a page other than the main "news" page, using the same template as the main blog page to show those headlines.
Blog 6.4.1
DNN 9.00.02

Have you found a solution for the page title?

I cannot reproduce this issue, can you please provide clear steps to reproduce.


IsUITesting() always returns false (OSOE-412)

As reported by @DemeSzabolcs.
Jira issue

Do you really need to update the NuGet reference in all projects? I don’t think all the submodules are necessary. Consolidation doesn't affect the dependencies only used during NuGet publishing.

It seems to me that only publishing Application Insights should be enough (due to its own changes, not for this issue), and otherwise, only publishing Lombiq.Tests.UI* projects, and updating the NuGet references in the test projects, are necessary.

I'm not sure, updating only Lombiq.Tests.UI* NuGet references are enough. If you have resource changes between the NuGet version (e.g. recipes) using different versions for Lombiq.Tests.UI* and the module itself can cause mystic errors, and looks ugly :)

Do you really need to update the NuGet reference in all projects? I don’t think all the submodules are necessary. Consolidation doesn't affect the dependencies only used during NuGet publishing.

If I remember well, updating UITT reference only in one module (in this case Application Insight) is not enough, the consolidating reports error in NuGet test.

What I'm saying is, that you have to only update UITT in the following places for its changes to take effect:

The UI test project in the NuGetTest solution (also necessary in the root solution but that's given due to using the source).
The web project in the NuGetTest solution.
If a module-specific UI test project, like that of AI, uses new APIs from UITT, then that as well, but only then.

This way, even if module-specific UI test projects may reference an older version of UITT, the whole thing should properly work, since at the root of the dependency chain, the app that actually runs and ultimately loads the packages, the latest UITT is used.

In general, you are right, but if I do a version update the way you write, and update UITT version only one NuGet (in this case AI), the NuGet test is fail in verify-dotnet-consolidation. I'm not tried nowadays, but a few weeks ago the consolidation check failed, in a similar case.

I thought that won't happen, since donsolidation refers to projects (not NuGet packages) referencing the same version of a given project. While our projects do that with UITT, only in NuGetBuild, so the source build shouldn't be affected. But you're right, dotnet-consolidate just looks at the references and doesn't care about the conditions in the csprojs, so these updates are necessary: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/3322274303/jobs/5491064235#step:4:46

Sorry, I remembered only the result and the reason for the situation.


Task - Matrix Row coder - add 'Diagnosable: ' warning/status on floating top navbar.[Was: Task - Matrix Row coder - descriptiors overview and description sections not visible]

The top part of Matrix Row codder contained the overview of the descriptors and OTU description sections.
Both are not visible any more.

Aren't they linked form the top bar now?  Or did we leave those out?
On Mon, Nov 22, 2021 at 5:16 PM Dmitry Dmitriev @.***>
wrote:

The top part of Matrix Row codder contained the overview of the
descriptors and OTU description sections.
Both are not visible any more.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/2674, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQSFJ7WHHVKNTDT4Q2BLUNLFMRANCNFSM5ISFW4RQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Aha! I was thinking about making expanding sections, but this may also work.
One improvement still needed:
When not enough scores, the diagnosis returns:
Cannot be separed from other rows in the matrix!
It would be nice to have this or at least an orange triangle be visible on the top of the page.

Aha! I was thinking about making expanding sections, but this may also work. One improvement still needed: When not enough scores, the diagnosis returns: Cannot be separed from other rows in the matrix! It would be nice to have this or at least an orange triangle be visible on the top of the page.

Does it have to be updated every time the user makes a change?

Probably not. I would do it on page entry and add the button "check again" The validation is on the top of the page, and it would not be visible all thetime.

It should definitely not check every time.  I think once there is any
change you could enable a disabled verison "check again".  This needs to be
in the top bar modal IMO.
On Tue, Nov 23, 2021 at 9:11 AM Dmitry Dmitriev @.***>
wrote:

Probably not. I would do it on page entry and add the button "check again"
The validation is on the top of the page, and it would not be visible all
thetime.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/2674#issuecomment-976689085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQSBS4APPXP3GMFXTRVDUNOVJZANCNFSM5ISFW4RQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@jlpereira: Top bar:
"Diagnosable: <check|triangle> [Recheck]"

Button Recheck beside is disabled at first, enabled at first /observations PATCH/PUT/DESTROY
Triangle is a modal/link (or maybe just hover if precident) with the full list errors if there is > 1 (might not be necessary)


New MultiIndex dimension behaviours

What is your issue?
As of the latest release (2022.6.0), the behaviour of MultiIndex coordinates and their constituents appears to have changed.
Creating a simple multi-indexed DataSet:
ds1 = xr.Dataset({'foo': (('x',), [1, 2, 3])}, {'x': [1, 2, 3], 'y': 'a'})
ds2 = xr.Dataset({'foo': (('x',), [4, 5, 6])}, {'x': [1, 2, 3], 'y': 'b'})

mult = xr.concat([ds1, ds2], dim='y').stack(yx=['y', 'x'])

Printing the DataSet and the coordinate indices on version 2022.3.0:
mult
<xarray.Dataset>
Dimensions:  (yx: 6)
Coordinates:
  * yx       (yx) MultiIndex
  - y        (yx) object 'a' 'a' 'a' 'b' 'b' 'b'
  - x        (yx) int64 1 2 3 1 2 3
Data variables:
    foo      (yx) int64 1 2 3 4 5 6

mult.coords.indexes
yx: MultiIndex([('a', 1),
                ('a', 2),
                ('a', 3),
                ('b', 1),
                ('b', 2),
                ('b', 3)],
               names=['y', 'x'])

Printing the DataSet and the coordinate indices on version 2022.6.0:
mult
<xarray.Dataset>
Dimensions:  (yx: 6)
Coordinates:
  * yx       (yx) object MultiIndex
  * y        (yx) <U1 'a' 'a' 'a' 'b' 'b' 'b'
  * x        (yx) int64 1 2 3 1 2 3
Data variables:
    foo      (yx) int64 1 2 3 4 5 6

mult.coords.indexes
Indexes:
yx: MultiIndex([('a', 1),
                ('a', 2),
                ('a', 3),
                ('b', 1),
                ('b', 2),
                ('b', 3)],
               name='yx')
y: MultiIndex([('a', 1),
               ('a', 2),
               ('a', 3),
               ('b', 1),
               ('b', 2),
               ('b', 3)],
              name='yx')
x: MultiIndex([('a', 1),
               ('a', 2),
               ('a', 3),
               ('b', 1),
               ('b', 2),
               ('b', 3)],
              name='yx')

On the latest version (2022.6.0), the constituent coordinates (x,y) of the multi-indexed coordinate (yx) have asterisks next to them, implying that they are dimensional (despite the them not being named equal to their sole dimension, as stated in the docs' coordinates section).

dimension coordinates are one dimensional coordinates with a name equal to their sole dimension (marked by * when printing a dataset or data array)

Further, looking into the .coords.indexes shows that each constituent coordinate is also indexed by an instance of the same MultiIndex.
I was wondering if this change been made design and whether the documentation just need updating, or I have misunderstood something along the way.

Hi @ConnorSwales,
Yes this is an intentional change part of the ongoing explicit indexes refactor. There's still some work to do on the documentation. For more details, see:

#6752
#6293
https://docs.xarray.dev/en/stable/roadmap.html#flexible-indexes
https://github.com/pydata/xarray/projects/1

Closing for now.
Feel free to reopen or better to comment in the linked issues above.


Update Pages “about”

Automatically generated by Netlify CMS

👷 Deploy Preview for safehavenaccounting processing.

Name
Link

🔨 Latest commit
26ef8e8f64b7e3d1d58d01b82972e019e8155a47

🔍 Latest deploy log
https://app.netlify.com/sites/safehavenaccounting/deploys/6493321651daf10008e0e386


Allow nested_in to accept a parser that emits a different type of tokens

I have this use case, where expr is a parser with (Token, Span) as the input, and the surrounding function returns a parser that takes in `(StringToken, Span)
expr.nested_in(select_ref! {
	StringToken::Interpolation(inner) = e => {
		inner.as_slice().spanned(SimpleSpan::to_end(&e.span()))
	},
});

However, this errors because nested_in expects the parser being passed in to both accept and return the same type, which clashes here.

Hmm. I can see this use-case, certainly.

I think it's just a matter of changing around the type params to allow for it?
fn nested_in<IB: Input<'a>, EB: ParserExtra<'a, IB>, B: Parser<'a, IB, I, EB>>(
    self,
    other: B,
) -> NestedIn<Self, B, O, E>
where
    Self: Sized,
{
    NestedIn {
        parser_a: self,
        parser_b: other,
        phantom: EmptyPhantom::new(),
    }
}

I've had a go at implementing this, and it does seem to work, but it comes with a constraint: specifically, that the State, Context, and Error types need to match between the inner and outer inputs.
I've pushed up a commit on main that makes this change. Could you give it a go to see if it does what you're looking for?

Updated, this seems to be related but I'm not sure how (maybe the same change needs to be made for select and select_ref?)
let interpolation= expr
	.nested_in::<_, StringInput, StringExtra>(select_ref! {
		StringToken::Interpolation(inner) = e => {
			inner.as_slice().spanned(SimpleSpan::to_end(&e.span()))
		},
	})
	.map(|t| StringPart::InterpolatedExpr(t.into()));

the method `map` exists for struct `NestedIn<P, SelectRef<{closure@lib.rs:2809:13}, SpannedInput<..., ..., ...>, ..., ...>, ..., ..., ..., ...>`, but its trait bounds were not satisfied

There's not enough information there to be useful. My hunch is that one of the constraints I listed is being violated somehow.

Can we discuss on Discord or something? I don't want to clog up the issue tracker with debugging.

Sure. I'm active on the Rust Community Discord, in the #langdev channel.
To anybody else reading this, any important information will be fed back here.


Remove script specific Makefile variables

There were some script specific Makefile variables added recently:
https://github.com/submariner-io/shipyard/blob/devel/Makefile.inc#L54-L69
We have, long ago, decided against having script specific make variables. In this regard, this change is a regression.
In addition, having these script options redefined as make variables, whereas other options aren't, is very inconsistent.
Instead of having and using these script specific variables, use the general *_ARGS variables i.e. E2E_ARGS

Is this still going to be worked on?

This has very low priority, closing for now


Does it work in IOS

Yes, Just support Android.

Why don't you declare this on read me file, thanks

I didn't mention that, but that platform part I guess because there is IOS folder in project, pub dev thought this library support IOS


Scale_type is not working

I have imageview set like this
<com.wingjay.blurimageviewlib.BlurImageView
android:layout_width="match_parent"
android:layout_height="match_parent"
android:scaleType="fitXY"

android:src="@drawable/grey"

/>

but Image view look like this https://goo.gl/photos/QaF3F8xCe6CfNLRF7 . I tried changing scale programmatically , same thing.
I downloaded your project and changed scale in blur class to fitxy , same thing .
What can be the problem .

Sorry for late answer.
the BlurImageView is actually not a ImageView, see here https://github.com/wingjay/BlurImageView/blob/master/blurimageviewlib/src/main/java/com/wingjay/blurimageviewlib/BlurImageView.java#L33
And I'll add a public function to set its scaleType.
Thanks.


Inconsistent argument naming for directory_url and server_url

It's referred to as directory_url here:

https://docs.rs/instant-acme/latest/instant_acme/struct.Account.html#method.from_parts

It's referred to as server_url here:

https://docs.rs/instant-acme/latest/instant_acme/struct.Account.html#method.create
https://docs.rs/instant-acme/latest/instant_acme/struct.Account.html#method.create_with_http

It would be good for this to be more consistent, or descriptive. It looks like server_urls in any case is used in Client to perform a request and fetch the directory, so perhaps directory_url is a better name.
See also https://github.com/instant-labs/instant-acme/pull/50#discussion_r1650033114

Other ACME implementations also make it obvious that this URL is related to the directory concept:
https://docs.rs/instant-acme/latest/instant_acme/struct.Account.html#method.create

I think renaming this to directory_url everywhere probably makes sense, want to send a PR to do that?

Sure thing! Happy to do that now

Okay I've created a branch off #50 over at https://github.com/kellpossible/instant-acme/tree/directory-url-argument-rename which I'll submit as an MR once #50 is merged to save on any merge conflict resolution that may be necessary.


Randomly crashes

After some time, the bot will stop and go offline and when I go to my PC the cmd says press any key to continue.

Please send screenshots of any errors you get

Those are DNS errors.  That's a problem with your network configuration or your internet connection.

My internet is fine though

Seemingly not if you are getting periodic DNS errors.

I have never had any problems with any other programs besides this one

@nickyo1011 if your internet is fine the configuration for your DNS may not be. I recommend checking your DNS settings to see what is going on.

Is this still happening/up-to-date?


Web project

Is your feature request related to a problem? Please describe.
Now the web build is not able to open projects.
Feature description
It should be possible to open projects when using the web build, probably it is necessary to compile the project and link statically to the atta executable. It should be possible to build atta with projects linked statically, so that the final build is only able to execute that project.
Tasks

[x] Build atta with project linked statically
[x] Disable possibility to open other projects when compiled specifically to a specific project
[x] DIsable hot-reload when compiled statically
[x] Make web build work with project linked statically

Registering scripts
Because we are not linking dynamic libraries with the scripts, we need another way to register scripts.
Project dynamic target linking
If it is dynamic library, we look for a function Script* createScript() defined in the library. We can search for this function for each of the project libraries
Project static target linking
It turns out to be a bit more tricky to register scripts when the project is linked statically.

We can't define Script* createScript() multiple times, so maybe define this function with other names? But how to find which files to include and what is the function name? A lot of corner cases
The final solution creates a scriptSystem/scripts.h file at compilation time with the include for all project target headers. When ScriptManager includes this file, all the inline variables are solved (which calls a function to register the script). We are now registering the scripts to the ScriptManager using one inline variable per script header.

Building emscripten with static project

Could not find atta installed -> now the project being built will always use the current atta being built, not the installed one.
The project .atta file and resources/ folder are copied to the we build (.data). They are located in /project/ in the web filesystem.

Web static build was finally able to execute projects, but the colors were wrong in WebGL. Turn out the problem was because we needed to copy the vector data to a temporary variable before sending to the GPU (not sure why).
Before:

After:


Why Wine 6.11+ support was dropped?

I started reading #1444 after I saw that Wine is unsupported, then I found out that Wine 6.11 had a I fix for this and I was ready to open a PR for the readme. Then I saw #1505, which was reverted in #1596.
What was the reason on removing something that works from the supported list? And what is needed to add it back?

Just tested Wine 9 and it works.

People claimed Wine worked, we put put "we support Wine" in the readme. Then others claimed it didn't work, in a less then pleasant way, so we removed it. At this point, I want to see CI support (e.g. see https://github.com/tokio-rs/mio/pull/1637) before we add anything.

If we ever want to claim we support Wine I first want CI support. Since that doesn't seem to be happening I'm going to close this for now, it can be reopened if someone is willing to put in the effort to finish #1637.


CLOUD-727 we can set day only for weekly interval

CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are the manifests (crd/bundle) regenerated if needed?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PG version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
failure

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
failure

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/630/commits/c9c504337052ac57987bf6987bebd9f0bbdf4f5c
image: perconalab/percona-postgresql-operator:PR-630-c9c504337


Order OMIS Markets by country name in API response

Codecov Report

Merging #431 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #431   +/-   ##
========================================
  Coverage    95.79%   95.79%
========================================
  Files           91       91
  Lines         2993     2993
  Branches       265      265
========================================
  Hits          2867     2867
  Misses          86       86
  Partials        40       40

Impacted Files
Coverage Δ

datahub/omis/market/metadata.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4875ffc...646ec7c. Read the comment docs.


always_run is deprecated in Ansible 2.2

Issue Type

Bug report

Ansible and Ansible Lint details

ansible <IP_ADDRESS>
ansible-lint 3.4.3
ansible installation method: source
ansible-lint installation method: source

Desired Behaviour
always_run is deprecated in Ansible 2.2, so it'd be nice if ansible-lint caught it and complained.

This is quite a simple rule to write if you'd like to write it - you're basically checking for
'always_run' in task

using the matchtask check - not hugely different to TaskHasNameRule.py

v3.4.10 is now available with this fix.


include<cuda.h> in thread_local

https://github.com/ROCmSoftwarePlatform/cub-hip/blob/835ca6906567e4905837d319911fed9cb034e679/cub/thread/thread_load.cuh#L37
Needs to be fixed.

https://github.com/ROCmSoftwarePlatform/cub-hip/blob/89de7ab20167909bc2c4f8acd397671c47cf3c0d/cub/thread/thread_store.cuh#L36
And there is another one. Please fix.

@iotamudelta
We use branch https://github.com/ROCmSoftwarePlatform/cub-hip/tree/hip_port_1.7.3 for HIP ports. Please check if your issue is fixed with above branch.

@sriharikarnam Caffe2/PyTorch have used 1.7.4 in the past and now want to use master since that branch got merged. Please simply remove the CUDA imports - I can also make a PR for that.
If you look at the branch you reference, it still has the #include<cuda.h> in thread_load.cuh...


https://superbbenchmark.org is down.

@leo19941227

Hi,
its back. However, updating the https certification is required for submission.
will work on that tomorrow.


I think this action or one of its dependencies are using an outdated GitHub Action syntax

Here's a link to a log file showing the warning: https://github.com/gjtorikian/commonmarker/actions/runs/3269757507/jobs/5377628002#step:4:391
And the notice: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

(This might be solved by merging https://github.com/oxidize-rb/cross-gem-action/pull/97)

Sorry, but this isn't solved yet @ianks. See https://github.com/gjtorikian/selma/actions/runs/3752129620/jobs/6374106251#step:4:602 for an example: despite pinning the action to main, the warnings persist.

Any idea what it is??

I think I got it: https://github.com/actions/toolkit/pull/1178
@actions/core should be bumped to >= 1.10; it's currently ^1.9.0

Closed by merge of #84


SDA-8551 Sync replicas validation for hosted clusters

This ticket is a follow-up of https://issues.redhat.com/browse/SDA-7929 for ROSA CLI.
Hypershift Operator updated the minimal replica validation, and those changes have been propagated into the backend (SDA-7929) and frontend (SDA-8551).
cc @oriAdler @gdbranco

/lgtm


offline open street map

Hi
It will be nice if we could view photos on the map at places with no internet connection, this will also improves private

Are you proposing that Aves downloads maps from servers that allow that, and then store these maps on the user's device? If so, i do not intend to do that.
But i know that users who use alternatives to Google Mobile Services (like microG) can redirect Google Maps access to the service they want, so they could use an offline OSM service.


Library broken (DroidGuard service down)

I was messing around with the Snapchat app and this library a bit to see why #27 the Google Auth token couldn't be retrieved. I see multiple calls made to https://android.clients.google.com/auth, but in all the requests the app header is com.google.android.gms and the parameter for the callerPkg is com.google.android.gms too. I see no requests made to the auth endpoint with the Snapchat package name during login, logout and general usage of the app so from this I assume that the Snapchat app is not making any calls to the auth endpoint.
So I tried editing the library to work without the need of a Google Auth token (as it seems the Snapchat android app can work without requesting it). I then ran into another issue. The login request takes a parameter called attestation, and this library retrieves that value through the Casper API. But the problem is these endpoints are no longer active.
Both of these endpoints return not found:
https://api.casper.io/droidguard/create/binary
https://api.casper.io/droidguard/attest/binary
{
    "code": 404,
    "message": "The DroidGuard Service is no longer available."
}

I'm not sure how the Snapchat android app generates the attestation value, this will require decompiling the app which I've not looked into.
I've not looked any further than this. It does seem possible to reissue the login request hours later and it works fine. So it may be possible to reuse the attestation value after manually receiving it once?

@fisch0920 is there any chance of this being resolved soon? I am having the google auth issues as well.

hey @jsutaria, i'm honestly not sure what it would take to get this lib working again as I haven't had time to look at this project in awhile.  maybe another contributor on here knows how to help you move forward.

@fisch0920 is it possible to use an older version of the api that was working or something like that?

Unfortunately, Snapchat disallows accessing previous versions so as far as I know it's currently a no-go.  I'd suggest checking out the php lib for people who may know more: https://github.com/mgp25/SC-API/

Thanks!

Just added an updated Status to the README to let people know up front that this library is currently broken.  Sorry for any confusion.


it doesn't work properly on macbook.

Attach (recommended) or Link to PDF file here:
helloworld.pdf exactly in examples.
Configuration:

Web browser and its version: newest Chrome on Mac
Operating system and its version: Macbook, M2
PDF.js version: 2.14.305
Is a browser extension:

Steps to reproduce the problem:
1.
2.
What is the expected behavior?
the project structure of mine, it's a simple html file:

What went wrong?
I don't know if the usage is correct, it behaved like this:

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


[Feature request] Setting option to change ISO driver on PSP games

Some PSP games (mostly collection or recompilation games like Metal Slug Anthology) don't work properly with the Inferno driver. Since the Retroflow Adrenaline Launcher settings go back to default when launching a game again, i wonder if its possible to add a option to always launch PSP games with a specific driver, or a way to save the booter settings on a game without lost them when I launch another game

Closing issue prior to archiving

Feature has been added


MySQL compatibility with Terraform

Platform or tool
MySQL
Desired or expected behavior
MySQL shell plugin currently provisions credentials using a temporary file. While this approach works great for the MySQL binary, for MySQL Terraform provider (there are tons of unofficial providers, haven't spotted an official provider yet), we'll need to use MySQL environment variables.
The expected behavior would be:

Temp file provisioner only for MySQL binary.
Env var provisioner for Terraform.

Current behavior
Credential provisioning happens as a temporary file.
Relevant log output
No response
op CLI version
2.19.0-beta.01

This was tracked in a parent issue, but we are branching it out to track them more precisely.


Make POSTMASTER_ADDRESS mandatory

And configure dovecot + /etc/aliases with it.

Just see that, when empty, it's currently statically set to<EMAIL_ADDRESS>which is not a good idea.

@tomav Adding this might break a lot of deployments.
Agree to not implement it as mandatory?

Ok.


Notification for multiple endpoints

Type: bug
The following has been addressed in the PR:

There is a related issue
Unit or Functional tests are included in the PR

Description:
Resolves #352

@ayusharma it seems CircleCI got 🍺  today. I've fetched again the test.

Yes. Circle CI is failing for a test case, that should not happen. I'll update the PR with requested changes.

The same test case is still failing :(

I will check this afternoon what’s the issue there

@juanpicado Have you reviewed CI failing issue?

@juanpicado I have rebased it with master and all checks are passing now. Please go ahead and merge this PR if all looks correct.

Sorry the long delay @ayusharma , please rebase from master I'll merge asap.


Add more code documentation

Codecov Report

Merging #21 (10cad64) into develop (2201d1f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #21   +/-   ##
==========================================
  Coverage      37.08%   37.08%
  Complexity        50       50
==========================================
  Files             14       14
  Lines            240      240
  Branches          31       31
==========================================
  Hits              89       89
  Misses           145      145
  Partials           6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2201d1f...10cad64. Read the comment docs.


Type change of HiveWarehouseSession from interface to class in HDP 3.1.4

Hi,
we wrote Spark code that works on HDP 3.x using the HiveWarehouseSession. In the last version (HDP 3.1.4) it fails with:
java.lang.IncompatibleClassChangeError: Found class com.hortonworks.hwc.HiveWarehouseSession, but interface was expected

This repository does not contain any commits on that, but the files here and the jar files in HDP 3.1.4 contains an abstract class instead of an interface.
Why was that changed? This breaks all compiled code... Is there a known workaround to be compatible with HDP 3.x and HDP 3.1.4+?

As a workaround, parts of the HiveWarehouseSession can be used directly:
import com.hortonworks.hwc.HiveWarehouseSession;
...
HiveWarehouseSession session = HiveWarehouseSession.session(sparkSession);

becomes
import com.hortonworks.spark.sql.hive.llap.HiveWarehouseBuilder;
import com.hortonworks.spark.sql.hive.llap.HiveWarehouseSession;
...
HiveWarehouseSession session = HiveWarehouseBuilder.session(sparkSession);

I used in this way:
import com.hortonworks.spark.sql.hive.llap.HiveWarehouseBuilder;
import com.hortonworks.spark.sql.hive.llap.HiveWarehouseSession;
...
HiveWarehouseSession session = HiveWarehouseBuilder.session(sparkSession);
HiveWarehouseSessionImpl hive = session.build();
...
hive.setDatabase(db_name);
...
and i get:
User class threw exception: java.lang.NoSuchMethodError: com.hortonworks.spark.sql.hive.llap.HiveWarehouseSessionImpl.sql(Ljava/lang/String;)Lorg/apache/spark/sql/Dataset;


fix(sbb-tag): fix styles

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR fixes an issue reported by Aleksandar from team Lynx, related to both storybook and his aem environment:
Tag elements are not correctly displayed
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

fixed tag element display (background, border, animations)

Browsers
I tested the build on the following browsers:

[x] Firefox Desktop
[x] Chrome Desktop
[ ] Edge Desktop
[x] Safari Desktop
[x] Chrome Mobile
[x] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

The ellipsis seem to be broken

working on it

Codecov Report

Merging #1516 (47821d4) into master (ab917b0) will decrease coverage by 1.62%.
The diff coverage is 62.05%.

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   54.85%   53.22%   -1.63%
==========================================
  Files          49       82      +33
  Lines        1659     3438    +1779
  Branches      406      958     +552
==========================================
+ Hits          910     1830     +920
- Misses        671     1474     +803
- Partials       78      134      +56

Impacted Files
Coverage Δ

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

src/components/sbb-clock/sbb-clock.tsx
0.00% <0.00%> (ø)

src/components/sbb-link/sbb-link.tsx
59.57% <ø> (-31.86%)
:arrow_down:

src/components/sbb-logo/sbb-logo.tsx
0.00% <ø> (ø)

src/components/sbb-menu-action/sbb-menu-action.tsx
61.90% <ø> (ø)

src/components/sbb-menu/sbb-menu.tsx
25.89% <ø> (ø)

...ts/sbb-navigation-action/sbb-navigation-action.tsx
71.42% <ø> (ø)

...onents/sbb-navigation-list/sbb-navigation-list.tsx
84.00% <ø> (ø)

...ts/sbb-navigation-marker/sbb-navigation-marker.tsx
53.19% <ø> (ø)

...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx
30.61% <30.61%> (ø)

... and 65 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pushed fixes for ellipsis + active state + focus outline + minor bug on firefox


Exclude Folder Option

In the case where a theme is using a library (Kirki, TGMPA, etc.) it would be useful to have a text field to enter directories that shouldn't be scanned.
Examples:
/vendor
/TGMPA
/inc/kirki

But libraries must meet the requirements also.

Yes, but for universally accepted libraries like the ones I mentioned, they don’t need to be scanned for each theme.
Assuming they are up to date.

I'd rather have them scanned than give the author an option to skip stuff.
And how do you assume they are up to date without scanning?

The tool is for reviewers as much as authors. As a reviewer I’m checking the library versioning manually anyway.

Currently, vendors and node_modules are excluded. The reasoning is that you may have those folders during development, but they shouldn't (vendors maybe should in some cases) be scanned as they would most certainly crash the sniffer or report on tons and tons of code that may not end up in the theme in the end.
As for kirki and TGMPA we should check them, because you never know what kind of code may be included. Somebody can say: I included TGMPA but puts his/hers own evil code inside...


Lore Metathread

Your clan of ninjas good guys
Enemy clan is bad guys
Enemy clan makes people into zombies

you are 3rd party clan
the big bosses of both clans are in cahoots with the zombie scheme
enemies in the levels are from both clans
Not an insane story just as a way for us to all practice our respective skillsets

After first world u go to study with a master
This will unlock special ability like how mario has the hat in wonderwold
Special abilities may be charged by some type of mana-like system


Video.destroy() doesn't work

Okay, so I have this code
var old_video = page.getViewById("video");
if(old_video !== undefined) {
    old_video.destroy();
}

But when I run it, the video freezes and the controls stop working, but the video won't disappear. BUT! If I run the code a second time, it says Cannot read property 'stopPlayback' of null'. So why is the video not disappearing? Is there something I'm doing wrong??

woops

Been a while since I've worked on this but from memory .destroy() is a method to mainly free resources on the device. It won't remove from the view so you'll need to actually handle that yourself to remove the view from the layout. Hope that helps. I don't think we should add that as part of the plugin either so I don't anticipate that changing at this time 😄 let me know if that makes sense or not.

@bradmartin would view.removeChild() work?

Something like that 😄 if view is the layout with the child possibly. Sorry, in a meeting right now 😢
https://docs.nativescript.org/api-reference/classes/_ui_layouts_layout_.layout.html#removechild

@bradmartin Alright thanks 👍 💯 :)

Something like that smile if view is the layout with the child possibly. Sorry, in a meeting right now cry
https://docs.nativescript.org/api-reference/classes/_ui_layouts_layout_.layout.html#removechild

Hello Brad,
I used removeChild along with video.destroy, it is removing the view correctly for ios but for android the destroy method is not removing the child properly. Could you please help me with this?

@princy05 this is the code I use to destroy the player:
  public destructor() {
    let container = this.page_.getViewById(
      'video-player-container',
    ) as StackLayout;

    let player: Video;

    if (container) player = container.getViewById('video-player') as Video;

    if (player) {
      console.log('player.destroy');
      player.destroy();
      container.removeChild(player);
    }
  }


[SERVICE_STARTUP_FAILED] [wait: http://xxx.xxx.xxx.xxx:xxxxx/ does not respond in 30s]

Hi @vania-pooh
Been racking my brains over this for a bit trying everything i know to solve this.
I have a GGR in Kubernetes that talks to Selenoid that is also in Kubernetes - this seems to work fine (I know the disadvantages of doing it this way over moon :) )
When my Selenoid container attempts to communicate with the browser image, It is not able to.
The image exists in docker ready to be created and Selenoid finds it and starts the container. but i always get
[SERVICE_STARTUP_FAILED] [wait: http://xxx.xxx.xxx.xxx:xxxxx/ does not respond in 30s]
The problem I have is this is quite a cryptic error to me, It looks to me like the docker browser container is trying to communicate back to my Selenoid container on the wrong IP. or there is some communication failure along that trajectory.
Do you have any advice on this problem? is there a setting i should look at to fix this? What is it actually trying to do?
Thanks

@topproto Selenoid has -container-network flag allowing to specify in which network your containers are running.

Thanks for the quick reply, I have tried default, bridge and host, and they did not seem to work for me, do i need to specify the Kubernetes network container?

Also if it helps My cluster is using the Flannel network, although i have not done anything in docker with Flannel, perhaps i need to configure docker to use cbr?

Are you trying to run selenoid in Kubernetes?
пт, 6 дек. 2019 г., 19:17 topproto<EMAIL_ADDRESS>
Also if it helps My cluster is using the Flannel network, although i have
not done anything in docker with Flannel, perhaps i need to configure
docker to use cbr?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/selenoid/issues/845?email_source=notifications&email_token=AAKY23MKUECB6CV6P65BS4TQXJ3JNA5CNFSM4JWWCP42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGESY6Q#issuecomment-562637946,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKY23LJS7J3VTHY43ZLPS3QXJ3JNANCNFSM4JWWCP4Q
.

@aandryashin I have Selenoid running in Kubernetes already (and the GGR), When it creates the browser container it can't communicate back to the Selenoid container in Kubernetes.
Unless there is a way I can create the browser container inside Kubernetes and have Selenoid call it from there.
Its literally the last piece of the puzzle im stuck on :(

We do not support selenoid installation in kubernetes, because it is very
dangerous to grant direct access to kubernetes docker, cluster can become
unstable. Please consider this solution developed for kubernetes:
https://aerokube.com/moon/latest/
пт, 6 дек. 2019 г., 19:22 topproto<EMAIL_ADDRESS>
@aandryashin https://github.com/aandryashin I have Selenoid running in
Kubernetes already (and the GGR), When it creates the browser container it
can't communicate back to the Selenoid container in Kubernetes.
Unless there is a way I can create the browser container inside Kubernetes
and have Selenoid call it from there.
Its literally the last piece of the puzzle im stuck on :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/selenoid/issues/845?email_source=notifications&email_token=AAKY23JCUSIKBYNQ3PAD5RTQXJ33ZA5CNFSM4JWWCP42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGETHLY#issuecomment-562639791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKY23IFFWP5A2P2MGMG5BDQXJ33ZANCNFSM4JWWCP4Q
.

@aandryashin thanks for the reply.
What direct access needs to be granted?
Why would the cluster become unstable?

@topproto described all this stuff in docs: https://aerokube.com/selenoid/latest/#_selenoid_in_kubernetes


Add options for improved render quality

Add options for anti aliasing etc.

With 0.0.1 can now modify the context which is returned by the create-window funciton. A :rendering key can now be attached which is a map that takes the java.awt.RenderingHints as key and value
Example: :rendering {RenderingHints/KEY_ANTIALIASING RenderingHints/VALUE_ANTIALIAS_ON}


mount usb hard drive from Docker Exec?

I would like to an external hard drive from the container itself, not from the host. It would be nice to add an pre script/command to mount the drive and add an post command to umount the drive when the backup is completed. No fstab.
What are the proper steps to get this running?

Not quite sure tbf.
In terms of scripts, it's easy enough to create a script to mount the drive onto the host before the backup, and unmount it after the backup.
You'd then need to script a way to mount it within the docker container.
Is there a particular reason why you want to mount/unmount outside of backups? (eg are you going to be running it on a cron job or manually? If it's manually, then the easiest thing to do would be to have a separate compose.yml).

Fixed


fix issue with background image

There was in issue when using image-lazy-background-image = true and image have a space in it's url. In that case background image was not getting displayed.

Agree, also issue when image src has ' char


[Bug]OlapTableSink.finalize may use a another method name to avoid GC thread execute?

I found that in OlapTableSink.java, there is a function named finalize. In Java, it will be called when GC destory the object, but I found that it will cause OOM. Because if we not define finalize method, the object will be recycle imediatelly, but if we define it, the object will insert into  java.lang.ref.Finalizer.ReferenceQueue, if we have large object in the queue, the fe will down cause by OOM.
https://github.com/apache/incubator-doris/blob/c6ac60bab9563a77b052a2766b0de859528aee41/fe/src/main/java/org/apache/doris/planner/OlapTableSink.java#L121-L137

Good job!


LogParser Creation Error

I'm attempting to create WAF rules using the AWS provided CloudFormation template found here: https://aws.amazon.com/solutions/implementations/aws-waf-security-automations/
I am using the default values (with the exceptions being ALB endpoint and access log bucket name). I am receiving this error:
1 validation error detected: Value 'This function parses access logs to identify suspicious behavior, such as an abnormal amount of errors. It then blocks those IP addresses for a customer-defined period of time. Parameters: 100, 50 and 240. ' at 'description' failed to satisfy constraint: Member must satisfy regular expression pattern: .* (Service: AWSLambdaInternal; Status Code: 400; Error Code: ValidationException;
I have successfully launched the same CloudFormation template in another account last week using the provided AWS defaults. I'm not sure what changed between last week and now. Could you please provide some insight in what I'm doing wrong?

This issue seems to  have been caused by some internal service issue and it should be fixed now. Please try again and let us know if there are any more issues. Thank you!

Everything is working now! Thanks for your help!


[BUG] Calculation of total price is wrong with mixed currencies

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

Describe the bug*
When adding line items with different currencies, the total price calculated in the line items overview does not take into account different currencies per line.
This happens in Purchase and in Sales orders. 10 yen are only about 8 cents - 20 USD is way off the correct value.

These were both created on the demo server. The total cost, calculated at the top of the order, is correct in both cases (10.08 USD)
Steps to Reproduce

Create sales|purchase order
Add line items with different currencies
Check bottom of table summary - find wrong sum

Expected behavior
One could argue that it makes no sense to use different currencies for each line item. I was trying to use this in a sales order to calculate a total cost of an idea, with parts purchased from different vendors, in different countries.
Regardless of which, it is currently possible to do this, and the sum is wrong. Something must be changed. Options:

Make the calculation take into account the currencies, as with the total cost.
Remove the sum from the table - better no info than wrong info, possibly on if different currencies available.
Make it impossible to use different currencies in line items in an order. This would require setting a currency for an order, and sticking to that.

Deployment Method

[X] Docker
[ ] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.10.0 dev
Django Version: 3.2.16
Commit Hash: e730b5c
Commit Date: 2023-01-10
Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Active plugins: False
Relevant log output
No response

@miggland Thanks for the report.
Seems like we will have to disable totals for now as the frontend does not know the rate.

I'm definitely not very good at how the frond-end works. I tried finding where that line is created, but no luck.
Can you point me to the right place, @matmair ?

@miggland I am also not really good with the current thing - although I am currently rebuilding it.

@miggland you can disable the total price column footer of the purchase/sale order tables by commenting out the footer-formatter code:
https://github.com/inventree/InvenTree/blob/e730b5c24ce88b7b3d72d39903815359b5b66fdb/InvenTree/templates/js/translated/order.js#L2373-L2385
https://github.com/inventree/InvenTree/blob/e730b5c24ce88b7b3d72d39903815359b5b66fdb/InvenTree/templates/js/translated/order.js#L2560-L2572
https://github.com/inventree/InvenTree/blob/e730b5c24ce88b7b3d72d39903815359b5b66fdb/InvenTree/templates/js/translated/order.js#L3885-L3897
https://github.com/inventree/InvenTree/blob/e730b5c24ce88b7b3d72d39903815359b5b66fdb/InvenTree/templates/js/translated/order.js#L4377-L4388
At first glance it seems to be doing some currency conversion... but not on individual rows. Will investigate if I can get it working

My recommendation regarding the mixed currency total would be to use the API to get that number.

Good point, better not to recalculate this as it's already done somewhere.

@miggland still looking to see if I'm able to fix it. Tried a few things, but I was to focused on adding data to the order lines. Having read the recommendation of @matmair, and re-thinking my strategy. I'm now thinking on adding two more fields to the api/order/so/ and api/order/po/ endpoints that represent the sub_total for the order lines and the extra lines.
Total price and sub-total prices will then all be shown in the base currency.

Sounds good. Please make a note of the speed of the endpoint before and after the changes, it is pretty simple to introduce slow DB queries unknowingly. The response time should not change much.
HMU if you need any pointers

I've made a draft PR #4245 which is an initial solution to this problem, but it needs further refinement as for some reason the bootstrap table is firing the onPostFooter twice per table. So that's 4 times on page load.
I'm thinking to have the sub total values present in the normal GET call to the template, so I can pass them to the javascript routines without a callback to the API.


Unhandled error in plugin from_transmission

Expected behavior:
Get the list of entries from the transmission.
Actual behavior:
Unhandled error in plugin from_transmission.
Steps to reproduce:

Step 1: Upgrade to 3.1.92
Step 2: Install transmission-rpc
Step 3: Use from_transmission in task

Config:
  TRANS_CLN:
    no_entries_ok: yes
    from_transmission:
      <<: *transmission_settings
      only_complete: yes
    disable: [seen, seen_info_hash, notify]
    if:
      - transmission_progress == 100: accept
      - not transmission_seed_ratio_ok: reject
      - not transmission_idle_limit_ok: reject
    transmission:
      <<: *transmission_settings
      action: remove

Log:

(click to expand)
2020-12-28 14:15:51 CRITICAL task          TRANS_CLN       BUG: Unhandled error in plugin from_transmission: 'Client' object has no attribute 'http_handler'
Traceback (most recent call last):

  File "/usr/lib/python3.6/threading.py", line 884, in _bootstrap
    self._bootstrap_inner()
    │    └ <function Thread._bootstrap_inner at 0xb6838c90>
    └ <Thread(task_queue, stopped daemon -1446013856)>
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
    │    └ <function Thread.run at 0xb6838b70>
    └ <Thread(task_queue, stopped daemon -1446013856)>
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
    │    │        │    │        │    └ {}
    │    │        │    │        └ <Thread(task_queue, stopped daemon -1446013856)>
    │    │        │    └ ()
    │    │        └ <Thread(task_queue, stopped daemon -1446013856)>
    │    └ <bound method TaskQueue.run of <flexget.task_queue.TaskQueue object at 0xb16bfc10>>
    └ <Thread(task_queue, stopped daemon -1446013856)>

  File "/usr/local/lib/python3.6/dist-packages/flexget/task_queue.py", line 46, in run
    self.current_task.execute()
    │    │            └ <function Task.execute at 0xb5490738>
    │    └ <flexget.task.Task object at 0xaecb87f0>
    └ <flexget.task_queue.TaskQueue object at 0xb16bfc10>

  File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 87, in wrapper
    return func(self, *args, **kw)
           │    │      │       └ {}
           │    │      └ ()
           │    └ <flexget.task.Task object at 0xaecb87f0>
           └ <function Task.execute at 0xb54906f0>

  File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 722, in execute
    self._execute()
    │    └ <function Task._execute at 0xb54906a8>
    └ <flexget.task.Task object at 0xaecb87f0>

  File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 688, in _execute
    self.__run_task_phase(phase)
    │                     └ 'input'
    └ <flexget.task.Task object at 0xaecb87f0>

  File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 514, in __run_task_phase
    response = self.__run_plugin(plugin, phase, args)
               │                 │       │      └ (<flexget.task.Task object at 0xaecb87f0>, {'host': '<IP_ADDRESS>', 'port': 9091, 'username': 'tnt', 'password': 'fylhtq1973...
               │                 │       └ 'input'
               │                 └ <PluginInfo(name=from_transmission)>
               └ <flexget.task.Task object at 0xaecb87f0>

> File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 547, in __run_plugin
    result = method(*args, **kwargs)
             │       │       └ {}
             │       └ (<flexget.task.Task object at 0xaecb87f0>, {'host': '<IP_ADDRESS>', 'port': 9091, 'username': 'tnt', 'password': 'fylhtq1973...
             └ <Event(name=plugin.from_transmission.input,func=on_task_input,priority=128)>

  File "/usr/local/lib/python3.6/dist-packages/flexget/event.py", line 20, in __call__
    return self.func(*args, **kwargs)
           │    │     │       └ {}
           │    │     └ (<flexget.task.Task object at 0xaecb87f0>, {'host': '<IP_ADDRESS>', 'port': 9091, 'username': 'tnt', 'password': 'fylhtq1973...
           │    └ <bound method PluginTransmissionInput.on_task_input of <flexget.plugins.clients.transmission.PluginTransmissionInput object a...
           └ <Event(name=plugin.from_transmission.input,func=on_task_input,priority=128)>

  File "/usr/local/lib/python3.6/dist-packages/flexget/plugins/clients/transmission.py", line 186, in on_task_input
    self.client.http_handler.set_authentication(
    │    └ <transmission_rpc.client.Client object at 0xae28ec50>
    └ <flexget.plugins.clients.transmission.PluginTransmissionInput object at 0xb16d38f0>

AttributeError: 'Client' object has no attribute 'http_handler'
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/flexget/task.py", line 547, in __run_plugin
    result = method(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/flexget/event.py", line 20, in __call__
    return self.func(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/flexget/plugins/clients/transmission.py", line 186, in on_task_input
    self.client.http_handler.set_authentication(
AttributeError: 'Client' object has no attribute 'http_handler'

Additional information:

FlexGet version: 3.1.92
Python version: 3.6.9
Installation method: pip
Using daemon (yes/no): yes
OS and version: Armbian Linux 4.19.62-sunxi
Link to crash log: https://cdn.discordapp.com/attachments/536690097496784906/793099343199993886/crash_report.2<IP_ADDRESS>551281798.log

Also I think that the breaking change in https://github.com/Trim21/transmission-rpc/releases/tag/v3.0.0a4 breaks the client plugin transmission in FlexGet.
I had to downgrade FlexGet to 3.1.91 to keep transmission working.
E.g. this does not work in Flexget 3.1.92: https://github.com/Flexget/Flexget/blob/develop/flexget/plugins/clients/transmission.py#L492

👋 I'm seeing the exact same behaviour for my setup.
I run flexget using the docker-flexget container, and opened an issue there for this:
https://github.com/cpoppema/docker-flexget/issues/85
In that issue, the author has written a small patch to simply comment out the offending lines which is working:
--- transmission.py.org
+++ transmission.py
@@ -182,10 +182,10 @@

         # Hack/Workaround for http://flexget.com/ticket/2002
         # TODO: Proper fix
-        if 'username' in config and 'password' in config:
-            self.client.http_handler.set_authentication(
-                self.client.url, config['username'], config['password']
-            )
+#        if 'username' in config and 'password' in config:
+#            self.client.http_handler.set_authentication(
+#                self.client.url, config['username'], config['password']
+#            )

         session = self.client.get_session()

Also I think that the breaking change in https://github.com/Trim21/transmission-rpc/releases/tag/v3.0.0a4 breaks the client plugin transmission in FlexGet.
I had to downgrade FlexGet to 3.1.91 to keep transmission working.
E.g. this does not work in Flexget 3.1.92: https://github.com/Flexget/Flexget/blob/v3.1.92/flexget/plugins/clients/transmission.py#L492

Yep, that'll break things too. We should start requiring >=3.0 and switch to that new interface.

In that issue, the author has written a small patch to simply comment out the offending lines which is working

Looks like the offending code is a workaround that's probably obviated by moving to the new module; should be safe to remove.

In that issue, the author has written a small patch to simply comment out the offending lines which is working

Looks like the offending code is a workaround that's probably obviated by moving to the new module; should be safe to remove.

This issue has been mentioned on Forum - FlexGet. There might be relevant details there:
https://discuss.flexget.com/t/unhandled-error-in-plugin-transmission-list-indices-must-be-integers-or-slices-not-file/5352/4

This issue has been mentioned on Forum - FlexGet. There might be relevant details there:
https://discuss.flexget.com/t/unhandled-error-in-plugin-transmission-list-indices-must-be-integers-or-slices-not-file/5352/4

This issue has been mentioned on Forum - FlexGet. There might be relevant details there:
https://discuss.flexget.com/t/unhandled-error-in-plugin-transmission-list-indices-must-be-integers-or-slices-not-file/5352/4

I think this is related to the "skip_files" and not this issue. I think it is another issue.

This issue has been mentioned on Forum - FlexGet. There might be relevant details there:
https://discuss.flexget.com/t/unhandled-error-in-plugin-transmission-list-indices-must-be-integers-or-slices-not-file/5352/4

I think this is related to the "skip_files" and not this issue. I think it is another issue.

I have exactly the same issue. Flexget daemon is closed each time when I try to use from_transmission plugin.
flexget[694]: 2021-01-08 13:15:07 CRITICAL task          clean-torr      BUG: Unhandled error in plugin from_transmission: 'Client' object has no attribute 'http_handler'
....
flexget[694]: 2021-01-08 13:15:07 CRITICAL task_queue                    BUG: Unhandled exception during task queue run loop.
flexget[694]: Exception in thread task_queue:
flexget[694]: Traceback (most recent call last):
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/task.py", line 547, in __run_plugin
flexget[694]:     result = method(*args, **kwargs)
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/event.py", line 20, in __call__
flexget[694]:     return self.func(*args, **kwargs)
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/plugins/clients/transmission.py", line 198, in on_task_input
flexget[694]:     self.client.http_handler.set_authentication(
flexget[694]: AttributeError: 'Client' object has no attribute 'http_handler'

This makes flexget unusable for me.

I have exactly the same issue. Flexget daemon is closed each time when I try to use from_transmission plugin.
flexget[694]: 2021-01-08 13:15:07 CRITICAL task          clean-torr      BUG: Unhandled error in plugin from_transmission: 'Client' object has no attribute 'http_handler'
....
flexget[694]: 2021-01-08 13:15:07 CRITICAL task_queue                    BUG: Unhandled exception during task queue run loop.
flexget[694]: Exception in thread task_queue:
flexget[694]: Traceback (most recent call last):
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/task.py", line 547, in __run_plugin
flexget[694]:     result = method(*args, **kwargs)
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/event.py", line 20, in __call__
flexget[694]:     return self.func(*args, **kwargs)
flexget[694]:   File "/usr/local/lib/python3.8/dist-packages/flexget/plugins/clients/transmission.py", line 198, in on_task_input
flexget[694]:     self.client.http_handler.set_authentication(
flexget[694]: AttributeError: 'Client' object has no attribute 'http_handler'

This makes flexget unusable for me.

Experiencing the same issue TypeError: list indices must be integers or slices, not File

Experiencing the same issue TypeError: list indices must be integers or slices, not File

Also I think that the breaking change in https://github.com/Trim21/transmission-rpc/releases/tag/v3.0.0a4 breaks the client plugin transmission in FlexGet.
I had to downgrade FlexGet to 3.1.91 to keep transmission working.
E.g. this does not work in Flexget 3.1.92: https://github.com/Flexget/Flexget/blob/v3.1.92/flexget/plugins/clients/transmission.py#L492

Re-opening this, because there were 2 issues here and only one is fixed. The change in the files api still needs to be fixed.

Also I think that the breaking change in https://github.com/Trim21/transmission-rpc/releases/tag/v3.0.0a4 breaks the client plugin transmission in FlexGet.
I had to downgrade FlexGet to 3.1.91 to keep transmission working.
E.g. this does not work in Flexget 3.1.92: https://github.com/Flexget/Flexget/blob/v3.1.92/flexget/plugins/clients/transmission.py#L492

Re-opening this, because there were 2 issues here and only one is fixed. The change in the files api still needs to be fixed.

Oops, that other error is already tracked in #2798. Closing this one again.

Oops, that other error is already tracked in #2798. Closing this one again.


[PDP] add Magento metadata as query parameters instead of headers

https://jira.corp.adobe.com/browse/DATA-6271
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--aem-boilerplate-commerce--hlxsites.aem.live/
After: https://DATA-6271--aem-boilerplate-commerce--hlxsites.aem.live/

Can you please update the PR description with the test URL for a PDP to get the PSI check on it :)

Please look into performance.
I am seeing a difference between the main branch and this branch, ~400ms average increase in TBT.
https://thinktanked.org/tools/deep-psi/deep-psi.html?url1=https%3A%2F%2Fmain--aem-boilerplate-commerce--hlxsites.aem.live%2Fproducts%2Fhollister-backyard-sweatshirt%2FMH05&url2=https%3A%2F%2FDATA-6271--aem-boilerplate-commerce--hlxsites.aem.live%2Fproducts%2Fhollister-backyard-sweatshirt%2FMH05


[DoNotMerge] Update YAMLs to support k8s (kubeadm) v1.24

With Kubernetes 1.24, master nodes are now
labeld and tainted as node-role.kubernetes.io/control-plane
Support this in sriov network operator by:

extending tolerations in relevant yaml files
adjusting node affinity in relevant yaml files
modify helm chart to deploy operator based on node affinity
and not node selector

Signed-off-by: Adrian Chiris<EMAIL_ADDRESS>

/test-all

/test-all

@adrianchiris can you push to merge this?

@adrianchiris please wait I am validating this on OCP running with k8s 1.24


Implement OnFailurePolicy in Propeller

TL;DR
Add support to OnFailurePolicy defined at the Workflow/Subworkflow levels. It defaults to FAIL_IMMEDIATELY keeping current behavior the same.
Type

[ ] Bug Fix
[X] Feature
[ ] Plugin

Are all requirements met?

[X] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
When set to FAIL_AFTER_EXECUTABLE_NODES_COMPLETE, it leads to the workflow continuing to run until all nodes have either succeeded, failed, timedout or skipped.

Tracking Issue
https://github.com/lyft/flyte/issues/191

Or description update

I am thinking its not ready yet right?

Codecov Report

Merging #152 into master will decrease coverage by 0.03%.
The diff coverage is 60.52%.

Ready for review @kumare3

Looks good to me, I think we need to agree that all top level enums will be handled so.


Update MD file on new branch 2017-16-13_14-11-44

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added ability to treat Postgres NUMERIC as double

Looks good to me, but from understandabilty POV it might be better to split it into two commits - the chnage it self and formatting changes - @gunnarmorling, @rhauch WDYT?

Amended commit to discard formatting changes

Hey @ssiahetiong, finally getting to look into this. Sorry for the delay. It looks good overall, thanks a lot.
Could you only file a JIRA issue in our tracker and reword the commit message so it begins with the issue key ("DBZ-xyz Adding ability ..."). And could you also use the e-mail address of your GitHub account for the commit? That way it is properly linked to your user in the history.
Thanks!

Rebased and applied. Also filed DBZ-337 to track it and reworded the commit message to refer to that issue. Thanks, @ssiahetiong!


Fixed braces for paginator skip take in eloquent

I am deleting fork, re forking cleaning up all, and re-submitting the pull request.


gitolite/vagrant installation issues

@david-yz-liu and I were trying to test the instructions for using gitolite and vagrant and came up with the following issues:

the vagrant vm already has a git user with most of gitolite installed, so we first tried to bypass the gitolite install instructions.
there is a git.pub file in the git user home directory that we thought should be named vagrant.pub
the .gitolite/keydir already had some directories in it
config environments files did not have a matching pair of paths for the public private keys.  The private key should have been /home/git/vagrant.pub
the MarkUs git_repository code hard-code the 'git' user for adding permissions.  (We had to change it to 'vagrant' to get it to work.)  This really should be a configurable parameter.

@oneohtrix I think we need to delete the 'git' user and recreate it but stop just after cloning the gitolite repo.  (@david-yz-liu and I had a really hard time trying to back out and redo steps because it was too hard to figure out all the different files that were getting modified by each step.)

hmm, okay. I'll take another stab at this. what are the steps I can perform to verify that gitolite works 100%?

Really all we'd like to see is the Vagrant machine going up to step #9 in the wiki under "install Gitolite".
You don't need to make sure gitolite "works" at that point (it won't), but the rest of the installation should work after it.
In fact, proceeding with the installation and setup will create new directories that we don't want to see in the virtual machine.

Thanks @oneohtrix!  You can save, or make a copy of the the vm at this point, and then continue with the installation instructions to make sure that they work.

Okay, I updated the box again with the recreated git user and vagrant.pub key. Hopefully it works this time. Please test it out and let me know if there are any issues -- I tested up until I saw the hello vagrant message.

@reidka Can you test this some time soon? I've also merged master into the git branch, so you can try on the newest version. Thanks!

And thanks @oneohtrix!

@oneohtrix and @david-yz-liu it is better, but I'm still getting the
Rugged::NetworkError: Early EOF
And when I 'ssh -T git@localhost'  I get
hello vagrant, this is git@vagrant-ubuntu-trusty-64 running gitolite3 v3.6.3-10-g4be7ac5 on git 1.9.1
R W    testing
Without the R W gitolite-admin
I'll try to look into this more, but I have to get something else done today.

@oneohtrix I was able to get the gitolite-admin to work by deleting
.gitolite
.gitolite.rc
repositories
.ssh
Do we need git.pub ?  It was the same as the vagrant public key until I created a new one, so my guess is that we don't.

@reidka I don't think those files should be in the new vagrant box..I'm quite certain the keys are set up properly and all that needs to be done is to mkdir bin and install gitolite under git.
However, I have been trying to get Markus set up with git, and I get the following error every time I perform rake db:setup (per the instructions in the wiki):
Grit::InvalidGitRepositoryError: /home/vagrant/Markus/data/dev/repos/conf
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/grit-2.5.0/lib/grit/repo.rb:51:in `initialize'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/gitolite-1.1.0/lib/gitolite/gitolite_admin.rb:16:in `new'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/gitolite-1.1.0/lib/gitolite/gitolite_admin.rb:16:in `initialize'

-- you mentioned that the git_repository code hard-coded the git user, is this related to that?
cc @david-yz-liu, @SoftwareDev, roping you in since you know how the git library code works.

@oneohtrix Okay, maybe the wrong vagrant box version was used.
You probably need to delete everything in the data/dev/repos folder before doing the setup.

Hi @reidka and @david-yz-liu, sorry for dawdling. I took another stab at the Vagrant box with git today. I managed to get MarkUs into a semi-working state with git. I don't think the problems I encountered were related to the Vagrant build, though. Here are the steps I did, starting from a totally clean box:
vagrant up (make sure box is on version 1.2; check using vagrant box list)
vagrant ssh (password is vagrant)
su git (password is also vagrant)
cd into git home directory
mkdir bin
gitolite/install -ln
export PATH="~/bin:$PATH"
gitolite setup -pk vagrant.pub
exit
cd into vagrant home directory
eval $(ssh-agent -s)
ssh-add ~/.ssh/id_rsa
ssh -T git@localhost (ensure we get 'hello' message)
git config --global user.name "Lawrence Wu"
git config --global user.email<EMAIL_ADDRESS>git clone https://github.com/MarkUsProject/Markus.git
cd Markus
edit config/environments/development.rb to change REPOSITORY_TYPE from svn to git
bundle install
cp ~/database.yml config
mkdir data/dev/repos
bundle exec rake db:setup
...wait a really long time
At this point, I received the following error:
No revision found before supplied timestamp.
/home/vagrant/Markus/lib/repo/git_repository.rb:335:in `get_revision_by_timestamp'
/home/vagrant/Markus/app/models/submission.rb:23:in `create_by_timestamp'
/home/vagrant/Markus/lib/tasks/marks.rake:20:in `block (3 levels) in <top (required)>'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activerecord-4.2.3/lib/active_record/relation/delegation.rb:46:in `each'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activerecord-4.2.3/lib/active_record/relation/delegation.rb:46:in `each'
/home/vagrant/Markus/lib/tasks/marks.rake:18:in `block (2 levels) in <top (required)>'
/home/vagrant/Markus/db/seeds.rb:7:in `<top (required)>'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activesupport-4.2.3/lib/active_support/dependencies.rb:268:in `load'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activesupport-4.2.3/lib/active_support/dependencies.rb:268:in `block in load'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activesupport-4.2.3/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activesupport-4.2.3/lib/active_support/dependencies.rb:268:in `load'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/railties-4.2.3/lib/rails/engine.rb:547:in `load_seed'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activerecord-4.2.3/lib/active_record/tasks/database_tasks.rb:250:in `load_seed'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/gems/activerecord-4.2.3/lib/active_record/railties/databases.rake:180:in `block (2 levels) in <top (required)>'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/bin/ruby_executable_hooks:15:in `eval'
/home/vagrant/.rvm/gems/ruby-2.1.3@markus/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => db:marks

The folders and files in data/dev/repos looked alright though, so I started up the rails server and looked around in the submissions for A1. When trying to access the repo view for a submission, I received the following stack trace:
undefined method `__get_files' for #<Repository::GitRevision:0x000000083e2be8>
lib/repo/git_repository.rb:1111:in `files_at_path_helper'
lib/repo/git_repository.rb:1097:in `changed_files_at_path'
app/controllers/submissions_controller.rb:87:in `block in repo_browser'
app/controllers/submissions_controller.rb:78:in `times'
app/controllers/submissions_controller.rb:78:in `each'
app/controllers/submissions_controller.rb:78:in `repo_browser'

As I said, these look like programming errors instead of environment issues. Could someone confirm? If so, I'd like to close this issue since I believe the vagrant box is correctly set up.

@oneohtrix Thanks, you're correct that these are issues with the software and not the vagrant machine. I'll close the issue after we get someone to download the new vagrant box.

@oneohtrix Good to go.


pythia: 8.304 -> 8.305

Motivation for this change
A bugfix release
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121629 at 5a57d961 run on x86_64-linux 1

2 packages built successfully:

pythia
sacrifice

1 suggestion:

warning: build-tools-in-build-inputs
rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/libraries/physics/pythia/default.nix:12:3:
   |
12 |   buildInputs = [ boost fastjet hepmc zlib rsync lhapdf ];
   |   ^


SEO improvement

Hi, I think we can remove or have a way to ignore the information about how many movies we have in the movies index to test Meilisearch :)
below you can see right after the description, we have a value 15880.

Hello @brunoocasali 👋
Thanks a lot for your issue. Unfortunately, I cannot change this as Google decides what appear in its search result.
As you can see in the landing source code (view-source:https://www.meilisearch.com/):

we already provide a meta description we would like to be displayed, but Google can decide to use it, or ignore it and put what he thinks is more appropriate.
In our case, he decides to use the text from the Interactive Search block + the number of movies on the left:

We cannot do much about it but hope that Google will update it by himself 🤷♀ I will therefore close this issue, but don't hesitate to open other issues if you find anything that doesn't seems fine to you 😀


Fix sending too many catch up requests

When KAGOME node sends too many catch up requests our reputation is decreased and no one sends us commit messages which leads to lag in block finalization. Need to restrict sending too many catch up requests

Also fix that we are receiving commits but do not apply them


[PE-D][Tester F] Entering an invalid gender for a pilot elicits no response from the program.

Steps:

In pilot mode, enter e.g. add /n pname /r 1 /a 1 /g 4 /fh 1

Actual:
The program provides no response.
Expected:
An error message explaining the invalid gender should be written to screen.

Labels: severity.Low type.FunctionalityBug
original: jefrai/ped#5

Added input value check for gender and pilot rank.


Fix outbound cold transfer when using dual-channel-recording

Summary
The custom-transfer-directory feature's cold transfer functionality needs a call SID to initiate the transfer for. Previously this used the call_sid attribute, as this should always be the customer call SID, however due to an issue in the dual-channel-recording feature, this is not currently the case when recording the worker leg and placing an outbound call.
We will fix dual-channel-recording separately, but this is a quick fix to use the known-good SID first.
Checklist

[x] Tested changes end to end
[x] Requested one or more reviewers

LGTM as a workaround.
Looks like the root cause is likely just an oversight that worker leg can be recorded