Close picker if clicked outside

:+1:
Before merging, there are two things to fix:

let's make an option for it, maybe some of the users don't want to close the popup when clicking outside
check if the event target is child of the popup (currently if you click the gray area, between color circles, it will close it)

Nice work, thanks! :sparkles:

Done.

check if the event target is child of the popup
I've gone the other way: I'm checking we are not clicking color picker element in addition to open element. This allows color picker and open element to have different parents

@troggy Amazing! :sparkles:

@troggy Thanks once again. Landed in 1.2.0. :ship: :tada:


should contain clk if it is a clock.

https://github.com/black-parrot/pre-alpha-release/blob/ec0b7b04d4e78d7bf6b83a2b28e7db690451f315/bp_top/src/v/bp_clint.v#L27

rtc_clk_i?

Yep.
On Tue, May 28, 2019 at 7:41 PM Dan Petrisko<EMAIL_ADDRESS>wrote:

rtc_clk_i?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/pre-alpha-release/issues/191?email_source=notifications&email_token=AEFG5AEK2BY26SOV34O46S3PXXUNRA5CNFSM4HQIR4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWN7UYA#issuecomment-496761440,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEFG5ACYP3LAIIZYKFLQCXDPXXUNRANCNFSM4HQIR4SQ
.

Folding into #193


added ResizeBilinearKernel_faster

ResizeBilinearKernel_faster is 30 ~ 50% faster than ResizeBilinearKernel. It eliminates redundant computation by only spawning at most 8 threads to iterate through the channel dimension and having each thread iterate through the batch dimension.
prerequisite is:

channels must be a multiple of 4
sizeof(T) == sizeof(float)

When the prerequisite is not met, ResizeBilinearKernel is used.

@chsigg
PR of optimized bilinear kernel code we have been discussing.
Here are some results comparing ResizeBilinearKernel_faster (my_kernel) to ResizeBilinearKernel` (tf_kernel):
batch = 2
channel = 128
input_height = 256
input_width = 256
height_scale = 0.25
width_scale = 0.25
tf_kernel_time = 7268ms
my_kernel_time = 5705ms
————————————
batch = 2
channel = 128
input_height = 128
input_width = 128
height_scale = 0.125
width_scale = 0.125
tf_kernel_time = 14090ms
my_kernel_time = 9561ms
————————————
batch = 2
channel = 128
input_height = 64
input_width = 64
height_scale = 0.0625
width_scale = 0.0625
tf_kernel_time = 14450ms
my_kernel_time = 9851ms
————————————
batch = 1
channel = 64
input_height = 512
input_width = 512
height_scale = 0.5
width_scale = 0.5
tf_kernel_time = 3705ms
my_kernel_time = 2944ms

batch = 10
channel = 64
input_height = 256
input_width = 256
height_scale = 0.5
width_scale = 0.5
tf_kernel_time = 9377ms
my_kernel_time = 6963ms

batch = 25
channel = 64
input_height = 256
input_width = 256
height_scale = 0.5
width_scale = 0.5
tf_kernel_time = 26112ms
my_kernel_time = 17152ms

batch = 100
channel = 64
input_height = 128
input_width = 128
height_scale = 0.5
width_scale = 0.5
tf_kernel_time = 27441ms
my_kernel_time = 15623ms

batch = 800
channel = 32
input_height = 32
input_width = 32
height_scale = 0.5
width_scale = 0.5
tf_kernel_time = 5896ms
my_kernel_time = 4694ms

@ThisIsIsaac could you please resolve the conflicts? Thanks!

@gbaned
thanks for the notification. Done!

@chsigg
Sorry for the delay. I am going to make one more pull request on another kernel optimization and get to this asap. Will be able to adjust for all the feedback by this Friday.
Thanks

@chsigg
After changing to float4, the performance boost is as follows:

GTX 1080: ~300%
V100: ~450%

I am having a difficult time building tensorflow code from source which is delaying the updates you have suggested. ( I am able to test the CUDA kernels separately because I do not need Tensorflow to test and develop, but the code that launches the CUDA kernels from Tensorflow requires building Tensorflow in order to test. ) will commit new code as soon as i am able to build Tenosrflow form source.

Sorry for the terribly long delay. I will work on doing a final review and getting it merged. For this I will have to mark this PR as 'ready to pull' (internal tools requirement).

@chsigg  oh wait! The implementation is not complete. I have yet to change some crucial parts. Please don't merge yet.

I patched your PR and started making some minor changes. I also noticed that we weren't testing the GPU path, so first I need to fix that.

Thanks. Make sure to replace ‘four_floats’ to ‘float4’

I've merged your code with some changes but somehow GitHub does not mark it merged. Could you please take a look to make sure I didn't make any mistakes and close this PR if you are happy?
Thanks a lot for you contribution!

@chsigg
Thanks so much for your help. I see that you haven't renamed the kernel to ResizeBilinearKernelUnrolled. It is perfectly fine for me either ways.
The code looks fine but I will run a few of my own tests before I confirm. I'll get back to you early next week.
Thanks again for this great opportunity to contribute! Really look forward to further contributions.


[1.12] Plant gatherer gathers leaves much outsider than its working radius

**Industrial Foregoing Version: **
1.12.13
**TeslaCoreLib Version: **
1.0.15
**Crashlog If Applicable (Upload to pastebin/gist): **
It's a bug in functionality, as I'm living in Biomes O Plenty's coniferous forest, there are plenty of fir wood and I'm using a plant gatherer to make a small tree farm for myself.
But the machine only gathers leaves and after almost half an hour, I found my surrounding turned into this:

Is there any solution? Or I will have to use TE's tree planter instead...

Then all the leaves was cut off, and it finally harvested all the logs, which make the wood became even more ugly...

What happened?

Right now, it seems that the only solution is to isolate this machine and its working area from the surroundings...

We have the same issue on my official TownCraft server-
industrialforegoing-1.12.2-1.12.13-237
This was in a roofed forrest with dark oak.

I've had this too. Seem like the algorithm that looks for connected leaves needs to be a little less fuzzy in it's logic and maybe have a max range beyond it's harvest range it will check. Enough to pick up the leaves from say a large oak or a 2x2 jungle tree, but not try and clear a whole forest.

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.

OH NO :(


How to deal with fatal: bad object HEAD in git

category: note
slug: solve-git-bad-object-head
as a cheapo who uses Apple iCloud (the world's worst sync service) as a sync service for my Obsidian Second Brain, I have recently run into this issue a lot:
$ git status
fatal: bad object HEAD
$ git log
fatal: bad object refs/heads/main

I've had to fix this a few times, and only recently worked it out with ChatGPT. Saving here for posterity:
$ git fetch origin
$ git reset --hard origin/main

This may show you some bad objects:
remote: Enumerating objects: 3899, done.
remote: Counting objects: 100% (888/888), done.
remote: Compressing objects: 100% (364/364), done.
remote: Total 3899 (delta 554), reused 597 (delta 523), pack-reused 3011
Receiving objects: 100% (3899/3899), 1.32 MiB | 9.92 MiB/s, done.
error: corrupt loose object 'dc3711cb3ba71eefe40c8e49cc9c9fb311d29553'
fatal: loose object dc3711cb3ba71eefe40c8e49cc9c9fb311d29553 (stored in .git/objects/dc/3711cb3ba71eefe40c8e49cc9c9fb311d29553) is corrupt
fatal: fetch-pack: invalid index-pack output
fatal: Could not parse object 'origin/main'.

So the fix is this:
rm -f .git/objects/dc/3711cb3ba71eefe40c8e49cc9c9fb311d29553
git fetch origin

(July 31 update) corrupt loose object
I also had this issue today:
$ git fsck

error: corrupt loose object '25726bffc0e97532098679d0ed04095710452d29'
error: unable to unpack contents of .git/objects/25/726bffc0e97532098679d0ed04095710452d29
error: 25726bffc0e97532098679d0ed04095710452d29: object corrupt or missing: .git/objects/25/726bffc0e97532098679d0ed04095710452d29
error: corrupt loose object '5b4e2ac94c33715545674545e501a705ea20924b'
error: unable to unpack contents of .git/objects/5b/4e2ac94c33715545674545e501a705ea20924b
error: 5b4e2ac94c33715545674545e501a705ea20924b: object corrupt or missing: .git/objects/5b/4e2ac94c33715545674545e501a705ea20924b
error: corrupt loose object 'ad7ceee5b187af409cbd2219bc4b578faf425471'
error: unable to unpack contents of .git/objects/ad/7ceee5b187af409cbd2219bc4b578faf425471
error: ad7ceee5b187af409cbd2219bc4b578faf425471: object corrupt or missing: .git/objects/ad/7ceee5b187af409cbd2219bc4b578faf425471
error: corrupt loose object 'fdacf1b391398e4548fa3a9f09b0f6714881907c'
error: unable to unpack contents of .git/objects/fd/acf1b391398e4548fa3a9f09b0f6714881907c
error: fdacf1b391398e4548fa3a9f09b0f6714881907c: object corrupt or missing: .git/objects/fd/acf1b391398e4548fa3a9f09b0f6714881907c
Checking object directories: 100% (256/256), done.
Checking objects: 100% (27396/27396), done.
missing blob 60e0633917e44a958f890039cff7297f99d8e8eb
dangling commit d885e9e214a1f84ce5feb8fdcdf51a27249e689e
dangling commit a38bc134bc0ec9741e7abbfa8ee200a0c82253d6
missing blob fdacf1b391398e4548fa3a9f09b0f6714881907c
missing blob 5b4e2ac94c33715545674545e501a705ea20924b
missing blob 25726bffc0e97532098679d0ed04095710452d29
missing blob f2f68aa9deda03f256574d468395e840144d9d05
missing blob ad7ceee5b187af409cbd2219bc4b578faf425471

i got a lot of recommendations with exotic options but ultimately the fix was this
git reset <last good remote commit> # NOT hard!
git stash # to store stuff that has been changed since last good remote commit
git fetch origin # pull down everything since last commit
git stash pop # put back the new stuff
git add . && git commit -m "add back new stuff" # new stuff
git push origin main # done!

Oh wow! I also recently wrote about the same issue with Obsidian on iCloud: https://architchandra.com/articles/a-side-effect-of-storing-a-git-repository-in-icloud-drive. 🙌🏽
Really like how you've tackled everything through the command line. I hope it would be okay if I try some of your learnings and incorporate them into my article later. Thanks!
I love your content, btw. You're an inspiration. :)

you're welcome! thanks for the nice note!

@robrecord - You're absolutely right, but this is for when we still want to do it 😅. Storing Git repos in cloud-sync services should ideally be avoided, but it might still be the best bet for some people who don't want to pay extra for using Git features on mobile devices (eg. you need to install paid apps to do anything meaningful on iOS).
Just talking about Obsidian, I've been using iCloud Drive to keep notes in sync on my desktop and phone for quite a while now without much of a hassle, esp. since I removed the workspace.json file from version control.

@robrecord I personally store my code on both Synology Drive and GitHub because I like having an extra backup outside of a Git system, and it’s convenient to sync it automatically between devices.


Replace membership_id with user's id

Description
The membership APIs for teams still use the GUIDs that were used as the V1 IDs for users to associate users with a team. In v2, they are called membership_ids. A migration is required to replace the GUID use in the user_team_assocation table with user IDs. We also need to update association APIs to use the normal IDs, including their use in the UI. We can then drop the membership_id field (or deprecate it and return the normal ID in that field for now for backwards compatibility).
Acceptance Criteria

[ ]  Migrate user_team_assocation table to replace v1 user GUIDS with v2 user IDs. We'll need to list all users to map the GUIDs to IDs. We should drop any GUID that doesn't map to an ID.
[ ] Update APIs, validation, and docs around team user association APIs as needed.
[ ] Update the UI to use the ID as the input to the team user association APIs (remove VersionizeTeam helpers, etc).
[ ] Drop the membership_id field from the user APIs or deprecate it and return the normal ID if we are uncomfortable removing it.

this work has been deprioritized.


search highlight on strings illegible

Hi,
The same configuration as previous issue without cursorline set:
I am using neovim with colorscheme nord (installed separately in colors/ folder), I removed all plugins and personal configuration.
During the search for a text between quotes, the highlighting color is incorrect (right)
Once I validate my search, the behavior is correct (left)
incsearch is activated by default

Thanks.

Thanks for your report :+1:
Sorry for the late reply, I've been busy with my job.
I've pushed a fix for it.
BeforeAfter
@syedelec @dylnmc You can check out :seedling: bugfix/gh-32-search-highlight-on-strings-illegible to test the changes.

Folds still are not visible for me. Is that how they are supposed to look.

Thanks for fixing the highlight on strings.

@dylnmc I've posted some information about the low contrast comment design in #36 .
The fold marker are indeed not optimal, I'll adjust them to match the comment color.

The fix works on my neovim configuration, Thank you !


Bug in zookeerper kerberos auth

##kerberos  Auth should be passed
Auth Failed
Snippet to Reproduce the Problem
client = KazooClient("<IP_ADDRESS>:24000,<IP_ADDRESS>:24000", sasl_options={"mechanism": "GSSAPI", "service":"zookeeper"})
client.start()

Logs with logging in DEBUG mode
AUTH_FAILED closing: Unknown error: (('Unspecified GSS failure.  Minor code may provide more information', 851968), ('Clock skew too great', -1765328347))
Specifications

Kazoo version: 2.8.0
Python version: 3.6
Zookeeper version:
OS: Centos7

Steps:
1. login kerberos with kinit -kt keytab_file principle
2. check kerberos auth status with klist, its ok
3. run the scripts above
The root cause I found is that:
The service send to kerberos is<EMAIL_ADDRESS>(pure_sasl-0.6.2-py3.6.egg/puresasl/mechanisms.py):
class GSSAPIMechanism(Mechanism):
    name = 'GSSAPI'
    score = 100
    qops = QOP.all

    allows_anonymous = False
    uses_plaintext = False
    active_safe = True

    def __init__(self, sasl, principal=None, **props):
        Mechanism.__init__(self, sasl)
        self.user = None
        self._have_negotiated_details = False
        self.host = self.sasl.host
        self.service = self.sasl.service
        self.principal = principal
        self._fetch_properties('host', 'service')

        krb_service = '@'.join((self.service, self.host))         ##self.host here should be hostname rather than host ip

Actually, the correct krb_service should be "zookeeper/hostName@Realm" or<EMAIL_ADDRESS>for example,
<EMAIL_ADDRESS>KazooClient should take serverFQDN as the input and propagate to puresasl.
serverFQDN - the fully qualified domain name of the server (e.g. “serverhost.example.com”).

Workaround:

Input service as "zookeeper@serverFQDN"
Change the code:

class GSSAPIMechanism(Mechanism):
    name = 'GSSAPI'
    score = 100
    qops = QOP.all

    allows_anonymous = False
    uses_plaintext = False
    active_safe = True

    def __init__(self, sasl, principal=None, **props):
        Mechanism.__init__(self, sasl)
        self.user = None
        self._have_negotiated_details = False
        self.host = self.sasl.host
        self.service = self.sasl.service
        self.principal = principal
        self._fetch_properties('host', 'service')

        krb_service = '@'.join((self.service, self.host))         ##self.host here should be hostname rather than host ip

Workaround:

Input service as "zookeeper@serverFQDN"
Change the code:

class GSSAPIMechanism(Mechanism):
    name = 'GSSAPI'
    score = 100
    qops = QOP.all

    allows_anonymous = False
    uses_plaintext = False
    active_safe = True

    def __init__(self, sasl, principal=None, **props):
        Mechanism.__init__(self, sasl)
        self.user = None
        self._have_negotiated_details = False
        self.host = self.sasl.host
        self.service = self.sasl.service
        self.principal = principal
        self._fetch_properties('host', 'service')

        krb_service = '@'.join((self.service, self.host))         ##self.host here should be hostname rather than host ip

Clock skew is too great looks like a time synchronization error, not a bad
principal issue. Could you double check that this is the actual error you
get from the SASL/Kerberos libraries?
Separately, to help us reproduce this issue, could you please detail the
exact configuration of your setup?

Client / sever respective hostnames and IP
Kerberos principals as returned by klist on both client and server
Zk server Jaas config, if possible

Cheers,
On Thu, Jan 21, 2021, 22:37 tianchao-haohan<EMAIL_ADDRESS>wrote:

Workaround:

Input service as "zookeeper@serverFQDN"
Change the code:

class GSSAPIMechanism(Mechanism):
name = 'GSSAPI'
score = 100
qops = QOP.all
allows_anonymous = False
uses_plaintext = False
active_safe = True

def __init__(self, sasl, principal=None, **props):
    Mechanism.__init__(self, sasl)
    self.user = None
    self._have_negotiated_details = False
    self.host = self.sasl.host
    self.service = self.sasl.service
    self.principal = principal
    self._fetch_properties('host', 'service')

    krb_service = '@'.join((self.service, self.host))         ##self.host here should be hostname rather than host ip

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/python-zk/kazoo/issues/636#issuecomment-765098707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFTHRBGNDVLZI724FP2M3S3DXH3ANCNFSM4WL3RDRA
.

Clock skew is too great looks like a time synchronization error, not a bad
principal issue. Could you double check that this is the actual error you
get from the SASL/Kerberos libraries?
Separately, to help us reproduce this issue, could you please detail the
exact configuration of your setup?

Client / sever respective hostnames and IP
Kerberos principals as returned by klist on both client and server
Zk server Jaas config, if possible

Cheers,
On Thu, Jan 21, 2021, 22:37 tianchao-haohan<EMAIL_ADDRESS>wrote:

Workaround:

Input service as "zookeeper@serverFQDN"
Change the code:

class GSSAPIMechanism(Mechanism):
name = 'GSSAPI'
score = 100
qops = QOP.all
allows_anonymous = False
uses_plaintext = False
active_safe = True

def __init__(self, sasl, principal=None, **props):
    Mechanism.__init__(self, sasl)
    self.user = None
    self._have_negotiated_details = False
    self.host = self.sasl.host
    self.service = self.sasl.service
    self.principal = principal
    self._fetch_properties('host', 'service')

    krb_service = '@'.join((self.service, self.host))         ##self.host here should be hostname rather than host ip

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/python-zk/kazoo/issues/636#issuecomment-765098707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFTHRBGNDVLZI724FP2M3S3DXH3ANCNFSM4WL3RDRA
.

Clock skew is too great looks like a time synchronization error, not a bad principal issue. Could you double check that this is the actual error you get from the SASL/Kerberos libraries? Separately, to help us reproduce this issue, could you please detail the exact configuration of your setup? * Client / sever respective hostnames and IP * Kerberos principals as returned by klist on both client and server * Zk server Jaas config, if possible Cheers,
…
On Thu, Jan 21, 2021, 22:37 tianchao-haohan @.***> wrote: Workaround: 1. Input service as @.***FQDN" 2. Change the code: class GSSAPIMechanism(Mechanism): name = 'GSSAPI' score = 100 qops = QOP.all allows_anonymous = False uses_plaintext = False active_safe = True def init(self, sasl, principal=None, **props): Mechanism.init(self, sasl) self.user = None self._have_negotiated_details = False self.host = self.sasl.host self.service = self.sasl.service self.principal = principal self._fetch_properties('host', 'service') krb_service = '@'.join((self.service, self.host)) ##self.host here should be hostname rather than host ip — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#636 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHRBGNDVLZI724FP2M3S3DXH3ANCNFSM4WL3RDRA .

Clock skew is too great looks like a time synchronization error, not a bad principal issue. Could you double check that this is the actual error you get from the SASL/Kerberos libraries? Separately, to help us reproduce this issue, could you please detail the exact configuration of your setup? * Client / sever respective hostnames and IP * Kerberos principals as returned by klist on both client and server * Zk server Jaas config, if possible Cheers,
…
On Thu, Jan 21, 2021, 22:37 tianchao-haohan @.***> wrote: Workaround: 1. Input service as @.***FQDN" 2. Change the code: class GSSAPIMechanism(Mechanism): name = 'GSSAPI' score = 100 qops = QOP.all allows_anonymous = False uses_plaintext = False active_safe = True def init(self, sasl, principal=None, **props): Mechanism.init(self, sasl) self.user = None self._have_negotiated_details = False self.host = self.sasl.host self.service = self.sasl.service self.principal = principal self._fetch_properties('host', 'service') krb_service = '@'.join((self.service, self.host)) ##self.host here should be hostname rather than host ip — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#636 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIFTHRBGNDVLZI724FP2M3S3DXH3ANCNFSM4WL3RDRA .

Client / sever respective hostnames and IP

client hostname: localhost.localdomain,
client ip: <IP_ADDRESS>
server hostname: hw-ker-node1
server ip: <IP_ADDRESS>

Kerberos principals as returned by klist on both client and server

client:

[c4dev@localhost ~]$ klist
Ticket cache: KEYRING:persistent:1000:1000
Default principal<EMAIL_ADDRESS>
Valid starting       Expires              Service principal
01/25/2021 14:33:42  01/26/2021 14:33:23<EMAIL_ADDRESS>    renew until 01/25/2021 15:03:42

server: empty

Zk server Jaas config, if possible

Client {
com.sun.security.auth.module.Krb5LoginModule required
useKeyTab=false
useTicketCache=true
debug=false;
};

Client / sever respective hostnames and IP

client hostname: localhost.localdomain,
client ip: <IP_ADDRESS>
server hostname: hw-ker-node1
server ip: <IP_ADDRESS>

Kerberos principals as returned by klist on both client and server

client:

[c4dev@localhost ~]$ klist
Ticket cache: KEYRING:persistent:1000:1000
Default principal<EMAIL_ADDRESS>
Valid starting       Expires              Service principal
01/25/2021 14:33:42  01/26/2021 14:33:23<EMAIL_ADDRESS>    renew until 01/25/2021 15:03:42

server: empty

Zk server Jaas config, if possible

Client {
com.sun.security.auth.module.Krb5LoginModule required
useKeyTab=false
useTicketCache=true
debug=false;
};

@ceache hi, is there any update on this issue?

There are a number of issues or at least confusing points of data about
your setup.
So I am going to go about how things should look like.
First it seems your client's Kerberos environment is set up properly:
<EMAIL_ADDRESS>There are, however, a couple of issues with the information you gave me
about the server.

server hostname: hw-ker-node1

server ip: <IP_ADDRESS>

Zk server Jaas config, if possibleClient {
com.sun.security.auth.module.Krb5LoginModule required
useKeyTab=false
useTicketCache=true
debug=false;
};

So, first, your server(s) should all have a keytab for zookeeper/$
<EMAIL_ADDRESS>. you can change the service from "zookeeper" to
whatever you want but you must then use the service="yourservice" parameter
in the sasl_options.
It could also be in a separate Kerberos realm, but X-realm setup are beyond
the scope of this issue.
Once you have the keytab at hand, you need a "Server" section in the
Zookeeper server JAAS config. The "Client" section only pertains to the
Java Zookeeper client, here you need to configure the Server component.
Below is based on what we use in our integration suite:
Server {

com.sun.security.auth.module.Krb5LoginModule required
debug=true
isInitiator=false
useKeyTab=true
keyTab="/path/to/the/above/keytab/file"
storeKey=true
useTicketCache=false
<EMAIL_ADDRESS>};

Once Zookeeper is setup with this file, you should be able to connect from
Kazoo, simply by passing hosts=[hostname],
sasl_options={"mechanism"="GSSAPI, service="zookeeper"} to KazooClient.
As for your point about using hostname instead of host IP, this is actually
the recommended way to connect to a Kerberized service. Kazoo will pass the
hostname if it was provided.
That being said, SASL and Kerberos do not really care, as long as your
server has that principal in its keytab  (e.g<EMAIL_ADDRESS>").
I hope this helps.
--
Charles-Henri de Boysson


Deploying nodejs app

I'm trying to use heroku-maven-plugin to deploy a nodejs app and I'm getting error when I try to set the buildpack to heroku/nodejs.
[INFO] -----> Deploying...
[INFO] remote:
[INFO] remote:  !     error fetching custom buildpack
[INFO] remote:
[INFO] remote:  !     Push failed

In the configuration section I added:
<buildpacks>
  <buildpack>heroku/nodejs</buildpack>
</buildpacks>

shouldn't it work ? I've tried to leave it unset and add the build back using the web admin pages but it doesn't seems to have any effect since node is not available on runtime.
The app includes a package.json file in the root to validate the buildpack.

What version of heroku-maven-plugin are you using?

Yea, I guess it doesn't support the shorthand (I expected it too). In any case, you can use:
<buildpacks>
  <buildpack>https://github.com/heroku/heroku-buildpack-nodejs</buildpack>
</buildpacks>

Also be aware that if you want the Node.js buildpack to run against your package.json and JS files, you'll need to include them in the configuration with the <includes> element.

Worked like a charm....
Thanks !


make it work for helmfiles

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dmitriy Rozentsvay seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Prioritize ingredients from inventory over of kitchen storage

From CurseForge:

I have a suggestion for this mod! I'll use an example to explain it. I have Pam's HarvestCraft, so let's say I'm trying to make a Hamburger. I need to make Toast, and I do already have Flour, Dough, Bread, and Butter in a cabinet, but I kind of want to make the Toast from scratch, both because I feel like it and so I won't waste ingredients for the next time when I may not feel like making it from scratch. So, I go to my Cooking Table to make Flour. But then, when I make Dough from it, instead of using the Flour I just made in my inventory, it uses the Flour that's in the cabinet. Same goes for when I make Heavy Cream for the Butter and use Dough to make Bread, then Bread and Butter to make Toast.
It's not that big of a deal, but it is rather annoying, especially if the ingredients are stored in different cabinets. So, I was thinking, maybe you could make it so that it prioritizes ingredients in your inventory, searching your inventory to find them before checking in the cabinets.

That might be a configuration option - perhaps a toggle switch visible in the GUI for the kitchen crafting table!
Toast is actually a good example in another way, as the toaster allows you to make toast, and then you end up with the toast in your inventory. Everything you pull out of the stove of course also goes into your inventory. Lacking a button to automatically unpack my groceries (which I want in real life thank you very much) I'd prefer it to pull from my inventory by priority...
but I think the toggle switch is the best compromise

I agree, having a bunch of ingredients dumped to my inventory is kind of a pain! I'd love to see an option to prefer ingredients from my inventory when cooking.


Argument in client constructor overrides http endpoint

Expected Behavior
The http endpoint defined by the environment variable DAPR_HTTP_ENDPOINT or   DAPR_RUNTIME_HOST plus DAPR_HTTP_PORT should be used for http service invocation and actors.
Actual Behavior
The http endpoint defined by the environment variable DAPR_HTTP_ENDPOINT or   DAPR_RUNTIME_HOST plus DAPR_HTTP_PORT is overridden by the gRPC address argument passed in the client constructor.
I introduced this bug myself in https://github.com/dapr/python-sdk/pull/597
Steps to Reproduce the Problem
Run the invocation examples in examples/invoke-http/invoke-caller.py, but update the client initialisation with an argument:
...
with DaprClient("localhost:50001") as d:
...

Release Note
RELEASE NOTE: FIX Fixes http endpoint being overwritten by address argument in constructor

/assign

I don't think this is a bug. The proposal says that arguments passes in the code takes precedence over the env variables.

I understand the issue now, thanks for fixing this.


support electron d.ts files without errors

I have an electron project where some files reference github-electron-main.d.ts and others reference github-electron-renderer.d.ts and when I compile with tsc, I don't get any errors. But, when I use gulp and gulp-tsb, I get:
Duplicate identifier 'export='."
Duplicate identifier 'export='."
reported once for each file. It looks like typescript's compiler supports this, but tsb somehow breaks the functionality.

What version of the typescript compiler do you use when you compile manually, and in which files are the errors reported?

I'm using version 1.6.2 w/support for JSX. Typescript doesn't report an error; unfortunately, expects the compilerOptions jsx member to have an integer value. See function checkJsxOpeningLikeElement in file typescriptServices.ts.

@klynch67 - wrong issue?

@jrieken Sorry, I take that back. I reduced the issue down to just 2 ts files and tsc does report the same errors. What I have is
A.ts:
/// <reference path='typings/github-electron/github-electron-main.d.ts' />
import foo = require('ipc');
console.log(foo.on);

B.ts:
/// <reference path='typings/github-electron/github-electron-renderer.d.ts' />
import foo = require('ipc');
console.log(foo.send);

When you try to compile those two files, the errors are reported in the d.ts files:
typings/github-electron/github-electron-main.d.ts(229,2): error TS2300: Duplicate identifier 'export='.
typings/github-electron/github-electron-renderer.d.ts(99,2): error TS2300: Duplicate identifier 'export='.

We used tsd to get the d.ts files from the DefinitelyTyped repo. I would have expected the reference path comments to be honored in this case. But it appears we need to do a two pass compile? I wonder if the TypeScript team is aware of this type of scenario..

electron has renamed ipc and updated the d.ts files. I don't think this issue is in gulp-tsb.


Transmit parameters  given to launch in the redirection

Add-on (Applications using the connector framework) needs to transmit parameters for example /mnoe/launch/cld-9pfh?settings=true
These parameters needs to be transfered to the MnoEnterprise.router.launch_url

@ouranos Could you please review ?
@hedudelgado FYI


[refactor]: Move metrics into separate service

          it would be nice if we could remove `sumeragi` from `torii`. I see that it is only used with `sumeragi.metrics` and `sumeragi.update_metrics`. Maybe we can make a ticket for this to make metrics a separate service

Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/4061#discussion_r1401915422
It would be convenient to decouple torii and sumeragii. And after wsv update (#4061) the last thing that requires torii to depend on sumeragi is metrics which should be moved into separate service.

related to #3467


Updated Panstarrs ingestion

Removed outdated links and downloading protocol for Panstarrs reference image ingestion, replacing with new links that auto-download without user interaction. The new setup still tiles together multiple images around the central RA and Dec to cover the frame.

@drmegannewsome thanks for the PR - updates are always great. To facilitate the review of this PR can you tell us how you tested the code changes in the PR?

Previously the use of -s ingestps1 would create a .txt file, asking the user to submit the file to an outdated site to manually download PS1 images for templates. This update allows the user to run, e.g.,
lscloop.py -n AT2020mot -e 20201017 -d 291 -s ingestps1
which will automatically download the template images, tile and stack them, and ingest them into the database.

@drmegannewsome here's a PR you can use as an example for formatting and what information to include: #118

The latest push addresses issues of: outdated/excessive commentary lines and patchy image tiling. This version successfully downloads and tiles the images from PS1 to cover the same frame as observed by LCO without missing sections. I have had no timeout issues on multiple tests. I have been encouraged to merge this for GW followup purposes for rapid, real-time subtractions of galaxy candidates.

The header keywords "MJD"/"MJD_OBS" needed to be changed to those values because we were getting a keyword error when using "MJD-OBS" otherwise. This has been confirmed by running with the old keyword header and getting an error of keyword not found.
To address the comment about _ut time, the line _ut = jd2date(_mjd+2400000.5).strftime('%H%M%S') does not just return 00:00:00. The database saves the PS1 templates with non-zero UT's. We also made this change because we receive an error when an explicit line defining _ut wasn't defined; thus we added it to the SDSS part as well for completeness' sake.
The line DR = delta/np.cos(_dec*np.pi/180) was actually already in the original PS1 ingestion version (original line 521; I just put it in a new place), so this is not a change. This line selects images at equal distances from the RA/dec of the source.

The header keywords "MJD"/"MJD_OBS" needed to be changed to those values because we were getting a keyword error when using "MJD-OBS" otherwise. This has been confirmed by running with the old keyword header and getting an error of keyword not found.
To address the comment about _ut time, the line _ut = jd2date(_mjd+2400000.5).strftime('%H%M%S') does not just return 00:00:00. The database saves the PS1 templates with non-zero UT's. We also made this change because we receive an error when an explicit line defining _ut wasn't defined; thus we added it to the SDSS part as well for completeness' sake.
The line DR = delta/np.cos(_dec*np.pi/180) was actually already in the original PS1 ingestion version (original line 521; I just put it in a new place), so this is not a change. This line selects images at equal distances from the RA/dec of the source.

I replied to these in the threads above.

In Slack, Megan mentioned that she had already ingested SDSS and PS1 templates for AT 2022upj. I looked at the headers of those images:
(pipeline) griffin@supernova:/supernova/data/extdata/20120529$ gethead sinistro_PS1_20120529_gp_AT2022upj.fits mjd mjd-obs mjd_obs ut utstart
sinistro_PS1_20120529_gp_AT2022upj.fits 56076.8954852977 55909.61602194 56076.8954852977<PHONE_NUMBER>29

(pipeline) griffin@supernova:/supernova/data/extdata/20060917$ gethead sinistro_SDSS_20060917_gp_AT2022upj.fits mjd mjd-obs mjd_obs ut utstart
sinistro_SDSS_20060917_gp_AT2022upj.fits 53995.0 53995.00000000 53995.0<PHONE_NUMBER>00

I notice three problems:

MJD-OBS (the standard LCO keyword) is now different than MJD and MJD_OBS. I suggest we just delete the latter two and set the standard one correctly.
The times (UT and UTSTART) are stored without colons in the header (212929 instead of 21:29:29).
The times are not set correctly for the SDSS image (000000).

I tested this on SN 2022xxf:
lscloop.py -n 'SN 2022xxf' -e 20230626 -d 33 -s ingestsloan
lscloop.py -n 'SN 2022xxf' -e 20230626 -d 33 -s ingestps1

This shows that the header keywords are set correctly. (SDSS does not come with times.)
(pipeline) griffin@supernova:~$ gethead /supernova/data/extdata/20021211/*SN2022xxf.fits /supernova/data/extdata/20111113/*SN2022xxf.fits mjd-obs date-obs
/supernova/data/extdata/20021211/sinistro_SDSS_20021211_gp_SN2022xxf.fits 52619.0 2002-12-11
/supernova/data/extdata/20111113/sinistro_PS1_20111113_gp_SN2022xxf.fits  55878.3518878931 2011-11-13T08:26:43.113949

The metadata also looks good on SNEx, so I'm going to go ahead and merge.


WIP: Enable parallel integration tests in hydra

Issue Number
ADP-466
Overview

[x] Pass in -j 4
[x] Try to avoid it failing due to hpc in CLI tests

Comments

Locally stack test cardano-wallet:integration --ta '-j 8' passed in 495s instead of 380s without parallel on CLI tests.

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+


Add new recipe for Cinnamon Rolls

Fixes #64

Perfect! Thanks for this great PR @CJarolyn! Happy to merge this!


Unnecessary wasm validation error "Smart contract data segments must lie in first 64KiB"

While working on Rust bindings I ran into this error: https://github.com/EOSIO/eos/blob/master/libraries/chain/wasm_eosio_validation.cpp#L28
Smart contract data segments must lie in first 64KiB
It seems to be caused by this line in the .wast file:
(data (i32.const 1048576) "Hello World")
If I change 1048576 to something much smaller like 555 then it works as expected.
According to @tbfleming on Telegram:

That check stopped a bug which no longer exists. Removing it would take revalidation, plus a hard fork.

The 64KB limit serves as a gatekeeper to ensure blockchain is healthy and secure. Changing this limit will result in hardfork or introduce blackholes for hackers. Alternatively you can use multi_index table to store const string data, which takes about same amount of memory.

The reason this occurs for rust is because rust’s compiler, be default, wants 1MB of “stack” to work with. You can reduce this, for example, by
rustc +nightly --target wasm32-unknown-unknown -O hello.rs -Clink-args='-z stack-size=8192'
The above example may or may not work I'm not sure how much stack rust needs to float.

Thanks @spoonincode! Reducing the stack size worked. FYI for anyone else tinkering with Rust, I ended up adding this to my .cargo/config file:
[target.wasm32-unknown-unknown]
rustflags = [
  "-C", "link-args=-z stack-size=48000"
]

Hi @taokayan, I build a contract with static libsecp256k1, with DATA larger than 64KB. Is there a better way to do? Since get data from table is quite slow when DATA big.

After the update to EOSIO.CDT v1.8.0-RC1 and EOSIO v2.1.0-RC1 I'm getting this error, too, with a pretty large contract. I previously used EOSIO.CDT v.1.7.0 and EOSIO v2.0.7 and have not had any problems.

After the update to EOSIO.CDT v1.8.0-RC1 and EOSIO v2.1.0-RC1 I'm getting this error, too, with a pretty large contract. I previously used EOSIO.CDT v.1.7.0 and EOSIO v2.0.7 and have not had any problems. Is there a way solve this? (like setting -stack-size or so?)

Tried setting -stack-size to something small and -fno-stack-first, both without success.


Support for Fragment Syntax

https://reactjs.org/blog/2017/11/28/react-v16.2.0-fragment-support.html#create-react-app

Experimental support for fragment syntax will be added to Create React App within the next few days. A stable release may take a bit longer as we await adoption by upstream projects.

6 months ago 😢 can we have this added to the babel-config 🙏

react-scripts 2.0 uses babel 7. Babel 7 is currently in beta and we are waiting for it to be officially released.

In the mean time you can use <React.Fragment>.

yeah im doing that. just figured it should be here already since the article was from november and it say within the next few days

Feel free to send a PR to edit the blog post. It was added pretty soon but 2.x will stay in beta for at least as long as Babel 7 itself is in beta.

but babel will stop its beta when gulp 4 leaves beta 😄
(just joking) but also a bit serious, in this current version we are using beta features from babel 7 isn't it? why not add this as well 🤔
https://github.com/facebook/create-react-app/blob/next/packages/babel-preset-react-app/package.json#L15-L27

Can someone clarify? Is this available in the @next branch?

yes, i think so.  @affanshahid

Why it was closed, since still not supporting?

@ReactGirl it is supported, but the version that is supporting it is still in beta.


Do I have to use wordslist if I can get wordvectors directly from words?

I wonder if the reason you're using wordslist is because you can only get wordvectors from id, or you can't get a tensor if you transfer wordvector in advance.

Yeah I mean you could also have a python dictionary that maps the words to their respective vectors. But yeah, the answer to your original question is you wouldn't need wordslist, it's just there to help you get the word vector.

I use Gensim and a pre-trained word vector model, and it seems impossible to transfer word vector sentence to a tensor because of the word vector in list. Any suggestion?

Should I go back to wordslist + embedding_lookup way since this tensor conversion way won't work?

Thank you so much!


Validation accuracy doesn't increase while retraining the model

Hello sir,
It is a great reference as my own research. However, I got a problem while I retrained the model. After I retrained your original model without any new data , there wasn't any increase in validation accuracy (log below). Do you know what might be the reasons of this issue?Thank you.
( By the way, I didn't modify your code except for printing numpy array)

rex@Zeus:~/Desktop/python_hr/retrained_5CNN$ python trackgesture.py
Using TensorFlow backend.

What would you like to do ?
1- Use pretrained model for gesture recognition & layer visualization
2- Train the model (you will require image samples for training under .\imgfolder)
3- Visualize feature maps of different layers of trained model
2

conv2d_1 (Conv2D)            (None, 32, 198, 198)      320
activation_1 (Activation)    (None, 32, 198, 198)      0
conv2d_2 (Conv2D)            (None, 32, 196, 196)      9248
activation_2 (Activation)    (None, 32, 196, 196)      0
max_pooling2d_1 (MaxPooling2 (None, 32, 98, 98)        0
dropout_1 (Dropout)          (None, 32, 98, 98)        0
flatten_1 (Flatten)          (None, 307328)            0
dense_1 (Dense)              (None,<PHONE_NUMBER>2
activation_3 (Activation)    (None, 128)               0
dropout_2 (Dropout)          (None, 128)               0
dense_2 (Dense)              (None, 5)                 645
activation_4 (Activation)    (None, 5)                 0
Total params: 39,348,325
Trainable params: 39,348,325
Non-trainable params: 0

(4015, 40000)
Press any key
samples_per_class -  803  total_image -  4015
Train on 3212 samples, validate on 803 samples
Epoch 1/15
2017-08-18 11:50:13.901818: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-18 11:50:13.901850: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-18 11:50:13.901855: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-08-18 11:50:13.901859: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2017-08-18 11:50:13.901862: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
2017-08-18 11:50:14.108379: I tensorflow/core/common_runtime/gpu/gpu_device.cc:940] Found device 0 with properties:
name: GeForce GTX 1080
major: 6 minor: 1 memoryClockRate (GHz) 1.835
pciBusID 0000:02:00.0
Total memory: 7.92GiB
Free memory: 7.30GiB
2017-08-18 11:50:14.108407: I tensorflow/core/common_runtime/gpu/gpu_device.cc:961] DMA: 0
2017-08-18 11:50:14.108413: I tensorflow/core/common_runtime/gpu/gpu_device.cc:971] 0:   Y
2017-08-18 11:50:14.108419: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1030] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1080, pci bus id: 0000:02:00.0)
3212/3212 [==============================] - 33s - loss: 1.7759 - acc: 0.2008 - val_loss: 1.6096 - val_acc: 0.2067
Epoch 2/15
3212/3212 [==============================] - 31s - loss: 1.6020 - acc: 0.2481 - val_loss: 1.6106 - val_acc: 0.2080
Epoch 3/15
3212/3212 [==============================] - 31s - loss: 1.5640 - acc: 0.2905 - val_loss: 1.6233 - val_acc: 0.2105
Epoch 4/15
3212/3212 [==============================] - 31s - loss: 1.4404 - acc: 0.4019 - val_loss: 1.6827 - val_acc: 0.1768
Epoch 5/15
3212/3212 [==============================] - 31s - loss: 1.2607 - acc: 0.4978 - val_loss: 1.7530 - val_acc: 0.1843
Epoch 6/15
3212/3212 [==============================] - 31s - loss: 1.0425 - acc: 0.6077 - val_loss: 1.9313 - val_acc: 0.1768
Epoch 7/15
3212/3212 [==============================] - 31s - loss: 0.8596 - acc: 0.6868 - val_loss: 2.0786 - val_acc: 0.1781
Epoch 8/15
3212/3212 [==============================] - 31s - loss: 0.7027 - acc: 0.7335 - val_loss: 2.2749 - val_acc: 0.1781
Epoch 9/15
3212/3212 [==============================] - 31s - loss: 0.6062 - acc: 0.7746 - val_loss: 2.6289 - val_acc: 0.1893
Epoch 10/15
3212/3212 [==============================] - 32s - loss: 0.5311 - acc: 0.7948 - val_loss: 2.7380 - val_acc: 0.1868
Epoch 11/15
3212/3212 [==============================] - 31s - loss: 0.4637 - acc: 0.8207 - val_loss: 2.8698 - val_acc: 0.1880
Epoch 12/15
3212/3212 [==============================] - 32s - loss: 0.4362 - acc: 0.8216 - val_loss: 3.0280 - val_acc: 0.1880
Epoch 13/15
3212/3212 [==============================] - 32s - loss: 0.3905 - acc: 0.8450 - val_loss: 3.2075 - val_acc: 0.1893
Epoch 14/15
3212/3212 [==============================] - 31s - loss: 0.3513 - acc: 0.8621 - val_loss: 3.3562 - val_acc: 0.1930
Epoch 15/15
3212/3212 [==============================] - 31s - loss: 0.3271 - acc: 0.8702 - val_loss: 3.4325 - val_acc: 0.1893

Hey Rex,
I noticed that you are using TensorFlow as backend, is it intentional ? I had used Theano infact. I may be wrong but I think in order to use my script under Tensorflow may require few additional changes. And I think that might be causing this accuracy difference that you are observing.
If backend library is not your concern then would you mind try with Theano once?

Hello @asingh33 , after using Theano as backend(KERAS_BACKEND=theano python trackgesture.py) , I still encountered the problem. Have you ever faced this kind of issue that you receive different training result in different machine?
(My operating environment : Keras 2.0.6, Theano:0.9.0, Python: 2.7.12)

rex@Zeus:~/Desktop/python_hr/retrained_5CNN$  KERAS_BACKEND=theano python trackgesture.py
Using Theano backend.
What would you like to do ?
1- Use pretrained model for gesture recognition & layer visualization
2- Train the model (you will require image samples for training under .\imgfolder)
3- Visualize feature maps of different layers of trained model
2

Layer (type)                 Output Shape              Param #
conv2d_1 (Conv2D)            (None, 32, 198, 198)      320
activation_1 (Activation)    (None, 32, 198, 198)      0
conv2d_2 (Conv2D)            (None, 32, 196, 196)      9248
activation_2 (Activation)    (None, 32, 196, 196)      0
max_pooling2d_1 (MaxPooling2 (None, 32, 98, 98)        0
dropout_1 (Dropout)          (None, 32, 98, 98)        0
flatten_1 (Flatten)          (None, 307328)            0
dense_1 (Dense)              (None,<PHONE_NUMBER>2
activation_3 (Activation)    (None, 128)               0
dropout_2 (Dropout)          (None, 128)               0
dense_2 (Dense)              (None, 5)                 645
activation_4 (Activation)    (None, 5)                 0
Total params: 39,348,325
Trainable params: 39,348,325
Non-trainable params: 0

(4015, 40000)
Press any key
samples_per_class -  803  total_image -  4015
Train on 3212 samples, validate on 803 samples
Epoch 1/15
3212/3212 [==============================] - 767s - loss: 1.8494 - acc: 0.1930 - val_loss: 1.6107 - val_acc: 0.2055
Epoch 2/15
3212/3212 [==============================] - 705s - loss: 1.6078 - acc: 0.2170 - val_loss: 1.6110 - val_acc: 0.2067
Epoch 3/15
3212/3212 [==============================] - 707s - loss: 1.5753 - acc: 0.2765 - val_loss: 1.6208 - val_acc: 0.2092
Epoch 4/15
3212/3212 [==============================] - 703s - loss: 1.4798 - acc: 0.3624 - val_loss: 1.6822 - val_acc: 0.2130
Epoch 5/15
3212/3212 [==============================] - 699s - loss: 1.3243 - acc: 0.4598 - val_loss: 1.7286 - val_acc: 0.1930
Epoch 6/15
3212/3212 [==============================] - 700s - loss: 1.1305 - acc: 0.5657 - val_loss: 1.8506 - val_acc: 0.1918
Epoch 7/15
3212/3212 [==============================] - 702s - loss: 0.9290 - acc: 0.6516 - val_loss: 2.0530 - val_acc: 0.1930
Epoch 8/15
3212/3212 [==============================] - 708s - loss: 0.8105 - acc: 0.6996 - val_loss: 2.1557 - val_acc: 0.2042
Epoch 9/15
3212/3212 [==============================] - 707s - loss: 0.6796 - acc: 0.7469 - val_loss: 2.3770 - val_acc: 0.1831
Epoch 10/15
3212/3212 [==============================] - 707s - loss: 0.6049 - acc: 0.7699 - val_loss: 2.4995 - val_acc: 0.1868
Epoch 11/15
3212/3212 [==============================] - 707s - loss: 0.5156 - acc: 0.8045 - val_loss: 2.7483 - val_acc: 0.1893
Epoch 12/15
3212/3212 [==============================] - 708s - loss: 0.4697 - acc: 0.8191 - val_loss: 2.7471 - val_acc: 0.1806
Epoch 13/15
3212/3212 [==============================] - 710s - loss: 0.4334 - acc: 0.8294 - val_loss: 2.9891 - val_acc: 0.1868
Epoch 14/15
3212/3212 [==============================] - 719s - loss: 0.3965 - acc: 0.8487 - val_loss: 3.0107 - val_acc: 0.1930
Epoch 15/15
3212/3212 [==============================] - 726s - loss: 0.3796 - acc: 0.8490 - val_loss: 3.1486 - val_acc: 0.1818

Hey Rex,
Do you train with or without GPU?
asingh33: At the time of writing this project I used only CPU. Didnt have appropriate GPU support.
What is your GPU specification?
asingh33: Not Applicable.
Do you modify parameters in .theanorc?
asingh33: None that I can recall now, but let me confirm once I am back home.

Hey Rex,
I checked my .theanorc file and I confirm that I dont have any changes in there.
BTW I kind of lost your original question here. What is your actual concern? Is it why that accuracy not going above that 84.9 % or something ??

Hello @asingh33, the issue is that I can't get the same result as you in Ubuntu 16.04 system. However, I found that I can get a similar result (above 85% accuracy) in Windows and OSX system. The reason is still unknown....

hi,
I am facing the same issue too... Validation accuracy is not getting increased when i retrain in ubuntu 16.04... and i also I get another error "HIGHGUI ERROR: V4L/V4L2: VIDIOC_S_CROP".. May I know where I am wrong..
It would be great if I canget an earnest reply.. Thank You

Guys,
I have only tested this project on OSX and Windows. Never get the chance to check on any Linux version yet. But your observations are really interesting as why the accuracy is getting affected on Ubuntu. I am afraid at the moment I dont have any answer to it.
Have you guys checked if the captured images are showing up right?
I may have to do some research of my own to figure that out but due to time constraint I am not able to spend any time at the moment. I would really appreciate if any of you are able to figure out the root cause and let me know.
@sanjanasri  regarding your that error msg, I did few searches on google. I may be wrong but it seems like its localized to Linux distros. Like I said I have not got the chance to try on Linux so wont be able to help here buddy.

@asingh33 I am sure that this problem is because the files under Ubuntu System are NOT sorted by filename. Therefore, when you are calling
    immatrix = np.array([np.array(Image.open(path2+ '/' + images).convert('L')).flatten()
                         for images in imlist], dtype = 'f')

the immatrix is not organized as you thought but.. some kind of a mess.
For a temporary fix, try using this:
    immatrix = np.array([np.array(Image.open(path2+ '/' + images).convert('L')).flatten()
                         for images in imlist], dtype = 'f')

If possible, using annotation files could solve that problem.

@xzyaoi   Thanks for taking time in fixing it. I will review it once on my end and pull the changes.


langgraph: add handle_unanswered_tool_calls to  create_react_agent

This change should address situations where LLM API providers error when sending an AI message with tool calls that do not have a corresponding ToolMessage, e.g.

openai BadRequestError: Error code: 400 - {'error': {'message': "An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'....
or anthropic: BadRequestError: Error code: 400 - {'type': 'error', 'error': {'type': 'invalid_request_error', 'message': 'messages.1: Did not find 1 tool_result block(s) at the beginning of this message....)

In the context of the create_react_agent usage, the simplest way to trigger this is an error inside a tool without error handling in ToolNode. This would lead to the agent interruption and any new human message sent to the agent would result in an error. A simple solution to address this is to call .update_state to modify message history. But since this option might not always be acceptable, we introduce a new handle_unanswered_tool_calls parameter with the following values:

"remove_tool_calls": modify AIMessages to remove tool_calls that do not have corresponding ToolMessages
"add_tool_messages": add a ToolMessage for each unanswered tool call, following each AIMessage with unanswered tool calls
False: do nothing (default)

Additional considerations:

should call_model update state for the AI messages with removed tool_calls? IMO no, because it would only lead to a confusing output when running agent w/ stream_mode=updates and won't actually affect underlying model behavior significantly (i.e. if the original human message is there, the model might still reintroduce a failing tool call in the future messages)

Closing in favor of https://github.com/langchain-ai/langgraph/pull/2182


Firebase Admin Java SDK should bypass App Check for RTDB operations

Moved from: https://github.com/firebase/firebase-android-sdk/issues/3952
It seems like the Admin SDK does not currently bypass App Check see: https://stackoverflow.com/questions/73105469/firebase-admins-sdk-and-app-check-safetynet
We might need a fix similar to https://github.com/firebase/firebase-js-sdk/commit/99414a51ca5cd25f69a96e4c9949ad5b84e3f64e#diff-ddbaa9e762a6010e5a0aa0c8048d48deea15594f14caa3d51e68b283f36e489fR170 in the Java SDK as well. Creating this issue to continue the investigation.

Any update on this? @lahirumaramba how did you worked arount it?

Hey @weixifan, any update on this? It looks like you're only focusing on the NodeJS port...

Still having the problem as of Feb 13, 2024. It is still not fixed.


remove link to deprecated hyperterm-tab-cwd

remove link to deprecated hyperterm-tab-cwd
hyperterm-tab-cwd is no longer maintained and has
a breaking issue:
see sdomino/hyperterm-tab-cwd#1
This is due to changes in Hyper

hej, @matheuss do you know, can we help hyperterm-tab-cwd?

@iamstarkov @matheuss Looks like creator said that Hyper has a similar feature that was in master on October 27 (ref: https://github.com/sdomino/hyperterm-tab-cwd/issues/1#issuecomment-256782885). Seems like he's discontinuing the plugin. Think we can land this, as there's been no further update 👍

Merging based on my previous comment. 👍 Please, feel free to comment or create an issue if there's any other developments!


Add yaml format spec support

When user run the generate command with a output file which has .yml or .yaml suffix. The swagger will generate yaml format output

Hi @casualjim,  could you please help merge the commits as seems i have no permission to do that ?

yes when the build finishes


Add advanced touch recognition

Hi Ulrich,
I was searching for a reliable touch lib for the esp32 lib like yours for a while. It really works well.
However, I would like to add some more advanced touch pattern methods, such as single tap, long tap, double tap. I'm unsure how to add such features to your code and I'm writing to get a hint where and how these should be added. An idea from your end would be much appreciated.
Thanks & Best Regards
-korkbaum

Dear Korrkbaum,
we would have to add some sort of time stamp or extra timers to the touch events and then qualify if two events belong to a single or double or long tap in ESP32Touch::dispatch_callbacks(ESP32Touch* self).
If you like, we can have a look at this next week, please write again or let me know how I can contact you via PN.

Hello ul-gh,
thanks for getting back to me. Unfortunately, I could'nt find a way to send you a PM but I added my mail address to my profile and it should be visible to you.
Your high-level design plan for the enhancement sounds good but I'm afraid that will go above and beyond my limited programming skills. Anyway, if you have any plan how we could tackle the job, please let me know and I will try my best.
BR
-korkbaum

Hi again,

I could'nt find a way to send you a PM but I added my mail address
to my profile and it should be visible to yo

Alas, Github removed any PM features, I guess there was too much abuse.
I am afraid I could not find your E-Mail address, but you can write to
<EMAIL_ADDRESS>which is my spam e-mail anyways.
I could look into this next week.
Regards, Ulrich

Hello Ulrich,
I spent some thought on this and think I can contribute with an algorithm as a starting point. I hope I will find some time over the weekend and will send you any results to your spam address. I guess I will get me a spam address as  well :-)
Thanks & Regards
Klaus

Hi guys,
did you come up with a working solution? I would be particularly interested in a long touch scenario. I did figure something out using the touchRead function, but it does not work very effectively.
Best regards,
freddeh

Hello freddeh,
I actually ended up with using touchread as well. ul-gh made a number of interesting suggestions in a PM trail but I failed to implement any of those.
BR -korkbaum

What would be useful is to have a simple API to check if touch-pin is currently touched or not.
Then you could use other libraries to detect pattern or do auto-repeat etc.


Expression before 'is' may be null

Fixes #31055 and fixes #28057.

Thanks!

Cherry-picked for 3.1.2.


[Input] Fix Errored Placeholder Text Color

see this fiddle
Any interest in working a little lighter coloring for the placeholders into default theme for input states?  Could just be my eyes, I don't have any stats on accessibility or proper spec.

Thanks

Fixed in next, colors for error placeholder are much lighter
http://jsfiddle.net/gsw6zmqn/

Has this been fixed? :) my input placeholders default to black and not gray
I'm running the meteor package with default theme, all components included.


com.android.build.api.transform.TransformException: java.util.zip.ZipException: duplicate entry: com/google/android/gms/internal/zzbyb.class

Hello,
:app:compileReleaseSources (Thread[main,5,main]) completed. Took 0.0 secs.
:app:lintVitalRelease (Thread[main,5,main]) started.
:app:lintVitalRelease
Executing task ':app:lintVitalRelease' (up-to-date check took 0.0 secs) due to:
  Task has not declared any outputs.
:app:lintVitalRelease (Thread[main,5,main]) completed. Took 2.006 secs.
:app:transformClassesWithJarMergingForRelease (Thread[main,5,main]) started.
:app:transformClassesWithJarMergingForRelease
Executing task ':app:transformClassesWithJarMergingForRelease' (up-to-date check took 0.006 secs) due to:
  Output file /Users/karliscudars/Projects/adpages/adpages/android/app/build/intermediates/transforms/jarMerging/release has changed.
  Output file /Users/karliscudars/Projects/adpages/adpages/android/app/build/intermediates/transforms/jarMerging/release/jars/1/1f/combined.jar has been removed.
All input files are considered out-of-date for incremental task ':app:transformClassesWithJarMergingForRelease'.
:app:transformClassesWithJarMergingForRelease FAILED
:app:transformClassesWithJarMergingForRelease (Thread[main,5,main]) completed. Took 1.105 secs.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:transformClassesWithJarMergingForRelease'.
> com.android.build.api.transform.TransformException: java.util.zip.ZipException: duplicate entry: com/google/android/gms/internal/zzbyb.class

* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 10.372 secs
Stopped 0 compiler daemon(s).

my dependencies:
dependencies {
    compile project(':react-native-flurry-analytics')
    compile project(':react-native-fetch-blob')
    compile project(':react-native-permissions')
    compile project(':react-native-animation')
    compile project(':react-native-mail')
    compile fileTree(include: ['*.jar'], dir: 'libs')
    compile 'com.android.support:appcompat-v7:25.0.0'
    compile 'com.facebook.react:react-native:+'
    compile project(':react-native-share')
    compile project(':react-native-onesignal')

    compile(project(':react-native-maps')) {
      exclude group: 'com.google.android.gms', module: 'play-services-base'
      exclude group: 'com.google.android.gms', module: 'play-services-maps'
      exclude group: 'com.google.android.gms', module: 'play-services-location'
      exclude group: 'com.google.android.gms', module: 'play-services-gcm'
    }
    compile 'com.google.android.gms:play-services:10.2.1'
    compile 'com.google.android.gms:play-services-location:10.2.1'
    // Required for OneSignal, even if you have added FCM.
    compile 'com.google.android.gms:play-services-gcm:10.2.1'
}

Any ideas?

BTW, my package.json:
{
  "name": "MYAPP",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "runiPhone5s": "react-native run-ios --simulator=\"iPhone 5s\""
  },
  "dependencies": {
    "@exponent/react-native-action-sheet": "^0.2.1",
    "@remobile/react-native-refresh-infinite-listview": "github:remobile/react-native-refresh-infinite-listview#pull/8/head",
    "react": "15.4.1",
    "react-mixin": "^2.0.2",
    "react-native": "0.38.0",
    "react-native-animation": "^1.0.6",
    "react-native-barcode-scanner-universal": "^1.0.5",
    "react-native-communications": "^2.1.0",
    "react-native-fetch-blob": "^0.10.4",
    "react-native-flurry-analytics": "^1.0.3",
    "react-native-gifted-listview": "github:faridsafi/react-native-gifted-listview#pull/51/head",
    "react-native-loading-container": "^0.4.0",
    "react-native-mail": "^1.5.0",
    "react-native-maps": "^0.12.2",
    "react-native-onesignal": "^1.2.3",
    "react-native-permissions": "git+https://github.com/alextkd/react-native-permissions.git",
    "react-native-share": "^1.0.13",
    "superagent": "^3.1.0"
  }
}

See #1773.


Column lookup key does not match for nested objects

Here is what i noticed.
Album mapping
public class AlbumMappings : Mappings<Album>
{
  AlbumMappings()
  {
    Columns( x=>
    {
        // column is generated with key 'Artist'.
        x.Column(c => c.Artist).Reference(f => f.ArtistId, ReferenceType.OneToOne).Result();
    }, true); // use explicit column definition
  }
}

FluentMappingPocoDataBuilder
protected override ColumnInfo GetColumnInfo(MemberInfo mi, MemberInfo[] memberInfos)
{
  // key is 'Artist__ArtistId'
  var key = PocoColumn.GenerateKey(memberInfos.Concat(new[] { mi }));
  bool explicitColumns = typeConfig.ExplicitColumns ?? false;
  // well, column not defined ??
  var isColumnDefined = typeConfig.ColumnConfiguration.ContainsKey(key);
  ...

  // resulting column being ignored for further column mapping aliasing
  if (explicitColumns && !isColumnDefined)
    columnInfo.IgnoreColumn = true;
}

Those problems does not occurs using Attributes, only with FluentMappings. Any clean work around for this problems?

@dwirawan Can you explain why this is an issue? and what problem you are getting because of it?

sorry for catching up late, here is the full snippet to give the idea.
Album class
public class Album
{
    public int AlbumId { get; set; }
    public string Title { get; set; }
    public int ArtistId { get; set; }
    public Artist Artist { get; set; }
}

Album class with attributes
[TableName("albums")]
[PrimaryKey("albumid")]
[ExplicitColumns]
public class Album
{
    [Column("albumid")]
    public int AlbumId { get; set; }
    [Column("title")]
    public string Title { get; set; }
    [Column("artistid")]
    public int ArtistId { get; set; }
    [ResultColumn]
    [Reference(ReferenceType.OneToOne, ColumnName = "artistid", ReferenceMemberName = "ArtistId")]
    public Artist Artist { get; set; }
}

Artist class
public class Artist
{
    public int ArtistId { get; set; }
    public string Name { get; set; }
    public List<Album> Albums { get; set; }
}

Artist class with attributes
[TableName("artists")]
[PrimaryKey("artistid")]
[ExplicitColumns]
public class Artist
{
    [Column("artistid")]
    public int ArtistId { get; set; }
    [Column("name")]
    public string Name { get; set; }
    [ResultColumn]
    [Reference(ReferenceType.Many, ColumnName = "artistid", ReferenceMemberName = "ArtistId")]
    public List<Album> Albums { get; set; }
}

Mapping class
public class EntityMappings : Mappings
{
    public EntityMappings()
    {
        For<Artist>()
            .TableName("artist")
            .PrimaryKey("artistid")
            .Columns(x =>
            {
                x.Column(c => c.ArtistId).WithName("artistid");
                x.Column(c => c.Name).WithName("name");
                // actually i don't know how to configure many reference to List<Album> ? missing something?
            }, true);
        For<Album>()
            .TableName("albums")
            .PrimaryKey("albumid")
            .Columns(x =>
            {
                x.Column(c => c.AlbumId).WithName("albumid");
                x.Column(c => c.Title).WithName("title");
                x.Column(c => c.ArtistId).WithName("artistid");
                x.Column(c => c.Artist).Reference(r => r.ArtistId, ReferenceType.OneToOne);
            }, true);
    }
}

Database factory snippet
private static readonly DatabaseFactory _factory = DatabaseFactory.Config(x =>
{
    x.UsingDatabase(() => new Database("csname"));
    x.WithFluentConfig(FluentMappingConfiguration.Configure(new EntityMappings()));
});

Test snippet
using (var db = factory.GetDatabase())
{
  var r = db.Fetch<Album>("select a.*,r.* from albums a left join artitst r on a.artistid=r.artistid");
}

So here is the problem.
Fetch result does not contain the nested Artist object as expected (null).
From my investigation during debugging session in PocoDataBuilder.Build(), resulted PocoData.Members for Album class does not contains PocoMemberChildren for member Artist, therefore it can't build map plans correctly. Continuing from my finding above _memberPlans returned from Attribute and FluentMapping behave differently, due to mismatch above, FluentMapping decide to ignored the child member of the nested object.
My idea is to create method to directly specify reference in ColumnConfigurationBuilder, so instead of using ColumnConfigurationBuilder.Column().Reference() to specify reference, it can directly call ColumnConfigurationBuilder.ReferenceColumn() so that _columndefinitions can directly build column key for nested object. Is that possible?

Give the latest or beta7 a go ;)

@schotime i will give it a try, can you commit the changes? since i don't find new code in dev3.1, for now i will evaluate from nuget. thanks, gonna report to you soon :)

@schotime well, i still having above issue as well with beta7, since latest code is not available, i cant figure out what really happening under the hood.

Pushed.

thanks. gonna check it

hi @schotime, already checked the code, and it still experiencing above issue, i think the problem lies on FluentMappingPocoBuilder.GetColumnInfo for childmember of a nested object, GetColumnInfo assume only for direct member but not for child's member, sorry i might be misleading about the lookup key mismatch, but here is my silly ideas:

Refactor GetColumnInfo so it can distinguish between direct member and child's member (checking against  in TypeDefinition.ColumnConfiguration), or
TypeDefinition.ColumnConfiguration should build nested object members.

What do you think?

This examples works for me.
The only difference I can see is that Artist should have its column set.
x.Column(c => c.Artist).WithName("artistid").Reference(r => r.ArtistId, ReferenceType.OneToOne);

I will commit my example that shows it working.

I think I have found what you mean.
I am using the convention scanning. That is the difference. It does the recursion. Back to the drawing board. Number 2 is the way to go.

Ok. Latest commit to dev3.1 should solve it. Was pretty easy in the end. Not sure why it was the way it was in the end. Have added the scenario above in IncludesWithLinqProvider with Test3/Test4.

@schotime just check it, and it works as expected, thanks :+1:

Awesome!


Graph::ListGroups API call fails with a JSON unmarshaling error

The Graph API implementation for ListGroups consistently fails with a JSON unmarshaling error.
Steps to reproduce:
... initialize client
_, err := client.ListGroups(clients.ctx, graph.ListGroupsArgs{})

In my project, I need to call the API like this, which also fails:
client.ListGroups(clients.ctx, graph.ListGroupsArgs{
		ScopeDescriptor: &projectDescriptor,
		ContinuationToken: continuationToken,
})

After a brief look into the code, my initial hunch is that, possibly, the unmarshal code being called is UnmarshalBody, where it may need to be UnmarshalCollectionBody
The response in browser looks like this
{
  "count": 10,
  "value": [
    ...
  ]
}

I've just hit the same issue with Graph::ListUsers.
This may affect all List methods probably?

Fixed in PR #31


PR #93644 - sql: enhance SHOW RANGES (2 of 6)

Exalate commented:
Related PR: https://github.com/cockroachdb/cockroach/pull/93644
Commit: https://github.com/cockroachdb/cockroach/commit/e67d2fd95546fb5af9e765a5cde1ae597f357373

Release note (backward-incompatible change): The format of the
columns start_key and end_key for SHOW RANGES FROM DATABASE
and SHOW RANGES FROM TABLE have been extended to include which
table/index the key belong to. This is necessary because a range
can now contain data from more than one table/index.
Jira Issue: DOC-6470

NB: The new behavior will be opt-in in v23.1, and the old behavior becomes deprecated.
See: https://github.com/cockroachdb/cockroach/pull/98979

knz @.***> writes:

NB: The new behavior will be opt-in in v23.1, and the old behavior
becomes deprecated.
See: cockroachdb/cockroach#98979

Thanks knz!!!  Appreciate the heads up
FYI the autogenerated docs issue for the change in
cockroachdb/cockroach#98979 is DOC-7311, which I will work on as part of
the larger tracking docs issue DOC-6732 for v23.1


Jython Support - locking

Hi,
youtube-dl does not work with Jython (http://www.jython.org/), at least on Mac OS X (possibly on Windows). The problem is related to import fcntl which doesn't exist in Jython :(
https://github.com/rg3/youtube-dl/blob/6ec6cb4e956abbd76a6ff42336821770a5fbbcc7/youtube_dl/utils.py#L1219-L1225
Can additional support be added for "soft locking" ... for instance, like in this Python package: https://pypi.python.org/pypi/filelock/
Thanks,
Dustin

Have you found a workaround for that yet? I'd like to embed youtube-dl in my java youtube downloader.

Unless you need the --download-archive option, you can just remove that line and change the setproctitle(in the same file) to:
def setproctitle(title):
    return

It seems to work fine.

As far as I see editing the setproctitle() is not necessary. I removed the fcntl part however.
Now it works when I don't provide any parameters for ydl_opts, if I do I get the following error:
test
Exception in thread "MainThread" Traceback (most recent call last):
  File "<string>", line 4, in <module>
  File "__pyclasspath__/youtube_dl/YoutubeDL.py", line 292, in __init__
AttributeError: 'set' object has no attribute 'get'

Process finished with exit code 1

My code is the following:
public class Main {
    public static void main(String[] args) {
        PythonInterpreter python = new PythonInterpreter();
        python.exec("print(\"test\")");
        python.exec(
            "from __future__ import unicode_literals\n" +
            "import youtube_dl\n" +
            "\n" +
            "ydl_opts = {'listformats'}\n" +
            "with youtube_dl.YoutubeDL(ydl_opts) as ydl:\n" +
            "   ydl.download(['http://www.youtube.com/watch?v=BaW_jenozKc'])"
        );

    }
}

@mdPlusPlus ydl_opts must be a dictionary: ydl_opts = {'listformats': True}.

Thank you, that worked.

Basic Jython support will be included in the next version.

Known issues on Jython:

--no-check-certificate cause errors. A patch is needed, see http://bugs.jython.org/issue2481
--console-title requires complete ctypes implementation. See http://bugs.jython.org/issue2148 and http://bugs.jython.org/issue1917
--download-archive requires file locking. See http://bugs.jython.org/issue1943


First steps towards SMS verification of profiles

Closes  #896

Backend checklist

[x] Formatted my code by running isort . && black . in app/backend

[x] Added tests for any new code or added a regression test if fixing a bug

[x] All tests pass

[ ] Run the backend locally and it works

[ ] Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

[x] check uniqueness of verified phone numbers

[x] random Luhn token generation

[x] hide unverified phone numbers from API

Ready for review of simplified API and the implementation.
Will do migrations once you are happy with the database model!

Just realized that my test file wasn't committed, but now it is included in the branch! Ready for another review and I will do migrations tomorrow unless someone does it before me :)

LGTM!

... as in merge despite that I broke frontend? Just double-checking.

No, sorry, I didn't notice. I'll fix it up and push to this branch.

Thanks for a quick helping hand! Merging!


exp/services/recoverysigner: empty allowed accounts cause application crash

When starting the recoverysigner without allowed accounts, the application crashes.
The allowed accounts feature added in 15de5ffd450223e1bc5abf80575d906dc2eabb6e is intended to be an optional feature, but it appears it is required by the code because the code isn't handling its absence. The CLI options parameters don't have the parameter defined as required, so there is no helpful error message if a user doesn't provide it.
When starting the application without the parameter specified, I see the following error as if I have provided a malformed invalid value for the option.
FATA[2021-06-04T21:59:55.747Z] Error: parsing allowed source accounts: strkey is 0 bytes long; minimum valid length is 5  pid=17606

I think this should be fixed by keeping the parameter as optional and making it so that if no value is provided the previous behavior is retained.

Closing all recoverysigner issues


added pump and pump controller devices xml

Problem
What is being fixed?  Examples:

Missing pump device and pump controller device xml

Change overview

Adds pump device and pump contoller device xml

Testing
How was this tested? (at least one bullet point required)

Not tested, because there appear to be no way to test the xml files?

@jepenven-silabs would have time to check this? Thanks

Thanks!


Removed contentLength from setTags

/azp run automation - sdk

Can one of the admins verify this patch?


Test if ci builds

This is the ci build is run on my fork ChihChengLiang/beacon_chain. So .circle/config.yml should not be the issue, it works.
The issue should be on Github or on Circle CI.


Assert failure at startup using x86_64-w64-mingw32-g++ on Ubuntu 18.04

Yosys silently fails an assert and exits without printing anything when built using x86_64-w64-mingw32-g++ on Ubuntu 18.04.
When built with debug symbols and run under gdb.exe, I can place a breakpoint on _exit and get the following backtrace:
Breakpoint 2, 0x00000000007c9ec8 in _exit ()
(gdb) bt
#0  0x00000000007c9ec8 in _exit ()
#1  0x000000000043ae32 in Yosys::logv_error_with_prefix(char const*, char const*, char*) () at /usr/share/mingw-w64/include/process.h:46
#2  0x000000000043ae49 in Yosys::logv_error(char const*, char*) () at kernel/log.cc:343
#3  0x000000000043ae6c in Yosys::log_error(char const*, ...) () at kernel/log.cc:392
#4  0x0000000000404de9 in Yosys::log_assert_worker () at ./kernel/log.h:153
#5  0x00000000007e37fd in Yosys::RTLIL::IdString::get_reference(char const*) () at ./kernel/rtlil.h:148
#6  0x00000000007e4520 in _ZN5Yosys5RTLIL8IdStringC4EPKc () at ./kernel/rtlil.h:258
#7  0x00000000008fdbdf in _GLOBAL__sub_I_opt_share.cc () at ./kernel/rtlil.h:258
#8  0x00000000007ba072 in __do_global_ctors ()
#9  0x00000000004013cb in __tmainCRTStartup ()
#10 0x000000000040151b in mainCRTStartup ()
(gdb)

Removing the assert fixes the issue, however that's obviously not a good solution.
There are two issues here:

The assert is failing, and I don't know why.
The program is silently exiting without printing anything, probably because it's exiting before the console output has been set up.

Further information:
This is being built with make config-msys2-64 using the toolchain available in Ubuntu 18.04.  I am testing this on a Windows 10 machine.
Things I've tried so far to fix it, in no particular order:

Building with both x86_64-w64-mingw32-g++-posix and x86_64-w64-mingw32-g++-win32
Building with -std=c++17
Building with -mthreads
Building both stripped and unstripped binaries

Of note is that gdb appears unable to actually set breakpoints, which makes this a challenge to debug:
(gdb) b kernel/log.h:153
No source file named kernel/log.h.
Make breakpoint pending on future shared library load? (y or [n]) n
(gdb) b Yosys::log_assert_worker()
Can't find member of namespace, class, struct, or union named "Yosys::log_assert_worker"
Hint: try 'Yosys::log_assert_worker()<TAB> or 'Yosys::log_assert_worker()<ESC-?>
(Note leading single quote.)
Make breakpoint pending on future shared library load? (y or [n]) n
(gdb)

Since I can't put a breakpoint on that value, I modified it to the following:
                static int get_reference(const char *p)
                {
                        //log_assert(destruct_guard.ok);
                        if (!destruct_guard.ok)
                                guard_failures++;
                        else
                                guard_successes++;

Then I ran yosys and exited right away:
Breakpoint 1, 0x00000000007d1d50 in _exit ()
(gdb) p guard_failures
$1 = 2
(gdb) p guard_successes
$2 = 198
(gdb)

Reading from https://isocpp.org/wiki/faq/ctors#static-init-order it seems as though this is undefined behavior in C++, since some static RTLIL object is being constructed at startup that contains a static call to a static destruct_guard_t, which may not yet have been constructed.
I'm inclined to believe that the correct solution is to disable the assert, since it seems the result is undefined anyway.  However, I would like someone who understands C++ and Yosys better to comment on the situation.

The assert seems to be showing that there are other issues.  When I try to synthesize a design using this version of yosys, it fails elsewhere:
2.25.1. Executing Verilog-2005 frontend: D:\Software\Icestorm\bin\../share/yosys/ice40/brams_map.v
Parsing Verilog input from `D:\Software\Icestorm\bin\../share/yosys/ice40/brams_map.v' to AST representation.
Generating RTLIL representation for module `\$__ICE40_RAM4K'.
Generating RTLIL representation for module `\$__ICE40_RAM4K_M0'.
Generating RTLIL representation for module `\$__ICE40_RAM4K_M123'.
D:\Software\Icestorm\bin\../share/yosys/ice40/brams_map.v:277: ERROR: Parameter _TECHMAP_REPLACE_.INIT_0 with non-constant value!

More things I've tried:

Compiling with -O0
Replacing the compiler with gcc (i.e. to ensure it's a problem with x86_64-w64-mingw32-g++) which produces a working binary
Running under wineconsole (WINEDEBUG=+relay wineconsole --backend=curses ./yosys.exe 2>&1 | grep ERROR shows the assert message as a call to msvcrt.strlen)

So there definitely is something weird going on, I'm just not sure what it is.  Or what "RTLIL" is.

I've done a bisect, and https://github.com/YosysHQ/yosys/commit/3d3779b0376b8204ed7637053176a07b7271ac1d is the commit that's causing issues.  It works fine with https://github.com/YosysHQ/yosys/commit/a29814ca3f448481d351bc9f8ba0a20084afd883, but not on the following commit.

Thanks for bisecting. I was going to suggest that https://github.com/YosysHQ/yosys/pull/1275 was the root cause, since it uses some exotic incantation to try and improve performance of IdStrings.
Commit https://github.com/YosysHQ/yosys/commit/3d3779b0376b8204ed7637053176a07b7271ac1d should simply apply that optimisation to more things across the codebase.
A workaround would be to not apply this opt to mingw?

I have a fix for it, and I'm kind of surprised this isn't affecting other platforms.  I think it's caused by UB in C++.

I can confirm that 8d128ba6d079fd5f0741c31a9308bf06aaf4673c fixes the issue.


Merge "configTypesUpdated" and "edsUpdatedServices" in PushRequest and XdsEvent

I believe it is historical problem we have two attributes to indicate the resources changes. It's better to have one and in a more extensible way as if we've other resource tracking requirements in the future. Such as Full Push scoping described in this #22392

Hi @seflerZ. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

unit-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-security-k8s-tests_istio

gencheck_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-local-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-local-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-security-k8s-tests_istio

gencheck_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test gencheck_istio

unit-tests_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
c4f705a316433dc7a5a00bfd0228247aa92391f8
link
/test integ-security-k8s-tests_istio

gencheck_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test gencheck_istio

unit-tests_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
3fe51bde40d87b9211ae7485bd78f41ae8c88e2e
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
5a50d0de4faf91a438796906e42045da99aa2f14
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5a50d0de4faf91a438796906e42045da99aa2f14
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5a50d0de4faf91a438796906e42045da99aa2f14
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
37e86ca6caf220fa26f23b2698f534f1aca563fc
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
37e86ca6caf220fa26f23b2698f534f1aca563fc
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4409453527275a224a9aa1a43a3ec9049aa148e8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4409453527275a224a9aa1a43a3ec9049aa148e8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
5c2cd825980c01edfa6ce44d9c4e49c08c5e2a01
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@seflerZ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
5c2cd825980c01edfa6ce44d9c4e49c08c5e2a01
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
838ca4a345f3b4d14bc20fac635ea5d3b830aaa8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Bug - geometry searches not zooming to extents properly

Fixes a bug where if using a geometry object to control where a search zooms to, the system will not zoom to it correctly if a zoom level is not defined.
Bonus bugfix to add in extra padding to the left and right of search objects, so that they don't extend right to the edges of the page.
Closes #142

Converted to draft while checking build errors