Adding a new stable version 2023-01-01 (Taking changes from 2022-11-01-preview)

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

          "$ref": "#/definitions/CloudError"

Error responses - use common types
There are definitions of error responses and details in commontypes types.json that you can use instead of declaring your own.
See e.g. ErrorResponse
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L300
And ErrorDetail
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#LL258C21-L258C21

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:3596 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "description": "Gets or sets the exclude resource types property. This property sets the resource types to be excluded during restore.",

e.g.?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:4450 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "description": "Gets or sets the include resource types property. This property sets the resource types to be included during restore.",

included

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:4443 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "description": "Gets or sets the PV Restore Mode property. This property sets whether volumes needs to be restored.",

expand acronym

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:6389 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "description": "Gets or sets the LabelSelectors property. This property sets the resource with such label selectors to be included during restore.",

This boilerplate isn't very useful as documentation. Try to focus on explaining the meaning or usage of properties in the descriptions.

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:6382 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "type": "string"

consider '"format": "arm-id"' and https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7299 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    "lastUpdatedTime": {

readonly should be true

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7308 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

"ResourceGuardProxyBaseResource": {

Should some of these base types be declaring a required discriminator property?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7316 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

"DppResource": {

Refactor
Can this be replaced and you could instead inherit allOf common-types's ProxyResource?
Or smaller refactor
Can you declare DppResource as inheriting allOf common-types' ProxyResource?
Resource definitions - use TrackedResource or ProxyResource in commontypes
Instead of defining your own resource class with required top level properties, 'id', 'type', 'name', and 'location' and 'tags' (for TrackedResource) its recommended to inherit from ProxyResource or TrackedResource in common-types v2 or v3.json. (The v2 definition does NOT include systemData, and is otherwise similar to the v3 one).
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L56

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5449 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

"DppIdentityDetails": {

Refactor if nonbreaking
UserAssignedIdentity, ManagedIdentity - use common types
Instead of defining your own managedIdentity or userAssignedIdentity class, I highly recommend finding one to use by $ref under common-types such as
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v5/managedidentity.json#L50

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5390 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

"InnerError": {

Refactor if nonbreaking:
Error responses - use common types
There are definitions of error responses and details in commontypes types.json that you can use instead of declaring your own.
See e.g. ErrorResponse
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L300
And ErrorDetail
https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#LL258C21-L258C21

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5883 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

"OperationResource": {

Refactor away by using common-types if its basically non-breaking (it should be)
OperationListResult - use common types
The OperationListResult type is defined correctly in commontypes types.json. It is recommended to reference and reuse the common definition instead of declaring your own. [Otherwise it is frequently declared incorrectly.]
            "schema": {
              "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/OperationListResult"
            }

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:6113 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    },

ARM recommends enums over booleans as explained here :
https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html
Standard guidance is: replace boolean/switch properties with better enum
A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Even if you still believe [True, False] are the correct values for a property, you should use a string enum with values [True, False] instead of boolean. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [True, False, Unknown].

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:6352 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    },

describe: what are the valid string values?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7357 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    "resourceToBeDeleted": {

consider '"format": "arm-id"' and https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7358 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "type": "string"

consider '"format": "arm-id"' and https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7359 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    }

format: datetime?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7370 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    },

ARM recommends enums over booleans as explained here :
https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html
Standard guidance is: replace boolean/switch properties with better enum
A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Even if you still believe [True, False] are the correct values for a property, you should use a string enum with values [True, False] instead of boolean. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [True, False, Unknown].

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5977 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    "description": {

Looks like readonly should be true

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7311 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "$ref": "#/definitions/DppResource"

Recommend moving to Resource definition from v4 common types.

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7320 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    "objectType": {

Recommend enum for discriminator properties.

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5267 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

      "readOnly": false

Shouldn't this be readOnly: true?

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5270 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    "snapshotVolumes": {

ARM recommends string enums over boolean. Generally enums make better properties than booleans. They are more descriptive, flexible and future-proof while being easier for customers to discover, understand and use. Ref: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review. They also allow adding values later without requiring a new API version (e.g. "Unknown", "Default", etc.), and allow values other than just true/false and support description strings. Even if you only ever want two values, you can have a string enum with True/False (or Enabled/Disabled, etc.).
In this case, it might be possible to include both booleans in one enum (depending on scenarios), or if not, it could still clarify the API: e.g. restoreProcess: { RestoreOnly, SnapshotFirst } and restoreScope: { Nodes, NodesAndCluster }.

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:4420 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

    },

+1, for example something like pathType: { Full, RelativeToBackupItem }

In reply to:<PHONE_NUMBER>

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:5977 in 9edb210. [](commit_id = 9edb210d9eecb2a3222e3ec9b653495173cc1f3d, deletion_comment = False)

@Shashank1306s , please response to ARM comments and make update to your swagger. And there are linter errors please help to fix.

we have removed the ResourceGuardProxy changes, so please review the PR again.

},

You won't need these definitions if you refer to common-types everywhere instead

Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-01-01/dataprotection.json:7039 in 4f2094d. [](commit_id = 4f2094d799f03e72ac3ce0528599a86011365db6, deletion_comment = False)

@Shashank1306s , please response to ARM comments and make update to your swagger. And there are linter errors please help to fix.

Hi, I've removed the changes that were causing linting errors, and will resolve the arm comments.

Hi @Shashank1306s , please require breaking change review from breaking change review board.

@xiaoxuqi-ms : can you pls review this PR now

The apiReadinessCheck failed, pls make sure your service are deployed or you have a scheduled time to deploy.

The apiReadinessCheck failed, pls make sure your service are deployed or you have a scheduled time to deploy.

We have a scheduled time to deploy, we will start deploying our service by 25 Jan.


fix: quantity for SfAddToCart in SfProductCardHorizontal

Related issue
Closes #998
Scope of work
V-model added to SfAddToCart

@justyna-13 awesome 🥇


VSR/Grid: read_block_from_{replica,cluster}

(Context: The grid scrubber will use this.)

read_block_from_replica(): Read from the disk. If there is an issue (e.g. checksum failure), pass the encountered error into the callback.
read_block_from_cluster(): Read from the disk. If there is an issue (e.g. checksum failure), queue the read into the "faulty queue" for remote repair. Don't invoke the callback until the correct block is available.

Both of these have cache_check/cache_update options:

cache_check allows the scrubber to skip the cache (since it only cares about disk content).
cache_check also allows the caller to skip the cache if they are handling it separately via read_block_from_cache as an optimization (to avoid a nexttick).
cache_update allows the scrubber to avoid filling the cache with cold data.

read_block_from_replica()'s coherent: bool option allows the grid to distinguish reads that should definitely be in the grid (e.g. commit prefetch) from reads that only might be (e.g. repairs). This enables additional validation.

Remove cache_coherent. Grid.verify_read() can now depend on the coherent option, which is much simpler (albeit slightly less comprehensive).
But the old cache_coherent strategy won't work soon (due to fulfill_block) and would have needed to be much more complicated (depending on a whole second bitset) so this is a good compromise.

Thanks for the excellent overview!


IR not blasting

Hi, I ran into an issue with IR not blasting.  The serial output was 0:nec:32.  It took me a little time to figure out, but it looks like the IR code is being sent from the IR Controller with the "0x" prefix already appended.
The code couldn't be sent because of the extra "0x" appended to the dataStr in line 1350.  Tweaking the code as follows resolved the issue for me.
uint64_t data = strtoull(("0x" + dataStr).c_str(), 0, 0);
to:
uint64_t data = strtoull(dataStr.c_str(), 0, 0);
Cheers!

Understood.  For some reason, sending code=FE4A56AB:NEC:32 resulted in 0:NEC:32 at the client.  The controller automatically added “0x” and then the client added another “0x”, resulting in 0x0xFE4A56AB, which was interpreted as 0:NEC:32.


Broken styles on MAUI + Blazor?

Hello y'all.
I've been trying to use TreeViews on MAUI, everything is working but I noticed the svg arrow is supposed to be hidden if the item doesn't have children.
The class names are there but there are no styles. Has anyone faced this behavior before?

Hi @AngeloTadeucci,
I've never experimented with Maui, so can't speak from experience, but I suspect that they didn't implement style tags within components.
You can test that hypothesis by creating a small component yourself, e.g.

Text

If that's not showing red text in Maui, we've got it confirmed and I have a resolution in mind.
Stefan

Hey @stefanloerwald
You are 100% correct, style tags don't work within components.
What is the fix you have in mind?
Thanks!

I'm thinking of https://github.com/excubo-ag/Blazor.TreeViews/commit/acf7da890141ec3e834b088a15db5f4f46123bf5
This commit should work for you, as long as the CSS isolation feature is supported in MAUI. Please let me know! The new version should be available any moment now.

It worked! Thank you.


Design Project Description Section for both Mobile and Desktop

May I take this issue ?

Yes you need to design that page

as per design on figma by vaibhav?

lets discuss over slack

ok

MULTIPLE ASSIGNEES REQUIRED HERE! PING ME FOR COLLABORATING!

Updates on this issue!

Willing to work on this issue

@Manvityagi shall I collaborate with you

@Manvityagi shall I collaborate with you

Yeah! I am supposed to complete it today!


Fix the test recognizes snapshot is obsolete

Current test raises a warning below. This cause GitHub Actions: Continuous Integration to fail in step 5.
npm run test

><EMAIL_ADDRESS>test
> npx standard && npx jest

 PASS  __test__/game.test.js
  App
    √ Contains the compiled JavaScript (1 ms)
  Game
    Game
      √ Initializes with two players (1 ms)
      √ Initializes with an empty board (1 ms)
      √ Starts the game with a random player
    turn
      √ Inserts an 'X' into the top center
      √ Inserts an 'X' into the top left (1 ms)
    nextPlayer
      √ Sets the current player to be whoever it is not (1 ms)
    hasWinner
      √ Wins if any row is filled (1 ms)
      √ Wins if any column is filled (1 ms)
      √ Wins if down-left diagonal is filled
      √ Wins if up-right diagonal is filled

 › 1 snapshot obsolete.
   • App Contains the compiled JavaScript 1
Snapshot Summary
 › 1 snapshot obsolete from 1 test suite. To remove it, run `npm run npx -- -u`.
   ↳ __test__/game.test.js
       • App Contains the compiled JavaScript 1

Test Suites: 1 passed, 1 total
Tests:       11 passed, 11 total
Snapshots:   1 obsolete, 0 total
Time:        0.682 s, estimated 1 s
Ran all test suites.

I noticed the comparison to the current snapshot in the fs.readFile callback in an async test case is recognized obsolete. So I change the method to fs.readFileSync, then the test works correctly and I could update the snapshot.

Thank you, @dzeyelid!


$resolved added to the PUT request

Angular-cached-resource adds the $resolved field, when making a POST or PUT request for the second time. Then mongoDB gives me an error: 'Modified field name may not start with $'. How can the $resolved field be removed from a request?

Having same issue. Any solution?

Same issue here


helper method for introspection queries

Would be useful to have a convenience method in the compiler to check if an executable definition is an introspection query (check if the first field is __type?).
I see it working something like this:
let query_input = r#"
query Op {
  __type(name: "User") {
    name
    fields {
      name
      type {
        name
      }
    }
  }
}
"#;

let mut compiler = ApolloCompiler::new();
let query_id = compiler.create_executable(query_input, "query.graphql");

let diagnostics = compiler.validate();
for diagnostic in &diagnostics {
    println!("{}", diagnostic);
}

let op = compiler.db.find_operation_by_name(query_id, String::from("Op"))
    .expect("getProduct query does not exist");
let is_introspection = op.is_introspection(); // return a bool

Is there any other useful information we can provide convenience methods for in introspection queries?

This looks interesting. I'd like to open a CR for this. I was writing some notes on what an implementation of this would have and came up with a question. Should this helper consider fragments or inline fragments?
Actually, if we are, then how deep do we follow these fragments? I came up with this crazy bit of a scenario that I ran on [Star wars api] (https://studio.apollographql.com/public/star-wars-swapi/explorer?variant=current).
query IntoSpectDeepFragments {
    ...onRootTrippy
}

fragment onRootTrippy on Root {
   ...onRooten
}

fragment onRooten on Root {
  ...onRooten2
}

fragment onRooten2 on Root {
   __type(name: "Root") {
    ...onType
  }
}

fragment onType on __Type {
  fields {
    name
  }
}

I think this could keep going, no?

If we should only consider field selection and return false if the selection is an inline or fragment expansion, then I think implementation is pretty simple. I have a local draft of a sample version I could PR.

@jregistr a PR is welcome!
The example you provided returns an introspection result, right? If so, I'd consider it to be an introspection query and should return true to this API method. So it's going to have to check recursively. It likely can be done in the same way we get variables in a given selection set - we also check fields, inline fragments and fragments for variables just like you would check here for field name == __type.

The example you provided returns an introspection result, right?

It does actually, so yeah, I agree, it's a valid introspection query.

It likely can be done in the same way we get variables in a given selection set

I'll take a look at that as reference for the fragments since that looked liked the trickier of the 3 selection types.


Sourcemaps refer to *.styl file, but display compiled css contents

how does one enable sourcemaps?
https://github.com/at0g/webpack-css-sourcemaps

#37 did not resolve this.
The link below is a simple reproduction using v0.6.0 of stylus-loader and the extract-text-plugin example from less.
https://github.com/at0g/webpack-css-sourcemaps/tree/less-stylus

@at0g, I'll look into this shortly.

@at0g, your package.json links to stylus-loader ^0.6.0, which doesn't match v1.0.0 that contains #37 merged in. This is a special behavior for pre-release 0.x versions. Change it to
...
  "stylus-loader": "^1.0.0",
...

then npm install and you'll see source maps for both less and stylus :)

Thanks for looking into this @shama / @skozin - The issue is gone in the v1.0.0 version.
:+1:


PressedCommand doesn´t work

Pressed command doesn´t trigger for any view, i´ve tried everything, but no sucess.
also, is there a way to "untrack" o "stop detecting" tap? or a way to stop the process that run on other thread that checks for taps of all "setted or affected" objects?
Im chaging objects dinamically and my app stops (crash) if i change an already "thouchAffected" (already configured the binding) object. I think that this is happeing because off the app is looking for "the previous version" of the object (before changing it).

Hello, it seems that a bug, will analyze this. Try set Color and Tap both in one place in code or xaml.
About untrack tap its good idea, I will add that. Now its not provided.
About changing objects could you send me example of code and exception?

Closed due to age


Increment to 3.0.0-snapshot

Signed-off-by: Amit Galitzky<EMAIL_ADDRESS>Description
increment repo to 3.0.0-SNAPSHOT
Issues Resolved
#205
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

the bwc tests fail with a similar error mentioned in BWC Tests failure.
will follow the pr.

@sbcd90 any update on BWC failures here?

@ohltyler , i still face the same error.
updated the issue with more details on the exception.Bwc Test Failure

I'll re-raise after https://github.com/opensearch-project/job-scheduler/pull/208


[Bug]: Duplicated string in the settings page

Affected Version
At least as early as <IP_ADDRESS>, and until the latest version, 1.70.11.
Bug Behavior
In the about section, the license claim is displayed as:
Under MIT License license. All rights reserved.
Expected Behavior
The license claim should be displayed as:
Under MIT License. All rights reserved.
Steps to reproduce

Launch Collapse
Open the side menu and navigate to the settings page
Observe the about section on the right.

Related Issues
No response
Screenshot(s)

Additional Information
This is not a translation side issue since the translation on crowdin is somehow the same as the original text.

Fixed in fixed typo in string.


[Question] in the topology page, app's cpm is not equals to the sum of the caller's cpm

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

from the topology pic, the cpm of baseinfo-provider is 112. we can see, from the app A, tion-provider and users,the cpm is 100+39+2 which is bigger than 112. shouldn't they be equal?

Bug

Which version of SkyWalking, OS and JRE?
skywalking 5.0.0.RC

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

I am sure what is happening, in theory, the incoming should be equal the CPM of node itself.  But I don't know all.


Create stateless-app.md

Signed-off-by: Michael Koranteng<EMAIL_ADDRESS>Describe your changes
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

[ ] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[ ] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

This PR is based on #250
Hi @mikekwabs
Since there is existing file for stateless-apps.md, why don't you edit that file instead of creating a new similar file.

okay sure

Closing this one as there are no changes at all.


Auditing: auditjs added to Travis build

This is a different index than npm/yarn.  Let's see if it catches anything useful, or if it's just noise.

selfie


CDNjs release

@daneden Hey, There should be a release to cdnjs for the new jello animations.

could you make a new release,since the latest relese is alredy 52 comments behind master?
I use codepen A LOT, and it is a bit of a hassle to readd the jello keyframes and classes.

@daneden thanks

@procodeing just released the new tag :)

@daneden Wait. you have to change the base files, and reupdate it manually: https://github.com/cdnjs/cdnjs

I geuss It does not auto-inplement the new update

@daneden so, I guess as soon as you do those commands, it should fix it.

@daneden Actually, I will try and do it for you

@daneden actually, i think its more complacated than that, so I think you have to doo it


Add hex saving via state refactor and new makecode embedding

Keep MakeCode around throughout so we can ask it for a hex file at any point.
Introduce a "Save" action in the toolbar that saves a hex that includes all the data.
Introduce drag and drop load that can restore that hex.
Move project and gesture storage to zustand-managed state. They both affect each other in different circumstances so it's much more manageable to colocate them.
Integrate them with MakeCode via new project @microbit-foundation/makecode-embed so we can make appropriate updates to MakeCode or app state depending on user actions

Code change seems good but this needs a bunch of testing before merge.

[ ] Import dataset file from scratch
[ ] Import dataset file with existing model
[ ] Import hex file from scratch
[ ] Import hex file with existing model
[ ] Import hex file inside of MakeCode
[ ] Blocks edit in MakeCode
[ ] Gesture name edit
[ ] Gesture recording edit
[ ] Threshold edit

I've also barely connected a micro:bit during dev. Likely that code is all unchanged but worth a run through.
The migration to zustand is partial and it makes sense to follow through with all other state that's in context and either move it to be local state or add it to the store.
I'd like to tidy the store code more - particularly gestures which I've just lifted and shifted. It's also potentially much easier to write a meaningful test.

Bug:

Change action name after editing the project
Note rendering updates to show "unknown" for renamed action (I think this is expected after an edit)
But open the project in MakeCode and see the old name, as if the project wasn't updated in MakeCode

For future: "Download all samples before continuing" probably isn't right now for starting a new session, as it will result in the loss of MakeCode code. So we should probably suggest a hex download instead. I think we should make that the only supported format.


SE Writer priority issue when using static content

2.0 master
When I configure routing as follows:
                .register(health) // Health at "/health"
                .register(metrics) // Metrics at "/metrics"
                .register(JsonBindingSupport.create())
                .register("/employees", employeeService)
                .register("/public", StaticContentSupport.builder("public")
                        .welcomeFileName("index.html"))
                .build();

the static content support does not work.
This is caused by discovery of writers - the JSON-B writer accepts any type, including Path.
That means the default Path writer is not triggered, and instead of serving the resource from file system (even though this is classpath, we use file Path if served from path - running from IDE that uses target/classes), it tried to create a JSON from Path.

This is working as designed, the employee-app example is a corner case of writers ordering with a Writer (JsonbBodyWriter) that accepts everything and trumps the built-in writer for Path.
The following changes the employee-app make it work:
diff --git a/examples/employee-app/src/main/java/io/helidon/service/employee/Main.java b/examples/employee-app/src/main/java/io/helidon/service/employee/Main.java
index 94764db63..ad539ff41 100644
--- a/examples/employee-app/src/main/java/io/helidon/service/employee/Main.java
+++ b/examples/employee-app/src/main/java/io/helidon/service/employee/Main.java
@@ -20,10 +20,15 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.util.logging.LogManager;
+import javax.json.bind.Jsonb;
+import javax.json.bind.JsonbBuilder;
+
 import io.helidon.config.Config;
 import io.helidon.health.HealthSupport;
 import io.helidon.health.checks.HealthChecks;
-import io.helidon.media.jsonb.server.JsonBindingSupport;
+import io.helidon.media.common.MediaSupport;
+import io.helidon.media.jsonb.common.JsonbBodyReader;
+import io.helidon.media.jsonb.common.JsonbBodyWriter;
 import io.helidon.metrics.MetricsSupport;
 import io.helidon.webserver.Routing;
 import io.helidon.webserver.ServerConfiguration;
@@ -68,7 +73,10 @@ public final class Main {
         // Get webserver config from the "server" section of application.yaml
         ServerConfiguration serverConfig = ServerConfiguration.create(config.get("server"));
-        WebServer server = WebServer.create(serverConfig, createRouting(config));
+        WebServer server = WebServer.builder(createRouting(config))
+                .mediaSupport(createMediaSupport())
+                .config(serverConfig)
+                .build();
         // Try to start the server. If successful, print some info and arrange to
         // print a message at shutdown. If unsuccessful, print the exception.
@@ -88,9 +96,22 @@ public final class Main {
         return server;
     }
+    /**
+     * Create new {@link MediaSupport}.
+     * @return media support configured with JSON binding support
+     */
+    private static MediaSupport createMediaSupport() {
+        Jsonb json = JsonbBuilder.create();
+        return MediaSupport.builder()
+                .registerReader(JsonbBodyReader.create(json))
+                .registerWriter(JsonbBodyWriter.create(json))
+                .registerDefaults()
+                .build();
+    }
+
     /**
      * Creates new {@link Routing}.
-     * @return routing configured with JSON support, a health check, and a service
+     * @return routing configured with a health check, and a service
      * @param config configuration of this server
      */
     private static Routing createRouting(Config config) {
@@ -100,7 +121,7 @@ public final class Main {
         HealthSupport health = HealthSupport.builder().add(HealthChecks.healthChecks())
                 .build(); // Adds a convenient set of checks
-        return Routing.builder().register(JsonBindingSupport.create())
+        return Routing.builder()
                 .register(health) // Health at "/health"
                 .register(metrics) // Metrics at "/metrics"
                 .register("/employees", employeeService)

This raises the question of media operator order sensitivity for our built-in handlers such as the static content support metrics and health check. Will file a separate issue to track this.

See https://github.com/oracle/helidon/issues/1588

This issue was resolved by #1899 and other media support PRs.


V8 Crash

Hi @ClearScriptLib,
we ran into an issue during starting V8 Engine which caused crash of entire application. The issue was this:

dotnet: /home/jerry/ClearScript/ClearScriptV8/V8IsolateImpl.cpp:1825: V8IsolateImpl::ExecutionScope *V8IsolateImpl::EnterExecutionScope(V8IsolateImpl::ExecutionScope *, size_t *): Assertion `m_spHeapWatchTimer.IsEmpty()' failed.

We never seen such crash in the application, so it must be "unique".

We're investigating that – as well as why assertion code was included in the official build 🤔
Thank you!

Hi @TomasPospisil,
Is the crash reproducible? Do you have a code sample you could share?
Thanks!

Hi @ClearScriptLib,
sorry for late reply. The crash is not reproducible at all, it was just an occasional crash. However it was run on ClearScript version 7.3.4

Version 7.3.7 fixes at least one cause of this crash. Please reopen this issue if you encounter it in ClearScript 7.3.7 or newer builds.


Fixes for usage with a Custom agent

The purpose of this pull request is to help fix a number of issues when using winssh-pageant with a custom SSH-Agent, such as creating an SSH-Agent using the golang.org/x/crypto/ssh/agent library.
Custom Windows SSH-Agent Deadlock issue
I ran into an issue when using winssh-pageant with a custom SSH-Agent which abruptly would deadlock and crash winssh-pageant, I've detailed the issue at the following link, https://github.com/ndbeals/winssh-pageant/issues/10
The simple solution has been to replace,
https://github.com/ndbeals/winssh-pageant/blob/ff92839d336da9b51525796b80f51ed380176551/main.go#L30-L34
With,
https://github.com/ndbeals/winssh-pageant/blob/fd229a282869b09aabad860d21996bd72314e5b5/main.go#L31-L36
Bufio Read Issue
A second issue relates to when a PuTTY client makes an initial list query to the SSH-Agent.
This starts with a write operation to the SSH-Agent https://github.com/ndbeals/winssh-pageant/blob/ff92839d336da9b51525796b80f51ed380176551/internal/sshagent/agent.go#L26
This is then followed by a read operation from the SSH-Agent, listing all the keys https://github.com/ndbeals/winssh-pageant/blob/ff92839d336da9b51525796b80f51ed380176551/internal/sshagent/agent.go#L34
The current code relies on all the key data being sent in a single read operation using bufio, however I ran into issues when using this with my custom SSH-Agent, as only the first 4 bytes of data was being returned (I later found out these 4 bytes are magic numbers - I think related to the named pipe).
I did some digging around, and according to the ssh-agent protocol specification ,
https://github.com/openssh/openssh-portable/blob/4e636cf201ce6e7e3b9088568218f9d4e2c51712/PROTOCOL.agent#L379-L387
So I've simply modified the code by breaking it into three distinct read functions, the code is
https://github.com/gazzenger/winssh-pageant/commit/c06f2e864e3088a0b46ff06ea6698a91c8d5cb18#diff-ee5318b37f84592ca501ef36813158b2096992143f93f41eec1b6a0f7205f12cR34-R74
These three read functions,

Read the magic number,
Read the SSH2_AGENT_IDENTITIES_ANSWER,
Read the number of keys, and
Read all the key information in a single read operation
This has been tested and works with both my custom SSH-Agent as well as with Windows OpenSSH

Many thanks,
Gary

The bufio changes look good and they are well documented, nothing further is needed for those.

Hey thanks for looking over the code,
I found using either
runtime.LockOSThread()

or
msg := (*win.MSG)(unsafe.Pointer(win.GlobalAlloc(0, unsafe.Sizeof(win.MSG{}))))
defer win.GlobalFree(win.HGLOBAL(unsafe.Pointer(msg)))

worked well to prevent the deadlock.
The deadlock issue is also resolved when I try running the code with both of these together.
Happy with both put both your suggestions
https://github.com/ndbeals/winssh-pageant/pull/11#discussion_r666158316
https://github.com/ndbeals/winssh-pageant/pull/11#discussion_r666162662
If you're happy I can put both in an update to the pull request
// main message loop
runtime.LockOSThread()
hglobal := win.GlobalAlloc(0, unsafe.Sizeof(win.MSG{}))
msg := (*win.MSG)(unsafe.Pointer(hglobal))
defer win.GlobalFree(hglobal)
for win.GetMessage(msg, 0, 0, 0) > 0 {
	win.TranslateMessage(msg)
	win.DispatchMessage(msg)
}

Let me know.
-Gary

I've committed the suggestions I made, so if you'd like to add the runtime.lockosthread to the code in a further commit you author, please do so!
otherwise I'll wait a few hours and add it myself. Thanks again for all this work you've done :)

Nathan

Also, this is minor and optional, The user "gnamestnik" is responsible for authoring the first commit in this PR. I assume that's you, it's just the git history isn't pointing to the right email, so github doesn't know it's you "gazzenger"?
If that's the case, and if you want to you can re-write the git history so it attributes the commits to the correct account.

Also, this is minor and optional, The user "gnamestnik" is responsible for authoring the first commit in this PR. I assume that's you, it's just the git history isn't pointing to the right email, so github doesn't know it's you "gazzenger"?
If that's the case, and if you want to you can re-write the git history so it attributes the commits to the correct account.

Yep, I mistakenly didn't set the Git Config info correct.
I'll just leave it as is.

Thanks again @gazzenger

New version pushed, find it at https://github.com/ndbeals/winssh-pageant/releases/tag/v1.3


Some libraries generate confusing errors when opening CloudPath objects

The main problem is the libs based on opening files with fsspec won't work properly with CloudPaths.
They will call fspath to resolve it (instead of str()) and therefore the file called will be cached (this is not exaclty what we want, and this will be done silently)
For single files like tif this will be not optimal but will work (your example)
But for nested files likes VRT, this will crash as only the header is cached and not the relative files. This will break the paths inside the VRT.
Note that GDAL (and therefore rasterio) can read VRT stored on the cloud, and this is the expected behavior.
A little example:

vrt = AnyPath("https://s3.unistra.fr/merge_32-31.vrt")
rasterio.open(str(vrt)) # will work
rasterio.open(vrt) # will fail for the wrong reason, saying that the files linked inside the VRT don't exist

Originally posted by @remi-braun in https://github.com/drivendataorg/cloudpathlib/issues/96#issuecomment-1402068539

There aren't great options here. This is what I see. Open to other options if people have them. Maybe some combination of these are good mitigations.
Stop being os.PathLike
A lot of these libraries do something like:
def open(f):
    is instance(f, os.PathLike):
        str_path = os.fspath(f)
    ...

They then have special-case logic to handle str_path and work with the local filesystem path. This only works with CloudPaths in read scenarios for single files. Other scenarios (writing, multi-file formats, directory walking) are all broken with code that works like this.
When the code eventually goes looking on the filesystem relative to str_path it errors in potentially confusing ways.
If we are no longer os.PathLike then code will likely error earlier with clearer error messages.
Pros:

Possibly clearer error messages

Cons:

Breaks single-file read scenarios, which are very common.

Cache entire directory on fspath call
We could do something like the following (and make this an option)
def __fspath__(self):
    if self.is_dir():
        self.download_to(self._local)  # cache entire directory recursively on `fspath` call

Pros:

No missing files when relative ones are referred to.
Could be optional based on setting/envvar

Cons:

Likely a lot of wasted network traffic and disk space usage (depending on what is in the directory)

Warn on __fspath__ being called
We could just always warn about writing/multi-file whenever __fspath__ is called.
def __fspath__(self):
    warnings.warn(f"File {self} has been converted to a local path; writing and uploading or opening multi-file formats will not work as expected.")
    ...

Pros:

Raise awareness of what might not work as expected earlier

Cons:

Pollutes logs/warnings stream for the many scenarios where things do work as expected

Try to detect who is trying to do what and how and raise errors in those cases
We may be able to provide more useful errors if we can detect who is calling .str, .__fspath__ or the built-in open function.
Pros:

We can raise Exceptions for scenarios that will not work

Cons:

Implementation is fragile even if it does work; we did an extensive look at this in #128 and #140, and the proposed implementation that is traceback based is very fragile and hard to maintain.
Lots of maintenance burden to track which scenarios and libraries need to have exceptions raised.

Provide documentation for other library developers to support CloudPaths
The best way to support CloudPaths is for developers to just use the pathlib API throughout their code base.  Since we support the majority of the pathlib API, then most code should work reasonably.
We could add a documentation page with recommendations on how to do this effectively. We could provide code snippet examples. Here are the key points:

Move from using os. methods for path manipulation to the pathlib API
Convert passed strings into Path or CloudPath objects immediately
Keep paths as *Path* objects as long as possible. Don't do calls to str or fspath until you absolutely need to open a single file.

Pros:

We could do this today.

Cons:

Requires implementation changes in other libraries before any end-user results.

Coordinate a sentinel convention to trigger fsspec code
We could potentially have a sentinel _fsspec property that indicates to a library they should open with fsspec. For example:
# in cloudpathlib

@property
def _fsspec(self):
    return str(self)

# in fsspec
def open(f):
    if hasattr(f, '_fsspec'):
        f = f._fsspec

# in other libraries
def open(f):
    is if hasattr(f, '_fsspec'):
        handle = fsspec.open(f)
    ...

Alternatively, fsspec write a shim to handle CloudPath objects:
# in fsspec
def open(f):
    if isinstance(f, CloudPath):
        str_cloud_path = str(f)
        ... # dispatch with normal `fsspec`

Either would require that third parties pass the object to fsspec without manipulating it first (e.g., they should not call str or fspath).
Pros:

CloudPath objects play nicely in the fsspec ecosystem

Cons:

Requires coordination across libraries/maintainers
Still requires implementation updates for other libraries

Just to add that the workaroud is for the user to pass str(cloudpath) to the problematic libraries, so this is not urgent (I think).
But it would be very comfortable to have a universal way of handling cloud paths (I cannot help you for that, this is way beyond my skills haha)

Good point, thanks for adding!

FWIW I'm working on adding a pathlib.AbstractPath class in the standard library. If that's introduced, and libraries like cloudpathlib start subclassing it, then other code can do:
def do_thing(path):
    if not isinstance(path, pathlib.AbstractPath):
        path = pathlib.Path(path)
    with path.open('rb') as f:
        ...

In this way, functions can accept string paths, pathlib.Path objects, and any other objects that inherit from pathlib.AbstractPath and therefore provide an open() method.
FWIW, I'm also planning to make __fspath__() a Path-only feature (not present in PurePath or AbstractPath) so that open(ZipFile('README.txt', archive=ZipFile('foo.zip'))) doesn't try to open README.txt in the current directory, which would be massively confusing.

Thanks @barneygale! Yes, we'd support having a way to signal pathlib API compatibility in the standard library so that we can signal to third part libraries to treat us like a path (which really helps with the problems listed above about people calling os.fspath too early.
Will os.PathLike still be dependent on __fspath__ being implemented? I guess in that case we would want to do is not be os.PathLike so that we don't get fspath'd, but  be an AbstractPath so we signal to libraries to use pathlib functions.
Let me know if we can help testing or reviewing anything there.
(That said, this still puts us in the "get other library maintainers to rewrite their code to use/support pathlib APIs" solution bucket.)

I'm not planning to change anything about os.PathLike, os.fspath() or __fspath__(), except that I'll move PurePath.__fspath__() to Path.__fspath__(). The proposed AbstractPath would sit between those classes, so it wouldn't have __fspath__(), and therefore wouldn't be path-like. This will require a proper deprecation process in CPython (2 or more minor releases) in which we raise warnings from PurePath.__fspath__().
I think it's a losing game trying to provide __fspath__() in other path implementations - it's impossible to know exactly how the function that calls os.fspath() intends to use the resulting string path. You can do clever things with caching of course, and unfortunately that's going to be necessary for at least another couple years.


Add horizontal swing modes

@bigmoby not sure if this will be ok on a unit that does not have the horizontal swing mode. Please test.

Hi @drc38 thank you for this PR! 🙌

The next this, please, run pre-commit check ;-)
pre-commit run --all-files


Hunting queries windows event batch5

Required items, please complete
Change(s):
Add Windows Event Data to the following Hunting Queries:
Hunting Queries/SecurityEvent/HostsWithNewLogons.yaml
Hunting Queries/SecurityEvent/UserAccountAddedToPrivlegeGroup.yaml
Hunting Queries/SecurityEvent/UserAccountCreatedDeleted.yaml
Hunting Queries/SecurityEvent/VIPAccountFailedLogons.yaml
Hunting Queries/SecurityEvent/WindowsSystemTimeChange.yaml
Hunting Queries/ThreatIntelligenceIndicator/FileEntity_SecurityEvent.yaml
Reason for Change(s):
Part of adding Windows Event data source project
Version Updated:
No
Testing Completed:
Yes
Checked that the validations are passing and have addressed any issues that are present:
Yes

@aprakash13  Please review hunting queries. thanks.

@oshezaf Please check and approve the changes, thanks.

@oshezaf can you please take a look and provide your feedback. thanks!!

Hi @oshezaf
Can we close this and reopen whenever required as you have labelled it as differed.
Thanks

Hi @oshezaf
Thanks for closing the differed PRs.
Can you also close remaining differed PRs (#4157, #3758, #2699, #4253, #4332).
Thanks

I closed 2 and left 2 intentionally open. Note that #4332https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F4332&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Kr%2FD5k6bxdMrFzGOwySTA%2FKH30m3c8p%2BTupbEuzRL2A%3D&reserved=0 is not mine.
From: Meena Kumari Chatla @.>
Sent: Thursday, September 8, 2022 2:31 PM
To: Azure/Azure-Sentinel @.>
Cc: Ofer Shezaf @.>; Mention @.>
Subject: Re: [Azure/Azure-Sentinel] Hunting queries windows event batch5 (PR #4253)
Hi @oshezafhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foshezaf&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=De%2BTRSaHGbypHicrFfBKQ1MgG3Z7z%2FvPTEvDzm58qrY%3D&reserved=0
Thanks for closing the differed PRs.
Can you also close remaining differed PRs (#4157https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F4157&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OWsOMZUnXM0mMGUACJi%2F%2F7X%2FVNfY%2BK1tmVqHUVNHYio%3D&reserved=0, #3758https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F3758&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=C3mC%2B7TlwoF0cdH5XwUwQuRixqtgZXNu%2FlANOqkXDVg%3D&reserved=0, #2699https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F2699&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=lD3AeIQ75UkhvTN8AtuLF9sbxzX1ZUpR9PngsRMJyes%3D&reserved=0, #4253https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F4253&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=jRGlvb%2BVyKAfKoR7ihkV8r4HH%2FfBQG93z%2FH2F1LNBig%3D&reserved=0, #4332https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F4332&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Kr%2FD5k6bxdMrFzGOwySTA%2FKH30m3c8p%2BTupbEuzRL2A%3D&reserved=0).
Thanks

Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FAzure-Sentinel%2Fpull%2F4253%23issuecomment-1240591152&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Yqwc%2FjI0%2FmbgOYfqkwE5ZWSCVKidB6dae1wNgxT2pdg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJRE5IIID2NSBEXO4LHOHD3V5HE57ANCNFSM5PEYIOXQ&data=05|01||1caa38654a0d40eb74f608da918d8f25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637982334417732182|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=BpoWS539%2BSrYpSN%2B6A5rd2ngtNIN8j0TL35hNILVQl0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Promote GEP-957 to standard channel

What type of PR is this?

/kind gep
What this PR does / why we need it:
GEP-957 should be moved from experimental to standard channel.
Depends on: #2775
Which issue(s) this PR fixes:

Fixes #957
Does this PR introduce a user-facing change?:

Attaching routes to gateways by port number (GEP-957) feature moved to standard channel.

Thanks @frankbu! With #2775 merged, this is good to go. Will defer to someone else for final LGTM.
/approve

Hit it! 🙂
/approve

/hold cancel


Fixes embedded dylibs/frameworks only run on iOS8 warning by ignoring linker warnings

XCode6.1 (falsely) warns that dylibs don't work on <iOS8. Suppressing this warning with linker flags for now.

While dynamic frameworks may run on iOS 7, App Store submission will be rejected (TestFlight too) if a bundled framework is not built with a deployment target of iOS 8+, see realm/realm-cocoa#900 and Hearst-DD/ObjectMapper#23 for other cases of this. The realm team worked around this by creating a static framework target for iOS 7 and dynamic framework target for iOS 8 use, or one could of course just pull the files in directly.
So quieting the warning masks the issue a bit no?

@pizthewiz that is a good point. Personally for apps that I have to support iOS 7 on, I have just been pulling the files in directly. I know that isn't ideal, but since iOS 7 is going probably fall off as a "supported development version" when iOS 9 drops, it might be an ok compromise. If there is the demand (or a pull request), I could see creating a static lib like realm has done.

for apps that I have to support iOS 7 on, I have just been pulling the files in directly

Yep, that technique has been suggested for the ObjectMapper library too. It could be more formalized by setting the framework deployment target to iOS 8 and add a mention in the README - this would at least put iOS 8 on the fully supported path. The current form of the framework target is not usable for App Store submission for iOS 7 or iOS 8, and suppressing the warnings just further obscures the core issue no?

Agreed. The README should probably update to reflect this. That is a good point, I will change the framework to allow this as well. Thanks for bring it up.


[Ulm] Data

http://tsu-app.rrooaarr.biz/front/

Also see http://www.ulmapi.de/news/2016/03/05/inoffizielle-parkapi.html

The PR #198 is using https://www.parken-in-ulm.de/ which currently seems to be the better Option since we don't want to make a single request for each parking lot.


file extension

The file extension has been updated and already published, but needs to be reviewed.
https://github.com/stac-extensions/file

Going to review

Review complete

Released


How to set reserved names in the JS → Options for UglifyJS2?

How to set reserved names in the JS → Options for UglifyJS2?
thanks.

Hey!
I had a look at my code. This feature is not supported right now.
But as far as I can see it's not supported by UglifyJS2 in node.js version, only in CLI.


[PCC-144] Implement Keycloak authentication for API security

I tested it locally and no issues occurred.


The Xs and Ys of the character are weird

Describe your problem here.
So I finally managed to get my stage assets to load but when I open it the characters are all misplaced even though I used the same that were in Flash in fact all the stage assets are placed correctly. This is how it's supposed to look like

And how it looks in game
image_1
image_2)
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Animated Icons, GameJolt, Main menu characters

BF has a Y Offset by default (350)
Can't help with your custom character because you posted none of your files

Spritesheet
xml n json


powershell: Unable to use as a login shell

Issue description
Attempting to add unstable.powershell to environment.shells or users.extraUsers.<username>.shell results in the following error:
error: /nix/store/4km9l5rdin6iz57g3p229v92jbl1cg5w-powershell-6.0.4 is not a shell package

Steps to reproduce
Add the following to your configuration.nix:
let
 unstable = import <unstable> {};

{
 environment.systemPackages = [ unstable.powershell ];

 environment.shells = [ unstable.powershell ];

 users.extraUsers.test = {
  isNormalUser = true;
  uid = 1000;
  shell = unstable.powershell;
 };
}

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.67, NixOS, 18.03.133174.edd63e05d1e (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0.4`
 - channels(root): `"nixos-18.03.133174.edd63e05d1e, unstable"`
 - channels(amandac): `"nixpkgs-18.09pre150352.7c826371c49"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

passhtru.shellPath would need to be defined for powershell, see, for example, fish:
https://github.com/NixOS/nixpkgs/blob/03b89e3031bb983fcc59a9f7794157e2e7b67102/pkgs/shells/fish/default.nix#L172-L174


SARAALERT-888: Monitoring status refactor 2.0

Description
Jira Ticket: SARAALERT-888
Duplicate of this PR: https://github.com/SaraAlert/SaraAlert/pull/450

Doing a final pass through and found one small issue so far that should be a quick fix. When changing monitoring status from Not Monitoring to Active Monitoring for a HoH, it should not say "will turn continuous exposure OFF for all household members" because we're re-opening them. Should only say then when closing them.

Doing a final pass through and found one small issue so far that should be a quick fix. When changing monitoring status from Not Monitoring to Active Monitoring for a HoH, it should not say "will turn continuous exposure OFF for all household members" because we're re-opening them. Should only say then when closing them.

done


Test gcs urls with spaces and %20

👍

@cjllanwarne I removed the static references to gcs files

:+1:


latest preflight binaries fails to run on rhel8 machines with glibc error

Bug Description
latest preflight binaries fails to run on rhel8 machines with glibc error
Version and Command Invocation
(The output of preflight --version)
Steps to Reproduce:
(How can we reproduce this?)

Download latest 1.6.8 preflight
Run the preflight on rhel8 mchine

Expected Result
Partner should be able to run preflight
Actual Result
[root@dhcp210-254 viksss]# ./preflight-linux-amd64 -v
./preflight-linux-amd64: /lib64/libc.so.6: version GLIBC_2.34' not found (required by ./preflight-linux-amd64) ./preflight-linux-amd64: /lib64/libc.so.6: version GLIBC_2.32' not found (required by ./preflight-linux-amd64)
Additional Context
(Anything else you think might help us troubleshoot, like your platform, dependency versions, etc).

May be related to the upgrade of the Go version we compile with -
https://github.com/redhat-openshift-ecosystem/openshift-preflight/commit/1f72aa2f5b111e1e201eadd89e11ad0ca4bc7310#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557
@acornett21 Looks like Go is doing some linking that got resolved in the containerized version, when we upgraded to ubi9, but still needs to be resolved in the binary version.
@vikasmulaje as a temporary WA, should be possible to use the containerized Preflight.

This is correct. As of Go 1.20, our binaries, which are dynamically linked, require equivalent libc available at the execution machine. The 1.20 Go build tooling seems to make different assumptions about CGO_ENABLED. For the time being, you can build off of main with CGO_ENABLED=0 which should work, but we haven't tested this yet. We'll likely move that direction, as the issue @itroyano links suggests.

Closing this as duplicate, since we are already working on the other linked issue.


Refactor flatten function implementation

Remove depth from the  initial implementation
Use a predicate to determine whether an item should be considered a leaf node or not

Coverage decreased (-0.01%) to 95.025% when pulling e6cf75500230c412248fe4eb0bddec7360958ca9 on skabbass1:master-refactor-flatten into 49718594eb11f9cedb976bb6d86ea28da0c2017c on jackfirth:master.

Coverage decreased (-0.01%) to 95.025% when pulling 7b9b2058eef792d341a1097bffaf0f2e267463e8 on skabbass1:master-refactor-flatten into 49718594eb11f9cedb976bb6d86ea28da0c2017c on jackfirth:master.


Fix #340 and #341, update README with info about pre load NP

Please see my notes in #340 and #341

Judging by the comments, it seems that you probably know what you're doing & is capable of doing so. And you're of great help answering people's issues.
Since most of the current contributors are overwhelmed by their real life^tm, myself included, I think maybe you're willing to help people here, trying to support this codebase and people in your free time.
Would you like to be a collaborator for this repo? Even managing issues only (open, answer, close, label duplicate) is of great help for anyone who's using this script.
Of course, I'll have to ask others first.
@potchy  @ryuga93 @TryBane
What's your take?

@29988122 First of all, I'm a professional Java programmer and have some experience with Git and Github through my contributions to the saltbot project, which is written in Typescript. I don't have experience with Lua and so far it seems really restrictive, but we can't do anything about it because of Ankulua.
I'm a bit stressed by work since most Pull Request I get there have lots of bugs or wrongly implemented features, but I still can manage to do a bit of Open Source programming in my free time.
I'd gladly accept the collaborator role, I would just need to know if there are any guidelines for handling Pull Requests related to code reviews. And I just found the naming conventions in CONTRIBUTING.md, so I will rename the debug_mode to Debug_Mode in this Pull Request. At least that's how I understood the naming rules.

Thanks for fixing my mistake. I didn't realize the debug mode would cause an issue in JP since I had wholly forgotten about its existence (especially since I only ever used it to debug problems people had) so it never occurred to me it would cause a bug in the other versions.
Also, since I never use first for Support selection, I completely overlooked the affect deleting that click would have, so again thanks for fixing that.
If the guy is helping with fixing bugs or adding features, I have zero issues with him coming in as a collaborator. I haven't been able to help answer questions or even check the issues posted recently so I appreciate the help he has provided in that regard as well. Seems like he would be a good addition.

@TryBane One thing I wanted to mention is that the friend support selection using image detection is behaving weirdly after I updated to the new version. It doesn't detect any CE support matches without scrolling down. And it's going through the list much faster.
I will take a detailed look at the recent changes after I get home from work today.

I have noticed this as well. I've been able to solve the issue somewhat by adjusting the similar() method used in Pattern, but there have been cases of false positives (which is what led me to make the original adjustment in the pull request prior). I think the current best option will be to reduce the similar value back to what it was, so that people have less issues in this regard.

@TryBane Can confirm, see my latest commit to revert your changes. A value of .8 will detect MLB CEs, .85 will not.

Sounds good. I expect false positives will be a thing again at a later date, but this is unavoidable with the current format without making the userbase as a whole deal with problems.

I'm doing a merge commit again as I think your original commits each have meaningful messages and references to other issues. Thank you for your interest and help!

@29988122 @potchy Any update on the collaborator role? I would really like to add some labels to Issues and close some.

Oh, I think only @29988122 (please show up!) can assign roles, as I don't have access to the "Settings" pane.

Oh, I think only @29988122 (please show up!) can assign roles, as I don't have access to the "Settings" pane.

I thought you don't agree with that decision XD
Now I get it.
Collaborator role added, @reconman  助手よ存分に働け！(Work tirelessly to die, my assisstant!)


Better link name in GetAnalysisTask notification

Signed-off-by: Roy Golan<EMAIL_ADDRESS>

/lgtm


Map several simple potato entities and blocks.

First yarn contribution!

Hi, many thanks for this PR, sadly it seems to have a lot of overlap with #3831 from @Shnupbups, I did a quick spot check and it seems most of the names are identical so thats great 👍
Im not sure what the best way forward is, it might just be easier to merge #3831. I dont like to close PRs especially when there is nothing wrong with it and it would normally be fine to merge, #3831 was first so this seems fair to me. Sorry about this, I hope you understand.

np! gonna be honest i didnt even check other prs before i made this so its kinda my fault


Docker should not substitute <IP_ADDRESS> name server when using --net=host

When /etc/resolv.conf contains nameserver <IP_ADDRESS>, docker creates a custom resolv.conf in the container with the google name servers (<IP_ADDRESS> and <IP_ADDRESS>).
This is not always a good solution, as those name servers might not be reachable, or might not return the same records as the name server on <IP_ADDRESS> (#14627 is a more general purpose issue in regards to this issue). However when using --net=host this substitution is not necessary.
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This appears to not be happening w/: Docker version 1.6.2, build 7c8fca2, but I'm still confused on how to get around this substitution during the docker build. I plan to run all my containers w/ --net=host and plan to bypass all the NAT'ing or interface linking craziness, but I can't wrap my head around how to convey this at the image building phase.
For instance, we host all of our own apt repos. Here's our sources.list
deb http://repo:9000/repo trusty main restricted universe multiverse
deb http://repo:9000/repo ix-trusty main

I need to install apt packages from this repo, but any changes I make to /etc/resolv.conf to force them back to <IP_ADDRESS> are lost on the next Dockerfile line.
@phemmer did you run into this problem when making images?

There is no workaround for docker build. Though for docker build I would follow #14627, which will probably implement something like a DNS proxy. With --net=host, a proxy is not necessary, and thus the solution is different.


SID Apps- Request to Conduct QA for ANC tests

This is a request to do QA on the ANC Tests on the ANC Module.
Here is a link  to the APK.
Here is a link to the Data Dictionary for reference.
We are only developing tests for the below items as shown on the screenshot:

please move to https://github.com/onaio/fhir-resources/

@MargaretNjenga
All expected conditions recorded as positive reflect on the profile page of the patient except for the TB screening Test.
NB
After filling in a test the status does not change to done the status remains the same and one can still fill in the test.


Add multi stage discovery proposal

This proposal aims to specify a way to do multi stage device discovery

Don't seems to be needed in fact


GoogleCloudMlV1_PredictRequest  Mount Wrong URL

Environment details

Programming language: Elixir
OS: macOS 12.1
Language runtime version: Elixir 1.13.1 (compiled with Erlang/OTP 24)
Package version: {:google_api_machine_learning, "~> 0.28.0"}

Steps to reproduce
Can run this livebook
https://gist.github.com/danieldocki/6b063661eee1062be322b9711f5b0814
the error is in the formation of the URL, as you can see in the error below
{:error,
 %Tesla.Env{
   __client__: %Tesla.Client{
     adapter: nil,
     fun: nil,
     post: [],
     pre: [
       {Tesla.Middleware.Headers, :call,
        [
          [
            {"authorization",
             "Bearer TOKEN"}
          ]
        ]}
     ]
   },
   __module__: GoogleApi.MachineLearning.V1.Connection,
   body: "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"Field: name Error: The name should be a model or a version resource name, e.g 'projects/your-project-id/models/your-model-name' or 'projects/your-project-id/models/your-model-name/versions/your-version-name'.\",\n    \"status\": \"INVALID_ARGUMENT\",\n    \"details\": [\n      {\n        \"@type\": \"type.googleapis.com/google.rpc.BadRequest\",\n        \"fieldViolations\": [\n          {\n            \"field\": \"name\",\n            \"description\": \"The name should be a model or a version resource name, e.g 'projects/your-project-id/models/your-model-name' or 'projects/your-project-id/models/your-model-name/versions/your-version-name'.\"\n          }\n        ]\n      }\n    ]\n  }\n}\n",
   headers: [
     {"cache-control", "private"},
     {"date", "Thu, 13 Jan 2022 12:27:53 GMT"},
     {"accept-ranges", "none"},
     {"server", "ESF"},
     {"vary", "X-Origin"},
     {"content-length", "711"},
     {"content-type", "application/json; charset=UTF-8"},
     {"x-xss-protection", "0"},
     {"x-frame-options", "SAMEORIGIN"},
     {"x-content-type-options", "nosniff"},
     {"alt-svc",
      "h3=\":443\"; ma=2592000,h3-29=\":443\"; ma=2592000,h3-Q050=\":443\"; ma=2592000,h3-Q046=\":443\"; ma=2592000,h3-Q043=\":443\"; ma=2592000,quic=\":443\"; ma=2592000; v=\"46,43\""}
   ],
   method: :post,
   opts: [],
   query: [],
   status: 400,
   url: "https://ml.googleapis.com/v1/projects/PROJECT_ID%2Fmodels%2FMODEL_NAME:predict"
 }}

was expected to assemble the URL
https://ml.googleapis.com/v1/projects/PROJECT_ID/models/MODEL_NAME:predict

This seems to be a breaking bug for the MachineLearning client. I can't find a way to specify a project and a model name. If I'm missing something, I'd love to know so I can use the library to access these services. Right now, I seem to always get PERMISSION_DENIED CONSUMER_INVALID when trying to just use the project id like the code seems to indicate.


[WIP] longer event names

I'm working on U.S. Congressional Hearings right now, and some of these event names are very long. This PR increases the length to accommodate these long names.
This is a WIP, because I want to make sure that 600 characters will actually be long enough and I'm not completely done with my scrape yet.

Coverage remained the same at 98.82% when pulling fcf97b949e35d5e9bb46435b6b2b86d625d24ed9 on longer_event_names into 840a9037e81fdba8ec6344192d22149a469ab559 on master.

Coverage remained the same at 98.82% when pulling fcf97b949e35d5e9bb46435b6b2b86d625d24ed9 on longer_event_names into 840a9037e81fdba8ec6344192d22149a469ab559 on master.

Coverage remained the same at 98.82% when pulling fcf97b949e35d5e9bb46435b6b2b86d625d24ed9 on longer_event_names into 840a9037e81fdba8ec6344192d22149a469ab559 on master.

Coverage remained the same at 98.82% when pulling fcf97b949e35d5e9bb46435b6b2b86d625d24ed9 on longer_event_names into 840a9037e81fdba8ec6344192d22149a469ab559 on master.

Coverage remained the same at 98.82% when pulling fcf97b949e35d5e9bb46435b6b2b86d625d24ed9 on longer_event_names into 840a9037e81fdba8ec6344192d22149a469ab559 on master.

want to just go to 1000? seems like the only purpose of the limit is to make sure someone doesn't accidentally set the title to the entire Wikipedia corpus

@fgregg need a release of this?  I can put out a 2.3.0 in a bit if so


XSUAA 2.13.5 compatible with spring boot 3.0.x?

Hi,
I have seen that in the latest release 2.13.5

Bump spring.boot.version from 2.7.5 to 2.7.8

Does it mean that it is not compatible with the spring boot 3.0.x (spring security 6.0)?
We try to upgrade to spring boot 3.0.0. I have begun the migration and then confronted an error:
java.lang.AbstractMethodError: Receiver class com.sap.cloud.security.xsuaa.token.authentication.XsuaaAudienceValidator does not define or inherit an implementation of the resolved method 'abstract org.springframework.security.oauth2.core.OAuth2TokenValidatorResult validate(org.springframework.security.oauth2.core.OAuth2Token)' of interface org.springframework.security.oauth2.core.OAuth2TokenValidator.

It looks like the code in spring boot 3 and spring boot 2.7.8 has some minor difference.
If it's not compatible with spring boot 3.0.x, I may have to stop the migration.
And #809 here, it is said that

The migration to Spring 6 , Spring boot 3 is planned for 2023 Q2
Do you have any update for it?

Many thanks in advance :)

Hi @Danli741,
no it's not compatible, we do not support yet Spring boot 3.x nor the Spring 6.x nor the Java 17 which is required for the latest major versions of Spring, but It is still planned to deliver the upgrade in Q2.
Kind Regards,
Liga


SceneLoader.LoadAssetContainer should grab environment texture

Feature request
Debatable whether this is a bug or not, so I made it a feature request. If you call BABYLON.SceneLoader.LoadAssetContainerAsync with a .babylon file that specifies an environment texture, this texture does not get loaded into the asset container. I'm guessing this is because AssetContainer does not share Scene's environmentTexture property.
Possible solutions
Any of the following solutions would be acceptable. I would probably prefer (1).

Move the environmentTexture property into AbstractScene and make sure SceneLoader populates it on the AssetContainer.
If the .babylon file has an environment texture, load it into either the textures array or the reflectionProbes array of the AssetContainer.

Thinking about it some more, only solution (1) makes it straightforward to implement addAllToScene, since if the environment texture is just sitting in the textures array, it's not clear how the asset container will know to make it the environment texture of the scene.

Unfortunately 1 would imply a breaking change so this is not acceptable.
I would prefer having an environment texture property on the asset container that will be used when user call addAll
@trevordev thoughts?

Check out #6019 for a related issue with the AssetContainer.

Yup, 1 sounds right to me as well
Working on fixes for these issues now


Integration not showing in HACS

Instakked HACS on a Pi docker container and when I search for new integrations in HACS there is no sign of Hive.
To Reproduce
Click on HACS / Click on add integrations / Search for hive
Expected behaviour
Hive custom integration offered to install
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

HACS version 1.12.4
HASS version 2021-5.5

For whatever reason - it has now appeared and installed. Sigh.
I can only think it was because I had a crash on my host and did a full restart of everything to get all my dockers back.

If you just installed HACs it can take some time for the HACs to initialise and download the available components


Removed jackson.databind

User Story 3752052: [SDK][Java] Migration to azure-json in Communication libraries
Removed jackson.databind and replaced it with azure-json in the OutStreamingData class.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-communication-callautomation


bin/tarsnap-backup: ShellCheck

Apply ShellCheck recommendations:

Double quote variables to prevent globbing and word splitting
Use $(..) instead of legacy `..`
expr is antiquated. Rewrite using $((..))
Fix if [ -n something_wrong ];

LGTM, but currently I cannot test this (AFK for about a week). Have you tried running the fixed script, just in case?
Thanks!

Yes, it runs on a server everyday (installed as a package)... thank you!

Awesome, thanks.


Feature request: Allow principal:// usage

The module currently does not support providing principals in the format:
principal://iam.googleapis.com/${var.pool_name}/subject/${local.value}
Please add support for using not only principalSet://, but also principal://.
Additionally, there is a need to use more than two fixed attributes "attribute.sub" and "attribute.repository".
The lack of this capability required a lot of time to identify the problem with 403 .
Issue with GutHub Actions

The module is intended to provide a simple option. If you want to do more customization and you are sure what you are doing, you can of course use the actual Terraform resource.
principalSet is listed for attribute values in the official documentation:
https://cloud.google.com/iam/docs/workload-identity-federation#principal-types
And is also used by colleagues from Google Professional Services:
https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/fast/stages/0-bootstrap/identity-providers-defs.tf#L46
I personally also never had a problem with principalSet (like 403).


[RocketChat] Customize the Home page message

Number of Volunteers: 1
Need to check with Dan & PCs about the message.

We should put the list of channels on the Home Page, e.g.,

announcements, firsttimers, ...
workshop-xxx
tutorial-xxx
sponsor-xxx
keynote-xxx

We should also put the CodeOfConduct and etc. on the Home page for visibility.

@hao-fang I could do this. Do we have a list of channels somewhere already?

@vladdy We are collecting the information https://docs.google.com/spreadsheets/d/1S3u6Q401kDyyqXL1SEPBOIHawqHDEUN4F-B0KxOraLQ/edit?usp=sharing
Once it is ready, we can see how we should advertise these channels. I think the issue is with ~800 channels for papers, the user will not be able to browse all the channels and decide which one to join.
Let me know if you have any thoughts.

I wonder if we could create links to the channels from the pages with article info, but on the other hand 800 channels appears to be something hard to manage. Do you have any thoughts about that?
In the meantime let me know if there is something I need to do.

I wonder if we could create links to the channels from the pages with article info, but on the other hand 800 channels appears to be something hard to manage. Do you have any thoughts about that?

Our webpage for a paper looks like this. (You can go to virtual.acl2020.org to see what it looks like currently as well). The user will join the channel for the specific paper on the webpage.

So we probably only need to list channels that do not have an entry point on the webpages, which would be things like helpdesk, firsttimers, etc.

In the meantime let me know if there is something I need to do.

I think the top priority on your plate is #55 .

I created a shared doc here https://docs.google.com/document/d/1lNx8wbkDlAmm-P8g9vVGKH15NWRGNifFwLt2TO0MYEc/edit and have started listing relevant channels from the ACL2020 RocketChat doc.

@anaerobeth Thanks a lot! Let me know when you have a draft and I'll send it over to the committee to review.

@hao-fang @vladdy I added some information and comments to the shared doc. Let me know if I missed anything.

@anaerobeth -- Thanks! I'll get back to you in a few days. Need to sort out some other things first.

@anaerobeth Thanks a lot for working on this. Unfortunately I don't have enough time to update it in the RocketChat.
So I simply turned off the Show "Home Button" option.
Sorry about missing this.. and you have made a lot of other great contributions to our website!


⚠ Turnos 24x7 has degraded performance

In 86689f4, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 935 ms

Resolved: Turnos 24x7 performance has improved in 6e65946.


Publish on Homebrew

I'd love to see this tool available via Homebrew :+1:

Yeah, I have some incompatible protocol changes in the works (removing the distinction between "Initiator" and "Receiver", to make things easier), so I'm holding off on publishing it too widely until that stabilizes. And we'll have to see how well my relay server handles the load :). But then yeah, I'll put it up on homebrew. (I don't have any experience with writing Homebrew recipies, feel free to send some hints my way).

:+1: @warner [https://github.com/Homebrew/homebrew/blob/master/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md#how-to-open-a-homebrew-pull-request-and-get-it-merged](they have a how-to guide) that links to the formula cookbook

There are also additional instructions specific to Python packages:
https://github.com/Homebrew/brew/blob/master/docs/Homebrew-and-Python.md
https://github.com/Homebrew/brew/blob/master/docs/Python-for-Formula-Authors.md

Will by fixed by https://github.com/Homebrew/homebrew-core/pull/11256!

Looks like this shipped. At the moment, brew install magic-wormhole will get you 0.9.2.


App icon clickable

Hey.
In the about libs screen, can you make the icon clickable, and open it in high res? (if is available)

@alorma any real advantage of this?

Why not? Can show the icon in a big size, or use as easter egg launcher...
:p
On Tue, May 19, 2015, 23:56 Mike Penz<EMAIL_ADDRESS>wrote:

@alorma https://github.com/alorma any real advantage of this?
--
Reply to this email directly or view it on GitHub
https://github.com/mikepenz/AboutLibraries/issues/83#issuecomment-103679474
.

@alorma solved ;)


Multi-day, all-day events have wrong end date

System Information:

Version: 1.5.3
Language: en-us
Timezone Offset: -08:00
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.35 Safari/537.36

What steps will reproduce the problem?

Create a multi-day, all-day event, such as February 1 - February 5.
Verify that the event bubble on the Calendar website shows February 1 - February 5.
Observe the event in the Chrome extension popup.

What is the expected result?
I expected February 1 - February 5.
What happens instead?
I see February 1 - February 6.
Screenshot URL:

Logs:

In the screenshot from the Google Calendar event page, it does show Feb 6 as well. Looks like an event ending at 00:00 can be variously parsed as the previous day or the next day.


drivers: sensor: sbs-gauge: The sbs-gauge cannot be read from sensor shell

Describe the bug
The sensor shell does unconditionally fetch all channels whenever something is read.
The sbs-gauge does not implement the SENSOR_CHAN_ALL and therefor cannot be used with the shell.
Expected behavior
Sensor shell can read the values
Impact
Sensor shell cannot be used with the sbs-gauge
Logs and console output
uart:~$ sensor get BAT_GAUGE
Failed to read sensor: -134

Additional context
Fix: #35443

This issue is also related to the driver bq274xx


Moster13SmHm little h

It is ambiguous in the paper what the units are.  It appears by trial and error it should be h=1.

@duncandc - I think you mean Moster10SmHm, yes?

http://halotools.readthedocs.io/en/latest/api/halotools.empirical_models.Moster13SmHm.html#halotools.empirical_models.Moster13SmHm

There was no bug in the implementation. But #620 improved the documentation and in-line comments.


refactor: ports clear cache app

This PR ports over the /clear-cache route and deletes the old app.

Warnings

:warning:

Routes added to routes.tsx should have a corresponding cypress.js smoke test. See the cypress/integration folder for examples.

  Generated by :no_entry_sign: dangerJS against f82ee554ebcc48ca05d9144fb1d9d1ff79264557

Oh interesting - didn't know this existed!


Missing Results when records with Large ID length

I'm seeing some odd issues with long(ish) id lengths. I have some multipart IDs I'm placing inside the same key in order to do a NEARBY search. Basically its a concatenation of the type +  as I want to search multiple classes of things within the same key. With longer IDs of 77 characters, I'm seeing that the records are never found with a NEARBY search.
When In invert the ID, (category at the end), which puts greater uniqueness up front, the record is found so I'm pretty sure that the issue is related to ID character length. Unrelated, I am trying to use "SEARCH" to debug but it always returns 0 count and IDs so I have to use SCAN with a high limit. This is version 1.4.1

Are you using HTTP for the client?

Or rather which client are you using? :)

I'm using python redis client

Thanks  for the response. Also to be clear this is the Tile38 ID underneath the key, vs the redis key. Documentation on redis keys seems to be imply the ID can be fairly large. Is there an efficient way to use Tile38 to search across multiple keys? That would be an potential alternative approach to what I was trying to do but I didn't see any way to do that in the commands.

Testing with master I saw inconsistencies once, but after flushing and trying all again I think its better. It may very well have been related to #49. Feel free to mark this as closed.
I still cannot get search to work however. Should I open a new ticket for that? I am testing over http I always get 0 results.

The SEARCH command only works on the string type. It allows for managing basic sorted string data in a key. Geo types will not be returned with search.
For example:
SET trucks 0001:driver STRING Tom
SET trucks 0002:driver STRING Janet
SET trucks 0003:driver STRING Alexis
SET trucks 0004:driver STRING Aaron

SEARCH trucks

Output:
"0004:driver", "Aaron"
"0003:driver", "Alexis"
"0002:driver", "Janet"
"0001:driver", "Tom"

SEARCH trucks MATCH A*

Output:
"0004:driver", "Aaron"
"0003:driver", "Alexis"

Sorry about the confusion.
It appears that the SEARCH command is poorly documented on the tile38.com site. I'll fix this asap.

ahh got it. I was trying to find some way to do a MATCH against a pattern of my IDs in some key (Without doing a geospatial search). SCAN with MATCH of a pattern != * didn't seem to work either.

Could you provide an example of a pattern that you are using?
I generally use MATCH for something like this:
SET trucks 0001:pos POINT 33 -115
SET trucks 0002:pos POINT 34 -116
SET trucks 0003:pos POINT 35 -117

SCAN trucks MATCH 0001:* POINTS

Output:
"0001:pos", "33", "-115"

Nevermind. It is in fact working with SCAN on the master branch. I had another issue due to things I set up for the ID test. Thank you for the quick feedback on everything. Great Project

Thank you for the helpful feedback, and please let me know if you have any further questions along the way.


chore: purge url for prod

Description

chore: purge url for prod

Linear Link

Business Impact

minimal

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[ ] Roll Forward
[x] Roll Back

Documentation
Reviewer Checklist

[ ] Description of Change
[ ] Description of Business Impact.
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.70.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


G600 Unable to commit changes

Information

ratbagd version (ratbagd --version): 0.14
Distribution: Linux dan-MS-7641 5.4.0-42-generic #46-Ubuntu SMP Fri Jul 10 00:24:02 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Kernel version (ex. uname -srmo): Linux 5.4.0-42-generic x86_64 GNU/Linux

Device info (if applicable):
$ ratbagctl <device> info
cheering-viscacha - Logitech Gaming Mouse G600
             Model: usb:046d:c24a:0
 Number of Buttons: 20
    Number of Leds: 1
Number of Profiles: 3
Profile 0: (active)
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 2000dpi (active) (default)
    1: 2000dpi
    2: 3000dpi
    3: 3200dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to 'second-mode'
  Button: 6 is mapped to macro '↕V'
  Button: 7 is mapped to macro '↕C'
  Button: 8 is mapped to macro '↓LEFTCTRL ↓C ↑LEFTCTRL ↑C'
  Button: 9 is mapped to macro '↕2'
  Button: 10 is mapped to macro '↕3'
  Button: 11 is mapped to macro '↕4'
  Button: 12 is mapped to macro '↕5'
  Button: 13 is mapped to macro '↕6'
  Button: 14 is mapped to macro '↕7'
  Button: 15 is mapped to macro '↕8'
  Button: 16 is mapped to macro '↕9'
  Button: 17 is mapped to macro '↕0'
  Button: 18 is mapped to macro '↕MINUS'
  Button: 19 is mapped to macro '↕EQUAL'
  LED: 0, depth: rgb, mode: cycle, duration: 0, brightness: 0
Profile 1:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 8000dpi (active) (default)
    1: 0dpi
    2: 0dpi
    3: 0dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to 'second-mode'
  Button: 6 is mapped to UNKNOWN
  Button: 7 is mapped to 'profile-cycle-up'
  Button: 8 is mapped to macro '↓LEFTCTRL ↓LEFTSHIFT ↓C ↑LEFTSHIFT ↑C ↑LEFTCTRL'
  Button: 9 is mapped to macro '↕KP2'
  Button: 10 is mapped to macro '↕KP3'
  Button: 11 is mapped to macro '↕KP4'
  Button: 12 is mapped to macro '↕KP5'
  Button: 13 is mapped to macro '↕KP6'
  Button: 14 is mapped to macro '↕KP7'
  Button: 15 is mapped to macro '↕KP8'
  Button: 16 is mapped to macro '↕KP9'
  Button: 17 is mapped to macro '↕KP0'
  Button: 18 is mapped to macro '↕KPMINUS'
  Button: 19 is mapped to macro '↕KPPLUS'
  LED: 0, depth: rgb, mode: cycle, duration: 0, brightness: 255
Profile 2:
  Name: n/a
  Report Rate: 1000Hz
  Resolutions:
    0: 400dpi
    1: 1200dpi (active) (default)
    2: 2000dpi
    3: 3200dpi
  Button: 0 is mapped to 'button 1'
  Button: 1 is mapped to 'button 2'
  Button: 2 is mapped to 'button 3'
  Button: 3 is mapped to 'button 4'
  Button: 4 is mapped to 'button 5'
  Button: 5 is mapped to 'resolution-alternate'
  Button: 6 is mapped to UNKNOWN
  Button: 7 is mapped to 'profile-cycle-up'
  Button: 8 is mapped to macro '↕1'
  Button: 9 is mapped to macro '↕2'
  Button: 10 is mapped to macro '↕3'
  Button: 11 is mapped to macro '↕4'
  Button: 12 is mapped to macro '↕5'
  Button: 13 is mapped to macro '↕6'
  Button: 14 is mapped to 'resolution-up'
  Button: 15 is mapped to UNKNOWN
  Button: 16 is mapped to 'button 5'
  Button: 17 is mapped to 'resolution-down'
  Button: 18 is mapped to macro '↕E'
  Button: 19 is mapped to 'button 4'
  LED: 0, depth: rgb, mode: breathing, color: 00ff00, duration: 4000, brightness: 0

Describe the bug
Unable to use ratbagctl to change dpi to 2000
To Reproduce
Steps to reproduce the behavior:

Run sudo dbus-monitor --system sender=org.freedesktop.ratbag1
Run ratbagctl "Logitech Gaming Mouse G600" profile 0 dpi set 2000
Observe string "Unknown method Commit or interface org.freedesktop.ratbag1.Device." on dbus monitor
Dpi does not change

Logs
Please start the daemon with verbosity and reproduce the issue.
 I created a 2nd layer compatibility controller that simply programs the keyboard with libratbagctl, disables it in x-sessions, and uses a unix-socket server to parse and output signals to a companion profile manager which can run at the user level.

Closing because this is no longer relevant. I created a 2nd layer compatibility controller that simply programs the keyboard with libratbagctl, disables it in x-sessions, and uses a unix-socket server to parse and output signals to a companion profile manager which can run at the user level.


Implement a .nvmrc to configure Node Version Manager for this project

The problem
Most of us devs are working on multiple projects that require different versions of nodes. Depending on what version of node that you're using it might not be compatible with this project and version "12.x^" is the version of node that's expected.
The solution
To avoid getting the following error below when starting up the project, let's look into adding a .nvmrc file that allows anyone with nvm to know the default node.js version and install the correct one.
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "12.x". Got "14.16.0"

Jeff will include in Oct 31 Engineering Huddle agenda.

Thank you for the suggestion @proeung !
We have discussed and decided that we will not include as not all users are using nvm. There are other node version managers available as well and we would not be able to include for all.
For a quick solution, the .nvmrc file can be added locally and excluded via .gitignore_global in your home directory.