Lego Loco interface glitches

I'm trying to run Lego Loco on Windows 10 but it has a lot of graphical issues. I installed DDrawCompat v0.4.0 and that's fixed most of them, but it still has a few issues where the interface flashes whatever it was displaying previously after changing. It also does not render text boxes correctly. I did try the debug version and older versions, but it ran way slower with the former and had more graphical issues with previous releases.
Example images:

The background from the main world stuck behind the tutorial box for a few frames after entering a building. When moving between buildings it also flashes between the current and previous backgrounds for a few frames.

Tutorial text boxes display all text in each section on one page briefly before moving excess text to another page. Normally it should immediately look like the bottom image.
Here is a short video showing these issues in motion, though some of them you have to pause and use frame advancing to see well. There are also cursor trails sometimes, but I was not able to capture them.

Are you using D3D9On12? I can't reproduce these issues without it. Please share your DDrawCompat logs.

DDrawCompat-Loco[2].log
Here's a log file it left in the folder I put ddraw.dll in, LEGO LOCO\Exe. PCGamingWiki did say to put the dll in just the LEGO LOCO folder, but it didn't recognize it when I did that. All the log files it left are identical aside from timestamps.
I have no idea if I have D3D9On12. If it's something I have to download then no.

Was the log file useful at all? I can try some more testing if needed, I don't know how to change any settings or what D3D9On12 is though. Sorry I forgot about this for a while and if what I posted wasn't helpful enough.

No, you're not using D3D9On12 according to your logs. It's only used by default with recent Intel GPUs, as a substitute for a D3D9 driver.
I didn't get very far with investigating the issues. The dialog boxes are of course not manipulated by DDrawCompat, the text wrapping changes because the game renders it multiple times and changes the wrapping itself.
I don't know about the other glitches, it may be some issue with DDrawCompat, but I didn't have good enough tools for debugging it yet and it was getting way too time consuming, so I put the investigation on hold to deal with simpler cases. I will try to return to it before the next release, but for now I still have many other issues to focus on that are less troublesome to debug.

Can you try it again with v0.5.0? I think I was able to fix most of the cursor trails, and I can not reproduce any of the other glitches either, although I always had a hard time reproducing most of them.

Can you try it again with v0.5.0? I think I was able to fix most of the cursor trails, and I can not reproduce any of the other glitches either, although I always had a hard time reproducing most of them.

Yeah, I tried it and it seems like the cursor trails and the background showing through textures, as well as the help box text sometimes not wrapping correctly, has been fixed in 0.5.0. The only issue I'm having now is that sometimes when moving between rooms (like going into and out of the post office or paint shop) the desktop and any windows behind the game flashes through for like one frame. No idea how it shows up on video because OBS just shows a second-long delay when moving between rooms. The exit window (pressing escape) also seems to have some lag issues. I forget if either of these happened in the old version though. Sorry I didn't see this at first!

Well since there's a 0.5.2 now too I tried that, and now the tutorial window isn't displaying at all unless I tab out of the game, it just covers the whole thing with whatever graphics were displayed there last. The framerate is also really bad. idk what changed but it's even more unplayable now than before

v0.5.2 has way bigger display issues with this game for me, so I'll look into that separately.
In the meantime, could you please help figure out which commit between v0.5.1 and v0.5.2 introduced the performance issues? I assume v0.5.1 is still fine, since it has only minimal changes compared to v0.5.0. I have a build of all commits between v0.5.1 and v0.5.2 here: https://github.com/narzoul/DDrawCompat/releases/download/v0.5.2/DDrawCompat-v0.5.2-debug-previous-builds.7z

Sure, I'll go through them and see if I can find when it breaks. I tried 0.5.1 real quick and yeah it works the same as 0.5.0 with only the exit popup and brief flicker issues.

v0.5.1-16-gd5a89cad is the version where it apparently first breaks.
v0.5.1-17-gec9cf32e is actually even worse, it breaks really bad to the point everything is black. v0.5.1-18-gd6fa1274 onward goes back to just breaking once you load a world but then later versions still sometimes just load the game with no graphics at all, including the last one v0.5.1-31-ge0048a1b.
Let me know if I should do further testing.

I fixed the more critical issues in v0.5.3. There is still the matter of an occasional 1-frame graphical glitch when dialog boxes pop up. The problem is caused by ShowWindow forcing the dialogs to the top of the Z-order, and it takes a little time for the fullscreen presentation window to reestablish it's topmost status. I tried various hacks to fix it, and while some of them worked, they caused other, worse problems. I don't have any more ideas to try at the moment, I'll get back to this when I do...


Included files don't trigger change.

When including something in a pug file or importing something in a sass / stylus file, the respective included files don't trigger a build.

git clone https://github.com/FranzSkuffka/pug-html-loader-bug
npm i
npm run dev
change https://github.com/FranzSkuffka/pug-html-loader-bug/blob/master/src/yo.pug
???
no profit

Imo it's not a good idea to mix pug includes with Vue's own component composition. If you need composition, just make them components instead. This is why vue-loader's template part don't support pre-processor imports.
If you really want it, you'll have to use pug-loader and configure vue-loader to use pug-loader per (docs here)[http://vue-loader.vuejs.org/en/configurations/advanced.html]. In addition, pug-loader returns a compiled template function, not the raw HTML, so you need to chain a custom loader after pug-loader to invoke that function and return the value.

Thank you for this info.


refactor(plugin/pdf-to-txt): read directly from buffer body

closes #68

Pull Request Test Coverage Report for Build 860844381

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 92.373%

Totals

Change from base Build 849461505:
1.6%

Covered Lines:
238

Relevant Lines:
260

💛  - Coveralls


Modify colors on the front office

Right now we have specidifc colors for each item but not for all items and not in all the interfaces

Red for people (but not in the list view)
Blue for Organizations
Yellow for Places, events, paths & trips

There is a lack of logic don't you think ?
Here are the colors we had initially seleted for each item

Identified color issues :

Title of event in block here

Background color of comment box

Background color of pictograms here

Sorry Maxime, the description was unclear. It's mainly the background banner of each element that needs to change. CF the figma here

Event R174 V189 B165 #aebda5
Journey/trips R137 V83 B78 #88534d
Path R30 V85 B68 #1e5544


Still showing 'Loading' in Quick Access on Mac.

Storage Explorer Version: 1.11.0
Build Number: 20191102.1
Platform/OS:  macOS High Sierra
Language: Chinese(zh-CN)/ Chinese(zh-TW)
Regression From: Not a regression
Steps to reproduce:

Open ASE
Expand the 'Quick Access'

Expect Experience:
Show quick access.
Actual Experience:
Still showing 'Loading' in Quick Access on Mac.

@v-lanjli Did "Loading..." ever go away for you?

@jinglouMSFT , no, when I expand 'Quick Access' node, it always shows loading...

This issue doesn't reproduce on my side in 1.11.0 release.

@v-lanjli likely the cached files on your machine are corrupted.  Can you try to delete the following?  Close Storage Explorer first, then delete
/Users/<your_name>/Library/Application Support/StorageExplorer
then restart Storage Explorer.
Note that if you have ever imported any SSL certificates, back up the contents of the certs directory. Later, you can use the backup to reimport your SSL certificates.

@jinglouMSFT I followed the steps you provided and the issue was solved. Closed this issue. Thanks for your help~


SyntaxError: invalid syntax  print(f"Reached MAX_STEP: {MAX_STEP} at step: {global_step_value}")

I got many errors related to the print statement.
File "train.py", line 82
print(f"Reached MAX_STEP: {MAX_STEP} at step: {global_step_value}")
^
SyntaxError: invalid syntax

Check you are using Python >=3.6 It is using f-strings.
On 15 March 2018 at 10:29, idhamari<EMAIL_ADDRESS>wrote:

I got many errors related to the print statement.
File "train.py", line 82
print(f"Reached MAX_STEP: {MAX_STEP} at step: {global_step_value}")
^
SyntaxError: invalid syntax
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mshunshin/SegNetCMR/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaQNnywDLWcvWoHoJZPx8X_3BgIVs35ks5tekJ9gaJpZM4Sr5Tc
.

Thanks for concern and quick reply. I am using python 2.7 (I built all other tools using it). Is there a way to make it works in python 2.7? or shall I rebuild all other tools in python 3?  do you think there will be no conflict?

I think it’s only a few of the print statements I use for python 3.6 features - but can’t promise.
Change them from
print(f”This is the result: {result}, and another result: {result2}”) to
print(“This is the result: {0}, and another result: {1}”.format(result, result2))
etc…
Have you tried using the anaconda python distribution - I find it works very well on windows and Mac for tensor flow and scientific use. No compiling needed, and has recent versions of tensor flow.

On 16 Mar 2018, at 23:21, idhamari<EMAIL_ADDRESS>wrote:
Thanks for concern and quick reply. I am using python 2.7 (I built all other tools using it). Is there a way to make it works in python 2.7? or shall I rebuild all other tools in python 3? do you think there will be no conflict?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for explaining, I will try your suggestion. I am using pip and Ubuntu 16 system.


Add logging to Modflow 6 package

In GitLab by @JoerivanEngelen on Jul 25, 2023, 17:41
Add logging to:

Initialization?
Writing
Dump
Validation?

Example log messages:
Initialization

"Initializing the StructuredDiscretization package..."
"Succesfully initialized the StructuredDiscretization package"

Writing

"Writing model 'test_model' to /path/model/dir"... --> This will be for issue #492

"Writing the StructuredDiscretization package..."
"Succesfully wrote StructuredDiscretization package"

"Succesfully wrote model 'test_model' to /path/model/dir" --> This will be for issue #492

I think the nicest thing (potentially) for to do this kind of logging is to use decorators, to avoid code duplication.

Should the "run" method of the Simulation class have logging? (I would add it with urgency level "CRITICAL" so that it'll always show up.)


Windows Defender detects virus

Windows defender reports the pre-built wcap.exe as dangerous. can this be looked at?

closing. duplicate.


Linux build failure

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
conda_libmamba_solver.conda_build_exceptions.ExplainedDependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {MatchSpec("rust_linux-64==1.79.0=h2e8eb6f_0"), MatchSpec("rust=1.79.0")}
Encountered problems while solving:
  - package rust_linux-64-1.79.0-h2e8eb6f_0 requires rust 1.79.0.*, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ rust_linux-64 1.79.0.*  is installable and it requires
│  └─ rust 1.79.0.* , which requires
│     └─ sysroot_linux-64 >=2.17 , which can be installed;
└─ sysroot_linux-64 2.12.*  is not installable because it conflicts with any installable versions previously reported.

Installed packages
.

Environment info
.

In staged-recipes, everything was working ok.

Fixed by re-rendering: https://github.com/conda-forge/zenoh-feedstock/pull/2 .


Add struct layout

Part of #37

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.82%. Comparing base (54937d4) to head (08b60e8).

Files with missing lines
Patch %
Lines

crates/shad_parser/src/item/struct_.rs
76.19%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #74      +/-   ##
===========================================
- Coverage   100.00%   99.82%   -0.18%
===========================================
  Files           59       59
  Lines         2836     2850      +14
===========================================
+ Hits          2836     2845       +9
- Misses           0        5       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Divide project to apps

We only need 2 apps for now: users, tasks. So I created the apps and put them in apps folder.
I think that this PR is only to create our work environment so each one could start writing the models.
The admin panel will help you to see the models you have created - after migrate. That a nice way to check your process 💪
The things I did:

created 2 new apps: users, tasks
added auto migrate to setup.sh
added admin panel with admin user
moved images to img folder and changed the readme accordingly

To get the admin username and password please contact me.
Resolve #23

@aradz1997 @avraham1992 @orzionpour @asafh7 @mgold1234 @natifridman @kobihk @nunnatsa
Can someone review my code?

LGTM.
I'll approve after we all confirm, on the zoom meeting later today., this is the right structure.

LGTM.
I'll approve if we all confirm, on the zoom meeting later today, this is the right structure.

I do not see that you have added the configurations in th settings..but looks good !

@avraham1992 check out here. Is that what you missed?

@AvivLiberman It does not work that way .. owe the copy from the page of app


Disable "short" DB names in replication requests

Since 2.0.0 has been released, there have been a number of issues with specifying "short" / "local" database names in replication requests. The most recent encounter with problems concerning this syntax is:
https://github.com/apache/couchdb/issues/1550#issuecomment-448149590
We need to do one of two things:

Fix "local" replication endpoints completely. My understanding from @nickva is that this is very difficult to accomplish, likely impossible.
Remove the ability to specify replication source and target as just a database name, both in the HTTP API as well as in Fauxton.

In short, it's not right for us to continue to encourage use of an API endpoint that is knowingly broken, and ignore the problem for 3 major releases.

+1 on "Remove the ability to specify replication source and target as just a database name, both in the HTTP API as well as in Fauxton" point
To expand on it:
Since 2.x local replication endpoints refer only to node-local databases. In 1.x they were "proper" databases so this was a useful thing to have. Now, it is mostly confusing, as these refer to databases created on the :5986 port, which is very surprising and mostly useless. A user who migrated from 1.x might be very confused as to what's happening and why things don't work as expected anymore.
Moreover, replication jobs are distributed to individual cluster nodes in an consistent but essentially opaque manner from a user's point of view.  So unless a cluster has only one node,  a replication job might end up on node 2, or node 3 for example, and would be pick the local endpoint dbs on that node only.
So perhaps we could disable it by default. Then users  would toggle a config value say allow_node_local_endpoints = true to use it. Eventually in a future release, it goes away altogether and we get to clean the complicated replicator code that handles both local and remote endpoints. Or just warn the disable it altogether, without bothering with a config toggle.

Fixed in https://github.com/apache/couchdb/pull/2089


[MODULE] - Bayesian Optimisation active learner

Please describe the module you would like to add to bricks
Bayesian optimisation to train an active learner classification head.
Do you already have an implementation?
Additional context

Great idea! HyperOpt is great for this. Also possible with Sklearn I think.


[Fix] SEP-6: Make account_id optional in withdraw response

The previous PR (https://github.com/stellar/stellar-anchor-tests/pull/132) did not make the account_id optional, which is omitted when the Anchor cannot provide the deposit address at transaction initiation.

Preview is available here:http://stellar-anchor-tests-pr133.previews.kube001.services.stellar-ops.com/


fix(package): Set typescript version as ~2.3.4 instead of ^2.2.1 and …

…ts-node up to ~3.2.0 from ^2.0.0

It's related to issue #102

Coverage remained the same at 94.975% when pulling 9fb0f6ab64ade787dcf54c36799e677241a64a4b on cojack:fix-typescript-version into a753c50c467cd775f4c8a791eea0239ff2394d9f on kamilmysliwiec:master.

It's changed in v4 :smiley: thanks @cojack!


Enforce DCO

We need to enforce DCO on contributions, we can use something like https://github.com/probot/dco to do this, it's fairly simple.

@caniszczyk: we have an existing DCO bot, is that fine?   Unless it somehow got disabled in the move cc @endophage

@riyazdf I think they disabled it before the move yes, but should probably be easy to re-enable

using your own DCO bot is fine too
On Thu, Nov 2, 2017 at 12:45 PM, Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

@riyazdf https://github.com/riyazdf I think they disabled it before the
move yes, but should probably be easy to re-enable
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/notary/issues/1255#issuecomment-341396904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5IZYJuBz6Qs4IC4bTHx8wCcUk6MRaks5syatfgaJpZM4QLtqs
.

--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1<PHONE_NUMBER>

ok, our own bot should be re-enabled!  I'll close this for now and we can re-open if there are any issues


Webapp uses wrong icon

Webapps v2.17 from F-Droid
Android 7.1.1
I deleted the Reddit webapp that was preconfigured.
I set a web app for: https://freelibrary.overdrive.com/
No matter how I try to configure it, the webapp uses the orange reddit icon on the main webapps screen. It will load the correct icon to the right of the back arrow on the top, but when I exit the webapp it still shows the reddit icon.
I've restarted the app, reconfigured the webapp, restarted phone, etc. No solution.
Thanks.
Edit: I cleared the phone's cached data but the reddit logo reappeared for the overdrive webapp after the icons regenerated.
It's the smaller version of this image, basically: https://i.redd.it/rq36kl1xjxr01.png
Edit 2: I resolved this by running LTE Cleaner from the IzzyOnDroid repo. It must have cleaned some type of cache. My icons are normal now.
Still, it's probably a bug? Leaving issue open for now unless you want to close it.

Thanks for the updates. Yes it is a bug - if you delete a webapp and add another one, it re-uses the icon of the deleted one, and doesn't replace it unless a higher-res icon is supplied. So I'll make it that it deletes the favicon everytime you launch a webapp, so that it can keep it updated.


[HOLD on #33680 and #41314] [$500] Desktop - Chat isn't marked as read if user clicks on notification from Notification Center

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.28-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open Desktop App
Login as User A
From the second device with account of User B sent a message to User A
User A received Notification
Wait until Notification goes to the Notification center
Open Notification center and click on this received notification

Expected Result:
User goes to the correct chat, new messages are marked as read and this chat is no longer marked in bold
Actual Result:
Chat is marked in bold
If User clicks on a notification BEFORE it goes to the notification center, the chat will be marked as read.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/aff3d35b-99ca-4985-a32b-ed1885ec91fc
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011a42b3684380c039
Upwork Job ID:<PHONE_NUMBER>068030464
Last Price Increase: 2024-01-19
Automatic offers:

ishpaul777 | Reviewer | 28118184

Proposal
Please re-state the problem that we are trying to solve in this issue.
We want to make sure the chat is marked as read when messages have gone into the Notification Center and are clicked from there.
What is the root cause of that problem?
The root of the problem is that the App is not in the ‘Visible’ state when the Notification Center message is clicked. There’s a small if statement in ReportActionsList.js which ensures that if the app isn’t visible (Visibility.isVisible()), messages will not be read.
if (Visibility.isVisible() && scrollingVerticalOffset.current < MSG_VISIBLE_THRESHOLD) {
     Report.readNewestAction(report.reportID);
} else {
     readActionSkipped.current = true;
}

This is useful in some cases, like receiving messages if you’re afk, but unhelpful in multiple other cases where the same bug shows up;

You click on a notification within the Notification Center

Click on a notification before it goes into the Notification Center, if you have another tab open in front of Expensify (same bug as this ticket)

You’re already chatting to someone and receive new messages. The bolding of the text doesn’t go away, until you click to another chat and back again. So again, the same bug. (See the attached video)

What changes do you think we should make in order to solve the problem?
This is the first bug I’m looking into, so I don’t know exactly what your desired behaviour is.
My suggestion would be adding to the functionality that makes chats visible:
Right now, the functionality for updating to the ‘Read’ state requires clicking on a message in the sidebar. I would say that we should add additional functionality so that if a user clicks within one of their chats, or on the chat title in the left hand sidebar, it will trigger the useEffect to update, and mark messages as read. This will resolve all three bugs that currently exist.
What alternative solutions did you explore? (Optional)
The simple code fix is removing isVisible , but this is at the expense of causing other issues - so messages will mark as read, even if the user is viewing other apps in front of it.
Screen Recording 2024-01-20 at 04.10.11.mov.zip

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01cce98dffb320182a

Proposal
Please re-state the problem that we are trying to solve in this issue.
The unread status styling of a report does not disappear when clicking on the OS notification when it's docked in the Notification Center.
What is the root cause of that problem?
At https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionsList.js#L211 The utility that exposes the Visibility has a stale reference to the document state.
What changes do you think we should make in order to solve the problem?
If you replace the Visibility.isVisible() with the actual document.visibilityState === 'visible', it will behave as expected.

What alternative solutions did you explore? (Optional)
I explored removing the visibility, but this impact the user experience. Also looked at other window methods such as hidden, and focus.

@sobitneupane what do you think of this first proposal?

My proposal on this is temporarily hidden because my primary github account is suspended while I am recovering it.
My solution was that I identified the existing
Visibility.isVisible() check gets a stale reference of the notification app.
Calling "document.visibilityState === 'visible'" directly in the ReportActionsList getse a fresh window state and clears the chat reliably.
Do I need to write a new proposal for this? It should be in the history of emails/notifications

Proposal
Please re-state the problem that we are trying to solve in this issue.
The Chat does not get marked as read if the OS notification gets clicked from the docked notification center state.
What is the root cause of that problem?
Visibility.isVisible() utility function unreliably returns false when the notification is from the docked notification center. This seems to be a bug with the util function, and the window document state from electron.
What changes do you think we should make in order to solve the problem?
When replacing Visibility.isVisible() in the ReportActionsList ( where it checks if it's visible before it marks as read)
with the actual document.visibilityState === 'visible', it works as expected. The utility has an unreliable reference in this specific scenario

I am not around and won't be able to review it soon. @garrettmknight Can we get someone else to review proposal?

Yeah, no problem.

Hey @ishpaul777 - we've got a couple proposals for this one when you've got a minute to review!

Thanks for your proposal @jeremy-croff, RCA makes and solution tests well, Can you do a impact analysis of your solution just want to make sure we didn't break current usage ofVisibility.isVisible.

Identified that the original visibility to focus mapped logic was implemented when electron had no support for visibility yet. https://github.com/Expensify/App/commit/e7150f92bfd50e5d46ba65e85163bdac808a2229
This gives good indication is was a tech limitation rather than an intentional choice.

When reviewing out uses of isVisibility, visibility is a more optimistic truthy value than isFocused, so I am reviewing it with the lens of are any unintentional behaviours happening that shouldn't.

When reviewing impact analysis, the change would be scoped to changes in the electron main file's interpration of visibility which can be found here https://github.com/Expensify/App/blob/main/desktop/main.js#L558, so it wouldn't impact other platforms.

Line by line analysis:
https://github.com/Expensify/App/blob/5edf172457de71f5fa77d9ddf30e03726db346a2/src/pages/signin/LoginForm/BaseLoginForm.js#L280 will behave the same because of the last condition will be truthy always
https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/libs/actions/Report.ts#L1834 behaves the same because of the last condition will be truthy always
https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/libs/getIsReportFullyVisible.ts#L6 will behave different, but we can implement isFocused seperate for electron ( currently short circuits to true ) to achieve the same logical behaviour here https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/libs/Visibility/index.desktop.ts#L11, and then a listener on the main process again.
https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/components/Form/FormProvider.js#L324 will benefit from similarly from also having an seperate focus implementation
In short, having a seperate isFocus implementation will further align the behavior between web and focus, and mitigate any impact.

Thanks for a detailed analysis. @jeremy-croff

but we can implement isFocused seperate for electron (currently short circuits to true ) to achieve the same logical behaviour here

Can you update your solution to include the changes required for the other cases to work as expected

Updated

Sounds good. @jeremy-croff feel free to put up a PR when you have it ready.
@mirimichaelson thank you for posting your first proposal! It looks like you put a lot of effort into figuring out a possible solution, and I appreciate the detail. Although your proposal wasn't chosen I'd encourage you to keep looking around for possible issues to pick up 🙂. Thank you for contributing to this issue's discussion and welcome to the repository!

Update: we're waiting to see if we can get an Electron maintainer to complete an upstream issue that will impact this issue. Comment here. If no word comes from them then we'll look into this again sometime next week.

Sounds good - will leave this daily for checkins.

We have confirmation from the Electron dev that they are working on the upstream issue. They said they hope to get to it next week. @ishpaul777 @jeremy-croff.

We have confirmation from the Electron dev that they are working on the upstream issue. They said they hope to get to it next week.
cc: @ishpaul777 @jeremy-croff.

Okay great.
So what we can do for this PR is follow the original proposal, and just implement the correct electron visibility method. End of PR. Simple.
I had referenced some other github issues that the onfocus listener implementation would fix, but i'll pull it out comment on those issues with the proposal seperate.

@ishpaul777 Good point! Let me see if I can get the ball rolling on getting our electron version upgraded while we wait for this upstream patch to happen.

what should be process for that do we need consensus for upgrade?

Here's my plan:

create a separate issue for bumping our electron version 28. I think this will be an easy sell since upgrading a core library that we use is important for staying up to date
Once the electron library is upgraded and the upstream issue that effects this issue is patched, then we can finish this issue. Per Jeremy's comment I think there is still work to be done here irrespective of the electron version bump correct?

If that sounds good to both of you I think we can change the priority of this to weekly. Does that sound like a plan?

@ishpaul777 Good point! Let me see if I can get the ball rolling on getting our electron version upgraded while we wait for this upstream patch to happen.

what should be process for that do we need consensus for upgrade?

Here's my plan:

create a separate issue for bumping our electron version 28. I think this will be an easy sell since upgrading a core library that we use is important for staying up to date
Once the electron library is upgraded and the upstream issue that effects this issue is patched, then we can finish this issue. Per Jeremy's comment I think there is still work to be done here irrespective of the electron version bump correct?

If that sounds good to both of you I think we can change the priority of this to weekly. Does that sound like a plan?
Seems we can put the PR on hold until after we have a fix version in electron,
and completed the https://github.com/Expensify/App/issues/35600 upgrade Issue.
If they are targeting feb 20 this probably will be on hold for a good month or so.

Upstream issue is officially fixed 🎉 https://github.com/electron/electron/issues/38955#issuecomment-1929219329

It looks like this issue is going to be patched in electron 25, so we might not even need to upgrade major versions in order to make use of the fix. It got merged to main but looks like we are waiting for it to be patched specifically in version 25 https://github.com/electron/electron/pull/38982#issuecomment-1929218085.
I'll keep the major version upgrade issue open though since that is worth doing in its own right.

I think it would be better to hold this for https://github.com/Expensify/App/issues/33680

@ishpaul777 He is implementing the focus listener logic. Which I had identified as solving the electron issue, as well as the LHN bold issues for desktop. A previous few commits of mine was doing this in the same way.
But it was considered a workaround for the electron bug, with additional risk, and I was advised on the PR to implement the minimum to resolve the bug by implementing the electron visibility apis. I think we will benefit from having the correct electron API's implemented. But if his PR goes first, I think his logic will kick in and make it non reproducable. I can test his branch later?

@jeremy-croff you get a chance to test his branch and see how it worked?

@jeremy-croff you get a chance to test his branch and see how it worked?

Bookmarked to test the branch in approx 5 hours. Confidence is pretty high it will be addressed

@jeremy-croff you get a chance to test his branch and see how it worked?

Confirmed this addresses this bug

Updating this to HOLD in that case for https://github.com/Expensify/App/issues/33680 and https://github.com/electron/electron/pull/41314 - will continue to check on those before retesting/taking his off hold if the bug still exists.

Just a note this is still on hold - keeping it while I go OOO because I doubt 33680 goes to prod till I get back.

Still on hold

Still on hold for both issues

@ishpaul777 I have confirmed that this is no longer reproducible on the latest main. This is most likely due to the merge of https://github.com/Expensify/App/issues/33680, as expected.
Summary:

Original  accepted proposal identified the missing of Electron.Visibility() API's and defaulting to focus.
After Implementation and thorough testing, an undesired side effect was identified. This was due to https://github.com/electron/electron/pull/41314. Great efforts from @blimpich to get it prioritized initially upstream, but it had to be reverted due to Linux issues.
Due to uncertainty in electron, I identified an alternate approach as mentioned in the bottom here. I also realized it fixes a bigger picture issue with how we handle visibility and started referencing multiple tickets it would address. However a parallel initiative was occuring in https://github.com/Expensify/App/issues/33680 that also tackled this, and got merged in before.

Combing through tickets that dependent on this, I've retested and confirmed fixed state for  https://github.com/Expensify/App/issues/34698
and. https://github.com/Expensify/App/issues/35085 and provided an updated status for them.
If you can confirm this is also no longer reproducable @ishpaul777 I think we are good here.

Thank you for your thorough summary @jeremy-croff!

@ishpaul777 I am perplexed.
https://github.com/Expensify/App/assets/157416545/8c9e7070-d775-4757-b5c0-602f5dc86e72
steps:
1.checkout main
2. pull latest
3. npm run web
4. npm run desktop
then video

I am able to reproduce, I have to have electron already focused to do so! Good catch.
I will try to get a good solution by today.

@ishpaul777 I am unable to come up with a decent solution at this point due to the occlusion issues; maybe it's time to consider opening it up again for new proposals.
I think what's going to make the most sense here is fix it upstream and make proposals for that.

Still awaiting proposals.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat isn't marked as read if user clicks on notification from Notification Center
What is the root cause of that problem?
The macOS notification center remains open even after clicking on a notification, causing browserWindow.isFocused() to become false.
What changes do you think we should make in order to solve the problem?
It's not possible to programmatically close or dismiss the macOS Notification Center from an Electron app.
We can trigger readNewestAction, each time we click the notification item. Change this code to:
        Modal.close(() => {
            const policyID = lastVisitedPath && extractPolicyIDFromPath(lastVisitedPath);
            const policyEmployeeAccountIDs = policyID ? getPolicyEmployeeAccountIDs(policyID) : [];
            const reportBelongsToWorkspace = policyID ? doesReportBelongToWorkspace(report, policyEmployeeAccountIDs, policyID) : false;
            if (!reportBelongsToWorkspace) {
                Navigation.navigateWithSwitchPolicyID({route: ROUTES.HOME});
            }
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
            readNewestAction(reportID);
        });

What alternative solutions did you explore? (Optional)

Proposal Updated
Suggest creating debouncedReadNewestAction for further optimization.

@ishpaul777 bump - if you want I can reassign while you're at less than 100%.

@ishpaul777 thanks for your feedback. My proposal Updated
Move prev main solution to alternative, Add new solution with new referrer querystring param

@ishpaul777 tested it on the web, I didn't notice any difference in behavior. However, since the issue only arises on desktops, it would be a good idea to limit the change to desktops for safety reasons.

i say this becuase it doesn't directly fix root cause

I agree with it. It's a workaround, but we don't have many options since the IsVisible in the browser and electron (desktop) is expected to behave differently.
In Electron, the document.visibilityState inside isVisible function might behave differently because it's not a traditional web environment. The visibility of the Electron window might not be tied to the visibility of the tab in the same way it is in a browser. For example, an Electron app doesn't have tabs, so the concept of a tab being hidden doesn't really apply.

Issue not reproducible during KI retests. (First week)

@ishpaul777 any thoughts on @wildan-m's response? Separately, it looks like this didn't show up in tests. Is the fix still necessary for another reason?

@ishpaul777 The PR is ready for review

On hold for merge freeze, but we're ready to go otherwise.

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week)

Payment Summary:

Contributor: @wildan-m $500 paid via upwork
Reviewer: @ishpaul777 $500 paid via upwork

@ishpaul777 can you complete the checklist?

Nice one - done!


[FEATURE] - [EDM] - Add a "type" parameter to a decision rule

The type parameter is meant to make it possible to group together different actions. This allows to divide actions between, for instance, verbal and non-verbal. Each group may then have a different decision cycle.

The keyword layer will be used instead to better represent the purpose of this field. The idea is to create a multi-layered decision making process


Image url

Currently I want to load image from url not from local, and this is the code I use and it is not working, please help me to resolve this
        <Svg
          width= {Layout.window.width}
          height={Layout.window.height/2}
        >
          <Circle
            cx={data.xAxis}
            cy={data.yAxis}
            r="10"
            fill={data.departmentColorCode}
          />
          <Image
                    width="100%"
                    height="100%"
                    preserveAspectRatio="xMidYMid slice"
                    opacity={0.5}
                 href={{uri:data.floorImage}}/>
        </Svg>
      </View>

I had solution by using react-native-fetch-blob

@hle50 Care to share any code, seems like i've hit the same problem as you. I'm working with react-native-fetch-blob but can't seem to get the SVG  element to display..

This seems to work for me  href={{ uri: '<remote-image-url', __packager_asset:true }} . Good luck! @hle50 @ @fendorio @magicismight

Thanks @nadude  i'll test this tomorrow and let the thread know how it went!

Any solution to this yet?

@hle50 can u post ur solution?

@sibelius Check here https://snack.expo.io/@msand/image-from-uri-inside-svg

hi @msand does this only work for apps via expo and not when importing Image from react-native-svg? Just tried this in a plain react native project i get the error:
JSON value '{
    uri = "https://avatars2.githubusercontent.com/u/1131362?s=460&v=4";
}' of type NSMutableDictionary cannot be converted to an image. Only local files or data URIs are supported.

Do we have to convert the image to a data uri before passing it into the href?

@ricklancee Oh, I didn't try in plain RN or iOS, just a Snack and Android. Having a filecache certainly seems like a great idea! Thanks for the example!

@ricklancee that seems like a good solution.
However, I am having trouble loading RNFetchBlob. It says undefined is not an object (evaluating 'RNFetchBlob.DocumentDir').
Can you post your package.json so that I can make sure I'm trying with the same set of files?
Regards,

@sanealytics i pasted the code from a typescript project so it might not be 100% working. Maybe check the RNFetchBlob docs if you installed it correctly https://github.com/wkh237/react-native-fetch-blob
im using versions:
    "react": "16.2.0",
    "react-native": "0.53.0",
    "react-native-svg": "^6.2.2",
    "react-native-fetch-blob": "^0.10.8",

RN 0.54 now has Blob support and Expo will probably get in the next version later this month https://github.com/expo/expo/issues/123
If you're trying this on expo, it won't work because it's a native dependency and requires linking.

ah, that's what it is... thanks.

OK, I am where you are (I think) after ejecting and hooking things up to the Android simulator (on ubuntu). I am also matching your version numbers.
The good news is that it works. Unfortunately, it is unstable.
When I start the app, no image show up initially, upon refresh, fallback image shows up. But it never changes to the fetched image.
I then added am SVG text component to show the base uri.
Now on start, fallback image flashes and then fetched image shows up. This is the correct behavior.
However, if I refresh again, I either get a blank, base image or the correct image intermittently.
Here is the modestly modified code. I am using an android simulator now.
import React from 'react'
import { View } from 'react-native'
import RNFetchBlob from 'react-native-fetch-blob'
import { Svg, Image, Text } from 'react-native-svg'

export default class SVGImage extends React.Component {

    state = { uri: undefined }

    async componentWillMount() {
        const { targetURI } = this.props

        try {
            const res = await RNFetchBlob
               .config({
                  // add this option that makes response data to be stored as a file,
                  // this performs better
                  fileCache : true,
                  // by adding this option, the temp files will have a file extension
                   appendExt : 'jpg',
               })
              .fetch('GET', targetURI)

            this.setState({
                uri: `file://${res.path()}`,
            })
        } catch (error) {
            console.error(error)
        }
    }

   render() {
        const { uri } = this.state
        return (
            <Svg
                height="200"
                width="400"
                viewBox="0 0 100 100"
            >
                <Image
                    x="50%"
                    y="0"
                    width="25%"
                    height="100%"
                    preserveAspectRatio="xMidYMid slice"
                    href={!uri ? require('./image.jpg') : { uri }}
                />
                <Text
                    x="0"
                    y="100"
                    fontSize="5"
                    fill="black"
                    stroke="purple"
                    textAnchor="middle"
                >
                    { uri }
                </Text>
            </Svg>
        )
    }
}

You use the above component like so from the main app
I guess that having to show the <Text> to make it work is a clue, but don't know enough to see what it means.
Should there be a delay of some sort?
Regards

@sanealytics I had the same issue on android where the image would not get switched out once loaded. This was my work around: switching the image component out for a new one:
I don't know if this is a bug caused by react-native-svg or something else.
{!uri ? (
    <Image
        x="50%"
        y="0"
        width="25%"
        height="100%"
        preserveAspectRatio="xMidYMid slice"
        href={require('./image.jpg')}
    />
) : (
    <Image
        x="50%"
        y="0"
        width="25%"
        height="100%"
        preserveAspectRatio="xMidYMid slice"
        href={{ uri }}
    />
)}

hmm, unfortunately, I have the same behavior as before  :cry:

#630


Consider to introduce initialPosition property

As a user, i want to set the initial position for time picker, as same as the usage in date-picker

So that the contained iron-list would initially be scrolled to the given value?
In time-picker's case it's not nearly as crucial (very limited scroll height) as with date picker where the scroll height is unlimited.

Related: https://github.com/vaadin/vaadin-date-time-picker-flow/issues/19


Create Profile page

Feature for sprint 3
Page should display:

[x] questions asked,

[x] replies provided,

[x] and "profile rep" (e.g. accumulation of points based on answers and/or questions)

settings function such as password change, email  #129

display total points?

This is the command line for the test

Added background change for the user


Update for 0.7.1 release

tks tks

@brentvatne So I guess calling dispatch_async inside our methods is no longer needed.

@isair - truth, this will happen by default now, good catch


Add some difficulty in farming

Maybe we can change the soil in dirt wen the player harvest.

The farming mod is like that because we choose it :)
A long itme ago we speak about this feature and the majority answered was "NO", so we didn't add this feature.
Thank you for your report, but this point will no change.


fix: curl import error

Description
Send only pageId for redirect call.
Fixes #15175
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manually
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=cc03a40

Approving for now but we'll need to fix types in a separate PR.

/ok-to-test sha=2bf44ff

@eco-monk Tested the dp and it fixes the issue.


Collection types can be updated by delta

AC

All collection types will be updatable by delta
The configuration will work the same as the numeric types, but a matching strategy will need to be provided
The matching strategies to be initially supported are by a single or multiple properties
The matching strategies should be extensible so others can be written as needed
On update, items will be inserted, updated or removed from the MongoDB collection, instead of the entire collection being overwritten

Updating collections ideas
These are some ideas with increasing levels of complexity of how to implement tracked changes of collections
HashSet
This mode will update using a replace strategy, as if the collection was a HashSet.
Implementation details
Internally, MongoDelta will compare the original and current values of the collection as a HashSet. It will then use $addToSet to add any items that exist in current but not in original, and use $pull to delete any items that exist in original but not current.
Configuration
public class BlogPost{
    public HashSet<string> Tags {get; set;}
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Tags).UpdateAsHashSet<string>();
});

Limitations

If 2 documents contained in this collection are updated concurrently, there is a strong chance that the document will be duplicated, but with the 2 new values
As this is a set, duplicate values aren't supported
The order of items in the collection are not consistent

DeltaSet
This mode will update using a delta update strategy. The type of items in the collection must have a mapped id member.
Implementation details
Change tracking in the collection itself will use a HashSet again, with a custom IEqualityComparer that uses the mapped id property. If the item type in the collection uses the delta update strategy, the sub-object change tracker can be repurposed to see if an item needs updating.
In MongoDB, this collection will be repersented as a dictionary, with the id as the key. This means that a custom serializer will have to be written that also implements IBsonArraySerializer.
Configuration
public class BlogPost{
    public Guid Id { get; set; }
    public List<Comment> Comments { get; set; }
    ...
}
public class Comment{
    public Guid Id { get; set; }
    ...
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Comments).UpdateAsDeltaCollection<Comment>();
});

Limitations

As this is a set, duplicate ids aren't supported
The order of items in the collection aren't consistent

Unique List
This mode will have pretty much the same behavior as the HashSet, except that the order of the collection will be maintained.
Implementation details
The collections will still be compared as a HashSet, but the BsonValue will be wrapped in another class that stores a double value containing it's position.
To decide how to update, the Myers diff algorithm will be used, comparing the original collection to the current collection. For objects that are added, or removed and added, the value for it's position will be determined by the midpoint of the surrounding objects, +- a random offset which still keeps the objects in the same order.
Configuration
public class BlogPost{
    public HashSet<string> Tags {get; set;}
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Tags).UpdateAsUniqueList<string>();
});

Limitations

Values must be unique
If the collection is updated consecutively, the order can a guarenteed to a high level, but if updated concurrently, the order of items will be maintained as a best effort
If objects are continuously added into the same position, it is possible that the limit of precision for doubles could be reached

Delta List
This will work pretty much the same as the DeltaSet, with the order tracking of the UniqueList.
Configuration
public class BlogPost{
    public Guid Id { get; set; }
    public List<Comment> Comments { get; set; }
    ...
}
public class Comment{
    public Guid Id { get; set; }
    ...
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Comments).UpdateAsDeltaList<Comment>();
});

Limitations
Same as UniqueList# Updating collections ideas
These are some ideas with increasing levels of complexity of how to implement tracked changes of collections
HashSet
This mode will update using a replace strategy, as if the collection was a HashSet.
Implementation details
Internally, MongoDelta will compare the original and current values of the collection as a HashSet. It will then use $addToSet to add any items that exist in current but not in original, and use $pull to delete any items that exist in original but not current.
Configuration
public class BlogPost{
    public HashSet<string> Tags {get; set;}
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Tags).UpdateAsHashSet<string>();
});

Limitations

If 2 documents contained in this collection are updated concurrently, there is a strong chance that the document will be duplicated, but with the 2 new values
As this is a set, duplicate values aren't supported
The order of items in the collection are not consistent

DeltaSet
This mode will update using a delta update strategy. The type of items in the collection must have a mapped id member.
Implementation details
Change tracking in the collection itself will use a HashSet again, with a custom IEqualityComparer that uses the mapped id property. If the item type in the collection uses the delta update strategy, the sub-object change tracker can be repurposed to see if an item needs updating.
In MongoDB, this collection will be repersented as a dictionary, with the id as the key. This means that a custom serializer will have to be written that also implements IBsonArraySerializer.
Configuration
public class BlogPost{
    public Guid Id { get; set; }
    public List<Comment> Comments { get; set; }
    ...
}
public class Comment{
    public Guid Id { get; set; }
    ...
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Comments).UpdateAsDeltaCollection<Comment>();
});

Limitations

As this is a set, duplicate ids aren't supported
The order of items in the collection aren't consistent

Unique List
This mode will have pretty much the same behavior as the HashSet, except that the order of the collection will be maintained.
Implementation details
The collections will still be compared as a HashSet, but the BsonValue will be wrapped in another class that stores a double value containing it's position.
To decide how to update, the Myers diff algorithm will be used, comparing the original collection to the current collection. For objects that are added, or removed and added, the value for it's position will be determined by the midpoint of the surrounding objects, +- a random offset which still keeps the objects in the same order.
Configuration
public class BlogPost{
    public HashSet<string> Tags {get; set;}
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Tags).UpdateAsUniqueList<string>();
});

Limitations

Values must be unique
If the collection is updated consecutively, the order can a guarenteed to a high level, but if updated concurrently, the order of items will be maintained as a best effort
If objects are continuously added into the same position, it is possible that the limit of precision for doubles could be reached

Delta List
This will work pretty much the same as the DeltaSet, with the order tracking of the UniqueList.
Configuration
public class BlogPost{
    public Guid Id { get; set; }
    public List<Comment> Comments { get; set; }
    ...
}
public class Comment{
    public Guid Id { get; set; }
    ...
}

BsonClassMap.RegisterClassMap<BlogPost>(map =>
{
	map.UseDeltaUpdateStrategy();
	map.MapProperty(m => m.Comments).UpdateAsDeltaList<Comment>();
});

Limitations
Same as UniqueList

The work for ordered collections will be moved to issue #49 so that the current work done on this issue can be released faster


week 8: possible static analysis tool

https://github.com/marketplace/actions/code-review-using-jshint

seems to be a bit weird, has a merge base error that occurs and not clear why as the fetch-depth is set to max. can probably look at alternatives

also find a security static analysis tool?

After research qodana proved to be the best, initially Planned SonarScan Cloud but switched


:wastebasket: Removal of Tekton downstream tests

Changes

:wastebasket: Removal of Tekton downstream tests

/kind removal
Fixes https://github.com/knative/pkg/issues/2643
Fixes https://github.com/knative/actions/issues/86
Closes https://github.com/tektoncd/pipeline/pull/5783
Tekton doesn't rely on the latest of knative/pkg, so probably we could remove downstream test for them. See: https://github.com/tektoncd/pipeline/pull/5783#issuecomment-1325069931

/assign @dprotaso
/cc @vdemeester
/cc @imjasonh

/retest

/lgtm
/approve


Add companion actor model

Though we don't have much information on them yet, we know that Companion NPCs have their own behavior that diverges from the character and adversary model.
Notably, spren and other companions have a given role which impacts their tests and health accordingly.
While we don't have much more information on them yet, we should still establish Companion as a non-Adversary, non-player-Character Actor type in the data model for later work

Little bit of a mixup in the discord, Companions are still inherently handled through the Adversary model. No work needed on this.


chore: upgrade to elasticsearch 8 work in progress

WIP @willtj

@StevePorter92 these changes seem to have done the trick.


Add Compose Multiplatform Auth module

What kind of change does this PR introduce?
Feature (see #212 and #233)
What is the current behavior?
For Native Auth and Auth UI Components, you have to rely on third party libraries or implement them yourself.
What is the new behavior?
The compose-auth module (name subject to change) current contains the following features:
A Native Google login Composable for Compose Multiplatform:
//in your Auth Screen
val state = rememberNativeSignInState()
NativeGoogleLogin(
    state = state,
    clientId = "YOUR_CLIENT_ID",
    nonce = "NONCE", //optional nonce
    onResult = { result: NativeSignInResult ->
        when(result) {
            NativeSignInResult.AccountNotFound -> {} //show error dialog
            NativeSignInResult.Canceled -> {} //show error dialog
            NativeSignInResult.ClosedByUser -> {} //show error dialog
            NativeSignInResult.NetworkError -> {} //show error dialog
            is NativeSignInResult.Error -> { println(result.message) }
            is NativeSignInResult.Success -> {
                /*in your ViewModel call
                gotrue.loginWith(IDToken) {
                    idToken = result.idToken
                    provider = Google
                    nonce = "NONCE" //optional nonce when used in the Composable
                }
                */
            }
        }
    },
    fallback = { //called when the flow started and there is no native google sign in available
        //call gotrue.loginWith(Google) e.g. in your ViewModel
    }
)
Button(  //Google Sign in Button may come also
    onClick = { state.startFlow() },
) {
    Text("Sign in with Google")
}

UI components:
Coming soon
Additional context
Feel free to share your thoughts, requests and suggestions! I'm not quite sure about the name yet.

Discussion continues in #241, UI components will follow up in a different PR


Debugger:Unable to resolve 'System.Reflection.Metadata' for '.NETCoreApp.Version=v1.0'

Environment data
dotnet --info output:
VS Code version: 1.4.0
C# Extension version: v.1.4.0-beta6
.NET Core version: 1.0.0-SDK Preview2
Steps to reproduce

Create a simple .NET Core project use command.
Open VSCode to install the C# extension of 1.4.0-beta6 , restart VSCode to make the extension takes effect.
Load the existing hwapp folder I just created on VSCode.
4.Press F5 to start debugging

Expected  behavior
The project should be start debugging.
Actual behavior
This project can't start debugging and show some error message in VSCode. Attached as below:

@chuckries @caslan I think we should pull the latest beta release until this is resolved.

I got this as well.

I am going to pull the release now.

OK. If you decide to completely delete the release, go ahead and remove the tag as well.

The GitHub documentation seems to say that it is possible to delete a release, but it isn't working for me (maybe because I didn't create it?). So I pulled the .vsix and I edited the description so that hopefully it is obvious that the release shouldn't be used. @chuckries do you want to see if you have access to delete it?

I can delete it.

Release is removed. Note: the trick is to delete the tag from GitHub, which converts the release to a "draft" release, which can be discarded.

Sorry everybody, this is my fault. I added the additional nuget feed but didn't want to push the change since it is (hopefully) a temporary workaround. I built the extension locally that works. When I created the release, the CI system built the package for the release page and it did not have my NuGet.config change. I will fix this.

This has been fixed, the System.Reflection.Metadata we need has been published to nuget.org, no workaround required.


Update to 4.6.0-0.okd-2021-01-23-132511 fails with "spec.servingCerts.namedCertificates[...].servingCertificate.name "cloud1-api.xxx.xxx" is used by other indexes: [0,0]"

Describe the bug
There seems to be a bug in the update process that prevents the kube-apiserver from updating. The kube-apiserver-operator prints the following error message:
I0127 12:15:14.928504       1 request.go:645] Throttling request took 1.950880247s, request: GET:https://<IP_ADDRESS>:443/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=apiserver%3Dtrue
I0127 12:15:15.346392       1 termination_observer.go:236] Observed event "TerminationStart" for API server pod "kube-apiserver-cloud1-control-2" (last termination at 2021-01-19 15:55:17 +0000 UTC) at 2021-01-27 12:15:15 +0000 UTC
I0127 12:15:15.438774       1 termination_observer.go:236] Observed event "TerminationPreShutdownHooksFinished" for API server pod "kube-apiserver-cloud1-control-2" (last termination at 2021-01-19 15:55:17 +0000 UTC) at 2021-01-27 12:15:15 +0000 UTC
I0127 12:15:15.614958       1 event.go:282] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-kube-apiserver-operator", Name:"kube-apiserver-operator", UID:"a2dea499-7df2-4187-ad7c-c25569d36f69", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal
' reason: 'ConfigMapUpdated' Updated ConfigMap/kube-apiserver-client-ca -n openshift-config-managed:
cause by changes in data.ca-bundle.crt
W0127 12:15:15.636932       1 observe_apiserver.go:216] errors during apiservers.config.openshift.io/cluster processing: [spec.servingCerts.namedCertificates[...].servingCertificate.name "cloud1-api.one.xxx.com" is used by other indexes: [0,0]]
E0127 12:15:15.637510       1 base_controller.go:250] "ConfigObserver" controller failed to sync "key", err: spec.servingCerts.namedCertificates[...].servingCertificate.name "cloud1-api.one.xxx.com" is used by other indexes: [0,0]
W0127 12:15:15.637920       1 observe_apiserver.go:216] errors during apiservers.config.openshift.io/cluster processing: [spec.servingCerts.namedCertificates[...].servingCertificate.name "cloud1-api.one.xxx.com" is used by other indexes: [0,0]]
E0127 12:15:15.638366       1 base_controller.go:250] "ConfigObserver" controller failed to sync "key", err: spec.servingCerts.namedCertificates[...].servingCertificate.name "cloud1-api.one.xxx.com" is used by other indexes: [0,0]
I0127 12:15:15.928572       1 request.go:645] Throttling request took 2.389906974s, request: GET:https://<IP_ADDRESS>:443/api/v1/namespaces/openshift-kube-apiserver/pods?labelSelector=apiserver%3Dtrue

We were not able to find anything about this specific error message.
Version
4.5.0-0.okd-2020-10-15-235428 on bare metal with UPI
How reproducible
Use snapshot that was made before starting the update process and start it again. The Installer gives the same error message.

Please attach (or upload to the public file sharing service) must-gather archive

Please attach (or upload to the public file sharing service) must-gather archive

I will try, at the moment it exposes to much information.

I will try, at the moment it exposes to much information.

Ok, we found the problem:
 oc get apiserver cluster -o yaml
...
  servingCerts:
    namedCertificates:
    - names:
      - cloud1-api.one.xxx.com
      - api.cloud1.xxx.de
      - openshift.cloud1.xxx.de
      - openshift
      - api
      - cloud1-api.one.xxx.com
      servingCertificate:
        name: api-xxx

The line "cloud1-api.one.xxx.com" was present two times. As soon as we removed the second entry, the update was making progress again.

Ok, we found the problem:
 oc get apiserver cluster -o yaml
...
  servingCerts:
    namedCertificates:
    - names:
      - cloud1-api.one.xxx.com
      - api.cloud1.xxx.de
      - openshift.cloud1.xxx.de
      - openshift
      - api
      - cloud1-api.one.xxx.com
      servingCertificate:
        name: api-xxx

The line "cloud1-api.one.xxx.com" was present two times. As soon as we removed the second entry, the update was making progress again.


Remove the use of BV sorts in the typechecker

This is a step in removing the .sort field of BV occurrences. The typechecker currently makes heavy use of it to typecheck terms, since it just trusts that field instead of checking its environment to find the variable. This PR removes that use, and fixes some parts of the typechecker+encoding to account for that.
I will run a perf comparison and post the results.

This looks great, Guido! Thanks! I've left a few localized comments. Do take a look and merge at your discretion. It would be great to get this into master.
Looking forward also to a subsequent PR to actually remove the sort field in the payload of Tm_name.

Merging soon. I did run a perf comparison and noticed no significant difference.


Fixed broken links

Two of these fixes are not obvious. They originally linked to articles in  https://docs.microsoft.com/cpp/misc/, which were deleted in https://github.com/Microsoft/cpp-docs/commit/3fa92896d. Their original forms were effectively just redirects, which I followed:

generate-from-usage
static-cpp

@svick We ended up with some conflicts with all the changes going on right now. Do you want to see if you can fix the branch on your end? If you're busy, I can try to set up your changes on a new branch. Let me know how you want to play it.

@GuardRex Rebased.

@svick Thanks!
LINQ docs moved, but I think it more efficient if we hit that in another PR, where we go through the entire redirection file and get all of our internal 301's squared away in one shot.
Let's :shipit: now.


User Secrets with Update-Database command

I have a .NET Core application that is available on GitHub. It makes use of User Secrets. When I check out the application, define my local User Secret variables and run Update-Database in the Package Manager Console, I get the following error:

Do EF Core migrations not work with User Secrets? What am I doing wrong?
Further technical details
<ItemGroup>
  <PackageReference Include="IdentityServer4" Version="2.3.2" />
  <PackageReference Include="IdentityServer4.AspNetIdentity" Version="2.3.0" />
  <PackageReference Include="Microsoft.AspNetCore.App" />
  <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="2.2.0" PrivateAssets="All" />
  <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.2.0" />
  <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="2.2.0" />

  <PackageReference Include="Serilog" Version="2.8.0" />
  <PackageReference Include="Serilog.AspNetCore" Version="2.1.1" />
  <PackageReference Include="Serilog.Sinks.Console" Version="3.1.1" />
  <PackageReference Include="Serilog.Sinks.File" Version="4.0.0" />
</ItemGroup>

Database Provider: Postgres via Npgsql
Operating system: Windows 10 x64
IDE: Visual Studio 2019 Preview (version 16, Preview 4.2)

@JwanKhalaf Please post the output from running with the "verbose" option.

@ajcvickers it turns out, I had to set the ASPNETCORE_ENVIRONMENT variable first.
For anyone reading this in the future, in order to set ASPNETCORE_ENVIRONMENT from within Package Manager Console, you run the following command.
$env:ASPNETCORE_ENVIRONMENT='Production'

Obviously, you would replace Production with whatever environment you want to target (e.g. Develop).
I'll close the issue.


Can't put null into the database?

Why can't we put null into our database?
Some api calls are not going to return all data right away, but the column still needs to be created, and ideally nulls should be interested into the tables.
In SQLite I can do with putNull(key);
I'm currently looking into using SugarORM, and inserting data via from json returned from api calls. It's extremely common for API calls to return null for certain fields, so I would like to insert those nulls into the database.
Considering it's already supported in SQLite I'm surprised it's not available in Sugar.

I don't think you can use null for @unique fields. I think all the fields of your persistent class are used as columns and so when you don't set a value for a field, it is set as null. So when you retrieve the data, that filed will be null for the given instance. What have you tried so far?

I have moved away from SugarOrm in favour of Realm. However when I was working on this I had helper methods that took the data from the json, whether it was null or not and inserted it into my database. So everything from the json was always updated into the database.
With SugarORM this through an exception. I guess it's not an issue for me anymore, but for other users of SugarOrm i would think this should be working.
I was essentially going sugarOrmoBJ.setId(null) for some data which caused an NPE exception.

Any news about this ? As you guys says, i can't save null values. For example, i have a Class User which has an Address object, but sometimes the address is null and SugarORM don't allows me to save null in the Address column for the User Table.

Well for the moment i will pass to Realm like @MiralDesai


Airflow plugin does not support dynamic task mapping

Describe the bug
Any DAG task using Airflow's dynamic task mapping will crash when using the Airflow plugin as it can't set the on success/failure callbacks.
Versions:

apache-airflow==2.4.2
acryl-datahub-airflow-plugin==<IP_ADDRESS>

Here is an example stacktrace:
[2022-12-01 23:21:36,883] {dagbag.py:322} DEBUG - Importing /home/jovyan/airflow/dags/taskflow.py
Setting task policy for Dag: taskflow Task: make_list
Setting task policy for Dag: taskflow Task: printer
[2022-12-01 23:21:36,904] {dagbag.py:564} ERROR - can't set attribute
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/airflow/models/dagbag.py", line 551, in collect_dags
    found_dags = self.process_file(filepath, only_if_updated=only_if_updated, safe_mode=safe_mode)
  File "/opt/conda/lib/python3.8/site-packages/airflow/models/dagbag.py", line 307, in process_file
    found_dags = self._process_modules(filepath, mods, file_last_changed_on_disk)
  File "/opt/conda/lib/python3.8/site-packages/airflow/models/dagbag.py", line 437, in _process_modules
    self.bag_dag(dag=dag, root_dag=dag)
  File "/opt/conda/lib/python3.8/site-packages/airflow/models/dagbag.py", line 464, in bag_dag
    self._bag_dag(dag=dag, root_dag=root_dag, recursive=True)
  File "/opt/conda/lib/python3.8/site-packages/airflow/models/dagbag.py", line 481, in _bag_dag
    settings.task_policy(task)
  File "/opt/conda/lib/python3.8/site-packages/datahub_provider/_plugin.py", line 292, in custom_task_policy
    task_policy(task)
  File "/opt/conda/lib/python3.8/site-packages/datahub_provider/_plugin.py", line 281, in task_policy
    task.on_failure_callback = _wrap_on_failure_callback(task.on_failure_callback)
AttributeError: can't set attribute

To Reproduce
Steps to reproduce the behavior:
Here is a basic DAG that crashes when trying to run with Datahub configured as the lineage backend (using the plugin).
from __future__ import annotations

import pendulum

from airflow.decorators import dag, task

@dag(
    schedule=None,
    start_date=pendulum.datetime(2021, 1, 1, tz="UTC")
)
def taskflow():

    @task()
    def make_list():
        return ['Hello', 'World']

    @task()
    def printer(val):
        print(val)

    printer.expand(val=make_list())

taskflow()

It seems like this bug has been reported in the past as well: https://github.com/datahub-project/datahub/issues/5583
Expected behavior
I'm not quite sure how we should handle lineage for task mapping. At the very least, the lineage for these types of tasks should either be skipped or trigger a warning.
We would like to use the latest version of this plugin which supports Airflow 2.4, but we have several users using dynamic task mapping which would break their tasks.
Desktop (please complete the following information):

Linux Ubuntu - using Airflow's official docker image

I looked into this briefly and it seems like we can't update task properties when the operator is a MappedOperator. I've asked a question related to this issue in an existing Airflow issue: https://github.com/apache/airflow/issues/24547#issuecomment-1341523888
As a temporary workaround, we filter our mapped tasks by checking isinstance(task, MappedOperator) before the code here: https://github.com/datahub-project/datahub/blob/8a8b667a529ef728584a489f2555d2416fa60683/metadata-ingestion/src/datahub_provider/_plugin.py#L297. That would allow the policy to be applied to non mapped operators.
@hsheth2 I can put up a PR for the above solution if its deemed acceptable while we wait for a response from the Airflow maintainers.

Yep that workaround seems pretty reasonable, and a PR would be great! We’ll probably want to print a warning and add a note in the docs for this as well - happy to provide guidance on that.

Talked to the Airflow folks about the issue, I'll be putting up a PR to allow setting those properties on MappedOperators. It's been labelled a feature so not sure when it will be released..
In the meantime, I'll submit a PR for this issue.

Going to close this, as https://github.com/datahub-project/datahub/pull/6738 was merged


Copy doesn't always work

Select all + copy in http://vizor.io/matt/default/edit
doesn't copy anything for me

and now it does after restarting browser, weird.. must have been chrome being funny

I've had this a few times, but can't reliably reproduce, sometimes cmd+c just doesn't copy anything within the browser window


Support for unicode-range

Fonts are often distributed in multiple files. eg. character š is on Google Fonts in separated file.
unicode-range allows download font files only if contained characters are used in page.
https://fonts.googleapis.com/css?family=Barlow+Condensed:400,700

Great! What would that look like? How is it used, and what would we have to do in order to support it? Thanks!

Only change in that library should be addition of unicode-range to output and allow multiple fonts with same name. It's still the same font, just divided into multiple files.
$fonts: (
  'Barlow Condensed - Latin Extended': (
    'name': 'Barlow Condensed',
    'normal': 'barlow-condensed/normal-latin-extended',
    'unicode-range': U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF
  ),
  'Barlow Condensed - Latin': (
    'name': 'Barlow Condensed',
    'normal': 'barlow-condensed/normal-latin',
    'unicode-range': U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215
  ),
);

Oh, this is great. I wasn't aware of the feature. Here's more detail for reference:
https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/unicode-range
Happy to accept a pull request, or I'll add it when I have time.

I would like to send PR but my attempts for more complex programming in sass are always catastrophical, I am sorry.
Thank you


Remove jQuery as a dependency

This PR removes jQuery as a dependency and replaces the outer/inner width/height methods with a single function that handles all scenarios. Will need to do further testing in browser and within unit tests to verify the numbers are correct.

Some screenshots of the calculations in action. Compare the numbers in the console to the dimensions of the hovered element.

I'm not sure how to write unit tests for this as their is no DOM. There were no tests before for it anyways.

Yeah of my TODOS is to enable dom testing at some point which would help.
You could stub some things but it might be somewhat meaningless.
Do the height animations still work?
On Fri, Aug 19, 2016, 12:26 PM Miles Johnson<EMAIL_ADDRESS>wrote:

Some screenshots of the calculations in action. Compare the numbers in the
console to the dimensions of the hovered element.
[image: screen shot 2016-08-19 at 10 19 17 am]
https://cloud.githubusercontent.com/assets/143744/17818187/4e46920c-65f7-11e6-89ab-1b459ec7686c.png
[image: screen shot 2016-08-19 at 10 19 25 am]
https://cloud.githubusercontent.com/assets/143744/17818188/4e48a20e-65f7-11e6-9e28-abe3d4fe2a6d.png
[image: screen shot 2016-08-19 at 10 20 02 am]
https://cloud.githubusercontent.com/assets/143744/17818189/4e56345a-65f7-11e6-8d88-b9bce121e17a.png
I'm not sure how to write unit tests for this as their is no DOM. There
were no tests before for it anyways.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/react-dates/pull/16#issuecomment-241080683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUdtT8453n1h1VUSvNQkIaP8lKubL2tks5qhec5gaJpZM4Jn7x5
.

Also can we test cross-browser before we merge this in?
On Fri, Aug 19, 2016, 12:28 PM Maja Wichrowska<EMAIL_ADDRESS>wrote:

Yeah of my TODOS is to enable dom testing at some point which would help.
You could stub some things but it might be somewhat meaningless.
Do the height animations still work?
On Fri, Aug 19, 2016, 12:26 PM Miles Johnson<EMAIL_ADDRESS>wrote:

Some screenshots of the calculations in action. Compare the numbers in
the console to the dimensions of the hovered element.
[image: screen shot 2016-08-19 at 10 19 17 am]
https://cloud.githubusercontent.com/assets/143744/17818187/4e46920c-65f7-11e6-89ab-1b459ec7686c.png
[image: screen shot 2016-08-19 at 10 19 25 am]
https://cloud.githubusercontent.com/assets/143744/17818188/4e48a20e-65f7-11e6-9e28-abe3d4fe2a6d.png
[image: screen shot 2016-08-19 at 10 20 02 am]
https://cloud.githubusercontent.com/assets/143744/17818189/4e56345a-65f7-11e6-8d88-b9bce121e17a.png
I'm not sure how to write unit tests for this as their is no DOM. There
were no tests before for it anyways.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/react-dates/pull/16#issuecomment-241080683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUdtT8453n1h1VUSvNQkIaP8lKubL2tks5qhec5gaJpZM4Jn7x5
.

I've tested it on Mac FF/Chrome/Safari with no issues. Trying to test IE and mobile.

Trying to test IE and mobile.

I can test in IE + Edge for you if you provide a public URL where I can hit your fork! :smile:

@Daniel15 I won't be using a public URL. Was just going to be testing locally.

I tested in IE11 and Edge with no issues. Storybook doesn't work in IE9/10, so can't verify.
Also, note to self, update this code. (I can't because of Windows line endings).
  calculateDimension(el, axis, borderBox = false, withMargin = false) {
    if (!el) {
      return 0;
    }

    const style = window.getComputedStyle(el);
    const axisStart = (axis === 'width') ? 'Left' : 'Top';
    const axisEnd = (axis === 'width') ? 'Right' : 'Bottom';

    // Includes border and padding
    let size = (axis === 'width') ? el.offsetWidth : el.offsetHeight;

    // Get the inner size
    if (!borderBox) {
      size -= (
        parseFloat(style[`padding${axisStart}`]) +
        parseFloat(style[`padding${axisEnd}`]) +
        parseFloat(style[`border${axisStart}Width`]) +
        parseFloat(style[`border${axisEnd}Width`])
      );
    }

    // Apply margin
    if (withMargin) {
      size += (
        parseFloat(style[`margin${axisStart}`]) +
        parseFloat(style[`margin${axisEnd}`])
      );
    }

    return size;
  }

@ljharb @majapw Updated the code. Added some stub tests as well.
All I really need to do is test IE8/9/10, but not sure how, because storybook does not work in it.

@milesj So the best bet is probably to do this using airbnb.com at this point. We can npm link to this repo locally and specifically to this branch, and check to see if our homepage works as expected. I can probably do this later today or tomorrow, although it will probably require another PR first. Are you okay with holding off on this for a few more days? We can have this in a minor release then.
I really don't want to merge this in and then after the fact discover that things are broken in those browsers.

Yeah, no problem. No rush to get this out right now.

So I tested on IE9, and it works as expected (no animations, but no errors). Same as before.
IE10 works well. :) Have you looked at mobile safari and mobile chrome?

Haven't tested mobile, but I don't foresee any issues. It's pretty straight forward.
I'll rebase tomorrow morning.

Awesome. :+1:
On Thu, Sep 1, 2016, 7:19 PM Miles Johnson<EMAIL_ADDRESS>wrote:

Haven't tested mobile, but I don't foresee any issues. It's pretty
straight forward.
I'll rebase tomorrow morning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/react-dates/pull/16#issuecomment-244266368,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUdtYqFrphZnPfkOacWMIggg-X7YyC4ks5ql4eUgaJpZM4Jn7x5
.

@majapw Rebased. Passed linting and tests locally.


Added tokens in wordlists

Hello @NriotHrreion, Thanks for the Pull Request. It includes interesting words and sentences. However some words seems too much difficult to type. Can you please add separate wordlist for hard difficulty words?
Also I see too many common sentences starting with "I". The wordlist should contains random words and sentences for better typing test.

Hello @NriotHrreion, Thanks for the Pull Request. It includes interesting words and sentences. However some words seems too much difficult to type. Can you please add separate wordlist for hard difficulty words?
Also I see too many common sentences starting with "I". The wordlist should contains random words and sentences for better typing test.

Yes. But I'm not so sure about what the random sentences means. Do you mean those sentences added by me are too simple?

Yeah, those sentences are way too simple. Can you also rename the "difficult" wordlist to "hard words"?


configuration lost when Heroku dynos restart

When dynos restart the app looses configuration because it's saving configuration to the filesystem (default behavior). Piwik has a configuration option to save everything to the DB by setting:
session_save_handler = dbtable

http://piwik.org/faq/how-to-install/faq_133/
Any chance this configuration can be built into this package?

That's only session data, you still need to persist config file. The easiest way is to add it to repo once you created project(security wise this is not good). Another way is to populate config file during "heroku compile".
TLDR; Working on it :)

@dz0ny sorry to bump an old issue, but I'm having exactly this problem with a deploy I only created a few days ago - all the environment variables are set, and I followed all the instructions as far as I can tell. It's like the replace isn't happening in config.ini, but I've no idea what I've missed that means that's not happening. I'm running a hobby dyno on Heroku with Jaws MariaDB, and it all works fine apart from losing config on dyno restart. Any ideas?

I too am confused about where the intended settings for the database goes — I have this working with a remote database (in my case it happens to be Amazon RDS), I can get through the setup, but upon restarting the dynos it reverts to the original settings. I've tried modifying config.ini.php, and removing line 1, each time I restart the dynos the app reverts to the start-up screen.
I read some comments about creating an over-ride file at vendor/piwik/piwik/config.ini.php
I went to attempt this, but vendor/ is in the .gitignore, so I think I may misunderstand something. Is the creating of the override file something that happens inside of the Heroku?
I have specified DB_HOST, DB_NAME, DB_PASSWORD, DB_PORT, DB_USERNAME as config vars on my heroku app, but it seems to not be able to pick those up.


fix: Support for New Variables

Adds support for the new Chat Strategy variables in X-NLU.

:tada: This PR is included in version 2.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Try TCP_FASTOPEN socket option with mptcp

With support for TCP_FASTOPEN in newer kernels, allow ATS to try to use TCP_FASTOPEN with mptcp enabled

Where is TCP_FASTOPEN defined?
% grep -Ir "TCP_FASTOPEN"
./doc/admin-guide/files/records.yaml.en.rst:        TCP_FASTOPEN (8)
./doc/admin-guide/files/records.yaml.en.rst:   Note: If MPTCP is enabled, TCP_NODELAY is only supported on Linux kernels 5.17+. TCP_FASTOPEN
./doc/admin-guide/files/records.yaml.en.rst:        TCP_FASTOPEN (8)
./src/proxy/http/HttpProxyServerMain.cc:#ifdef TCP_FASTOPEN
./src/iocore/net/Connection.cc:#ifdef TCP_FASTOPEN
./src/iocore/net/Connection.cc:      Warning("[Server::listen] TCP_FASTOPEN socket option not valid on MPTCP socket level");
./src/iocore/net/Connection.cc:    } else if (safe_setsockopt(fd, IPPROTO_TCP, TCP_FASTOPEN, (char *)&opt.tfo_queue_length, sizeof(int))) {

We don't define it anywhere ourselves. Is it defined in a system header?

yes @JosiahWI  it's defined in the system header files tcp.h, like all of the other TCP socket options

@serrislew

Cherry-picked to v10.0.x


Update README

Update README for kytos-ng:

Replace references to kytos project for kytos-ng

The Get help section should be removed or are going to create some kind of communication channel to put here? @italovalcy @rmotitsuki @viniarck

@ajoaoff, good point, @jab1982 might have more info or plans about potential future communication channels, maybe at least we could have<EMAIL_ADDRESS>mentioned as a point of contact?

@ajoaoff The main changes looks good to me, thanks for updating the readme, I've noticed in the rendered readme directly on GitHub on this PR branch, there are some links that apparently are broken highlighted in yellow

Let's create an alias @.*** Don't use @.***,
that's internal. Also, we have a Slack workgroup for Kytos-ng.
On Thu, Jan 13, 2022 at 8:32 AM Vinicius Arcanjo @.***>
wrote:

The Get help section should be removed or are going to create some kind
of communication channel to put here? @italovalcy
https://github.com/italovalcy @rmotitsuki
https://github.com/rmotitsuki @viniarck https://github.com/viniarck
@ajoaoff https://github.com/ajoaoff, good point, @jab1982
https://github.com/jab1982 might have more info or plans about
potential future communication channels, maybe at least we could have
@.*** mentioned as a point of contact?
—
Reply to this email directly, view it on GitHub
https://github.com/kytos-ng/kytos/pull/157#issuecomment-1012139644, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADC4AM2DKW4GECY4LYTYGILUV3H53ANCNFSM5LXRA2MA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


Project and instance definition when using -cf

Hi, I would like to use your emulator in my local environment.
I tried to use -cf my_new_instance.my_new_table.my_new_column_family flag to create an instance, table and column family on container start.
I cannot see the created instance and table when I run cbt ls from my system (after having set BIGTABLE_EMULATOR_HST=localhost:9035).
I set .cbtrc like this :
instance = my_new_instance
project = my_project

Do you have an idea of why cbt does not find the newly created table / instance on the emulator.
Otherwise, when I run cbt createtable the table seems reachable from cbt because I can see it when running cbt ls afterwards.
Thanks for your help.

The project name is hard-coded to "dev" (https://github.com/Shopify/bigtable-emulator/blob/master/bigtable-emulator.go#L63). Try this command
BIGTABLE_EMULATOR_HOST=localhost:9035 cbt -project dev -instance my_new_instance ls


Error in Tailwind Config for Charts

I am trying to follow the installation from this link for the Charts
Tailwind CSS Chart - Flowbite
and tried adding plugins: [   require('flowbite/plugin')({       charts: true,   }),   // ... other plugins ]
but I got this error
[plugin:vite:css] [postcss] require(...) is not a function

I ran into a similar issue using require with TypeScript.  I resolved it by using import like this:
import flowbitePlugin from 'flowbite/plugin';

...

  plugins: [
    flowbitePlugin, // require Flowbite's plugin for Tailwind CSS
  ],

Although the provided code resolved the issue, it still did not include the charts plugin.

@samuelna You need to add the following to your tailwind.config.ts:
flowbiteConfig: { charts: true, datatables: true },

at the same level as plugins.


[Accessibility] Add fieldset and legend to payment step

Describe the bug
When reviewing our checkout for WCAG 2.1 - 1.3.1 Info and Relationships (A), I found the payment step not to have any <fieldset> or <legend> tags. These elements allows users to understand the relationship of the controls and interact with the form more quickly and effectively.
To Reproduce
Steps to reproduce the behavior:

Go to payment step
View payment step HTML
See no fieldset or legend

Expected behavior
We need to add <fieldset> with direct descendant of <legend> to the payment step. These elements work together to tell screen readers that a group of form fields relate to each other, and to provide a label for the group.
Code example

Payment

  <fieldset>
    <legend>Payment type</legend>

      <input id="pay-cc" name="payment-type" type="radio" value="cc">
      Credit Card

      <input id="pay-pp" name="payment-type" type="radio" value="pp">
      PayPal

  </fieldset>
  <fieldset>
    <legend>Card details</legend>

      <input id="name-cc" name="payment-type" type="text" value="name">
      Name on card

  </fieldset>

Screenshots

Desktop (please complete the following information):

OS: Mac OS Monterey
Browser Safari 15

Additional context
Further reading on why this is important. https://accessibility.blog.gov.uk/2016/07/22/using-the-fieldset-and-legend-elements/

Hi @gazjoy - thanks for this observation.
As mentioned previously we will wait for the findings of our a11y assessment before implementing such structural changes

Our a11y assessment did flag that fieldsets and legends were missing from our markup, but not in relation to the payment method list.
It did however flag that they were needed elsewhere - and so we added them as part of this PR (#2083)


Snapshot contract between the config builder and the runtime.

Add new configuration data to the snapshot. Ephemeral.go builds the snapshot. Snapshot is used by the runtime dispatch table.
Following this PR, @mandarjog will work on consuming this snapshot during request path and I will work on building this snapshot as we load the config.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
34aa5001d8b2c109c1d75b8a9a37ebb59041256c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8c4ec76e89337fb3ce8f01f52ca4345cd9b8e10f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8c4ec76e89337fb3ce8f01f52ca4345cd9b8e10f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

unrelated pilot e2e failure.


Add Screen Orientation API to docs/extend.md

Already implemented in Chrome 38+.

Hey there. Thanks for reporting this. We appreciate it :) I'm going to close this as this project is deprecated.


PVP & MAC OS Sonoma [BUG]

Is this a bug in companion itself or a module?

[X] I believe this to be a bug in companion

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I recently upgraded to MAC Studio which unfortunately came with Sonoma. I have attempted to use stream deck through companion and it does not work. I have added the instance of PVP using IP, Port and Token and the connection seem to be connected fine. However, each time a trigger a button nothing happens.
Steps To Reproduce
No response
Expected Behavior
Button should trigger action
Environment (please complete the following information)
- OS:Sonoma
- Browser:Chrome - Version 120.0.6099.129
- Companion Version:3.1.2 (3.1.2+6243-stable-05c37a10)

Additional context
No response

@Julusian Is this not a bug?

We have the same exact issue. Since companion v3.0 pvp stopped responding which is very unfortanate.

I have the same bug. I would love to fix this issue so I can continue to use this amazing software!

Has anyone come up with a fix for this yet? I feel somewhat crippled without companion for PVP.

We had to disable HTTPS, now it works flawlessly.

Thank you!
That appears to work. A bit of delay but better than before.


Issue 551: Added support for collections.abc.Callable in function_wrapper.py

This failure is caused by a different issue. Will try to fix it tomorrow.