MPI example failing with a segmentation fault

I'm building the MPI example for compute capability 6.1, on Devuan GNU/Linux Chimaera (basically Debian Bullseye without systemd). When I run the program with 2 GTX 1050 Ti Boost GPUs cards, I get:
$ mpirun -np 2 jacobi
Single GPU jacobi relaxation: 1000 iterations on 16384 x 16384 mesh with norm check every 1 iterations
    0, 31.999022
  100, 0.897983
  200, 0.535684
  300, 0.395651
  400, 0.319039
  500, 0.269961
  600, 0.235509
  700, 0.209829
  800, 0.189854
  900, 0.173818
[bakunin:09699] Read -1, expected 65536, errno = 14
[bakunin:09700] Read -1, expected 65536, errno = 14
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun noticed that process rank 1 with PID 0 on node bakunin exited on signal 11 (Segmentation fault).
--------------------------------------------------------------------------

Can you provide some more details about your system? What MPI are you using? How is that configured?

@jirikraus : Certainly.
Kernel: 5.10.0-9-amd64 x86_64 bits:
Desktop: Cinnamon 4.8.6
Distro: Devuan GNU/Linux 4 (chimaera)
Mobo: ASUSTeK model: Z170 PRO GAMING
CPU: Quad Core Intel Core i5-7600K [MCP] speed: 1042 MHz min/max: 800/4200 MHz
Graphics:  Device-1: Intel HD Graphics 630 driver: i915 v: kernel
Device-2: NVIDIA GP107 [GeForce GTX 1050 Ti] driver: nvidia v: 470.57.02
Device-3: NVIDIA GP107 [GeForce GTX 1050 Ti] driver: nvidia v: 470.57.02
Display: x11 server: X.Org 1.20.11 driver: loaded: modesetting,nvidia unloaded: fbdev,nouveau,vesa
Library versions:

OpenMPI 4.1.0-10 (detected by CMake as MPI 3.1) - have not configured it manually, it's Debian's default.
NCCL 2.11.4 - built it from sources.

-- The CUDA compiler identification is NVIDIA 11.4.48
-- The CXX compiler identification is GNU 10.2.1
-- Found CUDAToolkit: /usr/local/cuda/include (found version "11.4.48")
-- Looking for C++ include pthread.h - found
-- Autodetected CUDA architecture(s):  6.1 6.1
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found MPI_CXX: /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi_cxx.so (found version "3.1")
-- Found MPI: TRUE (found version "3.1")
-- Found NCCL: /opt/nccl/lib/libnccl.so (found version "2.11.4")

Thanks

OpenMPI 4.1.0-10 (detected by CMake as MPI 3.1) - have not configured it manually, it's Debian's default.

This is likely the cause. I think the debian package is not CUDA-aware. The MPI variants of the code requires a CUDA-aware MPI. You can find information on how to build a CUDA-aware OpenMPI here: https://www.open-mpi.org/faq/?category=buildcuda
Closing this as not a bug.

@jirikraus : Well, perhaps you could do one of the following:

Check the "CUDA-awareness" of the MPI library, at run-time?
Check the "CUDA-awareness" of the MPI library in the Makefile?
Expand on what it means for MPI to be "CUDA-aware", in the README?

@jirikraus : Well, perhaps you could do one of the following:

Check the "CUDA-awareness" of the MPI library, at run-time?
Check the "CUDA-awareness" of the MPI library in the Makefile?
Expand on what it means for MPI to be "CUDA-aware", in the README?

Thanks for the suggestion. I just pushed an update adding a compile and runtime check: 1aed265c11a094b6001e75416b1da061daac623c . What do you think?

Haven't tested this, but it looks about right. A compile-time check is even better than a runtime check.


add scp option

We should add eden eve scp in addition to the eden eve ssh. We often need to pull files from the host; this makes it much easier.

But it needs to install scp inside EVE.

It can add it if needed. But you're right, let's add it to pillar. It's useful.

I don't think it should be in pillar by default -- arguably it can be added to sshd container but that would require a roundtrip with linuxkit maintainers.

I will make that happen. Let's leave this open until then.

This is being fixed via https://github.com/lf-edge/eve/pull/1546
Once that is in, we can close this.

Actually I don't think it'll be fixed -- but that's a separate conversation ;-)


Fix make manifests

Description
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

What this PR seems to be missing is the results of running make gen-files and committing the results.

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

Removing "merge-when-ready" label due to new commits

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.


DOR Garbage Collection

Feature description
Over time, DORs may collect a lot of data objects. Some of which may be no longer needed. There needs to be a mechanism to perform 'garbage collection'. Also, see #159 for more details on prior discussion.
Pitch
TBD
Suggestions (if any)
TBD

Obsolete.


GH3711: Fix SemanticVersion missing operators & comparer

Adds SemanticVersion equals operator
Adds SemanticVersion not equals operator
Fixes PreRelease sorted as newer than non PreRelease
Adds SemanticVersion tests
Fixes #3711

@devlead your changes have been merged, thanks for your contribution 👍


passphrase save password

it would be great if it was possible to store the passphrase for keys.

hundred times not seen and found now... Sorry. can be closed.


 I'm using java 17 and the latest release of recaf, and when I try to open the jar it just opens a cmd window with no main manifest attribute, in recaf-2.21.9.jar
What am I doing wrong?

Use the jar with the dependencies bundled.
https://www.coley.software/Recaf-documentation/setup-get.html

ok, I'll try that. I don't really know what I'm doing at all haha

it says javafx could not be found, even though I'm using a version of java above 11

Your JDK installation may be misconfigured, check your environment variables.

not sure what I did but it works now. Thanks!


Resource Monitor CREDIT_QUOTA type

I saw issue https://github.com/chanzuckerberg/terraform-provider-snowflake/issues/109 about converting the credit quota from an int to a float in resource monitors but when I try and create a  monitor I'm getting a data type error.
Error: error creating resource monitor EXAMPLE_MONITOR: 001008 (22023): SQL compilation error:
invalid value [5.00] for parameter 'CREDIT_QUOTA'

Using the generated SQL but using 5 instead of 5.00 creates the object successfully.

Can confirm this is still an issue. Currently you are unable to create a resource monitor with credit quota other than 0 with all other values resulting in the above error. #111 seems suspect as the cause of this issue.

We have run into this as well.

We are also running into this.
If I'm understanding the original issue #109 correctly, even though this parameter is an int, it is returned from Snowflake as a float?  Seems likely that the fix for both issues would be to use an int for the parameter, but to accept a float from the UI?

For anyone looking for a workaround to this problem in the mean time you can use a snowsql run via Terraform to update the credit quota after provisioning the resource monitor. Examples below.
locals {
  resource_monitor_name = "FOO_RESOURCE_MONITOR"
  credit_quote          = 100
  warehouse_name        = "FOO_WAREHOUSE"
}

resource "snowflake_resource_monitor" "resource_monitors" {
  lifecycle {
    ignore_changes = [
      # Ignore changes to credit quota as they are modified via a manual sql file
      credit_quota
    ]
  }

  name         = local.resource_monitor_name
  credit_quota = 0
}

resource "null_resource" "resource_monitor_credit_quotas" {
  depends_on = [snowflake_resource_monitor.resource_monitors]

  # Run the script every time apply is run
  triggers = {
    run_always = "${timestamp()}"
  }

  provisioner "local-exec" {
    command = "/usr/local/bin/snowsql -o variable_substitution=true  -f ${path.module}/update-quotas.sql --variable resource_monitor=${snowflake_resource_monitor.resource_monitors.name} --variable credit_quota=${local.credit_quote}"
  }
}

resource "snowflake_warehouse" "warehouses" {
  name             = local.warehouse_name
  resource_monitor = snowflake_resource_monitor.resource_monitors.name
}

And the update-quotas.sql looking something like.
ALTER RESOURCE MONITOR &resource_monitor SET CREDIT_QUOTA=&credit_quota;


Add CUDA extension

You forgot a compat specification for PackageExtensionCompat.

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

The error occurring in the Invalidations is due to a known bug in Pkg, which will be fixed from Julia 1.9.4 onwards:
https://github.com/JuliaLang/Pkg.jl/pull/3591


Publish configPy v0.1 to PyPi

[x] Publish Current Code changes with support for json and ndjson and Test scripts to Test-PyPi
[ ] Test Published Test-PyPi Package locally
[ ] Publish tested Code to PyPi.

Tested Test-PyPi v0.0.12 Locally

Test Successful - Ready to Publish v0.1 to PyPi

Published configParsePy v0.1 to PyPi
https://pypi.org/project/configParsePy/


Only cache results of successful gene result queries

Queries for all gene results are cached in the API. However, there is no check that the query succeeds. Thus, an initial failed query is never retried.
https://github.com/macarthur-lab/gnomadjs/blob/ace01be1cf034f202a23b6133d1a0a203ff14794/projects/exome-results-browsers/src/server/schema/geneResult.js#L66-L91

Exome results browsers moved to a different repository.


Use musl to build the Crystal binaries

Musl is a lightweigh,  statically-linked, C99-compatible libc implementation. It's easy to install on Linux systems (in most repositories) and is easy to use instead of glibc (replace calls to gcc with musl-gcc). Using this to build the binaries would mean that they are not dependent on a particular version of the glibc shared object librar.  An issue related to this was recently posted on the mailing list.

Does it work with clang too?

Alpine Linux is based on musl libc and it does provide a package for it: http://pkgs.alpinelinux.org/package/main/x86_64/llvm
I'm configuring a container with alpine to try it out.

Using the pre-built Crystal 0.7.1 I get some missing symbols:
alpine:~/crystal-0.7.1-1# ldd embedded/bin/crystal
        /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        libpthread.so.0 => /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        librt.so.1 => /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        libdl.so.2 => /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        libm.so.6 => /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x7f54ffd13000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x7f54ffb01000)
        libc.so.6 => /lib64/ld-linux-x86-64.so.2 (0x7f5500006000)
        ld-linux-x86-64.so.2 => /lib/ld-linux-x86-64.so.2 (0x7f54ff875000)
Error relocating embedded/bin/crystal: swapcontext: symbol not found
Error relocating embedded/bin/crystal: makecontext: symbol not found
Error relocating embedded/bin/crystal: mallinfo: symbol not found
Error relocating embedded/bin/crystal: getcontext: symbol not found
Error relocating embedded/bin/crystal: __register_atfork: symbol not found
Error relocating embedded/bin/crystal: __pthread_register_cancel: symbol not found
Error relocating embedded/bin/crystal: sysctl: symbol not found
Error relocating embedded/bin/crystal: __pthread_unregister_cancel: symbol not found
Error relocating embedded/bin/crystal: errno: symbol not found
Error relocating embedded/bin/crystal: __libc_stack_end: symbol not found

Maybe I'm just missing some packages (very likely).

I know that you can use musl with Clang, but you have to manually pass the arguments to not use glibc.
Besides, I'm suggesting that this be used for the prebuilt binaries.

I almost got Crystal to compile itself against musl libc (using a statically built crystal binary on alpine linux), and I'm down to a single missing symbol when linking: errno, which is defined differently.
int *__errno_location(void);
#define errno (*__errno_location());

I'm not sure how to translate this.

fun errno_location = __errno_location() : LibC::IntT*, no?

Yes. Replacing calls to LibC.errno for LibC.errno_location().value (I tried to add some ifdef musl but I still got some undefined references to errno), fixing some missing dependencies, and I got version of Crystal built against musl libc!
alpine:~/crystal# ldd crystal
        /lib/ld-musl-x86_64.so.1 (0x7fae5bb0c000)
        libz.so.1 => /lib/libz.so.1 (0x7fae5a10c000)
        libffi.so.6 => /usr/lib/libffi.so.6 (0x7fae59f07000)
        libedit.so.0 => /usr/lib/libedit.so.0 (0x7fae59cdb000)
        libncurses.so.5 => /usr/lib/libncurses.so.5 (0x7fae59a97000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x7fae597a4000)
        libevent-2.0.so.5 => /usr/lib/libevent-2.0.so.5 (0x7fae59565000)
        libpcl.so.1 => /usr/local/lib/libpcl.so.1 (0x7fae59361000)
        libpcre.so.1 => /usr/lib/libpcre.so.1 (0x7fae59108000)
        libgc.so.1 => /usr/lib/libgc.so.1 (0x7fae58ead000)
        libunwind.so.8 => /usr/local/lib/libunwind.so.8 (0x7fae58c93000)
        libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x7fae58a81000)
        libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7fae5bb0c000)

The problem now, is a segfault with gc when I try to compile something with it:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff68ffdac in GC_find_limit_with_bound () from /usr/lib/libgc.so.1
(gdb) bt
#0  0x00007ffff68ffdac in GC_find_limit_with_bound () from /usr/lib/libgc.so.1
#1  0x00007ffff68ffe30 in GC_init_linux_data_start () from /usr/lib/libgc.so.1
#2  0x00007ffff68fefa7 in GC_init () from /usr/lib/libgc.so.1
#3  0x0000555555641610 in *GC::init:Void ()
#4  0x000055555562fd25 in main ()

@ysbaddaden , did you managed to make it work ?

No, it sadly reaches further than I'm capable.
I guess we should compare the generated LLVM bytecodes to understand if the error comes from the generated crystal code, or maybe this has something to do with the way GC is initialized (it's patched for musl libc).
I also tried against Alpine 3.2 which is in beta and ships LLVM 3.6. I should retry with the stable Alpine 3.1 and LLVM 3.5.

I'm using statically linked crystal against glibc - the resulting (stripped, not recommended as you lose exception backtraces) binary is 21MB. The benefit of musl is questionable, as largest chunk of the static blo is llvm, ncurses and other dependencies, removing glibc/pthread and other gnu runtime will shed off 3-5MB at most.

I didn't experiment against musl-libc to distribute a smaller binary, but to be able to use crystal on musl based systems like Alpine; ie. make it more portable, without having to build a static binary on a glibc system and eventually have to use the glibc when I could use musl instead.

@ysbaddaden: Fair point about Alpine. One could speculate it's related to https://github.com/ivmai/bdwgc/blob/master/dyn_load.c#L55 - a general boehmgc issue with bgc and musl (dyn_load.c is awfuly platform specific regarding dlopen wrappers, and musl is not exactly svr4-compliant in this regard).
If that turns out to be true, either you can recompile libgc with dlopen disabled, or use TinyGC which does not implement it at all (it's just simple allocator wrappers) and is generally simpler to troubleshoot on new platform.

Wow, thanks a lot for detailing how to conduct further research!

So, for this issue in itself - statically linking with glibc will suffice? Considering the other statics included.
I like the idea of totally static, dependency free binaries - downloading and trying a neat language should just work, be effort free and a nice first impression ;-)

The issue will be closed when we can use a musl built crystal to compile apps.
Statically linking against glibc and other dependencies was already operational. Building against musl using this static build is also possible, with a small change around errno, but compiling with this compiler generates segfaulting binaries, which I didn't investigate, yet.

Ah, of course, I got the issue wrong. I got a Nim app running with musl - made it insanely small, so it's cool if it works for possible future embedded device hacking, whatnot :-)


Support for unit ids

First of all thank you for sharing this crate with us!
I guess this is a feature request but it may just be a documentation issue.
I need to setup a modbus TCP communication relying on unit identifiers (I think it is also referred to as slave id). I think this is not supported by this crate but could you please confirm it ?
If the feature is actually missing, is there any plan to implement it ?

As proposed here this can be implemented by introducing a device_id: u8 for both TCP and RTU transports. What do you think?

Correct, the unit identifier is currently hard-coded for TCP.

Another variant of sending messages to selected slave devices (address range: 1-247) is sending broadcast messages to all connected devices by using the address 0.

We also need to consider the use case of using one of the reserved addresses 248-255, e.g. for devices with a fixed broadcasting address 253.

Heavy work in progress: https://github.com/uklotzde/tokio-modbus/tree/devices
With tcp::connect_device() you will be able to connect to a specific device aka unit instead of using a direct connection (default : device/unit_id = 0xFF) to the coupler. It will also be possible to switch dynamically between devices at runtime for both RTU and TCP connections, see the rtu-client.rs example.
@flosse I'm still not sure about the API. Let's talk tomorrow.

Thank you for the work you put in this new version!
I may have missed something but I think sync::Context should implement SlaveContext as well


Godot does not save style settings when displaying property names.

Tested versions
v3.6.beta4.official [93ac21cf8]
System information
w10 64
Issue description
Godot does not save style settings when displaying property names.
Steps to reproduce
I select "Raw" style
Close the project
Open it again
Properties are not displayed in "Raw" style

Minimal reproduction project (MRP)
...

Ok it can be closed.
It seems that this is a "quick" option, the option that sets the naming style is found in the editor properties options.


Add support to HttpFileService for serving pre-compressed files.

@trustin PTAL

Current coverage is 65.48% (diff: 86.20%)

Merging #236 into master will increase coverage by 0.11%

@@             master       #236   diff @@
==========================================
  Files           286        286
  Lines         11020      11057    +37
  Methods           0          0
  Messages          0          0
  Branches       1610       1620    +10
==========================================
+ Hits           7204       7241    +37
+ Misses         3044       3043     -1
- Partials        772        773     +1

Powered by Codecov. Last update 17e1a14...54ce050


Add multi-tenancy

Access to Logsearch should be restricted to the Users of a CF cluster, and those users Orgs/Spaces/Roles and permissions.
Specifically, when accessing the Logsearch UI (Kibana) or API; a user should be bounced to the CF clusters UAA server to obtain an OAuth2 token.  All queries to Logsearch should have an automatic filter attached to them that only returns data for those apps that the user has access to view its logs.  Ie, all logs for apps which the users has permissions to use the cf logs cli command against should be returned.

This feature is being added by #24


Export the docker object

...to allow usage of imageRootDir and createEmptyImage
We'll need this for resin-io/resin-supervisor#204

It seems to be like the better option could be to use require('docker-delta/docker-toolbelt'), that way you could set up the docker connection with whatever options you want

Hadn't thought of that :/
So it would be require('docker-delta/lib/docker-toolbelt')
Nice one.
Closing this.

@Page- @pcarranzav I'm a bit concerned using docker-toolbelt like this. It is not part of the public API of this module and it can change internally without warning and without the appropriate version bump

@petrosagg should we then split this functionality to a separate module? what should we call it? (docker-toolbelt sounds too generic)

Yes I'm all for splitting. docker-toolbelt sounds fine to me tbh, that's why I named it that way :P

Okay then, I'll move it to resin-io-modules


Changing UI of Upload Form

I would like to work on inproving the UI of uploading a new user experience.Could you please assign the issue to me?

@avinashkranjan Can i work on this ?

I think this is issue is already being tracked with #50. Anyway I'd like to work on this as a part of our new UI design...

I have already created the PR and got it approved . Do check it out @avinashkranjan .
THANKS for the great opportunity and learning experience!


README

README
User Story
AS AN employee with access to sensitive data
I WANT to randomly generate a password that meets certain criteria
SO THAT I can create a strong password that provides greater security
Acceptance Criteria
GIVEN I view the repository
WHEN I view the README file
THEN I am presented with a quality README file with description, screenshot, and link to deployed application

Feature/readme


sycri fails to start

What are the steps to reproduce this issue?

followed build commands for singularity, singularity-cri software, typed in 'sycri' and the system failed

What happens?
sycri fails: runtime.go:131 could not initialize network manager: could not get networks: no net configurations found in /etc/cni/net.d
main.go:198 singularity cri server started on /var/run/singularity.sock
main.go:125 could not start singularity device plugin: could not create singularity device plugin: could not get build config: could not run buildcfg command: exit status 1
main.go:201 singularity cri service exiting...
What were you expecting to happen?
sycri to start
Any logs, error output, comments, etc?
see above
Environment?
centos 7.5.1804 (core)
go version
go1.12.6 linux/amx64
go-env
GOARCH="amd64"
GOCACHE="/root/.cache/go-build"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOPATH="/usr/local/go:/root/go"
GOROOT="/root/go"
GOTOOLDIR="/root/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GXX="g++"
CGO_ENABLED="1"
GOMOD="/root/singularity-cri/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build -gno-record-gcc-switches"
Singularity-CRI version: from git master
Singularity version: 3.0.2-1
Kubernetes version: not installed on slurm login system
crictl version: 2.12.0

The issue seems to be a missing /etc/cni/net.d - any suggestions on how to create/configure one of those?

Hello @ct-clmsn,
Here are several issues you'll have to address.
First, you'll need to update Singularity version to be at least 3.1. However, many fixes have been applied, so I suggest to use the latest version which is v3.3.0-rc.1.
Secondly you need to configure CNI. When you install sycri, configuration is placed into /usr/local/etc/sycri/sycri.yaml. You can either configure CNI paths there or place plugins and configlists in default locations.
That is how your config may look if  you choose first approach:
# unix socket to serve CRI requests on, required
# default: /var/run/singularity.sock
listenSocket: /var/run/singularity.sock

# directory to store all pulled images in, required
# default: /var/lib/singularity
storageDir: /var/lib/singularity

# address to serve streaming requests on (exec, attach, portforward), optional
# default: <IP_ADDRESS>:12345
streamingURL:

# directory to look for CNI plugin binaries, optional
# default: /opt/cni/bin
cniBinDir: /usr/local/libexec/singularity/cni

# directory to look for CNI network configuration files, optional
# default: /etc/cni/net.d
cniConfDir: /usr/local/etc/singularity/network

# directory to store currently running pods and containers, required
# default: /var/run/singularity
baseRunDir: /var/run/singularity

# directory where all container logs and configs will be stored upon removal
# default:
trashDir:

# whether CRI need to log all requests and responses
# default: false
debug:

@sashayakovtseva should this be done prior to installing kubernetes or does the order not matter?

@ct-clmsn Installation order does not really mater, but start order is. So you want to start sycri prior to kubelet.
If you already have things running and want to update, do the following:

update config
stop kubelet
stop sycri
restart sycri
restart kubelet

@sashayakovtseva will sycri be added into systemctl?

Not automatically, you will need to set it up as well. Details can be found
here:
https://sylabs.io/guides/cri/1.0/user-guide/installation.html#create-singularity-cri-service
ср, 19 июня 2019 г. в 19:44, ct-clmsn<EMAIL_ADDRESS>
@sashayakovtseva https://github.com/sashayakovtseva will sycri be added
into systemctl?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sylabs/singularity-cri/issues/296?email_source=notifications&email_token=AE7VH4TBMTRBOVSUKONJTQDP3JO6TA5CNFSM4HZAVWG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCO37Q#issuecomment-503639550,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE7VH4X356LYW45WEUWIKRTP3JO6TANCNFSM4HZAVWGQ
.

--
Sasha Yakovtseva
Software Engineer, Sylabs, Inc.
www.sylabs.io

@sashayakovtseva thank you! everything is working now on this end!


Feature/tail #416

Closes #416

[x] Running yarn lint does not trigger any linter errors
[x] The test of the method you have fixed is passing
[x] You have written a new skeleton method for someone else to work on!
[x] You have written tests to accompany your skeleton method

Bingo! Great Work! Thanks for the contribution. Could you do us a favor and create an issue for your new method. Happy Hacktobering!


Setup dockerfile for node v10.1 using alpine:3.7

Ran the build on both the dockerfile and dockerfile-tests and everything worked okay.

The test needs to be ran again after this pull request is merged.

Just waiting on one final review from @salsa2k before merging.


code cleanup - remove legacy functions

remove functions which are not used by any current cli.py functionality

I think this is done so closing.


Removed extra semicolon at the end of a function

There is an extra semicolon at the end of L1925, and we met this bug when developing WebNN in chromium: CL 5378104.
The error logs are as following:
CXX obj/components/ml/webnn/webnn/graph_validation_utils.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /c ../../components/ml/webnn/graph_val...(too long)
In file included from ../../components/ml/webnn/graph_validation_utils.cc:20:
../..\third_party/fp16/src/third-party/half.hpp(1925,69): error: extra ';' after member function definition [-Werror,-Wextra-semi]
 1925 |                         static half cast(U arg) { return cast_impl(arg, is_float<U>()); };
      |                                                                                ^
1 error generated.
Note: including file: ../..\components/ml/webnn/graph_validation_utils.h

This PR removed the extra semicolon and please take a look, thanks! @Maratyszcza<EMAIL_ADDRESS>

Thanks @miaobin.


ARTEMIS-4785 ARTEMIS-4702 Add profile and log4j2 files for non-run CLI commands

The run command uses the artemis.profile and log4j2.properties files while all other CLI commands use the artemis-utility.profile and log4j2-default.properties files.

Looks good overall, but I did spot an issue with handling of the data dir during upgrade. I've worked up a fix but still need to look into some testing changes, as I think the Upgrade tests should have some additional checks for the new additions, and in particular definitely need updated to ensure they cover the problematic path I found/fixed which they dont yet.
Will convert to draft for now.

I added https://github.com/apache/activemq-artemis/pull/5136/commits/68be64fdb8b56f92378c86ce17d380082a6c6882 with additional tests to cover the issue I noticed, and a fix, such that upgrades that didnt have a utility profile previously, will create it referencing the data dir from the existing main profile rather than the default which might be different.
I'll now squash and rebase all the changes

Now rebased to current main

@gemmellr good catch! Thanks for fixing the bug of the data dir.


API swallows exception when initializing Bluetooth Adapter.

there is no reason failing to initialize the Bluetooth adapter should swallow the exception.
protected override void InitializeNative()
{
	try
	{
		btAdapter = BluetoothAdapter.GetDefaultAsync().AsTask().Result;
		radio = btAdapter.GetRadioAsync().AsTask().Result;
		radio.StateChanged += Radio_StateChanged;
		isInitialized = true;
	}
	catch (Exception ex)
	{
		Trace.Message("InitializeNative exception:{0}", ex.Message);
	}
}

Then the API goes on to crash when trying to use the adapter.
public override bool SupportsExtendedAdvertising()
{
	return _bluetoothAdapter.IsExtendedAdvertisingSupported;
}

Steps to reproduce

One way to reproduce is to uninstall or remove the bluetooth drivers on windows... In my case apparently the subsystem on windows just crashed and disabled the radio

Expected behavior
The exception is thrown
Actual behavior
The exception is swallowed
Crashlog

Configuration
Version of the Plugin: e.g. 3.1.0
Platform: e.g. Windows 10.19041
Lenovo carbon 6 or something

Hi @axa88,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.


Self Tests Fail (L2/L3) When Using IBM Compilers

The self and link tests fail when using the IBM build tools but work fine on the same system with gcc 5.4.0. I have not tried with MASS or without OpenMP;  nor have I compared the assembly produced by the different compilers yet. I have tried everything from O0 to O5 with and without the strict flag and the results are the same.
I have included a file with the test output below and will update the issue when I know more.
System Details:

RHEL 7 Little Endian
IBM Power8 (8335-GTA) (dual socket 8PE/8thread per socket)
xlc-14..1(beta 6)/xlf-16.1(beta 6)

Make/Compilation:
VERBOSE=1 USE_OPENMP=1 TARGET=POWER8 make tests
xlc -Ofast -q64 -qstrict -qarch=pwr8 -qtune=pwr8 -qalign=linuxppc -DUSE_OPENMP -qsmp=omp
xlf90_r -q64 -qpic=large -O2 -q64 -qstrict -qfixed -qarch=pwr8 -qtune=pwr8 -qalign=bindc=linuxppc -DUSE_OPENMP -qsmp=omp
I have also tried including -L${XLF_ROOT}/lib -L${XLC_ROOT}/lib -lxlf90_r -lxlopt -lxlsmp -lxl -lxlfmath
build-tests.txt

Can you test with 0.2.20 or current "develop" snapshot rather than 0.2.19 ? There have been several fixes for unwanted side effects of Power8 assembly routines recently. (If RHEL on Power8 uses something other than glibc please use "develop", otherwise 0.2.20 and develop are practically identical)

Working from the develop branch:
xlc -c -Ofast -q64 -qstrict -qarch=pwr8 -qtune=pwr8 -qalign=linuxppc -DUSE_OPENMP -qsmp=omp -DMAX_STACK_ALLOC=2048 -DF_INTERFACE_IBM -qpic=large -DSMP_SERVER -DUSE_OPENMP -DNO_WARMUP -DMAX_CPU_NUMBER=128 -DASMNAME=dtrmm_oltucopy -DASMFNAME=dtrmm_oltucopy -DNAME=dtrmm_oltucopy -DCNAME=dtrmm_oltucopy -DCHAR_NAME=\"dtrmm_oltucopy\" -DCHAR_CNAME=\"dtrmm_oltucopy\" -DNO_AFFINITY -I.. -DDOUBLE  -UCOMPLEX  -DDOUBLE -UCOMPLEX -DOUTER -DLOWER -DUNIT generic/trmm_ltcopy_4.c -o dtrmm_oltucopy.o
In file included from ../kernel/power/sdot.c:39:
../kernel/power/sdot_microk_power8.c:169:8: error: unknown register name 'vs32' in asm
       "vs32","vs33","vs34","vs35","vs36","vs37","vs38","vs39",
       ^
1 error generated.
Error while processing ../kernel/power/sdot.c.
make[1]: *** [sdot_k.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from ../kernel/power/scopy.c:39:
../kernel/power/scopy_microk_power8.c:110:8: error: unknown register name 'vs40' in asm
       "vs40","vs41","vs42","vs43","vs44","vs45","vs46","vs47"

It keeps going like that for some time.

That's bad, these vs registers were added to the assembly clobber lists as part of the fix. This now looks like the clang compiler problem #1120 so could be the file uses some gnu assembler idiom for register naming.

Things I found on the 'net suggest compiler options like -qaltivec or -maltivec might be needed for xlc to enable compiler support for vector data types and instructions. No idea if that is true...

It looks like a problem with the clobber list. I had a similar issue before where the list was self-referencing (e.g. %0, %1) and xlc produced warnings about register names. I did try adding -qasm=gcc to the compile flags with no success.
I'll try -qaltivec this afternoon but when i tried adding it on Friday, it gave me a lot more errors.

I haven't used xlc since the days of the RS6000 so I cannot really help. All I managed to find was this discussion https://redmine.gromacs.org/issues/2102 which has a link to the manual of a somewhat older xlc version. (Perhaps knowing what the other errors were would help others to identify the problem)

If it builds with gcc (Like found at fedora epel) you can call functions from xlc? ASM is extension to C standards and in absence of documentation impossible to guess what goes wrong.

Yup. I can build it with gcc, including MASS, with no problem. However, I would like to be able to use IBM's toolchain, so I'll keep working on this and report back when I have an update.

Please run 'make clean' before new build and record output with 'script'
Fo not run 'make tests' before 'make' completes (ideally plain 'make' runs tests already and you can not mix up build options...)
when i last ran xlc on pSeries it overhauled assemblies at high optimisation levels. Try like '-O1' for starters.

Also add MAKE_NB_JOBS=1 (very slow 1-cpu build) to sync commands with error outputs.
curent output shows _trmm compilation command next to _dot assembly error....

I've attached the output that you requested.
power8_build.txt

So still no luck finding an xlc option that makes it accept vsx in clobber lists ?

maybe -qvsx iff it exists?

@martin-frbg I have a feeling that it has to do with using altivec, which I'm unable to do. When qaltivec is used, the build fails with:
/home/projects/pwr8-rhel73-lsf/ibm/xl/xlC/14.1.0/include/stddef.h: Assembler messages:
/home/projects/pwr8-rhel73-lsf/ibm/xl/xlC/14.1.0/include/stddef.h:34: Error: unrecognized opcode: `typedef'

I think that this is a problem with xlc recognizing the vector type but haven't had time to test that hypothesis.
In addition, due to gfortran mangling, I've been unable to link against objects compiled with the gnu toolchain. I was able to build the OpenBLAS libraries today using the fno-underscoring flag with gfortran. Unfortunately, each build takes 4-6 days with xlc/xlf, so it takes a while to test even with multiple builds running in parallel.

Reduce optimisation level?

I struggle to understand why -qaltivec would make the assembler try to process the C headers, apparently taking "typedef" for an instruction mnemonic.
Perhaps it would help to know the complete set of "make" options you are using. (Did the assembler name slip into the CC environment variable ? And why would it take an 822LC a week to build a relatively small library ??)

I asked to build on one cpu (normally hours on haswell pc)

Oh, no, I can compile the OpenBLAS libraries in a couple of minutes. The other comments were a separate issue and I've removed them to avoid confusion.

Look around qaltivec in xlc manuals
should be something to unlock more registers....

Which file is it that triggers the assembler error ? From a bit of googling this sort of thing can apparently happen when the relevant #include <stddef.h> is not guarded by #ifndef ASSEMBLER. (Note it could be that stddef.h is itself included by some other header, not sure if xlc would show this like gcc does)

@martin-frbg It looks like the problem is with amax.S, which includes common.h, which includes cblas.h, which includes stddef.h. I did add guards around the include in cblas.h, but that did not correct the error.
xlc -c -Ofast -q64 -qstrict -qarch=pwr8 -qtune=pwr8:st -qalign=linuxppc -qaltivec  -DMAX_STACK_ALLOC=2048 -DF_INTERFACE_IBM -qsmp=omp -qpic=large -DSMP_SERVER -DUSE_OPENMP -DNO_WARMUP -DMAX_CPU_NUMBER=160 -DASMNAME=samax_k -DASMFNAME=samax_k -DNAME=samax_k -DCNAME=samax_k -DCHAR_NAME=\"samax_k\" -DCHAR_CNAME=\"samax_k\" -DNO_AFFINITY -I.. -UDOUBLE  -UCOMPLEX -UCOMPLEX -UDOUBLE  -DUSE_ABS -UUSE_MIN ../kernel/power/amax.S -o samax_k.o

Not sure what the guard needs to look like exactly, perhaps the xlc assembler defines ASSEMBLER with double underscores or something like that (if it defines anything at all)

Which version are you building that leads to this error- I see isuruf fixed a few unguarded typedefs in the common.h file itself just 17 days ago.

I'm on develop:https://github.com/xianyi/OpenBLAS/commit/a8a342ccc49bb6e6824c60905ca015d2dd35cb0d

I did pull out the sdot_kernel_16 function and attempted to compile it with: xlc -qarch=pwr8 -qtune=pwr8 -qaltivec and it still won't recognize the registers.
error: unknown register name 'vs32' in asm
       "vs32","vs33","vs34","vs35","vs36","vs37","vs38","vs39",

Small reality check:
Has the problem ever occurred with any non-beta compiler?
Are you sure as is from XLC and not from /usr/bin ?

Can you try adding "-qhot" to your compiler options please ? (As that is supposed to enable "high order transformations" implying auto-vectorization of loops, it would seem to require the toolchain to understand vsx registers. -qaltivec may only be useful to unlock access to C extensions for vector math. At least provided what I read on the Interwebs is true...)

@hughes-c I have confirmed the problems with the "community edition" xlc 13.1.5 , but please see #1078 for the ensuing communication with IBM's David Edelsohn. (In short, the "vs32" naming issue could be worked around but is not the only problem - if anything these issues should be reported as xlc bugs)


Update Design of User Testimonials on Homepage

Objectives/Description:
Enhance the design and content structure of the existing user testimonials on the homepage. The goal is to make testimonials more informative by adding reviewer names and ratings, addressing the professor's request for improved validity.
Designing Tasks:

Testimonial Content Restructuring:
Update the content structure of each testimonial to include additional information such as reviewer names and ratings.
Ensure the restructuring enhances the clarity and authenticity of each testimonial.
Visual Design Improvements:
Enhance the visual design of the testimonials to accommodate the new content.
Consider typography, layout, and styling adjustments for an improved overall appearance.

Acceptance Criteria:
Testimonials on the homepage should include reviewer names and ratings.
The content restructuring should contribute to the clarity and validity of each testimonial.
Visual design changes should align with the overall theme of the website.
Additional Information:
Existing testimonials are located in the designated section on the homepage.
Ratings can be displayed using a numerical or graphical representation, as per the design guidelines.
Notes:
Test the updated testimonials on different devices to ensure a consistent and appealing presentation.
Verify that the restructuring doesn't compromise the responsiveness of the testimonials section.

Completed the design specific requirements of the Testimonials as per instructions given by the Professor.

Completed the design specific requirements of the Testimonials as per instructions given by the Professor.


Add zmachine unit tests

Which package/s are you suggesting this feature for?
grid_client
Describe the solution you'd like
Add tests for zmachine.ts

WIP:
Working on adding tests on all Zmachine fields.

WIP:
Working on adding tests on all Zmachine fields.

Work completed:
Added tests.

the test is failing is there something missing shall i add ?

verified and tested and working fine


Replace Gulp with tooling that offers similar functionality

Discussed at https://github.com/aspnet/AspNetCore.Docs/pull/12366#issuecomment-491331984.
Possibly work in conjunction with #11610 if a comprehensive overhaul is in the works.
Per @danroth27 in  #10798 - retire Gulp doc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f55e9a-cd3f-83a0-f142-969dc10d3ceb
Version Independent ID: f6845f70-1ac6-2036-f213-a3b665b3d8bf
Content: Bundle and minify static assets in ASP.NET Core
Content Source: aspnetcore/client-side/bundling-and-minification.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @scottaddie
Microsoft Alias: scaddie

Migrated to Bundle and minify master issue #18523


Tagging a card with a PA Category doesn't color the PA Overline

When tagging a card with a PA category, the PA overline should also change color, but currently it remains the same color as would be determined by the PA drop location.

After discussing this with users, it seems the most popular opinion is that it should retain the current behavior, so this will not be implemented.


Request in a remote json file

is it possible to make a request in a remote json file?

Yes, is possible. 😄


Message echoing in a mattermost1 <-> mattermost2 bridge

A bridge between different teams results in each message repeated in the channel from which it had originated.
[mattermost]
    [mattermost1]
    useAPI=true
    Server="yourmattermostserver.domain"
    Team="yourteam1"
    Login="yourlogin"
    Password="yourpass"
    PrefixMessagesWithNick=true

    [mattermost2]
    useAPI=true
    Server="yourmattermostserver.domain"
    Team="yourteam2"
    Login="yourlogin"
    Password="yourpass"
    PrefixMessagesWithNick=true

[[gateway.in]]
account="mattermost1"
channel="channel1"

[[gateway.in]]
account="mattermost2"
channel="channel2"

[[gateway.out]]
account="mattermost1"
channel="channel1"

[[gateway.out]]
account="mattermost2"
channel="channel2"

Every time a user sends a message in yourteam1/channel1, the bot outputs it both in yourteam2/channel2 as well as yourteam1/channel1 (expected behavior would result in output only in yourteam2/channel2).

Edit: even setting up IgnoreNicks="botname" doesn't seem to help.

OK, I pretty much figured out what is happening. The bot is logged in several channels (team1 channel1 & team2 channel2). It receives an incoming message notification once per login, and gets triggered twice. A workaround for now involves using one bot per mattermost team. Not the best, but acceptable.

Thanks! Does this also fix duplicate messages for when the same bot is listening in two channels in the same team?

Yes, you mean #48 ? this is fixed too (in combination with another commit though)

Indeed, everything works great!


fix firewall inconsistencies

There were a few errors with the openFirewall implementation:

Server port was UDP instead of TCP
Query port was TCP instead of UDP
UDP ports were opened on TCP needlessly (this hid the above errors)

Huh, Query is UDP and not TCP?
This needs to be fixed in base Nixpkgs then, since I pretty much lifted that entire setup straight from Nixpkgs, modifying it to account for multiple servers.

Huh, Query is UDP and not TCP?

Yup!

This needs to be fixed in base Nixpkgs then, since I pretty much lifted that entire setup straight from Nixpkgs, modifying it to account for multiple servers. (For reference)

Hmmm we should fix that

Sorry for taking so long, thanks for the contribution!


Most tasks swallow exceptions

What happened?
When there is an unhandled exception inside a task spawn by the SDK, the error is silently swallowed, leading to obscure, hard-to-debug bugs.
What did you expect instead?
Unhandled exceptions are at least logged or the whole Python process crashes.
Affected version(s)
No response
Affected part(s)
Core components (data structures, etc.) (part:core)
Extra information
I discovered this while working at #806. I added a sanity check which failed inside a task that was sending messages to a channel, so no messages was sent, and other task waiting for messages just got stuck, leaving no clues about where the problem might be. This makes the problem really hard to debug.
This issue is actually a problem across all areas of the SDK and projects in general.
A way to cope with it in the SDK would be to extend BackgroundService to provide a create_task() method that automatically adds the task to the task list and then also adds a done callback where we can either log the unhandled exception, or just raise a SystemExit exception to exit the program. We could even give the user the option to decide how to handle unhandled exceptions by either passing a callback or letting them override the default callback as a method of the instance. This callback should also remove the task from the tasks list, something users need to do manually at the moment.
Related issues
The solution to this issue needs to have in mind the following related issues:

#906
#819
#632

Maybe we can add a SDK specific create_task() that catches and logs unhandled exceptions, then use that function also in BackgroundService.

It is not trivial to override the default handler, because it will store the exception in the task object, and maybe users will inspect this task object in the future and report the exception properly in the future. Because of this, we might want to use a custom exception handler that only prints a debug message about unhandled exceptions, otherwise we might spam the logs with spurious messages about tasks stopping due to unhandled exceptions when exception are really properly handled, just not inside the task function itself, adding more noise to the logs and making things even harder to debug.


Please fix your detection of armhf aka arm32 aka armv6

Every node gyp version for a long time. Nodejs version idependant.
A long time ago i opened this issue, can you please implement my fix in your code base so node-gyp works again on arm32?
https://github.com/serialport/bindings-cpp/issues/89

wrong repo meant node-gyp-build


Valid edition 2024 in Cargo.toml file causes error.

"2024" is not valid under any of the given schemasEven Better TOML
How do i fix this?
I am using the 2024 edition of rust in my project. its a valid edition, but EBT does not recognize it.

Please open an issue to SchemaStore on Github. This is a schema issue. Thanks!


Allow list search in CONTEXT

coverage: 92.288% (+0.08%) from 92.211% when pulling 6dfb468537a49a5914ba72c838056984c0a78883 on lmcalvo:master into be82b57f5fca88e92be075e0556a22f1019e99dd on Telefonica:master.


Update README.md

make the config options more clear

Thanks! I'll change the wording, as config.py should have been removed completely a while ago


New Crowdin updates

:tada: This PR is included in version 2.3.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


using ptvsd remotely debugging from Django's development web server binding issue

I apologize if this is simply a user configuration issue but it appears that within one python process we are limited to binding to one IP address.  So when trying to run "python manage.py runserver" after adding pdvsd lines results in an error.  Is there a way around this? Threading?  SocketServer module??
Traceback (most recent call last):
File "manage.py", line 4, in
ptvsd.enable_attach(secret = 'dev', address = ('<IP_ADDRESS>', 1977))
File "/usr/lib/python2.7/site-packages/ptvsd/attach_server.py", line 162, in enable_attach
server.bind(address)
File "/usr/lib/python2.7/socket.py", line 228, in meth
return getattr(self._sock,name)(*args)
socket.error: [Errno 98] Address already in use
No other processes are running on this port.

It's limited to it in a sense that so long as it's the same code that runs, it's up to you to ensure that on the second concurrent run it has to use a different endpoint. For example, you can pick a port randomly, print it out, and then pass that random port to enable_attach; then every process can be attached to separately (so long as you have a way to find out which port it picked).
A better way to fix this would be to allow ptvsd to attach to VS, instead of the other way around. Then VS can keep a single port open, and several processes can use ptvsd to attach to that VS session for debugging.

I don't think this is a concurrent run, it's that Django itself is also trying to listen on <IP_ADDRESS> and this is apparently not working. That doesn't seem to make sense though - I'm sure we've done this before.
Does it make a difference if you also call ptvsd.wait_for_attach immediately after enabling? Maybe we can't listen on the same address multiple times, but once the connection is established it is fine.

Listening the same IP <IP_ADDRESS> shouldn't be a problem if it's on a different port. So the only way this should be hit is if Django somehow causes this code to be run more than once (or if that port number is actually used for something else).

So .. from the error I posted above ... it is true.. address <IP_ADDRESS> is in use but like you said, that shouldn't matter so long as the port isn't being used.  I checked on the server if the port was in use with a quick netstat -atun | grep 1977 resulting in nothing ... I ran the django development web server on 8080.
Theoretically it should have worked.

Do you need to use port 1977, or can you use a different one? Does it work on any other port?

I can use any port necessary, out of curiosity I tried a higher port 46000 with the same result.

Not that I'm aware of. This is very strange, but I suspect it's something platform-specific. We'll need to spend some more time looking into it, or see if anyone else has any ideas.

Update: I did notice that the locale windows version of Django (1.5.12) was newer than the version on my remote RHEL 6 machine (1.4.9) to which I was trying to remotely debug.  Though the actual code I was debugging was identical and runs fine using the older version of Django.  I will re-post when I try with identical versions of Django.

I'm getting the same problem with Django 1.8.14.

Same bug on CentOS (RHEL) 7 and Django 1.8.
Works fine on windows machine, but fail in docker container with CentOS7.

For some reason I didn't get yet, Django was calling the ptvsd.enable_attach("secret", address = ('<IP_ADDRESS>', 3000))twice during it's start up.
I solve the issue by closing the socket before ptvsd tryed to attach it
`import socket
import ptvsd
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock.close()
ptvsd.enable_attach("secret", address = ('<IP_ADDRESS>', 3000))
`

Nice! I will have to try this out.
On Wed, Feb 15, 2017 at 6:16 PM ppbrasil<EMAIL_ADDRESS>wrote:

For some reason I didn't get yet, Django was calling the ptvsd.enable_attach("secret",
address = ('<IP_ADDRESS>', 3000))twice during it's start up.
I solve the issue by closing the socket before ptvsd tryed to attach it
`import socket
import ptvsd
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock.close()
ptvsd.enable_attach("secret", address = ('<IP_ADDRESS>', 3000))
`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/PTVS/issues/1057#issuecomment-280209317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwTH3hTBsPdHb-CyaQz2cjcKWj4giAOks5rc7GXgaJpZM4HFTn_
.

--
Mark
https://www.linkedin.com/in/markengstrom

I don't know why, today it decided not to work.
So I took another approach and could connect using
try:     ptvsd.enable_attach("secret", address = ('<IP_ADDRESS>', 3000)) except:     pass
I could connect, but now I have two different processes listening to the same port.

I'm getting the same problem with Django 1.8.18. to.

Also getting the same error on an Linux Docker container running Flask 0.12.

Not sure about Flask, but I noticed the other day that Django seems to start two processes when you run it now (as of a recent update? I'm not sure). That is likely to cause trouble when we try to listen on the same port twice - likely an exception.
As an idea to investigate - if Django has some variable that shows it is in the second process (which I assume is the one that does the actual work), that is the one we want to enable attaching in.

If anyone encounters this problem like me: A workaround is adding the --noreload flag to manage.py runserver (for Django). Having to re-run the runserver command everytime the code changes sucks, but debugging with print statements is even worse! Hope it helps.
Credit: http://ramkulkarni.com/blog/debugging-django-project-in-docker/

Hopefully the workaround is fine for now. We are looking at long-term debugger improvements that may help here, but nothing specific for this issue.

To use the auto reloading functionality you can make VSCode only attach in the main process. Based on Django's utils/autoreload.py and Django-Extensions' management/commands/runserver_plus.py:
if os.environ.get('RUN_MAIN') or os.environ.get('WERKZEUG_RUN_MAIN'):
    ptvsd.enable_attach(address=('<IP_ADDRESS>', 7913), redirect_output=True)

where I've to add these lines? :D

where I've to add these lines? :D

Some place that gets loaded on startup; I put them in settings.py, but fe. urls.py should also work.


Missing/broken link

The link http://wiki.cython.org/tutorials/numpy referenced on this page https://github.com/cython/cython/wiki/WrappingNumpy is missing or broken.

Thanks. Fixed at https://github.com/cython/cython/wiki/WrappingNumpy/8557d4ae7c0f51a0aaf8631e5aa8156ced15a3af


chore add log to find bug of unstable test

Proposed changes
add log to find bug of unstable test

run buildall

run buildall

run buildall

run buildall

run buildall

run external_p0

run external


Release with SQLite 3.35.5

3.35.0 contained many new features, including math functions and RETURNING clause, which is really useful.
3.35.5 is the latest fix release after that.
Would be nice to release this with 3.35.5 bundled.
Release notes: https://www.sqlite.org/releaselog/3_35_5.html

done. I've confirmed RETURNING close works as expected

want the RETURNING clause. it is really useful


Ensure DSL for Exacts

Added ensure dsl for Exact
Fixed the directory naming (files were in directory arrow.exact by my mistake)

Decided to use ensure instead of refine, I think it will be better for users to have consistent naming throughout all Arrow modules. ensure accepts other Exact so now it must be easier to combine them.
The only problem is that I am not quite familiar with knit and probably have made something wrong, @nomisRev please fix me in that case 🙏
Feel free to change this PR!

Thank you @ustits 🙌


Prevent greedy --used/executed from capturing file

I ran into an issue while trying to use the --used and --executed provenance arguments. Because of the way that argparse works in the synapse CLI client, they capture CLI values greedily, and this can cause the file positional argument to be captured by one of these two optional arguments. See error below, where the file path is being included in --used, leaving not file for the client to upload.
$ synapse store --parentId syn22310623 --used syn22344112 syn22344113 syn22344114 workflow/examples/mutation_models.tsv

SynapseHTTPError: 400 Client Error:
FileEntity.dataFileHandleId cannot be null

The simple fix is to separate the optional and positional arguments with --, which is a UNIX convention that argparse adheres to. This ensures that the --used and --executed arguments don't capture the file positional argument. For example:
$ synapse store --parentId syn22310623 --used syn22344112 syn22344113 syn22344114 -- workflow/examples/mutation_models.tsv

Created/Updated entity: syn22344757     mutation_models.tsv

This can be achieved with a simple one-line fix in the CWL tool, as shown in this PR. I was able to test this fix in another project and can confirm that it solved the error I was previously running into.
If this is merged, can v1.1 be minted?

Mentioning @thomasyu888 as a potential reviewer since I believe he added the useful provenance arguments.

Interesting!  I did not know this.  What happens when there is only --parentId?  This command should still work right?
Another option is to reposition the arguments such that the file to be stored comes right after the synapse store /file/to/store.txt ....

Should also add this as a test case

I've previously been able to use this tool with just --parentId. It's only when --used and --executed are used because these arguments are listed after parentId in the CWL. For reference, this was the problematic command generated by my CWL workflow:
[docker run...]
    synapse \
    store \
    --parentId \
    syn22310623 \
    --used \
    syn22344112 \
    syn22344113 \
    syn22344114 \
    --executed \
    https://github.com/CRI-iAtlas/iatlas-workflows/blob/v1.1/Calculate_Mutation_Models/workflow/steps/calculate_mutation_models/calculate_mutation_models.cwl \
    /var/lib/cwl/stg2ae5a2f8-1339-4f87-ab95-e1d9cc215ac8/mutation_models.tsv

Personally, I'm not a fan of placing optional arguments after positional arguments. Also, using the -- delimiter (as opposed to changing the argument order) is an explicit fix rather than an implicit one, which can be helpful for future maintainers. It's also a simpler (i.e. one-line) fix than reordering the arguments. That said, I defer to others who've developed the tool.
I can add an additional test case. The reason that the current test that uses --used and --executed doesn't fail is because it also includes --name, which is placed before the file positional argument, thus preventing the greedy capturing.

I added a test case for the scenario described in this PR. However, I can't test the test until I have access to the credentials for the Synapse service account. Request pending...

I updated the expected output for the new test case. Also, I've enabled the CI workflow on PRs (instead of just pushes).
I'm able to get a passing test suite locally (see output below). So, I'm not sure why the tests are failing on this PR.
$ cwltest --test tests/test-descriptions.yaml --tool cwl-runner

Test [1/8] synapse_get_annotations: Get annotations
Test [2/8] synapse_set_annotations: Set annotations
Test [3/8] synapse_get: Get synapse file
Test [4/8] synapse_store: Store file to Synapse
Test [5/8] synapse_store_greedy_arguments: Store file to Synapse where --used/--executed (which are greedy arguments) are the last optional arguments
Test [6/8] synapse_query: Query a table or file view in Synapse
Test [7/8] synapse_sync: Sync files into Synapse with a manifest
Test [8/8] synapse_get_sts: Get Synapse STS token
All tests passed

I do notice that the ci.yaml in this repo is different from the ci.yaml from the template. I don't know if something was fixed in the template that should be ported here. I could copy-paste the entire template version.


travis: use new Bash Codecov upload script

This removes the need for using sudo to install a Python upload
script. By removing sudo, Travis will let our build run in a
container, which is supposed to start faster.

This actually didn't work due to codecov/codecov-bash#3. We should not merge this until that pull request is merged and we've verified that the fix is enough.

Current coverage is 97.76%

Merging #204 into master will not affect coverage as of 91acc8c

Powered by Codecov. Updated on successful CI builds.


Cache roles and permissions

It only utilizes the caching for the real-time permission checks.

Ah. I'll make sure the phpunit tests pass on my local before I try again. BRB.


Create separate dev and prod configs

Some pointers:
https://spring.io/blog/2020/04/23/spring-tips-configuration
https://www.baeldung.com/spring-profiles
https://stackabuse.com/spring-boot-profiles-for-dev-and-prod-environments/

💯


Generic module event

Summary
This PR adds a generic event for modules. It includes an example in the HTML module.
Background
In a scenario where we'd want to allow a more loose coupling between DNN extensions, having a generic handler allows us to send events between modules. It would also allow simple messagebus-type applications. The sample shows how the HTML module would implement this. As the UpdateModule event only fires when the Settings of a module are updated, it doesn't tell us when the actual content of a module is updated. Now, with this simple change, the HTML module can signal that it's content has changed and any other component can leverage this if it needs to.

I believe that this needs a bit more consideration before we accept, as I echo all of @bdukes comments and have a few more.  Possibly discuss this @ the next approvers meeting?

I believe that this needs a bit more consideration before we accept, as I echo all of @bdukes comments and have a few more.  Possibly discuss this @ the next approvers meeting?

After discussion the best avenue is to implement a more powerful and standardized approach with a library like MediatR. The main drawback of the solution proposed in this PR is that any consumer would need to filter for the module and event it is waiting for. This is obviously not very efficient and poses risks if this is scaled up.
Closing this for now.


Apply fixes from StyleCI

:tada: This PR is included in version 1.40.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bug in the latest libtpu nightly release

Description
I've experienced the issue in #24821, but I decided to create a new issue, since I've figured out the problem. Here is the code example that fails on the latest jax[tpu] with libtpu_nightly-0.1.dev20241010+nightly.cleanup
import jax
import jax.numpy as jnp
import jax.random as jr
from jax.sharding import NamedSharding, PartitionSpec as P

def f(data,key):
    indices = jr.choice(key, 100, shape=(100,))
    indexer = jnp.ones((100,2), dtype=jnp.int32)[indices]
    return data[indexer[:, 0], indexer[:, 1]]

sharding = NamedSharding(jax.make_mesh((len(jax.devices()),), P("x")), P("x"))

sharded_data = jnp.zeros((256,10,10,3))
sharded_data = jax.device_put(sharded_data, sharding)
keys = jr.split(jr.key(0), 256)

jax.vmap(f)(sharded_data, keys)

Fails with a bunch of various issues, it is either that TPU cannot initialize itself:
/home/user/.local/lib/python3.11/site-packages/jax/__init__.py:31: UserWarning: cloud_tpu_init failed: AttributeError("module 'libtpu' has no attribute 'get_library_path'")
 This a JAX bug; please report an issue at https://github.com/jax-ml/jax/issues
  _warn(f"cloud_tpu_init failed: {exc!r}\n This a JAX bug; please report "

Or, sometimes, with
RuntimeError: Unable to initialize backend 'cpu': ALREADY_EXISTS: Config key cpu:local_topology/cpu/3 already exists.
Additional GRPC error information from remote target coordination_service while calling /tensorflow.CoordinationService/InsertKeyValue:
:{"created":"@1731217318.560649460","description":"Error received from peer ipv4:some ip:8476","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Config key cpu:local_topology/cpu/3 already exists.","grpc_status":6} (set JAX_PLATFORMS='' to automatically choose an available backend)

Or it could even fail with some very internal errors like
jaxlib.xla_extension.XlaRuntimeError: UNKNOWN: /home/arst/.local/lib/python3.11/site-packages/equinox/_jit.py:55:14: error: All components of the offset index in a gather op must either be a offset dimension or explicitly collapsed or explicitly batched; got len(slice_sizes)=4, output_slice_sizes=2, collapsed_slice_dims=1,2, operand_batching_dims=.:
...
   @     0x7fb4ce901fe4  (unknown)
    @     0x7fb67c825f8d  xla::InitializeArgsAndCompile()
    @     0x7fb67c8266f6  xla::PjRtCApiClient::Compile()
    @     0x7fb68255566c  xla::ifrt::PjRtLoadedExecutable::Create()
    @     0x7fb682550a51  xla::ifrt::PjRtCompiler::Compile()
    @     0x7fb681ce452e  xla::PyClient::CompileIfrtProgram()
    @     0x7fb681ce532e  xla::PyClient::Compile()

This solution is to just explicitly downgrade libtpu to libtpu_nightly==0.1.dev20241009; some old versions also don't work, but this one seems to be OK.
System info (python version, jaxlib version, accelerator, etc.)
# python3.11 -m pip freeze
jax==0.4.35
jaxlib==0.4.35
libtpu==0.0.2
libtpu_nightly==0.1.dev20241010+nightly.cleanup
... (a bunch of other unrelated packages)

# python3.11 --version
3.11.10

# neofetch
OS: Ubuntu 20.04.4 LTS x86_64
Host: Google Compute Engine
Kernel: 5.13.0-1023-gcp
CPU: AMD EPYC 7B12 (240) @ 2.249GHz

The machine is from TRC, v4-32

Hi @knyazer , since the OS is Ubuntu 20.04, it looks like maybe you created the VM with --version=tpu-ubuntu2004-base instead of tpu-ubuntu2204-base, could that be right? (see docs here). I haven't been able to repro the failure with tpu-ubuntu2204-base. If you used a different version, could you try using that?
If there are instructions somewhere to use tpu-ubuntu2004-base please let us know so we can update that.

Hey @emilyfertig!
Hmmm, I was using the command that (I think?) I got recommended by the TRC support at some point, which is
gcloud alpha compute tpus queued-resources create arst --node-id=arst --accelerator-type=v4-32 --zone=arst --project=tpu-research-grant-12345 --runtime-version=tpu-vm-v4-pt-2.0

But I cannot find any evidence to back my claim. From now on, I shall use the tpu-ubuntu-2204-base runtime-version. If you think that my command is correct, or that I'm somehow wrong and this needs a further discussion: feel free to reopen the issue, but for now I will close it.
Thanks for pointing this out! That was a pretty annoying flakiness and I spend ~day on debugging :)

That might be an obsolete runtime version -- the current ones are listed here. I'm glad that helped, sorry about the debugging detour!


Feat(eos_designs): Support for PIM RP access_list_name under VRFs and Tenants

Change Summary
Support use of access_list_name under VRFs and Tenants, in a similar way to underlay_multicast_rps.
Related Issue(s)
Fixes #2881
Component(s) name
arista.avd.eos_designs
Proposed changes
Data Model:
< network_services_keys.key_1 >:
  < tenant_a >:
    pim_rp_addresses:
      - rps:
          - <str>
        groups:
          - <str>
        access_list_name: <str>
    vrfs:
      < tenant_a_vrf_1 >:
        pim_rp_addresses:
          - rps:
              - <str>
            groups:
              - <str>
            access_list_name: <str>

Behaviour is identical to that in #2846:
List of groups to associate with the RP addresses set in 'rps'.
If access_list_name is set, a standard access-list will be configured matching these groups.
Otherwise the groups are configured directly on the RP command.

How to test
Molecule tests modified to cover this case.
If you have an existing RP config on your PEGs you should be able to add the access_list_name key to an existing RP entry (value is the name of the ACL) and instead of specifying the groups  on the rp address command, the generated config should refer to the ACL, which should contain the same groups that were configured on the rp address command.
Checklist
User Checklist

N/A

Repository Checklist

[X] My code has been rebased from devel before I start
[X] I have read the CONTRIBUTING document.
[X] My change requires a change to the documentation and documentation have been updated accordingly.
[X] I have updated molecule CI testing accordingly. (check the box if not applicable)

Tested this and works as expected.

Merging since @perimore also tested and approved.


Revert "Merge pull request #42242 from eeckstein/escapeinfo"

This reverts commit c05e064cd831dda5c47ac6360dc82b31fe587d1f, reversing
changes made to c1534d5af9a480f82e0da9d7a4ec5d5341b5a1ab.
This caused a regression on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @eeckstein @atrick

@swift-ci please test

@compnerd what regression?

Anything else than the test fail, which is fixed by https://github.com/apple/swift/pull/42555?

Never mind, I saw your comment in the other PR. This is already fixed by https://github.com/apple/swift/pull/42555. So the revert was actually not necessary.

https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/547/console
Why should the test be an XFAIL?  If you are XFAILing it, do you have a timeline for repairing it?

The XFAIL was only the workaround from the build wrangler. The problem is a wrong check-pattern.


[feat] Add additional sample data for questions and answers

Would you like to have a new feature? Please describe.
Please go to server/data/dev-data/questions.json and add more questions and answers from previous examples
How would this feature be beneficial for the project
No response
Additional context
No response

helping with this issue. /assign

Sorry @ShivamTyagi12345 I won't be able to assign it to you as it is a college project. We will be accepting outer contributions from August 2022

Hey assign me so that I can contribute in this issue.

i would like to work on this

Hey assign me so that I can contribute in this issue!


50 Skin u_skin

Deleting of 200+ skin and renaming ( 36 MT character, whose 8 girl + 14 MFF character )

WOW ! Can i have a support for my PR ... because i don't understand .. i rebase before work and i see crabman's commit for submodule ... i don't understand this wave of commits ...

I think you should update your clone first. I can extract your commit, but it would be cleaner to have your master branch identical to ours, and your commit in a different branch.
We could meet on IRC for assistance (if you have the time for that).

Je pense qu'on peut virer "mff_character_1", "mff_character_3", "mff_character_6", "mff_character_7", "mff_character_11" et "character_11".
Je les remplacerai par (par exemple):

"character_33"
"character_28"
"character_67"
"character_123"
"character_265" ou "character_273"
"character_282"
"character_504"

Je pense qu'il faut aussi quelques persos "fun" (d'où 504 et 123)

@ezamlinux Thank you for this PR
@ObaniGemini
There are less than 50 skins so i think we can add the @ObaniGemini characters suggested without deleting other characters
@ezamlinux @LeMagnesium
For the PR, I think we need to redo it, without being nasty it's a really mess...

Rejected/Closed because now here : https://github.com/MinetestForFun/server-minetestforfun/pull/477


[DEPRECATED] DO NOT USE THIS LIBRARY ANYMORE - Read for full details

This was a lovely library, but it wasn't updated during more than 2 years (I just hope COVID didn't have anything to do there - Even the Github user who created this library seems that was deleted (Benoît Delmaire)).
We are all migrating to https://www.npmjs.com/package/react-native-reanimated-carousel

It is important that you migrate out of this library as soon as possible, in order to stop promoting it.

See you in the other side.

And please stop creating other issues in this library so this one keeps on the top.

Thank you

👍

Guys i already create a fork, because i think something happened with this developer... try using my solutions on
https://www.npmjs.com/package/react-native-new-snap-carousel
hope this help

Guys i already create a fork, because i think something happened with this developer... try using my solutions on
https://www.npmjs.com/package/react-native-new-snap-carousel
hope this help

Why not just https://www.npmjs.com/package/react-native-reanimated-carousel ? We are all migrating there.

That is a decision for every developer.. some of them just want to maintain legacy code without so much effort, others would like to implement a new library 🤷🏻♂

Guys i already create a fork, because i think something happened with this developer... try using my solutions on
https://www.npmjs.com/package/react-native-new-snap-carousel
hope this help

Thanks, this helps us who in need to migrate to the newest Expo and RN versions but also need more time to migrate to react-native-reanimated-carousel.

I can't find the fork on github? npmjs is still pointing to this repo..

NPM will still point towards this repo unless the owner of the NPM project publishes an update (or transfers it to someone else and then the new owner publishes an update).
You can npm install https://github.com/<username>/<repository> and it'll install from a github-sourced repository instead of the NPM repository.

I've lost a plenty of time with this.

Forked Repository - https://github.com/ciberbob-007/react-native-new-snap-carousel
Credits - @ciberbob-007

Commenting to bump this issue to the top in the issues view.

Guys i already create a fork, because i think something happened with this developer... try using my solutions on
https://www.npmjs.com/package/react-native-new-snap-carousel
hope this help

there are no @type repository
how install react-native-new-snap-carousel??
Old snap carousel has @type repository
https://www.npmjs.com/package/@types/react-native-snap-carousel

@BrodaNoel I have tried to implement the new library you are suggesting, but I am unable to get it working with my current code due to some missing UI features. I am not finding the following props in the new library:
itemWidth={Dimensions.get('window').width - 65}
sliderWidth
itemHeight
sliderHeight
activeSlideAlignment
inactiveSlideScale
inactiveSlideOpacity
containerCustomStyle
contentContainerCustomStyle

@BrodaNoel You're right, I should have posted that in the other library. I guess that I just thought that people who have migrated might have a better idea.

@BrodaNoel I have tried to implement the new library you are suggesting, but I am unable to get it working with my current code due to some missing UI features. I am not finding the following props in the new library Parallax mode:
       itemWidth
        sliderWidth
        itemHeight
        sliderHeight
        activeSlideAlignment
        inactiveSlideScale
        inactiveSlideOpacity
        containerCustomStyle
        contentContainerCustomStyle

Any help or guidance will be very appreciated. Thanks!

I will try to do support to this library as much as possible, please ask in the fork repo on https://github.com/ciberbob-007/react-native-new-snap-carousel

i don understand how is this getting 122K weekly downloads, oh! maybe because of people like me who figures out that it is deprecated after starting the implementation.


Add activity pattern arrangement

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- pyrsa/vis/activity_pattern_arrangement.py  8

See the complete overview on Codacy

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@074213c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #152   +/-   ##
=========================================
  Coverage          ?   81.74%
=========================================
  Files             ?       53
  Lines             ?     4717
  Branches          ?        0
=========================================
  Hits              ?     3856
  Misses            ?      861
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074213c...aa9735c. Read the comment docs.


CleanWebpackPlugin | Requires a config object

new CleanWebpackPlugin() | requires a config object than an array
describe your changes...

[x] Read and sign the CLA. PRs that haven't signed it won't be accepted.
[ ] Make sure your PR complies with the writer's guide.
[ ] Review the diff carefully as sometimes this can reveal issues.
Remove these instructions from your PR as they are for your eyes only.

Please also update the dependency in the package.json

@montogeek which package.json do you mean? i dont see us asking for specific version in the guides

We don't ask about it, but it is there:

Ah there it is, i couldn't find it with algolia :)

@montogeek lets get this one in and i'll do a follow up ?

Thanks!

Thanks!


List is converted to String

The List are converted to a String instead of a JSONArray
For instance the following code:
JSONObject object = new JSONObject();
object.put("mylist", Arrays.asList("my1", "my2", "my3"));

is producing
{"mylist":"[my1, my2, my3]"}

Instead of:
{"mylist":["my1","my2","my3"]}

Many thanks in advance :)
Sebastien

Original org.json has 3 methods:

put(String, Object)
put(String, Collection)
put(String, Map)

Openjson implementation is based on Android code and has only 1 method

put(String, Object)

Problem:

put(String, Collection/Map) breaks 'null' contract of put(String, Object) where null-value can be used to remove property from object. The missing methods in 'org.json' puts empty JSONArray|JSONObject.

What options we have:

Keep current minimal API compatible with Android

Follow org.json and break our contract for nulls for 2 new put() methods. It will not be possible to remove values using put(String, (Collection|Map)null). This will make us incompatible with Android API on compile level: calls to put(String, null) will not be compilable without explicit casts. Users who migrate from org.json will not have runtime issues.

Follow put(String, Object) contract for 2 new methods and, if null is passed as a second parameter, remove the property from object. This will make us incompatible with both org.json and Android API but the package will have better API.

I would follow option 2 here and be compatible with org.json package. People on Android have no need in our API and those who migrate from org.json on server platforms want minimum surprise in runtime.
Other thoughts?

I would go for option 2 too, as long as put(String, Object) tests the type of the supplied object (Collection/Map) and calls the appropriate method.

I believe if you have these 3 methods you can't call put(String, Object) without explicit cast to (Object).
And if the method put(String, Object) will check the type and call to put(String, Collection|Map) it will be API break both with org.json and Android and lead to runtime issues for those who migrate.

I believe if you have these 3 methods you can't call put(String, Object) without explicit cast to (Object).

Each methods will be correctly linked whether the object is a known Collection (put(String, Collection)), a known Map (put(String, Map)), or any other object type which is not a Collection nor a Map (put(String, Object)). The linkage is done at compile time.

And if the method put(String, Object) will check the type and call to put(String, Collection|Map) it will be API break both with org.json and Android and lead to runtime issues for those who migrate.

IMO that's the opposite, if the linkage is on put(String, Object), the underlying object - if it's a Collection/Map - should be handled correctly. That's actually the purpose of my issue, the org.json library behave that way.
For instance:
Object value = PropertyResolver.getValue("myList", this.getModelObject()); // gets a List at runtime

JSONObject object = new JSONObject();
object.put("mylist", value); // linked to put(String, Object) at compile time

You are correct about linking. My comment about explicit casts is valid only for null values.

I would go for option 2 too, as long as put(String, Object) tests the type of the supplied object (Collection/Map) and calls the appropriate method.

Here is the code from Wicket 7.x branch (same as json.org): it does not check if the object passed is collection or map and adds it as is.
public JSONObject put(String key, Object value) throws JSONException {
        if (key == null) {
            throw new NullPointerException("Null key.");
        }
        if (value != null) {
            testValidity(value);
            this.map.put(key, value);
        } else {
            this.remove(key);
        }
        return this;
    }

.

Just a quick question here.
Is this a theoretical problem (regardless of the attraction), or is there code that uses Open Json right now that breaks because of the single method?

Hello All,
We can add code like
public JSONObject put(String key, Object value) throws JSONException {
        if (key == null) {
            throw new NullPointerException("Null key.");
        }
        if (value != null) {
if (value instanceof Collection) {
            testValidity(value);
            this.map.put(key, value);
} else if ....
        } else {
            this.remove(key);
        }
        return this;
    }

complex logic like this is already used in the code (if I'm not mistaken it is new JSONObject(String))
WDYT?

Max, for a package with different name (com.github.openjson) I would try to convert this method (and all «Object» methods) to be package local - for internal use only.  As public option I would add alternatives with conrete types: put(String, JSONObject|JSONArray). In this case users will have no chance to call API with unclear behavior.
For 'org.json' version of the library this may not work.

This might be better from architect point of view, but it would require more code from user
BTW never heard of 'null' contract of put, always used remove for this :)

I have the same experience here: never used this method for removal or for collections.
To me the worst problem is that this problem is hidden from user. I believe it's better to ask user manually change the code the way he wants it to be used (this is trivial change) than have issues in runtime (or in database state)

@mfursov right, I didn't looked into the code. I think overloads are here just for ease. That's ok (and normal) that the object is stored as it is. But the issue is how it will be handled when rendered (to string)
@tdunning I don't think this is due to this method in particular (maybe my description was confusing), the real issue/break is when it's converted to string

@mfursov do you need need help with with?

@solomax the only help I need to fix 'com.github.openjson' branch is to decide which fix to apply before Wicket8 release.
I like any of these 2 options:

v1.0.1: add 2 more methods and make all 3 methods 100% compatible with original 'org.json'
In this case users will be required to perform minimal code change and we will know we tried to be as much 'org.json' as we can. We will inherit it's problems and may find more issues latter.

v2.0.0: remove «Object» methods (put, constructors, wrap, accumulate).  Add dedicated «putJSONObject|putJSONArray» methods.
In this case users will be forced to review all the code that has hidden compatibility problems and  library will be even simpler than before. Users are also have an option to swtich to original 'org.json', jackson or whatever they like if changes are big.

Both these solutions can be prepared/tested and pushed to maven in 1 day.

Both and mark the methods from 1) as @Deprecated and later remove them in 2.0.0

+1 for 3) :))

I don't think removing "Object" methods sounds like a good plan. These methods are quite essential IMO.
Still IMO, actually the main problem is not in the put method, but how the object is rendered

So I guess the best option for API users will be:
put should be more sophisticated: ie if collection is being put it should be auto-wrapped into collection

Ok, I will implement option 1 and update maven with v1.0.1 for com.github.openjson today.
@solomax ok, so put(String, Collection|Map) will check for object type and call appropriate method (this is not what original org.json have, btw).
@sebfz1 I thought it will be almost enought to replace put(Object) with putValue(Object) where value is known library type only: JSONArray, JSONObject, String or one of primitive types. This will allow to keep a lot of old scenarios where fields from one object are copied into another, but will not support automatic hierarchy creation from Maps.  But anyway, let's keep it for latter.

Do you mean having the following?

put(Collection|Map)
putValue(JSON*|String|Primitive)

In that case:
1/ Custom Object is not handled (in case it implements JSONString or equivalent). But ok, let's say it can be done later...
2/ There is 2 different method names, one for Collection/Map and one for String. That's a problem: in my use-case I don't know the type of object (defined by the user), that's why I need a unique/generic "Object" method.
3/ From my pov, put(Collection) is just a convenient overload. If you do any processing in it instead of just storing the object, what will happen if the user does a get right after and think he will retrieve its object ? (to be honest, I do remember how it behave, I just matter of raising potential points :) )

Here is a fix for 'com.github.openjson' branch:
https://github.com/openjson/openjson/commit/5ce9624000d324cdd5813b1459a185b91a130a4c

Checks for Map|Collection types in put(String, Object)
Fixes JSONObject(Map) constructor to accept nulls (same as org.json)

I'm going to add tests for these branches and release it as v1.0.1 today  if no issues/objections found.

Released to maven: http://repo1.maven.org/maven2/com/github/openjson/openjson/1.0.1/

Wicket 8.x has been updated to use it!
I'll take a look tomorrow to update 6.x and 7.x as well unless someone beats me to do it.

This will be a breaking change for Wicket 6.x & 7.x.
If timeline for adoption of this change allows to wait until version Wicket 8.x release I would wait and asked customers to migrate to Wicket 8.x if they do really care about this single line of code in MIT license.

Thanks guys for the quick change!
I've tested upon wicket-8.0.0-SNAPSHOT and so far it seems to be good! :+1:

@mfursov It isn't a matter of the users any more. It is a matter of the Apache Board saying no more releases with the non-OSS license.


Submit additional tests about NSString* dataUsingEncoding

Add tests for #303
NSString* dataUsingEncoding method always get random tail string in the data.bytes.
So submit this test.

Hi @cloudmonkeypeng, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

This is working by design, so this is not really a valid test.  dataUsingEncoding by design does not include the null termination character, which is needed if you are using %s to print the string.


Apex 28 pull 2 bak

Please open a ticket if not already open to discuss the need for this.

This is the ticket https://malhar.atlassian.net/browse/APEX-28


[ALL_ANALYSIS] Change the implementation of the question added in the jupyter.

If len(question) > 1, output comma separated

Changed with e04238e4bef3535e0ede643261247f1521a5c092


metame crash with last radare version

I updated radare to the last version and metame now crash
metame -i ea1da9a6fb202a0e1d9e2c27b1c806b2 -o caca.exe
[INFO] Opening file with r2
Metadata Signature: 0x96e8 0x10001424a5342 12
.NET Version: v2.0.50727
Number of Metadata Streams: 5
DirectoryAddress: 6c Size: 29e0
Stream name: MZ 4
DirectoryAddress: 2a4c Size: 1638
Stream name: MZ 4
DirectoryAddress: 73676e69 Size: 0
Stream name: MZ 4
DirectoryAddress: 10a8 Size: 535523
Stream name: MZ 4
DirectoryAddress: 10 Size: 49554723
Stream name: MZ 4
Traceback (most recent call last):
  File "/usr/local/bin/metame", line 5, in <module>
    metame.main()
  File "/usr/local/lib/python2.7/dist-packages/metame/__init__.py", line 19, in main
    r = r2parser.R2Parser(args.input, True, debug=args.debug, force_replace=args.force)
  File "/usr/local/lib/python2.7/dist-packages/metame/r2parser.py", line 20, in __init__
    info = json.loads(self.r2.cmd("ij").replace("\\", "\\\\"))
  File "/usr/local/lib/python2.7/dist-packages/r2pipe/open_base.py", line 204, in cmd
    res = self._cmd(cmd, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/r2pipe/open_sync.py", line 102, in _cmd_process
    self.process.stdin.write((cmd + '\n').encode('utf8'))
IOError: [Errno 32] Broken pipe

Crash with any sample

i had the same problem. It seems that "-q" flag breaks the pipe in newer version of radare2.
I managed to fix it with #15 .

Thanks @antonioCoco for the fix. I merged your PR and released a new version in github and pip.


Cursor 'pointer' missing

As reported by @xrobau

This is a User Experience issue more than anything else.

When the mouse pointer is over something that can be clicked on, there should be some css along the lines of:

.ng-binding:hover {
cursor: pointer;
}

However, there's some things that AREN'T clickable that have the ng-binding class (well, at least the 'h2' class at the top of the page)

This change has been implemented through https://github.com/sensu/uchiwa-web/commit/281e8ad6e01d82e474a5330f9f51b0f3a1a148f3


HTML (ERB) - htmlbeautifier custom path

I have installed htmlbeautifier through the command gem install htmlbeautifier but when I try to run your beautifier on HTML I get this error
Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;htmlbeautifier < "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/input115210-78658-j6w5bi" > "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/115210-78658-ks7f94" /bin/sh: htmlbeautifier: command not found

Looks like there currently is not an option for setting the path to htmlbeautifier (see beautifier code at https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/html-erb-beautify.coffee ).

[ ] add option to set path of htmlbeautifier

Currently Atom Beautify attempts to automatically detect htmlbeautifer and other installed beautifiers with the line:
/bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;

Test to see where you htmlbeautifier path is with:
which htmlbeautifier

For instance, mine returns: /usr/bin/htmlbeautifier
What's yours?
It's strange that gem did not setup either your .bash_profile or .bashrc files such that running the special script (shown above) did not find it automatically. This will be fixed with #164.

Mine returns /Users/chriswatson/.rvm/rubies/ruby-2.1.5/bin/htmlbeautifier. Is it possible to reinstall the gem in /usr/bin?

I am not a Ruby developer, so I am not really sure what you can and cannot do with gem, sorry. Let me know if you find out those! :smile:
Maybe there is something you could do with Bash aliases in either .bashrc or .bash_profile: http://tldp.org/LDP/abs/html/aliases.html
Maybe the following (untested):
alias htmlbeautifer='/Users/chriswatson/.rvm/rubies/ruby-2.1.5/bin/htmlbeautifier'

The funny thing is if I run htmlbeautifier in terminal it works. It just flakes out and throws that error within Atom. I don't really know coffee well enough to fix it for myself either /.\ haha

Published to v0.21.6
Usage: take that htmlbeautifier path and go into Atom Beautify's package settings, and find htmlbeautifier path and enter it there. Then try to beautify.
Let me know if it works. Thanks!

Dang I thought that would work. I just got this
Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;"/Users/chriswatson/.rvm/rubies/ruby-2.1.5/bin/htmlbeautifier" < "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/input115212-87663-3icos6" > "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/115212-87663-3l8iqw" env: ruby_executable_hooks: No such file or directory
I checked the directory and it does exist so what am I doing wrong?

Try: http://stackoverflow.com/a/26370576/2578205
So /Users/chriswatson/.rvm/rubies/ruby-2.1.5/bin/htmlbeautifier becomes /Users/chriswatson/.rvm/rubies/ruby-2.1.5/wrappers/htmlbeautifier

What is going on here?! Haha
Command failed: /bin/sh -c [ -f ~/.bash_profile ] && source ~/.bash_profile;[ -f ~/.bashrc ] && source ~/.bashrc;"/Users/chriswatson/.rvm/rubies/ruby-2.1.5/wrappers/htmlbeautifier" < "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/input115212-87663-1rwyswl" > "/var/folders/s_/sqlhgb657c51smfrcpk7x2x00000gn/T/115212-87663-4rvura" /bin/sh: /Users/chriswatson/.rvm/rubies/ruby-2.1.5/wrappers/htmlbeautifier: No such file or directory

I am not a Ruby developer, so I have no idea :stuck_out_tongue_closed_eyes:. Unfortunately, I don't think I'll be much help. I'd recommend searching around for your issue ruby_executable_hooks: No such file or directory and if you do find anything let me know so that we can fix this once and for all.
I hope you have better luck! Thanks.

I just tested using the custom htmlbeautifier path set via Atom Beautify's Package settings. Everything worked smoothly, so I am closing this issue.
Hopefully you have some luck with your Ruby installation issue, @iDev0urer .


Responsive navbar.

hello, I am a gssoc participant ,I see the navbar is not responsive .i would like to work on this issue..
can you pls assign this to me.?

hello, I am a gssoc participant ,I see the navbar is not responsive .i would like to work on this issue..
can you pls assign this to me.?

@rakshitnayak This was asked by some other participant earlier than you. Please find some other issue or let me know if you can do something different. Remember, we have a rule of First Come First Serve :)


Histogram Lua class

Still digging though, but AFAIK, this PR looks correct and provides a drop-in replacement for our Histogram_v1.lua module that avoids table allocations.
However, I question if this is the right place for a module like this.
An official lua API wrapper would ideally be minimalistic and just wrapping the C functions, like our Python wrapper: https://github.com/circonus-labs/libcircllhist/blob/master/src/python/circllhist/wrapper.py
I would like to see us doing something similar for lua.
Differences to this version are as follows:

This module pulls in 3 different dependencies in that are not needed in a minimal version: funiter (worst offender), tablex, lunity. This feels bloaty and duplicates code.

In addition, Histogram_v1 contains a number of regrettable choices that we want to get away from.
By exposing these functions here, we morally oblige ourself to keep on supporting them.

coroutines for IV quantiles are really slow https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R243
auto_y_rescale is off-topic for libcircllhist https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R334
self:quantiles(). We create a table just to unpack it. Wasteful. https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R217
Same here: https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R226
Same here: https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R287
Same here: https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R302
Same here: https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R316
coros for Hist:iteration again. This is a killer: https://github.com/circonus-labs/libcircllhist/pull/38/files#diff-a46588a3039863238263e1d9739d3175R440
Why expose Histogram_C and Histogram as names for classes (unmotivated here)

So my suggestion would be to either:
(a) Move this module into our internal code base as Histogram_v2.lua, and strip out the dependencies mentioned in (1). OR
(b) Put a big disclaimer at the top, that the exposed API is unstable and will undergo changes as we cleanup the Histogram module.

I disagree that we need to make this module pristine before releasing.  This is open source free software that is very useful to people who do Lua development.  I would release as is and fix over time.

I disagree that we need to make this module pristine before releasing.

I never said this. I just want to be clear, that I have no intentions in supporting a module like this going forward. Breaking changes will land without warning.


MTSRE-1520: Fix typo for remote-phase tolerations

Summary

Change Type
Bug Fix
Check List Before Merging

[x] This PR passes all pre-commit hook validations.
[x] This PR is fully tested and regression tests are included.
[x] Relevant documentation has been updated.

Additional Information

/retest

/approve
/lgtm


[iOS] Expose isAccessibilityElement as a prop

Does any other open PR do the same thing?
No
What issue is this PR fixing?
https://github.com/react-native-community/react-native-maps/issues/3114
When the MapView has isAccessibilityElement: YES, the map captures any accessibility taps and does not forward them on to the markers. Passing an isAccessibilityElement prop allows the developer to expose map children (ie markers) to VoiceOver and/or other accessibility tools.
How did you test this PR?

Created a map with custom markers.
Set isAccessibilityElement: false on map.
Turned VoiceOver on
Tapped on markers
Verified that VoiceOver recognized markers, allowed me to tap into them

This looks great, any chance to do it for android too (if it's not there already) ? 😻

Makes sense, I can do that.
The reason I didn't do that here is that Android does not exhibit the same issues as iOS -- when TalkBack is on, markers are still tappable. But I agree exposing the prop cross-platform is the right move.

although hm -- isAccessibilityElement is an iOS-only concept.

Ok, in this case can we document the new property  and mention is iOs only?
Also, if this works in Android out of the box, maybe we should set it default to true so the users don't really have to do anything to get this, only to be able to disable it if they need it for some reason ?

@computerjazz ^^

@computerjazz ❤


[data-plane] refresh ai-content-safety-rest sdk

https://github.com/Azure/azure-sdk-for-js/issues/30680

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure-rest/ai-content-safety

need use main to refresh