Add standard bin/scripts

This PR implements the standard build entrypoints / menu under bin/, specifically:

bin/build <-- builds the jekyll site to _site/
bin/package  artifact.tgz <-- does a clean build of the jekyll site inside a Docker container, and tars the resulting _site/ files
bin/reload-upstream <-- fetches upstream doc repositories
bin/start-webserver <-- runs a local webserver serving the site for development uses

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://jenkins.meta.logsearch.io/job/shared.releases.logsearch-website-PRs/11/
Build Log
last 50 lines
[EnvInject] - Inject global passwords.
GitHub pull request #7 of commit fe29510281104ea718e0591ace305b8baa6021fe automatically merged.
[EnvInject] - Loading node environment variables.
Building remotely on slave-z0.0 (docker ubuntu swarm) in workspace /var/vcap/sys/tmp/jenkins_slave/workspace/shared.releases.logsearch-website-PRs
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/logsearch/logsearch-website.git # timeout=10
Fetching upstream changes from https://github.com/logsearch/logsearch-website.git
> git --version # timeout=10
using .gitcredentials to set credentials
> git config --local credential.helper store --file=/tmp/git466979246488236266.credentials # timeout=10
> git fetch --tags --progress https://github.com/logsearch/logsearch-website.git +refs/pull/*:refs/remotes/origin/pr/*
> git config --local --remove-section credential # timeout=10
> git rev-parse origin/pr/7/merge^{commit} # timeout=10
Checking out Revision 13812c3ddd3faac5764244af6713b19c7eb3de5e (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 13812c3ddd3faac5764244af6713b19c7eb3de5e
First time build. Skipping changelog.
[shared.releases.logsearch-website-PRs] $ /bin/sh -xe /tmp/hudson6500193838790253752.sh
+ /var/vcap/sys/tmp/jenkins_slave/workspace/shared.releases.logsearch-website-PRs/_build/bin/jenkins-build logsearch-website-11.tar.gz
/tmp/hudson6500193838790253752.sh: 2: /tmp/hudson6500193838790253752.sh: /var/vcap/sys/tmp/jenkins_slave/workspace/shared.releases.logsearch-website-PRs/_build/bin/jenkins-build: not found
Build step 'Execute shell' marked build as failure

Test FAILed.

@dpb587, Great feedback, thanks.  I especially like the idea that start- indicates a background process and run- indicates a foreground process.
I've made all the changes propose.

:+1:

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://jenkins.meta.logsearch.io/job/shared.releases.logsearch-website-PRs/13/Test PASSed.


DataParallel

I am training to run the model on multiple GPUs. Probably SplitCrossEntropyLoss causes some troubles, any hints?
File "main.py", line 209, in train
    raw_loss = criterion(model.module.decoder.weight, model.module.decoder.bias, output, targets)
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__
    result = self.forward(*input, **kwargs)
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 114, in forward
    outputs = self.parallel_apply(replicas, inputs, kwargs)
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/parallel/data_parallel.py", line 124, in parallel_apply
    return parallel_apply(replicas, inputs, kwargs, self.device_ids[:len(replicas)])
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 65, in parallel_apply
    raise output
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/parallel/parallel_apply.py", line 41, in _worker
    output = module(*input, **kwargs)
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in __call__
    result = self.forward(*input, **kwargs)
  File "/net/scratch/people/plgkwrobel/awd-lstm-lm/splitcross.py", line 115, in forward
    split_targets, split_hiddens = self.split_on_targets(hiddens, targets)
  File "/net/scratch/people/plgkwrobel/awd-lstm-lm/splitcross.py", line 103, in split_on_targets
    split_hiddens.append(hiddens.masked_select(tmp_mask.unsqueeze(1).expand_as(hiddens)).view(-1, hiddens.size(1)))
  File "/net/people/plgkwrobel/env-pytorch/lib/python3.6/site-packages/torch/tensor.py", line 302, in expand_as
    return self.expand(tensor.size())
RuntimeError: The expanded size of the tensor (280) must match the existing size (550) at non-singleton dimension 0

I am experiencing the same problem, @djstrong did you able to solve it?

Found the fix:

You need to add dim=1 in your nn.DataParallel constructor parameter as the data passed through your network will be in the form of [steps, batch_size, dims] already, DataParallel needs to know which dimension you want to split.
You need to move https://github.com/salesforce/awd-lstm-lm/blob/32fcb42562aeb5c7e6c9dec3f2a3baaaf68a5cb5/model.py#L93 out, since nn.DataParallel will use the modified dim parameters to merge the final result. That line will flatten the tensor from [steps, batch, dims] into [steps * batch, dims], if you define dim=1, instead of merging the result in dim steps * batch, it will merge the result with dims dimension.

Let me know if it doesn't work for you!


Add Jalpaiguri Government Engineering College

@somnathrakshit Please rename lib/domains/ac/in/jgec.txt to lib/domains/in/ac/jgec.txt

@philipto Please see PR #6135

@somnathrakshit Thank you! I am closing this request as a duplicate to #6135


Added some explanation to Excel Row 1 - 3 for better understanding

creating a new PR instead with discussed changes


Can not bundle internal package.json that has relative main like a redux-saga

For example, this is node_modules/redux-saga/effects/package.json
{
  "name": "redux-saga/effects",
  "private": true,
  "main": "../lib/effects.js",
  "module": "../es/effects.js",
  "jsnext:main": "../es/effects.js"
}

next code passes but has no reference.
// source
import effects from 'redux/effects'

// compiled
var _effects = require('redux-saga/effects'); //=> undefined

hi @mizchi we are not covering package.json in sub folders just yet, that's quite a heavy procedure. You can solve it using aliases for now.

@nchanged OK, thx. I solved by replacing to redux-saga/lib/effects

I will close this for now, as there are many related issues.

I ran into this problem earlier today using TypeScript. The typings will not resolve properly for redux-saga/lib/effects so you have to add the following to the FuseBox configuration:
// ...
  alias: {
    'redux-saga/effects': 'redux-saga/lib/effects',
  },
// ...

Then you can use redux-saga/effects directly and typings will work.


added tiled template object support

I added support for object template as requested here #5102
I tested my implementation here:
https://github.com/OliPerraul/libgdx-test/tree/object-template-test

Hey guys, so I've been looking through some of the tiled PRs that are stacking up to see if I can help at all.
Since this is the oldest. I thought I'd start here.
Not sure what the protocol is in this case, but since this PR was originally submitted over 4 years ago there have been a lot of changes to the BaseTmxMapLoader class. Specifically related to how we handle properties. And trying to merge this locally was kind of a nightmare.
So instead, I just started from scratch from the current master. And I have a basic implementation which would only add  2 methods and a single IF statement in the loadObjectGroup() Method.
Not to diminish any of the work that was done here. It's just severely out of date by now and would probably take more time to integrate with all the current changes.
I don't know if @perrauo has any interest in continuing this.
I could simply provide the code here if he would like. Or I could just open a new PR. I'm all ears.


Can't parse type defined inside unnamed constant

For proc-macros is quite common to put the generated code inside unnamed constants, to not pollute the surrounding namespace. However the name of types defined inside such constants cannot be parsed by syn::Type:
use std::any::type_name;
use syn::Type;

trait A {
    type T;
}

struct Foo;

const _: () = {
    struct Bar;

    impl A for Foo {
        type T = Bar;
    }
};

fn main() {
    syn::parse_str::<Type>(type_name::<<Foo as A>::T>()).unwrap();
}

This panics with
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("expected identifier")', src/main.rs:6:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The value of type_name::<<Foo as A>::T>() is foo::_::Bar (where foo is the crate), so maybe syn doesn't support ::_::. I hadn't seen that before myself either 😅

This is behaving correctly as far as I can tell.


Minor fixes to notes on Getting Started and NodePool Upgrades pages

What this PR does / why we need it:
Fixes a minor doc issue on Getting Started page and updates a note to an Important block on the NodePool Upgrades page.
Which issue(s) this PR fixes:
N/A
Checklist

[x] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[x] This change includes docs.
[ ] This change includes unit tests.

thanks!
/approve


Remove chapters string from keysMeta urls

Currently the keysMeta uses the full url but throughout the codebase we split up the url into routes.chapters + lessonKey
Reason for change: if in the future we decide to place keys outside of the standard ch1-10 story with sidequests or other utility functions e.g. a general purpose transaction parsing tool like https://siminchen.github.io/bitcoinIDE/build/editor.html I think this Might live outside of the standard chapters/chapterSlug/lessonKey route additionally this simply keeps consistency with the rest of our current codebase involving urls

@benalleng
I would like to take a look at this issue.

#495 addresses this issue


Add WhoCanShare AllowLists to SetSPOTenant.md

@microsoft-github-policy-service agree [company="Microsoft"]

@microsoft-github-policy-service agree company="Microsoft"

Upgrade-SPOSite

could you help remove this one? We don't really use this cmdlet anymore.
Instead, add the Get-SPOSite documentation link here

Refers to: sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md:3587 in e056025. [](commit_id = e056025afc05a940a4fda6e6a7cc3e67d5d13541, deletion_comment = False)


Add manifest-prod.yml for prod stage.

The application name is nyu-promotion-service-s18-prod.
The production service is accessible at https://nyu-promotion-service-s18-prod.mybluemix.net.
The database is named ClearDB-prod. No test case should run against it.

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   93.91%   93.91%
=======================================
  Files           4        4
  Lines         230      230
=======================================
  Hits          216      216
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1e125...09a080e. Read the comment docs.


License or Permit number search not working

The new UI advertises you can search by permit number.  This is not working.

Using the permit number from here; https://test.orgbook.gov.bc.ca/en/organization/registration.registries.ca/BC0091892/cred/3580366
The new UI turns up zero results; https://frontend-v2-test.apps.silver.devops.gov.bc.ca/search?q=M-238&category%3Aentity_type=&credential_type_id=&inactive=&page=1

@amanji -- for now, "fix" this by removing "License or Permit" number, and then assign this to @wadeking98 for when he returns.  If this has not yet been designed, we'll likely need a meeting and a plan to figure out how to get this added to the searching.  Should be configurable, and perhaps it would be taken care of by an update to the other issuers (Hmmm...as I write this, I suspect this is the case...).

Similarly, and expectedly based on the comment from @swcurran, License number search does not work either.
Taking the license number from here; https://test.orgbook.gov.bc.ca/en/organization/registration.registries.ca/BC0803848/cred/3580890
The new UI produces zero results; https://frontend-v2-test.apps.silver.devops.gov.bc.ca/search?q=18C-0039&category%3Aentity_type=&credential_type_id=&inactive=&page=1

This is not yet a feature that's been implemented. So I'll remove the label for now but we will need to design this.

Reopening the issue so we don't loos it.  The mitigation of removing the labeling has been fixed in test.

Closing this issue as resolved and opening a new issue to enable the feature.


More visibility for DLQ reasons

Column "Dead Letter Reason" should be more prominently displayed and visible in the details dialog too.
As a matter of fact, content should be the last column visible in both view

Fixed with 0b2b86b84fe22abaf064fd6ccb6d7f531671a809 and 80ec28332b5fe797a3a7fa2497d1e49e4b27f858


Ansible request for linux_installer role

Please put the name of the software product (and affected platforms if relevant) in the title of this issue

[ ] Missing install
[ ] Bug in ansible playbook
[x] Request for new playbook addition

Details: Currently the linux_installer role as called from linux_installer_setup.yml. For this to work in practice it is necessary for an .rpmmacros file to be available to jenkins as per the end of this section of the docs, and for .gnupg to be populated.
Since the output of the playbook will not be usable without this file, we should add a final step that checks for the presence of it and if not, prints out a warning to the user to notify them that the extra step is required.

Needs validated in light of the linuxNew work. I suspect this has all been superceded. Bumping into June in order to drive a conclusion.

For those watching, linuxNew has been renamed to linux


feat(controller): make SSO session expiry configurable

Signed-off-by: Arghya Sadhu<EMAIL_ADDRESS>Checklist:

[ ] My organization is added to USERS.md.

Fixes #3873

Needs backporting to v2.12


How could I handle the node delete option?

How could I handle the node delete option? is there any event?

You can register the onChanged callback.
Doing so you receive a event of the type 'NodeRemoved'.
See here:
https://github.com/lochbrunner/react-flow-editor/blob/master/example/simple/simple.tsx#L102


Update records base lib

Coverage decreased (-3.06%) to 76.648% when pulling 0c9b558fca92991a8115119f2ecbf8d5bee1fb08 on add-sqlite into fd6347959c772905008bac09baea9d97ccfc9514 on master.

Coverage decreased (-3.06%) to 76.648% when pulling 0c9b558fca92991a8115119f2ecbf8d5bee1fb08 on add-sqlite into fd6347959c772905008bac09baea9d97ccfc9514 on master.


0x80190194 : unknown error

Brief description of your issue
PS C:\Windows\System32> winget install sumo
Multiple packages found matching input criteria. Please refine the input.
Name              Id                     Source
SUMO              EclipseFoundation.SUMO winget
KC Softwares SUMo KCSoftwares.SUMo       winget
PS C:\Windows\System32> winget install kcsoftwares.sumo
An unexpected error occurred while executing the command:
0x80190194 : unknown error
Steps to reproduce
Completely reproducible
Expected behavior
It should install the package or declare that latest available the version of the package is installed
Actual behavior
Error
Environment
PS C:\Windows\System32> winget --info
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.2215
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Can you please include the log files from winget install kcsoftwares.sumo --verbose ?

Hi
Log file attached as requested.
Thanks
Colin

Colin Knowles
Mobile: 0044<PHONE_NUMBER>
@.***
https://www.facebook.com/ColinRKnowles
On Mon, 28 Aug 2023 at 14:21, Kaleb Luedtke @.***>
wrote:

Can you please include the log files from winget install kcsoftwares.sumo
--verbose ?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/winget-cli/issues/3563#issuecomment-1695691179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCF6YAJMB4LAOOUJXTH3RSLXXSLNPANCNFSM6AAAAAA4BAEW54
.
You are receiving this because you authored the thread.Message ID:
@.***>

@eccrk it looks like you responded to the issue via e-mail. The files don't get attached unless you update at the GitHub issue.

Sorry I wasn't aware of that.
Please find attached.
WinGetCOM-2023-08-25-16-07-50.973.log

Was Sumo already installed on the system when the command was run?
From the log the "settings" file seemed to be invalid.
Can you share your settings? Run winget settings to open the settings.json file.
Can you share the list of pins? Run winget pin list to see if any are configured.

settings.json reads:
{
"$schema": "https://aka.ms/winget-settings.schema.json",
// For documentation on these settings, see: https://aka.ms/winget-settings
// "source": {
//    "autoUpdateIntervalInMinutes": 5
// },

}
the output from winget pin list is:
There are no pins configured.


Add provider equinix and module_name in Equinix Metal TF configs

@vasubabu It looks like example/main.tf is using the published version of this module, not using the local copy.  I think if you update the source for the module in that file, it will fix the failing CI job


where can i find the pretrained models?

hi nice work!
I am wondering where can i got the pretrained models you mentioned? i only find the raw data link for pretrain on readme.
thanks!
jackie

The pretrained models are in the Evaluation part. Below that we give all our model parameters. See https://github.com/Tribleave/SCAPT-ABSA#evaluation.


Vulnerability roundup 101: nanopb-0.4.4: 1 advisory [7.1]

search, files

[ ] CVE-2021-21401 CVSSv3=7.1 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: c7e905b6a97; nixos-unstable: f5e8bdd07d1.
Cc @kalbasit

Fixed by #119951 and #119965


No handlers could be found for logger "ari.client"

1.I have using ari-py lib. for making call application in asterisk.
I that i use bridge-dial.py filefrom example folder in Ari-py lib. for playing IVR in asterisk but got this kind of error  "No handlers could be found for logger "ari.client" " show on terminal.
how to solve this??
2.And another thing i want to know how to get header details in statis python-ari application.
Is there any method or api for that??

Hi @badrik91 , Have u gained any luck with that? I am circling around the same problem.


It is suggested that change the regular expression into readable message when configure containers.

In GitLab by @luotian-github on Sep 25, 2018, 20:27
The project doesn't exist in front-end, but I couldn't create a project which has been created in the last version of board.

In GitLab by @luotian-github on Nov 8, 2019, 07:59
And I suggest that the initial container name should be a right name.

In GitLab by @luotian-github on Nov 8, 2019, 07:59
will look at it

In GitLab by @liyanq528 on Nov 8, 2019, 07:59
error message duplicate #982; fixed #1725

In GitLab by @luotian-github on Nov 8, 2019, 07:59
Please change the regular expression to readable message.

In GitLab by @luotian-github on Nov 8, 2019, 07:59
Configure container has the same problem

In GitLab by @liyanq528 on Nov 8, 2019, 07:59
The error message fixed in v2.0beta;

In GitLab by @liyanq528 on Nov 8, 2019, 07:59
fixed by pr 1862

In GitLab by @sokril on Nov 8, 2019, 08:27
closed

In GitLab by @sokril on Nov 8, 2019, 08:27
assigned to @luotian-github

In GitLab by @liyanq528 on Nov 12, 2019, 03:04
mentioned in merge request !1155

In GitLab by @liyanq528 on Nov 13, 2019, 05:07
mentioned in merge request !911

In GitLab by @liyanq528 on Nov 13, 2019, 05:14
mentioned in merge request !1010

In GitLab by @liyanq528 on Nov 13, 2019, 08:01
mentioned in merge request !775

In GitLab by @liyanq528 on Nov 13, 2019, 09:34
mentioned in merge request !1418


Using OpenEBS on Azure Kubernetes Cluster

BUG/QUERY
What happened:
I was trying out the sample postgres use case as given in https://docs.openebs.io/docs/CrunchyPostgres.html
I created a three node Kubernetes cluster in AZURE of Standard_A0 type. At this point this is the sc output
kubectl get sc
NAME                 PROVISIONER                    AGE
default (default)    kubernetes.io/azure-disk       59m
managed-premium      kubernetes.io/azure-disk       59m
I used the openebs operator and storageclass yaml and then the postgress cluster yaml files to created the storage class and Statefulset upon which I see that one of the pod is not completely up. I believe the error points to the volume, I would appreciate any pointers.
kubectl get pods
NAME                                                            READY     STATUS              RESTARTS   AGE
maya-apiserver-7b8f548dd8-67s6x                                 1/1       Running             0          36m
openebs-provisioner-7958c6d44f-g9qvr                            1/1       Running             0          36m
pgset-0                                                         0/1       ContainerCreating   0          32m
pvc-febcc15e-25d7-11e8-92c2-0a58ac1f1190-ctrl-7d7c98745-49qcm   2/2       Running             0          32m
pvc-febcc15e-25d7-11e8-92c2-0a58ac1f1190-rep-578b5bcc6b-5758m   1/1       Running             0          32m
pvc-febcc15e-25d7-11e8-92c2-0a58ac1f1190-rep-578b5bcc6b-zkhn8   1/1       Running             0          32m
Below are excerpts from kubectl describe pod pgset-0
Volumes:
pgdata:
Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
ClaimName:  pgdata-pgset-0
ReadOnly:   false
default-token-cgpxf:
Type:        Secret (a volume populated by a Secret)
SecretName:  default-token-cgpxf
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     node.alpha.kubernetes.io/notReady:NoExecute for 300s
node.alpha.kubernetes.io/unreachable:NoExecute for 300s
Events:
Type     Reason                 Age                 From                               Message

Warning  FailedScheduling       25m (x3 over 25m)   default-scheduler                  PersistentVolumeClaim is not bound: "pgdata-pgset-0" (repeated 3 times)
Normal   Scheduled              25m                 default-scheduler                  Successfully assigned pgset-0 to aks-nodepool1-18777710-1
Normal   SuccessfulMountVolume  25m                 kubelet, aks-nodepool1-18777710-1  MountVolume.SetUp succeeded for volume "default-token-cgpxf"
Warning  FailedMount            43s (x11 over 23m)  kubelet, aks-nodepool1-18777710-1  Unable to mount volumes for pod "pgset-0_default(febd7e43-25d7-11e8-92c2-0a58ac1f1190)": timeout expired waiting for volumes to attach/mount for pod "default"/"pgset-0". list of unattached/unmounted volumes=[pgdata]
Warning  FailedSync             43s (x11 over 23m)  kubelet, aks-nodepool1-18777710-1  Error syncing pod
What you expected to happen:
pgset-0 pod to be running and all the pvc and pv to be available
How to reproduce it (as minimally and precisely as possible):
Create the azure resource group and kubernetes cluster
az group create --name JayPgResourceGroup --location canadacentral
az provider register -n Microsoft.ContainerService
az provider register -n Microsoft.Compute
az provider register -n Microsoft.Network
az aks create --resource-group JayPgResourceGroup --name JayPgDbReplicaSet --node-count 3 --kubernetes-version  1.8.7 --node-vm-size Standard_A0 --generate-ssh-keys
Create the openebs storage classes
kubectl create -f https://raw.githubusercontent.com/openebs/openebs/master/k8s/openebs-operator.yaml
kubectl create -f https://raw.githubusercontent.com/openebs/openebs/master/k8s/openebs-storageclasses.yaml
Create the crunchy data postgres as explained in https://docs.openebs.io/docs/CrunchyPostgres.html
Anything else we need to know?:
I am running on Ubuntu 16.04.3 LTS. From what I see looks like the iscsi service is running fine. Attaching the config for your perusal
sudo cat /etc/iscsi/initiatorname.iscsi (from each of the nodes)
InitiatorName=iqn.1993-08.org.debian:01:79c32a3367ac
InitiatorName=iqn.1993-08.org.debian:01:3a67dbe34663
InitiatorName=iqn.1993-08.org.debian:01:f7c3c1279dc3
Environment:

kubectl get nodes
NAME                       STATUS    ROLES     AGE       VERSION
aks-nodepool1-18777710-0   Ready     agent     2h        v1.8.7
aks-nodepool1-18777710-1   Ready     agent     2h        v1.8.7
aks-nodepool1-18777710-2   Ready     agent     2h        v1.8.7

kubectl get pods --all-namespaces
NAMESPACE     NAME                                                             READY     STATUS              RESTARTS   AGE
default       maya-apiserver-7b8f548dd8-q6kqb                                  1/1       Running             0          2h
default       openebs-provisioner-7958c6d44f-2h9t6                             1/1       Running             0          2h
default       pgset-0                                                          0/1       ContainerCreating   0          2h
default       pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3-ctrl-6f4f6d6d7f-jzxqk   2/2       Running             0          2h
default       pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3-rep-7989bbd946-cswxf    1/1       Running             0          2h
default       pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3-rep-7989bbd946-np5xl    1/1       Running             0          2h
kube-system   heapster-669488959c-bnpst                                        2/2       Running             0          2h
kube-system   kube-dns-v20-5bf84586f4-hq7tz                                    3/3       Running             0          2h
kube-system   kube-dns-v20-5bf84586f4-nxcg6                                    3/3       Running             0          2h
kube-system   kube-proxy-cffj6                                                 1/1       Running             0          2h
kube-system   kube-proxy-h6tn5                                                 1/1       Running             0          2h
kube-system   kube-proxy-js5xt                                                 1/1       Running             0          2h
kube-system   kube-svc-redirect-7w5jw                                          1/1       Running             0          2h
kube-system   kube-svc-redirect-tzs5d                                          1/1       Running             0          2h
kube-system   kube-svc-redirect-zdbhw                                          1/1       Running             0          2h
kube-system   kubernetes-dashboard-69bb965b88-hkmrk                            1/1       Running             0          2h
kube-system   tunnelfront-696789ffb-df2bh                                      1/1       Running             0          2h

kubectl get services
NAME                                                TYPE        CLUSTER-IP    EXTERNAL-IP   PORT(S)             AGE
kubernetes                                          ClusterIP   <IP_ADDRESS>              443/TCP             2h
maya-apiserver-service                              ClusterIP   <IP_ADDRESS>           5656/TCP            2h
pgset                                               ClusterIP   None                  5432/TCP            2h
pgset-primary                                       ClusterIP   <IP_ADDRESS>           5432/TCP            2h
pgset-replica                                       ClusterIP   <IP_ADDRESS>           5432/TCP            2h
pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3-ctrl-svc   ClusterIP   <IP_ADDRESS>           3260/TCP,9501/TCP   2h

kubectl get sc
NAME                 PROVISIONER                    AGE
default (default)    kubernetes.io/azure-disk       2h
managed-premium      kubernetes.io/azure-disk       2h
openebs-cassandra    openebs.io/provisioner-iscsi   2h
openebs-es-data-sc   openebs.io/provisioner-iscsi   2h
openebs-jupyter      openebs.io/provisioner-iscsi   2h
openebs-kafka        openebs.io/provisioner-iscsi   2h
openebs-mongodb      openebs.io/provisioner-iscsi   2h
openebs-percona      openebs.io/provisioner-iscsi   2h
openebs-redis        openebs.io/provisioner-iscsi   2h
openebs-standalone   openebs.io/provisioner-iscsi   2h
openebs-standard     openebs.io/provisioner-iscsi   2h
openebs-zk           openebs.io/provisioner-iscsi   2h

kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS    CLAIM                    STORAGECLASS       REASON    AGE
pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3   400M       RWO            Delete           Bound     default/pgdata-pgset-0   openebs-standard             2h

kubectl get pvc
NAME             STATUS    VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS       AGE
pgdata-pgset-0   Bound     pvc-a980c1e4-2674-11e8-a384-0a58ac1f03e3   400M       RWO            openebs-standard   2h

OS (e.g. from /etc/os-release):
cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

Kernel (e.g. uname -a):
Linux aks-nodepool1-18777710-2 4.13.0-1007-azure #9-Ubuntu SMP Thu Jan 25 10:47:32 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Need to find a way to automate installing the iscsi initiator on the kubelet container. The following steps were followed to manually install:

SSH into the Kubernetes Nodes
Identify the docker container running the kubelet using sudo docker ps.
Enter the kubelet container shellsudo docker exec -it kubelet_container_id bash

Install open-iscsi.apt-get update
apt install -y open-iscsi```

@kmova @yudaykiran Just thinking aloud here.
1/ Can we patch the kubelet pod with some kubelet image that has all these?
The patch operator will do the justice of finding the exact kubelet image & replace that with iscsi-kubelet image.
2/ Can we check if pod probes can do the apt-get install stuff
All these to avoid plumbing code around ssh & thinking from docker perspective.

@AmitKumarDas kubelet is not deployed as a pod, rather, the kubelet service is run inside a hyperkube container. i don't think this can be fixed from the Kubernetes end. It is more of a cloud-init that brings the VM and has some configuration for running the kubelet service inside this container. This is similar to how coreos runs all its services inside containers.

@yudaykiran These are more unknowns. I dont understand these ;) ... Hopefully you will explain each of them in some forms... BTW Is hyperkube same as virtual kubelet that azure guys are involved into?

@AmitKumarDas hyperkube and virtual kubelet are two different concepts.

Solution guide to setup OpenEBS in Azure : https://github.com/openebs/openebs-docs/blob/master/docs/openebs_azure.md

(just passing by)
To elaborate on @yudaykiran's comment. hyperkube and virtual kubelet are two different things.

hyperkube is the all-encompassing container that includes all of the k8s system services (kube-apiserver, kube-proxy, etc.) ref: https://github.com/kubernetes/kubernetes/tree/master/cluster/images/hyperkube
virtual kubelet let's you use different runtimes (Azure Container Instances, AWS, Hyper.sh) to masquerade as a node. So instead of having your pod running on an actual server host, you can run it on one of the supported runtimes. A use case of this would be for instance handling burst traffic, instead of waiting for a new VM to spin up, you can quickly scale-out your pods and run them on ACI.

The kubernetes clusters being provisioned in AKS are now running the kubelet as a service by default. OpenEBS will get deployed without any issues w.r.t ISCSI connections. Hence closing this issue.

2 years later, the docs still describe the "old" (kubelet container, no iscsi) situation...

Hi @howardjones, could you help me with docs that have outdated information and I will get them fixed.
Thank you for taking time to shout out though!

Sure, the prerequisites page for AKS, here: https://docs.openebs.io/docs/next/prerequisites.html#aks
describes the situation that @yudaykiran above notes is no longer the case.
I just did my first install yesterday and found the same thing
(I also can't figure out how openebs would ever find storage in AKS, but that's a different question!)


Use OCSP-specific error codes for clarity

Fixes #12735

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I do not think renaming the other error is needed. By invalid status response is meant invalid ocsp status response. Perhaps just changing the text of the error would be appropriate if you think the message needs clarification.

The error text is automatically created from the error name, isn't it?

Initially, yes. But then the text is kept if you edit it.

I think it's a bit misleading.
BTW, no problem to remove this part of a patch.

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

Removed the unnecessary error code rename

This pull request is ready to merge

Merged to master. Will raise a separate PR for 1.1.1.


Update to support Minecraft 1.20.4 Fabric

Please update to support Minecraft 1.20.4 Fabric. Thanks!

Update: WTHIT just updated to the latest versions, if you have time i would gladly appreciate if you could check the compatibility @shedaniel


Add support for request with PATCH method

Doneness:

[x] No Bugs - I made sure that this change is working properly as expected. It does'nt have any bugs that you are aware of.
[x] Build is okay - I made sure that this change is building successfully.
[x] Branching - If this is not a hotfix, I am making this request against release branch (aka beta branch)

Add support for request with PATCH method - treat it similar to POST and PUT method. PATCH method is similar to PUT method, but semantically it is different as it allows update on part of the item. In my enterprise setting use case, we do have quite a number of Web API with PATCH method.
FYI. Note that, all unit test passed, except the unit test re Certificate (as it is already failed before this changes).

Thank you.


LocalProcessSpawner cannot be used

Thanks for developing this package, it is a good-designed spawner for HPC and Jupyterhub.
I am wondering if jupyterhub_moss can allocate the local machine, for example the wrapsapwner.ProfilesSpawner can use jupyterhub.spawner.LocalProcessSpawner. Is there any way in jupyterhub_moss?

Hi,
We've made jupyterhub_moss for working with the SLURM batchspawner.
It should be possible to make it work with other schedulers supported by batchspawner, but not with others.

Hi,
We've made jupyterhub_moss for working with the SLURM batchspawner.
It should be possible to make it work with other schedulers supported by batchspawner, but not with others.

Thanks, I have solved the problem by installing the batchspawner, but I forgot to close this issue. :)


Splash damage doesn't trigger onHit effects

As an example: Hacking popups don't appear on explosion damage from cannon barrel

@Fueredoriku this ties into a major issue: We currently don't differentiate between on-hit effects that should and should not spread. Spawning hats and explosions are examples of non-spreading effects, while fire and hacking should spread through those effects.


Include Comet Data inside ReviewTask page : List of Requirements

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of the UI-DSM
[x] I have searched open and closed issues to ensure it has not already been reported

Description

The ReviewTask page should be able to list all Requirements if the related view needs it
Steps to Reproduce

System Configuration

UI-DSM version:

[ ] UI-DSM:
[ ] Other:

Environment (Operating system, version and so on):
.NET Framework version:
Additional information:

Replaced by #97


Fix: System redirects user to ‘Contact methods’ section when the user enters a wrong ‘Magic code’

Details
Navigate the user to the contact methods page when any contact details magic code gets verified successfully.
Fixed Issues

$ https://github.com/Expensify/App/issues/17398
PROPOSAL: https://github.com/Expensify/App/issues/17398#issuecomment-1507347216
Tests

Open Profile from Settings
Select contact method item
Click on any contact method for which verification is yet to complete
In the verification screen enter invalid magic code
Verify that the user remains on same screen and does not navigate to the contact methods page

[X] Verify that no errors appear in the JS console

Offline tests

Open Profile from Settings
Select contact method item
Click on any contact method for which verification is yet to complete
In the verification screen enter invalid magic code
Verify that the user remains on same screen and does not navigate to the contact methods page

QA Steps

Open Profile from Settings
Select contact method item
Click on any contact method for which verification is yet to complete
In the verification screen enter invalid magic code
Verify that the user remains on same screen and does not navigate to the contact methods page

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/14358475/233157907-78954c35-5909-4aab-8050-cea6bb2c010d.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://user-images.githubusercontent.com/14358475/233167145-9c27d5ab-32b5-47ea-bd0e-3e8876c5527e.mov

iOS
https://user-images.githubusercontent.com/14358475/233162975-05a055e0-c024-407d-8ada-e4cdac412c80.mp4

Android

@puneetlath @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mollfpr can you take the first round of review please? Thanks!

@puneetlath Yes! I’ll start it this morning.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/25520267/233701077-afd1c263-6675-4d25-98c3-48b39bc50c1e.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/25520267/233701087-dea7a6ee-c3a2-4094-baef-1ef2d561c073.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/25520267/233701100-6822a508-2148-41f2-ad8b-7f8ebd5d6115.mp4

Desktop

https://user-images.githubusercontent.com/25520267/233701108-03f92a65-1d32-4c13-bd31-01982ef7ade2.mov

iOS

https://user-images.githubusercontent.com/25520267/233701119-1f30d4fa-be84-4292-b017-c2de0c37f589.mp4

Android

https://user-images.githubusercontent.com/25520267/233701139-ce104eac-74f4-4994-b62e-50751aef31bb.mov

I just want to double-check @mollfpr. Is this ready for me to review?

@puneetlath Yes! Sorry, didn’t mention you before.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.6-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.6-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Custom Notification Channel problem

Larastan Version: 0.4.0

Description
I get this error:

Call to an undefined method Illuminate\Notifications\Notification::toApns().

when using custom Notification Channel (https://laravel.com/docs/5.8/notifications#custom-channels). I guess because type-hinting of method signature reference an abstract Notification class that does not have custom toChannel method.
Laravel code where the issue was found
    public function send($notifiable, Notification $notification)
    {
        $notification->toChannel($notifiable, $notification);
    }

I have the same problem. I'm thinking now that custom notification channels should have an interface from the channel package attached to the Notification themselves. But this is not feasible for third party packages.

You will need to use phpdocs hint the $notification variable.

You will need to use phpdocs hint the $notification variable.

I am facing the same issue, can you provide an example? What do you exactly mean by hinting the notification variable? isn't it hinted already in Notification $notification

/** @var your-type $notification */

/** @var \your-concrete-notification $notification */

Oh, I was hoping for a fix with the preexisting notification class.

You can create an interface with the method in question, and type hint when needed. Example given below:
namespace App\Notifications;

use App\Messages\SmsMessage;

interface SmsableNotification
{
    public function toSms(object $notifiable): SmsMessage;
}

class InvoicePaid extends Notification implements SmsableNotification
{
    // ...

    public function toSms(object $notifiable): SmsMessage
    {
        return new class {
            private $content = 'This is a test';

            public function getContent(): string
            {
                return $this->content;
            }
        };
    }

    // ...
}

class SmsChannel
{
    public function send(object $notifiable, SmsableNotification $notification): void
    {
        $sms = $notification->toSms($notifiable);
        // Send the SMS notification
    }
}


Method "extension" provides incorrect information for uploaded HTML file on Chrome

Laravel Version: 5.3.31
PHP Version: 7.0.16 (cli)
Database Driver & Version: N/A

Description:
Client OS: Windows 10
Client Browser: Chrome 59.0.3071.115 (Official Build) (64-bit)
Obtaining a file from an upload HTML form.
Method "extension" provides incorrect information
This functionality works correctly on Ubuntu (Chrome and Firefox)
Steps To Reproduce:
// retrieve uploaded file
// $request is an instance of "Request"
$file = $request->file('document_file');
error_log("FILE = ".$file->getClientOriginalName());
error_log("document_file extension = ".$request->file('document_file')->extension());
// apache log
[Fri Jul 21 17:34:49.544657 2017] [:error] [pid 14178] [client ] FILE = test.html
[Fri Jul 21 17:34:49.546536 2017] [:error] [pid 14178] [client ] document_file extension = txt

@raffLHS

Method "extension" provides incorrect information
And what is that ?

Apache log belongs to which platform ?

@raffLHS The extension() method in Illuminate\Http\FileHelpers which refers to guessExtension in a Symfony component Symfony\Component\HttpFoundation\File
What it does is that it tries to guess the file extension based on file mimetype. This is to cover scenarios when the uploaded file may not have the "correct" extension and you may want to store it with the one that corresponds to the mimetype.
Now I have not checked into this thoroughly, but assuming it behaves similarly to file on linux, it will recognize both, a normal text file and an html file, as an 'ASCII texttype and hence suggest thetxtextension. (note that the recognition is actuallyHTML document, ASCII text`, but it probably just cares about the last part)
If you want to keep the extension of the uploaded file, you can just parse it from the filename of the uploaded file (with a simple regex looking for the last . and taking the remaining text as extension, for eg).

What it does is that it tries to guess the file extension based on file mimetype. This is to cover scenarios when the uploaded file may not have the "correct" extension and you may want to store it with the one that corresponds to the mimetype.

This has been reported several times that it behaves differently on different environments, this is not a bug in the framework itself and for that reason I'm going to close this issue. Please search the issues history to find more information.


Preprocessor: support run for the default SAVE-developed test suites

We need to run our OWN test suites. In this case the developer of static analyzer need to provide us his BINARY and how to run it (configuration/save.properties) or a string for save execution.

different endpoint similar to /submitExecutionRequest
additional logic in preprocessor to store provided files in the same folder as cloned repo (part of SAVE repo? or some sort of SAVE-suites?)
support this on frontend, probably as part of #56


Statistics not properly updated if accessed before grounding

import clingo

ctl = clingo.Control([])
ctl.add("base",[],"""
a.
""")

#print(ctl.statistics)
ctl.ground([("base",[])])
ctl.solve()
print(ctl.statistics)

A large part of the statistics is missing in the second step if the first call is uncommented.

@BenKaufmann
If ClaspFacade::getStats() is used to access the statistics before solving, then the "lp" and "lpStep" entries do not appear in the statistics. I think the reason is that they are only initialized in the ClingoView constructor. When the lpStats are not yet available at this point, they won't appear later when the become available.
Any ideas here? Right now the only condition on getStats is !solving.

@BenKaufmann  The following patch seems to fix the problem. I just don't know if it is the best way to fix the issue. Also the corresponding code from the ClingoView constructor could be removed if this is done in update.
diff --git a/src/clasp_facade.cpp b/src/clasp_facade.cpp
index c99ed7d..c46bd6f 100644
--- a/src/clasp_facade.cpp
+++ b/src/clasp_facade.cpp
@@ -737,6 +737,11 @@ Potassco::AbstractStatistics::Key_t ClaspFacade::Statistics::ClingoView::user()
        return user_;
 }
 void ClaspFacade::Statistics::ClingoView::update(const ClaspFacade::Statistics& stats) {
+       const ClaspFacade& f = *stats.self_;
+       if (f.step_.lpStats() && !problem_.find("lp")) {
+               problem_.add("lp", StatisticObject::map(f.step_.lpStats()));
+               if (f.incremental()) { problem_.add("lpStep", StatisticObject::map(f.step_.lpStep())); }
+       }
        StatsCallbacks sources = stats.external();
        if (!Potassco::empty(sources)) {
                user_ = add(root(), "user_defined", Potassco::Statistics_t::Map);

@rkaminsk
ClaspFacade::getStats() was never meant to be called before having any meaningful statistics, i.e. before solving ended. Originally, the function had a stricter precondition, namley that the step was solved(). However, in an endeavour to support poorly written python scripts and to allow getting statistics of the previous step until the next step starts, I weakened the precondition. While I'm strongly against supporting the usage you propose, it seems that now that I messed up the precondition, I'm bound to support it :(
I'll fix this together with the external stats stuff.

Thanks. Alternatively, an exception that the statistics are not yet ready would have done the job too. Only the current behavior was puzzling. Anyway, with the current implementation we have to document less. ;)


Request for iOS support

Hello, I really enjoy using this project and find its features very useful. However, it currently only supports macOS, and I would like to use it on iOS platforms. Is it possible to consider adding support for iOS?

This discussion may be relevant https://github.com/openai/whisper/discussions/443
I do not see any easy way to make iOS version on the Buzz.


Document a PR to handle role and ARIA a11y tags

Digging through #409 I noticed that there are a lot of a11y tags floating around that might not be 100% accurate. For example, aria-expanded="false" is set in the HTML for toggles but is never flipped to true.
A PR addressing this issue should:

[ ] Audit the entire codebase for dynamic a11y tags that should be updated
[ ] Document the issues (or fix them!)
[ ] BONUS: Audit the codebase for other a11y/ARIA tags that could be improved

@metamoni, you have first dibs on this one if you'd like to help! No pressure if you don't have the appetite.

Awesome - thanks!

Thanks for documenting all of those issues this weekend! Are there any more that need to be addresses or can we close this issue for now?

I think there might be a few more SVGs that need to be hidden. Will let you know when we can close this

Sounds good – thanks!

We can close this for now, @joemasilotti. If I spot anything else, I'll open a new issue.

Sounds great - thanks for documenting all of these!


Code-only sample code doesn't build

Trying to follow instructions on https://stride3d.github.io/stride-community-toolkit/manual/code-only/create-project.html
Error from the Build log

MSB3073 The command ""C:\Users\xxx.nuget\packages\stride.core.assets.compilerapp\<IP_ADDRESS>2\buildTransitive..\lib\net8.0\Stride.Core.Assets.CompilerApp.exe"  --disable-auto-compile --project-configuration "Debug" --platform=Windows --project-configuration=Debug --compile-property:StrideGraphicsApi=Direct3D11 --output-path="D:\repos\xxx\src\Console\bin\Debug\net8.0\data" --build-path="D:\repos\xxx\src\Console\obj\stride\assetbuild\data" --package-file="D:\repos\xxx\src\Console\Console.csproj" --msbuild-uptodatecheck-filebase="D:\repos\xxx\src\Console\obj\Debug\net8.0\stride\assetcompiler-uptodatecheck"" exited with code 1.

at

C:\Users\xxx.nuget\packages\stride.core.assets.compilerapp\<IP_ADDRESS>2\buildTransitive\Stride.Core.Assets.CompilerApp.targets line 153

After running the failing underlying command in CLI, I get this error:

Error restoring NuGet packages!
Could not load file or assembly 'System.Security.Cryptography.Pkcs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

Repro:

Install Microsoft Visual C++ 2015-2022 Redistributable , .NET 8 SDK
Create new console app with .NET 8.0
Add package Stride.CommunityToolkit 1.0.0-preview.38
Replace Program.cs with provided sample code
Try to build

Let me check this..

I am going to do a few more tests, but it seems to be working for me on my VM. I am going to try a clean VM.
Could you try to delete your obj and bin folder, and build the project again?

Still same error. For repro, I've set up a tiny repo with exactly the steps from the doc (I've added a global.json to ensure same version of SDK and disable preview SDK).
https://github.com/CocoDico78/StrideCodeOnlyBuildIssue

I was able to replicate this issue on clean VM. There seems to be some hidden and deep depenceny on this package 'System.Security.Cryptography.Pkcs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
Weirdly, it works on my dev computer because of some unknown references. I will raise a ticket in Stride repo and will work on this to figure out where the reference is and update it.

I have some way around, till this is resolved.
Please follow these steps, which install/change references to the missing package:

Install Stride Installer (https://www.stride3d.net/download/)
Install the latest version of Stride from the installer
Click Start - This will trigger installing some other NuGet packages
You can close the Project selection Window
Delete obj/bin in your code only project
Build and run your code only project

References:
https://github.com/stride3d/stride/issues/2232

Thank you for confirmation. You can leave this issue with me and I will close it once I have a proper solution :)

The issue addressed in the description was resolved. I have to update all code-only examples, so they are using Stride.CommunityToolkit.Windows instead of Stride.CommunityToolkit.

The docs were just released and examples updated. The main example updated https://stride3d.github.io/stride-community-toolkit/manual/code-only/create-project.html
I am closing this as resolved.


Test Python ORM

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw5Jsp2TrY3it9Yr/recpEIm1evzDXQkzn
PM: @awoods187
Eng: @BramGruneir

Airtable record changed to "Add SQL Alchemy Test Suite to Nightly Tests". There won't be any docs work for the 19.1 release. We can open a separate issue if there are learnings to add to the docs.


HP-291: add test ids to HTML

Added to "data-test-id" -attributes to some components so testing is easier and tests more reliable even if components are moved in the DOM.

Oh, sorry! Didn't remember there were a previous commit with the removed stuff. Squashed the commits.


add example test script

Testing out genesis

Oops, meant to push this to my forked version of the repo. My bad.


[SMALLFIX] Update a new presentation slides in tachyon project

Add latest tachyon slides

Do you want to add it to the drop down as well?

+1 LGTM


"if data" issue

Hi!
Just to warn for an issue that happened to me, when using "if data" it was giving me an error because my data variable was a np.array. The issue was in line 140 of the pybasicbayes/pybasicbayes/distributions/multinomial.py file.
In my case, I corrected the issue in a simple way (probably not the best)":
before  ->   data = data if         data else [None]_len(weights)
after     ->   data = data if list(data) else [None]_len(weights)
If you could resolve this issue, it would be beneficial for the other users.
Best Regards,
jmgo

this does not work for me
File "/usr/local/lib/python2.7/site-packages/pybasicbayes/distributions/multinomial.py", line 144
    data= data if list(data) else [None]_len(weights)

Instead```
            data = data
            if data is None:
              data= [None]*len(weights)

I also tried:

`data = data if data is not None else [None]_len(weights)`

but I get the same syntax error


Opponent Health Always at 0%

As of today's update, all health bars show the right bar but not the right percent https://gyazo.com/82040cb074ef78a730b82c34b8c1a0d2
The bar sometimes doesn't disappear after a NPC dies either.

Issue should be fixed here: https://github.com/runelite/runelite/pull/2609


Additional Info/Icon in Card Header?

I'm new to this but react toolbox has been working great so thanks everybody around here.
I have a question as I'm using the Card component, most particularly with the Card Title component.  What is the proper way, if possible, to implement icon / status text on the top right corner of the card, similar to these examples from the spec?

Any thoughts?

I have exact same request!

Thetitle prop on CardTitle component accepts markup which will be rendered inside the H5 element. Specify something along the lines of

    Google

    <IconMenu>...</IconMenu>

You'll need to use CSS to get the alignment right, including specifying a width on the DIV containing the H5.


Sizing by Layer not image

Is there a way to size the slide by the layer size rather than the image size? I am using it twice on my site, the second time it is meant to be a content-only slider with no images. I cannot seem to get the slider to recognize the height of the layer, and hardcoding the height of the slider will cause usability issues.
Thanks!

Hi. Did you try to set autoHeight to true?


Raidboss: Add common replacement text for directions (and roles?)

Mentioned in #1821

Initial commit: add directions matching regex

Closes #1821

Korean east, south, ... it'll be okay to remove 쪽, it means -ward.
ex) 동쪽 is eastward. 동 is east but it's very unnatural in sentence, this is why translator or many example sentences don't use it alone. People understand its meaning. for reference, 東 is 동. Same as 東 is ひがし. (Korean always write in its pronounce.)

Thanks for explaining. I have fixed those words.

I have changed files with directions that I have added, but I don't know how to deal with the following error.
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale de: pre-translation collision on replaceText '2x Rook (E/W center)' for '\(E/W center\)' and '(?<= \(|\/)E(?=\)|\/)'
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale de: pre-translation collision on replaceText '2x Rook (E/W center)' for '(?<= \(|\/)E(?=\)|\/)' and '\(E/W center\)'
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale ja: pre-translation collision on replaceText '2x Rook (E/W center)' for '\(E/W center\)' and '(?<= \(|\/)E(?=\)|\/)'
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale ja: pre-translation collision on replaceText '2x Rook (E/W center)' for '(?<= \(|\/)E(?=\)|\/)' and '\(E/W center\)'
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale cn: pre-translation collision on replaceText '2x Rook (E/W center)' for '\(E/W center\)' and '(?<= \(|\/)E(?=\)|\/)'
/home/***/workspace/cactbot/ui/raidboss/data/02-arr/raid/t4.js:locale cn: pre-translation collision on replaceText '2x Rook (E/W center)' for '(?<= \(|\/)E(?=\)|\/)' and '\(E/W center\)'
The terminal process "/bin/bash '-c', 'python test/run_tests.py'" terminated with exit code: 1.

The related files are: https://github.com/quisquous/cactbot/blob/d36dd2b545f3e4e9ea87d5b4a001a0f8c0a420e2/ui/raidboss/data/02-arr/raid/t4.txt#L12
https://github.com/quisquous/cactbot/blob/d36dd2b545f3e4e9ea87d5b4a001a0f8c0a420e2/ui/raidboss/data/02-arr/raid/t4.js#L63-L172

The problem is that (?<= \(|\/)E(?=\)|\/) catches E in (E/W center).
but there's '\\(E/W center\\)': '(O/W mitte)', replacement. So, two collides.
You should change
'\\(E/W center\\)': '(O/W mitte)', to 'center': 'mitte',
but there's already replacement for '\\(center\\)', so just remove every '\\(E/W center\\)' replacements, then change '\\(center\\)' to center.
example
      'replaceText': {
        '\\(E/W center\\)': '(O/W mitte)',
        '\\(SE/NW\\)': '(SO/NW)',
        '\\(center\\)': '(mitte)',
        '\\(outside\\)': '(draußen)',
        'Bug': 'Wanze',
        'Dreadnaught': 'Brummonaut',
        'Emergency Override': 'Not-Übersteuerung',
        'Knight': 'Ritter',
        'Rook': 'Drehturm',
        'Soldier': 'Soldat',
      },

to
      'replaceText': {
        '\\(SE/NW\\)': '(SO/NW)',
        'center': 'mitte',
        '\\(outside\\)': '(draußen)',
        'Bug': 'Wanze',
        'Dreadnaught': 'Brummonaut',
        'Emergency Override': 'Not-Übersteuerung',
        'Knight': 'Ritter',
        'Rook': 'Drehturm',
        'Soldier': 'Soldat',
      },

Thank you! I have fixed it.

Thanks for this! This is great.


add jaredforth.com to webring

Description
Adds https://jaredforth.com/ (webring in footer)

Very nice :) I've seen your website before, perhaps on the lines forum?
Welcome to the webring!


'delegate', 'monitor', and 'uri' are auto-required on boot of MRI

Modify uri.rs in extn::stdlib to eval require 'uri' on package init.

Thanks for uncovering this @johnwahba.

$ ruby -e 'puts ''$''LOADED_FEATURES.sort'
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/delegate.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/monitor.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/basic_specification.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/bundler_version_finder.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/compatibility.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/core_ext/kernel_gem.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/core_ext/kernel_warn.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/defaults.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/dependency.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/deprecate.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/errors.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/exceptions.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/path_support.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/platform.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/requirement.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/specification.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/specification_policy.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/stub_specification.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/util.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/util/list.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/rubygems/version.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/common.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/file.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/ftp.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/generic.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/http.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/https.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/ldap.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/ldaps.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/mailto.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/rfc2396_parser.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/uri/rfc3986_parser.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/enc/encdb.bundle
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/enc/trans/transdb.bundle
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/rbconfig.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/2.6.0/x86_64-darwin18/stringio.bundle
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/core_ext/name_error.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/formatters/plain_formatter.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/jaro_winkler.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/levenshtein.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/key_error_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/method_name_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/name_error_checkers.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/name_error_checkers/class_name_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/spell_checkers/null_checker.rb
/usr/local/var/rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib/did_you_mean/version.rb
complex.so
enumerator.so
rational.so
thread.rb

thread already does something similar:
https://github.com/artichoke/artichoke/blob/189961ad97b9fbda1e3341fe0ede5495b2d26c2d/artichoke-backend/src/extn/core/thread.rs#L10-L13

FWIW,  monitor, and uri are only required by RubyGems.
And delegate by did_you_mean.
With --disable-rubygems, the list is much shorter:
$ ruby --disable-gems -e 'puts $"'
enumerator.so
thread.rb
rational.so
complex.so
/home/eregon/.rubies/ruby-2.6.2/lib/ruby/2.6.0/x86_64-linux/enc/encdb.so
/home/eregon/.rubies/ruby-2.6.2/lib/ruby/2.6.0/x86_64-linux/enc/trans/transdb.so

Thanks @eregon. Closing.


node-expat invalid ELF header

trying to deploy hubot-hipchat from an ec2 instance, but it keeps saying i've got an invalid ELF header.
i'm running npm install from the server, not my local machine before pushing it to the server. additionally, this is a new server so there are no other conflicting versions of nodejs.
anyone else have a similar issue?

rbergman was OK , it works for me ! Thanks

https://medium.com/@devontem/solved-invalid-elf-header-with-docker-and-bcrypt-444426d63605

@powdahound i got you
https://medium.com/@devontem/solved-invalid-elf-header-with-docker-and-bcrypt-444426d63605

As mentioned above npm rebuild worked for me

As mentioned above npm rebuild worked for me


Add metadata parameter to example in README

The metadata parameter was missing from the "Cross-Platform Advanced Usage" example in README.md

Perfect! Thanks. This will make it easier to see the actual usage.


refactor(parquet): Move arrow RleEncodingInternal to common

Follow-up PR: https://github.com/facebookincubator/velox/pull/11711
Summary:
Both Parquet reader and writer depend on RleEncodingInternal.
This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader.
No functional changes.
CC: @majetideepak @pedroerp

@wypb Let's also change the variable names to the Velox coding convention which uses camel case. Thanks.

Hi @majetideepak I have made changes according to the comments. Please help me take another look when you have time. Thank you!

Hi @majetideepak Thank you for your review. I have addressed all the comments.

@wypb CI is failing. Can you take a look?

@wypb Is the MacOS build failure related?

@majetideepak The error is Linking lib/libvelox.dylib. I’m not sure if it’s related to the current PR. I’m still looking into it.

I introduced #include <glog/logging.h> in the Encoding.cpp file to see if it works.

@majetideepak Yes, the BitStreamUtilsInternal.h and RleEncodingInternal.h files in this MR deleted some arrow headers (like logging.h and ubsan.h etc.), which caused the Encoding.cpp file to lack the glog/logging.h dependency, so an error was reported during compilation.


fix load parachain error question #359

Description
What is the purpose of the change?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Brief of your solution
Please describe your solution to solve the issue or feature request.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Codecov Report

Merging #367 (2d84a43) into master (fe456fd) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   45.38%   45.37%   -0.01%
==========================================
  Files         142      142
  Lines       12458    12460       +2
==========================================
  Hits         5654     5654
- Misses       5645     5647       +2
  Partials     1159     1159

Impacted Files
Coverage Δ

kernel/engines/xuperos/engine.go
39.58% <25.00%> (-0.56%)
:arrow_down:

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
48.82% <0.00%> (+0.93%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

关联一下相关 issue 吧。


Invalid url for tvEpisodeService.images

Executing the following code
let images = try await tmdb.tvShowEpisodes.images(forEpisode: 43, inSeason: 1, inTVShow: 37854)

results in the following value for images: TVShowEpisodeImageCollection(id: 1153014, stills: []). However, the correct result (as tested on https://developer.themoviedb.org/reference/tv-episode-images) should be:
{
  "id": 1153014,
  "stills": [
    {
      "aspect_ratio": 1.778,
      "height": 720,
      "iso_639_1": null,
      "file_path": "/bYgszCXq8oBIWCmq2kUg0xx3ob6.jpg",
      "vote_average": 5.312,
      "vote_count": 1,
      "width": 1280
    },
    {
      "aspect_ratio": 1.333,
      "height": 300,
      "iso_639_1": null,
      "file_path": "/hsNpOdjCr9OEDttxbzbMwvkCtcw.jpg",
      "vote_average": 5.172,
      "vote_count": 1,
      "width": 400
    },
    {
      "aspect_ratio": 1.778,
      "height": 675,
      "iso_639_1": null,
      "file_path": "/13v7WFhcpNxLvefU3eicgFrjVb2.jpg",
      "vote_average": 0,
      "vote_count": 0,
      "width": 1200
    }
  ]
}

I used the latest release version of the package (9.0.0).

I also tried this with the newest version (HEAD of main branch) and the result is the same.

The problem seems to be that the final URL looks like this:
https://api.themoviedb.org/3/tv/1429/season/1/episode/18/images?api_key=***&language=en
But it should look like:
https://api.themoviedb.org/3/tv/1429/season/1/episode/18/images?api_key=***

Thanks @dcamenisch 🙏🏻


Fix Issue 19283 - [std.mathspecial] documentation for normal distribution doesn't list parameters

The two functions use standard normal distribution, which implies that mean=0.0, stdev=1.0.
In the bugreport is stated, that reportee was not able to follow the implementation for the case z>=1. Me neither. But as the case z<1 is obviously the standard normal distribution it would be an error, if the case z>=1 would be some other distribution. I compared some computed values to the table given in the German Wikipedia and found no difference.

Auto-merge toggled on


Accessibility

https://www.dto.gov.au/standard/9-make-it-accessible/

I'm going to close this for now, as it's not specifically an issue. The accessibility side of things is also more specific to the theme that ends up being used (among templates that certain modules provide).


Implement cross-bispectrum

Currently, bispectrum-based metrics can only be calculated on a single channel.
Adding a cross-channel implementation would be valuable.

Hi,
I assume that this is the same as cross-location(or cross channel) CFC. Is this enhancement implemented?
If not, can someone please mention the steps to do cross channel cfc ?

Pactools implements 12 different CFC metrics, and the bispectrum is only one of them. For all the other ones, you can measure CFC using either the same channel for phase and amplitude, or two different channels (aka cross-channel CFC).
To measure cross-channel CFC, you need to give two signals to the fit method:
https://github.com/pactools/pactools/blob/f1ed7095e3dbd663001facaf5646c59c74aaec38/pactools/comodulogram.py#L173-L183


Fix #1005: Obey edit list in QuickTime Timecode track

Obey edit list in QuickTime timecode tracks. Fixes reporting for the sample file in:
https://sourceforge.net/p/mediainfo/bugs/1005/
Signed-off-by: Peter Chapman<EMAIL_ADDRESS>

Your patch does not handle time code tracks with non continuous time codes i.e. you add an offset based on time offset to the timecode of first frame without checking the timecode at this time offset.
Checking how we could handle such files, we need to check stts atom, find the corresponding chunk (instead of using the first chunk) and use this one instead of the first one, also adapt FirstEditOffset correspondingly. Would you be motivated for implementing it?
If not, I see that 99% of files have continuous time codes (a single time code value) and 99% of the remaining 1% of files have an offset of 0, so I guess it is not a big issue and for these files current behavior is already not correct so this is changing a bug with another bug for these files, I may accept the patch as is, just noticing that this is "only" a partial fix.

Hi Jerome, I see your point, thanks. However:

I don't have a test file with multiple timecode samples and a non-trivial edit list.
I think that a correct implementation would require me to spend some more time learning how MediaInfoLib's parsing process works.
At the moment I'm not going to develop the patch any further. I understand why you might not want a 'partial' fix so I'm happy whatever you decide.
Thanks.


St 650 remove new case pending review state

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Why next state page removed?

As part of ticket in remove stay journey, State selection page needs to be removed and next state will be Case Management instead of New Case Pending Review.

Why next state page removed?

The state machine was simplified so we only had one possible next state when removing a stay


Periodic disconnects

So, I've been using Discord.Net for a while now and I've been getting those disconnects all the time, but since the bot was reconnecting by itself I didn't really pay attention to it.
But since I decided to add audio capabilities to my bot, it turned out to be a huge problem.
I attached two log files, one shows periodic disconnects, and another shows what happens when I try to rejoin a voice channel after reconnecting. I am using a manually compiled git latest version of the Discord.Net library.
audio.txt
normal.txt

While this does not directly address your problem, it looks like you're using 0.9, which is quite outdated and uses a very old version of the gateway.
I would suggest (if possible) that you make a move over to 1.0 (available in the 'dev' branch).
(Also your name is a blast from the past from the Tmod days - you're the guy who got me writing C#, so thanks!)

Moving to 1.0 solved all the problems, thanks!
(Glad to hear that mate, good luck ;)

Good to see some fellow tmodders here ;O
anyway im having disconnect issues in 1.0 now, 1.0.0-rc-00621
bot disconnects and reconnects like 8 before it stops (at boot)

I also seem to be getting random disconnects and reconnects at the start from version 61-63 i will keep testing older versions to see if i dont get this

Okay more info version 617 seems to be the stablest version without the random disconnects version 618 and upwards has this issue @Jofairden

Nobody will really see this since the issue thread is closed. What I heard is that it's a Discord inconsistency.

Yea i think discord has changed something backend and its messing with the library.

Reconnects happen often, either on your end or (more often) Cloudflare's. What matters is that the connection successfully resumes. If it does, all missed data will be replayed by the Discord server.


Unusual jar naming strategy

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
The naming of the Pulsar jars is a bit unusual. If the project provides shaded JARs, they are named *-shaded.jar, and the original JAR is left as is. Most of the time, projects will include the non-shaded jar since it is not desired to duplicate another 20MB of dependencies. There are exceptions when there are version conflicts, and that's when you include the shared jar.
Solution
Add a classifier (shaded) and leave the original file name as is.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Is it a big deal about the name? Every project can has its own preference and if only it doesn't become a trouble for some integrations, it looks neutral to me to use pulsar-client as the shaded version and pulsar-client-original as the slim version.
If we just change pulsar-client to the slim version, it will shock users who already use it as a shaded version. This is a user-facing interface change, but I don't see some reasonable advantages to doing so.

I would not say it is a big deal ... it's just unusual. Honestly, I used hundreds of libraries, and none of them have this file name policy in reverse. The shaded JAR has a different name, and the original JAR is based on the artifact identifier.

I agree it's unusual. But that's a kind of breaking change. I don't think we have enough motivation to change the name.

Closed as won't do.


Enable execute() to run prepared_statements for all connectors

I am absolutely not sure about what applies to PostgreSQL and MySQL in terms of limitation to one query at a time or return value, but I hope that this is in any case a good baseline.
I have taken the liberty to modify the return type of execute() for MySql from void to size_t so that it is in sync with other connectors.

Thanks!
FYI: It might take a few days for me to take a closer look. I am a bit busy with something else right now :-)
Feel free to ping me if it feels like it takes too long.


minor: patches

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove sort, sort_reversed, and seed from the protocol

Instead of having a special kind of sort, consider sending a random vector:
import polymath

import numpy as np

library = polymath.Library(filename="libraries/wdl-library.json")
query_vector = np.random.rand(1536)
query = polymath.Library.base64_from_vector(query_vector)
result = library.query(
    version=1,
    query_embedding=query,
    count=1000,
    query_embedding_model="openai.com:text-embedding-ada-002",
    sort="similarity")
print('random test\n\n')
for bit in result.bits:
    print(bit.text)

Here's my intuition: I don't think we're going to use these. Let's just remove them?
@jkomoros WDYT?

Add them as we find use case maybe

Yeah, I agree we can remove them. sort_reverse doesn't actually have a use case, it's a thing that might hypothetically be useful in the future if there's a sort where you want to have a reverse order (but that's hypothetical).
In the future we might want to support other kinds of sorts, like similarity-per-token but we can cross that bridge when we come to it.
There is a similar distinction between pick a random space in the embedding space and return all of the bits closest to it and give me a totally random collection of bits. The latter is useful theoretically for things like "What are some concepts in this library." But it's also useful for the use case of scraping content from the library (see #94) by continually just fetching random bits.  And anyway we can just make it "if you don't pass a query_embedding, we return a random set of results up to the content length limit"
The seed is only useful if you do want a random sort (which is not obvious we do; the random embedding use case is probably better way of doing that), and you want a way to express "don't cache the request I just did, give me a different random sort" by passing a different seed.
I imagine in the future that there will be use cases for different sorts, but for now it's probably best to just rip out the machinery given that we don't need it right now, in the interest of keeping semantics simpler.

@dglazkov Wanderer doesn't currently use sort=random anymore does it? If not I might just start ripping this out

Yep, it doesn't use it anymore. I am using the random vector thingy now.

[ ] Document the protocol somewhere, including all arguments and what they do, now that Library.query() uses **kwds it's hard to tell


DIY Network switched formats

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[X] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[X] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
DIYnetwork.com has changed formats to resemble sciencechannel.com. I assume all discovery owned channels will eventually use this new format. I haven't had time to figure out how to consolidate these changes so it works for the changeover of each site before they switch and after, so for now just fixing them as they switch.

So not sure why it added all the rest of these commits, not super versed in github as of yet.

You can rebase on origin/master and then force push. But if you have difficulty with it, don't mind it


Update metrics to use Enum

🚀 Feature

Motivation

Update metrics package to use Enum where it makes sense. For example:
https://github.com/PyTorchLightning/pytorch-lightning/blob/f78223041283450c98fb34bb23bea6706247d937/pytorch_lightning/metrics/classification/helpers.py#L79-L87
the case (data type) could be made an enum type
class DataType(LightningEnum):
    BINARY = 'binary'
    MULTILABEL = 'multi-label'
    MULTICLASS = 'multi-class'
    MDMC = 'multi-dim multi-class'

Pitch

Alternatives

Additional context

@Borda

I could give it a shot.
something like this
_check_shape_and_type_consistency(preds: torch.Tensor, target: torch.Tensor) -> Tuple[DataType, int]
& typify all string values to DataType in the metric package?
can you point to a file where DataType should be defined?

I could give it a shot.
something like this
_check_shape_and_type_consistency(preds: torch.Tensor, target: torch.Tensor) -> Tuple[DataType, int]
& typify all string values to DataType in the metric package?
can you point to a file where DataType should be defined?

The DataType is propably unique to classification problems and I would therefore put it in pytorch-lightning/pytorch_lightning/metrics/classification/helpers.py file.

The DataType is propably unique to classification problems and I would therefore put it in pytorch-lightning/pytorch_lightning/metrics/classification/helpers.py file.

fine with
class DataType(LightningEnum):
    BINARY = 'binary'
    MULTILABEL = 'multilabel'
    MULTICLASS = 'multiclass'
    MDMC = 'mdmc'

?
Otherwise
DataType.from_str('multi-label') == None
due to https://github.com/PyTorchLightning/pytorch-lightning/blob/84e02fbb4d082a8457b58464c5bd6631d9496693/pytorch_lightning/utilities/init.py#L58

fine with
class DataType(LightningEnum):
    BINARY = 'binary'
    MULTILABEL = 'multilabel'
    MULTICLASS = 'multiclass'
    MDMC = 'mdmc'

?
Otherwise
DataType.from_str('multi-label') == None
due to https://github.com/PyTorchLightning/pytorch-lightning/blob/84e02fbb4d082a8457b58464c5bd6631d9496693/pytorch_lightning/utilities/init.py#L58

Closed by PR #5689


is there some tables recored the data users download or exported ? i can no find some table relate to the history, can U help me ?

is there some tables recored the data users download or exported ?
i can no find some table relate to the history, can U help me ?
if no, how can i do to patch the export history to some tables?

No, you would have to look at the access logs, or enable the specific logger for audit logs https://github.com/cloudera/hue/blob/master/desktop/conf.dist/hue.ini#L115