feat(cards): add credit card number validation

Fixes #606
Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates

Description

The PR adds a new crate called cards. Which currently just has a single module named validate which exposes the CardNumber struct as well as a CCValError.
The validation of a correct CC number is done via the Luhn Algorithm implemented in the luhn crate.
Additional Changes

[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

This PR address #606.
How did you test it?

Tests for successful and failing CC number validation have been added.
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[x] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

I wasn't sure what to do regarding the Error that StrongSecret::from_str(s) could produce (Infallible).
I guess I could have also made the associative type Err in FromStr to be type Err = Box<dyn std::error::Error>; but I feel like the current approach makes more sense. Otherwise I would have had to box CCValError

Hi @SanchithHegde
I refactored a bigger chunk of the code when I was moving Strategy trait over from masking, because I realized that there would otherwise be two places for CardNumber, the new one in crates/cards and the one that was in common_utils:pii.
Since quite a few places were using common_utils:pii::CardNumber i replaced that everywhere with the new cards::CardNumber.
I also moved the test regarding masking of CardNumber to cards::validate. Creating a secret from a valid and a non valid CC number works when specifying Strategy of CardNumber:
let secret: Secret<String, CardNumber>

When creating a CardNumber the inner value is a StrongSecret which uses the WithType Strategy per default which seems to work as well.
Still not really sure how to use the error properly,  i.e. what to do in the masking case when the CC number is not valid. Right now it's masked just as a valid CC number.

and to ensure that invalid card numbers are caught during deserialization?

Also I wasn't sure what you meant by this.
Let me know if this works for you and what to change. Or if this is too much I can always go back to the previous commit and just add the stuff that you mentioned in your earlier comment.

and to ensure that invalid card numbers are caught during deserialization?

Also I wasn't sure what you meant by this.

Could you add tests to ensure deserialization catches invalid card numbers? So a call like serde_json::from_str::<CardNumber>(r#""1234 5678""#) should fail deserialization because of the invalid card number.
Regarding the refactor, it's fine, I did expect it to happen.

Hi @SanchithHegde
thank you for the detailed explanation of how the masking Strategy works. It confirmed how I understood it before, but I thought maybe it's okay that CardNumber does both: hold the data as well as provide a masking Strategy.
But I totally agree that it makes more sense to split the two things into dedicated types. I created CardNumberStrategy as you suggested and replaced everything that uses CardNumber with the new Strategy.
One thing that I wasn't sure about is that in a lot of places use something similar to:
pub card_number: Secret<String, CardNumberStrategy>

Would it make sense to replace all those with the new CardNumber struct that actually holds the data?
Also regarding Deref : I thought this is strictly for Smart Pointers and hence i created get_secret() instead. Let me know what you think.
I think the cc number check does not happen before deserialization unfortunately. Not sure what to do about this. Implement Deserialize manually?

Hey @phillyphil91,
It would be fine to replace masking::Secret<String, Strategy> with CardNumber throughout the code, since it's just a wrapper around the actual StrongSecret. Typical case of the newtype pattern, and due to Rust's zero cost abstractions, the CardNumber wrapper won't have any size.
We'll also most probably go ahead with a custom implementation for Deserialize that internally performs validation and returns an appropriate error message in case of failure (unless @SanchithHegde @NishantJoshi00, you guys see an issue). The idea is that card number validation gets done at the API layer itself by actix when it deserializes the HTTP request body into the required type, and the developer does not have to manually call any function to ensure validity.
Serde has documentation on how to do the same. If you'd like a reference, check out the mods at the bottom of crates/api_models/src/payments.rs
We don't have to worry too much about serialization. We can just #[derive(Serialize)] and annotate with #[serde(transparent)], and the serialization logic will skip the CardNumber struct and just serialize the inner secret.

Also regarding Deref : I thought this is strictly for Smart Pointers and hence i created get_secret() instead. Let me know what you think.

While Deref works great for smart pointers, it's not restricted to that domain and can be used wherever needed. Usage of Deref is pretty popular with the newtype pattern. It allows us to seamlessly go from having to write card_number.0.some_method_on_strong_secret() to being able to write card_number.some_method_on_strong_secret() (no .0).

Hi @vspecky
thanks for the comment. Just to be clear, should I try to implement Deserialize manually for CardNumber according to the example that you provided?

Hi @SanchithHegde
I changed all occurrences of Secret wherever it was used to hold the card number to CardNumber (there where actually quite a lot of places :smile:)
A few issues arose due to this. Mainly:

Beforehand creating a Secret from a CC Number could  not fail, i.e. into() always worked. Now I have to use try_into() and unwrap() to get the CardNumber. Same with from_str() which can also return the CCValError. I know this isn't really good but I was not sure how to handle or where to propagate the error to. E.g.:
card_number: Some(response.card_number.try_into().unwrap()),
There are some tests that create empty CC numbers to check if API calls fail with a missing number. Now that there is a validation check on CC numbers, one with an empty string can no longer be created and would result in an Error. Again the issue is how to handle this. E.g.:
card_number: cards::CardNumber::from_str("").unwrap(), -> will panic, because the Result will be an Err variant.

I haven't really looked into the call stack of some places that just had a "always" working Secret before, if is easy to propagate the error. Maybe you have an idea for this?

hi @SanchithHegde

If it's about unwrap()s in tests, that's fine. If it's in production code however, you'd have to avoid it. As far as I could see, there was only one unwrap() within code, and everything else were in tests. If there are more instances in code, remove them, or let us know if you need help.

Unfortunately in crates/router/src/core/payment_methods/cards.rs there are numerous places as well as in crates/router/src/core/payment_methods/vault.rs for example.
I wonder if it makes sense to replace CardNumber with Result<CardNumber, CCValError> in some places, such as in AddCardResponse in crates/router/src/core/payment_methods/transformers.rs or find some other way to include the fact that a card number can now no longer always successfully be created but might fail sometimes.

We should be able to remove that test case from all connector tests, since we're handling it ourselves.

Does this mean I leave them in for now and you take care of this?

Does this mean I leave them in for now and you take care of this?

You can either leave it in and one of us will take care of removing the test case for each of the connectors (and the connector template), or you can remove it in this PR. I'm fine with either.

You can either leave it in and one of us will take care of removing the test case for each of the connectors (and the connector template), or you can remove it in this PR. I'm fine with either.

I can remove them in this PR

Once you're done with the suggested changes, please resolve merge conflicts with the main branch. CI checks seem to be blocked on it.

Hi @SanchithHegde
I hope everything is fixed now. It was a bit tough keeping up with all the changes on main. Let me know if there is something missing.

Hi @SanchithHegde
Just making sure: There is nothing needed from my side for this to be merged right?

Hi @SanchithHegde Just making sure: There is nothing needed from my side for this to be merged right?

@phillyphil91 Yup, I'll handle merge conflicts and getting it merged in.

It was a lot of fun @SanchithHegde


Remove calls to crypto:rand_bytes

crypt:rand_bytes was removed in Erlang/OTP 20. This PR makes it possible to use this lib with Erlang/OTP 20

Ping, is there anybody maintaining the lib?

I just performed a big refactorization, this fix is included.
Thank you.


refactor!: drop deprecated StatusBarIOS

Summary
This component has been merged with StatusBar and deprecated since Jun 24, 2019
Changelog

[JavaScript] [Removed] - refactor!: drop deprecated StatusBarIOS
Test Plan
Warning when user imports StatusBarIOS

@lunaleaps is done!

@ecreeth Did you want to also remove the docs for StatusBarIOS on react-native-website

👍 Of course! I'll do it tomorrow early.


Add Element.closest polyfill

Add polyfill for Element.closest
Reference: https://developer.mozilla.org/en-US/docs/Web/API/Element/closest

@ljharb I change to use the element-closest package instead of mdn polyfills. PTAL again

Released as v1.10.0


Fixing navbar#2108

Fixes #
Fixed the Navbar for smaller screens and position of Quick-btn
Describe the changes you have made in this PR -
The Navbar contents on expanding, the widgets slide down thus making space for the navbar contents to be displayed properly.
The position of Quick-btn is fixed which was initially overlapping the navbar contents.
Screenshots of the changes (If any) -
Navbar-closed

Navbar open

Issue linked with this PR is
https://github.com/CircuitVerse/CircuitVerse/issues/2108
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 84.711% when pulling 1df8a425de046a9cec8965a12c812d3296d25614 on devartstar:FixingNavbar#2108 into dd70f7bf32d89033ddde6d5b06a500432e1ab4e9 on CircuitVerse:master.

@tachyons I have removed the inline CSS. Can you please further check it.

Instead of having the issue number in the title, but along with fixes, Fixes #2108 it closes the issue once merged if set this way.

@abstrekt  okay will keep that in mind... thanks

@abstrekt  okay will keep that in mind... thanks

No I meant keep a meaningful title, & on the description of the PR, in the temple you'd have 1st line as Fixes #____ , put the issue no. along with the #, as eg.
Fixes #1234
Did this .... .... ...
^ followed by a clear description.

@abstrekt Sorry I misunderstood initially but I have corrected it now.


Move migrations functionality to separate module

Automatically creating new migrations based on model changes is what every node developer coming from Django has been looking for.

There isn't much development in Node on Fire anymore. I should put up a notice in the README.
I think your best bet is to have a look at https://github.com/locomote/node-migrate-orm2, or http://docs.sequelizejs.com/en/v3/docs/migrations/. The migrations aren't auto-generated like in Node on Fire and Django, but it should be possible to implement in one of these projects.
I myself prefer to use https://github.com/martijndeh/lego nowadays. It avoids another abstraction like an ORM and still makes it fairly easy to change models (alter tables), but you do need to write SQL.


Media nommer not completing task

Hi,
I was trying out media-nommer and found that the the task of video encoding (very light) that I had submitted was not getting completed. Is there any way to debug this?
I am attaching some logs below.
Thanks,
Vimal Narain
2011-05-28 20:39:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:39:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:39:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:39:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:40:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:40:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:40:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:40:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:41:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:41:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:41:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:41:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:42:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:42:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:42:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:42:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:43:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:43:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:43:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:43:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:44:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:44:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:44:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:44:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:45:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:45:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:45:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:45:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:46:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:46:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:46:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:46:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4
2011-05-28 20:47:47-0400 [-] JobCache.refresh_jobs_with_state_changes(): Checking state change queue.
2011-05-28 20:47:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current active instances: 1
2011-05-28 20:47:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Current unfinished jobs: 2
2011-05-28 20:47:47-0400 [-] EC2InstanceManager.spawn_if_needed(): Job capacity (2 w/ thresh): 4

A lot of this code got completely gutted, so it may no longer apply. Re-open if you're still running into issues.


How to get the score of all classes?

In the monocular 3D object detection task, the file 'mononerd/models/detectors_mono/stereo_detector3d_template.py' contains the function post_processing() which is used to generate predictions of KITTI dataset.
My question is: How can I get all scores of an object (one of the objects belongs to the same image) instead of the highest one?
For example, for a car object, its scores may be [0.1333, 0.04, 0.05] (corresponding to 3 classes). I want to get the whole output [0.1333, 0.04, 0.05] rather than the highest value, i.e., 0.1333
Thanks for your patient reply :)

Hello, I am so sad to say that setting the post_process_cfg.OUTPUT_RAW_SCORE to True does not make sense, i.e., it still outputs the highest score.
Since your code relies on a very complex environment for me, I could just run it on my docker and have no idea about how to debug it on my PC.
If it is possible for you to tell me which variant contains the score distributions (If you could run your code in the debugging mode)? I think it must be somewhere (Since we have to output the score of each object).
I am sincerely willing to compare my work with your method and cite it as an important baseline.
Looking forward to your reply.

Hi, i've been away from my previous company during intern for some time now, and currently i'm preparing for my next work and future job interviews. At the moment, i lack the necessary computing resources for debugging.
If possible, please send me an email xujunkai<EMAIL_ADDRESS>and i will provide you with my contact information and detail how to debug within docker container.

Thanks for your reply!
However, I should not disrupt you too much if you lack the necessary computing resources.
I would try my best to figure it out.
Please take it easy~

Thanks for your reply!
However, I should not disrupt you too much if you lack the necessary computing resources.
I would try my best to figure it out.
Please take it easy~

Ok, i assume i could acquire some GPU devices later next month, if this problem still bother you, feel free to contact me!


WIP Recipe overview and steps pages

Recipe overview page:

Recipe steps page:

See #89 for earlier discussion on the same branch
Main changes made since last pull request:

Added route checks to display correct recipe based on slug
Buttons route correctly
Added recipe steps page
Added colorScheme type to (hopefully) fix PurgeCSS issue
Reorganised recipe info + images for better scalability

Further work (overview page):

[ ] Add equipment/ingredients images to overview page (probs need to redo page layout)

Further work (steps page):

[ ] Fix positioning of images on steps page
[ ] Possibly turn steps into cool slideshow?
[ ] Make styling responsive

Further work (both pages):

[ ] Make styling more exciting for kids

Outdated, see #180 instead.


Add devdocs for Keyboard Manager

📝 Provide a description of requested docs changes
What is the purpose and what should be changed?
Keyboard Manager requires dev docs which explain the code flow and each of the implemented features, along with steps for modifying the UI.

@ryanbodrug-microsoft @crutkas @saahmedm FYI. Not sure which milestone we want to add this to.

i would start working on it when you have cycles since you'll remember stuff here and there

Closing this as the work is tracked in #7158


if chatAndUsers=true then the vertical alignment is wrong

@0ip im struggling to come up with a good CSS solution for this.  I'd appreciate your input :)

Fixed :)


Vector2.floorf method doesn't exist

classes.xml report a Vector2.floorf, however this method doesn't exists in Vector2 implementation
So I think this should be remove from classes.xml

I remember talking about this on irc. It's declared here and registered here. However, it seems to be exactly the same as floor, so I don't see this method's point.

Thanks for pointing me out ;-)
I guess this is legacy stuff, maybe Godot 3 is the right time to get rid of it...


How to implement new coin?

Is there a guide for implementing a coin into the code for a PR?

Is there a guide for implementing a coin into the code for a PR?

If you're looking add ERC20 token into a Bank Wallet, here is the repository for that https://github.com/horizontalsystems/Supported-ERC20-Tokens
If you refer to other blockchains/currencies (Monero, Dash, LTC etc) then at this point we are integrating decentralized support for each blockchain separately and it's a major task on its own.
At this point the BANK supports decentralize integration for Bitcoin, Bitcoin Cash and Ethereum blockchains. The support for DASH blockchain is currently in progress and likely to take another 3-4 months. Can't comment on any other blockchains besides that because we are not yet set on the priority level for each blockchain when it comes to choose which one will be integrated next.

Appreciate it. Thank you..


ExternalProgramTask -- disabling capture_output

I'm wondering how could I disable the ExternalProgramTask's capture_output property when it's already turned on by default?

By default, the output (stdout and stderr) of the run external program
is being captured and displayed after the execution has ended. This
behaviour can be overridden by passing "--capture-output False"

 `capture_output = luigi.BoolParameter(default=True, significant=False, positional=False)`

"--capture-output False" doesn't work since it's as a boolean parameter doesn't accept an argument, so I don't see how to switch it off from the command line. May be it would be better to replace it with something like --disable-capture-output or --no-capture-output to be able to control this behavior?
Thanks!

@indexless yes, this was clearly a design miss from us. I think --disable-capture-output would make much more sense. How long has the behavior been around? Perhaps we could change it as long as there's some reasonable check of the variable for backward compatibility for a short while?


Add Graveler Set advanced tests

Closes #3832
Any additional test ideas a welcomed!

@nopcoder  Thanks - let me know if this is what you were thinking


Fix omitted setting of SWIFT_HOST_VARIANT to "windows"

This was left out when I added this code. This fixes a couple of unit test and SourceKit CMake generation errors.
All the other configured hosts have this set, I'm not sure why I didn't add this at the beginning.

@gottesmm PTAL, cheers
Quick question too:
we have a lot of different checks around the place for SDKs.

CMAKE_SYSTEM_NAME
SWIFT_HOST_VARIANT
SWIFT_HOST_VARIANT_SDK
SWIFT_PRIMARY_VARIANT_SDK

I'm just confused as to the point of all of them.
I'd expect there to be two variables, with the following descriptions

SWIFT_TARGET_SDK: the ID of the system for which we're building. necessary for stuff like linking the right thing, and compiling the right thing
SWIFT_HOST_SDK: the ID of the actual system we're building on. necessary for stuff like working around platform specific build system limitations.

They'd have the same casing, e.g.
"windows|linux|macosx|iphoneos|iphonesimulator|appletvos|appletvsimulator|watchos|watchsimulator"
The problem right now is that each one has slightly different casing, naming convention and purpose!
I'm not sure how good this is to be honest, but the current system's a bit of a mess to an outsider

@swift-ci please clean smoke test

@hughbe you aren't considering cross-compiling a fat MachO target.  So, use x86_64 to cross-compile ARMv7 and AArch64.  Yes, there is a lot that could be done to simplify and clean up the build system, but the multiple variables are needed in the current setup.

LGTM


Rocket doesn't generate permissions file

The title says it all... My Rocket won't generate any permissions file. It generates all the other files and configs needed, the Rocket.config.xml and Rocket.Unturned.Config.xml. I tried with and without any plugins. I also noticed that all plugins fail to generate configs although they should.

oh, it looks like I fixed it... Although I have no idea how


Update tutorial.md (render draw gameover)

Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

Coverage remained the same at 100.0% when pulling 57b756d8ceb89cfbecf12560fcbd9b260c4daca1 on EmrysMyrddin:patch-1 into<PHONE_NUMBER>cc613950f9b783dc8b7d83428b32a2 on google:master.

No it's not really a bug.
It's just that the tutorial is showing how to return an object in the function endGameIf.
If the game is draw, it set a flag, but this flag is then not used. I found this a little confusing.

In the meantime, I think it's ok to leave the code as is. The two states can either be Winner or Draw, so it's ok to just check:
if (winner) { display Winner }
else { display Draw }

rather than checking for the draw field explicitly.

Feel free to continue the discussion here of course if you think we should change something.


Ensure sync to parent status-based tool tips show up for more than just the first few mouse hovers

For now, these tooltips are shown only for first N times (mouse hovers). Especially closing and reopen Git Machete tab or toggle listing commits cause that tooltip not appear.

Checked on IntelliJ 2020.3. It has been fixed.


Finding an example for i2s > a2dp > windows

trying to record from a INP443 over bluetooth on my windows machine (to register as a bluetooth mic). Coulnd't find the proper example, in this one (link ) I get a compilation error ('Channels' not found).
One more thing: Is it possible to send raw keycodes (e.g. 'enter key') over r2dp with your libraries (or are only media buttons supported, as I suspect)?
Thanks for the great work

Just use the example from Github! I am not updating the code examples on my Blogs as they.
I do not understand your second question. What is r2dp and what are raw keycodes?

Sorry, let me be more clear/specific.
First I tried your example streams-i2s-a2dp.ino which compiled nicely. However, if I get it right, this won't broadcast a bluetooth device name to be connected to (in my case, that would be my windows machine), but rather attempts to directly connect to a named device.
I guess my question is simply a)how do I make it broadcast/advertise so I can connect to my windows machine and b) how do I send 'more' than play/pause keys using your libraries (e.g. the 'arrow up' key, or any other keycode for that matter)

I am sorry I can't provide any Windows support. I suggest to google how to turn windows into a bluetooth sink.
I haven't worked with Windows since 20 years...
The example is intended to be used with a Bluetooth Speaker.

ok - I think I'm just being silly for not finding the proper example in your libraries. Can you simply point me to the right example to use my external i2s microphone with my esp32 as bluetooth source?

https://github.com/pschatzmann/arduino-audio-tools/tree/main/examples/examples-stream/streams-i2s-a2dp
https://github.com/pschatzmann/arduino-audio-tools/tree/main/examples/examples-basic-api/base-i2s-a2dp

thanks! Is there an example to advertise the bluetooth source without specifying the name of the device that is supposed to be connected to? (i.e. wait until any target device connects?)

This does not make any sense: You need to know the device you want to connect to!
That's the reason why I recommended you to test it with the phone first - there you can see the name!

I mean, I basically want to connect a i2s microphone over bluetooth (using an esp32). maybe I misunderstand completely, but I imagined the way this would be done is:
i2s from mic > esp32 > bluetooth device is advertised > search for bluetooth device (e.g. 'my bluetooth enabled microphone') on my phone / bluetooth enabled machine > connect to source (as 'microphone') > access microphone input using Audacity on my machine/phone

Lets start with the standard case. You have a mobile phone that you connect to a bluetooth speaker: On the mobile phone you can select the bluetooth speaker.
Now to the example: The ESP32 plays the role of the mobile phone - but because you do not have a screen you need to tell in advance to which device you want to connect to.

Lets start with the standard case. You have a mobile phone that you connect to a bluetooth speaker: On the mobile phone you can select the bluetooth speaker.
Now to the example: The ESP32 plays the role of the mobile phone - but because you do not have a screen you need to tell in advance to which device you want to connect to.

using this example, my phone (i.e. Bluetooth mic) wouldn't have a screen, but my speaker (i.e. my machine with attached) would.

i don't want to attach speakers, i want to attach a microphone upsidedown smiley

Then A2DP is not the right solution for your problem

For reference for future readers:
This (the thumbnail of the video with the puking smiley face) summarizes my struggles and explains that a2dp is not suitable, recommends Bluetooth handsfree profile.
https://youtu.be/0jR-QNTfydA
There are cheap bluetooth audio transmitters (also called emitters) explained well in this video
https://youtu.be/ZQ5MWcis8rA that seem to do the work reasonably well. I have not found a better alternative

Did you have the chance to measure the lag of these modules ?

Oh I just ordered, will arrive in months... it's for speech/dictation, like a karaoke 🎤 anything less than 100ms delay should be fine, I wouldn't expect a lot worse


Allow date picker quick select to be used for single-day selects

Feature description
Quick select on date pickers is only enabled for date pickers for which isRange is true. Would be great to allow quick select for date pickers where the goal is to pick one specific date.

can you provide some examples of useful quick select options?

A user is scheduling an appointment for a specific day/time, and 'today' or 'tomorrow' could be quick select links for that specific day


Add Vue 2 Material Dashboard

The Vue version of Material Dashboard which designed by Creative Tim.
LIVE DEMO

@kazupon sorry, how can I make my pull request to be mergeable?

Merged!
I think it's no problem. 😉


DOC/CI: fix doc build for latex + re-enable epub and htmlzip

After https://github.com/shapely/shapely/pull/1529, the doc build on readthedocs was failing for latex (pdf). Although if this rendering can't be done for pdf, then I am not sure that the approach of https://github.com/shapely/shapely/pull/1529 will actually result in proper pdf docs .. (I am also not sure how important this is)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.202%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2084

Relevant Lines:
2475

💛  - Coveralls

This fixed the doc build: https://readthedocs.org/projects/shapely/builds/18158708/
And it seems that the PDF is actually fine, it includes all the reference docs as well: https://shapely.readthedocs.io/_/downloads/en/fix-pdf-docs/pdf/ (so not really an idea how this works, since the templating doesn't seem to be called when running the latex docs; unless that is build after html, and uses the cached environment from that? Anyway, it works ;))


Investigate the use case of slurm sacct

It seems aiida-core is using this to get the exit code in a complicated manner:
tasks.py and calcjob.py both expect a dictionary with three keys ('retval',   'stdout',   'stderr') from:
scheduler.get_detailed_job_info()
Which then calcjob.py uses it along with two other files to call again on scheduler.parse_output to get the exit code.

Without this feature, monitoring cannot be done.
For now, in case of a failure, not possible to know which of these caused it:
ERROR_SCHEDULER_OUT_OF_MEMORY
ERROR_SCHEDULER_OUT_OF_WALLTIME
ERROR_SCHEDULER_NODE_FAILURE etc..


changes link to new donation form

The Executive team decided to move to a different donation platform that we can easily integrate into our Stripe account.  I've set up the form and am altering the donate links to point to the new form :)

Ty for your contribution 😛 😁


Add support for card messages

Cards look like this:

You can get one from the Skype support bot, thread ID 28:1fa0c494-3cd2-4a7e-9184-91d09a4cef1f.
>>> ch = sk.chats["28:1fa0c494-3cd2-4a7e-9184-91d09a4cef1f"]
>>> ch.sendMsg("help")
>>> # wait for a response...
>>> ch.getMsgs()[0]

Message type is RichText/Media_Card.  Sample message content:
<URIObject type="SWIFT.1" url_thumbnail="https://urlp.asm.skype.com/v1/url/content?url=https://neu1-urlp.secure.skypeassets.com/static/card-128x128.png">
  Card - access it on https://go.skype.com/cards.unsupported.
  <Swift b64="..." />
  <Description />
</URIObject>

The b64 attribute encodes a JSON representation of the card:
{
  "attachments": [
    {
      "contentType": "application/vnd.microsoft.card.hero",
      "content": {
        "title": "Thank you for your message!",
        "text": "
Please check out the following resources to learn more about Skype.
",
        "buttons": [
          {
            "type": "call",
            "title": "Make a test call",
            "value": "echo123"
          },
          {
            "type": "openUrl",
            "title": "Suggest a feature",
            "value": "https://feedback.skype.com/survey/answer/m2i"
          },
          {
            "type": "openUrl",
            "title": "Browse known issues",
            "value": "https://secure.skype.com/login/sso?go=help.litefaq&intsrc=support_bot-help&setlang=en"
          },
          {
            "type": "openUrl",
            "title": "Or... search for cats",
            "value": "https://www.bing.com/images/search?q=cats"
          }
        ]
      }
    }
  ],
  "type": "message/card",
  "recipient": {
    "id": "8:fred.2",
    "name": "Fred Adams"
  },
  "timestamp": "2017-01-01T00:00:00.0000001Z"
}

User-sent cards appear to render successfully in Skype for Web and Skype on Android.

3568719 adds the SkypeCardMsg type, which will parse existing cards and allow you to create your own.


About the release of the code

Do you have a plan to release the code?
Thanks

Due to a lot of schedules, I think I can release the code around the end of this month.

Thanks for reply!!

Waiting for the release! Thank you~

Yes, waiting for the release of the code..

hello,did you receive any reply from the author:)@GopiRajuMatta

hello,did you receive any reply from the author:)@GopiRajuMatta

No @HarisIqbal89

Waiting for the release! Thank you~

Hi, sorry for the late response, I've been extremely busy with my schedule for the past few months.
I think I can upload the code next month.
Thank you and sorry for your patience.

Hope you can publish the code.

When can you release the code? Thanks!

Hi, When can you release the code? Thanks!

Good paper work! Are you still plan to upload the code ?


Allow clinical types in immuno workflow

https://github.com/genome/analysis-workflows/blob/a3e26136043c03192c38c335316d2d36e3e67478/definitions/pipelines/immuno.cwl#L731
The immuno workflow should be modified to allow the user to optionally specify clinical HLA types. These should be intersected with the optitype output using a filtering script, then passed to pvacseq

This exists in the currently implemented immuno workflow, as far as i can tell.  @johnegarza, please reopen if I'm mistaken


First Fybrik kfp component and sample

Fybrik based get_data_endpoints kubeflow pipeline component for use in machine learning pipelines.  Enables reading of test and train cataloged datasets and generating a result dataset.
Includes a HousePriceEstimate example pipeline that uses the get_data_endpoints component.
See the following for overview of goals, architecture and demo
https://drive.google.com/file/d/1xn7pGe5pEAEZxnIzDdom9r7K6s78alcP/view?usp=sharing
Signed-off-by: simanadler<EMAIL_ADDRESS>

The failed runs do not remove fybrikapplication, and retry run fails with error that fybrikapplication exists

I will open an issue to investigate how to automatically remove fybrikapplication when a run is deleted.


Test Framework ReachabilityTest fails on naked->naked calls on minikube

./tests/e2e/local/minikube/setup_host.sh then
go test ./tests/integration/security/reachability/... -v -p 1 --istio.test.ci --istio.test.env kube --istio.test.nocleanup leads to
        --- FAIL: TestReachability/global-mtls-on/naked->http://naked:http (15.00s)
            checker.go:55: naked to naked:http using http: expected success but failed: failed calling naked->'http://naked:80/': rpc error: code = Unknown desc = Get http://naked.reachability-1-82168.svc.cluster.local:80: dial tcp <IP_ADDRESS>:80: i/o timeout
        --- FAIL: TestReachability/global-mtls-on/naked->ws://naked:http (15.00s)
            checker.go:55: naked to naked:http using ws: expected success but failed: failed calling naked->'http://naked:80/': rpc error: code = Unknown desc = dial tcp <IP_ADDRESS>:80: i/o timeout
        --- FAIL: TestReachability/global-mtls-on/naked->http://naked:tcp (15.00s)
            checker.go:55: naked to naked:tcp using http: expected success but failed: failed calling naked->'tcp://naked:9090/': rpc error: code = Unknown desc = Get http://naked.reachability-1-82168.svc.cluster.local:9090: context deadline exceeded

        --- FAIL: TestReachability/global-mtls-off/naked->http://naked:tcp (15.01s)
            checker.go:55: naked to naked:tcp using http: expected success but failed: failed calling naked->'tcp://naked:9090/': rpc error: code = Unknown desc = Get http://naked.reachability-1-82168.svc.cluster.local:9090: context deadline exceeded
        --- FAIL: TestReachability/global-mtls-off/naked->ws://naked:http (15.00s)
            checker.go:55: naked to naked:http using ws: expected success but failed: failed calling naked->'http://naked:80/': rpc error: code = Unknown desc = dial tcp <IP_ADDRESS>:80: i/o timeout
        --- FAIL: TestReachability/global-mtls-off/naked->http://naked:http (15.04s)
            checker.go:55: naked to naked:http using http: expected success but failed: failed calling naked->'http://naked:80/': rpc error: code = Unknown desc = Get http://naked.reachability-1-82168.svc.cluster.local:80: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
        --- FAIL: TestReachability/global-mtls-off/naked->grpc://naked:grpc (60.01s)
            checker.go:55: naked to naked:grpc using grpc: expected success but failed: failed calling naked->'grpc://naked:7070/': rpc error: code = Unknown desc = context deadline exceeded

Discovered by https://github.com/istio/installer/pull/262, because in the installer repo we run these tests on minikube

We "fixed" this in installer with https://github.com/istio/installer/pull/272. If this is needed for istio/istio I suggest we do the same here. For now closing this


Added adapt_structure method for NPZD

Solves #86

@iuryt @zwei961120 I've just tested on GPU and it seems to work now!

Anyone mind if I just merge this without the docs working? I can't work out why they won't run, but this PR doesn't make any changes to the docs


ESLint 4

Looks good Keegan! 👍
Just need to add some notes to CHANGELOG.md
If you're planning a release I might quickly sneak in a PR too.. I just realised I accidentally implemented a deprecated rule in our React rules. oops.

Thanks Jenna, I think we should merge your PR first and make a patch release, then merge this one and make a major release, since its a new major release of ESLint. I'll update the changelog in this PR.

I have now updated the changelog

Note: this only failed CI because we haven't yet published version 3.0.0


Adds '-z' parameter to set the local timezone for sql commands like N…

We had the problem creating metrics based on queries containing the NOW() command, which uses the UTC timezone of the MySQL server. This PR adds a new option (--mysql-local-timezone / -z) to set the local timezone for the query sessions.

Thanks @mhubig, looking good. The init_command doesn't seem to like being "" when -z isn't specified, but I'll tweak that when I merge.

Released in 0.3.0

@braedon sorry couldn‘t test this properly since am currently on vacation...

No worries. Let me know if you find any issues with the released version.


server wont start with workshop map

how can i install a map on linux (Debian 8)? I installed the manager and then
arkmanager installmod 504122600
then i editied the config
http://pastebin.com/9YqkZ6YD
but i get the error
23:00:26: start
23:00:26: Running /home/arkserver/ARK/ShooterGame/Binaries/Linux/ShooterGameServer -MapModID=504122600\?MaxPlayers=70\?Port=7777\?QueryPort=27016\?RCONEnabled=True\?RCONPort=32330\?ServerAdminPassword=keyboardcat\?ServerPassword\?SessionName=ARK\ Server\ Tools\?listen
23:00:26: Server PID: 7353
[S_API FAIL] SteamAPI_Init() failed; SteamAPI_IsSteamRunning() failed.
Setting breakpad minidump AppID = 346110
Signal 11 caught.
/usr/local/bin/arkmanager: line 516: 7353 Segmentation fault "$arkserverroot/$arkserverexec" "$arkserveropts" "${arkextraopts[@]}"
23:00:42: Bad PID ''; expected '7353'
23:00:42: exited with status 0

map is saved in /home/arkserver/ARK/ShooterGame/Content/Mods
but there is just the folder and no .mod file in /mods

What was the output of arkmanager installmod 504122600?
What are the contents of /home/arkserver/steamcmd/steamapps/workshop/content/346110/504122600?
Does /home/arkserver/steamcmd/steamapps/workshop/downloads/346110/504122600 exist?

Does /home/arkserver/steamcmd/steamapps/workshop/downloads/346110/504122600 exist?
nop

Had you previously started the server before installing the mod?  You will probably need to either remove the /home/arkserver/ARK/ShooterGame/Saved directory, or move it somewhere else if you want to keep it.

when i start with the normal map, it works. ok.
And what i have to add in the config?

btw how do i edit the ark settings? when i change something in the
/home/arkserver/ARK/ShooterGame/Saved/Config/LinuxServer/GameUserSettings.ini
it do not work

Server must be restarted before changes GameUserSettings.ini take effect, same goes for Game.ini.

i restarted the server after i changed something

Can you give example which values you're trying to change?

HarvestAmountMultiplier=2
TamingSpeedMultiplier=5
DayTimeSpeedScale=1
NightTimeSpeedScale=1.67
DayCycleSpeedScale=0.42857148
NoTributeDownloads=False
ServerCrosshair=False
ServerForceNoHUD=False
ServerHardcore=False
AutoSavePeriodMinutes=5.000000
ListenServerTetherDistanceMultiplier=1.000000
MaxTamedDinos=5000.000000
AllowThirdPersonPlayer=True
ServerPVE=False
ShowMapPlayerLocation=True

Is that the entire contents of the GameUserSettings.ini file, or just the [ServerSettings] section of that file?
As for the crontab entry, the following cron job should have it checking for both app and mod updates every half-hour:
*/30 * * * * /home/arkserver/bin/arkmanager update --warn --update-mods

its in the serversettings sections

Be sure to block out / remove passwords from your configs when you post them.
Any settings you want to set in GameUserSettings.ini need to be removed or commented-out in arkmanager.cfg.

there is nothing set in the arkmanager cfg which is set in the gameusersettings

@C0kkie i would seriously reconsider doing autosave every 5 minutes.  causes a LOT of lag.  I have mine set to 90 minutes.

@C0kkie do you still know what you changed to get it working? Facing the same problem and also trying to install Valhalla. Getting the same error as well.

guys this is the issue section of the ARK Server Tools, not a Q&A of ARK server.
If your questions are not related to problems with this tool, post them somewhere else.
This will help to keep clean this repository and focus on the real problems.


[Alarms & Timers] Process of creating a new alarm/timer is confusing

Affected hardware version
Bangle 2
Your firmware version
2v15
The bug
Describe the bug
Not a bug so much as a feature suggestion. It order to create an new alarm/timer, you must set up the alarm/timer with the menu, then press the side button. There isn't a note of this anywhere in the app. Ideally, this process would be a bit more intuitive so that someone who has never used the app before doesn't struggle to start an alarm/timer. Note that I'm not suggesting that the side button behavior be changed, just that an additional menu item be added that's a bit more obvious and does the same thing as pressing the side button in the menu.
Expected behavior
The first time I used the app, I expected there to be a button at the bottom of the menu labelled "Confirm", "Create", or something along those lines.
Steps to reproduce

Open Alarms & Timers
Choose New...
Choose Alarm or Timer
Panic because you can't figure out how to confirm your selections
Press the side button
Realize that's how you confirm and be confused
Create this issue

Ahh - thanks! Yes, you can actually go back by tapping the red arrow in the top-left as well.
But yes, adding something like 'confirm' makes a lot of sense!


custom qos for OperationQueue

Hey,
I am currently working on a project that requires highly intense CPU computation. After running for a while, the OperationQueue is no longer scheduled, task are enqueued but never executed.
The problem can be solved by specifying a high qos for OperationQueue. Is it possible to add an init function that takes an qos and set it to OperationQueue:
  /// Initializes a unsecure Server instance with custom quality of service
  public init(qualityOfService: QualityOfService) {
    workerQueue.qualityOfService = qualityOfService
  }

Hi @Burningdust21, unfortunately because of work and a never ending list of home improvement projects I don't have a lot of time to spend on Telegraph right now.
If you would like to open a PR, I would be happy to have a look at it when I can.
Perhaps we could even consider just making the workerQueue public. That would give some flexibility in configuring the OperationQueue. See: https://github.com/Building42/Telegraph/blob/main/Sources/Server/Server.swift


createActor parameters pattern

Suggestion
I just used pic.createActor for the first time and, I was suprised to notice that the pattern used to pass its parameters is different that other function such as upgradeCanister or setupCanister. Therefore, I would like to suggest, even if it's a breaking change, to modify the signature of the method as follow.
From:
public createActor<T = ActorInterface>(
    interfaceFactory: IDL.InterfaceFactory,
    canisterId: Principal,
  ): Actor<T> {

To something similar to:
public createActor<T = ActorInterface>(
    {interfaceFactory, canisterId}: {
       interfaceFactory: IDL.InterfaceFactory,
       canisterId: Principal,
    }
  ): Actor<T> {

i.e. pass an object as parameter
WDYT?

A propos, maybe would also be interesting to add an optional identity to the parameters - e.g. this is how I used it:
const newActor = pic.createActor<SatelliteActor>(idlFactorSatellite, canisterId);
newActor.setIdentity(controller);

My thinking here was that less than 3 paramters didn't justify an object as a parameter, but I can see how this feels consistent with the vast majority of public methods that have 3 or more parameters and hence have an object as a parameter.
The identity parameter is a nice suggestion too. I'll take a look at both next week and report back.
Thanks for the suggestion!


IF-397: New applet no preselection in action

Task linked: IF-397 Applets - "E-Mail" is preselected as action when creating new Applet


Slash Flag Ephemeral

Add full support now that this is documented.
https://github.com/discord/discord-api-docs/commit/ac350ce683da35d3cd471600bbd6958a8cc65874#diff-39e6aeaafba5726f3fb409da21a6953dfb679480f09038a0d05f4dd93e89e074R15

https://github.com/discord/discord-api-docs/commit/ac350ce683da35d3cd471600bbd6958a8cc65874#diff-07978ef9d619062fb1afbb70ea065124531246743444f4354cc9e6c8879f8780R881


Firefox 35: Javascript errors on common browser interactions

Steps to Reproduce:

Install Firefox v35

Errors can be re-created with the following code:

require 'watir-webdriver'
b = Watir::Browser.new :firefox
b.goto "www.google.com"
t = b.text_field(:id => "gbqfq")
t.flash  #this will throw this error: Selenium::WebDriver::Error::JavascriptError: arguments[0] is undefined
t.focus #this will throw this error: Selenium::WebDriver::Error::JavascriptError: arguments[0] is undefined

What version of selenium-webdriver is being used here? Looks like the version you're running isn't compatible with Firefox 35.

I think I am testing the latest development version. I can recreate the error with this:
gem 'selenium-webdriver', '=2.45.0.dev2'
require 'watir-webdriver'
b = Watir::Browser.new :firefox
b.goto "www.google.com"
t = b.text_field(:id => "gbqfq")

Thanks. This isn't an issue in watir-webdriver, but in selenium-webdriver. I've reported it here.

Thank you so much for your fast response on this issue.


docs: added reference to use generic http/https profile in mountainduck.

This PR will close https://github.com/minio/cookbook/issues/113#event-893234241

Cyberduck is in MountainDuck. Please fix.

@deekoder My bad. I should have also added a note that i have formatted structuring of cyberduck doc as well along with this patch.
Let me clarify:

This patch adds reference of  generic S3 HTTP profile in mountainduck cookbook.
This patch also does sentence restructuring related to generic S3 HTTP profile in cyberduck doc.

ok. Accepting this PR.


Connectivity Score implementation

Hi Ted,
Not really an issue per se, but I was wondering if you have any plans to extend the package to also compute the Connectivity Score as implemented by Subramanian et al., 2017?
Alternatively, are you aware of any other R package or code snippets that implement it?
Thank you,
Enrico

Hi @enricoferrero ,
Sorry for the delayed reply. We don't have immediate plans to implement the full set of connectivity scores (weighted enrichment, normalization, conversion to tau) in cmapR, particularly because the latter steps are quite involved and require access to precomputed background enrichment score distributions, which may not be generally possible.
We do however offer the full connectivity workflow as a set of docker containers:
https://hub.docker.com/r/cmap/sig_introspect_tool/ - for computing pairwise connectivities within a dataset
https://hub.docker.com/r/cmap/sig_gutcbackground_tool/ - for converting pairwise connectives into a background for computing tau
https://hub.docker.com/r/cmap/sig_gutc_tool/ - for computing tau values
The GSEA-MSigDB R package implements the enrichment score (function GSEA.EnrichmentScore), which may be useful if that's something you'd like to compute.
Thanks a lot,
Ted


return if start_gce fails

why would we continue if start_operator_gce returned an error already? It just means more unrelated errors?

oh but then shouldn't we return the error? like return 1 or will return preserve errno

From help return:
If N is omitted, the return status is that of the
last command executed within the function or script.
On Thu, Feb 10, 2022 at 11:40 AM sirdarckcat @.***>
wrote:

oh but then shouldn't we return the error? like return 1 or will return
preserve errno
—
Reply to this email directly, view it on GitHub
https://github.com/google/kctf/pull/359#issuecomment-1034761382, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEM2JHXCBY6ZW6KEQKY2OSDU2OI2VANCNFSM5OAFQC7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

cool!


Make conditional attributes work for data- attributes

Conditional attributes were introduced in MVC4 whereby if an attribute is set to a null value then the entire attribute was omitted. This isn't covered in the release notes, but is referred to here. Here is an example:

  ->

Presumably for backwards compatibility with some code that was confusing blank and null, this does not work for data- attributes. This behaviour is unexpected, hard to work around and not documented anywhere except in the source. Until you realise that it is data- attribute specific it is also very hard to find references to it. Example:

  ->

It is a very simple code change, but the question is whether compatibility issues are still a concern?
I see that other long-standing issues in MVC that had (presumably) not previously been fixed for backwards compatibility reasons have now been fixed in MVC Core, for example calling Html.Partial with a null model used to pass the callers model (without a nasty workaround) but now works as expected.
References (only really discoverable once you realise it is data- specific):
http://stackoverflow.com/questions/17545045/weird-behavior-with-conditional-data-attributes
http://stackoverflow.com/questions/13267619/razor-conditional-attribute-not-working

@leo-ridgewood data- attributes by spec are intended to be used on the client which is why we don't enable conditional attributes on them (server functionality). This is also true with TagHelper bound attributes; they cannot use HtmlAttributeName to specify a data- attribute.

To expand on @NTaylorMullen's comment, the presence of an empty data- attribute might be used to make a decision on the client. (e.g. document.querySelectorAll('[data-anything]')). Removing this would be a breaking behavior which is why Razor specifically chooses to ignore these.

I just discovered this issue too.
@pranavkm It's fair to say that someone may try to query for an element based on its data attributes, but surely someone could also query for other attributes too?
For example:
CSHTML
@{
    string title= null;
}
Link

JS
... document.querySelectorAll('[title]') ...

Also, the title attribute is surely a purely client side attribute, so it should show even if empty?

However, I get that if this is just gonna cause more issues for people who upgrade and you don't want to introduce unnecessary breaking changes, that makes sense.

@HarveyWilliams that's entirely true - most attributes, with the exception of the ones processed by TagHelpers, are meant for the client and could be used as a source of making decisions on the client (either JS or CSS). That said, using the presence of presentation \ informational attributes to make decisions on the client doesn't seem like idiomatic JS to me. That said, if you require these values to be rendered, you could always use empty strings (string title = "" or title="@(title ?? "")".

For the reasons @pranavkm and @NTaylorMullen mention, we are not planning to change this behavior.


chore: bump oneTBB to v2022.0.0

Bump oneTBB to v2022.0.0 - release page - https://github.com/oneapi-src/oneTBB/releases/tag/v2022.0.0
Key features

Extended the Flow Graph receiving nodes with a new try_put_and_wait API that submits a message to the graph and waits for its completion.
Fixed the missed signal for thread request for enqueue operation.
Significantly improved scalability of task_group, flow_graph, and parallel_for_each.
Removed usage of std::aligned_storage deprecated in C++23
Detect the GNU Binutils version to determine WAITPKG support better
Fixed the build on non-English locales

TBH the version number of TBB is quite confusing..


Non-ASCII characters in connection string password cause UnicodeEncodeError in cleanup

This script successfully connects to a SQL Server database using a login with a non-ASCII character in the password, but causes a UnicodeEncodeError when garbage collecting the pyodbc connection (I assume) and crashes python:
#!/usr/bin/env python
# encoding: utf-8
from __future__ import unicode_literals, print_function

import gc
import sys

import pyodbc

# Please ensure these are valid parameters for your test SQL Server - if pyodbc
# cannot establish a connection then the bug seems to be avoided.
CONN_PARTS = {
    'DRIVER': '{SQL Server}',
    'Server': '.\\SQLEXPRESS',
    'DATABASE': 'test_pyodbc',
    'UID': 'test_pyodbc_unicode',

    # PWD must contain Unicode that cannot be encoded as ASCII to invoke crash.
    'PWD': 'pa££word',
}
CONN_STR = ";".join(key + '=' + val for key, val in CONN_PARTS.items())

def main():
    print('python version:', sys.version)
    print('pyodbc version:', pyodbc.version)
    try:
        print("Connecting", CONN_STR)
        pyodbc.connect(CONN_STR)
        print("Connected OK")
    except Exception as err:
        print("Failed to connect - is your connection string correct?")
        print(err)
        exit(1)

    print('About to garbage collect')
    gc.collect()
    print('No crash - did you forget to use a Unicode PWD or fix the bug?')
    exit(1)

if __name__ == "__main__":
    main()

Output on my Windows 7 system, with the latest 3.0.10 release from pypi installed by pip from the wheel:
python version: 2.7.9 (default, Dec 10 2014, 12:24:55) [MSC v.1500 32 bit (Intel)]
pyodbc version: 3.0.10
Connecting PWD=pa££word;DATABASE=test_pyodbc;DRIVER={SQL Server};UID=test_pyodbc_unicode;Server=.\SQLEXPRESS
Connected OK
About to garbage collect
Exception UnicodeEncodeError: UnicodeEncodeError('ascii', u'PWD=pa\xa3\xa3word;DATABASE=test_pyodbc;DRIVER={SQL Server};UID=test_pyodbc_unicode;Server=.\\SQLEXPRESS', 6, 8, 'ordinal not in range(128)') in 'garbage collection' ignored
Fatal Python error: unexpected exception during garbage collection

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

If we remove the 4 lines of explicit gc.collect stuff at the end of main and replace with a dummy loop:
    for i in xrange(2):
        print("Fake work", i)
    print("Done")

Then python itself doesn't crash, but the UnicodeEncodeError is raised when the loop finishes, before we print Done:
python version: 2.7.9 (default, Dec 10 2014, 12:24:55) [MSC v.1500 32 bit (Intel)]
pyodbc version: 3.0.10
Connecting PWD=pa££word;DATABASE=test_pyodbc;DRIVER={SQL Server};UID=test_pyodbc_unicode;Server=.\SQLEXPRESS
Connected OK
Fake work 0
Fake work 1
Traceback (most recent call last):
  File "./pyodbc_crash.py", line 40, in <module>
    main()
  File "./pyodbc_crash.py", line 35, in main
    for i in xrange(2):
UnicodeEncodeError: 'ascii' codec can't encode characters in position 6-7: ordinal not in range(128)

I can also reproduce with the latest code from master built with python setup.py bdist_wininst:
python version: 2.7.9 (default, Dec 10 2014, 12:24:55) [MSC v.1500 32 bit (Intel)]
pyodbc version: 3.0.11b8
Connecting PWD=pa££word;DATABASE=test_pyodbc;DRIVER={SQL Server};UID=test_pyodbc_unicode;Server=.\SQLEXPRESS
Connected OK
Fake work 0
Fake work 1
Traceback (most recent call last):
  File "c:\Users\day.barr\bromium-management-server\bin\python-script.py", line 66, in <module>
    exec(compile(__file__f.read(), __file__, "exec"))
  File "pyodbc_crash.py", line 40, in <module>
    main()
  File "pyodbc_crash.py", line 35, in main
    for i in xrange(2):
UnicodeEncodeError: 'ascii' codec can't encode characters in position 6-7: ordinal not in range(128)```

I believe all Unicode issues are fixed by the 4.0 release.

@mkleehammer I have just reproduced this using pyodbc 4.0.23.
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 35: ordinal not in range(128)
Can you please have another look ? :)

Issue still persists, using Python 2.7: UnicodeEncodeError: 'ascii' codec can't encode character u'\u2013' in position 18: ordinal not in range(128)


[Bug]: CLI fails to run apps

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
App
Expected behavior
it used to be that clicked the provided URL from the tool would take you to working Apps inside Shopify Admin. In this case, this App is not installed in the development shop, the database backed session table is empty, no cookies exist, this is state of the art Shopify App v20 and API v12 code.
Actual behavior
This CLI 3 tool is slow and busted it seems. All it does now is show this page not found. There is no entry in the Shop table for any previous sessions. All browsers, incognito included exhibit same behaviour.
The URL causing this issue is:
https://view-imaging-local.myshopify.com/admin/apps/3e9021d5f34f17b579e627571d22e181/login?shop=view-imaging-local.myshopify.com&host=Y3VsbHZpZXctaW1hZ2luZy1sb2NhbC5teXNob3BpZnkuY29tL2FkbWlu&return_to=%2F%3Fshop%3Dview-imaging-local.myshopify.com%26host%3DY2VsbHZpZXctaW1hZ2luZy1sb3NhbC5teXNob3BpZnkuY29tL2FkbWlu

Stack trace
Processing by HomeController#index as HTML
backend    |   Parameters: {"shop"=>"view-imaging-local.myshopify.com", "host"=>"Y2VsbHZpZXctaW1hZ2luZy1sb2NhbC5teXNob3BpZnkuY29tL2FkbWlu"}
backend    |   Shop Load (0.3ms)  SELECT "shops".* FROM "shops" WHERE "shops"."shopify_domain" = $1 LIMIT $2  [["shopify_domain", "view-imaging-local.myshopify.com"], ["LIMIT", 1]]
backend    | Redirected to https://a409166d60c4.ngrok.io/login?shop=view-imaging-local.myshopify.com&host=Y2VsbHZpZXctaW1hZ2luZy1sb2NhbC5teXNob3BpZnkuY29tL2FkbWlu&return_to=%2F%3Fshop%3Dview-imaging-local.myshopify.com%26host%3DY2VsbHZpZXctaW1hZ2luZy1sb2NhbC5teXNob3BpZnkuY29tL2FkbWlu
backend    | Filter chain halted as :check_shop_known rendered or redirected
backend    | Completed 302 Found in 9ms (ActiveRecord: 1.4ms | Allocations: 5646)

Reproduction steps

Operating System
MacOS
Shopify CLI version (check your project's package.json if you're not sure)
3.15
Shell
warp
Node version (run node -v if you're not sure)
v18
What language and version are you using in your application?
Ruby 3.1.2

You are correct. This was due to the errors in the underlying App and interactions with the platform, mostly in oAuth and especially with scoped permissions. I will end and close this issue with a warning that the response from this kind of underlying error, ie) that screen I posted here, is very uninformative and led me exactly zero degrees closer to my goal of a working App. Only a completely separate approach to debugging worked, so I will leave it here that the tools are far from effective at communicating the real underlying problems at this time.
It is hoped that with more effort, the tooling will be able to report things like "Hey, your underlying API key is wrong therefore fizzbuzz:, or "Hey, your permissions are being denied by Shopify", because even though those things are sort of handled, they are not cleanly handled at all.


Cannot read property 'forcePush' of undefined

Note: If your issue/bug is regarding the AWS Amplify Console service, please log it in the
Amplify Console GitHub Issue Tracker

Describe the bug
Before updating to latest version , it dont have any problem to push the resources to the cloud .
Amplify CLI Version
4.17.2
To Reproduce
Run amplify mock for the first time after creating the graphql resource and user pool resource
Expected behavior
It supposed push the resource to aws services  .
Screenshots
Screenshot provided
Desktop (please complete the following information):

Macos catalina V.10.15.3
Node version - v12.16.1

I observed a similar error while using Amplify Storage API and trying to run amplify mock. This error is observed when I run amplify mock without pushing the auth resources to the backend.
Screenshot of the error

However, now if I run amplify auth push the auth resources are pushed and updated in the backend. Amplify mock now runs as expected too!
Amplify CLI Version
4.17.1

@killallskywalker thanks for the report. I can confirm what @Jay2113 said, and just running amplify push before amplify mock works for now


gitlab ci generator

any plan on generating gitlab ci yml generator?
thanks for this great tool btw

Hello, we are working on a rewrite of the generator.
We don't use Gitlab at BAM but if you've managed to setup Gitlab CI with the generator, would you be willing to share the config with us?


Fastify 4

I've been using this with Fastify 3 so far – thank you! Unfortunately it currently does not work with Fastify 4.
The fix is just upgrading the version constraint in the plugin definition. This should be non-breaking.

Thanks! I'll check real quick to ensure backward compatibility then release against whatever semver is appropriate.


Add detach retries and forced detach after max retries

https://github.com/rancher/rancher/issues/9760

LGTM


Include rule S101 by default

Motivation
Assert statements in code are easily abused in the Python ecosystem and it is worthwhile to discourage their use by default.
Summary of desired enhancement
Select rule S101 in usethis tool ruff by default.

As a counter-argument, pyright uses assert statements as a way to assist the type checker. So perhaps more consideration needed as to whether this is really a good idea.


Migration Directionality Inverted?

Following a couple of test migrations, it appears that the direction of edges is inverted in Neo4J, from the direction they had in CosmosDB.
For example, in our Cosmos DB, we have an edge/rel labelled 'Themes' that goes out from Client node in to Theme nodes in Comsos, but, one imported into Neo4J, the relation Themes direction goes from Theme to Client.
This seems consistent across the migration from what I can see.

Hi, I've just committed #09f4a19ca6ad487a0aded7dc49674d8688dbcb65  which fixes this - it was inverted for all use cases :/


Doesn't detect XLSX when generated by OpenOffice/Googledocs

I just used this gem to detect files by content, and it works perfectly.
The only thing I detected is, that the Overlay features for xlsx, docx is only working for files generated by Microsoft Office. When they are exported by Google Docs or OpenOffice, they are not detected properly.
# Stunden.xlsx is exported from google docs
MimeMagic.by_magic(File.open('Stunden.xlsx'))
 => #<MimeMagic:0x00000003401ea8 @type="application/zip", @mediatype="application", @subtype="zip">

# ex03_Grade Report.xlsx saved by Microsoft Excel
MimeMagic.by_magic(File.open('ex03_Grade Report.xlsx'))
 => #<MimeMagic:0x000000033ea230 @type="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", @mediatype="application", @subtype="vnd.openxmlformats-officedocument.spreadsheetml.sheet">

To add to this, files generated by the RubyXL gem does also seems to be still detected as application/zip.
Please see the attached file.
hello.xlsx
What I am not sure is whether it's matter of you keep updating the overlays to support same file type generated by different tools or the tools generate the correct files to begin with

Ultimately what we did was to add another relaxed requirement to MimeMagic
x = ['application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', [[0, "PK\003\004",[[0..5000, 'xl/']]]]]
MimeMagic.add x[0], { magic: x[1] }

This would detect files generated using RubyXL correctly.

I've been working on something regarding this issue the past couple days. While these changes would work in a lot of cases, it didn't actually work in the case that I've been trying to fix. In my case, I have a spreadsheet that was modified by RubyXL and the resulting zip file has a .jpg file as the first one. In this case, it takes up way more than the first 3000 characters of the zip and breaks the magic.
Since we're using paperclip which has no option but to use MimeMagic, I have to fix this by manually re-ordering the zip file to have [Content_Types].xml up front, followed by at least on xl/ file. I feel dirty.

If order in zip file is not defined by specification of docx, xlsx or etc, this overlay should not be used anymore.

Guys I found an issue in bundled overlay.
When you call it like this MimeMagic.add(magic[0], magic: magic[1]) i.e. (extensions, parent and comment keys not specified) it overwrites MimeMagic::TYPES value with [], [], nil which is not very good. https://github.com/minad/mimemagic/blob/master/lib/mimemagic.rb#L27-L29
[
  [
    'application/vnd.openxmlformats-officedocument.presentationml.presentation',
    {
      magic: [[0, "PK\003\004", [[0..5000, 'ppt/']]]],
      extensions: %w[pptx],
      parents: %w[application/zip],
      comment: 'PowerPoint 2007 presentation'
    }
  ],
  [
    'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
    { magic: [[0, "PK\003\004", [[0..5000, 'xl/']]]],
      extensions: %w[xlsx],
      parents: %w[application/zip],
      comment: 'Excel 2007 spreadsheet' }
  ],
  [
    'application/vnd.openxmlformats-officedocument.wordprocessingml.document',
    {
      magic: [[0, "PK\003\004", [[0..5000, 'word/']]]],
      extensions: %w[docx],
      parents: %w[application/zip],
      comment: 'Word 2007 document'
    }
  ]
].each do |magic|
  MimeMagic.add(*magic)
end

I'm not fully sure if it is safe to match just by PK and word/ it may false trigger on zip containing word folder. It would be better to match by both magic and extension in conjunction.

Thanks @iRet I was banging my head against the wall on this one.
I am using Rails + Paperclip, and was finding that in my staging environment MimeMagic.by_magic was returning correctly in my development environment but not in my staging environment.
Adding an initializer to my Rails app with your code above did the trick.
Cheers!

@cameronbourgeois to be honest we've ended with patching paperclip to use file tool first and then mimemagic because method described above does false triggering on zip files which contains word folder inside for example.
Unfortunately there is no way to fix mimemagic of current version to use same logic as file tool since it doesn't support advanced features like relative offsets and so on. See magic file from file tool for more details.
https://github.com/file/file/blob/a25f230f1e7adf1632592d5c81a2d6cc86559c67/magic/Magdir/msooxml
I've been tracing paperclip commits and found that it has started to employ mimemagic to solve docx problems when it wasn't supported by file yet. Then this support has been added and after some time it was broken in mime magic in favour to improve detection.
I'm not sure if I am doing right leaving such comments here but if it will help some one, my temporary fix:
# Monkey-patch type_from_file_contents method to use 'file' tool rather
# than mimemagic gem to avoid 3rd party office software docs miss-detection.
# Mimemagic was introduced to support docsx but unfortunately its current
# version does not do it well and IMHO it won't be fixed in future.
# Though, paperclip may get rid of mimemagic completely.
# @see https://ituems.atlassian.net/browse/ETPO-828
module Paperclip
  class ContentTypeDetector
    def type_from_file_contents
      type_from_file_command || type_from_mime_magic
    rescue Errno::ENOENT => e
      Paperclip.log("Error while determining content type: #{e}")
      SENSIBLE_DEFAULT
    end
  end
end

# Above method has been initially taken from Paperclip 5.1.0.
# Please check current implementation and update fix in case it is still actual
# Otherwise remove it.
return if Gem.loaded_specs['paperclip'].version == Gem::Version.new('5.1.0')
warn '[WARNING] Paperclip has been updated. Check initializers/paperclip.rb'

Oh cool @iRet I was also considering the same monkey patch earlier, though I was finding that the file command is returning application/zip on my local machine despite getting the correct mime on my staging server 😆
I think for now I will stick with the MimeMagic quick fix as seems to be working in both environments. I should be safe from incorrect zip file as my app doesn't accept .zip file extensions and is also not open to general public. I've kept a comment and a link back to this thread with the solution I implemented with your help.
Thanks again - I hope others will also benefit from this thread :)


Add

Currently, there's no element for recording the name of the person/organization to whom a composition is dedicated.  Of course this can be marked up using name elements, such as <persName>, but an element would be helpful.

Closed by f4ce80f


tendermint v0.30.2 upgrade

Breaking changes since tendermint v0.28 with priv_validator.json. See more at https://github.com/tendermint/tendermint/blob/master/UPGRADING.md#v0280
upgrading using helper
go run $GOPATH/src/github.com/tendermint/tendermint/scripts/privValUpgrade.go $GOPATH/src/github.com/ovrclk/akash/_run/single/data/node/config/priv_validator.json $GOPATH/src/github.com/ovrclk/akash/_run/single/data/node/config/priv_validator_key.json $GOPATH/src/github.com/ovrclk/akash/_run/single/data/node/config/priv_validator_state.json


add html formatter

Problem Statement
Default option table provides pretty output in console using styles (colors, etc..) but when we save it into a file using --fileoutput styles will not be passed. If we share the output file to others via s3 or something, styles will be missed and looks plain. It would be nice to keep the styles when rendering from the file.
Solution
Default option table using Rich library and same library has function export_html to generate html from table output. It will keep the same styles used in default table formatter.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@aantn Could you please take a look at this PR?
Thanks


update sensitivity object reference

This is needed to override the default sensitivity value

I do not believe this is correct as circle and marker are the corresponding Google API objects which do not have sensitivity properties. this.circle.sensitivity returns an error.
Was there a particular problem you were trying to solve?

Thanks for coming back so quickly! Sorry, that's by bad, I updated both circle and marker, but only testing marker. I was having an issue with the marker using the default sensitivity of 0.01, even when passing in a new value as a prop (for example 1e-9 to make it more sensitive).

All good. So as far as I can tell it is working as expected. I put in :sensitivity="0.0000001" for a marker and while zoomed in to the max, on the move event I count not not trigger the event.
I'm not sure how you're not getting an error (but maybe without TS installed it lets you do it), but what I think your PR does is makes sensitivity always null (aka 0). You can achieve the same result with :sensitivity="0".
If you can demonstrate this not working would you be able to raise an issue for me to test?
TBH the whole sensitivity thing is a little flimsy, so would prefer not to have it; however it does cut down on a lot of events the majority don't want.

Ah okay, I see what's wrong... I'm passing sensitivity as an attribute on the options prop rather directly as a prop to the marker. This explains why it is being ignored in place of the default value on the marker and why I can find my passed in value on the Google API object instead. I've just corrected this, and it is again working in my setup.
Thanks for the help! :smiley:


Unresolved overloads when building docs

doxygenfunction: Unable to resolve multiple matches for function “bin” with arguments () in doxygen xml output for project “format” from directory: /home/travis/build/cppformat/cppformat/doxyxml. Potential matches:

- IntFormatSpec<unsigned, TypeSpec<'b'>> fmt::bin(unsigned)
- IntFormatSpec<unsigned long, TypeSpec<'b'>> fmt::bin(unsigned long)
- IntFormatSpec<LongLong, TypeSpec<'b'>> fmt::bin(LongLong)
- IntFormatSpec<int, TypeSpec<'b'>> fmt::bin(int)
- IntFormatSpec<long, TypeSpec<'b'>> fmt::bin(long)
- IntFormatSpec<ULongLong, TypeSpec<'b'>> fmt::bin(ULongLong)

Need to publish the packages with the docs as soon as it is fixed.

Fixed in https://github.com/cppformat/cppformat/commit/e4f7d0d3117cf8e805b0398caaf3a87fb237a5ef.


Cleaning up normalize

This replaces https://github.com/planetlabs/radiometric_normalization/pull/12
Instead of putting too much logic into this library to deal with every sort of situation that we might use the library for, we've decided to just directly call the library functions whenever it is used. Therefore less wrapper functions are required.

I moved the deleted code to a usage example in README.md. Looks ready for merge to me.


pretrained model requirst!!!

Can you release a pretrained model, and i have make your code, and trained on the wider face, however, the result is poor. Thank you!!

https://github.com/deepinsight/insightface/wiki/Model-Zoo

https://github.com/deepinsight/insightface/wiki/Model-Zoo

Thank you for your work!!


Tweak MPSC stress test

The test ran 10k iterations, and for each iteration it spawned a new thread. However, it did not wait for the thread to complete before starting the next iteration. This can result in a situation where
spawning the threads can run faster than the threads closing and overload the system.
This could have been the cause for #529, though I can't be sure. I was able to reproduce the test hanging by running the test on my laptop 8x in parallel. It ended up never completing due to threads being spawned faster than they could complete. Once I added the join in each iteration, the test completed in a reasonable amount of time.
I would recommend closing #529 and if the issue shows up again, we can investigate further.

Awesome, thanks!


Fix the handling of 'Display in Catalog' checkbox

For Catalog Bundle, we called default_entry_point method with wrong number of arguments, caused by change in https://github.com/ManageIQ/manageiq/pull/11103
2nd commit is optional, as I noticed exception also on 'generic' Catalog Item (not Bundle), when user try check the 'Display in Catalog' checkbox.
https://bugzilla.redhat.com/show_bug.cgi?id=1384759

@miq-bot add_label ui,bug

@jzigmund Looks good and I validated it is fixing the reported issue.  Just missing tests.

@gmcculloug added test for CatalogController#st_set_form_vars to ensure the methos sets default entry points

Euwe Backport details:
$ git log -1
commit 8e0da5a68dc3bd95f8e747492a4c136fb98428d7
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Tue Oct 25 14:22:50 2016 -0400

    Merge pull request #11996 from jzigmund/bz1384759-fix_saving_display_in_catalog

    Fix the handling of 'Display in Catalog' checkbox
    (cherry picked from commit d6a4904d6c63394d1819d700332b8110ea5a1d26)

    https://bugzilla.redhat.com/show_bug.cgi?id=1384759

@simaishi need Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1384759

Euwe BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1391138


fix ldlibs for berkeley-unix systems

Hi @skeeto
I had to adapt emacsql-sqlite-compile for berkeley systems. I'm running Freebsd:
$ uname -m -r -s
FreeBSD 11.0-RELEASE-p12 amd64

ELISP> system-type
berkeley-unix

The "-ldl" flag is not needed, as dl calls are provided by the libc on BSD systems.
Best regards.

Merged. Thanks!


feat: initial implementation of sample-client-python

Initial commit for sample python client
How to test

Start up server
uor-client-client serve test.sock
Setup and run client

pipenv shell
pipenv install
export UOR_SOCKET_ADDRESS=test.sock /. Default to /var/run/uor.sock
python3 sample_client.py push test/workspace localhost:5001/test:latest
python3 sample_client.py pull localhost:5001/test:latest testme
// This test attribute filter. The attributes pattern is by the gRPC client in this case
python3 sample_client.py pull localhost:5001/test:latest mytestdir --attributes='{"images": True}'

Signed-off-by: Jennifer Power<EMAIL_ADDRESS>

@sabre1041 Testing instructions added


Fix Expand Your Horizons link

Ooopsie, the 420 related prize has the old quuxapalooza link in it...

Closing as moot, this is not an active 2024 pointless prize.


Adopt text/template in node inspect

- What I did
Changed the node inspect code to use text/template instead of using Sprintf. This was actually one of the TODO task in that file - https://github.com/docker/docker/blob/master/cli/command/node/inspect.go#L81

@vdemeester make sense, spent some more time to understand service inspect. I could relate what I've submitted part of this PR. Let me refactor my code to align to cli/formatter package.

@vdemeester refactored the code using cli/formatter, PTAL at latest commit.

11:16:16 --- FAIL: TestNodeInspectErrors (0.00s)
11:16:16 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
11:16:16 	panic: runtime error: invalid memory address or nil pointer dereference
11:16:16 [signal SIGSEGV: segmentation violation code=0x1 addr=0xb0 pc=0x483a39]
11:16:16
11:16:16 goroutine 13 [running]:
11:16:16 panic(0x7ccb40, 0xc4200100a0)
11:16:16 	/usr/local/go/src/runtime/panic.go:500 +0x1a1
11:16:16 testing.tRunner.func1(0xc42007ad80)
11:16:16 	/usr/local/go/src/testing/testing.go:579 +0x25d
11:16:16 panic(0x7ccb40, 0xc4200100a0)
11:16:16 	/usr/local/go/src/runtime/panic.go:458 +0x243
11:16:16 github.com/docker/docker/cli/command/node.runInspect(0xc353c0, 0xc42007af00, 0xc4202e7aa0, 0x1, 0x1, 0x0, 0x0, 0x0, 0xc4202e7aa0, 0x1)

@vdemeester all jobs got passed except windowsRS1 one, not sure whats wrong with it.!

@vdemeester ping

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.


[BEAM-12583] Fix HarnessMonitoringInfoInstructionHandler to use the ShortIdMap properly

[BEAM-12583] Fix HarnessMonitoringInfoInstructionHandler to use the ShortIdMap properly
Use the MetricContainerImpl's getMonitoringData function on the process wide metric container.
(And no longer call getShortId while passing in a MonitoringInfo with the payload field populated.)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @kennknowles @aromanenko-dev
Would you please take a look, and merge if this looks okay.
This is the fix for: https://issues.apache.org/jira/browse/BEAM-12583

Run Java PreCommit

Just noticed that PR was created from master branch. I don't think it's critical (isn't it?) but better to create a feature branch for that.

I think its generally fine to do this, as its ajamato:master, which is separate from beam:master. I am not aware of any issues this will cause.
The only thing I can think of is that it might make it akward if I wanted ajamato/master to reflect beam/master for my work locally (Though that's not needed as I can always rebase from origin/master). But at this point I can rebase from origin/master and it should be back to the same state.
LMK if you had some other specific reason for to be concerned about doing it this way


Andrewjamesbrown/gemspecs

These two commits result in the CI build passing.  It removes several CS12 tests and adds a new _identifiers REST endpoint.

I'm not a huge fan of removing tests to make a build pass, but I think it is okay in the interest of getting https://github.com/chef/chef-zero/pull/117 merged.  @andrewjamesbrown if you will file an issue to have us remove the disabled tests I will set the milestone on that to the next minor release of chef-zero so we can make sure we get that accomplished before performing the release.  Then we can accept this and get #117 merged!


Dart's Await keyword is not working as expected in flutter web.

While trying to implement Firebase login, Dart's await keyword is not functioning as intended.
Dart version:  2.9.0-14.1.beta.
Flutter version: 1.19.0-4.2.pre ; channel Beta.
OS: Windows.
Browser: Chrome.
Here's the Login Function - Firebase Login :
  Future<int> userLogin(String mail, String password) async {

    int loginStatus = -5;
    print("Logging User In");

    try {

      print("Connecting to Firebase");
      _auth.signInWithEmailAndPassword(email: mail, password: password).then((firebaseUser)  {

        if(firebaseUser != null)  {

          UserDetails.currentUser = firebaseUser.user;
          loginStatus = 1;
          print("Login Successful");
          print("Current User - ${UserDetails.currentUser.email}");
        }
        else  {

          print("Login Failed - Null User");
          loginStatus = -2;
        }
      });
    } catch (loginError)  {

      print("Login Failed\n$loginError");
      loginStatus = -1;
    }

    return loginStatus;
  }

Here's the Hash Function - Writes data into FireStore :
  Future<int> writeHash ()  async {

    print("Writing Hash Document");

    DocumentReference studentHash = _firestoreInstance.collection("HashData").document("H");
    try{
      studentHash.setData({"ABCDEFG" : [UserDetails.currentUser.uid, "ABC", "123"]}).then((value) {
        print("Hash Document Updated\nvalue");
      });
    } catch (hashError) {
      print("Hash Document Updation Error\n$hashError");
    }

    return 1;
  }

This is how they are being called on button press:
onPressed: () async {
          loginStatus =  await<EMAIL_ADDRESS>"RandomPassword");
          print("loginStatus $loginStatus");
          await fireStoreOperations.writeHash();
        },

And here's the OutPut :
Logging User In
Connecting to Firebase
loginStatus -5
Writing Hash Document
Hash Document Updation Error
NoSuchMethodError: invalid member on null: 'uid'
Login Successful
Current User -<EMAIL_ADDRESS>
Here's flutter doctor in case it's of any relevance here:
[√] Flutter (Channel beta, 1.19.0-4.2.pre, on Microsoft Windows [Version 10.0.18363.900], locale en-US)
• Flutter version 1.19.0-4.2.pre at C:\flutter
• Framework revision 9b9b543d92 (11 days ago), 2020-06-22 12:19:28 -0700
• Engine revision 9a28c3bcf4
• Dart version 2.9.0 (build 2.9.0-14.1.beta)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\Achal\AppData\Local\Android\sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 45.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] IntelliJ IDEA Ultimate Edition (version 2019.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.2.3
• Flutter plugin version 45.0.2
• Dart plugin version 193.6911.31
[√] Connected device (2 available)
• Web Server       • web-server • web-javascript • Flutter Tools
• Chrome           • chrome     • web-javascript • Google Chrome 83.0.4103.116

Neither userLogin nor writeHash contains any await. Most likely they should.
It means that whatever asynchronous operations you are doing inside those functions, are not being waited for, and the functions return as soon as possible.

Tried it, and yes it worked. Thank you so much :)


feat(console-colors): Add a global config option to enable/disable colors in console

closes #1218

Awesome. ❤ this PR! I've changed one thing: allow for the value to be passed through the command line. As this argument has the most value on build servers, you probably want the value to be passed via command line (so you can share local configuration with build server configuration as much as possible).


Topology Manager

This is a Feature Request

What would you like to be added
Currently the topology manager options does take care of attaching the cpu cores to the local numa node, but it does not consider the pci device in case SR-IOV VFs are used. As in that case to get best performance we to align the pci device and cpu from the same numa node to avoid passing network packets over QPI links. This is very important for high network throughput applications specially telecom apps.
Why is this needed
As mentioned above we need to consider the pci device location too while selecting the proper numa node to place the POD. Without this there will be high performance impacts.
Comments

Raised the Feature request at the wrong place. Re-raised it in the proper forum.


v2.2.6 causes a fatal error

Issue description:
Fatal error: Cannot access parent:: when current class scope has no parent in ***Path_to_kirki***\includes\class-kirki-panel.php on line 24
Latest develop ebcd06f works okay.
Version used:
v2.2.6

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32298783-v2-2-6-causes-a-fatal-error?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github).

Yeah, that was an issue 'cause one of the files did not get uploaded to wordpress.org via SVN when I uploaded the plugin there.
The issue was fixed just 15-20 minutes later, so if you happen to have downloaded Kirki during those 15-20 minutes all you have to do it delete the plugin and re-download. :+1:
If the issue persists with a new download then I'm in trouble.

I didn't download from WordPress repository. I downloaded and used the master branch from GitHub.
Anyway, I just tried the master branch again. It's working now :+1:


Create a web server + front to host lisp-inference

This should be simple and inspired in the project ultralisp.org

It was done and is deployed at http://logic.lerax.me.
It still have issues about parsing the string to a list expression to be analyzed, but it working!


long_description does not render properly on PyPI

PyPI only renders RST, but invalid syntax is introduced when concatenating README.rst + CHANGES.txt + AUTHORS.txt.  I remember looking at PyPI in the recent past and seeing properly rendered text, so I think this breakage is relatively recent.

How can this issue be recreated? Looking on the PyPI website shows README, CHANGES, and AUTHORS in the correct order and correctly rendered (as far as I can tell).

@cmcnutt1 The content is present, but rendered as plain text instead of HTML.  Compare to Rasterio's PyPI page: https://pypi.python.org/pypi/rasterio

The https://pypi.python.org/pypi/Fiona/1.7.1 page looks fine and I didn't change anything. I wonder if the problem is that the 1.7.1.post1 sdist didn't make it to PyPI? See https://pypi.python.org/pypi/Fiona/1.7.1.post1#downloads. I think the wheels are just blobs as far as PyPI is concerned.

Turns out the problem was the asterisks at https://github.com/Toblerity/Fiona/blob/maint-1.7/CHANGES.txt#L28. I hacked a PKG_INFO file and uploaded it to PyPI to fix.


adding "Storage" as possible option for --destination-address-prefixes

adding "Storage" as possible option for --destination-address-prefixes

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afe4941c-7b46-b9fb-1c52-98e68f6354cc
Version Independent ID: d1bc72fb-ccf9-9645-7b1d-98c91bc75a55
Content: az network nsg rule
Content Source: src/azure-cli/azure/cli/command_modules/network/_help.py
Service: virtual-network
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S174

@aki0061 Thanks for raising this issue. I need some time to check it in detail. I'll keep you posted.

@aki0061 It seems that we don't do any check for this value and it should support Storage type.

Which kind of error did you meet?

@aki0061 any update?

Close it since this issue should be a false alarm.


feat: disallow duplicate submodule declaration

Description
This PR is heavily WIP, I am opening to discuss both the problem and solution.
closes #3947.
closes #3988.
TODO

[ ] Generate an actual compilation error
[ ] Remove filters added to forc-test
[ ] Fix this situation in standard library
[ ] Tests
[ ] Documentation

Problem
Duplicate dep declarations lead to duplicate entry points in the FinalizedProgram with different imm values and same Span. This was causing test entries to get duplicated. I guess this wasn't a problem until addition of unit testing, as other than test functions there is only the main function as an entry point(?). Also duplicate main declaration is something already checked.
So basically duplicate submodule declarations (through dependencies) are causing tests to be duplicated in the top level module. An example can be seen below:
graph TD;
    A-->B;
    A-->C;
    B-->C;

A, B and C are separate modules where in with A we have following declarations:
dep B;
dep C;

and in B there is:
dep C;

In a scenario like this entry points of C are duplicated in A. So any tests that are placed in C, is duplicated in the top most level A. This caused #3813. To solve that I added a hot-fix (#3986  and #4069) but in a small discussion over slack, sezna mentioned that this is something that should be a compiler error.
Solution
I constructed a graph from dep declarations. Such as the example given in the problem section and checked if any given node has more than 1 incoming edge. If there is one I am marking this dep declarations invalid and (will be) producing a compile error.
Checklist

[x] I have linked to any relevant issues.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[ ] I have requested a review from the relevant team or maintainers.

In the above example, if we had module re-exports, B could simply re-export (i.e: pub use C) C so A doesn't need to also import C.
I don't know wif this actually solves the issue at its root, but would be nice to have it regardless.

Note that this RFC proposes a full rework of how modules work and removes the dep keyword altogether in favor of mod, similarly to Rust.

Note that this RFC proposes a full rework of how modules work and removes the dep keyword altogether in favor of mod, similarly to Rust.

Really nice one, closing in favor of that as once that RFC is implemented, I guess this won't be needed.


Property is used before its initialization error is only shown during compilation when using ES2022 but is with ESNext

Bug Report

🔎 Search Terms

property is used before its initialization
esnext
es2022
before its initialization

🕗 Version & Regression Information

Does not seem to be a regression.

⏯ Playground Link
ESNext: https://www.typescriptlang.org/play?useDefineForClassFields=true&target=99&ts=5.1.0-dev.20230315&ssl=4&ssc=2&pln=1&pc=1#code/MYGwhgzhAEBiD29oG9oChqegIzAJ2gF5oAXACwEsIA6bAVwC8BuDLYeAOwhLzuBPh4AFAAc8FAG5gSAUxyMAXNDocA1h3gB3DgEoUAXzT6gA
ES2022: https://www.typescriptlang.org/play?useDefineForClassFields=true&target=9&ts=5.1.0-dev.20230315&ssl=4&ssc=2&pln=1&pc=1#code/MYGwhgzhAEBiD29oG9oChqegIzAJ2gF5oAXACwEsIA6bAVwC8BuDLYeAOwhLzuBPh4AFAAc8FAG5gSAUxyMAXNDocA1h3gB3DgEoUAXzT6gA
💻 Code
class Foo {
    bar = this.buz;
    constructor(private buz: unknown) {}
}

🙁 Actual behavior
TSC correctly produces the below compilation error when targeting ESNext. But does not when targeting ES2022.
TS2729: Property 'buz' is used before its initialization.

🙂 Expected behavior
The same compilation error is shown when targetting ES2022.

Hello Alan,
I was wondering if I can take this issue?

Go for it

It’s not a duplicate as those issues are closed and problem still persists.
It appears that the problem was only fixed for esnext.

Hey Alan!
I would like to work on this issue if anyone is not working on it.

@Dev79844, no one has opened a PR so far so feel free to open one.

Can confirmed this issue is happening with 5.0.4. Maybe related #50971 and #52331
ES2022 (and ESNext) implies useDefineForClassFields: true. TS2729 will happen if this option is set to true.
On ESNext, if you set the option to true it shows TS2729, and false doesn't. This is expected.
But on ES2022, even with useDefineForClassFields: true explicitly set to true, there are no TS2729 errors.

Hello Alan,
Is somebody working on this PR? I would like to contribute if it is available.

@alan-agius4  I  am new to opensource could you suggest how would I test the error.
I have set up the project locally

@Anshul-target, please see the contributing guidelines.

Hey @alan-agius4 does the PR #53885 fix this issue?

Hey @alan-agius4 does the PR #53885 fix this issue?

Looks like it


User Management | Allow BCeID users to edit their secondary user information |2|

https://trello.com/c/q2MVzQgr/814-user-management-allow-bceid-users-to-edit-their-secondary-user-information-2
Story:
As a BCeID user, I want to be able to edit my own secondary user information so that I can ensure it is up-to-date.
Scenario:
GIVEN that I am a BCeID user
AND I have not been assigned the Managing Users role
AND I am on the Settings page
WHEN I click on the "User Profile" sub tab
THEN I am able to view my user information
AND I am able to edit my "secondary information"
AND I am able to save the changes I make
AND saving the changes updates my secondary information throughout TFRS (i.e. user page off of the Company Details page)
User Profile:
PO is flexible in changing this label
Secondary Information:
Email, work phone and mobile phone
System Alert:
Please add a system alert to the completion of this action
Note:
Under this task, a BCeID user should only be able to edit their own secondary information, and not the secondary information of other users. In contrast, a BCeID user with the Managing Users role should be able to edit all users within its company.
Demo:

Show that a non-Managing Users user can edit their own secondary information

 User Management | Allow BCeID users to edit their secondary user information |2|