[WIP] Add button to allow CPS as input data source

@hdoupe this is how I'd like to add the CPS button. I'm having trouble to have those options displayed properly, even if for most part I was mimicking the "Start Year" button.

I'm confused why the button shows nothing: when I substitute start_years for data_sources, and start_year for default_source, the drop down does show different years as specified in constants.py. But I can't quite figure out why data_sources, default_source won't work.

@hdoupe Thanks! Conflicts are resolved.

Thanks @GoFroggyRun

Closing this in favor of #835


Unexpected error while scrapping

Trying to Scrap from Isracard and fron Hapoalim and got an  Unexpected Error:
$ israeli-bank-firefly-importer
[2023-07-14 01:18:37.977] DEBUG (85112): Config file './config.yaml' loaded.
[2023-07-14 01:18:37.978] INFO (85112): Starting Israeli Bank Firefly iii Importer
version: "1.3.7"
[2023-07-14 01:18:37.979] INFO (85112): Getting state from firefly...
[2023-07-14 01:18:38.560] INFO (85112): Getting scrap data...
[2023-07-14 01:18:38.563] DEBUG (85112): Scrapping...
options: {
"companyId": "hapoalim",
"startDate": "2018-07-13T22:18:38.561Z",
"args": [],
"combineInstallments": false,
"showBrowser": false,
"outputData": {
"enableTransactionsFilterByDate": false
},
"additionalTransactionInformation": true
}
[2023-07-14 01:18:38.565] DEBUG (85112): Scrapping...
options: {
"companyId": "isracard",
"startDate": "2018-07-13T22:18:38.562Z",
"args": [],
"combineInstallments": false,
"showBrowser": false,
"outputData": {
"enableTransactionsFilterByDate": false
},
"additionalTransactionInformation": true
}
[2023-07-14 01:18:45.829] ERROR (85112): Unexpected error while scrapping
options: {
"companyId": "isracard",
"startDate": "2018-07-13T22:18:38.562Z",
"args": [],
"combineInstallments": false,
"showBrowser": false,
"outputData": {
"enableTransactionsFilterByDate": false
},
"additionalTransactionInformation": true
}
error: {
"message": "Protocol error (Performance.enable): Target closed."
}
[2023-07-14 01:18:45.838] ERROR (85112): Unexpected error while scrapping
options: {
"companyId": "hapoalim",
"startDate": "2018-07-13T22:18:38.561Z",
"args": [],
"combineInstallments": false,
"showBrowser": false,
"outputData": {
"enableTransactionsFilterByDate": false
},
"additionalTransactionInformation": true
}
error: {
"message": "Protocol error (Performance.enable): Target closed."
}
[2023-07-14 01:18:45.839] ERROR (85112): hapoalim  failed with type GENERAL_ERROR: Protocol error (Performance.enable): Target closed., isracard  failed with type GENERAL_ERROR: Protocol error (Performance.enable): Target closed.
[2023-07-14 01:18:45.839] DEBUG (85112): Scrap result
results: [
{
"success": false,
"errorType": "GENERAL_ERROR",
"errorMessage": "Protocol error (Performance.enable): Target closed."
},
{
"success": false,
"errorType": "GENERAL_ERROR",
"errorMessage": "Protocol error (Performance.enable): Target closed."
}
]
[2023-07-14 01:18:45.840] INFO (85112): Getting or creating accounts...
[2023-07-14 01:18:46.278] INFO (85112): Manipulating...
[2023-07-14 01:18:46.281] INFO (85112): Getting firefly transactions to compare...
since: "2023-07-13"
[2023-07-14 01:18:46.688] DEBUG (85112): Got transactions from firefly
numberOfTransactionsFromFirefly: 0
since: "2023-07-13"
[2023-07-14 01:18:46.689] INFO (85112): Creating transactions to firefly...
count: 0
toCreate: []
[2023-07-14 01:18:46.689] INFO (85112): Updating transactions types to firefly...
count: 0
toTypeUpdate: []
[2023-07-14 01:18:47.074] INFO (85112): Updating last import...
[2023-07-14 01:18:47.451] INFO (85112): Done.

Hi @BenD780x9 ,
This issue is coming from the scrapper (israeli-bank-scrappers), please report about this issue or look for a solution there.
You might need to tune scrapper settings under config.yaml:
scrapper:
  options:

Please reopen the issue if need more assistant


Redesign Win32 build transition rules

Description
This reworks my previous commits, which aimed to make it configurable on which executable should be built with what build configurations (e.g. CRT link type, target CPU architecture).
One thing we need to further consider is the debug symbol name embedded in each artifact executable as noted in 0377ddd0b617c824b93d17e87bab028acc0ef3e7.
To generate debug symbols one can use generate_pdb_file feature. The issue is that the pdb filename is not configurable in rules_cc. For instance, if the target name is mozc_tip32, then rules_cc assumes that the output pdb file is always mozc_tip32.pdb. To make it mozc_tip32.dll.pdb, the target name must be mozc_tip32.dll.dll. This is why I had do rework Win32 build transition rules.
Implementation note:

The reason why mozc_win32_cc_prod_binary needs to be introduced is because the final executable name needs to be available as an input of mozc_cc_binary.
mozc_cc_win32_library also needs to be reworked so that generate_pdb_file feature will not be applied to it.

There must be no observable change in GYP build and non-Windows bazel builds.
Closes #1108.
Issue IDs

https://github.com/google/mozc/issues/1108

Steps to test new behaviors (if any)

OS: Windows 11 23H2
Steps:

bazel --bazelrc=windows.bazelrc build --config oss_windows --config release_build //win32/tip:mozc_tip32
cp bazel-bin\win32\tip\mozc_tip32.dll .
dumpbin /headers mozc_tip32.dll | findstr cv
Confirm mozc_tip32.dll.pdb is in the output.

Addressed all the comments then rebased onto HEAD.

Also squashed then rebased onto HEAD.

We have submitted bc546b239bccff494773104e108ba08fcff40d5b that is a part of this PR.
I hope it makes this PR focus on the essential part.
Could you please rebase this PR?
Thank you,


Plumber won't work

When error happening plumber doesn't say anything
var plumberErrors = function(err) {
  notify.onError({
    title    : 'Gulp',
    subtitle : 'Failure!',
    message  : 'Error: <%= error.message %>',
    sound    : 'Bee'
  })(err);

  this.emit('end');
};

....

    .pipe(plumber({errorHandler : plumberErrors}))
    .pipe(webpack({
      watch         : true,
      devtool       : 'source-map',
      entry         : {
        profile : './pages/profile.js',
        feed    : './pages/feed.js'
      },
...

@max-mykhailenko any idea of how to fix this?

I use clean webpack with this configuration https://gist.github.com/max-mykhailenko/6f4aa956ab4cbbed4ac2

FYI I had a similar problem when using eslint-loader, and I solved it by throwing an error in the reporter, and making sure that bail is set to true in webpack.config.js.
Ex:
module.exports = {
    bail: true,
    ...
    eslint: {
        emitErrors:true,
        reporter: function(errors) {
            throw new Error("Help!");
        }
    }
    ...
};


Spacebar Swipe Option for Cursor Positioning

Similar to the title of #243, it would be great to move the input cursor around left-to-right by simply swiping the spacebar.  Currently, this action looks to be solely responsible for changing the soft-keyboard input layout instead.  This is a killer feature of Gboard, in my opinion.  It is much rarer for me to change languages.  I also use mostly portrait mode now-a-days, so horizontal orientation arrow keys are not so helpful.

You can put arrow keys in portrait mode too:

That is true.  The 4 row Gingerbread layout is preferable, due to the ever-so-slightly bigger keys.  Otherwise, I end up with way too many typos.  I just think a setting to mimic Gboard, in this case ,would be a great enhancement, is all.


Updates to uk_ua.json; Added missing lowercase "є"

Added "maxFPS", "maxFPSUnlimited" and "debugCrashButton" translations
Minor fixes to previous translations

*Added missing lowercase "є", since i fat fingered the enter button somehow

I don't that's where the є character belongs according to unicode, but I'll check now

The font file definitely needs adjusting, but I can do that quickly, merging now.


Endpoint to retrieve register locations data from oracle

new oracle query api endpoint to retrieve register location data from sql DB

2 sonar code smells to fix - they look small


Game modes not changing

Game modes wont change for players. Upon a server restart game modes will change properly for a couple of hours then they will stop changing again. Cb version 1846 multiverse version 2.3. Here is my full server restart http://pastebin.com/X0x4GUmG and here is my permissions file http://pastebin.com/fWs44MBj.

I'm having this issue to.

Cannot reproduce. I'd imagine you've given your players the * perm. There are good reasons why Dinnerbone and the other SuperPerms advocates have stated this is a bad thing to do: Multiverse caveat with Gamemodes.

Ive had the same permissions for multiverse for months prior to this issue so I dont understand why this would be the cause of my problems considering multiverse had been working fine for a long time prior to this. Unfortunately I cant give logs with the debug mode on as I had to switch to another world plugin to fix the game mode issue. I personally like multiverse better but I couldnt continue to use it knowing game modes werent working for me which could ruin the legitimacy of my survival map.

Ok then. I'm going to close this issue for now then as could not reproduce, as I test this feature often and this feels a lot more like a configuration issue than a Multiverse bug.
Feel free to fire up a test server and post some logs and I'll re-open the issue. Thanks.


Allow hooking into $fetch (specifically for generic error reporting)

What problem does this feature solve?
The new fetch-hook uses a global try/catch in the nuxt core, and exposes the error only as a property inside $fetchState.error. Upstream, the error is now also emitted to the console on dev enviroments by default.
For production environments, currently the $fetchState.error can easily be used to handle errors in per component by checking for $fetchState.error in the component. However, there is no API available to have any sort of generic error reporting for any fetch-hook in the app.
However, for integrating with error-reporting tools like Bugsnag or Sentry, I'd want to be able to easily report any exceptions from any fetch-hook inside the App.
It would be great if there was a hook here we could use to add a specific implementation for Bugsnag, Sentry or another tool to any $fetch hook used in the app, while retaining the graceful error handling that's there now.
What does the proposed changes look like?
I don't really know how to implement hooks in the nuxt source, but I'd imagine the consumer API could look like this:
import Bugsnag from 'bugsnag';
this.nuxt.hook('app:onFetchError', (app, err)  => Bugsnag.notifyException(err));

This feature request is available on Nuxt community (#c10773)

Hi @FreekVR
Thank you for the feedback, right now we don't have Hooks for the Vue application and we planned them for Nuxt 3.
We can think of something like $nuxt.on('fetchError', (err) => ...) for Nuxt v2 since it is an instance of Vue.

Hey @Atinux ,
That seems fine too!  Even a configuration setting in nuxt.config.js could work, though in terms of DX using an events or hooks system probably makes more sense :)

Any news on this issue? It would be really great to be able to handle fetch errors globally.

Alright I managed to "catch" errors via a global watcher mixin:
      watch: {
        '$fetchState.error'(error: any) {
          if (error) {
            console.log(error)
          }
        },
      },

The problem now is, that the supplied "error" object is a custom nuxt object which unfortunately does not contain the original exception which was thrown. Any idea how I could get that original exception? It would be really great if that could be added.

@danielroe how would this be done in Nuxt 3? I have several points in my app where I send requests to my backend and I don't want to do error handling for common errors (such as unauthorized due to session expiry) on every call. I would love to handle it globally. However I could not find any hook that seems related to that. I've also tried adding my own wrapper around fetch but that causes it to lose type support.

We are approaching the Nuxt 2 EOL date (June 30, 2024) - see this article for more information. I'm closing this issue as it's marked as a Nuxt 2 related enhancement and it's not a critical issue.
That doesn't mean it might not be relevant for Nuxt 3. If it is, please feel free to open a new issue (or just comment, and I can reopen it). 🙏
Thank you for your understanding and for your contribution to Nuxt! 🎉

@danielroe still relevant for nuxt3


wrong emoji send :bug

Procedure to reproduce bug:-

open emojipicker

choose icon - "family Wwb" -  - (https://cdn.jsdelivr.net/emojione/assets/3.1/png/32/1f469-1f469-1f466.png)

now focusout from "emojionearea-editor"

then you see that you "family Wwb" -  icon is changed to "two girls with black and white and one coloured boy's icon" - 👩👩

Reason: -

when user focusout from  "emojionearea-editor" then  alt tag not create properly. two girls icon formed out side of  alt tag. please check below:-

👩👩

:frowning_face:

It seems, that this isue was not solved.
I have the same problem with the newest Emojionarea, MySQL is utf8mb4_unicode_ci and PHP connection is utf8mb4.
The problem is even before I send it to database, it depends not on PHP or DB do...
Some Emojis are allright, like "person playing water polo", but if I pick "men (or woman) playing water polo" immediately in the textarea I can see Emoji for "person playing water polo" + gender Emoji.
The same is with judge and another icons. Flags are OK.
If I save this to DB, emojione will display 2 icons, like I described.
I tried Emojis from JoyPixel an Twitter, with both I have the sam problem.

i confirm this bug. it is not to be fixed yet
@mervick do you think a fix is possible?

The release 5.0 of this https://github.com/joypixels/emojione/issues/654 don't solve this bug?


Could not find any Visual Studio installation to use after trying all the tips I could find online

Node Version: node -v=v12.18.3 and npm -v=6.14.8
Platform: systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type" (Windows)

OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.18362 N/A Build 18362
System Type:               x64-based PC

Compiler: msbuild /version & cl (Windows)

Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

<IP_ADDRESS>4Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27043 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

usage: cl [ option... ] filename... [ /link linkoption... ]

Module: zeromq

Verbose output (from npm or node-gyp):
me@me-PC0 D:\Desktop\myapp
# node-gyp configure --msvs_version=2017
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp info find Python using Python version 3.8.5 found at "C:\Python\Python38\python.exe"
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017"
gyp ERR! find VS - will only use this version
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\me\AppData\Roaming\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:310:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Apps\\nodejs\\node.exe" "C:\\Users\\me\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "configure" "--msvs_version=2017"
gyp ERR! cwd D:\Desktop\myapp
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v7.1.0
gyp ERR! not ok

Things I've tried to no avail

Reinstall VS 2017 with Desktop Development Kit for C++
Reinstall node and npm
Run the same command in Admin CMD, Admin PowerShell, Admin VC2017 Dev Command Prompt
Manually set VCINSTALLDIR environment variable to: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\
Run npm config set msvs_version 2017 --global, then npm config get msvs_version gives me 2017
Restart PC every step of the way

I got the same errors as above every step of the way.
Please help!

I've nuked my entire nodejs installation and started over. What I've done

Removed nodejs based on this StackOverflow answer.
Reinstalled nodejs x64 for Windows v12.18.3 using the .msi installer from official nodejs site, allowing the installer to install extra dependencies such as chocolatey
Created a blank electron app using electron-forge: like this

me@me-PC0 D:\Desktop
$ npx create-electron-app myapp
√ Initializing Project Directory
√ Initializing Git Repository
√ Locating custom template: "base"
√ Copying Starter Files
√ Initializing NPM Module
√ Installing Template Dependencies
√ Installing NPM Dependencies

me@me-PC0 D:\Desktop
$ cd myapp

me@me-PC0 D:\Desktop\myapp
$ npm start

><EMAIL_ADDRESS>start D:\Desktop\myapp
> electron-forge start

√ Checking your system
√ Locating Application
√ Preparing native dependencies
√ Launching Application

The app runs this way.
Problem
As soon as I added dependency: zeromq here

I also had similar issues recently and what helped me to locate the issue was running the npm command with --loglevel silly added, this gives you a whole lot more info printed out.
My issue was that there were some outdated (non-existing) paths in my LIB environment variable and that made node-gyp fail.

I also had similar issues recently and what helped me to locate the issue was running the npm command with --loglevel silly added, this gives you a whole lot more info printed out.
My issue was that there were some outdated (non-existing) paths in my LIB environment variable and that made node-gyp fail.

Thanks for the tip. Indeed, I shared the exact problem with you. I found out about it myself weeks ago the hard way and I really should've used --loglevel as you suggested.

I've nuked my entire nodejs installation and started over, but the problem persists.
Repro
I've nuked my entire nodejs installation and started over. What I've done

Removed nodejs based on this StackOverflow answer.
Reinstalled nodejs x64 for Windows v12.18.3 using the .msi installer from official nodejs site, allowing the installer to install extra dependencies such as chocolatey
Created a blank electron app using electron-forge: like this

me@me-PC0 D:\Desktop
$ npx create-electron-app myapp
√ Initializing Project Directory
√ Initializing Git Repository
√ Locating custom template: "base"
√ Copying Starter Files
√ Initializing NPM Module
√ Installing Template Dependencies
√ Installing NPM Dependencies

me@me-PC0 D:\Desktop
$ cd myapp

me@me-PC0 D:\Desktop\myapp
$ npm start

><EMAIL_ADDRESS>start D:\Desktop\myapp
> electron-forge start

√ Checking your system
√ Locating Application
√ Preparing native dependencies
√ Launching Application

Configured VS version that npm uses: npm config set msvs_version 2017 and npm config set msvs_version 2017 --global

The app runs up until this point. Then ...

Installed dependency zeromq

$ npm install zeromq --save-prod
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\extract-zip.cmd as it wasn't installed by D:\Desktop\myapp\node_modules\extract-zip
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\extract-zip as it wasn't installed by D:\Desktop\myapp\node_modules\extract-zip
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\rimraf.cmd as it wasn't installed by D:\Desktop\myapp\node_modules\rimraf
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\rimraf as it wasn't installed by D:\Desktop\myapp\node_modules\rimraf
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\semver.cmd as it wasn't installed by D:\Desktop\myapp\node_modules\semver
npm WARN rm not removing D:\Desktop\myapp\node_modules\.bin\semver as it wasn't installed by D:\Desktop\myapp\node_modules\semver

><EMAIL_ADDRESS>install D:\Desktop\myapp\node_modules\zeromq
> node-gyp-build

><EMAIL_ADDRESS>postinstall D:\Desktop\myapp\node_modules\core-js
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\@electron-forge\maker-deb\node_modules\electron-installer-debian):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin,linux","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\@electron-forge\maker-rpm\node_modules\electron-installer-redhat):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin,linux","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN<EMAIL_ADDRESS>No repository field.

+<EMAIL_ADDRESS>added 50 packages from 7 contributors, removed 32 packages, updated 401 packages and audited 460 packages in 61.306s

32 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Run electron-forge to build the Windows distribution.

$ npm run make

><EMAIL_ADDRESS>make D:\Desktop\myapp
> electron-forge make

√ Checking your system
√ Resolving Forge Config
We need to package your application before we can make it
√ Preparing to Package Application for arch: x64
× Preparing native dependencies: 0 / 1

An unhandled error has occurred inside Forge:
Command failed with a non-zero return code (1):
D:\Desktop\myapp\node_modules\electron-rebuild\node_modules\.bin\node-gyp.cmd rebuild --target=10.1.0 --arch=x64 --dist-url=https://www.electronjs.org/headers --build-from-source

gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS valid versions for msvs_version:
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:310:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\Desktop\\myapp\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=10.1.0" "--arch=x64" "--dist-url=https://www.electronjs.org/headers" "--build-from-source"
gyp ERR! cwd C:\Users\me\AppData\Local\Temp\electron-packager\win32-x64\myapp-win32-x64\resources\app\node_modules\zeromq
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v7.1.0
gyp ERR! not ok
Error: Command failed with a non-zero return code (1):
D:\Desktop\myapp\node_modules\electron-rebuild\node_modules\.bin\node-gyp.cmd rebuild --target=10.1.0 --arch=x64 --dist-url=https://www.electronjs.org/headers --build-from-source

gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS valid versions for msvs_version:
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:310:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\Desktop\\myapp\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=10.1.0" "--arch=x64" "--dist-url=https://www.electronjs.org/headers" "--build-from-source"
gyp ERR! cwd C:\Users\me\AppData\Local\Temp\electron-packager\win32-x64\myapp-win32-x64\resources\app\node_modules\zeromq
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v7.1.0
gyp ERR! not ok
    at ChildProcess.<anonymous> (D:\Desktop\myapp\node_modules\@malept\cross-spawn-promise\src\index.ts:155:16)
    at ChildProcess.emit (events.js:315:20)
    at ChildProcess.EventEmitter.emit (domain.js:483:12)
    at ChildProcess.cp.emit (D:\Desktop\myapp\node_modules\cross-spawn\lib\enoent.js:34:29)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>make: `electron-forge make`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>make script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\me\AppData\Roaming\npm-cache\_logs\2020-08-28T04_35_43_345Z-debug.log

Attempted to fix this by setting VCINSTALLDIR environment variable manually

set VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\

Then run electron-forge again

D:\Desktop\myapp>npm run make

><EMAIL_ADDRESS>make D:\Desktop\myapp
> electron-forge make

√ Checking your system
√ Resolving Forge Config
We need to package your application before we can make it
√ Preparing to Package Application for arch: x64
× Preparing native dependencies: 0 / 1

An unhandled error has occurred inside Forge:
Command failed with a non-zero return code (1):
D:\Desktop\myapp\node_modules\electron-rebuild\node_modules\.bin\node-gyp.cmd rebuild --target=10.1.0 --arch=x64 --dist-url=https://www.electronjs.org/headers --build-from-source

gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017"
gyp ERR! find VS - will only use this version
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:310:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\Desktop\\myapp\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=10.1.0" "--arch=x64" "--dist-url=https://www.electronjs.org/headers" "--build-from-source"
gyp ERR! cwd C:\Users\me\AppData\Local\Temp\electron-packager\win32-x64\myapp-win32-x64\resources\app\node_modules\zeromq
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v7.1.0
gyp ERR! not ok
Error: Command failed with a non-zero return code (1):
D:\Desktop\myapp\node_modules\electron-rebuild\node_modules\.bin\node-gyp.cmd rebuild --target=10.1.0 --arch=x64 --dist-url=https://www.electronjs.org/headers --build-from-source

gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017"
gyp ERR! find VS - will only use this version
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - found in "C:\Program Files (x86)\Microsoft Visual Studio 14.0"
gyp ERR! find VS - could not find MSBuild in registry for this version
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js:384:20
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at D:\Desktop\myapp\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:310:5)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1021:16)
gyp ERR! System Windows_NT 10.0.18362
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "D:\\Desktop\\myapp\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=10.1.0" "--arch=x64" "--dist-url=https://www.electronjs.org/headers" "--build-from-source"
gyp ERR! cwd C:\Users\me\AppData\Local\Temp\electron-packager\win32-x64\myapp-win32-x64\resources\app\node_modules\zeromq
gyp ERR! node -v v12.18.3
gyp ERR! node-gyp -v v7.1.0
gyp ERR! not ok
    at ChildProcess.<anonymous> (D:\Desktop\myapp\node_modules\@malept\cross-spawn-promise\src\index.ts:155:16)
    at ChildProcess.emit (events.js:315:20)
    at ChildProcess.EventEmitter.emit (domain.js:483:12)
    at ChildProcess.cp.emit (D:\Desktop\myapp\node_modules\cross-spawn\lib\enoent.js:34:29)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>make: `electron-forge make`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>make script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\me\AppData\Roaming\npm-cache\_logs\2020-08-28T04_40_16_364Z-debug.log

Also tried to hack the visual studio locator code of node-gyp at D:\Desktop\myapp\node_modules\node-gyp\lib\find-visualstudio.js

to insert amd64 to the lines

if (versionYear === 2017) {
        return path.join(info.path, 'MSBuild', '15.0', 'Bin', 'MSBuild.exe')
      }
      if (versionYear === 2019) {
        return path.join(info.path, 'MSBuild', 'Current', 'Bin', 'MSBuild.exe')
      }

- so that they become

if (versionYear === 2017) {
        return path.join(info.path, 'MSBuild', '15.0', 'Bin', 'amd64', 'MSBuild.exe')
      }
      if (versionYear === 2019) {
        return path.join(info.path, 'MSBuild', 'Current', 'Bin', 'amd64', 'MSBuild.exe')
      }

- Then run `npm run make` again. Same errors as previous step.

Here is my build environment
D:\Desktop\myapp>npm config get msvs_version
2017

D:\Desktop\myapp>npm config get python
C:\Python\Python38\pythonw.exe

Python 3.8 is the 64bit version from python.org.
Question
What am I missing? Should I forget about VS2017? My project uses VS2017 for the C++ development so I'm afraid I can't change that. But should I install VS2015?
It's confusing that on node-gyp README.md, it first says

Launch cmd, npm config set msvs_version 2017

Then later in How to Use, it then says:
Auto-detection fails for Visual C++ Build Tools 2015, so --msvs_version=2015 needs to be added (not needed when run by npm as configured above):

$ node-gyp configure --msvs_version=2015

What's with this version discrepancy?

did you find solution please help. getting same problem

@anujxx Check out initram's answer above.

A little late, but if it helps anyone:
https://stackoverflow.com/a/63311413

Deleting the package-lock.json file resolved the problem for me.
As far as I can tell, no node_modules/_package_/bin/* files were being downloaded. I'm not sure why this solved it for me, but there you go.

Deleting the package-lock.json file resolved the problem for me.
As far as I can tell, no node_modules/_package_/bin/* files were being downloaded. I'm not sure why this solved it for me, but there you go.

Did the work thanks!

Deleting the package-lock.json file resolved the problem for me.
As far as I can tell, no node_modules/_package_/bin/* files were being downloaded. I'm not sure why this solved it for me, but there you go.

WORKED FOR ME AFTER TRYING EVERYTHING!
As far as I can tell, no node_modules/_package_/bin/* files were being downloaded. I'm not sure why this solved it for me, but there you go.

WORKED FOR ME AFTER TRYING EVERYTHING! Just had to delete the package-lock.json file

did anything happen after deleting that file?

Ran into this pretty recently.  Completely reinstalling Visual Studio cleared it up.

Deleting the package-lock.json file resolved the problem for me.
As far as I can tell, no node_modules/_package_/bin/* files were being downloaded. I'm not sure why this solved it for me, but there you go.

@DeuxAlpha Appreciate it, Man!

Just follow the instructions at https://github.com/nodejs/node-gyp#on-windows like the error output suggests
For me, setting npm config set msvs_version 2017 was the missing piece

@lsharir thank you, this was my problem too.
Btw I also installed<EMAIL_ADDRESS>dependency, plus perhaps some VS C++ tooling, and then I needed to set the line that @lsharir provided, except my version was 2019. The error I was getting looked kind of like this:
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2017
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS checking VS2019 (16.10.31424.327) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS checking VS2019 (16.10.31424.327) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - msvs_version does not match this version
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS valid versions for msvs_version:
gyp ERR! find VS - "2019"
gyp ERR! find VS - "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - "2019"
gyp ERR! find VS - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Users\...\AppData\Roaming\nvm\v12.22.1\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:315:5)
gyp ERR! stack     at ChildProcess.emit (events.js:314:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1022:16)
gyp ERR! System Windows_NT 10.0.19043
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\...\\AppData\\Roaming\\nvm\\v12.22.1\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"

on my computer works with the next commands
npm install --g --production windows-build-tools
npm install node-gyp
npm audit fix
npm install node-phpass

Indeed, this appears to be a cross-platform issue and regenerating package-lock.json did the trick.
I have two machines, one running Ubuntu the other Windows. The former generated that file and I didn't encounter any issue. However when I tried installing the modules on the latter, that's when the issue occurred.
Do not install windows-build-tools as it is not only heavy but deprecated (and not needed).

Indeed, this appears to be a cross-platform issue and regenerating package-lock.json did the trick.
I have two machines, one running Ubuntu the other Windows. The former generated that file and I didn't encounter any issue. However when I tried installing the modules on the latter, that's when the issue occurred. Do not install windows-build-tools as it is not only heavy but deprecated (and not needed).

Thank you, having same error using Windows 11 with Node v14.15.1, removing package-lock.json solve the issue

I have tried every solution on this issue, but I am getting the same error. Can someone help me?

In your error log, what is the version on the line that starts with gyp ERR! node-gyp -v ?
Is it the same version as https://github.com/nodejs/node-gyp/releases ?

Came across exact same issue when trying to install fibers package globally.

npm -g install fibers

0 verbose cli [
0 verbose cli   'C:\\ProgramData\\scoop\\apps\\nodejs-lts\\current\\node.exe',
0 verbose cli   'C:\\ProgramData\\scoop\\persist\\nodejs-lts\\bin\\node_modules\\npm\\bin\\npm-cli.js',
0 verbose cli   '-g',
0 verbose cli   'i',
0 verbose cli   'fibers'
0 verbose cli ]
1 info using<EMAIL_ADDRESS>2 info using<EMAIL_ADDRESS>3 timing npm:load:whichnode Completed in 1ms
4 timing config:load:defaults Completed in 2ms
5 timing config:load:file:C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\npmrc Completed in 4ms
6 timing config:load:builtin Completed in 4ms
7 timing config:load:cli Completed in 2ms
8 timing config:load:env Completed in 1ms
9 timing config:load:project Completed in 0ms
10 timing config:load:file:C:\Users\fery\.npmrc Completed in 1ms
11 timing config:load:user Completed in 1ms
12 timing config:load:file:C:\ProgramData\scoop\persist\nodejs-lts\bin\etc\npmrc Completed in 1ms
13 timing config:load:global Completed in 1ms
14 timing config:load:validate Completed in 0ms
15 timing config:load:credentials Completed in 1ms
16 timing config:load:setEnvs Completed in 1ms
17 timing config:load Completed in 13ms
18 timing npm:load:configload Completed in 13ms
19 timing npm:load:setTitle Completed in 1ms
20 timing npm:load:setupLog Completed in 1ms
21 timing config:load:flatten Completed in 4ms
22 timing npm:load:cleanupLog Completed in 3ms
23 timing npm:load:configScope Completed in 0ms
24 timing npm:load:projectScope Completed in 0ms
25 timing npm:load Completed in 24ms
26 timing arborist:ctor Completed in 1ms
27 timing idealTree:init Completed in 7ms
28 timing idealTree:userRequests Completed in 3ms
29 silly idealTree buildDeps
30 silly fetch manifest fibers@*
31 http fetch GET 200 https://registry.npmjs.org/fibers 255ms (cache revalidated)
32 silly placeDep ROOT<EMAIL_ADDRESS>OK for:  want: *
33 silly fetch manifest<EMAIL_ADDRESS>34 http fetch GET 200 https://registry.npmjs.org/detect-libc 59ms (cache revalidated)
35 timing idealTree:#root Completed in 333ms
36 silly placeDep node_modules/fibers<EMAIL_ADDRESS>OK for<EMAIL_ADDRESS>want: ^1.0.3
37 timing idealTree:node_modules/fibers Completed in 4ms
38 timing idealTree:node_modules/fibers/node_modules/detect-libc Completed in 0ms
39 timing idealTree:buildDeps Completed in 340ms
40 timing idealTree:fixDepFlags Completed in 1ms
41 timing idealTree Completed in 352ms
42 timing reify:loadTrees Completed in 356ms
43 timing reify:diffTrees Completed in 1ms
44 silly reify moves {}
45 timing reify:retireShallow Completed in 0ms
46 timing reify:createSparse Completed in 3ms
47 timing reify:loadBundles Completed in 0ms
48 silly audit bulk request { fibers: [ '5.0.0' ], 'detect-libc': [ '1.0.3' ] }
49 timing reifyNode:node_modules/fibers/node_modules/detect-libc Completed in 61ms
50 timing reifyNode:node_modules/fibers Completed in 140ms
51 timing reify:unpack Completed in 140ms
52 timing reify:unretire Completed in 0ms
53 timing build:queue Completed in 1ms
54 timing build:link:node_modules/fibers/node_modules/detect-libc Completed in 6ms
55 timing build:link Completed in 7ms
56 info run<EMAIL_ADDRESS>install node_modules/fibers node build.js || nodejs build.js
57 http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/advisories/bulk 964ms
58 timing auditReport:getReport Completed in 965ms
59 silly audit report {}
60 timing auditReport:init Completed in 0ms
61 timing reify:audit Completed in 966ms
62 info run<EMAIL_ADDRESS>install { code: 1, signal: null }
63 timing reify:rollback:createSparse Completed in 20ms
64 timing reify:rollback:retireShallow Completed in 0ms
65 timing command:i Completed in 2048ms
66 verbose stack Error: command failed
66 verbose stack     at ChildProcess. (C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\@npmcli\promise-spawn\index.js:64:27)
66 verbose stack     at ChildProcess.emit (node:events:390:28)
66 verbose stack     at maybeClose (node:internal/child_process:1064:16)
66 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
67 verbose pkgid<EMAIL_ADDRESS>68 verbose cwd D:\Workspace
69 verbose Windows_NT 10.0.19043
70 verbose argv "C:\\ProgramData\\scoop\\apps\\nodejs-lts\\current\\node.exe" "C:\\ProgramData\\scoop\\persist\\nodejs-lts\\bin\\node_modules\\npm\\bin\\npm-cli.js" "-g" "i" "fibers"
71 verbose node v16.13.0
72 verbose npm  v8.1.4
73 error code 1
74 error path C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\fibers
75 error command failed
76 error command C:\WINDOWS\system32\cmd.exe /d /s /c node build.js || nodejs build.js
77 error gyp info it worked if it ends with ok
77 error gyp info using<EMAIL_ADDRESS>77 error gyp info using<EMAIL_ADDRESS>| win32 | x64
77 error gyp info find Python using Python version 3.10.0 found at "C:\ProgramData\scoop\apps\python\current\python.exe"
77 error gyp ERR! find VS
77 error gyp ERR! find VS msvs_version was set from command line or npm config
77 error gyp ERR! find VS - looking for Visual Studio version 2019
77 error gyp ERR! find VS running in VS Command Prompt, installation path is:
77 error gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio"
77 error gyp ERR! find VS - will only use this version
77 error gyp ERR! find VS checking VS2019 (16.11.31911.196) found at:
77 error gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
77 error gyp ERR! find VS - found "Visual Studio C++ core features"
77 error gyp ERR! find VS - found VC++ toolset: v142
77 error gyp ERR! find VS - found Windows SDK: 10.0.19041.0
77 error gyp ERR! find VS - does not match this Visual Studio Command Prompt
77 error gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
77 error gyp ERR! find VS looking for Visual Studio 2015
77 error gyp ERR! find VS - not found
77 error gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
77 error gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
77 error gyp ERR! find VS installation cannot be used.
77 error gyp ERR! find VS
77 error gyp ERR! find VS **************************************************************
77 error gyp ERR! find VS You need to install the latest version of Visual Studio
77 error gyp ERR! find VS including the "Desktop development with C++" workload.
77 error gyp ERR! find VS For more information consult the documentation at:
77 error gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
77 error gyp ERR! find VS **************************************************************
77 error gyp ERR! find VS
77 error gyp ERR! configure error
77 error gyp ERR! stack Error: Could not find any Visual Studio installation to use
77 error gyp ERR! stack     at VisualStudioFinder.fail (C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:122:47)
77 error gyp ERR! stack     at C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:75:16
77 error gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:363:14)
77 error gyp ERR! stack     at C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:71:14
77 error gyp ERR! stack     at C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:384:16
77 error gyp ERR! stack     at C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
77 error gyp ERR! stack     at C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
77 error gyp ERR! stack     at ChildProcess.exithandler (node:child_process:404:5)
77 error gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
77 error gyp ERR! stack     at maybeClose (node:internal/child_process:1064:16)
77 error gyp ERR! System Windows_NT 10.0.19043
77 error gyp ERR! command "C:\\ProgramData\\scoop\\apps\\nodejs-lts\\current\\node.exe" "C:\\ProgramData\\scoop\\persist\\nodejs-lts\\bin\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--release"
77 error gyp ERR! cwd C:\ProgramData\scoop\persist\nodejs-lts\bin\node_modules\fibers
77 error gyp ERR! node -v v16.13.0
77 error gyp ERR! node-gyp -v v8.4.0
77 error gyp ERR! not ok
77 error node-gyp exited with code: 1
77 error Please make sure you are using a supported platform and node version. If you
77 error would like to compile fibers on this machine please make sure you have setup your
77 error build environment--
77 error Windows + OS X instructions here: https://github.com/nodejs/node-gyp
77 error Ubuntu users please run: `sudo apt-get install g++ build-essential`
77 error RHEL users please run: `yum install gcc-c++` and `yum groupinstall 'Development Tools'`
77 error Alpine users please run: `sudo apk add python make g++`
77 error 'nodejs' is not recognized as an internal or external command,
77 error operable program or batch file.
78 verbose exit 1

That does not match this Visual Studio Command Prompt line is the only thing make me confused and have no clue whatsoever.
Any helps appreciated.

Tried to install it inside Developer PowerShell for VS 2019 and Developer Command Prompt for VS 2019 the issue still persisted.

Noticed I have sudo prefix? Yes, I'm using sudo package just for convenience. Once I ran the same command inside "native" Administrator mode, no issue.

But still, I can't get its running on PowerShell

Is this line

does not match this Visual Studio Command Prompt

really means I have to run in Elevated VS Developer Shell?

@feryardiant Running via a Powershell launched from VS 2022's Tools > Command line > Dev powershell is what finally got it working for me once I got to this point


Dev changes

Fixed up #143
Used default=? when available with the flask.request.args object.
pip-tools to manage dependencies.
Replaced pickles with feather files. I'm really just not a fan of pickles and would like to avoid them when I can. Pyarrow is only needed as a dev dependency to make this happen, so it doesn't add any bloat to prod.

Added some more things here:

@arutfield's flagging message support in the database.
I added a little more surrounding this and the live options in general, such as more tinkering with the admin view and support for Markdown editing.
FLASK_PORT for run_unix_dev.sh, mostly for personal use. I'm running something on port 5000 and the conflict is getting annoying.

Final round of changes for this batch.

Got rid of unnecessary warnings for tests. Tests are now fully passing!
Mostly resolved #136. The issue was related to the Time column changing from GMT-04:00 toGMT-05:00presumably after daylight savings. Ideally we will eventually want to handle all our datetime parsing throughout the whole app a little bit more carefully than we currently are, but for now this is fine.


Dir tree display "^G"

In left dir tree, left of every file name displayed "^G"

Environment

Operating System:
Vim version :version:
NERDTree version git rev-parse --short HEAD:
NERDTree settings applied in your vimrc, if any:

Process

Current Result

Expected Result

Screenshot(s)
Possible Fix

I still have this same issue even after updating today. Maybe this issue should be reopened?

I just tested and up to commit c905a5d7b87051e574c2e72fae57e56c456ba2f4 everything used to work fine. The next commit (ffa8be8) was the one that introduced this issue.

Just updated NERDTree and instantly hit this issue.
I get lots of ^G symbols as noted in the screenshot above.
My guess is that my font of choice, Iosevka, possibly has a character defined at \x07?
It is definitely true that Iosevka has a no glyph defined at \u00a0 as seen here in the Latin-1 supplement section.
This fixes the issue for me:
let g:NERDTreeNodeDelimiter = "\u00a0"

I am not sure changing the default node delimiter to the BELL character is an ideal choice.

Actually, it was not the font I was using, it was the because I had set conceallevel=0 for the NERDTree file type as follows:
autocmd FileType nerdtree setlocal conceallevel=0

Why did I do that?
I suspect I did it many many years ago to fix an issue where indentLine was being displaying in the NERDTree window. By turning off conceal, I suspect it disabled indentLine just within NERDTree.
I am not seeing any such weird interactions now between indentLine and NERDTree, once I removed that autocmd rule, AND the ugly ^Gs are also gone 😄
It may be worth noting that g:NERDTreeNodeDelimiter relies on conceallevel and it is best not to fool around with it for NERDTree.
All good now for me.

It may be worth noting that g:NERDTreeNodeDelimiter relies on conceallevel and it is best not to fool around with it for NERDTree.

Duly noted. I'll update the documentation.


[EmbeddingApi] Init xwalkview extension usecase android tests project

-Embedding API Usecase/usecase-extension-android-tests
-Create Crosswalk Android extensions using Java and extension usecase tests project
-Include echo extension & contact extension & echo jsstubgen extension & constructor jsstubgen extension
Impacted tests(approved): new 4, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 4, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4902
BUG=https://crosswalk-project.org/jira/browse/XWALK-4940

project build and export apk tests ok on locally.
@jennycao please help to review it.

LGTM

We will add the pack script for extension test pkg later.


[bug?] oai.samvera content harvesting error botocore.errorfactory.InvalidParameterException: An error occurred (InvalidParameterException) when calling the RunTask operation: Container Overrides length must be at most 8192 - registry ID 27768

The content harvesting task instantly fails for all map index pages when the content harvesting task begins to run. Is this a Rikolti issue or a Samvera (UCLA-side) issue?

oai.samvera
Registry ID: 27768
Run ID: manual__2024-05-03T23:44:52+00:00
permalink to airflow gridview
permalink to map index 0 log

[2024-05-07, 20:12:17 UTC] {{taskinstance.py:1824}} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/usr/local/airflow/dags/rikolti/dags/shared_tasks/content_harvest_operators.py", line 116, in execute
    return super().execute(context)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow/utils/session.py", line 76, in wrapper
    return func(*args, session=session, **kwargs)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow/providers/amazon/aws/operators/ecs.py", line 476, in execute
    self._start_wait_check_task(context)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow/providers/amazon/aws/hooks/base_aws.py", line 743, in decorator_f
    return fun(self, *args, **kwargs)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow/providers/amazon/aws/operators/ecs.py", line 493, in _start_wait_check_task
    self._start_task(context)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow/providers/amazon/aws/operators/ecs.py", line 543, in _start_task
    response = self.client.run_task(**run_opts)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/botocore/client.py", line 530, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/botocore/client.py", line 964, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.InvalidParameterException: An error occurred (InvalidParameterException) when calling the RunTask operation: Container Overrides length must be at most 8192
[2024-05-07, 20:12:17 UTC] {{taskinstance.py:1345}} INFO - Marking task as FAILED. dag_id=harvest_collection, task_id=content_harvesting.content_harvest, map_index=0, execution_date=20240503T234452, start_date=20240507T201216, end_date=20240507T201217
[2024-05-07, 20:12:17 UTC] {{logging_mixin.py:150}} INFO - Message sent to SNS with Message ID: acbc6eb1-d7f0-5997-9e1b-30055a913390
[2024-05-07, 20:12:17 UTC] {{standard_task_runner.py:104}} ERROR - Failed to execute job 116216 for task content_harvesting.content_harvest (An error occurred (InvalidParameterException) when calling the RunTask operation: Container Overrides length must be at most 8192; 1736)
[2024-05-07, 20:12:17 UTC] {{local_task_job_runner.py:225}} INFO - Task exited with return code 1
[2024-05-07, 20:12:18 UTC] {{taskinstance.py:2653}} INFO - 0 downstream tasks scheduled from follow-on schedule check

This is a rikolti issue.

We are fetching 7330 pages of metadata from this URL: https://digital.library.ucla.edu/catalog/oai?verb=ListIdentifiers&metadataPrefix=oai_dpla&set=member_of_collection_ids_ssim:k13t1n-89112

Data entry issue. The incorrect endpoint was placed in the collection registry, and the harvest job attempted to harvest over 188k records. Once the endpoint was corrected, the harvest job picked up the desired 5 objects: https://calisphere-stage.cdlib.org/collections/27768/


cmd/go: test -bench implies "chatty"

Consider the following invocations:
go test github.com/cockroachdb/cockroach/pkg/util/stop

go test github.com/cockroachdb/cockroach/pkg/util/stop -bench -

the two should ostensibly produce the same result, but the latter does not omit the output of successful tests as the former does. This does not appear to be documented anywhere.
A somewhat related issue was previously filed (https://github.com/golang/go/issues/10713) and closed with https://github.com/golang/go/commit/e9827f62018b87482e647dd88aecdedb24c94680, even though the behaviour appears to be global depending on the value of the -bench flag rather than based on the type of receiver of Log and Logf.

Possibly related to #17603?

Doesn't seem related to me.
On Nov 22, 2016 19:34, "Josh Bleecher Snyder"<EMAIL_ADDRESS>wrote:

Possibly related to #17603 https://github.com/golang/go/issues/17603?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/18010#issuecomment-262407479, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABdsPDdpHGMfPTWQSVXwUvqIIYVNCtCHks5rA4omgaJpZM4K4-HJ
.

Could you reproduce this on any of the standard packages?
And which version of Go are you using?

What do you mean by "the standard packages"? What does this have to do with the package being tested?
go version go1.7.1 darwin/amd64

Because I can't reproduce this in any of the std packages that I tried,
so I suspect that maybe it has something to do with the package
being tested.
Are you suggesting that difference in output is the extra "PASS"
at the beginning of the output? If that's case, it's working as intended
as if -bench is passed, even if none of the benchmark matches,
the testing package will still use the output format intended for
benchmarks.

@minux I think he means stdout/stderr produced by tests, which is hidden by go test.

Also, what is the reason for the inconsistency between -chatty and -v/-test.v in the docs?

I still don't understand what this issue is about.
$ cat a_test.go
package pkg
import (
"fmt"
"testing"
)
func TestA(t *testing.T) {
fmt.Println("Tstdout")
println("Tstderr")
t.Log("Tlog")
}
func BenchmarkA(t *testing.B) {
fmt.Println("Bstdout")
println("Bstderr")
t.Log("Blog")
}
$ go171 test
Tstdout
Tstderr
PASS
ok   pkg 0.001s
$ go171 test -bench -
Tstdout
Tstderr
PASS
ok   pkg 0.001s

@minux your example is exactly the problem. if you run go test (without -bench -) you will not see "Tstdout" nor "Tstderr".

@tamird but he did just there and it also prints.

Oh, it seems the behaviour is not so simple.
$ (cd foo && go test)
Tstdout
Tstderr
PASS
ok  	github.com/cockroachdb/cockroach/foo	0.005s
$ (cd foo && go^Cest)
go test ./foo
ok  	github.com/cockroachdb/cockroach/foo	0.006s
$ go test ./foo -bench -
Tstdout
Tstderr
PASS
ok  	github.com/cockroachdb/cockroach/foo	0.006s

...so if you specify a package name, stdout/stderr are swallowed, but if you don't, they are not. this is so inconsistent so as to be crazy.

OK, here are all four combinations:
$ go171 test pkg
ok   pkg 0.001s
$ go171 test pkg -bench -
Tstdout
Tstderr
PASS
ok   pkg 0.001s
$ go171 test
Tstdout
Tstderr
PASS
ok   pkg 0.001s
$ go171 test -bench -
Tstdout
Tstderr
PASS
ok   pkg 0.002s
I think this is all working as intended.
When -bench is not given,

with package name(s), go test only shows test summary
without package name, go test assume you're developing that package,
and want full output, so it doesn't suppress stdout/stderr.

When -bench is given, go test will always show stdout/stderr, even if it
doesn't match any of the benchmarks (this is because the benchmark
statistics is produced by the testing package, not by the go command,
so if the Go command wants to show you the benchmark result, it can't
hide the other output from the test.)

Working as intended by whom? None of this is documented, and none of it makes sense.
Why does supplying a package name suppress stdout? "go test assume you're developing that package" this is a rationalization, or something, because it's certainly not documented.

When -bench is given, go test will always show stdout/stderr, even if it
doesn't match any of the benchmarks (this is because the benchmark
statistics is produced by the testing package, not by the go command,
so if the Go command wants to show you the benchmark result, it can't
hide the other output from the test.)
That sounds like an implementation detail, not a sensible reason that for this behaviour. Again, it is not documented.

undocumented, perhaps, but it has always been this way since Go 1
so it's very unlikely to change.

why? it doesn't seem to me that any of this is covered by the Go 1 guarantee.

What do you want to change?
Tools are not covered by Go 1 guarantee, but we should at least
preserve existing behavior as much as possible (in case people
have existing programs that parse such output).

As the issue description states, I propose that the -bench flag not affect stdout/stderr suppression.

+1 I think the behavior currently in the code was actually not intended by the designer of this code, and I think anyone using the benchmarking code will welcome fixing this issue that has been there since Go 1.

Like @minux wrote above, this is working as intended (I designed and wrote the code, and this is what I intended). If running benchmarks, we stream the output from the benchmarks to make sure they are seen at all but also that they are seen as they happen.
The only option we've come up with is to make go test -bench run the binary twice, once for tests (quietly) and once for benchmarks (not quietly). That seems a bit odd, and a different special case (init code would run multiple times, and so on).

There are conflicting goals here, of course, but since this has been this way from Go 1, I'm inclined to keep things as is.


Be lenient with guard clauses

Rubocop is complaining on the following code:
class MyClass
  def my_method
    if @x
      method1
      method2
    end
  end
end

It prefers:
class MyClass
  def my_method
   return unless @x
   method1
   method2
  end
end

While this makes sense in many cases, 1/3 of the time it is much uglier.
Can we just remove this check?

Nah.  I actually like the guard clause stuff, because many cases fall into like your example.  And that 1/3 number sounds made up :)  For the rest just ignore it.  Rubocop is not a hard and fast rule except for the Ruby warnings and errors.

Do you have an example where it's uglier and rubocop complained?

Sounds good.
The example from @mkanoor that spurred this:
  # rubocop friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    return unless dest_class
    dest_class.destroy if @overwrite
    raise "Destination Class already exists #{dest_class.fqname}" unless @overwrite
  end

vs
  # rubocop un-friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    if dest_class
      dest_class.destroy if @overwrite
      raise "Destination Class already exists #{dest_class.fqname}" unless @overwrite
    end
  end

The @overwrite clause should probably be rewritten, but the return in the middle is odd to me:
  # rubocop friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    return unless dest_class
    if @overwrite
      dest_class.destroy
    else
      raise "Destination Class already exists #{dest_class.fqname}"
    end
  end

vs
  # rubocop un-friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    if dest_class
      if @overwrite
        dest_class.destroy
      else
        raise "Destination Class already exists #{dest_class.fqname}"
      end
    end
  end

The other example that spurred this:
  # rubocop friendly
  def check_duplicity(domain, ns, classname)
    return if domain.downcase    != @src_domain.downcase
    return if classname.downcase != @ae_class.downcase
    raise "Cannot copy class onto itself" if ns.nil? || ns.downcase == @partial_ns.downcase
  end

vs
  # rubocop not friendly
  def check_duplicity(domain, ns, classname)
    if domain.downcase == @src_domain.downcase && classname.downcase == @ae_class.downcase
      raise "Cannot copy class onto itself" if ns.nil? || ns.downcase == @partial_ns.downcase
    end
  end

return in the middle

That's exactly what a guard clause is 1 2.  It reads much nicer to me if you make a paragraph break after the guard clauses.  Part of the reason to go with guard clauses is to prevent hyper-nesting, particularly if the method is overly long or there are a significant number of guards.  If there is only 1 guard and it's otherwise a one-liner, you might as well just use a ternary statement than a guard clause. :smile:
Your example made even more guard clause-ish:
  # rubocop friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    return unless dest_class
    raise "Destination Class already exists #{dest_class.fqname}" unless @overwrite

    dest_class.destroy
  end

Thanks, space makes a big difference
  # rubocop friendly
  def validate
    dest_class = MiqAeClass.find_by_fqname("#{@target_ns_fqname}/#{@target_name}")
    return unless dest_class

    if @overwrite
      dest_class.destroy
    else
      raise "Destination Class already exists #{dest_class.fqname}"
    end
  end


Where to get DevEUI, AppEUI, and AppKey?

I am trying to follow your instructions, and I am confused about how I get the DevEUI, AppEUI, and AppKey for programming my mapper.
(Or alternately, is there a way to pull this info from an already configured board? I have an IOWe mapper that I believe was flashed with your code that they stopped paying for the DC's on.)

Answered my own question, when manually creating a device in the console it randomly generates those.
https://docs.helium.com/console/adding-devices/


Add Support for TokenMarker

I am looking to move from jidesoft.com code editor to RichTextFx. Few features I miss:

Support for TokenMarker. TokenMarkers are Java classes generated by JFlex lexical parser. See http://jflex.de/ and http://syntax.jedit.org/. I ask you to implement this because a good implementation will work very well on large files - the text verification will be done from the last line without any highglight till after the edited line, where the highlight is the same.

Add search / replace dialog directly to the editor. Having this directly build-in is a great advantage.

Consider features for editing large files. The best editors I saw, like the one from jidesoft can edit very large files, computing the lines and loading only the visible one. This feature may be pretty difficult.

Improve the sample application in your jar. When launching java -jar richTextFx.jar start directly the demo, and inside show all features you have.

@dprutean RichTextFX is meant as a base upon which others can build. As such, the lack of support for syntax highlighters and search/replace dialog is intentional.
As for the large files see #282. The feature you describe (as I understand it) is already implemented via an efficient VirtualFlow. See TomasMikula/Flowless

Improve the sample application in your jar. When launching java -jar richTextFx.jar start directly the demo, and inside show all features you have.

What do you mean by that? How should the sample application be improved?

Still is nice to have maybe an extra module ( jar ) with search/replace functionality. Everybody needs this. Also having at least a base class / some samples for few language parsers would be great. Maybe the most powerfull free parsers at the moment, for SQL, Java, Groovy, etc. Users who decide for ReachTextFx will need also a solution for this, and having at least something included is great. Many users will contribute to extend this base.
With improved examples I mean to simply double-click a jar ( could be a samples.jar ) and samples should start. There on different tabls should be few examples ( if different ). On one tab should show a checkbox for 'Show line number', 'show end line'- -maybe show end line markers in gray, etc.
Also a tab with source code for each example. A tab may be for showing behaviour on large files,etc.

Everybody needs this.

In my own project, I have no use for a search/replace functionality, though I understand why many others would want that.

Still is nice to have maybe an extra module ( jar ) with search/replace functionality. Everybody needs this. Also having at least a base class / some samples for few language parsers would be great. Maybe the most powerfull free parsers at the moment, for SQL, Java, Groovy, etc. Users who decide for ReachTextFx will need also a solution for this, and having at least something included is great. Many users will contribute to extend this base.

I understand your desire, but as soon as we would add that feature, then others would ask that we add more such features using similar justification as you are now doing. That would quickly fall out of the scope of this project: changes that help one such party here may provide inflexibility to other parties who use this code in a different way.
Tomas has shown in the demos package how RichTextFX could be built upon to add such functionality. So, although I wouldn't merge such features into the main project, if you wanted to create a demo that adds such functionality to the demo package, I would merge that.
In some ways, it would make sense to create a RichTextFXUtils project that could quickly augment the code here with such features.

With improved examples I mean to simply double-click a jar ( could be a samples.jar ) and samples should start. There on different tabs should be few examples ( if different ). On one tab should show a checkbox for 'Show line number', 'show end line'- -maybe show end line markers in gray, etc.
Also a tab with source code for each example. A tab may be for showing behaviour on large files,etc.

Are you suggesting something similar to the approach taken by ControlsFX's samples.jar?

Agree with you. I find the best if possible to create one more module in your project. It is an advantage to have them together. A good find/replace functionality is not simple, may include regexp, show of markers on the right of the text pane, shortcuts ( F3 search next ), etc.
Right, controlsfx-samples.jar is a nice sample. If you look in their source code they also use separate modules for samples and others. They have tabs for source code, also great.

Right, controlsfx-samples.jar is a nice sample. If you look in their source code they also use separate modules for samples and others. They have tabs for source code, also great.

We can discuss this further in the issue I've just opened.

Agree with you. I find the best if possible to create one more module in your project. It is an advantage to have them together....

Wait, so what are you agreeing with? I said we shouldn't merge such features into this project at all (which includes creating a separate module for that), but that seems to be what you are implying. Perhaps I wasn't as clear as I could have been?

As for large files, with the provided document representation (implementation of EditableStyledDocument), the whole document is still in memory. It's just that paragraphs that are not visible are not part of the scene graph.
👍  for some RichTextFX-Extras project.

Sorry for the last comment, is my mistake. Adding a search-replace functionality may also have a method to disable it: disableSearchReplace() - for users who wants to implement something else or simply disable.
This is like when buying a car : the producer may say "we don't put any radio in our cars, some of our customers doesn't need one or they can choose what they like". Still, I think is better to already have the radio inside, the time spent to find and put one inside is also important for me. Same with implementing new code.
Having a module in the same project has few advantages

may create a separate jar
is possitive for code mentenance, dependencies, etc.
is better for Google search ( more keywords pointing to one project )

Thank you also for the comment on large files. I plan to use the editor to edit SQL scripts, sometimes they can be database backups which are really large. The editor may stop to load text from the file if a certain limit is reached, and continue to load only if the scrollbar goes very down. Like facebook does when scrolling its content. Just think about it.

Adding a search-replace functionality may also have a method to disable it: disableSearchReplace() - for users who wants to implement something else or simply disable.
This is like when buying a car : the producer may say "we don't put any radio in our cars, some of our customers doesn't need one or they can choose what they like". Still, I think is better to already have the radio inside, the time spent to find and put one inside is also important for me. Same with implementing new code.

I see RichTextFX more as a supplier of auto parts that an automaker (i.e. developers) can utilize to build a fully-featured car (e.g. code editors). Being a parts-maker, RichTextFX does not have the goal of building a fully functional car. The fact that it provides StyledTextArea, which (to use your analogy) can function as a car, is an exception, not the norm.
RichTextFX's goal is to provide a rich text area base upon which others can build. Developer's use-cases, as is my understanding, generally falls somewhere in these categories:

a standard RichTextArea (because that is missing from standard JavaFX library)
a slightly-customized RichTextArea (overrides default behavior in some way) for a special use case
a base for a heavily-customized RichTextArea that includes non-text Nodes (images/emoticons, shapes, paragraph bullets, and tables).
a base for a code editor that uses a specific items to accomplish some tasks (e.g. syntax-highlighting)

With that being the goal, one concern is to not include "features" that may be useless for some users, inflexible for others, or otherwise complicate things for others unnecessarily. For example, features that may benefit some but annoy and/or complicate use-cases for others would not be desirable, such as implementing a specific syntax-highlighter.
The other concern is limited manpower and scope. Keeping the scope narrows makes it easier to fix bugs, which leads to stable code for everyone, and focuses the direction and manpower of the project, so that things actually get done rather than being talked about.
However, the last concern to keep in mind is whether a developer can implement a feature on top of the base. If the developer cannot, then I think it should be included in the project. Specifically, #222 comes to mind. How would a developer implement that on top of the base area? It is possible, but it would feel very hackery.
With those considerations in mind, should a search-and-replace feature be included? Here are my thoughts:

Since it can be implemented as a feature on top of the base which this project provides, it doesn't need to be implemented like the multiple carets/selections issue I mentioned above.
However, just because it doesn't need to be implemented directly in the code base, would it benefit enough users without hindering others to be worth it? Looking back at the four categories I mentioned above:

Category 4: Desirable, no doubt. One could include options for plain text, regex, within selection, etc.
Categories 1 & 2: May or may not be useful. For users like myself who don't need that functionality, it would make more sense to override the default behavior (assuming  SHORTCUT + F calls the search-and-replace method) than to disable it via method call.
Category 3: How it would be implemented? How do you search and replace an image, shape, etc.? If ignoring those items, how would you write the code to incorporate that use case along with the others? I suppose using generics and functional interfaces would work, right?

The code needed for this sounds like a lot of work, which will only increase this project's complexity when other features are merged. That increases the amount of time between stable releases.

This is why I think implementing the code inside a RichTextFX-Extras project would make more sense.

Closing due to being outside the scope of this project. I've also written an explanation of what "out of the scope of this project" means in the wiki


Switching oraclejdk7 to openjdk7 due to lack of support on trusty.

This is addressed in a github issue on the matter, summarised in
that all builds run on trusty that use oraclejdk7 as their jdk will
categorically fail.

Whelp, that one took me by surprise. Guess I have to figure out why gradle can't handle openjdk7 now.
Or support could be dropped for it?

Actually, near the end of this thread it basically says that there's a workaround involving build scripts like this, or a docker build like this.

Can this be merged-in asap @norbertpotocki? Other merge request builds are registering as failed because the travis build environment for jdk7 no-longer works. There are other options available (as mentioned in my comments above), but this takes care of it immediately.


feat: /when command

Adds a /when command which gives the user a basic message regarding the current status of various milestones. Currently has /when mobile and /when version2. Their texts definitely need to be updated but it's a start.

I love this idea, but I'd personally rather see if as an FAQ/KB section on the site and this command links out to that so we can "centralise" the messaging if that makes sense

One of the uses for this isn't just for the users to be able to get an update, but also so that me and Fabian can get the bot to generate a copy-paste friendly message that we can send to people when they ask for things like this

I'd rather /when mobile, copy-paste as a response to a user than have to type the entire message every time. I could save it to a .txt file, but felt I might as well just make it available to all


veresk.ruslan.org are not reachable via HTTP

Due to API Gateway peculiar support for custom domains, no redirection are done to HTTPS version, veresk.ruslan.org:80 simply refuses connection.
curl -v http://veresk.ruslan.org
* Rebuilt URL to: http://veresk.ruslan.org/
*   Trying <IP_ADDRESS>...
* Connection failed
* connect to <IP_ADDRESS> port 80 failed: Connection refused
*   Trying <IP_ADDRESS>...
* Connection failed
* connect to <IP_ADDRESS> port 80 failed: Connection refused
*   Trying <IP_ADDRESS>...
* Connection failed
* connect to <IP_ADDRESS> port 80 failed: Connection refused
* Failed to connect to veresk.ruslan.org port 80: Connection refused
* Closing connection 0
curl: (7) Failed to connect to veresk.ruslan.org port 80: Connection refused

https://github.com/amplify-education/serverless-domain-manager/issues/163

Clarification: only regional domains does not support HTTP to HTTPS redirection. Switching to edge domain solves this.


more unittests for code coverge

#278

Codecov Report

Merging #279 (14161f8) into master (8fe26ca) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   54.87%   54.96%   +0.09%
==========================================
  Files          29       29
  Lines        8170     8170
  Branches     1691     1691
==========================================
+ Hits         4483     4491       +8
+ Misses       3316     3308       -8
  Partials      371      371

Impacted Files
Coverage Δ

exetera/core/fields.py
76.17% <0.00%> (+0.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe26ca...14161f8. Read the comment docs.


CC:2022 allows "Conditional" requirements

These are our "Implementation-dependent" requirements. Should we change our name to "Conditional?"

Nope.


Fix field not validating after re-mount (#3566, #3500)

Because we do
return (
    !structure.deepEqual(values, nextProps && nextProps.values) ||
    !structure.deepEqual(lastFieldValidatorKeys, fieldValidatorKeys)
  )

in the defaultShouldValidate, we have to remove the field keys from the lastFieldValidatorKeys when Field is destroyed, otherwise on re-mount the key still exists and validation is skipped.
Should fix:
https://github.com/erikras/redux-form/issues/3500
https://github.com/erikras/redux-form/issues/3566

Codecov Report

Merging #3909 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3909   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          70      70
  Lines        1629    1631    +2
======================================
+ Hits         1629    1631    +2

Impacted Files
Coverage Δ

src/createReduxForm.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085b218...c33440d. Read the comment docs.

Hei @erikras @gustavohenke!
Could take a look at this PR please?
Quite important for us.


Use correct bit depth in nexus writing

When we write the VDS on the nexus file we should specify the data type of the data, currently we are just using the nexgen default. This datatype is the one that we get from the Eiger and send to Odin, see forward_bit_depth_to_filewriter.

This will also now mean that nexus writing depends on detector parameters being complete, worth thinking about

The best way to do this is probably emit a document with the bit depth when we arm the Eiger, this should be picked up by the NexusCallback.

Fixed by https://github.com/DiamondLightSource/hyperion/pull/1172


Regex commands

It'd be cool if we could use Regex's to make our commands more natural / smart.

@camasthecat  How didn't i think about it ?
Should the code only check if the regexp matches with the recognized text isn't ? The test function should do the trick:
/^([a-z0-9]{5,})$/.test('abc1');// False, then skip this index

/^([a-z0-9]{5,})$/.test('abc123');// True, then trigger command

Then we could add regular expressions with smart commands:
artyom.addCommands({
    indexes: [/hello/],
    // Enable wildcards and RegExps
    smart: true,
    action: (i) => {
        artyom.say("Hey, how are you today?");
    }
});

That'd be awesome, yeah! Funnily enough I've never used regex's before, but now I'll learn!!
This looks amazing!

Regular expressions in smart commands are available in Artyom V1.0.5.
Read the docs for more information


[AzureMonitorExporter] logging for backoff

Towards https://github.com/Azure/azure-sdk-for-net/issues/34581
Changes

log the interval whenever backoff occurs.

API change check
API changes are not detected in this pull request.


KeyVault.name is incorrectly documented.

The name property on KeyVault is documented as :
keyvault.ts
    /**
     * SKU name to specify whether the key vault is a `standard`
     * or `premium` vault.
     */
    readonly name: pulumi.Output<string>;

However it really is the name you'd expect it to be :
let appKeyVault = new azure.keyvault.KeyVault("big-bag-of-secrets", {
    name: "big-bag-of-secrets",
    resourceGroupName: resourceGroup.name,
    location: config.location,
    sku: { name: "standard" },
    tenantId: config.azureAdTenantId
});
appKeyVault.name.apply(x => console.log(x));

Diagnostics:
  pulumi:pulumi:Stack: dev-dev
    info: big-bag-of-secrets

fixed! perhaps by the recent terraform update.


Reinforce the need for version bumping

What is the purpose of this Pull Request?
The purpose of this PR is to reinforce the need for a version bump. Most code reviews I've done lately ended up in this request, including one in which the contributor (wrongly) claimed that a version bump wasn't need for his PR. Beyond that the release failed a couple of times (maybe because of the lack of a version bump) and I had to send things to PyPI manually.
What was done to achieve this purpose?
Added a few lines in the README.rst not only reinforcing that a version bump is needed, but explaining why it's needed.
How to test if it really works?
Read the diff, catch my typos, blame me, wait for my Fix typos commit, done.
Who can help reviewing it?
Anyone ; )

Look good to merge to me. :)

I would suggest putting it with "always" on the pull request template too (over the "do not forget").

Great idea, @giovanisleite — done in 0c34c21

I believe that this PR is ready to be merged.
@anaschwendler, could you help us with it?

I think that is clear enough now to see that the version bump is really necessary, even in minor cases, that is why we have minor bumps :)
Great @cuducos

Great @cuducos

Is anything missing for a merge?

No, I'll leave a last test check, and then I'll merge!

Clone the project

$ git clone git@github.com:datasciencebr/serenata-toolbox.git

Change to Toolbox folde:

$ cd serenata-toolbox

Change do @cuducos branch:

$ git checkout -b cuducos-reinforce-the-need-for-version-bump origin/cuducos-reinforce-the-need-for-version-bump

Merge with the master:

$ git merge master

Check the code locally, and it's fine!


examples/infinitescrole, examples/perspective: Doesn't work on BungBungame Photon 2

Reproduced on BungBungame Photon 2

Fixed


some functions or packages may be not include in the program

Dear authhor, when i run the mf_bayesian_optimization.ipynb, some error occured as follow
Cell In[3], line 9
6 from mfpml.models.scale_kriging import ScaledKriging
7 from mfpml.optimization.mf_acqusitions import (AugmentedEI, ExtendedPI, VFEI,
8                                                 VFLCB)
----> 9 from mfpml.optimization.mfbo import mfBayesOpt
10 from mfpml.problems.multifidelity_functions import Forrester_1a, mf_Hartman3
ModuleNotFoundError: No module named 'mfpml.optimization.mfbo'

Hello, I just updated the recent version, the notebook for multi-fidelity optimization is out dated, you can refer to the online documentation for case that used for this case https://jiaxiangyi96.github.io/mfpml/optimization.html#multi-fidelity-bayesian-optimization

Hello, I just updated the recent version, the notebook for multi-fidelity optimization is out dated, you can refer to the online documentation for case that used for this case https://jiaxiangyi96.github.io/mfpml/optimization.html#multi-fidelity-bayesian-optimization

ok，Thank you very much for open-sourcing and I salute you.


System level global webhook

I prefer to add system level global webhooks UI on admin panel. Administrators of gitea instance could add or remove system webhooks.
All system webhooks will not be displayed in repositories webhook settings ui but only displayed on admin panel. When an event is triggered, then all system webhooks, organization webhooks and repository webhooks will be requested.
A system webhook will help administrator to do statistics/backup/update depends systems and etc.

I think this is a duplicate of https://github.com/go-gitea/gitea/issues/4456

@Mikaela
#4456 calls for user webhooks, that are essentially notifications.
This, however, calls for admin webhooks, which would run for all repositories on the instance.

Actually it says:

Feature Request: support for personal webhooks and site-wide webhooks
...
It is also useful to have site-wide webhooks that react on all repos for those who want to do some "logging to slack" kinda stuff.

and I think site-wide webhooks and system level global webhooks are the same thing, but I don't mind either way and probably won't comment here further.


Include License File

Hi
In case you meant to publish this project as a Free and Open Source project under MIT license (which is mentioned in the gemspec), please include LICENSE file.

I just did. Thank you for mentioning this!


[SMALLFIX] Remove duplicated javadoc param in lineage.

We only need to document it once.

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/6409/
Test PASSed.


olric-load output is useless

Output of olric-load is misleading and math is wrong.  Here is some inspiration: https://github.com/tidwall/redbench/blob/master/bench.go

Done 53a459c0daa1f941781313248c29114c71400e5b


Number in red badge on certificate is not centered, red circle in the background is very small

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: iPhone 6s
iOS version: 15.0.1
App version: 2.11.1

Describe the bug
The number in the red badge on a certificate is very small and it is nearly cut off, also the number is not really centered
Here's a screenshot:

Here's a screenshot:
Steps to reproduce the issue

Add a certificate to the app but not through the QR code scanner on the "Certificates" tab but through the QR code scanner on the "Check In" tab
Click on the "Certificates" tab
See the text with the red badge "There is news about your certificates"

Expected behaviour
The red circle shouldn't be that small, rather match the size of the badge on the "Certificates" tab. The number should be centered and not cut off.

Internal Tracking ID: EXPOSUREAPP-9914

@ndegendogo

can you confirm that the 'crippled' appearance is related to the language setting?

Yes, confirm that.

@Ein-Tim could you test this? - Thanks!

Thanks for the ping @ndegendogo!
I can confirm that the issue has been fixed in version 2.14.1.
Thanks for fixing!
Closing.

@ndegendogo @Ein-Tim Thanks for report/fix/Feedback. Internal ticket set to CONFIRMED.


Adding documentation, dependencies and function signatures

See the full change in 'dev' branch for an overview.

Something seems to be wrong with Appveyor at the moment. The tests are passing locally.

Appveyor tests are passing again. Ignore the coverage, as I didn't add tests for this change. It will be better when the full change with tests are added.


Issue with the scrolling performance

In case of using animateTo or even jumpTo function to scroll the table to some target area, every single cell on the way will be rendered.
This feature is completely unusable when using for jumping to some area of a long list (500 items and more) as it will render every single cell on the way to the target. I would expect at least jumpTo function to avoid rendering every single cell on the way.

Thank you for submitting this great issue, it's a problem, but the render things are handled by flutter framework itself, I just wrapped ListView widget, jumpTo method is also ListView's, so I have no idea to improve the performance of this package currently, do you have any ideas about this? thanks

I‘m a new to the Flutter ecosystem as we all are :) Unfortunately it's hard for me to purpose some solution right away. I will look into this issue a bit later and purpose something if I will come up with some ideas.

If I want to use the refresh function, do I need to determine the height of each cell?

Here is the relevant discussion, just for reference https://github.com/flutter/flutter/issues/12319

thank you 😄
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年4月15日(星期一) 晚上6:25
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [Realank/flutter_section_table_view] Issue with the scrollingperformance (#5)
Here is the relevant discussion, just for reference flutter/flutter#12319
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@jizhigang no you shouldn't. height is necessary to calculate scroll offset related callbacks


Style "Do" and "Don't" "local" components

Acceptance criteria

Create local “react only” components for use in the design system website
** Do
** Don’t
Consider using the “Do” and “Don’t” react components created for storybook, get in touch with @chrisolsen for more information.
Figma designs

Closing as this has been completed in another repository (ui-components-docs)