 Any ideas how to make them work?

I think I have to alter the markup here a little bit because you can use autoplay="" attribute. Maybe data-autoplay=""?

Yes, being able to use data-autoplay="" to lazy-load autoplay videos would be awesome!

@mondalaci
I will only have time to do this after 10.10.19. In general it should be easy so you can give it a try.

Are you suggesting that I should implement this myself to test it? I would much rather wait for your implementation. It's not a pressing issue, and I better trust your code given your experience.

You can do this using the unveilhooks extension if you do something like this (or a data attribute), after it has changed the preload value to auto:
if(e.target.hasClass('autoplay') && e.target.autoplay != true){
  e.target.autoplay = true;
}

I just added the feature. You will need the following markup:
<video
	class="lazyload"
	preload="none"
	muted=""
	data-autoplay=""
	data-poster="poster.jpg"
	src="src.mp4">
</video>

Love your work @aFarkas

@aFarkas The latest lazysizes version has been integrated into the beta version of the aforementioned WordPress plugin, and I can confirm that it's working as expected. Thank you so much for the great work!

@aFarkas This is only working halfway for me. Using the markup above the following happens:
Chrome
the video doesn't start playing. When I add autoplay it works. But this way the video gets loaded twice when looking at the network tab. I suppose data-autoplay has to be changed to autoplay after the content is loaded?
Firefox
The video gets lazyloaded, but the poster doesn't fade out and the video doesn't start playing. When adding autoplay it works as well. But same issue with double loading the video like in Chrome.

@aerni
Could you please provide a testcase on jsfiddle, codepen, codesandbox or what ever.

@aFarkas Sure I can. To my clarification; Do you need the unveilhooks plugin to make this work or no plugin at all?

@aerni
yes, this is only available via the unveilhooks plugin.

@aFarkas - this appears to only work when you use src=, but not if/when you use multiple <source>'s - is that intentional?
Fortunately, in the case of the video I have on my site at the mo, I have a fairly well compressed .mp4 so have swapped it into the src and it appears to work fine! But if I wanted <source type="webm"><source type="mp4"> etc. this wouldn't work?

Also, interestingly (and I haven't had a chance to debug yet), the solution does not appear to work on iOS 13.2 - the video just never loads for me on Safari/Chrome/Brave (obviously, all use the same underlying engine)

@aerni  and @willstocks
I can't really reproduce your issues. Here is my testcase:
https://output.jsbin.com/qijoziq

Thanks @afarkas - I will take a look/will spin up a test case when I get
home.
For the time being, I don’t know if this helps:
https://willstocks.co.uk/ scroll down to the “MPOW” article (last one of
four)
On Mon, 18 Nov 2019 at 20:56, Alexander Farkas<EMAIL_ADDRESS>wrote:

@aerni https://github.com/aerni and @willstocks
https://github.com/willstocks
I can't really reproduce your issues. Here is my testcase:
https://output.jsbin.com/qijoziq
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aFarkas/lazysizes/issues/697?email_source=notifications&email_token=AKNX2AR66RRSPYOG5HS6DM3QUL6PRA5CNFSM4ITXC4UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEL4DYI#issuecomment-555205089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKNX2ATMHFPVBHFWJT7JTALQUL6PRANCNFSM4ITXC4UA
.

@aFarkas You're right. Your test case works as expected. I implemented your markup on my website but I still can't figure out why it's not working. The JS works as the class lazyloaded gets applied and the video lazyloaded. But the video just doesn't start playing.
See here: https://stage.michaelaerni.ch/en/work/hyve
Scroll down past the quote. There are two videos.

@aerni
As it seems to me you don't have included the unveilhooks plugin.

@aFarkas I do have it included. It's bundled with Webpack in the vendor.js.
import lazySizes from 'lazysizes';
import 'lazysizes/plugins/unveilhooks/ls.unveilhooks';

Funny enough; I just figured that it works fine when adding the unveilhooks plugin as an external script in my HTML like so:
<script src="https://afarkas.github.io/lazysizes/plugins/unveilhooks/ls.unveilhooks.min.js"></script>

Seems to be an issue with importing the plugin and bundling with Webpack?

@aFarkas - I've just taken a look at that testcase and it appears to work as expected. I believe that, for some reason, regardless of my markup including playsinline and -webkit-playsinline, these two items are being stripped from my output for some reason... weird
Otherwise, lazyloading of the video works fine everywhere else!

I can't really reproduce your issues. Here is my testcase:
https://output.jsbin.com/qijoziq

Hey @aFarkas the testcase is not working.
The lazyload is now working when the source is added in separate tag

Maybe this codepen will help someone - https://codepen.io/alex2407/pen/RwpJBJz
Some observations:

it is src, not data-src
it is data-autoplay, not autoplay
.container is purely decorative to create large enough viewport to avoid loading video immediately
unveilhooks plugin is included

Initial page load:

Scrolling down until lazyloading happens:

Maybe this codepen will help someone - https://codepen.io/alex2407/pen/RwpJBJz
Some observations:
* it is `src`, **not** `data-src`

* it is `data-autoplay`, **not** `autoplay`

* `.container` is purely decorative to create large enough viewport to avoid loading video immediately

* `unveilhooks` plugin _is_ included

Initial page load:

Scrolling down until lazyloading happens:

Ps. I have used a free placeholder video, in case it breaks any copyright let me know and I will replace it with anything else; it is meant to be purely educational w/o any copyright infringement intentions

I have just tested and the webm seems to be loading once I open the page. In theory, when you use src then of course browser will load it once the HTML is parsed.

I have just tested and the webm seems to be loading once I open the page

I have just tried and in my case, it opens when I scroll down to the video itself. I am on OSX with Google Chrome.

Doesn't seem to be SUPER happy on iOS (any browser - Safari, Chrome, Brave - all open the video full screen even when playsinline is set)

@willstocks are you suggesting there is a bug or issue with my sample code? To be honest, my code is not meant to be used as a ready-copy-and-paste solution. But rather a guideline or reference to get started. If you can reproduce the bug, I think it's better to raise it as an actual bug issue.

Hi @alexkuc - no, just lazyloaded video as a whole appears to still not be 100% happy autoplaying/playing inline on iOS. I did peek very quickly at your codepen, but I only see the poster image as I think webm video hasn't yet made its way to iOS (webm audio is though through a flag I think)

I am completly new to this and I am trying to lazyload autoplay videos in my shopify stroe.
Can someone guide me in the right direction on what I need to do ?

@gelsas there is a "How To" section in README.md

Hello everyone. I'm having the following markup
<video class="lazyload"
       preload="none"
       data-autoplay=""
       loop=""
       playsinline=""
>
    <source src="VIDEO_URL" type="video/mp4">
</video>

This setup works perfectly, as evidenced by the network tab showing that only 22 out of 60 videos load initially, with more videos loading incrementally as I scroll down (24, 26, 28, 30, etc.).
However, the problem arises when I add the muted attribute to the videos. When the videos have the muted attribute, it seems that lazysizes fails, and all 60 videos load immediately on page load. What could be causing this issue?
Please note the following:

The videos are dynamically added to the DOM.
I am using a masonry JavaScript library.
I have an IntersectionObserver that plays the videos when they enter the viewport and pauses them when they exit.

Thanks in advance for you help! @aFarkas


Parameter type checker tasks

Merging for now - we will review on the main PR anyway.

Linking #11 #20


Does this module works with ReactiveFormsModule

I know two types of forms in angular 2. Template driven forms and reactive forms. Here is a chapter about form validation in this form types. ng2-redux-form module works fine with template-driven forms. But if I use reactive forms with   formGroup and form controls, then ng2-redux-form module doesn't work. There is no actions @@ng2-redux-form/FORM_CHANGED on inputs changed.
Does this module work only with template-driven forms?

Yes. The purpose of the library is to enable you to build template-driven forms that are bound to Redux state. FormBuilder is bad and you can't use it with ng2-redux-form-controlled forms.


🙏 Export PostgrestResponse and PostgrestError types

Feature request
Is your feature request related to a problem? Please describe.
Would like to access the PostgrestResponse and PostgrestError types to allow for verbose typing within end application.
The await supabase.from(TABLE).select() (and similar) commands return a destructured PostgrestResponse  object.
There is no way to access this typing that I can see, either directly or indirectly (ie via the terminal @supabase/postgrest-js package index) which disallows the possibility of verbose typing, which is required by @typescript-eslint/typedef
Related error
TS2694: Namespace '"/frontend/node_modules/.pnpm/@supabase+supabase-js@1.11.10/node_modules/@supabase/supabase-js/dist/main/index"' has no exported member 'PostgrestResponse'.

Describe the solution you'd like
(Re)export the PostgrestResponse type from https://github.com/supabase/supabase-js/blob/master/src/index.ts
Given the @supabase/postgrest-js package is tightly coupled with @supabase/supabase-js, it seems architecturally ok to export from the main package to avoid developers having to import @supabase/postgrest-js directly (which is likely to end up out of sync with the underlying versioning, and in any case is not currently possible anyway)).
Describe alternatives you've considered
Currently, I am creating a local copy of the type, although naturally, this is not desirable long term for obvious reasons.
Suggested implementation

https://github.com/supabase/postgrest-js/blob/master/src/index.ts

import PostgrestClient from './PostgrestClient'
import PostgrestFilterBuilder from './lib/PostgrestFilterBuilder'
import PostgrestQueryBuilder from './lib/PostgrestQueryBuilder'
import { PostgrestBuilder, PostgrestResponse, PostgrestError } from './lib/types'

export { PostgrestClient, PostgrestFilterBuilder, PostgrestQueryBuilder, PostgrestBuilder, PostgrestResponse, PostgrestError }

https://github.com/supabase/supabase-js/blob/master/src/index.ts

import SupabaseClient from './SupabaseClient'
import { SupabaseClientOptions, SupabaseRealtimePayload } from './lib/types'
import { PostgrestResponse, PostgrestError } from '@subabase/postgrest-js'
import { User as AuthUser, Session as AuthSession } from '@supabase/gotrue-js'
export * from '@supabase/gotrue-js'
export * from '@supabase/realtime-js'

/**
 * Creates a new Supabase Client.
 */
const createClient = (
  supabaseUrl: string,
  supabaseKey: string,
  options?: SupabaseClientOptions
) => {
  return new SupabaseClient(supabaseUrl, supabaseKey, options)
}

export {
  createClient,
  SupabaseClient,
  SupabaseClientOptions,
  SupabaseRealtimePayload,
  AuthUser,
  AuthSession,
  PostgrestResponse,
  PostgrestError
}

:tada: This issue has been resolved in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

can we export all the other internal types too? I have a use case in my app, where i need the type PostgrestFilterBuilder because i build it in stages.  Can(Should) we just export the internal types?
Thanks


About the lag fix.

Even tho the game does feels more responsive with it enabled, I've read that it can cause issues for the opponent if they don't have it as well. Is that really a thing? I'm not using the FPS unlocker, only the the lag fix.

It makes your game enter everything one frame earlier, and so it sends into to the opponent that you've entered your inputs 1 frame earlier. This can cause 1 frame more of rollback on the opponent's screen. This is in effect "rollback netcode" everyone was asking for.


update_app_identifier is saving the Project.xcodeproj/project.pbxproj in XML format

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
After upgrading to Xcode 7.3, when running fastlane and trying to get the new build number by executing increment_build_number action we started getting the error below.
After some research we've found that after running update_app_identifier action the format of the project.pbxproj changed to XML while the one supported by agvtool it seems to be some sort for Json format now, so running increment_build_number or get_version_number won't no longer work as they are wrappers of agvtool.
This issue has appeared after migrating to Xcode 7.3, it seems before that was not an issue for agvtool or something.
So even if you try to run agvtool next-version -allor even agvtool what-version -terse manually, after a update_app_identifier action, they won't work as it's changing the format of the project.pbxproj file and avgtoolis not able to read it and returns 6.
After further look at update_app_identifier.rb it seems that it's parsing the project.pbxproj as XML, therefore when it saves it back it's saving it as XML (not 100% sure here).
Complete output when running fastlane, including the stack trace and command used
/Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.4****.2/lib/fastlane_core/ui/interface.rb:****27:in `crash!': [3****m[!] Exit status of command 'cd /Users/jenkins/.jenkins/jobs/orange_ios_alpha/workspace && agvtool next-version -all' was 6 instead of 0. (FastlaneCore::Interface::FastlaneCrash)
There does not seem to be a CURRENT_PROJECT_VERSION key set for this project.  Add this key to your target's expert build settings.

	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.4****.2/lib/fastlane_core/ui/ui.rb:****4:in `method_missing'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/helper/sh_helper.rb:44:in `sh_no_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/helper/sh_helper.rb:9:in `sh'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/actions/increment_build_number.rb:36:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:****43:in `block (2 levels) in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:****29:in `block in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:****28:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:****28:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/fast_file.rb:****49:in `method_missing'
	from Fastfile:69:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:********0:in `try_switch_to_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/fast_file.rb:****4****:in `rescue in method_missing'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/fast_file.rb:****36:in `method_missing'
	from Fastfile:27:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:52:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:46:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/runner.rb:46:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/bin/fastlane:38:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:****78:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:****78:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:****53:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.4****.2/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:****5:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/bin/fastlane:****58:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-****.80.0/bin/fastlane:****64:in `<top (required)>'
	from /usr/local/bin/fastlane:23:in `load'
	from /usr/local/bin/fastlane:23:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
.......
#Download all the certificates and provisioning profiles
    match(
      git_url<EMAIL_ADDRESS>      type: "enterprise",
      app_identifier: "com.xxxxx.Project-" + options[:distribution]
    )

    #Increments the build number
    build_number = increment_build_number

    #Gets current version number
    version_number = get_version_number

    #Updates the BundleID to get the proper app
    update_app_identifier(
      xcodeproj: 'Project.xcodeproj',
      plist_path: "Project-iOS/Info.plist",
      app_identifier: "com.xxxxx.Project-" + options[:distribution],
    )

    #Signs the app with the given identity
    gym(
      codesigning_identity: "iPhone Distribution: XXXXX, LLC",
      use_legacy_build_api: true
    )

    #Delivers to HockeyApp
    hockey(
      api_token: ENV["HOCKEY_API_TOKEN"],
        public_identifier: options[:hockey_app_id],
      notify: "0"
    )

    #Resets the App Identifier
    update_app_identifier(
      xcodeproj: 'Project.xcodeproj',
      plist_path: "Project-iOS/Info.plist",
      app_identifier: "com.xxxxxx.Project",
    )
......

Environment
fastlane version (fastlane -v): fastlane 1.80.0

Thanks for the report, we'll look into this.

Thanks @vpolouchkine, looking forward to it, as this is blocking our CI process.

@gbejarano01 I had a similar problem and after realising that fastlane depends on xcodeproj I noticed when installing cocoapods 1.0.0.beta.x (which I assume ships with a newer version of xcodeproj) it started working again.

We're suffering from the same issue. update_app_identifier turns the project.pbxproj into XML and then increment_build_number stops working.
We've swapped the order of these two steps to work around the issue (so now we increment the version number before we update the app id) but would be nice to have this fixed as it really messes up the pbxproj file.

@iamramin @s0mmer Only solution here, at least temporarily, we created different schemes and configurations and set a different bundle id for each one of those.
Instead of changing the bundle id through fastlane we have it there.

Thanks for following up. We are still looking into this over here and will update on this thread. 👍

As @s0mmer mentioned, this is related to the xcodeproj version. Please follow check out resolution in this issue .
Thanks for the detailed report. I'm going to close this one as a duplicate.

@asfalcone I don't use and I don't have a Gemfile, not sure if that's the solution for my problem.
The issue you're referring us to is about the ìncremene_build_numberwhile the issue I was referring to is on the update_app_identifier` action.
Does that make any sense?

@gbejarano01 Yes sorry I wasn't more clear. I believe the underlying problem to be with the xcodeproj gem. Both issues relate to that gem and using xcode 7.3 (and there is a detailed description of why we can't up the minimum version of xcodeproj required by fastlane in that issue).
Can you try updating to the beta version with gem update xcodeproj --pre.
Then try running update_app_identifier again. Please let me know if this helps!

@gbejarano01 Let me know if you get a chance to try out my suggestion from above! Thanks! 👍

@asfalcone Unfortunately we didn't have time to try, since we've found a workaround this is second priority now.
If it happens that we try, I'll let you know.
Thanks for helping us!

Updating the xcodeporj gem using gem update xcodeproj --pre does indeed fix this issue (the update_app_identifier no longer turns project.pbxproj into XML), but now we've got the versioning issue with cocoapods 😞

Hi @iamramin Thanks for letting us know. Can you file a different ticket for this Cocoapods issue if you haven't found a solution. Thanks


Finish AuthBDD cases, address the fallout

All reviews are resolved and all tests are back to passing.
I've added a single test, ``Registering a user should require a employee identifier(), and made it pass with somewhat far-reaching but simple changes to AuthenticationUtilities.register() and the calls it makes all the way down to PureMemoryDatabase.
The result is that we now require you to pass a (nullable) employeeId when registering a user. The idea being that a real-world user would be given some identifier by an administrator to use when registering themselves, which the system would use to link them to an employee pre-populated by the admin. It can, in the future, be more advanced than a simple integer, have password-level complexity, etc.


New modal option to support tall videos

New tall video modal option

Adds ability to display tall/portrait style videos in modal
Opt in feature - add modal-metadata block to fragment and apply new style "tall-video"

This new feature is enabled by adding a modal-metadata block to a fragment that will be used as a modal. Adding a new style value of "tall-video" will enable the feature.
This use case is for the Photoshop mobile launch.
Resolves: MWPW-162482
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/rclayton/tall-video?martech=off
After: https://modal-tall-video--milo--adobecom.hlx.page/drafts/rclayton/tall-video?martech=off

@spadmasa will this impact the footer modal at all?

Hi @salonijain3  , No impact on footer modal
https://main--cc--adobecom.hlx.page/creativecloud?milolibs=modal-tall-video#langnav

@spadmasa Updates pushed to correct tablet view.

Validation done on the pr , details are added in subtask (https://jira.corp.adobe.com/browse/MWPW-162855)
https://main--cc--adobecom.hlx.page/drafts/souj/carousel/editorialcards?milolibs=modal-tall-video

validation in devices
https://modal-tall-video--milo--adobecom.hlx.page/drafts/rclayton/tall-video?martech=off


Improve error message when resource name clashes.

Action, trigger and rule names must be unique within a namespace and package. It could be confusing to a developer that you cannot create an action with a name, if a trigger or rule already exists with them identifier.
Here's the error message that gets returned if you try to do this....
error: Unable to create action 'hello': Resource by this name exists but is not in this collection. (code 5000008)
Run 'wsk --help' for usage.

It would be helpful if the CLI could return the resource details ("Trigger with name ... already exists") to help users understand this issue.
Alternatively, a more helpful error message ("Actions, rules and triggers share the same namespace, check for those resources with that name.").

I believe this error message actually originates from the OpenWhisk controller.

It does. I’d close as duplicate of https://github.com/apache/incubator-openwhisk/issues/1684

It is, closing....


Provide built library

We cannot currently use this in our codebase, as we don't run node_modules through Babel, and we must target older browsers.  let and const don't work for us.
Can this be transpiled before being published to NPM?

No. Reasoning: https://github.com/sindresorhus/file-type/issues/70#issuecomment-268853935

Fair enough. I liked your suggestion to have a tool check the target of dependencies, and build when necessary.


Re-render with playlist fails

When I initially render the youtube component with a configuration playlist parameter, the player loads the playlist correctly. EG
return (
<YoutubePlayer
   playbackState='unstarted'
   height="350"
   width="875"
   configuration={{
      playlist: this.props.ids
   }}
/>
)

However, if I update the results, player stops playing, and just reloads the playlist that I originally had provided it. Not sure if I need to wait for the player to finish destruction or what not.

How do you solve playlist issue ?
How to show playlist using this component ?


Support RFC 8705 - OAuth MTLS

Hi,
Are you already supporting certificate based oauth client authentication (mtls) ?
Any plans to support it?
References:
OAuth MTLS : https://oauth.net/2/mtls/
RFC 8705: https://datatracker.ietf.org/doc/html/rfc8705
Thanks
Pradeep

All efforts are directed at preparing the v2 release, and no new features are planned right now.  However, we very much encourage Pull Requests if you want to take a stab at it.  I'll make a note to review this once I have v2 closer release-ready.

@pboling What do you think about removing this from the 2.0 milestone?
I found these references useful:

https://youtu.be/kRI5geKohjo?t=3035
https://auth0.com/blog/identity-unlocked-explained-episode-1/
https://backstage.forgerock.com/docs/ig/7/gateway-guide/oauth2-rs-introspect-mtls.html

Thinking aloud, I think to support RFC 8705, I wonder if we don't actually have to make any changes here. Client#get_token needs clientCertificate as a parameter.
I initially thought Client#connection needs to set up a connection with mutual TLS by configuring Faraday to use client_cert and client_key (https://github.com/lostisland/faraday/blob/21ac595919b0372b41386ae00640e16f73a20d31/lib/faraday/options/ssl_options.rb#L45), but I think that's only needed by the client accessing the resource.
It seems to me most of the heavy lifting of RFC 8705 is on the server side, which has to:

Retrieve the peer certificate from the TLS connection.
Verify that the cnf value matches the certificate used.

But I don't think this library needs to handle this?
It does look like Keycloak supports RFC 8705: https://www.keycloak.org/docs/17.0/server_admin/#con-advanced-settings_server_administration_guide

Oh, I think this can just be passed via connection_opts, so maybe nothing has to change in the code? We can document this:
client = OAuth2::Client.new('YOUR-CLIENT-ID', 'YOUR-CLIENT-SECRET',
  site: 'https://example.com',
  authorize_url: '/oauth/authorize/',
  token_url: '/oauth/token/',
  connection_opts: {
    ssl: {
      client_cert: OpenSSL::X509::Certificate.new(File.read('localhost.pem')),
      client_key: OpenSSL::PKey::RSA.new(File.read('localhost-key.pem'))
    }
  })

Relevant Keycloak pull requestsfor mutual TLS support:

https://github.com/keycloak/keycloak/pull/5083/
https://github.com/keycloak/keycloak/pull/5449

Thanks for looking into this @stanhu.  The documentation solution seems to be the right one.  Leaving this open as a reminder to add documentation.

@tnpradeep It appears the gem is already supporting OAuth MTLS.  Please try out the suggested config and report back!
client = OAuth2::Client.new('YOUR-CLIENT-ID', 'YOUR-CLIENT-SECRET',
  site: 'https://example.com',
  authorize_url: '/oauth/authorize/',
  token_url: '/oauth/token/',
  connection_opts: {
    ssl: {
      client_cert: OpenSSL::X509::Certificate.new(File.read('localhost.pem')),
      client_key: OpenSSL::PKey::RSA.new(File.read('localhost-key.pem'))
    }
  })


Fix the images in contributors.html

Many of the images are different sizes. Figure out a way to make all the images render at the same size with a height property or resize the images.

I can add some css fixes for the images

Happy to have your help @egpennington. I just ask that you sent commits and pull requests separately for each of the issues you are working on. Thank you!

Thank you!

Pull request made.
e

From: Michaella Rodriguez @.>
Sent: Wednesday, October 2, 2024 10:41
To: ScrimbaBootcamp/progress-tracker @.>
Cc: egpennington (애멧) @.>; Assign @.>
Subject: Re: [ScrimbaBootcamp/progress-tracker] Fix the images in contributors.html (Issue #99)
Assigned #99https://github.com/ScrimbaBootcamp/progress-tracker/issues/99 to @egpenningtonhttps://github.com/egpennington.
—
Reply to this email directly, view it on GitHubhttps://github.com/ScrimbaBootcamp/progress-tracker/issues/99#event-14489942270, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMWIYQP2OVAEQ4TA5PTHI6LZZQAYRAVCNFSM6AAAAABLRE4OZWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ4DSOJUGIZDOMA.
You are receiving this because you were assigned.


Set up associations

Project requirements

Create a class Classroom
Create the has-many/belongs-to relationship between Classroom and Student.
Create a class Book
Create a class Rental
Create the many-to-many (also has-many-through) relationship between Person and Book using the intermediate class Rental. The following should be implemented:

Create the has-many side of Book and Rental (a book has many rentals).
Create the belongs-to side of Rental and Book (a rental belongs to a book).
Create the has-many side of Person and Rental (a person has many rentals).
Create the belongs-to side of Rental and Person (a rental belongs to a person).
Modify the constructor of Rental so Book and Person are set in it.

thanks for your time @anagudelogu


⚠ ClamAV has degraded performance

In bf0855f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 76b8564.


link(origin, signature) should not work if recovered ethereum public key is not the intended ethereum public key

https://github.com/fragcolor-xyz/clamor/blob/81b96a78be0223d817ec2c1bc7a13cfb41eb261c/pallets/tickets/src/lib.rs#L333

found this while writing tests for Pallet Tickets

see the test case tests::link_tests::link_should_not_work_if_hashed_message_is_invalid

@sinkingsugar   - just to confirm - this is also bugged right? Thanks

Need to actually check
ensure!(!<EVMLinks<T>>::contains_key(&sender), Error::<T>::AccountAlreadyLinked);
// WE NEVER DO THIS
ensure!(<EVMLinks<T>>::get(&sender) == eth_key, Error::<T>::AccountAlreadyLinked);

As discussed, not a bug.

Can we close this? @sinkingsugar @aang114

I think so


Add JsonAdaptedReview

The code does not properly handle reviews yet, using JsonAdaptedStall as a placeholder. As Review has not been added as of this commit, this would use Stall in place of Review.
Let's add the JsonAdaptedReview class and properly work with the AddressBook to convert to and from the model and JSON.
This PR resolves issue #73.

Codecov Report

Merging #104 (221aa14) into master (eda4f5c) will decrease coverage by 2.08%.
The diff coverage is 29.11%.

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
- Coverage     63.97%   61.89%   -2.09%
- Complexity      373      377       +4
============================================
  Files            76       77       +1
  Lines          1288     1362      +74
  Branches        133      142       +9
============================================
+ Hits            824      843      +19
- Misses          434      482      +48
- Partials         30       37       +7

Impacted Files
Coverage Δ

...foodwhere/storage/JsonSerializableAddressBook.java
57.14% <7.69%> (-42.86%)
:arrow_down:

...main/java/foodwhere/storage/JsonAdaptedReview.java
27.58% <27.58%> (ø)

.../main/java/foodwhere/storage/JsonAdaptedStall.java
75.00% <29.41%> (-25.00%)
:arrow_down:

src/main/java/foodwhere/model/AddressBook.java
70.00% <42.10%> (-21.67%)
:arrow_down:

src/main/java/foodwhere/model/ModelManager.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

As of latest development, Stall has be updated to Review. The changes aim to reflect that.


Echo more progress and don't __clean on die

This will make troubleshooting stuck builds a bit easier.

LGTM 👍


Silence some warnings in gRPC code

What does this Pull Request accomplish?
Silences some warnings about iterator base type in gRPC code. These warnings seem innocuous, aren't in our code, and are pretty noisy.
Unfortunately the warnings I really wanted to fix are covered in protocolbuffers/protobuf#7103.
Why should this Pull Request be merged?
Reduce noise when compiling.
What testing has been done?
Built, verified warnings are gone.

One of the comments on the issue that you linked suggested putting all of the pb generated files in a subdirectory and ignoring warnings at that scope. Do you think we should try that for squashing the other warnings?

I think the generated files we want to ignore those warnings on are already in a subdirectory, but to ignore those warnings I think we'd have to split them out into a separate build (like a library or something). As much as the warnings annoy me I'm not sure it's worth that effort. But hopefully the upstream issue gets fixed soon...


Allow add for already exists DNS records.

Fixes #1139 and Fixes #1149.
Changes in this pull request:

Allow add for already exists DNS records.

Scenario:

Users can add the recordset in DNS change page. VinylDNS will notify with

if record data already exists =>  "No further actions require."
if record data does not exists =>  This will go for Manual approval. "RecordName "$name" already exists. Your request will be manually reviewed.  If you intended to update this record, you can avoid manual review by adding a DeleteRecordSet entry followed by an Add."

So I was testing locally and it seems like adding a totally new record to a zone results in a This record already exists. No further action is required. message. I was wondering if this is intended. Included some screenshots of that test below. Other scenarios seem to work as expected.

@nspadaccino Thanks for alerting me on this issue.
Reason for the issue:- For creating a new record, Vinyldns will first create a record, then it will try to validate the record already exists, then it will update the status as completed. (i.e. both already exists and newly created record has same message and same validations)
Solution:- Updated the message as "No further action required." Since its understood.


Allow write throttle to be changed at runtime

Also added some help in the bottom area for the time being

Codecov Report
Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 29.04%. Comparing base (07aa77d) to head (c77e526).
Report is 39 commits behind head on main.

Files
Patch %
Lines

hammer/hammer.go
0.00%
9 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #125       +/-   ##
===========================================
- Coverage   55.99%   29.04%   -26.95%
===========================================
  Files           8       15        +7
  Lines         759     1415      +656
===========================================
- Hits          425      411       -14
- Misses        265      925      +660
- Partials       69       79       +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[nrf fromtree] Bluetooth: UBSAN warnings fixes

Several warnings were reported by UBSAN when testing different Bluetooth LE features.
This PR fixes 3 different warnings.

CI in manifest PR is green:
https://github.com/nrfconnect/sdk-nrf/pull/13933


fix: use prefix instead of bin

npm bin was removed as part of npm v9.0.0.

:tada: This PR is included in version 1.16.27 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error BCP019: Expected a new line character at this location.

Bicep version
v0.4.1124
Describe the bug
Breaking change from the previous versions when passing values for array properties:
resource accessPolicy 'Microsoft.KeyVault/vaults/accessPolicies@2019-09-01' = {
  name: 'vault_example/add'
  properties: {
    accessPolicies: [{

Line "accessPolicies: [{" will throw "Error BCP019: Expected a new line character at this location." requesting a new line character between "[" and "{".

Interesting - I see same issue in v0.4.1019 (what I happened to have installed).
This is working:
resource accessPolicy 'Microsoft.KeyVault/vaults/accessPolicies@2019-09-01' = {
  name: 'vault_example/add'
  properties: {
    accessPolicies: [{}
    ]
  }
}

but this is not
resource accessPolicy 'Microsoft.KeyVault/vaults/accessPolicies@2019-09-01' = {
  name: 'vault_example/add'
  properties: {
    accessPolicies: [{}]
  }
}

When I upgrade to 1124, I get the BCP019 error with the first code snippet:

Related to #586


[rm2fb] update rm2fb with wait ioctl and no-op on rM1

this updates rm2fb with matteo's changes for rM1 compat, as well as adds the wait ioctl support. imo, it will need a bit of testing (locally and from outside people) before we merge it into stable.

Seems to work fine. I didn't specifically test the ioctl (I can do that later today).
I think this will be fine though. Just needs a version bump.

Could you test with Oxide to see if it resolves that issue?

Could you test with Oxide to see if it resolves that issue?

I can try it out too. Should I use the 2.1.2 PR? Or the current version in testing?

Could you test with Oxide to see if it resolves that issue?

I can try it out too. Should I use the 2.1.2 PR? Or the current version in testing?

Please test with the 2.1.2 PR.

It may contribute to fewer weird sleep screen contentions with oxide/decay, but it is hard to say as they were so intermittent before.

Some users were getting them quite often from what I understand.

Some users were getting them quite often from what I understand.

I definitely had times when I had to cycle it to sleep and awake a few times to get back to where I was. I can't recall it happening since this fix so I really do think it is solved (the no pin issue being different, as we've discovered).


flowcharting plugin dashboard kept open causes grafana memory issue and crash in chrome

Hi,
We've noticed that a dashboard holding a panel, build with the flowcharting plugin, is causing grafana (running on a ubuntu 20.04 LTS server) to steadily grow it's memory usage over a short time! This results in a grafana service crash on the Ubuntu server, when the dashboard is kept open (multiple hours). Important note is that this only happens when the dashboard is opened in Chrome (here on a Windows 10 OS), but does not to occur when the dashboard is opened in chromium edge on the same device.
The dashboard only contains one panel, build with the latest version of the flowcharting plugin, fetching data from a mixed data source (see environment description). I've added the dashboard json:
dashboard.json.zip
Could the memory issue in chrome be caused by the flowcharting plugin? In that case, could you investigate the difference between using both browsers?
I already opened this issue on the grafana github page, but was suggested to open an issue here instead.
https://github.com/grafana/grafana/issues/32205
Environment:
Google Chrome 89.0.4389.90 (Official Build) (64-bit)
Edge Chromium 89.0.774.57 (Official build) (64-bit)
grafana v7.4.2
flux & influx datasource (influx v1.8.4) & postgres datasource (v9.6)
grafana installed on Ubuntu 20.04 LTS
dashboard opened in Chrome on Windows 10 OS
grafana plugins: flowcharting plugin (v0.9) (https://grafana.com/grafana/plugins/agenty-flowcharting-panel/)

Hi,
Thanks for your patience,
I has made a pause for a new job, I try this configuration as soon as possible.
BR
Arnaud

hi，
We also encountered the same problem. When the blinking function is bound, the browser will crash after a period of time. Is this problem solved in the current version?


I am trying to downgrade node from 4.4.6 to 0.12.4. Nothing seems to work

I am trying to downgrade node from 4.4.6 to 0.12.4.
I had version 4.4.6 installed. I installed nodist the usual way (download the installer and install it).
i tried nodist 0.12.4,nodist local 0.12.4,nodist env 0.12.4 but none of them changed the node -v (node version always says v4.4.6). Also may be it does not change the node -v version, but i am doing it for
one npm module that worked in 0.12.4 but it still throws error. So i guess the node version hasn't changed at all. Please help me with this. Have i interpreted something wrong or am i doing something wrong? Please guide me. Thanks

Hi!
Did you uninstall node 4 before installing nodist?
On July 7, 2016 1:23:54 PM CEST, parthgandhi7<EMAIL_ADDRESS>wrote:

I am trying to downgrade node from 4.4.6 to 0.12.4.
I had version 4.4.6 installed. I installed nodist the usual way
(download the installer and install it).
i tried nodist 0.12.4,nodist local 0.12.4,nodist env 0.12.4 but none of
them changed the node -v (node version always says v4.4.6). Also may be
it does not change the node -v version, but i am doing it for
one npm module that worked in 0.12.4 but it still throws error. So i
guess the node version hasn't changed at all. Please help me with this.
Have i interpreted something wrong or am i doing something wrong?
Please guide me. Thanks

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/marcelklehr/nodist/issues/148

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Oh so i need to uninstall all node versions before installing nodist . i din't know that. So now do i have to uninstall all installed node version and nodist and then reinstall nodist? Do you have any proper guide on how to uninstall node completely from a windows 10 system. Thanks

Anyways thanks. i uninstalled node and reinstalled nodist and installed 0.12.4 node through nodist and it seems working fine . but i tried doing "npm install sails -g" but it seems the global modules are getting installed at some other default location so my console doesn't seem to recognize sails. Can you help with this?

ok https://github.com/marcelklehr/nodist/issues/66#issuecomment-69363749 this helped thanks


Attempt to preserve/sanitize positions

Currently the @bundle macro annotation will discard positions on resulting trees if -Yrangepos is enabled to avoid RangePosition validation errors. For improved IDE friendliness it might be useful to attempt to backport this logic from 2.11.x both for macro-compat's own macro, and also to wrap all user macro method calls to do the same.

As of c066786539fd9812ed83ab1dc204f49d15ee8b27 positions will be stripped from user macro result trees if -Yrangepos is enabled. This should prevent compiler crashes due to position validation errors, however it would be preferable to fix the positions as above.

See also this recent scalac commit.


Vernon Grocery Store BTM Robbery

https://www.castanet.net/news/Vernon/270823/Vernon-grocery-store-thieves-break-into-bitcoin-ATM
Vernon Grocery Store
November 19, 2020

2020?

Thanks, fixed the typo in the date


Add authentication to block header data

To prevent MITM attacks, we should add support to authentication of the block header. This does not eliminate the need to check the need to check the operator's data on L1, it is strictly a protection against MITM attacks.

Another alternative is to publish the operator's certificate somewhere (either hardcode in the client's, publish L1, something along these lines). And rely on the TLS handshake for both encryption + authentication.

I think there are 3 separate settings in which this is relevant and they may have different considerations:

Fully centralized: all clients connect to a single operator. This operator is the only one who can create new blocks. In this setting, we have the following options:
a. Include operator's signature with each block/block header.
b. Operator proves knowledge of pre-image as a part of the block kernel.
c. Rely on TLS handshake.
d. Maybe something else?
Semi-centralized: there is still only one operator who can create new blocks, but there is a P2P network of nodes, and clients can connect to various nodes. In this setting, I don't think we can rely on TLS handshake any more, but other approaches should work.
Fully decentralized: multiple operators can create blocks and there is network of P2P nodes to which clients connect. In this setting, we'd need a real L2 consensus mechanism.

For the first setting (in which we'll probably start out), I think TLS approach is probably the simplest one. For the third setting, we'll need a real consensus and that's a whole other discussion. However, for the second setting, I'm not sure what's the best option. Here are how I see pros and cons:

Using signatures: we'd need to enshrine some signature scheme in the protocol - something that ideally I'd like to avoid. On the other hand, signatures could be pretty small and easy to generate/verify.
Using proof of pre-image knowledge: this would be the simplest from the node standpoint, but might be expensive from the client standpoint. The main reason is that proofs are pretty large (probably will be over 100KB) and probably we want to avoid sending them with every block header.


fix: Use the same Typescript version as Flow

This should fix problems with multiple TypeScript versions being mixed and TypeScript 5.2 installed in node_modules/@hilla/something/node_modules

Updated


Bump service version from 2.13.0 to 2.14.0

Changelog: https://github.com/gnosis/safe-config-service/compare/v2.13.0...bump-version-2.14.0

Coverage remained the same at 99.205% when pulling f324a369f3b134abca68c474a366111da9245e79 on bump-version-2.14.0 into e1cf8354320006c59e8c4bb644790bb7bcf405e0 on release-2.14.0.


DreamFactory Middleware

Add DreamFactory as an open source middleware solution for IoT.

Hi, thanks for the contribution! 😄 It looks good to me, I'd like to perhaps create a Platform section later to integrate this kind of references. In the mean time let's keep it in the Middlewares section.


--list-devices sometimes shows things as Inactive when they are active

Describe the bug
Sometimes I see an inactive device that is active...
cconstab@tarial keys % sshnp -f @kryz_client -t @kryz_device -h @rv_am --list-devices
Searching for devices...
Active Devices:
  kryz_01 - v3.4.2
Inactive Devices:
  xmt_pi - v3.4.2
cconstab@tarial keys % sshnp -f @kryz_client -t @kryz_device -h @rv_am --list-devices
Searching for devices...
Active Devices:
  kryz_01 - v3.4.2
  xmt_pi - v3.4.2
Inactive Devices:
  [X] No devices found
cconstab@tarial keys %

Steps to reproduce

Just run sshnp --list-devices

Expected behavior
Show active devices as active - Is this a race issue ?
Screenshots
No response
Smartphones

Linux

Were you using an atApplication when the bug was found?
sshnp
Additional context
No response

Looks like there was a timeout, the way list devices determines whether a device is active or not:

Client reads atKeys to get all potentially available devices names
Client sends a notification to ping each device
Client waits 5 seconds for devices to respond
Client creates lists of devices that did (active) and didn't (inactive) respond

We could also go with the approach of checking whether the key is longer than 1 hour old (since it is designed to refresh every hour) but I would rather not, since it could report devices as active when they are not. I would much rather have devices report as inactive when they are, than active when they aren't.

@cconstab Should I instead have:
Active, Not responding, AND Inactive by implementing both strategies?

My guess is 5 secs is not quiet long enough for a sleepy Pi to spin up and get the notification back.
It seems to work once awake just fine. Remember it needs to do a lot of work to get a notication out if all the connections have timed out..
Perhaps double the timeout first ?

Perhaps double the timeout first ?

Added in one of my PRs


Support .jp-RenderedHTMLCommon CSS class

If one e.g. uses ipywidgets to wrap a DataFrame, the output area has no rendered_html class, but jp-RenderedHTMLCommon
Alternative
Using :is(.rendered_html, .jp-RenderedHTMLCommon) table would be a less verbose alternative that works in all current browser versions: https://caniuse.com/css-matches-pseudo

Thanks for this PR!
Do you have a small example for me to reproduce the problem?
Maybe we should include this in the example notebook in the docs?
There are already examples for DataFrame and for widgets, but not both at once.
Regarding :is(...): I don't have a preference.

An example would be this:
import pandas as pd
import ipywidgets as widgets

df = pd.DataFrame(...)

out = widgets.Output()
with out:
    display(df)

tabs = widgets.Tab(children=[out])
tabs.set_title(0, 'Test')
tabs

Thanks for the example, that's great!
I'll add it to the docs: #633

Perfect! Do you need anything more from me or is this ready then?

Thanks, that's all I need for now.
I'd like to have a look into the equations problem to see if there is any overlap, and then I'll come back to this.

I still don't understand why equation rendering doesn't work within widgets.
It should be enabled everywhere within output_area, but for some reason it doesn't seem to work.
Do you have an idea why that's the case?

No idea! Is that issue blocking this one? I’d assume this PR would be useful on its own.

No idea! Is that issue blocking this one?

No it isn't!

I’d assume this PR would be useful on its own.

Yes it is!

I could take a look anyway if you give me a pointer to where equations are handled

Equations are handled via MathJax, which is supposed to be activated on elements with the output_area CSS class:
https://github.com/spatialaudio/nbsphinx/blob/be3e63ebbb2e2beb934661508ea056fe33f747ca/src/nbsphinx.py#L1910
AFAICT, the widget outputs have this class, but somehow it doesn't seem to work ...


Add ReSharper 2019.1 support

v1.14.0 for ReSharper 2019.1 has been pushed to the plugins gallery (it usually takes a couple days before it's approved).


Develop

@sanjaynainani, could you please describe the purpose of this pull request? Thank you.

Hi Daniel
Sorry about that. It was a mistake. Please ignore.
Thanks
Sanjay Nainani
On Wed, Feb 3, 2016 at 3:26 PM, Daniel Weck<EMAIL_ADDRESS>wrote:

@sanjaynainani https://github.com/sanjaynainani, could you please
describe the purpose of this pull request? Thank you.
—
Reply to this email directly or view it on GitHub
https://github.com/readium/readium-js-viewer/pull/480#issuecomment-179136626
.


SqliteError message is not enumerable, test frameworks tend to ignore it

I created an issue in the ava test repo (https://github.com/avajs/ava/issues/2755) that explains how sqlite error messages are not shown. It looks like the cause of it is that the errors are not enumerable (see here https://github.com/JoshuaWise/better-sqlite3/blob/master/lib/sqlite-error.js#L13)
Errors end up looking like this:
  Error thrown in test:

  SqliteError {}

  › Database.prepare (node_modules/.pnpm/better-sqlite3@7.4.0/node_modules/better-sqlite3/lib/methods/wrappers.js:5:21)
  › test.js:7:6

Is there a reason error messages need to be not enumerable?

I don't think enumerability per se is the problem, see also https://github.com/JoshuaWise/better-sqlite3/issues/575#issuecomment-810831445
(new Error('test')).propertyIsEnumerable('message')
false
(new (class CustomError extends Error{})('test')).propertyIsEnumerable('message')
false

How does ava serialize the Error for printing? It looks like neither toString nor util.inspect

I've changed the code property to be enumerable, as of better-sqlite3 version 7.5.0.
Originally, I made it non-enumerable to match the message property that every error has. However, after reflecting on the Node.js and JavaScript ecosystem, I realized that custom properties of error objects are pretty much always enumerable, to aid in discoverability (i.e., so they appear when using console.log).


Issue Tracker: Refactor document change manager (remove dot-repeat hack)

We want to refactor two-way sync.

[ ] https://github.com/vscode-neovim/vscode-neovim/pull/992
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/543
[ ] if we send inputs using nvim_input, we can remove dot-repeat hack, composite escape, etc
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/543
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/625
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/644
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/1056
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/1068
[ ] https://github.com/vscode-neovim/vscode-neovim/issues/1187
[ ] https://github.com/vscode-neovim/vscode-neovim/pull/948

Here are my new ideas for removing dot repeat. I had some old ones at https://github.com/vscode-neovim/vscode-neovim/pull/992#issuecomment-1228734888, but they mostly involved trying to send edits to nvim in a way that would be picked up by dot repeat. Directly writing to dot repeat is going to be added to nvim at some point according to @justinmk, but not yet iirc.
My new idea takes inspiration from the way that many nvim plugins handle dot repeat: https://www.reddit.com/r/neovim/comments/wkqkzf/comment/ijownam/?utm_source=share&utm_medium=web2x&context=3
The challenge is that I need to construct a string to save in operatorfunc.
There are two strategies:

bind vscode type event and record keystrokes before sending them back to vscode. This is a major design decision but the performance should be good with the new extension affinity settings. Whenever an arrow key or cursor is moved, dot repeat is reset.
construct a set of typed changes by parsing the sequential editor changes produced by vscode, and trying to calculate what the user actually typed based on document changes. This is tricky however due to things like auto bracket pairs and discontinuous edits.

This should delete a lot of code.

I have narrowed it down to two options:
bind vscode type
I have figured out how to not break completions, and the lag seems acceptable.
The challenge
Edits come in both with type and onDocumentChanged. How can I merge them together? Ideas:

when type, wait for document changed, and cancel it out surgically
after sending type, do a diff from document changed and apply the diff instead
go back to syncing changes from a diff when leaving insert mode

parse documentChanges and convert to nvim_insert when applicable
I worked on this last year, and made some good progress. The roadblock was situations where you needed arrows, but now I have a solution. The code is pretty complicated for this though.

Closed, most content may be outdated. If there are new ideas, it's best to start a new discussion.


Bug in the update process: Calling the server.vbs file without explicitly specifying the windoes scripting host

During the automated update-process, the server is restarted using the the command: server.vbs
This works fine on systems where the VBS extension is linked to the scripting host cscript.exe or wscript.exe (That's the default windows-configuration)
But for security reasons and for easier debugging, there are systems where the default link for vbs is not linked to wsh or linked to another program like notpad++.
In that case the simple call "server.vbs" does not work or calls notepad++ instead.
solution:
explicitly call the vbs file using "wscript server.vbs"
then the update process runs through

I see, thank you for pointing that out. I'll take a look.

Added for 2.11.1, so the update after that should run smoothly then.


The new page is not completely displayed (Mobile)

Technical
WATT mobile profile
Description
The new page is not completely displayed.
Steps to reproduce

Create a new project in Design Editor
New Page Wizard -> Create the new page by a.html
Select the a.html

Expected behaviour
The new page is completely displayed.
Actual behaviour
The new page is not completely displayed.

I closed by https://github.com/Samsung/TAU-Design-Editor/pull/217


Error accessing file, this might be due to fastlane's directory handling

Issue Description
Started getting this error on one of our dev laptops. Same behavior with FL 2.62.0.
Complete output when running fastlane, including the stack trace and command used
Captured Output
Command Used: jenkins app:dwts
Output/Log

DEBUG [2017-10-19 00:20:23.08]: Checking if there are any plugins that should be loaded...
DEBUG [2017-10-19 00:20:23.08]: Loading 'fastlane-plugin-upload_symbols_to_new_relic' plugin
INFO [2017-10-19 00:20:23.11]: gem 'fastlane-plugin-upload_symbols_to_new_relic' is already installed
DEBUG [2017-10-19 00:20:23.12]: Loading 'fastlane-plugin-appicon' plugin
INFO [2017-10-19 00:20:23.15]: gem 'fastlane-plugin-appicon' is already installed
+------------------------+---------+------------------------+
|                       Used plugins                        |
+------------------------+---------+------------------------+
| Plugin                 | Version | Action                 |
+------------------------+---------+------------------------+
| fastlane-plugin-uploa  | 0.1.1   | upload_symbols_to_new  |
| d_symbols_to_new_reli  |         | _relic                 |
| c                      |         |                        |
| fastlane-plugin-appic  | 0.10.0  | android_appicon        |
| on                     |         | appicon                |
+------------------------+---------+------------------------+

WARN [2017-10-19 00:20:23.28]: Error accessing file, this might be due to fastlane's directory handling
WARN [2017-10-19 00:20:23.28]: Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details

bundler: failed to load command: fastlane (/Users/vamsee/Development/ruby/bin/fastlane)
Errno::ENOENT: No such file or directory - SW_VERS
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane_core/lib/fastlane_core/analytics/analytics_session.rb:194:in ``'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane_core/lib/fastlane_core/analytics/analytics_session.rb:194:in `operating_system_version'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane_core/lib/fastlane_core/analytics/analytics_session.rb:71:in `action_launched'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:64:in `run!'
  /Users/vamsee/Development/ruby/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in `run!'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane/lib/fastlane/commands_generator.rb:303:in `run'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/fastlane/lib/fastlane/cli_tools_distributor.rb:66:in `take_off'
  /Users/vamsee/Development/ruby/gems/fastlane-2.62.0/bin/fastlane:20:in `<top (required)>'
  /Users/vamsee/Development/ruby/bin/fastlane:23:in `load'
  /Users/vamsee/Development/ruby/bin/fastlane:23:in `<top (required)>'

DEBUG [2017-10-19 00:20:24.13]: All plugins are up to date

✅ fastlane environment ✅
Stack

Key
Value

OS
10.13

Ruby
2.4.2

Bundler?
true

Git
git version 2.13.5 (Apple Git-94)

Installation Source
~/Development/ruby/bin/fastlane

Host
Mac OS X 10.13 (17A405)

Ruby Lib Dir
/usr/local/Cellar/ruby/2.4.2/lib

OpenSSL Version
OpenSSL 1.0.2l  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.0.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/docs
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.58.0"

$:.unshift File.dirname(__FILE__)
require 'Onkore.rb'

default_platform :ios

platform :ios do
  before_all do

    ENV["FASTLANE_XCODE_LIST_TIMEOUT"] = "120"
    Onkore.setupEnv

    if ENV['FL_CHECKOUT']
        puts "Checking out code to ensure build directory is clean ..."
        sh("git checkout ../")
    end
    ensure_git_status_clean unless ENV['FL_NO_ENSURE_CLEAN']
    ENV["FASTFILE_DIR"] =  File.expand_path(File.dirname(File.dirname(__FILE__)))
  end

  desc "Parameterized Jenkins lane. If params are omitted will default to Bachelor"
  lane :jenkins do |options|
    cocoapods unless ENV['FL_NO_PODS']
    type = 'development'
    app = Onkore.getApp(options,type)
    match(app_identifier:app['appid'] , readonly: true, type: type)
    suffixRec = Onkore.getSuffix(type)
    profile= suffixRec['profile'] + app['appid']
    team=ENV['FASTLANE_TEAM_ID']

    gym(
        workspace: 'Onkore.xcworkspace',
        scheme: app['scheme'],
        export_method: "development",
        output_directory: "archives",
      com.onkore.BachelorFantasyUSA.Debug' DEVELOPMENT_TEAM=XXXXXX",
        xcargs: "PROVISIONING_PROFILE=profile DEVELOPMENT_TEAM=#{team}",
        clean: true, include_bitcode:false
    )
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful
  end

  error do |lane, exception|
     #slack(
     #  message: exception.message,
     #  success: false
     #)
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/docs/Platforms.md
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

fastlane gems

Gem
Version
Update-Status

fastlane
2.62.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-upload_symbols_to_new_relic
0.1.1
✅ Up-To-Date

fastlane-plugin-appicon
0.10.0
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.1.0

bundler
1.15.4

io-console
0.4.6

CFPropertyList
2.3.5

concurrent-ruby
1.0.5

i18n
0.9.0

minitest
5.10.3

thread_safe
0.3.6

tzinfo
1.2.3

activesupport
4.2.10

public_suffix
2.0.5

addressable
2.5.2

babosa
1.0.2

claide
1.0.2

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.3.1

cocoapods-deintegrate
1.0.1

cocoapods-downloader
1.1.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.0.0

netrc
0.11.0

cocoapods-trunk
1.3.0

cocoapods-try
1.1.0

colored2
3.1.2

escape
0.0.4

fourflusher
2.0.1

gh_inspector
1.0.3

molinillo
0.5.7

ruby-macho
1.1.0

nanaimo
0.2.3

xcodeproj
1.5.2

cocoapods
1.3.1

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

declarative
0.0.10

declarative-option
0.1.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

dotenv
2.2.1

excon
0.59.0

multipart-post
2.0.0

faraday
0.13.1

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

fastimage
2.1.0

jwt
2.1.0

little-plugger
1.1.4

multi_json
1.12.2

logging
2.2.2

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.1

httpclient
2.8.3

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.1.0

representable
3.0.4

retriable
3.1.1

google-api-client
0.13.6

json
2.1.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.3.0

rubyzip
1.2.1

security
0.1.3

slack-notifier
1.5.1

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

tty-screen
0.5.0

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.2.8

xcpretty-travis-formatter
0.0.4

fastlane-plugin-appicon
0.10.0

fastlane-plugin-upload_symbols_to_new_relic
0.1.1

xcode-install
2.3.1

generated on: 2017-10-19

I've got the same issue using version 2.62.0. Any news?

Same issue using 2.62.0. Try reinstall, but not help : (

Yes, definitely 2.62.0. My workaround is to go back to 2.58.0 which was the last working version for me, haven't tested with 2.60 etc. Do this if you are using bundler.

gem uninstall fastlane
Change fastlane gem line to look like this: gem 'fastlane', '2.58.0'
bundle install
bundle exec fastlane <your lane>

This is a known issue with fastlane 2.62.0 and case-sensitive file systems. We will ship a fix for it shortly - the fix is in PR #10630.  Thanks and sorry for the inconvenience! 🚀


Update microsoft-defender-atp-mac-install-with-intune.md

adding troubleshooting step for common 'no license found' issue

@Dansimp The PR introduces a Troubleshooting section to the documentation, "Microsoft Defenter ATP Mac Install with Intune" and is submitted by a MS contributor. Please review as the time permits. Thanks.


Bugfix/invalid hex string when using encryptECIES

This issue was caused when the length of sharedSecret.toString('hex') was not 64.
To work around this issue a new recursive function getEncryptionKeys was created that will return an object with sharedSecret and ephemeralPK to be used by encryptECIES. The function will only return a value if the converted hex string for sharedSecret is 64 characters long. The function will run again otherwise.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much for this @brandonparee - @kantai or I will take a look at this in the next couple days!


typo: Mirosoft -> Microsoft

@mijacobs The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!


Feature/pipeline waves 274

Issue #, if available: 274
Description of changes: Waves support with pipelines to deploy a group of clusters in parallel.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I ran preliminary tests. Functional test through codepipeline requires published artifact.

will merge the csi secrets first.

Please review just this commit: https://github.com/aws-quickstart/ssp-amazon-eks/pull/286/commits/6c624bb15f2c6f3370d5c99b415eafbff6a2e76e

It seems like code from Secrets Store CSI refactor is mixed in here (ce3bd6e) is mixed in here. Am I missing something?

Yes, it is. I have branched off the argocd csi secrets branch, hoping these commits will not show up as they are part of the main already. See the PR description, I left a comment on it.

e2e succeeded. however, unsure why the PR is not showing it.


When closing Spyder (or only a console), add an option to save variables (automatically?)

From pierre.raybaut on 2010-08-11T01:43:07Z
The idea is to do something similar to the warning message when closing Spyder v1.x with a non empty workspace. But here, it would be a dialog box with check boxes: one line per console.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=277

From<EMAIL_ADDRESS>on 2010-08-11T00:31:32Z
It would be good to make this warning optional as I have never found a need to save variables.

From pierre.raybaut on 2010-08-10T23:55:09Z
Labels: Milestone-Release2.0

From pierre.raybaut on 2010-08-11T01:00:47Z
Ok, I'll add an option to enable/disable this feature in "Variable Explorer" configuration page.

From<EMAIL_ADDRESS>on 2010-08-18T08:09:20Z
perhaps a "don't show this question again" tickmark on the dialog itself would also be nice.

From pierre.raybaut on 2010-10-17T13:03:32Z
Labels: -Milestone-Release2.0 Milestone-Release2.1

From ccordoba12 on 2011-05-02T10:37:32Z
Summary: When closing Spyder, add an option to save variables (automatically?)
Labels: -Type-Defect Type-Enhancement

From pierre.raybaut on 2011-05-16T01:07:42Z
Labels: Cat-VariableExplorer

From pierre.raybaut on 2011-10-15T07:15:50Z
Labels: -Milestone-Release2.1 Milestone-Release2.2

From pierre.raybaut on 2011-06-25T05:30:56Z
Summary: When closing Spyder (or only a console), add an option to save variables (automatically?)

From pierre.raybaut on 2011-10-29T04:28:05Z
Status: WontFix


Translater

Unfortunately we cannot accept this patch, since as explained in CONTRIBUTING.md (see excerpt below, we're importing the translations from Firefox.

Note that the translations for PDF.js in the l10n folder are synchronized with the Nightly channel of Mozilla Firefox. This means that we will only accept pull requests that add strings currently missing in the Nightly channel, but keep in mind that the changes will be overwritten when we synchronize again.

If you think this is incorrect, please suggest the change upstream first.


Publish agent template to marketplace

Description

Related Issues

Solution and Design

Test Plan

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[ ] My pull request is atomic and focuses on a single change.
[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] I have documented my changes clearly and comprehensively.
[ ] I have added the required tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: namansleeps2:x: Rounak BhatiaRounak Bhatia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[GHSA-p2fh-w83x-vrm3] In Progress Telerik UI for WPF versions prior to 2024 Q4 ...

Updates

Affected products
Summary

Comments
Provides at least one of the common NuGet package names that this vulnerability comes in.

Our advisories need to be connected to a package that is in one of the supported ecosystems.


Add Version Logging

When xcbeautify starts, it should log the semantic version to the console. It should use the semantic version found in Version.swift, and it should be suppressible via an environment variable and/or CLI argument.

This is now available, starting in 2.4.0. Thanks again @ikelax for the contribution!


feature: mqtt websockets

class TestMQTTProviderRunOpWithSetConnectionArgs(RunOpTests):

We need a test that shows that websockets is passed to the transport based on the value in the configuration object

Refers to: azure-iot-device/tests/common/pipeline/test_pipeline_stages_mqtt.py:201 in 7b6384f. [](commit_id = 7b6384fd71502ce0414ac0e61389d8d631f91ceb, deletion_comment = False)

def test_passes_right_params(self, stage, transport, mocker, op_set_connection_args):

We need a test that shows that websockets is passed to the transport based on the value in the configuration object. This might require slight restructure of the contents of this test and/or making a new test

Refers to: azure-iot-device/tests/common/pipeline/test_pipeline_stages_mqtt.py:210 in 7b6384f. [](commit_id = 7b6384fd71502ce0414ac0e61389d8d631f91ceb, deletion_comment = False)

/azp run Azure.azure-iot-sdk-python-horton-e2e


Selecting image through the app renames it, while sharing an image with the app preserves the original filename

My understanding is that you're not interested in implementing filename randomization, as mentioned here: https://github.com/Tommy-Geenexus/exif-eraser/issues/52#issuecomment-1238291901
Therefore, this feels like a bug / unintended, especially seeing as it doesn't happen when you share the photo with the app.

Bug, or hidden feature? 😅 #53

This is pretty much covered by #52.
It's neither a bug nor feature, simply a byproduct of Android's file sharing via URI.
The method used for retrieving the image display name is the exact same for every use case, it's just that images shared via file provider have obfuscated URIs and the display name can't be retrieved (to my knowledge, without overhead).


Add dependabot.yml

Dependabot is a good way to stay ahead with dependency updates.

Implemented in d0149fc


[druid] Updating refresh logic (#4655)

(cherry picked from commit f9d85bd2e1fd9bc233d19c76bed09467522b968a)
to: @graceguo-supercat @michellethomas @timifasubaa

Codecov Report

:exclamation: No coverage uploaded for pull request base (airbnb-master@d48b53a). Click here to learn what that means.
The diff coverage is 74.2%.

@@               Coverage Diff                @@
##             airbnb-master      #28   +/-   ##
================================================
  Coverage                 ?   71.52%
================================================
  Files                    ?      190
  Lines                    ?    14927
  Branches                 ?     1102
================================================
  Hits                     ?    10677
  Misses                   ?     4247
  Partials                 ?        3

Impacted Files
Coverage Δ

superset/connectors/sqla/models.py
77.91% <ø> (ø)

superset/cli.py
48.38% <ø> (ø)

superset/assets/javascripts/welcome/App.jsx
94.44% <ø> (ø)

...rset/assets/javascripts/explore/stores/visTypes.js
70.58% <ø> (ø)

superset/connectors/sqla/views.py
71.56% <ø> (ø)

...ssets/javascripts/explore/components/SaveModal.jsx
93.75% <ø> (ø)

.../explore/components/controls/DatasourceControl.jsx
66.66% <0%> (ø)

superset/connectors/druid/views.py
68.02% <0%> (ø)

superset/assets/javascripts/chart/Chart.jsx
64.95% <0%> (ø)

...ascripts/explore/components/ExploreChartHeader.jsx
71.42% <0%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48b53a...ba44eb1. Read the comment docs.


License

HI! This is great work.
Request you to add the license as well. Unable to figure out if it is MIT license or not. Thanks :D

Thanks! The license has been added


Docs about setting up environment for testing

I had a failure running phantomjs.. I'm not sure about the required versions and such. Is there any doc that shows how to setup a testing environment... mostly for integration tests?
Thanks!

Can you post your failure in a gist?

Also, the README.md, the CONTRIBUTING.md, and agouti.org should provide plenty of information on how to get your environment to run our tests. Try using PhantomJS 1.9.7+

ok, was using 1.9.0 .. maybe it's just that.


NixOS Unstable and 16.09 Release Channel Not Updating

For the past week or so, NixOS release-16.09 hasn't been updated by hydra due to issues with kernel builds.
Kernels have been timing out:

https://hydra.nixos.org/build/44741624
https://hydra.nixos.org/build/44741882
https://hydra.nixos.org/build/44769425
https://hydra.nixos.org/build/44769447
https://hydra.nixos.org/build/44769619
https://hydra.nixos.org/build/44769533

At one point, instability in the 4.8 build was also causing issues.
This is a bit dire now, because users on 16.09 using ACME / LetsEncrypt are now unable to update their certificates: https://github.com/NixOS/nixpkgs/issues/21144 making this a time-bomb as someone's certificate could be running out any moment now.
I'm not sure how to debug or investigate this, and would really like some help.
/cc @rbvermaa, @edolstra, @domenkozar

I restarted the last one and it was immediately successful (I presume the upload to cache was OK and it hung afterwards).

@vcunat Interesting ... can you try restarting the others, too, and see how it goes?

... but I think the main channel-blockers are somewhere else. Actually, I'm not even aware of 4.8 kernel being channel-critical in 16.09.

One day I went through and ran the "Reproduce Locally" script locally and every single one passed.

Yeah, I've never been able to reproduce Hydra failures where the log is correct and complete to the end, followed by a timeout.  I've got no idea why exactly these hangs happen, but it's certainly nothing new; maybe it was worse now due to increased machine load or something...

Even the VM tests where where is an error in the log, I believe every single one passed locally :(

anyway -- if the fix to this issue is changes to nixpkgs, or changes to hydra / the servers / whatever, the important thing is we get an update out.

At least the firewall tests on 16.09 seem to fail reproducibly with some vsftpd problem: http://hydra.nixos.org/build/44745942 http://hydra.nixos.org/build/44745934

I ran the reproduce script for those tests and they passed just fine.

Those tests also started failing on master.  I suspect the underlying problem might be the same as http://lists.science.uu.nl/pipermail/nix-dev/2016-December/022311.html (also maybe)

@edolstra has pushed some changes to the release and master branches, and the 16.09-small channel has already updated. Looks like we should be in the clear, but I'll update again in several hours.

So #20500 was the solution?

Not sure, now weird stuff is failing on hydra but not locally. Example: https://hydra.nixos.org/build/44846830 @edolstra assuming these changes are from that nix upgrade, can we revert nix to the older version until more testing is done?

Update: @FRidh has disabled testing on pytest, and we're now seeing issues from samba.

(messaged nix-dev about this at http://lists.science.uu.nl/pipermail/nix-dev/2016-December/022366.html)

I messaged to #nixos:

as I understand it, the issue is pytest has a test where it chmods a directory to 0000
and expects to not be able to write in there. If it can write, the test fails. with user
namespacing, it can write . hydra is running unstable nix, which turns on user
namespacing. the reason this test started failing out of the blue is because the nix
daemon is, technically, an impure input. so it didn't start failing as soon as nix was
changed, but the next time a big rebuild came around. to make things worse,
nixUnstable had a schema change, so hydra can't just be reset to nix-stable.

Further detail I sent #nixos:

this is what user namespacing is allowing, which I think breaks posix:
mkdir test; chmod 0000 test; touch test/foo

Hydra is running nixUnstable: https://github.com/NixOS/nixos-org-configurations/blob/master/hydra-provisioner/nixops.nix#L42

@edolstra @rbvermaa @domenkozar should hydra be switched nixStable so that release-16.09 can be built reliably?

To add some urgency to this: an embargoed Exim vulnerability is going public on December 25th (who picks Christmas??)... and I'm hopeful this is fixed before then.

To add some urgency to this: an embargoed Exim vulnerability is going public on December 25th (who picks Christmas??)... and I'm hopeful this is fixed before then.

(Perhaps it's on purpose; black hats will surely take a holiday ;-)

For those who want reproduce the bugs happen on hydra:
https://github.com/lethalman/nix-user-chroot
Suffers from the same problems at it uses user namespaces. I was able to reproduce go bug for instance.

I think that not running as UID 0 in the namespace should solve most of these (if not all).

nix-user-chroot does not runs as root, by mapping its own uid into the namespace. Go build still fails though.

@vcunat the issue with pytest works as a regular user, too (https://github.com/NixOS/nixpkgs/issues/21145#issuecomment-267833849)

This might be related to parted build failures on Hydra now: http://hydra.nixos.org/build/45093914
When I build parted on my own box it succeeds because it skips all the device-mapper tests, due to not being run is uid 0.
On Hydra it tries to run them as it is "root" but they fail.

Yes, parted looks like that, and coreutils, too, which blocks almost all Linux stuff.

parted had its tests disabled here: 2fdd4973ec4e867ff76ef6608ac75e89aa0d4514 I would really rather not see lots of packages have their test suites disabled if we can avoid it.

Now both -small and nixpkgs-unstable channels got updated, at least.

Commits were reverted on nix: https://github.com/NixOS/nix/commits/master
and the jobs on hydra were re-run, removing the massive 8,000 package breaking rebuild is no longer there: https://hydra.nixos.org/jobset/nixos/release-16.09

@aristidb can you revert your parted change?
@FRidh can you revert the disabling of pytest tests?

@grahamc I plan to use the latest pytest as default. Because of a circular dependency with hypothesis tests will need to remain disabled then.

@globin, @domenkozar, @cstrahan, @nathan7 (contributors to go in nixpkgs): hydra is erroring on:
--- FAIL: TestSCMCredentials (0.00s)
	creds_test.go:66: WriteMsgUnix failed with invalid argument, want EPERM

(https://hydra.nixos.org/build/44853356/nixlog/3) in 1.6 and 1.7 at least. Seemingly related: https://github.com/golang/go/issues/10703
can you look at it?

That go problem doesn't happen with my local nix (on the same nixpkgs commit).

Yes, this is introduced by user namespacing. We're still using user namespacing on hydra. Only the seccomp changes were reverted.

I see now. It should be run with UID 1 and GID 1.

KDE5 tests fail on unstable and 16.09; I don't see why currently. On unstable it's actually the last issue preventing channel update.

KDE tests frequently fail for "no reason"... will investigate.

@grahamc while I can patch that out, things shouldn't be running as UID 0, and I'm not particularly interested in ignoring a valid test

@nathan7 the tests aren't running as uid 0 at this point.

See: https://github.com/NixOS/nix/commit/3a4bd320c2c4043a4b1f73406030e9afc0677b59 this revert, put us back at uid 1000

KDE5 tests fail on unstable and 16.09; I don't see why currently. On unstable it's actually the last issue preventing channel update.

These tests frequently time-out, I'm afraid.

There were several failed attempts, so I thought it was some more permanent problem, but I see 16.09 succeeded completely now. nixos-unstable is now the only long-failing channel (~12 days).

16.09 is updating okay now, I think though:

the patch for go_1_7 should be applied to 1_6
the patches for release-16.09 should be reviewed and applied to master

@vcunat not sure where to put this, but @LnL7 and @acowley are asking for staging to  be merged to master.

We need to wait for Hydra; that's what staging is for.

My question was a bit more general, eg. are there reasons not to merge in the last commit that was built by hydra if the results look ok?
At the moment the sync between master and staging is pretty long IMHO.

In general there aren't, but the last one fully-built on Hydra is relatively old and there were a lot of changes on master since then, so the merge would create lots of new jobs by itself. My tool estimates ~10k just for x86_64-linux and it doesn't count e.g. Haskell stuff. There are thousands of jobs queued for master even now :-/
It isn't that bad, really; I remember periods where the lag was counted in months :-)

I also had to backport to go patch to go_bootstrap, which was having trouble after a mass rebuild. Now, some tests aren't completing fast enough: https://hydra.nixos.org/build/45276404/nixlog/1

It's probably better to disable go tests altogether.

That could be. I wonder, though, if it is because the machine it is running on is highly loaded, due to the mass rebuild?

The go tests are pretty cpu intensive

They passed ok, but the instability is a bit troubling. Not the biggest worry, perhaps, though...

All the five channels are recent now :-)


Highlight edges through dispatchAction in force-layout graph

What problem does this feature solve?
In my project, I want to highlight one or some paths (including several edges). However we can only highlight nodes (dataIndex or data name)  through dispatchAction. Could you please add some new feature to help to highlight the edges  through dispatchAction?
What does the proposed API look like?
myChart.dispatchAction({
       type: 'highlight',
       seriesIndex: 0,
        seriesName: 'test',
        edgeDataIndex: number | list
});

https://echarts.apache.org/zh/api.html#action.highlight

Hi, I have read the document as well as the source code. First, the node dataIndex and the edge dataIndex were counted separately. In the code view/Chart.js, I find
highlight: function (seriesModel, ecModel, api, payload) {
        console.log(seriesModel)
        toggleHighlight(seriesModel.getData(), payload, 'emphasis');
    }

Here getData() can be found in Model/Series.js, I think the possible reason that we can't highlight the edges through dispatchAction now is that getData function will get the node dataIndex but not the edge dataindex.
Could you please help me check it?

Could @susiwen8 help check this? Thanks!

@Ovilia Sure

Any updates on this issue? I have the same requirement - need to highlight an edge programmingly.

Any updates?

Any updates?

any updates?


Fix changing servers

Turns out, the Cloud City URL setting in the settings screen was useless because while we were changing it, and updating the repository, it was never really reused since the Retrofit would just get initialized once with the initial (prefilled) value of the server URL and that's that.
So apart from doing some other beneficial changes, this PR makes it possible to recreate the Retrofit client when necessary (when URL changes) and 'enable' us to change servers on the fly while the app is running.

Summary by CodeRabbit
Release Notes

New Features

Enhanced thread safety for server URL and token management.
Improved listener management in shared preferences, allowing multiple listeners per preference type.
Streamlined update logic to prevent concurrent updates.
Improved control flow and error handling for Retrofit client initialization based on URL changes.
Added cleanup method to prevent memory leaks by unregistering listeners when the fragment's view is destroyed.

Bug Fixes

Resolved issues with concurrent access to server URL and token methods.

Consider taking the whole SharedPrefGrouper to the OMNT team since changes to it have already spanned a few commits...


Post-processing

Finalise the test_and_plot_only option, to allow for post-processing of a base, without the need of re-generating it.

Done as per 81fa3053263c9457a713d970cba538441162f722.


fix: customized show content of get-property

What this PR does / why we need it:
fix: customized show content of get-property

Does this PR need to be backport to the previous release branch?:

release/3.11
release/3.10

/cc @zexi @ioito

/lgtm


SpliceAI will not output results.

To Whom It May Concern,
I am trying to run SpliceAI for a BRCA1 variant in hg19 (chr17-41246372-C-T) with 10000 max distance, but I keep getting the following error message regardless of whether I do or do not use the pre-computed scores:
"ERROR: Unable to reach the SpliceAI-lookup API server. Either the API server or your internet isn't working."
My internet is working, so I wanted to alert you that perhaps there is an API server issue that you are not yet aware of.
Thank you!

Thanks for letting me know.  Someone was running a script that was making 10+ requests per minute, so I've
now added per-user request rate limits which should make the API more resilient going forward.
The server is now back online.


Modify update method to use precomputed values with delta

Requires a modification to insert, such that we return all of the update delta values which we then use to update the commitment

Adding to this;
This is an optimisation where all of the keys being inserted are already in the tree, this means that no new nodes are being added. Using this, if a node is modified n times, we only need to update it once to the last value and skip the intermediate values


Add layer docs Catalog and GreatCircleLayer Demo

Background
7.0 audit
Change List

split layer-demos to layer catalog demos
reorg layer docs
add GreatCircleLayer demo

Coverage remained the same at 61.849% when pulling 28f29869fb185416d7df7b5cfc574834e3d980d4 on xx/website-demos into bbc79d9e73ca235892af7d7ea88b96c9d8160764 on master.


Failed to resolve flagsmith kotlin library

I have follow the tutorial to add flagsmith to my kotlin project. But when I build my project, the IDE give this error: Failed to resolve: com.github.Flagsmith:flagsmith-kotlin-android-client:1.0.1
How to resolve it ?
gz#415

Can you share the code/tutorial so we can try and reproduce?


copresentation view for whitelisting image/file URLs

As discussed last week, get a view ready to help Cantaloupe and the file server know which file paths are whitelisted for direct access.

Please ignore the bit above where I accidentally clicked "assign yourself". :P

In the short term we can create a view on 'cosearch', but longer term this should be a view against one of the CouchDB repositories that are part of the preservation platform rather than one part of the access platform.  I just wanted to make the note that what we do in the short term is stopgap while we architect the split between preservation and access platforms.

This will be sufficient while we build the proper system.  I'll need to replicate the 'copresentation' database to the content servers, and force the map building if this is seen as sufficient.

A note that a successful request returns the row if it was found, or an empty set if not found.  Everything else is an error, and we'll want to decide what to do with errors (skip whitelist and require JWT?)
A timeout can happen when calculating the view, and we'll want to decide what to do with those.  Including deciding if we want to have a very short request timeout and a fallback if whitelist isn't currently available.
russell@russell-XPS-13-9370:~$ curl http://eclipse.tor.c7a.ca:5984/copresentation/_design/tdr/_view/fileapproved?key=%22oocihm.8_04865_7/data/sip/data/files/oocihm.8_04865_7.pdf%22
{"total_rows":69176513,"offset":13748552,"rows":[
{"id":"oocihm.8_04865_7","key":"oocihm.8_04865_7/data/sip/data/files/oocihm.8_04865_7.pdf","value":null}
]}
russell@russell-XPS-13-9370:~$ curl http://eclipse.tor.c7a.ca:5984/copresentation/_design/tdr/_view/fileapproved?key=%22oocihm.8_04865_7/data/sip/data/files/oocihm.8_04865_7.doc%22
{"total_rows":69176513,"offset":13748552,"rows":[

]}
russell@russell-XPS-13-9370:~$


Have same texture with 2 different items (not an issue)

Is there a way to have 2 different named items use the same texture in a single.properties file?
Thanks

You would use a regex expression to achieve that. If you check the display name against =regex:(first|second) it would match either "first" or "second". There's tons of info online on regex if you want to do something more complicated.


Any idea why code block displays extra numbers?

If I disable the theme, it fixes so I'm sure its the theme. But I'm not sure which value in the css I should edit to fix it

Unsure why it looks like that for you, got any other plugins / Themes running on side?

And if that is supposed to be the CSS editor, it looks normal for me aswell

Hi! Turns out it was the popular Shiki plugin, I disabled it since they don't seem compatible

Could a plugin perhaps cause this too?

Yeah, better codeblocks plugin also did this, for now I deleted them both, so now it works! Although now I can't copy :(
Do you know how to make them compatible with the theme?

https://github.com/Vap0r1ze/vpc-shiki

Issue is, both are touching the Codeblocks side of Discord, meaning if I was gonna add them together in any way I'd need the approval from the creator of shiki to use it in my theme. So as of now, even if I wanted to, tried to and maybe get it to work.. I wouldn't be able to publish it onto my Theme.
I know this response is a bit late, but lately I've been busy with alot of irl stuff D:


Is OmniDB not compatibile with MS Internet Explorer v11?

obvious duplicate of #929

Hi @larryrayleonard , and thanks, @pgaro .
Yes, we don't plan to add support to MS Internet Explorer, as its supported is about to be discontinued from Microsoft. We also won't add support for Microsoft Edge, as soon it will be replaced by a Chromium-based version.
Closing this now.
Regards,
William