In joy UI Autocomplete and Model does not work  properly together

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/optimistic-lena-hig7h6?file=/src/App.js
Steps:

Click open dialog box
Click on Autocomplete field

Current behavior 😯
All the options for Autocomplete goes below the Model, And it all burry.
Expected behavior 🤔
All the options for Autocomplete should be above the model right below the Autocomplete.
Context 🔦
No response
Your environment 🌎
No response

Seems to be a z-index issue. Passing style with zIndex to listbox fixes it and can be used as a workaround -
<Autocomplete
  placeholder="Combo box"
  options={top100Films}
  sx={{ width: 300 }}
  slotProps={{
    listbox: {
      sx: {
        zIndex: 1300
      }
    }
  }}
/>

Ideally, joy-ui should auto handle adding correct z-index when autocomplete is opened inside modals/dialogs.

slotProps={{
    listbox: {
      sx: (theme) => ({
        zIndex: theme.vars.zIndex.modal
      })
    }
  }}

@brijeshb42 This works perfectly, Thank you!
But I will keep this issue open because this should be the default behavior.

can I take this?

@saikathalderr Sure. Feel free to take a stab at it. Let us know if you are facing any issue with the implementation.

I fixed the issue in my local, need some suggestions on how to add test case for this fix. or do we need a test case at all as it was more of a CSS issue.
the fix code:

@kartik1225 Thanks for reporting the issue. It will be fixed in #37515.
Here is the preview of the fix using your code https://codesandbox.io/s/joy-cra-ts-forked-kcds54?file=/src/App.tsx


api: Don't crash if Slack does not return JSON

Sometimes Slack doesn't return JSON for an API response, if they're having
a bad day. Catch parsing errors and hit the callback with the error instead of
(potentially) crashing the process.

(this just crashed a process on our server)

Thanks @kevinburkeshyp  contributed,


update template packages

Changes proposed in this Pull Request:

update templates to use new versions of pxb packages

Screenshots:

To Test:

no need to publish this, no major updates


Distance function and comparison with no warping

Hi,
I am trying to use a L1 distance instead of L2.
Currently I only change line 321 in soft_dtw_cuda.py:
    def _calc_distance_matrix(self, x, y):
        """
        Calculates the Euclidean distance between each element in x and y per timestep
        """
        n = x.size(1)
        m = y.size(1)
        d = x.size(2)
        x = x.unsqueeze(2).expand(-1, n, m, d)
        y = y.unsqueeze(1).expand(-1, n, m, d)
        return torch.abs(x - y).sum(3)
#        return torch.pow(x - y, 2).sum(3)

is this correct or is there more to be changed?
Also, I'm comparing the non warped loss (i.e. mean(abs(X-Y))) and the dtw loss is much higher.
I would expect dtw to roughly less or equal (averaging the timesteps) of the normal L1, or at least comparable, but I get value which are of 2 or even 3 orders of magnitude higher. What am I missing?

Your change to the cost function looks correct to me.

I'm comparing the non warped loss (i.e. mean(abs(X-Y))) and the dtw loss is much higher.

Can you elaborate a bit more what you mean by that?

Given two sequence A, B (of length n), I compute the standard L1 loss as abs(A-B)/n.
Now, by warping I would expect a lower average timestep distance: assuming I expand the two series into A' and B' (as in the many to many mapping in dtw) of lenght n' > n, I would expect that abs(A' - B')/n' < abs(A-B)/n and dtw(A,B) to be closely related toabs(A' - B')/n'. I find however that dtw(A,B)~~~ L1(A,B) ^ 2 (~~~ meaning very loosely, with very noisy sequences).
Basically I wanted to compute the "degree of warping" as 1 - dtw(A,B) / L1(A,B) which, assuming that dtw(A,B) < L1(A,B), would be between 0 and 1. However this seems far from True, even taking the square of L1(A,B).

Thanks for the clarification.
If I understood your description correctly, I think the huge difference in the result is expected, because the returned value from sDTW actually is logarithmized (see this related response from the original authors).
The global alignment kernel normalization trick that the author has referenced in his response above can help obtain sDTW values that are always greater than 0, but I don't know what else needs to be done to correctly scale the resulting sDTW value between 0 and 1, if that's what you're after in this case.


ImportError: cannot import name 'PydanticUndefined' from 'pydantic_core' (unknown location)

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Seems that scikit learn CI pipeline broke to the new update:
https://github.com/scikit-learn/scikit-learn/issues/28004
Example Code
Traceback (most recent call last):
  File "/usr/share/miniconda/bin/conda-lock", line 6, in <module>
    from conda_lock import main
  File "/usr/share/miniconda/lib/python3.11/site-packages/conda_lock/__init__.py", line 3, in <module>
    from conda_lock.conda_lock import main
  File "/usr/share/miniconda/lib/python3.11/site-packages/conda_lock/conda_lock.py", line 50, in <module>
    from conda_lock.conda_solver import solve_conda
  File "/usr/share/miniconda/lib/python3.11/site-packages/conda_lock/conda_solver.py", line 20, in <module>
    from conda_lock.invoke_conda import (
  File "/usr/share/miniconda/lib/python3.11/site-packages/conda_lock/invoke_conda.py", line 15, in <module>
    from conda_lock.models.channel import Channel
  File "/usr/share/miniconda/lib/python3.11/site-packages/conda_lock/models/__init__.py", line 1, in <module>
    from pydantic import BaseModel
  File "/usr/share/miniconda/lib/python3.11/site-packages/pydantic/__init__.py", line 372, in __getattr__
    module = import_module(module_name, package=package)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda/lib/python3.11/site-packages/pydantic/main.py", line 13, in <module>
    from pydantic_core import PydanticUndefined
ImportError: cannot import name 'PydanticUndefined' from 'pydantic_core' (unknown location)

Python, Pydantic & OS Version
pydantic-core-2.14.6
pydantic-2.5.3

Thanks @edgBR for reporting this.
AFAIK, There is no change in related to PydanticUndefined in pydantic and pydantic-core.
I've tried the from pydantic_core import PydanticUndefined in a fresh env with pydantic-core-2.14.6 and pydantic-2.5.3 and it was OK.

I too am able to run from pydantic_core import PydanticUndefined fine with 2.5.3.
@edgBR it looks like you're installing from conda-forge, is that right? I don't know how, but maybe that's part of the problem.
The "(unknown location)" makes me think this could be an issue with pydantic-core not working at all in that environment, and the above import is just the first pydantic_core import that's being hit.

I have noticed the same issue. For us, it occurs only when installing pydantic through conda-forge on a CI pipelines running linux (windows and macOS pipelines do not suffer from this issue).
For us, a temporary (dirty) fix is to move pydantic from the conda dependencies to pip dependencies.
Hopefully this helps in resolving the issue!

I've created https://github.com/conda-forge/pydantic-core-feedstock/issues/79 in the help someone from anaconda can help.

Thanks!
Lets see if the fix it soon!
BR
E

Any news?  I'm trying to build a new image for my app and it's dead in the water ... I assume that the same is true for any app that depends on pydantic ...

Well, it's specific to condaforge as far as we know (please confirm if that's NOT the case) and pydantic 2.5.3.
That likely means <1% of those using Pydantic are affected, not any app that depends on Pydantic.

A user just ran into this as well in a scientific library we maintain (https://github.com/DASDAE/dascore/issues/325).
When pydantic is installed with conda on python 3.12, like this:
conda create -c conda-forge -n pydantic pydantic
conda activate pydantic

Trying to import the PlainValidtor like this:
from pydantic import PlainValidator

raises this Error:
  File "<string>", line 1, in <module>
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/__init__.py", line 363, in __getattr__
    return _getattr_migration(attr_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/_migration.py", line 278, in wrapper
    from ._internal._validators import import_string
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/_internal/_validators.py", line 14, in <module>
    from pydantic_core import PydanticCustomError, core_schema
ImportError: cannot import name 'PydanticCustomError' from 'pydantic_core' (unknown location)

However,  if I create a new environment then install pydantic with pip it works fine:
conda create -n py312 python=3.12
conda activate py312
python -m pip install pydantic

In the broken environment that installed pydantic with conda uninstalling then re-installing pydantic_core with pip fixes the issue.
Here is the output of the pydantic version command for both environments:
broken environment (pydantic)
pydantic version: 2.5.3
pydantic-core version: 2.14.6
pydantic-core build: profile=release pgo=false
install path: /home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic
python version: 3.12.0 | packaged by conda-forge | (main, Oct  3 2023, 08:43:22) [GCC 12.3.0]
platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31
related packages: typing_extensions-4.9.0
working environment (py312)
pydantic version: 2.5.3
pydantic-core version: 2.14.6
pydantic-core build: profile=release pgo=true
install path: /home/derrick/anaconda3/envs/py312/lib/python3.12/site-packages/pydantic
python version: 3.12.0 | packaged by conda-forge | (main, Oct  3 2023, 08:43:22) [GCC 12.3.0]
platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31
related packages: typing_extensions-4.9.0
The difference I note is that in the working environment pgo=true whereas in the broken environment pgo=false. I don't know what that means though.

That likely means <1% of those using Pydantic are affected, not any app that depends on Pydantic.

This is probably true, but it also means anyone using conda to install any library that depends on pydantic will probably end up with a broken installation, so not an insignificant number of folks.

Oh well, my app's dependency on pydantic was through the "inflect" module which turned out to be some cruft so I removed it ... no worries for me, sorry for the noise.

This has been solved in conda-forge and new installs in 15min from now will no longer be affected.

Great, thanks so much for your help on this @xhochy.
I'll close this assuming it's now fixed, if anyone continues to experience the problem, please let us know.

Hi,
Im still having the same problem, scikit learn CI is still broken:
https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=61825&view=logs&j=dde5042c-7464-5d47-9507-31bdd2ee0a3a&t=7d852497-2547-55fa-986f-0b436c028d7e

A user just ran into this as well in a scientific library we maintain (DASDAE/dascore#325).
When pydantic is installed with conda on python 3.12, like this:
conda create -c conda-forge -n pydantic pydantic
conda activate pydantic

Trying to import the PlainValidtor like this:
from pydantic import PlainValidator

raises this Error:
  File "<string>", line 1, in <module>
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/__init__.py", line 363, in __getattr__
    return _getattr_migration(attr_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/_migration.py", line 278, in wrapper
    from ._internal._validators import import_string
  File "/home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic/_internal/_validators.py", line 14, in <module>
    from pydantic_core import PydanticCustomError, core_schema
ImportError: cannot import name 'PydanticCustomError' from 'pydantic_core' (unknown location)

However, if I create a new environment then install pydantic with pip it works fine:
conda create -n py312 python=3.12
conda activate py312
python -m pip install pydantic

In the broken environment that installed pydantic with conda uninstalling then re-installing pydantic_core with pip fixes the issue.
Here is the output of the pydantic version command for both environments:
broken environment (pydantic)
pydantic version: 2.5.3 pydantic-core version: 2.14.6 pydantic-core build: profile=release pgo=false install path: /home/derrick/anaconda3/envs/pydantic/lib/python3.12/site-packages/pydantic python version: 3.12.0 | packaged by conda-forge | (main, Oct 3 2023, 08:43:22) [GCC 12.3.0] platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31 related packages: typing_extensions-4.9.0
working environment (py312)
pydantic version: 2.5.3 pydantic-core version: 2.14.6 pydantic-core build: profile=release pgo=true install path: /home/derrick/anaconda3/envs/py312/lib/python3.12/site-packages/pydantic python version: 3.12.0 | packaged by conda-forge | (main, Oct 3 2023, 08:43:22) [GCC 12.3.0] platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31 related packages: typing_extensions-4.9.0
The difference I note is that in the working environment pgo=true whereas in the broken environment pgo=false. I don't know what that means though.

It works.


PEP 658 metadata download to speed up builds

Fixes: https://github.com/python-wheel-build/fromager/issues/360

@rd4398 I notice this is a draft is there any testing wise you would be interested in?

@rd4398 I notice this is a draft is there any testing wise you would be interested in?

oops! @pnasrat I forgot to close this PR. I started working on this here: https://github.com/python-wheel-build/fromager/pull/464. I apologize for the confusion and thank you for your interest.
@tiran has some ideas on how to implement this feature and I need to collaborate with him to discuss about it. You can look out for https://github.com/python-wheel-build/fromager/pull/464 when it lands.
I am closing this PR now to avoid further confusion. Again, I am sorry about this and appreciate your interest!


"Inventors" in patents are not captured

Hi,
When using fill() to populate a publication and the publication is a patent, author field is missing from bib.
{'author_pub_id': 'Ql-RFR8AAAAJ:W7OEmFMy1HYC',
 'bib': {'abstract': 'Example implementations relate to assigning '
                     'microservices to cluster nodes. A sidecar proxy may be '
                     'deployed at a data plane of a distributed service. The '
                     'sidecar proxy may monitor telemetry data between '
                     'microservices of the distributed service. A '
                     'communication pattern may be determined from the '
                     'telemetry data of the distributed service. Each '
                     'microservice of the distributed service may be assigned '
                     'to a cluster node based on the communication pattern.',
         'pub_year': '2020',
         'title': 'Assignment of microservices'},
 'cites_per_year': {},
 'eprint_url': 'https://patentimages.storage.googleapis.com/f9/04/30/7ca5d8a0249f99/US10827020.pdf',
 'filled': True,
 'num_citations': 0,
 'pub_url': 'https://patents.google.com/patent/US10827020B1/en',
 'source': 'AUTHOR_PUBLICATION_ENTRY'}

I did a quick check. For a patent, Google Scholar uses "Inventors" rather than "Authors", which seems to be the problem.

Solution: Essentially check for key authors and/or inventors to fill the [bib][author] of a publication
Code:

search_query = scholarly.search_author('Lianjie Cao')
author = scholarly.fill(next(search_query))
author = scholarly.fill(author)
pub = scholarly.fill(author['publications'][10])
scholarly.pprint(pub)

Output:
{'author_pub_id': 'Ql-RFR8AAAAJ:YsMSGLbcyi4C',
 'bib': {'abstract': 'Network slicing enables Communication Service Providers '
                     'to partition physical infrastructure into '
                     'logically-independent networks. Network slices must be '
                     'provisioned to meet the Service-Level Objectives (SLOs) '
                     'of disparate offerings, such as enhanced Mobile '
                     'Broadband, Ultra Reliable Low Latency Communications, '
                     'and massive Machine Type Communications. Network '
                     'orchestrators must customize service placement and '
                     'scaling to achieve the SLO of each network slice. In '
                     'this article, we describe the challenges encountered by '
                     'network orchestrators in allocating resources to '
                     'disparate 5G network slices, and propose the use of '
                     'artificial intelligence to make core placement and '
                     'scaling decisions that meet the requirements of network '
                     'slices deployed on shared infrastructure. We explore how '
                     'artificial intelligence-driven scaling algorithms, '
                     'coupled with functionality-aware placement, can enable '
                     'providers to design …',
         'author': 'Amit Sheoran and Sonia Fahmy and Lianjie Cao and Puneet '
                   'Sharma',
         'journal': 'IEEE Internet Computing',
         'number': '01',
         'pages': '1-1',
         'pub_year': 2021,
         'publisher': 'IEEE Computer Society',
         'title': 'AI-Driven Provisioning in the 5G Core'},
 'cites_per_year': {},
 'filled': True,
 'num_citations': 0,
 'pub_url': 'https://www.computer.org/csdl/magazine/ic/5555/01/09345397/1qTYFFAyZbi',
 'source': 'AUTHOR_PUBLICATION_ENTRY'}


[android-player] Creating a New Playlist from Album does not add Album's tracks

Tested on
FW Basic 1.6.8 build 227, Samsung S4/Android 5.0.1
FW Plus build 228, Sony Xperia Z2/ Android 5.1.1.
Behavior
Creating a New Playlist when in My Music under Album, Recent, Artists or any screen that shows tracks in aggregate does create a Playlist, but does not add tracks from that screen to the Playlist. Playlist is empty.
Steps to Reproduce

Go to My Music > Albums
Tap on any album
Select Menu from upper right corner > choose New Playlist
Name Playlist and tap OK.
Scroll back to Playlists & Check your newly created playlist

Additional Observations

The same thing happens on both phones
The same thing happens regardless of file format
Adding individual files to a New Playlist works fine
Adding individual files to an already existing Playlist works fine

CC: @votaguz @alejandroarturom @X-NicON @dennistobar (@arubinofaux wanna do some android?)
$15 bounty for merged pull request to be paid in Bitcoin at the exchange rate of the day on Bitven.com

We need to make sure that we are only fixing this at the inner stage, for example Recent - selected album, and not just in recent, or in artists - Kellee Maize and not just artists. When you double hold for ex. a whole album you get "Add to Playlist" and on the next dialog you can either choose your playlist or create a new one - this works as intended, so we could use that functionality in the overflow menu when inside of the artist or an album instead of 'New Playlist' only.
Everything on the outside - when 'My Music' is on the action bar means we would add all our content to a playlist, which we don't want. So since we can not tap and hold to select multiple songs or albums it only make sense to have 'new playlist' as is now.

OK - I see what you are saying. If you logic is correct (and I think it is) then technically the current behaviour is fine and nothing is broken.
Logically then, there should be two functions:
'New Playlist' - Creates an empty Playlist
'Add All to Playlist' - Creates a Playlists with all files on current screen or adds all files on current screen to an already existing Playlist.
If @gubatron agrees, we should probably close this ticket and open one with Enhancement to add 'Add All to Playlist' functionality. I in the light of current workload, I would even mark it as low priority/bounty and I will explain playlist creation on support for anybody that gets confused.

Well, in the beginning I wanted to do just that - add "Add all to playlist" however when you go into a particular folder 'shuffle all', 'sort by' only applies to that particular album. Hence I was thinking of just having "Add to playlist" instead of both. When you add to playlist the dialog will come with an option to create a new playlist to add it too or selecting an existing one. I think by doing so we would be able to reuse some code that already exists.

So thinking more about it ... kademlia is right, I think keeping both is the best option.
I started working on it and set it up so the Add to Playlist is visible in certain ProfileActivities such as Albums and Artists but still can not make it fully functional. Will work on it later. Good exercise.

Hi gurls.
Just took a look.
"New Playlist" is a generic button to create a new playlist and it works as expected.
When we're in a screen that shows multiple songs, we can have that second one that says "Add to playlits", so that should be an easy fix, and I think @marcelinkaaa already did it.
There's one improvement to make, and it's something I did for desktop.
When you add a bunch of songs, whatever they are to a new Playlist, the suggested name should be there for you without having to type the name.
So here's the first part of the code on desktop (for illustration purposes)
public static void createNewPlaylist(final List<? extends AbstractLibraryTableDataLine<?>> lines) {
        DialogFinishedListener dialogListener = new DialogFinishedListener() {
            @Override
            public void onDialogCancelled() {
            }

            @Override
            public void onDialogOk(String playlistName) {
                if (playlistName != null && playlistName.length() > 0) {
                    final Playlist playlist = LibraryMediator.getLibrary().newPlaylist(playlistName, playlistName);
                    playlist.save();
                    LibraryMediator.instance().getLibraryPlaylists().addPlaylist(playlist);
                    LibraryMediator.instance().getLibraryPlaylists().markBeginImport(playlist);
                    Thread t = new Thread(new Runnable() {
                        public void run() {
                            addToPlaylist(playlist, lines);
                            playlist.save();
                            asyncAddToPlaylistFinalizer(playlist);
                        }
                    }, "createNewPlaylist");
                    t.setDaemon(true);
                    t.start();
                    UXStats.instance().log(UXAction.LIBRARY_PLAYLIST_CREATED);
                }
            }
        };

        FrostwireInputDialog.showInputDialog(GUIMediator.getAppFrame(),
                I18n.tr("Playlist name"),
                I18n.tr("Playlist name"),
                GUIMediator.getThemeImage("playlist"),
                suggestPlaylistName(lines), // CHECK THIS OUT
                dialogListener);
    }

There I have this method called suggestPlaylistName(lines), this is the code:
private static String suggestPlaylistName(File[] mediaFiles) {
        HistoHashMap<String> artistNames = new HistoHashMap<String>();
        HistoHashMap<String> artistsAlbums = new HistoHashMap<String>();
        HistoHashMap<String> albumNames = new HistoHashMap<String>();
        HistoHashMap<String> genres = new HistoHashMap<String>();

        for (File mf : mediaFiles) {
            if (MediaPlayer.isPlayableFile(mf)) {
                TagsData mt = new TagsReader(mf).parse();
                artistNames.update(mt.getArtist());
                artistsAlbums.update(mt.getArtist() + " - " + mt.getAlbum());
                albumNames.update(mt.getAlbum());
                genres.update("(" + mt.getGenre() + ")");
            }
        }

        Entry<String, Integer>[] histogramArtistNames = artistNames.histogram();
        Entry<String, Integer>[] histogramArtistsAlbums = artistsAlbums.histogram();
        Entry<String, Integer>[] histogramAlbumNames = albumNames.histogram();
        Entry<String, Integer>[] histogramGenres = genres.histogram();

        String topArtistName = histogramArtistNames[histogramArtistNames.length - 1].getKey();
        int topArtistNameCount = histogramArtistNames[histogramArtistNames.length - 1].getValue();

        String topArtistAlbum = histogramArtistsAlbums[histogramArtistsAlbums.length - 1].getKey();
        int topArtistAlbumCount = histogramArtistsAlbums[histogramArtistsAlbums.length - 1].getValue();

        String topAlbumName = histogramAlbumNames[histogramAlbumNames.length - 1].getKey();
        int topAlbumNameCount = histogramAlbumNames[histogramAlbumNames.length - 1].getValue();

        String topGenre = histogramGenres[histogramGenres.length - 1].getKey();

        String suggestedPlaylistName = topArtistName;
        if (topArtistAlbumCount >= topArtistNameCount) {
            suggestedPlaylistName = topArtistAlbum;
        } else if (topAlbumNameCount >= topArtistNameCount) {
            suggestedPlaylistName = topAlbumName;
            if (topArtistNameCount > 3) {
                suggestedPlaylistName = topArtistName + " - " + suggestedPlaylistName;
            }
        }

        if (!topGenre.equals("()")) {
            suggestedPlaylistName = suggestedPlaylistName + " " + topGenre;
        }

        return suggestedPlaylistName;
    }

I invented something called HistoHashMap, it's a structure that has an update operation.
You tell it about a certain key that you found, and it adds it to an internal map that keeps count of how many times it happend. On the algorithm above I keep count of the album names, song titles, artists names of the list of music files given so I can try to deduct what the most common pattern is and suggest a playlist name.
HistoHashMap currently lives only in package com.frostwire.gui.library; which is inside desktop.
If you're up for it, @marcelinkaaa , we can move it somewhere inside the common/ folder and make use of it to improve the "New Playlist" pre-written text. I think those are the kind of details that make you love an app which are not so obvious, being on a cellphone, it's a PITA to have to type the name of an artist, album, etc, it's just amazing if you open that dialog an the app is smart enough to type it for you.
That algorithm above uses a TagReader, which is a class that can open audio files to analize their metadata, in the case of android, it should be easier because we already have that data parsed for us.

This is just a visual set up was not able to connect functionality; ContextMenu used when you long press on the item to get "Add to playlist" works great but I can not seem to find a way to connect it to the action bar overflow menu. I tired using your AddToPlaylistMenuAction.java in android not apollo in, in couple of different ways, but I was just able to show the list of playlists but nothing happened on click.
https://github.com/marcelinkaaa/frostwire/tree/apollo-playlist-fix

I've been doing a lot of work now on this and I'm a bit more familiar with the codebase.
As part of this fix I'll attempt a refactor that should eliminate a ton of repeated code in about 17 fragment classes.

this was a can of worms that was opened and it should be cleaned.

@gubatron Comparing branches I have: 110 changed files with 2,094 additions and 4,976 deletions.
I can't fully follow all the refactor+new features you made and I'm worry about it. It's my impression that such a big change should support a fundamental new product feature, not an additional menu item. If the act of adding this menu item, requieres such a big change, then we need to balance the risk of doing it vs immediate effective gain. The player is a very delicate and pseudo-stable component.
@marcelinkaaa @kad3mlia I would like to hear your opinions too. Thanks

If you come to the lab tomorrow I'll give you a walkthrough of the changes.
I believe it's a lot better now and in better shape for future fixes and additions.

OK, let's review this together


⚠ Bofrost.at has degraded performance

In 583256a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1765 ms

Resolved: Bofrost.at performance has improved in 5b6cb6c.


ci: use reusable workflow

ci: use reusable workflow
ci(pre-commit): add hadolint-docker hook
docs(readme): add docker-publish badge

Codecov Report
Patch and project coverage have no change.

Comparison is base (0252d60) 65.51% compared to head (15e4a41) 65.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   65.51%   65.51%
=======================================
  Files           1        1
  Lines          29       29
=======================================
  Hits           19       19
  Misses         10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Updating CI/CD workflows and pre-commit hooks
📝 PR summary: This PR introduces changes to the CI/CD workflows, specifically the codeql and docker-publish workflows. It also updates the pre-commit hooks configuration and adds a new badge to the README.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The changes made in this PR seem to be well thought out and are likely to improve the efficiency of the CI/CD pipelines. However, it would be beneficial to include a detailed PR description explaining the rationale behind these changes. This would help reviewers understand the context and the expected impact of the changes.

 🤖 Code feedback:

relevant file: .github/workflows/docker-publish.yml
suggestion: It's great that you are using a reusable workflow. However, it's important to pin the version of the reusable workflow to avoid unexpected changes if the workflow is updated in the future. [important]
relevant line: uses: deadnews/deadnews-template-docker/.github/workflows/docker-reusable.yml@latest

relevant file: .pre-commit-config.yaml
suggestion: It's good to see that you are adding new hooks to the pre-commit configuration. However, it would be beneficial to add a comment explaining why the hadolint-docker hook is being skipped. This would provide context for future contributors. [medium]
relevant line: skip: [golangci-lint, hadolint-docker]

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.


Changes made in installation file to make the download

Targets #1006
Description
This PR contains the changes made in the installation file to make the installation process easier
Checklist:

[ ] I have performed a self-review of my code.

@gautam071 Please resolve the merge conflict

@gautam071 Please resolve the merge conflict

Resolved!


Update Probabilistic Counting example to use Scala test utils

retest this please

pint-merged as well

This PR covered a subset of the original, bigger PR at https://github.com/confluentinc/kafka-streams-examples/pull/235.


Prefer compileOnly for idea deps when it exists

Fall back to compile configuration on older Gradle versions
Fixes #168

The same is needed for plugins as well

cool, I'll update the patch and double-check the runtime configuration too

Thanks, looking forward to

It might be better to just put them into a new configuration (e.g. idea or intellij, possibly a separate one for plugins?) and to extend that configuration in compile/compileOnly/testCompileOnly. That means you need to add the dependency a single time only once because it will be automatically inherited into the other configurations.
Basically like this (in pseudo Groovy):
def ideaConfig = configurations.create('idea')
project.dependencies.add(ideaConfig.name, /* ... */)

if (compileOnly) {
    configurations.compileOnly.extendsFrom(ideaConfig)
    configurations.testCompileOnly.extendsFrom(ideaConfig)
} else {
    configurations.compile.extendsFrom(ideaConfig)
}

oh true, that would make it a bit cleaner compared to shuttling the List<String> around

Looks good, although after I thought about it for a while I think it might be useful in some cases to have a separate configuration for the IntelliJ IDEA plugins (e.g. ideaPlugins). For example if you have a task that generates PSI classes/parsers using Grammar-Kit then you need just IntelliJ IDEA on the classpath when running it, not all the plugins you depend on.
All we need to do to support this is to create a new ideaPlugins configuration and extend the idea configuration in it. If you then extend ideaPlugins in compileOnly etc then it will automatically also inherit the idea configuration.

so something like a compileOnly > ideaPlugins > idea? I'm not sure I understand the use case but I can send a new PR

Yes. Essentially it allows re-using the IDEA dependency in other configurations. Grammar-Kit for example requires classes from the IntelliJ IDEA distribution for generating the parser/PSI classes. So if we have a separate idea configuration with only the idea dependency we can just do:
configurations {
    grammarKit {
        extendsFrom configurations.idea
    }
}

dependencies {
    grammarKit("org.jetbrains:grammar-kit:...")
}

task generateParser(type: JavaExec) {
    classpath = configurations.grammarKit
    // ...
}

Currently everything is added to the compile configuration directly, so there is no easy way to only add the main IDEA distribution to the classpath of the Grammar-Kit task. With your changes in your PR here, we can already limit it to the IDEA dependency and the plugins you depend on. If you add another extra configuration for the IDEA plugins we can add only the required dependency on the IDEA core.

Thank you @madisp for the changes and @Minecrell for review. Merged. 0.2.6 will be available in a couple hours

@zolotov Did you make the change I mentioned above? If not, only ideaPlugins is actually added to the classpath currently.

@Minecrell I did, thanks. Sorry, for delay, 0.2.6 is available at plugins.gradle.com now

Thanks for the review and merge!


Refine global styles and implement login/signup pages

Functional features overview
Main changes to global styles:

Added a default color for warning messages.
Add responsive padding to header and footer
Change all menu items that don't have pages for now to href="#" to avoid navigating to other pages

Login and Signup pages:

Login page where clicking login button leads to home page
Signup page where clicking signup button leads to signup-success page which can navigate to home page
signup-fail which sets the signup up for failure and displays error message.

Closing this PR due to a mishap with git rebase and git history.


KAFKA-14885: fix kafka client connect to the broker that offline from…

When a broker has some issues about network, the broker can not connect to zookeeper and controller.At this time, we replace this broker with a new broker that has a same broker.id with fault broker, and we can not  stop the Kafka process on fault broker because of network issue. So the client can still connect this broker and can produce and consume messages normally.  But the data on fault broker maybe be lost because there are some leader for partitions on the fault broker.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@alexism Can you help me reviewing it?

@alexism Can you help me reviewing it?

We are in the process of removing ZooKeeper, and the KafkaServer class should get deleted before the next release. So I'm not sure it make sense to make this fix as it will never be in a release.


Update Instance flags in shaders to match instance flags in engine

Fixes: https://github.com/godotengine/godot/issues/66639
Fixes: https://github.com/godotengine/godot/issues/66618
Introduced by: https://github.com/godotengine/godot/pull/65833
The Instance flags are used both in the engine and in the scene shaders. The flags need to match in both.
Definitions here:
https://github.com/godotengine/godot/blob/e69b7083d45c5d8698508cce7086d361c4b1f44c/servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.h#L234-L249
and here:
https://github.com/godotengine/godot/blob/e69b7083d45c5d8698508cce7086d361c4b1f44c/servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.h#L375-L390

Probably warrants adding comments in the headers so future changes are properly done in the glsl too.

Probably warrants adding comments in the headers so future changes are properly done in the glsl too.

Sure thing! Pushed with comments

Thanks!


Some questions about the VQGAN tokenizer

First, congratulations to MAGE for being accepted by CVPR2023! I learned a lot from your great paper and also the detailed replies to other issues!
I'm not familiar with the usage of the image tokenizer. Below are some questions from my side:

Based on this issue the image tokenizer pre-trained with two different (in image augmentation) settings based on the VQGAN tokenizer in the MaskGiT. Hence, can I think the image tokenizer is first pre-trained and then plug into the MAE-like encoder-decoder architecture?
In your paper, only the reconstruction cross-entropy loss and contrastive loss are used. Hence, is the image tokenizer fixed (frozen) in the training-from-scratch process of MAGE?

Thanks again for such a great paper! It pushes the field a big step forward!

Hi! Thanks for your interest. The answers to both of your questions are Yes: 1. One key observation in MAGE is that the exact same MAE-like encoder-decoder operating on image tokens instead of pixel space (MAE) gives us a huge boost in both generation and representation learning performance. 2. The image tokenizer is pre-trained and fixed during the MAGE training.

Thanks for your prompt reply! Wish you all the best! I am very curious that why BEiT-like paper use the patch projection tokens as input instead of their tokenized semantic tokens before I read your paper. I am not sure if MAGE is the first paper which use semantic tokens as input for representation learning, but the experimental results about linear probing prove its effectiveness!
I also very like the analysis and details in Table.  6. As you explained in this issue, I am a little confused about why "the receptive fields of neighboring feature pixels have significant overlap, it is much easier to infer masked feature pixels using nearby unquantized feature pixels.".  Since you have masked the raw pixels, the receptive fields  of both the neighbouring feature tokens and semantic tokens should be very similar?

I think there is some misunderstanding: we do not mask the raw pixels in 256x256 images, but we mask the pixels in the feature space (16x16). Therefore, if we do not quantize the features and directly mask them, the masked features can easily be inferred by looking at nearby features, as each pixel in the feature space has an overlapping receptive field.

Thanks for solving my confusion!
The analysis in your paper, the discussion of this issue, and the previous issue remind me that: If we directly mask CNN encoded image features, the overlapping receptive field will cause information leaking.
Except for using quantized tokens in MAGE, I recommend you can try the ViT-VQGAN as they said in Section 3.1: "The encoder of ViT-VQGAN first maps 8×8 non-overlapping image patches into image tokens". Although it is still not open-source, it is the only Transformer-based I know and the authors come from Google Research, maybe you can try MAGE with ViT-VQGAN. Since the patches are non-overlapping, it may better handle this problem and improve the results in Table. 4.

Thanks for your suggestion! It could be an interesting future direction to explore.

Hi @LTH14, I noticed that in mage/models_mage.py, after tokenizing the input images into input ids (based on the VQGAN's codebook), the ids will be converted to embeddings based on self.token_emb.
However, based on your paper (if I am not mistaken):

it seems that the self.token_emb should be initialized with VQGAN's codebook?
self.token_emb should be fixed during MAGE training? (considering you said, "The image tokenizer is pre-trained and fixed during the MAGE training." here, which means encoder & decoder & codebook of VQGAN are all fixed?)

Hi, I think there is a bit misunderstanding: we use the pre-trained VQGAN to extract the token "index", instead of the token vector from the original image. After that, we use a different embedding (i.e., self.token_emb) to embed such token index, which is trained together with the MAGE training. The main reason to do this is that the embedding dimension of the MAGE transformer can be different from the VQGAN codebook. As a result, directly using the VQGAN codebook as an initialization can cause embedding dimension mismatch.

Thanks for your prompt reply!
Hence, the frozen VQGAN is just used to extract image token index and decode the index to an image (or we can say tokenize and detokenize).
The random initialized self. token_emb is learned during training and can be seen as a new learned MAGE codebook aligned with VQGAN codebook (so MAGE can use VQGAN decoder).
Is there any misunderstanding in my above understanding?🧐
BTW, do you try a VQGAN codebook copy and a linear projection as the self.token_emb?

You are mostly correct! Just one minor point: the newly learned MAGE codebook also does not need to necessarily align with the VQGAN codebook: the output of MAGE is still token index. Hence, you can use the VQGAN detokenizer to decode those token index.
"VQGAN codebook copy and a linear projection as the self.token_emb" -- I remember I tried that one and the results are quite similar.

The "align" in my comment means each index in the token_emb naturally aligns with that in the VQGAN codebook based on the training process. It aligns with your comment!
Thanks again for your detailed discussion!


Login and Storage MVP

This ticket includes connecting sub parts of previous workstreams to demonstrate an end to end working solution for the login and storage functionalities.

Build an MVP for the Login functionality.

Allow the user to login to the Console.

Display the user image in the top corner.

Allow for Flow creation

Save the data to storage

Allow the user to re-log in and see the saved Flow

Acceptance Criteria

end to end minimum working usecase for the login functionality

console should still work as before but can be hidden behind a login page

Link to feature: https://jinaai.productboard.com/feature-board/planning/features/7362620


It is recommended that the toolbar in the work definition flow be changed to authorizable

It is recommended that the toolbar in the work definition flow be changed to authorizable to use or display, and that the tools available be licensed to use in user authorization.
271/5000
The reason: 1. In a production environment, when we create accounts for different users, maybe I just want different users to use one of the features, but not the other features, which is more conducive to security management and risk reduction. 2, can use the function to authorize, can not use the function does not give the customer to reflect on the page, can enhance the customer experience, solve some unnecessary explanation and trouble.

+1

+1

哪位大神来搞一下这个功能啊，我觉得还是很重要得啊！

哪位大神来搞一下这个功能啊，我觉得还是很重要得啊！

哪位大神来搞一下这个功能啊，我觉得还是很重要得啊！

So let me do that.

哪位大神来搞一下这个功能啊，我觉得还是很重要得啊！

So let me do that.


⚠ Bofrost.at has degraded performance

In 54bd3f5, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1529 ms

Resolved: Bofrost.at performance has improved in dabad98 after 15 minutes.


Publish NPM module

It would be great to be able to install bootstrap-sass via NPM

It is already on npm: https://www.npmjs.com/package/bootstrap-sass


Cleanup ClientUI

Client UI

Extract common utlity methods from ClientUI to SwingUtil utlity class.
Make ClientUI wrap JFrame inside
Do not make RuneLite class depend on Swing API at all
Create ClientUI through Guice
Simplify initialization and showing of UI
Change LinkBrowser to not use ClientUI as parent for message box (not
required at all) and change it from Guice service to static utility
class
Set screenshot plugin offsets statically without recalculating them
based on swing component

Plugin Toolbar

Create PluginToolbar through Guice
Create separate component class for toolbar layout
Create custom navigation button component to not depend on swing
Create new events that are fired on new toolbar button addition and
removal
Use updated construction for NavigationButton
Replace ClientUI injections with PluginToolbar injections

Title Toolbar

Extract title toolbar layout to separate component
Create new events for adding and removing title toolbar buttons
Create TitleToolbar through Guice
Change info panel to support new hooks
Change plugins to use NavigationButton for adding buttons to
titleToolbar
Add 2 new methods to SwingUtil for image manipulation

Alright now this should be done, hopefully. Tested it and it works :tm:


[alpine] apk add repmgr will install another copy of postgresql

My target is to deploy a postgresql HA cluster in docker, following is my steps:

ran a postgres:15.2-alpine container which will be the primary server, no problem. However, I noticed apk list -I not list postgres as installed package;
install repmgr in this container by run apk add repmgr command, installation seems ok, but logs said:

/ # apk add repmgr
(1/9) Installing openssh-keygen (9.1_p1-r2)
(2/9) Installing openssh-client-common (9.1_p1-r2)
(3/9) Installing openssh-client-default (9.1_p1-r2)
(4/9) Installing doas (6.8.2-r3)
Executing doas-6.8.2-r3.post-install
(5/9) Installing postgresql-common (1.1-r3)
Executing postgresql-common-1.1-r3.pre-install
(6/9) Installing libpq (15.2-r0)
(7/9) Installing postgresql15-client (15.2-r0)
(8/9) Installing postgresql15 (15.2-r0)
Executing postgresql15-15.2-r0.post-install
*
* If you want to use JIT in PostgreSQL, install postgresql15-jit or
* postgresql-jit (if you didn't install specific major version of postgresql).
*
(9/9) Installing repmgr (5.3.3-r1)
Executing busybox-1.35.0-r29.trigger
Executing postgresql-common-1.1-r3.trigger
* Setting postgresql15 as the default version
pg_versions: WARN: /etc/postgresql exists and it's not a symlink!
OK: 204 MiB in 56 packages

as you can see, apk add repmgr installed another copy of postgresql, this lead to two issues:

repmgr only install extension in new instance, and repmgr can't work with exist postgres which has no repmgr extension;
more disk usage;

Could you please try some thing to make apk aware postgres was installed?
I'm not good at linux/alpine, sorry for that.
Thanks a lot!

I don't think there's a way for us to do that, but if there is an unobtrusive (esp. simple to maintain) way to block apk from installing PostgreSQL again, we'd be open to considering it.

Ok, I understood.
Thanks again.


Issues with uPlot integration in React Flow

Hi there,
I’m experiencing several issues while using uPlot in combination with React Flow. I understand that these problems are not directly related to the wrapper itself but seem to arise from using the wrapper with uPlot in a specific context.
Could you please assist me in resolving these issues?
I’ve created a Stackblitz with examples of the issues: Stackblitz Link
Issues:
1.	The line appears blurred from the start.
2.	The crosshair is missing the point on hover over the line values.

Thank you in advance for your help!

Hi
Can you give more details on how to reproduce the issue? I tried your test case, but the line doesn't seem to be blurred for me at all. Also the crosshair seems to be working just fine...
Can you record a video with the issue, so that it'd be easier to understand it?
Also try to reproduce the issue with plain React and plain uPlot, so that we will be able understand what exactly causes this behavior.

Hi,
I see. Yes, I can reproduce it now!
It seems like using ReactFlow causes this behavior. It works just fine when using the same example with plain uPlot or uplot-wrappers.
I guess ReactFlow does some kind of scaling under the hood that uPlot is not aware of and it causes all those problems.
You can try asking ReactFlow authors what exactly are they doing there, maybe there is some way to prevent it? You can also create an issue for uPlot itself, maybe there is some way to work-around it https://github.com/leeoniya/uPlot/issues
It doesn't seem like much can be done from the side of the wrapper itself though (

It was just a question, maybe you already had experience solving similar problems. In that case I think we can close the issue. I have already created a ticket for the creators of uPlot.


如何添加SAD到ERFNet网络中，提升CULane数据集的精度？谢谢

You can just derive the attention maps from stage 2 and stage 3, and then make the attention maps of stage 2 mimic these of stage 3.


Readme improvements

Some blocks in README.md could benefit from a few extra characters!
at line 11, 14, 18, 20, 25, 27, 31, 33 could add just one more ` for each of those lines it would look a lot nicer and easier to read!

Fixed


Allow specifying different website for bug reports

i personally have nothing against this, as also discord channels could be specified, or rickrolls

Main reason for this change:
Even though you can parse github link and open issues page, some mods would want to use a more user friendly way to report bugs. Having no blank issue and adding it as a contact link isn't a solution because it requires github login which defeats the purpose of making it user friendly

Since the order of elements matters for validation can this be placed near (after) repo link?


Slurm fails to utilize the full service quota

I have increased my service quota from 32 to 96 after starting a AWS Parallel Cluster and queuing jobs. The compute nodes are r5axlarge (vCPU=4 per node). However, slurm resume program fails to utilize the full quota potential, and still shows that the limit is 32. A snapshot from the slurm_resume log -
2022-03-06 04:53:05,459 - [slurm_plugin.instance_manager:add_instances_for_nodes] - ERROR - Encountered exception when launching instances for nodes (x13) ['queue1-dy-r5axlarge-8', 'queue1-dy-r5axlarge-9', 'queue1-dy-r5axlarge-10', 'queue1-dy-r5axlarge-11', 'queue1-dy-r5axlarge-12', 'queue1-dy-r5axlarge-13', 'queue1-dy-r5axlarge-14', 'queue1-dy-r5axlarge-15', 'queue1-dy-r5axlarge-16', 'queue1-dy-r5axlarge-17', 'queue1-dy-r5axlarge-18', 'queue1-dy-r5axlarge-19', 'queue1-dy-r5axlarge-20']:
An error occurred (VcpuLimitExceeded) when calling the RunInstances operation:
You have requested more vCPU capacity than your current vCPU limit of 32 allows for the instance
bucket that the specified instance type belongs to. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.

I have tried to cancel pending jobs and requeue them. However the issue still persists.

Hello @swaroop-nath,
were you able to move forward?
Thanks

Hi guys, @lukeseawalker and @enrico-usai, sorry for the delay. Turns out that the service quota had shown an increase in my console but wasn't actually increased. I contacted AWS support and they informed me the same.


run within PHP

Is it possible to run
bazel-bin/tensorflow/examples/label_image/label_image
inside PHP script and echo the output of main.cc to PHP script?
Is there any way to remotely call and get the results?

There is separate project named TensorFlow Serving.
You could call API from PHP.

This is a question about how to use PHP to invoke processes, not a TensorFlow issues.


Initial CLI framework - datasette-build command, optional datasette build if Datasette is installed

Part of:

#1

I can use this pattern: https://til.simonwillison.net/datasette/cli-tool-that-is-also-a-plugin

datasette-build --help

Usage: datasette-build [OPTIONS] DB_PATH DIRECTORY_PATH

  Build a directory full of files into a SQLite database

Options:
  --help  Show this message and exit.

And with Datasette installed:
datasette build --help

Usage: datasette build [OPTIONS] DB_PATH DIRECTORY_PATH

  Build a directory full of files into a SQLite database

Options:
  --help  Show this message and exit.


[mempool] Remove unused prometheus dependency

Found a remaining unused prometheus dependency in mempool during triage. This removes it.

@bors-libra r=davidiw

:pushpin: Commit 53a692a has been approved by davidiw

:hourglass: Testing commit 53a692ad58c5972266f883aaab1558da51efcef7 with merge 6f8c309814585d09f7db67c1171c50073500be06...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 6f8c309814585d09f7db67c1171c50073500be06 to master...


[Snyk] Upgrade body-parser from 1.20.1 to 1.20.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade body-parser from 1.20.1 to 1.20.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-02-22.

Release notes

Package name: body-parser

1.20.2 - 2023-02-22
Fix strict json error message on Node.js 19+
deps<EMAIL_ADDRESS>
perf: skip value escaping when unnecessary

deps<EMAIL_ADDRESS>

1.20.1 - 2022-10-06
deps<EMAIL_ADDRESS>perf: remove unnecessary object clone

    from body-parser GitHub release notes

Commit messages

Package name: body-parser

ee91374 1.20.2
368a93a Fix strict json error message on Node.js 19+
0385872 deps<EMAIL_ADDRESS>2c35b41 build<EMAIL_ADDRESS>f0646c2 build<EMAIL_ADDRESS>f345fb1 build<EMAIL_ADDRESS>6842efc deps<EMAIL_ADDRESS>5af7315 build<EMAIL_ADDRESS>8e605b3 build<EMAIL_ADDRESS>cba6e77 build<EMAIL_ADDRESS>6a464ab build<EMAIL_ADDRESS>7ebf276 build<EMAIL_ADDRESS>69bb649 build<EMAIL_ADDRESS>8ff995f docs: switch badges to badgen
850832f build<EMAIL_ADDRESS>dad8f34 build: actions/download-artifact@v3
b17df32 build: use $GITHUB_OUTPUT for environment list
d22513a build: actions/upload-artifact@v3
9f44f7b build: actions/checkout@v3
48e18ea build<EMAIL_ADDRESS>
Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage: 85.625%. Remained the same when pulling 9d9b99f8a53dd407fe20a871a1ed99541464623f on snyk-upgrade-2cb2a0f1f9d60f0b98a6c0ff90664fe9 into c8b1387b307891e80b0f7eef1fe6ab33e641d734 on main.


libp2p_helper: 1 dependencies couldn't be built

Using this commit.
When building with make build, I'm getting this error:
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/ily14d68xl11cnbbkf9svwnzwsrrnzah-bash-4.4-p23'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/n4mc61zgpx5ardz0h745mrpbx48mzsls-go-1.12.9'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/v28wx4y2mq5y0i6r2n4yfw71lqvz7wxz-stdenv-linux'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/mymkz6qhf46j6j7nanilyd15cgj5p9br-bzip2-<IP_ADDRESS>.1-bin'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8p0gj2g800971ssm2nnw5aqaydfs5wch-diffutils-3.7'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/6kybix8hndmq5chz7zdjc10v2pvdf0qz-findutils-4.7.0'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/r7q1y0v74afrhdg1wqzs8gd7n96nbr98-gawk-5.0.1'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8x3lspbpjlm5wpwg3zb2qiksrxblsnax-gcc-wrapper-8.3.0'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/kksyrix1bpklvgkmvngcv0q9nh8hn2fl-glibc-2.27'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/mqjfwh0b3zdz3n89q71f3px38dlvbybm-gnugrep-3.3'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/irwjcfkgygya964mag6b920qws4r1zl7-gnumake-4.2.1'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/l9cd8rki40anwhbxwbc7c7hgdmbmz9mk-gnused-4.7'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/znsa81k72j5aaclg1crv5575n4w726fc-gnutar-1.32'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/rvybssv5lxm6rfdbqmkiapv91hrl5cmx-gzip-1.10'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/jwbp0wxizvfjl99p0nbaagc91sf3hb1h-patch-2.7.6'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/fldkzixl4ascrrg1cs3j229gn6b9xxiw-patchelf-0.9'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/95j91i5mkhfwqrscmiz49qab3l343jc7-stdenv-linux'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/ch63h3ysgnsyjgw0inqplfh5af2bqhxb-xz-5.2.4-bin'
cannot build derivation '/nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv': 1 dependencies couldn't be built

@dannywillems can you share more of your logs? Those warnings don't look fatal, so something else is probably causing your build to fail. Thanks!

The fatal error is the last line. Here the complete log if you want:
INFO Not using Docker
find: '_build/default': No such file or directory
find: '_build/default': No such file or directory
find: '_build/default': No such file or directory
ocamlformat --doc-comments=before --inplace  || true
bash -c "if [ -z \"${USER}\" ]; then export USER=opam ; fi && source ~/.nix-profile/etc/profile.d/nix.sh && (if [ -z \"${CACHIX_SIGNING_KEY+x}\" ]; then cd src/app/libp2p_helper && nix-build ${EXTRA_NIX_ARGS} default.nix;  else cachix use codaprotocol && cd src/app/libp2p_helper && nix-build ${EXTRA_NIX_ARGS} default.nix | cachix push codaprotocol ; fi)"
ocamlformat: Must specify at least one input file, or `-` for stdin
these derivations will be built:
  /nix/store/w10p3qd3hadd2bxy44dwb30g3i9gm6q2-libp2p_helper-0.1-go-modules.drv
  /nix/store/yid5v99zzd22ia1bzg2xv0fhpk7kmvlf-remove-references-to.drv
  /nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv
these paths will be fetched (183.93 MiB download, 791.61 MiB unpacked):
  /nix/store/0cgsw0gh0c5pgkp40x4nd5h728bk4mqq-perl5.30.0-HTTP-Daemon-6.01
  /nix/store/0hr45a0pzlh51hhcgynmfjpzff9d3ddv-binutils-2.31.1
  /nix/store/121pfq5xb2vv1k62hc9qasp9682hj13a-keyutils-1.6-lib
  /nix/store/22h3f311fjymkvp683kb657jycs7i5pn-glibc-2.27-bin
  /nix/store/24l5rfm2xhqkx96jvq0rg8pplb89b9hv-gcc-8.3.0
  /nix/store/28ad36blb1ar2lbccamxnwf9mwb3nn3h-expand-response-params
  /nix/store/2hmmpihddvg2br06wkbia5b9ngrrbic1-perl5.30.0-HTTP-Date-6.02
  /nix/store/2n8wj6qh69c5mkc87mhfa74qip5gb86p-binutils-wrapper-2.31.1
  /nix/store/3hdlcd12cc9c95ym9cic4237kgp5sh1n-libssh2-1.9.0
  /nix/store/3qdcgqmdlfn74apvjq1zr9d2dwlf75p5-perl-5.30.0
  /nix/store/4hv1736v8mhczln694f6ixzqj4mvgl0m-perl5.30.0-Net-HTTP-6.19
  /nix/store/4nigx91wfr202b3xh9ls9688168s2vxw-perl5.30.0-Test-Fatal-0.014
  /nix/store/4rjbbp4wwmcywgnax45dg2670vhvw7za-readline-6.3p08
  /nix/store/4smn05z6pavqzrpfjfnr6ryikfcrm6rn-perl5.30.0-HTTP-Message-6.18
  /nix/store/53g2nqsz0p8gm6wvp8lvlpavrx44jmdg-curl-7.65.3
  /nix/store/6kybix8hndmq5chz7zdjc10v2pvdf0qz-findutils-4.7.0
  /nix/store/6m12chabs78pkayj0lx4iqn96cn8ffv5-perl5.30.0-FCGI-ProcManager-0.28
  /nix/store/6v2z8ygblp259almxl1wi2qq36nlsipv-nss-cacert-3.46
  /nix/store/71gskq82qgp6758fgsjg26lpdqzwy7xd-perl5.30.0-HTML-Parser-3.72
  /nix/store/7mmn8ri08z48vfj69c2h66f3g349ilq1-mailcap-2.1.48
  /nix/store/849x0sqjwhyhlwflyl5b5dc6ga4mqqvj-perl5.30.0-HTML-Tagset-3.20
  /nix/store/86gds466pknhbxfsn319w0nycv7pqxfi-xz-5.2.4
  /nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31
  /nix/store/8p0gj2g800971ssm2nnw5aqaydfs5wch-diffutils-3.7
  /nix/store/8x3lspbpjlm5wpwg3zb2qiksrxblsnax-gcc-wrapper-8.3.0
  /nix/store/94qhv72gfsflr30a7pn0lkh19i7bmfxb-perl5.30.0-WWW-RobotRules-6.02
  /nix/store/94x62c5r7sx8gk3aixlfsfzdfqxap6f5-linux-pam-1.3.1
  /nix/store/95j91i5mkhfwqrscmiz49qab3l343jc7-stdenv-linux
  /nix/store/9bx80yfs8d9gdwgvlq2bwwzagkn901lw-perl5.30.0-File-Listing-6.04
  /nix/store/a0i03hk2jgwpbqh9riny1qdpbiqnh23m-attr-2.4.48
  /nix/store/a31mvmpm5wmx50ikn0c47yw6521pgdpb-gnum4-1.4.18
  /nix/store/a47gcmf3bw2wdl2bpvf1dp1hj40d7rc3-python-2.7.16
  /nix/store/aiakgyjsmx373fl8ppzxxw4aq6hgl9f6-tzdata-2019b
  /nix/store/bmd3pzj2jhj8lfa6r05dxqk37dn11vlp-db-5.3.28
  /nix/store/cdyc50j2xcb6bfnkkvjb2g93f12jx6i8-iana-etc-20190731
  /nix/store/ch63h3ysgnsyjgw0inqplfh5af2bqhxb-xz-5.2.4-bin
  /nix/store/cvzxhlj94pfqi34gx9h0j9c91s0jxw50-nghttp2-1.39.2-lib
  /nix/store/cwrwyingwq2l94ic218h0qpi2g1r6f23-perl5.30.0-CGI-4.44
  /nix/store/cx2a04bg8339r039wqx6wqjblxwjbwg1-sqlite-3.28.0
  /nix/store/czhi20s53ddkyw2bcxqngg8jrf9xrhzv-perl5.30.0-TermReadKey-2.38
  /nix/store/d97kkhkxwj9lxjl4ba81jlzplyzlzjb8-gcc-8.3.0-lib
  /nix/store/ddskigqhqi8n97yinvlz8mn1dyil85mn-perl5.30.0-Try-Tiny-0.30
  /nix/store/df12b5d3w2w9hylqvc365g4vigjmwkcg-perl5.30.0-CGI-Fast-2.15
  /nix/store/dlaqysmjssjs89w4lz8hzpfqmsr0g7w0-openssh-7.9p1
  /nix/store/f8zs7mknva4rdx7zxr6j54y0igh3pras-zlib-1.2.11
  /nix/store/fj97ibrgvnx6xn0xmb0r4ac5p1p93yjp-git-2.23.0
  /nix/store/fldkzixl4ascrrg1cs3j229gn6b9xxiw-patchelf-0.9
  /nix/store/hnzhghlb1k8r1cibhircbba15q3c1j22-libkrb5-1.17
  /nix/store/i4h5rnrfi4yldixi1bhn6qn1cl0zfgrd-ncurses-6.1-20190112
  /nix/store/if0z5pd56ypkjdy06597fh6g8xkzah2a-pcre2-10.33
  /nix/store/ily14d68xl11cnbbkf9svwnzwsrrnzah-bash-4.4-p23
  /nix/store/irwjcfkgygya964mag6b920qws4r1zl7-gnumake-4.2.1
  /nix/store/isvqnvaph6947zhxjp148yy6wkc00184-perl5.30.0-HTTP-Cookies-6.04
  /nix/store/j4ss5kw1nvac313fdfr9qi4p4iappa6g-libedit-20190324-3.1
  /nix/store/jwbp0wxizvfjl99p0nbaagc91sf3hb1h-patch-2.7.6
  /nix/store/k42yw9i3r4pmw78d038k8h7rbn0d0hb2-acl-2.2.53
  /nix/store/kksyrix1bpklvgkmvngcv0q9nh8hn2fl-glibc-2.27
  /nix/store/km6y3bvlqasn23nlz1wqgnhvjhij2g4z-pcre-8.43
  /nix/store/ksw2vbja6hvskw45hay9n91iab5hqamd-perl5.30.0-IO-HTML-1.001
  /nix/store/l9cd8rki40anwhbxwbc7c7hgdmbmz9mk-gnused-4.7
  /nix/store/lrnpy7nv1rrigc4d62fiwr4wkryimzxr-linux-headers-4.19.16
  /nix/store/m5lp2ncwd7wagdny564ji49z4fxigzm6-cracklib-2.9.7
  /nix/store/mqjfwh0b3zdz3n89q71f3px38dlvbybm-gnugrep-3.3
  /nix/store/mymkz6qhf46j6j7nanilyd15cgj5p9br-bzip2-<IP_ADDRESS>.1-bin
  /nix/store/n4mc61zgpx5ardz0h745mrpbx48mzsls-go-1.12.9
  /nix/store/p5g048q89h0qgygpp8zbim7s4ar5nvnv-expat-2.2.7
  /nix/store/q4fcb5l1vyww675n0h7inyxv1sb598kn-gdbm-1.18.1
  /nix/store/qj6cwbhagy1129q39a1d6gj1ricfbjvv-perl5.30.0-LWP-MediaTypes-6.04
  /nix/store/qwm593x9sxd48vz09s523qi4zywfhsks-glibc-2.27-dev
  /nix/store/r3ivkcis026lc6r2xxwa77pk87nzpc2g-perl5.30.0-FCGI-0.78
  /nix/store/r7q1y0v74afrhdg1wqzs8gd7n96nbr98-gawk-5.0.1
  /nix/store/rbgsb818yi7jv82mpbb6d5s2ifhqvpyk-perl5.30.0-URI-1.76
  /nix/store/rv0gdqsiyc9fx5byi77dfya1sh1wn961-openssl-1.1.1d
  /nix/store/rvdl88qb3n3ygnz5fximb8m8f5k8d1a0-perl5.30.0-Encode-Locale-1.05
  /nix/store/rvybssv5lxm6rfdbqmkiapv91hrl5cmx-gzip-1.10
  /nix/store/sxv216w8yphh7v6yvml5z1mab0158dks-ed-1.15
  /nix/store/v0sh346cayav5100ddddw3cidkqf7119-perl5.30.0-HTML-TagCloud-0.38
  /nix/store/v28wx4y2mq5y0i6r2n4yfw71lqvz7wxz-stdenv-linux
  /nix/store/w8nfxqzm3crndmgs1dvhwhkxrnghk57q-db-4.8.30
  /nix/store/wc1yx7svbww211lmj2489j2f42m0p3vv-perl5.30.0-HTTP-Negotiate-6.01
  /nix/store/x1932jrkpksjhwrpamzkd3pgw3yz72rx-perl5.30.0-Test-RequiresInternet-0.05
  /nix/store/xz91amrls208ycv02smhpw0ax8qyx5ji-bzip2-<IP_ADDRESS>.1
  /nix/store/ykxh7hqjh2gyhab540rkavad95rbw6hk-gettext-<IP_ADDRESS>
  /nix/store/znsa81k72j5aaclg1crv5575n4w726fc-gnutar-1.32
  /nix/store/znvp1n80zb9lp50zvf7yn2vz6x42wk24-perl5.30.0-Test-Needs-0.002006
  /nix/store/zylpar0xclgai7xwzi3226w80llq69za-perl5.30.0-libwww-perl-6.39
  /nix/store/zyy26wn23ac3ivl8lkc6wv2bdyjz99h1-bison-3.4.2
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/ily14d68xl11cnbbkf9svwnzwsrrnzah-bash-4.4-p23'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/n4mc61zgpx5ardz0h745mrpbx48mzsls-go-1.12.9'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/v28wx4y2mq5y0i6r2n4yfw71lqvz7wxz-stdenv-linux'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/mymkz6qhf46j6j7nanilyd15cgj5p9br-bzip2-<IP_ADDRESS>.1-bin'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8h3bgs39dhwkbyb8ii1fbb6zrcp4kd1p-coreutils-8.31'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8p0gj2g800971ssm2nnw5aqaydfs5wch-diffutils-3.7'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/6kybix8hndmq5chz7zdjc10v2pvdf0qz-findutils-4.7.0'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/r7q1y0v74afrhdg1wqzs8gd7n96nbr98-gawk-5.0.1'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/8x3lspbpjlm5wpwg3zb2qiksrxblsnax-gcc-wrapper-8.3.0'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/kksyrix1bpklvgkmvngcv0q9nh8hn2fl-glibc-2.27'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/mqjfwh0b3zdz3n89q71f3px38dlvbybm-gnugrep-3.3'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/irwjcfkgygya964mag6b920qws4r1zl7-gnumake-4.2.1'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/l9cd8rki40anwhbxwbc7c7hgdmbmz9mk-gnused-4.7'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/znsa81k72j5aaclg1crv5575n4w726fc-gnutar-1.32'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/rvybssv5lxm6rfdbqmkiapv91hrl5cmx-gzip-1.10'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/jwbp0wxizvfjl99p0nbaagc91sf3hb1h-patch-2.7.6'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/fldkzixl4ascrrg1cs3j229gn6b9xxiw-patchelf-0.9'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/95j91i5mkhfwqrscmiz49qab3l343jc7-stdenv-linux'
warning: substituter 'https://cache.nixos.org' does not have a valid signature for path '/nix/store/ch63h3ysgnsyjgw0inqplfh5af2bqhxb-xz-5.2.4-bin'
cannot build derivation '/nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv' failed
Makefile:64: recipe for target 'libp2p_helper' failed
make: *** [libp2p_helper] Error 1

@dannywillems are you certain nix is installed properly on your system?
Try source ~/.nix-profile/etc/profile.d/nix.sh && nix-shell -p nix-info --run "nix-info -m" -- does this work for you?

You can try this part of the build manually by:
cd src/app/libp2p_helper && nix-build default.nix
I can confirm this command works on my machine

@dannywillems are you certain nix is installed properly on your system?
Try source ~/.nix-profile/etc/profile.d/nix.sh && nix-shell -p nix-info --run "nix-info -m" -- does this work for you?

That's because of missing nix-build in the PATH. Thanks.

nix-build not present in PATH was a partial solution.
libp2p_helper still failing to build:
builder for '/nix/store/9pgyzdhpi42rhh0h8m76kan13bi1gc1l-go-1.4-bootstrap-20161024.drv' failed with exit code 1
cannot build derivation '/nix/store/m4394zjy38v6yd0z6ai2r5gfiwp304dn-go-bootstrap.drv': 1 dependencies couldn't be built
building '/nix/store/9x1ijkj2v60p9lap8kp47hs250xvadb3-go1.12.9.src.tar.gz.drv'...
cannot build derivation '/nix/store/kadbwj9i6qf5p82qvlris6z2x88zkbdx-go-1.12.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k2wskj727jfvpi75g7a1r3qvdpahlk8a-libp2p_helper-0.1.drv' failed

source ~/.nix-profile/etc/profile.d/nix.sh && nix-shell -p nix-info --run "nix-info -m" can you still try this and see if it works? It looks like the go rule is failing on your machine. You can skip that step and download a binary for the libp2p helper tool directly to workaround it.

Closing this issue as it is stale for a long time.


ZIPPacker.open() causes index out of bounds error in Web after updating from Emscripten 3.1.18 to 3.1.39

Godot version
4.2.stable
System information
openSUSE Tumbleweed 20231122 - X11 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1060 6GB (nvidia) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
Browsers tested: Mozilla Firefox 119.0.1 and Chromium 119.0.6045.159
Issue description
Using ZIPPacker.open() crashes in the Web version in Godot 4.2, giving an "index out of bounds" error. This did not happen in Godot 4.1.2. ZIPReader seems to be working correctly. I have only tested Mozilla Firefox 119.0.1 and Chromium 119.0.6045.159  on openSUSE Tumbleweed.
EDIT: The issue seems to have been introduced in Godot 4.2-beta3. In beta 2 this does not happen.
Firefox:

Chromium:

Errors keep appearing in the console as long as the tab is open.
Steps to reproduce
Create an empty project, add a node and attach this script to it:
extends Node

func _ready() -> void:
	var zip_packer := ZIPPacker.new()
	var err := zip_packer.open("user://test.zip")
	print(err)
	zip_packer.close()

And run it on the Web version. It should crash.
Minimal reproduction project
ZIPPackerWeb.zip

After testing, I have confirmed that this regression is introduced in Godot 4.2-beta3. In beta 2 the issue does not occur.

If Emscripten is to blame, then perhaps downgrading it to 3.1.18 might be a good idea for Godot 4.2.1. I just finished a jam game, and some hours before the deadline, I noticed crashes on the Web export on a certain level. I opened the browser console and the messages were the exact same as the ZIPPacker issue (the game doesn't use ZIPPacker). I reverted the game back to Godot 4.1 and it run perfectly.
Unfortunately I'm not sure I can provide an MRP for this. but I could try if it's required. If the Emscripten version changes for Godot 4.2.1, I can try again to see if I can reproduce the issue.

We found the culprit. Emscripten updated their default values for -sSTACK_SIZE and -sDEFAULT_PTHREAD_STACK_SIZE. Reverting back to the original default values fixes your issue.

Indeed, for the record, the change happened in Emscripten 3.1.27.
3.1.26 works fine, if someone needs it to build a custom 4.2-stable (but #86306 should be in 4.2.1-stable).

Thank you so much!


Problem in building vagrant box

Getting the following error message in between the process,
==> default: urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>\n
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!
sh install.sh -v 11.4.4 2>&1
Stdout from the command:
Downloading Chef 11.4.4 for el...
downloading https://www.getchef.com/chef/metadata?v=11.4.4&prerelease=false&nightlies=false&p=el&pv=6&m=x86_64
to file /tmp/install.sh.7872/metadata.txt
trying wget...
trying curl...
grep: /tmp/install.sh.7872/stderr: No such file or directory
trying perl...
trying python...
Unable to retrieve a valid package!
Version: 11.4.4
Please file a Bug Report at https://github.com/opscode/opscode-omnitruck/issues/new
Alternatively, feel free to open a Support Ticket at https://www.getchef.com/support/tickets
More Chef support resources can be found at https://www.getchef.com/support
Please include as many details about the problem as possible i.e., how to reproduce
the problem (if possible), type of the Operating System and its version, etc.,
and any other relevant details that might help us with troubleshooting.
Metadata URL: https://www.getchef.com/chef/metadata?v=11.4.4&prerelease=false&nightlies=false&p=el&pv=6&m=x86_64
\nDEBUG OUTPUT FOLLOWS:\n\nSTDERR from wget:\n\n--2015-08-13 05:49:39--  https://www.getchef.com/chef/metadata?v=11.4.4&prerelease=false&nightlies=false&p=el&pv=6&m=x86_64
Resolving www.getchef.com... failed: Temporary failure in name resolution.
wget: unable to resolve host address “www.getchef.com”\n\nSTDERR from perl:\n\nCan't locate LWP/Simple.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at -e line 1.
BEGIN failed--compilation aborted at -e line 1.\n\nSTDERR from python:\n\nTraceback (most recent call last):
File "", line 1, in
File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "/usr/lib64/python2.6/urllib2.py", line 391, in open
response = self._open(req, data)
File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
'_open', req)
File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
result = func(*args)
File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
return self.do_open(httplib.HTTPSConnection, req)
File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
raise URLError(err)
urllib2.URLError: <urlopen error [Errno -3] Temporary failure in name resolution>\n
Stderr from the command:
cp: cannot create regular file `/etc/chef/encrypted_data_bag_secret_key': No such file or directory

Your DNS is busted so 'www.getchef.com' isn't resolving, there's nothing really to fix on our end here.  You could try using the IP address directly to work around that.


Possibility to deploy with ARM device tree on any devices

I'm sorry, but I'm afraid that's not enough to deploy to "any devices" :)


Updating TabView to consume DropShadows

Description
Since DropShadows don't require a caster or receiver, this PR removes references to the TabView's caster/receiver combo and adds checks for OS version 21H1 in codebehind. The selected TabViewItem itself will have the DropShadow.
Screenshots

/azp run

/azp run


Can't send One tokens from my 1wallet

After trying to send one token to another wallet, the token did not leave, but since then I just can't send tokens anymore. I only got "validation error". So my money are actually stuck in my 1wallet\Thanks

@Lentz70 Can you provide the wallet address?

Im having the same issue

@polymorpher seems like The relayer HTTPS cert expired.

Is there a solve for the problem?

@Talawah1 It should be quick fix. I am not sure when @polymorpher will be available.
One workaround is to go to https://relayer.onewallet.hiddenstate.xyz/ and trust the site. (NOT RECOMMENDED)

Okay, thank you very much. I'll wait

Sorry about that. I will set up a few more relayers over the next few weeks.

Also, the certificate is renewed. The issue should be fixed.

Leaving it open for now since @Lentz70 never replied and confirmed whether it is the same issue

Sweet. Thank you so much!

@Lentz70 please reopen if the issue persists

HI There
one1zgep0zqjd8rdrpxya4c5he3lcul429shl704z7
This is my adress
The problem it's still there, nothing changed
@.***(https://github.com/Lentz70)
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, December 12th, 2021 at 01:36, CY Lim @.***> wrote:

@.***(https://github.com/Lentz70) Can you provide the wallet address?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


[HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Refactor  CompactionTriggerStrategy.
Brief change log

Replace conditional in ScheduleCompactionActionExecutor with polymorphsim of CompactionTriggerStrategy class.

Verify this pull request
(Please pick either of the following options)
This pull request is a refactor work and covered by org.apache.hudi.table.action.compact.TestInlineCompaction.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@xushiyan @yanghua @leesf .
Excuse me.I looked into this CI failure case in the backgroud of this pr. There are some interesting appearance in test cases , such as TestHoodieSparkMergeOnReadTableInsertUpdateDelete, etc.
            String newCommitTime = "001"; // ---------------(1)       client.startCommitWithTime(newCommitTime);       List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 200);       insertRecords(metaClient, records, client, cfg, newCommitTime);
The new CompactionTriggerStrategy will use commit instant time parameters and use delta commit info parameters to judge the state.
When the variable "001" tagged with (1) was transported into HoodieInstantTimeGenerator#parseInstantTime(String timestamp) , the newCommitTime value was not compatible with the parse pattern yyyyMMddHHmmss declared in HoodieInstantTimeGenerator#INSTANT_TIME_FORMATTER. At the same time, the compact configuration item was set as 'NUM_COMMITS' . As a result of the setting, the old CompactionTriggerStrategy would judge the state without instantTime parameters. The new CompactionTriggerStrategy will use both instantTime and commitNumber parameters to judge the state  on the contrary, which is the reason why the old  CompactionTriggerStrategy could be successful but new CompactionTriggerStrategy would be unsuccessful. With my limited read, we could enhance the validation of commitTime (1) in the target format yyyyMMddHHmmss or stop the refactor in the pr.
Please let me know what's your opinion.

@yanghua Thanks so much for your suggestions, which appears to have a good result on checking check the Azure CI.
Thanks again.

@yanghua Thanks so much for your suggestions, which has a good result for my checking the Azure CI. Thanks again.

You are welcome, I will have a final check soon. Since you have refactored code.

@hudi-bot run azure

@danny0405 Double check?

@hudi-bot run azure

cc @leesf

Excuse me, @xushiyan Shall we close the PR ?

@RocMarshal the last CI build passed. I'll take a pass later. We're close to land this. Thanks for the patience

Ccn @yihua who worked on lot of client refactoring code

@vinothchandar I made some change based on your comments. PTAL. Thanks.

 But would like to understand the main benefit of this change: is it meant for portability of these logic? @RocMarshal

Thanks @xushiyan for the review. After listening to your opinions, I don't think this reconstruction seems to be much significant.
Or turn it off.
If new strategies are introduced in the future, it goes perhaps without good scalability.


customize background color

I'd really like to be able to customize the background color of non data cells (ie., the cells below and to the right of my data). It seems they are always painted white and there's no way to control that or even paint over it.

Using a ThemeProvider and setting bgCell: '<your color>' colors the cells below and to the right for me.
<ThemeProvider theme={{ bgCell: '#FF0000' }}>
  <DataEditor ... />
</ThemeProvider>

@bjgrosse does @pzcfg's solution resolve your issue? if not, I'll leave this issue open.

You can do this by setting the root themeProviders bgCell: to whatever you want the non-data cell background to be, and then for every cell you produce out of getCellContent you can provide a different bgCell value in the overrideTheme.

You can also do this at the column level instead for a slightly different effect (rows that are blank because there is not enough data will still color as the override color)

@jassmith there's another reason this approach doesn't work: the bgCell of the global theme is what is used for the background of the DataGridOverlayEditorStyle and thus the bgCell of the themeOverride on the cell itself is not honored:


error:speech to text

Hello, I used speech to text in ue5.1, but it did not take effect, and only start has a return value for the node. Is there any problem?

text to sound is ok


helm: Remove redundant capabilities

The cilium agent container already runs as a privileged container, so
there is no need to grant additional capabilities, as it already has all
of them. This section will become relevant again once we remove
privileged from the DaemonSet, but in the meantime there is no reason
to keep an incomplete and redundant list of capabilities.
I did a quick git blame on the source of the two capabilities that we had,
and I don't see any rationale as to why they were added. It's also clear
that the set of capabilities is incomplete, as evident by the list
provided in #14446.
I also manually verified this locally, here is the set of capabilities
given to the cilium-agent process with this change applied,
note sys_module and net_admin are both present.
# pscap -a
ppid  pid   name        command           capabilities
0     1     root        cilium-agent      chown, dac_override, dac_read_search, fowner, fsetid, kill, setgid, setuid, setpcap, linux_immutable, net_bind_service, net_broadcast, net_admin, net_raw, ipc_lock, ipc_owner, sys_module, sys_rawio, sys_chroot, sys_ptrace, sys_pacct, sys_admin, sys_boot, sys_nice, sys_resource, sys_time, sys_tty_config, mknod, lease, audit_write, audit_control, setfcap, mac_override, mac_admin, syslog, wake_alarm, block_suspend, audit_read

Fixes: #17118

test-me-please

ConformanceEKS is currently known to be broken https://github.com/cilium/cilium/issues/17139

test-me-please

Image build was somehow not triggered. Reopening to kick off GitHub Actions again.

test-me-please

k8s-1.19-kernel-5.4 hit #16852 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-5.4/843/
Some CI 3.0 timed out due to the image build still being wonky due to GitHub. Restarting them.

ci-awscni

ci-aks

ci-eks

ci-gke

ci-external-workloads

ci-multicluster

test-1.19-5.4

ci-gke

ci-eks

I'm marking this ready-to-merge. The only CI failure on ConformanceGKE (which doesn't even use the Helm charts, thus is unrelated) failed in no-policies/pod-to-world/http-to-cilium-io-1, which is known to be flaky: https://github.com/cilium/cilium/runs/3419400227?check_suite_focus=true

Close all issues accounts and accounts
Then delete all accounts

Close all issues accounts and accounts
Then delete all accounts


image alignment issue

It seems that the alignment between HR and LR generated by your program is off and it could be related to the following code (different from original version).  But somehow after USRNet, the alignment is back to normal.  This is quite confusing.
https://github.com/JingyunLiang/FKP/blob/5ca3f7c39ba849408993cec64341e2639063984f/data/prepare_dataset.py#L24

As claimed in Sec.6.1 of the paper,  Following  Kernel-GAN [3] and USRNet [53], the blur kernel is shifted and the upper-left pixels are kept in downsampling to avoid sub-pixel misalignments.  Both our paper and USRNet assume the kernel is shifted. Therefore, when inputting the estimated kernel (shifted) to USRNet,  it can generated aligned images automatically, as it is trained in this way (LR+shifted kernel-->aligned HR).

Feel free to open it if you have more questions.


Fixed is_authenticated in the template html files

I fixed the is_authenticated method in the template html files to account for the changes in Flask-Login 0.3.0

This does not suffice without bumping up package versions in requirements.txt.

Has someone forked this project? This problem has existed for about a year I think, nothing from the author. Is he dead??

No forks that I know of. He probably just hasn't had any time to put into
it.
On Jul 17, 2016 4:26 PM, "curioussavage"<EMAIL_ADDRESS>wrote:

Has someone forked this project? This problem has existed for about a year
I think, nothing from the author. Is he dead??
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lingthio/Flask-User-starter-app/pull/12#issuecomment-233205161,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIeMrZM8PZ-LPgsm7Aqtrq7nv6gJKXJ7ks5qWp4SgaJpZM4GBBho
.


Prometheus is not compatible with version 3.0.0

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
When using the Prometheus LXC script an error is given saying that cant execute the command mv consoles/ console_libraries/ /etc/prometheus/ due to the folder being non existant.
What settings are you currently utilizing?
Default Settings
Which Linux distribution are you employing?
Debian 12
If relevant, including screenshots or a code block can be helpful in clarifying the issue.
No response
Please provide detailed steps to reproduce the issue.
Just run the script.

Just encountered the same issue.

If you use the Install Script (new LXC) or on Update?

New install.
On 11/16/24 16:13, CanbiZ wrote:

If you use the Install Script (new LXC) or on Update?
—
Reply to this email directly, view it on GitHub
https://github.com/community-scripts/ProxmoxVE/issues/289#issuecomment-2480811338, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNCPP4EDKQSXHRQA6ZW4JT2A6YO7AVCNFSM6AAAAABR5E7NJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQHAYTCMZTHA.
You are receiving this because you commented.Message ID:
@.***>

Same issue while trying to install

Same issue here when updating, so I just commented out that line and it seems to work.

I take a look tomorrow and fix it

Thanks for resolving this so quickly!  (And for your work to keep the Helper scripts going under these difficult circumstances.)

Thanks a lot and keep up with the good work @MickLesk  👍


Does not work on Windows

Describe the bug
Running the extension just after installing it shows,
--: line 1: C:\Users\heaths\AppData\Local\GitHub CLI\extensions\gh-clean-branches\gh-clean-branches: cannot execute: required file not found

This appears to be because it requires zsh instead of bash, the latter of which is installed with git and accessible to any callers.
To Reproduce
Steps to reproduce the behavior:

Install it this extension on Windows.
Just run it.

Expected behavior
Passing with --dry-run should show me watch branches I can delete.
Desktop (please complete the following information):

OS: [e.g. iOS] Windows
Version [e.g. 22] 11

Additional context
I wrote a GitHub CLI extension using script a while back using bash and can repro this same error if I just change the shebang to require zsh.

Hi @heaths,
Thanks for trying the extension, and for investing the time in trying to improve it.
Unfortunately, the extension depends on zsh as mentioned.
There was a great work done by @ndom91 in this PR to refactor the code to bash, but it didn't pass tests yet.


Ignore links per-crate?

Right now you can ignore links globally:
[ignore]
"name" = [ "link 1" ]

and per-file:
["tracing-core/src/lib.rs"]
"`downcast_ref`" = [ "#method.downcast_ref" ]

but not per crate. It would be nice to be able to say "ignore links to String, but only in the core crate".
I'm not sure how to fit that in to the existing syntax - I think we might have hemmed ourselves in by getting too clever with the keys. Maybe something like this?
[[crate]]
name = "core"
"String" = "../../std/str/struct.String.html"

That means you can't ignore a name link I think, but I'm not sure what other syntax intra-conv could use.

I never understood toml tables.
I agree this would be nice to have but I'm not sure how to fix it. Your proposed syntax is nice but I don't want to lock people out of using name or any other identifier within a crate-wide ignore.
The current solution is to have an ignore file per-crate but this obviously does not scale well.
I'll think about it some more before making a choice.

The current solution is to have an ignore file per-crate but this obviously does not scale well.

Oh I didn't think of that - that would probably work for me. I'm not sure how intraconv detects crates though, I think if I run it in the root of a workspace it will use the same ignore file for each?

Yes, you would have to run it for each crate separately and either give it a specific ignore file or put one in each crate directory and run intraconv from this directory. Not very agreeable to use but it should work


Create switch to turn off heat balance enforcement

Currently enforced here:
https://github.com/VSPEC-collab/VSPEC/blob/6d3146128df1c6c7e1d1e6f1d3c30178cb7760a4/VSPEC/gcm/structure.py#L375-L379

Fixed by #31


Update build scripts for Continuum products

Download links are changed to HTTPS. This is important especially for latest version of miniconda as there is no SHA256 to keep users from MITM attack.
Anaconda 2.5.0 is added as well.

Good catch :+1: Thanks~


fixes of branch h/es2015

fix variable name
fix injection of module

Hi @Kaijun
thanks for the fixes, the branch h/es2015 is work in progress that I started in my spare time.
I also saw your i18n PR #203 - this should be against master though.
We'd also need a signed CLA to be able to merge your changes.

Hi Chaudum,
Kaijun in our developer from ZhongKeJuHui. We already signed the CLA before.
Best,
Zipeng

great to hear that :) @Kaijun @zipeng


Error: Command failed with exit code 1: yarn add pgerror<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=18.x.x". Got "19.6.0"error Found incompatible module.yarn add v1.22.19[1/5] Validating package.json...info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

🐛  Bug Report
🤷♀ What did you do

⛔  Error log
Command failed with exit code 1: yarn add pg
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=18.x.x". Got "19.6.0"
error Found incompatible module.
yarn add v1.22.19
[1/5] Validating package.json...
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
🕵♀ Stack trace
Error: Command failed with exit code 1: yarn add pg
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=18.x.x". Got "19.6.0"
error Found incompatible module.
yarn add v1.22.19
[1/5] Validating package.json...
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    at makeError (/home/asavienko/.npm/_npx/c78dafd2dc881eeb/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/home/asavienko/.npm/_npx/c78dafd2dc881eeb/node_modules/execa/index.js:118:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async installDependecies (/home/asavienko/.npm/_npx/c78dafd2dc881eeb/node_modules/@strapi-community/dockerize/core/dependencies.js:21:3)
    at async /home/asavienko/.npm/_npx/c78dafd2dc881eeb/node_modules/@strapi-community/dockerize/index.js:57:4

🙇♀  Expected behavior/code
A clear and concise description of what you expected to happen (or code).
👩💻 Environment

📦  Node version:  v19.6.0
💻  OS: linux x64

💡 Possible Solution

📺 Additional context/Screenshots

You will need to use node 16-18 and not 19 :)


Logging doc with logFile default path behavior note

:+1: thanks for this!
next time, no need to open multiple PRs to amend your initial work.  as the discussion unfolds and you make additional tweaks the new commits in your feature branch appear in the Pull Request as soon as you push them up to your own fork.
once everyone is satisfied we can always squash down the commits if necessary.


Adding country codes to all countries and correcting few country names

Adding country codes to all countries and correcting few country names.

Thanks you. I will review it this week 🙂

any update on this @saveav

I think it's good to merge... I will merge it :) Thank you @raghuvarmabh
I will publish a newer gem version soon. Thank you for this :)

Hey Saveav/World_airports,
If you can publish a new version that would be great.
Thanks,
Raghu
On Wed, Jul 10, 2019 at 3:39 AM adam not-levine<EMAIL_ADDRESS>wrote:

I think it's good to merge... I will merge it :) Thank you @raghuvarmabh
https://github.com/raghuvarmabh
I will publish a newer gem version soon. Thank you for this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/saveav/world_airports/pull/4?email_source=notifications&email_token=AB46MME3DOEAFO3YLE624QDP6W34RA5CNFSM4H35XY52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZTB5PY#issuecomment-510009023,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46MMGGNLM53DT5GWDRYXLP6W34RANCNFSM4H35XY5Q
.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

Yes. I agree with you. I will bump the version and publish it to RubyGem probably this weekend. Sorry for keeping you waiting.

I am sorry I was unable to publish a new version last week. I will try to do it today. Thank you.

Thanks
Raghu
On Sunday, July 28, 2019, adam not-levine<EMAIL_ADDRESS>wrote:

I am sorry I was unable to publish a new version last week. I will try to
do it today. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/saveav/world_airports/pull/4?email_source=notifications&email_token=AB46MMAGHIXTVPSXVOYHGUTQBZFMXA5CNFSM4H35XY52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27MIGY#issuecomment-515818523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46MMESNSOIGGGTFJFI2LDQBZFMXANCNFSM4H35XY5Q
.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

Any update on this?
Regards,
Raghu
On Mon, Jul 29, 2019 at 7:53 AM Raghu V<EMAIL_ADDRESS>wrote:

Thanks
Raghu
On Sunday, July 28, 2019, adam not-levine<EMAIL_ADDRESS>wrote:

I am sorry I was unable to publish a new version last week. I will try to
do it today. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/saveav/world_airports/pull/4?email_source=notifications&email_token=AB46MMAGHIXTVPSXVOYHGUTQBZFMXA5CNFSM4H35XY52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27MIGY#issuecomment-515818523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46MMESNSOIGGGTFJFI2LDQBZFMXANCNFSM4H35XY5Q
.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

I create a new pr to suppress a warning. Can you merge it. And if you dont
have time to create a new version I can do it for you. Let me know if you
need any help.
Thanks,
Raghu
On Thu, Aug 8, 2019 at 9:14 AM Raghu V<EMAIL_ADDRESS>wrote:

Any update on this?
Regards,
Raghu
On Mon, Jul 29, 2019 at 7:53 AM Raghu V<EMAIL_ADDRESS>wrote:

Thanks
Raghu
On Sunday, July 28, 2019, adam not-levine<EMAIL_ADDRESS>wrote:

I am sorry I was unable to publish a new version last week. I will try
to do it today. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/saveav/world_airports/pull/4?email_source=notifications&email_token=AB46MMAGHIXTVPSXVOYHGUTQBZFMXA5CNFSM4H35XY52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27MIGY#issuecomment-515818523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46MMESNSOIGGGTFJFI2LDQBZFMXANCNFSM4H35XY5Q
.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.

--
Thanks and Regards,
Raghu Varma Bhupathiraju.


Underscore for italics

Would be good to have a user setting to use _underscore for italics_.

How do you think we deal with the bold text?
Sharing a setting or have another setting?

I actually thought that bold needs to always be **, I've never seen underscores used for that even though the CommonMark spec seems to allow that. But I'd be happy with just a config variable for the italics character.

👌

Appreciate your responses, your extension makes the Markdown editing experience in VSCode much better!