Feature Support API (Part 2)

This is the second part of the new feature support (class) APIs. The branch is constantly synced with the first part so all modifications suggested in the previous PR review is pushed to this branch as well. The new code is also updated to stay consistent with part 1. Once the part 1 PR is merged you'll be able to see the code changes more clearly, but you can take a look right now at the new features and check routines. I will forward the open questions to this PR.
I'll make inline comments about code snippets for potential discussion, but you're always welcome to provide feedback anywhere in the code.

I've merged the first PR. Interestingly, GitHub didn't update the code diff when the target branch changed.

Updates in the latest commit:

Fixed an issue with caps that exist in more than one feature. See the following comments for details.
Renamed loop variables to be more descriptive.
Use TIER_0 as default values for applicable caps.
Minor format fix.

I've decided to keep only one initialization method for the class:

User create an empty object using the default constructor.
User calls the Init() function to initialize the object. User can read the HRESULT returned by Init() to learn if the construction succeeds or fails.

While this is not the most elegant solution, I believe it is the most straightforward way to resolve the issue and requires minimal changes to the current code.

I've made a new commit that addressed the discussed issues. Though the code looks quite different, I've only made some changes in code structure and formatting with little changes on the actual contents:

Kept only the default constructor and the Init() function. Removed Create() and the customized constructor.
Removed a duplicate SharedResourceCompatibilityTier getter function from the Displayable feature.
Moved opening curly braces to new lines.
Separate function declaration from definition. Moved definition out of the class.
Replaced some macros with actual code.
Updated basic test files.


Optimize ADSR

Included these changes in #60 -- closing this

Included these changes in #60 -- closing this


Test suite for the type complexity analysis algorithm

Summary
Changes are not 100% ready but I am requesting feedback and input on 1 particular problem I am having.
When working with lists in graphQL, the type complexity of the query is dependent on the number of objects returned in the list. For example, on line 263 in typeComplexityAnalysis.test.ts:
query = `
     Query {
          human(id: 1) {
               name,
               friends {
                   name
                }
           }
    }`;

the field friends is a list that returns an unknown number of objects in the response. How would we account for this when writing the complexity algorithm? Does this need to be accounted for the buildTypeWeights function?
Similarly on line 271 in typeComplexityAnalysis.test.ts,
query = 'Query {reviews(episode: EMPIRE, first: 3) { stars, commentary } }';

the number of objects in the response is 3, but it could 4, or 5. It's variable based on the client requests. Should the typeComplextyAnalysis algorithm take in the query variables as an argument in order to estimate maximum size that the response could be?
Type of Change

[ ] New feature (non-breaking change which adds functionality)

Issues
closes #8
Evidence

Re: your second question about taking into account first and limit arguments. Yes, I think we should do account for these in our calculation in order to get an accurate complexity estimate. So if the query is asking for the first: 3 Users and each User has a weight of 1 then the overall complexity would be 3. I think that the names of these variables would need to be defined somehow if the config so that the algorithm knows what arguments to look for. Maybe something like a paginationArgName and limitArgName that default to first and limit respectively.
As for unbounded lists. I'm not sure and I don't see a way to precompute this without having access to the database. We could have this to default to some value, make it configurable or cache the complexity each time an unbounded collection is resolved. The first call would be 'free' but after that there would be an accurate estimate.
I'll poke around some of the existing packages and see if they handle this case.


eltclsh: init at 1.18

Description of changes
Added eltclsh, a REPL for Tcl based on editline, similar to tclreadline.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 169941 run on x86_64-linux 1

1 package built:

eltclsh

Thank you!


Error when trying to train with pipeline parallelism

Hi guys,
I was trying to train a transformer model with pipeline parallelism. Is this supposed to work already?
The command i tried (following the translation example):
fairseq-train     data-bin/iwslt14.tokenized.de-en     --arch transformer_iwslt_de_en_pipeline_parallel --share-decoder-input-output-embed     --optimizer adam --adam-betas '(0.9, 0.98)' --clip-norm 0.0     --lr 5e-4 --lr-scheduler inverse_sqrt --warmup-updates 4000     --dropout 0.3 --weight-decay 0.0001     --criterion label_smoothed_cross_entropy --label-smoothing 0.1     --max-tokens 4096     --eval-bleu     --eval-bleu-args '{"beam": 5, "max_len_a": 1.2, "max_len_b": 10}'     --eval-bleu-detok moses     --eval-bleu-remove-bpe     --eval-bleu-print-samples     --best-checkpoint-metric bleu --maximize-best-checkpoint-metric --pipeline-model-parallel --pipeline-encoder-balance '[8]' --pipeline-encoder-devices '[0]' --pipeline-decoder-balance '[1,6,1]' --pipeline-decoder-devices '[0,1,0]' --pipeline-chunks 1 --distributed-world-size 2
error:
2020-10-23 17:17:08 | INFO | fairseq.tasks.translation | [de] dictionary: 8848 types
2020-10-23 17:17:08 | INFO | fairseq.tasks.translation | [en] dictionary: 6632 types
2020-10-23 17:17:08 | INFO | fairseq.data.data_utils | loaded 7283 examples from: data-bin/iwslt14.tokenized.de-en/valid.de-en.de
2020-10-23 17:17:08 | INFO | fairseq.data.data_utils | loaded 7283 examples from: data-bin/iwslt14.tokenized.de-en/valid.de-en.en
2020-10-23 17:17:08 | INFO | fairseq.tasks.translation | data-bin/iwslt14.tokenized.de-en valid de-en 7283 examples
Traceback (most recent call last):
  File "/secondary/thies/.virtualenvs/pytorch-23102020/bin/fairseq-train", line 33, in <module>
    sys.exit(load_entry_point('fairseq', 'console_scripts', 'fairseq-train')())
  File "/tertiary/thies/fairseq/fairseq_cli/train.py", line 352, in cli_main
    distributed_utils.call_main(cfg, main)
  File "/tertiary/thies/fairseq/fairseq/distributed_utils.py", line 301, in call_main
    cfg.distributed_training.distributed_world_size,
  File "/secondary/thies/.virtualenvs/pytorch-23102020/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 247, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/secondary/thies/.virtualenvs/pytorch-23102020/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 205, in start_processes
    while not context.join():
  File "/secondary/thies/.virtualenvs/pytorch-23102020/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 166, in join
    raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/secondary/thies/.virtualenvs/pytorch-23102020/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 59, in _wrap
    fn(i, *args)
  File "/tertiary/thies/fairseq/fairseq/distributed_utils.py", line 283, in distributed_main
    main(cfg, **kwargs)
  File "/tertiary/thies/fairseq/fairseq_cli/train.py", line 74, in main
    model = task.build_model(cfg.model)
  File "/tertiary/thies/fairseq/fairseq/tasks/translation.py", line 327, in build_model
    model = super().build_model(args)
  File "/tertiary/thies/fairseq/fairseq/tasks/fairseq_task.py", line 548, in build_model
    model = models.build_model(args, self)
  File "/tertiary/thies/fairseq/fairseq/models/__init__.py", line 56, in build_model
    return ARCH_MODEL_REGISTRY[cfg.arch].build_model(cfg, task)
  File "/tertiary/thies/fairseq/fairseq/model_parallel/models/pipeline_parallel_transformer/model.py", line 277, in build_model
    checkpoint=args.pipeline_checkpoint,
  File "/tertiary/thies/fairseq/fairseq/model_parallel/models/pipeline_parallel_transformer/model.py", line 57, in __init__
    + [encoder.final_layer_norm]
  File "/secondary/thies/.virtualenvs/pytorch-23102020/lib/python3.6/site-packages/torch/nn/modules/module.py", line 796, in __getattr__
    type(self).__name__, name))
torch.nn.modules.module.ModuleAttributeError: 'TransformerEncoder' object has no attribute 'embedding_layer'

For training, the a single Pipe() module needs to be created for the Transformer encoder-decoder model. So, you need to set --pipeline-balance and --pipeline-devices in the training command, instead of --pipeline-encoder-balance, --pipeline-encoder-devices, --pipeline-decoder-balance, --pipeline-decoder-devices.
For inference/generation, two Pipe() modules are created, one for the encoder and one for the decoder, since the encoder and decoder are called separately during generation. So, in that case, you need to set --pipeline-encoder-balance, --pipeline-encoder-devices, --pipeline-decoder-balance, --pipeline-decoder-devices instead.

Awesome, works now.
Thank you very much.


⚠ GitLab Server has degraded performance

In b459cf9, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11789 ms

Resolved: GitLab Server performance has improved in 15955a2.


Add support for clusterawsadm

Signed-off-by: Christophe Jauffret<EMAIL_ADDRESS>
Description
Add support for clusterawsadm CLI in arkade
Motivation and Context

[X] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)
Closes #803

How Has This Been Tested?
./hack/test-tool.sh clusterawsadm
+ go build
+ ./arkade get clusterawsadm --arch arm64 --os darwin --quiet
+ file /Users/cris/.arkade/bin/clusterawsadm
/Users/cris/.arkade/bin/clusterawsadm: Mach-O 64-bit executable arm64
+ rm /Users/cris/.arkade/bin/clusterawsadm
+ ./arkade get clusterawsadm --arch x86_64 --os darwin --quiet
+ file /Users/cris/.arkade/bin/clusterawsadm
/Users/cris/.arkade/bin/clusterawsadm: Mach-O 64-bit executable x86_64
+ rm /Users/cris/.arkade/bin/clusterawsadm
+ ./arkade get clusterawsadm --arch x86_64 --os linux --quiet
+ file /Users/cris/.arkade/bin/clusterawsadm
/Users/cris/.arkade/bin/clusterawsadm: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=5I19QLJndROz4NKhj7_m/kBUP9uPqIFkhZp9k8H6Y/c5SlHMf_qRH6yFdRwcoU/UiBllQtCPcLE1ouQlwxh, not stripped
+ rm /Users/cris/.arkade/bin/clusterawsadm
+ ./arkade get clusterawsadm --arch arm64 --os linux --quiet
+ file /Users/cris/.arkade/bin/clusterawsadm
/Users/cris/.arkade/bin/clusterawsadm: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=mRb7O0ywcuu3ZHT3W__T/pwlBk88vCaSdJMB9AZ_D/1K7gEaq233w_VSYbGODx/CjpssFBE8kPGeCpKZv6P, not stripped
+ rm /Users/cris/.arkade/bin/clusterawsadm

make test
CGO_ENABLED=0 go test github.com/alexellis/arkade github.com/alexellis/arkade/cmd github.com/alexellis/arkade/cmd/apps github.com/alexellis/arkade/cmd/chart github.com/alexellis/arkade/cmd/system github.com/alexellis/arkade/pkg github.com/alexellis/arkade/pkg/apps github.com/alexellis/arkade/pkg/archive github.com/alexellis/arkade/pkg/config github.com/alexellis/arkade/pkg/env github.com/alexellis/arkade/pkg/get github.com/alexellis/arkade/pkg/helm github.com/alexellis/arkade/pkg/k8s github.com/alexellis/arkade/pkg/types -cover
?   	github.com/alexellis/arkade	[no test files]
ok  	github.com/alexellis/arkade/cmd	(cached)	coverage: 17.2% of statements
ok  	github.com/alexellis/arkade/cmd/apps	(cached)	coverage: 1.9% of statements
?   	github.com/alexellis/arkade/cmd/chart	[no test files]
?   	github.com/alexellis/arkade/cmd/system	[no test files]
?   	github.com/alexellis/arkade/pkg	[no test files]
?   	github.com/alexellis/arkade/pkg/apps	[no test files]
?   	github.com/alexellis/arkade/pkg/archive	[no test files]
ok  	github.com/alexellis/arkade/pkg/config	(cached)	coverage: 22.9% of statements
?   	github.com/alexellis/arkade/pkg/env	[no test files]
ok  	github.com/alexellis/arkade/pkg/get	(cached)	coverage: 52.8% of statements
ok  	github.com/alexellis/arkade/pkg/helm	(cached)	coverage: 5.3% of statements
?   	github.com/alexellis/arkade/pkg/k8s	[no test files]
?   	github.com/alexellis/arkade/pkg/types	[no test files]

make e2e
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
......
PASS
coverage: 55.1% of statements
ok  	github.com/alexellis/arkade/pkg/get	(cached)	coverage: 55.1% of statements

Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[X] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[X] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s

[ ] I have tested this on arm, or have added code to prevent deployment

@tuxtof hi. would you mind to update your branch from master? I'll review your PR then.

Hi @Jasstkn
At the time i write the PR in v1.5, windows version was not available
Now with v2.0 it is so i just fix

@tuxtof I've fixed error in e2e pipeline, you can update your branch from master to make it go away.

Let's merge it as is - then we can remove the Windows ARM64 binary ourselves and get this PR closed out.


Integrate player stats with bidding scene

Purpose
Improve UI y'know
What's done already

[x] Fix bidding platforms not being wired up to controller
[x] Assign player stat UIs to panels
[x] Adjust UI to look okay
[x] Limit scaling of stats to always adjust for a new max
[x] Put labels above their stat bar
[x] Hide stats for missing players ;)

Future improvements

[ ] Add icons (text looks bad)

Looks great! 👍
Read code and tested, works fine on my end.
As I mentioned we might want to think about "bakeing" some state together (eg form DPS), but I'll create a separate issue for that I think.
Great work, I approve! :)

Yeah, the stats aren't final here, I just put together the most reasonable set of stats among the attributes in GunStats.


Make sure that Atom does not get autoupdated when running main process tests

Context
Somehow, after adding a main process test in https://github.com/atom/atom/pull/19109/commits/df54e900d5ef25c7dd52b07d6141c91069ae5208, the Azure builds have started failing on master (example).
By looking at the logs, this seems to be caused by the autoupdate logic being triggered when that test is executed. Then, when Atom gets autoupdated during the CI build, another unrelated test starts failing with the following error:
{ Error: spawn /Users/vsts/agent/2.149.2/work/1/s/out/Atom Dev.app/Contents/MacOS/Atom Dev ENOENT
    at _errnoException (util.js:1024:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
  code: 'ENOENT',
  errno: 'ENOENT',
  syscall: 'spawn /Users/vsts/agent/2.149.2/work/1/s/out/Atom Dev.app/Contents/MacOS/Atom Dev',
  path: '/Users/vsts/agent/2.149.2/work/1/s/out/Atom Dev.app/Contents/MacOS/Atom Dev',
  spawnargs:
   [ '--benchmark-test',
     '/Users/vsts/agent/2.149.2/work/1/s/benchmarks' ] }

This issue only appears on master or on release branches (not on PRs), since the autoupdate logic  only works correctly when executed against a signed build of Atom, and we don't sign Atom on PRs.
Solution
This PR is basically a workaround to avoid autoupdating Atom when running the tests, but the root issue here is that builds generated from CI can get autoupdated, somehow the autoupdate logic should prevent this...

Tests are passing, I'm gonna land this PR and check if it fixes things on master...


Deregistering mappings?

Thanks for the extremely handy little package.
Is there a way to deregister mappings?
I guess for now something like document.querySelector('script[type=importmap')?.remove() is one way to go about it, though it removes all mappings.
The way to implement it nicely, I suppose, could be by generating an unique ID and keeping it as part of the ImportMapper instance; the ID would be assigned to the <script> element returned by generate(), and then deregister() could simply find that script by ID and detach it from DOM (though I’d need to check with import map specs to see whether simply removing mappings from DOM deactivates them immediately).

Actually, I see that the importmap script element is removed immediately, which I guess means it’s not a way to deregister mappings…


How to add a check box "select all" in table header ?

I find this component in the repository : ng2-smart-table/src/ng2-smart-table/components/thead/cells/checkbox-select-all.component.ts
But i don't figure out how to use it. Does anyone have an idea ?

settings = {
actions: false,
pager: {
display: true,
perPage: 14
},
selectMode: 'multi', //to add multi row check box's
columns: {

how to do bulk action in ng2 smart table

hi anyone please help me for a bulk action in ng2 smart table my source is .
settings = {
   selectMode : 'multi',
   mode: 'external',
    columns: {
         name: {
            title: 'Name',
        },
        branch_name: {
            title: 'Branch',
        },
        ifsc: {
            title: 'IFSC',
            width:'15%',

        },
        status_name: {
            title: 'Status',
        },

    },
     actions: {

        columnTitle: 'Actions',
        add: false,
        edit: true,
        delete: true,
        position: 'right',

    },

    pager: {
        display: true,
        perPage: 10,

    },
    edit: {
        editButtonContent: ''
    },
    delete: {
        deleteButtonContent: ''
    },

@jeevitha8123 ,
Looks like you have the select boxes set up. Now you just need to use (userRowSelect)="userSelectRows($event.selected)"
in  to build the list.
userSelectRows(selectedList) {
this.selected = selectedList;
}
Then make a button that calls a function that does something with the list.

Hi guys.
Regarding title of the issue, I guess mine goes here.
I got a custom column using custom cell components and it works great but I need to set as title of the column a checkbox instead of a text.
Actually, I could use directly the existing component of CheckboxSelectAllComponent, but I'm not able to figure out how.
Some help would be highly appreciated!


Concurrent SES and DynamoDB use in Lambda causes Fatal error: Tls Context failed to create.

Describe the bug
Bug issue #1077 in Swift SDK project mentions an exception that is thrown from TLSContext constructor in aws-crt-swift/Source/AwsCommonRuntimeKit/io/TLSContext.swift. The bug is caught in smithy-swift/Sources/ClientRuntime/Networking/Http/CRT/SDKDefaultIO.swift. The error seems to be arising from CRT side, hence submission of this issue.
Expected Behavior
TLS Context should be successfully created.
Current Behavior
Fatal error is thrown when creating TLS context.
Reproduction Steps
Details in issue #1077
Possible Solution
No response
Additional Information/Context
The function is using runtime version: provided:al2.v20
aws-crt-swift version used
0.12.0
Compiler and Version used
Swift 5.7
Operating System and version
Built for arm64 using the swift:5.7-amazonlinux2 image

Blocked by https://github.com/awslabs/aws-sdk-swift/issues/1131

Closing as the ticket has gone stale with no response from the customer.


Doctorine problem/issue, dunno if its from my side or yours.

Hey, I've done everything properly and now I'm tryna' generate the database but I'm getting some weird errors after editing PDOConnection.php and before editing it.
http://prntscr.com/7vuek4

hi, the problem is the connection to your sql server. the script can not connect to the server.

Well, I've fixed it, I've kept trying to type proper connection info and eventually i found out that it requires mysql. But now I'm facing another issue, when I type localhost/pservercmsfull in google chrome I get this : http://prntscr.com/7vuu4x

Didn't try it in the other browsers since I have only google chrome.

you can also use mssql for web db.
localhost/pservercmsfull/public, you have to call that in your browser, you can also change the doc root like i wrote it in the tut

Ok, I've finally managed to get it working. but now I'm getting some errors when I try to surf localhost.
http://prntscr.com/7vzfq7
http://prntscr.com/7vzftx
http://prntscr.com/7vzfxc
Can you tell me what should I do to fix this?
I really appreciate your reply. Thanks =)

did you php composer.phar update ?
it looks like some parts of kokspflanze/small-user missing.

Thanks for your reply^^ It works now. But check out <IP_ADDRESS>
Register, login, many things else doesn't work, do I have to edit anything else other than the files you mentioned in the tutorial?

An error occurred during execution; please try again later.

did you fix it with the composer.phar update?
you can enable the error logging and little debug helper, check https://github.com/kokspflanze/pserverCMSFull/blob/master/config/autoload/sro.example.php#L3-L18
i think you have a error with the mssql connection, maybe wrong username or missing sql driver.

Well, when I fixed the old error I updated composer.json and my application.config was messed up (I edited it xD) then when i used the original one again the site worked. About my mssql connection, I've just checked it out and its fine.http://prntscr.com/7w07eg
Btw, I've added you on skype, can you accept me so we can contact easier? Skype: aeron.53

With updating composer.json  I mean adding 2 new things and edited it like this ; http://prntscr.com/7w0ade

the config, with sql params looks wrong, you didnt set the sql driver, also in composer.json please use https://github.com/kokspflanze/pserverCMSFull/blob/master/composer.json with dev-master and not ~3.4

the main problem was the sql connect, tcp conenction and driver was not set in config.


/reset_counter does not reset host statistics

Title:  /reset_counter does not reset host statistics
Description:
During troubleshooting if someone  collects  statistics from "/stats" and from "/clusters" then the output may show difference if "/reset_counter" was used beforehand.
It seems so that "/reset_counter" does not reset the host statistics.
It is desirable to keep those stats in sync.

@mattklein123  I'm interested for implementing it.

@Lynskylate sounds great! The easiest way to implement this is probably can be to iterate through every cluster and every known host in the admin handler and reset all of the host stats to 0. It's possible this will require allowing the reset operation to be a mutable operation, otherwise the changes will potentially be massive, but I'm not sure. Maybe take a look and come up with a brief implementation proposal before implementing? Thank you!

Any update for this issue?


feature: shared session for multi apollo portal

What's the purpose of this PR
shared session for multi apollo portal
Which issue(s) this PR fixes:
Fixes #3672
Brief changelog
add spring session support and configure the property spring.session.store-type=none on the application.yml as a default value
How to use
1. No session data-store(dufault)
clear all of the property spring.session.store-type on the properties files(such as application-github.properties), environment variables and system properties
2. Redis backed sessions
configure the properties spring.session.store-type=redis, spring.redis.* on the properties files(such as application-github.properties), environment variables or system properties
3. JDBC backed sessions
configure the properties spring.session.store-type=jdbc, spring.datasource.* on the properties files(such as application-github.properties), environment variables or system properties
configure the property spring.session.jdbc.initialize-schema=always on the properties files(such as application-github.properties), environment variables or system properties to create the table automatically  while first time startup and then configure the property spring.session.jdbc.initialize-schema=never
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

Codecov Report

Merging #3786 (3138ad1) into master (6ed203a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3138ad1 differs from pull request most recent head 802e494. Consider uploading reports for the commit 802e494 to get more accurate results

@@            Coverage Diff            @@
##             master    #3786   +/-   ##
=========================================
  Coverage     50.47%   50.47%
+ Complexity     2392     2389    -3
=========================================
  Files           458      458
  Lines         14472    14472
  Branches       1467     1467
=========================================
  Hits           7305     7305
  Misses         6663     6663
  Partials        504      504

Impacted Files
Coverage Δ

...work/apollo/biz/message/DatabaseMessageSender.java
56.25% <0.00%> (-8.34%)
:arrow_down:

...ervice/service/ReleaseMessageServiceWithCache.java
85.88% <0.00%> (-1.18%)
:arrow_down:

...mework/apollo/portal/component/PortalSettings.java
65.62% <0.00%> (+7.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed203a...802e494. Read the comment docs.


Installation instructions provided only for MacOS

Installation instructions https://dashlane.github.io/dashlane-cli/install mention only MacOS.
Install page is clear for MacOS https://dashlane.github.io/dashlane-cli/install :

One of our teammates (I am a Dashlaner) tried installing on Windows and got this error:

Are other platforms supported? If yes, let's add instructions. If no, let's make it explicit and avoid later disappointment :')

For your information, this blue screen is displayed if you try to double click on the executable which is not the way it is intended to run. By the way if you click on "more info" you can also force run it.
If you run the binary from the command line you won't see it.
I'm updating the documentation accordingly.


Add single line "wrapping" option

I'm not sure how to desribe it, but here are two pics of nano doing it:
https://punpun.xyz/tsf2.png
Move cursor to the right
https://punpun.xyz/nxkw.png

I think this is sort of a subset of #25.

Does the new soft wrap feature cover this?

I think #25 covers this functionality so I'm going to close this issue.


Prevent the use of reserved names

The command line must restrict any attempt to query or create resources using reserved names

The namespaces are prefixed, the user could user any name they want!


GDScript: Allow access to outer constant and enum values

Fix #40857
Fix #52035

Thanks!

Looks that this commit broke unit tests after merging

Indeed it seems this was changed in #52090.


Vanir next

Be advised that this is a work in progress.  Please do not merge to master.  This PR adds Makefile and docker-compose services to add Kafka and Zookeeper for Vanir 2.0 initiative.   Vanir 2.0 leverages the block explorer to start pushing the data asynchronously to Kafka topics to be used in other API data services in realtime, rather than polling for data in Mongo DB with corn job.  Please do not merge to master as it is subject to much stabilization and active development such as Kafka topics.  Thanks.
Checklist

[x] Targeted PR against correct branch.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Run meteor npm run lint
[ ] Added an entry to the CHANGELOG.md file.
[ ] Re-reviewed Files changed in the Github PR explorer.

Converted to draft as the PR is not ready to merge yet.


[zh] updated volumes.md

Add anchors
Adjust commented sequence of note block

content/zh-cn/docs/concepts/storage/volumes.md

Preview: https://deploy-preview-37630--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/storage/volumes/

/lgtm


Emphasis inline with HTML Entities

The emphasis extension has an issue when trying to emphasise an Html entity:
### Works:
MyBrand^®^ and MyTrademark^™^

This is text MyBrand ^®^ and MyTrademark ^™^

This is text MyBrand^®^ and MyCopyright~©~
This is text MyBrand^12^

### Doesn't work
This is text MyBrand^®^ and MyTrademark^™^

This is text MyBrand~®~ and MyCopyright^©^

which produces:

I was going to take a look at fixing this but the project doesn't work out of box. Yeah I know DNX and project.json versioning stuff 😢

Indeed, according to babelmark
It seems that only Pandoc is supporting this correctly... will try to check why...

I didn't know about babelmark. That's sweet!

This is fixed by b47ae8d
The nuget 0.10.6 is on its way

Checked out in 0.10.6 and all looks good. Thanks for the quick turnaround and getting the NuGet package out - that's awesome!


Fix table1., table2. issue

Problem with two stars:
    var res = alasql('SELECT people.*, companies.* FROM ? AS people JOIN ? AS     companies ON people.company = companies.id',[schema.tables.people, schema.tables.companies]);

http://jsfiddle.net/agershun/6d5ztgzr/

Now it is working.
See the example in jsFiddle.


Add event object to onCheckboxChange

Hi @imballinst,
Thank you again for your previous fix. This time, I'd like to request you to add the event  object to the onCheckboxChange callback. I'm running into this problem for my code:

Add a onRowClick to my table.
Turn on the checkbox option for one of the rows.
Clicking on the checkbox would bubble up the event for the row onclick => it also triggers a onRowClick that I don't want

Having a event to event.stopPropagation() would be great for me to address this issue. I believe you can add it here and maybe anywhere else where the event handler is added.
Thank you again for your time.

hi @Thomas-Boi! Sounds good, I will do these on the next update:

Add event to the onCheckboxChange
Probably for safety measures, I'll add the event.stopPropagation on both onRowClick and onCheckboxChange.

Thanks for the idea!

hi @Thomas-Boi, I have published the beta version: https://www.npmjs.com/package/react-bs-datatable/v/3.8.0-beta.1. Demo can be checked here: https://codesandbox.io/s/youthful-nova-cky9u9?file=/src/App.tsx
Also, I wasn't able to fix the bubbling thingy by stopPropagation. For some reasons, the row on click always gets called first (IIRC stopPropagation only works if it's the children event that's fired first). So I worked it around by checking if the clicked part of the row is either <tr> or <td>.
Let me know if there are things that's still missing. Thanks!

@Thomas-Boi 3.8.0 has been published --> https://www.npmjs.com/package/react-bs-datatable/v/3.8.0. Feel free to re-open or create new issue if there are more issues/requests that you'd like to post. Thanks!


New line breaks the json format and throwing issue

Hello spring team,
I am having issue with complex user query, for simple query it work well. if i try complex query json break to parse.
java.lang.RuntimeException: com.fasterxml.jackson.core.JsonParseException: Illegal unquoted character ((CTRL-CHAR, code 10)): has to be escaped using backslash to be included in string value  at [Source: (String)"{"query": "SELECT SUM(rnd_hours) as total_rnd_hours FROM rnds
I have tried to override McpFunctionCallback and call function to sanitize response. howver work on first call but failed during internal call. I m using mcp-server-mysql https://github.com/designcomputer/mysql_mcp_server. I really dont know issue need to be report here or client . so sorry in advance

Hi @bibekditagtech,
Maybe here we can try to remove any new lines or other special characters returned from the tool call.
The STDIO transport spec: "Messages are delimited by newlines, and MUST NOT contain embedded newlines."

@bibekditagtech this PR (#22 ) escapes the new line characters before sending it to the server's stdin. However the mcp server would likely have to un-escape those.
This seems a general limitation of the stdio transport. The sse transport won't have such problems.

@tzolov when will this be release. I am using             0.2.0-SNAPSHOT which contain old code.

@bibekditagtech, the 0.2.0-SNAPSHOT already contains line escaping functionality. However, this represents the limit of what an MCP client can do - the server must be capable of handling the escaped content.
As an alternative, you can use the remote (HTTP/SSE) transport if your server supports it. This transport method doesn't experience the line escaping issue.


Add missing dependency

This pull-request will fix missing dependency from test.js .
Lines where path package is requested are:

test.js -> 115
test.js -> 116

Please, can you guys also update the npm packages for ukor and wist. And maybe ukor version too. Thanks !

New versions have been published to npm


Chrome extention to change the code into image.

Actually, It's a feature that just came into my mind. As I write tech blogs so whenever I have to give a code snippet, I always have to go to VS Code/Atom etc to paste the code, take a snapshot and then add that snapshot to blog editor.
It will be better If there is a chrome extension (when enabled) can detect the code in the input/text area field and replace it with a formatted image of that code.
I am also willing to work on this feature If this feature is usable.

That's interesting, I could see that being useful for also just quickly creating Carbon images for code you come across when browsing the web (even if you're not writing a blog). This would probably be dependent on #210? A chrome extension isn't something we'll incorporate into the project here, but if you or anyone else gets a chance to make it, we can certainly document it in the README!

I agree this would be useful - especially if you could select a bit of code on the web, and right click to create a carbon image

Hey all, issues marked "Integrations" are being closed and theirs discussions moved to https://github.com/dawnlabs/carbon/issues/358. With many requests for new features, this allows the Carbon team to prioritize which to support first 👍

@as-ajitsingh are you working on the chrome extension?


Add WiFi functionality through the ESP32 (Due: 2024-03-15)

The ESP32 is connected via the I2C bus to the STM32 but neither side has the firmware written to allow for communication. If there is time implement a way to identify message types. I would recommend having the first byte sent from the STM32 be the number of bytes and having the ESP32 read loop for that number of bytes and return an ACK at the end.
Outcomes: Libraries written for the ESP32 and STM32 for communicating arrays of bytes back and forth. Example applications on both ends that demonstrate the functionality using the example HTTP server.

Esp32 module interface has been implemented along with the protobuf message encodings that are used in the i2c interface.
Current TODO:

[ ] Convert lib/dirtviz to an esp32 module
[ ] Add stm32 test code for new message types
[ ] Create stm32 library for external interfaces

Realized that the Arduino Wire (i2c) interface has a software buffer size of 32 bytes which is less than ideal for protobuf messages. The limit of LoRaWAN messages is 222 bytes which exceeds this. The WiFi configuration is ~600 bytes. Need to implement some sort of chunked data transfer over i2c within module_handler interface.

Also thinking of renaming to something like main/sub where the main is on the stm32 and the sub is the current module_handler implementation.

Planning on switching to Controller/Agent naming convention for coms between the stm32 and esp32. On the esp32 side, it was written with the name ModuleHandler that should be changed.

Fixed the issue with every other attempt. Running into an issue where the entire I2C bus stops working. Appears to be bus contention on either the stm32 or fram chip. Tried isolating the problem by disabling ADC and saving static data to no avail. The error is nondeterministic and I'm unable to determine the root cause.
Below are logs on the esp32 side of a failure. Notice that the esp32 will respond with the length but doesn't receive a request from the stm32 to return actual data.
Success
V: cmd.which_command: 3
T: ModuleWiFi::OnReceive
T: WiFiCommand type: 1
T: Calling POST
T: ModuleWiFI::Post
I: WiFi status: 3
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: onRequest
T: ModuleHandler::OnRequest
T: Copy data into the request buffer
T: ModuleWiFi::OnRequest
T: Done processing OnRequest
T: Sending length 7
T: len_bytes = {0x0000, 0x0007}
T: onRequest
T: ModuleHandler::OnRequest
T: Sending data
T: Bytes remaining: 7
V: request_buffer[7] = 0x001A
V: request_buffer[7] = 0x0005
V: request_buffer[7] = 0x0008
V: request_buffer[7] = 0x0001
V: request_buffer[7] = 0x0028
V: request_buffer[7] = 0x00C8
V: request_buffer[7] = 0x0001
T: Writing with finished flag

Failure
T: Wire.read -> 0x00B7
T: Wire.read -> 0x00C0
T: Message done
T: Decoding message
V: receive_buffer[0] = 0x001A
V: receive_buffer[1] = 0x001D
V: receive_buffer[2] = 0x0008
V: receive_buffer[3] = 0x0001
V: receive_buffer[4] = 0x003A
V: receive_buffer[5] = 0x0019
V: receive_buffer[6] = 0x000A
V: receive_buffer[7] = 0x000C
V: receive_buffer[8] = 0x0008
V: receive_buffer[9] = 0x00C8
V: receive_buffer[10] = 0x0001
V: receive_buffer[11] = 0x0010
V: receive_buffer[12] = 0x00C8
V: receive_buffer[13] = 0x0001
V: receive_buffer[14] = 0x0018
V: receive_buffer[15] = 0x00A9
V: receive_buffer[16] = 0x00AA
V: receive_buffer[17] = 0x00F3
V: receive_buffer[18] = 0x00BA
V: receive_buffer[19] = 0x0006
V: receive_buffer[20] = 0x0012
V: receive_buffer[21] = 0x0009
V: receive_buffer[22] = 0x0011
V: receive_buffer[23] = 0x0050
V: receive_buffer[24] = 0x008D
V: receive_buffer[25] = 0x0097
V: receive_buffer[26] = 0x006E
V: receive_buffer[27] = 0x0052
V: receive_buffer[28] = 0x0067
V: receive_buffer[29] = 0x00B7
V: receive_buffer[30] = 0x00C0
T: Forwarding message
V: cmd.which_command: 3
T: ModuleWiFi::OnReceive
T: WiFiCommand type: 1
T: Calling POST
T: ModuleWiFI::Post
I: WiFi status: 3
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: Delaying until available
T: onRequest
T: ModuleHandler::OnRequest
T: Copy data into the request buffer
T: ModuleWiFi::OnRequest
T: Done processing OnRequest
T: Sending length 7
T: len_bytes = {0x0000, 0x0007}

I think the current error for WiFi is related to errors with the bme280code that fails randomly. Logs from example_bme280 for reference.


fix simulator type error on macOS

When building the simulator on macOS, the build fails due to a type error. However, this does not happen on Ubuntu.
To work around this issue, I modified the type declarations used for macOS according to the compiler output.
The contents of the error are as follows. Occurs while running python setup.py install.
this pull request includes https://github.com/EvolutionGym/evogym/pull/30 commits (for passing ci tests)
[ 87%] Building CXX object SimulatorCPP/CMakeFiles/simulator_cpp.dir/Robot.cpp.o
[ 90%] Building CXX object SimulatorCPP/CMakeFiles/simulator_cpp.dir/Sim.cpp.o
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Interface.cpp:1:
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Interface.h:13:
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Sim.h:9:
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.h:9:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "SimObject.h";
                      ^
                      //
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/PythonBindings.cpp:3:
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Interface.h:13:
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Sim.h:9:
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.h:9:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "SimObject.h";
                      ^
                      //
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:334:49: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (top != NULL && top->point_bot_left_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:336:52: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (left != NULL && left->point_top_right_index != NULL)
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:338:60: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (top_left != NULL && top_left->point_bot_right_index != NULL)
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:340:38: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->point_top_left_index == NULL)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:349:50: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (top != NULL && top->point_bot_right_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:351:53: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (right != NULL && right->point_top_left_index != NULL)
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:353:61: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (top_right != NULL && top_right->point_bot_left_index != NULL)
                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:355:39: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->point_top_right_index == NULL)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:364:49: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (bot != NULL && bot->point_top_left_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:366:52: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (left != NULL && left->point_bot_right_index != NULL)
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:368:60: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (bot_left != NULL && bot_left->point_top_right_index != NULL)
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp/opt/ng/evogym/evogym/simulator/SimulatorCPP/Environment.cpp:271:10: error: calling a private constructor of class 'Eigen::Ref<Eigen::Matrix<double, -1, -1, 0>, 0, Eigen::OuterStride<-1>>'
                return empty;
                       ^
:/opt/ng/evogym/evogym/simulator/externals/eigen/Eigen/src/Core/Ref.h:370299::3830::  warning: note: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]declared private here

    EIGEN_DEVICE_FUNC inline Ref(const PlainObjectBase<Derived>& expr,
                        if (current->point_bot_left_index == NULL)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:380:50: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (bot != NULL && bot->point_top_right_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:382:53: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (right != NULL && right->point_bot_left_index != NULL)
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:384:61: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (bot_right != NULL && bot_right->point_top_left_index != NULL)
                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:386:39: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->point_bot_right_index == NULL)
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:398:43: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (top != NULL && top->edge_bot_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:400:32: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->edge_top_index == NULL) {
                            ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:405:43: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (bot != NULL && bot->edge_top_index != NULL)
                                           ~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:407:32: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->edge_bot_index == NULL) {
                            ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
                             ^
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:412:47: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (left != NULL && left->edge_right_index != NULL)
                                            ~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:414:33: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->edge_left_index == NULL) {
                            ~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/Environment.cpp:282:10: error: calling a private constructor of class 'Eigen::Ref<Eigen::Matrix<double, -1, -1, 0>, 0, Eigen::OuterStride<-1>>'
                return empty;
                       ^
/opt/ng/evogym/evogym/simulator/externals/eigen/Eigen/src/Core/Ref.h:299:30: note: declared private here
    EIGEN_DEVICE_FUNC inline Ref(const PlainObjectBase<Derived>& expr,
                             ^/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:419:48: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (right != NULL && right->edge_left_index != NULL)
                                             ~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.cpp:421:34: warning: comparison between NULL and non-pointer ('int' and NULL) [-Wnull-arithmetic]
                        if (current->edge_right_index == NULL) {
                            ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~

/opt/ng/evogym/evogym/simulator/SimulatorCPP/Environment.cpp:294:10: error: calling a private constructor of class 'Eigen::Ref<Eigen::Matrix<double, -1, -1, 0>, 0, Eigen::OuterStride<-1>>'
                return empty;
                       ^
/opt/ng/evogym/evogym/simulator/externals/eigen/Eigen/src/Core/Ref.h:299:30: note: declared private here
    EIGEN_DEVICE_FUNC inline Ref(const PlainObjectBase<Derived>& expr,
                             ^
/opt/ng/evogym/evogym/simulator/SimulatorCPP/Environment.cpp:309:10: error: calling a private constructor of class 'Eigen::Ref<Eigen::Matrix<double, -1, -1, 0>, 0, Eigen::OuterStride<-1>>'
                return empty;
                       ^
/opt/ng/evogym/evogym/simulator/externals/eigen/Eigen/src/Core/Ref.h:299:30: note: declared private here
    EIGEN_DEVICE_FUNC inline Ref(const PlainObjectBase<Derived>& expr,
                             ^
8 warnings generated.
[ 92%] Building CXX object SimulatorCPP/CMakeFiles/simulator_cpp.dir/SimObject.cpp.o
1 warning generated.
[ 95%] Building CXX object SimulatorCPP/CMakeFiles/simulator_cpp.dir/Snapshot.cpp.o
4 errors generated.
make[2]: *** [SimulatorCPP/CMakeFiles/simulator_cpp.dir/Environment.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
25 warnings generated.
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Sim.cpp:1:
In file included from /opt/ng/evogym/evogym/simulator/SimulatorCPP/Sim.h:9:
/opt/ng/evogym/evogym/simulator/SimulatorCPP/ObjectCreator.h:9:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "SimObject.h";
                      ^
                      //
/opt/ng/evogym/evogym/simulator/SimulatorCPP/Sim.cpp:19:28: warning: assigning field to itself [-Wself-assign-field]
        Sim::is_rendering_enabled = is_rendering_enabled;
                                  ^
2 warnings generated.
1 warning generated.
make[1]: *** [SimulatorCPP/CMakeFiles/simulator_cpp.dir/all] Error 2
make: *** [all] Error 2

This pull request will be merged after the CI passes.


How to get all usersdata from a channel ?

You can't, at least you can save info with new_chat_members as they join.


feat: added HashToG2 and BLS G2 signature verification circuit for BLS12-381

Description
This PR implemented circuit for HashToG2 and BLS G2 signature verification for the BLS12-381 curve. The implementation is based on affine coordinations.
Along with the said functionalities, it also added G2.addUnified(p, q) function which can handle the case that p == q. And as an optimization, it also adopted a new hint to calculate the sqrtRatio function with the gnark-crypto library to save constraints. Therefore this PR depends on an update to gnark-crypto
Fixes # (issue)
https://github.com/Consensys/gnark/issues/648
Type of change

[x] New feature (non-breaking change which adds functionality)

How has this been tested?
Added unit tests to cover:

[x] G2.addUnified for BLS12-381
[x] HashToG2 for BLS12-381

How has this been benchmarked?
Added test cases for HashToG2. Results: 2761896 constraints with SCS and 779198 with R1CS for simple message ("abcd").
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I did not modify files generated from templates
[x] golangci-lint does not output errors locally
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

L'et also make it a draft for now as I have a related pending question here: https://github.com/Consensys/gnark/discussions/1041
The background is that I want to ensure that the Domain Separation Tag is constant.

Hi @weijiguo, thank you for this contribution! this is a great work! As you would imagine, it takes a bit of time to review all of this. But it's definitely a great PR that we are looking to merge.

Hi @yelhousni @ivokub  now that we have the 0.11 version. Can you spare some time to review yet? Really appreciate your time among your tight schedule.

static check fails due to needing to merge https://github.com/Consensys/gnark-crypto/pull/481 first

Hi @weijiguo - actually I started reviewing the PR about a month ago, but then realized it would require a bit of work to understand completely and postponed. But indeed, it would be a great addition and it would be good to review. I'll retry again soon, hopefully being more successful.
For example - the first issue I encountered with https://github.com/Consensys/gnark-crypto/pull/481 is that it is implemented only for the BLS12-381 in the code generated path, so would have to add to the code generation. And I think exposing the individual method may overload the ecc/bls12-381 package, so maybe there is a better way for exposing the required functionality.

@ivokub Understood. Thanks again.


Added true and false to the fuzzing list

Changing json field to true or false could have interesting results on an endpoint when fuzzing.

Thank you! 🎉


Merge Hoshi master into Hoshi-Merge to bring things up to speed.

Will review commits between the two and ensure any major differences are worked out before bringing to the master.

Completed


Create MiniMaxSum.py

URL : https://www.hackerrank.com/challenges/mini-max-sum/problem

@anukeshi Please add your name and info in README

#98

Thanks!

@anukeshi I had to revert this pull request because you had the old version of files. Please see that structure of repository is changed now, i apologize for that. But can you please make another pull request for your code file. Thanks


Newly created database not showing up in pull-down

System information:

Operating system (distribution) and version = Linux Mint
DBeaver version = 6.3.2
Additional extensions = none

Connection specification:

Database name and version = MySQL
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)? = no

Describe the problem you're observing:
Newly created databases, using CREATE DATABASE ...  command, are not showing up in the top toolbar pull-down menu and the schema and table names are not showing up in the intellisense either. If I run SHOW DATABASES command the database shows up and I can use/see the tables with the commands.
Restarting DBeaver resolves the issue, [edit] in that the ones created before the restart show up but ones after the restart have same problem.

Thank you for the bug report. It is actual for Win 10 too.

Duplicate of #7924


Change CMAKE_CROSSCOMPILING from ON/OFF to TRUE/FALSE

Describe the bug
Some projects burn the content of the variable of CMAKE_CROSSCOMPILING into their generated code, so that when using the library it can be recognized whether the library was cross compiled or not.
To Reproduce
E.g., see issues here::

https://github.com/microsoft/vcpkg/pull/30950#issuecomment-1520832119
https://github.com/microsoft/vcpkg/issues/8104

Expected behavior
VCPKG should behave like CMake it does, so patches should not be necessary.
Additional context
CMake is using always TRUE or FALSE for CMAKE_CROSSCOMPILING  within their code (not within their tests, but this doesn't matter), see here. Therefore all projects which using something like configure_file to store CMAKE_CROSSCOMPILING into a file, a storing TRUE or FALSE.
In comparison, vcpkg always sets ON or OFF for this variable in the toolchain files, e.g., here:
https://github.com/microsoft/vcpkg/blob/a5d91f7d264786b42b0d6bb7b1d31a3f2842a39c/scripts/toolchains/windows.cmake#L22-L30
This leads to the issue that the libraries that previously had FALSE baked in now have comparisons like if ("OFF" STREQUAL "FALSE") (Note: CMake has no inbuild command to compare boolean values for equality, as STREQUAL is for strings and EQUAL only for numeric values).
To avoid the need for patches in the ports to adjust the baked-in value, it would make sense for vcpkg to adjust to how CMake behaves when invoked without vcpkg.

Note that changing the toolchain files would invalidate all cached artifacts.
These cases are rare, and IMO the mentioned projects are already broken

by relying on a particular literal representation of "true" when CMake language actually allows alternatives.
by assuming that a cross-built package cannot be re-used in a native context and vice-versa. (Packages can be transferred between machines.)

This leads to the issue that the libraries that previously had FALSE baked in now have comparisons like if ("OFF" STREQUAL "FALSE") (Note: CMake has no in-build command to compare boolean values for equality, as STREQUAL is for strings and EQUAL only for numeric values).

So much nonsense. Use if("@CMAKE_CROSSCOMPILING@"). There is no reason to use a "boolean" comparison. CMAKE_CROSSCOMPILING can be an input variable to CMake itself so assuming CMake itself sets it is just wrong.

So much nonsense. Use if("@CMAKE_CROSSCOMPILING@").

As noted above: It is about comparing boolean values for equality and not about checking which value it has. So it is not about if("@CMAKE_CROSSCOMPILING@"), but something like if("@CMAKE_CROSSCOMPILING@" STREQUAL "FALSE").

CMAKE_CROSSCOMPILING can be an input variable to CMake itself so assuming CMake itself sets it is just wrong.

CMake is not wrong at this case as a true constant may be 1, ON, YES, TRUE, Y and a false constant 0, OFF, NO, FALSE, N, IGNORE, NOTFOUND (see here). From the point of view both projects are correct, because both FALSE and OFF are correct for false constants. Technically, it is also correct that you could set the value from the outside as well - but not in this case. As linked above (to their source code), CMake sets this variable within the determine system step - meaning when project is called for the first time, their code is called.
You try it yourself with following CMake code:
cmake_minimum_required(VERSION 3.15)
message("CMAKE_CROSSCOMPILING Pre: ${CMAKE_CROSSCOMPILING}")

project(test)
message("CMAKE_CROSSCOMPILING Test: ${CMAKE_CROSSCOMPILING}")

set(CMAKE_CROSSCOMPILING ON)
project(test2)
message("CMAKE_CROSSCOMPILING Test2: ${CMAKE_CROSSCOMPILING}")

When calling this via cmake . -DCMAKE_CROSSCOMPILING=ON you will get e.g.,:
-- Building for: Visual Studio 17 2022
CMAKE_CROSSCOMPILING Pre: ON
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19045.
-- The C compiler identification is MSVC 19.35.32217.1
-- The CXX compiler identification is MSVC 19.35.32217.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMAKE_CROSSCOMPILING Test: FALSE
CMAKE_CROSSCOMPILING Test2: ON
-- Configuring done (2.4s)

How you can see: CMake is ignoring basically the externally set value (Ignoring = From the perspective that most projects have the project command almost at the beginning of their CMake code). From there, all CMake projects will work with TRUE or FALSE for this one specific variable unless they manually modify the value.

As noted above: It is about comparing boolean values for equality and not about checking which value it has. So it is not about if("@CMAKE_CROSSCOMPILING@"), but something like if("@CMAKE_CROSSCOMPILING@" STREQUAL "FALSE")

It is about testing CMAKE_CROSSCOMPILING. The only way to do that correctly is via:
if("@CMAKE_CROSSCOMPILING@")
or
if("@CMAKE_CROSSCOMPILING@" MATCHES"^(OFF|FALSE|0|NO|<other false criteria>)$")
using STREQUAL assumes an implementation detail of how CMAKE_CROSSCOMPILING is set by CMake without taking into account what actual valid FALSE values are.

@Neumann-A I agree that depending on a specific boolean value in CMake is not the best idea. However, since CMAKE_CROSSCOMPILING is one of those CMake predefined variables that you don't normally change, I can't really blame the authors of the projects that are based on a fixed value, since unfortunately there is no BOOL_EQUAL in CMake and before toolchains became more popular in CMake, it was probably never a issue either.
Btw: I would never using a regex to check for an boolean value in CMake, as the regex engine of CMake is slow. And in this case your alternative suggestion doesn't make much sense either, because it is again only about checking a single value and not about comparing two values (apart from the fact that I think such a list is quite error-prone).
Maybe it would help to understand the problem if I explain the lines that caused the problem in the two referenced projects (geographiclib and liblas) - and who knows how many other projects use that:
These libraries have a line like the following within a file, which will be passed to configure_file (see liblas):
if (NOT CMAKE_CROSSCOMPILING STREQUAL "@CMAKE_CROSSCOMPILING@")

So during configure_file, so the "@CMAKE_CROSSCOMPILING@" will replaced by a boolean value. As it seems that the toolchain files of VCPKG will be only used when including an already installed target, but not during vcpkg install (or the value will be overwritten by an project call there - didn't debugged it), the value will be replaced by TRUE or FALSE, so you have e.g.,
if (NOT CMAKE_CROSSCOMPILING STREQUAL "FALSE")

This line will be executed, when you including this project (e.g., find_package(liblas)). Usually it works - except you are using VCPKG, as VCPKG is setting the value to ON or OFF.
Apart from the fact that I don't know if the projects really need to catch the cross compile case, the question now would be which way to go:

All projects are forced to adapt their code for VCPKG (i.e. a patch for the port is usually added first until it is merged and released upstream), so they are using sth like if((varA AND @varB@) OR (NOT varA AND NOT @varB@)) instead of if(varA STREQUAL @varB@)
Adapt it vcpkg, which would also benefit other (possibly future) ports that they do not have to patch.

@autoantwort The issue is not about checking for a single value, it is about comparing two boolean values.
@dg0yt

Note that changing the toolchain files would invalidate all cached artifacts.

I agree that invalidating a cache is not so wanted. However, it feels like everything is already rebuilt every time I update the manifest file on our project every 1-2 months, since some project gets updated and so do all the ones based on it (even if it wouldn't be necessary, since it's just an ABI compatible update). Or such cases as recently, when arm64ec was added, although one does nothing at all with the ARM architecture. From there I don't see the cache invalidation as a knockout criterion. And since vcpkg also has no major releases, but only date-based version numbers, there is also no perfect time to adjust central changes bundled.
So I would summarize the discussion so far by saying that the decision would be whether to invalidate the cache once or to make all 3rd party projects adapt their code so that the value of CMAKE_CROSSCOMPILING  can be represented by different boolean representations, which probably can only happen currently when using toolchains (I have not tested alternatives to vcpkg now).


Mythical cape left click options

This one I believe would be pretty simple, but to be able to change the left click option on the mythical cape would be great. Currently you can have it changed with the where the left click is the teleport option, but it would be nice to have it follow some of the other frequently used items like karamja gloves where it has its own commands in the plug in. I hope that made sense, anyways I keep teleporting when I go to change gear for the dragon war hammer spec

Also first time using github so I’m sure I’m doing something wrong so please bear with me.

Maybe setting a customizable shift-click option for the mythical cape would be the best solution for you? That way, you can set that option specifically for the cape and nothing else.

Duplicate of #9695


Wrong error message when failing to resolve packages.

While testing I found the following edge case:
Consider the following paket.dependencies
redirects: on
source https://nuget.org/api/v2

//Build
nuget FAKE == 3.36.0
nuget Yaaf.AdvancedBuilding == 0.8.0
nuget FSharp.Formatting == 2.11.1-alpha1
//nuget FSharp.Compiler.Service == <IP_ADDRESS>
//nuget FSharpVSPowerTools.Core == 1.9.0

Paket will complain with
Paket version <IP_ADDRESS>
Resolving packages for group Main:
 - FAKE 3.36.0
 - FSharp.Formatting 2.11.1-alpha1
 - Yaaf.AdvancedBuilding 0.8.0
 - FSharp.Compiler.Service <IP_ADDRESS>
 - FSharp.Compiler.Service 1.3.1
 - FSharp.Compiler.Service 0.0.90
Paket failed with:

Error in resolution.
  Resolved:
   - FAKE == 3.36.0
   - FSharp.Formatting == 2.11.1-alpha1
   - Yaaf.AdvancedBuilding == 0.8.0
   - FSharp.Compiler.Service >= 0.0.90 < 1.4
  Could not resolve package FAKE:
   - Dependencies file requested == 3.36.0
   - Yaaf.AdvancedBuilding 0.8.0 requested 4.0.2
   - Yaaf.AdvancedBuilding 0.8.0 requested 4.0.2
 Please try to relax some conditions.

This is wrong, because we specified (and forced) the FAKE version.
Instead Paket failed to resolve a FSharpVSPowerTools.Core because
Yaaf.AdvancedBuilding requires exactly 1.8 while FSharp.Formatting
requires exactly 1.9.
In fact, the following works as expected:

redirects: on
source https://nuget.org/api/v2

//Build
nuget FAKE == 3.36.0
nuget Yaaf.AdvancedBuilding == 0.8.0
nuget FSharp.Formatting == 2.11.1-alpha1
//nuget FSharp.Compiler.Service == <IP_ADDRESS>
nuget FSharpVSPowerTools.Core == 1.9.0

An other interesting case is

redirects: on
source https://nuget.org/api/v2

//Build
nuget FAKE == 3.36.0
nuget Yaaf.AdvancedBuilding == 0.8.0
nuget FSharp.Formatting == 2.11.1-alpha1
nuget FSharp.Compiler.Service == <IP_ADDRESS>
//nuget FSharpVSPowerTools.Core == 1.9.0

Because in this case Paket will print the correct error message:
Paket version <IP_ADDRESS>
Resolving packages for group Main:
 - FAKE 3.36.0
 - FSharp.Formatting 2.11.1-alpha1
 - FSharp.Compiler.Service <IP_ADDRESS>
 - Yaaf.AdvancedBuilding 0.8.0
Paket failed with:

Error in resolution.
  Resolved:
   - FAKE == 3.36.0
   - FSharp.Formatting == 2.11.1-alpha1
   - FSharp.Compiler.Service == <IP_ADDRESS>
   - Yaaf.AdvancedBuilding == 0.8.0
   - FSharp.Compiler.Service >= 0.0.90 < 1.4
   - FAKE 4.0.2
   - FSharp.Formatting 2.10.0
  Could not resolve package FSharpVSPowerTools.Core:
   - FSharp.Formatting 2.11.1-alpha1 requested 1.9.0
   - Yaaf.AdvancedBuilding 0.8.0 requested 1.8.0
   - FSharp.Formatting 2.11.1-alpha1 requested 1.9.0
 Please try to relax some conditions.

To be clear: The problem is not that paket is failing...
Just the error message is incorrect.

wow interesting case. Will look into this tomorrow during train ride.

could you please try again?

Yes and in fact after reporting I found a very similar edge case where it was a real bug (where paket failed when it shouldn't) which is now gone as well, very nice! As always thanks for the fast release :+1:

Mhm, could you please describe the case? I'm a bit worried when we fixed
something other than error messages here. At least we should create an
regression test to track that constellation.
On Oct 17, 2015 10:35 PM, "Matthias Dittrich"<EMAIL_ADDRESS>wrote:

Yes and in fact after reporting I found a very similar edge case where it
was a real bug (where paket failed when it shouldn't) which is now gone as
well, very nice! As always thanks for the fast release [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/issues/1142#issuecomment-148949579.

Sure... Consider the following paket.dependencies:
$cat paket.dependencies
redirects: on
source https://nuget.org/api/v2

nuget FAKE == 4.7.0
nuget FSharp.Compiler.Service == <IP_ADDRESS>
nuget FSharp.Formatting == 2.11.1-alpha1
nuget FSharpVSPowerTools.Core == 2.1.0
nuget Yaaf.AdvancedBuilding == 0.5.5

paket.exe update fails with 2.14.2
$paket.exe update
Paket version <IP_ADDRESS>
Resolving packages for group Main:
 - FAKE 4.7.0
 - FSharp.Formatting 2.11.1-alpha1
Paket failed with:
        Could not find compatible versions for top level dependency:
     "FSharpVSPowerTools.Core == 2.1.0 (from c:\Projects\paket.test\paket.dependencies)
     FSharpVSPowerTools.Core 1.9.0 (from FSharp.Formatting 2.11.1-alpha1)"
   Available versions:
     - 2.1.0
     - 2.0.0-beta
     - 1.9.0
     - 1.8.0
     - 1.7.0
     - 1.6.1
     - 1.6.0
     - 1.5.0
     - 1.4.0
     - 1.3.1
     - 1.3.0
     - 1.2.6
     - 1.2.5
     - 1.2.1
   Try to relax the dependency or allow prereleases.

But works with latest/current/2.15.1:
$paket.exe update
Paket version <IP_ADDRESS>
Resolving packages for group Main:
 - FAKE 4.7.0
 - FSharp.Formatting 2.11.1-alpha1
 - FSharpVSPowerTools.Core 2.1.0
 - FSharp.Compiler.Service <IP_ADDRESS>
 - Yaaf.AdvancedBuilding 0.5.5
Locked version resolution written to c:\Projects\paket.test\paket.lock
4 seconds - ready.

I think the current behavior is correct as there is basically nothing to resolve (I resolved everything by hand).


Update Gemfile.lock

Update our Gem dependencies to their latest versions.

Warnings

:warning:
ld: dylib (/Applications/Xcode-12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/libXCTestSwiftSupport.dylib) was built for newer macOS version (10.15) than being linked (10.12)

:warning:
ld: dylib (/Applications/Xcode-12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/XCTest.framework/XCTest) was built for newer macOS version (10.15) than being linked (10.12)

:warning:

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

:warning:

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

:warning:

Found a configuration for 'file_length' rule, but it is disabled on 'disabled_rules'.

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L241 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L253 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

:warning:

Tests/MoyaTests/MoyaProviderSpec.swift#L268 - initialization of immutable value 'token' was never used; consider replacing with assignment to '_' or removing it

Messages

:book:
macOS: 	 Executed 321 tests, with 0 failures (0 unexpected) in 16.621 (16.921) seconds

:book:
tvOS: 	 Executed 321 tests, with 0 failures (0 unexpected) in 14.191 (14.531) seconds

:book:
iOS: 	 Executed 321 tests, with 0 failures (0 unexpected) in 14.286 (14.633) seconds

  Generated by :no_entry_sign: Danger Swift against 94d2f7de93e84adbaafbada06c6bdf462488785f

Will address warnings in a follow-up pull request.

Codecov Report

Merging #2189 (94d2f7d) into development (975110e) will increase coverage by 1.44%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development    #2189      +/-   ##
===============================================
+ Coverage        88.78%   90.23%   +1.44%
===============================================
  Files               30       30
  Lines              972      983      +11
===============================================
+ Hits               863      887      +24
+ Misses             109       96      -13

Impacted Files
Coverage Δ

Sources/RxMoya/MoyaProvider+Rx.swift
96.15% <100.00%> (ø)

Sources/Moya/Atomic.swift
100.00% <0.00%> (ø)

Sources/Moya/Cancellable.swift
100.00% <0.00%> (ø)

Sources/Moya/Plugins/NetworkLoggerPlugin.swift
92.13% <0.00%> (+0.27%)
:arrow_up:

Sources/Moya/Moya+Alamofire.swift
85.36% <0.00%> (+0.36%)
:arrow_up:

Sources/Moya/MoyaProvider.swift
94.44% <0.00%> (+3.39%)
:arrow_up:

Sources/Moya/Response.swift
95.29% <0.00%> (+4.70%)
:arrow_up:

Sources/RxMoya/Observable+Response.swift
61.53% <0.00%> (+7.69%)
:arrow_up:

Sources/ReactiveMoya/SignalProducer+Response.swift
93.93% <0.00%> (+9.09%)
:arrow_up:

Sources/RxMoya/Single+Response.swift
100.00% <0.00%> (+12.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a075bd0...94d2f7d. Read the comment docs.


Initial Commit

@suyograo have you had a chance to look at this?

@suyograo sorry to be a nag but, any movement on this?

Hi @jordansissel @suyograo ,
I have signed the CLA. Can we merge this now?

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.


Test Action Occasionally Gets Stuck

Hello, we're using mablhq/github-run-tests-action@v1 in some of our CI/CD workflows.
Most of the time, it works great! Occasionally, maybe 1 out of 10 times, we are seeing an issue where the action hangs on Await completion of tests, and it thinks there is still a test plan running, even if the test plan appears to be complete in the Mabl web UI. We've seen the action get stuck indefinitely, requiring a manual cancellation, or it gets killed when Github's default 6 hour max duration for a step is exceeded.
We know we can add a timeout to the test step, but it still requires manual intervention to follow up on the real test result. We'd love to keep things automated as much as possible!

@shreecodes , thanks for reporting this issue. We've added extra timeout logic that should address cases of occasional "hanging" test runs, in v1.11.
I'm closing this as fixed for now. Please leave a comment if you see a recurrence.


How can I only using client side?

If I only need to render on cilent side, how can I do?

Here.

@erikras  Thx, I knew that but I would like to just package it, and give them to backend member, Don't start and node or expressJS service, is it possible?

 There might be other repos that better represent that, but I've got the docs for Redux-Form doing something like that, served statically. Here's the repo (npm install and npm run dev).

@erikras  thx!, I want to migrate the apiCilent.js from universal example, because it so easy to use than redux official example!


Make total project coverage configurable

Seems like the "total project coverage" currently shows the class coverage.
It would be nice if it could be configured e.g. to show branch coverage.

Thanks for bringing this up 👍 Currently we use the line coverage for showing the total project coverage (see code here). But it would definetly make sense to make this configurable

Thanks for the quick answer!

Configure option for this was released just now with release v1.5 but also made available for the major version v1.

Thank you once more for the super quick reaction!


Bump bass libraries for macOS

Apple started enforcing a minimum SDK version for compiled libraries to be notarized. Bumping bass.dylib to latest official release; bass_fx.dylib to version available here (latest official release is not updated yet).
Don't merge yet, pending integration testing

Tested to be working as expected (runtime)
Tested to silence notarization errors


Improve getObject support， fixed #3194, #3302, #3317

增加内置Filter对 JDK8 ResultSet.getObject(int,Class) 方法和ResultSet.getObject(String,Class) 方法的支持

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

不要对代码格式化，而且代码冲突了


Add support for enum types in the schema.

Add support for GraphQL enums.

Coverage decreased (-1.9%) to 94.186% when pulling 81bdc4848767071c18573e296e6fe8df40580d15 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Coverage increased (+0.4%) to 96.429% when pulling 4bf0a9630a4838770f64fe3ce5f34aada9633fe7 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Coverage increased (+0.4%) to 96.429% when pulling 4bf0a9630a4838770f64fe3ce5f34aada9633fe7 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Coverage increased (+0.4%) to 96.471% when pulling bccdffb042be651e66bbb940b24e9bb5a8ab0d77 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Coverage increased (+0.4%) to 96.471% when pulling bccdffb042be651e66bbb940b24e9bb5a8ab0d77 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Coverage increased (+0.5%) to 96.552% when pulling 89540bcf133f100fcfb5b9c4c94fab37901aa756 on msiegenthaler:enums into eead53c1faa7274c80423b7afc90680444517f16 on nknapp:master.

Let me know if you need a release on npm. I can only do this in the evening or on Fridays (and the weekend).
And please let me know, if you want me to review your code.
I like that the code-coverage increases slightly with every commit your make...

Coverage increased (+0.5%) to 96.552% when pulling b1150477b0c04ee3554a064f9269a7fb922b8743 on msiegenthaler:enums into a67fcc91745a5b8e3e13085cc199a804b4591a5f on nknapp:master.

Coverage increased (+0.5%) to 96.552% when pulling a7ae3f5e385e2814ca272a60084e0f2d764d4045 on msiegenthaler:enums into a67fcc91745a5b8e3e13085cc199a804b4591a5f on nknapp:master.

I have squashed the commits and updated your PR-branch. (hope that was ok). Will merge now. Thanks for your work


More functionalities to Pramda

Hello @kapolos,
First of all, thank you very much for this wonderful library Pramda. I have started using it, in one of the core rewrites of a PHP module - in a functional way.

I would like to cover more functions to Pramda, something that is useful to me, which is covered in Ramda 0.21, but not present in current Pramda. Can I submit a pull request with these additions?

They include:

memoize
pick*
fromPairs
toPairs
path*

and more.

Do you have plans to include Fantasy Land spec?

Hey @rsmoorthy!
I'm very glad you've found Pramda useful for your work! :beers:
I would absolutely love pull requests. :+1: Currently the master branch is based on 0.9 but 0.10 is practically ready (apart from some docs) and so I will wrap it up and merge it into master tomorrow.
Regarding the Fantasy Land spec, my thought at the time was to let its implementation for the future. My main concern with it was in regards to documentation. While someone with a background of FP can easily see what each function does, a newcomer to the paradigm won't. As it is, the practical "documentation" for the functions is to look at the source code. In that sense, it was a deliberate decision to have the source code be as readable as possible. Including the Fantasy Land spec will make the code more complex and harder to read (in regards to the newcomer).
So, my idea was to include the spec after we have some reasonable documentation for each function. That said, nothing is written in stone - if the need for it surpases the current disadvantages, why not?

@kapolos  Thanks for your quick response.
I am making those additions (have done only memoize for now). Will submit the pull request, after the other changes is done as well by next weekend or so. Will do that after your merge, in any case.
My main interest with Fantasy Land spec was more for avoiding exceptions, and handling it via Maybe or Either would be more apt - from a pure FP point of view. But I agree with you, that newcomers (including me, when I started) will struggle to understand both on FP and Pramda. Even in the case of Ramda, they have implemented it as a separate library and none of the core Ramda methods would return a Maybe/Either, for ex, to signal errors. So, I concur with you to - keep Pramda, as is - but may be implement Pramda-Fantasy as a separate class.
If there is a way to avoid exceptions, that will be helpful. Or any of the user functions in the pipe line, wants to return an error, it should be easy and elegant to do. Any thoughts?

@rsmoorthy, @kapolos, any updates?

@rtodea I've been swamped, sorry. I do want to add more, so hopefully Soon(tm)


migrate adaptive-browser-sdk

Migrating https://www.npmjs.com/package/adaptive-browser-sdk to this monorepo

@rramk do the existing github actions support docs/npm publishing for all of the packages contained within the sdk directory?

@rramk do the existing github actions support docs/npm publishing for all of the packages contained within the sdk directory?

docs: No. Need to add a section corresponding to the specific sdk. ( We could enhance to generalize to publish any sdk docs once we agree)
npm: Yes. It should push to npmjs once a git tag is pushed OR a github release is created
@Loxstomper

@Loxstomper
This is just a suggestion. Since the parent directory is sdk, I think it's better to change the adaptive sdk directory name to be adaptive-browser instead of adaptive-browser-sdk.


The mini map shows the wrong area after fullscreen

I use http://brunob.github.com/leaflet.fullscreen/ to add the fullscreen feature on my map.
When minimize the mini map, and set the page to full screen, the mini map shows the wrong area after restore the mini map again.

Same issue today.

Well, this sounds like some sort of bug in the interaction between the two plugins, probably that the fullscreen plugin doesn't fire some event that the minimap is waiting for to reorient itself. I assume it fixes itself if you move the main map around in fullscreen?

No :(

That sounds more difficult to fix; without having looked at the code for the other plugin I'm guessing that it somehow swaps out the map object the the minimap is listening to for changes. Any chance you could make a quick JSFiddle or similar that reproduces the problem?

Hi robpvn,
Here is the JSFiddle https://jsfiddle.net/ringoswy/tLd1vqnc/
Thanks a lot~

If anyone is still struggling with this issue in 2022, this will reset the minimap after restoring the minimap from the minimized state.
mainMap is your main map
miniMap is the minimap control
        mainMap.on('resize', function(e) {
            miniMap.once('restore', function () {
                miniMap._miniMap.invalidateSize();
            })
        });


Single node META FATE data

closes #4905

Moved all the fate data for a single META transaction into a single ZK node

Pushed all the data into NodeValue (renamed to FateData)
Previously, FateData stored TStatus, FateReservation, and FateKey. Now additionally stores the REPO stack and TxInfo.

Status enforcement added to MetaFateStore (previously only possible for UserFateStore).
Moved testFateInitialConfigCorrectness() from UserFateStoreIT to UserFateIT
Renamed UserFateStoreIT to UserFateStatusEnforcementIT (now extends a new class FateStatusEnforcementIT)

Now only tests status enforcement (previously status enforcement + testFateInitialConfigCorrectness())

Created MetaFateStatusEnforcementIT (extends FateStatusEnforcementIT)

Tests that the new status enforcement in MetaFateStore works

Created FateStoreUtil, moving the createFateTable() util here, created MetaFateZKSetup inner class here (the counterpart to createFateTable() for UserFateStore but sets up ZooKeeper for use in MetaFateStore)
Deleted UserFateStoreITs (now UserFateStatusEnforcementIT) method injectStatus replacing with the existing setStatus which does the same thing
Ensured sunny day and all FATE tests still pass with these changes

I did not end up using JSON for the fate data. I was not sure what the benefit of this would be since the data needs to be stored in ZK as a byte array anyways and it seemed simpler to me to just keep the same serialization/deserialization strategy for the fate data. Maybe this could be changed to JSON in a follow on if there would be a benefit of using JSON over the current strategy.

Addressed in 29edaa2cd79ab2920edc9d2a4355e9f761ff78d8:

Got rid of END_REPO_DATA marker, replacing with simply writing the number of repos to read
Avoid AtomicBoolean in MetaFateStore.FateTxStoreImpl.push(repo) by changing StackOverflowException to instead be a RuntimeException (previously Exception)
Deleted unnecessary preexisting catch and immediate re-throw of a StackOverflowException in MetaFateStore.FateTxStoreImpl.push(repo)
Cleaned up and refactored MetaFateStore methods which mutate existing FateData; now reuse same pattern across these methods: all call new method MetaFateStore.mutate()

Resolved the conflicts from the recent seed transaction speedup. Thankfully, those changes were mostly for UserFateStore and these are for MetaFateStore, so conflicts were very easy


Add kinde to showcase

Adds the Kinde docs website to the Starlight showcase page.

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Generate deviation between the range (mhw/mlw) and the actual value per type

Based on the vegetation table, create grids with how much the mhw (or mlw) needs to change to allow a certain vegetation type.
Example map below:

These maps don't take into account nutrient level and acidity

This is based on the simple NICHE model, not taking into account nutrient level and acidity.

Currently, the deviation plots are empty...

The plots are actually ok when checked in qgis or saga. I opened using a picture application, which was not a good idea.

We discussed the handling of the legend again. The basic functionality has an argument fixed_scale=TRUE as argument, which results in a range [-100, 100] (cfr. supra).
If user decides to use: fixed_scale=FALSE, the data range is just translated to the scale.


Doobie Exercises

This issue can be closed once https://github.com/scala-exercises/scala-exercises/pull/581 is merged.


[packagers] Support SINGLE_JAR distribution in AppImage

The only missing piece to support AppImage for SINGLE_JAR distributions is a dedicated launcher script template.
cc: @ebullient

Released in v1.4.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.4.0


Madlipsgenerator.py

In this game you enter random words and story is created around those words.


Modified single-file-example.html raw file link

Modified the documentation of legacy.reactjs.org/content/docs/getting-started.md
In the Online Playgrounds section, the Provided link for the download this HTML file is not working because of renaming of the repository from reactjs.org to legacy.reactjs.org
So to address the above issue I'm making a pull request by modifying the link from https://raw.githubusercontent.com/reactjs/reactjs.org/main/static/html/single-file-example.html to https://raw.githubusercontent.com/reactjs/legacy.reactjs.org/main/static/html/single-file-example.html
Thank you 🤝

@gaearon


Publish pure Python wheel on PyPI

Only the source tarball is now published on PyPI. It would be nice to also publish as wheel.

The workflow of matchms can be re-used for that.
See https://github.com/matchms/matchms/blob/master/.github/workflows/CI_publish_pypi.yml

The workflow of matchms can be re-used for that.
See https://github.com/matchms/matchms/blob/master/.github/workflows/CI_publish_pypi.yml

The (only) purpose of this would be to speed up install for users, correct?
Reading from your link, we would need to create a Pure Python Wheel (I don't want to deal with Python 2 anymore, what say you?).

The workflow of matchms can be re-used for that.

The workflow Faruk links doesn't test the package from a test server like test.pypi.org though.
Additionally I'm wondering if we can formalize some of the procedure from https://github.com/fair-software/howfairis/blob/0.12.0/README.rst#making-a-release in a user-triggered workflow that results in one or two artefacts, which developers can then download for testing before making a release.

The (only) purpose of this would be to speed up install for users, correct?
Reading from your link, we would need to create a Pure Python Wheel (I don't want to deal with Python 2 anymore, what say you?).

The workflow of matchms can be re-used for that.

The workflow Faruk links doesn't test the package from a test server like test.pypi.org though.
Additionally I'm wondering if we can formalize some of the procedure from https://github.com/fair-software/howfairis/blob/0.12.0/README.rst#making-a-release in a user-triggered workflow that results in one or two artefacts, which developers can then download for testing before making a release.

Wheel has other advantages than speed, see https://pythonwheels.com/

Wheel has other advantages than speed, see https://pythonwheels.com/

Closure of issues is blocked by #138

Should we close this?

Will be done as part of milestone


Feature: haraka docker build workflow #24

close #24

@nawazdhandala this PR is blocking this issue #26 , can you please check on it.

@bigelio Closed. Thank you for fixing up the context:  in docker-compose file. Can you please also do that for docker-compose.dev.yml in the next PR.


ITK must be built with Module_ITKReview enabled

Hello,
I have successfully installed ITKon Windows using Visual Studio 2022. However, I am currently facing an issue while building the PETPVC  library, which requires the Mdule_ITKReview.
I have followed the instructions provided by the PETPVC documentation and have set up the necessary dependencies, including ITK. However, during the PETPVC build process, I encounter an error indicating that the Module_ITKReview is missing.
I have searched extensively for a standalone download of the Module, but I have been unable to find it. I have also attempted to build different versions of ITK (tried 5.3 and 5.2 and according to this https://itk.org/Doxygen52/html/group__ITKReview.html the 5.2 shoudl have the moduel) but I have not been able to obtain the required module.
I would greatly appreciate any assistance or guidance in obtaining the Moduel_ITKReview bc wihout it I can´t use thte PETPVC. If anyone has successfully built PETPVC with ITK and has encountered a similar problem, I would be grateful for any insights or suggestions.
Thank you!

Hello @jadrianaj,
When you configure the ITK build using CMake, tick the "Advanced" checkbox and search for "review" you'll see that the Module_ITKReview is likely not ticked. Tick that checkbox too and then configure, generate and rebuild. This will include the missing module in your build.


Following zoom-in, parts of VCf blocks disappears in the UI

We found that after zoom-in a region (e.g from 7,508,441-7,508,473, to 7,508,449-7,508,465), the VCF blocks, i;e, the green with yellow rectangular and the sample (HG00100) grey blocks are not being rendered.
The attachments below illustrate the above-mentioned scenario
Before zoom-in

After zoom-in

Thank you in advance.

@rlim19 can you  post the mango-submit command

MANGO_HOME=/opt/mango
MANGO_DATA=hdfs:/data/mango
$MANGO_HOME/bin/mango-submit $MANGO_HOME/example-files/hg19.17.2bit
-genes http://www.biodalliance.org/datasets/ensGene.bb
-reads $MANGO_DATA/example-files/chr17.7500000-7515000.bam.adam
-variants $MANGO_DATA/example-files/ALL.chr17.7500000-7515000.phase3_shapeit2_mvncall_integrated_v5a.20130502.genotypes.vcf
-show_genotypes
-discover
-port 8070
Cheers

im getting this exception
Exception in thread "main" java.io.FileNotFoundException: Couldn't find any files matching
my mango-submit command ===============
./bin/mango-submit --master yarn-cluster --driver-memory 2g --executor-memory 2g  --  file://opt/Data/HumanBase/hg19/hg19.fa  -genes http://www.biodalliance.org/datasets/ensGene.bb -reads hdfs://master.hdp:8020/opt/small5.adam  -variants hdfs://master.hdp:8020/opt/sample/sorted.vcf  -show_genotypes -discover -port 8020

is it possible to run mango-submit using yarn cluster?

Hi @shibuvp. Can you isolate which file cannot be found? Is it the reference, reads or variants?
You can run mango-submit on yarn cluster. Just like spark or adam shell, you can run
./bin/mango-submit  --master yarn-client <other spark args here> -- <other mango arguments here>
Just remember to use '--' to separate Spark and Mango arguments

Closed by https://github.com/bigdatagenomics/mango/pull/299
Thanks for finding this @rlim19 !


Cli template not updated latest SuperAgentX version in poetry.toml file

SuperAgentX cli's generated toml file not reflected the latest SuperAgentX version.

This toml had some cache and it's not reflected. It's actually working like you expected. So, I'm closing this ticket.


Create defos.script_api

It resolves the issue of the warnings that appear in the linter due to not finding the extension globally, but it doesn't fix the display of the complete list of functions. Many thanks to Magna for the help.

Nice! Is the intention to add all of the api functions?

I preferred not to do it because I didn't have the exact list with the specific names of all the functions, and I also didn't know how to obtain it. I tried getting an AI to do it (since it's a repetitive task), but I wasn't successful, so I decided to leave it as is because it served the purpose of preventing errors. I didn't want to delete the identified function so it could serve as an example if someone knew how to complete the list.


[AutoPR datafactory/resource-manager] [Data Factory] Add data flow compute property in IR.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7325

/check-enforcer success


404 error at compiler download link

https://dl.google.com/closure-compiler/compiler-latest.zip
If you're trying to install using make deps today, you'll get a 404.

Confirmed.
From this page:
https://developers.google.com/closure/compiler/
The "Download the application" link goes 404.
Filing a bug with Google...

For internal Google tracking purposes, this is b/115784701.

Fixed on Google's end.


External dependencies upgrade - Spring Boot 2.7.0 and Spring Cloud 2021.0.3

Updates external dependencies to align with Spring Boot version 2.7.0 from 2.6.7 and Spring Cloud version 2021.0.3 from 2021.0.2.
None
This PR is created by GitHub Actions: https://github.com/Netyyyy/spring-cloud-azure-tools/actions/runs/2552881729

/azp run java - spring - tests

/azp run - cosmos - tests

API change check
API changes are not detected in this pull request.

Closing this in favor of https://github.com/Azure/azure-sdk-for-java/pull/29638