timit and parsing need data_sets specified with --timit_paths and --parsing_path.

HI all,
After the update, it seems using shared character vocab, charbased option for english chinese translate problem has been removed. I wrote a little scripts following the those in wmt.py but is arrived with the topic specified error.
I wonder if i have missed something, it would be great if someone could help.
Many thanks,
Colman
from tensor2tensor.utils import registry
from tensor2tensor.data_generators import text_encoder
from tensor2tensor.data_generators import problem
from tensor2tensor.data_generators import wmt
@registry.register_problem
class TranslateEnzhWmtCharacters(wmt.TranslateProblem):
"""Problem spec for WMT En-Zh translation."""
@property
def is_character_level(self):
return True
def generator(self, _, tmp_dir, train):
character_vocab = text_encoder.ByteTextEncoder()
datasets = wmt._ZHEN_TRAIN_DATASETS if train else wmt._ZHEN_TEST_DATASETS
tag = "train" if train else "dev"
data_path = wmt.compile_data(tmp_dir, datasets, "wmt_enzh_chr%s" % tag)
return wmt.character_generator(data_path + ".lang1", data_path + ".lang2",
character_vocab, EOS)
@property
def input_space_id(self):
return problem.SpaceID.ZH_TOK
@property
def target_space_id(self):
return problem.SpaceID.EN_TOK

on a second check, while the problem is registered when calling t2t-trainer, t2t-datagen clearly has not been able to retrieve the registered files from --t2t_usr=t2t_usr_path, i read from tutorial t2t-datagen should have supported t2t_usr in a similar way as t2t-trainer, would be great to know if there is anything i got wrong.

was a typo... sorry, works perfect.


Unable to make flatten() work on 2-minute TESS data

While applying flatten() on a 2-minute TESS target (HD 214667), I failed to find any combination of parameters that did not dramatically overfit the eclipse signals, despite using various combinations of the window_length, polyorder, sigma, and niters parameters.
How do I use flatten to just fit the baseline flux in this example?!
This is of course very much related to #546.
Example code used:
import lightkurve as lk
lc = lk.search_lightcurvefile("HD 214667").download().PDCSAP_FLUX
flat, trend = lc.flatten(window_length=1001, return_trend=True)

Example output:

Hi Geert-- have you tried masking the transits? lc.flatten(mask=transit_mask)

I think this is related to #546


Make a diff of the production database and what we have in oometa schema migration

I have been creating the following indexes manually to aid the release of ooni-api:
CREATE INDEX label_msm_no_idx ON public.label (msm_no);
CREATE INDEX report_probe_cc_idx ON public.report (probe_cc);

CREATE INDEX measurement_anomaly_idx ON public.measurement (anomaly);
CREATE INDEX measurement_confirmed_idx ON public.measurement (confirmed);

CREATE INDEX measurement_msm_failure_idx ON public.measurement (msm_failure);
CREATE INDEX measurement_exc_idx ON public.measurement (exc);
CREATE INDEX measurement_residual_no_idx ON public.measurement (residual_no);

I am not familiar enough with the deployment process of ooni-pipeline to safely do it using the ooni-sysadmin toolchain.
@darkk can you add these to the table migration scripts and integrate it into ooni-sysadmin and/or ooni-pipeline?

No longer relevant.


add proxy support

Hi @rubencaro
I come from ruby world where its ssh library support the proxy feature like here
https://net-ssh.github.io/ssh/v2/api/classes/Net/SSH/Proxy/Command.html
I checked the erlang ssh doc and it seems that there is no proxy support?
Correct me if I am wrong

Nice idea!
Maybe something like that could be supported using EEx itself with the given command to run/3 like this:
{:ok, res, 0} = SSHEx.run conn, "ls /path/composed_by/<%= host %>/and/<%= port %>"

It looks simple enough. SSHEx itself would execute internally something like:
final_command = EEx.eval_string given_command, [host: actual_host, port: actual_port]

Look at it as if you were using Ruby's Erb to render given command as a template (but faster!).
What data is given to EEx to be replaced can be a growing list over time (i.e. no need to be limited to host and port). Whenever someone needs a new one, just needs to add it and it will work.
Maybe there can be some switch on opts to enable this feature (a simple :use_eex would do), just to avoid extra work, as this is usually not needed. No harm is done.
If this would do it for you, then it does not look too hard to code. Maybe you can do it yourself. Pull requests are welcome!
I will do it if I find time, but that's hard to see lately.

hmm, maybe I didn't explain my question very clearly.
The feature that I need is a proxy support like http://www.cyberciti.biz/faq/linux-unix-ssh-proxycommand-passing-through-one-host-gateway-server/
I have a server A which has a public IP and server B which is in a private a network, to ssh to B I have to go through server A.
In my ssh config file, I specify a rule to use A as a proxy:
  Host B
  ProxyCommand ssh A -W %h:%p 2>/dev/null

I am wondering if I could do the similar thing in SSHEx?

Haha, I'm sorry. I'm the one that did not understand your question!
Here I see that it looks like it's not supported by underlying Erlang ssh, as it says explicitly that supports RFC4251:
(...)
Except (...) 9.5.2 Proxy Forwarding
(...)
But it's not too clear, and I'm just a mere user of :ssh, as SSHEx is just a collection of helpers to make it easier from Elixir. You should ask this yourself on the Erlang mailing list here. There lay the actual masters. Ask about 'SSH Support for Proxy Forwarding' and they will give you something.
If you get the Erlang code that does it, then maybe I can help you add a helper to SSHEx to make it easier to use from Elixir.
Thanks!

Thanks @rubencaro  :+1:


Allow specification of figsize in plot methods

Pandas allows a call to plot like:
df.plot(x='var1', y='var2', figsize=(10, 6))

but this doesn't seem to be possible in xarray - but it would be handy if it were.
It looks like fixing this would require modifying the @_plot2d decorator, specifically around https://github.com/pydata/xarray/blob/master/xarray/plot/plot.py#L376 (although I can't seem to find how to do the equivalent of gca() but set a figsize too).
Any thoughts or ideas?

I made some significant progress on this previously (https://github.com/pydata/xarray/pull/637), but stalled out when I wasn't happy with any of the API options. I would welcome someone else picking this up.


Update docs for feat: support desc [table] <table_name>

A document change request is generated from
https://github.com/GreptimeTeam/greptimedb/pull/1944

https://docs.greptime.com/reference/sql/describe_table#describe-table


Add basic webhook

Add basic webhook implementation which generate certificates for itself with minimal helm configuration.
The implementation is based on kyma/serverless

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


redis: 4.0.9 -> 4.0.10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/redis/versions.
These checks were done:

built on NixOS
/nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-sentinel passed the binary check.
/nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-server passed the binary check.
/nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-benchmark passed the binary check.
/nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-cli passed the binary check.
Warning: no invocation of /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-check-rdb had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-check-aof had a zero exit code or showed the expected version
4 of 6 passed binary check by having a zero exit code.
1 of 6 passed binary check by having the new version present in output.
found 4.0.10 with grep in /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10
directory tree listing: https://gist.github.com/a3e7b3964e29e1b8f0cfe9feca21635a
du listing: https://gist.github.com/be5306dea5e04998bf4b962ab9c0de8d

meta.description for redis is: '"An open source, advanced key-value store"'.
cc @berdario for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 2db31b6b660191c85eb9eda1841815879cbe9151 && nix-shell --pure -I nixpkgs=. -p redis

Success on x86_64-linux (full log)
Attempted: redis
Partial log (click to expand)
shrinking /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-server
shrinking /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-check-aof
shrinking /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-check-rdb
shrinking /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-benchmark
shrinking /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin/redis-cli
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10/bin
patching script interpreter paths in /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10
checking for references to /build in /nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10...
/nix/store/q6zp97d0xgxf7xa4gswy0jgqdnkrrxi4-redis-4.0.10

Success on x86_64-darwin (full log)
Attempted: redis
Partial log (click to expand)
    INSTALL install
    INSTALL install
    INSTALL install
    INSTALL install
make[1]: Leaving directory '/private/tmp/nix-build-redis-4.0.10.drv-0/redis-4.0.10/src'
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wshkbg8pb757d40fpman9g2fqjfbrhmw-redis-4.0.10/bin
patching script interpreter paths in /nix/store/wshkbg8pb757d40fpman9g2fqjfbrhmw-redis-4.0.10
/nix/store/wshkbg8pb757d40fpman9g2fqjfbrhmw-redis-4.0.10

Success on aarch64-linux (full log)
Attempted: redis
Partial log (click to expand)
shrinking /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin/redis-check-aof
shrinking /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin/redis-check-rdb
shrinking /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin/redis-cli
shrinking /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin/redis-benchmark
shrinking /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin/redis-server
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10/bin
patching script interpreter paths in /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10
checking for references to /build in /nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10...
/nix/store/d8wwwgy4chkwjf7la3z31qakw7q8zgg4-redis-4.0.10


Update Japanese JSONata message catalogue

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

This PR update Japanese message catalogue for JSONata following recent update of JSONata (https://github.com/node-red/node-red/pull/2340).
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 77.548% when pulling 7b1411d171403e03a901fa6d140f41a9952f69b8 on node-red-hitachi:update-jsonata-message-jp into 3a1d0f36952f7e01214691ef89355af72ad6e5c9 on node-red:master.


Add support for crystal tool expand

This tool is used to show macro expansion for a given location.
Note: The usage is similar to the crystal tool context that is already supported by this plugin.

Cool, thanks @rhysd :smiley:


support timeout

This PR will add support totimeout in helm.

thanks for your contribution 🙌

:+1:


For compatibility with RMarkdown and bookdown support of {text, label-id}... is needed

I have a problem with labeled code fence blocks.
I'm using ReText 7.0.4 as pre-production environment for editing RMarkdown files with bookdown extensions for custom blocks. I tried to report the following issue to the author. And we closed this issue.
ReText uses Python-Markdown with all extensions as Markdown parser.
The simplest minimal working example is below:

Code with label

```{python, label=first}
some
code
here

```

---

Code with extra fields

```{sh, echo=FALSE, comment=""}
some
code
here
```

I have enabled fenced_code extension in ReText.
I found problematic zone in fenced_code.py file - it is regular expression.
I suggest to rewrite it to the form (\{?\.?(?P<lang>[\w#.+-]*))?([ ]*|[ ,="\w-]+) to allow having {language, code-label="", extra=""}:
(?P<fence>^(?:~{3,}|`{3,}))[ ]*         # Opening ``` or ~~~
---> (\{?\.?(?P<lang>[\w#.+-]*))?([ ]*|[ ,="\w-]+)        # Optional {, and lang <---
# Optional highlight lines, single- or double-quote-delimited
(hl_lines=(?P<quot>"|')(?P<hl_lines>.*?)(?P=quot))?[ ]*
}?[ ]*\n                                # Optional closing }
(?P<code>.*?)(?<=\n)
(?P=fence)[ ]*$

I have tested it using DebuggEx and with my local ReText version. Now it renders the test document above as expected.
How do you think - is it possible to include this simple fix into your code?

The current fenced_code extension was a clone of PHP Markdown's Extra additions. It does not support commas between parameters as PHP Markdown did not either.  It is unlikey it will be changed to be a clone RMarkdown's behavior.
With that said, I have an extension SuperFences which allows you to create custom code blocks, and even add your own set of options, such as label. It's syntax is roughly the same as fenced_code. Speaking as the author of SuperFences, I have no intentions at this time of supporting the commas in the syntax over there either.
There is also the option of forking a suitable fence extension, add your functionality, and maintain it yourself. This is a perfectly reasonable option.  I am assuming ReText allows you to pull in custom extensions?  I haven't used ReText.

Thank you for reply!
From user point of view I can say that many other Markdown editors support the mentioned syntax. The example list is long: RStudio, GhostWriter, VNote, Typora, Formiko, MicroPad, Dellinger, CuteMarkEd, Marker.

I understand that PHP Markdown is older than RMarkdown, but the latter is very powerful but lacks WYSIWYG Markdown editor.
I have already patched my locally installed Python-Markdown (dependency of ReText), but it would be great if you include my small change into the distribution.
I still hope about this. Patching or forking is not a good solution for possible large audiences.

I don't think all of those do support that syntax. I just tried out Dillinger, and it treats {sh} as the language-{sh}. It doesn't properly parse it. Some may be passing the syntax through, but that doesn't mean it supports it.  What is the convert used in all of these?  And how do you know they all support Rmarkdown syntax properly?

I see you can't get me correctly.
So I'll repeat the whole story. I'm using ReText which is based on Python-Markdown for pre-production of RMarkdown (+bookdown) documents. This means that I want to use all great WYSIWYG functionality of the ReText. So all syntactically correct objects should render correctly or as-is (or partialy, or dropped) if editor does not know about some RMarkdown/bookdown extensions. In this particular case the Python-Markdown do not know about extra fields in fenced code blocks. So I have expanded regular expression to support RMarkdown extensions. You can use aforementioned issue link to get screenshots.
About Dellinger I do not know how do you opened it, but my render is below, and it is correct.

About other editors - I have tested all of them on my big real RMarkdown document with headers, bold, italic, inline code, inline equations, numbered equations and labeled code fence blocks. Editors are usually based on Pandoc, CommonMark, MultiMarkdown, etc. The result of the comparison is that ReText is outstanding on all parameters.
I do not need parsing of code fence arguments, I need them to not to break the formatting of the document (see example of wrong formatting). After patching of Python-Markdown code ReText works as I expect:

So I'll ask you again - please include my simple one line change to the Python-Markdown code. You can ask me to do comprehensive testing of it if not sure.
The result would be great for both Python-Markdown and ReText end-users. From their point-of-view the manual patching will not be an option. They will install ReText with pip3, which will install all dependencies including Python-Markdown.

Our Contributing Guide states:

Feature requests will often be closed with a recommendation that they be implemented as third party extensions outside of the core Python-Markdown library. Keeping new feature requests implemented as third party extensions allows us to keep the maintenance overhead of Python-Markdown to a minimum, so that the focus can be on continued stability, bug fixes, and documentation.

You are asking to support a new feature which I have no need for and no interest in maintaining. Of course, you are free to create any extension you want which has any behavior you want. And if you do so within the confines of the license, you can even fork the existing extension and modify it to meet your needs.
For the record, our implementation of fenced code blocks is a clone of this and anything in addition to that is outside the scope of the existing extension. In fact, many years ago, Michel Fortin and I developed that syntax together and released our implementations within a few days of each other (before any other implementations existed). As I see it, any variations of the syntax are unofficial variations. And any additions (such as r-markdown) should be implemented with some new different syntax. But that is my personal opinion. Of course, anyone is free to implement there own thing however they want. Just don't expect me to support it.


Set up bumpversion

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   89.47%   89.47%
=======================================
  Files          93       93
  Lines       11998    11998
  Branches     1084     1084
=======================================
  Hits        10735    10735
  Misses       1094     1094
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745c18a...88dfb5c. Read the comment docs.


Code Quality: Improve linting

In the project, we are using local linting configurations for each package.

eslint in demo
standardx in vue-currency-filter

This heterogeneous structure doesn't feel right.
Would it make sense if instead of linting at the package level we configure linting at the global level?
Proposal
Let's configure ESLint at the global level so that all packages follow the same linting standards.

I'm ready to make a PR for this. I mentioned this change in the comments of #205 but I wasn't able to find time to work on it because of work.

Just update the linter to the root at https://github.com/mazipan/vue-currency-filter/commit/6756bdb87a2fed2225679e27cd964c0685b06783

@mazipan can you also add prettier?

Hmmm, lemme check

Add here https://github.com/mazipan/vue-currency-filter/commit/a99ee81f53c2687e4964e60fe836977682ade0e1


charevents table: difference between column "error" in MIMICIII and column "warning" in MIMICIV

In some scripts for MIMICIII dataset, the error column is used to exclude certain rows using the following statement
" (error IS NULL OR error = 0)"
However, this column does not exist in MIMIVIV dataset, shall we just ignore such statement moving forward?
Or shall we use the "warning" column instead?
Thanks

We have removed all error rows prior to release so you no longer need this
statement. Warning is different and it's up to you how to handle them, but
they don't necessarily mean bad quality data.


fix(stats): Handle delta overflows in Counter and Countergauge

Closes #410
/claim #410

Handles overflow while calculating the delta in Counter and CounterGauge

@fwbrasil I think this takes care of the rollover

I think the issue was looking for a more holistic solution, but regardless tests will be necessary for this bounty claim.

Working on a better solution + tests

Hi @fwbrasil @hearnadam this solution addresses the overflow on last by rolling over the remainder of the value to start from zero. This would mitigate the inaccuracies when dealing with negative numbers. Kindly review and advise if this was not the intended behaviour

@fwbrasil @hearnadam I would appreciate your feedback

Thank you! Sorry for the delay to review @mobley-trent


Deployment fix for --auto_create_cli_app flag bug

Summary of the Pull Request
Fixes #2915.
Refactoring the deployment config and OneFuzz cli config settings created a bug that required new deployments know the CLI app ID prior to it being created in situations where the CLI app ID is specifically set to be created at deploy time using the --auto_create_cli_app flag.
PR Checklist

[x] Applies to work item: #2915
[x] Tests added/passed
[x] Requires documentation to be updated

Info on Pull Request
updated:
src/deployment/deploy.py
src/deployment/deploylib/configuration.py
Validation Steps Performed

run deploy.py $REGION $RESOURCE_GROUP $APP_NAME $OWNER config.json --auto_create_cli_app  (where config.json doesn't have the normally required "cli_client_id" key)

Codecov Report

Merging #2921 (76b355d) into main (f00248f) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2921      +/-   ##
==========================================
+ Coverage   28.84%   29.04%   +0.19%
==========================================
  Files         302      177     -125
  Lines       35895    22293   -13602
==========================================
- Hits        10353     6474    -3879
+ Misses      25542    15819    -9723

see 125 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This looks good.
Have you tested in PME and microsoft tenant?
The test cases I would think about are:

[x]  Deploying to Microsoft using the Micrsoft onefuzz-cli app id in config.json
[x]  Using the auto_create flag to create a cli app id in Microsot tenant
[x]  Deploying to PME using the PME onefuzz-cli app id in config.json
[x]  Using the `auto_create flag to create a cli app id in PME tenant.

These tests completed successfully, details in teams.


The  table_to_text function returns an empty list

Hi
I am trying to run the code in create_external_datasets.py file for income dataset using t0serialization or tabletotext with debug arguments. But in , the function table_to_text has a regular expression that returns an empty list (around line  180 in file). I think there is the same problem in entry_to_text function.
def table_to_text(note):
         re_name_value = re.compile(r"^- (.*):([^:]*)$", re.MULTILINE)
         name_values = re_name_value.findall(note)                                # --->  name_values = []
         examples = [write_into_table(x[0].strip(), x[1].strip()) for x in name_values]
         return [preprocess(e)['linearized_table'] for e in examples]

I can not find the issue to run the code. Could you please let me know is that problem with template or something else? Thanks

Thanks for your interest in using TabLLM! Unfortunately, I currently don’t have access to my computer. I will come back to you on the 11th of April. Sorry for the delay.
Best,
Stefan

Error: "cannot import name 'DatasetDict' from 'datasets' (unknown location)"
Hello, I'm also trying to use tabllm. By the way, I encountered the error you may be experienced. I can't find that kind of folder. Can I ask your solution to that issue?

Hi @mortezamg63,
the error is due to the fact that datasets are should be internally serialized as list before applying the tabletotext or T0 model for serialization. It can be seen as a preparation. Hence, the regex expects a dashed list. Sorry for not making this clear.
The problem can be solved by adding a list serialization to the command line. The following command work for me to perform the tabetotext serialization:
create_external_datasets.py --dataset income --list --tabletotext
@seygodin your problem seems to be an importing issue. Please check if you install all required dependencies. If you still encounter the problem, please open a separate issue.
Hope that helps!

@stefanhgm
Thanks for your answer. I ran the code as the command you provided in your answer.  But, I can not still figure out the issue in code. It is not working for tabletotext. I can see the variable notes gives me a list of dictionaries like the output below.
notes[0]
"{'age': '39', 'workclass': 'owner of a non-incorporated business, professional practice, or farm', 'education': 'finished 11th class', 'marital_status': 'married', 'occupation': 'transportation, communication, and other public utilities sector', 'relationship': 'Husband', 'race': 'White', 'sex': 'Male', 'capital_gain': '0', 'capital_loss': '0', 'hours_per_week': '40', 'native_country': 'United States', 'label': 'False'}"

Lines 186 to 189 show the part that I can not see any serialization on notes. The lines are shown below as well.
186:  old_size = len(notes)
187:  notes = Dataset.from_dict({'text': list(itertools.chain(*[table_to_text(n) for n in notes]))})
188:  assert notes.shape[0] == num_features * old_size
189:  notes = notes.map(serialize)

What I understand from the code above is that the serialization in line 189 is called before the table_to_text function in line 187. In addition, as I mentioned and shown above, the variable notes is not a dashed-list. Can you show me how the dashed list should be? I can go for generating that format.
Thanks for giving time to me

Hi @mortezamg63
Sorry for the late reply! Again, I cloned the repo as is and only adjusted the data_dir and output_dir and the below command runs as expected:
create_external_datasets.py --dataset income --list --tabletotext

Re serialization: Depending on the LLM used for serialization (Narrativaai/bloom-560m-finetuned-totto-table-to-text, bigscience/T0, GPT-3) a different format is required. For Narrativaai/bloom-560m-finetuned-totto-table-to-text an html with a highlighted cell is required (see the model's documentation). For this, we actually created a single table with a single cell for each value and use the model to serialize this into a sentence because o.w. we experienced that the model leaves out information. The serialization, i.e. the dict in the notes dataset, should look like this (for income):
{
'text': ['<s><table> <row> <highlighted_cell> Age </highlighted_cell> </row> <row> <highlighted_cell> 39 <col_header> Age </col_header> </highlighted_cell> </row> </table>\n\n', '<s><table> <row> <highlighted_cell> Race </highlighted_cell> </row> <row> <highlighted_cell> White <col_header> Race </col_header> </highlighted_cell> </row> </table>\n\n', [...]
}

For bigscience/T0 (using --t0serialization) we created a dashed list with two items and ask the LLM to serialize it into a sentence. We found that this leads to the least information loss. So the dict would look like this:
{
'text': ['Write this information as a sentence: Age: 39, Race: White. \n', 'Write this information as a sentence: Sex: Male, Marital status: married. \n', [...]
}

For GPT-3 we simply serialized the dataset as a dashed list (just as for T0 but will all features in the list) and used an external program to query the OpenAI API.
Hope that help!

I close this issues since it seems resolved.


Initial functionality

Introduces quantize(img, alg) and the following algorithms:

UniformQuantization
KMeansQuantization via Clustering.jl, adapted from DitherPunk.jl's implementation

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f0be8f8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         4
  Lines           ?        28
  Branches        ?         0
========================================
  Hits            ?        28
  Misses          ?         0
  Partials        ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sorry @johnnychen94, src/uniform.jl could now use another quick look. The implementation should now be equal to MATLAB's, rounding to the center of each cube in the grid:


lora: Add support for a LoRa capsule

This adds userspace support for the new Tock LoRaMac capsule

Updated to support the latest version of https://github.com/tock/tock/pull/3360

The Tock changes are in, this is also ready to go

I have updated the names to match the kernel. Can this be merged?

bors r+


Double quotes used instead of apostrophe

In the following words:
he"ll
it"ll
hain"t

hi @darriuk please fix with PR if you can. 👍

This ticket should probably be closed, as a patch addressing it has merged to master.

What about missing apostrophe-included words?

@nadavb worth opening a separate issue for those. (Please/thanks!)
As @tomprogers noted above the OP's issue was resolved.


Display Comment Pop Up - Student B

In this milestone, I implemented the following as per the project requirements:

Created the main part of the homepage that keeps the layout.
Added API to render shows.
Created show cards & display cards functions.
Applied styling as per wireframe.

General requirements checklist.

No linters error.
Used the correct Gitflow workflow.
documented work professionally.
Followed the best practices of HTML, CSS, and JavaScript.

Popup implementation for capstone
-Added pop-up to comment button
-Added a close button to go back to the main page.

Status:Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it : ship it:
Congratulations! 🎉
Highlights
The app works great💯
Descriptive pull request summary👍
Meaningful commit messages🟢 👍
No linter errors 💯
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Support type-safe aliasing through refs

Looks great! Restarted failed job, I'm pretty sure that's just a flaky test.

@kibertoad do you remember which test failed? I couldn't locate that build from travis.

@elhigu One of the Oracle ones, but don't remember specific one. Will definitely write it down next time.

this is causing type errors everywhere... is there an eta on next release?

Can you please share some examples of errors that you are receiving ? Are these with last stable release or with @next ?

@jpike88 Could you please try if<EMAIL_ADDRESS>is working correctly for you in this regard? If no, we'd like to fix it before releasing final 0.17.0.

<EMAIL_ADDRESS>has fixed it, thanks


fix: adding more logging to retry test

There is a test failure that we kept sending retry requests exceeding max attempt number.
Could be due to some race on currentRetries count? I couldn't repro it on my local machine.
Added some logging and moved currentRetries count after we set the exception.

Please rebase this branch on master and only include the single new commit you want in the PR.

Rebase worked, PTAL.


Using blockRenderFn and paste deletes block data

I'm guessing this is a bug
When pasting text into a block that is rendered using blockRenderFn, data is stripped from the selection start block. I'd expect that when you paste text that the data shouldn't get wiped from a block unless you indicate that it should. This isn't browser-specifc.
As a work-around I use handlePastedText and recreate insertion to avoid losing block data.

I am having a similar problem. I am storing metadata in the data property of a block.
In normal editing I get the data in and out with no problem.
But whenever I paste, the data property for the selected block is set to an empty object and I loose my metatdata for that block. I am using a  blockRenderFn as well.
I have tried to utilize a handlePastedText as you describe, but the metdata  continues to be reset.
Here is my handlePastedText, wondering if I need to do something different?
handlePastedText(text) {
const { editorState } = this.state;
const blockMap = ContentState.createFromText(text).blockMap;
const newState = Modifier.replaceWithFragment(editorState.getCurrentContent(), editorState.getSelection(), blockMap);
this.onChange(EditorState.push(editorState, newState, 'insert-fragment'));
return 'handled';
}
This is the 'data' property where I store my metadata
export type RawDraftContentBlock = {
key: ?string,
type: DraftBlockType,
text: string,
depth: ?number,
inlineStyleRanges: ?Array,
entityRanges: ?Array,
data?: Object,
};
Thanks!

@jjunkin, replaceWithFragment overwrites the data in the original blocks with the data in the new blocks: https://github.com/facebook/draft-js/blob/514490b1322e1c123524eae97d4aea25b4da16ce/src/model/transaction/insertFragmentIntoContentState.js#L26
You need to remember the data in the first first and last block of the selection and then reapply that data after inserting the fragment.

thanks @colinjeanne for the response. Just to be clear, the .data is being lost on the default paste behavior - i.e. when I am not providing a handlePastedText function.
I am only trying to utilize the handlePastedText and thus replaceWithFragment to save the .data metadata before and then restore it after the paste - as you suggest.
My guess is that the default paste action utilizes the same mechanism and thus requires the same fix.
Thanks!


Severe performance degradation in 4.9.3-rc2

This issue is related to https://github.com/Unidata/netcdf4-python/issues/1393 but narrowed down to netcdf-c library in it's 4.9.3-rc2 version.
We have noticed a very significant degradation in read performance when accessing a variable in a loop.
As a reproducer, the International Best Track Archive for Climate Stewardship (IBTrACS) data can be used:
wget https://www.ncei.noaa.gov/data/international-best-track-archive-for-climate-stewardship-ibtracs/v04r01/access/netcdf/IBTrACS.ALL.v04r01.nc
With the following minimal C code:
#include <netcdf.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>

#define FILE_NAME "IBTrACS.ALL.v04r00.nc"
#define DIM_STORM "storm"
#define VAR_LAT "lat"

int main() {
    int ncid;                 // File ID
    int storm_dimid;          // ID for the "storm" dimension
    int lat_varid;            // ID for the "lat" variable
    size_t nstorms;           // Total number of storms
    size_t start[2], count[2]; // Start and count arrays for reading lat data
    float lat_value;          // Latitude value to read
    double total_time = 0.0;  // Total time of getting lat value
    int iterations = 0;       // Number of iterations

    // Open the NetCDF file
    nc_open(FILE_NAME, NC_NOWRITE, &ncid);

    // Get the "storm" dimension ID and size
    nc_inq_dimid(ncid, DIM_STORM, &storm_dimid);
    nc_inq_dimlen(ncid, storm_dimid, &nstorms);

    // Get the "lat" variable ID
    nc_inq_varid(ncid, VAR_LAT, &lat_varid);

    // Iterate over the last 10 storms
    for (size_t ns = nstorms - 10; ns < nstorms; ns++) {
        // Set start and count for reading a single value
        start[0] = ns;  // Index of the storm
        start[1] = 0;   // First time step
        count[0] = 1;   // Read one storm
        count[1] = 1;   // Read one time step

        clock_t cstart, cend;
        cstart = clock();

        // Read the latitude value
        nc_get_vara_float(ncid, lat_varid, start, count, &lat_value);

        cend = clock();
        double time_taken = ((double)(cend - cstart)) * 1000/ CLOCKS_PER_SEC; // Convert to ms
        total_time += time_taken;
	iterations++;

        // Print the latitude value
        printf("Storm %zu: Latitude is %f, Time taken = %.3f ms\n", ns, lat_value, time_taken);

    }

    double average_time = total_time / iterations;
    printf("\nAverage runtime per iteration: %.3f ms\n", average_time);

    // Close the NetCDF file
    nc_close(ncid);

    return 0;
}

iterating over the last 10 storms in the input file and accessing the corresponding lat value. With version 4.9.2 and below only the first read takes significant time, while the rest take virtually nothing:
Storm 13801: Latitude is -12.000000, Time taken = 80.000 ms
Storm 13802: Latitude is -13.400000, Time taken = 0.000 ms
Storm 13803: Latitude is -12.700001, Time taken = 0.000 ms
Storm 13804: Latitude is -13.100001, Time taken = 0.000 ms
Storm 13805: Latitude is -13.800000, Time taken = 0.000 ms
Storm 13806: Latitude is -8.600000, Time taken = 0.000 ms
Storm 13807: Latitude is -9.100000, Time taken = 0.000 ms
Storm 13808: Latitude is -2.300000, Time taken = 0.000 ms
Storm 13809: Latitude is 11.199999, Time taken = 0.000 ms
Storm 13810: Latitude is 18.800001, Time taken = 0.000 ms

Average runtime per iteration: 8.000 ms

Where as using 4.9.3-rc2, every iteration takes a similar amount of time:
Storm 13801: Latitude is -12.000000, Time taken = 80.000 ms
Storm 13802: Latitude is -13.400000, Time taken = 90.000 ms
Storm 13803: Latitude is -12.700001, Time taken = 50.000 ms
Storm 13804: Latitude is -13.100001, Time taken = 60.000 ms
Storm 13805: Latitude is -13.800000, Time taken = 40.000 ms
Storm 13806: Latitude is -8.600000, Time taken = 50.000 ms
Storm 13807: Latitude is -9.100000, Time taken = 50.000 ms
Storm 13808: Latitude is -2.300000, Time taken = 50.000 ms
Storm 13809: Latitude is 11.199999, Time taken = 50.000 ms
Storm 13810: Latitude is 18.800001, Time taken = 50.000 ms

Average runtime per iteration: 57.000 ms

For certain programs, this may result in a very noticeable slowdown.
This has been reproduced in Linux and Mac.

Thank you for reporting this, and thank you for providing the test program.  I'll take a look at this and see if I can sort it out. Out of curiosity, do you know which version of libhdf5 is being linked against?


NEW LOGO

I want to contribute in the form of a new logo. If a developer wants I can send it.

@averissimo


Feature: How to add 'Show HTML' button

Hi, forst of all, great plugin.
Is there any way to add 'show HTML' button to editor, so users can se HTML source code when writing texs?
Thanks

Hi @frobert
I made some searches but I think that QuillJS doesn't provide a "Show HTML" / "Show source" feature unfortunately.
Perhaps the best solution would be to create a custom editor module.
BTW, I'll think about it to see if there could be some workaround.

@blocknotes Yeah, that is weird, usually all HTML editors have thew 'Show source' option...
Yeas there are some custom modules, but is difficult to inject them into activeadmin_quill_editor gem just like that. It would be great if you could implement this feature to the gem so it works out of the box.
Thanks.

I know this is an older issue, but I wanted to share how I was able to accomplish this.
I used this quill-html-edit-button plugin.
In the javascript used to import the activeadmin_quill_editorlibrary, I also import and then register the htmlEditButton plugin.
import 'activeadmin_quill_editor'
import htmlEditButton from "quill-html-edit-button";
Quill.register("modules/htmlEditButton", htmlEditButton);

And then in the active admin form, I specify the quill editor type and use the data-* options to specify the modules.
f.input :content, as: :quill_editor, input_html: { data: { options: { modules: { htmlEditButton: {} } } } }

That adds the "Edit HTML" button at the end of my toolbar. I had to do some CSS tweaking to get it to display properly (it doesn't have SVG icons like the stock Quill editor icons, so it was inheriting some other styles that were undesirable.)

Thank you for your feedback @TheBrockEllis!
I didn't have chance to make experiments on this side but it looks like a nice solution.
Closing the issue for now.


Add unit tests

Merging is blocked until:

building tests is not a default option (i.e., build test must pass as-is, with only eigen3 as dependency)
add a new workflow which will test automatically (for all PRs and master branch)

I pushed few commits to fix some workflow changes, and to acquire a knowledge of how it works


Docstrings

[ ] disease
[ ] diseases.examples
[ ] diseases.gonorrhea
[ ] diseases.hiv
[ ] diseases.syphilis
[ ] distributions
[ ] interventions
[ ] modules
[ ] networks
[ ] parameters
[ ] people
[ ] products
[ ] random
[ ] results
[ ] settings
[ ] sim
[ ] states
[ ] utils

Most, but not all, seem to be in place

Going to close for now -- we can add more as needed.


HBASE-25445: Use WAL FS instead of master FS in SplitWALManager

If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem instances, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance.

Once QA results are in, will merge this PR.

Once QA results are in, will merge this PR.

I think there seems some problem with Jenkins, the recent build is aborted and I am not able to schedule a new build.

I think there seems some problem with Jenkins, the recent build is aborted and I am not able to schedule a new build.

New build is triggered

New build is triggered

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
2m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

44m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2844

JIRA Issue
HBASE-25445

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0bd34b12de67 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
2m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

44m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2844

JIRA Issue
HBASE-25445

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0bd34b12de67 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a414361ed9

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Build is taking more time. Let me merge this PR, I have validated test locally and we also have result available here https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/testReport/org.apache.hadoop.hbase.master/TestSplitWALManager/

Build is taking more time.


Update README.md

I expanded a bit the README, to make it easy to start.
I wish you like, i wait for corrections also.
Thanks

Awesome @cristiandley!
Thank you! :beers:


Feature Request: option to keep user-provided images at higher resolution

In Medium, I notice I can't set any of the images I added to my notebook to be full screen or semi-full screen. The resolution of the images when added to my original notebook was quite high. I believe the images need to be saved at higher resolution for this option to appear in Medium.
If this is the issue, it would be nice to somehow be able to specify keeping the original resolution for all user generated images, or to specify for one image at a time. Not a huge deal, I can just delete and upload a new image to Medium directly. But usually I want at least 2 higher resolution images in a post.

Interesting. I just checked this myself and verified that images cannot be used for semi/full screen. Unfortunately, I don't believe it's possible to do anything about this as the API has no parameter settings to change the resolution.
You can check the API here - https://github.com/Medium/medium-api-docs#34-images
If you think you can do something about this, reopen this issue.


Bug in Nora - More songs mentioned when there are not.

Describe the bug
The album panel in Artist, Albums and the View Album screens show incorrect song numbers.
To Reproduce
Steps to reproduce the behavior:
Not sure, but:

List both a directory, and its parent directory in the parent folder
Nora creates "ghost songs" (which is another issue in and of itself) - They do not have artworks, cannot be played, and amplify Songs In Album numbers.
Remove one of the added directories, so the songs can still be listed.
"Ghost songs" should disappear on restart, but the numbers will still be incorrect.

Expected behavior
Showing the number of songs in the album that are currently available in Nora.
Screenshots
Album Tile:

Same Album's Page:

Log File
No errors are available - seems like a Library / Filesystem Issue,
System Information:

OS: Windows 10
Affected App Version: 2.3.0-stable (and 2.2.0-stable as well)

I sadly cannot replicate the bug, but what I mean by that is, Nora shows tracks that are not really supposed to be there? Like, the same song showing up twice in the listing, but one is unplayable and has the default Nora track sleeve.

Then I'll keep this issue for now.
Made some adjustments to Nora to fix issues like this.
If you still see this error in the new update, mention it to me.

Alright, I will close this as can't repro for now.


pythonPackages.scrapy: 2.1.0 -> 2.2.0

Motivation for this change
Changelog: https://github.com/scrapy/scrapy/releases/tag/2.2.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.scrapy

@GrahamcOfBorg build python3Packages.scrapy


Move dependencies to pyproject toml and create ci/cd install and import test

The aim of this PR is to move dependencies from requirements.txt to pyproject.toml (as has been proposed for v0.2.0 on the roadmap) and discussed on https://github.com/mllam/neural-lam/pull/27#issuecomment-2110001148.
Requirements:

dependencies should still be installable with pip and pyproject.toml can be updated by hand
dependencies can be handle with pdm
ci/cd test that runs the pip install and runs a test that imports neural-lam to ensure that the required packages have correctly been installed.

I will copy here my motivation for allow using of pdm from https://github.com/mllam/neural-lam/pull/27#issuecomment-2117603643:
For someone not using pdm the process of setting up a new development environment would be:

Clone repo git clone http://github.com/<username>/neural-lam and change directory cd neural-lam
Optionally create your virtualenv with your favourite tool, maybe mkvirtualenv ... and then activate ...
Install neural-lam editable with pip so that changes you make are reflected in the site-packages version (actually this is simply a link) pip install -e .
Edit and run neural-lam: python -m neural_lam.train_model --config-file config.yaml
Manually install a dependency with pip and edit pyproject.toml by hand, i.e. python -m pip install ... and edit the pyproject.toml file
Stage, commit and push!

I like using a package manager like pdm (other options are pipenv, poetry, uv) because it makes the development process easier by 1) automatically updating package versions in pyproject.toml to ensure versions work together when I add a new package, 2) allowing me to "dry run" any dependency modification without clobbering my current env (this has hurt me quite a few times with pip) and 3) handling creating and activating virtuals envs
So with pdm the development process would be:

Clone repo git clone http://github.com/<username>/neural-lam and change directory cd neural-lam
Create virtual env pdm venv create and either activating it pdm venv activate ... or making it the default when using pdm run python ... with pdm use ...
Install package pdm install
Add dependency pdm add ... (this is where you can do  pdm add --dry-run ... to see what would change before you install a package), or remove one with pdm remove .... You can also add dev dependencies separately (which won't be included in wheels) with pdm add --dev ... or dependency groups with pdm add --group visualisation matplotlib for example (if we didn't want visualisation tools installed by default)
Edit and run neural-lam: python -m neural_lam.train_model --config-file config.yaml (if using activated virtualenv) or pdm run python -m neural_lam.train_model --config-file config.yaml
Stage, commit and push!

Since our cluster upgraded to cuda version 12.0 I ran into some issues with pinned dependencies (e.g. pyg-lib=0.2.0 is not avaiable: https://pytorch-geometric.com/whl/torch-2.0.1%2Bcu121.html). When we install dependencies with pdm in the future we should make sure that cuda < and > 12.0 is supported. Unless we expect the user to install their own cuda framework which I think is too limiting. In case it is useful, this is the command I am currently using to install the neural-lam env with cuda support:
mamba install pytorch pytorch-lightning torchvision torchaudio pytorch-cuda=12.1 pyg "numpy<2.0.0" cartopy pandas wandb matplotlib scipy shapely networkx cartopy pyproj plotly xarray zarr dask pre-commit geopandas pytest pooch -c pyg -c pytorch -c nvidia
pip install tueplots

Do you know if there is a way to install the dev dependencies using pip? Or do you have to do this manually now that they are listed under [tool.pdm.dev-dependencies]? I tried a few things but could not figure it out

@khintz and I finally got testing on GPUs (using cirun.io running on AWS EC2 with GPU) with both pure pip and pdm based installs working yesterday 🥳 As you will see there are now four different github action workflows for each of the four variations of cpu/gpu and pip/pdm. Doing this work I learnt that:

torch comes as different "variants" for installing for cpu-only support or support for a specific CUDA version, and the default variant that is installed with pip or pdm (when simply doing pip install torch or pdm add torch) is the latest torch version with latest CUDA version. If one wants specific variant other than default (for example for developing without a GPU) then this can only be achieved by providing an additional pip package index URL when installing with pip (with --index-url https://download.pytorch.org/whl/cpu e.g. the command would be pip instal torch --index-url https://download.pytorch.org/whl/cpu)
pdm does not support "index urls" when adding a package, there are workaround where we add index URLs directly to the pyproject.toml, but then we would have to add all the variants we think people might use... There are more complicated solutions. I have opted for simply suggesting that people manually install the torch variant they want with pip before doing pdm install if they don't want the latest torch version with the latest CUDA version.
because variants can only be installed by the providing this additional index url then

I cannot do a pure pdm-based install to get the cpu variant installed, I have to first create a virtual environment, then install torch with torch+cpu with pip and then complete the install with pdm. As long as the version of the torch package installed is adequate then pdm will be happy with it and won't try to install the latest gpu variant by default
We can't include a pdm.lock file (which would pin the specific versions of a working install, i.e. be the result of the dependency resolution from the pyproject.toml file) because that would refer to a specific torch variant and then we would be locked out of installing other variants with pdm. We could of course in future consider maintaining a collection of lock files (this could be good for productions setup), but I think that is out of scope for now.

In the github actions you will also see that explicitly check that the torch variant has been installed. So I hope this will a solid enough setup going forward.
Anyway, the good news this now all works! I have updated the README with install instructions and this is all ready for review 😄 And in future we will have both CPU and GPU based testing running in ci/cd.

Since our cluster upgraded to cuda version 12.0 I ran into some issues with pinned dependencies (e.g. pyg-lib=0.2.0 is not avaiable: https://pytorch-geometric.com/whl/torch-2.0.1%2Bcu121.html). When we install dependencies with pdm in the future we should make sure that cuda < and > 12.0 is supported.

I think this should work with the setup I have implemented now. Could you try with the install instructions I have written? I hope this works... 🤞

Do you know if there is a way to install the dev dependencies using pip? Or do you have to do this manually now that they are listed under [tool.pdm.dev-dependencies]? I tried a few things but could not figure it out

There isn't no, and this is be default I found out. The reason is that in pdm they have taken the policy that "dev"-dependencies shouldn't be part of the package that is built when putting a package on e.g. pypi. We could simply choose to not use the pdm special dev-dependencies, and instead use a optional extras group which we could also call dev.
The install would then change from
pdm install --dev

to
pdm instal --group dev

And with pip you could then install this with
python -m pip install .[dev]

I would be ok with this if people prefer this?

I see. Yes, I think using an optional extras group is preferable then, since it would work smoothly both wiht pip and pdm.

I see. Yes, I think using an optional extras group is preferable then, since it would work smoothly with both pip and pdm.

Cool. Yes I think you're right. I would imagine @sadamov, @SimonKamuk and @khintz are happy with this too. If I don't hear any complaints I will change that this morning and update the PR (README and pyproject.toml)
I will take that is your review so far @joeloskarsson 😀

I have looked over all the changes and I think it looks good. Want to do a full install on my end and see that everything works, but will wait with that until you've made that final change. I have not looked in detail on any of the github workflows, as I don't know that stuff so well. But I trust others to go over that.
Does this go in before or after #32 ?

I have looked over all the changes and I think it looks good. Want to do a full install on my end and see that everything works, but will wait with that until you've made that final change. I have not looked in detail on any of the github workflows, as I don't know that stuff so well. But I trust others to go over that.

Great, thanks!

Does this go in before or after #32 ?

After I would say. The other PR is about moving files around to make neural-lam into a package. Once we've done that I can make sure that package installs and runs correctly for both cpu and gpu support

Ok @sadamov and @joeloskarsson, I've moved the dev dependencies to the optional dependency groups and updated the ci/cd setups and README to reflect the change.

Now this includes ( a bit hidden) the upgrade to numpy 2.0. Can we make this a bit more transparent? For example by adding this specifically to the changelog, as it now just contains the entry for capping it to <2.0.
If we now are moving to allow numpy 2.0, should we actually make this >=2.0.0, so we do not need to make sure to support both numpy 1 and 2 in the future?

Now this includes ( a bit hidden) the upgrade to numpy 2.0. Can we make this a bit more transparent? For example by adding this specifically to the changelog, as it now just contains the entry for capping it to <2.0.

If we now are moving to allow numpy 2.0, should we actually make this >=2.0.0, so we do not need to make sure to support both numpy 1 and 2 in the future?

Ah! Sorry, that was an oversight. I had somehow convinced myself we now did support numpy>=2.0.0, but of course #67 capped the version. I'm glad you noticed this. I will make another commit to cap the version as it was before in requirements.txt

Oh no, sorry for the confusion. We want to remove the cap to <2.0 here, just make it clear that we do that. The code works with numpy 2, see

Oh no, sorry for the confusion. We want to remove the cap to <2.0 here, just make it clear that we do that. The code works with numpy 2, see #67

Ah I see! Ok, so I will include a note in the CHANGELOG to say that we removed the cap to numpy<2.0.0 because it works. I'll draft that changelog entry now and revert the changes


ci(postman): Update PayPal and Checkout Collection to address assertion failures

Type of Change

[x] Bugfix
[x] CI/CD

Description

Address Assertion failures
Motivation and Context

Remove red
How did you test it?

Ran the postman collections
Checklist

[x] I reviewed the submitted code
[x] I added unit tests for my changes where possible

Closing this PR since @Gnanasundari24's PR addresses this


prusa-slicer: fix binary name on Darwin

Description of changes
If we attempt to nix run this derivation on Darwin, the build succeeds but produces a binary named PrusaSlicer, thus failing the run.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@wegank could you have a look?


error TS7016: Could not find a declaration file for module 'domhandler'

Using latest v0.21.4 tag, npm i throws:
npm ERR! prepareGitDep node_modules/@types/domutils/index.d.ts(6,28): error TS7016: Could not find a declaration file for module 'domhandler'.
npm ERR! prepareGitDep   Try `npm install @types/domhandler` if it exists or add a new declaration (.d.ts) file containing `declare module 'domhandler';`

Adding "@types/domhandler": "^2.4.1", to package.json devDependencies fixes it.

npm i throws a TS error? Are you installing apify as a dependency of a project or are you installing dependencies of apify itself?

To be fair I'm pulling in Apify via a github fork:
"apify": "github:corford/apify-js#hotfixes",
The branch is a clone of v0.21.4  plus https://github.com/apify/apify-js/pull/698

It would be our prepare script that triggers the build script which includes TS type definitions. Not sure why it would complain about domhandler. Plain 0.21.4 builds the types just fine.

But I still don't get why it would install this way and why it would pull devDependencies.
Maybe the github install actually includes an install of the package itself and then a build of it into a tarball? That could possibly explain it.

No idea tbh. Feel free to close this issue if it is more a quirk of my particular setup (I only opened it to share my fix in case anyone else was hitting the same problem).

Would be great though if https://github.com/apify/apify-js/pull/698 (or something similar) could get merged one day - then I wouldn't need my fork :D

Yeah, I remember we talked about it and sorry about the delay. We've been rewriting a lot of internals in the past months and it's slowly coming to an end, so we might finally get back to bug fixing and features.


Codice L1A updates for SIT-3

Change Summary
Overview

This PR makes some more changes to the CoDICE L1a pipeline to add better support for products for SIT-3
New Files

imap_processing/codice/packet_definitions/P_COD_LO_SW_PRIORITY_COUNTS.xml
imap_processing/codice/packet_definitions/P_COD_LO_NSW_PRIORITY_COUNTS.xml

Priority counts XTCE definition is now split into two, one for each Sunward and Non-sunward

Deleted Files

imap_processing/codice/packet_definitions/P_COD_LO_PRIORITY_COUNTS.xml

Priority counts XTCE definition is now split into two, one for each Sunward and Non-sunward

Updated Files

docs/source/development-guide/style-guide/naming-conventions.rst

Updated valid descriptors

imap_processing/codice/cdf_attrs.py

Moved attribute definitions to be in alphabetical order

imap_processing/codice/codice_l0.py

Added code to determine the XML to raw data file mapping based on descriptor instead of hard-coded

imap_processing/codice/codice_l1a.py

Various cleanup, updated TODOs, and defining the data arrays as arrays of 1s to get things flowing for SIT-3

imap_processing/codice/constants.py

Added CATDESCs for a bunch of CDF attributes

imap_processing/codice/packet_definitions/*.xml

Renamed files to be consistent with the valid descriptors expected for CoDICE
Updated XTCE files after being run through updated space_packet_parser version

imap_processing/tests/codice/data/imap_codice_l0_*.pkts

Renamed simulated data files to reflect proper naming convention for L0 data

imap_processing/tests/codice/test_codice_l0.py

Renamed L0 simulated data file to reflect proper naming convention for L0 data

imap_processing/tests/codice/test_codice_l1a.py

Updated simulated data filenames and re-ordered to alphabetical order

tools/xtce_generation/xtce_generator_codice.py

Reodered list of APIDs to be in increasing order

Would it make sense to combine the packet definitions into a single "COMBINED" file? I think that is how we are doing it on some of the instruments. That would enable you to load a single XTCE file and parse all APIDs I think, but it would likely make the single XTCE much larger and harder to find things.

This might be worth trying, but regardless I would like to wait until after SIT-3 to tackle this. Given the copious amount of different CoDICE APIDs (13), the resulting XTCE file would indeed be quite massive. Something I will think about!


Refactor rename incorrect when the referenced method is defined in another project.

Describe the bug

Steps to Reproduce

Create python application named PythonAppication1
Create python application named PythonAppication2
Right-click in PythonAppication1 and select Add->reference..., select PythonApplication2 as referenced
Typing code in PythonApplication2.py

def add(a, b):
    print(a + b)

Typing code in PythonAppication1.py

import PythonApplication2
PythonApplication2.add(1,2)

Open PythonApplication2.py and select function name add and right-click to select rename...
Input a new name addTest in rename dialog and press enter

Expected behavior
The name add can be renamed as addTest both in PythonApplication2.py and PythonApplication1.py
Actual behavior
Nothing has changed.

Very weird. Only repros with the cross project reference. Otherwise rename works fine.

In today's build 17.1.0 Preview 3.0 [32030.14.main] , The name of the place where this method is called has not changed.

In today's build 17.2.0 Preview 2.0 [32228.339.main].In the same project, rename a method, but the method name of this method in other places where it is called has not changed

The original bug is reported for two projects, with one referencing the other. But the latest screenshots show this is broken for two files in the SAME project. We need to investigate and fix both of these cases if they still repro.

@ttSpace Can you please verify if this is still happening on the latest version of Visual Studio? For both single project and multiproject cases. Thank you!

@AdamYoblick In today's build 17.6.0 Preview 2.0 [33406.287.main], Python Package: 17.0.23033.1, In two Projects, Renamed only in PythonApplication2.py. The name of the place where this method is called has not changed. foo --> footest

This works fine for the two files in the SAME project. foo --> footest

In today's latest build:17.7.0 Preview 2.0 [33709.378.main],Python package:17.0.23115.2
In two Projects, the 'rename' command doesn't have any responce after selecting it

@linette-zyy I was trying to repro this issue, how did you find the other project to add as reference? Mine shows nothing was found.


Added mDNS support

This enables the eSpa to be accessed via the spa name (defaults to MySpa) instead of needing to know the IP address: myspa.local
The Spa Name is configurable, therefore this change necessitated moving the config read above the Wi-Fi connection in setup(). I don't see any reason not to do this.
I think we should change the default spa name to eSpa to match the new project name. This change will need to be done carefully, as it could result in a breaking change.

Addresses #71


update sdc to v0.1.0-beta05-preview4-SNAPSHOT

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #1737
Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

Relates to https://github.com/opensrp/fhircore/pull/1731


Adding missing schemalocation, version

With this commit I fixed some problems due to missing elements according to the specification.
Please review.

Looks good to me. Please merge if the tests pass.


Some queries about docker creation

Greetings. I am not a docker expert, so i have some queries? I have watched the video, but still i am not clear. Sorry for naive queries.
Right now what i have done is create a docker container which take input folder and give output folder. There is no evaluation folder in it. What i think you have a separate script which take the output produced by docker and evaluate it. Am i right?
Second, is it necessary to have to shell script or we can directly use python script?
My current command is
docker container run --gpus device=0 --name tac --rm  -v $PWD/images:/workspace/images -v $PWD/tac_outputs:/workspace/outputs tac -i images -o outputs

Hi @talhaanwarch ,

Yes, There is no evaluation folder in it. When we download your folder, it will be evaluated by

docker image load < teamname.tar.gz

docker container run --gpus "device=1" --name teamname --rm -v $PWD/inputs/:/workspace/inputs/ -v $PWD/teamname_outputs/:/workspace/outputs/ teamname:latest /bin/bash -c "sh predict.sh"

Yes, you should have a sh file inside the docker. It is very easy. For example, if the running script is
python3 predict_flare_seg.sh

The shell script predict.sh is
# !/bin/bash -e

python3 prediction_flare21.py

Hope the answer helps. Please feel free to raise more questions:)
Best,
Jun

can you rectify, i think the running script should be python3 prediction_flare21.py instead of  python3 predict_flare_seg.sh

i finally manage this command docker container run --gpus device=0 --name tac --rm  -v $PWD/images:/workspace/inputs/ -v $PWD/tac_outputs:/workspace/outputs/ tac:latest /bin/bash -c "sh predict.sh"
thanks

can you rectify, i think the running script should be python3 prediction_flare21.py instead of python3 predict_flare_seg.sh

Yes, you are right. Sorry for the typo.

i finally manage this command docker container run --gpus device=0 --name tac --rm -v $PWD/images:/workspace/inputs/ -v $PWD/tac_outputs:/workspace/outputs/ tac:latest /bin/bash -c "sh predict.sh"
thanks

That's great. Congrats!


Feat: personal story section

Describe the feature
After pricing section . We can add personal story section so that users can share thier views or thoughts.
Kindly assign me this issue under #gssoc'24.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshot in your PR.
Make sure to star the repo before working on it! Happy open-source contributing!

assign this please


Error in MMM-GoogleMaps-Tracking.js

It looks like lines 6 and 7 need to be removed from MMM-GoogleMaps-Tracking.js.
If you don't set lon and lat in the config file, then these default to the values "latitute" and "longitude".  That, however, causes those strings to be set at the centre point on line 91, which in turn causes map.setCenter to throw an exception (NaN not an expected type) on line 184.

Fixed in the current commit. Thanks for your support


Check if socket is resource before reading

Per your request, here is the PR for checking if the socket is a resource prior to reading.

This can't hurt and won't impact performance that much.

This is a dumb question but I already have 2.02 in my composer.lock and I can't seem to get this file change down. Do you need to bump to 2.03 so I will get the change?

Do you need to bump to 2.03 so I will get the change?

Yes, a new release needs to be done for it to appear.
Note: you can try out releases before they are done by using 2.0-dev as version (at your own risk)

Wouldn't it be dev-main?

Thanks. Do you know when your next release is planned? We would like to get this fix into production as soon as we can. We have other packages that reply on predis that we moved to “^2.0” in composer from 1.1.
From: Markus Podar @.>
Date: Monday, September 19, 2022 at 1:48 AM
To: predis/predis @.>
Cc: streamingsystems @.>, Author @.>
Subject: Re: [predis/predis] Check if socket is resource before reading (PR #802)
Do you need to bump to 2.03 so I will get the change?
Yes, a new release needs to be done for it to appear.
Note: you can try out releases before they are done by using 2.0-dev as versionhttps://github.com/predis/predis/blob/42c33a406f1fc8f63dc91a2cc32a5fd832659ec6/composer.json#L47 (at your own risk)
—
Reply to this email directly, view it on GitHubhttps://github.com/predis/predis/pull/802#issuecomment-1250630678, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOI5PRLKG2HNSWJ2BPSXHITV7AECNANCNFSM6AAAAAAQPTTMOU.
You are receiving this because you authored the thread.Message ID: @.***>

@streamingsystems: Tagged v2.0.3 just now.


Fix for Issue #8

Tested and works with my code on Hybris v6.7 now.

Thank you @akrivitzky for your great contribution!
I agree it would be best running the container with non-root user.
I'll test your changes as soon.


Can't install gem

Hello I m unable to install this gem, even-though I have the source 'https://rubygems.org' at the top of my Gemfile, and I have this in my Gemfile:
gem 'march_hare', '~> 2.22'

Errored out:
Could not find gem 'march_hare (~> 2.22)' in any of the gem sources listed in
your Gemfile or available on this machine.

I cannot reproduce:
λ ~/ rvm use jruby
λ ~/ gem install march_hare
Fetching: march_hare-2.22.0-java.gem (100%)
Successfully installed march_hare-2.22.0-java
1 gem installed

March Hare is a JRuby-only library. Are you sure you are running JRuby? Switching to CRuby produces a "not found" from RubyGems:
λ ~/ rvm use 2.3
λ ~/ gem install march_hare
ERROR:  Could not find a valid gem 'march_hare' (>= 0) in any repository

hi @michaelklishin yes I m sure. Check this out :
ruby -v
jruby 1.7.19 (2.0.0p598) 2015-01-29 20786bd on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64]

I can also install it easily from console using gem install, I only observe the issue once it's inside my Gemfile. When I run into issue, I did find a workaround so I can explore your gem for potential production use, I clone repo locally and added this to my Gemfile :
gem 'march_hare', path: '~/workspace/march_hare'

Now works, I was able to install & connect to my broker

I don't see that we indicate this in the gemspec but March Hare only supports JRuby 9K these days.

thanks @michaelklishin I missed that bit. Very useful info.


Increase Max Healthy to allow cluster to provision

100% is too low and will prevent the cluster from provisioning new instances. Increasing this value to 200% allows the cluster to provision a new instance while keeping the existing task in place.\
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nice catch! Thank you for the PR.


Update index.html for redirection

Updated index.html of "Services" to redirect to product container section .

kindly solve merge conflict then I will merge it

Sir , I solved the merge conflict , now please kindly merge my pull request .

show me the output so that I can merge your PR also mention your issue number related to this issue.

Sir how to show the output ? I am confused

https://github.com/codervivek5/VigyBag/assets/112816781/0096b241-7192-41ca-9c5d-44fc93bc5374

can this be called a output ?

this is the issue number #202

this issue already solved


[WIP] Lazy checks for pytest

May be fix #410

@TE-Good Please check with https://github.com/Mogost/django-constance/archive/try-fix-pytest.zip

@Mogost, it looks like you've cracked it! Both pytest and pytest -vvx -n 4 --dist=loadscope are working with the build from your link.
Thanks for this!


Encoding definition improvement

Current version of HAP allows to determine HTML-page encoding for such meta tags:
<meta http-equiv="content-type" content="text/html;charset=iso-8859-1"/>
But in HTML5 next tag is also a valid one:
<meta charset="iso-8859-1"/>
Added appropriate changes to support second case.

Hello @SMishanya ,
Thank a lot for your pull,
My developer will check it very soon.
Best Regards,
Jonathan

Minor point: I suggest updating the <summary> for HtmlDocument.DeclaredEncoding at line 236. It describes the pre-HTML5 tag:
"Declared encoding is determined using the meta http-equiv="content-type" content="text/html;charset=XXXXX" html node."
I would omit describing the details of the HTML element. The details are not necessary for someone using the facility, and the code that implements the behavior is far away in the source file.
Another option is to add the details for the HTML5 version, perhaps something like this:
"Declared encoding is determined using the meta http-equiv="content-type" content="text/html;charset=XXXXX" html node (pre-HTML5) or the meta charset="XXXXX" html node (HTML5)."

Hello @SMishanya , @jfcardinal ,
The pull has been merged. We also made your suggestion @jfcardinal to improve the description.
A new release will be available later today.
Thank both of you for your contribution.
Best Regards,
Jonathan

Hello @JonathanMagnan,
Thank you too

The v1.7.2 has been released ;)
Best Regards,
Jonathan


[Question] Change the default glfw window height and width

Question
Hi!
Is it possible to change the default glfw window height and width with the human rendering mode?

We do not currently support this feature, you have to use your Window Manager to resize the window
You can offer a PR, to add this feature.
P.S. In the future, please include MuJoCo in the title of the question. (or whichever framework you use)


05-parser loadNpz test failed on nvcr.io/nvidia/pytorch:22.09-py3

After install packages in requrements.txt, i test loadNpz plugin and failed.
err msg:
[03/06/2023-09:33:00] [TRT] [E] 2: [stdArchiveReader.h::readManyHelper::333] Error Code 2: Internal Error (Assertion prefix.count failed. Enums must always have at least one entry.)
[03/06/2023-09:33:00] [TRT] [E] 4: [runtime.cpp::deserializeCudaEngine::66] Error Code 4: Internal Error (Engine deserialization failed.)

Thank for finding this problem!
In recent TensorRT, Plugin Layer needs at least one input tensor (even if a dummy one), but the example does not.
The problem is fixed by adding one input tensor and it surely works now.

hi, when i build tensorrt fp16 network, why all input dtype  are set to trt.float32 not trt,.float16?

hi, when i build tensorrt fp16 network, why all input dtype are set to trt.float32 not trt,.float16?

When using FP32 as input data type, the implicit convert from FP32 to FP16 will be included in the TensorRT engine.
You can also directly use FP16 as input data type if you need, just change the parameter in "set_input" API.

When I build fp16 network, if input dtype is trt.float32, and all inputs
dtype are np.float15, i found enqueu func use fp32 to compute not fp16, so
how to understand implicit convert?
wili @.***>于2023年3月28日 周二12:36写道：

When using FP32 as input data type, the implicit convert from FP32 to FP16
will be included in the TensorRT engine.
You can also directly use FP16 as input data type if you need, just change
the parameter in "set_input" API.
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/trt-samples-for-hackathon-cn/issues/67#issuecomment-1486202666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHQULIMLYYNTU7H5HEZSTDW6JTDTANCNFSM6AAAAAAVQ4JJYA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

What do you mean by "if input dtype is trt.float32, and all inputs dtype are np.float15"?
Anyway, run the example code below to check where your problem is. You should receive the VERBOSE log like:

...
This information below tells us the convolution layer computes in float16.
[03/28/2023-04:57:55] [TRT] [V] Engine Layer Information:
Layer(CaskConvolution): (Unnamed Layer* 0) [Convolution], Tactic: 0x1a44b86b83a2d99d, inputT0 (Half[1,1,6,9]) -> (Unnamed Layer* 0) [Convolution]_output (Half[1,1,4,7])
...
This information below tells us the data type of input / output tensors are float16.
[ 0]Input -> DataType.HALF (1, 1, 6, 9) (1, 1, 6, 9) inputT0
[ 1]Output-> DataType.HALF (1, 1, 4, 7) (1, 1, 4, 7) (Unnamed Layer* 0) [Convolution]_output
...

#
# Copyright (c) 2021-2023, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

import numpy as np
from cuda import cudart
import tensorrt as trt

nB, nC, nH, nW = 1, 1, 6, 9
nCOut, nKernelHeight, nKernelWidth = 1, 3, 3
data = np.ones([nB, nC, nH, nW],dtype=np.float16)

weight = np.ones([nCOut, nC, nKernelHeight, nKernelWidth], dtype=np.float32)
bias = np.ascontiguousarray(np.zeros(nCOut, dtype=np.float32))

np.set_printoptions(precision=3, linewidth=200, suppress=True)
cudart.cudaDeviceSynchronize()

logger = trt.Logger(trt.Logger.VERBOSE)
builder = trt.Builder(logger)
network = builder.create_network(1 << int(trt.NetworkDefinitionCreationFlag.EXPLICIT_BATCH))
config = builder.create_builder_config()
config.set_flag(trt.BuilderFlag.FP16)
inputT0 = network.add_input("inputT0", trt.float16, (nB, nC, nH, nW))
#------------------------------------------------------------------------------- Network
convolutionLayer = network.add_convolution_nd(inputT0, nCOut, (nKernelHeight, nKernelWidth), trt.Weights(weight), trt.Weights(bias))
convolutionLayer.get_output(0).dtype= trt.float16
#------------------------------------------------------------------------------- Network
network.mark_output(convolutionLayer.get_output(0))
engineString = builder.build_serialized_network(network, config)
engine = trt.Runtime(logger).deserialize_cuda_engine(engineString)
nIO = engine.num_io_tensors
lTensorName = [engine.get_tensor_name(i) for i in range(nIO)]
nInput = [engine.get_tensor_mode(lTensorName[i]) for i in range(nIO)].count(trt.TensorIOMode.INPUT)

context = engine.create_execution_context()
for i in range(nIO):
    print("[%2d]%s->" % (i, "Input " if i < nInput else "Output"), engine.get_tensor_dtype(lTensorName[i]), engine.get_tensor_shape(lTensorName[i]), context.get_tensor_shape(lTensorName[i]), lTensorName[i])

bufferH = []
bufferH.append(np.ascontiguousarray(data))
for i in range(nInput, nIO):
    bufferH.append(np.empty(context.get_tensor_shape(lTensorName[i]), dtype=trt.nptype(engine.get_tensor_dtype(lTensorName[i]))))
bufferD = []
for i in range(nIO):
    bufferD.append(cudart.cudaMalloc(bufferH[i].nbytes)[1])

for i in range(nInput):
    cudart.cudaMemcpy(bufferD[i], bufferH[i].ctypes.data, bufferH[i].nbytes, cudart.cudaMemcpyKind.cudaMemcpyHostToDevice)

for i in range(nIO):
    context.set_tensor_address(lTensorName[i], int(bufferD[i]))

context.execute_async_v3(0)

for i in range(nInput, nIO):
    cudart.cudaMemcpy(bufferH[i].ctypes.data, bufferD[i], bufferH[i].nbytes, cudart.cudaMemcpyKind.cudaMemcpyDeviceToHost)

for i in range(nIO):
    print(lTensorName[i])
    print(bufferH[i])

for b in bufferD:
    cudart.cudaFree(b)


Installation on localhost in xampp

I've installed UserApplePie-v3 on localhost with xampp (windows).
So folder is C:\xampp\htdocs\projectname\
I've moved UserApplePie public folder content to C:\xampp\htdocs\projectname\ (and imported sql and used composer)
When visiting http://localhost/projectname/ i can see welcome page.
In Config.php i have:
define('SITEURL', 'http://localhost/projectname/');
define('DIR', '/projectname/');
But when on welcome page i click on login (or register) the link is http://localhost/projectname/Login and  i get error "Object not found! The requested URL was not found on this server. [...]"
What am i doing wrong?
Many thanks
P.S. I couldn't register on official website because i got an error: "An error occurred, The error has been reported." on "http://userapplepie.com/Register" after clicking on "register"

Thank you for the heads up on http://www.userapplepie.com
I was able to track that error down to a database setting.  Should be working now.

As for your issue with removing the public folder.
I have not yet tried to install UAP3 this way.  However I think you need to change the following in index.php:
/** Define the absolute paths for configured directories */
define('APPDIR', realpath(__DIR__.'/../app/').'/');
define('SYSTEMDIR', realpath(__DIR__.'/../system/').'/');
define('PUBLICDIR', realpath(__DIR__).'/');
define('ROOTDIR', realpath(__DIR__.'/../').'/');

To
/** Define the absolute paths for configured directories */
define('APPDIR', realpath(__DIR__.'./app/').'/');
define('SYSTEMDIR', realpath(__DIR__.'./system/').'/');
define('PUBLICDIR', realpath(__DIR__).'/');
define('ROOTDIR', realpath(__DIR__.'./').'/');

Let me know if that works.  If not I will do further testing.

I tested on my server and was able to get it working by editing the .htaccess file as well.
Change the following:
RewriteBase /

to
RewriteBase /projectname/

Now it works! Thanks a lot!


[CORE] Import JDBC module

What changes were proposed in this pull request?
This PR imports JDBC module for XSQL, Creating class of JDBCManager and implementing some standard SQL functions. It works with some common jdbc data sources.
How was this patch tested?
No UT.

Could you make the description have more detail？


Add client/dump/restore functionality

Notes:

redis-cli has an option for dumping a redis rdb file from a remote server, but not for importing. I've added the rdbtools python package for importing the rdb file.
I haven't found a way to put the redis server in readonly mode.

Awesome, thanks!


Merge pull request #1 from copy/master

Sync CX

?

Fixes for osS like brick os beta that us use cat to cobine and give the error Disk Read failed error


Using JPMS with Gradle causes split module issue between gdx.utils, gdx and gdx.jnigen.loader

Issue details
I've been trying to establish a personal project for 2 days now, but been unable to resolve a split package issue between the inferred modules "com.badlogic.gdx.utils", "gdx.jnigen.loader" and "gdx":
The source code for my exact setup can be found here:
https://github.com/GustavBW/MELANGE
According to Gradle, they support JPMS now, and it has successfully inferred all the gdx libraries as modules, but I'm new to gradle and still don't exactly get it. In other words: I can't determine if this is a gradle issue or a libGDX one.
I could shade gdx.jnigen.loader, but that seems like an extreme measure for something that has probably happened for others and been solved before.
I've also tried employing the JLINK plugin, which I've read can solve these kind of issues, but to no avail
A last ditch effort could be porting to Maven instead which has better (as far as I'm aware) JPMS support, but your guide for libGDX on Maven is old and states that it isn't exactly supported (https://libgdx.com/wiki/articles/maven-integration), so I'd love to hear how feasible that'd be.
Reproduction steps/code
Use the gdx-setup tool, select support for all but IOS.
Refactor projects to JPMS modules, since gradle 7..xx this has been supported by default, but still requires the following statements to establish default module setup (as per IntelliJ standards that is).
sourceSets {
    main {
        java {
            srcDirs = ['src/main/java']
        }
        resources {
            srcDirs = ['src/main/resources']
        }
    }
}

Add a module-info.java to each module's main/java folder:
module core {
    requires java.desktop;
    requires gdx;

    exports gbw.melange to desktop;
}
module desktop {
    requires gdx.backend.lwjgl3;
    requires gdx;
    requires java.desktop;

    requires core;
}

run "gradle build", "gradle jlink", click the green array in [desktop]... .DesktopLauncher in IntelliJ, anything really that involves a build process.
Version of libGDX and/or relevant dependencies
I'm using the latest version of libGDX: 1.12.1
I've tried updating AGP to 8.3 (as my JDK language level is set to 17, which it isn't happy about) but the build fails because Android studio doesn't like that. So, its at 8.0.1 so far.
Steps taken to solve the issue
I've tried to mend the gdx dependency for the core module (core/build.gradle) to exclude jnigen:
dependencies {
    api("com.badlogicgames.gdx:gdx:$gdxVersion") {
        exclude module: "gdx.jnigen.loader"
    }
}

As well as adding a patch module statement to the compiler arguments during the "compileJava" task of the core module to explicitly remove it (which might cause other issues later):
'--patch-module', 'gdx=C:/Users/gusta/.m2/repository/com/badlogicgames/gdx/gdx-jnigen-loader/2.3.1/gdx-jnigen-loader-2.3.1.jar'

Stacktrace
> Task :core:compileJava FAILED
error: the unnamed module reads package com.badlogic.gdx.utils from both gdx and gdx.jnigen.loader
error: module gdx.jnigen.loader reads package com.badlogic.gdx.utils from both gdx and gdx.jnigen.loader
error: module gdx reads package com.badlogic.gdx.utils from both gdx.jnigen.loader and gdx
the unnamed module reads package com.badlogic.gdx.utils from both gdx and gdx.jnigen.loader

Please select the affected platforms

[ ] Android
[ ] iOS
[ ] HTML/GWT
[ ] Windows
[ ] Linux
[ ] macOS
[X] undetermined structural issue

Why do you need modules here? I've only seen the existence of a module-info.java file cause problems... I don't know what you're trying to solve.

Why do you need modules here? I've only seen the existence of a module-info.java file cause problems... I don't know what you're trying to solve.

They're another layer of abstraction that makes it easier to manage separate chunks of a program/library/framework. Admittedly, JPMS is one of the wonkiest module implementations I've used, but they can be pretty neat when they work.
What I'm trying to solve, or figure out, is why they don't work for libGDX specifically - at least not per my current setup.

There are very few people familiar with modules in the libGDX community, and the ones who are familiar probably use it for work projects. I'm not sure where to turn for advice on this, because I absolutely avoid modules.

Do you know about GDX 1.12.1 and Maven then / know about someone who got updated information on the current integration? My problem is I'm currently debugging 2 variables: Gradle and LibGDX, I'm far more familiar with Maven, and would happily sacrifice everything but desktop (android, HTML, ...) to get it working.

This sounds like you don't actually need modules. It also sounds like none of this is going to be easy to manage. Pretty much everyone here just ignores that JPMS ever released...

The only reason I know about JPMS is because we were forced to learn about it at university. Every other module system I've used since, C#, GoLang, and maybe even Node, has been easier to set up and get working. The great thing is about modules is that you actually get to reuse code for once, not just talk about "reusability" because dependencies and settings are abstracted to a per module basis. Also avoiding conflicting dependencies at the same time.

I'm familiar with Maven and use it occasionally. This project of mine uses libGDX 1.12.1 and the LWJGL3 backend with Maven. It does not use JPMS, though.

I'm familiar with Maven and use it occasionally. This project of mine uses libGDX 1.12.1 and the LWJGL3 backend with Maven. It does not use JPMS, though.

Thanks for the reference. I managed to set it all up with Maven, but it ran straight into the same error. As far as I can see, nothing requires com.badlogic.gdx.utils in gdx-jnigen-loader to be named utils. Changing the package name to "loader" would resolve the error and make gdx compatible with JPMS for the foreseeable future.


Collisions -- Fixing the "crack" problem

When trying to resolve the collisions, a problem happens because the ground tiles next to the player try to push him back, resulting in the player getting stuck between them. As such, the player can't walk past the tile under him.

Treating each axis separately
One solution could be to treat each axis separately in the physics engine, so that first the player moves along the X axis for instance, then collisions on the X axis are resolved, and same with the Y axis.
Cons
It complicates the physics engine's code;
// Apply X velocity
mCharacter->body.x += mCharacter->body.vel.x;
// Solve X collisions
mCollisions.solveX();

// Apply Y velocity
mCharacter->body.y += mCharacter->body.vel.y;
// Solve Y collisions
mCollisions.solveY();

instead of
// Apply velocity
mCharacter->body.x += mCharacter->body.vel.x;
mCharacter->body.y += mCharacter->body.vel.y;

// Solve collisions
mCollisions.solve();

Use a collider which is smaller on each

Here we use a rectangle collider which is larger and less high for the X axis, and the other way around with the Y axis
Cons
There are bugs such as the player going up when jumping against a tile and not hitting the X collider

Sorting the collisions by colliding area
Sorting the collisions by colliding area, fixing the first one, recalculating the collisions, and so on until there is no collision left, seems to work pretty well


Remove comment in biffweb.clj

I've noticed there is a dev comment with local paths at the bottom of the main biffweb.clj file.
Btw, I'm super new with clojure, it's quite hard for me to understand what I'm doing. I need a email/password authentication method, can I just ignore biff's authentication and user buddy-auth or am I going to have conflicts somewhere?

Yep, I use that for updating the docs on the website. You can ignore it.
For authentication, it's totally fine to not use the provided auth plugin and supply your own. (and recommended, if you need something different like passwords.)


npm run dev error

Please help me

Create a SQL database and add a file called dbconfig.json with the login details to the root of the project.
The contents of the file should be as follows:
{
    "db_pool": {
     "connectionLimit" : 10,
    "host"  : <NAME_OF_DB_HOST>,
    "user"     : <DB_LOGIN_NAME>,
    "password" : <DB_LOGIN_PASSWORD>,
    "database" : "<DB_NAME>"
}

}


Nits

I address the nits that Predrag made on previous refactor-schema-graph PRs.

Coverage remained the same at 93.619% when pulling 584c6299591501805e08a3c84a52ed05e4844e4c on nits into 4ea5c5c1a1563a9cc8cd4b5efc5288ef793906e3 on refactor-schema-graph.