FlexibleItemDecoration withOffset not working correctly for section headers

Hi there.
I'm facing a simple bug when trying to add offset for my section headers with GridLayoutManager.
The problem is that offset won't applied for headers with
position == itemsCount - grid.spanCount - 1.
For example, if GridLayoutManager spanCount == 2, there is no offset between last and before last item.
As I can see the problem is in isLastRowOrColumn() method.
Specially in this part:
int nextRowPos = position < itemCount - (spanCount - spanIndex) ? position + (spanCount - spanIndex) : -1;
Assume we have 10 items and Grid's columnCount == 2.
Since headers take whole width the spanCount will be equals 2, and spanIndex will be 0.
So, for the before last position the position will be 8.
So we have 8 < 10 - (2 - 0) which is false, and the ternary result is -1.
In method return statement there is ... || nextRowPos == -1 || ... condition, so we get true for position before last.
I'm using 5.0.0rc2 version of lib.
I would like any quick(!) suggestion how to fix it. Since I can't see the way to extend FlexibleItemDecoration and override relative methods.
Thanks.

Hi @omgreel, that calculation comes from the library which I imported, you can see it in #382.
You can of course take the code of this decoration and create your own decoration with the fix you need.
If you find the fix please let me know.

@omgreel, are you applying a sectionOffset with GridLayout?
So you mean that the items of the last row of each section do not receive the section gap but only the last item of the section?

@davideas well, i'm not sure about gap, for me withOffset() seems to broken.
Here the code I used to reproduce this bug in your sample app.
See FragmentExpandableSections:
mRecyclerView.addItemDecoration(new FlexibleItemDecoration(getActivity())                 .addItemViewType(R.layout.recycler_expandable_header_item)                 .withOffset(4));
If you collapse all expandable headers and scroll to bottom you'll see no offset between last three headers.

Ok thanks, to have noticed it.
It is necessary a new calculation method. And for that I need more free time 😢

I will try to find some time to take a closer look to help you with it.
My first suggestion is to use spanSize of item.
Something like this:
int nextRowPos = position < itemCount - (spanCount/spanSize - spanIndex) ? position + (spanCount/spanSize - spanIndex) : -1;
I ran it on sample app in FragmentExpandableSection and it's works in my case. But it's hard for me to say whether I broke something else or not.

@omgreel, 🆒 ❕ ❕ For the moment I do not see inconvenience. Let's use it.
However, I also tried to remove completely the calculation of nextRowPos and it seems to work anyway.
The first 3 conditions should be more than enough. because the next row should be covered by next position viewType condition... what do you think?

My suggestion requires lots of tests for different viewTypes, spanCounts, spanSizes and etc.
Same for removing calculation. But I think there might be less side effects with no calculating nextRowPos at all.
Maybe I'll write test for isLastRowOrColumn method later.

@omgreel, but nextRowPos should not be everytime that spanIndex = 0?

Sorry, I don't understand your question.
Could you please explain it?

Sorry @omgreel forget my last question.

The proposed fix will be available in the next snapshot.


Grid is not correct when transform to Label Projection.

Context

MapFish print version: 3.29.4 (latest)
Java version: 17
OS: Docker

Describe the bug
The printed grid is not correct when added "labelProjection" param. The right labels is not equals to the lefts and all left labels are same.
How to reproduce

{
    "layout": "A4 landscape",
    "attributes": {"map": {
        "rotation": 0,
        "center": [
            602602,
            4915620
        ],
        "layers": [{
                    "type": "grid",
                    "font": {
                        "name": ["Arial", "Liberation Sans"]
                    },
                    "rotateLabels": true,
                    "numberOfLines": [3, 3],
                    "labelProjection": "EPSG:4326"
                }],
        "scale": 258000,
        "projection": "EPSG:26713",
        "dpi": 72
    }}
}

Actual results

mapfish-print-report (5).pdf
Expected results

Is there an issue with axis order?


add more tests to straxen

What is the problem / what does the code in this PR do
Add several tests for packages missed by the current tests.
Can you briefly describe how it works?
Mostly checks that things load properly.

2.5 % coverage increase of tests over entire straxen code. Not too bad..

Hej, I am not sure if I should already review this PR. One question/suggestion, do you think it make sense to add for example for test_straxen some "truth" dictionary containing the expected outcomes. I am asking in case we will ever change the demo it might be easier to just modify the dict instead of tests itself.

Sure, you mean like testing the number of events and so on? Could add with some reasonable error or margin. Thanks for the sugestion

@WenzDaniel Done, can you re-review?


Add ouster lidar driver by WhaleDynamic

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WFLY-14821] Additional PostBuild tests for the archetypes

Fixes https://issues.redhat.com/browse/WFLY-14821

@WolfgangHG I have created a Jira issue for your work. You have to change the commit message to
[WFLY-14821] Additional PostBuild tests for the archetypes <--- title of the commit
Fixes https://issues.redhat.com/browse/WFLY-14821 <-- body message of the commit

I made some changes and hopefully did the correct thing ;-). Sorry, I am a newbie to Git.

Try locally with 'git commit --amend' and then 'git push --force origin master'
You didn't setup a branch but commited directly to master - try to avoid that in the future. (git checkout -b myNewBranch)

@WolfgangHG  @boris-unckel hi, WFLY-14821 seems unrelated to this change, is that the correct JIRA?

@WolfgangHG Hello Wolfgang, @emmartins is right. My apologies posting the wrong link. The correct one is https://issues.redhat.com/browse/WFLY-14822 "WildFly Maven archetypes: Additional PostBuild tests". Wolfgang could you please change this in the commit message (git command see above) and in the pull request?

@boris-unckel  done - hope it is OK now ;-)


Add doc endpoint

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[x] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: Fixes #43
What is the new behavior?

openapi doc is exposed on /openapi.json

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report
Base: 51.83% // Head: 73.58% // Increases project coverage by +21.74% :tada:

Coverage data is based on head (4cf7ecb) compared to base (5e6d87b).
Patch coverage: 84.68% of modified lines in pull request are covered.

:exclamation: Current head 4cf7ecb differs from pull request most recent head ff692a7. Consider uploading reports for the commit ff692a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #57       +/-   ##
===========================================
+ Coverage   51.83%   73.58%   +21.74%
===========================================
  Files          21       21
  Lines         463      511       +48
===========================================
+ Hits          240      376      +136
+ Misses        223      135       -88

Impacted Files
Coverage Δ

beerus_cli/src/main.rs
5.00% <6.25%> (-11.67%)
:arrow_down:

beerus_rest_api/src/api/starknet/resp/mod.rs
66.66% <66.66%> (ø)

beerus_cli/src/starknet/mod.rs
96.77% <90.90%> (+96.77%)
:arrow_up:

beerus_cli/src/ethereum/mod.rs
100.00% <100.00%> (+100.00%)
:arrow_up:

beerus_cli/src/model.rs
53.57% <100.00%> (+53.57%)
:arrow_up:

beerus_cli/src/runner.rs
92.59% <100.00%> (+92.59%)
:arrow_up:

beerus_rest_api/src/api/ethereum/endpoints.rs
96.15% <100.00%> (+0.15%)
:arrow_up:

beerus_rest_api/src/api/ethereum/resp/mod.rs
100.00% <100.00%> (ø)

beerus_rest_api/src/api/mod.rs
100.00% <100.00%> (ø)

beerus_rest_api/src/api/starknet/endpoints.rs
52.85% <100.00%> (+2.11%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


public visualforce page

I am planning to have a public VisualFoce page with jsforce where it will consume objects from salesforce.
In my tests, I was able to make a "secure" VisualForce page work with the jsforce.Connection({ accessToken: '{!$API.Session_Id}' }) and Query Stream.
For a public visual force page, what is the recommended approach for a public visualforce page to query a SalesForce object? Mostly, how the authentication will play between the public page and the SalesForce object? Do you have examples?

The public VF page needs to use OAuth instead of session id.

@stomita thanks for reply, do you have a sample how to consume objects and put in a guest (public) visual force page using oauth?

Just do it like other OAuth2 web integration. Login as a guest user is not possible as the API access doesn't allow that.


Move exit override to retarget.cpp

I moved the exit handler from exit.c to retarget.cpp where the rest of
the standard C library retargetting routines are found.  The exported
makefiles already explicitly link in retarget.o but not exit.o
When building with the GNU toolchain, it is safest to link in the
object file directly for retargetting routines so that GNU linker has
to use these versions of the routines.
Testing:
I have only tested this change with GCC_ARM. It should really be
tested with more toolchains before getting merged.

I'll test it with other toolchains

Tested with IAR and uVision, all green :green_apple:

@0xc0170
Thanks for the test pass and merging!


Create Istio Fault Tolerance rule

We need to create Istio fault tolerance config rule to do Retry, Circuit breaker, limit the concurrent requests, timeout. set the  MP_Fault_Tolerance_NonFallback_Enabled in configmap to disable MP FT annotations except fallback.

@jonhawkes will do a PR for this


Add support for anonymous functions (eval)

Given an error stack like this one:
ReferenceError: a is not defined
    at $$.onStart (eval at <anonymous> (http://localhost:8080/hg/html/js/homegenie.webapp.js?version=r525:6851:25), <anonymous>:32:7)
    at $$.RenderWidget (http://localhost:8080/hg/html/js/homegenie.webapp.js?version=r525:6770:36)
    at $$.RenderView (http://localhost:8080/hg/html/js/homegenie.webapp.js?version=r525:6757:12)
    at http://localhost:8080/hg/html/js/homegenie.webapp.js?version=r525:6879:24
    at Object.$.ajax.success (http://localhost:8080/hg/html/js/homegenie.api.js?version=r525:724:21)
    at l (http://localhost:8080/hg/html/js/jquery-2.0.2.min.js:3:24881)
    at Object.c.fireWith [as resolveWith] (http://localhost:8080/hg/html/js/jquery-2.0.2.min.js:3:25702)
    at k (http://localhost:8080/hg/html/js/jquery-2.0.2.min.js:5:4919)
    at XMLHttpRequest.<anonymous> (http://localhost:8080/hg/html/js/jquery-2.0.2.min.js:5:8723)

stackframe will currently ignore the eval <anonymous>:32:7 at the end of the first stack element, which is the real source of the error at line 32, column 7.
It will indeed report stack[0] with line 6851 and column 25.

@genielabs Stackframe itself handles eval origins as you can setEvalOrigin(Stackframe). However, error-stack-parser does not set eval origins yet, so I'm going to move this issue to that project. Thanks for submitting.

Issue moved to stacktracejs/error-stack-parser #32 via ZenHub


value_label - add_value_label - color of value_label

Describe the workflow you want to enable
Hi all, I wanted to use gray-scale colormap and add labels. july.calendar_plot and july.month_plot allowed me to add labels (a.k.a. ticks, values inside calendar cells) with value_label=True param, but did not allow me to change the color of these labels.
Example image and code attached

july.calendar_plot(data=df_plot.values, dates=df_plot.index, cmap="gray_r", value_label=True, title=False)

Describe your proposed solution

As far as I understand the source code, the affected line is below:
https://github.com/e-hulten/july/blob/master/src/july/helpers.py#L116

july/src/july/helpers.py
> 105 | def add_value_label(ax, cal, value_format):
> ...
> 118 | ax.text(j + 0.5, i + 0.5, val_format.format(z), ha="center", va="center")

Objects of matplotlib.axes.Axes.text class have color or c - color parameter documentation link.
We might add additional param responsible for color of values or transfer **kwargs

Describe alternatives you've considered, if relevant
Mayhap there are other ways to fix it
Additional context
Same issue may occur with other colormaps - it is difficult to separate dark colors from dark backgrounds (or to separate same tints, shades, tones in general). Also, color are important both from æsthetical and accessibility points see

Workaround solution
Currently, to change the color (or other properties) of text of values one may use functionality of rather "advanced" matplotlib:

Create the chart "as-is" with value_label=True
Get these texts (matplotlib.text.Text objects) children artists (ax.get_children() function) from objects of matplotlib.axes._subplots.AxesSubplot class

> `ax[indx].texts` or custom loop over `ax[indx].get_children()`

Set desired color manually for these texts objects

> `plt.setp(ax[indx].texts, color=color)` or custom loop with `Text.set_color(color)`

Sources (official documentation):

matplotlib.artist - Inheritance Diagrams
Artist tutorial - Using Artist objects to render on the canvas
Set and get properties

matplotlib.__version__ = 3.4.3


Move enforce_ssl to production:enforce_tls

Move the suspenders:enforce_ssl generator to
suspenders:production:enforce_tls. This namespaces it as something
specific to production (useful for those who are looking for the
Heroku-specific functionality), and it renames SSL to TLS, as that is
the abbreviation used in this century.
While here, shuffle some things around, which exposes existing bugs.
And fix those bugs!

This makes me twitchy because Rails calls it enforce_ssl. That means the generator name doesn't match the setting name. On the other hand, the setting name doesn't match the protocol! What's a dev to do?

I've been trying to name the generators after what they do and not how it is implemented. For example, the suspenders:lint generator configures Hound, but if we want to change from Hound to Code Climate in the future we won't need to rename it. Similarly suspenders:js_driver (c-w), suspenders:testing (Rspec), suspenders:analytics (Segment), etc.
Therefore, maybe suspenders:force_tls is shorter and nicer. Eh?

That makes sense and I feel better now.


Firmware

Dear Alex,
As you mentioned in Github, you use firmware by p-h-a-i-i.
Do you adjust any parameters in the original firmware? If yes, please send me your firmware by email<EMAIL_ADDRESS>Thank you,

Hey @quangvu16, I'm using bipropellant stock firmware.

Thank you. I will try

Hey @quangvu16, I'm using bipropellant stock firmware.

I built the firmware by uncommenting the usart2 on platformio.ini file and I get the following error repetiadly


Updates template testing script with additional options

Updates the template testing scripts with the following options:

Adds support to specify azure location/region to use (defaults to eastus2)
Adds configurable Playwright retries (defaults to 3)
Adds parallelism for azd up/down
Adds output to specify TEST_ONLY run
Adds option to specify whether local & remote cleanup should be performed

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
No changes detected.

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
No changes detected.

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
No changes detected.


Can't import encryption key for Saas version

Encryption is always turned on for online versions, and you cannot turn it off.
But why i can't import encryption key for Saas version

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 677649e2-d481-3988-b615-fa3614e1603f
Version Independent ID: d83f6d23-2c3e-1bb2-ddad-409ceaab58a4
Content: Manage Data Encryption - Business Central
Content Source: business-central/admin-manage-data-encryption.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: edupont

Hello @MakerX101,
Thank you for your feedback! As explained in the administration content, you cannot import or export encryption keys for Business Central online: https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-encrypting-data
Since your question is not about the Help, we suggest that you submit a feature request here: https://aka.ms/businesscentralfeedback


New Default Theme

Next Process, New FurtherLand Default Theme.
FurtherLand really need an new Theme, because the current one: without pjax technology, some UI really ugly, using too much ugly hacks and poor performance.
This may be an hard journey, which may costs one month or more time to finish.
The new Theme will be made with Google's MDL(Material Design Lite) Library.

New Theme 「Summer Night」 has released in v20150719 dev.


Install-PSResource prompts for untrusted repository even though resource is installing from a trusted repo

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
I am trying to install a resource and I have two repositories registered my computer's test repo and PSGallery. The test repo does not have specified resource but for some reason its prompting against that repository instead of passing since it resides in trusted PSGallery.
Expected behavior
Installs without any prompts

Actual behavior
PS C:\Users\Thomas> install-PSResource Microsoft.PowerShell.SecretStore

Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its Trusted value by running the Set-PSResourceRepository cmdlet. Are you sure you want to install the
PSresource from 'test' ?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"):
PS C:\Users\Thomas> ^C
PS C:\Users\Thomas> Set-PSResourceRepository -Name PSGallery -Trusted
PS C:\Users\Thomas> install-PSResource Microsoft.PowerShell.SecretStore

Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its Trusted value by running the Set-PSResourceRepository cmdlet. Are you sure you want to install the
PSresource from 'test' ?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"):
PS C:\Users\Thomas> Find-PSResource -Name Microsoft.PowerShell.SecretStore

Name                             Version Prerelease Repository Description
----                             ------- ---------- ---------- -----------
Microsoft.PowerShell.SecretStore <IP_ADDRESS>            PSGallery  …

PS C:\Users\Thomas> Get-PSResourceRepository

Name      Uri                                      Trusted Priority
----      ---                                      ------- --------
test      file:///C:/test/repo                     False   49
PSGallery https://www.powershellgallery.com/api/v2 True    50

PS C:\Users\Thomas> Find-PSResource -Name Microsoft.PowerShell.SecretStore -Repository test

Error details
N/A

Environment data
Name          Version
----          -------
PowerShellGet 3.0.14

Name                           Value
----                           -----
PSVersion                      7.2.5
PSEdition                      Core
GitCommitId                    7.2.5
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

It seems that the prompt is happening at the wrong place in the code.  It looks like when the cmdlet does a search, it prompts.  It should really prompt when doing the install.

This one should be resolved by #831


Python solution for 50: Horserace

Avoided any dictionary types, since those are not available in the
original BASIC version. This makes it slightly less idiomatic.
Tried my best to keep it as close to the original as possible.
Also horses are enumerated from 0, rather than from 1 as in the
original implementation (if needed this can easily be adjusted).
Hope this helps! Let me know if there need to be any adjustments.

Fantastic! Thank you 👏

Fantastic! Thank you 👏


Strange character inserted before result of each command

I use the latest oh-my-zsh from today with zsh 4.3.17, just installed via curl on Ubuntu 12.04 with GNOME Terminal. Whenever I run a command, a strange character is printed before the result:
werner@satyr:~/.oh-my-zsh% ls
klscustom  lib  log  oh-my-zsh.sh  plugins  README.textile  templates  themes  tools

Actually, the real output should start at custom, not with kls. Here's a screenshot:

The full .zshrc I use is here. Everything works fine without oh-my-zsh, but as soon as I source it, I get the problem mentioned above. Note that I primarily use this zshrc on OS X, but it has worked on Linux before.
Let me know if there is more information needed to get to the root of this issue.

@rolfschr thanks. this is helpful.
ubuntu 14.04 is the same problom.

 I was having this issue when using gnome-terminal and completely forgot to set the fonts in the Gnome Terminal profile prefs to use a Powerline font. Grr....
# If running in Gnome Terminal, set the default profile font to Powerline
if [ `echo $VTE_VERSION` -eq 3409 ]; then
  oldfont=$(gconftool-2 --get /apps/gnome-terminal/profiles/Default/font)
  newfont="Meslo LG M for Powerline 9"

  echo "Changing gnome-terminal Default profile font from: '$oldfont' to '$newfont'"
  gconftool-2 --set /apps/gnome-terminal/profiles/Default/font --type string "$newfont"
fi

I get on this today. The problem starts after set "export TERM="screen-256color"" on .zshrc. Enable DISABLE_AUTO_TITLE="true" has resolved the problem to me (thanks @joseronierison)


Django 3.0 support

Description
Upgrade to Django 3.0

[x] Bump version in requirements & get build to pass
[x] Update readme & documentation
[x] Deploy to prod & do sanity testing

Rationale
Fixes #2352
To test it out
You can try this out by running this command:
cookiecutter https://github.com/pydanny/cookiecutter-django --checkout django-30

Any help would be appreciated to help spot possible production issues. Please test it out and report any issues.

Are we dropping support for 2.2 LTS? It's still supported until 2022:
https://www.djangoproject.com/download/

I believe the aim is to be on the latest version, we've never supported 2 Django versions at once, as far as I know.

When will this be merged?

After more testing, yes

@AkashV10 did you gave this a try? Would appreciate any feedback, good or bad. I've left the command you need to run in the description at the top.

@browniebroke no. I was getting errors with setuptools on Windows with existing version so I just used the djangoX repo instead and modified as needed.


failed to extract

LogOutput.log

Parameter name: string
  at (wrapper managed-to-native) System.Object.__icall_wrapper_mono_string_from_byvalstr(intptr,int)
  at (wrapper managed-to-native) System.Runtime.InteropServices.Marshal.PtrToStructure(intptr,System.Type)
  at System.Runtime.InteropServices.Marshal.PtrToStructure[T] (System.IntPtr ptr)
  at System.Net.NetworkInformation.Win32NetworkInterface.get_FixedInfo ()
  at System.Net.NetworkInformation.Win32IPGlobalProperties.get_DomainName ()
  at System.Net.CookieContainer..ctor ()
  at System.Net.Http.MonoWebRequestHandler.get_CookieContainer ()
  at System.Net.Http.MonoWebRequestHandler.CreateWebRequest (System.Net.Http.HttpRequestMessage request)
  at System.Net.Http.MonoWebRequestHandler.SendAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
  at System.Net.Http.HttpClient.SendAsyncWorker (System.Net.Http.HttpRequestMessage request, System.Net.Http.HttpCompletionOption completionOption, System.Threading.CancellationToken cancellationToken)
  at FoundFootage.VersionChecker.GetVersion ()

Seems like this issue: https://forum.unity.com/threads/httpclient-getasync-doesnt-work-on-computers-with-pc-names-that-contain-non-latin-characters.1561297/
I will switch to UnityWebRequest in the next version and hope that it is not as crappy as its FCL version.


[Question]: How can I build a Q&A agent over a csv file present locally with Gradio UI?

Describe the bug
I'm attempting to construct a multi-agent system where I can load a CSV into memory using pandas, and then ask questions about the data for the agents to discuss and reach a solution. I want to deploy this Q&A system using Gradio, but when I transfer the logic to a .py file, it seems like the DataFrame isn't retained in memory. I could prompt it to read the file every time the code is executed, but that introduces additional latency due to the file's size. Is there a better way to accomplish this? In LangChain, I have utilized a pandas agent to achieve similar tasks, but I couldn't find anything helpful here for solving this problem
FYI: In a Jupyter notebook I was able to make it work.
Steps to reproduce
NA
Expected Behavior
NA
Screenshots and logs
No response
Additional Information
Python 3.10

@ekzhu


[twitter:card] HTTP Error 404

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.07.23. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.07.23

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl.py -v "https://twitter.com/OPP_HSD/status/890621485181620224"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://twitter.com/OPP_HSD/status/890621485181620224']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.07.23
[debug] Python version 3.5.1 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-71727-g46778ab, ffprobe 3.2, rtmpdump 2.4
[debug] Proxy map: {}
[twitter]<PHONE_NUMBER>81620224: Downloading webpage
[twitter:card]<PHONE_NUMBER>81620224: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; t
ype  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Transmogrifier\youtube-dl.py\youtube_dl\extractor\common.py", line 502, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "C:\Transmogrifier\youtube-dl.py\youtube_dl\YoutubeDL.py", line 2166, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "C:\Program Files\Python35\lib\urllib\request.py", line 471, in open
    response = meth(req, response)
  File "C:\Program Files\Python35\lib\urllib\request.py", line 581, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Program Files\Python35\lib\urllib\request.py", line 509, in error
    return self._call_chain(*args)
  File "C:\Program Files\Python35\lib\urllib\request.py", line 443, in _call_chain
    result = func(*args)
  File "C:\Program Files\Python35\lib\urllib\request.py", line 589, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://twitter.com/OPP_HSD/status/890621485181620224

Thanks
Ringo

Now that have a second look I think this is actually a periscope video that has been tweeted out
(similar to: Periscope video in tweet #10737)
The Periscope video DOES download correctly:
https://www.pscp.tv/OPP_HSD/1OwGWoZQDDkGQ?t=6

@dstftw This type of link works in the current version. This issue can be closed.


P4_16 (or PSA) - Consider creating padding primitive

Many P4 targets impose the limitation that headers must be a multiple of 8 bits long.
PSA defines several data plane types such as PortId_t that are bit<W>, where the value of W is fixed for a single target, but can vary from one target to another.  It need not be a multiple of 8 bits long.
Today there is no way to write P4 source code that includes such a field in a header definition and is portable across multiple targets with different bit widths for these fields, while satisfying the multiple-of-8-bits restriction that I suspect a large fraction of targets require.
PSA's current approach is to define additional types with similar, but different, names, where each is guaranteed to have a size that is a multiple of 8 bits by itself.
It may be useful to consider some kind of explicit padding constructs in the definition of P4 header types, where the size of the padding might vary from target to target, but no one need modify the P4 source code to adjust the size of the padding manually for each target.

Or we could have an annotation @padded(8)

If the padding is target specific it would be better to have a compiler option that specifies the padding and the size for the target. Or the size can simply be part of the backend for the target, in which case the option just signals to pad all headers (I can't imagine that we'll have a case in which some headers need to be aligned (padded) and some won't).

Marking this as PSA. I would propose that you prototype it there, and then bring it back to the LDWG group if it is working well.


ButtonImg does not actually draw a button of size "size"

Description
The "size" parameter to ButtonImg doesn't seem to work correctly. UI.ButtonAt and UI.Button both create buttons of size size, but ButtonImg does something... else?

All three of these buttons have the argument size = new Vec2(0.032f, 0.032f), which should result in a 32mm by 32mm button. However, ButtonImg seems to have its own opinion of what 32mm is!
Platform / Environment
SK Universal Template, currently on Dotnet target.

Yeah, it was just a bad padding flag, easy fix!

v0.3.7-preview.3 is now up, and contains the fix for this :)


Win+DownArrow also works on forms without a Minimize Control Button.

When a form's minimize control button is removed through:
#include <lecui/controls.h>
...
lecui::controls ctrls_{*this};
...
ctrls_.minimize(false);
...

the form can still be minimized by using the keyboard shortcut Win+DownArrow. This should not be so.

Fixed in 55036c164fc351ca1e2e305416a6c5901362cbfe.


out-of-bounds panic in utils::expand_pass

thread '<unnamed>' panicked at 'index out of bounds: the len is 56 but the index is 56', png-0.16.5/src/utils.rs:248:17
Sample file triggering the panic: mysterious-oob-crash
The coolest thing about this is that this bug is not reproducible with png's current cargo-fuzz fuzzing harness for decoding. I get the panic only with the following code:
#![no_main]
use libfuzzer_sys::fuzz_target;

use std::io;
extern crate png;

fn decode_png(data: &[u8])
    -> io::Result<Vec<u8>>
{
    let limits = png::Limits { bytes: 1 << 16 };
    let decoder = png::Decoder::new_with_limits(data, limits);
    let (info, mut reader) = decoder.read_info()?;

    if info.buffer_size() > 5_000_000 {
        return Err(std::io::Error::new(std::io::ErrorKind::Other, "memory limit exceeded"));
    }

    let mut data = vec![0u8; info.buffer_size()];
    reader.next_frame(&mut data)?;

    Ok(data)
}

fuzz_target!(|data: &[u8]| {
    decode_png(data);
});

Backtrace:
thread '<unnamed>' panicked at 'index out of bounds: the len is 56 but the index is 56', /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/png-0.16.5/src/utils.rs:248:17
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1069
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1504
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:218
  10: <alloc::boxed::Box<F> as core::ops::function::Fn<A>>::call
             at /home/shnatsel/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/liballoc/boxed.rs:1022
  11: libfuzzer_sys::initialize::{{closure}}
             at /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/libfuzzer-sys-0.3.2/src/lib.rs:50
  12: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:515
  13: rust_begin_unwind
             at src/libstd/panicking.rs:419
  14: core::panicking::panic_fmt
             at src/libcore/panicking.rs:111
  15: core::panicking::panic_bounds_check
             at src/libcore/panicking.rs:69
  16: png::utils::expand_pass
             at /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/png-0.16.5/src/utils.rs:248
  17: png::decoder::Reader<R>::next_frame
             at /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/png-0.16.5/src/decoder/mod.rs:406
  18: roundtrip::decode_png
             at fuzz_targets/roundtrip.rs:23
  19: rust_fuzzer_test_input
             at fuzz_targets/roundtrip.rs:29
  20: libfuzzer_sys::test_input_wrap::{{closure}}
             at /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/libfuzzer-sys-0.3.2/src/lib.rs:27
  21: std::panicking::try::do_call
             at /home/shnatsel/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panicking.rs:331
  22: __rust_try
  23: std::panicking::try
             at /home/shnatsel/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panicking.rs:274
  24: std::panic::catch_unwind
             at /home/shnatsel/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/panic.rs:394
  25: LLVMFuzzerTestOneInput
             at /home/shnatsel/.cargo/registry/src/github.com-1ecc6299db9ec823/libfuzzer-sys-0.3.2/src/lib.rs:25
  26: _ZN6fuzzer6Fuzzer15ExecuteCallbackEPKhm
  27: _ZN6fuzzer10RunOneTestEPNS_6FuzzerEPKcm
  28: _ZN6fuzzer12FuzzerDriverEPiPPPcPFiPKhmE
  29: main
             at libfuzzer/FuzzerMain.cpp:19
  30: __libc_start_main
  31: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Ah, I think this is what makes all the difference:
let mut data = vec![0u8; info.buffer_size()]; versus Vec::with_capacity(info.buffer_size()); in png's own fuzzing harness. Apparently the png fuzzing harness has always been passing zero-sized output buffer... because &mut Vec<u8> transparently coerces to &mut [u8] and the types magically work out... despite &mut Vec<u8> being extensible and &mut [u8] not, so zero-lenght Vec makes sense but not zero-lenght &mut [u8].
So much for "if it compiles, it works".

I've fixed the fuzzing harness in #220 but the panic still stands.

We'll need to rewrite color handling, it's a mess. The 56×1 image with RGBA/2bit has an unexpanded length of 56 bytes but the expansion pass wants to exand each channel to 8bits for quadruple the data. For some reason, output_buffer_size() uses the internal color type to calculate line size and this is of course not enough.
It doesn't not appear to cause an issue in non-interlaced images because here we simply ignore the additional data.


Goto Page on click event

Hello, i am using click event, but unable to understand how can i open specific page by check route params ?
route://userDetails?userid=123
Want to goto user details page and read 123

You should create a click listener for handling jumping pages.
`class DefaultClickListener implements ClickListener{
@override
void onClicked(String event) {
print("Receive click event: " + event);
}
}`


Properly handle error while saving files

When an error occurs while saving a file we need to put the associated
file editor back in the dirty editors list. Otherwise data may be
lost. Prior to this fix once i/o failed, the editor was considered clean
and i/o would not be retried unless the editor was modified again. So
for example if a designer attribute was changed, but the i/o failed, it
would not get saved again, even if a change was made in the blocks
editor and even if the “Save project” menu was used.
Note: We do not re-schedule the failed i/o but instead depend on another
user change (anywhere) or explicit use of the “Save project” menu. I
considered re-scheduling the i/o but am concerned that if i/o is failing
due to a server problem, a lot of clients retrying i/o may make it worse
via the “thundering herd!”
Change-Id: Ife50c3c20d407b4e009c639bc36c2596331342d7

I ran into this when updating code.appinventor.mit.edu. Because I was going to have "code" out of service for a while, I put up a website in its stead whose homepage explained the outage and any other attempted page returned a 503 error. So people running the client would be alerted that something was amiss. But guess what, after the i/o failed, the client considered it saved (clean). That is what I am fixing here!


replaced Shaed's PAT with HMCTS

JIRA link (if applicable)
VIH-7660
Change description
change PAT token
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

no issues


Fix typos and word splits in Danish translation

CLA is signed.

Coverage remained the same at 61.959% when pulling ce70580e11a68fa2e7573d7ab3cccbc4a5554968 on Martin4ndersen:da-coffee-fix into 5529c7a14c9e17ea1efb5204af49bffae2f08beb on codecombat:master.

Thanks. Merged.


Map citext type from PostgreSQL to string type in TypeScript

Description 📖
Map citext type from PostgreSQL to string type in TypeScript.
Background 📜
citext is case-insensitive character string type in PostgreSQL. It's often used for unique fields where case sensitivity should be ignored, like email, repo name, etc. Supporting this mapping by default would make it easier to integrate this library in a codebase that is using citext.
I wanted to add a spec that tests the behaviour through Property#infer_type_from but the current test suite is not very friendly in this aspect 😅
The Fix 🔨
By addin default mapping from citext to string, developers won't have to extend the gem's config only to support this mapping in their app.

Looks good, thanks Ventsislav! 😃

Thanks for the fast response. I love the idea behind the library ❤


How to exclude tags in body

Describe the bug
I would like it that tags are only picked up when they are in the front matter, not when they are in the body. Would that be possible?

You can pass parseTags: false to Plugin.ObsidianFlavoredMarkdown()
Docs: https://quartz.jzhao.xyz/plugins/ObsidianFlavoredMarkdown


Rattle breaks under unitful

AtomsBuilder's rattle function currently breaks, when unitful conversion is required:
using AtomsBuilder
using Unitful, UnitfulAtomic

system = bulk(:Si)
rattle!(system, 0.1)  # works
rattle!(system, 0.1u"angstrom")  # works
rattle!(system, 0.1u"bohr")  # MethodError

Pkg.status()
#  [f5cc8831] AtomsBuilder v0.2.0
#  [a7773ee8] UnitfulAtomic v1.0.0

I can open a small PR to fix this, if it makes sense?

yes please.


Accessible swipe

I am working through several accessibility items in a new app I am buildind with the framework. For the most part it is somewhat accessible. The photo browser has a few pieces that could be improved on when voiceover is active on an app. First is that swipe gestures completely stop when voiceover is active. I know when using other 3rd party gesture libs (hammerjs & quo) that the gesture is still recognized and actionable when using the accessible gesture (3 finger swipe). Is there any plan for supporting swipe in accessibility mode?

Sorry for the late reply - didn't see your follow up.
So in short the idea would be to add caption property to the image object and then assign that the image element when the template is generated.
You can see how I implemented in an app with an override on the hook onSlideChangeEnd in lines 801-808 of https://github.com/codearachnid/com.chestercomix.reader/blob/master/www/js/app.js
if( activeSlide.find('.align-claw-to-this').attr('alt') == '' ){
    var caption = response.comix[0].panels[ slider.activeSlideIndex ].caption;
    activeSlide.find('.align-claw-to-this').attr('alt',  caption );
}

Does F7 support accessibility at all from the ground up? If not, I'm not sure that this fix does make sense.


Is there a way to remove playground:theme=playground from the suggestion list?

Describe the bug
I monitor new user activity and I see quite a few playgrounds with playground:theme=playground.
Example: https://osmcha.org/changesets/149253152?aoi=4da8bade-add6-49e0-b2d6-9baf69253667
I expect users to just fill in what makes most sense from the list in iD. However, this value is given by Taginfo (I assume…) and should not be used.
Is there a way to remove it from the auto suggestion list … without taking over the whole list as a fixed list?

In the past, we’ve had some other malformed values crop up due to an import, such as country=Tanzania in https://github.com/openstreetmap/iD/issues/7123#issuecomment-653817884, which we simply fixed in the database. However, this appears to be organic usage. playground:theme=playground has the straightest hockey stick graph I’ve ever seen on taginfo, and it’s somewhat broadly distributed geographically.
There are some other tautological key-value pairs, such as traffic_signals=signals, but they sort of get a pass as an affirmation that no other value applies (so an editor like StreetComplete wouldn’t need to bother asking). For something more freeform like playground:theme, a tautological value is probably less useful.

Maybe we should just demote the theme tag from the leisure=playground preset into a "moreTags".
It is super prominent right now https://ideditor.netlify.app/#background=Berlin-2018&disable_features=boundaries&id=w60443941&map=20.00/52.47433/13.44798 and it really should not be…

Maybe we should just demote the theme tag from the leisure=playground preset into a "moreTags".

I did just that in https://github.com/openstreetmap/id-tagging-schema/pull/1191

However, this appears to be organic usage.

It seems to me to be induced by iD interface (prominence of field, high position on unmoderated list) and applied without some deeper intention.
I would consider removing it from database. Maybe ask some sample of people adding it?

It seems to me to be induced by iD interface (prominence of field, high position on unmoderated list) and applied without some deeper intention.

Maybe, I just meant that it doesn’t look like an import. It clearly grew thanks to prominent placement in iD, but normally that effect is less stark than what we see here. It’s almost as if there was a campaign to set the field, now that it’s available in iD.

I would not really call it organic. I expect that people setting it have no idea what they are actually doing and if such prominent location would disappear the growth would stop.

The field was now moved to the optional fields.
There is however one more thing we could do: iD will not autosuggest tag values which are in the deprecated.json list. It is possible to add a tag to that list even without a replacement tag. For these tag, iD will also show the "tag issue" warning and suggest to simply remove the tag. Currently, this is already used for the tags content=unkown (a field of the storage tank preset) and operator:type=unknown.
As the tag playground:theme=playground seems to add little to no information, so maybe it should also be added to the "deprecated" tags list?

I think a deprecation is a good idea!

done in ed497a32


Update jackson-databind version

Update Jackson version to fix silence  security alerts

I have this applied on my development site, and it works without problem - recommend merging.


fix some link references for openwhisk

please review and merge @sefuhrer

good updates - requesting a build now.


Abbreviation for Update Management Center

There is no abbreviation for Update Management Center.
May I suggest umc.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8c22eb33-2fde-55b4-021d-e229c857e51b
Version Independent ID: 1f767675-7d50-6ea5-b798-1323cd4a63a1
Content: Abbreviation examples for Azure resources - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/resource-abbreviations.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @stephen-sumner
Microsoft Alias: ssumner

@o-l-a-v : Thanks for the suggestion. I've never used the update management center, but I currently don't see where you would need to name an instance of it? Can you clarify your request?

@o-l-a-v : Thanks for the suggestion. I've never used the update management center, but I currently don't see where you would need to name an instance of it? Can you clarify your request?

I probably done goofed again, like I did with Sentinel. I haven't used it either. If one can't choose the name of an instance of it, theres no point with an abbrevation.

@o-l-a-v - All good! Thanks for the input as always! Have a good one!


Feat/sub categorys

guys let's give some feedback or approve it @Nodrex  @shalva97

guys let's give some feedback or approve it @Nodrex  @shalva97

I agree, since i also made changes to this branch let others review it
@shalva97
@tkhat
@nmgalo
@likaGlonti


Add error message for return item without channel

I keep making a mistake like this:
@single_value_node("sum")
def addition(a, b):
    return a + b

@single_value_node("product")
def multiplication(a, b):
    return a * b

@macro_node("result")
def add_and_multiply(macro):
    macro.addition = addition(1, 2)
    macro.multiplication = multiplication(macro.addition, 5)
    return macro.multiplication.outputs.product.value

node = add_and_multiply()

The main problem is that in the current implementation it only says NOT_DATA does not have channel, which doesn't immediately make me understand where the error is coming from.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
11 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 91.791%

Files with Coverage Reduction
New Missed Lines
%

macro.py
11
89.12%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5837

Relevant Lines:
6359

💛  - Coveralls

Oh, and we need a test added that catches the new message

Ok, I've got my computer and I stand by everything I said earlier. More specifically, somewhere in here:
https://github.com/pyiron/pyiron_workflow/blob/bb326ec6d26efd371eac45d431c0d3d6d1dc680a/pyiron_workflow/macro.py#L313-L319
I'd slot in a new method like self._ensure_returned_objects_are_has_channels (or similar) that does the check you want. This is perfectly in line with the variable name, it's just that right now the code assumes that the user has correctly returned only HasChannel objects. I totally agree that's an easy mistake though, so let's add the filtering. To fail as early as possible I recommend inserting the check immediately after line 313.
In the future we could even imagine extending the check to create channel objects from non-HasChannel returns. This heads in the direction of getting macro and function nodes to be more similar, and is absolutely not necessary here and now, but I like that this change is commensurate with that direction.

Ok I messed around. In the end I didn't put it in __init__, because for my taste there are already too many lines. I also added a test.

Ugh, my rerun failed jobs button has no effect. I'm not sure if it's a problem with my browser or what, but this happens sometimes. @samwaseda could you rerun the failed windows test before merging?


Deploy subcommand for CLI tool

Implements the deploy subcommand.
deploy cleans the relevant target directory, runs tests and builds the project. It then creates a deploy directory, zips all files (including the directory itself) in resources, and copies all dynamically linked libraries and binaries to deploy.

I was also planning on including the option of specifying the deploy directory, but I think that could wait for some time in the future.

@ogoding #24 should allow to pass strings to subcommands, but will aso break your code, so you'll need to merge from master, if my PR is going to land (I hope it will).

@White-Oak Ah, so now Vec<&str> are ArgMatches interchangeable for the commands? Cool. I'll have a look at merging from master when it lands :smile: I'll make deploy always just supply vec!["--release", "--color=always"] to test and build.

@ogoding those commands already supply color=always and instead of --release, you'll need to supply release to them (that's what they're looking for).

@White-Oak Pull request #24 looks pretty good to me. @ogoding, what are your thoughts? Whose PR should I merge first to minimize breakage?

@ebkalderon this is going to be merged first, since @ogoding 's work is dependent on this.

@ogoding All right, #24 has been merged. Go ahead and rebase! If you need any assistance, I'm sure we'd all be happy to help.

@ebkalderon Merging it now, just trying to work out how to call/import the new methods from the deploy Cmd struct at the moment.

@ebkalderon Should be merged without issue now! Will try to finish off the conversion from std;:io::Error to &str and then it'll all be finally done! :smile:

@ogoding I have some work done with that. Would you like me to give you a small PR that removes the tryio! macro so we can just use try! everywhere and not have that borrow issue.

@LucioFranco That'd be great, thanks. Hopefully you don't have any conflicts, but I suspect you might.

@ogoding I am almost ready with the new error system. Expect a PR within the next 20. (Hopefully) :)

@ebkalderon PR is finally all done! Let me know if there is anything else that I should improve.

Wonderful job! I'll try it out on my laptop tomorrow.

@ogoding The resources.zip file structure seems incorrect when testing on my laptop.
Currently it is:

resources.zip

resources/ (folder)

entities (file)
prefabs (file)
config.yml (file)
input.yml (file)

resources (file)

It should be:

resources.zip

entities/ (folder)
prefabs/ (folder)
config.yml
input.yml

@ebkalderon hmm, I'll have a look at it. Probably that resources file is due to walkdir using the given path as the first file/folder it iterates.

AFAIK, zip can't have folders without files.

@ebkalderon Just pushed a fix for those compression issues. Turns out that rust doesn't include a / character at the end of a directory's path. Also WalkDir starts in the current directory so I had to change it back to fs::read_dir(path) and use WalkDir for any sub directories in resources/.

@ogoding Testing it now!

@ogoding It works perfectly! Thank you so much for your effort and patience. I think this pull request is finally ready to be merged.


Janitor Monkey recorder changes

Add additional resource fields and resource tags to Janitor Monkey cleaning events.  Change processing order to generate event after cleanup instead of before.

NetflixOSS » SimianArmy » SimianArmy-pull-requests #36 SUCCESS
This pull request looks good

SimianArmy-pull-requests #208 SUCCESS
This pull request looks good


Migrate data structures

Migrate singly linked list
Migrate binary search tree

@faheel Besides the fixes you pointed out today and a few other little things here and there (migrating utils.hpp to the proper sorting folder, for one), I think this is the final step of converting all existing code into the new format. Only took us two years!  😄
I'll leave this open until you've had a chance to look it over.

The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-5.0" failed and exited with 100 during .

I just re-ran the build associated with #250 without issue, which makes me think that there's something up with this PR. On the other hand, this seems to indicate an issue with using Trusty as the default build environment. Apparently Travis is migrating to Xenial.

The most recent commit appears to have done the trick. Specified Trusty manually, though it seems like at some point we'll want to migrate this to Xenial.

Requested changes submitted, including the issues with the Node references and pointers.

Changes and fixes implemented. Ready to merge as far as I'm concerned.

Nice work @alxmjo!


Add: MTV Sub

Channel Name
MTV Sub
Alternative Names (optional)
MTV Sub HD
Network (optional)
No response
Owners (optional)
No response
Country
FI
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/FI
Languages
fin
Categories (optional)
No response
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://fi.wikipedia.org/wiki/MTV_Sub
Logo
https://img.prod.telkku.com/channel-logos/MTV_Sub_logo.png
Notes
No response

Duplicate of https://iptv-org.github.io/channels/fi/Sub


KOGITO-6441: Responsive dropdown component (OpenShift deployments)

JIRA Issue
https://issues.redhat.com/browse/KOGITO-6441
On this PR

Added a new component to be used as a Dropdown. It wraps Patternfly dropdown components, keeping the same API while providing a way to switch to a Modal when a certain breakpoint is reached while resizing the viewport.

Before
https://user-images.githubusercontent.com/10515135/148110845-a23e3948-5217-4dff-b3c1-1b60973079ad.mp4
After
https://user-images.githubusercontent.com/10515135/148110860-993a362b-0815-47bc-ba10-8d1253c8fcba.mp4

@tomasdavidorg This is ready for review.


Showing error 'X11 connection rejected because of wrong authentication' when running from ssh shell

I am trying to run in headless mode. I updated the compose file as per monitor requirements instructions.
I run as below:
./run-gow --platform headless --gpu nvidia --app steam up
I get error:
X11 connection rejected because of wrong authentication
The gow-xorg shows error :
gow-xorg-1      | error: could not open display
How can i fix the 'X11 connection rejected because of wrong authentication' error? I am running gow as a non-root user.

The GOW script is getting rusty and unmaintained; I'm working on Wolf https://github.com/games-on-whales/wolf as a replacement for this stack, would you be interested in trying it out?


add MinIO tests

This starts MinIO and Redis servers during CI tests, and uses MinIO to run the HostedStorageManager tests we have previously used for AWS S3 and Azure.
This is a step to supporting and testing snapshots in grist-core.

Thanks @georgegevoian. I also added a small change to obscure keys in logs:
...
2022-12-22 09:45:08.074 - info: == grist.externalStorage.minio.port: 9000 [GRIST_DOCS_MINIO_PORT]
2022-12-22 09:45:08.074 - info: == grist.externalStorage.minio.useSsl: 0 [GRIST_DOCS_MINIO_USE_SSL]
2022-12-22 09:45:08.074 - info: == grist.externalStorage.minio.accessKey: ***** [GRIST_DOCS_MINIO_ACCESS_KEY]
2022-12-22 09:45:08.074 - info: == grist.externalStorage.minio.secretKey: ***** [GRIST_DOCS_MINIO_SECRET_KEY]
...

@berhalak test failure looks webhook related:
  1) DocApi
       should work with a merged server
         Webhooks
           /webhooks endpoint
             should return statistics:

      AssertionError: expected<PHONE_NUMBER>826 to be above<PHONE_NUMBER>826
      + expected - actual

      at Context.<anonymous> (test/server/lib/DocApi.ts:3551:16)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

  2) DocApi
       should work with a merged server
         Webhooks
           /webhooks endpoint
             should monitor failures:

      AssertionError: expected 3 to equal 2
      + expected - actual

      -3
      +2

Rebased to pick up test fix in #383


Teleporting

Allow someone to request teleporting everyone of the group they are monitoring to them.
Todo:

[ ] Track who's monitoring who. (A list of who gets the request to teleport)
[ ] Provide a /inotify tp_here to request all of the list of players to teleport to location. (I.E. "ApolloX is requesting you at (x, y, z). Use /inotify yes to accept or /inotify no to deny. Request will wait 30 seconds then timeout.")
[ ] Provide a /inotify yes or /inotify no chat commands to accept or deny teleporting there.

Teams is being scrapped.


Since v0.6.0, it does not work with powershell anymore.

We were able to confirm that it works on Linux.

fn app() is stopped by crossterm::execute macro

It didn't work in windows git bash either.

The press, release, repeat causes a double input, and powershell generates two enter events and terminates immediately. git bash does not terminate immediately, but does not seem to be working correctly due to the double input.


[BUG] Set Harvester containerd-registry to use default value also cleanup previous status setting

Describe the bug

When we already have setup valid setting in Harvester containerd-registry, after clicking the Use default value and save.

We found the status field of the containerd registry setting also been cleanup to empty in K9s

Which would cause no new apply-sync-containerd jobs trigger to update the containerd setting

To Reproduce
Follow the steps to prepare test environment https://github.com/harvester/tests/issues/476#issue-1355132277
Steps to reproduce the behavior:

Update the Harvester containerd-registry setting to use private registry

{
"Mirrors": {
  "docker.io": {
    "Endpoints": [
      "https://myregistry.local:5000"
    ],
    "Rewrites": null
  }
},
"Configs": {
  "myregistry.local:5000": {
    "Auth": null,
    "TLS": {
      "CAFile": "",
      "CertFile": "",
      "KeyFile": "",
      "InsecureSkipVerify": false
    }
  }
},
"Auths": null
}

Open K9s -> search -> secrets -> containerd -> y

Check content in cattle-system/harvester-containerd-registry secret is changed.

Search jobs -> containerd -> l -> tail
Check there are new jobs to auto apply the new containerd-registry setting.

Apply following yaml in fileapiVersion: apps/v1
kind: Deployment
metadata:
  name: myregistry-nginx
spec:
  selector:
    matchLabels:
      image: myregistry-nginx
  template:
    metadata:
      labels:
        image: myregistry-nginx
    spec:
      containers:
        - imagePullPolicy: Always
          image: myregistry.local:5000/nginx:latest
          name: nginx

harvester-node-0:~ # kubectl apply -f deploy.yaml
deployment.apps/myregistry-nginx created

search deployments -> default namespace -> myregsistry-nginx -> describe -> shift + g
Check the nginx can be deployed.
Click the default value to update the Harvester containerd-registry setting to default empty
In K9s, search settings -> containerd -> y
Check the status field
In K9s, search jobs -> containerd
Check if new apply-sync-containerd jobs created

Expected behavior

When we set containerd registry back to default, the settings of container registry should retain the previous status
And there should be new apply-sync-containerd jobs created to update the setting accordingly
Support bundle

supportbundle_b03ed342-6a09-44e9-9236-be3a26dd0be4_2022-10-05T07-10-17Z.zip
Environment

Harvester ISO version: master-75876dee-head (10/05)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): 1 node local kvm machine

Additional context
Add any other context about the problem here.

Hi， @TachunLin  This should not be a UI enhancement, I removed the area/ui label, feel free to add it if needed.  thanks

Hi @TachunLin, I tested again on harvester v1.1.0-rc2 with the latest dashboard UI. I think the issue is fixed. Also, when users click "Use default value", related annotations and status is not removed. Thank you.

I validated that this looks good on v1.1.0-rc3.
Thanks again for the edits @WuJun2016 ! :+1: :smile:

I'll go ahead and close this out :smile: !


legacy bindist files seems to have a lot of unreachable code

e.g. https://github.com/sgammon/rules_graalvm/blob/aedd413d30acaa4d8677c63c1772ff8f26df8c53/internal/graalvm_bindist_legacy.bzl#L85
it seems your code is now looking for things of different shape. If you look in that file and try to figure out how to access those, you can't.
For instance, many have sha keys, but your code is looking for sha256. Seems like most of that needs to be removed.
I'm can't get it to work yet, so it may still be operator error, but it looks like the legacy stuff doesn't work, so maybe just remove it and have a clear and tested upgrade guide for people who want to create native image binaries.

@johnynek it's supposed to fallback to equivalent code from rules_graal when it consults the older bindist map. I'll take a look at this and add an integration test too.


Drug Label Extraction Using Deep Learning

This closes #3497
Article checklist
Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #issue-number

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Plagiarism check done - Proceed.

@collins-a Done making the changes.

@wilkistermumbi unfortunately, this article is not ready for final review. I found numerous errors, poor sentence structures, and numerous repetitions. I would suggest going through the article, correcting all errors, and then create a new PR when ready. I will be losing this one for now. Thanks
cc @collins-a

@wilkistermumbi unfortunately, this article is not ready for final review. I found numerous errors, poor sentence structures, and numerous repetitions. I would suggest going through the article, correcting all errors, and then create a new PR when ready. I will be closing this one for now. Thanks
cc @collins-a

I don't think this warrants closure of the tutorial. Why couldn't you point out where you thought there was a problem? This is the first time I'm having my article closed. And I've written many articles before.
CC:
@hectorkambow
@WanjaMIKE
@collins-a

@WanjaMIKE  What could be done to improve the tutorial??
cc @lalith1403 - also would like Laliths thoughts as he is our resident ML expert.

I don't think the problem is because the tutorial is light on substance. @WanjaMIKE pointed out that he found found numerous errors, poor sentence structures, and numerous repetitions. I'd like that bit to be pointed out. I've been contributing for Section for a while now, I'm honestly surprised with the closure of my tutorial.
CC: @lalith1403

Hello @wilkistermumbi. This is a good article. However, as @WanjaMIKE mentioned, there are several sentences that are difficult to comprehend. Once that is fixed, we can proceed with the final review. I loved reading the article. Covers the practical aspects of implementing an OCR system.
cc: @hectorkambow

Hello @wilkistermumbi. This is a good article. However, as @WanjaMIKE mentioned, there are several sentences that are difficult to comprehend. Once that is fixed, we can proceed with the final review. I loved reading the article. Covers the practical aspects of implementing an OCR system.
cc: @hectorkambow

Noted @lalith1403 I'll make the requested changes.
CC: @collins-a

@WanjaMIKE Could you re-open my tutorial and add an enhancement label instead? I cannot edit file if the PR is closed.
cc: @lalith1403 @hectorkambow  @collins-a

@collins-a  Please have a look.

@lalith1403 @collins-a It should be ready for final review now.

@WanjaMIKE can you take a look at this PR?

Jumping on - Mike is having a slight issue with his GitHub.

👍 very cool - overall nice work


[SPARK-9281] [SQL] use decimal or double when parsing SQL

Right now, we use double to parse all the float number in SQL. When it's used in expression together with DecimalType, it will turn the decimal into double as well. Also it will loss some precision when using double.
This PR change to parse float number to decimal or double, based on it's  using scientific notation or not, see https://msdn.microsoft.com/en-us/library/ms179899.aspx
This is a break change, should we doc it somewhere?

Merged build triggered.

Merged build started.

Test build #38337 has started for   PR 7642 at commit 1c48e34.

Test build #38337 has finished for   PR 7642 at commit 1c48e34.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1197 has started for   PR 7642 at commit f4a320b.

Test build #1197 has finished for   PR 7642 at commit f4a320b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Merged build started.

Test build #38379 has started for   PR 7642 at commit eca99de.

Test build #38379 has finished for   PR 7642 at commit eca99de.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38384 has started for   PR 7642 at commit 5e142b6.

Test build #38384 has finished for   PR 7642 at commit 5e142b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #38679 has started for   PR 7642 at commit 1f576d9.

Test build #38679 has finished for   PR 7642 at commit 1f576d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

cc @yhuai @rxin

We should add "releasenotes" label to the JIRA ticket.

cc @cloud-fan for review too

LGTM

@davies  do we need to change the hive ql part?

@rxin HiveQl already does this, it always parse float number as decimal.

Great - merging this in. Thanks.

hi @davies  seems this is not compatible with hiveql, HiveQl still parse float number as double. https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala#L1670-L1689
Or i missed sth?

Yes, If you use HiveContext, you will be compatible with Hive, but SQLContext will not.


feat(main): add method to check SGX instance ID on docs

changes
Add documentation on how to verify SGX registration ID
reason for changes
I believe the SGX instance ID can be found from Transaction, even if you missed it during registration. I added it to the documentation because I think it would be more convenient to be able to refer to it as a confirmation method in case it was overlooked.

included in #427


missing dependencies sklearn for windows

Rasa Core version (e.g. 0.7.3):
Rasa Core - 0.7.1
Operating system (windows, osx, ...):
Window 10 64-bit
PIP - 9.0.1
Python - 3.6.3
Issue:
I am able to set up rasa and do a "Hello, World" as described on https://core.rasa.ai/installation.html
however , when i am trying Rasa Core as a HTTP server (https://core.rasa.ai/http.html) , i keep facing
PS C:\temp\rasa_core>  python -m rasa_core.server -d examples/babi/models/policy/current -u examples/babi/models/nlu/current_py2 -o out.log
Using TensorFlow backend.
2017-10-11 15:56:21.537946: W C:\tf_jenkins\home\workspace\rel-win\M\windows\PY\36\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-10-11 15:56:21.538093: W C:\tf_jenkins\home\workspace\rel-win\M\windows\PY\36\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
WARNING:rasa_nlu.model:Deprecated use of `Interpreter.load` with a metadata object. If you want to directly pass the metadata, use `Interpreter.create(metadata, ...)`. If you want to load the metadata from file, use `Interpreter.load(model_dir, ...)
DEBUG:pip.vcs:Registered VCS backend: git
DEBUG:pip.vcs:Registered VCS backend: hg
DEBUG:pip.pep425tags:Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
DEBUG:pip.pep425tags:Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
DEBUG:pip.pep425tags:Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
DEBUG:pip.pep425tags:Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
DEBUG:pip.vcs:Registered VCS backend: svn
DEBUG:pip.vcs:Registered VCS backend: bzr
INFO:rasa_nlu.components:Couldn't read dev-requirements.txt. Error: [Errno 0] Error: 'rasa_nlu\\..\\alt_requirements\\requirements_dev.txt'
Traceback (most recent call last):
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\temp\rasa_core\rasa_core\server.py", line 147, in <module>
    cmdline_args.log_file)
  File "C:\temp\rasa_core\rasa_core\server.py", line 71, in __init__
    self.agent = self._create_agent(model_directory, nlu_model)
  File "C:\temp\rasa_core\rasa_core\server.py", line 75, in _create_agent
    return Agent.load(model_directory, nlu_model)
  File "C:\temp\rasa_core\rasa_core\agent.py", line 51, in load
    _interpreter = NaturalLanguageInterpreter.create(interpreter)
  File "C:\temp\rasa_core\rasa_core\interpreter.py", line 27, in create
    return RasaNLUInterpreter(model_directory=obj)
  File "C:\temp\rasa_core\rasa_core\interpreter.py", line 136, in __init__
    os.environ))
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_nlu-0.10.1-py3.6.egg\rasa_nlu\model.py", line 229, in load
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_nlu-0.10.1-py3.6.egg\rasa_nlu\model.py", line 252, in create
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\rasa_nlu-0.10.1-py3.6.egg\rasa_nlu\components.py", line 96, in validate_requirements
Exception: Not all required packages are installed. To use this pipeline, you need to install the missing dependencies.
Content of domain file (if used & relevant):

When you run C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36 in an interactive python session, are you able to import sklearn ?

hey tmbo , thanks for the prompt reply.
 import sklearn
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\sklearn\__init__.py", line 134, in <module>
    from .base import clone
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\sklearn\base.py", line 12, in <module>
    from .utils.fixes import signature
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\sklearn\utils\__init__.py", line 11, in <module>
    from .validation import (as_float_array,
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\sklearn\utils\validation.py", line 18, in <module>
    from ..utils.fixes import signature
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\sklearn\utils\fixes.py", line 144, in <module>
    from scipy.sparse.linalg import lsqr as sparse_lsqr  # noqa
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\scipy\sparse\linalg\__init__.py", line 114, in <module>
    from .isolve import *
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\scipy\sparse\linalg\isolve\__init__.py", line 6, in <module>
    from .iterative import *
  File "C:\Users\KIANMENG\AppData\Local\Programs\Python\Python36\lib\site-packages\scipy\sparse\linalg\isolve\iterative.py", line 7, in <module>
    from . import _iterative
ImportError: DLL load failed: The specified module could not be found.

there is indeed some problem, i tried to google and i reinstalled scipy and scikit-learn still the same issue...
any idea how can i fix this?

Found out the issue, its with numpy, i need to install numpy+mkl instead .
Closing this , thanks!

@kianmeng-aft mind sharing the commands you ran to resolve the problem? I think a couple other windows users ran into a similar issue with sklearn.

i downloaded numpy‑1.13.3+mkl‑cp36‑cp36m‑win_amd64.whl
and ran the command :
pip install numpy‑1.13.3+mkl‑cp36‑cp36m‑win_amd64.whl

basically from what i tested  there are 2 requirements that needs to be changed for windows users....

hope that helps

@kianmeng-aft that is a very useful insight. Mind creating a PR to update these two?

i tried changing it using ubuntu virtual box , but seems like the mkl thingy is only available for window.

so i guess for windows user , we will have to manually change it instead 😞

right now , i am facing another issue mention in this ticket https://github.com/RasaHQ/rasa_core/issues/23
(tested using ubuntu virtual box and its is ok)
is there by any chance some other windows user already found a fix to this?
[rasa is not windows friendly 😢 ]

I face the same issue on ubuntu 14.04, it doesn't like the numpy or sklearn installed as instructed in the nlu docs.
crossref #108

resolved, by installing tensorflow-gpu

I am facing similar issue on unix (RHEL 6.8).
Exception: Not all required packages are installed. Failed to find the following imports spacy, sklearn. To use this pipeline, you need to install the missing dependencies, e.g. by running:
> pip install spacy==1.8.2 scikit-learn==0.18.1 scipy==0.19.0 matplotlib==1.5.3
Required dependencies are already installed under  "/opt/rh/python27/root/usr/lib64/python2.7/site-packages"  but rasa core is looking under "/opt/rh/python27/root/usr/lib/python2.7/site-packages"
I started /opt/rh/python27/root/usr/bin/python in interactive mode and tried import spacy , there is no error.  Also i have been using rasa nlu for few months now and never has any issues.
/opt/rh/python27/root/usr/bin/python -m rasa_core.run -d models/dialogue -u models/nlu/model_20171117-110732/
INFO:root:Rasa process starting
Using TensorFlow backend.
2017-11-29 23:20:26.434263: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2
DEBUG:pip.utils:bz2 module is not available
DEBUG:pip.utils:lzma module is not available
DEBUG:pip.vcs:Registered VCS backend: git
DEBUG:pip.vcs:Registered VCS backend: hg
DEBUG:pip.vcs:Registered VCS backend: svn
DEBUG:pip.vcs:Registered VCS backend: bzr
Traceback (most recent call last):
File "/opt/rh/python27/root/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/opt/rh/python27/root/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/run.py", line 126, in
cmdline_args.credentials)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/run.py", line 105, in main
agent = Agent.load(model_directory, nlu_model)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/agent.py", line 55, in load
_interpreter = NaturalLanguageInterpreter.create(interpreter)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 27, in create
return RasaNLUInterpreter(model_directory=obj)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 132, in init
self._load_interpreter()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 151, in _load_interpreter
os.environ))
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/model.py", line 225, in load
skip_valdation)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/model.py", line 248, in create
components.validate_requirements(model_metadata.pipeline)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/components.py", line 92, in validate_requirements
"> pip install {}".format(" ".join(missing_requirements)))
Exception: Not all required packages are installed. Failed to find the following imports spacy, sklearn. To use this pipeline, you need to install the missing dependencies, e.g. by running:
> pip install spacy==1.8.2 scikit-learn==0.18.1 scipy==0.19.0 matplotlib==1.5.3


Add paddle backend

Category

[x] New feature
[ ] Bugfix
[ ] Breaking change
[ ] Refactoring
[x] Documentation
[ ] Other (please explain)

Description

As talked in https://github.com/NVIDIA/warp/discussions/285, we add PaddlePaddle framework as one of backends of warp.
Thanks for reply from @shi-eric(https://github.com/NVIDIA/warp/pull/313#issuecomment-2380075250), I create this PR as contained only one commit.
This PR additionally adds support for the bool type to warp’s dlpack, based on this discussion: https://github.com/dmlc/dlpack/issues/75 and the corresponding PR: https://github.com/dmlc/dlpack/pull/76. The boolean type representation seems uses 8 bits instead of the current 1 bit finally. I am not sure if there were any additional considerations regarding this in warp’s development. If there are specific explanations, please let me know. I will adjust the support for the boolean type of paddle, according to the suggestions, thanks :).
run test:
# 1. install paddlepaddle
# cu123
$ python -m pip install --pre paddlepaddle-gpu -i https://www.paddlepaddle.org.cn/packages/nightly/cu123/
# cu118
# python -m pip install --pre paddlepaddle-gpu -i https://www.paddlepaddle.org.cn/packages/nightly/cu118/

# 2. install warp
$ cd warp/
$ python build.py
$ pip install -e .

# 3. run test related to paddle framework
$ python warp/tests/test_dlpack.py -k paddle
Warp 1.3.3 initialized:
   CUDA Toolkit 11.6, Driver 12.0
   Devices:
     "cpu"      : "x86_64"
     "cuda:0"   : "Tesla V100-PCIE-16GB" (16 GiB, sm_70, mempool enabled)
   Kernel cache:
     /root/.cache/warp/1.3.3
Skipping Jax DLPack tests due to exception: No module named 'jax'
W0928 17:58:46.172823 11252 gpu_resources.cc:119] Please NOTE: device: 0, GPU Compute Capability: 7.0, Driver API Version: 12.0, Runtime API Version: 11.6
W0928 17:58:46.174096 11252 gpu_resources.cc:164] device: 0, cuDNN Version: 8.4.
Skipping Paddle DLPack tests due to exception: name 'test_dlpack_paddle_to_warp_v2' is not defined
test_dlpack_paddle_to_warp_cuda_0 (__main__.TestDLPack) ... Module __main__ cac4f71 load on device 'cuda:0' took 373.07 ms  (compiled)
ok
test_dlpack_warp_to_paddle_cuda_0 (__main__.TestDLPack) ... ok
test_dlpack_warp_to_paddle_v2_cuda_0 (__main__.TestDLPack) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.498s

OK

$ python warp/tests/test_dlpack.py -k paddle
Warp 1.3.3 initialized:
   CUDA Toolkit 11.6, Driver 12.0
   Devices:
     "cpu"      : "x86_64"
     "cuda:0"   : "Tesla V100-PCIE-16GB" (16 GiB, sm_70, mempool enabled)
   Kernel cache:
     /root/.cache/warp/1.3.3
Skipping Jax DLPack tests due to exception: No module named 'jax'
W0928 13:15:33.230201 29239 gpu_resources.cc:119] Please NOTE: device: 0, GPU Compute Capability: 7.0, Driver API Version: 12.0, Runtime API Version: 11.6
W0928 13:15:33.231549 29239 gpu_resources.cc:164] device: 0, cuDNN Version: 8.4.
test_dlpack_paddle_to_warp_cuda_0 (__main__.TestDLPack) ... Module __main__ cac4f71 load on device 'cuda:0' took 387.06 ms  (compiled)
ok
test_dlpack_paddle_to_warp_v2_cuda_0 (__main__.TestDLPack) ... ok
test_dlpack_warp_to_paddle_cuda_0 (__main__.TestDLPack) ... ok
test_dlpack_warp_to_paddle_v2_cuda_0 (__main__.TestDLPack) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.567s

OK

todolist:

[x] Add __cuda_array_interface__ in paddlepaddle(https://github.com/PaddlePaddle/Paddle/pull/68192)
[x] Merge pr for supporting zero-copy dlpack(https://github.com/PaddlePaddle/Paddle/pull/67927)

Changelog

Add specific line-by-line info of high level changes in this PR.

Before your PR is "Ready for review"

[x] Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
[x] Have you read the Contributor Guidelines?
[x] Have you written any new necessary tests?
[x] Have you added or updated any necessary documentation?
[x] Have you added any files modified by compiling Warp and building the documentation to this PR (.e.g. stubs.py, functions.rst)?
[x] Does your code pass ruff check and ruff format --check?

Did you forget to include paddle.py?

Thank you for the very nice PR! This is really well done, we are aiming to merge this with our 1.4.0 release this week.

Thank you for the very nice PR! This is really well done, we are aiming to merge this with our 1.4.0 release this week.

Thanks a lot to @mmacklin and @shi-eric for your review. Note that there seems still a link error in build-and-test / pull-request-docs CI, which might because
the reason @shi-eric mentioned(https://github.com/NVIDIA/warp/pull/318#discussion_r1779731457), I am afraid of warp's document CI will be affected by this.

Please check if https://www.paddlepaddle.org.cn/ be accessed in US, or please help to replace it with https://github.com/PaddlePaddle/Paddle

Thank you for the very nice PR! This is really well done, we are aiming to merge this with our 1.4.0 release this week.

Thanks a lot to @mmacklin and @shi-eric for your review. Note that there seems still a link error in build-and-test / pull-request-docs CI, which might because the reason @shi-eric mentioned(#318 (comment)), I am afraid of warp's document CI will be affected by this.  Please check if https://www.paddlepaddle.org.cn/ be accessed in US, or please help to replace it with https://github.com/PaddlePaddle/Paddle

Yeah, I fixed that with ab147a089c70c4f5bdf97024714b6ddef28d775d so we're all good. I did notice that when I tried to install Paddle (CUDA 12.3) and run test_paddle.py on my (multi-GPU) system, I got a bunch of CUDA-related errors. I'll let you know if I have a chance to look into it...

Thank you for the very nice PR! This is really well done, we are aiming to merge this with our 1.4.0 release this week.

Thanks a lot to @mmacklin and @shi-eric for your review. Note that there seems still a link error in build-and-test / pull-request-docs CI, which might because the reason @shi-eric mentioned(#318 (comment)), I am afraid of warp's document CI will be affected by this.  Please check if https://www.paddlepaddle.org.cn/ be accessed in US, or please help to replace it with https://github.com/PaddlePaddle/Paddle

Yeah, I fixed that with ab147a0 so we're all good. I did notice that when I tried to install Paddle (CUDA 12.3) and run test_paddle.py on my (multi-GPU) system, I got a bunch of CUDA-related errors. I'll let you know if I have a chance to look into it...

Thanks for fixing that, I found it may because not setting device_id correctly in FromDLpack of paddle
framework, so when a tensor from gpu ohter than the first device(id=0), paddle still setting the default id(0) for converted tensor(https://github.com/PaddlePaddle/Paddle/blob/e549437ad8bda6ff55ed22039eb09bafa74f78ba/paddle/fluid/framework/tensor_util.cc#L910-L911). I will verify and fix it soonly.


Very poor documentation

It would be great to add meaningful godoc comments and examples, document the ways the library can be used (how to use a different migration directory, how to register migrations from the code, etc.)

I went through the md file and i didn't figure out how to do the migration. The example doesn't work at command "go run *.go" which i actually executed as "go run main.go".
Poor documentation!

I want to help with this issue! I think a have understand the basics and simpler idea of how to explain it.

I want to help with this issue! I think a have understand the basics and simpler idea of how to explain it.

I was thinking about creating a example/tutorial like the existing one. Any suggestions where to write it and which topics to cover?

I was thinking about creating a example/tutorial like the existing one. Any suggestions where to write it and which topics to cover?

@RegisMelgaco if you ask me I would add an article to https://github.com/go-pg/docs/tree/master/docs. It will be published on https://pg.uptrace.dev/
But godoc comments or an example in this repo will be helpful too I guess :)

@RegisMelgaco if you ask me I would add an article to https://github.com/go-pg/docs/tree/master/docs. It will be published on https://pg.uptrace.dev/
But godoc comments or an example in this repo will be helpful too I guess :)

Thanks for the tips! So I will prioritize writing the article, since it would be incorporated in the docs.

Thanks for the tips! So I will prioritize writing the article, since it would be incorporated in the docs.

Any updates on that? I can also help.