mr

Not an error just a wish list asks
Just a note to say it would be amazing to have a visual designer for Xamarin cross platform apps like the Xamarin android designer and of course the amazing windows universal app designer .  I had to go to Xamarin android designer to position buttons on my android phone app.
so I have to go to the windows designer for my universal apps. would be good to have  a cross platform visual button designer.
And last wish please please please could you add a colour fill routine for canvas apps  like the old ExtFloodFill in mfc
to fill boundary of lines with a color.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d648cd73-34e8-1a47-35cc-3c5a1ff9f8f5
Version Independent ID: a02d528a-85f7-00f6-cf00-3416713ed4d9
Content: How to report a problem with Visual Studio 2017 - Visual Studio
Content Source: docs/ide/how-to-report-a-problem-with-visual-studio-2017.md
Product: visual-studio-dev15
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@steveowen It looks like you have a product feature request rather than an issue with documentation. To that end, this venue isn't the correct place for such requests. Instead, please share your product feature requests and suggestions with us on UserVoice.
As an FYI, these alternative means of contacting us are documented in the "Reporting alternatives" section of the How to report a problem page, and in the "I want to make a suggestion about Visual Studio features" section of the Talk to us page.
Thanks,
~ Terry


refactor(drift): Parallelize requests using conc

Thanks for trying this out, this is fun.

Should note that using the pool comes with some overhead.
// Pool is efficient, but not zero cost. It should not be used for very short
// tasks. Startup and teardown come with an overhead of around 1µs, and each
// task has an overhead of around 300ns.

https://github.com/sourcegraph/conc/blob/main/pool/pool.go#L27C1-L29C41
This shouldn't be an issue for something like iam drift detection - but this could be more problematic if you want to write something high performance.

Good to know, thanks for the education.


As a user, I can send feedback to the developer

... so that the app can be improved

Deferred to v2.0


Operator does not react when a new ServiceAccount is created

Describe the bug
It looks like the operator does not react when a new ServiceAccount is created after the operator has been installed.
To Reproduce
Steps to reproduce the behavior:

Create new kind cluster
Follow instructions to install registry-creds, create seed secret, and add the ClusterPullSecret CRD
create a private image on dockerhub by pulling nginx:latest, retag, and push to your private dockerhub repo
Create a new basic helm chart with helm create foobar - which creates by default a new ServiceAccount and deployment of library/nginx
Change the repository and tag in values.yaml to your new private image
Run helm install foobar ./foobar

A ServiceAccount is created in the default namespace, that the registry-creds operator does not react to and add the imagePullSecret
A deployment is created that fails with ImagePullBackoff

Delete the registry-creds pod (and let it be recreated)
foobar deployment successfully pulls, since new registry-creds pod now sees the new ServiceAccount

Full recreation:
mkdir recreate-issue

cd recreate-issue

kind create cluster

kubectl apply -f https://raw.githubusercontent.com/alexellis/registry-creds/master/manifest.yaml

kubectl create secret docker-registry registry-creds-secret --namespace registry-creds-system --docker-username=rothandrew --docker-password=[REDACTED]<EMAIL_ADDRESS>
cat <<EOF | kubectl apply -f -
apiVersion: ops.alexellis.io/v1
kind: ClusterPullSecret
metadata:
  name: docker-registry
spec:
  secretRef:
    name: registry-creds-secret
    namespace: registry-creds-system
EOF

helm create foobar

helm install foobar ./foobar --set image.repository=rothandrew/testprivate --set image.tag=test1

# foobar deployment is now in ErrImagePull with following error:
# Failed to pull image "rothandrew/testprivate:test1": rpc error: code = Unknown desc = failed to pull and unpack image "docker.io/rothandrew/testprivate:test1": failed to resolve reference "docker.io/rothandrew/testprivate:test1": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

kubectl get pods -n registry-creds-system --no-headers=true | awk '/registry-creds-registry-creds-controller/{print $1}' | xargs kubectl delete -n registry-creds-system pod

# foobar pod will now get pulled successfully the next time k8s tries.

Expected behavior
The operator notices when new service accounts are created and adds the ImagePullSecret to them
Screenshots or console output
N/A
Operating system and version:
MacOS Mojave 10.14.6
List all possible solutions, and your suggested option
Not sure. I'm not familiar with this operator's functionality enough to make any educated guesses.
Additional context
none

@RothAndrew whilst I appreciate the instructions, these need to be steps we can actually run (which they are not). Hopefully it won't take you long to do that and create a little repo.
Please also see the full report and all the fields required.
https://raw.githubusercontent.com/alexellis/registry-creds/master/.github/ISSUE_TEMPLATE/bug_report.md

@alexellis I will update the issue to meet your criteria

All we should need is you to install the chart.
Then create a ServiceAccount in a namespace. That is what you're saying causes an issue right? What's the need for helm and all other other manual steps?

@developer-guy did you want to try out the scenario above? From what I read in the code the operator should handle this use-case already.

Just coming up with a full recreation of what I experienced. I'm sure there are lots of different ways this can be tested.
I'm working on coming up with a list of actual commands you can run

Full list of commands to recreate are added. I will add the other required items now

@alexellis Issue description should now fully comply

Thank you @RothAndrew for the explanatory description, I'll investigate this issue soon .

More context: cloning the repo and running make install && make run does not exhibit the behavior I detailed above. It looks to be working correctly.

Bumping the tag of ghcr.io/alexellis/registry-creds on line 232 of manifest.yaml to 0.2.6 fixes the issue for me. I'd be happy to submit the one line change as a PR if you'd like.

/cc @developer-guy @alexellis

Bumping the tag of ghcr.io/alexellis/registry-creds on line 232 of manifest.yaml to 0.2.6 fixes the issue for me. I'd be happy to submit the one line change as a PR if you'd like.

Yeah, I think that's true,  it fixes this issue for me too, I think the tag 0.25.0 does not include the feature that watch service account creation. 🤔

/lock: inactive, raise your own issue as a GitHub Sponsor


functionality Save to Archive

How do I implement the  functionality Save to Archive,  I am using the meteor version 1.x and would like to implement the save to archive. I can see it has been implemented as seen in the image below but the version i am currently running does not have this functionality. Can someone help me with this and exactly what packages to upgrade.

There is no easy way to upgrade from v1 to v2. For most, it will be a matter of adopting v2 entirely, and then porting any "secret sauce" you added for your v1 fork to work for/with version 2's extensions.
"Save to Archive" is not currently supported, but we would be willing to review and merge PRs that add support. A solution would likely need to use DICOMWeb's STOW-RS to send DICOM Structured Reports back.
Depending on your needs, we could add the "Save to Archive" button, and provide a hook that receives application data when pressed, and you can then persist it with your mechanism of choice. This would also be possible with a custom Panel Extension.
Related:

https://github.com/OHIF/Viewers/issues/68
https://github.com/OHIF/Viewers/issues/591
https://github.com/OHIF/Viewers/issues/729

Thanks, @dannyrb was this implemented in version 1 meteor? if yes where can I find it?

I actually joined the project right around the time v1 was deprecated, so I'm not positive. I "think" this is where the logic lives:
https://github.com/OHIF/Viewers/blob/v1.x/Packages/ohif-measurement-table/client/configuration/dataExchange.js#L15-L30
Note: This same repository and in the v1.x branch

Hi guys,
congratulations for the work done so far with v2, this is already an amazing piece of software.
I have a question regarding the "Save to Archive" functionality.
I've been doing some work to try to migrate some of the SR ROI functionality from v1 to v2.
I've had some success with the Length annotations (I'm able to save the SR to Orthanc), even if there are still some details that need fixing. I've tried to do the same with the Polyline annotations, that I previously added to the viewer.
I filled up the getTID300RepresentationArguments(tool) function inside dcmjs/src/adapters/Cornerstone/FreehandMouse.js in the following way:
' static getTID300RepresentationArguments(tool) {
    const points = tool.handles.points;
    const lengths = [];

    return {
        points,
        lengths
    };
}

I've tried to provide the data according to the format described in dcmjs/src/utilities/TID300/Polyline.js.
The SR generation processed called through MeasurementReport.generateReport() makes some progress, but at some point stops with the following error, before being able to save the report to Orthanc:
Error: There are undefined values at the array naturalValue in DicomMetaDictionary.denaturalizeValue
Do you have some idea of what might be the problem here?
Thanks again

CC: @JamesAPetts
@gmer16, do you have any additional code you can share to assist? This should probably be a separate issue unless you're trying to port and contribute the Save To Archive feature wholesale.
James has the most experience with dcmjs, so I've tagged him to see if he has any immediate thoughts.

Thanks @dannyrb, I fixed that issue making the following changes to  dcmjs/src/utilities/TID300/Polyline.js
`
function expandPoints(points) {
const allPoints = [];

points.forEach(point => {
    allPoints.push(point.x);
    allPoints.push(point.y);
});
return allPoints;

}
`
Now the report is saved to Orthanc.

@gmer16 is that a fix that should be pushed into dcmjs?  Would you provide a PR?

CC: @galelis


Init

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b10520). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #1   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         3
  Lines             ?        16
  Branches          ?         1
==========================================
  Hits              ?        16
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b10520...763d383. Read the comment docs.


Migrate examples

Description
Migrate examples to scalar-terraform-examples

Sorry, but I added a new example in #255, so it will be needed to be migrated too after that PR is merged.

Or I might be able to update #255 to move the new example to the scalar-terraform-examples repo after this PR is merged.


vSphere prerelease e2e testing

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Documentation:

/test pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.27.11

/test pull-kubeone-e2e-vsphere-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7

/test pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.27.11

/test pull-kubeone-e2e-vsphere-default-install-containerd-external-v1.27.11


[Proposal] Add table prefix option to config/database.js

As far as I can see there is no option to provide a table prefix for creating tables with migrations.
Would be great if we could add an option to config/database.js to include this:
./config/database.js
...
  mysql: {
    client: 'mysql',
    connection: {
      host: Env.get('DB_HOST', 'localhost'),
      user: Env.get('DB_USER', 'root'),
      password: Env.get('DB_PASSWORD', ''),
      database: Env.get('DB_DATABASE', 'adonis'),
      tablePrefix: Env.get('DB_TABLE_PREFIX', 'ad_')
    }
  },

./.env.example
...
DB_CONNECTION=sqlite
DB_HOST=<IP_ADDRESS>
DB_USER=root
DB_PASSWORD=
DB_DATABASE=adonis
DB_TABLE_PREFIX=ad_

Will add it in new release

@thetutlage which date new version maybe released?

Issue moved to adonisjs/adonis-lucid #58 via ZenHub


Failed to retrieve/set file extension when upload file as blob

What I upload:
------WebKitFormBoundaryi8ZhzSYa1jK76hJC
Content-Disposition: form-data; name="tags"

56a1f2c06dfc44c4570a46cb,56a1f2c06dfc44c4570a46cc
------WebKitFormBoundaryi8ZhzSYa1jK76hJC
Content-Disposition: form-data; name="headImg"; filename="blob"
Content-Type: image/jpeg

------WebKitFormBoundaryi8ZhzSYa1jK76hJC--

The problem is that when handle File and ouput a Blob instance, and then upload this blob, the filename's extension will lost (client only sent filename="blob").
So the IncomingForm.prototype._fileName will return "blob" as the file.name.
And IncomingForm.prototype._uploadPath will generate path without extension (although this.keepExtensions is true) and all saved files lost their extension.
I'm not sure it's a better way to retrieve and add extension from Content-Type: image/jpeg, or just leave it with no extension.

I'm using chrome (v52) and does not see such effect.
case:
let file = input.files[0];

let data = new FormData();
data.append('photo', photo);

fetch(`url`, {
    method: 'POST',
    body: data
});

request:
------WebKitFormBoundary76WmHIDQOjBC1dKX
Content-Disposition: form-data; name="photo"; filename="___.jpg"
Content-Type: image/jpeg

File name is in place.

Um, It's chrome v46/v48 (v40+, not v50+) when I report this issue.
Maybe things changed when chrome updated.

@creeperyang can you try it and report back when you can?

cause this issue, because the third argument does not set
formdata.append('blobdata', blob, filename);

This looks like to be a client side issue


fix: [#6752] The ShowTypingMiddleware throws System.ObjectDisposedException when an exception occurs in the bot

#minor
Fixes # 6752
Description
This PR fixes the Dispose error avoiding the dispose of faulted tasks.
Specific Changes

Added if condition to dispose tasks that are not faulted.

Testing
The following image shows the bot responding correctly to other requests after an error has occurred.

Pull Request Test Coverage Report for Build 387573
Details

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 78.194%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/LRUCache.cs
4
87.18%

Totals

Change from base Build 386500:
-0.01%

Covered Lines:
26181

Relevant Lines:
33482

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll


Why does not the stage 3 implementation use broadcast and reduce-scatter?

Hi there,
(Thanks for sharing your implementations!)
After reading the paper, and partially going throught the stage3.py implementation.
I have two questions in general:

is there any specific reason for picking all-gather instead of broadcast operation, which is mentioned in the paper.
by profiling the stage-3, using Nsight System, I didn't see any nccl reduce-scatter kernel on the timeline. As shown in the following. While, I do see the nccl-all-reduce kernel on the timeline, does that mean the ZeRO3 implementation using all-reduce for gradient reduction?

@zarzen Thank you for trying out ZeRO-3.

The communication collectives in the ZeRO-3 implementation is slightly different from what is described in the ZeRO paper. We  are using all-gather instead of broadcast as you noticed. The reason for doing so is to effectively support offloading to CPU and NVMe. In the absence of offloading, both all-gather and broadcast would result in similar communication volume, but with offloading, all-gather supports a data partitioning scheme that enables better offload bandwidth utilization. For details, please take a look at Sec 6.1 in our ZeRO-Infinity paper : https://arxiv.org/pdf/2104.07857.pdf

ZeRO3 does use reduce-scatter for the gradients. It is strange that its not showing up in the profiler. Perhaps reduce-scatter is turned off in the config. You can trace the code path leading to the reduce scatter call from

params_to_reduce[0].reduce_gradients_at_owner(                 param_list=params_to_reduce,                 hierarchy=self.param_coordinator.hierarchy)
in stage3.py to the _reduce_scatter_gradient call in partition_parameters.py
Can you let us know if your execution is taking this code path? If not, please share how we can repro.

@samyam
I found that the config must have "contiguous_gradients": true to enable reduce_scatter.
Using "reduce_scatter": true, does not enable reduce_scatter.
here is a condition check for invoking average_tensor: https://github.com/microsoft/DeepSpeed/blob/b3870363e026717752c119b21870e2886b9ad92d/deepspeed/runtime/zero/stage3.py#L2175
I am confused about this condition check, as the document for "contiguous_gradients" is related to memory fragmentation.

@zarzen ZeRO-3 should be run with contiguous gradients set to True. Just pushed a PR that makes contiguous gradients True by default for all cases. Originally when we added support for contiguous gradients there was a performance bug that showed up on small model sizes so we set to False by default but that bug has been fixed for a while now so there is no reason to not run with contiguous gradients set to True.
We always assumed that contiguous_gradients will be set to True for stage 3 and so only implemented the reduce_scatter under it. We should probably just deprecate the contiguous_gradients flags in stage 3 and just always have it on as there are no downsides to it.


<EMAIL_ADDRESS>download failed

Installing LanguageTool (without aria2) is returning the following error:
The remote server returned an error: (403) Forbidden.
URL https://languagetool.org/download/LanguageTool-5.4.zip is not valid

Installing it with aria2 also does not work and returns:
ERROR Download failed! (Error 22) HTTP response header was bad or unexpected
ERROR https://languagetool.org/download/LanguageTool-5.4.zip
    referer=https://languagetool.org/download/
    dir=C:\path\bin\scoop\cache
    out=languagetool#5.4#https_languagetool.org_download_LanguageTool-5.4.zip

It is working now. Closing the ticket.


[WIP] Test optimization flags for benchmarks

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.77%. Comparing base (d99a69e) to head (020ce43).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   72.71%   72.77%   +0.06%
==========================================
  Files         241      241
  Lines       34427    34427
==========================================
+ Hits        25033    25054      +21
+ Misses       9394     9373      -21

Components
Coverage Δ

crashtracker
20.66% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
90.12% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
82.11% <ø> (ø)

ddcommon-ffi
68.11% <ø> (ø)

ddtelemetry
59.02% <ø> (ø)

ipc
84.00% <ø> (ø)

profiling
84.26% <ø> (ø)

profiling-ffi
77.42% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
40.23% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.18% <ø> (ø)

trace-mini-agent
70.88% <ø> (ø)

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.00% <ø> (ø)


Documentation: Add an article explaining how to get the Android context

When developer need to work with native API directly they often need the context in different phases of the application. Please create an article which describes how the Android context can be obtained and used.

I have opened a similar NativeScript/NativeScript#458 issue in the NativeScript repo since this is modules related. At Runtime level the situation is the same as with the Native Context access.


Misunderstanding <<:

I have this code:
restic:
  <<: *image

When I save with this extension enabled it does this:
restic:
  !!merge <<: *image

is there a way to disable this ?

I've taken it upon myself to improve this extension since it hasn't had an update in quite a while.
The feature that you're requesting is available in the base yamlfmt and added as an option here:
https://github.com/kiliantyler/kubernetes-yaml-formatter-x?tab=readme-ov-file#extension-settings
kubernetes-yaml-formatter-x.dropMergeTags

thankyou! Works like a treat.

The v2 version has been released on VSCode and fix this issue.
Give it a try!


[JDK21+] Re-enable ThreadStateTest and CarrierThreadWaits

CarrierThreadWaits: eclipse-openj9/openj9#18051
ThreadStateTest: eclipse-openj9/openj9#18054
eclipse-openj9/openj9#18051 is fixed by eclipse-openj9/openj9#18167.
eclipse-openj9/openj9#18054 is fixed by eclipse-openj9/openj9#18166.
Closes: eclipse-openj9/openj9#18051
Closes: eclipse-openj9/openj9#18054

@llxia @LongyuZhang Requesting your review.


Doesn't normalize urls

So:
hostname: 'http://website.com' with url: 'page.html' => http://website.compage.html
hostname: 'http://website.com/' with url: '/page.html' => http://website.com//page.html
I'd expect this module to remove and add slashes where necessary.

If you use a package like https://www.npmjs.com/package/url-join to join the different parts here this problem would be solved.

Hi @ismay
Thanks for report.

:+1:


[c++ grpc] Fix two server-side crashes

Two server-side crashes were revealed by the compatibility testing:

sometimes, when the server was being shutdown, in-flight RPC calls couldn't send back responses
the state of a unary_call was sometimes being deleted before the unary_call instance was itself destroyed

There are two separate commits here, but both are needed to fix the server-side crashes, hence one PR.
Please rebase -i and fixup when merging to maintain the commits.

Merged in commit f6c065cf.


[Bug-14378][Master] Trigger task execution in workflow instance page cause workflow instance keep running status

Purpose of the pull request

This PR closes https://github.com/apache/dolphinscheduler/issues/14378

Brief change log

The parameter of dag.containsNode is taskCode, rather taskInstanceId.

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14389 (1ab1d6a) into dev (5cbe170) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

:exclamation: Current head 1ab1d6a differs from pull request most recent head aff434c. Consider uploading reports for the commit aff434c to get more accurate results

@@             Coverage Diff              @@
##                dev   #14389      +/-   ##
============================================
- Coverage     38.51%   38.46%   -0.06%
+ Complexity     4566     4555      -11
============================================
  Files          1237     1237
  Lines         43541    43462      -79
  Branches       4813     4795      -18
============================================
- Hits          16771    16717      -54
+ Misses        24914    24893      -21
+ Partials       1856     1852       -4

Impacted Files
Coverage Δ

.../server/master/runner/WorkflowExecuteRunnable.java
10.68% <100.00%> (+0.05%)
:arrow_up:

... and 64 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Exclude SharedTokenCacheCredential by default

Fixes #96, by excluding SharedTokenCacheCredential by default.

/azp run

/azp run


fix example comments

Coverage remained the same at 98.273% when pulling 588494130d6f9443804057d728ce3f0712b71e04 on dwsupplee:example-fix-2 into 8ecdaef486318e304c8b8ebccf4ea365ddecd93d on GoogleCloudPlatform:master.

@jdpedrie PTAL

Coverage decreased (-0.3%) to 97.961% when pulling 3cec60972a56658c645d4bfb44738e97e6e2475f on dwsupplee:example-fix-2 into 8ecdaef486318e304c8b8ebccf4ea365ddecd93d on GoogleCloudPlatform:master.

Looks good. We might want to automatically inject that into the top of pages on the docs site later on so it doesn't get neglected.

Maybe, I still want to make sure we have room for examples using keyFiles or other authentication methods.


Rebaseline performance tests

I've triggered a build for you. Click here to see all failures if there's any.


yaml and json formats in "lxc list" ignore filtering

Required information

Distribution: Debian

Distribution version: bullseye
lxc_info_out.txt

Kernel version:5.10.0-18
LXC version:  5.0.1-1 (as installed from deb in repo https://apt.calenhad.com/debian )
LXD version: 5.0.1-2
Storage backend in use: LVM

Issue description
The lxc list can accept a filter based on container configuration. That filter works usually fine but if the output format is either yaml or json it seems that the filtering is ignored.
Here is an example from one server:
lxc list  image.jenkins.node=true
+-----------------------------+---------+----------------------+-----------------------------------------------+-----------+-----------+
|            NAME             |  STATE  |         IPV4         |                     IPV6                      |   TYPE    | SNAPSHOTS |
+-----------------------------+---------+----------------------+-----------------------------------------------+-----------+-----------+
| cifedora36-amd64-x07   | RUNNING | x.x.x.x (eth0)  | x:x:x:x (eth0) | CONTAINER | 0         |
+-----------------------------+---------+----------------------+-----------------------------------------------+-----------+-----------+
| ciubuntu2204-amd64-x07 | RUNNING | x.x.x.x. (eth0) | x:x:x:x | CONTAINER | 0         |
+-----------------------------+---------+----------------------+-----------------------------------------------+-----------+-----------+
lxc list  image.jenkins.node=true -f yaml | grep "^  name:"
name: cifedora36-amd64-x07
name: ciubuntu2204-amd64-x07
name: debian11-test
name: f36-test
name: fedora36-amd64-dev07
As you see there are in this case 5 containers listed, rather than the two that are matched only with the filter. This seems to be a regression, since in older versions (I have checked 3.0.3 and 4.0.7) this was working properly.

See #10396

Thanks,
sorry, I didn't see the duplicate.


Add safeTxGas parameter on TxModal for Safe App tx

What it solves
Resolves #4036
How this PR fixes it
Pass safeTxGas parameter to TxModalWrapper and parse from number to string if exists
How to test it
This Safe App only available for Gnosis Chain, tries to set safeTxGas to 0. Parameter is currently ignored in prod.
After the change we set the suggested safeTxGas and we still calculate for those Safe Apps that don't suggest any value
More context directly in #4036 ticket

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.608%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4586

Relevant Lines:
10130

💛  - Coveralls

Tested in a couple of safes, the shared one in the original ticket and another circles safe of which I am the owner and can confirm that safeTxGas is coming as 0 now, mucho bueno:


moveit_kinematics remove COLCON_IGNORE

/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp: In member function ‘void kdl_kinematics_plugin::KDLKinematicsPlugin::getJointWeights()’:
/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp:86:19: error: ‘node_’ was not declared in this scope
   if (lookupParam(node_, "joint_weights/weights", weights, weights))
                   ^~~~~
/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp:86:19: note: suggested alternative: ‘mode_t’
   if (lookupParam(node_, "joint_weights/weights", weights, weights))
                   ^~~~~
                   mode_t
/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp: In member function ‘virtual bool kdl_kinematics_plugin::KDLKinematicsPlugin::initialize(const moveit::core::RobotModel&, const string&, const string&, const std::vector<std::__cxx11::basic_string<char> >&, double)’:
/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp:199:15: error: ‘node_’ was not declared in this scope
   lookupParam(node_, "max_solver_iterations", max_solver_iterations_, 500);
               ^~~~~
/root/moveit2/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp:199:15: note: suggested alternative: ‘mode_t’
   lookupParam(node_, "max_solver_iterations", max_solver_iterations_, 500);
               ^~~~~
               mode_t
make[2]: *** [kdl_kinematics_plugin/CMakeFiles/moveit_kdl_kinematics_plugin.dir/src/kdl_kinematics_plugin.cpp.o] Error 1
make[1]: *** [kdl_kinematics_plugin/CMakeFiles/moveit_kdl_kinematics_plugin.dir/all] Error 2
make: *** [all] Error 2

DO NOT MERGE! Just checking CI


Integration with AAD

Type of issue

[ ] Bug
[x] New feature
[ ] Enhancement

Description
Add option to require authentication and to forward the user to AAD login page. The auth flow should start only when the remote endpoint(s) require auth.

Not needed anymore, Auth managed by UI and microservices


Use of Update button when filtering clears previously selected filters

When using 'Refine your search' options it does not seem possible to combine more than one filter at a time. To reproduce:
Go to https://library.marjon.ac.uk/cgi-bin/koha/opac-main.pl
Switch to Discovery and search for 'Stonehenge'
Filter to: Limit to = Full text
When results appear add another filter for Source type = Academic Journals
The floating 'Update' button will appear, click to update
Filtered results display but the previous Limit to = Full text filter has been unticked.
Plugin version is 22.11001, Koha version 22.11.12

Thanks for reporting this.  We're looking into it.

Addressed issue in #137 - thank you for reporting this issue.


Enhancing the icons.

In some cases it is providing not effective result as we want. https://huggingface.co/sd-concepts-library/small-iconss

link


CB-9059 removed targetingWin10 logic from prepare

Removes isTargetingWin10 logic and fails silently in case system does not have UAP tools installed.

LGTM


capture events

Probe.capture(event, listener);
Probe.captureOnce(event, listener);
Probe.removeCaptureListeners(event, listener);
Probe.removeAllCaptureListeners(event);

cant remember why i suggested this. closing for now.


fix: add workflow outputs to scope for arguments

Fixes #11610
Modifications
Added workflow global outputs to scope for arguments
Verification
Tested locally

@rohankmr414 shall I'll take over this PR

☂


Maxiter does not except scientific e notation

I have just started using GalacticOptim and have to say it's a great package. I wanted to give a quick feedback.
The maxiter kwarg for the solve function behaves sliglty inconsitent when defining iterations by 1e5. When using BBO() it runs fine but fails when creating the object to return and when using Optim.jl optimisers it fails due a Float64 warning.
Not sure if you want the interface to accept e notation (personally I think it would be good idea) but it should be consitent.

This is because Optim allows only Int64 type for the maxiters, so you can pass in Int(1e5) instead and it should work

I expected that to be the issue. I thought it might a good idea to handle this internally in GalacticOptim so you don't get the BBO() where the optimisation runs fine because BlackboxOptim internally converts to Int but returning the results fails due the Optim object used. I can make a PR if you want with a fix. It will be my first one so bare with.

Yeah this could auto-convert.

I have made a pull request with my suggestions, I hope that is okay. I am not familiar what the etiquette is with PR. I can retract it if it doesn't fit with the package design. #64

Thanks!


Submit a repodata patch to add libpython to 2.7.4_1

Comment:
libpython is indeed a direct dependency and should be included after all. (It was omitted from build 1)
To avoid problems down the line, submit a patch here: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock
References:

libpython is a direct dependency
We are readding it in build 2 in https://github.com/conda-forge/aesara-feedstock/pull/88

Pending confirmation of the version pin, this is ready to go in https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/290


Nice enduser fixes

Just some additions I notice as a go along :smiley:

this commit 48524de is pretty cool!
it adds cov_thresholds as an option that you can specify in the config and will autofill the command line option ^^


chore: unpack *.dll on electron-create-asar.sh

This change is needed to make electron-create-asar.sh output valid
asar packages on Windows (Msys).
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

I'd change the title to something like "chore: don't include *.dll files inside the asar archive" ?
IMHO "upack *.dll" makes it sound like you're (somehow) extracting the contents of .dll files ;-)

@lurch Makes sense. I chose "unpack" to be consistent with the asar command line tool option, but I agree it might not make much sense to someone not familiar with it.


Remove pagination get param from links pointing to page 1 within pagination

On page 2 of a paginated list the "previous" and "1" pagination link point to /?start=0 as the first page in the pagination series. Both / and /?start=0 will return the same page and therefore its preferable to point to the non param version for duplicate content reasons. A page when first visited will use the non param version / of the URL. Its only when we start navigation through pagination and are on page 2 that there is a link back to /?start=0. Search engines will navigate the site the same as users can and will crawl this this URL (/?start=0) and index it alongside the main URL (/) causing a duplicate page.

closing due to inactivity for 1.5 years. I'd put the time in to get it over the line but I see this as non-essential improvement.

@Andrew-Mc-Cormack feel free to reopen if you would like to get this over the line :)


[Bug] Showing blank screen after updating to 0.0.14

Describe the Bug
I've updated Linux Discord to Stable 0.0.14 and it shows a semi empty screen with a button which takes me to the Discord download website. I've tried reinstalling Discord, reinstalling betterdiscordcli, deleting Discord config folder, but nothing.
My OS is Arch Linux 5.11.8-arch1-1
To Reproduce
Update Linux Discord to 0.0.14
Expected Behavior
Discord should start normally
Screenshots

Discord Version
Stable 0.0.14

Duplicate of #589

Downgrading to 0.0.13 and setting the version in /opt/discord/resources/build_info.json to 0.0.14 fixed it


[Azure.Monitor.Query] Update TROUBLESHOOTING.md

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


chore: remove support for older Node versions than LTS 12

Description
Drop official support for node@8 and node@10. Will leave the builds and testing for now as an indicator to when we are actually starting to break for those versions.
Type of change
Please delete options that are not relevant.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Internal change (a change which is not visible to the package consumers)
[x] Documentation change or requires a documentation update

Checklist:

[x] Documentation has been updated
[ ] Change file has been generated (npm run change:new)
[ ] Delete this branch (after the PR is merged)

Codecov Report

Merging #482 (e15db33) into main (499f54f) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e15db33 differs from pull request most recent head fa63c02. Consider uploading reports for the commit fa63c02 to get more accurate results

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   77.94%   77.94%
=======================================
  Files          25       25
  Lines         730      730
  Branches      169      169
=======================================
  Hits          569      569
  Misses        161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499f54f...fa63c02. Read the comment docs.


config model path

Hi, thank you for sharing your work !
Could you please tell us which paths / arguments exactly should we input the .config fiels ?
Thanks

Hi, thank you for sharing your work !
Could you please tell us which paths / arguments exactly should we input the .config fiels ?
Thanks
config.zip
Mind that you have to manually download realisticVisionV13_v13_cvt, convert to safetensors and add your own path in depth_based_inpaint_template.yaml. Other models will be downloaded.

Config file has been updated. Thank you for your attention.


Shift click compass to view south (or any direction)

Is your feature request related to a problem? Please describe.
The compass when you click it, it will point to the north, and when you right-click it has all the options for other directions. East/West is whatever but the south is most important so you can do an instant 180 camera turn easily.
Describe the solution you'd like
Add a toggle or something so you can shift-click the compass to make it point to the south (or configurable direction, east/west don't really matter tbh, south is the most useful)
Describe alternatives you've considered
An alternative feature could be to do a 180 camera turn from the direction you are currently facing when doing a shift-click on the compass, this would be the most ideal solution but IDK if that's possible hence why I suggested the above. So in this ideal situation let's say I was running while facing southwest and then I shift-click compass to make it face northeast instantly, will be real nice at certain pvm situations and just a QoL improvement IMO for general usage.
Additional context
Add any other context or screenshots about the feature request here.

This is the compass in case I didn't make it clear^, Make is so when you click this while holding shift, it auto turns 180 degrees or to a configurable direction.
Thank you :)

Essentially a duplicate of #10731


Adding option directory publish

Hi
I have a two directory charts and hosting, the charts store helm template and hosting store chart publish, bellow my command line
$ cd hosting
$ helm package ../private/<chart-name>
helm repo index . --merge index.yaml

Do we have a option to support directory publish

I have fix it https://github.com/stefanprodan/helm-gh-pages/pull/2


riscv/ESP32C3: Use the common exception handler

Summary
ESP32-C3 was using a separate exception handler that does the same as the code we have in riscv_expcetion_common.S
Impact
ESP32-C3
Testing
ESP32-C3 defconfigs all built and run successfully.

BTW, I'd also like to use riscv_vectors.S and remove esp32c3_vectors.S if there is a way to do the rept(32) without an ugly ifdef.
@pussuw there is a very small change to riscv_exception_common if you want to take a look.  I notice howver that the option IRQ_NSTACKS is only defined in MPFS Kconfig file.  This should probably go to arch/Kconfig.

MacOS builds complaining about ARCH_CPU_COUNT, this also will be fixed with #5985.

MacOS builds complaining about ARCH_CPU_COUNT, this also will be fixed with #5985.

 Needs ASSEMBLY guards..

By moving the EXCEPTION_SECTION to chip.h, this one will break the build if merged.  It will need @pussuw fix for BL602.

By moving the EXCEPTION_SECTION to chip.h, this one will break the build if merged. It will need @pussuw fix for BL602.

Look like BL602's chip.h include some header files which isn't compatible with assemble code:
https://github.com/apache/incubator-nuttx/blob/master/arch/risc-v/src/bl602/chip.h#L28-L33
Let's remove them?

Needs __ASSEMBLY__ guards..

@pussuw has already fixed that.  It just required some ASSEMBLY guards.

Should we add that change into this PR? since @pussuw 's patch can't pass the CI yet.

Should we add that change into this PR? since @pussuw 's patch can't pass the CI yet.

I can add parts of @pussuw commit in here.


Enhance PCPCombine wrapper to supply additional options for field info

Currently the [FCST/OBS]_PCP_COMBINE_INPUT_OPTIONS values are only read in derive mode. If these are provided, they should be added to other modes, such as -add. This functionality can be tested with Ying Lin's (NOAA EMC) use case using UKMO data.

This functionality has been implemented and demonstrated in 2 use cases
Using PCPCombine - met_tool_wrapper/PCPCombine/pcp_loop_custom.conf
Using SeriesAnalysis - model_applications/s2s/GridStat_fcstNMME_obsCPC_seasonal_forecast.conf
The METplus config
_CUSTOM_LOOP_LIST can be set to apply the custom string looping to the given MET tool. It has only been tested using PCPCombine and SeriesAnalysis, but in theory it should work for the rest of the wrappers as well (except for tools that it is not necessary to implement, like PB2NC and ASCII2NC). All of the other wrappers run as they did before if you don't supply a custom loop list, which just sets the custom string to an empty string and passes it into the wrappers via the time_info dictionary.
The custom string can be referenced using filename template syntax: {custom?fmt=%s}
Still need to update documentation to:

Include variables in glossary and Python Wrappers section
Add section to describe how the functionality works

This has been implemented and added to the develop branch. The OPTIONS can also support reading valid time {valid?fmt=%Y%m%d%H}


Update links in README.md

Use markdown link tags. It's more neat and now we can click on it on npm page.

Thanks but I think the bare URLs read cleaner.

Ok, but then why not jut wrap the URLs in markdown tag [URL](URL)?

Because Github renders that for us automatically. See the main project page.

I know, but what if its not interprested by GitHub? Check the npm page https://www.npmjs.com/package/underscore


Drop datetime.utcnow()

datetime.utcnow() was deprecated since Python 3.12.
Python recommends using datetime.now(timezone.utc) instead.
TODO:

[x] Replace datetune.utcnow() with datetime.now(timezone.utc)
[x] changelog

Resolved in #111


Logic apps that are triggered by 'Incident Creation' at times get stuck - and do not execute on trigger

Describe the bug
Rarely but it occurs regularly the consumption logic app that has the following trigger:

{
  "type": "ApiConnectionWebhook",
  "inputs": {
    "host": {
      "connection": {
        "referenceName": "azuresentinel"
      }
    },
    "body": {
      "callback_url": "@{listCallbackUrl()}"
    },
    "path": "/incident-creation"
  }
}

Get's 'stuck' and no longer triggers. The only way to solve this issue is to disable/enable the logic app.
This can cause a lot of damage in case a logic app which is supposed to send an escalation, and does not do so. There is no information that would imply that the trigger had been made and failed, so no alerting is possible - this is a critical issue that we've had for quite some time but hadn't been reported yet.

There are a lot of missed triggers, and only after it had been restarted it started picking up new ones (note the date differences between actions, I've restarted it on 07.03 - and that's where you see it start to pick up the slack again)
This seems to be an issue with logic apps consumption themselves, so not sure if this is the valid place to raise this. But it should raise awareness of this critical issue.
To Reproduce
Steps to reproduce the behavior:

Have a long standing recurring logic app that does 'something'
After a few months of working fine it gets 'stuck'
It no longer fires triggers
Restart the logic app and it starts working again

Expected behavior
A logic app that has an event trigger should not get stuck :)
Screenshots
See above
Additional context
This is not a one time issue, this has been happening over the past year multiple times, causing SLA breaches and missed critical incidents. We can't afford to have this be ignored.

Hi @Kaloszer , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 13Mar24. Thanks!

Hi @Kaloszer ,still need some more time for detailed analysis ,will get back to you.

Hi @Kaloszer ,tried to replicate the generic issue,but unable to have that much long running or Can you please share the logic app details ,so will try to set up and replicate from my end

@v-muuppugund You would need to be running this for months to eventually hit that issue. A week is is nothing for this issue.
It happens for pretty much every PB that has that particular trigger eventually so it doesn't matter what you have after it, even if it is a print text command. It is however critical as it causes logic apps that would otherwise execute not do anything at all. And there's trigger failure either - ergo can't alert anyone to restart the PB - because well, nothing is seemingly wrong with it.

@Kaloszer , sure ,Will check there is an existing similar issue from logic apps,will check and upate you.

If you relay in one of the blocks on System Alert ARM/ID, f.e using it in logic app in KQL query it is known issue that when incident is created it takes up to 2min to fully "connect" Incident to Alerts which results of errors. Would be more clear if you provide your logic app blocks. Workarround for this is after Incident trigger put a delay 2min..

Hi @Kaloszer / @bisskar , I am unable to replicate the issue from my end, if you have log details or traces,please share with me,else will reach team on this issue they will check from backend.

@v-muuppugund What traces? What logs? I'm sorry but I don't think this is something I can get as I'm not a MSFT employee -> the issue isn't about the logic app itself but about the trigger. As I mentioned in my earlier comment:

Because this is 'untraceable' on as to when it starts not to work - unless you have a trigger every second ;) - this easily breaches the consumption logic app SLA ( 99.9% iirc ) because unless a user does something about it - it stops working indefinitely. For our example the logic app did not work until we had restarted it manually for OVER 8 DAYS - which means that the SLA was breached and if this was the only occurence this year it would stand at: 97.7915 %.

We do not have a way to tell that it stops working, we do not get any errors - either in the trigger part of the portal, nor was there any outage reported.

@Kaloszer, please let us know your response. Thanks!

@Kaloszer ,As we are unable to replicate the issue ,we request you raise the support case in Azure portal, so we are closing this issue.

@v-muuppugund @v-sudkharat
Not an acceptable solution, re-open. Again this is a big issue, it breaches the services' SLA.

@v-muuppugund @v-sudkharat
Not an acceptable solution, re-open. Again this is a big issue, it breaches the services' SLA.

@Kaloszer , Sure,reopened the issue

Hi @Kaloszer ,As discussed on Monday, will be raising ICM for this issue and will post updates over an email ,as per our standard operating procedures. If you still need support for this issue(https://github.com/Azure/Azure-Sentinel/issues/10106), feel free to re-open at any time. Thank you for your co-operation!

@v-muuppugund Before closing the issue, provide a tracking Id.

@v-muuppugund Before closing the issue, provide a tracking Id.

Sure @Kaloszer ,We need to raise a internal support case,so team will pick up had a discussion with CSS team

@Kaloszer we are seeing a very similar issue I think there is some kind of capacity problem in at the very lease North Central US region. This article is very helpful Monitor the health of your Microsoft Sentinel automation rules and playbooks | Microsoft Learn. Once you have it configured you can query the Sentinel Health logs and see playbooks failing event get kicked off.
Here is an example of what we are seeing

@JonnyG365 - in my case the runs that should've occurred do not even show up in that, as if that trigger never fired :(. So it would seem that the Automation Rule was somehow bound to the Logic App's state - and because it had hung, it never fired. Note that when the logic app was restarted, one of the missing triggers had fired, albeit it doesn't show as Fired but as null

@Kaloszer oh good so I've found another problem :)

@Kaloszer ,As we are unable to raise ICM independently, so reached CSS team and they suggested support case from azure subscription, so they can assist you.

shared response in comment -https://github.com/Azure/Azure-Sentinel/issues/10107#issuecomment-2074880736


Login page not shown

I Have installed  Panasonic Comfort Cloud integration using HACS. on a Rasp Pi4 running Home Assistant.
I cant find the login to Comfort Cloud.
In the box under HACS with the  Panasonic Comfort Cloud, in the right lower corner there is 3 dots. Is this where the login is ? I only have "Information,update information ...."
Best regards Claus

Here a screen shot.

@claus-lind After you installed the components through HACS you need to go to Home Assistant Configuration - Integrations add/activate it there.

Super, thanks I found it .. (new to Home assistant)


Fix reporting metrics not supported warning for BigQueryIO Direct read when throttled

Fixes #30646. Actually the feature is there but there is a bug prevented it from working properly.
The pipeline, when throttled, can see warning
Reporting metrics are not supported in the current execution environment.

raised from here: https://github.com/apache/beam/blob/8454cc9503008e28f5d3e90d39659352d46af9c2/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1676
This is because the method is called on a callback thread that does not have thread level metrics container. Change it to increment the metrics back to StorageClientImpl temporarily then add it to Beam metrics in work item thread resolved the issue.
Tested with reading TPCDS_1T
Before (pipeline throttled, slowdown, scheduler aggressively upscale worker):

max worker 106

After (pipeline actively scale down, throttling metrics shown)

throttling-msecs	15,060,000
max worker: 57

Sufficient quota:

max worker: 43

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

assign set of reviewers

macos java unit test failed due to #31100 - and rerun doesn't work because the base branch of this PR wasn't updated


Configurable model loading timeout

The model loading timeout, the time to wait for the llama runner, is hard coded. It would be nice to be able to configure this to increase or decrease it (for me, mostly increase). This would allow experimenting with big models that take forever to load, but might run fine once loaded.

I can try to add this feature.

/assign

@ProjectMoon Your problem is that when ollama runs a model that does not exist locally, does pulling it from the registry time out?

No, it's the loading of the model from disk.  There's a hard coded timeout of 10 minutes. I forget the exact file where this is, but the comment above the line says something like "be generous, as long models can take a long time to load."

An example of why this would be useful (to me): I can load Mixtral 8x7b using the Q2_K quant (smallest available file). It loads in 565 seconds, just under the 10 minute timeout limit. But once it's loaded, it generates at 16 tokens/second. It would be lovely if I could try the higher quants and see  what happens.

I am noticing some flakiness on slow model loads. I have one model that gets to 80% and then gives up. Should I reopen this issue or make a new issue to change the stall time?

@ProjectMoon can you try disabling mmap to see if that significantly changes the load times for your setup?
curl http://localhost:11434/api/generate -d '{
  "model": "llama3:70b",
  "prompt": "Why is the sky blue?",
  "stream": false, "options": {"use_mmap": false}
}'

@dhiltgen Disabling mmap makes a world of difference. All the models actually load now, properly split across CPU and GPU. They also load a billion times faster. It's like magic. But mmap doesn't seem to be globally toggleable, and OpenWebUI seems to have only "on" or "default" as options for mmap, instead of also having an "off" value (this isn't part of the Ollama project, but it is odd).
I will now be making some new modelfiles with ollama disabled.

Have noticed, though, that some models have issues loading with mmap disabled if I increase the context size. They crash for various reasons, and not always out of memory issues.

We'll track this via #3940


utils.R

NA handling needs to be done in tag_outlier_windows_ and tag_outlier_windows
The lines 236, 247 and 251 in test_utils.R explain the issue. Pasted below is the whole context text block. The commented expect_* are the buggy tests. And they do have comments below explaining why
context('Tag and Identify outlier windows based on device rotation(using gravity)')
test_that('Identify min, max gravity values for each window of tidy sensor data',{
  # actual function in utils: tag_outlier_windows_

  gravityVec <- dat$gravity$x
  expect_is(mhealthtools:::tag_outlier_windows_(gravityVec, 256, 0.5), 'data.frame')
  # Check if output is in correct format. 256 Window length and 0.5 overlap

  gravityVec <- c(rep(NA,255),1)
  # All values are NA except for the last value, our window length is 256, same as the length of gravityVec
  # min(gravityVec) and max(gravityVec) should be NA, so the testOutput needs to be a dataframe with one obs. for all
  # the three output vars with max and min having NAs

  testOutput <- mhealthtools:::tag_outlier_windows_(seq(256), 256, 0.5) # Initialize the data
  testOutput$max <- NA
  testOutput$min <- NA

  # L 236 # expect_equal(mhealthtools:::tag_outlier_windows_(gravityVec, 256, 0.5), testOutput)
  # Min and Max should be NA if any window has NAs in it
})

test_that('Identify windows in which Phone might have been flipped/rotated given gravity',{
  # actual function in utils: tag_outlier_windows
  testTibble <- dplyr::tibble(window = NA, error = "Error tagging outlier windows")

  gravityVec <- dat$gravity$x

  # Given a gravity vector as the function requires, we should not get the error tibble(testTibble back)
  # L 247 # expect_false(all.equal(mhealthtools:::tag_outlier_windows(gravityVec,256,0.5),testTibble))
  # I think the error is because the input needs to be formatted before feeding it in, or if fed in a gravity vector,
  # it needs to be handled inside (or especially before L 331 of utils, ie the first line after tryCatch in tag_outlier_windows)

  # L 251 # expect_equal(mhealthtools:::tag_outlier_windows(dat$gravity,256,0.5), testTibble) # Wrong input data format(not a vector, but a dataframe), expect an error tibble

})

Re-write the test with the latest merged pull #18 and re-comment on this issue.


Please pin codecov.io to 0.1.16

Release 0.1.17 includes a build-breaking dependency on a version of request which does not exist: cainus/codecov.io/issues/33

To be honest this should be a dev-dependency, not a dependency. This is breaking everyone that depends on node-tap.

It is not a devDependency https://github.com/tapjs/node-tap/commit/e577847553b8905cb5d9bcd0c0397473c0658191#commitcomment-17943382

OK, I am fine with that. Thanks for the fix and thanks for explaining.
An extra 2¢: It is counter intuitive that services are part of the codebase. We could argue this is a case of coupling. Both Grunt and Karma encourage a more interesting pattern, which is requiring all "plugins" that start with "grunt-" or "karma-" respectively and providing hooks that the plugins can activate at the proper time.


Activate the function "Do not save commands"

Description of the new feature/enhancement
This function should delete the executed commands or overwrite them after a restart or with another text.

Proposed technical implementation details (optional)
1. Terminals sends typed char
2. PowerShell receive typed char
3. Terminal displays chars

You have read the issue from which you copied this text. There is no reason for you to file a second one.

Which issue do you mean?
@DHowett-MSFT

Sorry, there's a lively discussion in #5378 -- people are asserting that it is possible, but nobody can tell me how. :smile:
The user who filed that issue has a lot of friends coming over to this repository to keep filing the same requests, and it looked like some of the text in this issue was copied from there, so I thought that it was a clone. It turns out that it isn't (sorry!), but the issue is still a /dupe of #5378.
More information on why it may not be possible in this comment: https://github.com/microsoft/terminal/issues/5378#issuecomment-616883348


java solution leetcode two_sum problem

possible solution in Java
I adjusted some folders to be able to separate the solutions by language types

I'm going to close this pr and open another one ok

removed the folders as we talked


Missing "Parent" field

Please add Parent field on the left side's dataset
Thank you so much from the bottom of my heart
Moran

I'm sorry, but it seems there is no parent in the data for this record. Please provide an example where you know there exists a parent.


Create kymographs from image arrays

Why this PR?
Creating kymos from image data opens up multiple possibilities including creating kymographs from CorrelatedStacks and exploring kymotracking on new types of image transformations (eg., edge detection).  Per-pixel timestamps are not supported, but the line time (frame integration time in the case of camera-based images) must be supplied. This way, these kymos can be used in most downstream analysis including kymotracking

all good points, there's so much functionality to cover but I think now everything is handled and tested


[BAEL-3058] Demonstrate named query

Unit test code for article

@KevinGilmore Latest commit should address these

@KevinGilmore Refactored module into persistence-modules module

@KevinGilmore - I think that takes care of the changes.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.9.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Flutter Web - Uncaught TypeError: func.call$1 is not a functi

When connecting and on subsequent client connections, the web app throws an uncaught type error. Chrome points to zone.dart line 1175, firefox does the same but points to client.dart line 487.
Your environment.

Version: 6512fefd01d606662228b838a8196ffff6c9ae1a
Browser: issue persists

What did you do?
flutter create .
flutter build web --release
host it
Chrome
Uncaught TypeError: func.call$1 is not a function
    at Client.callback$7 (event_emitter.dart:29)
    at EventEmitter_emit_closure.call$1 (event_emitter.dart:64)
    at Interceptor.forEach$1 (js_array.dart:257)
    at Object.forEach$1$ax (main.dart.js:7204)
    at Client.emit$5 (event_emitter.dart:63)
    at Client._handleNotification$1 (client.dart:506)
    at Object.eval (eval at Closure_forwardCallTo (js_helper.dart:2182), <anonymous>:3:41)
    at Peer.callback$7 (event_emitter.dart:29)
    at EventEmitter_emit_closure.call$1 (event_emitter.dart:64)
    at Interceptor.forEach$1 (js_array.dart:257)

Firefox:
Uncaught Error: undefined
    wrapException js_helper.dart:1129
    firstWhere$2$orElse js_array.dart:327
    firstWhere$1 main.dart.js:40658
    2 meeting_page.dart:64
    protected main.dart.js:7440
    call$2 async_patch.dart:340
    _asyncStartSync async_patch.dart:245
    call$2 meeting_page.dart:64
    callback$7 event_emitter.dart:32
    call$1 event_emitter.dart:64
    forEach$1 js_array.dart:257
    forEach$1$ax main.dart.js:7204
    emit$5 event_emitter.dart:63
    emit$3 main.dart.js:53619
    _handleNotification$1 client.dart:514
    anonymous main.dart.js line 4671 > Function:3
    callback$7 event_emitter.dart:29
    call$1 event_emitter.dart:64
    forEach$1 js_array.dart:257
    forEach$1$ax main.dart.js:7204
    emit$5 event_emitter.dart:63
    emit$2 main.dart.js:53613
    call$1 peer.dart:120
    callback$7 event_emitter.dart:29
    call$1 event_emitter.dart:64
    forEach$1 js_array.dart:257
    forEach$1$ax main.dart.js:7204
    emit$5 event_emitter.dart:63
    emit$2 main.dart.js:53613
    call$1 main.dart.js:102223
    1 websocket_web_impl.dart:36
    protected main.dart.js:7440
    call$2 async_patch.dart:340
    _asyncStartSync async_patch.dart:245
    $call$body$WebSocketImpl_connect_closure websocket_web_impl.dart:30
    call$1 websocket_web_impl.dart:30
    call$1 html_dart2js.dart:37188
    invokeClosure js_helper.dart:1825
    function main.dart.js:4533

What did you expect?
I expected it to join the room and conferencing to work.
What happened?
Client joins but hangs at waiting for others to join. You can see your own camera and hear your own audio, but you cannot hear any other participants as they never show joined to the room. The SFU logs indicate multiple peers are connected, and publishing.

@cloudwebrtc I have also discovered this on a chrome release build and accessing the website via firefox in debug. Any ideas?

Closing, reopened under SDK https://github.com/pion/ion-sdk-flutter/issues/16.


Could I copay all content of div tag?

I would like to copay all content of div tag like this

Hello

.......
   .........

It looks like this functionality is missing in this project, but you can check this answer to do it in your own code.


Selects the first timespan available after measurement selection

Related ticket: https://github.com/CartoDB/cartodb/issues/12349.
Acceptance

Take a user from RUI staging servers.
Enable new DO analysis with the feature flag data-observatory-multiple-measures.
Add a new DO analysis.
Select a measurement.
Check after requests that the timespan dropdown selects automatically the first available option.

cc @nobuti

🚀


Android instructions are missing details

A couple of notes from trying to get running on android for the first time:

you have to install API 23, even if you want to build for 5.1. It would be helpful to mention in the guide that 23 is required regardless of target version, since I thought it was just assuming I wanted to build for 6.0 (see #3617)

Android SDK Build-tools has been updated to 23.0.2, so 23.0.1 wasn't installed by default and I had to manually install that when the build failed.

I also had to install Extras > Android Support Repository (see http://stackoverflow.com/questions/33023018/react-native-awesome-project-not-building-android-project)

Thanks for the information, many of the detail are located at http://facebook.github.io/react-native/docs/android-setup.html, but we should update the build tools info.

Could we make the build tool version number in the Gradle file match a version range according to semver? I looked into a bit and the version matching with "+" is slightly bizarre... from my reading it does a prefix match rather than parsing the version string. But maybe there's a sane way to say match 23.0.x?

@mroch can you leave a URL or instructions on how to manually install 23.0.1?

nvm installing android extras got it to build

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-instructions-are-missing-details
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Install AtomVM applications with beams, source code and avm package

This allows users to create dialyzer plt for their version of dialyzer
Until we manage versions of application, these are installed under PREFIX/lib/atomvm/lib/APP-ATOMVM_VERSION
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

It would be great if we could have a future PR add a brief description for how to build and use a plt for their application in the Programmers Guide.

It would be great if we could have a future PR add a brief description for how to build and use a plt for their application in the Programmers Guide.

My idea was that we could have:
rebar3 atomvm dialyzer

That would manage things for users automagically.

I'm not sure if it is a good default for install target or not. But for sure it can be useful. I need to think about this.

I do have a local rebar3 plugin that builds avm for eunit tests, but definitely need etest.avm to be installed.
Current approach is not very friendly:
https://github.com/pguyot/la_machine/blob/668e54082ea42bc988a80f9212a6a4ec5378da3a/.github/workflows/build.yaml#L77-L85


Mini Player Window Expands

OS: Windows 10 Spring Creators Update (Build 1803)
GPMDP Version: V4.5.0
Issue Descriptions: After opening mini player, it continuously expands the window size taking up the entire display,
Steps to Reproduce: Open min player with or without media playing
debug_info.zip

Found related issue : https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/2269


'Access-Control-Allow-Origin' issue

i tried to update my homepage today but when running hugo serve i get the following errors:

any ideas how to fix this? i've tried the chrome extensions suggested in this thread but this didn't help.

I think the problem is with templating. The version numbers for the assets aren't replaced in the URL.
For example, the link for Bootstrap CSS should have been https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/css/bootstrap.min.css instead of that shown in the screenshot.
I tested on both the latest version v2.2 and master branch; there seems to be no issue like this. Which version of Hugo and Hugo-academic theme are you using?

thanks -- i'll look into it and will send an update shortly.

removing my custom header.html file solved the issue. thanks for your help!


Bug Fixes

Handle Attach in RABR rap pending state
Handle Attach in MB Rsp Pending state
Handle Service Req with Control block not found
Service Reject encode fix.

retest this please

retest this please


Formatter poorly(?) documented deviation: Call in right side of equality when call chain is on the left

Black formatting:
def foo():
    for _ in range(2):
        assert AAAAAAAAAAAAAAAAAAAAAA.bbbbbb.fooo(
            aaaaaaaaaaaa=aaaaaaaaaaaa
        ).ccccc() == (len(aaaaaaaaaa) + 1) * fooooooooooo * (
            foooooo + 1
        ) * foooooo * len(
            list(foo(bar(4, foo), foo))
        )

Ruff formatting:
def foo():
    for _ in range(2):
        assert AAAAAAAAAAAAAAAAAAAAAA.bbbbbb.fooo(
            aaaaaaaaaaaa=aaaaaaaaaaaa
        ).ccccc() == (len(aaaaaaaaaa) + 1) * fooooooooooo * (
            foooooo + 1
        ) * foooooo * len(list(foo(bar(4, foo), foo)))

This seems pretty similar to https://github.com/astral-sh/ruff/blob/main/docs/formatter/black.md#call-chain-calls-break-differently, so I'm guessing it might be intentional? But the call that's being changed isn't actually part of the call chain, so if it's intentional the documentation should perhaps be rewritten slightly.

Yeah, I suspect this is the same thing. I'll try to improve the write-up a bit.

This is another similar-ish example, this time it's not a call in the chain that's getting changed but an indexing after the call chain:
https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AE7AJVdAD2IimZxl1N_WlbvK5V9KEd0suDTtKdXyXo2kcuBYPryJZ5G_dS0BQrsk0J72ctwrWi50MbcjSAgbd1pDRsO25yM0zEHl-Qp80HeK1J3JG-cjLbYLJtwuLmm5YYOfhKlmnoTZ6tl7avsmvD4jY7GxWGE-6rTP7XuF8nOCQP7pdeJDKHVTSXR58N3rXVmq6mhBAquOTsAAAAAAAzEPxgSbck6AAGxAbwCAADxGIN7scRn-wIAAAAABFla
https://play.ruff.rs/a6144214-4043-43fd-8d6c-de08025a21dd?secondary=Format

Hmm, this one has no call chains nor calls, is it a completely different issue or still related?
https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AD7AGZdAD2IimZxl1N_WlbvK5V9KEd0suDTtKdXyg7Vbzvz0jlNR2_bpXU07f205BRmTbXczRtImDQGwvxVeZ0igpjl1qY5GjsPOvWAo45rNmyDKffTMdBonyq7OakaQnjgdtL9VEwdljVCAAAAABNrGxsCFLuyAAGCAfwBAACWiz9gscRn-wIAAAAABFla
https://play.ruff.rs/ca8b5351-00c1-4ddc-a1f3-fe9ee3aeeb7d?secondary=Format

That last one looks separate -- do you mind filing a new issue for it? I would've expected us to wrap there.

Will do!

Here's an example where it changes a call in the chain, but not the last call:
https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AFAAJ9dAD2IimZxl1N_WlbvK5V8G17R4xukEnqcY6_V1Dl-sIzsksJnPtkyWorT7oP5VJ0HTTlXlmW8mqIHMCK-um5mxlp8fBO2lEBIirr6EpL7rOS9n9gkhszdKw9Z_6t9P76Zmk-DWur8klIiD5tLp9iRs_5uQjix160o4YhkqfxCzOpnA_fhc5V4Eh856r4r51IvxbNFd4_DQmGPIfeEci6HAAAANfFOPYGTZkAAAbsBwQIAANZDTUOxxGf7AgAAAAAEWVo=
https://play.ruff.rs/b7af8c25-78e4-4fcd-ad2c-0f74db349da3?secondary=Format

Interestingly I found a case where Ruff splits a call which Black doesn't
https://black.vercel.app/?version=stable&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AHEALVdAD2IimZxl1N_WlbvK5V9KEd0suDTtKdXyXm39k-8r0kVpb5gKnZS64uu_-AbJ7XCI_oZS91LNEZjHTtI0qDEfK_9DztckbzC_cA3STrwTL1H75v0-A127RZ2ho-GRN0j-RFkhjHalceawulnq13ZcXyiq508tAjG33Uk4UlvIatbX1EKu1wwr1HQ8DVxuqcLUzw4iMvnNGaeMGd8HmRZG4luSVtzfIImtnVQzKoyH-QILZc-twAAAAAAogfqQW1z8GEAAdEBxQMAAIqSgmSxxGf7AgAAAAAEWVo=
https://play.ruff.rs/dd119455-1ea0-464c-af99-49e704037612?secondary=Format


Broken controls in the latest release

Controls are broken in the b068+MC_b093 build.
Only L/R and 1/3/7/9 are working in most games. Every other button doesnt respond, no matter if virtual or mapped to a gamepad.
Regular J2ME-Loader works fine.
Thank you.
Note: I labeled it wrong, sorry.

Try new build b069+MC_b093


Installing Issues VLC Office 2019 STD

Hello New to this way of downloading so bare with me.
I created the configuration.xml from the creator Microsoft provided. The problem I keep having is I ran setup/download configuration.xml Which download to a windows 10 PC. I then ran /configure and it also installed great.
So I created another XML with a source \server\office2019 Moved the Office folder from the Windows 10 machine to a network share.
Logged into another PC and copy ODT and the new XML to it. Ran setup /configure configuration.xml and it keeps returning Error 30182-1011 Couldn't Install We are Sorry we can't continue we weren't able to download a required file.
I can't seem to get past this error.
Please Help

Make sure the folder name you're running the setup from is the same as when the configuration file was created. So if you originally ran it from a folder named Office2019 you'll get that error if you run it from MSOffice2019 on the new machine. Keep the name the same as the original and it may fix the problem.


Error for the new tag extra_html_url_es5 after updating to latest version of HA, custom-ui and customizer.

Checklist

[Yes ] I'm running the latest version of CustomUI (Update guide) or using a specific release that is not marked as "Broken".
[ yes] I tried to force-refresh (Ctrl+Shift+R / Ctrl+F5) the browser
[yes ] (Optional, but recommended) I'm using Chrome or tried to reproduce the feature on Chrome.

Browser + Version:

CustomUI version:
Home Assistant release (hass --version):
Problem-relevant configuration.yaml entries:
customizer:
  custom_ui: local
  hide_attributes:
    - node_id
    - value_index

# Enables the frontend
frontend:
  extra_html_url:
    - /local/custom_ui/state-card-custom-ui.html
  extra_html_url_es5:
    - /local/custom_ui/state-card-custom-ui-es5.html
# Enables configuration UI

Problem-relevant Home Assistant log entries:
2017-11-29 14:47:10 INFO (MainThread) [homeassistant.loader] Loaded system_log from homeassistant.components.system_log
2017-11-29 14:47:10 ERROR (MainThread) [homeassistant.config] Invalid config for [frontend]: [extra_html_url_es5] is an invalid option for [frontend]. Check: frontend->frontend->extra_html_url_es5. (See /config/configuration.yaml, line 31). Please check the docs at https://home-assistant.io/components/frontend/
2017-11-29 14:47:10 ERROR (MainThread) [homeassistant.setup] Setup failed for frontend: Invalid config.
2017-11-29 14:47:11 INFO (MainThread) [homeassistant.loader] Loaded history from homeassistant.components.history
2017-11-29 14:47:11 INFO (MainThread) [homeassistant.loader] Loaded recorder from homeassistant.components.recorder

Any errors from browser Javascript console:

I just updated my HASS installation. pip3 is installing 0.58.1. The es5 URL is for 0.59+ :)

Yes, es5 is 0.59+ you shouldn't use it
@sumitrajancse
Also, if you are using
customizer:
  custom_ui: local

no need to add extra_html_url / extra_html_url_es5, as customizer is taking care of that in a version-aware way.

Thanks @andrey-git


class file for com.google.errorprone.annotations.RestrictedInheritance not found

Just updated Google Places SDK from 3.3.0 to 3.4.0 which bumped play-services-base from 18.0.1 to 18.3.0, resulting in the following problems:
compileDebugJavaWithJavac FAILED
Z:\caches\gradle\caches\transforms-3\cafb58f4ccde6f6fe4b7ef5eb9b091ac\transformed\play-services-base-18.3.0-api.jar(/com/google/android/gms/common/GoogleApiAvailability.class): warning: Cannot find annotation method  'explanation()' in type 'RestrictedInheritance': class file for com.google.errorprone.annotations.RestrictedInheritance not found
Z:\caches\gradle\caches\transforms-3\cafb58f4ccde6f6fe4b7ef5eb9b091ac\transformed\play-services-base-18.3.0-api.jar(/com/google/android/gms/common/GoogleApiAvailability.class): warning: Cannot find annotation method  'link()' in type 'RestrictedInheritance'
Z:\caches\gradle\caches\transforms-3\cafb58f4ccde6f6fe4b7ef5eb9b091ac\transformed\play-services-base-18.3.0-api.jar(/com/google/android/gms/common/GoogleApiAvailability.class): warning: Cannot find annotation method  'allowedOnPath()' in type 'RestrictedInheritance'
Z:\caches\gradle\caches\transforms-3\cafb58f4ccde6f6fe4b7ef5eb9b091ac\transformed\play-services-base-18.3.0-api.jar(/com/google/android/gms/common/GoogleApiAvailability.class): warning: Cannot find annotation method  'allowlistAnnotations()' in type 'RestrictedInheritance'
error: warnings found and -Werror specified
1 error
4 warnings

Can you please add the RestrictedInheritance annotation and checker to the error-prone artifacts? or hide the private annotation from the public API.

Workaround
Create a new file at src/main/java/com/google/errorprone/annotations/RestrictedInheritance.java in the module that uses play-services-base:
package com.google.errorprone.annotations;

/**
 * Workaround for class file for com.google.errorprone.annotations.RestrictedInheritance not found.
 *
 *

 * warning: Cannot find annotation method 'explanation()' in type 'RestrictedInheritance'
 * warning: Cannot find annotation method 'link()' in type 'RestrictedInheritance'
 * warning: Cannot find annotation method 'allowedOnPath()' in type 'RestrictedInheritance'
 * warning: Cannot find annotation method 'allowlistAnnotations()' in type 'RestrictedInheritance'
 *

 *
 * @see Report
 */
public @interface RestrictedInheritance {
	String explanation();
	String link();
	String allowedOnPath();
	Class<?>[] allowlistAnnotations();
}

Thanks for the report!

Can you please add the RestrictedInheritance annotation and checker to the error-prone artifacts? or hide the private annotation from the public API.

We may eventually finalize the annotation to and include it in error-prone-annotations, but until that happens I have filed an internal issue against the owners of play-services-base about hiding the annotation from the API [b/330519201].

Thanks for forwarding the issue internally!


Unsafe adding px as unit to -webkit-line-clamp

unsafe("-webkit-line-clamp", "2") translates to -webkit-line-clamp: 2px. I've been looking through the code and can't figure out where this happens.

Solved by using: unsafe("-webkit-line-clamp", "calc(2)") to prevent px being added as a unit to the number.


Batch verification of multiple artifacts

Currently slsa-verifier needs to be run once per artifact listed in a provenance statement. We could provide a way to specify multiple artifacts at once so they can all be verified in one go.

I'm not sure if this is particularly high priority since

Provenance is somewhat likely to be created 1:1 with artifacts.
I think users will always be verifying a subset of the artifacts listed in provenance.
Feedback to the user becomes more complicated. Which artifact was the one that failed? Is a simple human readable error message sufficient?

duplicate of https://github.com/slsa-framework/slsa-verifier/issues/91. I'll close this issue and copy over your comment.


Updated versions, updated readme, improved IOS

Made the readme clearer for IOS with instructions and limits.

Add platform to the features so it causes less confusion.

Updated some versions in pubspec

Because of a line of code on line 25 in sound_mode.dart it gave the wrong value. Fixed this.

Hi @JobMoll, I understood the reason for the issue on line 25 in sound_mode.dart,
Thanks again for the pull request!


Revert "Revert "Updated Push to FDP""

Reverts DTL-FAIRData/FAIRifier#43

Due to messed up re-re-reverted branches, accepting this one and continuing in .45


invalid API key for maps.omniscale

Am I doing something wrong?

Fixed. You can also switch the map layer with the button on the top right. Also after the fix you can use the map tiles with our key on localhost but you cannot use them on your own server (get some fresh api keys at omniscale.com)


[Google Meet] Doesn't copy URL from Arc

Extension
http://www.raycast.com/vitoorgomes/google-meet
Description
The new Google Meet opens in Arc correctly, but when it goes to copy the link to make it immediately shareable, Raycast says "Couldn't copy to clipboard"

Steps To Reproduce

Be on macOS Sonoma 14.2.1 and Raycast 1.64.4
Have the Preferred Browser setting set to Arc
Open Raycast and choose "Create Meet"

Current Behaviour
Does not copy Meet URL to the clipboard
Expected Behaviour
Copies Meet URL to the clipboard

The link at the top of the note is the correct one.  I don't know why it's not seeing it correctly because the link opens the extension's page correctly for me.

@vitoorgomes In case you don't get tagged in this automatically

Just thinking out loud here, I see in the script (https://github.com/raycast/extensions/blob/610b37b77daf12d71b9e6f5efaf4a405770a0a6a/extensions/google-meet/src/utils/scripts.ts#L43) that you're just doing some keystrokes.  Would it make sense to do something like:
     tell application "System Events"
        keystroke "l" using {command down}       # <------ add this line to open the command bar that has the address selected
        keystroke "c" using {command down, shift down}
        delay 1
        set copiedURL to the clipboard as text
      end tell


Migrate GetEstimationDto to zod

Summary
This migrates the validation of GetEstimationDto to zod.
Changes

Remove GetEstimationDtoValidationPipe and associated schemas.
Add test-covered GetEstimationDtoSchema and infer types from it.
Propagate type requirements.
Update tests accordingly.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

15 of 16 (93.75%)  changed or added relevant lines in 5 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 93.323%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/domain/estimations/entities/get-estimation.dto.entity.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/domain/estimations/entities/get-estimation.dto.entity.ts
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
6473

Relevant Lines:
6692

💛  - Coveralls


Dependabot links to the wrong project and changelog

Package manage/ecosystem
Python
Manifest contents prior to update
N/A: The manifest update is correct.
Updated dependency
Bump darglint from 1.2.3 to 1.3.0
What you expected to see, versus what you actually saw
The project name darglint should be linked to:

https://github.com/terrencepreilly/darglint

Instead it is linked to:

https://github.com/raddessi/SublimeLinter-contrib-darglint

darglint provides the correct url in its setup.py.
The changelog also comes from the wrong project.
Dependabot PR: https://github.com/cjolowicz/cookiecutter-hypermodern-python-instance/pull/148

This is a pretty old issue, I wonder if this is still happening or if it is reproducible with any current packages? I know we've fixed a number of issues around metadata gathering, so unless I hear otherwise in the next week I'll be closing this issue.

Closing due to lack of feedback.


feat: update error messages

Currently, the error messages make the debugging hard, as it is difficult to figure out where are there issues (in the request or the documentation), for which request it is happening and what's the exact problem and the expectation.
This PR aims to fix that (partially) by changing a few things:

Change how the reference is created:
The existing reference contained minimal information and it also had a bug where it would continuously attach fields to it, even when it should have pointed to only one field. The new format will contain informations about the request path and type, if it's the request or response, and the drilldowned path to the key with the issues (if it's the case)

The new format will look like this: '<request_type> <request_path> > <request/response> > <status_code(for responses)> > path > to > key'
and in practice it could look like this: GET /api/pets > response > 200 > name > id

Add whenever possible the actual request/response body and the schema section for easy comparison

Update most of the messages to include, besides the new reference, a copy of the actual body and the schema section, along with (hopefully) clearer language as to what went wrong. The combination of these and the new reference should provide enough information to quickly investigate the issue without have to take the request and the documentation and scan for differences side by side.
Examples of how it would look like:
missing property from the request data
E               openapi_tester.exceptions.DocumentationError: The following property was found in the schema definition, but is missing from the request data: "name"
E
E               Reference:
E
E               POST /api/pets > request > name
E
E               Request body:
E                 {
E                   "tag": "dog"
E               }
E               Schema section:
E                 {
E                   "name": {
E                       "type": "string"
E                   },
E                   "tag": {
E                       "type": "string"
E                   }
E               }
E
E               Hint: Remove the key from your OpenAPI docs, or include it in your API request

missing property from the response data
E               openapi_tester.exceptions.DocumentationError: The following property was found in the schema definition, but is missing from the response data: "width"
E
E               Reference:
E
E               GET /api/v1/cars/incorrect > response > 200 > width
E
E               Response body:
E                 {
E                   "name": "Saab",
E                   "color": "Yellow",
E                   "height": "Medium height"
E               }
E               Schema section:
E                 {
E                   "name": {
E                       "type": "string",
E                       "maxLength": 254
E                   },
E                   "color": {
E                       "type": "string",
E                       "maxLength": 254
E                   },
E                   "height": {
E                       "type": "string",
E                       "maxLength": 254
E                   },
E                   "width": {
E                       "type": "string",
E                       "maxLength": 254
E                   },
E                   "length": {
E                       "type": "string",
E                       "maxLength": 254
E                   }
E               }
E
E               Hint: Remove the key from your OpenAPI docs, or include it in your API response

Besides all of these, another minor change is to use by default json.dumps on data whenever the content is application/json in order to reduce verbosity in tests
Additionally Part 3: added support for OAS 3.1 lists of types e.g.:
    NewPet:
      type: object
      properties:
        name:
          type:
            - string
            - 'null'

@danut-t thanks for this change, IMO this is a huge improvement to the main goal of this package, which is informing these inconsistencies. Just left a comment about the minor change of the json serialization on this package's side.

@maticardenas Hmm I don't see the comment, could you link it to me please?

@danut-t it should be visible now, I had forgotten to “submit the review” and it was only visible to me

So nice! These error messages are so useful 😻


Selects and angular

When I try to get the value of a select -angle I can not, because the original select a dropdown in obtaining been thinking the value of a select with any js framework ?
-------------ESPAÑOL-------------
Cuando intento obtener el valor de un select con angular no puedo, ya que el select original es un dropdown, han pensando en como obtener el valor de un select con algun framework js?

Actual english: I cannot obtain the value of a select element with Angular when I try, becase the original select is a dropdown (??). Have you considered how to obtain the select value with any js framework?

I haven't used any other js framework with materialize, but in js I had no issues adding an onchange event listener to the original select element.

I am using Materialize with Angular and had no problems getting the value from the select.

I've just tried to get value from materialized select and the value is empty. Basically the issue remains.

We won't get anywhere with this. What version of materialize and angular are you using? I'm using materialize 0.95.2 and angular 1.3.14.
You could also share a code example of how you're doing it. This is an example of how I'm writing it.
<!-- The material_select function is called on a directive I created -->
<select ng-model="vm.model.gender" required="required">
    <option value="">Gender</option>
    <option value="Male">Male</option>
    <option value="Female">Female</option>
</select>

I tried your code and there is no data in the scope ... It only works with the browser-default class , which is a design backstep ... Did you use it without the browser default ? Can you please show or describe your directive ?

In my example, it is as I used in my app, word by word, and it works.
I have another case where the options come from the server and filled with ngOptions, in that case I used a ngIf to prevent the select being created before the data is ready.
<select ng-model="myModelr" required="required" ng-options="..." ng-if="options.$resolved">
    <option value="">Gender</option>
</select>

The options would be my options, and the $resolved property is there because I'm using ngResource, but you can use whatever way you want to prevent it being created before time.
I also created a directive for the select, because my app is a single page app, so my directive handles calling material_select for each select element.

I tried this out in my app and it all works.  I didn't name my controller "vm" though, so had to change that, but it works verbatim other than that change with and without the browser-select class as @viniciusmelquiades indicates.

I'm going to go ahead and close this as there seems to be no problem. Thank you @viniciusmelquiades for clarifying your method.

{{strCircle}}

above in ng-click = before selected option is sending to function so plz alternate

@viniciusmelquiades, looks like the problem is when you put the select inside.input-field
<div class="input-field col s12">
   {{vm.model.gender}}
   <!-- The material_select function is called on a directive I created -->
   <select ng-model="vm.model.gender" required="required">
       <option value="">Gender</option>
       <option value="Male">Male</option>
       <option value="Female">Female</option>
   </select>
</div>

This code don't work inside that class

Do you think you could post your directive for the select elements that calls material_select?

@PerzAlejandro @fedpettinella @jamesgarzon @ibrainventures
Just load jQuery before Angular, and it work like a charm! :)

thx @nicolaspennesi

Thanks @viniciusmelquiades  Never thought ng-if will make such a difference.  It is kind of mandatory to place it your options are loading dynamically by collection in scope from the controller. Fortunately, google helped me to land up here. I will we documented this. I will check that out if we can contribute in terms of documentation

@nicolaspennesi your method worked like a charm!!!

I have the same problem here https://codepen.io/antonyselt/pen/YxOveW , anyone now what I'm doing wrong? I tried you guys said

@Antonyselt I fixed it for you here https://codepen.io/anon/pen/yoRbrQ
Basically I used ng-options. I never tried with ng-repeat.
The default option ("Choose your option") was fixed by setting the value as an empty string (value="").
You don't need the selected attribute in the default option. Angular will set the default option for you.
I only fixed the first example.


Replaced mentions of bounding box with bounds control

Overview
removed all references to old bounding box in other articles and replaced by bounds control
replaced one old reference to manipulation handler with object manipulator

/azp run mrtk_docs


Update mirror

Is seems 7b57b0f6347127140e99a70f71d0d21ce633265d is 48dd2a8294ae2d419057d85c20dc1b960d8ff42d missing on this mirror.

I've updated it now - thanks.

Could you push the tags as well?

Done. I'll add a note to remind myself to do this in future.


Help the user use the extension

Error messages and notifications are useless at the moment: They tell you what's wrong, but not how to fix it.

[x] Add a "get started" document to point people to
[x] Customize the extension errors to point to this document ("No field found" and "No editor found")
[x] In the options page, add link to this document and to the testing ground/demo page.
[ ] Point errors to their exact troubleshooting parts
[ ] Add welcome page to open on install https://github.com/fregante/ghosttext.fregante.com/issues/2

[ ]


Reproduce protobuf corruption

gives
Error message from worker: java.lang.RuntimeException: java.io.EOFException: reached end of stream after reading 5 bytes; 10 bytes expected org.apache.beam.runners.dataflow.worker.WindmillKeyedWorkItem.lambda$elementsIterable$2(WindmillKeyedWorkItem.java:110)

when run on dataflow
no problem with direct runner
no problem when message mapper maps directly to Test instead of to byte[] first before doing Test.parseFrom, although in more complex pipelines a different serialisation error still shows, this is probably due to fusion which in simpler pipelines can make serialisation unnecessary and so the issue might not manifest
no problem when
  @Override
  public boolean requiresDeduping() {
    return false;
  }

This example has been incorporated into the latest release.


ci(workflows): upgrade action versions and ubuntu in workflows

Not sure scope yet, trying out some changes.

https://github.com/actions/runner-images/issues/6002

@y3rsh it looks like the runner is now using 3.10 instead of 3.7 to create the virtualenv which is breaking things:
Pipfile: /home/runner/work/opentrons/opentrons/api/Pipfile
Using /usr/bin/python3 (3.10.4) to create virtualenv...

now i'm not sure why that is, but i think that's what is breaking things. we shouldn't have to, and should not, change the code - would you mind reverting that commit?

@y3rsh it looks like this: https://github.com/opentrons/opentrons/pull/9708 now needs to be not opted out of by CI.
this is set in ci by .github/actions/setup/action.yaml. it's set by an action input that defaults to empty.
i think we should make either

(preferred) Change the action so that if the input is unset, it doesn't specify the environment override at all, and just calls make -C ${{ inputs.project }} setup rather than make -C ${{ inputs.project}} setup OT_VIRTUALENV_VERSION=, which will allow the default in the python.mk script to get set
change the action to have that input default to 3.7, which I don't love because then it's a second source of truth to python.mk, but should work

All builds created from this PR installed.

mac
windows
linux


Adding/fixing gates in lab_dev transformations

Context:
Fixing mistakes of the Rgate and adding Identity to lab_dev
Description of the Change:
Correcting the Abc triplet of the Rgate from squeezing Abc to rotation Abc and updating the tests. Adding the identity transformation and tests of it.
Benefits:
More (and correct) gates in lab_dev.
Possible Drawbacks:
Related GitHub Issues:

The Tensorflow test worked for the initial push. The difference to the second is I ran the 'black formatting' and now Tensorflow fails.


Renaming command files to use same semantics as Laravel

This PR:

rewords descriptions of commands to use same naming

example: Create a new validation rule...

renames files to ThingMakeCommand, now its easier to search for the file (visually) since list will be alphabetically ordered

example: MiddlewareMakeCommand.php

removes unused parameters sent along to stub class
fixes uncovered bug with getDefaultNamespace() see 787357c

Tests renaming is next, did not want to fiddle with tests while renaming files in src.

Hello,
Thanks for the PR. However, I was about to start refactoring to the MakeSomethingCommand structure.
This makes the files grouped together.

I see you also did a lot of code style changes that aren't needed.

I don't understand the issue about "fixes uncovered bug with getDefaultNamespace() see 787357c"
It never caused an issue in the past, do you have a test making the bug visible?

I think we should follow how Laravel does it with filenaming (ThingMakeCommand) and maybe use another folder for so-called "generators" but its not needed. Reasoning for this that is that If I search for Middleware (visually, not via search in editor) I can find it easier.
The bug I am talking about in 787357c is that if user sets for lets say for Notifications in config 'SMS/Notifications', the getDefaultPath() is going to generate wrong path. In other words I did not look at the detail I just concluded that half of commands had default namespace hard-coded and half did not.

Yes, I looked at what laravel does, but I don't think we need to copy laravel in regards to class names.

And code style changes is from PHPstorm cmd+alt+L set to PSR2. I just "styled" those that I touched.
I am following Laravel's conventions because this package is targeted for Laravel users not for some other framework users.

The code style is not the one from phpstorm, but the one from phpcsfixer.
There's no need to follow laravel conventions.

Changed styling using php-cs-fixer; commit message should be "Using .php_cs.dist".

Thank you 👍

Please hold of the tests renaming, I'll handle that. 😄

Sure thing :D
And thanks too :).


Home Page: Display gallery load failures only when none succeed

Summary
If one of the galleries loads then display the result (e.g. Dropbox succeeds but local fails). Only display an error message when all galleries fail to load

Test plan
Untouched

Coverage remained the same at 93.056% when pulling 19b4c033487825159796becec43461056aa5759e on danactive/home-try-show-any-gallery-success into 7884732a5acfce9e7c656a196e743ab5d45bb012 on master.