Vertical slider responsive height

Hello, i have been using this slider for 8 months already thanks very much
Im trying to do Vertical slider, but i cant set slidesToShow option. height of .slick-list and .slick-slide
items can be variant.
here is my fiddle  https://jsfiddle.net/75ouf2pg/4/
is there a way to set slidesToShow auto.
best Regards

I had the same issue, fixed one like this:
I replaced this part if code
 if (_.options.vertical === false) {             targetLeft = ((slideIndex * _.slideWidth) * -1) + _.slideOffset;         } else {             targetLeft = ((slideIndex * verticalHeight) * -1) + verticalOffset; }
with this one
if (_.options.vertical === false) { 	targetLeft = ((slideIndex * _.slideWidth) * -1) + _.slideOffset; } else { 	var scrollHeight = 0; 	for(var i = 0; i < slideIndex; i++) 		scrollHeight+= _.$slides.eq(i).outerHeight(true); 	targetLeft = (scrollHeight * -1) + verticalOffset; }

targetLeft

Where add this code ?


sol-fbp-generator fails to generate a .c file

In order to test the SLV feature to export fbp files, I tried to convert a fbp file to .c source code with the following command line:
'/sol-fbp-generator2 -j /usr/share/soletta/flow/descriptions/builtins.json -j /usr/share/soletta/flow/descriptions/calamari.json  SLV_Examples/slv_created_calamari_led_lever.fbp slv_calamari-lever.c'

Output (error) returned by the previous command:

SLV_Examples/slv_created_calamari_led_lever.fbp:1:40 Expected ',' after key-pair meta information. e.g. '(nodetype:key1:val2,keyN:valN)'
Segmentation fault

below is the content of the file: 'slv_created_calamari_led_lever.fbp'  :

node2(calamari/lever:poll_interval=max:"INT32_MAX"|min:"INT32_MIN"|step:1|val:0,range=max:1023|min:0|step:1|val:0,bus=max:"INT32_MAX"|min:"INT32_MIN"|step:1|val:0,chip_select=max:"INT32_MAX"|min:"INT32_MIN"|step:100|val:0) OUT -> INTENSITY node3(calamari/led:period=max:"INT32_MAX"|min:"INT32_MIN"|step:1|val:10000,range=max:10000|min:0|step:5|val:0,address=1)
Thank you!

I cannot try now, but the INT32_MAX and INT32_MIN shouldn't have quotes as they are constants. @cmarcelo may know more about it.

@dborquez Like @barbieri said, I tested here and it worked removing the " for INT32_MAX and INT32_MIN values.

@barbieri and @barbieri, that's correct, with the changes before mentioned it works. I'll proceed now to close this issue and redirect this to SLV team.


Ability to disable Select All

reopening #563 as I had already tried the suggested workflow which led me to the handleAllRowsSelect.
I have a use case where I need to disable the ability to select/unselect all. Looking at the code there doesn't appear to be a away to do this as currSelected is set no matter what onSelectAll does. Am I missing something obvious? Or is this a feature you would consider adding?
    handleAllRowsSelect = (e, isUnSelect) => {
      const {
        data,
        keyField,
        selectRow: {
          onSelectAll,
          nonSelectable
        }
      } = this.props;
      const { selected } = this.state;

      let currSelected;

      if (!isUnSelect) {
        currSelected = selected.concat(dataOperator.selectableKeys(data, keyField, nonSelectable));
      } else {
        currSelected = selected.filter(s => typeof data.find(d => d[keyField] === s) === 'undefined');
      }

      if (onSelectAll) {
        onSelectAll(!isUnSelect, dataOperator.getSelectedRows(data, keyField, currSelected), e);
      }

      this.setState(() => ({ selected: currSelected }));
    }

As @AllenFang suggested, you can remove the select all checkbox using selectionHeaderRenderer and rendering null,  but if you click the table cell the handleCheckBoxClick is still fired.
I believe its this code:
https://github.com/react-bootstrap-table/react-bootstrap-table2/blob/6e526f455b68f06705ab862cbe1fa63bf8057682/packages/react-bootstrap-table2/src/row-selection/selection-header-cell.js#L74-L76

I will handle it

@tmock12
https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/09/30/version-bump.html
Please upgrade to<EMAIL_ADDRESS>at least. selectRow.hideSelectAll will help you so you don't need to custom it via selectionHeaderRenderer. thanks
Please reopen this issue and tag me if it's still not work.

@AllenFang Thank you! 🤗

I was wondering how I can have a custom header for the select column, without allowing selectAll.
Basically, I want to title the selectRow, and not have the click propagate through. Is this currently possible?


Introduce importmap-rails for JavaScript dependency management

It will be the default way from Rails 7.
https://world.hey.com/dhh/rails-7-will-have-three-great-answers-to-javascript-in-2021-8d68191b

Hello, is there any news about this? I am using Rails 7 and propshaft instead of sprockets as my asset pipeline and I get an error on installation because sprockets is required.
Thanks!

I realized that this is possible now, after upgrading Bootstrap to 5 we now have no ESM-incompatible dependencies.
I'll try to see if it works or not soon.

Is there a corrected rails_admin:install command to work with importmap?


Compile error

Hello,
I get a compile error when I build the upgrade-to-next-9 branch.
npm run build

><EMAIL_ADDRESS>build F:\next-boilerplate
> cross-env NODE_ENV=production next build

Creating an optimized production build ...

> Using external babel configuration
> Location: "F:\next-boilerplate\.babelrc"
Failed to compile.

./src/Components/Heading/style.scss 2:0
Module parse failed: Unexpected token (2:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|
> .title {
|     display: flex;
|     flex-direction: column;

> Build error occurred
Error: > Build failed because of webpack errors
    at build (F:\next-boilerplate\node_modules\next\dist\build\index.js:7:847)
    at <anonymous>
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `cross-env NODE_ENV=production next build`
npm ERR! Exit status 1

What am I missing?

Hi @yang-xiaodong
Thank for reaching us.
This branch hasn't been completed yet. We're still working on this. It' ll be updated very soon.

OK, Thanks. I will wait for update


[file-format] Deprecate script visibility for an entry point modifier #182_88

Motivation

Replaces Script visibility with an is_entry marker for functions.

For backwards compatibility, Script visibility now means public + is_entry.

The visibility is removed from V5+.

We want to separate out the notion of entry points from visibility.

This gives adapters more flexibility.

Additionally, it allows module writers to have more expressiveness. You can even declare a private entry function, which enables new expressiveness, as you can ensure the logic is only performed at the start of the transaction (assuming the module itself does not call the function).

Test Plan
CI/CD tests were performed

:sunny: Canary successful

/land


Would you mind to give an instruction about how to reproduce your results?

Hi, I'm very surprised by your results and interested in your implementation.
I notice that you provide the trained models FPNSSD512.
Would you mind to give an instruction on how to train FPNSSD512 using your codes?
Thanks very much for your help.

Sorry, you are mislead!
The results in readme are SSD from torchcv, I haven't implemented it yet!!!
Code could be found in examples/dsod and torchcv/models/dsod. I'll update readme!


Enhance icon fallback and their docs for exporters

Make Windows exporter fallback to other alternatives (first application/config/windows_native_icon then application/config/icon) if no icon was set.
Make macOS exporter fallback to application/config/macos_native_icon first, and then application/config/icon.
Improve exporter doc pages with references and better wording.

Thanks!


Stop the gradient computation for Keras eager execution mode

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 1.10.1
Python version: python 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

Describe the problem
I  am facing problems when implementing some custom loss function in Keras based on the eager execution mode. The problem is that some loss functions require to stop the gradient computation for some specific variables. When executed in a graph, we can use the op tf.stop_gradient. In fact, for Keras the GradientTape is internally handled by the function _process_single_batch
Source code / logs
Here is an example :
    def virtual_adversarial_loss(X, DAE_encoder):
        r_vadv = generate_virtual_adversarial_perturbation(X, DAE_encoder)
        tape.reset()
        tape.watch(X)
        tape.watch(r_vadv)
        p =  DAE_encoder(X)
        p = tape.watch(p)
        q = DAE_encoder(x+r_vadv)
        loss = kl(p, q)
        return tf.identity(loss, name="vat_loss")

    def virtual_adversarial_loss(X, DAE_encoder):
        r_vadv = generate_virtual_adversarial_perturbation(X, DAE_encoder)
        tf.stop_gradient(X)
        tf.stop_gradient(r_vadv)
        p =  DAE_encoder(X)
        p = tf.stop_gradient(p)
        q = DAE_encoder(x+r_vadv)
        loss = kl(p, q)
        return tf.identity(loss, name="vat_loss")

Both of these functions do not work. The problem with the first one is that I can't use the tape variable created by the internal Keras wrapper function _process_single_batch . The problem with the second one is that I can't use tf.stop_gradient for the eager execution mode.
Is there a way to stop the gradient computation in Keras eager execution mode?

@nairouz just ran above snippets in eager execution and both of these functions should work. You would need to add something like:
from tensorflow import keras from tensorflow.python.eager.backprop import GradientTape from tensorflow import keras as ks
Make sure to add with GradientTape() as tape: in your first function.

@wt-huang thank you for the response. Yes, I made sure to add all the required imports.
Please let further explain the problem. Some loss functions require to stop the gradient for some specific variables. In fact, there are two cases:

In the graph execution mode, one can use the  tf.stop_gradient(input=a) and this operator will exclude the "a" variable from any gradient backpropagation.

In the eager execution mode, a tape should be created based on the GradientTape class to record the operations since we do not have a graph and only then we can exclude some variables from the gradient backpropagation.

Unfortunately in Keras, one should not create a tape himself since the gradient computation will be done using the tape created by tensorflow developers in this function _process_single_batch. Even if I create a tape myself, it will not be used for the gradient computation performed by Keras engine unless I implement my own training loop function and hence have my own  backpropagation. In this case,  I would be deprived of Keras high-level API functions like train and predict.
I think it will be quite useful to extend tensorflow with the following operator:
tf.get_GradientTape() which can return the actual gradient context manager if there is one.

@wt-huang thank you for the response.
But what if I am not the one who created the gradient context (i.e., in Keras it is created internally) and I do not have access to the tape variable. How can I stop the gradient?
Here is a toy example to illustrate the problem:
import tensorflow as tf

tfe = tf.contrib.eager
tf.enable_eager_execution()

a = tfe.Variable(0.)

def custom_loss(y_true, y_pred)
  #here I want to stop the gradient how can I do so?
  #I can only write the code of the custom loss function

def keras_backprop(loss, model, lr, x, y_true):
  with tf.GradientTape() as tape:
    y_pred = model(x)
    l = loss(y_true, y_pred)
  dw = tape.gradient(l, model.w)
  model.w = model.w - lr * dw
  return w

Actually, I have found a workaround. I can simply wrap the tensor which I want to exclude from the gradient computation with tfe.Variable().
The code would look something like this
def virtual_adversarial_loss(X, DAE_encoder):
r_vadv = tfe.Variable(generate_virtual_adversarial_perturbation(DAE_encoder, X))
p = tfe.Variable(DAE_encoder(X))
q = model(X+r_vadv)
loss = tf.reduce_mean(kl(p, q), axis=0)
return tf.identity(loss, name="vat_loss")
But obviously, this is not intuitive at all.

import tensorflow as tftfe = tf.contrib.eagertf.enable_eager_execution()a = tfe.Variable(0.)def custom_loss(y_true, y_pred)  #here I want to stop the gradient how can I do so?  #I can only write the code of the custom loss functiondef keras_backprop(loss, model, lr, x, y_true):  with tf.GradientTape() as tape:    y_pred = model(x)    l = loss(y_true, y_pred)  dw = tape.gradient(l, model.w)  model.w = model.w - lr * dw  return w

@nairouz Glad you found a workaround, will close this for now. Feel free to open a new issue if problem persists.

Cc: @fchollet
I think this should be fixed since there is no way to handle the tape in Keras eager execution mode :(


setQueryData does not update the state

Hi!
I wanted to update cached data by using useQueryClient's setQueryData method. But the state returned from useQuery didn't get updated by updating the cache.
Could anyone show me a proper way to sync the state after updating the cache?
Reproduction link
codesandbox.io
Steps to reproduce
Clicking on Update button
What is expected?
data.title should get updated
What is actually happening?
The cache get updated. But the state does not

Hi,
The solution to your problem would be to overwrite the whole object, not mutating a single property.
queryClient.setQueryData("post", (d) => {
    return {
      ...d,
      title: "updated"
    };
  });

I think this is due to Vue watcher being shallow by default for refs. But I might be wrong.


Add TokenLight rule element and toggle to candle

Closes https://github.com/foundryvtt/pf2e/issues/5946

We've had people ask about making torches into an effect to track the duration. We could do that here from the jump. For the life of me I cannot remember why I made torch a toggle, but I remember I did have a reason.


Renaming sprites not working (on Windows)

I try  to rename sprites and it's not working.
For few hours I search for reason but I can't find.
I guess that is possibly connected with AssetDatabase.
I remember I have problems when I use AssetDatabase methods in separete methods. Changes was only saved when AssetDatabase methods are invoked on hightest level method.
I checked meta files and changes are not saved.
It's propably problem with Assetdatabase class on windows.
Do you have similar problem?

Weird behaviour.

I searched problem in AssetDatabase class but everything work fine for me for that momemt.

I found solution. Was easier then I expected :)
We are working on different systems and we have different line endings.

Yes that must be it! Thanks for doing it! If you submit a PR into
develop-v1.2.0 I'll patch it in!
On Sun, Feb 4, 2018 at 5:29 PM Uvi Vagabond<EMAIL_ADDRESS>wrote:

[image: obraz]
https://user-images.githubusercontent.com/20247639/35783142-029fdfbe-0a03-11e8-90c1-ebad648f4493.png
I found solution. Was easier then I expected :)
We are working on different systems and we have different line endings.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/redbluegames/unity-mulligan-renamer/issues/152#issuecomment-362945729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYUKdQLjVXjZErvYs3WvZ1yixPHntADks5tRi9MgaJpZM4R4t96
.

--
Edward Rowe
Developer and Co-founder
Red Blue Games

It's four line of code so it's easier if you change this :)

Ok I will do it when I get a chance. I just realized it should probably be
a regex for either \n OR \r\n then substitute whichever it found back in,
because even if you are on windows the file might have "\n" in it. We need
to make sure to match the file with whatever was in it.
I will submit a fix in the morning tomorrow!
On Sun, Feb 4, 2018 at 5:42 PM Uvi Vagabond<EMAIL_ADDRESS>wrote:

It's four line of code so it's easier if you change this :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/redbluegames/unity-mulligan-renamer/issues/152#issuecomment-362946632,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYUKa8A-3kGF4S5hBIKtey1QuqeknRPks5tRjJbgaJpZM4R4t96
.

--
Edward Rowe
Developer and Co-founder
Red Blue Games

Problem is living and is interesting.
Some of my sprites can be renamed and some can't. And somethimes I can remane one group and sometimes not.
I spent few hours to find why this happening.
When I add new spite (or other assets) to project is created metafile.
Which line endings have metafiles(when are created by Unity)? For Unix platforms.

I as Windows user always changes line endings for non-unix. So when I checking metafiles also I changes line endings non-unix.

Here is a potential problem.
Environment.NewLine will not help.
We must know which lineending is used by metafile in moment of renaming sprites (for that kind of situations).

So solve that problem we should search for \r and \n to find which line ending is used in file.

Should be fixed in develop-v1.2.0 branch, will make a release soon.

Latest beta (v1.2.1b2) should fix this issue.

We saw the same thing you saw with line endings earlier today - I don't know why Unity created Meta files with "\n" line endings on Windows. We couldn't get it to generate a file with "\r\n".
Our fix was instead of "\n" and instead of System.Environment.NewLine, we did "(\r?\n)" and substitute it back in with "$2". Worked for us but we had to force a meta file to CRLF cause we weren't able to get Unity to make one with CRLF.

I checked new version. It's work perfectly.
Monodevelop is my basic script editor and it always ask if I want to change line ending.
By default is set to convert to windows so I always click it.

Gotcha - Woohoo! Thanks for all your help tracking this down :)
On Tue, Feb 6, 2018 at 3:33 AM Uvi Vagabond<EMAIL_ADDRESS>wrote:

I checked new version. It's work perfectly.
Monodevelop is my basic script editor and it always ask if I want to
change line ending.
By default is set to convert to windows so I always click it.
[image: obraz]
https://user-images.githubusercontent.com/20247639/35849035-8554cf46-0b20-11e8-95a7-b584b44b9361.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/redbluegames/unity-mulligan-renamer/issues/152#issuecomment-363348110,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYUKTbG1v1MECPpltJtgVxXbjClySA3ks5tSA5PgaJpZM4R4t96
.

--
Edward Rowe
Developer and Co-founder
Red Blue Games


When i modify the dates change

When i modify the createdAt fields on firestore, they now become _seconds and _nanoseconds in algolia when the fields were initially seconds and nanoseconds. The nanosecondsfield becomes zero

This is a change made by Algolia, they renamed the fields


We do not need to close the socket manually

The motivation for this pr:
We've had some issues with this error in our logs: "The UdpSocket to syslog.cbxone:514 has been closed and can not be written to anymore". The problem seems to be that that send is being called after the socket has been closed. This lead us down the rabbit hole of "when is an object destructed. My colleague who did the deep dive wrote:
PHP docs say this about __destruct(): "The destructor method will be called as
soon as there are no other references to a particular object, or in any order
during the shutdown sequence.". Monolog will attempt to close the socket via
AbstractHandler::__destruct() but if this occurs during the PHP "shutdown
sequence", it seems a send() may actually come after this which triggers an
error: "The UdpSocket to syslog.cbxone:514 has been closed and can not be
written to anymore".
Using strace I have verified that PHP closes the socket itself during shutdown,
even with FPM (which reuses PHP processes), so the __destruct behavior is
entirely unnecessary
Thank you so much for an awesome library! :)

Can you describe the full layout of handlers/configuration that you are using? Maybe that'd help me understand what's going on..

Yes, for sure, here is how we set up logging:
$handlers[] = \Monolog\Handler\SyslogUdpHandler(
  "syslog.cbxone",
  514,
  "local6"
);
return new \Monolog\Logger('our-application-name', $handlers);

Hope this helps.


Fix build

Codecov Report

Merging #1633 (93d1c0b) into master (76b6aad) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
- Coverage   86.09%   85.95%   -0.15%
==========================================
  Files          61       60       -1
  Lines        2423     2413      -10
  Branches      130      130
==========================================
- Hits         2086     2074      -12
- Misses        337      339       +2

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.38% <0.00%> (-2.34%)
:arrow_down:

...core/shared/src/main/scala/io/circe/CursorOp.scala
51.72% <0.00%> (-1.41%)
:arrow_down:

...es/core/shared/src/main/scala/io/circe/Error.scala
62.06% <0.00%> (-0.44%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.33% <0.00%> (-0.31%)
:arrow_down:

...nter/src/main/scala/io/circe/pointer/Pointer.scala
89.34% <0.00%> (-0.13%)
:arrow_down:

...in/scala/io/circe/pointer/PointerSyntaxError.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f7b1e...93d1c0b. Read the comment docs.

Codecov Report

Merging #1633 (93d1c0b) into master (76b6aad) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
- Coverage   86.09%   85.95%   -0.15%
==========================================
  Files          61       60       -1
  Lines        2423     2413      -10
  Branches      130      130
==========================================
- Hits         2086     2074      -12
- Misses        337      339       +2

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.38% <0.00%> (-2.34%)
:arrow_down:

...core/shared/src/main/scala/io/circe/CursorOp.scala
51.72% <0.00%> (-1.41%)
:arrow_down:

...es/core/shared/src/main/scala/io/circe/Error.scala
62.06% <0.00%> (-0.44%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.33% <0.00%> (-0.31%)
:arrow_down:

...nter/src/main/scala/io/circe/pointer/Pointer.scala
89.34% <0.00%> (-0.13%)
:arrow_down:

...in/scala/io/circe/pointer/PointerSyntaxError.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f7b1e...93d1c0b. Read the comment docs.


Upgrade to llvmlite 0.19.*

Upgrade to llvmlite 0.19.*
This patch make llvmlite 0.18 incompatible  due to numba/llvmlite#273

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7874e33). Click here to learn what that means.
The diff coverage is 70%.

@@            Coverage Diff            @@
##             master    #2394   +/-   ##
=========================================
  Coverage          ?   86.24%
=========================================
  Files             ?      315
  Lines             ?    59982
  Branches          ?     6516
=========================================
  Hits              ?    51734
  Misses            ?     7199
  Partials          ?     1049


Update from Flast to FastAPI and Add user Table incl. Admin Functiona…

…lity

This is missing for abdou's approach
Define a Pydantic model for the expected request body
class QueryData(BaseModel):
query: str


[1.73] Fix custom dashboard yaml parsing (#701)

Backport of #701

part of https://github.com/kiali/kiali/issues/6771


Return date from evaluate/evaluateHandle

Hi!
First, I've seen #376 and #382 that seems to be related to this problem.
What I understood from #382 is that now it should work fine...?
Anyway, I'm trying to return a Date from these methods but all I get is an empty object:
        const dateHandle = await page.evaluateHandle(() => new Date());
        const date = await dateHandle .jsonValue(); // {}

        const anotherDate = await page.evaluate(() => new Date()); // {}

I'm using puppeteer 2.0.0.
I'm doing some workaround returning the milliseconds and creating a date back on my node app, but that's ugly.
Is it a bug? How can I make this work? 😕
Thanks!

I was also facing the same issue.
The solution of @gerardnico works (serialize it as a JSON-string to pass through page.evaluate).
Nevertheless, I think that this should be fixed by either Puppeteer or Chromium.


Fixes #302: Handle Beginning/End of document arrow keys

When a user typed a Left Arrow at the Beginning of a Document or a Right arrow at the end of a document, SuperEditor's default keyboard action moveUpDownLeftAndRightWithArrowKey would ExecutionInstruction.continueExecution.
Then, the anyCharacterToInsertInParagraph would capture the Key Event and attempt to insert the Special Key into the text.
When moving the arrow key down at the same spot, the moveUpDownLeftAndRightWithArrowKey would actually ExecutionInstruction.haltExecution, which means the special key would not be inserted by anyCharacterToInsertInParagraph.
Therefore, the fix appeared to me to be: haltExecution when a left arrow key is detected at the beginning of a document or a right arrow key is detected at the end of the document. Then, the anyCharacterToInsertInParagraph cannot insert the special character.
Question: returning true/false sets a value named didMove, and we set haltExecution for true or continueExecution for false. Technically, we didn't move the cursor in this instance, but we still want to haltExecution. Should I rename the didMove variable to something like handledMove?

Hm, looks like tests are failing due to using RenderEditable.nextCharacter, which is visible only for testing. There's a comment in the codebase that we may need to copy/pasta it into the project. Should I go ahead and do so?

@brian-superlist I agree that changing the return value technically resolves this issue, but the contract for the method is no longer valid if that change is made.
It looks like the only obvious options are:

Get rid of the bool response from the movement methods, or
Change the calling method to always halt regardless of whether the arrow key causes movement
Don't print a content character for arrow keys

Given that other areas of code may wish to utilize the same movement behavior, and those callers might care about whether a movement actually took place, I don't think it's a good idea to remove the bool response from the method.
I poked around briefly and couldn't find a reason to continue execution. Did you find any use-cases for arrow keys that come after that handler? We can probably get away with halting execution for now. A possible future problem is that we want to take a particular action when an arrow key is pressed at the boundary of a document. If we halt execution no matter what, then we can't install another handler to handle that situation. We'll be forced to edit an existing handler, which should be a last resort.
The final option is to adjust the handler that's printing this key. In theory, it's not supposed to matter if an arrow key makes it to the print handler because we shouldn't be trying to print an arrow character. As I mentioned in my comment on the issue ticket, web issues are predictable because Flutter doesn't appropriately report keys from web. However, I wouldn't expect any print behavior on Mac. Did you check on why that's happening?

Hm, looks like tests are failing due to using RenderEditable.nextCharacter, which is visible only for testing. There's a comment in the codebase that we may need to copy/pasta it into the project. Should I go ahead and do so?

I have a fix for this in my custom text field PR that's open right now. I'd rather avoid conflicts with that PR.

@brian-superlist I agree that changing the return value technically resolves this issue, but the contract for the method is no longer valid if that change is made.

Exactly, that's what lead to my question in my description above: is it safe to slightly alter the meaning of the contract to "handled arrow key" or "handled movement" instead of "did move"? Would there really be a downside in changing the nature of that  contract, since the only place didMove is used is from the moveUpDownLeftAndRightWithArrowKeys KeyboardAction? However, it sounds like you have plans for this particular contract and you want to keep it in place. Fair enough, definitely need to find another option :)
At the moment, I can't think of a scenario where a downstream DocumentKeyboardAction would want to handle arrow key presses, which is why my solution relied on halting execution. I couldn't think of scenario where you'd want to take an action, nor could I think of a good reason to continue passing this keystroke down the chain. Therefore, halting execution at this point seems to make sense to me until we have a concrete use case to allow it to continue.

The final option is to adjust the handler that's printing this key. In theory, it's not supposed to matter if an arrow key makes it to the print handler because we shouldn't be trying to print an arrow character. As I mentioned in my comment on the issue ticket, web issues are predictable because Flutter doesn't appropriately report keys from web. However, I wouldn't expect any print behavior on Mac. Did you check on why that's happening?

I didn't check on why it's happening, but I'm a "fail fast" kinda guy and this feels the most "defensive" approach, therefore it's my least favorite solution. I kind of thought the special character rendering was actually a helpful bug because it exposed bad logic further up the chain. Again, I have very little context on this project thus far having just dived in. If you prefer this solution, I'm happy to dive into why it's being rendered on Mac and see if we can prevent it from rendering.


MB: List Item onPress called when onAnimationEnd

Fix for https://github.com/codypearce/material-bread/issues/218

Updated onPress prop assignment from onAnimationEnd to onPress in order to fire the onPress method when the user intends it

Before:

After:

@mgonzalezs Hey thanks for the PR, I'm getting an error running the ripple example on iOS

@mgonzalezs Fixed! Thanks!


Doesn't use GPU during inference or training

It seems like it's loading the model inside vram, but it's not utilizing the GPU during training or generation. It's using the CPU. I tried adding device_map={'': 0} as some others suggested, but it didn't fix the problem. Currently on bitsandbytes 0.37.0.

Nvm, checked again, and I'm just looking at the wrong graph. It should be CUDA.


Enhance yii\helpers\BaseHtml::checkbox()

Fix a bug when form attribute was not propagated to the hidden input
of the checkbox.

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#13053, #7946

Please let me know if we need a changelog line for this.

Sure we do.

Added the earliest issue to the changelog.

Merged. Thanks!


Cleanup + improve logging

get rid of J_LOGGER and replace with logger.
set up the logger in a more sane way (set it up as a "script" not a "module", as this code mostly will never be imported as a library)
ensure useful warnings+errors are thrown in common cases. previously the client just logged error messages but didn't actually throw errors, now it throws a RequestFailure exception.

cases i tested + ensured they produce useful output with default logging options:
on the client:

notebook is not open / wrong name
server is not running / can't connect to server

on the server:

notebook is not open / wrong name

Ran pytest and checked functionality.

Hmmm, I'm a bit skeptical here. I think there's a reason that I added the calls to disable: https://loguru.readthedocs.io/en/stable/api/logger.html#loguru._logger.Logger.disable
In particular, I think it used to log messages in the actual jupyter notebook when requests were received. Does that no longer happen with these changes?

Otherwise looks good though!

In the notebook? No, definitely haven't seen any logs show up there.
They recommend disabling it if you're writing a library ("Developers of library using Loguru should absolutely disable it to avoid disrupting users with unrelated logs messages."), and previously all the logging was setup as the recommend for a library. But this is not a library - I can't think of a case where we'd wanna import this from some other project.

Oh, I see what you're saying now - essentially this is imported as a library within the notebook kernel. Lemme think about this some more.

Hmm, I tested raising a logger.warning and logger.error from within the notebook extension and they still didn't show up in the notebook. And honestly I'm not sure I would hate it if they did; by default only WARNING and up are shown on stdout and these levels should never happen on normal usage. So I think this is fine?

agree that we'll want to minimize the docs and setup. ideally you have to run like one command and thats it. should be idiotproof

I'm gonna go ahead and merge this, and will have a convo with @brydenfogelman later today about how to keep improving the docs! That feels separate to this PR.


Add Presto FNV-1 hash functions fnv1_32/fnv1a_32/fnv1_64/fnv1a_64

Implements the  FNV-1 hash functions:

fnv1_32
fnv1a_32
fnv1_64
fnv1a_64

Resolves #5434
The implements refers: http://www.isthe.com/chongo/tech/comp/fnv/index.html

The failed workflow  macos-build-macos-intel  seems to be caused by the low version of openssl that folly depends on, and has nothing to do with this pr


build issues doxygen and graphviz in sandbox

what do u think about the necessary fixes to get doxygen/graphviz up in sandbox:
$ git diff
diff --git a/recipes/devel/doxygen.yaml b/recipes/devel/doxygen.yaml
index 145645b..966d7e9 100644
--- a/recipes/devel/doxygen.yaml
+++ b/recipes/devel/doxygen.yaml
@@ -10,8 +10,9 @@ checkoutSCM:
     stripComponents: 1

 buildTools: [flex, bison, dot, python3]
+buildVars: [CXX]
 buildScript: |
-    cmakeBuild "$1"
+    cmakeBuild "$1" -DPYTHON_EXECUTABLE="$(which python3)" -DCMAKE_PREFIX_PATH="$($CXX -print-sysroot)/usr"

 packageScript: |
     cmakePackageTgt
diff --git a/recipes/devel/graphviz.yaml b/recipes/devel/graphviz.yaml
index 7dcb739..af34538 100644
--- a/recipes/devel/graphviz.yaml
+++ b/recipes/devel/graphviz.yaml
@@ -23,6 +23,12 @@ checkoutSCM:
     stripComponents: 1

 buildScript: |
+    if [[ "$(which ps2pdf)" == "" ]] ; then
+        export ac_cv_prog_PS2PDF="true"
+    fi
+    if [[ "$(which groff)" == "" ]] ; then
+        export ac_cv_prog_GROFF="true"
+    fi
     autotoolsBuild $1

 packageScript: |

-DCMAKE_PREFIX_PATH="$($CXX -print-sysroot)/usr" because of find_package(Iconv REQUIRED) will not find iconv... why?
-DPYTHON_EXECUTABLE="$(which python3)" necesssary because of cmake picks python instead of python3 by find_package(PythonInterp REQUIRED), no idea why?!
the missing tools groff and ps2pdf (ghostscript) for graphviz... should we add anyone of them?

What do u think about setting CMAKE_SYSROOT to $CXX -print-sysroot if not empty in cmake class? This would fix it in this case.

Should we add a python executable to all python3 providing tool recipes e.g. by sym-linking to python3?

I think the bob_compat toolchain is currently flawed. It is declared as native toolchain but comes with a sysroot. This screams for such kind of problems.
The python thing is strange. At least in the sandbox /usr/bin/python is a symlink to python3. There is not even a python2 version available.

No. It will be used /usr/bin/python which is python v3. I just expected to use the python, provided by package. But there is no package that provides a tool names python. All python3 packages just provides python3 executables.

I think the bob_compat toolchain is currently flawed. It is declared as native toolchain but comes with a sysroot. This screams for such kind of problems.

not just the compat-toolchain, also the sandbox is not correct IMO:
/toolchain/include/c++/9.2.0/ext/stdio_filebuf.h
/toolchain/include/c++/9.2.0/ext/stdio_sync_filebuf.h
/toolchain/include/c++/9.2.0/tr1/stdio.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/bits/stdio_lim.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/bits/stdio-ldbl.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/bits/stdio2.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/bits/stdio.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/stdio.h
/toolchain/sysroots/aarch64-bob-linux-gnu/usr/include/stdio_ext.h
/toolchain/lib/gcc/aarch64-bob-linux-gnu/9.2.0/include/ssp/stdio.h

we build glibc in sandbox, and build a host-toolchain, but do not copy it into default locations (/usr).
that is also the blocker of the aarch64-sandbox MR.

This is actually correct and done on purpose. These paths are added to $PATH by the host-toolchain. No regular package should find the compiler or use stray include files from /usr/include. It is still a native compiler, though. Just at an unusual location.

No. It will be used /usr/bin/python which is python v3. I just expected to use the python, provided by package. But there is no package that provides a tool names python. All python3 packages just provides python3 executables.

Yes. Currently python is supposed to be around in the sandbox or the host. Otherwise we would need a relocatable python such as you created in the new layer. I would rather avoid that in the basement layer...

wtf. i analyzed the problem. it still doesn't work for ubuntu bionic. no idea why this ever worked.

If you are using stretch or earlier, it also needs to be accessible from inside the chroot jail. From Debian buster and later, this isn't necessary because Linux will use the qemu binary from the host system instead of from the chroot. This means that you can use the dynamically linked qemu on buster or later but not stretch or earlier because the host libraries will not be accessible from inside the chroot.
https://wiki.debian.org/QemuUserEmulation

i also tested it with a plain new ubuntu18.04. no way. in a plain new ubuntu 20.04 it works out of the box.
ubuntu 18.04 is the basesystem of all our linux machines. would be nice, if i could "upgrade" this feature, but didn't work by upgrading some packages, like binfmt-support or qemu-user-static. maybe it's a kernel thing...


OAuth2 Support

Start by telling us what problem you’re trying to solve. Often a solution already exists!
There is a lot of adoption of oauth2. Lot of server relies on/build with oauth2 for authorization & authorization is underneath of oauth2 mechanism. Earlier, okhttp had plugin/works-with "okhttp-signpost" it hasn't become strong weather component, and it's no more live.
https://github.com/pakerfeldt/okhttp-signpost/issues/21
Don’t send pull requests to implement new features without first getting our support. Sometimes we leave features out on purpose to keep the project small.

This is out of scope for OkHttp.    We have a slow methodical release process and try to maintain API stability.  This sort of additional functionality is much better as an optional library that can release on it's own schedule, and have whatever features are needed for users who adopt it.


[L15] Failure of ecrecover function does not revert

Description
Adds a check that ecrecover is able to recover the signer address, which returns 0 if not.
Tested
Unit tests
Other changes
None
Related issues

Fixes #https://github.com/celo-org/celo-labs/issues/315

Backwards compatibility
Yes

Looks like transfer costs changed/e2e tests broken.

Looks like transfer costs changed/e2e tests broken.

I think this was just minor flakiness on circleci/github, I don't think this test should be affected.


Structure of Thermodynamics vs Dynamics

In a sea-ice model, thermodynamics and dynamics are intrinsically connected  (tracers are advected by velocities and rheologies need tracers).
Therefore, it makes sense to have them as the same level instead of one inside the other.
I think it would be nice to modify a bit the current structure as to have an overarching SeaIceModel that contains the necessary prognostic variables (also a bit discussed in #19)

velocities
tracers
thickness
concentration

and

thermodynamics with all the ruleset for freezing/melting/heat exchange (for example SlabIceThermodynamics) that would be calculated in the compute_tracer_tendencies! function
dynamics with all the rulesets for momentum stepping/rheologies/solvers (for example ExplicitMomentumSolver and ViscoPlasticRheology) calculated in the step_momentum! function

Then the tracers to be computed will be required by the thermodynamics argument (a little bit like we do closures now in oceanigans). The velocities would be always 2D fields

Also, this structure generalizes nicely to extension to, for example, a snow model

This makes sense. Here's the current structure of SlabSeaIceModel:
struct SlabSeaIceModel{GR, CL, TS, IT, IC, ST, IS, U, STF, TBC, CF, P, MIT, A} <: AbstractModel{TS}
    grid :: GR
    clock :: CL
    timestepper :: TS
    # State
    ice_thickness :: IT
    ice_concentration :: IC
    top_surface_temperature :: ST
    ice_salinity :: IS
    velocities :: U
    # Boundary conditions
    external_heat_fluxes :: STF
    heat_boundary_conditions :: TBC
    # Internal flux
    internal_heat_flux :: CF
    # Melting and freezing stuff
    phase_transitions :: P
    ice_consolidation_thickness :: MIT
    # Numerics
    advection :: A
end

I'm not so sure about where tracers belong. For example, some tracers may be 2D (not sure which...) but some are certaintly 3D in a multilayer model, like energy, temperature, salinity, porosity.
There are also abstraction issues to sort out regarding the grid for a multilayer model. It could make sense to use a 3D grid for a multilayer model, where "z" would be a non-dimensional coordinate varying from 0, 1. But another possibility is to use a 2D grid and organize the data differently somehow...

We could always provide a 3D grid which would fix the number of levels in a multilayer model and then force the 2D variables  to live in Nothing in the z-direction

Indeed, there is no challenge with having 2D variables on a 3D grid. We have designed the system to support that.
The hard question is what is clearest for users. In terms of implementation I don't think it matters much what we choose.


Add the link to verigreen in the hook message.

Add the link to verigreen in the hook message so that it is easier to monitor it.

fixed.


Tabbar icon state not changed.

BottomBarTab iconView state not changed. Could you set selected for iconViews on select and deselect functions. So we can use a selector drawable for icon.
void select(boolean animate) {
isActive = true;
iconView.setSelected(true);
...
}
void deselect(boolean animate) {
isActive = false;
iconView.setSelected(false);
...
}

this is currently in PR

It's now possible with version 2.2.0 and up, see the README.


Fix - App generated by react-juce fails to render

Steps to reproduce

Following "Integrating Your Project" guideline, generate JS project using:

cd packages/react-juce
npm run init -- ~/MyProject/Source/jsui

and build it
cd ~/MyProject/Source/jsui
$ npm start

Point JUCE application to your JS build as described in guideline
Compile and run application

Result
Error in console:
Error: {}
    at [anon] (/Users/vladislavvoinov/libs/blueprint/react_juce/duktape/extras/console/duk_console.c:49) internal
    at error () native strict preventsyield
    at jn (main.js:5098) strict
    at [anon] (main.js:5098) strict
    at me (main.js:5098) strict
    at ye (main.js:5098) strict
    at Hr (main.js:5098) strict
    at Br (main.js:5098) strict
    at Wr (main.js:5098) strict
    at Rr (main.js:5098) strict
    at cr (main.js:5098) strict
    [...]

==== Error in JavaScript runtime. Context: ====
ctx: top=1, stack=["TypeError: undefined not callable (property 'addChild' of [object Object])\n    at [anon] (/Users/vladislavvoinov/libs/blueprint/react_juce/duktape/src-noline/duktape.c:65639) internal\n    at [anon] (main.js:5089) strict\n    at [anon] (main.js:5089) strict\n    at [anon] (main.js:5098) strict\n    at nr (main.js:5098) strict\n    at rr (main.js:5098) strict\n    at or (main.js:5098) strict\n    at Br (main.js:5098) strict\n    at Wr (main.js:5098) strict\n    at Rr (main.js:5098) strict\n    at cr (main.js:5098) strict\n    [...]"]

TypeError: undefined not callable (property 'addChild' of [object Object])
    at [anon] (/Users/vladislavvoinov/libs/blueprint/react_juce/duktape/src-noline/duktape.c:65639) internal
    at [anon] (main.js:5089) strict
    at [anon] (main.js:5089) strict
    at [anon] (main.js:5098) strict
    at nr (main.js:5098) strict
    at rr (main.js:5098) strict
    at or (main.js:5098) strict
    at Br (main.js:5098) strict
    at Wr (main.js:5098) strict
    at Rr (main.js:5098) strict
    at cr (main.js:5098) strict
    [...]

and on the screen(orange background + traces).
Fix
Turned out, template used in command
npm run init -- ~/MyProject/Source/jsui
has old version of react-juce, which expects "BlueprintNative" object to have a "addChild" method which is not supported:
// from the ReactApplicationRoot.cpp, no addChild provided for __BlueprintNative__
...
    void ReactApplicationRoot::bindNativeRenderingHooks()
    {
        const auto ns = "__BlueprintNative__";

        engine->registerNativeProperty(ns, juce::JSON::parse("{}"));

        engine->registerNativeMethod(ns, "invokeViewMethod", [this](const juce::var::NativeFunctionArgs& args) -> juce::var
        {
            jassert(args.numArguments >= 2);
            const ViewId       viewId = args.arguments[0];
            const juce::String method = args.arguments[1];

            const juce::var::NativeFunctionArgs methodArgs(args.thisObject, args.arguments + 2, args.numArguments - 2);
            return viewManager.invokeViewMethod(viewId, method, methodArgs);
        });

        addMethodBinding<1>(ns, "createViewInstance", &ReactApplicationRoot::createViewInstance);
        addMethodBinding<1>(ns, "createTextViewInstance", &ReactApplicationRoot::createTextViewInstance);
        addMethodBinding<3>(ns, "setViewProperty", &ReactApplicationRoot::setViewProperty);
        addMethodBinding<2>(ns, "setRawTextValue", &ReactApplicationRoot::setRawTextValue);
        addMethodBinding<3>(ns, "insertChild", &ReactApplicationRoot::insertChild);
        addMethodBinding<2>(ns, "removeChild", &ReactApplicationRoot::removeChild);
        addMethodBinding<0>(ns, "getRootInstanceId", &ReactApplicationRoot::getRootInstanceId);
        addMethodBinding<0>(ns, "resetAfterCommit", &ReactApplicationRoot::resetAfterCommit);
    }
...

Wow, an oversight on my part! Great catch, thank you

Wow, an oversight on my part! Great catch, thank you


Add in documentation for colcon-ed

Addresses https://github.com/colcon/colcon-ed/issues/12
This PR adds the documentation for colcon-ed .
I added in another verb inside the reference folder.
Bug Report
I also find that in PR #68 and my own CI log there is an error during sudo apt-get update
It is mainly due to some google-chrome keys couldn't be verified. I added in a simple fix that will add the updated keys for google. I am not sure it is the best solution, but it does the job for now.
https://github.com/colcon/colcon.readthedocs.org/blob/c3e89cd231301b12b1da91a4769928a22db47e9e/.travis.yml#L6

Thanks for updating the docs.


Add a license?

Hi @whoisryosuke - just took a look at this repo and would love to take it for a spin. Would it be possible to get a license added to the repo? Thanks!

Oh funny, I didn't notice it was missing one 😅 Tossed one up in the latest master branch. Thanks for catching that 👍

Thanks @whoisryosuke!


[Documentation Issue] Please provide up-to-date docs on "ambient_sound_interval"

The current documentation of the minecraft:ambient_sound_interval is out of date and does not have good examples of the new supported syntax for molang usage which can be found in the latest Allay mob behavior files.
Please update the examples and documentation on this component to show that molang is supported and fully documents the structure and any other missing arguments/parameters.
My suggestion to the docs team is to go and check for all 1.19 behavior additions for any other changes that were not mentioned or noted in any official changelog having up-to-date documentation is very important for creators in the community and ones that work full-time on the Minecraft Marketplace if you need any help, I'm happy to volunteer my time.
My gut tells me if this was missed then some other stuff was missed as well.
      "minecraft:ambient_sound_interval": {
        "value": 5.0,
        "range": 5.0,
        "event_name": "ambient",
        "event_names": [
          {
            "event_name": "ambient.tame",
            "condition": "query.is_using_item"
          },
          {
            "event_name": "ambient",
            "condition": "!query.is_using_item"
          }
        ]
      }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be9623a9-fdc3-0d63-3680-28446d8aae6b
Version Independent ID: e751da80-5106-7d8c-5382-e81f623a0e57
Content: Entity Documentation -minecraft:ambient_sound_interval
Content Source: creator/Reference/Content/EntityReference/Examples/EntityProperties/minecraftProperty_ambient_sound_interval.md
Product: gaming
GitHub Login: @v-josjones
Microsoft Alias: v-josjones

Hello!
It looks like we've made some progress on this. Since it's been a while, I'm going to close this issue, but if you have any additional feedback, please reach out to us!
Thanks!


nothing important

use { } for variables
use unset instead of =""
use -z instead of = ""
delete unused variable $encoding

Always important! Thank you!


Update Site-Wide Settings

https://nus-cs2103-ay2223s1.github.io/website/schedule/week7/project.html#2-update-project-website-aboutus-readme

This is a typo. Should be _config.yml


Simplify non-integer code

I've used this test code (adapted from the C++ reference implementation) to check that the Golden test cases give the same results: https://gist.github.com/csoroz/fc337aad325417526f5b153e70502f28

It seems the suggested change is needed

Hmm, I don't understand why is needed. Do you mean that the Show constraint is unnecessary here?
There are other cases where Show is not required. In fact the only functions that need the Show constraint are ln' and lncf because they show the argument in the error case, and (***) as it uses ln'.

I got a compilation error with stack build for this redundant constraint, it didn't appear because of buildkite not running, I think

Oh, I see. It's due to the compiler flags -Wredundant-constraints and -Werror. I was compiling with -Wall only.

yes, we changed to very strict options recently
On Tue, Aug 6, 2019 at 11:32 AM csoroz<EMAIL_ADDRESS>wrote:

Oh, I see. It's due to the compiler flags -Wredundant-constraints and
-Werror. I was compiling with -Wall only.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/cardano-ledger-specs/pull/698?email_source=notifications&email_token=AATYOTBBLRI3GL7MK3NXED3QDFAKFA5CNFSM4IH5GNS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3URGDQ#issuecomment-518591246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATYOTFWYDENNWLVSO56OQDQDFAKFANCNFSM4IH5GNSQ
.

--
Matthias Güdemann
FORMAL METHODS SOFTWARE ENGINEER | AUGSBURG, GERMANY
Website: www.iohk.io http://iohk.io
Skype: matthias.guedemann
Twitter: @mgudemann
PGP Key ID: 0x734ECFFF51BEA8B5
http://iohk.io[image: Input Output] http://iohk.io
[image: Twitter] https://twitter.com/InputOutputHK [image: Github]
https://github.com/input-output-hk [image: LinkedIn]
https://www.linkedin.com/company/input-output-global


fix: clear policies after sign out

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/46680
PROPOSAL: https://github.com/Expensify/App/issues/46680#issuecomment-2291034280
Tests

Sign out of the account with the workspace connected to NetSuite integration (Important)
Sign in with a new account
Navigate to settings > Workspace > Create new Workspace
Navigate to more features > Enable accounting
Go to Accounting > Connect to NetSuite
Upgrade the workspace to Control > Navigate back to Accounting > Click on "Connect" next to NetSuite
Verify that: Netsuite setup page appears, no "Reuse existing connection" appears.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign out of the account with the workspace connected to NetSuite integration (Important)
Sign in with a new account
Navigate to settings > Workspace > Create new Workspace
Navigate to more features > Enable accounting
Go to Accounting > Connect to NetSuite
Upgrade the workspace to Control > Navigate back to Accounting > Click on "Connect" next to NetSuite
Verify that: Netsuite setup page appears, no "Reuse existing connection" appears.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/646d8cb1-b0ae-46b3-bf41-ce5bb06bd0f5

Android: mWeb Chrome
https://github.com/user-attachments/assets/158fbfbf-d865-4e52-9ded-1e158770ce01

iOS: Native
https://github.com/user-attachments/assets/641eb2a8-d489-438a-8e7d-c4ce83953440

iOS: mWeb Safari
https://github.com/user-attachments/assets/0b88308f-18b8-4944-a88f-ca8f1a5206d4

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/6e3380c7-923f-4b2f-8527-9619d8abd965

MacOS: Desktop
https://github.com/user-attachments/assets/3c1f1329-cc23-40e8-91c6-1c7bf34f5277

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
https://github.com/user-attachments/assets/dcf5efc3-8bbd-4910-8b78-ad1d0751fd1b

iOS: Native

iOS: mWeb Safari
https://github.com/user-attachments/assets/e3d39787-d21a-4e50-b22c-d656ed3eaa2a

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/5587a07e-181b-4189-a841-37343eb75988
https://github.com/user-attachments/assets/20e4386b-7884-4580-886e-d58289c48bf5

MacOS: Desktop
https://github.com/user-attachments/assets/6656d4cc-5517-40dd-b2cc-95f8ab731a87

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Incorrect assignability check when using Extract (TS2322)

Bug Report
🔎 Search Terms
extract assignable TS2322
🕗 Version & Regression Information
This is the behavior in every version I tried, and I reviewed the FAQ for entries about Generics, Assignability, and Extract.
Tested with 4.2.3, 4.3.5, 4.4.4, and 4.5.0-dev.20211018.
In 4.1.5, the example using a type alias also fails. Version 4.2 introduced Smarter Type Alias Preservation, which may explain why that example passes starting from 4.2.x.
⏯ Playground Link
Playground link with relevant code
💻 Code
I have attempted to minimize this example as much as possible. The use of Extract to define a field type appears to be significant.
type A<T> = {
    val: Extract<number | string, T>;
};
type A_number = A<number>;

function f1(x: A_number): A<number| string> {
    // Passes type checking.
    return x;
}

function f2(x: A<number>): A<number | string> {
    // Fails type checking with error TS2322:
    // Type 'A<number>' is not assignable to type 'A<string | number>'.
    //   Type 'string | number' is not assignable to type 'number'.
    //     Type 'string' is not assignable to type 'number'.
    return x;
}

🙁 Actual behavior
The type checker reports error TS2322: A<number> is not assignable to type A<string | number> because string | number is not assignable to number. It appears to be checking assignability of a field in the wrong direction, because the assignability check should be whether number is assignable to string | number.
Using a type alias for A<number> does not produce the same error. I was also not able to reproduce this error without using Extract to define a field type.
🙂 Expected behavior
The type A<number> should be assignable to type A<string | number> because it is a simple object type and number is assignable to string | number.

A is contravariant in T because it’s subtracting T from the type rather than using it directly.  A wider type for T will therefore produce a narrower A, so the error is expected.

Possibly related: #43887


Initializers are not allowed in ambient contexts

https://angular.io/docs/ts/latest/cookbook/visual-studio-2015.html
Install TypeScript 2.2 for Visual Studio 2015
It has  "spec": ">=2.2.0 <2.3.0",
But
Your quickstart source package.json:"typescript": "~2.1.0"

Thank you!  That fixed my problem :)
I followed the instructions at https://angular.io/docs/ts/latest/guide/webpack.html and in the package.json file they have:
"typescript": "~2.0.10",
I changed it to:
"typescript": "^2.2.0",
and the initializers not allowed in ambient contexts error when away.
Thank You!

Now I include everything in quickstart-master, I still get the same error.
I saw .angular-cli.json included in quickstart-master. I tried ng serve and got the following error:
The "@angular/compiler-cli" package was not properly installed.
Error: The "@angular/compiler-cli" package was not properly installed.
at Object. (C:\MyProjects\VS_Angular\WebApplication3\node_modules@ngtools\webpack\src\index.js:14:11)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object. (C:\MyProjects\VS_Angular\WebApplication3\node_modules@angular\cli\tasks\eject.js:10:19)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
Can we also build the project via ng serve?
Thanks in advance!!!

Fixed the issue. VS 2015 project file uses TypeScript 2.0 instead of 2.2.

Just did the same. Worked for me too. Thanks a lot.

This repository is now deprecated. The Angular Quickstart project was a nice starting point for creating Angular applications. Now we recommend using the Angular CLI to create new Angular projects.
Starting from 1 November 2017, all the Angular documentation, at angular.io, is based on the Angular CLI.
Let's get started


Arcade app : Garden Crop Duster can't open

Describe the bug
Arcade app : Garden Crop Duster can't open
Steps to reproduce the behavior
1.Download app in https://makecode.com/api/release/arcade/v1.0.16/win64
2.Click Garden Crop Duster in Game Jam
Expect behavior
Community Games can open in editor
Actual behavior
Arcade app : Garden Crop Duster can't open. There shows error "Importing GitHub projects not currently supported"

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.0.16
3.Microsoft MakeCode version: 6.1.42

Now that beta has shipped, I (or anyone, right?) could make a regular share link for the game. Would that be better for the homepage gallery?

If you could that would be great; for the initial release we aren't planning on supporting github projects in the electron app quite yet / that's a future work item

https://makecode.com/_FmcYeLfuRV1W
^ here you go


imageproc support: setting a feature for a certain package only seems not supported (yet?)

:white_check_mark: Cargo supports transitive conditional features just one level deep (See workspace-features-experiment, https://github.com/foresterre/sic/issues/395#issuecomment-626783321 and #410)

I would like to add imageproc operations to sic. For this to happen we need to let sic_image_engine be dependent on imageproc. imageproc however pulls in a lot of code, so for now I would like to be able to build with and without imageproc support. Thus, I wanted to add a feature to sic_image_engine: imageproc-ops = ["imageproc"] and under dependencies imageproc = { version = "...", optional = true }`.
Now, if I can't build sic from the root workspace;
Attempts
Branch: https://github.com/foresterre/sic/tree/experiment/gated-imageproc-feature - (perm link)

workspace toml
image engine toml

(A) Attempt: define feature from workspace root directly

cargo run --features imageproc-ops --  -i .\resources\1x1_a.png -o target/o.jpg

error: Package sic v0.11.0 (\ws\sic) does not have these features: imageproc-ops

if the root crate also defines  the above feature in its manifest, it will only be enabled for the root crate (which sounds logical to me), not the sic_image_engine package.

cargo build --workspace --features 'imageproc-ops';  without imageproc-ops feature in the root results in the same "missing feature" error (A,1); with the empty feature it results in (A,2)

cargo +nightly build --features 'sic_image_ops/imageproc-ops' -Z package-features

error: none of the selected packages contains these features: sic_image_ops/imageproc-ops
(B) Attempt: build with multiple packages

cargo +nightly run --bin sic -p sic -p sic_cli -p sic_cli_ops -p sic_core -p sic_io -p sic_parser -p sic_testing  -p sic_image_engine --features imageproc-ops -Z package-features --  -i .\resources\1x1_a.png -o target/o.jpg

error: The argument '--package ' was provided more than once, but cannot be used multiple times
happens both with this nightly flag and without (it was a trial and error attempt)
(C) Attempt: add feature to every depending package in package manifest
i.e.

[dependencies]
sic_image_engine = { path = "../../components/sic_image_engine", version = "0.11", features = ["imageproc-ops"] }

src: https://github.com/foresterre/sic/blob/experiment/gated-imageproc-feature/components/sic_cli/Cargo.imageproc-ops.toml
This works, but is very inconvenient, as we'll need to change the manifests of several packages for every custom build where we would like to include the imageproc features ...
Workarounds
Second custom manifest

Create a second custom manifest in sic_cli called Cargo.imageproc-ops.toml, and replace the Cargo.toml with this version temporarily when building with the imageproc feature:

create script or cargo-ws(e) [cargo workspace-enhancer <opts...>] if we need to do this a lot
sic_cli_ops = { path = "../../components/sic_cli_ops", version = "0.11.0", features = ["imageproc-ops"] }
sic_core = { path = "../../components/sic_core", version = "0.11" }
sic_io  = { path = "../../components/sic_io", version = "0.11" }
sic_image_engine = { path = "../../components/sic_image_engine", version = "0.11", features = ["imageproc-ops"] }
sic_parser = { path = "../../components/sic_parser", version = "0.11", features = ["imageproc-ops"] }

Open Questions?

Say, cargo would add the possibility to enable a feature for a single crate to unstable features; can we somehow use nightly cargo with a stable toolchain (alternatively, build only the imageproc version with a nightly toolchain)

Related

https://github.com/rust-lang/cargo/issues/6195 (Testing whole workspace with features enabled in some crate(s))
https://github.com/rust-lang/cargo/pull/8074 (Extend -Zpackage-features with more capabilities)
https://github.com/rust-lang/cargo/issues/5015 (This exact issue, building workspaces can't use --features flag)

should now be possible but see (A, 4)

Similarly, sic_parser and sic_cli_ops should add the feature like so: imageproc-ops = []

status: works for https://github.com/foresterre/workspace-features-experiment, but not sic ... (?)

It works, but only for a crate one level deep from the crate where the action is invoked (i.e. the crate where the feature is set must directly depend on the crate where a cargo command is invoked).
In our case this means that sic_image_engine must be a direct dependency on sic (lib); the root crate which includes our main() function. For this to happen, I had to move  the sic_cli crate back into sic itself.
See https://github.com/foresterre/sic/commit/2360a22e39495e988067ec78263fa3f5688c22dc
Documented here: https://github.com/rust-lang/cargo/issues/2851#issuecomment-232431204

Additional workspace support is being discussed in a new RFC (https://github.com/rust-lang/rfcs/pull/2906), currently in its final comment period.


Fixed Array Bounds for Fragment

Changed array bound from FRAGMENT_LENGTH (which is 2187 in trytes) to HASH_LENGTH (which is 243 in trits).

Hey @phil-zxx thank you for your PR!
That's a really interesting change; I'm curious to see the unit test that repros the issue.  The Python implementation has diverged a titch from the other API libraries (mostly because of language-specific optimisations), but depending on the issue, it may have implications for the other projects.

The variable hash_trits is a hash and should always have length 243 (in trits), also indicated by the indices hash_start & hash_end which imply an array length of HASH_LENGTH=243 for hash_trits (see lines 170-172). So when stitching together the digest, each fragment hash should be treated as having length HASH_LENGTH, and not FRAGMENT_LENGTH.
Analogously, say you have an array a = [7,5,2,1] of length 4 and do the following:

a[100:200] = [9,5] with both start & end indices completely out of bound, or
a[4:6] = [9,5] with indices correctly aligned

Python doesn't throw an error in either case, and just appends [9,5] to the current array, giving you a = [7,5,2,1,9,5].
My fix basically changes the current implementation from case 1 to case 2. That is, no change in behaviour at all, but correct indexing.

Ah.  I think I see what you're getting at now.  I'll have to do some more experimentation, but I think you're correct.
One request:  Could we also rename the fragment_start and fragment_end variables?  Just so that another developer doesn't come along later and try to "fix" it back to how it was (:

Added your suggested change.


NNBD. Analyzer issue for '?.' operator

The following code produces an error in analyzer with --enable-experiment=non-nullable
class A {
  void test() {}
  int operator[](int index) => 0;
}

main() {
  A? a = null;
  a?.test();
  a ?.. test();
  a?.[0];

  a = new A();
  a?.test();   // error - The target expression can't be null, and so '?.' isn't necessary. - static_errors_A11_t01.dart:33:4 - unnecessary_null_aware_call
  a ?.. test();
  a?.[0];
}

It's interesting, that if to remove the first part of the checkings then error disappears.
class A {
  void test() {}
  int operator[](int index) => 0;
}

main() {
  A? a = null;
  a = new A();
  a?.test();
  a ?.. test();
  a?.[0];
}

Analyzer finds no any issues in the code above. Why analyzer behaves so strange?
dartanalyzer version 2.8.0-dev.0.0

Retested on dartanalyzer version 2.8.0-dev.12.0. There is static warning instead of error now

See also https://github.com/dart-lang/sdk/issues/40088

See https://github.com/dart-lang/sdk/issues/40088, the correct behavior for this code:
A? a = null;
a = new A();

...is to promote a from A? to A on assignment.
So, both test cases above should start reporting a warning that the target cannot be null.
https://dart-review.googlesource.com/c/sdk/+/144040 implements such promotion.