Document Exit Codes

Brief description of your issue
Please document the exit codes so WinGet can be used in batch files.

If you are referring to exit codes coming from installers, they could be nearly anything. The exit codes from MSIX, and MSI installers are well documented. For EXE installers, it depends on the publisher when they package their application. We do have an ability to map expected return codes from EXE installers to more standardized error codes in the manifest.

#1278

Is this what you are referring to?

I think they mean the exit codes returned by winget itself, not the installers, i.e. the ones defined in AppInstallerErrors.h
Something like "0x8A150008 means that downloading the installer failed; 0x8A150109 means that the installer needs a reboot to finish; etc." So somebody could call winget in a script, and handle each error differently.

@lechacon exactly

+1

To put a little more meat on this problem - it's not uncommon that a bit of a script might have a goal like: "Ensure that such&such a package is installed and at the latest version".  Right now, if you want to validate that the installation happened, you have to check your exit code against everything that the installer might do (which can often be summed up by 'if it returns 0, it succeeded') plus everything that WinGet might do.  If WinGet decides the package is already current and up-to-date, it exits with APPINSTALLER_CLI_ERROR_UPDATE_NOT_APPLICABLE, so an install script has to check not just against zero, but also against -1978335189.

PR https://github.com/microsoft/winget-cli/pull/3202 added a doc listing exit codes returned by WinGet
https://github.com/microsoft/winget-cli/blob/master/doc/windows/package-manager/winget/returnCodes.md
cc @denelon if this needs to be closed

https://github.com/microsoft/winget-cli/blob/master/doc/windows/package-manager/winget/returnCodes.md


RNPM link script is not working on 0.29 applications

Reference #37 , we should update rnpm script so that the installation could be easier.
@joeferraro

+!

+1

+1

+1 , how to manual import. my RN is 0.31

+1

Hey there.
For manual importing u can add several lines in this files (on android):
MainApplication.java
...
import com.psykar.cookiemanager.CookieManagerPackage;
...
@Override
protected List getPackages() {
return Arrays.asList(
new MainReactPackage(),
....,
new CookieManagerPackage()
);
}
android/app/build.gradle
dependencies {
...
compile project(':react-native-cookies')
}
android/settings.gradle
include ':app', ..., ':react-native-cookies'
...
project(':react-native-cookies').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-cookies/android')
After that you should reinstall your app on device/emulator with react-native run-android.
And everything should work
P.S. For ios, as i remember, you need to add react-native-cookies xcode project to libraries list of your xcode project. May be something else, but im not sure

Not working on 0.31 😢

Cheers @liquidprogrammer


[Fix] end_level is the index of the end input backbone level

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
end_level is the index of the end input backbone level, so end_level=-1 is equal to end_level=self.num_ins  - 1
Modification
To fix the bug, just change the if condition
To fix the bug, just change the if condition
To fix the bug,  we need to change the if condition
if end_level == -1 or end_level == self.num_ins - 1
and add 1 for some variables.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

@Czm369 ci failed

We should not only test assertion errors, but also test the cases when they can run normally.


BUG: Remove assert from matrix widget that flooded application log

Each time a ctkMatrixWidget was shown, a series of errors about width and height mismatch flooded the log, making it harder to read. Since these mismatches do not seem to have any consequence on function, it seems to be more advantageous to remove the asserts.

A block of warnings like this appeared on each show of matrix widget:
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->columnWidth(j) == newWidth` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  242
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->columnWidth(j) == newWidth` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  242
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->columnWidth(j) == newWidth` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  242
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->columnWidth(j) == newWidth` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  242
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253
[WARNING][Qt] 09.06.2021 14:53:51 [] (unknown:0) - Assertion `this->Table->rowHeight(i) == newHeight` failed in  /home/csaba/Devel/cR/CTK/Libs/Widgets/ctkMatrixWidget.cpp  line  253

Thanks @pieper !


Smart completion for XML files

We should also do smart completions for XML files so you can edit Camel endpoints there as well.
This requires an XML reference
https://github.com/davsclaus/camel-idea-plugin/blob/master/resources/META-INF/plugin.xml#L26
And find out how to do that.
There is some IDEA plugins that can do this.
https://github.com/JetBrains/intellij-community/tree/master/plugins
Maybe xpath
https://github.com/JetBrains/intellij-community/blob/master/plugins/xpath/xpath-view/src/META-INF/plugin.xml#L159

Yay we now have xml support as well


OCPBUGS-31745: TaskRun status is not displayed near the name

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31745
Analysis / Root cause:
Status was not added for TaskRun details page heading
Solution Description:
Added the status value in heading
Screen shots / Gifs for design review:
---Before--

--After--

Unit test coverage report:
NA
Test setup:
1. Create a TaskRun and go to details page

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/retest

/cherry-pick release-4.15


take &str arguments instead of String

It is better to take &str arguments for just reading it.
Using String requires extra memory allocation in some cases.

@paq LGTM! thx.
When I wrote this, I didn't know rust civility.
So it's very helpful!

@paq LGTM! thx.
When I wrote this, I didn't know rust civility.
So it's very helpful!


Follow ups from add unmatched parameters support to our built-in components

While doing https://github.com/aspnet/AspNetCore/issues/5071 - I left two things untouched that seem like they need some discussion.

Should we remove the Id and Class parameters from EditForm and InputBase<>?
Making these attributes first class makes it obvious that you can set them, and these components have some special handling for class. We need to make a design decision here on what this experience should be like.

Should we rewrite NavLink to use this new feature?
NavLink already functionally has this behaviour. There's a big comment in NavLink about how it was intentionally written at a low level of abstraction that scared me away from making this change. We could do this easily and it would simplify the codes, but I want to make sure I'm not throwing away something valuable.

Note: this sounds like code cleanup, but it's not purely that. We have to make a decision about the API surface and direction for built-in components.

See Steve's comments here: https://github.com/aspnet/AspNetCore/pull/10712#issuecomment-498203147


add Choosing approach and Spinning node section in Run a Node's Overview page

What

Add Choosing an approach and Spinning up the node section under Run a Node's Overview page
Delete Approach section

Refs

Ethereum's post "SPIN UP YOUR OWN ETHEREUM NODE"

What

Fix typo and deprecated link in Bridge page


[rtl,rv_core_ibex] Mask off lower bits of mapping address

Previously to this change software had to set the lower bits of the mapping address to 0 otherwise the address translation would produce an incorrect result.
Same fix as https://github.com/lowRISC/opentitan/pull/23178 but on integrated branch

CHANGE AUTHORIZED: hw/ip/rv_core_ibex/rtl/rv_core_addr_trans.sv


npm run dev is caught in deprecated packages

Describe the bug
Running into deprecated packages and execution errors.
A few errors:

node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.
node:internal/crypto/hash:67 this[kHandle] = new _Hash(algorithm, xofLen);
details.family.toLowerCase is not a function

To Reproduce
Steps to reproduce the behavior:

nvm install --lts
npm install @vue/cli
Do steps in README
Run into errors when running npm install
Run into errors when executing npm run dev

Expected behavior
Install node/npm and vuejs as described in the README and run npm run dev to develop/test the application
Wishing for
Maybe provide a Docker-Image, or pin the required package versions in a script.

@zwoefler can you attach your the screenshot ?

Closed as no response


add: VEX Feed to repository

Adding the directory which contains the OpenVEX data for this repository.
The files stored in this directory are used as templates by
vexctl generate when generating VEX data for a release or
a specific artifact.
To add new statements to publish data about a vulnerability,
download vexctl
and append new statements using vexctl add. For example:
vexctl add --in-place main.openvex.json pkg:oci/test CVE-2014-1234567 fixed

That will add a new VEX statement expressing that the impact of
CVE-2014-1234567 is under investigation in the test image. When
cutting a new release, for pkg:oci/test the new file will be
incorporated to the relase's VEX data.
What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

Add VEX Feed to the release process

This was proposed by @puerco and SIG Release for all k8s subprojects, as a prerequisite for automating VEX generation.

OK, this one LGTM. We need to kickoff the VEX generation but for now the initial feed seems right.
/lgtm
/ok-to-test

Thanks @hrittikhere!
/approve


Unit test workflow

Summary
Unit test workflows are added to the repository.
Changelog

[x] workflows folder with matlab action created
[x] test_GnssRX which includes (first) MATLAB unit test added

workflow runs accordingly.


Tar truncates the first character of filename when using CreateEntryFromFile

Steps to reproduce

Create an output Tar Archive
Set the root path to an empty string (this happens when our code receives a relative path, so rootPath = GetDirectoryName(targetFile)).
Call CreateFileFromEntry using the filename targetFile - the tarEntry has the correct name property.
Call WriteEntry.
Check the generated output - the filename in the generated archive is missing the leading character.

Expected behavior
The filename in the archive should be the same as what is written.
Actual behavior
The filename in the archive is missing the leading character.
Version of SharpZipLib
1.1.0
Obtained from (only keep the relevant lines)

Package installed using NuGet

I haven't tested it, but maybe the check @
https://github.com/icsharpcode/SharpZipLib/blob/afcccb09488ac2cd0ed701b52b17a5959dee5a41/src/ICSharpCode.SharpZipLib/Tar/TarArchive.cs#L787
should be checking if rootPath is empty rather than just null?

Yep - that seems like the problem. I just did a quick test, and switching that for String.IsNullOrEmpty seemed to fix the problem.
I opened a pull request with with the small change.


feat(talks overview): add talks overview page

It looks like the theme value is not properly set for the navigation bar


Add .row-column or just .column class and to make columns easier

So we can have columns with buttons all at the bottom and cool flex stuff like that.

https://github.com/JiveDig/flexington/pull/10


'Adding Feature' emoji

Because there is no way to represent an added feature.

Features are often split over multiple commits unlike many of the other emoji so it seems less useful.
We also don't want to encourage checking in code with known issues so definitely don't want an emoji for that.


Add optional emoji field to Activity object and the new activity type

With the addition of allowing custom statuses. There is now an optional emoji field (here) and also another type of an activity.

I think this is already covered


Feature/advanced query from file

Description of change
Implements the ability for alerts search and security-data (search|send-to) commands to read --advanced-query arg from a file.
If the argument string for --advanced-query does not begin with an opening brace {, the CLI assumes the argument is a filename, and will try to open and parse the file as JSON. Helpful error messages are printed if the file can't be read or the JSON can't be parsed.
--advanced-query is still incompatible with all other query arguments, but it can now be used with a checkpoint.

@kiran-chaudhary when you get a chance can you re-review/approve this, assuming that the changes you requested have been addressed?
As an FYI, if you request changes, this makes it so that the change cannot be merged until you approve (even if someone else approves).


Update .openpublishing.publish.config.json

Docs Build status updates of commit ca9bcf1:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit ca9bcf1:
:clock10: Full build: the average full build time is 183 min(s) 47 sec(s), this is based on the last 4 build(s) for this repository.
:warning: This is a FULL build due to a recent Docs Build service upgrade, normally no action is required on your part. In the result you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'master' branch. For more detailed info, please click here.

Docs Build status updates of commit ca9bcf1:
:clock10: Full build: the average full build time is 183 min(s) 47 sec(s), this is based on the last 4 build(s) for this repository.
:warning: This is a FULL build due to a recent Docs Build service upgrade, normally no action is required on your part. In the result you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'master' branch. For more detailed info, please click here.

Docs Build status updates of commit ca9bcf1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Set authentication on route conditionally

I wanted to know how I can do authentication on a route conditionally.
Suppose, I wanted to have a cards route which is visible only to the authenticated users. Now, a user can make the card public and the card will be visible to the unauthenticated users also.
How can I achieve this functionality?
So, here, we can set some flag once the card is public and make the route authenticated or unauthenticated based on the flag.

You can simply override the beforeModel method and conditionally check for the session's authentication state - see the implementation of beforeModel in the AuthenticatedRouteMixin (which you wouldn't use in that case of course).
Please ask questions like this on stackoverflow.com though and use github for issues only.


Accidently installed docker snap while having docker dpkg installed.

Hi, I am having a rather annoying issue, while I was messing around in a VM I apparently disconnected through SSH. I happily did sudo snap install docker  on my host machine that was running a few development containers. After noticing my mistake I uninstalled the snap package, but it was already too late.
I attempted to remove and reinstall my normal docker install but that didn't helped. Basicly docker can not remove/stop/kill/start containers because permissions issues.
Starting
ERROR: for db  Cannot start service db: mkdir /var/run/docker/libcontainerd/containerd/15cb2e0b612ac94ea3a48a16f94c045dbeb02a90867d106169022459b8576674: file exists

Stopping a new container
Cannot stop container e51a26232f662a497c2523224f811d78ab9b5786d1acff27271a32ea4f6cff59: Cannot kill container e51a26232f662a497c2523224f811d78ab9b5786d1acff27271a32ea4f6cff59: rpc error: code = 7 desc = permission denied

It wouldn't be that bad if I could get 1 container running to get the prepared data of a postgresql container.
As for the issue. It would be nice if the snap package fails to install if an older docker installation has been installed.
Thank you

I solved my issue, the snap docker actually was already running some of my containers, but upon removing the snap package it didn't correctly shut those down. Creating zombie processes of docker-containerd-shim. I don't know if it is worth looking into this tho. Restarting the server cleaned those up and I was abbe to restart my containers.

Thanks for the feedback.  The snap and non-snap versions don't get along well, so we don't support upgrading from one to the other (discussed previously -
https://github.com/docker/docker-snap/issues/4).  In general since they store data in different places, most of the problems are related to apparmor profiles, which a reboot can help with.  I don't think it makes sense to try to have the snap detect this scenario.  I'll keep an eye out for the zombie issue.  Closing, but feel free to continue the conversation. :+1:


Validate compose v2 input

Compose v1 has input validation but in the composev2 merge function validation was missing so added it.
Fixes #357

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "validate_composev2" git@github.com:surajssd/libcompose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "validate_composev2" git@github.com:surajssd/libcompose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

validateServiceConstraints uses the v1 schema, so I don't think this should be used here. There's also a second piece to validation, which is calling validate. To support v2 validation, we'll have to make separate versions of these two functions.
Creating the v1 versions of these functions took a bit of fiddling to get error messages that resembled those of Docker Compose. To make sure v2 versions work properly, we'll probably want to create separate versions of the validation unit tests as well.

@joshwget what all other validations would you like to see in compose v2? Because in the validateServiceConstraints we have basic image, build and dockerfile checks, what all would you wanna have?

I think it would be good if all keys were validated, as with v1. The dockerfile key has changed from v1 to v2, so reusing v1 validation here will give false errors.

@joshwget made changes according to the new schema and also added the error message which is similar to docker-compose.

@joshwget I am having hard time debugging tests. While doing normal run(build binary and run on docker-compose files)

I saw that schemaLoader is <nil> before running setupSchemaLoaders in validate.
Also after calling setupSchemaLoaders the value of schemaLoader has field "id":"config_schema_v1.json"

But when running it in tests(go test github.com/docker/libcompose/config/)

same schemaLoader has some data already in it. So I am getting that error Invalid type. Expected: object, given: schema.
Also after calling setupSchemaLoaders the value of schemaLoader has field "id":"config_schema_v2.0.json" which is different than normal run!

How we load the schema could definitely be improved. This is something I've been meaning to refactor for a while to support custom schemas. Fixing the issues around loading the schema might be a prerequisite to v2 validation, unfortunately :sweat:

@surajssd In #371 I address some of the issues you were running into here. I also refactored the tests a bit so it'll be easier to write tests for service constraint validation. Once it's merged, would you mind rebasing this PR on top of that? I'd be happy to help with this!

@joshwget yes sure :+1:


Bug: Make Error Suppression Facility Dropdown Update when Searching

#4776 allowed for searching, but when a user types in the search box, the list of displayed facilities in the dropdown does not change. The first entry with matching characters is highlighted, but if it is not in the first few, the user must scroll down to see it which deselects it.
Given a user has navigated to the error suppression page,
When they type in the Facility dropdown,
The list of facilities displayed in the dropdown will change to match the typed text.
https://projects.invisionapp.com/freehand/document/1dwq6maiy?zoomToItems=Y2xka2VhdDhwMDExMDNiNzRlMGUyb2w4Mw%3D%3D

Error Suppression Facility Dropdown Updates when Searching


Ensure session store complete before redirect

I'm converting session storage for an app from MemoryStore to connect-couchdb. The login page is now flaky, and I think it is because the new session storage is slow enough that it has highlighted a race.
It looks like the successful login is redirecting (in our case successReturnToOrRedirect: '/'), and the 'session get' for / occurs before the 'session set' has written to the database. I've used some extra logging through the connect-couchdb and passport code to confirm this.
Is there a way to make sure req.session.save is called and completes before res.redirect gets called on success? The optional callback you can pass into authenticate() replaces all builtin handling, I was hoping for a solution where it can be augmented.
Any thoughts on this?
Cheers,
Eddie

Did anyone find a solution/workaround for this? I find this is very troublesome. The same issue exists in connect-ensure-login (they are probably written by the same person after all), but that one is much easier to fix (jaredhanson/connect-ensure-login#28). This one seems very complicated though.


[Bug]: Built-in ruby webrick service error in Shopify CLI 3.x

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Extension
Expected behavior
Theme extensions for Shopify CLI 3.x work fine on <IP_ADDRESS>:9292
Actual behavior
Actually I have the following problem when using the Dawn theme

Stack trace
None,I don't know how to debug

Reproduction steps

generate theme extension in shopify cli 3.0
serve app and theme extension
create product and add to cart , then the issue come

Operating System
Ubuntu 20.04
Shopify CLI version (check your project's package.json if you're not sure)
3.39.0
Shell
bash
Node version (run node -v if you're not sure)
v18.14.2
What language and version are you using in your application?
Ruby 3.1
Has any update @shopify

This problem has been solved by my efforts.@Shopify


Camera3D cannot be selected by clicking the gizmo

Godot version
4.0-alpha14
System information
W10
Issue description
Camera3D can't be selected by clicking on the gizmo. I would expect it to have some clickable bounding box for use in editor.

Steps to reproduce

Add Camera3D node to scene, as root or anything else.
Try to select it by clicking the gizmo, or region select.

Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/53083.


Use the CTPUG build as source for the travis badge

So the badge is accurate.

Targetted incorrect tree.


refactor: rename to CustomAuth

Please check the following:

Please update the documentation
Why are there 2 folders, auth and directAuth ?
Verison bumps are incorrect.
Duplicate podspecs

@rathishubham7 made changes, pls review again.


Fixed/Default height

I haven't played around with the plugin that much yet, but off the top of my head, then I would love an option for a fixed height as well or a default height If that's possible.
Thanks in advance

Due to presentation in columns, the images are sized primarily based on width. How would you imagine the height setting to work? Perhaps by cropping images to fit?


kcd-recompile / Watching nested properties

Hi,
First, thanks for the great directive kcd-recompile.
I noticed that it's no possible to watch for nested properties in the current directive.
For instance, let's suppose in the controlleur:
$scope.person = {};
$scope.person.mud = 'happy';

In HTML I would have (inside an ng-repeat="persons"):

   {{::person.mud}}

However, as a nested property, recompilation would not happen if I do:
$scope.person.mud = 'sad';

The fix that I did is to add the argument "true" to the watch made by the directive like so:
var stopWatching = scope.$parent.$watch(attrs.kcdRecompile, function (_new, _old) {
                        var useBoolean = attrs.hasOwnProperty('useBoolean');
                        if ((useBoolean && (!_new || _new === 'false')) || (!useBoolean && (!_new || _new === _old))) {
                            return;
                        }
                        // reset kcdRecompile to false if we're using a boolean
                        if (useBoolean) {
                            $parse(attrs.kcdRecompile).assign(scope.$parent, false);
                        }

                        // recompile
                        var newEl = $compile(template)(scope.$parent);
                        $el.replaceWith(newEl);

                        // Destroy old scope, reassign new scope.
                        stopWatching();
                        scope.$destroy();
                    }, true);  //here, adding true to enable watch on nested properties

Is it possible to merge it in the current directive? Or better: adding it as an option:

What do you think?
Thanks.

Would it make sense to handle detection for the user automagically? Speaking from personal experience, It's not very common to look for the existence of an object in itself - it's a lot more common to look at the existence/changes of properties in said object.
Sort of like so:
scope.$watch(attrs.kcdRecompile, function(_new, _old) {
  /** redacted **/
}, typeof $parse(attrs.kcdRecompile)(scope) === 'object'); // true|false;

I do apologise if this is considered a necro.

@kasperlewau, nope you're good. That's a good idea. I don't really use kcd-recompile at all, but I'd happily accept a PR that updates it to do as you illustrated :-)

@kentcdodds Curious why you are not using kcd-recompile anymore. Is there a better way?

I just don't do Angular anymore


Modify color scheme to be more consistent with the base16 ecosystem

as a base16 user, I think the colors didn't fit very well with the rest of the templates, I think this way it was better.

@gnsfujiwara there are some conflicts, can you update the PR. The github actions file has been created, so if you remove that pull from upstream and re-run the builder on this template, things should be good. I would do those changes for you but I'm unable to edit this PR.

Ok, i've added you as a contributor

@gnsfujiwara I didn't have the permissions to change anything in your repo it seems, but I created a branch on this repo with your changes.

One important thing to note about this PR is that is looking at your master branch, even though currently that branch doesn't exist on your github repo.

You can get this PR to reflect your master branch by doing the following:
$ git checkout main # Make sure you're on the main branch
$ git remote add upstream https://github.com/tinted-theming/base16-dunst.git # If you haven't already done this
$ git fetch # fetch the upstream data
$ git br -D master # Delete your local version of master branch
$ git checkout -b master # Create a new version of local master branch
$ git reset --hard upstream/jamy/feature/gnsfujiwara # Make master equal to the branch I made
$ git push --force origin master # You may not need the `--force`, but if you have that branch on your github repo, that will overwrite it

Once you've done that this PR should be updated.
Alternatively, if you don't want to work off of the old master branch (and keep this PR closed), you could create a new PR using a feature/modify-color-scheme branch by doing this:
$ git checkout -b feature/modify-color-scheme
$ git remote add upstream https://github.com/tinted-theming/base16-dunst.git
$ git fetch
$ git reset --hard upstream/jamy/feature/gnsfujiwara
$ git push

And then create a new PR looking at that new feature/modify-color-scheme branch.


protobuf-compiler not found even when it is installed

Checklist

[X] I've looked through the issues and pull requests for similar reports

Describe your issue
Hi,
I'm facing a hard time using cross with protobuf compiling.
The project consists of two binaries projects with another workspace member embedding the protobuf :

Global repo Cargo.toml
nostrss-core
nostrss-cli
grpc part

This is what i come through anytime i try to compile :
Error: failed to run custom build command for `nostrss_grpc v0.1.0 (/project/nostrss-grpc)`
Caused by:
  process didn't exit successfully: `/target/release/build/nostrss_grpc-b025e56850f8952d/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=protos/nostrss.proto
  cargo:rerun-if-changed=proto

  --- stderr
  thread 'main' panicked at 'Could not find `protoc` installation and this build crate cannot proceed without
      this knowledge. If `protoc` is installed and this crate had trouble finding
      it, you can set the `PROTOC` environment variable with the specific path to your
      installed `protoc` binary.If you're on debian, try `apt-get install protobuf-compiler` or download it from https://github.com/protocolbuffers/protobuf/releases

  For more information: https://docs.rs/prost-build/#sourcing-protoc
  ', /cargo/registry/src/github.com-1ecc6299db9ec823/prost-build-0.11.9/src/lib.rs:1457:10

You'll find more context here
This happens no matter what i do, and even when i ensure that protoc is installed.
If you look at the steps of the CI linked a bit above you'll see that the protobuf-compiler is installed ( many times ) :

here (result)
or here (result)

I even tried to declare PROTOC before calling cross using which protoc (see here). No luck.
Yet, when using cargo i have no problem compiling. See here
I tried then to cross compile on my local machine (an intel i7 macbook pro from 2018) and it appears i do have the same problem. compiling with cargo even the release works like a charm, but cross fails with the exact same problem.
I don't know if i am missing something regarding the configuration or if this is a bug/blind spot of cross.
Many thanks for your help/feedback 🙏
What target(s) are you cross-compiling for?
No response
Which operating system is the host (e.g computer cross is on) running?

[X] macOS
[ ] Windows
[X] Linux / BSD
[ ] other OS (specify in description)

What architecture is the host?

[X] x86_64 / AMD64
[ ] arm32
[ ] arm64 (including Mac M1)

What container engine is cross using?

[ ] docker
[ ] podman
[ ] other container engine (specify in description)

cross version
cross v0.2.5
Example
No response
Additional information / notes
No response

You need to install the dependency in the container, see https://github.com/cross-rs/cross/wiki/Recipes#pre-build for an example on how to install openssl development libraries.
Your cross builds don't use anything from the outside environment except for the code you're compiling and the rust cross-compiler. So installing protobuf on the host wouldn't automatically make it available inside the cross build.
So for protoc, targetting x86_64, it'd be
#Cross.toml
[target.x86_64-unknown-linux-gnu]
pre-build = ["apt update && apt upgrade && apt install -y protobuf-compiler"]

I don't know how protobuf works, but if it's a build-time dependency it should be fine to use the same line for the other targets too, see wiki/Configuration


Inconsistent behaviour with track by and bindone when adding to list.

This is an Angular 1.3.0 issue.  I was using firefox and tested on Chrome.
I was having a play with the bindone syntax and track by.
If you have a track by in a repeater and you bind once on a value, then you cannot change the value on the bound once value after the original binding (as you would expect).  However, as soon as you add to the list then the change comes through.  Plunkr provided to illustrate what I mean:-
http://plnkr.co/edit/u3Rbb40UKQYuTcK5pc94?p=preview
The "Modify Key" button modifies the key of the first item, the "Modify Value" button modifies the value of the first item.  The "Add" button will add a value to the list.
If you do the following:-

Click on "Modify Key"
Click on "Modify Value"

Then, the bound once first value does not change.  However, if you then click on add, then the bound once value is updated.
What I was hoping was to see is the bound once value would not be updated until the key changed - after which time the DOM would be re-rendered and the new value would be displayed.  This would mean that we could use the track by mechanism as a means of significantly reducing the number of watchers.  This was probably naive of me.  Irrespective of how I feel it should work, I think it should work consistently - that is, it should either not change in all cases or change only when the key changes.

This works as expected. ngRepeat uses $watchCollection to check for changes in the collection. If you update only the key of an object, ngRepeat doesn't trigger the track by check etc at all. If you add an item, it will find that the key has changed, and rerender the changed item, which causes the change in the value to be picked up.


feat(angular): Search organizations by contributor role

Closes #1378

TODO: validate if the value of checkbox is part of query parameters.


Child entities with a trigger area go into full epilepsy mode

I noticed this happening in entities that are children of another entity AND that have the TriggerComponent from the Utils library.
I'm not sure how long this has been happening, but it's currently happening both in @latest and in @next
Here's a minimal example where that happens:
https://app.zenhub.com/files/220994476/6490dc2e-faa6-4dfe-b550-bac4e856d0b1/download
import utils from '../node_modules/decentraland-ecs-utils/index'

let scene = new Entity()
scene.addComponent(
  new Transform({
    position: new Vector3(0, 0, 0),
    rotation: Quaternion.Euler(0, 90, 0),
  })
)
engine.addEntity(scene)

export let building = new Entity()
building.addComponent(
  new Transform({
    position: new Vector3(16, 0, 16),
  })
)
building.addComponent(new GLTFShape('models/FoxAsian.glb'))
building.setParent(scene)

let triggerBox = new utils.TriggerBoxShape(Vector3.One(), Vector3.Zero())

building.addComponent(
  new utils.TriggerComponent(
    triggerBox, //shape
    0, //layer
    0, //triggeredByLayer
    null, //onTriggerEnter
    null, //onTriggerExit
    () => {
      log('inside')
    }
  )
)

Like this, the 3d model jumps every frame between 4 different locations in the scene.
If I set the position of the model directly, without the parent, it gets fixed.
If I remove the TriggerComponent, it gets fixed.
If I remove the last argument of the TriggerComponent, so that it has a trigger area but doesn't have a triggered function, it gets fixed.

@pbosio maybe you can get a better insight into this one, that trigger component is part of your utils library right?

@pbosio maybe you can get a better insight into this one, that trigger component is part of your utils library right?

It's not my utils library... it's our utils library 😒 the world's utils library!
I will take a look, as far as I remember the triggers never moved or rotate anything... but... maybe those old functions for getting the global position or rotation of an entity are doing something crazy here? 🤔

Yeap.. As I suspected there was an issue with the function to calculate the position of the child entity in world space. (it was using a reference instead of a copy)
I have pushed a fix to the repo and should be available to update the npm package in your scene @nearnshaw

Nice!!
Thanks @pbosio ❤


Consider adding wait spinner when running azd down

When running azd down, it takes from 10 to 30 seconds for the first output to show up:

This will delete 8 resources, are you sure you want to continue?

Consider adding a quick message after running azd down like: Getting resource list from your project...  .  So the user knows that azd is doing something and that it's not frozen.

Should be covered as part of the azd down UX improvements https://github.com/Azure/azure-dev/issues/1434


Manually selecting tab: "old tab" is incorrectly sized

I'm using setDefaultTabPosition before I add any items, which is fine.
I need to override the onBackPressed behavior a bit. (Switch the tabs until you reach the "end") So I have to manually select tabs on demand.
After calling selectTabAtPosition the previous tab is incorrectly sized.
http://i.imgur.com/qTx87nw.png

This happens to me whenever I call selectTabAtPosition regardless of default tab or not.

@NickM-27 Workaround: .noResizeGoodness() which sets the tab width fixed

Similar to #120, so I guess some internal "magic" needs to be applied when using setDefaultTabPosition

i'm having this problem too

No problems with the latest version.


DevRel community contribution guide

As per our last meeting, it will be useful to have a contribution guide for the DEvRel community. It can be a md file. Potential content includes how to present OpenSSF and related security topics in giving talks, where to find the events that we are going to, how to let us know if someone is speaking etc. It can also include the link to the meetup organising guide.

Here is a stab: https://docs.google.com/document/d/100EI-QXJ4OESVjGQngJsVYYusrcDcHJppQ-K69Er-Ic/edit

Ok, thanks to @kdruckman for the feedback, this stab is now a PR for review at #37

The PR got merged, so closing this one out!


Set terminal resize signal handler to system default

#70

Coverage increased (+0.0009%) to 96.781% when pulling 3b04eb4337df27a110050e496f692db92ff67823 on brycepg:master into 47b6b486320f7be7c019afc353fc3aa398af3a23 on peterbrittain:master.

@peterbrittain, I've made _CursesScreen restore the previously defined signals upon close. I've decided not to modify the restore conditional part of the close method for this pull request because there are some other considerations to take into account. Namely, users who have set restore as a positional or keyword argument will have their code break.

Coverage increased (+0.01%) to 96.792% when pulling 5d7b1989832b73afd151adfc50dcaab6e21ee8ff on brycepg:master into 47b6b486320f7be7c019afc353fc3aa398af3a23 on peterbrittain:master.


gui: fix crash in CLOSEST_MATCH for paths with only clock nodes

Fix #4487
Write clock nodes in situations where the path is made only of clock nodes.
Paths with only clock nodes will be written with -through for all nodes. Using -from for the first and -to would lead to not finding the path in report_checks.

@eder-matheus please review


Clarified starting number for -n

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Added some clarification for the -n switch

I don't think this is necessary to add to the article, thanks and happy coding!


Add CHANGELOG

as @sarcadass indicated on gitter, we should add a changelog and keep track of our future updates on the project.
This should be as easy as looking at the commit log on github, and typing down a CHANGELOG

Fixed with 657f5dcaddfb6fe26507604109312003a2b11bec


BBL installing latest version of terraform does not sync with plugin compatibility

BBL installs the latest version of terraform as a dependency but support is not well synced or supported so I am looking into pinning the terraform version for reliability.  Hashicorp's release schedule causes many breakages with BBL and version pinning is needed to keep things working.  Over the past year I have had 3 or 4 periods where breaks due to incompatibility latest longer than a week.

No response, still an issue but closing.


use new iTwinUI for scoped styles

This PR adds the freshly released scoped styles that will enable synchronization-report-react to be consumed by apps that are still using iTwinUI v1 for the rest of the page.
For more details about how this works, you can see https://github.com/iTwin/iTwinUI/pull/1031. There will be more friendly documentation very soon.

Can you bump the version?

Can you bump the version?

done


"Secret key" is unexplained

What is the "secret key" for? If it's for an online service, the description should say so. (And if it's not, it should still be explained because it is mysterious.)

Haha, yeah that isn't explained well in the documentation.  I just fixed it to say that the secret key is just the seed that the algorithm uses to generate the prompts.  No online services or anything!


spark-notebook does not shutdown all processes when dynamic allocation is switched on

When shutting down the notebook Spark-notebook does not shut down all apps related to the notebook when dynamic allocation is switched on the spark-standalone cluster.
To reproduce the bug - switch on dynamic allocation and external scheduling service on spark standalone cluster, give some tasks that will lead to several allocations per notebook and shutdown notebook inside spark-notebook UI

Good one!
As it is quite a task to reproduce, could you investigate what we could do?
That'd be super useful.
many thanks


Feature/settings redesign [OP-50]

Purpose
Redesign settings into a toolbar and other small changes

Creates toolbar for settings that is always visible in edit mode
Moves the up and down move buttons to toolbar to clear clutter
Uses Material design icons (https://material.io/icons/)
Adds query parameter for edit mode to speed up development
Removes save indicator temporarily
Small enhancements to starter theme select
replaces some images with local copies

quite the PR looks good 👍


Unbounded CBMC Proofs for an Array-backed Task-Scheduler

Unbounded CBMC Proofs for an Array-backed Task-Scheduler
Description
Provide unbounded CBMC proofs (i.e. proofs for task-lists of arbitrary length) for the task-scheduler. However, these proofs assume an array-backed implementation of lists.
Test Steps
Only the CBMC proofs folder was modified. All CBMC proofs pass.
Related Pull Request
This pull-request is dependent on the following pull-request which modifies the old linked-list based implementation to an array-list based list implementation
https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/561
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

DO NOT MERGE. It is a proposal for the unbounded proof for the array-based implementation introduced in https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/561.

Closing this PR after discussion with the PR owners.


Statistical Hikes #hikes

Please add comments for some of the below hike ideas, an example description is provided for "What is Statistics?"

[ ] What is Statistics?
[ ] What is Probability?
[ ] What is a Mean?
[ ] What is a Standard Deviation and Variance?
[ ] What is a Probability Distribution?
[ ] What is a Normal Distribution?
[ ] What is a Binomial Distribution?
[ ] What is an Exponential Distribution?
[ ] What is a Poisson Distribution?
[ ] What is AB Testing?
[ ] What is a t-test?
[ ] What is a Hypothesis?
[ ] What is a p-value?
[ ] What is Bayes Theorem?
[ ] What is Analysis of Variance?
[ ] What is Bootstrapping?
[ ] What is a Markov Chain?
[ ] What is Regression?

What is Statistics
A hike defining what statistics is.
"Statistics is the study of data including how you collect, organize, transform, analyze, and present it"
Example statistic problems, bioinformatics, data aggregation, etc.
How to make sense of your data, someone can't be 20 meters tall etc.
Mention common terms and reference that they'll be introduced in other hikes.

Is statistics the study of numbers? F
Is data presentation a part of statistics? T
Do statisticians clean data? T

#What is a Standard Deviation and Variance
Variance is the sum of squared deviations of each observation from the mean divided by the sample size aka n-1
Standard Deviation is the "typical" departure of an observation from the mean or simply put the square root of the variance

Is degree of freedom and n-1 different? F

What is a Mean
Mean is the sum of all individual observations divided by the number of observations(n) or simply put the average value

What is a Probability Distribution
Probability Distribution is a frequency distribution about which predictions can be made.

What is a Binomial Distribution
Binomial Distribution applies to random variables that take on only a finite and specified number of values or categories
Real life examples

coin toss
gender
games of chance

What is a Normal Distribution
Normal Distribution applies to random variables that can take on an infinite number of values

What is a Poisson Distribution
Poisson Distribution is used to test for the random pattern hypothesis, which states that the pattern of items in space or time is random
Procedure for Poisson

Obtain a random sample
Calculate the mean
Calculate P
Multiply P by total number sampling units n to get expected number sampling units for each Xi
Test for goodness of fit using X^2


HelloRequest Handshake Type Support

Summary
Add support for the HelloRequest Type
Motivation
I am currently trying to implement a client for a server that sends a HelloRequest-Paket after the HelloVerifyRequest. This packet is currently not supported and causes the client to not function properly.
Additional context
My understanding is that the HelloRequest Packet requests the client to reset its sequence number.
However, the HelloRequest Paket already arrives with sequence number 0, causing the anti-replay protection to trigger, which happens before we try to parse the packet to receive its Handshake Type and therefore we never actually handle the paket, so implementing this feature would require some restructuring of the anti-replay protection/handshake parsing.
Here are 2 Screenshots showing the HelloRequest-Paket and the following ClientHello-Paket. The left window is a capture of the original client, the right window is the client using this package.

Aswell as the Log-Message popping up:
dtls DEBUG: 08:47:21.686082 conn.go:672: discarded duplicated packet (epoch: 0, seq: 0)

Hey @MaxBosse
I think it makes sense to add support for it! Would you be interested in contributing this? I would be happy to help.
In the short/medium time I don't have the time to work on this. I could see it possibly happening in the next 6 months. We just have lots of other issues that have more users requesting/effected.
thanks

I don't think we should implement HelloRequest

Not much demand/interest for it in the two years this issue has been open
Adding more code could lead to more bugs/issues

If you are blocked by this issue please comment and would love to implement/explore it.


Unable to increase the rate of navposecef stream from 1Hz to 4 Hz

I am trying to read messages from the u-blox ZED-F9K receiver via serial communication using pyubx2. However, currently, the measurement update rate for various streams such as the navposecef stream is set to 1 Hz. Since my application involves high dynamics, I would like to increase the streaming rate to ideally 4 Hz or 20 Hz (the highest rate possible). I was able to do this in ucenter-2 but I would like to do it via serial communication. I tried setting higher rates than 1 Hz but the iTOW in messages still shows that we receive these measurements at 1 Hz.

Please post the FULL code you are using to set the measurement rate, along with examples of the serial output of your device BEFORE and AFTER you apply your code. Please also specify how you are physically connecting to the device (i.e. which serial port, baud rate). Thanks.

I am using one of the example scripts, specifically, ubxsetrates.py. I am changing the RATE value here as shown. I tried baud rates of 9600 and 115200. The serial output from my device is exactly the same.
for (msgid, msgname) in UBX_MSGIDS.items():             if msgid[0] == 0x01:  # NAV                 msg = UBXMessage(                     "CFG",                     "CFG-MSG",                     SET,                     msgClass=msgid[0],                     msgID=msgid[1],                     rateUART1=RATE,                     rateUSB=RATE,                 )


Add new repositories fragment

What this PR does / why we need it:
Added new fragment called "repositories". Demo and documentation is available at /fragments/repositories. Currently it only supports Github. I plan to add Bitbucket and Gitlab shortly but adding them would require a simple interface to keep us from writing the template multiple times. Writing the code isn't that hard but I prefer to get approval on the design and how it's currently implemented before I move on.

Which issue this PR fixes:
fixes #599
Release note:
- repositories: Added new fragment to fetch and display user repositories from Github

I don't think subitems would be a good idea for this fragment. A whitelist of repositories can be created using a variable, specifying fields is something that is applied on all the cards (I don't think changing the fields per project is a good idea, both design-vise and the confusion that it causes to the end user). Also we can allow a filter function to be written by the user and call that. For example, we write our sort and filter functionality in a helper partials/helpers/repositories_github/fitler.html that returns a filtered list and document how to write new filters. We can keep the sort and count in our code for the sake of simplicity as well.

Ok so we keep it simple.
Make it the first provider specific fragment.
Adding more buttons from the data as follow on.
So default sorting is just by last commit date.
We should have at least star count as well. Sidequestion there. Does a fork have the same star count as the main repo? If not, then filtering wouldn't be needed. We would just have star count default sort and it would always bubble up the users personal repos and show the 5 most important or so.
Not sure about what you are imagining on the filter side. Care to elaborate? My first thought was just whitelisting of repos as a list.
Thinking about lists. Any reason to not make the "user" not a list? Also is this better to be called "user" or namespace?
It being a list of namespaces for example we could do something like: "okkur, okkur-incubator".
The other option there is to keep it simple and pull in only one namespace/user and the Syna user could always create multiple separate fragments.

Sorting and filtering is a bit of a problem since we can't get pinned repositories and have to rely on sorting and limiting or filtering (based on a whitelist or "no forks" somehow) and again, limiting with count. We can however extract the code we use to filter repositories into a helper file that receives repos as a parameter and returns the new list. Then any user who wishes to change the list to their liking can override that helper, copy it to their website and update its code.

I would leave advanced sorting and filtering for now, but add these points:

sorting by date (what we have)
sorting by star count (new default)
forks true/false (false by default)
whitelist that only shows repos that match the whitelist (not set by default)

Happy to do the whitelist idea in a separate PR. The others I feel are good things to have here already. Thoughts?

Let's do the whitelist and maybe additional buttons in a separate PR.


Add support for next-* and thunderstorms to German

Closes #95

Accepted and merged. Thanks!
(How many languages do you speak, anyway?)


'coda client status' appears to hang at times

coda client status' appears to hang at times.  So I started timing it with the time command.
Here is an instance when it appeared to hang but did finish.
real	1m18.501s
user	0m0.216s
sys	0m0.080s

And here is an instance where the response was snappy.
real	0m0.336s
user	0m0.180s
sys	0m0.040s

Another example of untimely response.
real	1m5.110s
user	0m0.208s
sys	0m0.072s

With version
[DIRTY]7f0440c609bfd1e2bc4130f06d09f72763c25b67

just witnessed
real	33m45.537s
user	0m1.864s
sys	0m1.060s

Closing this issue as it is stale for a long time.


Update Verilator version

As of version 4.028, Verilator supports wildcard matching for lint_off rules. This reduces the effort required to keep lint waiver files aligned with the actual source code.

Please also add the machinery we have in Ibex to warn users if they use an outdated Verilator version. We currently don't have a reliable way to inform downstream users of such changes they need to make to their environment, so this is our only chance (or we get grumpy users).

@imphil I managed to port your framework from Ibex to OpenTitan (the hardest part was actually to also use it with Hugo).
For now, the check is just included for linting via  hw/lint/common.core. I am not sure if this is sufficient. But before touching many .core files, I would like to get your input if this goes in the right direction.

Ah, I just found out that lint is also called before generating e.g. top_earlgrey. So this should actually be sufficient. WDYT?

I made the new shortcode more generic: the tool name is now passed as an arugment to the shortcode {{< tool_version "verilator" >}} . Meaning we can use the same shortcode also for other tools in the future.


feat: DID Exchange Inbound Message Event

Support to register go channels for inbound DIDExchange  message types
Trigger events on inbound message message from Handle function
Support for callback events (go channels) to post the result from consumer message processing

Signed-off-by: Rolson Quadras<EMAIL_ADDRESS>

Codecov Report

Merging #240 into master will increase coverage by 0.95%.
The diff coverage is 92.77%.

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage    86.8%   87.75%   +0.95%
==========================================
  Files          35       35
  Lines        1538     1576      +38
==========================================
+ Hits         1335     1383      +48
+ Misses        113      105       -8
+ Partials       90       88       -2

Impacted Files
Coverage Δ

pkg/didcomm/protocol/didexchange/service.go
85.88% <92.77%> (+9.06%)
:arrow_up:

pkg/client/didexchange/client.go
100% <0%> (ø)
:arrow_up:

pkg/didcomm/protocol/didexchange/states.go
100% <0%> (+2.5%)
:arrow_up:

pkg/restapi/operation/didexchange/didexchange.go
76.92% <0%> (+4.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbd59c...35ffd11. Read the comment docs.

Remove go routine - (https://github.com/hyperledger/aries-framework-go/pull/240/files#diff-f761c91e753eba1c42a68076df06ce12R179)
Non-block processCallback
Have a  errorEvent
Client deals with one channel (event).
Hide all other async details from clients. eg - callback appears to be blocking to the client even though its non-blocking.

Remove go routine - (https://github.com/hyperledger/aries-framework-go/pull/240/files#diff-f761c91e753eba1c42a68076df06ce12R179)
Non-block processCallback
Have a  errorEvent
Client deals with one channel (event).
Hide all other async details from clients. eg - callback appears to be blocking to the client even though its non-blocking.

Addressed all the above comments except point#3 (TODO #242 )

Updated the code based on discussion with @troyronda.
Configs:

Action Events - Consumer can register one event for message processing. The event message will have a callback function. The consumer need to call this to continue processing the message.
Stream Events -  Consume can register multiple event for stream listening. This is not related to message handling and just a mean for the consumers to listen to the messages.
Auto Execution - Consumers can set Auto execution to execute the message processing.

Behaviour:

If Action events or auto execution not set - the service will throw error while handling the messages.
If action event set after auto execution - the service will trigger action event and wait for callback
If action event set before auto execution - the service will auto execute
If multiple action event set - the events will triggered on last event channel.


CheckUnknown should not panic on nil alert.

I think this should only be needed if you remove an alert and restart bosun. This will prevent a panic.

Here's the panic that caused this.
2015/03/03 17:22:32 checkUnknown
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x68 pc=0x4f62d4]

goroutine 130069 [running]:
bosun.org/cmd/bosun/sched.(*Schedule).CheckUnknown(0xf84900)
        /home/teamcity/buildAgent/work/73e1f84984469e15/src/bosun.org/cmd/bosun/sched/check.go:201 +0x354
created by bosun.org/cmd/bosun/sched.func·027
        /home/teamcity/buildAgent/work/73e1f84984469e15/src/bosun.org/cmd/bosun/sched/sched.go:597 +0x52

I can't reproduce this anymore. Perhaps we should leave it 'broken' until it rears its head again.

Closing until this happens again.


Specialize ordinal encoding for SortedSetDocValues

Description (or a Jira issue link if you have one)
This follows up the work done in LUCENE-10067 by adding additional specialization for SORTED_SET doc values.

Benchmarks look good on SSDV faceting (and no regressions elsewhere). I think some new bench tasks have recently been added as well that might be relevant here, so I'll update my luceneutil and run again soon. For now, here are results on wikimediumall:
                            TaskQPS baseline      StdDevQPS candidate      StdDev                Pct diff p-value
                         Prefix3       58.57      (8.6%)       57.65      (9.9%)   -1.6% ( -18% -   18%) 0.591
               HighTermMonthSort       47.72     (28.0%)       47.26     (15.8%)   -1.0% ( -34% -   59%) 0.893
     BrowseRandomLabelSSDVFacets        2.60      (6.8%)        2.58      (5.6%)   -0.7% ( -12% -   12%) 0.729
                    HighSpanNear       17.35      (2.6%)       17.23      (4.2%)   -0.7% (  -7% -    6%) 0.544
                   OrHighNotHigh      762.36      (4.2%)      757.77      (4.8%)   -0.6% (  -9% -    8%) 0.673
                        Wildcard       27.05      (5.4%)       26.94      (5.9%)   -0.4% ( -11% -   11%) 0.820
                       LowPhrase       35.88      (2.7%)       35.80      (2.7%)   -0.2% (  -5% -    5%) 0.788
                   OrNotHighHigh      645.25      (3.1%)      644.30      (3.3%)   -0.1% (  -6% -    6%) 0.884
                         LowTerm     1793.47      (3.6%)     1792.45      (3.8%)   -0.1% (  -7% -    7%) 0.961
                    OrNotHighMed      653.99      (3.1%)      653.73      (3.2%)   -0.0% (  -6% -    6%) 0.968
                      AndHighMed       68.77      (5.3%)       68.75      (6.5%)   -0.0% ( -11% -   12%) 0.986
             LowIntervalsOrdered       51.08      (4.6%)       51.08      (4.5%)    0.0% (  -8% -    9%) 1.000
                       MedPhrase       70.46      (3.1%)       70.46      (3.3%)    0.0% (  -6% -    6%) 0.995
                    OrHighNotLow     1055.73      (3.3%)     1055.91      (4.4%)    0.0% (  -7% -    7%) 0.989
            HighIntervalsOrdered        8.03      (4.5%)        8.03      (4.6%)    0.0% (  -8% -    9%) 0.984
                     MedSpanNear       11.88      (2.4%)       11.89      (3.1%)    0.1% (  -5% -    5%) 0.926
            MedTermDayTaxoFacets       18.17      (3.6%)       18.20      (3.8%)    0.2% (  -7% -    7%) 0.891
                    OrHighNotMed      780.58      (3.3%)      781.92      (3.8%)    0.2% (  -6% -    7%) 0.877
          OrHighMedDayTaxoFacets        4.78      (4.4%)        4.79      (5.0%)    0.2% (  -8% -    9%) 0.906
        AndHighHighDayTaxoFacets        6.91      (2.3%)        6.92      (2.9%)    0.2% (  -4% -    5%) 0.828
             MedIntervalsOrdered        4.36      (3.5%)        4.37      (3.7%)    0.2% (  -6% -    7%) 0.851
                      OrHighHigh       14.24      (2.8%)       14.27      (6.4%)    0.3% (  -8% -    9%) 0.872
                          IntNRQ       33.94      (1.1%)       34.05      (1.3%)    0.3% (  -2% -    2%) 0.381
                          Fuzzy2       71.29      (1.7%)       71.55      (1.8%)    0.4% (  -3% -    3%) 0.509
                     LowSpanNear        8.79      (2.7%)        8.83      (3.2%)    0.4% (  -5% -    6%) 0.673
                          Fuzzy1       76.55      (1.7%)       76.90      (1.6%)    0.5% (  -2% -    3%) 0.377
                      AndHighLow     1077.25      (4.1%)     1082.31      (3.8%)    0.5% (  -7% -    8%) 0.706
       BrowseDayOfYearSSDVFacets        3.45      (5.8%)        3.47      (4.9%)    0.6% (  -9% -   11%) 0.722
                 LowSloppyPhrase       16.00      (1.9%)       16.10      (2.9%)    0.6% (  -4% -    5%) 0.437
                       OrHighMed       47.78      (2.0%)       48.08      (3.9%)    0.6% (  -5% -    6%) 0.527
                        HighTerm     1147.74      (4.7%)     1155.05      (4.2%)    0.6% (  -7% -    9%) 0.650
                        PKLookup      147.38      (3.6%)      148.34      (3.1%)    0.7% (  -5% -    7%) 0.537
                     AndHighHigh       19.16      (5.1%)       19.29      (6.8%)    0.7% ( -10% -   13%) 0.730
                         Respell       51.81      (1.5%)       52.15      (1.4%)    0.7% (  -2% -    3%) 0.147
                         MedTerm     1406.90      (4.4%)     1417.58      (4.2%)    0.8% (  -7% -    9%) 0.578
                 MedSloppyPhrase       28.98      (2.0%)       29.20      (2.8%)    0.8% (  -3% -    5%) 0.306
         AndHighMedDayTaxoFacets       23.12      (2.0%)       23.31      (2.3%)    0.8% (  -3% -    5%) 0.232
                      TermDTSort       78.14     (20.6%)       78.83     (20.1%)    0.9% ( -32% -   52%) 0.891
                      HighPhrase      180.25      (2.8%)      182.18      (2.6%)    1.1% (  -4% -    6%) 0.215
                       OrHighLow      317.72      (2.0%)      321.31      (3.4%)    1.1% (  -4% -    6%) 0.199
                HighSloppyPhrase        7.56      (3.9%)        7.65      (5.6%)    1.2% (  -7% -   11%) 0.429
                    OrNotHighLow      703.88      (3.0%)      713.94      (3.2%)    1.4% (  -4% -    7%) 0.142
           BrowseMonthSSDVFacets        3.92      (2.6%)        4.01      (8.1%)    2.2% (  -8% -   13%) 0.246
           HighTermDayOfYearSort       27.70     (14.3%)       28.46     (18.1%)    2.8% ( -25% -   41%) 0.591
            HighTermTitleBDVSort       59.66     (15.4%)       61.56     (15.9%)    3.2% ( -24% -   40%) 0.520
     BrowseRandomLabelTaxoFacets        5.83     (18.6%)        6.18     (13.8%)    6.1% ( -22% -   47%) 0.241
       BrowseDayOfYearTaxoFacets        6.35     (20.9%)        6.75     (17.0%)    6.3% ( -26% -   55%) 0.293
           BrowseMonthTaxoFacets        8.06     (27.7%)        8.58     (21.4%)    6.4% ( -33% -   76%) 0.413
            BrowseDateTaxoFacets        6.33     (20.8%)        6.73     (16.8%)    6.4% ( -25% -   55%) 0.280
            BrowseDateSSDVFacets        0.85     (12.7%)        0.95     (11.0%)   11.5% ( -10% -   40%) 0.002

This yielded a big speedup on nightly benchmarks http://people.apache.org/~mikemccand/lucenebench/BrowseDateSSDVFacets.html

I pushed an annotation, it should be live on the next nightly run.

Thanks Adrien!
On Tue, Jul 19, 2022 at 12:54 AM Adrien Grand @.***>
wrote:

I pushed an annotation, it should be live on the next nightly run.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/lucene/pull/1010#issuecomment-1188722250, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5XKSACPFXC7WAIYW36OITVUZNKXANCNFSM527FQNBQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Fixes #37 - Expireless tokens

Tried to just comment out the key refresh token parts, just for in case we need to reimplement them.
I tested the authorization grant, checked the database to see that no refresh token is being generated.
Besides that, the methodology used to make refresh tokens expireless was to set its duration for 100 years. I did this also for the access tokens.
Related isssue #37

Reimplemented all the refreshToken parts.
Had some trouble revoking a refresh token, but it was solved eventually.


AI Voice Assitant script using Python

Hi @DhanushNehru, I am writing a python script for real-time camera face mask detection using different libraries which are part of machine learning and deep learning like Tensorflow and Keras, and OpenCV. Please give me go ahead to achieve the same. Thanks!

Hi @DhanushNehru, your repo is not excluded from Hacktoberfest right ? Just wanna confirm because many repos I have contributed getting excluded don't know why so that's wanted to confirm from your side ??

@DhanushNehru please give me acceptance!

i want to work on this issue. Please give me the acceptance
!

Hi @Govind516 its already done by @Sushant-1999
If you are doing , do something differently

Hi @DhanushNehru
I want to add something new where the user can give input a word and get the meaning of the word in form of both text and audio. Can I ?


error when activating datavirtualization extension

I am seeing the following error

Which extension is this?

I have a fix out to remove the proposed API from that extension since we don't need it anymore, but if we do in the future for this or any other extension then the fix should be just to add it to https://github.com/microsoft/azuredatastudio/blob/master/product.json#L62


Update Internal Documentation to Reflect JWT Integration in LibreChat

Discovery:
With the recent changes to LibreChat, the system now supports external JWT authentication and the automatic creation of users when a user.id from a JWT does not exist in the database. This new functionality must be properly documented to ensure developers and maintainers understand how to configure and work with the JWT integration.
Problem Definition:
The internal documentation for LibreChat does not currently reflect the changes made to support external JWT authentication. This lack of documentation can lead to confusion for developers when integrating or maintaining the system. Clear documentation is required to outline the process for configuring JWT authentication, handling JWT tokens, and automatically creating users from JWT payloads.
Motivations:
By updating the internal documentation to reflect the JWT integration, we can:

Provide clear guidance for configuring JWT authentication and managing external tokens.
Ensure developers understand how the system handles new users and what data is required for user creation.
Facilitate easier onboarding of new developers and maintainers by providing up-to-date, accurate documentation on the authentication flow.
Improve overall system maintainability by reducing the risk of errors or misunderstandings related to the authentication process.

Proposed Solution:

Update Documentation for JWT Configuration:

Add detailed instructions on how to configure passport-jwt for external JWT token validation, including how to set up JWT extraction from the Authorization header and configure the secret key or public key used for token verification.
Include steps on how to manage secret keys securely using environment variables or a secret manager (such as AWS Secrets Manager).

Document User Creation Workflow:

Provide an explanation of how the system handles cases where the user.id from the JWT does not exist in the database.
Describe the steps the system takes to create a new user based on the JWT payload, including which fields are required (e.g., username, email).
Include a description of how missing or malformed fields in the JWT are handled, and what error messages or logs are generated.

Include Code Examples (Optional):

Include code snippets that demonstrate how JWT validation is implemented in the middleware and how new users are created dynamically based on JWT payloads. This will help developers understand the flow of the implementation.

Add Security Considerations:

Document best practices for managing JWT tokens securely, including recommendations for token expiration times, refreshing tokens, and securely managing keys.
Explain the importance of validating user data extracted from JWT tokens to prevent unauthorized access or data corruption.

Testing and Debugging Guide:

Provide a section on how to test the JWT authentication flow, including using mock tokens for development purposes.
Include a troubleshooting section to help developers debug common issues related to JWT validation and user creation.

Link to Existing Documentation:

Ensure the updated JWT integration documentation links back to other relevant sections of the internal docs, such as the overall authentication flow or API security guidelines.

Definition of Done:

[ ] Documentation is updated with detailed instructions on configuring passport-jwt for external JWT authentication.
[ ] The user creation workflow for handling new users via JWT is clearly explained.
[ ] Security considerations for JWT authentication are included in the documentation.
[ ] Code snippets are added to demonstrate key parts of the implementation (optional).
[ ] Testing and debugging guidelines are provided to help developers validate and troubleshoot the JWT authentication flow.
[ ] Links to relevant existing documentation are included for context.

Additional Information:

Documentation Format: Ensure the documentation follows the existing structure and format used in LibreChat’s internal docs (e.g., Markdown files or Wiki).
Security Best Practices: Emphasize the importance of securely managing JWT tokens and keys, and ensuring proper validation during the user creation process.

#time 2
After a meeting with rizwan I've created a couple of sequence diagrams to reflect the actual authentication (JWT) scenario and how the backend will work along with Cognito to provide authentication and authorization.

Notion updated


Is it possible to set the stage background color transparent?

Hi,
thanks for the nice library!!
Is it possible to set the stage background color transparent?

just curious: why do you need that?

I put the stage in a div with background color.
I tried to change the stage background with
this.stage.viewer.renderer.setClearColor( 0xffffff, 1);
but it's not quite working as expected.

may be try this?
https://github.com/arose/ngl/blob/d35e0135eea6d603e3375b65a2a209fd8c9b47b1/src/stage/stage.ts#L161
or this
https://github.com/arose/ngl/blob/d35e0135eea6d603e3375b65a2a209fd8c9b47b1/src/stage/stage.ts#L251

I used setParameters  it's working, thanks!

Sorry to bump this old issue - @lidaof, how did you get this to work? I've tried using setParameters, but I'm not sure what the syntax is.

Hi @evanbunnage sorry I have switched to a computer..cannot remember or find the details, sorry...i guess probably related to the code below, you can try play with it:
function setTheme (value) {
    var cssPath, bgColor
    if (value === 'light') {
      cssPath = NGL.cssDirectory + 'light.css'
      bgColor = 'white'
    } else {
      cssPath = NGL.cssDirectory + 'dark.css'
      bgColor = 'black'
    }
    cssLinkElement.href = cssPath
    stage.setParameters({ backgroundColor: bgColor })
  }


Issue with k8s.io/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive/

Problem in Step 3.

[ ] Feature Request
[ X] Bug Report

Problem:
control-C doesn't work in the console
Environment:
MacOS, Chrome
Page to Update:
https://kubernetes.io/...

Are you using Ctrl+C or Command+C? I've just checked and on OSX, Ctrl+C works as expected. Command+C doesn't have any response, this is the same behaviour as iTerm on the desktop.


Typescript definitions for onClick etc.

Hi,
if have problems with the typings.
You can't use onClick or others standard props on Box etc.
If you use styled-components you get this typing.
This is my intermediate fix to get additional type information
export interface ExtendedBox extends BoxProps {
    onClick?: () => {}
}

export const Box: React.SFC<ExtendedBox> = props => <BaseBox {...props} />

You shouldn’t need type definitions for built-in React props, should you?

I would say this is a problem for me as well.
It's my understanding that you can get accurate type checking while using styled-components because the library is typed in terms of the JSX.IntrinsicElements interface while rebass is not.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/fe3bb114a3203f058d8bffedc996c92712609275/types/styled-components/index.d.ts#L100

Same for me. Although I'm not 100% that Button & Box should allow entire set of dom props + It would mess up with intellisense

Closing this out since this seems like an issue with typescript, and Rebass is not written with TS


how-to use docker with local DNS

We need setup guides illustrating how to stand up docker and have it advertise the machine's hostname/fqdn to clients instead of the default it ships with of "ziti-controller" or "ziti-edge-router" etc

Why the Docker host's hostname? You want apps running in containers to be able to resolve the DNS name of the controller and routers, correct?
One way to approach this is to run a nameserver. Then, the Docker daemon and the Docker host's OS can be configured to use the nameserver.
For reference, this PR added an optional nameserver to the local quickstart. It was pre-configured with the DNS records for the controller. That way I could use the ziti CLI and edge SDKs with ordinary domain names.

Possibly useful for this: https://nip.io/


Cannot find Vuesax depndencies

Hi there
Im trying to use the vuesax libraries for my project but everytime i hit npm run it says:
` ERROR  Failed to compile with 2 errors
These dependencies were not found:

vuesax in ./src/main.js
vuesax/dist/vuesax.css in ./src/main.js

To install them, you can run: npm install --save vuesax vuesax/dist/vuesax.css`
Ive installed using npm and even when running the command presented above it comes up with:
`npm ERR! code ENOLOCAL
npm ERR! Could not install from "vuesax\dist\vuesax.css" as it does not contain a package.json file.
npm ERR!      C:\Users\User\AppData\Roaming\npm-cache_logs\2020-06-24T07_19_36_340Z-debug.log`
Not sure what im doing wrong as ive followed the install instructions on the site so if any idea whats causing this would be most appreciated.

its happenig for my all projects since yesterday

I'm experiencing as well, neither vuesax latest 3.x or vuesax@next (4.x) were installed with a dist folder. I had to force install 3.11.15 which worked as expected.

I was not so lucky my project is with 3.11.15 is giving the error :(
"vuesax": "^3.11.15",

` ERROR  Failed to compile with 3 errors                                                                                8:02:06 PM
These dependencies were not found:

vuesax in ./themeConfig.js, ./src/main.js
vuesax/dist/vuesax.css in ./src/main.js

To install them, you can run: npm install --save vuesax vuesax/dist/vuesax.css`

I was not so lucky my project is with 3.11.15 is giving the error :(
"vuesax": "^3.11.15",

` ERROR Failed to compile with 3 errors 8:02:06 PM
These dependencies were not found:

vuesax in ./themeConfig.js, ./src/main.js
vuesax/dist/vuesax.css in ./src/main.js

To install them, you can run: npm install --save vuesax vuesax/dist/vuesax.css`

Remove "^" in your package.json file
"vuesax": "3.11.15",

Delete node_modules folder and run npm install


Mutations???

How are mutations to be defined?

i tried
public class Mutation extends GraphQLRootResolver{     //......  } no luck

Mutations do works - take a look here:
https://github.com/Loydl/camunda-graphql/blob/master/src/main/java/graphql/resolvers/Mutation.java

Ahh my bad! turns out that my Schema definition had a typo. thanks


Capability to cancel dask jobs started with fire_and_forget

Ran across a scenario where a job was improperly submitted using "fire_and_forget" to my dask cluster that was too small/wrong level of parallelism and was going to take a long time to finish.    The only way I could find (out of the box) to cancel the job was to blow away the whole cluster and restart it.
It would be nice if Coordination Primitives as described in this (closed) issue:
https://github.com/dask/dask/issues/1183
Could be combined with an approach like described here (explicit stopping condition):
https://stackoverflow.com/questions/49203128/how-do-i-stop-a-running-task-in-dask
To give out of the box ways to have Client apis like:
Client.get_jobs
>>  Queue[Future]

Client.cancel_job(future.id)
>>  Cancelled

If no one thinks this is a bad idea or if there isn't an easier way to accomplish the same thing I'll get started on this later in the week.


Change api mount to /api/v1

Since the api is going to be on devshift and not accessible on 3scale, we can change the api mount.
Sorry Brandon!!

/retest


NO-JIRA Cleaning up test suite

Derby was leaking.
all tests were issuing derby shutdown even if not using them.
a test was not using derby at all (JMSStorageTest) since we don't have a JMSSTorage implementation (just regular StorageManager).

this was before the updates..

This is after these updates.


how to create a config file with trojan please explain

[General]
loglevel = error
tun = auto
dns-server = <IP_ADDRESS>, <IP_ADDRESS>

[Proxy]
Trojan = trojan, <IP_ADDRESS>, 443, password=password, sni=servername.com

[Rule]
FINAL, Trojan


Add metric fan

See discussion at #803

Some easy properties to add:

P181 Countably infinite
P126 Door, as the space refines S12

Just curious about the terminology "sequential fan" and "metric fan".  I would have thought "sequential fan" is because each of the "spines" is itself (homeomorphic to) a convergent sequence.  But the "metric fan" has the same property: each spine is also a convergent sequence.  we could say it's a "metric sequential fan", versus the other one, which is not metrizable.
Apart from that article from Gruenhage, what is the more commonly used terminology for metric vs non-metric fans?  There could also be similar "fans" with spines being sequences or being something else?  Hedgehogs?

About having "Compact semi-Hausdorff non-KC space" as an alias, I can't think of anyone referencing this space by such an unhelpful and nondescript name.  I don't think it helps anyone to keep that name.  And I don't imagine anyone having referred to this space by that name, and definitely not from the literature.  (And nobody will care if we remove this alias.)

Just curious about the terminology "sequential fan" and "metric fan". I would have thought "sequential fan" is because each of the "spines" is itself (homeomorphic to) a convergent sequence. But the "metric fan" has the same property: each spine is also a convergent sequence. we could say it's a "metric sequential fan", versus the other one, which is not metrizable.

The "sequential fan" name comes from the fact that open neighborhoods of the non-isolated point are defined by sequences $\omega\to\omega$, rather than elements $n<\omega$ as in the metric fan (named because it's metrizable, ofc).

Apart from that article from Gruenhage, what is the more commonly used terminology for metric vs non-metric fans? There could also be similar "fans" with spines being sequences or being something else? Hedgehogs?

I'm working off memory, but "metric fan" and "sequential fan" are standard names (at least within the southeast US set-theoretic topology colloquia). I do think I've heard "hedgehog" before as well, though that might be used to distinguish using [0,1] in place of \omega+1: https://en.wikipedia.org/wiki/Hedgehog_space

FYI, see https://mathoverflow.net/a/370989.  At the end of the post, T. Banakh gives the "metric fan" with the same definition as you.  He also mentions the "Frechet-Urysohn fan" at the end.  I have not looked into it, but that could be interesting too; or is that the same as the "sequential fan"?  (See also the linked paper)

I think it's the sequential fan: https://topology.pi-base.org/spaces/S000097/properties/P000080 should be true

Cool.  I'll let @danflapjax do the review.

Whether the metric fan is completely metrizable came up in our call today. Indeed, for any almost-discrete metrizable space we can choose a metric where the distance between any two isolated points is greater than some fixed $\epsilon>0$, so any Cauchy sequence is either eventually constant or converges to the one non-isolated point. (Constructively: given some metric $d(x,y)$, take $d\prime(x,y)$ that equals 1 when $x$ and $y$ are both isolated and $\min(1,d(x,y))$ otherwise.) Since this is a theorem we can add later, I see no need to add a trait now.
As for the PR's content:
I didn't find the explanation for P23 (not weakly locally compact) to be very clear, since I interpreted "discrete subset" as meaning discrete with the subspace topology, rather than a set consisting of open singletons. I would rather write something like "a closed subset consisting of infinitely many isolated points".
In the descriptions, "Compare with {S#}" may be more helpful as "Compare with the finer/coarser {S#}" to emphasize the relationship between the two.

discrete with the subspace topology

I believe this is sufficient for non-compact: given an infinite closed set with a discrete subspace topology, choose open sets in the full space that contain exactly one point from the subspace. Then those open sets and the complement of the closed subspace are an infinite open cover of the space with no finite subcover.

n the descriptions, "Compare with {S#}" may be more helpful as "Compare with the finer/coarser {S#}" to emphasize the relationship between the two.

This is done

discrete with the subspace topology

I believe this is sufficient for non-compact: given an infinite closed set with a discrete subspace topology, choose open sets in the full space that contain exactly one point from the subspace. Then those open sets and the complement of the closed subspace are an infinite open cover of the space with no finite subcover.

Or easier: a closed subset of a compact space is compact.  But an infinite discrete space is not compact.

Or easier: a closed subset of a compact space is compact. But an infinite discrete space is not compact.

Lol yes, much slicker.

@danflapjax can this be approved?


[Component] Checkbox checked image bug

(Error, Success, Alert, Info, Neutral) intent's icon color was changed from onMain to onError, onSuccess, onAlert, onInfo, onNeutral. Snapshots were regenerated.
When you create checkbox group component first time. There was a small padding on top of component uikit side. It was't seen on demo project. I also fixed this small issue while I was regenerating snaphots.

Hello, We fixed checked icon color, but in this image border color is also wrong. It should be outline. I checked "checkbox component" on polaris side with demo project. Borders color seem as expected (outline).  I don't know which page is this but border color problem is from polaris side.

for test branch: component/checkbox_bug_803
snapshot tests also regenerated

@aycil-alican on demo app we don't have any themes except Adevinta one, so I think won't be able to test that.
The only think I can check is that Adevinta theme is still ok !

@elisa-hery, Hello, you might only test warning intent icon color. It seemed light but with this fix on demo project, It seems dark now

@aycil-alican  I checked colors on snapshots & on demo app for single checkbox :

UI kit light theme : ✅
UI kit dark theme : ✅
Swift UI light theme : ✅
Swift Ui dark theme : ✅

ℹ this ticket also include a fix : there was a small space issue on UI kit checkbox group

@elisa-hery thank you so much. Should I move this to ready for production column?

@elisa-hery Hello, It was revied thanks 🙋♂


feat(color): add color-black

Adds a new color variable $color-black with the value #000000.

Current coverage is 100% (diff: 100%)

Merging #155 into master will not change coverage

@@           master   #155   diff @@
====================================
  Files          19     19
  Lines         323    323
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          323    323
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update e4fe3c9...d8f98f5

@brnrdog our "black" color is $color-default-darker.
In theory, we don't have #000000 in Leroy colors palette. Usually if some layout uses #000000 we substitute to #333333.

@leandrogrillo I know about the $color-default-darker, but unfortunately it isn't dark enough to accomplish the visual specs of the project I'm working on. Since we have a $color-neutral with values of #ffffff, I though it would be worth to have a variable for #000000.


Suggestion: in onChange return "undefined" instead of "empty string" or "empty array"

Prerequisites

[x] I have read the documentation;
[x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description
When there is no data for checkbox or text input ... return undefined instead of empty string or empty array to be consistent with other field types.
From what I can gather based on recent commits this year.  The correct behaviour for NULL or clearing of an input field is to return "undefined".  This will cause the field to be removed from the JSON result data.  This is good in two ways.

It means that an empty string won't raise an error for being an invalid integer (for example).
The mandatory check kicks in.

Let's say I have a Name string field which is required.  Now normally (say for strings) an empty string is not a problem.  As the HTML "required" tag will cause the browser to prompt the user to input a string.
But now let's assume I have another error as well in my form ... could be anything, but for now assume it's a field whose widget (for whatever reason) doesn't support the "required" tag.   For me this was a custom checkbox widget to support a NULL value.   That's fine but when the error list is now displayed it tells me that my boolean value is required, but doesn't mention the empty Name string field.
Why?  Because an empty string is still a string.  From a validation point of view you HAVE a string.  Basically we're saved in most cases from this by virtue of the fact the "required" tag is kicking in.
I've noticed this on "string" fields and checkbox arrays ....
Yes ... mandatory on a checkbox array.  Although the current code doesn't support it, with this fix if you pass in "undefined" instead of empty array, and then also pass through the "required" parameter to Widget in Arrayfield it works.
You won't be able to use the "required" HTML tag for the checkbox list (that would mean you have to select every item), but the validation routine then picks up the error when you click submit.
I'll be submitting another bug (fix) for the required tag that would enable this shortly, but this would lay the groundwork for that as well.
Expected behavior
My suggestion is that to be consistent with other controls, when the string field is empty string "" it should return "undefined" like other controls.  Likewise an empty array [], should never be returned either in onClick, rather it should also return "undefined".
This makes it consistent, and allows the validation to work as well.
Actual behavior
String return an empty string "".  Which is still a string for validation purposes.
Arrays (like from checkboxes)  return an empty array []"  Which is still an array for validation purposes.
Version
Latest.
Not sure of the proper protocol for submitting patches,  but I have forked the project here:
https://github.com/crumblix/react-jsonschema-form
Made a meal of the commits ... lost an underscore in the first commit, but the combination of the two commits below in that branch is basically what I am suggesting.  Sorry it's not just on the one commit, but I can refork and clean it up later if you like the general idea.
Commit: 2aad37fa1e1ed2aad4bebd82cba137abaf634bc4 [2aad37f]
Commit: a901626fc7eff61e8bd3548f0c8d362022515914 [a901626]
(Diffs were here ... I've removed them since the formatting didn't work)
If you don't like it though I won't be offended :)
I'll submit the other changes for consideration shortly.

OK ... looks like the diffs didn't work well.  Ignore those!  Nonetheless the links to the changes seem good.
Sorry about that!

My suggestion is that to be consistent with other controls, when the string field is empty string "" it should return "undefined" like other controls

An empty string should be considered as a valid string value if the jsonschema allows that; undefined means the field has no value attached to it at all. Both are very valid use cases to me.
What we need is a way to "reset" a given field value, eg. with pressing a "clear" button next to the widget, so it's attached value switches from "" to undefined and reflects the change into formData.
This is currently discussed in #402.

OK.  I'll move the discussion there.  It's the age old battle of zero length string versus NULL.
I get that's a preference thing.
I'd prefer to leave this open as well for now though as it also is to do with arrays.  Is that OK?
Thanks!

Sure, we'll close according to the outcome of the ongoing discussions.

Sounds like an excellent plan :)
Not sure if I'm following correct protocol with these bug fixes/suggestions.  If you'd prefer I do it in a different way let me know.
Thanks!

Not sure if I'm following correct protocol with these bug fixes/suggestions. If you'd prefer I do it in a different way let me know.

Ideally pull requests are a great way to start good conversations, but I understand this may be overkill or frustrating sometimes. For now let's try to align on the strategy in the comments of #402.

It seems people are agreeing on this behavior and want to see it implemented in the lib, see ongoing dicussion in #402.
I'd like to make them happy and land this along #420, would you be willing to post your modifications as a single consistent PR so it's easier to review and discuss the implementation? Thanks!

As agreed, I'll merge my changes from #410 into #420 and take it from there :)

This has now all been wrapped up in a new PR #442.

#442 has landed and has been released in v0.42.0.


Heads UP: Copy edits complete

Docs Build status updates of commit accd167:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"issue" is missing in the Protocol box

I guess we want to enable the wallet to get credentials issued?

Yes!


Add support for sf and bbox class objects to filter_geom argument in arcgislayers::arc_select()

I'd love to see arcgislayers::arc_select() updated to add support for bbox class and sf class objects as a spatial filter. This is a basic example of a wrapper that would do the same thing – happy to take a look at the function and open a pull request to add this feature if it is welcome.
arc_select_filter_geom_ext <- function(..., filter_geom = NULL) {

  if (inherits(filter_geom, "bbox")) {
    filter_geom <- sf::st_as_sfc(filter_geom)
  } else if (inherits(filter_geom, "sf")) {
    filter_geom <- sf::st_geometry(filter_geom)
  }

  arcgislayers::arc_select(..., filter_geom = filter_geom)
}

I agree using a bbox would be quite useful to dispatch on. I do think using an sf object, though is a bit of a misuse of the object itself. There should be clarity that we are filtering based on a single geometry and not based on any attributes. For that reason I think limiting it to strictly geometric objects is important. A cli::cli_abort() could be raised when an sf object is provided with the suggestion to use sf::st_geometry() instead.

Overall, the error's and type handling here could be vastly improved:
https://github.com/R-ArcGIS/arcgislayers/blob/3a1254ac1c8d156e22419c964d7eb86ae9920daa/R/arc-select.R#L26

I can understand the preference to avoid support for {sf} inputs. I could make the case in favor but I don't feel that strongly about it.
I have two helper functions in {esri2sf} that would be easy to adapt into better input checks for filter_geom:

sf2geometry(): https://github.com/elipousson/esri2sf/blob/master/R/esri2sf.R#L472-L508
sf2geometryType(): https://github.com/elipousson/esri2sf/blob/master/R/esri2sf.R#L436-L469

Happy to start working something up and share a pull request next week sometime if it is helpful.


Add Book: PRO Git v2

What does this PR do?
Add resource(s)
For resources
Description
Add Book: PRO Git v2
Why is this valuable (or not)?
An update of previous book
How do we know it's really free?
Visit official git-scm web
For book lists, is it a book? For course lists, is it a course? etc.
A book
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Followup

Check the output of Travis-CI for linter errors!

Thanks, and welcome to free-programming-books!

@eshellman as it's my first PR, it's necesary I remove my branch like GitHub suggests me?

not necessary, but you shouldn't need it


Fix TestBrokerRedelivery

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

/retest

/test pull-knative-eventing-contrib-integration-tests

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

Worked, retesting
/test pull-knative-eventing-contrib-integration-tests

/lgtm

@pierDipi I think we should close here, and aplly to new repo?

@matzew Yes, I agree. I opened an issue to track this.
/close