[GH-12018] Remove the now unnecessary show prop from PopoverBar

Summary
The PopoverBar component is the bottom black bar that we see on an uploaded image's preview modal. Screenshot:

Previously, its show prop was used to conditionally show/hide the component on mouse enter/leave on modal. But now the component is set to permanently show directly via CSS, which makes the prop unnecessary and obsolete.
This PR:

removes the show prop from PopoverBar and its references from the component's parent ViewImageModal

updates unit tests and Jest snapshots accordingly

Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/12018

@hmhealey Thanks for approving. Cannot wait to see my first PR merged :)

@imisshtml Thanks for your time. Did you get a chance to finish your review?

These changes look good, thanks @hmhealey for testing this!

@imisshtml, @hmhealey - All being good, shall we merge and close this PR?

@anuragbhd Instead of rebasing and force-pushing, you can pull the latest version of master and merge it into your branch. We've got a bit of a guide for that here. I merged it in though so assuming the build passes, we should be good to merge this


Probable security issue, leaking file descriptors into terminal process

Issue Type: Bug
When running a process from the integrated terminal it seems some file-descriptors are inherited. For example my bash has some open file-descriptors to various asar and font files (and a lot of shared memory!).
To reproduce (on Linux) use the following command directly in the integrated Terminal: ls -l /proc/$$/fd
This lists all open files for the current process (the bash) from the /proc file system. If you use the -l switch it shows to which file the file-descriptor points too.

Example output (in summary because of long output)
$ ls -l /proc/$$/fd
total 0
lrwx------ 1 johannes johannes 64 Sep 17 12:10 0 -> /dev/pts/12
lrwx------ 1 johannes johannes 64 Sep 17 12:10 1 -> /dev/pts/12
lr-x------ 1 johannes johannes 64 Sep 17 12:10 10 -> /usr/share/code/pdf_viewer_resources.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 100 -> '/dev/shm/.org.chromium.Chromium.HWn72A (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 101 -> '/dev/shm/.org.chromium.Chromium.xhltP6 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 102 -> '/dev/shm/.org.chromium.Chromium.mGbMg5 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 103 -> '/dev/shm/.org.chromium.Chromium.tgA7H3 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 104 -> '/dev/shm/.org.chromium.Chromium.iQqruz (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 105 -> '/dev/shm/.org.chromium.Chromium.xo8u0x (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 106 -> '/dev/shm/.org.chromium.Chromium.VwDTi2 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 107 -> '/dev/shm/.org.chromium.Chromium.sptiBw (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 108 -> '/dev/shm/.org.chromium.Chromium.vRJj7S (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 109 -> '/dev/shm/.org.chromium.Chromium.8xnka2 (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 11 -> /usr/share/code/blink_image_resources_200_percent.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 110 -> '/dev/shm/.org.chromium.Chromium.Md4G4x (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 112 -> '/dev/shm/.org.chromium.Chromium.b7N4Y3 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 113 -> '/dev/shm/.org.chromium.Chromium.XvX6Cs (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 114 -> '/dev/shm/.org.chromium.Chromium.vdpNXz (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 117 -> '/dev/shm/.org.chromium.Chromium.AbehVB (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 119 -> '/dev/shm/.org.chromium.Chromium.JXv2T7 (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 12 -> /usr/share/code/content_resources_200_percent.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 121 -> '/dev/shm/.org.chromium.Chromium.o5F609 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 122 -> '/dev/shm/.org.chromium.Chromium.wRzQSD (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 123 -> '/dev/shm/.org.chromium.Chromium.Mr52wG (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 124 -> '/dev/shm/.org.chromium.Chromium.L6r02c (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 125 -> '/dev/shm/.org.chromium.Chromium.Kf0YyJ (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 126 -> '/dev/shm/.org.chromium.Chromium.t87X4f (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 127 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-B.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 128 -> /usr/share/fonts/truetype/liberation2/LiberationMono-Bold.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 129 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-B.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 13 -> /usr/share/code/ui_resources_200_percent.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 130 -> '/dev/shm/.org.chromium.Chromium.5vO06i (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 131 -> '/dev/shm/.org.chromium.Chromium.EU0YAM (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 132 -> '/dev/shm/.org.chromium.Chromium.Dq7802 (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 14 -> /usr/share/code/views_resources_200_percent.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 17 -> 'socket:[609354]'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 18 -> /usr/share/code/natives_blob.bin
lr-x------ 1 johannes johannes 64 Sep 17 12:10 19 -> /usr/share/code/snapshot_blob.bin
lrwx------ 1 johannes johannes 64 Sep 17 12:10 2 -> /dev/pts/12
lrwx------ 1 johannes johannes 64 Sep 17 12:10 24 -> 'anon_inode:[eventpoll]'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 255 -> /dev/pts/12
lrwx------ 1 johannes johannes 64 Sep 17 12:10 30 -> 'socket:[604449]'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 36 -> 'socket:[602066]'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 37 -> /usr/share/code/resources/app/node_modules.asar
lr-x------ 1 johannes johannes 64 Sep 17 12:10 38 -> /usr/share/code/resources/electron.asar
lrwx------ 1 johannes johannes 64 Sep 17 12:10 39 -> '/dev/shm/.org.chromium.Chromium.yM9tCr (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 4 -> 'socket:[43671]'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 40 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-R.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 41 -> '/dev/shm/.org.chromium.Chromium.C94wW5 (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 42 -> /usr/share/fonts/truetype/freefont/FreeSerif.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 43 -> '/dev/shm/.org.chromium.Chromium.pTAaGy (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 44 -> '/dev/shm/.org.chromium.Chromium.CiV1s5 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 45 -> '/dev/shm/.org.chromium.Chromium.PEZWfC (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 48 -> /usr/share/fonts/truetype/liberation2/LiberationSerif-Regular.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 5 -> /usr/share/code/icudtl.dat
lrwx------ 1 johannes johannes 64 Sep 17 12:10 51 -> '/dev/shm/.org.chromium.Chromium.yOHgod (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 53 -> /usr/share/fonts/truetype/liberation2/LiberationMono-Regular.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 54 -> '/dev/shm/.org.chromium.Chromium.xUg3RS (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 55 -> /usr/share/fonts/truetype/droid/DroidSansFallbackFull.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 57 -> /usr/share/fonts/opentype/noto/NotoSansCJK-Regular.ttc
lrwx------ 1 johannes johannes 64 Sep 17 12:10 58 -> '/dev/shm/.org.chromium.Chromium.0MbhSI (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 6 -> /usr/share/code/snapshot_blob.bin
lr-x------ 1 johannes johannes 64 Sep 17 12:10 60 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-RI.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 61 -> /usr/share/fonts/truetype/liberation2/LiberationMono-Italic.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 62 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-RI.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 63 -> '/dev/shm/.org.chromium.Chromium.WGxD5c (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 64 -> '/dev/shm/.org.chromium.Chromium.auH0iH (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 65 -> '/dev/shm/.org.chromium.Chromium.WW6CK2 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 66 -> '/dev/shm/.org.chromium.Chromium.rFgowb (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 67 -> '/dev/shm/.org.chromium.Chromium.yPgMJF (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 68 -> '/dev/shm/.org.chromium.Chromium.LEEjo8 (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 7 -> /usr/share/code/natives_blob.bin
lr-x------ 1 johannes johannes 64 Sep 17 12:10 70 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-RI.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 72 -> /usr/share/fonts/truetype/liberation2/LiberationSans-Italic.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 75 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-RI.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 76 -> /dev/ptmx
lr-x------ 1 johannes johannes 64 Sep 17 12:10 78 -> /usr/share/fonts/truetype/liberation2/LiberationSans-Regular.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 79 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-R.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 8 -> /usr/share/code/locales/en-US.pak
lr-x------ 1 johannes johannes 64 Sep 17 12:10 80 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-B.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 81 -> /usr/share/fonts/truetype/liberation2/LiberationSans-Bold.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 82 -> /usr/share/fonts/truetype/ubuntu/Ubuntu-B.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 83 -> /usr/share/fonts/truetype/oxygen/Oxygen-Sans.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 84 -> /usr/share/fonts/truetype/liberation2/LiberationSerif-Regular.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 85 -> /usr/share/fonts/opentype/font-awesome/FontAwesome.otf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 86 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-R.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 87 -> /usr/share/fonts/truetype/liberation2/LiberationMono-Regular.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 88 -> /usr/share/fonts/truetype/droid/DroidSansFallbackFull.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 89 -> /usr/share/fonts/truetype/ubuntu/UbuntuMono-R.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 9 -> /usr/share/code/content_shell.pak
lrwx------ 1 johannes johannes 64 Sep 17 12:10 90 -> '/dev/shm/.org.chromium.Chromium.9VuhX9 (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 92 -> '/dev/shm/.org.chromium.Chromium.pLcNaE (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 93 -> '/dev/shm/.org.chromium.Chromium.RU2r1N (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 94 -> '/dev/shm/.org.chromium.Chromium.JOHE9m (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 95 -> '/dev/shm/.org.chromium.Chromium.kLfShW (deleted)'
lrwx------ 1 johannes johannes 64 Sep 17 12:10 96 -> '/dev/shm/.org.chromium.Chromium.cV6mrv (deleted)'
lr-x------ 1 johannes johannes 64 Sep 17 12:10 97 -> /usr/share/fonts/truetype/liberation2/LiberationSans-Regular.ttf
lr-x------ 1 johannes johannes 64 Sep 17 12:10 98 -> /usr/share/fonts/truetype/freefont/FreeMono.ttf
lrwx------ 1 johannes johannes 64 Sep 17 12:10 99 -> '/dev/shm/.org.chromium.Chromium.fFzQBC (deleted)'

I can see no direct issue for now but it is possible to access files or shared memory this way and probably crash VScode this way. Additionally it is completely unexpected behaviour (i was stumped why my single-file python process had over 100 open file descriptors).
VS Code version: Code 1.27.1 (5944e81f3c46a3938a82c701f96d7a59b074cfdc, 2018-09-06T09:21:47.222Z)
OS version: Linux x64 4.15.0-34-generic
Ubuntu 18.04

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 1487)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
31.34GB (15.56GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions (26)

Extension
Author (truncated)
Version

EditorConfig
Edi
0.12.4

postgresql
JPT
0.0.2

better-toml
bun
0.3.2

npm-intellisense
chr
1.3.0

vscode-eslint
dba
1.6.0

vscode-dash
dee
1.10.0

jupyter
don
1.1.4

gitlens
eam
8.5.6

vscode-npm-script
eg2
0.3.5

vscode-npm
fkn
3.3.0

gc-excelviewer
Gra
2.1.26

todo-tree
Gru
0.0.86

node-module-intellisense
lei
1.5.0

restructuredtext
lex
78.0.0

rainbow-csv
mec
0.5.0

ecdc
mit
0.12.0

python
ms-
2018.8.0

cpptools
ms-
0.18.1

vsliveshare
ms-
0.3.666

vscode-versionlens
pfl
0.21.1

vscode-sort-json
ric
1.13.0

vscode-icons
rob
7.26.0

rust
rus
0.4.10

vscode-hexdump
sle
1.6.0

vscode-lldb
vad
0.8.9

debug
web
0.22.0

If I'm understanding you correctly, I'm not sure how this sort of thing could happen. A pty is forked here:
https://github.com/Microsoft/node-pty/blob/80fcc8ccf15c2a2f2649fdca9a48411ffdd24ad9/src/unix/pty.cc#L693
And the process is launched here:
https://github.com/Microsoft/node-pty/blob/80fcc8ccf15c2a2f2649fdca9a48411ffdd24ad9/src/unix/pty.cc#L413
You seem more familiar with what's going on so if you have any insights into how this could happen that would be helpful.

That's the problem here, there are multiple ways to do that. The cleanest way would be that all opened files would be opened with the O_CLOEXEC flag set. That's not purely a function of the pty/terminal code but a more fundamental node/electron thing. (And sometimes you actually want to inherit those file descriptors, for example the pty itself or shared memory for the various child processes electron uses)
There are some "workarounds", one is to manually loop through all possible open filedescriptors (0 to getrlimit(RLIMIT_NOFILE, &rlim), and others, see for example https://stackoverflow.com/a/21952155) and set the flag with fcntl(fd, F_SETFD, FD_CLOEXEC); before calling the exec. This will absolutely slow execution of processes down as there's no list of open file descriptors (well, kind of, there is on linux but I am not sure if that holds for other OSs), you'll have to try them all and ignore errors.

/cc @jerch

@Tyriar
Thats one of the issues I stumbled over when I worked the reimplementation of node-pty and the process tracker. I decided to force close left over fds before I ended up using the fork c helper through the childprocess API (libuv handles this correctly already by duping them with O_CLOEXEC).
Imho a serious bug in node-pty, it might even leak the fds to subprocesses (depends on the shell, imho zsh wipes them while zsh doesnt or vice versa, cant remember).
Only chance we have imho is looping through it. Id even vote for closing any fd > 2 before exec, since thats all a pty connection needs.

Bash seems to leak them at least. Not using z-shell or something other here so I can't comment on this.

Edited the typo above.
@dunkelstern If you like to write a patch, node-pty is the place to go.

I am looking to send a patch on the weekend. So looping through all descriptors is fine in your opinion too?

@dunkelstern Not sure if it will break other things, as it would also close fds that are leaked by purpose (my process tracker relied on that, some debugger might also). I guess only a member of vscode can tell if they utilize this behavior to some degree.
Leaving it open I'd see as an security risk (the fds will survive a setuid call), maybe node-pty needs some kind of API to tell, which fds should stay open after the fork. Then everything else can be closed safely.

Any idea whom/where to ask for something like that?

Testing all one by one is, well tendious, errorprone and might lead to a false assumptions.
For vscode you could trace from the pty process caller upwards and see if there are some suspicious pipes/filehandles etc. placed (just strace for files, pipes and sockets - those are possible targets). The extension thing complicates this further, not sure if an extension can place such primitives into the vscode process that calls the pty.
But note, node-pty gets used in many other places too, not only vscode. Therefore I think an API extension in node-pty to announce left open fds is more failsafe and would give enough security.

I don't think this is an issue because the pty launched by node-pty by design is always launched at the same permission level as what it's launched from, therefore the pty can do anything of the parent process anyway. As an action item I'll make a note on the node-pty readme about what not to do https://github.com/Microsoft/node-pty/issues/230


Add templating for new repos

e.g. cookiecutter, copier
Is it possible to have this repo still work after templatifying it?

Done across the following commits:

a05e7d4 Add cruft config to skip git internals
70ecef3 Bump nix dependencies
f805657 Fix cruft extra, it's pyproject not toml
27e4590 Include toml extra for cruft
e5326fa Add context to cruft JSON
bdb960b Add additional fields to cruft.json
e786042 Fix for loop to use newline as IFS
32c8f7a Attempt to generate cruft commit JSON
cbeb600 Fix order of sed arguments
41a324b Update template generation workflow to rewrite fully
c0aeeb6 Add 'act' to standard dev dependencies
b7ed3ee Commit all files in post-generate hook
fd85973 Add post-generate hook for initializing git repo
83173fe Move template support to a dotted directory
0b6ec0d WIP on cookiecutter template


Memory problems with custom dataset

For gaussian-opacity-fields it appears that grads and grads_abs may not be getting cleared correctly between calls of densify_and_prune(). They seem to double in size each time, eventually leading to out of memory errors. As such, simply changing memory parameters or environment variables does little to help. What is the best way to manage this size during training?

Hi, thank you for your question. Grads and grads_abs doubling in size means that the number of gaussians doubles each densify step; am I right? From my understanding, the issue is caused by GOF, not by nerfbaselines (it calls GOF code internally). If that is the case, asking at https://github.com/autonomousvision/gaussian-opacity-fields might be better. I believe the issue can be the scale of your scene. I would recommend trying to adjust the densification and pruning thresholds. Btw, do you have the same issue with gaussian-splatting or mip-splatting?

We don't seem to have it with gaussian-splatting or mip-splatting. I will ask at gaussian-opacity-fields.

Closing the issue as it seems to be the issue with GOF rather then nerfbaselines.


add ceres

Build failed because of:
No cached entry, and CERES has issues with logo: ceres.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/ceres.svg'


✨ Initial commit for the justify-content

Pull Request Template
Description
Created definition file for j
Fixes # (issue) # 16
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X] Verified that added/modified attribues are properly loading on browsing
[X] Verified that added/modified attribues editing templates are properly rendered
[X] Verified the putput on changes
[X] Verified the deployment

Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests(if any) pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings

@all-contributors please add @atapas for code


How to fallback on default language for unsupported language

Hello
I have an app with 2 supported languages 'fr' and 'en'.
Is there a way to configure a fallback for any other detected language?
If not yet, the following should be nice to use:
var i18next = require('i18next');
var middleware = require('i18next-express-middleware');

i18next
	.use(middleware.LanguageDetector)
	.init({
		fallbackLng: ['en'],
		detection: {
			order: ['querystring'],

			// unavailable but nice to have option
			supportedLanguages: ['fr', 'en'],

			// keys or params to lookup language from
			lookupQuerystring: 'lng',

			// cache user language
			caches: false, // ['cookie']
		}
	});

http://server:port/lng=fr  	-> req.language is 'fr'
http://server:port/     	-> req.language is 'en' (fallbackLng)
http://server:port/lng=zzz 	-> req.language should be 'en' (fallbackLng) since 'zzz' is not in supportedLanguages

does it not work? should work like this.

I doesn't work.
Actually, I don't see supportedLanguages as an option in Language detectors, and supportedLngs is no more part of i18next v2 options.
Well, may be the problem is with i18next, not i18next-express-middleware?

ah...yes...it's not supported it's whitelist on i18next:  http://i18next.com/docs/options/#init-options

Thank you @jamuhl ! This is what I was looking for.
The working code with whitelist on i18next options:
var i18next = require('i18next');
var middleware = require('i18next-express-middleware');

i18next
    .use(middleware.LanguageDetector)
    .init({
        fallbackLng: ['en'],

        whitelist: ['fr', 'en'],

        detection: {
            order: ['querystring'],

            // keys or params to lookup language from
            lookupQuerystring: 'lng',

            // cache user language
            caches: false, // ['cookie']
        }
    });

And now
http://server:port/lng=zzz -> req.language is 'en' (fallbackLng) since 'zzz' is not in whitelist


Logging of Avg CPU Power and Avg GPU Power does not work

Currently, there's an option to show Avg CPU P and Avg GPU P but it does not work. And there's no way to input sensor and element IDs  to also make them work. Would really appcreciate it if it can be fixed as I'd love to log them.

Are you using HWiNFO or MSI Afterburner?

I've tried using both. On MSI I turned on all active monitoring graphs and it still doesn't work

With the last release, it's possible to add power element with HWiNFO.
If you use MSI Afterburner, could you send your logs?

I seem to be having this issue as of now as well with HWiNFO on SharedMemory. All elements seem to be working fine except for both GPU and CPU power. When checking the Shared Memory Viewer, everything seems to be all working correctly there.

I'm having this same issue with GPU Power only. CPU power works.
I use a Rainmeter skin that shows both of these metrics just fine. I'm using the exact same sensor and element IDs in both rainmeter and GameActivity, yet GameActivity shows Avg GPU power as 0W.


refactor: allow the mock module to be used multiple times as base ibc application in middleware stack

Description
Currently the AppModule assumes a single scoped keeper. This doesn't allow the mock module to be used as a base application for different middleware stack (ica stack, fee stack, etc)
I broke the API because I think it is cleaner. If we want this to be non API breaking, I can try to readjust
ref: #891

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Would you mind expanding the context a little bit more as to what problem we're solving with this PR?

Yea of course. This is one of the trickiest parts of IBC to understand. The SDK doesn't allow multiple instantiations of AppModule. Each port is bound by the port keeper but claimed by a specific scoped keeper. The scoped keeper claiming the the port capability is what allows the callback to be routed to the correct handler. The mock module exists so that it can act as a stand in IBC/App module so we can mock expected behaviour without developing custom modules. Currently, the mock AppModule has a single scoped keeper which claims the port capability. So if you instantiated the mock AppModule with the IBCMockScopedKeeper, then the IBCMockScopedKeeper would claim port (for all mock IBC applications)
Concretely:
Current behaviour:
mockfee port would route to mock IBC module
mock would route to mock IBC module
mockcustomapp port would route to mock module
Desired behaviour:
mockfee port routes to fee IBC module
mock would route to mock IBC module
mockcustomapp port route to top level of the custom stack
By allowing the AppModule for mock to pair scoped keeper/port ID we can properly claim the capability. The scoped keeper for mock fee would claim mockfee port and there would be a route in the router going from mockfee -> mockFeeIBCModule (ics29 as first to receive the callback)
Does that make sense?

Would you mind expanding the context a little bit more as to what problem we're solving with this PR?

Yea of course. This is one of the trickiest parts of IBC to understand. The SDK doesn't allow multiple instantiations of AppModule. Each port is bound by the port keeper but claimed by a specific scoped keeper. The scoped keeper claiming the the port capability is what allows the callback to be routed to the correct handler. The mock module exists so that it can act as a stand in IBC/App module so we can mock expected behaviour without developing custom modules. Currently, the mock AppModule has a single scoped keeper which claims the port capability. So if you instantiated the mock AppModule with the IBCMockScopedKeeper, then the IBCMockScopedKeeper would claim port (for all mock IBC applications)
Concretely:
Current behaviour:

mockfee port would route to mock IBC module
mock would route to mock IBC module
mockcustomapp port would route to mock module

Desired behaviour:

mockfee port routes to fee IBC module
mock would route to mock IBC module
mockcustomapp port route to top level of the custom stack

By allowing the AppModule for mock to pair scoped keeper/port ID we can properly claim the capability. The scoped keeper for mock fee would claim mockfee port and there would be a route in the router going from mockfee -> mockFeeIBCModule (ics29 as first to receive the callback)
Does that make sense?

Knowledge :bomb: Thanks for the details!

Adding the backport label, since the ibc mock functionality for middleware stacks is a feature of v3, it makes sense to backport


Fix #9174

Setting external methods did not throw an error when that method didn't exist.
This commit updates the code to throw a not found error.
I want to merge this change to fix an open issue and contribute to a project I may use.
Fixes #9174.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @SethThoburn!
Thanks for your first contribution 👏
Looks like black is failing - https://github.com/saleor/saleor/runs/5880817298?check_suite_focus=true.
Can you apply black changes and push once again?
For future PRs you can also install pre-commit
https://docs.saleor.io/docs/3.x/developer/community/contributing#coding-style

I just formatted with black and pushed again!


Add links to ranking pages from stat var chips

Also carry over params so the per capita, unit and scaling match the original charts.

This PR fixes quite a few issues at once, so it might be easier to review a commit at a time.


Run appveyor on php 8

Thank you. But I think we should move forward with #227  instead.

Thank you. But I think we should move forward with #227  instead.


Support for Cocoapods resource_bundles

I use R.swift in a dynamic framework which organizes all the images for the main project and other frameworks. After the dynamic framework building successfully, but the image I access in main project is nil.
This is the code: let image = R.image.driver_task_calender()
After check, I found the let hostingBundle = Bundle(identifier: "com.**.**") ?? Bundle.main is wrong.
I think this is the correct hosting bundle ：
var hostingBundle: Bundle {
        let podBundle = Bundle(for: TheClassName.self)
        if let bundleURL = podBundle.url(forResource: "TheBundleName", withExtension: "bundle") {
            if let bundle = Bundle(url: bundleURL) {
                return bundle
            }
        }
        return podBundle
    }

Expect to get help.

I organized the framework by cocoapods, in the dynamic framework place a spec file. In the spec file:
s.resource_bundles = { 'JFoundation' => ['JFoundation/Resources/**/*.{storyboard,xib,xcassets,json,imageset,png}'] }

Thanks for using R.swift and reporting this issue.
I've fixed this issue in the latest release of R.swift, version 3.2.0. If you upgrade to that version your problem should be solved! Please let me know if you still have troubles using R.swift from a framework after upgrading. :)

please do not close the issue. After upgrading there are something wrong, I think you should upgrade the R.swift and add some script, like adding --accessLevel public to the call to R.swift to use R.swift in a library. To distinguish the different situation between using in main project and dynamic framework.
the correct hosting bundle :
var hostingBundle: Bundle {
        let podBundle = Bundle(for: TheClassName.self)
        if let bundleURL = podBundle.url(forResource: "TheBundleName", withExtension: "bundle") {
            if let bundle = Bundle(url: bundleURL) {
                return bundle
            }
        }
        return podBundle
    }

your hostingBundle generated by R.swift :
fileprivate static let hostingBundle = Bundle(for: R.Class.self)

Expect to get help.

Ah alright, so basically you're asking for support for Cocoapods resource_bundles feature.
This is basically pulling your library apart and moving things over to another bundle, I can take a look if this is something we can support. Not sure when I have time for it, if anyone has any idea how R.swift should detect that resources are moved to another bundle you're very welcome to share it!

I've encountered the same issue as @wangguangfeng in the project I've been working on, and since no official solution exists (yet) I've decided to fix it using some bash magic.
In short, the solution I am using involves modifying the R.generated.swift file (right after it gets generated) and replacing the hostingBundle value with the correct bundle for my Pod library.
First I've defined a class that represents my Pod resource bundle:
class ResourceBundle: Bundle {
    static var bundleURL: URL {
        let url = Bundle(for: ResourceBundle.self).bundleURL
        return bundleURL.appendingPathComponent("TheBundleName.bundle")
    }

    static var sharedBundle: ResourceBundle? {
        return ResourceBundle(url: bundleURL)
    }
}

Then I modified the custom Run Script build phase that executed the rswift command:
# run the 'rswift' command to generate the constants file
"$PODS_ROOT/R.swift/rswift" "$SRCROOT"

CODE_TO_REPLACE="Bundle(for: R.Class.self)"
CODE_REPLACEMENT="ResourceBundle.sharedBundle as! Bundle"

# replace the bundle creation in the generated code
sed -i '' -e "s/$CODE_TO_REPLACE/$CODE_REPLACEMENT/g" "$SRCROOT/R.generated.swift"

With this simple fix we can fully benefit from the generated constants file in our Pod libraries!

Hello @mac-cain13, first of all thanks for making R.swift, it's a great library! Not sure if it's the right place for that but like @EvsenevDev I would also be interested in this feature. In the meantime thanks to @wojciechczerski for the workaround :)

We'll discuss support for bundles further in #186

@wojciechczerski's solution https://github.com/mac-cain13/R.swift/issues/295#issuecomment-328984986 is great and works. I would suggest improving it slightly to be more similar to the file auto-generated by SPM for resources (Bundle extension file that adds a Bundle.module accessor)
final class BundleHelper {
    /// Returns the resource bundle associated with the current Swift module.
    static var bundle: Bundle = {
        let bundleName = "YOUR_BUNDLE_NAME" // Do not include extension ".bundle"

        let candidates = [
            // Bundle should be present here when the package is linked into an App.
            Bundle.main.resourceURL,

            // Bundle should be present here when the package is linked into a framework.
            Bundle(for: BundleHelper.self).resourceURL,

            // For command-line tools.
            Bundle.main.bundleURL
        ]

        for candidate in candidates {
            let bundlePath = candidate?.appendingPathComponent(bundleName + ".bundle")
            if let bundle = bundlePath.flatMap(Bundle.init(url:)) {
                return bundle
            }
        }

        assertionFailure("unable to find bundle named \(bundleName)")

        // Return whatever bundle this code is in as a last resort.
        return Bundle(for: BundleHelper.self)
    }()
}

Then for the modified script:
Then I modified the custom Run Script build phase that executed the rswift command:

# run the 'rswift' command to generate the constants file
"$PODS_ROOT/R.swift/rswift" "$SRCROOT"

CODE_TO_REPLACE="Bundle(for: R.Class.self)"
CODE_REPLACEMENT="BundleHelper.bundle"

# replace the bundle creation in the generated code
sed -i '' -e "s/$CODE_TO_REPLACE/$CODE_REPLACEMENT/g" "$SRCROOT/R.generated.swift"

Feel free to then use that class throughout your library without fear.
By making sure to use the same bundle name that SPM would auto-generate in the podspec resources_bundle, you can then enable supporting both SPM and Cocoapods!


ExampleService works if I run through VS, but not with dotnet command

Hello,
I'm having an issue when I install your ExampleService (non-timer version to simplify it).  If I edit the ServiceRunner, line 18 to manually specify ActionEnum.Install, I can get the ExampleService to install and run on my Windows 10 box.  However, I have an issue when I attempt to install and run the ExampleService via dotnet commands.  Here's what I'm doing:
Steps

Open Admin command prompt and navigate to the folder PeterKottas.DotNetCore.Example on my harddrive.
Issue dotnet publish command while in that directory
Subsequently nav down to ..\bin\Debug\netcoreapp1.1\win81-x64\publish (where thePeterKottas.DotNetCore.Example.dll) is located
Issue dotnet PeterKottas.DotNetCore.Example.dll action:install command

Result
The service installs and shows up in the Services mmc.  However, it won't start.  The error I receive is "The service did not respond to the start or control request in a timely fashion".  I thought it might be a permissions issue, but if I use box admin credentials manually on the installed service, it still won't start.
Any ideas?

Update
I was able to get it to work outside of the IDE.  I had to target a specific runtime in my project.json (win10-x64 in my case) so my own console application would generate an exe.  I then did the publish, navigated to the publish directory and didn't use dotnet to run it.  Instead I ran the exe with action:install and it worked!
I hope that helps you, I know I was struggling a bit with this.

Thank you so much.  I will give this a try!

Morning guys, thanks Sepaphoria, that definitely works :) that's actually what I was doing with all my services so I never even encountered this, gave it a shot yesterday and the indeed is a problem with running even the simplest code with dotnet. I have an idea on what I could try but for now feel free to use that *.exe approach. Portable apps seem to work just fine. I'll let you both know when I have any news about this. @PaulCoetser I will use this issue as it specifically meant to solve this problem.

Hi @Sepaphoria & @PaulCoetser  . Good news. I've fixed the problem and the solution is now available via nuget. Release version is 1.0.13. Would be great if you could try it so that I can close the issue :) There's also one minor fix. I've seen the service fail to reinstall from time to time saying the service is marked for deletion. This is now handled via retries and all works well.


Fix indentation in example

Please check the rest of the examples :smile:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Question] Game Package Registry

Unity editor version: 2020.2.4
Firebase Unity SDK version: 7.1.0
Source you installed the SDK:UPM
Problematic Firebase Component: Crashlytics
Other Firebase Components in use: Analytics
Additional SDKs you are using: AppsFlyer
Platform you are using the Unity editor on: Mac & Windows
Platform you are targeting: iOS, Android
Scripting Runtime: IL2CPP

I'm following github and would love to ask for an update on the UPM issue.
I see that was removed from Firebase setup instructions.
As mentioned by @uchar , keeping things in the UPM is so much better for all possible reasons.
I found and follow the link https://laptrinhx.com/managing-the-firebase-unity-plugin-the-easy-way-1600281350/ to configure in my project.
I'm at the moment having some issues having Firebase running on the mobile devices. But without proper instructions on the Firebase documentation is hard to understand where the issue is.
My question is, isn't this registry made by Google?
Name: Game Package Registry by Google
URL: https://unityregistry-pa.googleapis.com
Scope(s): com.google

I can see there the latest updates of the Firebase.

@CoderGamester
Yes, this registry is made and maintained by Google.
Let me know if you have any additional question.

You are right.
It seems the issue I was having was trying to build the App with Armv7 & Arm64 was creating issues.
By completely cleanning up the Firebase plugins and adding it back again we were able to make Firebase Analytics work for both iOS & Android.
We decided to drop the use of Crashlytics to avoid any further complications and use Unity's solution for the moment.
Thank you for the indication


Documentation fixes

I have no idea what the deal is with the newline changes nor can I seem to remove them. I have core.autocrlf=true in my settings and they shouldn't occur due to the .gitattributes but it appears that git doesn't care for some reason.

Can you squash and rebase? It will be much easier to review.  Also, commits that merge master back into your branch can really make the Ghidra git history messy.

Can you squash and rebase? It will be much easier to review. Also, commits that merge master back into your branch can really make the Ghidra git history messy.

I can. I had only merged it when there was something that needed to be pulled in to fix. There are actually a couple more to fix so I'll squash everything down later today.

I tried to reinsert the trailing whitespace into ConcurrentQ but git won't see the changes. I checked how the ConcurrentQ  documentation appears in Eclipse and it looks ok.

Superseded by #2603

Superseded by #2603


[debt] Many ResourceWarnings when PYTHONWARNDEFAULTENCODING = 1

In jaraco/skeleton, I've rolled out PYTHONWARNDEFAULTENCODING=1. Merging that change into Setuptools causes the test suite to fail due to pytest.ini:filterwarnings[error].

The rule is still in "preview", but this can be checked for setuptool's own code using https://docs.astral.sh/ruff/rules/unspecified-encoding/


Added zip for up to 10 variables

I added zip for Tagged for up to 10 variables. I use this quite a lot, hope you find it useful.

Hey @buscarini! Thanks for the PR. Could you share some examples of how you've used it? Definitely sounds interesting but would love to better understand how it's helped you.

Sure! I've used it mainly for operating with multiple values tagged with units. In some projects I tag strings that are ready to be displayed to the user, and I sometimes need to combine those.

Hey @buscarini! After sitting on this awhile I think we're going to hold off for now. While it's a totally valid and cool operation that the Tagged type has, because Swift lacks abstraction over zip, we're not sure it's worth the API surface area over manually unwrapping and wrapping the values. I think we'd be down to revisit in a future where variadic generics is available so that it doesn't have quite as great of an impact on the API, though!
Thanks again for taking the time to suggest and PR.


Explanation of exclusive option in procedure invocation on SERVER page

Exclusivity works as additional level of procedure execution control, so I decided that it worth explicit description in Multithreading section at SERVER page.

Please review @tshemsedinov . This PR adds small paragraph in 3 sentences.


image_types_ostree: refactor garagesign task

To enable usage of the Uptane's 'ota-tuf' repository for uptane-sign, we need to change this task. Since in more recent releases there, the tool name has changed from 'garage-sign' to 'uptane-sign'.
This way, we set the name of the tool used in a customizable variable, defaulting to 'garage-sign', and if anyone wants to use the latest version of this tool (given Aktualizr was also refactored), they just need to set this new variable with the tool name.

Makes sense +1

@cajun-rat, @quaresmajose, I submitted this change to master branch, but it would be nice if we could also cherry-pick it to scarthgap!
Would it be possible? Should I open another PR on scarthgap for this?

In my opinion it would be better to wait for the merge and then open a new PR using git cherry-pick -s -x

Hey guys, any pending reviews/actions here? Can we merge this?


feat: flashbots

Description

feat: submission of bundles via Flashbots Builders
refactored Bundling Service
feat: configurable size & interval of bundling
feat: timeout for flashbots submission (5 minutes?)
fix: better handling of failed userops

Tested on Sepolia
https://sepolia.etherscan.io/tx/0xcf1589b7e80e0d6f22b13e8aa6425c61c90bf127ec34b5bf02fa85766809627f
There's some weird issue on Sepolia. https://relay-sepolia.flashbots.net is always returning "internal server error" even if a bundle is successfully submitted (I've reported it to devs on Discord)
Tested on Goerli:
https://goerli.etherscan.io/tx/0xab98000a3f9bade11eeb4fffb4c05ba8784da9c39b3136d97319943e4dc18669
https://goerli.etherscan.io/tx/0xf89d34b8147798856dae5e449f5c517d41fde642df975784c60a00df5d995f4c
https://goerli.etherscan.io/tx/0xbb95249afa472327bcdbdfe297c8a669cf55e317fb203c84b0eee7166c332c15
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Further comments (optional)

I've addressed issue #124 in this PR, but not other 2. And I've refactored BundlingService with the issue #125 in mind, so it should be easier to implement.

@ch4r10t33r Looked into it. It's not related to Flashbots and this is the same issue that we're having on Polygon (ticket PRO-2045) We're losing money when a bundle's gas price is equal to a userop's gas price.
I will address it in a separate PR since it's not related to Flashbots and we have a separate ticket for this issue.


Should do "check" operation concurrently

The perfinfo is gathered concurrently (so if one has a lot of services configured, the performance metrics are gathered in parallel).
The check/status action should behave similarly. Each service only takes a second to check, but that could add up if there are lots of services configured.
Essentially, we should use that model for any operation that does not change state.

Done at c42c449720ec10197cd92d7b3b7c0e676bff7348


Door crashing game

Describe the bug
When you look at door with weapon, game crash.
Reproducibility
Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

[X] I reproduced this issue with as few other mods as possible installed.
[ ] I am unable to reproduce this issue consistently.

To Reproduce
Steps to reproduce the behavior:

In mw.cfg set "enableAmmoCounter" to false
Create new world
Take weapon
Select weapon at door

Screenshots or/and videos
https://streamable.com/tcmc9e
Logs or/and crash reports
https://mclo.gs/kKUlTQe
Versions

Modern Warfare Cubed: paneedah-modern-warfare-0.1-Dev-5
Forge: 1.12.2 - <IP_ADDRESS>59
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation

Specification:

OS: Windows 10
CPU: AMD ryzen 5 PRO 4650G
GPU: NVIDIA GeForce RTX 3060 Ti
RAM Allocated: 5GB

This issue would also be related to your severely outdated Java version.
Please update Java here: https://adoptium.net/en-gb/temurin/releases/?version=8

Please test this again after updating Java

Please test this again after updating Java.
It appear you might be using the Curse Forge launcher if so follow these instruction to change the Java that Curse Forge launcher uses once newer Java installed https://youtu.be/EGUsEq6HOd0?t=25

I believe this issue was already addressed previously. Please test again using Dev-10.

Nevermind, this issue was found and addressed for the 0.1-Dev11 version.

Correction, a safe guard as been put in place for the issue not to happen, the issue is sadly not fixed yet.
It will be in the future though


Allow setting a minimum bid value to determine whether or not to use a block supplied by the builder API

Currently users are required to make a binary choice between using a centralized block builder or forgoing MEV.
MEV-Boost should allow user's to set a fixed fee (e.g. 0.2 ETH) under which they will use a locally produced block.
In this way validators can gain exposure to large MEV opportunities while still contributing to decentralized block building when MEV is small/non existent.
Additionally, as the CL does not currently have a view into the value of a locally produced block, this provides some protection to user's from relay's producing very low value blocks.
In the future this can be enhanced by comparing the value of the locally built block vs. the remote builder's submission and using a fee delta instead of a fixed fee.
Originally submitted as an issue to a few CLs but it was suggested that it would be better to implement it in MEV-Boost.
https://github.com/ConsenSys/teku/issues/6140
https://github.com/sigp/lighthouse/issues/3517

I took a stab at the PR, I have minimal GO experience but it seems to work fine.

@metachris any thoughts on this?

Thanks for the contribution! And sorry for being slow to respond on this. It was on the radar, but due to the merge there were so many other priorities.
I wonder if there's an appetite for this feature from a wider audience. Could people please signify their interest by 👍 the initial comment above?

@allboxes, I think this PR is step in the right direction given that many people are wary of running mev-boost especially since the mev-boost reward has the possibility of being less than the reward you would have earned from a locally produced block. I have 2 comments (although this may be beyond the scope of the PR)

There are 2 types of min bid, absolute min bid and relative min bid. I take it this PR is an absolute mid bid, but it would also be useful to have the option to specify a relative min bid which would be the min bid above the reward you would receive from a locally produced block

Is there a way of transmitting this information to the relay? Under this implementation if I have a min bid of .1 eth will the relay realize this and only submit bids of .1 eth or more? Will the bid immediately be rejected, giving the relay the opportunity to submit a higher bid? Or will the low bid be silently ignored? The last case seems sub-optimal if the relay is willing to bid higher but did not know of the min required bid of the validator.

@jumboshrimp100, responding here to keep the PR clean.
The PR/issue is just for the absolute bid and this value is not exposed to the connected relays.  There is ongoing work on exposing the local block value to the CL so that the CL can compare between builder blocks and the local block.  If/when that functionality is implemented in the CLs/ELs it will make min-bid in MEV-Boost largely obsolete (unless there is desire to enable 2-way communication with the relays, which make or make not make sense given the complexity/game theory/additional latency concerns)

for reference, this is the EL APIs issue: https://github.com/ethereum/execution-apis/issues/307 about exposing the block value

@allboxes thanks for your contribution! It's a great feature.


Docker Toolbox EOL

https://github.com/docker/toolbox/issues/898

No abandoned, see https://portapps.io/news/2020-11-04-docker-toolbox-portable-abandoned/


Add perf exporter

Signed-off-by: Daniel Hodges<EMAIL_ADDRESS>

Hmm, does this cover things that the ebpf exporter doesn't? We try to avoid overlap on this page.

It uses kprobes directly, eBPF programs (generally) need to be compiled with kernel headers unless another eBPF frontend is used like in this project. The main benefit that the perf_exporter has is that by using kprobes directly you don't need to compile any eBPF programs. So much in the same way a helicopter and airplane are both methods of flying the means of doing so is rather different.

From https://github.com/cloudflare/ebpf_exporter#examples there seems to be overlap, and your exporter is quite new.


feat: support ARN as type argument

Fixes #10

@hoegertn please make sure to request a review next time so it doesn't slip under my radar.


some Local SVG's not working while others are fine

I'm attempting to display an SVG by doing the following
import FooBar from "./../../assets/<filename>.svg";
then later in the project
<FooBar height="40" width="40" />
what I get is some SVG we have work like this:
This SVG just shows blank:
(Screenshot)

(SVG)

Other's show washed out:
(ScreenShot of the icon in React vs the browser)

(SVG which is washed out)

And others display normally as expected
(Screenshot in React App)

(SVG)

This behaviour is the same in the iOS and Android emulators as well as physical android devices.

Forgot to note that we were seeing this on 12.3.0 so I updated to 13.4.0 and still seeing the same issues. (Also the Folder Icon above now I see it here also looks washed out)

Im getting this error which I think is similar -
Fetching file:///data/user/0/com.tribefy.tribefy.dev/cache/ExponentAsset-9b3d6b13a27b0c8c74eba357365f270c.svg failed with status 0
at node_modules/react-native-svg/src/xml.tsx:132:17 in fetchText
- ... 13 more stack frames from framework internals

did you solve this? I have the same washed out problem with one of my svgs

Hello,
If you still have that problem, please provide a simple example to reproduce that.
Thank you.


zsh: fix completion when oh-my-zsh is enabled

enableCompletion option not only calls compinit but also adds
nix-zsh-completions package to home.packages which should still happen
even if oh-my-zsh is enabled.
The double compinit call will still be eliminated by moving guarding condition
down to the compinit call itself.
Fixes #771.

We should probably backport it to release-19.03 as well.

Thanks, done :)


Add PriorityClass support

Hi, I thought that it would be very helpful to be able to add a PriorityClassName to the Deployment, so here's my humble contibution.

Thanks @stg-0 . Can you also bump the chart version and run the make helm-update please?

Thanks @stg-0 . Can you also bump the chart version and run the make helm-update please?

done!

great. thanks @stg-0 !


What about the rest of the activation kinds? there is a lot more than 3

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 48c16388-7620-4e40-8cf9-fd1157af7a77
Version Independent ID: 03be4303-f85f-52b8-351f-2bfd357990c7
Content: AppActivationArguments.Data Property (Microsoft.Windows.AppLifecycle) - Windows App SDK
Content Source: winapps-winrt-build/xml/Microsoft.Windows.AppLifecycle/AppActivationArguments.xml
Product: reunion
Technology: reunion-reference
GitHub Login: @alvinashcraft
Microsoft Alias: aashcraft

Hi @KWodarczyk. That's a great question. I'm sorry for the delay in replying. I'm trying to track down someone on the product team who can help get an answer, so we can improve the docs for this API. I'll keep you updated on my findings.

Launch was missing. I added that and also added a note that those are the only four kinds currently supported by Windows App SDK here. The changes should be live later today.


[routing-manager] determine route preference from parent link quality

This commit updates how RoutePublisher determines the published route preference:

Medium preference is used on a border router (BR) acting as a router or a BR acting as an end-device (ED) connected to a parent with link quality 1.
An ED BR with lower link quality publishes its route with low preference.

For ED BRs, the preference is updated if the parent's link quality changes. However, to avoid frequent preference changes due to link variability, the following rules are used:

If the link quality goes to 2 or 3, the route preference is immediately changed to low.
On transition to link quality 1, we wait for 5 minutes before changing the preference to medium.
If the ED BR switches parents, the link quality to the new parent is used to determine preference.

It also adds new APIs and related CLI commands to allow users to get and manually set the published route preference. A new test script test-021-br-route-prf.py is added to validate the selection of route preference by BR.
This commit also add a new mechanism to detect when the link quality to the parent changes and signal it using a newly added Notifier event.

Related to SPEC-1190.

New push contains the (squashed) commit from (now closed) PR:

https://github.com/openthread/openthread/pull/9094


counting image hit , Need some guide

Thanks for This Great work.
I have a Problem with it. I use this awesome library in a site, That I must show hit of every picture.
I coded a Handler that increases counter of every Image in SQL database and then reads and returns picture as response and uses async: False to do not get a hit on the counter for all images when a page with many images is opened
for example /photohandler.ashx?id=67.jpg
But left and the right pictures also is hit when the bauggetbox overlay is opened.
How can I handle This situation?
I am not JS expert, can I modify Functions (which function or functions?) to send extra query string only for the currently visible image to make counter increase routine run only when this Query String is sent?
for example /photohandler.ashx?id=67.jpg&Hit=1

I presume the issue has been fixed.


tab-text is too low

As per bens request....

... @brandyscarney probably broke it

I did no such thing


Laravel 9 Attributes should support public method

Larastan Version: latest
--level used: 6

Hi, lalastan supports Laravel 9 specified attribute but it supports only protected method
https://github.com/nunomaduro/larastan/blob/eda1094b4eb279b1a4512665c148105c7aeb402e/src/Properties/ModelPropertyExtension.php#L294-L296
But in laravel docs it should support the public and the protected methods.

Hi,
Attribute methods should have protected visibility. It is in the documentation.

... To define an accessor, create a protected method on your model ...

If public is used in any of the examples, you should send a PR to Laravel docs instead to change it to protected


ESPHome component to use zeroconf discovery

Breaking Change:
Discovery of ESPHome is now handled by the Zeroconf integration.
ESPHome will not be available in the context of the discovery integration anymore and using ignore  will break your configuration.
Description:
Related issue (if applicable): fixes https://github.com/home-assistant/architecture/issues/198#event-2330901207
https://github.com/home-assistant/home-assistant.io/pull/9506
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Should this be tagged as a breaking change?
ESPHome was only configurable through a config flow ever - discovery was only used to initiate the config flow. So no user could have relied on this.

The breaking change flag was added initially when I removed references to ESPHome in the discovery component, but that has been reverted. So no breaking change exist anymore


Fix regen of common types no validated in CI

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-azure-resource-manager

Show changes

As discussed, can you move x-ms-identifier from types.tsp into the supplement file here.

/azp run


[BUG]: error executing powershell / step 6 of guide

Describe the bug
Following step 6 (bypass consent for mobile apps) but getting error executing powershell - "...running scripts is disabled on this system..."
To Reproduce
Steps to reproduce the behavior:

Copy and paste powershell script in step 6 onto notepad
Save as .ps or .ps1 and execute in powershell
See error/s

Expected behavior
powershell to bypass will run successfully
Screenshots

Interface(please complete the following information):

Browser [e.g. chrome, safari] - Microsoft Edge 44.18362.449.0
Powershell and Powershell ISE

Smartphone (please complete the following information):

NA

Additional context
Add any other context about the problem here.

Don't you need to set the execution policy on the local machine?

Please set execution policy on the machine and rerun


Accounts can be renamed to the empty string.

This is both a btcwallet and a Paymetheus bug.  btcwallet should not be allowing this (waddrmgr should error), but Paymetheus should also disable the Rename button in the dialog if the text box is empty.

See btcsuite/btcwallet#369 for the related bug.

I noticed this as well, but didn't file an issue since I knew it was possible via RPC as well.  I agree with you though that an empty account name should be disallowed and the Rename button disabled when the text box is empty.


Add label to thumbnail images

Currently, thumbnail images do not have any associated data. We should have the ability to provide image captions (alt-text at the least) and other associated information

Captions and other information could be captured through additional RDF triples to the thumbnail, e.g.

Subject: URI for thumbnail (e.g., http://omex-libary.org/archive.omex/path/to/thumbnail.jpg)
Predicate: rdfs:label
Object: caption

Todo

[ ] Add to meta data guidelines in this repository
[ ] Add to BioSimulators-utils omexmeta module
[ ] Add to COMBINE API
[ ] Add to dispatch app

[ ] Add to COMBINE service

[ ] Add to platform app


Added NMF example patches to Toolkit patch

The JIT-NMF example tab (changed to just NMF) now opens a patch with links to four nmf example patches that have all been commented and given descriptions.

Great work!
I think the tone is a bit brutal in the sentence
"If you lack a basic understanding of the nmf objects, check out their help files before diving deeper!"
Other grammar and wording questions:
"in close to realtime" -> close-to-real-time or close-to-realtime ?
in 'resynthesis' there is an extra period after [buf.nmf~]
otherwise I love this very much - and the explainers in the various patches are good! Maybe @weefuzzy or @AlexHarker might want to read the explanations to make sure he likes the inviting tone as much as I do?


Expose SKBlender

Description of Change
SKBlender represents a custom blend function in the Skia pipeline.
When a blender is present in a paint, the BlendMode property is ignored. A blender combines a source color (the result of our paint) and destination color (from the canvas) into a final color.
Bugs Fixed
None.
API Changes
// NEW TYPES

public unsafe class SKBlender : SKObject, ISKReferenceCounted
{
    public static SKBlender CreateBlendMode (SKBlendMode mode);
    public static SKBlender CreateArithmetic (float k1, float k2, float k3, float k4, bool enforcePMColor);
}

public class SKRuntimeBlenderBuilder : SKRuntimeEffectBuilder
{
    public SKRuntimeBlenderBuilder (SKRuntimeEffect effect);
    public SKBlender Build ();
}

// NEW MEMBERS

class SKImageFilter
{
    public static SKImageFilter CreateBlendMode (SKBlender blender, SKImageFilter? background);
    public static SKImageFilter CreateBlendMode (SKBlender blender, SKImageFilter? background, SKImageFilter? foreground);
    public static SKImageFilter CreateBlendMode (SKBlender blender, SKImageFilter? background, SKImageFilter? foreground, SKRect cropRect);
}

class SKPaint
{
    public SKBlender Blender { get; set; }
}

class SKRuntimeEffect
{
    public SKBlender ToBlender ();
    public SKBlender ToBlender (SKRuntimeEffectUniforms uniforms);
    public SKBlender ToBlender (SKRuntimeEffectUniforms uniforms, SKRuntimeEffectChildren children);
}

struct SKRuntimeEffectChild
{
    public SKRuntimeEffectChild (SKBlender blender);
    public SKBlender Blender { get; }
    public static implicit operator SKRuntimeEffectChild (SKBlender blender);
}

class SKShader
{
    public static SKShader CreateBlend (SKBlendMode mode, SKShader shaderA, SKShader shaderB);
    public static SKShader CreateBlend (SKBlender blender, SKShader shaderA, SKShader shaderB);
}

Behavioral Changes
None.

Required skia PR
https://github.com/mono/skia/pull/123
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Merged related skia PRs
[ ] Changes adhere to coding standard
[ ] Updated documentation

/azp run


Update passt rep

What this PR does / why we need it:
Update the passt repo to a fully archived mirror of the Copr repository.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
This PR also includes update of the bazeldnf.
passt rpm includes "^" which causes the generation of the WORKSPACE file to fail. The new bazeldnf version includes a fix substituting "^" with "caret".
The bazeldnf update commit was taken from PR https://github.com/kubevirt/kubevirt/pull/8404.
Release note:

Changing the passt repo to https://passt.top/builds/copr
Updating passt version to 0^20221022.gb68da10-1.el8

/test pull-kubevirt-e2e-k8s-1.23-sig-network

/test pull-kubevirt-e2e-k8s-1.24-sig-network

/test pull-kubevirt-e2e-k8s-1.24-sig-network

/test pull-kubevirt-e2e-k8s-1.24-sig-network

/test pull-kubevirt-e2e-k8s-1.24-sig-network


Error when saving Escher SVG as CNApy-style map

Traceback (most recent call last): File "/scratch/GitHub/CNApy/cnapy/gui_elements/main_window.py", line 1423, in wait_for_retrieval self.continue_save_project() File "/scratch/GitHub/CNApy/cnapy/gui_elements/main_window.py", line 1472, in continue_save_project zip_obj.write(name, arcname=m) File "/scratch/mambaforge/envs/cnapy-dev-38/lib/python3.8/zipfile.py", line 1741, in write zinfo = ZipInfo.from_file(filename, arcname, File "/scratch/mambaforge/envs/cnapy-dev-38/lib/python3.8/zipfile.py", line 523, in from_file st = os.stat(filename) FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpkd3a8lix/map1.svg'

Fixed thanks to @axelvonkamp :D


Smart Distancing: Implement FastAPI backend and React frontend skelton

Dockerfile-x86 contains build script for frontend.

@JsonSadler to help review.

@mhejrati @JsonSadler I just added the frontend build script to all Dockerfiles. I have only tested the x86 Dockerfile.

Merging this PR is pending testing on all hosts. Hopefully, it will be done in 1-2 days!

@mhejrati Can I help you? I can test it by edgetpu(usbtpu, coral dev board), jetson nano, and gpu devices.

Merging this PR is pending testing on all hosts. Hopefully, it will be done in 1-2 days!

@mhejrati Can I help you? I can test it by edgetpu(usbtpu, coral dev board), jetson nano, and gpu devices.

Wow great! I was away for almost a week, I will check this ASAP

This pull request has been moved to the new repo: https://github.com/neuralet/smart-social-distancing/pull/3


Store taxes/VAT information in orders and transactions

To setup taxes on a tier, host taxes must be configured.
Example
{
	"PRODUCT": {
		"name": "VAT",
		"description": "Value-added tax for Europe.",
		"percentage": 20
	}
}

See https://docs.opencollective.com/help/hosts/taxes-support-vat

Coverage increased (+0.03%) to 67.324% when pulling 032401bc07740d4827cd8bd31066dce0eaf0adbe on feat/taxes-vat into e43f279105750ee0ac6199f23f47dfdaea2643f0 on master.


README

README
User Story
As a bootcamp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

crafted a professional README file using markup


first subnet

why is it not permitted to configure "0" as the first subnet to scan?

If you know little bit of networking then 0 in the last octet is used for network ID and this IP can not be a host IP.

i know very little indeed. what i meant by first subnet was the third number or like you say octet.
long story short, i wasn't able to scan for this IP in my routers network: <IP_ADDRESS>

First three octets are auto fetched from the routers wifi and the last octet is what you can change as per your need. Valid range for last octet which you can change in settings also first subnet and last subnet is 1 to 254. 0 is reserved for network ID and 255 is reserved for broadcast address.


Change Command

Please tick all applicable boxes.

[x] I am using Python 3.5 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (1.9.8)
[ ] The latest review version

What type of issue are you creating?

[ ] Bug
[ ] Feature request
[x] Question

Can I Change "summon" Command to "join"?
Description of issue
Steps to reproduce

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.

Use the newly added alias file for this

Use the newly added alias file for this

I don't know how to do...
Can I say a little more

It's pretty self explanatory if you look at the file.
"summon" : ["join"]

ok
thanks


run program  on host using bashoperator

Hi ,
My task has below code for bashoperator.
dbt_t1 = BashOperator(task_id="dbt_deps", bash_command="cd /Users/userid/project_dbt && wxdbt deps")
wxdbt deps is a programm which should run inside host directory /Users/userid/project_dbt and it  uses host userid and password.
task is failing with below error in webserver(UI) :
[2019-11-08 07:37:52,780] {{bash_operator.py:128}} INFO - /tmp/airflowtmpqipl33d9/dbt_depsqs_1dean: line 1: cd: /Users/userid/project_dbt: No such file or directory
so in nutshell the requirement is to  run program  on host machine which uses host userid and password using  bashoperator .
Can you please provide some solution for it.?
Thanks in advance.
--Krishna

@krishna61834 You could, eventually, share the volume /Users/userid/project_dbt and share the volume where the bin for wxdbt is, and then run the bash command with the adapted volume names and paths.
Although I would recommend you to not do that. You should run everything within the worker container, and then publish the resulting items to the host, as any CI/CD tool would do.


Dashboard Orders and Products page should be searchable

Right now it's just being listed and paginated. We need some search options and filters.

I've done a pull request for a basic product search. Perhaps mark this one as in development.

Marked as in dev. Merged in products - waiting on orders.


fixing structselect_tools.cpp compilation with gcc (https://forum.kde.org/viewtopic.php?f=74&t=118922)

fixed by 1cd236f0be0136fc68c14a8c3c29080fd39b7491


created Modal to confirm goal deletion

Created modal to confirm if a goal should be deleted
Created button labeled "delete Goal" to display modal component
fixes issue #402
Live link https://goals.zuri.chat/
NB: Click on delete Goal to display modal

Please resolve conflict

I've removed the react syntax chief


error with GENCODE annotations

Hi,
When using the R2_lift.R script with GENCODE annotation file, I encounter the error with transcript_id.
`Problem with transcript_id.
Backtrace:

├─... %>% mutate(score = ".", .after = metaname)
├─dplyr::mutate(., score = ".", .after = metaname)
├─dplyr::inner_join(mappedLocus, strand_lookup, by = "transcript_id")
└─dplyr:::inner_join.data.frame(mappedLocus, strand_lookup, by = "transcript_id")
└─dplyr:::join_mutate(...)

└─dplyr:::join_cols(...)

  └─dplyr:::standardise_join_by(...)

    └─dplyr:::check_join_vars(by$x, x_names, error_call = error_call)

      └─rlang::abort(bullets, call = error_call)

Execution halted
`
I follow your generate notes,  commenting out line 25 in lift.R and line 27 in annotate.R. But it seems update, does not corresponding with it.
In addition, same error with test data.
Bai,
Thanks a lot

Hi Bai, if you'd like to share the GTF file, I can take a look.


Branching prints warnings: 'WARN Page version of rel checkpoint already exists'

Aug 23 07:22:37.229 INFO branched timeline de039d91c21a9a58f231e4e83aaaab2a from 3828e482b2d8ea302d480e72fe2b403f at 0/1699D0A, location: pageserver::layered_repository, pageserver/src/layered_repository.rs:148
Aug 23 07:22:37.243 INFO loading layer map for timeline de039d91c21a9a58f231e4e83aaaab2a into memory, location: pageserver::layered_repository, pageserver/src/layered_repository.rs:884
Aug 23 07:22:37.243 INFO Loading WAL for timeline de039d91c21a9a58f231e4e83aaaab2a starting at 0/1699D0A, location: pageserver::layered_repository, pageserver/src/layered_repository.rs:208
Aug 23 07:22:37.244 INFO reached end of WAL at 0/1699D0A, location: pageserver::restore_local_repo, pageserver/src/restore_local_repo.rs:335
Aug 23 07:22:37.244 WARN Page version of rel checkpoint blk 0 at 0/1699D0A already exists, location: pageserver::layered_repository::inmemory_layer, pageserver/src/layered_repository/inmemory_layer.rs:237

Seems harmless, but we shouldn't print warnings like that.

Fixed by commit  ab33614


signed release app crashes in the direction fragment

after creating a signed apk, when i click the direction button to show the direction in a fragment it shows error like onDirectionSuccess(unknown sources) but in debugging mode it works fine.
please help me....

Did you added the ProGuard rules for this library?
ProGuard
-keep class com.google.android.gms.maps.** { *; }
-keep interface com.google.android.gms.maps.* { *; }

-dontwarn retrofit2.**
-keep class retrofit2.** { *; }
-keepattributes Signature
-keepattributes Exceptions

-keepclasseswithmembers class * {
    @retrofit2.http.* <methods>;
}

For anyone who had stumbled across this issue, may have to add the below rule as well along with the mentioned proguard rules.
-keep class com.akexorcist.googledirection.model.** { *;}


Crashes during Background Customization [1.7.572.0]

Environment
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19042.0 Microsoft Windows NT 10.0.19042.0

Windows Terminal Preview 1.7.572.0

Steps to reproduce
Open Settings menu, select Base Layer under Profiles, Click Appearance Tab, Click Browse for Background Image Path.
The app consistently crashes after attempting to open the browse file explorer window. The "Use desktop background" option works fine.
Expected behavior
I should be able to modify my background for the terminal without having to edit the JSON settings file. I want to use the UI to do this work.
Actual behavior
See steps to reproduce. It's crashing after clicking "browse".

Are you running the Terminal elevated / as an admin?

Are you running the Terminal elevated / as an admin?

Yes. Behavior is consistent as admin/non-admin

Hmm. Bizarre that you're seeing this unelevated as well. That's not what you want. We're generally already tracking this over in #8957 so I'll make a note there. Thanks!
/dup #8957


WebServer.builder() default socket configuration ignored

Environment Details

Helidon Version: Helidon Nima 4.0.0-ALPHA6 (see Maven config below)
Helidon SE or Helidon MP: SE
JDK version: Java 20
OS: Windows 10

Problem Description
I expect that configuring the defaultSocket builder (through the below method or by directly using WebServer.DEFAULT_SOCKET_NAME to modify the default socket, but it does not appear to. If this is correct behavior, then there does not appear to be documentation documenting that certain default socket options cannot be configured.
Side note: It would be nice to be able to disable the default socket, or simply not have it automatically created in the first place.
Steps to reproduce
WebServer.builder()
    .defaultSocket(builder -> {
        try {
            builder
                .bindAddress(InetAddress.getByName("<IP_ADDRESS>"))
                .port(8080);
        } catch(UnknownHostException e) {
            throw new RuntimeException(e);
        }
    })
    .build()
    .start();

Logging output
[main] INFO io.helidon.logging.slf4j.Slf4jProvider - Logging initialization.
[start @default (/<IP_ADDRESS>:0)] INFO io.helidon.nima.webserver.ServerListener - [0x66da4602] http://<IP_ADDRESS>:2516 bound for socket '@default'
[features-thread] INFO io.helidon.common.features.HelidonFeatures - Helidon NIMA 4.0.0-ALPHA6 features: [Config, Encoding, Media, WebServer]
[main] INFO io.helidon.nima.webserver.LoomServer - Started all channels in 16 milliseconds. 904 milliseconds since JVM startup. Java 20+36

Maven configuration
<dependency>
	<groupId>io.helidon.nima.webserver</groupId>
	<artifactId>helidon-nima-webserver</artifactId>
	<exclusions>
		<exclusion>
			<groupId>io.helidon.logging</groupId>
			<artifactId>helidon-logging-jul</artifactId>
		</exclusion>
	</exclusions>
</dependency>
<dependency>
	<groupId>io.helidon.logging</groupId>
	<artifactId>helidon-logging-slf4j</artifactId>
	<scope>runtime</scope>
</dependency>
<dependencyManagement>
<dependencies>
	<dependency>
		<groupId>io.helidon</groupId>
		<artifactId>helidon-bom</artifactId>
		<version>4.0.0-ALPHA6</version>
		<type>pom</type>
		<scope>import</scope>
	</dependency>
</dependencies>
</dependencyManagement>

There is no such defaultSocket method nowadays in Helidon 4. Is this still an issue?.

There is no such WebServerConfig.Builder#defaultSocket method nowadays in Helidon 4. Is this still an issue?.

Probably not, I've put it back in triage ; we will purge it next time we process triage issues.

There was a real bug at the time this was reported. The configuration should not be honored as expected.
Closing this issue.


refactor: hard code script in app template

This is yet another refactor, this time designed to remove any runtime need for generating the color-mode script. There's not yet a standardised way to engage with the document template directly, but this is an attempt to fully cover all targets. Perhaps in future we could consider a @nuxt/kit helper along these lines.
Local tests
[note, ci tests should pass when #96 is merged]

SSR
Target
Commands
Test

false
server
dev, generate, build + start
✅

false
static
dev, generate
✅

true
server
dev, generate, build + start
✅

true
static
dev, generate
✅

[nitro]
server
dev, build + start
✅

[nitro]
static
dev, generate
✅

Workarounds

[x] @nuxtjs/storybook and other solutions extending the Nuxt webpack config will work, even if client-only as (in dev mode) the color-mode script is added to the nuxt entrypoint - thoughts welcome on the approach...

Note for kit/nuxt3 app: I think if we add a standardized way, it would be through runtime (current approach) rather than hooking into template to allow runtime config and dynamic scripts.


In Network DAO proposal list , if proposal title too long, will exhibit error

Description
In Network DAO proposal list , if proposal title too long, will exhibit error
Steps To Reproduce

Log in...
Enter Network DAO proposal list page https://test.tmrwdao.com/network-dao#association

Current Behavior

If proposal title too long, will exhibit error

Expected Behavior

If proposal title too long, omit display

Environment

Platform: PC
Node: v18.18.0
Browser: Chrome 126.0.6478.56

fixed confirm


AttributeError: 'NoneType' object has no attribute 'shape'

When running botactions.py, the script queues up automatically like it's supposed to but when we get to the point where the game is actually launched, I get this error and the script stops responding.

My bad sorry I didnt update JPG files. Clone again with hexJPG, TemplateMatchingClient, TemplateMatchingGame. Thank you for noticing issue, and please let me know if everything ok after cloning again.


Find the Bad Dimm

On fail, it'd be nice if it could say which DIMM is bad.

Wheres waldo?

Not possible unfortunately


[AIRFLOW-423][AIRFLOW-424][AIRFLOW-426] UX updates for PR Tool

Some big UX improvements to the PR tool:
AIRFLOW-423: commit messages are automatically wrapped at 50 characters. Paragraph breaks and tab indents are preserved. The first line of the commit is NOT forced to be 72 characters because handling this on subsequent lines is challenging. This is also deployed throughout the PR tool to make long status messages prettier.
https://issues.apache.org/jira/browse/AIRFLOW-423
AIRFLOW-424: this commit fixes a number of whitespace and formatting issues. It’s only contribution to functionality is that the JIRA resolution process is a little clearer.
https://issues.apache.org/jira/browse/AIRFLOW-424
AIRFLOW-426: I think this one is pretty cool. If the PR author mentions a JIRA issue anywhere in their PR (including on GitHub or buried in a commit), then the PR tool will automatically add it to the PR title. It even catches misformatted ones. So if the 20th commit mentions “AIRFLOW   - -426” somewhere in its body, you’ll still get “[AIRFLOW-426]” in the squash commit subject.
https://issues.apache.org/jira/browse/AIRFLOW-426
AIRFLOW-427: You can now run the PR tool from anywhere (previously you had to be cd'd to the Airflow git repo or set an env var)
https://issues.apache.org/jira/browse/AIRFLOW-427

+1

commit messages are automatically wrapped at 50 characters

I think this is breaking links

@zodiac interesting point -- on the other hand, 50 characters is 50 characters. The tool does display the commit and asks the user to confirm they want to use it, or instructs them how to edit it, so I think it is up front about any changes that would be made


[FEATURE]: migrations in TypeScript / drizzle-kit generate --typescript

Describe what you want
I'd love to see support for migrations in TypeScript. It would make life so much easier.
After we do a schema migration, we often need to migrate data too. This usually involves:

Selecting the data
Preparing it
Inserting or updating it

Sure, you can do this with plain SQL, but it’s not as simple or nice as writing a script in TypeScript.
Right now, we have to create a TypeScript script and run it manually, which is a pain because:

Manual Work: Running scripts manually is prone to mistakes and is just extra work. It’s easy to mess up the order or the environment, especially with a team.

CI/CD Hassles: Our CI/CD setup doesn’t handle these scripts automatically. We have to apply every migration by hand, which breaks the smooth automation we’re aiming for.

Tracking Issues: Unlike schema migrations, these scripts don’t get tracked automatically, so we lose the history of what’s been applied. This can lead to inconsistent environments.

drizzle-kit already does a great job tracking and running schema migrations. It would be awesome if it could handle data migrations too, making the whole process smoother and less error-prone.

I have put together a script that can refer to drizzle's code and perform the migration in typescript. This is not perfect, but I hope it helps☺
migration.ts
Place sql and ts files in migrationsFolder. Do not place extra ts files in the migrations.
import "dotenv/config";
import { resolve } from "node:path";
import { db } from "../db";
import { readMigrationFiles } from "drizzle-orm/migrator";
import fs from "node:fs";
import path from "node:path";
import { sql } from "drizzle-orm";
import crypto from "node:crypto";

async function migrateToDB() {

  const migrationsFolder = resolve(__dirname, "./migrations");

  // Read all migration files
  const sqlMigrations = readMigrationFiles({ migrationsFolder: migrationsFolder });
  const tsMigrations = await readTsMigrationFiles(migrationsFolder);

  // Sort all migrations by timestamp
  const allMigrations = [...sqlMigrations, ...tsMigrations].sort((a, b) => a.folderMillis - b.folderMillis);

  await db.execute(sql`
    CREATE TABLE IF NOT EXISTS drizzle.__drizzle_migrations (
      id SERIAL PRIMARY KEY,
      hash text NOT NULL,
      created_at bigint
    )
  `);

  const lastMigration = await db.execute(sql`
    SELECT id, hash, created_at FROM drizzle.__drizzle_migrations
    ORDER BY created_at DESC LIMIT 1
  `);

  for (const migration of allMigrations) {
    if (!lastMigration.rows.length || Number(lastMigration.rows[0].created_at) < migration.folderMillis) {
      await db.transaction(async (tx) => {
        if ('sql' in migration) {
          // In case of sql file
          for (const stmt of migration.sql) {
            await tx.execute(sql.raw(stmt));
          }
        } else {
          // In case of TypeScript file.
          await migration.up(tx);
        }
        // Since it is not a formal file operation, leaving it in the migration history can be a breeding ground for bugs.
        await tx.execute(sql`
          INSERT INTO drizzle.__drizzle_migrations (hash, created_at)
          VALUES (${migration.hash}, ${migration.folderMillis})
        `);
      });
      console.log(`Migration ${migration.hash} applied successfully.`);
    }
  }

  console.log("All migrations completed.");
}

interface TsMigrationFile {
  up: (db: any) => Promise<void>;
  folderMillis: number;
  hash: string;
}

export async function readTsMigrationFiles(migrationsFolder: string): Promise<TsMigrationFile[]> {
  const tsMigrationFiles = fs.readdirSync(migrationsFolder).filter(file => file.endsWith('.ts'));
  const tsMigrations: TsMigrationFile[] = [];

  for (const file of tsMigrationFiles) {
    const filePath = path.join(migrationsFolder, file);
    const { up, folderMillis } = await import(filePath);
    const fileContent = fs.readFileSync(filePath, 'utf-8');
    const hash = crypto.createHash("sha256").update(fileContent).digest("hex");

    tsMigrations.push({
      up,
      folderMillis,
      hash
    });
  }

  return tsMigrations;
}

migrateToDB().catch(console.error);

smaple.ts
Describe the SQL for the data migration you wish to perform. This file should be placed in the same directory as the other sql.
It is recommended to use RAW SQL as much as possible to avoid type errors later.
Remember to specify unix time.
import { sql } from 'drizzle-orm';
import { NodePgDatabase } from 'drizzle-orm/node-postgres';
import { v7 as uuidv7 } from 'uuid';

export async function up(db: NodePgDatabase) {
 // Get all clients
 const { rows: clients } = await db.execute(sql`
  SELECT id, email, password, created_at, updated_at
  FROM clients
  WHERE email IS NOT NULL
`);

for (const client of clients) {
  const uuid = uuidv7();
  await db.execute(sql`
    INSERT INTO accounts (id, email, password, created_at, updated_at)
    VALUES (
      ${uuid},
      ${client.id},
      ${client.email},
      ${client.password},
      ${client.created_at},
      ${client.updated_at}
    )
  `);
}
}

export const folderMillis =<PHONE_NUMBER>000; // Specifies unix time. This is to determine the order of migration.


Unwanted reconnection

FTP OS: Unix
FTP Server: NASFTPD Turbo station 1.3.5a Server (ProFTPD)
Computer OS: Windows 10  & VS2019(Developer) / Windows 2012 R2 (Production)
FluentFTP Version: 33.0.2
I want to move some files on the FTP-Server to an archive folder after successfull download. On my developer machine is it working. But on the Production-Server they break up and reopen new connection till a timeout come up
Import Hint today find out: some function download ".pdf"-Files and move them afterwards. But when ".xml" should download, then the moving is not possible
Logs :

Developer-Log (works fine)
# OpenPassiveDataStream(EPSV, "RETR /05_KM/out/DC2KM.7190933.XML", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||56100|)
Status:   Connecting to <IP_ADDRESS>:56100
Command:  RETR /05_KM/out/DC2KM.7190933.XML
Response: 150 Opening BINARY mode data connection for /05_KM/out/DC2KM.7190933.XML (1865 bytes)
Status:   Disposing FtpSocketStream...
Response: 226 Transfer complete

# Rename("/05_KM/out/DC2KM.7188318.XML", "/05_KM/out/xmlarchiv/DC2KM.7188318.XML")
Command:  RNFR /05_KM/out/DC2KM.7188318.XML
Response: 350 File or directory exists, ready for destination name
Command:  RNTO /05_KM/out/xmlarchiv/DC2KM.7188318.XML
Response: 250 Rename successful

Production-Log (No moving and timeout)
# OpenPassiveDataStream(EPSV, "RETR /05_KM/out/DC2KM.7190933.XML", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||56019|)
Status:   Connecting to ***:56019
Command:  RETR /05_KM/out/DC2KM.7190933.XML
Response: 150 Opening BINARY mode data connection for /05_KM/out/DC2KM.7190933.XML (1865 bytes)
Status:   Disposing FtpSocketStream...
Response: 226 Transfer complete

# Rename("/05_KM/out/DC2KM.7188318.XML", "/05_KM/out/xmlarchiv/DC2KM.7188318.XML")
Command:  RNFR /05_KM/out/DC2KM.7188318.XML
Response: 350 File or directory exists, ready for destination name
Command:  RNTO /05_KM/out/xmlarchiv/DC2KM.7188318.XML
Status:   Disposing FtpSocketStream...

# Rename("/05_KM/out/DC2KM.7188319.XML", "/05_KM/out/xmlarchiv/DC2KM.7188319.XML")

# Connect()
Status:   Connecting to ***:21
Response: 220 NASFTPD Turbo station 1.3.5a Server (ProFTPD)
Status:   Detected FTP server: ProFTPD
Command:  USER 04KM
Response: 331 Password required for 04KM
Command:  PASS ***
Response: 230 User 04KM logged in
Command:  FEAT
Response: 211-Features:
Response: PBSZ
Response: AUTH TLS
Response: MFF modify;UNIX.group;UNIX.mode;
Response: REST STREAM
Response: MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.mode*;UNIX.owner*;
Response: LANG en-US*
Response: EPRT
Response: EPSV
Response: MDTM
Response: SSCN
Response: TVFS
Response: MFMT
Response: SIZE
Response: PROT
Response: CCC
Response: 211 End
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 215 UNIX Type: L8
Command:  RNFR /05_KM/out/DC2KM.7188319.XML
Response: 350 File or directory exists, ready for destination name
Command:  RNTO /05_KM/out/xmlarchiv/DC2KM.7188319.XML
Status:   Disposing FtpSocketStream...

# Rename("/05_KM/out/DC2KM.7190878.XML", "/05_KM/out/xmlarchiv/DC2KM.7190878.XML")

# Connect()
Status:   Connecting to ***:21
Response: 220 NASFTPD Turbo station 1.3.5a Server (ProFTPD)
Status:   Detected FTP server: ProFTPD
Command:  USER 04KM
Response: 331 Password required for 04KM
Command:  PASS ***
Response: 230 User 04KM logged in
Command:  FEAT
Response: 211-Features:
Response: PBSZ
Response: AUTH TLS
Response: MFF modify;UNIX.group;UNIX.mode;
Response: REST STREAM
Response: MLST modify*;perm*;size*;type*;unique*;UNIX.group*;UNIX.mode*;UNIX.owner*;
Response: LANG en-US*
Response: EPRT
Response: EPSV
Response: MDTM
Response: SSCN
Response: TVFS
Response: MFMT
Response: SIZE
Response: PROT
Response: CCC
Response: 211 End
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 215 UNIX Type: L8
Command:  RNFR /05_KM/out/DC2KM.7190878.XML
Response: 350 File or directory exists, ready for destination name
Command:  RNTO /05_KM/out/xmlarchiv/DC2KM.7190878.XML
Status:   Disposing FtpSocketStream...

# Rename("/05_KM/out/DC2KM.7190886.XML", "/05_KM/out/xmlarchiv/DC2KM.7190886.XML")

# Connect()
Status:   Connecting to ***:21
Response: 220 NASFTPD Turbo station 1.3.5a Server (ProFTPD)
Status:   Detected FTP server: ProFTPD
Command:  USER 04KM
Response: 331 Password required for 04KM
Command:  PASS ***
Response: 530 Sorry, the maximum number of clients (10) for this user are already connected.

# Rename("/05_KM/out/DC2KM.7190887.XML", "/05_KM/out/xmlarchiv/DC2KM.7190887.XML")
Command:  RNFR /05_KM/out/DC2KM.7190887.XML

# Rename("/05_KM/out/DC2KM.7190888.XML", "/05_KM/out/xmlarchiv/DC2KM.7190888.XML")
Command:  RNFR /05_KM/out/DC2KM.7190888.XML

Why are you using Rename()? You should use the MoveFile() API.

Why are you using Rename()? You should use the MoveFile() API.


Enforce xFilesFactor between 0 and 1

It was bugging me that I could set illogical xFilesFactor values.  Now they raise ValueError.
New tests included.

@TheNoButton Can you address the review comments and rebase your changes against the latest master branch please?

Any objections to closing this?


Create second mailchimp sign up for sponsors on splash page

I added another Mailchimp list and configured it. I still need to add the form on the splash page.

At the last mtg, we decided a sign up form to get the sponsor info was too indirect. The new plan is link to a static sponsor page with the info, prospectus and mailchimp sign up there.

Hey @jonraedeke what is the status of this task? @Nneka asked Kirsten for priorities recently and getting up the sponsor information was at the very TOP. Since I don't believe we are anywhere near ready with the new COD site, I think we should still put it up under the static "splash" site as this task outlines. Do you want me to take a stab at it?

I've taken a stab at a page. Only half of it is saved in a new file. Most of the style changes/moving stuff around I did in chrome inspector. I've attached a screenshot. I could not find draft content for the sponsors page. Not sure how much language needs to go on there aside from a link to the prospectus and signup form.

I like it @timwood . I thought we were on hold until the prospectus was finished. Is it ready?

I've asked via email whether the prospectus is ready. I see a couple versions in Gdocs.

Closing as we've decided to just link to the prospectus PDF directly from the splash home page.


Better handling of axis padding

The padding should be added added inside the layout system rather than in each axis. Fixes #2478
I don't think this change is ready for merging just yet.

[ ] I think it should be expanded to handle top and bottom padding. Right now it only handles left / right.
[ ] With this change, the padding will always be 0 in axes because the layout system handles it. We can simplify lots of places where the padding is used

Fiddles
Before fix: https://jsfiddle.net/y9kqfocr/1/
After fix: https://jsfiddle.net/r062yrng/1/

CC @chartjs/maintainers to get your thoughts before I go further

Sounds good to me and would be more useful than just padding on the axis.

@chartjs/maintainers I updated the scales to remove the unnecessary padding variables. This should simplify the code and make it smaller.
I updated the category scale tests appropriately and rebased on master.

@chartjs/maintainers once this is reviewed, we can merge it


Fresh install fails

I've been installing gometalinter like this for quite some time. On a fresh install today, I get the following.
I don't see anything that indicates I need to do something different.
[user:~/go/src] % go version
go version go1.8 linux/amd64
[user:~/go/src] % lsb_release -cs
xenial
[user:~/go/src] % go get -u -v github.com/alecthomas/gometalinter
github.com/alecthomas/gometalinter (download)
github.com/alecthomas/gometalinter/vendor/github.com/google/shlex
github.com/alecthomas/gometalinter/vendor/github.com/alecthomas/units
github.com/alecthomas/gometalinter/vendor/github.com/nicksnyder/go-i18n/i18n/language
github.com/alecthomas/gometalinter/vendor/gopkg.in/yaml.v2
github.com/alecthomas/gometalinter/vendor/github.com/nicksnyder/go-i18n/i18n/translation
github.com/alecthomas/gometalinter/vendor/github.com/nicksnyder/go-i18n/i18n/bundle
github.com/alecthomas/gometalinter/vendor/github.com/nicksnyder/go-i18n/i18n
github.com/alecthomas/gometalinter/vendor/gopkg.in/alecthomas/kingpin.v3-unstable
github.com/alecthomas/gometalinter
[user:~/go/src] % gometalinter --install
gometalinter: error: could not find vendored linters in
[user:~/go/src] 1 % gometalinter
WARNING: exec: "gosimple": executable file not found in $PATH
WARNING: exec: "interfacer": executable file not found in $PATH
WARNING: exec: "errcheck": executable file not found in $PATH
WARNING: exec: "gas": executable file not found in $PATH
WARNING: exec: "varcheck": executable file not found in $PATH
WARNING: exec: "ineffassign": executable file not found in $PATH
WARNING: exec: "deadcode": executable file not found in $PATH
WARNING: exec: "golint": executable file not found in $PATH
WARNING: exec: "goconst": executable file not found in $PATH
WARNING: exec: "unconvert": executable file not found in $PATH
WARNING: exec: "staticcheck": executable file not found in $PATH
WARNING: exec: "aligncheck": executable file not found in $PATH
WARNING: exec: "gocyclo": executable file not found in $PATH
WARNING: exec: "structcheck": executable file not found in $PATH
WARNING: exec: "gotype": executable file not found in $PATH

Is your GOPATH set?

Ignore me.

1.8 sets $HOME/go I think. And I set it in /etc/profile.d/home.sh for all users, but it appears that somehow it was unset. So I don't know how it was unset, but yes that appears to have been the issue.

Okay, that is good to know though. The error should be more useful.


FIX Value on zhimi.airpurifier.ma4.js

Hi, i find this error ! :) Thanks for your work i used it !

fixed in 0.0.28

fixed in 0.0.28


Support sequential function chart

"Is there a shape for sfc (sequential function chart) according to IEC 61131-3? I have searched for a long time and unfortunately found nothing. I have then put something together (see attachment), but would be nicer if there was an official Shape. "
Asked in DND 553

diagram file.zip
SAG_L50_sfc_Ofentor_en.zip

Have they made any yet? :D


Skyline: add a User Interface selection to the Settings menu, in case users don't notice it on the button bar

Two questions:

The capitalization matches that of the toolbar button but seems inconsistent with our menu conventions.
Do we want to indicate which choice is the current one with a check or highlight or similar?

On the 2 questions:

I think you can drop the word "interface" because it seems redundant with the parent menu item "User Interface"
Yes, it needs to show the active "setting" with a checkbox

It needs to change to "Document Type" if we want to leave it here, and move above "Integrate All". This more accurately exposes what is happening to the SrmDocument, but seems a little inconsistent with what we are otherwise promoting on our other UI Mode settings. We still don't need the word "interface" in either case when it is on the menu.

OK, so to be clear,we want to:
put it on the View Menu, under Text Zoom
call it User Interface
drop "interface" from the submenu
indicate the current UI mode on the submenu

Yes. I think that would be fine.

OK: