Add data augmentation in LeRobotDataset

What this does
Implements data augmentation for images from a LeRobot dataset object.
The transforms are :

Colorjitter with brightness and contrast

RandomAdjustSharpness with a value > 1 to increase sharpness

RandomAdjustSharpness with a value < 1 to increase blur (maybe we could instead do a random.choice to choose whether to do one or another?

The parameters are taken from the default.yaml and the transforms are defined in make_dataset. They are then applied in  __getitem__()
The transformation is applied on the images of all of the given cameras.
How you can verify it
To test various types of transforms, you can use this helper script that saves nb_frames frames from a dataset and applies to them the transformations. It then creates a grid with both the modified and unmodified frames.
import torch

from lerobot.common.datasets.lerobot_dataset import LeRobotDataset
from pathlib import Path

from torchvision.transforms import v2
from torchvision.utils import make_grid, save_image

image_transform={"colorjittor_factor": 0.5,
  "colorjittor_p": 0.5,
  'sharpness_factor': 2,
  "sharpness_p": 0.5,
  "blur_factor": 0.5,
  "blur_p": 0.5}

output_dir=""
repo_id="lerobot/aloha_static_tape"

transform = v2.Compose([v2.ColorJitter(brightness=image_transform["colorjittor_factor"], contrast=image_transform["colorjittor_factor"]),
                                v2.RandomAdjustSharpness(image_transform["sharpness_factor"], p=image_transform["sharpness_p"]), v2.RandomAdjustSharpness(image_transform["blur_factor"], p=image_transform["blur_p"]),
                                 v2.ToDtype(torch.float32, scale=True),
        ])

def visualize_transformation(repo_id, output_dir, nb_frames=7):
    dataset = LeRobotDataset(repo_id=repo_id)
    frames=[dataset.__getitem__(idx)[dataset.camera_keys[0]] for idx in range(nb_frames)]

    print(f"Camera Keys: {dataset.camera_keys}")
    print(f"Using camera : {dataset.camera_keys[0]}")

    transformed_dataset=LeRobotDataset(repo_id, transform=transform)
    transformed_frames = [transformed_dataset.__getitem__(idx)[transformed_dataset.camera_keys[0]] for idx in range(nb_frames)]

    save_image(make_grid([*frames, *transformed_frames]), Path(output_dir))

visualize_transformation(repo_id, output_dir)

This change is

@marinabar Wonderful PR :)
Could you illustrate the augmentations by adding some screenshots to the PR description? Thanks!

@marinabar Wonderful PR :) Could you illustrate the augmentations by adding some screenshots to the PR description? Thanks!

@marinabar Ideally we should show an image with the biggest augmentation for each transform (to better understand what each transform is doing).
Then we should show the worst case where all biggest augmentation of all transform are applied sequentially to an image (this is because your implementation can apply transforms sequentially).
Also, we should display the frames in the original scale. What you displayed is a bit too small and compressed to get a good feeling.
Ideally we could add a script in lerobot/scripts/show_image_transforms.py that could save these images in outputs/show_image_transforms. That's something we would need each time we add new transforms, so super useful!!!
Finally, we could add backward compatibility tests where we would save the result of specific frames, augmented with each transform. This is to ensure that if torchvision change something, we are aware of it.
Data augmentation is really something we should be careful about since it can fail silently.
What do you think?
cc @aliberts @alexander-soare


NPM Task Viewer Widget

Discovering a new project can be challenging, especially if the project specific tasks are unknown. We can help expose these NPM tasks by offering a widget that allows to add descriptions and titles to an NPM task to help developers better understand what they do and when to use that NPM task.
Requirements:

by default show an empty list with a "Call to Action" to add a project script
when adding a project script a modal is shown that requires title, description and shell command script (multiline script)
read defined NPM scripts from package.json and offer to add them to the list

We should leverage the VSCode task schema for defining them and the widgets basically reads and displays them.

Also we should add this as a new section into the tree viewer.

We should leverage the VSCode task schema for defining them and the widgets basically reads and displays them.
Also we should add this as a new section into the tree viewer.

I like those two requirements, @christian-bromann. So in essence this is widget is actually a generic VS Code task runner showcased based on NPM scripts/tasks?

Also we should add this as a new section into the tree viewer.

I kind changed my mind on this one because tree viewer sections need to be defined within package.json and therefor show up also in non NPM projects.

Also we should add this as a new section into the tree viewer.

I kind changed my mind on this one because tree viewer sections need to be defined within package.json and therefor show up also in non NPM projects.

Not sure I understand. If a tasks.json is defined the treeviewer could be totally agnostic from what context project is loaded, no?

If a tasks.json is defined the treeviewer could be totally agnostic from what context project is loaded, no?

Yeah. If a task.json is defined.


WARNING:root:NaN or Inf found in input tensor.

When I use my own data set, the loss appears nan, and it reports WARNING:root:NaN or Inf found in input tensor. What is the reason?
**Traceback (most recent call last):
File "train.py", line 114, in
main()
File "train.py", line 105, in main
model = train(cfg, args)
File "train.py", line 44, in train
model = do_train(cfg, model, train_loader, optimizer, scheduler, checkpointer, device, arguments, args)
File "D:\Document\PersonalDocuments\FileCollection\All_Programs\Python\MyPaperExperiment\lufficc\original\SSD-master\ssd\engine\trainer.py", line
76, in do_train
for iteration, (images, targets, _) in enumerate(data_loader, start_iter):
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data\dataloader.py", line 363, in next
data = self._next_data()
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data\dataloader.py", line 989, in _next_data
return self._process_data(data)
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data\dataloader.py", line 1014, in _process_data
data.reraise()
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch_utils.py", line 395, in reraise
raise self.exc_type(msg)
cv2.error: Caught error in DataLoader worker process 1.
Original Traceback (most recent call last):
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data_utils\worker.py", line 185, in _worker_loop
data = fetcher.fetch(index)
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "D:\Software\ProgrammingTools\Anaconda\envs\torch1.6\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "D:\Document\PersonalDocuments\FileCollection\All_Programs\Python\MyPaperExperiment\lufficc\original\SSD-master\ssd\data\datasets\voc.py", l
ine 44, in getitem
image, boxes, labels = self.transform(image, boxes, labels)
File "D:\Document\PersonalDocuments\FileCollection\All_Programs\Python\MyPaperExperiment\lufficc\original\SSD-master\ssd\data\transforms\transfor
ms.py", line 75, in call
img, boxes, labels = t(img, boxes, labels)
File "D:\Document\PersonalDocuments\FileCollection\All_Programs\Python\MyPaperExperiment\lufficc\original\SSD-master\ssd\data\transforms\transfor
ms.py", line 135, in call
self.size))
cv2.error: OpenCV(4.5.4) :-1: error: (-5:Bad argument) in function 'resize'

Overload resolution failed:

Conversion error: src
Expected Ptrcv::UMat for argument 'src'**

Have you solved it? I also encountered this problem


setAcceleration cause wrong deceleration calculation (overshoot)

loop
{
stepper->setSpeed(variableSpeed);
//stepper->setAcceleration(9999); // uncomment this cause motor position will be over than target and motor have to go backward (same in both direction). In most bad cases it act like drunk car driver to chive target position in waves-like motion.
//stepper->setAcceleration(variableAcceleration); //same situation
long target = analogRead(A0)*5;
stepper->moveTo(target);
}
I test on ESP32.   tested this on v0.18.11 , v0.18.02

Sounds interesting. Could you please add a Serial.println(target) at the end and perhaps a delay(10) ? Hope you can provide the log with timestamp. This way I can try to produce it on my side.

Sounds interesting. Could you please add a Serial.println(target) at the end and perhaps a delay(10) ? Hope you can provide the log with timestamp. This way I can try to produce it on my side.

Sorry, finished project, so no hardware. This is looks like absolutely the same as overshoot examples in google.
The code above produce NO waves but only one return, but if acceleration is low , i think waves will appear.
The output, i got with one of the settings  with waves:
Green - target, Red - current position.

Sorry, finished project, so no hardware. This is looks like absolutely the same as overshoot examples in google.
The code above produce NO waves but only one return, but if acceleration is low , i think waves will appear.
The output, i got with one of the settings  with waves:
Green - target, Red - current position.

Thanks for additional info. What is the meaning of the other three lines between 0 and 10000 ?
With this input I have tried to check on my HW (esp and avr) and could not reproduce anything close to what you get. So I have changed one of my tests to constantly issue moveTo() and setAcceleration. There has been a finding, which I have fixed, and I have added another precaution in setAcceleration. The code is uploaded to github, but not released yet.
Just I cannot explain that behavior with those changes.
Could you provide a log with timing included and your setting of speed/acceleration for the pic above ?

Thanks for additional info. What is the meaning of the other three lines between 0 and 10000 ?
With this input I have tried to check on my HW (esp and avr) and could not reproduce anything close to what you get. So I have changed one of my tests to constantly issue moveTo() and setAcceleration. There has been a finding, which I have fixed, and I have added another precaution in setAcceleration. The code is uploaded to github, but not released yet.
Just I cannot explain that behavior with those changes.
Could you provide a log with timing included and your setting of speed/acceleration for the pic above ?

forgot the picture above. The issue in 1st message looks like this:

with any code that updates setAcceleration
loop
{
stepper->setSpeed(200);
stepper->setAcceleration(9999);
stepper->moveTo(20000);
delay(10);
}

forgot the picture above. The issue in 1st message looks like this:

with any code that updates setAcceleration
loop
{
stepper->setSpeed(200);
stepper->setAcceleration(9999);
stepper->moveTo(20000);
delay(10);
}

Thanks for the code. Based on this the issue came apparent and I have added a test case to my test suite.
The issue is fixed in v0.18.12, but may reappear, if the setAcceleration() would jump back and forth between 999 and 1000. Perhaps later add a test case for this.

Thanks for the code. Based on this the issue came apparent and I have added a test case to my test suite.
The issue is fixed in v0.18.12, but may reappear, if the setAcceleration() would jump back and forth between 999 and 1000. Perhaps later add a test case for this.

added a test case with alternating acceleration: no failure

added a test case with alternating acceleration: no failure


Generalize command parsing

Instead of having hard-coded commands defined, generalize parsing of commands, so they can be configured in a more dynamic way.

This will largely solve itself by migrating functionality to plugins (with #8), except for whatever core stuff we want to keep in the bot proper


832: Use a disk cache (TEMP_DIR) to optimize audit report generation

Ticket #832
Description
Audit report generation has been getting progressively slower, as we need to process more and more upload workbooks to produce the desired report.
The motivating idea behind this approach is that the single slowest part of audit report generation is not the logic, formatting or even disk access.  It is the XLSX.read operation.
Short of digging into this third party code, a minimally invasive way to optimise this expensive step is to introduce a cache layer.
Each upload, parsed as JSON is about a megabyte in size.  Our production ARPA tool manages about 1000 uploads today.  That's a little more data than I think we should be comfortable holding in RAM.  We could persist this cached content in our database, but parsing and printing JSON into a database involves overhead and adds load to the DB service.
In this diff, I try a relatively naive disk cache instead.  This mirrors the way we handle the original .xlsm upload content today.
Operationally, the impact of this diff is:

No DB migrations required (now or in the future)
No manual scripts required to populate cache
Changes to the audit report or record parsing logic do not require manual intervention
Cache will need to be flushed if and only if we change the parsing options passed to XLSX.read.
To flush the cache: wipe the TEMP_DIR folder from the deployment's disk instance

This pull request is an alternative approach to #833.  We should land one or the other (not both)!
Screenshots / Demo Video

Testing
To test:

check out branch
yarn install
yarn start
Set VERBOSE=true in your .env file
Upload at least one valid workbook, if none present in your instance
Click the "Download audit report" button on the home screen
Verify that subsequent downloads are faster, and verbose console logs indicate expected cache usage

Checklist

[x] Provided ticket and description
[x] Your PR title contains the ISSUE ticket number e.g "86: ..."
[x] Provided screenshots/demo
[x] Provided testing information
[ ] Provided adequate test coverage for all new code
[ ] Run automated tests (docker compose exec app yarn test)
[x] Added PR reviewers
[ ] Ensure at least 1 review before merging

I think one neat feature of this approach is that the cache will be populated gradually.  Whenever a user validates an upload or generates a treasury report, the associated uploads will be cached for later use by the audit report!

Also, would love to see some unit tests on here :)

@trumanc I can answer a couple of your questions!

I'm unsure of how Render (and soon AWS) treat their tmp directories. How frequently would those dirs be wiped, completely clearing our cache?

I am not actually using a system temp dir in this PR.  This just uses another subfolder of our server's DATA_DIR which I label "tmp".  Therefore the system will not auto-wipe it, just like our current uploads directory.  Maybe I should name it something other than TEMP_DIR, for increased clarity?

This cache is making a strong statement that the only part of the process we need to optimize in order to fix performance concerns is the XLSX.read call...

This is still a very valid point.  It might be a good idea to try both of our PRs on staging to see the practical impact of each?

Not a major concern, but I'm curious what the relative sizes of the original .xlsx workbook, this parsed workbook data object, and the pure json records objects are.

I can answer this for a couple .xlsx and .json files!  For two 470kB .xlsx files I uploaded, the equivalent JSON size on disk was 2.1MB.  That makes sense to me, since I believe the .xlsx format uses a zip compression under the hood.  I would definitely be worried about keeping cache content of this size in memory, but I don't think it's likely to be problematic on disk?

Oh wow I didn't expect the file size to go up by more than 4x, that has me even more concerned about file I/O time now. I wonder if there's a good way to test that

Okay, I mucked around a bit and got some profiling data!
For sample data, I worked out how to SSH into the staging host and clone the uploads directory to my local system.  Then I pointed my local build to the staging database.  I logged into a user on tenant 1 and generated the audit report.
Some top line findings:
Without any cache logic, generating an audit report took 7351 ms.  Of that time, 6003 ms were spent running synchronous XLSX.read jobs.  Since XLSX.write runs synchronously on the main thread, this doesn't benefit from our use of async-batch or other async code patterns.  In the logs below, you can see that some IO operations take a non-trivial time, but since we use fs/promises, IO operations do not block the main thread.
With disk cache populated, the audit report drops to 2773 ms..  IO does become the bottleneck now, but note that jsonForUpload operations do not appear to take any longer than bufferForUpload, on average.


[JBEAP-8015][JBEAP-8013]: Impossible to use JAX-RS and Spring MVC in the same WEB a…

…pplication
Jira: https://issues.jboss.org/browse/JBEAP-8015
Master branch PR: https://github.com/resteasy/Resteasy/pull/1032

@gaol I'm closing this PR as the 3.0.x branch is being renamed to 3.0.19.SPx. Once decided what to do with this issue, we'll either get the changes from here and create a new PR or propose a different fix. Thanks anyway.


Improve regex to reduce effects of whitespace

Fixes #148

Codecov Report

Merging #168 (72c5785) into master (4f3d9ff) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
+ Coverage     54.50%   54.64%   +0.13%
  Complexity      485      485
============================================
  Files           114      114
  Lines          1976     1982       +6
  Branches        202      202
============================================
+ Hits           1077     1083       +6
  Misses          824      824
  Partials         75       75

Impacted Files
Coverage Δ

.../java/bookface/logic/parser/LoanCommandParser.java
0.00% <ø> (ø)

...ava/bookface/logic/parser/ReturnCommandParser.java
0.00% <ø> (ø)

src/main/java/bookface/model/book/Author.java
63.63% <100.00%> (+3.63%)
:arrow_up:

src/main/java/bookface/model/book/Title.java
72.72% <100.00%> (+2.72%)
:arrow_up:

src/main/java/bookface/model/person/Email.java
81.81% <100.00%> (+1.81%)
:arrow_up:

src/main/java/bookface/model/person/Name.java
81.81% <100.00%> (+1.81%)
:arrow_up:

src/main/java/bookface/model/person/Phone.java
81.81% <100.00%> (+1.81%)
:arrow_up:

src/main/java/bookface/model/tag/Tag.java
81.81% <100.00%> (+1.81%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix typos in READMEs and documentation

What does this PR do?

This PR fix some typos in the READMEs and in the documentation.
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Hyperlink DOIs against preferred resolver

Hello :-)
The DOI foundation recommends this new, secure resolver. Would a PR that updates all static links & the code that generates new ones, plus the test cases be welcome?
Cheers!

PS: Also in the sister repos.

@katrinleinweber - thanks for the suggestion. What would be the benefit of using your suggested resolver over just using http://dx.doi.org or even just http://doi.org in our URL-encoded DOIs?

@horsburgh The benefit is that it is encrypted + securt https instead of http.
@katrinleinweber yes PRs are welcome :)

@dtarb @horsburgh Took a quick look at the code change, and found the only change involved is to change http://dx.doi.org/ to https://doi.org.  The https version is preferred and secured URL, but http version is also supported by DOI server. The XML metadata file will be updated accordingly for new published resources since it retrieves URL-encoded DOI from our identifier metadata element. But for old published resources, DOI URL will not be updated unless we do a data migration. However, the old http URL still works, so we may not need to do a data migration since both versions of DOI URLs work. I guess this PR can make the new published resources to use the new preferred secure https DOI URL version going forward, which probably is a good thing.

#2690 is the PR.


Add RoutePath param to createApp()

see some context to this here
This is either something very useful, or something very silly and I missed a point. Either way will be a good discussion.
Thanks

I would love to see this merged. Exactly what I need on my project.


feat(open-graph): add copy actions

Description
Add a copy action for each existing value.
Fixes #9630
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

LGTM 👍
Thanks for your contribution.

Hey, nicely done! :)


pyxet should not require git

pyxet currently has a small git dependency and prints a message to set up user.email etc from time to time. xet mount also currently has a strong git dependency. I think the dependency can be eliminated.

Fixed. xet mount still requires git but that is a bit more involving to fix. Will defer until that becomes an issue.


fix(CardGroup): allow CardGroup to set Card with cta copy

Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
CardSectionSimple needs to have Cards that have text in the cta. Allowing CardGroup to set Card passing in any cta props.

Changelog
Changed

pass in cta props to Card from CardGroup

@annawen1 looks like the snapshot file needs updating.


Built-in prompt compression

Optimization being part of prompt design, it'd be great to integrate a tool like LLMLingua in the VSC extension.
The prompty file could have a compression section:
compression:
    rate: 0.55
    target_token: 200
    ...

I think this is a great idea. @sethjuarez  what do you think?

In general it should be able to be done in the render/parse step - maybe we could add an invoker for this?


Hoisted variables forgotten after yield, unless hoisted manually

Hi,
Thanks for a great tool that saves me a lot of work!
I am using Closure v20160713 to minify autogenerated JS code.
It is started up by the Transcrypt Python to JS compiler with the options given below:
import os
import subprocess

from org.transcrypt import utils

closureCompilerPath = '{}/closure_compiler/compiler.jar'.format (os.path.dirname (os.path.abspath (__file__)) .replace ('\\', '/'))

def run (sourcePath, targetPath, postMapPath, javaScriptVersion):
	params = [
		'java', '-jar',
		closureCompilerPath,
		'--language_in=ES{}'.format (javaScriptVersion),
		'--language_out=ECMASCRIPT5_STRICT',
		'--compilation_level', 'SIMPLE_OPTIMIZATIONS',
		'--js', sourcePath,
		'--js_output_file', targetPath
	]

	if utils.commandArgs.map:
		params += [
			'--create_source_map', postMapPath,
			'--source_map_format=V3'
		]

	subprocess.run (params)

Function 'accumulate' (part of Python 3.5 itertools module) works correctly in Chrome without using Closure to minify, but doesn't work if minified by Closure.
The value of variable  'sum' is forgotten after the yield.
No error report or warning is given.
var accumulate = function* (iterable, func) {
	let first = true;
	if (func) {
		for (let item of iterable) {
			if (first) {
				var sum = item;
				first = false;
			}
			else {
				sum = func (sum, item);
			}
			yield sum;
		}
	}
	else {
		for (let item of iterable) {
			if (first) {
				var sum = item;
				first = false;
			}
			else {
				sum = sum + item;
			}
			yield sum;
		}
	}
}

Manually hoising variable 'sum' circumvents the problem:
var accumulate = function* (iterable, func) {
	let sum;
	let first = true;
	if (func) {
		for (let item of iterable) {
			if (first) {
				sum = item;
				first = false;
			}
			else {
				sum = func (sum, item);
			}
			yield sum;
		}
	}
	else {
		for (let item of iterable) {
			if (first) {
				sum = item;
				first = false;
			}
			else {
				sum = sum + item;
			}
			yield sum;
		}
	}
}

You want to report this against the compiler.

Wrong spot, thanks  & sorry...

Np
On Jul 15, 2016 12:27 PM, "Jacques de Hooge"<EMAIL_ADDRESS>wrote:

Wrong spot, thanks & sorry...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-library/issues/730#issuecomment-233048712,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMDKqJbklvmgWvAO03nFHxTEfQoofVCks5qV98zgaJpZM4JNtM7
.


purge/update: remove backward compatibility legacy

This was introduced in 3.1 and marked as deprecation
We can definitely drop it in stable-4.0
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-non_container-purge

jenkins test centos-container-purge

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman


Switch to VSFilter as subtitle renderer

Branching this off from #96.
assrender is unfortunately out of date by about 2 years, which is a problem since ASS is a rapidly developing format.
The current issue with using VSFilter is that it doesn't have an automatic font loading solution like assrender.
There needs to be some kind of temporary font loading solution on my part.

You can ask for help at<EMAIL_ADDRESS>I am sure there will be someone who can help you out.

I'm fairly sure I know what I need to do (AddFontResource) I just need to get around to writing all the code that makes sure I don't have any stupid memory leaks or something.

Nonetheless, it can be useful for your current project.

I was just talking with @line0 on this and a few others in #irrational-typesetting-wizardry and he pointed me in this direcion: https://github.com/line0/ExRelease/blob/master/ExRelease.psm1#L666

To be honest, I'm somewhat surprised.
You don't have to worry about not (un)loading fonts that are already installed on the system?

I think with AddFontResourceEx it is temporary or only for the current session.

Included in v2.16.0.


Unexpected returns from array.slice() if end > array.size()-1

Godot version:
Godot_v3.2-beta3_win64
OS/device including version:
Windows 10
Issue description:
Running this code
func _ready():
	var array = [0,1,2]
	for i in range(-2, 3):
		var slice = array.slice(0, array.size() + i)
		print(slice)

prints
[0, 1]
[0, 1, 2]
[0, 1, 2, 2]
[0, 1, 2, 2]
[0, 1, 2, 2]
It seems to return with a copy of the final element at the end of the array when you make 'end' higher than the array's max index. This only happens if 'step' is 1.
If you change array to [[0,0],[1,1],[2,2]] you get
[[0, 0], [1, 1]]
[[0, 0], [1, 1], [2, 2]]
[[0, 0], [1, 1], [2, 2], [...]]
[[0, 0], [1, 1], [2, 2], [...]]
[[0, 0], [1, 1], [2, 2], [...]]
getting the [...] returns [2, 2] (slice[-1]) (slice.size() returns 4)

This bug still exists in the 3.2.1 rc2 release.
The issue is obvious in the source code. However, the implementation of this method seems a bit too complicated and error prone compared to other source code in Array.cpp.

There's also this thing that is similar to this issue:
print([0, 1, 2, 3, 4, 5].slice(0, 6)) # [0, 1, 2, 3, 4, 5, 5]
print([0, 1, 2, 3, 4, 5].slice(0, 6, 2)) # [0, 2, 4, 5]

The first line shows the bug described here. The second one takes every second element but if the end index is off by one, it also grabs that 5 in the end, which it probably shouldn't.

I've proposed a re-implementation of Array.slice() to address these and a few other issues I've found with the indexing.
In doing so, I've also modified the method so the end (aka stop) parameter is exclusive.  This could be considered a breaking change, however:

This is consistent with other scripting languages that implement a .slice(begin, end) method (e.g., Python, JavaScript)
This is consistent with GDScript's range(initial, final, increment) implementation, where the final element generated is final-1.

It seems logical (although up for debate) that getting a subset of a list using range() and slice() using similar inputs would yield the same results:
var a1 = [0,1,2,3,4,5]

#Using Range
for i in range(0,3):
 print(a1[i])

#Using Slice
var a2 = a1.slice(0, 3)
for i in a2:
    print(a2[i]) # output should be the same

Array.slice() currently returns an extra element , but with this pull request the results of the two approaches would  be brought to parity.
Here are some additional details on updated behavior using 14 scenarios:
Cases where behavior will change:

#
Code
Current
Proposed

1
[0, 1, 2, 3, 4, 5].slice(1, 4)
[1, 2, 3, 4]
[1, 2, 3]

2
[0, 1, 2, 3, 4, 5].slice(0, 6)
[0, 1, 2, 3, 4, 5, 5]
[0, 1, 2, 3, 4, 5]

3
[0, 1, 2, 3, 4, 5].slice(0, 6, 2)
[0, 2, 4, 5]
[0, 2, 4]

4
[0, 1, 2, 3, 4, 5].slice(6, 0, -1)
[5, 4, 3, 2, 1, 0]
[5, 4, 3, 2, 1]

5
[0, 1, 2, 3, 4, 5].slice(2, 2)
[2]
[]

6
[0, 1].slice(0, 1, 2)
[]
[0]

7
[0, 1].slice(0, 2, 2)
[0, 1]
[0]

8
[0, 1, 2, 3, 4, 5].slice(-4, -1)
[2, 3, 4, 5]
[2, 3, 4]

9
[0, 1, 2, 3, 4, 5].slice(-1, -4, -1)
[5, 4, 3, 2]
[5, 4, 3]

Cases 2, 3, 6, 7 were previously identified in this issue discussion.
Cases where behavior will not change:

#
Code
Current
Proposed

10
[0, 1, 2, 3, 4, 5].slice(6, 0)
[]
[]

11
[0, 1, 2, 3, 4, 5].slice(6, 0, -2)
[5, 3, 1]
[5, 3, 1]

12
[0, 1, 2, 3, 4, 5].slice(0, 6, 0)
ERROR -> []
ERROR -> []

13
[0, 1, 2, 3, 4, 5].slice(-4, -1, -1)
[]
[]

14
[0, 1, 2, 3, 4, 5].slice(-1, -4)
[]
[]

Perhaps of note, I've used CPython as the reference implementation ("lifted directly"?).  Running these inputs in Python using the list[start:stop:step] notation will give identical results to the proposed state, with the exception of Case 12.  If given a step of size 0, Python will error and stop processing, where the proposed implementation will error but continue processing with an empty Array.


Manual approval required for workflow run<PHONE_NUMBER>

Workflow is pending manual review.
URL: https://github.com/pushpendrasingh3/manual-approval/actions/runs/8249270358
Required approvers: [pushpendrasingh3]
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.

approved

All approvers have approved, continuing workflow and closing this issue.


Fix Access error bug

Hi!
If there is an error with a parameterised query, then the following exception occurs:
** (exit) an exception was raised:
    ** (ArgumentError) the Access calls for keywords expect the key to be an atom, got: "code"
        (elixir) lib/access.ex:166: Access.fetch/2
        (elixir) lib/access.ex:179: Access.get/3
        (neo4j_sips) lib/neo4j_sips/query.ex:37: Neo4j.Sips.Query.do_query!/1

This PR fixes the Access errors by using dot notation to access the struct's members instead.

That is correct, thank you. I fixed this in bolt_sips but not here. I'll promote the PR as soon as I get close to a computer, later on today, and will also push a new release. Many thanks for catching this! - Florin

merged, and a new version available at Hex.pm. Thanks again!


Propose update Dakota 6.20

Small question/remark: I noticed that numpy has now gone to release 2.0. I think you are building with the latest release, so that would mean that this would be build with numpy 2.0. That would be a good thing, since that should be compatible with both numpy 1.0 and 2.0. But it might be good to check that.


Ionicons not appearing (404)

Live example:
http://amirsharif.com/
Repo:
https://github.com/Overload119/amirsharif.com
The fonts folder is not being included in the assets paths.

I added this line to /Users/amirsharif/Projects/amirsharif.com/_config.yml
assets:
  assets:
    - _assets/fonts


The purpose of pretrain script?

Doesn't LongChat is a fine-tune from Llama Model but with a tweak script to rotation embedding layer? Or you have to do pretraining first before fine-tuning with sharegpt data? Because the script for pretraining exists and makes me assume we have to pretrained Llama Model first before fine-tuning.

@fahadh4ilyas Thanks for the question! The pre-training script was not used for LongChat. It is for people who wish to do some pre-training experiments.

Thank you for the clarification...


load_mon: increase cpuload rate, get corresponding time safetly, and misc cleanup

increase rate from 1 Hz to 3.3 Hz (every 300 ms)
cpu load calculation grab timestamp with runtime in a critical section
task stack only check one task per cycle (but cycle at a higher rate)
decrease available FD threshold 3 -> 2
minor cleanup (split out header)

I increased the rate slightly because I wanted to have a bit more detail in the logs.


remove tlsEnd from FetchTimingInfo in network module

It is not present in the spec: https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo
Bug: #765

This can only be merged once WPT is updated (https://github.com/GoogleChromeLabs/chromium-bidi/pull/787).


Replace exception with warning

In this PR we enable the CUDA  training with the INCTrainer, neural-compressor must be installed from source

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Feature/work clusters (WIP)

Codecov Report

Merging #466 (6abec9b) into develop (746360f) will increase coverage by 1.01%.
The diff coverage is n/a.

:exclamation: Current head 6abec9b differs from pull request most recent head f73da6e. Consider uploading reports for the commit f73da6e to get more accurate results

@@             Coverage Diff              @@
##           develop      #466      +/-   ##
============================================
+ Coverage    98.98%   100.00%   +1.01%
============================================
  Files          112         5     -107
  Lines         5934        78    -5856
  Branches         8         8
============================================
- Hits          5874        78    -5796
+ Misses          60         0      -60

Merged https://github.com/Princeton-CDH/ppa-django/pull/505 into this PR. Waiting to see if the tests pass before merging this PR into develop.


[stress testing] Document metrics and events that we've used for Event Hubs stress testing

As part of building stress testing for the Event Hubs in Java, @YijunXieMS found some good metrics to report to distinguish between separate partitions send/receive rates as well as some adhoc queries/charts.
For this issue we'd like to document the names and their usage (nothing is final, this is just a first pass) and use them as a template for other Event Hubs based tests (and, depending on commonality, for Service Bus tests).

First round of discussion is complete and documented here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/494/Event-Hubs-Telemetry
The second pass (with @jsquire) is tracked in #3223


fontbakery: fix build failures

Description of changes
The bulk update of Python packages in PR #294305 introduced build failures in fontbakery and several of its dependencies. This fixes the whole chain to get fontbakery building again.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

~For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)~

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 300400 run on x86_64-linux 1

4 packages failed to build:

python312Packages.fontbakery
python312Packages.fontbakery.dist
python312Packages.glyphsets
python312Packages.glyphsets.dist

16 packages built:

fontbakery (python311Packages.fontbakery)
fontbakery.dist (python311Packages.fontbakery.dist)
python311Packages.gflanguages
python311Packages.gflanguages.dist
python311Packages.gfsubsets
python311Packages.gfsubsets.dist
python311Packages.glyphsets
python311Packages.glyphsets.dist
shaperglot (python311Packages.shaperglot)
shaperglot.dist (python311Packages.shaperglot.dist)
python312Packages.gflanguages
python312Packages.gflanguages.dist
python312Packages.gfsubsets
python312Packages.gfsubsets.dist
python312Packages.shaperglot
python312Packages.shaperglot.dist

Thanks for the review. I've amended this PR to use pyproject = true; and the PEP-517 attributes for all four packages touched in the PR. I've also explicitly disabled tests for the gfsubsets package (there are indeed no unit tests) and added an import check, which helped me to find an undeclared dependency.

Just for the record, the build failures reported by nixpkgs-review are on Python 3.12, due to an unrelated build failure in openstep-plist. It's failing on master also. The Python 3.11 builds are successful.


Does Calico Operator Add-on support Egress Gateway?

Describe the documentation issue
Looking at https://aws-quickstart.github.io/cdk-eks-blueprints/addons/calico-operator/ I'm not sure if it's Calico open source or Calico Enterprise - it seems the former?
This page https://docs.tigera.io/calico-cloud/about/product-comparison tells me I need Calico Enterprise for an Egress Gateway.
Links
https://aws-quickstart.github.io/cdk-eks-blueprints/addons/calico-operator/

I believe I have found the answer: https://github.com/projectcalico/calico/issues/7338

@NinoSkopac with support of Network Policies natively by VPC-CNI, what is your use case to use Calico? Are you trying to work around the issue of IPv4 exhaustion, by using an overlay network?
We do have an approach for IPv4 exhaustion with secondary CIDRs and VPC-CNI configuration if that is what you are after.

Dear @shapirov103 ,
My use case is as follows. I have a container that requires full cone NAT. To achieve that I give the container an elastic IP using the EIP controller: https://github.com/aws-samples/aws-pod-eip-controller. An EIP allows unsolicited connections to come in on a set port, which is basically the definition of full cone NAT.
The problem is as you say IPv4 exhaustion. I want to have hundreds of these containers running in the same time and each of them needs an elastic IP, which is impossible due to AWS limits.
I want to use an egress gateway and give it an elastic IP and then route the traffic from the previously mentioned hundreds of containers through the egress gateway.
I'd put those hundreds of containers in the namespace and configure Cilium rather than Calico due to former being FOSS to do the routing.
I'll look into the link you gave me, thank you very much and have a great day!

Dear @shapirov103 ,
My use case is as follows. I have a container that requires full cone NAT. To achieve that I give the container an elastic IP using the EIP controller: https://github.com/aws-samples/aws-pod-eip-controller. An EIP allows unsolicited connections to come in on a set port, which is basically the definition of full cone NAT.
The problem is as you say IPv4 exhaustion. I want to have hundreds of these containers running in the same time and each of them requires an elastic IP, which is impossible due to AWS limits.
I want to use an egress gateway and give it an elastic IP and then route the traffic from the previously mentioned hundreds of containers through the egress gateway. Will it work? I don't know.
I'd put those hundreds of containers in a namespace and configure Cilium rather than Calico due to former being FOSS to do the routing.
I'll look into the link you gave me, thank you very much and have a great day!

I found this egressgateway which can work with calico: egressgateway

Dear @xiaosuiba ,
thank you so much for that link.
However, I have decided not to use Calico, I'm going to use Cilium. GKE went from Calico to Cilium. Calico is not FOSS, Cilium is. I hope I can pull it off using Cilium Egress Gateway: https://docs.cilium.io/en/stable/network/egress-gateway/egress-gateway/

@NinoSkopac Cilium Egress Gateway is not HA, it allows You to use only one egress node


[Bug]: Example app Gallery component gestures not working.

Summary
I cloned the project and followed the steps to run it locally. I did use yarn and decided to try it on ios simulator. The Gallery component's gestures don't seem to work. I also tried it on Expo Go and go the same result.
Environment
Apple M3 Pro 18 GB | simulator: iPhone 15 Pro iOS 17.2
Expo GO : iPhone 11 Pro
Steps to Reproduce
Clone the project.
Run yarn example start.
Start the project wether with an iOS simulator or Exp GO.

Does it work on Android simulator?

I thought I was going crazy until I saw this issue.


Self Hosted Supabase is not registering Users from Flutter SDK, Opposed to the hosted version which can.

Describe the bug
I am using self hosted supabase on linux, docker and docker compose. Published over the internet. I am trying to interact with it through the flutter SDK. I have the following error on the terminal.
D/EGL_emulation(30987): app_time_stats: avg=8798.66ms min=5.59ms max=228297.12ms count=26 E/flutter (30987): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: AuthException(message: FormatException: Unexpected character (at character 5) E/flutter (30987): 404 page not found E/flutter (30987):     ^ E/flutter (30987): , statusCode: null) E/flutter (30987): #0      GotrueFetch._handleError (package:gotrue/src/fetch.dart:46:7) E/flutter (30987): #1      GotrueFetch._handleRequest (package:gotrue/src/fetch.dart:141:13) E/flutter (30987): <asynchronous suspension> E/flutter (30987): #2      GotrueFetch.request (package:gotrue/src/fetch.dart:88:12) E/flutter (30987): <asynchronous suspension> E/flutter (30987): #3      GoTrueClient.signUp (package:gotrue/src/gotrue_client.dart:214:18) E/flutter (30987): <asynchronous suspension> E/flutter (30987): #4      _MyHomePageState.signUp.<anonymous closure> (package:main_app/main.dart:88:19) E/flutter (30987): <asynchronous suspension> E/flutter (30987): #5      _MyHomePageState.signUp (package:main_app/main.dart:84:35) E/flutter (30987): <asynchronous suspension> E/flutter (30987):
However, I am running the same code but changing to my supabase hosted version it works fine.
To Reproduce
Steps to reproduce the behavior:
Use the flutter snippet against a self hosted Supabase instance.
    final AuthResponse response = await sbClient.auth.signUp(       email: email,       password: password,     )     .whenComplete(() => print('Block Completed.'));
Expected behavior
User should be registered.
Version (please complete the following information):
On Linux/macOS
Please run dart pub deps | grep -E "supabase|gotrue|postgrest|storage_client|realtime_client|functions_client" in your project directory and paste the output here.
├── supabase_flutter 2.5.3 │   ├── supabase 2.1.3 │   │   ├── functions_client 2.2.0 │   │   ├── gotrue 2.7.0 │   │   ├── postgrest 2.1.2 │   │   ├── realtime_client 2.0.4 │   │   ├── storage_client 2.0.1
Additional context
Add any other context about the problem here.

I am trying to resolve the issue, I did a local setup with the CLI.
I run the flutter app from the simulator with debugging I noticed that the SDK sends requests to http://<IP_ADDRESS>:5432/auth/v1/signup?. While when I check what's the API url from the supabase status it gives me http://<IP_ADDRESS>:54321.

You probably have the wrong Supabase URL passed to Supabase.initialize() call for the self-hosted version. Try to see if any of the API methods work.  If not, double check that you have the correct URL. You might be passing the URL to access the studio.


Just Dance on PC

I know this script is almost 2 years old, but I am curious if it still works. I tried to run dance.py but it doesn't work.
I tried to use help from #53 but still nothing...

Yes. I was able to get it to work on Windows 11 relatively easily, but I did need to mess with pip a little bit. Basically, I think some of the older versions of some dependencies don't like newer Python versions, but you can update them and they'll still work with JoyDance.
I'm willing to help you but I'm away this weekend so I can't look at exactly what I did yet.

oh okay, i'll try that thank you <3

oh okay, i'll try that thank you <3

Btw I used Python 3.11 from the Microsoft Store so I know that version works if you're having trouble

@Bartek5347 were you able to get it to work?

@Bartek5347 were you able to get it to work?

Also having trouble here. Mine won't even load up the web UI, even tho there didn't seem to have any problem installing dependencies. Using 3.10.11 here tho.

I changed import aio to import aiohttp in dance.py i think
On Mon, 17 Jun 2024 at 16:45, Blasetvrt @.***> wrote:

@Bartek5347 https://github.com/Bartek5347 were you able to get it to
work?
Also having trouble here. Mine won't even load up the web UI, even tho
there didn't seem to have any problem installing dependencies. Using
3.10.11 here tho.
—
Reply to this email directly, view it on GitHub
https://github.com/redphx/joydance/issues/57#issuecomment-2173613576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BINMRYPBBIHYS667AHC3HZDZH3ZAHAVCNFSM6AAAAABHRZMHBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGYYTGNJXGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yeah, I should've noticed it was not a python issue but a JS one, my issue was the black screen one, which you can only notice by checking the devtools console to see if it has issues finding the modules, so just chsnging the ecmascript import format worked.

Were both of you able to get it to work?


Tool should support multiple secrets

Since the name indicates "secrets" this tool should support multiple secrets. The vault agent config file can support multiple template files, and it should be fairly trivial to iterate over a list to create files in the configmap.

Initial version, supporting multiple secrets (secret names) based on the same vault agent config is in place.


Fix and Update has_public_story Functionality

If you perform too many queries from a certain IP has_public_story() no longer works.
Using this simple example:
import instaloader

L = instaloader.Instaloader()
L.load_session_from_file('...')

profile = instaloader.Post.from_shortcode(L.context, 'bmw')

print(profile.has_public_story)
print(profile.has_viewable_story)

HTTP redirect from https://www.instagram.com/graphql/query to https://www.instagram.com/accounts/login/
Traceback (most recent call last):
  File "e:/instaloader/TODO.py", line 9, in <module>
    print(profile.has_public_story)
  File "e:\instaloader\instaloader\structures.py", line 803, in has_public_story
  File "e:\instaloader\instaloader\instaloadercontext.py", line 430, in graphql_query
    session=tmpsession)
  File "e:\instaloader\instaloader\instaloadercontext.py", line 335, in get_json
    raise LoginRequiredException("Redirected to login page. Use --login.")
instaloader.exceptions.LoginRequiredException: Redirected to login page. Use --login.

This occurs because the query is invoked anonymously.
# query not rate limited if invoked anonymously:
with self._context.anonymous_copy() as anonymous_context:

Fix: Give users the option to call the query both anonymously and not anonymously with the following functions

has_public_story()
has_public_story_anon()

If you perform too many queries from a certain IP has_public_story() no longer works.
[…]
This occurs because the query is invoked anonymously.

If the query is now rate limited when performed anonymously, I see no advantage in forcing it into an anonymous context anymore.

Fix: Give users the option to call the query both anonymously and not anonymously with the following functions

The new version of has_public_story() which omits the anonymous context does also give users the option to call the query anonymously by simply not logging in. Therefore there is no need to have a separate has_public_story_anon().
So, my suggestion would be to just remove the anonymous context instead of splitting the function into an anonymous and a non-anonymous version.

The new version of has_public_story() which omits the anonymous context does also give users the option to call the query anonymously by simply not logging in. Therefore there is no need to have a separate has_public_story_anon().
So, my suggestion would be to just remove the anonymous context instead of splitting the function into an anonymous and a non-anonymous version.

Correct, now that I think about it the user has the option to call the new version of has_public_story() both anonymoysly and while logged in, so it's good to go. I removed has_public_story_anon().

Thanks for reporting and fixing!


Do not use react-native link from cli

I imported this lib by cli and react-native link, this totally messed up my project. I had to create a new one after 6 hours of error search.

I think I did the same thing. If you don't install it with cli, then how do you ? which alternative did you use

I went with this lib and have done all manually as explained in the readme.
#hint: For iOS you have to create an extra Google Maps API key besides the Google Places API and put it here [GMSServices provideAPIKey:@"YOUR_IOS_API_KEY_HERE"]; Its not good explained, but with that hint you should be able to rock.


[Missing Implementation]Playwright chromium launching in Incognito Mode, no option to change it

What are you trying to achieve?
launching application in chromium and Test
What do you get instead?
Chromium getting started in Incognito mode, should have option to launch in Normal mode

Provide console output if related. Use --verbose mode for more details.

#      userDataDir option is not supported in `browserType.launch`. Use `browserType.launchPersistentContext` instead
  rror: userDataDir option is not supported in `browserType.launch`. Use `browserType.launchPersistentContext` instead
      at Object.assert (node_modules\playwright-core\lib\helper.js:288:15)
      at Chromium.launch (node_modules\playwright-core\lib\server\chromium.js:43:18)
      at Playwright._startBrowser (node_modules\codeceptjs\lib\helper\Playwright.js:531:61)
      at Playwright._beforeSuite (node_modules\codeceptjs\lib\helper\Playwright.js:299:19)
      at C:\Automation\Demo_Playwright\node_modules\codeceptjs\lib\listener\helpers.js:27:69
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

Provide test source code if related

// Please implement
const browser = await playwright[browserType].launchPersistentContext(userDataDir,{headless:false})
along with
const browser = await playwright[browserType].launch({headless:false})

Details

CodeceptJS version:2.6.2
NodeJS Version:
Operating System:Win 10
pPlaywright
Configuration file:

# exports.config = {
  tests: './tests/*_test.js',
  timeout: 10000,
  output: './output',
  manualStart:true,
  helpers: {
    Playwright: {
      url: '',
      show: true,
      browser: 'chromium',
      chromium: {
          browserContext: false,
          userDataDir: " C:/Users/test/AppData/Local/Chromium/User Data"
          args: [
            '--disable-features=ImprovedCookieControls',
        ],
      },
      windowSize: '1900x1200'

// Please implement
const browser = await playwright[browserType].launchPersistentContext(userDataDir,{headless:false})
along with
const browser = await playwright[browserType].launch({headless:false})

I think you are half-done to get it implemented by yourself.
It is easy to start contributing to CodeceptJS, send a pull request to Playwright helper with your changes and we will try to get it into a release!

// Please implement
const browser = await playwright[browserType].launchPersistentContext(userDataDir,{headless:false})
along with
const browser = await playwright[browserType].launch({headless:false})

I think you are half-done to get it implemented by yourself.
It is easy to start contributing to CodeceptJS, send a pull request to Playwright helper with your changes and we will try to get it into a release!

Thanks @DavertMik , i still find issues with Playwright launchPersistentContext method, will send pull request once i have proper fix.

Hello @MaxTester1 can we add a lauchType option same as jest-playwright did ?
launchType <LAUNCH | PERSISTENT | SERVER>. Method to launch browser instance. jest-playwright attaches Playwright to an existing browser instance by default.

Hello @MaxTester1 can we add a lauchType option same as jest-playwright did ?
launchType <LAUNCH | PERSISTENT | SERVER>. Method to launch browser instance. jest-playwright attaches Playwright to an existing browser instance by default.


Decode Tuple

Continuation of: https://github.com/EthWorks/ethereum.rb/issues/141
Any solution so far?

No, I'm still unsure how this is done actually. We are tracking this here: #102


Announce Beta feature & Package Show in bootstrap

We want to start getting feedback from our users as soon as possible. :bowtie:
From @dmarcoux: Take note that I will add the screenshots once the sprint is over to have the latest state of the pages. This explains the Do Not Merge

Deploy preview for openbuildservice ready!
Built with commit 888d1998f73f2eb9d155b7fa393b51d4405f1ae7
https://deploy-preview-203--openbuildservice.netlify.com

 Announce the Beta Link

I have added the two blogs together in the same PR as the content in the includes is used by both blog post. That was @hennevogel's idea, but I am not convinced of writing such repetitive blog post. :thinking:
@openSUSE/open-build-service I am on vacation until Friday, so someone has to take care of @dmarcoux's comments. :wink:

I will take over since @Ana06 is not here until Friday.

I really like the blog post about the beta feature. Well done!
For the second bootstrap blogpost:
I don't think we have to repeat parts of the beta blog post there. A reference to the other post should be enough.
And I would change the file name of the bootstrap post: '_posts/development/2018-10-05-beta.md'. The '2018-10-05-beta.md' is part of the URL which is a bit confusing.

And if someone has some time, it would be cool if we could fix #180 :smiley:

@openSUSE/obs-frontend Please review the posts. Take note that I will add the screenshots once the sprint is over to have the latest state of the pages.

The 'new pages' page looks strange:

@bgeuken This is normal. I'm waiting for the "final" state of packages to take screenshots / gifs / side by side comparison.

LGTM beside what Björn says :+1:

@hennevogel Please have a look again.

L:heart:TM

Thank you to everybody involved!!!


[Re-request][Feature] Add ChangeStar model

Part 2 of #18  .
Add one SOTA muti-task CD model, ChangeStar (the paper was published in ICCV 2021).

有个冲突需要解决

已解决。


Bottom sheet covers bottom navigation bar, how to open it from behind

I am using BottomSheetScaffold with Scaffold that has BottomBar and when the bottomsheet is opened, it opens on top/front of bottom navigation bar, covering it instead of opening from behind. Is there any way to achieve this? Also, is there a way to anchor the bottom sheet to different points on screen instead of only Expand(full height) and Collapse(all the way down)?

Hi!
This issue seems unrelated to the compose-samples repository directly, issues here are reserved for bug reports within the compose-samples apps or feature requests for the sample apps.
For questions related to Jetpack Compose - we recommend asking them on StackOverflow with the android-jetpack-compose tag.
If you find an issue with an Android Jetpack Compose components, report it using the Jetpack Compose issue tracker.


[Bug/Question] Incorrect tagging behavior with accented characters

Issue Summary:
When attempting to tag audio files using TagLib, specifically when the fields contain words with accent marks, the resulting tags display strange characters or completely different words. This behavior indicates a potential problem with character encoding or handling of special characters within the library.
Steps to Reproduce:

Choose an audio file with metadata fields containing words with accent marks (e.g., á, é, í, ó, ú).
Use TagLib to programmatically tag the audio file, setting values for fields with accented characters.
Verify the tags applied to the audio file.

Expected Behavior:
The tags applied to the audio file should accurately reflect the values provided, including any words with accent marks. The text should remain intact and correctly encoded.
Actual Behavior:
The tags display strange characters or entirely different words instead of the expected text with accent marks. This behavior suggests a potential issue with character encoding or handling within TagLib.
(Sorry for the initial sent info, it was a template I have)

For example: "ú" is replaced by "Ãº".
I don't know if I should encode the string in some way for being able to write it correctly

Which format?

Which format?

I would say MP3

Could you please check by your side if this occurs? I just realized now checking my app that it may be a problem with Jetpack Compose decoding the string bytes...
This is just a note that I leave here since right now I can't test if this is a problem of the lib since I just went to bed haha. Thanks for attending the issue and for the nice library!

Thanks for reporting! It's fixed. I will publish a new release soon.

Thanks for reporting! It's fixed. I will publish a new release soon.

Thanks!


[code-infra] Drop support for React<18 in @mui/internal-test-utils/userEvent

userEvent.mousePress or userEvent.keyPress do not seem to be used in this repo.
mui-x is using those extensively and never in an environment where React < 18.
The existing function has an inconsistent return type (act returns a Promise).
Also renamed userEvent export to fireUserEvent to avoid the confusion with @testing/library/user-event and in turn errors produced by the eslint-plugin-testing-library when userEvent calls are detected (plugin assumes they are from @testing-library/user-event and complains if they are not awaited).

Are they still needed given that we also use @testing-library/user-event? It already has APIs for mouse and keyboard on board.

Are they still needed given that we also use @testing-library/user-event? It already has APIs for mouse and keyboard on board.

I've explored the option of using solely the @testing-library/user-event instead of these "fakes", but it created timeout issues in tests. 🙈
I think that such refactoring is better done separately from the ESLint plugin introduction. 👍

doesn't it only return a promise when called with an async function? In any case, I'd rather make those methods async and keep the act, but just calling it asynchronously.

act in those functions returns a Promise when called in an environment with React < 18.
But AFAIK, there are no instances where tests using these functions are run on older React versions. 🤷
If you don't agree with the change, I can only keep the rename of the export, which is mainly needed for the Eslint plugin setup on mui-x. 🤔

Would it make sense to just move these functions to X and remove them here?

Would it make sense to just move these functions to X and remove them here? I don't see why we would use them over @testing-library/user-event.

Great observation. 💯
I will look into that.


On totalProgress jumps back to 0

Hi
I'm using the "on('totalProgress', (submitted,total) =>..." callback to display progress of the total upload. Somehow it seems that after reaching 100% both the values 'submitted and total' switch back to '0' immediately. Which deliveries a nice NaN for displaying.
Did you ever come across that issue?

This is a question about fine-uploader itself, not the VueJS wrapper.


testing required parameter returns 400 bad request hangs

Informations

Type
Version

Question
4.30.1

Description
I want to write a test that verifies if a call is made with a missing parameter then it returns 400.
I have the following controller:
@Controller('/payments')
export class PaymentsController {
  @Post('/')
  @Status(HttpStatusCode.Created)
  async create(
    @Request() req: Express.Request,
    @Required()
    @BodyParams('paymentType')
    paymentType: PaymentType
  ): Promise<CreatePaymentResponse> {

And I have the following test:
describe('payments', () => {
  let app: any;

  beforeAll(bootstrap(FakeServer));

  beforeEach(inject([ExpressApplication], (expressApplication: ExpressApplication) => {
    app = request(expressApplication);
  }));

  it('should return Bad Request Request for missing payment type', async () => {
    await app
      .post(paymentsUrl)
      .send()
      .expect(HttpStatusCode.BadRequest);
  });

I am using jest but it just hangs and displays this error message:

Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.

so for some reason the promise is not resolving gut only in test.  It works in reality.
Is there a better way to test this or why would the promise not be resolved?

@dagda1 Can I close this issue ?


[REQUEST] rename with_epoch()  method of WebDataset

this method is crucial in distributed training yet i found this name very confusing. regarding the manual, the only reference to it seems to be
You then set the epoch length explicitly with the `.with_epoch` method.
which, while helpful after tinkering with the function a bit, is not clear.
wouldn't it be more descriptive to convert it something like .set_one_epoch_samples() or something better?

Perhaps. But that would be an incompatible change. Sometimes people make bad picks for names and we are stuck with it. I'll try to improve the documentation.


duplicate   insert mongodb data ，No duplicate mongodb data in ES

Describe the bug(Please use English)
A clear and concise description of what the bug is.
Environment :

flink-1.13.2
Flink CDC version: 2.2.1
Database and version:  flink-sql-connector-mongodb-cdc-2.2.1 、flink-sql-connector-elasticsearch7_2.11-1.13.2

To Reproduce
Steps to reproduce the behavior:

Thes test data :

   -- Flink SQL
-- checkpoint every 3000 milliseconds
Flink SQL> SET execution.checkpointing.interval = 3s;

-- set local time zone as Asia/Shanghai
Flink SQL> SET table.local-time-zone = Asia/Shanghai;

Flink SQL> CREATE TABLE orders (
   _id STRING,
   order_id INT,
   order_date TIMESTAMP_LTZ(3),
   customer_id INT,
   price DECIMAL(10, 5),
   product ROW<name STRING, description STRING>,
   order_status BOOLEAN,
   PRIMARY KEY (_id) NOT ENFORCED
 ) WITH (
   'connector' = 'mongodb-cdc',
   'hosts' = 'localhost:27017',
   'username' = 'mongouser',
   'password' = 'mongopw',
   'database' = 'mgdb',
   'collection' = 'orders'
 );

 Flink SQL> CREATE TABLE customers (
   _id STRING,
   customer_id INT,
   name STRING,
   address STRING,
   PRIMARY KEY (_id) NOT ENFORCED
 ) WITH (
   'connector' = 'mongodb-cdc',
   'hosts' = 'localhost:27017',
   'username' = 'mongouser',
   'password' = 'mongopw',
   'database' = 'mgdb',
   'collection' = 'customers'
 );

Flink SQL> CREATE TABLE enriched_orders (
   order_id INT,
   order_date TIMESTAMP_LTZ(3),
   customer_id INT,
   price DECIMAL(10, 5),
   product ROW<name STRING, description STRING>,
   order_status BOOLEAN,
   customer_name STRING,
   customer_address STRING,
   PRIMARY KEY (order_id) NOT ENFORCED
 ) WITH (
     'connector' = 'elasticsearch-7',
     'hosts' = 'http://localhost:9200',
     'index' = 'enriched_orders'
 );

Flink SQL> INSERT INTO enriched_orders
 SELECT o.order_id,
        o.order_date,
        o.customer_id,
        o.price,
        o.product,
        o.order_status,
        c.name,
        c. address
   FROM orders AS o
   LEFT JOIN customers AS c ON o.customer_id = c.customer_id;

   db.orders.insert({
  order_id: 104,
  order_date: ISODate("2020-07-30T12:00:30.001Z"),
  customer_id: 1004,
  price: NumberDecimal("25.25"),
  product: {
    name: 'rocks',
    description: 'box of assorted rocks'
  },
  order_status: false
});

   db.orders.insert({
  order_id: 104,
  order_date: ISODate("2020-07-30T12:00:30.001Z"),
  customer_id: 1004,
  price: NumberDecimal("25.25"),
  product: {
    name: 'rocks',
    description: 'box of assorted rocks'
  },
  order_status: false
});

db.customers.insert({
  customer_id: 1004,
  name: 'Jacob',
  address: 'Shanghai'
});

db.orders.updateOne(
  { order_id: 104 },
  { $set: { order_status: true } }
);

db.orders.deleteOne(
  { order_id : 104 }
);

a、MongoDB  orders table:

b、MongoDB  customers table:

c、elastic search ：

The test code :
The error :

Additional Description
https://ververica.github.io/flink-cdc-connectors/master/content/quickstart/mongodb-tutorial.html

Hi @ddfeiyu, Whether data is the same depends on the declared primary key.
In the example you provided, we declared the order_id as the logical primary key.
Therefore, all data with the same order_id will be considered the same and will be deduplicated.
If we declare orders._id as logical primary key, then there will be 5 records in ES.
In practical scenarios, logical primary keys are usually declared as unique keys with business semantics.


[Inspector API] runJavascript has additional inputSchema and outputSchema ports

Not sure if this is a bug or not, but I think it might be. As of https://github.com/breadboard-ai/breadboard/pull/2413 we now get three schemas coming through for a runJavascript node: schema, inputSchema, and outputSchema.
This generates some oddness on the front end:

Which I'm currently working around with this:
https://github.com/breadboard-ai/breadboard/blob/main/packages/visual-editor/src/ui/elements/node-info/node-configuration.ts#L743 i.e., only allow a port-spec attached to "schema" otherwise ignore it.
@dglazkov, @aomarks – can one of you advise on what the correct behavior is here?

Ohh yeah, we need to reconcile this. My sense is that we probably should change the node details UI to treat a port with a port-spec as just another port (similar to the LLM Content) rather than its own section. WDYT?


Support butler --userversion-file option

Butler has a feature to set the version number from a file. I would like to use this feature with Project Builder. It's documented here: https://itch.io/docs/butler/pushing.html#specifying-your-own-version-number
There's also a feature to set the version number by a command argument, but I don't think that makes sense to support.
Suggested interface:

Add a field labeled "User Version File" below the "Source Folder" and "Channel" fields. If this is too long then "Version File" is also good.
Give it a button to select a file.
Give it a hint when empty that reads "Leave empty to use default version numbering."
Put something in the documentation reading something like "See the butler manual for the required format of the file."

5035025
Also added "Use Project Version" to upload task, which makes it use application/config/version when enabled. It's useful with my Auto Version addon and I will probably use it in my project.

Also added "Use Project Version" to upload task, which makes it use application/config/version when enabled.

That's even better. Thanks!


Icon not selected by default after uploading

Description of the bug
Not a bug. When I upload an icon to be used, the icon is not selected by default. I need to click on the icon before saving the page.
This might be a bit confusing and I missed this step.
Reproduction steps

Go to page edit
Upload an icon

Expected behavior
Perhaps pre-select the uploaded icon, or make it more clear what is and is not selected.
Screenshot/Video

Version
Branch: 2023.3.0-dev.5.1
Reporter: Tomaz (Test fest)

https://github.com/cortezaproject/corteza/commit/5c31acba5bb07a9b87665e248e60336a2a5107f8

Tested and confirming that this now works as expected. No need for CL since this is a new feature part of 2023.3


Fixed wrong references in project.pbxproj

In the project.pbxproj file:

PRODUCT_BUNDLE_IDENTIFIER used a wrong placeholder
INFOPLIST_FILE used __PROJECT_NAME__Tests, but in fact it is Tests/<file name>

Thanks for finding this. Do you have a recommendation for the cleanest way to update RECIPE.md to correct this?

Thank you, I think this is addressed in https://github.com/fulldecent/swift3-module-template/commit/98d4387f41cfed49eb0cf75dc3f4f99251bd1940


Images look rezzed when using Fast Image on iOS

Fast Image works fine on Android, but the exact same images render rezzed and low quality in iOS. When I switch to the regular Image component the problem goes away, but then I lose the perks of fast image.
Can anyone tell me why this might be happening and if there's a solution for it?
Android:

iOS:

I'm pulling these images in from a remote url that has no file ending and returns base64.

Nothing yet, I've had to remove fast image from the iphone build
altogether. Still hoping to get an answer.
On Mon, Dec 13, 2021, 7:28 AM Pietro-Putelli @.***>
wrote:

same, do you find any solution please? thank you
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DylanVann/react-native-fast-image/issues/739#issuecomment-992477146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUNHA34DJUZMMW2Q66UQF3UQXYJJANCNFSM4TGZ5A7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I’ve tried lots of libraries for caching images in react native, I even
tried to create one in my account, but it seems fast image works really
well apart this issue😕.
Anyway nice to talk with you, my name is Pietro from Italy.
What type of project are you working on?
On Mon, 13 Dec 2021 at 3:50 PM, Bane @.***> wrote:

Nothing yet, I've had to remove fast image from the iphone build
altogether. Still hoping to get an answer.
On Mon, Dec 13, 2021, 7:28 AM Pietro-Putelli @.***>
wrote:

same, do you find any solution please? thank you
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/DylanVann/react-native-fast-image/issues/739#issuecomment-992477146
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABUNHA34DJUZMMW2Q66UQF3UQXYJJANCNFSM4TGZ5A7A
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DylanVann/react-native-fast-image/issues/739#issuecomment-992556426,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APL4WSKIMZ3JOSBMSOBX5ELUQYB43ANCNFSM4TGZ5A7A
.

I’ve tried lots of libraries for caching images in react native, I even
tried to create one in my account, but it seems fast image works really
well apart this issue😕.

I agree, and I've tried changing everything about the images as well.
Changed them from base64 to jpgs, changed the quality and size when the
user takes them. It'd be nice to know why this is happening to us and not
most other users of the library. If fast image had this issue universally
across all ios builds no one would use it.
On Mon, Dec 13, 2021, 8:54 AM Pietro-Putelli @.***>
wrote:

I’ve tried lots of libraries for caching images in react native, I even
tried to create one in my account, but it seems fast image works really
well apart this issue😕.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DylanVann/react-native-fast-image/issues/739#issuecomment-992559582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUNHA6675S7WRQJY7UG4HTUQYCJ3ANCNFSM4TGZ5A7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Having the same issue. Any solution to this?


Add setopt HASH_EXECUTABLES_ONLY

Describe the bug
while using znap source to install plugins like https://github.com/zsh-users/zsh-autosuggestions, an unnecessary file gets created in ~/.local/bin/zsh-autosuggestions.
This is a symlink to zsh-autosuggestions.plugin.zsh - which is not an executable.
Steps To Reproduce

znap uninstall zsh-users/zsh-autosuggestions
znap source zsh-users/zsh-autosuggestions
ls -l ~/.local/bin/zsh-autosuggestions

Expected behavior

~/.local/bin/zsh-autosuggestions is not created
Observed behavior
❯ znap uninstall zsh-users/zsh-autosuggestions
Removing:
~/.local/bin/zsh-autosuggestions
/home/jck/.local/share/zsh-snap/zsh-autosuggestions
zsh-autosuggestions uninstalled.
❯ ls -l ~/.local/bin/zsh-autosuggestions
ls: cannot access '/home/jck/.local/bin/zsh-autosuggestions': No such file or directory
❯ znap source zsh-users/zsh-autosuggestions
Cloning into 'zsh-autosuggestions'...
remote: Enumerating objects: 72, done.
remote: Counting objects: 100% (72/72), done.
remote: Compressing objects: 100% (63/63), done.
remote: Total 72 (delta 9), reused 37 (delta 3), pack-reused 0
Receiving objects: 100% (72/72), 35.52 KiB | 845.00 KiB/s, done.
Resolving deltas: 100% (9/9), done.
❯ ls -l ~/.local/bin/zsh-autosuggestions
lrwxrwxrwx 1 jck jck 82 Jun  4 18:20 /home/jck/.local/bin/zsh-autosuggestions -> /home/jck/.local/share/zsh-snap/zsh-autosuggestions/zsh-autosuggestions.plugin.zsh
❯ cat ~/.local/bin/zsh-autosuggestions
source ${0:A:h}/zsh-autosuggestions.zsh

Environment:

OS: Archlinux
Terminal: kitty
Zsh version: 5.9
Repo version: * main b2365b1 Fix premature return from znap source

Additional context

It's not a bug; it's a feature. source and . both search your path. Thus, it makes sense for source-able files to be in your path (and Znap adds ~/.local/bin to your $path). Additionally, the symlinks are a way for Znap to find plugin files faster.
If non-executable files in your $path are showing up as commands in your completions, add setopt HASH_EXECUTABLES_ONLY to your .zshrc file. I will add this to Znap, too.

Thank you!

If there are any additional drawbacks to having non-executable files in $path, please let me know and I will move them to another place.

Some tools like pipx and marcosnils/bin install executable in ~/.local/bin. I have occasionally run into instances where this conflicts with the corresponding zsh plugin.
For example, I cannot install the https://github.com/ajeetdsouza/zoxide binary into ~/.local/bin and still use znap to install it's zsh plugin.

Thanks for the feedback! I will move them to another location. Sourcing plugins on the command doesn’t really make sense anyway. So, on second thought: No, they don’t need to be in $path after all.

@jck Fixed. 🙂
PS: If you enjoy using my software, please consider sponsoring me. 💝


[api] Send API 404 response in JSON

Closes https://github.com/endoflife-date/endoflife.date/issues/2408

While not strictly required, most API clients will appreciate having a consistent content-type for the API.

Doesn't seem to be working. https://deploy-preview-2425--endoflife-date.netlify.app/assets/404.json is present, but https://deploy-preview-2425--endoflife-date.netlify.app/api/pythonx.json still returns HTML 404.

And functional now: https://deploy-preview-2425--endoflife-date.netlify.app/api/psadasd.json
This will need an update to the openapi spec as well. Will pick that up later, alongside v1 changes.


Remove StringNumber from theme definitions

StringNumber seems to do nothing but mask String, resulting in unquoted strings
having a different color than quoted strings. This resolves the issue by
removing StringNumber.

Can you show me a before and after screenshot?

before:

after:

LGTM


FoundationEssentials: initial pass to add Android support

This adds the necessary guards and includes for the Android modules. While the module does not compile currently due to nullability differences (and in some cases missing declarations), this at least brings the module to a point where we can start working on the errors and differences to create a maintainable codebase for Android.

@swift-ci test

@swift-ci please test


Could not start attach mechanism: No such file or directory

sudo ./profiler.sh -d 15 2381

Could not start attach mechanism: No such file or directory

Cannot figure out what's wrong.

The process was in a docker container.

Right, the profiler and the JVM should have access to each other, which is not usually the case with containers. I've added Troubleshooting section to README. Thank you for the report.


Disable WiFi/BT for qemu_esp32

Problem
WiFi/BT crashes qemu_esp32 when loaded by PlatformManager
Change overview

Disable WiFi/BT for qemu_esp32
Remove duplicated initialize code in src/test_driver/esp32/main/main_app.cpp (dup with PlatformManager::InitChipStack)

Testing
Verified using unit-tests

@sweetymhaiske could you take a look?

fast track: platform specific change approved by a platform owner


OutOfMemory Error

Netty application seems to gradually 'eat up' all memory and eventually out of memory. But Netty LEAK detection doesn't show anything.
This screenshot shows  the heap dump , and the load on product server is pretty low - 50req/sec, with ~40 active connections.

And  found out too many pool chunks in heap. The actual value size of byte array is very small:

Netty version is 4.1.29.Final
Java version is jdk1.8.0_201
Unfortunately I wasn't able to reproduce this issue on test env.  The heap dump size is 4G, so I cannot upload it. Please let me know if you need more info.

Did you try to run with paranoid / advanced leak detection ?

Please re-open with more infos once you can provide these if you still think this is a netty issue


Recognition using EfficientNetB1,EfficientNetB2 and EfficientNetB3

Recognition using EfficientNetB1,EfficientNetB2 and EfficientNetB3

I would like to work on this issue as a part of DWOC 21'

I would like to work on this issue as a part of DWOC 21'

Hi @infiniteoverflow i am thinking of changing this issue a bit by adding different issue for each implementation

Hi @infiniteoverflow i am thinking of changing this issue a bit by adding different issue for each implementation

Okkay , so shall i work on EfficientNet B1 ?

Okkay , so shall i work on EfficientNet B1 ?

yes you can ,assigning you

yes you can ,assigning you


Started sharing SemanticsProperties between the Widget and the RenderObject

This starts sharing memory between Semantics and RenderSemanticsAnnotations.  I noticed a significant decrease in build times in customer: money when I ripped out all the Semantics while testing something else.  I theorized that the performance increase was related to the large memory cost of Semantics where almost all of its 62 instance variables were getting copied to the RenderObject.  In production apps Semantics widgets become ubiquitous and account for a large percentage of the allocations.
I did a bit of testing to see what effect his might have.  I ran a before and after with customer: money where I just clicked on the first button to load the main screen and saw 108MB of allocations go to 85MB, where 210 RenderSemanticsAnnotations where allocated.  That would mean a savings of ~112 KB per RenderSemanticsAnnotations.  That doesn't sound plausible, I'm not sure what Dart is doing under the covers though.  I would have expected something more like (48 removed ivars * ~16 bytes * 210 instances) = 161 KB total.
I did run CPU benchmark tests with build_bench.dart and didn't notice a difference, but it also isn't that representative.  I did try my customer: money benchmark and didn't notice a difference either but that benchmark isn't quite good either.
I don't think it's worth spending more time trying to track down the exact extent of the changes.  The cleanup of this optimization is value enough.  Writing a microbenchmark just for this may not be worth it.  Hopefully I can get the customer:money one showing what we want eventually.
before:

after:

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

test-exempt: code refactor with no semantic change
however if this breaks anything in flutter/tests or google, we will need a migration guide
it might be worth pro-actively searching for potentially broken code in Google that might not be covered by tests.

it might be worth pro-actively searching for potentially broken code in Google that might not be covered by tests.

I saw now references of subclassing RenderSemanticsAnnotations or allocating it.  I think those are things that would potentially break.

Nice clean-up overall!

test-exempt: code refactor with no semantic change

Uhhh isn't this entirely a semantic change?
I'll leave now...


Rspec line filtering

Enables an understanding of RSpec line number filters when specified via spin push. With other test frameworks, line specifiers are ignored.

When I push two specs, like so:
spin push spec/models/user_spec.rb spec/models/user_spec.rb

then Spin runs both of them. I.e. the uniq check on this line doesn't work:
f = files_to_load.select { |f| File.exist?(f.filename) }.uniq.join(SpinFile::PATH_SEPARATOR)

and it doesn't work because you call the uniq on an array of objects, not file names.
Which leads me to a question: Is it really necessary to introduce the SpinFIle class? What does it really add?
I have a similar branch, and after discussing it with Jesse, he mentioned  that we first need a proper way of serializing the info that goes into ARGV. I'm not sure if this pull request brings any new wind to this.


Adding python-pycryptodome Spec to CBL-Mariner

(a) Initial import from OpenSuse Tumbleweed
(b) Adding as run dependency for cassandra medusa.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary
Initial import of python-pycryptodome in CBL-mariner as run dependency for cassandra medusa.
Change Log
(a) Initial import from OpenSuse Tumbleweed
(b) Adding as run dependency for cassandra medusa.
(c) License Verified.
Does this affect the toolchain?
NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX

Test Methodology

Local Build.

Closing this PR.
As pointed out by Olivia, adding dependency on pycryptodomex instead.


Grsecurity playbook assumes bootloader is grub

On my EFI-based macbook, I'm using systemd-boot (ex gummiboot) instead of grub.
I will have to figure out the steps to actually configure/load/boot the grsec kernel on my laptop.
After running spark, I have /etc/mkinitcpio.d/linux-grsec.preset (in addition to linux.preset).
Running the typical {{mkinitcpio -p linux}} only reads the linux.preset.
I probably also have to update/append to /boot/loader/arch/entries.conf to choose grsec kern from the boot menu.

I didn't have to do anything with mkinitcpio. I think the package handles that.
Looking at the wiki, I think you need to check if a grsec was added to $esp/loader/entries/ by the package, then check the default in $esp/loader/loader.conf, and then run bootctl update.
If the package handles the entries for systemd-boot like it did for grub, we probably just need a handler for bootctl update.

I'm closing this since I only have experience with grub. If a systemd-boot user finds that we need a bootctl handler, I'll accept a patch.


ENH: Add a test to check reading large NIfTI image subregions

Add a test to check reading large NIfTI image subregions.
Resolves #3625.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)
[X] Added test (or behavior not changed)

/azp run ITK.macOS

FYI itkNiftiLargeImageRegionReadTest has entered the 4th position in to top 25 of most time consuming tests! At least on the Windows build of commit f423f2d7c7b8f0c33eb2a4bd07561aae63e89ad0. The average ITK test takes less than 0.3 sec, but this one takes more than 9 sec. Unfortunately I have no idea how to speed it up.
Here is the top 25 (out of in total 621 tests) of most time consuming tests:

Test name
Duration (sec)

Test 2483:   itkKullbackLeiblerCompareHistogramImageToImageMetricTest
9.24

Test 2531: itkSyNPointSetRegistrationTest
9.17

Test 1896: itkRegionGrow2DTest
9.06

Test 1274:   itkNiftiLargeImageRegionReadTest
9.05

Test 2460:   itkGaussianExponentialDiffeomorphicTransformParametersAdaptorTest
8.84

Test 665: itkImageFillBufferTest4.1
8.59

Test 2537:   itkTimeVaryingBSplineVelocityFieldImageRegistrationTest
8.16

Test 2271:   itkDemonsImageToImageMetricv4RegistrationTest3
7.88

Test 909:   itkFastMarchingImageFilterTest_wm_multipleSeeds_NoTopo
7.69

Test 2459:   itkBSplineExponentialDiffeomorphicTransformParametersAdaptorTest
7.53

Test 2532:   itkBSplineSyNPointSetRegistrationTest
7.43

Test 2335:   itkDiffeomorphicDemonsRegistrationFilterTest06
7.28

Test 2330:   itkDiffeomorphicDemonsRegistrationFilterTest01
7.18

Test 803:   itkTimeVaryingBSplineVelocityFieldTransformTest
7.15

Test 2270:   itkDemonsImageToImageMetricv4RegistrationTest2
7.11

Test 722:   itkFFTConvolutionImageFilterTest4x5Mean
6.86

Test 723:   itkFFTConvolutionImageFilterTest5x5Mean
6.86

Test 2148:   itkGrayscaleMorphologicalClosingImageFilterTest2
6.74

Test 777:   itkPatchBasedDenoisingImageFilterDefaultTest
6.54

Test 31: vnl_basic_operation_timings
6.16

Test 2150:   itkGrayscaleMorphologicalOpeningImageFilterTest2
6.16

Test 693:   itkRelabelComponentImageFilterTest
6.08

Test 2533:   itkTimeVaryingBSplineVelocityFieldPointSetRegistrationTest
6.07

Test 692:   ConnectedComponentImageFilter.checkerboard_3D
5.81

Test 690:   RelabelComponentImageFilter.big_zero
5.54

Most of that time is presumably spent compressing/decompressing using GZIP in single thread. There is probably not a lot we can do to speed it up, but that should not be a problem.

There is probably not a lot we can do to speed it up, but that should not be a problem.

@dzenanz OK, thanks, I agree. Although I do think it could be a problem when a unit test that takes a lot of time unnecessarily. (Both because it takes resources and it slows down the development process.) With this particular test I think it cannot be done much faster anyway. The size of the image must be > INT_MAX bytes, so it will take some time anyway.


[bug fix] resolve CI intermittent failure issue

Trello card URL:
https://trello.com/c/r2z4Npmo/535-investigate-intermittent-ci-failure
Changes in this PR:
Adds missing elasticsearch tag to failing spec to ensure elasticsearch is correctly configured.

 Investigate intermittent CI failure

@lozette thank you!


Is there any receiver solution/example which decodes AAC format of audio?

Hi,
I successfully applied this library to send H264 Video and use example of H264 receiver code. But I didn't find out any example to receive AAC or other format of audio. Does anyone could have example audio decoding code?

can you please explain a little bit more. I am new to these things.

So did you understand to encoding part of this library?  Try to flow how AAC is decoded in this library and once it get streamed over UDP, you simply reverse the process.

can you provide any example please so I can understand


Loss of focus is observed while navigating from ".NET Framework/ .NET Core " drop-down to "Create Workbook" button by tabbing in "Create a New workbook" window.

Pre-Requisite:
Follow the instructions for installing the app from
https://docs.microsoft.com/en-us/xamarin/tools/workbooks/install?tabs=windows
Steps to Reproduce

Launch Xamarin Workbooks application.
Select the working platform to "Console".
Navigate from ".NET Framework/ .NET Core" drop-down to "Create Workbook" button using Tab.

Expected Behavior
Should be able to set focus on "Create Workbook" button with 1 Tab press from " .NET Framework/ .NET Core" drop-down.
Actual Behavior
Loss of focus is observed while navigating from ".NET Framework/ .NET Core " drop-down to "Create Workbook" button.
Note: (Inspect Observation)
Forward Navigation: Inspect focus remains 2 times on ".NET Framework/.NET Core" drop-down button
Backward Navigation: Inspect focus remains 2 times on "Create Workbook" button.
User Impact
People with visual impairments can become disoriented when keyboard navigation takes focus somewhere unexpected or when they cannot easily find the content surrounding an interactive element.
Environment
Windows : Version 1803 (OS Build : 17134.48)
Xamarin Version : 1.4(master/b3f92f9)
Screenshots:

Inspect Screenshots:

Log File

Please add the following labels to the bug:
A11yMAS
Accessibility
Xamarin-Workbooks-Windows
Wipro
MAS2.4.3

Exemption Approved - 1813


NODE OBJECT ENCODING command: In version 7.0.15, the test fails

Describe the bug
The test object encoding which merged in https://github.com/aws/glide-for-redis/pull/1518/files fails with version 7.0.15 (maybe for more versions).
On this part :
                expect(await client.lpush(list_key, ["1"])).toEqual(1);

                if (versionLessThan7) {
                    expect(await client.object_encoding(list_key)).toEqual(
                        "quicklist",
                    );
                } else {
                    expect(await client.object_encoding(list_key)).toEqual(
                        "listpack",
                    );
                }

With a list length equal to one (small list) and a version of redis greater than 7 (the version is 7.0.15), I'm getting "quicklist" instead of "listpack".
It is not clear from documentation when the quicklist should be returned:
* Lists can be encoded as:

* linkedlist, simple list encoding. No longer used, an old list encoding.
* ziplist, Redis <= 6.2, a space-efficient encoding used for small lists.
* listpack, Redis >= 7.0, a space-efficient encoding used for small lists.
* quicklist, encoded as linkedlist of ziplists or listpacks.

Expected Behavior
Tests passed for all redis versions
Current Behavior
test object encoding fails:

Reproduction Steps

install redis server 7.0.15
run object encoding node test : npm run test -- --testNamePattern="object encoding"

Possible Solution
No response
Additional Information/Context
No response
Client version used
redis-cli 7.2.5
Redis Version
7.0.15
OS
ubuntu
Language
TypeScript
Language Version
Node v18.19.1
Cluster information
No response
Logs
No response
Other information
No response

@yipin-chen Please take care

I have been working on this issue. Yes, the documentation is not clear, and here are my test results:

6.2.14: quicklist
7.0.15: quicklist
latest (7.2): listpack

I don't have the authority to assign this issue to myself. Can someone please assign this bug to me?


[FLINK-13477][core] Add memory-overhead-ratio conf for containers

What is the purpose of the change
Currently, the -XX:MaxDirectMemorySize parameter is set as:
MaxDirectMemorySize = containerMemoryMB - heapSizeMB
However as explained at
https://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html,
MaxDirectMemorySize only sets the maximum amount of memory that can be
used for direct buffers, thus the amount of off-heap memory used can be
greater than that value, leading to the sum of heap + off-heap memory used being
higher than the allocated container memory and the container being killed by Yarn
or Mesos for that reason.
In addition, users might want to allocate off-heap memory through native
code, in which case they will want to keep some of the container memory
free and unallocated by Flink.
This PR introduces the containerized.memory-overhead-ratio config to allow keeping some of the container memory free. With this change, the heap and direct memory sizes are computed as fractions of the usable memory, with usableMemoryMB = containerMemoryMB * (1 - overheadRatio) instead of on the full container memory. The overhead ratio default value is 0 to keep the current behavior.
Brief change log

Add containerized.memory-overhead-ratio config to allow keeping some of the container memory free (default is 0 to keep the current behavior)

Verifying this change
This change added tests and can be verified as follows:

Added testUsableMemory unit test to ensure memory-overhead-ratio is honored in ContainerTaskManagerParametersTest.java

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs

Thanks for creating this PR @BenoitHanotte. Sorry for the late response. In the meantime, the community has completed FLIP-49 and, hence, this change is no longer required. Closing this PR now.


fix: avoid overflow when counting scalars (PROOF-906)

Rationale for this change
Refactors the code so that the code will still work if the number of bits used per multi-exponentiation output can't fit into a 32-bit integer.
What changes are included in this PR?

Minor adjustments to code that counts the number of scalars per output.

Are these changes tested?
Yes. I added test cases.

:tada: This PR is included in version 3.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


我为啥打不开https://ke.smartloli.org/这个页面

我为啥打不开https://ke.smartloli.org/　这个页面,你们可以吗

@mmmboge Sometimes because network problems need to be accessed by VPN.

@smartloli is there any other way to get the installer guide？ because i can't use VPN in the company

@mmmboge Please visit wiki.


Fix exception when entity attributes are missing

#696

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 93.07%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
415

Relevant Lines:
435

💛  - Coveralls