LU Build environment default

Describe the bug
Referencing issue here https://github.com/microsoft/BotFramework-Composer/issues/5448

The older runtime templates include the environment value set to "composer" by default.
A decision needs to be made to add this value while the template  scaffolding (new runtime) or at Composer bot load time we check for this value and update it empty. Other considerations to be made is how does this value get handled in CI/CD env outside context of Composer
Version
main

Closing this ticket as a fix was made here
bug: Update luis:environment setting value to 'composer' by peterinnesmsft · Pull Request #669 · microsoft/botframework-components (github.com)


Build fails: No module named peachpy.x86_64

I'm trying to build it on FreeBSD and it fails:
[20/45] cd /usr/ports/science/nnpack/work/.build && PYTHONPATH=/usr/ports/science/nnpack/work/NNPACK-c039579/deps/six:/usr/ports/science/nnpack/work/NNPACK-c039579/deps/enum: /usr/local/bin/python2.7 -m peachpy.x86_64 -mabi=sysv -g4 -mimage-format=elf -I/usr/ports/science/nnpack/work/NNPACK-c039579/src -I/usr/ports/science/nnpack/work/NNPACK-c039579/src/x86_64-fma -I/usr/local/include -o /usr/ports/science/nnpack/work/.build/src/x86_64-fma/2d-fourier-8x8.py.o /usr/ports/science/nnpack/work/NNPACK-c039579/src/x86_64-fma/2d-fourier-8x8.py
FAILED: src/x86_64-fma/2d-fourier-8x8.py.o
cd /usr/ports/science/nnpack/work/.build && PYTHONPATH=/usr/ports/science/nnpack/work/NNPACK-c039579/deps/six:/usr/ports/science/nnpack/work/NNPACK-c039579/deps/enum: /usr/local/bin/python2.7 -m peachpy.x86_64 -mabi=sysv -g4 -mimage-format=elf -I/usr/ports/science/nnpack/work/NNPACK-c039579/src -I/usr/ports/science/nnpack/work/NNPACK-c039579/src/x86_64-fma -I/usr/local/include -o /usr/ports/science/nnpack/work/.build/src/x86_64-fma/2d-fourier-8x8.py.o /usr/ports/science/nnpack/work/NNPACK-c039579/src/x86_64-fma/2d-fourier-8x8.py
/usr/local/bin/python2.7: No module named peachpy.x86_64
ninja: build stopped: subcommand failed.

How do you build it? Do you use CMake?

I use cmake w/in the FreeBSD ports framework.

NNPACK CMake file should download PeachPy and add it to PYTHONPATH, see here, but I see only PYTHONPATH=/usr/ports/science/nnpack/work/NNPACK-c039579/deps/six:/usr/ports/science/nnpack/work/NNPACK-c039579/deps/enum: in your logs. Do you pass -DPYTHON_PEACHPY_SOURCE_DIR to CMake (you shouldn't)? Please paste a complete log, including the commands you type.

PeachPy package is pre-installed, insecure downloads aren't allowed during the package builds.

Did you follow installation instructions in PeachPy README?

yes, setup.py does all the work there.

Try a simple test, e.g. python -c "from peachpy.x86_64 import * ; ADD(eax, 5).encode()"

Actually, /usr/local/bin/python2.7 -c "from peachpy.x86_64 import * ; ADD(eax, 5).encode()" in your case, because this is the Python CMake finds.

py27-peachpy installs x64 and x86 architectures.
$ python2.7 -c "from peachpy.x64 import * ; ADD(eax, 5).encode()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/peachpy/x64.py", line 8939, in ADD
    origin = inspect.stack() if Function.get_current().collect_origin else None
  File "/usr/local/lib/python2.7/site-packages/peachpy/x64.py", line 625, in get_current
    raise ValueError('No function is active')
ValueError: No function is active

$ python2.7 -c "from peachpy.x86 import * ; ADD(eax, 5).encode()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/peachpy/x86.py", line 2945, in ADD
    current_function.add_instruction(ArithmeticInstruction('ADD', Operand(destination), Operand(source)))
AttributeError: 'NoneType' object has no attribute 'add_instruction'

DO NOT install PeachPy from PyPI. It is an old version, incompatible with NNPACK. Follow the instructions in PeachPy README

The new version of PeachPy fixed this, thanks!


fix worksheets error for version 4 notebooks

Please consider this simple backwards-compatible fix for the stacktrace from running ruipy on version 4 notebooks.

I'll think about this. Could you also add a v4 notebook for testing?

From what I can tell, this actually doesn't fix the problem. How were you able to get this to work?

Thanks for your patch @kbroughton. Unfortunately, I have chosen not to accept it as I did not find that this fixed the problem at hand.
It seems the issues was more due to the HTML being written out than any earlier part of the run.
If it turns out I have mistaken what you are trying to solve here, please let me know and we can revisit it.


ue4 integration

I'm trying to use the HSM with ue4, however enabling RTTI in ue4 makes packagingimpossible, but when I don't enable it I can't seem to get it to work because of the RTTI.

Hi there,
If you disable RTTI, you'll need to add the DEFINE_HSM_STATE() macros in each of your states to inject the custom RTTI info needed by hsm. Check out the info in the documentation:
https://github.com/amaiorano/hsm/wiki/Chapter-1.-Getting-Started#rtti
If you haven't already, I highly recommend reading the doc. Let me know if that works for you! I've shipped UE4 multiple games that use HSM, so it should work out just fine.

Hi, this is what I am doing right now (just leaving 1 state in there) and the baseState in there in case I happen to be using the wrong syntax;
struct MyStates
{
struct BaseState : hsm::StateWithOwner
{
DEFINE_HSM_STATE(BaseState);
};
struct Grabbed : BaseState
{
DEFINE_HSM_STATE(Grabbed);
virtual hsm::Transition GetTransition()
{
if (!Owner().m_pBlackboard->GetValueAsBool(ISGRABBED))
return hsm::SiblingTransition();
		return hsm::NoTransition();
	}
	virtual void OnEnter()
	{
		Owner().m_bShouldProcess = true;
		Owner().m_Animstate = EAnimEnum::Grabbed;
	}
};

};
this throws me all of these erors:
Severity	Code	Description	Project	File	Line	Suppression State
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error (active)	E0135	namespace "hsm" has no member "StateTypeIdStorage"	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	33
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	38
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	69
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	108
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	140
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	164
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	196
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	217
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	234
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	250
Error	C2039	'StateTypeIdStorage': is not a member of 'hsm'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
Error	C2146	syntax error: missing ';' before identifier 'sStateTypeId'	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
Error	C3861	'sStateTypeId': identifier not found	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
Error	C2065	'sStateTypeId': undeclared identifier	FluffyFactory	C:\perf\Grp_Fluffy\Dev\FluffyFactory\Source\FluffyFactory\FluffyCharacter.cpp	266
which are basically the same for every state I Define
I am currently using the latest Release Build I could find on here.

So I downloaded the second latest release (1.5) and had to comment the line 	//static_assert(std::is_convertible<TargetState, State>::value, "TargetState must derive from hsm::State");
and add this define at the start to make it build
#define HSM_CPP_RTTI 0
Seems to me there must be something missing in the latest release or the syntax of something has changed which I am not aware off.

So I downloaded the second latest release (1.5) and had to comment the line //static_assert(std::is_convertible<TargetState, State>::value, "TargetState must derive from hsm::State");

This assert is important, you should not remove it. If you're triggering it, it means you've probably added a DEFINE_HSM_STATE somewhere you shouldn't. This macro should only really be added to the actual states you transition to, not to base classes for your states. I noticed in the code you pasted above that you had added this macro to your BaseState, which you shouldn't be doing (see this example: https://github.com/amaiorano/hsm/blob/master/samples/hsm_book_samples/source/ch3/drawing_hsms.cpp).

and add this define at the start to make it build
#define HSM_CPP_RTTI 0

This is correct. You are supposed to define this to 0 to disable C++ RTTI, and make use of the custom RTTI. I assume you had already done this even before downgrading.

Seems to me there must be something missing in the latest release or the syntax of something has changed which I am not aware off.

I think you found a bug in the latest version related to custom RTTI. When I get the chance, I'll take a look and see what's up. For now, using 1.5 should be perfectly fine.


refactor handling llama2 formatting

Do you have a plan to add test cases like llama2_then_openai?

At some point, yes. Tests for local llms are tricky/messy - a separate model server needs to be spun up. We can see how other libs are doing these tests.


rename and unify setting variable names

fixes #29
Not sure if the doc-strings actually work - any ideas to clearly mark the deprecation?
I also played with the idea of printing a warning to stderr or so, but that is a bit too much I think.

One note, this is a semver-minor change (it introduces new fields not present in older versions) so the next version would be 3.2.0.

I made the changes as requested.

Perfect, thanks!


Ensure that MSBuildProjectSystem doesn't add project references twice

Fixes #795
It's possible for project references to appear twice within an MSBuild project after execution:

As a ProjectReference item
As a ReferencePath item with ReferenceSourceTarget="ProjectReference"

This change makes sure that ReferencePath items that were sourced from project references aren't added. We just use the project references, which is a better experience at designtime when the project is built.
Note: There was code that used to do this, but it was unintentionally removed in a refactoring a few months ago (by me -- oops!): https://github.com/OmniSharp/omnisharp-roslyn/commit/ef4b3838d39666ed5ca9780ea133bfdc08ff5844.

have you thought of publishing all this MSBuild-related code as a nuget package?
For example I would like to use something like that in other projects - being able to go from csproj to everything needed to create a CSharpCompilation/describing the project (some kind of a replacement for https://www.nuget.org/packages/Microsoft.DotNet.ProjectModel)

have you thought of publishing all this MSBuild-related code as a nuget package?

Probably not. We already have that in Roslyn with the MSBuildProjectLoader. It just doesn't work with the latest MSBuild and isn't portable. However, it's looking likely that I'll be called upon to fix that.

oh that's what I've been missing. Is it part of any of the Roslyn nuget packages?

Sure, but it's only available on desktop: https://www.nuget.org/packages/Microsoft.CodeAnalysis.Workspaces.Common/.
The API sits next to MSBuildWorkspace.

thanks!


Open DB Project Does Not Integrate with Source Control Provider

Azure Data Studio Version:
Version: 1.20.0-insider (user setup)
Commit: 95107f1f611df05f85e1cc7122f088f4d9cc6aec
Date: 2020-06-18T05:34:11.799Z
VS Code: 1.46.0
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Steps to Reproduce:

Open established sqlproj (in folder initialized for git)
Unless user also opens the project in files area, ADS source control does not parse changes

Following #10974 should the folder also be opened to tie into source control functionality?

Moving to ADO


⚠ Bofrost.hr has degraded performance

In d2ed256, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 11423 ms

Resolved: Bofrost.hr performance has improved in dbd9789 after 10 minutes.


This is an update on the validations.py python scripts

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

This update was on validations.py 👍 :).


Nested routes not marked as active

Reproduction
https://codesandbox.io/s/nested-views-broken-active-behaviour-yvcshl
Steps to reproduce the bug

Create a route with children routes nested below the parent path, like so:{
  path: "/foo",
  component: () => import("parent-component-with-router-view.vue")
  children: [
    { path: "bar", component: () => import("child-component-bar.vue") },
    { path: "baz", component: () => import("child-component-baz.vue") },
  ]
}

Add router-link instances to the page:<router-link to="/foo">/foo</router-link>
<router-link to="/foo/bar">/foo/bar</router-link>
<router-link to="/foo/baz">/foo/baz</router-link>

Click one of the children links
Witness the parent link not receiving active state

Expected behavior
Parent links should be marked as active if a child route is active and they do not have an exact prop. I understand this has changed in Vue router 4, but my routes are properly nested.
Actual behavior
The parent route never receives an active state. I have tried directly referencing components, reducing the parent component to a router-view, adding route names, redirects, slashes, what have you. This is simply not working as stated in the documentation.
Additional information
I modified the example from the Vue documentation, which used a route parameter in the parent URL, which apparently is working. This has to work without parameters, too, however. In my specific situation, I have the following routes (indentation indicates children):

"/team"

"users"

""
"invite"
":id"
":id/edit"

"groups"

""
"create"
":id"
":id/edit"

For all of these, I'd expect the "/team" navigation item to be active. I created the router configuration as described in the documentation, but it doesn't work.

Your repro isn’t using the code sample you are referring to. It’s working as expected given the  parameter is repeated across routes rather than be a single route record with children. Are you sure you are not missing something?

Apparently so, although I can't figure out what it is. Sorry for bothering!


Add ack as a synonym for acknowledge in Zulip

When running through my list of notifications, it'd be nice if I could just type ack 1 versus acknowledge 1, since the second is a bit of a handful to type.

Thanks!

(Should deploy in 5-10 minutes or so).


Remove home page / landing page from crawler

Description
This PR includes the following:

Removes the redundant code in the crawler which crawled the home page only

Fixes #CDD-2337

Type of change
Please select the options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests at the right levels to prove my change is effective
[ ] I have added screenshots or screen grabs where appropriate
[ ] I have added docstrings in the correct style (google)

The original spike for this was about seeing if we could get away with not crawling the landing page in the redis cache and just relying on the upstream CF cache. Turns out that was already happening!


Schema.hs is not picked up by Travis

/home/travis/build/gagandeepb/Frames-beam/src/UsageExample.hs:36:1: error:
    Could not find module ‘Schema’
    Use -v to see a list of the files searched for.
   |
36 | import           Schema
   | ^^^^^^^^^^^^^^^^^^^^^^^

Done.


Retry curl on Travis and AppVeyor

I've seen curl failure due to temporary network error on AppVeyor.
This pull request adds --retry 5 to config files for Travis and AppVeyor.
No code change in XSpec core.

This pull request derives from #262. So needs to be handled after that.

This pull request just improves the setup of the test scripts environment. It doesn't touch the XSpec code. None of the existing tests are modified.
The tests are working fine with this change on Travis and AppVeyor.
This pull request is supposed to reduce temporary errors on future pending pull requests (towards #235 in particular).

So I think this pull request can be merged (after #263) safely without reviewing details, or I'd like to merge this by myself in a few days.


Ranges Do Not Work As Expected

While writing some emojicode I ran into some unexpected behaviors with ranges of steps not equal to 1.
🏁 🍇
    🔂 y 🆕⏩ 0 5 2❗ 🍇
        😀 🔡 y ❗❗
    🍉
🍉

This is a simple loop of printing the values in the range. I expected 3 digits. "0 2 4"
I only see displayed 2, "0 2"
I checked to see if this was only an interaction with loops but this code
😀 🔡📏🆕⏩ 0 5 2❗❓❗❗
returns length 2, rather than the expected 3.
In other languages such as python the range function returns different results
>>> list(range(0, 5, 2))
[0, 2, 4]

Ive tried with other numbers and I also see similar issues. I am on the most recent version of emojicode.
It must be an off by 1 error somewhere but I have not gone into the source code to investigate it.

This is indeed a bug in 📏 as the result of the division needs to be ceiled actually:
https://github.com/emojicode/emojicode/blob/master/s/⏩.🍇#L51


Use venv for Python development

Addresses https://github.com/replicate/replicate/issues/424

Not sure why CI / Test (Python) (3.6, ubuntu-20.04) is failing. The error seems to be No matching distribution found for tensorflow-cpu==2.4.0 (from -r requirements-test.txt (line 4)).

Yeah, super weird isn't it. I restarted the test a couple of times so it's a real failure.
Maybe it's using a different version of pip because it's inside a virtualenv? I'm trying to figure out what might be different in this installation.

Thanks so much for the contribution btw! I'll do some poking around later today if I get time...

@bfirsh Cool, thanks for looking into it. Let me know if I can help.

@bfirsh it looks like the pip version is the culprit - https://github.com/tensorflow/tensorflow/issues/39130#issuecomment-623335820

Hah, oh god. Nice find. 🙄

Several times during this project we've thought "ok we need to burn all Python packaging to the ground and create a new packaging system" but then reminded ourselves we should keep our eyes on the ball, haha. This is also why most of the codebase is in Go -- so we don't have to deal with Python's godawful packaging/dependencies. cc @dscape

Yeah, sometimes with issues like this, it can be quite frustrating.

Hey @bfirsh, let me know if this is good to go or if there are any changes required.

Hey @bfirsh, let me know if this is good to go or if there are any changes required.

Thanks so much @hemildesai! We're just in the process of shipping a release right now so I don't want to change up the development environment while we do that. But, as soon as we've shipped it, this is first thing I'm taking a look at. :)

Thanks so much @hemildesai! We're just in the process of shipping a release right now so I don't want to change up the development environment while we do that. But, as soon as we've shipped it, this is first thing I'm taking a look at. :)

Sorry for being slow here -- I had a quick look at this the other day. I think it's a bit confusing that the Python library is installed locally in a virtualenv, but the binary is still installed globally. That'll make it easy to get into a situation where different versions installed in two different places. I wonder if we can install the binary inside the venv in development?

@bfirsh Sure. Can you point me to where the binary is installed so that I can change it to be installed in the venv?


pin-b is not a valid tailwind class

https://github.com/dirkolbrich/hugo-theme-tailwindcss-starter/blob/663fd9bf56c095d12103c603c9f8dcbc64277125/layouts/partials/footer.html#L1

Therefore I guess it's just a typo?

Good catch. But it's not a typo. pin-bwas a valid positioning class in tailwindcss < v0.x. I somehow missed the change in v1.x. Will add a fix.


Quota blocks scaling to 5 build agents

Just fixed some syntax errors in quota.yaml and after I enacted the quota the build agent can't scale past 1.
Should either increase the quota or reduce the suggested number of replicas (I'm not sure the quota is actually necessary at all, though you could mention it as a possibility)

No longer using quota in this tutorial.


Improvement: Add option to change F1 score from micro to macro.

https://github.com/telekom/nlu-bridge/blob/aa7705d0167ca111491b9b6afdc470a21e4f4c0b/nlubridge/vendors/vendors.py#L52
PS: I personaly would prefer F1 macro.

Why I like F1 macro and dislike F1 micro – a short discussion:
For an unbalanced binary classification we use the F1 score of the minority class instead of accuracy for example. The reason is because you do not want to give too much influence to the true negatives.
So what happens when I have an unbalanced multi class problem. F1 score can not be used anymore because F1 is only for binary classification. You can calculate multiple F1 scores and then average them. That is why there is F1 micro and F1 macro.
But you can average in 2 different ways:
micro counts globally by counting the total true positives, false negatives and false positives and then calculate F1 micro from that
macro calculates F1 for each label and then builds the unweighted mean
So what is the difference here? If the classifier works very bad on a minority class the influence of this bad classification is very low if you use the micro F1 (because you first add up and then calculate F1 once). If you use the F1 macro the bad minority class performance is wighted as high as all other classifications (because of “unweighted mean”). So the reason why I do not like using F1 micro for unbalanced multi class problems is almost the same as I do not use accuracy.

Thanks for bringing it up! Just merged your changes.


Added env usage hint for bash and fish shells

This is an attempt at the usage hint mentioned in #877
Signed-off-by: Tom Barlow<EMAIL_ADDRESS>

@ehazlett Let me know what you think of this :smile:

@ehazlett Let me know what you think :smile:

Nice.

Great, thanks for the feedback @ehazlett -- I'll get those changes done now.

@ehazlett How's this?

LGTM


Made initial changes for query parameterization

Modeled escaping methods after Python version. I do have some reservations about the way strings are escaped/some things I'd like to clarify, but overall I think this is a good starting point. I'll add some more test cases over the next day, but apparently Jesse has a docker container that is designed to test malformed queries, so I'll only do more work on that end after syncing with him.

and given the fact query parametrization will be supported by the service side at some point in near future

@moderakh I didn't know that it's going to be supported by backend. Where can I find more information about this?

Closing this as we are just going to wait for it to be supported on server side.


<EMAIL_ADDRESS>fails with an unhandled error during update phase when executing within AWS CodeBuild

Error message:

error: an unhandled error occurred: Program exited with non-zero exit code: 1

Running the exact same pulumi script in the following environments gives these results:

Machine
OS
@pulumi/aws Version
Result

MacBook Pro
macOS 10.14.2
0.16.9
✅

AWS CodeBuild
image aws/codebuild/nodejs:8.11.0
0.16.8
✅

AWS CodeBuild
image aws/codebuild/nodejs:8:11:0
0.16.9
❌

The last resource printed to the console before the unhandled error occurs is consistently an aws:waf:WebAcl. So there might be a problem with the latest AWS provider plugin when it is interacting with a WebAcl resource while running on Linux (the CodeBuild image mentioned above is based on ubuntu:14.04.5).

Hi @robertbullen! Sorry for the delay in replying here. Is this still occurring with the latest versions (v0.18.3)? If so, do you have any more information about how you are using the WebAcl resource in your program to help diagnose?

Hi @robertbullen,
I am going to close this out - it's been idle for a while now. If you are still having the same issue, please do recomment on the issue and we can reopen it
Thanks again
Paul


Issues with VoiceStates on startup

VoiceState#channel is always null/uncached when the bot is started

one more thing the embeds still only work with snake_case

one more thing the embeds still only work with snake_case

Fixed already in the dev branch, not in NPM yet

I guess in #createInteractionResponse it should return an empty array instead of undefined if there are no embeds/components

It doesn't make a difference

ik but everywhere it's an empty array so yeah

VoiceState#channel is always null/uncached when the bot is started

anything about this?

Fixed in a2b9f54e349f943d096631a6ed5f5098457e28bc

Fixed in a2b9f54

There is a console.log on the top, remove it


Dependency issues with postcss-preset-env

The postcss-preset-env package hasn't released a new version in 2 years and is starting to cause dependency issues. For example, this warning shows up when using the latest version of tailwindcss since the autoprefixer versions conflict.
<EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>
I recommend removing postcss-present-env from the default install and including the plugins directly. For example, add autoprefixer and postcss-nesting packages if that's what is used by the app.
This results in fewer npm dependencies and a faster postcss build because it is only doing what the app needs.

Happy to take a patch that just does autoprefixer and css nesting as a smaller default area 👍


how to add dependencies ?

Hi,
Some cpp files are created by swig.
howto add these files as dependencies , since they are generated by swig .
Regards,
S.Ancelot

This request is out of scope for this project, but a few things I'd suggest:
Swig generates source files that need to be linked into your module. Sources can be added to a list prior to calling add_nodejs_module, e.g:
list(APPEND MY_SOURCES
  module.c
  generated_file_1.h
  generated_file_1.cpp
  generated_file_2.h
  generated_file_2.cpp
)
add_nodejs_module(${PROJECT_NAME} ${MY_SOURCES})

From what I can see, cmake provides two built-in modules for swig FindSwig.cmake and UseSwig.cmake. Annoyingly, these modules provide functions attempt to build the entire library all at once. These functions serve the same role as add_nodejs_module; you won't be able to use them together. What you need is the list of generated sources that this module produces, and then pass this list into add_nodejs_module as sources. However, I don't know if you can hack around the built-in modules, as they don't seem to support javascript as a language target (which makes sense, its a relatively new target for swig).
I wish I could be more helpful, but most folks don't use swig when writing node bindings, they manually write bindings by hand.
https://cmake.org/cmake/help/v3.5/module/FindSWIG.html
https://cmake.org/cmake/help/v3.5/module/UseSWIG.html
https://github.com/Kitware/CMake/blob/master/Modules/FindSWIG.cmake
https://github.com/Kitware/CMake/blob/master/Modules/UseSWIG.cmake
P.S. In that last link, the function SWIG_ADD_SOURCE_TO_MODULE looks like almost what you want to do (you'd call it with the same target as add_nodejs_module, that is, the first argument you pass to my function and each *.i file you want to generate), but the context it's called in does a lot more than just call it, so you'd have to figure out what else needs to be replicated. Also, I don't quite remember how CMake scopes modules right now. You may not even be able to call that function from your own file ~YMMV.


Task: Implement Find Properties filter option for property market values

Describe the task
Currently, there is not an option for users to filter vacant properties by estimated market value. We will implement a filter option in which users can 1) input their own custom value for minimum and maximum entry fields and/or 2) select from a dropdown of provided market values for the minimum and maximum entry fields.
Acceptance Criteria

Users can input custom values
Can select from a dropdown of pre-defined market values
Can clear the entry field by clicking "Clear"
Can confirm their selections by clicking "Done"

Additional context

Figma link

@bacitracin quick question about the input field, would we need a visual label here? Would the "Market Value" act as the label or do you think it would be beneficial to include a visual label for the min value and max value input fields? Maybe just a floating label can work. For example, this NEXTUI input: https://nextui.org/docs/components/input#usage

@Amberroseweeks Good question! A visible label is definitely necessary here for Min Value & Max Value. Once you pick a value the Min Value/ Max Value text disappears. It being min/max from left to right seems obvious to us but adding the label will help with cognitive load, and if screenreader or zoomtext users get disoriented.
Ideally the label would be outside of the input and not move around, but if you use a floating label and 1) it's always visible 2) sounds decent on a screenreader it should be fine. In the first example on that page it reads out as "Email email edit your email edit text email" which you'd want to avoid.


[metrics control] Show error message when chart contains bad data

Is your feature request related to a problem? Please describe.
This feature request is related to https://github.com/apache/superset/pull/17201.
Describe the solution you'd like
When user creates a chart, they can pick one or more metrics from dataset. With time passing by, or same dataset shared with different groups of users, dataset itself may be changed. In airbnb we found many cases that some metrics used by certain charts, which are not aware by other users, are deleted unintentionally. Later when a user open an old chart which contains these metrics, the whole chart is kind of broken. https://github.com/apache/superset/pull/17201 fixed UI issue. It unblock user to see the chart with valid metrics. But the invalid metric data is still in the Slice entity.
Ideally, Superset should let user know which piece of data is not valid anymore, and ask user to take action to clean up this bad data
Describe alternatives you've considered
https://github.com/apache/superset/pull/17201 fixed UI issue so that unblock user to see the chart with valid metrics.
Additional context
This issue has been in Superset for a long time: https://github.com/apache/superset/issues/16719, https://github.com/apache/superset/issues/14034.
cc @kgabryje @junlincc

@villebro thanks for the looking this issue.
there are 2 places we can prevent this issue:

from source: we should check which metrics are in use when attempting to delete them. I think this is you suggested.
from target: when bad data already existed in superset data, how Superset should handle the error. this is what i suggested.

I feel both places need some work to fix. From technical point of view, fix 1 is harder, given some companies (like airbnb) already had huge number of charts and dataset.

This issue has gone stale so I'll reluctantly close it, but it's also worth pointing out that @kasiazjc put a whole lot of work into surfacing relationships between charts/dashboards, and there's been some design work here on dataset relationships too. Maybe @kasiazjc can speak to what's left to implement in this effort (if anything) and we can either (a) reopen this issue, (b) open a new Discussion thread if warranted, or (c) just leave this closed and let nature take its course.

We actually have implemented all of the dashboard x charts features for now, but we didn't really touch the dataset part. It would probably be a stretch to include it in the dataset flow redesign or CRUD redesign which is happening, BUT for the visibility and consideration I'm tagging @khallon


argument parsing issues

argparse struggles to determine if README.md is an additional ignore pattern or a path... maybe -i should be comma-separated or you have to specify multiple -i arguments?
Example:
➜  test_repo git:(main)  wurl-check -i excluded_domains README.md
usage: wurl-check [-h] [-t TIMEOUT] [-c MAX_CONNECTIONS] [-k MAX_KEEPALIVE_CONNECTIONS]
                  [-i IGNORE [IGNORE ...]] [-a ALLOW [ALLOW ...]] [--version]
                  paths [paths ...]
wurl-check: error: the following arguments are required: paths

wurl-check README.md bad.txt repositories.json test.py  -i excluded_domain yahoo.com  detects yahoo.com as an additional file I think (the output only mentions one ignored).

wurl-check README.md bad.txt repositories.json test.py -i excluded_domain yahoo.com detects yahoo.com as an additional file I think

No, I don't think so. It correctly adds yahoo.com to the ignore list.

wurl-check README.md bad.txt repositories.json test.py -i excluded_domain yahoo.com detects yahoo.com as an additional file I think

No, I don't think so. It correctly adds yahoo.com to the ignore list.

You're right... I was thinking it was stating what was configured via arguments (not what was actually ignored in the run). I was missing a bad yahoo.com URL in my test file.
Testing on latest master 975e5c69773e465aee7980f1ec6b9e9737d078ac, the provided usage doesn't behave as expected though (the arguments must be specified in a different order - path first vs last). I guess maybe change the usage to specify path first (if having to specify multiple -i arguments is painful)?
(venv) ➜  deadlink git:(main) ✗  deadlink-check -i yahoo.com README.md
usage: deadlink-check [-h] [-t TIMEOUT] [-c MAX_CONNECTIONS] [-k MAX_KEEPALIVE_CONNECTIONS]
                      [-a ALLOW_URLS [ALLOW_URLS ...]] [-i IGNORE_URLS [IGNORE_URLS ...]]
                      [-af ALLOW_FILES [ALLOW_FILES ...]] [-if IGNORE_FILES [IGNORE_FILES ...]] [--version]
                      paths [paths ...]
deadlink-check: error: the following arguments are required: paths

deadlink-check README.md -i yahoo.com works as expected.
pre-commit (if you ever want to use deadlink as a pre-commit hook) will have issues with that ordering though. I believe pre-commit expects to be able to append the files to operate on at the end of the command (see https://pre-commit.com/#new-hooks, the entry parameter).

I definitely want to keep the syntax
deadlink-check filename1

so there's probably not much we can change here.

I definitely want to keep the syntax
deadlink-check filename1

so there's probably not much we can change here.

Yeah, that's possible. The issue is where the options like -i go (not the filenames).
OK: deadlink-check -i excluded.com filename1
PROBLEMATIC: deadlink-check filename1 -i excluded.com

Feel free to PR if you see a solution for this.


fix README missing shell command in docker-compose exec calls.

Your pull requests does 2 things, one is duplicate of https://github.com/tiangolo/full-stack-fastapi-postgresql/pull/348

Thanks! This was handled in another PR, so I'll now close this one. But thanks for the effort! :coffee:


Main into develop for v0.5.0

Merge main branch back into develop

This PR is a part of the release of v0.5.0
Merge changes made as part of the release candidate into develop.

Created #558 to update the files.  Then I'll delete the release and run it again.

@ltaylor16 -- did you update the version to 0.5.0?
I looked at AxomVersion.cmake and didn't see the change
See: https://github.com/LLNL/axom/blob/main/src/cmake/AxomVersion.cmake
I think we also have to update the RELEASE file:
https://github.com/LLNL/axom/blob/main/RELEASE
If not, I think you'll need to create a PR into main to fix this.
The process is described here: https://github.com/LLNL/axom/blob/8208dfaa4267e2cab6fb673151c3064a2cc9837a/src/docs/sphinx/dev_guide/release.rst#2-issue-a-pull-request
Sorry I missed it before.

Also the

@ltaylor16 -- did you update the version to 0.5.0?
I looked at AxomVersion.cmake and didn't see the change
See: https://github.com/LLNL/axom/blob/main/src/cmake/AxomVersion.cmake
I think we also have to update the RELEASE file:
https://github.com/LLNL/axom/blob/main/RELEASE
If not, I think you'll need to create a PR into main to fix this.
The process is described here: https://github.com/LLNL/axom/blob/8208dfaa4267e2cab6fb673151c3064a2cc9837a/src/docs/sphinx/dev_guide/release.rst#2-issue-a-pull-request
Sorry I missed it before.

Also the

Also the what?
I've merged #558, deleted the release, deleted the v0.5.0 tag, created a new release (which creates v0.5.0 tag), created tar files and uploaded to release.  I think we're all set.

sorry! i misclicked thanks again!


formulae: check for added formulae in build_bottle?

Fixes skipping bottle builds for PRs that add a formula and switch other
formulae to depend on the added formula.
Let's also make this skipping behaviour more prominent so that it's more
obvious when it's happening.

==> Running Formulae#formula!(gst-plugins-good)
Error: undefined method `Annotation' for GitHub::Actions:Module


Add typofixer extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks for your contribution 🔥
What's the difference between this and Punto Switcher from the store?

What's the difference between this and Punto Switcher from the store?

Typofixer:

supports other keyboard layouts (it's main difference)
has layouts settings
can convert each word separately
has a more correct algorithm for encoding detection

Basically, they do the same, right? Another solution would be to let this one supersede the other one so we don't end up with multiple extensions doing the same 🙂

Sounds great. I can improve typofixer to support a different layout.

What do you think @red-avtovo since you're the author of Punto 🙂

@pernielsentikaer thanks for reviewing this one. I was already reviewing the very same change, but as a PR to puntoswitcher extension. I was a bit surprised, that the PR was closed and now I understand why.
I had no intention to "gatekeep" the extension, but was rather offering a clearer way to define immutable parts of it. I still think, that the original PR was a great contribution and I would love to see it merged

Yes, I've already tried making PR to Punto, with a sincere desire to do better. But:

To make it work correctly, I have to completely rewrite all the code of Punto.
@red-avtovo didn't like my approach. Although it is more universal, correct and with elegant code.
I can improve typofixer to support layout of Punto.

It would be better for all users to only have one agreed-upon extension. Otherwise, there will be a lot of confusion, and we are really trying not to make that happen 🙂

In all fairness, I merely suggested some changes and without a comment you've closed your PR, which was at least a surprise to me

Does this cover everything in Punto @red-avtovo? Then, this could also supersede it if it's doing the job better. I'm not sure what this really does, so I can't judge here.

While it implements much more than Punto does I still think, that it is only because there was no intention in that logic in the first place

supports other keyboard layouts (it's main difference) -> skimming through the code gives me an impression, that it supports only 2 layouts (as mine extension as well), so either it is not fully implemented or I'm missing something
has layouts settings -> Fair feature and I would be happy to introduce that in Punto, but I had no use case
can convert each word separately -> not a feature that I had ever a use case, but yes, there it no such thing implemented in punto
has a more correct algorithm for encoding detection -> that is subjective. This extension has just a regex to detect the layout

While we're selecting the extension to choose, I would remind, that we're talking about mostly 1 function only and about 15 lines of code in difference. I would like to highlight again, that it was not my intention to gatekeep the project and I'm more than happy to accept any feature request. Only thing that I was asking was a dialogue


Organize and create modules

This is a follow up to https://github.com/WebServiceDevelopment/PrivateInvoice/issues/48. Now that we have a narrowly defined list of end points we can start to address how modules will be handled within these end points.

session
contacts
invoice
message
tray
settings
wallet
presentations

Right now the low hanging fruit is to get rid of message. The next will be to identify how the end points can be split up into modules.

Looks like we were pretty easily able to get rid of messages in https://github.com/WebServiceDevelopment/PrivateInvoice/pull/52/commits/cdccd91ac32e73beb1927083ba920659481a5c2d. We might need to put some functionality back later, but the end-points themselves should only be handled by the presentation end-points.

I this case session can probably be divided into Organization, Members and Authentication. Contacts, and Tray can probably be their own modules. The next issue is settings, which is probably going to use a combination of Organization and Members modules.

Under the /tray route, we have the following end points.

/getCountOfInvoice
/getFolderOfInvoice
/getTotalOfInvoice

And then the same for Archive and Draft. I think this means that we can effectively move these functions from the route handler to a new module, move all of the Tray end points into a single index file. And then update the end pointer handlers to only pass arguments into the module functions.

Two notes that I should mention here. The first is that we should probably avoid doing a deep dive on anything too soon. The first approach should be to get everything into folders and make sure we're not calling database or transactions from any end point handlers.
The next step from there is to look at each module and see what needs to be grouped, simplified or renamed to simplify the application.
The other note to make at this point is that that we probably dont need to bundle this into one massive PR. We can multiple small PR's to address incremental changes.

Before jumping into changing code, I took the time to write two blog posts about the changes that need to be made.

https://privateinvoice.io/reflecting-on-api-implementation/
https://privateinvoice.io/api-documentation-refinement/

The knee-jerk reaction would be to start making a lot of big changes. We can start to make preparations for larger moves. But we should be focusing on the smaller changes that will continue to make improvements until we need to address the larger ones.

Contacts
Credentials
Presentations
Organization
Session
Member
Keys
Mnemonics
Tray

The two easiest places to start would be credentials and tray.


Wink state changes

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (0.30.2):
Python release (3.4):
Component/platform:
Wink
Description of problem:
All Wink lights, sensors, etc. stop updating their state at least once a day for me. Once this happens the only fix is to restart HASS. There doesn't seem to be any specific time or state change causing it, and nothing is showing in the logs. I can still control lights in this condition but the state doesn't change. This started sometime around the 0.30 release. I'm running Windows 10.
Expected:
Correct state changes
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

Might be related to #3143 I lose my connection to pubnub and the state changes go with it.

@rbflurry is probably correct this is an issue with pubnub. Check out #3143 and see if you can use the automation/script I mention for a temporary fix for your issue. I am trying to work with pubnub to get this figured out. They are updating to a new version of their SDK, it is in beta and I am testing with it. Hopefully we can get this issue addressed soon.

@w1ll1am23, after reading over #3143 I remembered when this was happening several months ago, but at the time I was getting an error that somehow pointed to the battery state from the sensors causing the issue.  I just tried what I did last time around which was to remove the two functions in the wink.py file below.  So far its been 24 hours and everything's still running smoothly(with no battery levels displayed anymore of course).  I'll keep you updated if that changes.
@property
def device_state_attributes(self):
    """Return the state attributes."""
    if self._battery:
        return {
            ATTR_BATTERY_LEVEL: self._battery_level,
        }

@property
def _battery_level(self):
    """Return the battery level."""
    return self.wink.battery_level * 100

I did get this error a couple times overnight, but it didn't seem to affect anything so far.
16-10-23 00:45:56 requests.packages.urllib3.connectionpool: Retrying (Retry(total=0, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))': /subscribe/sub-c-f7bf7f7e-0542-11e3-a5e8-02ee2ddab7fe/2c3c5edb76d346686549c0db57962275f35f0a80%7Csensor_pod-156431%7Cuser-252560/0/14771928511639332?heartbeat=120&uuid=104ec45c-826b-4f5a-b26d-bfdb40a28dfa&pnsdk=PubNub-Python%2F3.8.

@brg468 Interesting, I would be very confused if that had anything to do with it, but you never know. So how has it been running? Also those pubnub errors are okay, pubnub should handle them and reconnect.

It's been over 2 days now and it's still running fine. I think that's the only thing I changed. Could be a coincidence, but I've noticed one of my PIR sensors seems to report offline every several hours and then back on almost immediately, but long enough to show up in the HA history. So maybe when it goes offline it's somehow reporting a battery level that's not an integer?Just a wild guess. I don't know why that would drop the connection but I'm pretty inexperienced with all this.

Interesting, keep me posted. I am testing some things now, but I should be able to try this too in a couple days.

Well yesterday morning it started acting up again, now it won't even make it through the night before losing state changes. I guess it's not the battery levels causing it.

@brg468 thanks, i did find an issue thanks to you and it is related to the battery but I don't think it is the main problem. It looks like sometimes the battery is sent back as None and in that case we are trying to do None * 100 which blows up and pubnub updates stop. In this case turning on a light doesn't correct the problem so there must be some other issue as well. This is definitely a good find though so thanks again. I'll correct that issue soon.

@w1lliam23, I was starting to get that same impression but now it's related to my temperature sensors. There was a error that came up in my terminal window but that isn't logged in HA that essentially said the same thing but with 'STATE_UNKNOWN' being returned and then crashing when trying to pass that to round() in this case. It seems like sensors occasionally dropping offline and then trying to use that invalid data could be the underlying issue, but again just throwing out ideas here.

Good call out, I will add an if around those round() calls too. Got a notification from pubnub that v4 should be released very soon so hopefully I can start testing more with that and we can get this completely resolved.

I wanted to provide some testing and feedback I have been doing as well to see if it helps narrow the issue down. The largest bit of automation that runs in my HA environment is my pantry door sensor through wink turning two hue bulbs on and off based on the door opening and closing. I have noticed since 0.29 release that this same issue was occurring and eventually the lights stop receiving state from wink. I have to reboot HA to fix the pantry. This occurs about 2-3 times a day. Today I finally rolled back to 0.28.0 and while my motion sensor is missing in this release, my pantry sensor and state work without issue and it stays running.  I know HA did a major change around this time and there was a bug fix put in for the motion sensors reporting only temperature and not motion state. Hopefully this information helps.

@mcaminiti thanks! This is helpful, I really do think this has something
tondo with the motion sensors. Your input has me almost certain now. Having
said that I believe I have it fix! If you could test out
https://github.com/home-assistant/home-assistant/pull/4175 it would help me
confirm. The easiest way to test would be to wait for 0.32.0 to be
released, and then this PR will get merged into dev.
On Nov 5, 2016 12:19 AM, "mcaminiti"<EMAIL_ADDRESS>wrote:

I wanted to provide some testing and feedback I have been doing as well to
see if it helps narrow the issue down. The largest bit of automation that
runs in my HA environment is my pantry door sensor through wink turning two
hue bulbs on and off based on the door opening and closing. I have noticed
since 0.29 release that this same issue was occurring and eventually the
lights stop receiving state from wink. I have to reboot HA to fix the
pantry. This occurs about 2-3 times a day. Today I finally rolled back to
0.28.0 and while my motion sensor is missing in this release, my pantry
sensor and state work without issue and it stays running. I know HA did a
major change around this time and there was a bug fix put in for the motion
sensors reporting only temperature and not motion state. Hopefully this
information helps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/3989#issuecomment-258589873,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGIoAogenbTJXfdNzlCLi0nS12lIbFK1ks5q7APfgaJpZM4Kd160
.

Sure. I'll gladly run the Dev branch once the PR is committed and ready to test. I know with as often as my family likes food, we test it out frequently. If there is any logging I can enable or send as well let me know too.
Thanks for all you do on the platform. It really is a great platform growing every update.

@w1ll1am23, Just to keep you updated, I put an if around those round () calls like you mentioned for sensor temperature, basically just having it skip the rounding part if the number isn't a float, but your solution seems like the right way to do it. I haven't had any issues since I inserted this, so I think it's fairly safe to assume it's the math operations on bad data causing the issues. I'll run your changes once it's merged and keep you updated.

@brg468 Really good news! I did however wake up this morning to mine being unresponsive, running this PR. So I think I may still be missing things but it could be caused by device you don't have. I also updated my Wink Hub last night and the Z-Wave range seems to have dropped because now the furthest two Z-Wave devices went unavailable multiple times over night might have something to do with the issue as well?
@brg468 @mcaminiti Can you add a list of all of your Wink devices? Might be helpful to see what we have in common. Here are mine.

GE Lights
Osram Light
Quirky Spotter
Quirky Power Strip
Quirky Egg Minder
Quirky Porkfolio
Schlage lock
GoControl PIR
GoControl Door/Window sensors
GoControl Siren
Z-Wave light switches
Generic Z-Wave leak sensor
Nest (Support added with #4175)

@w1ll1am23 , I updated mine the other day as well, but I haven't noticed any adverse effects yet.  I thought I had the issue appear yesterday morning but it ended up being HA completely stopped updating the frontend, not just Wink stuff, and wouldn't let me log in from other devices until I restarted, which I've never seen before but I don't think it was related to this.  Here's my list of connected items.  BTW I also still have the battery state code removed as I mentioned at the beginning of all this.

GE Link bulbs
Cree Connected bulb
Osram RGBW bulb
various GE in wall dimmers and switches
iHome Smart Plug (through linked acccount)
GoControl PIR sensor
GoControl Door sensors
Ecolink PIR sensor (doesn't report temperature)
Leaksmart water valve and water sensors (these also report temperature and tend to be what drops offline more than anything)
Lutron Connected Bulb Remotes
GoControl battery powered siren
Chamberlain MyQ garage door opener (through linked account)
Nest (using the HA Nest component)

I do not have many things in wink in my total home automation:

Go Control Door Sensors

Go Control Motion Sensor

lutron / Leviton zwave Switches

I removed Hue from the wink to avoid duplicates in HA and Amazon Echo.

Yes, still waiting for @balloob to merge #4175 into dev.
I am no longer seeing any errors in my logs however I am still seeing my devices become unresponsive. I hopeful that these changes along with switching to pubnub v4 once it is out of beta will correct the problem all together.

Done 👍

As a note, I've been running 0.28 without issues or reasons to reboot now
for 2 days.   I will check out how to upgrade to the dev branch from git
and then test that out.
Thanks!
Matt
On Sun, Nov 6, 2016 at 9:27 AM, Paulus Schoutsen<EMAIL_ADDRESS>wrote:

Done 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/3989#issuecomment-258688154,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKlQ7h2QIQpQEmguxvaYkfK2zhExE45dks5q7fHlgaJpZM4Kd160
.

Lets start talking about this over here. https://community.home-assistant.io/t/ha-stops-reporting-wink-state-changes/5884 this will provide some more exposer and we might get some others to chime.


Import and formatting issues

Recently I've been noticing quite a few issues with imports being messy and some of the code not being formatted correctly.

We should do a full black and isort over the codebase before 0.7.0 is released. Then we'll have a tidier base to work from.


Task markers get highlighted everywhere, not just at the beginning of lines

I have - set as baseMarker and, currently, all - characters get treated as if they are task markers... The buffer's DOM gets changed with these semantics and so they're all highlighted.
I was able to fix this behavior by changing this part of tasks/lib/tasks.cson to become:
'repository':
  'marker':
    'match': '^\\s*(☐|✔|✘)'
    ...

...I believe this change should go into master, unless something is escaping me... Please let me know your thoughts on this...
Sorry that I'm not sending a pull request — I still gotta learn a bit more about how Git works!

Thanks. Fixed it for me.

I have now another fix so that --- markdown text at beginning of line doesn't get highlighted too:
'repository':
  'marker':
    'match': '^\\s*(☐|✔|✘)\\s'

@Zettt You're welcome! — I'm glad it was worthwhile to share.  :)

This seems valid to me! Thanks for exploring this :) I'll get it in as soon as I can.

Unfortunately, this change seems to break the highlighting for completed and cancelled tasks. I'll need to do a bit more adjusting to fix this.

I've found that it comes down to not being able to utilize the ^ in the repository marker section. For whatever reason that seems to be breaking the highlighting. I think it may be that previous rules are consuming the line start, so I'm going to see if I can work around this issue.

Thank you!


request validation fails for optional parameters

operation.validateRequest(req) falsely fails for multiple reasons:

when there's nothing said, wether a parameter is required and the param is missing, the validation fails with:

Cannot read property \'readUInt8\' of undefined for strings
Expected type boolean but found type undefined for booleans
the spec says it defaults to false.
...

when no mime type is defined via consumes

i was giving this library a try, because the swagger-tools do not validate array-enums correctly.

I doubt it fails falsely as any runtime error, like the first, would be thrown.  As for the second, I'm not sure what you're saying there but it seems like an optional boolean is not defaulting to false like you'd expect.  The third...I don't know what that one is.  When there is no consumes, the request shouldn't fail.

As for swagger-tools not validating enums properly, I think your schema is wrong as I mentioned there.

I can reproduce these issues but here is my feedback:

This is an issue and will be fixed
Nothing in the specification says that an optional boolean defaults to false.  If you want to set a default value, use the default property.  But, I do think it's wrong to validate optional arguments without a value so I will fix this as well.
I have no idea what you're talking about regarding consumes

Any information you can share on how to reproduce each of these would be ideal because all I can do is guess.

The first two issues you see are related to an issue with how we identify optional parameters.  Fixing one fixes both.  Commit incoming.

I cannot reproduce the last issue.  I tried with empty consumes at both the global and operation level, and with no consumes at all at the global and operation level.

Without more information, I cannot reproduce or fix the third issue you brought up.  As for the other two, they are fixed and will be released in 1.0.0.

thanks for your prompt answer - and sorry, i cannot reproduce the last issue neither.


Org-Wide app policies vs Custom permission policies

I find some information on the article contradictory.
On one hand you say that "Org-wide app settings override the global policy and any custom policies that you create and assign to users." and on the other "If you want to control the apps that are available for different groups of users in your organization, create and assign one or more custom app permission policies."
How can the custom policy work if it's overridden by the Org-Wide one?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b51eda6c-168c-7d99-7cc1-992b3d8feef2
Version Independent ID: 118a1b8f-f4b7-a778-70b1-d3161fc548ab
Content: Manage app permission policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-app-permission-policies.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@AlexanderSaad Thank you for submitting feedback and contributing to the docs. We are currently investigating this

Hello @AlexanderSaad How are you?
Hope you are doing good.
I read both sentences and to my understanding and tests in lab, that means that, if for example, in org-wide settings I disable "Allow third-party apps" there will be no posibility to create a custom permission policy with Third party apps:

However, if I enable  "Allow third-party apps" I can have a custom app perm policy that can have either allow, allow specific, block specific or blocked, like this:

Hope this helps you clarify this concept.

@get-itips Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Please provide a Release Artifact on each release

Currently (at least until 0.6.2), you do a GitHub release, but you do not provide a release artifact.
Please provide one, which is compiled version of the sources. At minimum you could exclude all the build specific stuff like .mvn .github etc.

Hi @rkottmann ,
We do publish an artifact for each release on Maven Central.
We will make sure to add this information in the release notes in the future, so that it is easier to spot for developers.
Thank you for pointing that out.


Throw a meaningful error when there's a syntax mistake in composes

Currently, composes: a-block[type=butcher] (value is not in quotes) results in an error that's not meaningful, like the following.

[css-blocks] BlockSyntaxError: No Block named "b-block" found in scope. (xxx/card.block.scss:18:3)```

We should throw an error that suggest a quoting the value instead.

Perhaps support   composes: 'text-body[weight=bold][size=small]'; in addition to ```composes: 'text-body[weight=bold]', 'text-body[size=small]'


ARROW-11568: [C++][Compute] Rewrite mode kernel

Arrow mode kernel performance is bad compared with scipy.stats.mode
(based on numpy.unique). Arrow mode kernel stores value:count pair in
a map, while numpy.unique sorts the input array then count the adjacent
same values. Per my test, the map approach only wins when there are
many duplicated values (length / value_range > 100), looks not very
useful in practice.
This patch rewrites mode kernel to use the sort and count approach for
floating points and integers with wide value range. 2x performance
improvement is observed.

Benchmark on skylake, clang-9.

Do the existing tests exercise both the narrow and wide cases?

Yes. https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/aggregate_test.cc#L1075-L1082
I do find a comment should be updated hashmap-based -> sorter-based

I checked Github Actions and Travis-CI on my fork, will merge.


npm run build error "Lexical error "

!!! IF YOU DO NOT USE THIS ISSUES TEAMPLATE, YOUR ISSUE IS LIABLE TO BEING IGNORED BY US
Prerequisites
Please answer the following questions for yourself before submitting an issue.

[ X] I am running the latest version
[X ] I checked the documentation and found no answer
[X ] I checked to make sure that this issue has not already been filed
[ X] I'm reporting the issue to the correct repository (for multi-repository projects)

Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Device:  MacBook Pro
Operating System: MacOS 10.13.6
nodejs : 12.4.0

Failure Logs
I can not run npm run build. there was an error

Lexical error on line 1: Unrecognized text.
Erroneous area:
1: 100% - $sidebar-width
^.........^

Please include any relevant log snippets or files here.
2019-06-15T04_24_13_228Z-debug.log

Hello there, @aapidech ,
This is kind of a duplicate of this issue here: https://github.com/creativetimofficial/light-bootstrap-dashboard-react/issues/50
Also, my response for your issue is found here: https://github.com/creativetimofficial/light-bootstrap-dashboard-react/issues/50#issuecomment-492533529
In our issue template we have this line I checked to make sure that this issue has not already been filed. I can see that you have checked it, please next time take a moment and search through other issues. Thank you.
Best,
Manu

Try instaed 100% - #{$sidebar-width}


make dvc a dev dependency and make "data for tests" into a dvc dataset

Decided I don't want to do this, closing as wontfix


Can it easily get text content and switch window like selenium?

What versions are you running?

$ go list -m github.com/chromedp/chromedp
github.com/chromedp/chromedp v0.6.10
$ google-chrome --version
Google Chrome | 89.0.4389.90 (Official Build) (x86_64)
$ go version
go version go1.16.2 darwin/amd64

What did you do? Include clear steps.
it will easily get text content in selenium, the code as follow:
from selenium import webdriver
from selenium.webdriver.common.by import By
from selenium.webdriver.chrome.options import Options
from selenium.webdriver.support import expected_conditions as ec
from selenium.webdriver.support.wait import WebDriverWait

def browser(*args):
    opts = Options()
    # opts.add_argument('--headless')
    opts.add_argument('--disable-gpu')
    for arg in args:
        opts.add_argument(arg)
    return webdriver.Chrome(executable_path=r'path_of_your_chromedriver',
                            options=opts)

def hymnSpider(browser, url: str):
    try:
        wait = WebDriverWait(browser, 20)
        browser.get(url)
        wait.until(ec.presence_of_element_located((By.ID, "js_content")))
        nodes = browser.find_elements_by_xpath(
            ".//section[@*[starts-with(name(), 'data-darkmode-color')] and @*[starts-with(name(), 'data-darkmode-original-bgcolor')]]/*[self::p or self::section]/a"
        )
    except Exception as e:
        print("browser exception: {}", e)
    return nodes

def Daben():
    bs = browser()
    nodes = hymnSpider(
        bs,
        'http://mp.weixin.qq.com/s?__biz=MzUwOTc2ODcxNA==&mid=2247509149&idx=2&sn=4c5265f1c343444f42c806c8af3d43d6&chksm=f90fc1f8ce7848ee03c5f63b13566fdd7495154488e276fc6fa18aa30fd54ad38995fa77be18&scene=21#wechat_redirect'
    )
    for node in nodes:
        title = node.get_attribute('textvalue')
        url = node.get_attribute('href')
        if url and '大本诗歌' in title:
            print(title)
            bs.execute_script('window.open()')
            handles = bs.window_handles
            bs.switch_to_window(handles[1])
            hymns = hymnSpider(bs, url)
            time.sleep(3)
            for hymn in hymns:
                print(hymn.text, hymn.get_attribute('href'))
            bs.close()
            bs.switch_to_window(handles[0])

    bs.quit()

It can easily get the text content using the node instance attribute text, just like hymn.text. And It can also switch the window through the switch_to_window function.
What did you expect to see?
I look forward to having the same function in chromed.
What did you see instead?

Hi,
here is some of the example for scraping the text from page: https://github.com/chromedp/examples/blob/master/text/main.go
and for what you're looking for switch the page, I think you can switch to a different page if you use their own context.

Hi,
here is some of the example for scraping the text from page: https://github.com/chromedp/examples/blob/master/text/main.go
and for what you're looking for switch the page, I think you can switch to a different page if you use their own context.

Thanks. It could get the text via node instance in selenium(like hymn), but i did not see the same way in chromedp.

For getting text, please check whether this works for you: https://github.com/chromedp/chromedp/issues/668#issuecomment-832629053


Importing local modules

Thanks, this appears to be a very useful package which would solve many compatibility problems between windows, linux etc.
One thing I am wondering is how to import a local module. In PyCall this would be done as:
const pymodule = PyNULL()
pushfirst!(PyVector(pyimport("sys")["path"]), (@__DIR__)*"/dir_relative_to_src")
copy!(pymodule, pyimport("mylocalmodule"))

Help on how to do this in PythonCall would be highly appreciated!

Glad you like it!
The equivalent in PythonCall is:
const pymodule = PythonCall.pynew()
pyimport("sys").path.append("some/path")
PythonCall.pycopy!(pymodule, pyimport("mylocalmodule"))

Thanks, that works! See https://github.com/JuliaGeodynamics/geomIO. Next up is figuring out why CI fails on windows, but works on Mac/Linux.

I'm following this pattern and getting occasional segfaults when I try to access the imported module (the one that I pycopy!ed).  Do I need to do something like GC protect that pointer so it doesn't get GCed?  Can I even do that on the julia side or do I need to do it on the python side somehow?

I get the same behavior FWIW when using Ref{Py} to store the imported module as well...

Wow and when I pyimport the module afresh each time before referring to it.  I suspect this may be something specific to my module and how I'm using it!


Benchmark action fails to post comments for PRs from forks

Problem
Secrets are not passed to workflows that are triggered by a pull request from a fork
Proposed Changes
Maybe it can be triggered by adding a label to the PR?
cc @siku2

The GITHUB_TOKEN passed to pull requests from forks is read only ([docs] (https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token)). It might be possible to work around this by adding another write-enabled token to the secrets and use that instead.
This is assuming that secrets do get passed (I haven't tested / found an answer to whether or not that's true).

Well it turns out that secrets aren't passed at all so there goes that idea...

@jstarry

Maybe it can be triggered by adding a label to the PR?

That is how the workflow works already (the first run is triggered by the label, not by a push) but sadly that doesn't seem to work.
I've considered porting the workflow to Travis but even it doesn't allow for this:

Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them.

(source)
For now I think we have no other choice but to remove the comment and simply have the workflow print the results to the console. That way we can at leat point to them more easily.
Hopefully there will be a way to do this in the future...


Flutter macOS application screen is black, but logs are live in terminal.

Steps to reproduce:
I don't know the way to reproduce this. I created new project and its running well. But this error occurred in our running app for a while. It was working well yesterday, I didn't change any piece of code, but not running today.
Expected results:
App should open without blacking out screen.
Actual results:
Screen is black but my prints are in terminal.

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.0, on macOS 12.3.1 21E258 darwin-x64, locale en-GB)
    • Flutter version 3.0.0 at /Users/kadirovatabek/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee4e09cce0 (7 weeks ago), 2022-05-09 16:45:18 -0700
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/kadirovatabek/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.42.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.3.1 21E258 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

macos/Podfile
platform :osx, '10.13'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
  'Debug' => :debug,
  'Profile' => :release,
  'Release' => :release,
}

def flutter_root
  generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'ephemeral', 'Flutter-Generated.xcconfig'), __FILE__)
  unless File.exist?(generated_xcode_build_settings_path)
    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure \"flutter pub get\" is executed first"
  end

  File.foreach(generated_xcode_build_settings_path) do |line|
    matches = line.match(/FLUTTER_ROOT\=(.*)/)
    return matches[1].strip if matches
  end
  raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Flutter-Generated.xcconfig, then run \"flutter pub get\""
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_macos_podfile_setup

target 'Runner' do
  use_frameworks!
  use_modular_headers!

  flutter_install_all_macos_pods File.dirname(File.realpath(__FILE__))
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_macos_build_settings(target)
    target.build_configurations.each do |config|
      config.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.13'
    end
  end
end

pubspec.yaml
environment:
  sdk: '>=2.17.0 <3.0.0'

dependencies:
  flutter:
    sdk: flutter
  animations: ^2.0.0
  auto_size_text: ^3.0.0-nullsafety.0
  cached_network_image: ^3.0.0
  cupertino_icons: ^1.0.3
  device_info_plus: ^3.2.3
  equatable: ^2.0.2
  expandable: ^5.0.1
  file_picker: ^4.2.0
  # firebase_core: ^1.1.1
  flutter_app_badger: ^1.2.0
  # firebase_analytics: ^8.2.0
  # firebase_messaging: ^11.4.1
  # firebase_crashlytics: ^2.0.4
  flutter_markdown: ^0.6.2
  # flutter_masked_text: ^0.8.0
  flutter_masked_text2: ^0.9.1
  flutter_image_compress: ^1.0.0
  flutter_interactive_keyboard: ^0.2.0
  # flutter_video_compress: ^0.3.7+8
  video_compress: ^3.0.0
  flutter_native_splash: ^1.1.8+4
  flutter_bloc: ^7.0.0
  flutter_slidable: ^0.6.0
  flutter_svg: ^0.23.0+1
  flutter_spinkit: ^5.0.0
  flutter_google_places: ^0.3.0
  flutter_video_info: ^1.2.0
  font_awesome_flutter: ^9.0.0
  dart_ipify: ^1.0.2
  google_fonts: ^2.1.0
  google_maps_flutter: ^2.0.5
  geolocator: ^7.0.3
  image_picker: ^0.8.4+4
  image: ^3.0.8
  intl: ^0.17.0
  # local_auth: ^1.1.5
  mime: ^1.0.0
  # native_pdf_view: ^6.0.0+1
  pdfx: ^2.0.1+2
  open_file: ^3.2.1
  path_provider: ^2.0.1
  package_info: ^2.0.0
  permission_handler: ^8.0.0+1
  photo_view: ^0.13.0
  printing: ^5.9.1
  provider: ^6.0.1
  responsive_util: ^0.4.0
  signature: ^4.1.1
  shared_preferences: ^2.0.5
  shimmer: ^2.0.0
  sliding_up_panel: ^2.0.0+1
  timeago: ^3.0.2
  uuid: ^3.0.4
  url_launcher: ^6.0.4
  better_player: ^0.0.79
  http: ^0.13.3
  http_interceptor: ^1.0.1
  # video_player: ^2.1.0
  collection: ^1.15.0-nullsafety.4

dev_dependencies:
  integration_test:
    sdk: flutter
  flutter_test:
    sdk: flutter
  test: any

flutter run -d macos --verbose:
log.txt
Regards.

Hi @ikays97,
From what I can see, your project contains many dependencies so that we can not address the issue properly.
Please provide a completed and minimal reproducible code sample so that we may verify this.
Below are some hints that you can try before back here with us:

You are using the old Flutter version, the latest Flutter stable is 3.0.3 and the master is 3.1.0-0.0.pre.1396. Please try upgrading them and retry to see if this issue still reproduces
What is your current Xcode version? Does you project run well with iOS?
Try removing dependency one by one and running app again to find out if issue's caused by a specific dependency.

Thank you!


Propose updates only to stable Fedora versions

A change to global configuration to not propose Fedora updates beyond stable by replacing updates from https://quay.io/repository/fedora/fedora with https://endoflife.date/fedora .
Example merge request proposed by Mintmaker can be viewed here.
Refers to CWFHEALTH-3193.

@qixiang @gnaponie @staticf0x I think PR should be good to go now, can you take one last look?

+1 \o/


Documenation/Article improvement

This tutorial is using very obscured and confusing sentencing I find on top of very high expectations for the reader.
This paragraph is very confusing and pointing to another even more confusing URL: https://spring.io/guides/tutorials/spring-security-and-angular-js/
"Add an Angular App
The core of a single page application in Angular (or any modern front-end framework) these days is going to be a Node.js build. Angular has some tools for setting this up quickly, so lets use those, and also keep the option of building with Maven, like any other Spring Boot application. The details of how to set up the Angular app are covered elsewhere, or you can just checkout the code for this tutorial from github."
The URL https://github.com/dsyer/spring-boot-angular has even more difficult steps to follow which did not take me anywhere. These steps require advanced knowledge of linux commands, not something I would expect as a requirement for Spring Boot applications.
I have never heard of Angular app being added into Spring Boot project but the description seems to be doing exactly that. Why would you tie these together? Isn't this what monoliths are?
It would be helpful to provide simpler steps with explanations, especially for the Angular part since and as the article mentions, Java devs may not have knowledge of Angular. Same for the linux command being used all over the article, scaffolding details are also missing lots of clear guidance.
In addition to the above, it is unclear

if this article explains building an Angular or AngularJS app
and is this frontend Angular part of Spring Boot backend or are they separate.  It feels like they are one app

The instructions are more deterring than attracting those interested to learn and try out the example.

Hey, @dbnex14.
Please include a link to the article you're referring to so we can take a look.

Hey, @dbnex14.
Please include a link to the article you're referring to so we can take a look.

added

Hi, @dbnex14.
The article in question is not on baeldung.com.
Unfortunately, we can only help with questions that are specifically and directly related to our articles. In this case, you should check with the spring.io support team.


process-agent: bump gopsutil version and use the same handleSignal helper for all platforms

What does this PR do?
This bumps the gopsutil version we use to have: https://github.com/DataDog/gopsutil/pull/23 (this was causing issues on macos)
Also the sigchild was very noisy on macos so I just merged the two handleSignal helpers.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?

The CI failed on
# github.com/DataDog/datadog-agent/pkg/process/util
pkg\process\util\signal.go:21:8: undefined: syscall.SIGCHLD


Add checkstyle formatter

Fixes #109

Thanks for the pull request. I'm curious what is checkstyle? I've never heard of it. What I saw with a quick search was http://checkstyle.sourceforge.net/ and a plugin for jenkins...

As you probably saw, Checkstyle itself is a tool for validating Java coding styles and not particularly interesting in the Node.js world.
The output format that Checkstyle uses, however, is supported by many CI systems (Jenkins being one of them) and various tools in the JavaScript ecosystem, for instance jscs, JSHint and ESLint or Complexity Report. The point is that the CI can then aggregate the results of all of these tools and display the problems detected on a file-by-file basis (and let it handle whether the build should fail depending on the number of warnings and problems found).
Does this answer your question?

Is there anything else I can do to help this PR go forward?

@pigulla Sorry, I think I derailed your PR with my dumb comments in #112.
I think there is a small bit of work to do here to support custom formatters on the nsp side, but the good news is that you could publish your custom "checkstyle" formatter to npm and manage it yourself without needing to land code in nsp.

Yes! Sorry for the delay. I think this would the best way to proceed. Any chance you could help us make this a better generic / plugin friendly solution for yourself and others?

On May 24, 2016, at 6:05 PM, Peter deHaan<EMAIL_ADDRESS>wrote:
@pigulla Sorry, I think I derailed your PR with my dumb comments in #112.
I think there is a small bit of work to do here to support custom formatters on the nsp side, but the good news is that you could publish your custom "checkstyle" formatter to npm and manage it yourself without needing to land code in nsp.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@evilpacket Yes, I can take a stab at it later this week :)

Until then, let me close this PR since it doesn't look like it will be merged.


Stuck on "Connecting to discord IPC pipe"

I suspect this happened after updating my discord to 64 bit recently, any ideas?

Turns out - the answer was both yes and no to if it was caused by installing x64 or not. I had to restart my system after installing the x64 version of discord for the pipe to actually exist - it was in a state of limbo until I did. (Just restarting discord did not work)


Re-create the CMS in the image process and change the sync logic

Currently, only pages in GitHub that are not homepages are managed for the creation of online documentation in the HUGO CMS. These are _index.md files in the CMS. When writing, this is taken into account by skipping them specifically. Also, the date of the last change is not generated by writing a FrontMatter, but by a setting in the HUGO configuration.
This makes the adjustment unnecessarily complicated. For this reason the behavior is to be changed.
The switch -deleteNonReplacedFiles in Sync-MarkdownFiles could be omitted, in which the target directory is completely deleted before. The prerequisite would be that the homepage file is located in GitHub. There, however, it is normally called Readme.md.
To do would be:

Remove switch
Rebuild logic
Delete target directory
Put a warning in the home page so that GitHub users aren't aware that local links on the home page don't work as expected.


improve readme

Coverage remained the same at 100.0% when pulling eebdaae191e6e7fee70d32fafe702d0cb873a336 on fico7489:develop into 4fb656bad99e313375969117de566c8c859fbbb4 on stevegrunwell:develop.


fix: Improved SEO score

Related Issue #1575
Description

Added proper meta tags to improve the SEO score
Also properly added keywords , titles, description etc to improve SEO

Screenshots

Hey @priyankarpal I resolved all the issues Please review it now


Round Robin Mapping is Broken

LP IDs on each Rank always start at 0. Not good.

This was done so the Local LP id is used as an index in the local LP array.
What is broken about Round Robin mapping ?
Thanks,
Chris

Christopher D. Carothers
Director, Center for Computational Innovations
Professor, Department of Computer Science
Rensselaer Polytechnic Institute
110 8th Street
Troy, New York 12180-3590
e-mail<EMAIL_ADDRESS>web page: www.cs.rpi.edu/~chrischttp://www.cs.rpi.edu/~chrisc
phone:<PHONE_NUMBER>tel:(518) 276-2930
fax:<PHONE_NUMBER>tel:(518) 276-4033

From: Elsa Gonsiorowski<EMAIL_ADDRESS>Sent: Thursday, September 03, 2015 3:44 PM
To: carothersc/ROSS
Subject: [ROSS] Round Robin Mapping is Broken (#69)
LP IDs on each Rank always start at 0. Not good.
—
Reply to this email directly or view it on GitHubhttps://github.com/carothersc/ROSS/issues/69.

Sorry, I meant to say that LP GIDs always start at 0. Each MPI Rank has an LP 0.


How to differentiate bringing the app to the foreground via a notification tap

Hi,
This is be related to  the issue App open from PushNotification click without payload where @cjadhav and @DFoxinator ask about getting the payload on clicking on notification.
To differentiate bringing the app to the foreground via a notification tap from just bringing the app to the foreground normally, I have tried the following:

At GCMIntentService.java add an Extra to the launcherIntent :

launcherIntent.putExtra("PUSH_LAUNCH", true);`

Somewhere in my code add an 'newIntent' event listener.
I have tried with no luck:

win.activity.addEventListener("newIntent", function(e) {
     console.log('NEW INTENT ' + JSON.stringify(e.intent) + ' WITH EXTRA: ' + e.intent.getBooleanExtra('PUSH_LAUNCH', false));
});

and
Ti.Android.currentActivity.addEventListener('newintent', function(e) {
         console.log('NEW INTENT ' + JSON.stringify(e.intent) + ' WITH EXTRA: ' + e.intent.getBooleanExtra('PUSH_LAUNCH', false));
});

@FokkeZB opened a JIRA ticket :Android newintent event not fired so that could be reason I do not get it.
Do you know another way to do it?

@pakoArtal were you ever able to figure this out?

Hi @DFoxinator,
No luck yet, if I get news I will write them here...
If I understand correctly we need  a 'newIntent' listener.  In the JIRA ticket related to the newIntent listener says:
Resolution: Unresolved
Affects Version/s: Release 5.2.0
Fix Version/s: Release 6.0.0
To get notified, Login to jira and press 'Start watching this issue' on https://jira.appcelerator.org/browse/TIMOB-4865
I heard that the more people watching the issue the fastest they solve it ....

@pakoArtal thanks a bunch, what you're saying makes sense. The way you were trying to do it with newintent listener is what I was trying to do too.
I left a comment on the ticket asking about a workaround. This seems like very critical functionality, if in fact you literally can't properly open a Titanium app that's in the background from a push notification with a payload.

You can do it yourself by using gcm.getLastData(); when you start the app

Agreed, this is critical functionality.  Surprised this isn't included somehow??


Minimally-invasive separation of bitcoin keys from ECDSA signature types

This PR tries to do a minimally-invazive separation of signature- and key-related types, previously mixed in a single util::ecdsa module.
Rationale: bitcoin key types are not specific for signature algorithm. See discussion at #588.
This PR became possible after we moved on new secp256k1 version exposing XonlyPublicKey type, since now all key types may co-exist in a single module under different names
The PR goal is achieved through

Renaming ecdsa mod into private ec module such that the code is not copied and diff size is small;
Introducing dummy ecdsa mod back in the next commit and re-exporiting only signature types from internal ec mod in it;
Re-exporting all key types under key module, removing previous depreciation message for bitcoin keys.

Concept ACK. Given how trivial the ecdsa mod is It think this would be better without eedab33955840527cee1f05b4e9cc7e4ec674c6c
Was also thinking of moving things outside of util while you're at it but maybe it's too unrelated.

Honestly I think the entire contents of util/ecdsa.rs could just be pulled into key.rs directly.

Maybe we can punt on re-organizing keys to #751 that would massive crate re-organization anyways? And I think this is not critical for taproot release.
As mentioned in the review, using bitcoin::PublicKey did not generate any deprecation downstream. I think we can get away with nuking ecdsa::PublicKey and ecdsa::PrivateKey directly.

I've redone this PR trying to follow your suggestions. Now it effectively moves keys from ecdsa mod to key mod - and it is done in a way that you can check that the code has not changed by reviewing on a per-commit basis.

ACK 6ecc8809112ef17c428c24eefaf300f7f84d86b1 except for Kixunil's comment about deprecation.

@apoelstra updated, needs re-ACK

Had to re-base after the latest merges; @sanket1729 @Kixunil @apoelstra pls re-ACK

Now this one also has conflicts

Rebased, another re-ACK required, sorry, @Kixunil @apoelstra @sanket1729

@apoelstra which is good, isn't it? :D

Rebased after latest merges. @apoelstra @Kixunil @sanket1729 please re-ACK

Sorry guys, I know you are tired of this - but while we were-reACKing it it had to be rebased once again :( Hopefully for the last time.