How to migrate from 0.9 to 1

Asking how to migrate

Copy cli branch from git@github.com:angular/angular-cli.git;

What do you mean by copy cli branch ?

Copy your src/app, src/assets, src/custom-typings.d.ts into src folder;

Copy to where ? A fresh cloned from latest version or "ng new" project ?  I

Add each of your required modules and styles into .angular-cli.json;

Change paths to file(images, fonts, ets);

Add import * as $ from 'jquery'; into app.component.ts;

Add those line to our current project (v0.9.0)

Delete unused files: .bootstraprc, postcss.config.js, tsconfig.webpack.js, typedoc.json, webpack.config.js, config/, docs/, src/custom-typings.d.ts, desktop, ts, src/main.browser.aot.ts, src/package.json, src/polyfills.browser.ts, src/vendor.browser.ts, src/app/environment.ts, src/app/index.ts, src/assets/service-worker.js;

Delete it from our current project ? (v0.9.0)

Change style-loader css import to styleUrls[‘./example.scss’] and wrap your sass styles into :host /deep/ {} expression.

@genz10 I updated a migration guide.

@lexzhukov Where can I find the updated migration guide?


The generated file for iOS interferes with other options for providing flavors of .env files

In the latest version, something creates the generated iOS env file ultimately stored in the node_module/react-native-config directory.
This appears to interfere with other methods of providing flavored .env files such as using ENVFILE=.env.staging when running react-native.
It appears to always reads from the generated file and not the local environment. Manually deleting it resolves the issue, but the file gets recreated at some point. I think either pod install or react-native run-ios.
Downgrading to 1.4.6 fixes the issue - that file is not automatically created every install or scheme/flavor change.

This explains why it now requires a clean before building with a different scheme to have the config update correctly.

The only change I can see in the diff https://github.com/luggit/react-native-config/compare/v1.4.6...v1.4.11 is the addition of this line https://github.com/luggit/react-native-config/blob/master/react-native-config.podspec#L29

I had this as well and indeed every build needs an xcodebuild clean -workspace ios/somename.xcworkspace -scheme someSchemeName before the config is being picked up.

Yeah, me too. This seems the only solution that worked for me

I get error with version 1.5.0
Downgrading to 1.4.6 fixes for me


Add repr and str support for handlers

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a82bbe) 100.00% compared to head (ce0deb1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #388   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           62        62
  Lines         2193      2179   -14
  Branches       384       384
=========================================
- Hits          2193      2179   -14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


renamed dir to full-day-workshop

corrected the spelling in the breadcrumb
renamed supporting files to match markdown directory name
renamed images directory to match markdown directory name

@dougseven I will merge and resubmit

I have merged the spelling changes into the branch so that there aren't any conflicts

I tested this locally with Jekyll prior to pushing the PR


add getLabelItems public method

Fixed #10837

@LeeLenaleee @etimberg @kurkle review please 🙏

@LeeLenaleee, I'm out of the context of the changes. I'm just fixing CI here. Could you help me with this?

Should also update the docs https://www.chartjs.org/docs/master/developers/api.html

That doc is for the Chart class, this change is in scale. Typedoc will generate an entry for this.


Missing User Canceled Error Message

Hello,
When a user clicks on cancel I am returned the following error code: "AADB2C90091" however, I do not see it in this list. can you please update this list?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd9c64ff-5065-9a2b-4965-c48685482fe1
Version Independent ID: 3ff9871f-d28d-b752-750e-1142556ec8cb
Content: Error code reference - Azure AD B2C
Content Source: articles/active-directory-b2c/error-codes.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@MarileeTurscak-MSFT
Thanks for the feedback! We are looking into this and will get back to you shortly.


Line breaks do not get rejected in envelope.{from,to}

The from and to fields in client.send(envelope, msg) do not get properly escaped and thus allow for injecting arbitrary SMTP commands. This could be used by an attacker to send arbitrary messages if the application fails to validate the email address properly (or the developer mistakenly assumes the library has validation built-in).
PoC:
var SMTPConnection = require('smtp-connection');

var c = new SMTPConnection({port: 5566});
c.connect(function () {
	c.login({user<EMAIL_ADDRESS>pass: "*yay*"}, function() {
		console.log("logged in");
		c.send({to<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Subject\r\nCthulhu fhtagn\r\n.\r\n", from<EMAIL_ADDRESS>				"Does not matter",
				function() { console.log("sent!"); c.close() });
	})
});

This is similar to the CVE-2015-8476 found in PHPMailer few weeks back.

Thanks for reporting. Fixed with https://github.com/andris9/smtp-connection/commit/21590db277a9b14f4efa25e968fbd91dbaadee0e?w=1 published to npm as v1.3.4


Static definitions inside a ES6 class cause errors

This :
class FullScreenButton extends React.Component {
    static propTypes = {

Causes an error like:
ERROR: Unable to parse /......./FullScreenButton.jsx: Unexpected token =

Also this fails:
getButtonProperties = () => {
// ...
}

Docma currently supports JSDoc v3.4.3 (latest stable version as of Jun, 2017).
Static methods (and getters/setters) would work but static (property) fields seem a stage-1 proposal which is currently not supported by JSDoc yet.
Once JSDoc supports it, Docma will.

Thank you,
I supposed it was a jsdoc issue. Even if not supported I hope there is a solution to avoid documentation generation to crash, because it is the automatic conversion suggested by facebook to migrate to react 15 that uses that syntax to autobind functions.
We would try to find a solutions to propose to acorn / acorn-jsx (the JS parser at the end of the chain) they can accept.

That crash/issue (with your static property example) is fixed by JSDoc v3.5.4 which is the version Docma will run with the new release.
This will also add support for arrow methods and code with most ES2015 features.
I still have some work with the new release; but won't take too long though.

@onury  any idea when a new version will be released.. I thought it would be as easy as just updating the jsdoc-x dependency but its still failing for me on arrow functions
const example = () => { }

causes an error on page load which results in a no render
Uncaught TypeError: Cannot read property 'indexOf' of undefined     at app.min.js:1     at Array.reduce (<anonymous>)     at app.min.js:1     at Object.dust.filter (docma-web.js:4)     at Chunk.reference (docma-web.js:4)     at body_0 (docma-web.js:27)     at load (docma-web.js:4)     at Chunk.partial (docma-web.js:4)     at body_33 (docma-web.js:27)     at Chunk.section (docma-web.js:4)

There are other things to be updated such as jsdom which itself also has breaking changes. I'm working on v2 (actually these are implemented already), just needs some more time for template adjustments, etc..

Supported in Docma v2.0.0.


Experiment page viewing

Similar to collections, should be tabular form

checked it and this looks to be the proper form


2.0.0 portal failure

[x] I have checked the discussions
[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
apollo portal deployed by helm, 2.0.0
fail to start
To Reproduce
Steps to reproduce the behavior:

set up the database
set up service
fail to start

Expected behavior
portal works normal
Screenshots

Additional Details & Logs

Version
Error logs
apollo-portal (13).txt
Configuration
Platform and Operating System

This is strange that oauth is enabled...would you please try 2.0.1 or 2.1.0 version?
2023-03-06 19:16:26.068  WARN 1 --- [           main] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'authConfiguration.SpringSecurityConfigurer': Unsatisfied dependency expressed through method 'setContentNegotationStrategy' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration': Unsatisfied dependency expressed through method 'setConfigurers' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration': Unsatisfied dependency expressed through method 'setAuthorizedClientRepository' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'authorizedClientRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2WebSecurityConfiguration.class]: Unsatisfied dependency expressed through method 'authorizedClientRepository' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'authorizedClientService' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2WebSecurityConfiguration.class]: Unsatisfied dependency expressed through method 'authorizedClientService' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [org/springframework/boot/autoconfigure/security/oauth2/client/servlet/OAuth2ClientRegistrationRepositoryConfiguration.class]: Unsatisfied dependency expressed through method 'clientRegistrationRepository' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'spring.security.oauth2.client-org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties': Invocation of init method failed; nested exception is java.lang.IllegalStateException: Client id must not be empty.

recreate database and redeploy services with 2.1.0, same issue occurs as below
apollo-portal (14).txt

there shouldn't be any oauth block

Hi @nobodyiam @vdisk-group , any clues or any evidence i can provide, rollback to 2.0.0 failed and it blocks our services fetching config...

please try to add this environment variable
LOGGING_LEVEL_ORG_SPRINGFRAMEWORK_BOOT_AUTOCONFIGURE_LOGGING_CONDITIONEVALUATIONREPORTLOGGINGLISTENER=trace

recreate database and redeploy services with 2.1.0, same issue occurs as below apollo-portal (14).txt
there shouldn't be any oauth block

if you don't want to use the oidc login, please clean up all properties start with spring.security.oauth2.client

Hi all, after a day's wait portal-service works as our expected in Sunday with out any changes after i removed a external-secret SPRING_SECURITY_OAUTH2_CLIENT_REGISTRATION_OKTA_CLIENT_SECRET, supposing there's should be a cache or something for the oauth properties?

the environment variable SPRING_SECURITY_OAUTH2_CLIENT_REGISTRATION_OKTA_CLIENT_SECRET is mapped to the property spring.security.oauth2.client.registration.okta.client-secret by spring boot, and trigger the oauth2 client init.
if you don't want to use the oidc login, please clean up all properties start with spring.security.oauth2.client.
for example

in xxx.properties

spring.security.oauth2.client.registration.okta.client-secret=xxx

in xxx.yml

spring:
  security:
    oauth2:
      client:
        registration:
          okta:
            client-secret: xxx

environment variable

SPRING_SECURITY_OAUTH2_CLIENT_REGISTRATION_OKTA_CLIENT_SECRET=xxx

vm options

-Dspring.security.oauth2.client.registration.okta.client-secret=xxx

vm args

--spring.security.oauth2.client.registration.okta.client-secret=xxx


What should I do if I do not need time series in the box plot chart?

I know that superset has a close connection with time series, but if I do not need such attribute and set is_timeseries = false, the box plot will be a flat line.
Instead, if I need other attributes to series data, such as customers names or countries( columns in the dataset) how can I replace time series to other attributes? For example, I plan to create a new control panel like Entity and use this panel to replace time panel (time range and time column). This may be very similar to Tableau's detail panel.
 SELECT region AS region, year AS __timestamp, sum(SP_POP_TOTL) AS sum__SP_POP_TOTL      FROM wb_health_population INNER JOIN (SELECT region AS region__, sum(SP_POP_TOTL) AS mme_inner__      FROM wb_health_population      WHERE year >= STR_TO_DATE('1960-01-01 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f') AND year <=      STR_TO_DATE('2020-07-29 08:20:11.000000', '%Y-%m-%d %H:%i:%s.%f') GROUP BY region ORDER BY mme_inner__      DESC      LIMIT 25) AS anon_1 ON region = region__      WHERE year >= STR_TO_DATE('1960-01-01 00:00:00.000000', '%Y-%m-%d %H:%i:%s.%f') AND year <=      STR_TO_DATE('2020-07-29 08:20:11.000000', '%Y-%m-%d %H:%i:%s.%f') GROUP BY region, year ORDER BY     sum__SP_POP_TOTL DESC      LIMIT 50000
As you can see, SQL queries years, what I want is to make SQL queries other attributes.
I think what I should rewrite is viz.py and boxplot control panels. But in the viz.py, I didn't find where I can replace time series and in the control panels, I did not find where to delete the time panel.
Thanks!

@cyang52 I recently thought about precisely what you're describing here. Adding an additional multi-select control (entity is as good a name as any), and then grouping by groupby + entity would make it possible to calculate the box plot statistics across all entity columns. In addition, #10344 that was recently merged makes it possible to apply the time grain on any column that is used as a grouping variable, making it possible to do the exact same temporal box plot as before, if one so wishes.
As box plot is using the legacy plugin framework, you'd need to change the control panel in the superset-ui repo, more specifically here: https://github.com/apache-superset/superset-ui/blob/master/plugins/preset-chart-xy/src/BoxPlot/controlPanel.ts. After that, you'd need to add logic in viz.py` that makes sure the entity columns are added to groupbys and then handled in the pivot operation. It is worth mentioning that we're moving away from the legacy plugin architecture, so if I were to make major changes to the box plot viz, I'd probably

port it to ECharts
make the data request using the new chart data endpoint on /api/v1/chart/data

Doing it like this you wouldn't need to add anything to viz.py, however you'd need to do all the necessary pandas transformation work using the post_processing operations.
If you need help, feel free to reach out on slack.

I checked #10344, just wondering if I do not have ds or any columns that relative to (time, year or month) , instead, I have region countries, etc. Is there any difference between before and after?
If I print out chart_data, it shows:
{'datasource': '17__table', 'viz_type': 'box_plot', 'slice_id': 58, 'url_params': {}, 'time_range_endpoints': (<TimeRangeEndpoint.UNKNOWN: 'unknown'>, <TimeRangeEndpoint.INCLUSIVE: 'inclusive'>), 'granularity_sqla': 'year', 'time_range': '1960-01-01 : now', 'metrics': ['sum__SP_POP_TOTL'], 'adhoc_filters': [], 'groupby': ['region'], 'limit': '25', 'color_scheme': 'bnbColors', 'label_colors': {}, 'whisker_options': '2/98 percentiles', 'x_ticks_layout': 'staggered', 'where': '', 'having': '', 'having_filters': [], 'filters': []}
<TimeRangeEndpoint.UNKNOWN: 'unknown'>, <TimeRangeEndpoint.INCLUSIVE: 'inclusive'>), 'granularity_sqla': 'year', 'time_range': '1960-01-01 : now',> those information I do not need and do not include in my data set columns.

@cyang52 what I'm proposing is leaving the time fields there. If the user doesn't add the timestamp column to either entity or groupby, it will not be included in the query. However, if it is, then it will affect the chart. If we do make this change, we will need to migrate the chart metadata for existing boxplot charts to add the timestamp field to the new entity field to make it work like before.

🙏@villebro can we close this issue?

@cyang52 @junlincc please see PR #11199 which should resolve this issue.


option to use pretrained embeddings/user defined values as initializer

Background and Context
option to initialize eniity and relation embeddings with user defined values (Eg, can be pretrained embeddings)
Description

Fixed by pull request #206


people: add/edit person

As a record editor, I want to add a new or edit an existing person so that I can document people associated with the Derrida Library.

Some fields I would expect might be likely things you would want for this: VIAF uri, their authorized name per viaf, birth, and death.
Possibly also: sort name (if you want to adjust sort order)
Able to associate: roles and relationships
I suspect the finalized schema from will clarify this.

Yes, we do want to be able to associate: roles and relationships. Thanks for catching that.
I will defer to Jean on the other questions.

@bwhicks Two things came up here:

We could probably ditch the "Family Group" field, since that won't really apply to the Derrida library.

I notice that under "Associated Books," the Books a person is a Creator (Author, Editor, etc.) of don't show up.  I think I understand why that's the case (because these are not relationships entered under person/book interaction), but it would be great if we could change this.  As is, when I go, for example, to Heidegger, I don't see any Associated Books.

There's another issue with Associated Books.  Under Person/Book Interaction I made Derrida the "Annotator" of "Being and Time."  But when I look at "Associated Books" for the Derrida person record, I only see this:

On this one, I'll gladly pull the family group field. It's just a matter of deleting it.
The associated books setup is probably a bit misleading for the context of this project. In Winthrop (for example) it represented a relationship like ownership of a book, etc. that didn't include annotator, creator, etc., since it was looking at a family library. I'll take some time to think about how to make this a useful inline for your purposes now that I see how you'd be using it.

@kac3 A change I have just made. We can talk today about how best to integrate author, editor, etc. Thanks for all the testing and feedback. It makes my job work!


add support for relative line numbers

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change
Add support for going to a line based on relative line numbers (deltas). This is particularly useful in combination with packages such as relative-numbers which displays the relative line numbers. The relative line numbers will be recognized by -/+/= prefixes. For example, "-4" is interpreted as go backward by 4 lines. (= is synonymous with + for convenience)

Alternate Designs

Benefits
Faster code navigation.

Possible Drawbacks
Complicates the line number parsing slightly.

Applicable Issues
#50

Is this request ready to be merged? I would love to see this feature implemented!

@H8to Yeah, as you can see that it passed all the checks. The maintainers seem slow to reply on this repo :( But you could apm install falcondai/go-to-line to use it. Feedback is much welcome!

@falcondai Will do, thanks for the advice! Maybe we brought it to their attention again :)

We can't accept a pull request of new functionality without tests. Please add tests so that we can review this further.

Hi @falcondai, thanks a lot for your contribution!
As @lee-dohm mentioned, we'll need some tests to verify the behavior that you're adding before we're able to merge this change.  Since we're currently in the process of migrating this package back into the core atom/atom repo, I'm unfortunately going to have to close this PR in the meantime.  If you're interested, please feel free to resubmit this PR to the atom/atom repo after the migration is complete and you've added some tests to verify the new behavior.
Thanks again! :sparkles:

@lee-dohm @daviwil Sorry for my late attention. Sure, that is very reasonable. I shall follow up the PR with new tests on the migrated repo.


Inconsistent entry with iPad "magic keyboard" in text input fields

Using the iPad magic keyboard I cannot input text immediately into the demo text fields. If I focus away and click around a few times or take some other actions (pasting appear to be one) it will suddenly become live and I can enter text.
On reload sometimes the keyboard works, sometimes it doesn't.
Possibly related: using the "select all" hotkey (CMD-a) results in an extra cursor being visible (see screenshot)

Is this still an issue on www.egui.rs?

I don‘t think so. I am not able to recreate this on an IPad Pro 12.9 (2020) with magic keyboard running iPadOS 15.6.1.
That being said - there are numerous issues still, such as lack of copy/paste from egui.

I don‘t think so. I am not able to recreate this on an IPad Pro 12.9 (2020) with magic keyboard running iPadOS 15.6.1.

Great, thanks for testing!

That being said - there are numerous issues still, such as lack of copy/paste from egui.

There's another issue for this: https://github.com/emilk/egui/issues/501

My apologies @emilk  - I did some more testing on this as I‘ve been using egui a lot recently. I can indeed recreate both issues in the OP, The  inconsistent text entry is only apparent sometimes, it seems. The  adding a second cursor always happens.
If I can get some time I‘ll try to look into what‘s causing it.


Test notifying reviewer

Hello @meteorcloudy, modules without existing maintainers (bazel_skylib) have been updated in this PR. Please review the changes.


Espalexa stops responding

I am using an ESP32 Andy have it all setup and it seems to work for 24-48hrs but then alexa reports device not responding check its network/power supply connections.
If I reset it it does the same again, at first I thought it may have something to do with my code means I added and TFT display and an RTC3232 along with a button with a dimmer and timer started once I pressed the button to automatically turn the light off, the timer also timed out even if alexa turned it on.
So I removed all the timing code along with the RTC, TFT and the button code so now it’s the bare minimum like the example but still get the same issue where device not responding.
I’ve seen issues reported and tried various things but still can not solve, I did see someone mention about yeild() but not sure what thus means
Thanks
Steve

Hi Steve,
probably your ESP32 disconnects from your WiFi network for some reason and doesn't auto reconnect...
You could try if adding this to your loop() helps (using the connectWifi() method from the examples):
if (WiFi.status() != WL_CONNECTED) connectWifi();

Happy holidays!
Christian

Thanks for that, I added the code and still the same.
I’ve added yield(); in the loop along with your suggestion and at the moment thus seems to working and I’m carrying out more testing.
Not sure why adding yield() as seemed to cure the problem ?


Point cloud is not in dense format, please remove NaN points first!

I used RSLIDAR to make bag, and modified config/params.yaml pointcoudtopic. When I run this bag with lio-sam, the following problem occur.
[ERROR] [1608623674.483017189]: Point cloud is not in dense format, please remove NaN points first!
How to solve this problem, please

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, I tried, I added this code to LIO-SAM/src/imageProjection.cpp, but it did not work.

Did you get any errors? Please try to provide some detailed information for reference.

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problems by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

It's a warning. Were you able to get LIO-SAM running?
The algorithm expects a custom XYZIRT pointtype for LIDAR pointcloud, where point timestamp is used for deskewing the pointcloud.

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

I downloaded the latest Robesense driver. The new driver eliminates the Nan point cloud and has XYZIRT coordinates,which R is "ring" and T is "timestamp".
link is https://github.com/RoboSense-LiDAR/rslidar_sdk

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

I downloaded the latest rslidar_sdk. The new driver eliminates the Nan point cloud and has XYZIRT coordinates,which R is "ring" and T is "timestamp".
link is https://github.com/RoboSense-LiDAR/rslidar_sdk

I see, but I have been unable to collect any more data recently for some reason :(

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

Did you get any errors? Please try to provide some detailed information for reference.

I have solved the previous problem by other methods, but I have encountered new problems
[ WARN] [1608712876.194493172]: Point cloud timestamp not available, deskew function disabled, system will drift significantly!
sad

Hello! Could you tell me what method you use to solve the NaN points problem?

I downloaded the latest rslidar_sdk. The new driver eliminates the Nan point cloud and has XYZIRT coordinates,which R is "ring" and T is "timestamp".
link is https://github.com/RoboSense-LiDAR/rslidar_sdk

Excuse me, after you add the code：
vector indices;
pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);
is there no error in the compilation?

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

It still wrong

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

After add std::vector, still not working

u need to add #include "pcl/filters/impl/filter.hpp first

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

After add std::vector, still not working

@z1047941150 u need to add #include "pcl/filters/impl/filter.hpp" first

Thanks dude, I wil try it later.

Zhihao Zhang
@.***

------------------ 原始邮件 ------------------
发件人: "Lumo @.>;
发送时间: 2021年12月28日(星期二) 下午5:59
收件人: @.>;
抄送: "Zhihao @.>; @.>;
主题: Re: [TixiaoShan/LIO-SAM] Point cloud is not in dense format, please remove NaN points first! (#175)
Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
// remove Nan         vector<int> indices;         pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);         // check dense flag         if (laserCloudIn->is_dense == false)         {             ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");             ros::shutdown();         }
This should work.
Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？
it should be std::vector
After add std::vector, still not working
@z1047941150 u need to add #include "pcl/filters/impl/filter.hpp" first
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

After add std::vector, still not working

@z1047941150 u need to add #include "pcl/filters/impl/filter.hpp" first

Thanks, dude. It works， but I have a question.
Lego-loam used this function too, why could work without adding  #include "pcl/filters/impl/filter.hpp"?

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

After add std::vector, still not working

@z1047941150 u need to add #include "pcl/filters/impl/filter.hpp" first

Thanks, dude. It works， but I have a question. Lego-loam used this function too, why could work without adding #include "pcl/filters/impl/filter.hpp"?

Perhaps Lego-loam includes other libraries.

Have the same issue. Adding
#include "pcl/filters/impl/filter.hpp"
vector<int> indices;
pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

helped a bit, but after that i'm getting this
[ERROR] [1643635462.415513074]: Point cloud ring channel not available, please configure your point cloud data!
Any clues?

@DaddyWesker are you able to solve the ring issue?

@arjunskumar  unfortunately, no

Ring means the order of the beams. if your lidar is vlp-32, you will get 32 beams and each point will add the data which beam it belongs to. But some lidar didn't add this data to echo point, like RS-Lidar-32. So we should use other program to modify it, for example:https://github.com/EpsAvlc/rslidar_to_velodyne

@DaddyWesker Same with the  please remove NaN points first problem, it because of  the different lidar data formats of the different lidar manufacturer.

@DaddyWesker @arjunskumar
Ring means the order of the beams. if your lidar is vlp-32, you will get 32 beams and each point will add the data which beam it belongs to. But some lidar didn't add this data to echo point, like RS-Lidar-32. So we should use other program to modify it, for example:https://github.com/EpsAvlc/rslidar_to_velodyne

@z1047941150 yes I manged to get the ring info , but not able to run on my dataset as IMU and Lidar were not calibrated.

@arjunskumar well... Maybe because of the rate of IMU message... I didn't calibrate my IMU and Lidar too, but the program worked well.

@z1047941150 have you used lidar from robosense or the velodyne one?

@arjunskumar yes,RS-Helios-32

if you dont mind, could you share your bag file @z1047941150 ?

@z1047941150 I have the same lidar with me.  It would be really helpful to see your configuration

@arjunskumar I‘m sorry. Due to work regulations, I can't share it :(

@z1047941150 i can see this code uses 16 beams, if I change it to 32 and give those information to LIO-SAM, RS-Helios-32 should work right?

@arjunskumar no, you should change the params.yaml.

@z1047941150 I'm using simple Kitti dataset. As i know, it's velodyne.

@z1047941150 I tried converting the lidar but IMU outputs only at 50Hz. The author has recommended at least use 200 Hz IMU. Can you check the frequency of your IMU and update me ?
Attaching my output for your reference

@arjunskumar  when I use IMU at 10HZ, it's output as same as yours and had bad performance when the robot tunring. Now I using 200hz, the output is very perfect.

@DaddyWesker Maybe something wrong in the params.yaml?

@z1047941150 Can you tell me what changings are needed to be made in the params.yaml file? should i need to change my topics names only? and i want to know where is this odometry/imu coming from? is this the topic published as a result of LIO-SAM? Are there any changings need to be made in .cpp files?  I am using same RS Helios 5515.

@z1047941150 Thanks for the reply! Actually my data is coming from a rosbag file and there i have tf, imu. and rslidar topics. The data is recorded in real time and i want to know how to modify the package for my usage? Do i have to change the .cpp files? I couldn't understand the scripts for param.yaml. Would highly appreciate if you could help me

@z1047941150 Thanks for the reply! Actually my data is coming from a rosbag file and there i have tf, imu. and rslidar topics. The data is recorded in real time and i want to know how to modify the package for my usage? Do i have to change the .cpp files? I couldn't understand the scripts for param.yaml. Would highly appreciate if you could help me

nothing need to be changed in package or .cpp files. The only thing you need to do is just convert it.

Okay I will try and will let u know if any problem occurred. Thanks so much again for the help!!

@z1047941150 So after converting i would be getting my data on this topic /velodyne_points So wouldn't i need to change points_raw topic or imu etc in the package Like my point cloud topic would become /velodyne_points and imu topic would become imu/data because thats the topic my rosbag is publishing on.

Your pointcloud has NaN points. You need to clean your pointcloud. Add the following to imageProjection.cpp node:
        // remove Nan
        vector<int> indices;
        pcl::removeNaNFromPointCloud(*laserCloudIn, *laserCloudIn, indices);

        // check dense flag
        if (laserCloudIn->is_dense == false)
        {
            ROS_ERROR("Point cloud is not in dense format, please remove NaN points first!");
            ros::shutdown();
        }

This should work.

Hi, After I add the above code, I get this error：
Undefined reference to void pcl::removeNaNFromPointCloud(pcl::PointCloud const&, pcl::PointCloud&, std::vector<int, std::allocator >&)
Why？

it should be std::vector

After add std::vector, still not working

@z1047941150 u need to add #include "pcl/filters/impl/filter.hpp" first

Thanks, dude. It works， but I have a question. Lego-loam used this function too, why could work without adding #include "pcl/filters/impl/filter.hpp"?

Hey @z1047941150 can you tell me how did you make that work? I added those lines in image Projection.cpp module but i am still gfetting this error:
[ERROR] [1689602770.451085416]: Point cloud is not in dense format, please remove NaN points first!

Try

The latest rslidar_sdk include ring and timestamp data field, you might have to rename timestamp to time, I am not sure is the ring sharing the same meaning.
For NaN issue, you might try setting dense_points = true as shown here


elmPackages.{elm-language-server,create-elm-app,elm-optimize-level-2}…

Motivation for this change
routine update of elm language tooling.
updated

elm-language-server
create-elm-app
elm-optimization-level-2

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@domenkozar once you have a sec I think this is good to go.

@GrahamcOfBorg build elmPackages


Add Lightline theme

Now using the defined palettes.
Modes:

Tabline:

* All the zeros are for `cterm` colors, right?

Yes, I didn't try to emulate these colors in cterm, probably a disclaimer would make sense.

* Can lightline tell the difference between visual and block-visual?

No, Visual, V-Block, V-Line are all colored by s:p.visual

* Could normal mode use a simpler gray color? I'm used to a very simple status line, but if other colorschemes use colors for normal node, then I guess it's fine.

I was using the gruvbox theme for a long time before I switched to melange, and so I tried to emulate the color choices of its status line here. Btw, most of the included themes have non-gray normal mode colors: https://github.com/itchyny/lightline.vim/blob/master/colorscheme.md

I'd maybe swap visual and replace, so insert and replace both use warm colors.
I, personally, use the visual mode most often to select an arbitrary section, and then change that via c, so for me the stronger yellow color makes a lot of sense here. On the other hand, I never ever used Replace mode :D How about meeting in the middle: let's change "replace" to magenta?

Ok. Then the changes I'd suggest are:

Use light gray for normal mode.
Use magenta for replace mode.
Use green or cyan for command mode.

It's not possible to config the Command mode with Lightline, it seems. I've applied your other suggestions.

Perfect. Thanks @Nandax00 for the PR!


Allow  to be used outside of Router, add warning

Fixes #3889
Previously, using a Link outside of the Router would break the program. The breaking was caused by the inability to find location when outside of the router context. This PR fixes that by checking if the context contains the router, and if not, marking "isActive" as false by default. This introduces the assumption that all  outside of the router are not active.
This also adds a warning to indicate that the user is using the  is being used outside of the error. I am not exactly sure what copy to use in the error.
As of right now, since there is no invariant in handleClick, a  can be "used" outside of a router. It simply reloads the page based on the href.
This is my first time contributing, so let me know if there is anything else that needs to be changed or added to resolve this issue.

Should I add an invariant in handleClick to prevent links from being clicked if they are outside of the Router? If so, it shows the error and then stills goes to the new page because of the href value.

let's just not handle clicks and not check isActive without a router in
context.
On Sat, Sep 17, 2016 at 3:49 PM Connor Elsea<EMAIL_ADDRESS>wrote:

Should I add an invariant in handleClick to prevent links from being
clicked if they are outside of the Router? If so, it shows the error and
then stills goes to the new page because of the href value.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/pull/3896#issuecomment-247812867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaCyTAo-SdGv8yzjZWfxiGz7WHFntks5qrG5-gaJpZM4J_uhR
.

(was intended but just an oversight)
On Sat, Sep 17, 2016 at 5:40 PM Ryan Florence<EMAIL_ADDRESS>wrote:

let's just not handle clicks and not check isActive without a router in
context.
On Sat, Sep 17, 2016 at 3:49 PM Connor Elsea<EMAIL_ADDRESS>wrote:

Should I add an invariant in handleClick to prevent links from being
clicked if they are outside of the Router? If so, it shows the error and
then stills goes to the new page because of the href value.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ReactTraining/react-router/pull/3896#issuecomment-247812867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGHaCyTAo-SdGv8yzjZWfxiGz7WHFntks5qrG5-gaJpZM4J_uhR
.

@ryanflorence Do we want to warn users that it is not handling clicks? If so, where, onClick? Because when you click on a Link outside of a Router it still clicks and goes to the href.

Rebased to remove the warning. Now this commit refactors the method signature of getIsActive to allow for the sniffing of router context. Then getIsActive returns false if the router is not available on the context. It does this without any warning to the user. This also refactors away verbosity from the className assignment when returning the final anchor tag.
As of right now clicking on this link outside of the router just follows its href. It seems like there is no problem occurring with handling onClick.

Hey @timdorr and @ryanflorence, I have iterated on this and feel as if I have found a solution that will benefit users.
Fixes in
When outside of a <Router> parent context, <Link>s now do the following:

In handleClick(): Perform onClick if it is explicitly specified as a prop to a <Link>
In handleClick(): Warn after onClick action that there is no <Router> parent
In handleClick(): Prevent router.transitionTo from happening (due to no router context)
In render(): If no router, set isActive to false

Effect of these changes
A <Link> that somehow ends up outside of a router will still function as normal. It will load pages based on the href or a supplied onClick method. Yet it will not perform the transitions or check the links "activeness" as it attempted to do previously, which caused errors. Since some of the expected features are missing, and placing a  outside of the Router may cause un-intended affects, the user should be warned that these feature omissions are occurring.
Questions

How should I go about issuing this warning to users. console.warn causes a build fail

@ryanflorence I made the suggested changes, but will have to look into why the tests failed. It is working perfectly fine for me locally when I build my changes and test RR using my build.

Was it testing that the activeStyle is applied when not in the Router context? If so, these tests now fail because active is assumed to be false when there is no Router context.

@Connorelsea I'm going to close this out, as I think we're close to good with the current version. Once #3986 lands, it basically does the same thing. But it's updated against recent changes. If it doesn't work, we'll need to rebase and refactor this branch anyways.


Algorithm produces different data outputs between NASA and ESA

Due to #7, it was discovered that, given the same inputs, there are discrepancies between the results produced by running the algorithm in the NASA and ESA environments.
In addition to using this algorithm to gather profiling metrics from the 2 environments, we also want to make sure we can produce the same results.
See attached slides detailing @nemo794's initial investigation into the output discrepancies: NASA-ESA get-dem discrepancy.pptx

@nemo794 and @arthurduf, I did some investigation into this issue, and as I suspected, the difference in outputs between NASA and ESA (including the reason for the exception described in #7) is due to differences in Python package dependencies.
Here's what I did to confirm this:

I enhanced the ESA Dockerfile to install conda and install dependencies from environment.yml instead of using pip to only install a couple of dependencies.
I changed the use of np.linalg.pinv back to np.linalg.inv, which would cause the ESA version to fail again, if the change in dependencies did not have an impact.
I reran the algorithm (locally) for both NASA and ESA using the bbox -156 18.8 -154.7 20.3, which is the bbox that caused the exception in ESA (per #7).
The ESA version did not raise the exception, which was the first indication that the dependencies are a factor.
I compared the cksum between the NASA and ESA dem.tif files, and found them to be identical.

Therefore, I suggest that in order to be confident that running an algorithm in both systems with the same inputs will produce the same outputs, we must use the same dependencies and install them with the same dependency manager in both environments.
@arthurduf, is there any reason you chose not to use conda in the Dockerfile? Is there anything in the ESA environment that would prevent you from doing so?


Flushbar Package development issue

I have a Flutter package that is presenting some weird behavior on iOS but it is working fine on Android even though I have no distinct platform code inside. Please, take a look at the following issue.
This looks like a Flutter bug. If not, can someone shed some light over the issue, please?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Update how-to-use-automated-ml-for-ml-models.md

Added Explain best model and removed concurrency option as it is moved out of addition configuration to Limits Optional Point. Will be adding Limits Option in my next Pull Request.

UI screenshot of the edit proposed.

Proposed edit with the UI screenshot.

@manashgoswami
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Objects365+COCO

First of all, congratulations on pushing the field forward!
Currently, D-FINE supplies checkpoints that are pretrained on Objects365 before being finetuned on COCO. In this way, they get significant performance improvements, better than the DEIM checkpoints that just use COCO. Are you planning to do the same for this project?
Thanks for open sourcing this great work!

Thank you so much for your recognition of our work! We hope this is helpful to you. This project is dedicated to building a foundational DETR training framework to accelerate progress in this field.
The issues you mentioned are already on our To-Do List, and we’re also actively working on V2. If you’re interested, we’d love for you to keep an eye on our repository for updates.

Okay that is great! I'll certainly be watching!


PR: Optimise Spyder

Description of Changes
Small changes that improve the response time of spyder to keystrokes.

Remove if self._editor is None check because we return None anyway, so the check is useless.
Cache the width of the linenumber widgets. It was recomputed at each frame, which was slow. Cache updtaed on number of lines changed or font changed.
_update was repetitively checking the cursor position. However the code doesn't modify the position so it only needs to be checked once.
no need to setViewportMargins if the margin did not change
self.get_text('sof', 'eof') appears to be slower than super(TextEditBaseWidget, self).toPlainText() for the same result.
Calling pattern.search(line) repetitively takes more time than using pattern.finditer(line)
osp.realpath is really slow. Only call if needed.
Setting the focus to the widget that already has the focus isn't useful.
Avoid moving the focus to the console when running a cell, because it must then immediately be moved back.
Don't set the cwd to the current cwd as it is already the cwd.
The entire text of the editor is turned to a list and back to a string. Avoid the list step. That also adds a list of line terminator that are useful for other functions.
Don't stop the spinner repetitively. Only stop it once.

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #https://github.com/spyder-ide/spyder/issues/16865
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/editor/widgets/codeeditor.py:

Line 1103:80: E501 line too long (86 > 79 characters)
Line 1152:80: E501 line too long (83 > 79 characters)
Line 2387:5: E265 block comment should start with '# '
Line 2390:50: E227 missing whitespace around bitwise or shift operator
Line 2401:50: E227 missing whitespace around bitwise or shift operator
Line 2520:5: E265 block comment should start with '# '
Line 2683:42: E502 the backslash is redundant between brackets
Line 2712:5: E265 block comment should start with '# '
Line 2902:1: W293 blank line contains whitespace
Line 3241:5: E265 block comment should start with '# '
Line 3279:5: E265 block comment should start with '# '
Line 3615:80: E501 line too long (81 > 79 characters)
Line 3670:80: E501 line too long (90 > 79 characters)
Line 3672:80: E501 line too long (86 > 79 characters)
Line 3738:80: E501 line too long (80 > 79 characters)
Line 3770:28: E128 continuation line under-indented for visual indent
Line 3771:68: E502 the backslash is redundant between brackets
Line 3784:67: E502 the backslash is redundant between brackets
Line 3814:80: E501 line too long (80 > 79 characters)
Line 3995:29: E222 multiple spaces after operator
Line 4004:28: E124 closing bracket does not match visual indentation
Line 4052:5: E265 block comment should start with '# '
Line 4133:5: E265 block comment should start with '# '
Line 4175:80: E501 line too long (83 > 79 characters)
Line 4662:17: E731 do not assign a lambda expression, use a def
Line 4675:17: E731 do not assign a lambda expression, use a def
Line 5241:80: E501 line too long (80 > 79 characters)
Line 5289:5: E265 block comment should start with '# '
Line 5321:5: E265 block comment should start with '# '
Line 5461:80: E501 line too long (80 > 79 characters)

In the file spyder/plugins/editor/widgets/editor.py:

Line 290:17: E128 continuation line under-indented for visual indent
Line 1238:41: E711 comparison to None should be 'if cond is None:'
Line 1367:80: E501 line too long (80 > 79 characters)
Line 1504:13: E731 do not assign a lambda expression, use a def
Line 1777:26: E124 closing bracket does not match visual indentation
Line 1778:27: E131 continuation line unaligned for hanging indent
Line 1779:27: E131 continuation line unaligned for hanging indent
Line 1886:41: E127 continuation line over-indented for visual indent
Line 1962:37: E128 continuation line under-indented for visual indent
Line 1963:37: E128 continuation line under-indented for visual indent
Line 1964:37: E128 continuation line under-indented for visual indent
Line 1965:37: E128 continuation line under-indented for visual indent
Line 2074:41: E127 continuation line over-indented for visual indent
Line 2091:5: E265 block comment should start with '# '
Line 2396:9: E265 block comment should start with '# '
Line 2994:80: E501 line too long (80 > 79 characters)
Line 3007:21: E128 continuation line under-indented for visual indent
Line 3008:21: E128 continuation line under-indented for visual indent
Line 3009:21: E128 continuation line under-indented for visual indent
Line 3111:31: E201 whitespace after '('
Line 3112:51: E202 whitespace before ')'
Line 3175:25: E128 continuation line under-indented for visual indent
Line 3176:25: E128 continuation line under-indented for visual indent
Line 3329:25: E201 whitespace after '('
Line 3329:38: E202 whitespace before ')'
Line 3333:23: E201 whitespace after '('
Line 3333:36: E202 whitespace before ')'
Line 3336:31: E201 whitespace after '('
Line 3337:51: E202 whitespace before ')'
Line 3360:43: E261 at least two spaces before inline comment

Thanks, @impact27 ! Would be cool to see some benchmarks, if there's anything consistently measurable you can find.

Do you know of a good way of including benchmarks? It could be interesting to keep track of a few things in the CI maybe?

In the internal console:
This PR:
# Running in codeeditor.py
>>> timeit.timeit("spy.window.editor.zoom(1); spy.window.editor.zoom(-1)", number=3, globals={"spy":spy})
4.640133099999957
>>> timeit.timeit("PyQt5.QtTest.QTest.keyClick(spy.window.editor.get_focus_widget(), 'w')", number=100, globals={"spy":spy, "PyQt5": PyQt5})
0.5205837999999403
# Running in empty file
>>> timeit.timeit("spy.window.editor.run_cell()", number=100, globals={"spy":spy})
0.024335500000006505

5.x
# Running in codeeditor.py
>>> timeit.timeit("spy.window.editor.zoom(1); spy.window.editor.zoom(-1)", number=3, globals={"spy":spy})
7.019444599999986
>>> timeit.timeit("PyQt5.QtTest.QTest.keyClick(spy.window.editor.get_focus_widget(), 'w')", number=100, globals={"spy":spy, "PyQt5": PyQt5})
2.3932132999999993
# Running in empty file
>>> timeit.timeit("spy.window.editor.run_cell()", number=100, globals={"spy":spy})
1.7612139999999954

So 1.5x speed-up for zooming, 4.5x speed up for writing text, 72x speed up for running cells (only the overhead)

https://github.com/spyder-ide/spyder/pull/15372 is already useful :)

Do you know of a good way of including benchmarks? It could be interesting to keep track of a few things in the CI maybe?

Airspeed Velocity; I think this is what CPython, PyPy and some other scientific packages use

So 1.5x speed-up for zooming, 4.5x speed up for writing text, 72x speed up for running cells (only the overhead)

Nice! Glad to see; its not always easy since some PRs in the past that we thought would improve performance had no effect, or sometimes even caused it to regress, heh

As a quick, informal but practical/functional user test, I also often measure the max typing speed holding down one key (chars/s over 100 chars; which, at least in past versions, could vary by several times and be heavily constrained by Spyder performance rather than key repeat rate), the rate of moving lines up or down (lines per second over 1000 lines), and the undo/redo rate, plus a few others. These metrics are key in regulating how "snappy" and responsive Spyder feels to an average user, and historically have been many times lower than other editors (e.g. Notepad++).

Fast:
>>> timeit.timeit("PyQt5.QtTest.QTest.keyClick(spy.window.editor.get_focus_widget(), PyQt5.QtCore.Qt.Key_Enter)", number=100, globals={"spy":spy, "PyQt5": PyQt5})
3.0736162999999124
>>> timeit.timeit("spy.window.editor.get_current_editor().undo(); spy.window.editor.get_current_editor().redo()", number=100, globals={"spy":spy})
5.136109799999986

5.x
>>> timeit.timeit("PyQt5.QtTest.QTest.keyClick(spy.window.editor.get_focus_widget(), PyQt5.QtCore.Qt.Key_Enter)", number=100, globals={"spy":spy, "PyQt5": PyQt5})
4.196703599999864
>>> timeit.timeit("spy.window.editor.get_current_editor().undo(); spy.window.editor.get_current_editor().redo()", number=100, globals={"spy":spy})
6.325618500000019

1.4x faster for returns, 1.25 for undo/redo

With caching of bookmarks and breakpoints:
>>> timeit.timeit("spy.window.editor.get_current_editor().undo(); spy.window.editor.get_current_editor().redo()", number=100, globals={"spy":spy})
3.349273999999994

2x faster undo/redo

Nice! Fantastic, @impact27 .

Hey @impact27, thanks for all your work on this! It's really impressive!!
For now I only have one suggestion for you: please remove from your last two commits (i.e. cc27158 and
4231213) the changes related to document_did_change. The thing is right now I'm also working on using a timer to trigger didChange requests, but my approach is different from yours and I think it's the right one. I mean, I also tried your approach and unfortunately it can make that the file contents are not synced correctly with the contents saved in the PyLSP (which could be the cause of our tests failures).
Instead of calling document_did_change to update to the document contents manually, we can connect the timer to the textChanged signal of QPlainTextEdit, make the timer call document_did_change and remove all calls to that method. That solved the unsynced problems for me.

Instead of calling document_did_change to update to the document contents manually, we can connect the timer to the textChanged signal of QPlainTextEdit, make the timer call document_did_change and remove all calls to that method. That solved the unsynced problems for me.

So you would still use a timer? I think the problem is the ordering of the calls to LSP. Doing them syncronously with the KeyPressEvent introduces a lot of percieved lag. I tried to only put document_did_change on a timer but I think there is an issue with the ordering of the calls.  So I see two problems:

The calls to LSP should not be syncronous with the KeyPressEvent
The ordering of the calls should be preserved

@ccordoba12 I tried something here: https://github.com/spyder-ide/spyder/pull/16911

I tried something here: #16911

Thanks for your help with that @impact27! Let's continue the discussion about those improvements on that PR.

@impact27, I think you still need to address the two regressions @steff456 mentioned above:

A thing that I noticed while playing around in this branch is that the highlight is taking some time to paint

Perhaps for this we could be solved by shortening the timeout of _rehighlight_timer. Or we could even leave that for another PR to investigate further how to improve it.

Also, I'm not sure why once I use the find option and delete the text in the find, the text is still highlighted until I focus the editor and type something,

This is a serious UI/UX regression. Perhaps it's related to the introduction of _rehighlight_timer too (not really sure though).

@ccordoba12 , as I stated and I believe @dalthviz confirmed in our reviews, both of those do not appear to be regressions with this PR, as they were identically reproducible on 5.x, with the same behavior and lag time observed down to the measuring accuracy (0.2-ish s). I would suggest opening new issues about those, including the information in @steff456 's and my reports.

Actually @ccordoba12 , as I stated and I believe @dalthviz confirmed in our reviews, both of those do not appear to be regressions with this PR, as they were identically reproducible on 5.x

Oh, so sorry! I'll try to read your comments more carefully for next time.
Then I'll wait for another review from @steff456 and @dalthviz. If they approve this one, I'll merge it.

No worries @ccordoba12 ^_^ , I realize I could have made it more clear. Do you want me to open new issues about the UI issues @steff456 , @dalthviz and I found? NB, I can repro them on 5.1.5 as well. I think the first thing is not really an issue though, since IIRC based on my feedback you set the timer like that (1s-ish timed from keyboard idle, I believe) a while ago to prevent major searching/painting lag when typing common search queries in longer documents. It personally doesn't really bother me too much, though a bit shorter might be better without affecting responsiveness too much.

Do you want me to open new issues about the UI issues @steff456 , @dalthviz and I found?

Yes, please do. Thanks for your help with that!

Thanks! Opened as #16948 , I imagine @steff456 or @impact27 might be good people to look into it

I see how it is @ccordoba12 :sob:
In all seriousness, thanks @impact27 and awesome to see this merged!

Haha, sorry, I forgot about your review. Thanks for your contribution too!


Rewrote DNS on GO

Rewrote dns server on GoLang and added a lot of features.
Features:

Optimized (Loads like 1k domains instantly on /domains)
Config file (Dont have to restart for everything)
Registrar API keys (Give third party registrars api keys that bypass global ratelimit / ddos)
Ratelimit Per Registrar key (Can set diff ratelimits depending on the size of the registrar)
Owner (Logs who created domain and who owns the api key)
Ratelimits (Protects against ddos attacks and domain botting)
Moderation (Features a FREE AI model that can check if a domain is inappropriate)
Anti Spam (Features another FREE AI model that can check if a domain is botted/spammed)
Dynamic Anti Spam (The more domains created last hour = the more sensible it becomes)
Better api home (Gives some info for devs)
Cloudflare Option (can toggle cloudflare, on and off, dont have to change the code)
IP Checks (Will only accept valid URLs or IP addresses)

Todo:

/domains per pages
/scrap - for browsers

Test it out:
https://domains.upioti.com/
(Running on my pc, wont be for long)

Test it out:
https://domains.upioti.com/
(Running on my pc, wont be for long)

Is domains meant to share the secret keys ?

Also is that 8 character indentation?

Test it out:
https://domains.upioti.com/
(Running on my pc, wont be for long)

Is /domains meant to share the secret keys ?

Its a known issue, very easy to fix but considering theres another dns recode PR i would fix it only if this gets selected

We've got 3 PRs now to rewrite the DNS backend. This, #142 and #143. We need to decide which one of these solutions we like the most. I personally am of the opinion that the backend being in Rust makes more sense for this application given that a majority of the stack is already Rust, but I'm not against Go either. We'll leave it to maintainers and @face-hh to determine what solution they feel is best.

Small issue i noticed is that the moderation api doesn't retry if the reposne isnt the correct format

Small issue i noticed is that the moderation api doesn't retry if the reposne isnt the correct format

Well we are ratelimited to 30 requests a minute (on the free plan) so i dont wanna waste requests if the model is acting up and not sending json

Superseded by #142


OrderPayerTokenAccount and CoinWallet are confusing

The issue arrises from the fact that OrderPayerTokenAccount changes between quote and the base currency token accounts based on whether buying or selling is happening. Whereas coinWallet is always the same in both situations.
Why not just have separate baseWallet and quoteWallet that are permanently there?
pub struct MarketAccounts<'info> {
    #[account(mut)]
    market: AccountInfo<'info>,
    #[account(mut)]
    open_orders: AccountInfo<'info>,
    #[account(mut)]
    request_queue: AccountInfo<'info>,
    #[account(mut)]
    event_queue: AccountInfo<'info>,
    #[account(mut)]
    bids: AccountInfo<'info>,
    #[account(mut)]
    asks: AccountInfo<'info>,
    // The `spl_token::Account` that funds will be taken from, i.e., transferred
    // from the user into the market's vault.
    //
    // For bids, this is the base currency. For asks, the quote.
    #[account(mut)]
    order_payer_token_account: AccountInfo<'info>,
    // Also known as the "base" currency. For a given A/B market,
    // this is the vault for the A mint.
    #[account(mut)]
    coin_vault: AccountInfo<'info>,
    // Also known as the "quote" currency. For a given A/B market,
    // this is the vault for the B mint.
    #[account(mut)]
    pc_vault: AccountInfo<'info>,
    // PDA owner of the DEX's token accounts for base + quote currencies.
    vault_signer: AccountInfo<'info>,
    // User wallets.
    #[account(mut)]
    coin_wallet: AccountInfo<'info>,
}

Although much better from a dev ux perspective, I'm not a big fan of adding this because it adds an extra key to the instruction, which matters a lot when composing with the dex, since it's easy to go over the transaction size limit.

It shouldn't add an extra pubkey really? In the case of buying the coin it should have the same number of accounts, and in the case of selling the coin, yes it does use one extra because in that scenario normally OrderPayerTokenAccount and coinWallet are the same pubkey.


[Feature] Complex web page fetcher

Is your feature request related to a problem? Please describe.
Many web pages are hidden behind logins, forms and inside web apps.
To monitor such pages, a script is needed to describe complex interactions with the browser.
Describe the solution you'd like
A few possibilities

Add a new "external" fetcher that execute a command and read the page content, return code and headers from 3 files.
Plugins
Enable the user to add some code in the  sync_playwright() function with  some exec()

Of course these solution are not suitable for a public subscription.
My current work around is :

Every 5 minutes, fetch some deep web page with a playwright script
Save it on a web server
Monitor this with changedetection.io

Additional context
I could not find any other open source project with such a feature
There is this commercial product: https://deepwebmonitor.com/post/visualping-vs-wachete-vs-versionista-vs-deepwebmonitor-for-website-change-monitoring/

https://github.com/dgtlmoon/changedetection.io/pull/478   does that help? :)
closed - duplicate


fix compatible with ubuntu sh - #582

Current coverage is 40.87% (diff: 100%)

No coverage report found for master at f83cd30.

Powered by Codecov. Last update f83cd30...c04e0b6

LGTM


Keep rendering context window size in sync when resizing

Fixes #67280.
On X11 we rely on ConfigureNotify event to update rendering context window size, but we don't get such event when resizing programmatically, only when done "manually" by resizing the window etc.

Thanks!


Collapse block doesn't work

Logseq 0.6.5 Linux Appimage
logseq-plugin-vim-shortcuts 0.15
When I try to collapse block using zm nothing happens.
But zo (Extend block) works good

I have the same issue too.
Logseq 0.6.5 on linux
logseq-plugin-vim-shortcuts 0.15

I can reproduce this issue, seems related to Logseq API, I will let Logseq team know about this, but not sure when to solved, I think once it's fixed by Logseq Team, the function will be back automatically.

I can reproduce this issue, seems related to Logseq API, I will let Logseq team know about this, but not sure when to solved, I think once it's fixed by Logseq Team, the function will be back automatically.

Thanks I got it. I closed this issue and I'll be waiting for a fix from Logseq team.
Thanks a lot for a great plugin. I missed him a lot!

Logseq has fixed it after v0.6.7, please upgrade Logseq.

It works, thanks!


Error when compiling in linux

when I compile the project I get an error in the file "babylon/core/nullable.h" with the message error: ‘BABYLON::Nullable::_value’ has incomplete type
T _value;
I can not find the solution Thank you

Should be resolved now (some includes were missing). I am currently working on getting the examples working again due to all the changes for BabylonJS 3.2.0. The ShaderMaterial examples are working now but the other ones need further investigation. I will keep you update on my progress.


KeyboardKit crashed when using AutoCompleteToolBar

I got a frustrated problem from the library, I'm currently using the newest version (KeyboardKit v7.0.0)--

After I commented this code, but the SystemKeyboard seemingly abnormal interactive and return nothing
https://user-images.githubusercontent.com/59305441/222480996-fae6249a-ffad-401b-a45a-f16d6393f9b5.mov

Hi @Unix-test
That's strange - I tested this in the demo keyboard and it works:

Running the demo uses the locale of the environment context:

How are you using this view? If you are using it from your controller's setup function, it should work. And you should use that controller in the initializer, not create a new one.
Can you take a look at the demo keyboard and see if that works?

If you do any custom stuff and don't call the controller's setup(with:), you must inject the environment objects into the view hierarchy, since this is done by the setup function.
Do you mean that the demo's original code crashes, or your custom code in the demo?

If you do any custom stuff and don't call the controller's setup(with:), you must inject the environment objects into the view hierarchy, since this is done by the setup function.
Do you mean that the demo's original code crashes, or your custom code in the demo?

In the picture that I listed above, I just copy the demo code into Content View for testing first, which meant it was nothing more the purest code getting from example. However, when I placed it inside some screen view ( like when I create a new project, there is a sample screen “hello world”). It just crashed like what is in the picture. Plus, I tried to remove controller label and left it like this => SystemKeyboard(), but Xcode keep demanding, controller should be in place like this => SystemKeyboard(controller: …),   without controller initialization, Xcode wont compile my app
To sum up, there are 2 problems
1./ the demo codes for SystemKeyboard not working ( crashed at first run)
2./ abnormal behaviour of SystemKeyboard just like what is in my screen recorded video

@Unix-test In your first video, are you adding the system keyboard to the screen without using a keyboard extension?

The reason the environment object crashes and the observed one doesn't, is that you don't get the environment object injected automatically if you don't use the input controller's setup function. If you setup the system keyboard in another way, you must setup its dependencies manually.
And for your last screenshot, you either need an input view controller, which you get in a keyboard extension, or you need to use the system keyboard initializer with more parameters.

@Unix-test In your first video, are you adding the system keyboard to the screen without using a keyboard extension?

Yeah, as I mentioned aboved, I placed it in inputView  of UITextView, I disabled ios systemKeyboard by assign inputView = UIView, so then UIView will become the firstResponder, when UIView is hide it wont cause UITextView forcibly resign itself and keep the cursor or my text selection is still available


Add ability to record "recieved time"

Do we want to record the time a string was received by the server as a very rough verification of the logger clock?

Is there a particular use case for this that you had in mind? There is nowhere in the underlying ODM2 database to store this information.

We've been keeping the server time in our current configuration.  I think right now Shannon is using it for convenience for plotting, but I don't know if it's really needed for anything else.


Move Content To Mammotome SharePoint

In order to secure the website content under Mammotome's control the content eventually needs to be move to Mammotome's SharePoint. This is no go-live blocker.

[ ] Configure Mammotome SharePoint (SP) as per http://hlx.live/docs/setup-customer-sharepoint (Mammotome)
[ ] Copy content from Adobe SP to Mammotome SP (Adobe / Mammotome)
[ ] Switch fstab.yaml to point to Mammotome SP (Adobe)

For handling Forms attachments use cases we need perform few more steps

[ ] Create a technical account ( new user in Mammotome domain).
[ ] Provide write access to technical account on attachment folder.
[ ] Update Submit worker to use newly created technical account.
[ ] If required update Azure App to use any organization directory.


Use it as an IDE

Hi,
Thanks for the great tool.
I am thinking that it would be great to use the debugger as a code editor. I could add folders to the workspace right clicking the sources tab but I couldn't make it catch the debugger. And the folders are not saved through executions.
I know this may be a load of work, but it would be a nice feature to have.
Cheers,
Javi

Yes, see #27. We are blocked on Electron, but this feature would be pretty huge. Feel free to explore alternatives; it may be possible to shim the Node internals/requires to get certain things working.

Could this be done as an atom plugin?

Hmm not sure how that would work, but feel free to explore. :smile:

You can use devtool as IDE.
Need add your project in Workspace , then map any local js file to identical remote file in file:// section.
Refresh, and you can at the same time edit files and debug it. ;)
Even, you can use any other language with sourceMap support, for example LiveScript. And programming, as like in native javascript.


Sub-subdomain troubles

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
A clear and concise description of what the bug is.
We have the following project structure:

Core: (contains xyz.com and subdomains point to the namespaces in the other projects)
Dev: (contains a DNS zone dev.xyz.com and a service account that is in GKE cluster that can modify domain dev.xyz.com domain)
Staging: (contains a DNS zone staging.xyz.comand a service account that is in GKE cluster that can modify domain staging.xyz.com domain)

This is so that we can limit IAM access and have api.dev.xyz.com and backoffice.dev.xyz.com
The Cert-manager is returning the error:
challenges controller: Re-queuing item "default/api-env-xyz-com-1171685514-0" due to error processing: No matching GoogleCloud domain found for domain xyz.com.
Expected behaviour:
A concise description of what you expected to happen.
It to find the subdomain entry or have a field that can specify the level.
Steps to reproduce the bug:
Steps to reproduce the bug should be clear and easily reproducible to help people
gain an understanding of the problem.

Create a project (core) with a domain
Create a project with a hosted zone for the subdomain (abc.xyz.com)
Point the domain to the subdomain
Create service account in the environment project with DNS rights
Put credentials in GKE
Attempt to build ACME challenge at api.abc.xyz.com

Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): v1.11.7-gke.4
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): GKE
cert-manager version (e.g. v0.4.0): v0.6.6
Install method (e.g. helm or static manifests): static

/kind bug

I think this requires the equivalent of a hosted zone name for google dns?

I think this requires the equivalent of a hosted zone name for google dns?

This shouldn't really be required - we should be able to automatically detect the appropriate zone to use by recursing up through SOA records to find an authoritative nameserver.
/area acme/dns01

How was this resolved @benfdking ?

We didn't really resolve it. We have our root domain in AWS. What I wanted to do was put the subdomains in Google's DNS service in our Google Cloud Project with the rest of the bits of the projects to segregate our subdomains and make IAM simpler to manage. I wanted to be able to just delegate the Google projects to individual team members.
I could not get Cert Manager to work with Google when using sub domains, so instead I created separate zones in AWS that managed the subdomains, created IAM roles for those individual zones and passed the zone id to cert-manager with the restricted role credentials.
Hope that helps.


tooltip cut off

The tool looks great. One minor annoyance I've noticed is that the tooltip widget always shows below the command edit widget unless you're currently typing a keyword. This can lead to it getting cut off at the bottom on the screen (see image). I think it'd be better to always show above the command edit when it's this close to the bottom.

Hi @ajs99778 , that'll be a very nice improvement. Thanks for the idea!


Add Heated Seats support via the Select entity

Add Heated Seats support via the Select entity
Limitations:

The Heated Seat data relies on the Climate Data from Tesla. This only returns a value while the climate is on. This means that the select entities will stay in their previous state until the climate is turned on in the car. The selects update as expected while Climate is turned on.
Heated Seats will only change while climate is enabled. This means that if you want to turn on a heated seat, you need to first turn on the climate control, then change the select to the desired level. This is a limitation of the Tesla API.

I thought about automating turning on the climate if the user sets an option and climate isn't on, but automatically turning on the climate could have unintended consequences.

I assume this is ready to integrate right?

Same issue as heated steats - need to make it match the app.
If you like, i can close this PR, and roll the changes into the seats PR as a more overall climate control update.

No need to close it. I just noticed the commit message so thought you may have done it.

Closing this as the code has been rolled into the larger climate controls pr #188


Refactored generate function for clarity and consistency

This PR proposes the suggested changes in #473 's PR review to FreeAPS/Resources/javascript/prepare/determine-basal.js's generate function, in particular:

Simplified date initialization; removed redundant var clock = new Date();.
Streamlined middleware result assignment and logging.
Used const for immutable variables where applicable (glucose_status).
Enhanced error logging with console.error.
Simplified assignment of optional parameters (autosens_data, reservoir_data, meal_data, pumphistory, basalprofile, oref2_variables_).
Maintained default parameter values for readability and consistency.

Tested in iOS 17 simulator, tested on iPhone 15 Pro running iOS 17.1.1

Reducing the code is always nice.
However despite your verbose commit comment I don't understand why exactly you chose to remove several of the variable checks for nil, but still kept some?
As it's a bit hard to test and since current "/prepare/determine-basal.js" doesn't contain any bug or has ever caused any issues as is, would you please care to explain?

It’s unnessecary code to it like it’s currently done. Can be written shorter with the same outcome. That’s what this PR proposes. Variables that already have a default null value don’t need additional checking when passed to the next layer. Those that don’t will get assigned a proper null value / empty object and pass on to the next layer.
I used what was there (logic wise) just made it shorter, more readable to developers.

Check the other PR where I had commented that we don’t need to doubly assign variables for checking before passing them down the oref2.

I haven't tested it at all or anything, but from a quick glance it doesn't look like anything actually changes in this PR, it just makes it more concise and readable.
I don't see any reason to check those 2 variables for null, and then if it is null, set it to null... whereas in order to keep the old code's functionality the same for the other 4 checks you do still have to set null values to {} which is what the || does in the return statement.

What the script does here is to check all arrays and variables before relaying these to oref0, as any nil value will potentially brake the loop.
Now some of the nil checks are removed, and I just wonder why?

Looks like if autosens and reservoir are nil they're already set to null in the function's parameters, though. If you used pump_history = {} in the parameters it would return null instead of {}, though, which is why pump_history||{} is in the return statement.
I don't know why some are null and some are {} and didn't look into it, but it looks to match the original functionality.

I concurs with Mike, thanks for chiming in and trying to explain the intent of this PR 😊
Not a single check was removed. The parameters that have default values are not checked again, as they will default to null, if they are not given; if null is passed they are null anyways. The parameters that are not null checked before, are then checked but in the return (that’s what the || does).
I‘m not entirely sure why some parameters default / are assigned to be null, while others are assigned to be an empty object; it was done like this in the existing code, so it was done here again, I didn’t call this into question
The code here is just more concise, clear and readable. Nothing was removed in terms of checks. The unnecessary double checks (instantiating a local variable, then checking a parameter and assigning null to the local variable) was removed - but the check is still in place, via the parameters default values and where not present in the return statement.

@Jon-b-m I see that 3 days ago you labelled this with question. What is your question? I've tried answering your initial inquiry, and there have been no follow-up questions.

What the script does here is to check all JSONs before relaying these to oref0, as any nil will brake the loop.
Now some of the nil checks are removed, and I just wonder why?

Do you mean "brake" as in slow down the loop or "break" as in stop the loop working?

@Jon-b-m Was this accidentally closed when fixing the alpha branch, and should be re-PR'd to alpha?


Enable CD for genexus-plugin

Description
Enable CD for genexus-plugin at https://github.com/jenkinsci/genexus-plugin.git
Submitter checklist for adding or changing permissions
Always

[x] Add link to plugin/component Git repository in description above

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

FYI https://groups.google.com/g/jenkinsci-dev/c/1-46eS41y6I


Prevent Gridsome from creating certain tags inside

Description
When working with a custom index.html file, Gridsome adds a second <title> even though the title hasn’t been specified in any component or the main.js file and is already present within the index.html file.
Steps to reproduce

Create a custom index.html file with a <title> inside <head>
Run gridsome build

Expected result
It should be possible to control which tags get added to the head of a build.
Actual result
Gridsome assumes certain fields haven’t been set manually and adds them, even though no information on how to populate them has been specified. The title is just one example of a tag being added although a version of it already exists within the index.html
Environment

Libs:
- gridsome version: 0.7.3
- @gridsome/cli version: 0.2.3

The correct way to populate tags inside <head> described in docs. And I don't think this is going to be changed.

@Al-Rozhkov The method described in the docs might not always be a viable options for certain projects. I opened this issue because I used gridsome to populate a given template that already included certain head tags.
In my case gridsome added tags that were already populated, due to some hardcoded values in the gridsome core. It'd be great if there was an option to decide which tags exactly are set by gridsome and which should be omitted.


[New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator

Name of library: expo-image-manipulator
More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293319626329
Details

Link to package: https://www.npmjs.com/package/expo-image-manipulator
Problem solved by using this package: The library we're using now (@oguzhnatly/react-native-image-manipulator) is a transitive fork of expo-image-manipulator. The original package is more actively maintained and uses expo-modules-core so it should support both, the new and the old architecture.
Number of stars in GH: 26.7k
Number of monthly downloads: 42,954
Number of releases in the last year: 9
Level of activity in the repo: high
Alternatives: @oguzhnatly/react-native-image-manipulator or any of the other expo-free forks of this library.
Are security concerns brought up and addressed in the library's repo?
How many dependencies does this lib use that will be brought into our code?

0 – since we already have the Expo modules core.

What will the effect be on the bundle size of our code?

Hey! I'm Kamil from Software Mansion and I would like to work on this task.

@mountiny for some context, we did get New Arch support merged for the fork we're currently using, but it has not yet been published to npm. It took about a year for the PR to be reviewed.
The main reason I support this switch is because we're already using a fork of expo-image-manipulator, so using the original source and the most widely adopted version of this library makes sense.

What will the effect be on the bundle size of our code?
According to https://bundlephobia.com we will add ~2kB

I will do this tomorrow

Posted here https://expensify.slack.com/archives/C01GTK53T8Q/p1707496462582779

I traced back the reason for using this fork to help determine my decisions and found it here:
https://github.com/Expensify/App/issues/6301#issuecomment-1100758657
Not having expo at the time was the main reason for using the fork, and because we now have it, it totally makes sense to use the original package.

Want to clarify with whatever C+ gets assigned to this issue that we'll pay a $250 bounty for the review instead of the standard $500

We have got I believe 6 or 7 👍  from App deployers across GH and Slack and 0 pushback so we can go ahead with the PR @kowczarz

Asked for an update on the PR

On staging

This will be ready for payment for Manan

Payment Summary:
Contributor: @kowczarz no payment, agency contributor
C+ Review: @mananjadhav $500 please request in newdot

@laurenreidexpensify this issue is not closed. The earlier PR was reverted, and the new one is under review right now. Can you please remove the payout summary and reopen the issue?

Payment Summary:
Contributor: @kowczarz no payment, agency contributor
C+ Review: @mananjadhav $500 please request in newdot
@hungvu193 pls apply for payment in upwork - https://www.upwork.com/jobs/~0155bf7bf36c1319ef

Payment Summary:
Contributor: @kowczarz no payment, agency contributor
C+ Review: @mananjadhav $500 please request in newdot
@hungvu193 pls apply for payment in upwork - https://www.upwork.com/jobs/~0155bf7bf36c1319ef

I've just applied!

Upwork Proposal: Upgrading React Native Image Manipulator Package
Dear Team,
To address the issue with the current library, I propose upgrading to the original package, expo-image-manipulator, which is more actively maintained and supports both the new and old architecture. By transitioning to this package, we ensure compatibility with Expo modules core and benefit from ongoing updates and enhancements.
Implementation Plan:

Assessment: Evaluate the current usage of @oguzhnatly/react-native-image-manipulator in our application and identify any potential dependencies or conflicts.
Migration: Replace the existing library with expo-image-manipulator in our codebase, ensuring compatibility with both the old and new architecture.
Testing: Conduct thorough testing to validate the functionality and performance of the image manipulation features with the new library.
Deployment: Once testing is successful, deploy the updated version of the application to production, ensuring a seamless transition for end-users.

$500 approved for @mananjadhav based on summary.


fix(test): test

:tada: This PR is included in version 1.0.9-rc.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VERTX JUNIT5 Issue Mocking Static Classes

I am unable to mock static classes for Vertx JUNIT5. Added all dependencies as well in pom.xml for Vertx JUNIT5. (junit-jupiter-api,junit-jupiter-engine,mockito-inline,mockito-core,mockito-junit-jupiter,vertx-junit5)
Code Snippet:
@ExtendWith (VertxExtension.class)
VertxTestClass {
@BeforeEach
 public void beforeEach(Vertx vertx,VertxTestContext ctx)
{
    vertx=Vertx.vertx(options);
    Mockito.mockstatic(Placeholder.java);
    when (Placeholder.getValue(Mockito.anyString()).thenReturn("value")
    vertx.deployVerticle(MyVerticle.class.getaName()).onSuccess(ok->ctx.completeNow())
}

}
Main Class:
MyVerticle extends AbstractVerticle{
@Override

public void start(Promise appState)
{ ….
      Placeholder.getValue(“MyValue”);  // this is always returning NULL even this is mocked in test class
    …
}

}
When verticle is deployed the start method MyVerticle Class is invoked. But even though Placeholder class is mocked then also Placeholder.getValue("MyValue") is returned as NULL.
Unable to figure out how to do that mocking. I have tried with Mocked Static as well but that also does not help. To me it looks like when vertx deploy verticle is called then the start method is not being invoked directly but it will be invoked by Vertx. so somewhere that scope is lost and whatever mocking is done in test class is lost. Unable to figure out a way. Any help is appreciated

vertx-junit5 version is 4.3.7, mockito-inline is 3.8.0,junit-jupiter-api is 5.8.2,mockito-junit-jupiter is 2.23.0

This does not look like a bug but rather a question about Mockito static mocking. I'm not sure this is the best place to ask for help about it.
Perhaps if you modify your snippets to show an easily reproducible case someone will try it out.

I have mentioned the above steps . Unable to figure out a way . Earlier with JUNIT4 we could easily mock such scenarios with PowerMockito.


Fallback to PCRE2 if match whole word used with regexp

Fixes #82071
This PR ensures that --auto-hybrid-regex will be added to Regexp searches regardless of Match Whole Word state.
Changed order of operations a bit to keep related checks and CLI arguments nearby.

But if it is a non-regex whole word search, it won't be added, right?

Correct. If isWordMatch is true but isRegExp is false - it won't be added [1].

Maybe it should just be duplicated and put next to the --regexp switch to make sure it always gets set for regex searches

That was my first intention, but if it is added unconditionally then it will be also applied to all non-regex whole word searches. If condition added - that there will be 2 similar conditions which looks confusing as for me. Therefore I moved args.push('--auto-hybrid-regex'); in check right above blocks where ---regexp will be added.
Example with duplicate + condition.
if (query.isWordMatch) {
	const regexp = createRegExp(query.pattern, !!query.isRegExp, { wholeWord: query.isWordMatch });
	const regexpStr = regexp.source.replace(/\\\//g, '/'); // RegExp.source arbitrarily returns escaped slashes. Search and destroy.
	args.push('--regexp', regexpStr);
	if (query.isRegExp) { // same as below
		args.push('--auto-hybrid-regex');
	}
} else if (query.isRegExp) { // same as above
	let fixedRegexpQuery = fixRegexNewline(query.pattern);
	fixedRegexpQuery = fixNewline(fixedRegexpQuery);
	args.push('--regexp', fixedRegexpQuery);
	args.push('--auto-hybrid-regex');
}

[1] only exception is special case when search query is exactly --. In this case isRegExp will be overridden to true, and --auto-hybrid-regex will be added even if user doesn't use regexp search.

then it will be also applied to all non-regex whole word searches

But we convert all whole word searches to regex searches, even if they are not originally regex searches, that is my point.

Yes.
It was my assumption that adding --auto-hybrid-regex for cases when it won't be used is undesirable (whole word search should always be valid input for non-PCRE2 implementation).
I'll happily update PR to simply duplicate line if it's OK to always include it.

I would expect that whole word search should always be valid input for non-PCRE2 implementation

Ok, that's a good point.

Yes, so it's just about preference. I don't think that it has any performance impact in any of two options (this PR or include for every regexp search).
Thanks for reviewing!