Strange issue

I get this error :
    NSAssert(itemToClusterDistanceMap.count == _items.count,
             @"All items should be mapped to a distance");

in line 168 at GMUNonHierarchicalDistanceBasedAlgorithm.m file
Debug helpers :
_items contain 2 elements
itemToClusterDistanceMap contain 1 key
debug of for loop at line 133  :

In the first execution he will add the second item (in _items array) to processedItems array.
In the second execution he will  check if ([processedItems containsObject:item]) continue; which return true because second item was add at first execution.
As result he has _items and itemToClusterDistanceMap with different count which cause the issue

Is it possible to include some code snippet of your GMUClusterItem implementation? I think it might be something to do with the 2 items are considered "equal".

@chlebta : any update on this?

I think its happening if the latitude and longitude of more than one item are exactly same.
Assertion failure in -[GMUNonHierarchicalDistanceBasedAlgorithm clustersAtZoom:], /Users//Documents//***/Pods/Google-Maps-iOS-Utils/src/Clustering/Algo/GMUNonHierarchicalDistanceBasedAlgorithm.m:169
2016-11-17 14:27:34.539 ***[3332:495234] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'All items should be mapped to a distance'

Items are compared by reference so having the same lat,lng should not trigger the assert. I tried clearing the items using [clusterManager clearItems] and readd them and it seemed fine.
Do you have a reproduction case that I can have a look at?

It was because of the wrong latitudes and longitudes. I removed them and it works fine.
Thanks for the response.

Hello @mountainvat while working more on it, I found that the library is considering values less than -88 as invalid. But the value of should be valid upto -90 as the range of latitude is -90 to 90. Please let me know if this is the case you also facing at your end.

Hello @mountainvat ,
I am unable to place latitude -90 and 0 clusters on the map.
Error - All items should be mapped to a distance
There are almost 1140 item on same location.
Thanks.

@manpreetg latitude has to be within this range [-85, +85] for it to be valid on the Mercator map. This assumption is implicit and we do not validate either on the GoogleMaps itself or this library.
However I am not sure that's related. So if you can fix the latitude first and see how it goes. Thanks.

@mountainvat Right. The -90 goes out of the map. I fixed with the condition of the latitude. But the Google map Android not giving any crash. Strange!!!

Certainly worth keeping this ticket open and we'll investigate for the next release.

If you add to map GMSMarker, and don't add this to GMUClusterManager, this XCTAssert is triggered. But if you comment out this lines, clustering is working except for this marker.
I don't want clustering this single marker. I think in some point you get all markers from GMSMapView, instead from added to GMUClusterManager.

@Bit2Dev Thanks. It helps.

//  NSAssert(itemToClusterDistanceMap.count == _items.count,
//           @"All items should be mapped to a distance");
//  NSAssert(itemToClusterMap.count == _items.count,
//           @"All items should be mapped to a cluster");
#if DEBUG
NSUInteger totalCount = 0;
for (id cluster in clusters) {
totalCount += cluster.count;
}
//  NSAssert(_items.count == totalCount, @"All clusters combined should make up original item set");
#endif
return clusters;
Commenting the lines as shown above.. this one is working fine.

@Mehul18292 I don't think this is a good idea to comment assertion lines. Now you probably have issues with markers that won't show up on the map.

@mountainvat Could you give me an idea? I have the same problem, maybe I got crash when I override isEqual: function of id. But I don't know why. Just a simple function. If I remove this code, app not crash when I rotate device quickly anymore.
open override func isEqual(_ object: Any?) -> Bool {         if let marker = object as? ClusterMarkerItem {             let content = userData as? Report             let markerContent = marker.userData as? Report             if content != nil && markerContent != nil {                 return content == markerContent             }         }         return super.isEqual(object)     }

This is happening when I am changing position(CLLocationCoordinate2D) of GMUClusterItem that is already added to clusterManager. To fix this I removed old GMUClusterItem and added new one and then called clusterManager.cluster(), and it worked.
Is there a better way to update existing GMUClusterItem?

Unfortunately this is the current behaviour. Being able to update existing items would be a non trivial effort.

This is frustrating if that is the cause. i am using external data sources and i do not have issues with the android library, but  with the ios version, i get the exception.

I've discovered that changes in marker.lalyer.latitude and marker.lalyer.longitude affect marker.position. Therefore, when the clasterization changes layer position, it also affects marker.position. The simplest way to solve this is to simply disable these animations:
let renderer = GMUDefaultClusterRenderer(mapView: map, clusterIconGenerator: generator)
renderer.animatesClusters = false

The correct way to resolve the issue is:

to gain access to the private GoogleMaps framework and fix the logic there
or create fake markers and animate them instead of the original ones


Allow looking up enums by integral value and type name.

I.e. searching "FileMode 2" should return FileMode.Create as a result.
https://referencesource.microsoft.com/#mscorlib/system/io/filemode.cs,c0cb6ba6af625b3a

I'm thinking there should be an additional terms/tags field on definitions for this which simple stores their numeric value as a searchable keyword. Also would be nice if this could be found, for all enums. In the BuildXL codebase we have event ids distributed across a number of files. It would be nice if "enum 2702 buildxl" gave all enums in the buildxl codebase which value 2702.


ERROR: in target '//external:android/crosstool': no such package '@androidndk//': Either the path attribute of android_ndk_repository or the ANDROID_NDK_HOME  environment variable must be set.

Before you open an issue, please make sure you have tried the following steps:

I am sure that my environment is the same with (https://mace.readthedocs.io/en/latest/installation/env_requirement.html).
I have  read the document for my usage.

System information

Linux Ubuntu 14.04 LTS  (VMware Wokerstation)
ANDROID NDK version : android-ndk-r15c
GCC version(if compiling for host, e.g., 5.4.0):
MACE version (Use the command: git describe --long --tags):
**Python version: 2.7.6
**Bazel version: 0.16.1

Model deploy file (*.yml)
library_name: mobilenet-v2
target_abis: [armeabi-v7a, arm64-v8a]
model_graph_format: code
model_data_format: code
models:
  mobilenet_v2:
    platform: tensorflow
    model_file_path: https://cnbj1.fds.api.xiaomi.com/mace/miai-models/mobilenet-v2/mobilenet-v2-1.0.pb
    model_sha256_checksum: 369f9a5f38f3c15b4311c1c84c032ce868da9f371b5f78c13d3ea3c537389bb4
    subgraphs:
      - input_tensors:
          - input
        input_shapes:
          - 1,224,224,3
        output_tensors:
          - MobilenetV2/Predictions/Reshape_1
        output_shapes:
          - 1,1001
    runtime: cpu+gpu
    limit_opencl_kernel_time: 0
    nnlib_graph_mode: 0
    obfuscate: 0
    winograd: 0

### Describe the problem
I have compiled the mace source code in the same environment and have successfully converted the
style conversion model and one of my model into a file. Now I want to convert mobilnenet-v2 into code
 and I get an error:

******************************************
          Building model library
******************************************

* Build //mace/codegen:generated_models with ABI armeabi-v7a
ERROR: in target '//external:android/crosstool': no such package '@androidndk//': Either the path attribute of android_ndk_repository or the ANDROID_NDK_HOME  environment variable must be set.
INFO: Elapsed time: 0.517s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (1 packages loaded)
Traceback (most recent call last):
  File "tools/converter.py", line 1757, in <module>
    flags.func(flags)
  File "tools/converter.py", line 847, in convert_func
    build_model_lib(configs, flags.address_sanitizer)
  File "tools/converter.py", line 816, in build_model_lib
    symbol_hidden=True
  File "/home/chenxiang/Mi_Mace/mace-master/tools/sh_commands.py", line 318, in bazel_build
    *bazel_args)
  File "/usr/local/lib/python2.7/dist-packages/sh.py", line 1413, in __call__
    raise exc
....
I will also encounter this problem when recompiling the maces source.I checked the environment
variables and everything seems to be fine.
such as this:

chenxiang@ubuntu:~/Mi_Mace/mace-master$ echo $ANDROID_NDK_HOME
/home/chenxiang/Android/ndk/android-ndk-r15c
chenxiang@ubuntu:~/Mi_Mace/mace-master$

What can I do to solve the problem?

Hi
When I build Mace mace source code again,
I encountered the same problem again.I execute that command to verify. the ANDROID_NDK_HOME is right.
.............

The problem is caused by running with sudo permission, where env variables are different with current user. Close this issue, feel free to reopen it if any question still not resolved.

I also encountered the same problem.
build shared lib for armeabi-v7a + cpu_gpu_dsp
WARNING: The following configs were expanded more than once: [cross_compile]. For repeatable flags, repeats are counted twice and may lead to unexpected behavior.
ERROR: in target '//external:android/crosstool': no such package '@androidndk//': Either the path attribute of android_ndk_repository or the ANDROID_NDK_HOME  environment variable must be set.
INFO: Elapsed time: 0.209s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

I had configure NDK ENV

'su root' will solve it.

@yejw5 cmake users can manually modify the "-DCMAKE_TOOLCHAIN_FILE"  in tools/cmake/cmake-build-armeabi-v7a.sh to specify android ndk being used manually. So how can i modify tools/bazel_build_standalone_lib.sh to specify android ndk directory being used? I searched the "android" keyword in bazel_build_standalone_lib.sh but the result seems not related to android ndk directory used.


feat: add better version discovery with tag splitting

Lot of repositories tag their releases as the following: product-name-1.0.0. To discover these versions the release name/tag should be cut with the name of the application so the output would be like: 1.0.0 . This way the output could be parsed to semver format.

Closing as this is not the priority anymore.


Hey is it possible to add videos support too ?

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
just to convert videos to correct format like MPEG and WEBM and OGV.
Does other service/app have this feature?
i dont know

hi @Kayo99 thanks for the suggestion! Squoosh is focused on image files and we consider videos are out of scope.


Java rewrite

Please describe the changes this pull request makes and why it should be merged:
Status:

[ ] Code changes have been tested
[ ] Code changes work without errors

Content of the pull request:

[x] This pull request changes the bot

[x] This pull request includes breaking changes for the bot
[ ] This pull request includes new command(s) for the bot

[ ] This pull request only includes non-code changes, like changes to templates, README.md, etc.

Pushing this on through due to it being nearly showtime for this rewrite


Select kernel per code cell

We would like to select the kernel on a per code cell basis rather than one kernel for the notebook.

@l-johnston
Thanks for filing this issue, unfortunately thats not something we plan on adding
Jupyter Notebook/Jupyter Lab do not support per cell kernels, and this extension tries to provide the same functionality that Jupyter Notebook/Lab provides.
You could instead try to look at using cell magics that allow you to run cells with different kernels.


fix bug #317.

add counter for current task. If it's bigger then zero, do not quit background thread

Your changes are based on the older version.

Your changes are based on the older version.


Custom path for hystrix metrics stream in case of Rancher discovery

In case of Rancher discovery there is no way to override the default path for hystrix metrics stream (/tenacity/metrics.stream). This pull request has minor changes that help to override the default path for metrics stream in breakerbox.yml

@priyadarsh,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@priyadarsh, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Will create another request with few more changes


Upgrade catenax-ng.github.io to Docusaurus v3

Migration guide: https://docusaurus.io/docs/migration/v3
This could be a good starting point to test before pushing the effort to upgrade eclipse-tractusx.github.io as well.

Please review: https://github.com/catenax-ng/catenax-ng.github.io/pull/218


Fix Issue #39:  CFI Generation fails with namespaced tags.

Builds upon #40
This replaces the usage of $element.is( [selector | element] )
The selector type we use  is limited to tag names so checking using domElement.localName should work for this case
Sometimes we check if two elements are the same, or there are code paths were it's not sure if the input is a local name selector string or an element reference. This has been implemented as a helper method.
This pull request is Finalized
Related issue(s) and/or pull request(s)
#40. #39
Test cases, sample files
One reproducible way is to load a book with a namespaced root element in the OPF in Readium.

Hello @JCCR the TravisCI automated build failed:
https://travis-ci.org/readium/readium-cfi-js/builds/190728579
...with a knock-on effect on readium-js-viewer:
https://travis-ci.org/readium/readium-js-viewer/builds/190734010

When I invoke npm run test locally in my shell, I see the following errors:
Uncaught TypeError: Cannot read property '_matchesLocalNameOrElement' of undefined
TypeError: e.EPUBcfi is undefined

When I run the browser tests via npm run http, the error is pin-pointed at:
https://github.com/readium/readium-cfi-js/blob/develop/js/cfi_instructions.js#L16
var _matchesLocalNameOrElement = global.EPUBcfi._matchesLocalNameOrElement;
(global.EPUBcfi is undefined)

I implemented a temporary fix.

...but, 3x unit tests fail:
https://github.com/readium/readium-cfi-js/blob/develop/tests/spec/models/cfi_instructions_spec.js#L267
        expect($result[2].id).toEqual("survivor-3");
https://github.com/readium/readium-cfi-js/blob/develop/tests/spec/models/cfi_instructions_spec.js#L308
        expect($result[3].nodeType).toEqual(3);
https://github.com/readium/readium-cfi-js/blob/develop/tests/spec/models/cfi_instructions_spec.js#L309
        expect($result[4].id).toEqual("survivor-3");

The unit tests passed before this pull request, at revision aa6dc1a8fb1b74ce1aedc645a26c2ddfb2a6b70e:
https://github.com/readium/readium-cfi-js/commits/develop
Let's revert the changes?

Reverting using GitHub's "revert" feature:
https://github.com/readium/readium-cfi-js/pull/58

@danielweck
Thanks Daniel. I'll fix this.
I assumed since the merge stayed green for a while that the tests passed on the PR.
It looks like Travis integration on this repository in github might not be working like before.


Correction for raw affiliation Ethical approval: The EPAC project, through the AAMC, was determined to be exempt from further institutional review board (IRB) review by the American Institutes for Research (IRB00000436, project number EX00338). The project was also reviewed and approved or exempted by the IRBs from each participating site.; Other disclosures: None reported.; is professor of pediatrics and vice chair for education, Department of Pediatrics, University of California, San Francisco, San Francisco, California.

Correction needed for raw affiliation Ethical approval: The EPAC project, through the AAMC, was determined to be exempt from further institutional review board (IRB) review by the American Institutes for Research (IRB00000436, project number EX00338). The project was also reviewed and approved or exempted by the IRBs from each participating site.; Other disclosures: None reported.; is professor of pediatrics and vice chair for education, Department of Pediatrics, University of California, San Francisco, San Francisco, California.
raw_affiliation_name: Ethical approval: The EPAC project, through the AAMC, was determined to be exempt from further institutional review board (IRB) review by the American Institutes for Research (IRB00000436, project number EX00338). The project was also reviewed and approved or exempted by the IRBs from each participating site.; Other disclosures: None reported.; is professor of pediatrics and vice chair for education, Department of Pediatrics, University of California, San Francisco, San Francisco, California.
new_rors: 043mz5j54
previous_rors: 043mz5j54;00490n048
works_examples: W2900646942
contact: 6f4eeda8748e3f419dd16e8898ac2f12:827c64d48eb9ae @ air.org

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


[Event Request] Codeunit 5836 - Cost Calculation Management - OnBeforeCalcOutputQtyBaseOnPurchOrder

Dear Support,
We would like to add a new event OnBeforeCalcOutputQtyBaseOnPurchOrder in the following function using the IsHandled pattern. This would allow us to further customize the code and migrate existing customizations.
    procedure CalcOutputQtyBaseOnPurchOrder(ProdOrderLine: Record "Prod. Order Line"; ProdOrderRtngLine: Record "Prod. Order Routing Line"): Decimal
    var
        PurchLine: Record "Purchase Line";
        Item: Record Item;
        UOMMgt: Codeunit "Unit of Measure Management";
        OutstandingBaseQty: Decimal;
        IsHandled: Boolean; //New Code --++
    begin
        //New Code --
        IsHandled := false;
        OnBeforeCalcOutputQtyBaseOnPurchOrder(ProdOrderLine, ProdOrderRtngLine, OutstandingBaseQty, IsHandled);
        if not IsHandled then
        //New Code ++
            with PurchLine do begin
                SetCurrentKey(
                  "Document Type", Type, "Prod. Order No.", "Prod. Order Line No.", "Routing No.", "Operation No.");
                SetRange("Document Type", "Document Type"::Order);
                SetRange(Type, Type::Item);
                SetRange("Prod. Order No.", ProdOrderLine."Prod. Order No.");
                SetRange("Prod. Order Line No.", ProdOrderLine."Line No.");
                SetRange("Routing No.", ProdOrderRtngLine."Routing No.");
                SetRange("Operation No.", ProdOrderRtngLine."Operation No.");
                if Find('-') then
                    repeat
                        if Item."No." <> "No." then
                            Item.Get("No.");
                        OutstandingBaseQty :=
                          OutstandingBaseQty +
                          UOMMgt.GetQtyPerUnitOfMeasure(Item, "Unit of Measure Code") * "Outstanding Quantity";
                    until Next() = 0;
                exit(OutstandingBaseQty);
            end;
    end;

Event signature:
    [IntegrationEvent(false, false)]
    local procedure OnBeforeCalcOutputQtyBaseOnPurchOrder(ProdOrderLine: Record "Prod. Order Line"; ProdOrderRtngLine: Record "Prod. Order Routing Line"; var OutstandingBaseQty: Decimal; var IsHandled: Boolean)
    begin
    end;

Availability update: We will publish a fix for this issue in the next update for release 22.
Build ID to track: 56887.


Add derivation for firefox-bin on macOS

Description of changes
Fixes #71689
Had to rewrite some of maintainers/scripts/update.py as I was getting deadlocks due to there being too much stderr output when running it with firefox-bin/update.nix
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@jtojnar separated update.py into another commit :)

@jtojnar updated the function name :)

Any updates?

@jtojnar could you review the update script part again?

@Enzime you need to rebase.

@jtojnar @Atemu updated my PR, can you guys take a look?

@jtojnar updated, renamed check_subprocess_outputs to check_subprocess_output now that it no longer returns stderr :+1:

@jtojnar can you take a look at this PR when you get a chance?

Fwiw this doesn't work for me on darwin-aarch64:
$ nix build  github:Enzime/nixpkgs/firefox-bin-darwin#firefox-bin --show-trace
error:
       … while calling the 'derivationStrict' builtin

         at //builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'firefox-bin-112.0'
         whose name attribute is located at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/stdenv/generic/make-derivation.nix:302:7

       … while evaluating attribute 'buildInputs' of derivation 'firefox-bin-112.0'

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/stdenv/generic/make-derivation.nix:349:7:

          348|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          349|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^
          350|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;

       … while calling 'getOutput'

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/lib/attrsets.nix:892:23:

          891|   */
          892|   getOutput = output: pkg:
             |                       ^
          893|     if ! pkg ? outputSpecified || ! pkg.outputSpecified

       … while calling anonymous lambda

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/stdenv/generic/make-derivation.nix:249:13:

          248|       (map (drv: drv.__spliced.hostHost or drv) (checkDependencyList "depsHostHost" depsHostHost))
          249|       (map (drv: drv.__spliced.hostTarget or drv) (checkDependencyList "buildInputs" buildInputs'))
             |             ^
          250|     ]

       … while calling anonymous lambda

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/lib/lists.nix:117:29:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |                             ^
          118|

       … from call site

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/lib/lists.nix:117:32:

          116|   */
          117|   imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
             |                                ^
          118|

       … while calling anonymous lambda

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/stdenv/generic/make-derivation.nix:216:81:

          215|   checkDependencyList = checkDependencyList' [];
          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
             |                                                                                ^
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep

       … from call site

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/stdenv/generic/make-derivation.nix:217:8:

          216|   checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep:
          217|     if lib.isDerivation dep || dep == null || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep
             |        ^
          218|     else if lib.isList dep then checkDependencyList' ([index] ++ positions) name dep

       … while calling 'isDerivation'

         at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/lib/attrsets.nix:636:5:

          635|     # Value to check.
          636|     value: value.type or null == "derivation";
             |     ^
          637|

       error: attribute 'gtk3' missing

       at /nix/store/cw47zmdcab6hd787ws7arb87j482v356-source/pkgs/applications/networking/browsers/firefox/wrapper.nix:231:23:

          230|       nativeBuildInputs = [ makeWrapper lndir jq ];
          231|       buildInputs = [ browser.gtk3 ];
             |                       ^
          232|

@hraban the Firefox wrapper is currently Linux only, so the package you want is firefox-bin-unwrapped

This sort of feels like a place where the derivations diverge so much that we'd want to keep the Linux one in this file as the main focus and extract the Darwin one into its own neighboring file.

I'd be in favour of that aswell. See https://github.com/NixOS/nixpkgs/pull/195473

@hraban the Firefox wrapper is currently Linux only, so the package you want is firefox-bin-unwrapped

thanks, can confirm this works 👍

@tjni @Atemu I intentionally chose to keep the files together as firefox-bin on macOS should stay quite simple as it'll just be a derivation that extracts a DMG and to avoid #227449

@Enzime that bug happens due to they way they chose to go about it. It'd be better to do that in all-packages IMO i.e. if stdenv.isDarwin then callPackage ../path/to/spotify/darwin.nix { } else callPackage ../path/to/spotify { };

I ran shellcheck on the Bash script in update.nix and fixed all the issues, and I separated default.nix into darwin.nix and linux.nix

I see some updates around unwrapped considered supported or not--What's the actual entrypoint of this PR now?

I see some updates around unwrapped considered supported or not--What's the actual entrypoint of this PR now?

The entrypoint is firefox-bin (not the unwrapped variant).

@Enzime Up for rebasing this?

I'm quite busy for the next 2 weeks, feel free to create a new PR, otherwise I'll rebase it when I get some more free time :+1:

@Enzime, I'm so appreciative of your work on this PR (many thanks to the reviewers as well)! I haven't contributed to nixpkgs before, but I would love to help in any way get this merged.
One thought that I had was that the changes to maintainers/scripts/update.py could be isolated to a separate PR. As I'm writing this message, that file has not been touched in over a year, so we could possibly cherry-pick your commit from this branch into another branch and get an PR out there for that.

Closing this PR, anyone's who's interested feel free to pick this up
However note that firefox-bin is a lot less necessary as a source built version should be merged soon at #350384


Update sdk version and check for subdomain uniqueness

Updated to latest version of azure-mgmt-iotcentral python sdk
Added check for subdomain uniqueness.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

Add @emgarten @zzcodework @amrenbin @cle5eland @vavilla

@tjprescott For checkNameAvailability and checkSubdomainAvailability our rp-service will return a message stating if the given name/subdomain is available. If the name/subdomain is taken than it will return a message stating it's taken.
We do these checks because on our appCreate api we do not check for uniquness of the name or subdomain, we assume at this point they are unique. When users create an application using our UI or Azure Portal we do this check prior to creating an application as well. Also, if we do not do these checks the user may confuse a create with an update event because the response is the same from our rp-service.

@tjprescott Discussed offline, submitted an issue to make IoTCentral create command idempotent. #7791


Execute scripts without wrapping exceptions

Situation
If you want to check whether your scripts produce the expected exceptions, it is more convenient to not have them wrapped in a runtime exception — or to be more precise a DatabaseObjectException.
Acceptance Criteria

Scripts can optionally be executed without wrapping the SqlException.

Changed my mind. This bloats the interface unnecessarily and writing code to unwrap the runtime exception is trivial.


AnalyzeAPK() for some APKs give a variety of xml.parsers.expat.ExpatError: errors

Describe what you wanted to do
When parsing https://play.google.com/store/apps/details?id=com.shopgate.android.app13182 with Androguard's androlyze.py, I get: xml.parsers.expat.ExpatError: unbound prefix: line 108, column 0
Other apps have similar errors in expat, but it's not clear if the underlying cause is the same.  The whole set of unique expat errors I've seen is:
$ grep ExpatError invalid.err | sort | uniq
xml.parsers.expat.ExpatError: duplicate attribute: line 101, column 0
xml.parsers.expat.ExpatError: duplicate attribute: line 110, column 0
xml.parsers.expat.ExpatError: duplicate attribute: line 121, column 0
xml.parsers.expat.ExpatError: duplicate attribute: line 164, column 0
xml.parsers.expat.ExpatError: duplicate attribute: line 81, column 0
xml.parsers.expat.ExpatError: duplicate attribute: line 98, column 0
xml.parsers.expat.ExpatError: must not undeclare prefix: line 2, column 0
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 154, column 0
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 205, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 338, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 349, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 397, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 509, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 569, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 57, column 0
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 5, column 24
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 602, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 611, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 614, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 629, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 642, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 670, column 6
xml.parsers.expat.ExpatError: not well-formed (invalid token): line 704, column 6
xml.parsers.expat.ExpatError: unbound prefix: line 101, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 104, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 108, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 151, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 178, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 199, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 2183, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 246, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 299, column 0
xml.parsers.expat.ExpatError: unbound prefix: line 681, column 0
Describe what you expected
Parse w/o error
Describe what actually happened
In [4]: a,d,dx = AnalyzeAPK('com.shopgate.android.app13182.apk')
WARNING: AXML parsing failed: unbound prefix: line 108, column 0
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/androguard-3.1.0.dev0-py3.5.egg/androguard/core/bytecodes/apk.py", line 203, in init
self.xml[i] = minidom.parseString(self.axml[i].get_buff())
File "/usr/lib/python3.5/xml/dom/minidom.py", line 1968, in parseString
return expatbuilder.parseString(string)
File "/usr/lib/python3.5/xml/dom/expatbuilder.py", line 925, in parseString
return builder.parseString(string)
File "/usr/lib/python3.5/xml/dom/expatbuilder.py", line 223, in parseString
parser.Parse(string, True)
xml.parsers.expat.ExpatError: unbound prefix: line 108, column 0
System Information
Androguard Version: master
Python Version: 3.5.2
Operating System: Ubuntu 16.04
Further Log Files and Output
If this warrants a separate bug for each expat error type, let me know.  But possibly fixing one may fix others?

It seems like they are using some kind of packer for the manifest file, so the decompilation fails...
Such problem are really a PIA because packer vendors will always find some way to disturb automated processes such as androguard.
Just out of curiosity: have you tried to use a different xml parser? Maybe it will still work with other parsers than minidom. Minidom is fine, but sometimes quite limited.

Attached is the manifest file from com.shopgate.android.app13182, which has been extracted using apktool.   Both etree and minidom handle it fine, and it doesn't seem to be malformed in any way.  However, this is after it's been parsed with apktool, so perhaps that's because it's after apktool fixes it up in some way?
AndroidManifest.xml.txt

So I took a look at some of my files with this error. It seems they do not start with the usual AXML Header of 0x00080003 but with 0x00080503. So they already fail in line 1225 of the AXMLParser.
I'm not sure why it is a separate header but this fixes it:
diff --git a/androguard/core/bytecodes/apk.py b/androguard/core/bytecodes/apk.py
index 1d4d780..458a76a 100644
--- a/androguard/core/bytecodes/apk.py
+++ b/androguard/core/bytecodes/apk.py
@@ -1222,7 +1222,7 @@ class AXMLParser(object):

         axml_file = unpack('<L', self.buff.read(4))[0]

-        if axml_file == CHUNK_AXML_FILE:
+        if axml_file == CHUNK_AXML_FILE or axml_file == 0x00080503:
             self.buff.read(4)

             header = ARSCHeader(self.buff)

Who has more knowledge of the AXML format and might answer the question with the different headers?

It looks to still error in the same way after the above modification:
WARNING: AXML parsing failed: unbound prefix: line 108, column 0
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/androguard-3.1.0.dev0-py3.5.egg/androguard/core/bytecodes/apk.py", line 203, in init
self.xml[i] = minidom.parseString(self.axml[i].get_buff())
File "/usr/lib/python3.5/xml/dom/minidom.py", line 1968, in parseString
return expatbuilder.parseString(string)
File "/usr/lib/python3.5/xml/dom/expatbuilder.py", line 925, in parseString
return builder.parseString(string)
File "/usr/lib/python3.5/xml/dom/expatbuilder.py", line 223, in parseString
parser.Parse(string, True)
xml.parsers.expat.ExpatError: unbound prefix: line 108, column 0
Are you sure this is the right fix?  With the above patch, com.shopgate.android.app13182.apk fails in the same way that it did before.

Actually, all of the APKs that I currently have that fail to be processed by androguard have axml_file = 0x80003, which is the expected CHUNK_AXML_FILE value.  I'm not sure why you'd be seeing 0x00080503 in any APK file.  But if you are, I suppose that'd be a different problem than I'm seeing.

oh okay. so I have yet another error... I'll try to debug this.

For this shopgate app, I get a more desciptive error message when using lxml:
In [22]: etree.fromstring(y)
  File "<string>", line 116
XMLSyntaxError: Namespace prefix ns for theme on application is not defined, line 116, column 1

in the xml, it looks like this:
<application
ns:theme="@7F0A0143"
ns:label="Babyshop UK"
ns:icon="@7F020076"
ns:name="com.shopgate.android.app.SGApplication"
ns:debuggable="false"
ns:allowBackup="false"
ns:hardwareAccelerated="true"
>

And below that, there are more ns:, instead of android:
When I look at the AXML file itself using 010 editor, the namspace seems to be fine - so I do not really know where this one comes from...

Actually it doesn't look to bad. The problem was, that namespaces where not acknowledged if the uri was already parsed. I changed that behaviour.
In the case of this APK, the xmlns:ns part is now directly in the application tag. Looks like the XML Parser is happy then.
@wdormann Can you check if the changes in https://github.com/reox/androguard/tree/fix-axml-missing-ns work for you?

As with issue 280, nothing seems to be fixed here.   Do you want a copy of an offending APK?


select function demands column name to be in lower case while in fact it is not

@infocrat, can you share more details of what you're trying to accomplish?

I have a table in Hive, I am trying to accomplish something like this and :
cr <- myTable %>% filter(CurrentRate>0) %>% select(CurrentRate)
Error in eval(expr, envir, enclos): object 'CurrentRate' not found
While this works fine:
cr <- myTable %>% filter(CurrentRate>0) %>% select(currentrate)

Not really...
iris %>% select(species)
Error in overscope_eval_next(overscope, expr) :
  object 'species' not found

> iris %>% filter(Species !=  "") %>% select(species)
Error in overscope_eval_next(overscope, expr) :
  object 'species' not found

We match dplyr behavior for dplyr functions in `sparklyr.


Recent Processes

Task "Automatic upload to Col finished - 4 seconds ago" should change into "3 photo(s) uploaded automatically to Col - 4 seconds ago"

as the same as in notification


Retrieve the Dependabot alerts after dependabot processes have run

[ ] is there an API that we can ask for the latest Dependabot run?
[ ] we can retrieve the vulnerability alerts through CodeQL. Example here, which returns all alerts with a severity if you use the query below.

Results

Query
{
    repository(name: "test-alerts", owner: "rajbos") {
        vulnerabilityAlerts(first: 100) {
            nodes {
                createdAt
                dismissedAt
                securityVulnerability {
                    package {
                        name
                    }
                    advisory {
                        description
                        severity
                    }
                }
            }
        }
    }
}

No API available to find out if Dependabot has run or when the last run happened :-(. We can only retrieve the security alerts trough the GraphQL API.


Update readme to explain what verifiers-for-hyle does

The purpose of this issue is to

write a good description of what the repo does, in the readme directly. This repo lists all the different verifiers that Hylé supports
explain the code structure (each new verifier is a new folder)
add links for hylé at the bottom: Useful links
Hylé website
Hylé documentation

Hi @s0lness  can I work on this ?

Can I hop on this

@s0lness  Hello team! 👋 I'm eager to contribute to the project by updating the README to provide clear explanations about the functionality of verifiers-for-hyle.
To address this issue, I'll begin by thoroughly reviewing the existing README to understand the project's scope and purpose. Then, I'll update the documentation to include a concise yet comprehensive explanation of what verifiers-for-hyle does. This will involve describing its main features, use cases, and how it integrates with other components of the project.
I'll ensure that the README is user-friendly, informative, and helps both newcomers and experienced users understand the role of verifiers-for-hyle in the project.
Looking forward to making a meaningful contribution!
Best regards,
Mario Araya

@s0lness Can I work on this please? This is my first time in Starknet ecosystem and I’ll love to proof my acquired skills. Thank you.

Hi @s0lness I’m still waiting to be assigned this issue. Assign me please. I can update the readme to make it easily understandable and technically accurate, estimated time of delivery is 24 hours and I’ll create a pr within 12 hours once assigned, thank you.

Hi, please check my Pull Request.
#18
Do tell me what I should improve to make it better.

@s0lness Let me take on this

@s0lness please can I be assigned this issue?

Hello Team Lead, am a web3 developer and i will love to be part of this project if given the opportunity.
https://github.com/Ternder001

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
My recent focus in Ethereum-Solidity and Starknet-Cairo has significantly deepened my understanding of web3 technologies, positioning me well to contribute to innovative projects in the blockchain space. As an alumnus of Web3Bridge, where I received training in Solidity and Cairo, I have developed a solid foundation in these technologies. I am eager to contribute to open-source projects within the Starknet ecosystem, and I am particularly excited about the opportunity to make meaningful contributions to this project. Given the chance, I am committed to delivering my best work and leveraging my skills to drive success.
How I plan on tackling this issue
I will approach the problem by creating  a comprehensive README for the Hylé Verifiers repository, the following steps will be taken:

Understand the Purpose and Functionality of Hylé:
o	Ensure a clear understanding of Hylé’s role as a minimal layer one blockchain focused on verifying zero-knowledge proofs.
o	Understand how the verifiers fit into the broader Hylé ecosystem and their importance in enabling off-chain applications.
Structure the README:
o	Create a clear and concise structure for the README to cover all necessary aspects: repository description, code structure, and useful links.
Draft Repository Description:
o	Write a brief, engaging overview of what the repository does, highlighting the importance of ZKP verifiers and their integration with Hylé.
Detail Code Structure:
o	Explain how the code is organized within the repository.
o	Describe the purpose of each folder and how new verifiers should be added.
Add Useful Links:
o	Include direct links to the Hylé website and Hylé documentation for easy access to additional information and resources.
Review and Refine:
o	Review the README for clarity, completeness, and accuracy.
o	Refine the language to ensure it is easy to understand and free of jargon.
Detailed Steps
Repository Description:
o	Introduce Hylé and its core function of verifying zero-knowledge proofs.
o	Explain the purpose of the repository: listing all the different verifiers that Hylé supports.
o	Highlight the benefits of using Hylé and its verifiers for off-chain applications with blockchain security.
Code Structure:
o	Describe the overall structure of the repository.
o	For each verifier, mention that it has its own folder containing all necessary files and documentation.
o	Provide an example of the folder structure and what each component within the folders represents.
Useful Links:
o	Add a section at the end of the README titled "Useful Links".
o	Include hyperlinks to the Hylé website and Hylé documentation for users who want to learn more or need further assistance.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Full Stack Mobile Engineer leveraging Golang as a backend technology while building mobile applications with Flutter, SwiftUI and Kotlin JetPack Compose
How I plan on tackling this issue

Understand the project structure and architecture.
Navigate between folders in the project to get a full knowledge of what it holds and how they communicate between folders which holds files.
Add important links.


Onboarding structure revamp for alpha

Implemented the new onboarding structure we discussed for alpha - welcome page, getting started with 3 main steps then either tutorial or porting guide. Made changes to the ToC to reflect this. Only basic testing done on this yet, needs improbadoc testing

This PR is duplicated and superseded by: https://github.com/spatialos/UnrealGDK/pull/446


Fix data race in ValidateCoherency

Pull Request Test Coverage Report for Build 799010696

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 93.615%

Totals

Change from base Build 755773631:
0.002%

Covered Lines:
3739

Relevant Lines:
3994

💛  - Coveralls


[Support] Disconnection of wireguard clients

Hello colleagues, good day
I have pihole and pivpn wireguard in ubuntu served in the cloud, and I have mikrotik clients connected through wireguard, everything works perfectly, but it happens that when there is a power outage or internet outage in the client routers (mikrotik) they disconnect from pivpn (wireguard) you have to restart the server for them to reconnect.
I hope someone can help me to solve this conflict.
Thanks a lot!

Duplicate: https://github.com/pivpn/pivpn/discussions/1458
Closing


Allow using just $

Compared to literal $ in strings I use ${} much, much more
And I definetly never want to remove on the content when typing $ over a selection
I would like the extension to autocomplete {} brackets for me when I write just $
s = `abcd|efg${123}h`
// type `$`
s = `abcd${|}efg${123}h`

// extended: also convert to template string
s = "abcd|efgh"
// type `$`
s = `abcd${|}efgh`

// selection: surround on $
s = "abc|def|gh"
// type `$`
s = `abc${|def|}gh`

I have a snippet that lets me complete $ to ${}.
"Template Literal": {
		"prefix": "$TemplateLiteral",
		"body": [
			"\\${$1\\}"
		],
		"description": "Insert Template Literal"
	}

Unfortunately when using it this extension does not work.


docs: fix the license URLs of client_model, flatbuffers and hyperscan

Risk Level: Low
Docs Changes: Fix license URLs

Thank you for reviewing and merging!


what the meaning of center_radius=2.5 in yolo_head

https://github.com/Megvii-BaseDetection/YOLOX/blob/d17bef824966bf3f0209fd58c70d07f93265c9c7/yolox/models/yolo_head.py#L581

@PyNancy Center sampling radius. The anchor points out of these regions won't be assigned as positive.

why not center_radius=1.5  as the paper said  We simply assigns the center 3×3 area as positives, also named “center sampling” in FCOS


Build packages for synology

Is your feature request related to a problem? Please describe.
I can't install netbird on my synology nas.
Describe the solution you'd like
build packages for synology dsm7 for the arm64 and amd64.
Describe alternatives you've considered
Use netbird in docker container.
Additional context
no context needed.

@tbc0309 already do it here but without share build scripts.

It is purely handmade, and you can use 7zip to unzip and view the running script.

@artemklevtsov is there something more generic that you can share with the community?

I would just like to get the official support of the synology nas.

Thanks guys, we will have a look at it for the next quarter.

Looking forward to it. If possible please include a package compatible with the ARMv7 architecture.

A Synology package is not a Solution. We have seen this with numerous other projects, the maintenance is slow so you will be versions behind and eventually getting dropped. Not only that but the proprietary Synology application saves the data in hidden folders in the filesystem, making access edit and backup a nightmare.
The Best solution for Synology would be the adaptation of the script so it only creates you the docker compose file + evn file that you then can easily load it to Portainer and start your stack like a BOSS.
This way you can also decide not to use docker Volumes but mount persistent data to your Synology, making accessing of the data, edit and backup a simple task instead.
There is no other way really......

Synologies running on an ARMv7 do not support docker.

Synologies running on an ARMv7 do not support docker.

That is so unfortunate. Maybe i need to make a new issue for the docker install support then.

The official Netbird build does not provide ARMv7 binary file, which means I cannot easily create a package for Synology NAS.

Can docker be used to setup netbird then?

I managed to run the docker container without any luck on accessing it through the netbird network.
It still shows as not connected.
First I had an issue with /dev/net/tun not being found inside docker and now when I added --device it gives me a timeout:
sudo docker run --rm --name synology-dsXXX --hostname synology-dsXXX --device /dev/net/tun --cap-add=NET_ADMIN --cap-add=SYS_ADMIN --cap-add=SYS_RESOURCE -d -e NB_SETUP_KEY=XXXXX -v netbird-client:/etc/netbird netbirdio/netbird:latest

and the logs from the container:
2024-04-02T13:59:52Z INFO client/internal/connect.go:96: starting NetBird client version 0.26.7
2024-04-02T13:59:52Z WARN client/internal/wgproxy/factory_linux.go:15: failed to initialize ebpf proxy, fallback to user space proxy: field NbXdpProg: program nb_xdp_prog: map .rodata: map create: read- and write-only maps not supported (requires >= v5.2)
2024-04-02T13:59:52Z INFO iface/tun_usp_linux.go:33: using userspace bind mode
2024-04-02T13:59:52Z INFO client/internal/routemanager/manager.go:76: Routing setup complete
2024-04-02T13:59:52Z INFO iface/tun_usp_linux.go:45: create tun interface
2024-04-02T13:59:52Z INFO client/internal/dns/host_linux.go:68: System DNS manager discovered: file
2024-04-02T14:00:18Z WARN signal/client/grpc.go:152: disconnected from the Signal Exchange due to an error: rpc error: code = Unavailable desc = connection error: desc = "error reading from server: read tcp <IP_ADDRESS>:53890-><IP_ADDRESS>:443: read: connection timed out"

Hmm one of the reasons I use tailscale now, is because they have a package for synology.
I have a synology placed with family and by tailscale I can connect wherever I am even if their IP changes.

Check here guys :
https://github.com/netbirdio/netbird/issues/1977


JSX element type 'Particles' does not have any construct or call signatures.

Is the latest version affected?

[x] Yes
[ ] No

Which library are you using?

[ ] Vanilla JS (tsparticles)
[ ] React (react-tsparticles)
[ ] Vue.js 2.x (particles.vue)
[ ] Vue.js 3.x (particles.vue3)
[ ] Angular (ng-particles)
[ ] Svelte (svelte-particles)
[x] Preact (preact-particles)
[ ] Inferno (inferno-particles)
[ ] jQuery (jquery-particles)

Describe the bug
I am using the following packages with TypeScript version ^4.0.3:
"preact": "^10.5.3",
"preact-particles": "^1.18.10",
"typescript": "^4.0.3"

It doesn't seem to like the definition:
type Particles = PureComponent<IParticlesProps, IParticlesState>;
declare const Particles: Particles;

Usually, I would expect to see a class rather than a const but I'm no expert. For example, if I change it to:
export default class Particles extends React.PureComponent<
  IParticlesProps,
  IParticlesProps
> {};

then this works.
To Reproduce
Steps to reproduce the behavior:

Use typescript": "^4.0.3 in your package.json and try to import and use Particles from preact-particles.

Desktop (please complete the following information):

OS: Windows 10 Pro
Browser [e.g. chrome, safari]: I use Chrome but this error is from VS Code.

Thanks for reporting that, I'm working on 1.18.11 for other fixes, I'll check out this too!

@matteobruni Damn, that was quick! Thank you :) I hope that the suggested change I included is helpful, but I didn't want to add it as a pull request because I'm no expert with definition files. Much appreciated.


fsevents

It looks like you depend on a package<EMAIL_ADDRESS>Unfortunately this only is supported on MacOsX. Is this an important dependency? I'd like to try an use your project on Windows.

got the same error!

Hey @dloukola, @samvloeberghs,
fsevents is a dependency of karma, which I use for testing. On Windows, it typically throws a warning about an optional dependency (fsevents) that failed to install, however this is a warning and karma will work regardless. See https://github.com/karma-runner/karma/issues/1609.
Karma is one of the devDependencies, so you shouldn't see this error if you install via npm. If you are cloning the repo, running npm install --production will not install devDependencies. But ng2-bs3-bootstrap actually doesn't have any dependencies aside from peerDependencies and those are not installed by npm anymore.


feat: add more event emissions

Description

This PR addresses the lack of event emissions for operations in our smart contracts.

Events added
AlignedLayerServiceManager

BatcherBalanceUpdated.

BatcherPaymentService

TaskCreated.
BalanceLocked.
BalanceUnlocked.
MerkleRootVerified.

To Test

Try deployment and normal flow.

I think we should be careful with the emission of events, they could significantly improve the costs of the transactions. Specially with the SignerBalanceDecreased and SignatureVerified, which will be emitted lots of times in every transaction. Make sure to measure this properly

I think we should be careful with the emission of events, they could significantly improve the costs of the transactions. Specially with the SignerBalanceDecreased and SignatureVerified, which will be emitted lots of times in every transaction. Make sure to measure this properly

I agree, do we have measurements on gas usage with / without events, I assume its a fixed value extra per proof, since we are emitting N SignatureVerified events for N proofs.


xSQLServerAlwaysOnAvailabilityGroupReplica: Update description for parameter Name

Updated parameter description for parameter Name, so that it says it must be in the format SQLServer\InstanceName for named instance (issue #548).

Pull Request (PR) description

Changes to xSQLServerAlwaysOnAvailabilityGroupReplica

Updated parameter description for parameter Name, so that it says it must be in the format SQLServer\InstanceName for named instance (issue #548).

This Pull Request (PR) fixes the following issues:
Fixes #548
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #590 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #590   +/-   ##
===================================
  Coverage    81%    81%
===================================
  Files        32     32
  Lines      3434   3434
===================================
  Hits       2788   2788
  Misses      646    646

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


refactor(list): add docs and improve list cmd

See commit history
BREAKING CHANGE: This replaces the --pkg argument with a positional
argument of type array, so multiple packages can be provided

@amcgee I've addressed all our points, I also changed the commands to include all node modules that have a codemod, so d2 or d2-ui could be found as well (see <root>/test/list-command.test.js for better overview over how it works now)


#1990 seems to be breaking File.save

#1990 is breaking my code:
I'm getting an error which is suppressed by makeAuthenticatedRequest.
The error which is suppressed: value.hasOwnProperty is not a function which is triggered on the line:
https://github.com/GoogleCloudPlatform/google-cloud-node/pull/1990/files#diff-4ddf84f5cae46867fbddaf62136f04c3R521
The object value is looks something like this

Reverting to 0.47.0 fixes this for me.
I'm doing a File.save (from the storage module).
The config for storage is {projectId: '...'}. I'm using the credentials provided by de gcloud sdk.

This is fixed in @google-cloud/storage (dupe #2070), but a new version of google-cloud hasn't been released yet. We'll be doing that tomorrow, but if you need a solution in the meantime, you can use @google-cloud/storage directly. Sorry for the trouble and thank you for reporting.


Add evaluation for gdqn agent

User Stories
As presented in research papers, we need to experiment on the trained model and record the result/ performance as subjected to a few standardized metrics. The result should also be compared to the benchmark (buy and hold), and the research paper results.
Acceptance Criteria

evaluate-gdqn.ipynb submitted and tested
graphs and tables of results presented
compared to benchmark and analysed results

Add evaluations script for this model, output
2. If needed, retrain and debug

Status update:
I will try to fix my own code and get the eval script done and push it sometime. If I don't have time right now I will do so during reading week which is around 2 weeks later. You can ignore this model for now, I'll handle it.


Update integration tests to ubuntu 20.04

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #3047 (c501f19) into main (0432829) will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
+ Coverage   31.42%   32.08%   +0.65%
==========================================
  Files         306      275      -31
  Lines       36633    31004    -5629
==========================================
- Hits        11513     9948    -1565
+ Misses      25120    21056    -4064

see 53 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Modification to run on Summit and support login / batch / compute architecture

I am a user on Summit and it uses LSF for job submittal.  It has a unique architecture that has a login / batch / compute node setup such that a job submitted via LSF needs to have this jsrun wrapper script precede any batch job run on cluster as show in this sample job script  (otherwise the job just stays on the batch node and never gets to the compute node).
#!/usr/bin/env bash
#BSUB -J dask-worker
#BSUB -P xxx201
#BSUB -W 00:30
#BSUB -nnodes 1
jsrun -n1 -a1 -g0 -c1 /ccs/home/vanstee/.conda/envs/powerai-ornl/bin/python -m distributed.cli.dask_worker tcp://<IP_ADDRESS>:40063 --nthreads 8 --memory-limit 4.00GB --name dummy-name --nanny --death-timeout 60 --interface ib0 --protocol tcp://
I modified core.py to achieve this goal, and would like to see if some version of this idea could make it into dask_jobqueue library. thanks

Thanks a lot for your PR!
This is certainly a bit of a hack but I think what you want can currently be achieved by doing:
dask_worker_prefix = "jsrun -n1 -a1 -g0 -c1"
cluster = LSFCluster(
    ...,
    python= f"{dask_worker_prefix} {sys.executable}")

For how to do it in a cleaner way in the longer-term, using Jinja templates (and allowing user to tweak the Jinja template) seems a good way forward. Unfortunately I don't think I will find time to look at #370 any time soon ....

@lesteve thanks for your feedback.  this does exactly what I need, appreciate it !  closing PR


Add documentation on how to extend the theme

This is something that I get questions on a lot:

New maintainers want to know how to add CSS/JS. We prescribe adding in a setup() extension point via app.add_stylesheet() to get around our extension
Companies doing a deeper conversion of our theme to match their brand should know how to extend our templates
Our template blocks should be documented some? Or at least we point to the Sphinx default list of blocks that we emulate

I've been doing some minor CSS adjustments/fixes on top of the theme. It's not something I've really had time for, so I just hurried in something like:
In conf.py:
html_style = 'override.css'

And override.css:
@import url("css/theme.css");

#table-of-contents {
    background-color: #e3e3e3;
    border: 1px solid #c9c9c9;
    padding: 20px;
    margin-bottom: 20px;
}

Seems pretty straightforward. However, when you get deeper in, it gets messy and complicated:
/* Less whitespace after highlight blocks in lists, same as for <p> (bundled) */
.rst-content .section ol div[class^="highlight-"], .rst-content .section ul div[class^="highlight-"] {
    margin-bottom: 12px;  /* default: 24px */
}

Or even:
/* Margin after <ol> within lists */
.wy-plain-list-decimal li ul, .rst-content .section ol li ul, .rst-content ol.arabic li ul, article ol li ul {
    margin-bottom: 12px;  /* default: 0 */
}
.wy-plain-list-disc li ul, .rst-content .section ul li ul, .rst-content .toctree-wrapper ul li ul, article ul li ul,
.wy-plain-list-disc li ol, .rst-content .section ol li ol, .rst-content .toctree-wrapper ol li ol, article ol li ol,
.rst-content .section ol li ul, .rst-content .toctree-wrapper ol li ul, article ol li ul,
.rst-content .section ul li ol, .rst-content .toctree-wrapper ul li ol, article ul li ol {
    margin-top: 12px;  /* default: 0 */
    margin-bottom: 12px;  /* default: 0 */
}

I'm not sure what the latter even does anymore, or how I ended up having exactly those selectors. I guess I copied something from the bundled theme.css and override properties.
Something more format/documented/simpler would definitively be nice.

We should also document hmlt_context https://github.com/readthedocs/sphinx_rtd_theme/issues/156

I'd not write specific documentation for this, but just link people to the official docs:

https://www.sphinx-doc.org/en/master/usage/theming.html
https://www.sphinx-doc.org/en/master/development/html_themes/index.html


Add a way to refresh download link.

sometimes for large file i need to refresh download link to resume download. however i can't replace link in ab-download-manager.
please add this feature.
(IDM, XDM, FDM all have this feature)

Hi there. thanks for your suggestion..
Yes tou are right. I will do that.


[flake8-bugbear]  Handle shadowing and scope in unused-loop-control-variable (B007)

This PR changes the logic employed to search for uses of the control variable within the loop body in order to account for shadowing and nested scope. This is achieved by using the semantic model to check whether there are any references to the binding of the control variable within the loop body.
Closes #14113 .

Those ecosystem results look like mostly false positives - let me add some more test cases for those and fix up the implementation.


use specific version of iOSMcuManagerLibrary

Regarding this issue: https://github.com/NordicSemiconductor/Flutter-nRF-Connect-Device-Manager/issues/38
In order to prevent such problems in the future I propose to indicate the exact version of the package, and not to use an optimistic operator

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Make sense.
It's done in #41 . So I close this PR.


support/nowarnings Address some of the warnings oon LLM dev builds

📝 Description
Today I sat down and actually read the warnings that get thrown when we launch Ledger Live Mobile instead of dismissing them. How hard can it be to have an app without warnings or at least without errors? Let's go deeper.

'deprecated-react-native-prop-types' warning, it doesn't seem to be coming from us and according to some guy on github it's safe to silence them.
Memory leak on remoteliveappprovider because we launch some async task and the component gets unmounted before it completes yet we try to update the state afterwards. Simply using the useIsMounted hook that was already available we can prevent this leak.
Failed to fetch Firebase remote config.. it's kinda similar, fetching is async, and it gets cancelled because it gets unmounted. Checking that it's not unmounted before logging the error, no error.
Circular dependencies on native-ui package. They seem to come from components importing from the index of a parent instead of the specific component they rely on, so TimelineItem which is under the Layout folder, importing Flex from ../.. instead of from ../../Flex. No idea if there's a better way but changing the import removed the warning.
There's a circular dependency between react-native-crypto -> react-native-randombytes -> sjcl -> react-native-crypto but that's no on our codebase, not sure how to tackle it, any help on this one would be much appreciated.
null is not a valid color or brush. I actually looked into this a while ago and remember precisely what it was. It's usage of "null" inside svg files for some of our icons. Luckily I didn't have to spend time because I have good memory. Essentially stroke="null" is invalid yet present in SGB.svg and FTM.svg This gave a warning when listing all currencies, ie add accounts.
Bunch of styling warnings in the Portfolio NFTs tab, we should've caught these during review probably. For styled components you need to provide the pxs now. So that should silence the warning.

So I couldn't catch them all, but together maybe?
🙏🏼
❓ Context

Impacted projects: ledger-live-mobile, ledger-live-desktop, ledger-live-common, native-ui
Linked resource(s): ``

✅ Checklist

[x] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo
No demo
🚀 Expectations to reach
App should behave the same as far as QA is concerned, but for developers it should show less warnings.

I also just found this one that depends on react-native-ble-plx


Support bilibili playlist download

We now support archive download, which covers more useful cases as they are created by owner with a good selection and order.
This is still valid, but low priority now.


New package: CarouselArrays v0.1.0

Registering package: CarouselArrays
Repository: https://github.com/ChifiSource/CarouselArrays.jl
Created by: @emmettgb
Version: v0.1.0
Commit: 62fcc84688ab9dd15b116af4174595023b9f621e
Reviewed by: @emmettgb
Reference: https://github.com/ChifiSource/CarouselArrays.jl/issues/1#issuecomment-1200366826
Description: Repeating Arrays for Julia

Have you looked at https://github.com/Vexatos/CircularArrays.jl? This package seems similar
[noblock]


Wizard: Image name validation

This adds validation of an image name based on a pattern, which was chosen as an intersection of the naming constrains of hyperscalers.
The pattern is based on the one for naming GCP images as those naming guidelines are the most restrictive. With added minimal length restriction of AWS.
Sources:

Azure
GCP
AWS and

As the length of the name for AMI differs between the CLI reference and the screenshot of the error the stricter rule was chosen.

@jrusz I think this could possibly break tests. It'll change the pattern for validation of the image name to lowercase letters, numbers and hyphens only (new pattern is ^[a-z][-a-z0-9]{1,61}[a-z0-9]$).
The images that are build for the testing include underscores in the name as well, right? So it probably wouldn't get past the validation on the Name image step. Would it be possible to change the name of the test images?
cc @croissanne

@jrusz I think this could possibly break tests. It'll change the pattern for validation of the image name to lowercase letters, numbers and hyphens only (new pattern is ^[a-z][-a-z0-9]{1,61}[a-z0-9]$).
The images that are build for the testing include underscores in the name as well, right? So it probably wouldn't get past the validation on the Name image step. Would it be possible to change the name of the test images?
cc @croissanne

I think the notification engine is currently broken in eph ;_; easiest to just check the iqe plugin directly to see what name they use

@jrusz I think this could possibly break tests. It'll change the pattern for validation of the image name to lowercase letters, numbers and hyphens only (new pattern is ^[a-z][-a-z0-9]{1,61}[a-z0-9]$).
The images that are build for the testing include underscores in the name as well, right? So it probably wouldn't get past the validation on the Name image step. Would it be possible to change the name of the test images?
cc @croissanne

Yeah it seems it does use something like image-under-test-2023-07-10_11-59-39_536988 so there is an underscore. I'll go ahead and change it somehow.


Package Plugin.FacebookClient 2.1.14 is not compatible with portable45-net45+win8+wpa81

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: 2.1.14
Device Tested On: N/A
Simulator Tested On: N/A
Version of VS: MAC 2019
Version of Xamarin: 4.2
Versions of other things you are using: N/A
Steps to reproduce the Behavior
Updating package error:
Expected Behavior
Should update
Actual Behavior
Package Plugin.FacebookClient 2.1.14 is not compatible with portable45-net45+win8+wpa81 (.NETPortable,Version=v4.5,Profile=Profile111). Package Plugin.FacebookClient 2.1.14 supports:

monoandroid81 (MonoAndroid,Version=v8.1)
monoandroid90 (MonoAndroid,Version=v9.0)
netstandard2.0 (.NETStandard,Version=v2.0)
xamarinios10 (Xamarin.iOS,Version=v1.0)

Code snippet
Screenshotst

This version is not compatible with PCL projects just .NETStandard projects.


Added Eric Zimmerman's Forensic Tool List

@thefear100 plz note the list is organised by alphabetic  order, can you fix your placement of the link ?

👍


PR: Add icon for binary files

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

Added Icon for non-text files which extension is not recognized.

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

Hello @juanis2112! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/editor/plugin.py:

Line 1741:80: E501 line too long (84 > 79 characters)

In the file spyder/utils/icon_manager.py:

Line 426:21: E117 over-indented

@juanis2112, this PR look good too, except for my minor comments above.
I really don't understand why our macOS tests are failing, but if after addressing my review they are still failing, I'll give a hand with that so you can move to other things.

Please take a look at commit 5d9e019 to see how I fixed our tests (I basically skipped the test that was hanging on both Windows and macOS).


Debounce WRITE events by looking for change in file modification time.; fix unrelated linter errors

potential fixes for #4 and https://github.com/vugu/vugu/issues/177.

4c398d7 seems to cut down on multiple rebuilds per change, recommended to review now.


Error trying to control the alarm

Hi!
Thank you for your work on this integration. I hope you’re still using it and you could help me. I would like to connect my alarm to HA. I’m able to connect and see the entity control panel but I can’t control it.
Here is the error message I’m getting :
alarm_control_panel/alarm_arm_home.
TC20EAlarmPanel.async_alarm_arm_home() takes 1 positional argument but 2 were given

Hi,
Thanks for the feedback. The issue shall be fixed in v0.1.2.


Make players join automatically

Add players that are in a voice channel automatically instead of telling them to join manually

We'd need a way to detect their colors, though.

Yes, but we can do it like by using OCR and whenever the kill screen appears then parse it to the bot as the player is dead?

But for that, we need to have the game run on every players' PC  <that's not my case though half of my friends play on the phone> XD

Soup's bot does that already: https://github.com/denverquane/amongusdiscord
Amongcord's objective is to require no local installation, but make it optional. I do plan to write some sort of capture tool for Windows/Android in the future, though.

We'd need a way to detect their colors, though. Maybe if we add them to random colors?

exactly as only the names that matter during the game not the colors, everyone keeps changing colors anyways

I'll see what I can do.

Would ,joinall be cool?

Yeah that would be great.

oh hi there

No, don't close it yet! I'm not done :p


feat: deprecate xxx_token columns from users table (phase iii)

What kind of change does this PR introduce?

This PR removes the the reliance on using the xxx_token columns in the user model to store information about the token and use the one_time_tokens table as the single source of truth

CreateOneTimeToken now returns the models.OneTimeToken struct

Decouple sending the email change emails from the sendEmail function into sendEmailChangeEmails

This PR does not address changing the xxx_sent_at columns to use the one_time_tokens table yet

Do not merge until phase ii has been deployed for some time

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

171 of 236 (72.46%)  changed or added relevant lines in 7 files are covered.
21 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 57.362%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/models/one_time_token.go
3
5
60.0%

internal/mailer/template.go
54
57
94.74%

internal/api/reauthenticate.go
1
7
14.29%

internal/api/verify.go
23
32
71.88%

internal/api/mail.go
80
125
64.0%

Files with Coverage Reduction
New Missed Lines
%

internal/mailer/template.go
1
88.94%

internal/api/verify.go
2
71.7%

internal/api/mail.go
18
57.35%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8438

Relevant Lines:
14710

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

168 of 234 (71.79%)  changed or added relevant lines in 7 files are covered.
96 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.2%) to 57.377%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/models/one_time_token.go
3
5
60.0%

internal/mailer/template.go
54
57
94.74%

internal/api/reauthenticate.go
1
7
14.29%

internal/api/verify.go
23
32
71.88%

internal/api/mail.go
77
123
62.6%

Files with Coverage Reduction
New Missed Lines
%

internal/mailer/template.go
1
88.94%

internal/api/verify.go
2
71.7%

internal/models/cleanup.go
8
88.37%

internal/observability/request-tracing.go
9
81.98%

internal/crypto/password.go
14
78.29%

internal/api/middleware.go
16
80.81%

internal/api/mail.go
18
56.97%

internal/observability/metrics.go
28
4.96%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8435

Relevant Lines:
14701

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

169 of 238 (71.01%)  changed or added relevant lines in 7 files are covered.
98 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.2%) to 57.355%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/models/one_time_token.go
3
5
60.0%

internal/mailer/template.go
54
57
94.74%

internal/api/reauthenticate.go
1
7
14.29%

internal/api/verify.go
24
36
66.67%

internal/api/mail.go
77
123
62.6%

Files with Coverage Reduction
New Missed Lines
%

internal/mailer/template.go
1
88.94%

internal/api/verify.go
4
71.03%

internal/models/cleanup.go
8
88.37%

internal/observability/request-tracing.go
9
81.98%

internal/crypto/password.go
14
78.29%

internal/api/middleware.go
16
80.81%

internal/api/mail.go
18
56.97%

internal/observability/metrics.go
28
4.96%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
8434

Relevant Lines:
14705

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

171 of 240 (71.25%)  changed or added relevant lines in 7 files are covered.
23 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 57.77%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/models/one_time_token.go
3
5
60.0%

internal/mailer/template.go
54
57
94.74%

internal/api/reauthenticate.go
1
7
14.29%

internal/api/verify.go
24
36
66.67%

internal/api/mail.go
79
125
63.2%

Files with Coverage Reduction
New Missed Lines
%

internal/mailer/template.go
1
88.94%

internal/api/verify.go
4
72.06%

internal/api/mail.go
18
56.97%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.2%

Covered Lines:
8744

Relevant Lines:
15136

💛  - Coveralls


Add new limited role to TO for TR to watch TO resources

This PR is a DB entry for a new role called trouter that is for Traffic Router to watch Traffic Ops resources

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?

Verify that new Role exists in table for trouter with Capabilities including:
DELIVERY-SERVICE:READ
DNS-SEC:READ
STEERING:READ
FEDERATION-RESOLVER:READ
DS-SECURITY-KEY:READ

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

[ ] This PR has tests
[ ] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Changed PR title to more descriptive name


Boolean widget with false value not rendered in MD

Describe the bug
When setting a Boolean widget to false, this key wont be rendered to the resulting Frontmatter/Markdown file with key: false but will be left out completely. This makes problems with Gatsby GraphQL queries where this field is part of the query.
To Reproduce
define boolean field like so:
- {label: "Featured Post", name: "featuredpost", widget: "boolean", required: false}
resulting MD file doesnt have the frontmatter key "featuredpost" included.
Expected behavior
a file like this gets generated:
---
templateKey: single-blog-post
title: My super blog post
featuredpost: false
---
Super Blog content

Applicable Versions:

netlify-cms-app 2.14.5
netlify-cms-core 2.36.4
Github

CMS configuration
not disclosed

Also running into this issue, but with a YAML file rather than MD.


Ability to add custom headers to SDK via terraform provider

We dont see a way pass custom headers to the SDK..
Can we get the ability to add custom headers to SDK?
Ref: https://github.com/IBM/platform-services-go-sdk/blob/a7f14ee285ced3c4ec52b4b56e6cf9011d234b54/resourcecontrollerv2/resource_controller_v2.go#L139

I don't understand the need for custom headers, when KeyProtect will more or less completely ignore them if they aren't part of the KeyProtect API.
If you could provide your use case for them and it is a valid use case then maybe we could consider it.
I would also have to confirm with the KeyProtect API folks that adding custom headers wouldn't cause any request validation issues.


Review: Manoa-Inventory-POST Faculty Home Page

Overview
The focus for this code review will be centered around the faculty home page.
Please pay attention too:

Javascript issues
React components

Review Branch
review-03
Files to review

FacultyHome.jsx
FacultyInfoBar.jsx

Checklists

Architecture
Design
JS
React
Testing

Due date
February 13, 2023
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

FacultyHome.jsx
-Correction on comment , clear stuff element
-add comment
FacultyInfoBar.jsx
-Correction on comment , ckear stuff element
-herf link needs to be added

FacultyHome.jsx
Design-05: Ensure comments are appropriate - copy/paste error comments (lines 11, 15, 19); get rid of “how” comments (line 13)
JS-07: Avoid console.logs (line 26)
ESLINT-01: No errors, avoid warnings move import meteor before component imports
FacultyInfoBar.jsx
JS-07: Avoid console.logs (line 23)

FacultyHome.jsx
DE-05: L11, L13, L15, L19
FacultyInfoBar.jsx
DE-05: L1, L12, L16

FacultyHome.jsx

DE-05 (Line 11, 19) Mentions Stuff
JS-06 (Line 26) Get rid of console.log(faculty)
ES-01 (Line 9, 25, 46, 26) Import order, indentation, blank lines, and unexpected console statement
TA-01 Doesn’t have isDisplayed() acceptance test

FacultyInfoBar.jsx

DE-05 (Line 9, 16) Mentions admin dashboard and stuff
JS-06 (Line 23) Get rid of console.log(faculty)
ES-01 (Line 23) Unexpected console statement

FacultyHome.jsx:
Design: L11 - stuff comment
JS & ES: L26 - console log
FacultyInfoBar.jsx:
Design: L16 - stuff comment
JS & ES: L23 - console log

FacultyInfoBar.jsx: Line 23: remove console.log()

FacultyHome.jsx:
L11 & 19: Comments about stuff
FacultyInfoBar.jsx:
L16: Comments about stuff
Clear out the old comment


import X from  "y"

VsCode all import X from  "y" print error.

Need " -> '

I'm not able to reproduce this locally. Seems very odd that switching from double quotes to single quotes would make any material difference - both are valid JS/TS representations of strings.
Usually this kinda thing indicates either:
a) VSCode hasn't caught up. Try restarting your editor.
b) There's some linting plugin that dislikes one string style vs. another. I use Prettier and double-quote strings. The fact that "path" isn't yielding any errors in your screenshots, probably means this is not a linting issue.
I've guess (a) above.

Prettier


Xdebug 3 and PHP 8.1 - not working

When running a brand new install on Magento 2 using the below conifg, xdebug fails to break.
ELASTICSEARCH_VERSION=7.17
MARIADB_VERSION=10.4
NODE_VERSION=16
COMPOSER_VERSION=2
PHP_VERSION=8.1
PHP_XDEBUG_3=1
RABBITMQ_VERSION=3.9
REDIS_VERSION=6.2
VARNISH_VERSION=7.0
When downgrading the PHP version to 7.4 then the breakpoints work correct without changing any other config settings in the IDE.
This makes me believe it's a 8.1 Image specific problem, debugging is out my remit but hopefully someone can shed some light.
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[164] [Config] INFO: No shared secret: Activating
[164] [Step Debug] INFO: Checking for client discovery headers: 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] INFO: Checking header 'HTTP_X_DEBUG_HOST'.
[164] [Step Debug] WARN: Could not discover client host through HTTP headers, connecting to configured address/port: localhost:9003.
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', poll success, but error: Operation now in progress (29).
[164] [Step Debug] WARN: Creating socket for 'localhost:9003', connect: Cannot assign requested address.
[164] [Step Debug] ERR: Could not connect to debugging client. Tried: localhost:9003 (fallback through xdebug.client_host/xdebug.client_port).
[164] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_TRACE'
[164] [Config] INFO: Trigger value for 'XDEBUG_TRACE' not found, so not activating
[164] Log closed at 2022-12-25 23:07:23.224448

More detailed information can be found here swiftotter/den/#177

Maybe some additional finding from my side. Everything worked still fine in 2022 with PHP 8.1 and XDebug 3.
In the new year, I ran warden env pull and since then it is broken.
Can't really say when I did this the last time, but it seems to be related to the latest image.

@navarr , is there anything we can help here? Or do you at least see some kind of workaround, which might work for the time being?
This is a huge issue for us, so it would be awesome, if we could find a way to fix it.

@norgeindian, there seems to be a workaround roughly described in https://github.com/swiftotter/den/issues/177. I just did not get to check it in more detail yet.

add this folder and xml file to the root of the project ".warden/warden-env.yml"
run docker inspect on the project network to know the network gateway and replace "<IP_ADDRESS>" with your gateway
version: "3.5"
services:
nginx:
environment:
- XDEBUG_CONNECT_BACK_HOST=<IP_ADDRESS>

Would someone running linux be able to tell me:

The gateway IP (docker inspect <proj>_default and then under IPAM.Config.Gateway)
The result of  docker run -it --rm ubuntu:22.04 bash -c "apt-get update > /dev/null && apt-get install iproute2 -y > /dev/null && ip -4 route show default | cut -d' ' -f3"
The result of a page load with xdebug turned on, outputting: $_SERVER['HTTP_X_FORWARDED_FOR'] and $_SERVER['REMOTE_ADDR']?

In case it's useful, the following should be able to be used to gather the gateway IP from within any running container without requiring additional packages:
awk '/32 host/ { if (i !~ /^127\./) print i } { i=$2 }' /proc/net/fib_trie | head -n1 | sed -E 's/\.[0-9]+$/\.1/'

Seemed interesting that this only affects PHP 8.1, but not PHP 7.4, so I took a look through Xdebug update notes and found this:

Fixed bug #1819: Allow a list of headers in 'xdebug.client_discovery_header'

The last comment on that bug tracker reads:

if someone upgraded to xdebug 3.2 and was using client_discovery_header you have to change it to:
xdebug.client_discovery_header="YOUR_CURRENT_VALUE,HTTP_X_FORWARDED_FOR,REMOTE_ADDR"
if you want the same behavior

Considering the documentation on the feature hasn't changed to reflect this, could be a bug. Or it could be a miss on updating docs to reflect the BC break.
Since XDebug 3.2 dropped support for 7.4, the PHP 7.4 images are running XDebug 3.1 or 3.0 and thus unaffected by the  behavior change.

Thank you @davidalger for your incredible insight.
Since this seems to be intentional, I've opened a Documentation issue: https://bugs.xdebug.org/view.php?id=2154
For Warden, we're probably going to have to split XDebug config between versions as I don't see a way to update it and keep it backwards compatible 🤔

Thanks a lot for the solutions here. That actually works fine for me and is totally perfect as a workaround for the time being.

Theoretically, this will be fixed when https://github.com/wardenenv/images/actions/runs/3914748370 works.  I've confirmed XDebug still works on Windows after those changes, but I'll need someone on Linux to pull the images and test it out without a workaround once it's finished running

Images are built and pushed

I have tested this on Ubuntu 22.04 on a PHP 8.1 project:

I disabled my workaround.
I ran warden env pull && warden env up.
I tested if XDebug works again.

Aaaannddd... It works again! Thanks to everyone involved fixing this!

Thank you so much @sprankhub!


how can i fix this and run the scipt ? plz help !!

i fix that and met this 😥😥

I now can run the script but it cannot upload the video in my drive on pc

yssssss!!!! i slove the problem , i use / instead of \ and work really well !!!

You could click the "close issue" button since your problem is solved ;)


Fix rate limiter panic

lgtm

Coverage increased (+0.01%) to 83.333% when pulling fcb827d128253ee74196c4ebb286a563f4f891b7 on rate_limiter_panic into e569aa681895b0378f1acda23d55c85cada09280 on master.

Coverage increased (+0.3%) to 83.603% when pulling fcb827d128253ee74196c4ebb286a563f4f891b7 on rate_limiter_panic into e569aa681895b0378f1acda23d55c85cada09280 on master.


HTTP 500 on DELETE/If-Match

When attempting to DELETE a directory with an If-Match header I receive an HTTP 500 and the following error:
{
  "error": {
    "code": "generalException",
    "message": "An error occurred in the data store.",
    "innerError": {
      "request-id": "5770bc39-f72a-4793-83e8-60fca5e73f4a",
      "date": "2018-03-31T06:52:45"
    }
  }
}

NOTE: I used the cTag in the If-Match header.

Hi @billziss-gh, is this OneDrive Consumer? Also, can you give me a little information on the directory being deleted? For example, does it have a lot of children? Deep folder hierarchy? etc

This is on OneDrive Personal. It is very easy to repro using Graph Explorer:

Create an (empty) directory named foo under the root.
Find out its cTag by issuing a GET.
Issue a DELETE with If-Match equal to the cTag.

Hi @billziss-gh, the fix for this issue should now be deployed. Please let us know if you're still seeing issues.

Thank you for this resolution. I will test as soon as I get some free time and will let you know if I find any problems.

I can confirm that this now works for me. Thank you again for the resolution!


Respect inter-target dependencies

Prior to this commit, we weren't adding the dependencies pulled in via
inter-target dependencies to the resolution.

I ran this locally and eye balled the diff file and finding that Guava doesn't have any dependencies:
genrule(name="genrules/com.google.guava_guava_25.1-jre"<EMAIL_ADDRESS>outs=["@maven//:com.google.guava/guava-25.1-jre.jar"], cmd="cp $< $@")
scala_import(name="com.google.guava_guava_25.1-jre", jars=["@maven//:com.google.guava/guava-25.1-jre.jar"], deps=[], exports=[], tags=["jvm_module=com.google.guava:guava", "jvm_version=25.1-jre"], visibility=["//visibility:public"])

This seems wrong.

I ran this locally and eye balled the diff file and finding that Guava doesn't have any dependencies:
genrule(name="genrules/com.google.guava_guava_25.1-jre"<EMAIL_ADDRESS>outs=["@maven//:com.google.guava/guava-25.1-jre.jar"], cmd="cp $< $@")
scala_import(name="com.google.guava_guava_25.1-jre", jars=["@maven//:com.google.guava/guava-25.1-jre.jar"], deps=[], exports=[], tags=["jvm_module=com.google.guava:guava", "jvm_version=25.1-jre"], visibility=["//visibility:public"])

This seems wrong.

Good catch, thank you! I believe that the resolution results were not stored correctly for the target dependencies, because they would show up as both an actual root dependency, and a fake-root dependency of modules that have a target-dependency on them.

Good catch, thank you! I believe that the resolution results were not stored correctly for the target dependencies, because they would show up as both an actual root dependency, and a fake-root dependency of modules that have a target-dependency on them.


MagSafe error-blinking override?

I've spotted here that when there is a problem with the charging, the magsafe connector can blink orange.
I wonder if battery may overrides this, because in that case it would remove an important indicator that something charging related is not working properly.
(P.S.: I didn't came up with a better issue title so idk someone has a better ideas, be welcome to make a comment)

Update: in battery charging off mode, the magsafe can blink (but if I'm not wrong this setting doesn't affect the magsafe light)