kexec: fix wrong calculation method of ramdisk_start

Fix ramdisk_start promlem in the kexec.c.

Use the initrd_addr_max value from the kernel header if the kernel version is 2.03 or newer.
ref: https://github.com/zchee/linux-documentation/blob/master/x86/boot.md#initrd_addr_max
Use hardcoded(0x37ffffff) value if older.
Compare the initrd_max and memory.size, and re-assign if initrd_max is larger.
Add ALIGNDOWN macro for ramdisk_start, uses prevent to go past the address limit.
Fix typo for initrd_addr_max. thanks @dlorenc

Based on qemu/hw/i386/pc.c.
Close https://github.com/docker/hyperkit/issues/63

I don't know this change is correct, but it has the same value as the qemu without pcmc->acpi_data_size.

CI failures seem to be down to some ocaml ecosystem changes -- @djs55 we happened to be talking about this yesterday, were you going to raise a PR?
@zchee The code here looks ok, but I'm a bit concerned what will happen with >3G of RAM, when there will be a hole in the address space between 3-4GB as I mentioned in the final paragraph of https://github.com/docker/hyperkit/issues/63#issuecomment-252581435. In this case memory.size would perhaps point into an MMIO hole. e.g. with memory.size == 3.5GB of memory then the address space would be (I think) laid out like:
0-3GB       RAM
3-4GB       MMIO space (virtio, other devices etc)
4GB-4.5GB   RAM

But I think your code (assuming large enough zp->setup_header.initrd_addr_max) will place the initrd just below 3.5GB, which is in the middle of the MMIO hole, so badness will occur.
I think it would be acceptable to clamp the initrd address to lowmem_limit as well as memory.size (i.e. whichever is smaller). In the example above then the initrd would be loaded just below 3GB, which I think is going to be fine -- it should be way way way above anything the kernel would be expected to use during boot and is much simpler that figuring out that the real end of RAM is at 4.5GB.

@ijc25

CI failures seem to be down to some ocaml ecosystem change

yeah, understood. waiting for fix, or I will debug it.
and, OK. I do not understand all yet, but got it your said meaning.
I will comment later.

@ijc25 Now, I'm trying to understand look at the source of xhyve and qemu based on your comment.
Please wait a moment...
And, will this pull request be merged after fixing CI error?

And, will this pull request be merged after fixing CI error?

I think we would need to fix the MMIO hole problem I described too (or explain why it is not a problem).

@ijc25 Ah, Sorry.
Of curse, I'm trying to fix MMIO hole issue. Now trying.
I mean, If I fixed the MMIO issue, push to GitHub, and you said LGTM.
But this pull request merge process is after the fixed of the circlecI failed issue?

We need to fix the MMIO issue, rebase onto the CI fix and then review the final result, but there doesn't seem to be any obvious reason why this wouldn't be able to be merged then.

rebase onto the CI fix

I hadn't noticed that the CI is already fixed by https://github.com/docker/hyperkit/pull/64. So please rebase these changes onto the current master.

@ijc25 OK, I understand. Sorry for confusing you..

@ijc25 Ah, got it. I will fix MMIO issue and rebase it.

@ijc25 Sorry again if my interpretation is wrong. I hope that I had understood you said meaning.
Also, sorry this comment is so long... :(
===
I interpreted as below:
In the case of below situation, will guest memory is split to low and high. and MMIO hole exists.

protocol version(zp->setup_header.version) is 0x203 or newer
guest memory size larger than 3GB. now assuming to<PHONE_NUMBER>(4.5GB)
initrd(sz) size assuming to 805306368<PHONE_NUMBER> -<PHONE_NUMBER> / 2)
assuming to if initrd_max >= memory.size is true

The low memory has limited size that is assigned lowmem_limit = (3ull << 30) at the xh_vm_create, actually<PHONE_NUMBER>(3GB)
The high memory always starts the<PHONE_NUMBER>(4GB).
The memory layout like
(start) 0 ~<PHONE_NUMBER> ~ MMIO hole ~<PHONE_NUMBER> ~<PHONE_NUMBER> (end)

When re-calculating the initrd_max based on the memory.size only, You are concerned that initrd are overlapped in MMIO space. like
memory.size - 1  -     sz     ramdisk_start // before aligndown
(4831838208 - 1) - 805306368 =<PHONE_NUMBER>

ALIGNDOWN(4026531839, 0x1000ull) =<PHONE_NUMBER> // overlapped MMIO hole

So, you think we should compare the memory.size and xh_vm_get_lowmem_limit(), and use the smaller one. like
#include <xhyve/support/misc.h>
.
.
		initrd_max = ((uint32_t) min(memory.size, xh_vm_get_lowmem_limit()) - 1);

Is this interpretation is correct?
===
If correct, I also assumed almost the same behavior.
but AFAIK, It does not happen (only tested normal boot hyperkitrun.sh with 1GB and 8GB)
Because, memory.size assigned this line,
https://github.com/docker/hyperkit/blob/master/src/firmware/kexec.c#L229
	memory.size = xh_vm_get_lowmem_size();

and that value(3221225472) does not change until the loading initrd.
I do not know whether it is correct behavior(assign lowmem_size), but it will never be higher than the lowmem_limit, also memory.size ==<PHONE_NUMBER>(3.5GB) is impossibility value.
actually
memory.size - 1  -     sz     ramdisk_start // before aligndown
(3221225472 - 1) - 805306368 =<PHONE_NUMBER>

ALIGNDOWN(2415919103, 0x1000ull) =<PHONE_NUMBER>

We already get the low memory size on memory.size and its same as xh_vm_get_lowmem_size.
And, I thought will degrade performance a little if call the xh_vm_get_lowmem_size function.
Therefore I use memory.size only.
===
Here is added some fprintf debug.
https://gist.github.com/zchee/6f12687901b18e9867367f996f93010b
I'm really sorry if I'm wrong...

Is this interpretation is correct?

I think so, yes.

Because, memory.size assigned this line,
https://github.com/docker/hyperkit/blob/master/src/firmware/kexec.c#L229

Ah, that's surprising but you are correct that having memory.size = xh_vm_get_lowmem_size(); addresses the issue I was concerned with. Sorry for not spotting this code sooner!
So: LGTM, I'll merge. Thanks for your contribution and patience.

@ijc25 Thanks merged!
and https://github.com/docker/hyperkit/pull/68, yeah, I think good change and easier to read.
Anyway, thanks again for code & comment review :)


boards: nucleo_f413zh: enable usb

Enable usb on Nucleo-F413ZH board.
FYI: @ydamigos

Codecov Report

Merging #7518 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7518      +/-   ##
==========================================
- Coverage   55.25%   55.25%   -0.01%
==========================================
  Files         467      467
  Lines       51638    51638
  Branches     9887     9887
==========================================
- Hits        28532    28531       -1
- Misses      19197    19198       +1
  Partials     3909     3909

Impacted Files
Coverage Δ

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b038f2...c84dcf9. Read the comment docs.


ARROW-10867: [C++] Workaround gcc internal compiler error

Several gcc versions (from at least 7.x to 10.x) crash on the current development version of Arrow.
Upstream bug report is at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98282

@github-actions crossbow submit -g linux -g cpp

@github-actions crossbow submit -g example-cpp

x86 CI is ok (the Debian 10 failure is unrelated and due to an obsolete GTest version). ARM64 CI is unfortunately blocked due to missing Travis-CI credits.

mingw failures are https://issues.apache.org/jira/browse/ARROW-10896


Claiming namespace mannypeterson/HeliOS

Package information

Package link: https://registry.platformio.org/libraries/mannypeterson/HeliOS

Description

Hi @MannyPeterson,
Have you tried to log in to [PlatformIO Account(https://docs.platformio.org/en/latest/plus/pio-account.html) using your Github account?

@ivankravets I have but the very email step does not seem to work for me, I never receive the verification email and I have checked the spam folder.
Also, the package seems to still only show release 0.2.6 even though I released 0.2.7 a few days ago.

Hi @ivankravets
Thank you for fixing the crawler. Everything looks good now. 😊
The email address you provided is old but it still works and I didn't get the verification email. I did remove that email address from my GitHub account. I will try again.
❤🇺🇦

Okay, all good now. I logged in with GitHub. What’s next?

I think nothing :)
If you prefer manually publish updates for your library, you can now use https://docs.platformio.org/en/latest/core/userguide/package/cmd_publish.html


core: add vector

Codecov Report

Merging #37 into master will decrease coverage by 1.78%.
The diff coverage is 62.02%.

@@            Coverage Diff            @@
##           master     #37      +/-   ##
=========================================
- Coverage   93.09%   91.3%   -1.79%
=========================================
  Files          80      83       +3
  Lines        1911    2024     +113
=========================================
+ Hits         1779    1848      +69
- Misses        132     176      +44

Impacted Files
Coverage Δ

py_hcl/core/type/vector.py
62.5% <ø> (+62.5%)
:arrow_up:

py_hcl/core/type/sint.py
57.14% <ø> (ø)
:arrow_up:

py_hcl/core/type/uint.py
64.28% <ø> (ø)
:arrow_up:

py_hcl/core/module_factory/merger.py
100% <ø> (ø)
:arrow_up:

py_hcl/core/hcl_ops/__init__.py
84.61% <ø> (ø)
:arrow_up:

py_hcl/core/type/wrapper.py
57.14% <ø> (ø)
:arrow_up:

py_hcl/core/expr/mod_inst.py
70% <0%> (ø)
:arrow_up:

py_hcl/core/__init__.py
100% <100%> (ø)
:arrow_up:

py_hcl/core/expr/convert.py
71.73% <100%> (+5.94%)
:arrow_up:

py_hcl/dsl/module.py
100% <100%> (+9.09%)
:arrow_up:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ee418...25e1b30. Read the comment docs.


Update Readme.md

Most of the examples of razorPay show how to fetch payment details of an order.  However, what took me a while to realize was, how to retrieve the orderId from the created order.
If applied, this PR will improve the documentation on how to get orderId from the order

@harman28 I could not add anyone as a reviewer. Sorry for spamming your mailbox with a comment.

Maybe use status instead of id to demonstrate? The fetch call already uses id, so it feels redundant.

The fetch call uses a variable $orderId and it is not obvious from any of the documentation that how to get this value. This PR is trying to fill that gap. However, this also needs to be updated here https://razorpay.com/docs/server-integration/php/usage/#fetch-order-by-id.


CLI: Add support for listing all packages for a package name

Is your feature request related to a problem? Please describe.
glasskube list shows the list of all ClusterPackages or Packages or both. It should also be possible to list all packages with a particular .Spec.PackageInfo.Name.
Describe the solution you'd like
When glasskube list is called with an argument, only the Packages with that .Spec.PackageInfo.Name should be listed.

I'll take this

Hi @kanha-gupta! This is sort of blocked by an open PR (https://github.com/glasskube/glasskube/pull/817), so I think it would make sense to wait a couple of days before this should be tackled. I'll let you know once it's ready. In the meantime, feel free to explore our other open issues. :slightly_smiling_face:

Hey @kanha-gupta! This issue can now be worked on. If you're still interested, I can assign you. Just let me know!

@kosmoz If nobody work on this, I can work on this.

Sure I'll pick this. @oversampling do you want to work ?

Sure I'll pick this. @oversampling do you want to work ?

Is ok, you can take this.

Hi @kosmoz  @oversampling I had an unexpected travel therefore It would cause delay.
I encourage the community to take this :)

Hi @kosmoz @oversampling I had an unexpected travel therefore It would cause delay. I encourage the community to take this :)

No problem, thanks for letting us know. Safe travels!

@kosmoz I would be happy to take this one

@kosmoz I have created the PR as draft, because there are some suggested changes I would like to have some feedback on first. More details in the "Additional Information" section of the PR


Can variant-supporting reads be saved?

i.e. a bam of split reads and spanning reads

I don't believe the --save-reads option in svviz v1.x (this repository) will annotate reads as such.
The output from svviz2 is divided into separate bams for ref and alt and the tags include some information relevant to this decision. svviz2 isn't quite as polished but the underlying functionality is much more deeply developed and I recommend using it instead if possible.


Update to latest Brother libraries

Any chance you could update the library with the latest drivers from Brother?
There are new types of printers that are unsupported by the current version.

Hello @veermaniperen
Did you manage to update the library?
If yes, would you send a PR across?
Thanks

Sorry @arcadius , I looked into it, but the new libraries are totally different. It became too difficult to my liking ;-)


Dependabot frequently failing to raise PR for pub packages

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
pub
Package manager version
NA
Language version
2.19.6
Manifest location and content before the Dependabot update
/packages/at_secondary_server/pubspec.yaml
dependabot.yml content
version: 2
enable-beta-ecosystems: true
updates:
  # Maintain dependencies for GitHub Actions
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "daily"
  - package-ecosystem: "docker"
    directory: "/tools/build_secondary"
    schedule:
      interval: "daily"
  - package-ecosystem: "docker"
    directory: "/tools/build_virtual_environment/ve"
    schedule:
      interval: "daily"
  - package-ecosystem: "docker"
    directory: "/tools/build_virtual_environment/ve_base"
    schedule:
      interval: "daily"
  - package-ecosystem: "docker"
    directory: "/packages/at_root_server"
    schedule:
      interval: "daily"
  - package-ecosystem: "pub"
    directory: "/packages/at_secondary_server"
    schedule:
      interval: "daily"
  - package-ecosystem: "pip"
    directory: "/tools" # Location of package manifests
    schedule:
      interval: "daily"

Updated dependency

Dependency
From version
To version

collection
1.17.0
1.17.1

basic_utils
5.4.2
5.5.4

meta
1.8.0
1.9.1

args
2.3.1
2.4.0

What you expected to see, versus what you actually saw
I'd expect to see a PR for the dependencies that need to be updated. Instead the logs show that a PR couldn't be raised:
They conclude with:
updater | 2023/05/03 10:40:54 INFO Results:
updater | Dependabot encountered '4' error(s) during execution, please check the logs for more details.
updater | +-------------------------------+
updater | | Dependencies failed to update |
updater | +---------------+---------------+
updater | | collection    | unknown_error |
updater | | basic_utils   | unknown_error |
updater | | meta          | unknown_error |
updater | | args          | unknown_error |
updater | +---------------+---------------+

and on the way show ERROR block for each dependency like:
updater | 2023/05/03 10:40:17 ERROR <job_656542567> Error processing collection (Dependabot::ApiError)
updater | 2023/05/03 10:40:17 ERROR <job_656542567> {"errors":[{"status":500,"title":"Internal Server Error"}]}
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/api_client.rb:30:in `create_pull_request'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/service.rb:31:in `create_pull_request'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:250:in `create_pull_request'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:134:in `check_and_create_pull_request'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:65:in `check_and_create_pr_with_error_handling'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:34:in `block in perform'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:34:in `each'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/update_all_versions.rb:34:in `perform'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:72:in `run'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:38:in `perform_job'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:52:in `run'
updater | 2023/05/03 10:40:17 ERROR <job_656542567> bin/update_files.rb:23:in `<main>'

Native package manager behavior
NA
Images of the diff or a link to the PR, issue, or logs
Logs are at https://gist.github.com/cpswan/9884347c0cddc7e29b6bb5bf9113fd45
Smallest manifest that reproduces the issue
No response

@cpswan I just pushed a fix for this on the server. Can you run the job again and verify it works now? Thanks!

Thanks for the quick response @jakecoffman
It's still saying Dependabot encountered an unknown error Dependabot failed to update your dependencies because an unexpected error occurred. See the logs for more details., but I'm seeing far less evidence of errors in the logs (new gist). No sign of a PR though :(
There's also another dependency needing updating since yesterday, and better reporting of the changes that should be happening:
updater | +------------------------------------------------+
updater | |      Changes to Dependabot Pull Requests       |
updater | +---------+--------------------------------------+
updater | | created | args ( from 2.3.1 to 2.4.1 )         |
updater | | created | crypto ( from 3.0.2 to 3.0.3 )       |
updater | | created | collection ( from 1.17.0 to 1.17.1 ) |
updater | | created | basic_utils ( from 5.4.2 to 5.5.4 )  |
updater | | created | meta ( from 1.8.0 to 1.9.1 )         |
updater | +---------+--------------------------------------+

@cpswan thanks for checking, looks like it made more progress. I made another change if you want to try again. I think this time it should put up some PRs. 🤞

Thanks @jakecoffman the overnight run beat me to it...
This time I see a green tick before Dependabot encountered an unknown error rather than the usual red triangle, which is a bit weird. But still no PR.

I've put the latest logs in another gist, though once again they don't have much to say about what went wrong in raising the PR.

Dependabot is receiving the following error from GitHub when it tries to put up the PR:
422 - tree.path contains a malformed path component

I ran the Dependabot CLI to diagnose further: dependabot update pub atsign-foundation/at_server --directory /packages/at_root_server -o out.yml
In the out.yml the symlink mentioned here seems to be included in the update even though the symlink itself didn't change, just the contents of the file that it points to.
That's probably a bug in Dependabot's Pub implementation we'll have to sort out.

That error was due to running jobs without credentials in the CLI. I fixed it in #7277, so if you pull a new version of the pub updater it should work: docker pull ghcr.io/dependabot/dependabot-updater-pub:latest
It looks like the issue here is Pub considers all pubspecs under the directory that is configured: https://github.com/dependabot/dependabot-core/blob/03069cc49e07fb3b658b0a5f1bda900171d1889f/pub/lib/dependabot/pub/file_fetcher.rb#L27
So we should filter out symlinks since they're either already covered by the glob, or they're outside the directory and shouldn't be considered. I can fix that up soon.

Some progress... I'm now seeing clean runs with the dependabot CLI and in Dependency Graph > Dependabot.
But, no PR actually raised. So it's still silently failing somewhere.

@cpswan  Has this improved since https://github.com/dependabot/dependabot-core/pull/7265 was deployed?

@sigurdm sadly no improvement. The logs conclude in a way that suggests that PRs have been raised:
updater | 2023/06/02 01:11:39 INFO Results:
updater | +------------------------------------------------+
updater | |      Changes to Dependabot Pull Requests       |
updater | +---------+--------------------------------------+
updater | | created | collection ( from 1.17.0 to 1.17.2 ) |
updater | | created | crypto ( from 3.0.2 to 3.0.3 )       |
updater | | created | meta ( from 1.8.0 to 1.9.1 )         |
updater | | created | yaml ( from 3.1.1 to 3.1.2 )         |
updater | | created | basic_utils ( from 5.4.2 to 5.5.4 )  |
updater | +---------+--------------------------------------+

But no actual PRs:

@jeffwidman not sure I understand those logs. Does this look like a problem with the pub integration?

Thanks @cpswan ; yes we're working on improving and surfacing actionable error messages. I hope this helps!

After adding groups to my dependabot.yml it looks like things are working when they weren't before.

But there's no actual PR from that run :(
Full logs in this gist: 825091200.log
The pub section of my dependabot.yml now look like this:
  - package-ecosystem: "pub"
    directories:
      - "/packages/at_root_server"
      - "/packages/at_secondary_server"
    schedule:
      interval: "daily"
    groups:
      pub:
        patterns:
          - "*"

Extra weirdness... in the time it took me to write the comment above (which was already an hour after the Dependabot run), the status has now changed to failed.
Nothing new in the logs, but I do see this:
Dependabot ran into an issue when attempting to create the pull request

Dependabot encountered the following error:

POST https://api.github.com/repos/atsign-foundation/at_server/git/trees: 422 - tree.path contains a malformed path component // See: https://docs.github.com/rest/git/trees#create-a-tree
[Troubleshoot Dependabot errors](https://docs.github.com/github/managing-security-vulnerabilities/troubleshooting-dependabot-errors)

I'm guessing something took over an hour to time out, and then that eventually propagated back to the Dependency graph insights.

Hi all. Are any updates coming? I'm experiencing the very similar symptoms.
More data:

Symptoms.
Config.


distro-base: python3 minimal poc

Issue #, if available:
Description of changes:
@jonahjon needed a python 3.9 image for emissary in eks-a.  This adds a new python image with 3.9, for both al2 and al22 (for when we switch over).
There is a new pattern introduced here since there are a number of python versions still in support, even al2 has 2.7 3.7 and 3.8.  For now we are only building 3.9 since thats all we need, but we may introduce older ones just depending on need/asks.  There is only going to be one ecr repo for python and each image will tagged with its version, aka 3.9-latest vs just latest.  The makefile has been changed to be versioned_image aware to handle these cases and the python dockerfile has the code to build 3.7 and 3.8, mainly as a POC/template for future builds that may require multiple versions.
I have built both platforms on both os versions locally and included the tracking files for reference.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

Going to go ahead and merge this, but I welcome more reviews. These changes should only affect the new image being built, so risk is low. I want to kick off a build this morning since these things take hours.


Calculate work gaps based on submission date

Context
We calculate whether a candidate has a gap at the end of their work history based on when their last job/volunteering ended (as we do now) and the date they submitted their application (rather than today's date).
When we work out whether a candidate has a work gap at the end of the work history we use something like this: (Time.zone.now - last_job_end_date) > 1.month. Because today's date is a moving target the outcome of this calculation is fairly likely to change from false to true while the provider is going through their process. Instead we should use (date_application_submitted - last_job_end_date) > 1.month
Changes proposed in this pull request

[x] Use ApplicationForm.submitted_at as the 'baseline' for work break calculations.
[x] Update specs including one new initially failing spec

Guidance to review

Is there anywhere else in the code for work gaps that uses current date in the same way that I've missed?

Link to Trello card
https://trello.com/c/9KbrH4yC/1721-calculate-work-gaps-based-on-submission-date
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

@chubberlisk I've updated app/services/check_breaks_in_work_history.rb - I think it makes sense to have that working the same way. What do you think?


1.20.2 crash on startup

So kind of a weird one, if you have a pre-existing config from 1.16, it loads fine, but when you get in-game nothing works with gts.
If you don't have a config, crashes on startup.
https://pastebin.com/1d5PkXV3

So the startup crash from the new config is because the database isn't setup. But I think the config changed between the two versions potentially?

So the startup crash from the new config is because the database isn't setup. But I think the config changed between the two versions potentially?

I think you are correct, regenned and synced to mysql, no more crash on startup. However, this error appears upon join and same you do not have permission to use this command "even though I do"
[09:33:32] [Server thread/INFO] [net.minecraft.server.MinecraftServer]: A wild TheWickening appeared! [09:33:32] [envyware_concurrency_1/ERROR] [EnvyGTS]: Error when loading attribute data for com.envyful.gts.forge.player.GTSAttribute java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "com.envyful.gts.forge.shade.envy.api.forge.player.ForgeEnvyPlayer.getUniqueId()" because "this.parent" is null 	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?] 	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) [?:?] 	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) [?:?] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) [?:?] 	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?] 	at java.lang.Thread.run(Thread.java:840) [?:?] Caused by: java.lang.NullPointerException: Cannot invoke "com.envyful.gts.forge.shade.envy.api.forge.player.ForgeEnvyPlayer.getUniqueId()" because "this.parent" is null 	at com.envyful.gts.forge.player.GTSAttribute.load(GTSAttribute.java:83) ~[EnvyGTS-Forge-4.5.7-1.20.2.jar%23166!/:?] 	at com.envyful.gts.forge.shade.envy.api.player.attribute.PlayerAttribute.load(PlayerAttribute.java:66) ~[EnvyGTS-Forge-4.5.7-1.20.2.jar%23166!/:?] 	at com.envyful.gts.forge.shade.envy.api.player.attribute.PlayerAttribute.load(PlayerAttribute.java:28) ~[EnvyGTS-Forge-4.5.7-1.20.2.jar%23166!/:?] 	at com.envyful.gts.forge.shade.envy.api.player.save.impl.EmptySaveManager.lambda$loadAttribute$0(EmptySaveManager.java:46) ~[EnvyGTS-Forge-4.5.7-1.20.2.jar%23166!/:?] 	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?] 	... 6 more

Does this happen with the latest version?


[bug] Add missing disabled prop to Radio

Missing ability to set disabled state on radio https://mantine.dev/core/radio/#disabled-state

@ahmedhalac - yes!  That would be fantastic :slightly_smiling_face:
Let me know if you have any questions

PR #425 submitted

oops @ahmedhalac looks like @ahmedhalac beat you to it :horse_racing:
But there are other good first issues - I'd be delighted to have you contribute to DMC!
Thank you both :pray:

oops @ahmedhalac looks like @ahmedhalac beat you to it 🏇
But there are other good first issues - I'd be delighted to have you contribute to DMC!
Thank you both 🙏

Hi @AnnMarieW
Who beats who exactly?! 😅

@namakshenas looks like i beat myself 😄

Gotta love the DMC community!  An issue was reported a couple hours ago, and not just one, but two people offer to help fix it.
Soo cool!  :heart_eyes:


Docs gh 1

Updated to say "if you're not" instead of "if you don't" as the previous line due to the "are using" in the previous line.

Thanks!


Improve the text at the top of the home page

Harish: Received the latest home page text from the product team.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: chku123 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


typeof type guards don't work with switch statements

TypeScript Version:  2.3
Code
declare function parse(input: string): boolean | string | number

const data = parse('whatever')

switch (typeof data) {
    case 'number':
        console.log(data.toFixed())
    case 'string':
        console.log(data.toUpperCase())
    case 'boolean':
        console.log(!data)
}

Expected behavior:
I would expect data type to be refined in each case & for this code to check.
Actual behavior:
data type does not seems to get refined by switch cases, there for errors are reported when data is treated as number and as string:
Property 'toFixed' does not exist on type 'string | number | boolean'.
  Property 'toFixed' does not exist on type 'string'.

Property 'toUpperCase' does not exist on type 'string | number | boolean'.
  Property 'toUpperCase' does not exist on type 'number'.

Duplicate #2214.


Plotly templates

Xiplot currently uses the default Plotly template. I don't really like the grey background, especially for scatterplots (and especially for the slisemap plugin where I use a continuous colour). Would it be okay to switch to "plotly_white" that has a white background?
I also implemented a mechanism for switching to "plotly_dark" when the dark mode is activated.

Unless RDKit can generate a svg:s with dark backgrounds I think it is best to leave the SMILES plot as is (instead of coming up with replacement colours for everything in the svg:s).

Unless RDKit can generate a svg:s with dark backgrounds I think it is best to leave the SMILES plot as is (instead of coming up with replacement colours for everything in the svg:s).

@Aggrathon I found a bit of a cheeky solution to this problem, but it's probably easier if you add the CSS for it:

keep the --smiles-img-bg-color to white even in dark mode (or tweak it after step 2 is applied)
apply filter: hue-rotate(180deg) invert(100%) to the .smiles-img in dark mode

In theory, that is not a bad idea, but a in practice I (as a non-chemist) would prefer the grey-blue background to the inverted colors: (left: default, middle: inverted, right: current dark mode)

Does your PR also fix the warning/error message popups from https://www.dash-mantine-components.com that we use? Apparently they support dark mode out-of-the-box but so far I'm not seeing it in the main branch version.

I also found that (again in the main branch, please disregard if that's already fixed in your PR) the text input for cluster regex and smiles strings is quite dark in dark mode

In theory, that is not a bad idea, but a in practice I (as a non-chemist) would prefer the grey-blue background to the inverted colors: (left: default, middle: inverted, right: current dark mode)

I've fiddled around with filters a bit more and there are certainly things we could do with them in the future. However, I think that to make SMILES really work in dark mode, xiplot should manually string-replace all black lines with white in dark mode, the rest can then be handled by slightly inverting the colours (e.g. 10%) and increasing their brightness.
But that seems to be work for the future, for now perhaps a slightly darker background would be enough, since right now my personal user experience is to think that dark mode doesn't do anything for the SMILES plot which still looks a bit too bright (and this is only about the background colour, the other ones should remain mostly the same as you pointed out)

Does your PR also fix the warning/error message popups from https://www.dash-mantine-components.com that we use? Apparently they support dark mode out-of-the-box but so far I'm not seeing it in the main branch version.

This PR is only (mostly) for the plots.

I also found that (again in the main branch, please disregard if that's already fixed in your PR) the text input for cluster regex and smiles strings is quite dark in dark mode

I did notice one of those, and I've added some css for input fields (that fixes both).

I think we can soon land this, and I'll upgrade the WASM branch after that


Inconsistent behavior

I deployed it here: https://basic-pwa.vercel.app/
It worked for me initially.. and for Austin too:

But now I get this:

Austin also got an error the first time

Any ideas on how to debug this in a good way?
cc @technophile-04 @Pabl0cks

Can confirm this inconsistent on mobile :(, happened to me many time
For some reason navigator.serviceWorker.getRegistration() and swRegistration.pushManager.subscribe(options) from https://github.com/BuidlGuidl/PWA-burner-wallet/blob/b17797cea25b39efba00010244b217f66d5e6521/packages/nextjs/utils/service-workers/index.ts#L12
is not working properly on mobile devices, I am on it and will try to fix this nicely 🙌

Closing this too.
But @Pabl0cks , feel free to do a test again with the merged changes from #4 and see if your issues are solved. We can open more specific issues if not.

Awesome job @technophile-04 with the last PR this is working great!! 🔥🙌
This is what I've found (very edge cases probably):

Environment variables on Vercel only work after a Vercel deployment, so if you yarn vercel from console, then set the variables when the project is created in Vercel, you'll need to yarn vercel again to make push notifications work.
I think this is working as intended due to Vercel specs, and just need to be documented in Readme, I'll take care of that 🙌

Sometimes after a period of inactivity, my first "Notify all" throws a 500 internal error. Refreshing the webpage fixed it, and happened only like once or twice. I think we can leave it for now probably.

After some usage in several browsers on desktop and mobile (like 3 on each one), sometimes either my Desktop (all browsers) or my Mobile (all browsers) stopped getting notifications, but the other device still was receiving them. No errors, everything OK in console.
Tried cleaning firestore database, tried giving it time to maybe "unban" my device if was some kind of spam problem, also tried re-deploying and generating new keys. Nothing worked to try to fix it, until I tried using a VPN, suddenly all my unreceived notifications started popping. Seems like either Vercel, Firebase or your own device is preventing spam and not showing notifications on suspicious devices.
Probably this doesn't happend with normal usage

TYSM Shiv for the fast fixes, will try to understand everything you changed 🙃


WIP - List end fixes

Description
Clean up list end processing
Fix the Dangerfile and remove .rubocop.yml
Issues Resolved
#109
#175
#176
Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

This change is

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Warning

:warning:
This is a big Pull Request.

  Generated by :no_entry_sign: Danger


Block error rate

It should be possible to optionally display the block error rate (BLER), i.e. percentage of erroneous blocks during the last n blocks or seconds.
There are two distinct definitions of BLER, depending on the time of calculation: either before (transmission BLER) or after error correction (decoding BLER). Decoding BLER is perhaps more useful for redsea users (?).
The BlockStream member block_has_errors_ is already nearly suitable for this, but for transmission BLER it would need to be able to count error-corrected blocks as well. This would also alter the criteria for sync drop. Whether this is a good thing needs to be tested.
The BLER value should not perhaps refer to a single group; otherwise it could only get one of the values 0, 25, 75, or 100 %. Instead, it should be an average over a dozen or so groups. This may be misleading though, since almost everything else in the JSON object refers to the group at hand.

On one of my PCs I saw by chance that the BER is not a percentage (0-100), but a long number (10 digits or so). I'll check and try to reinstall redsea there ...

Thanks. I haven't seen this behavior, but I'm suspecting this line, where booleans are directly being used in an std::accumulate, will try and change it soon: https://github.com/windytan/redsea/blob/master/src/groups.cc#L140

I found it, it's on my Raspberry 3B. Even after a new compiling it shows that ...
But I have a second installation of redsea thanks to https://github.com/hayguen/fmlist_scan and this works :-)

$ rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 19.7 -F 0 -f 97.8M | ~/apps/redsea/src/redsea -E
Found 1 device(s):
0:  Realtek, RTL2838UHIDIR, SN: 00000001
Using device 0: Generic RTL2832U OEM
Found Rafael Micro R820T tuner
Tuner gain set to 19.70 dB.
[R82XX] PLL not locked for 1925000 Hz!
Bandwidth set to automatic resulted in 290000 Hz.
Tuned to 97458000 Hz.
Oversampling input by: 8x.
Oversampling output by: 1x.
Buffer size: 5.99ms
Exact sample rate is: 1368000.013046 Hz
Sampling at 1368000 S/s.
Output at 171000 Hz.
Allocating 15 zero-copy buffers
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"artificial_head":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"14A","other_network":{"kilohertz":99300,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"compressed":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"dynamic_pty":true},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"group":"14A","other_network":{"kilohertz":88600,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"stereo":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"group":"14A","other_network":{"kilohertz":88800,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"artificial_head":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"compressed":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"14A","other_network":{"kilohertz":99500,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"dynamic_pty":true},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ps":"RADIO-K ","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"stereo":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"3A","open_data_app":{"app_name":"RDS-TMC: ALERT-C","oda_group":"8A"},"pi":"0xA502","prog_type":"No PTY","tmc":{"system_info":{"gap":3,"service_id":0}},"tp":true}

$ rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 19.7 -F 0 -f 97.8M | redsea -E
Found 1 device(s):
0:  Realtek, RTL2838UHIDIR, SN: 00000001
Using device 0: Generic RTL2832U OEM
Found Rafael Micro R820T tuner
Tuner gain set to 19.70 dB.
[R82XX] PLL not locked for 1925000 Hz!
Bandwidth set to automatic resulted in 290000 Hz.
Tuned to 97458000 Hz.
Oversampling input by: 8x.
Oversampling output by: 1x.
Buffer size: 5.99ms
Exact sample rate is: 1368000.013046 Hz
Sampling at 1368000 S/s.
Output at 171000 Hz.
Allocating 15 zero-copy buffers
{"bler":87,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":79,"group":"14A","other_network":{"kilohertz":99900,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":70,"debug":["redsea compiled without TMC support"],"group":"3A","open_data_app":{"app_name":"RDS-TMC: ALERT-C","oda_group":"8A"},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":62,"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":56,"di":{"stereo":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":47,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":39,"group":"14A","other_network":{"kilohertz":99300,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":31,"di":{"artificial_head":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":22,"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":14,"di":{"compressed":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":6,"group":"14A","other_network":{"kilohertz":98600,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2,"di":{"dynamic_pty":true},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ps":"RADIO-K ","ta":false,"tp":true}
{"bler":2,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2,"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2,"di":{"stereo":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2,"group":"14A","other_network":{"kilohertz":89100,"pi":"0xA203","tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":0,"di":{"artificial_head":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":0,"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":0,"di":{"compressed":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}

Ah, I think I found the bug. Just so I remember this, it was introduced in 0.18 when I removed the empty value-initializers, not supported by GCC 4.9, from RunningAverage and RunningSum.

I've pushed a fix to master. Does this work for you?

No, it did not work. Same output.

$ rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 14 -F 0 -f 97.8M | ./redsea -E
Found 1 device(s):
0:  NOXON, DAB Stick, SN: 0
Using device 0: Terratec NOXON DAB/DAB+ USB dongle (rev 1)
Found Fitipower FC0013 tuner
Tuner gain set to 17.90 dB.
Bandwidth set to automatic resulted in 0 Hz.
Tuned to 97458000 Hz.
Oversampling input by: 8x.
Oversampling output by: 1x.
Buffer size: 5.99ms
Exact sample rate is: 1368000.013046 Hz
Sampling at 1368000 S/s.
Output at 171000 Hz.
Allocating 15 zero-copy buffers
{"bler":2147483647,"group":"14A","other_network":{"pi":"0xA213","prog_type":"No PTY","ta":true,"tp":false},"pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"stereo":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"di":{"artificial_head":false},"group":"0A","is_music":true,"pi":"0xA502","prog_type":"No PTY","ta":false,"tp":true}
{"bler":2147483647,"group":"2A","pi":"0xA502","prog_type":"No PTY","tp":true}
{"bler":2147483647,"debug":["TODO 8A"],"group":"8A","pi":"0xA502","prog_type":"No PTY","tp":true}

Have deleted the complete redsea folder and recompiled.
$ ~/apps/redsea/src/redsea --version
redsea 0.18 by OH2EIQ
$ which redsea
/usr/local/bin/redsea
$ redsea --version
redsea 0.17.1 by OH2EIQ

Yes, it has to do with 0.18 as the 0.17.1 works on the same raspberry.

pi@raspberrypi:~/apps/redsea $ git log
commit c82f1cead2b2f1473f5a3d6c49da3660aa64fee5
Author: Oona Räisänen<EMAIL_ADDRESS>Date:   Wed Aug 14 10:01:20 2019 +0300

    fix double-conversion of BLER to percentages

I can confirm that this is still not working on a Raspberry Pi 4B. Is there anything I can do to help?
gcc (Raspbian 8.3.0-6+rpi1) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

redsea 0.19-SNAPSHOT by OH2EIQ

Are you seeing this for all signals or a specific one?

It's the same behavior as andimik's output above. I'd be happy to test any suggestions you have.

Can you test if the current master fixes this?

I can confirm that fixes it. Thank you!
{"bler":27,"callsign":"WJQB","group":"2A","pi":"0x6E0D","prog_type":"No PTY","radiotext":"HITS 106","rx_time":"Sun Mar 29 06:50:51 2020","tp":true}
{"bler":25,"callsign":"WJQB","debug":["TODO: Unimplemented ODA app 29555"],"group":"3A","open_data_app":{"app_name":"Enhanced early warning system","message":93,"oda_group":"12A"},"pi":"0x6E0D","prog_type":"No PTY","rx_time":"Sun Mar 29 06:50:51 2020","tp":true}
{"bler":29,"callsign":"WJQB","pi":"0x6E0D","rx_time":"Sun Mar 29 06:50:51 2020"}
{"bler":31,"callsign":"WJQB","pi":"0x6E0D","rx_time":"Sun Mar 29 06:50:51 2020"}
{"bler":31,"callsign":"WJQB","di":{"dynamic_pty":true},"group":"0A","is_music":true,"pi":"0x6E0D","prog_type":"No PTY","rx_time":"Sun Mar 29 06:50:52 2020","ta":false,"tp":true}
{"bler":31,"callsign":"WJQB","group":"2A","pi":"0x6E0D","prog_type":"No PTY","rx_time":"Sun Mar 29 06:50:52 2020","tp":true}
{"bler":33,"callsign":"WJQB","pi":"0x6E0D","rx_time":"Sun Mar 29 06:50:52 2020"}
{"bler":38,"callsign":"WJQB","group":"2A","pi":"0x6E0D","prog_type":"No PTY","radiotext":"HITS 106","rx_time":"Sun Mar 29 06:50:52 2020","tp":true}


layers/meta-balena-5x-owa & layers/meta-owasys: improved connectivity

Several minor details has been fixed which improves overall connectivity and integration with balena cloud. Most changes consist of services and scripts as well as some conf files. Also meta-owasys layer has been upgraded.
Changelog-entry: Owasys layer updated improving connectivity and integration with BalenaCloud.
Signed-off-by: Alvaro Guzman<EMAIL_ADDRESS>

Hello @alexgg, any help merging this PR?
Thanks in advance!

hey @owzagj there are a few things in the PR that we are not usual for device repositories and divert from the rest of the balenaOS devices.  We try very hard to keep a default balenaOS across device types as it facilitates testing and debugging. I am aware this is a custom device repository so there is more flexibility, but I am convinced that not diverging will allow you to benefit from balenaOS improvements and support.
So if you don't mind I'd like to understand the thinking behind some of the changes.

You add a pollux and pmsrv units, one of which requires an extra bind mount. This seems like something that should live in the application container instead where it is easier to maintain and update. What's the reason that this needs to be customized in the OS?
You also introduce a couple of services switchwifi and switchgsm that finish up calling a couple of binaries. Did you try using the resin-init service that is typically used for device specific initialization? Another usual mechanism to enable networking devices at boot is using udev rules to enable them on detection instead of adding systemd services as the latter diverts the boot sequence from the balenaOS defaults.

Hello @alexgg thanks for your answers:

You add a pollux and pmsrv units, one of which requires an extra bind mount. This seems like something that should live in the application container instead where it is easier to maintain and update. What's the reason that this needs to be customized in the OS?
There are a couple of reasons for this. First of all, our device has a secondary cortex M0 which controls several parts of the system including power. This service, pmsrv must be present from the very beginning of the bootup process as the cortexM0 is waiting for a signal which, if not received, will reset the entire system switching directly the onboard PMIC.
The pollux service might be integrated in a container but several questions come to my mind about this. We have not much experience working with containers so integration would require development, aka time. On the other hand this is a service which works at low level, it powers on a GPS module and get data out of it, so other apps have them available. Being a low level application, is it required to work inside a container? It is also part of our value as company, as this is part of our custom tools.

You also introduce a couple of services switchwifi and switchgsm that finish up calling a couple of binaries. Did you try using the resin-init service that is typically used for device specific initialization? Another usual mechanism to enable networking devices at boot is using udev rules to enable them on detection instead of adding systemd services as the latter diverts the boot sequence from the balenaOS defaults.

The problem here is that both the wifi/ble & cellular modules do not start powered on and require a command to start. This means that udev rules won't come to play as no devices will appear, so udev can be discarded.
Resin-init service could be explored to be responsible for this, and I'm likely to test it tomorrow, but I have not much faith on this, as it runs after NetworkManager and ModemManager. I think that as nor cellular neither wifi interfaces will be present at Network or ModemManager service initialization, connectivity may fail.
Anyway, I'll reach to you tomorrow to see if we can use resin-init to start wifi and gsm.
Thanks in advance

hi @owzagj thanks for the extra details and for working with us in identifying the valid use cases that are not covered by the current OS device integration abstractions. Once we identify those we will extend the OS abstractions to support them.
Let's speak about each component in turn:

I understand the pmsrv service is very tightly coupled to the hardware and it needs to be started by the OS. I will discuss this use case internally and come back to you.

The pollux service. This is a user space service that interacts with a hardware component. This is something that I still think should be in a container. You mention is is part of your company's IP and adds value to the product, and that is one more reason why you would want to add it to the application container. BalenaOS should be seen as a lightweight container manager/hypervisor, not an embedded OS in the traditional sense. You mention the pollux service makes GPS data available to other services, so depending on how this data is being accessed it might need some more thinking. Maybe it can be placed in a user volume that can then be shared via NFS.

About switchwifi and switchgsm, please let us know whether they can be made to work from resin-init. If not, we may need to find a better way to handle this use case.

Hello @alexgg ,
I've started both wifi and gsm from resin-init-board and it seems to work like a charm. Tomorrow I'll perform more testing to be sure there arre no problems with this approach but thanks in advance for the suggestion.
About the pollux to be launched by a container I've got a couple of questions:

How would we flash that container in our default image? Would it be contained in the SD flasher image from the beginning or would we need to connect to balenaCloud and installed it from here?

In the case that we decide to create a container for the pollux, is it needed to hold that container in your balena registry?

We have little experience with containers as for the moment.
Thanks!

hey @owzagj sorry for the delay - it might be better if you use the forums as we don't monitor github comments. Answering your questions:

How would we flash that container in our default image? Would it be contained in the SD flasher image from the beginning or would we need to connect to balenaCloud and installed it from here?

The container can be preloaded into the images so on first boot it does not need to be downloaded from the cloud.

In the case that we decide to create a container for the pollux, is it needed to hold that container in your balena registry?

The pollux container will be a service on a microservices application, so one of several containers that make up the application. It will be pushed to the balenaCloud registry as the rest of the application, so the application gets build by the cloud builders on push and the resulting image is deployed to the balenaCloud registry so it can be installed in your fleet by the supervisor.
In this way, the pollux service just becomes part of the application and it easily updated and manages independently from hostOS updates that need a more careful updating approach.

Hello, sorry for the delay here. Okay, so I'm removing polluxgps for the moment to eventually create a container with it. Also moved Wifi&GSM start to "resin-init-board" and it seems to work, no problems.
Beyond this we are upgrading our yocto layer and fixing some flaws here and there.
What do you think guys @floion @alexgg ? Is it okay?
Thanks


Fix item-submission.xml DTD

Currently the DTD is not valid for the new item-submission.xml format. https://jira.lyrasis.org/browse/DS-4264

@tdonohue I've had a look at this issue and it seems to me that we're running into a conceptual problem here. There are currently two different "step" tags present within this item-submission.xml:

https://github.com/DSpace/DSpace/blob/main/dspace/config/item-submission.xml#L49
https://github.com/DSpace/DSpace/blob/main/dspace/config/item-submission.xml#L195

One of these step tags contains a heading, processing-class and type element. The other step is without any of these elements  (and shouldn't ever contain any of these elements). This means that, conceptually, we're dealing with two different "step" xml tags whilst a .dtd is only able to properly identify and describe a single xml tag with a given name.
This leaves us with two options:

We alter the dtd at this location to make every element optional for the "step" xml tag
We change the name of one of the "step" xml tags so that we're able to properly define both

I heavily prefer the second option. If we were to simply make everything with regards to "step" optional in the dtd, then it would basically mean that we don't have a dtd because nothing is enforced and we could easily allow mistakes to happen in these xml files because we have no system of checking.
The second option would allow us to keep the enforcing rules on both elements, making the entire setup more stable.
The second option has the drawback of taking a lot more time to implement. We'll have to change the xml file and the dtd file, but we'll also likely have to alter the parsing of these files.

I heartily agree with the objection concerning validation, but I note that at the moment we are using a non-validating parser so none of our definitions are enforced during syntactic analysis anyway.  SubmissionConfigReader is peppered with tests to ensure that required elements are present.
A third option:  translate the DTD to XML Schema, renaming one of the two "step" elements.  Scrap all of our hand-built tree-parsing code and generate it automatically from the schema using jaxb2-maven-plugin.  This approach is probably the most disruptive of surrounding code, but it hands us the data structures that we need, ready to drive the submission-wizard engine.

@Raf-atmire :  Good point.  I agree with your analysis. Could you provide a rough estimate of how much more time it would take to implement the second option (rename one step tag)?  Are we talking a few extra hours?
Looking more closely here, I suspect the <step> under <step-definitions> could be renamed to be either <step-definition> or <step-def>.  It's role is to define the step.
That would mean the <step> under <submission-process> could keep the same name.  We may want to change it's id attribute though, as that references back to the step-definition.  Maybe that should be renamed to definition-id (or similar).
So we'd end up with something like this...
<step-definitions>
    <step-definition id="sample">
         <heading>Sample Step</heading>
         <processing-class>...</processing-class>
         <type>sample</type>
    </step-definition>
    ...
</step-definitions>
<submission-definitions>
    <submission-process name="traditional">
        <step definition-id="sample"/>
          ....
    </submission-process>
</submission-definitions>

@mwoodiupui : While I definitely understand the desire to scrap DTDs in favor of XML Schema + automatic code generator (like jaxb), that's unfortunately out-of-scope for the current DSpace 7.0 development effort / budget.  I do agree with you though that we may want to consider this for the long term (for all XML-based configs), as it'd be less code for us to write/maintain manually.  (Though, at the same time, we might also want to question honestly whether XML-based configs should be replaced with something easier to manage...that's another topic altogether we should consider here.)

If we enable validation, then I think that submission-definitions | submission-process | step | @id must be renamed, else it is required to be unique within the document, and I don't think we mean that.  The point of separating out step-definitions is that a step-definition should be reusable in multiple submission-definitions, no?
However step-definitions should have unique names, and @id fills that bill perfectly.

@tdonohue I estimate the rewriting of the step tag under the step-definitions like you've mentioned to be about 4 hours of implementation work and testing work combined.

@Raf-atmire : Sounds fine. I've updated the estimate on this ticket to be 6 hrs (originally 2 hours + your 4 hour estimate)


Version number does not increment when you remove an embedded collection

I have a Doctrine ODM document that uses the @Version feature. One of the properties on my document is an embedded collection.
I notice that when I make additive updates to my document, the version number is incremented via this Doctrine code:
https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php#L348-L362
However, I also noticed that when I remove from my document the embedded collection value, the version does not increment.
This is likely due to the differences deletions are triggered via this code:
https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Persisters/CollectionPersister.php#L73-L88
I would like to be able to have my version number increment when items are removed from my document even when the item is an embedded collection.
How do I make my version number increment when I remove my embedded collection from my document?
Example test which demonstrates the problem:
https://gist.github.com/blockjon/857d7cba7cdb4c865cf9

#985 is merged, so this should be fixed.


[PE-D][Tester E] "note 1" removes note for index 1

Entering "note 1" removes the note from person 1.
Is this the intended effect? It is not in the UG

Labels: type.DocumentationBug severity.Medium
original: tohpinren/ped#4

Same as #195.


Title: Implement User Dashboard in Frontend

Description:
As part of the projectSpark frontend development, we need to implement a user dashboard that provides a personalized overview of the user's profile, ideas, feedback, and progress. This dashboard will be the central hub for users to manage their data and activities.
Features to be included in the user dashboard:

Profile Section:
Display user's profile picture and basic information.
Allow users to update their profile information and profile picture.

Ideas Section:
Show a list of the user's created ideas with their titles, descriptions, and tags.
Allow users to create new ideas and edit/delete existing ones.
Provide links to view the details of each idea.

Progress Section:
Show the progress of each idea (if applicable), such as the completion status or milestones achieved.
Provide visualization of progress using charts or progress bars.

Notifications Section:
Display notifications for updates related to the user's ideas, followed ideas, and comments.
Allow users to mark notifications as read or dismiss them.

Activity Log:
Show a chronological list of the user's recent activities, such as idea creations, feedback received, and comments made.

Settings:
Provide a settings section for users to manage their account preferences and notification settings.

Logout:
Include a logout button that allows users to log out of their account.
The user dashboard should be responsive and accessible on various devices. API calls to the backend will be required to retrieve and update user data and activities.

Let's discuss the implementation details, design considerations, and any specific requirements related to the user dashboard in this issue.

Now we are done with our setup. I Want to know when we will start and did you have any images for the project.


Feature/support lists with inline formats

Coverage remained the same at 92.061% when pulling 822d460e6004005c51e924149afde30257c30ed2 on ageekymonk:feature/support-list-with-inline-formats into 677defd0e024333503d8c946dd4ba3f32ad3e5d2 on chaseadamsio:master.

Coverage remained the same at 92.061% when pulling e7b6f9735552b8656358de05a83fd8a3f2dfd138 on ageekymonk:feature/support-list-with-inline-formats into 677defd0e024333503d8c946dd4ba3f32ad3e5d2 on chaseadamsio:master.

thanks!

@ageekymonk, tried to find a way to contact you not through github. If you're on twitter, can you reach out to me at @chaseadamsio and if not, shoot me an email at<EMAIL_ADDRESS>Wanted to say thanks for contributing.


Vision Transformer for ADNI Dataset

This pull request is an implementation of a Vision Transformer trained on the ADNI dataset.
The trained model acheived a test accuracy of 66.9%, which unfortunately does not meet the requirement of 80%.
The following files are included in this pull request under recognition/46975115_ViT:

figures&images file: contains figures and images for the README.md file
README.md: Description of algorithm and the problem that it solves, how it works in a paragraph and a evidence of training and results.
dataset.py: Preprocessing and loading of the dataset.
modules.py: Implementation of the vision transformer model.
predict.py: Generate results for the trained model.
train.py: Training of the model, provides plots of accuracy/loss and test accuracy.
utils.py: Stores hyperparameters and optimizer function.

This is an initial inspection
1) Recognition Problem:
a) Algorithm solves the respective pattern recognition problem appropriately: (+3)
b) Algorithm implemented in PyTorch demonstrated and functions as intended to solve the respective problem: (+3)
c) Good design implemented in PyTorch that solves the problem: (+1)
d) Commenting: (+1)
e) Algorithm is normal or above difficulty while implemented in TF/PyTorch while solving the respective problem: Hard level (+5)
f) Algorithm is hard difficulty while implemented in TF/PyTorch while solving the respective problem: Hard level (+5)
2) Commit Log:
a) Meaningful commit messages with evidence of individual work and originality: (+2)
b) Progressive commits and logical log structure providing evidence of individual work and originality: (+3)
3) Documentation:
Requirement:
Tittle: Done
Description of the algorithm: Done
Problem that it solves: Done
How it works in a paragraph (example any pre-processing): Done
Figure/visualisation (any input, output & results): Done
Dependencies: Done
Marking:
a) Description and explanation of the working principles of the algorithm implemented and the problem it solves: (+5)
b) Description of usage and comments throughout scripts: (+3)
c) Proper formatting using GitHub markdown: (+2)
4) Pull Request
a) Creating a pull-request into correct branch with a working and demonstrable version of the algorithm: (+2)
b) Incorporating feedback into the pull request: (+2)
c) Description of and comments within the pull request: (+1)
Feedback:
Good attempt, could have tried using better data augmentations and a variational model for better generalization
Any Changes Needed: No

Observational Feedback
Pull Request:
Correctly created the Pull request from Topic Recognition Branch .
The pull request includes a clear description about the file structure .
File Organizing: Well-organized files.
Commit Log:
Commit messages are  progressive for the Recognition Problem solved using 4 files .
Commits  demonstrate  logical development flow.
Commits are regularly made, showing incremental development rather than bulk updates.
Documentation:
The README file should contain Conclusion and Future Improvements .
Code comments and docstrings are included.
Proper GitHub markdown formatting is used, with organized headings, lists, and code blocks.

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
OK solution to problem. -2
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Hard. ViT (Hard Difficulty)
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Good.
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). On time submission.
No Feedback required.
Request Description is good.
TOTAL-3

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes


Tools: enable message parser and writer for different channels, including camera topics; fix lots of bugs

Looks good to me, many thanks!


Implementing multiplan subscriptions

As explained in issue #397 from Laravel Cashier Stripe, multiplan subscription would be a very nice feature. Could you implement this for us or is this already available? Would you accept PR's on this?

This is useful because this way the customer will see only one debit on their bank account for every billing cycle instead of seeing one for every subscribed plan. Eg. if your customer is subscribed to a main service plus 4 features, they will get 5 debits every month. This is bad for service providers because (a) it is ugly (b) it is more expensive due to the fix fees.

Hi @lexdewilligen,
Yeah this was one of the architecture concerns when I started this project.
You can implement this by scheduling Cashier::run() to run monthly (or tinker with the underlying method to match it better to your use case).
All order items that are due at that moment will be processed into one single order (and invoice). Multiple currencies will be split into multiple orders.


how to change key bindings in elfeed-entry

I want to change keybindgins in elfeed-entry.
But I can not find any map look-like "elfeed-entry-mode-map" . And I have changed "elfeed-show-mode-map",  it seems not working.
By the way, in elfeed-entry, RET bind to newline normally. But when I move my cursor on a url, it bind to shr-browse-url. I really don't know why. I grep all the elfeed code. only find shr-brose-url in elfeed-show-mode-map:
(defvar elfeed-show-mode-map
  (let ((map (make-sparse-keymap)))
    (prog1 map
      (suppress-keymap map)
      (define-key map "d" 'elfeed-show-save-enclosure)
      (define-key map "q" 'elfeed-kill-buffer)
      (define-key map "g" 'elfeed-show-refresh)
      (define-key map "n" 'elfeed-show-next)
      (define-key map "p" 'elfeed-show-prev)
      (define-key map "s" 'elfeed-show-new-live-search)
      (define-key map "b" 'elfeed-show-visit)
      (define-key map "y" 'elfeed-show-yank)
      (define-key map "u" (elfeed-expose #'elfeed-show-tag 'unread))
      (define-key map "+" 'elfeed-show-tag)
      (define-key map "-" 'elfeed-show-untag)
      (define-key map (kbd "SPC") 'scroll-up-command)
      (define-key map (kbd "DEL") 'scroll-down-command)
      (define-key map "\t" 'shr-next-link)
      (define-key map [tab] 'shr-next-link)
      (define-key map "\e\t" 'shr-previous-link)
      (define-key map [backtab] 'shr-previous-link)
      (define-key map [mouse-2] 'shr-browse-url)
      (define-key map "A" 'elfeed-show-add-enclosure-to-playlist)
      (define-key map "P" 'elfeed-show-play-enclosure)))
  "Keymap for `elfeed-show-mode'.")

As it shown, it binds to [mouse-2] other than RET.
I run describe-function when my cursor is under a url in elfeed-entry buffer:
shr-browse-url is an interactive compiled Lisp function in `shr.el'.

It is bound to RET, v, <mouse-2>.

(shr-browse-url &optional EXTERNAL MOUSE-EVENT)

Browse the URL under point.
If EXTERNAL, browse the URL using `shr-external-browser'.

[back]

Where do the RET and v bind? I can't find in the code.

Entries are displayed with elfeed-show-mode, so elfeed-show-mode-map is
definitely what you're looking for. If your changes to this map don't
seem to be working it could be that you're setting it incorrectly.
Here's an example that adds vi-style scrolling:
(define-key elfeed-show-mode-map "k" (elfeed-expose #'scroll-down 1))
(define-key elfeed-show-mode-map "j" (elfeed-expose #'scroll-up 1))

I think the RET binding that you're looking for is in shr-map. In the
Emacs source it's bound using "\r" rather than RET. The strangeness of
the links has to do with them being "buttons" or something like that,
with special behavior attached by shr.

Yes, I change the `shr-map'. It works now. Thank you very much.


Navigation drawer not working properly in tablets.

I have tested it in a real device Nokia N1 and also in an emulator Nexus 9. It seems that when the drawer is open its hard to close it, and also the menus are not clickable. Please fix this issue as I really like this drawer it works perfectly in phones I have tested it in Nexus 6p (real device) and also Nexus 5 (real device) and a bunch of emulators. Thanks.

I don't have time to work on this library right now. I'll work on it in the near future. Maybe you can look at the problem yourself and create a pull request.


[feat]: Sequential focus functionality for contact component

@Anandsg
I have worked on improving the user experience in the contact component.
For this PR, Our contact component sets the focus for next,next input on pressing the enter key.
Please refer this video Contact Component Sequential Focus
(In the video i will press enter as soon as i finished entering the inputs)
Can you assign this to me ?
Will create a PR now, as it is mergeable.

create a PR will review the changes


doesn't even work

if( $('.countdownTimer').length ) {
$('.countdownTimer').simplyCountdown({
year    : 2018,
month   : 9,
day     : 21
});
}

I close this issue because of inactive issue.


Loading a font with it's extension in upper case throw an error -> MissingAssetLoader

Bevy version
0.4.0
Operating system & version
Ubuntu 20.04
What you did
pub fn display_hello_world(
    commands: &mut Commands,
    asset_server: Res<AssetServer>
) {
    commands.spawn(TextBundle{
        text: Text{
            value: format!("Hello World!"),
            font: asset_server.load("fonts/256BYTES.TTF"),
            ..Default::default()
        },
        ..Default::default()
    });
}

What you expected to happen
The text to be loaded and the font to be displayed.
What actually happened
Bevy throws a panic within an IO Task Pool:
thread 'IO Task Pool (1)' panicked at 'called `Result::unwrap()` on an `Err` value: MissingAssetLoader(Some("TTF"))', /home/archina/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_asset-0.4.0/src/asset_server.rs:298:60

Additional information
Renaming the font to <font_name>.ttf fixes the error and load the font correctly.

In font_loader.rs try to change this line:
&["ttf", "otf"]
with this one:
&["ttf", "TTF", "otf", "OTF"]
and see if it still panics

I think a better way would be to use use to_lower_case before comparing as TTf and tTF are still not covered otherwise.

Fixed by #1427.


Example Project does not compile / Cannot find PB symbols from ProtocolBuffers when compiling framework

Hi
I'm using Xcode 6.3.2
When cloning repository and trying to compile the Example project, I get this reference error in descriptor.pb.h

I've originally tried to include ProtocolBuffers in my own dynamic framework just by adding the ProtocolBuffers project file to my dynamic framework project and then linking the libProtocolBuffers in the link build phase.
Every time during compilation it references some PB symbols it cannot find them.
Using your ProtocolBuffers for swift works in terms of referencing but then the generated classes are unusable in objective-C because not visible to objective-C (see my other issue in protobuf-swift https://github.com/alexeyxo/protobuf-swift/issues/65)

Look this issue:
https://github.com/alexeyxo/protobuf-objc/issues/33#


[BUG] hub.copy does not support pathlib.Path arguments

🐛🐛 Bug Report
hub.copy does not seem to play well with pathlib.Path. Since pathlib.Path seems to be the up and coming new standard for Python3 paths, I think it would greatly reduce friction and increase compatibility if it was supported.
⚗ Current Behavior
Currently, the hub.copy method's signature looks like:
@staticmethod
    def copy(
        src: Union[str, Dataset],
        dest: str,
        overwrite: bool = False,
        src_creds=None,
        src_token=None,
        dest_creds=None,
        dest_token=None,
        num_workers: int = 0,
        scheduler="threaded",
        progressbar=True,
    ):

For src and dest we should include pathlib.Path as a potential type. One can easily convert a pathlib.Path to a string path if necessary by using
path_to_string = lambda x: os.fspath(x.resolve())

⚙ Environment

Python version(s):
python                    3.8.12          ha38a3c6_3_cpython    conda-forg
OS: [e.g. Ubuntu 20.04]
IDE: [PyCharm]
Packages: [ Pytorch-latest]

Will be adding support for for Path argument soon.

@farizrahman4u, with respect to this issue, will it be resolved with the workaround @AntreasAntoniou suggested, or does it have some more depth to it? I'd like to work on this if I can!

@dhiganthrao we have a PR up: https://github.com/activeloopai/Hub/pull/1651

Hi @AntreasAntoniou! We have added support for pathlib.path to hub.copy and many other methods. Thank you for your patience!


Transparency turns off screen space reflections

*Godot commit d3ea922
If I have a material that is set to be transparent, ss reflections aren't drawn on it.
Example Project

The materials used on both sides of the plane are identical except that one side has the Transparent Flag set.

This is by design, Godot needs a depth reference to make a screen space reflection. Transparent materials generally don't write depth so they won't be visible.

Keep in mind this is the same for most screen space effects, such as SSAO or Subsurface Scattering,
and it's a limitation in most (if not all) game engines.


CFE: incorrect return type inference for non-local variables initialized with function literals

All of the function literals (and the local function) in the example below should have inferred type Never Function() per the spec here.
The CFE correctly infers this for a and b (the local variables) but incorrectly infers Null Function() for the top level variable, the static class variable, and the instance variable.
var c = () {
  throw "Baz";
};

class C {
  static var d = () {
    throw "Baz";
  };
  var e = () {
    throw "Baz";
  };
}
void main() {
  var a = () {
    throw "Hello";
  };
  b() {
    throw "World";
  }

  int x;
  x = a; // Correct
  x = b; // Correct
  x = c; // Incorrect
  x = C.d; // Incorrect
  x = C().e; // Incorrect
}

The analyzer infers this correctly, and the fix should be almost entirely non-breaking.

cc/ @stefantsov

@stefantsov Shall we go ahead and slip this to the next release?

I think we can make this slip.

cc @stereotype441

@johnniwinther @stefantsov What's the status of this?

This is rooted in the language issue https://github.com/dart-lang/language/issues/1650
I'll remove the milestone since we need to resolve the language issue before fixing this.


chore(deps): update dependency golang to v1.23.1

This PR contains the following updates:

Package
Update
Change

golang
patch
1.23.0 -> 1.23.1

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

golang/go (golang)
v1.23.1
Compare Source

Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


File Not Found

super().__init__(open(name, mode))
                 ^^^^^^^^^^^^^^^^

FileNotFoundError: [Errno 2] No such file or directory: 'TrainData.pth'

super().__init__(open(name, mode))
                 ^^^^^^^^^^^^^^^^

FileNotFoundError: [Errno 2] No such file or directory: 'TrainData.pth'

When you run Train.py file, then it create TrainData.pth and you can not view or open this file.
when you open Train.py file you can see that i clearly mention that when we run this Train.py it will create a TrainData.pth file


Use non-zero costmodels in Imp tests

Description

Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
New section is never added with the code changes. (See RELEASING.md)
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated.
If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[ ] Self-reviewed the diff

Just an initial attempt, investigating now the situation of costmodels in plutus

Merging because I think it does bring value to use  realistic costmodels, but agree it should be better!  Added an issue for this: https://github.com/IntersectMBO/cardano-ledger/issues/4784


Response interceptor is not called on error

Hi!
I try to catch error response but its not working. It was a bug earlier #21, maybe its a bug again?
I have<EMAIL_ADDRESS>version.
The console log called only on success response but its not when the status code is 500 for instance.
httpInterceptor.response().addInterceptor(res => {
      return res.do(r => {
        console.log("Status: ", r.status);
      });
    });

In your code snippet I cannot see catch operator, maybe that is why you are missing errors?

I have the same error:
httpInterceptor.response().addInterceptor((res, method) => {
      try {
        return res.do(r => {
          try {
            console.log(method, r)
          }
          catch(ex){
            console.log("catcth 2", ex);
          }

        });
      }
      catch(ex) {
        console.log("error catch 1", ex);
      }
    });

only on success response is working

What I meant by catch operator is not language try/catch construct but RxJs Observable .catch operator (like .do)
httpInterceptor.response().addInterceptor(res => {
      return res
        .do(r => doSideEffectsOnSuccess(r))
        .catch(e => handleErrorAndReturnNewObservable(e));
    });

For further details about catch operator usage please refer to RxJs catch documentation.

You can also use the second parameter of do():
httpInterceptor.response().addInterceptor(res => {
    return res.do(
      r => {
        console.log("Status: ", r.status);
      },
      err => {
        console.log("Error");
      }
    );
});

The first parameter can be replaced with null:
httpInterceptor.response().addInterceptor(res => {
    return res.do(
      null,
      err => {
        console.log("Error");
      }
    );
});

@gund @dsge Thanks!

Awesome! Will close this issue then =)


Typo fix: 1 repeated word, 1 accidental capital

Incredibly low-priority typo fixes.
(´・ω・｀)

Thanks so much for your contribution @zkpub


Build image failing on acorn platform when if statement is used inside the Acornfile

Hi, I'm working on Developing Acornfile for Jellyfin. As it is a media server so I have given  an options to pass the s3 bucket details to the users. To take the user input I'm using the args field and as there is not way we can make the specific field required . So there can be the scenrios if users don't pass the s3 credentails along with bucket name the jellyfin container will start failing, to prevent this I have added a if check for both the sidecar image and other container image that we are using.  Now if user forget to pass the s3 bucket details the jellyfin container will still be running as it will skip both the sidecar and other container.
While testing it using acorn cli it works as expected for both the scenarios when the s3 details are given and not given. Below is how i'm running while passing all the s3 details
acorn run -n jellyfin . --access_key <>  --bucket_name <> --secret_key <>

and when I just run acorn run -n jellyfin . jellyfin server is still running just other containers are skipped.
After testing it using Acorn CLI i created the image for the Acornfile and was trying to run it on the platform using the image and after passing all the s3 details when I click on Deploy. Below is the error I'm getting.

In the error it says image/build field is required for bucketsync container but when I check my Acornfile on the platform I was able to see those field.
I doubt there can be some bug on the platform causing this issue.
TL;DR : When using if statement in the Acornfile and running the jellyfin image on the platform it fails with the above error (see the image) , but when the same Acornfile is run using acorn cli it works as expected in both the scenarios when bucket details is given and not given.

This is a known behavior, and isn't documented at the moment, but there is a solution. The tl;dr is you need to use the top level images key to define images that will be hidden behind conditionals during build. Because they aren't found during build time, they aren't available in the Acorn image which is why you are seeing this error.
So, images look like:
// Just an image like you would use in containers.foo.image
images: sidecar: image: "ghcr.io/this/image:v0.0.0"
// Same fields you would use for a container build in the container block.
images: sidecarToBeBuilt: containerBuild: { context: "." }

// use it like so
if foo != "" {
  containers: sidecar: {
    image: images.sidecar.image
  }
}

you can also do an acornBuild with the same fields you would use in the acorns block.
I'll be adding this to the docs.

Documented in acorn-io/docs#11


GNSS Ublox parser - Udp stream/ failed to create parser

Linux Ubuntu 18.04
**Apollo installed from source
**Apollo version master
==>
I want to send ubx file data in udp protocol as input to the localization module. For That I followed the indicated steps in this link https://github.com/ApolloAuto/apollo/blob/master/docs/howto/how_to_add_a_gps_receiver.md
These instructions are not complete and i need to implement the ubx_parser class as done for novatel. Any help or parser that is provided would be greatly appreciated.
Also I need to know how could i send the data (ubx file ) by udp protocol unstead of having the data from the connecting device?

Thank you.

Please answer.
Thank you

???

What is your real problem then?
Through your description, your needs are very unique, you may need to do some experiments, it is best to ask specific questions.
For example, if you need to send a file, you can check the UDP socket related information, and if you encounter an error, ask again. At least I know that no one will complete the code for you directly!
Hope this helps you！

@daohu527 Thank you for your answer,  My question precisely is How can i send data in localization module using Udp protocole, Can you share with me the related information of UDP socket?

There are many examples of socket communication. for examle link

Thank you for your answer, I did the necessary changes on gnss in apollo but still fail while creating the stream (can't receive the data sent in udp protocol) and i have this error in launch :

The error message reminds you that there are duplicate nodes.

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Switch to Bunny Fonts Provider by default

I found no place where the font will be changed depending on the config, therefor I simply made the changes necessary to have Bunny Font the Default one.

Could you revert de docs changes? These are still the v2 docs and will be updated before v3 launches anyway. Rest looks good to me.
@danharrin, Laravel also uses Bunny Fonts instead of Google Fonts as the default these days, so makes sense.

@Jubeki, mark as ready for review when you've reverted the docs.

I have reverted the docs.

Perfect, thanks. Waiting for @danharrin to merge.


samples: disable shell for i.MX8QM and i.MX8QXP

Disable shell for i.MX8QM and i.MX8QXP since is not supported now.

Are you sure that the shell is not working?
I would expect that it is generic as the console is over rpmsg  (CONFIG_SHELL_BACKEND_RPMSG=y).
with that the console should be accessible from your board Linux console
To check it:
In your board Linux console check that you have a "/dev/ttyRPMSG1"
then
:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

Are you sure that the shell is not working? I would expect that it is generic as the console is over rpmsg (CONFIG_SHELL_BACKEND_RPMSG=y). with that the console should be accessible from your board Linux console
To check it: In your board Linux console check that you have a "/dev/ttyRPMSG1" then
:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

With the shell config the communication between cores is broken (the first message sent from Linux get's stuck) because it messes up with the interrupts - for these 2 targets the UART has interrupts enabled.
The SHELL was enabled for all targets, in prj.conf and I don't think this should be for all targets, I'm pretty sure was not tested on all supported boards. IMO should be set per board.

on between cores is broken (the first message sen

Are you sure that the shell is not working? I would expect that it is generic as the console is over rpmsg (CONFIG_SHELL_BACKEND_RPMSG=y). with that the console should be accessible from your board Linux console
To check it: In your board Linux console check that you have a "/dev/ttyRPMSG1" then
:~# microcom /dev/ttyRPMSG1

tty:~$ kernel version
Zephyr version 3.7.0

With the shell config the communication between cores is broken (the first message sent from Linux get's stuck) because it messes up with the interrupts - for these 2 targets the UART has interrupts enabled.
The SHELL was enabled for all targets, in prj.conf and I don't think this should be for all targets, I'm pretty sure was not tested on all supported boards. IMO should be set per board.
LE: I don't have time to debug this issue now, that's why I prefer to disable the SHELL for i.MX8QM and i.MX8QXP, for now. I'll get back to it, when time allows.

Thanks for the clarification.
I'm not familiar with Zephyr process in such case, I let @doki-nordic and/or @carlocaione give advice on this (issue creation, commit message explaining more in detail limitation...)

@doki-nordic @carlocaione @arnopo can you, please, take a look?
Thanks!


Add "fast" export mode to local storage provider bulk-export to match S3 fast export mode

If you have a large data set on your fhir server and do a bulk export, in local mode (running containerized on a linux box - in my case Ubuntu 22.04LTS) you will barely notice a bump in system load and the export will take a staggeringly long time (for my current export around 27 hours to complete). On the system resource viewer (screenshot attached mid export) we peak at 15% load on 1 core, and only 5gb of RAM, which on a high core-count water cooled server should be able to generate extraordinary high export rates.
For baseline system specs: Watercooled 12th gen i9 (intel 12900K), 64GB DDR4 3200, RTX 3090
In discussion with @lmsurpre this is the "search" based export. He phrased this request as request to support filesystem-based storageProviders from our fast export
here is the command as executed that produced that system resource chart attached (note this will export around 2gb of ndjson when complete)
curl -k -u "fhiruser:change-password" -H "Content-Type: application/fhir+json" -X GET 'https://localhost:9443/fhir-server/api/v4/$export'

Our legacy export impl defines "Providers" for Azure Blob, local filesystem, AWS S3, etc.
However, the "fast" impl was coded directly to the IBM Cloud Object Storage API.
It shouldn't be too difficult to support filesystem-based export from the fast impl... mostly a matter of removing stuff related to multipart uploading to COS.
For example, replacing the existing ResourcePayloadReader.uploadWhenReady() with something that just appends the resource content to the existing (buffered) file output stream.