Workspace in the workspace list is misaligned when deleted offline

Details

This PR fixes a regression from https://github.com/Expensify/App/pull/31728. There was a problem that styles are not combined and used separately. Right now we use StyleUtils.combineStyles for combining them.
Fixed Issues

$ https://github.com/Expensify/App/issues/32182
PROPOSAL: N/A
Tests

Go offline.
Go to Settings > Workspaces > Create a new workspace.
Click on the three-dot menu > Click on Delete workspace > Delete.
Go back to Workspaces.
Verify that the deleted workspace in the workspace list is not misaligned.

[x] Verify that no errors appear in the JS console

Offline tests

Same as "Tests".
QA Steps

Same as "Tests".

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/57314631/5bd62baa-5e4c-4d24-a1eb-3af5ed576520

Android: mWeb Chrome

https://github.com/Expensify/App/assets/57314631/4881b69f-a2f6-412a-bdd5-37dab8119716

iOS: Native

https://github.com/Expensify/App/assets/57314631/fa98bb2d-b32e-4345-9034-ef3937d9d640

iOS: mWeb Safari

https://github.com/Expensify/App/assets/57314631/0701ceba-5975-4045-8956-b4ed8e385ae2

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/57314631/e6b1d736-de49-4484-b1f5-f42870e34118

MacOS: Desktop

https://github.com/Expensify/App/assets/57314631/8f3ce7a3-9286-4c14-85df-c1af9fa83a7d

I still need to test native Android, but it is not a big deal and blocker fore review, I think.

@grgia if you need C+ to be tested on all platforms, I can help

Tested Android, works properly.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/4c15ec7c-e2aa-491c-8cbd-642d0d806215

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/bd324c65-4d10-4f61-bdb6-b15423a54c26

iOS: Native
https://github.com/Expensify/App/assets/108292595/2862ec64-be7c-498c-83a7-739df18cfe36

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/5241edb6-bdd3-4563-b75b-616b67b19c85

MacOS: Chrome / Safari

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/275ea694-3075-4261-8786-727f21611ab7

Maybe not caused by PR but hardly see android default workspace icon title

Confirmed happening on main so out of scope

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.4.5-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.


query and identify options for geojson layer in Bootleaf

Hello,
I like to get solution for activating the options "query widget and identify" for geojson layers.
I also want to know how to activate highlight feature on mousehover..
Thanks,

hi there, I don't believe that GeoJSON layers support query or identify, however I could be wrong.
The bootleaf implementation simply uses standard GeoJSON functionality as described at https://leafletjs.com/reference-1.6.0.html#geojson so I could start searching there.
Good luck

Hello,
I like to get solution for activating the options "query widget and identify" for geojson layers.
I also want to know how to activate highlight feature on mousehover..
Thanks,

Hello there
If there has been a development regarding the geojson layer, can you share with me which method did you apply?
Thanks in advance forever.


Suggestion - Add commands via discord

Was thinking it would be useful to add commands via discord to get the bot to work. This is because I can just leave on the python main file or executable to run on a server then control using discord commands.
So like !join (Voice channel name) to join a channel and !leave to leave. !mute and !unmute as well

yeah that's a good idea, I didn't think about the server use case

yeah that's a good idea, I didn't think about the server use case

Is there any update on this?


re added javascript questions

i re added the javascript questions

Huh, maybe they got deleted when I was resolving a conflict in the quizQuestions.js file. Sorry about that.

yeah must be something like that aint it, i was wondering what was going on lol


No file(s) found for glob /var/log/auth.log

Hi
Thanks for your sharing. I just successfully install the container but when I want to start it, I got the error No file(s) found for glob /var/log/auth.log
I am new to container and Fail2Ban. How can I solve this? Thanks.

I am getting the same error.
OS: CentOS 7.6.1810
Kernel: 3.10.0-957.5.1.el7.x86_64

@robert1112 @ninjalf2 I took a quick look on your issue and I found this: https://unix.stackexchange.com/questions/268357/how-to-configure-fail2ban-with-systemd-journal
According to this post, it seems that you don't have syslog or rsyslog on your system which causes that you don't have the auth.log file. This log file is used by my default config for fail2ban to protect your ssh connection.
You can see my jail.local config:
[ssh]
enabled  = true
port = ssh
filter = sshd
# Change this path if needed or remove all config to disable the ssh protection
logpath = /var/log/auth.log
maxretry = 5

Don't hesitate to replace my default jail.local config with yours by adding the argument

-v /path/to/jail.local:/etc/fail2ban/jail.local

If you think that the default config could be improved, don't hesitate to propose a better config 😊

Hi @SuperITMan
First Thank you for your support. I will take a look and take time understanding it. (I am new to Docker and Fail2Ban.)
Is it possible for you to share what pro and con of having Fail2Ban installed as a dock conatiner versus installed on the host? Thank you so much.


Automatic Video Orientation fix

Handled device camera video orientation fix automatically
Added Swift 5 support
Added Compression Progress Handler
Added Result type completion handler

Hi @akaashdev ,
This is really impressing! ❤❤❤
I believe this PR breaks Swift 4 support due to Apple's latest SDK naming scheme changes, correct me if I'm mistaken. Since this repo is originally an artifact of a blog post, changing the reference code would be unhelpful to the community.
I'm thinking about merging this to a branch called swift5 and put a link of it into the current README with a huge disclaimer for people who are interested in. In order for me to do that, can you revert the changes where you remove the word "tutorial" from README and code, then create a seperate PR?
I'll merge this one into swift5-betternames and the one with the word "tutorial" kept into swift5.
I hope it's not too much to ask.
Thanks for the effort, it's really appreciated!

Hi @diegoperini ,
I have made the required changes.
Added a latest commit with title changes in README.md and code.
Hope these are the required changes. Do let me know if these are not.
And I couldn't find a new branch to create merge request. Could please resolve and let me know,
so that I'll create a new PR to merge with the new branch.
Thanks!

Thanks @akaashdev
I've created the branches. Feel free to resend the PRs whenever you are ready. You may keep the attribution to your name as long the license for the code stays in public domain.


Documentation and man page reorganization

This commit reorganizes the documentation files to get around an earlier issue with the asciidoc maven plugin not generating man pages and contains the configuration to replace the current https://ngageoint.github.io/geowave/ site. The two new content pages, PDAL and GSOC 2015 have also been migrated into the new format.
EPUB3 support has been added with a new (alpha) library. The epub output looks pretty bad at the moment but we can follow along and at the point it's decent we could start distributing in that format. Man pages are still generated but only by the backend Jenkins worker that has the native asciidoc package installed.
For ease of inspection I've pushed the site generated from this commit to my fork and can be viewed at http://spohnan.github.io/geowave/
To generate the documentation locally check out this branch and run the command mvn -P docs -pl docs install and look under the target/site directory. I ended up using a black on white stylesheet as it seemed more readable but docs/pom.xml line 196 can be changed to <stylesheet>slate.css</stylesheet> or a new stylesheet could be created if the dark theme is desired.

Coverage remained the same at 34.86% when pulling 43f445ff53b70b3739c361b8e003a046d73e8e0d on GEOWAVE-147-Docs-to-AsciiDoc into 7bdc096624201aacf24b933b11ef6fc38d1631ec on master.

Coverage remained the same at 34.86% when pulling 9e572fa4a940285cbd1c6ff5c6b0ad73e7fc8146 on GEOWAVE-147-Docs-to-AsciiDoc into fb59922b32ef45012f3744cb9720d25e9a379659 on master.


stake-pool: Assess fee as a percentage of rewards

Fixes #1521
Instead of minting pool tokens on deposit to the manager, we mint them every epoch as a percentage of rewards perceived.  If there were no rewards or the pool lost value due to slashing, no fee is minted.
From the associated issue:

Problem
Taking all of the fee upfront on deposit is a simple model, but unnecessarily punishes users who deposit for a short time. Also, it's totally different from the main staking program's reward model if assessing the commission every epoch.
Solution
Adopt a model similar to regular staking, and have the stake pool fee paid out as pool tokens minted every epoch during "update pool balance". Also, update the documentation to reflect this change.

You're welcome 😜


[FR]convert markdown to nb

that will be great that we can convert markdown to nb, we can convert codeblock to code and others to markdown

Thank you for filing this feature request, given this hasn't received any upvotes I'm closing this issue.


envFile config option

Many popular debuggers (node, python, etc.) for VSCode support the envFile option. Also, it's mentioned in VSCode's docs.
Personally, I'd use this option to be able to debug my rust project which needs some API keys. I might use some rust libraries that load env variables from a file, but I think that the program itself should not be responsible for this.
Also, I'd be happy to implement it myself and open a PR. As far as I understand, this might be implemented by adding a dotenv dependency to package.json and using it to parse the file from the new envFile option. Then the env variables might be spread in the env dict:
https://github.com/vadimcn/vscode-lldb/blob/master/extension/main.ts#L178
Let me know if adding a new dependency to this project is appropriate. Also, are there any other places that depend on the env option?
Thanks!

Yeah a PR would be nice.  Please see the previous issue on this: #506.

Implemented in v1.9.1

Implemented in v1.9.1
So cool! Thanks! i have to use getenv(..) in C bootstra GUI mode, because .env did not worked at all, maybe thing will change soon!


Add ability to monitor progress of SciF workflows

Task to do
Add the ability to monitor the process of the SciF workflows
Reason
From PR: https://github.com/AgPipeline/drone-makeflow/pull/4#discussion_r470144596
Wish list: A command to monitor the progress
Result
Ability to monitor progress of Workflow, including useful status updates and error messages.

@julianpistorius Do you have a suggestion for how you would like this done (technology-wise)?

I'd like to use the built-in Makeflow monitoring:
https://cctools.readthedocs.io/en/latest/makeflow/#monitoring

Following Julians suggestion, there is a need to document these existing monitoring tools for our environment (namely tying in the tools with the makeflow artifacts documentation).

PR: https://github.com/AgPipeline/drone-makeflow/pull/24


Overlapping docker options

ref https://github.com/progrium/dokku/pull/1254#issuecomment-118204117

can bake another PR. You said those options work their own way but it seems to me that DOKKU_DOCKER_BUILD_OPTS and DOCKER_OPTIONS_BUILD are the same, all we need is the docker plugin ones, there nothing you can't so passing params to docker, included disabling cache and exposing the port. I'll open a new ticket to iterate on this a bit more?

I confirmed with @josegonzalez that all docker options that are not DOCKER_OPTIONS_* are overlapping and we may want to get rid of them.

Well not all, but at least the one he mentioned (DOKKU_DOCKER_BUILD_OPTS).

We'll probably want to do this for the 0.4.0 release.

It may be a choice to not remove them all, but they are all overlapping each other.

DOCKERFILE_PORT=8080 DOCKER_OPTIONS_DEPLOY="-p 8080"
DOCKER_OPTIONS_DEPLOY
DOCKER_OPTIONS_RUN
DOCKER_OPTIONS_BUILD
DOKKU_DOCKER_BUILD_OPTS === DOCKER_OPTIONS_BUILD
DOKKU_DOCKERFILE_CACHE_BUILD=0 DOCKER_OPTIONS_BUILD="--no-cache=true"
DOKKU_DOCKERFILE_START_CMD <-- should be renamed into DOCKER_OPTIONS_DEPLOY_CMD and moved into docker plugin.

@kilianc Want to make a pr with all these changes? With the exception of DOKKU_DOCKERFILE_START_CMD - it's not been released in a stable version yet - we'll need to support both the old and new methods.

I would love to, not sure what you mean with

With the exception of DOKKU_DOCKERFILE_START_CMD - it's not been released in a stable version yet - we'll need to support both the old and new methods.

That just got merged right ?

Oh and when making the PR, please add a *DEPRECATED* comment. Would be nice if it echo'd a deprecation notice, similar to how deploy:all works. Maybe to stderr?

Yeah, that just got merged, but since I haven't made a release, if anyone depends on it, they can go kick rocks.

Oh I just misread what you wrote, deprecation warnings for all but DOKKU_DOCKERFILE_START_CMD gotcha, this will take me 2/3 days I am not a bash guy :)

Neither am I!

what are we doing here O_O

I'm :+1: on utilizing the docker-options plugin for consistency. IIRC, that plugin came in after the fact or at I'm choosing to remember it that way :smile:

Note, we should probably take care of this for 0.4.0.

I'm not really sure what specifically we're trying to do here. To be clear the docker-options plugin is a method to persist desired docker args between build/deploy/run executions.
Let me try to enumerate my questions/concerns.

DOKKU_DOCKERFILE_PORT: not sure how or why we'd modify this functionality as the way it currently stands, it simplifies the logic of how to start the deployed container
DOKKU_DOCKERFILE_CACHE_BUILD is a transient variable in that it can change between deployments. so we shouldn't persist it in the docker-options plugin
renaming DOKKU_DOCKERFILE_START_CMD to DOCKER_OPTIONS_DEPLOY_CMD seems ambiguous as "DEPLOY" is a dokku phase.

Looking through the code I think this list is exhaustive with regards to us diverging from injecting docker args with the docker-options plugin. I don't think it makes sense to modify these cases but I'm definitely open to more clarifying discussions around what we're trying to accomplish.

@michaelshobbs if you don't think there is anything to do here, I'm okay with closing :)

@kilianc do you have any further thoughts here?

@michaelshobbs the point that I am tried to make at the time is that there are misnamed and overlapping options and you can do the same thing from both the plugin and core which is confusing.
For consistency everything should be handled by core or plugin and decide appropriate names for each option and update the docs. If I recall correctly even @josegonzalez got confused and confirmed the overlapping. The discussion is somewhere in the tickets.
I will have some time tomorrow to reorganize thoughts on this but most of my reasoning is already spilled out!

renaming DOKKU_DOCKERFILE_START_CMD to DOCKER_OPTIONS_DEPLOY_CMD seems ambiguous as "DEPLOY" is a dokku phase.

That's why it's called DOCKER and not DOKKU that's what docker calls it

I don't understand what you mean by that's what docker calls it. Can you clarify?

Sorry I think I messed up! The ref is here: https://docs.docker.com/reference/run/ the DEPLOY is a reference to the dokku DEPLOY phase indeed the param is CMD as explained in the docker docs. It's the command executed in the deploy phase of dokku!

@kilianc Can you make a pr with the changes you have in mind? Much easier to sort out what's overlapping when we can see some changes :)

I would be happy to, but work is getting in the way lately. No time for the next 4w. Is there a deadline/expected shipping date for 0.4??

4 days ago ;)

Going to close this. Any work can happen in a pr if necessary.


containerd http apis doesnt work

Description
Currently, I am hitting docker.sock to get the  inventory of the containers and images on k8s cluster where docker is container run time.  I am extending this support for the containerd runtime engine for the K8s.  I am trying to hit the containerd.sock to get this info but none of the APIs work.
Steps to reproduce the issue:

curl -v --unix-socket /run/containerd/containerd.sock http://localhost/info

root@k8s-agentpool1-10471297-vmss000000:~# curl -v --unix-socket /run/containerd/containerd.sock http://localhost/info

Trying /run/containerd/containerd.sock...
Connected to localhost (/run/containerd/containerd.sock) port 80 (#0)

GET /info HTTP/1.1
Host: localhost
User-Agent: curl/7.47.0
Accept: /

Recv failure: Connection reset by peer
Closing connection 0
curl: (56) Recv failure: Connection reset by peer

root@k8s-agentpool1-10471297-vmss000000:~# curl -v --unix-socket /run/containerd/containerd.sock http://localhost/containers

Trying /run/containerd/containerd.sock...
Connected to localhost (/run/containerd/containerd.sock) port 80 (#0)

GET /containers HTTP/1.1
Host: localhost
User-Agent: curl/7.47.0
Accept: /

Recv failure: Connection reset by peer
Closing connection 0
curl: (56) Recv failure: Connection reset by peer

Describe the results you received:

Recv failure: Connection reset by peer errors on hitting containerd.sock

Describe the results you expected:
Expecting to get the inventory of the containers and images, and container images from containerd similar to docker via HTTP APIs
Output of containerd --version:
     root@k8s-agentpool1-10471297-vmss000000:~# containerd --version
containerd github.com/containerd/containerd v1.1.5 5960cade475fb25a181705d7eccbacc0313bcd7b
Any other relevant information:

containerd uses a grpc API, which it's different than docker's remote API

containerd uses a grpc API, which it's different than docker's remote API

@thaJeztah, thanks for the quick response.  My scenario is to get inventory of the container and images on the node from the container. Currently,  I hit the mounted docker.sock from container.

Here are few follow up questions ...

Does grpc API way, can I talk to container runtime  (containerd, CRIO etc..) from container?

is same grpc API supported for docker as well, is just CRI compatiable runtimes (containerd, CRIO etc)?

Docker provides the http JSON API, and in itself connects to the containerd gRPC API
Connecting from within a container should be possible if there's a containerd client inside the container. The containerd API is a more "low level" API than the docker API, and information may be presented different (or not available, as the docker daemon adds it's own information)

Note that kubelet has an API for getting the pods assigned to the node.
I'm not sure if this is sufficient for your needs.
Should be able to curl <node IP>:10255/pods

Hi, @cpuguy83 , thanks for the response. This is approach, "http(s)://:10255(10250)/pods"  I am considering but this lacks container specific environment variables though it returns the Kubernetes environment variable. I have explored all the options to get the container environment variables in which we we are getting via Docker REST APIs. This is breaking change with regards our monitoring agent behavior so wondering are there any ways to get the container environment variables. Do you guys any pointers, does the gRPC API gives the container specific environment variables?

Absolutely you can get anything you need from the GRPC API.
Really there are 2 API's, the main containerd API, and the CRI API, both served over GRPC.

Absolutely you can get anything you need from the GRPC API.
Really there are 2 API's, the main containerd API, and the CRI API, both served over GRPC.

Hi, @cpuguy83 , Thanks for the response. My scenario is to make CRI API calls from monitoring agent container.  I am trying to figure out,  do I need something mount to the container (like socket we do for docker) to hit CRI APIs on the kubelet?    Appreciate throwing some pointers, how doe the CRI APIs are accessible from  container?

I believe CRI's API is served over the normal containerd socket.

Hi Ganga,
Is this issue resolved? Even I am facing the similar issue.
I was unable to hit the unix.socket url after kubernetes upgrade from 1.17 to 1.19.7 version.
Please let me know if this issue is resolved.
once check this url https://github.com/kubernetes/kubernetes/issues/99722


Use of custom buttons

Working on a custom subclass of BLTNPageItem that includes multiple buttons in the 'main button' style, and while I've got it working, I wanted to verify that the way I'm doing it is correct.
In one of the makeViewsUnder... methods, I'm creating a button, i.e. let newActionButton = interfaceBuilder.makeActionButton...
I'm then attaching the handler via newActionButton.button.addTarget.
Is this the correct way to respond to that button being tapped, or is there something else I should be doing?
Thanks!

Hi! It seems to be correct from what you're telling me 😄 Feel free to reopen an issue if you encounter any problem with that setup.

pretty old, but ill try anyway :)
Hi @grey280, would your solution for costume buttons lets you also costume the design of the buttons (e.g adjusting rounded corners, shadow etc etc)??
thanks

@NiroTheHero yeah, since I'm creating the button from scratch (or rather, in my implementation, I'm using interfaceBuilder.makeActionButton) it's available in code as a customizable view; I haven't actually done any visual customization in there, but it's certainly possible!


Blank plotly 3D plots

Description:
I followed this tutorial to plot the 3D scatter plot. But seems like it cannot render 3D plots properly.

As shown on the figure above, the hover text is properly displayed but no data points are shown.
However, when I tried to do 2D line chart, it render properly.

Steps to Reproduce:

Copy the code of "Basic 3D Scatter Plot" in 3D Scatter Plots in Python
Run, 3D scatter plot does not work properly.
Copy the code of "Simple Line Plot" in Line Charts in Python
Run, line chart will be rendered properly.

Versions:
Mac OS 10.12.6
Atom    : 1.22.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
plotly: 2.2.2
Logs:
Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-eval'". Either the 'unsafe-inline' keyword, a hash ('sha256-swz/ljTjUNUGwUQTCdL2vZS/ni77MS56012RAz3iLBk='), or a nonce ('nonce-...') is required to enable inline execution.
This error is shown when I run plotly.offline.init_notebook_mode(). But same error appeared when I plotted the 2D line plots therefore I think it might not related to the issue.

This looks like a CSS issue.

I haven't tested it, but I'm pretty confident that this line introduces the problem:
https://github.com/nteract/hydrogen/blob/09bacb3556dbd9ee3b85d8cbc28a0b62eeb9defc/styles/hydrogen.less#L46-L48

By canceling the background-color in developer tool, it solve this problem. Thanks a lot :)

Is there any workaround I can use to solve this problem without have to open the dev tool? (e.g. adding some snippets when starting up or somethings). Sorry for not really familiar with CSS syntax.
Thank you!

We should better scope
https://github.com/nteract/hydrogen/blob/09bacb3556dbd9ee3b85d8cbc28a0b62eeb9defc/styles/hydrogen.less#L46-L48
This line is mostly there to ensure a white background for SVG plots rendered with matplotlib or similar but unfortunately breaks plotly 3D plots.
Personally I'd be OK with removing this line at the cost of not having a white background for matplotlib SVG plots.
I'm going to label this as a good first issue if someone wants to dig into it and find a better solution.


Role Entity modification not taken in account in interactive mode

Rasa version: 1.10.3
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant):
Python version: 3.6.9
Operating system (windows, osx, ...): MacOS Catalina 10.15.5
Issue:
I use the recent feature of Role and groups for entities (and I think it is very usefull) but when I want to train this with interactive mode, if the role is not good and I modify it, the modification is not taken in account.
In the example below, we can see the entity "Lyon" is a "city-site" but it has to be a role "source" but my modification doesn't appear in the chat history after.
Thank you by advance.
Error (including full traceback):
------
? Your input -> bloque skype depuis lyon vers porto
? Is the intent 'reseau_action' correct for '[bloque]{"entity": "action", "value": "deny"} [skype](application)
 depuis [lyon]{"entity": "city-site", "role": "destination"} vers [porto]{"entity": "city-site", "role": "desti
nation"}' and are all entities labeled correctly?  No
? What intent is it?  1.00 reseau_action
? Please mark the entities using [value](type) notation [bloque]{"entity": "action", "value": "deny"} [skype](a
pplication) depuis [lyon]{"entity": "city-site", "role": "source"} vers [porto]{"entity": "city-site", "role":
"destination"}
------
Chat History

 #    Bot                                                                                You
──────────────────────────────────────────────────────────────────────────────────────────────────────
 1    action_listen
──────────────────────────────────────────────────────────────────────────────────────────────────────
 2                          [bloque]{"entity": "action", "value": "deny"} [skype](application) depuis
                          [lyon]{"entity": "city-site", "role": "destination"} vers [porto]{"entity":
                                                                  "city-site", "role": "destination"}
                                                                           intent: reseau_action 1.00
──────────────────────────────────────────────────────────────────────────────────────────────────────
 3    slot{"action":
      "deny"}

Command or request that led to error:
rasa interactive

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/

language: fr

pipeline:
  - name: WhitespaceTokenizer
  - name: RegexFeaturizer
  - name: LexicalSyntacticFeaturizer
  - name: CountVectorsFeaturizer
  - name: CountVectorsFeaturizer
    analyzer: "char_wb"
    min_ngram: 1
    max_ngram: 4
  - name: DIETClassifier
    epochs: 100
  - name: EntitySynonymMapper
  - name: "DucklingHTTPExtractor"
    url: "http://localhost:8000"
    dimensions: ["time"]
    timezone: "Europe/Paris"
    timeout : 3

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: "TEDPolicy"
    epochs: 250
    max_history: 5
  - name: "FallbackPolicy"
    fallback_action_name: 'action_default_fallback'
  - name: "MemoizationPolicy"
    max_history: 5
  - name: "FormPolicy"
  - name: "MappingPolicy"

Content of domain file (domain.yml) (if relevant):

Thanks for raising this issue, @akelad will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

@julienbronner Thanks for raising the issue. We will fix this as soon as possible.


Independent Helper

Is there a way to define a standalone helper like:
class MyHelper(FormHelper):
    form_class = 'form-horizontal'
    label_class = 'col-sm-3'
    field_class = 'col-sm-9'

That I could use directly from my templates
{% crispy my_form my_helper %}

The docs says

Most of the time, you will want to use the helper attached

That doesn't seem to be my case for 3 main reasons:

I'm using the same forms in multiple pages with not always the same rendering
I use the same CSS for most of my forms
I generally prefer controlling the rendering from the templates

I agree with your points and ended up creating a few helpers and exposing them globally to templates via a template context processor.


Working directly with the C library

I'm trying to understand how to access the C library directly with the Python wrapper. The below code works in my simple tests to return all of the fired actions (after creating, binding and asserting some facts on a ruleset). But I'm not convinced its using the API correctly. Does this look right?
def get_actions(ruleset_handle):
    retval = []
    result = rules.start_action(ruleset_handle)
    res = result[1]
    while res:
        retval.append(json.loads(res))
        binding, replies = rules.start_update_state(ruleset_handle, result[2], result[0])
        res = rules.complete_and_start_action(ruleset_handle, replies, result[2])

    return list(retval)

Hi thanks for posting the question. Yes the code above will drain all actions scheduled as a result of changing the state. Do you have any scenario in mind for using the C API directly? I haven't documented it as it is hard to use, it is intended to be for internal use of the language specific engines.

Thanks! I'm trying to dynamically define rulesets. I have rules that are already written in a custom language that I'm translating into durable.lang.value and durable.lang.avalue at runtime. I couldn't find a way of ingesting those directly in durable.engine but I also didn't look very hard.  If you have a suggestions for a better way to do that other than going directly to the C API that would be great.

Hi, you might find this test interesting: https://github.com/jruizgit/rules/blob/master/testpy/testdynamic.py . It feeds the engine with a ruleset defined in JSON and translates actions. It uses the full dispatcher including statechart and flowchart transforms.

That gave me what I needed, thanks! Is there a way to tell when the engine has completed processing, i.e. all actions have fired?


License?

How free is this content to use?

Good point. Let me add a license file.

Fixed, added MIT


[bug] The input box does not support Chinese input method for firefox ext, chrome not tested

when I try to input with chinese input method, only letters show up. no matter sogou pinyin or microsoft pinyin (windows 11 default chinese input method).
but i can paste chinese into the input box with ctrl+c/ctrl+v.
need to method that, microsoft ABC (Windows 7 chinese input method) can input Chinese characters directly in the input box, but not that smooth
could you please fix that, thank you

Hey, thanks for reporting this issue. I will fix it. Do you have the same issue on Chrome as well? If you can test it on Chrome, please give me feedback. I released a similar fix a few months ago, but I haven't tested it on Firefox yet.

hey, chrome don't have this bug, i can type chinese directly.


Inherit PageHeader from CommandBar. …

Better Design Time support.
Removed Text dependency property and reintroduced the content property.
Ellipsis Button is always visible, following the commandbar behavior.
We can hide the ellipsis if no commands exist, or introduce a behavior property to control it

Good idea. Could you re-merge and resubmit? This is out of sync.


MQTT doesn't reconnect after connection lost

MQTT client doesn't reconnect after connection lost caused by a broker restart.

It would help if you provided the device and the version of Android.

I’m using a Google Nexus 7 2012 3g (nakasig) with the last official rom (Android version 5.1.1).
Many thanks!

I am afraid that was done intentionally for devices running Android versions below Lollipop.  Those devices have connection issues when the connection was dropped.  So the device does not try to disconnect on a loss connection for your Android version.  There is nothing to be done unless you want to compile the application yourself and remove that part of the code.

I updated my Nexus 7 to Android AOSP 7.1.2 and now the MQTT client reconnects after a broker reboot.
Thank you very much for your support


Handle trailing whitespace in tag values

Fixes #392.
RELEASE NOTES BEGIN
Value of a Tag no longer includes trailing whitespace (if any).


Fix PageImage mapping and association towards PageTranslation

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #191

License
MIT

As mentioned is the issue, I think MRs #209 and #214 were both attempts to fix the same bug - maybe merge one of them and close the others ?
If you could tag a version with this patch, it would be awesome :)


refactor: Simplify HeartRateMode logic

Refactor the HeartRateMode callback handling and heart rate logic, in preparation to support a new mode that relies on heart rate and power output

https://github.com/edabe/dreo-headwind/pull/11 resolves this issue.


ioquake3: 2019-05-29 -> 2020-08-29

Motivation for this change
Upstream update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 96935 run on x86_64-linux 1

2 packages built:

ioquake3
quake3demo

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

@GrahamcOfBorg build ioquake3

@GrahamcOfBorg build ioquake3

@ofborg eval

Please change pkgconfig in line 1 to pkg-config.

Please change pkgconfig in line 1 to pkg-config.

@ofborg eval

@ofborg eval

@GrahamcOfBorg build ioquake3

@GrahamcOfBorg build ioquake3