Unable To Use @shopify/post-purchase-ui-react with Vite

I am trying to use this package for developing upsell extensions: @shopify/post-purchase-ui-react
But I am getting the error I posted here https://github.com/Shopify/post-purchase-ui/issues/16
I've made a sample repo here. You can reproduce the issue by running yarn dev at https://github.com/eni9889/shopify-frontend-template-react

Hi @eni9889. Can you give me a quick walkthrough of the steps you've taken. For example, what command did you use to create the app? Is it a new app or an older app that you're adding the post purchase extension to? What command are you using to create the extension?
Looking at the repo you linked, I'm not seeing an extensions directory, which I'd expect.

@dnagoda thank you for commenting. I forked the Shopify Frontend react template and then just added that package. The package I'm having issues with is not used in an extension it is used to create previews etc of extensions. I just added it as a package using yarn and then tried to run the project with yarn dev and then you can see the resolution errors.

@dnagoda thank you for commenting. I forked the Shopify Frontend react template and then just added that package. The package I'm having issues with is not used in an extension it is used to create previews etc of extensions. I just added it as a package using yarn and then tried to run the project with yarn dev and then you can see the resolution errors.

Got it. Thanks for the extra detail.
Out of curiosity, why not use the Shopify CLI?
https://github.com/Shopify/cli

Have you tried following the post purchase tutorial: https://shopify.dev/docs/apps/checkout/product-offers/post-purchase? You should be able to yarn create @shopify/app to create a new app. Then from that app directory yarn generate extension, choosing (11) Post-purchase UI.
I feel like I'm still missing some aspect of what you're trying to do. If you're trying to create an upsell extension, then the tutorial linked above should be a good starting point.

Thanks for the additional information. I'm going to link these comments back into the issue you created in the post-purchase-ui repo and close this issue. I'll also ping a couple of people internally to see if I can get someone with more context on that project to take a look.
Duplicate https://github.com/Shopify/post-purchase-ui/issues/16.

Thanks for the additional information. I'm going to link these comments back into the issue you created in the post-purchase-ui repo and close this issue. I'll also ping a couple of people internally to see if I can get someone with more context on that project to take a look.
Duplicate Shopify/post-purchase-ui#16.

The Duplicate issue wasn't available because the repo was archived.
Any news about it?


python310Packages.pyee: 8.2.2 -> 9.0.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyee is: "A port of Node.js's EventEmitter to Python"
meta.homepage for python310Packages.pyee is: "https://github.com/jfhbrook/pyee"
meta.changelog for python310Packages.pyee is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 9.0.4 with grep in /nix/store/iz9n63wrsb2f23fsdkcl2k91xcra49cl-python3.10-pyee-9.0.4

found 9.0.4 in filename of file in /nix/store/iz9n63wrsb2f23fsdkcl2k91xcra49cl-python3.10-pyee-9.0.4

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

8 package rebuild(s)

8 x86_64-linux rebuild(s)
8 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyee
python310Packages.pyppeteer
python310Packages.webthing
python39Packages.pyee
python39Packages.pyppeteer
python39Packages.webthing
theharvester
urlwatch

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/iz9n63wrsb2f23fsdkcl2k91xcra49cl-python3.10-pyee-9.0.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyee https://github.com/r-ryantm/nixpkgs/archive/3b7958dafd938a09fe782b4770e2e4afcb4025ff.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/iz9n63wrsb2f23fsdkcl2k91xcra49cl-python3.10-pyee-9.0.4
ls -la /nix/store/iz9n63wrsb2f23fsdkcl2k91xcra49cl-python3.10-pyee-9.0.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

python310Packages.pyppeteer
python310Packages.webthing
python39Packages.pyppeteer
python39Packages.webthing
theharvester
urlwatch

2 packages built:

python310Packages.pyee
python39Packages.pyee

Maintainer pings
cc @kmein for testing.

Done by<PHONE_NUMBER>7964b1681096a68f5fb626687c42eb.


Small typo in the documentation

What happened:
Hi,
First of all, thanks for your work great on this Datasource plugin. I'm starting to using and it's really powerful !
I'm opening this ticket because there is a small typo in the documentation (https://grafana.com/grafana/plugins/grafana-athena-datasource/) :
$__rawtimeFrom() => $__rawTimeFrom()

I lost a lot of time to understand why it was not working so it can maybe prevent other people to do the same. And I found the solution thanks to this ticket: https://github.com/grafana/athena-datasource/issues/149
What you expected to happen:
$__rawtimeFrom() => $__rawTimeFrom()

in the documentation
How to reproduce it (as minimally and precisely as possible):

Screenshots

Anything else we need to know?:
Environment:
Useless information I think

Grafana version:
Plugin version:
OS Grafana is installed on:
User OS & Browser:
Others:

thanks for reporting this @CharlesBlonde! maybe you can open a quick PR updating the docs?

Please review for any changes :)

Thanks for the fix and it has been fixed to quickly by @PrajwalBorkar  I wasn't able to do the PR :)
Nevertheless, I didn't realized the typo root source was README.md...
I was personally  using this page as documentation and not the Github README. I guess it will be updated with the next release ?

I was personally using this page as documentation and not the Github README. I guess it will be updated with the next release ?

That's correct :+1:


Crash during initial storage location setup prevents successfully completing initial setup

Steps to reproduce

Initial screen.

Second screen with option to select the storage location.

Android file picker opens

Opening the folder ("Mihon", "Aniyomi" or "Tachiyomi" depending on the app)

After pressing the select button, it asks for read/write permission for the selected folder. On clicking allow, the app crashes.

The initial screen where the app ends up after the crash. All progress lost and no folder selected, so it doesn't let you continue to the main part of the app.

These screenshots are from testing it on Aniyomi, but the bug is 100% identically replicable with at least Mihon 0.16.3, Tachiyomi from 0.15.x and Aniyomi from 0.15.x
Maybe a compatibility issue with One UI?
Maybe there's a possibility of a temporary fix that lets you skip this initial setup? (and maybe an option where it can be done later in settings still, which would be useful anyway so the storage folder can be changed after setup)
Bug verified on a Samsung Galaxy S22 Ultra, Security Patch level 1.1.2024
Expected behavior
After Step 5, it should return to the screen of Step 2, with the selected storage location locked in and the option to continue appearing.
Actual behavior
App seems to crash at Step 5, and then immediately reverting back to Step 1 (same as Step 6), not having locked in the selected storage location, so there is no way to successfully finish the initial setup.
Crash logs
No response
Mihon version
0.16.3
Android version
Android 14, Security Patch Level 1.1.2024 (One UI 6.0)
Device
Samsung Galaxy S22 Ultra
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

It seems that this affects other devices besides Samsung phones too, see #395 and #645
Two possible solutions for this:

During initial setup, have a default path for the storage folder already preset, so the user can continue setup without having to use the potentially buggy filepicker.
Make the storage path setting step entirely optional, allowing the user to continue initial setup without selecting a storage folder.

UPDATE:
Issue is solved, the crash happened because "Don't keep activities" was enabled in Developer Settings.
Disabling that setting makes it work normally.


Update CONTRIBUTING.rst

Hi Team,
I updated the appropriate docs with the correct links and contact info.
Thanks in advance for the review.

Thanks for the feedback @athy9193! Hopefully, this clarifies things,


Issue #SB-29116 fix: Pagination issue and download request body updated for certificate

Pagination in learner passbook - View more and view less
RC Verification invalid UI updated
Download RC certificate; request body updated

@rajeevsathish


Better errors for metadata discovery

Is your feature request related to a problem? Please describe.
When a model is not discovered, an error with selecting name in this function:
    initFactoryField(prop) {
        ['mappedBy', 'inversedBy'].forEach(type => {
            const value = prop[type];
            if (value instanceof Function) {
                const meta2 = this.metadata.get(prop.type);
                prop[type] = value(meta2.properties).name;
            }
        });
    }

Describe the solution you'd like
    initFactoryField(prop) {
        ['mappedBy', 'inversedBy'].forEach(type => {
            const value = prop[type];
            if (value instanceof Function) {
                const meta2 = this.metadata.get(prop.type);
                console.log(type)
                try {
                    prop[type] = value(meta2.properties).name;
                } catch (cause) {
                    throw new Error(`Metadata discovery for ${type} failed: ${cause.message}`)
                }
            }
        });
    }

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the feature request here.

Any updates? I'd very much like to improve the validation, but you did not gave me much here - I need a way to reproduce, and the error message with stack trace as the bare minimum.
Otherwise will close as this is not actionable as is. Tried to reproduce but the existing validation seems to be enough.

Closing due to inactivity 🤷
Will be happy to improve, but not without a repro...


Add platform and sensors for Vultr VPS

Description:
Allows the Vultr VPS provider to be used as a hub, binary sensor (representing currently running or not of each subscription (vps), attributes being everything static about the vps), sensor (two types for the moment representing current bandwidth usage this period in GB and the current pending charges in US$).
This is my first platform / sensor creation so I would love any feedback. It was stitched together with reference code from the DigitalOcean platform and various other components.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3663
Example entry for configuration.yaml (if applicable):
vultr:
  api_key: ABCDEF123456

binary_sensor:
  - platform: vultr
    subs:
      - "123456"
      - "567899"

sensor:
  - platform: vultr
    monitored_conditions:
      - current_bandwidth_gb
      - pending_charges
    subs:
      - "123456"
      - "567899"

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

Do I need to add manually each new file to .coveragerc or do I only add if I want to ignore them? I don't think I want to ignore the coverage but not 100% on if I need to add anything or not.


accidental type coercion ?

Hello,
https://github.com/stackworx/formik-material-ui/blob/5aa57434d92b99d82ab541d55558311adc211773/src/TextField.tsx#L31
Is there a reason why it is != ? My IDE complains about it
Thanks !

It's just to catch disabled being undefined or null
undefined != undefined // false
null != undefined // false
null !== undefined // true

it could probably be written as disabled ? isSubmitting : disabled


move beacon API types from paradigmxyz/reth to a new crate in alloy

Motivation
https://github.com/paradigmxyz/reth/issues/8094

Solution
Moved the beacon crate from https://github.com/paradigmxyz/reth to rpc-types-beacon

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

@mattsse

smol nit
@prestwich imo beacon API types are useful and there are more coming, for example for sidecars paradigmxyz/reth#7443
they are closely related to EL types (engines) but for some reason the CL uses different formatting rules...
I'd prefer having this crate in this repo because we want them to be compatible with engine and other types
wdyt

yeah, works for me


Seems impossible to get visual studio task or msbuild task to build *.sqlproj on Hosted Agent wit VS 2017

It does not produce any output, just a warning:
XXX.Database.sqlproj.metaproj : warning MSB4078: The project file "XXX.Database\XXX.Database.sqlproj" is not supported by MSBuild and cannot be built.

According to this blog post it should work out of the box on hosted agents : https://blogs.msdn.microsoft.com/ssdt/2016/04/06/sqldb-cicd-part2-build/
I tried to install the nuget package and override SQLDBExtensionsRefPath variable without any success.

It actually works if I target the project and not the solution which is really weird.

I have very random behavior around this issue between builds. I'm closing it for now, I'll reopen if I can narrow down a 100% reproduction scenario.

Ok found the issue, this is a problem with msbuild which hides the real issue behind this message. Nothing to do with the task. (in this case in one build, the sqlproj had invalid data injected by the build process)


validator in generated tests fails due to "UNRESOLVABLE_REFERENCE"

In the swagger spec file, the schemas of my responses contain
$ref: "#/definitions/SomeOtherResponse"

but swagger-test-templates failed to load the referred definitions and put them before the actual schemas, and that causes the validator failing due to "UNRESOLVABLE_REFERENCE"

How you resolve references in your swagger file before using it with this?

In the swagger file, there's a "definitions" property ( check out here ), and you can define schema objects here and reference them in other places(i.e. responses, parameters, etc) so that complex schemas can be re-used.

You need to resolve the references you make to the definitions you define so that when parsing, we have the full definition not the reference. So before using testGen, you have to use the swagger-tools module and call resolve, as it is done here
I hope this helps!

Closing as answer was given and lack of activity. Reopen if problem/confusion persists.


Mascot voice is off when going to another page

So with the Tomorrow theme you get a different mascot and voice when you click on it. If you follow any link or reload the page and click on the mascot you hear the voice of the standard mascot.

Already fixed in dev.pantsu.cat


allow to give away some thrust for yaw control

@tumbili What about the lower limit case?

@LorenzMeier I haven't managed to get yaw unstable on very fast descends yet. Maybe some quads with very low hover thrust will have problems. I don't know.

Ok, so this looks like a safe fix, even if its not the best / final one, so I'm merging it.
@tumbili Please send PRs against the release branch while we're in release mode. I'll cherry-pick this one into both branches.

@LorenzMeier this went to master instead to release_v1.0.0

Its also cherry picked there:
https://github.com/PX4/Firmware/blob/release_v1.0.0/src/modules/systemlib/mixer/mixer_multirotor.cpp#L316

Oh ok, we've flown release yesterday and it still lost yaw, why I was wondering.

In that case we should look at the log. Roman tested it successfully on our setups.

Should we keep #2279 open for further work?

Yes, will share the log


HDDS-10154. isKeyPresentInTable should use the constructor with prefix

What changes were proposed in this pull request?
isKeyPresentInTable should use the constructor with prefix.
The table iterator implemented over rocksDB can seek to the prefix if provided at the time to construction. This can avoid wasteful seekToFirst behavior that is part of the construction of the iterator.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10154
How was this patch tested?
Existing tests

@kerneltime can you explain the difference in the two options? Looking at the code it seems both options end up calling RDBStoreAbstractIterator#seek0 soon after the iterator is created. Based on the RocksDB API it does not look like the underlying implementation does anything different in these two cases.

@kerneltime can you explain the difference in the two options? Looking at the code it seems both options end up calling RDBStoreAbstractIterator#seek0 soon after the iterator is created. Based on the RocksDB API it does not look like the underlying implementation does anything different in these two cases.

When the constructor is called without prefix
  RDBStoreByteArrayIterator(ManagedRocksIterator iterator,
      RDBTable table, byte[] prefix) {
    super(iterator, table,
        prefix == null ? null : Arrays.copyOf(prefix, prefix.length));
    seekToFirst();
  }

seekToFirst() does
  public final void seekToFirst() {
    if (prefix == null) {
      rocksDBIterator.get().seekToFirst();
    } else {
      seek0(prefix);
    }
    setCurrentEntry();
  }

which in turn calls
  @Override
  public void seekToFirst() {
    assert (isOwningHandle());
    seekToFirst0(nativeHandle_);
  }

@kerneltime can you explain the difference in the two options? Looking at the code it seems both options end up calling RDBStoreAbstractIterator#seek0 soon after the iterator is created. Based on the RocksDB API it does not look like the underlying implementation does anything different in these two cases.

This behavior was first fixed for https://issues.apache.org/jira/browse/HDDS-8289. There needs to be a clean up of TableIterators to behave the same way when in memory vs via RocksDB. My initial attempt to clean up this code did not go as cleanly as this works only when the table type is RocksDB. I am continuing to investigate how to make the behavior the same (always initialize  the iterator with prefix when prefix is available).

Thanks @kerneltime for the patch, @duongkame, @errose28 for the review.


Link posted by GitHub action broken

In case the guidelines for auto merging are not met and there is an issue with compatibility specification, the bot posts a link to
https://julialang.github.io/Pkg.jl/v1/compatibility/
which should instead link to
https://julialang.github.io/Pkg.jl/v1/compatibility   (.html)
=> delete trailing /

Please reopen at the Pkg.jl repo.


[Feature]:  Add Captcha verification to the register form

[x] Would you like to take up this task?
[x] Are you from GSSoC'23?

✨
Feature request

Is your feature request related to a problem?
A captcha verification must be present to differentiate between a human and a bot

Describe the solution you'd like
Will like to add a captcha verification below the register form before submitting

Get it done !!

Yup. Will get back soon.

In the frontend codebase i dont see vite anywhere

We went back to CRA we have to remove it  will do that now


[ISSUE-#7299] Logic optmization about zookeeperServiceDiscoveryChangeWatcher.

What is the purpose of the change
For-#7299
1.use same instances to notify listener.onEvent and dispatchServiceInstancesChangedEvent.
2.modify the re watcher machine mechanism, re watcher by ZookeeperServiceDiscoveryChangeWatcher self.

Codecov Report

Merging #7300 (90f9431) into master (51d5a88) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d5a88...90f9431. Read the comment docs.

pls resolve conflict


[BUG] No connection could be made because the target machine actively refused it C:\pathToCRCHome\crc.sock

General information

OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
# Put `crc version` output here
CodeReady Containers version: 1.28.0+08de64bd
OpenShift version: 4.7.13 (embedded in executable)

CRC status
# Put `crc status --log-level debug` output here

CRC config
# Put `crc config view` output here

Host Operating System
# Put the output of `cat /etc/os-release` in case of Linux
# put the output of `sw_vers` in case of Mac
# Put the output of `systeminfo` in case of Windows

Steps to reproduce

Happens during crc setup
Happens during crc start

Expected
No error dialog
Actual
Error dialog is shown multiple times during operating crc (either setup or starting)
Logs
Before gather the logs try following if that fix your issue
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

Please consider posting the output of crc start --log-level debug  on http://gist.github.com/ and post the link in the issue.

Can you run crc setup and report the output here ?
Thanks
crc.sock socket is created by crc daemon command.

$ crc setup
CodeReady Containers is constantly improving and we would like to know more about usage (more details at https://developers.redhat.com/article/tool-data-collection)
Your preference can be changed manually if desired using 'crc config set consent-telemetry <yes/no>'
Would you like to contribute anonymous usage statistics? [y/N]: No worry, you can still enable telemetry manually with the command 'crc config set consent-telemetry yes'.
INFO Checking if crc-admin-helper executable is cached
INFO Checking for obsolete admin-helper executable
INFO Checking if running on a supported CPU architecture
INFO Checking minimum RAM requirements
INFO Checking if running in a shell with administrator rights
INFO Checking Windows 10 release
INFO Checking Windows edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if crc-users group exists
INFO Checking if current user is in Hyper-V group and crc-users group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if admin-helper daemon is installed
INFO Checking if vsock is correctly configured
INFO Checking if CodeReady Containers daemon is installed
INFO Checking if tray executable is present
INFO Caching tray executable
INFO Checking if tray is running
INFO Starting CodeReady Containers tray
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking if C:\Program Files\CodeReady Containers\crc_hyperv_4.7.13.crcbundle exists
INFO Extracting bundle from the CRC executable
INFO Ensuring directory C:\Program Files\CodeReady Containers exists
INFO Uncompressing crc_hyperv_4.7.13.crcbundle
crc.vhdx: 11.57 GiB / 11.57 GiB [-----------------------------------------------------------------------------] 100.00%
Your system is correctly setup for using CodeReady Containers, you can now run 'crc start' to start the OpenShift cluster

@odockal do you still have same issue?

@praveenkumar I do not know right now, it has been two months. Next week we are testing so I will check again next week.

Haven't seen it lately.


Wrong logging format was found in meta server_state

Some logs are found for meta server as follows:
F2022-09-09 17:02:17.184<PHONE_NUMBER>184230445 11231)   meta.meta_state0.0202000700000001: server_state.cpp:895:on_config_sync(): assertion expression: false
F2022-09-09 17:02:17.184<PHONE_NUMBER>184247617 11231)   meta.meta_state0.0202000700000001: server_state.cpp:895:on_config_sync(): gpid({}) on node({}) is not exist on meta server, administrator should check consistency of meta data

The key point is gpid({}) on node({}) in logs of meta server rather than the fatal level, which is the result of connecting to a wrong replica server. gpid({}) on node({}) must be caused by invalid logging format.

This issue has been fixed by https://github.com/apache/incubator-pegasus/pull/1217.


New Tables should populate at top of Tables list for easier navigation

Azure Data Studio Version: 1.36.2
OS Version: Windows 10

Steps to Reproduce:

Create new table on Azure Data Studio
Hit "Publish" icon
Select "Update Database
Right-click on Tables folder and select "Refresh"

Expected Result:
New table should be seen at top of Tables list drop-down
Actual Result:
This is not the case; user has to traverse down drop-down to find newly created table.
For example, in the image below, "Lists" is the name of the newly created table. It should be at the top of the list, but rather, it is 4th on the list which is not very intuitive. This makes navigating objects with lots of tables a bit strenuous.

FYI @alanrenmsft @caohai

Does this issue occur when all extensions are disabled?: No

I don't think this necessarily should be the case - many people would prefer it to be alphabetical like it is currently.
Rather, what the "best" solution would be is to have the ability to choose how the list is sorted. So then the user could choose themselves whether the list is alphabetical, by age, or some other metric.

Expected Result:
New table should be seen at top of Tables list drop-down

Can you elaborate on why this should be the expected result? Once a new table is published, it becomes an existing table, just like other tables, I'm not sure why it should be on the top.
If you are saying we want a different sorting option for tables in OE, then it's a different story but that has nothing to do with table designer itself.
I also tested in SSDT and the newly created table [YYYYYTable] is not at the top.

I agree with @Charles-Gagnon  I believe that we should provide users the flexibility to decide how they want their tables to be sorted. We can start with two metrics (sort by "recently added" OR sort by "alphabetical") and continue to add more metrics as needed as we iterate on this feature. @caohai


Vim commands such as y, r and ~ result in invalid cursor positions

See https://github.com/RyotaUshio/obsidian-inline-math/pull/9#issuecomment-2468140997

Interestingly, repeatedly doing the keypresses ~ then <C-z> has the following effect: The first time the cursor jumps back two positions, and all subsequent times it jumps back three positions. (Note that <C-z> is tapping obsidian/codemirror's native undo.  Vim's undo key of u actually jumps to the start of the expression with this plugin - presumably because it detects the brace insertion being the most recent change)
I wonder if a cheap fix for all of this would be to have a plugin option of just persisting the braces beside the dollars from the moment the dollar is inserted instead of automatically removing them every time the expression is deselected and then reinserting them when needed.


Stm32f0x0 PLLSRC

the f0x0 devices have a 1 bit PLLSRC, this patches that and updates the appropriate enum.

Thanks!


isNumber(new Number(5)) is false

I'd never use new Number but I think is a use case that should be handled... because is actually a number.

it will return true, what's your code?

I'm sorry, I see the lib of 4.0.0, so the feature is removed, I don't know why

The use of Number constructor new Number() is believed to be a bad practice by many so the lib is right in keeping things consistent

Closing, for the same reasons mentioned by @bodazhao in https://github.com/jonschlinkert/is-number/issues/18#issuecomment-532468827


WARNING: Unable to start rtorrent

Hi,
i tried "rt start" but not possible.
Get error "WARNING: Unable to start rtorrent"
thx

Same happened to me as well.
Did you find any solution?

I actually had the same issue, it became resolved after doing the following fix:
https://github.com/arakasi72/rtinst/issues/246

Yea I also had this issue and tried to figure it out for 2 days and almost gave up on it. It also showed me the same error and on the webui it showed "No connection to rTorrent. Check if it is really running. Check $scgi_port and $scgi_host settings in config.php and scgi_port in rTorrent configuration file.".
For me I just did apt-get install rtorrent after rtinst, then restarted the server and it seems to work (for now).


Set eval_sample_packing to false in mistral config.yaml

Without eval_sampling_packing set to false, running accelerate launch -m axolotl.cli.train examples/mistral/config.yml returns the following error:
ValueError: eval dataset split is too small for sample_packing. You should set `eval_sample_packing: False`.

Related to Issue #999.

Went ahead and merged this since was a small docs change


License

Great work! What is the license of the repo?

We just updated our LICENSE under Apache License 2.0.


Tests fail with OpenSSL > 3.0.1

There are tests which check if TLS 1.0. and TLS 1.1 work if owasp_cipher_string C or D are used. TLS 1.0 and 1.1 are not supported anymore by default in OpenSSL > 3.0.1.

Solved by removing support for TLS 1.0 and 1.1.


Remove moot version property from bower.json

Per bower/bower.json-spec@a325da3
Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property

Merged, and noted. I don't even use bower any more, I just have it here for others that do.


Split date and time entry

What you want:
In the data entry screen, split the date entry from time, i.e. have two different fields that can be clicked on.
Why you want it:
No response

Oops, dupe.


Use FINAL for immutable variables creates syntax error in case of method call

Given is the following code:
class lcl_test definition create private.
  public section.
    types: begin of test,
             id   type sysuuid_x16,
             name type string,
           end of test.
    methods show_data.
endclass.

class lcl_test implementation.
  method show_data.
    try.
        data(test_data) = value test( id   = cl_system_uuid=>create_uuid_x16_static( )
                                      name = 'Test' ).
        cl_demo_output=>display( test_data ).
      catch cx_uuid_error.
        raise exception new cx_sovy_fsi_event_dispatcher( ).
    endtry.
  endmethod.
endclass.

When I run the ABAP Cleaner with the rule Use FINAL for immutable variables I will get a syntax error and the declaration type of the variable test_data will change from DATA to FINAL.

Manual solution is to either extract the creation of the id upfront:
        final(id) = cl_system_uuid=>create_uuid_x16_static( ).
        final(test_data) = value test( id   = id
                                       name = 'Test' ).

Or to move id generation to the last line:
        final(test_data) = value test( name = 'Test'
                                       id   = cl_system_uuid=>create_uuid_x16_static( ) ).

Which is weird, but works.
It would be great if you could add another check to either extract the result of inline calls into own variables or don't change the declaration type in that case.

Or to move id generation to the last line:

Seriously? The weird edge cases of the chosen expression implementation strike again :(
A variable inside the expression also works by the way:
        final(test_data) = value test( LET i = cl_system_uuid=>create_uuid_x16_static( ) IN
                                       id   = i
                                       name = 'Test' ).

In my opinion this should be fixed or at least documented somewhere. Having to account for this in abap-cleaner seems unreasonable, especially when it's not obvious what works and what does not.

Hi Christian,
that's an amazing finding indeed! And you can find more surprising examples, e.g.

I shall ask colleagues from the ABAP compiler team about this. However, even if the compiler learns to deal with those cases at some point in the future, I think for the time being it would be best to prevent introducing FINAL whenever any method calls are found inside of constructor expressions on the right-hand side.
Kind regards,
Jörg-Michael

Hi Christian and Fabian,
with the next release, the workaround would be as mentioned: Whenever a method call is found inside of a constructor expression, DATA is kept:

Hope this solves the issue, even if it does a bit too much; please let me know if you find cases which still cause a syntax error!
Kind regards,
Jörg-Michael

I shall ask colleagues from the ABAP compiler team about this.

Hi Jörg-Michael, done that already 👍🏼

Hi Christian, Fabian and Suhas,
thanks again for reporting this! The workaround is now in place with version 1.5.3, which was just released. Closing this issue for now, but if there are news from the ABAP compiler team on this, we could see if the workaround can be modified accordingly or even removed at some point.
Kind regards,
Jörg-Michael

Cool. Thanks a lot.


support laravel 5.7

change require 5.7

Newer version has been tagged. https://github.com/Crinsane/LaravelShoppingcart/releases/tag/2.6.0 Sorry for the delay, but life got in the way.


optimize: declare @Bean methods as static

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
GlobalTransactionScanner,SeataAutoDataSourceProxyCreator declare @Bean methods as static
Ⅱ. Does this pull request fix one issue?
https://github.com/seata/seata/issues/5176

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #5180 (70f0200) into develop (8000195) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 70f0200 differs from pull request most recent head 58b3bfc. Consider uploading reports for the commit 58b3bfc to get more accurate results

@@              Coverage Diff              @@
##             develop    #5180      +/-   ##
=============================================
+ Coverage      48.47%   48.48%   +0.01%
- Complexity      4136     4138       +2
=============================================
  Files            743      743
  Lines          26517    26517
  Branches        3294     3294
=============================================
+ Hits           12853    12856       +3
+ Misses         12263    12262       -1
+ Partials        1401     1399       -2

Impacted Files
Coverage Δ

...ing/boot/autoconfigure/SeataAutoConfiguration.java
0.00% <ø> (ø)

...utoconfigure/SeataDataSourceAutoConfiguration.java
0.00% <ø> (ø)

...very/registry/zk/ZookeeperRegisterServiceImpl.java
61.02% <0.00%> (-0.74%)
:arrow_down:

...er/src/main/java/io/seata/server/ServerRunner.java
50.00% <0.00%> (ø)

...in/java/io/seata/server/session/GlobalSession.java
78.68% <0.00%> (ø)

...torage/file/store/FileTransactionStoreManager.java
56.27% <0.00%> (+0.64%)
:arrow_up:

...o/seata/server/coordinator/DefaultCoordinator.java
45.08% <0.00%> (+0.81%)
:arrow_up:


main.py needs to be refactored

Change its name to something more meaningful
Remove optimization related code
Be able to receive "rules" parameters (from the competition manual) or delegate this to some other function

Partially solved with #191
Rules being passed as parameters is a feature that should have its own Issue and will not be covered under the 1.0 release.


[Storage] BREAKING CHANGE: az storage account create: Server change the default value to False for --allow-blob-public-access and --allow-cross-tenant-replication

Describe the bug
Beginning August 2023, there will be server breaking changes to these default security settings when creating a storage account.

--allow-blob-public-access will default to False instead of None now
--allow-cross-tenant-replication will default to False instead of True now.

Please see the blog post about the security risk and server change details:
https://techcommunity.microsoft.com/t5/azure-storage-blog/azure-storage-updating-some-default-security-settings-on-new/ba-p/3819554
Related command
az storage account create
Errors
--allow-blob-public-access and --allow-cross-tenant-replication default to False
Issue script & Debug output
N/A
Expected behavior
--allow-blob-public-access and --allow-cross-tenant-replication will default to False starting August 2023
Environment Summary
azure-cli                         2.50.0
core                              2.50.0
telemetry                          1.1.0
Additional context
No response

Thank you for opening this issue, we will look into it.


fix: formatting for easy copy paste of code

A minor improvement to the readme

much appreciated! Let me know any other feedback you have!


chore(deps): update dependency adguardteam/adguardhome to v0.107.53

This PR contains the following updates:

Package
Update
Change

AdguardTeam/AdGuardHome
patch
v0.107.52 -> v0.107.53

Release Notes

AdguardTeam/AdGuardHome (AdguardTeam/AdGuardHome)
v0.107.53
Compare Source
See also the v0.107.53 GitHub milestone.
Security

Previous versions of AdGuard Home allowed users to add any system file it had
access to as filters, exposing them to be world-readable.  To prevent this,
AdGuard Home now allows adding filtering-rule list files only from files
matching the patterns enumerated in the filtering.safe_fs_patterns property
in the configuration file.
We thank @itz-d0dgy for reporting this vulnerability, designated
CVE-2024-36814, to us.

Additionally, AdGuard Home will now try to change the permissions of its files
and directories to more restrictive ones to prevent similar vulnerabilities
as well as limit the access to the configuration.
We thank @go-compile for reporting this vulnerability, designated
CVE-2024-36586, to us.

Go version has been updated to prevent the possibility of exploiting the Go
vulnerabilities fixed in 1.23.2.

Added

Support for 64-bit RISC-V architecture (#5704).
Ecosia search engine is now supported in safe search (#5009).

Changed

Upstream server URL domain names requirements has been relaxed and now follow
the same rules as their domain specifications.

Configuration changes
In this release, the schema version has changed from 28 to 29.

The new array filtering.safe_fs_patterns contains glob patterns for paths of
files that can be added as local filtering-rule lists.  The migration should
add list files that have already been added, as well as the default value,
$DATA_DIR/userfilters/*.

Fixed

Property clients.runtime_sources.dhcp in the configuration file not taking
effect.
Stale Google safe search domains list (#7155).
Bing safe search from Edge sidebar (#7154).
Text overflow on the query log page (#7119).

Known issues

Due to the complexity of the Windows permissions architecture and poor support
from the standard Go library, we have to postpone the proper automated Windows
fix until the next release.
Temporary workaround:  Set the permissions of the AdGuardHome directory
to more restrictive ones manually.  To do that:

Locate the AdGuardHome directory.
Right-click on it and navigate to Properties → Security → Advanced.
(You might need to disable permission inheritance to make them more
restricted.)
Adjust to give the Full control access to only the user which runs
AdGuard Home.  Typically, Administrator.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 63.26%

Totals

Change from base Build<PHONE_NUMBER>4:
0.2%

Covered Lines:
1238

Relevant Lines:
1957

💛  - Coveralls


Replace deprecated package

vierbergenlars/php-semver has been deprecated and can be replaced by composer/semver.
Also add the missing json ext requirement.

@rennokki bump

@rennokki Sorry but I want to bump it again, please take a look when you have time

@rennokki Sorry but I want to bump it again, please take a look when you have time

cc @rennokki pls :)

I don't know how I missed this PR. I have another variant of it here:
https://github.com/renoki-co/php-k8s/pull/380
I can trim off my commit and just keep the other bumps if we favor this one... I can also merge this commit over into mine to consolidate as well.
Great work!

@rennokki Sorry to bother you again, but I'm really hope this PR can be merged, please let me know what you concern, thanks!

It's almost one year later...
Bump again @rennokki


Build fails on OS X Mojave

I can't build on OS X Mojave v10.14.5 due to a missing header file, Availability.h. I get the following error output when running cargo build:
./grpc/include/grpc/impl/codegen/port_platform.h:182:10: fatal error: 'Availability.h' file not found
./grpc/include/grpc/impl/codegen/port_platform.h:182:10: fatal error: 'Availability.h' file not found, err: true
thread 'main' panicked at 'Unable to generate grpc bindings: ()', src/libcore/result.rs:997:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

What can I do to fix this?

You need to install (or update) new XCode libraries (I hit the same problem last week): first check the app store and system settings for any updates and update if necessary, then run xcode-select --install

@nrc Unfortunately, I had already tried both those things and it doesn't help. There are no updates and:
$ xcode-select --install
xcode-select: error: command line tools are already installed, use "Software Update" to install updates

@aknuds1 would you like to verify whether #349 fixes the problem?

@aknuds1 would you like to verify whether #349 fixes the problem?

@BusyJay Yes, this works! Thanks!

It should be fixed.

still getting this error on the last MacOS Catalina


Route a request to a specific docker container?

Hi,
I'm trying to find a way that:

provide only 1 outgoing port
many docker containers connect to that port
a mechanism which can route a request to a specific docker container
(In my application, each container serve one user. When I get a request, I need to load the config of a certain user and start a container)
for all users, they just send requests to the same URL/port

Is my requirement be able to be achieved with Kong?
Any suggestion would be appreciated, thanks.

closing for lack of activity


Wrong behaviour of the compiler in the case with strict null check and optional chaining

TypeScript Version:  3.7.4
Search Terms: optional chaining, strict, strict-type-predicates
Expected behavior: compiler says "Object is possibly 'undefined'".
Actual behavior: compiler thinks that object can't be undefined => possible runtime error "Cannot read property of undefined".
Code
interface SomeObject {
    someProperty: unknown;
}

let lastSomeProperty: unknown | undefined;

function someFunction(someOptionalObject: SomeObject | undefined): void {
    if (someOptionalObject?.someProperty !== lastSomeProperty) {
        console.log(someOptionalObject); // Why compiler thinks that someOptionalObject can't be undefined now?
        console.log(someOptionalObject.someProperty); // Runtime error possible here
        lastSomeProperty = someOptionalObject?.someProperty;
    }
}

const someObject: SomeObject = {
    someProperty: 42
};

someFunction(someObject);
someFunction(undefined);

Output
"use strict";
let lastSomeProperty;
function someFunction(someOptionalObject) {
    var _a, _b;
    if (((_a = someOptionalObject) === null || _a === void 0 ? void 0 : _a.someProperty) !== lastSomeProperty) {
        console.log(someOptionalObject); // Why compiler thinks that someOptionalObject can't be undefined now?
        console.log(someOptionalObject.someProperty); // Runtime error possible here
        lastSomeProperty = (_b = someOptionalObject) === null || _b === void 0 ? void 0 : _b.someProperty;
    }
}
const someObject = {
    someProperty: 42
};
someFunction(someObject);
someFunction(undefined);

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided

The problem is indeed the === when the specs use == which makes statements like opts && opts.thing semantically different to opts?.thing.
It would have made more sense to have (in your case):
lastSomeProperty = (_b = someOptionalObject) === null || _b === undefined || _b === void 0 ? void 0 : _b.someProperty

Or simply:
lastSomeProperty = (_b = someOptionalObject) == null || _b === void 0 ? void 0 : _b.someProperty

Fix at #35895
For inequality tests it was looking for maybe undefined when it should be definitely undefined. The unknown type is maybe undefined, but not definitely.


[EXP-28-228] add support for avalanche

add basic support for avalanche since yearn is contemplating deploying there

add to networks
add price oracles

I can pick this up!


Fix brokerHost argument being ignored

When starting the Pinot broker with the brokerHost argument, this
argument was previously ignored and was not used to build the broker
id. This patch fixes this issue.

Codecov Report

Merging #1538 into master will decrease coverage by 0.06%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
- Coverage   47.96%   47.89%   -0.07%
==========================================
  Files         796      796
  Lines       38775    38779       +4
  Branches     5067     5068       +1
==========================================
- Hits        18598    18575      -23
- Misses      18554    18598      +44
+ Partials     1623     1606      -17

Impacted Files
Coverage Δ

.../pinot/broker/broker/helix/HelixBrokerStarter.java
58.06% <80%> (+0.76%)
:arrow_up:

...e/query/aggregation/groupby/utils/LongToIdMap.java
0% <0%> (-75%)
:arrow_down:

...pinot/controller/validation/ValidationManager.java
50.92% <0%> (-16.67%)
:arrow_down:

...aggregation/groupby/utils/ValueToIdMapFactory.java
44.44% <0%> (-11.12%)
:arrow_down:

.../core/realtime/PinotLLCRealtimeSegmentManager.java
48.9% <0%> (-10.54%)
:arrow_down:

...n/pinot/controller/helix/SegmentStatusChecker.java
52.73% <0%> (-8.22%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
68.88% <0%> (-6.67%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
88.88% <0%> (-6.67%)
:arrow_down:

...nkedin/pinot/common/metrics/ValidationMetrics.java
77.04% <0%> (-4.92%)
:arrow_down:

...not/core/query/pruner/DataSchemaSegmentPruner.java
53.65% <0%> (-4.88%)
:arrow_down:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2635f74...8fcac62. Read the comment docs.


Panics on FFI unused global type

Working on utilising FFI with Raylib and whenever I'm trying to run the code for test purposes it panics with following:
:1:0: [W89] Syntax warning: Unused global of type `Vector2`
     1 ╭─
       ┆  ╭──────
       ┆  ╰─ Unused global of type `Vector2`

:1:0: [W89] Syntax warning: Unused global of type `Image`
     1 ╭─
       ┆  ╭────
       ┆  ╰─ Unused global of type `Image`
thread 171263 panic: reached unreachable code

It seems to be related to global extern structs within FFI call that are not used in the Buzz code.
Full code:
import "std";
import "ffi";

zdef("raylib", `
const Vector2 = extern struct {
    width: f64,
    height: f64,
};

const Image = extern struct {
    width: c_int,
    height: c_int,
    mipmaps: c_int,
    format: c_int,
};

fn GetScreenWidth() c_int;
fn InitWindow(width: c_int, height: c_int, title: [*:0]const u8) void;
fn WindowShouldClose() bool;
fn CloseWindow() void;
fn IsWindowReady() bool;
fn IsWindowFullscreen() bool;
fn IsWindowHidden() bool;
fn IsWindowMinimized() bool;
fn IsWindowMaximized() bool;
fn IsWindowFocused() bool;
fn IsWindowResized() bool;
fn IsWindowState(flag: c_uint) bool;
fn SetWindowState(flag: c_uint) void;
fn ClearWindowState(flag: c_uint) void;
fn ToggleFullscreen() void;
fn MaximizeWindow() void;
fn MinimizeWindow() void;
fn RestoreWindow() void;
fn SetWindowIcon(image: Image) void;
fn SetWindowIcons(images: *Image, count: c_int) void;
fn SetWindowTitle(title: [*:0]const u8) void;
fn SetWindowPosition(x: c_int, y: c_int) void;
fn SetWindowMonitor(monitor: c_int) void;
fn SetWindowMinSize(width: c_int, height: c_int) void;
fn SetWindowSize(width: c_int, height: c_int) void;
fn GetScreenHeight() c_int;
fn GetRenderWidth() c_int;
fn GetRenderHeight() c_int;
fn GetMonitorCount() c_int;
fn GetCurrentMonitor() c_int;
fn GetMonitorPosition(monitor: c_int) Vector2;
fn GetMonitorWidth(monitor: c_int) c_int;
fn GetMonitorHeight(monitor: c_int) c_int;
fn GetMonitorPhysicalWidth(monitor: c_int) c_int;
fn GetMonitorPhysicalHeight(monitor: c_int) c_int;
fn GetMonitorRefreshRate(monitor: c_int) c_int;
fn GetWindowPosition() Vector2;
fn GetWindowScaleDPI() Vector2;
fn GetMonitorName(monitor: c_int) [*:0]const u8;
fn SetClipboardText(text: [*:0]const u8) void;
fn GetClipboardText() [*:0]const u8;
fn EnableEventWaiting() void;
fn DisableEventWaiting() void;
`);

fun main([str] _) > void {
    print("hello world");
}

Removing all instances of Image and Vector2 (including functions) will result in successful printout of "hello world"

Do you still have the issue? I don't on my end.

Can be closed.
Looks like its not related to unused global types, but as discussed on Discord its about passing structs around.


Ability to specify which TimePickerEntryModes to use and hide switch button

Related to #85013
added new two enum dialOnly and inputOnly. when App writer choose this type of TimePickerEnteryMode, showing only that type of dialog and hide switch button. when App writer choose other mode, showing switch button .

@darrenaustin
@HansMuller
Can you please check my latest PR?

@darrenaustin  I resolved all issue and fixed with new structure. please checkout it.

Hi @viralkachhadiya, looks like there is an issue when you merged master.  The easiest way to fix this is to rebase your changes on top of master and then force push to your branch on github:
% git pull --rebase upstream master
% git push --force origin specifying_timepickermode_switchbutton

Hi @viralkachhadiya, looks like there is an issue when you merged master.  The easiest way to fix this is to rebase your changes on top of master and then force push to your branch on github:
% git pull --rebase upstream master
% git push --force origin specifying_timepickermode_switchbutton

i try it but still it has same merge issue.

@darrenaustin I did not know. Why is it happing?
Can you help me please?

@darrenaustin  can you check it?

@PixelToast @Piinks can you please review this pr?

@darrenaustin  I added test in test_picker.dart. please review my PR.

Hi @viralkachhadiya it looks like many tests are failing currently for this PR, can you take a look?

This PR has not been updated in a while, so I am going to close it. If you would like to continue working on this change, please re-open it. Thank you!


⚠ BeyondHD has degraded performance

In 27d004d, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 1529 ms

Resolved: BeyondHD performance has improved in f13a57d.


Space between IMAGEANNOTATIONS and change text size of labels

Is your feature request related to a problem? Please describe
There should be a space between IMAGEANNOTATIONS for cohesive purposes and user should be able to set the text size of the image label to make it more appealing as per the need of the project.

Describe the solution you'd like
We could add a space between IMAGEANNOTATIONS as it doesn't look cohesive, and user should be able to increase or decrease text size of image labels making it more flexible for the user to edit the project.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

cc @Arnabdaz @Prerna-0202

@fillingtothemomo @tanmoysrt is there anyone working on this? If not, can you please assign me this issue

@fillingtothemomo @tanmoysrt is there anyone working on this? If not, can you please assign me this issue

It's waiting for approval

@fillingtothemomo basically you want to add font size to labels ?

@Arnabdaz yes that's pretty much the gist of it

cc @tachyons wdyt ?

ok on further lookup i found a similar issue already #2866


Minifying output HTML files

Has anyone been able to figure out how to minify the HTML files built by the plugin?

Never mind, found out you can use HtmlMinifierWebpackPlugin right after the NunjucksWebpackPlugin.


new bond type 'ProLPBond'

add new bond type 'ProLPBond' that uses bond calculator to determine 'purchased' in dollars. will be applicable to gob/sidx bond and new gob/bch pro bonds.


[SPEC] New chain ID type updates and integration

Overview
We need to pass in the updated chain ID type to the note generator when we create notes for the respective chains. Similarly, we need to parse these notes and process them, provide information for the respective (chain_type, chain_id) pair to the users.
Chain id with type
The updated chain ID is composed of the following:

A chain type that is 2 bytes (u16 / uint16)
A chain ID that is 4 bytes (u32 / uint32)
We concatenate these bytes to create a 6 byte chainIdType and convert this back into a integer value at least as large as a u48::max(). The integer is encoded in big-endian form.

Computation
The corresponding chain ID computation in protocol-substrate that should be used in the webb-dapp is also attached for reference:
pub fn compute_chain_id_type<ChainId>(chain_id: ChainId, chain_type: [u8; 2]) -> u64
where
	ChainId: AtLeast32Bit,
{
	let mut chain_id_value: u32 = chain_id.try_into().unwrap_or_default();
	let mut buf = [0u8; 8];
	buf[2..4].copy_from_slice(&chain_type);
	buf[4..8].copy_from_slice(&chain_id_value.to_be_bytes());
	u64::from_be_bytes(buf)
}

The updated chain type bytes can be seen in the dkg-substrate repo. It is attached below for reference as well since we'll need to add this to the dApp in some form or another:
pub fn to_bytes(&self) -> [u8; 2] {
	let polkadot_str = create_runtime_str!("polkadot");
	let kusama_str = create_runtime_str!("kusama");
	match self {
		ChainIdType::EVM(_) => [1, 0],
		ChainIdType::Substrate(_) => [2, 0],
		ChainIdType::RelayChain(relay, _) =>
			if relay == &polkadot_str {
				[2, 1]
			} else if relay == &kusama_str {
				[2, 2]
			} else {
				panic!("Unknown relay chain id: {:?}", relay);
			},
		ChainIdType::Parachain(relay, _) =>
			if relay == &polkadot_str {
				[2, 128]
			} else if relay == &kusama_str {
				[2, 129]
			} else {
				panic!("Unknown relay chain id: {:?}", relay);
			},
		ChainIdType::CosmosSDK(_) => [3, 0],
		ChainIdType::Solana(_) => [4, 0],
		_ => panic!("Invalid chain id type"),
	}
}

Examples

EVM chain with chain ID 1: [1, 0, 0, 0, 0, 1] ===<PHONE_NUMBER>777
Substrate chain with ID 31337: [2, 0, 0, 0, 122, 105] ===<PHONE_NUMBER>889

@ajtj

Tasks

[ ] Update the EVM computation of chainIdType in web3/webb-bridge-deposit
[ ] Create the Polkadot bridge deposit class with this computation
[ ] Testing


🐛 Bug: The Library and Support icons point to Tritan.gg

On the front page the links point to Tritan.gg

hush


Request on ResNet-101 pretrained model

Hi, would you release the pretrained resnet-101 on Kinetics? Thanks in advance !

Unfortunately, that is not in the pipeline. Soon, I will release a 3D version of this repo. Keep an eye out.

Thanks for your reply


Self assigns itself

BUG REPORT

Please describe the issue you observed:

In org.apache.rocketmq.tools.command.consumer.ConsumerConfigInfo#setBrokerName
Self assigns itself

What did you do (The steps to reproduce)?

What is expected to see?

What did you see instead?

Please tell us about your environment:

Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

The issue is fixed by others so close the issue


Geopandas geographical charts

Solves #5

Important: add geojson dependencies as submodules, correct absolute paths, finish linting.

Also solves #9


[Extractor] Extractor create apiInformation.json with wrong apiVersionSet id

Release version
v1.2.0
Describe the bug
Following #129 , I noticed that the ApiVersionSet id extracted is different than the one used in apiInformation.json:
EXTRACTED:

Version in apiInformation.json:
"apiVersionSetId": "/subscriptions/sub/resourceGroups/rg/providers/Microsoft.ApiManagement/service/apim/apiVersionSets/b4kjb4bvp2apc",
This leads to the publisher failing consecutively due to "ApiVersionSet not found". Once the apiInformation.json is updated with the correct ID, deployments with the publisher work again.
Expected behavior
The ApiVersionSet in apiInformation.json uses the correct ID.
Actual behavior
It is possible that the version set is erroneous.
Reproduction Steps
None known to me.

After running az apim api versionset show, it appears that there are two ApiVersionSet for some of our APIs and that the tool is picking the wrong one in the file apiVersionSet.json

can you please confirm if this behavior persists after upgrading to V2?

All versions sets for all APIs are present in the versionsets folder so I think it is already a good sign.
I test the publisher yet since our test environment for the publisher is decommissioned during off hours but I will try it first thing Monday and report the result.

The apiVersionSet no longer need to be adjusted and the publisher pipeline works right after a clean extraction.


Architecture: Figure out how to get context

Several issues are blocked, because I don't know yet how to get context.
For example, SIM 201 prevents not a==b and suggests a != b. In general, this seems to be a good rule.
As an exception, I want to leave it like this when it's in the context of throwing exceptions:
if not (a == b):
    return ValueError("Expected a==b")

But for this I need to know that the boolean operation not (a ==b) is in the context of an if-statement.

@MartinThoma Here you go. To get context you just need to extend the ASTNodeVisitor: https://stackoverflow.com/questions/43166571/getting-all-the-nodes-from-python-ast-that-correspond-to-a-particular-variable-w

@MartinThoma Or better yet transformers.ParentChildNodeTransformer in astmonkey should work well. One of the AST libraries in the list should prove helpful: https://github.com/gyermolenko/awesome-python-ast

After looking around, I really think astpath should be able to do queries with all the context you realistically need: (check the ReadMe: https://github.com/hchasestevens/astpath)

Thank you!
This week (and probably all the time until Christmas) is super busy for me. I don't think I will have the time to look into it. But feel free to create a PR :-)

https://stackoverflow.com/a/43311383/562769 might be it

https://stackoverflow.com/a/43311383/562769 might be it

It's fixed: https://github.com/MartinThoma/flake8-simplify/commit/e301b8fd21a10a62de78a6b6c2437c10970ed320 - now every node has a parent attribute. It's a bit of a mess to fix the type annotations, but besides that it's fine.

It's fixed: https://github.com/MartinThoma/flake8-simplify/commit/e301b8fd21a10a62de78a6b6c2437c10970ed320 - now every node has a parent attribute. It's a bit of a mess to fix the type annotations, but besides that it's fine.

@MartinThoma Could have also just used typing .cast

@MartinThoma Could have also just used typing .cast

@Skylion007 Where? And cast to what? Feel free to make a PR if you see a simpler solution :-)

@Skylion007 Where? And cast to what? Feel free to make a PR if you see a simpler solution :-)

Ah, nvm you are using dynamic attrs. Yeah, that will only work if you mark parent as an optional value and subclass them all. :/

Ah, nvm you are using dynamic attrs. Yeah, that will only work if you mark parent as an optional value and subclass them all. :/


Ignore Stack Sizes of 1

As mentioned in this discussion post, these are the changes I implemented to ignore stack sizes of one.
I added an attempt at a null check before checking the stack size (Not sure if necessary or enough to catch all possible issues), as well as actual settings and locale for it. Though, at current I only made locale for EN. Setting is off by default.

The null check is fine even if it might not be needed. Since this code all runs in the prototype stage performance isn't a concern so leaving in potential superfluous null checks is fine.


M2 contamination handling not equivalent to M1

@ldgauthier commented on Mon Dec 07 2015
Chip plotted the M1 and M2 calls using number of alternate reads vs. depth*contamination:

It looks like M2 contamination downsampling isn't doing the same thing as M1.  Chip ran these data with Genome Analysis Toolkit (GATK) v3.4-45-g6e00632, Compiled 2015/07/07 19:13:53.
More info from Chip for testing:
The tumor/normal pair with the largest problem of calls below the contamination level (3.7%) was DLBCl-Ls3085:
DLBCL-Ls3085-Tumor
/seq/picard_aggregation/C593/1102503033/v3/1102503033.bam
DLBCL-Ls3085-Normal
/seq/picard_aggregation/C593/1102800748/v3/1102800748.bam
DLBCL-c_D_pair13 was shown as an example with long deletions that showed up in the M2 bams.  The link that Mark prepared
http://iwww.broadinstitute.org/igvdata/humgen/gsa-hpprojects/dev/fleharty/VariantReviewLunch/Nov-12-2015/m2.xml
has the vcf, the combined M2 bam, the M2 bam split into tumor and normal samples, and the original bwa bams.  If we navigate to X:119,059,043-119,059,506, we should see something like this :

panel 1: vcf
panel 2: normal M2 bam
panel 3: tumor M2 bam
panel 4: combined tumor+normal+HC bam
panel 5: bwa tumor bam
panel 6: bwa normal bam
I've turned on color by tag, selecting "HC" for this screenshot (not sure if your IGV comes up that way by default).
The HC tag pattern is that the sample=HC reads all have HC tags and the reads with sample =c_D_pair_13_Dx or sample=RICOVER_134_N do not have HC tags.  Is this consistent with what you find?  Is this consistent with the most recent M2 version?

@vdauwera commented on Mon Nov 14 2016
Moving to GATK4 for @davidbenjamin's to determine its fate.

Hmmm, can't make a snap judgment.  Leaving this for now.

Upon investigation, neither one downsamples correctly.


Update the pausing and unpausing of kickoff

What
With Concourse 5.x series pausing and unpausing of resources has been replaced by pinning and unpinning of resources. This PR reinstates the behaviour we had previously.
How to review
Code review
Deploy in your env and let it pin
unpin later in the day and see you have an env ready in the morning
Who can review
Anyone

Haven't deployed but Code review seems fine


Bump version and update changelog for 0.2.1 release

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   50.72%   50.72%
=======================================
  Files          87       87
  Lines        4197     4197
=======================================
  Hits         2129     2129
  Misses       2068     2068

Impacted Files
Coverage Δ

mlflow/version.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aa9d8...1a66eae. Read the comment docs.


curl -d does not work for node

See sample curl command below to convert to node
curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '18233982904' 'http://<IP_ADDRESS>:8309/CurlToNode'

Seems to be related to the number-only body that is being passed. Appending or prepending it with a letter fixes the parsing. The console gives the error 'request.data.indexOf is not a function'.

I had a similar problem with this trying to upload images to Filestack. Turns out I was missing the "Content-Type": "application/x-www-form-urlencoded" header.
curl -X POST -d url="https://example.com/ponies.png" "https://www.filestackapi.com/api/store/S3?key=MY_API_KEY"

... converted to this:
var dataString = 'url=https://example.com/ponies.png';

var options = {
    url: 'https://www.filestackapi.com/api/store/S3?key=MY_API_KEY',
    method: 'POST',
    body: dataString
};

But it really should be this:
var options = {
    url: 'https://www.filestackapi.com/api/store/S3?key=MY_API_KEY',
    method: 'POST',
    body: dataString
    headers: {
      "Content-Type": "application/x-www-form-urlencoded"
    },
};

I haven't yet dug into the code to see how curlconverter decides on which encoding to use, but that fixed it for me.


Removed docker build to unstable-gateway docker hub

If we need unstable gateway releases we can build it in tools.docker.  We will keep the module around as a convenience for developers who want a docker image from develop-SNAPSHOT


Fix jest test runner

Fix jest test runner on Android and iOS.
Handle no configuration flags in the Jest runner.
Should fix #362 and #363
New up to date demo project for react native which uses jest as a test runner.
To run:
cd examples/demo-react-native-jest
yarn
npm run test-android
npm run test-ios

@rotemmiz One of these tests failed because of an issue with npm, could you manually trigger another build?

@Kureev, this PR just includes the jest test runner fix.
#370 includes the new demo project.

@Kureev , I have updated the commander defaults.

Hi @rotemmiz! I think this one is ready to be merged

I can confirm this is needed for Jest runner to work.

let's do it

Hey @SMJ93, thank you very much for this PR!
Sorry for taking that long to respond, we've been really busy with releasing new features in our core product.
There are two issues I wanted to discuss before we merge it:

I am not sure I understand what is the issue this PR fixes, what happens if Jest receives empty configuration ? [argparse](https://github.com/wix/detox/blob/master/detox/src/utils/argparse.js)  should be able to handle empty keys or no keys, and querying it should be done carefully (if (argparse.getArgValue('key'))). It can return either null, undefined, or empty string, but they should all resolve to false.
Jest integration seems to be catching pretty fast, and I want to make sure it will not get broken easily. If we indeed want to fully support it, let's add another build to our build Matrix that will run the demo projects (including both Mocha and Jest test projects)

@rotemmiz no worries!
Regarding your issues:

Previously, passing through empty configuration to Jest before resulted in strange behaviour; the build failed and verbose was always enabled. It's like it was passing through undefined to Jest?
To fix this we added default values so it would fallback if null, undefined etc. There are probably better ways to do fix this - I will try to find some time to look into argparse, but for the time being this fixes Jest.

Yeah, for us (and probably many others!) it makes sense to use the same test runner for both unit and e2e tests. Yeah that sounds like a better solution! If you have time at some point maybe we could go through the build matrix?

Sorry @SMJ93 , I won't accept a workaround solution. We either need to understand what causes Jest to act weirdly (probably they way argparse is being consumed around argparse.getArgValue('loglevel')).

@SMJ93 , can I use the email in your github account to invite you to our slack group ?

@rotemmiz, I understand what you're saying, but at the moment the Jest test runner is broken on both iOS and Android. This would allow people to use it for the time being while we find a better fix / understand the problem better.
Yeah sure. I'll be on after work.

@rotemmiz what is missing in this PR?

Hey @sibelius , my comment above https://github.com/wix/detox/pull/371#issuecomment-343905754. This PR will probably won't make it into master.
We are actually doing a few changes internally, that will include fixes for this issue, and a few others with Jest, as preliminaries to a bigger task we plan to publish soon, parallelization support for detox tests...

@rotemmiz, is there an ETA for this fix?

A few breaking changes in the configuration, but we believe its a sane and more usable API than what we have today.
https://github.com/wix/detox/pull/423
I'm closing this PR as what it tried to solve was solved in the PR 423.


PPP does not shut-down the link properly

Transferred here from https://discord.com/channels/720317445772017664/733037635194585148/1196453166590476439.
PR https://github.com/zephyrproject-rtos/zephyr/pull/61147 made a change to the PPP driver so that it calls net_if_carrier_off() inside ppp_stop():
static int ppp_stop(const struct device *dev)
{
        struct ppp_driver_context *context = dev->data;

        net_if_carrier_off(context->iface);
        context->modem_init_done = false;
        return 0;
}

Unfortunately, this means the PPP shut-down process cannot work correctly, since fsm.c ppp_send_pkt() checks that the carrier is up in order to send packets, packets which need to be exchanged in order to run through the shut-down process with the PPP peer.
	if (!net_if_is_carrier_ok(iface)) {
		return -ENETDOWN;
	}

So after calling net_if_down() on a PPP link you end up with something like this (noting my debug prints preceded by ###):
13:12:44 ### EVENT 0xd0010001
13:12:44 D: (net_mgmt): [0x20001790] phase RUNNING (4) => TERMINATE (5) (lcp_close():166)
13:12:44 D: (net_mgmt): [LCP/0x200017c8] Current state OPENED (9)
13:12:44 D: (net_mgmt): [IPCP/0x20001898] Current state OPENED (9)
13:12:45 D: (net_mgmt): [IPCP/0x20001898] state OPENED (9) => STARTING (1) (ppp_fsm_lower_down():282)
13:12:45 D: (net_mgmt): [0x20001790] Proto IPv4 (0x0021) down (0)
13:12:45 D: (net_mgmt): [IPCP/0x20001898] Current state STARTING (1)
13:12:45 D: (net_mgmt): [IPCP/0x20001898] state STARTING (1) => INITIAL (0) (ppp_fsm_close():240)
13:12:45 D: (net_mgmt): [PAP/0x20001970] Current state OPENED (9)
13:12:45 D: (net_mgmt): [PAP/0x20001970] state OPENED (9) => STARTING (1) (ppp_fsm_lower_down():282)
13:12:45 D: (net_mgmt): [0x20001790] phase TERMINATE (5) => DEAD (0) (ppp_link_down():136)
13:12:45 D: (net_mgmt): [0x20001790] phase DEAD (0) => ESTABLISH (1) (lcp_down():182)
13:12:45 ### [LCP/0x200017c8] fsm.c, entered ppp_send_pkt()
13:12:45 ### [LCP/0x200017c8] fsm.c, ppp_send_pkt() checks net_if_is_carrier_ok() and it returns false
13:12:45 D: (net_mgmt): [LCP/0x200017c8] state OPENED (9) => CLOSING (4) (terminate():215)
13:12:45 ### EVENT 0xd0010003
...
13:12:54 D: (sysworkq): [LCP/0x200017c8] Current state CLOSING (4)
13:12:54 D: (sysworkq): ### [LCP/0x200017c8]  fsm.c, entered ppp_send_pkt()
13:12:55 D: (sysworkq): ### [LCP/0x200017c8] fsm.c, ppp_send_pkt() checks net_if_is_carrier_ok() and it returns false
13:13:04 D: (sysworkq): [LCP/0x200017c8] Current state CLOSING (4)
13:13:04 D: (sysworkq): [LCP/0x200017c8] state CLOSING (4) => CLOSED (2) (ppp_fsm_timeout():136)
13:13:04 D: (sysworkq): [0x20001790] phase ESTABLISH (1) => DEAD (0) (ppp_link_terminated():123)
13:13:04 D: (sysworkq): [0x20001790] Link terminated

The link just times out and the PPP peer knows nothing about it.
If I comment out the call to net_if_carrier_off() in ppp_stop() then a proper link termination, with the peer, is performed.
To Reproduce

Make a PPP connection to something.
Try to terminate that connection and watch the process happen (e.g. with debug on) so that you can tell the difference between a timed-out termination and a true peer-to-peer termination.

Impact
The PPP peer is left hanging, which mean it won't start up again the next time you try to connect to it unless you've powered cycled or reset it.  In other words, once you have disconnected PPP you can never connect it again.
Version

Zephry 3.4.99 (as arrives with nRFConnect 2.5.0), but headrev Zephyr seems actually worse, in that it now also calls uart_rx_disable() for the asynchronous UART case (which I am using)...!?

@bjarki-trackunit please also take a look if you have time.

I don't believe the net_if_down() or net_if_up() should directly control the carrier, which is what is happening here (ppp_stop is called from net_if_l2(iface)->enable(iface, false) in net_if.c.
Maybe @jhirsi can expand on the issue?

We seem to agree on the issue :) The solution should be to remove net_if_carrier_on() and net_if_carrier_off() calls from the ppp_start() and ppp_stop() functions, since the flag NET_IF_LOWER_UP (set/cleared with net_if_carrier_on/off) is set by default See https://github.com/zephyrproject-rtos/zephyr/blob/9074feabf6f827f6b37a69d77a5e13093799a905/include/zephyr/net/net_if.h#L2832 and https://github.com/zephyrproject-rtos/zephyr/blob/9074feabf6f827f6b37a69d77a5e13093799a905/include/zephyr/net/net_if.h#L2850

That sounds great: while we're here, headrev Zephyr's ppp_stop() also has this line in it:
#if defined(CONFIG_NET_PPP_ASYNC_UART)
	uart_rx_disable(context->dev);
#endif

Since I am using the asynchronous UART interface this would cause the same problem: could it be removed also?

@tomi-font Hi, can you help with this issue? I think you added the call to uart_rx_disable(context->dev); last month, it may be related to this issue :)

@rlubos, @jukkar Please assign a priority to this issue.

@bjarki-trackunit can you take a look at Robert's comment?

@carlescufi I'm working on a solution which makes everyone happy :) Give me a couple of hours ;)

@rlubos
The PR #67731 should explain itself, but I will address your comment here for clarity :)

For me the PPP driver does not seem to be the problem here (if the PPP L2 tells the driver to stop it's operation by calling stop() - what's wrong with disabling underlying UART peripheral?), but rather the fact that PPP L2 disables the driver, while still expecting from it to operate (to perform PPP teardown).

Agreed, when disabling the interface, the L2 PPP will now block until PPP is dead, before calling the stop function, making it safe to disable the UART.

It's probably even more confusing, given the PPP interface management logic is scattered between enable() ...

The management logic still uses both the call to enable() and the net_mgmt callback to manage the L2 PPP instance after #67731 the change here is that calling net_if_down() is now synchronous. We need the net mgmt callback to monitor if the carrier is lost, and when it comes back, to signal the L2 PPP interface (and the upper layers in propagation) that the network is down temporarily.


Clearer Pytorch Examples

It would be nice if the Pytorch examples followed some sort of structure, or were organized better. Normally, you have all the functions, and then the normal code that runs when you call the python file gets encapsulated within if __name__ == '__main__': (but really, there probably shouldn't be any free standing python code..)
It's quite hard to follow, since functions are interlayed with normal python code, and they sort of interweave each other. This makes it extremely hard to see what gets executed where, and I found myself constantly checking the tabs / spacing to see if certain code was inside of a function, or just being executed.
Example file:
https://github.com/awslabs/amazon-sagemaker-examples/blob/master/sagemaker-python-sdk/pytorch_lstm_word_language_model/source/train.py

Thanks for the feedback! Totally understand where you're coming from - we're always reprioritizing our work based on customer feedback, and we'll look into improving the readability of the code when we can. We're also always open to contributions, so if you have any interest in editing the code to make it more readable for yourself and then submitting that in a PR, feel free to do so!

This example is written in that way because it was based on the facebook's example:
https://github.com/pytorch/examples/blob/master/word_language_model/main.py
One purpose of the example was to show how little modification is required to an existing pytorch code to make it work in SageMaker.


"await is a reserved word!"  await can't use in redis.on() callback

redis.on('message',function(channel, message){
await myFunc()
}
SyntaxError:  await is a reserved word
How should I use 'await' in redis.on callback?

works.
thank you!


CI Checks (S)

As a developer I would need an action to check my code so that I know that it follows the correct convention(lint action).

Here is an example action that we can run, we have to change it to on pull requests, we can decide if we are using yarn or npm
name: CI
on: push
jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Install modules
      run: npm
    - name: Run ESLint
      run: eslint . --ext .js,.jsx,.ts,.tsx

We will also need to protect the main branch from pushes

Use airbnb eslint

Set a number of required reviewers (2) - optional

This may be helpful to know
https://stackoverflow.com/questions/58541814/how-to-protect-branch-with-require-pull-request-reviews-before-merging/58542669#58542669


Update antlr and gradle

Codecov Report

Merging #189 (4cfd809) into master (b9a35c0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage     65.66%   65.66%
  Complexity     1294     1294
=========================================
  Files           108      108
  Lines          4788     4788
  Branches        981      981
=========================================
  Hits           3144     3144
  Misses         1333     1333
  Partials        311      311

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for the PR. May I ask why it was necessary to force resolution of antlr?

Was something from testing, I thought it was using an older version for generating the files. There was something weird. I don't think it's needed

I have removed the version enforcement.


fixed loader to handle multiple bins. fixed scene to handle multiple

Fixed the loader to correctly handle multiple bins. Fixed scene loader to correctly handle multiple parts and correct structure transforms.  Added support in shader for alpha discard. Apple tree and Farm now load.

good point. I hadn't actually set out to fix the texturing per-se - I was
more interested in fixing the multi-part loading and structure pieces as
i'm really trying to find a way to load our cad data and try out some PBR
experiments.  But you are right - It needs clearing up to make the images
referenced and re-used.  I'll take a look at that.
On Thu, Aug 17, 2017 at 3:07 PM, Ed Mackey<EMAIL_ADDRESS>wrote:

@emackey commented on this pull request.
In scene.js
https://github.com/KhronosGroup/glTF-WebGL-PBR/pull/47#discussion_r133722925
:

     // draw to the front buffer
     this.frontBuffer.drawImage(this.backBuffer, 0, 0);
 }

loadImage(imageInfo, gl) {

loadImage(imageInfo, gl,mesh) {

Yes, the old method could easily run out of samplers, that's a problem
that I'm glad you're trying to fix. I'm just concerned that the new code
appears to make the assumption that each image is "owned" by only a single
mesh. I'll admit I didn't test it directly yet, it's just the impression I
get from looking at these diffs. It looks like the new code is tying each
image to a single mesh, and that's an even older problem that I had
(cheaply) fixed by going to the current method of one sampler per image. We
do have sample models where multiple meshes use the same image, and even
multiple gltf.texture blocks reference the same gltf.image block with
different sampler settings. The "TextureSettingsTest" is the harshest of
these, and does not yet work in the master branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KhronosGroup/glTF-WebGL-PBR/pull/47#discussion_r133722925,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALQevJCs_FiLlI18QCyZU-pqE7CbeOEwks5sZEkbgaJpZM4O4_hX
.

This PR has gone stale with merge conflicts and unresolved issues, but, please feel free to update and open a new one.  Thanks!


Repeated ChEBI identifiers in datanodes.tsv

I noticed that all ChEBI identifiers are repeated in the datanodes.tsv files, e.g. "chebi:3165;chebi:3165", while there is no problem for other identifiers. It might be good to fix this for consistency.

Fix implemented.

Released: https://github.com/wikipathways/meta-data-action/releases/tag/v1.1.3


React Query Appreciation 🙂

Just wanted to leave a note here saying thanks and great work!
Very well-thought-out API, pleasure to use.
We are using the library in a closed source (sorry) project, so I'll sponsor while my client keeps paying!
Cheers!

Thanks so much! I'm glad to hear it's helping out :)

@bgazzera @tannerlinsley don't mean to hijack your issue but I'm now deciding which async library to use for a large production app with a very complex data model (closed source, but I'm pretty sure I'll be able to get the company to sponsor :) )
react-query is looking better than any other library I've seen! - my only concern is that the data will be fully managed by it, which may make certain things a little bit tricky but should be ok as long as each mutation invalidates/updates all the relevant queries.
@tannerlinsley if required, would it be feasable to store the data in a central store easily?
And final question! If we load for example the current user from and endpoint (receiving username, email... ) and this data is used in several places of the application (assuming that passing it in a prop is not feasable), would you recommend loading it from each component that needs it using useQuery, or should I store it in a centralised store? I guess that's just my main concern really, thanks again!

So react query is essentially a living  store/cache. You shouldn’t need to store anything from it on your own unless it’s in local-ish state for editing and using in a mutation. If you have multiple places using the same query, then just make your own custom hook that wraps useQuery and consume that all over your app. It will dedupe and share a single instance under the hood for multiple instances of the same query.
I hope that answers your question. If not let me know. I wrote this from my phone 🤦♂
Tanner Linsley
On Nov 27, 2019, 9:26 AM -0700, Alejandro U. Alvarez<EMAIL_ADDRESS>wrote:

@bgazzera @tannerlinsley don't mean to hijack your issue but I'm now deciding which async library to use for a large production app with a very complex data model (closed source, but I'm pretty sure I'll be able to get the company to sponsor :) )
react-query is looking better than any other library I've seen! - my only concern is that the data will be fully managed by it, which may make certain things a little bit tricky but should be ok as long as each mutation invalidates/updates all the relevant queries.
@tannerlinsley if required, would it be feasable to store the data in a central store easily?
And final question! If we load for example the current user from and endpoint (receiving username, email... ) and this data is used in several places of the application (assuming that passing it in a prop is not feasable), would you recommend loading it from each component that needs it using useQuery, or should I store it in a centralised store? I guess that's just my main concern really, thanks again!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hey @aurbano our use case in this particular project is a fairly complex data model, where the app is mostly reading from APIs with few local mutations and PUT/POST back to the server.
We have been using it as @tannerlinsley mentioned above.
We have wrapped the useQuery almost every time, to allow for additional features, such as caching the results into localStorage for some calls, or for doing transformations to the data before we deliver it to the actual component, and to abstract/hide useQuery and simplify the way the consumers interact with the data (hiding react-query configuration or not returning the refetch() function if the component doesn't need it)
We haven't yet felt the need to tie the data layer to a state management library, like say, mobx. Our app is handling state using useState and very few useContexts and passing props around, as usual.
Hope this helps!


Bug when GetAuthFromFile

Bug Report
https://github.com/RageAgainstThePixel/OpenAI-DotNet/blob/b7117911e1c99c94ff21709a74c794c05149787b/OpenAI-DotNet/OpenAIAuthentication.cs#L175
It should as below
for (var i = 0; i < parts.Length - 1; i++)

Overview

To Reproduce
Steps to reproduce the behavior:
unittest for
 [Test]
 public void Test_02_GetAuthFromFile()

Expected behavior
get config from .openai
Screenshots

can you please give me an example of the format for your .openai file with sensitive info stripped out please?

https://github.com/AwesomeYuer/OpenAI.Embeddings.pgvector.NET/blob/main/ConsoleApp1/.openai.example

can you please give me an example of the format for your .openai file with sensitive info stripped out please?

https://github.com/AwesomeYuer/OpenAI.Embeddings.pgvector.NET/blob/main/ConsoleApp1/.openai.example

I've fixed it but I do want to emphasize that the env file is deprecated for the new json format.


chore: Remove people

Closes: https://github.com/coopnorge/vale-coop/issues/42

I guess this also closes #40 ?


Expense - Main chat with RBR is not removed after dismissing error from expense report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.15-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4783635
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

Device 1 and 2 are logged in with the same account

Go to staging.new.expensify.com
[Device 1] Go offline
[Device 2] Go to FAB > Split expense > Manual
[Device 2] Split a manual expense with two users
[Device 1] While offline, split the same manual expense with the two same users from Step 4 (Same amount and same users)
[Device 1] Go online
[Device 1] Go to the main chat with RBR.
[Device 1} Dimiss the error.
{Device 1] Note that both the main chat and expense report with RBR are removed after dismissing the error.
[Device 1] Click on the expense report with RBR (from another split participant) from LHN.
[Device 1] Dismiss the error

Expected Result:
Both the main chat and expense report with RBR will be removed after dismissing the error from the expense report
Actual Result:
The main chat with RBR is not removed after dismissing the error from the expense report
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/7ba7e59b-e6ab-4c0c-9caf-f62f91fe0243
View all open jobs on GitHub

@JmillsExpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal
Please re-state the problem that we are trying to solve in this issue.
The main chat isn't removed when clearing the transaction from the expense report.
What is the root cause of that problem?
This was previously solved at https://github.com/Expensify/App/pull/44923. Clearing the error will delete the main chat and all its child reports if the main chat fails to be created.
https://github.com/Expensify/App/blob/ec38b0508184b9ef00c368c7c5f7e583edfb0bef/src/components/ReportActionItem/MoneyRequestView.tsx#L441-L455
However, in https://github.com/Expensify/App/pull/44142, they handle another case where the app will navigate back depending on whether to delete the transaction thread only or also the expense report (IOU.cleanUpMoneyRequest). If the expense report is deleted, then the user will be navigated back to the main chat. This works well to cover the case where the main chat is created. The problem is, that the logic for this takes priority over the logic explained in the first sentence above.
What changes do you think we should make in order to solve the problem?

We should restructure the condition so if the main report/chat fails to be created, then we will perform the delete main report and its child logic, otherwise, use IOU.cleanUpMoneyRequest logic.
if (transaction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) {
    if (chatReport?.reportID && ReportUtils.getAddWorkspaceRoomOrChatReportErrors(chatReport)) {
        Report.navigateToConciergeChatAndDeleteReport(chatReport.reportID, true, true);
        return;
    }
    if (parentReportAction) {
        const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
        Navigation.goBack(urlToNavigateBack);
        return;
    }
}

We won't need this logic anymore too. It was added in https://github.com/Expensify/App/pull/43346 which is now handled by IOU.cleanUpMoneyRequest.
https://github.com/Expensify/App/blob/ec38b0508184b9ef00c368c7c5f7e583edfb0bef/src/components/ReportActionItem/MoneyRequestView.tsx#L452-L454

Added as wave-control polish and opened up for proposal reviews.

If the expense report is deleted, then the user will be navigated back to the main chat.

@bernhardoj, I don’t see how the PR you mentioned is responsible. The code that was added there isn’t navigating back without calling first cleanUpMoneyRequest, which is exactly what you’re proposing. or i am missing something...

Inside the cleanUpMoneyRequest logic (specifically the prepareToCleanUpMoneyRequest function), there is a condition on whether to delete the expense report or not.
https://github.com/Expensify/App/blob/e7fe622ba0a5e9a32047791eb6df6ab38803ad62/src/libs/actions/IOU.ts#L5525-L5526
If the condition is met, then the function will return a route to the chat report.
https://github.com/Expensify/App/blob/e7fe622ba0a5e9a32047791eb6df6ab38803ad62/src/libs/actions/IOU.ts#L5581-L5583

Reviewing

I am not able to reproduce this, no error appears after creating the same splits.

You can follow this step to repro it:

[Device 1] Go offline and submit a money request to a new user
[Device 2] Start a chat with the new user and send a message
[Device 1] Go online

Trying to reproduce this, will update today.

@bernhardoj the chat seems to be removed from LHN for me on latest main
https://github.com/user-attachments/assets/28ddf92c-7c4e-4827-b627-29798cedf91f

Both the main chat and expense report with RBR will be removed after dismissing the error from the expense report

From your video, the main chat isn't removed when you close the expense report error.

From your video, the main chat isn't removed when you close the expense report error.

Are you referring to the tab on the left side?

No, the report screen itself.

Hmmm i see, so why do we want to remove the main chat that was created successfully with a message from another device? I think removing the expense report is enough.
What do you think @JmillsExpensify?

so why do we want to remove the main chat that was created successfully

The report creation is failed.

The report creation is failed.

It was successfully created from the other device.

It's not. It's 2 different reports. 1 failed report from user A, 1 success report from user B. That's why the error says there is an existing report.

It's not. It's 2 different reports. 1 failed report from device 1, 1 success report from device 2. That's why the error says there is an existing report.

I think the failed report get removed when we dismiss the error from the failed report. I think i get it now looks like we need to remove the failed chat when we dismiss the error from the expense. right? Wouldn't that also remove the successfully created chat?

It won't since the reportIDs are different. You can see how it works before in https://github.com/Expensify/App/pull/44923

@bernhardoj's proposal looks good to me
🎀 👀 🎀 C+ Reviewed

Hmm, now I can't trigger the error anymore using this steps. Looks like the BE handle it when there is already an existing chat and merge the actions.
@getusha can you test to verify it too?

Wait, I got an idea to trigger the error, but I need to test it first.

PR is ready
cc: @getusha

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

@getusha Bump on the review here!

Requested in ND.

Payment summary above is correct.

@getusha do you mind filling out the BZ checklist before submitting via NewDot?

Confirming the payment summary is correct.

$250 approved for @bernhardoj

@getusha closing this one out, though don't forget to complete the checklist and we can approve payment in NewDot.

$250 approved for @getusha


Typos

Limitations paragraph
first bullet point.
"Basic availabililty groups" should be "Basic Availability Groups"
last bullet point
"can not" should be "cannot"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32bb0e7a-a91c-6ccd-bf16-5118801d5612
Version Independent ID: 84eb1614-0e30-e116-9dd2-34a3db7c6b5d
Content: Basic availability groups for a single database - SQL Server Always On
Content Source: docs/database-engine/availability-groups/windows/basic-availability-groups-always-on-availability-groups.md
Product: sql
Technology: high-availability
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@fatherjack -- thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.

Hi @fatherjack, thank you for your feedback! Just so you know, you have the ability to modify the documentation yourself :) This will add you as a public contributor to our documentation!
In case you're interested, here are the steps:

Navigate to the page of interest
Select the "Edit" button at the top right of the page
Select the "Pencil" icon on the right
Modify the text within the text box in markdown format - more info: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
Name your file change and provide a description, if necessary
Select "Propose file change"
Select "Create pull request" on the 'Comparing changes' page
Select "Create pull request" on the 'Open a pull request' page

You can find more information about that here: https://aka.ms/editsqldocs
However, we're happy to make the changes on your behalf as well! Just passing this along as an FYI.
Thanks!
Masha from the SQL Docs team