Enable generating/providing completions

This is a sister issue to https://github.com/coder/coder/issues/13502. Working with a plethora of CLIs is so much easier when the next completion is at your fingertips. Manually writing completions is a hassle and as a CLI framework serpent should imho aid in creating completions programatically

began working on this here: https://github.com/coder/serpent/pull/7


Truncate symbols that are too long

This fixes symbols longer than kMaxNameLen being copied in their entirety and overwriting other memory instead of being truncated.

Looks good. Thanks!


RC6 AOT

Hello,
I am getting the following error with Angular2 RC6 using AOT compiler. (Error: Unexpected value 'MaterializeDirective' declared by the module 'AppModule'). My App Module looks like this.
import {MaterializeDirective} from "angular2-materialize";
declarations
materializeDirective
Should I be using the Module import instead? I tried it and got errors. Was curious because I do not see this import referenced in the documentation.

I'm experiencing the same, using Angular 2.0.1.  What was the solution?

CC @bitbeter @ https://github.com/InfomediaLtd/angular2-materialize/issues/121


Oxford RobotCar dataset

Hello, I really appreciate the work you have done, but I have problems downloading the Oxford RobotCar dataset. Can you provide the Oxford RobotCar dataset you used in your paper? Thank you so much！

Hi, Thanks for your interest! We provide a version of the dataset here: https://github.com/AnyLoc/AnyLoc#included-datasets

Thanks for your help, I have successfully downloaded the dataset. Another question, is the oxdatapart_seg.npz the one mentioned in your paper 'For the Semantic Consistency baseline, we generate semantic segmentation masks for all reference and query images based on the Cityscapes scheme' ?


Lacking of release tags

When looking if a change has made into a release, the tags are an important tool to identify it.
Please consider starting to tag the releases accordingly.

That's happening now!
[mulhern@localhost failure]$ git tag
0.1.3


[stable/rabbitmq-ha] Clustering fixes

Use hostnames instead of IPs for node names since IPs are ephemeral
Always use a headless clusterIP service for clustering
Never use a cached erlang cookie since we are always providing it

Fixes #3914
Primarily this switches from using the pod IP to using the hostname for the rabbit node name. The pod IP doesn't work with persistence because new pods get new IPs which then can't access the existing data because the node name has changed.
As a part of that change, I realized that we need to have a headless ClusterIP for StatefulSet DNS stuff to work correctly, but we allow changing the service type to LoadBalancer etc.  To ensure DNS stuff always works correctly, I created a new service that is always headless ClusterIP to use for clustering DNS requirements.
Finally, after rolling things a few times during testing, I got into the state where /var/lib/rabbitmq/.erlang.cookie was set to something other than the current RABBITMQ_ERLANG_COOKIE. Since we shouldn't ever need to keep this cached cookie around, I added a snippet to the init container to remove that file if it exists.
Here's what things look like after the changes:
bash-4.4# rabbitmqctl cluster_status
Cluster status of node<EMAIL_ADDRESS>...
[{nodes,
     [{disc,
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> {running_nodes,
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS> {cluster_name,
<EMAIL_ADDRESS> {partitions,[]},
 {alarms,
<EMAIL_ADDRESS>          []},
<EMAIL_ADDRESS>          []},
<EMAIL_ADDRESS>          []}]}]

bash-4.4# ls -lah /var/lib/rabbitmq/mnesia/
total 32
drwxr-xr-x    6 rabbitmq rabbitmq    4.0K Apr  2 15:26 .
drwxr-xr-x    6 rabbitmq root        4.0K Apr  2 15:26 ..
drwxr-xr-x    3 rabbitmq rabbitmq    4.0K Apr  2 15:26<EMAIL_ADDRESS>drwxr-xr-x   18 rabbitmq rabbitmq    4.0K Apr  2 15:26<EMAIL_ADDRESS>-rw-r--r--    1 rabbitmq rabbitmq       2 Apr  2 15:26<EMAIL_ADDRESS>drwxr-xr-x    3 rabbitmq rabbitmq    4.0K Apr  2 14:51<EMAIL_ADDRESS>drwxr-xr-x   18 rabbitmq rabbitmq    4.0K Apr  2 14:51<EMAIL_ADDRESS>-rw-r--r--    1 rabbitmq rabbitmq       2 Apr  2 14:51<EMAIL_ADDRESS>

Although I think this looks fine, I wonder if we should prefer the solution from #4591, as that seems the cleaner solution. Or is there a good reason to do it like this instead?

😮 So, philosophically speaking, if rabbitmq adds support for clustering, why do we need rabbitmq-ha as a separate chart?
Practically speaking, the solution being proposed there looks a lot like the way rabbitmq-ha is currently doing things with IP-based node names which doesn't work with persistence.

Totally agree with you there. If we can have a single rabbitmq Chart that support a single replica and can also scale up automagically, we should do that.

/ok-to-test

/lgtm

cc @etiennetremel

/lgtm

@coreypobrien We had a lot of issues with the rabbitmq chart and broken mnesia databases due to the use of names instead of IPs. It felt like due to the pod using IPs it was recovering a lot better because it would just fail over and rebuild the mirror.
Given we don't have a lot of operational experience with RabbitMQ, the issue may be somewhere else.

@estahn main problem with IP names it doesn't work with persistent storage, but without persistent storage it is not reliable since you can lose all queued data, because it can't rejoin cluster on ip change (supposed)

@maksimru We're not using persistent storage. We have 5 pods across nodes with a policy ha-mode: exactly, ha-params: 3.
IMO we will need to lose >3 pods to lose data. Please correct me if I'm wrong.
Also, we favour availability and are fine with a possible message loss.
How are you dealing with broken mnesia databases? Is that not happening for you at all?

Lose together 3 or even 5 pods is not so hard, for example, if all pods are on same node you can overload it and node will get down with all pods, other reasons are network failure, cloud provider issues etc.
I never had problems with broken mnesia database so far.
Btw i tested solution from @coreypobrien and it still not reliable, simple kubectl delete pod rabbitmq-0 make rabbit-0 hung on CrashLoopBackOff, it is unable to reconnect to the cluster (inconsistent_cluster), most likely because it is already removed from other nodes but still thinks it is clustered

@maksimru Yes, clearly but the pods have an anti-affinity rule so the pods are all on different nodes.
It's working fine for us without persistent volumes and just IP addresses. We can just delete pods and they rejoin the cluster.

@maksimru I just tried the latest 1.3.0 version and it recovered fine after running kubectl delete pod saucy-penguin-rabbitmq-ha-0

@estahn @coreypobrien I just tried this as well, but deleting a pod takes it in a crashloop forever due to BOOT FAILED, with this log:
2018-04-09 09:15:15.618 [debug] <0.97.0> Lager installed handler lager_forwarder_backend into error_logger_lager_event
2018-04-09 09:15:15.618 [debug] <0.100.0> Lager installed handler lager_forwarder_backend into rabbit_log_lager_event
2018-04-09 09:15:15.613 [debug] <0.94.0> Lager installed handler error_logger_lager_h into error_logger
2018-04-09 09:15:15.618 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,error_logger_lager_event}) at pid <0.96.0>
2018-04-09 09:15:15.618 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_lager_event}) at pid <0.99.0>
2018-04-09 09:15:15.618 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_channel_lager_event}) at pid <0.102.0>
2018-04-09 09:15:15.623 [debug] <0.103.0> Lager installed handler lager_forwarder_backend into rabbit_log_channel_lager_event
2018-04-09 09:15:15.623 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_connection_lager_event}) at pid <0.105.0>
2018-04-09 09:15:15.623 [debug] <0.106.0> Lager installed handler lager_forwarder_backend into rabbit_log_connection_lager_event
2018-04-09 09:15:15.623 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_mirroring_lager_event}) at pid <0.108.0>
2018-04-09 09:15:15.624 [debug] <0.109.0> Lager installed handler lager_forwarder_backend into rabbit_log_mirroring_lager_event
2018-04-09 09:15:15.624 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_queue_lager_event}) at pid <0.111.0>
2018-04-09 09:15:15.624 [debug] <0.112.0> Lager installed handler lager_forwarder_backend into rabbit_log_queue_lager_event
2018-04-09 09:15:15.624 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_federation_lager_event}) at pid <0.114.0>
2018-04-09 09:15:15.624 [debug] <0.115.0> Lager installed handler lager_forwarder_backend into rabbit_log_federation_lager_event
2018-04-09 09:15:15.625 [debug] <0.86.0> Supervisor lager_sup started gen_event:start_link({local,rabbit_log_upgrade_lager_event}) at pid <0.117.0>
2018-04-09 09:15:15.625 [debug] <0.118.0> Lager installed handler lager_forwarder_backend into rabbit_log_upgrade_lager_event
2018-04-09 09:15:15.638 [debug] <0.81.0> Supervisor gr_param_sup started gr_param:start_link(gr_lager_default_tracer_params) at pid <0.120.0>
2018-04-09 09:15:15.642 [debug] <0.80.0> Supervisor gr_counter_sup started gr_counter:start_link(gr_lager_default_tracer_counters) at pid <0.121.0>
2018-04-09 09:15:15.647 [debug] <0.82.0> Supervisor gr_manager_sup started gr_manager:start_link(gr_lager_default_tracer_params_mgr, gr_lager_default_tracer_params, []) at pid <0.122.0>
2018-04-09 09:15:15.647 [debug] <0.82.0> Supervisor gr_manager_sup started gr_manager:start_link(gr_lager_default_tracer_counters_mgr, gr_lager_default_tracer_counters, [{input,0},{filter,0},{output,0},{job_input,0},{job_run,0},{job_time,0},{job_error,0}]) at pid <0.123.0>
2018-04-09 09:15:15.948 [info] <0.33.0> Application lager started on node<EMAIL_ADDRESS>2018-04-09 09:15:16.084 [debug] <0.90.0> Lager installed handler lager_backend_throttle into lager_event
2018-04-09 09:15:17.969 [debug] <0.127.0> Supervisor inet_gethost_native_sup started undefined at pid <0.128.0>
2018-04-09 09:15:17.969 [debug] <0.60.0> Supervisor kernel_safe_sup started inet_gethost_native:start_link() at pid <0.127.0>
2018-04-09 09:15:17.979 [debug] <0.136.0> Supervisor mnesia_sup started mnesia_sup:start_event() at pid <0.137.0>
2018-04-09 09:15:17.979 [debug] <0.136.0> Supervisor mnesia_sup started mnesia_ext_sup:start() at pid <0.138.0>
2018-04-09 09:15:17.979 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_monitor:start() at pid <0.140.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_subscr:start() at pid <0.141.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_locker:start() at pid <0.142.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_recover:start() at pid <0.143.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_tm:start() at pid <0.144.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_checkpoint_sup:start() at pid <0.145.0>
2018-04-09 09:15:17.980 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_controller:start() at pid <0.146.0>
2018-04-09 09:15:17.981 [debug] <0.139.0> Supervisor mnesia_kernel_sup started mnesia_late_loader:start() at pid <0.147.0>
2018-04-09 09:15:17.981 [debug] <0.136.0> Supervisor mnesia_sup started mnesia_kernel_sup:start() at pid <0.139.0>
2018-04-09 09:15:17.981 [info] <0.33.0> Application mnesia started on node<EMAIL_ADDRESS>2018-04-09 09:15:17.983 [info] <0.33.0> Application mnesia exited with reason: stopped

BOOT FAILED
===========

Error description:
    init:do_boot/3
    init:start_em/1
    rabbit:start_it/1 line 444
    rabbit:'-boot/0-fun-0-'/0 line 300
    rabbit_mnesia:check_cluster_consistency/0 line 663
throw:{error,{inconsistent_cluster,"Node<EMAIL_ADDRESS>thinks it's clustered with node<EMAIL_ADDRESS>but<EMAIL_ADDRESS>disagrees"}}
Log file(s) (may contain more information):
   <stdout>

2018-04-09 09:15:17.984 [error] <0.5.0>
Error description:
    init:do_boot/3
    init:start_em/1
    rabbit:start_it/1 line 444
    rabbit:'-boot/0-fun-0-'/0 line 300
    rabbit_mnesia:check_cluster_consistency/0 line 663
throw:{error,{inconsistent_cluster,"Node<EMAIL_ADDRESS>thinks it's clustered with node<EMAIL_ADDRESS>but<EMAIL_ADDRESS>disagrees"}}
Log file(s) (may contain more information):
   <stdout>
{"init terminating in do_boot",{error,{inconsistent_cluster,"Node<EMAIL_ADDRESS>thinks it's clustered with node<EMAIL_ADDRESS>but<EMAIL_ADDRESS>disagrees"}}}

Any ideas how to deal with this? (other than deleting the rabbitmq-1 data, of course)

@estahn did you try with persistent storage?

The ideal is to have persistent storage ("if all of my pods stop simultaneously, I don't lose any data") high availability ("I can lose N pods and still be online"), and failure recovery ("if I lose a pod, kubernetes heals my cluster automatically"). This PR strictly handles the persistent storage story. With IP-based names, you cannot lose all of your nodes and still have persistent data because new pods come up without access to the persisted data in mnesia. The high availability story is pretty solid I think (i.e losing 1 pod isn't a problem). The inconsistent_cluster errors is part of the failure recovery story and is well reported regardless of the persistent storage story in issues #4474, #4519, #4685. I'd suggest we focus on the inconsistent_cluster issue in (preferably one of) those issues.

@coreypobrien what is supposed to make this form as one cluster instead of three?
The OLD style chart before this merge had issues (crashed node could not rejoin).. but all 3 nodes correctly joined the same cluster.
After this change, starting 3 nodes forms 3 clusters of size 1.
My clusters are called

Cluster<EMAIL_ADDRESS>Cluster<EMAIL_ADDRESS>Cluster<EMAIL_ADDRESS>

I have a slightly hacked configmap so its possible it was a hacking mistake.. but past that not sure how to dig deeper?

2018-05-04 21:23:56.765 [info] <0.33.0> Application rabbit started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.765 [info] <0.33.0> Application rabbitmq_amqp1_0 started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.765 [info] <0.5671.0> Peer discovery: enabling node cleanup (will remove nodes not known to the discovery backend). Check interval: 10 seconds.
2018-05-04 21:23:56.766 [info] <0.33.0> Application rabbitmq_peer_discovery_common started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.766 [info] <0.33.0> Application rabbitmq_shovel started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.767 [info] <0.33.0> Application rabbitmq_federation started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.767 [info] <0.33.0> Application rabbitmq_consistent_hash_exchange started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.767 [info] <0.33.0> Application rabbitmq_peer_discovery_k8s started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.770 [info] <0.33.0> Application rabbitmq_management_agent started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.770 [info] <0.33.0> Application cowboy started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.770 [info] <0.33.0> Application rabbitmq_web_dispatch started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.813 [info] <0.5738.0> Management plugin started. Port: 15672
2018-05-04 21:23:56.813 [info] <0.5844.0> Statistics database started.
2018-05-04 21:23:56.813 [info] <0.33.0> Application rabbitmq_management started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.813 [info] <0.33.0> Application rabbitmq_federation_management started on node<EMAIL_ADDRESS>2018-05-04 21:23:56.813 [info] <0.33.0> Application rabbitmq_shovel_management started on node<EMAIL_ADDRESS> completed with 11 plugins.
2018-05-04 21:23:57.099 [info] <0.5.0> Server startup complete; 11 plugins started.
 * rabbitmq_shovel_management
 * rabbitmq_federation_management
 * rabbitmq_management
 * rabbitmq_web_dispatch
 * rabbitmq_management_agent
 * rabbitmq_peer_discovery_k8s
 * rabbitmq_consistent_hash_exchange
 * rabbitmq_federation
 * rabbitmq_shovel
 * rabbitmq_peer_discovery_common
 * rabbitmq_amqp1_0

@coreypobrien
Can I ask about the "Never use a cached erlang cookie since we are always providing it" bit?
Why was it necessary?
and
Is the RabbitMQ app recreating that file upon start, taking the value from the environment variable?
I'm asking because even if I'm passing the Erlang Cookie in the values.yaml file I've had a problem where one of the three nodes of my Cluster had a different Erlang Cookie (in that file /var/lib/rabbitmq/.erlang.cookie) after I deleted the pod and it was recreated.
I deleted the pods one by one because I had changed the rabbitmqMemoryHighWatermark in the values.yaml file, then run a helm upgrade, and I wanted the nodes to start up with the new value.
All three nodes had, and still have, the /var/lib/rabbitmq/.erlang.cookie file present, but one was different and after deleting that pod I had lots of messages in the logs like the one below, and the node could not rejoin the cluster:
2018-05-22 12:58:26.181 [error] <0.373.0> ** Connection attempt from disallowed node<EMAIL_ADDRESS>**

I had to manually write the correct Cookie in the /var/lib/rabbitmq/.erlang.cookie file then the node came back up, only to get a message like:
2018-05-22 14:55:01.563 [warning] <0.4551.0> Message store ".../msg_store_persistent": rebuilding indices from scratch

which because the queue was huge never manages to finish and the pod reboots itself.
This are only test queues and messages, so no big problem there, but with my luck, that pod was the one where the queue with the biggest number of messages was (47M out of the 53M).
I just don't understand why the Cookie was different for some reason, and where that one came from.
I'm using an efs-provisioner for the storage class. Not sure if that's relevant as I never had any problems with it before.
Maybe I was simply wrong to delete the pods one by one after updating the Chart Values?
Understanding better how the cached cookie file works would be very useful, and if you have any idea of what might have happened as well.
Sorry for the long message.
F

Why was it necessary?
Is the RabbitMQ app recreating that file upon start, taking the value from the environment variable?
Since the chart is providing the cookie with rabbitmqErlangCookie which gets mapped into the environment variable that the image puts into the cookie the chart is always the source of truth for the cookie.

The specific case you're running into is probably due to what we should probably consider a bug in this chart due to upstream helm annoying behavior. This chart sets the cookie to a random value if you don't specify it. That random value gets updated every time helm is run so every upgrade will change the cookie. Since that leave old pods with the old cookie and new pods with the new cookie, you get the behavior you're seeing. The easy fix is to just specify the cookie in you helm values.


Toolkit is broken, maybe my Java Version..

I load up the toolkit with Java SDK 17.0.1, load my bigfart11 (LBP1 Profile) I try and edit a level slot and it shows a blank window. Same thing with exiting! Title is 'Pending Changes' with a blank window. It is probably my Java version but I don't know.

The Darcula theme doesn't play nicely with any version of Java greater than 11.

So I just use a version under 11 like Java 8? Right?

Ok I got it working now with Java 8! Thank you.


"open_at" in "businesses search" query returns then closed businesses.

Set open_at =<PHONE_NUMBER>(10/01/2016 1:00am PDT) returned "Morty's Delicatessen", but it should be closed at that time.

Yep, that's broken.  Dup of the current state of #42 .


Windows dependency on Microsoft Visual C++ Redistributable

Hi @LucaScheller
In a previous issue I told you about the CachedResolver crashing Houdini with a segmentation fault. I resolved the issue by re-installing the MS Visual C++ redistributable. I had the same issue again today. I suspect installing an old version of Thinkbox Deadline corrupted the installation, but I'm not certain that this is the cause.
My (noob) question is, could the CachedResolver be compiled for Windows in such a way to avoid this kind of dependency ? We are slowly starting to use it in production and I'm afraid this issue will happen more often as it will be used on more workstations at our studio.
Regards

Hi,
I already successfully compiled it following the .bat instructions. I will ask around me if there's any way to get rid of that dependency.
Thanks

I did some more research, according to stackoverflow (and chatgpt) statically linking from dynamically linked files (as that is what Houdini ships with), is not straight forward.
Could you share the error again that you are getting? I wonder what specifically is calling into standard clibs that is making it crash.
What happens when you run:
from pxr import Ar
from usdAssetResolver import CachedResolver

I have not yet managed to reproduce the crash, but here is the log of the crash from a few days ago, when I reported this issue :
Crash report from 800ccaaf; Houdini FX Version 20.5.332 [windows-x86_64-cl19.35]
Uptime 141 seconds
Tue Nov  5 09:23:38 2024
Caught signal 11

Traceback from 16536 ThreadId=0x00004274
CURRENT THREAD 17012
+0x7ff8af792f58 [Thrd_yield] C:\WINDOWS\SYSTEM32\MSVCP140.dll
+0x7ff8000e85f1 [CachedResolverContext::ResolveAndCachePair] \\VSERVER01\shotgun\donatdev2024\install\git\tk-framework-nozonusd.git\v0.1.2\VFX-UsdAssetResolver\CachedResolver_v0.7.3_houdini_20.5.332.py310\lib\cachedResolver.dll
+0x7ff8000e6676 [pxrInternal_v0_24__pxrReserved__::CachedResolver::_Resolve] \\VSERVER01\shotgun\donatdev2024\install\git\tk-framework-nozonusd.git\v0.1.2\VFX-UsdAssetResolver\CachedResolver_v0.7.3_houdini_20.5.332.py310\lib\cachedResolver.dll
+0x7ff89ba904d8 [pxrInternal_v0_24__pxrReserved__::ArResolver::~ArResolver] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_ar.dll
+0x7ff89ba8e0fe [pxrInternal_v0_24__pxrReserved__::ArSplitPackageRelativePathOuter] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_ar.dll
+0x7ff89ba98621 [pxrInternal_v0_24__pxrReserved__::ArResolver::_IsRepositoryPath] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_ar.dll
+0x7ff89ba91c7f [pxrInternal_v0_24__pxrReserved__::ArResolver::Resolve] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_ar.dll
+0x7ff80e40b188 [pxrInternal_v0_24__pxrReserved__::Sdf_ValueTypeNamesType::~Sdf_ValueTypeNamesType] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_sdf.dll
+0x7ff80e55df98 [pxrInternal_v0_24__pxrReserved__::SdfLayer::WriteDataFile] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_sdf.dll
+0x7ff80e551fc1 [pxrInternal_v0_24__pxrReserved__::SdfLayer::FindOrOpen] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_sdf.dll
+0x7ff879c150b4 [pxrInternal_v0_24__pxrReserved__::operator<<] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_pcp.dll
+0x7ff879c1ba91 [pxrInternal_v0_24__pxrReserved__::PcpIsTimeScalingForLayerTimeCodesPerSecondDisabled] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\libpxr_pcp.dll
+0x2d2ec273 [tbb::interface7::internal::task_arena_base::internal_max_concurrency] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x2d2eaf13 [tbb::interface7::internal::task_arena_base::internal_max_concurrency] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x2d2e51a4 [tbb::task_scheduler_init::default_num_threads] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x2d2e476e [tbb::task_scheduler_init::default_num_threads] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x2d2df7b8 [tbb::internal::thread_sleep_v3] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x2d2df73b [tbb::internal::thread_sleep_v3] C:\Program Files\Side Effects Software\Houdini 20.5.332\bin\tbb.dll
+0x7ff8b5a51bb2 [configthreadlocale] C:\WINDOWS\System32\ucrtbase.dll
+0x7ff8b6227374 [BaseThreadInitThunk] C:\WINDOWS\System32\KERNEL32.DLL
+0x7ff8b823cc91 [RtlUserThreadStart] C:\WINDOWS\SYSTEM32\ntdll.dll

I uninstalled every MS Visual C++ redistributable I had on my pc, rebooted and the CachedResolver is still working (Houdini doesn't crash). So I'm a bit puzzled.
Anyway I was raising this issue in case it would be 'trivial' to remove such dependency. But as you say this isn't, then let it be. Lots of other programs are installing those redistributables anyway
Cheers


Make xDS request timeout configurable

Async Client uses NullRetryPolicy and the API fetcher hardcodes the upstream request timeout to 1s. This is too low in some environments, and it would be nice to make this configurable.
(https://github.com/envoyproxy/envoy/blob/master/source/common/http/rest_api_fetcher.cc#L56)

please assign this to me

Is there any progress on this? @rshriram


Bug Report in utils/eval_helper.py

There is a bug detected in the utils/eval_helper.py file in the line 15. The problematic line is:
data_size = len(loader.dataset.indices)
This raises an error while .indices is a function.
In order to fix this issue, the line should be updated as following:
data_size = len(loader.dataset.indices())

Fixed. Thanks!


Pass command line arguments to commands' execute

We should pass parses command line arguments to commands' executor since
the command may want to use it. For example, the Serve command has to
know about conf path because it's watching for conf and re-build entire
blog if changes were detected.
Fixed #75

Coverage decreased (-0.16%) to 69.68% when pulling b54161478fa3683f8044ac8ccc906bb782ba0ae6 on pass-arguments-to-commands into 6625ec5b4fd74e6fb75ac14543b6f75e81d26734 on master.


[WFCORE-904] Signal the future when boot fails

Core - Full Integration - Windows Build 14 is now running using a merge of 559f7f9948e9d039da271d286e65b1c4a5dded9d

Linux Build 2466 is now running using a merge of 559f7f9948e9d039da271d286e65b1c4a5dded9d

Linux Build 2466 outcome was SUCCESS using a merge of 559f7f9948e9d039da271d286e65b1c4a5dded9d
Summary: Tests passed: 3402, ignored: 64 Build time: 00:41:13

Core - Full Integration - Windows Build 14 outcome was SUCCESS using a merge of 559f7f9948e9d039da271d286e65b1c4a5dded9d
Summary: Tests passed: 3055, ignored: 358 Build time: 00:59:19

WildFly pull requests Build 1888 outcome was SUCCESS using a merge of 559f7f9948e9d039da271d286e65b1c4a5dded9d
Summary: Running Build time: 00:00:02

@bstansberry I am closing this since I believe it is superseded by https://github.com/wildfly/wildfly-core/pull/991


[BUG] Removing videos causes issues when switching playlists

Steps to reproduce:

Remove videos from a playlist
Switch to another playlist that contains videos

Expected results:
The videos to display normally.
Actual results:
The video containers hidden in the original playlist remain hidden in the next playlist. For example, if 3 videos are removed from "Watch later" and the user clicks on another playlist, there will be 3 hidden videos in this playlist.
Notes:
Perhaps the best solution is just to remove the dynamic hiding of watched videos.

:tada: This issue has been resolved in version 1.5.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add a note regarding setting size limit on shared caches

The docs references a "shared" memory cache in DI early on and this leads to a pitfall when users try to set a size limit on the shared instance later on. When a size limit is imposed on a cache, all entries must specify a size when being added. This can lead to issues since the users may not have full control on what uses the shared cache. For example, EFCore will use the shared cache and does not specify a size, and the application will throw InvalidOperationException if a size limit is imposed on the shared cache. We should add a note early in the documentation so that it's clear we recommend against setting a size limit on a shared memory cache and instead tell users to create a private instance for caches with a size limit.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13f5f8f9-18dd-9c12-9ed1-fcc6b44ba7fd
Version Independent ID: 640b4f36-5886-7b69-1c95-cfc8574a02fd
Content: Cache in-memory in ASP.NET Core
Content Source: aspnetcore/performance/caching/memory.md
Product: aspnet-core
Technology: aspnetcore-performance
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@JunTaoLuo  do you have an issue this came from?

@mmitche and I was looking at a bug he ran into and it turned out to be that a size limit was set on the shared instance breaking other components that used it.

@JunTaoLuo  and @mmitche

The docs references a "shared" memory cache in DI early on

What doc?

Specifically https://github.com/aspnet/AspNetCore.Docs/blame/master/aspnetcore/performance/caching/memory.md#L54


TypeError: Str, bytes or bytearray expected, not NoneType

Great project.
I plan to use it with a script to play customised MP4 videos to visitors when they open the door with their access card.
I am using catt on Win10pro x64, using catt v0.10.0 and python3.7.4.
The Chromecast device is Gen2, located on a separate VLAN
I connect to it directly over IP (no proxy) and it opens connections on TCP8008 and TCP8009
I can use catt to stream utube video without any issue.
However when I tried MP4 files it fails. See output in attached error.txt file
error.txt
I initially thought I was using the wrong syntax to launch the program but https://www.computerhope.com/issues/ch001980.htm seems to use the same syntax without issue, albeit to a local chromecast.
I am not a coder but the error suggests it is expecting a value that is not there.
So I began to suspect there was corruption in the file itself which was MOV format converted by VLC to MP4. So I tried a sample from "https://file-examples.com/index.php/sample-video-files/sample-mp4-files" and got the same error.
Finally I downloaded the file of the utube video that I knew I could stream OK. But alas the same error.
Can you suggest how to resolve the issue. Thx

That's odd, it looks like the local server address is None when it tries to save the file. Is there any restriction on your machine that makes catt unable to open the port? Can you add a print(address) on c:\users\username\appdata\local\programs\python\python37-32\lib\site-packages\catt\http_server.py:109?

I'm getting a feeling this is the culprit:
https://github.com/skorokithakis/catt/blob/master/catt/util.py#L62

That seems very plausible. We should add a raise ValueError("No adapters found") at the end there or something similar, instead of returning None.

I'm not sure why we can find no adapters, though.

We're not looking for adapters. Ever since we dropped using netifaces for this purpose (because zeroconf switched to ifaddr), we are guessing the local ip from the cc ip. As far as I can tell, the logic in get_local_ip doesn't suffice in this usecase, because the box running catt and the cc are on different subnets.

@skorokithakis Any ideas for an alternative implementation? Having looked through the suggestions from this SO answer, I couldn't find anything that looked ideal for catt.

I tested CATT with the chromecast connected to the same subnet and it can play the mp4 file OK. Is it peculiar how CATT casts youtube content OK to different subnet but not when the source is local file.

@drareve

Is it peculiar how CATT casts youtube content OK

In that case the chromecast would be streaming directly from googles servers and not from your box, and so this problem doesn't come into play.

@drareve
Can you try out the local-ip-fix branch? Should fix this problem.
pip install -U https://github.com/skorokithakis/catt/archive/local-ip-fix.zip

Thank you. It was successful. Applied the local-ip-fix on PC and ran catt from a different subnet to the CAST device. The results appeared to be the same as if it were on a local subnet.
PC makes two connections to CAST on TCP:8008 and TCP:8008
CAST makes one connection to PC on TCP:46841
Is the service TCP:46841 opened on the PC a setting configured in CATT or is the port number selected by the CAST device, and if CAST selected, is it always this fixed value or random? Would be good to know for any firewall configurations.


Set up CI with Azure Pipelines

You can squash the commits in two "Set up YAML file for Azure build" and "Set up CI script".

Also, please add an appropriate description for the PR and sign it.


Added CSV file format import and export support

Additions

Added exporting to csv file format support.
Added importing from csv file support.
Added test cases for importing from csv
Added test cases for exporting to csv

Changes

The find_and_export command now takes an extra optional argument v/ [FILEFORMAT] which accepts either json or csv options to export as a json file or a csv file. If /v is not specified, json file is exported by default. Examples:

find_and_export friend f/contacts  v/json

find_and_export friend f/contacts2  v/csv

find_and_export friend f/contacts3

The import command's f/ argument now requires user to input with [filename].json or [filename].csv files. any other format is unsupported. Example

import f/contacts.json

import f/contacts.csv

Also, do try to add more tests to pass the Codecov CI check.


Configuring Zowe Explorer - info about "Jobs: Confirm Submission" option

Is your request for enhancement related to a problem? Please describe.
A feature will be added to Zowe Explorer that gives the user the option to confirm their submission for the "Submit Job" feature in the Data Sets panel. Since the feature has multiple options, it would be best to document this feature in the Configuring Zowe Explorer section.
See https://github.com/zowe/vscode-extension-for-zowe/pull/2054 for more info.
Describe the solution you'd like
Add some context on this option to the Configuring Zowe Explorer section, as users might want to enable/customize it for their own usage, e.g.:
"For some users, running a job without confirmation can cause a myriad of problems on their server, and hence a confirmation option could be useful before accidental submission w/ Zowe Explorer's 'Submit Jobs' feature. This option will enable a confirmation dialog that appears when using the "Submit Job" functionality. By clicking 'Submit', the user confirms that the use of this feature was intentional, avoiding the potential harm in an accidental misclick of Submit Jobs."
Options:

Disabled: No confirmation dialogs will appear when submitting a job.
All jobs: A confirmation dialog will appear before submitting any job.

Other user jobs: A confirmation dialog only appears before submitting another user's job.

Related doc pages
https://docs.zowe.org/stable/user-guide/ze-install#configuring-zowe-explorer
Additional context
Here's what the option looks like from extension settings:

The dialog that appears when the above option is selected:

@anaxceron

Closing with PR 2577.

Closing with PR 2577.


HttpClient instance isn't reused in GoogleJsonWebSignature

This means that a new HttpClient instance is created and disposed each time ValidateAsync is called. We might as well reuse the instance.

As far as I can see, HttpClient is only used to fetch the Google certs. The certs are cached, so an HttpClient is only instantianted at most once per hour (the cache expiration is one hour).
I'm not sure keeping an HttpClient instance cached for this would be better?

You're quite right - I missed the caching aspect.


Add initial pipe support to json serialization

Add PipeReader and PipeWriter support per https://github.com/dotnet/corefx/issues/34372
After the API review is completed, this will be updated again to reflect that.
cc @ahsonkhan @davidfowl

Oh interesting design point:
What happens if the ReadOnlySequence<byte> and ReadOnlySpan<byte> you pass in has more data after the JSON object you de-serialized? The reason I ask is because there's no way to figure out how much of the buffer was read from the outside.
@JamesNK what does JSON.NET do in this case?

https://www.newtonsoft.com/json/help/html/P_Newtonsoft_Json_JsonSerializerSettings_CheckAdditionalContent.htm
There is a setting that stops reading when serialization is complete.

@dotnet-bot test this please

@dotnet-bot test this please


Enable hairpinMode in flannel CNI config

Allow pods to communicate with themselves via service IP
https://github.com/coreos/flannel/pull/849

coreosbot run e2e

Flaked on the e2e-selfetcd DeleteAPI test.


Switching between players in draft log doesn't switch shared decks

Bug: in the draft log view if multiple players have submitted decks and you use the dropdown to see one player's deck, the card piles don't update when clicking on a different player to show the deck they shared. Everything else seems to update okay above the piles (name, basics, etc.) As a workaround, you can get the correct deck by changing the dropdown to Cards and then back to Deck (h/t Ben Werne for identifying the bug and the workaround).

A little janky, but this should fix it c7637df38a2de4de12e4da80d92956b85090a979

A little janky, but this should fix it c7637df38a2de4de12e4da80d92956b85090a979

Fix confirmed locally

Fix confirmed locally


Update preferences.md

Fixed minor spelling errors
Switched out else for otherwise for, in my opinion, better flow.
Need some clarification on exactly what is meant by the line
That can be used to create additional containers for preference
As I believe it can be used to create private(?)/shared(?) containers, however I didn't understand it as additional.

@LuckyDucko : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jamesmontemagno Views on this PR?

@jamesmontemagno
I'm not sure if it should be also takes.
to me also takes would be used if I was talking about just one of the methods e.g.

The above method also takes in an optional sharedName

however, saying

The above methods also takes in an optional sharedName

Sounds unusual as since Methods is a plural, it should use the singular take in

@davidbritch : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Incompatible pointer types

I'm getting two warnings when building from within Xcode 8.3.3.

Incompatible pointer types passing 'NSArray *' to parameter of type 'NSError *'
Incompatible pointer types sending 'const CFStringRef _Nonnull' (aka 'const struct __CFString *const') to parameter of type 'id _Nonnull'

It appears that these are actually fixed in the repo but because we're using yarn add react-native-sensitive-info to add it to our project we aren't getting the latest.  We're getting version 5.1.0, but that was published back in May.
Can you publish a new version that has all the changes from the past 4+ months?
Thanks,
David

Hello @DavidPotter , I've just released an beta version of RNSensitiveInfo. 😄
yarn add<EMAIL_ADDRESS>

Great!  Thanks @mCodex.  That fixed one of the warnings.  I guess I didn't do my homework as there is still one warning left.  It is at line 215, which looks like this:
reject(@"no_events", @"There were no events", @[[NSNull null]]);

The warning is:

Incompatible pointer types passing 'NSArray *' to parameter of type 'NSError *'

Hi @DavidPotter, thanks for your feedback! It's stranger 🤔 I have to take a look at it, because I have no idea what is happening.

I took another look at this today and this is what I learned.  The reject function is defined as an instance of type RCTPromiseRejectBlock which is defined like this:
typedef void (^RCTPromiseRejectBlock)(NSString *__strong, NSString *__strong, NSError *__strong)

The warning is being displayed because an NSArray is being passed where an NSError is expected.  I'm puzzled (and a little disappointed) as to why this is a warning and not an error.
Wouldn't it be appropriate to just pass a nil instead of @[[NSNull null]]?


PEAR-1711 - Case counts on Gene Expression card

Description
Checklist

[ ] Added proper unit tests
[ ] Left proper TODO messages for any remaining tasks
[ ] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good - counts are as expected! 👍


why not use 401 instead of 404 when unauthorized?

http code 404 stands for resourse Not Found，is 401 more accurate when the user authentication failed?
reference:  http://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses
Thanks~

From the README:

Knock responds with a 404 Not Found when the user cannot be found or the password is invalid. This is a security best practice to avoid giving away information about the existence or not of a particular user.

This has also been answered in issues #44 and #76.

got it.
Thanks again for repeating the answer to my carelessness!

Sorry, but this makes no sense to me. Working outside de faco standards doesn't seems valid here not even to employ some kind of security by obfuscation. You should return HTTP 401 for both invalid user or invalid password.
I did read your other GitHub issues and is clear that, even though people asked for, you could not supply a clear reference from whether did you get that assumption that an HTTP 404 is the best secure approach. I can debate with you and I doubt you could prove to me that, for an API token endpoint, which is supposed to be publicly traceable, returning an HTTP 404 instead of 401 is better. Anyway, I'm open to the discussion.
I'll try to modify it locally to return HTTP 401 instead, but it concerns me from a culture-wise perspective that you are so skeptical about something so clear, and refuses to adjust and accept it as an issue, without providing any reference, given so many comments and points made.

Just to make my point more clear. I understand the security advantages of replying with HTTP 404 for an anonymous user trying to access a protected resource that requires authentication like, e.g, /api/wallet.
I saw in the code we have a way to customize the unauthorized entity when a user doesn't gets authenticated. I see this as an issue, but it is still good giving people the option to customize.
https://github.com/nsarno/knock/commit/7d92de4b0210d541dd8ee3ee00a2d5f6e37c0303#diff-18caa9b36bf543440f73344b6cc34769R23
What I believe the reporter here wanted, and it is at least what I was looking for, was means to customize the way we reply to /user_token route for invalid username and password. For that, default should be HTTP 401 and, well, I don't know why, you could customize to HTTP 404 for whatever reason you believe.
TL;DR: return HTTP 401 for /user_token and HTTP 404 for /some_protected_resource

Coming across this years later, I solved it by overriding the authenticate method from the base class.
class UserTokenController < Knock::AuthTokenController
  skip_before_action :verify_authenticity_token

  private

  def authenticate
    return if (entity.present? && entity.authenticate(auth_params[:password]))

    render json: {error: 'Invalid credentials'}, status: :unauthorized
  end
end

I agree with @rafaelpivato that 401 simply makes more sense here, this has confused me and my team a number of times over the years, when we think we made a mistake with URL or routing rather than credentials / authentication because of the 404 status.
Also, our 404 error handling gets tripped up by this and needs a special case since it's fundamentally not what would we'd consider a 404.
My team is going to update all of our our Knock endpoints similar to @aaron-humerickhouse's method for that reason :+1: IMO it should be the default to save other people from getting tripped up in the future, there's no reason why 404 is more secure than 401.


Closed head-tag in document template

Description
Please describe your pull request:

Why is it necessary?

It makes the document template HTML compliant.

What does it improve?

It closed the head-tag.

Does it have side effects?

No.

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
#SW-17160

How to test?
Generate a document (e.g. an invoice) and see if it looks still the same as before.

Tracked with ticket http://issues.shopware.com/issues/SW-17160.


fix: error message specificity, tempalteID state management, runtime selection data handling

Description
Various small items for the new creation experience are handled in this PR. More details outline in each task item below
Task Item

fixes #5850

New logic for templateID state management and template display implemented to account for new '@microsoft/' npm pacakges that represent the template yeomen generators

fixes #5556

Users selection for desired runtime now passed to template generators
Template generators still need to do something with this info, tracked here (issue 601 in components repo)

fixes #5783

Change has been made so any errors in the creation flow that arise are surfaced to the user as opposed to the previous generic '500 server call' that was previously surfaced

TODO: handle strong typing of runtime selection (azureWebApp and azureFunction), currently it is just passing the string from the front end, to the server, to the yeomen generators

DO NOT MERGE.
This PR is replaced by 3 smaller ones:
#5865
#5880
#5881


Problem with redefining a language and using babel

I am working on a french book. I redefined the translation for french using :
\RequirePackage[french]{babel}
\setlength\parindent{2em}
\newcommand\figref[1]{\textbf{Figure}~\ref{#1}}
\newcommand\tabref[1]{\textbf{Tableau}~\ref{#1}}
\renewcommand{\chaptername}{Chapitre \thechapter}
\newcommand{\authorname}{\textbf{auteur: }}
\newcommand{\institutename}{\textbf{Institut: }}
...

When I use
\documentclass[12pt,mode=fancy,cite=authoryear,titlestyle=display,lang=fr]{elegantbook}

The generated document does not have the chapter number in french, it is only present in english when lang=en.
The only difference I see is in french I use babel, in english not. In spite of this, I am unable to correct the problem. Do you have any ideas?

Please provide MWE.

\documentclass[12pt,mode=fancy,cite=authoryear,titlestyle=display]{elegantbook}
\usepackage[utf8]{inputenc}
\usepackage[french]{babel}

% == Translation in french
\renewcommand{\chaptername}{Chapitre \thechapter}

\begin{document}
\maketitle
\chapter{Test}
\end{document}

If you comment the line \usepackage[french]{babel} the translation is correct with the chapter number. With babel, the chapter number is missing.

I can't solve this problem in my ability, sorry.

The missing number is known problem in version 3, I have fix it in version 4, later in this year, version 4 will be released.
This problem is caused by different logic when dealing with the chapter counter and chapter name.

Yes I deal with the same problem in spanish, it's because babel use {lang}chaptername instead of \chaptername.
In spanish i use \spanishcheptername... why you dont try with \frenchchaptername... anyway I tried it with the Italian in the same way without success.
\renewcommand{\spanishchaptername}{Capítulo \thechapter}

Seeing the update from 17 september 2020, I presume this has been fixed in 4.0?
Recently I used in Overleaf the Elegant book template and ran into this problem.
Can this template be updated?
Thanks.

Seeing the update from 17 september 2020, I presume this has been fixed in 4.0? Recently I used in Overleaf the Elegant book template and ran into this problem. Can this template be updated? Thanks.

The overleaf version is older version (3.x), I didn't upload the latest version to overleaft, you can check the lastest version on your local machine, I will upload 4.x to overleaft later.


fix(yamlls): add yaml.docker-compose to filetypes

This is a filetype used by for example:

https://github.com/ekalinin/Dockerfile.vim
https://github.com/sheerun/vim-polyglot

I wonder if there should be some changes to lspconfig internals to respect these "compound" filetypes that are composed of more than one filetype. I might be misunderstanding how the . notation should be interpreted though (I'm going off of :h 'filetype')

I'd rather not complicate the filetype handling until it becomes an issue


Add support for #![no_std]

The default features include the std (to be able to run cargo test on the host PC).
Among the things I took the liberty of doing in-order to support #![no_std]:

Remove usage of failure and implement core::fmt::Display and optionally std::error::Error where needed
Remove logging, it will never work on embedded platforms and I feel at this level gdb is usually more helpful

Fixes #7

I forgot to mention that I'm totally fine with working more on this if it doesn't meet your expectations :smile:

I'm traveling for the week and won't be able to look at this immediately,
but it all sounds awesome. Thank you so much!
Your comments all sound like reasonable changes.
I like logging, but it's also difficult on embedded systems and does grow
the library size.
On Tue, Apr 30, 2019, 1:26 PM Gabriel Féron<EMAIL_ADDRESS>wrote:

I forgot to mention that I'm totally fine with working more on this if it
doesn't meet your expectations 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jasonpeacock/ht16k33/pull/12#issuecomment-488062128,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJ2E4ZUML2GSO6SEBREXCLPTCFMZANCNFSM4HJGEFIQ
.

Sorry for the long delay, this looks good. Thank you!
I've created #13 to track releasing this as a new (0.4.0) version, which I'll do this weekend.

Sorry for the long delay, this looks good. Thank you!
I've created #13 to track releasing this as a new (0.4.0) version, which I'll do this weekend.

No problem at all, thanks for looking into it and merging the PR! I guess I can start publishing my Adafruit HAT crate now :tada:


chardet is very very very slow

The character detection code in chardet is very very slow.  A simple profiling of flanker parsing shows that ~85% of CPU time is spent in chardet.

@pquerna you need cchardet


How to import already marked data?

I have some marked data that I want to import into label studio. Can I import it?

Check this page: https://labelstud.io/guide/predictions.html#main


[feature request] Grayscale (Black&White) content + colored style?

Should save some memory/performance.

This won't actually save any memory or computation because the grayscale image would need to be fed through the pretrained VGG network; see additional discussion here:
https://github.com/jcjohnson/neural-style/issues/82

Yep.
I think also it would miss color palette mapping info (where reddish colors mapped to reddish and so on).


Update avocode to 2.26.2

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Each time I ran the command, I got a different checkpoint. The HTML page must have something that changes on every call.

good catch, thanks @vitorgalvao


DAO Documentation

Motivation
This application requires documentation to inform the user about the project.
This includes:

README.md

What the application is, how to run it etc

SPECIFICATION.md

General overview of the application use cases, contract design, UI design etc

Any additional informative files

No issue has currently addressed the UI aspect since there is no UI at this time. That being said there is sufficient documentation that has been added through other issues therefore this issue is being closed.


Stats won't apply in game.

I have tried everything I could think of; adding the diagnostic globals to my settings manually because for some reason my version of lua reader won't add them from server side. I have remade it in a different file, and still nothing. Any suggestions? I am barely a coder at all so if it's obvious, please let me know I'd appreciate it a lot. Thanks!

Have you figured it out yet? I'm having the same problem...


Deployment script module - AKV certificates

Description
Adds a new module which leverages Key Vaults ability to create self-signed certificates.
It is also able to use these generated certificates in Azure Application Gateway as either frontend or backend certificates.
The script is derived from what is used in this sample.
Closes #69
Adding a new module

[x] A proposal has been submitted and approved.
[x] I have included "Closes #{module_proposal_issue_number}" in the PR description.
[x] I have run brm validate locally to verify the module files.
[x] I have run deployment tests locally to ensure the module is deployable.

Closing this down for the moment as i've still got an optimisation to do in the AGW script. oops.

Re-Opening as the script looks fixed.
I'm anticipating feedback on "what if the AKV is in a different RG to the AGW" - but am interested in other thoughts/feedback before I add parameters for this use case.

Some great feedback from @bmoore-msft
I think this module will be best down-scoped to just KeyVault.
I'll work on the suggested changes, then respond to the PR discussions individually. I think all but 2 i'm happy to implement without further discussion.

Getting another strange CI failure @shenglol - any insight? It works fine locally.

An error occurred: Exception calling "Invoke" with "0" argument(s): "The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop:
Cannot find deleted vault 'akvtest3vbarm34t26ck' in location 'westus'"

Thanks for all the feedback @bmoore-msft and iteration @Gordonby.
In general, I am aligned with Brian's thinking, though I had one thought that may split the difference:
Should we have a generic-deployment-script module that is the foundation for all these specific scenarios in which to use a deployment script. The generic-deployment-script would expose everything (or mostly everything) with good defaults, then the create-agw-kv-certificate would use that module in its definition and not expose the same degree of parameters. Thoughts?

Getting another strange CI failure @shenglol - any insight? It works fine locally.

An error occurred: Exception calling "Invoke" with "0" argument(s): "The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop:
Cannot find deleted vault 'akvtest3vbarm34t26ck' in location 'westus'"

That's an error in cleaning up the resource group. It seems that deleting a key vault is an async operation inside the backend and we should wait some time before purging the key vault. I'm working on a fix now.

Closing and reopening the PR to run the latest Deployment Test - CI.

Thanks for all the feedback @bmoore-msft and iteration @Gordonby.
In general, I am aligned with Brian's thinking, though I had one thought that may split the difference:
Should we have a generic-deployment-script module that is the foundation for all these specific scenarios in which to use a deployment script. The generic-deployment-script would expose everything (or mostly everything) with good defaults, then the create-kv-certificate would use that module in its definition and not expose the same degree of parameters. Thoughts?

Do we have a generic deployment script module?  If so, I do love the idea...

Thanks for all the feedback @bmoore-msft
        Brian Moore (AZURE RESOURCE MANAGER)
        FTE and iteration @Gordonby

        Gordon Byers
        FTE.

In general, I am aligned with Brian's thinking, though I had one thought that may split the difference:
Should we have a generic-deployment-script module that is the foundation for all these specific scenarios in which to use a deployment script. The generic-deployment-script would expose everything (or mostly everything) with good defaults, then the create-kv-certificate would use that module in its definition and not expose the same degree of parameters. Thoughts?

Do we have a generic deployment script module? If so, I do love the idea...

We don't but we can make one, or @Gordonby or @MrMCake can have right of first refusal :)

We don't but we can make one, or @Gordonby or @MrMCake can have right of first refusal :)

There is a module for this resource in CARML. If it's suitable, then @MrMCake should probably PR.

That's an error in cleaning up the resource group. It seems that deleting a key vault is an async operation inside the backend and we should wait some time before purging the key vault. I'm working on a fix now.

Why would we need to purge the vault?

I'll need to update the MCR manifest before merging the PR since the module name is changed.


Failed to configure event hub error

sanket@sanket-bojewar:~/build-blockchain-insurance-app$ docker logs web

<EMAIL_ADDRESS>serve /app
cross-env NODE_ENV=production&&node ./bin/server

/app/app/static/js
Server running on port: 3000
Failed to configure event hubs. Error this._channelName.newChannelEventHub is not a function
(node:22) UnhandledPromiseRejectionWarning: TypeError: this._channelName.newChannelEventHub is not a function
at OrganizationClient.initEventHubs (/app/www/blockchain/utils.js:77:49)
at /app/www/blockchain/setup.js:89:19
at Generator.next ()
at step (/app/bin/blockchain/setup.js:27:191)
at /app/bin/blockchain/setup.js:27:361
at
(node:22) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:22) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I am also facing this same issue

i just cloned and ran the code - the app is up and running.
Few tips to try:

make sure you clone the latest repo from github

what version of python do you have installed on your machine? or the readme to make sure you have the latest versions

did you remove all previously installed images/containers? do it manually if you have to:
docker rm $(docker ps -aq) -f
docker rmi $(docker images -aq) -f
Then try docker ps and docker images to make sure you got rid of them before starting to install the app by running ./build_mac.sh or whatever machine you have.

Let me know how it goes.

Can you please post your versions of the prerequisite mentioned in the readme? Thanks alot for your support.

i just cloned and ran the code - the app is up and running.
Few tips to try:

make sure you clone the latest repo from github
what version of python do you have installed on your machine? or the readme to make sure you have the latest versions
did you remove all previously installed images/containers? do it manually if you have to:
docker rm $(docker ps -aq) -f
docker rmi $(docker images -aq) -f
Then try docker ps and docker images to make sure you got rid of them before starting to install the app by running ./build_mac.sh or whatever machine you have.

Let me know how it goes.

i just cloned and ran the code - the app is up and running.
Few tips to try:
* make sure you clone the latest repo from github

* what version of python do you have installed on your machine? or the readme to make sure you have the latest versions

* did you remove all previously installed images/containers? do it manually if you have to:
  `docker rm $(docker ps -aq) -f`
  `docker rmi $(docker images -aq) -f`
  Then try `docker ps` and `docker images` to make sure you got rid of them before starting to install the app by running `./build_mac.sh` or whatever machine you have.

Let me know how it goes.

python -V
Python 2.7.15rc1
python2 -V
Python 2.7.15rc1
python3 -V
Python 3.6.7
performed both the steps, still isn't working.

i just cloned and ran the code - the app is up and running.
Few tips to try:

make sure you clone the latest repo from github
what version of python do you have installed on your machine? or the readme to make sure you have the latest versions
did you remove all previously installed images/containers? do it manually if you have to:
docker rm $(docker ps -aq) -f
docker rmi $(docker images -aq) -f
Then try docker ps and docker images to make sure you got rid of them before starting to install the app by running ./build_mac.sh or whatever machine you have.

Let me know how it goes.

 Somehow the latest commit (updated to the latest fabric version) is having issues. Example, const defaultEventHub = this._channelName.newChannelEventHub(this._peerConfig); should have been const defaultEventHub = this._channel.newChannelEventHub(this._peerConfig);. There are similar errors.

should have been const defaultEventHub = this._channel.newChannelEventHub(this._peerConfig);

which file?
which line?
does it work after the change?

If I clone 1 commit before, it work

the previous commit works just fine.

just in case someone needs a way to use a specific commit

do a regular git clone where you want the repo (gets everything to date — I know, not what is wanted, we're getting there)
git checkout  of the commit you want

Can you type in the command to use the commit which is working fine? Thank
you.
On Wed, 13 Mar 2019, 12:09 khizir97<EMAIL_ADDRESS>wrote:

If I clone 1 commit before, it work
the previous commit works just fine.

just in case someone needs a way to use a specific commit

do a regular git clone where you want the repo (gets everything to
date — I know, not what is wanted, we're getting there)
git checkout of the commit you want

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/IBM/build-blockchain-insurance-app/issues/62#issuecomment-472299130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcU5UPB-FBK1xHQBxl_c4pO-bLJOGABnks5vWJ0sgaJpZM4bhDtM
.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD is now at d9de332 Update README.md

if you clone 1 commit before, you're cloning a repo with previous fabric version and not 1.4. the latest version supports ChannelEventHub library and not EventHub

if you clone 1 commit before, you're cloning a repo with previous fabric version and not 1.4. the latest version supports ChannelEventHub library and not EventHub

Can you please post your version of the prerequisites mentioned in the readme? Thanks alot for your support.

Docker - 18.09.2
Docker Compose - 1.21.2
node - 11.11.0
Git client - 2.19.1
Python - 3.5.5 on one machine and 2.7.x on another (tested on both)

Hi. It did not work with the master branch. It worked with d9de332

I have opened a pull request to fix the issue in the latest commit. #66

Docker - 18.09.2
Docker Compose - 1.21.2
node - 11.11.0
Python - 3.5.5 on one machine and 2.7.x on another (tested on both)

Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ python --version
Python 3.7.1
Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ docker --version
Docker version 18.09.2, build 6247962
Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ docker-compose --version
docker-compose version 1.23.2, build 1110ad01
Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ node --version
v11.11.0
Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ git --version
git version 2.20.1
Sankets-MacBook-Pro:build-blockchain-insurance-app sanket$ docker logs web

<EMAIL_ADDRESS>serve /app
cross-env NODE_ENV=production&&node ./bin/server

/app/app/static/js
Server running on port: 3000
Failed to configure event hubs. Error this._channelName.newChannelEventHub is not a function
(node:22) UnhandledPromiseRejectionWarning: TypeError: this._channelName.newChannelEventHub is not a function
at OrganizationClient.initEventHubs (/app/www/blockchain/utils.js:77:49)
at /app/www/blockchain/setup.js:89:19
at Generator.next ()
at step (/app/bin/blockchain/setup.js:27:191)
at /app/bin/blockchain/setup.js:27:361
at
(node:22) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:22) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
tried but the same error.

i just cloned and ran the code - the app is up and running.
Few tips to try:

make sure you clone the latest repo from github
what version of python do you have installed on your machine? or the readme to make sure you have the latest versions
did you remove all previously installed images/containers? do it manually if you have to:
docker rm $(docker ps -aq) -f
docker rmi $(docker images -aq) -f
Then try docker ps and docker images to make sure you got rid of them before starting to install the app by running ./build_mac.sh or whatever machine you have.

Let me know how it goes.

 Somehow the latest commit (updated to the latest fabric version) is having issues. Example, const defaultEventHub = this._channelName.newChannelEventHub(this._peerConfig); should have been const defaultEventHub = this._channel.newChannelEventHub(this._peerConfig);. There are similar errors.

I tried the previous commit, it ran for sometime then it began to give me error/issue #45 ,any help would be appreciated.

Hi. It did not work with the master branch. It worked with d9de332

is it still working?

Yes it is

Hi. It did not work with the master branch. It worked with d9de332

is it still working?

Thank you for letting me know, are you using all the latest prerequisites?

Yes, I am

Can you try again? It should now work.

The demo was updated two days ago, I tried it this afternoon and found it not working as expected. Looking into the docker logs web I found that peers failed to join the channel and an error message that network not found: build-blockchain-insurance-app_default not found. I checked the docker network and found the buildblockchaininsuranceappmaster_default network. So I went into the peer-base.yaml,  changed '- CORE_VM_DOCKER_HOSTCONFIG_NETWORKMODE=build-blockchain-insurance-app_default' to '- CORE_VM_DOCKER_HOSTCONFIG_NETWORKMODE=buildblockchaininsuranceappmaster_default', and relaunched it. It worked then.

The demo was updated two days ago, I tried it this afternoon and found it not working as expected. Looking into the docker logs web I found that peers failed to join the channel and an error message that network not found: build-blockchain-insurance-app_default not found. I checked the docker network and found the buildblockchaininsuranceappmaster_default network. So I went into the peer-base.yaml, changed '- CORE_VM_DOCKER_HOSTCONFIG_NETWORKMODE=build-blockchain-insurance-app_default' to '- CORE_VM_DOCKER_HOSTCONFIG_NETWORKMODE=buildblockchaininsuranceappmaster_default', and relaunched it. It worked then.

You can do either of these two:

Main folder name to be build-blockchain-insurance-app
Create a .env file with COMPOSE_PROJECT_NAME=build-blockchain-insurance-app

My understanding is that Docker Compose creates default network in this syntax.
Let us know if this works.

I am also facing this same issue

This issue is solved with my latest commit. Can we get this closed?

I am also facing this same issue

This issue is solved with my latest commit. Can we get this closed?

I am also facing this same issue

This issue is solved with my latest commit. Can we get this closed?

Can you please help me with this?

I am also facing this same issue

This issue is solved with my latest commit. Can we get this closed?

This was the error while building,Can you please help me with this?

I am also facing this same issue

This issue is solved with my latest commit. Can we get this closed?

This was the error while building,Can you please help me with this?

Try ./clean.sh


Improve CI Observability - Tests dashboard

Improve CI Observability - Tests dashboard

[ ] enable pytest profiling
[ ] set alerts / slack notifications if some conditions met
[ ] collect flaky tests

Enhancement moved to JIRA: INFRA-33


Add SSE component

This PR adds ServerSideEvents components which enables dash apps to subscribe to server sent events.
server.py
import asyncio
import random

import uvicorn
from sse_starlette.sse import EventSourceResponse
from starlette.applications import Starlette
from starlette.middleware import Middleware
from starlette.middleware.cors import CORSMiddleware

middleware = [Middleware(CORSMiddleware, allow_origins=['*'])]
app = Starlette(debug=True, middleware=middleware)

async def numbers():
    while True:
        await asyncio.sleep(1)
        yield [random.randrange(200, 1000) for _ in range(10)]

@app.route("/")
async def sse(request):
    generator = numbers()
    return EventSourceResponse(generator)

if __name__ == "__main__":
    uvicorn.run(app, port=8000, log_level='info')

client.py
from dash import Dash, html, Input, Output, dcc
from dash_extensions import ServerSentEvents

app = Dash(__name__)

app.layout = html.Div(
    [
        dcc.Graph(id="graph"),
        ServerSentEvents(id="sse", url="http://<IP_ADDRESS>:8000"),
    ]
)

app.clientside_callback(
    """
    function(val) {
        values = val ? JSON.parse(val) : []
        return {data: [{y: values , type: "scatter"}]}
    }
    """,
    Output("graph", "figure"),
    Input("sse", "message"),
)

if __name__ == "__main__":
    app.run_server(debug=True)

Output:
https://user-images.githubusercontent.com/91216500/152369583-8926e593-13d0-4e39-b639-f5f1daec3e20.mov
Please let me know if this PR needs more changes.

It look really cool! Any reason, the component is not just called EventSource?

I named the component according to what it conceptually does. DashEventSource makes sense only if you know how SSE is implemented in JavaScript, which is via creating an event source. What do you think?

I generally like to link the component names to the JS ancestors as close as possible where it makes sense. So I am learning more towards DashEventSource. Or maybe ServerEventSource (or DashServerEventSource, but that's a bit long...).

I think we should also add a readyState property before releasing the component (but I could also do that).


Add top navigation component

Changes

Adding reusable top navigation component
Adding base images for the project
Importing the project fonts globally

Missing

Styles on hover
Responsive design

My only suggestion is that we change the underscores to hyphens in the asset file names. Everything else looks great!

My only suggestion is that we change the underscores to hyphens in the asset file names. Everything else looks great!

I agree, let's handle multi-word filenames with hyphens from now on. I renamed the assets replacing the underscores with hyphens and adjusted the paths in the code accordingly.


fix: Android - Map pending text shown in preview instead of icon

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/43420
PROPOSAL: https://github.com/Expensify/App/issues/43420#issuecomment-2173129986
Tests
precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

[x] Verify that no errors appear in the JS console

Offline tests
precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

QA Steps
precondition: user a member of a workspace

Android specific issue

Open the workspace chat
Create more than 1 distance expenses
In preview, verify the map pending text is not shown only the pending icon is shown with correct style.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/c54c64dc-c21c-485e-a2b7-08c8516b24c1

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/6ac62d94-2efc-4480-9fa3-647f1029e87a

iOS: Native
https://github.com/Expensify/App/assets/85894871/1389ddd7-babc-47dc-a169-16612fa56e16

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/0f664ba5-ca57-4da6-bf60-ff35aaea2252

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/24510dd9-cfdb-478b-ae75-b4c0e802af1d

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/34756515-b6ce-410c-abad-cc8bb33cdd77

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Online
Offline

Android: mWeb Chrome
https://github.com/Expensify/App/assets/56457735/56d7f19e-2fe5-4194-b01d-71a27319258c

iOS: Native
https://github.com/Expensify/App/assets/56457735/43ddb59d-0c0f-48fd-a424-67592f6b273d

iOS: mWeb Safari
https://github.com/Expensify/App/assets/56457735/347c8b71-119b-4452-ba68-086c5b80ebd2

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/56457735/e5a8f888-4d22-4413-90ce-86cf7ae054b7

MacOS: Desktop
https://github.com/Expensify/App/assets/56457735/5ce356b6-38d2-4bd9-b31b-be35bc149f8c

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@francoisl Looks like this PR was skipped from the production deploy for the past 7 days, any idea why ?

Looks like the last production deploy failed. Going to check with the rest of the team.
https://github.com/Expensify/App/actions/runs/9704167915/job/26783866816

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Convert Fullstack roadmap to readme format

Fixes Issue

Closes #201
Changes proposed

Screenshots

Note to reviewers

Within each step, I am a bit doubtful if there is any order for the resources and if I have done that correctly or not.

Hey @kaiwalyakoparkar, I have made the changes. Can you please look into it?

Hey @kaiwalyakoparkar, I have made the changes. Can you please look into it?

Hey @kaiwalyakoparkar. There was a small mistake from my side, The heading(H1) should have been Fullstack roadmap instead of frontend roadmap

@kaiwalyakoparkar can you please push the above-mentioned change directly as it is a small fix?


Add python 3.11 to GitHub deploy

Python 3.11 is currently only in the build target for Windows and macOS.

Related to #436


runtime(vim): Update base-syntax, improve :let-heredoc highlighting

The end marker is not required to match the indent of :let when "trim"
is specified, it may also appear without leading whitespace as normal.

thanks!


Can translate python to c++?

Can translate python to c++? As it require to deploy on mobile device

+1


changes in analysis_biocyc.py, analysis_db.py, gapfill.py

analysis_biocyc.py:

chemical formula error catching
check if input paths exists because PICNIC

analysis_db:

added multiprocessing for BiGG db requests, currently splitted in 5 threads, more might overwhelm db?

TODO: progress bar is not working

TODO: SettingWithCopyWarning: A value is trying to be set on a copy of a slice from a DataFrame. Try using .loc[row_index,col_indexer] = value instead in line 165, 170 -> however .loc is used, I dont see the issue here...

gapfill.py:

avoid conflicts while converting None ChEBI values to floats

analysis_biocyc.py & gapfill.py can be merged into dev.
analysis_db.py could also be merged as point 3 is not necessarily to be fixed, but we could add at the top of the file under the import of pandas: pd.options.mode.chained_assignment = None. For point 2, if we cannot add a progress bar, we should print for now how long the process might take under the printout when the process is started.
@f3rryman If you add the changes today, I can integrate them into the new release. We could add a working progress bar in a later release also for analysis_db.py point 3.

Fixed the progress bar bug & added the pd.options.mode.chained_assignment = None line to analysis_db.py


Is 'either' extra here?

Hello,
kindly check if 'either' is redundant in this string: "You can export an installation configuration file from either a previously installed instance of Visual Studio."
If not, the sentence would need the second option also.
Kind regards,
Anne H., CQ

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 517f011b-d4f4-b1d3-3212-6725204a71e3
Version Independent ID: 77f048ce-d750-9c9d-f33a-5ec4f4a9965a
Content: Import or export installation configurations
Content Source: docs/install/import-export-installation-configurations.md
Product: visual-studio-windows
Technology: vs-installation
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@QueryCoordinator, thanks for your feedback. We've updated the doc. The changes should be live later today.
Thanks!


silx: init at 2.1.1, fabio: init at 24.4.0

Description of changes
Both fabio and silx are used at so-called synchroton radiation facilities all around the globe (particle accelerators that produce nice X-ray radiation). See the fabio/silx website.
Originally, I wanted to package just silx, a viewer for experimental data in different formats, most notably HDF5, but it needed the fabio library, which is used by other tools as well.
I asked around and having this as one PR with two commits seems agreeable to people.
If you actually want to try running silx, download a sample h5 file and then after building silx, run silx view xrr_dataset.h5. It should show a tree of attributes on the left and actual data on the right.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build silx

@Aleksanaa Thanks for the quick review!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4546

@FliegendeWurst Thanks for the review! I've fixed all the issues (and reformatted with nixfmt).

@FliegendeWurst Tests have passed now. Is it ready to be merged?


Fix iOS viewport issue

To fix this issue, let's try this hack.

Another possible solution:
https://css-tricks.com/the-trick-to-viewport-units-on-mobile/


Allow writing with void promise if IdleStateHandler is configured in …

…pipeline.
Motivation:
Allow writing with void promise if IdleStateHandler is configured in the pipeline for read timeout events.
Modifications:
Better performance.
Result:
No more ChannelFutureListeners are created if IdleStateHandler is only configured for read timeouts allowing for writing to the channel with void promise.

AUTOMATED MESSAGE for ADMINS:Please verify and accept the pull request.To accept, say @netkins acceptTo build again, say @netkins buildTo whitelist the author, say @netkins whitelist

@johnou please sign the ICLA: http://tinyurl.com/netty-icla
Let me know once done

@netkins accept

@normanmaurer signed.

@johnou Thanks a ton!
Cherry-picked into 4.0 (0decf2f64794481aa4382e18e726649294bbaf82), 4.1 (ad7f033c061e6d8fbabec6171e52a658310e21df) and master (eee7b3c07d9792ac463c2124009fd0ee34774ede)


Search Unsuccessful

Used the seed cracker and gathered enough bits, however the seed cracker returned with no results. Is there something I did wrong? I used the original in 1.15 and it worked fine, just wanted to make sure I hadn't messed up anything.
Attached is the log report (unsure if helpful)
latest.log

Used the seed cracker and gathered enough bits, however the seed cracker returned with no results. Is there something I did wrong? I used the original in 1.15 and it worked fine, just wanted to make sure I hadn't messed up anything.
Attached is the log report (unsure if helpful)
latest.log

what dimension are you cracking in? If in overworld, the server might be using anti-xray which covers part of the dungeon floor. If so, mine out the dungeon so the whole floor is visible.


Use ContractScan for the deployment link

Links to ContractScan which shows the list of all/most deployments for both singleton factories.

Disclaimer: I am the author of the tool

Thank you for your PR.
I don't think we will merge the PR at the moment. I don't think there is a demand for using an external website to list existing deployments and I am personally not familiar with the tool. We may reconsider at a later point in time, but I will close this for now.

Hey @Destiner , I actually liked the tool, and I spoke to @nlordell internally. We might add it to the readme if it's separated from the address and there's a clear notice that the Safe team does not maintain the tool.
Something like:

Deployments overview on ContractScan) (not maintained by the Safe team).

Further feedback on the tool:
We do have a need for an interface to track the deployments and the feature that would be particularly useful to us is to create bundles of deployments. E.g., we have this repo with the Safe deployments we'd like to somehow track on a webpage: https://github.com/safe-global/safe-deployments
So adding a "bundle" feature that may be created via URL, e.g., contractscan.xyz/bundle?addresses=...&name=Safe Contracts v1.3.0/, would've been very helpful for us.

@mmv08 that's a great idea and something i'd love to use myself. let me think what's the best way to support that and get back to you in a separate pr/issue!


M_CANNOT_LEAVE_SERVER_NOTICE_ROOM is annoying

Suggestion
Currently rejecting an invite to a server notice room might error with M_CANNOT_LEAVE_SERVER_NOTICE_ROOM (or might just work fine). At least that's how the spec is worded. As a client it's a pretty bad user experience to have to tell the user that they actually can't reject this invite and that the button offered was a lie. Potential improvements would be to either change the spec to have some clear indicator while the membership is invite that it can't be rejected (like for example never allowing invites to server notice rooms to be rejected) or even better, have home servers join users into those server notice rooms without prompting the user to accept an invite.

Clients can determine if the room is a server notice room with the m.server_notice tag. The spec for server notices is pretty clear in that the room cannot be left, so clients should be able to hide the reject button on these rooms.
Servers can optionally auto-join the user to avoid invites, though this is typically considered a bit too invasive.

The spec says clients can not expect to be able to reject it, it doesn't say the room can't be left.

The common implementation is to prevent leaving as well. The spec says the same error code is used for that, so the client should be able to handle the error gracefully.

To cross-reference the spec: https://spec.matrix.org/latest/client-server-api/#client-behaviour-28
It says:

The client must not expect to be able to reject an invite to join the server notices room. Attempting to reject the invite must result in a M_CANNOT_LEAVE_SERVER_NOTICE_ROOM error. Servers should not prevent the user leaving the room after joining the server notices room, however the same error code must be used if the server will prevent leaving the room.

If the common implementation is to prevent leaving, shouldn't that simply be specced? It is pretty bad user-experience to attempt an action which is impossible to complete.

The common implementation is to prevent leaving as well

As far as I can tell Synapse doesn't prevent leaving?

it used to, from memory :/
In any case: clients can avoid the error from rejecting the invite by inspecting account data.

it used to, from memory :/
In any case: clients can avoid the error from rejecting the invite by inspecting account data.

This was changed in May of 2018: matrix-org/synapse#3287.
Regardless, if the intention of the spec is to not allow this, then it should be updated. 🤷


support for x-ratelimit-* response headers in ratelimit

Description:

support for x-ratelimit-* response headers in ratelimit (easy to check current limit status）
XRateLimitHeadersRFCVersion

[optional Relevant Links:]

draft RFC Version 03

If no one has done it, you can give it to me