Mark Voucher as used

[x] Add button to mark Voucher as used. This should be done using an the deposit.InvalidateVoucher API
[x] Use a confirm dialog to ask the user if they are sure they want to mark the voucher as used
[ ] After success from API we can fetch the info again and it should show as "used"

@iam-agf status on this?


[ast,clkmgr] The aon clock slows down with extclk

When clkmgr's extclk_ctrl.sel is True and extclk_ctrl.hi_speed_sel is True the aon clock frequency is reduced to about 100 kHz. This is unexpected. Keeping sel True and setting hi_speed_sel to False brings the aon clock frequency to its nominal value.
A side-effect of this is that when the clkmgr is programmed with extclk and high speed select enabled the io_div2 and io_div4 measurement modules (prim_clock_meas) hit the MaxWidth_A assertion.

Assigned to @tjaychen, but please reassign as needed.

Here are some waves:

@matutem thanks!
do you know what's the external clock frequency in this test? I can't see it from the waves.

Should be 100 MHz. Tim, https://github.com/lowRISC/opentitan/pull/11327 was rebased and is ready for review.

Related to #11561, closing this one for now.


New update seems to have caused issues on Linux 2021.1.9f1 editor. Crashes and closes editor right away.

Hey there,
I created a test project a few weeks ago, whenever this was first released, it was using 2021.1.7f1 at the time and I pulled the new changes into the project and went to start it up, but as soon as the editor first loads after the initial Unity splash/loading image, the editor simply closes, or gives a bug report window. I removed the asset from my assets folder and started Unity again to be sure and it loaded just fine. I put the Smart-Inspector folder back in the project and as it was importing/compiling it just locked up. I forced the project closed, tried to open again, and once again it crashed. The below is an excerpt from the tail end of the logs, though, it doesn't seem too helpful, unfortunately.
---- Edit, I added another bit from a log that looks like it has some more info that is relevant to the patcher, not sure if it is related, but it came up just before it locked up again.

Tail end of logs
Mono: successfully reloaded assembly
- Completed reload, in  1.648 seconds
Domain Reload Profiling:
	ReloadAssembly (1684ms)
		BeginReloadAssembly (110ms)
			ExecutionOrderSort (0ms)
			DisableScriptedObjects (4ms)
			BackupInstance (0ms)
			ReleaseScriptingObjects (0ms)
			CreateAndSetChildDomain (22ms)
		EndReloadAssembly (1522ms)
			LoadAssemblies (54ms)
			RebuildTransferFunctionScriptingTraits (0ms)
			SetupTypeCache (348ms)
			ReleaseScriptCaches (2ms)
			RebuildScriptCaches (61ms)
			SetupLoadedEditorAssemblies (920ms)
				LogAssemblyErrors (0ms)
				InitializePlatformSupportModulesInManaged (9ms)
				SetLoadedEditorAssemblies (0ms)
				RefreshPlugins (1ms)
				BeforeProcessingInitializeOnLoad (61ms)
				ProcessInitializeOnLoadAttributes (576ms)
				ProcessInitializeOnLoadMethodAttributes (269ms)
				AfterProcessingInitializeOnLoad (3ms)
				EditorAssembliesLoaded (0ms)
			ExecutionOrderSort2 (0ms)
			AwakeInstancesAfterBackupRestoration (6ms)
Platform modules already initialized, skipping
RefreshInfo: InitialScriptRefreshV2(NoUpdateAssetOptions) scanfilter:  ... 1 filters
RefreshProfiler: Total: 3136.722ms
	InvokeBeforeRefreshCallbacks: 0.243ms
	ApplyChangesToAssetFolders: 0.055ms
	Scan: 346.128ms
	OnSourceAssetsModified: 0.000ms
	InitializeImportedAssetsSnapshot: 0.114ms
	GetAllGuidsForCategorization: 0.931ms
	CategorizeAssets: 90.709ms
	ImportAndPostprocessOutOfDateAssets: 2675.387ms (2346.398ms without children)
		CompileScripts: 327.557ms
		PostProcessAllAssets: 0.001ms
		EnsureUptoDateAssetsAreRegisteredWithGuidPM: 0.415ms
		InitializingProgressBar: 0.530ms
		PostProcessAllAssetNotificationsAddChangedAssets: 0.400ms
		RestoreLoadedAssetsState: 0.087ms
	ReloadSourceAssets: 0.354ms
	UnloadImportedAssets: 0.003ms
	Hotreload: 0.699ms
	FixTempGuids: 0.003ms
	GatherAllCurrentPrimaryArtifactRevisions: 0.000ms
	UnloadStreamsBegin: 0.138ms
	LoadedImportedAssetsSnapshotReleaseGCHandles: 0.018ms
	GetLoadedSourceAssetsSnapshot: 0.109ms
	PersistCurrentRevisions: 0.996ms
	UnloadStreamsEnd: 15.708ms
	GenerateScriptTypeHashes: 0.186ms
	Untracked: 5.124ms
Application.AssetDatabase Initial Script Refresh End
Application.AssetDatabase.Refresh Start
Refresh completed in 0.273940 seconds.
RefreshInfo: RefreshV2(ForceSynchronousImport) scanfilter:
RefreshProfiler: Total: 273.386ms
Application.AssetDatabase.Refresh End
RefreshInfo: StopAssetImportingV2(ForceSynchronousImport) scanfilter:
RefreshProfiler: Total: 1.783ms
Refresh completed in 0.239520 seconds.
RefreshInfo: RefreshV2(NoUpdateAssetOptions) scanfilter:
RefreshProfiler: Total: 238.919ms
Launched and connected shader compiler UnityShaderCompiler after 0.01 seconds
Initializing Unity extensions:
Refresh completed in 0.182672 seconds.
RefreshInfo: RefreshV2(NoUpdateAssetOptions) scanfilter:
RefreshProfiler: Total: 181.506ms
UpdateMenuTitleForLanguage: 10
Unloading 273 Unused Serialized files (Serialized files now loaded: 0)
System memory in use before: 110.8 MB.
System memory in use after: 110.3 MB.

Unloading 308 unused Assets to reduce memory usage. Loaded Objects now: 4304.
Total: 4.445728 ms (FindLiveObjects: 0.162896 ms CreateObjectMapping: 0.088576 ms MarkObjects: 3.713755 ms  DeleteObjects: 0.479810 ms)

ProgressiveSceneManager::Cancel()
[MODES] ModeService[none].Initialize
[MODES] ModeService[none].LoadModes
[MODES] Loading mode Default (0) for mode-current-id-Test_Project
[LAYOUT] About to load Library/CurrentLayout-default.dwlt, keepMainWindow=False
Unhandled description string [
Unhandled description string ]
Unhandled description string \
[MODES] ModeService[default].InitializeCurrentMode
[MODES] ModeService[default].RaiseModeChanged(default, default)
[MODES] ModeService[default].UpdateModeMenus
Unhandled description string [
Unhandled description string ]
Unhandled description string \
IsTimeToCheckForNewEditor: Update time<PHONE_NUMBER> current<PHONE_NUMBER>
[Project] Loading completed in 11.095 seconds
	Project init time: 				0.273 seconds
		Template init time: 		0.000 seconds
		Package Manager init time: 		0.000 seconds
		Asset Database init time: 		0.000 seconds
		Global illumination init time: 	0.000 seconds
		Assemblies load time: 			0.000 seconds
		Unity extensions init time: 	0.000 seconds
		Asset Database refresh time: 	0.000 seconds
	Scene opening time: 			2.838 seconds
Unhandled description string [
Unhandled description string ]
Unhandled description string \
Unhandled description string [
Unhandled description string ]
Unhandled description string \
Caught fatal signal - signo:11 code:128 errno:0 addr:(nil)
Obtained 12 stack frames.
#0  0x007f630425cbb0 in funlockfile
#1  0x007f63040d27d9 in psiginfo
#2  0x007f6304185d3b in __printf_chk
#3  0x007f61241c7e56 in mono_breakpoint_clean_code
#4  0x00000041977308 in (Unknown)
#5  0x00000040f43dac in System.InvalidCastException:.ctor ()
#6  0x007f61240d5be5 in mono_print_method_from_ip
#7  0x007f61242459fc in mono_perfcounter_foreach
#8  0x007f61242491c1 in mono_object_unbox
#9  0x007f6124202c2b in mono_exception_from_token
#10 0x007f61241c73ac in mono_breakpoint_clean_code
#11 0x00000041978fa3 in (Unknown)
Launching bug reporter
QObject: Cannot create children for a parent that is in a different thread.
(Parent is QObject(0x1ebc4c0), parent's thread is QThread(0x1557630), current thread is Thread(0x18016d0)

Additional Logs

NullReferenceException: Object reference not set to an instance of an object
  at AV.Inspector.Patcher.GUISkinHasLoaded () [0x0000d] in /mnt/x/_unity/_test/Test_Project/Assets/Smart-Inspector/Patches/Provider/Patcher.cs:41
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
UnityEngine.<>c:<RegisterUECatcher>b__0_0(Object, UnhandledExceptionEventArgs) (at /home/bokken/buildslave/unity/build/Runtime/Export/Scripting/UnhandledExceptionHandler.bindings.cs:46)

(Filename: Assets/Smart-Inspector/Patches/Provider/Patcher.cs Line: 41)

AcceleratorClientConnectionCallback - disconnected - :0
PlatformDependent/Linux/External/baselib/builds/Include/C/Baselib_ThreadLocalStorage.inl.h(13): Assertion failed (rc == 0)
Caught fatal signal - signo:5 code:128 errno:0 addr:(nil)
PlatformDependent/Linux/External/baselib/builds/Include/C/Baselib_ThreadLocalStorage.inl.h(13): Assertion failed (rc == 0)
Caught fatal signal - signo:5 code:128 errno:0 addr:(nil)
Obtained 5 stack frames.
#0  0x0055e3c0d026c4 in AudioManager::EngineThreadStarted(char const*)
#1  0x0055e3c0d025c1 in AudioManager::systemCallback(FMOD_SYSTEM*, FMOD_SYSTEM_CALLBACKTYPE, void*, void*)
#2  0x0055e3c287cb94 in FMOD::Thread::callback(void*)
#3  0x007f195db47590 in start_thread
#4  0x007f195da6d223 in clone
Launching bug reporter
Obtained 5 stack frames.
#0  0x0055e3c0d026c4 in AudioManager::EngineThreadStarted(char const*)
#1  0x0055e3c0d025c1 in AudioManager::systemCallback(FMOD_SYSTEM*, FMOD_SYSTEM_CALLBACKTYPE, void*, void*)
#2  0x0055e3c287cb94 in FMOD::Thread::callback(void*)
#3  0x007f195db47590 in start_thread
#4  0x007f195da6d223 in clone
Launching bug reporter
PlatformDependent/Linux/External/baselib/builds/Include/C/Baselib_ThreadLocalStorage.inl.h(13): Assertion failed (rc == 0)
Caught fatal signal - signo:5 code:128 errno:0 addr:(nil)
cp: cannot create regular file '/tmp/status_438479': Permission denied
/proc/self/maps:
407d8000-4080c000 rwxp 00000000 00:00 0
4081c000-4082c000 rwxp 00000000 00:00 0
4083c000-4086c000 rwxp 00000000 00:00 0
4087c000-4090c000 rwxp 00000000 00:00 0
40918000-40df1000 rwxp 00000000 00:00 0
41359000-41369000 rwxp 00000000 00:00 0
41bd2000-41be2000 rwxp 00000000 00:00 0
55e3bdf17000-55e3bfce0000 r--p 00000000 103:05 6704642                   /home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity
55e3bfce0000-55e3c316a000 r-xp 01dc9000 103:05 6704642                   /home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity
55e3c316a000-55e3c3270000 r--p 05253000 103:05 6704642                   /home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity
55e3c3270000-55e3c32bc000 rw-p 05359000 103:05 6704642                   /home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity
55e3c32bc000-55e3c3560000 rw-p 00000000 00:00 0
55e3c4c5f000-55e3cec26000 rw-p 00000000 00:00 0                          [heap]
7f167487f000-7f167ac49000 r--p 00000000 103:05 6704584                   /home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity_s.debug
7f1680000000-7f1680108000 rw-p 00000000 00:00 0
7f1680108000-7f1684000000 ---p 00000000 00:00 0
7f16875ff000-7f1687600000 ---p 00000000 00:00 0
7f1687600000-7f1687e00000 rw-p 00000000 00:00 0
7f1688000000-7f1688021000 rw-p 00000000 00:00 0
7f1688021000-7f168c000000 ---p 00000000 00:00 0
7f168c000000-7f168c02a000 rw-p 00000000 00:00 0
7f168c02a000-7f1690000000 ---p 00000000 00:00 0
7f1690000000-7f1690021000 rw-p 00000000 00:00 0
# ------ A while lot more of the above - cut because it was hundreds/ possibly thousands of lines
# -----------------------------------------------------------------------------------------------

Native stacktrace:

	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Data/MonoBleedingEdge/MonoEmbedRuntime/libmonobdwgc-2.0.so(+0xd809c) [0x7f175415309c]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Data/MonoBleedingEdge/MonoEmbedRuntime/libmonobdwgc-2.0.so(+0x5be3f) [0x7f17540d6e3f]
	/lib/x86_64-linux-gnu/libpthread.so.0(+0x14bb0) [0x7f195db52bb0]
	/lib/x86_64-linux-gnu/libpthread.so.0(pthread_mutex_lock+0x4) [0x7f195db49824]
	/lib/x86_64-linux-gnu/libnvidia-glcore.so.465.31(+0xda98a9) [0x7f1822e518a9]
	/lib/x86_64-linux-gnu/libGLX_nvidia.so.0(+0x7a267) [0x7f184452b267]
	/lib/x86_64-linux-gnu/libc.so.6(+0x91f30) [0x7f195d9e5f30]
	/lib/x86_64-linux-gnu/libc.so.6(__libc_fork+0x24) [0x7f195da32924]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x384061d) [0x55e3c175761d]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x383f335) [0x55e3c1756335]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x2ac1794) [0x55e3c09d8794]
	/lib/x86_64-linux-gnu/libpthread.so.0(+0x14bb0) [0x7f195db52bb0]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x24af9d8) [0x55e3c03c69d8]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x2deb6c4) [0x55e3c0d026c4]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x2deb5c1) [0x55e3c0d025c1]
	/home/mosthated/Unity/Hub/Editor/2021.1.9f1/Editor/Unity(+0x4965b94) [0x55e3c287cb94]
	/lib/x86_64-linux-gnu/libpthread.so.0(+0x9590) [0x7f195db47590]
	/lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f195da6d223]

Debug info from gdb:

mono_gdb_render_native_backtraces not supported on this platform, unable to find gdb or lldb
Obtained 9 stack frames.
#0  0x0055e3c08b7773 in profiling::Profiler::InitializeUserThread(char const*, char const*)
#1  0x0055e3c0a017a3 in profiling::gc_finalizer_start(void*)
#2  0x007f1754257482 in mono_profiler_set_iomap_report_callback
#3  0x007f175428f9a4 in mono_callspec_cleanup
#4  0x007f1754260cea in mono_threads_set_shutting_down
#5  0x007f17542c2d1b in GC_inner_start_routine
#6  0x007f17542b7851 in GC_call_with_stack_base
#7  0x007f195db47590 in start_thread
#8  0x007f195da6d223 in clone
Launching bug reporter

Thanks,
-MH ------------------------------------

So it always crashes the Editor on launch now? Was it not happening in previous versions?

Wait what? It dies on "Patcher.GUISkinHasLoaded()"?

It looks like it, everything else before that point is pretty typical Unity stuff. This is from just above the Patcher lines from the log.
Application.AssetDatabase Initial Script Refresh End
Application.AssetDatabase.Refresh Start
Refresh completed in 0.250891 seconds.
RefreshInfo: RefreshV2(ForceSynchronousImport) scanfilter:
RefreshProfiler: Total: 249.835ms
Application.AssetDatabase.Refresh End
RefreshInfo: StopAssetImportingV2(ForceSynchronousImport) scanfilter:
RefreshProfiler: Total: 1.802ms
Refresh completed in 0.258507 seconds.
RefreshInfo: RefreshV2(NoUpdateAssetOptions) scanfilter:
RefreshProfiler: Total: 257.750ms
Launched and connected shader compiler UnityShaderCompiler after 0.01 seconds
Initializing Unity extensions:
Refresh completed in 0.155609 seconds.
RefreshInfo: RefreshV2(NoUpdateAssetOptions) scanfilter:
RefreshProfiler: Total: 154.427ms
UpdateMenuTitleForLanguage: 10
Unloading 273 Unused Serialized files (Serialized files now loaded: 0)
System memory in use before: 113.9 MB.
System memory in use after: 113.4 MB.

Unloading 308 unused Assets to reduce memory usage. Loaded Objects now: 4282.
Total: 4.346984 ms (FindLiveObjects: 0.150812 ms CreateObjectMapping: 0.087814 ms MarkObjects: 3.629738 ms  DeleteObjects: 0.478066 ms)

ProgressiveSceneManager::Cancel()
[MODES] ModeService[none].Initialize
[MODES] ModeService[none].LoadModes
[MODES] Loading mode Default (0) for mode-current-id-Test_Project
[LAYOUT] About to load Library/CurrentLayout-default.dwlt, keepMainWindow=False
Unhandled description string [
Unhandled description string ]
Unhandled description string \
[MODES] ModeService[default].InitializeCurrentMode
[MODES] ModeService[default].RaiseModeChanged(default, default)
[MODES] ModeService[default].UpdateModeMenus
Unhandled description string [
Unhandled description string ]
Unhandled description string \
IsTimeToCheckForNewEditor: Update time<PHONE_NUMBER> current<PHONE_NUMBER>
[Project] Loading completed in 16.321 seconds
	Project init time: 				0.151 seconds
		Template init time: 		0.000 seconds
		Package Manager init time: 		0.000 seconds
		Asset Database init time: 		0.000 seconds
		Global illumination init time: 	0.000 seconds
		Assemblies load time: 			0.000 seconds
		Unity extensions init time: 	0.000 seconds
		Asset Database refresh time: 	0.000 seconds
	Scene opening time: 			1.641 seconds
Unhandled description string [
Unhandled description string ]
Unhandled description string \
Unhandled description string [
Unhandled description string ]
Unhandled description string \

NullReferenceException: Object reference not set to an instance of an object
  at AV.Inspector.Patcher.GUISkinHasLoaded () [0x0000d] in /mnt/x/_unity/_test/Test_Project/Assets/Smart-Inspector/Patches/Provider/Patcher.cs:41
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
UnityEngine.<>c:<RegisterUECatcher>b__0_0(Object, UnhandledExceptionEventArgs) (at /home/bokken/buildslave/unity/build/Runtime/Export/Scripting/UnhandledExceptionHandler.bindings.cs:46)

(Filename: Assets/Smart-Inspector/Patches/Provider/Patcher.cs Line: 41)

Can you try to comment out line 32 and 33 in Patcher.Init?

Sure, one sec, I will give it a try.

Unfortunately, that didn't help. Just to see, I commented out the [InitializeOnLoadMethod] of the Patcher init and it loaded just fine, but then I realized that, that method is probably what handles everything this asset is about, lol.

You need to comment out the lines related to GUISkin check, not the whole Init :)

Yeah, I did. I tried commenting 32 and 33 first, but it didn't seem to make a difference. It still closed right away when loading the editor.

But what error it gives in this case? Couldn't be 41 line now

I'd need to try to check this issue later on my Manjaro

This was unfortunately all it gave this last time.
Caught fatal signal - signo:11 code:1 errno:0 addr:0xf893b11
Obtained 2 stack frames.
#0  0x007fc6821a6bb0 in funlockfile
#1  0x00000041f976a7 in (Unknown)
Launching bug reporter
Attribute Qt::AA_EnableHighDpiScaling must be set before QCoreApplication is created.
QObject: Cannot create children for a parent that is in a different thread.
(Parent is QObject(0x10029e0), parent's thread is QThread(0xd163d0), current thread is Thread(0xfbee70)

Looking at how this initializes, I will see if I can remove one of the patches at a time to see which one then allows it to load.

Yes, it should be related to one of patches being injected / initialized at a wrong time, as was with #5

Ok, I changed  to the following and I found what looks like the one:

		static void GetPatches()
		{
			if (patches != null)
				return;
			patches = new List<PatchBase>();

			var patchTypes = TypeCache.GetTypesDerivedFrom(typeof(PatchBase));
			for (var i = 0; i < patchTypes.Count; i++)
			{

				if (i == 5) // Skipping: PropertyEditorPatch - Editor loaded when it skipped this one
				{
					Debug.Log($"Skipping: {patchTypes[i].Name}");
					continue;
				}

				var type = patchTypes[i];
				if (type.IsAbstract)
					continue;

				var instance = Activator.CreateInstance(type) as PatchBase;
				patches.Add(instance);
			}
		}

Hooh, we're getting somewhere! What if you comment out OnEnable and OnDisable patches in PropertyEditorPatch?
These methods are likely to be called during Editor launch

I removed the skip, then made this adjustment, but it crashed as it had before.

        protected override IEnumerable<Patch> GetPatches()
        {
            // var onEnable = AccessTools.Method(PropertyEditorRef.type, "OnEnable");
            // var onDisable = AccessTools.Method(PropertyEditorRef.type, "OnDisable");

            var rebuildContent = AccessTools.Method(PropertyEditorRef.type, "RebuildContentsContainers");
            var endRebuildContent = AccessTools.Method(PropertyEditorRef.type, "EndRebuildContentContainers");

            // yield return new Patch(onEnable, postfix: nameof(OnEnable_));
            // yield return new Patch(onDisable, nameof(_OnDisable));

            yield return new Patch(rebuildContent, nameof(_RebuildContentsContainers), nameof(RebuildContentsContainers_));
            #if UNITY_2020_1_OR_NEWER
            yield return new Patch(endRebuildContent, postfix: nameof(EndRebuildContentContainers_));
            #endif
        }

But it doesn't crash if the rest of these patches / Patch itself is skipped?

If PropertyEditorPatch is skipped from loading via the method I used prior, the editor loads. If I set everything back to normal, but then in PropertyEditorPatch, I make the changes above, it crashes. Did I comment out the proper parts you were referring to?

Yes, but wait. It crashes even when Editor is already launched?

I am not sure, when I made the changes, I closed the editor and reopened it, and it crashed.

When I launch the project with these changes, it crashes.

I understand, but could you try to launch skipping PropertyEditorPatch and then comment it back in?

Should I keep OnEnable and OnDisable commented out, or reenable them first?

You can just skip the whole patch with yield break;

Ok, like this?

    internal class PropertyEditorPatch : PatchBase
    {
        protected override IEnumerable<Patch> GetPatches()
        {
            yield break;
            var onEnable = AccessTools.Method(PropertyEditorRef.type, "OnEnable");
            var onDisable = AccessTools.Method(PropertyEditorRef.type, "OnDisable");

            var rebuildContent = AccessTools.Method(PropertyEditorRef.type, "RebuildContentsContainers");
            var endRebuildContent = AccessTools.Method(PropertyEditorRef.type, "EndRebuildContentContainers");

            yield return new Patch(onEnable, postfix: nameof(OnEnable_));
            yield return new Patch(onDisable, nameof(_OnDisable));

            yield return new Patch(rebuildContent, nameof(_RebuildContentsContainers), nameof(RebuildContentsContainers_));
            #if UNITY_2020_1_OR_NEWER
            yield return new Patch(endRebuildContent, postfix: nameof(EndRebuildContentContainers_));
            #endif
        }

Ok, so with that patch skipped, the editor open, you then want me to remove the skip but keep the yield break; and then recompile?

No, once it's launched, you remove yield break;

Ok, so, I removed the skip, removed the yield, and recompiled and it crashed.

So it cuts down the problem to SmartInspector.OnRebuildContent().
Could you try to comment out RebuildToolbar line in there? That's where ActiveEditorTracker is used the most

I dont see anything with the name of RebuildToolbar within PropertyEditorPatch?

Only inside SmartInspector.OnRebuildContent, yes

I did this, but it crashed:
        /// <see cref="PropertyEditorPatch.RebuildContentsContainers_"/>
        internal void OnRebuildContent(RebuildStage stage)
        {
            RebuildingInspector = this;
            FirstInitOnInspectorIfNeeded();

            //Debug.Log(stage);

            if (stage == RebuildStage.BeforeEditorElements)
            {
                editors.Clear();
                RemoveUserElements();
            }

            if (stage == RebuildStage.BeforeRepaint)
            {
                // RebuildToolbar();
            }

            if (stage == RebuildStage.AfterRepaint)
            {
                // TODO: Fix one-frame issue when dragged element keeps expanded layout of element that was last there
            }
        }

Okay I guess then it also might be caused by SmartInspector.Inject method, or the rest of the OnRebuildContent

Hmm.... I just tried

        internal SmartInspector(EditorWindow propertyEditor)
        {
            this.propertyEditor = propertyEditor;
            // this.tracker = PropertyEditorRef.GetTracker(propertyEditor);
        }

But it still crashed. :(

That doesn't seem right.. Nothing else could be called by PropertyEditorPatch
Could you both comment out tracker and skip Inject method?

Like this?

        internal SmartInspector(EditorWindow propertyEditor)
        {
            this.propertyEditor = propertyEditor;
            // this.tracker = PropertyEditorRef.GetTracker(propertyEditor);
        }

        internal void OnEnable() {}
        internal void OnDisable() {}

        internal void Inject()
        {
            // var result = TryInject();
            //Debug.Log(result);
        }

Still crashed

Okaay... Then I have another assumption - EditorElementPatch.CreateEditorElement causes it.
PropertyEditorPatch.Rebuild creates SmartInspector instance and makes it a RebuildingInspector
Then EditorElementPatch creates and setups the element for it, right after vanilla Init, but one of it's methods causes the crash
Try to comment out line 51 and 52 in EditorElementPatch.Init_

oi, this is not making it easy, is it? lol.
I did the following, but still crashed

        static void Init_(VisualElement __instance, IMGUIContainer ___m_Header, IMGUIContainer ___m_Footer, EditorWindow ___inspectorWindow)
        {
            var smartInspector = SmartInspector.RebuildingInspector;

            // var data = CreateEditorElement(__instance, ___m_Header, ___m_Footer, smartInspector);
            // smartInspector.SetupEditorElement(data);
        }

That ain't right.. Other suspects are still commented out?
I can't think of any other method that can be called during rebuild

Oh, no, I was uncommenting things as we went along so that only the current one asked was commented.

oi, this is not making it easy, is it? lol.

This is made that way because vanilla EditorElement.Init is always called inside PropertyEditor.RebuildContentsContainers

Oh, no, I was uncommenting things as we went along so that only the current one asked was commented.

We need to find the last commented out suspect that fixes the crash :)

Happens to me as well (PopOS 20.10, Unity 2021.1.12f1)

v0.8.0-pre.1 got a Patches UI. It should now be easier to debug this issue.

Here's a config with plugin and patches disabled - Smart Inspector Prefs.zip
It needs to be inside project's Library folder, can be modified before Editor launch.

Ok, nice. I will give it a go and see how it turns out. :+1:

Ok, nice. Adding the prefs to library was able to let me load up the editor. (Side note, this issue page for some reason is lagging my browser terribly. Each letter I type takes 1 second to appear. I have never had that happen on github before, and it is only this particular issue thread. Something I pasted into here must before must be lagging it out.)

What if you disable all other patches but enable PropertyEditorPatch?

Doing that made it so the editor will no longer start.


create-react-app 2.0 + babel 7 issues

Hi,
I get the following error when building using create-react-app version 2 (branch: next).
PS: v2 of create-react-app depends on babel 7.
./node_modules/dumb-reducer/es/index.js
Syntax error: /home/ctaf/src/lana-notes/node_modules/dumb-reducer/es/index.js: Support for the experimental syntax 'objectRestSpread' isn't currently enabled (6:50):

  4 |
  5 | function makeDumbReducer(prefix, initialState = {}, specialReducers = {}) {
> 6 |   return function (state = initialState, { type, ...payload } = {}) {
    |                                                  ^
  7 |     if (type) {
  8 |       if (specialReducers[type]) {
  9 |         return specialReducers[type](state, payload);

Add @babel/plugin-proposal-object-rest-spread (https://git.io/vb4Ss) to the 'plugins' section of your Babel config to enable transformation.

Any idea where the issue comes from?

Right... so... it should have fixed itself. Babel used not to understand the rest/spread syntax by default (it needed a syntax plugin to do that), it does since the release of babel 7 (august 2018).
create-react-app did the upgrade long ago, everything should be fine now. Close?

Yeah it is fixed :)
On Wed, May 29, 2019, 17:22 Quentin Vernot<EMAIL_ADDRESS>wrote:

Closed #3 https://github.com/quentinvernot/dumb-reducer/issues/3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quentinvernot/dumb-reducer/issues/3?email_source=notifications&email_token=AAAL75OJVP7P7U5VBXE52ETPX2GR7A5CNFSM4E25WDVKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORWKCVPY#event-2375297727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAL75JRX5CKSMAO2IA5QDTPX2GR7ANCNFSM4E25WDVA
.


research on notification

research on current notification mechanism and related java class

research the workflow of Shrink/Split/Open index operation;
research the reindex workflow
read the notification design document


When can I use 10.Example section for foxy ?

Hello,
When entering 10,Example section(https://emanual.robotis.com/docs/en/platform/turtlebot3/basic_examples/#move-using-interactive-markers), it says " NOTE: This feature is available for Kinetic, Dashing only."
though i remembered that it was okay for foxy users.
So I wonder when it would be possible to be accessed.
Thanks A LOT!! :)

@boglebogle7
It is guided by Dashing standards, but you can try it in the Foxy version.
Unfortunately, an e-manual Foxy version is not yet planned.
thank you!


User Request: HTTP Disruptions

Note: While chaos-controller is open to the public and we consider all suggestions for improvement, we prioritize feature development that is immediately applicable to chaos engineering initiatives within Datadog. We encourage users to contribute ideas to the repository directly in the form of pull requests!
Is your feature request related to a problem? Please describe.
@scottjr632 and I are interested in disrupting some web services at the application HTTP layer.
Describe the solution you'd like
If this is a desirable feature for Datadog, we are willing to design and implement an HTTP disruption capability. We would provide the design for review by early July to ensure that it lines up with Datadog plans for the controller and then proceed with implementation. We are currently looking into how possible this is to do at the interface/pod level, though it may require some kind of application capability due to the protocol's layer and the encryption of HTTPS.
Describe alternatives you've considered
A network disruption could approximate this functionality, but would be too coarse to target specific HTTP request types or URI endpoints without also disrupting other requests.

This is a desirable feature, and we're willing to collaborate on both/either of design or implementation. We're definitely happy to take suggestions for a design. We hadn't planned to start this anytime soon, so there's no risk of duplicate work (at least not in the near future)

Thank you for the request. It is, indeed, a desirable feature. We haven't designed anything related to this yet but I have some (eventually wrong) ideas in mind.
If the idea is to apply the same disruptions as a network disruption but with filters based on HTTP headers (like the verb, the path, the host, etc.), there is a potential implementation with a combination of iptables and existing network disruptions with tc. iptables rules being applied before tc rules on outgoing packets, you could probably rely on the string extension to match the header and apply a specific mark on the packet so tc can catch it later. However, because headers are encrypted when using HTTPS, it won't work as expected.
The second idea is having a more advanced HTTP feature with response mocking. In this case, like the DNS disruption, you would need to setup a local proxy and redirect outgoing packets to that proxy so it handles them when needed. DNS disruption relies on iptables to redirect packets and it could eventually work the same way. For HTTPS though, it means that you also need to handle the SSL connection and everything that comes with it.

@blazebissar and I have created an initial design doc for this enhancement. Any feedback or critique is welcomed!

I'm curious to see how well the poc performs, but the design looks reasonable

We made some modifications to the design based on a small-scale POC and the comments everyone has made. Later this week we plan to make the POC within the chaos-controller.

We're running a little behind schedule and are anticipating completion of the POC by 24 July.


Add --show-non-errors to jshint

Problem Description
Some unused consts/variables in the code.
Solution Description
Add --show-non-errors to jshint in package.json; add mocha and node to .jshintrc

Thank you @mtrybulec for the cleanup.


Send money - App freezes tapping payment button in send money flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app and login with expensifail account
Click the FAB button  and select Send money
Enter an amount and tap Next button
Select an attendee from the list
Tap the payment selection button.

Expected Result:
User will see onfido flow
Actual Result:
Blank page displayed
Workaround:
Unknown
Platform:

Where is this issue occurring?

iOS
Android

Version Number:
1.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/140234584-fa9f8103-4fbe-4b08-9adc-00a618ebdf8a.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Interesting, the error for this one is
 ERROR  Error: Text strings must be rendered within a <Text> component.

This error is located at:
    in RCTView (at View.js:34)
    in View (at BasePopoverMenu.js:39)
    in RCTView (at View.js:34)
    in View (at BaseModal.js:129)
    in RCTView (at View.js:34)
    in View (at createAnimatedComponent.js:217)
    in AnimatedComponent (at createAnimatedComponent.js:278)
    in AnimatedComponentWrapper (at createAnimatableComponent.js:599)
    in withAnimatable(View) (created by ReactNativeModal)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:107)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:134)
    in AppContainer (at Modal.js:228)
    in RCTView (at View.js:34)
    in View (at Modal.js:249)
    in VirtualizedListContextResetter (at Modal.js:247)
    in RCTModalHostView (at Modal.js:234)
    in Modal (created by ReactNativeModal)
    in ReactNativeModal (at BaseModal.js:75)
    in BaseModal (at BaseModal.js:152)

I initially started looking for PRs in the deploy checklist that added strings without text, but after not seeing any I found https://stackoverflow.com/a/59108109/2509962 which lead me to the problem (we also mention this in our style guide. The error is in https://github.com/Expensify/App/pull/6139, and it seems to be happening because the default value for menuHeaderText is set to an empty string.
One way to fix this is to check _.isEmpty, another way would be to set the default prop to undefined, but in this case I'll go with our style guide recommendation of using an isEmpty check.

Sorry for the slow response on my part here, thanks for handling this @Jag96!


Update dependents and fix frontend issues

introduce namespace helm module to prepare namespace before actual module, earlier this was done using depends_on = kuberay_operator
optmise frontend module to read endpoint from module output and remove addtional data sources.
set l4 node-locations default to us-central1-a for less quota or stockout issues.
disable IAP as default option.
tf plan reduced to 40s to 8s

/gcbrun


Time limited spot requests.

While testing it's best to put a time limit on spot requests so we don't accidentally leave a bunch running wasting money.  This, of course, should be optional

https://trello.com/c/nbYq7IpD/48-time-limited-spot-requests


adding option for installing Open MUL Controller

please add to the main branch

Hi,
Can you please let us know what is required to pull this request?
Thanks,
Saurabh Jain


Feature: Integrate with Burp Session Management APIs

Could be a good solution for renewing session tokens and refreshing csrf tokens.

Decided to not go with this


Unable to use microphone within an iframe implimentation

I am embedding the app within an EHR in an iframe. The record function is throwing a violation.

I have added to the<iframe allow="microphone, popups" ... None of this is working. Is there a way to get the microphone permission popup to show from the iframe? It seems like it would because the Sign In / Create Account overlay works. I know these are different constructs.

Granting microphone permission across different origins (cross-origin) is not possible due to security restrictions enforced by web browsers. These restrictions are in place to protect users' privacy and prevent malicious actions.
When a webpage requests access to the microphone (or camera), the browser prompts the user to grant or deny permission. This prompt is controlled by the browser and cannot be overridden by JavaScript or any other means. The user's decision to grant or deny permission applies only to the current origin (domain), and this decision cannot be extended to other origins.
If you have control over both the parent page and the content within the iframe, and they are served from the same origin, you can follow the approach outlined in my previous response to request microphone permission. However, if the iframe content is served from a different origin, you cannot directly request microphone permission from within the iframe.
One common workaround for cross-origin communication is using the postMessage() API. You can use postMessage() to communicate between the parent page and the iframe, but you cannot directly trigger microphone permission requests in the iframe content if it's served from a different origin. Instead, you could inform the parent page about the user's action and let the parent page handle the permission request. However, the user would still need to explicitly interact with the parent page to grant permission; it cannot be done silently or programmatically without user interaction.


chore(RHTAPWATCH-327): offboard o11y prometheus rules

The Prometheus rules coming from the o11y repo should not be deployed to RHTAP using argoCD. Instead, they are to be deployed using app-interface.
Later on we might want to offboard the o11y component altogether

@amisstea @Kousalya1998 please take a look

lgtm


some typos

i think there are some typos like this one from s3 section
S3 is a universal namespace, the name must be unique globally. So you can have the same name as someone else.
should it not be cannot have same name here?

Hi!
Thanks for reporting that, you are right, you can't have bucket names having the same name as someone else.
Will fix it :bowing_man:

Hi!
Thanks for reporting that, you are right, you can't have bucket names having the same name as someone else.
Will fix it thanks! :bowing_man:


Payment Module, Problem

Once someone paid from membership module (paypal for example), browse and the functualitie from the account dos not chance

Has been fixed here https://github.com/pH7Software/pH7-Social-Dating-CMS/commit/7308ce0a31c62c6ea352f957985ac4415213efab


fix: settings page ui [CU-24vxzym]

Summary
What does this PR do/solve?

Align Settings Page UI with design guidelines

Task linked: CU-24vxzym Align Settings page UI with design guidelines


Drop support for DataONE

Currently we are unable to update a significant portion of the stack due to: https://github.com/DataONEorg/d1_python/issues/40
Usage tracking shows limited activity (only people I can identify as devs, which could be probably tracked to testing) in both registering and publishing to test DataONE instances. The "Analyze in Whole Tale" button developed during the course of original WT NSF proposal was never adopted and deployed upstream.

Note
Data currently registered, and therefore Tales using it, will continue to work.

Also noting that publishing was only supported for dev instances of Metacat. We were not allowed to publish to any production environment.

ok, thanks. Yeah, that python issue is a pain. And something we do need to get resolved on multiple fronts.  And I was frustrated that the Analyze in Whole Tale button never became reliable enough to deploy to production -- it was so close. Thanks for the clarification as to why it needs to be removed.
We still do have people with interest in Whole Tale from DataONE, most recently a new Army Corps project with interest in running containerized models against repository data. I talked with Bertram about this last year, although it didn't get the funding it needed. I hope that, were we able to get a project like this funded, we could revisit this (and invest in getting it working again).

ok, thanks. Yeah, that python issue is a pain. And something we do need to get resolved on multiple fronts. And I was frustrated that the Analyze in Whole Tale button never became reliable enough to deploy to production -- it was so close. Thanks for the clarification as to why it needs to be removed.

I'm gonna note that we're dropping only the publishing part. Analyze in WT (and registering from DataONE in general) is still working and will still work, cause @ThomasThelen and @amoeba implemented that using raw http requests (kudos to them for that decision).

Thanks, that is valuable to know. Our DRP group might indeed take advantage of that feature.

And I was frustrated that the Analyze in Whole Tale button never became reliable enough to deploy to production -- it was so close.

The fact that the button was never deployed on DataONE is a frustration for me as well, considering the effort put into the integration. That and we were only ever allowed to enable publishing to https://dev.nceas.ucsb.edu/.
Was there ever any issue reported about the reliability issues? I assume this is from long ago?

Yes, from when our team at UCSB was working on it. The problem from my perspective was that every deployed beta that I tried had an error that did not work properly in some fundamental way -- i think mostly in terms of publishing to DataONE.  My perspective was that Tommy got it 95% of the way there, but it wasn't ready for users as they would have had a bad experience. All of that was on me for not managing our part of the project well enough to deliver it, and I would still see my team finishing any work on this before we deployed it. Tommy has left our group for another position, so if we did some work on this it would be with a different developer. So, please don't take my comments badly -- I was just lamenting that I didn't quite get it there, and still have HOPE, so was disappointed to see code being removed that we might build on later. But I fully understand that you need to make the current app work with the current constraints, so don't let me get in the way of that viability.


document how to include a brainsprite as an iframe using nilearn

To generate a sprite in Python for a T1w image I did the following:
from nilearn.plotting import view_img
import nibabel as nib

img = nib.load("my_image.nii.gz")
html_view = plotting.view_img(img, bg_img=None, colorbar=False,
                              annnotate=False, cmap="gray",
                              symmetric_cmap=False, black_bg=True)
html_view.save_as_html("my_sprite.html")

Then for including it in a page, I just did the following
<iframe src="my_sprite.html" height=250 style="padding:0; border:0"></iframe>

Note: this doesn't include anything like adjusting the vmin and vmax to improve contrast, etc...

One thing I'd love documentation for, if possible, is how to add a contour to a nilearn-generated brainsprite. I know from #25 that these contours need to be generated in 3D -- still unclear to me how that can be incorporated when calling from nilearn !

This issue is too old. Closing.

mmmhh the snippet actually badly needs to land in the docs. Re-opening with appropriate label.


[BUG]: Dispatches endpoint only returning 10 or so items

Link to faulty endpoint
https://helldivers-2-dotnet.fly.dev/api/v1/dispatches
The name of your client/application
Mozilla FireFox
Request information
Need to include the maxEntries query param to the url.
Steps to reproduce
Load https://helldivers-2-dotnet.fly.dev/api/v1/dispatches in a browser.
What is expected?
Returns all newsfeed items
What is actually happening?
Only returns the first 10 or so

System Info
Windows 10
Firefox

Any additional comments?
No

It looks like "message" is returning null for each entry as well

message does seem to return messages for me, might've been a temporary outage


Scan for ES6 methods in moduleMocker.js

Fixes https://github.com/facebook/jest/issues/332
It's not clear to me if/how I could add a test for this. It depends on attempting to mock a module that exports an ES6 class or instance. If it needs a test to be merged and you can provide some guidance I'll add it.

There are two hard things in computer science: cache invalidation, naming things, and off-by-one errors.

I'm not sure scan is an ideal name, but I don't have anything better at the moment.

cc @jeffmo

Now I understand how generateFromMetadata works, so I was able to write a test for this.

I think we should go with this PR, but we need to support all methods on classes, including those that override defaults (like toString).
So, will something like this be sufficient:
/**
 * Returns all properties in the prototype chain,
 * including non-enumerable (to support mocking of
 * ES6 class methods). Doesn't consider Object.prototype
 * at traversing.
 */
function getSlots(object) {
  var slots = {};
  do {
    Object.getOwnPropertyNames(object).forEach(function(prop) {
      slots[prop] = true;
    });
    object = Object.getPrototypeOf(object);
  } while (object !== Object.prototype);
  return Object.keys(slots);
}

// tests

var foo = Object.create(Object.prototype, {
  m1: {value: function() {}},
  m2: {value: function() {}},
  m3: {value: function() {}},
  m4: {value: function() {}, enumerable: true},
  p1: {value: 10, enumerable: true},
});

var bar = Object.create(foo, {
  toString: {value: function() {}},
  m5: {value: function() {}},
  m6: {value: function() {}, enumerable: true},
});

// ["toString", "m5", "m6", "m1", "m2", "m3", "m4", "p1"]
console.log(getSlots(bar));

And then the usage will be:
getSlots(metadata.members).forEach(function(slot) {
  ...
});

I added this then ran with --runInBand. Under some situations we actually get an infinite loop. I'm fairly sure it's because modules are loaded from a different context but I don't know how to prove it.
   var object = obj;
   var j = 0;
   do {
     console.log(j++);
     if (object) {
      object = Object.getPrototypeOf(object);

     }
  } while (object !== Object.prototype);

originally I was thinking we didn't need to mock any built in functions, and we can't find them under normal circumstances since they aren't enumerable. I think you're right though, the former behavior would have found overridden built in functions.

I just committed a variation of your recommended changes. I also added a test to verify that toString gets mocked when you override the default implementation.

I switched to getSlots(object) and then squashed all my changes into one commit. Thanks for the help on this.

OK, let's go with this version. Thanks for this fix!

:santa:

Just in case anyone else stumbles upon this, if you have a module doing
export {
    foo: Immutable.Map() // Any Iterable
}

Immutable.js will throw iterable.length has been deprecated warnings when running tests because getSlots() touches length too.

Yeah, the mocker should consider accessor properties and not to call an accessor function. See the #389.


Placeholder raises ConstructorError

yaml.constructor.ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:PLACEHOLDER!!'

https://github.com/rafaribe/home-ops/actions/runs/9650191118/job/26615316089#step:8:1919
https://github.com/rafaribe/home-ops/actions/runs/9650337292/job/26615770418#step:8:1878

This was changed in https://github.com/allenporter/flux-local/pull/620


Autosave

What does your feature do?
Autosave quests being edited or created.
How would people use it?
When someone is editing a quest or creating a quest auto save it every 3 mins to avoid data loss. I just spent an hour creating a quest and suddenly i was no longer in the editor and when i went to give the next command it just typed the number into chat.

Thanks for your report. Unfortunately, this isn’t possible when creating a quest as the user may not have filled out all required fields. As for editing a quest, I can’t think of any situations where the user would make a large enough edit to warrant auto-saving. Feel free to correct me on this if anything comes to mind.

Its entirely possible. It may just require spme extra thought and work from
a programming perspective. Save it to its own seperate yml configuration
that can be loaded up later or something. I was technically doing an edit
as i saved it then came back to it the next day because the process of
creating takes so damn long.
On Thu, Feb 20, 2020, 7:17 PM PikaMug<EMAIL_ADDRESS>wrote:

Thanks for your report. Unfortunately, this isn’t possible when creating a
quest as the user may not have filled out all required fields. As for
editing a quest, I can’t think of any situations where the user would make
a large enough edit to warrant auto-saving. Feel free to correct me on this
if anything comes to mind.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PikaMug/Quests/issues/1088?email_source=notifications&email_token=AAHS26HHVJYPPDK4LE5ETR3RD4MQTA5CNFSM4KYZIMJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRBOAY#issuecomment-589436675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHS26CYALJJOFQFGSEAYATRD4MQTANCNFSM4KYZIMJA
.

What I meant is that it isn’t possible with how the editor is currently programmed. Feel free to submit a pull request.
Could you please elaborate? I’m able to make a basic quest in a matter of minutes. What exactly are you doing that takes so long?

Closing to due lack of response from OP.


Wrong display resolution and scale detection.[BUG]

I launched compiled Windows executable of autogguf tool on my laptop, which screen resolution is 1920x1080p and got very small gui controls:

It is very difficult to use your app while buttons and other controls are so tiny.

Fixed in this commit: https://github.com/leafspark/AutoGGUF/commit/cb51a22d2f6c0524393105b7335f32a88180a34d
Here's the prebuilt binary: https://github.com/leafspark/AutoGGUF/releases/tag/v1.5.0
Changes:

The entire window should be scrollable now.

Thank you.


Reduce scope of sync_tables

Addresses some first steps of #245

Removes nobs columns from critical columns, no longer generates them from source in _generate_object_table()
Sync_tables now just aligns indices, no generation of nobs information
Adds the notion of temporary columns, which are removed when syncs occur
Updates prune() to use an existing nobs column if provided, but otherwise calls calc_nobs() as part of the operation

@hombit I can't seem to reply in line with the question re: why the reset_index.set_index is needed. The problem in some cases seems to be that the grouping is done on the source table, so the source partitions are preserved. And the divisions are not known unless they were known for source. The assign call seems to have issues when the divisions for object are known, but the divisions for the new pandas series to assign are not. That being said, I wonder if it'd resolve better if I tried to remove the division information from object, might give that a go


ES6

Sprockets 4.x will have first class support for ES6 via 6to5.
/cc @dgraham @sebmck @thejameskyle

:+1: excited for this!

Also very excited for this!

That's really cool!

Oh great!

:+1:
@josh is this in Rails or in development?

:+1:

:+1:

:+1:

:+1:


Do not include cookies with empty value

I got the following error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 518, in thread_handler
    raise exc_info[1]
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 42, in inner
    response = await get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/asgiref/sync.py", line 518, in thread_handler
    raise exc_info[1]
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/base.py", line 253, in _get_response_async
    response = await wrapped_callback(
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/views/decorators/clickjacking.py", line 50, in _view_wrapper
    response = await view_func(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/website/app_next/views.py", line 37, in get
    return await nextjs_request(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/website/app_next/functions.py", line 8, in nextjs_request
    return await render_nextjs_page(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django_nextjs/render.py", line 149, in render_nextjs_page
    content, status, response_headers = await _render_nextjs_page_to_string(
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django_nextjs/render.py", line 102, in _render_nextjs_page_to_string
    async with aiohttp.ClientSession(
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client.py", line 305, in __init__
    self._cookie_jar.update_cookies(cookies)
  File "/usr/local/lib/python3.11/site-packages/aiohttp/cookiejar.py", line 179, in update_cookies
    tmp[name] = cookie  # type: ignore[assignment]
    ~~~^^^^^^
  File "/usr/local/lib/python3.11/http/cookies.py", line 498, in __setitem__
    self.__set(key, rval, cval)
  File "/usr/local/lib/python3.11/http/cookies.py", line 488, in __set
    M.set(key, real_value, coded_value)
  File "/usr/local/lib/python3.11/http/cookies.py", line 353, in set
    raise CookieError('Illegal key %r' % (key,))
http.cookies.CookieError: Illegal key ''

To fix this I added an extra check that the cookie is not passed through when the value of the cookie is empty.

The error appears to be with an empty cookie key, not the value:
  File "/usr/local/lib/python3.11/http/cookies.py", line 498, in __setitem__
    self.__set(key, rval, cval)
  File "/usr/local/lib/python3.11/http/cookies.py", line 488, in __set
    M.set(key, real_value, coded_value)
  File "/usr/local/lib/python3.11/http/cookies.py", line 353, in set
    raise CookieError('Illegal key %r' % (key,))
http.cookies.CookieError: Illegal key ''

The error appears to be with an empty cookie key, not the value:
  File "/usr/local/lib/python3.11/http/cookies.py", line 498, in __setitem__
    self.__set(key, rval, cval)
  File "/usr/local/lib/python3.11/http/cookies.py", line 488, in __set
    M.set(key, real_value, coded_value)
  File "/usr/local/lib/python3.11/http/cookies.py", line 353, in set
    raise CookieError('Illegal key %r' % (key,))
http.cookies.CookieError: Illegal key ''

Empty value works:
curl 'http://localhost:8000/magnet/jobs' -H 'Cookie: key='

However, supplying an empty key would result in the same error as mentioned:
curl 'http://localhost:8000/magnet/jobs' -H 'Cookie: =value'

My bad, it has been fixed with the new commit.

No problem 🙏🏼
Since the value itself isn't an issue, we can skip filtering cookies based on their values. We only need to filter if the key is empty.

I have also allowed passing cookies with empty value in 4fb93a99 since it's not causing exceptions.


python311Packages.pycep-parser: 0.4.1 -> 0.4.2

Diff: https://github.com/gruebel/pycep/compare/refs/tags/0.4.1...0.4.2
Changelog: https://github.com/gruebel/pycep/blob/0.4.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265808 run on x86_64-linux 1

6 packages built:

checkov
checkov.dist
python310Packages.pycep-parser
python310Packages.pycep-parser.dist
python311Packages.pycep-parser
python311Packages.pycep-parser.dist


JS: async/await

Target JS to ES6 (you can always transpile it with a transpiler)
Use async/await pattern to enable support for synchronous I/O and threads
Partially implementation of https://github.com/jtransc/jtransc/issues/265 (but just for JS)

Wouldn't it be by far easier to implicitly mark all methods as @JTranscSync and only async methods as JTranscAsync?

@intrigus Yes, it would be easier. But I wanted two things:

Allow to mark some functions synchronous to ensure at compile-time
Validate this before investing time into implementing the implicit marking


HarfBuzz failures with harfbuzz 1.7.2

Failing test run https://github.com/pdf-raku/HarfBuzz-raku/runs/1906311023.
I've been able to replicater this locally on a locally built harfbuzz 1.7.2

That corresponds to Debian 10. Debian 11 has HarfBuzz version 2.7.2

Multiple problems with Debian 10 / harfbuzz 1.7.2 and Debian 11 / harfbuzz 2.7.2 is testing.
Along with this issue, HarfBuzz::Subset needs the libharfbuzz-subset library, which I don't think even Debian 11 packages.
I'm planning to solve these issue, (in the short term at least), by building harfbuzz from source.

Building from source is complicated by downstream module HarfBuzz::Subset. Uses libharfbuzz-subset, which references symbols from libharfbuzz. Can't be configured to be fully static.


fix: override fetch search params entries

Hey,
we encountered with the error:
this change fixed it when i tried locally.
 {
      error: TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator))
          at Function.fromEntries (<anonymous>)
          at /Users/amitshw/github/wix-one-app-portal-platform/node_modules/netmock-js/lib/overrideFetch.js:41:34
          at Generator.next (<anonymous>)
          at /Users/amitshw/github/wix-one-app-portal-platform/node_modules/netmock-js/lib/overrideFetch.js:8:71
          at new Promise (<anonymous>)
          at new TrackedPromise (/Users/amitshw/github/wix-one-app-portal-platform/node_modules/@wix/amino/dist/src/jest-setup.js:140:13)
          at Object.<anonymous>.__awaiter (/Users/amitshw/github/wix-one-app-portal-platform/node_modules/netmock-js/lib/overrideFetch.js:4:12)
          at fetch (/Users/amitshw/github/wix-one-app-portal-platform/node_modules/netmock-js/lib/overrideFetch.js:22:37)
          at func (/Users/amitshw/github/wix-one-app-portal-platform/node_modules/wix-one-app-engine/src/engine/WixFetch/WixFetch.ts:153:46)
          at InFlightMap.launch (/Users/amitshw/github/wix-one-app-portal-platform/node_modules/wix-one-app-engine/src/engine/WixFetch/inFlightMap.ts:37:5) {
        metadata: {
          url: 'https://wix-life.com/_functions/v1/search',
          requestParams: [Object],
          retryIndex: 2
        }
      }
    }

@AmitShwarts I figured out the problem - react-native-url-polyfill  it has a different implementation for URLSearchParams 🤦🏻
Are you able to remove it from your project?
Do you know why it's there?
It also comes from @wix/bookings-mobile-owner  and needs to be removed.
See test commit - https://github.com/wix-private/wix-one-app-portal-platform/pull/448/commits/1d98dd380de574b061d8df23f0bba6f6ebaa82a2

react-native-url-polyfill

@AmitShwarts Another option is to simply add jest.mock('react-native-url-polyfill'); to your jest-setup.
But I'd still recommend understanding why you need this lib

react-native-url-polyfill

@AmitShwarts Another option is to simply add jest.mock('react-native-url-polyfill'); to your jest-setup. But I'd still recommend understanding why you need this lib

Thanks @doronpr !
we will mock it until we'll be able to remove this lib.


[improve][cli] Supports creating tokens with additional headers

Motivation
Currently, the tool that generates the token cannot attach headers. We should support it. For example, it makes sense to attach a kid field for JWKS.
Modifications
Supports creating tokens with additional headers
Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[x] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

/pulsarbot rerun-failure-checks

@lhotari @heesung-sn Could you help take a look ?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.16%. Comparing base (bbc6224) to head (aef7cfc).
Report is 281 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22690      +/-   ##
============================================
- Coverage     73.57%   73.16%   -0.41%
- Complexity    32624    32849     +225
============================================
  Files          1877     1889      +12
  Lines        139502   141401    +1899
  Branches      15299    15517     +218
============================================
+ Hits         102638   103457     +819
- Misses        28908    29937    +1029
- Partials       7956     8007      +51

Flag
Coverage Δ

inttests
27.43% <0.00%> (+2.85%)
:arrow_up:

systests
24.75% <0.00%> (+0.42%)
:arrow_up:

unittests
72.15% <100.00%> (-0.69%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...ar/broker/authentication/utils/AuthTokenUtils.java
77.27% <100.00%> (+1.08%)
:arrow_up:

...pache/pulsar/utils/auth/tokens/TokensCliUtils.java
39.28% <100.00%> (+11.42%)
:arrow_up:

... and 371 files with indirect coverage changes


Use the HaplotypeCaller calls QC metrics

In the HaplotypeCaller calls we can check the common SNPs whether the two are the same: it can serve as a QC metric, i.e.to make sure the patients are not mixed up

Transferred to the new nf-core/sarek repo


LUCI logs making determing why tests fail harder

Message from @pedromassango in https://github.com/flutter/flutter/issues/67144#issuecomment-708664186:

It is really hard to find out and see why tests are failing in the LUCI interface. It simply hide all the build logs. I think it was better before.

cc @godofredoc

Not sure what we mean by hiding:

Was a build failing and not showing up in github ui?
Was a build failing and showing up as green?
Was a build passing when it was expected to fail?

If any of those is happening we should mark it as a P0. Having too much logging that is difficult to find the real problem is a known issue that will be addressed in Q1-Q2 next year.

I found out the LUCI interface too complex to find the build logs and to navigate overall. In my message mentioned in the OP, I was trying to find the logs because one of the build steps was failing.

Was a build failing and not showing up in github ui?

GitHub showed it as failed but when you clicked on "Details" it was did not redirected me to the build logs (as used to be without LUCI, if I remember it right).

Was a build failing and showing up as green?

No, a build failed and showed as red.

Was a build passing when it was expected to fail?

No.
I've shared my feedback on Discord and here is the links to my messages for reference, (please see it):
https://discord.com/channels/608014603317936148/608021351567065092/764921764626300968
You can scroll down to see the rest of the messages until you find:
https://discord.com/channels/608014603317936148/608021351567065092/766052758553362454
Then, I found out that I need to click "stdout" to see the logs:
https://discord.com/channels/608014603317936148/608021351567065092/766055503109029910
I think @jmagman had some difficulties to use the new UI as well:
https://discord.com/channels/608014603317936148/608021351567065092/766057345972699147

Closing this issue as a duplicate of https://github.com/flutter/flutter/issues/64208


configure_me_codegen retroactively reserved on our bind_host parame…

Which issue does this PR close?
Closes #519.
Rationale for this change
Described in issue.
What changes are included in this PR?
Pin an old version until we can fix properly.
Are there any user-facing changes?
The build works.

This is 1 breakage less than master... perhaps we can merge this?


Please add an unminified version in /dist

I know that there is a raw version at index.js - but it's unwrapped.
I have a workflow that pulls down all libs with raw github URLs, then bundle all libs together in one single libs.js, and then minify that libs.js myself.

You can minify it twice, it doesn't affect the final build.
I'd wary of your workflow, if a developer changes the position of a file your URL will be a 404 and the build will fail. I suggest using npm at least as you can rely on a semantic versioning (plus it includes the unminified library)

On several occasions, after running minified code through gulp-uglify the end result is a javascript error that says something like unexpected variable l in .... on line 1. I have no idea why Uglify does this, but so far it has never given me trouble for unminified sources.
As for my workflow - not everything is on NPM, not everything is on bower, I can't control filenames or the order, and I just feel blind when pulling in things that way. Developers have different ideas what a "distribution" version is, some include minified versions, some unminified versions, and some split the "distribution version" into 3 separate files that you have to include in a particular order.
I have a YAML file with a list of library names and URLs. When I build libs.js - it pulls fresh libraries, immediately notifying me if the destination file isn't found. I use git for version management, and because I'm always pulling unminified sources, I can see line-by-line diff, not just a changelog. On top of that - all my dev builds are unminified, and when I build for release, everything is beautifully uglified.
In 2 years, I've encountered a problem where the destination changed only 1 time. I fixed that in 25 seconds. When I was using a "package manager" like bower - I had to tinker almost with each library to pull it in properly.
It's probably not a big deal for you to add an unminified version in your /dist folder, since you're using something to compile from ES2015 already.
p.s. The Polyfill source is ES2015 ? A little ironic :)

Sorry to be such a party pooper, but if uglify gives you an error I would suggest opening an issue on their repo and it will help everybody every time. If currently there are no issues with IIV you can already use its minified version. As you said developers have different ideas on what a distribution version is and currently I prefer not posting anything but the minified browser build to GitHub.
PS: No irony, it just simplifies development and with bublé the output is still neat. :)

This was fixed in UglifyJS 2.7.0 a couple months ago, please update it to fix the issue :)

Also, the unminified version is now in v3 ;)
https://github.com/bfred-it/object-fit-images/blob/master/dist/ofi.js

Thanks & Thanks 👍


Changing queues and the quickly clicking a slide in the timeline causes an error

Changing queues in the editor and then quickly clicking a slide before the new queue loads causes a JavaScript error.

This should now be fixed in 69d8ec2288c36989c65bc22dd02b318c36834a1e.


{bp-15373} Documentation: add NuttX 12.8.0 Release notes

Summary
add NuttX 12.8.0 Release notes
add NuttX 12.7.0 Release notes
Impact
RELEASE
Testing
NONE

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX requirements.  While it mentions adding release notes, it lacks crucial details.
Here's why:

Insufficient Summary:  Simply stating "add release notes" isn't enough.  The summary should explain what changes are included in those release notes (bug fixes, new features, etc.), which parts of NuttX are affected, and how these changes work.
 It needs to specify the impact on users, the build process, hardware, documentation, security, and compatibility based on the changes listed in the release notes.  For example, if a new feature is introduced, how will users use it? Does it require any configuration changes?  Are any existing features deprecated?
Missing Testing: "NONE" is unacceptable for a release.  Release notes imply changes, and changes require testing. The PR needs to demonstrate that the documented changes work as intended.  Even if the changes themselves weren't tested as part of this specific PR (because they were tested in previous PRs), the release notes should be tested for accuracy and completeness.  At a minimum, the PR should confirm that the release notes accurately reflect the changes included in the release.

In short, the PR needs to elaborate significantly on what changes are being documented, how they impact NuttX, and provide evidence that the release notes themselves are accurate and complete.


Just using the segmentation part

Hi I was looking to just fine tune the segmentation part for my down stream task. Could you please let me know how to get that as both object detection and segmentation are there
And is there a way to just get the bit mask of the segmentation or do i need to change the code for that in some files?
lastly, what would be the best config for fine tuning models for mask dino?

Hi, I think you only need to finetune the decoder part, it is lightweight and contains both detection and segmentaiton.


bump version number

let's wait till #547

Oops... will need to bump it again.

huh? you published before merging?

yep :(

Everything is good now.


Segmentation fault if two methods of same text fixture have same name.

https://github.com/lucidguppy/BowlingKata
commit :  156255cc75ee5cd1e89c38c91013e93f90125929
If two methods have the same name it does a segmentation fault.  It might be nice to have a static assert to check for this somehow.

Since there has been no followup, I am going to close this and assume it works. If not, please reopen.


Fix remaining issues with the new language switcher

The new language switcher does not yet work for me :( I installed the most recent version on bio26.edgeryders.eu and did a clean build (yarn install && yarn run build) but so far, no language switcher appears.
There are two problems that I could identify:

The VUE_APP_LANG parameter was removed in one of the last commits but is still needed in src/helpers/discourse.js l. 3. So without the parameter present in .env.production, the application will not start (showing a "white screen of death").

The English language strings are compiled into the resulting dist/* files by yarn, but not the Slovenian language strings. At least it appears that way from me doing grep -R "Dobrodo" ./dist/*.

I've pushed up a fix for discourse.js relying on VUE_APP_LANG (it doesn't anymore); I was hoping to wait on it (since we don't have SL-translated error messages anyhow), but hopefully that should fix it up.
A quick peek at the resultant app..js makes me think that the SL translations are getting included alright:

^^ (this is from running yarn run build)
Let me know if that patches things up for you?

Let me know if that patches things up for you?

Yes, both issues are gone now :-) (See bio26.edgeryders.eu.)


Add Synology install instructions

@andypiper wrote some here, we should adapt that into the official docs: https://andypiper.co.uk/2023/07/05/running-a-3d-print-catalogue-with-van-dam/

... 😬 I should probably check that's still valid!

Heh - well, it's linked from the main website now! https://manyfold.app/get-started/synology-nas.html
(I'll replace it at some point with an official set of instructions)

I'll try to update my installation from VanDAM to Manyfold this weekend.


Introduce a controlled env for pex testing.

Although this could be used as a stepping stone to containerized
Travis CI, in the short term it helps me have a working test
environment. The pex.testing.ensure_python_interpreter fails to
install CPython 2.7.9, 2.7.10, etc. on Arch Linux atm.

Supports work on #509 and #510.

N.B: This allows me to run test_interpreter.py green where I couldn't before via:
./dtox.sh -epy27-requests -- -vktest_interpreter.py


accept everything between 200 and 299

see #70

CC @pusher/sigsdk

LGTM 👍

@hamchapman ChatKitJS needs to be updated to get this change or none of the examples work:
https://github.com/pusher/chatkit-client-js/issues/3


Corrected tutorial code

Added displayInIframe option to dialogs for better experience in browser
Moved event.completed call until after the dialog is resolved

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/addin-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


corrected doc string for example - on windows, folder is winx64

in function doc strings for launch_mapdl the examples were not pointing to the correct folder or exe.

while in the examples it is without x, which may lead to confusion

I'm merging this without all the checks passed because this PR was created before @kmahajan-cadfem were an approved collaborator, so it does not have access to the secrets.


Add support project_id from connection configuration in MLEngine

This will break compatibility as project_id is first argument in hook methods.

Done. https://github.com/apache/airflow/pull/6286


fix: remove lodash-es

Maybe better completely get rid from lodash?

Btw does it play with tsdx?

To test the impact of a change like this we need to test the impact of file size on the following for both a CJS and ESM project:

impact on a project that only imports formik and react
impact on a project that imports formik, react and lodash
impact on a project that imports formik, react, and lodash-es
impact on a project that imports formik, react, and lodash and uses the webpack lodash plugin
impact on a project that imports formik, react, and lodash-es and uses the webpack lodash plugin
impact on a project that imports formik, react, and lodash and uses the alias technique below
impact on a project that imports formik, react, and lodash-es and uses the alias technique in reverse:

// webpack.config.js or whatever
webpackConfig.resolve.alias = {
  lodash: 'lodash-es',
};

https://github.com/formium/formik/issues/2602#issuecomment-658296674
My theory is that we go ahead and use lodash because it is the standard and users are far more likely to have imported it than lodash-es. However, the caveat is that we should all of our imports within Formik should use the following format:
import join from 'lodash/join';

I think if we combine those two changes, and instruct users to use the webpack lodash plugin, that may be the silver bullet solution to solving this issue in userland for v3. But we'll want to test and make sure webpack lodash plugin can correctly alias lodash/join type imports first.
Evidence that lodash is more popular than lodash-es: https://www.npmtrends.com/lodash-vs-lodash-es

(we also may get rid of lodash completely depending on the API of v3)

@johnrom I was just trying formik in a webpack project and was seeing both lodash being included in the final bundle. Not much impact on bundle size, as were named imported but no sense of having duplicate codes.

@maddhruv that is one of the many different package configurations I listed, all of which will have different effects.
if your project used lodash-es (which some certainly do) you would received duplicate packages with this PR, for example
I still agree with this change, though as mentioned above I think we should go above and beyond to limit the scope of our imports since lodash isn't tree-shakeable (I don't think?) and make sure that webpack lodash plugin can optimize them to create the lowest total package size across all common project types. This will also affect people's packages in a big way so this is likely something we should punt to v3.

TSDX intelligently bundles lodash and treeshakes properly.
https://tsdx.io/optimization#using-lodash
However, I would like to get rid of lodash altogether. I haven't yet found an equivalent of toPath that supports brackets.

@jaredpalmer I mean will tsdx continue to work when lodash-es is removed?

Haven't tried, my guess is it will not.

AFAIK implementation is still your original one from back when formik handled its own build.

lodash-es hasn't had a release since 4.17.15 and so is subject to a bunch of vulnerabilities v.s. lodash 4.17.20 which has none of them. See https://snyk.io/test/npm/lodash/4.17.15

Someday they may lost an access to lodash package as well 🤷♂

I don't think anyone is advocating that we keep lodash-es for no reason, but I do recommend a bunch of mitigations above that need to be considered before merging this, and this should probably be shipped with v3 and not v2 for those who have already solved the duplication in their projects another way, unless we can prove in all situations I listed above this doesn't have a negative impact.

I am open to removing lodash in v3 but we need to do it gracefully with warnings in v2 if there are any backwards incompatible changes (such as bracket path references)

lodash-es hasn't had a release since 4.17.15 and so is subject to a bunch of vulnerabilities v.s. lodash 4.17.20 which has none of them. See https://snyk.io/test/npm/lodash/4.17.15

This bit looks fixed now. See https://github.com/lodash/lodash/issues/4879#issuecomment-748571123

lodash-es hasn't had a release since 4.17.15 and so is subject to a bunch of vulnerabilities v.s. lodash 4.17.20 which has none of them. See https://snyk.io/test/npm/lodash/4.17.15

This bit looks fixed now. See https://github.com/lodash/lodash/issues/4879#issuecomment-748571123

Maybe better completely get rid from lodash?

@TrySound I'm 💯 in favor of this. 75kb (ungzipped) is a lot..


[MINOR][DOCS][K8S] Use hadoop-aws 3.2.0 in K8s example

What changes were proposed in this pull request?
This PR aims to update Hadoop dependency in K8S doc example.
Why are the changes needed?
Apache Spark 3.1.1 is using Apache Hadoop 3.2.0 by default.
Does this PR introduce any user-facing change?
No. This is a doc-only change.
How was this patch tested?
N/A

cc @HyukjinKwon
I found this during RC3 doc reviews. Just a minor fix for 3.1.2 release.

Merged to branch-3.1.

Test build #135394 has started for PR 31629 at commit 6524bd0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39974/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135394/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39974/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39974/

Thank you!


WARN precision

I got WARN: Box bound precision lowered by casting to float32 when I run the code. Should this be fixed?

Should be ok, I get this warning as well on some machines - the method is
not sensitive to float64 -> 32 casting
On Sun, May 10, 2020 at 9:48 PM Ian Zhao<EMAIL_ADDRESS>wrote:

I got WARN: Box bound precision lowered by casting to float32 when I
run the code. Should this be fixed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MishaLaskin/curl/issues/6, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHWQWJQFZ6PXF5HQCZYASTRQ5KOXANCNFSM4M5QBMVA
.

Thanks a lot :)

Hi, when I run the task "Cheetah, Run", it costs about 65s for every four episodes. Is it ok or did I make some mistakes?
I run the code on TITAN RTX.
The run.sh is:
CUDA_VISIBLE_DEVICES=2 python train.py
--domain_name cheetah
--task_name run
--encoder_type pixel
--action_repeat 4
--save_tb --pre_transform_image_size 100 --image_size 84
--work_dir ./tmp
--agent curl_sac --frame_stack 3
--seed -1 --critic_lr 2e-4 --actor_lr 2e-4 --encoder_lr 2e-4 --eval_freq 10000 --batch_size 512 --num_train_steps 100000

That's normal - large batch sizes take a long time to train
On Thu, May 14, 2020 at 1:48 AM Ian Zhao<EMAIL_ADDRESS>wrote:

Hi, when I run the task "Cheetah, Run", it costs about 65s for every four
episodes. Is it ok or did I make some mistakes?
I run the code on TITAN RTX.
The run.sh is:
CUDA_VISIBLE_DEVICES=2 python train.py
--domain_name cheetah
--task_name run
--encoder_type pixel
--action_repeat 4
--save_tb --pre_transform_image_size 100 --image_size 84
--work_dir ./tmp
--agent curl_sac --frame_stack 3
--seed -1 --critic_lr 2e-4 --actor_lr 2e-4 --encoder_lr 2e-4 --eval_freq
10000 --batch_size 512 --num_train_steps 100000
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MishaLaskin/curl/issues/6#issuecomment-628401763, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHWQWMIPKW2KTW7OT3CDU3RROA37ANCNFSM4M5QBMVA
.

Thanks for your reply!


Remove bogus extra double quote in run-peers.sh

This didn't look right; but I think I fixed it :)

Thanks


ggpull and ggpush are no longer aliases?

I am running:

commit 4224c2a1af2a1b99c14ef81012af321c39856cf5
Merge: 51e366e 8cf04ed

and it appears that this version has removed those useful aliases, although I can't say for sure. Am I the only one missing these aliases with today's (5/6/2015) update?

They are replaced by the ggl and ggp functions respectively.

I see. Thanks!


A little fix for Electric Pump

Fix Electric Pump not pumping heavy water when it's filled with over9000 mb. That is in no way an important fix, but it is a bit annoying that the pump just stops on 9k.

@aidancbrady why was this PR closed?


Removed principal attribute repository from access strategy tab

Removed extra Principal Attribute Repository section from Access Strategy tab

Ryan, I don't quite understand this pull request. Why the removal? by "extra", do you mean there is more than one "principal attribute repository" section and you found a duplicate?

Yes, there is a section for principal attribute repository on both the access strategy and the attribute release tabs, and Paul Spaude seemed to think the one on access strategy was a copy/paste error. If this is incorrect let me know and I will close the PR.


Rename project files and update namespaces?

Would you like me to commit a PR to rename QueryBuilder/QueryBuilder.Tests to SqlKata/Tests.SqlKata (incl. namespace updates) or let me know.
Thanks,

@ceastwood actually the namespaces should be renamed the QueryBuilder.Tests (the file names are correct), since am planning to add other db related projects under SqlKata, it would be great if you can help :) thanks

So would SqlKata.QueryBuilder for the project work?

yes true, the namespaces should be renamed from SqlKata.Tests to QueryBuilder.Tests

Sorry about the two references early this morning, I was merging changes I should be testing cross-platform first. This current PR is good to go.

@ahmad-moussawi Probably :)

:D thanks


Output Images are blurry and noisy

Hi,
I'm using protogen x 5.3 model and trained pics of 15 images with UNet_Training_Steps 1700 steps and UNet_Learning_Rate 2e-6 and even trained again with 200 steps but still getting only the blurry images. Just two days ago it was working fine. Is anyone facing this issue ?

Issue with the training steps I have started with 500 steps again with protogen 3.4 n its working fine don't know why its failing to produce good results with protogen 5.4


support for integer-based sensors

For now ESPHome sensors have floating point state (short float), it is not very optimal in terms of passing this data over very limited TPDO.
Let's provide option of mapping this floating-point data to integers (8-bit / 16-bit / 32-bit) (by providing low / high limit in value, we can include this information in sensor metadata). So it will be possible to transmit this data over CAN in shorter form and map back to float on can-mqtt  side.

implemented here: https://github.com/mrk-its/esphome-canopen/commit/48d091f91269083290010dfcc415785f4ef4cc75


Puzzles cannot be viewed in Internet Explorer

Attached is a screenshot of how a puzzle looks when opened in IE.
This is IE version 11.885.17134.0 on Windows Version 10.0.17134.885.

I looked into this a bit (in fits and starts unfortunately, as I do not have access to a Windows/IE set-up regularly).
Anything below IE11 will be really hard to support as the JS code is full of the desirably block-scoped "let/const" keywords instead of "var".
Unfortunately, IE11 does not support backtick-enclosed multiline strings in JS, which is how Exolve lets setters describe the entire grid, clues, ninas, questions, etc.
I tried to replace this with '....\n' + for every line (just to diagnose), but it does not work -- there must be other issues too, I suppose. Will keep trying some more, but am not very optimistic, unfortunately.

Can you not use Babel to transpile your script into ECMA5?

Re: Can you not use Babel to transpile your script into ECMA5?
I think that might be doable, but I do not think that that complexity needs to be a part of the core software, esp as IE seems to be on its way to obsolescence (I will try harder to fix Edge issues -- still waiting for a period of time where I have access to a Windows machine for some time). If you try this and are successful, please let me know though. Thanks!

Closing the issue as I'm unlikely to work on this, unfortunately.


Case sensitive imports in re-export file

🐛 Bug Report
Input file: add_chart.svg, addchart.svg (2 files)
Output Components: AddChart.js (1 file)
But re-export index.js file contains entries for both files.
export { default as AddChart } from './AddChart'
export { default as Addchart } from './Addchart'

This causes module not found an error in webpack with case sensitive plugin enabled.
Module not found: Error: [CaseSensitivePathsPlugin]
../Addchart.js` does not match the corresponding path on disk `AddChart.js`.

Expected behaviour:
index.js file should not have an entry for a component which doesn't exist in the folder.

I resolved the issue using a custom index template.
function defaultIndexTemplate(filePaths) {
    const filePathInLowerCase = filePaths.map(filePath => filePath.toLowerCase());
    const uniqueFilePaths = filePaths.filter((filePath, index) => {
        return filePathInLowerCase.indexOf(filePath.toLowerCase()) === index
    })

    const exportEntries = uniqueFilePaths.map((filePath) => {
    ...

Keeping it open for default solution.

Hello @ankitchouhan1020, I think it is an edge case. The problem is that you have "add_chart.svg" and "addchart.svg"... I will not handle this in SVGR, you should cleanup your input files.


[FLINK-3899] Document window processing with Reduce/FoldFunction + WindowFunction

Added example of using Reduce/Fold + Window in docs.  The examples were tested to run -- I used the sensor reading class from dataArtisans/blogposts.

Hi @danielblazevski, thanks for the PR. I added a some comments and suggestions.
Thank you, Fabian

Thanks for the fast update @danielblazevski.
I think you accidentally added tools/FlinkCodyStyle.xml to your commit.

Sorry, indeed, added that when playing around that the open PR to add FlinkCodyStyle.xml

No worries :-)

Pushed the Scala example

Thanks for the update! The example looks good. I'll do some minor reformatting and merge the PR.


Can't run npm test

I cannot seem to run the test script. npm test fails to load the built library from test/api/ident.js.
$ npm test

><EMAIL_ADDRESS>test /Users/john/Projects/highlight.js
> mocha test/

module.js:339
   throw err;
   ^

Error: Cannot find module '../../build'

I do have a build folder but it is at ../build from where I ran npm test. I also tried running from several other folders and I tried moving build folder but always same error.

You need to build the library for node before testing.
node tools/build.js -t node
npm test

wow. thanks!


Any way to implement Endless Page feature?

An awesome gem.. but i want to know if theres any way to implement the endless page feature, that twitter and Facebook use?!  As I hear offset query is a bit slower.. http://www.slideshare.net/Eweaver/efficient-pagination-using-mysql

@fschwahn thank you for the tutorial. I am using it and works ok showing the second page, but it does not show the third page, so how can I do this? Thanks

For me dont working fine :( https://github.com/amatsuda/kaminari/wiki/How-To:-Create-Infinite-Scrolling-with-jQuery. I have the same problem that jferrecas. Only show the second page but the next pages dont show. Also load many results many times. Any help? Thanks.


chefspec matcher name is inconsistent

ChefSpec matchers follow the pattern action_resource. According to which the repo resource should be asserted as:
expect(chef_run).to add_packagecloud_repo('foo/bar')

currently the matcher is named as create_packagecloud_repo.

Fixed in https://github.com/computology/packagecloud-cookbook/pull/53

Also matchers are auto generated now in ChefSpec 7 so this is no longer an issue for anyone on modern ChefDK