Retraining u2net.pth Bad Results

Hello @NathanUA ,
I tried to retrain the model to improve the results but its really bad at 700k iterations. using same DUTS Dataset, horizontally flipped offline like in the paper.
what could be the reason for this?

Hi,
Thanks for your trying. Could you please give more clues about the "bad" ?
In terms of visual quality, F-measure, losses ? What is your batch size?
On Tue, Oct 13, 2020 at 1:30 AM Root Access<EMAIL_ADDRESS>wrote:

Hello @NathanUA https://github.com/NathanUA ,
I tried to retrain the model to improve the results but its really bad at
700k iterations. using same DUTS Dataset, horizontally flipped offline like
in the paper.
what could be the reason for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NathanUA/U-2-Net/issues/80, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORL5GMCH2TDRRAD5IC3SKP6XTANCNFSM4SOI242Q
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

Hello @NathanUA ,
Here is the visual example with my model u2net_bce_itr_756000_train_0.137447_tar_0.012064.pth.
756k iterations.  train loss 0.137447 tar loss 0.012064
when resuming from your current model i set this values like this as in the paper:
ite_num = 600000 because your model ran 600k times
epoch_num = 300000
current_epoch = 360  current epoch on your model is 360 like in the paper

With your model here are the results

If you want to get good results on your own dataset, I suggest to retrain
the model with your own data from scratch. The model cannot handle all
cases as you can in the provided prediction maps for the six evaluation
datasets. It just doesn't work perfectly sometimes due to the limited
training set. Just retraining or further training the model cann't solve
all the problems. For practical use, more feature engineering and data
collection works have to be done. You can also try test
time  augmentation (TTA,
https://www.kaggle.com/c/histopathologic-cancer-detection/discussion/84056)
to see if that helps. Because TTA doesn't require more training.
On Wed, Oct 14, 2020 at 12:20 AM Root Access<EMAIL_ADDRESS>wrote:

Hello @NathanUA https://github.com/NathanUA ,
Here is the visual example with my model
u2net_bce_itr_756000_train_0.137447_tar_0.012064.pth.
756k iterations. train loss 0.137447 tar loss 0.012064
when resuming from your current model i set this values like this as in
the paper:
ite_num = 600000 because your model ran 600k times
epoch_num = 300000
current_epoch = 360 current epoch on your model is 360 like in the paper
https://camo.githubusercontent.com/e54370a0778d599103418f29d880f74a948c5368/68747470733a2f2f692e65626179696d672e636f6d2f696d616765732f672f42647341414f5377315564636c66686e2f732d6c313630302e6a7067
[image: rtesd]
https://user-images.githubusercontent.com/14039016/95950452-39a60280-0dfd-11eb-9851-615242603125.png
With your model here are the results
[image: downloadrt]
https://user-images.githubusercontent.com/14039016/95951025-55f66f00-0dfe-11eb-9dbe-314e2c190754.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NathanUA/U-2-Net/issues/80#issuecomment-708184879,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORP4W5XKCFOQN45RRELSKU7JXANCNFSM4SOI242Q
.

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage:https://webdocs.cs.ualberta.ca/~xuebin/

Alright thanks. makes alot of sense


3.1.0 release

I think following PRs could be included in this release:
#2754
#3425
#3428
#3485
for the remaining, we may need more times to review/implement.

I think #3428 should be merged only after fixing this CUDA error #3450.
Also, I'd like to include in 3.1 a fix for easy-reproducible OpenCL GPU error #3475 .

Works for me! Other than the pull requests already mentioned, I have nothing to add that I think needs to get in for the release. And I agree with the next release being 3.1.0 instead of 3.0.1, since so many new features have been added.
Once those other pull requests mentioned above have all been merged, I'll run all the CRAN checks (manual valgrind check here, Solaris via R Hub) to be sure no new issues have been introduced.
We won't be able to submit the R package to CRAN until November but I'm ok with doing the rest of the release before then and not waiting on CRAN. Also as a reminder from #3338 ...I'll do the CRAN submission this time.

@guolinke I hope it's ok, I updated R-package/configure and pushed it here

Release checklist:

[ ] Update VERSION number.
[ ] Update version in Appveyor config file.
[ ] Update version and release date in DESCRIPTION file of R-package.
[ ] Push commit with v* tag to trigger GitHubRelease action at Azure Pipelines.
[ ] Convert automatic GitHub release from Draft to normal one.
[ ] Update stable tag at GitHub.
[ ] Upload release to PyPI.
[ ] Upload release to CRAN (soon).
[ ] Upload release to NuGet.
[ ] Update version and hash in Homebrew formula.

As of #3335, Update version and release date in DESCRIPTION file of R-package. is no longer necessary for releases 😀

@jameslamb Cool! Then I'm striking this bullet out from the list.

@shiyu1994 what is the ETA of your improvement for dense histogram construction? I think this PR is waiting for it.

I've marked #3520 as blocking issue, I think we can include fix for it in 3.1.0.

I'm sorry, I just discovered a valgrind issue that I think will block 3.1.0 from getting to CRAN: #3525

Now that all of the PRs in https://github.com/microsoft/LightGBM/pull/3484#issuecomment-716306645 have been fixed,  if CI passes are we ready to release? Should I submit the R package to CRAN?

oh wait I forgot about #3513. I'll open a PR right now that skips the problematic tests for now.

if CI passes are we ready to release?

What about https://github.com/microsoft/LightGBM/pull/3484#issuecomment-716507553 (#3475)?

Also, I'd like to mark this release as the last one which supports Python 2. So that our next minor release (in 2021 I believe) will drop Python 2 support (1 year after Python 2 EOL). I guess it's time. Does anyone have any objections?

if CI passes are we ready to release?

What about #3484 (comment) (#3475)?

oh sorry, missed that one. Yes we should try to fix that before release.

Also, I'd like to mark this release as the last one which supports Python 2. So that our next minor release (in 2021 I believe) will drop Python 2 support (1 year after Python 2 EOL).

I agree with this too. I think it's ok to abandon support for Python 2. Other scientific computing libraries are already talking about even removing support for Python 3.6:

https://github.com/dask/community/issues/66
https://numpy.org/neps/nep-0029-deprecation_policy.html

@shiyu1994 what is the ETA of your improvement for dense histogram construction? I think this PR is waiting for it.

Done with that.

I think it is almost ready. Any other PRs need to include?

@StrikerRUS recommended that we try to fix #3475 before release

One more good item to include in new release, I believe:

[ ] #3561

@StrikerRUS recommended that we try to fix #3475 before release

I saw @StrikerRUS already try different python and boost versions, and think it is not trivial to fix in a short time.
And it is possible that the bug is from Boost or Clang, as the gcc and msvc can work.

I am going to merge this in 24 hours and draft a new release.

@jameslamb Any cran's issuse to address? I think we can submit this release to cran.

@jameslamb Any cran's issuse to address? I think we can submit this release to cran.

I'll try R Hub Solaris checks on this branch one more time right now. I think some things have been merged here since the last time I did that.
If those checks pass (should only take 10-20 minutes), I'll submit a CRAN submission. Is that OK?

@jameslamb no problem, thank you!

no issues found on Solaris (https://artifacts.r-hub.io/lightgbm_3.1.0.tar.gz-048076e707fd42c695b805753f65aa44/lightgbm.Rcheck/), valgrind is happy (https://github.com/microsoft/LightGBM/pull/3484#discussion_r523766573), and all of the other CI jobs are passing.
I'm going to submit to CRAN 😀
@guolinke I think that since I'm not the maintainer in DESCRIPTION, CRAN will email you to confirm that I have permission to submit.

I've submitted to CRAN!

@guolinke they'll send you an email next asking you to confirm the submission

The maintainer of this package has been sent an email to confirm the submission. After their confirmation the package will be passed to CRAN for review.

Please note that the submission is not completed until it is confirmed by the maintainer (via a link in the e-mail), who may need to check the spam folder.

Release checklist:

[x]  Update VERSION number.
[x]  Update version in Appveyor config file.
[x]  ~Update version and release date in DESCRIPTION file of R-package.~
[x]  Update version in configure file of R-package.
[x]  Push commit with v* tag to trigger GitHubRelease action at Azure Pipelines.
[x]  Convert automatic GitHub release from Draft to normal one.
[x]  Update stable tag at GitHub.
[x]  Upload release to PyPI.
[ ]  Upload release to CRAN (soon).
[x]  Upload release to NuGet.
[ ]  Update version and hash in Homebrew formula.

@StrikerRUS can you help for the  Homebrew formula?

@guolinke

can you help for the Homebrew formula?

Sure. PR proposed: https://github.com/Homebrew/homebrew-core/pull/64933
Seems Homebrew started to support Big Sur! 👍
https://github.com/Homebrew/homebrew-core/commit/d80a8b51f83393dae4c6222077363a77dc78435e#diff-5e461287a37b620a7dd2f18a9c1706d10371608f3384c032bb732aa2a08117f6

PR proposed: Homebrew/homebrew-core#64933

Homebrew successfully updated:

https://github.com/Homebrew/homebrew-core/commit/133a0441bef47e9d4f9f91980ccde7512c604e21#diff-5e461287a37b620a7dd2f18a9c1706d10371608f3384c032bb732aa2a08117f6
https://github.com/Homebrew/homebrew-core/commit/6c9e77fc0e3b3ff51b26a89c80dbf385f4bba230#diff-5e461287a37b620a7dd2f18a9c1706d10371608f3384c032bb732aa2a08117f6

woo, thanks!

@guolinke have you received an email from CRAN?
According to https://lockedata.github.io/cransays/articles/dashboard.html, {lightgbm} is still in "pending" which means CRAN is waiting for a response from us. They should have sent you an email with a link to click to confirm that I'm allowed to submit.

I think I already comfirm it and receive their auto reply:
Dear maintainer,

package lightgbm_3.1.0.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.

Log dir: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2F&data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749888900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NZe%2BwpgRf5A%2FTfQy1OZIIvl2y1DORnbdUFb4YZyZ5N8%3D&reserved=0>
The files will be removed after roughly 7 days.
Installation time in seconds: 676
Check time in seconds: 256
R Under development (unstable) (2020-11-14 r79432)

Pretests results:
Windows: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2FWindows%2F00check.log&data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749888900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MfQWw19iM7fjFNw5HhQXZtB4LmyLvHRMuiIQeaNWl%2B8%3D&reserved=0>
Status: 1 NOTE
Debian: <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwin-builder.r-project.org%2Fincoming_pretest%2Flightgbm_3.1.0_20201116_044056%2FDebian%2F00check.log&data=04%7C01%7Cguolin.ke%40microsoft.com%7Cbe31c3b4f887472079fe08d88a006d6d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637411081749898895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nYwviy5FXgrR0wgBAeFd1aGe%2BC8f3WnK%2BAz4ZhBRV5A%3D&reserved=0>
Status: 1 NOTE

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service

oh great, thank you!

It seems we got accept:
https://cran.r-project.org/web/packages/lightgbm/index.html

!!! Exciting!
I'm going to wait a few days before publicizing this or updating the documentation, in case we get surprised like last time.
But I'm hopeful 😀

I've been refreshing https://cran.r-project.org/web/checks/check_results_lightgbm.html every few hours. More checks are slowly rolling in.
Right now we're passing on Windows, Mac, Solaris, and Linux

Soon we should know if we're passing valgrind and UBSAN/ASAN, as well as tests with other combinations of operating system + compiler.

@jameslamb According to https://cran.r-project.org/web/checks/check_results_lightgbm.html it looks like we need to add ON_32BIT_WIN to the fix introduced in #3534.

UGH

Ok I'll open a PR with a fix. I think to be safe we should just completely skip that test if on CRAN. This also tells me the existing Windows CI jobs we have in GitHub Actions aren't a perfect replica of what CRAN does.
I'll see if I can replicate it with R Hub.

I created #3585 , let's move this discussion there instead of keeping it on this closed PR

This also tells me the existing Windows CI jobs we have in GitHub Actions aren't a perfect replica of what CRAN does.

I guess we simply don't have any 32-bit CI jobs.


typo on this page

[Enter feedback here]

you can strongly advised to configure your application behind your Standard Load Balancer.

you are strongly advised to
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f85b671d-f324-1bbb-9ae1-cfb4d14f642b
Version Independent ID: 6357b6d4-9748-c80a-7331-d69e486fa3ad
Content: Create an Azure Private Link service using Azure CLI
Content Source: articles/private-link/create-private-link-service-cli.md
Service: private-link
GitHub Login: @KumudD
Microsoft Alias: kumud

I have created a PR with the update, changes will be live shortly.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/94950


Add a MAC signature on the secure tokens

The format is a 24 byte random token followed by a signature that is then base64 encoded and passed on to the user.

[ ] add more documentation for admins
[ ] fix feedback when the key is missing on boot
[ ] fix tests
[ ] don't store the token signature in the databas
[ ] move token creation and verification routines outside UserService to ease reuse

This is necessary to safely redirect in resend confirmation when the token has been used already (and deleted) as we would be at least capable of guaranteeing that we generated it. See #215 for details.

Let's use JWT instead.


Added required libs to readme

I have struggled to build (still is) please accept this, this commit contains required libs to build without errors

Hey @Atonix0,
Thanks for the PR, but the list in incomplete and widely depends on your platform.
This page roughly lists everything: https://crystal-lang.org/reference/1.9/man/required_libraries.html
And this one is more precise but a bit obsolete: https://github.com/crystal-lang/crystal/wiki/All-required-libraries


pip installs ckeditor_demo along with ckeditor

I've just found lib/python2.7/site-packages/ckeditor_demo folder in my venv after installing ckeditor. AFAIU it's useless, isn't it?

Yes, it shouldn't be in the package.

Not present in 4.4.8 any more.


fix: slugify version in setup.py

fix: slugify version in setup.py

fix #419

Duplicate of #411
Duplicate of #410


Protobuf is not installed

Installing collected packages: torch, torchvision
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
open-clip-torch 2.7.0 requires protobuf==3.20.0, which is not installed.
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Successfully installed torch-2.0.1+cu118 torchvision-0.15.2+cu118
Installing requirements

I get this issue after I created a new notebook from your docker container. Do I maybe need to update the container?

tensorflow 2.9.2 requires protobuf<3.20,>=3.9.2, but you have protobuf 4.23.2 which is incompatible.
Successfully installed bs4-0.0.1 markdownify-0.11.6 six-1.16.0

Actually, seeing further in the output, it seems some of the dependencies are broken.

# Import launch.py which will automatically run the install script but not launch the WebUI.
import launch
launch.prepare_environment()

Mhh, it installs protobuf using this, so I am not sure what to do about it. Where is import.py coming from?
...It is in the web UI.

Let me summarize what is going on. When the container is initially deployed, it has protobuf 3.20. Then after we run the setup script, it uninstalls it on this line here:
# Uninstall PyTorch and some other libraries so the WebUI can install the versions it needs
!pip uninstall -y torch torchvision torchaudio protobuf

Then it tries installing it again on these lines.
# Import launch.py which will automatically run the install script but not launch the WebUI.
import launch
launch.prepare_environment()

Unfortunately, this gets the 4.23.2 version which breaks everything. I am not sure what to do here. I hadn't expected this. I took on the quest of updating my WebUI install due to some people asking me how to install extensions, but I hadn't through that the entire build would be broken!

I am not sure what to do here, I am trying to install using some of the earlier versions like v1.1.0, but it still seems to be fetching the most up to date protobuf.

A workaround for this is to pip install protobuf==3.20.0. And remove the part where uninstalls it. Then it will proceed unimpeded.
That having said, the xformers don't work for me either.

I'd recommend commenting out the entire !pip uninstall -y torch torchvision torchaudio protobuf line as it makes the startup a lot faster.
As mentioned in the other issue, one of the dependencies installing tensorflow is the problem.
I also don't understand why xformers are not working properly.

# The installer isn't installing deepdanbooru right now so we'll do it manually.
if activate_deepdanbooru:
    # https://github.com/KichangKim/DeepDanbooru/releases
    !pip install "git+https://github.com/KichangKim/DeepDanbooru.git@v3-20211112-sgd-e28#egg=deepdanbooru[tensorflow]" # $(curl --silent "https://api.github.com/KichangKim/DeepDanbooru/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')#egg=deepdanbooru[tensorflow]" # tensorflow==2.10.0 tensorflow-io==0.27.0 flatbuffers==1.12

In the other issue this was mentioned by this branch should be false by default so the most likely case is that TF comes with the container itself.

WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Installing xformers from wheels on Github...
--2023-06-01 09:51:01--  https://github.com/Cyberes/xformers-compiled/raw/main/a4000/xformers-0.0.18%2Bda27862.d20230413-cp39-cp39-linux_x86_64.whl
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://raw.githubusercontent.com/Cyberes/xformers-compiled/main/a4000/xformers-0.0.18%2Bda27862.d20230413-cp39-cp39-linux_x86_64.whl [following]
--2023-06-01 09:51:02--  https://raw.githubusercontent.com/Cyberes/xformers-compiled/main/a4000/xformers-0.0.18%2Bda27862.d20230413-cp39-cp39-linux_x86_64.whl
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 19155376 (18M) [application/octet-stream]
Saving to: ‘/tmp/tmp.IxO3pArqCc/xformers-0.0.14.dev0-cp39-cp39-linux_x86_64.whl’

/tmp/tmp.IxO3pArqCc 100%[===================>]  18.27M  --.-KB/s    in 0.06s

2023-06-01 09:51:02 (313 MB/s) - ‘/tmp/tmp.IxO3pArqCc/xformers-0.0.14.dev0-cp39-cp39-linux_x86_64.whl’ saved [19155376/19155376]

WARNING: Skipping xformers as it is not installed.
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
ERROR: xformers-0.0.14.dev0-cp39-cp39-linux_x86_64.whl is not a supported wheel on this platform.

===================================
Done! If you're seeing this the process has exited successfully.

Maybe the reason xformers aren't working is because cp39.
Probably that stands for C Python 3.9 while the container comes with 3.10.

If you are using the special Python 3.10 container cyberes/gradient-base-py3.10:latest you need to either install xformers through pip or build them yourself.

First, try installing it through pip by setting install_pip_xformers = True in the settings block above. If that fails or you encounter issues, use the block in the Tools section to build xformers for your machine.

Ah, it says as much in one of the cells. Didn't realize it.

The !pip uninstall -y torch torchvision torchaudio protobuf line is to reset the environment for the WebUI to install what it wants. I guess tensorflow needs to be there too.
activate_deepdanbooru is kind of old but I haven't removed it in case people still use it.

I've stepped away from SD for a few months.

Me too. I made some vids on how to get it running on SD using your script, which led to people thinking I am some kind of expert at setting up the WebUI, and lately I've had some questions coming in how to make extensions work. I gave it a try and am just not ready to bash my head against that yet. I'll get back to it when I start writing a web novel.

I've kept this notebook on maintenance but is there anything else that needs to be fixed or added?

Yeah, I do have a request. Could put the Python version check at the top of the file. I started the day by making a recording, and was surprised a couple of minutes in that I had to erase the notebook and install a new one after I spent some time modifying the previous cell.
Also, could you put the model downloads below the WebUI startup?
Also, this question is just out of curiosity as I already did it using your container, but do you know if it is possible to install Python 10 manually on a notebook? I looked it up, found this, but the update-alternatives command didn't work for me, and I don't know why. The problem with installing your docker container is that it wiped my UI defaults file, I didn't realize it until after the deed was done.

Good idea, I'll move the Python check to the top.

Also, could you put the model downloads below the WebUI startup?

I use the Jupyter interface where you can collapse the sections. I don't want to put it at the bottom because a new user might get confused about how to download a model. So many people don't read instructions.

is possible to install Python 10 manually on a notebook?

I tried that but forget why I decided the container was the better option. I think it the install process unreliable or not straight forward and with how many non-technical users there are I decided against it.

pip install protobuf==3.20.0

I stumbled upon the same issue but what worked for me was to add !pip install "protobuf<3.20".

@kruttik-lab49 that's probably the best solution, but I'll let stable-diffusion-webui manage installing those dependencies rather than trying to do it ourselves.
I'll leave this issue open in case others have the same problem.

its 2024 and Python dependency management is still the wild west, came here to say that keeping this issue open is helpful because I had the issue several times and keep coming back to the answer, maybe worth adding to a cell text


create call to action section on project detail container

Request
Pending Approval
Change Requested
Rejected

done in recent PR


Code samples workflow fix paths

wow what timing can you take a look at my comments from the other PR that was merged in like 1sec after I commented so there was no way you could've seen those comments? They were just comments tho so feel free to be like "nah" and then I'll approve this one lol
#227

Wow thats wild timing. For ubuntu latest we are doing the same thing for our comment workflow on rdk so im good with keeping that pattern here. To link to the fleet team maybe we link to our jira board? Im down for suggestions for how to reach out to us.

Ya I wasn't sure. the sdk-netcode team has an actual GitHub team that we can tag @viamrobotics/sdk-netcode so I was thinking maybe something like that? but it doesn't seem that fleet management has that setup?

Ya I wasn't sure. the sdk-netcode team has an actual GitHub team that we can tag @viamrobotics/sdk-netcode so I was thinking maybe something like that? but it doesn't seem that fleet management has that setup?

I added a  @viamrobotics/fleet-management team in github and changed the comment to reflect this


KIP-19(Advanced Orders): add info regarding dynamic fee caps

@Andrew-Synthetix @Marko-roy updated the fees to 3bp will need someone to approve


Include contextual info in the page title when changing URL parameters

Changing the URL can add entries to the browser's page history. This would be significantly more useful if we could change the title to include the selected feature and/or map location. I'm not sure if this could work on osm.org but I think it's worth it for ideditor.com and localhost alone.

We could do number of changes (the code that updates the save button count could do it)
document.title = "iD (60)"

I want to solve it. How exactly should title looks? Only 'iD' with number of changes as @bhousel proposed? Or for example with name of selected item like in Google Maps?

I ended up removing the map location part since it was distracting and not particularly useful to most users. Perhaps we could include the local area name instead, e.g. "Tuba City, AZ".

We could do number of changes

I added this too. I couldn't yet figure out how to show it in the current title but not in the history item title, but it's not a big problem.


Debug 21 Scene

Currently Everything is working on the whole. Will review the new way the cards are displaying for bugs and disable the ability to switch between scenes manually when the round ends.


Include wiring for isolated components

Fixes #96

I have added the extra device graphs and parameterised some of the tests as requested.
@callumforrester please may you look at this for me? I haven't parameterised all of them because it felt a bit overkill but I can do if you think I should.
Also the test file is now over 600 lines long, should we move the graph fixtures into other files?


Fix requests by passing correct data parameter to query function

Wrong parameter was used when forming queries, resulting in a response with the message Unauthenticated. This change provides the correct parameter which results in working API requests.

Looks reasonable!

Thanks for the fix


[Miscellaneous] [DOCS] - Add project setup file

added a Project setup.md file that explains how to setup the project
also added a .gitignore file that ignores common files one does not want to have in GitHub
added linke to Project setup.md to README.md

Oh I just saw @TheInspiredConjurer already marked it as ready, FYI: I wanted to read over it one more time vefore it's ready fore review ☝🏽

Good job! @justDabuK


add action for build validation

A Action for confirming the build-success should run for PRs

You mean a build action like in linkfree?

Action that runs the build 👍


Version 0.5.5

Hello,
There were several changes (8 commits) since version 0.5.4: https://github.com/oauth-xx/oauth-ruby/compare/v0.5.4...master
Is there something I can do to help release version 0.5.5?

Hi,
Any updates on this?

Hi,
Any updates on this?

We're also waiting for the next release with a vuln fix.

We're also waiting for the next release with a vuln fix.

A new gem will be pushed up today or tomorrow.

A new gem will be pushed up today or tomorrow.

Version 0.5.5 is now on rubygems.

Version 0.5.5 is now on rubygems.


Does not wotk with Hexo 4.0.0

Any plans to upgrade this to work with Hexo 4.0.0?
The help image_version is not found.

Thanks for reporting 👍 I will try to update it next week

I've beaning looking at this and it's a more general malaise with Hexo 4.0. None of the filters are working e.g. <%- url_for('foo') %> throws a JS error url_for not found. Looks like there are serious issues with 4.0. I should never trust a dot zero release. Rolling back to 3.x

@steveww Please open a issue at hexojs/hexo here if you encounter some problems on Hexo 4.0. IMHO, there must be something wrong with your Node.js version or node_modules.
I will retain this issue opened since the unit-test for this plugin has not update to Hexo 4.0.0 yet.
I believe the unit-test will pass like a flying color even after @ertrzyiks update unit-test for Hexo@4:
https://github.com/hexojs/hexo-filter-responsive-images/blob/d70c616cbd161212746b4e0081202cd50ba33a62/package.json#L34

It's merged to master branch and all the specs are green. I'm struggling updating my blog to hexo4, so until I can test it properly I won't publish a new version.

@ertrzyiks If you have encountered some problem when updating to Hexo@4, you can create a discussion at GitHub Org Team page. Then we might be able to find out what we had missed in Hexo 4.0.0 Release notes, and to prevent other users from encountering them.

@SukkaW the problems I had were not related to Hexo update directly, I had issues installing binary dependencies of sharp (it complained about wrong python/libvis version). I made it work and confirmed this plugin works with Hexo 4 with no other tweaks than in package.json.
1.5.0 is out  :tada:


Removes superfluous logger.log entries. Closes #5461

Closes #5461
Removes superfluous logger.log entries.

Merged manually, thank you!


Add option to plugin.yml

I think this is what broke the master build

https://github.com/buildkite/cli is the best way to check things locally! I just ran bk run and it looks like there's a shellcheck error with the min_max_percent line?

@toolmantim yep I hadn't set it up locally on my new laptop. Done now and passing


Poll questions over 256 characters long cause an error which makes poll creation fail

Embed titles are limited to 256 characters, and the question is placed in the title field. A check needs to be placed on the input before continuing to ensure it is permissable. This restriction also extends to field titles, which I believe options are placed in, so the same restriction/check would need to be present there, or alternatively just move the whole thing to the description which is longer and I think less restrictive in general.

The results embed has extra characters in the title such as "results for:" which need to either be accounted for in the original limit or removed

Extension, field values have a character limit of 1024 so validate options length too


Certificate rotation region by region

At times it might be necessary to rotate certs region by region. This PR enables this feature by allowing the celery task to receive a region param.
A new rotate method considers the region and rotates only matching patterns in the dnsname of the endpoint, for instance, rotate only if "us-east-1" in the dnsname of the hostname.
one can according put different schedules for rotation region-by-region, and then one default one to rotate any missing regions.
example scheudule:
CELERYBEAT_SCHEDULE = {
    'certificate_rotate': {
        'task': 'lemur.common.celery.certificate_rotate',
        'options': {
            'expires': 180
        },
        'schedule': crontab(minute="*"),
        'kwargs': {'region': 'us-east-1'}
    }
}

Coverage decreased (-0.3%) to 58.091% when pulling 843ffad60e404ab03af4a49b2ffa41eb3650b9fb on hosseinsh:cert-rotation-region-by-region into 54035e8db8cad227cfde59b5a6e0439571d3e109 on Netflix:master.


Update README.MD for readability

added some newlines to make clearer what the docker commands are

Thanks @davevs (merged)


Typo

@Hardware-based isolation (last word of alinea) "wbsites" should be websites.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae14bfa4-3c20-78bb-d086-69a5a91cc5c3
Version Independent ID: bb5cbe43-a796-d231-c8c2-0c6031dc47dd
Content: Overview of attack surface reduction
Content Source: windows/security/threat-protection/windows-defender-atp/overview-attack-surface-reduction.md
Product: w10
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@BenVlie Thanks for catching that. Correction should tomorrow.

@BenVlie - Thank you for submitting this feedback.
From our understanding the issue has been resolved. If you feel it hasn't been resolved please re-open this issue.

@AndreaBarr - This issue can be closed. Thank you.


Add events modality

Background
Currently, no events are emitted when user triggers actions - transfer, burn, etc.
Suggestion
This should be fixed by using CES.
If this issue is accepted, the js-client should be updated.
we will do this by adding an events modality, in the pattern of our cep78 implementation:

no events (default)d
CES events

duplicate of #73


Update README.md: Add missing details

Listed additional listed models on nat.dev UI
Added links to references for models, people

Thank you!


Build issues because of errors in Findpg.cmake

Related issue: https://github.com/microsoft/vcpkg/issues/12760

Sorry, I mainly created the vcpkg port for installation on Windows. I rarely tested it on other platforms. I will try to fix it.

@interfector18 , Do you have any suggestions? thank you.

The PostgreSQL::PostgreSQL target is supported after 3.15 version of cmake, it can cause more errors on user platforms with older versions of cmake installed, so we can't depend on it.

drogon_port.patch.gz
@yay please check this patch. thanks. if it works, I will submit a PR to vcpkg.

@an-tao Thanks for the patch. After applying it, the vcpkg install drogon worked:
The package drogon:x64-osx provides CMake targets:

    find_package(Drogon CONFIG REQUIRED)
    # Note: 4 target(s) were omitted.
    target_link_libraries(main PRIVATE pg_lib UUID_lib coz::coz MySQL_lib)

However, when added to CMakeLists.txt I see the following error:
[cmake] CMake Error at /Users/vitaliikravchenko/tools/vcpkg/scripts/buildsystems/vcpkg.cmake:343 (_add_executable):
[cmake]   Target "drogon" links to target "coz::coz" but the target was not found.
[cmake]   Perhaps a find_package() call is missing for an IMPORTED target, or an
[cmake]   ALIAS target is missing?

When I remove the coz::coz from target_link_libraries, I'm able to configure the project.
But the simple example app fails to compile:
[main] Building folder: drogon main
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /Users/vitaliikravchenko/projects/drogon/build --config Debug --target main -- -j 18
[build] Scanning dependencies of target main
[build] [ 50%] Building CXX object CMakeFiles/main.dir/main.cpp.o
[build] [100%] Linking CXX executable main
[build] Undefined symbols for architecture x86_64:
[build]   "Json::Value::Value(Json::ValueType)", referenced from:
[build]       drogon::PluginBase::PluginBase() in main.cpp.o
[build]   "Json::Value::~Value()", referenced from:
[build]       drogon::PluginBase::~PluginBase() in main.cpp.o
[build]   "drogon::DrClassMap::registerClass(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::function<drogon::DrObjectBase* ()> const&)", referenced from:
[build]       std::__1::enable_if<std::is_default_constructible<drogon::plugin::SecureSSLRedirector>::value, void>::type drogon::DrObject<drogon::plugin::SecureSSLRedirector>::DrAllocator::registerClass<drogon::plugin::SecureSSLRedirector>() in main.cpp.o
[build]       std::__1::enable_if<std::is_default_constructible<drogon::IntranetIpFilter>::value, void>::type drogon::DrObject<drogon::IntranetIpFilter>::DrAllocator::registerClass<drogon::IntranetIpFilter>() in main.cpp.o
[build]       std::__1::enable_if<std::is_default_constructible<drogon::LocalHostFilter>::value, void>::type drogon::DrObject<drogon::LocalHostFilter>::DrAllocator::registerClass<drogon::LocalHostFilter>() in main.cpp.o
[build]       std::__1::enable_if<std::is_default_constructible<drogon::NotFound>::value, void>::type drogon::DrObject<drogon::NotFound>::DrAllocator::registerClass<drogon::NotFound>() in main.cpp.o
[build]   "drogon::HttpAppFramework::instance()", referenced from:
[build]       drogon::app() in main.cpp.o
[build]   "trantor::Logger::stream()", referenced from:
[build]       drogon::DrClassMap::demangle(char const*) in main.cpp.o
[build]   "trantor::Logger::Logger(trantor::Logger::SourceFile, int, trantor::Logger::LogLevel)", referenced from:
[build]       drogon::DrClassMap::demangle(char const*) in main.cpp.o
[build]   "trantor::Logger::~Logger()", referenced from:
[build]       drogon::DrClassMap::demangle(char const*) in main.cpp.o
[build]   "typeinfo for drogon::LocalHostFilter", referenced from:
[build]       drogon::DrObject<drogon::LocalHostFilter>::DrAllocator::className() const in main.cpp.o
[build]   "typeinfo for drogon::IntranetIpFilter", referenced from:
[build]       drogon::DrObject<drogon::IntranetIpFilter>::DrAllocator::className() const in main.cpp.o
[build]   "typeinfo for drogon::plugin::SecureSSLRedirector", referenced from:
[build]       drogon::DrObject<drogon::plugin::SecureSSLRedirector>::DrAllocator::className() const in main.cpp.o
[build]   "typeinfo for drogon::NotFound", referenced from:
[build]       drogon::DrObject<drogon::NotFound>::DrAllocator::className() const in main.cpp.o
[build]   "VTT for drogon::LocalHostFilter", referenced from:
[build]       drogon::LocalHostFilter::LocalHostFilter() in main.cpp.o
[build]   "VTT for drogon::IntranetIpFilter", referenced from:
[build]       drogon::IntranetIpFilter::IntranetIpFilter() in main.cpp.o
[build]   "VTT for drogon::plugin::SecureSSLRedirector", referenced from:
[build]       drogon::plugin::SecureSSLRedirector::SecureSSLRedirector() in main.cpp.o
[build]   "VTT for drogon::NotFound", referenced from:
[build]       drogon::NotFound::NotFound() in main.cpp.o
[build]   "vtable for drogon::LocalHostFilter", referenced from:
[build]       drogon::LocalHostFilter::LocalHostFilter() in main.cpp.o
[build]   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
[build]   "vtable for drogon::IntranetIpFilter", referenced from:
[build]       drogon::IntranetIpFilter::IntranetIpFilter() in main.cpp.o
[build]   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
[build]   "vtable for drogon::plugin::SecureSSLRedirector", referenced from:
[build]       drogon::plugin::SecureSSLRedirector::SecureSSLRedirector() in main.cpp.o
[build]   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
[build]   "vtable for drogon::NotFound", referenced from:
[build]       drogon::NotFound::NotFound() in main.cpp.o
[build]   NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
[build] ld: symbol(s) not found for architecture x86_64
[build] clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
[build] make[3]: *** [main] Error 1
[build] make[2]: *** [CMakeFiles/main.dir/all] Error 2
[build] make[1]: *** [CMakeFiles/main.dir/rule] Error 2
[build] make: *** [main] Error 2
[cmakefileapi-parser] Code model version (2.1) of cmake-file-api is unexpected. Expecting (2.0). IntelliSense configuration may be incorrect.
[cmakefileapi-parser] Code model version (2.1) of cmake-file-api is unexpected. Expecting (2.0). IntelliSense configuration may be incorrect.
[build] Build finished with exit code 2

Just use the defaut cmake file generated by drogon_ctl:
find_package(Drogon CONFIG REQUIRED)
target_link_libraries(${PROJECT_NAME} PRIVATE Drogon::Drogon)

That worked, thank you.

@yay , I've update the vcpkg, https://github.com/microsoft/vcpkg/pull/12931#event-3668509877, please check it. thanks.

@an-tao There was only a single error:

It doesn't seem like MariaDB is optional, I had to run brew install mariadb in order for vcpkg install drogon to complete successfully.
Other than that it works, thanks!


kodi.packages.pvr-iptvsimple: 7.4.2 -> 7.5.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I have tested this and it works :+1:

Result of nixpkgs-review pr 117430 at 734c5023 run on aarch64-linux 1

3 packages built successfully:

kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.pvr-iptvsimple

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 117430 run on x86_64-linux 1

3 packages built:

kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.pvr-iptvsimple


Crossplane improvement

What problem are you facing?

How could Crossplane help solve your problem?

@Sechaba22 I think you are missing the text in the description. Could you add it? Otherwise I am going to close this issue.


Command line parsing bug: spaces and trailing backslash

This has already been posted on UserVoice (here), but appears to still happen in 6.0.
Steps to reproduce
Using any .exe capable of outputting its command line arguments:
PS X:\scratch> .\ps-args-test.exe .\test1\ '.\test 2\' .\test1\

Auto-completion uses this format with a trailing backslash, so it's expected to work correctly.
Expected behavior
.\test1\
.\test 2\
.\test1\

Actual behavior
.\test1\
.\test 2" .\test1\

Environment data
> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.4
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@iSazonov:
This is only indirectly related to IntelliSense (which suggests passing the arguments like that).
The real issue is how the command line is rebuilt behind the scenes by PowerShell:
Argument list .\test1\ '.\test 2\' .\test1\ is translated to .\test1\ ".\test 2\" .\test1\ behind the scenes, which any external utility that uses \ as the escape character (most of them) parses as reflected in the initial post, causing the initial argument partitioning to be misinterpreted:

The 2nd " in ".\test 2\", due to being preceded by \ is interpreted as an escaped ", causing the remainder of the string - despite a then-missing closing " to be interpreted as part of the same argument.

The - cumbersome - workaround on Windows is to add an extra \, though, given that PowerShell does re-quoting behind the scenes, the fix is to let PowerShell  do  that automatically:
> .\ps-args-test.exe .\test1\ '.\test 2\\' .\test1\  # Note the '\\'

The - proper, unfortunately-hypothetical-as-of-now - fix on Unix platforms is to pass the arguments as an array of literals to the target utility, as is the norm on Unix platforms, bypassing such issues altogether.
cc @SteveL-MSFT

Unless I hear otherwise, this doesn't seem to be a common use case.  I think we can fix in 6.1.0 unless someone from the community submits a PR.

I'd argue it's common since it happens every time I auto-complete a directory name with a space unless I remove the trailing slash manually. My example was a bit incomplete I think, since the extra quote is also inserted with just one argument.
PS X:\scratch> .\ps-args-test.exe '.\test 2\'

.\test 2"

A shell that has a broken auto-complete for directories is... inconvenient.

@akervinen I see, every time with a space is definitely a concern

The trailing slash is added by PSReadline, but by powershell tab completion:
PS> $s = TabExpansion2 -inputScript 'git t' -cursorColumn 'git t'.Length
PS> $s.CompletionMatches[0].CompletionText
'.\test 2'

So this is more of a PSReadline issue, maybe PSReadline should have an option to no adding trailing slash for directories?

@daxian-dbw:
Not appending a \ would be band-aid, especially given that nothing stops a user from typing a path that ends in \.
There is no good reason not to properly support passing of arguments with whitespace that end in \.
At the risk of repeating myself: The problem is a fundamental problem with how PS rebuilds the command line behind the scenes on Windows and that it even does so at all on Unix platforms, and it should be fixed at that level.

@mklement0 I see your point now.
The problem is in NativeCommandParameterBinder.cs, which cause the argument passed in native commands like this:
PS> testexe.exe -echoargs '.\test 2\'
Arg 0 is <.\test 2">

Just lost an hour wondering why git status wouldn't work with -C. And a number of RoboCopy folks lost time to it.
This use case gets hit!

The - cumbersome - workaround on Windows is to add an extra , though, given that PowerShell does re-quoting behind the scenes (as is necessary on Windows), the fix is to let PowerShell do that automatically:
.\ps-args-test.exe .\test1\ '.\test 2\' .\test1\  # Note the '\'

@mklement0 Do you think we should do this fix for now or shall we wait until #23592 is addressed?
I'm trying to do this fix now but having some trouble figuring out the reasonable behavior handling the trailing backslashes of an arg string. When the arg string needs to be quoted, the trailing backslashes will escape each other and if there are odd number of backslashes, then the closing quote will be misinterpreted, for example:
PS> testexe.exe -echoargs 'test \'
Arg 0 is <test ">
PS> testexe.exe -echoargs 'test \\'
Arg 0 is <test \>
PS> testexe.exe -echoargs 'test \\\'
Arg 0 is <test \">
PS> testexe.exe -echoargs 'test \\\\'
Arg 0 is <test \\>

Now, we think the resulting " is confusing, and the ending \ should be preserved when passing to the native command. As a result, we will see behaviors like this:
PS> testexe.exe -echoargs 'test \'
Arg 0 is <test \>
PS> testexe.exe -echoargs 'test \\'
Arg 0 is <test \>
PS> testexe.exe -echoargs 'test \\\'
Arg 0 is <test \\>
PS> testexe.exe -echoargs 'test \\\\'
Arg 0 is <test \\>

You can see that when there is an odd number of backslashes, the ending backslash will be preserved, which makes the odd number of trailing backslashes always behave as (odd number + 1) trailing backslashes. Does this look like a reasonable behavior?

@daxian-dbw:
My sense is that once this RFC proposal by @TSlivede is implemented, it will cover this scenario too, so we probably don't need a separate fix for this specific issue.
For background, see https://github.com/PowerShell/PowerShell/issues/1995#issuecomment-325231274

Yes, that's true. My RFC-Proposal (or any other fix for https://github.com/PowerShell/PowerShell/issues/1995) should also fix this. Basically we could rename https://github.com/PowerShell/PowerShell/issues/1995 to something like "Arguments for external executables aren't correctly escaped". In that case this issue could be closed as duplicate.

@TSlivede makes sense.  Dupe of https://github.com/PowerShell/PowerShell/issues/1995

I'm separating this out from the uber issue of args to native commands which might be resolved by a future corefx api.  I'll see if there is something we can do to solve this one sooner.

This bug causes all kinds of problem in Jenkins builds.  Trying to set any ENV variable to a path then ends in a backslash causes this.
For example, if you try to call   setx 'MY_PATH' 'C:\folder1\folders' /M;
It ends up setting MYPATH to "C:\folder1\folder2" /M"
So instead of the value ending in a backslash, it ends with a double quote a space a forward slash and a capital M.
It doesn't get more wrong that that.  And Jenkins is just tied to this powershell version () so there's no fixing it. Just literally cannot pass any powershell arguments using single quotes when the string ends in a backslash.


PMVS export

I've never made a pull request before so I don't know what I'm doing!
Here's a script to generate output for PMVS. There's a markdown readme to go with it.

Awesome @ktuite!
Re: one reason that we made __image_file() private is to ensure DataSet is flexible to use with images locally or in S3. The same applies for the __object_file() methods.


Update eslint config

upgrade eslint related dependencies
reactive node plugin (ignore 4 common issues)
remove unused standard plugin
remove unused promise plugin (activating it triggered loads of errors)
fix Buffer API warning
fix duplicate import warning

Coverage remained the same at 72.742% when pulling c716327448bc62471256dd42af51ed8fdf88eaf3 on eslint-update into fc0824b1d10a3b5cf834999f7d02d1c7f6ab8d4d on master.


Implementation of async trash for parallel deletions.

Implementation of async trash for parallel deletions.

@ydailinkedin @chavdar can you review? Thanks!

@chavdar fixed the thread pool.

LGTM

@ydailinkedin addressed comment.

LGTM

Changes Unknown when pulling 6841f92f88f9962833c7245803236540ac29e19e on ibuenros:async-trash into ** on linkedin:master**.


Path Map Settings in README is misleading

I find the Settings information to be misleading.
The README.md specifies the config.cson should contain the following:
"php-debug":
  {
    ServerPort: 9000
    PathMaps: [
      "remotepath;localpath"
      "/base/path/on/remote/system;C:\\base\\path\\on\\local\\system"
    ]
  }

What is actually generated by the settings dialog is this:
"*":
  "php-debug":
    PathMaps: [
      "/srv/repo/www;/Users/matthewpoer/PhpstormProjects/sugar/repo/www"
    ]

One could also just include a screenshot of the Settings dialog where you can easily specify a CSV set of PathMap options.

Should be fixed in v0.3.0


I get build fail when adding url_launcher to my project

when I adding url_launcher to my project I get build fail
name: flutter_app
description: A new Flutter application.

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.2
  url_launcher: ^5.4.1

dev_dependencies:
  flutter_test:
    sdk: flutter

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  # assets:
  #   - images/a_dot_burr.jpeg
  #   - images/a_dot_ham.jpeg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  # fonts:
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

Logs

Launching lib\main.dart on Android SDK built for x86 64 in debug mode...
Running Gradle task 'assembleDebug'...

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':url_launcher'.
> Could not resolve all artifacts for configuration ':url_launcher:classpath'.
   > Could not find builder.jar (com.android.tools.build:builder:3.4.2).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/3.4.2/builder-3.4.2.jar
> Failed to notify project evaluation listener.
   > Could not get unknown property 'android' for project ':url_launcher' of type org.gradle.api.Project.
   > Could not find method implementation() for arguments [project ':url_launcher_web'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
   > Could not find method implementation() for arguments [project ':url_launcher_macos'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3s
Finished with error: Gradle task assembleDebug failed with exit code 1

flutter doctor -v
[√] Flutter (Channel master, v1.14.7-pre.83, on Microsoft Windows [Version 10.0.18363.592], locale en-US)
    • Flutter version 1.14.7-pre.83 at C:\src\flutter
    • Framework revision e10df3c1a6 (2 days ago), 2020-02-01 11:23:01 +0800
    • Engine revision e625e174c5
    • Dart version 2.8.0 (build 2.8.0-dev.6.0 5ae5aff640)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at D:\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = D:\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.41.1)
    • VS Code at C:\Users\rezae\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.1

[√] Connected device (3 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64    • Android 7.0 (API 24) (emulator)
    • Chrome                       • chrome        • web-javascript • Google Chrome 79.0.3945.130
    • Web Server                   • web-server    • web-javascript • Flutter Tools

• No issues found!

Have you tried to build on stable channel?

Have you tried to build on stable channel?

yes I changed to stable channel and there is a problem yet
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':url_launcher'.
> Could not resolve all artifacts for configuration ':url_launcher:classpath'.
   > Could not find builder.jar (com.android.tools.build:builder:3.4.2).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/3.4.2/builder-3.4.2.jar
> Failed to notify project evaluation listener.
   > Could not get unknown property 'android' for project ':url_launcher' of type org.gradle.api.Project.
   > Could not find method implementation() for arguments [project ':url_launcher_web'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
   > Could not find method implementation() for arguments [project ':url_launcher_macos'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s
Finished with error: Gradle task assembleDebug failed with exit code 1

``
[√] Flutter (Channel stable, v1.12.13+hotfix.7, on Microsoft Windows [Version 10.0.18363.592], locale en-US)
    • Flutter version 1.12.13+hotfix.7 at C:\src\flutter
    • Framework revision 9f5ff2306b (7 days ago), 2020-01-26 22:38:26 -0800
    • Engine revision a67792536c
    • Dart version 2.7.0

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at D:\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = D:\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 43.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.41.1)
    • VS Code at C:\Users\rezae\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.1

[√] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 7.0 (API 24) (emulator)

• No issues found!

Does your app use AnodridX? Check it on android\build.gradle

Is your app using AnodridX? Check it on android\build.gradle

yes my app using AndroidX
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    compileSdkVersion 28

    sourceSets {
        main.java.srcDirs += 'src/main/kotlin'
    }

    lintOptions {
        disable 'InvalidPackage'
    }

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "io.github.resfandiari.flutter_app"
        minSdkVersion 16
        targetSdkVersion 28
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }
}

flutter {
    source '../..'
}

dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'androidx.test:runner:1.1.1'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
}

org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
android.useAndroidX=true
android.enableJetifier=true

buildscript {
    ext.kotlin_version = '1.3.50'
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.5.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

I'm not sure but seems that during build the compiler is not able to find gradle 3.4.2

What went wrong:
A problem occurred configuring project ':url_launcher'.
Could not resolve all artifacts for configuration ':url_launcher:classpath'.
Could not find builder.jar (com.android.tools.build:builder:3.4.2).
Searched in the following locations:
https://dl.google.com/dl/android/maven2/com/android/tools/build/builder/3.4.2/builder-3.4.2.jar

But in your configuration you are using classpath 'com.android.tools.build:gradle:3.5.0'.
I'm using the same package version with this build.gradle configuration:
buildscript {
    repositories {
        google()
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:3.4.0'
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

In my case it is classpath 'com.android.tools.build:gradle:3.4.0'

Try this:

buildscript {
repositories {
google()
jcenter()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.2.0'
}
}

and try to refer to this issue Flutter_#22470

Try this:

buildscript {
repositories {
google()
jcenter()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.2.0'
}
}

and try to refer to this issue Flutter_#22470

thank you, This worked for me and build success


[EC-160] Refactor transfer of value in a tx

yes it is not trivial 😉

@rtkaczyk / @ntallar it is up to date now

There are still conflicts

there was no conflict yesterday, will fix it

@rtkaczyk no conflicts


docs: yaml paths style fixes

This patch ensures we coherently use the dot in front of
field paths in the documentation.

/ok-to-merge documentation only patch


Update documentation (#4477)

Pull request opened by the merge tool on behalf of #4477

Merged into branches iso5 in 08767d4b789abdb70bb0e541549c78f821708175


Støtte for dotnet 8

I assume the lack of this caused some issues. What that was is not clear - it should work with a net6 lib on a net8 app, so can you raise an issue explaining what that was, and link to this PR?


Cant disable future message rule

I want to disable all future reviews for the Guest named Somchai
I put Somchai in the search - scheduled reviews appear on dashboard
i select the drop down in the top right corner press actions and select Disable
nothing happens message does not get disabled

I'll look into it right now.  Thanks for creating a new issue.  :)

Ok, I fixed it.  Let me know if it works for you.

work with most messages but not with this two

and these two

I figured out the issue and am working on a fix now.  There are duplicate messages (just in the dashboard, it's different code then the code that sends the messages, it won't send the messages more than once).  I'm working on figuring out why it's happening, it has to do with the new dashboard layout.  I'll let you know when I have a fix.

Ok, I think it's fixed.  Can you verify that it's working now and then I'll look into https://github.com/wootwoot1234/Superhost-Tools/issues/43 again.


impl blocking read

Running strace on Kiro reveals that it polls every 100ms for an input
returning 0 if nothing was read. This pull request implements a blocking
read for noncanonical mode as specified in the canonical and
noncanonical section in the termios man page:
https://man7.org/linux/man-pages/man3/termios.3.html
This provides a more efficient reading of the input, by blocking after
an empty read of 0 bytes without wasteful polling cycles.

Thank you for suggesting this change.
I implemented reading chars asynchronously because there may be other asynchronous feature added in the future. For example, if we add support for formatters, running a formatter process asynchronously would require to make read chars asynchronous.
But currently we don't have such the feature for now. So I think it's ok to make reading chars blocking if it really affects performance. Did you find any meaningful performance improvements with this change?

I implemented reading chars asynchronously because there may be other asynchronous feature added in the future. For example, if we add support for formatters, running a formatter process asynchronously would require to make read chars asynchronous.

That makes sense.

But currently we don't have such the feature for now. So I think it's ok to make reading chars blocking if it really affects performance. Did you find any meaningful performance improvements with this change?

Nothing statistically significant from the benches I ran so i'm happy for you to close this pull if you want I ran. Heres the top 3 runs for each out of 5 runs (the tests were run on an SQ1 ARM64 processor, so results are likely to be across the board slower than what your used to seeing):
Async read:
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  21,227,070 ns/iter (+/- 5,869,550)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 294,399,760 ns/iter (+/- 38,843,049)
test no_term_scroll_up_down_plain_text   ... bench:   1,826,435 ns/iter (+/- 805,845)
test no_term_scroll_up_down_rust_code    ... bench:   8,478,310 ns/iter (+/- 2,187,853)
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  20,981,970 ns/iter (+/- 2,226,994)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 281,824,130 ns/iter (+/- 15,390,393)
test no_term_scroll_up_down_plain_text   ... bench:   1,842,310 ns/iter (+/- 32,067)
test no_term_scroll_up_down_rust_code    ... bench:   8,494,480 ns/iter (+/- 1,775,388)
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  20,778,460 ns/iter (+/- 521,697)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 298,071,340 ns/iter (+/- 86,771,665)
test no_term_scroll_up_down_plain_text   ... bench:   1,852,977 ns/iter (+/- 1,526,645)
test no_term_scroll_up_down_rust_code    ... bench:   9,379,870 ns/iter (+/- 4,123,508)
Blocking read:
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  20,769,960 ns/iter (+/- 3,247,478)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 294,269,140 ns/iter (+/- 49,102,896)
test no_term_scroll_up_down_plain_text   ... bench:   1,845,752 ns/iter (+/- 311,698)
test no_term_scroll_up_down_rust_code    ... bench:   8,812,825 ns/iter (+/- 1,366,026)
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  20,868,280 ns/iter (+/- 1,036,625)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 288,901,810 ns/iter (+/- 25,186,931)
test no_term_scroll_up_down_plain_text   ... bench:   1,842,875 ns/iter (+/- 574,316)
test no_term_scroll_up_down_rust_code    ... bench:   8,676,095 ns/iter (+/- 381,880)
test no_term_edit_1000_operations_to_10000_chars_plain_text   ... bench:  20,970,470 ns/iter (+/- 2,329,955)
test no_term_edit_1000_operations_to_editor_rs                ... bench: 279,762,900 ns/iter (+/- 14,083,083)
test no_term_scroll_up_down_plain_text   ... bench:   1,841,185 ns/iter (+/- 618,122)
test no_term_scroll_up_down_rust_code    ... bench:   8,476,660 ns/iter (+/- 643,426)

I'm sorry for confusion, but those benchmarks are not helpful to measure changes in this PR. Since Iterator<InputSeq> is an abstraction layer of user inputs, the benchmark implements its own iterator.
https://github.com/rhysd/kiro-editor/blob/b5d34c371b71affedfd83131f07b0661e60dd2f8/benches/edit.rs#L121
It does not read inputs from stdin. Instead, it generates random inputs. The benchmarks are for measuring core logic of this editor. So reading stdin is out of scope.
I think we should have E2E benchmark suites.

I also believe this PR change improves performance since it reduces syscalls.
OK, I'll merge this PR and will add new benchmark which covers reading stdin inputs. And then I'll be able to check performance change in this PR.


Downloaded app image crashes on start 'symlink' access error

downloaded image here :
https://github.com/ipfs-shipyard/ipfs-desktop/releases/download/v0.10.2/ipfs-desktop-0.10.2-linux-x86_64.AppImage
Check what kind of file it is :
file ipfs-desktop-0.10.2-linux-x86_64.AppImage
ipfs-desktop-0.10.2-linux-x86_64.AppImage: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/l, for GNU/Linux 2.6.18, stripped
Make executable :
oetelaar@DT-Helmond:~/Downloads$ chmod +x ipfs-desktop-0.10.2-linux-x86_64.AppImage
Run it :
oetelaar@DT-Helmond:~/Downloads$ ./ipfs-desktop-0.10.2-linux-x86_64.AppImage
Warnings from gtk :
(ipfs-desktop:19190): Gtk-WARNING **: 13:11:36.420: Theme parsing error: gtk.css:68:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version
(ipfs-desktop:19190): Gtk-WARNING **: 13:11:36.420: Theme parsing error: gtk.css:69:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version
(ipfs-desktop:19190): Gtk-WARNING **: 13:11:36.420: Theme parsing error: gtk.css:73:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version
2019-12-21T12:11:37.048Z info: [meta] logs can be found on /home/oetelaar/.config/IPFS Desktop
(node:19190) ProtocolDeprecateCallback: The callback argument of protocol module APIs is no longer needed.
(node:19190) ProtocolDeprecateCallback: The callback argument of protocol module APIs is no longer needed.
Checking for update
Generated new staging user ID: 57c3c941-1822-578f-ab74-c60c33cef565
Update for version 0.10.2 is not available (latest version: 0.10.2, downgrade is disallowed).
2019-12-21T12:11:39.359Z info: [web ui] window ready
2019-12-21T12:11:39.359Z info: [tray] starting
2019-12-21T12:11:39.387Z info: [tray] started
2019-12-21T12:11:39.387Z info: [ipfsd] start daemon STARTED
2019-12-21T12:11:40.495Z info: [daemon] gateway port busy
Gtk-Message: 13:11:40.549: GtkDialog mapped without a transient parent. This is discouraged.
2019-12-21T12:12:09.297Z info: [daemon] ports updated
2019-12-21T12:12:10.065Z info: [ipfsd] start daemon FINISHED 30.677251384735108s
2019-12-21T12:12:10.105Z info: [npm on ipfs] 1st time running and package is not installed
2019-12-21T12:12:10.112Z info: [npm on ipfs] no action taken
2019-12-21T12:12:10.121Z info: [launch on startup] disabled
2019-12-21T12:12:10.207Z info: [ipfs on path] no-sudo: stderr: fs.js:126
throw err;
^
It stops working
Error: EACCES: permission denied, symlink '/tmp/.mount_ipfs-dIn8Cte/resources/app.asar.unpacked/out/ipfs-on-path/scripts/ipfs.sh' -> '/usr/local/bin/ipfs'
at Object.symlinkSync (fs.js:935:3)
at Object.createSymlinkSync (/tmp/.mount_ipfs-dIn8Cte/resources/app.asar/node_modules/fs-extra/lib/ensure/symlink.js:55:25)
at Object. (/tmp/.mount_ipfs-dIn8Cte/resources/app.asar/out/ipfs-on-path/scripts/install.js:62:21)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
at Module._load (internal/modules/cjs/loader.js:648:12)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Function.Module.runMain (internal/modules/cjs/loader.js:944:10) {
errno: -13,
syscall: 'symlink',
code: 'EACCES',
path: '/tmp/.mount_ipfs-dIn8Cte/resources/app.asar.unpacked/out/ipfs-on-path/scripts/ipfs.sh',
dest: '/usr/local/bin/ipfs'
}
^C
This is a normal linux system, i9 based
at /proc/cpuinfo
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 158
model name	: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
stepping	: 12
microcode	: 0xae
cpu MHz		: 800.033
cache size	: 16384 KB
physical id	: 0
Running Ubuntu :+1: Linux DT-Helmond 4.18.0-15-generic #16~18.04.1-Ubuntu SMP Thu Feb 7 14:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Nothing special as far as I can see.
I will try DEB package now...

The same issue using Debian 10. Appimage doesn't roll.

@alphanmoon is this still a problem with v0.13.2?

I am afraid the only fix here is to find IPFS Desktop/config.json and manually set:
"ipfsOnPath": false,

We will be deprecating this feature (https://github.com/ipfs-shipyard/ipfs-desktop/pull/1768), if you want ipfs on your PATH   follow https://docs.ipfs.io/install/command-line/


With --enable-cxx-namespaces, can't use bindings in submodule within crate

Or else the various use root; statements don't match the path they need to, which would be use self::root; I think.
This is rather frustrating, and means I have to use include!(bindings.rs) in the crate's lib.rs instead of mod bindings; to maintain some semblance of file tidiness/separation.
I am unsure what a fix would look like. Ideas?

I'm duping this with #96, but feel free to comment there. Shouldn't be hard to fix.


Bump 0.1.9

Pull Request Test Coverage Report for Build 329

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.592%

Totals

Change from base Build 420:
0.0%

Covered Lines:
939

Relevant Lines:
1113

💛  - Coveralls


Fix url bugs in docs

Summary
Easy navigation and easy reading for others

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4747a86e9929763891bb4308a4be9bf7899e1457/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jpa.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e6587cb7392443e9c6ad7df32a64ab62bddeaa1b/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md

@RaduBerinde can you look into this sir

Made the fix both in v20.1 and v20.2

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/775e346fb8258c337a3bef4054a89c44c98c762a/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/81d1b7eff8611aa4251bde83faafb2b60497a4a2/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md
v20.2/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jpa.md

@saintmalik Thank you for contributing to CockroachDB this year. As a token of our appreciation we would like to send you a gift. Please DM me on our community Slack @lisa so I can send you a link. (If you don’t want a gift, we also have a charitable contribution choice.) All orders need to be in by December 13, so please send this asap. :)


Publish new documentation for 0.8 and OSS releases to live.

Docs Build status updates of commit b8d0d5d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/index.md
:warning:Warning

Details

articles/install-guide/index.md
:warning:Warning

Details

api/docfx.json
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/contributing/index.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/index.md

[Warning] 1 invalid cross reference(s) "microsoft.com.contributing".

articles/install-guide/index.md

Line 29: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vs2017).
Line 37: [Warning] Invalid file link:(~/quickstart?tabs=tabid-vscode).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 20f7e83:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/index.md
:warning:Warning

Details

api/docfx.json
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/contributing/index.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md
:white_check_mark:Succeeded

articles/index.md

[Warning] 1 invalid cross reference(s) "microsoft.com.contributing".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 97e62e7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/index.md
:warning:Warning

Details

api/docfx.json
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/contributing/index.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/language/expressions.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md
:white_check_mark:Succeeded

articles/index.md

[Warning] 1 invalid cross reference(s) "microsoft.com.contributing".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1611e5d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/index.md
:warning:Warning

Details

api/docfx.json
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/contributing/index.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/language/expressions.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md
:white_check_mark:Succeeded

articles/index.md

[Warning] 1 invalid cross reference(s) "microsoft.com.contributing".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit cbae5b7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/docfx.json
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/contributing/index.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/index.md
:white_check_mark:Succeeded

articles/install-guide/index.md
:white_check_mark:Succeeded

articles/install-guide/jupyter.md
:white_check_mark:Succeeded

articles/install-guide/python.md
:white_check_mark:Succeeded

articles/language/expressions.md
:white_check_mark:Succeeded

articles/quickstart.md
:white_check_mark:Succeeded

articles/relnotes/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Why opening dev/mem and not dev/gpiomem ?

Hi
I'm using pigpio with a C++ project (using ROS2).
The thing is I can't run ROS2 as sudo but I need ROS2 to run my package, wich use pigpio.
I've tried everything to have a normal user having access to pigpio. (adding the user to the kmem and gpio group; lowering the access restriction on /dev/mem ...)
But everytime, I get the failure message when gpioInitialise call open("/dev/mem, ...)
So I was wondering why do you need to open /dev/mem instead of /dev/gpiomem.
Also, if you have a general clue to help me with my problem, please don't hesitate.
Thank you :)

/dev/gpiomem only gives access to the GPIO hardware peripheral.
pigpio also makes use of the PWM, PCM, DMA, SYST, SPI, and BSC hardware peripherals.  They can only be accessed via /dev/mem.
You might be able to use the Linux capabilities features rather than using root permissions.  I seem to remember I was successful in using capabilities.
I suggest you start with man capabilities.
Of course an alternative is to rewrite your code to use the pigpio daemon.

Thank you for your quick answer.
I will keep looking then :)
It might interest some users to have an optional boolean argument "limited" in the gpioInitialize function wich would only require rights on gpiomem instead of mem (with limited functionalities of course) :)


Purge project, sponsorship stuff

Pull Request 30
Branches Compared

Discobots-1104A-master :arrow_left: Discobots-1104A-marco-dec_2020
Proposed Changes

➕ Add OkapiLib.
➕ Add new files for sponsorship reasons.
➖ Remove the entire old project.
✅ Fix .gitignore to ignore scripts for PROS to LaTeX stuff.
💡 We're making the change over to OkapiLib because of time constraints.
💡 There's gonna be basically nothing in /src because I haven't put anything in it yet.

The Codacy failed check is related to using OkapiLib so it's fine, ignore it.


Import token followed by square bracket panics

Describe the bug
import[expr] within an expression panics.
Input code
const str = "meta";

console.log(import[str]);

Config
No response
Playground link
No response
Expected behavior
Syntax error
Actual behavior
thread 'main' panicked at 'internal error: entered unreachable code', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/swc_ecma_parser-0.104.0/src/parser/expr.rs:1186:43

Version
swc_ecma_parser 0.104.0
Additional context
No response

According to the spec, you have to use literal property access expression.
import[expr] is not valid.


Feature Request: Continuous Integration for meta-ros

This issue exists so anyone interested in CI/CD for the meta-ros project can talk about their progress, set of requirements and early stage documentation.
Some discussion about this started on:
https://github.com/bmwcarit/meta-ros/issues/485
But CI merits it's own conversation.
So far people interested are: @bulwahn @rojkov @TSC21

I put some work a few months ago to adapt the ostro project CI to just build all recipes found on all of the layers of a bitbake build.
bitbake-layers show-recipes
Maybe that was overkill as it would take way longer than just building core-image-ros-world
Here are a few links that got me started:
Intel CI/CD OpenIoT Summit Presentation
Ostro Project CI/CD ansible
Ostro Project CI/CD
Currently all my work was local and has some work specific code on it. Since there are people interested, I'll remove that and make it available. Given my current schedule, this will probably happen by the first or second week of May. (About two weeks from now)

We should talk about requirements thought, just so that all efforts go on the same direction.
I am aiming to produce a CI that given a bitbake layer it just builds everything on it. It was something generic so I could use it on other yocto/oe based projects too.
Maybe that's too little, maybe it's too much. It only ensures that recipes build. Thoughts?

In the meantime, @rojkov has installed a continuous integration for meta-ros. We are surely open to improvements of any kind as long as it does not break what we already have in place.


net/http, crypto/tls: first HTTP request is consistently slower during TLS handshake in Go 1.17, but not 1.18

What version of Go are you using (go version)?

$ go version
go version go1.17.5 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.5"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0h/wc_q919d4_9_f0wj1p4v4h840000gn/T/go-build4221745526=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I'm seeing the first http request using net/http package and Client to be consistently 100-200ms slower than the consecutive ones. This happens both when sending requests to one or multiple servers. The code to reproduce the issue:
package main

import (
	"crypto/tls"
	"fmt"
	"net/http"
	"net/http/httptrace"
	"time"
)

func main() {
	request := func (client *http.Client, url string) {
		t := time.Now()
		fmt.Println("")
		clientTrace := &httptrace.ClientTrace{
			GetConn:      func(hostPort string) { s := time.Now(); fmt.Println(s.Sub(t), "starting to create conn ", hostPort); t = s },
			DNSStart:     func(info httptrace.DNSStartInfo) { s := time.Now(); fmt.Println(s.Sub(t), "starting to look up dns", info); t = s },
			DNSDone:      func(info httptrace.DNSDoneInfo) { s := time.Now(); fmt.Println(s.Sub(t), "done looking up dns", info); t = s },
			ConnectStart: func(network, addr string) { s := time.Now(); fmt.Println(s.Sub(t), "starting tcp connection", network, addr); t = s },
			ConnectDone:  func(network, addr string, err error) { s := time.Now(); fmt.Println(s.Sub(t), "tcp connection created", network, addr, err) ; t = s},
			GotConn:      func(info httptrace.GotConnInfo) { s := time.Now(); fmt.Println(s.Sub(t), "connection established", info.Reused); t = s },
			GotFirstResponseByte: func() { s := time.Now(); fmt.Println(s.Sub(t), "got first byte"); t = s },
			TLSHandshakeStart: func() { s := time.Now(); fmt.Println(s.Sub(t), "handshake start"); t = s },
			TLSHandshakeDone: func(tt tls.ConnectionState, e error) {s := time.Now(); fmt.Println(s.Sub(t), "handshake end"); t = s},
		}

		req, _ := http.NewRequest("GET", url, nil)
		req.Close = true
		clientTraceCtx := httptrace.WithClientTrace(req.Context(), clientTrace)
		req = req.WithContext(clientTraceCtx)
		response, _ := client.Do(req)
		response.Body.Close()
	}

	client := &http.Client{}
	request(client, "https://news.ycombinator.com")
	client = &http.Client{}
	request(client, "https://news.ycombinator.com")
	client = &http.Client{}
	request(client, "https://news.ycombinator.com")
}

What did you expect to see?
Roughly the same timings for all the requests.
What did you see instead?
145.166µs starting to create conn  news.ycombinator.com:443
276.459µs starting to look up dns {news.ycombinator.com}
58.451916ms done looking up dns {[{<IP_ADDRESS> }] <nil> false}
616.542µs starting tcp connection tcp <IP_ADDRESS>:443
190.6365ms tcp connection created tcp <IP_ADDRESS>:443 <nil>
711.875µs handshake start
517.936208ms handshake end
620.167µs connection established false
194.723083ms got first byte

115.5µs starting to create conn  news.ycombinator.com:443
93.959µs starting to look up dns {news.ycombinator.com}
8.060583ms done looking up dns {[{<IP_ADDRESS> }] <nil> false}
41.167µs starting tcp connection tcp <IP_ADDRESS>:443
179.021541ms tcp connection created tcp <IP_ADDRESS>:443 <nil>
224.875µs handshake start
362.071834ms handshake end
152.291µs connection established false
180.119625ms got first byte

91.333µs starting to create conn  news.ycombinator.com:443
129.208µs starting to look up dns {news.ycombinator.com}
2.597417ms done looking up dns {[{<IP_ADDRESS> }] <nil> false}
74.833µs starting tcp connection tcp <IP_ADDRESS>:443
181.5515ms tcp connection created tcp <IP_ADDRESS>:443 <nil>
151.334µs handshake start
359.525791ms handshake end
157.042µs connection established false
179.980583ms got first byte

The slowdown for the first request happens for every server I tried and it's always only the first request, whether the Client is reused or recreated for every request.
Just to make sure that there's no confusion - I tried this for multiple servers, the first request is always slower. For server X, the average request duration is N if it's the first request and M if it's one of the consecutive requests. Duration M for consecutive requests is roughly the same across multiple runs regardless of whether the first request was to the server X or some other server. The duration M is always 100-200ms lower than N.
The logs I posted seem to indicate that the bulk of the slowdown is coming from TLS handshake. I couldn't find anything in the code that would point to some overhead/initialization happening exclusively for the first request.
I'm not necessarily saying there's a bug - this might be the expected behavior. In that case it would be great to update the documentation, I spend few hours researching this and found no explanation for this behavior.
Thank you for your time!

In the test performed, client := &http.Client{} looks suspicious. From https://pkg.go.dev/net/http#Client.Transport:
// Transport specifies the mechanism by which individual
// HTTP requests are made.
// If nil, DefaultTransport is used.
Transport RoundTripper

If all 3 instances of an HTTP client end up reusing the default transport, there may be something cached and reused for future connections.
Maybe this isn't a problem because of req.Close = true line, but still, I'd suggest avoiding reusing the transport to make the test more fair.
This doesn't appear to reproduce consistently for me with Go 1.18 Beta 1 and using my internet. I got a result that looks like:
$ go run . | grep "got first byte"
112.980708ms got first byte
93.152333ms got first byte
84.753375ms got first byte
$ go run . | grep "got first byte"
79.133125ms got first byte
85.475709ms got first byte
82.661083ms got first byte
$ go run . | grep "got first byte"
80.984625ms got first byte
78.987416ms got first byte
91.047583ms got first byte

So, it happened on first program execution, but not second and third.
I would imagine this can happen because of how the internet works: when making a request to a new server for the first time, routers take a bit longer to route packets the first time. For subsequent requests, those "first time" delays aren't incurred. For related discussion, see https://stackoverflow.com/questions/54078692/why-first-network-call-takes-more-time-than-subsequent-ones.
This is to say there may still be room for improvement in certain parts of net/http, but the provided test is too high level to find where the opportunities may be.

consistently 100-200ms slower

Can you clarify how you're getting to that number? From your log, it looked like all 3 requests got first byte within 20 ms, not 100-200 ms.

I'd suggest avoiding reusing the transport to make the test more fair.

I tried running this with creating each client like this:
client := &http.Client{
	Transport: &http.Transport{
		Proxy: http.ProxyFromEnvironment,
		DialContext: (&net.Dialer{
			Timeout:   30 * time.Second,
			KeepAlive: 30 * time.Second,
		}).DialContext,
		ForceAttemptHTTP2:     true,
		MaxIdleConns:          100,
		IdleConnTimeout:       90 * time.Second,
		TLSHandshakeTimeout:   10 * time.Second,
		ExpectContinueTimeout: 1 * time.Second,
	},
}

and the issue persists.

Can you clarify how you're getting to that number? From your log, it looked like all 3 requests got first byte within 20 ms, not 100-200 ms.

Yes, I was not clear about this in my original post - the line to track is handshake end in the log. The timings are not cumulative.
janivanecky@MacBook-Pro blnk % go run example.go | grep "handshake end"
499.478584ms handshake end
358.794625ms handshake end
358.046667ms handshake end
janivanecky@MacBook-Pro blnk % go run example.go | grep "handshake end"
496.45375ms handshake end
363.463291ms handshake end
356.473209ms handshake end

I would imagine this can happen because of how the internet works: when making a request to a new server for the first time, routers take a bit longer to route packets the first time. For subsequent requests, those "first time" delays aren't incurred. For related discussion, see https://stackoverflow.com/questions/54078692/why-first-network-call-takes-more-time-than-subsequent-ones.

Makes sense, but I'm seeing the same thing when across different servers:
janivanecky@MacBook-Pro blnk % go run example.go | grep "handshake end"
487.623042ms https://news.ycombinator.com handshake end
33.04375ms https://twitter.com handshake end
janivanecky@MacBook-Pro blnk % go run example.go | grep "handshake end"
131.811708ms https://twitter.com handshake end
360.978583ms https://news.ycombinator.com handshake end

Thanks for clarifying.
I'm still not seeing the same difference you're describing on my machine, at least not with Go 1.18 Beta 1:
$ go run . | grep "handshake end"
184.652292ms handshake end
185.861708ms handshake end
232.005459ms handshake end
$ go run . | grep "handshake end"
206.014125ms handshake end
198.452334ms handshake end
171.361875ms handshake end
$ go run . | grep "handshake end"
181.764333ms handshake end
180.761042ms handshake end
176.7205ms handshake end

I'll let someone more familiar with net/http and crypto/tls take a look, possibly later on due to #50241.

Thank you anyways Dmitri!
I tried running this with Go 1.18 Beta 1 and I don't see the issue either. I think the absolute first request to the server is still the slowest, by a small margin, but the speed up persists across multiple runs.

Closing as 1.17 is no longer supported


Can not run example on ios simulator

@jorgefspereira I'm getting the following warning on ios:
ld: warning: ignoring file  ../example/ios/Pods/PersonaInquirySDK/Persona.xcframework/ios-arm64/Persona.framework/Persona, building for iOS Simulator-x86_64 but attempting to link with file built for iOS-arm64
Undefined symbols for architecture x86_64:
<omitted>

[✓] Flutter (Channel stable, 1.22.4, on macOS 11.1 20C69 darwin-x64, locale en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
[✓] VS Code (version 1.52.1)

I've tried updating the xcode build settings to exclude archs arm64 for ios simulator and valid archs to x86_64, but it didn't help. Also tried putting this in my podfile:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
      config.build_settings["ONLY_ACTIVE_ARCH"] = "YES"
      config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
    end
  end
  installer.pods_project.build_configurations.each do |config|
    config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = 'arm64'
  end
end

Are you able to recreate the issue and fix?

I'll try to replicate the issue.

Hi @tuanvugoodmoney, I was unable to reproduce the error. I updated the plugin to version 1.1.0 wich includes the latest Persona SDKs. Please give it a try. Feel free to reopen the issue if persists.