ProcessTimedOutException when exporting with wkhtmltopdf

For Bug Reports

BookStack Version : v0.22.0
PHP Version: PHP 7.0.30-0ubuntu<IP_ADDRESS> (cli) ( NTS )
MySQL Version: Ver 14.14 Distrib 5.7.22, for Linux (x86_64)
Linux Version: Ubuntu Server 16.04 LTS

Expected Behavior
Exported PDF.
Current Behavior
When starting the export of a large page, or whole chapters the export is failing with wkhtmltopdf extension.
Steps to Reproduce
Select Export to PDF option.

I imagine it has to be something with the default timeouts of the PHP engine?

https://stackoverflow.com/questions/5164930/fatal-error-maximum-execution-time-of-30-seconds-exceeded
I can not give you more specific instruction since I do not how the webserver is talking to php in your setup.

It was installed on the clean 16.04 Server install with the Ubuntu installer script. I've changed
max_execution_time = 300 max_input_time = 120
in the php.ini, but PDF export still timeouts on larger html pages.

Try in settings/snappy.php to change the pdf sections timeout to 3600 - https://github.com/BookStackApp/BookStack/blob/b3cc3130f092ce571f47a67bcd199ead18cdd1f9/config/snappy.php#L7

@TBK Hi, great tip, it seems that it failed at loading some of the images.
/var/www/bookstack/vendor/knplabs/knp-snappy/src/Knp/Snappy/AbstractGenerator.php
                'The file \'%s\' was created but is empty (command: %s).',
                $output, $command
            ));
        }
    }

    /**
     * Checks the process return status.
     *
     * @param int    $status  The exit status code
     * @param string $stdout  The stdout content
     * @param string $stderr  The stderr content
     * @param string $command The run command
     *
     * @throws \RuntimeException if the output file generation failed
     */
    protected function checkProcessStatus($status, $stdout, $stderr, $command)
    {
        if (0 !== $status and '' !== $stderr) {
            throw new \RuntimeException(sprintf(
                'The exit status code \'%s\' says something went wrong:' . "\n"
                . 'stderr: "%s"' . "\n"
                . 'stdout: "%s"' . "\n"
                . 'command: %s.',
                $status, $stderr, $stdout, $command
            ));
        }
    }

    /**
     * Creates a temporary file.
     * The file is not created if the $content argument is null.
     *
     * @param string $content   Optional content for the temporary file
     * @param string $extension An optional extension for the filename
     *
     * @return string The filename
     */
    protected function createTemporaryFile($content = null, $extension = null)
    {
Arguments
"""
The exit status code '1' says something went wrong:\n
stderr: "Loading pages (1/6)\n
[>                                                           ] 0%\r[======>                                                     ] 10%\r[===========================>                                ] 45%\r[============================>                               ] 48%\r[=====================================>                      ] 63%\r[=======================================>                    ] 66%\r[============================================>               ] 74%\r[================================================>           ] 80%\r[=================================================>          ] 83%\r[===================================================>        ] 86%\r[====================================================>       ] 88%\rWarning: Failed to load https://book.mikronis-it.si/uploads/images/gallery/2018-05-May/scaled-840-0/Iq8wMUbFR7CzZZXW-2018-05-05-15_50_21_My-Calendar-_-Vladimir-Putin--Axigen-WebMail.png (ignore)\n ◀
Warning: Failed to load https://book.mikronis-it.si/uploads/images/gallery/2018-05-May/scaled-840-0/8cB1vvNmtqpwQtyO-2018-05-10-21_13_28_Test-_-Tadej-Rudec--Axigen-WebMail.png (ignore)\n ◀
[============================================================] 100%\rCounting pages (2/6)                                               \n
[============================================================] Object 1 of 1\rResolving links (4/6)                                                       \n
[============================================================] Object 1 of 1\rLoading headers and footers (5/6)                                           \n
Printing pages (6/6)\n
[>                                                           ] Preparing\r[====>                                                       ] Page 1 of 14\r[========>                                                   ] Page 2 of 14\r[============>                                               ] Page 3 of 14\r[================>                                           ] Page 4 of 14\r[=====================>                                      ] Page 5 of 14\r[=========================>                                  ] Page 6 of
14\r[==============================>                             ] Page 7 of 14\r[==================================>                         ] Page 8 of 14\r[======================================>                     ] Page 9 of 14\r[==========================================>                 ] Page 10 of 14\r[==============================================>             ] Page 11 of 14\r[===================================================>        ] Page 12 of 14\r[=======================================================>    ] Page 13 of 14\r[============================================================] Page 14 of 14\rDone                                                                        \n ◀
Exit with code 1 due to network error: TimeoutError\n
"\n
stdout: ""\n
command: /var/www/bookstack/wkhtmltopdf --lowquality --print-media-type '/tmp/knp_snappy5b274ec7d434a8.00148987.html' '/tmp/knp_snappy5b274ec7d77785.41891400.pdf'. ◀
"""

Two images which failed to load are attached here:

v12.4, but I just saw that v12.5 is out for couple days. Same issue with it.
Only difference when trying with v12.5 is that the error message was Socket operation timed out:
Error: Failed to load https://book.mikronis-it.si/uploads/images/gallery/2018-05-May/scaled-840-0/R0n4rFycGCtZIEcn-2018-05-05-21_09_49_[2]-Total-Commander-(x64)-9.12---Tadej-Rudec.png, with network status code 4 and http status code 0 - Socket operation timed out\n

Yes, it's a private documentation server, but if the authorization was an issue, it would fail with all images on all exports. I also disabled it for a test, but same error persisted.

Are the other image urls relative or absolute?

All images are absolute.

I only got couple of things left that could possible cause the issue:

Check that /tmp/knp_snappy5b274ec7d434a8.00148987.html is valid HTML.
Characters in the file name that it does not like.
It could be an issue with the images encoding.

If it is not 1 then I think we have established that the issue contained to wkhtmltopdf.

Great tips @TBK , I've checked the .pdf in /tmp and saw the the certain images were indeed missing.
It seems that filenames containing []% characters were failing at export. When renaming the images, reuploading them and readding to the page the pdf export was instant (so adding the timeout wasn't actually needed).
This notice regarding image naming could be perhaps added to the installation or usage guide.

File upload could sanitize the file name. What do you think @ssddanbrown ?


Arguments Incorrect

Continuous integration with Azure Pipelines
Step #2
/p:USQLSDKPath=/p:USQLSDKPath=$(Build.SourcesDirectory)/packages/Microsoft.Azure.DataLake.USQL.SDK.1.3.180615/build/runtime
Should be:
/p:USQLSDKPath=$(Build.SourcesDirectory)/packages/Microsoft.Azure.DataLake.USQL.SDK.1.3.180615/build/runtime
/p:USQLSDKPath=/p:USQLSDKPath= Cant be correct...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c4f5005-badf-be90-53d2-43caaf3f75c4
Version Independent ID: 40319ba7-072b-5984-cb88-36a733161ba8
Content: How to set up a CI/CD pipeline for Azure Data Lake Analytics
Content Source: articles/data-lake-analytics/data-lake-analytics-cicd-overview.md
Service: data-lake-analytics
GitHub Login: @yanancai
Microsoft Alias: yanacai

@solidcloudio Thanks for the feedback! We are currently investigating and will update you shortly. Also if You are interested in becoming a contributor. You are more than welcome to create a pull request with the fix, that then will be evaluated and merged if approved https://docs.microsoft.com/en-us/contribute/

@solidcloudio Thanks again for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thanks @solidcloudio for your feedback! Like you said, the command line is not correct. I am updating the doc with PR MicrosoftDocs/azure-docs-pr#59363.

#please-close the PR is published.


Bug located in ... Body label imports

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
I am facing issue for importing body labels from SpaceClaim. Face labels are importing correctly.
📝 Steps to reproduce
You can create a simple box and assign body label in SpaceClaim. After importing into pyprimemesh it fail to import body labels
💻 Which operating system are you using?
Windows
📀 Which ANSYS version are you using?
23R1SP1
🐍 Which Python version are you using?
3.9
📦 Installed packages
ansys-api-meshing-prime==0.1.1
-e git+https://github.com/pyansys/pyprimemesh@a8b05bdfdfa8d5c976cd0b46afa611152bd6a705#egg=ansys_meshing_prime
appdirs==1.4.4
certifi==2022.12.7
charset-normalizer==3.0.1
contourpy==1.0.7
cycler==0.11.0
fonttools==4.38.0
grpcio==1.51.1
idna==3.4
imageio==2.25.0
kiwisolver==1.4.4
matplotlib==3.6.3
numpy==1.24.1
packaging==23.0
Pillow==9.4.0
pooch==1.6.0
protobuf==3.20.3
pyparsing==3.0.9
python-dateutil==2.8.2
pyvista==0.38.1
requests==2.28.2
scooby==0.7.1
six==1.16.0
urllib3==1.26.14
vtk==9.2.5

Hi @Rohits28 it's been added/fixed in the 0.4.0 dev build so I will not create a duplicate defect for this. Thanks


fix: new header project title

This PR... #3006
Changes

the project title style

Fixes

How to test it

Screenshots

https://user-images.githubusercontent.com/20525304/212888996-73f106c0-2833-418f-b738-e5591da4272a.mp4
Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

I am also getting this warning when running the app

I'm guessing it might be because of this

Can we also vertically align these?


Change execution policy to parallel using C++17 for-each in filling Hessian matrix

Time improvement:

PR: 189 sec
Main : 284 sec

WowWysłane z iPhone'aWiadomość napisana przez Michał Pełka @.***> w dniu 21.07.2023, o godz. 23:23:
Time improvement:
PR: 189 sec
Main : 284 sec
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>


tests: fix -Werror,-Wimplicit-int-float-conversion

testes/dispatch_timer_short.c:58:74: error: implicit conversion from 'unsigned long long' to 'double' may loose precision [-Werror,-Wimplicit-int-float-conversion]
	test_long_less_than("Frequency", 1, (long)ceil((double)delay/(finalCount*interval)));
	~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~

Fix the casting for finalCount and explicitly cast the result which would be
an unsigned long long due to the multiplication by interval.

@swift-ci please test

@ktopley-apple - okay to merge?


Refactor edge semantics

As discussed before, here is my proposal for generalizing edge semantics more. This way we can reuse these edges for other datasets besides the workspace.
All queries will traverse based on "from_vertex_collection_name -> edge_name -> to_vertex_collection_name". All of these relationships can be described contextually using the set of three things.

I think is_identical_to is clearer than is_equal_to. Do you intend to link detail (e.g. genome) objects with this or workspace_object_versions?
was_created_by critically contains the object method specs for object creation so I think we need a specialized edge for that or we need to add that as an optional attribute in was_produced_by
I'm not sure which one of these is a replacement for was_input_in_creation_of I assume was_created_with?
To communicate usage of these edges we really need a schematic.

I was intending was_created_with to be used instead of was_input_in_creation_of.
We may be able to use arango's "graph" feature to convey how these edges get used. A graph definition is just a json array of vertex, edge, vertex triples:
[ { "collection": "was_created_from", "from": [ "ws_object_versions" ], "to" : [ "ws_object_versions" ] } ]

Like I mentioned in slack, the downside of using generic edges is we can't have strict schemas on edge attributes, since we're reusing them in different contexts. The two options are:

make some edges more specific (I would prefer an exact name like ws_object_was_created_by_method)
use a generic edge but have additionalProperties: true

I propose we have both very generic edges and very specific edges as needed. I can create these two edges in addition to what's here:

ws_object_was_created_with_method
ws_object_was_created_with_module

I'm fine with ws_object_was_created_with_method is fine but shouldn't ws_object_was_created_with_module just use was_created_using

I guess that's true, I'm going in circles. I'll remove that.
A good strategy could be to start out using the highly generic edges when we can, and when we find out we need more specific stuff, make a highly specific edge.


Title for diff reports does not incorporate diff-range-notation

Thanks for the great tool. Very handy!
I notice that when the diff-range-notation is ".." the 'diff title' is still Diff: origin/main...HEAD (three dots instead of two)
 diff-cover coverage.xml --diff-range-notation=..
-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
No lines with coverage information in this diff.
-------------

Yeah, looks like we are hardcoding this.
I think https://github.com/Bachmann1234/diff_cover/pull/289 will fix it

@prescod try version 7.0.0. I hope you are not using python 3.6 since I ended up dropping it in this release
https://pypi.org/project/diff-cover/7.0.0/


Feature Request: Add actions to patterns

Would be great to define actions in a pattern. A use case I have is the Profile pattern's username field. Would be great to have a SetUsernameAction that can be defined once and not on every profile.

yup, related https://github.com/lolopinto/ent/issues/596
i even wrote this comment today https://github.com/lolopinto/ent/blob/main/internal/schema/input/input.go#L22 when fixing https://github.com/lolopinto/ent/pull/702

Great! It does make sense to me to copy most everything from Node. I’m sure having constraints and indices will be valuable too.


sh: Can't open /home/chronos/user/Downloads/crouton

sh: Can't open /home/chronos/user/Downloads/crouton

Please describe your issue: I have checked essentially every other issue relating to this but none are helping, everything seems to be in working order though itseems it doesn't have access.
If known, describe the steps to reproduce the issue: In shell, still on chrome OS, write
sudo sh ~/Downloads/crouton -t unity
as that seems to be the problem. I have installed crouton and tried many things though none work. Thanks in advance!

Please read or re-read the README that explains the new installation method.

sh: Can't open /home/chronos/user/Downloads/crouton

Also, make sure your fresh downloaded copy of crouton is in ~/Downloads and not another folder for those instructions to work.
Hope this helps,
-DennisLfromGA


Feature: Provide a way to specify condition names

Discussed in https://github.com/alexfertel/bulloak/discussions/77

Originally posted by clauBv23 July 10, 2024
When testing complex code a common scenario scenario involves verifying specific behaviors under different setups. For example in Sablier V2 Core, the test tree looks like this:
             ...
            └── given all streams are warm
            ├── when the caller is unauthorized for all streams
            │  ├── when the caller is a malicious third party
            │  │  └── it should revert
            │  └── when the caller is the recipient
            │     └── it should revert
            ├── when the caller is unauthorized for some streams
            │  ├── when the caller is a malicious third party
            │  │  └── it should revert
            │  └── when the caller is the recipient
            │     └── it should revert
            ...

This tree structure checks that when the caller is a malicious third party and when the caller is the recipient should revert in both cases: when the caller is unauthorized for all streams and when the caller is unauthorized for some streams.
Using bulloak, this specification fails because in Solidity two functions or modifiers cannot have the same signature.
However, in the Sablier V2 Core repo this issue is managed by also appending the scenario description to the function name instead of just creating a modifier, as shown below:
function test_RevertWhen_CallerUnauthorizedAllStreams_MaliciousThirdParty()
        external
        whenNotDelegateCalled
        whenArrayCountNotZero
        givenNoNull
        givenAllStreamsWarm
        whenCallerUnauthorized

Is there a way to handle this in bulloak? or any workaround for this issue?
Perhaps a special word, character, or ASCII sequence in the tree, could be used to append the description to the function name?

Adding a comment to receive notifications on updates :eyes: 🔥


linter failing for "github.com/Optum/dce/pkg/awsiface/mocks" types

Version information

Describe the bug
Linter is complaining about several types tied to "github.com/Optum/dce/pkg/awsiface/mocks". Here is a sample error:
var mockIAM *mocks.IAM
cannot use mockIAM (variable of type *mocks.IAM) as awsiface.IAM value in struct literal: missing method ListInstanceProfileTags

Here is another one:
var mockCwe *awsMocks.CloudWatchEventsAPI
cannot use mockCwe (variable of type *"github.com/Optum/dce/pkg/awsiface/mocks".CloudWatchEventsAPI) as cloudwatcheventsiface.CloudWatchEventsAPI value in struct literal: missing method CreateApiDestination

The same error pops up
To Reproduce

Expected behavior
No linter errors
Additional context

I could be wrong but it seems that this requires that the latest version of mockery be re-run with the latest version against some interface types that AWS has updated in their SDK


Upper right dropdown is not working

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
The upper right navigation bar is meant to show a dropdown list for versions supported.
However it does not work as expected.
Proposed Solution:
fix it.
Page to Update:
https://kubernetes.io/docs/

@tengqm Are you still seeing this? I'm able to select versions without difficulty.

@zacharysarah yes, it is still there. I'm using Safari, btw.

I see the same thing with Safari = the page renders/works differently in Chrome, but utterly fails with Safari. It also works with Firefox (just tested it)

I took a look and you can fix it by adding overflow: visible to the header element, but if you do that there's a bunch of stuff that will suddenly appear that probably doesn't need to, so you'll need to take a look at it.


Fixing Broken Link Because RNTester Changed Path

This PR fix broken link on react-native-website because recently RNTester directory have been moved.

@Simek should we fix the broken link on versioned docs too?

@Simek should we fix the broken link on versioned docs too?

Thank you for working on those updates! It would be nice if you can edit last versioned docs too (0.63). 🙂

@Simek updated.


Create bone-luck

This plugin will detect if you are offering bones at the Chaos Altar (wilderness) and offer some helpful information such as:

bones used
bones saved
saved percentage
(optional configs)
total XP gained in session
expected XP gained (based on average luck)

my bad. Will try again

Don't open a new PR; you can reopen this one and push new commits to make CI run again


[AMHACK] Test operation related to production endpoint url in creating Web Socket API prompts a error message even though the given url is correct

Description:
Test operation related to production endpoint url in creating Web Socket API prompts a error message even though the given url is correct
Suggested Labels:
Bug
Suggested Assignees:
Affected Product Version:
APIM WUM Updated - wso2am-<IP_ADDRESS>0585460470
OS, DB, other environment details and versions:
Standalone
DB - H2
Browser - Chrome Version 61.0.3163.100 (Official Build) (64-bit)
JDK - jdk1.8.0_121
Steps to reproduce:

Sign in to the API Publisher.
https://:9443/publisher (e.g. : https://localhost:9443/publisher). Use admin as username and password.
In the APIS menu, click Add New API.
Select the option to design a new WebSocket API and click Start Creating.
The Design tab of the API opens. Give the information in the table below and click Next: Implement > to proceed to the implementation phase.
Click the Managed API option.
Provide the production endpoint and sandbox endpoint, which is ws://echo.websocket.org:80
Click on the Test button
Will get a error message as Invalid (Even though the given url is correct)

Related Issues:

APIM does a HTTP HEAD method to check whether the backend is valid. Since it is not there for web socket, you would see this error. One option you could do is to use change the protocol to http to check whether the endpoint exists. This would give a warning with 404 not found (we could see whether at least the backend is existing)

Test button is

From 4. x we remove the WebSocket test functionality


Use Object.assign polyfill

IE11 does not support Object.assign

Coverage decreased (-0.1%) to 96.672% when pulling a710d7c0ea146523d4ed6ee2eb50d7d14c667e0e on object-assign-polyfill into 58f5bb599405d89e6765fcde5c75e3c3573207f1 on master.

Coverage decreased (-0.1%) to 96.672% when pulling a710d7c0ea146523d4ed6ee2eb50d7d14c667e0e on object-assign-polyfill into 58f5bb599405d89e6765fcde5c75e3c3573207f1 on master.


Panic Error with Pull Request Submit

Gogs version (or commit ref): <IP_ADDRESS>9
Git version: 2.7.4
Operating system: Ubuntu
Database (use [x]):

[ ] PostgreSQL
[X ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[ X] Not relevant

Log gist (usually found in log/gogs.log):

Hi,
I am getting the following errors when submitting a pull request. The request went through but
I am getting an empty page on submit. Please let me know if there is a configuration I am missing.
Thanks.
Macaron] 2017-06-20 04:34:59: Started POST /vistara/itom2/compare/master...mangkang:master for <IP_ADDRESS>
[Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:489 (0x4340bf)
/usr/local/go/src/runtime/panic.go:63 (0x432f6e)
/usr/local/go/src/runtime/signal_unix.go:290 (0x44930f)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/repo.go:612 (0xb7d70a)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/repo.go:630 (0xb7dbe0)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/repo.go:287 (0xb7a5df)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/repo.go:314 (0xb7a8ea)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/pull.go:140 (0xb6b775)
/home/vagrant/gopath/src/github.com/gogits/gogs/models/pull.go:444 (0xb6fd6d)
/home/vagrant/gopath/src/github.com/gogits/gogs/routers/repo/pull.go:705 (0xc2f699)
/usr/local/go/src/runtime/asm_amd64.s:516 (0x460726)
/usr/local/go/src/reflect/value.go:434 (0x4b279f)
/usr/local/go/src/reflect/value.go:302 (0x4b1d64)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:177 (0x88bd3f)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:137 (0x88b70a)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:121 (0x8a99e2)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:112 (0x8a9906)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/session/session.go:186 (0x901dc0)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:79 (0x8a9781)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:157 (0x88ba12)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:135 (0x88b80b)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:121 (0x8a99e2)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:112 (0x8a9906)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/recovery.go:161 (0x8bd26b)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/logger.go:40 (0x8ace98)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:157 (0x88ba12)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:135 (0x88b80b)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:121 (0x8a99e2)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:112 (0x8a9906)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/logger.go:52 (0x8bc4e4)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/logger.go:40 (0x8ace98)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:157 (0x88ba12)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/github.com/go-macaron/inject/inject.go:135 (0x88b80b)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/context.go:121 (0x8a99e2)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/router.go:187 (0x8be539)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/router.go:296 (0x8b65dd)
/home/vagrant/gopath/src/github.com/gogits/gogs/vendor/gopkg.in/macaron.v1/macaron.go:220 (0x8ae4dc)
/usr/local/go/src/net/http/server.go:2568 (0x6dc702)
/usr/local/go/src/net/http/server.go:3088 (0x6de103)
:312 (0x703024)
/usr/local/go/src/net/http/h2_bundle.go:4319 (0x6fa5ad)
/usr/local/go/src/net/http/h2_bundle.go:4599 (0x6b30f9)
/usr/local/go/src/runtime/asm_amd64.s:2197 (0x462dc1)
[Macaron] 2017-06-20 04:34:59: Completed POST /vistara/itom2/compare/master...mangkang:master 500 Internal Server Error in 103.436195ms
...

#4565 Probably related

Still getting panic error after building latest from master.

Hi, why can't you reproduce on demo site?

Ok i did try on demo site:
I forked https://try.gogs.io/kolgotcko/test, my repo is https://try.gogs.io/dracic/test. I have made one commit and then submitted a pull request.
https://try.gogs.io/kolgotcko/test/compare/master...dracic:master gives error 500, but at the end the pull request is saved...
Best regards

Can confirm, we are experiencing this issue. Error 500, then pull request saved.

Can confirm too. Here is the backtrace :
[Macaron] 2017-07-04 14:10:36: Started GET /xxxxxxxxxx/xxxx/pulls/162 for <IP_ADDRESS>
2017/07/04 14:10:36 [TRACE] Session ID: 70835c38eb2c3d61
2017/07/04 14:10:36 [TRACE] CSRF Token: 2jegA7TMey35nGQz0orGtL_zQwM6MTQ5OTE1NzkzMjQ5MzI3NzYyMw==
2017/07/04 14:10:36 [TRACE] Template: repo/issue/view
[Macaron] 2017-07-04 14:10:36: Completed GET /xxxxxxxxxx/xxxx/pulls/162 200 OK in 122.826586ms
[Macaron] 2017-07-04 14:10:37: Started POST /xxxxxxxxxx/xxxx/pulls/162/merge for <IP_ADDRESS>
2017/07/04 14:10:37 [TRACE] Session ID: 70835c38eb2c3d61
2017/07/04 14:10:37 [TRACE] CSRF Token: 2jegA7TMey35nGQz0orGtL_zQwM6MTQ5OTE1NzkzMjQ5MzI3NzYyMw==
[Macaron] 2017-07-04 14:10:40: Completed POST /xxxxxxxxxx/xxxx/pulls/162/merge 302 Found in 3.150374256s
2017/07/04 14:10:40 [TRACE] Pull request merged: 503
2017/07/04 14:10:40 [TRACE] DeliverHooks [repo_id: 126]
2017/07/04 14:10:40 [TRACE] AddTestPullRequestTask [head_repo_id: 126, head_branch: develop]: finding pull requests
2017/07/04 14:10:40 [TRACE] addHeadRepoTasks[300]: composing new test task
2017/07/04 14:10:40 [TRACE] PullRequest[300].UpdatePatch: ignored cruppted data
2017/07/04 14:10:40 [TRACE] PushToBaseRepo[126]: pushing commits to base repo 'refs/pull/106/head'
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x10 pc=0x5c9b5a]

goroutine 15776 [running]:
panic(0x10777c0, 0xc82000e0d0)
        /usr/local/go/1.6.2/src/runtime/panic.go:481 +0x3e6
github.com/gogits/gogs/models.(*Repository).getOwner(0x0, 0x7f7f8b9ae270, 0xc820123c20, 0x0, 0x0)
        /usr/src/gogs/src/github.com/gogits/gogs/models/repo.go:273 +0x2a
github.com/gogits/gogs/models.(*Repository).mustOwner(0x0, 0x7f7f8b9ae270, 0xc820123c20, 0x0)
        /usr/src/gogs/src/github.com/gogits/gogs/models/repo.go:286 +0x39
github.com/gogits/gogs/models.(*Repository).repoPath(0x0, 0x7f7f8b9ae270, 0xc820123c20, 0x0, 0x0)
        /usr/src/gogs/src/github.com/gogits/gogs/models/repo.go:415 +0x45
github.com/gogits/gogs/models.(*Repository).RepoPath(0x0, 0x0, 0x0)
        /usr/src/gogs/src/github.com/gogits/gogs/models/repo.go:419 +0x5a
github.com/gogits/gogs/models.(*PullRequest).PushToBaseRepo(0xc82163e1c0, 0x0, 0x0)
        /usr/src/gogs/src/github.com/gogits/gogs/models/pull.go:572 +0x1cf
github.com/gogits/gogs/models.addHeadRepoTasks(0xc82180e0f0, 0x1, 0x2)
        /usr/src/gogs/src/github.com/gogits/gogs/models/pull.go:652 +0x2b9
github.com/gogits/gogs/models.AddTestPullRequestTask(0xc82248c000, 0x7e, 0xc8219f7ff0, 0xc, 0xc8217e8d00)
        /usr/src/gogs/src/github.com/gogits/gogs/models/pull.go:698 +0x77d
created by github.com/gogits/gogs/models.(*PullRequest).Merge.func1
        /usr/src/gogs/src/github.com/gogits/gogs/models/pull.go:190 +0xd5

@unknown i had the same issue with latest release

Gogs version <IP_ADDRESS>9
git version 2.7.4
Operating system: Ubuntu 16.04.2 LTS
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist (usually found in log/gogs.log):
same as other users above

Patch has pushed to fix this issue, please test on master branch or https://try.gogs.io.

unable to test fix ... creating a fork causes an error 500

@caffeineaddiction should be good now! Please help test again.

@Unknwon confirmed working on https://try.gogs.io
when can we expect a new docker release of this fix?

@caffeineaddiction I think it is already available: https://hub.docker.com/r/gogs/gogs/builds/

@Unknwon epic win, tyvm for the fix

Tested pull request on master branch. Works fine now. Thanks!

Hi,
I have just updated gogs to 0.11.29 @ 2017-08-15 (Windows 386) following the steps enumerated in this link https://gogs.io/docs/upgrade/upgrade_from_binary. My git version is 2.12.0.windows.1 and I am using sql database.
However I still find problems trying to submit a pull request. I cannot see any error, but the page stays waiting forever. Then anyone else navigating in gogs cannot list any repositories in any organization.


net/http: add knobs for which headers Client forwards on redirect?

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.8.1
What operating system and processor architecture are you using (go env)?
amd64/darwin
What did you do?
Making a request to upload a file that is setting the content-type of application/x-compressed which results in a successful 302 redirect to a task monitoring endpoint.
What did you expect to see?
The request succeeds and the task monitoring endpoint returns a 200.
What did you see instead?
The endpoint fails due to the fact that it has received the additional header.
I know I can implement a CheckRedirect function that would allow me to strip out the headers but it seems like the go 1.7.X behavior was more desirable (providing the function to forward the headers).
It actually might be nice to make this a flag on the client (so headers can be optionally be forwarded or not). Having to implement CheckRedirect just to not send along headers feels a tad bit heavy handed but I am open to it.
I also know that the API server, which I have no control over, could be modified to ignore additional headers but the code I have talking to this server worked in 1.7.X and now doesn't work in 1.8.1 (slightly surprising).

For 8 releases people complained about the lack of header forwarding and we kept putting it off and thinking about it. And then we did it, and... this. :)
I'll entertain proposals but I don't have the resources to think about this more and design the API myself.

@bradfitz I almost dreaded putting this in because it felt like a "damned if you do, damned if you don't" sort of behavior. I'd be glad to take this on and rough it out, of course as long as you are willing to provide feedback 😄
Easiest solution:
Client now takes a bool for RedirectHeaders.
I'd love to see if anyone else has run into this and/or cares. Also, thanks for all you do and even being open to the idea.

We're not going to make the behavior off in 1.0-1.7, on in 1.8, and off again in 1.9. It's going to be on by default now. So any bool would need to turn it off, so would need a different name.
But a bool might not be flexible enough. A func(string) bool might be better. A per-key policy func or something. And then there could be predefined funcs/vars for AllowAll or AllNone. And a nil func (the default) would be a Go-defined policy, like we have in 1.8.

I am also closing this issue. Seems like the default behavior is fine as @bradfitz originally stated.


DateTimeOffset in endpoint return type is generated as DateTime

I have an endpoint which returns a class:
class StatusHistory { public IEnumerable<StatusItem> Items { get; set; } }
class StatusItem { public DateTimeOffset Date { get; set; } }
When using NSwag to generate a client, the Date property of StatusItem is generated as DateTime, rather than DateTimeOffset.  I do not want to lose the precision provided by DateTimeOffset.
Is there any way I can get this property to be generated as DateTimeOffset?

Is this "the same" as a TimeSpan?

I'm not sure I follow your question.  If you're asking if DateTimeOffset is the same as TimeSpan then it is not.  DateTimeOffset is basically a DateTime that also includes time zone information.  It reduces the ambiguity normally associated with working with DateTimes across time zones.

Ok, then we should treat DateTimeOffset like a DateTime in JSON Schema and you can set the DateTimeType to "DateTimeOffset" to generate the client code... JSON Schema cannot differentiate between datetime and datetimeoffset. Would this be ok?

Yes that sounds good to me.

Ok, no changes needed. Just set the DateTimeType setting of the C# generator to "System.DateTimeOffset"


fatal error: core.h: No such file or directory breaks build against node 10.2.0

node 10.1.0 was fine, but 10.2.0 introduced this new fatal error:
mk@vujade:~/git/nan$ npm run rebuild-tests

><EMAIL_ADDRESS>rebuild-tests /home/mk/git/nan
> node-gyp rebuild --msvs_version=2015 --directory test

make: Entering directory '/home/mk/git/nan/test/build'
  CXX(target) Release/obj.target/accessors/cpp/accessors.o
In file included from ../../nan.h:51:0,
                 from ../cpp/accessors.cpp:9:
/home/mk/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: core.h: No such file or directory
 #include "core.h"  // NOLINT(build/include_order)
          ^~~~~~~~
compilation terminated.

I first noticed this in CI:
https://travis-ci.org/mkrufky/node-dvbtee/jobs/382993499
...and then I was able to easily reproduce it locally after upgrading node from v10.1.0 to v10.2.0
Oops, this is a node bug, and not NAN's issue:  https://github.com/nodejs/node/issues/20921
Will likely end up closing this soon.

Closing this now -- a fix for it landed upstream in nodejs/node@3f4caec. A 10.2.1 release with that fix should follow shortly.  No changes to NAN or any native modules are necessary.


Sprite editor not opening

Describe the bug
Internal crash when trying to open an image from monaco.
To Reproduce
Open microsoft/pxt-arcade-cabinet/menu
click on paint tool

palette is undefined

fixed with https://github.com/microsoft/pxt/pull/7747 (removed the Tile Gallery tab)

fixed with https://github.com/microsoft/pxt/pull/7747 (removed the Tile Gallery tab)


Outline mode: Folded bullets/tasks get unfolded when moved up/down

Hey, I'm coming from an outliner (logseq) background so I'm still relying on task/bullet folding heavily. Currently, whenever a folded bullet is moved up/down it gets unfolded automatically. Similarly, whenever another, non-folded, bullet/task is moved over a folded one then the latter gets unfolded too. I'm not sure if this is by design but it can become annoying esp. for bullets with a large number of children. I'd expect any folded element remains folded until it gets unfolded explicitly.
Thank you (& I agree SB looks like the one ;)).

This is not by design. It's a bug.


Clicking the Expand button does nothing.

Hello, I have been playing with this neat package and have noticed that when there are breaks in the compare due to large enough areas that don't have any changes, it will collapse the lines and instead show a summary line. This is nice, however when I go to click the summary line to expand the unchanged code, nothing happens.
This can be recreated by going to the demo site and setting the 'context' to 1:

You will see the code collapses down as expected. However, when trying to reveal the collapsed code, nothing happens.
Specifically, I would expect clicking the blue areas pictured below would expand the hidden lines.

Yes, the expected behavior here is to expand the code upon clicking, but this functionality has not been implemented yet. I have been quite busy recently, but I will work on implementing it in the future. However, it may take some time, so I apologize for any inconvenience this may cause. I will do my best to find the time to improve it.

@Shimada666 Hello, I think I can help with this feature.

@Shimada666 Hello, I think I can help with this feature.

Sounds good! Could you please create a PR? To be honest, I'm a little busy recently..

@JoelYoung01
This feature has been developed by @cjboy76 and can be tried by installing version 1.5.0. Thanks for cjboy76's contributon!


No throwing exceptions in header files

Google internally forbids the use of exception and having exceptions thrown in envoy header files can cause trouble when google code tries to include envoy library.
This is to raise this issue of possibly rewriting all the instances where exceptions are thrown in header files. It primarily involves getting rid of template functions that are throwing exceptions, which may or may not be a significant change to envoy downstream.

@ahedberg is more knowledgeable on this issue.

As I mentioned this is fine with me as long as all the fixes are simple which it sounds like they should be. If they aren't simple let's circle back and discuss.

I just added an exception linter in this PR https://github.com/envoyproxy/envoy/pull/12471
Maybe the lint portion of this could just extend the deny list.

Yes. But I probably want to do the linting part last after all corresponding changes have been made.

This issue is now closed. @ahedberg


Update UintUtils

Several API changes and optimizations.
Further changes needed:

[x] toString tests
[x] toBinString implementation
[ ] toBase64String implementation (see here)
[x] reconcile padding input values - toDecString(uint256,uint256) accepts a string length, while toHexString(uint256,uint256) accepts a bytes length
[ ] prefixes (0x) and possibly hex length enforcement (0x1 => 0x01) should be optional, and other prefixes should be available (see 0b and 0o here)

@NouDaimon Okay to review now.  Opinions about the missing features?

I think the best way to deal with the prefixes is to add custom functions for conversion to each prefixed base: toHexString, toBinString, etc.  This could also preserve the behavior of Address#toString found in other libraries, where a bytes length is provided rather than a string length - this PR currently standardizes all toString functions to use the latter.

Above comment is implemented except for reverting the behavior of the length parameter of toHexString.

Two questions remain:
Should toHexString(uint256) zero-pad the output so that character length is always even and bytes are not split?
toHexString(1) => 0x01
// or
toHexString(1) => 0x1

Should toHexString(uint256,uint256) treat the length parameter as a bytes length or a character length?
toHexString(1, 1) => 0x01
toHexString(1, 2) => 0x0001
// or
toHexString(1, 1) => 0x1
toHexString(1, 2) => 0x01

For both questions mentioned above, length shall refer to bytes length rather than character length.  Hex nibbles shall not be split, except when using the lower level toString function.


Ventura dylib issue

Bug Description
After installing ventura on my M1 macbook, I started seeing this error:
dyld[28029]: terminating because inserted dylib '/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' could not be loaded: tried: '/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (fat file, but missing compatible architecture (have 'x86_64,arm64,arm64e', need '')), '/System/Volumes/Preboot/Cryptexes/OS/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (no such file), '/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (fat file, but missing compatible architecture (have 'x86_64,arm64,arm64e', need ''))
dyld[28029]: tried: '/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (fat file, but missing compatible architecture (have 'x86_64,arm64,arm64e', need '')), '/System/Volumes/Preboot/Cryptexes/OS/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (no such file), '/Users/{user}/.vscode/extensions/metalbear.mirrord-3.5.3-darwin-arm64/libmirrord_layer.dylib' (fat file, but missing compatible architecture (have 'x86_64,arm64,arm64e', need ''))

The path /System/Volumes/Preboot/Cryptexes/OS/User/* does not exist.
I am unable to start mirrord from inside vscode as a result of this error.
Steps to Reproduce

Installed mirrord (v3.4, in my case)
Upgrade macos to Ventura on my M1
Got error as shown above
Updated mirrord to latest (3.5.2 at the time of this report)
Continued to get error as shown above

Backtrace
No response
Relevant Logs
No response
Your operating system and version
macos Ventura
Local process
/opt/homebrew/bin/go: Mach-O 64-bit executable arm64
Local process version
No response
Additional Info
Let me know if I need to provide supplemental information. Thanks!

Thanks for reporting this @alairock ! I'm sorry for the inconvenience.
I'm actually on Ventura and it works for me so it's a bit of a puzzle.
Can you please specify what go version you're running go version?
Also, can you run file BINARY on the built binary from go?
The problem seems to be that the binary is ran doesn't have an architecture.. which is, weird. the file command might shed some light on it.

go version
go version go1.19.2 darwin/arm64

file BINARY
{filename}: Mach-O 64-bit executable arm64

Thanks for the report.
It's a confirmed issue with macOS new version, we're still investigating what's changed from macOS side. I'll keep this issue updated.

Hey,
We shipped a patch. I tested it and appears to work on my setup. Please let us know if it's okay now.

Perfectly! Thank you so much for tackling that! How do I buy you a coffee???

You're welcome. Thanks for reporting it :)
We'd actually love to hear some feedback over video if you're up - we want to understand better our user base and make the product even better.
If you're up for it, you can pick a time slot here.


Add toString to samplers

Coverage decreased (-0.1%) to 97.744% when pulling 6eabc9d74b5af1f2e618de1f9466fec483e22749 on sampler-tostring into d376cec01bc4079be49937022551b25da3c93054 on master.

LGTM


Moving LokiJS To TypeScript?

Title makes this sound extreme, but there are some solid reasons to switch.
My viewpoint after writing the definition file for LokiJS (see https://github.com/techfort/LokiJS/issues/167) is that there's no obvious downsides to TypeScript for an OOP JS library like LokiJS, the code doesn't doing anything crazy with prototypes or function argument and makes an excellent target for TypeScript.
Since all javascript code is valid typescript, file extensions can be changed to .ts to move a project to TypeScript.  Types can be added when contributer's have the time/desire.  There's a dozen tools and IDEs to compile .ts to .js when you save a file or as part of a build process, keeping side-by-side .ts and .js files in the LokiJS /src directory wouldn't take much effort.
TypeScript has the obvious advantage of providing compile time error checking, it has great refactoring support (VS2015's TS tooling is pretty awesome! Check it out if you haven't) and the TS module syntax, shorthand lambdas, classes, etc. (which can all be compiled away into standard JS) merges very cleanly with ES6 making the upgrade easy in future.
What are your, the major contributors to LokiJS, thoughts on upgrading Loki to typescript and pros/cons from your viewpoint?
(based on my experience over the last 6 months working on a large business web app using VS2015 + TypeScript + LokiJS + lokijs.d.ts file linked in https://github.com/techfort/LokiJS/issues/167)

Typescript does look interesting... I expect I will be looking into it more over the next few months or so.
I am not sure yet of the major benefits inside the lokijs project itself.  Without the benefit of much research into typescript, I would expect that higer level abstractions of lokijs like resultset and dynamic view would be easier to port, while the low level core methods and plumbing are more functional style and may be less able to concretely express?   Externally and across api surfaces, the value is obvious and your definitions probably already help for that.
We have been very careful to keep loki as pure native javascript solution not only for deployment purposes, but for development purposes as well.  Having said that, this 'common feature set' will likely be fine tuned and tested enough soon that domain specific solutions / forks can pivot that source base into more specific environments like a full typescript rewrite.
I would offer to include your definitions in this project but I assume DefinitelyTyped is the preferred central location for these?

Thanks for your input obeliskos, TypeScript isn't pure javascript, that's true, but it is a superset of javascript, which means LokiJS core level methods could remain unchanged and higher level methods like resultset and dynamic view could have types added to their function parameters and return types.
Yes, the central repository for definitions is DefinitelyTyped.  I was thinking I might not always be available or remember to keep the definition over there updated as LokiJS continues to evolve, which was one of the reasons I asked this question.

Yes i'm looking over it a bit and looks pretty impressive.  Once I learn more I would be willing to help maintain the typescript definitions.  Maybe once i get comfortable enough to work with the definitions you created (thanks :) we can coordinate via messaging here or elsewhere.

DefinitelyTyped is open to any contributors, the LokiJS definition hasn't been updated in 5 months, so it could use an update.
My blocker to easily updating the definition is that I don't keep up with LokiJS API changes and minor releases, so I either have to manually go through every commit for the last 5 months to find API changes, or take the current loki.js file and re-convert it function by function to a definition file.
If you keep up with LokiJS releases and API changes, you could help maintain the definition file.

Since ES6 (and in a few more months ES7) is already available in all major browsers, there isn't any benefit at all (except type checking) at using TypeScript over plain JS (ES6).
Furthermore, you'll notice that the entire community is :-1: TypeScript as it just makes things harder to debug without any reason. Also, developers just don't seem to want to learn/deal with TypeScript syntax. Just look at the biggest JS project (that I'm aware of): Atom. They started doing it in CoffeeScript and now they are moving to plain ES6.
Just my 2 cents

maybe talk to the Angular 2 team about Typescript (oh and Ionic as well) and Aurelia and .........

I'm not saying to not support TS. Supporting TS would be totally fine, if it were possible with some minor effort. My point is that right now, being ES6 already available in all browsers, there are no reasons to switch over to TS (except type checking, which imho is a solution to a non-existing problem). Type checking is a good thing, but be honest with yourself, how many times you actually screwed something because of bad variable assignment? Just a simple example, Python doesn't have type checking, and Python apps are cool, they work fine.
About Angular 2, Ionic, Aurelia, etc... They all chose what they chose based on what was available at the time they started those projects.
On the other hand, TS adds yet another point of failure, as browsers don't run TS, but JS. So you're forced to transpile the code to JS, meaning you're actually tied to yet another component. Let a single bug in the transpiler happen, and you'll be debugging something for hours before realizing you're hunting ghosts.
There is also the fact that just a small subset of the developers that code in JS understand/code TS too. Such a change will scare the vast majority of possible contributors.
Last, but not least important. Your issue is the opposite of the very first rule of coding: Don't touch it if it works. This is not some 300 lines Angular directive. We're talking about 7k lines of code. Odds are rewriting such a big code base will (listen my words, this is not the first time I see such a thing) cause bugs, failures and other odd situations.
But even in the best case scenario, after rewriting the entire code base to TS without introducing a single bug, you'll have wasted precious time which could have been employed in implementing new features in rewriting something that wasn't bad and didn't actually need a rewrite.
My final point, and with that I'll probably stop replying to this issue as I don't want a flame war, TS doesn't offer that much pros compared to all the cons it has, after analyzing the amount of work required to do what you're requesting.

My very first statement was: “I’m not saying to not support TS”. From there on everything is just my POV. I’m sure the dev team will be more than happy to review your patch and merge it. 👍

I see @techfort mixed things up by adding stale bot ;)
Guys we have already embraced Typescript within the (next gen loki) LokiDB.  @Viatorus put in a lot of work to make that happen.
As it stands now we are refactoring critical code paths and adding new ones.  Hopefully that should be in a supported upgrade path from lokijs soon.  Packages are currently being emitted to es6, so if you prefer javascript you should be able to utilize that along with full type definitions for your editor.


Can't run a cell with python interpreters on the Jupyter Datascience Notebooks container

Testing #174728
I can't figure out how to run a notebook on a container that is specifically meant for running notebooks.

Go to the remote explorer, select containers
create a new container with the "Jupyter Datascience Notebooks" configuration
Wait for the creation to complete

creating a Conda environment fails with
CondaError: Unable to create prefix directory '/workspaces/jupyter-datascience-notebooks/.conda'. Check that you have sufficient permissions.
creating a venv fails with
Error: [Errno 13] Permission denied: '/workspaces/jupyter-datascience-notebooks/.venv'
trying to use the global environments leads to the There is no Pip installer available in the selected environment. error when trying to install IPykernel.

@amunger looks like you have a two issues here

Cannot create conda or venv
Cannot use global python env as pip is not available (in the Jupyter Datascience Notebook container, you should not have to use the global one, just use the exiting conda, that is what is recommended)
I tried that and here is the screenshot

The issue with other global python envs is known, i think we have a seprate issue for that.
If that does not work, please could you file a separate issue
Assigning this to Brett as Python extension owns creation of conda and venvs.

I wonder if we can leverage kernel filter in dev containers to ensure that the global python is never picked https://github.com/microsoft/vscode-jupyter/pull/12861 but if Python knows to filter them out, it would be even better.

Related to https://github.com/microsoft/vscode-python/issues/15937
Probably needs a discussion on what we need to do with such ptyohhn envs, i think we should display them with warnings, like we do with Conda without python envs.

Sorry, I'm still recovering from COVID, but what's the specific ask here? Aaron didn't have write permissions, so the creation failed, so that's not unexpected in that scenario. And not having pip installed is a known issue on all Debian-based OSs and Don linked to the open issue about that, so I'm not quite sure what I'm supposed to do with this issue?

I think we might want a better error message to notify the user that they cann't create virtual envs due to permission issues or the like.
@amunger not sure what else you want done here/

I think the error message was fine, I understood why I couldn't create an environment.
I was just surprised that I struggled so much to run a notebook cell in a container that sounds like it is specifically designed to do so.
The biggest blocker for me was that I was apparently supposed to use the 'base' environment when I had previously heard that using that environment was bad practice. I think understand why it would be different in containers and fine to use base (the entire thing is a temporary environment, so it doesn't matter if I clutter up base), but at the time of testing this out, I couldn't figure out which kernel I was supposed to use.

I was just surprised that I struggled so much to run a notebook cell in a container that sounds like it is specifically designed to do so.

If the default container is at all Debian-based and not set up for Python explicitly, you're just in for a bad time. 😅

The biggest blocker for me was that I was apparently supposed to use the 'base' environment when I had previously heard that using that environment was bad practice.

Correct. This is actually considered a big win for micromamba and its lack of a base environment (and there being talk of blocking installing into the base environment from the conda side for pip).

OK, based on what's been said it sounds like the key things worked out or already have an issue for the Python extension. I'm going to unassign myself, but if this stems from some container that needs more Python configuration then I would reach out to whomever is in charge of that container to set more of Python up in it.


Bug fix/rlp 991/fixing transaction poll bug

This PR fixes the bug reported on this ticket https://jirainfuy.atlassian.net/browse/RLP-991

1. the sleep is OK.

2. i understand that `transaction is None and last_result is not None` does not _necessarily_ mean we should raise an exception, and that is also OK.

3. with this change applied, how will we deal with the cases in which the previous condition means something _has_ indeed gone wrong?

if the last point is not tackled anywhere, please create a follow-up issue for this.
thanks

Created an issue for 3 https://jirainfuy.atlassian.net/browse/RLP-993

1. the sleep is OK.

2. i understand that `transaction is None and last_result is not None` does not _necessarily_ mean we should raise an exception, and that is also OK.

3. with this change applied, how will we deal with the cases in which the previous condition means something _has_ indeed gone wrong?

if the last point is not tackled anywhere, please create a follow-up issue for this.
thanks

Created an issue for 3 https://jirainfuy.atlassian.net/browse/RLP-993


Add tutorial to demonstrate how to train a generative model that can generate large image volumes

Fixes #1744.
Description
Add tutorial to demonstrate how to train a generative model that can generate large image volumes.
Checks

[ ] Avoid including large-size files in the PR.
[ ] Clean up long text outputs from code cells in the notebook.
[ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key.
[ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
[ ] Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Hi @dongyang0122 , some signature is missing:
https://github.com/Project-MONAI/tutorials/pull/1745/checks?check_run_id=27169416504
Summary
Commit sha: [f159834](https://github.com/Project-MONAI/tutorials/pull/1745/commits/f1598348036b7d64267f1c7a8f1fa76d4a5d37aa), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [50d0382](https://github.com/Project-MONAI/tutorials/pull/1745/commits/50d0382c5194f2eb185d0a7dceea148eaec406da), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e818c46](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e818c46d56d40cca03fdaca1d7db82577fccf172), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e033503](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e03350303104d65254f84ca482b752ac83f1de48), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [e41d619](https://github.com/Project-MONAI/tutorials/pull/1745/commits/e41d6197c989de35751f53b0a662d9f0a7ef344c), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [d78b35a](https://github.com/Project-MONAI/tutorials/pull/1745/commits/d78b35a1f230319fb898b68c41ccabe29b1d9c27), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [a5de734](https://github.com/Project-MONAI/tutorials/pull/1745/commits/a5de734e08ffc74e5bada4b4cef5e2f62c2d02cf), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [79d620f](https://github.com/Project-MONAI/tutorials/pull/1745/commits/79d620f0210281b7d09a1827cfe88b9606f9ad4d), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [74f69a4](https://github.com/Project-MONAI/tutorials/pull/1745/commits/74f69a4d34ff116c498913c98c9af135f62bc47b), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [3268421](https://github.com/Project-MONAI/tutorials/pull/1745/commits/32684213f89da42fdef71b3709948693a693bc59), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.
Commit sha: [5847ed8](https://github.com/Project-MONAI/tutorials/pull/1745/commits/5847ed823621d4a3f970058ae7b1c611a9f4c5d6), Author: Dong Yang, Committer: Dong Yang; The sign-off is missing.

Hi @dongyang0122, could you please take a look at the ci issue? You can see the error using details. Thanks!

Shall we add some doc to explain how/where to run the diff-model_{infer/train}.py later (since the markdown is removed from the PR)

Shall we add some doc to explain how/where to run the diff-model_{infer/train}.py later (since the markdown is removed from the PR)

There will be a README PR later. We will add this information in the unified README file.

The model architecture is also defined in 'config_maisi.json'. Do you think we can reuse it and avoid duplicate network definition?

The model architecture is also defined in 'config_maisi.json'. Do you think we can reuse it and avoid duplicate network definition?

Hi @Can-Zhao, I have updated the scripts to reuse model definition from config_maisi.json. Thanks for suggestion.

Hi @KumoLiu , is it necessary to push another commit by @dongyang0122 ?

No, should be fine for now.


Customize the NFS -mapall param in /etc/exports

Currently the /etc/exports file gets configured with:
-mapall=$(id -u):$(id -g)

However it seems for some (#14) this causes permissions issues and needs to be replace with some other values or be substituted with -maproot=0
The idea would be to allow to send the /etc/exports params through the docker-machine-nfs command:
E.g.
./docker-machine-nfs [machine] --nfs-exports="-maproot=0"

:+1:

+1


Feature to include Comments

Main Changes

Add feature to allow users to enter an optional comment field in the add command, using c/Comment. Note that there is no restrictions for comments.
Able to edit comment via edit command
Able to view comment of an internship entry in the right panel when using the view command
Include relevant tests
Made right panel responsive to add, edit and delete commands. This means when user adds/edit/deletes a particular internship, the right panel's information will be updated accordingly.

Issues
This PR fixes #66.

Just a question, I noticed that when the c/COMMENT field in the add command is not added, the comment will be NA by default, so say I already have a comment and I want to delete it, to do so would just be using the edit command to set the comment to NA?
The rest LGTM!

Hi @kohkaixun, great catch! It was my mistake, I did not think of that situation. I have edited the edit command accordingly where if the user wants to delete a comment, he can just write edit INDEX c/ and the comment will revert to NA. This is consistent with how tags work for the edit command:

Do try it out and let me know if it works! If it works and everything is okay, you go ahead to merge. 😄


Added WS 2016 and later as PRT doc

Added 'Windows Server 2016 and later' as the following PRT doc to make it more clearer to customer:
https://docs.microsoft.com/en-us/azure/active-directory/devices/concept-primary-refresh-token

@mzmaili : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mzmaili : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Replace ci-release with dynver

Replaces ci-release with dynver, see https://lists.apache.org/thread/l7yp8yb2ooy7opwmzpw7hkmz9gm0qr2r

So I am going to go ahead and merge this even though the link validator is failing. I am not sure whats causing it to fail but it should be completely unrelated.


Installation on HA core-2021.11.3 fails

Installed via HACS
Restarted HA
Added integration,  showing "Please wait while Deutscher Wetterdienst (DWD) is being setup".
Waiting ... waiting ... more waiting ...
Nothing happens.
Alternatively, an error message "Config flow doesn't work" or somesuch pops up.
Anyone any idea?

Hi @swa72, I'm currently not actively distributing my extension via HACS. I guess you are probably using https://github.com/FL550/dwd_weather?

Bummer, you're right. I posted an issue in the wrong repo. Sorry dafür :-)


Minor edits: Contribute to CockroachDB

If you are contributing to the Cockroach Labs docs for the first time, thank you! To get started, check out our Contributing guide.
Edits:
On the v2.1/contribute-to-cockroachdb.md and v19.1/contribute-to-cockroachdb.md pages, make the following edits:

(line 26) Change don't to do not
(line 27) Change don't to do not
(line 30) Change won't to will not
(line 56) Change don't to do not

I'll take this.


Get-DanglingDnsRecords fails with: Attempted to divide by zero

Describe the bug
When running Get-DanglingDnsRecords with the switch '-FetchDnsRecordsFromAzureSubscription' using a service connection through Azure DevOps we see the error: 'Attempted to divide by zero' for multiple customers, but not everyone.
Reproduce
Create a pipeline to run the code from using a Service connection with full read permissions on the intermediate management group in Azure.
It should use the 'FetchDnsRecordsFromAzureSubscription' switch to do so.
Expected behavior
We expect it to output a hash table and CSV-files, as this works as expected when running it locally.
Screenshots

VERBOSE: Exporting function 'New-AzResourceGraphQuery'.
VERBOSE: Exporting function 'Remove-AzResourceGraphQuery'.
VERBOSE: Exporting function 'Update-AzResourceGraphQuery'.
VERBOSE: Exporting function 'Test-DotNet'.
VERBOSE: Exporting function 'Preload-Assembly'.
VERBOSE: Exporting cmdlet 'Search-AzGraph'.
VERBOSE: Importing cmdlet 'Search-AzGraph'.
VERBOSE: Importing function 'Get-AzResourceGraphQuery'.
VERBOSE: Importing function 'New-AzResourceGraphQuery'.
VERBOSE: Importing function 'Remove-AzResourceGraphQuery'.
VERBOSE: Importing function 'Update-AzResourceGraphQuery'.
VERBOSE: Sent top=100 skip=0 skipToken=
VERBOSE: Received results: 1
Get-DanglingDnsRecords: /agent/_work/1/s/management/src/powershell/private/Get-DanglingCNameRecord.ps1:21
Line |
  21 |  … rdsOutput = Get-DanglingDnsRecords -FetchDnsRecordsFromAzureSubscript …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Attempted to divide by zero.

##[error]PowerShell exited with code '1'.
##[error]PowerShell wrote one or more lines to the standard error stream.

Environment- if applicable
Task         : Azure PowerShell
Description  : Run a PowerShell script within an Azure environment
Version      : 5.243.7

Logs- if applicable
Additional context
The weird part it, that we've seen it working, and we've seen it failing (mostly fail). It seems to be some unhandled logic in the code.

@abhijeetgaiha  / @tanviohri  - Hello Team, Please take a look at this issue.


Fails if privileges are limited

In a production environment, users usually have limited privileges. In this case kubectl tree <kind> <name> fails with
Error: error while querying api objects: listing resources failed (<GVK>): <kind> is forbidden

I  would suggest to print a warning for 403s but continue processing otherwise.
EDIT: Just saw there is already https://github.com/ahmetb/kubectl-tree/pull/55 for this. Please merge.

Just pushed some changes to #55. Do you have the means to try that branch out and see if it works as you expected?


Question : Can moment generate timestamp in format 2015-11-20T03:11:55Z ?

Can moment generate timestamp in format 2015-11-20T03:11:55Z ?
Tried below..
console.log(moment.utc().format('YYYY-MM-DDTHH:mm:ss'));
// 2015-11-20T03:11:55

console.log(moment.utc().format('YYYY-MM-DDTHH:mm:ssZ'));
// 2015-11-20T03:11:55+00:00

console.log(moment.utc().format('YYYY-MM-DDTHH:mm:ssz'));
// 2015-11-20T03:11:55UTC

console.log(moment.utc().format('YYYY-MM-DDTHH:mm:sszz'));
// 2015-11-20T03:11:55Coordinated Universal Time

I had to append 'Z' to the string. Is there any cleaner way supported by moment ?
console.log(moment.utc().format('YYYY-MM-DDTHH:mm:ss')+'Z');
// 2015-11-20T03:11:55Z    //need this.

Thanks,
Sasi

With the format method, you would switch to UTC mode and add the Z as an escaped character [Z].  Technically, the [T] should also be like that, but T isn't a format specifier so it carries through unchanged.
However, it's much easier just to call .toISOString(), which already has the desired output.  You don't need to switch to UTC mode when doing that.
console.log(moment().toISOString());  // note that this includes milliseconds
console.log(moment.utc().format('YYYY-MM-DD[T]HH:mm:ss[Z]');

the toISOString() does not help in this case because it has milli seconds.
This formatting helps and makes it clear..
console.log(moment.utc().format('YYYY-MM-DD[T]HH:mm:ss[Z]');

Thanks,
Sasi


[FLINK_22408]Flink Table Parsr Hive Drop Partitions Syntax unparse is…

What is the purpose of the change
Flink Table Enventment Parsr Hive Drop Partitions Syntax unparse is Error
Brief change log

Flink Table Parser is error Synopsis:
SQL：
alter table tbl drop partition (p1='a',p2=1), partition(p1='b',p2=2);
Hive Multiple partitions unparse toSqlString is error,Missing comma in Partition SqlNodeList
In Flink Table Hive Env syntax：
ALTER TABLE tbl     DROP     PARTITION (P1= 'a',P2 = 1)     PARTITION (P1= 'b',P2 = 2)

The right hive syntax ：
ALTER TABLE tbl    DROP    PARTITION (P1= 'a',P2 = 1),    PARTITION (P1= 'b',P2 = 2)

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@lirui-apache need merge


imgur albums are "not supported URL", when the URL contains "/a/"

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.08.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.08.04

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
 ~  youtube-dl --verbose https://imgur.com/a/xKoFIRl
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://imgur.com/a/xKoFIRl']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.15rc1 (CPython) - Linux-4.15.0-30-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.2-2, ffprobe 3.4.2-2
[debug] Proxy map: {}
[generic] xKoFIRl: Requesting header
WARNING: Falling back on generic information extractor.
[generic] xKoFIRl: Downloading webpage
[generic] xKoFIRl: Extracting information
ERROR: Unsupported URL: https://imgur.com/a/xKoFIRl
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 2309, in _real_extract
    doc = compat_etree_fromstring(webpage.encode('utf-8'))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2542, in compat_etree_fromstring
    doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2531, in _XML
    parser.feed(text)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1659, in feed
    self._raiseerror(v)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1523, in _raiseerror
    raise err
ParseError: not well-formed (invalid token): line 103, column 50
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 502, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 3274, in _real_extract
    raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://imgur.com/a/xKoFIRl

Description of your issue, suggested solution and other information
a link to the album does not work: https://imgur.com/a/7ffa0TU
but the same link without "/a/" works: https://imgur.com/7ffa0TU
youtube-dl https://imgur.com/7ffa0TU
[Imgur] 7ffa0TU: Downloading webpage
[download] Destination: Imgur GIF-7ffa0TU.mp4
[download] 100% of 12.84KiB in 00:04

related #9833, #2157
but I don't think this is an issue with the extractor itself. I think the url is just not passed to the correct extractor


Add support for ng-href and on in link tag

I found out that:
<link ng-href="themes/{{theme||'default'}}/css/style.css" rel="stylesheet" onerror="this.href='themes/experter/css/style.css'">

is being parsed as:
<link ng-href="themes/{{theme||?v=44edd1b317271634126140a94694357b'default'}}/css/style.css" rel="stylesheet" onerror="this.href='themes/experter/css/style.css'">

which is not the expected output. The expected output should be:
<link ng-href="themes/{{theme||'default'}}/css/style.css?v=44edd1b317271634126140a94694357b" rel="stylesheet" onerror="this.href='themes/default/css/style.css?v=44edd1b317271634126140a94694357b''">

I'm using version 0.1.7, using the version config as shown below:
const versionConfig = {
    'value': '%MDS%',
    'append': {
        'key': 'v',
        'to': ['js', 'css', 'sass'],
    },
};

now, custom attribute supported. "append.to.{Object}.attr"

Nice. But this does not solves the problem related to ng-href , right?

attribute is ['href', 'ng-href', ...] which you want to append

Both of these attributes. As I understand, using
const versionConfig = {
    'value': '%MDS%',
    'append': {
        'key': 'v',
        'to': [
            {
                'type': 'js'
            },
            {
                'type': 'css',
                'attr': ['href', 'ng-href', 'onerror']
            }
        ],
    },
};

Is giving me this output
<link ng-href="themes/{{theme|| ?v=2b0b76da590ce4487593d2b93d10295c'default}}/css/style.css" rel="stylesheet" onerror="this.href=?v=2b0b76da590ce4487593d2b93d10295c'themes/default/css/style.css'">

Which is not right. I'm defining versionConfig wrong?

I think that's not a standard link 😆, it contains templates or logic. Why not use the replacement mode

I see. Even if is not a standard link, the regex used do match links should be able to deal with this (since is a valid syntax).
And did you notice that the generated onerror's attribute link is wrong too?


Make the function-sample-aws simple to run on linux/macosx with updates instructions

Describe the issue
When following these instructions they lead to function-sample-aws and if you check that out and run it you can run into a set of problems that are difficult to understand/explain if you are new to the concepts of this project and not on windows.
It should be pretty easy to address by documenting the steps that are needed specific to the context.  E.g., linux or macosx
Sample
These instructions suggest You simply execute ./mvnw clean package to generate JAR file. and since on my host (macosx) I don't use windows I translated to this You simply execute mvn clean package to generate JAR file.  Pretty straightforward.  However, the next steps deviate as I didn't want to run a deploy to AWS but rather switch to use AWS SAM locally FIRST, to get the hang of things.
And when I ran sam local invoke I get this:
Class not found: org.springframework.cloud.function.adapter.aws.FunctionInvoker: java.lang.ClassNotFoundException
java.lang.ClassNotFoundException: org.springframework.cloud.function.adapter.aws.FunctionInvoker
	at java.base/java.net.URLClassLoader.findClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Unknown Source)

Which appears to be a very common problem that people ask about, however, there is no straightforward answer.  There are however lots of finger pointing to AWS SAM or Spring Cloud Function etc. having the issues.  In the end I was able to determine that there is indeed some expectations on AWS SAM about how the packaging of the code will be created when AWS SAM local is executed.  It depends on sam build to be executed so that the artifacts will be located correctly in the container.  However,  when I ran sam build it chokes on the fact that I have no mvnw environment.  Again, I assumed the instructions of mvn clean package were sufficient and so I missed that sam build was the only real means to get sam happy.
Specifically, I had to drop the mvnw et. al.  (I literally deleted it).  I also deleted the .aws-sam directory as I wanted to make sure I was clean on all accounts. Then I ran the sam build and then sam local invoke and everything worked as expected.
In other words lots of wasted time trying to get the simple 'demo' to work locally with Spring Cloud Function and AWS SAM local.  And in a few post I found people just switched languages to python.  🤷
It would be ideal to document how to bootstrap for linux/macosx such that it just works on the first 10m instead of wasting time chasing ClassNotFoundException to get it to work.

@roskelleycj
First, thank you for all of these details. . . . and it seems like you have spent "some time" getting it to work.
Obviously there are (as you pointed out) certain expectations for SAM that could be different then for a real deployment. . .
But I do agree it would be nice if this could be documented.
Do you mind providing a documentation PR? I can guide you thru it as well.


Feedback on Note

Howdy
I believe the first "Note" section is inconsistent.
It states the Windows Server 2016/VS 2017 is being deprecated as of Sep 2021, whilst suggesting lower down that customers are encouraged to migrate to that version.  Believer the "target version" should be Windows Server 2019 or 2022.
Dean

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61db3371-6395-88a2-fb78-09f98790ab1b
Version Independent ID: ef6f1bf7-02b8-9093-b84e-c9bde7d98e57
Content: Microsoft-hosted agents for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/agents/hosted.md
Product: devops
Technology: devops-cicd-agents
GitHub Login: @steved0x
Microsoft Alias: sdanie

Good catch, I will get that updated today, thank you/


Source for 1.0.7 ?

Hello,
First thank you for your work on this extension and its companion addon, very useful to dev in a sane environment ;)
I noticed that the extension currently on VSCode Marketplace is ahead of what's on your repo. Is it possible to push your changes ? I'm thinking of maybe adding a couple of features as I work more with this extension. (and if you need help maintaining it, I'd be glad to!)

Thanks @rthery, I've just pushed up the source for 1.0.7 - feel free to make any improvements. I'm happy to merge anything back into the main branch and publish

Thanks, will be happy to submit PRs then :)


Mm 37532 split name and team

Summary
This PR will split playbook name and team name
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-37532

Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[ ] Unit tests updated

This would be the result of the playbook name and team name split


PANIC: index out of bounds: the len is 1 but the index is 1

Hi Prisma Team! My Prisma Client just crashed. This is the report:
Versions

Name
Version

Node
v14.15.3

OS
windows

Prisma Client
2.13.1

Logs
  prisma-client { clientVersion: '2.13.1' }

everything is working perfectly in wsl2(ubuntu 18.04) with same code
but in windows "npx prisma migrate dev --preview-feature" and send any query or mutation via gql playground
I've got this error PANIC: index out of bounds: the len is 1 but the index is 1
(I follow the document of nestjs  and prisma-nest git exmple repo)
please cheak my github repo (https://github.com/kimyh03/prisma-nestjs-graphql-windows-error)
src/app.module.ts
import { Module } from '@nestjs/common';
import { GraphQLModule } from '@nestjs/graphql';
import { join } from 'path';
import { PrismaService } from './prisma.service';
import { UserResolver } from './resolvers.user';
@Module({
  imports: [
    GraphQLModule.forRoot({
      autoSchemaFile: join(process.cwd(), 'src/schema.gql'),
    }),
  ],
  controllers: [],
  providers: [PrismaService, UserResolver],
})
export class AppModule {}

src\prisma.service.ts
import { Injectable, OnModuleInit, OnModuleDestroy } from '@nestjs/common';
import { PrismaClient } from '@prisma/client';

@Injectable()
export class PrismaService
  extends PrismaClient
  implements OnModuleInit, OnModuleDestroy {
  async onModuleInit() {
    await this.$connect();
  }

  async onModuleDestroy() {
    await this.$disconnect();
  }
}

prisma\schema.prisma
// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
}

model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
}

src\resolvers.user.ts
import 'reflect-metadata';
import {
  Resolver,
  Query,
  Mutation,
  Args,
  InputType,
  Field,
} from '@nestjs/graphql';
import { Inject } from '@nestjs/common';
import { User } from './user';
import { PrismaService } from './prisma.service';

@InputType()
class SignupUserInput {
  @Field({ nullable: true })
  name: string;

  @Field()
  email: string;
}

@Resolver(User)
export class UserResolver {
  constructor(@Inject(PrismaService) private prismaService: PrismaService) {}

  @Mutation(() => User)
  async signupUser(@Args('data') data: SignupUserInput): Promise<User> {
    return this.prismaService.user.create({
      data: {
        email: data.email,
        name: data.name,
      },
    });
  }

  @Query(() => User, { nullable: true })
  async user(@Args('id') id: number) {
    return this.prismaService.user.findUnique({
      where: { id: id },
    });
  }
}

src/user.ts
import 'reflect-metadata';
import { ObjectType, Field, ID } from '@nestjs/graphql';

@ObjectType()
export class User {
  @Field(() => ID)
  id: number;

  @Field()
  email: string;

  @Field(() => String, { nullable: true })
  name?: string | null;
}

Hello @kimyh03
Sorry for the late reply here. I haven't had a windows machine in hand so this got delayed a bit.
I am unable to reproduce this in my windows machine as you can see below:

Can you please try with a fresh database? If you can still reproduce this, please share dump of the database so that I can retry this reproduction.

Hello @kimyh03
Sorry for the late reply here. I haven't had a windows machine in hand so this got delayed a bit.
I am unable to reproduce this in my windows machine as you can see below:

Can you please try with a fresh database? If you can still reproduce this, please share dump of the database so that I can retry this reproduction.


[WIP] Simple config

Motivation
For simpler config system. I think we can use mmlab models easier like transformers.
If this system is good, we can modify for all models.
Modification
Config examples.
model = dict(type='ImageClassifier', arch='r50', head=dict(num_classes=1000))
model = dict(type='ImageClassifier',
             arch='r50',
             backbone=dict(init_cfg=dict(
                 type='Pretrained', checkpoint=checkpoint, prefix='backbone')),
             head=dict(num_classes=100)
            )
model = dict(type='ImageClassifier', arch='swin-t', head=dict(num_classes=1000))

Detection examples.
# https://github.com/open-mmlab/mmdetection/blob/master/configs/yolox/yolox_s_8x8_300e_coco.py
model = dict(
    type='YOLOX',
    input_size=img_scale,
    random_size_range=(15, 25),
    random_size_interval=10,
    arch='yolox-s'
    bbox_head=dict(num_classes=80))

I also think all backbones in mmcls should be as easy to specify as swin.
Config examples.
# https://github.com/open-mmlab/mmclassification/blob/master/configs/_base_/models/resnet50.py
backbone=dict(
        type='ResNet',
        arch='r50')

# https://github.com/open-mmlab/mmclassification/blob/master/configs/_base_/models/wide-resnet50.py
backbone=dict(
        type='ResNet',
        arch='wr50')

Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

@Ezra-Yu What do you think about it?


feat: add use extension

This exports a function that can be used with marked.use.
marked.use allows multiple extensions to be used without completely overwriting each other.
This also leaves the current default Renderer so there are no breaking changes.
Usage
import { marked } from 'marked';
import { markedTerminal } from 'marked-terminal';

marked.use(markedTerminal([options][, highlightOptions]));

marked.parse(markdown);

Fantastic stuff! And with additional tests. Great work. Could you update the README with the new API also?

I'm adding it to README as a part of some other work here now! 👍


Fix ConciseView where error message is wider than window width and doesn't have whitespace

PR Summary
This is a bit of an edge case.  Where the error message is wider than the console window width and doesn't contain whitespace, then it doesn't get rendered as the calculation to split the string uses a negative index.  Fix is to check that the string length subtracting the prefix length is greater than 0 before getting a substring, otherwise, just use it.
PR Context
https://github.com/PowerShell/PowerShell/issues/11827
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@PoshChan please retry linux, windows

@SteveL-MSFT, successfully started retry of PowerShell-CI-Linux, PowerShell-CI-Windows


Undefined symbols for architecture x86_64:

Hi,
I am new to iOS programming. As I added the Source files onto my Xcode project, i encountered the following errors when compiling. Any suggestions?
Undefined symbols for architecture x86_64:
Undefined symbols for architecture x86_64:
"OBJC_CLASS$_CLLocationManager", referenced from:
objc-class-ref in INTULocationManager.o
"_kCLLocationAccuracyBest", referenced from:
-[INTULocationManager startUpdatingLocationIfNeeded] in INTULocationManager.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Assertion failure in -[INTULocationManager startUpdatingLocationIfNeeded], /Users/andrew/Documents/workspace/flint/code_0605/YYPro/src-app/app/libraries/INTULocationManager/INTULocationManager.m:299
what's wrong? please help! thanks ...

@shaobo8910 You are hitting the assertion here: https://github.com/intuit/LocationManager/blob/master/LocationManager/INTULocationManager/INTULocationManager.m#L299
Please read this section of the README: https://github.com/intuit/LocationManager#ios-8


Bills endpoint refactor

This is a re-write of the Bills of Mortality endpoint that makes the endpoint more flexible and predictable. The primary change is instead of using multiple case statements to determine the correct query, the query gets built depending on parameters provided by a user. This means we also do away with some of the oddness of creating a false "All" category for certain parameters. Finally, the endpoint now includes a way to return all the data without a limit or offset provided.

@qtrinh2 Would you like me to merge this into main, or do you want to work with this branch on the server first?

@qtrinh2 Would you like me to merge this into main, or do you want to work with this branch on the server first?

@hepplerj you can merge it, i already tested the deployment.


Merge / extend ObjectRepository with Collection interfaces (3.0)

I'm opening this issue as a proposal and a place to debate this. I can (and want to, if you guys agree) implement this on ORM.NEXT, so it's not only a feature request! I just know beforehand that it'll be a lot of code changes, and don't want to send a PR without chatting a bit first.
BTW, I know of doctrine-dev IRC, but I don't usually get much feedback there, so don't be mad at me for trying something different this time :sweat_smile:
Repository pattern
From PoEAA: (The repository) Mediates between the domain and data mapping layers using a collection-like interface for accessing domain objects.
Proposal
Make repositories expose a collection-like interface. Then, make both repositories and collections share implementations.

iterable repositories
implement all Collection methods
"query" methods could return a new instance of the Repository / Collection instead of fetching right away or falling back to QueryBuilder. The new instance would accumulate conditions and execute the query when iterated or otherwise initialized.
Merging both worlds would reduce userland complexity when working with associations or repositories: Associations are pre-filtered repositories.

Examples
Iterable repositories
$books = $entityManager->getRepository(Book::class);

foreach ($books as $book) { /* SELECT * FROM books; */ }

Associations as repositories
$author = $entityManager->find(Author::class, 1);
foreach ($author->getBooks() as $book) { /* SELECT * FROM books WHERE author_id = 1 */ }

// Nested calls could be lazily implemented, returning a new instance of the repo with the accumulated query
$author->getBooks()->findBy(['format' => $format])->first(); // SELECT ... WHERE format_id = :id LIMIT 1;

// This could also be improved somehow, Criteria is very verbose...
$filtered = $authors->getBooks()->matching(Criteria::create()->where(
    Criteria::expr()->eq('foo', 'bar')
));

// SELECT * FROM books WHERE author_id = 1 AND foo = 'bar' LIMIT 1;
$filtered->first();

Aggregate queries could be also lazy loaded and handled with a single API:
$books = $entityManager->getRepository(Book::class);

// No query yet, $featured instanceof Repository
$featured = $books->findBy(['featured' => true]);

// Could be answered with single query instead of loading entities to memory
$featured->average('price');
$featured->count();
$featured->sum('price');

$featured->map(function (Book $book) {
    // Loaded entities on memory
});

$featured->reduce(function ($carry, Book $book) {
    // Loaded entities on memory
}, 0);

Modeling system facades:
class Library
{
    private $books;
    private $authors;

    public function __construct(Repository $books, Repository $authors){ /* ... */ }

    public function featuredBooks()
    {
        // Could also be a custom method in repository, just illustrating here.
        return $this->books->findBy(['featured' => true]);
    }
}

class HomeController
{
    public function home(Library $library)
    {
         return view('home', ['books' => $library->featuredBooks()]);
    }
}

May be related to https://github.com/doctrine/doctrine2/issues/6311


@bentley/imodeljs-native 3.2.13

Consume fix: https://bentleycs.visualstudio.com/iModelTechnologies/_git/imodel02/commit/78622c40566c905110bcc9ec9207e04864ed08dd?refName=refs%2Fheads%2Fimodeljs%2F3.x

Do I need to run rushchange.bat again?

Shouldn't need to -- backend tests don't publish a changelog.
Cross fingers updating azurite didn't pull in new audit issues...


Fix scala icon

Just adding a double quote to fix the scala icon not being parsed correctly in the webpage.

Thanks


import parameter is not being taken in account

When creating a new thread, even if the import parameter is set to true, helpscout will send an email.
I spoke with @craig-davis from helpScout and he confirmed the import parameter appears to be unused.

I believe that the import parameter is not being used in the call to Post on line 123.

Sorry for the delay
I'm currently on annual leave, I will have a look as soon as I'm back home

@mathieukempe Thanks for the update. Much appreciated.
I found a couple of misspelled methods as well, in particular some methods named ListConservations *. You can see them here: https://github.com/Selz/HelpScoutNet/blob/master/src/HelpScoutClient.cs#L67
Thanks for this library!

The import flag on thread  is fixed (with the misspelled methods)


Add ability to have no rating

At the moment when you initialize the rating it will always show as e.g. 1 star selected. This gives a false impression that the user has already rated when in fact they haven't.
You can get around this by adding a hidden option that is selected like:
<select>
	<option value="" selected disabled hidden></option>
	<option value="1">1</option>
	<option value="2">2</option>
	...
</select>

But this feels a bit clunky, it should be easier to do in the plugin itself. Maybe a new option like allowEmpty could simulate the above in the plugin itself. What do you think?

It's actually the expected way of allowing for empty ratings... May need to be documented more explicitly though.
I considered adding an allowEmpty or similar option in the past, but in the end decided that it's better to rely on select field markup. If you look at Example C and play around with enable/disable button you'll see the select field and rating widget are kept in sync. I think that couldn't be easily done if the empty rating wasn't defined in the markup.
http://www.antenna.io/demo/jquery-bar-rating/examples/

I think that couldn't be easily done if the empty rating wasn't defined in the markup.

What I was thinking was the allowEmpty would basically just add the <option ..> empty field automatically to the markup during initialization, either at the beginning or end depending on if reverse.

Ok, it could work as you described it... Essentially there would be two ways of allowing for empty ratings - either by having it defined on the select field or by setting the option.

@antennaio Have you worked on the allowEmpty thing

Not yet, but it's more of a nice-to-have feature - the same effect can be achieved by adding an empty option to the select field as described in the FAQ:
http://antenna.io/demo/jquery-bar-rating/examples/#nav-faq

I added an allowEmpty option.
By default it is set to null, which means that the plugin will look for an option with empty value and if it's present it will assume that empty ratings are allowed (just like it worked until now).

Looks good :+1:


NOTIFPLT-81: Change layout of notification header icon and count

https://issues.jasig.org/browse/NOTIFPLT-81
Changes layout to a bootstrap badge, with icon and text adjacent to each
other.
Switches default icon to bell.
Removes size setting and instead inherits surrounding size.
Adds active notification color setting to highlight when there are
notifications.
New layout:

Tested. Looks great! Excellent work, as always Christian!


Use predicates on non-partition columns in Iceberg

This has two benefits: (w.r.t. predicates on non-partition columns)

predicates can be used during split generation, reducing the number of splits scheduled
predicates can be used by ORC/Parquet readers

For example, without this patch, the SELECT query in the sequence below would schedule 2 splits instead of 1.
CREATE TABLE T (a bigint, b bigint) WITH (partitioning=array['b'])
INSERT INTO T VALUES (5, 6), (6, 7);
SELECT * FROM T WHERE a = 5;

IN predicates with large value set throw a stackoverflow error in iceberg because iceberg seems to translate it to OR expressions. To avoid this, we loosen up such conditions in tableScan.filter  for predicates on non-partition columns. However, we cannot do the same for partition columns to maintain correctness.

@electrum gentle ping :) there has been a non-trivial change after your last approval.


php symbol icon

Hello,

Ask for a feature.

Is it possible to add symbol icons like in php storm?
here an example

Thanks for your great work.
MacFlurry

You can see the icons VS Code uses here: https://code.visualstudio.com/docs/editor/intellisense#_types-of-completions

Hello, I mean, symbols like class overrode in another class, in phpStorm , they appear like this

I would recommend you to suggest that at the vscode repo first, this is not possible to control through LSP

oh ok,
thanks for your answer.
Best regards,