Feature request: add compatibility for svelte-multicssclass to enable usage of multiple classes in a single class directive in svelte scoped mode

Clear and concise description of the problem
It would be nice if UnoCSS could work together with svelte-multicssclass which is a plugin to enable usage of multiple classes separated by a separator character in a class directive, so for example class:bg-blue-500|hover:bg-blue-300={!red}
Right now it doesn't really work. On first load it works but when HMR kicks in the extra classes are removed.
Repro: https://stackblitz.com/edit/unocss-unocss-cbyaza?file=src/routes/+page.svelte
It works after loading but after typing anything in +page.svelte (for example) the classes get removed.
Suggested solution
No idea of how to implement it or if it is possible, but since it works when loading the first time maybe it could be implemented.
Or maybe it could be implemented as a native feature in svelte-scoped which would be even better.
Alternative
To simply not use svelte-multicssclass but it would be pretty cool if it worked!
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[X] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I'm still undecided if this should be a native feature in svelte-scoped since svelte-multiclass has already addressed it. We can think more about it post #2552 as making it native would require much less code than that required by https://github.com/fernandolguevara/svelte-multicssclass/blob/main/src/plugin.ts as their solution is general purpose.
My main concern would be not introducing any breaking syntax for tooling. An initial test seems to indicate the pipe | is friendly to the Svelte parser:

Related: https://github.com/sveltejs/svelte/issues/7170
In the meantime though, why don't you try creating a PR to solve https://github.com/fernandolguevara/svelte-multicssclass/issues/2 that I posted about your HMR problem. I didn't test the code I posted in there but it should give you what you're looking for.

@henrikvilhelmberglund svelte-multicssclass 2.1.1 is out, can u try hmr now?
@jacob-8 thanks 🚀

@henrikvilhelmberglund is this still a request? How are you finding svelte-multicssclass as a solution to your problem. I'm still chewing on if we want to add this. As well, are there others who want this?

svelte-multicssclass works fine. The original request was just for it to work together with UnoCSS so I'll close this as it works now.


Add keystone container artifact building

This PoC uses existing playbooks to create containers on a host.
We then apply our own playbook to create a container image per role
(first is keystone).

Do not merge yet!

@evrardjp Please can you use branch names of the form u-suk-dev/issues/1074 to make them easier to find if your work needs to be continued for some reason.


Getting working with React 16

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chris Rodgers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add uuid string functions

String is probably the most used form of uuid, but currently it is a bit cumbersome to produce:
(to-string (make-v7))

Should we introduce functions to directly output strings?
Here would be some obvious naming ideas:
make-v7-string v7-string make-v7-to-string
Or would you prefer a different name?

IMO string is only used when converting from/to some external format. Otherwise I'd like to work with the uuid type.
Not sure if additional constructors will confuse the user.

While I wouldn't necessarily call this cumbersome, I agree that it is common enough to be a useful addition to the API (especially when you need pass a function argument). If we add this then all supported conversions should be considered (integer, octets, symbol and string).
I prefer the name make-vN-TYPE (make-v1-octets, make-v4-integer, make-v7-sym, etc.) and the functions should probably be defined in the respective files for each UUID version (this would be non-frugal/name-based.lisp for versions 3 and 5).
Having multiple constructors shouldn't be too confusing I think, we already have them in the current API (e.g. make-v7-from-timestamp).

At some point these could be optimized to avoid some allocations as well.

@kilianmh I hope this works for you: https://github.com/ak-coram/cl-frugal-uuid/commit/c310845c472ea214a60477fb8e33d168041a1017


Support for multiple tours in single page.

We can user two instances in single page but the problem exists because the local-storage name is set to static name called hopscotch.tour.state so one tour which state is set to step 3, this is automatically using by other tour in this case other tour is starting from the step 3. This may be avoided by giving the namespace as developer option.

Hi @padmarao123,
Have you tried setting the cookieName? You can do so in the tour configuration by setting config.cookieName.
Not sure how this would work with multiple tours - I haven't tried.

I didnt see cookieName in the conig, i will give a try

As noted, setting the cookieName when switching tours is a reasonable way to keep state of multiple tours. Hopscotch by design forgets the previous tour when a new one is started, so your app's code will need to act as intermediary with setting the correct cookie name for the tour being launched before starting the tour.
I hope this helps!


Do not consider priorities when sorting workloads from different ClusterQueues

What would you like to be added:
Use priorities to sort workloads within a ClusterQueue, but ignore the priorities when sorting the heads of multiple cluster queues within a cohort.
The design needs to avoid the race condition presented here https://github.com/kubernetes-sigs/kueue/pull/1024
Why is this needed:
In organizations where teams do not know each other, they might be incentivized to use higher priorities to always be ahead of the rest. Ignoring priorities across ClusterQueues would remove this incentive, while allowing users to use priorities within their ClusterQueue.
Maybe this calls for a setting in a new Cohort object.
Completion requirements:
This enhancement requires the following artifacts:

[x] Design doc
[x] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

/assign

Having that StrictFIFO is actually a priority queueing, I couldn't reproduce the bug that was described in https://github.com/kubernetes-sigs/kueue/pull/1024. Maybe there was no bug but actually not desired behavior when low priority workload was admitted and it was preempted just in the next scheduling cycle and we wanted to avoid such scenario and schedule higher priority workload in the first place?
Anyway, my understanding is that we want to have the priority sorting in the scheduling loop as optional (enabled by default), so feature gate could be a solution here.

The example above has some problems
but we can implement this much simpler case

I've added a test cases that you described https://github.com/kubernetes-sigs/kueue/issues/1283#issuecomment-1834370396 in https://github.com/kubernetes-sigs/kueue/pull/1399 and it turns out that the pending workload is still blocking borrowing. Note, that priorities doesn't matter here, I putted the highest priority for borrowing workload. The reason is that the pending workload has "Preempt" FlavorAssignmentMode and has no borrowing, so in sorting it goes before any workload that requires borrowing.
It's definitely a bug, however it's not related to disabling priority feature. So I've added a feature gate to a separate PR https://github.com/kubernetes-sigs/kueue/pull/1406 and will look further how to fix this bug.

For completeness when investigating a solution. In the following case, workload #3 should be blocked, because #2 is waiting to use its nominal quota.

See this comment:
https://github.com/kubernetes-sigs/kueue/blob/e75090ab7ade6b55349768de8f3dff3c9becfaa4/pkg/scheduler/flavorassigner/flavorassigner.go#L201-L204
I think a potential solution could be to change this logic https://github.com/kubernetes-sigs/kueue/blob/e75090ab7ade6b55349768de8f3dff3c9becfaa4/pkg/scheduler/scheduler.go#L190 to only "use" (or block) up to the nominal quota.

Probably adding minimum from workload resources and clusterQueue nominal resources that are left here will help

@yaroslava-serdiuk @alculquicondor I think this is almost done.
I guess that leaving task is adding docs for featureGate, PrioritySortingWithinCohort?
https://github.com/kubernetes-sigs/kueue/blob/main/site/content/en/docs/installation/_index.md#change-the-feature-gates-configuration

yes, we should document this feature.


[tool_crash] FileSystemException: Cannot create link, OS Error: File exists, errno = 17

Command
flutter pub get --no-example

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot create link, OS Error: File exists, errno = 17
#0      _Link.throwIfError (dart:io/link.dart:339:7)
#1      _Link.createSync (dart:io/link.dart:267:5)
#2      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
#3      ForwardingLink.createSync (package:file/src/forwarding/forwarding_link.dart:20:16)
#4      _createPlatformPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:981:12)
#5      createPluginSymlinks (package:flutter_tools/src/flutter_plugins.dart:903:5)
#6      refreshPluginsList (package:flutter_tools/src/flutter_plugins.dart:1013:5)
<asynchronous suspension>
#7      FlutterProject.ensureReadyForPlatformSpecificTooling (package:flutter_tools/src/project.dart:367:5)
<asynchronous suspension>
#8      PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:383:7)
<asynchronous suspension>
#9      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1394:27)
<asynchronous suspension>
#10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#11     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:372:9)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#14     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:308:5)
<asynchronous suspension>
#15     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:130:9)

[✓] Flutter (Channel stable, 3.22.1, on macOS 12.7.5 21H1222 darwin-x64, locale en-GB)
    • Flutter version 3.22.1 on channel stable at /Users/coditas/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (11 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/coditas/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ! Flutter recommends a minimum Xcode version of 15.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • macOS (desktop)              • macos         • darwin-x64     • macOS 12.7.5 21H1222 darwin-x64
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 125.0.6422.113

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: a14f74ff3a1cbd521163c5f03d68113d50af93d3
Plugins
cloud_firestore-4.17.5
cloud_firestore_web-3.12.5
firebase_analytics-10.10.7
firebase_analytics_web-0.5.7+7
firebase_auth-4.20.0
firebase_auth_web-5.12.0
firebase_core-2.32.0
firebase_core_web-2.17.0
firebase_messaging-14.9.4
firebase_messaging_web-3.8.7
flutter_native_splash-2.4.0
path_provider-2.1.3
path_provider_android-2.2.5
path_provider_foundation-2.4.0
path_provider_linux-2.2.1
path_provider_windows-2.2.1
shared_preferences-2.2.3
shared_preferences_android-2.2.3
shared_preferences_foundation-2.4.0
shared_preferences_linux-2.3.2
shared_preferences_web-2.3.0
shared_preferences_windows-2.3.2

@mayurshelar-coditas
Does the issue persist if you run the said command everytime consistently ?


EDIF HEX strings

I was trying to push a pin list through to the edif as a parameter to an iobuf,
#(.LOC("1,2,3,4,5,6,+"))

I am now getting those hex strings.
(string "104'h312c322c332c342c352c362c2b")

There does not seem a way to differentiate those from other strings.
(how am I supposed to parse those?)

the is_string property got lost during techmap
here's a patch:
0001-Fix-for-issue-316.patch.txt

Fixed in commit 1e927a5.


Choice of FITS library

Lets use astropy.io.fits in all of the examples (since it is included in anaconda) but mention that fitsio is sometimes necessary for working with large files, since it uses the compiled cfitsio library whereas astropy is pure python, but has some caveats:

Not included with anaconda
Requires a C compiler to install
Does not work under windows
Similar but not identical API to astropy

Done!


AddParentPom recipe

Tests fail with "Recipe was expected to make a change but made no changes."

What's changed?

A new AddParentPom recipe is added.
What's your motivation?

I need to add a parent POM to my projects.
Anything in particular you'd like reviewers to focus on?

Discover why is the recipe making no changes (as stated by the tests) and how to better share code with ChangeParentPom recipe.
Anyone you would like to review specifically?

@timtebeek (as he invited me to make a draft PR on #4239)
Have you considered any alternatives or workarounds?

Any additional context

Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

Great start @rcsilva83 ! Thanks for kicking this off. I've pushed a change to your PR to get the tests running. You had overridden isAcceptable, but for the precondition check to work you'd need to instead override a visit method, and return a changed instance to trigger the guarded visitor. SearchResult.found does exactly that. Hope that helps you explore what the recipe actually should do, as it seemed you got stuck at this point.

Hi @timtebeek !
Thank you very much for your help. The recipe is almost done: it's working but I still need to handle new parent's properties and dependency management.
However, I have some doubts:

What to do when no versions are found when using wildcard version? (see line 152)
Should I always search for version on Maven repository or should I bypass this when the version is fixed? From what I saw on other recipes this kind of optimization isn't done.

Regards!

I still need to handle new parent's properties and dependency management.

Actually, do you think is there anything to do on this regard? I though I needed to remove properties and dependency management declarations from the pom.xml if they exist on the new parent pom but I don't think that's the case. The ChangeParentPom recipe just add properties and dependency management declarations from the old parent pom, right?
If you can confirm this to me, I'll remove some unused code from the recipe and, after you feedback on the 2 questions I made before, it will be done.

Thanks a lot @rcsilva83 ! To answer your questions I'll reply to each in a separate paragraph below.
In ChangeParentPom we seem to skip with no changes when no acceptable version is found. Probably best to be consistent then, even if it could make for a frustrating debugging experience when there are misconfigurations.
I wouldn't skip over validating the parent; we'd like to be sure the parent exists, since we'll use it to update the model of the code, and might otherwise lead to invalid configuration.
As for updating properties: I'd maybe only go as far as doing a doAfterVisit(new org.openrewrite.maven.RemoveRedundantDependencyVersions().getVisitor()); that clears out one of the major reasons to add a parent pom.xml; if there's more clean ups to be done then I suggest to similarly move those to separate recipes, such that there's less complexity in each, with the opportunity for reuse.
Is there anything else you'd then still like to push before a review and merge?

In ChangeParentPom we seem to skip with no changes when no acceptable version is found. Probably best to be consistent then, even if it could make for a frustrating debugging experience when there are misconfigurations.

I'll adjust this and make a new push. Then I think it'll be ready for merge :)

@timtebeek I need your help on a new problem. After changing the change to make no changes when no suitable version is found, I still got an empty <parent/> in the and, because it was added in the visitDocument method. I couldn't find a way to remove it, so I moved all the code to visitDocument method and removed visitTag method.
Everything is fine but apparently the doAfterVisit(new org.openrewrite.maven.RemoveRedundantDependencyVersions().getVisitor()) isn't working anymore and the versions matching with parent aren't being removed anymore.
How can I solve this? I couldn't find any situation like this in other recipes.

All tests seem to pass; are we missing anything? Wondering because of your question above and the draft status. Ideally we have a failing test if there's anything to add still.
We're planning a new release tomorrow; let me know if this should make it in in the current form, or with small changes.

Hi @timtebeek ! I'll take a look on you feedback and make the code changes needed. But I committed the failing tests I told before so you can understand the problem. I just solve them moving the code to visitDocument method but the RemoveRedundantDependencyVersions stopped working.

@timtebeek, and I thank you for the guidance and patience! Now I know why OpenRewrite is improving so fast and have such a vibrant community :)
Regards!

Thank you! Couldn't do it without so many folks pitching in. You're changes have already landed in
https://github.com/openrewrite/rewrite/releases/tag/v8.29.0
I'll follow up with downstream releases of recipe modules and the OpenRewrite plugins, culminating in our rewrite-recipe-bom over the next couple hours: https://github.com/openrewrite/rewrite-recipe-bom/releases


Is there any way to fix the bias in fc?

Is there any way to fix the bias in fc?
Do I have to modify the optimizer?
Thx!

@LiamZhuuu You can use the no-bias mode and add a constant bias by yourself.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Development of DampedChair4DOF dynamic systems

New system is to implement in module chair.py. It should be inherited from similar class being implemented within scope of the module if possible.

The system works properly, when called using DynSysOverviewReport it returns all the necessary information.


error on PostgreSQL table with array columns

I have a postgres table that was created in the following way
CREATE TABLE argo
(
  id serial NOT NULL,
  float_id integer,
  cycle_nr integer,
  date timestamp with time zone,
  lat double precision,
  lon double precision,
  pres double precision[],
  temp double precision[],
  psal double precision[],
  CONSTRAINT argo_pkey PRIMARY KEY (id)
)

I am trying to read it in blaze. However, when I try to create a new Data object
db = blaze.Data("postgresql://user:pass@host/dbname::argo")

I get the errors listed below. Am I correct in assuming that blaze cannot handle postgres array-type columns?
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2421: SAWarning: Did not recognize type 'geometry' of column 'the_geom'
  (attype, name))
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index argo_lat_round2
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index argo_lon_round2
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index ne_10m_land_splitted_the_geom_geography
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index argo_mbari_date_date
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index argo_mbari_lat_round2
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2673: SAWarning: Skipped unsupported reflection of expression-based index argo_mbari_lon_round2
  % idx_name)
/Users/rpa/anaconda/lib/python2.7/site-packages/sqlalchemy/dialects/postgresql/base.py:2421: SAWarning: Did not recognize type 'geometry' of column 'extent'
  (attype, name))
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type DOUBLE PRECISION[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type REAL[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type DOUBLE PRECISION[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type DOUBLE PRECISION[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type DOUBLE PRECISION[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type TEXT[]
Skipping.
Blaze does not understand a SQLAlchemy type.
Blaze provided the following error:
	No SQL-datashape match for type REAL[]
Skipping.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-2-036c04547e9a> in <module>()
      1 # works
----> 2 tb = bl.Data('postgresql://argoguest:ArgoUser0815@seascape.ldeo.columbia.edu/ocean::argo')

/Users/rpa/anaconda/lib/python2.7/site-packages/blaze/interactive.pyc in Data(data, dshape, name, fields, columns, schema, **kwargs)
     98         for field in sub_uri.split('/'):
     99             if field:
--> 100                 result = result[field]
    101
    102     return result

/Users/rpa/anaconda/lib/python2.7/site-packages/blaze/expr/expressions.pyc in __getitem__(self, key)
    106         elif isinstance(key, (slice, int, type(None), list, np.ndarray)):
    107             return sliceit(self, (key,))
--> 108         raise ValueError("Not understood %s[%s]" % (self, key))
    109
    110     def map(self, func, schema=None, name=None):

ValueError: Not understood _1[argo]

It looks like we don't discover array types for postgres, can you confirm that you can connect to a table that does not use any array types?

I think we can add support for those types fairly easily.

yeah, I agree that it shouldn't be hard to discover these.

can you confirm that you can connect to a table that does not use any array types?

Yes, I can connect successfully to other tables in the db which don't use array types.


tendermint-proto: (re-)add grpc feature and server definitions

See #1225.
Adds a "grpc" feature to the crate along with gRPC server definitions for the "privval" interface used by e.g. TMKMS to support remote signing.
These were originally added in #1137 by @tomtau but lost in the shuffle of Tendermint v0.35-related changes.
They have been updated to use tonic v0.8, which the tendermint-proto crate updated to after the original #1137 PR landed.

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[x] Updated all code comments where relevant
[ ] Wrote tests
[x] Added entry in .changelog/

Codecov Report

Merging #1227 (f0bad92) into main (d102af4) will decrease coverage by 0.1%.
The diff coverage is n/a.

:exclamation: Current head f0bad92 differs from pull request most recent head 474b1bc. Consider uploading reports for the commit 474b1bc to get more accurate results

@@           Coverage Diff           @@
##            main   #1227     +/-   ##
=======================================
- Coverage   64.2%   64.1%   -0.2%
=======================================
  Files        244     244
  Lines      21364   21411     +47
=======================================
- Hits       13734   13730      -4
- Misses      7630    7681     +51

Impacted Files
Coverage Δ

proto/src/lib.rs
100.0% <ø> (ø)

rpc/src/response.rs
48.1% <0.0%> (-11.4%)
:arrow_down:

testgen/src/vote.rs
84.0% <0.0%> (-1.7%)
:arrow_down:

testgen/src/commit.rs
90.6% <0.0%> (-0.7%)
:arrow_down:

testgen/src/header.rs
83.5% <0.0%> (-0.6%)
:arrow_down:

light-client-verifier/src/types.rs
38.4% <0.0%> (-0.3%)
:arrow_down:

tendermint/src/node.rs
63.8% <0.0%> (-0.2%)
:arrow_down:

abci/src/server.rs
9.4% <0.0%> (+0.1%)
:arrow_up:

tendermint/src/timeout.rs
85.9% <0.0%> (+1.7%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Note: the gRPC service definitions are otherwise verbatim from #1137 which generated them using tonic v0.7. I had to tweak accept_compression_encodings and send_compression_encodings to get the code to compile with tonic v0.8.
They should probably be completely regenerated with tonic v0.8, although I'm not sure offhand the best way to do that with tendermint-proto, especially with the grpc feature gating.
FWIW the process for this, including adding the #[cfg(feature = "grpc"))] annotations to the relevant code, is completely automated in cosmos-sdk-proto's proto-build: https://github.com/cosmos/cosmos-rust/blob/bee6a6b/proto-build/src/main.rs#L398-L418

Oh wow, so it is. That's unfortunate

@thanethomson any idea if/when the gRPC privval interface will get re-added upstream in Tendermint?

any idea if/when the gRPC privval interface will get re-added upstream in Tendermint?

It's in our prioritized backlog. We have a bunch of burning, high-priority issues to deal with this quarter (see this board), so those things take precedence. As we have capacity we pick things off the prioritized backlog to work on.

Aha cool, here's the relevant issue: https://github.com/tendermint/tendermint/issues/9256

If this is still needed, can you rebase it and fix the conflicts?

@mzabaluev it's blocked on https://github.com/tendermint/tendermint/issues/9256 (which I now see was closed as stale).
I would definitely still love to see all of this happen, if possible though.

Should this be closed in favor of #1338?

Sure


Problem with "Shared Resources" section.

In the "final complete XAML file with three buttons..." section:
FontSize"{StaticResource fontSize}"
Should be
FontSize="{StaticResource fontSize}"
Also, any time I try to use a StaticResource for FontSize, the UWP app crashes.  (Haven't tried Android or ios).  This is with VStudio 15.6.5, Xamarin <IP_ADDRESS>2 (0faa808ee).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 673a2420-3d41-aa5d-a8e4-3383cf10da6e
Version Independent ID: ecdf7b35-97d1-524d-d448-9b7865b5b66a
Content: Part 3. XAML Markup Extensions - Xamarin
Content Source: docs/xamarin-forms/xaml/xaml-basics/xaml-markup-extensions.md
Service: unspecified
GitHub Login: @charlespetzold
Microsoft Alias: chape

Thank you! Defining a FontSize resource as an x:String worked once but does not work any longer. It's much safer to define the resource as an x:Double with a numeric value. I have made that change in this article and the XamlSamples code sample. The changes should show up within a day or so.

Problem with "Shared Resources" section.
its giving me an error, Value cannot be null


build failed in go1.12

hi、When I am build goproxy in go1.12,I got this:
go generate
go build

go: finding github.com/goproxyio/goproxy/internal/sys latest
go: finding github.com/goproxyio/goproxy/internal latest
build github.com/goproxyio/goproxy: cannot load github.com/goproxyio/goproxy/internal/sys: cannot find module providing package github.com/goproxyio/goproxy/internal/sys

@ztxmao Plase use go1.11 at this moment.

The same to this case. Also use go 1.12

#61


Update IOMMU ref model with option to cache ATS translations in IOMMU ATC

In some cases it is beneficial to cache responses provided in ATS translation completions in IOMMU ATC. This is currently done only when T2GPA is 1. This PR updates it to add the support for doing caching for T2GPA=0 case as well.

ATS translation request is not exercisable through the debug register interface. Model was built especially to compare translation requests executed by model vs. the debug register interface.
The model is providing an example of implementation but one could decide not to cache any ATS translation request (regardless of T2GPA). This option is not provided by the model.

The model is intended for the specification. I think its useful to add the do not cache ever option. I will refresh the PR with that option.


running time

millis?

ds.millis()

Or uptime to match jacdac. Can we get a builtin control client for the self device instead?


Automatic error report

<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>
Installed beautifulsoup through conda install on anaconda prompt, said environment was inconsistent.
It fixed the environment on it's own, after that I got the error message.

What error message?

Fixed the error already.
Thank you!
On Thu, Aug 1, 2019 at 4:09 PM Carlos Cordoba<EMAIL_ADDRESS>wrote:

What error message?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/9947?email_source=notifications&email_token=AK3W472F52ONEEVKRC236KTQCNNI5A5CNFSM4IIUI6OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MA5II#issuecomment-517476001,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK3W475HPDWOM6GQH55H5K3QCNNI5ANCNFSM4IIUI6OA
.

--
Martin Salas


chore(release): fix missing slash in helm cosign

Fixes #
Description
Found there is a missing slash in the cosign logic for helm which is an issue for releasing. Fixing.
How was this change tested?
Nothing additional.
*
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

NONE

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.736%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35662

Relevant Lines:
36488

💛  - Coveralls


ci: main branch health build notification

First attempt at a Slack notification..

🛠 Docs Preview Building...

Configuration
{
  "repoOverrides": {
    "apollographql/apollo-ios-dev@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "apollo-ios-dev",
        "branch": "ci/nightly-build-notification"
      }
    }
  }
}

0d77250db809107cb4cb59b1df5d0677e837bf19

Since this only changes the nightly build action I'll be merging this as soon as the tests pass.


Link to GitLab in download rate limits documentation

Proposed changes
This MR adds GitLab to the list of 3rd party vendors on https://docs.docker.com/docker-hub/download-rate-limit/#third-party-platforms and links to their documentation for authenticating/logging in to Docker.
The goal is that any community members using the GitLab Container Registry can understand how to remediate any issues due to rate limits.

Perfect, thanks @dberkholz @StefanScherer @thaJeztah for your fast collaboration!


Add an example of updateMask

Problem
I spent a lot of time figuring out how to pass updateMask in plain JS
Solution
It would be very useful to update the documentation of updateJobs with a filled updateMask example like:
const job = {
        name,
        description,
        schedule
    };
const updateMask = {
    paths: ["description","schedule"]
};
const request = {
    job,
    updateMask
};

Alternative solution
As this actually applies to all the JS libraries backed by grpc this documentation may be added somewhere else.

Fixed in #265


Incompatible types checking error using Enums

When upgrading a "enum" type in my contract, I have these cases:
Base enum
    enum MyEnum { AA, BB }

Keep enum size the same but change the names.
Example: new enum:     enum MyEnum { AA, BC }
This is marked as invalid though it should be valid.
Shrink enum size.
Example: new enum:     enum MyEnum { AA }
This is marked as invalid. I "could" be valid
Grow enum size.
Example: new enum:     enum MyEnum { AA, BB, CC }
This is marked as valid.

However, I think that being all uint8 internally, there is no incompatible types, and they should all be valid.

Can you provide two sample contracts A and B that are marked as invalid when you try to upgrade from A to B?

The problem at the core here is that our definition of "valid" is not simply that an upgrade will not corrupt the storage layout, we also try to catch problems that might lead to corruption of the storage semantics now or in the future. The reason we don't allow removal or reordering of enums is that instances of those values may already be in storage. If you have a mapping (uint => Status) with enum Status { Open, Closed }, and you upgrade a contract where the enum Status is reordered to enum Status { Closed, Open }, all of the Status instances that are already in storagef will change to the opposite meaning!

The problem at the core here is that our definition of "valid" is not simply that an upgrade will not corrupt the storage layout, we also try to catch problems that might lead to corruption of the storage semantics now or in the future. The reason we don't allow removal or reordering of enums is that instances of those values may already be in storage. If you have a mapping (uint => Status) with enum Status { Open, Closed }, and you upgrade a contract where the enum Status is reordered to enum Status { Closed, Open }, all of the Status instances that are already in storage will change to the opposite meaning!

But they are "compatible types".
Maybe this should be called a different way, and allow a different unsafeSkipOption, other than unsafeSkipStorageCheck.

Here's a trick, you can use the "retyped" feature for layout-compatible types. In the case of enums, if you're getting an error from the following variable:
contract C {
    enum MyEnum { AA, BC }

    MyEnum e; // error here

You can write this to pass the checks:
contract C {
    enum MyEnum { AA, BC }

    /// @custom:oz-retyped-from enum C.MyEnum
    MyEnum e;

In the retyped comment, enum C.MyEnum should describe the original type. Here I'm assume the original type had the same name and was defined inside a contract C. You will see this type in the validation report in the console. If you see:
Bad upgrade from enum C.MyEnum to enum C.MyEnum

This means that you should write the comment as I put in the example above.


Add redisClusterAsyncCommandArgvToNode API

Hello!
This PR add a API redisClusterAsyncCommandArgvToNode.
It's possible that someone else is working on this issue, if so, I am very sorry.
Resolve: #104

@zuiderkwast cc: @bjosv
I've added a commit to fix build issue for Windows.
Please have a look again.
3cd56d2a9eb3472c5e0c5f9d4c5fd461452ddec2 Fix: I forgot to update hircluster.def. c.f. https://github.com/plainbanana/hiredis-cluster/blob/62ead90cc0eefd6e5551b44f0c37eb1480dc3729/CONTRIBUTING.md?plain=1#L53-L55


MSSIM loss function

Hi, Thank you for this work. I ran into the following problems while running the code you provided that is the MSSIM loss function you provided missing 1-MSSIM? What I see in the code is -MSSIM. How should I understand this? Looking forward to your reply.

Hi， please see the link for detailed implementation of MS-SSIM loss.
https://github.com/liuh127/Two-branch-dehazing/blob/7fa08e810dba73088081384ec4a1940c872784e2/pytorch_msssim/__init__.py#L124
We use the implementation in https://github.com/jorge-pessoa/pytorch-msssim.

Hi, Thank you for this work. I ran into the following problems while running the code you provided that is the MSSIM loss function you provided missing 1-MSSIM? What I see in the code is -MSSIM. How should I understand this? Looking forward to your reply.

Hi， please see the link for detailed implementation of MS-SSIM loss.
https://github.com/liuh127/Two-branch-dehazing/blob/7fa08e810dba73088081384ec4a1940c872784e2/pytorch_msssim/__init__.py#L124
We use the implementation in https://github.com/jorge-pessoa/pytorch-msssim.

Thank you very much!


Issue with installing from tar.gz with Python3.11

Hi,
I am trying to pip install pydantic_core-2.14.6.tar.gz from pypi using python3.11 (I am using 2.14.6 and not the newer version because this is the exact version required by the newest pydantic release).
I get the following error related to maturin not being found, even though maturin package is already installed (verified with pip freeze):
 Checking for Rust toolchain....
      Running `maturin pep517 write-dist-info --metadata-directory /tmp/pip-modern-metadata-93v6ooxb --interpreter /usr/bin/python3.11`
      Traceback (most recent call last):
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-6f_6pi9c/overlay/local/lib/python3.11/dist-packages/maturin/__init__.py", line 187, in prepare_metadata_for_build_wheel
          _output = subprocess.check_output(command)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3.11/subprocess.py", line 466, in check_output
          return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3.11/subprocess.py", line 548, in run
          with Popen(*popenargs, **kwargs) as process:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
          self._execute_child(args, executable, preexec_fn, close_fds,
        File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
          raise child_exception_type(errno_num, err_msg, err_filename)
      FileNotFoundError: [Errno 2] No such file or directory: 'maturin'
      [end of output]

Thanks in advance

Can you give a minimal reproduction of the sequence of commands you are using to run the build? This sounds like a misconfiguration of the build environment.

downloaded pydantic_core-2.14.6.tar.gz from pypi
python3.11 -m pip install pydantic_core-2.14.6.tar.gz
got the above error
python3.11 -m pip freeze | grep maturin
>> maturin==1.4.0

I will also add that installing not from source (python3.11 -m pip install pydantic_core) does work. But for my build I need to install from source.

Installing from the following wheel instead of using the tar.gz works: pydantic_core-2.14.6-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.
Closing, thanks for the help.


build breaks after FindGraphQLTags error

i've found that certain errors seem terminal and no matter what i do i can't get webpack to rebuild certain relay files.
for example, here's my initial error:
ERROR in ./app/assets/javascripts/components/Application.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Syntax Error: Expected $, found )

GraphQL request (2:30)
1:
2:   subscription JobWasCreated() {
                                ^
3:     jobWasCreated() {

fixing the above error causes a rebuild which then (correctly) catches a new error:
ERROR in ./app/assets/javascripts/components/Application.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Syntax Error: Expected Name, found )

GraphQL request (3:19)
2:   subscription JobWasCreated {
3:     jobWasCreated() {
                     ^
4:       job {

fixing that error causes a rebuild which gives me a FindGraphQLTags error:
ERROR in ./app/assets/javascripts/components/Application.js
Module not found: Error: Parse error: Error: FindGraphQLTags: Operation names in graphql tags must be prefixed with the module name and end in "Mutation", "Query", or "Subscription". Got `JobWasCreated` in module `Application`. in "components/Application.js"
 @ ./app/assets/javascripts/components/Application.js 5:123-171 5:399-447
 @ ./app/assets/javascripts/routes/Application.js
 @ multi @babel/polyfill url-polyfill raf/polyfill webpack-hot-middleware/client ./app/assets/javascripts/routes/Application.js

but once i resolve this error i end up here:
ERROR in ./app/assets/javascripts/components/Application.js
Module not found: Error: Can't resolve './__generated__/ApplicationJobWasCreatedSubscription.graphql' in '/Users/jon/git/swoop/app/assets/javascripts/components'
 @ ./app/assets/javascripts/components/Application.js 5:123-194 5:445-516
 @ ./app/assets/javascripts/routes/Application.js
 @ multi @babel/polyfill url-polyfill raf/polyfill webpack-hot-middleware/client ./app/assets/javascripts/routes/Application.js
ℹ ｢wdm｣: Failed to compile.

and no matter what i do (changing file again, changing name to something different then back) i cannot get this file built.  for comparison if i call relay from the cli it does build the file:
$ npx relay-compiler --src ./app/assets/javascripts --schema ./app/assets/javascripts/graphql/schema.graphql --extensions js jsx
HINT: pass --watch to keep watching for changes.

Writing js
Created:
 - ApplicationJobWasCreatedSubscription.graphql.js
Unchanged: 4 files
✨  Done in 1.23s.

i can't share my repo but i hope this is enough to trace down - if not i'd be happy to create a test repo if you can point me to a simplish starting point repo? thanks!

Thanks for the report @modosc . I've got a project using this starting in a few weeks and I can look into it then. There is a simplish starting repo available here if you do want to mess around with it in the meantime: https://github.com/danielholmes/relay-compiler-webpack-plugin-example

@modosc I think this is fixed now with the latest release v1.0.0, but I don't have a project using subscriptions to test your exact case. (Note that this version is backwards incompatible with relay-compiler 1.6 and below because of the changes introduced in relay-compiler 1.7)


mode request: Cucumber

Hello, what do you think if we will add https://github.com/lazyatom/cucumber.el as an option to init.el ?

Sorry for the very late reply. Since Cucumber and its ilk are language agnostic (and I'm unfamiliar with it), I'm uncertain where cucumber would fit in. I'll consider a PR, but if it requires no substantial configuration, I'd rather it be left to users to install themselves.


Vertical Section places Viva Dashboard at the bottom of the page in the SharePoint Mobile experience

Microsft recommends the use of the vertical section for displaying the Viva Dashboard on the SharePoint home site for best results: https://docs.microsoft.com/en-us/sharepoint/create-dashboard#use-the-dashboard-web-part-for-viva-connections
Currently, the vertical section is displayed at the bottom of the responsive page design in the SharePoint mobile/app experience.  This is not the preferred user experience reported by clients.  When a dashboard web part is included in the vertical section, it is preferred to be displayed above the fold.

Thanks for your input. This is currently by design from our design organization. I've bypassed the feedback to them, but there really is nothing more we can do around this through this issue list.


Push more then one packages at once?

Hi,
is it needed to push each single package because of the tag?
I haven't much experience with git and haven't worked with tags before.

is it needed to push each single package because of the tag?

Just create a commit/tag for each package release:
git commit ${PACKAGE}/${PACKAGE}.tar.gz -m "Publish ${PACKAGE} version ${VERSION}."
git tag ${PACKAGE}/${VERSION}

and then push everything:
git push
git push --tags

Hi,
so single push is ok, but each package release needs it's own commit + tag.
So release 3 packages needs 3 commits, 3 tags and 1 push / push tags.
Thanks!

Hi,
so single push is ok, but each package release needs it's own commit + tag.
So release 3 packages needs 3 commits, 3 tags and 1 push / push tags.
Thanks!


Let's support Functions and new models

Openai has introduced new models and function calls. Let's support these new features.
Thanks

The models are already automatically supported since you can set them yourself, just FYI.

Thanks. It's more about the function call feature.


FatalErrorException gets sent twice

I was just testing some changes I have made and I noticed that when a fatal syntax error occurs and a Symfony\Component\Debug\Exception\FatalErrorException is thrown Bugsnag is notified twice?
These errors wouldn't make it into our production code of course :wink: I just thought you might want to know in case that's something you need to be aware of.

Closing as we have merged a fix!


Restyle api docs for classes and directives

There is a live test link if you'd like to check it out: https://api-doc-styling-1.firebaseapp.com/
This PR is work towards closing https://github.com/angular/angular.io/issues/964, as it stands, there are already quite a bit of changes in the codebase. This is in an effort to make code review easier. I will continue fulfilling the proposal in https://github.com/angular/angular.io/issues/964 in a subsequent PR.

@wardbell this looks good to me -- I won't have time to merge it until late today. If convenient, could you merge and verify with check-deploy? (but no rush if you are swamped)

Merged and live!


Setup front end app with index and view query of O&G operators

Create node.js REACT app for oil and gas ESG portal. Put this in new directory (e.g., esg-portal) under app/
This simple app should expose index and view pages.

Index will provided a paginated list of organizations queried from POSTGRES database
View will list information about the divisions (e.g., states) they operate under, and information on the total number of assets they operate and their lat long coordinates.

Next we will work on integrate mapping plug-ins (e.g., arcgis) to show where these assets are located.
Late we will include division and assets level emission certificate statistics to the organization's view page.

net-zero-project/blockchain-carbon-accounting#1

How

@rose33-maker this was resolved several months ago. If you are interested in contributing I we can discuss opening a new for you to work on


EC rights educational pages

As a member of the education committee you can currently change the educational information page (as the board would). It also looks like you can change the pages of for example the educational bouquet and IDEA pages. Only when you click on the edit button it tells you you do not have the authority to go to that page. I would recommend giving authority if possible and otherwise at least removing the edit button when the person does not actually have edit rights

It seems that a part of the educational pages is actually an /about page. Depending on preference, the edit button can be removed from templates or a Page can get an 'educational' tag/checkbox that allows the EC to edit them.


maint: Drop 3.9 support

@AlejandroFernandezLuces Seems like you need to update the jobs that need to pass for a PR to be merged. Seems like python 3.8 and 3.9 are currently expected to run on Linux. Removing them should do the trick !


More than one item to the page

Can I add more than one items to one page?

Sorry but it is not possible. Platform specific controls don't offer that option.

Thanks, your reply.


Refactor TemporalGraph and snapshotAtTime for Landy

The snapshotAtTime for Landy is currently failing

wtf,

wtf,

0 commits nice

Close for now as it is bugged and scuffed


Allowed types for registering Python functions are a different set from those allowed by RACO

I ran into this issue while trying to make a UDA work in MyriaL in a jupyter notebook. RACO expects either LONG_TYPE or DOUBLE_TYPE for numerical function results, but when registering a function it is possible to register it as FLOAT_TYPE and then RACO fails to understand the type, leading to TypeError: 'NoneType' object has no attribute '__getitem__'
It seems like there should be a warning when registering the function about the type not being valid or a better error output when the type checking fails while calling the UDF/UDA.
Here is an example that is based on the argMax TwitterK example from the myria docs:
from raco.types import LONG_TYPE
def pickBasedOnValue(tuplList):
    for tupl in tuplList:
        value1 = tupl[0]
        arg1 = tupl[1]
        value2 = tupl[2]
        arg2 = tupl[3]
        if (value1 >= value2):
            return arg1
        else:
            return arg2

MyriaPythonFunction(pickBasedOnValue, LONG_TYPE).register()

from raco.types import FLOAT_TYPE
def maxValue(tuplList):
    for tupl in tuplList:
        value1 = tupl[0]
        value2 = tupl[1]
        if (value1 >= value2):
            return value1
        else:
            return value2

MyriaPythonFunction(maxValue, FLOAT_TYPE).register()

%%query
uda argMaxAndMax(arg, val) {
    [-1 as argAcc, -1.0 as valAcc];

    [pickBasedOnValue(val, arg, valAcc, argAcc),
     maxValue(val, valAcc)];

    [argAcc, valAcc];
};
t = scan(cube300);
s = select argMaxAndMax(iOrder, vx) from t;
store(s, maxVX);

This throws the NoneType error, but using DOUBLE_TYPE instead for maxValue works.

This looks like a RACO issue to me.


Remove unused variable from BeDirectoryIterator::WalkDirsAndMatch()

topDirPrefix variable is not used in BeDirectoryIterator::WalkDirsAndMatch() static method and may be removed there.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/azp run imodel-native


Coding style

Coverage remained the same at 100.0% when pulling 47d55ea2d7551f5e4d99443d9ba2e0b9f79837d1 on fwininger:coding_style into 94ff17ac15eeffc81889fb0c2d54ee39588e166b on Cyberwatch:master.


Disable if not in git repo

During normal usage of quick files / scripts (not in a Git repo), I keep getting the following warning, which I've just accepted for a very long time:
[cmp-git] [WARN  02:19:24] ...pack/packer/start/cmp-git/lua/cmp_git/sources/github.lua:209: Can't fetch Github issues or pull requests, not a github repository
However, upon closer investigation of the source code, it seems that this GitHub source check can be avoided if we ignore completion inside non-Git repositories.

Thanks!


Stuck on "activating" while deploying an item from the catalog on a swarm environment

Rancher Version: v1.0.0
Steps to Reproduce: Create a ghost blog or a wordpress from the catalog
Results: stuck on "activating" in the project tab of a swarm environment
Expected: a working ghost blog and a working wordpress stack

Did you get a host working in your environment as I see you filed #4246

Yes I have 2 hosts running on local servers on which I'm able to run containers but not deploying an item from the catalog.

Hi @aieeeeeeeee, I am unable to reproduce without more information.
Under INFRASTRUCTURE > HOSTS, are any hosts listed as ACTIVE? Assuming there are, you should see a Swarm stack with at least one swarm agent, and it should be running. If these requirements are satisfied, you should have a healthy swarm environment.
Next, when you deploy the project and it enters the "activating" state, are any containers actually launched? If you could post the swarm agent log and any other details, it would be helpful.

Hi @LLParse.
Yes I have 2 hosts that are Active and the following containers are running (on top of any "dummy" container that I have created to check that deploying a container was ok):
Host 1:

swarm_swarm_1
Network agent

Host 2:

Swarm_swarm-agent_1
Network agent

While in the activating state no container has been launched.
Here is the only logging information that I have while running a docker logs on the agent container:

time="2016-04-02T02:11:01Z" level=info msg="Listening for health checks on <IP_ADDRESS>:10240/healthcheck"
time="2016-04-02T02:11:01Z" level=info msg="Initializing event router" workerCount=50
time="2016-04-02T02:11:02Z" level=info msg="Connection established"

For the any other details, except telling you that the hosts are VMs running on an Hyper-V environment local to my company and on-premise, that these VMs are running Debian 8 with the latest Docker version (see quote below), I'm running out of info that I could share to help you:

Client:
Version:      1.10.3
API version:  1.22
Go version:   go1.5.3
Git commit:   20f81dd
Built:        Thu Mar 10 15:38:58 2016
OS/Arch:      linux/amd64
Server:
Version:      1.10.3
API version:  1.22
Go version:   go1.5.3
Git commit:   20f81dd
Built:        Thu Mar 10 15:38:58 2016
OS/Arch:      linux/amd64

Thanks for your support !

Do your hosts have cross host communication actually working? Have you opened up UDP ports 500 and 4500? If you exec into the network agent on one host, can you ping the IP of the other network agent (10.42.x.x)?
http://docs.rancher.com/rancher/faqs/#cross-host-communication

@aieeeeeeeee If you could confirm if your cross host communication is working in your setup and are still having issues, please re-open.

@deniseschannon Yep I confirm that the issue can be closed since everything now behaves as expected! Thanks again for your support!


Tile Server supports Google maps

https://mt1.google.cn/maps/vt?lyrs=s&hl=zh-CN&gl=CN&x=0&y=0&z=0

Was closed accidentally because target branch was merged and deleted.

@zengweicheng666, I'm closing this because our satellite system is nearly running using the slippy coordinate conventions.


change raw config assets type

Closes https://github.com/python-semantic-release/python-semantic-release/issues/602
Also do we have an ETA of 8.0 release?

Same issue here, any eta for this fix being released?


How to access the current item being mapped .As()?

I am running into somewhat of a complex problem with the As() extension method. Before I move forward to explain the issue I am going to list a small dictionary of terms I will be using throughout this ticket:

Article - Document Type Composition for Article DocType
Article DocType - Self explanatory - Uses Article Composition
PageConverter - Generic TypeConverter I created that will return a particular content item from a passed ID.
HeaderConverter - TypeConverter that will return either the header property or node name (on current context's assigned content item).

Now the problem:
I have a page (one of our typical document types) that contains an Archetype called ArticlesBanner. This ArticlesBanner has the following function:
On the left side of the banner, it will show a summary set on the Archetype, as well as breadcrumbs leading up to the current page that the Archetype is on, as well as the header of the current page. On the right side of the banner, it will show the header, summary, and category of an Article page that is picked with a multinode treepicker The code for this banner looks like this:
    /// <summary>
    /// The articles banner widget.
    /// </summary>
    [ArchetypeContent(alias: "articlesBanner")]
    public class ArticlesBanner: IWidget
    {

        #region Properties

        /// <summary>
        /// The banner's header (override optional).
        /// </summary>
        [TypeConverter(typeof(HeaderConverter))]
        public string Header { get; set; }

        /// <summary>
        /// The banner's summary.
        /// </summary>
        public string Summary { get; set; }

        /// <summary>
        /// The banner's breadcrumbs.
        /// </summary>
        [ArchetypeProperty(alias: "labelIgnored")] // Random property so that ditto knows to map it
        [TypeConverter(typeof(BreadcrumbConverter))]
        public List<Link> Breadcrumbs { get; set; }

        /// <summary>
        /// The banner's picked article details
        /// </summary>
        [ArchetypeProperty(alias: "article")]
        [TypeConverter(typeof(PageConverter<Article>))]
        public Article Article { get; set; }

        #endregion

    }

The Article class (Article.cs) holds the details for the Article Composition. It looks like this:
    /// <summary>
    /// Article details for article pages.
    /// </summary>
    public class Article
    {

        #region Properties

        /// <summary>
        /// The header of the article page.
        /// </summary>
        /* ISSUE: Return header from specified ID because Ditto is mapping calling page header
        rather than the called page header (via picker)*/
        [UmbracoProperty(propertyName: "id")]
        [TypeConverter(typeof (HeaderConverter))]
        public string Header { get; set; }

        /// <summary>
        /// The summary of the article page.
        /// </summary>
        public string Summary { get; set; }

        /// <summary>
        /// The parent article's author.
        /// </summary>
        [TypeConverter(typeof(PageConverter<Author>))]
        public Author Author { get; set; }

        /// <summary>
        /// The parent articles's release date.
        /// </summary>
        public DateTime ReleaseDate { get; set; }

        /// <summary>
        /// The URL of the article page.
        /// </summary>
        public string URL { get; set; }

        /// <summary>
        /// The categories of the article page.
        /// </summary>
        [TypeConverter(typeof(PrevalueCSVConverter))]
        public List<string> Categories { get; set; }

        #endregion

    }

If you see on the Article, I am using [UmbracoProperty(propertyName: "id")]. This is because the behavior I am experiencing is that the value I get back from from this code (Inside HeaderConverter):
var node = UmbracoContext.Current.PublishedContentRequest.PublishedContent;

is the the origin content (typical page), and not the content of Article page that I have picked in multinode treepicker (where it should be mapping to using .As<Article>() inside of my PageConverter):
        /// <summary>
        /// Returns TPage from ID.
        /// </summary>
        /// <returns></returns>
        public override object ConvertFrom(ITypeDescriptorContext context,
            CultureInfo culture, object value)
        {

            // Return <T>Page
            if (value != null) {
                // Helper method to return UmbracoHelper
                var content = Rhythm.Extensions.Helpers.ContentHelper.GetHelper().TypedContent(Int32.Parse((string)value));
                return content.As<T>();
            }

            return null;
        }

So It seems to me that the mapper doesn't change the context's current content (either by UmbracoHelper.AssignedContentItem or PublishedContentRequest.PublishedContent) when mapping referenced types through content pickers.
Because this is the case, how can I get access the current item that is mapping from a TypeConverter?

HI @LoganLehman
In v0.8x, there is an undocumented feature in which we add in a custom ITypeDescriptorContext implementation to TypeConverters that are used by Ditto.  The Instance property on that context is the current node that is being mapped.
Try this code...
var dittoCtx = (DittoTypeConverterContext)context;
var content = (IPublishedContent)dittoCtx.Instance;

An alternative way to do this is instead of using [UmbracoProperty(propertyName: "id")], to get the ID handle that in the TypeConverter, try using the [CurrentContentAs] attribute.  This will pass the current content node back to Ditto for further mapping.
I hope this helps.
Cheers, Lee.

@LoganLehman Out of curiosity, what is this line of code for?
[ArchetypeProperty(alias: "labelIgnored")] // Random property so that ditto knows to map it

Thanks so much for the help! I actually noticed that [CurrentContentAs] did pass the "header" property, but because I am defaulting to the node name if "header" doesn't have a value, it did not work because I was not able to access the mapping node, only the node in the current context. Now that I am able to access the mapping node, I can use CurrentContentAs instead of the id.
In regards to your second question, it is a Ditto.Resolvers ArchetypeProperty attribute (which I am assuming you know about since it is an extension off of Ditto). "labelIgnored" actually just acts as a BackOffice label for the Archetype.
I was actually going to submit a separate ticket for it, but because you asked:
Because Breadcrumbs doesn't exist in the Archetype to begin with, I had to add that attribute to force the TypeConverter to run. I believe this is truly just an architecture decision on the team lead's end because he wants all the heavy lifting to occur in a TypeConverter. It would make sense that if the property exists only in the POCO/Model, and not in Umbraco, that it would not even think about running the TypeConverter because it won't have a value to convert from. So essentially, we are converting from nothing to something (with a trick).
If there is a way to do this in Ditto without doing this, that would be cool. Either way, we are just trying to stay away from View logic as much as possible.

@LoganLehman Thanks for the explanation, I can understand the reason.
An alternative approach is to use the conversion-handlers, specifically the [DittoOnConverted] attribute, (unfortunately our documentation for these is desperately lacking at the moment - sorry) .. for an example, take a look at our unit-test: ConversionHandlerTests.cs
Cheers, Lee.


Distribution

Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

Any idea what the DB access exception is about?

Any idea what the DB access exception is about?

Yeah - it means the db is not yet active. We've been seeing it a few times in the last week.

Any idea what the DB access exception is about?

Yeah - it means the db is not yet active. We've been seeing it a few times in the last week.

I’ve tried restarting it about 3-4 times with no luck.


Support rep_delay

Summary
Many users have asked for the ability to specify a rep_delay, which is already supported on the server side. This PR officially adds that support.
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 59.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.008%

Covered Lines:
3197

Relevant Lines:
5394

💛  - Coveralls

Is this something we still want to add? Don't want this PR to get too stale/forgotten

It's already stale. We are deprecating V1 primitive in about a week, so there is really no point making updates.


Atlas code quite convoluted

And broken: in atlas.out, we get only a part of the Atlas actions (it works if done by hand in the shell, or if run with sh -x but not otherwise).

Cannot reproduce it, closed.


Python Agents - Mark assistant object in samples with metadata

Estefania suggested we use meta-data to identify assistant artifacts that may need clean-up.  I've done this for .NET in https://github.com/microsoft/semantic-kernel/pull/7126 using the sksample key.
Be good to do in Python samples also

Re-opening as work is not complete.


feat(config): allow usage of env vars to set config

This means we can change configuration by environment variables at runtime.
An example with docker:
docker run ghcr.io/beckn/bap-client --env DATABASE_URL=mongdb://localhost:27017

Done!


Improve Google Sheets upload

Fixes #2760 along with a variety of problems that I found when testing fixes for it and fixes #2306..

upload in chunks instead of serializing the entire document at once
Free up resources as we go
stop if an error occurs
reduce batch size to try and stay in 10MB request size limit
(but need a more dynamic way to do this probably for very wide
sheets or sheets with large values)
preserves cell data type on upload - fixes #2785.

I'll open issues for some of the other things. The whole thing is kind of a mess.

Nice! It would be good to try to separate the actual upload part from the generation of the java beans that represent the table in Google's format, so that this generation can be more easily tested.

It would be good to try to separate the actual upload part from the generation of the java beans that represent the table in Google's format, so that this generation can be more easily tested.

@wetneb Do you have any good ideas on how to do this? The first thing that comes to mind is building the batches and then serializing them using toString() or something to make sure that they are expected, but that's effectively testing the Google client as much or more as our code and would need to be updated with client serialization changes, which I don't think we want to do.

@tfmorris I would expect the Google library to properly implement equals on its datamodel objects, so that you can check for equality between the generated document and the expected one, no? I do not think this should rely on any serialization or toString.

@wetneb https://github.com/OpenRefine/OpenRefine/pull/2784/commits/1f6885cb5fa1abbea8b332e2af9b7d5538f11f2f includes a testability refactoring to allow some minimal tests and https://github.com/OpenRefine/OpenRefine/pull/2784/commits/64cf9858f215243b93fb0434b6ba06ac41cdb856 builds on that to test the cell data types.
Untested is all the code associated with uploading rows multiple times, resource exhaustion, etc which would require integration tests.

Thanks, I will try to have a good look tomorrow!

@tfmorris you added the relevant issues to the 3.4 milestone - did you mean to do it for 3.5 instead? Since this is a pretty significant refactoring and these bugs were not recent regressions, I would go for 3.5 by default.

@wetneb Yes, the 3.4 milestone was intentional. The current code doesn't work for any spreadsheet with empty cells, doesn't work for more than 26 columns, doesn't work for more than 1000 rows, doesn't work for non-string cell types (willing to concede that this last is non-critical). Leaving aside the fact that someone (Google?) apparently paid for this work and probably wants it in a usable state, how much worse could this Pull Request make it?
The less-than-26x1000-string-only corner of the universe that worked before shouldn't be that hard to validate if that's a serious concern.

how much worse could this Pull Request make it

You got a point here :-D
Adding it to 3.4

@tfmorris: I'm trying to test (master, tfmorris:google-sheets-cleanup branch, etc) and it's not working.
Any insight you could give me?
Regards,
Antoine

I'm trying to test (master, tfmorris:google-sheets-cleanup branch, etc) and it's not working.

@antoine2711 Thanks for helping test. master was broken until #2828 was merged about an hour ago, but should be OK now.
None of my branches need testing, but please test the 3.4 branch (especially) -- and master if you have time. Check to make sure that the bugs that you reported are fixed and that I haven't broken anything else in the process.
Thank you!

I'm trying to test (master, tfmorris:google-sheets-cleanup branch, etc) and it's not working.

@antoine2711 Thanks for helping test. master was broken until #2828 was merged about an hour ago, but should be OK now.

Well, I just pulled master from OpenRefine/OpenRefine, and I still have a gSheets file that exports NOTHING (but create an empty gSheet file). What should I do? I would love to download v3.4b2, but it's not there.
Regards,
Antoine

Hi @tfmorris

None of my branches need testing, but please test the 3.4 branch (especially) -- and master if you have time. Check to make sure that the bugs that you reported are fixed and that I haven't broken anything else in the process.

An OR column with date or number type do not get exported. Row count & column count are OK. This is with v3.4 [4f501af].
Regards,
Antoine


Refactor of the code

I think this could be a slightly better code

Sorry, I didn't notice you had made a PR. You should also remove unused imports, there should be a plugin for Eclipse for that.

A general suggestion: If you make a new method, you could add a Python doc comment under it to say that it was made by you. At the moment it's difficult for me to say whats mine and whats yours, especially for stuff in core.

In these days I've already fixed some of these problems, for the choose regressor it's not needed in core because the model is created in training and core module simply takes the model from the database.
Now i'm trying to squash the migrations.
I discovered that i need to change the predmodel model because it's not good right now, so I think that it's better to wait to merge this PR. When i'll finish with predmodels I'll let you know.
For the comment in new method i'll do from now on, by the way I think I have changed like, everything.

I can't deploy the back-end to UT servers because the master version is broken. Please do a check of the end-to-end training tasks and fix it.
11:54:02 TypeError: prediction() missing 1 required positional argument: 'model'
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/rq/worker.py", line 789, in perform_job
    rv = job.perform()
  File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 573, in perform
    self._result = self._execute()
  File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 579, in _execute
    return self.func(*self.args, **self.kwargs)
TypeError: prediction() missing 1 required positional argument: 'model'
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/rq/worker.py", line 789, in perform_job
    rv = job.perform()
  File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 573, in perform
    self._result = self._execute()
  File "/usr/local/lib/python3.5/dist-packages/rq/job.py", line 579, in _execute
    return self.func(*self.args, **self.kwargs)
TypeError: prediction() missing 1 required positional argument: 'model'

Try now if it works fine or not and let me know

I don't have the time at the moment to check out your repo and install everything. Frankly, you caused the bug and you have to fix it.
Start the webserver and start the rqworker. Use the curl in the README to see if the task is working correctly. If you don't know how to use that then start the front-end and use the some random training options.

I have added you as collaborator to this and the front-end project. For development I'd like you to make a branch and then create a PR so I can see it. This is so we don't have a million repositories with the same code. And all the automated testing is on this repo.
Please don't directly commit stuff to the master branch 😄
At the end, when you have to submit your thesis, you can make a fork.

Wait a moment. I didn't ask you to solve the problem I caused , but simply have a feedback if I fixed it right or not, by the way I think I fixed it, because It works fine on my computer. Sorry if my previous message wasn't clear.
At the moment i'm rewriting the code to work fine wih the new structure of PredModel

Ok sorry, if it works then I'd like to merge it so I could deploy it today. Or do you have any more refactoring you want to do here?

I think that for now you can merge it.


Improve keyboard handling

Uniformly manage all keyboards accordingly to their localization.
A (partial) implementation can be found in PR #568, however:

Its purpose is to be a workaround for the ones in need of scancodes support before the official implementation. And I would be glad if it could help the SFML devs during the creation of the official implementation as well.

For the record, I am working on this. :construction_worker:

Shouldn't we first decide the shape of the API? BTW, there was a rather long discussion about that issue somewhere on the forum that unfortunately stalled. Maybe we should restart from there?

there was a rather long discussion about that issue somewhere on the forum that unfortunately stalled. Maybe we should restart from there?

http://en.sfml-dev.org/forums/index.php?topic=13692.msg95809#msg95809
Have at it, I'm working on a practical implementation that will do what it is supposed to do. Once we get something that works we can discuss the API and adapt as needed. The trouble isn't deciding on an API, but getting something that works.
I for one am not up for another long discussion, we already had it and you can read that thread above and all the other threads where stuff has been proposed, the outcome can just about in every case be summed up below.
I have looked at many other libs and how they handle keyboard keys (not talking text input here as what we have works just fine) and they all have several things in common.

Physical Key (mapped from OS value to the lib value)
Virtual Key (mapped from OS VK value to lib value) - this is what we have right now
Modifier Keys (which we already do)

The plan right now is to do the physical key mapping, then fix our current virtual mapping (add missing keys).

It's nice to have a working implementation as proof-of-concept, but if the API is not thoroughly discussed beforehand, you have to take into account that major changes may be necessary. Same for the mask feature, by the way. We don't want you to waste a lot of effort on something that may in the end not be accepted, as rewriting things again and again can be very frustrating...
Furthermore, I think defining an API as soon as user requirements are known is often a good idea. The API is a user interface and should thus be user-driven, not developer-driven -- the priority is usability, not ease of implementation. Of course there are sometimes implementation details that dictate the API, but it should not be the default approach.

you have to take into account that major changes may be necessary.

Some people might be willing to take that risk :grin:. If you ask me, it's not for us to decide how they spend their time. If they had fun writing the draft that gets overhauled anyway, there really isn't any loss for anyone.

We don't want you to waste a lot of effort on something that may in the end not be accepted, as rewriting things again and again can be very frustrating...

Well, some implementation will ultimately get accepted, and if it is even remotely derived from an initial draft or just uses it as inspiration, it will not have been in vain. Getting lost in months of discussions without any substance behind them can be more frustrating than having to write a bit of new code every time a new idea pops up.

Furthermore, I think defining an API as soon as user requirements are known is often a good idea.

This is assuming we will ever have a good idea about user requirements. I don't like having such dependent development. If you ask me, showing people something that they can try out in a sandbox project will provide us with more information than a simple "what do you think of this discussion?" approach. It obviously hasn't worked for us since this issue is still unresolved even after this amount of discussion.
Everybody should know by now that the waterfall model is busted, and blocking possible parallel work on a draft implementation waiting on such discussions is nothing other than adhering to that model. If we determine that requirements are going to change during the discussions than we should always be able to tweak the draft without too much effort, and this isn't even an issue for us if you ask me.
All we need is "something to talk about" and that something is not an abstract mental model, but something we can send to users and ask them for feedback about, since as you said, the API should be user-driven.

That's true indeed. As mentioned, a proof-of-concept is definitely helpful. I just thought I'd state such a warning so that people are prepared ;)
One problem with our discussions is -- besides the coexistence of multiple ones about the same topic -- that we start them, discontinue them at some point, and next time we want to work on the feature, everything has been forgotten and needs to be extracted anew from heaps of posts. For larger feature changes, it might thus be good to write a Wiki document that summarizes important considerations and presents different implementation possibilities with their trade-offs.

you have to take into account that major changes may be necessary.

You have to consider we are talking keyboard handling here, not more theory that major changes may have to be done to a general PR that implements some wide open feature. As I said above, all major libs handle it the way I am working to implement something. So unless we all agree on something that makes no sense there won't be any major changes.

I think defining an API as soon as user requirements are known is often a good idea.

As I also said, I have gone through just about all of the threads requesting better keyboard handling. I have a fairly good idea what people have requested.

the priority is usability, not ease of implementation.

Yes of course, the current implementation was easy - not much thought given ease of use and multiple keyboard layouts. Trying to be smart and mix virtual key codes and scan codes has given us the current API when it is clear from looking at other implementations it doesn't work out - especially when it comes to handling localizations.
Another thing to think about with this model of don't implement it until we decide is simply won't work. It is impossible to satisfy everybody 100% with every design. There always is going to be drawbacks, it eventually gets to the point where you just need to "suck it up" and go with it. And stalling a merge until we get feedback is fine, but it gets to a point when people could care less and don't bother commenting on anything but in master. So waiting until we get feedback will block forever since feedback won't happen until it is in master and they are basically forced to give usage feedback. Its a sad fact, but that's the way it is.
You all should know me, I love discussing and finding the best design for something and I also don't mind changing something if I found a better way to do it. But at one point you need to end the discussion and just make something work. That is why I have gone ahead and implemented the clipping masks and text outlines.

Personally I like this attitude (and so far, I also like how you do it), this is probably this only way to make these prehistoric issues progress. And I know that you'll be able to deal with whatever we'll do to your PRs, as frustrating as it may be (or not) ;)
:+1:

Those are indeed valid points! Let's see what you'll come up with. :wink:

For posterity reference, ISO/IEC already defined a physical reference grid for keyboards as can be seen here.

The keyboard handling has massively been improved by handling scancodes with #1235
As such, I'll close this issue. Further discussions on expanding the non-scancode key codes can be held over at #1045


DEVICE_GROUP_NOT_FOUND with MQTT measure

Related: https://github.com/telefonicaid/iotagent-ul/issues/320
For the Ultralight IoT agent, in the previous release 1.7 if an MQTT measure arrived , when the flow of the code looked for a service group resource was ignored. Therefore the tutorial (setting the resource to blank) was fine when run against 1.7. The behaviour of the iot agent has changed for current release 1.8 and I can't see where the change has been documented, so maybe this is unexpected behaviour.
Either way it is fair to say that the current tutorial doesn't work with the current IoT Agent and one of them (or both) needs to be fixed.

Getting the issue too :(

As of v 1.11.0, the old functionality has been reacquired. Tutorial now working against latest versions of enablers


[SPARK-21181] Release byteBuffers to suppress netty error messages

What changes were proposed in this pull request?
We are explicitly calling release on the byteBuf's used to encode the string to Base64 to suppress the memory leak error message reported by netty. This is to make it less confusing for the user.
Changes proposed in this fix
By explicitly invoking release on the byteBuf's we are decrement the internal reference counts for the wrappedByteBuf's. Now, when the GC kicks in, these would be reclaimed as before, just that netty wouldn't report any memory leak error messages as the internal ref. counts are now 0.
How was this patch tested?
Ran a few spark-applications and examined the logs. The error message no longer appears.
Original PR was opened against branch-2.1 => https://github.com/apache/spark/pull/18392

Test build #78532 has started for PR 18407 at commit 51967c8.

Test build #78534 has started for PR 18407 at commit d0ced9f.

Test build #78532 has finished for PR 18407 at commit 51967c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78532/
Test PASSed.

LGTM. Merging to master / 2.2 / 2.1.

Thanks @vanzin

Test build #78534 has finished for PR 18407 at commit d0ced9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78534/
Test PASSed.


Repository for creating nixos-images

@arianvp and me want to have a new repository for creating NixOS images.
Reason is that cache.nixos.org has a lot of images that no one will have download.
It saves costs, when we build these images outside of hydra.

cc @Lassulus

Proposed name would just be images

I'd eventually plan to merge https://GitHub.com/NixOS/amis into this new repo

done: https://github.com/NixOS/images


Github Action: Generate and add "release notes" when distributing new builds on Firebase (staging and production)

Why
Currently, the template supports existing CD workflows to distribute new builds to Firebase. There is a space for improvement to have release notes on each build to clarify what is being covered with the new update for the PM and testers instead of showing the default release notes.
Solution: available solutions from TPC

after merging a PR to develop:
echo "RELEASE_NOTE_CONTENT="$((git log -1 --merges | grep "\[") | grep . && echo "" || echo $(git log -1 --merges --format=%B))""

after merging a release PR to main
echo "RELEASE_NOTE_CONTENT="$(git log --merges --pretty=%B $(git describe --abbrev=0 --tags)..HEAD | grep "\[")""

Who Benefits?
PM and Testers

@luongvo @ryan-conway Let me update the title of this issue for Github action. I'll add more similar to this for Codemagic. 🙏

@lydiasama Since I handled this in the new project, in case you haven't started working on this so would you mind if I handle this for template updates? 😄

@hoangnguyen92dn Sure thing. Thank you. 🙏🏻

@hoangnguyen92dn @lydiasama You can consider using https://github.com/mikepenz/release-changelog-builder-action to generate the changelog for release notes on develop and main branches here https://github.com/nimblehq/flutter-templates/pull/270.


MSB3246 should say which file

https://github.com/Microsoft/msbuild/blob/a8fba1ebd7b10ea68fcbdb8144a31496f8c37ce7/src/Tasks/Resources/Strings.resx#L1423-L1424
logged from
https://github.com/Microsoft/msbuild/blob/a8fba1ebd7b10ea68fcbdb8144a31496f8c37ce7/src/Tasks/AssemblyDependency/ResolveAssemblyReference.cs#L1523-L1528
Doesn't name a file, so you have to dig through more information to do anything about it.
Looks like everything in that block should list the reference in its error.

fyi / other context - since @shanselman also found my SO answer while researching this live on youtube (https://stackoverflow.com/questions/48122173/warning-when-using-nuget-package-that-contains-native-dll)
This also happens when native DLLs are shipped in NuGet packages since AFAIK Core MSBuild uses different APIs (?) to inspect DLLs and thus complains on native DLLs that are placed inside NuGet lib/ folders instead of runtime/ folders.
NuGet packages did this before netstandard/netcoreapp to ship native DLLs (e.g. sql drivers, things like zeromq libs etc.). When NuGet introduced the asset target fallback to net* assemblies, this started happening a lot more.
Would be good to know which package is responsible from the error message.


[Crash reports] Add Security & Privacy Self-Review Questionnaire

This PR includes the completed Security & Privacy self-review questionnaire as per the requirement of the Chrome Entry. The questionnaire addresses various aspects of the feature, including the exposure of information, handling of sensitive data, persistence of state, interaction with the underlying platform, and more.
The questionnaire is designed to ensure that all security and privacy considerations are thoroughly reviewed and addressed. It follows the format provided by the W3C: https://www.w3.org/TR/security-privacy-questionnaire/
The responses in the questionnaire provide a comprehensive overview of how the feature interacts with user data and the browser environment.

@dandclark I'm not able to add reviewers, do you know if there is a way to fix that (unless it's intentional)?

Hi @issackjohn, looks like the ability to add reviewers is tied to write access in this repo. For now I recommend just tagging anyone you'd like to review.

@sethbrenith @aluhrs13 @dandclark PTAL. 🙂

@dandclark You may land this PR. Thanks!


Add link to featericon-rails and featericon-sass on README

:snowflake::snowflake::snowflake: Add link to featericon-rails and featericon-sass project on README :snowflake::snowflake::snowflake:

@syokenz Thanks!! :1st_place_medal:


Merge pull request #1 from Tencent/develop

merge develop

?

fix: checkbox css up

checkbox 样式更新


Add missing paren in lsp invocation on terraform/config

Original change introduced in https://github.com/hlissner/doom-emacs/commit/9b620c3b59944881d9111936b5d464969777bb11

Duplicate of #2562


armv7-m irq: initialize mask to avoid compiler warning/error

Backport of https://github.com/apache/nuttx/pull/8856
Don't merge before it's in upstream NuttX.

Updated with suggestions from the original upstream pr:
https://github.com/PX4/NuttX/compare/bbdbb6dc14f4924f6d6df894b8eb192eda845a1b..1dd79b5d2f6649736ce6bb10a33b7ac24c0f9efd

@MaEtUgR Please do a PX4 PR to test this branch. Then after it is merged repoint it.

@MaEtUgR Upstream has been merged

Upstream has been merged

Thank you @davids5 !

PX4 PR to test this branch

@davids5 I have that here: https://github.com/PX4/PX4-Autopilot/pull/21340

Note that it brings in other backport commits from this repository:

Note that it brings in 3 other backport commits from this repository by updating to the state of this pr:

I think the 3 extra are Kconfig defaulted to current and should have no effect.
But let's test that!
After the release @dagar wanted to bring in the PX4 PR that enables them.

After the release @dagar wanted to bring in the PX4 PR that enables them.

I was targeting the release to build on GCC 12 :innocent:  I'll check with him thanks :pray:

@davids5 Any chance we could get this backport in now? The release is out and I'd still like to enable GCC 12 support. I'm updating the PX4 pr now as preparation.

Thank you :pray: I'm updating and testing.


'cURL error 7: Failed to connect to study.uproom.net port 9090: Connection timed out

I am getting this error, when running my code on shared server
with no result displaying at all
whereas everything working fine over my laptop local xamp and producing correct results.
Please help me ,what could be the issue?
Thanks

is your openfire working correctly on that address and port?

As i told earlier, it is working fine and giving my openfire data
when running the code on my laptop XAMP server as local host
But i have tested it on more than 3 shared server now, it is not giving me anything.


parser: shrink the size of WithSpan to one register

To be rebased after https://github.com/rinja-rs/rinja/pull/214 is merged.

Oh, I did not expect a fuzzer error, but it makes me happy that it is actually working!

Offset::offset_to only accepts slices of self

Oops, I should have read the documentation of the method more properly. :)

Well, the changes in the parser are not too big. No reason to wait.

You even added the fuzzing error, nice!

Well, the changes in the parser are not too big.

As the reviewer, I disagree. :p

Please merge once fuzzer passed.


No artifacts section for Windows

the readme states:

Prebuilt binaries can be downloaded from the artifacts section of appveyor.

https://github.com/jwilm/alacritty/blob/master/README.md#windows
When I nav to the link provided there's no artifacts section to download.
Can you please include the pre-build windows binaries into the releases section of github?

The artifacts are available under the last successful build job on appveyor.

I see that now. Thanks

Note that github releases will be available with #1329.


Gardener components no longer use admin kubeconfig for local garden dev setup

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Today, all Gardener components are using the admin kubeconfig for the local garden development setup. This has the downside that the RBAC rules which we maintain in
Which issue(s) this PR fixes:
Softly related to #1723 and #1724.
Special notes for your reviewer:
/squash
Release note:

When using the local garden development environment, the Gardener components do now use dedicated kubeconfigs constrained by RBAC rules (earlier, they were always using the admin kubeconfig).

@vpnachev - an idea as follow-up of this PR to also make the gardenlet use the RBAC privileges in the seed that you plan to apply with #3763:
In https://github.com/gardener/gardener/blob/master/hack/local-development/start-gardenlet,

create a ServiceAccount in the garden namespace of all the seed clusters (by reading all Seeds and using the kubeconfig referenced by .spec.secretRef)
apply the RBAC resources for the gardenlet in the seeds
create a new, temporary kubeconfig which uses the token of the ServiceAccount created in 1.
update the kubeconfig in the .spec.secretRef of the various seeds

It might have drawbacks, just brain-storming here. WDYT?

@vpnachev - an idea as follow-up of this PR to also make the gardenlet use the RBAC privileges in the seed that you plan to apply with #3763:
In https://github.com/gardener/gardener/blob/master/hack/local-development/start-gardenlet,
1. create a `ServiceAccount` in the `garden` namespace of all the seed clusters (by reading all `Seed`s and using the kubeconfig referenced by `.spec.secretRef`)

2. apply the RBAC resources for the gardenlet in the seeds

3. create a new, temporary kubeconfig which uses the token of the `ServiceAccount` created in 1.

4. update the kubeconfig in the `.spec.secretRef` of the various seeds

It might have drawbacks, just brain-storming here. WDYT?

Thanks for the suggestion! However, I am still thinking that it should be as it is today. Why

A new seed can be added at any time and gardenlet will use the configured kubeconfig. On restart of gardenlet, it will create the service account and bound the (cluster)roles to it. This can lead to authorization issues if new permissions are required, or if the seed is deleted with no restart of gardenlet such missing permissions will not be detected.
It still possible to run gardenlet remotely in productive landscapes with the whatever kubeconfig is configured by the landscape administrator. Should we implement such automation in this case - I think no. It would be a bit weird gardenlet to amend externally configured kubeconfig.

For now I will not add anything like this in #3763 as it has been prolonged too much and a lot of conflicts needs to be resolved. Such automation can be contributed later, if we find a suitable solution.

@vpnachev My recommendation was only for the local development environment. Of course, in production code we should not have anything like this. I just think we should find a way to make sure to detect issues in the gardenlet's RBAC rules already when developing locally. We don't have to follow above approach (it was just some short brain-storming/food for thought), and we don't have to do anything now with #3763, but I think we should eventually have some solution for it.

/assign


Add RTL support to component

Hello my friend thanks for your contribute.
I will review your commit carefully, after that i merge this pull request.
Sorry for my delay.


Issue whilst running

Terminal Logs
Write spam text : 3
python discord_text_spam.py '3'
Traceback (most recent call last):
File "start.py", line 36, in
p = subprocess.Popen('python discord_text_spam.py ' + token + " "+'"'+spam_text+'"')
File "/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 707, in init
restore_signals, start_new_session)
File "/usr/local/Cellar/python3/3.6.1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 1326, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'python discord_text_spam.py USERTOKEN "3"'

BTW running on OS X

Weird,  I'll try it when I get home.
Also you left your usertoken in the log before 😬 I edited it and removed it for you.

Oh, is it only the text spammer or all of them?

I haven't tried others, but tbh just wanted the text spam, also thanks lol

Alright, I updated the 'start.py' code. Let me know if it fixed it

Still doesn't work, Im also a beginner with python and I tried messing with the input, couldn't fix it.
File "/Users/Kasra/Desktop/discord-spam-bots-master/start.py", line 34, in
spam_text = (input("Write spam text : "))
File "", line 1, in
NameError: name 'test' is not defined

Alright replace line #37 with
        p = subprocess.Popen(['python','discord_text_spam.py',token,spam_text],shell=True)

let me if that works.