Nativescript 7.x compatibility

Hi,
this PR updates the plugin by following the guidelines reported in this blog post, fixes the #422  issue (markers not showing), plus some other minor code improvements.
Cheers

Some updates: unfortunately I'm not in touch yet with NS team, new commits are including the fix for the problem reported in the last message.
There are still issues with WeakRef at runtime though, it needs further investigation.

Problem fixed! Successfully loaded the map in a nativescript v6 application! (tested on android only)

I had an issue with markers not showing on the map. Apparently this is happening because the nativeView is cleared after initialization (disposeNativeView() method is called in the wrong moment?).
By looking at nativescript/core view management, seems that some changes have been introduced in the view lifecycle, so this needs to fixed before closing the PR!
In fact I started this migration due to this problem, people using the last released version will not see markers if they update to {N}6

Sadly I can't show the markers even with this PR.

@flocca this PR is not fixing the marker problem actually, it was more a generic update of dependencies and so on.
I thought that they were not showing due to the plugin dependencies not being up to date. In fact the source of the problem is in the code (nativescript is handling the view life-cycle differently, so the plugin is getting null instead of the map-view reference: it cannot load the markers).
The fix was not pushed because it wasn't fully tested, but now more than a month is passed without any problem, so if you can wait until this afternoon I'll push the update.
Cheers,
Federico

@flocca I've just pushed the fix, it includes nativescript@7 support, plus other stuff, now I'm closing so I didn't have time to test it in a project, btw the fix is well documented in map-view.android.ts. Tomorrow morning I'll do a full test to check if everything is working properly.
In case that there are no problems, I will also try to make it compatible with Angular 10.
Cheers ;)

Thanks for all your work @funder7.  Sorry I've been slow to respond, I'll take a look this week to get it merged.  Let me know how the full test goes.  Are there any updates needed for the demo apps?

Hello @dapriett, nice to hear something from you!  :-)
I'm updating the demo projects now...it's a very long job to do, I don't know if it's me or the latest releases of {N} libraries, but I have to admit that it's really frustrating when the app doesn't work, it takes a long time to find the source of the errors (console messages are not very explanatory :/)
Unfortunately I can work on this only during the weekends, I hope that the fix released yesterday is working in the meanwhile for who wants to use that revision... I used it in a personal application, so it fixes the markers problem for sure....but experience tells that with nativescript, once you change a dependency the game starts again :-)

Heya just wondered if there is an ETA for release of this to get this working? Thank you so much for the work

Sorry @liamcharmer  I'm a bit busy in these days. In fact the code is ok, if you want you can clone this branch and build the plugin on your computer, then link it in your package.json (instructions here).
It's not that hard, just go into the src folder, then npm run build, finally in the root folder there's a publish where you need to exec ./pack.sh script.
Now there will be a new publish/package folder, inside of it you can find the plugin pack that must be linked into your app package.json.
Hope this helps in the meanwhile that the work will be done.

@funder7 Don't say sorry at all! Thank you so much for the amazing hard work! I'm a bit useless wit this type of stuff but your instructions have been perfect. I'll let you know what bugs i come across if i do come across any

When I run exec pack.sh in the publish folder it does seem to crash the terminal for some strange reason. Will look into

When I run exec pack.sh in the publish folder it does seem to crash the terminal for some strange reason. Will look into

Before you need to run npm install in that folder too! I forgot that :-)
Ok thanks for keeping an eye on it!

When I run exec pack.sh in the publish folder it does seem to crash the terminal for some strange reason. Will look into

I was being silly i was running exec pack.sh not sh pack.sh

Implemented with Vue.js NativeScript 7, still get the same error
CONSOLE LOG: TypeError: Class constructor View cannot be invoked without 'new'```

@funder7
Seems to occur when running the app via ns run
(CoreFoundation) *** Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Uncaught ReferenceError: NativeClass is not defined
at
../node_modules/nativescript-google-maps-sdk/map-view.js(file: node_modules/nativescript-google-maps-sdk/map-view.ios.js:51:0)

Can you upload a blank ns-vue project with your configuration?

@funder7  I've just created a new ns-vue blank project here:  https://github.com/liamcharmer/nativescript-vue-plain-google-map-test
NPM Version 6.14.7
Node Version 14.8.0
NativeScript 7.0.8
iPhone iOS 14

Ok mate, I will try to check it this weekend!

Another user reported that the MapView is not loading at all in this comment.
I guess that the problem reported by @liamcharmer affects all flavours, not only vue

Ok mate, I will try to check it this weekend! Thanks for the project

Don't feel rushed or anything, you're honestly doing such amazing stuff and saving so many people. But keep good health!

Hi guys,
I am also seeing the NativeClass is not defined error using NS7, as well as a few others that:
WARNING in ../node_modules/nativescript-google-maps-sdk/map-view-common.js 72:0-30
"export 'Style' (reexported as 'StyleBase') was not found in './map-view'
 @ ../node_modules/nativescript-google-maps-sdk/map-view.js
 @ ./create-incident/location-search.xml
 @ . sync (?<!\bApp_Resources\b.*)(?<!\.\/\btests\b\/.*?)\.(xml|css|js|(?<!\.d\.)ts|(?<!\b_[\w-]*\.)scss)$
 @ ./app.js

WARNING in ../node_modules/nativescript-google-maps-sdk/map-view.js 240:63-70
"export 'WeakRef' was not found in '@nativescript/core/debugger/dom-node'
 @ ./create-incident/location-search.xml
 @ . sync (?<!\bApp_Resources\b.*)(?<!\.\/\btests\b\/.*?)\.(xml|css|js|(?<!\.d\.)ts|(?<!\b_[\w-]*\.)scss)$
 @ ./app.js

WARNING in ../node_modules/nativescript-google-maps-sdk/map-view.js 241:75-82
"export 'WeakRef' was not found in '@nativescript/core/debugger/dom-node'
 @ ./create-incident/location-search.xml
 @ . sync (?<!\bApp_Resources\b.*)(?<!\.\/\btests\b\/.*?)\.(xml|css|js|(?<!\.d\.)ts|(?<!\b_[\w-]*\.)scss)$
 @ ./app.js

After a couple of hours of poking around I've finally got the app to build and the map to load without any warnings or crashes. These changes may have broken other things - I haven't had chance to test much of map functionality yet. Hopefully this might help somebody get up and running...

Terminating app due to uncaught exception 'NativeScript encountered a fatal error: Uncaught ReferenceError: NativeClass is not defined

I modified the src/tsconfig.json to be more similar to the official NS plugin tsconfig:
{
  "compilerOptions": {
    "target": "es2017",
    "module": "esnext",
    "moduleResolution": "node",
    "declaration": false,
    "noImplicitAny": false,
    "removeComments": true,
    "preserveConstEnums": true,
    "suppressImplicitAnyIndexErrors": true,
    "sourceMap": false,
    "pretty": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "noEmitHelpers": true,
    "noEmitOnError": true,
    "lib": [
      "es2017",
      "dom"
    ],
    "baseUrl": ".",
    "paths": {
      "*": [
        "./node_modules/*"
      ]
    },
    "plugins": [
      {
        "transform": "@nativescript/webpack/transformers/ns-transform-native-classes",
        "type": "raw"
      }
    ],
  },
  "include": [
    "./"
  ],
  "exclude": [
    "node_modules",
    "platforms"
  ]
}

publish/pack.sh seems to be loading the tsconfig.json file from the wrong directory:
Change this line:
node_modules/.bin/tsc -p "$TO_SOURCE_DIR/tsconfig.json"
To this:
node_modules/.bin/tsc -p "$SOURCE_DIR/tsconfig.json"

"export 'WeakRef' was not found in '@nativescript/core/debugger/dom-node'

I just removed this import from src/map-view.ios.ts:
import { WeakRef }  from '@nativescript/core/debugger/dom-node';

"export 'Style' (reexported as 'StyleBase') was not found in './map-view'

Just added an export of Style to src/map-view.ios.ts

@3rror404 @funder7 can confirm the above has solved the issue for now and got the map working

Working for me too, thanks!

Just create a tgz (just download the file and remove .zip ;) ) for easier usage:
nativescript-google-maps-sdk-3.0.0.tgz.zip

Hey @hypery2k nice work!
I don't know if that is possible but if you want open a new PR on my forked branch (feature/angular-10-compat) so we will include your work!
Regarding the pack.sh script....it creates a copy of the "src" directory, which if I don't remember bad is the "TO_SRC_DIR", then it does some operations on that folder, and finally it gets packed.
You can see what happens by commenting out the lines where the new directories are removed!
Cheers ;-)

Hi @funder7, What about the owner ? he will merge this soon ?

Would be great to see the changes made by @funder7 and @hypery2k getting merged soon.
This plugin is just way too important to not be compatible with {N} 7. 😃

Hello guys, I agree with you @MrSnoozles, before merging demo projects must be updated & tested, in order to provide to new users a good starting point. Unfortunately I'm really busy in these days and it's hard to find a moment to finish the upgrade.
Another point is iOS testing: I don't own an iPhone so it's impossible for me, I should setup a remote testing configuration somehow.
I'll do my best to find a spot in the next weeks, but I cannot guarantee it...If there's a candidate wanting to finish this tasks, I can give some support in case he/she needs it.
;-)

I've been working on this (along with others of course) and will do everything I can.   At the moment apart from the demos, there seems to be issues with all events on IOS apart from mapReady.   Ive seen at least one other commenting similar.
I can run extensive tests on IOS both physical and via simulators and Im not seeing anything other than mapReady firing.   I'm thinking the new @nativeclass requirement is the issue.

@funder7 I have can do the job .. can you tell me what should I do exactly ?

Hi guys, thanks for your interest.
@rljdavies I think that you're right. I'm pretty sure to have read a post on NS blog, telling to add the @NativeClass() decorator on each plugin class extending a iOS native object.
An example:
@NativeClass()
class IndoorDisplayDelegateImpl extends NSObject implements GMSIndoorDisplayDelegate {

Would that be sufficient? I don't know, but I hope so.  I just looked at some code that I've commited in the past months and it seems that decorators are already in place.
But speaking with another plugin user, he told me about a memory leak problem that he noticed. When unloading the view which contains the map, memory is not freed. So if you continue to do back and forth from the map view, a new instance is created every time, but not deleted once you leave.
I'm almost sure that a breaking change has been introduced in the view lifecycle in the latest versions, so the plugin must be adapted in order to load(and unload) correctly. I've made a temporary fix for issue #422 , which is touching the area where I suspect this problem resides, you can see the updated code here, check disposeNativeView().
You can try to do a debug session and check that in the iOS part, all references are populated correctly, it's very likely that something is not initialized and is null,  that's why event listeners may be not hooked correctly. Just an assumption.
@kefahB demo projects are carried with the plugin to provide a minimal working configuration for each NS flavour (Angular, Vue.js, Vanilla JS, etc.. ). So there are some changes to be done:

Angular demo project must be updated to Angular 10.x,
The way how mapView is initialized in the Angular project must be updated to follow latest guidelines for @ViewChild usage
Update all the projects dependencies if possibile (maybe comparing the project with a more recent one)
Update the Readme to include the new updates

Generally speaking that's what's missing, solving iOS issues and checking the mapView lifecycle on both platforms is a top priority task though, maybe let's focus on that before completing the rest.
We can organize a day where we "meet" and try to fix all this problem, to close this update. Let me know what do you think about it, generally I'm free on saturday or sunday (doh)
Cheers guys

Thanks for the comprehensive post @funder7

Would that be sufficient? I don't know, but I hope so. I just looked at some code that I've commited in the past months and it seems that decorators are already in place.

I think/hope so too.   I've seen the decorator in some places but not others I might have expected them to be.
I have to push an App Store update this evening with partial fixes in a client app, but once that is out I can turn back to this.

@funder7 It will be great if you push your changes to your fork, then I will continue from there

@rljdavies no problem, we can also arrange this for the next weekend
@kefahB Ok I'll push the changes in a separate branch, as more than a month passed and now I don't remember if what I was doing was kind of a test, or definitive code. They're more than 200 files :(
Since there are some changes on plugin code, I'll push them in a separated commit, please keep an eye on them too.
I'll post the branch name once everything is pushed

Ok... so I pushed my changes to refactor/demo-projects-update, but I have bad news: files were marked as changed but in fact only their file permissions were changed, don't ask me why. On 200+ changes, only few of them were really updated, and I can tell that those updates can be trashed straight away, sorry guys.
If you want, we can meet next saturday afternoon and try to finish this update. Let me know if you're available. Cheers

@funder7 I've forked the project .. and successful running on IOS, there is only one issue, infoWindowTemplates dose not work! I’ll keep this for the moment try with android then we will see

Nice! So #422 happens on android only, or recent ns updates have solved the problem.
The current version has a typo in the class where map styling json is parsed, in case you need that function give it a check.
If you can, keep an eye on memory usage, in particular I'd like to know if memory is freed once the map view is unloaded.
It's kinda weird though that it works with the old configuration, but not after linking new nativescript libraries. I will try to compare the   transpiled output of both version just to understand what differs.
Thanks for reporting!

I run the project on both platforms successfully without problem .. I'll try to debug the memory for android...
Also I have implemented CLLocationManagerDelegate to get the button myLocationButton worked .. it have never worked on IOS :)

I found a reply from TSC to a question you asked a little while back @funder7 - confirming NativeClass decorator is not needed in the typings files.  So here's what I did...

Rebuilt my project from scratch, not just ns clean, a completely new start beginning with ns create.
Followed steps outlined by @3rror404 (except the StyleBase step as this for me created a circular reference).
Rather than overwriting plugin files I removed the plugin fully and installed from the local tgz as mentioned by @3rror404

After I did the above I was able to run my project including with map events (eg MapMarkerSelected) firing on IOS.
However, native classes (eg GMSCameraPosition) were not found.
So, I copied the typings files in the plugin's platforms/ios folder to the @nativescript/types-ios/lib/ios/objc-x86_64 folder and added references to them in @nativescript/types-ios/lib/ios/ios.d.ts and everything I'm using plugin wise now appears to be working  (although one issue with preparing a release build remains)
Therefore, there does seem to be an issue with references but this point I'm unsure if this is specific to this plugin or something more general with NS7.   Its worth pointing out not all of the plugins in the project are NS7 but in those cases they are minor plugins with limited function.
Hopefully this info moves us on a little.

Hi @funder7 ,
I've pushed a new PR .. I tested on multiples device and it work "properly" but the infoWindowTemplates does't work for the moment !

Closing in favor of #440


⚠ Thumbnails API Endpoint has degraded performance

In 7fe1426, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1865 ms

Resolved: Thumbnails API Endpoint performance has improved in e03c9ca.


Crab

Description:
Add Crab, monster that has +2 cl slots
Changes:

Add Crab

Update highscores to add Araxxor

[X] I have tested all my changes thoroughly.

If you are adding this to osb (not sure if you are), just make sure it matches osrs in terms of how long it takes to finish

If you are adding this to osb (not sure if you are), just make sure it matches osrs in terms of how long it takes to finish

Yup thats the plan, I'll be sure to test out kills/ph ingame first before I PR the monster in osb.


Make reflections library optional

Would you consider something along these lines to make the reflections library optional?  As I understand it, it's only used for the class/minimal-class cases, which in my experience aren't that common.  There are a couple of issues I hit in using in using the library:

Slow initialisation time due to classpath scanning
Tedious discussions with management about the suitability of WTFPL - see https://github.com/ronmamo/reflections/issues/159

Scala isn't really my thing so please let me know if there's anything that can be improved.

Thanks for the PR..
I will look into this some more..
-Morten

I have updated reflectioncode. New reflection-lib is much faster.
Maybe we do not need to make it optional, just lazy?


useCLS error

Wondering what the model files are supposed to look like. I've already defined models and resolvers and also have built my own schemas as well, but wanted to see if this gave more functionality. However, I'm bumping into an issue where it seems like it doesn't like the models I've built. I do have the dependencies sequelize and graphql installed.

Can you please post full error here or your code to see the error? You can check tests folder for an example how this library works.

src/index.js
...imports

var { GraphQLSchema } = require('graphql');
const { generateSchema } = require('sequelize-graphql-schema')()
const schema = new GraphQLSchema(generateSchema(models))

const server = new ApolloServer({
  typeDefs: schema,
  resolvers,
    return {
      ...error,
      message,
    };
  },
  context: async ({ req, res }) => {
    return {
      models,
      me,
      secret: "notSoSecret",
    }
  },
  path: "/graphql"
});

server.applyMiddleware({ app });
app.get("/playground", graphiql({ endpoint: "/graphql" }));

const handler = serverless(app);
export { handler };

One of many model files
'use strict';
module.exports = (sequelize, DataTypes) => {
  const Role = sequelize.define('role', {
    id: {
      type: DataTypes.INTEGER.UNSIGNED,
      autoIncrement: true,
      primaryKey: true
    },
    slug: {
      allowNull: false,
      type: DataTypes.STRING,
    },
    description: {
      allowNull: false,
      type: DataTypes.STRING,
    },
    created_at: {
      type: 'TIMESTAMP',
    },
    updated_at: {
      type: 'TIMESTAMP',
    }
  }, {
      underscored: true,
    });
  Role.associate = function (models) {
    // associations can be defined here
  };
  return Role;
};

{"errorMessage":"Error while loading playground","errorType":"TypeError","stackTrace":["TypeError: Cannot read property 'useCLS' of undefined","at generateSchema (C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\sequelize-graphql-schema\dist\sequelize-graphql-schema.js:869:20)","at Module../src/index.js (C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:322:34)","at webpack_require (C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:21:30)","at C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:85:18","at Object.  (C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\hapi\lib\connection.js:259:30)","at Server.emit (events.js:182:13)","at Server.EventEmitter.emit (domain.js:442:20)","at parserOnIncoming (_http_server.js:672:12)"],"offlineInfo":"If you believe this is an issue with the plugin please submit it, thanks. https://github.com/dherault/serverless-offline/issues"}

it seems like the models you are passing doesn't have an object Sequelize along with it as in https://github.com/alirizwan/sequelize-graphql-schema/blob/ab613a02609226aeae97bf71377d805bbb99924c/tests/models/index.js#L40
I believe in next update I can make changes so we can have more ways to pass Sequelize objects instead of the way it is now.

I failed to mention that I do have an index file as follows that I think may make a difference:
import Sequelize from "sequelize";
import config from "./../config/config";
const sequelize = new Sequelize(config.db.database, config.db.username, config.db.password, config.db.options);

const roleModel = require("./Role.js");

const models = {
  Role: sequelize.import("role", roleModel),
}

Object.keys(models).forEach(key => {
	if ("associate" in models[key]) {
		models[key].associate(models);
	}
});

export { sequelize };
export default models;

you are not exporting Sequelize but only sequelize. You need to export all three sequelize Sequelize and models;

Okay so I made the following changes in which I believe reflects what you've mentioned, and I'm getting a new error:
models/index.js
import Sequelize from "sequelize";
import config from "./../config/config";
const sequelize = new Sequelize(config.db.database, config.db.username, config.db.password, config.db.options);

const roleModel = require("./Role.js");

const models = {
  Role: sequelize.import("role", roleModel),
}

Object.keys(models).forEach(key => {
	if ("associate" in models[key]) {
		models[key].associate(models);
	}
});

models.sequelize = sequelize;
models.Sequelize = Sequelize;
export default models;

Error:
{"errorMessage":"Error while loading playground","errorType":"TypeError","stackTrace":["TypeError: Cannot read property 'options' of undefined","at C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\sequelize-graphql-schema\dist\sequelize-graphql-schema.js:621:49","at Array.reduce ()","at generateQueryRootType (C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\sequelize-graphql-schema\dist\sequelize-graphql-schema.js:610:43)","at generateSchema (C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\sequelize-graphql-schema\dist\sequelize-graphql-schema.js:925:14)","at Module../src/index.js (C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:322:34)","at webpack_require (C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:21:30)","at C:\Users\Mike\Desktop\test\apollo-server-api\.webpack\service\src\index.js:85:18","at Object.  (C:\Users\Mike\Desktop\test\apollo-server-api\node_modules\hapi\lib\connection.js:259:30)","at Server.emit (events.js:182:13)","at Server.EventEmitter.emit (domain.js:442:20)","at parserOnIncoming (_http_server.js:672:12)"],"offlineInfo":"If you believe this is an issue with the plugin please submit it, thanks. https://github.com/dherault/serverless-offline/issues"}
So I tried putting some options in I had required the package and the result would be the same, tried removing it altogether and just having:
const { generateSchema } = require('sequelize-graphql-schema')
would say that generateSchema is not defined.

I tried to re-produce it and found a couple of issues. When you import your model, import it as model name instead of giving it a name of your own unless the name matches with the model name for example, model name is role but your key in models object is Role. It's better to do it like this:
const models = {}; const roleModel = sequelize['import']('./Role.js'); models[roleModel.name] = roleModel;
For model importing if you could use the logic we have in tests/models/index.js that's pretty generic and automatically imports all of available models.
Second
created_at: {       type: 'TIMESTAMP',     },     updated_at: {       type: 'TIMESTAMP',     } you don't need these two columns, if you want to use DataTypes.DATE

https://github.com/alirizwan/sequelize-graphql-schema/issues/19
closing this issue.


1.0.0

Signed-off-by: Josh Wulf<EMAIL_ADDRESS>

Shouldn't some other dependencies be updated (e.g. simple monitor to 2.0.0 with the hazelcast 1.0.0 exporter ?)


Leader Change Hook

What's the best way to hook into leader change events? I see how it's done internally, each append_entry request has this guard:
     if self.current_leader.as_ref() != Some(&msg.leader_id) {
         self.update_current_leader(UpdateCurrentLeader::OtherNode(msg.leader_id));
         report_metrics = true;
     }

But this leader_id field is dropped by the time by time my impl is called:
    #[tracing::instrument(level = "trace", skip_all, fields(len=%entries.len()))]
    async fn append_to_log(&self, entries: &[&Entry<SequencedRequest>]) -> Result<()> {
        // What's the cheapest way to find out whether this entry has a new leader?
        todo!()
    }

Basically, I need set some context following a leader re-election BEFORE applying the associated entry to the state machine? I could simply query the RaftMetrics in apply_to_state_machine if that's how the control flow works. As it stands, I'm not 100% sure when report_metrics takes effect because it sends the update asynchronously:
        let res = self.tx_metrics.send(RaftMetrics {
            id: self.id,
            state: self.target_state,
            current_term: self.current_term,
            last_log_index: self.last_log_id.index,
            last_applied: self.last_applied.index,
            current_leader: self.current_leader,
            membership_config: self.membership.clone(),
            snapshot: self.snapshot_last_log_id,
            leader_metrics,
        });

AFAIK, send() is synchronized between threads. E.g. a Receiver::borrow() that is called after send() should always see the updated value:
https://docs.rs/tokio/1.8.0/src/tokio/sync/watch.rs.html#360
https://docs.rs/tokio/1.8.0/src/tokio/sync/watch.rs.html#231
But you are still not guaranteed to see the correct leader because the leader may have changed again.
What's your root need for this? Why do you need the leader-id when applying a log entry? 🤔
Since there is no guarantee that every follower sees the same leader-id when applying a certain log entry.


SCIM integration with OpenID Connect

Hi,
Does OpenID Connect implementation support the following draft Draft ?
Also, how to integrate SCIM within the dex and harmonize it with existing OpenID connect?

To the best of my understanding SCIM is a mechanism for asynchronous updates between user management systems. Dex isn't really a user management system, it federates to existing ones. What minimal representations of users it does have can be managed from the API.
I'm a little confused what you're specifically proposing. This seems like an orthogonal issue to what dex does (authentication vs user management).

@ericchiang  SCIM is definitely for user management, but it also allows to add more attributes related to user info that could not be available from standard LDAP.  However, OpenID connect supports SCIM based service for userinfo that can in turn connect to LDAP or other database.  Therefore, wondering how to provision user with dex stack, does openid connect implementation in dex already has provision for the following attributes (scim_id, scim_location, scim_profile, scim_endpoint) as per draft ? Then i need to register client with those information and  on the other side SCIM service to support that interaction.

Therefore, wondering how to provision user with dex stack, does openid connect implementation in dex already has provision for the following attributes (scim_id, scim_location, scim_profile, scim_endpoint) as per draft?

Dex does not. It only implements the core and provider metadata specs, which are the most commonly implemented throughout providers.
Let me read over that draft and get back to you on this.

So basically you'd like to add extra fields to the discovery metadata, id token, and clients?

Do you have a specific client that uses this info I can look at? Or are you planning on rolling your own?

This specification defines the following metadata:
Discovery metadata indicating the availability of a SCIM protocol base endpoint.
Dynamic registration metadata that is used to indicate a clients intent to use the SCIM protocol and its associated endpoint.
An additional ID Token claim which specifies the SCIM resource endpoint and identifier associated with the authenticate subject.
In addition to the above metadata attributes and claims, the specification will also show how a client MAY access the SCIM endpoint.

Yes, I read the spec. We don't have dynamic client registration but we still have additional attributes on clients.
I'm curious what you're using this for. I'm not super familiar with the SCIM ecosystem and I'd like to understand what technologies you plan to use this feature with.

@ericchiang  So, the first important thing is that, instead of adding Rest to Ldap, SCIM is the standard and make easier to Restify provisioning of the users, groups and extensible for attributes that can be part of the token claim set.
Second, it may require to move identity from Active directory or Ldap to cloud and it is useful there as well. There are other feature set like password reset, migration, extensibility. It seems as an Identity management service that can interact with internal system and external as well.

@ericchiang can you assign  Priority to this proposal ?

It's been assigned one. We're not working on it.
For us, supporting new protocols involves learning about the providers that implement them, getting good examples of clients, understanding the security implications, etc. SCIM is a big spec and most implementations seem to be closed source so its hard for us to gauge the amount of work, ongoing maintenance, and benefit of this feature. SCIM integration isn't a huge priority for us so we've not been doing this initial investigation.
If you have specific readings on SCIM and OpenID Connect integrations or software that uses this I'd be happy to explore it a little bit more.


Need to remove flag argument from ActionBar:AddButton

The flag isn't being used so remove it from the Save and File Picker tools.

Flag argument has been removed from the AddButton() method.


Master: remote-exec: error validating "STDIN"

Upon running terraform apply -var 'nodes=1' -var 'weave_password=password' -var 'docker_version=18.06', I was presented with the following error when trying to apply the monitoring script commands...
scaleway_server.k8s_master (remote-exec): error: error validating "STDIN": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false

Both urls return a 404 status, which in turns kills the terraform process.
https://github.com/stefanprodan/k8s-scw-baremetal/blob/7829b914bc043a1e1005720661f1cf136b11e003/scripts/monitoring-install.sh#L11-L23
So a quick fix for anyone encountering the same problem, you'll need to change the dashboard url to the appropriate one for your architecture.

What link did you use?
I tried 2.0.0 beta.7 but did not work

Hey @domiSchenk, the tag your using doesn't have an arm version available. You'll have to build that yourself or change back to the v1.10.1 tag.


Remove addreaction!

Previously addreaction! was used to handle large Vector{Reaction}, otherwise, a stackoverflow error was thrown. However, mutating the system is not ideal, therefore this updates rather creates a Vector via push! that avoids the problem of building, at a single time, a Vector with to many lines of code.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (a0c2ec7) to head (6019b49).
Report is 12 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   96.58%   96.56%   -0.03%
==========================================
  Files          22       22
  Lines        1698     1687      -11
==========================================
- Hits         1640     1629      -11
  Misses         58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


drivers: sensor: adxl362: Driver update and CS support

Updated to add support for CS. DT config names updated
to adhere to the DTS naming convention. Init and SPI
configuration now follows the device datasheet.
Signed-off-by: Henrik Malvik Halvorsen<EMAIL_ADDRESS>

Codecov Report

Merging #14030 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14030      +/-   ##
==========================================
- Coverage   52.27%   52.23%   -0.04%
==========================================
  Files         307      307
  Lines       45467    45467
  Branches    10525    10525
==========================================
- Hits        23768    23751      -17
- Misses      16901    16913      +12
- Partials     4798     4803       +5

Impacted Files
Coverage Δ

subsys/testsuite/ztest/include/ztest_assert.h
38.88% <0%> (-38.89%)
:arrow_down:

subsys/testsuite/ztest/src/ztest.c
65.28% <0%> (-7.44%)
:arrow_down:

arch/posix/core/posix_core.c
90.9% <0%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fd80a...788c32e. Read the comment docs.

Please make gpio-driven chip select optional, not mandatory. See adxl372 for example.

OK. I've updated the PR now.


ChakraValueEditor does not have Chakra props for fine-tuned styling

Hi, so currently all other chakra controlElements from @react-querybuilder/chakra are able to pass in chakra style props for styling
Example:
const baseChakraControlElements: Partial<Controls> = {
    ...chakraControlElements,
    fieldSelector: (props: FieldSelectorProps) => (
      <ChakraValueSelector {...props} size={size} />
    ),
    combinatorSelector: (props: CombinatorSelectorProps) => (
      <ChakraValueSelector {...props} size={size} />
    ),
    operatorSelector: (props: OperatorSelectorProps) => (
      <ChakraValueSelector {...props} size={size} />
    ),
    addRuleAction: (props: ActionWithRulesAndAddersProps) => (
      <ChakraActionElement {...props} size={size} px={4}/>
    ),
    addGroupAction: (props: ActionWithRulesAndAddersProps) => (
      <ChakraActionElement {...props} size={size} px={4}/>
    ),
    removeGroupAction: (props: ActionWithRulesProps) => (
      <ChakraActionElement {...props} size={size} />
    ),
    removeRuleAction: (props: ActionWithRulesProps) => (
      <ChakraActionElement {...props} size={size} />
    ),
  };

However for the <ChakraValueEditor /> component, it does not have access to the ChakraUI style props that the other control elements have access to, so there is no way to finely control the style for the input inside the <ChakraValueEditor/> component when passing it as an overriden control element for  <QueryBuilder />
Example:
<ChakraValueEditor {...props} size={size} /> // this will not work, as size does not exist as a prop

Hi @jsungg! Thanks for bringing this up. Actually none of the value editors in any of the compatibility packages accept extra props specific to their respective style library like the value selectors, buttons, and other components do.
The reason is that value editors, ChakraValueEditor in your case, can render one of several different (Chakra) components depending on the props, and I couldn't union all the props types for all the possible rendered components. When I originally created them, I didn't think enough about how to get them to accept custom props for several different components in one props object, but I think I know how to do it now, so I'll try to address this in v7.0.0 (no ETA on that yet).


frameworks: improve log_artifact for model "checkpoints"

When auto-logging model artifacts as part of the frameworks in #500, sometimes frameworks save multiple model files at different paths within a directory to allow users to keep multiple model checkpoints:

https://lightning.ai/docs/pytorch/stable/common/checkpointing_basic.html
https://huggingface.co/docs/transformers/main_classes/trainer#transformers.Trainer.save_model
https://docs.fast.ai/callback.tracker.html#savemodelcallback

This present some questions for our callbacks:

Should we save the individual files or the entire directory?
How should we keep track of the latest model file so that it can be used to resume/analyze/deploy?

After #472, live.log_artifact should be adding something to dvclive/dvc.yaml like:
artifacts:
  fast-ai-model:
    path: model.pth
    type: model

This artifacts section could be used to answer question 2 above. Each call to live.log_artifact can update the path in that artifacts section from model_1.pth to model_2.pth and so on, and @aguschin is working on making it possible to do things like dvc get . fast-ai-model so that it's possible to get the model without specifying the exact path of the last checkpoint.
In that case, question 1 becomes less important and is mostly about how we want to organize the .dvc files: is it okay to have one for each checkpoint, or should we try to track the model directory?

I think we can close this as completed with the work we have done so far in lightning and huggingface


Add ability to access method parameters

I'm trying to use gomigen for a project at work. I have an audit logging layer on my services that records every operation in a database. Since the code is mostly the same for all methods I'd like to use a code generation tool. However, I'm not able to use gomigen, since there is no option to access the parameters of the method. I need to access them in order to preserve them in the database as part of the audit log.
Here's how the current implementation looks (I've stripped some details):
func (s *Service) Operation(ctx context.Context, p *Params) (*Result, error) {
	user, err := auth.UserFromContext(ctx)
	if err != nil {
		return nil, fmt.Errorf("no user info provided: %w", err)
	}

	ri, err := remoteinfo.FromContext(ctx)
	if err != nil {
		return nil, fmt.Errorf("error extracting remote info: %w", err)
	}

	log, err := s.logger.Start(ctx, &audit.Log{
		UserID:    user.ID,
		ClientID:  user.ClientID,
		Action:    "package.Service.Operation",
		Params:    p, // Params need to be persisted.
		UserAgent: ri.UserAgent,
		RemoteIP:  ri.RemoteIP,
		Country:   ri.Country,
	})

	if err != nil {
		return nil, fmt.Errorf("error persisting start audit log: %w", err)
	}

	ctx = audit.LogInContext(ctx, log)
	r, err := s.next.Operation(ctx, p)

	_ = s.logger.End(ctx, log)

	return r, err
}

The types.MethodInfo object seems like a good place to add the method parameters. Perhaps a Params []interface{} field will be enough. Does this sound like a good idea and does it fit the general design idea of gomigen?
Thanks,
Ivan

Hi. This was implemented as part of #7. Do note that it's a breaking change because it extends the MethodInfo structure. Let me know if you need a tag as of now or you can wait until I look into #5

Thanks!
I don't need a tag, I'll try this out and I'll add panics in order to stop the original method invocation (so I can actually try it) until #5 is ready.


bintray: fix package creation for verbose output

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Ref: https://github.com/Homebrew/brew/pull/7415#issuecomment-619453118
I believe we should consider  removing appending --fail flag from the expression
https://github.com/Homebrew/brew/blob/bbe300ab2aa5c6cb097cdee2bc2b2c7aeda8af2a/Library/Homebrew/utils/curl.rb#L35-L40

I believe we should consider removing appending --fail flag from the expression

Should it be moved outside the expression or just removed altogether?

Actually, would prefer to have --fail always to be as a part of curl command.
Just for a reference, it was like this before until moved to unless show_output in https://github.com/Homebrew/brew/pull/3039
Also, we could put --fail under a separate ruby flag, something like:
diff --git a/Library/Homebrew/utils/curl.rb b/Library/Homebrew/utils/curl.rb
index 25d5e2235..dc00df1da 100644
--- a/Library/Homebrew/utils/curl.rb
+++ b/Library/Homebrew/utils/curl.rb
@@ -13,7 +13,7 @@ def curl_executable
   @curl
 end

-def curl_args(*extra_args, show_output: false, user_agent: :default)
+def curl_args(*extra_args, show_output: false, user_agent: :default, raise_on_failure: true)
   args = []

   # do not load .curlrc unless requested (must be the first argument)
@@ -32,8 +32,11 @@ def curl_args(*extra_args, show_output: false, user_agent: :default)
     user_agent
   end

-  unless show_output
+  if raise_on_failure
     args << "--fail"
+  end
+
+  unless show_output
     args << "--progress-bar" unless Homebrew.args.verbose?
     args << "--verbose" if Homebrew::EnvConfig.curl_verbose?
     args << "--silent" unless $stdout.tty?

Thanks @bayandin!


Creating token account without a name, created a null name , this is specific to Bubble.

This is specific to Bubble, when the API call is created, all the parameters have to be provided and if the user does not want to create a name and leaves the name parameter blank, a null name is created.
Is it possible to ignore the "name" parameter if it is empty?
{
"owner": "b7fa11647c02a3a65a72970d8e703d8804eb127c7e7c41d565c3514a4d3fdf13",
"version": 1,
"created":<PHONE_NUMBER>,
"modified":<PHONE_NUMBER>,
"type": "OBJECT",
"register": "8BwLP3DUZ9Awe2dg1SyQQLCdbAcMoYzBLZyiY9qBQxLSv1Vav3Y",
"name": null,
"namespace": "",
"address": "8JPLqFyFDTjpvrey5vXg1ShCAkj8ZSntaz4XHW2DKiUZbtrg3qS"
},

Fixed with commit abb26aa113bd21e06e7e5b8a878cd975774bc868


More AnnotationProcessor tests

Again a failing merge request. Please do not merge this one yet.
I like to talk about how the AnnotationInfo and the AnnotationProcessor need to be updated. I can then directly integrate those changes into this MR

Okey dokey. We can discuss in person after Nov 13th :smile:

Coverage decreased (-3.3%) to 80.944% when pulling d436ebc72baf91a6025784d147b560f6c6bb9305 on sclassen:annotationProcessorTests into 394a53f5fa516647a93df6f7f94efcfb96090721 on aalmiray:master.

Coverage decreased (-4.1%) to 80.159% when pulling 041510c2f2546705a4df47770eca367afbee5d76 on sclassen:annotationProcessorTests into 394a53f5fa516647a93df6f7f94efcfb96090721 on aalmiray:master.

This is quite a big PR, thanks again for having a hard look into this feature 😄


Cannot provide custom file matching pattern

When I run my tests from the terminal I can rely on the files param for example like this:
configure({
  ...processCliArgs(process.argv.slice(2)),
  ...{
    files: ['test/**/*.e2e-spec.ts'],
    ...
  },
});

But code lenses do not show up on those files because I can't set the same pattern to match for the extension.

Thanks for the report
For the moment, for simplicity, I have hardcoded the test file name pattern.
https://github.com/Julien-R44/japa-vscode/blob/main/src/index.ts#L14
it should be quite easy to fix anyway. I'll try by the end of the week

Great, thanks for your work and the quick reply!

Works great, thank you!


Harden registry APIs: signatures & result handling

Current registry APIs should be revised on the following points:

Rename all the APIs in ebpf_registry_helper.h by prepending ebpf_.
Add return value and related tracking to the close_registry_key API (i.e. ebpf_close_registry_key after renaming).

Work for this issue will be included in #2123


"IndexError: string index out of range" on trying to stem the word "oing"

Easy to reproduce:
>>> from nltk import PorterStemmer
>>> stemmer = PorterStemmer()
>>> stemmer.stem('oing')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/peterbe/virtualenvs/songsearch/lib/python3.5/site-packages/nltk/stem/porter.py", line 665, in stem
    stem = self._step1b(stem)
  File "/Users/peterbe/virtualenvs/songsearch/lib/python3.5/site-packages/nltk/stem/porter.py", line 376, in _step1b
    lambda stem: (self._measure(stem) == 1 and
  File "/Users/peterbe/virtualenvs/songsearch/lib/python3.5/site-packages/nltk/stem/porter.py", line 258, in _apply_rule_list
    if suffix == '*d' and self._ends_double_consonant(word):
  File "/Users/peterbe/virtualenvs/songsearch/lib/python3.5/site-packages/nltk/stem/porter.py", line 214, in _ends_double_consonant
    word[-1] == word[-2] and
IndexError: string index out of range

>>> import nltk
>>> nltk.__version__
'3.2.2'

I got this error for the word "aed":
from nltk.stem.porter import PorterStemmer
from nltk.corpus import stopwords
stemmer = PorterStemmer()
stemmer.stem('aed')

Error is:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/peter.hurford/.virtualenvs/rex/lib/python2.7/site-packages/nltk/stem/porter.py", line 665, in stem
    stem = self._step1b(stem)
  File "/Users/peter.hurford/.virtualenvs/rex/lib/python2.7/site-packages/nltk/stem/porter.py", line 376, in _step1b
    lambda stem: (self._measure(stem) == 1 and
  File "/Users/peter.hurford/.virtualenvs/rex/lib/python2.7/site-packages/nltk/stem/porter.py", line 258, in _apply_rule_list
    if suffix == '*d' and self._ends_double_consonant(word):
  File "/Users/peter.hurford/.virtualenvs/rex/lib/python2.7/site-packages/nltk/stem/porter.py", line 214, in _ends_double_consonant
    word[-1] == word[-2] and
IndexError: string index out of range

Installed with:
pip install nltk
python -m nltk.downloader -d

Version:
import nltk
nltk.__version__ # '3.2.2'

Duplicate of https://github.com/nltk/nltk/issues/1581. My fault; sorry. :(
The bug was introduced in version 3.2.2 and is fixed on master; you can either use master or version 3.2.1 to get rid of the bug.

Close as fixed?

So, has the issue been resolved?

This issue should have been resolved by #1582 😉
>>> import nltk
>>> nltk.__version__
'3.2.5'

>>> from nltk import PorterStemmer
>>> porter = PorterStemmer()
>>> porter.stem('oing')
u'o'


WIP - Koji Parent Content Generator

Store parent Koji build ID in Koji Content Generator metadata for build

Still needs work for https://github.com/projectatomic/atomic-reactor/pull/812/files#r137030657.

Updated release notes draft:

koji_import will add the ID of parent image's koji build to metadata.


[QA-419]: Update S3 property to fix issue

QA-419
What?
Update S3 results bucket property to fix deployment issue.
Changes:

Added OwnershipControls property to replace the AccessControl property.
This has been tested in the dev environment.

Why?
To fix the deployment issue in perf test accounts.

Replaced by #486


typo in bulleted list

There is a ">" after the third bullet text  of the bulleted list items.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fe072057-700f-333e-9fd8-4f5859310c7b
Version Independent ID: 3fc4ff6f-32bb-8d0c-284a-e79a2ced3c50
Content: Strategy and vision best practices - Power Platform
Content Source: power-platform/guidance/adoption/strategy-best-practices.md
Service: power-platform
Sub-service: guidance
GitHub Login: @manuelap-msft
Microsoft Alias: mapichle

Thanks for your comment, @jmccartan. This issue has been assigned to the doc author for review.


[helping] The difference between String a = null and String a = "" in beanshell script

Expected behavior
The difference between String a = null and String a = "" in beanshell script.
What information can I refer to to understand this issue?
Actual behavior
No response
Steps to reproduce the problem
when i use String a = ""; I get a result . A definite value can be obtained。
。
but i use String a = null; I can`t get a result. i get a void.

JMeter Version
5.5
Java Version
17
OS Version
windows version 11

I believe this is a duplicate of https://github.com/apache/jmeter/issues/3411
I am afraid we can't fix it in JMeter until Beanshell team releases an update (see https://github.com/beanshell/beanshell/issues/739)
As a workaround, you could use Groovy.


Unable to trigger 'open' state on DropdownMenu when controlled

Bug report
Current Behavior
The dropdown will open as expected when its open state is not controlled.
However, when the state is controlled,
I have made implementation and test for each case.
// uncontrolled
import * as DropdownMenu from "@radix-ui/react-dropdown-menu";

export function UncontrolledDropdown() {
  return (
    <DropdownMenu.Root>
      <DropdownMenu.Trigger>Trigger</DropdownMenu.Trigger>
      <DropdownMenu.Portal>
        <DropdownMenu.Content>
          <DropdownMenu.Item>Item 1</DropdownMenu.Item>
          <DropdownMenu.Item>Item 2</DropdownMenu.Item>
          <DropdownMenu.Item>Item 3</DropdownMenu.Item>
        </DropdownMenu.Content>
      </DropdownMenu.Portal>
    </DropdownMenu.Root>
  );
}

And the following test passes.
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { UncontrolledDropdown } from "./uncontrolled-dropdown";

it("renders without crashing", async () => {
  const user = userEvent.setup();

  render(<UncontrolledDropdown />);

  await user.click(screen.getByText("Trigger"));
  expect(screen.getByRole("menu")).toBeInTheDocument();
});

Here is the controlled version
import { useState } from "react";
import * as DropdownMenu from "@radix-ui/react-dropdown-menu";

/**
 *
 */
export function ControlledDropdown() {
  const [open, setOpen] = useState(false);

  return (
    <DropdownMenu.Root open={open}>
      <DropdownMenu.Trigger onClick={() => setOpen(true)}>
        Trigger
      </DropdownMenu.Trigger>
      <DropdownMenu.Portal>
        <DropdownMenu.Content>
          <DropdownMenu.Item>Item 1</DropdownMenu.Item>
          <DropdownMenu.Item>Item 2</DropdownMenu.Item>
          <DropdownMenu.Item>Item 3</DropdownMenu.Item>
        </DropdownMenu.Content>
      </DropdownMenu.Portal>
    </DropdownMenu.Root>
  );
}

And the following test will fail. It will fail to query for an element with role 'menu'.
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { UncontrolledDropdown } from "./uncontrolled-dropdown";

it("renders without crashing", async () => {
  const user = userEvent.setup();

  render(<UncontrolledDropdown />);

  await user.click(screen.getByText("Trigger"));
  expect(screen.getByRole("menu")).toBeInTheDocument();
});

Expected behavior
Whether the component is controlled or not should not impact the test.
Reproducible example
CodeSandbox
Suggested solution
Not really sure what's going on here.
Additional context
I have tried to mock PointerEvent as Suggested by #856, but it doesn't fix the issue.
Your environment

Software
Name(s)
Version

Radix Package(s)
react-dropdown-menu
2.0.6

React
n/a
18.2.0

Browser

chrome

Node
n/a
18.18

npm/yarn

1.22.19(yarn)

Operating System

MacOS

I'm sorry, simply passing a handler to onOpenChange fixes this.


[feature]: Change microsevice admin password - POST /msadmins/change-password

Before submitting your PR for review

Run npm run lint to find errors in code syntax/format
Run npm run lint:fix to fix all auto-fixable errors in source code and auto-format with prettier
Ensure you fix any linting errors displayed after running any of the above commands

What does this PR do?
Fixes #434
An endpoint for microservice admins to change their password
Description of Task to be completed?

Create controller for changing microservice admin password
Add validation rules and middleware
Attach controller to route
Write tests for the endpoint

How should this be manually tested?

Send POST request to /v1/msadmins/change-password with the sample body and valid superAdmin system token

{
  "oldPassword": "someoldpassword",
  "newPassword": "a new password",
}

Any background context you want to provide?
Password is minimum of 8 characters

Nice, everything looks fine.


BUG: Clicking on the display name does not render the profile page of the author

Steps to Reproduce:

Open planetary.link
Click on the author display name
Issue: Profile header flashes and page goes black

Fixed in #104

hi @nichoth - This seems to work for the main message, but for any reply I am not seeing this work consistently. I opened the javascript console while testing a click on AndreStaltz and saw a bunch of errors.

The errors about a CORS issue indicate that the server crashed (it restarts automatically). I have tried reproducing (clicking a reply avatar) and it seems ok at the moment.

Hi @nichoth - Why do you think the server crashed? Do you think it's related to this change or to something completely different?

Something random; it may be a memory leak somewhere deep in the ssb stack.


1259 - Make ledger state dir optional to handle disable ledger option

Description
This PR fixes issue #1259
Checklist

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes are noted in the changelog
[x] Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh
[ ] Self-reviewed the diff

Migrations

[ ] The pr causes a breaking change of type a,b or c
[ ] If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
[ ] Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

Closing as superseded by https://github.com/input-output-hk/cardano-db-sync/pull/1378


fixed error messages and inconsistent if-condition-raise statements

@islem-esi Can you please resolve conflicts? Thank you!

Hi @islem-esi Can you please check @rohan100jain's comments and keep us posted ? Thank you!


Fix XmlException when writing Html log with certain test names

Fix https://github.com/microsoft/vstest/issues/3136
Bug: In the repro case, the test metadata (display name here) contains characters like � that are not valid in XML (outside of CDATA perhaps) per spec:

https://www.w3.org/TR/2008/REC-xml-20081126/#NT-Char

[2]
Char
::=
#x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF]
/* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */

The HtmlLogger serializes the TestResult to XML using DCS. DCS is tolerant of these invalid characters -- it will serialize as eg  and read that too. XmlTextWriter will by default serialize the same way. But in default configuration XmlReader will not read it, and throw XmlException causing the production of the Html log to fail.
Fix: set XmlWriterSettings.CheckCharacters to false.
I verified that this fixes the problem locally. I tried hard to make a unit test (see first commit) but concluded that it's not mockable using public API: HtmlTransformer is internal. I guess it could be mocked using reflection or we could use an end to end test instead? I don't have more time to spend, so perhaps it's acceptable without a test.

compare lines in original code:
https://github.com/dotnet/runtime/blob/b00ebc853fdb46425842cf6cae8186d65031e9ef/src/libraries/System.Private.Xml/src/System/Xml/Xslt/XslCompiledTransform.cs#L365-L366
was calling
        public void Transform(string inputUri, string resultsFile)
        {
            ArgumentNullException.ThrowIfNull(inputUri);
            ArgumentNullException.ThrowIfNull(resultsFile);

            // SQLBUDT 276415: Prevent wiping out the content of the input file if the output file is the same
            using XmlReader reader = XmlReader.Create(inputUri);
            using XmlWriter writer = XmlWriter.Create(resultsFile, OutputSettings);
            Transform(reader, null, writer, CreateDefaultResolver());

now calling
        public void Transform(XmlReader input, XmlWriter results)
        {
            ArgumentNullException.ThrowIfNull(input);
            ArgumentNullException.ThrowIfNull(results);

            Transform(input, null, results, CreateDefaultResolver());
        }

I believe OutputSettings above was null.

Thanks, will have a look tomorrow.

in case it's useful in future, here's the half attempt I had at a test, that I gave up on
-    [TestMethod]
-    public void TestCompleteHandlerShouldHandleInvalidCharReferences()
-    {
-        System.Diagnostics.Debugger.Break();
-        VisualStudio.TestPlatform.Extensions.HtmlLogger.HtmlLogger hl = new(_mockFileHelper.Object, new Mock<IHtmlTransformer>().Object, new DataContractSerializer(typeof(TestRunDetails)));
-        hl.Initialize(_events.Object, _parameters);
-
-        MemoryStream xmlStream = new();
-        _mockFileHelper.Setup(x => x.GetStream(It.IsAny<string>(), FileMode.Open, FileAccess.Read)).Returns(xmlStream);
-        _mockFileHelper.Setup(x => x.Exists(It.IsAny<string>())).Returns(false);
-
-        MemoryStream htmlStream = new();
-        _mockFileHelper.Setup(x => x.GetStream(It.IsAny<string>(), FileMode.OpenOrCreate, FileAccess.ReadWrite)).Returns(htmlStream);
-        _mockFileHelper.Setup(x => x.Exists(It.IsAny<string>())).Returns(false);
-
-        var testCase = new TestCase("TestName", new Uri("some://uri"), "TestSource");
-        var testResult = new ObjectModel.TestResult(testCase) { Outcome = TestOutcome.Failed };
-        testResult.Messages.Add(new(TestResultMessage.StandardErrorCategory, "\uFFFF"));
-
-        hl.TestResultHandler(new object(), new TestResultEventArgs(testResult));
-
-        hl.TestRunCompleteHandler(new object(), new TestRunCompleteEventArgs(null, false, true, null, null, null, TimeSpan.Zero));
-
-        //Assert.AreEqual(htmlFileContent, new StreamReader(htmlStream).ReadToEnd());
-    }


Add fpm packaging to x.py

add fpm packaging subcommand ./x.py package fpm
add type annotations for all functions
add --cmake-path to ./x.py build
remove release workflow and package.sh

@PragmaTwice This PR looks good to me and it becomes cleaner that we replace most scripts with x.py, but I'm wondering how we release those binaries after this PR.

I tried to fix the release workflow and upload packages automatically to a draft release in #751.
@tisonkun suggested that we can directly remove the release workflow and move packaging scripts to x.py.
I do not know whether the release vote process and the  release workflow are compatible, maybe we can have a discussion.

Thanks @PragmaTwice, sorry that I didn't have a look at the background.

I think rename x.py to  build.py is better filename for user.

I think rename x.py to build.py is better filename for user.

Hi @xiaobiaozhao, this script is versatile for not just building, for example it can execute code inspection tools, package source code, generate rpm packages, etc. So naming it build.py may not express this meaning well, you can refer to https://github.com/apache/incubator-kvrocks/pull/725 for details.

Hi @tisonkun, could you take a look at the PR while free?


fix compact counter on detecting background access

previously we assume that we don't change these counters after jit begins. however if there's prejit, we mark the counters has been accessed from background thread already and does not allow update, and then with force searialize bytecode, it is updating the counter (searialize ID).
fixing this by block the counter updating only when there's background thread JIT is ongoing, and unblock when the JIT completed

looks #712 is updated correctly (there's no update PR button on chakra hub)


Fix(log): fix compile error when the options --log-info, --log-verbose are enabled

I got errors when I tried to do following commands:
cd trunk
./configure --log-info --log-verbose && make

After checking, there are few parts need to be corrected. Please help to review, thanks.

4.0 最新的代码已经没有问题了。
不过还是要很感谢 @stitch8467 提交PR，感谢 😀


a code security scanner reports a resource leak in qat_hw_ecx.c

hi, openscanhub code security scanner reports a number of resource leaks in the qatengine code:
Defect type: RESOURCE_LEAK
QAT_Engine-1.6.0/qat_hw_ecx.c:557:13: leaked_storage: Freeing "key" without freeing its pointer field "lock" leaks the storage that "lock" points to.
QAT_Engine-1.6.0/qat_hw_ecx.c:315:9: leaked_storage: Freeing "key" without freeing its pointer field "lock" leaks the storage that "lock" points to.
QAT_Engine-1.6.0/qat_hw_ecx.c:249:9: leaked_storage: Freeing "key" without freeing its pointer field "lock" leaks the storage that "lock" points to.
indeed, ECX_KEY *key is allocated and in certain cases its .lock field is initiated and a lock structure is allocated. later, when key is freed by OPENSSL_free(key) then key->lock is not freed but leaked:
ECX_KEY *key = NULL;
key = OPENSSL_zalloc(sizeof(*key));
...
#ifdef QAT_OPENSSL_3
# if OPENSSL_VERSION_NUMBER < 0x30200000
    key->references = 1;
    key->lock = CRYPTO_THREAD_lock_new(); ### key->lock is allocated
# else
    key->references.val = 1;
# endif
#endif
...
OPENSSL_free(key); ### key->lock is leaked

It looks like CRYPTO_THREAD_lock_free() (?? not sure here) should be added to all instances of OPENSSL_free(key).

Hi @nefigtut , thank you for raising the issue. We will look into this.

Can you give the reproduction steps with openscanhub security scanner ?

hi, unfortunately, not. i have used our internal corporate osh instance which is not accessible from the outside. i'm not sure here, osh home page (https://openscanhub.dev/) says:

How to use it? It is running as a Fedora service. Alternatively, you can use it on your local system by following the developer documentation.

alternatively, i believe, i can scan a fixed package in our internal instance.

The mem leak issues had been fixed based on the details you provided. We could not reproduce the issues with the security scanner though. We will release the package in the mid September.

thank you, Venkatesh, most appreciated.


[config] Add default logging filter level to LoggerConfig

Motivation
This PR performs two actions, in two separate commits:

First, it cleans up the common logging code by: (i) removing unnecessary helper functions; and (ii) it renames the default logger creation function to be consistent with the rest of the code.
Second, this PR adds the default logging filter level to the logger config. This is more intuitive than keeping it as a hard coded constant in the logger code.

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
A local run of 'cargo xtest' produces the expected output.
Related PRs
None.

Thanks David! This is ready for another look! 😄

Thanks, David! 😄I've run this with libra-node manually, and verified that the logging levels do indeed change based on the level specified in the config. For example, setting the level to "Off" hides all logs, while "Info" produces the same amount of logging as before the change (i.e. the current state of the master branch). So it appears that the behaviour is as intended.

@bors-libra r=davidiw

:pushpin: Commit d69c33a has been approved by davidiw

:hourglass: Testing commit d69c33a1363da92643ac91ff8729b632a04a62f4 with merge 8eaddb4f334531b8385c28665f8d8768fceed684...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=davidiw (try again -- merge conflict!)

:pushpin: Commit 21582a9 has been approved by davidiw

:hourglass: Testing commit 21582a946549f0f68e6695418966d1fcb6e95a54 with merge 4d02e403910410ee00999d5a5823da18689bb224...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=davidiw (try again -- needed to 'cargo fmt' after merge)

:pushpin: Commit 519417d has been approved by davidiw

:hourglass: Testing commit 519417d11fd99f6f86460e326663babaf488894b with merge c31a5a6179f319eb4c7f4be5155f1c5f0338f0a8...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=davidiw (try again -- transient failure??)

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #2530

:pushpin: Commit 519417d has been approved by davidiw

@bors-libra retry

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2469

:pushpin: Commit 519417d has been approved by davidiw

@bors-libra retry

:hourglass: Testing commit 519417d11fd99f6f86460e326663babaf488894b with merge 523585db0586a6328a102fb97a8bc7c791e362ba...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: davidiw
Pushing 523585db0586a6328a102fb97a8bc7c791e362ba to master...


Adding modules amazonlinuxextras kpatch yumconfiguration

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
I am adding amazonlinuxextras kpatch yumconfiguration modules.
The three modules are collecting the following:

amazonlinuxextras : "amazon-linux-extras list" output that is useful when troubleshooting package related issue
kpatch: "kpatch list" output for troubleshooting kpatch related issue
yumconfiguration: collecting "yum repolist all" and all /etc/yum* configuration files, that are quite useful for troubleshooting package management related issue.

I had meant to review this PR over the weekend but real life got in the way. Haven't gotten--just slightly delayed.

Of course, right as I approve and merge this, I remember the changelog. I'll take care of that separately.


Types for models

When we have a model of a theory, we need some way of telling Julia what types to use for representing the values in that theory. The point of this is not to be precise, but rather to be able to specialize things for performance.
I.e., when we do FinSet, we want to tell Julia that an Ob is an Int, and a morphism is a Vector{Int}. There are several ways of doing this.
The first way is that each model could have an associated module. I.e. something like
module FinSetImpl
const Ob = Int
const Hom = Int
end

The second way is that when you declare a model, you could subtype Model with parameters given by the types of the type constructors. This could be done with a couple variants.
In the first variant, when you declare a theory you would declare an abstract type for models of that theory, parameterized by the type constructors. For instance:
struct FinSetC <: CategoryModel{Int, Vector{Int}}
end

In the second variant, we'd have an abstract type Model with two parameters, one being the theory, and the other being a Tuple of type parameters. For instance:
struct FinSetC <: Model{ThCategory, Tuple{Int, Vector{Int}}}
end

I'm inclined to this last variant, because it seems like it's the most programmable. That is, we don't need to make up any new names like FinSetImpl or CategoryModel. Additionally, generated structs could look something like
struct Arena{Ob, Hom, T <: Model{ThCartesianCategory, Tuple{Ob, Hom}}}
  pos::Ob
  dir::Ob
end

struct FullLens{Ob, Hom, T <: Model{ThCartesianCategory, Tuple{Ob, Hom}}}
  dom::Arena{Ob, Hom, T}
  codom::Arena{Ob, Hom, T}
  expose::Hom
  update::Hom
end

Interested in hearing the thoughts of @epatters, @kris-brown and @jpfairbanks though.

I also like the last variant best. It would be nice to also have instances with type parameters, e.g.
struct MatC{T} <: Model{ThBiproductCategory, Tuple{Int,AbstractMatrix{T}}
end


Player power button on home frame works only once

Enable the interface option to display the power button on the home frame for the current player.
Press the button once, it toggles player state on/off.
Subsequent press does nothing.    (The drop down power buttons do still work however.)
Refreshing the browser page (chrome) gets the button to work again, but only once.
This issue began with a recent update, not sure which one exactly.
Latest LMS 8.3.1 running here perhaps that's it?
Not urgent, just a little annoying
Thanks for the great work on this skin.

This is a material issue, but is already fixed ready for next release.

@waltonbruce 3.0.2 has just been released with this fix.


Apache ActiveMQ CVE-2023-46604

CVE-2023-46604 lists a vulnerability with remote code execution for Active MQ.
The highest version available appears to be 5.15.12.  This is an affected version.  Is there any plan from IBM to remediate this and port a higher version without the RCE vulnerability?

Hi @shup88,
I am building the latest version of Active MQ right now. I will let you know if it looks like we will be able to get an updated RPM out quickly to resolve the CVE.

Hi @markdirish.  Any update on this?
Thank you!

Hi @markdirish. Any update on this?
Thank you!


Point cloud not rendered

Description
Primitives of type POINTS are not displayed.
Steps to Reproduce

Download and unzip model: mickey_mouse_test_color_point_cloud.glb.zip
Go to PlayCanvas viewer: https://playcanvas.github.io/playcanvas-gltf/viewer/
Drag and drop model mickey_mouse_test_color_point_cloud.glb into PlayCanvas viewer.

What I expected to see

What I see instead

It looks like this is actually a bug in the core engine. The engine probably doesn't currently correctly support pc.PRIMITIVE_POINTS. And there's definitely no API to support point size. I'm going to open an issue on this against the engine repo.

To be fair, I don't think there is a nice way to implement point size in the engine IMHO (see my comment). I don't see much point in it ;)

just an update - I tried current version of PlayCanvas and it loads and renders the model. The only issue I see is that the camera does not look at the model when loaded, so you need to look around to find it. I'll see what that is. But point cloud (at least without point size API) works.

Haha, amazing. Looks like I was wrong then. 🤣


Hi, why the tail call always can't run successfully, thanks

Hi, thanks for your wonderful project and sharing. I am trying to run your code but without TRex. I send some dummy GTP packets of N3 and UDP packets of N6 to the running program. The packets can be caught at the entry_point of SEC("xdp_entry_point"), but these packets never can come to SEC("xdp_uplink_entry_point") or SEC("xdp_downlink_entry_point"), and the tail call is always failed.
I am wondering why, and when will you call getUplinkFileDescriptor(). It looks like you don't need to call that to trigger tail call? many thanks for your ideas.

And I am wondering where is SessionProgram::setup() called? I haven't found it been called anywhere, thanks.

Hi Bradley,
I seem that you have been able to run this project and really gone far in running this. However, I was proceeding as per documentation, and is stuck currently. When using command "make install" inside the docker, I am getting issue in compilation of Configuration.cpp file.
On digging further, I understand that this could be the issue with values provided in env.sh wherein SOCKET_BUFFER_ENABLED=0 is provided. Additionally, few other parameters are also there for GTP and UDP interface names.
Can you help me with providing this information, So, that I can compile and run it in my setup.
Thanks

@bradley-code-again, @hrkgarg, Sorry for the late reply. I appreciate that you have been trying to run.  I am without band right now to help you guys. This definitely could have some issue.
@bradley-code-again, did you create the PFCP Session? Check here: https://github.com/navarrothiago/upf-bpf/tree/master/tests/api/requests_body. You can import inside Postman. Usually, three steps are done:

Setup configuration
Create the pfcp session

@hrkgarg, hi, I didn't change anything in env.sh. There is a problem of a cpp file, I changed somewhere manually. I don't remember exactly what I have changes, but it is somewhere auto generated. Read the error carefully, then you may find it.
@navarrothiago, thanks, it works now.


functionality fix

Not sure if this was just an issue for me, but I think  it was because the notes were set to null and it was looking for a string.

Thank you for your contribution @shaineoneal !
I've left some comments, do check them out!


Crash when using harness_platform_environment_group

We are using terraform to configure our NextGen environment, so far for most of the resources it went all good.
But when we set up a  harness_platform_environment_group after its apply, the next attempt starts to crash.
Terraform Version
Terraform v1.5.0
on darwin_arm64
+ provider registry.terraform.io/harness/harness v0.22.1

Affected Resource(s)
Please list the resources as a list, for example:

harness_platform_environment_group

If this issue appears to affect multiple resources, it may be an issue with Terraform's core, so please mention this.
Terraform Configuration Files
resource "harness_platform_environment" "development_a" {
  identifier = "development_a"
  name       = "development_a"
  org_id     = "<org>"
  project_id = "" # IDEA gives warn as mandatory
  type       = "PreProduction"

  yaml       = <<-EOT
  environment:
    name: development_a
    identifier: development_a
    type: PreProduction
    orgIdentifier: <org>
    EOT
}
resource "harness_platform_environment" "development_b" {
  identifier = "development_b"
  name       = "development_b"
  org_id     = "<org>"
  project_id = "" # IDEA gives warn as mandatory
  type       = "PreProduction"

  yaml       = <<-EOT
  environment:
    name: development_b
    identifier: development_b
    type: PreProduction
    orgIdentifier: <org>
    EOT
}

resource "harness_platform_environment_group" "development" {
  identifier = "development_g"
  org_id     = "<org>"
  yaml       = <<-EOT
  environmentGroup:
    name: development_g
    identifier: development_g
    orgIdentifier: <org>
    envIdentifiers: [development_a, development_b]
    EOT
}

Debug Output
Please provider a link to a GitHub Gist containing the complete debug output: https://www.terraform.io/docs/internals/debugging.html. Please do NOT paste the debug output in the issue; just paste a link to the Gist.
Panic Output
harness_platform_environment_group.development: Refreshing state... [id=development_g]
harness_platform_environment.development_a: Refreshing state... [id=development_a]
harness_platform_environment.development_b: Refreshing state... [id=development_b]
╷
│ Error: Plugin did not respond
│
│   with harness_platform_environment.development_a,
│   on environments.tf line 91, in resource "harness_platform_environment" "development_a":
│   91: resource "harness_platform_environment" "development_a" {
│
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│   with harness_platform_environment.development_b,
│   on environments.tf line 106, in resource "harness_platform_environment" "development_b":
│  106: resource "harness_platform_environment" "development_b" {
│
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│   with harness_platform_environment_group.development,
│   on environments.tf line 122, in resource "harness_platform_environment_group" "development":
│  122: resource "harness_platform_environment_group" "development" {
│
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-harness_v0.22.1 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1015c7a80]

goroutine 30 [running]:
github.com/harness/terraform-provider-harness/internal/service/platform/environment_group.resourceEnvironmentGroupRead({0x101b0af88?, 0x14000124780?}, 0x0?, {0x1019cc220?, 0x14000a169c0?})
	github.com/harness/terraform-provider-harness/internal/service/platform/environment_group/resource_environment_group.go:83 +0x210
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x1400052ad20, {0x101b0afc0, 0x14000441e00}, 0xd?, {0x1019cc220, 0x14000a169c0})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:724 +0xec
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0x1400052ad20, {0x101b0afc0, 0x14000441e00}, 0x140003588f0, {0x1019cc220, 0x14000a169c0})
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:1015 +0x46c
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0x14000198168, {0x101b0afc0?, 0x14000441ce0?}, 0x140006ec900)
	github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/grpc_provider.go:613 +0x40c
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadResource(0x140002f60a0, {0x101b0afc0?, 0x14000441320?}, 0x14000124480)
	github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/tf5server/server.go:748 +0x3ec
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler({0x101ab1200?, 0x140002f60a0}, {0x101b0afc0, 0x14000441320}, 0x140002ec1c0, 0x0)
	github.com/hashicorp/terraform-plugin-go@v0.15.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:383 +0x174
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000448000, {0x101b0df60, 0x14000003520}, 0x140000cbc20, 0x140002e5c50, 0x1021759b0, 0x0)
	google.golang.org/grpc@v1.55.0/server.go:1337 +0xc7c
google.golang.org/grpc.(*Server).handleStream(0x14000448000, {0x101b0df60, 0x14000003520}, 0x140000cbc20, 0x0)
	google.golang.org/grpc@v1.55.0/server.go:1714 +0x840
google.golang.org/grpc.(*Server).serveStreams.func1.1()
	google.golang.org/grpc@v1.55.0/server.go:959 +0x88
created by google.golang.org/grpc.(*Server).serveStreams.func1
	google.golang.org/grpc@v1.55.0/server.go:957 +0x170

Error: The terraform-provider-harness_v0.22.1 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

Expected Behavior
What should have happened?
apply would be executed without issue
Actual Behavior
What actually happened?
First apply is fine but it seems to corrupt the statefile and the next attempts crashes even before showing the plan
Steps to Reproduce
Please list the steps required to reproduce the issue, for example:

terraform apply

Important Factoids
Are there anything atypical about your accounts that we should know? For example: Running in EC2 Classic? Custom version of OpenStack? Tight ACLs?
References
Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

GH-1234

This issue is also occurring for harness_platform_usergroup, harness_platform_roles and harness_platform_resource_group
Is there any fix available? Thanks

Thanks for the update. I did try with 0.24.4 for harness_platform_usergroup, harness_platform_roles and harness_platform_resource_group and it fails as my issue is with these resources. Thanks

Please ignore my issue as it was happening because I did use user value as null when creating userGroup. After removing that attribute it worked fine. Thanks.

Tested with the latest version(0.28.2) and it seems fine now
Thanks for the fix!


4.2

http://ffmpeg.org/index.html#pr4.2

You're probably already aware but I think these are failing because of the certificate at the URL's at kent.dl.source...
You can do "curl -sLk ..."
It looks like the failure has been cached in the other variant ;-/
That's terrible, let me find another mirror with valid cert, expired July 20...

Looks like it's just opencore-amr and lame that need a different mirror.
On a separate note, could we add a nvidia variant without "--enable-cuda" but nvenc and cuvid and vaapi enabled?  I'm able to decode and encode with nvdec and hevc_nvenc, hevc_vaapi, etc inside of docker container without the nvidia/cuda base image.  It requires "--runtime=nvidia" at container startup.
I would have submitted a pull request but I wanted to check if you already had a reason not to do it this way?
I have a dockerfile here that shows what I mean:
https://github.com/djaydev/docker-ffmpeg/blob/master/Dockerfile


Assert Enum type equal String

Change branch.
reopen PR https://github.com/graph-gophers/graphql-go/pull/181

Updated code and test case, any suggestion？


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-11-24)
Features

idwt: block proxyium (#87) (87f88bb)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.0
:sunflower:


add diagram that illustrates VM configuration split

Trying to summarize a long text with a small diagram.
Signed-off-by: Arik Hadas<EMAIL_ADDRESS>

@mykaul in [1] (slide 34) we referred to this split in the vm configuration simply as OS-level and host-level. maybe we can avoid the confusion here by using similar terms
http://ahadas.github.io/slides/ram_snapshots.pdf


Need to fix RabbitMQ connectivity / auth

https://github.com/petabridge/akkadotnet-code-samples/tree/master/src/reliability/rabbitmq-backpressure isn't working right now - unable to connect to RabbitMQ docker even when started correctly

Fix is waiting here: https://github.com/akkadotnet/Alpakka/pull/1891


Make Identity an n qubit bloq

fixes #1207

Identity now accepts a bitsize, and has a single register q of QAny(bitsize).
Identity(n).controlled(m) is Identity(n + m).

more discussion: https://github.com/quantumlib/Qualtran/pull/1322#issuecomment-2299989824

I'm still a little confused about why the Identity being a single qubit bloq is problematic, does OnEach(Identity, n).controlled(m) not do the same thing?

I think OnEach(Identity(), n).controlled(m) would probably do the same thing; but I think it's nicer and cleaner to have an n-bit Identity operation that returns itself when controlled.

Ok, should this still be a basic gate? I think the justification for moving it back to basic gates from #1322 was that it was more logically consistent to be among $I$, $X$, $Y$ and $Z$ and basic gates should probably be restricted to one and two qubit gates maybe? Please ignore me if it makes things easier / better / cleaner.

Another subtle issue with OnEach(Identity(), n).controlled(m) is that it would produce m bloqs of OnEach(Identity(), n + 1) (because the control qubits are common), and therefore m * (n + 1) Identity() bloqs. Having a single Identity(n) makes it cleaner imo.

SGTM. Do we need to have both? Probably not right?

both as in?

I'm still a little confused about why the Identity being a single qubit bloq is problematic, doesOnEach(Identity(), n).controlled(m) not do the same thing?

The motivation is that we have an identity bloq (that is somewhat out of our control; e.g. passed as a class attribute; e.g. in applyLthgate) that we want to control. We could return OnEach; but the spirit of qualtran is to give names to things

SGTM. Do we need to have both? Probably not right?

Not 100% sure what's being asked here, but this PR keeps one Identity bloq that has a bitsize that defaults to 1, so there's only one thing to contend with.


NuGet Packages in debug build?

Hello, I've recently started working on a peformance critical C# library and I stumbled upon this library which meets my criteria perfectly, a day later I noticed that Silk.NET has optimizations disabled because this was built with a Debug configuration, Silk.NET focuses on performance yet having JIT optimizations hurts the performance of Silk.NET in production use drastically which makes it one of the slowest bindings library, why is that? I would expect for a NuGet package in "Release" build to be published.

This is a known issue and will be fixed in our update on the first week of March.

Fixed in 2.2.


Can I transfer Gluon-ts model to ONNX model?

Can I transfer Gluon-ts model to ONNX model?

As long as the operators are supported by MXNet ONNX, there should be no problem. Checkout this tutorial to start.

As long as the operators are supported by MXNet ONNX, there should be no problem. Checkout this tutorial to start.

Can you show an example of gluonts to ONNX as the symbol json in Gluonts is different from MXNET. And in GluonTS the serialized predictor saves 5 files and similarly in mxnet it saves 3 files. But the example whihc you referring is working pretty well in MXNET. it will be helpful if you an kindly give some example for GluonTS TO ONNX

Any update on this? An example, please.

Hi there,
Any hints about this transfer are appreciated.

I've moved on from the changes to this project. But in general, you'd want to export the underlying pytorch model to onnx. Afaik the MXNet part is pretty much in active or in the maintenance mode.

Thanks for the quick reply and recommendation. I would try to export the uderlying pytorch model to onnx then. Thanks again.

Thanks for the quick reply and recommendation. I would try to export the uderlying pytorch model to onnx then. Thanks again.

Hi, did you have succed by generating onnx from timeseries in autogluon, gluonts or any other platform?


Event type avail

Changes:

Event type availability component and route added
Updated dashboard to only show active event types for proper rendering of event type availability

This one is stale, sorry!


Can Sell Other Objects Than Wine

...and even other than artisanal goods.

Cannot reproduce?

...and with #44 it's obsolete.


fix(cli): OpenAPI importer handles arbitrary content types instead of skipping

This pull request introduces a fix to the OpenAPI importer's handling of content types. Previously, the importer would ignore parsing arbitrary content types "/", but now it treats this content type as application/json.

The changelogEntry field in versions.yml has been updated to reflect this change.
The getApplicationJsonSchemaMediaObject function in getApplicationJsonSchema.ts now includes a check for the "/" content type.

Approved to unblock, but are there any docs you could link in a comment that explain */*? Couldn't find anything on a quick search

Yup --
https://swagger.io/docs/specification/media-types/


Set isLibrary to true

Lapiz does nothing on its own. isLibrary tells the mod manager to remove the qmod if there are no mods referencing it.

What is the motivation behind this? SongCore requires Lapiz to be installed, no matter what anyway?

isLibrary is used for things such as BeatMods3 to check if a user should manage it. Also proper practice for the qmod ecosystem.


WFLY-9529: setup ee naming context and platform bindings for ear modu…

…les + add ee concurrency context setup action to weld setup actions
Issue: https://issues.jboss.org/browse/WFLY-9529

please do not merge

@stuartwdouglas do you foresee any issue in what this introduces, i.e having a naming context setup for ear modules too, similar to war modules but with just the "ee platform" bindings common to all naming contexts? I believe this is the simplest solution to fix the handling of CDI app initialised/destroyed events, by non ejb CDI components in ear modules. The alternative would be to intercept around the event handling and find out the naming context selector for the module of handler class, and set it up, which I couldn't find a way to do (yet I am not very familiar with Weld integration). The linked JIRA is a good showcase of what's wrong right now, the handling of such events is atm not properly setup wrt naming and ee concurrency.
This PR also adds the setup action of EE Concurrency to CDI, but I believe that's a peaceful change.

never mind I found an issue with module names clashing


⚠ TiendaEnLinea has degraded performance

In 6a3782e, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 5605 ms

Resolved: TiendaEnLinea performance has improved in f71d963.


Whatever i search to play it says "Could not play track! Your request yielded no results"

📝 Description
Title says it all. The console logs are not saying anything.
🪜 Reproduction Steps

Boot up the bot correctly
Try any entry for search or youtube url
See error.

 They've been getting stricter on this.
Try to download a video using yt-dlp on your host machine. If you get this error, then it's most probably your IP:
Sign in to confirm you’re not a bot. This helps protect our community. Learn more


Invoke start callback after request is parsed

I have a scenario where I need the connection info in the start callback. Right now connection info is always null since the thing is invoked.
var wss = new WebSocketServer("ws://localhost:8181");
wss.Start(socket =>
{
    if (socket.ConnectionInfo == null)
    {
        Console.WriteLine("Connection info is null here");
    }
});

The above code will always print "Connection info is null here". I've fixed this in my fork but haven't spent much time running tests as I wanted to run it by you first. The change is pretty small:
https://github.com/davidfowl/Fleck/commit/2c391eca626cd5ca8c8d40c52ded2dc7e9d312ec
Let me know if you need me to do anything else, I'll be happy to send a pull request.

Could you explain the scenario? Also, be aware that the within the Start() callback, the handshake has not successfully completed; it could be a completely bogus request. It was designed more for setting up the callbacks than anything.

Sure, I'm trying to get SignalR working with Fleck (and I have it working in my fork). Basically I need to subscribe to events based on the request path. Here's what the code looks like:
wss.Start(socket =>
{
    PersistentConnection connection;
    if (server.TryGetConnection(socket.ConnectionInfo.Path, out connection))
    {
        var req = new SocketRequest(socket.ConnectionInfo, wss.IsSecure);
        var hostContext = new HostContext(req, null, null);

        hostContext.Items["Fleck.IWebSocketConnection"] = socket;
        try
        {
            connection.ProcessRequestAsync(hostContext).ContinueWith(task =>
            {
                Console.WriteLine(task.Exception.GetBaseException());
            },
            TaskContinuationOptions.OnlyOnFaulted);
        }
        catch (Exception ex)
        {
            Console.WriteLine(ex.ToString());
        }
    }
    else
    {
        socket.Close();
    }
});

So the scenario is that I need request info to get a specific connection for a path and then subscribe the events.

Makes sense. It's nice to see the ways people are using Fleck.
I took a look at your branch, and I prefer having the initialize passed into the constructor of WebSocketConnection (like here).
If you wouldn't mind rebasing (just pushed a small, but important fix), and writing a test or two, I'll definitely pull in the changes.

Sure, I think I'll do the changes over and write some tests.
Thanks!

Posted the fleck sample here:
https://github.com/davidfowl/SignalR.Fleck
Thanks!


Failure with Python 2.7

Failure of PyCropML on appveyor: https://ci.appveyor.com/project/openalea/pycrop2ml/build/job/y3mwsgjukwdwbyvr
Executing: conda.exe build  --python=27 ..\conda
'conda.exe' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1
call on_failure.bat

The same issue with openalea.core:

conda.exe build  --python=2. ..\conda

The PYTHON VERSION is wrong (2. rather than 27)
Use the CONDA_PY env var instead:
doc

@pradal Normally PYTHON_VERSION should be formatted as 2.7 while CONDA_PY should be 27.
CONDA_PY should be set as env variable while PYTHON_VERSION is passed as argument to conda build --python.
It seems that default detection of PYTHON_VERSION is buggy and should not gives 2.

Look at upstream repo:
Pierre add a file python_version.py.
And it call the generated script in the build_script

But if I set PYTHON_VERSION, I have yet the error.
It is just afer

Configuring Windows SDK "v7.0" for Python 2 on a 64 bit architecture
Setting SDK environment relative to C:\Program Files\Microsoft SDKs\Windows\v7.0.
Targeting Windows 7 x64 RELEASE

Perhaps this disable the conda env?


Cannot find ANY instruction on how to RENAME a wiki page & navigation links on dev.azure.com

Hi Guys,
Would you be able to point me towards some instruction on how to rename a navigation 'page link' in dev.azure.com please?
i.e. is it simply a matter of getting the right permissions?
Info: if it makes any difference we have enterprise subscription licenses and are able to create new pages but there don't appear to be any options to rename a page (& navigation link) after creation?
(PS: any option to add screenshots here that I'm not seeing?)
Interested to know,
Thanks,
Steve.
<EMAIL_ADDRESS>0434850541

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7892ee5-8b56-bd95-29bb-41ebb8a8bd7e
Version Independent ID: eccf0785-0968-d6a2-d29e-0c4796aa165c
Content: Add, edit, reorder and manage wiki pages in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/add-edit-wiki.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @swalkersbw, Thanks for reaching out! From your wiki page, select Edit (top right corner of your screen), change the page title, and then select Save. Did I get your ask right? Is this helpful?


Outdated tutorials for responses

https://developers.google.com/actions/assistant/responses
Tutorials on this page are outdated, cannot run any SimpleResponse, BasicCard, BrowseCarousel, BrowseCarouselItem. Hard to work with to learn

Hi,
You may need extra conv.ask() when you use that page.
For example:
conv.ask("Hello"); conv.ask(new Suggestions(["Suggestion 1", "Suggestion 2", "Suggestion 3"]));

I got it working. It seems we have to add string parameter for all Cards
" conv.ask(Here's the color,new BasicCard({  text: 'This is a basic card.'}));'


[add-resource] New Plugin

I would like to add my new plugin to the Grav Repository.
Here are the project details: https://github.com/krzysztofgal/GravGdprPrivacySetupPlugin

added to GPM


fix: Fix typo

Why are these changes needed?
Just fix some typo.

@microsoft-github-policy-service agree


VirtualMachineSize does not show NIC data

VirtualMachineSize displays cpu, ram, and disk info, but does not show any information about number of NICs supported.

Even though msdn doc shows number of NICs corresponds to each size, this property is not yet exposed in the rest api https://github.com/Azure/azure-rest-api-specs/blob/master/arm-compute/2016-03-30/swagger/compute.json#L2640.
Let me check with compute team about their plan for exposing this property.

Thank you. Being able to live query available sizes for a region and getting all information about the size is much more efficient than doing so and comparing to known data

Unfortunately number of NIC supported is still not exposed in the VirtualMachineSize model, latest swagger model is here

not actionable until the Compute service exposes access to this programmatically

still not supported.

Cleaning up old issues from 2016 - 2018. Please reactivate this if it is still a problem.


Replace "compile" with "implementation"

This fixes a warning generated when building this project. For more details see here: http://d.android.com/r/tools/update-dependency-configurations.html

Thank you very much 💃


Specify pip3 install during installation

In order to install deps properly (to be able to execute the script with python3), requirements need to be handled using pip3 instead of pip.

Hello Xh4H,
Thank you for this pull request. You have made the first pull request on this repository! And I agree with you as this program works with Python 3, pip should be changed to pip3.
Thanks and have a great day,
Tapan


fix scrolling to the highlighted results on first open

This pull request includes a

[x] Bug fix
[ ] New feature
[ ] Translation

The following changes were made

added a call to ensureHighlightVisible() after the hightlight classes have been set

#3956 and #4204

I can merge this after I do some smoke testing, to make sure it doesn't break anything. And if possible, I might write up a unit test to make sure we don't have this issue in the future.
If you're interested in writing up the unit test, then this will definitely be merged in time for 4.0.3.

This ended up being fixed by https://github.com/select2/select2/pull/4238.


<EMAIL_ADDRESS>

I hope everything is going well. But I can't believe all this support..thanks alls

Edit