Runtime error when running tensorflow.python.ops.gen_nn_ops.in_top_kv2

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
2.10.0
Custom Code
Yes
OS Platform and Distribution
22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Probably due to negative argument

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
from tensorflow.python.ops import gen_nn_ops
try:
  try:
    with tf.device('/CPU'):
      arg_0_tensor = tf.saturate_cast(tf.random.uniform([3], minval=0, maxval=2, dtype=tf.int64), dtype=tf.int16)
      arg_0 = tf.identity(arg_0_tensor)
      arg_1_tensor = tf.saturate_cast(tf.random.uniform([3], minval=-256, maxval=257, dtype=tf.int64), dtype=tf.uint64)
      arg_1 = tf.identity(arg_1_tensor)
      arg_2 = -285
      out = gen_nn_ops.in_top_kv2(arg_0,arg_1,arg_2,)
  except Exception as e:
    print("Error:"+str(e))
  try:
    with tf.device('/GPU:0'):
      arg_0 = tf.identity(arg_0_tensor)
      arg_0 = tf.cast(arg_0, tf.int16)
      arg_1 = tf.identity(arg_1_tensor)
      arg_1 = tf.cast(arg_1, tf.uint64)
      gen_nn_ops.in_top_kv2(arg_0,arg_1,arg_2,)
  except Exception as e:
    print("Error:"+str(e))
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-01-21 14:05:29.559915: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-21 14:05:29.674650: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-01-21 14:05:30.265706: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 14:05:30.265897: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 14:05:30.265906: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-01-21 14:05:30.887927: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-21 14:05:30.916555: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudnn.so.8'; dlerror: libcudnn.so.8: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/
2023-01-21 14:05:30.916572: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1934] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2023-01-21 14:05:30.916825: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
Error:can't convert negative int to unsigned
Error:can't convert negative int to unsigned

</details>

@nimashiri As the error suggests, conversion to tf.uint64 from tf.int64 can lead to error as uint expects positive input.
Also, as per documentation, the arg_1_tensor (predictions) must be 2 dimensional tensor(batch_size x classes). Please refer to the documentation for valid intputs. Thank you.

@pjpratik  vulnerabilities occur when invalid arguments are being sent to APIs. So your reply here is wrong.
@nimashiri this is not a vulnerability, you're receiving a user error. Please consult SECURITY.md before sending new reports as very few of them are really actionable (and they should have been submitted via private channels)


enter_chroot: do not export variables that weren't previously exported

COREOS_BUILD_ID is set to a default value in common.sh if unset in the
environment. When entering the chroot this default value should not then
get promoted into the environment. Doing so causes catalyst to re-use
stale builds and multiple build_image runs to conflict with each other.

LGTM


Support no_std

Fixes #5

Are there any issues stopping for this PR to be merged?

It would be nice to see this merged. For now, I'm using a git dependency on this PR.

Totally forgot about this PR, going to merge and bump.


Fix sonar issues

Overview
Fixes bugs and code smells identified by sonar scan:

Add aria-label to tables
Use th scope=row instead of td for first column of statistics table (required some custom styles)
Removed unused imports and empty css files

How it was tested
Ran the showcase app and looked at the tables
Checklist

[x] The title contains a short meaningful summary
[ ] I have added a link to this PR in the Jira issue
[ ] I have described how this was tested
[ ] I have included screen shots for changes that affect the user interface
[ ] I have updated unit tests
[ ] I have run unit tests locally
[ ] I have updated documentation (including README)

Statistics table looks similar to before, but is now using <th scope="row"> for the first column's cells.


Providing credentials for reading objects from a private bucket

Hi, thanks for the amazing work on webdataset! 😊
I want to load a webdataset from a non-publicly accessible bucket. How can I provide the access key id and secret access key to authenticate my requests?
Also, I am using a provider other than AWS or GCS, i.e., NetApp.

WebDataset just uses command line programs, so you provide credentials in whatever way you provide credentials to them.
For builtin protocols like "gs:", WebDataset invokes "gsutil ...", so if "gsutil ..." works from the command line, it works in WebDataset.
For more complex I/O needs, you can use "pipe:command ..." as your URL. Here, "command..." can be any kind of shell command line to read a shard. For complex needs, just use a script as your command. Brace expansion still happens as for all other URLs.

Thanks so much! 👍


Svd_truncate, the returned value when return_err=True

When running Svd_truncate with argument return_err=True, it will return the largest singular value that is truncated. I suggest to return all the truncated singular values. In DMRG the truncation error is defined by summing all the truncated p_i=s_i*s_i where s_i is the singular value. In this way we can compute the truncation error.

I suggest to extend the return_err:
return_err="full" (or simply a integer ) will return all the truncated eigenvalues, for example


Firewall groups in the interface section

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
If one organizes the rules in groups, those groups apply to the interfaces as well.
While in the Firewall/Rules section all groups and interface are visible in the interfaces section interfaces that are member of a group do not appear. One has to search the groups to find the interfaces.
See this example the interface VLAN022_WLANDATA does not appear in the interfaces section because it is a member of a group:

Describe the solution you like
I would prefer to see all interfaces in the interfaces section immediately.
I even want to ask why are the groups displayed in the interfaces section at all?
Describe alternatives you considered
No groups but all interfaces in the interfaces section.

not really possible due to the number of levels the menu supports.

never mind, you want to remove the groups in the interfaces, not adding them in the rules. Not likely going to happen, the extra grouping was a feature introduced a long time ago not planning to revert it.

The idea (which was discussed and explained before) was to reduce the number of entries in the interfaces submenu, which it still does.
We discussed preventing grouping in the menu as an additional group option, but I guess we've come a long way without it...
Cheers,
Franco

PS: it was #4016

@fichtner wrote:

We discussed preventing grouping in the menu as an additional group option, but I guess we've come a long way without it...

I would vote for this option because I find it rather tedious to search my interfaces in the groups.
So there's nothing left to but thank you for your immediate support and wish you nice holidays.
Regards,
Bernhard

Hi Bernhard,
I'm not sure it will fit 23.1 timeline, but I’ll try.
Happy holidays!
Franco


fix kubelet flag description

https://github.com/kubernetes/kubernetes/pull/98869

@liuxu623 Please consider split this PR into two, each dedicated to one language. Preferably, hold the zh PR till the en PR is reviewed and merged.

@tengqm done

/assign @savitharaghunathan

/remove-language zh

/lgtm

/sig node

are those reference files auto-generated? Since PR is merged to k/k, is there anything special to review?

@SergeyKanzhelev Yes, they are augo-generated.

/assign

/approve


Remove quartz at WorkerServer

Purpose of the pull request
close #10348
Brief change log
Remove some spring bean at worker

Codecov Report

Merging #10358 (06693f9) into dev (12fdd9b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10358      +/-   ##
============================================
- Coverage     40.44%   40.43%   -0.02%
+ Complexity     4784     4781       -3
============================================
  Files           868      868
  Lines         35369    35369
  Branches       3943     3943
============================================
- Hits          14306    14301       -5
- Misses        19628    19632       +4
- Partials       1435     1436       +1

Impacted Files
Coverage Δ

...e/dolphinscheduler/server/worker/WorkerServer.java
0.00% <ø> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fdd9b...06693f9. Read the comment docs.

Hey @ruanwenjun , @caishunfeng just found that you only rename the files but didn't modify the package names, causing errors in IDE, though it can compile as you didn't change the import reference, can you please modify the package names as well?

@WangJPLeo had found this issue too and had submitted a pr


Google Page Speed Insights Failing with Error

Having trouble getting GPSI working. It doesn't show up in the html or as json.
ERROR: TypeError: Cannot read property 'FIRST_CONTENTFUL_PAINT_MS' of undefined at Object.repackage (/gpsi/lib/pageSummary.js:37:49) at /gpsi/lib/index.js:88

Docker command: --plugins.add analysisstorer --gpsi.key ${GPSI_KEY} -n 1 --webpagetest.host http://localhost:4000 --webpagetest.location Test --video ${URL}
Docker Image: sitespeedio/sitespeed.io:12.6.0-plus1
Strangely enough if I run it again I get no error but no GPSI data anywhere either.

Thank you @dekryptic it really helps with the failing URL! Its fixed in https://github.com/sitespeedio/plugin-gpsi/pull/23 and I will push that in the next release, hopefully tomorrow nigh.

This has been fixed.


Expand Test Utils + Zombienet

Let's model the Zombienet configuration (here is the grammar's new/WIP AST) and integrate it into test-util.
cc @pepoviola

Ongoing list of test feature ideas:

running dev-chain-spawning tests in parallel
collectExtrinsicEvents (introduced in #211) –– perhaps with a slightly different interface.

For testing, it would be nice to specify a node configuration
For example, compiling the polkadot node with cargo build --release --features fast-runtime, creates a binary with shorter Launch/Voting/Enactment periods (see polkadot repo).
I'm not sure if it would be possible to get a new configuration with a runtime upgrade.

For testing, it would be nice to specify a node configuration to speed up some operations.
For example, compiling the polkadot node with cargo build --release --features fast-runtime, creates a binary with shorter Launch/Voting/Enactment periods (see polkadot repo).
I'm not sure if it would be possible to get a new configuration with a runtime upgrade.

Using fast-runtime in our CI is part of this pr. That will produce an image (polkadot-debug) that we can use in zombienet with the fast-runtime.

Another thing to consider is launching polkadot nodes in parallel for testing.
Doing #211, the following was discovered

polkadot --dev --ws-port [port] may not start to listen in the selected port if some other process is listening in that port and it will chose a different port.
A workaround could be to make start a named polkadot node and make an rpc request to get the node name to validate that the node was started successfully in the specified port.
killing a Deno.Process that started a polkadot non-detached docker container does not stop the containerconst p = Deno.run({cmd:["bash", "-c", "docker run --rm parity/polkadot:v0.9.25 --dev"]});
p.kill("SIGKILL");
p.close();

A workaround could be to start the container detached with a name and use the container-id (or name) to be able to do docker stop [id].

Solved by the new dev server approach.


Marge & add unit field to CashuWallet instance

Merged and resolved code from main branch
Added unit field to pass on 'sat' or 'usd'. It defaults to 'sat'
Added integration test case to get active quote from mint.current.fyi

gonna close this since it will get merged here #110


chore: bump for main

Fixes bug in CLI
Fixes provisioning issue in SSM

Codecov Report

Merging #68 (9f8b873) into main (bf3065e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #68   +/-   ##
=========================================
  Coverage     90.13%   90.13%
  Complexity      492      492
=========================================
  Files            69       69
  Lines          2077     2077
  Branches         95       95
=========================================
  Hits           1872     1872
  Misses          170      170
  Partials         35       35

Impacted Files
Coverage Δ

...l/examples/infra/DevicePoolExamplesInfraStack.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3065e...9f8b873. Read the comment docs.


Score Calculation

Hi, I am interested in analyzing open-vocabulary detectors with the zero-shot instance detection task. I read in the paper (Appendix H) how Detic and MDETR were used, but I wanted to clarify if the query scores for the open-vocabulary detectors were computed in the same way as the PACO-trained models (Appendix G). If so, this repo supports such evaluation of open-vocabulary detectors, correct?
Thank you for your time and consideration.

Hi there, thanks for your interest in our paper and code. Yes, the code can be used for evaluation of any open-vocabulary detector.
So if you use 5k queries as prompts and dump scores for detected boxes for each image in a PACO dataset (e.g., paco_lvis_v1_test) to a .npy or .pth file, you can pass it to query_predictions_eval.py script (https://github.com/facebookresearch/paco/blob/12c1dad2e1eca69ed9a8128a23b31ef4302d8610/scripts/query_predictions_eval.py#L21) and it will do the eval on that dataset. The prediction dump format is specified in https://github.com/facebookresearch/paco/blob/12c1dad2e1eca69ed9a8128a23b31ef4302d8610/paco/evaluation/paco_query_evaluation.py#L497-L510.
To answer your question on score calculation, the open-vocabulary detectors directly produce scores for prompts for each of detected bounding boxes. PACO-trained models produce part and attribute scores for each of detected bounding boxes and these scores have to be converted to query scores as described in Appendix G. So the calculation is different but the final output format is the same: a set of boxes and query prediction scores. This allows the same evaluation script to be used for all methods (which is what we did).
Hope you can use it for your eval, let us know if you have any more questions.

Great, thanks for the excellent answer.

Closing the issue, please feel free to reopen it if you have any more questions.


Expand snippet even if the snippet is a suffix of the current symbol

Assume that I have a snippet named today that expands to current
date, like 2021-07-16 Fri. Assuming | denotes the cursor, observe
the following expansions:
Sample text today| -> Sample text 2021-07-16 Fri
today| -> today
[today|] -> [today]

As you can see, the second and third one does not behave as
expected. Second one happens due to some regression introduced in #73.
Third one was never working, because yasnippet is looking for a
keyword named [today. This commit makes them expand as expected:
today| -> 2021-07-16 Fri
[today|] -> [2021-07-16 Fri]

This also works for following scenarios:
aaaatoday| -> aaaa2021-07-16 Fri

Assume that you have another snippet with keyword totoday along with
the today snippet. When you try to expand aaaatotoday|, then
totoday snippet will be expanded instead of the today snippet. The
longest matching snippet wins.

Let me know if there are cases that is is not the wanted behavior.

Thanks! Your second example already worked for me though, except for when at the beginning of the file.


Different certificates (and private keys) for SP signing and encryption

Hello, I am facing an IDP who requires different certificates (and private keys) for singing and encryption. Is it possible to configure my SP in such way with this gem?

Right now at the toolkit you can only register

1 IdP public cert
1 SP public cert and SP private key.

The toolkit publishes the same public cert to allow the IdP to validate Signatures generated by the SP as well as encrypt the SAML Assertions.
Are you sure you are not able to import the generated SP Metadata XML on the IdP side?

Right now at the toolkit you can only register

1 IdP public cert
1 SP public cert and SP private key.

The toolkit publishes the same public cert to allow the IdP to validate Signatures generated by the SP as well as encrypt the SAML Assertions.
Are you sure you are not able to import the generated SP Metadata XML on the IdP side?

@pitbulk yes, I am absolutely sure that we need different SP certificates and private keys for singing and encryption as this is both required and then verified by the IDP.

@pitbulk yes, I am absolutely sure that we need different SP certificates and private keys for singing and encryption as this is both required and then verified by the IDP.

What software is used on the IdP side?
I 'm not aware of this kind restriction of restriction in the SAML standard.
The toolkit right now does not support registering different pairs to sign and decrypt

What software is used on the IdP side?
I 'm not aware of this kind restriction of restriction in the SAML standard.
The toolkit right now does not support registering different pairs to sign and decrypt

I am not sure what kind of software is on the IDP side and it is not relevant as this is a new restriction placed by Slovak eGov (slovensko.sk) IDP. It will take effect in the upcoming months. In other words we can not do anything about it but obey.
Here is a part of the related docs:

The last (highlighted) sentence translates to "Certificate in SP SAML metadata used for encryption must be different from certificate used for signing."
I have verified this with them (twice) and they will simply not register an SP metadata with the same certificates.

I am not sure what kind of software is on the IDP side and it is not relevant as this is a new restriction placed by Slovak eGov (slovensko.sk) IDP. It will take effect in the upcoming months. In other words we can not do anything about it but obey.
Here is a part of the related docs:

The last (highlighted) sentence translates to "Certificate in SP SAML metadata used for encryption must be different from certificate used for signing."
I have verified this with them (twice) and they will simply not register an SP metadata with the same certificates.

I see
P.S Strange that in page 20 appears a screenshot of the regsitered SP and only appears 1 certificate

I see
P.S Strange that in page 20 appears a screenshot of the regsitered SP and only appears 1 certificate

P.S Strange that in page 20 appears a screenshot of the regsitered SP and only appears 1 certificate

Well, the docs are always with some mistakes in this case, but there has been an online workshop addressing this and other upcoming changes, so it is absolutely legit.

P.S Strange that in page 20 appears a screenshot of the regsitered SP and only appears 1 certificate

Well, the docs are always with some mistakes in this case, but there has been an online workshop addressing this and other upcoming changes, so it is absolutely legit.

@pitbulk anyway, are you willing to accept a PR on this issue? I think we can manage to prepare one in the near future.

It depends on how you can implement it and how much complexity will add to the toolkit.

:+1: I also encountered this. This is important to be able to implement key rotation on the SP side.
The requirement should be:

Multiple encryption AND
Multiple signing certs
Each cert having its own private key specific to that cert

Currently, RubySaml implements multiple certs on the IdP side using the idp_cert_multi setting. This is a hash in the format:
setting.idp_cert_multi = { encryption: [cert1, cert2],
                           signing: [cert3, cert4] }

I would like to propose we add sp_cert_multi, however, we also need to add in the private keys. So perhaps it could look like this:
setting.sp_cert_multi = { encryption: [ { cert: cert1, private_key: pk1 }, { cert: cert2, private_key: pk2 } ],
                          signing: [ { cert: cert3, private_key: pk3 }, { cert: cert4, private_key: pk4 } ] }

Thoughts / comments?

I see the use cases different.
At the SP side, we support multiple IdP's certs in order to be able to validate the Signature of the SAMLResponse. Some IdPs support multiple private_ley/certs at the same time, so the scenario of supporting multiple makes sense not only in the cert rotation scenario.
The key rotation on ruby SAML was implemented in a very easy way.
When there is a new private_key/public cert to be used, the public cert is added as
certificate_new setting. Then all IdPs have time to update its metadata and register the new cert.
After that, once all IdPs are updated, SP admin only needs to move the certificate_new value on certificate and remove the certificate_new setting and at the same time, update the new private_key value.  That way, we don't have any interruption on the service.
I don't see the need of a sp_cert_multi/sp_private_key_multi strategy here

I don't understand the requirement from the slovensko.sk IDP requiring 2 different SP certs involved on the signature validation and the encryption process, to be honest. There is no other SAML profile with this kind of requirement. See saml2int

The fact that SAML allows different signing and encryption certs, however silly it may be in practice, still means we ought to support it.

Here is another reason why this should be supported.
https://ec.europa.eu/cefdigital/wiki/download/attachments/82773108/eIDAS Cryptographic Requirement v.1.2 Final.pdf?version=2&modificationDate=1571068651805&api=v2

@pitbulk any further thoughts on this?

@pavolzbell @jsuchal I've implemented this here: https://github.com/SAML-Toolkits/ruby-saml/pull/673
I've added lots of test cases so I'm fairly confident in it. Please try it out.

@johnnyshields : My project also needs signing/encryption certificates, when will it release?

@ducthien1490 you can use my branch here. The merge/release is up to @pitbulk as the project maintaier.

I plan to add this on next release.


migrate utils and devices

Migrate devices.dart and utils.dart to null safety.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hello @jmagman
can you please review this PR?
Thanks

@Abhishek01039 Thanks for working on all these null safety migrations, but please stop personally pinging me to review them.  I'm not always the right person, and we want to spread the workload around.  Pull request triage processes will pick them up. 🙂

Thanks for the contribution, but looks like these files have already been migrated elsewhere.


add compare to crypto system buf

PR summary
adds compare function to crypto-system Buffer trait, and copies over the implementation for sodium secure buffer and does a bad implementation for u8 buffer.

@neonphog added yet another test to make things clear and I'm quite mystified by the sodium compare algorithm  data seems to show that:
[45, 0] < [0, 1]  and
[45] > [0, 1]
that seems weird to me.

found the issue. It compares right to left, starting from a's size.


Code action, pull module not working in windows

Description:
Code action, pull module not working in windows.
Steps to reproduce:
Try to execute code action for a module that hasn't pulled before.
import wso2/github4

Affected Versions:
1.0.0

Fix is merged https://github.com/ballerina-platform/ballerina-lang/pull/19066


have sdk available as osgi fragment bundle

have sdk available as osgi fragment bundle

see https://github.com/adobe/aio-lib-java/pull/29


Support --publish on debug command

Expected Behavior
When we debug the container, we might need to connect the debugger by tcp
Actual Behavior

Steps to Reproduce the Problem

Specifications

Version:
Platform:

Good idea :-) It's a relatively straight forward enhancement, so if you want to try adding it this could be a nice opportunity to contribute. If you don't have cycles at this point in time then I'll be able to add it in a week or so.

The case is I want to generate a local port randomly, then use delve or gdb remote mode, listen this port on the debug container.
Then my vscode or something else can debug through this port.
I have no idea how to support this for all the platforms. The first case is k8s.

The k8s runtime is a bit more involved compared to the other runtimes because it's using ephemeral containers and those don't support exposing ports. With k8s there'll need to be a port forwarder component that does the I/O through the standard I/O interface you get and then it would need to setup a local port listener on the client machine, so you'd connect to it with VSCode instead of connecting to the remote container. It's definitely doable, but it's a bit more work :-)


python312Packages.tencentcloud-sdk-python: 3.0.1272 -> 3.0.1273

Diff: https://github.com/TencentCloud/tencentcloud-sdk-python/compare/refs/tags/3.0.1272...3.0.1273
Changelog: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/3.0.1273/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 359777

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.tencentcloud-sdk-python
python311Packages.tencentcloud-sdk-python.dist
python312Packages.tencentcloud-sdk-python
python312Packages.tencentcloud-sdk-python.dist


IObit Uninstaller Pro Crack <IP_ADDRESS> + Key Download [Latest]

IObit Uninstaller Pro Crack <IP_ADDRESS> + Key Download [Latest]
IObit Uninstaller Pro Crack Free Download is a powerful uninstall application that helps you easily remove unwanted programs, even if Windows “Add or Remove Programs” fails. In addition to removing unwanted applications, it’s easy to scan and delete residues. The most appealing part is that it generates a recovery image before each uninstall. Using the newly added toolbar to uninstall modules, it helps you completely remove unwanted toolbars.
IObit Uninstaller Pro full version crack can powerfully remove them and delete all the leftovers, including the registry and file directories of some stubborn antivirus programs. It will continue the unfinished uninstall process caused by the system reboot; and it can also create a system restore point before each uninstall to prevent accidents. Sometimes users forget to delete the rest after uninstalling.
Download Now

Download Latest Version
IObit Uninstaller Pro Crack

Download Latest Version
Direct Download IObit Uninstaller Pro SetUp
For any query contact with me. Many Thanks.


Measurement quality

Added functions to check measurement quality. This helps determine if the value read is actually usable.
Tested with example vl53l4cd_simpletest.py replacing line:
print("Distance: {} cm".format(vl53.distance))
by:
print("Status: {:3d} Distance: {:6.2f}cm, Estimated noise: {:6.2f}cm".format(vl53.range_status, vl53.distance, vl53.sigma))

I added a new commit that renames those constants to use shorter names and remove the leading underscore.
The changes look good to me.


Production servers are hitting Stack Overflow access quota

Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] gh-badges NPM package

:beetle: Description
Badge for StackOverflow fails to provide the correct questions intermittently
:link: Link to the badge
https://img.shields.io/stackexchange/stackoverflow/t/point-cloud-library.svg?logo=stackoverflow
Live image:

Discussion: https://github.com/PointCloudLibrary/pcl/issues/3175
:bulb: Possible Solution
This might not be the cause, but caching SO results might prevent a non-response from their end (if that's the cause).
Manually calling the SO API that shields.io is supposed to call results in a correct response which led to this hypothesis.

Hi, thanks for the report!
This is working fine for me locally:
~/c/shields (master|✔) $ npm run badge "https://img.shields.io/stackexchange/stackoverflow/t/point-cloud-library.svg?logo=stackoverflow"

><EMAIL_ADDRESS>badge /Users/pnm/code/shields
> cross-env NODE_CONFIG_ENV=test TRACE_SERVICES=true node scripts/badge-cli.js "https://img.shields.io/stackexchange/stackoverflow/t/point-cloud-library.svg?logo=stackoverflow"

0620125711 FsTokenPersistence configured with /Users/pnm/code/shields/private/github-user-tokens.json
0620125711 Server is starting up: http://localhost:1111/
 Service class  👩🍳
 StackExchangeQuestions
 Named params  🎫
 { stackexchangesite: 'stackoverflow',
  query: 'point-cloud-library' }
 Query params  🖍
 { color: undefined,
  colorA: undefined,
  colorB: undefined,
  label: undefined,
  labelColor: undefined,
  link: undefined,
  logo: 'stackoverflow',
  logoColor: undefined,
  logoPosition: undefined,
  logoWidth: undefined,
  style: undefined }
 Request  🏹
 https://api.stackexchange.com/2.2/tags/point-cloud-library/info
 Response status code  🎯
 200
 Response JSON (before validation)  🎯
{ items:
   [ { has_synonyms: false,
       is_moderator_only: false,
       is_required: false,
       count: 1035,
       name: 'point-cloud-library' } ],
  has_more: false,
  quota_max: 300,
  quota_remaining: 299 }
 Response after validation  🛁
{ items: [ { count: 1035 } ] }
 Service data  🛡
 { label: 'stackoverflow point-cloud-library questions',
  message: '1k',
  color: 'yellowgreen' }
 Rendered badge  🛡
 { label: 'stackoverflow point-cloud-library questions',
  message: '1k',
  color: 'yellowgreen',
  link: [],
  name: 'stackoverflow point-cloud-library questions',
  value: '1k' }

I noticed this:
  quota_max: 300,
  quota_remaining: 299 }

Could we be hitting an API usage limit in production?

Could we be hitting an API usage limit in production?

This seems most likely as I noted above. SO API docs also mention the throttling and quota restrictions.

I found this question/answer more helpful.  It describes the 300 quota max mentioned by @paulmelnikow. It's a daily limit per IP, which seems very low, I'm not surprised we're hitting the limit on our production servers.
I managed to generate an API key quite easily, and indeed the max quota indicated in the response was increased to 10000. I suggest we add support for an optional API token like we have in other services and put a key on the production servers.

@PyvesB JS isn't my strong suit, but I'll see what I can do. Moreover, can we change the unknown to some other message?


sync from kubernetes/kubernetes

/cc @ahmetb
ref https://github.com/kubernetes/kubernetes/pull/54577

We actually didn't think of an OWNERS model for this repo (i.e. that file does nothing right now).
@sebgoa and myself are like the current OWNERS. We should probably rethink what we'll do here. Thoughts?


Missing links in docs and energy system supply chain diagram needed

From A. schlueter's communication: Today was the ENSCC kickoff (spacergy). Some of the other research groups were interested to learn more. They were especially interested in the supply models and if / how they could contribute. Now I checked the documentation but the links do not work: https://architecture-building-systems.gitbooks.io/cea-toolbox-for-arcgis-manual/content/technical_data.html

done


Lint-on the fly disabled but doing it

I disabled linting on the fly in the settings, but it still doing it. I am using the latest version 0.12.1

I'm guessing this is also related to https://github.com/mybuddymichael/linter-elm-make/issues/54


forc test doesn't return with error code if Cargo manifest is invalid

CI is actually failing on 89f2ff1: https://github.com/FuelLabs/sway/runs/6276075112?check_suite_focus=true (see "Run test project's test suite" job).
error: failed to parse manifest at `/home/runner/work/sway/sway/test-proj/Cargo.toml`

Caused by:
  could not parse input as TOML

Caused by:
  TOML parse error at line 20, column 1
     |
  20 | \n[workspace]
     | ^
  Could not parse the line

But forc test doesn't actually return an error code so it's not picked up by CI. This is a bug in forc.
Originally posted by @adlerjohn in https://github.com/FuelLabs/sway/pull/1461#pullrequestreview-960645066

Maybe I can put down my thought process and we can discuss it. I believe this is happening because the return code of the child process (cargo test process that is created from the forc test command) is currently not fetched. To test this I will be doing:

[ ] Create the test-proj like the CI
[ ] Create a typo in the Cargo.toml in the test-proj
[ ] Run forc test
[ ] Check the return code (I am on a mac so I will try to get it with echo $?)

If I can get a non-zero error code with an invalid Cargo.toml => 👍


Archer VR2100v Only loads first page of devices for device_tracker

Describe the bug
In the WebUI for the Archer VR2100v the connected device list is split across multiple pages, with 5 devices per page.
The integration only loads and shows the devices from the first page.
Logs
Add also all relevant logs from Settings->System->Logs.
Additional Information (please complete the following information)

Router Hardware Version: Archer VR2100v v1 00000000
Router Firmware Version: 1.16.0 0.9.1 v009e.0 Build 230510 Rel.46740n
Home Assistant Version: Core / Docker 2024.6.2
TP-Link Router Integration Component Version: 1.15.1

Hi. As I dont have this router - Would be great if you could add importing devices from other page to https://github.com/AlexandrErohin/TP-Link-Archer-C6U


feat: CI pipeline

Description
Add CI workflow.
PR Type
What kind of change does this PR introduce?

[ ] Bug Fix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Related Issues
Issue Number: N/A
Checklist
Put an "x" in the boxes that apply. You can also add additional tasks if needed.

[x] I have tested the changes locally and they work as expected.
[x] I have added/updated relevant documentation (if applicable).
[x] My code follows the project's coding standards and conventions.
[ ] I have reviewed my own code and ensured it is clear and understandable.
[ ] I have requested a code review from at least one team member.
[ ] I have addressed any feedback received during the code review.
[x] All new and existing tests pass successfully.
[x] I have made sure that the branch is up-to-date with the base branch.

Other information

approve


Xcode error when used in IB

This is directly from the TORoundedButtonExample project.

Thanks for the report @danqing! I thought it was just me having this issue.
I discovered that it was the result of a collision of the framework name in the same build target. I renamed the internal name for the framework and this seems to have fixed it. Please pull the latest version. :)

Error is gone. Thanks!


CamelCaseVariableName: allow-underscore implemented

Sorry for the new Request, but i was forked from manuelpichler/phpmd.

Why the test ist failed? (Sorry for my ignorance)

I don't understand the error, because the file exists?

The test medthod is named testRuleDoesApplyForVariableNameWithUnderscore but the test file and it's class name is called testRuleDoesApplyForVariableNameWithUnderscores with a trailing s.
They need to match.

@eeree if you want to take care of this, feel free 😼

Replaced by https://github.com/phpmd/phpmd/pull/749


The Token can't be used before xxxxx

hi
this is the token : eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJpc3N1ZXIiLCJleHAiOjE2MDkxNDA3MTQsImlhdCI6MTYwOTEzNzExNCwidXNlcm5hbWUiOiJhZG1pbiJ9.UBaAyr3AC0FDaiYY5dtgN_TbYin0s37iILSua9AELkU
error: com.auth0.jwt.exceptions.InvalidClaimException: The Token can't be used before Mon Dec 28 14:31:54 CST 2020.
token debug: {
"iss": "issuer",
"exp":<PHONE_NUMBER>,
"iat":<PHONE_NUMBER>,
"username": "admin"
}
expire time is 2020-12-28 15:31:54, why it say token can't be used before Mon Dec 28 14:31:54 CST 2020 ??? it looks use the iat?
version:
com.auth0
java-jwt
3.10.3

Yes, the "issue at" (iat) claim is checked when you verify a token. See https://github.com/auth0/java-jwt#time-validation. If you need to disable that specific check, you can do so using the following method.

You can also use the inbuild method ignoreIssuedAT().
Java example
JWTVerifier jwtVerifier = JWT.require(algorithm).ignoreIssuedAt().build();

FYI I've submitted an errata request to RFC 7519 to update the spec to explicitly prohibit rejecting tokens with iat from "the future".
Feel free to follow along here: Discussion: JWT tokens containing iat values in the future should not be rejected


can't install in deno

I can successfully install this package using npm, but not using deno add:
$ deno add npm:@danielx/civet
Add npm<EMAIL_ADDRESS>error: Unknown export './unstable-retry' for '<EMAIL_ADDRESS>  Package exports:
 * .
 * ./abortable
 * ./deadline
 * ./debounce
 * ./delay
 * ./mux-async-iterator
 * ./unstable-mux-async-iterator
 * ./pool
 * ./retry
 * ./tee
 * ./unstable-throttle

Is there perhaps an error that NodeJS doesn't detect? Note that @std/async is a Deno package - if you don't support Deno yet, I'm not sure why that's being imported???

That sounds like an error in Deno itself? What version of Deno are you using? I had no trouble in a fresh install:
$ deno add npm:@danielx/civet
Add npm<EMAIL_ADDRESS>
$ deno --version
deno 2.1.1 (stable, release, x86_64-pc-windows-msvc)
v8 <IP_ADDRESS>-rusty
typescript 5.6.2


Update aks module to output identities

These changes use the azurerm_kubernetes_cluster resource's attributes as outputs instead of using the azure cli to get the desired outputs. It also exports the oms_agent_identity which will be required for a future improvement to the use of managed identity.
Issue: #1441
cc: @andrebriggs @jmspring

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

It looks like the automated tests may be hung, let me see what I can do about that.

I was able to provision the azure-msi environment using this branch. Are there other tests that I should be running? Sorry, not sure what the process is for bedrock testing.

It looks like the automated tests may be hung, let me see what I can do about that.

@jpflueger - did you try running the tests in bedrock/tests?  The pipeline seems hung, I will take look when I get a chance.

Adding a comment

/AzurePipelines run


Avoid unidiomatic one-element tuples

Documentation examples and tests contain OneOf<(T,)>-shaped return values:

fn allocate_box() -> Result<Box<u8>, OneOf<(AllocationFailure,)>>
fn send() -> Result<(), OneOf<(Timeout,)>>
fn allocates() -> Result<(), OneOf<(NotEnoughMemory,)>>

You can find all of them using this regex: OneOf<\(\w+,\)>
I'm heavily against using such examples in documentation. No real-world code looks like this. It's always going to be Result<_, T> rather than Result<_, OneOf<(T,)>>. The current examples may falsely imply that the library is unergonomic and requires returning OneOf<(T,)> instead of T.
If you want to showcase broadening, I suggest using real-world patterns like T -> OneOf<(T, U)> or OneOf<(T, U)> -> OneOf<(T, U, V)>, instead of OneOf<(T,)> -> OneOf<(T, U)>. In tests, we can keep that case if you want to cover it, but I'd add a comment that it is unidiomatic and simply covers an edge case.
If you agree in principle, let me know and I'll implement these changes myself.

I prefer to keep the examples as simple as possible for now

This is understandable. This means that we shouldn't add OneOf<(T, U)> -> OneOf<(T, U, V)> examples yet.
But I'd argue that
fn inner -> Result<T, E1> {
    unimplemented!()
}

fn outer -> Result<T, OneOf<(E1, E2)>> {
    inner().map_err(OneOf::new)
}

is actually simpler than the current
fn inner -> Result<T, OneOf<(E1,)>> {
    unimplemented!()
}

fn outer -> Result<T, OneOf<(E1, E2)>> {
    inner().map_err(OneOf::broaden)
}

And if you can imagine applying some of these changes in the future, I suggest keeping the issue open for tracking purposes and discussion


NoneType Error on self.read()

When I get a response without "Content-Length" specified on header the lib shows this:
File "./src/mrequests.py", line 161, in read
TypeError: unsupported types for lt: 'int', 'NoneType'
I had to change the line 232 from
self._cached = self.read(size=None)
to
self._cached = self.read()
Now it works!
https://github.com/SpotlightKid/mrequests/blob/4ba5cc62c5609360c18eb147605680ca66f4dfea/mrequests.py#L232

You don't seem to be using the latest version of the code. Please re-test with the current version in the repo.


Create a feature to find all keys and replace the values

I want a function that takes a key as a string, a dataset and a function to apply to that value.
Example: imagine you need to iterate through a set of data and add left padding to a customer number in a collection / array of objects or single object:
var customers = [  {customerID:"wrongFormat"}  ];
var updateCustomerFormat = function(value) { return "0000" + value; };
customers  = _.update("customerID", customers, updateCustomerFormat);

If I am understanding you correctly, you can already accomplish that with _.map
var customers = [
  {customerID:"wrongFormat"}
];

var updateCustomerFormat = function(value) {
  value.customerID += "0000";
  return value;
};

console.dir(_.map(customers, updateCustomerFormat));

http://jsbin.com/barixoloxe/edit?html,js,console,output

If you want to avoid copying the array you can also use _.each:
_.each(customers, function(value) {
    value.customerID = '0000' + value.customerID;
});

I don't think this use case warrants a whole new function.


Unable to distinguish values from different fields sharing the same ItemKey

Summary
The values read from different fields that all map to the same ItemKey appear in no particular order.
They don't follow the ordering and precedence defined by the mapping macro. This ordering only affects which field gets written, namely only the first one.
API design
No response

Do you mean, for example, an MP4 file that has both a ----:com.apple.iTunes:BPM and a tmpo atom, they could possibly be stored in the tag in the order [tmpo, ----:com.apple.iTunes:BPM] despite the freeform coming first in the mapping macro?
Items are stored in the order they appear in the file, they shouldn't be expected to appear in any particular order. The ordering only matters in the macro to pick out the key to write, alongside possible keys that we can also read.
If there is a different value that can occur between the keys, they should probably have separate ItemKey variants. There should only be multiple keys if you can expect them all to have a similar value, such as in the case of ItemKey::EncodedBy for Vorbis Comments:
https://github.com/Serial-ATA/lofty-rs/blob/f73783aa8af5297d792227078500404f3f297510/src/tag/item.rs#LL336C2-L336C43

Thanks for the clarification.
tmpo/----:com.apple.iTunes:BPM is a special case because here you should write into both atoms, but with different values. The generic code should probably only write integer bpms as the least common denominator.
The most awkward case is TIT1/GRP1, caused by Apple's ignorance and stupidity.

Yet another issue caused by iTunes.
When I first heard about GRP1, I had assumed it was equivalent. I've never worked with these tags myself.
After seeing https://community.mp3tag.de/t/support-for-new-itunes-grouping-id3-frame-grp1/18523/2 though, I think it should have its own ItemKey::Grouping.

...I think it should have its own ItemKey::Grouping.

Probably ItemKey::AppleId3Grouping, as warning in which context this requires special handling and that this ItemKey is only used for ID3 tags. Unfortunately, every application then has to deal with it and decide how to handle the Content Group for ID3 tags.
If they had chosen a new tag identifier for the work name instead everything would be easy, portable, and backwards compatible.

I consider this resolved for now. New ItemKeys for disambiguation could be introduced on demand when required.


fallback load model on CPU in TabularNeuralNetTorchModel

This PR introduces support for loading PyTorch models previously trained on a device (e.g., cuda GPU) not currently available, falling back to CPU mapping of the model state.
Despite being a PyTorch-related issue, we could introduce this temporary fix until the PyTorch community approves the changes, so that it is possible to operate (e.g., visualize, plot, consult architecture, etc.) on GPU-trained models from a device with only CPU (e.g., perform model training/HPO/NAS on GPU-enabled devices/cluster for performance, and then do some post-ops and analysis on the local machine).
For the original PyTorch issue (still open) please refer to https://github.com/pytorch/pytorch/issues/16797
Previous error message
Attempting to load GPU-trained (Cuda) models on a non-GPU-enabled device:
Loading: withgpu/predictor.pkl
Loading: withgpu/learner.pkl
Loading: withgpu/models/trainer.pkl
Loading: withgpu/models/NeuralNetTorch/cd903054/model.pkl
Traceback (most recent call last):
  File "~/scripts/printArchParams.py", line 41, in <module>
    main()
  File "~/scripts/printArchParams.py", line 23, in main
    model = predictor._trainer.load_model(predictor.get_model_best())
  File "~/.venv/lib/python3.9/site-packages/autogluon/core/trainer/abstract_trainer.py", line 1390, in load_model
    return model_type.load(path=path, reset_paths=self.reset_paths)
  File "~/.venv/lib/python3.9/site-packages/autogluon/tabular/models/tabular_nn/torch/tabular_nn_torch.py", line 604, in load
    model: TabularNeuralNetTorchModel = super().load(path=path, reset_paths=reset_paths, verbose=verbose)
  File "~/.venv/lib/python3.9/site-packages/autogluon/core/models/abstract/abstract_model.py", line 1034, in load
    model = load_pkl.load(path=file_path, verbose=verbose)
  File "~/.venv/lib/python3.9/site-packages/autogluon/common/loaders/load_pkl.py", line 43, in load
    object = pickle.load(fin)
  File "~/.venv/lib/python3.9/site-packages/torch/storage.py", line 240, in _load_from_bytes
    return torch.load(io.BytesIO(b))
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 795, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 1012, in _legacy_load
    result = unpickler.load()
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 958, in persistent_load
    wrap_storage=restore_location(obj, location),
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 215, in default_restore_location
    result = fn(storage, location)
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 182, in _cuda_deserialize
    device = validate_cuda_device(location)
  File "~/.venv/lib/python3.9/site-packages/torch/serialization.py", line 166, in validate_cuda_device
    raise RuntimeError('Attempting to deserialize object on a CUDA '
RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.

Description of Changes
Credits to the original PyTorch issue discussion. The change consists of introducing a custom Unpickler class with the find_class method that automatically accounts for introducing the map_location='cpu' to the torch.load function. At this point, the model is loaded in the CPU, despite its original device used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the contribution @s41m0n!! We will target merging this for the next release once we test it out. This feature is much appreciated and will go a long way to making GPU better supported in TabularPredictor!

@yinweisu good catch!
@s41m0n can you test v0.8.2 and see if it fixes the issue you are facing?
@yinweisu The implementation of the fix is pretty different between the two options. We may want to think about which one is more elegant.

@yinweisu good catch!
@s41m0n can you test v0.8.2 and see if it fixes the issue you are facing?
@yinweisu The implementation of the fix is pretty different between the two options. We may want to think about which one is more elegant.

I have tested this behaviour in the 0.8.2 release today and I am still facing problems.
Despite being an elegant solution, the fix introduced in the previous PR does not let me load a GPU-trained model on a CPU-only device. I also tried to patch the following function with no luck :https://github.com/autogluon/autogluon/blob/526bc1754e67d2dbe7b974fe23e813f1422db897/tabular/src/autogluon/tabular/models/tabular_nn/torch/tabular_nn_torch.py#L575
def save(self, path: str = None, verbose=True) -> str:
        import torch

        # Save on CPU to ensure the model can be loaded on a box without GPU
        if self.model is not None:
            device = torch.device('cpu')     # NEWLY INTRODUCED
            self.device = device             # NEWLY INTRODUCED
            self.model.device = device       # NEWLY INTRODUCED
            self.model = self.model.to(device)
        path = super().save(path, verbose)
        # Put the model back to the device after the save
        if self.model is not None:
            self.model.to(self.device)
        return path

Still, when loading back the model the same CUDA error appears. Moreover, when attempting to re-load the model, the knowledge of the previous device used for the training would've been lost with these lines.
Please let me know if I am wrong. It seems that self.model = self.model.to(torch.device('cpu')) is not enough for ensuring safety when loading back the models.
Otherwise, I would be more than glad to proceed with the PR :)

This is interesting if the previous commit didn't fix this issue. It's hard to have unit test for cross system saving and loading, I'll do some manual testing to verify this.
Besides, regarding the verbosity of hpo. Currently, we are not exposing that to the users, I'll create an issue to track this. Thanks for reporting!

@s41m0n I just tried our 0.8.2 release and was able to load a gpu trained model on cpu.
To be more specific, I trained NN_TORCH model with gpu, verified gpu usage through nvidia-smi. Then disable gpu through export CUDA_VISIBLE_DEVICES="". The tried to load the previous trained model after verifying assert torch.cuda.is_available() == False. I was able to load the model correctly.
If you look at the commit that fixed this issue, we always save the model to cpu. It's only during loading that we move the model to the correct device. I guess you were trying to load a model trained in older AG version? Since the saving logic was modified to fix this issue, models trained in previous AG version wouldn't work

Closing as we believe the issue has been fixed in v0.8.2 based on @yinweisu's investigation above. Thanks for the contribution @s41m0n, please let us know if the issue is still present in v0.8.2 by opening a new GitHub issue.


Tutorial 1.1

I've added some bold text and some quotes to highlight the key words.

Thanks for the Pull Request Penca!
I'm made quite a few comments but most of them a one character changes. I really like the addition of backticks, they make it much easier to determine what's code references! Nice work!
I would quite like to reduce the amount of bold used though, I just feel like there's so much that it detracts from the really important bold words you've added! Can I set a rough target for you to halve it? I know that's quite a lot but I think it would reduce a lot of the distraction but still really add to the clarity! 🙂
Thanks for taking the time to edit this!
Jamie

This looks much better I think!
There's sill a few peculiarities with backticks though that would be good to sort out and then we should be there! Nice work 🙂

I've removed some backticks... Tell me if there is anything else to do!

Hey Penca, sorry I've not looked at this sooner!
I'm still not convinced by this, I think you've removed some instances of backticks where they really added to the formatting!
Let me give you some examples. The first, Kill is a really good one to keep as it's the name of a method! Similarly, MouseController, NetworkPlayer, and ControllablePlayer are really good as they're prefab/gameobject /script names but you've removed some of them! Thinks like using DarkRift; and using DarkRift.Server; (in server basics) are also perfect examples of when to use backticks, they're literally code snippets!
The only instances I was concerned about were things like PlayerSpawner component and Network object where you've included both the name of a component/object and also the word after it!
It would be really good if you could revert the last commit and we'll meet in the middle there!
Thanks for the patience!
Jamie

I don't know why there were so many bold texts... that looked like my first commit but after you told me to remove some, I removed some bold texts... strange 😄

Awesome work! 😄


Prowler

Context
Please include relevant motivation and context for this PR.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @tharsiganj, I will close the PR since it may have been opened on accident. Let us know if you wanted to do something else.


What do you think about providing RowApply and + as parts of this library?

This is now in type-prelude. The docs should be updated.


Taskbar attempts to return to default causing a flicker

Description
Taskbar attempts to return to default sizing while application is running causing a flickering.  This is mostly only noticeable while clicking any buttons located on the taskbar.

I had a play around with this, I think the resize is on windows end. You can eliminate the flicker by removing the wait time in the background invoke and making the ApplyStyle function async, but obviously this isn't ideal on CPU usage...
Need a way for the ApplyStyle function to be called if the taskbar is clicked so it doesn't have to wait for the background invoke.

Hey @VincentWillats,
Sorry for the extreme delay in replying to this. There's a high probability that I'll end up rewriting this project at some point, because this was mostly a test-bed to see what all I could do with the taskbar. Spoiler alert: there's a lot you can do. Repositioning the elements of the taskbar is a unique one that I found I haven't seen before. Unfortunately, no matter what I've tried to fix the flicker, there's a drawback. I'm sure there's a way, but knowledge is limited.
Anyway, I'm mostly replying to you because I wanted to 'thank you' for trying to fix the issue! So, thank you!

Hey, you may check out Windows 10 Team. Something similar is implemented there.
https://youtu.be/P_QZc29WWiQ


chore: apply the latest unjs template

I wanted to work on #24, but first I applied the latest unjs template for maintenance.

Can you please check CI/lint issue?


Introduce a fine grained configuration change event

When the configuration change event is emitted, also provide the details about what configuration has changed.

This looks like it fixes my issue?
#23325

@xconverge Yes.


Remove requirements for message initialization "clear" vs "no-clear" options

Is your feature request related to a problem? Please describe.
CFE_MSG_Init no longer supports "clear" vs "no-clear" options due to abstraction incompatibilities.
cSB4315.1 - SB: Initialize Message - Clear
cSB4315.2 - SB: Initialize Message - No Clear
Describe the solution you'd like
Remove these "special option" requirements.  The requirement is that it initializes the packet (cSB4315), the design/implementation describes the exact behavior (there are many possible compliant implementations by design).  Ambiguous options that can not be abstracted should be avoided in the API.
Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC

Closed by #1701 and #1720


Added Quiche.QUICHE_ERR_BUFFER_TOO_SHORT to QuicError

@atropnikov thanks a lot... Can you also sign our ICLA: https://netty.io/s/icla ?

@normanmaurer Done


Unable to build on Mac OS X

I just installed using homebrew, cloned to my machine, ran npm i and then npm run build and got the following error.
ERROR in bundle.js from UglifyJs
SyntaxError: Unexpected token: name (CharacterStream) [./~/graphql-language-service-parser/dist/CharacterStream.js:3,0]

Getting exactly the same error but with ubuntu 20.04

hey, having the same issue on macos big sur
ERROR in bundle.js from UglifyJs


livereload of css and HMR not working

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
It feels like a bug to me but i don't want to stress anybody - the HMR thing is still in developement i guess and maybe it is just work-in-progress..?

What is the current behavior?
Three weeks ago i've initialized a new project with this skeleton project - and the css livereload was working fine. By livereload i mean, he can inject the new css directly into the browser without reloading the page. Now i've upgraded my project with all the new changes and the livereload is broken now, he always reloads the page - on css changes and in typescript (in typescript it was kind of working with the HMR back those days.. it wasn't made with this new angular2-hmr package).

Steps to reproduce

checkout the repo as a new project and npm i, npm start
goto localhost:3000
open up home.css for example and add some css like body { color: red; }
watch webpack rebuilding the package and as soon as he is ready -> the page reloads

What is the expected behavior?
page should not reload at least with css - what the state is with HMR i don't really know.

Please tell us about your environment:

Angular version: 2.0.0-beta.13
latest variant for now with HMR 0.5.1

in the readme you have to run npm start:hmr hmr is off by default

the css for components are also scoped so if you include body { color: red; } it's not going to work since there is not body tag within the home component. You would need to turn off css encapsulation for the component or use a different style value like form { color: red; }

I"m going to close this issue to keep them issue count down but if you still have this problem please reopen it. thanks!

Thanks for your replies! Everything clear so far.. but, how would i turn off css encapsulation for a component?
My problem is, i try to use Sass together with Bootstrap. I know it would be perfect in ES6 modules to import the css for every component directly in the components code. But then i don't know all the variables/classes inside my component script - then i have to import everything needed over and over again in every component (which is not wrong as i read about ES6 modules). But this results in having bootstrap included several times in the final package - and then i have to de-dup everything? This feels totally wrong to me.
So i got another approach - i'm importing my scss only at one single point in the whole app - in my bootstrapping "main.browser.ts" -> and my basic scss is importing bootstrap, and all subsequent scss files of all components. This way i end up having all classes/variables everywhere available and i import boostrap only once and don't have to de-dup in the end. Now the only thing "disturbing" here is the css encapsulation i guess.
Isn't the encapsulation controlled by the imports...? Or is there really an optional flag or something for my webpack configuration?


Refactoring some code?

Clear some unused comments?
Using something like this to shorten the code? (with some kind of default values)

Example
#!/bin/sh
# https://www.shellcheck.net/
DEBUG=0             # 0 no debug, 1 show getColor value
DEFAULT_SLEEP=2     # equivalent to wait

# inputTap <X> <Y>
inputTap() {
    input tap "$1" "$2"                 # tap
}

# inputTapSleep <X> <Y> <SLEEP>
# SLEEP default value is DEFAULT_SLEEP
inputTapSleep() {
    inputTap "$1" "$2"                  # tap
    sleep "${3:-DEFAULT_SLEEP}"         # sleep
}

# testColor <X> <Y> <COLOR>
# if true, return 1, else 0
testColor() {
    getColor "$1" "$2"                  # looking for color
    if [ $DEBUG -ge 1 ]; then echo "[DEBUG] getColor $1 $2 > RGB: $RGB"; fi
    test "$([ "$RGB" = "$3" ])"         # color found?
    echo "$?"                           # print result of previous command
}

# testColor2 <X> <Y> <COLOR> <COLOR>
# if true, return 1, else 0
testColor2() {
    getColor "$1" "$2"                                      # looking for color
    if [ $DEBUG -ge 1 ]; then echo "[DEBUG] getColor $1 $2 > RGB: $RGB"; fi
    test "$([ "$RGB" = "$3" ] || [ "$RGB" = "$4" ])"        # color found?
    echo "$?"                                               # print result of previous command
}

# testColorTapSleep <X> <Y> <COLOR> <SLEEP>
# SLEEP default value is DEFAULT_SLEEP
# if true, tap, else do nothing
testColorTapSleep() {
    if testColor "$1" "$2" "$3" > /dev/null; then           # if color found
        inputTapSleep  "$1" "$2" "${4:-DEFAULT_SLEEP}"      # tap & sleep
    fi
}

PS: I don't remember how to hide the echo of testColor in test... so I use > /dev/null

Fix some bad practices (https://www.shellcheck.net/)
-- fixing some risky calls by adding || exit
-- removing function  or removing ()
-- replacing most of == by =
-- adding/removing "
-- complete list:

deploy.sh
$ shellcheck myscript

Line 6:
source ./lib/print.sh
     ^-- SC1091: Not following: ./lib/print.sh was not specified as input (see shellcheck -x).

Line 48:
          cd ./adb  # Change to new directory
          ^-- SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: (apply this, apply all SC2164)
          cd ./adb || exit  # Change to new directory

Line 77:
          cd ..                        # Change directory back
          ^-- SC2103: Use a ( subshell ) to avoid having to cd back.

Line 152:
  source config.sh
         ^-- SC1091: Not following: config.sh was not specified as input (see shellcheck -x).

Line 193:
  printTask "Checking Line endings of file ${cBlue}$1${cNc}..."
                                           ^-- SC2154: cBlue is referenced but not assigned.
                                                     ^-- SC2154: cNc is referenced but not assigned.

Line 194:
  if [[ $(head -1 $1 | cat -A) =~ \^M ]]; then
                  ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
  if [[ $(head -1 "$1" | cat -A) =~ \^M ]]; then

Line 197:
      dos2unix $1 2>/dev/null
               ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      dos2unix "$1" 2>/dev/null

Line 199:
      if [[ $(head -1 $1 | cat -A) =~ \^M ]]; then
                      ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      if [[ $(head -1 "$1" | cat -A) =~ \^M ]]; then

Line 273:
              let "difference = $now - $value" # Time since last beat campaign
              ^-- SC2219: Instead of 'let expr', prefer (( expr )) .

Line 276:
              if [ $difference -gt 255600 ]; then
                   ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
              if [ "$difference" -gt 255600 ]; then

Line 285:
              echo $(date +"%s") > .afkscript.tmp # Write date to file
                   ^-- SC2046: Quote this to prevent word splitting.
                   ^-- SC2005: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'.

afk-daily.sh.sh
$ shellcheck myscript

Line 16:
  source /$1/scripts/afk-arena/config.sh
  ^-- SC3046: In POSIX sh, 'source' in place of '.' is undefined.
         ^-- SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
          ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
  source /"$1"/scripts/afk-arena/config.sh

Line 21:
  source /storage/emulated/0/scripts/afk-arena/config.sh
  ^-- SC3046: In POSIX sh, 'source' in place of '.' is undefined.
         ^-- SC1091: Not following: /storage/emulated/0/scripts/afk-arena/config.sh was not specified as input (see shellcheck -x).

Line 26:
function test() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 27:
  local COUNT=0
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 29:
      sleep $4
            ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      sleep "$4"

Line 32:
      ((COUNT = COUNT + 1)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 38:
function wait() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 43:
function startApp() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 50:
function closeApp() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 55:
function switchApp() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 61:
function disableOrientation() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 66:
function takeScreenshot() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 71:
function readRGB() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 72:
  let offset="$DEVICEWIDTH"*"$2"+"$1"+3
  ^-- SC3039: In POSIX sh, 'let' is undefined.

Line 74:
  RGB=${RGB:9:9}
      ^-- SC3057: In POSIX sh, string indexing is undefined.

Line 75:
  RGB="${RGB// /}"
       ^-- SC3060: In POSIX sh, string replacement is undefined.

Line 80:
function getColor() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 86:
function verifyRGB() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 89:
      echo "[ERROR] VerifyRGB: Failure! Expected "$3", but got "$RGB" instead."
                                                  ^-- SC2027: The surrounding quotes actually unquote this. Remove or escape them.
                                                  ^-- SC2086: Double quote to prevent globbing and word splitting.
>>                                                                ^-- SC2027: The surrounding quotes actually unquote this. Remove or escape them.
>>                                                                ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      echo "[ERROR] VerifyRGB: Failure! Expected ""$3"", but got ""$RGB"" instead."

Line 99:
function switchTab() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 125:
function loopUntilRGB() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 127:
  getColor $2 $3
           ^-- SC2086: Double quote to prevent globbing and word splitting.
              ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
  getColor "$2" "$3"

Line 130:
      getColor $2 $3
               ^-- SC2086: Double quote to prevent globbing and word splitting.
                  ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      getColor "$2" "$3"

Line 135:
function loopUntilNotRGB() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 137:
  getColor $2 $3
           ^-- SC2086: Double quote to prevent globbing and word splitting.
              ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
  getColor "$2" "$3"

Line 138:
  while [ "$RGB" == "$4" ]; do
                 ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 140:
      getColor $2 $3
               ^-- SC2086: Double quote to prevent globbing and word splitting.
                  ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      getColor "$2" "$3"

Line 145:
function waitBattleFinish() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 147:
  local finished=false
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 148:
  while [ $finished == false ]; do
                    ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 150:
      if [ "$RGB" == "b8894d" ] || [ "$RGB" == "b7894c" ]; then # First RGB local device, second bluestacks
                  ^-- SC3014: In POSIX sh, == in place of = is undefined.
                                            ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 154:
      elif [ "$RGB" == "171932" ]; then
                    ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 158:
      elif [ "$RGB" == "45331d" ] || [ "$RGB" == "44331c" ]; then # First RGB local device, second bluestacks
                    ^-- SC3014: In POSIX sh, == in place of = is undefined.
                                              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 168:
function buyStoreItem() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 169:
  input tap $1 $2
            ^-- SC2086: Double quote to prevent globbing and word splitting.
               ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
  input tap "$1" "$2"

Line 177:
function oakSearchPresent() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 183:
  if [ "$RGB" == "833f0e" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 192:
      if [ "$RGB" == "a21a1a" ]; then
                  ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 201:
          if [ "$RGB" == "aa2b27" ]; then
                      ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 210:
              if [ "$RGB" == "bc3f36" ]; then
                          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 219:
                  if [ "$RGB" == "bb3734" ]; then
                              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 237:
function oakPresentTab() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 240:
  if [ "$RGB" == "c79663" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 241:
      ((oakPresentTabs = oakPresentTabs + 1000)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 244:
  if [ "$RGB" == "bb824f" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 245:
      ((oakPresentTabs = oakPresentTabs + 200)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 248:
  if [ "$RGB" == "af6e3b" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 249:
      ((oakPresentTabs = oakPresentTabs + 30)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 252:
  if [ "$RGB" == "b57b45" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 253:
      ((oakPresentTabs = oakPresentTabs + 4)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 258:
function oakTryCollectPresent() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 261:
  if [ $oakRes == 0 ]; then
               ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 282:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 297:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 307:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 317:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 321:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 337:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 347:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 357:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 361:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 372:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 382:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 386:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 397:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 401:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 412:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 416:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 420:
                  if [ $oakRes == 0 ]; then
                               ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 433:
function checkWhereToEnd() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 434:
  case "$endAt" in
        ^-- SC2154: endAt is referenced but not assigned.

Line 467:
      if [ "$pvpEvent" == false ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 480:
function quickBattleGuildBosses() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 481:
  local COUNT=0
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 482:
  until [ "$COUNT" -ge "$totalAmountGuildBossTries" ]; do
                        ^-- SC2154: totalAmountGuildBossTries is referenced but not assigned.

Line 490:
      ((COUNT = COUNT + 1)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 495:
function lootAfkChest() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 510:
function challengeBoss() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 516:
  if [ "$RGB" == "f2d79f" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 522:
  if [ "$forceFightCampaign" == "true" ]; then
                             ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 524:
      echo "[INFO] Figthing in campaign because of Mythic Trick $maxCampaignFights time(s)."
>>                                                                ^-- SC2154: maxCampaignFights is referenced but not assigned.

Line 525:
      local COUNT=0
      ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 529:
      while [ "$RGB" == "eaca95" ] && [ "$COUNT" -lt "$maxCampaignFights" ]; do
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 534:
          if [ "$battleFailed" == false ]; then # Win
                               ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 537:
              if [ "$RGB" == "e2dddc" ]; then
                          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 548:
                  if [ "$RGB" == "f2d79f" ]; then
                              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 561:
              ((COUNT = COUNT + 1)) # Increment
              ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 574:
      if [ "$RGB" == "feffff" ]; then
                  ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 599:
function fastRewards() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 613:
function collectFriendsAndMercenaries() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 636:
function soloBounties() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 691:
  if [ "$doTeamBounties" == false ]; then
        ^-- SC2154: doTeamBounties is referenced but not assigned.
                         ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 703:
function teamBounties() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 705:
  if [ "$1" == true ]; then
            ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 748:
function arenaOfHeroes() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 751:
  if [ "$pvpEvent" == false ]; then
                   ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 768:
      local COUNT=0
      ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 769:
      until [ "$COUNT" -ge "$totalAmountArenaTries" ]; do
                            ^-- SC2154: totalAmountArenaTries is referenced but not assigned.

Line 774:
          case $arenaHeroesOpponent in
               ^-- SC2154: arenaHeroesOpponent is referenced but not assigned.

Line 794:
          if [ "$battleFailed" == false ]; then
                               ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 800:
          ((COUNT = COUNT + 1)) # Increment
          ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 810:
  if [ "$doLegendsTournament" == false ]; then
        ^-- SC2154: doLegendsTournament is referenced but not assigned.
                              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 824:
function legendsTournament() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 826:
  if [ "$1" == true ]; then
            ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 834:
  if [ "$pvpEvent" == false ]; then
                   ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 850:
  local COUNT=0
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 862:
      ((COUNT = COUNT + 1)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 874:
function kingsTower() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 896:
function guildHunts() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 902:
  if [ "$RGB" == "793929" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 924:
  local COUNT=0
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 941:
      ((COUNT = COUNT + 1)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 950:
  if [ "$RGB" == "8ae5c4" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 954:
  elif [ "$canOpenSoren" == true ]; then
          ^-- SC2154: canOpenSoren is referenced but not assigned.
                         ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 958:
      if [ "$RGB" == "fae0ac" ]; then
                  ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 968:
  if [ "$doGuildHunts" == false ]; then
        ^-- SC2154: doGuildHunts is referenced but not assigned.
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 982:
function twistedRealmBoss() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 986:
  if [ "$1" == true ]; then
            ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1000:
  if [ "$RGB" == "9aedc1" ]; then
              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1026:
function buyFromStore() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1031:
  if [ "$buyStoreDust" == true ]; then
        ^-- SC2154: buyStoreDust is referenced but not assigned.
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1036:
  if [ "$buyStorePoeCoins" == true ]; then
        ^-- SC2154: buyStorePoeCoins is referenced but not assigned.
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1041:
  if [ "$buyStoreEmblems" == true ]; then
        ^-- SC2154: buyStoreEmblems is referenced but not assigned.
                          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1052:
function collectQuestChests() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1059:
  while [ "$RGB" == "82fdf5" ]; do
                 ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1103:
function collectMerchants() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1152:
function strenghenCrystal() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1169:
function nobleTavern() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1178:
  until [ "$RGB" == "f38d67" ]; do
                 ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1199:
function oakInn() {
^-- SC2112: 'function' keyword is non-standard. Delete it.

Line 1203:
  local COUNT=0
  ^-- SC3043: In POSIX sh, 'local' is undefined.

Line 1212:
      if [ $oakRes == 0 ]; then
                   ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1221:
          if [ $oakRes == 0 ]; then
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1230:
              if [ $oakRes == 0 ]; then
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1238:
      ((COUNT = COUNT + 1)) # Increment
      ^-- SC3006: In POSIX sh, standalone ((..)) is undefined.

Line 1290:
if [ "$RGB" == "ffc15b" ]; then
          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1292:
  if [ "$waitForUpdate" == true ]; then
        ^-- SC2154: waitForUpdate is referenced but not assigned.
                        ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1303:
if [ "$doLootAfkChest" == true ]; then lootAfkChest; fi
    ^-- SC2154: doLootAfkChest is referenced but not assigned.
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1304:
if [ "$doChallengeBoss" == true ]; then challengeBoss; fi
    ^-- SC2154: doChallengeBoss is referenced but not assigned.
                      ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1305:
if [ "$doFastRewards" == true ]; then fastRewards; fi
    ^-- SC2154: doFastRewards is referenced but not assigned.
                    ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1306:
if [ "$doCollectFriendsAndMercenaries" == true ]; then collectFriendsAndMercenaries; fi
    ^-- SC2154: doCollectFriendsAndMercenaries is referenced but not assigned.
                                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1307:
if [ "$doLootAfkChest" == true ]; then lootAfkChest; fi
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1311:
if [ "$doSoloBounties" == true ]; then soloBounties; fi
    ^-- SC2154: doSoloBounties is referenced but not assigned.
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1312:
if [ "$doTeamBounties" == true ]; then
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1313:
  if [ "$doSoloBounties" == true ]; then teamBounties; else teamBounties true; fi
                         ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1315:
if [ "$doArenaOfHeroes" == true ]; then arenaOfHeroes; fi
    ^-- SC2154: doArenaOfHeroes is referenced but not assigned.
                      ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1316:
if [ "$doLegendsTournament" == true ]; then
                          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1317:
  if [ "$doArenaOfHeroes" == true ]; then legendsTournament; else legendsTournament true; fi
                          ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1319:
if [ "$doKingsTower" == true ]; then kingsTower; fi
    ^-- SC2154: doKingsTower is referenced but not assigned.
                   ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1323:
if [ "$doGuildHunts" == true ]; then guildHunts; fi
                   ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1324:
if [ "$doTwistedRealmBoss" == true ]; then
    ^-- SC2154: doTwistedRealmBoss is referenced but not assigned.
                         ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1325:
  if [ "$doGuildHunts" == true ]; then twistedRealmBoss; else twistedRealmBoss true; fi
                       ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1327:
if [ "$doBuyFromStore" == true ]; then buyFromStore; fi
    ^-- SC2154: doBuyFromStore is referenced but not assigned.
                     ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1328:
if [ "$doStrenghenCrystal" == true ]; then strenghenCrystal; fi
    ^-- SC2154: doStrenghenCrystal is referenced but not assigned.
                         ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1329:
if [ "$doCompanionPointsSummon" == true ]; then nobleTavern; fi
    ^-- SC2154: doCompanionPointsSummon is referenced but not assigned.
                              ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1330:
if [ "$doCollectOakPresents" == true ]; then oakInn; fi
    ^-- SC2154: doCollectOakPresents is referenced but not assigned.
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1333:
if [ "$doCollectQuestChests" == true ]; then collectQuestChests; fi
    ^-- SC2154: doCollectQuestChests is referenced but not assigned.
                           ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1334:
if [ "$doCollectMail" == true ]; then collectMail; fi
    ^-- SC2154: doCollectMail is referenced but not assigned.
                    ^-- SC3014: In POSIX sh, == in place of = is undefined.

Line 1335:
if [ "$doCollectMerchantFreebies" == true ]; then collectMerchants; fi
    ^-- SC2154: doCollectMerchantFreebies is referenced but not assigned.
                                ^-- SC3014: In POSIX sh, == in place of = is undefined.

If using VS Code: in .vscode/settings.json we could sync our comment lines / max length, spaces/tabs

settings.json
{
    "workbench.colorCustomizations": {
        "editorRuler.foreground": "#333"        // rulers color
    },
    "[shellscript]": {
        "editor.insertSpaces": true,
        "editor.rulers": [
            48,                                 // default comment
            80,                                 // maximum code length, 2nd comment line
            120                                 // maximum line length
        ],
        "editor.tabSize": 4,
        "files.eol": "\n"
    }
}

Damn, I really like the idea of this. Thank you!
This is indeed something I wanted to do for a long time now, but I've never really done it mainly because it's such a big undertaking for basically no reward besides being more optimized I guess. Don't get me wrong though, I find this really important and I want to make use of shellcheck! I just think that I'd rather implement some missing features first (like the ones we are taking care of now) and whenever that is done, I'd put my head into this big topic.
Though of course, let's try and use the best practices when creating code from now on already! I'll try and install shellcheck and make use of it, as well as use those .vscode settings you proposed.

I use the online version of shellcheck. We always have the sames issues... 😺
I did with the already existing code to start to motivate everyone ;)
Adding basic functions to help everyone have the same code is already good if one day we need to change some core function.
And it's already in the PR list :godmode:

Still updating the .vscode/settings.json:
{
    // Global > Ruller
    "workbench.colorCustomizations": {
        "editorRuler.foreground": "#333"        // rulers color
    },
    // Global > EOL > LF
    "files.eol": "\n",
    // shellscript
    "[shellscript]": {
        // Ruller
        "editor.rulers": [
            48,                                 // default comment
            80,                                 // maximum code length, 2nd comment line
            120                                 // maximum line length
        ],
        // Tab
        "editor.insertSpaces": true,
        "editor.tabSize": 4,
        // EOL > LF
        "files.eol": "\n"
    },
    // Extension - markdownlint > https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint
    "markdownlint.config": {
        "default": true,
        "MD033": false,                         // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md033
        "MD036": false,                         // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md036
        "MD041": false                          // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041
    },
    // Extension - shellcheck > https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck
    "shellcheck.customArgs": [
        "-x"                                    // https://github.com/koalaman/shellcheck/wiki/SC1091
    ],
    "shellcheck.exclude": [
        "1090",                                 // https://github.com/koalaman/shellcheck/wiki/SC1090
        "1091",                                 // https://github.com/koalaman/shellcheck/wiki/SC1091
        "2034",                                 // https://github.com/koalaman/shellcheck/wiki/SC2034
        "2119",                                 // https://github.com/koalaman/shellcheck/wiki/SC2119
        "2154",                                 // https://github.com/koalaman/shellcheck/wiki/SC2154
        "3053",                                 // https://github.com/koalaman/shellcheck/wiki/SC3053
        "3057",                                 // https://github.com/koalaman/shellcheck/wiki/SC3057
        "3060"                                  // https://github.com/koalaman/shellcheck/wiki/SC3060
    ]
}

Just leaving this comment here as well: https://github.com/zebscripts/AFK-Daily/pull/59#issuecomment-828316644
Also, I will use those .vscode settings for future commits, so at least that should be fixed!