No conversation when using API key

When using the API key instead of logging in through the browser, the extension does not seem to be able to have a conversation with ChatGPT. Single prompts or context menu options still work, however when follow-up questions are asked they are processed as if they are new questions (without the context of the previous questions and answers).

Because the API does not support follow up.
This is a limitation for OpenAI itself, not the extension.

related: https://github.com/gencay/vscode-chatgpt/issues/60

Because the API does not support follow up. This is a limitation for OpenAI itself, not the extension.

Aah oke. I assume as much at first, however I did find another extension that uses ChatGPT in which it is possible to ask follow-up questions and which only had the API key as an option to connect to OpenAI. This lead me to believe it was perhaps not a limitation of the API key. Perhaps they found a workaround for it.

@WouterCouwenbergh Can you share the extension?

@TroyCalandra @WouterCouwenbergh @ncesar The V3.5.2 now has the conversation support with the pre-release ChatGPT API integration. Please update your extensions


trackByArea doesn't work with coloredarea type

Pretty much what the title says.  If I have a regular area chart I can capture a click event in the "area" plot by setting series.trackByArea to true.  Using this plugin and the coloredarea bype, only clicks on the point actually fire the event.

Thanks for reporting the issue @genzgd
Workaorund:
Demo: https://jsfiddle.net/BlackLabel/tg58gc6x/238/
Plugin:
  Highcharts.seriesTypes.coloredarea.prototype.getGraphPath = function() {
    var series = this,
      graphPath = [],
      segmentPath,
      singlePoints = []; // used in drawTracker
    // Divide into segments and build graph and area paths

    Highcharts.seriesTypes.area.prototype.getGraphPath.call(this);

    // this.areaPath = [];
    Highcharts.each(series.segments, function(segment) {
      segmentPath = series.getSegmentPath(segment.points);
      // add the segment to the graph, or a single point for tracking
      if (segment.points.length > 1) {
        graphPath.push([segmentPath, segment.color]);
      } else {
        singlePoints.push(segment.points);
      }
    });

    // Record it for use in drawGraph and drawTracker, and return graphPath
    series.singlePoints = singlePoints;
    series.graphPath = graphPath;
    return graphPath;
  };


Add MultiNamespaceListerWatcher capability

Add MultiNamespaceListerWatcher method into top pkg which can be used by
#11667
#11932
Signed-off-by: Chun Lin Yang<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

have a separate commit for new dependency instead of create a new PR. so close it.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @costinm
/cc @linsun

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e94a5a0691b18138f6cfd025862d79fe39c00a06
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7c4f86a13cdf7298892c8520679b1a2c52f466c9
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test e2e-simpleTests-cni

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
bd64f7e6e5dd1475bf7b8b2dac21577c5aebe2b2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Realistically speaking 1.3.

Realistically speaking 1.3.

I should move this to galley/pkg/source/kube/common and address your comment. then it can be in 1.2. Right?

Judging by the code review comments, too much work would be required for 1.1.  Please try resending this to master and addressing the review comments there.


Tests for examples & a screenshot of Page type definition

This commit added tests to ensure the examples work as intended. It also adds clarity from the Butter admin side to help bridge the gap between Page type definition and consumption.

Couple minor comments, otherwise looks good!


ImportError: No module named 'RFXtrx'

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.40.1
(also 0.40.2 and 0.41.0)
Python release (python3 --version):
Python 3.4.2
Component/platform:
rfxtrx
Description of problem:
Error on startup (see log below). RFXtrx not working
Expected:
rfxtrx platform working
Problem-relevant configuration.yaml entries and steps to reproduce:
n/a

Install HA in venv: pip3 install --upgrade homeassistant==0.40.1
start HA: hass (or just use script check-config)
see error

Traceback (if applicable):
n/a

Additional info:
home-assistant.log
17-04-02 13:45:04 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/discovery.py", line 105, in new_service_found
    hass, component, platform, info, config)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/helpers/discovery.py", line 155, in async_load_platform
    hass, component, hass_config)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/setup.py", line 47, in async_setup_component
    return (yield from setup_tasks[domain])
  File "/usr/lib/python3.4/asyncio/futures.py", line 390, in __iter__
    return self.result()  # May raise too.
  File "/usr/lib/python3.4/asyncio/futures.py", line 277, in result
    raise self._exception
  File "/usr/lib/python3.4/asyncio/tasks.py", line 233, in _step
    result = coro.throw(exc)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/setup.py", line 58, in async_setup_component
    return (yield from task)
  File "/usr/lib/python3.4/asyncio/futures.py", line 388, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.4/asyncio/tasks.py", line 286, in _wakeup
    value = future.result()
  File "/usr/lib/python3.4/asyncio/futures.py", line 277, in result
    raise self._exception
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/setup.py", line 154, in _async_setup_component
    conf_util.async_process_component_config(hass, config, domain)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/config.py", line 566, in async_process_component_config
    p_validated = platform.PLATFORM_SCHEMA(p_validated)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 192, in __call__
    return self._compiled([], data)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 486, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 269, in validate_mapping
    cval = cvalue(key_path, value)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 625, in validate_callable
    return schema(data)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/validators.py", line 262, in __call__
    v = schema(v)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 192, in __call__
    return self._compiled([], data)
  File "/srv/homeassistant/lib/python3.4/site-packages/voluptuous/schema_builder.py", line 625, in validate_callable
    return schema(data)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/rfxtrx.py", line 96, in _valid_light_switch
    return _valid_device(value, "light_switch")
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/rfxtrx.py", line 74, in _valid_device
    if get_rfx_object(key) is None:
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/rfxtrx.py", line 175, in get_rfx_object
    import RFXtrx as rfxtrxmod
ImportError: No module named 'RFXtrx'

Can you try
pip3 install pyRFXtrx

I did a clean install of 0.41.0 in a virtualenv.
Still had the error.
Then did this:
sudo systemctl stop home-assistant@homeassistant
sudo su -s /bin/bash homeassistant
source /srv/homeassistant/bin/activate
pip install pyRFXTRX
deactivate
sudo systemctl start home-assistant@homeassistant

The error has gone for now, but I guess this needs to be fixed in the source?

As Fabian linked, my issue #7836 maybe the same and is with version 0.45.1

This happens cause rfxtrx platforms depend on RFXtrx in the validation of the config. This won't work since the automatic install of requirements happen after the process of the config during setup, which includes config validation.


Apocrypha books maybe? (Not a real issue.)

Would it be possible to see other versions of the bible added into the databases in the future? Like KJVA, or 1611 KJV, or simply just the apocrypha in its own database?

Never mind. Duh. Found them. Thank you.


[MISC] Update data-platform-libs: data_interfaces to 34 and upgrade to 16

Following our discussion about why test_on_get_password is passing only if the unit is leader, I created the following ticket to address it: https://warthogs.atlassian.net/browse/DPE-4259
If everyone agrees I think this PR can get merged in the meantime. Then I can create follow-ups once we investigate the issue.

I think that's fine to merge it as is and investigate later.


Interpreter should allow user to specify image file

The interpreter looks for an image file named "ImageBuilder/image". It should allow the user to specify the image file to use. If not provided, it should look for "image" in the current directory, not an ImageBuilder subdirectory.

The interpreter command does accept an image name on the command line. Enhancing this task to add all of the parameters to the main section.


Scenario in Execution context should contain all steps info from scenario

Scenario in ExecutionContext should contain array of StepDetails instead of "currentScenario", also StepsDetails should contain field isExecuted
Issue opened according to discussion:
https://gitter.im/getgauge/chat?at=5a09cfa8f257ad91098ce6b5

Closing this as an old issue. However, any PR's to fix this will be merged.


How to evaluate the link prediction performance of GraphGPT

Hi,
Thank you for sharing your fantastic work. I recently want to reproduce the link prediction evaluation part. In your paper, you mentioned that
"we utilize three commonly adopted evaluation metrics: Accuracy and Macro F1 for node
classification, and AUC (Area Under the Curve) for link prediction".
I can find from the example files for node classification evaluation but I can't find how to use the evaluation output to calculate the AUC.
What confuses most is that AUC requires the confidence of existence of links between 2 nodes. However, in your prompt design, you only ask llm for whether there's a link or not which means you can only get 0 or 1.
I would be appreciate it if you could provide me with further explanation. Thank you for your time!

explanation

Thanks for your interests in our GraphGPT. We treat link prediction as a binary classification problem on the edges (linking or not linking). We set the output of 'yes' as 1 and 'no' as 0, and then proceed to calculate the AUC (Area Under the Curve). Specifically, we utilize the computation function provided by sklearn to perform the calculation directly.

Thank you for your clarification!


CTS should populate learner preferences even if they're empty defaults

Part of the content specification outlines that The AU MUST retrieve the Learner Preferences document from the Agent Profile on startup..
The tester shouldn't need to setup the agent profile in the client/#/test/{ID} route. It should automatically at least put a "default" document when then agent is created (new test in the CTS).

The spec requires that the AU request the learner preferences but it does not indicate that one must exist. It would not be a good assumption to make that an agent profile exists, forcing a default into catapult would give this impression.

Excellent, Thanks for the clarification @brianjmiller I just added a switch to ignore not found errors which is enabled by default in our AU impl. Perfect :)


Renames methodth of currency repository.

Current coverage is 100% (diff: 100%)

Merging #24 into master will not change coverage

@@           master   #24   diff @@
===================================
  Files           3     3
  Lines          89    89
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           89    89
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 4dcd209...63042fb


Revert "Update podspec homepage to fix react native link"

Revert https://github.com/futurepress/react-native-static-server/pull/63 because https://github.com/futurepress/react-native-static-server/pull/75 fixed this issue.
package['repository'] doesn't work in some cases because npm generate different package.json on npm i or npm ci.
It doesn't work when it's an object.
  "repository": {
    "type": "git",
    "url": "git+https://github.com/futurepress/react-native-static-server.git"
  }

s.homepage     = package['homepage'] is used by a lot of libs. You can check async-storage for instance
https://github.com/react-native-community/async-storage/blob/LEGACY/RNCAsyncStorage.podspec#L12

There's a mistake in branch name. it should be revert-gvanderclay/patch-1

Thanks sorry for the delay on this, fixed in #89


expose children elements

In some cases access to textarea and pre/code elements are needed. (selecting/marking text).
In addition, this allows remove unnecessary internal querySelector calls.

If #51 added, it would require additional change as well

Thank you for this! It definitely makes my code cleaner, and probably faster.


np-46448: use most recent org api version as default

I think I will wait with merge until tomorrow after notifying the team. One can always use earlier version by manually using Accept header


Verification shall include MDTest

If MDTest verification detects an error on read, the benchmark should detect it and invalidate the result.

This issue is now addressed in #56, a62cce0b1169ab4193f1aa61b2d7f1948e4d7978


Feature request: Enable AP+STA mode

Currently, the MPU ships in AP mode, allowing wireless clients to connect to it but not allowing the MPU to connect to the WAN.
I suggest that the MPU be put by default in AP+STA mode, allowing it simultaneously to act as a WiFi hotspot and to connect to a wireless network, allowing for WAN access.
This would be useful in a performance context if, for example, you had audience members who wished to participate using a webapp, but didn't want to connect to a separate WiFi network. WAN traffic from the audience members could be routed to the MPU, while also allowing instruments (such as the T-Stick) to connect to the access point afforded by the MPU.
One tutorial for doing this on Raspberry Pi can be found here: https://docs.raspap.com/ap-sta/.

That's indeed useful, but I don't know how reliable the WiFi module is in dual mode. I remembered trying this in the past with poor results (intermittent disconnections, unreliable signal). I have to run some tests before implementing it.
Regardless, if reliable interaction using WiFi is required, I usually suggest a dedicated router that provides a stable and stronger signal.

I will close this issue as the OS part of the MPU will migrate soon to another project. We will explore solutions of AP/STA modes then.


Add BinaryExistsCheck, Updating behaviour of health to perform as per documentation

Details on individual commits.

Needs rebasing

@dhensby have rebased. Looks like several of the fixes happened in parallel to this being here.

This will need another rebase sorry. :)

Bah. Robots.

Closing this, the PSR2 stuff is a dog to merge


Parse Error when used with pdfJS

Hi!
I'm trying to use Google Closure (v20220601) with pdfjs-dist (v2.14.305)
Google Closure: https://mvnrepository.com/artifact/com.google.javascript/closure-compiler/v20220601
pdfjs: https://github.com/mozilla/pdfjs-dist/tree/v2.14.305
But I keep getting a parsing error message in pdf_viewer.js:
src/third-party/doc/pdf_viewer.js:447:2: ERROR - [JSC_PARSE_ERROR] Parse error. '}' expected
  447|   #pagesRefCache = new Map();

I found that others had a similar issue here and that there was some chatter about adding a fix for private class fields; is this already done?

It looks like this is using private class properties, which may not be supported.


[WIP] fix SetInstantaneousJointValues signature

cf https://github.com/mujin/mujincontrollerclientpy/commit/8b31801a34dc57deb5c23684dde7d3eb050fdfaf

(waiting for customer answer)

they are editing taskparameter; no need to edit our code base


mocha loses the right title when done called multiple times

I just finished trouble-shooting a wierd "done called multiple times" message.... phewee.. here's a tricky one:
I had a before-all hook that looked as following:
{ "lib/rest" :
  { beforeAll:
    function(done) {
        this.slow("1.1s");
        rest = require('../lib/rest')(sockets, eventsHandler, done);
        setTimeout(done, 1000)
    }
  ,

Where evidently, the done is called both from ../lib/rest and the setTimeout.
Anyway, the ../lib/rest was not calling the callback for a long time, and evidently, making it call the callback as it should - was actually what broke the build.
(I'm using mocha-ui-exports, that's why it looks like that)
However, mocha could not direct me to the right place - probably because the setTimeout handler that was fired after 1s - was called in the midst of some other suite that followed - and mocha was pointing me to the suite and the test that during it's run the timer was fired...
looking there obviously brought nothing, and pending the tests that were reported as failing just moved the failure to another test that was not pended - and that's where I started suspecting that mocha reports the wrong place, and expanded my search.
After fixing the issue (removing the setTimeout from the beforeAll hook) - the suite passes.

Unfortunately, no portable solution exists for this right now. :( In node, you'd have to use domains, which are being deprecated (though an alternate solution doesn't yet exist) That's what I used for https://github.com/danielstjules/mocha.parallel#error-handling
AFAIK, nothing similar exists in the browser. https://github.com/bevry/domain-browser is more of a sham than a shim, since it exposes a similar API but doesn't handle async errors.
Sorry for inconvenience, I hope it wasn't too difficult to debug. In those situations, I usually hope the stacktrace points me in the right direction.

Well. Doesn't make sense to me:
done function, wither it's called once or more, is passed to a test function from a closure -  one that remembers how many times is was called.
How about adding information about the function a done callback is passed to?

Sorry about that, that's what I get for closing issues when tired :) I must have been thinking about exceptions being thrown async, rather than the callback. However, what version of mocha are you running? With 2.3.0, this doesn't seem to be an issue:
$ cat test.js
describe('suite', function() {
  it('test1', function(done) {
    done();
    setTimeout(done, 50);
  });

  it('test2', function(done) {
    setTimeout(done, 100);
  });
});

$ mocha test.js

  suite
    ✓ test1
    1) test1
    ✓ test2 (102ms)

  2 passing (108ms)
  1 failing

  1) suite test1:
     Error: done() called multiple times

$ cat test.js
describe('suite', function() {
  before(function(done) {
    done();
    setTimeout(done, 50);
  });

  it('test', function(done) {
    setTimeout(done, 100);
  });
});

$ mocha test.js

  suite
    1) test

  0 passing (58ms)
  1 failing

  1) suite test:
     Uncaught Error: done() called multiple times

With your reporter:
$ cat test.js
module.exports = { Example: {
    beforeAll: function(done) {
      this.slow(110);
      setTimeout(done, 50);
      setTimeout(done, 100);
    },
    'test 1': function(done) {
      setTimeout(done, 200);
    }
  }
}

$ mocha --ui mocha-ui-exports test.js

  Example
    1) test 1

  0 passing (116ms)
  1 failing

  1) Example test 1:
     Uncaught Error: done() called multiple times
      at Array.forEach (native)
      at node.js:951:3

I think I get it now.  When invoked multiple times from a hook, it prints the test name rather than indicate the hook. It works correctly when invoked multiple times from a spec.


Fix multiple clicks opening multiple modals

Apply multiple modals fix to BGE 'Edit' button and 'Review Donations' anchor.

Fix Source

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-031525

Tracking W-031525

@kenlewis-sfdo - Does this change any behavior for the end user? Do we need to say anything is release notes on this one?


PLNSRVCE-448: clean up unneeded operator rbac perms; fix mvn-goals on openshift

So this PR started of as cleanup of some unneeded RBAC permissions that I discovered while reviewing the API dependencies for jvm-build-service.
However, in the process of my local testing, I discovered that a regression was introduced with @stuartwdouglas 's https://github.com/redhat-appstudio/jvm-build-service/commit/b6cf13f16f09f9fe68eca98286ef909024880fce (the change of the maven image I believe) that results in this error when running on OpenShift:
[mvn-goals] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[mvn-goals] [INFO] ------------------------------------------------------------------------
[mvn-goals] [INFO] BUILD FAILURE
[mvn-goals] [INFO] ------------------------------------------------------------------------
[mvn-goals] [INFO] Total time:  30:59 min
[mvn-goals] [INFO] Finished at: 2022-06-30T13:14:43Z
[mvn-goals] [INFO] ------------------------------------------------------------------------
[mvn-goals] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources (default-resources) on project code-with-quarkus: Cannot create resource output directory: /workspace/source/target/classes -> [Help 1]
[mvn-goals] [ERROR]
[mvn-goals] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn-goals] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn-goals] [ERROR]
[mvn-goals] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn-goals] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

I did cross reference with @dwalluck, who happened to be working on a minikube cluster today, and confirmed that this error does not occur on minikube.  This is not at all surprising though, given OpenShift's more stringent enforcement around things like file permissions.
Furthermore, I saw in @Michkov 's https://github.com/redhat-appstudio/jvm-build-service/commit/4127d12738e78f77ac4af9d8f6f432387604d9da where he undoubtedly encountered a similar situation in other steps he touched in the PR, and have employed those in Task/ClusterTask we use as part of testing the service registry build locally.
Now, the icky part.  I could not sort out after a lot of different experiments how to reconcile the GOAL param array within a script.  I had to switch mvn-goals from a command to a script to add the chown to fix the permissions issue.  Aside from general bash internet searches, I went throught the tekton doc, and sure enough, no examples around param arrays in scripts.  Plenty with string and k/v pair params.  So for now, I've hardcoded to the params used in the service registry build.
If solutions arise during PR review, I'll gladly take them.  If none arise, I'll merge this after any other comments are addressed, link up with @stuartwdouglas when he gets back, and sort out whether we can use a more friendly maven image for OpenShift, switch the GOALS param to a space separated string parameter, or some other option not occurring to me.
/assign @Michkov
/assign @dwalluck

Forgot to mention: the yaml change which I believe introduced the regression on openshift (no minikube) is already one of the to-do's listed in my https://issues.redhat.com/browse/PLNSRVCE-452 for this sprint, where we start running tests using a PR's deploy/* yaml changes


[Bug] Visible underline on hover of "GitHub Star" on homepage

Description
A small green underline is visible on hover of "GitHub Star" on the meshery.io website homepage under GIF

Expected Behavior
Remove the underline
Environment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Please assign me this

Great @DevilsAutumn let's get you assigned this issue 😎

@ritiksaxena124 ruby 2.7.5 is not available for windows, so do i have to use wsl or is there any better way?

@ritiksaxena124 ruby 2.7.5 is not available for windows, so do i have to use wsl or is there any better way?
Edit: Doing with wsl

Well its available here

hey please  @ritiksaxena124  can you please assign me this issue .

Thank you @roy2pushkar, we already have a PR by @DevilsAutumn for this issue that will complete this task. you can check for other issues 😉

yes thank you @ritiksaxena124


[Feature Request] When hovering over truncated snippet show longer version

When hovering over truncated snippet show a tooltip or something with a longer version of the text eg how ClipMenu  does it

This is already done in #31 and will be available in the next release.


post_publish_bbb_video_download.rb should got to post_process

I think *bbb_video_download.rb should be called in post_process and not in post_publish.
In post_publish are normally scripts that depend on the finished recording processing like for example the scalelite_recording_importer.
At the moment the scalelite importer is called after the video_download script because of the alphabetical ordering (s after r)
The publish script sets at its end of its processing the marker status/published/xxxx-presentation.done to indicate that its done.
But the video_download script might still run for a long time.

I had a look into publish/presentation.rb
It might be that in this script is more processing that must run before bbb_video_download.rb .
The we have to make sure that it is run before scripts like scalelite...

Since the scripts works with the published files it will remain in post_publish. Though you can adjust the name, so it's called in the right order.


Jupyter Server Roadmap

In today's call, we put together a technical roadmap for the Jupyter Server. Here's a place to discuss the plan.

[x] Release nbclassic

[x] a notebook ExtensionApp (from jupyter_server).
[x] pulls Notebook JS and templates from notebook.
[x] execute from command line with jupyter nbclassic
[ ] migrates configuration to jupyter_server_config.

[x] Setup Jupyter Server's Testing Framework

[x] Port old tests to pytest.
[x] Move to Github actions (?)

[ ] Merge Kernel Providers

[ ] Move jupyter_kernel_mgmt, jupyter_protocol to Jupyter's Github org.
[ ] Documentation for Kernel Providers, jupyter_kernel_mgmt and jupyter_protocol.
[ ] Merge Kernel Providers into jupyter_server: jupyter/jupyter_server#112.
[ ] Help voila adjust to kernel_mgmt

@kevin-bates mentioned that he spoke with @SylvainCorlay about KP.

[ ] Release jupyter_server with Kernel Providers
[ ] Helpnb_conda_kernels switch to Kernel Providers.

They currently have an old version of Kernel Provider.
nb_conda_kernels tries to import Kernel Providers. If found, uses the new kernel management framework. Otherwise, falls back to old way.

[ ] Update Jupyter Server JEP to reflect new nbclassic.
[ ] Transition other frontends:

JupyterLab to Jupyter Server, dropping notebook as a dependency.
nteract_on_jupyter to Jupyter Server
any other frontends?
Uses nbclassic to run multiple frontends side-by-side.

[ ] Notebook 7.x: transition jupyter/notebook to Jupyter Server

[ ] drop the old notebook server
[ ] NotebookApp becomes
[ ] shim the notebook server API to jupyter_server
[ ] raise DeprecationWarnings in shimmed APIs.
[ ] release notebook 7.x

[ ] Notebook 8.x: drop shims.

Just moved Zsailer/notebook_shim to Zsailer/nbclassic.
NBClassic is a thin package that provides the classic Jupyter Notebook frontend on top of Jupyter Server. You can install NBClassic side-by-side with notebook. NBClassic uses the Javascript and templates from notebook, but runs on the Jupyter Server's tornado server (not the notebook's native tornado server).
You can install nbclassic from PyPI today.
pip install jupyter_server nbclassic notebook

You can try the nbclassic frontend by running jupyter server or jupyter nbclassic and going to localhost:<port>/tree?token=...

@Zsailer I've gone ahead and pinned this issue for visibility. Thanks for putting it together!

Thanks, @willingc!

didn't know about the pinned feature, learning every day here...
Good to have more visibility here but further actions could be needed in downstream projects that are using notebook or are/will be using server. This is especially true for the kernel_mgmt - nbclassic should have 0 impact I believe.

See https://github.com/jupyter/jupyter_server/issues/190


add new format option to just echo id

So a while ago I was staring at these workarounds: https://github.com/strategicdesignteam/openshift-ansible-contrib/commit/a2c0ec681e0445d8e7c8b79339c5fc06cb71f58a#diff-ca224404b5a9b5002bd12ea8577bd914R85
and it occurred to me that various moderately sophisticated tasks quickly become almost impossible with tower-cli, if lookups can not be done through a resource's identity tuple. Example scenario: Change the email of a user with a given first name and last name. Solution (made possible by this PR):
tower-cli user modify $(tower-cli user get --last-name="Auditor" --first-name="System" --format=id<EMAIL_ADDRESS>
This is still using special bash syntax, but if it solves someone's problem, then that seems fine. If someone, instead, were to store the outcome and then use it in a subsequent command, this might be useful as well.

Coverage decreased (-0.08%) to 89.586% when pulling 026b16e1382267fa8f058c9c3e9e8de195f24128 on AlanCoding:format_id into d663046542a78c78985ac10a53cb6d7c7a22c045 on ansible:master.


feat: enable hub vpc

Description
hub_vpc_id input (used in spoke vpc)

configures delegated resolver pointing to hub vpc
configures DNS resolution binding
creates ibm_is_vpc_dns_resolution_binding resource under the hood - with source being the VPC

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Can add validation to check both "enable_hub" and "enable_hub_vpc" are not true at the same time once @vburckhardt PR is in.

Hi @rajatagarwal-ibm - the goal here is not to create a second VPC, but to expose the variable in the interface of the module allowing a consumer to use this module to create a spoke VPC.

/run pipeline

/run pipeline

I have also added a check if enable_hub is false then only it should create ibm_is_vpc_dns_resolution_binding based on hub_vpc_id / hub_vpc_crn, as you would not create DNS resolution binding unless you already have hub info.
Here is the terraform plan for the basic example in all the scenarios:

When both hub_vpc_id and hub_vpc_crn are not passed.

 # module.slz_vpc.ibm_is_vpc.vpc will be created
  + resource "ibm_is_vpc" "vpc" {
      + access_tags                 = (known after apply)
      + address_prefix_management   = "auto"
      + classic_access              = false
      + crn                         = (known after apply)
      + cse_source_addresses        = (known after apply)
      + default_network_acl         = (known after apply)
      + default_network_acl_crn     = (known after apply)
      + default_network_acl_name    = (known after apply)
      + default_routing_table       = (known after apply)
      + default_routing_table_name  = (known after apply)
      + default_security_group      = (known after apply)
      + default_security_group_crn  = (known after apply)
      + default_security_group_name = (known after apply)
      + health_reasons              = (known after apply)
      + health_state                = (known after apply)
      + id                          = (known after apply)
      + name                        = "basic-slz-vpc-vpc-vpc"
      + no_sg_acl_rules             = false
      + resource_controller_url     = (known after apply)
      + resource_crn                = (known after apply)
      + resource_group              = (known after apply)
      + resource_group_name         = (known after apply)
      + resource_name               = (known after apply)
      + resource_status             = (known after apply)
      + security_group              = (known after apply)
      + status                      = (known after apply)
      + subnets                     = (known after apply)
      + tags                        = (known after apply)

      + dns {
          + enable_hub               = false
          + resolution_binding_count = (known after apply)
        }
    }

When hub_vpc_id is passed

 # module.slz_vpc.ibm_is_vpc.vpc will be created
  + resource "ibm_is_vpc" "vpc" {
      + access_tags                 = (known after apply)
      + address_prefix_management   = "auto"
      + classic_access              = false
      + crn                         = (known after apply)
      + cse_source_addresses        = (known after apply)
      + default_network_acl         = (known after apply)
      + default_network_acl_crn     = (known after apply)
      + default_network_acl_name    = (known after apply)
      + default_routing_table       = (known after apply)
      + default_routing_table_name  = (known after apply)
      + default_security_group      = (known after apply)
      + default_security_group_crn  = (known after apply)
      + default_security_group_name = (known after apply)
      + health_reasons              = (known after apply)
      + health_state                = (known after apply)
      + id                          = (known after apply)
      + name                        = "basic-slz-vpc-vpc-vpc"
      + no_sg_acl_rules             = false
      + resource_controller_url     = (known after apply)
      + resource_crn                = (known after apply)
      + resource_group              = (known after apply)
      + resource_group_name         = (known after apply)
      + resource_name               = (known after apply)
      + resource_status             = (known after apply)
      + security_group              = (known after apply)
      + status                      = (known after apply)
      + subnets                     = (known after apply)
      + tags                        = (known after apply)

      + dns {
          + enable_hub               = false
          + resolution_binding_count = (known after apply)

          + resolver {
              + configuration         = (known after apply)
              + servers               = (known after apply)
              + type                  = "delegated"
              + vpc_id                = "abc"
              + vpc_name              = (known after apply)
              + vpc_remote_account_id = (known after apply)
              + vpc_remote_region     = (known after apply)
            }
        }
    }

 # module.slz_vpc.ibm_is_vpc_dns_resolution_binding.vpc_dns_resolution_binding_id[0] will be created
  + resource "ibm_is_vpc_dns_resolution_binding" "vpc_dns_resolution_binding_id" {
      + created_at        = (known after apply)
      + endpoint_gateways = (known after apply)
      + href              = (known after apply)
      + id                = (known after apply)
      + lifecycle_state   = (known after apply)
      + name              = "basic-slz-vpc-dns-binding"
      + resource_type     = (known after apply)
      + vpc_id            = (known after apply)

      + vpc {
          + crn           = (known after apply)
          + href          = (known after apply)
          + id            = "abc"
          + name          = (known after apply)
          + remote        = (known after apply)
          + resource_type = (known after apply)
        }
    }

When hub_vpc_crn is passed

 # module.slz_vpc.ibm_is_vpc.vpc will be created
  + resource "ibm_is_vpc" "vpc" {
      + access_tags                 = (known after apply)
      + address_prefix_management   = "auto"
      + classic_access              = false
      + crn                         = (known after apply)
      + cse_source_addresses        = (known after apply)
      + default_network_acl         = (known after apply)
      + default_network_acl_crn     = (known after apply)
      + default_network_acl_name    = (known after apply)
      + default_routing_table       = (known after apply)
      + default_routing_table_name  = (known after apply)
      + default_security_group      = (known after apply)
      + default_security_group_crn  = (known after apply)
      + default_security_group_name = (known after apply)
      + health_reasons              = (known after apply)
      + health_state                = (known after apply)
      + id                          = (known after apply)
      + name                        = "basic-slz-vpc-vpc-vpc"
      + no_sg_acl_rules             = false
      + resource_controller_url     = (known after apply)
      + resource_crn                = (known after apply)
      + resource_group              = (known after apply)
      + resource_group_name         = (known after apply)
      + resource_name               = (known after apply)
      + resource_status             = (known after apply)
      + security_group              = (known after apply)
      + status                      = (known after apply)
      + subnets                     = (known after apply)
      + tags                        = (known after apply)

      + dns {
          + enable_hub               = false
          + resolution_binding_count = (known after apply)

          + resolver {
              + configuration         = (known after apply)
              + servers               = (known after apply)
              + type                  = "delegated"
              + vpc_crn               = "abc"
              + vpc_name              = (known after apply)
              + vpc_remote_account_id = (known after apply)
              + vpc_remote_region     = (known after apply)
            }
        }
    }

# module.slz_vpc.ibm_is_vpc_dns_resolution_binding.vpc_dns_resolution_binding_crn[0] will be created
  + resource "ibm_is_vpc_dns_resolution_binding" "vpc_dns_resolution_binding_crn" {
      + created_at        = (known after apply)
      + endpoint_gateways = (known after apply)
      + href              = (known after apply)
      + id                = (known after apply)
      + lifecycle_state   = (known after apply)
      + name              = "basic-slz-vpc-dns-binding"
      + resource_type     = (known after apply)
      + vpc_id            = (known after apply)

      + vpc {
          + crn           = "abc"
          + href          = (known after apply)
          + id            = (known after apply)
          + name          = (known after apply)
          + remote        = (known after apply)
          + resource_type = (known after apply)
        }
    }

/run pipeline

Ran both pr_test and others_test locally, and both passed
PASS
ok      github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc 333.621s


Development Branch Config Resolve Error

Required Info

Camera Model
T265

Firmware Version
<IP_ADDRESS>6

Operating System & Version
Win 10

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.31.0

Language
C++

Segment
AR

Issue Description
With the latest development branch the following snippet fails with rs2_config_resolve(config:0000011517E0F7C0, pipe:00000115198E3470): No device connected
rs2::config cfg;
rs2::context ctx;
rs2::pipeline pipe(ctx);
std::string sn;

for (const auto& dev : ctx.query_devices())
{
    if (std::string(dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID)) == std::string("0B37"))
    {
        sn = dev.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER);
    }
}
cfg.enable_device(sn);
cfg.enable_stream(RS2_STREAM_POSE, 0, 0, 0, RS2_FORMAT_6DOF, 0);
auto pp = cfg.resolve(pipe);

Apologies that you did not receive a response to your question.
I will close this case since, with the release of two subsequent SDK versions since then, 2.31.0 is no longer the latest SDK release.  Please open a new case if you are still experiencing problems with the current releases.  Thanks!


[BUG] Loadbalancer node nginx fails with new Docker M1 RC version

What did you do

How was the cluster created?

k3d cluster create mycluster --registry-create --api-port 6550 -p "<IP_ADDRESS>:8080:80@loadbalancer" -p "80:80@server[0]" -p "443:443@server[0]" --volume ~/data:/data/prod@server[0] --k3s-server-arg '--no-deploy=traefik' --label 'disktype=storage@server[0]' --image rancher/k3s:v1.20.5-rc1-k3s1

What did you do afterwards?

I opened browser to http://localhost:8080
What did you expect to happen
It should return an Nginx error page indicating the load balancer was reached.
Instead the text EOF is returned in the response body. Loadbalancer node error logs show
2021/03/20 03:06:56 [alert] 14#14: *1023 1026 worker_connections are not enough while connecting to upstream, client: <IP_ADDRESS>, server: <IP_ADDRESS>:80, upstream: "<IP_ADDRESS>:80", bytes from/to client:0/0, bytes from/to upstream:0/0

Accessing port 80 which is bound to the server node works and nginx error page is returned.
Screenshots or terminal output
Which OS & Architecture
MacOS with M1 arm processor
Which version of k3d
k3d 4.3.0 and 4.0.0 tested with same result
Which version of docker
Docker version 20.10.5, build 55c4c88
Previous version of Docker for M1 mac preview worked and did not have this error
This may be a Docker for M1 issue but I'm not sure.

Confirmed. I have exactly the same issue.

Hi @chrischen , thanks for opening this issue!
Unfortunately, I have no way of testing on Apple M1 architecture.

Are the other nodes/containers even running? :thinking:
Also please paste the output of docker info and docker version

Note I modified the server node to directly expose port 80 so I can work with it and bypass the loadbalancer. But accessing it via 8080 still gives EOF.
c3ceea88ceb8   rancher/k3d-proxy:v4.0.0           "/bin/sh -c nginx-pr…"   12 days ago    Up 36 hours                 <IP_ADDRESS>:8080->80/tcp, <IP_ADDRESS>:6550->6443/tcp   k3d-instp-dev-serverlb
d3bcd3606e20   rancher/k3s:v1.20.5-rc1-k3s1       "/bin/k3s server --n…"   12 days ago    Up 36 hours                 <IP_ADDRESS>:80->80/tcp, <IP_ADDRESS>:443->443/tcp         k3d-instp-dev-server-0
06197bb049b9   registry:2                         "/entrypoint.sh /etc…"   12 days ago    Up 36 hours                 <IP_ADDRESS>:61071->5000/tcp                          k3d-instp-dev-registry

Client:
 Context:    default
 Debug Mode: false
 Plugins:
  app: Docker App (Docker Inc., v0.9.1-beta3)
  buildx: Build with BuildKit (Docker Inc., v0.5.1-docker)
  scan: Docker Scan (Docker Inc., v0.5.0)

Server:
 Containers: 11
  Running: 3
  Paused: 0
  Stopped: 8
 Images: 17
 Server Version: 20.10.5
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Native Overlay Diff: true
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 05f951a3781f4f2c1911b05e61c160e9c30eaa8e
 runc version: 12644e614e25b05da6fd08a38ffa0cfe1903fdec
 init version: de40ad0
 Security Options:
  seccomp
   Profile: default
 Kernel Version: 4.19.121-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 2
 Total Memory: 3.838GiB
 Name: docker-desktop
 ID: 3WZE:7YNX:CCTD:ROKW:ALPZ:YRC6:CRRW:TJQ3:6LVJ:ZITG:HHW4:D7F2
 Docker Root Dir: /var/lib/docker
 Debug Mode: true
  File Descriptors: 64
  Goroutines: 63
  System Time: 2021-04-01T09:53:12.003851672Z
  EventsListeners: 3
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: true
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

Client: Docker Engine - Community
 Cloud integration: 1.0.10
 Version:           20.10.5
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        55c4c88
 Built:             Tue Mar  2 20:13:00 2021
 OS/Arch:           darwin/amd64 (rosetta)
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.5
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       363e9a8
  Built:            Tue Mar  2 20:16:48 2021
  OS/Arch:          linux/arm64
  Experimental:     true
 containerd:
  Version:          1.4.4
  GitCommit:        05f951a3781f4f2c1911b05e61c160e9c30eaa8e
 runc:
  Version:          1.0.0-rc93
  GitCommit:        12644e614e25b05da6fd08a38ffa0cfe1903fdec
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Ah, seems like I completely overlooked some things here, so let's start from the beginning:

You have traefik disabled, so what is actually listening there on port 80?

since you mentioned, that "nginx error page is returned" I assume that you deployed nginx-ingress?
if so, how did you deploy it?

Hi @chrischen , do you have some more input on this? :thinking:

Yes I disabled traefik as I'm using nginx ingress within the cluster itself. The nginx error page is when I skip the loadbalancer and access the server node directly on port 80, which is running my nginx ingress.
Does this also make the loadbalancer container use nginx as well? It's installed via the HelmChart controller I believe.

@chrischen so I cannot find any issue of e.g. nginx that could be related.
THe timeouts in the first message hint on issues with k3s though, maybe those logs could be interesting :thinking:

Does this also make the loadbalancer container use nginx as well? It's installed via the HelmChart controller I believe.

I'm not sure I understand your question here :thinking:
The serverlb (i.e. the loadbalancer that k3d creates) is always nginx, but that should be transparent.

I am rather beginner with kube and k3s, but I think i might be suffering of this same issue, but for me it is not related to nginx. I also get similar EOF on my M1 when I try to use ingress with k3d.

Hi @anan44 , could you please provide some details and the logs from the involved containers? :+1:

@iwilltry42 I hate to disappoint you, but it seems like newest docker version no longer has this issue. When I mentioned this I had not used my M1 for while (due to this particular issue), now that I updated docker on it and went to fetch the logs, everything worked smoothy.
@chrischen you should try also updating docker. I have Docker version 20.10.5, build 55c4c88, and at least my ingress issue has disappeared. If the these issues were actually even connected.

@anan44 if it was fixed on docker side (and the issue actually came from there), then that's surely no disappointment 😁

I assume that it was fixed on docker side, so I'll go ahead and close this issue.
If it still persists, please reopen!


[Event Change Request] codeunit 5815 Undo Sales Shipment Line - procedure Code - event OnAfterSalesShptLineModify

Describe the request
We would like HideDialog added to the following event.
Original:
codeunit 5815 - Undo Sales Shipment Line - procedure Code - event OnAfterSalesShptLineModify

OnAfterSalesShptLineModify(SalesShipmentLine, DocLineNo);

[IntegrationEvent(false, false)]
local procedure OnAfterSalesShptLineModify(var SalesShptLine: Record "Sales Shipment Line"; DocLineNo: Integer)
begin
end;

Change:
OnAfterSalesShptLineModify(SalesShipmentLine, DocLineNo, HideDialog); // <-- ADDED

[IntegrationEvent(false, false)]
local procedure OnAfterSalesShptLineModify(var SalesShptLine: Record "Sales Shipment Line"; DocLineNo: Integer; HideDialog: Boolean) // <-- ADDED
begin
end;

Additional context
for our own additional functionality we need the user to choose further action if not HideDialog is active
Internal work item: AB#523671

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 18286.


Updated dependencies and formatted code revision 2

updated all dependencies to a stable version
let prettier and ESLint go through all project files
tested on all platforms :)

closes #50

There are a few errors left which I wasn't immediately able to resolve. It would be nice if those who worked on these remaining components could try and resolve these.


Feature A

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

Emerson Contiero seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Update dependencies

are we going to convert this to just be a build time extension?

are we going to convert this to just be a build time extension?

@aruniverse I was thinking about that when updating this yesterday. I think it makes sense to do so. I'll hopefully get to it in the next few days.


Integrated terminal echoes secrets with new Local Echo feature

I've noticed that the new Local Echo feature from the October update - always echoes.
That is when my machine is under load and I am executing a command in the integrated terminal under WSL as sudo, I see my password on the console while I'm typing it. Same as for SSHing to a remote server using password authentication.
I can understand this is probably mostly harmless, but in an office setting without privacy monitors, this could actually pose a potential risk.
Is there any way for the local echo to know when the terminal itself is deliberately not echoing back, besides disabling the feature outright?

VSCode Version: 1.52.1
OS Version: Windows_NT x64 10.0.18363

Steps to Reproduce:

SSH to far away or high-latency machine requiring password authentication
OR

Execute a command as sudo while host system is under load

See your password echoed to the console as you type it

Hard to verify, using Remote-WSL which is by itself an extension

Actually that definitely looks like a duplicate, my apologies

Duplicate of #110359


Post projects to betapage

Post here: https://betapage.co/

[ ] Gefyra
[ ] Unikube
[ ] Hurricane

Just posted Gefyra to beta page. Review will take 32 days.


Add a test for #552

Just verifying that https://github.com/adamghill/django-unicorn/pull/552 works as expected.

@lassebomh Sorry this PR is a little messy, but at the end I added a test based on your original PR. Let me know if that makes sense!

Nice. And yes, I believe running get_frontend_context_variables in the test would do the trick.


operator-sdk run bundle cannot pull private bundle image

Bug Report

What did you do?

operator-sdk run bundle hyc-cloud-private-scratch-docker-local.artifactory.swg-devops.com/ibmcom/common-service-operator-bundle:3.7.1

What did you expect to see?

CatalogSource pod created by run bundle should be in Running state, and operator installed
What did you see instead? Under which circumstances?

CatalogSource pod is in CrashLoopBackOff state
Output of run bundle
INFO[0011] Successfully created registry pod: tory-swg-devops-com-ibmcom-common-service-operator-bundle-3-7-1
INFO[0011] Created CatalogSource: ibm-common-service-operator-catalog
INFO[0011] OperatorGroup "operator-sdk-og" created
INFO[0011] Created Subscription: ibm-common-service-operator-v3-7-1-sub
FATA[0120] Failed to run bundle: install plan is not available for the subscription ibm-common-service-operator-v3-7-1-sub: timed out waiting for the condition
Makefile:200: recipe for target 'run-bundle' failed
make: *** [run-bundle] Error 1

Logs from CatalogSource pod
time="2021-03-12T21:37:05Z" level=info msg="adding to the registry" bundles="[hyc-cloud-private-scratch-docker-local.artifactory.swg-devops.com/ibmcom/common-service-operator-bundle:3.7.1]"
time="2021-03-12T21:37:06Z" level=error msg="permissive mode disabled" bundles="[hyc-cloud-private-scratch-docker-local.artifactory.swg-devops.com/ibmcom/common-service-operator-bundle:3.7.1]" error="[error resolving name : failed to authorize: failed to fetch anonymous token: unexpected status: 401 Unauthorized, image \"hyc-cloud-private-scratch-docker-local.artifactory.swg-devops.com/ibmcom/common-service-operator-bundle:3.7.1\": not found]"
Error: [error resolving name : failed to authorize: failed to fetch anonymous token: unexpected status: 401 Unauthorized, image "hyc-cloud-private-scratch-docker-local.artifactory.swg-devops.com/ibmcom/common-service-operator-bundle:3.7.1": not found]
Usage:
  opm registry add [flags]

Flags:
  -b, --bundle-images strings   comma separated list of links to bundle image
  -c, --container-tool string   tool to interact with container images (save, build, etc.). One of: [none, docker, podman] (default "none")
  -d, --database string         relative path to database file (default "bundles.db")
      --debug                   enable debug logging
  -h, --help                    help for add
      --mode string             graph update mode that defines how channel graphs are updated. One of: [replaces, semver, semver-skippatch] (default "replaces")
      --permissive              allow registry load errors

Global Flags:
      --skip-tls   skip TLS certificate verification for container image registries while pulling bundles or index

Environment
Operator type:

/language go

Kubernetes cluster type:

Openshift 4.6.16
$ operator-sdk version

operator-sdk version: "v1.3.0", commit: "1abf57985b43bf6a59dcd18147b3c574fa57d3f6", kubernetes version: "1.19.4", go version: "go1.15.5", GOOS: "linux", GOARCH: "amd64"

Also tried with operator-sdk version 1.5.0
$ go version (if language is Go)

go version go1.15.5 linux/amd64
$ kubectl version

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:23:52Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0+e49167a", GitCommit:"e49167aad6a08046be6ab21ff13029110c76951d", GitTreeState:"clean", BuildDate:"2021-01-28T07:35:27Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

Possible Solution

CatalogSource pod should additionally use global cluster pull secret
Additional context

Few things I can confirm:

Image does exist as I can successfully pull it locally
Cluster global pull secret is configured for that private registry
Cluster is able to pull images from private registry since I successfully deployed Deployment using another image

I tried adding my private registry credentials to the imagePullSecrets the pod was using, but got the same result:

added credentials to pod's imagePullSecrets secret
ran operator-sdk cleanup ibm-common-service-operator
re-ran run bundle command
pod in CrashLoopBackOff (confirmed that pod has the same imagePullSecrets)

Found a related bugzilla report https://bugzilla.redhat.com/show_bug.cgi?id=1883198
Also, potentially another bug; the pod name was tory-swg-devops-com-ibmcom-common-service-operator-bundle-3-7-1. Seems like there is a character limit to the name that does not match Kubernetes' character limit for names.

/kind feature

Same problem for us, ie the"opm registry add" does not trust the CA set up on the cluser and on the underlying nodes even if the steps are slightly different
We are trying to go through the quickstart for go and it fails executing this step (registry url replaced by xxx)
export BUNDLE_IMG="xxxxxx.xxxx.xxx.xxxxx.xxxxx/xxxxx/memcached-operator-bundle:v0.0.1"
operator-sdk run bundle $BUNDLE_IMG

Versions:
minikube (fail also on microk8s)
operator-sdk version: "v1.4.2", commit: "4b083393be65589358b3e0416573df04f4ae8d9b", kubernetes version: "1.19.4", go version: "go1.15.5", GOOS: "linux", GOARCH: "amd64"
go version go1.15.10 linux/amd64
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.1-5-g76a04fc", GitCommit:"c66c03f3012a10f16eb86fdce6330433adf6c9ee", GitTreeState:"clean", BuildDate:"2021-02-13T03:54:59Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

The errors are not in the "CatalogSource" pod as described in the initial post but from a pod namedxxx-xxxx-xxx-xxxx-xxxx-xxxx-memcached-operator-bundle-v0-0-1created by the"operator-sdk run bundle"
The image registry uses a certificate emitted by the corporate CA, the cluster is configured with it and all the images running in the cluster are pulled from the registry without any problem
time="2021-03-23T00:55:50Z" level=info msg="adding to the registry" bundles="[xxxxxx.xxxx.xxx.xxxxx.xxxxx/xxxxx/memcached-operator-bundle:v0.0.1]"
time="2021-03-23T00:55:50Z" level=error msg="permissive mode disabled" bundles="[xxxxxx.xxxx.xxx.xxxxx.xxxxx/xxxxx/memcached-operator-bundle:v0.0.1]" error="[error resolving name : failed to do request: Head https://xxxxxx.xxxx.xxx.xxxxx.xxxx/v2/denis/memcached-operator-bundle/manifests/v0.0.1: x509: certificate signed by unknown authority, image \"xxxxxx.xxxx.xxx.xxxxx.xxxxx/xxxxx/memcached-operator-bundle:v0.0.1\": not found]"
Error: [error resolving name : failed to do request: Head https://xxxxxx.xxxx.xxx.xxxxx.xxxxx/v2/xxxxx/memcached-operator-bundle/manifests/v0.0.1: x509: certificate signed by unknown authority, image "xxxxxx.xxxx.xxx.xxxxx.xxxxx/xxxxx/memcached-operator-bundle:v0.0.1": not found]
Usage:
  opm registry add [flags]

Flags:
  -b, --bundle-images strings   comma separated list of links to bundle image
  -c, --container-tool string   tool to interact with container images (save, build, etc.). One of: [none, docker, podman] (default "none")
  -d, --database string         relative path to database file (default "bundles.db")
      --debug                   enable debug logging
  -h, --help                    help for add
      --mode string             graph update mode that defines how channel graphs are updated. One of: [replaces, semver, semver-skippatch] (default "replaces")
      --permissive              allow registry load errors

Global Flags:
      --skip-tls   skip TLS certificate verification for container image registries while pulling bundles or index

Q:

is there a workaround for this problem?
is there a way to configure the opm registry add...command running in the generated pod to use the CA of the cluster or use some ConfigMap/Secret?

@titou10titou10 unfortunately not at the moment.

@jmrodri OK. thx
IMHO it should be added in the documentation that you can't use theoperator-sdk run bundlecommand in the quickstart  and in the tutorial if you are using a private image registry using a private/corporate CA
Only the mnaual way is working in this case

I'm going to take this on. Will update docs prior to the next release so at least readers are aware of this issue, if the feature doesn't land in v1.6.

Also this is a scorecard issue too I believe.

@bitscuit @titou10titou10 #4694 implements this feature. Let me know if the options provided are sufficient to pull private bundles.

thanks @estroz, they look good to me.

@estroz I don't think it solves the problem. AFAIK there is no way to set a CA inside an"imagePullSecret", you can only set the credentials (user/password/email)
To solve the problem, we should be able to specify a file with the CA cert to the"opm registry add" command via the"operator-sdk run bundle"command
"opm registry addalready has a" --skip-tls"option but there is no way to set it via  the"operator-sdk run bundle"`command and AFAIK it will try to access the registry in HTTP instead of HTTPS. It would not solve the problem here
The "operator-sdk run bundle"command should be updated to optionnaly pass a new option ("--opm-ca-cert=<ca cert file>"?) to specify the CA cert file. The opm registrycommand must also be changed to use that file
Another option would be to change the opm registrycommand to use the cluster CA directly
As for the --skip-tls option to be used by theopm registrycommand, It should also be added to the"operator-sdk run bundle" and passed to the underlying command, but It will not solve my problem here

@titou10titou10 opm registry add will use the cert pool present in the pod when pulling an image, which can be configured with the cluster CA. Perhaps allowing a cert to be passed to opm registry add would be convenient.

@estroz your latest code changes look great. Thanks!

@titou10titou10 if it's desirable to skip TLS, then I don't see a problem exposing --skip-tls from opm registry add in operator-sdk run bundle. To use a specific remote registry CA, you'd first create a secret containing the root certificate of that registry, then set that secret's name with --ca-secret-name:
kubectl create secret generic tls-ca --from-file=cert.pem=/path/to/registry/cert.pem
operator-sdk run bundle public-ca-reg.com/my-bundle:v0.1.0 --ca-secret-name=tls-ca

If a pull secret is also required, i.e. for a private registry, you'd run
kubectl create secret generic tls-ca --from-file=cert.pem=/path/to/registry/cert.pem
kubectl create secret docker-registry reg --docker-username=foo --docker-password=bar123 --docker-server=https://private-ca-reg.com
kubectl patch serviceaccount default -p '{"imagePullSecrets":[{"name":"reg"}]}'
operator-sdk run bundle private-ca-reg.com/my-bundle:v0.1.0 --secret-name=reg --ca-secret-name=tls-ca

Ideally the cluster, namespace, and service account used will have been provisioned with the appropriate secrets beforehand, so the above just becomes
operator-sdk run bundle private-ca-reg.com/my-bundle:v0.1.0 ...

Perhaps renaming --secret-name to --pull-secret-name would clarify flag meanings. Thoughts?

@estroz excellent
If you ask my opinion for the parameter name, as those parameters are not directly related to the"operator-sdk run bundle"command but to the underlying"opm registry add"command, I would prefix them with "opm", ie
--opm-ca-secret-name
--opm-pull-secret-name
--opm-skip-tls

just my 2cts


fix(Search): Merge nested shorthand props for the  element

...instead of overriding the hardcoded ones.
Fixes #3750.

Thanks for contributing, I will review these changes and will let you know soon.

As per my comment on the feedback, I think my attempt to delegate handling of the nested shorthand to the Input component using existing mechanisms failed.
Another approach I initially considered was to have Search call the createHTMLInput() factory itself to simulate the recursive behaviour desired. However it feels wrong not to delegate to Input for this, since:

It would be duplicating logic making it more brittle in case Input were to change.

It would be doing extra, unnecessary work during the render since it would run through createHTMLInput() twice.

So yeah, for these reasons I think nested shorthands probably need a more generic solution inside createShorthand() itself, e.g. by looking at the component's prop metadata, or the caller explicitly specifying the props for the nested shorthands that should be deep merged. Or maybe you could get away with an explicit utility function like mergedPropsForShorthand().
Personally I don't think I'm up for such an involved feature, so feel free to close this PR if it's no longer useful.

Codecov Report

Merging #3785 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
- Coverage   99.84%   99.83%   -0.01%
==========================================
  Files         184      172      -12
  Lines        3164     3102      -62
==========================================
- Hits         3159     3097      -62
  Misses          5        5

Impacted Files
Coverage Δ

src/modules/Search/Search.js
99.54% <100.00%> (+0.01%)
:arrow_up:

src/modules/Popup/Popup.js
98.71% <0.00%> (-0.02%)
:arrow_down:

src/elements/Flag/Flag.js
100.00% <0.00%> (ø)

src/addons/Portal/Portal.js
100.00% <0.00%> (ø)

src/views/Feed/FeedSummary.js
100.00% <0.00%> (ø)

src/modules/Dropdown/Dropdown.js
100.00% <0.00%> (ø)

src/collections/Form/FormField.js
100.00% <0.00%> (ø)

src/modules/Search/SearchCategory.js
100.00% <0.00%> (ø)

src/modules/Transition/Transition.js
100.00% <0.00%> (ø)

src/behaviors/Visibility/Visibility.js
100.00% <0.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac8009...5e00c55. Read the comment docs.


refactor existing go tests which requires Docker config to accept TCP connection

Currently [sanity_test] ( https://github.com/vmware/docker-volume-vsphere/blob/master/vmdk_plugin/sanity_test.go ) requires docker config to be set in order to accept TCP connection.
The test can be refactored further as we have automated some tests which uses ssh channel to invoke docker CLI.
// @msterin

@shuklanirdesh82 can you evaluate this issue and close or specify what more changes needs to be done.

This issue was meant for enhancing the existing test to use ssh way of making call (to keep in sync with other tests) instead of TCP connection for communicating to docker daemon.
More over, person has to configure test VM to open port 2357 to let vms talk among over tcp.
I think we may close this issue having it said we have test bed deployment automation script and no more issue while using automated testbed.


Avoid printing git error when checking version on badly packaged version

What was the end-user problem that led to this PR?
The problem was https://github.com/bundler/bundler/issues/6453.
What was your diagnosis of the problem?
A use had a version of Bundler packaged with Ruby 2.5.0 in RVM, but this version didn't include Bundler's git repo or any of the ivars which should have been set. As a result, Bundler was shelling out to git even though it wasn't in a git repo.
What is your fix for the problem, implemented in this PR?
My fix is to show a nicer result in this case (just say that the SHA is unknown)
Why did you choose this fix out of the possible options?
I chose this fix because ensuring Bundler is always packaged correctly by others isn't possible (although it seems weird and unlikely that a version without instance variables set would be used). Falling back to a cleaner error message is marginally nicer than what we currently have, and not much work.
Fixes #6453.

Thank you!
@bundlerbot r+

Oops that was me.

@bundlerbot retry


Modifying docs

This change includes compacting of Readme to move out installation steps in separate document and chalk out the steps the script is actually helps to automate.

@abraham-jebaraj Can you please review.
Thanks!

done


Show presynopsis seminar and Thesis seminar along with AWS list to user.

Show presynopsis seminar and Thesis seminar along with AWS list to user.

No further enhancement in this repo except for API.


[New policies] Azure Cosmos DB - WAF - Reliability

Two new policies to support upcoming WAF guidance around reliability:

[x] policyDefinitions/Cosmos DB/cosmos-db-audit-georeplication/azurepolicy.json: Validates that there is at least two regions for the Azure Cosmos DB account.
[x] policyDefinitions/Cosmos DB/cosmos-db-audit-service-managed-failover/azurepolicy.json: Validates that service-managed failover is enabled for the Azure Cosmos DB account.

Thanks @techlake, I will make those changes now.

@techlake, I have made those changes after reviewing the contributor guide. Thank you for the guidance.


About CULane official evaluation function

Hello,
I have run the enet_baseline model,and I have gotten the result 'checkpoints/enet_baseline_/culane/model.pt'.And then I the test enet_model ,and got the output 'output/driver_frame/.MP4/*.lines.txt'.But when I run './tools/culane_evaluation/eval.sh' to evaluate the output files, I got the number 0 or -1

Have you ever encountered such a situation?
And the configuration in eval.sh:
data_dir is the original CULane data which download from website
detect_dir is the output of the test 'python main_landet.py --test --config=configs/lane_detection/baseline/enet_culane.py --mixed-precision'
Is there anything wrong with my configuation?

And the eval class configuration 'output/out*.txt' ,I copy the downloaded from website CULane to this directory and renamed them

@huanFigure I only encounter this when the model really have 0 accuracy. Did you train the model yourself? Perhaps try testing one of the uploaded checkpoints and verify if the issue is in evaluation script?

Thanks for your replay. I have solved this problem. The reason is that the file name generated by the test end with '.jpg.lines.txt' which doesn't match  the original file name '.lines.txt'


Vehicle Issues

Hi friend,
I understand Starfinder vehicles has a warning that this section is still in development but I thought I'd let you know that I have been having some issues with rolling weapon attacks and damage rolls from vehicles. I thought it may have been my mods causing the issues so I tried again in a mod-free test world but still had the same issues. Apologies if you are already aware of this!
Kind regards
Ryan

Vehicle weapons are only partially implemented. It's on the roadmap, but I can't give any kind of timeline for when it'll be fully implemented.


How can we combine brownfield data with other data sets?

See link to an interactive map I created of Vacant and Derelict Land (VDL) in Scotland - which combines various data. VDL as site centroids as published by Scot gov. (the polygons aren't publicly available so I couldn't use these), Deprivation layer, OS Open Buildings layer. [https://twitter.com/danc00ks0n/status/1174330577778094081]


Explicitly delete Estimator before copying output_dir

Hopefully this fixes #9185 by releasing some stray file handle.

I triggered http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/3/console
I hope the setup is the same as tf-master-win-bzl.
@meteorcloudy FYI.

@martinwicke I tested on my local machine as well, it doesn't seem to fix the problem.
But I found shutil.copytree(model_dir1, model_dir2) works, can we use this instead of os.rename?

The problem with that would be that this does not delete the old tree. This test is to ensure that no absolute paths creep in anywhere, so this would defang the test.
I cannot see what hangs on to a file handle.

Perhaps the easiest approach would be to install the current nightly on one of our Windows test VMs, run a modified version of estimator_test.py that blocks before the rename, and apply https://technet.microsoft.com/en-us/sysinternals/processexplorer.aspx to the Python interpreter to see what handles are open?

@mrry It shows this file is in use by python
c:/tmp/tmp3y2vhvzi/model_dir1/events.out.tfevents.1492671112.TENSORFLOW-JENK

Thanks for tracking that down, Yun! Then I think we have a smoking gun: the tf.summary.FileWriter is holding open a file handle after est1.train() returns.
It looks like this happens deep in the MonitoredTrainingSession... and there seems to be a cache(!!) involved:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/summary/writer/writer_cache.py#L27
As a hack, you might try invoking FileWriterCache.clear() before the rename, but I'm not sure that that's sufficient because deleting a FileWriter doesn't appear to close() it, so you might need to add a writer.close() call somewhere (or maybe add it to the destructor?).

@mrry Thanks for the hint, Derek!
I tested adding writer_cache.FileWriterCache._cache[model_dir1].close() before rename also solves the problem. Does this sounds good to you?

That'll fix the test, but I'm wondering whether we can get put that line (or some equivalent) somewhere were it will be called automatically when the Estimator owning the model_dir is deleted?

I'm even wondering whether we should even keep the cache live when any of train(), eval(), predict() exit. They're all meant to be long running and ideally shouldn't leave open file handles hanging around.

@martinwicke Yes, I totally agree! But I am lack of knowledge how these function works. Can someone with more experience look into this?

Jenkins, test this please.

Triggered another Windows build: http://ci.tensorflow.org/job/tensorflow-pr-win-bazel/4/

I edited FileWriterCache to close() all caches it has, and call that in the test. Cleaner than closing the cache directly.

I'll merge to fix build.


sql日志打印多遍建议只打印最后执行sql

Please answer these questions before submitting your issue. Thanks!
Which version of Sharding-Jdbc do you using?
Expected behavior
Actual behavior
Steps to reproduce the behavior
Please provide the reproduce example codes (such as github link) if possible.

这个并无决定的对与错，我认为打印日志多一些也没什么问题。因此先不修改了


VLSU Support

PR Goal:
Implement VLSU instruction support. Current implementation uses the LSU design and adds vector iterations based on VLEN and data width of VLSU.

@kathlenemagnus
If you could look at the VLSU.cpp (specifically the completeInst_) for context for the rest of this comment when you get the chance. I've updated my code to work around how the LSU handled stores, but the issue I was running into and had to work around can be summarized as:

Stores get retired before "completing" in the LSU. This is an issue because:

We need to send multiple memory requests through. If on vector store has 16 passes needed, so 16 memory operations, we need to send that many through. However, the wrappers for LoadStoreInfo and MemoryAccessInfo, which contain relevant data to cache, TLB, and MMU status include the InstPtr. This becomes an issue if we have multiple requests, because the InstPtr already has a retired status, but the next requests will try to set the status thus resulting in an error.
The work around I did was to create a separate status per each LoadStoreInfo wrapper, thus each memory request has it's own status, that is separate from the instruction's.
A couple questions:

Currently in my design, the memory requests are sent through the VLSU serially, so we have to wait for the first pass to finish before the 2nd pass can begin for the same vector instruction. This is due to the current design of the LSU, because we're only assuming one memory request per instruction, which is the case for LSU, but not VLSU. The benefit of this is that if there are multiple vlsu instructions, they fully utilize the pipeline because while instruction A's memory request is waiting for the cache, instruction B's memory request is at a different stage of the vlsu pipeline. My question is does this type of design make sense? Or should rearchitect this to work differently similar to the uop generator in vlsu that Knute had suggested?
The vlsu uop generator idea would only process one vlsu instruction at a time, but generate lets say 16 memory requests that then queue up in the VLSU. The flow would look like:

vlsu_uop_generator -> generates 16 memory requests for instruction A
vlsu_ldst_queue_ -> takes the memory requests, queues them up, begins processing them through the pipeline
vlsu -> once all memory requests are through, we officially retire instruction A
(repeat for all vlsu instructions)
vlsu_uop_generator -> generates 16 memory requests for instruction B
...

I wanted to check all this with you and Knute before proceeding, because it will change a bit of how the VLSU works compared to the LSU, especially around the setting of instruction status vs creating a LoadStoreInfo status due to the nature of VLSU instructions.

The work around I did was to create a separate status per each LoadStoreInfo wrapper, thus each memory request has it's own status, that is separate from the instruction's.

I think this is the right solution. Each memory access should be completed separately and then a vector instruction can be marked completed if all of its memory accesses have completed.

Currently in my design, the memory requests are sent through the VLSU serially, so we have to wait for the first pass to finish before the 2nd pass can begin for the same vector instruction. This is due to the current design of the LSU, because we're only assuming one memory request per instruction, which is the case for LSU, but not VLSU. The benefit of this is that if there are multiple vlsu instructions, they fully utilize the pipeline because while instruction A's memory request is waiting for the cache, instruction B's memory request is at a different stage of the vlsu pipeline. My question is does this type of design make sense? Or should rearchitect this to work differently similar to the uop generator in vlsu that Knute had suggested?

I would rearchitect like Knute suggested. What we want is for a vector instruction to be able to generate multiple memory accesses. They can be executed serially, but they should be able to be pipelined. So 1 vector instruction should be able to send a uop down the LSU pipeline every cycle. Similarly to how we used to track whether a parent instruction was "done" in the ROB, a vector load or store should expect multiple memory accesses to be completed before it can be marked as done. One thing to be careful of though is that there should only be 1 writeback to the vector destination. So you will need some sort of structure for collecting all of the data returned to the LSU.

The vlsu uop generator idea would only process one vlsu instruction at a time, but generate lets say 16 memory requests that then queue up in the VLSU. The flow would look like:

vlsu_uop_generator -> generates 16 memory requests for instruction A
vlsu_ldst_queue_ -> takes the memory requests, queues them up, begins processing them through the pipeline
vlsu -> once all memory requests are through, we officially retire instruction A
(repeat for all vlsu instructions)
vlsu_uop_generator -> generates 16 memory requests for instruction B

I wanted to check all this with you and Knute before proceeding, because it will change a bit of how the VLSU works compared to the LSU, especially around the setting of instruction status vs creating a LoadStoreInfo status due to the nature of VLSU instructions.

Let's talk about this more on Monday. I see two paths forward here:

We could do as you suggest and "sequence" the vector load store instruction when it gets to the LSU and generate a memory request that is stored in the LDST queue. These memory requests would behave like scalar instructions in the queue. The question here is when to trigger WB. It's inefficient to writeback to the vector destination 16 times and it is not always possible to do partial writes to the register file.
Another option would be to keep the vector instruction in the LDST queue and send it down the LSU pipe multiple times. Each time it gets sent down the pipe it would generate a different memory access. Again, we need a way to track all of the data that has come back and make sure it's all ready before sending the vector instruction down the pipe a final time to do writeback.

@klingaard @kathlenemagnus this should be ready for review/merge.

Closing due to @kathlenemagnus's PR


Production Logging

Production level logging is required to be able to easily troubleshoot production issues.
Logging was added in gh-159 but at the TRACE level.  TRACE is fine for development but not for production.
Please add logging more suitable for troubleshooting production issue.

@dciarniello, thanks for reaching out!

Logging was added in https://github.com/spring-projects/spring-authorization-server/issues/159 but at the TRACE level. TRACE is fine for development but not for production.

The goal of gh-159 was to add enough logging to allow efficient troubleshooting during the development cycle without adding too much detail. Adding more details and more logging requires specific use cases and will not likely be addressed as a general request.

Please add logging more suitable for troubleshooting production issue.

Please provide some additional information about your request, and be specific if possible. Depending on the number of use cases you can provide, we could potentially open an issue for each use case or an issue for one or more themes (groups of related use cases) that emerge from the request.

Thanks @dciarniello, that's a pretty good list to start with.
One thing we're thinking about right now (that is a bit of a detour from logging) is customization around the processing flow itself. I feel like if we add the right types of hooks into the processing flow of e.g. the AuthenticationProviders or Filters (such as in gh-1075 and a few other suggestions), there's potential to solve two problems at once. Meaning, even if the core framework didn't have direct support for every single logging case, it would ideally be trivial to add your own logging in a specific place without much work. This would help unblock some of those needs from being bound to a specific future release, if you need it sooner. So I see two things here:

Add hooks into the processing flow, specifically for failure cases.
Add additional logging in the framework itself.

Depending on where either of these fits in the priority list, one could be addressed earlier than the other. I also think that the second request (this issue) could be addressed as contributions from the community since we have some logging in place already to show the general (simple) pattern. So if you're interested in sending any PRs, let me know!
For now, I'll do some checking, and see about adding an issue for each of the logging use cases you point out above so they are small bite-sized issues, then I'll close this issue as a duplicate. Sound good? Let me know if you have any other thoughts.

Closing as a duplicate of gh-1245, gh-1246, gh-1247, and gh-1248.

Hi, @sjohnr.
Thanks for looking into this and creating the individual tickets.  Much appreciated.


Feature: Add support for defining custom container securityContext

closes #67

This PR has some problems:

chart version bump is missing
in this way enabled: true also ends up inside the securityContext

It needs to be fixed up a bit and will probably introduce some breaking changes.

@pierluigilenoci enabled: true won't end up in the securityContext.
It is removed with Helm's unset function in line 192:
{{- $securityContext := unset .Values.securityContext "enabled" }}

Or should I introduce some breaking changes like this?
 {{- with .Values.podSecurityContext }}
 securityContext:
   {{- toYaml . | nindent 8 }}
 {{- end }}

@pierluigilenoci enabled: true won't end up in the securityContext. It is removed with Helm's unset function in line 192:

You're right, I didn't notice.
However, the version still needs to be updated because we merged another PR a few minutes ago.
For me it is enough but I would like the opinion of another maintainer.

Alright, I will update the bump


Update weekday-function-dax.md

There is an error in the number range that is returned by the Return Type 3. It should be 0 to 6, instead of 1 to 7.

@kfollis

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off