Add render prop support

import React from 'react';
import InputMask from 'react-input-mask';
import styled from 'styled-components';

const StyledInput = styled.input`
  border-color: red;
`;

class Input extends React.Component {
  render() {
    return <InputMask mask="99999-9999" render={(ref, props) => <StyledInput innerRef={ref} {...props} />} />;
  }
}

I'm not familiar with test writting. Help is appreciated.

I would use children as function variant to be in sync with react itself (new context api). It's also more readable with some nesting inside such function.

@denisborovikov @TrySound I'm working on it right now, stay tuned.

Thanks, guys, just wanted to share the idea, glad you're on it already.

Using children or render function might lead to confusion on what input — parent or child — should you listen to events. What do you think about this syntax with inputComponent prop?
import React from 'react';
import InputMask from 'react-input-mask';
import TextField from '@material-ui/core/TextField';

class Input extends React.Component {
  state = {
    value: ''
  }

  onChange = (event) => {
    this.setState({
      value: event.target.value
    });
  }

  render() {
    return <InputMask
      inputComponent={TextField}
      mask="99999-9999"
      value={this.state.value}
      onChange={this.onChange}
    />;
  }
}

The problem with it is a possibility to get a conflict between react-input-mask's and child's properties. For example, TextField in material-ui has its own inputRef prop which is impossible to use with this syntax.

As for me, I don't see any confusion here. But you may allow using only prop getters inside the render prop.
Something like
<InputMask
    mask="99999-9999"
    value={this.state.value}
    onChange={this.onChange}
>
 ({ getInputProps }) => <input {...getInputProps()} />
</InputMask>

Might work, but it will be great if we can find a simpler solution. To make it clear for someone who isn't familiar with react-input-mask, but has to fix an error in this code.

You may write a descriptive changelog with diff in examples like this
- <InputMask />
+ <InputMask>
+   {() => null}
+ </InputMask>

@denisborovikov @TrySound Implemented support for children function.

Cool

Ah, I see findDOMNode. Not cool. It won't work with async react and probably will be deprecated soon.

Will work around this when it happens :)

@TrySound Any ideas how to find input node inside children without findDOMNode and wrapping input into another node?

As I see both react-powerplug and react-measure attach to the actual DOM node with bind or measureRef and can't be used with functional components, can they?

Do you expect any kind of abstraction there? For this purpose was introduced React.forwardRef helper. So it's not a problem.

I still think prop getter is a good pattern that could fit into this case perfectly. More about the pattern here. It allows to combine parent and child handlers.
<InputMask
    mask="99999-9999"
    value={this.state.value}
    onChange={this.onChange}
>
 ({ getInputProps }) => <input {...getInputProps({ onChange: this.onChangeHalndler})} />
</InputMask>

Clarification of not using some props seems weird for me and definitely not a simpler solution.

I don't think somebody need to apply more than one callback here. It's better to use InputMask as proxy and listen only it. Children as function should be used only for changing element (from material ui for example), styling and not related to masking stuff.

I don't think such components are supposed to be customized with masks. They hide dom element so it's not our problem.

For things which exposes innerRef/componentRef bind may be passed explicitly without spread.

But it also might be the main concern to pass component inside react-input-mask (#80). Let's make it more universal for now and see on the actual use cases. While It's an experimental feature and it's compatible with all current versions of React, I think it's fine to rely on findDOMNode until we get some statistics or until we find out a better alternative to findDOMNode.


Reorder table properties to match specification

Desired Behaviour
Reorder table properties to match specification. E.g. Primary keys should be after Missing Values

This should be extended to Foreign Keys


Running a checkpoint bot on testnet

We're going to want checkpoint bots targeting each pool (there will be 4 pools).

should be resolved by https://github.com/delvtech/agent0/issues/1393 but we will want to test again after the next round of releases.

Completed via
https://github.com/delvtech/agent0/pull/1397
https://github.com/delvtech/agent0/pull/1400


Create a documentation website using Github pages

It is hard to navigate/search within the Github interface to read the docs for zulip-mobile.
Since zulip-mobile has it's own documentation, separate from that of zulip server, it might be helpful if a documentation website were to be set up at the https://zulip.github.io/zulip-mobile sub-domain using Github pages, perhaps using Jekyll to manage them easily (https://jekyllrb.com/)
An example of this type of setup can be seen https://crux-bphc.github.io/fest-manager/.
The organization is crux-bphc, and the above link points to the documentation of the fest-manager project, which resides in the docs folder of the source repository.
There is already a docs folder in the zulip-mobile repository, so setting up the documentation website should not involve significant refactor of the repository.
I will be happy to work on this should this idea be approved.

Can I work on this issue ?

One antifeature of the above solution (as seen at https://github.com/crux-bphc/fest-manager/tree/master/docs) is that, when viewed from the repository itself, links between documents no longer function.
This is not a fatal objection – we've already accepted this downside in the Zulip server repo, as can be seen at https://github.com/zulip/zulip/tree/master/docs – but if there's a reasonable way to avoid that and keep the inline documentation functional, it would be much preferred.

With modern ReadTheDocs at least, it's now possible to make those links work on GitHub as well as in ReadTheDocs, as long as they're not to a hash within the page (those links are still broken).  We use that for the Zulip server repo now, and I imagine eventually recommonmark will fix that too.
I suspect we'd prefer using ReadTheDocs than GitHub Pages, if for no other reason than for consistency with the main Zulip webapp (It's also very convenient to administer and has nice support for things like configuring redirects when you rename a page).  I suspect it might even be possible to make our ReadTheDocs build script for the server project fetch zulip-mobile and build its docs in a "mobile" subsection, if desired (though we might need to be somewhat careful to avoid making a build-dependency on the mobile project?), but we could certainly make a zulip-mobile.readthedocs.org.
I'm happy to let the mobile folks figure out how to proceed, but wanted to raise that idea.
@drrosa FYI as he made be able to add more.

The main question I'd want us to answer before trying this is what we're aiming to gain.
The OP says it's hard to navigate/search; but I don't see any way at all to search on the example docs site https://crux-bphc.github.io/fest-manager/, nor any overall navigation, so it doesn't seem like GitHub Pages is helpful for that.
On the other hand ReadTheDocs would be helpful for that problem statement, if we want to work on that -- it provides a prominent overall navbar and a search feature.
One thing that example GitHub Pages site does do is that it looks quite a bit slicker than a GitHub browse page. That'd be under our control with either GitHub Pages or RTD. I'm not convinced that's a priority, though.

@agrawal-d
Notice you can search the zulip-mobile documentation by simply adding a couple of parameters to a normal GitHub search like so: repo:zulip/zulip-mobile language:Markdown and you get both Basic Search and Advanced Search of docs for free.
I know that docs navigation on Github is not ideal, but the zulip-mobile repo has only about 35 Markdown files of documentation compared to 100+ in the server project. I hope the search trick makes things at least a little easier.
@timabbott
I think it wouldn't be a bad idea for the mobile project to start using ReadTheDocs at some point, but I'd say the zulip-mobile docs are still small and manageable enough that switching over right now would most likely add a bit of unnecessary overhead to the project.
Also, given the mobile project has been sticking to Github and Markdown only, I think that a neater alternative would be https://rust-lang.github.io/mdBook. mdBook is meant for Markdown files only, looks nice, has both search/nav bar features, and it can be used as a command-line tool so setting it up shouldn't be difficult. It was created for the Rust project and so it continues to be well maintained.
@gnprice
I think it would be a good idea to put a README in https://github.com/zulip/zulip-mobile/tree/master/docs that includes a table of contents and the basic/advanced search links I provided above just for convenience and to improve navigation a bit.

Also, given the mobile project has been sticking to Github and Markdown only, I think that a neater alternative would be https://rust-lang.github.io/mdBook. mdBook is meant for Markdown files only, looks nice, has both search/nav bar features, and it can be used as a command-line tool so setting it up shouldn't be difficult. It was created for the Rust project and so it continues to be well maintained.

Interesting, thanks for the pointer! When playing with Rust and Rust-related projects, I have generally felt that the docs are nicely rendered, so that is a point in favor of that tool.

@gnprice
I think it would be a good idea to put a README in https://github.com/zulip/zulip-mobile/tree/master/docs that includes a table of contents and the basic/advanced search links I provided above just for convenience and to improve navigation a bit.

That's probably a good idea, thanks.

I think it would be a good idea to put a README in https://github.com/zulip/zulip-mobile/tree/master/docs that includes a table of contents and the basic/advanced search links I provided above just for convenience and to improve navigation a bit.

OK -- I've just pushed 1ec5b640f and 1ec1d6b75. Please take a look, and thanks again @drrosa for the suggestion!
I'm going to close this issue, because I don't think we'll be pursuing a move to GitHub Pages.


fragment should have a closing tag

To be more compatible with custom elements spec Tailor should use closing </fragment> tag and might use the content as a fallback.

#44 Will be addressed by this.


Expose a compile-time constant to determine which version of spirv-tools is being used.

This is useful specifically when there is an api-breaking change. Something like:
   #ifdef SPV_TOOLS_VERSION < X
   #else
   #endif

Right now our versioning is keyed off of a build step.
So for a from-source build we'd be adding a source dependency to the build output tree.  I don't think we have that for our public interface.
For an installed version of the library, we can migrate a generated file to the output install include dir, so that would be easier.
Not clear to me what to do here.


Bump highlights.js from 10.4.1 to 11.0.1 in bridge

Signed-off-by: Elisabeth Lang<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Save output of K6 Results into InfluxDb + Grafana

🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
Currently we have a working suite of performance tests for hedera-json-rpc-relay, but the results of the tests are presented as a .md file so interpretation is limited.
Ideally we would like to have a graphical dashboard where we can have more insightful presentation and comparison of performance tests results.
Proposed Solution:

Provision an influxDB for k6
Create npm task that use necessary options to save to influxdb and do an initial run.
Add (Import) influxDB to Grafana server as a DataSource
Create dashboard to show and present the results of the tests.

Recommended templates: This templates should be used as starting point and examples.
https://grafana.com/grafana/dashboards/2587-k6-load-testing-results/
https://grafana.com/grafana/dashboards/10660-k6-load-testing-results/
K6 Doc on Export to InfluxDB:
https://k6.io/docs/results-output/real-time/influxdb-grafana/
Example of desired output:

Alternatives

use a GDrive Spreadsheet to generate some graphs.
Continue to use the MD report storing it on a Notion page for reference.

📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

[ ] Claim this issue: Comment below that you are interested in working on the issue
[ ] Wait for assignment: A community member with the given rights will add you as an assignee of the issue
[ ] Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
[ ] Check out the forked repository
[ ] Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
[ ] Solve the issue in your branch.
[ ] Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
[ ] Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
[ ] Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
[ ] Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
[ ] You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional Information
If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

Assign me !


README file has wrong default port for the frontend

The default port for the frontend is 8080, not 8081 as stated in the README file.

Readme updated. I have a server already running in port 8080 so my frontend ended up using the port 8081


404s on every path except 'metrics'

Built with Go 1.10.1 and Hashcat 3.6.0 on Arch Linux.  Everything appears to be working including worker authentication, except that I can't access the web interface itself:
gocrack_server log:
{"time":"2018-04-30T19:13:16+09:00","level":"info","addr":"[::]:1338","message":"HTTP Server listening"}
{"time":"2018-04-30T19:13:16+09:00","level":"info","addr":"[::]:1339","message":"RPC Server listening"}
{"time":"2018-04-30T19:13:42+09:00","level":"info","client_ip":"<IP_ADDRESS>","method":"POST","path":"/rpc/v1/beacon","status":200,"latency":"1.278765ms","message":"Processed HTTP
Request"}
{"time":"2018-04-30T19:14:00+09:00","level":"info","client_ip":"153.222.[redacted]","method":"GET","path":"/","status":404,"latency":"402.028�s","message":"Processed HTTP Request"}
{"time":"2018-04-30T19:14:12+09:00","level":"info","client_ip":"<IP_ADDRESS>","method":"POST","path":"/rpc/v1/beacon","status":200,"latency":"950.842�s","message":"Processed HTTP
Request"}
{"time":"2018-04-30T19:14:32+09:00","level":"info","client_ip":"153.222.[redacted]","method":"GET","path":"/metrics","status":200,"latency":"6.884966ms","message":"Processed HTTP
Request"}
{"time":"2018-04-30T19:14:42+09:00","level":"info","client_ip":"<IP_ADDRESS>","method":"POST","path":"/rpc/v1/beacon","status":200,"latency":"408.585�s","message":"Processed HTTP
Request"}
{"time":"2018-04-30T19:14:51+09:00","level":"info","client_ip":"153.222.[redacted]","method":"GET","path":"/","status":404,"latency":"460.473�s","message":"Processed HTTP Request"}

server.yaml
debug: true
web_server:
  listener:
    address: ":1338"
    ssl_enabled: false
  cors:
    allowed_origins:
        - "*"
  ui:
    csrf_key: [redacted]
    csrf_enabled: true
rpc_server:
  listener:
    address: ":1339"
    ssl_enabled: true
    ssl_ca_certificate: |
      -----BEGIN CERTIFICATE-----
      [redacted]
      -----END CERTIFICATE-----
    ssl_certificate: |
      -----BEGIN CERTIFICATE-----
     [redacted]
      -----END CERTIFICATE-----
    ssl_private_key: |
      -----BEGIN RSA PRIVATE KEY-----
      [redacted]
      -----END RSA PRIVATE KEY-----
database:
  backend: bdb
  connection_string: /home/oda/gocrack/server/database.db
file_manager:
  engine_file_path: /home/oda/gocrack/server/engine
  task_file_path: /home/oda/gocrack/server/task
  temp_path: /home/oda/gocrack/server/temp
  import_path: /home/oda/gocrack/server/import
authentication:
  backend: "database"
  secret_key: [redacted]
  backend_settings:
    bcrypt_cost: 10
    allow_registration: true
notifications:
  email_server:
    address: mail.teknik.io
  enabled: false
  from_address<EMAIL_ADDRESS>  public_address: http://crack.tiuxo.com:1338

Hi Brian,
Sorry for the delay. The UI is a separate component located @ https://github.com/fireeye/gocrack-ui and can be served up on an existing server (nginx/apache) or embedded within the executable you compiled.
To get it running embedded, build the UI following the instructions in the README.MD in the UI code and put them in a folder named "static" in the same folder as your binaries. It should look something like this:

Next, you'll have to set the path to the static folder in the config (see this doc for more info). Dont forget to add "http://crack.tiuxo.com:1338" to the CORS headers too (wildcards are bad! 😄)
The UI should be accessible now! Please let me know if you still have issues seeing it after this.

It works perfectly, thanks!  I added a little note about it so others won't miss it.  I couldn't find any references to it in the other documentation #46


[Dubbo-2678][For Master] Add ability to turn off SPI auto injection, special support for Object type.

What is the purpose of the change
Fix problem reported in https://github.com/apache/incubator-skywalking/issues/1769
Brief changelog

Add Inject annotation
Printing log instead of throwing Exception in SpringExtensionFactory

Verifying this change
ExtensionLoaderTest.testInjectExtension
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2682 into master will increase coverage by 0.07%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
+ Coverage   62.99%   63.06%   +0.07%
==========================================
  Files         574      574
  Lines       25786    25792       +6
  Branches     4524     4539      +15
==========================================
+ Hits        16245    16267      +22
+ Misses       7380     7368      -12
+ Partials     2161     2157       -4

Impacted Files
Coverage Δ

...onfig/spring/extension/SpringExtensionFactory.java
71.87% <40%> (-3.99%)
:arrow_down:

...apache/dubbo/common/extension/ExtensionLoader.java
80.74% <66.66%> (-0.09%)
:arrow_down:

...e/dubbo/remoting/transport/netty/NettyChannel.java
54.11% <0%> (-7.06%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-4.35%)
:arrow_down:

...c/main/java/org/apache/dubbo/rpc/RpcException.java
85.71% <0%> (-3.58%)
:arrow_down:

...che/dubbo/common/compiler/support/JdkCompiler.java
64.54% <0%> (ø)
:arrow_up:

...he/dubbo/registry/multicast/MulticastRegistry.java
61.2% <0%> (+0.43%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
66.66% <0%> (+0.83%)
:arrow_up:

.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java
58.94% <0%> (+1.05%)
:arrow_up:

...ache/dubbo/common/compiler/support/ClassUtils.java
49.19% <0%> (+1.06%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b6f07...aaa670e. Read the comment docs.


Show categories in main menu

I am using this theme and I've found useful show the categories into the main menu, at least in my specific case. I am wondering if a pull request with this feature is interesting.
Great theme! Congratulations!

Yes it is, be my guest and send the PR

@Copperfield I would be interested as well. Do you have time for a PR?


Devfile Tutorial For Various Personas

Background
This issue discusses the need for a devfile tutorial from different perspectives for the various personas. For example, we would like to have tutorials for Application Developers, Devfile authors/Stack providers, Registry Administrators, Devfile Consumers, etc.
We would like to showcase the various functionalities of the Devfile when curating tutorials for these personas and how to try devfiles out before diving in(Maybe point them towards Developer Sandbox, as we can spin up a OpenShift cluster and they can try out devfiles on ODC).
Work
When working on these tutorials, we can leverage the devfile v2 documentation that we have and also update them as we see fit. We can craft slides, demos, samples, etc to reach our objectives.
These tutorials can be hosted on Red Hat’s website, devfile’s documentation and can be used for conferences in the future.

Hi @maysunfaisal this issue looks interesting..I'd love to work on it :)

@yimikao that sounds awesome
We will update the issue with specifics, so you can work on this

After having some discussion with the team, we realized that the approach we would like to take in this issue is to create a guide for the Application Developers persona.
In this proposed guide, we could elaborate on how to incorporate a devfile into an application/project. For instance, we could write up about how as an application developer, one would get their application running with a devfile workspace definition. We could leverage tools like odo to test out the devfile and perhaps incorporate the example of using odo in our guide.
This python devfile sample could be used as an example if the guide is aimed towards creating devfile sample repositories.
For devfile stack (which is different from devfile samples), there is an issue https://github.com/devfile/api/issues/911 which is mostly geared towards it. When https://github.com/devfile/api/issues/911 is complete, we could potentially leverage that guide/documentation in our guide to say how to author a devfile from scratch.

@yimikao sorry for the delay in hashing this issue out. But I've posted some details on how to get started. Are you still interested in picking this up? If so, please assign yourself and I can get it tracked.


Show number of selected lines in status bar

Display line count of current selection in status bar, e.g. (2 lines, 5 chars).
Fix #154327

@bpasero May I ask what exactly is blocking this PR? Cause the change is fairly small and easy to review IMO. Anything I can help to speed things up?

Nothing is blocking this PR other than a review from me and a decision if we want to have it or not. I typically find time to review PRs in our issue grooming iteration in October/November of a year.

Hey @ushuz, I made some updates in https://github.com/microsoft/vscode/commit/b5d51d3132fd3d2c16f5470a72f51f895e4fe09d. Check it out and let me know what you think 😊

Hey @ushuz, I made some updates in b5d51d3. Check it out and let me know what you think 😊

@wmentha Hi, thanks for the heads up. As long as there's line count, I'm fine.

@wmentha Hi, thanks for the heads up. As long as there's line count, I'm fine.

@ushuz  I've added an improvement to the line count algorithm so it takes multiple selections on a single line into account. Take a look:

The commit can be found here: https://github.com/microsoft/vscode/commit/61493926ba2af7407ca45d3964cb2eb711860ab5 😊
I thought selections might have been a misnomer as a selection with no content is just a cursor, however we don't distinguish between multiple selections that contain content or no content at the moment:

As you can see, I don't count a cursor as adding to the line count. Thoughts?

Should this be behind a setting at least? Screen real estate in the status bar is always a problem and this change forces every user to have less space, even when maybe not interested in the selected lines?

@wmentha oh very cool! I would be interested in a setting like that maybe with support for line count and support for concise format. We can have the setting on the workbench.editor.* settings scope, I think it should not be on the editor.* spectrum because it only applies to the VSCode, not Monaco Editor standalone.
To summarise:

we introduce a new setting that allows to adjust how editor selection is presented in the status bar
we optionally allow to show line count
we optionally allow a concise form

Maybe then we have an enum of 3?

default: as today
concise: a new short form
long: including line count

?

Awesome! I think this covers the best off all worlds 😊 Since many extensions make liberal use of the status bar, I think customisation of how much is displayed by what is built into the status bar is important. I'll get onto it with your suggestions 👍

@bpasero @wmentha
If this is desirable, may be this setting could be made into a format string, so users can configure it to whatever they like.  Something like "Ln ${lineNo}, Col ${colNo} (${charSelected} selected)" could be set as the default value to keep it looking the same as today.

I thought about it but felt it might be an expensive feature because we literally update the status bar on each caret move. I think having such flexibility is a bit overkill at the cost of having to dynamically figure out the format and apply it?

Also the issue of plurality for different languages when it comes to character(s) selected.

@ushuz May I ask permission to contribute to this PR on your branch? 😊

Also the issue of plurality for different languages when it comes to character(s) selected.

If we take i18n and l10n into consideration, how would the concise long option play out for different locales? If concise long doesn't work in all locales, this setting may not make sense.
In that case, how about just dropping the selected from the label (which is implied and unnecessary IMO, I kept it only to make my change as small as possible), and trade the status bar real estate for the xxx lines?

2 Selections (3 Selected) reads awkwardly in my view. Perhaps this is what concise can be for. So 4 possible options in the enum:

default
line-count
concise
concise-line-count

The support for different languages is a good point, I think I would expect:

the concise format to only show numbers and maybe colons? Should compare with how other editors present this maybe
the default format to work as today
the long format to be like default in terms of wording but with the additional selected lines

?

the concise format to only show numbers and maybe colons? Should compare with how other editors present this maybe, possibly this becomes the same in all languages then?

@bpasero To be concise with support for selections and multiple line selections without text, we could do:

123 ∶ 456 (7) from Ln 123, Col 456 (7 characters)
2 (3) from 2 selections (3 characters selected)

The ∶ character can provide context.

2 Selections (3 Selected) reads awkwardly in my view.

It would be 2 Selections (3 chars) by dropping selected and shorten characters.

Perhaps this is what concise can be for. So 4 possible options in the enum:

@bpasero @wmentha
If the setting doesn't work for all locales, which is very likely, it becomes an English-specific setting. And I don't think it's a good idea.
For example, in zh-cn, today's version is already concise enough and there may not be any wording more "concise". Then the concise option won't make any sense for users using zh-cn if nothing changes.

Also, if the primary concern here is the status bar real estate. Dropping selected and shortening characters would be more than enough to address it. Adding a language-specific setting feels even more like an overkill.

To be concise with support for selections and multiple line selections without text

123 ∶ 456 (7) from Ln 123, Col 456 (7 characters)
2 (3) from 2 selections (3 characters selected)

@wmentha's new proposal is an interesting idea and worth exploring. However, I think it's beyond the scope of this change, and should be discussed separately.

What's more, inconsistency and abbreviation already existed in the current codebase.
It's Line and Column here.
https://github.com/microsoft/vscode/blob/6cd856c6c5b95dadbb20e0571f51b6ddfcc06a10/src/vs/editor/common/standaloneStrings.ts#L10
And Ln and Col here.
https://github.com/microsoft/vscode/blob/6cd856c6c5b95dadbb20e0571f51b6ddfcc06a10/src/vs/workbench/browser/parts/editor/editorStatus.ts#L293

So dropping selected and abbreviating characters could be acceptable. Also it's much easier to implement and less complication to worry about than adding a new setting.

Fyi I will depart from this discussion in the PR until I am returning from my vacation end of October. I think the details still have to be figured out and I can review the changes when I am back.

@ushuz May I ask permission to contribute to this PR on your branch? 😊

@wmentha Sorry I missed this earlier. As we haven’t reach a consensus yet, I think it would be better to branch out so we have more options going forward. Feel free to use any of my code if you need, my pleasure.

Is this PR still active?

Is this PR still active?

Of course, waiting for your review

@bpasero for accessibility I believe most users get line number information by pressing Cmd/Ctrl + G and using Quick Open. Maybe that quick open should also say how many lines are selected.
@meganrogge thoughts?

I don't think there's a harm to announcing the number of selected lines, so I agree with @isidorn that the quick open could indicate that. Maybe it could announce the line range ? "Line 1, char 3 to line 5, char 7 selected"

@bpasero

I am not seeing a setting for this as I had asked for in #156086 (comment), so this change cannot go in like that.

About this, I've gave my thoughts on why the proposed setting may not be a good idea in https://github.com/microsoft/vscode/pull/156086#issuecomment-1259105986. I haven't received any feedback untill now. Is it already decided?

@bpasero @isidorn @meganrogge
I think accessibilty may need more careful consideration. This is a super small change for fully abled users, it's just a couple more characters in status bar for glimpse. But it may be quite a big change for people relying on accessibilty features. Thus I think it's outside the scope of this PR as well.

@bpasero

As for the setting: it is likely a large set of users (maybe even the majority) that would be impacted by this change, so I still think a setting makes sense even if not applicable in all languages?

Yes, this would be rolled out to a lot of users, but it's just a super minor format tweak for an existing feature. It's literally just a few characters more. If we do some abbr, there may even be fewer chars than now. I doubt most of the users would even notice this change, let alone complain about a few extra chars. Besides, the current chars count isn't a particularly useful metric IMO, so I doubt the users would even care if there're changes to it.
Also, I don't think every change impacting a large number of users warrants a setting, it depends on what the impact is.
In this case, as I stated here and in https://github.com/microsoft/vscode/issues/154327#issuecomment-1194507552, the impact could be negligible. More rationale from that comment:

line count is more useful than character count, most of the time, and VS Code does have char count built-in, so why not line count?
competitor like Sublime Text and Notepad++ offer line count out-of-the-box
the implementation is super lightweight, minimal burden on both maintainers and users

@bpasero
I can understand the reason for a setting now. Unfortunately, implementing something like that is beyond what I can commit to this feature. So I'll just update this PR to address the status bar space concern and leave it here.
If this feature is not mergeable under the current state, and no one else is willing to contribute, please feel free to close it.

@ushuz I'm up for looking back into this issue again and implementing the enum of 3 @bpasero has been suggesting 😊

👀

This PR seems stale.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Give API access to valid link elements

Fixes #591

Opps, didn't create a PR for this one apparently.

Coverage decreased (-0.1%) to 68.809% when pulling 584ec681af228db89e990b41d0670779efd272a0 on Tyriar:591_element_on_validation into 0c5b5cca4ab1d77469f14a2479e121bff1136879 on sourcelair:master.


Add Attributes to a sensor device

Would be really cool to have the ability to add attributes from the scrape to the sensor as well as have multiple sensors
for example if the webpage had a table of data, and you wanted other columns in the table to be attributes.

Maybe this could be implemented similar to the rest integration https://www.home-assistant.io/integrations/rest/
For example, instead of generating five separate sensor for the same printer
# Dell Printer
multiscrape:
  - resource: !secret printer_status
    scan_interval: 900
    sensor:
      - name: Printer Toner Level Cyan
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(2) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
        unit_of_measurement: "%"
      - name: Printer Toner Level Magenta
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(4) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
        unit_of_measurement: "%"
      - name: Printer Toner Level Yellow
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(6) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
        unit_of_measurement: "%"
      - name: Printer Toner Level Black
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(8) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
        unit_of_measurement: "%"
  - resource: !secret printer_volume
    scan_interval: 900
    sensor:
      - name: Printer Volume
        select: "body > table > tr > td > table:nth-child(4) > tr > td > table > tr > td:nth-child(2) > font"
        value_template: '{{ value }}'
        unit_of_measurement: "pages"

it could be one sensor with a state for the number of pages and four attributes for toner levels. Maybe similar to this:
# Dell Printer
multiscrape:
  - sensor:
      name: Dell Printer
      value:
      - resource: !secret printer_volume
        scan_interval: 900
        name: Printer Volume
        select: "body > table > tr > td > table:nth-child(4) > tr > td > table > tr > td:nth-child(2) > font"
        value_template: '{{ value }}'
        unit_of_measurement: "pages"
      attributes:
      - name: Toner Level Cyan
        resource: !secret printer_status
        scan_interval: 900
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(2) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
      - name: Toner Level Magenta
        resource: !secret printer_status
        scan_interval: 900
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(4) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
      - name: Toner Level Yellow
        resource: !secret printer_status
        scan_interval: 900
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(6) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
      - name: Toner Level Black
        resource: !secret printer_status
        scan_interval: 900
        select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(8) > td:nth-child(1) > b"
        value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'

how to release this?
`multiscrape:

resource: !secret pwr_sw_address
username: !secret pwr_sw_username
password: !secret pwr_sw_password
scan_interval: 5
sensor:

name: relay_1
select: "button[name=relayon1] ~ img"
attribute: "src"
value_template: '{{ value.split("light")[1].split(".jpg")[0] }}'
`

I realise that my example might be too complicated as it has several calls to different resources for one sensor. But in your example, how would you set state and more than one attribute to one sensor from the one resource?

What about this:
multiscrape:
  - resource: !secret pwr_sw_address
    username: !secret pwr_sw_username
    password: !secret pwr_sw_password
    scan_interval: 5
    sensor:
      - name: relay_1
        select: "button[name=relayon1] ~ img"
        value_template: '{{ value.split("light")[1].split(".jpg")[0] }}'
        attributes:
          - name: src
            select: "some selection"
            value_template: "some value template"
          - name: brand
            select: "some selection"
            value_template: "some value template"
          - name: model
            select: "some selection"
            value_template: "some value template"

So from one resource you get one or more sensors with states and each sensor can have several attributes with their own selections in addition to the state.

And how do I get the sensor value then?
my config parsed structure like this:
<button name="relayon1" value="on">Open</button><button name="relayoff1" value="off">Close</button><button name="pulse1" value="pluse">Pulse</button>
and set the sensor value on or off depending on the image name. Do you propose to me to make several different values for one sensor?

Yes, that would be the idea. You have one main value representing the sensor. But then this sensor also has a number of additional attributes that come along with it.

Today is not work.

What about this:
multiscrape:
  - resource: !secret pwr_sw_address
    username: !secret pwr_sw_username
    password: !secret pwr_sw_password
    scan_interval: 5
    sensor:
      - name: relay_1
        select: "button[name=relayon1] ~ img"
        value_template: '{{ value.split("light")[1].split(".jpg")[0] }}'
        attributes:
          - name: src
            select: "some selection"
            value_template: "some value template"
          - name: brand
            select: "some selection"
            value_template: "some value template"
          - name: model
            select: "some selection"
            value_template: "some value template"

So from one resource you get one or more sensors with states and each sensor can have several attributes with their own selections in addition to the state.

Adding attributes in this way is indeed how I envision it.

@wcomartin thank you for your patience! Please check pre-release v4.1.0!
PS: And thank you for initiating the Kia Uvo integration :)

ok, will check, thanks
currently, with the latest 2021.6.4 multiscrape is broken for me. The previously working sensors stopped working. I'll try the pre-release and will report back and if the problem still exists open a separate issue.

Hm, I'm not entirely sure how the attributes are supposed to work. I tried this:
multiscrape:
  - resource: !secret printer_status
    scan_interval: 900
    sensor:
      - name: Printer Toner Level
        value_template: '{{ value }}'
        select: "body > table > tr > td > table:nth-child(10) > tr > td > table > tr:nth-child(2) > td:nth-child(2) > b"
        attributes:
          - name: Cyan
            select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(2) > td:nth-child(1) > b"
            value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
          - name: Magenta
            select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(4) > td:nth-child(1) > b"
            value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
          - name: Yellow
            select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(6) > td:nth-child(1) > b"
            value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'
          - name: Black
            select: "body > table > tr > td > table:nth-child(6) > tr > td > table > tr:nth-child(8) > td:nth-child(1) > b"
            value_template: '{{ value|regex_findall_index(find="(\d+)\%", index=0, ignorecase=False) }}'

and I get the following error:
2021-06-16 01:15:59 ERROR (MainThread) [homeassistant.components.sensor] Error adding entities for domain sensor with platform multiscrape
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 383, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 588, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 614, in add_to_platform_finish
    await self.async_added_to_hass()
  File "/usr/src/homeassistant/homeassistant/components/rest/entity.py", line 64, in async_added_to_hass
    self._update_from_rest_data()
  File "/config/custom_components/multiscrape/sensor.py", line 178, in _update_from_rest_data
    attr_value = self._scrape(
  File "/config/custom_components/multiscrape/entity.py", line 67, in _scrape
    value = value_template.async_render_with_possible_json_value(value, None)
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 543, in async_render_with_possible_json_value
    self._ensure_compiled()
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 571, in _ensure_compiled
    assert self.hass is not None, "hass variable not set on template"
AssertionError: hass variable not set on template
2021-06-16 01:15:59 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up multiscrape platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 258, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 383, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 588, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 614, in add_to_platform_finish
    await self.async_added_to_hass()
  File "/usr/src/homeassistant/homeassistant/components/rest/entity.py", line 64, in async_added_to_hass
    self._update_from_rest_data()
  File "/config/custom_components/multiscrape/sensor.py", line 178, in _update_from_rest_data
    attr_value = self._scrape(
  File "/config/custom_components/multiscrape/entity.py", line 67, in _scrape
    value = value_template.async_render_with_possible_json_value(value, None)
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 543, in async_render_with_possible_json_value
    self._ensure_compiled()
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 571, in _ensure_compiled
    assert self.hass is not None, "hass variable not set on template"
AssertionError: hass variable not set on template

Thanks, data is arriving well now. But there is still a bug - I'll file a new issue...

Thanks for testing!
On 16 Jun 2021, at 18:25, kongo09 @.***> wrote:

Thanks, data is arriving well now. But there is still a bug - I'll file a new issue...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/danieldotnl/ha-multiscrape/issues/27#issuecomment-862523346, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWYKI3TK2EQBGOJ2AF4ZYDTTDF6ZANCNFSM46KFSHZA.

You guys are awesome!! This is going to make my modem status scraping much simpler.


Add support for drawing points

Hi! Testing notan I missed being able to draw points in a simple way with variable width and alignment, so I created a Point shape, and two enums for alignment, since it didn't seem appropriate to reuse the ones intended for text.
I also made an example showcasing all the alignment combinations on the first 10 integral widths, showing labels when compiled with text support:

Please feel free of letting me know if you want me to change something.

This looks good to me, a great addition. Thanks you so much!


new branch for influxdb 0.9.0

Should you create a new branch for the upcoming influxDB 0.9.0 ?
Would be good to start implementing the new features and API changes.

+1

duplicate of https://github.com/influxdb/influxdb-ruby/issues/77

@n1tr0g we're working on it. should be out later today!


upgrade gogo protobuf

upgrade gogo protobuf relates to https://github.com/open-cluster-management/backlog/issues/8969

/approve
/lgtm


Num.min and Num.max on floats produces different answers depending on argument order

To reproduce, in the repl:
» Num.min (0f64 / 0) 1

1 : F64
» Num.min 1 (0f64 / 0)

NaN : F64

The same thing happens with Num.max.
This happens because our current implementation is just a conditional that returns one argument or the other. That's very efficient for integers and Dec, but it's incorrect for floats.

Thanks to @mattgodbolt for putting this on my radar! 😄

There are multiple ways we could address this; there's a discussion on Zulip about which way to go.

Zoiks: I think I may be misinformed! https://compiler-explorer.com/z/h5desbfvY ! the C++ min clearly is doing the x<y?x:y type thing!

We should still do it better! 😆


unexpected behavior while merging on arrays

merge(["a1","a2","c1","f1","p1"],["t1","s1","c2","r1","p2","p3"])

["a1", "a2", "c1", "f1", "p1", "p3", "s1", "c2", "r1", "p2"]

"t1" is missing in this list

@nrf110 is this published? Given that this module has ~200,000 downloads / month it'd be nice to get bug fixes out promptly :)

still don't have access to publish this on npm, and don't do node enough to have time to maintain this anymore.  if anyone wants to volunteer to maintain, I can transfer ownership of the repo.

@nrf110 I'll maintain it.

@KyleAMathews @nrf110 I also have time if you need an extra maintainer.

@nhocki @nrf110 the more the merrier! I'm a big fan of the OPEN open source model. As long as all work is done in pull requests and gets signed off by other maintainer(s) before merging, things should work smoothly with multiple maintainers.
https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md

@nrf110 thanks for transferring the repository. Have you had a chance to recover your NPM password so you can make me (us) owner there?
@nhocki I added you as a collaborator. Welcome!

@KyleAMathews yes, just got it back this morning. If you send me your npm username I'll add you as an owner.

Fixed by 49cc4edcaba6749951d7f06f269e594d7bcafa22

(And published as 0.2.9 it looks like)


Register pytest markers and upgrade pytest

Registering the markers used by pytest helps to prevent typos, as unknown markers in newer versions raise a warning.
https://docs.pytest.org/en/latest/mark.html#registering-marks

Coverage remained the same at 82.497% when pulling 0243b04463f612d38549a47957d05630412306a2 on snorfalorpagus:markers into 32eeb62cd97acd191fe8434e2fde9d934efa7226 on Toblerity:master.

Fantastic. Thanks, @snorfalorpagus !

This MR broke the appveyor build. Something to do with an older version of argparse but I haven't managed to reproduce it locally yet.

@snorfalorpagus  There is a similar bug report in the pytest issue tracker: https://github.com/pytest-dev/pytest/issues/5594
Maybe something is odd with our Python setup on appveyor.

I think the reason is that we install the argparse library with requirements.txt. Dropping this requirement fixes this issue. I think this should not be a problem as we won't support Python < 3.5 with Fiona 2.0 and argparse is in the standard library after Python 3.2.  To be safe we could add
argparse==1.4.0 ; python_version <= '3.4'
(From https://pypi.org/project/argparse/ I assume the separate argparse library provides bugfixes up to 3.4)
It's strange that the error is not present on travis.


Configure XCTest for Dispatch if included in Foundation on Linux

What's in this pull request?
When libdispatch is added into the builds on Linux (for use by Foundation), there are subsequent build errors in XCTest as it needs access to build artefacts from libdispatch due to the downward dependency from Foundation. These changes pass the source and build locations through to XCTest if libdispatch is included in the builds.
The XCTest PR that picks up and uses the arguments has been merged already:
https://github.com/apple/swift-corelibs-xctest/pull/107
Resolved bug number: (SR-)
N/A
!-- This selection should only be completed by Swift admin -->
Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

@gribozavr Would it be possible to get a review of this - if your happy with it I'll do the work to update for the merge conflict.
Note that the counterpart in XCTest is already merged.


TurboModules / CallInvoker are not ABI safe

it looks like TurboModules are currently coupled to STL types which makes the APIs non ABI-safe, thus hindering reuse-via-binary, are there plans to address this?
Originally posted by @asklar in https://github.com/facebook/react-native/issues/28128#issuecomment-702006201

CC @TheSavior

Please read https://github.com/react-native-community/discussions-and-proposals/issues/257


Can't Find SearchDescriptor .Types(IEnumerable types) method on NEST Nuget package 2.3.1

I'm trying to use this method of ( .Types(params Type[] types ), intellisense was not finding either of them.
I looked at the decompiled sources for the SearchDescriptor class (using R#) but the source looks very different to what's in this src file
https://github.com/JasonPunyon/NEST/blob/master/src/Nest/DSL/SearchDescriptor.cs
Most of the other methods appear to be there

Not sure where you found  theabove repo, but the official repo is at https://github.com/elastic/elasticsearch-net

I googled for that method
I'm trying to do what's described here
https://github.com/elastic/elasticsearch-net/issues/243

.Search(s=>s
.Types(typeof(Product),typeof(Category),typeof(Manufacturer))
.Query(...)
);

@Mpdreamz can you please advise?

@remtek To specify multiple types, you would use .Type(Types.Type(typeof(T))), for example
var response = client.Search<Person>(s => s
    .Type(Types.Type(typeof(Teacher), typeof(Firefighter)))
    .MatchAll()
);

If you're looking at returning covariant results, take a look at the covariant search results documentation and also this example.


Warn on expression with == nil or convert to is_nil

Is your feature request related to a problem? Please describe.
When writing an expression containing something == nil, this is literally translated to SQL. In SQL however nothing is equal to NULL.
Describe the solution you'd like
Warn user to use is_nil(something) instead.
Describe alternatives you've considered
Convert == nil to is_nil.
Express the feature either with a change to resource syntax, or with a change to the resource interface
No changes in interface.
Additional context

Do not write expression = NULL because NULL is not “equal to” NULL. (The null value represents an unknown value, and it is not known whether two unknown values are equal.)

https://www.postgresql.org/docs/current/functions-comparison.html

So, we can't automatically convert to is_nil, as that could pose a security issue. We could potentially warn the user to use is_nil instead of ==, however. I would likely implement this in the Ash layer.


README: add ttyd to Alternatives

ttyd is a C port of GoTTY with CJK and IME support (from xterm.js).

Thanks!


Problem using Integram Notifier

Successfully added Integram Notifier to Telegram Channel using @integram_bot using command
NOTIFIERS_INTEGRAM_REQUIRED_URL=
Although as soon as I launch I get a few pairs sent to the channel telling the pairs wether its hot or cold from all the indicators but it only sends out a few then the bot crashes. Gives me the following error code:
My guess is maybe the program sends out too many messages and gets blocked for anti-spam, which causes the program to think that something is wrong, gives you an error like "Too many requests" .. This is just a speculation, I am not a programmer, just a thought...
Good luck !
Traceback (most recent call last):
File "app.py", line 46, in
main()
File "app.py", line 41, in main
behaviour.run(settings['market_pairs'], settings['output_mode'])
File "/app/behaviour.py", line 56, in run
self.test_strategies(market_data, output_mode)
File "/app/behaviour.py", line 144, in test_strategies
self.notifier.notify_all(message)
File "/app/notification.py", line 81, in notify_all
self.notify_integram(message)
File "/app/notification.py", line 124, in notify_integram
self.integram_client.notify(message)
File "/app/notifiers/integram_client.py", line 38, in notify
urllib.request.urlopen(req, jsondataasbytes)
File "/usr/local/lib/python3.6/urllib/request.py", line 223, in urlopen
return opener.open(url, data, timeout)
File "/usr/local/lib/python3.6/urllib/request.py", line 532, in open
response = meth(req, response)
File "/usr/local/lib/python3.6/urllib/request.py", line 642, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/local/lib/python3.6/urllib/request.py", line 570, in error
return self._call_chain(args)
File "/usr/local/lib/python3.6/urllib/request.py", line 504, in _call_chain
result = func(args)
File "/usr/local/lib/python3.6/urllib/request.py", line 650, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 429: Too Many Requests

I have the same issue.

We'll try to fix this as soon as we can

ich, I just looked at our telegram code. I am probably going to do some significant refactoring to hopefully make it better all round.

Fixed in https://github.com/CryptoSignal/crypto-signal/pull/205/ waiting for review, this is a significant change to the telegram integration and completely changes how it works. Existing users will need to update their config.

So I tried updated the application, seemed to work fine, I havn't changed anything in the folder from the previous version, leaving my old settings.env file in there with my old setup using Binance exchange and Integram Notifier.
Still get the same error message so what am I doing wrong ?

The change hasn't been merged yet. It's still waiting for review.

Merged, build should publish in the next hour.


fixes RESTEASY-1149

Tests fails on my environment without this fix so its hard to judge if the fix is correct. Please review.

This is incorrect fix.  You are wiping out any existing context data.


failed to compile xcode project

The following build commands failed:
CompileC /Users/admin/Desktop/App/iOS/build/Pods.build/Debug-iphonesimulator/pop.build/Objects-normal/i386/POPAnimatableProperty.o pop/pop/POPAnimatableProperty.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler

Can you paste the command you are running as well as its full output? Use https://gist.github.com/ or similar for large pastes. Also, the contents of "infer-out/toplevel.log" could be useful, please paste them as well. Thanks!

command + output: https://gist.github.com/royanghami/76ce2973a34b6b449183
toplevel.log: https://gist.github.com/royanghami/c246ff5286695e1f61d4
On Mon, Mar 21, 2016 at 4:53 PM, Jules Villard<EMAIL_ADDRESS>wrote:

Can you paste the command you are running as well as its full output? Use
https://gist.github.com/ or similar for large pastes. Also, the contents
of "infer-out/toplevel.log" could be useful, please paste them as well.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/facebook/infer/issues/311#issuecomment-199324313

Thanks! The error is actually "fatal error: cyclic dependency in module 'Darwin': Darwin -> std -> Darwin". It's a know problem in clang, see the solutions suggested in #232 to solve your problem.

i try the solutions in #232, but nothing works
On Mon, Mar 21, 2016 at 8:02 PM, Jules Villard<EMAIL_ADDRESS>wrote:

Thanks! The error is actually "fatal error: cyclic dependency in module
'Darwin': Darwin -> std -> Darwin". It's a know problem in clang
https://github.com/facebook/infer/issues/232#issuecomment-169744110,
see the solutions suggested in #232
https://github.com/facebook/infer/issues/232 to solve your problem.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/facebook/infer/issues/311#issuecomment-199404295

do you get the same output when you run infer -- xcodebuild -workspace Anghami.xcworkspace -scheme Anghami" "Release -configuration Debug -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=9.1,name=iPhone 6' CLANG_ENABLE_MODULES=NO?

I got another error
On Monday, 21 March 2016, Jules Villard<EMAIL_ADDRESS>wrote:

Reopened #311 https://github.com/facebook/infer/issues/311.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/facebook/infer/issues/311#event-597548895

can you please paste the full output of that one?

output : https://gist.github.com/royanghami/51e5f83acfff4fe1e0a7
On Tue, Mar 22, 2016 at 2:45 AM, Jules Villard<EMAIL_ADDRESS>wrote:

can you please paste the full output of that one?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/facebook/infer/issues/311#issuecomment-199563624

There are two errors:

The linking step is failing. You can set LD to /bin/true to circumvent the issue. See the FAQ. Let me know if linking still fails.

You need to disable modules only selectively because you use @import in your project. Does this solution work for you?

closing optimistically. We're tracking the module issue in #335


Error install different version of solidity

When I run this plugin it's telling me the following error:
$ asdf install solidity 0.5.17
/home/xxxxxxxx/.asdf/plugins/solidity/bin/install: line 38: syntax error near unexpected token `&&'
/home/xxxxxxxx/.asdf/plugins/solidity/bin/install: line 38: `    && sh ./scripts/install_deps.sh \'

I am running asdf on WSL if that matters.

Also seeing this error on OS X. sh is GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20) Copyright (C) 2007 Free Software Foundation, Inc.

Also seeing this error on OS X. sh is GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20) Copyright (C) 2007 Free Software Foundation, Inc.

Are you accepting PRs? because I also had troubles with the plugin and made another one: https://github.com/diegodorado/asdf-solidity ... but I would gladly merge it with yours.
I am basically installing binaries from https://github.com/ethereum/solc-bin/


Optimize the time statistics in the profile's plan time for scan nodes, including total time, average time, maximum and minimum times.

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Previously, the plan time in the profile only recorded the time for individual scan nodes, without aggregating the timing statistics across all scan nodes.
Release note
The purpose of this improvement is to collect timing statistics for all scan nodes within the plan time section of the profile, including the total time, average time, maximum and minimum times across all nodes.

Plan  Time:  1s288ms
-  JoinReorder  Time:  N/A
-  CreateSingleNode  Time:  N/A
-  QueryDistributed  Time:  N/A
-  Init  Scan  Node  Time:  sum  99ms,  count  4,  avg  24ms,  max  84ms,  min  2ms
-  Finalize  Scan  Node  Time:  sum  868ms,  count  4,  avg  217ms,  max  841ms,  min  5ms
-  Get  Splits  Time:  sum  827ms,  count  4,  avg  206ms,  max  803ms,  min  5ms
-  Get  Partitions  Time:  sum  41ms,  count  4,  avg  10ms,  max  41ms,  min  0ms
-  Get  Partition  Files  Time:  sum  785ms,  count  4,  avg  196ms,  max  762ms,  min  5ms
-  Create  Scan  Range  Time:  sum  40ms,  count  4,  avg  10ms,  max  37ms,  min  0ms

Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall

run buildall

run buildall


Remove code duplication and extract common logic into separate helper module

After discussion with @lyubomir we figured out that we have some code duplication a several parts of our app.
This PR removes this duplication and moves common logic into separate helper module.

@tsareg, thank you!
I'd like to note that we're duplicating isRoomValid at https://github.com/jitsi/jitsi-meet-react/blob/master/features/app/components/App.native.js#L122 as well. I'll take care of this, of course.


Ensure the existing Debugger survey banner is displayed

Seems we aren't getting any new surveys completed.
Todo

~[ ] Fix bug if any~ (confirmed to be working)
[x] Increase threshold.
[x] Update message if necessary

Not a problem


Typo: StreamConsumer

https://github.com/dart-lang/sdk/blob/master/sdk/lib/async/stream.dart#L1462
s/consequtive/consecutive/

Fixed in a57abe83e2bedefc9d384dcd100eaf2c85a70c1d.


Support \x7F(Backspace or Delete in macOS) as default key bind

Env: macOS
There is no default mapping of \x7F so Backspace/Delete(macOS) is not work as expected in default.
I think It is better to be binded to CmdBackwardDeleteChar.
Additionally, CmdISearchBackward can't remove previous char using the key.(CtrlH can remove.)

On Ubuntu, the backspace-key could remove the previous character on the current line, but it could not join the previous and current lines with removing LF because the backspace-key is bound to the original function of go-readline-ny not to that of go-multiline-ny.
Is this same unexpected behaviour as that on macOS aht you wrote ? ( then, it will be fixed soon )

Yes, it is the same behaviour.

Could you please try with the new release v0.16.4 ?

I've confirmed that the Delete key on macOS defaults to CmdBackwardDeleteChar and works as expected.
Thanks!

Additionally, CmdISearchBackward can't remove previous char using the key.(CtrlH can remove.)
May it be another issue, so this issue would be better to close.


Update SimpleString.cpp for Borland compiler

the Borland compiler does not like the expression (*s1++ = *s2++) as part of a while condition,  This commit rewrites the while loop, moving the assignment out of the while test expression.

Super interesting compiler :) Thanks for the PR!


NTR: DOI - digital object identifier

Please can we (VectorBase/PopBio) have this term in the VEuPath Ontology?
http://purl.obolibrary.org/obo/OBI_0002110 "digital object identifier"
We already have its sibling, PubMed ID, which is great.

Import http://purl.obolibrary.org/obo/OBI_0002110 "digital object identifier"


Handle empty sub-directories when compressing contents.

This fixes an issue where empty subdirectories were being ignored (as they didn’t have their visitor.visitFile method called). This better aligns with the default unix tar implementation, whereby all directories are created as archive entries, regardless if they have contents or not.

Codecov Report

Merging #706 into master will increase coverage by 0.21%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
+ Coverage     65.12%   65.34%   +0.21%
  Complexity      623      623
============================================
  Files           141      141
  Lines          2684     2695      +11
  Branches        327      329       +2
============================================
+ Hits           1748     1761      +13
+ Misses          789      788       -1
+ Partials        147      146       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb6112...1347dc4. Read the comment docs.

@rohansingh @mattnworb Any reason we were skipping empty dirs? Will this break anything?


gitOps upgrade failed due to diskGiB field is immutable

What happened:
Cluster yaml file in git repo was edited to add more disk space
From
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  annotations:
    anywhere.eks.amazonaws.com/etcd: "true"
  name: k8s-lower-wlr-machines
  namespace: default
spec:
  diskGiB: 20
.....

Change to this
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  annotations:
    anywhere.eks.amazonaws.com/etcd: "true"
  name: k8s-lower-wlr-machines
  namespace: default
spec:
  diskGiB: 50
.....

Nothing happened.
flux-system kustomize-controller pod log shows this
{"level":"error","ts":"2022-12-08T19:36:50.911Z","logger":"controller.kustomization","msg":"Reconciliation failed after 858.979712ms, next try in 10m0s","reconciler group":"kustomize.toolkit.fluxcd.io","reconciler kind":"Kustomization","name":"flux-system","namespace":"flux-system","revision":"main/f8993e13defd7211d3dab445bb51d2441a5169fd","error":"VSphereMachineConfig/default/k8s-lower-wlr-machines dry-run failed, reason: Invalid, error: admission webhook \"validation.vspheremachineconfig.anywhere.amazonaws.com\" denied the request: VSphereMachineConfig.anywhere.eks.amazonaws.com \"k8s-lower-wlr-machines\" is invalid: spec.diskGiB: Forbidden: field is immutable\n"}
Manually upgrade with eksctl anywhere command completed successfully without any issue.
What you expected to happen:
gitOps should be able to upgrade the cluster on this field.
Environment:

EKS Anywhere Release: v0.12.0
EKS Distro Release: 1.22-eks-11

Yes @hainabc, I am looking into this issue and will update you here ASAP.

@panktishah26 the docs definitely need to be updated then because diskGiB is explicitly listed as a field that can be managed via GitOps for workload clusters https://anywhere.eks.amazonaws.com/docs/tasks/cluster/cluster-flux/

@hainabc may I know for which VSphereMachineConfig which diskGiB field were you trying to update? As mentioned in the doc, if it was for management cluster's controlplane's diskGiB field, then you wouldn't be able to update it.


Janitor Tool Resprite

About the PR
Resprites certain janitor tools and cleanbot
Media

(cleanbot would crash on spawn so I just took it from the sheet)

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:Alekshhh

tweak: Changed how certain janitor items look. Also cleanbot got tweaked too

it doesn't fit the current art style, so it looks really out of place

they look mushy aswell

they look like theyre made out of jelly, the jani tools do need a touch up but these arent really better


Correct values passed to morse.Reader.

A named argument name was incorrect, and the value being passed was a string rather than an ENUM. Fixed both issues.

Closes #279


wrong OS version for in-app browsers

OS version generation based on user-agent so it works not properly
Expected Behavior

iPhone like OS should appear
Current Behavior

Instagram version in OS field

user-agent: Mozilla/5.0 (iPhone; CPU iPhone OS 15_6_1 like Mac OS X) AppleWebKit/ 605.1.15 (HTML, like Gecko) Mobile/ 15E148 Instagram 2<IP_ADDRESS>.104 (iPhone12,8; iOS 15_6_1; en_US; en; scale=2.00; 750x1334; 413505119)
Steps to Reproduce

open instagram
track some event
go to user look-up in amplitude ui tools

Environment

typescript sdk version - "@amplitude/analytics-browser": "^1.4.0"
Installation Method: npm

Hi @BeepYoung , thanks for submitting this! We are using a forked version of ua-parser-js to handle the user agents. I have search on the original source, and didn't find any suspicious similar issues.
For the step 2 mentioned in description, does it mean to use Instagram embedded browser to open your web page (installed Amplitude TypeScript SDK on the page)?

Hi @liuyang1520 ! Yes, we're on the same page about step 2

Hi @BeepYoung, thank you for choosing Amplitude. We designed the Browser SDK to use browser name and browser version to fill in Amplitude's built-in user properties OS name and OS version. If you prefer to use the true OS name/version, you can create/use a plugin to overwrite the values we provide. We can help create this plugin if you like. Otherwise, some of our customers had requests for custom behavior like this and we have published the plugin solution we proposed here: https://github.com/amplitude/Amplitude-TypeScript/tree/main/examples/plugins for inspiration.

Thank!


Add extra checks for test_vm_schedule to avoid intermittent failures

Description
This PR adds additional checks in test_vm_schedule to avoid intermittent failures

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[] Minor
[x] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

this should avoid some of the intermitted failures, at least.

@blueorangutan package

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7223

@blueorangutan test

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-7840)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43949 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8036-t7840-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_upgrade_kubernetes_cluster
Failure
528.74
test_kubernetes_clusters.py


No errors on server, but spreadsheet/fetch2 call returns undefined

Not entirely sure what's going on, the script can find my spreadsheet, as well as get through all the oauth, but I'm not receiving any data from the spreadsheet as the fetch function returns undefined.
Any ideas?

No idea, sorry.  You might want to try the updated version<EMAIL_ADDRESS>that I just pushed, built with updated meteor packages.


API GET AUTH TOKEN ERROR: Cannot read properties of undefined (reading 'authorizationUrl')

Install Wolf-smartset
Add User and PW
Touch get DeviceList
--> Error messages

wolf-smartset.0 | 2023-11-25 16:31:55.118 | info | getDeviceList
wolf-smartset.0 | 2023-11-25 16:31:55.120 | warn | API GET AUTH TOKEN ERROR: Cannot read properties of undefined (reading'authorizationUrl')
wolf-smartset.0 | 2023-11-25 16:31:55.123 | warn | TypeError: Cannot read properties of undefined (reading 'authorizationUrl') at WolfSmartSet._getAuthToken (/opt/iobroker/node_modules/iobroker.wolf-smartset/lib/wss.js:167:38) at WolfSmartSet.adminGetDevicelist (/opt/iobroker/node_modules/iobroker.wolf-smartset/lib/wss.js:134:32) at WolfSmartset.onMessage (/opt/iobroker/node_modules/iobroker.wolf-smartset/main.js:430:34) at WolfSmartset.emit (node:events:514:28) at WolfSmartset.emit (node:domain:489:12) at change (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/src/lib/adapter/adapter.ts:11134:34) at Immediate._onImmediate (/opt/iobroker/node_modules/@iobroker/db-states-redis/src/lib/states/statesInRedisClient.ts:379:37) at processImmediate (node:internal/timers:476:21)
Final: i not know hot to fix this. Please help me =)
Thank you in advence

@MKniet
Do you read #286?

hi i try also the Version 1.0.0 i have the problem he not accept my user and PW
CPU: 7,93 %
RAM: 76,5 %
Betriebszeit: 1d0h
Verfügbar: 5.0.16
Installiert: 5.0.16
Ereignisse: ⇥22 / ↦15
Plattform: linux
Betriebssystem: linux
Architektur: arm64
CPUs: 4
Geschwindigkeit: 1800 MHz
Modell: Cortex-A72
RAM: 7.6 GB
System-Betriebszeit: 85 T. 18:41:15
Node.js: v18.17.1
time:<PHONE_NUMBER>930
timeOffset: -60
NPM: 9.6.7
Adapter-Anzahl: 515
Datenträgergröße: 117.0 GB
Freier Festplattenspeicher: 112.6 GB
Aktive Instanzen: 23
Pfad: /opt/iobroker/
Betriebszeit: 23:46:24
aktiv: true
_nodeCurrent: 18.17.1
_nodeNewest: 18.18.2
_nodeNewestNext: 18.18.2
_npmCurrent: 9.6.7
_npmNewest: 9.6.7
_npmNewestNext: 9.8.1

@MKniet
I had the same issue. Steps that fixed it:

Remove adapter 1.1.1
Install 1.1.1 again and skip the configuration page
Downgrade to 1.0.0 and enter the same credentials you use on the Wolf Smartset page and select your device
Update to 1.1.1 again

Logins via API to the Wolf Smarset portal has still negative responses but they will happen only in an intervall, depending on your configured query intervall. Please see #302, where I decribed this.

Thank you !! Now it is Working!!

I got the same issue.  Downgrade to 1.0.0 did not help neither.
API GET AUTH TOKEN ERROR: Cannot read properties of undefined (reading 'authorizationUrl')
TypeError: Cannot read properties of undefined (reading 'authorizationUrl') at WolfSmartSet._getAuthToken (/opt/iobroker/node_modules/iobroker.wolf-smartset/lib/wss.js:167:38) at WolfSmartSet.adminGetDevicelist (/opt/iobroker/node_modules/iobroker.wolf-smartset/lib/wss.js:134:32) at WolfSmartset.onMessage (/opt/iobroker/node_modules/iobroker.wolf-smartset/main.js:430:34) at WolfSmartset.emit (node:events:517:28) at WolfSmartset.emit (node:domain:489:12) at change (/opt/iobroker/node_modules/@iobroker/js-controller-adapter/src/lib/adapter/adapter.ts:11114:34) at Immediate._onImmediate (/opt/iobroker/node_modules/@iobroker/db-states-redis/src/lib/states/statesInRedisClient.ts:379:37) at processImmediate (node:internal/timers:476:21)
Is there anything else i could try ?
Thanks
Stefan

@bstmedia Schick mal deine Kontaktdaten zu<EMAIL_ADDRESS>Ggf. kann man per TeamViewer das Problem lösen.

I did work with downgrade to 1.0.0 and upgrade to 1.1.1 . Not sure why it failed yesterday.

Hi, since a few Days I can not get a working connection to the smart Set Protal. I Tried the steps from above, but i can not get the device. The Trick with Downgrade does not work, I always get Error 400 in the log with 1.0.0. Attached the Log.
Adapter version: 1.1.1
Admin: v6.13.16
JS-Controller version: 5.0.19
Node version: v18.17.1
NPM: 9.6.7
Operating system: linux Raspberry Pi OS

Same here: trying to connect the WolfSmartSet since two or three days without success. Did try the downgrade/upgrade work-around, also no success.
SystemInfo (Docker Container on Synology NAS):
    Plattform: docker (official image - v9.1.2)
    Betriebssystem: linux
    Architektur: x64
    Node.js: v18.20.1
    NPM: 10.5.1

I did some debugging of the adapter code and added - besides some debug output - basically one line of code which fixed it for me:
In file lib/wss.js, in function _getAuthToken immediately before the try/catch block:
		this.openIdInit()
Debugging showed that openIdInit() was never called before doing _getAuthToken, so this.openIdClient was not yet set when calling getDeviceList, which is what the TypeError in the log complains about.
I published a patch version with the adapter named  'iobroker.wolf-ism7' so one can install both adapters side-by-side and check the difference.
Feel free to check out the patch. If this fixes the issue for others also I will do a merge request with the one line changed.

Thanks for your effort.
Please provide a PR if you think the change will fix the issue.

If it is just this then the fix is a one liner. Thank you for trying it ... provide PR and we will update !

PR will  follow on Monday, based on latest release .1.2.0.

fixed at 1.2.1

Thanks!!


Delayed_job doesn't release memory after jobs completed

Hello,
I have noticed that delayed_jobs consumes memory once it starts processing a job. After the job is completed, it doesn't release back the memory. I have to manually restart the Delayed_job to release the memory.
Server : Amazon Linux AMI release 2016.03
RAM : 8GB
ruby 2.2.4p230
rails 4.2.5
delayed_job 4.1.1
delayed_job_active_record 4.1.0

@albus522 @mithesh109
I have  more 1000 jobs, execute by 3 worker.
After each jobs completed, i see memory increase 100MB, and never stop.
I ready have temporary solution.
https://github.com/collectiveidea/delayed_job/wiki/How-to-release-memory-after-jobs-completed-%3F


Name

IMO, the current name of this program is a bit unfortunate. It is nearly the same name as the earlier Chrome app "stm-serial-flasher". Also "serial" doesn't mean that much, as pretty much any method to access the flash of the STM8 uses some serial connection.
An important aspect of this program is that it uses the bootloader. The first name that comes to my mind would be "stm8bootflash", but there may be better names.
Philipp

yep, agreed. I also already got confused in the past with all the similar names. As an excuse I can only say that I started this tool for my own personal use, so it didn't really matter.
"stm8bootflash" sounds good but let me sleep over it. Maybe somebody else reads this and has an idea...!?

ok, slept it over and did some internet browsing --> for the Atmel uC family the PC flash tool is called avrdude, so how about stm8dude or stmdude? Remarks:

avrdude supports BSL and ISP operation, so essentially it combines stm8flash and STM8_serial_flasher. But who's perfect... :wink:
I'll ask Georg O. how big the difference between STM8 and STM32 boot loading is. If it's realistic, I'll implement STM32 as well. In that case we should go for stmdude. If not IMO stm8dude is better suited

stmdude seems ok. Personally, I'd probably prefer stmgal (since it sounds similar to stcgal - a tool for the mcs51 clones by STC, another 8-bit architecture supported by SDCC).
Philipp

renamed to stm8gal and moved to https://github.com/gicking/stm8gal


GitTimeout is not been used on helm-op anymore (chartsync)

There was some refactor on upgrading to 0.5 to use git uri per CRD and that change is not using  mirrors at chartsync and not passing the timeout to git.
Here is the line:
https://github.com/weaveworks/flux/blob/master/integrations/helm/chartsync/chartsync.go#L267

@squaremo
I am wondering if this should be a per HelmRelease configuration or a global flag like it used to be, by the looks of it the --git-poll-interval flag has also stopped working (or is actually replaced by the ---charts-sync-interval flag).

I think all git options now should be per HelmRelease each repository can have it's own key/timeout and so on.
For the charts-sync-interval I rather have it global.


chore(main): release 3.3.0

:robot: I have created a release beep boop
3.3.0 (2023-12-27)
Features

add private_dns_zone_id (3b8d25d)
add run_command_enabled variable (3354b4e)

Bug Fixes

correct none for automatic_channel_upgrade (eb8e3e3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/amestofortytwo/terraform-azurerm-aks/releases/tag/v3.3.0 :sunflower:


On cluster build: Not working for a golang function

I am following this doc: https://github.com/knative-sandbox/kn-plugin-func/blob/main/docs/guides/on-cluster-build.md and have compiled func cli from main branch.
I created function in go language.
When I am doing func deploy, it fails with:
Error: function pipeline run has failed, please inspect logs of Tekton PipelineRun "my-function-git-pipeline-run-d92n4"

Upon taking a look at step-create, it says:
Paketo Go Build Buildpack 0.6.0
  Executing build process
    Running 'go build -o /layers/paketo-buildpacks_go-build/targets/bin -buildmode pie -trimpath .'
      Failed after 94ms
        go build: no main packages to build
failed to execute 'go build': exit status 1
ERROR: failed to build: exit status 1

I wonder if its because go functions require some scaffolding with boson go buildpack and that might not be included in the create step of buildpacks task here: https://raw.githubusercontent.com/tektoncd/catalog/master/task/buildpacks/0.3/buildpacks.yaml

@Shashankft9 you are right, that's the problem.
@lance did this PR: https://github.com/boson-project/packs/pull/5
We just need to set the proper builder for Golang based func projects.

sure, related question - something like the PR you linked has to be done for rust runtime as well I believe? Since it uses one paketo community buildpack which is not included in the the paketo buildpacks builder.

Do you think you can handle Rust as well? Thanks!

Sure! but we will need to host the rust builder somewhere, just like the go builder. I don't know how I can do that, any pointers?
Note: the rust builder also deletes the source files, so the PR #830 will unblock that.

This is a good question, we need to tackle this? Maybe the global configuration could solve this? Users could overwrite default buildpacks there? WDYT?

I think this might not be an immediate issue, but might come up for users later who are already familiar with buildpacks and want to use their custom ones in on cluster builds, maybe the global configuration work will address some of it - I will open a separate issue for this

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

@jrangelramos do you think we can get an e2e test for this? I think it should work when using func deploy --builder=host.

Yea. I think so. I can manage that.


Optimize RustStr's Equatable implementation

I want to address the following TODO:
https://github.com/chinedufn/swift-bridge/blob/a11b368bef4ba904c39481d735db537205de29c4/crates/swift-bridge-build/src/generate_core/string.swift#L28-L35

Awesome! Let me know if you need anything.

To address this issue, I added the following unit test:

let hi = create_string("hi").as_str()
let he = create_string("he").as_str()
XCTAssertNotEqual(hi, he)

Result:

hi and he seem to have the same address. It's strange. I' dont overrwrite create_string and as_str method, by the way. I just overrwrote RustStr's == operator.

Closed via https://github.com/chinedufn/swift-bridge/pull/151


When the value of  khchecks' runInterval  field is a little small, the khcheck pod  can't enter the "Running" state, and will be deleted forcely under a certain probability, which will report an error to the khstate object.

When I deploy a kuberhealthy in my cluster, I set several khchecks which the runInterval field set to 5min or 10min. In the very beginning of time, it runs well. But suddenly I got a lot of errors from the kuberhealthy report. The error is almost "pod deleted unexpectedly". So I keep monitor the khcheck pod. I found that every time the khcheck pod will stay in "ContainerCreating" status for more than 1 min，and then the pod will be deleted forcely. But my khcheck pod usually takes about ten seconds to enter the "Running" state, and run about 1 min it will be Completed which is much less than the runInterval. The weird thing is that I discover when the khcheck pod is stay in "ContainerCreating" status, the code in the pod is start running! I was really puzzled. Because the pod cannot enter the "Running"  status, so I can't get logs of the pod. I don't know why. Then I tried to set the runInterval to 20 min, the errors' gone! I am very puzzled why this happen. The k8s cluster should be no problem. I really hope to get your help. Thank you very much.

Thanks for your report.

Can you run kubectl describe on the pod that is stuck in ContainerCreating?  It would be helpful to see the Events section.
Can you paste your khcheck here so we can review?
Can you find logs from your kuberhealthy pod around the time when it says pod deleted unexpectedly?


How to set file types to a specific grammar in project settings?

I want to associate all the .js files in my project to be opened with a specific grammar settings, and similarly all .html files with another specific grammar type. How do I do that?
Specifically I want:

.js to use javascript (meteor) grammar
.html to use spacebars grammar

Have you tried to use the file-types plugin and set its parameters inside your project settings?

Apparently file-types is depreciated in favour of core.customFileTypes. However, I can't seem to get it to work. Here's my projects.cson:
[
  {
    title: "Test Project"
    paths: [
      "/Users/andrew.rininsland/Projects/test-project"
    ],
    settings: {
      core: {
        customFileTypes: {
          'text.html.nunjucks': [
            'html'
          ]
        }
      }
    }
  }
]

I'm trying to get all .html files in my project to use the Nunjucks grammar but it's not working. This also doesn't work:
[
  {
    title: "France 2017 Poll Tracker"
    paths: [
      "/Users/andrew.rininsland/Projects/france-2017-poll-tracker"
    ],
    settings: {
      '*': {
        core: {
          customFileTypes: {
            'text.html.nunjucks': [
              'html'
            ]
          }
        }
      }
    }
  }
]

I'm experiencing this too.


Updates .github configuration

[#172332619]
Co-authored-by: Timothy Hitchener<EMAIL_ADDRESS>

update version


multi-robot navigation

How to build open-vocabulary obstacle maps from a list of obstacle categories for different robot embodiments for multi-robot navigation?

An example is shown in generate_obstacle_map.py. By calling customize_obstacle_map method in the class VLMap (see here), you can provide a list of potential obstacle names and a list of real obstacle names among the potential names to create an open-vocabulary obstacle map. The customized obstacle map is saved in the attribute obstacles_new_cropped in VLMap.


Signed package

I was attempting to submit Mist as a cask in homebrew, which requires that packages be signed. Is it possible for the Mist.0.5.pkg to be signed? Also, I think macOS on ARM requires applications to be signed.

https://github.com/Homebrew/homebrew-cask/pull/141504

The Mist packages and apps are already signed and notarized when uploaded to GitHub:
pkgutil --check-signature Mist.0.5.pkg
Package "Mist.0.5.pkg":
   Status: signed by a developer certificate issued by Apple for distribution
   Notarization: trusted by the Apple notary service
   Signed with a trusted timestamp on: 2022-12-29 06:10:33 +0000
   Certificate Chain:
    1. Developer ID Installer: Nindi Gill (7K3HVCLV7Z)
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           66 9A 5B 80 72 F8 40 29 EF C0 B8 22 ED A9 D2 7B 21 62 05 E3 BE 76
           32 1B AC 26 7D 6E F4 D9 4D 70
       ------------------------------------------------------------------------
    2. Developer ID Certification Authority
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03
           F2 9C 88 CF B0 B1 BA 63 58 7F
       ------------------------------------------------------------------------
    3. Apple Root CA
       Expires: 2035-02-09 21:40:36 +0000
       SHA256 Fingerprint:
           B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
           68 C5 BE 91 B5 A1 10 01 F0 24

spctl -a -vv Mist.app
Mist.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Nindi Gill (7K3HVCLV7Z)

I see https://github.com/Homebrew/homebrew-cask/pull/141504 was merged - is the cask working as expected?

Sorry, my bad. The pkg is indeed signed correctly. I didn't look too closely at the brew audit output. Brew audit output is misleading in claiming the package is unsigned and "Please contact the upstream developer to let them know they should notarize their package." as you can see in the screenshot.
It seems the minimal installation of Xcode does not support signature checking and requires the full Xcode 🙄


Unable to connect to subscription/resource group

Storage Explorer Version: <1.13.1 -->
Build Number:
Platform/OS:
Architecture:
Regression From:
Bug Description
<Storage explorer doesn't display storage accounts associated with subscription>
Steps to Reproduce

Expected Experience
<Be able to navigate to any of the storage accounts in the subscription -->
Actual Experience
<Can't see any of the storage accounts or containers -->
Additional Context
<Subscriptions for the follwowing tenants could not be retrieved:
Tenant Id: 271df5c2-953a-497b-93ad-7adf7a4b3cd7, Error: {
"name": "Error",
"message": "self signed certificate in certificate chain",
"stack": "Error: self signed certificate in certificate chain\n    at TLSSocket.onConnectSecure (_tls_wrap.js:1049:34)\n    at ZoneDelegate.invokeTask (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\zone.js\dist\zone-node.js:275:35)\n    at Zone.runTask (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\zone.js\dist\zone-node.js:151:47)\n    at TLSSocket.ZoneTask.invoke (C:\Program Files (x86)\Microsoft Azure Storage Explorer\resources\app\node_modules\zone.js\dist\zone-node.js:345:33)\n    at TLSSocket.emit (events.js:182:13)\n    at TLSSocket._finishInit (_tls_wrap.js:631:8)",
"code": "SELF_SIGNED_CERT_IN_CHAIN"
}

Can you try to follow this troubleshooting guide to see if you can fix your issue first?  https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-troubleshooting?tabs=Windows%2C1904#error-self-signed-certificate-in-certificate-chain-and-similar-errors
Thanks.

Closing due to lack of response. Please open a new issue if you're still having problems.


Use Kafka 3.5 as AMQ operator does not support 3.6

Summary
backports https://github.com/quarkus-qe/quarkus-test-framework/pull/937
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[x] Backport
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests


Align with recent cfg80211 header

1. The scan_width field is no longer present in the cfg80211_inform_bss structure.
commit 5add321 wifi: cfg80211: remove scan_width support
kernel version : v6.9-rc6 ~ v6.7-rc1
date : Sep 13, 2023

There really isn't any support for scanning at different channel widths than 20 MHz since there's no way to set it. Remove this support for now, if somebody wants to maintain this whole thing later we can revisit how it should work.

- bss_data.scan_width = NL80211_BSS_CHAN_WIDTH_20;

2. The parameters in the change_beacon function have been updated to cfg80211_ap_update.
commit bb55441 wifi: cfg80211: split struct cfg80211_ap_settings
kernel version : v6.9-rc6 ~ v6.7-rc1
date : Sep 25, 2023

Using the full struct cfg80211_ap_settings for an update is misleading, since most settings cannot be updated. Split the update case off into a new struct cfg80211_ap_update.

/**
 * struct cfg80211_ap_update - AP configuration update
 *
 * Subset of &struct cfg80211_ap_settings, for updating a running AP.
 *
 * @beacon: beacon data
 * @fils_discovery: FILS discovery transmission parameters
 * @unsol_bcast_probe_resp: Unsolicited broadcast probe response parameters
 */

+struct cfg80211_ap_update {
+	struct cfg80211_beacon_data beacon;
+	struct cfg80211_fils_discovery fils_discovery;
+	struct cfg80211_unsol_bcast_probe_resp unsol_bcast_probe_resp;
+};

	int	(*change_beacon)(struct wiphy *wiphy, struct net_device *dev,
-				 struct cfg80211_ap_settings *info);
+				 struct cfg80211_ap_update *info);

commit 66f85d5 wifi: cfg80211: modify prototype for change_beacon
kernel version : v6.9-rc6 ~ v6.7-rc1
date : Sep 13, 2023

Modify the prototype for change_beacon() in struct cfg80211_op to accept cfg80211_ap_settings instead of cfg80211_beacon_data so that it can process data in addition to beacons. Modify the prototypes of ieee80211_change_beacon() and driver specific functions accordingly.

int	(*change_beacon)(struct wiphy *wiphy, struct net_device *dev,
-				 struct cfg80211_beacon_data *info);
+				 struct cfg80211_ap_settings *info);

Simply put, the change_beacon function now includes two additional parameters, fils_discovery and unsol_bcast_probe_resp, which are part of the cfg80211_ap_update structure.
fils_discovery : FILS discovery transmission parameters
unsol_bcast_probe_resp : Unsolicited broadcast probe response parameters

Close via commit 35ca058e767d87a7c809091ae910b2bf02687870


Can lit-gpt support deepseek-coder finetune?

DeepSeek-Coder:
https://github.com/deepseek-ai/DeepSeek-Coder

It can since it's based off Llama 2, which is already fully supported. Contributions are welcome


Split GitHub Actions workflows

This PR is related to https://github.com/optuna/optuna/issues/2654.
This PR splits the CI job of Optuna examples.
The original workflow file is optuna/.github/workflows/examples.yaml
The changes are as follows:

Create subdirectories for catboost, dask_ml, haiku, ray, skimage and tensorboard
Add requirements.txt to mange dependencies
Update links in README.md
Add GitHub Actions workflow files for CI

We'll relax the review policy. The optuna/optuna requires two approval reviews, but this repository requires a single approval. If we find issues after merging PRs, we'll work on them in follow-up PRs.
So, let me merge this PR.