Support for case insensitive query search something like "$regex" instead of "$contains"

Issue you'd like to raise.
To get documents from collections (vector db) there is a method:
class Collection(BaseModel):
    name: str
    id: UUID
    metadata: Optional[CollectionMetadata] = None
    _client: "API" = PrivateAttr()
    _embedding_function: Optional[EmbeddingFunction] = PrivateAttr()

    def __init__(
        self,
        client: "API",
        name: str,
        id: UUID,
        embedding_function: Optional[EmbeddingFunction] = ef.DefaultEmbeddingFunction(),
        metadata: Optional[CollectionMetadata] = None,
    ):
        self._client = client
        self._embedding_function = embedding_function
        super().__init__(name=name, metadata=metadata, id=id)

    '''
    '''
    def get(
            self,
            ids: Optional[OneOrMany[ID]] = None,
            where: Optional[Where] = None,
            limit: Optional[int] = None,
            offset: Optional[int] = None,
            where_document: Optional[WhereDocument] = None,
            include: Include = ["metadatas", "documents"],
        ) -> GetResult:
            """Get embeddings and their associate data from the data store. If no ids or where filter is provided returns
            all embeddings up to limit starting at offset.

            Args:
                ids: The ids of the embeddings to get. Optional.
                where: A Where type dict used to filter results by. E.g. `{"$and": ["color" : "red", "price": {"$gte": 4.20}]}`. Optional.
                limit: The number of documents to return. Optional.
                offset: The offset to start returning results from. Useful for paging results with limit. Optional.
                where_document: A WhereDocument type dict used to filter by the documents. E.g. `{$contains: {"text": "hello"}}`. Optional.
                include: A list of what to include in the results. Can contain `"embeddings"`, `"metadatas"`, `"documents"`. Ids are always included. Defaults to `["metadatas", "documents"]`. Optional.

            Returns:
                GetResult: A GetResult object containing the results.

            """
            where = validate_where(where) if where else None
            where_document = (
                validate_where_document(where_document) if where_document else None
            )
            ids = validate_ids(maybe_cast_one_to_many(ids)) if ids else None
            include = validate_include(include, allow_distances=False)
            return self._client._get(
                self.id,
                ids,
                where,
                None,
                limit,
                offset,
                where_document=where_document,
                include=include,
            )

To query documents by searching for a particular term in the document where_document = {"$contains": "langchain"} can be passed to the get() method. This value for the key/operator $contains is case sensitive. How to search for keywords irrespective of case?
Suggestion:
I want to extract entities from a sentence and pass it get documents from the chromadb that contains that words. But this entities need to be case sensitive. If the LLM outputs a different case like for example, the document contains the keyword: "Langchain", but asking llm to extract the entity from the sentence it isnt always sure that it will generate "Langchain", it can output: "langchain". This can be handled if the first letter of the entities generated is capitalized. But this may not work for keywords like OpenCV.

@dosu-bot About the feedback you asked:
To better understand your needs and to propose a suitable solution, could you please provide more details about your use case? Specifically, it would be helpful to know:

Are you looking for a global setting to make all $contains queries case-insensitive, or do you need to switch between case-sensitive and case-insensitive searches?
Are there any specific performance considerations we should be aware of for your use case? For example, would you be okay with a potential trade-off between search speed and case-insensitivity?
Could you provide some examples of the types of queries you're trying to perform? This will help us understand the complexity and variety of the searches you need to support.

I want switch between $regex and $contains if there is a trade-off in performance when using $regex. If there is no compromise in the search speed $contains can search for all the case-insensitive queries by changing global settings.
Types of Queries can be, "OpenCV", "NumPy", "FedEx", "iPhone", "WordPad", "JavaScript", "LinkedIn", "WordPress", "YouTube", etc.

@dosu-bot for the questions you asked as below:
Thanks for reaching out with your question. To better assist you, I need a bit more information about your current setup and usage of the LangChain framework.

1. Could you please provide more details about the data structure you're working with? Specifically, what are the fields in your documents and what types of data do they contain?

2. Are you currently using any specific indexing or search optimization techniques in your application?

3. Could you provide an example of how you're currently using the $contains operator in your get() method calls?

4. Are there any constraints or requirements that we should be aware of when considering modifications to the get() method or the framework?

The more context you can provide, the better I can assist you in finding a solution that fits your needs.

Answers:

Document will contain text data, so $contains will search for words.
No I am not using anny specific indexing or search optimization technique.
Currently I am using get() method as follow: vector_store.get(where_document={"$contains": "langchain"}))
No there are no constrains. Just add $regex or make $contains case-insensitive.

@dosu-bot I am using Chromadb, Redis is irrelevant for me.

@dosu-bot

Name: langchain
Version: 0.0.305

Name: chromadb
Version: 0.4.6

No other library in conjunction with Langchain and Chromadb

There is no such specific document size, total number of documents and frequency of queries. You can assume the maximum values possible.

@dosu-bot you know what, what I want to do is very simple, but you keep on asking many questions. I am done with it.

Hey @meet1919 Sorry Dosu couldn't help you more. If Dosu get "stuck" asking clarifying questions, it means they aren't able to find anything with the repository to concretely answer your question.
We're working on improving this! As for your question, WhereDocument type comes from ChromaD, so I'd go their Discord or Github to find an answer.
Let me know if you have any other ideas on ways we can make Dosu more useful!

@meet1919 I'm not familiar with all VectorDBs, but I use Supabase/Postgres with pgvector, which you can definitely do insensitive queries using SQL.

About Dosu-bot, does it search with internet and bringing the information into its context while generating answer? Along with information from the source code in the context too. Follow-up questions are asked properly but is there a way to converge the planning process rather than keeping on asking questions?

Not yet. Internet information can be noisy and not always relevant to the issue, which is why we haven't incorporated it yet.
For converging the planning process, yes this is actively being worked on so stay tuned.


[CDN]  updated query string caching default behavior and profile name help text.

Fixes #7207
az cdn endpoint create's --profile-name parameter now has help text.
query-string-caching parameter is no longer set to "IgnoreQueryString" by default. Default behavior now depends on service. For standard_akamai and standard_verizon default behavior is "IgnoreQueryString", while for premium_verizon it is "NotSet".

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@tjprescott I was planning on making any changes (if necessary) to deal with the premium profile issue before bumping the version number. I will make sure to bump the version number.

@tjprescott Let me know your thoughts. Are the new tests unnecessary / overkill? They are pretty much tests to verify the expected behavior (with regard to the query caching behavior) of creating an endpoint with different profiles.

@adewaleo the tests are good--the history entry needs changes.

@adewaleo the tests are good--the history entry needs changes.

Does the history entry look good now?


Update Eclipse to 2020-12

Closes #425

Tests should pass once rebased against #427

Rebase shouldn't be necessary to resolve the issue with Packer lint; since the changes aren't to the same file, git checkout action should cleanly merge them to what main would be if this were merged. Re-running the jobs should be all that's required. Seems like the new Eclipse file hasn't been synced to all mirrors yet though.

Yep, getting that lagging mirror feeling now.


[Fixing Test Cases] Allow 0 in label image test cases

This PR contains:

[ ] a new test-case for the benchmark

[ ] I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark

[ ] new dependencies in requirements.txt

[ ] The environment.yml file was updated using the command conda env export > environment.yml

[ ] new generator-functions allowing to sample from other LLMs
[ ] new samples (sample_....jsonl files)
[ ] new benchmarking results (..._results.jsonl files)
[ ] documentation update
[x] bug fixes

Related github issue (if relevant): closes #130
Short description:

Test cases involving label images will now accept 0 as a valid label if the LLM solution includes it.

How do you think will this influence the benchmark results?

Broadly increases the scoring for these test_cases (in my view, nearer to expectation)

Why do you think it makes sense to merge this PR?

This one also depends a little on #118. If our model prompting becomes more specific (e.g., to directly specify that 0 is not a valid label), this PR may be closed.

Thanks for working on this @ian-coccimiglio !


combine ping_op and close_op

These two composed operations have the same state and almost the same code, they can be combined into control_op to handle all three cases (ping, pong, control) with a little bit of CRTP or using a Policy template type that handles the minor differences (for example close_op sets wr_close_=true)
All ping, pong, close members of stream can just reside in control.ipp and do away with ping.ipp and close.ipp

close_op is now sufficiently different that this issue is no longer applicable.


SWF Playback should allow replay upon completion to match HTML5

In the SWF player, both HLS streams and FLV don't seem to allow a replay, once completed.
Here's a demo of what I'm working on (A Knockout based component using MEjs) where you can compare the behavior.
http://snaptopixel.com/misc/mejs/

@lsvt-casey Closing this issue since fixed was merged already


shift-insert shortcut is not bound to "paste"

when pressing shift-insert it should paste the clipboard contents, just like Ctrl-V.
Many people (like me for example) are used to the much more accessible shift-del and shift-ins keyboard shortcuts to control the clipboard instead of ctrl-c/x/v, simply because it does not require moving the hands across the keyboard and rearranging the fingers when already using left shift (left hand) and up/down/left/right/pos1/end (right hand) to move the cursor around the document and select portions of text.
Most text editors and word processors have bound these two clipboard functions to these two key combinations and now I have become so used to it that everytime I want to copy (or cut) a couple of lines in AsciidocFX I will cut them with shift-del and then 200 milliseconds later I realize I cannot insert them back again with shift-ins which forces me to rearrange my hands to a seldomly used (by me) position to execute a ctrl-v instead.
Please implement this keyboard shortcut. Shift-del is already working as expected, now all that is missing is its counterpart shift-insert.

@prof7bit Yes, we should implement it.


Code Block enhancements

It would be nice to be able to collapse code blocks, and really awesome if code blocks had syntax highlighting.
You can see an example of highlighting here: https://homelab.blog/blog/devops/cloudflare-workers/

Would love to help out with this feature.

Go for it!


Add possibility to stop a karma server

When you start testacular with singleRun=false from within a script (Eg. build script) there is no way to stop it again (apart from killing the process manually).
Someting like
node testacular stop 9876
would be nice.

@dignifiedquire We can close this, right?

Yes we can thanks to you :)

Still staying open for me
(datalab) joe:datalab joeflack4$ ./node_modules/karma/bin/karma start --single-run
02 10 2018 12:40:51.691:WARN [watcher]: Pattern "/Users/joeflack4/projects/datalab/test/fixtures/**/*" does not match any file.
ℹ ｢wdm｣: Hash: 1af0291e2b7daf4c1038
Version: webpack 3.10.0
Time: 61ms
ℹ ｢wdm｣: Compiled successfully.
02 10 2018 12:40:51.712:WARN [watcher]: Pattern "/Users/joeflack4/projects/datalab/test/fixtures/**/*" does not match any file.
ℹ ｢wdm｣: Compiling...
ℹ ｢wdm｣: wait until bundle finished: noop
ℹ ｢wdm｣: wait until bundle finished: noop
ℹ ｢wdm｣: wait until bundle finished: noop
ℹ ｢wdm｣: wait until bundle finished: noop
ℹ ｢wdm｣: Hash: 80d465b0bcc75b9fc8d3
Version: webpack 3.10.0
Time: 1324ms
                               Asset     Size  Chunks                    Chunk Names
      test/javascripts/chart.test.js  1.01 MB       0  [emitted]  [big]  test/javascripts/chart.test
    test/javascripts/network.test.js   445 kB       1  [emitted]  [big]  test/javascripts/network.test
  test/javascripts/url-parse.test.js   380 kB       2  [emitted]  [big]  test/javascripts/url-parse.test
test/javascripts/definitions.test.js   407 kB       3  [emitted]  [big]  test/javascripts/definitions.test
    test/javascripts/utility.test.js   408 kB       4  [emitted]  [big]  test/javascripts/utility.test
   [7] ./node_modules/babel-runtime/helpers/classCallCheck.js 208 bytes {0} {1} {2} {3} {4} [built]
  [24] ./source/javascripts/utility.js 5.58 kB {0} {1} {3} {4} [built]
  [78] ./test/javascripts/chart.test.js 6.47 kB {0} [built]
  [79] ./node_modules/jquery/dist/jquery.js 272 kB {0} [built]
  [80] ./node_modules/chai/index.js 40 bytes {0} {1} {2} {3} {4} [built]
 [103] ./node_modules/chai-spies/chai-spies.js 20.5 kB {0} {1} {3} {4} [built]
 [104] ./source/javascripts/chart.js 25 kB {0} [built]
 [162] ./source/javascripts/url-parse.js 2.05 kB {0} {2} [built]
 [170] ./source/javascripts/definitions.js 1.99 kB {0} {3} [built]
 [177] ./env.js 1.21 kB {0} {1} [built]
 [182] ./test/javascripts/definitions.test.js 1.36 kB {3} [built]
 [183] ./test/javascripts/network.test.js 1.29 kB {1} [built]
 [184] ./source/javascripts/network.js 5.41 kB {1} [built]
 [186] ./test/javascripts/url-parse.test.js 1.43 kB {2} [built]
 [187] ./test/javascripts/utility.test.js 4.67 kB {4} [built]
    + 173 hidden modules
ℹ ｢wdm｣: Compiled successfully.
02 10 2018 12:40:55.725:INFO [karma]: Karma v2.0.5 server started at http://<IP_ADDRESS>:9876/


Error fetching maps

java.util.concurrent.CompletionException: java.nio.file.InvalidPathException: Illegal char <:> at index 7: starway:_krasnograd.v0001.png

We know this error for years lemme check the staus. So this is definetly a duplicate

#902 #852 #614

https://github.com/FAForever/faf-java-api/pull/208 we solved it for newely uploaded maps however their are still old maps that conatin illegal characters

told mods to hide map


ERICSSON - MEAS_COLLEC_XML - parsing output empty - Cloud oriented

Hi,
I've installed BTS-CE-Lite in my computer and tried to use it to Parse and Import an PM File from an OpenStack (type of) cloud system. It implements the MEAS_COLLECT_XML format.
Attached a small example.
No error is shown but resulting file is empty.
Is this use case supported in bts-ce-lite?
Thanks in advance, Jose
PRODUCTION_ECMES_20190926_0945-1000_metrics.zip

@jsanz01 it should be but let me the sample you have shared and confirm

@jsanz01 we are not handling this format measurement collect format well. We will release update over the weekend for this.

@erssebaggala Do you have any news about this point?. I could be really great to use Boda Stage with these files. Please, let me know if I can support. Thanks, Jose

@jsanz01 changes to the  measurement collection parser have been made at https://github.com/bodastage/boda-measdatacollectionparser/releases .  It will be updated in today's release.

@erssebaggala Hi Emmanuel, now that the new measdatacollectionparser has been improved with the new type of "r" fields.
Could you please let me know when this new library (.jar) file will be included in the bts-ce-lite application (.EXE package rebuild)?
Thanks, Jose

@jsanz01, give me a day to update it

@jsanz01 the parser has been updated check ot
https://github.com/bodastage/bts-ce-lite/releases/tag/v0.5.0. Thanks for reporting this issue.


Implement resource indicator spec

https://tools.ietf.org/html/draft-ietf-oauth-resource-indicators-08
this is our interpretation of how it works in IdentityServer
a) no resource parameter, scope parameter

all resources requiring indicator are excluded
AllowedScopes works as today
same behavior as today + if scope is defined in multiple resources, then you'll get multiple audiences

b) resource parameter, scope parameter

all resources that match the resource parameter(s) are used
must use new AllowedResources config setting
get one access token per resource with downscoped behavior

if a requested scope is not present in any resource -> invalid_target
if a requested scope is not present in one or more resource

if resource has no scopes defined -> access token without scopes
if resource has scopes defined -> invalid_target

c) resource parameter, no scope

all resources that match the resource parameter(s) are used
must use new AllowedResources config setting
get one access token per resource with no scopes if resource has no scopes defined

Need any assistance implementing this?  Very interested


Update virtual-machines-linux-setup-tomcat7-linux.md

Reviewed, not update needed.

Hi @NingKuang, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Cannot be installed under luarocks/lua 5.4

Hi,
luamqtt does not install under luarocks for lua 5.4.
the culprit appears to be the line "lua >= 5.1, < 5.4" in the rockspec file.
Changing the '5.4' to '5.5' allows building/installation of luamqtt under lua 5.4/luarocks.

Hi @oktoberfest6 ,
I've fixed and updated rockspec file on the luarocks.
That Lua version limitation was because the copas project also does not define it: https://github.com/keplerproject/copas/blob/master/rockspec/copas-3.0.0-1.rockspec#L30
(@Tieske can you please take a look?)
The luamqtt does not depend on copas directly but can be used as one of the available connectors and it's used in tests: https://github.com/xHasKx/luamqtt/blob/master/tests/spec/mqtt-client.lua#L515
Now I just changed the tests runner script to avoid testing copas for the Lua 5.4 in the commit 7c62daa

Just uploaded a new rockspec for Copas, Lua 5.4 is now supported


WIP: netbsd-*: 8.0 -> 9.0

Motivation for this change
Heavily WIP. Split out from #82131 as I'll make that one just about FreeBSD.
Things done

[x] Update all versions and hashes
[ ] Everything that cross-compiled for NetBSD before the update still does
[ ] Static binaries run on NetBSD
[ ] Everything used on Darwin still works.

I'd recommend bringing this up to 9.1. It's fully compatible with 9.0 with some extra bug fixes and enhancements. We'll be releasing 9.2 in a month or so and that's going to come with another round of important bug fixes.

@niacat Thanks for the tip. This is a plenty old commit I split off from an old WIP PR, so I am happy to go straight for 9.1 (or maybe 9.2 if I don't get to this sooner).

Edited the PR body to include a checklist of things we'll need to do.

Everything in unixtools builds:
$ nix-build -A netbsd.column -A netbsd.getconf -A netbsd.getent -A netbsd.locale
/nix/store/ihdyybd3hjsra8bx5xfvkb0l6y47qans-column-netbsd-9.1
/nix/store/8vp89svqlgjfp90s20jqs4y8byb43cd3-getconf-netbsd-9.1
/nix/store/d12wfd7p3qj2wzycdm0p6vbzr0c84g9c-getent-netbsd-9.1
/nix/store/1rb4nahid5lp167z1s026v4dsjsxcyd7-locale-netbsd-9.1

samba4 is marked as broken (on darwin at least).
A dependency of swtpm is not supported on darwin

Started the remaining two builds just now, I'll just edit this message when they are finished.

Actually everything except libterminfo, libcurses, man, uudecode and libedit builds on darwin.

Actually everything except libterminfo, libcurses, man, uudecode and libedit builds on darwin.

Did libterminfo build before this change?  Everything else is expected,
I think.  (Well, uudecode is new, but I never tested it on Darwin.)

Did libterminfo build before this change? Everything else is expected, I think. (Well, uudecode is new, but I never tested it on Darwin.)

Nope, uudecode also didn't build.

Hmm, the x64 EFI bootloader fails to build with the same error as the 32-bit one. :(
They did work on 8.0, so I'm not really sure what to do here.  How much do we want these bootloaders, I suppose?

Interesting! The NetBSD change that breaks this for us, claims to be a fix for it! http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/i386/stand/efiboot/bootx64/ldscript.diff?r1=1.1&r2=1.2&only_with_tag=MAIN&f=h

@Ericson2314 I think this is ready now, what do you think?
I think we probably will want to squash merge this one, so we don't end up with commits with broken packages and make bisects annoying.

Great! Thanks for taking this over from me.


Correct parsing of scitokens.cfg with empty audience_json value

The INI library always returns a key when there's a lookup -- if the key isn't in the section, the returned object is a valid key with an empty value.  When this empty string was being parsed as JSON, an error was thrown.
Fixed the conditional to check for a non-empty key and added a short unit test.
Note this branch builds on top of #594.
Fixes #601

Bah.  Looks like the slices package was introduced in 1.21.0 and we're on 1.20.0!

@bbockelm Replaced slices by reflect.DeepEqual. Hopefully GHA is happy.

I think the second round of tests failed due to flaky test in a random way, but it seems to be still part of the testing on xrootd maintenance routine that caused the failure: https://github.com/PelicanPlatform/pelican/actions/runs/7413081964/job/20171285018


Add pcc64le to binary builds

Which problem is this PR solving?

Short description of the changes

I seem to be stuck in a DCO loop... each time I follow the steps to correct it I get the same issue.

@redmark-alt I would suggest squashing all commits to a single commit and then sign it.
Personally I would use interactive rebase to squash the commits and then g rebase HEAD~1 && g add -A && g commit -s "message" -s, or something similar.


Build image aem-dispatcher

I made a correction on build aem-dispatcher, for me work that way.
Hope it helps.

@jimfrenette A lot of your commits are included in this PR. Are you OK with that?

I made a PR? I thought I had only forked the repo. If you think they Re useful sure, I'm okay with them. I certainly like the changes.
Sent from Yahoo Mail on Android
On Tue, Jul 24, 2018 at 3:47 AM, Lukas<EMAIL_ADDRESS>wrote:
@jimfrenette A lot of your commits are included in this PR. Are you OK with that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jimfrenette commented on Jul 24, 2018, 14:43 AM CEST:
I made a PR? I thought I had only forked the repo. If you think they Re useful sure, I'm okay with them. I certainly like the changes.

You only forked the repo, but @gb8may now created the PR based on your work and I just wanted to quickly check if you're OK with it.

Cool, thanks for checking. I'm OK with these changes. They are working in both OS X and Windows. I am having an issue in Linux which I think is applicable even before my changes. I will test an open an issue as needed once I have more details.
Sent from Yahoo Mail on Android
On Tue, Jul 24, 2018 at 8:56 AM, Lukas<EMAIL_ADDRESS>wrote:
@jimfrenette commented on Jul 24, 2018, 14:43 AM CEST:
I made a PR? I thought I had only forked the repo. If you think they Re useful sure, I'm okay with them. I certainly like the changes.
You only forked the repo, but @gb8may now created the PR based on your work and I just wanted to quickly check if you're OK with it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Adds Encounter location and type constraints

Description of what I changed

E2E test

TESTED:
I have updated the dwh/test_query_lib.ipynb notebook and added examples with and without Encounter constraints. Spot-checked a sample patient with some encounters filtered out.
Checklist: I completed these to help reviewers :)

[x] My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides. Note, when in conflict, OpenMRS style guide overrules.

[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
Beside the unit-tests, see TESTED above too.

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[x] All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

Thanks @kimaina for the review; PTAL.


Implement fix for ElementColor in nb199

Change-Id: I7e72b548130b65c29fd22c30a24a92e282fc6dbc

General items:

[ ] I have updated the relevant documentation files under docs/
[x] My code follows the:

[x] Google Java style guide (for .java files)
[x] Google JavaScript style guide (for .js files)

[x] ant tests passes on my machine

If your code changes how something works on the device (i.e., it affects the companion):

[x] I branched from ucr
[x] My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

[x] I have updated the corresponding version number in YaVersion.java
[x] I have updated the corresponding upgrader in YoungAndroidFormUpgrader.java (components only)
[x] I have updated the corresponding entries in versioning.js

For all other changes:

[ ] I branched from master
[ ] My pull request has master as the base

What does this PR accomplish?
Per the discussion on the forum, ElementColor defaults to Black, which is fine except for when people change the BackgroundColor of the ListView. This only affects Android companion 2.73 for now. Android versions prior to 2.73 and all iOS versions do not have the ElementColor property so BackgroundColor is the only color to customize the ListView. By changing the ElementColor to be transparent by default, it causes the elements to be invisible (making BackgroundColor match existing behavior) unless the user changes it to something opaque.

@patryk84a PTAL

When I start working with the MockListView file I realized that the divider should have a default color set to gray. Android didn't have a divider until now, and iOS creates them automatically in gray. Do we need to worry about this? I won't hide the fact that I'll want to add DividerColor and DividerThickness to the iOS version.


add Worker#work_off and rake qc:work_off.

This provides a way to work off all the jobs in the queue
and exit afterwards.
Closes #191.

@smathieu @jipiboily thoughts?

:+1:
work_off seems a bit obtuse. If I could go back in history I'd propose qc:start for the daemon task and qc:work for this work-and-exit task. However, assuming we don't want to break the existing task name, I don't have a better suggestion besides something like complete, finish or clear. Actually, I think I like qc:clear best?

I would expect a task named qc:clear to delete of the tasks from the queue, not process them. I'd agree that qc:start and qc:work would be better, but unfortunately, we can't change that. I think work_off is fine for now.

The code is fine, but I worry about how this project is evolving. QC was originally designed (as far as I understand) to have a simple and limited interface for workers. This would allow users of QC to create their own subclass of the worker class and override some method.
It seems that over the year, the size of the worker interface has kept growing, making it less approachable to override.
For instance, if someone overrode the Worker#work method, he now needs to know that he should all override the Worker#work_off method. If he doesn't and he doesn't use the rake task, then it doesn't matter. But the fact of the matter is that you now have a rake task in your application that doesn't work or has unknown behaviour.
Something to think about I guess.

@smathieu I agree with everything you say. I also do think that this functionality should be part of the limited interface we provide.
The PR was created to be fully backwards compatible but as you pointed out, this is a tradeoff in other areas. Depending on wether this lands in a major or minor we might have more flexibility to rework the internals. I'd like to see a more approachable interface as well.
@jipiboily any thoughts on a roadmap?

I'm on the fence on that one. I don't have a strong opinion, but it doesn't feel like something that most people will use.
The more I think about qc, the more I think it should keep a tight scope, stay easily approachable and modifiable. To achieve this, I think we should mostly add stuff that will be used by the majority of the people using qc.
Are there any other use cases you can think of? The original one (using this on Heroku to avoid paying for a full dyno) seems like something very few people will do, and it's easy to work around it.

And by the way, my life changed a bit in the last couple months, you might have seen I don't have much time to work on qc or any open source stuff, and I don't think this will change anytime soon. Basically, don't wait for me if you want to be able to move at a decent pace :)

I still feel we should put this in. Some use-cases I've came across where this would be very helpful.

For very low-volume projects it might be easier to configure a cron-job using #work_of than to manage background processes. This would be a very easy way to get started with background jobs.
In integration tests when you want to run all queued_jobs before continuing without having to manage a worker process.

I don't have a strong opinion, so either way is fine IMHO.

This makes sense and has precedent: delayed_job has a jobs:workoff task (link)

If you want to just run all available jobs and exit you can use rake jobs:workoff

Agreed, a cron job is a good example where it would be needed.  Another would be spinning up an expensive host twice a day to drain the queue.  I'd like to see this feature.
That said, I agree with @smathieu...  QC's internals have always been weird and they're getting weirder.  For example, in this PR, lock_job, lock_job_no_wait seem inside-out, and work and work_off seem like copy pasta.
Is it OK to make minor changes to lock_job and work's method signatures to clean this up?  I don't imagine anyone would be overriding them.
But maybe it's not OK...  Since the docs recommend overriding Worker to manage connections (!), and nobody put any private statements anywhere (!!), the project might have guaranteed that the Worker class will never change...  If that's the case, I suppose this PR is the best that can be done and should be merged as-is.

@senny has convinced me that this is valuable, but I'm still not convinced this interface is the right one. Maybe we can limit the scope of change by making the lock_job method take an optional options have. e.g. lock_job(wait: false)

@bronson @senny not sure if y'all use this any more - if you do and you wanna work on this lmk, if not I might

I'm not in charge of any Rails projects anymore. Hope you can do it @ukd1!

In integration tests when you want to run all queued_jobs before continuing without having to manage a worker process.

I'm not sure if queue_classic already addressed this in the past few years, but que has Que.run_synchronously = true which IMO is a nice solution to this.
Our Que specs use this helper:
def run_que_synchronously
  Que.run_synchronously = true
  yield
ensure
  Que.run_synchronously = false
end

it "runs jobs inline without needing a worker" do
   run_que_synchronously do
      Job.enqueue()
      OtherJob.enqueue()
   end
end


AUR package

https://aur.archlinux.org/

Honestly I'd kill for an AUR package of this

While I work on publishing an AUR package for omm, would getting linux binaries directly from a release suffice for now? Something like this:
# choose a gzipped tarball based on your architecture
curl -s -L -o omm.tar.gz https://github.com/dhth/omm/releases/download/v0.2.1/omm_0.2.1_linux_amd64.tar.gz
tar -xvzf omm.tar.gz
# move omm to a location on your $PATH
omm

I've published one and ready to maintain it
Could you please provide instructions on how to verify tarball signatures? I see that cosign is used, but the public key (cosign.pub) is in .gitignore

@dimatematik Thanks a lot for publishing it :)
I've added cosign.pub to the release assets. The tarballs (or any other files in the release, eg. checksum files) can be verified using:
cosign verify-blob --key cosign.pub --signature omm_0.4.1_linux_amd64.tar.gz.sig omm_0.4.1_linux_amd64.tar.gz

Since I am new to AUR packages, I have a question:
The AUR package lists go as a dependency. Since I'm already publishing linux binaries, would it be easier to point the source directly to a precompiled binary (eg. the way it's done here), and remove the dependency?

The AUR package lists go as a dependency. Since I'm already publishing linux binaries, would it be easier to point the source directly to a precompiled binary (eg. the way it's done here), and remove the dependency?

I'm no expert either but I think that how it works:

package: Latest version
package-git: Latest git commit
package-bin: Latest version binary

Thanks for clarifying the verification process!
The use of -bin packages is a matter of debate (discussion example). Since the AUR is completely untrusted (maintainer == anyone), end users should verify that the binary was compiled by the original author of the code. As a maintainer, I am advised to validate the binary (as stated in the Arch package guidelines), but the end user cannot be sure of my honesty. The only way to verify whether a binary was provided by the code's author is through cryptographic verification. Currently makepkg natively only supports PGP keys, so checking with cosign will require the "cosign" dependency.
Personally, I don't think there is a problem with the "go" dependency. The AUR is designed to store build instructions. -bin packages are typically used for heavy projects (like browsers) and proprietary software.

@dimatematik Makes sense. A non bin package with dependencies sounds good, then.
Side note: I added more details on verifying the authenticity of release assets here.

Well, someone published the -bin package) I think the issue can be marked as resolved


Change OpenDAP link to hydroshare directory off Hyrax root

[ ] Copy all the copies of HS NetCDF resources in /var/opt/hyrax/inedcdf_public_hydroshare to a new subdirectory /var/opt/hyrax/inetcdf_public_resource/hydroshare.
[ ] Change tgt_path Hong's /var/log/bes/scripts/expose_pub_netcdf_res.py script on hyrax.hydroshare.org to point to the that hydroshare catalog subdirectory
[ ] In hs_app_netCDF, change page_processors.py to generate links to /opendap/hydroshare/ instead of just /opendap/. This is so that Hydroshare NetCDF datasets in Hyrax can be in a hydroshare directly off the Hyrax catalog root, rather than in the root itself. This is so that the hydoshare datasets do not obscure the nwm directory on the catalog root. This would result in a visit to http://hyrax.hydroshare.org/opendap/ showing two top leverl directories, hydroshare and nwm. Merge into RC1.14 and deploy as hotfix to www.hydroshare.org.
[ ] Delete all the copies of HS NetCDF resources in the tope level only /var/opt/hyrax/inedcdf_public_hydroshare. Do nor remove the copies in /var/opt/hyrax/inedcdf_public_hydroshare/hydroshare.
[x] Create a repo in the hydroshare organization for the hyrax.hydroshare.org scripts and configuration data.

@hyi @gantian127 @aphelionz ^^^ and ref http://hyrax.hydroshare.org/opendap/ and http://hyrax.hydroshare.org/opendap/nwm/

@cbcunc Nice and thorough summary of bullet points on the steps. Just want to point out that for the last bullet point, I have already created a repo in the hydroshare organization just for this purpose here: https://github.com/hydroshare/hs_netcdf_to_hyrax, so I have checked off that bullet point.

Decommissioning Hyrax.

Decommissioning Hyrax.


Stack add

You already have Stack Icon

Requesting "Stack +" Icon

Closing as duplicate of #225

Added stack-plus, stack-minus


Data set problem

Besides comparing the PSNR of strong and weak photos, can this code handle its own images? Or can you input a data set and get an enhanced data set? Only enhance the picture.

Hi, thanks for your interest,
Yes, the first step is to pick up a pre-trained weight. Then use the corresponding config file. Modify the input and gt paths in the config file to the path of your data set. Finally run the test_from_dataset.py.
If you find our repo useful, please help us star it. Thank you :)

Thank you very much for your reply!
I still have some doubts. The dataroot_gt and dataroot_lq paths in the configuration file are high-quality and low-quality pictures respectively. We can compare them with the images in the dataroot_gt folder by enhancing the images in the dataroot_lq folder. Through test_from_dataset.py, we can get data such as psnr, and in the result, we can get the different images of the contrast image, but what I want to ask is how can I get the enhanced image. It is an image compared with the dataroot_gt folder.Thank you for your answer!


RFE: filter by name when importing a repository

Details
The user interface for browsing available repositories is almost unusable if the number of available repositories is large.  Even restricted to just my personal repositories, it took me almost three minutes of scrolling to find the one I wanted.
Expected Result
I wish there was a text field into which I could type a partial repository name and have the list of available repositories restricted to those matching the name. E.g, the Travis UI for selecting a repository @ https://travis-ci.org/account/repositories.
Actual Result
So. Much. Time.

Duplicate of #1899


spring-cloud-starter-archaius pulls commons-logging as transitive dependency

With SpringCloud Brixton.SR5, dependency tree:
 +- org.springframework.cloud:spring-cloud-starter-archaius:jar:1.1.5.RELEASE:compile
 |  |  +- commons-configuration:commons-configuration:jar:1.8:compile
 |  |  |  \- commons-logging:commons-logging:jar:1.1.1:compile

As far as I can tell, commons-configuration depends on commons-logging. Do you want us to exclude it? Couldn't that cause potential problems?

commons-logging:commons-logging and commons-logging:commons-logging-api are forbidden in the SpringBoot platform, hence the reason why they are excluded from all transitive dependencies in spring-boot-dependencies.
It is replaced by org.slf4j:jcl-over-slf4j to redirect all calls to the SLF4J façade. Having both on the classpath will make SpringBoot’s logging system complain at startup.
So yes, that dependency should be excluded. And no, as per SpringBoot design, it shouldn’t cause any problem.

BTW, commons-logging has already been excluded from most transitive dependencies in spring-cloud-netflix...

Thanks for the spring boot lesson!

Sorry, but you surprised me with your question... Anyway, that "lesson" could be useful for others reading the post ;-)

Closed via https://github.com/spring-cloud/spring-cloud-netflix/commit/c93a80f550a2f630c655d58509dc7faeb1e7b3b0


[MM-47326]: Contribute - WYSIWYG editor

Summary
This will add the WYSIWYG editor to the webapp.
For now this is behind a feature flag and a setting in the advanced section since the editor as it is now is pretty much in an alpha state. In an effort to keep working on this in smaller iterations to be more effective the team decided we can release this as is for now and deal with any bugs as we go on.
to enable it you have to set the feature flag: MM_FEATUREFLAGS_WYSIWYGEDITOR=true, then the setting in the advanced settings will appear and you can use it in the create post section
Ticket Link
EPIC: MM-47326
Related Pull Requests

Has server changes: https://github.com/mattermost/mattermost-server/pull/22020

This is a re-opened PR from #11186
Release Note
Adds the alpha state of the WYSIWYG editor to the create post section behind feature flag and advanced setting

Looks like you fixed most of the issues @michelengelen.
A couple more things:

For the enter icon, can we adjust the alignment a bit and add a few px of space between the icon and the word ENTER?

Also on smaller screens, we're not collapsing any formatting buttons by the looks of it like we do with the current advanced text editor. Things seem to be bleeding out of the container. Is this something you'll work on in a separate PR?

@matthewbirtch same procedure as last time:

1. For the enter icon, can we adjust the alignment a bit and add a few px of space between the icon and the word ENTER?

Fixed!

2. Also on smaller screens, we're not collapsing any formatting buttons by the looks of it like we do with the current advanced text editor. Things seem to be bleeding out of the container. Is this something you'll work on in a separate PR?

This is a bit hard to do without excessive calculations. I would like to try and find the best solution possible. I will take this on in the second iteration (same as the hidden formatting bar feature)
On a side note:

I fixed the ArrowDown behavior in code blocks. Still missing the ArrowUp behavior though, which is a lot harder to do
I fixed the emoji sizing in the editor ... should now be the same as in posts (except for emoji posts)

@michelengelen really great work, inot sure how many of these have already been found but here's a few things I noticed:

When selecting a code block, it defaults to CSS (can we default to no specific language selected but still have the dropdown available for a language selection (may need a placeholder text?)?

The language selector might be broken:

Message priority button doesn't seem to be working

When tables are used, can we allow rows & columns in the table, followed by the delete key to delete the selected row/column? I had a hard time figuring out how to remove a column.

With tables, can we allow ctrl + A or a dragging across the table to select it for deletion. I found it a little finicky to figure out to properly select the table so it could be deleted

I think this was discussed already, but it would be really excellent if the table pop-over could be shown in context with the table when a selection is made in the table.

After using the link button and entering a link, can we move the cursor to after the word (see google docs)

Any change we can implement this improvement along with the new editor? ;) https://mattermost.atlassian.net/browse/MM-48061

@esethna Comments between the lines.

1. When selecting a code block, it defaults to CSS (can we default to no specific language selected but still have the dropdown available for a language selection (may need a placeholder text?)?

FIXED

2. Language selector should validate languages: https://gyazo.com/c04d68ef2a983a44e39ae1a3c92e9796

FIXED

3. The language selector needs to be allowed to span outside the input area:

FIXED

4. Message priority button doesn't seem to be working

FIXED

5. When tables are used, can we allow rows & columns in the table, followed by the delete key to delete the selected row/column? I had a hard time figuring out how to remove a column.

The whole table feature is still just very basic and the proposed changes are particularly hard to implement. For this we would need to render the whole structure differently. We want to provide a similar experience as with the editor in JIRA/Confluence, but as this is such a big task I would like to push this to a later iteration.

6. With tables, can we allow ctrl + A or a dragging across the table to select it for deletion. I found it a little finicky to figure out to properly select the table so it could be deleted

see comment on point 5.

7. I think this was discussed already, but it would be really excellent if the table pop-over could be shown in context with the table when a selection is made in the table.

see comment on point 5.

8. After using the link button and entering a link, can we move the cursor to after the word (see google docs)

FIXED

9. Any chance we can implement this improvement along with the new editor? ;) https://mattermost.atlassian.net/browse/MM-48061

This is also very hard to do since the trigger functionality has no way of knowing the current state of the editor(s) which would be needed for it. There are a few ways of doing this, but it is definitely out of scope for this PR
Let me know what you think

Seems like there might be something wrong with the menu for code block language selection. The height is very short and can't see any items within it:

@matthewbirtch this should be fixed by now ... the test server did not update and that's why it is currently broken

@matthewbirtch @esethna the test server is updated with the newest commit

Thanks @michelengelen
Seeing few issues

Attachments remain in textbox after posting

Emoji picker is displaying off screen in Safari. Hidden when RHS is open

Safari: Cursor missing when options other than Normal Text are toggled

Existing posts appear to shift down when typing or deleting text

Code language selector is too tall, top items are out of view

When pasting code block, it is not recognized and formatted ( this may be done later). I'm unable to get out of code formatting and add normal text after pasting something similar to screenshot, can't start a new line

Horizontal cursor when table is present

Table input cursor jumps from top cells to bottom right when user stops typing

https://user-images.githubusercontent.com/52937121/213007669-079157b5-c833-4469-a93f-4e9978f3d700.mov

Unable to turn linking off e.g. add link and hit enter, add space and try to toggle link off to add more text
Safari: Unable to add link, hitting Enter while on the link popover doesn't do anything
There is slight downward shift to main channel posts (existing) when opening post priority menu. I have seen something similar with some other actions/posts. Maybe the same as issue 4.

https://user-images.githubusercontent.com/52937121/213014071-91864432-7c19-49d3-b404-0a858e08e950.mov

Hi @jgilliam17 ... thanks for going over this. Comments between the lines as usual:

1. Attachments remain in textbox after posting

FIXED

2. Emoji picker is displaying off screen in Safari. Hidden when RHS is open

FIXED

3. Safari: Cursor missing when options other than Normal Text are toggled

not sure what is causing this ... did not manage to fix for this iteration. @jgilliam17 could you open a ticket in the epic and assign this to me so I can work on this in the second iteration? Thanks!

4. Existing posts appear to shift down when typing or deleting text

FIXED

5. Code language selector is too tall, top items are out of view

FIXED (applied the Suggestion lists max-height value here - @matthewbirtch is that OK for you?)

6. When pasting code block, it is not recognized and formatted ( this may be done later). I'm unable to get out of code formatting and add normal text after pasting something similar to screenshot, can't start a new line

formatting pasted text (at least the more complex stuff) will be handled in one of the next iterations.

7. Horizontal cursor when table is present

This is the gapcursor and allows for easy deletion of the table when hitting Backspace

8. Table input cursor jumps from top cells to bottom right when user stops typing

I could not reproduce this (tested in FF, FF Dev Edition, Chrome and Safari)

9. Unable to turn linking off e.g. add link and hit enter, add space and try to toggle link off to add more text

You can exit the link with the Right-Arrow. This is the default behavior and since chars like dots and commas are valid chars for a link it is hard to determine when we want to exit the link state. For spaces: This is valid for text that has a link applied, so when you have a pure URL like http://www.mattermost.com it can be exited with a space.

10. Safari: Unable to add link, hitting Enter while on the link popover doesn't do anything

FIXED

11. There is slight downward shift to main channel posts (existing) when opening post priority menu. I have seen something similar with some other actions/posts. Maybe the same as issue 4.

FIXED (same issue as no.4)

Edited: 12. Console error and banner. I am not 100% sure of the steps, but I think I had some text highlighted or pasted, follow by selecting to add table (happened on Desktop daily build)

Could not reproduce ... If you can reproduce and know the steps please open up a ticket.
Thanks for the review... Ready for another round! 🚀

5. Code language selector is too tall, top items are out of view

FIXED (applied the Suggestion lists max-height value here - @matthewbirtch is that OK for you?)

Yep, this is good now

7. Horizontal cursor when table is present

This is the gapcursor and allows for easy deletion of the table when hitting Backspace

@michelengelen I don't know if this is a common behavior - it was unexpected for me as well. I would have expected it just to be a normal text cursor on a new line (like we do for code blocks)

Horizontal cursor when table is present

This is the gapcursor and allows for easy deletion of the table when hitting Backspace

@michelengelen I don't know if this is a common behavior - it was unexpected for me as well. I would have expected it just to be a normal text cursor on a new line (like we do for code blocks)

I have seen this in a few other wysiwyg editors. I will Check if a normal caret is possible as well. This is the standard behavior for the package we are using.

Thanks @michelengelen for the quick fix
Looks good, for alpha release to community
Noticed one small issue with Upload limit error, missing red font color on main channel, not reproducing on RHS.

@jgilliam17 I fixed the error text color and added the [user] is typing... element as well.
@matthewbirtch the gapcursor is currently needed since when removing it from the extensions we cannot exit a table anymore when there is no text around it. I will leave it in for now, so we can see if this is acceptable in daily usage, or find another solution.
Thanks for your reviews!
Now its time for the devs to rip apart my code! 🤔
@mickmister @koox00 @AshishDhama and @Willyfrog: There are a few functions inside the advanced_create_post.tsx file that I have recreated to fit with the new data-flow. some just extract the message value from the event, where others are getting the string from the wysiwyg and need to loop that through (similar to the "old" implementations).
HAVE FUN!!!

added the [user] is typing... element as well.

The user is typing element is too small, but I believe that was going to be fixed in another PR since we identified that elsewhere, right?

@michelengelen  additional note on [user] is typing... element is not visible for me on main channel. It is visible on RHS

@michelengele multiple checks failing, could please update the pr

@jgilliam17 strange ... its the same component ... could you try retesting it?

@jgilliam17 strange ... its the same component ... could you try retesting it?

I checked today again and still miss the user typing on main channel

@hmhealey I have fixed the tests, removed the packages causing the problems, added a custom parser logic and included some tests for it as well. I did remove the Kaomoji-Stuff from this PR as well and will add a new PR in the following days!
@AshishDhama @mickmister @Willyfrog and @koox00 all tests are green now, so feel free to start reviewing
@jgilliam17 I will fix that [user] is typing ... issue next week.
Thanks all! :shipit:

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


Student UI: Print improvements

[ ] Remove current day styling from print views
[x] Remove scroll bar?
[ ] Investigate: Can the events be made smaller or use X events more... in month view
[ ] Can we match the title font family to Myriad Pro

?

Assigning to @Coenego

Assigning to @bp323 for review

Issue remaining: Week, month and day view all have issues with the height of the calendar container.

Back to @Coenego for followup

Coverage remained the same at 100.0% when pulling 73329573ca75462988ee84508f0dc642c267edea on Coenego:issue-320-print into 82236fb1ec14073f305914baf2d8206c27ad49e4 on CUL-DigitalServices:master.

This causes an issue in the 'My agenda' view where content is pushed down the page quite a bit.

I assume this was good to go then? I couldn't reproduce the issue when printing the calendar.. ( @bp323 )

Coverage remained the same at 100.0% when pulling cbba5e6d5523834b9409aec9543789fe2340b3a4 on Coenego:issue-320-print into 8d1c14634e962119c0bd9aeb5b45b11e424c0915 on CUL-DigitalServices:master.

I'm still seeing these calendar issues, I think it has to do with resolution but I have it in latest Chrome in pretty much any resolution.

I'd like to get this fixed as it's a step back from what it was before.

Coverage remained the same at 100.0% when pulling e02905b424e1d0f73653914a846c565898a29b80 on Coenego:issue-320-print into 8957a06374854ac57e3fa9a0d767151b92f0b39a on CUL-DigitalServices:master.

Followed up and merged into master


cant edit name with URI scheme

when i send a file with URI scheme i cant edit name and information file why???

Files uploaded by URL are fetched once and cached for some time. They must be the same for anyone using the URL. Hence, the files must have automatically deduced type, filename and other metadata.


fix url for csv-operator

hi!I just fix a invalid url for CSV description.

can you please merge all your documentation related fixes into a single PR? Thanks!

:+1:  and if you sign your commits with -s our DCO check is also happy.

@wyyxd2017 if you don't sign your commits, we can't merge them. Do you have the chance to do so?


Feature/lol/only allow tifs

Connects #186
Connects #187
This provides mimetype checking for uploaded images and hardens the worker pipeline against failing because of bad data.
Much of the worker code has been refactored in an effort to make this more stable.
To test

Start worker
Go through normal site checks with varying images including some that will fail.

Check that worker does not crash.
Upload a PNG file and ensure it is marked as invalid with appropriate error message.

Rebased in the thumbnail generation work from @lewfish

+1


May I ask about the computing sources required?

Hi, thanks for sharing your work.
May I ask how many GPUs (or the memory) it takes to train the baseline and how long the training procedure lasts for each category of tasks?

Hi suoych,
I have replied to your email. As I mentioned in the paper, I trained the model with 8 DDP A5000 GPUs and run ~2 hours each. I used batch size 16 since I found small batch sizes might cause errors.

Hi suoych,
I have replied to your email. As I mentioned in the paper, I trained the model with 8 DDP A5000 GPUs and run ~2 hours each. I used batch size 16 since I found small batch sizes might cause errors.

Thanks!


[WIP] Upgrades the TensorFlow backend to TF2.0

This is the feature branch for the new TF2.0 backend. All PRs on the new backend should be made to this holding branch.

@josh146 could you fix the conflicts? I think Travis might be on hold because of that

@thisac regarding the empty args/kwargs, I did not remove them to avoid breaking users' code. For instance, if users had kwargs which are now unnecessary they won't have to go change their function calls.

I noticed one test function names was duplicated, so perhaps one of the tests is actually not being tested

Fixed! Not sure how pytest decides, but the second test with the same name (the more advanced one) was being executed, and the simple test was being skipped!

Also, the examples/quantum_neural_network.py still seems to be using tf.Session. Should/will this be updated?

Yes, that should be updated

Also, the examples/quantum_neural_network.py still seems to be using tf.Session. Should/will this be updated?

Yes, that should be updated

Done, updated file is here: https://github.com/XanaduAI/strawberryfields/blob/tf2/examples/quantum_neural_network.py
Thanks for catching that @thisac!
I have also gone through and replaced all remaining occurrences of 'Tensorflow' with 'TensorFlow'.


Objective Sharpie `error: invalid SDK 'iphoneos-18.0'

Hi,
I cloned this repo and ran dotnet build in maui.nativelibraryinterop/template/macios/NewBinding.MaciOS.Binding to generate the API defs (as described in Rachel Kang's excellent tutorial here: https://devblogs.microsoft.com/dotnet/native-library-interop-dotnet-maui/)
I see the following error:
.nuget/packages/communitytoolkit.maui.nativelibraryinterop.buildtasks/0.0.1-pre1/tools/Common.macios.targets(168,5): error SHRP0000: error: invalid SDK 'iphoneos18.0'

Also sharpie xcode -sdks returns nothing. [My xcode is in an external HDD, and xcode-select -p returns the correct location]
Not sure what the problem is. Is iOS18.0 too new?
[sharpie update throws an error too.]

I symlinked ln -s /Applications/Xcode.app/ and still it doesn't work.
On a different machine with Xcode with SDK ios17.5 sharpie xcode -sdks works / builds the API defs.
Will there be a newer Objective Sharpie released? (Guessing it's not working with 18.0?)

Thank you. sharpie xcode -x works :)
However, I tried it with the net8.0 (Which doesn't work with XCode 16) and net9.0 (your latest in-progress PR).
Your PR net9.0 requires manual sharpie bind for which I couldn't find the right command line parameters to work with the template.
Do you have a full example for invoking sharpie bind?
I tried the following:
native/NewBinding > sharpie bind -x /blah/ -sdk iphoneos18.0 -o ../../NewBinding.MaciOS.Binding -scope ./NewBinding/ ./NewBinding/NewBinding.h   -c -Ibuild/Release-iphoneos/NewBinding.framework/Headers/

and the result is this:

Binding...
  [write] ApiDefinitions.cs

Binding Analysis:
  Automated binding is complete, but there are a few APIs which have been flagged with [Verify] attributes. While the entire binding should be audited for best API design practices, look more closely at APIs with the following Verify attribute hints:
... (lots of boiler plate text)

Done.

The final ApiDefinitions.cs has
using Foundation;

[Static]
[Verify (ConstantsInterfaceAssociation)]
partial interface Constants
{
	// extern double NewBindingVersionNumber;
	[Field ("NewBindingVersionNumber", "__Internal")]
	double NewBindingVersionNumber { get; }

	// extern const unsigned char[] NewBindingVersionString;
	[Field ("NewBindingVersionString", "__Internal")]
	byte[] NewBindingVersionString { get; }
}

which is not the API but ...  something  else?
I wonder if the net9.0 version can be made to use sharpie automatically just like the net8.0 (with maybe the -x option in the csproj perhaps?). If not, docs for the manual step will be super helpful. (the sharpie docs/interop docs are barely sufficient/usable).

Let me summarize the question:
For the dotnet9 PR, what's the sharpie command to regenerate the template API cs file from swift/objc?
@pjcollins  / @rachelkang FYI
Thank you!

For the dotnet9 PR, what's the sharpie command to regenerate the template API cs file from swift/objc?

For .NET 9 and Xcode 16.0, the sharpie command you'd run against the template should look something like this (from the template folder);
template % sharpie bind --output=sharpie-out --namespace=NewBindingMaciOS --sdk=iphoneos18.0 --scope=macios/NewBinding.MaciOS.Binding/bin/Debug/net9.0-ios/NewBinding.MaciOS.Binding.resources/NewBindingiOS.xcframework/ios-arm64/NewBinding.framework/Headers macios/NewBinding.MaciOS.Binding/bin/Debug/net9.0-ios/NewBinding.MaciOS.Binding.resources/NewBindingiOS.xcframework/ios-arm64/NewBinding.framework/Headers/NewBinding-Swift.h

Which should produce an updated sharpie-out/ApiDefinitions.cs file.

Thank you @pjcollins ! Your command seems to work (I will spend a bit more time as the headers are out of date from a stale Debug build - I will report back soon).
Your doc update looks good (I checked/verified iOS only, not Android). Not sure if anyone uses Xcode from an external HDD - if so your pro tip of sharipe bind -x /path/to/Xcode.app might be relevant to add in your .md update.

Thanks! I'll mark this as resolved, let us know if you run into any other issues here.


str read in as bytes in h5py 3.0.0

Hi,
I'm not sure if this is the right place to raise this issue; I've noticed some read/write discrepencies with the .obs and .var slots when h5py==3.0.0 is used.
Strings and indices within the data frames are returned as byte string rather than character (Unicode) string. This seems to work fine with h5py==2.10.0.
Package versions:
scanpy==1.6.0 anndata==0.7.4 umap==0.4.6 numpy==1.19.2 scipy==1.5.2 pandas==1.1.4 scikit-learn==0.23.2 statsmodels==0.12.0 python-igraph==0.8.3 leidenalg==0.8.2

I can confirm this behavior, and yes it is very annoying.

I've looked into this, and am a bit closer to a fix.
Basically, h5py>3 will now read any variable length strings in as bytes objects. You can instead read the objects as string by calling dataset.asstr()[:]. We can use some information stored in the dtype to know whether the strings were written as bytes or str objects, so we use that to tell if we want to call the asstr method. Strangely, this would all be done on the h5py side in previous versions, but that behaviour has been removed  ¯_(ツ)_/¯.
I haven't figured out how we can read structured arrays (like the output of rank_genes_groups) back in with the correct dtype. I'm following up with this here: https://github.com/h5py/h5py/issues/1751.

I got the same annoying error and also solved it by downgrading h5py to 2.10.0.
This error is so annoying @.@, and I spent several hours before I found the solution here. Thanks!

I also got this frustrating error. The error is so frustrating because you do not land on this page while searching for this error for many days.
scanpy h5ad file read byte error b''
Solved by updating anndata
pip install anndata==0.7.5

I also got this frustrating error. The error is so frustrating because you do not land on this page while searching for this error for many days.
scanpy h5ad file read byte error b''
Solved by updating anndata
pip install anndata==0.7.5

Upgrading to anndata=0.7.5 alone didn't work, but that + downgrading to h5py=2.10.0 did. Thanks!

I have just experienced this error using h5py==3.3.0; anndata==0.7.4.
Downgrading to h5py==2.10.0 resolved the issue.
It seems like this bug for me affected the reading of the file rather than the writing. When I loaded an .h5ad which I had previously saved v3.3.0, it now worked fine.

I have just experienced this error using h5py==3.3.0; anndata==0.7.4.
Downgrading to h5py==2.10.0 resolved the issue.
It seems like this bug for me affected the reading of the file rather than the writing. When I loaded an .h5ad which I had previously saved from v3.3.0, it now worked fine. (n.b. I am using this via scanpy)

Hi, I experienced the same issue in #1480. Tried downgrading h5py to 2.10.0 but the issue persists, and it's not compatible with the latest scanpy.
package versions:
anndata                   0.8.0
h5py                      3.8.0
scanpy                    1.9.3
scmer                     0.1.1

my error message:
>>> adata = scanpy.read_h5ad("data/abseq/outputs/abseq.h5Seurat")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/rsrch4/home/bcb/ywang74/condaenv/scmer/lib/python3.7/site-packages/anndata/_io/h5ad.py", line 254, in read_h5ad
    return AnnData(**d)
TypeError: __init__() got an unexpected keyword argument 'active.ident'

data:
<EMAIL_ADDRESS> [1] "0"  "1"  "2"  "3"  "4"  "5"  "6"  "7"  "8"  "9"  "10" "11" "12" "13" "14"
Could you help me with the issue? Thank you!

AnnData 0.8 is 2 versions behind, try a newer version.


[Payment history] make ProcessStripeWebhook.cpp create expenses when refunding a customer

Complete this part of the design doc: Expense and receipt creation for refunds.

Spent a lot of time on this today. I got confused because the test I wrote seemed to pass without my fix, so I doubted whether my original hypothesis that the stripe webhooks weren't queueing the billing receipt notification, and ended up going through a lot of pain to actually test that hypothesis. I did do it though and confirmed that successfully calling that hook to refund an actual purchase in the db does NOT queue a billing receipt notification and therefore does NOT create an expense.
Figured out what I was doing wrong and got a good test written, getting PR up soon.

Have PR up for both web and auth, but the Auth PR actually isn't ready yet. See this comment for details.

New web PR and updated Auth PR, getting it out for review today.

merged and deployed


No Database Icon

There doesn't appear to be a database icon in the set, and it seems like there probably should

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


i18n missing for digest and missed message email templates

During tests with our evaluation system, I got an email with a missed message reminder. The system texts were English phrases, while system and user preferences were set to German. Looking around I found 7 files under /home/zulip/deployments/current/templates/zerver/emails that, as far as I understand, lack internationalization support:
digest.source.html
digest.subject.txt
digest.txt
missed_message.source.html
missed_message.subject.txt
missed_message.txt
realm_reactivation.subject.txt

@idandr thanks for the report!  We had been waiting to do this for the missed_message emails until a recent redesign of them (that deleted most of the text), but we should do make sure we have full i18n tags on them now; they used to have a bunch of spurious text in them that we've since removed.
@hackerkid can you take this issue?

@zulipbot claim

@hackerkid can I take this up or is it wrapped up?

@vaibhavrajsingh2001 Feel free to take.

@zulipbot claim


[Bug] setExtraLibs does not work for globals in javascript mode

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.46.0-dev-20231214#XQAAAAKTAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzrB9RgmSaumWUF-TBOs7rE9XbZp0QEljbc6k5igJtayNyZFpJFm_mM5nJyGtaYVSA8LYfNAiH0H_SKfgOTkv8DlUboExY7GbKPnbhroY0B24jmS2R92JnItIzQGMHZXUjqq2hvRdCNtfoSooq76YgWgU381BhoMHe_tSoK2stAoyBGGGs841oh94ws9qhUvlnfPqRBj0LWu3ww-xZFSq3-X32-aYE6JaXdqOxkbXJc8xhxp32Zw9fTR5S_h0LAYlicKOopRGu9sTsR9_OkBwEjpxHxubth1Dhe2QmdfyP6LMT3m25ylnESchgP6jfFJ0Qq0yyW5wSTELD7CvokVqGtzM_9kU5SQ
Monaco Editor Playground Code
const value = `a`;

monaco.languages.typescript.typescriptDefaults.setExtraLibs(
[
{content:'declare var a : { b: "aa", c: {d:"e"}} ', filePath:''}
]);

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "javascript",
	automaticLayout: true,
});

Reproduction Steps
Try the playground, you get no completition for the object 'a'
switch to typescript, and the completition works
Actual (Problematic) Behavior
No codecompletition for global objects in javascript mode
Expected Behavior
code completition should work
Additional Context
No response

A short googling gave me monaco.languages.typescript.javascriptDefaults.setExtraLibs()
But I have never used monaco myself...

thanks, didn't find this....

Could you edit your comment in typescript repo so this issue over there is not derailed? Thanks.


Getting deckmaster running under Wine?

Hey There -
This may or may not be something that can be done, but I was wondering if you could give me some insight as to the Windows dependencies of the addon that I might be able to install to get the app to run properly under Wine on Ubuntu. Been running / streaming MTGA from Linux without issue, but would like to get this addon working under it as well if possible.
It seems to load up fine, but the UI doesn't populate:

If have ideas that would be great, either way, thanks for reading!

Hey @JeffHoogland I'm a viewer/subscriber on your stream (RootSamurai), and also a developer.  I took a look into this and it looks like the main problem is that Chrome/Chromium-based things currently don't run well on Wine.  If you take a look at https://appdb.winehq.org/objectManager.php?sClass=category&iId=33&sAction=view&sTitle=Browse+Applications, Chrome along with everything Chromium-based are all listed as Garbage or Bronze status.  All the entries I looked at indicated pages don't render.  This project is using electron, which is effectively an embedded Chromium browser with nodejs, so I think you're running into the same Chromium support issues with Wine.
That said, I think there might be a way to get you up and running with your Linux rig.  It seems Deckmaster at it's core just tails/follows the Arena log files.  It might be possible to run the eletron-based UI directly on Linux and point it at the Arena log files in your wine prefix (~/.wine/drive_c/).  Then the electron process would be running directly on Linux, which handles Chrome/Chromium just fine.

Yeah - in theory the code here should build + run cross platform from my understanding of what Electron is doing. I just don't have the experience to get it to build correctly on Ubuntu 18.04. Simply following the build directions after installing the dependencies hit some errors for me after I pointed it to the correct location of my output log file.
If my time permits I might also take a look at seeing how it sends information to Twitch. Odds are I could probably write a similar tool in Python that scraps the log and sends up the information it needs to populate the UI.

@JeffHoogland I've forked and pushed a build-on-linux branch here.  You should only need nodejs and yarn installed on your Linux box in order to build.  I built with node version 10.12.0 and yarn version 1.10.1, but other versions should be fine, too.
Just run the updated build.sh script, set the ARENA_LOG_PATH environment variable to point to the output_log.txt from your wine install, and run the deckmaster binary from the dist directory.
Feel free to review the commits.  I had to disable the Sentry release plugin, drop a bogus reference to a static directory, and drop the auto-updater check since this repo has no linux builds pushed.  Nothing too crazy, but those were some small adaptations required to get it to run without throwing exceptions.
CC @Fugiman on the Sentry release plugin and static directory reference -- having the webpacker config wired to notify Sentry means other contributors can't build without having Sentry configured locally...might make sense to use their CLI command instead and wire that up to a release script or something instead.  And the static directory reference seems like some outdated/unused reference for production builds?

Builds, launches, and detects as expected!
https://cdn.discordapp.com/attachments/200494040502894595/504762734898970644/unknown.png
I'll try it on a live stream tomorrow afternoon to confirm it sends the info to Twitch correctly.
Will the path to my output file be baked into this app image directly, or will I need to make sure to set it in my terminal before running the app image?

@JeffHoogland Glad it works!  You'll need to set the ARENA_LOG_PATH in your terminal before launching each time (or create a wrapper script/shortcut or similar that sets it before launching).  I could make it configurable via the UI and persist the path, but I figured it would make sense to get something working first and see if @Fugiman chimes in with any thoughts on how best to handle going forward.  Ideally we could agree on some changes that don't affect the windows builds but make it flexible enough to use like you're using, too.

Makes sense - I'll confirm it sends to twitch tomorrow.
Other apps that work off the log file auto detect it (which works for most installs) and then also leave the option to manually point to it in a settings panel. Something like that might work well here as well so it leaves people who have stock setups alone, but lets others like mine work as expected.

Yep, that's probably the best way forward

Just wanted to confirm that this works as expected running from Linux.

Awesome!
@Fugiman I realize you probably aren't planning to release linux builds, but are you open to accepting some PRs that would at least make it easier for @JeffHoogland and others to build and run on Linux/Mac themselves, assuming the changes don't impact the existing Windows support?
I think the main things would be:

Detect the presence of the output_log.txt file and add a UI element that allows the user to select the path to the file if it can't be auto-detected.  Technically this might even help some Windows users if they use non-standard paths.
Update the build scripts/config to support running on Linux/Mac and running on a fresh clone of the repo without Sentry or anything else configured.

I'd be happy to make these changes and submit as PRs, but want to check if you'd accept them before I invest the time.

@Fugiman - also adding support for any/all PRs to include MTGA streamers via Wine installation.


fix: improve return types for Collection first, firstWhere, last

[x] Added or updated tests
[ ] Documented user facing changes
[ ] Updated CHANGELOG.md

Improves #1010
Changes
Adds return types for callable $default parameters in first() and last() methods:
User::all()->first(default: fn () => false); // User|bool
User::all()->last(default: fn () => false); // User|bool

Adds firstWhere to the collection stubs:
User::all()->firstWhere('blocked'); // User|null
User::all()->firstWhere('blocked', true); // User|null
User::all()->firstWhere('blocked', '=', true); // User|null

Breaking changes
None.

@canvural All the stuff around collections, is already on the core. Meaning that, for Laravel 9, none of this is needed on Larastan.

The reason I submitted this PR is because I can't wait until Laravel 9, and it's really annoying to work with PHPStan on level 9.

Thank you!

@nunomaduro It seems like this PR's types are more advanced than Laravel's core. Here the default type is TDefault|callable(): TDefault and in the core is just TDefault.

That goes like
https://github.com/laravel/framework/blob/78637dcc784e8c85e08490d47098cd7531dcaa81/src/Illuminate/Collections/Arr.php#L201
then
https://github.com/laravel/framework/blob/78637dcc784e8c85e08490d47098cd7531dcaa81/src/Illuminate/Collections/helpers.php#L182-L186
where the closures get executed.

@MatanYadaev Can you pull request your "proposal" to Laravel 9?

@nunomaduro Sure: https://github.com/laravel/framework/pull/39805


fix(class occlusion): multi class of one point

Description

Enable assigning multiple class to one point, in order to be consistent with the training settings.

The value of each class is set as pow(2, class_index), e.g.  {"CAR": 1, "BICYCLE": 2, "PEDESTRIAN": 4}
The "CLASS" field of a point is the sum of all the classes, e.g. if the projected point is inside the "CAR" roi and "PEDESTRIAN" roi at the same time, its "CLASS" is 5.
The "CLASS“ value is decoded by voxel_generator into one-hot code, e.g 00000101, where each bit represents a class.

Related links
https://tier4.atlassian.net/wiki/spaces/CT/pages/2851864699/SP+2023-08-08+PointPainting+Sync
Tests performed
rosbag:https://drive.google.com/drive/folders/161wVB87jIu2E9CC9hRmaKwAAWjaDney_

The brightest points are assigned as pedestrian and car at the same time.
Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukke42 can I ask for a review?


cloning private repositories

Hi,
Should I be able to clone private repositories with:
git clone orgname/reponame

Because when I try that atm I am getting the following error:
Cloning into 'reponame'...
fatal: remote error:
  Repository not found.

I can successfully use features like git pull-request
These are the versions I use (hub is installed via brew):
$ git version                                                         [ruby-1.9.3-p194]
> git version 1.7.9
> hub version 1.10.1

If I try this command git clone -p orgname/reponame , the output is unknown switch 'p'.
I'm new in githup , the repository is private and the URL is correct

@Masar92 This issue tracker is for a specific project called hub, not for git and GitHub in general. Many people alias hub as git, and thus get extra features when they perform commands like git clone. However, if you never installed hub, then you can still clone private repositories normally like so:
# using HTTPS:
git clone https://github.com/orgname/reponame.git

# using SSH:
git clone git@github.com:orgname/reponame.git


New DrupalConsole installer instructions.

@geerlingguy: Since latest changes on the site and the project the instructions for setting up Drupal Console, have changed I just copied instructions on the home page at http://www.drupalconsole.com :
# Run this in your terminal to get the latest Console version:
curl http://drupalconsole.com/installer -L -o drupal.phar

# Or if you don't have curl:
php -r "readfile('http://drupalconsole.com/installer');" > drupal.phar

# Accessing from anywhere on your system:
mv drupal.phar /usr/local/bin/drupal

# Copy configuration files to user home directory:
drupal init [--override]

Not entirely comfortable with fetching an executable over http

Since we  move the site to a PassS, we are in the process to implement https, I will keep you updated.

@oxyc ++ - Since console is now configurable, until it's https, you can exclude it from the list of installed_extras if you'd like until you're in a trustedlocation/network.

You can manually curl the latest version from the project releases page at: https://github.com/hechoendrupal/DrupalConsole/releases
NOTE: This is what we do on the installer URL, grab the drupal.phar from github .

And IIRC (don't have time to verify right now), I have the geerlingguy.drupal-console role set to do it this way, instead of grabbing the installer direct from the DC website, for that very reason. But might need to make some changes there too, we'll see.

On Dec 7, 2015, at 1:25 PM, Jesus Manuel Olivas<EMAIL_ADDRESS>wrote:
You can manually curl the latest version from the project releases page at: https://github.com/hechoendrupal/DrupalConsole/releases
NOTE: This is what we do on the installer URL, grab the drupal.phar from github .
—
Reply to this email directly or view it on GitHub.

This will need to be fixed in the geerlingguy.drupal-console role.

Merged https://github.com/geerlingguy/ansible-role-drupal-console/pull/5 to fix this.

This has been fixed upstream. Please make sure you run sudo ansible-galaxy install -r provisioning/requirements.yml --force to get the latest version of the role.

@oxyc @geerlingguy: We enabled SSL on the site. new installer instructions using https:
# Run this in your terminal to get the latest project version:
curl https://drupalconsole.com/installer -L -o drupal.phar

@jmolivas - Thanks for the quick turnaround! Updated the role in the above issue.

This still appears to be broken for me, I am getting the following error
TASK: [geerlingguy.drupal-console | Run Drupal Console init.] *****************
<<IP_ADDRESS>> REMOTE_MODULE command php /usr/local/bin/drupal init creates=~/.console #USE_SHELL
failed: [drupaldev] => {"changed": true, "cmd": "php /usr/local/bin/drupal init", "delta": "0:00:00.187567", "end": "2015-12-16 18:12:03.547324", "rc": 255, "start": "2015-12-16 18:12:03.359757", "warnings": []}
stderr: Failed loading opcache.so:  opcache.so: cannot open shared object file: No such file or directory
PHP Parse error:  syntax error, unexpected '==' (T_IS_EQUAL), expecting ')' in phar:///usr/local/bin/drupal/src/Command/Theme/UninstallCommand.php on line 48

using the debian box

@elju Which version of DC is causing this issue?. We fixed Drupal-VM, issues on latest release and must be working now.

@elju I'm guessing something is broken with your PHP installation... if you log into the VM and do anything else (e.g. php -i), does that work?

@geerlingguy php -i seems to be working fine. @jmolivas this was downloaded today via curl https://drupalconsole.com/installer , unsure of how to check the version number, but it seems like that should be the newest version.

@elju:  Just by running any of drupal --version or just drupal

drupal --version

Drupal Console version 0.9.10

drupal

drupal

Drupal Console (0.9.10) | Supports Drupal 8.0.1
===============================================

Copy configuration files to user home directory.

   drupal init [--override]

Download, install and serve Drupal 8

   drupal chain --file=~/.console/chain/quick-start.yml

Create a new Drupal project

   drupal site:new drupal8.dev 8.0.1

Install a Drupal project

   drupal site:install

Lists all available commands

   drupal list

Update project to the latest version.
-------------------------------------

   drupal self-update

@jmolivas both of those commands are just throwing the same error, but I'm 99% sure this is the newest version:
vagrant@dev/usr/local/bin >: drupal
PHP Parse error:  syntax error, unexpected '==' (T_IS_EQUAL), expecting ')' in phar:///usr/local/bin/drupal/src/Command/Theme/UninstallCommand.php on line 48
vagrant@dev/usr/local/bin >: drupal --version
PHP Parse error:  syntax error, unexpected '==' (T_IS_EQUAL), expecting ')' in phar:///usr/local/bin/drupal/src/Command/Theme/UninstallCommand.php on line 48

@elju: I will take a look at the code and ping you back.

Thanks! My php version is PHP 5.4.45-0+deb7u2 and the box that I'm on Debian wheezy if that's helpful

yeah, I can reproduce this from scratch with
vagrant init puphpet/debian75-x64
vagrant ssh
sudo apt-get update
sudo apt-get install php5-cli curl
sudo curl https://drupalconsole.com/installer -L -o /usr/local/bin/drupal
sudo chmod +x /usr/local/bin/drupal
drupal --version
PHP Parse error:  syntax error, unexpected '==' (T_IS_EQUAL), expecting ')' in phar:///usr/local/bin/drupal/src/Command/Theme/UninstallCommand.php on line 48

Should I move this over to an issue on drupal-console?

Yes, I'd move this to drupal-console project. I don't even know if PHP 5.4 is supported... I thought Console required 5.5+.

Drupal Console requires "php": ">=5.5.9",
https://github.com/hechoendrupal/DrupalConsole/blob/master/composer.json#L39
Same as Drupal 8
https://github.com/drupal/drupal/blob/8.0.x/core/composer.json#L7

Oh, this is failing because the php role using apt-get, but on debian wheezy, apt-get only installs 5.4. Works fine on newer versions. Sorry for wasting your time.

@elju I glad to read it works ;)

@jmolivas
This year vlad with drupalconsole has stopped working because of drupalconsole stopped being a standalone.
According to article https://drupalconsole.com/articles/drupalconsole-launcher-a-stand-alone-full-cli-application is back being a standalone.
Current vlad snapshot still is unable to install drupalconsole. Any thoughts?

@chriscalip is a stand alone CLI but provide a limited number of commands you still need to install per-site more info about it at the docs => https://docs.drupalconsole.com/en/getting/project.html

how do I test vlad @chriscalip ?

@jmolivas Ahh. I thought since you were in this thread I assumed that you are familiar with vlad use.
https://vlad-docs.readthedocs.io/en/latest/usage/installation/
After installation and vagrant ssh.
`
✝ vagrant@d8vlad ✝ /var/www/site/docroot
$ drupal
[ERROR] Drupal Console is not installed at:
You must execute the following composer commands:
composer require drupal/console:~1.0 --prefer-dist --optimize-autoloader
composer update drupal/console --with-dependencies
✝ vagrant@d8vlad ✝ /var/www/site/docroot
$
`

@chriscalip fyi this is the Drupal VM issue queue :)

@oxyc @jmolivas  Right, I am sorry this issue was in the vlad issue queue; and this is a drupal-vm issue.


Release new KG that uses human UniProt identifiers for nodes instead of species non-specific Protein Ontology identifiers

The aim of this proposal is to improve integration of the Text Mining Provider's KGs with the rest of the Translator ecosystem for reasons described in https://github.com/NCATSTranslator/Text-Mining-Provider-Roadmap/issues/81. We note that this is not an ideal solution as the gene/protein mentions that have been identified in text are not necessarily human, however for the near term this appears to be an acceptable solution as discussed during the mini-hackathon on 6/17, and noted in https://github.com/NCATSTranslator/minihackathons/issues/14.

Open question regarding protein/gene conflation: Should this KG also include HGNC identifiers so that genes can be linked in the text-mined assertions as well? Or should there be a separate KG that uses HGNC identifiers for its nodes?


chore: delete Init.Quot

@Parcly-Taxel Thanks! Since these are really quite low-level, could you please add
@[deprecated Quot.recOnSubsingleton (since := "2024-08-26"]
alias Quot.recOnSubsingleton' := Quot.recOnSubsingleton

somewhere?


Added call to pam_acct_mgmt to query PAM for expired passwords

To implement locking of accounts with expired passwords and refuse login to any such accounts, I added this code.
Please review my changes, I would be pleased to have them merged.

Hi, thanks for the PR, do you have any test output from testing this change?

Hello,
what kind of output are you looking for? Unfortunately, I could not get the TACACS to report the cause back to the connecting device, so the output was the same as if you enter the wrong password:
Using username "tst.boettger".
Access is restricted to authorized users only.
Disconnect IMMEDIATELY if you are not an authorized user!
Access denied
Using keyboard-interactive authentication.
Password:
Access denied
Using keyboard-interactive authentication.
Password:
The Daemon in debug mode gave the following output:
[root@xalhtlvap01 tacacs+-FB<IP_ADDRESS>.1]# ./tac_plus -C /etc/tac_plus.conf -L -p 49 -d32 -g
Reading config
Version F<IP_ADDRESS>-fb Initialized 1
tac_plus server F<IP_ADDRESS>-fb starting
socket FD 4 AF 2
socket FD 5 AF 10
uid=0 euid=0 gid=0 egid=0 s=38121984
connect from <IP_ADDRESS> [<IP_ADDRESS>]
connect from <IP_ADDRESS> [<IP_ADDRESS>]
pam_verify tst.boettger
pam_tacacs received 1 pam_messages
<IP_ADDRESS> tty707: PAM_PROMPT_ECHO_OFF
pam_tacacs received 1 pam_messages
<IP_ADDRESS> tty707: Your account has expired; please contact your system administrator
pam_acct_mgmt returns PAM_AUTHTOK_EXPIRED
login query for 'tst.boettger' tty707 from <IP_ADDRESS> rejected
login failure: user=tst.boettger device=<IP_ADDRESS> port=<IP_ADDRESS> client=tty707
connect from <IP_ADDRESS> [<IP_ADDRESS>]
pam_verify tst.boettger
pam_tacacs received 1 pam_messages
<IP_ADDRESS> tty707: PAM_PROMPT_ECHO_OFF
The password aging information was as follows:
[root@xalhtlvap01 ~]# chage -l tst.boettger
Last password change                                    : Jan 23, 2017
Password expires                                        : Jan 24, 2017
Password inactive                                       : Jan 25, 2017
Account expires                                         : never
Minimum number of days between password change          : 0
Maximum number of days between password change          : 1
Number of days of warning before password expires       : 1

Thanks for contributing.

Yeah - thanks for the PR mate!


7549 schema

Adds the two types of attestations (Phase0 and Electra)

the old ssz Attestation class becomes an interface. We then have AttestationPhase0 and AttestationElectra
AggregateAndProof schema (and it's signed version) remain untouched (dynamically constructed)
on the creation side, I opted with a Supplier<committeeBits> because:

we don't need to care about the current fork, no spaghetti
if using Optional<committeeBits>, in DataStructureUtil it would have changed all the random object generation that would have required an update to an enormous number of json files and hardcoded stuff.

beacon block bodies updated consequently.
since max attester slashing has been lowered to 1 in Electra, we can't always pick the Genesis schema in BlockProposalTestUtil

Note
There is an open question about OpenAPI schema, related to the additional committee_bits that now shows up. See https://github.com/ethereum/beacon-APIs/issues/445
fixes #8130
Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

def refTestVersion = 'v1.5.0-alpha.1'


fix:  wrong file in testdata

fixes #4
I noticed that checksum of testdata/issue368.parquet was different meaning
we were working with the wrong file.
There is no need for further investigation on why we end up with a different
file.
While on this I discovered another issue that has been around for a while which was affecting the same test, so it is fair to include that fix in this PR ( details on the commits)

So FWIW I think I modified this yesterday by opening the file in vim which would have appended a newline to the file. You might want to check and see if reverting the change I made yesterday fixes the checksum.

So FWIW I think I modified this yesterday by opening the file in vim which would have appended a newline to the file. You might want to check and see if reverting the change I made yesterday fixes the checksum.

Indeed, but this TestOpenFile is flakey, the commit that properly resets the  reused format.PageHeader stabilise it.
What do you think if we just leave the checksum fix and the  reset of format.PageHeader as is  and chalk it up as fixing/stabilising  TestOpenFile  I can update the title to something like stabilise TestOpenFile
I was hard to bisect  when TestOpenFile was this volatile.
I'm happy to hunt down and revert change you think might be the culprit,  what do you think?

Whatever you think is best is fine with me, don't do extra work on my behalf, let's just get this fixed

Cool, I'm merging this for now. I really need to check on our workflow file. It makes me unease to tiptoe around new go features with the fear of breaking old go versions support in our runner matrix

@gernest Whoops - there's one more change. TestIssue368 should also be marked unskipped.

nice catch! I'm on it.


Updated spanish translations

Updated spanish translations
Changes 👷♀

most of the strings in public/locales/es/common.json are translated to spanish

How to test 🧪

step 1 ...

Definition of done ✔

[ ] Acceptance criteria for each issue met
[ ] Unit tests written where needed and passing
[ ] End-to-end tests for happy path
[ ] Documentation updated
[ ] Project builds without errors
[ ] Non-functional requirements met
[ ] Code reviewed and functionality tested by the reviewer (locally, Heroku, etc.)
[ ] Feature verified and accepted by Product Owner
[ ] Project deployed to production environment

Corregidas las dos strings.


try to list quotas of a tenant

Hi @abellotti,
I tried to list quotas of a tenant in the API. This is the diff I came up with. Far from perfect (and not mergeable as is of course) but maybe you have some guidelines to let me go further.
What I did not succeed :

having the route like /tenants/1/quotas instead of /tenants/1/tenant_quotas
populating one tenant to list its quotas

Thanks !

If it's just to list them, then you can query the virtual attribute via GET /api/tenants/:id?attributes=tenant_quotas
But for the purpose of adding/editing/removing quotas for a tenant, approach you have here is the right direction, exposing as formal subcollection /api/tenants/:id/quotas with subcollection actions add, edit and delete. Look at tags/policies for assign/unassign for subcollection action implementations.
Thanks for enhancing the API !!

Thanks a lot for the input ! Definitely a great help.
I will try to go as far as adding/editing/deleting a tenant quota.
Talk to you soon :)

Hi, is it possible to review my pull request ?
I've completed Romaintb's work for managing quotas on the API.
Hope you like it.
Thank in advance !
ps: I can't run Rubocop on local because I get a lot of errors and failures, do you have an idea how to fix it?

Thank you, I'll look at the changes.
regarding rubocop, are you running it with the yml from https://raw.githubusercontent.com/ManageIQ/manageiq/master/.rubocop.yml ?

Yes I run rubocop with .rubocop.yml
Look at my errors https://gist.github.com/alex-lairan/ab9df56eb15b03185827 (13 197 long lines)
I think he doesn't read it.

after rebasing on master, the branch does not build anymore, we will have a look assap

ok, the fact that we added a validation on unicity of a quota for a tenant showed a bug in an other quota related test : https://github.com/ManageIQ/manageiq/blob/master/spec/models/miq_report_spec.rb#L549 we declare variables that use @tenant before we actually declare @tenant, so the current tenant is always null.

managed to fix this one. I had to fix a few things in the report spec. Hope it is okay, let me know :)

@imtayadeway @gtanzillo please review, Thanks.

all good for me, please review :)

Is there something left to fix for this to be merged @abellotti @imtayadeway ?
Thanks

LGTM !!

@romaintb LGTM - can you unwip it? Thanks for all your work on this! :heart:

(removed wip from title, can't edit tags though)

@romaintb - you can tell the bot to:
@miq-bot rm-label wip

@imtayadeway thanks for the tip :)
thank you guys for your help on this one, and thanks @alex-lairan for his work too


Result file order in GUI batch-analysis

This fixes the order of the result files in the combined selection table when running from the GUI.

Implemented in #473


What is the token or user?

On startup, you will supply the token for your bot account (created here). Then, you will supply your user ID in discord to force yourself to have 100% of commands regardless of server. Currently the bot itself is broken and will not log in, I will need to rework that and expect that with a week or two.

oh okay. Let me know when its up. Thank you!!

Is the bot up and running?

Not as of yet, I had finals this week so I haven't had the time. I'll take a look at it right now and see what I can do!

Thanks! You're the best!

Hi, I have gone and updated the bot. If you need help setting up the bot, check out the wiki!

okay thank you