Disable Ingress for kiali

Fixes https://github.com/istio/istio/issues/26038

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
@howardjohn just a heads up. Clearly, operators are creating grief for some people, especially for simple demo applications like what we are doing here in the samples/addons stuff. So, most likely within the next 24 to 48 hours (once I get buy-in from the Kiali team that the additional maintenance burden this will create is acceptable), I'm going to propose we change the gen.sh to use the new-new Kiali Server Helm chart that we just merged (only a SNAPSHOT is published so far - we may be releasing an official release in a day or two). See: https://github.com/kiali/kiali-operator/pull/105
I will try to get this in quick so 1.7 can use it.

@jmazzitelli thanks! I think that will be really useful for the demo stuff!

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test release-notes_istio

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
12d559260a746b4005173e70d2425e807c16fdea
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Fix small remaining bug

Sorry I was a bit sloppy with my PR yesterday

No worries. And thanks for catching my slop ;)


Upgrade to React 0.14

I got two warnings after migrating to<EMAIL_ADDRESS>Warning: React.findDOMNode is deprecated. Please use ReactDOM.findDOMNode from require('react-dom') instead.

From this line.
Warning: `div` was passed a style object that has previously been mutated. Mutating `style` is deprecated. Consider cloning it beforehand.
Check the `render` of `NotificationItem`.

Previous style: {position: "relative", width: "100%", cursor: "pointer", borderRadius: "2px", fontSize: "13px", border: "1px solid", borderTopWidth: "4px", margin: "10px 0 0", padding: "10px", display: "block", WebkitBoxSizing: "border-box", MozBoxSizing: "border-box", boxSizing: "border-box", WebkitBoxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", MozBoxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", boxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", opacity: 0, transition: "0.3s ease-in-out", isHidden: {opacity: 0}, isVisible: {opacity: 0.9}, borderColor: "#edbfbf", borderTopColor: "#ec3d3d", backgroundColor: "#f4e9e9", color: "#412f2f", right: -200}.

Mutated style: {position: "relative", width: "100%", cursor: "pointer", borderRadius: "2px", fontSize: "13px", border: "1px solid", borderTopWidth: "4px", margin: "10px 0 0", padding: "10px", display: "block", WebkitBoxSizing: "border-box", MozBoxSizing: "border-box", boxSizing: "border-box", WebkitBoxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", MozBoxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", boxShadow: "0px 0px 5px 2px rgba(0,0,0,0.1)", opacity: 0.9, transition: "0.3s ease-in-out", isHidden: {opacity: 0}, isVisible: {opacity: 0.9}, borderColor: "#edbfbf", borderTopColor: "#ec3d3d", backgroundColor: "#f4e9e9", color: "#412f2f", right: 0, height: 63}.

I'm not sure but I think it is thrown because this._styles is mutated between renders.

Thanks @kimmobrunfeldt. I tested it here and it works - React team said that they will support React.render and other methods that were moved to ReactDOM until 0.15.0 - but I got a lot of errors/warnings. I'll fix them on the next release.

Please use 0.1.16 for React 0.14.

Woah that was fast. :) Thanks a ton!


Requests to external page trrigers an error?

Some how calling a URL to an external resource inside my view triggers the following exception:
$ DJANGO_SETTINGS_MODULE=sharescreening.settings.devlocal coverage run manage.py test --failfast -v 2
Creating test database for alias 'default' ('/home/oznt/Software/screenshares/sharescreening/../sharescreening/test-db.sqlite3')...
Destroying old test database 'default'...
Operations to perform:
  Synchronize unmigrated apps: staticfiles, messages, select_multiple_field
  Apply all migrations: admin, contenttypes, sharescreening, auth, sessions
Synchronizing apps without migrations:
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states... DONE
  Applying contenttypes.0001_initial... OK
  Applying auth.0001_initial... OK
  Applying admin.0001_initial... OK
  Applying contenttypes.0002_remove_content_type_name... OK
  ... snipped ...
  Applying sharescreening.0023_searchfilterpreview_lang... OK
test_1_create_bookmarks (sharescreening.tests.TestBookmarks) ... ERROR

======================================================================
ERROR: test_1_create_bookmarks (sharescreening.tests.TestBookmarks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "sharescreening/tests.py", line 282, in setUp
    self._login('normaluser', 'secretz').follow()
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/response.py", line 102, in follow
    return self._follow(**kw)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/response.py", line 90, in _follow
    return self.test_app.get(abslocation, **kw)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_webtest/__init__.py", line 111, in get
    url, params, headers, extra_environ, status, expect_errors, **kwargs)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/app.py", line 323, in get
    expect_errors=expect_errors)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_webtest/__init__.py", line 74, in do_request
    response = super(DjangoTestApp, self).do_request(req, status, expect_errors)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/app.py", line 606, in do_request
    res = req.get_response(app, catch_exc_info=True)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webob/request.py", line 1295, in send
    application, catch_exc_info=True)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webob/request.py", line 1263, in call_application
    app_iter = application(self.environ, start_response)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/lint.py", line 198, in lint_app
    iterator = application(environ, start_response_wrapper)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/contrib/staticfiles/handlers.py", line 63, in __call__
    return self.application(environ, start_response)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in __call__
    response = self.get_response(request)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response
    response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 164, in get_response
    response = response.render()
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/response.py", line 158, in render
    self.content = self.rendered_content
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/response.py", line 135, in rendered_content
    content = template.render(context, self._request)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/backends/django.py", line 74, in render
    return self.template.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 210, in render
    return self._render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/test/utils.py", line 96, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 135, in render
    return compiled_parent._render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/test/utils.py", line 96, in instrumented_test_render
    return self.nodelist.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 65, in render
    result = block.nodelist.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
    bit = self.render_node(node, context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
    return node.render(context)
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/defaulttags.py", line 161, in render
    values = list(values)
  File "sharescreening/views_utils.py", line 22, in _replace_broken_link
    if check_broken_link(document.get('picture', '')):
  File "sharescreening/utils.py", line 58, in check_broken_link
    h.request('HEAD', parsed.path)
  File "/usr/lib/python2.7/httplib.py", line 979, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 1013, in _send_request
    self.endheaders(body)
  File "/usr/lib/python2.7/httplib.py", line 975, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 835, in _send_output
    self.send(msg)
  File "/usr/lib/python2.7/httplib.py", line 801, in send
    if self.debuglevel > 0:
  File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_coverage_plugin/plugin.py", line 170, in line_number_range
    assert frame.f_code.co_name == 'render'
AssertionError

----------------------------------------------------------------------
Ran 1 test in 0.308s

FAILED (errors=1)
Destroying test database for alias 'default' ('/home/oznt/Software/screenshares/sharescreening/../sharescreening/test-db.sqlite3')...

This does not happened with simple testing:
$ DJANGO_SETTINGS_MODULE=sharescreening.settings.devlocal manage.py test --failfast -v 2
Creating test database for alias 'default' ('/home/oznt/Software/screenshares/sharescreening/../sharescreening/test-db.sqlite3')...
Destroying old test database 'default'...
Operations to perform:
  Synchronize unmigrated apps: staticfiles, messages, select_multiple_field
  Apply all migrations: admin, contenttypes, sharescreening, auth, sessions
Synchronizing apps without migrations:
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states... DONE
  Applying contenttypes.0001_initial... OK
... snipped ...
  Applying sharescreening.0019_auto_20160415_1303... OK
  Applying sharescreening.0020_auto_20160419_1525... OK
  Applying sharescreening.0021_auto_20160419_1600... OK
  Applying sharescreening.0022_auto_20160420_1425... OK
  Applying sharescreening.0023_searchfilterpreview_lang... OK
test_1_create_bookmarks (sharescreening.tests.TestBookmarks) ... ok
test_2_bookmark_list (sharescreening.tests.TestBookmarks) ... ok

Can you tell what is going on here?

That is odd, maybe it's even a problem with coverage pluing? I change the setUp and removed follow()
and  now the test passes. Still I wonder why this happens.

Can you provide instructions so that I can reproduce this error?  Does it happen reliably? There's another report of the same assertion, but it is intermittent.

Hi Ned,
Thanks for the quick reply. Try including the following method in one of your views, and give it a URL:
def check_broken_link(link):
    """:return: True if link is broken"""
    if not link:
        pass

    else:
        url = img_url(link)
        parsed = urlparse.urlparse(url)
        h = httplib.HTTPConnection(parsed.netloc)
        h.request('HEAD', parsed.path)
        response = h.getresponse()
        if response.status == 200:
            return False
    return True

I haven't tried your suggestion yet.  But if you have a complete project I could try, with tests, configuration, etc, that would be much better.

Unfortunately, it's a commercial non open source code. I could try and reap off the essential parts and make an example project. However, I might be able to get to it next week only.

Hi Ned,
OK, I can tell you definitely that the error happens every time I run the test suite with the django-template-coverage.
I also tried creating a new simple project with similar templates and url structure. But I could not recreate the error on a simpler project with the above. Also, if I changed the code of the above posted function to:
import requests
def check_broken_link(link):
    """:return: True if link is broken"""
    try:
        if not link:
            pass

        else:
            url = img_url(link)
            parsed = urlparse.urlparse(url)
            res = requests.get(url)
            if res.status_code == 200:
                return False
        return True
    except AssertionError as E:
        print url
        return True

Now, I am seeing another error:
$ DJANGO_SETTINGS_MODULE=sharescreening.settings.devlocal coverage run manage.py test --failfast -v 2
Creating test database for alias 'default' ('/home/oznt/Software/screenshares/sharescreening/../sharescreening/test-db.sqlite3')...
Destroying old test database 'default'...
Operations to perform:
Synchronize unmigrated apps: staticfiles, messages, select_multiple_field
Apply all migrations: admin, contenttypes, sharescreening, auth, sessions
Synchronizing apps without migrations:
Creating tables...
Running deferred SQL...
Installing custom SQL...
Running migrations:
Rendering model states... DONE
Applying contenttypes.0001_initial... OK
Applying auth.0001_initial... OK
Applying admin.0001_initial... OK
Applying contenttypes.0002_remove_content_type_name... OK
Applying auth.0002_alter_permission_name_max_length... OK
Applying auth.0003_alter_user_email_max_length... OK
Applying auth.0004_alter_user_username_opts... OK
Applying auth.0005_alter_user_last_login_null... OK
Applying auth.0006_require_contenttypes_0002... OK
Applying sessions.0001_initial... OK
Applying sharescreening.0001_initial... OK
Applying sharescreening.0002_auto_20160314_1145... OK
Applying sharescreening.0003_auto_20160323_1151... OK
Applying sharescreening.0004_contentbookmark... OK
Applying sharescreening.0005_auto_20160331_1207... OK
Applying sharescreening.0006_auto_20160331_1237... OK
...
Applying sharescreening.0021_auto_20160419_1600... OK
Applying sharescreening.0022_auto_20160420_1425... OK
Applying sharescreening.0023_searchfilterpreview_lang... OK
test_1_create_bookmarks (sharescreening.tests.TestBookmarks) ... http://....url ...45947/46.jpg
ERROR
======================================================================
ERROR: test_1_create_bookmarks (sharescreening.tests.TestBookmarks)
Traceback (most recent call last):
File "/home/oznt/Software/screenshares/sharescreening/tests.py", line 317, in test_1_create_bookmarks
response = form.submit().follow()
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/response.py", line 102, in follow
return self._follow(**kw)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/response.py", line 90, in _follow
return self.test_app.get(abslocation, **kw)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_webtest/init.py", line 111, in get
url, params, headers, extra_environ, status, expect_errors, **kwargs)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/app.py", line 323, in get
expect_errors=expect_errors)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_webtest/init.py", line 74, in do_request
response = super(DjangoTestApp, self).do_request(req, status, expect_errors)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/app.py", line 606, in do_request
res = req.get_response(app, catch_exc_info=True)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webob/request.py", line 1295, in send
application, catch_exc_info=True)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webob/request.py", line 1263, in call_application
app_iter = application(self.environ, start_response)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/webtest/lint.py", line 198, in lint_app
iterator = application(environ, start_response_wrapper)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/contrib/staticfiles/handlers.py", line 63, in call
return self.application(environ, start_response)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in call
response = self.get_response(request)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response
response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 164, in get_response
response = response.render()
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/response.py", line 158, in render
self.content = self.rendered_content
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/response.py", line 135, in rendered_content
content = template.render(context, self._request)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/backends/django.py", line 74, in render
return self.template.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 210, in render
return self._render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/test/utils.py", line 96, in instrumented_test_render
return self.nodelist.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
bit = self.render_node(node, context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
return node.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 135, in render
return compiled_parent._render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/test/utils.py", line 96, in instrumented_test_render
return self.nodelist.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 905, in render
bit = self.render_node(node, context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/debug.py", line 79, in render_node
return node.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/loader_tags.py", line 65, in render
result = block.nodelist.render(context)
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django/template/base.py", line 908, in render
bits.append(force_text(bit))
File "/home/oznt/.virtualenvs/screenshares/local/lib/python2.7/site-packages/django_coverage_plugin/plugin.py", line 106, in line_number_range
source = render_self.source
AttributeError: 'DebugNodeList' object has no attribute 'source'

Ran 1 test in 0.938s
FAILED (errors=1)
Destroying test database for alias 'default' ('/home/oznt/Software/screenshares/sharescreening/../sharescreening/test-db.sqlite3')...
If I change `requests.get` to `requests.head` I am getting the old error.

This appears to be a duplicate of https://github.com/nedbat/django_coverage_plugin/issues/22


PersonAccount issues with listMetadata and deployment

I originally sent this to @ntotten, @clairebianchi, and @amphro directly and was asked to log it as an issue here:
I had the following issue filed against IC:
https://bitbucket.org/RoseSilverSoftware/illuminatedcloud/issues/1734
If you scan down you'll see that the issue is not actually with IC but rather with how certain PersonAccount metadata is returned by listMetadata. I've found the following known discrepancies, though it's very possible(/likely?) that there are others:

DuplicateRule

Account.Standard_Person_Account_Duplicate_Rule

Full name should be PersonAccount.Standard_Person_Account_Duplicate_Rule
Filename should be duplicateRules/PersonAccount.Standard_Person_Account_Duplicate_Rule.duplicateRule

MatchingRule

Account.Standard_PersonAccount_Match_Rule_v1_0

Full name should be PersonAccount.Standard_PersonAccount_Match_Rule_v1_0
Filename should be matchingRules/PersonAccount.matchingRule

RecordType

Account.PersonAccount

Full name should be PersonAccount.PersonAccount
Filename should be objects/PersonAccount.object

Also note that deployment of duplicate rules seems to be broken in the CLI. When I try to deploy any duplicate rule--not just this weird PersonAccount one but any duplicate rule--force:source:deploy completes as follows:
$ sfdx force:source:deploy -m DuplicateRule:Account.Standard_Account_Duplicate_Rule --json
{
  "status": 0,
  "result": {
    "deployedSource": []
  }
}

And trying to deploy the actual file fails with:
$ sfdx force:source:deploy -p force-app/main/default/duplicateRules/Account.Standard_Account_Duplicate_Rule.duplicateRule-meta.xml
ERROR running force:source:deploy:  The DuplicateRule named Account.Standard_Account_Duplicate_Rule was not found in the workspace.

So obviously there are two issues included here, the first with the information reported by listMetadata and the second with deployment of duplicate rule metadata. Feel free to clone/split as appropriate.

Hi @SCWells72 - the duplicate rules issue is known (#685 ) and the workaround is listed in that issue (add '# .forceignore v2' to your forceignore file).  That fix will be in either 50.6.0 or 50.7.0.
The other issue you mentioned with the listMetadata command is owned by another internal team so they would have to comment.

@SCWells72 I'm closing because I think #685 took care of this.  If the other listMetadata part is still bad, let us know.


[Bug] Non english scanlators are not shown

Device information

Tachiyomi version:  2.2.1
Android phone & version: Xiaomi Redmi 9 Android 10

Steps to reproduce

Have an MD account with other languages configured, in my case spain spanish and latam spanish
Same configuration on neko
Search for example manga

Expected behavior
Non-english scanlators chapters should appear
Actual behavior
They dont. In the given example Ravens scans chapters should be listed but only two other english chapters are shown.
Other details
If we open web view version from the manga page, chapters are listed as they should.

Do you have the other language enabled in the app?  under the mangadex settings?

It was already enabled. I cleared cookies and without me noticing neko started detecting all the other chapters, so its now solved. Thanks!


Dev Test: Bending Light 1.2.0-dev.2

Dev Test
Mentions: @KatieWoe @kathy-phet @arouinfar
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html

Test Matrix
Please include all (non-screen reader) feature testing in these records if applicable.

[x] Latest macOS, Safari (Time = 2) (Tester = NS)
[x] Latest iOS, Safari (Time = 2) (Tester = AM)
[x] Windows 10/11, Firefox (Time = 2) (Tester = MM)
[x] Windows 11, Chrome (Time = 2) (Tester = KW)
[x] Latest Chrome OS, Chrome (Time = 2) (Tester = NS)

Light testing, or optionally skip if time crunch:

[ ] Latest macOS, Chrome (Time = ) (Tester = )
[ ] Windows 10, Chrome (Time = ) (Tester = )

Features included

~[ ] PhET-iO~
[x] Dynamic Locale
~[ ] Alternative Input~
~[ ] UI Sound~
~[ ] Sonification~
~[ ] Description~
~[ ] Voicing~

Focus and Special Instructions

This is the initial dev test for https://github.com/phetsims/bending-light/issues/418 which adds the preferences dialog and dynamic string layout on language change. After this dev test, we will proceed into RC.1.  PhET brand only.
When issues are discovered, please compare to the published version 1.1 to see if it is also buggy there.
Please be aware of deferred issues or user suggestions which are not in scope for fixing in 1.2: https://github.com/phetsims/bending-light/issues/
The drag listeners for the prisms and laser and protractor have been rewritten, please test while zoomed in, with touch and mouse, and that things don't get lost when resizing the window.
Issues to Verify
These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

[ ] https://github.com/phetsims/bending-light/issues/424
[x] https://github.com/phetsims/bending-light/issues/423
[x] https://github.com/phetsims/bending-light/issues/358
[ ] Be aware of https://github.com/phetsims/bending-light/issues/410 which we would like to solve but is known to be buggy in this version.

For QA...

General features

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Try to include browser version numbers
If there is a console available, check for errors and include them in the Problem Description.
Run through the string tests on at least one platform, especially if it is about to go to rc.
Check the Game Up harness on one platform.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Calling QA

Thanks, I'll continue in the opened issues. Closing.


Stacks event provider

Collect callstacks in ICorProfiler and serialize them to event pipe. Based on https://github.com/dotnet/samples/tree/main/core/profiling.

Names and relationships for name data is cached in dictionaries.
The dictionaries are then serialized to event pipe. Formatting will be performed by dotnet-monitor itself. The name cache also provides an implementation for name formatting for diagnostic purposes.
EventPipe api is wrapped around a variadic template based class, to make data declaration and serialization easier.

TODO:
Event pipe model:

Need to map out remaining types, which are not used for the current data.
We don't have a way of modeling data with no payload.

Names and name caching:

Consider making each naming function append to a sstream and consider adding flags to disable certain parts of the name such as the module.
Currently using fixed max size names and fixed size generic parameters for name discovery. Consider dynamic allocation or TLS buffers to allow more flexibility.
Use a better hash combine algorithm

Stack walking:

According to docs, need to block ThreadDestroyed while stack walking. Is this still a requirement?

/backport to main


Handling of anonymous structs and nested structs in interface{} fields

Swgen now correctly handles anonymous structures and structures with interface{} fields, containing nested structs. Related internal improvements.

Coverage decreased (-0.08%) to 93.601% when pulling dbefe38ea461cb699fdd69fb9aab385be39013d1 on sb-lazada:proposed-changes into 10b849ce4bd998b87b813aa17b321e9e79d2129d on lazada:master.

Coverage decreased (-0.1%) to 93.585% when pulling 01b21fe020dfe78baf62ae6e381fb8b01b006024 on sb-lazada:proposed-changes into 10b849ce4bd998b87b813aa17b321e9e79d2129d on lazada:master.

I don't think it works correctly on master, either. Current result of your test on commit lazada/swgen@10b849ce4bd998b87b813aa17b321e9e79d2129d is:

  "paths": {
    "/V1/empty": {
      "post": {
        "tags": [
          "v1"
        ],
        "summary": "test empty struct",
        "description": "test empty struct",
        "responses": {
          "200": {
            "description": "request success",
            "schema": {
              "$ref": "#/definitions/testEmptyStruct"
            }
          }
        },
        "x-request-go-type": "github.com/sb-lazada/swgen.testEmptyStruct"
      }
    }
  },
  "definitions": {},

Is it possible to have a reference without corresponding item in "definitions"? Please provide an example of correct Swagger JSON that you expect to receive in this case.

Please check https://github.com/lazada/swgen/pull/18 for correct test case

Coverage decreased (-1.8%) to 91.933% when pulling f93bd6d7cc6e23de110d3c9238f340460d987c5d on sb-lazada:proposed-changes into d52236c62d5aee68d8c7a6cfd1ada3e87674cae6 on lazada:master.


Error: HttpError: Bad credentials

Getting an error of Error: HttpError: Bad credentials,
All the tests are run successfully, but I get an error when trying to publish the report. Is there anything wrong with my GitHub token, does it require any specific permission to publish the report?
Here is my runner file
pull-request-coverage.yml
name: Get Test Coverage
on:
  pull_request:
    branches:
      - main
jobs:
  coverage:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2

      - name: Install dependencies
        run: yarn install

      - name: Get Coverage
        uses<EMAIL_ADDRESS>        with:
          github-token: ${{ secrets.PERSONAL_GITHUB_TOKEN }}
          package-manager: yarn
          test-script: yarn test:ci
          threshold: 60

Runner failed

@kevalsavani,
Are you using this action in the private repo? If so, I think that your personal access token should also have permissions for that private repo. I recommend testing with GITHUB_TOKEN, it usually has all necessary privileges.

Hi, @ArtiomTr when I use GITHUB_TOKEN in that case it works fine but then I get an error when I publish my package with the npm publish command in GitHub actions, although I have provided FULL permission to PERSONAL_GITHUB_TOKEN token which I am using while publishing package :/

@kevalsavani,
Could you please attach full yml file with "publish" step? I think you can  use two different tokens - GITHUB_TOKEN for testing and PERSONAL_GITHUB_TOKEN for publishing.

@ArtiomTr here is the full yml file, also wanted to know that NODE_AUTH_TOKEN should be from Github or from npmjs it self I am confused here, thanks
name: Publish Node.js Package

on:
  release:
    types:
      - created

jobs:
  publish:
    runs-on: ubuntu-latest
    permissions:
      packages: write
      contents: read

    strategy:
      matrix:
        node-version: [14.x]

    steps:
      - uses: actions/checkout@v2

      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v2
        with:
          node-version: ${{ matrix.node-version }}
          registry-url: https://npm.pkg.github.com/

      - name: Install dependencies
        run: yarn install

      - name: Run tests
        run: yarn test:ci

      - name: Publish
        run: yarn publish
        env:
          NODE_AUTH_TOKEN: ${{ secrets.PERSONAL_GITHUB_TOKEN }}

@kevalsavani,
I see now, that you're using two different workflows - one for testing and one for publishing. So, because you have different workflows, you can use two different tokens - just pass GITHUB_TOKEN for jest-coverage-report-action, and use PERSONAL_GITHUB_TOKEN for your publishing workflow.
Regarding NODE_AUTH_TOKEN - this token should be from the registry, to which you're publishing. You've set up https://npm.pkg.github.com/. This means, that you will publish to the GitHub package registry, so the token should be from there.

Hi, @ArtiomTr yes, I was expecting the same thing, thank you for clarification 🎉, closing the issue 🎉


Add check for initialized items, fix #5

Add check mentioned in #5. Add simple test for use-case with scrollToIndex defined, which fails without fix.

Thanks a lot!
Sorry that I took so long to merge it (I actually missed the notification)


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit ed670c3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


UI: show file offsets and virtual address in verbose output

Display raw and virtual offsets in verbose mode.
This could help to match things up more quickly between FLOSS output, the file, and disassembler view.

Hey, I would like to work on this. Though can you specify more? as to what out is needed? Should there be more columns or should i just log them as info?

Hi! I imagined extra columns for this, correct.

Will something like this be ideal?

Yes, however, this doesn't apply so much to decoded strings vs. the language strings (Go and Rust).
If we had something for the language strings that would be amazing!

Would also be interesting to show (and order by) referenced from va or referenced from fva.


make it harder to have an inbox with a stale UID in it

note to check the ephemeral purger/conv loader for proper shutdown


Restore "old" follow logs (in a terminal)

Just a thought since there is a lot more power in using the cmd line for this action (even if it's just a kubectl command line - VSCode's integration made it easy to know what that cmd line is). Perhaps if the new web view is staying, maybe make the terminal method an option?

Semi-related: #593 (this is a note to myself, not a comment to you @coding2012 - thanks for the feedback!).

Fixed in master - next release will have this feature :)


Draft PR - create function for getting weather data

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

I have done the testing for the new functionality of getting weather data

updated the readme with the documentation for new API added to the wildfire application


Synapse Workspace Creation Error

Received following error message running setup.sh at revision 05d0a4e8563b92e15314f795d84af74a98c96b1b
--> Creating storage account containers: stage1, stage2, stage3, synapse
{
  "created": true
}
{
  "created": true
}
{
  "created": true
}
{
  "created": true
}
{
  "created": true
}
--> Creating Synapse Workspace: syn-oea-dmoea001
Command group 'synapse' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
ValidationFailed: Workspace request validation failed, check error details for more information
WARNING: Command group 'synapse' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
ERROR: (ResourceNotFound) The Resource 'Microsoft.Synapse/workspaces/syn-oea-dmoea001' under resource group 'rg-oea-dmoea001' was not found. For more details please goto https://aka.ms/ARMResourceNotFoundFix
argument --assignee: expected one argument

TRY THIS:
az role assignment create --assignee 00000000-0000-0000-0000-000000000000 --role "Storage Account Key Operator Service Role" --scope $id
Create a new role assignment for a user, group, or service principal. (autogenerated)

az role assignment create --assignee sp_name --role a_role
Create role assignment for an assignee.

az aks show --name MyManagedCluster --resource-group MyResourceGroup
Show the details for a managed Kubernetes cluster

https://docs.microsoft.com/en-US/cli/azure/role/assignment#az_role_assignment_create
Read more about the command in reference docs

Saw a comment from Paul DeSante on Teams chat that he might have run into the same thing. He said "I also needed to register the Microsoft.sql resource provider so that the Synapse workspace could be setup." I haven't checked to see if that addressed my actual issue.

This issue came up for me as well, along with provisioning for Spark. Both resolved with registering the provider in the subscription.

Same for me as well, having an issue during setup related to the Microsoft.Synapse resource being missing in the new resource group when it tries to create the firewall rule and spark pool.

Thanks everyone.
I've added info about this error to the wiki: Customer subscription xyz needs to be registered with Microsoft.Sql resource provider.


Wrong links in README for repo files

In the info section you link to files smallweb.txt etc.
The links are for editing those files, not viewing them. Clicking the link prompts to fork the repo.
What's currently linked
https://github.com/kagisearch/smallweb/edit/main/smallweb.txt
vs
What should be linked
https://github.com/kagisearch/smallweb/blob/main/smallweb.txt

Thanks fixed


NVM uses packages which failed checksum, with warning only. It should fail to install, instead.

Operating system and version:
Mac OS/X High Sierra

nvm debug output:

nvm --version: v0.33.11
$TERM_PROGRAM: Apple_Terminal
$SHELL: /bin/bash
$SHLVL: 1
$HOME: /Users/doug
$NVM_DIR: '$HOME/.nvm'
$PATH: $NVM_DIR/versions/node/v10.4.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin17)'
uname -a: 'Darwin 17.6.0 Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64'
OS version: Mac 10.13.5 17F77
curl: /usr/bin/curl, curl 7.54.0 (x86_64-apple-darwin17.0) libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
wget: /usr/local/bin/wget, GNU Wget 1.19.4 built on darwin17.3.0.
git: /usr/bin/git, git version 2.15.2 (Apple Git-101.1)
grep: /usr/bin/grep, grep (BSD grep) 2.5.1-FreeBSD
awk: /usr/bin/awk, awk version 20070501
sed: illegal option -- -
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: /usr/bin/sed,
cut: illegal option -- -
usage: cut -b list [-n] [file ...]
       cut -c list [file ...]
       cut -f list [-s] [-d delim] [file ...]
cut: /usr/bin/cut,
basename: illegal option -- -
usage: basename string [suffix]
       basename [-a] [-s suffix] string [...]
basename: /usr/bin/basename,
rm: illegal option -- -
usage: rm [-f | -i] [-dPRrvW] file ...
       unlink file
rm: /bin/rm,
mkdir: illegal option -- -
usage: mkdir [-pv] [-m mode] directory ...
mkdir: /bin/mkdir,
xargs: illegal option -- -
usage: xargs [-0opt] [-E eofstr] [-I replstr [-R replacements]] [-J replstr]
             [-L number] [-n number [-x]] [-P maxprocs] [-s size]
             [utility [argument ...]]
xargs: /usr/bin/xargs,
nvm current: v10.4.0
which node: $NVM_DIR/versions/node/v10.4.0/bin/node
which iojs:
which npm: $NVM_DIR/versions/node/v10.4.0/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v10.4.0
npm root -g: $NVM_DIR/versions/node/v10.4.0/lib/node_modules

nvm ls output:

         v8.2.1
         v8.9.3
->      v10.4.0
default -> 8.2.1 (-> v8.2.1)
node -> stable (-> v10.4.0) (default)
stable -> 10.4 (-> v10.4.0) (default)
iojs -> N/A (default)
lts/* -> lts/carbon (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.14.3 (-> N/A)
lts/carbon -> v8.11.3 (-> N/A)

How did you install nvm? (e.g. install script in readme, Homebrew):
From script on main site.

What steps did you perform?
I had v8.9.3 "used" and wanted to switch to an later version. I typed in nvm use v10.4.0. Nvm told me it was not installed so I ran the install command: nvm install v10.4.0.

What happened?
I had an outdated version of shasum sitting in my /usr/local/bin folder, which was giving me wrong checksums. When I attempted to install node, the checksum test failed, but it downloaded the package anyway, and installed it. Here is the output:

$ nvm install v10.4.0
Downloading and installing node v10.4.0...
Local cache found: $NVM_DIR/.cache/bin/node-v10.4.0-darwin-x64/node-v10.4.0-darwin-x64.tar.gz
Computing checksum with sha256sum
Checksums do not match: 'ae191912605f3ebc9d17ef58d1e6b976b1ce6e8d' found, '82b27983c990a6860e8d729e0b15acf9643ffca0eff282a926268849dfd2c3d2' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://nodejs.org/dist/v10.4.0/node-v10.4.0-darwin-x64.tar.gz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums do not match: 'ae191912605f3ebc9d17ef58d1e6b976b1ce6e8d' found, '82b27983c990a6860e8d729e0b15acf9643ffca0eff282a926268849dfd2c3d2' expected.
Now using node v10.4.0 (npm v6.1.0)

What did you expect to happen?
I expected nvm to fail the installation with an error, and refuse to use the version which failed the checksum.

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
No.

Thanks - this definitely seems like a bug in the fallback logic.

Just to add more clues--it's when had the brew package vim installed. It brings in perl as a dependency, and that package installs shasum in /usr/local/bin.
The interesting thing:
$ /usr/bin/shasum --version
5.84

whereas:
$ /usr/local/bin/shasum --version
6.01

Clearly, the package signing is happening with the builtin version of shasum, not the brew version.

Indeed, nvm is assuming the builtin version of shasum. However, I don't understand why any implementation of shasum would be using a different algorithm :-/

This puzzles me as well. Do you think it could have to do with a newline at the end of input?

I suppose that's possible - if the file has one, perhaps one of the versions trims it before summing - and if not, perhaps one of them appends it before summing.

Want me to leave this open? Is this still being investigated?

Yes, I'd prefer to leave it open indefinitely until we can fix it. Is it still happening for you?

I haven't experienced it in many months, but then again, I use the shasum util from Mac Brew.

I have resolved it using the following commands in macOS.
export NVM_DIR="$HOME/.nvm"  [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"
Restart your terminal.


[FEATURE] Penal Code Group Sorting

Describe the feature

Wondering if you can also add sorting to this page :)
Thank you!
Additional Context
No response

Yeah, this is definitely do-able!


Make a Hardhat version please

This is a suggestion, not an issue.
I believe it should be made with Hardhat instead of Truffle due to the industry moving more and more towards Hardhat.
That's all. Great job! :)

Thanks for your suggestion.
Please use our forum next time for this reason.
https://forum.moralis.io/t/ethereum-boilerplate-questions/3951/49

Hi @adriandelgg ! Thank you for your feedback!
We selected Truffle because it can save localchain data. So when you stop your devchain and run it again you will not loose your previous data. This is important because it makes easier syncing local devchain with Moralis Database.
Does the HardHat have such functionality?

Hi @adriandelgg ! Thank you for your feedback!
We selected Truffle because it can save localchain data. So when you stop your devchain and run it again you will not loose your previous data. This is important because it makes easier syncing local devchain with Moralis Database.
Does the HardHat have such functionality?

That's a good point. I'm not exactly sure, but I do know that Hardhat has a plugin to be able to use Ganache. It may allow to save the state, not entirely sure.
https://hardhat.org/plugins/nomiclabs-hardhat-ganache.html


Cannot build from demo scene

Unity 5.6.2f1, latest CardboardControls+ from GitHub.
I am doing the following:

Creating new project
Change  platform to Android
Import CardboardControls+ from package
(tried this with/without) Commenting out  based on alert to remove mentions of cardboard from Android Manifest
Enable virtual reality in player settings, add Cardboard to the list
Opening the demo scene
Build

Playing scene in Unity works, but building to Android always leads to instant force-close on phone. Can run GVR fine on phone.

That doesn't sound very fun! I'm on vacation right now but I want to check it out later. If you can package up your crashing project and share it then it'll be a lot easier to properly diagnose.

Thanks, that would be great! I've literally imported and packaged, then I zipped the project file if that's also helpful.
https://www.dropbox.com/s/6gf1whb4vbobsf5/CardboardControlsImported.zip?dl=0
https://www.dropbox.com/s/giag1m2sqs49hez/FinalCardboardControlsProject.zip?dl=0

@dotlaura Exactly what I needed, thanks :) I also forgot to ask: what phone model are you running it on that it crashes? The version of GVR that CC+ targets is kind of old now so that could be a piece of the puzzle. I'll be making some time this week to dive into it.

Okay, so first thanks for your patience. I found this in the logs:
E/AndroidRuntime(22144): FATAL EXCEPTION: main
E/AndroidRuntime(22144): Process: com.WSP.FinalCardboardControls, PID: 22144
E/AndroidRuntime(22144): java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.WSP.FinalCardboardControls/com.google.unity.GoogleUnityActivity}: java.lang.ClassNotFoundException: Didn't find class "com.google.unity.GoogleUnityActivity" on path: Dex
PathList[[zip file "/data/app/com.WSP.FinalCardboardControls-1/base.apk"],nativeLibraryDirectories=[/data/app/com.WSP.FinalCardboardControls-1/lib/arm, /vendor/lib, /system/lib]]
E/AndroidRuntime(22144):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2993)
E/AndroidRuntime(22144):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3248)
E/AndroidRuntime(22144):        at android.app.ActivityThread.access$1000(ActivityThread.java:197)
E/AndroidRuntime(22144):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1681)
E/AndroidRuntime(22144):        at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime(22144):        at android.os.Looper.loop(Looper.java:145)
E/AndroidRuntime(22144):        at android.app.ActivityThread.main(ActivityThread.java:6872)
E/AndroidRuntime(22144):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(22144):        at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime(22144):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
E/AndroidRuntime(22144):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)
E/AndroidRuntime(22144): Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.unity.GoogleUnityActivity" on path: DexPathList[[zip file "/data/app/com.WSP.FinalCardboardControls-1/base.apk"],nativeLibraryDirectories=[/data/app/com.WSP.FinalCardboard
Controls-1/lib/arm, /vendor/lib, /system/lib]]
E/AndroidRuntime(22144):        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
E/AndroidRuntime(22144):        at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
E/AndroidRuntime(22144):        at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
E/AndroidRuntime(22144):        at android.app.Instrumentation.newActivity(Instrumentation.java:1080)
E/AndroidRuntime(22144):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2983)
E/AndroidRuntime(22144):        ... 10 more
E/AndroidRuntime(22144):        Suppressed: java.lang.ClassNotFoundException: com.google.unity.GoogleUnityActivity
E/AndroidRuntime(22144):                at java.lang.Class.classForName(Native Method)
E/AndroidRuntime(22144):                at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
E/AndroidRuntime(22144):                at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
E/AndroidRuntime(22144):                at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
E/AndroidRuntime(22144):                ... 13 more
E/AndroidRuntime(22144):        Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available
W/ActivityManager( 1142):   Force finishing activity 1 com.WSP.FinalCardboardControls/com.google.unity.GoogleUnityActivity

It has something to do with the manifests in the Plugin directory: https://stackoverflow.com/questions/39655627/android-didnt-find-class-com-google-unity-googleunityactivity
I got it compiling by deleting the Plugins directory and replacing it with the one from the newest version of GVR from GitHub. However, the gaze was off by a lot. The color changing cube was on the right side of the screen before it started registering that it was in the middle of the screen. I'm not sure why suddenly it's not working when it did before so you could also try older builds of CC+.
Here's the project thus far, with ct2.apk as the compiled project that doesn't crash: https://www.dropbox.com/s/xberue7ag5eo22a/FinalCardboardControls redux.zip?dl=0
So that's not a very good answer but it's a start. I think the real solution is updating to support a newer version of GVR. GVR 1.5 changed a lot and we're up to 1.6 now so it'll take a while to see if I can get it working or fall back to 1.4 if I can't. I'm game to support you if you need it quickly and want to try the update yourself as well :)

Hello, thanks for this. I'm happy to keep playing around while it's being updated - I don't have a specific project and deadline at the moment for a cardboard app but I do want to learn CC+.
I'm using it on an LG G5 if that still helps- let me know if you want a tester!

Basically all that needs to be done is delete GoogleVR and Plugins directories, replace them with the newest stuff, and then fix all the numerous errors that will result. I'm probably going to just start at the release notes for v1.30 and make my way up to see all the things that changed because it's enough that guessing just led to more problems when I tried v1.5. Feel free to ask me any questions if you want to play around with it on your own. Not everyone is comfortable blasting questions on a public forum so you can can also reach me at the email in my profile. Either way I'll post here when I've made some progress.
Also, looking at the notes for 1.4 it seems that they have up/down/held for GvrController but I'm not sure what that means for Cardboard vs. Daydream and also it's still just a bunch of booleans instead of C# Delegates. Someone tell me if CC+ ever becomes obsolete so I'm not upgrading it for no reason :P

I got it working on GVR 1.60 and committed the code to master. It's all generally the same but I added a Player prefab and added some things to the existing manager prefab because Google made the system more complicated. I have to do some code cleanup before I push a new release out though.

That's great, thank you. Can confirm it's working well on my LG G5!
I'll definitely post if I have more questions.

Excellent! You're very welcome and thanks for taking the time to bring up the issue. Good luck in your GVR journey :)


Refactor CloudVolumeSnapshotController using mixins.

Delete cut-n-pasted stuff. Make use of the generic mixins.

@hayesr / @jzigmund please review/reference for the mixins refactoring project . . . ping me when this is ready to merge.  Thx, Dan


nested Objects/arrays

Given the following Openapi spec:
openapi: 3.0.1
x-zally-ignore:
  - 104
  - 105
  - 224
  - 151
info:
  x-audience: business-unit-internal
  x-api-id: 29021a8cd635
  title: Issue - Rest API
  version: 1.0.0
  contact:
    name: mocked
    url: 'http://www.mock.com/'
    email<EMAIL_ADDRESS>  description: |
    API specification for the mock service.
servers:
  - url: http://{server}/mock
    description: prefix of the server url
paths:
  '/basicroutes':
    get:
      operationId: gebasicroutes
      responses:
        '200':
          description: Success
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/CamelcaseAllowed'
    post:
      operationId: gebasicroutes
      responses:
        '200':
          description: Success
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/refarray'
components:
  schemas:
    CamelcaseAllowed:
      type: object
      properties:
        data:
          type: array
          items:
            type: object
            properties:
              id:
                type: string
                description: mock id
              unitSymbole:
                type: string
                description: Symoble of the unit
    refarray:
      type: object
      properties:
        data:
          type: array
          items:
            $ref: '#/components/schemas/issuefound'
    issuefound:
        type: object
        properties:
          id:
            type: string
            description: mock id
          unitsymbole:
            type: string
            description: Symoble of the unit

I get this violation when running the CLI:
HINT
====

HINT Avoid using x-zally-ignore extension.
        Ignores rules 104, 105, 224, 151
        https://github.com/zalando/zally/blob/master/server/rules.md#h002-avoid-using-x-zally-ignore-extension-
                x-zally-ignore (lines 2-7)+
====

Since bothe components are the same they should give the same linting error.
But "CamelcaseAllowed" passed by the linter, "issuefound" will trigger the snakcase rule.
I woud expect that in mutually cases the Violation triggert.
edit: fixed markdown

Not sure I quite understand the complaint...
Is it that CamelcaseAllowed, refarray, issuefound are not being validated against some naming policy? That would make sense as CaseCheckerRule.kt doesn't include a checkSchemaNames() - we should probably add it!


0.4.0 release

With #206 merged that is the last ticket in the 0.4.0 milestone
What needs done? @djmitche @savchenko

Probably a bit of manual testing to make sure everything works as expected
Publish on crates.io as per the RELEASING.md
...?

Manual testing sounds good.  I have WIP on #128 that should give a bit more confidence about that in the future.

How's this going?  I merged #128.

I've done a bit of playing with ta and not noticed anything (well nothing that wasn't already recorded in another issue somewhere!)

Huh, build is failing on cargo publish  Git bisect blames baa6b59e398311c11afc8a3f4b33b592c2047055.  I'm not sure what that's about!

cargo build works, but cargo build -p taskchampion does not.  What's up with that?

It seems like the serde macros aren't loading:
funk ~/p/taskchampion [main] $ cargo build -p taskchampion
   Compiling taskchampion v0.4.0 (/home/dustin/p/taskchampion/taskchampion)
error: cannot find derive macro `Serialize` in this scope
  --> taskchampion/src/server/local.rs:12:10
   |
12 | #[derive(Serialize, Deserialize, Debug)]

That was with rustc 1.55.  I reproduced on another host with rustc 1.54.

Well, I'm out of time to debug today.  @dbr have you seen anything like this?  Can you reproduce?

Ohh the problem is the combination of:

serde's derive macros are an optional feature
Cargo unifies features between all uses (so if some dependency is using features = ['derive'] you can, dangerously, omit it in the parent project)
kv has serde = ... features=['derive'], which the bisected commit removed
Something else in the overall workspace has the derive feature enabled, so the build works when everything was done in one (which is still a bit confusing)

In short means we should be specifing serde = { version = "^1.0.125", features = ["derive"] } and it should solve this

Oh! Nice find!  I'll tag and release a 0.4.1 with that fix in the (my) morning.

https://github.com/taskchampion/taskchampion/releases/tag/v0.4.1
https://docs.rs/taskchampion/0.4.1/taskchampion/


allowed prometheus to gather metrics

What type of PR is this?
/kind feature

What this PR does / why we need it
Allows prometheus to gather metrics
Which issue(s) this PR fixes

Fixes #45
Special notes for your reviewer
Does this PR introduce a user-facing change?

do we need to upgrade golang to 1.22? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_lws/68/pull-lws-test-integration-main/1772314340867706880

do we need to upgrade golang to 1.22? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_lws/68/pull-lws-test-integration-main/1772314340867706880

@ahg-g yep, Edwin will migrate the go version in the PR as well to fix the issue

probable sending a separate PR is better.

Yea, I just did this for jobset/kueue. Most likely you will need a test-infra PR first (as defaults seem to pull 1.21 right now).
And then I'd suggest verifying it on the presubmit.

/retest

@Edwinhr716 did you test it in practice?

Yes, I installed kube-prometheus in my cluster, and was able to query for the controller_runtime_reconcile_errors_total metric
$ curl 'http://localhost:9090/api/v1/query?query=controller_runtime_reconcile_errors_total'
{"status":"success","data":{"resultType":"vector","result":[{"metric":{"__name__":"controller_runtime_reconcile_errors_total","container":"kube-rbac-proxy","controller":"cert-rotator","endpoint":"https","instance":"<IP_ADDRESS>:8443","job":"lws-controller-manager-metrics-service","namespace":"lws-system","pod":"lws-controller-manager-66b9bbddcb-7n8xc","service":"lws-controller-manager-metrics-service"},"value":[1711470007.443,"0"]},{"metric":{"__name__":"controller_runtime_reconcile_errors_total","container":"kube-rbac-proxy","controller":"leaderworkerset","endpoint":"https","instance":"<IP_ADDRESS>:8443","job":"lws-controller-manager-metrics-service","namespace":"lws-system","pod":"lws-controller-manager-66b9bbddcb-7n8xc","service":"lws-controller-manager-metrics-service"},"value":[1711470007.443,"0"]},{"metric":{"__name__":"controller_runtime_reconcile_errors_total","container":"kube-rbac-proxy","controller":"pod","endpoint":"https","instance":"<IP_ADDRESS>:8443","job":"lws-controller-manager-metrics-service","namespace":"lws-system","pod":"lws-controller-manager-66b9bbddcb-7n8xc","service":"lws-controller-manager-metrics-service"},"value":[1711470007.443,"0"]}]}}

/lgtm
/approve


Adding in a message to make clear that 32-bit Python no longer works with RESQPY due to the HDF5 dependency.

Codecov Report

Merging #502 (f32522d) into master (d1056ff) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   79.11%   79.12%
=======================================
  Files         173      173
  Lines       28885    28885
=======================================
+ Hits        22853    22854    +1
+ Misses       6032     6031    -1

Impacted Files
Coverage Δ

resqpy/model/_xml.py
90.30% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1056ff...f32522d. Read the comment docs.


[Feature Request]: Profile picture customization.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
As of now the profile pic is displaying with it's full resolution which is the cause of the loading time of your server.
Also the profile pic is displaying in small width and height. so there is no need to display it in full resolution. So there is an need modification this image displaying format using Cloudinary SDK
Use Case
I want to customize the profile picture image displaying format using cloudinary Node.js SDK
That is reduce the loading time of the server along with the image clear visibility in small width and height.
Benefits
No response
Add ScreenShots

As you can see in small area the picture is note clearly visible because of pixel density ISSUE.
@Soujanya2004   Please assign me this ISSUE.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Soujanya2004
Because of high resolution image rendering it take way more time to load the server.  Assign it to me.


Shellbot cmd KO during Input/Menu acquisition

If shellbot command is executed during the Input or Menu machine acquisition included in Step and Sequence, the shellbot command is not recognized.
It's activate again when the sequences of the step are done.

Guillain, the behavior of shellbot has changed. This is because in direct channels there is no way to distinguish text that is sent explicitly to the bot from text that is the input itself. Now during the capture sequence, all text typed by the end user is considered as input. A consequence of this change is that you cannot submit a shell command while the bot is expecting some input. Are you with this approach?

This must be taken into account when we imagine and create the scenario. Thanks for the info


fix(ngResources): support IPv6 URLs

Do not confuse IPv6 URLs domains and resource parameters.
Closes #12512

What about the https? part of the RegExp ? Couldn't people be using other protocols ?
(I can't think of any good reason, but people do all sorts of stuff without a good reason :))
Should we add a breaking change notice (or avoid it altogether) ?

Other than that, it LGTM :+1:


Added min.js method

Make sure these boxes are checked before submitting this pull request~!~ Thank you!!

[x] The test of the method you have fixed is passing
[x - adding skeleton for isEven.js] You have written a new skeleton method for someone else to work on!

Hey @melissa3000 ! Thanks for the contribution. If you could please skim over the README in regards to contributing. We require all method fixes to include a new skeleton method + accompanying tests for someone else to work on. This is how we keep fresh issues in the project! Thanks

Resuming convo here: https://github.com/BlakeGuilloud/ganon/issues/97


Get all requested headers or a specific requested header

I would like to be able to just like the body be able to get requested headers in the response body.
For example:
request:
  method: GET
  path: /echo
response:
  statusCode: 200
  headers:
    Content-Type:
      - "application/json"
  body: >
    {
      "headers": "{{request.headers}}"
    }

Or to utilize specific headers:
request:
  method: GET
  path: /echo
response:
  statusCode: 200
  headers:
    Content-Type:
      - "application/json"
  body: >
    {
      "headers": "{{request.headers.User-Agent}}"
    }

This can be useful for various different testing purposes. My current use case is to check if a proxy adds/removes certain headers.

I don't really see the mainstream use case here. Sorry


onError callback

Hello,
I want to use this library in my React project, but I couldn't figure out how to catch an error when loading a document.
Does this library provide a callback that allows us to catch errors?

Hi @meseven !
Support for error handling has been added in version 1.5.0.
Specifically for React take a look at the error handling example, for which a demo is also available.

It's great! Thank you very much.
So with this update, can we run a callback function like below?
const { viewerRef, usePDFSlickStore, PDFSlickViewer, error } = usePDFSlick(
  pdfFilePath,
  {
    onError: (error) => {
      console.log(error);
    }
  }
);

No, with usePDFSlick hook you can use the returned error when loading a PDF document to detect and act upon errors.
If you want to use the onError callback consider using PDFSlick's core package — see the Svelte example for reference.

Thanks a lot @van100j.


more minor cleanup

[x] get rid of the func_sup_numpy stuff that remains in the fitter... it's better to just enforce everyone plays nice with numpy. makes the code much easier to read, and forces the programmer to vectorize.
[x] finally my vscode is once again pointing out unused imports, so it would make sense to go through the code and clean that up.

the block
    # Options for plotting files and functions.
    'xcol': None,        # Column for the xdata when plotting a file.
    'ycol': None,        # Column for the ydata when plotting a file.
    'yecol': None,       # Column for the errors in y-direction when plotting a file.
    'xecol': None,       # Column for the errors in x-direction when plotting a file.
    'style': "dots",     # Style when plotting a file.
    'npoints': 1000,     # Number of points for function plotting.

in the plotting library's default_params  probably shouldn't be there. especially the column stuff... you should specify that when you call the function that plots the data.

done


camera doesnot start for object recognition

hi i am using imageAI on google colab everything is working good but my camera doesnot starts for object recognition. Can anyone help regarding this issue?

Hello, you have to run the code on your computer to connect with your camera. Colab notebooks doesn't provide functionalities for you to connect with your system camera


Adds timestamps to Exported CSV

Overview

Adds support for adding timestamps to exported CSVs. The timestamps are found by transforming appropriate view names. Appropriate view name == views that correspond to the time quantum of the field.
Adds timestamps=ENABLE flag to /export endpoint. If ENABLE is true then the timestamps are included in the CSV. Otherwise they are excluded.
timestamps=false returns only the bits from viewStandard and timestamps=true returns only the bits from the appropriate time views. So, in order to get all bits, the user should call /export twice with timestamps=true (to get bits with timestamps) and timestamps=false (to get bits without timestamps).

Example:
$ curl localhost:10101/index/i1 -d ''
$ curl localhost:10101/index/i1/field/f1 -d '{"options":{"type":"time","timeQuantum":"YMDH"}}'
$ curl localhost:10101/index/i1/query -d 'Set(10, f1=1, 2019-04-01T12:34)'
$ curl localhost:10101/index/i1/query -d 'Set(10, f1=1, 2019-03-01T12:34)'
$ curl localhost:10101/index/i1/query -d 'Set(100, f1=1)'
$ curl -H "Accept: text/csv" "localhost:10101/export?index=i1&field=f1&shard=0&timestamps=false"
1,10
1,100
$ curl -H "Accept: text/csv" "localhost:10101/export?index=i1&field=f1&shard=0&timestamps=true"
1,10,2019-03-01T12:00
1,10,2019-04-01T12:00

Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Add appropriate changelog label to PR (if applicable).

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Make sure PR is tagged with appropriate changelog label.

This should be good to review.


Im facing a trouble while running this code in the file of 's01.mat' is not found or empty?

Hello.
As written in readme,
You first need to download dataset.
Then please specify your path.

that is what I got after the mentioned steps,

Could you let me know the file size. It should be 253.45MB. if so, that should be working.

actually, it's not the size of the zip code I've downloaded..

I think it failed to download whole dataset, as whole dataset is very huge, about 19GB.
You can download for each mat individually

okay, but I'm seeing all the files you uploaded here is the same as the files that I've downloaded so, even if I download them individually what is the difference?

Another comment: you cannot load my mat files with scipy.io.loadmat. This function is for mat format other than mat73.
I saved the mat files using mat73, it requires mat73.loadmat or h5py.

pip install mat73

Your script should be:

eeg = mat73.loadmat('s01.mat')

okay, but I'm seeing all the files you uploaded here is the same as the files that I've downloaded so, even if I download them individually what is the difference?

I don't know, but your file size is only 433KB, somehow it does not represent my whole data

Another comment: you cannot load my mat files with scipy.io.loadmat. This function is for mat format other than mat73. I saved the mat files using mat73, it requires mat73.loadmat or h5py.

pip install mat73

Your script should be:

eeg = mat73.loadmat('s01.mat')

ohh i got it, but i did both and nth.
Over all thank you😊

I apologize for the inconvenience caused, but I would like to inquire if there exists an alternative source or means to obtain the dataset, aside from utilizing GitHub or transmitting the file 's01.mat', in order to address the encountered error. I am actively seeking a resolution for this matter as the repository in question holds significant importance for my ongoing project.

I apologize for the inconvenience caused, but I would like to inquire if there exists an alternative source or means to obtain the dataset, aside from utilizing GitHub or transmitting the file 's01.mat', in order to address the encountered error. I am actively seeking a resolution for this matter as the repository in question holds significant importance for my ongoing project.

On 16 May 2023, at 12:35 AM, Kyungho Won @.***> wrote:

I apologize for the inconvenience caused, but I would like to inquire if there exists an alternative source or means to obtain the dataset, aside from utilizing GitHub or transmitting the file 's01.mat', in order to address the encountered error. I am actively seeking a resolution for this matter as the repository in question holds significant importance for my ongoing project.


make file inclusion recursive

Currently, if you include a file that itself contains included files, only the top-level includes are processed. Included files in the child files are simply rendered as the {file name} (or {id}).
I think that any included file should also have sub-includes parsed.
Obviously, this would require a mechanism to protect against looping (a includes b which includes a), but I still think it would be valuable.

Ah, it should work as you described. It also has a loop protection, that it does not include a file if it was already included. The fact that it does not work, means there is a bug somewhere.
Thanks for reporting it. I will start fixing it.


[CLEANUP] fixes checkstyle issues

@smmribeiro

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'plugins/shapefilereader/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/shapefilereader/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/shapefilereader/core/src/main/java/org/pentaho/di/shapefilereader/ShapeFileReader.java
  plugins/shapefilereader/core/src/main/java/org/pentaho/di/shapefilereader/ShapeFileReaderMeta.java

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/shapefilereader/core/src/main/java/org/pentaho/di/shapefilereader/ShapeFileReader.java

:heavy_exclamation_mark: Avoid nested blocks. at Line: 87 Column: 41

:heavy_exclamation_mark: Avoid nested blocks. at Line: 148 Column: 38

:heavy_exclamation_mark: Avoid nested blocks. at Line: 210 Column: 39

:heavy_exclamation_mark: Avoid nested blocks. at Line: 271 Column: 36

:heavy_exclamation_mark: Empty statement. at Line: 384 Column: 9


🪲 Bug Report - Tools - WARA Collector - Tenant wide not working

Describe the bug
The tenant wide collection of data (all subscriptions) is blocked by logic requiring either subscription Ids or resource group Ids.
This doesn't work:
Run against all subscriptions in tenant "00000000-0000-0000-0000-000000000000":
.\1_wara_collector.ps1 -TenantID 00000000-0000-0000-0000-000000000000

To Reproduce
Steps to reproduce the behaviour:

Provide only Tenant Id to the 1_wara_collector.ps1

Expected behaviour
Should be able to collect all data at Tenant level.
Screenshots 📷

Additional context
Anything else we should know to help us troubleshoot this bug?

This is by design. WARA is meant to be workload specific, so we expect users to explicitly define their scopes.


[RESTX] Confirm that edge cases do not throw any 500s

We need to confirm that none of the endpoints return a 500 error.
This issue includes going over existing tests, writing additional test cases with different cases of invalid data (wrong types, missing fields, wrong format, etc.)

Hey team! Please add your planning poker estimate with ZenHub @Fivetoes @jiuliwei @XinyuC97 @yx2512 @ZX-WANG


"same chain of narrators" and empty hadiths

Salam
When we access the Hadith ENDPOINT for Sahih Muslim, we get many hadiths which are simply statements like
A hadith like this has been narrated on the authority of Abu Huraira (Allah be pleased with him) through another chain of transmitters and we also get empty hadiths etc. is there any list of the hadith numbers that contain such things which aren't actual hadiths, so that we may block them out when we access the API? Or any other workaround that you could suggest?
Regards

For simple statements I am not sure if there is any reliable way to block it
For empty text, You can check in python whether the text is empty

Ah ok, is there any list of all the hadiths in a simple txt so we can
identify the numbers involved and blacklist them when we search the API
On Mon, 29 Aug 2022, 15:45 Fawaz Ahmed, @.***> wrote:

For simple statements I am not sure if there is any reliable way to block
it
For empty text, You can check in python whether the text is empty
—
Reply to this email directly, view it on GitHub
https://github.com/fawazahmed0/hadith-api/issues/11#issuecomment-1230411781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQIKRW3K5GDFTZXZEVLAUI3V3TEJPANCNFSM576ALEHQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

currently, there is no list yet

Ok.


Improvements to the ICA API

@adam2392 pinging as discussed.
Hello! Following the release of mne-icalabel, I'd like to propose a couple of changes to the ICA API.
In mne-icalabel, we used label_components as the main entry-point:
from mne_icalabel import label_components

raw = ...
ica = ...
label_components(raw, ica, method='iclabel')

The name was chosen to be consistent with the methods in an ICA instance: get_components and plot_components. For now, the only available method argument is 'iclabel', but the goal is to add more.
-> Proposed change: add a label_components method to the ICA instance that takes as input self, a raw or epochs instance, and the name of the method to use to label components.

But instead of only stopping here and clogging a bit more the MNE API, I'd like to go a bit further. For now, the ICA instance has build-in simple methods to label cardiac, ocular, MEG ref, and muscular-related components: find_bads_eog, find_bads_ecg, find_bads_ref and the newly added find_bads_muscle. Each of those methods' outputs is very similar to the output of label_components: labels and scores/prediction probabilities.
-> Proposed change: move those simple labeling methods to mne-icalabel, deprecate the find_bads_ methods, and group all labeling methods under a simple ica.label_components method.
IMO, this change would simplify the API and move the maintenance of the related code and documentation to the mne-icalabel repository.

And finally, alongside those 2 changes, labels and scores/prediction probabilities could be stored in the ICA instance. For now, only the labels are stored in a dictionary self.labels_ where the key is the method/component type and the value is a list of components IDx that were labelled with this type. Related issue: https://github.com/mne-tools/mne-python/issues/9846
WDYT?

I like it a lot!

Proposed change: move those simple labeling methods to mne-icalabel, deprecate the find_bads_ methods, and group all labeling methods under a simple ica.label_components method.

I'm fine with moving this functionality to a unified ica.label_components function, but I'd actually like to 1) keep one-line wrappers for find_bads_*, and 2) advertise that new code should use the unified function. Every deprecation means pain for our users, and I think we can avoid it easily here, especially for code that has been around for 8 years. The maintenance overhead for us in keeping it is low, and I think if we adapt tutorials + docstrings to advertise the new label_components function, users won't be too confused by our the violation of "one way" principle.

Yes please no API changes here. Moving the code outside of MNE is a great idea though.

let's not rush here. Let mne-icalabel get a bit of visibility and user
feedback and then let's
reevaluate in a few months.

Message ID: @.***>

Moving the code outside of MNE is a great idea though.

Does MNE-ICLabel require PyTorch? If that's the case, given @hoechenberger's difficulties with installing PyTorch in https://github.com/mne-tools/mne-installers/pull/123 as it's quite a big dependency, I'm -1 on depending on MNE-ICLabel for core ICA functionality in MNE-Python. We should only depend on it for ICLabel functionality.
In other words, let's add ica.label_components in MNE-Python, keep our find_bads_* one-line wrappers for trivial backward compat (no need for deprecation), and just add a small shim in label_components to call to mne-iclabel when a user requests that mode.

Yes of course let's not rush here, the goal is to get opinions for now.
Also yes, let's definitely not have PyTorch set as a hard dependency. When we move the code from find_bads_* to mne-icalabel, we'll set pytorch as a soft dependency for ICLabel, with a warning if it's not installed.

Oh, yes we can do it this way as well. I was proposing to move all IC-labelling stuff to mne-icalabel while removing the hard-dependency for torch from mne-icalabel. This way it can become a core dependency of mne, while not needing any additional dependencies to run.
So compare to your proposal, the idea is to import mne-icalabel (same dep. as mne-python) to use ica.label_components(), and in mne-icalabel, import optional dependencies as torch (or any other extra dependency specific to this model), if needed only.

I was proposing to move all IC-labelling stuff to mne-icalabel while removing the hard-dependency for torch from mne-icalabel. This way it can become a core dependency of mne, while not needing any additional dependencies to run.

I like this proposal a bit less because if a user does pip install --upgrade mne now ICA is broken for them unless they install mne-iclabel as well. I like the idea of making the scope of mne-iclabel to do labeling using iclabel, not all forms of labeling. It seems more appropriate, especially since find_bads_ecg and such have been around for so long. Then mne-iclabel can focus on just iclabel functionality, and not have to test all the find_bads_* functions that MNE-Python currently does already.

So it sounds like the only change we should do is https://github.com/mne-tools/mne-python/issues/9846?
Is there a consensus there? What are the next steps to enable storage of "scores" within the ICA labels?

I'm surprised pip install --upgrade pkg doesn't install new dependencies for the updated version

It would, but then we'd have to add another hard dependency.
Dependencies aside, though, I like the idea of keeping mne-iclabel's functionality focused on iclabel stuff as opposed to things like find_bads_* that MNE-Python already provides. It makes it clear that core ICA functionality lives in MNE, including label_components, and that the scope of mne-iclabel is iclabel-specific stuff.

So, what is 'iclabel-specific'? We also want to include different models to label components, not just ICLabel. That's why I proposed to move the code from the find_bads_* to the other repo, as in the end they can be considered as simple models to label components.
But anyway, that was just an additional proposal to move some of the code from mne-python to a sub-repo. It's not that important, the core is really label_components and regrouping all labeling methods (inc. find_bads_*) in label_components, no matter where the code of find_bads_* lives.

So, what is 'iclabel-specific'? We also want to include different models to label components, not just ICLabel. That's why I proposed to move the code from the find_bads_* to the other repo, as in the end they can be considered as simple models to label components.

Let's do it the other way around, then:
ICALabel could internally call the MNE find_bads_* methods and expose this as, say, method='mne'.
The package depends on MNE already, so all would be good, I suppose!

We also want to include different models to label components, not just ICLabel

label_components(..., method='iclabel') should definitely be in mne-iclabel. I'm not sure what other methods there are, but they could live in iclabel or MNE-Python, either way is fine by me. If they're already in mne-iclabel, they could stay.
To me the default method='channels' (or whatever we think is a good name for what find_bads_* does currently) should live in MNE-Python and continue to work with no other dependencies.

Let's do it the other way around, then:

This could work, too, I suppose. But it sounds like you're saying that we shouldn't add ica.label_components, but that seemed like a nice API unification point.

Installing pytorch with installer seems ambitious unless you accept to only
install a CPU version.
but then you'll have people complaining to have a slow pytorch if they do
anything else.
I don't know if the installer can detect at runtime if cuda is available
and if so install a GPU version.
It seems a bit of work...

Message ID: @.***>

But do we even need a GPU version? We are just running a forward pass.. there is no training involved.

yes for icalabel cpu is just what you need but if folks want to train deep
net in the MNE environment
it would be bad. Not sure what to recommend.

Message ID: @.***>

yes.. thought about it after, you are right.

yes for icalabel cpu is just what you need but if folks want to train deep net in the MNE environment it would be bad. Not sure what to recommend.

If we include ICALabel, I wouldn't mention the availability of PyTorch as long as we only have CPU support.
Capability detection & package selection at installation time is possible; the auto-selection is already part of the conda-forge package; the tricky (?) part is to fire up the package installation in a post-installation script after the installer has extracted everything else. It's all doable but I expect this to take a while until we'll get it to work well on all platforms. But this effort would come with the bonus point that once we have such a mechanism in place, we can in theory also ship packages from PyPI etc…
I cannot work on this for the time being, though, as I'm busy with other stuff I'm afraid


js: removal of pending acceptance state

We are storing the minion id in session storage while it goes under
pending acceptance state. However we were not handling its removal if
the acceptance succeeded or if an error happened after the request.
This patch fixes those scenarios avoiding unwanted user experiences.
bsc#1093869
Signed-off-by: Vítor Avelino<EMAIL_ADDRESS>(cherry picked from commit a660c5b273befe3427f04036719c035fcf0635e1)

 Bug 1093869 - New nodes never leave "Acceptance in progress"


Kafka Monitoring

Kafka has JMX Metrics. Dashboard-Interface should have an interface which displays the most important information such as topics, who is writing to these topics.
With these metrics it could be nice if the interface could detect abnormal writes and alert the user

After testing this with JConsole and Jolokia (HTTP version of JConsole), then I'm not sure that you can fetch information such as topics and who is writing to what topic with JMX Metrics. However, there are some other metrics that could be interesting.
If we want the metrics to be available to C# developed system, then we probably have to start a Jolokia agent that listens to specific JVMs and makes the data available with a REST API. I have not found any other feasible solution yet, as JMX (and its underlying RMI technology) is clouded with a lot of old information on the internet.
I'm left wondering what value this would bring compared to the big implementation task it is.
The following documentation shows what JMX metrics are available:
https://docs.confluent.io/platform/current/kafka/monitoring.html
https://kafka.apache.org/documentation/#monitoring


[AST] Progress toward handling indirect conformances in witness tables

Make some progress toward handling "indirect conformances", e.g., those that are introduced via where clauses on associated types, in IRGen. This currently has two independent pieces:

Teach requirement sources that involve protocol requirements to keep track of the dependent type that we're looking through to find the conformance we want. This will allow us to find the conformance later, but we're not using it yet.
Reimplement NormalProtocolConformance::getAssocated{Type|Conformance} to make them handle indirect conformances properly.

The second part lets us emit witness tables involving indirect conformances, but we need to wire up the first part before we can actually use them.

Adding this to the new test:
func useQ<T: Q>(_: T) { }
func useP3<T: P3>(_ t: T) {
  useQ(t.getAssocP3().getAssocP2())
}

will assert in access-path computation because we're not using requirement sources there.

@swift-ci please smoke test and merge

@rjmccall you'll be interested in this.

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge


cmd/cgo: proposed #cgo noescape seems redundant

Go version
go1.22rc1
What operating system and processor architecture are you using (go env)?
N/A

What did you do?
The proposed #cgo noescape pragma (#56378) is documented to say:

When passing a Go pointer to a C function the compiler normally ensures
that the Go object lives on the heap. If the C function does not keep
a copy of the Go pointer, and never passes the Go pointer back to Go code,
then this is unnecessary. The #cgo noescape directive may be used to tell
the compiler that no Go pointers escape via the named C function.
If the noescape directive is used and the C function does not handle the
pointer safely, the program may crash or see memory corruption.

However, the property "If the C function does not keep a copy of the Go pointer" seems guaranteed for non-pinned memory by the rule that

C code may not keep a copy of a Go pointer after the call returns,
unless the memory it points to is pinned with [runtime.Pinner]

So my question is: what can "#cgo noescape" promise that is not already promised?
One answer may be "pinned objects may be retained by C". But then why not force objects passed to runtime.Pinner to the heap?
Another answer may be "Go objects may escape through callbacks to from C to Go", then that seems entirely covered by the "#cgo nocallback" pragma.
In summary, "#cgo noescape" seems to add no useful information.
What did you expect to see?
No "#cgo noescape" pragma, or clearer documentation what "#cgo noescape" promises that is not already promised.
What did you see instead?
A seemingly redundant "#cgo noescape" pragma.

@eliasnaur I see a third case, C can return a Go pointer back to go.
Then the pointer does escape but isn't retained by C.
The escape analysis is able to model this properly when reading go code, but the noescape pragmas are way under capable compared to the level of detail the escape analysis read code.

Yes, I think (if my memory serves) the issue has to do with Go -> C -> Go cases. Doesn't happen very often, but it is something we support. Perhaps the documentation could be clarified/enhanced.

@eliasnaur #cgo noescape is disabled in 1.22, and will enable in 1.23, so, there is no much doc about it.
For such a Go function:
func get() uint64 {
	var value C.uint64_t
	C.GetIntegerValue(&value)
	return uint64(value)
}

without #cgo noescape , value will always escape to heap.
after adding #cgo noescape GetIntegerValue, value will be on stack.
it's a normal optimization for cgo.
And pin is another thing.
we can also say the Go pointer &value is pinned, when it's on the stack, since it won't move before C entering Go again.

Yes, I think (if my memory serves) the issue has to do with Go -> C -> Go cases. Doesn't happen very often, but it is something we support. Perhaps the documentation could be clarified/enhanced.

Thank you. I missed that a returned value is a violation of "never passes the Go pointer back to Go code".