Trouble with OCR

Hey! So I recently migrated to Amazon Lightsail to host a project. However, since I started with it, I get the following error when attempting to use Cloud Vision:

SyntaxError: Unexpected token p in JSON at position 93

at JSON.parse (<anonymous>)

at ReadStream.<anonymous> (/home/bitnami/.jenkins/workspace/[my project]/node_modules/google-auth-library/build/src/auth/googleauth.js:347:39)

at ReadStream.emit (events.js:208:15)

at endReadableNT (_stream_readable.js:1161:12)

at processTicksAndRejections (internal/process/task_queues.js:77:11)

Environment details

OS: Ubuntu 16.04.6 LTS (GNU/Linux 4.4.0-1098-aws x86_64)
Node.js version: 12.7.0
npm version: 6.13.1
@google-cloud/vision version: 1.7.2

Steps to reproduce

Attempt to run code using vision client

                const vision = require("@google-cloud/vision");
                const visionClient = new vision.ImageAnnotatorClient();
                const [result] = await visionClient.textDetection(
                  cresult.secure_url
                );
                const detections = result.textAnnotations;
                let ocrresult = detections[0].description;

??

@futurGH where were you running @google-cloud/vision prior to this? In GCP environments credentials are detected automatically, in an AWS environment, you will need to create a service account for credentials and point to the path using the environment variable GOOGLE_APPLICATION_CREDENTIALS, see:
https://cloud.google.com/docs/authentication/getting-started

@futurGH where were you running @google-cloud/vision prior to this? In GCP environments credentials are detected automatically, in an AWS environment, you will need to create a service account for credentials and point to the path using the environment variable GOOGLE_APPLICATION_CREDENTIALS, see:
https://cloud.google.com/docs/authentication/getting-started

Ah, that makes sense. I was previously running it on Glitch.com. I have the env variable set.
I assumed the service account aspect would be different because Lightsail seemed to be a simplified version of other EC2 instances. I'll give that a go. Thanks!

:+1: please feel free to reopen this issue if you continue bumping into issues, but I think you'll find setting the variable does the trick.


when editors and/or member support roles review reportbacks, flagged status is set to null

when admins review reportbacks flagged status is set properly (0 for flagged, 1 for everything else)
we recreated this several times on staging and production with the same user and just changing their permissions
every single reportback that Lizzy reviewed has flagged status of null on nid 5566 has flagged status null. her roles are editor and member support.
when diego reviewed reportbacks on nid 5566 they had the correct flagged status. he is an admin. when we changed him to editor role, the reportbacks he reviewed had incorrect flagged status
also saw this with nid 2900 and sam's accounts

so we've been able to reproduce this consistently, but it's worth noting times when this has worked properly for editors and has not worked properly for admins.
one example:
select rb.nid, rb.rbid, rbf.fid, rb.flagged, rb.flagged_reason, rb.promoted, rb.promoted_reason, rbf.status, from_unixtime(rb.created) as created, from_unixtime(rbf.reviewed) as reviewed, u.mail, r.name
from dosomething_reportback rb
inner join dosomething_reportback_file rbf on rb.rbid = rbf.rbid
inner join users u on u.uid = rbf.reviewer
inner join users_roles ur on u.uid = ur.uid
inner join role r on r.rid = ur.rid
where rb.nid = 2003
order by rb.rbid desc;

this may be because we had multiple issues causing the problem, but i'd like to still keep an eye out for this.
also may be worth @angaither running a query to see every time an editor has reviewed a rb and the flagged status is correct and also every time an admin has reviewed a rb and the flagged status was null just to see if there are still other things that may be causing the symptom of #4829 and #4815

also noting here, the permission that needs to be changed for editor and customer support role is that they need permission to "edit any reportback"

Every reportback where flagged is null, but reportback file status is flagged

proves that editor|member support|site admin have the issue

select rb.nid, rb.rbid, rbf.fid, rb.flagged, rb.flagged_reason, rb.promoted, rb.promoted_reason, rbf.status, from_unixtime(rb.created) as created, from_unixtime(rbf.reviewed) as reviewed, u.mail, r.name
from dosomething_reportback rb
inner join dosomething_reportback_file rbf on rb.rbid = rbf.rbid
inner join users u on u.uid = rbf.reviewer
inner join users_roles ur on u.uid = ur.uid
inner join role r on r.rid = ur.rid
where rb.flagged is NULL
and rbf.status = 'flagged'
order by reviewed asc;


append hostname to graphiteReporter metric key prefix

Hello!
I'm running several instances of a same dropwizard project behind a load balancer, and all of them report to the same graphite host. Since all of the instances have the same config all the metrics go to graphite with the same prefix, so it gets impossible to have metrics per individual instance.
I worked around this issue adding a command-line option like this in the init scirpt:

-Ddw.metrics.reporters[0].prefix=common.prefix.for.my.app.hostname

I.E. using the back-ticks to add the output of the shell command "hostname" to the prefix for the graphite metrics. This way I get the name of the machine on the metrics and I can inspect them individually if I need to do so.
I really prefer to control this from the application config rather than the init script. Wrote  some changes for the GraphiteReporter so I can pass an option  on the yml config so it tries to get the hostname using InetAddress.getLocalHost().getHostName() to append it to the prefix from the config.
https://github.com/rafael-driutti-olx/dropwizard/commit/94e0f0092902de7b09b3fe89dd5fb503ce0085b4
Do you think this could be useful?
If so, what's the best way to handle an eventual UnknownHostException ? I just assign "localhost" to the prefix... should I raise an error and/or prevent the server from starting?
  try {
                localHostName = InetAddress.getLocalHost().getHostName();
            } catch (UnknownHostException e) {
                localHostName = "localhost";
            }

Thanks!

Could your deployment workflow allow you to set the prefix configuration option of GraphiteReporter? If you use some configuration management system to distribute templatized Dropwizard config files to your instances, you could simply include the hostname in the prefix:
metrics:
  reporters:
    - type: graphite
      prefix: common.prefix.for.my.app.<IP_ADDRESS>

The purpose of the prefix config option is to be general enough to satisfy most use cases. I'm hesitant to entertain a hostname-prefixing patch, since it strikes me as one among multiple possible pieces of application metadata that could feasibly be used to prefix metrics. For instance, you could imagine using a PID or something cloud-provider-specific like an EC2 instance ID or tag.

Hi!
I see your point, but I tend to identify my hosts (and things in general) by name rather by AWS id, process id or other difficult to remember reference, so that I can easily find them on my metrics storage. Especially on multiple instance/HA/ASG setups.
I just thought was better to add this kind of logic to the application rather than the init scripts or deploy pipelines. Must be because I'm a sysadmin not a developer :D
Thanks for the feedback!


STM32F303 I2C blocking_read_write works but async write_read fails due to a timeout

main.rs:
bind_interrupts!(struct Irqs {
    I2C1_EV => i2c::EventInterruptHandler<peripherals::I2C1>;
    I2C1_ER => i2c::ErrorInterruptHandler<peripherals::I2C1>;
});

#[embassy_executor::main]
async fn main(spawner: Spawner) {
    let p = embassy_stm32::init(Config::default());

    let mut config = i2c::Config::default();

    let mut i2c = I2c::new(
        p.I2C1,
        p.PB6,
        p.PB7,
        Irqs,
        p.DMA1_CH2,
        p.DMA1_CH7,
        Hertz(100_000),
        Default::default(),
    );

    let mut buf = [0u8];
    i2c.blocking_write_read(0x38, &[0u8], &mut buf).unwrap();

    defmt::info!("blocking: {:?}", buf);

    let mut buf = [0u8];
    i2c.write_read(0x38, &[0u8], &mut buf).await.unwrap();

    defmt::info!("async: {:?}", buf);
}

Output:
INFO  blocking: [24]
└─ pd_interceptor::____embassy_main_task::{async_fn#0} @ pd-interceptor/src/main.rs:55
ERROR panicked at pd-interceptor/src/main.rs:58:50:
called `Result::unwrap()` on an `Err` value: Timeout

Why does the async read-write fail? Have I set up the interrupts/DMA correctly?

@fmckeogh I looked and the F303 doesn't have the errata from #2887, I would suggest adding logs to the poll_fns in the read/write dma internal to figure out which branch was taken, I'm guessing in the hanging case, it's taking one of the branches that DOESN'T re-enable the interrupts.
Since the interrupts self-disable, any non-terminating branch of the poll-fns should re-enable the interrupts.

@jamesmunns Awesome, will do:)

@jamesmunns Yes, seems like you're right. The contents of the poll_fn gets called once, returns pending, then is never called again. I've tried manually re-enabling interrupts but no luck so far, I think I need to take some time to understand the codebase.


Improved urgent handling with keyboard multiplexing

When keyboard multiplexing is activated, the multiplexing border now
overrides the urgent border. Also made it more obvious which terminals
are urgent.

Hi,
Thanks for the patch and sorry for the late response. I applied the part regarding the urgent handling.
Tags which contain urgent windows are currently blinking, maybe we should use the same indications (be it a different color or blinking) for windows too?

With #29 applied, the tag symbol is now colored differently while keyboard multiplexing is enabled.


[TextField] Replaced WebkitTextFillColor with WebkitOpacity

WebkitTextFillColor overwrites any custom html css color rules

[ ] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@midan888 Thanks

@oliviertassinari When will this be merged into a release? (0.18.4)

Will do a release by the end of the week.


Trie implementation link 404

Your trie implementation link in the README.md leads to a 404.

It was a typo in the URL. Thanks!


Issues in Fluent Autocomplete and Fluent Dialog controls

🐛 Bug Report

On tab key, it doesn't go to the close button in Fluent Autocomplete control.
Also when press the down arrow button at the end of the populated list of Fluent autocomplete control, it continuously pronounce text in input box in NVDA.
Tooltip is required on focus to close button in Fluent dialog.

💻 Repro or Code Sample
Go to fluent blazor demo URL: https://www.fluentui-blazor.net/Autocomplete
🤔 Expected Behavior

On keyboard tab key, Focus should move to the close button in Fluent Autocomplete control.
Also when press the down arrow button at the end of the populated list of Fluent autocomplete control, it should not pronounce text in NVDA when arrow reach the end of the list.
Tooltip is required on focus to close button in Fluent dialog using keyboard tab key.

😯 Current Behavior

On tab key, it doesn't go to the close button in Fluent Autocomplete control.
Also when press the down arrow button at the end of the populated list of Fluent autocomplete control, it continuously pronounce text in input box in NVDA.
Tooltip is not keyboard accessible, when mouse hover on the control, tooltip is displayed.

🔦 Context
We are trying to achieve grade A accessibility level. however these issues are stopping to achieve the same.
🌍 Your Environment

OS & Device: [Windows] on [PC]
Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
.NET 6 and Fluent UI Blazor library Version [3.5.5]

Update: we just released v3.7.0 : https://www.nuget.org/packages/Microsoft.Fast.Components.FluentUI. First try this version and then re-submit any issues separately once tested and nt resolved. Thanks


Automatic object marshaling feature request.

A nice to have feature since POJOs are often represented as JsonObjects. It would be nice to have a flag in the serialize method that tries to reflectively figure out what a non-Jsonable POJO's fields are and use their names as keys and their respective values for the keys' values in the JsonObject.
Naturally, implementing Jsonable is safer and in many ways makes this feature a convenience for not needing to implement Jsonable for very simple POJOs. If it fails to produce a JsonObject to serialize it should defer to replacements if allowed. If replacement fails it should defer to invalids if allowed. This feature would require another serialize method exposed to allow this serialization.
This feature (although perhaps useful on its own) would also include a method in the JsonObject where you pass it a class and it would do its best to instantiate a POJO of the class using the keys in the JsonObject.
A potential challenge for this feature is the limited power of Java's generics and may not fit into the simple nature of json-simple. Those with suggestions are highly encouraged to comment on this issue.

The OP was actually a comment from the code posted here, so I would like to note 'replacements' are referred to when it shouldn't. It was a quirky feature that was abandoned before release and shouldn't be paid any mind. Instead it should defer directly to invalids if allowed or fail.

There is no way to passively acquire all fields that are declared public, protected, package, and private scope from the Class itself and all of its inherited ones.


Missing climate entity, outside temperature sensor and service set_quick_mode not working

Hi thomasgermain,
the integration works basically, thanks for your work.
But a few things don't seem to work in my setup:
Heat pump VWF58/4
VR921
I have no climate entity "climate.xxx" and no sensor "sensor.outside_temperature". However, in the Multimatic app these values are displayed.
This is all I receive:

Furthermore, the service: multimatic.set_quick_mode does not work:
service: multimatic.set_quick_mode
data:
quick_mode: QM_HOTWATER_BOOST
Thought about this I could trigger the function "hot water fast", as it is called in the Multimatic App.
I get the error "Error calling the service multimatic/set_quick_mode. Cannot put https://smart.vaillant.com/mobile/api/v4/facilities/21210900202609620938012014N2/systemcontrol/v1/configuration/quickmode, status: 409, response: {"errorCode": "FACILITY_NOT_COMPATIBLE"},payload: {'quickmode': 'QM_HOTWATER_BOOST'}}
"
Am I doing something wrong?
Thanks for your help.
flobo1990

So, I added a small note on the readme about the VR921. It sounds like, in certain cases, that the VR921 is using a different API than the one supported in the integration.
I'm gonna close all the issues related to the incompatibility. But I'm still open to receive a PR to support this API.


Add code for  Doomsday algorithm

I can take a look at this, I assume the algorithm is this one: https://en.wikipedia.org/wiki/Doomsday_rule. I will place it under a folder titled Doomsday algorithm.


Excepted output of the example

I've managed to execute the example that you've given in the Readme section. But Im not able to understand the output that ive got. Please make me clear on this. I've posted a question about this in stackoverflow. Hope you could give me a right solution there. I dont know how to reach you thats why ive raised as a issue here.

I will address your question on stackoverflow.  Please PM me in the future.


[RUNTIME] Ensure we hold the GIL before calling into CPython API in cubin binding

Formatting of the diff is not the best. I only indented the whole function, moved the creation of the py::bytes and the return out of the scope and declared and assigned the cubin variable appropriately. Everything else is unchanged.
Today it triggers the following error on CPython debug build:
Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL
Python runtime state: initialized

installing and using the pre-commit should clean up the diff :p

TIL: "pre-commit" was actually the name of the project haha
Should be good now. I also rebased on latest main (the previous fix was based on the PyTorch pinned hash which might be missing some formatting.

Hmm i'm confused by the formatting failure. It looks like it's not using our clang-format config

In my original commit, I didn't realize that the commit hook only triggers on newly added files. I re-ran it by hand on just that file to get the updated lint. Should be good now right?

I think it's good. The CI machine may have a problem though


How to run pre-trained models to generate voice e.g. Joe Rogan?

Hi,
Can you please provide instructions on how to use this repo and generate speech from input text? Sorry I'm just having a bit of trouble figuring out how to run it.
Also is there a pre-trained model of Joe Rogan? How would I go about building this? Thanks!

+1

If I remember correctly, you extract the pretrained voice into the logdir folder and run "python synthesize.py" in the command prompt. You can edit the "harvard_sentences.txt" file to make it say whatever you want. (just don't delete the numbers) Then a folder called "samples" is generated in the dc_tts-master folder with the wav files.
As for how to make a voice, I used the LJ speech dataset as a template to create my own dataset. I couldn't train it because I don't have enough ram at the moment, so I'll have to wait to see if it works.


Update github repository credentials

** Please describe which feature you have a question about? **
I have created an AWS Amplify App with an Angular frontend and a DynamoDB backend. The code repository is hosted by github, and I am using CD/CI which all works fine.
Due to a change in the github policy I want to change the credentials for the github repository using a "personal access token". I created this token in my github account, change my account to use 2FA and even change my account password.
As I didn't find any point in the AWS Console to edit the github repository credentials I tried to "reconnect repository" in the App settings:General section - but I don't get asked for new credentials. And the AWS Amplify App even grabs new commits (in my develop branch, but it will also work on the main branch I guess). Did I miss any thing? Do I have to delete the App and recreate it? I would like to avoid that.
Kind regards,
Stefan.
** Provide additional details**

@aheadxnet Once your repository is connected, you will not have to reconnect when credentials change.
I will close this ticket, but feel free to re-open if you have further questions.

@aheadxnet Once your repository is connected, you will not have to reconnect when credentials change.
I will close this ticket, but feel free to re-open if you have further questions.


Can't get old permissions after switching from flatfile to mysql

it just doesnt find changes

https://github.com/lucko/LuckPerms/wiki/Switching-storage-types


Rotate operation

Good, but small enhancements could be done:

[ ] Button for turning in the opposite direction (both "clockwise" and "counter-clockwise").
[ ] When user turns picture, it changes size. Looks like UI bug, because free angle mode functions properly.
[ ] Conversion of dragging motion into angle for rotation is incorrect (not a problem for small angles).

https://user-images.githubusercontent.com/581023/218253864-d159983c-0dc7-4295-84f2-95eb9b7c0e80.mp4

Nice, but now it crashes if the app was started in "drawing from scratch" mode.


Transparent background images become white?

I got that problem while testing the downloading:
moodImageView.load("http://mooddy.officience.com/uploads/media/default/564e/91/thumb_564e9152582c2ee3217b23c6_default_small.png")
The problem doesnt happen if I use this:
let url = NSURL(string:"http://mooddy.officience.com/uploads/media/default/564e/91/thumb_564e9152582c2ee3217b23c6_default_small.png")!
moodImageView.image = UIImage(data: NSData(contentsOfURL: url)!)

Thanks, @gloryluu .
I fixed by https://github.com/hirohisa/ImageLoaderSwift/commit/d761b61b04257c07b24cabab0089041d2f4a30ef.

And now I bump version 0.7.2.
It has this commit, please use.
Regards

Hi Hirohisa,
I dont know if it helps you but I got some crashes ra randomly. Quite hard
to reproduce.
Regard,
On Tue, Nov 24, 2015 at 6:07 PM, Hirohisa Kawasaki<EMAIL_ADDRESS>
wrote:

And now I bump version 0.7.2.
It has this commit, please use.
Regards
—
Reply to this email directly or view it on GitHub
https://github.com/hirohisa/ImageLoaderSwift/issues/53#issuecomment-159231612
.

Hi @gloryluu ,
Could you show me crash logs?

Sorry I didnt see any log in the simulator. It keeps crashing randomly.
Right at the position I show you, always exc_bad_access.
On Thu, Nov 26, 2015 at 11:15 PM, Hirohisa Kawasaki <
<EMAIL_ADDRESS>wrote:

Hi @gloryluu https://github.com/gloryluu ,
Could you show me crash logs?
—
Reply to this email directly or view it on GitHub
https://github.com/hirohisa/ImageLoaderSwift/issues/53#issuecomment-159951595
.


Add a fix for gradient aggregation

Modulus Pull Request
Description
The Gradient aggregation was not functioning correctly, because it was computing the losses on the same batch as opposed to different batches that is needed for Gradient aggregation. This PR adds a fix that enables use of Gradient aggregation for cases without CUDA Graphs.
Closes #51
Annular ring case now works as expected with Gradient aggregation.
Pink: Baseline, Blue: 0.1x batch size, Red: 0.1x batch size + 10 gradient aggregation steps.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci

/blossom-ci


Text in the bubble cut with using setDraggableFromAnywhere(true)

If the user jumps from an index that has a text with lower width (like in alphabet the letter "i") to an index that has a longer text (like "m") then the letter is cut on display. This only happens when the user directly jumps to the position by pressing the scroll bar on a place where the indicator would display the longer text.
Step 1:

Step 2 (jumping directly to letter "M"):

This was reproduced on an Android 4.1.1 device, ATM I don't know if it applies to other Android versions or not.
Please let me know if you need any further details. Thank you for you for this library.

Thanks for notifying me about this issue. I will try and fix it as soon as possible.


Test for string / numeric coercion

Which issue does this PR close?

Part of https://github.com/apache/datafusion/issues/13359

Rationale for this change
While testing https://github.com/apache/datafusion/pull/13366 I found there are still some gaps with StringView:
What changes are included in this PR?
Add tests for string coercsion to integer. They currently fail as arrow-rs doesn't suport int --> StringView casting at the moment
Are these changes tested?

Are there any user-facing changes?

fyi https://github.com/apache/arrow-rs/issues/6714 was resolved recently.

fyi apache/arrow-rs#6714 was resolved recently.

Awesome -- thank you
I have it on my list to double check if we need any additional work (like timestamp --> Utf8View)
I just haven't found the time yet to write the corresponding tests to verify in DataFusion. Hoping to be able to do so this week


Misleading usage of acc_stats in kfac optimizer.

It is not obvious, how to use this, a simple inline comment would be extremely helpful
https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/blob/4d95ec364c7303566c6a52fb0a254640e931609d/algo/kfac.py#L162

Fixed in https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/commit/2edf667a2e2bb2fcfe8f102b0a58576a69dad4e5


Edit lines 31-32 of lcd1602_hello_world to be able to correctly display hex

LCD1602 code migrated to CowPi_stdio


asObservable() eats exceptions

Use of asObservable() causes exceptions thrown by observers to be eaten.
<EMAIL_ADDRESS>let subject = new BehaviorSubject<boolean>(null);
subject.asObservable().subscribe(b => {
    throw new Error('yuk');
});

Expected: An exception to be thrown
Observed: No exception is thrown
If I remove the call to asObservable(), an exception is thrown.

let me close this as dupe of https://github.com/ReactiveX/rxjs/issues/2565.


fix(dockerfile): ensure dockerfile gets binary (#1)

The container image fails to build as it is unable to fetch the proper link for the binaries needed.
This PR includes:

fix(dockerfile): ensure dockerfile gets binary

Create .dockerignore

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for this contribution, but its been made redundant by the change to support versions


React slow on iphone6 with Menus and Tabs component

https://material-ui.com/demos/menus/
I used iphone6 to open this page, when I click button to show menus, it feels much slower than the same click on PC.
When I click on my iphone6. It delay 500ms, then the menu showing.
Thanks.

ios version is 9.2.1... It can't install newest chrome browser. Tried newest uc browser seems a little bit faster.

I should try this: https://github.com/ftlabs/fastclick

iOS support starts with Safari 10, by setting the correct meta viewport, you shouldn't have any issue.

https://github.com/ftlabs/fastclick/issues/514#issuecomment-279957025
https://material-ui.com/getting-started/usage/#responsive-meta-tag


LED was very dim when using bitlash

Hi, I use bitlash and send a command:

d7=1   * turn on pin 7
The D7 pin was connected to LED, but I found the LED was very dim.

Then I run arduino IED and upload the sample Blink to test if arduino is OK,I found that the LED was bright as normal.
It's weired. Can anyone help me, thanks.

Ah ,I solved it.
I just add one line:
pinmode(7,1)
then LED was bright as normal.


[EditorSettings/SceneTabs] Added option to restore only active tab.

Hi there!
This pull request implements a small editor feature to restore only the active tab from the previous session, thus changing the editor setting for property interface/scene_tabs/restore_scenes_on_load from a simple boolean to a drop down menu with possible values of None, Active Tab, and All.

All restores all scenes that were open in the previous session. (default; same behavior as old TRUE value)
Active Tab restores only the scene that was active when the previous session was exited.
None doesn't restore anything from the previous session and simply loads the project's main scene, if available. (same behavior as old FALSE value)

(META: As I'm trying to upstream a small patch that I wrote for myself, I haven't written any corresponding proposal in the godot-proposals repo. This is my first Godot PR, so I don't know if a proposal is needed for a patch like this. If so, just let me know and I can go and write one retroactively.)

(META: As I'm trying to upstream a small patch that I wrote for myself, I haven't written any corresponding proposal in the godot-proposals repo. This is my first Godot PR, so I don't know if a proposal is needed for a patch like this. If so, just let me know and I can go and write one retroactively.)

Yes, please open a proposal on https://github.com/godotengine/godot-proposals :slightly_smiling_face:

Ok, here's my proposal. https://github.com/godotengine/godot-proposals/issues/9608

See also https://github.com/godotengine/godot-proposals/issues/4197.

Yeah, this seems to be the same thing.
I missed this during my quick search of the proposals. :smile:


Placing the last tile in a stack crashes the server

To reproduce:

Use a crowbar to pry up one tile
Place the tile back where it was

 ---> Robust.Shared.Utility.DebugAssertException: Tried to get component on a deleted entity.
   at Robust.Shared.Utility.DebugTools.Assert(Boolean condition, String message) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\Utility\DebugTools.cs:line 48
   at Robust.Shared.GameObjects.Entity.TryGetComponent[T](T& component) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\GameObjects\Entity.cs:line 291
   at Robust.Server.GameObjects.ServerEntityManager.AddContainedRecursive(IEntity ent, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 304
   at Robust.Server.GameObjects.ServerEntityManager.AddContainedRecursive(IEntity ent, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 317
   at Robust.Server.GameObjects.ServerEntityManager.IncludeRelatives(IEnumerable`1 children, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 289
   at Robust.Server.GameObjects.ServerEntityManager.UpdatePlayerSeenEntityStates(GameTick fromTick, IPlayerSession player, Single range) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManage
r.cs:line 482
   at Robust.Server.GameStates.ServerGameStateManager.<>c__DisplayClass17_0.<SendGameStateUpdate>g__GenerateMail|0(IPlayerSession session) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameStates\ServerGameStateMa
nager.cs:line 143
   at System.Linq.Parallel.PartitionedDataSource`1.ListContiguousIndexRangeEnumerator.MoveNext(T& currentElement, Int32& currentKey)
   at System.Linq.Parallel.StopAndGoSpoolingTask`2.SpoolingWork()
   at System.Linq.Parallel.SpoolingTaskBase.Work()
   at System.Linq.Parallel.QueryTask.BaseWork(Object unused)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
   --- End of inner exception stack trace ---
   at System.Linq.Parallel.QueryTaskGroupState.QueryEnd(Boolean userInitiatedDispose)
   at System.Linq.Parallel.SpoolingTask.SpoolStopAndGo[TInputOutput,TIgnoreKey](QueryTaskGroupState groupState, PartitionedStream`2 partitions, SynchronousChannel`1[] channels, TaskScheduler taskScheduler)
   at System.Linq.Parallel.DefaultMergeHelper`2.System.Linq.Parallel.IMergeHelper<TInputOutput>.Execute()
   at System.Linq.Parallel.MergeExecutor`1.Execute[TKey](PartitionedStream`2 partitions, Boolean ignoreOutput, ParallelMergeOptions options, TaskScheduler taskScheduler, Boolean isOrdered, CancellationState cancellationState, In
t32 queryId)
   at System.Linq.Parallel.PartitionedStreamMerger`1.Receive[TKey](PartitionedStream`2 partitionedStream)
   at System.Linq.Parallel.UnaryQueryOperator`2.UnaryQueryOperatorResults.GivePartitionedStream(IPartitionedStreamRecipient`1 recipient)
   at System.Linq.Parallel.QueryOperator`1.GetOpenedEnumerator(Nullable`1 mergeOptions, Boolean suppressOrder, Boolean forEffect, QuerySettings querySettings)
   at System.Linq.Parallel.QueryOpeningEnumerator`1.OpenQuery()
   at System.Linq.Parallel.QueryOpeningEnumerator`1.MoveNext()
   at System.Linq.ParallelEnumerable.ToList[TSource](ParallelQuery`1 source)
   at Robust.Server.GameStates.ServerGameStateManager.SendGameStateUpdate() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameStates\ServerGameStateManager.cs:line 175
   at Robust.Server.BaseServer.Update(FrameEventArgs frameEventArgs) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 534
   at Robust.Server.BaseServer.<MainLoop>b__41_0(Object sender, FrameEventArgs args) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 403
   at Robust.Shared.Timing.GameLoop.Run() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\Timing\GameLoop.cs:line 195
   at Robust.Server.BaseServer.MainLoop() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 408
   at Robust.Server.Program.ParsedMain(CommandLineArgs args, Boolean contentStart) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 89
   at Robust.Server.Program.<>c__DisplayClass2_0.<Start>b__0() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 54
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location where exception was thrown ---
   at Robust.Server.Program.Start(String[] args, Boolean contentStart) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 49
   at Robust.Server.ContentStart.Start(String[] args) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\ContentStart.cs:line 10
   at Content.Server.Program.Main(String[] args) in E:\Code\ss14\space-station-14\Content.Server\Program.cs:line 9
Unhandled exception. System.AggregateException: One or more errors occurred. (One or more errors occurred. (Tried to get component on a deleted entity.)) (Tried to get component on a deleted entity.)
 ---> Robust.Shared.Utility.DebugAssertException: Tried to get component on a deleted entity.
   at Robust.Shared.Utility.DebugTools.Assert(Boolean condition, String message) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\Utility\DebugTools.cs:line 48
   at Robust.Shared.GameObjects.Entity.TryGetComponent[T](T& component) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\GameObjects\Entity.cs:line 291
   at Robust.Server.GameObjects.ServerEntityManager.AddContainedRecursive(IEntity ent, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 304
   at Robust.Server.GameObjects.ServerEntityManager.AddContainedRecursive(IEntity ent, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 317
   at Robust.Server.GameObjects.ServerEntityManager.IncludeRelatives(IEnumerable`1 children, HashSet`1 set) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManager.cs:line 289
   at Robust.Server.GameObjects.ServerEntityManager.UpdatePlayerSeenEntityStates(GameTick fromTick, IPlayerSession player, Single range) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameObjects\ServerEntityManage
r.cs:line 482
   at Robust.Server.GameStates.ServerGameStateManager.<>c__DisplayClass17_0.<SendGameStateUpdate>g__GenerateMail|0(IPlayerSession session) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameStates\ServerGameStateMa
nager.cs:line 143
   at System.Linq.Parallel.PartitionedDataSource`1.ListContiguousIndexRangeEnumerator.MoveNext(T& currentElement, Int32& currentKey)
   at System.Linq.Parallel.StopAndGoSpoolingTask`2.SpoolingWork()
   at System.Linq.Parallel.SpoolingTaskBase.Work()
   at System.Linq.Parallel.QueryTask.BaseWork(Object unused)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
   --- End of inner exception stack trace ---
   at System.Linq.Parallel.QueryTaskGroupState.QueryEnd(Boolean userInitiatedDispose)
   at System.Linq.Parallel.SpoolingTask.SpoolStopAndGo[TInputOutput,TIgnoreKey](QueryTaskGroupState groupState, PartitionedStream`2 partitions, SynchronousChannel`1[] channels, TaskScheduler taskScheduler)
   at System.Linq.Parallel.DefaultMergeHelper`2.System.Linq.Parallel.IMergeHelper<TInputOutput>.Execute()
   at System.Linq.Parallel.MergeExecutor`1.Execute[TKey](PartitionedStream`2 partitions, Boolean ignoreOutput, ParallelMergeOptions options, TaskScheduler taskScheduler, Boolean isOrdered, CancellationState cancellationState, In
t32 queryId)
   at System.Linq.Parallel.PartitionedStreamMerger`1.Receive[TKey](PartitionedStream`2 partitionedStream)
   at System.Linq.Parallel.UnaryQueryOperator`2.UnaryQueryOperatorResults.GivePartitionedStream(IPartitionedStreamRecipient`1 recipient)
   at System.Linq.Parallel.QueryOperator`1.GetOpenedEnumerator(Nullable`1 mergeOptions, Boolean suppressOrder, Boolean forEffect, QuerySettings querySettings)
   at System.Linq.Parallel.QueryOpeningEnumerator`1.OpenQuery()
   at System.Linq.Parallel.QueryOpeningEnumerator`1.MoveNext()
   at System.Linq.ParallelEnumerable.ToList[TSource](ParallelQuery`1 source)
   at Robust.Server.GameStates.ServerGameStateManager.SendGameStateUpdate() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\GameStates\ServerGameStateManager.cs:line 175
   at Robust.Server.BaseServer.Update(FrameEventArgs frameEventArgs) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 534
   at Robust.Server.BaseServer.<MainLoop>b__41_0(Object sender, FrameEventArgs args) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 403
   at Robust.Shared.Timing.GameLoop.Run() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Shared\Timing\GameLoop.cs:line 195
   at Robust.Server.BaseServer.MainLoop() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\BaseServer.cs:line 408
   at Robust.Server.Program.ParsedMain(CommandLineArgs args, Boolean contentStart) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 89
   at Robust.Server.Program.<>c__DisplayClass2_0.<Start>b__0() in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 54
   at System.Threading.Tasks.Task.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location where exception was thrown ---
   at Robust.Server.Program.Start(String[] args, Boolean contentStart) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\Program.cs:line 49
   at Robust.Server.ContentStart.Start(String[] args) in E:\Code\ss14\space-station-14\RobustToolbox\Robust.Server\ContentStart.cs:line 10
   at Content.Server.Program.Main(String[] args) in E:\Code\ss14\space-station-14\Content.Server\Program.cs:line 9

Can't replicate on latest master

Nevermind, reproduced.

why is this exclusive to floortiles 🤔

why is this exclusive to floortiles 🤔

Because floor tiles are the only stack item you can place

why is this exclusive to floortiles 🤔

Because floor tiles are the only stack item you can place

are coils of cable different? they are a tile technically right.

are coils of cable different? they are a tile technically right.

Placed cable coils are an entity, tiles however are not since they are special cased.

void IAfterInteract.AfterInteract(AfterInteractEventArgs eventArgs)
{

            Owner.Delete();
}

simply changing the method body to this in FloorTileItemComponent.cs still causes the server to crash.

I think i found the reason why Food doesn't crash the Server but Building does.
It has nothing to do with an item having a Stacksize as far as i can see.
I compared the the "FloorTileItemComponent" with the "FoodComponent".
If a user eats this code will be called if it is from the Inventory:

The Content of the Hand is always replaced. If the food of the User is doesn't have any remains, then nothing is placed in the Hand.
In case of the Tile placement there is nothing placed in the Hand, the Item is simply deleted:

So the true error is that Robust.Shared.GameObjects.EntityManager.RemoveFromEntityTrees is not removing Entitys from Containers. If that is intentional, another way to fix this would be to just place nothing into the hand of the Mob/User. This of course would have the downside of having to remember to do this for every Consumable Item, or the Server crashes.
So what should be done to fix this Bug?


#1911 - ECE response processing notification part 2

ECE Response processing notification part 2

[x] Create a GC Notify template to send emails to integration contacts for ECE

[x] Update ECE Response processing service to save notifications on file processing when the file is present.

[x] Updated the validations in ECE processing service to check for application number to have a valid number as per @JasonCTang

[x] Updated the createFakeApplication as mentioned above to create application as valid number string with fixed length of 10 characters.

[x] Added an interface to GCNotify email payload to have some sort of validation in place.

[x] Added E2E tests for notifications.

[x] Added E2E test for disbursement with multiple detail records(multiple award lines) as per discussions in previous PR https://github.com/bcgov/SIMS/pull/1998

[x] Updated the E2E tests(few) to check for COE status and tuition remittance after the processing is complete as per the discussion in previous PR https://github.com/bcgov/SIMS/pull/1998

Added some comments @dheepak-aot. Thanks for adding the scenarios that we discussed in the test. I think we can also add the new message_payload type to the SaveNotificationModel interface

I added the message_payload type to SaveNotificationModel interface

@dheepak-aot, Thank you for making the adjustments and for sharing the screenshot. 👍 As previously noted a gentle reminder, if you have any concerns with my/devs' comments, kindly let us know first before proceeding to the dev chat and making a decision 😄 . Thanks for understanding 👍

Thanks for understanding too. To be clear the concern is not personal and if it was personal, direct message or call would have been the first thing that I will do. But the concern was about deviating from the path of making the code better which I strongly felt that it is better to share in the group. Having said that I know we are a great team and we will always get better in any given situation. 👍


plotmafSummary error

I've loaded a small maf file, and when I use plotmafSummary, I get this error

Error in seq.default(0, max(colSums(gs.dat)), length.out = 4) :
'to' must be a finite number
In addition: Warning message:
In max(colSums(gs.dat)) : no non-missing arguments to max; returning -Inf

There are two such files which are giving this same error. Although they have data from 3-4 samples, the getSampleSummary lists only the sample with missense mutation for both of them.
Am I getting this error because there is only one sample which has a missense mutation?
Any help appreciated!

Hi,
Please accept my apologies for late reply. Yes, your cohort is way too small for plotting stuffs. Use vs_nonSyn argument while reading maf to define variant classifications.
Plus if you can share your maf file thats causing the error, I might be able to track the issue.


Organizational demo pages

Copied from https://github.com/psu-libraries/researcher-metadata/issues/774#issuecomment-1734420281 we want:
Organizational demo pages that display publications for each organization and paginate in groups of 25, in reverse chronological order by publication date
How will user find the page for the Organization they want? For now we would just use the Org's ID in the URL so we can predict the URL and provide it as needed.
Within the Libraries, we'd want to implement our own page pulling content from the API. But, we won't be able to do this immediately, so we would link out to the demo page in the meantime.

@ajkiessl One more thought I had after looking at the preview -- could you add contact details in the footer so folks know whom to contact about corrections/errors? I'm thinking something like "With corrections or questions, please contact Faculty Activity Management Services, University Libraries<EMAIL_ADDRESS>I'm suggesting the FAMS contact info since that's what's on the main page and I think they are best placed to handle most errors with these publication lists, but tagging @nmg110 in case she disagrees. If Nicole prefers, we can do ""With corrections or questions, please contact Scholarly Communications and Copyright, University Libraries<EMAIL_ADDRESS>

@anaelizabethenriquez I am good with what @ajkiessl has. Most of the time it is an issue with their Activity Insight data anyway. :-)


Table for oauth2 consumers (logins) is not responsive

The table on the profile page listing the OAuth2 provider tokens used to log in to amelie is not responsive.

This seems to be fixed already.


Tag -> Version standarization

This code tries to explain that we really work on git tags, and that in both Goreleaser and Godownloader we assume the tag to be a version that might have a v prefix.
Another subtle change is that this code now supports the Checksum.NameTemplate for fetching the Checksum file.
Additionally, with this update the sample scripts now work when fetching these project's latest releases with two exceptions:

event-gateway just changed their config but haven't cut a new release with zips: https://github.com/serverless/event-gateway/commit/7e9ffbf895e3389f9d4c3dc9a802d5a7c2a031aa
misspell hasn't cut a release since this commit in goreleaser, which means their release doesn't match our defaults anymore: https://github.com/goreleaser/goreleaser/commit/c541d99c58658a5888ff9bf3b5401fd7f104d965

In order to fix these failures I believe we would need to make Godownloader much more intelligent at consuming the GitHub Release API. I'm more than happy to keep working on this to solve these two failures; I just wanted your feedback first on what you think about all of this and how I can help.

2018/02/17 23:34:07 Reading https://raw.githubusercontent.com/goreleaser/goreleaser/master/goreleaser.yml
2018/02/17 23:34:07 Reading https://raw.githubusercontent.com/goreleaser/goreleaser/master/.goreleaser.yml
2018/02/17 23:34:07 failed: unable to parse: goreleaser.yml file not found
make: *** [build] Error 1

isn't particularly helpful and figuring out what went wrong. we should probably fix that.

Definitely need to start writing some tests for these methods, but here's a local test when I override those strings to be broken:
18:55 $ make ci
cp -f scripts/lint.sh .git/hooks/pre-commit
go build
./scripts/build_samples.sh
+ ./godownloader -repo gohugoio/hugo
2018/02/17 18:55:40 Reading https://raw.githubusercontent.com/gohugoio/hugo/master/broken-goreleaser.yml
2018/02/17 18:55:41 Reading https://raw.githubusercontent.com/gohugoio/hugo/master/broken-.goreleaser.yml
2018/02/17 18:55:41 broken-goreleaser.yml had error: 404: Not Found
2018/02/17 18:55:41 broken-.goreleaser.yml had error: 404: Not Found
2018/02/17 18:55:41 failed: unable to parse: could not fetch a goreleaser configuration file
Makefile:33: recipe for target 'build' failed
make: *** [build] Error 1

+./godownloader -repo gohugoio/hugo
2018/02/18 01:28:49 Reading https://raw.githubusercontent.com/gohugoio/hugo/master/goreleaser.yml
2018/02/18 01:28:49  info 	generating changelog
2018/02/18 01:28:49  info 	releasing to GitHub
2018/02/18 01:28:49  info 	creating archives
2018/02/18 01:28:49  info 	building binaries
2018/02/18 01:28:49  info 	creating Linux packages with fpm
2018/02/18 01:28:49  info 	calculating checksums
2018/02/18 01:28:49  info 	creating Docker images
2018/02/18 01:28:49  info 	creating homebrew formula
+./godownloader -repo goreleaser/goreleaser
2018/02/18 01:28:49 Reading https://raw.githubusercontent.com/goreleaser/goreleaser/master/goreleaser.yml
2018/02/18 01:28:49 Issue reading https://raw.githubusercontent.com/goreleaser/goreleaser/master/goreleaser.yml returned: 404 Not Found
2018/02/18 01:28:49 Reading https://raw.githubusercontent.com/goreleaser/goreleaser/master/.goreleaser.yml
2018/02/18 01:28:49 failed: unable to parse: unknown fields in the config file: scoop, nfpm, snapcraft.name_template, docker[0].tag_templates
make: *** [build] Error 1

error handling works: https://travis-ci.org/goreleaser/godownloader/builds/342895674

LGTM, thanks!


CocoaPods could not find compatible versions for pod

Describe the bug
Specs satisfying the AgawebStripe (from ../node_modules/@agaweb/react-native-stripe) dependency were found, but they required a higher minimum deployment target.
To Reproduce
Steps to reproduce the behavior:

Go to 'ios folder'
Click on 'pod install'
See error

@WEETECHDEV check out the "requirements" section, does your project use ios 11.0 as minimum deployment target?

@NicholasBertazzon

Podfile not there

@NicholasBertazzon Yes, Done pod install after clean build folder again I generated podfile and install
Generating Pods project
Integrating client project
Pod installation complete! There are 48 dependencies from the Podfile and 64 total pods installed.

Good, in case anyone in the future come out with the same error: check your deployment target in the podfile


Edit COS LSF.ipynb notebook

Made edits for some file downloads to work with astroquery
PEP8 changes
Edits on comments, updated markdown links/references
Changed figures to match updated website

The notebook's style errors have been successfully addressed.


Added created by and when

Added that Brendan Eich created JS in may of 1995.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@samfultonschool thanx for your contribution :balloon:


HTML escaping causes malformed profile response

If you set the username on a social account to a string containing special characters, something goes very wrong (probably around here) and causes the profile endpoint to return invalid json:
                "username": "\"><test", "proof_url":="" ""="" }="" },="" "moderation_fee":="" 10.0,="" "moderator":="" false,="" "nsfw":="" false,="" "handle":="" "",="" "guid":="" "7c0c581c5224f22f41d0218998a12e98f1ee361a",="" "background_color":="" 407379,="" "secondary_color":="" 3243448,="" "location":="" "na",="" "short_description":="" "test\"=""><"```

What special characters are you trying to put in?

In this case I set my instagram username to "><test.

Probably just need to check it client side @jjeffryes

I don't think you should ever be able to get the server to reply with invalid json -- this definitely seems like a server bug to me.

We will need to do sanitization on both sides, server and client, since you can send data directly to the server without a client (or with a custom client).
We'll need a fairly robust whitelist solution, one that strips all non-alphanumeric or punctuation characters but allows whitelisted tags. The currently allowed tags in the client are
'h2','h3', 'h4', 'h5', 'h6', 'p', 'a','u','ul', 'ol', 'nl', 'li', 'b', 'i', 'strong', 'em', 'strike', 'hr', 'br', 'img', 'blockquote'

I put in an issue on the client side to extend sanitizing to all inputs.

Okay, but we should definitely deal with this issue of the server returning a malformed response. This:  "proof_url":="" ""="" }="" should never happen.

Agreed on preventing malformed responses. That's Chris's department.

It's also possible to add / modify data directly in database or line protocol between servers via modified or completely custom server code. All of those things need to be counted.

I think this has been fixed @cpacia ?

Fixed


Handling phantomCamerahosts with swapping character scenes

Issue description
While its not currently an issue with multiplayer implementation where changing character controllers (changing from playable character to spectator character on death) causes the "Only one PhantomCameraHost can exist in a scene
Multiple PhantomCameraHosts will be supported in https://github.com/MarcusSkov/phantom-camera/issues/26" error to occur. While I did see the links contents I'm wondering if there is a work around for switching character controllers while not encountering this issue while waiting for that update the time being. (since only one cam controller should be active anyhow.)
Steps to reproduce

Use Untrue plugin
Slot working character with controls and camera built in
use Game.get_gamemode().player_character_scene = [call to spectator scene] to swap character controller with different one via a trigger (in this case when player hp reaches 0)
Error occurs. WASD and jumping still works but camera becomes a fixed pov. Moving the mouse still causes input direction to change like you can still look around however

(Optional) Minimal reproduction project
I'm new to coding so I'm not sure what I can pull out and the issue will still be replicable. If you can't replicate the error above though I can upload the full project on request.

Think the solution you're looking for depends on how you've set up your scene.
You mention multiplayer, and to paraphrase what you've said just to make sure I understand it correctly, is your goal to you switch between 2 cameras. One for when the player is alive to another upon reaching 0 hp?


Add documentation for JSON config file structure.

This adds an example of what the config file might look like to the README.

I just made changes to the readme, so I find a build failure surprising. Looking at the log, it doesn't seem to be related to this PR.

@LoganBarnett that's a good point, I've merged this in 7b002a9740 (and also added an additional section which also mention that the default options can be also included in a package.json "flow-coverage-report" property).


Support wider ray version range in requirements

Currently ray is pinned to 1.13 but we should support a range of versions. ideally [1.8 -> 2.0]

Closed with #337


Dtls13 encrypt sequence numbers

These changes implements dtls 1.3 record number encryption reference:
https://www.rfc-editor.org/rfc/rfc9147.html#name-record-number-encryption
The base functionality added is covered by the functions:
dtls_crypt_sequence_number(): This function implements the encryption of the sequence number
ssl_cipher_get_evp_cipher_ecb(): This function fetches an ecb cipher for the sequence number encryption
dtls13_derive_snkey(): This function derives a key for sequence number encryption

@t8m @mattcaswell
This one is ready for review.
There is a test failure that is relevant. But I'm pretty sure the code is correct. Maybe you have a better understanding of what might be wrong?
If not I'll dig some more.

There is a test failure that is relevant. But I'm pretty sure the code is correct. Maybe you have a better understanding of what might be wrong?
If not I'll dig some more.

Not sure what could be wrong here as the key schedule seems to be set unconditionally IMO the only possibility is that the input data (i.e., some bytes within rl->packet + 13 up to 16 bytes of length), is uninitialized.

Thanks a lot @t8m !
Turns out the test case fiddles with the length field of the record and thus the record data was not initialized. This one is ready for review.

@vdukhovni thanks for the review. Just noting that I've seen your comments and hope to have time next week to address them.

Thanks, would be great if you find the time.

@vdukhovni thanks for the review. Just noting that I've seen your comments and hope to have time next week to address them.

Thanks, would be great if you find the time.

I've marked the suggestions that I have addressed as resolved. I need to look at your comment about lengths tomorrow.

@t8m please reapprove

This pull request is ready to merge


Tested locally without frontend

When we change the : Available projects in .env file , it get reflects in /project
Front end is not maintained as before

Here we changed AVAILABLE PROJECTS in .env file

Our /project is changed
Also in installation guide it would be great to mention that Contributor should use python 3.9 as python 3 (default one) makes it  complex to set up in linux. I spent bunch of hours fixing that.

Update the frontend:

Functionality to redirect to repo :
https://github.com/user-attachments/assets/33332256-fcdf-4d58-b7ad-48b0a74272b7
Regarding maintainer name:
{
"id": 144955661,
"node_id": "MDEwOlJlcG9zaXRvcnkxNDQ5NTU2NjE=",
"name": "ContriHub-18",
"full_name": "ContriHUB/ContriHub-18",
"private": false,
"owner": {
"login": "ContriHUB",
"id": 42784838,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjQyNzg0ODM4",
"avatar_url": "https://avatars.githubusercontent.com/u/42784838?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ContriHUB",
"html_url": "https://github.com/ContriHUB",
"followers_url": "https://api.github.com/users/ContriHUB/followers",
"following_url": "https://api.github.com/users/ContriHUB/following{/other_user}",
"gists_url": "https://api.github.com/users/ContriHUB/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ContriHUB/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ContriHUB/subscriptions",
"organizations_url": "https://api.github.com/users/ContriHUB/orgs",
"repos_url": "https://api.github.com/users/ContriHUB/repos",
"events_url": "https://api.github.com/users/ContriHUB/events{/privacy}",
"received_events_url": "https://api.github.com/users/ContriHUB/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
I think owner=>login should be the name of the maintainer , but every where it is ContriHUB .

Kindly check sir

@meisabhishekpatel Is there any issue sir  ?

closing this issue.


fix: modify import path in demo code of python api docs.

The project zksync2-python has update to V0.4.0, but the docs is not updated.
This commit updates two places:

modify import path in demo code of python api docs
modify Web3.toWei to Web3.to_wei

Hi @a3roger we are in the process of completely updating the Python SDK. Please keep your eye on the docs for the update https://era.zksync.io/docs/api/python. Thanks for the PR.


i would like a plugin that can backup/restore Redis

Feature request to create a redis plugin for cfops

Implemented plugin for cfops - http://www.cfops.io/plugins/redis-plugin/


coredns: support reverse DNS lookups i.e PTR records

Add support for reverse DNS lookups for internal containers.
If user does dig -x container-ip it should return a single PTR record
with either containername or alias name.

@baude Following PR should make reverse lookup work.

This is already merged.


CI:

CI failure

Set title to be in the format CI: <test-name>.
Copy-paste the output the test failure.
Upload the zip file generated from that test failure.
Copy-paste the link of the CI build where that test failure has happen.
Include any output from logs that you think may be relevant (to ease GitHub searches).

@rainlay001 Was opening this issue intentional?

Going to close for now as the description is empty, feel free to reopen later.


Posture Breaker is too loud

I enchanted my bow with power and it gave me Posture Breaker with it. This wouldn't be an issue if it didn't play a sound that's way louder than every other sound in the game every time I shoot a mob.
I could lower the game volume but then everything is quiet. And because enchanting tables are random I have to waste XP to get a bow without this enchantment.

What version is this? The bow shouldn't be able to get Posture Breaker in the newest, which is the optimal one and where the sound should have been lowered. Consider updating if you're not using the newest 1.0.2 version.


Make more templates translateble

Codecov Report

Merging #2545 (8861efe) into main (c3c2f95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2545   +/-   ##
=======================================
  Coverage   81.17%   81.17%
=======================================
  Files         636      636
  Lines       23188    23188
=======================================
  Hits        18824    18824
  Misses       4364     4364

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c2f95...8861efe. Read the comment docs.


dframe conversion to string in _dataframe_client.py does not support unicode

We discovered this while trying to process a field of string type that included the degree character, °.
We hacked a patch by replacing any call dframe.astype(str) with dframe.astype(unicode) within _stringify_dataframe().

Would you be willing to prepare a patch for this issue (and a test)? If not, I should be able to get to it this week. Thanks for reporting!

We were far from certain if our hack was the best way to fix the issue.
And, we are not at all familiar with the test suite for the project. While
we would love to help more, we feel we’re not the best source for
correcting the problem and contributing to the project beyond reporting
this problem.
Thank you for following up.
On Oct 31, 2017, at 7:24 AM, xginn8<EMAIL_ADDRESS>wrote:
Would you be willing to prepare a patch for this issue (and a test)? If
not, I should be able to get to it this week. Thanks for reporting!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb-python/issues/521#issuecomment-340746296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA__5iJKIMZ0gOpObQlIyQ6XpyTo_vPGks5sxxFvgaJpZM4QDaF1
.


FBX linked mesh import with wrong origin [4.4.dev2]

Tested versions

Reproducible in: 4.4.dev2

System information
Windows 10 - v4.4.dev2.official [97ef3c837] - GLES 3.0.0 Angle (Compatibility) [Inteal R HD Graphics (0x00000102) Direct3D 11 vs__4_1 ps_4_1, D3D11-<IP_ADDRESS>59]]
Issue description

(Left: .OBJ) (Right: .fbx)
When importing a model in FBX format that has a linked mesh, it only imports the original.

Steps to reproduce
Just import a model in fbx format with some meshes linked into the project.
Minimal reproduction project (MRP)
N/A

Can you try to provide a mrp project?

Can you try to provide a mrp project?

Can I try to send the blender model?

https://github.com/QJPG/mrp-fbx-model
In blender it looks like this:

Please provide your full import settings as well

Please provide your full import settings as well

Done

My first look suggests that this is a fbx-blender export. Can you check? I don't think blender exports valid fbx files.
I will try https://blendermarket.com/products/better-fbx-importer--exporter

Will link upstream as I have no idea.

Minha primeira olhada sugere que esta é uma exportação fbx-blender. Você pode verificar? Não acho que o blender exporte arquivos fbx válidos.
Vou tentar https://blendermarket.com/products/better-fbx-importer--exporter

The version of Blender that I use is 2.79.7
The FBX importer I used is the program's default. I've had some problems importing models with bones in this version into Godot, but with FBX it's less problematic.

bqq

Tested instancing; issue occurs in ufbx viewer as well.
Problem identified as instanced skinned meshes not being supported due to the skin deformer being attached to the mesh itself, not the instance.

iFire

Feels the feature should be supported but acknowledges it might be a Blender bug.
Tested in Blender 4.2; FBX export still broken.
Suggests using Maya, 3ds Max, or Cinema 4D to verify if the issue is with Blender's export.
Proposes using glTF format as a workaround.

Conclusion
Verify the FBX file in other software (Maya, 3ds Max, Cinema 4D). If the issue persists, conclude it's a Blender export problem and recommend using glTF instead.

The fbx opens correctly in maya.

@bqqbarbhg checked unity and it broke in the same way. We discussed this feature and came to conclusion all the downstream viewers of ufbx broke in this way. Maya worked.
We wish to document the instanced skinned meshes limitation, but there's not much will and resources to do a permanent enhancement.

btw I'm facing a very similar issue: I export a simple object (as simple as a cube), but it's not positioned right in the middle of my Blender file (it's part of a bigger structure). it should use its own Origin, which is just at the middle of the bottom side. However, exporting as FBX or gITF, it always goes into Godot using the global 3D origin instead.
I am using Godot 4.3 and Blender 4.2

Can you post a new report with a MRP test project?


Supported Qt Creator version

Which Qt Creator version is supported?
I tried to build Nim Plugin with 3.4.2 on Linux/gcc, but got tons of errors.

Have you read the build instructions? i was able to build it this morning with the latest QtCreator branch

Grab the current QtCreator master branch e put yourself at commit abec43e7d32b5ded1b598e6f3accd8e389eb1db5
Build QtCreator out of source
Follow the instructions on the my repo Readme

Thanks. With Qt Creator from git works.

I'll close this as solved


Document TypeScript 2.5 checkJs cast syntax

TypeScript 2.5 introduced a new JSDoc-based cast syntax that looks like this:
var x = /** @type {SomeType} */ (AnyParenthesizedExpression);

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-5.html#type-assertioncast-syntax-in-checkjsts-check-mode
It was documented in the announcement, but not anywhere else. This adds it to the "Type Checking JavaScript Files" page, which is probably the best place for it to go.

I think this is better be added to https://github.com/Zarel/TypeScript-wiki/blob/a1749c93e32e5e6deb5b2fc4ab71cc2a9897afed/JSDoc-support-in-JavaScript.md instead.

This is, as far as I can tell, a departure from how JSDoc is intended to be used, so this seems like the right place? For comparison, @augments is also documented here and not there.
Or maybe they should be in both places?

I've opened upp #155, and filed an issue for documenting @extends/@augments at #154.


Assigning maintainers against tests.

High-level description
Define a Concept of Test Owners for Tests in DCOS/DCOS
https://jira.mesosphere.com/browse/DCOS-20355
When a status check fails, we should make it easy for a developer to be self-sufficient, by helping the developer in identifying the purpose of the test, and provide information on the maintainer for the test.
Along those lines, we'd like to give information about the various pull request statuses and also give a _maintainer_ information for the module. These could be useful when reviewing, assigning reviewers, or assisting with test failures.
Please Review
Please review this PR and share your feedback.

I have assigned members from teams who, I thought, have worked on that piece of code.
If a different maintainer is desired, please comment on this.
Similar exercise will be done for the dcos-enterprise as well.

@vespian  - I have removed adam and included only active committers.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review

@mesosphere-mergebot bump-ee


Added clone method

Added the clone method and documentation along with tests.

@salexzee, removed if statement.

You removed the wrong if statement.
if (this.isObject(obj)) { :arrow_backward: Keep
if (null == obj || "object" != typeof obj) { is the one to drop :arrow_backward: Remove
What I was trying to explain is that isObject() already checks for null and makes sure it is a valid object so you don't need to manually check it.

Sorry @salexzee, I misunderstood you. It should be good now.

Sweet! Thanks


issue: charge threshold not working after waking up from sleep

Subject of the issue
Charge threshold persistence not working after sleep
Your system
OS: Ubuntu 23.10 (mantic)
Host: Asus TUF A15 FA506IH
Kernel: 6.5.0-13-generic
Version
0.14 (Latest)
Steps to reproduce

set charge threshold
persist the charge threshold
send the host machine to sleep
wake up the machine

Expected behaviour
The persisted threshold should work
Actual behaviour
The charge threshold is not working at all unless set again

How do you "send the host machine to sleep"?
In any case, I think it might be because sleep is used in the persist settings. To test if this is the case, do wget good4.eu/bat; chmod +x bat; sudo ./bat persist and see if that fixes the issue.

Also the threshold works fine while the machine is in sleep and stops working as soon as the machine wakes up.

Reloading the driver resets the threshold value. The unit files /etc/systemd/system/bat-* together with /etc/systemd/system/*.wants/bat-* should take care of that.
What does /var/log/system look like right after coming back from sleep. What are the lines after the line System returned from sleep state., do you have Starting Persist the battery charging threshold after suspend...?

/etc/systemd/system/bat-hybrid-sleep.service
[Unit]
Description=Persist the battery charging threshold after hybrid-sleep
After=hybrid-sleep.target
StartLimitBurst=0

[Service]
Type=oneshot
ExecStart=/usr/bin/sh -c 'echo 60 > /sys/class/power_supply/BAT1/charge_control_end_threshold'
Restart=on-failure
RemainAfterExit=true

[Install]
WantedBy=hybrid-sleep.target

/etc/systemd/system/hybrid-sleep.target.wants/chargelimit-hybrid-sleep.service
[Unit]
Description=Persist the battery charge limit after hybrid-sleep
After=hybrid-sleep.target
StartLimitBurst=0

[Service]
Type=oneshot
ExecStart=/usr/bin/sh -c 'echo 60 >/sys/class/power_supply/BAT1/charge_control_end_threshold'
Restart=on-failure
RemainAfterExit=true

[Install]
WantedBy=hybrid-sleep.target

No trace of battery persistent in syslog after waking up.

So in /var/log/syslog after the line System returned from sleep state. you must have soon after that: Reached target Suspend.. On my system I have right after that Starting Persist the battery charging threshold after suspend....
What does sudo systemctl status bat-suspend.service give?

There is no trace of Starting Persist the battery charging threshold after suspend..., I also tried to search in the logs file. The bat-suspend.service is active.
/var/log/syslog
2023-11-27T15:01:03.013980+05:30 23 systemd[1]: Reached target suspend.target - Suspend.
2023-11-27T15:01:03.015894+05:30 23 ModemManager[1297]: <info>  [sleep-monitor-systemd] system is resuming
2023-11-27T15:01:03.046468+05:30 23 kernel: [15215.439762] Generic FE-GE Realtek PHY r8169-0-200:00: attached PHY driver (mii_bus:phy_addr=r8169-0-200:00, irq=MAC)
2023-11-27T15:01:03.062648+05:30 23 NetworkManager[1089]: <info>  [1701077463.0155] manager: sleep: wake requested (sleeping: yes  enabled: yes)
2023-11-27T15:01:03.063293+05:30 23 NetworkManager[1089]: <info>  [1701077463.0158] device (enp2s0): state change: unmanaged -> unavailable (reason 'managed', sys-iface-state: 'external')
2023-11-27T15:01:03.063529+05:30 23 systemd[1]: Starting grub-common.service - Record successful boot for GRUB...
2023-11-27T15:01:03.067127+05:30 23 systemd[1]: Starting nvidia-resume.service - NVIDIA system resume actions...
2023-11-27T15:01:03.071577+05:30 23 suspend: nvidia-resume.service
2023-11-27T15:01:03.071714+05:30 23 logger[88302]: <13>Nov 27 15:01:03 suspend: nvidia-resume.service
2023-11-27T15:01:03.074870+05:30 23 systemd[1]: Stopped target suspend.target - Suspend.
2023-11-27T15:01:03.080368+05:30 23 systemd[1]: nvidia-resume.service: Deactivated successfully.
2023-11-27T15:01:03.081143+05:30 23 systemd[1]: Finished nvidia-resume.service - NVIDIA system resume actions.
2023-11-27T15:01:03.087695+05:30 23 systemd[1]: grub-common.service: Deactivated successfully.
2023-11-27T15:01:03.088092+05:30 23 systemd[1]: Finished grub-common.service - Record successful boot for GRUB.
2023-11-27T15:01:03.091526+05:30 23 systemd[1]: Starting grub-initrd-fallback.service - GRUB failed boot detection...
2023-11-27T15:01:03.102964+05:30 23 systemd[1]: grub-initrd-fallback.service: Deactivated successfully.
2023-11-27T15:01:03.103600+05:30 23 systemd[1]: Finished grub-initrd-fallback.service - GRUB failed boot detection.
2023-11-27T15:01:03.187569+05:30 23 gnome-shell[3264]: Window manager warning: Overwriting existing binding of keysym 35 with keysym 35 (keycode e).
2023-11-27T15:01:03.187764+05:30 23 gnome-shell[3264]: Window manager warning: Overwriting existing binding of keysym 31 with keysym 31 (keycode a).
2023-11-27T15:01:03.187816+05:30 23 gnome-shell[3264]: Window manager warning: Overwriting existing binding of keysym 32 with keysym 32 (keycode b).
2023-11-27T15:01:03.187877+05:30 23 gnome-shell[3264]: Window manager warning: Overwriting existing binding of keysym 33 with keysym 33 (keycode c).
2023-11-27T15:01:03.187922+05:30 23 gnome-shell[3264]: Window manager warning: Overwriting existing binding of keysym 34 with keysym 34 (keycode d).

bat-suspend.service
● bat-suspend.service - Persist the battery charging threshold after suspend
     Loaded: loaded (/etc/systemd/system/bat-suspend.service; enabled; preset: enabled)
     Active: active (exited) since Mon 2023-11-27 09:23:54 IST; 5h 45min ago
   Main PID: 4447 (code=exited, status=0/SUCCESS)
        CPU: 5ms

Nov 27 09:23:54 23.10 systemd[1]: Starting bat-suspend.service - Persist the battery charging threshold after suspend...
Nov 27 09:23:54 23.10 systemd[1]: Finished bat-suspend.service - Persist the battery charging threshold after suspend.

All this would not be necessary if the driver would just accept a parameter to set the charge limit...
We need a systemd expert to get this to work I guess. Side note, I am on 22.04, you seem to be on 23.10, so the systemd version is different.

All this would not be necessary if the driver would just accept a parameter to set the charge limit...
We need a systemd expert to get this to work I guess. Side note, I am on 22.04, you seem to be on 23.10, so the systemd version is different.

Yes. I was also using it on 22.04 Jammy and it was working perfectly fine.

I found this service inactive, but I can't enable it.
○ chargelimit-suspend.service - Persist the battery charge limit after suspend
     Loaded: loaded (/etc/systemd/system/chargelimit-suspend.service; enabled; preset: enabled)
     Active: inactive (dead)

I found this service inactive, but I can't enable it.

What you can try is bat reset (with the installed binary) and then sudo ./bat remove (with the downloaded binary) followed by sudo ./bat persist. Then see what the output is of ./bat.

There must be something in the requirements for the systemd unit files that changed so they no longer work in the 23.10 version...

There must be something in the requirements for the systemd unit files that changed so they no longer work in the 23.10 version...

Yes, most likely.

Try putting this in /usr/lib/systemd/system-sleep/bat:
#!/bin/sh
test "x$1" = "xpost" &&
  /usr/bin/echo 60 >/sys/class/power_supply/BAT1/charge_control_end_threshold
exit 0

Try putting this in /usr/lib/systemd/system-sleep/bat:
#!/bin/sh
test "x$1" = "xpost" &&
  /usr/bin/echo 60 >/sys/class/power_supply/BAT1/charge_control_end_threshold
exit 0

And make it executable: sudo chmod +x /usr/lib/systemd/system-sleep/bat

Worked! Thank you very much 😄

@pepa65 do you think this is a more robust way to set the threshold after sleep or is it enough of an edge case to leave things as is?

I have added it as an additional way to persist the threshold, just write that file on Persist and delete it on Reset.

I’ll mark this issue as resolved and if more people have the same problem maybe we’ll go with that too.


[FLINK-20921][python] Support SqlTimeTypeInfo in Python DataStream

What is the purpose of the change
This pull request Support SqlTimeTypeInfo in Python DataStream
Brief change log

Support SqlTimeTypeInfo in Python DataStream

Verifying this change
This change added tests and can be verified as follows:

Added relational UT in PythonTypeUtilsTest
Added IT in test_sql_timestamp_type_info in test_data_stream.py

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@WeiZhong94 Thanks a lot for the review. I have addressed the comments at the latest commit.

@WeiZhong94 Thanks a lot for the review. I have addressed the comments at the latest commit.


templatePath option to specify path to template

closes #6

Hey @vadzim
Thanks for the PR. It only seems to implement part of #6. I'm currently testing some code that will implement all but I don't have an ETA for releasing it.


Support advanced options in Command Line args

Is your feature request related to a problem? Please describe.
As of now when opening a new connection via command line arguments to open Azure Data Studio, only limited primary options are supported that are universal to all providers e.g.:
azuredatastudio://connect?server=*****&provider=*****&user=*****&authenticationType=*****
Describe the solution or feature you'd like
Users should be able to pass advanced options supported by the provider that can be used for creating connection.

Closing are changes are checked in.


Support generating soci indexes for all or some platforms in a multi-arch Image

Thanks for a great tool! soci indexes have made a big improvement to our task startup times, and this has been the easiest way for us to generate them in CI where containerd isn't available.
One gap we've noticed that would be super helpful would be to support creating soci indexes for multi-arch images. For example, we run the datadog agent in many tasks and the image that's pulled from docker hub looks like this:

We reference it in task definitions via the tag that points to the image index (dddddddddddd.dkr.ecr.us-east-1.amazonaws.com/ecr-public/datadog/agent:7.49.0). The four sub-images are different platforms (linux amd64, linux arm64, etc), and fargate pulls just the one it needs.
However, when we try to generate the soci index we get an error:
./standalone-soci-indexer dddddddddddd.dkr.ecr.us-east-1.amazonaws.com/ecr-public/datadog/agent:7.49.0
{"level":"info","time":"2024-03-20T22:59:18+11:00","message":"Indexing and pushing ecr-public/datadog/agent:7.49.0 to dddddddddddd.dkr.ecr.us-east-1.amazonaws.com"}
{"level":"info","RegistryURL":"dddddddddddd.dkr.ecr.us-east-1.amazonaws.com","time":"2024-03-20T22:59:18+11:00","message":"Initializing registry client"}
{"level":"warn","RegistryURL":"dddddddddddd.dkr.ecr.us-east-1.amazonaws.com","time":"2024-03-20T22:59:20+11:00","message":"Image manifest validation error: Empty config media type."}

We can work around it by creating a tag that points directly to the image we want:
skopeo copy --all --preserve-digests \
  docker://dddddddddddd.dkr.ecr.us-east-1.amazonaws.com/ecr-public/datadog/agent@sha256:9a161b6fc2f8ef74bb368f56edcac33a91b494d082da3693a600751a1a68b7d8 \
  docker://dddddddddddd.dkr.ecr.us-east-1.amazonaws.com/ecr-public/datadog/agent:7.49.0-amd64

Then creating the soci index works:
./standalone-soci-indexer dddddddddddd.dkr.ecr.us-east-1.amazonaws.com/ecr-public/datadog/agent:7.49.0-amd64

Fargate tasks seem to use this soci index, which is great. It'd be helpful to have a way to generate the soci index without the tag shenanigans though.

Sorry for missing this. I didn't have a watch on the repo. I do now.
Is there an easy way I can get one of those multi-arch Datadog images into my ECR for testing?
Alternatively, PRs would be welcome for this.

The easiest way is probably to setup ECR with a pull through cache for the ECR public gallery:

Assuming you choose a repository prefix of ecr-public, it should be possible to populate the registry with a datadog image by doing:
docker pull dddddddddddd.dkr.ecr.<region>.amazonaws.com/ecr-public/datadog/agent:7.49.0

This should pull the image from https://gallery.ecr.aws/datadog/agent

brilliant, thanks! We'll test out 1.0.2 and let you know how it goes

Confirmed: we were able to point standalone-soci-indexer v1.0.2 at the image manifest, and it generated soci indexed for all the images in a loop ❤

Awesome! I'm glad to hear it worked.
For future reference, I used this command to get a testable image:
docker run quay.io/skopeo/stable copy --all docker://public.ecr.aws/datadog/agent:7.49.0 docker://1234567890.dkr.ecr.us-east-1.amazonaws.com/soci-test:latest --dest-creds ...


Allow users to bundle node_modules

Please notice that I had to rebase this PR on top of #576 so that we can actually parse streaming responses from Kibana.

Summary
This PR allows users to bundle modules into the scripts they push.
I've marked it as draft as it still needs E2E tests.
How to test this PR
To test this PR, try including a JS library into your journey, by importing it into the journey file.
Then push your journey with the extra imported module to Kibana.
You should be able to run the Journey just fine.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-17T17:22:46.512+0000

Duration: 8 min 58 sec

Test stats :test_tube:

Test
Results

Failed
6

Passed
173

Skipped
2

Total
181

Test errors
Expand to view the tests failures
Test / Bundler build journey – Bundler build journey

Expand to view the error details
 null

Expand to view the stacktrace
 Error: Build failed with 1 error:
asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/e2e/uptime.journey.ts:27:18: ERROR: Could not resolve "axios"
    at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
    at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
    at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
    at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
    at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

Test / Monitors api schema – Monitors api schema

Expand to view the error details
 null

Expand to view the stacktrace
 Error: Build failed with 1 error:
asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/fixtures/example.journey.ts:26:30: ERROR: [plugin: esbuild-multiasset-plugin] Build failed with 1 error:
node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"
    at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
    at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
    at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
    at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
    at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:315:12)

Test / Monitors build monitor schema monitor – Monitors build monitor schema monitor

Expand to view the error details
 null

Expand to view the stacktrace
 Error: Build failed with 1 error:
asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/fixtures/example.journey.ts:26:30: ERROR: [plugin: esbuild-multiasset-plugin] Build failed with 1 error:
node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"
    at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
    at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
    at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
    at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
    at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:315:12)

Test / Plugin bundle jouneys – Plugin bundle jouneys

Expand to view the error details
 null

Expand to view the stacktrace
 Error: Build failed with 1 error:
asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/e2e/uptime.journey.ts:27:18: ERROR: Could not resolve "axios"
    at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
    at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
    at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
    at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
    at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
    at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
    at Socket.emit (node:events:527:28)
    at addChunk (node:internal/streams/readable:315:12)

Test / Push API handle streamed response – Push API handle streamed response

Expand to view the error details
 null

Expand to view the stacktrace
 Error: expect(received).toMatchSnapshot()

Snapshot name: `Push API handle streamed response 1`

- Snapshot  -  5
+ Received  + 25

  > preparing all monitors
- > creating all monitors
- > chunk 1
- > chunk 2
- > chunk 3
- ✓ Pushed
+ Error: Build failed with 1 error:
+ asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/push/new-project/test.journey.ts:1:31: ERROR: [plugin: esbuild-multiasset-plugin] Build failed with 1 error:
+ ../../../node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"
+     at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
+     at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
+     at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
+     at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
+     at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
+     at Socket.emit (node:events:527:28)
+     at Socket.emit (node:domain:475:12) {
+   errors: [
+     {
+       detail: [Error],
+       location: [Object],
+       notes: [Array],
+       pluginName: 'esbuild-multiasset-plugin',
+       text: 'Build failed with 1 error:\n' +
+         '../../../node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"'
+     }
+   ],
+   warnings: []
+ }
  ↵
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/push/index.test.ts:217:22)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Test / Push API handle sync response – Push API handle sync response

Expand to view the error details
 null

Expand to view the stacktrace
 Error: expect(received).toMatchSnapshot()

Snapshot name: `Push API handle sync response 1`

- Snapshot  -  2
+ Received  + 25

  > preparing all monitors
- > creating all monitors
- ✓ Pushed
+ Error: Build failed with 1 error:
+ asset:/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/push/new-project/test.journey.ts:1:31: ERROR: [plugin: esbuild-multiasset-plugin] Build failed with 1 error:
+ ../../../node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"
+     at failureErrorWithLog (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1599:15)
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1245:28
+     at runOnEndCallbacks (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1030:63)
+     at buildResponseToResult (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1243:7)
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:1352:14
+     at /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:662:9
+     at handleIncomingPacket (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:759:9)
+     at Socket.readFromStdout (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/node_modules/esbuild/lib/main.js:629:7)
+     at Socket.emit (node:events:527:28)
+     at Socket.emit (node:domain:475:12) {
+   errors: [
+     {
+       detail: [Error],
+       location: [Object],
+       notes: [Array],
+       pluginName: 'esbuild-multiasset-plugin',
+       text: 'Build failed with 1 error:\n' +
+         '../../../node_modules/playwright-core/lib/server/electron/electron.js:172:51: ERROR: Could not resolve "electron/index.js"'
+     }
+   ],
+   warnings: []
+ }
  ↵
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-580/src/github.com/elastic/synthetics/__tests__/push/index.test.ts:209:22)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Steps errors
Expand to view the steps failures

Runs the tests

Took 2 min 59 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

CC @vigneshshanmugam feel free to merge this whenever you're happy with it, all tests are now passing 😄

@vigneshshanmugam can you double check whether you had the last version during your test? That behaviour you mentioned was happening before the changes I did yesterday morning.
Right now, I just tried to push a journey which depends on another local file and it did separate the necessary files.
To test that, I added the following line to src/push/bundler.js in the build function to get the ZIP file:
  async build(entry: string, output: string) {
    await this.prepare(entry);
    await this.zip(output);
    const data = await this.encode(output);
    await writeFile('/tmp/new-synth.zip', data, { encoding: 'base64' });
    await this.cleanup(output);
    return data;
  }

Then I extracted the new-synth zip file and got two separate files:

Is this what you meant? Or did I misunderstand?

As discussed in Tech Sync, we should ensure this feature includes a check and handling the failure of the compressed bundle being too big for either the Saved Object, or configmap to support, and feed this back to the user (e.g. ...failed to create the monitor as the bundle size is bigger than the maximum 800KB...)
cc @lucasfcosta

@vigneshshanmugam I was looking into not bundling the node_modules but in that case we'd have to implement the resolution ourselves as the plugin we use bundles them by default and it doesn't seem like we can change that.
Considering that Kibana only shows the code inside the step, as shown in the screenshot below, what do you think of us merging this one as is?

Hi guys.
We're currently waiting on this change, is there any timeframe for its release?

Post FF Testing
I was able to import a simple library like uuid and successfully create, push and run the journey.
Script I used:
import { journey, step, monitor } from '@elastic/synthetics';

import { v4 as uuidv4 } from 'uuid';

journey('Journey uuid Test', ({ page, params }) => {
  monitor.use({
    id: 'uuid-lib-test-001',
    enabled: true,
    schedule: 20,
  });

  step('Generate UUID', async () => {
    const uuid = uuidv4();
    await page.goto('https://onlinetexttools.com/convert-text-to-image');
    const textAreaLocator = page.locator('textarea').first();
    await textAreaLocator.fill(uuid);
    await textAreaLocator.type(' ');
  });
});

However, I did find an issue with bundling certain imports and raised a bug.


Commit data to L1

[x] https://github.com/FuelLabs/fuel-block-committer/issues/50
[x] https://github.com/FuelLabs/fuel-block-committer/issues/56
[x] https://github.com/FuelLabs/fuel-block-committer/issues/57
[x] https://github.com/FuelLabs/fuel-block-committer/issues/79

Nice to have:

[ ] https://github.com/FuelLabs/fuel-block-committer/issues/80
[ ] https://github.com/FuelLabs/fuel-block-committer/issues/58
[ ] https://github.com/FuelLabs/fuel-block-committer/issues/59

Closing this as most critical sub-tasks have been completed. Nice-to-haves will be implemented on follow-up works.