Sluggish behaviour in UI after update from 124 R2 to 126 R2+Hotfix (edit!)

[edit]
I made a mistake! I have updated from 124 R2 to 126 R2+Hotfix
All 126 releases have the lagging bug on my system, either 32bit or 64bit, have checked all.
Describe the bug
After I have updated newest (126 R2 64bit) 124 R2 to R2+Hotfix 64bit via Installer, the UI of Supermium feels slow.
When I hit f.e. CTRL+L to jump to the URL bar and type something, the letters I typed start to show after ~1 second.
I went back to 124 R2 and the problem is gone.
Desktop (please complete the following information):

OS: Windows 7 64bit

That sounds awfully close to my own issue (https://github.com/win32ss/supermium/issues/878), minus the 126 without hotfix running normally on your end. Odd.

I have noticed slow/sluggish menu renderings on both 126 & 126R2 32bit running on a fully updated Win7 64bit OS. Compared to 124 it is a pretty big difference but other than that it seems to be running just fine.

@tessa112
That's precisely my issue too. I'm... "glad" that someone else ran into this issue as well, I was starting to doubt my sanity here.

@jimjonesbased69 Yeah, I saw your bug report but as I observed the "lags" only after updating from R2 to R2+Hotfix, I thought it would be worth it to open a new ticket. Something strange is going on here, don't know what it is.

I'm so sorry for the confusion. Long story short: All 126 releases are lagging on my Win 7 64bit system. The 124 R2 works!
I have updated the title and the first post.

@shaft17
I was wondering why i've never seen that non-hotfix R2 you've been talking about. Well, that explains it. Let's hope @win32ss is able to reproduce this issue and find the cause.

Pages were lagging for a while (several hours), but then everything stopped and works fine, even after a reboot. Strange.

[edit] I made a mistake! I have updated from 124 R2 to 126 R2+Hotfix All 126 releases have the lagging bug on my system, either 32bit or 64bit, have checked all.
Describe the bug After I have updated newest (126 R2 64bit) 124 R2 to R2+Hotfix 64bit via Installer, the UI of Supermium feels slow. When I hit f.e. CTRL+L to jump to the URL bar and type something, the letters I typed start to show after ~1 second.
I went back to 124 R2 and the problem is gone.
Desktop (please complete the following information):

OS: Windows 7 64bit

that behaviour is weird
idk why thts happening..... do u have the platform update for windows 7 (KB2670838) ?

I have noticed slow/sluggish menu renderings on both 126 & 126R2 32bit running on a fully updated Win7 64bit OS. Compared to 124 it is a pretty big difference but other than that it seems to be running just fine.

Fully updated??!!!

@Ravenant1234
I can personally confirm that update status has absolutely no bearing on this issue.

I have noticed slow/sluggish menu renderings on both 126 & 126R2 32bit running on a fully updated Win7 64bit OS. Compared to 124 it is a pretty big difference but other than that it seems to be running just fine.

Fully updated??!!!

well, almost.

I just updated Supermium to the latest version (126 R3, 64 bits) on my win8.1 machine.
I haven't experienced anything as described here.
The browser did feel off just after installing however (which prompted me to check if anything was going on here, in the issues). Especially:

When opening a new tab, there was like a tiny delay (in the 300~600ms ballpark) before the page appeared. Once the tab is loaded, it's fine.
When pressing the 3 dots on the top right, to open the menu, the fade in animation felt a tiny bit sluggish.

But, beside this, it ran fine. I wasn't on a fresh profile and I can't discard a possible nocebo effect on my part, I'm just sharing my experience.
I played around with flags since because I didn't really like the new look, and I currently have:
ntp-realbox-cr23-all disabled
ntp-realbox-cr23-theming disabled
chrome-refresh-2023 disabled
force-xp-theme enabled

and I haven't noticed these problems again, it's now buttersmooth. I don't know if enabling the classic theme  helped, though.

This should be an easy way to try to reproduce,
When i click a folder on the bookmark bar it takes ~1 second to display the content (15-20 dirs and ~100 bookmarks) and moving the cursor up-down it only highlights every 4-5th instance. (very laggy, always been instant prior to v126)
Trying to list another subdir containing 10 bookmarks will take again ~1 second.  (i can even perceive the window fade in)

I've just finished testing Windows XP 64-Bit Edition (x64), Windows Vista (x64), Windows 7 (x64), 8 (x64), 8.1 (x64), 10 (x64) & 11 (x64). It appears that only Windows 7, 8 & 8.1 are affected by this issue, all other operating systems ran fine and no sluggishness could be observed at all.

Disable Aero and see what happens.

@FK2FAGHMS
There is no difference between Aero, Basic & Classic theme performance, the issue persists throughout.

Weird, I did not expect any sluggish performance (Classic/Pre-Refresh). Maybe the ones whose experiencing this problem should list system specifications like CPU, GPU and drivers (see if there's any similarities).

Okay, i've actually potentially discovered what causes this behavior.
Here's what i've found:
Running Windows 7 (x64) in VMware:

With VMware graphics driver installed = Sluggishness.
Without VMware graphics driver installed = No Sluggishness.

Running Windows 7 (x64) on Hardware:

With Radeon graphics driver installed = Sluggishness.
Without Radeon graphics driver installed = No Sluggishness.
With NVIDIA graphics driver installed = Sluggishness.
Without NVIDIA graphics driver installed = No Sluggishness.

Could someone that experiences this issue please uninstall their graphics driver via DDU and report back if they run into the same results? If this holds true and is not just a fluke on my end, it'll make sense why only Windows 7, 8 & 8.1 are impacted; they're all using the same driver.

I don't want to play around with the graphic driver of this machine for reasons but:

I can confirm what happened in my earlier post was on real hardware with a NVIDIA GPU (A Geforce 605 if I remember well, can't check right now).
I noticed the sluggish fade-in of the 3 dot menu occuring again, so what I did with flags didn't fix the issue. It occured while the PC had a graphics heavy task running in the background.

Well, I forgot to mention that I've used the 32-bit version of the browser. My GPU is NVIDIA Geforce GT 220M and with drivers 342.01.
I didn't test the 64-bit version because it's more resource intensive and my machine is limited to 4 GB of RAM.

@win32ss
I'm using VMware Workstation 15 Pro (15.5.7 build-17171714) using a Windows 7 (x64) host.
I setup all my virtual machine guests with these settings:

1 Socket/CPU with 16 Cores.
16GB of RAM.
32GB Storage (SATA).
3D graphics acceleration is enabled (requires VMware graphics driver to function).
Hardware Compatibility is set to "Workstation 15.x" (this is the latest available level).
(Windows 7 Only) Guest operating system is set to "Microsoft Windows", Version "Windows Server 2008 R2 x64" as VMware, for some reason, otherwise forces NUMA nodes on anything above 8-Cores on Version "Windows 7 x64".

As for the older renderer you've supplied, it sadly doesn't appear to be changing anything on my end.

I set up a Windows 7 install on a system with a NVIDIA Quadro K2200 running driver 348.40 and there were no performance issues. But it seems I don't remember suggesting temporarily removing dwrite.dll from the Supermium folder. I wonder what happens if it's removed altogether?

@win32ss
Do you have access to slighty newer hardware which works with the latest drivers? Or, can you use more recent drivers that support that graphics card? Via NVIDIA's driver page, your card should be able to use the R440 U4 (441.66) driver, no? But this makes me think; @FK2FAGHMS has similarly old drivers and is also not affected by this issue, maybe old NVIDIA hardware/driver configurations are unaffected?
I've tested these hardware configurations:
(Modern NVIDIA) GTX 1660 Super with 472.12 drivers.
(Radeon GCN) RX 580 with 21.4.1 drivers.
(Radeon TeraScale) Radeon HD 8650G with 15.7.1 drivers.
(Virtual) VMware with whatever driver Workstation 15 Pro provides.
Coincidentally, I do not own any old NVIDIA hardware.
Removing the DWrite library was actually the first thing I did trying to fix the issue, no dice. Was a moonshot anyway since 124, which also shipped with the library, had no issues at all.
I'd also like to ask again; if anyone with this specific issue could uninstall their graphics drivers via DDU and report back if that remedies this issue, that would be great.

I installed 441.66 and nothing changed.
My next attempt will involve internal tests with other users experiencing the same issue, but with Chromium 124-126 era nightly builds patched to run on Windows 7. I had actually discovered many different feature switches relating to compositing, message loops and related entities that were introduced in this period but none had any impact, leaving no other option than to pore over potentially dozens of nightly builds to find the responsible commit amongst the sprawling Chromium codebase.

All 126 releases are very slow on my hardware (the interface is very slow compared to 124 and 122). Win 7 32bit Starter (Aero is not there, DWM service is disabled), updates until 2024. CPU: Intel Atom N270 (two logical cores) / 2GB RAM / GPU: Intel GMA 950. Hardware acceleration is disabled in the browser settings, because GMA 950 is useless and only harmful. Versions 122 and 124 are fast. 124 is a little slower than 122, but I use the 122 version, because 124 has strange problems with YouTube (the video won’t start, no matter what I do, the wheel just spins, and the same thing with the 126 version).

@win32ss
Let me give you a simple example of a rendering bug on my equipment. It seems to me that this may also be due to the slowdown of the interface, because... in version 124 it has already become slower, but to a lesser extent than in 126.
So, you need to disable JavaScript in your browser settings and open the page: https://github.com/win32ss/supermium/releases
Under the newest release you can see an animated circle (since JavaScript is disabled, the circle will continue to spin, but the “Assets” list will not appear).
Rendering this small element (while it is present in line of sight) uses the CPU over 50% and tries to use the GPU, even with hardware graphics acceleration disabled. This happens in versions 126, 124 and 122(R6). In version 122(R5), 122(R4), 122(R2) everything is fine and works as it should. From this it follows that, for my equipment and similar ones with win7, the rendering became corrupted already in version 122 (R6), and this got worse in subsequent versions.
Details can be seen on the screenshot. Those who have problems with the slow interface can repeat this experience. It would be interesting to know the results and establish or refute the relationship. Of course, CPU usage will be more noticeable on weaker hardware.

I recently made heavy patches to a Chromium 126/early 127 nightly build so it could run on Windows 7/8.1. A user tested this build and had no UI slowdown issues. So I decided to start looking into Supermium's own patches as the ultimate cause of the issue.
And this most recent submission would prove it, as virtually all non-security patches between 122 R5 and R6 originated from Supermium itself. The most relevant change would be the change to "non-lazy composition", as it solved some drawing bugs that were once present without any reports of performance issues at the time (my testing systems have no change in performance between 126 R3, 126 R3 with lazy composition, and 122 R5). The old functionality remains available behind the command line switch --force-lazy-compositor, so users may want to try it.

The most relevant change would be the change to "non-lazy composition", as it solved some drawing bugs that were once present, while not causing any reports of performance issue (my testing systems have no change in performance between 126 R3, 126 R3 with lazy composition, and 122 R5).

I've already used --force-lazy-compositor. Unfortunately, this does not affect the problems described above and the slowdown of the interface.
"lazy composition" gives benefit to weaker hardware when you open a link in a new tab and don't switch to it while it's loading. Thus, rendering does not occur and does not eat up the power of the equipment until you switch to this tab. Without --force-lazy-compositor, loaded background tabs use more power and time (probably only noticeable on very low-end hardware like mine).
I tried playing with some other flags related to rendering and layout, but to no avail. Clearly the problem is something else that was introduced/changed in 122(R6) but was missing or not addressed in 122(R5). But from the description of the changes in 122(R6) the reason is unclear to me, even approximately...

The other changes not related to UI metrics in 122 R6 were some small GDI compatibility fixes in the Skia renderer and the print/PDF renderer, as well as the patching of security vulnerabilities in the V8 renderer.

@win32ss
Your patches for Supermium are not the cause of this issue, it's chromium itself. Checking out various plain patches that make newer chromium versions work on older operating systems, i've noticed that the issue appears somewhere between 124.0.6364.202 (https://github.com/Blaukovitch/GOOGLE_CHROME_Windows_7/releases/tag/124_ret2) and 125.0.6422.61 (https://github.com/Blaukovitch/GOOGLE_CHROME_Windows_7/releases/tag/125). Both have the same new UI, but only 125 exhibits the issue.

I have now patched two nightly builds of Chromium 126/127 from April 30 and May 16, 2024 to run on Windows 7. The user noticed that tab animations were slow, but not menu highlights. No issues were present in the May 16 build. (126 ESR "feature" patches are mostly frozen in the mid April - mid May period)
I am going to patch further builds but this process may be lengthy, as there are about 8000 commits between the two releases, and especially hastened by the fact I have to rely on others' hardware to test.

I patched several nightly builds between versions 124 and 127. None of them had the extent of performance issues that Supermium and Google Chrome experience. The difference seems to lie in build options (Supermium and Google Chrome are a more release-oriented configuration, while the nightly builds, while not being built with debug flags, have more sanity checking and logging enabled, including dumps and call stacks being dumped on the command line without line numbers). For that reason I built a debug build of Supermium,
I'll correct as many issues as I can find and then release a regular non-debug release with these changes.

This debugging build notably lacks the is_official_build and thin LTO optimizations to match the Chromium browser snapshots, and has been confirmed to have improved UI performance on an affected system. I am now building the regular 32 bit version (since it hadn't been rebuilt yet) without the thin LTO optimizations to determine whether it has an impact. For 64 bit (where I already finished the costly rebuild to accommodate the Supermium debug flags), I will try to look into the many places that is_official_build impacts and try to find the source of the problem.

Please try the new release v126-r4-dbg, preferably the standard supermium_126_(64/32)_setup package.

@win32ss
Does not appear to make any difference on my end.

Unfortunately, no difference on my end aswell (32-bit)
I will try the 64bit later today and will report back if  there is any improvement.

I made another pre-release with a 64 bit chrome.dll, with some other changes made.

@win32ss
No change observed here, sadly.

Can confirm the same problem occurs with Supermium 126 on Windows 8.1, with both NVIDIA and Intel HD graphics cards 😔 Supermium 124 on the other hand works fine 😆

@win32ss
No, nothing has changed. I checked it on two old netbooks, win 7 32 and 64. But on the second netbook (which I am currently using) I noticed that the interface slows down to varying degrees for the USB mouse and the built-in touchpad in different menus! What could be causing the difference, driver, different DPI? For example, moving through the “three dots” menu, it seems that there is almost no slowdown for the touchpad, at the same time, for the mouse it is very noticeable, and from the keyboard there is no slowdown at all.
For now I’m staying on version 122 (R5), since this version is the most stable on both netbooks. At 122 (R6) and higher, obvious problems with YouTube begin: the animation of the loading wheel eats up a lot of resources, the loading of the video stream is either interrupted or cannot start.
But even version 122 (R5) is inferior to the SRWare Iron 109 browser in terms of YouTube playback quality (H264 480, 720, software rendering). It seems that SRWare Iron 109 works with the video stream more optimally, there is no feeling of dropped frames (when the image jerks).

Can confirm the same problem occurs with Supermium 126 on Windows 8.1, so it isn't limited to Windows 7 alone, with both NVIDIA and Intel HD graphics cards 😔 Supermium 124 on the other hand works fine 😆

Win8.1, Intel CPU and Nvidia graphic card here, no problem on the latest 126.0.6478.256 R5. This system only have security updates installed, plus a few optional ones related to security, if it matters.
The issues I mentionned way above in this thread and in #941 are gone and I did feel the browser to be slightly more responsive overall. Some odd rendering lags which occured occasionaly are also gone or heavily diminished.

For example, moving through the “three dots” menu, it seems that there is almost no slowdown for the touchpad, at the same time, for the mouse it is very noticeable, and from the keyboard there is no slowdown at all.

Do you mean when moving the mouse over the various options of the menu? Because, if so, I do see a slight "delay/lag" before the hightlight updates to the option I'm actually hovering on, but it's almost imperceptible to me. I wouldn't have noticed if I didn't read your post.

Can confirm the same problem occurs with Supermium 126 on Windows 8.1, so it isn't limited to Windows 7 alone, with both NVIDIA and Intel HD graphics cards  Supermium 124 on the other hand works fine

Win8.1, Intel CPU and Nvidia graphic card here, no problem on the latest 126.0.6478.256 R5. This system only have security updates installed, plus a few optional ones related to security, if it matters. The issues I mentionned way above in this thread and in #941 are gone and I did feel the browser to be slightly more responsive overall. Some odd rendering lags which occured occasionaly are also gone or heavily diminished.

I have last tested it with 126 R4, so I will try out the R5 version. I hope it got better

Do you mean when moving the mouse over the various options of the menu?

No, not just the menu. The “three dots” menu was just given as an example. The strongest delay is when moving the mouse across many tabs (20-30 or more), this is immediately very noticeable. The most interesting thing is that for a USB mouse and for a built-in touchpad the delay is different; for a touchpad it is significantly less. Although, it would seem, what is the fundamental difference between a touchpad and a mouse?..
But most of all, it’s not even these delays that bother me, but the problem with incorrect animation rendering, which takes up a lot of resources (CPU and GPU) for nothing, I posted the screenshot and description above in this topic. It is very similar to the “looping” (“multiplicity”) of executing some drawing commands. The problem started with version 122 (R6) and is still present today. I tested it on two different netbooks with win7 32 and 64. I believe the problems may be related and the root of the problem is probably version 122 (R6).

The other changes not related to UI metrics in 122 R6 were some small GDI compatibility fixes in the Skia renderer and the print/PDF renderer, as well as the patching of security vulnerabilities in the V8 renderer.

I'm still looking for the cause of the problem I described above in this post: https://github.com/win32ss/supermium/issues/889#issuecomment-2387266555
Looks like it's getting close! I tried the version Thorium_SSE3_122.0.6261.171.zip  from the developer Alex313031. This version also has a fix for CVE-2024-4947, as well as your Skia fixes
:

GDI text rendering alignment is fixed This bug caused text to be askew, either too high or too low, or too much to the left. The reason previous releases didn't have this fixed, is that win32ss fixed it in Skia, which is a third_party submodule of Chromium. Because of that, I couldn't see the commits or changes. He shared a patch with me, and I have now created a repo specifically for it, and we will probably use that as a submodule in both here and in the Supermium repo. See the pull request I made for this after we discussed it > win32ss/supermium#511 Fixes #69

As a result of the Thorium test, I saw exactly the same problems that I experienced with Supermium 122.0.6261.152 (R6) (and subsequent versions) regarding animation rendering.
Next, I tried version 125.0.6422.77 from developer Blaukovitch, which also has a fix for CVE-2024-4947, but does not have a fix for Skia. This time there were no problems with rendering the animation, YouTube worked fine, and the animated circle did not consume a lot of CPU resources. But the browser interface itself (moving through menus, through tabs) began to slow down.
Conclusions:

My problem with animation rendering is directly dependent (99% probability) on the Skia fixes applied since Supermium version 122.0.6261.152 (R6);
My problem is not related to the title and content of this topic. Apparently, this problem should be highlighted in a separate topic, since I discovered the problem on two different weak netbooks with win7 32 and 64bit. I guess those with more powerful equipment simply don't pay attention to this problem;
The problem with interface slowdown, as suggested above, is a problem with new versions of Chrome, and not directly with the win32ss code.

@win32ss, I ask you to release version 126 without applying the Skia fixes, or to analyze these fixes more carefully for the possibility of animation rendering bugs. I myself cannot fix this or assemble the Supermium version: I have neither sufficient qualifications nor suitable more powerful equipment.

The Skia fix should only apply in GDI mode. GDI should only be explicitly enabled using #force-gdi//--force-gdi.
But I will remove the Skia patches anyway in the next release to see if it has indirectly caused issues elsewhere.

The Skia fix should only apply in GDI mode. GDI should only be explicitly enabled using #force-gdi//--force-gdi.

I always have the #force-gdi option disabled.
As far as I understand, the Skia fixes are also in the Pdfium patch?

But I will remove the Skia patches anyway in the next release to see if it has indirectly caused issues elsewhere.

Unfortunately, removing the Skia patches did not solve my problem with the animation elements. Apparently, I was seriously mistaken about the cause of this problem. But this is the first thing that came to mind when I compared Thorium and Supermium, and what exactly united them. After all, the problem appears in both Supermium and Thorium, equally. Although the problem is absent in the versions from Blaukovitch.
Obviously, the problem lies in something else that unites Supermium and Thorium, but was not used by Blaukovitch.
I'm upset :( I can't use Supermium above version 122 (R5) for so long now...


Auto select correct currency based on user's app/play store settings

Currently defaulted to USD

Check with ali, brian and test from India.

Check with ali, brian and test from India.

-Verified this issue on Staging app v1.4.1(194)

-Verified this issue on Staging app v1.4.1(194)


Change the text of the top-down view's search field back to "search"

No filtering is actually done, i.e., no node is hidden: the matching nodes are
highlighted and all their ancestors expanded. I think "search" is more accurate
for this.

What do you think?


krishnamurthy number

[x] Adds krishnamurthy number check

Thanks @ashwani-rathee
I am trying to unstack the PR in order with the small amount of time I have this week. Next month should be better (I hope I can contribute some algo myself :p)

If the CI goes through, we're good to go


ldeep: 1.0.77 -> 1.0.78

Diff: https://github.com/franc-pentest/ldeep/compare/None...1.0.78
Changelog: https://github.com/franc-pentest/ldeep/releases/tag/1.0.78

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 369619

x86_64-linux

:white_check_mark: 2 packages built:

ldeep
ldeep.dist


kubeapi configuration update approach

Need to verify kubeapi restart approach, provide more robust if needed and generalize it
https://github.com/Netcracker/KubeMarine/blob/587479a0e227376acb402b77b9ecd6cf2ac96b59/kubemarine/psp.py#L356

https://github.com/Netcracker/KubeMarine/pull/275

pr: https://github.com/Netcracker/KubeMarine/pull/275


Fix use-after-unref bug in fault_injection_filter

https://github.com/grpc/grpc/pull/25827 found a use-after-unref bug in the fault injection filter - https://source.cloud.google.com/results/invocations/cf319436-f4b8-45e5-a30a-8487da44fd61/targets/%2F%2Ftest%2Fcpp%2Fend2end:xds_end2end_test@poller%3Depoll1/log
The issue is that we are unlocking calld->delay_mu_ after unreffing the call stack. This PR fixes this.

@yashykt Can I ask why adding an extra scope fixes the use-after-unref bug? I actually saw this failure at 1/1000 TSAN runs.

@lidizheng With this change, the MutexLock goes out of scope, thereby releasing the lock, before the object containing the lock is unreffed.

Oh, GRPC_CALL_STACK_UNREF might remove CallData, hence the lock itself is deallocated. Thanks!


where to creating a .kafka file?

and how to opreat that?

Hi,
You can create any .kafka file as a normal file on disk. The extension is registered to listen for those filetypes. Once you have a .kafka file you should get code lense showing up for producer declarations allowing you to produce records.


Coin Sum solved

This Pull Request resolves Issue #572
Description:
Added the solution in the required directory

Thanks for contributing @hlpr98


Node kubelet restart loop hogs CPU when using self-host-kubelet

The example under hack/multi-node/user-data.sample uses the below systemd unit for node kubelet:
        [Service]
        EnvironmentFile=/etc/environment
        Environment=KUBELET_ACI=quay.io/coreos/hyperkube
        Environment=KUBELET_VERSION=v1.5.1_coreos.0
        Environment="RKT_OPTS=--volume var-lib-cni,kind=host,source=/var/lib/cni --mount volume=var-lib-cni,target=/var/lib/cni"
        ExecStartPre=/bin/mkdir -p /etc/kubernetes/manifests
        ExecStartPre=/bin/mkdir -p /etc/kubernetes/cni/net.d
        ExecStartPre=/bin/mkdir -p /etc/kubernetes/checkpoint-secrets
        ExecStartPre=/bin/mkdir -p /srv/kubernetes/manifests
        ExecStartPre=/bin/mkdir -p /var/lib/cni
        ExecStart=/usr/lib/coreos/kubelet-wrapper \
          --kubeconfig=/etc/kubernetes/kubeconfig \
          --require-kubeconfig \
          --cni-conf-dir=/etc/kubernetes/cni/net.d \
          --network-plugin=cni \
          --lock-file=/var/run/lock/kubelet.lock \
          --exit-on-lock-contention \
          --pod-manifest-path=/etc/kubernetes/manifests \
          --allow-privileged \
          --hostname-override=${COREOS_PUBLIC_IPV4} \
          --node-labels=master=true \
          --cluster_dns=<IP_ADDRESS> \
          --cluster_domain=cluster.local
        Restart=always
        RestartSec=5

However, if you use self-host-kubelet, the --exit-on-lock-contention causes the node kubelet to die and the Restart=always causes it to restart. This restart loop eats up all of my CPU on a m4.large AWS EC2 instance. Setting "Restart=on-failure" should work and documentation should be updated to highlight this.

I'm going to close this as a duplicate of https://github.com/kubernetes-incubator/bootkube/issues/251
If that's not the same behavior, let me know. Unfortunately the self-hosted kubelet hasn't been undergoing much testing / maintenance recently and there are some lingering issues. I also think we need to be more explicit about its current state: https://github.com/kubernetes-incubator/bootkube/issues/275


Add recursion limit #337

@collerek what do you think about making this change to solve the number of recursion calls that im making? #337


rnaseqc_call_2 grouping error (RNA_calling.ipynb)

This step groups input by 3, but there are four outputs produced by rnaseqc_call_1. This leads to an error. Fix is just to change it to 4.

Done


THRIFT-5572: add travis_wait for rebuilding docker image

because building image requires kerl to build erlang, which requires >10
min to build and meanwhile not printing to stdout, failing the travis
build
Currently the travis CI is broken because the step when kerl is building erlang OTP from source but the build process produces no output for >10 mins and travis will then fail the build if no output is detected.
The max number of build errors has been reached so now the travis CI build is suspended.
The easy fix is to allow travis to wait a bit longer (the erlang build itself takes around 1100 seconds).

this is a follow up on:

https://github.com/apache/thrift/pull/2541

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

i tried to build erlang locally using kerl and it's still taking significant time - so i assume this fix isn't temporary and instead should be checked in for good...


GPU seperate doesn't work

Short summary about the issue/question:
when I apply for 1 gpu sku,I can use all gpu in the container,why?
For example:I use nvidai-smi in command,it will print all gpu information.
I had installed a same v1.8.0 opanpai in another cluster,it can seperate gpu.
Brief what process you are following:

How to reproduce it:

OpenPAI Environment:

OpenPAI version:v1.8.0
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

Short summary about the issue/question: when I apply for 1 gpu sku,I can use all gpu in the container,why? For example:I use nvidai-smi in command,it will print all gpu information. I had installed a same v1.8.0 opanpai in another cluster,it can seperate gpu. Brief what process you are following:
How to reproduce it:
OpenPAI Environment:

OpenPAI version:v1.8.0
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:

I see environment "NVIDIA_VISIBLE_DEVICES=all" when docker inspect container

Sorry for late response. Can you run printenv inside the container and paste the result here? And please make sure you use the nvidia-runtime not default runc for docker daemon.


modified: Change dependencies.

Previous LaTeX rendering workaround requires code modification outside this repo. These commits move those change into this git repo. GitHub Action generated release now should be able to render LaTeX correctly.
Also removed unused packages and update related docs.

Current Github Action generated Release.zip doesn't works well with the PluginInstaller. The reason may be that the release.zip archive file is nested inside Release.zip generated by Github Action.
I'm not familiar with Github Action and not sure if it possible to remove this layer of nesting, or is there any specific reason that we should keep this nesting?

Current Github Action generated Release.zip doesn't works well with the PluginInstaller. The reason may be that the release.zip archive file is nested inside Release.zip generated by Github Action.
I'm not familiar with Github Action and not sure if it possible to remove this layer of nesting, or is there any specific reason that we should keep such nesting structure?

并没有特别的需求，仅需在 Action 中打包后和上传构建前之间加入一行 rm 命令删除 release.zip 即可

我看了下，怎么把node_modules也给包进去了啊（）


Feature lint sprig

I wrote a tool to help ensure other sprig games present in the repository aren't missing from the gallery. It's called lint-sprig. It's a little bash shell script. It might be helpful for all the awesome work sprigsters are doing adding games to the repository and website.
Here was the output I used to make changes for my prior pull request that found three games that hadn't been added to the metadata.json file.
$ ./bin/lint-sprig
error: Unexpected character in file name 'games/5-in-1-Carnival-Game-Pack!.js'.
warning: 'Alien_Attack' for games/Alien_Attack.js not present in games/metadata.json.
Suggested fix: add this record to games/metadata.json.
  {
    "filename": "Alien_Attack.js",
    "title": "Alien_Attack",
    "author": "whatware",
    "img": "games/img/Alien_Attack.png",
    "tags": [],
    "addedOn": "2023-03-01"
  },
error: Unexpected character in file name 'games/Cookie_Click!.js'.
warning: 'ElfSokoban' for games/ElfSokoban.js not present in games/metadata.json.
warning: no 'games/img/ElfSokoban.png' image found.
Suggested fix: add this record to games/metadata.json.
  {
    "filename": "ElfSokoban.js",
    "title": "ElfSokoban",
    "author": "Markonije",
    "img": "",
    "tags": [],
    "addedOn": "2023-03-01"
  },
error: Unexpected character in file name 'games/It_Is_Coming_Out!.js'.
warning: 'It_Is_Coming_Out!' for games/It_Is_Coming_Out!.js not present in games/metadata.json.
error: no @author in games/It_Is_Coming_Out!.js
Suggested fix: add this record to games/metadata.json.
  {
    "filename": "It_Is_Coming_Out!.js",
    "title": "It_Is_Coming_Out!",
    "author": "N/A",
    "img": "games/img/It_Is_Coming_Out!.png",
    "tags": [],
    "addedOn": "2023-03-01"
  },
error: Unexpected character in file name 'games/Music!.js'.
error: Unexpected character in file name 'games/sPaint!.js'.
error: Unexpected character in file name 'games/seven_ate_nine_(789).js'.

You can also provide it with one or more game files to check. Here is the usage.
$ ./bin/lint-sprig -h
Usage: ./bin/lint-sprig [games/<name>.js ...]

Perform sanity check on sprig games. Ensures js files in games directory are
represented in metadata file. Checks name for invalid characters. Suggests a
record to add to metadata if not present, pulling title and author from
javascript file. Checks for associated image file.

Does not read metadata to determine if it references files not present.

@shanecelis I believe this PR is dead so I'm closing it, please reopen it if you want to advocate for its merge.

Its contents were resubmitted in this PR: https://github.com/hackclub/sprig/pull/971


Exception running Actor example: Type 'Dapr.Actors.Runtime.ActorReminder' cannot be serialized.

Expected Behavior
The var reminder = await proxy.GetReminder(); should return the registerd reminder information
Actual Behavior
Exception is thrown in the client: Type 'Dapr.Actors.Runtime.ActorReminder' cannot be serialized.
At line https://github.com/m3nax/dapr-dotnet-sdk/blob/master/examples/Actor/ActorClient/Program.cs#L100
Client output:
Making call using actor proxy to save data.
Making call using actor proxy to get data.
Received data is PropertyA: ValueA, PropertyB: ValueB.
Making calls to an actor method which has no argument and no return type.
Got Incorrect Exception from actor method invocation. Exception Dapr.Actors.ActorInvokeException: The method or operation is not implemented.
Making calls without Remoting.
Registering the timer and reminder
Waiting so the timer and reminder can be triggered
Making call using actor proxy to get data after timer and reminder triggered
Received data is PropertyA: Timer triggered at '02023-10-25T22:50:16', PropertyB: Reminder triggered at '2023-10-25T22:50:12'.
Getting details of the registered reminder
Unhandled exception. Dapr.Actors.ActorMethodInvocationException: Remote Actor Method Exception,  DETAILS: Exception: InvalidDataContractException, Method Name: ThrowInvalidDataContractException, Line Number: 0, Exception uuid: 99272412-891a-40e7-9705-1cb6b3edf4e3
 ---> Dapr.Actors.ActorInvokeException: Type 'Dapr.Actors.Runtime.ActorReminder' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the DataMemberAttribute attribute. Alternatively, you can ensure that the type is public and has a parameterless constructor - all public members of the type will then be serialized, and no attributes will be required.
   --- End of inner exception stack trace ---
   at Dapr.Actors.DaprHttpInteractor.InvokeActorMethodWithRemotingAsync(ActorMessageSerializersManager serializersManager, IActorRequestMessage remotingRequestRequestMessage, CancellationToken cancellationToken) in C:\Users\manue\source\repos\dapr-dotnet-sdk\src\Dapr.Actors\DaprHttpInteractor.cs:line 174
   at Dapr.Actors.Communication.Client.ActorRemotingClient.InvokeAsync(IActorRequestMessage remotingRequestMessage, CancellationToken cancellationToken) in C:\Users\manue\source\repos\dapr-dotnet-sdk\src\Dapr.Actors\Communication\Client\ActorRemotingClient.cs:line 47
   at Dapr.Actors.Client.ActorProxy.InvokeMethodAsync(Int32 interfaceId, Int32 methodId, String methodName, IActorRequestMessageBody requestMsgBodyValue, CancellationToken cancellationToken) in C:\Users\manue\source\repos\dapr-dotnet-sdk\src\Dapr.Actors\Client\ActorProxy.cs:line 227
   at Dapr.Actors.Client.ActorProxy.ContinueWithResult[TRetval](Int32 interfaceId, Int32 methodId, Task`1 task) in C:\Users\manue\source\repos\dapr-dotnet-sdk\src\Dapr.Actors\Client\ActorProxy.cs:line 291
   at ActorClient.Program.Main(String[] args) in C:\Users\manue\source\repos\dapr-dotnet-sdk\examples\Actor\ActorClient\Program.cs:line 100
   at ActorClient.Program.<Main>(String[] args)

Steps to Reproduce the Problem

fetch lastest version of master branch
move to example folder cd .\examples\Actor\DemoActor\
run command as written in readme dapr run --dapr-http-port 3500 --app-id demo_actor --app-port 5010 dotnet run
open another console and move to example folder cd .\examples\Actor\ActorClient\
run command as written in readme dotnet run
wait for reminder part of example

Release Note

RELEASE NOTE:

/assign


Updates google-play-services.jar w/ 10.2.1 version

I'm so sorry, I upgrade the SDK to 1.5.1, so close this pr.
Thanks for your pr.


WIP: Add class method from_params for creating statements

Simplify creating statements - we don't need to pass token list and we can use param values instead.
To be discussed - what statements should have from_params? All of them? Or just particular.

Although I wrote earlier that all statements should get this treatment, they don't necessarily need to get it in RF 4 and definitely not in beta 2. Right now it's important to agree on the overall design and to add methods that the new Tidy needs.

Looks good! Comments:

I think all statements should get this factory method. They might all be needed in some use cases and all statements having them would also be good for consistency reasons.
Perhaps create would be better than from_params.
See also individual line comments.

I will update all statements with this factory method.
I mentioned this in Slack but if it's about from_params I prefer the current version. Not 100% happy with it but it's akin to 'from_tokens' method so for someone who was using parsing API already it will be easier to understand what it's doing.

Looks good! Comments:

I think all statements should get this factory method. They might all be needed in some use cases and all statements having them would also be good for consistency reasons.
Perhaps create would be better than from_params.
See also individual line comments.

I will update all statements with this factory method.
I mentioned this in Slack but if it's about from_params I prefer the current version. Not 100% happy with it but it's akin to 'from_tokens' method so for someone who was using parsing API already it will be easier to understand what it's doing.

Updated with all comments. Still not covered all statements - on it.

Updated with all comments. Still not covered all statements - on it.

Codecov Report

Merging #3808 (c31e9b4) into master (d62ee50) will decrease coverage by 0.25%.
The diff coverage is 86.21%.

@@            Coverage Diff             @@
##           master    #3808      +/-   ##
==========================================
- Coverage   74.46%   74.21%   -0.24%
==========================================
  Files         218      217       -1
  Lines       17942    18085     +143
  Branches     2917     2927      +10
==========================================
+ Hits        13358    13420      +62
- Misses       4087     4147      +60
- Partials      497      518      +21

Impacted Files
Coverage Δ

src/robot/tidypkg/transformers.py
20.87% <0.00%> (-0.38%)
:arrow_down:

src/robot/utils/__init__.py
94.12% <ø> (ø)

src/robot/parsing/model/statements.py
94.66% <87.97%> (-1.85%)
:arrow_down:

src/robot/utils/misc.py
98.64% <100.00%> (+0.11%)
:arrow_up:

src/robot/utils/encodingsniffer.py
66.16% <0.00%> (-21.53%)
:arrow_down:

src/robot/model/keyword.py
83.97% <0.00%> (-13.30%)
:arrow_down:

src/robot/version.py
55.56% <0.00%> (-11.11%)
:arrow_down:

src/robot/utils/robotpath.py
64.16% <0.00%> (-9.43%)
:arrow_down:

src/robot/utils/robottypes3.py
90.91% <0.00%> (-9.09%)
:arrow_down:

src/robot/utils/argumentparser.py
78.02% <0.00%> (-5.67%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62ee50...c31e9b4. Read the comment docs.

Codecov Report

Merging #3808 (c31e9b4) into master (d62ee50) will decrease coverage by 0.25%.
The diff coverage is 86.21%.

@@            Coverage Diff             @@
##           master    #3808      +/-   ##
==========================================
- Coverage   74.46%   74.21%   -0.24%
==========================================
  Files         218      217       -1
  Lines       17942    18085     +143
  Branches     2917     2927      +10
==========================================
+ Hits        13358    13420      +62
- Misses       4087     4147      +60
- Partials      497      518      +21

Impacted Files
Coverage Δ

src/robot/tidypkg/transformers.py
20.87% <0.00%> (-0.38%)
:arrow_down:

src/robot/utils/__init__.py
94.12% <ø> (ø)

src/robot/parsing/model/statements.py
94.66% <87.97%> (-1.85%)
:arrow_down:

src/robot/utils/misc.py
98.64% <100.00%> (+0.11%)
:arrow_up:

src/robot/utils/encodingsniffer.py
66.16% <0.00%> (-21.53%)
:arrow_down:

src/robot/model/keyword.py
83.97% <0.00%> (-13.30%)
:arrow_down:

src/robot/version.py
55.56% <0.00%> (-11.11%)
:arrow_down:

src/robot/utils/robotpath.py
64.16% <0.00%> (-9.43%)
:arrow_down:

src/robot/utils/robottypes3.py
90.91% <0.00%> (-9.09%)
:arrow_down:

src/robot/utils/argumentparser.py
78.02% <0.00%> (-5.67%)
:arrow_down:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62ee50...c31e9b4. Read the comment docs.

Thanks a lot for a great PR @bhirsz!

Thanks a lot for a great PR @bhirsz!


Adding instructions for running natively on macOS

@lemire let me know if you have any thoughts here.

Let us merge.


Update README.md

Quickly cleaning out readme

@AdrianCollinsShippo I believe if you completely remove a section, the generator will re-generate it.  check out https://www.speakeasyapi.dev/docs/customize-sdks/sdk-docs

@AdrianCollinsShippo I believe if you completely remove a section, the generator will re-generate it. check out https://www.speakeasyapi.dev/docs/customize-sdks/sdk-docs

good spot @shippo-lueders - I'll see if i can work around this.
Probably a little heavy handed on the cuts - will revert some of these cuts.


Direct leak of 5376 byte(s) in 70 object(s) allocated from: 0x7f36108ba68f in __interceptor_malloc (/lib64/libasan.so.8+0xba68f)

67: =================================================================
67: ==109869==ERROR: LeakSanitizer: detected memory leaks
67:
67: Direct leak of 5376 byte(s) in 70 object(s) allocated from:
67:     #0 0x7f36108ba68f in __interceptor_malloc (/lib64/libasan.so.8+0xba68f)
67:     #1 0x7f3610381b6f in _PyMem_DebugRawAlloc (/lib64/libpython3.10.so.1.0+0x181b6f)
67:
67: -----------------------------------------------------
67: Suppressions used:
67:   count      bytes template
67:      14        896 sys_mutex
67: -----------------------------------------------------
67:
67: SUMMARY: AddressSanitizer: 5376 byte(s) leaked in 70 allocation(s).
1/1 Test #67: c_unittests ......................***Failed    1.77 sec

Did this happen in CI ? I am guessing this failure did not happen in CI since you would have posted a link to the failing CI.
Was this from @ted-ross ? If yes, he is on Fedora 36. Thanks

The best I can do is to preserve some Python global variables when reset is being done (the breaking commit above is for the globals reset)
        _typeobject  my_PyBool_Type        = PyBool_Type;
        _object    *my_PyExc_Exception    = PyExc_Exception;
        _object    *my_PyExc_RuntimeError = PyExc_RuntimeError;
        _object    *my_PyExc_TypeError    = PyExc_TypeError;
        _longobject  my__Py_FalseStruct    = _Py_FalseStruct;
        _typeobject my_PyFloat_Type       = PyFloat_Type;
        _object     my__Py_NoneStruct     = _Py_NoneStruct;
        _longobject  my__Py_TrueStruct     = _Py_TrueStruct;

[...]

            PyBool_Type = my_PyBool_Type;
            PyExc_Exception = my_PyExc_Exception;
            PyExc_RuntimeError = my_PyExc_RuntimeError;
            PyExc_TypeError = my_PyExc_TypeError;
            _Py_FalseStruct = my__Py_FalseStruct;
            PyFloat_Type = my_PyFloat_Type;
            _Py_NoneStruct = my__Py_NoneStruct;
            _Py_TrueStruct = my__Py_TrueStruct;

This reduces the amount of leaked memory but does not eliminate it.
I don't see what other globals I might preserve, and looking at https://github.com/python/cpython/blob/7d6ddb96b34b94c1cbdf95baa94492c48426404e/Objects/obmalloc.c#L917, there are some kind of global pools in python. They don't show in nm output. (Because they are in a DLL and have the visibility set so that they are not exported. I don't know where they live in memory (are they in the .data or .bss sections to be zeroed?) In any case, this does not look promising.
Python has been fighting its global state for some time, see the README in https://github.com/python/cpython/tree/main/Tools/c-analyzer

@ganeshmurthy Yes, this is from @ted-ross.
I am thinking that reverting #609 is the only practical solution. I'm going to do that.


UTF-8 w/ BOM + @mixin causes fatal parsing error

Demo repo here
Short version is that when you have a file encoded as UTF-8 w/ BOM that starts with @mixin, the CLI linter fails with a 1:1  error  Please check validity of the block starting from line #1  Fatal.
UTF-8 w/out BOM works fine, as does UTF-8 w/ BOM without @mixin at the start.
Happens on OS X w/ node 6.2.0 and Windows 10 w/ node 5.8.0.
The gulp-sass-lint plugin actually works fine in all scenarios.

Actually, I'm noticing that UTF-8 w/ BOM also produces an incorrect "Property appears to be spelled incorrectly" error when there's a variable on the first line too. I added an example to the repo. Can open a separate issue for that if you want, though I assume the root cause is the same.

Thanks @mattdistefano will look into it.
Just a note that when you see a please check the validity message, that that error is actually thrown directly from the AST we use to parse your files Gonzales-pe Therefore this may not be a quick fix.
I'll look deeper though. 👍

Thanks!
I believe gulp internally strips the BOM, which is probably why the gulp plugin worked where the CLI tool didn't. So a quick fix maybe is to do the same when loading from the filesystem directly.

Yep, thats what I'm thinking too. There's a task around stripping front matter too for liquid/jekyll stylesheets too so i may incorporate it into all that.
I'll keep you updated.


I3DRSGM Settings not changing

I3DRSGM Changes it's settings by updating tmp.param however if the application folder needs admin rights to update this file the settings do not get updated. A temporary fix is to run the application as admin (right-click -> run as admin). This is only necessary as the previous parameter setting method had other issues.

A quick fix has been applied so that tmp.param is now saved in QStandardPaths::TempLocation. This does not require admin permission.

A quick fix has been applied where by tmp.param is now stored in a writable temporary location using QStandardPaths::writableLocation(QStandardPaths::TempLocation).


How do I config for the items to spawn into other mods' chest

I know this is not really an issue, but I really don't know how to do this. Can someone teach me?

https://github.com/Thelnfamous1/Dungeons-Gear/wiki/How-Loot-Works


100% coverage

Get 100% coverage with tests
Posts

[x] GET /post
[x] GET /post/{id}
[ ] POST     /posts
[ ] DELETE /posts/{id}
[ ] PUT        /posts/{id}

Revisions

[ ] GET /revisions
[ ] GET /revisions/{id}
[ ] POST     /revisions
[ ] DELETE /revisions/{id}
[ ] PUT        /revisions/{id}

util/model-commons/combinators

[ ] $eq
[ ] $ne
[ ] $in
[ ] $nin
[ ] $and
[ ] $or

progress on this depends on the result of this issue in lab-babel, turning off coverage in the mean time as off 484fb6b

reintroduced coverage as of c77089b

implemented at 43eccfe


Scrolling jank in ListView when semantics are enabled

Hi i am following flutter and keep in touch with testing different apps developed in flutter.
But one major issue which is continuously under the ignorance and no thread i found on internet for now.. here is what i feel since 6 months of testing different apps.
Listview kind of scrolling jerks, specially when we have images posters like content with it. you can try this by doing create a list with image and some content list view must have content 3x of screen size.
just scroll it in medium speed, you will clearly feel jerks on screen, beside this the same test did on react native and its super smooth.
here is an example app on playstore (Flutter demo: CINEMA) you can download and test, but that i am sure its flutter bug  because all similar apps or with long list views this happens.
More examples in flutter official app: Flutter Gallery

Flutter Gallery -> (Crane A personalized travel app) -> vertical scroll listview in bottom (Jerk is clearly visible)
Flutter Gallery -> (Rally A personalized finance app) -> Login -> vertical scroll it (choppy scrolling Jerks)

Above examples are not debug all are on production playstore, on stackoverflow this is under discussion but everyone is doing just tricks which is not appropriate way to develop an production grade application.
beside this i also tested horizontal listviews and they work fine.
I am expecting senior flutter teams will take this issue serious and resolve this bug on high priority.
@ianloic @anaisbetts @sgraham @gmoothart @sethladd

I'd just add that it's especially noticeable on the web platform. In my experience which is about 6 months, too. Apps that were made for iOS/Android didn't have that issue but the same app that was build for web was super jerky, very choppy.
There is another live project, where I have a list view where you can add text fields. As long as you have 6 text fields it's okay but as long as you add more fields (e.g. 20/30/40), it starts to get very laggy, janky.

I'd just add that it's especially noticeable on the web platform. In my experience which is about 6 months, too. Apps that were made for iOS/Android didn't have that issue but the same app that was build for web was super jerky, very choppy.
There is another live project, where I have a ListView where you can add text fields. As long as you have 6 text fields it's okay but as long as you add more fields (e.g. 20/30/40), it starts to get very laggy, janky.
There are many bugs on the web platform which is not ideal but honestly I can live with them since I found workarounds but for this kind of bug I'm seriously considering using React instead of Flutter for web. So, couldn't agree more. This definitely should be one of the highest priority, if not the highest one.

Sorry i don't agree as you are saying apps on Android/iOS have no issue..
Issue i opened just cause of mobile apps, and examples are also for mobile platform.
Web is not priority right now, flutter team should fix this bug on high priority or its hard for community to convince our clients to leave react-native and use flutter.
Because according to marketing they are saying they are native if they are then why performance and user experience is so bad than react-native?

Hi @azeemgujjar
there are plenty of open issues addressing different aspects of the "bug" you are describing
https://github.com/flutter/flutter/issues/59404
https://github.com/flutter/flutter/issues/59332
https://github.com/flutter/flutter/issues/55144
https://github.com/flutter/flutter/issues/52207
https://github.com/flutter/flutter/issues/51153
(and more)
that said I do not experience the behaviour you are describing in flutter gallery (web)
please follow up on the issues mentioned above, I'm closing the current one as duplicate.
If you disagree, please write in the comments
possibly providing details of a specific aspect not yet addressed
together with your flutter doctor -v and a minimal complete reproducible code sample.
and I will reopen it.
Thank you

I am sorry but this issue must not be ignored or closed, as you said you are not experiencing this issue because you don't want to see that bug.
As i said its not figured out within hours or days after experiencing several months i opened this ticket.
Flutter development team should take care of this bug on highest priority.
Bug is very clear, already in discussions on several forums, i also send you examples in your own official apps.
All you need to do is compare with react-native or native app performance of listview and check flutter performance then Jerking vertical listviews with images is very clear. Scrolling must be like throwing dice or pushup and leave screen..

Hi @azeemgujjar
I apologise for the misunderstanding,
I'm not saying that the problem does not occur,
I'm saying that the performance issue is currently being addressed in the issues listed above.
If you have are experiencing a behaviour that is not described in those issues,
please provide a description of said behaviour
together with your flutter doctor -v and a minimal complete reproducible code sample;
without these information this issue is not actable.
Thank you

This might be a different issue than those issues above with a long ListView of thousands of strings, dynamic items, and fast scrolling. The Flutter gallery app's Crane tab specifically only has a dozen list items, but the UI thread frame build time is as slow as 20-30 ms/frame even if I scroll slowly on my Moto G4 in profile mode. Below is a tracing to illustrate that problem.
dart-timeline-2020-7-15.json.zip
In our device lab, the gallery app's performance test is showing much faster frame build time (5.68 ms/frame) and rasterization time (11.1 ms) on Moto G4 (search for "new_gallery" on https://flutter-dashboard.appspot.com/benchmarks.html). Presumably, such test exercises many other parts of the gallery app so the bad performance of "Crane" tab gets diluted.
@willlarche @clocksmith @guidezpl @pennzht : can you please add a focused test on "Crane" (similar to the one in https://github.com/flutter/gallery/blob/master/test_driver/transitions_perf_test.dart), and help investigate why its build performance is so poor with such a short list? We'd love to improve the framework to speed it up if it's not some trivial issues on the app side.

Thanks @liyuqian . We'll see what we can find out.

@willlarche @guidezpl : we've now had a test that can reliably reproduce this issue (https://github.com/flutter/gallery/pull/228#pullrequestreview-453553332). I wonder if you've seen anything suspicious in either the app code, or in framework/engine from the profiling?

I had a look again and semantics-related operations are taking abnormally long.
Average over multiple frames on Android:

Single frame:

@dnfield @jonahwilliams @goderbauer seems to be the experts in accessibility (according to go/flutter-who). Any idea if this is expected? If not, is there anything we need to fix in the gallery code, or in the framework?

Turning on semantics does have a price in terms of performance, see also the flutter_gallery__transition_perf_with_semantics benchmark. We have never optimized the semantics tree generation for performance, so it is possible that it can be further optimized. (see also https://github.com/flutter/flutter/issues/28204).
@guidezpl Do you have an accessibility service running on your device? Otherwise semantics should be off and you shouldn't be paying this penalty.

Hmm interesting, TalkBack is the only one I've used and it wasn't activated at the time.

Many Android password managers turn on a11y services.

Many Android password managers turn on a11y services.

Is that still true? I was under the impression that in recent versions of Android that's heavily discouraged and most PW managers have switched to the appropriate APIs for this.

That may be but most people using Android are still on older versions right?

SemanticsBinding.instance.accessibilityFeatures returns [] (is this the right way to check?)

I believe that would work. To be sure you can check whether RendererBinding.instance.pipelineOwner.semanticsOwner is null. If it is, and you're seeing substantial amount of time spend in code related to semantics, we need to investigate why semantic information are computed even though semantics are turned off (cc @chunhtai).

In profile mode, I get <optimized out>#44923 whereas in debug mode I get  SemanticsOwner#b7afa

@guidezpl That means something on your device is turning on semantics, which explains why you're seeing the performance penalty of calculating semantics.

I wonder if we're caching the rect calculations, and if we could just somehow short-circuit some logic for list views if we realize the list item has the same dimensions as an item we've already calculated.

Just caching the rects is probably not sufficient because some of them do change when you scroll. But some kind of smarts to figure out what can be cached is probably needed here (see also https://github.com/flutter/flutter/issues/28204#issuecomment-530616318 for why we cannot cache the full thing).

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.251, on Mac OS X 10.15.6 19G2021
    x86_64, locale en-GB)
    • Flutter version 1.22.0-10.0.pre.251 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision d26268bb9e (13 hours ago), 2020-09-18 09:06:26 +0900
    • Engine revision 2abe69c608
    • Dart version 2.10.0 (build 2.10.0-136.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0, Build version 12A7209
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.6 19G2021
      x86_64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      85.0.4183.102

• No issues found!

I'm verifying this on the latest master channels 3.7.0, it seems the issue still persists when I can see the most jank at the end of scrolling (back to top of list from my end)

Adding recorded video and timeline trace JSON file:

Demo (with TalkBack)
https://user-images.githubusercontent.com/104349824/212310894-dd66d8a0-0fc0-460a-b8f1-bd721de9312f.mp4

Demo (without TalkBack)
https://user-images.githubusercontent.com/104349824/212311013-f25c5f32-a14a-4924-8999-96fccaeed4e0.mp4

(timeline trace JSON - with TalkBack)
dart_devtools_2023-01-13_18_24_21.081.json.zip

Sample code
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(),
        body: _buildListViewBody(),
      ),
    );
  }

  Widget _buildListViewBody() {
    return ListView(
      children: List.generate(
        100,
        (index) => _buildContainer('Text $index'),
      ),
    );
  }

  Widget _buildContainer(String text) {
    return SingleChildScrollView(
      child: Container(
        height: 200,
        decoration: BoxDecoration(border: Border.all(color: Colors.blue)),
        child: Center(child: Text(text)),
      ),
    );
  }
}

flutter doctor -v (master)
[!] Flutter (Channel master, 3.7.0-20.0.pre.26, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.7.0-20.0.pre.26 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f7b444e117 (17 minutes ago), 2023-01-13 03:11:08 +0100
    • Engine revision 8aa26baa9d
    • Dart version 3.0.0 (build 3.0.0-119.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.56.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 108.0.5359.124

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Viseme not lip-syncing

Hello,
Thanks for this project. I haven't found anything close to doing what I wanted.
I'm having trouble getting the avatar's lips to move. I have a backend process that will call Azure's TTS service. I store the audio (base64), an array a visemes, and words. That API also converts from nanoseconds to seconds since I saw your Azure example dividing the offsets by 10000. Using the code from the index.html file, I convert the JSON I get back to the words/visemes that your code is expecting (mapping, etc.)
I then call speakAudio providing a speak object. The audio plays and the subtitles work, but as I said, the avatar's lips do not move.
Here's a minimal sample. I use WebStorm's built-in serve functionality to host it locally.
Please let me know if you have any thoughts on what I can do to get this working. If you have a ko-fi or something, I'd be happy to donate.

The starting times and durations for both the words and visemes should be provided to the TalkingHead class in milliseconds. In your JSON file, the offset for the first word is 50, which seems right. Now, since the units should be the same, the offset for the first viseme of that word should be approximately the same, but it is 500000. So, all you need to do is divide the viseme offsets by 10000.
You should perhaps fix the units in your backend process, but to test this, I downloaded your code and made the following change, and it worked perfectly.
// const time = e.AudioOffset;
const time = e.AudioOffset / 10000;

By providing the example code of the issue, you made it very easy for me, so thank you. I was happy to help.

THANK YOU!
I did wonder if this was an offset issue. You know what it was?? In the backend I had done the conversion but missed the viseme. After I had already generated my test JSON (to avoid Azure), I fixed the viseme offset, but I didn't regenerate the test JSON file.
Ugh. Feel so stupid now lol.
As one OSS dev to another, I know how important sample code is. My issue templates for my more popular repos always include a text box for sample location.
Aside: As I was trying to debug and understand what was happening, I converted the module to typescript. It's not very pretty right now, but if you're interested in what I have, I'm happy to share it.

resolved


Add Build Workflow

See https://github.com/flywire/libreoffice_ooodev_ext/actions/runs/5873986185 - download development build at the bottom. Repo needs refactoring a bit and it creates the wrong PythonPath. Could do something similar to build a production version too.
An oxt file is a zip file. You could zip the folder and rename with an oxt extension but it seems an action will zip any file without a zip extension.

Build
This repo has a custom build process.
I wrote the tooling into this repo to build the extension.
python -m app build

This will build the extension using the current version of OooDev that has been installed by poetry.
So when a new version of OooDev becomes available the proces is as follows.
Update the version in the pyproject.toml file:
[tool.poetry]
name = "OOO Development Tools Extension"
version = "0.12.2"

Run the build command.
python -m app build

Thats it! This will replace the OooDev.oxt file in the dist folder with the current version.
Note: the oxt folder is source files that contain placeholders (tokens) and are copied and modified into a build folder during the bulid process.
Process
This proces is as follows:

oxt folder contents are copied into build folder
the build/pythonpath gets emptied
All OooDev revelent Packages in the current .venv/../site-packages get copied into build/pythonpath folder.
All __pycache__ folder are clean from build/pythonpath/**
The build/pytonpath now get zip into build/pythonpath.zip and the build/pythonpath folder gets removed
The build folder now get zipped, copied into dist folder and renamed to OooDev.oxt

See the src/build.py to see the steps.
For several reason, internally for the OooDev.oxt has a pythonpath.zip instead of a pythonpath folder.
I use a 'job' see oxt/job.xcu, to hook LibreOffice startup and add pythonpath.zip to The LibreOffice python path.
Python supports using a zip file as a valid import path.
Automating with a Workflow
I suppose it is possible to do this for this project but it would be much different then the yaml file that was pointed to above.
The workflow would have to incoperate updating (poetry update), Update the project toml and then call python -m app build.


WARNING: Warning: Falling back to static signature algorithm [youtube] XC-Im_kRPxM: Downloading js player new WARNING: Automatic signature extraction failed: Traceback (most recent call last):

cannot download this video
https://www.youtube.com/watch?v=XC-Im_kRPxM
getting error
WARNING: Warning: Falling back to static signature algorithm
WARNING: Automatic signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 957, in _decrypt_signature
video_id, player_url, len(s)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 331, in _extract_signature_function
player_type = id_m.group('ext')
AttributeError: 'NoneType' object has no attribute 'group'
WARNING: Warning: Falling back to static signature algorithm
ERROR: unable to download video data: HTTP Error 403: Forbidden

You are using an outdated version of youtube-dl. See our FAQ on how to update.


Compiling Rust projects in a bind mount causes a "Too many open files" error

When I try to compile a reasonably large Rust project from within a bind-mounted persistence location, cargo fails with "Too many open files" so reliably that it's become nearly impossible to successfully compile any of my projects. I've found this is dramatically worse when using the mold linker, but still occurs regularly with the default linker.
In the best cases, I can compile the code by continuously restarting the build and relying on incremental compiles to slowly inch it along, and in most cases (namely tests), the build will never succeed no matter how many times I restart it.
I've tried increasing ulimit -n to a ridiculously large number<PHONE_NUMBER>), and this still happens. From what I've read, increasing this limit to a number this large is far from a solution so I'd like to figure out the root cause of this but I'm at a loss. My guess is something cargo/rustc is doing is leaking FDs in the fuse FS.
Any advice would be greatly appreciated. I understand this may not be an issue with impermanence but I'm asking here to at least get an idea of where to look next.

Related issue in the cargo repository with straces: https://github.com/rust-lang/cargo/issues/14437

I commented this in that thread, but I was able to fix this by moving all of my home folder mounts to the system config with environment.persistence."path".users.myuser. This makes impermanence use bind-mounts instead of bindfs which is also dramatically more performant.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/too-many-open-files-when-the-gradle-cache-is-persisted-via-impermanence/51560/3


Nix store cache

Right now, only the shell environment is cached. This is good, but it means that every deployment must be fetched from the Nix binary cache every single time.
Ideally, we should use GitHub Actions' cache to cache everything in /nix/store (after we GC what we don't need). This will allow us to persist a /nix/store after each deployment.

Implemented in https://github.com/diamondburned/acm-aws/commit/999ef4671b812c6ef43f33bd47b141b1ddbfffe3.


When pause video, ads load again

Hi @shawnbuso , Maybe you can help me, sometimes, after preroll run one time and jump for my video correctly, if i pause my video, adsloader run again and show me again ads..
You can see in http://rr.sapo.pt/videojs/imagoogle.html

Okay, I think I got it sorted out. Because of the mobile versions, it had the following code:
player.one(startEvent, function () {
player.ima.initializeAdDisplayContainer();
player.ima.requestAds();
player.play();
});
if i remove player.ima.requestAds(); ,i think it works

What you did by mistake is what I needed to do intentionally and this helped me out, thanks, buddy!


Display does not include timezone offsets

When initially clicking on the field, the value is set to the current datetime. If the current datetime includes an offset, then the value includes that offset, but the display does not.
Example:
https://jsfiddle.net/ms9jh1d6/1/
Running this example in a timezone with an offset (e.g. UTC +01:00) at 14:00 results in the following:

A "getTime" value of 13:00 + 01:00
A display value of 13:00

Really it should have a display value of 14:00, as that is what the time is for the user.

This is not a bug.
Display the result as you do in the example gives you automatic timezone adjustment.
The complexity of timezone management is up to you. Internally, the plugin uses UTC only. It accepts UTC,  it uses UTC,  it returns UTC.
Why it is so: For example, in Russia railroad use Moscow timezone, in  Kazakhstan it uses local timezone, at the same time aeroports give information in local timezone in both countries. Timezone transformation for all of this use-cases is a very peculiar thing and can not be handled by plugin.
My suggestion to you would be in using timezone.js library and manage offsets by yourself.

I believe @Martin-Cox means, that Date returned by plugin does not match the one it displays. And I agree with him. No matter what way you handle timezones - the value and display should be the same.

Plugin always return date in UTC TZ.
If you notice, the time in the input is not in your local timezone, it is in UTC too.
Even if you pass options
$('selector').datetime({                 datetime: '01/03/1976 21:53',                 locale: 'ru',                 format: 'dd L yyyy HH:mm '             });
the input field will contain UTC.  03 января 1976 15:53 , not 03 января 1976 20:53 (for my local TZ)
This is made on purpose i mentioned above, and will not be changed.
If you want to get your local time - add your time offset manually.
const yourLocalOffet = (new Date()).getTimezoneOffset();

@ua9msn well, I got your point, but from user perspective - it looks a bit confusing.
I'm passing in the new Date() value, which resolves into Fri Apr 14 2017 20:12:37 GMT+0200, depending on the timezone we are in. Please, note the GMT+0200 part of it.
And, your plugin displays not 20:12:37, but a 18:12:37, dropping down the time zone offset - which is really unexpected. I'd expect plugin to display me the datetime I've passed in - 20:12:37, and return back the Date instance with the same TZ offset (+2 in this particular example).
Couldn't we have a respect of initial TZ offset of the Date instance we pass in? Because, currently, to workaround that behavior, I have to add/subtract the TZ difference before providing my date to your plugin, and subtract/add same difference, when I read it back. These steps should be handled by the plugin natively, I believe.

Version 2 now has flag useUTC.


RSI gives different result with Bittrex

I try to put period from Bittrex to 18 to match strategy from the source code but it still gives the different result.
So I make another test is to increase the period to 100 from source code and Bittrex, what I expect is RSI should around 45~55 but it doesn't.

To match bittrex, period count has to be a high number like 10000 in order to get all possible history for the market. This is because bittrex uses all available data to calculate RSI.


Integration tests for project resources extension

Depends on https://github.com/rancher/rancher/pull/40155 and https://github.com/rancher/rancher/pull/40310

Closing in favor of https://github.com/rancher/rancher/pull/41536


We need an "AWS" version of this

That uses all the AWS components to realize the same application

Good idea if that's fit your practice!
In than case, we could:

Add abstractions for

Queue (Queue Storage / SQS)
Blob (Blob Storage / S3)
Monitoring (App Insights / Distro for OpenTelemetry)

Add a configuration file with a switch + config from those providers

First part of the job is done with the v1.5.0: Local Storage has been added in addition to Azure Storage.
You can now implement the AWS SDKs and push your PR!
Also, in the meantime, Mountpoint for Amazon S3 can be a viable option for you.


⚠ ClamAV has degraded performance

In 727a845, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 192 ms

Resolved: ClamAV performance has improved in 3634220.


Fix no fee account creation issue 378

Goal
The goal of this PR is
Closes
Discussion

Checklist

[ ] Chain spec updated
[ ] Updated the js/api-augment code if a custom RPC added/changed
[ ] Design doc(s) updated
[ ] Tests added
[ ] Benchmarks added
[ ] Weights updated

NOT READY FOR REVIEW


Require jupyter-server-proxy 4+

We don't have tests to verify things work with old versions of jupyter-server-proxy, so it feels good to enforce something new now that we are about to release a new major version.

sure why not


SE0288_IsPower

This patch implements SE0288 in the swift evolution staging repository.
The corresponding pull request against the main Swift repository is apple/swift#24766.

Hi, @dingobye 👋🏻 — we'd like to get this added to the preview package, since it's been approved through the evolution process. I'm going to close this PR, since this repo is for proposals that are going under review.
Could you open a PR to add it to the preview package repo here? You can follow the example of the RangeSet package.
https://github.com/apple/swift-standard-library-preview/


[Lunacy idea] Porting the TGS CI/CD pipeline to automate generation of releases + changelogs + milestones

Its a tall order, and absolutely fuelled by lunacy, but it may be something worthwhile?

(MITAGPL anyway)
Can't use it here then

(~MIT~AGPL anyway)

Can't use it here then

I'll re-create it in a different language and not take direct code samples.

I'm the only author on those files, you can just copy whatever you want


nextcloud-client 3.9.2 -> 3.9.3

Description of changes

Things done
Diff: https://github.com/nextcloud/desktop/compare/v3.9.2...v3.9.3
Changelog: https://github.com/nextcloud/desktop/releases/tag/v3.9.3

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250602 run on x86_64-linux 1

1 package failed to build:

nextcloud-client.dev

1 package built:

nextcloud-client

Result of nixpkgs-review pr 250602 run on x86_64-linux 1

2 packages built:

nextcloud-client
nextcloud-client.dev

Thank you for the update!

Result of nixpkgs-review pr 250602 run on x86_64-linux 1
1 package failed to build:
1 package built:

Weird that my build failed, I was building it remotely on a train with cellular connection...


Qingwei/disable range selector in purchase

Changes Unknown when pulling b4b617f95bd7d7cf78b322affa4f2d4a8bf30394 on qingweibinary:qingwei/disable_range_selector_in_purchase into ** on binary-com:master**.


proper_sync_dynamic_cb build fails

The culprit is line # 198 in VulkanDevice.cpp
queueFamilyIndices.graphics = VK_NULL_HANDLE;

Yeah, it's a work in progress branch. Please don't clone and try it yet. It's also missing a lot of changes that I haven't committed yet.

I have pushed a fix for this. But as noticed above, please note that this branch is still heavy work-in-progress and doesn't include all changes to e.g. the base code to properly work.


ToDoApp - BackEnd - SpringBoot

@ajjayymahato  i would love add backend to your project assign me please...

@bhavnapandit Sure


SpdxDeclaredLicenseMapping: Add 'Amazon Software License'

As found in https://repo.maven.apache.org/maven2/com/amazonaws/amazon-kinesis-client/1.7.5/amazon-kinesis-client-1.7.5.pom,
see also https://github.com/nexB/scancode-toolkit/blob/v3.1.1/src/licensedcode/data/licenses/amazon-sl.LICENSE.
Signed-off-by: Frank Viernau<EMAIL_ADDRESS>

see also https://github.com/nexB/scancode-toolkit/blob/v3.1.1/src/licensedcode/data/licenses/amazon-sl.LICENSE.

Nit: I believe it makes more sense to refer to ScanCode v3.0.2 here, as that's the version currently used by ORT by default.

Nit: I believe it makes more sense to refer to ScanCode v3.0.2 here, as that's the version currently used by ORT by default.

@sschuberth agree, changed it.

/rebase

Merge regardless of the unrelated failure on travis.


General: evaluate the use of GitHub Codespaces to provide a standard environment for admiral development

Background Information
GitHub has recently offered something called Codespaces.  I think it may be very helpful in a number of different package development initiatives, including admiral.
My understanding: as part of a repository, you can attach a development environment which is perfectly tailored for that specific project. This could be useful for setting up a training class or for ensuring all development on a specific repo is done in an identical environment. Potential use cases:

We put effort (NAMESPACE, DESCRIPTION) into ensuring the USERS of admiral have all the packages necessary, and the expected versions of those packages, in their environment so that admiral will work correctly. But we do not do the same for the community of DEVELOPERS, who are left on their own to ensure they have R 4.0.5, the correct version/edition of devtools (2.3.2), testthat (3e), etc. set up in their environment. While some are fortunate to have a standard, company-provided environment available to them, many others are left to fend for themselves.
A workshop on Bookdown, for example, requires Tinytex, etc. to be available with some underlying OS software. This could be challenging for some attendees and tedious/time-consuming for others. And it all gets in the way of the goal of learning about Bookdown. Setting up the environment along with the course content in a repo allows attendees to work in an identical environment customized for the content, e.g. all of the Latex-related software and packages pre-installed. And, since this is accessed through a web browser, someone with limited hardware, e.g. a Google Chromebook, has the same experience as others.
rstudio::conf(2022): "Zero-setup R workshops with GitHub Codespaces" (David Smith): "What if you could host a workshop using R that required no setup from the participants at all? With GitHub Codespaces, a GitHub repository becomes a cloud-based engine for running R in a container with a single click. Every participant, regardless of the power, configuration or operating system of their laptop will have the same experience, all with NO setup in advance." [GitHub repo]

Definition of Done

Determine costs involved, if any.
Determine if a standard admiral development codespace can be defined, created and used for development work. Does devtools, testthat, pkgdown all work as needed?
Determine the difficulty in modifying the codespace, e.g. if we decide to use a newer version of R or a newer version of packages.
Determine the difficulty in porting and modifying the codespace to admiraldev, admiralonco, etc.

FYI @cicdguy as discussed.
@esimms999-gsk see message on our dev slack about rocker alternative.

An example of why this could be of benefit: admiraldev issue #220.

Hi @esimms999-gsk, at the end of David Smith's presentation, he mentions that GitHub CodeSpaces are available with GitHub Enterprise and GitHub Education, so I wonder whether we would be able to use them on the regular, public GitHub?

@fshanlee I believe that Codespaces was rolled out to the public GitHub in late 2022. I have managed to spin up an RStudio/R4.0.5 codespace in my private GitHub account,but am having some difficulty figuring out the userid/password to use to logon. :( I hope to find some time to get this working and the steps documented.
@rossfarrugia Great to hear!

Going to move this to admiralci


Harmonize the approach to displaying the "page load" message

Here's how:

When loading a new page (whether list, paged list or details), turn on the "Loading" message in the upper right corner. Don't use anything else in the page.
When loading just a section of a page, use a spinner icon where the new content will appear.

Also need to figure out a way to do this without copy/pasting the page loader on every view. Ideally we want it on the index.html page, and be able to fire messages "up" to turn it on/off. AngularJS has some kind of mechanism for this.

This looks nice, especially for the details pages:
http://blog.brunoscopelliti.com/show-route-only-after-all-promises-are-resolved/


Sockets implementation

Hey can you explain this a bit?

Read the contribution guidelines
Join the Gitter for any discussions


improve u30_div3_carry and u30_shr1_carry

This PR improves u30_div3_carry and u30_shr1_carry, also gets rid of some redundancies. This results in minor improvements in some div2, div3, mul, inv, square functions of Fq, Fq2, Fq6, Fq12.

Good catch on the "1 OP_SUB"


Fix 25 issue

This is related to #25.
CC: @MaksVal,  @joaoalf Could you try this PR version ?

@syohex I tried your PR and it works. Thanks!
:+1:

@syohex Thanks for PR !!
@MaksVal @joaoalf Sorry for the delay in my response 🙇

Hi, gongo! Thanks for your fix! :)
I tryed to check it, but I have trouble with connect to server.
OrgRedmine - Not retrieved: Can't find issue #5094 on https://url-redmine.com/
I know what that https://url-redmine.com/issue/5094.json and my API key is working. I checked it in emacs-w3m.
Do you can help me? How I can debug it?
Thanks!!
Sorry for the delay in my response

Hi, gongo! Thanks for your fix! :)
I tryed to check it, but I have trouble with connect to server.
OrgRedmine - Not retrieved: Can't find issue #5094 on https://url-redmine.com/
I know what that https://url-redmine.com/issue/5094.json and my API key is working. I checked it in emacs-w3m.
Do you can help me? How I can debug it?
Thanks!!
Sorry for the delay in my response.

Hi @MaksVal
Thank you for comment. But please create new issue about this problem. 🙇


Can't init Reg of Vec to all 0

Note: for support questions, you are strongly advised to use Stack Overflow.
This repository's issues are reserved for feature requests and bug reports.

Type of issue

[x] Bug report

If the current behavior is a bug, please provide the steps to reproduce the problem:

What is the current behavior?
vecReg seems is a Vec contains 8 8-bit width UInt, but it's value is not zero, print elt has a very strange behaviour
What is the expected behavior?
vecReg is a Vec contains 8 8-bit width UInt
Please tell us about your environment:
(examples)

version: 3.0.0

What is the use case for changing the behavior?

Impact

[ ] unknown

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. Stack Overflow, gitter, etc)
I am writing a register file with two output port, one input port. But I can't create a Reg of Vec which is init
as all 0. The problem seems hide in the RegInit or Reg. Even I get a all zero Vec, RegInit or Reg still generate a strange Register, which seems contain some random value.
this is my RegFile Module and Tester

package core74

import chisel3._

class RegFile() extends Module{
  override val io = IO(new Bundle{

    // three data io port
    val out1  = Output(UInt(8.W))
    val out2  = Output(UInt(8.W))
    val in    = Input(UInt(8.W))

    // three address io port
    val oadd1 = Input(UInt(3.W))
    val oadd2 = Input(UInt(3.W))
    val iadd  = Input(UInt(3.W))
  })

  val regVec = Reg(init = Vec(Seq.fill(8)(UInt(0, 8.W))))

  for(elt <- regVec){
    println(regVec.length)
    printf(p"0x${Hexadecimal(elt)} ") // this printf will print tons of strange number
    assert(elt === 0.U) // can't pass the assert
  }

  regVec(io.iadd) := io.in
  io.out1 := regVec(io.oadd1)
  io.out2 := regVec(io.oadd2)

}

package core74

import chisel3.iotesters._

import scala.util.Random

class RegFileTests(c: RegFile) extends PeekPokeTester(c) {

  val io = c.io
  val regWidth = io.out1.getWidth
  val addWidth = io.iadd.getWidth

  var state: Array[Int] = Array.fill(1 << addWidth){0}

  /* open this comment then the register is set to all zero
  for(i <- 0 until 1 << addWidth) {
    poke(io.iadd, i)
    poke(io.in, 0)
    step(1)
  }
  */

  for(j <- 0 until 1 << addWidth; k <- 0 until 1 << addWidth){
    poke(io.oadd1, j)
    poke(io.oadd2, k)

    step(1)

    expect(io.out1, 0)
    expect(io.out2, 0)
  }

  for(i <- 0 until 10000){
    val rand = Random.nextInt(1 << regWidth)
    val randin = Random.nextInt(1 << addWidth)
    state(randin) = rand
    poke(io.iadd, randin)
    poke(io.in, rand)
    step(1)

    for(j <- 0 until 1 << addWidth; k <- 0 until 1 << addWidth){
      poke(io.oadd1, j)
      poke(io.oadd2, k)
      step(1)
      expect(io.out1, state(j))
      expect(io.out2, state(k))
    }
 }
}

There are two issues with this code:

the elements of regVec will only be zero during reset or as long as as io.in is 0,
the tester doesn't initialize io.iadd and io.in so these will have random values, updating regVec once reset is de-asserted.

The fix is to replace the unconditional regVec assertion in RegFile:
  for(elt <- regVec){
    println(regVec.length)
    printf(p"0x${Hexadecimal(elt)} ") // this printf will print tons of strange number
    assert(elt === 0.U) // can't pass the assert
  }

with a conditional test:
  val regVecChanged = RegInit(false.B)

  when (!regVecChanged) {
    for (elt <- regVec) {
      println(regVec.length)
      printf(p"0x${Hexadecimal(elt)} ") // this printf will print the initial values of regVec
      assert(elt === 0.U) // can pass the assert as long as we haven't changed regVec
    }
    printf("\n")
    regVecChanged := io.in =/= 0.U
  }

and add the following initialization code to RegFileTests:
  // Ensure the circuit is initialized.
  poke(io.iadd, 0)
  poke(io.in, 0)
  reset()

before the first expect loop.
Thanks for providing the circuit and its tester. This helps us duplicate the problem.


Removing unused reference (grpc container in mock service)

This no longer necessary after https://github.com/googleapis/toolkit/commit/702e06aa02bb48cdb74a61eebf1bce41039bea7c (since you can call bindService() directly on a service impl)

Current coverage is 81.21% (diff: 100%)

Merging #498 into master will decrease coverage by <.01%

@@             master       #498   diff @@
==========================================
  Files           221        221
  Lines          8293       8290     -3
  Methods           0          0
  Messages          0          0
  Branches       1099       1099
==========================================
- Hits           6736       6733     -3
  Misses         1257       1257
  Partials        300        300

Powered by Codecov. Last update 702e06a...2c86acc


ChatGPT integration

How difficult would it be to integrate ChatGPT to:
A) read threads and like/unlike/comment based on whitelisted topics of interest extracted from the thread?
B) post new threads automatically given ChatGPT output

It shouldn't be too difficult, but that mainly has to do with OpenAI's API. For the whitelisting of topics you could see OpenAI's Embeddings. That should be able to match a thread post to a topic.

That makes sense @jtams. I'd have to play with it and see how it can be used programmatically to automate a few things ;)

@Mineru98 is doing that in https://github.com/junhoyeo/threads-py 💪

This shouldn't be part of threads-api as it's not related to threads or what an API is about. But it's a great idea for built with threads-api 💯


Size of exported pdf

Hello,
iam using in dotnet web api 6.0 and I noticed that when I export the pdf through the api, the file size is much larger than when exporting through the Community designer.
I created my report like this
webReport = new WebReport();
string path = Path.ChangeExtension(reportFilePath, "frx");
webReport.Report.Load(path);
webReport.Report.Dictionary.DataSources.Clear();
webReport.Report.Dictionary.ClearRegisteredData();

webReport.Report.Dictionary.RegisterBusinessObject(
    data: data,
    referenceName: "data",
    maxNestingLevel: data.Count(),
    enabled: true);

webReport.Report.RegisterData(
    data: data,
    name: "data");

webReport.Report.Prepare();

MemoryStream stream = new();
webReport.Report.Export(new PDFSimpleExport(), stream);
stream.Flush();
stream.Position = 0;

return new FileDTO(
    content: stream,
    contentType: "application/pdf",
    filename: "report.pdf");

The report is in the following layout

Size in API: 277 kb
Size in designer: 171 kb
In the designer I press CTRL + P and use the microsoft printer for pdf.
If there is any suggestion to decrease the size I would appreciate it.
thanks

The size of a PDF is because PDFSimpleExport transform content in a pdf/embeded image.

The size of a PDF is because PDFSimpleExport transform content in a pdf/embeded image.

Yeah. Do you know some alternative?

You can export to HTML and use another tool to transform content in a pdf

You can export to HTML and use another tool to transform content in a pdf

ah ok. Do you have any suggestion to transform in pdf?

I recomend try two packages, PuppeteerSharp (this is a port of a nodejs package, and use chromium V8 or itext7

In version 2024 of Community Designer CTRL + P is disabled, what a pitty :(


[ServiceBus] update Message.data type

fixes: #35424
Updating the type, as it is currently incorrect and the Message.data type should include Iterable[bytes].

API change check
API changes are not detected in this pull request.


Fix disk size attribute

#1249  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite