preventCurveOverShooting  troubles

Hey,
Thanks for a great chart package, which I really enjoy using.
But I'm encountering troubles with the preventCurveOverShooting option.
My Graphs with curving:

My Graphs with curving and preventCurveOverShooting:

As you can see in the middle graph, there is an overshooting around 12/27, which is gone with preventCurveOverShooting=true.
Unfortunately, the graph has now curves where there is no need (e.g. black line between 12/06 an 12/11) and spaces between the line and the BetweenBarsData.
Code:
Widget build(BuildContext context) {
if (values.isEmpty) {
return SizedBox(height: thirdHeight);
}
Map<String, dynamic> newValues = _calculateData(values);
double maxY = _getExtreMax(newValues);
return SizedBox(
height: thirdHeight,
child: Column(
children: [
_titleRow(title),
SizedBox(
height: 8,
),
SizedBox(
height: thirdHeight - 42,
child: LineChart(
LineChartData(
lineTouchData: LineTouchData(
enabled: true,
touchTooltipData:
LineTouchTooltipData(fitInsideVertically: true)),
betweenBarsData: [
BetweenBarsData(
fromIndex: 0,
toIndex: 1,
color: colorListShort[1].withOpacity(.6),
),
BetweenBarsData(
fromIndex: 1,
toIndex: 2,
color: colorListShort[2].withOpacity(.6),
)
],
backgroundColor: stodiaWeiss,
minX: 0,
maxX: chartLength,
maxY: maxY,
minY: 0,
gridData: FlGridData(
verticalInterval: vertInterval,
horizontalInterval: gridIntervalHoriz,
),
borderData: FlBorderData(
border: const Border(
bottom: BorderSide(),
left: BorderSide(),
right: BorderSide())),
lineBarsData: _lineList(newValues, maxY),
titlesData: FlTitlesData(
bottomTitles: AxisTitles(
sideTitles:
_getBottomTitles(bottomType, chartLength, context)),
leftTitles: AxisTitles(sideTitles: _leftTitles()),
topTitles:
AxisTitles(sideTitles: SideTitles(showTitles: false)),
rightTitles: AxisTitles(sideTitles: _rightTitles(maxY / 100)),
),
),
),
),
],
),
);
}
Is there a way to fix that which I have not found so far?
Thanks in advance

I thought I was going nuts, thanks!
While I"m here, does anyone know how to stop "over drawing" of data out of the chart area when switching between data types?  I actually like the animation, but if I go from a chart with say Y axis values of 0 to 5, to a chart with values of 0 to 100, it will briefly draw the data way out of bounds before shrinking it back into the chart.
I explicitly set minY and maxY values depending on the data type, but it seems those are not respective for a short duration initially, resulting in a vast overshooting of data prior to the data settling into the chart area.

I didn't understand the issue, why you need to enable preventCurveOverShooting in your case? Because it looks good.
Do you want to have a sharp chart instead of curved corner lines?
Then you can set isCurved: false in your LineChartData


Enhancements to Excel Services

Fixes #225

[X] Change details added to Unreleased section of changelog.md?
[X] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[X] Examples updated for both the single server and small farm templates in the examples folder?
[X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[X] Unit and Integration tests created/updated where possible?

This change is

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Just needs another branch merge, before it can be merged.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


MariaDB

Hi I just have a question.
After bacup restauration it was a problem with Backup of Mariadb files. So is there a possibility to stop the maria service before starting the backup?

I don't really understand the question and how it is related to Samba Backup. Creating snapshots is handled by the supervisor. It is exactly the same if you create a snapshot manually via the UI.
You can always stop the MariaDB addon if you want to, but that's probably not the solution to your problem.

This is a "known" issue with Home Assistant. It does not really have a proper backup infrastructure which means that backups can be created will the sqlite or MariaDB databases are being updated. This is a Home Assistant problem that can happen with manual backups as well.
For more info see this issue: https://github.com/home-assistant/addons/issues/1353
I can't think of a way for this addon to work around that really.

Thanks for the clarification. Now it's much clearer.
But I'm not sure if this addon is really a good location for such workarounds. I would say we have to wait for an official solution from Home Assistant.
Alternatively you could create an automation yourself which triggers shortly before Samba Backup and stops the MariaDB addon until there is an official solution. Something like that:
service: hassio.addon_stop
data:
  addon: core_mariadb

Thx alot... I will try it

I asked this question also on Forum HA this morning. Google Drive Backup have the option to stop addon before backup. When backup is done it will start the addon again. This prevent problems with MariaDB after a restore.

This should not be needed anymore, as MariaDB now locks the tables during backups. See changelog for MariaDB:
2.4.0
- Add lock capabilities during snapshot

I have not tested it myself.

Thats true, read it also but lost the info. I will create a dev HA on a RPi and restore the image and see what happen.


Cannot adjust cart or lineItem in BeforeLineItemQuantityChangedEvent

PHP Version: 8.3.6   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Actual behaviour:
Any change to a lineItem's quantity in the cart passed in the event (or directly to the passed in lineItem) when subscribing to the BeforeLineItemQuantityChangedEvent is disregarded and not applied when the new quantity of said lineItem is calculated.
Expected behaviour:
Changes to lineItems in a cart work when subscribing to the BeforeLineItemAddedEvent, and because of this discrepancy I believe it to be a bug.
How to reproduce:

Subscribe to the BeforeLineItemQuantityChangedEvent
Change any quantity of any item in the cart or modify it in any other way

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-40022
[created from NEXT-40022, comment 525281]

Hey @pm-mariusa,
yes, very true, currently this event is not usable to change the quantity and manipulate it. This is by design, since the Factory should have the final say, if a quantity is changeable. We would recommend you to decorate the CartItemUpdateRoute instead, if you want to manipulate the entered quantity.
While evaluating this issue, we did find that in case of product line items, the quantity is updated twice, which is not really nice. We will have a look at this in the future, but for now, please decorate the aforementioned route.


Where method on DataFrames can't seem to take series as conditions

I want to use where to set values across a DataFrame where a Series meets a condition.
For example:
df=pd.DataFrame({'a':[1,2,3], 'b':[4,5,6]})

But this
df.where(df['a']==2,0)

returns an unedited DataFrame.
Whereas this returns just the middle row, as you'd expect:
df[df['a']==2]

Supplying axis=0 or axis=1 doesn't help. Am I doing something wrong? Or this unintended behavior?

Versions
python: 2.7.6.final.0
pandas: 0.14.1

I believe the cond argument to df.where has to be the same shape as the original df.

@TomAugspurger, that's correct.
Is that desired behavior though? I would think that broadcasting across an index (in the same way as the final example broadcasts) would be desired.

@maximilianr the reason for this is that .where() is shape preserving, IOW it puts nan in the non-matching conditions.
df[df['a']==2] potentially changes the shape of the result. e.g. it can drop rows.
FYI, df.where(df['a']==2) raises (an odd error message), so actually prob need to do some more checking for shape compat (right now it just does a .reindex()).

@jreback Thanks!

This is closed with #10283. Closing


projects with a dependency on the openssl crate seem to always fail

here's an example - https://travis-ci.org/softprops/bin-test/jobs/192443776
error: failed to run custom build command for `openssl v0.7.14`
process didn't exit successfully: `/target/debug/build/openssl-5464f8f6e728c35a/build-script-build` (exit code: 101)
--- stdout
TARGET = Some("x86_64-unknown-linux-musl")
OPT_LEVEL = Some("0")
PROFILE = Some("debug")
TARGET = Some("x86_64-unknown-linux-musl")
debug=true opt-level=0
HOST = Some("x86_64-unknown-linux-gnu")
TARGET = Some("x86_64-unknown-linux-musl")
TARGET = Some("x86_64-unknown-linux-musl")
HOST = Some("x86_64-unknown-linux-gnu")
CC_x86_64-unknown-linux-musl = None
CC_x86_64_unknown_linux_musl = None
TARGET_CC = None
CC = None
HOST = Some("x86_64-unknown-linux-gnu")
CROSS_COMPILE = None
TARGET = Some("x86_64-unknown-linux-musl")
HOST = Some("x86_64-unknown-linux-gnu")
CFLAGS_x86_64-unknown-linux-musl = None
CFLAGS_x86_64_unknown_linux_musl = None
TARGET_CFLAGS = None
CFLAGS = None
running: "musl-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-g" "-m64" "-fPIC" "-static" "-o" "/target/x86_64-unknown-linux-musl/debug/build/openssl-5464f8f6e728c35a/out/src/c_helpers.o" "-c" "src/c_helpers.c"
cargo:warning=src/c_helpers.c:1:25: fatal error: openssl/ssl.h: No such file or directory
cargo:warning=compilation terminated.
ExitStatus(ExitStatus(256))
command did not execute successfully, got: exit code: 1
--- stderr
thread 'main' panicked at 'explicit panic', /cargo/registry/src/github.com-1ecc6299db9ec823/gcc-0.3.41/src/lib.rs:1018
note: Run with `RUST_BACKTRACE=1` for a backtrace.```

v0.1.4: Pulling from japaric/x86_64-unknown-linux-musl
openssl v0.7.14

Use cross v0.1.6. v0.1.4 only supports openssl 0.8 and newer.

I updated the --tag param in my ci/install.sh to v0.1.6 script but I still get the same error https://travis-ci.org/softprops/bin-test/jobs/192446534. Is there any other debug info I could try and grab?

Is there any other debug info I could try and grab?

Pass -v to cross then it will all the shell commands it calls, in particular the Docker command.
You could also test locally, i.e. run cross build locally.
I'm not sure what's wrong with your build because I can build hyper with cross v0.1.6 just fine :-(.

I'll try that. It's hyper im targeting as well. I've had some issues with it an openssl in the past with containers but trust looks pretty promising so I wanted to try a few tests with the simplest setup I could make

Here's a build with more verbose output https://travis-ci.org/softprops/bin-test/jobs/192480484
I'll try repeating locally on my mac

Here's some more local diagnostics ( from my mac )
rustc 1.14.0 (e8a012324 2016-12-16)

cross 0.1.6
cargo 0.15.0-nightly (298a012 2016-12-20)

Client:
 Version:      1.13.0-rc5
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   43cc971
 Built:        Thu Jan  5 03:07:30 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      1.13.0-rc4
 API version:  1.25 (minimum version 1.12)
 Go version:   go1.7.3
 Git commit:   88862e7
 Built:        Sat Dec 17 01:34:17 2016
 OS/Arch:      linux/amd64
 Experimental: false

The build seems to fail even faster locally, this time with a different error. I'm not sure if this is because I can't build linux targets locally.
+ "cargo" "build" "-v" "--target" "x86_64-unknown-linux-musl"
   Compiling log v0.3.6
   Compiling matches v0.1.4
   Compiling unicode-normalization v0.1.3
   Compiling traitobject v0.0.1
     Running `rustc /Users/dougtangren/.cargo/registry/src/github.com-1ecc6299db9ec823/log-0.3.6/src/lib.rs --crate-name log --crate-type lib -g --cfg feature=\"default\" --cfg feature=\"use_std\" -C metadata=bf16bb9a4912b11d -C extra-filename=-bf16bb9a4912b11d --out-dir /Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --emit=dep-info,link --target x86_64-unknown-linux-musl -L dependency=/Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --cap-lints allow`
     Running `rustc /Users/dougtangren/.cargo/registry/src/github.com-1ecc6299db9ec823/matches-0.1.4/lib.rs --crate-name matches --crate-type lib -g -C metadata=3614821dd5ceb75c -C extra-filename=-3614821dd5ceb75c --out-dir /Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --emit=dep-info,link --target x86_64-unknown-linux-musl -L dependency=/Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --cap-lints allow`
     Running `rustc /Users/dougtangren/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-normalization-0.1.3/src/lib.rs --crate-name unicode_normalization --crate-type lib -g -C metadata=77ce7c413abacd3f -C extra-filename=-77ce7c413abacd3f --out-dir /Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --emit=dep-info,link --target x86_64-unknown-linux-musl -L dependency=/Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --cap-lints allow`
     Running `rustc /Users/dougtangren/.cargo/registry/src/github.com-1ecc6299db9ec823/traitobject-0.0.1/src/lib.rs --crate-name traitobject --crate-type lib -g -C metadata=516160771d9db60e -C extra-filename=-516160771d9db60e --out-dir /Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --emit=dep-info,link --target x86_64-unknown-linux-musl -L dependency=/Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --cap-lints allow`
error[E0463]: can't find crate for `std`

error: aborting due to previous error

error[E0463]: can't find crate for `std`

error: aborting due to previous error

Build failed, waiting for other jobs to finish...
Build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `std`

error: aborting due to previous error

Build failed, waiting for other jobs to finish...
error[E0463]: can't find crate for `std`

error: aborting due to previous error

error: Could not compile `traitobject`.

Caused by:
  process didn't exit successfully: `rustc /Users/dougtangren/.cargo/registry/src/github.com-1ecc6299db9ec823/traitobject-0.0.1/src/lib.rs --crate-name traitobject --crate-type lib -g -C metadata=516160771d9db60e -C extra-filename=-516160771d9db60e --out-dir /Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --emit=dep-info,link --target x86_64-unknown-linux-musl -L dependency=/Users/dougtangren/code/rust/bin-test/target/x86_64-unknown-linux-musl/debug/deps --cap-lints allow` (exit code: 101)```

Here's some more local diagnostics ( from my mac )

Ah, sorry. cross doesn't support macs as the host :-(.

Can you link me to one of those working repos with hyper in travis ci? Maybe I can try locking down my version numbers. I'm testing with the latest of the 0.9 series https://github.com/softprops/bin-test/blob/master/Cargo.toml

Can you link me to one of those working repos with hyper in travis ci?

I actually tested it locally and with your repo. Both on stable and on nightly.

Ok. I'll read up on travis config docs

Wanted to followup. I had better luck with trust on travis with the new latest version of hyper  (0.10) which removes it's dependency on openssl and combined with the hyper-native-talk crate. Leaving a comment here in case others run into the same issues.


No Module named 'src'

Hey I was trying to set this up but after following all the instructions listed, I am not getting any results, just this error. I'm pretty new at this, so I would love if someone can tell me what I might of done wrong or be missing.

I am running Python 3.11
I have to say though I am quite a novice with this and if you could explain your suggestion like you would to a child, that might be more helpful for me, heh.. As I don't understand the suggestion. (I'm sorry!) But I thank you for your response and your time! I also posted in the discord where you pointed me to.


Using the default language image for search results

Translated nodes might not always have a unique cover image,
so this code will use the node's default language image if
the current langugage does not have a cover image.
This construct probably appears in multiple places, and we could
eventually refactor this with a helper like dosomething_helpers_get_cover_image()

Resolves #5059

:+1: looks good, but can you make a new issue to refactor this later?


Concordance...

One thing that could be done to make this project even better would be to include a concordance as well.

Agree with this feature request. Will see if I can find some time to implement.
The main points of consideration are:

general word/phrase search (e.g. google for the bible)
curated concordance. This has its use but can be biased due to the biases of the curator.

I'll prioritize 1. But might be able to follow up with 2 at a later date.

Thank you for taking into consideration my suggestion and deciding to implement it.  God bless.
On Jun 16, 2024, 11:51 AM, at 11:51 AM, Peter Stephens @.***> wrote:

Agree with this feature request. Will see if I can find some time to
implement.
The main points of consideration are:

general word/phrase search (e.g. google for the bible)
curated concordance. This has its use but can be biased due to the
biases of the curator.

I'll prioritize 1. But might be able to follow up with 2 at a later
date.
--
Reply to this email directly or view it on GitHub:
https://github.com/pstephens/kingjames.bible/issues/47#issuecomment-2171768775
You are receiving this because you authored the thread.
Message ID: @.***>

I found a website that might be of interest to you in regards to this matter.  The website is http://kjvbible.net/.


hash fix: wait to run scrollIntoView

I'm working on porting minidocs to choo v5 and found a couple issues with hash behavior.
I'm open to revising things if needed, or even just using this PR as inspiration for better ones if there are other ways to solve things.
Here's a description of changes:
scrollIntoView
I found that the check for an id was failing because it needed to wait for the next tick: https://github.com/yoshuawuyts/choo/blob/master/index.js#L113
This PR puts scrollIntoView inside a setTimeout.

edit: removed createLocation changes

Just as an example, it looks like Next.js is wrapping it's scrollIntoView in a setTimeout here (commenting that it won't scroll properly otherwise)
https://github.com/zeit/next.js/blob/97c472c0c8419d7d032c5f98e21123968b63b869/lib/app.js#L45-L53

@jekrb ah, good to know other folks have come up against this.
I've revised this PR to be just for wrapping scrollIntoView in a setTimeout, and will open another with a revised approach for handling hash routing.

v5.0.3


rbd: utilize cookie support from rbd for nbd

Describe what this PR does
Problem:
On remap/attach of device (i.e. nodeplugin restart), there is no way for rbd-nbd to defend if the backend storage is matching with the initial backend storage.
Say, if an initial map request for backend "pool1/image1" got mapped to /dev/nbd0 and the userspace process is terminated (on nodeplugin restart). A next remap/attach (nodeplugin start) request within reattach-timeout is allowed to use /dev/nbd0 for a different backend "pool1/image2"
For example, an operation like below could be dangerous:
$ sudo rbd-nbd map --try-netlink rbd-pool/ext4-image
/dev/nbd0
$ sudo blkid /dev/nbd0
/dev/nbd0: UUID="bfc444b4-64b1-418f-8b36-6e0d170cfc04" TYPE="ext4"
$ sudo pkill -15 rbd-nbd   <-- nodeplugin terminate
$ sudo rbd-nbd attach --try-netlink --device /dev/nbd0 rbd-pool/xfs-image
/dev/nbd0
$ sudo blkid /dev/nbd0
/dev/nbd0: UUID="d29bf343-6570-4069-a9ea-2fa156ced908" TYPE="xfs"

Solution:
rbd-nbd/kernel now provides a way to keep some metadata in sysfs to identify between the device and the backend, so that when a remap/attach request is made, rbd-nbd can compare and avoid such dangerous operations.
With the provided solution, as part of the initial map request, backend cookie (ceph-csi VOLID) can be stored in the sysfs per device config, so that on a remap/attach request rbd-nbd will check and validate if the backend per device cookie matches with the initial map backend with the help of cookie.
At Ceph-csi we use VOLID as device cookie, which will be unique, we pass the VOLID as cookie at map and use the same at the time of attach, that way rbd-nbd can identify backends and their matching devices.
Requires:
https://github.com/ceph/ceph/pull/41323
https://lkml.org/lkml/2021/4/29/274

[x] Require PR https://github.com/ceph/ceph/pull/41323

Signed-off-by: Prasanna Kumar Kalever<EMAIL_ADDRESS>

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

DNM waiting for https://github.com/ceph/ceph/pull/41323

tests are failing:
STEP: create a PVC and bind it to an app with normal user
Sep 30 06:45:48.183: INFO: Waiting up to &PersistentVolumeClaim{ObjectMeta:{rbd-1318  rbd-1318    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []},Spec:PersistentVolumeClaimSpec{AccessModes:[ReadWriteOnce],Resources:ResourceRequirements{Limits:ResourceList{},Requests:ResourceList{storage: {{1073741824 0} {<nil>} 1Gi BinarySI},},},VolumeName:,Selector:nil,StorageClassName:*csi-rbd-sc,VolumeMode:nil,DataSource:nil,DataSourceRef:nil,},Status:PersistentVolumeClaimStatus{Phase:,AccessModes:[],Capacity:ResourceList{},Conditions:[]PersistentVolumeClaimCondition{},},} to be in Bound state
Sep 30 06:45:48.183: INFO: waiting for PVC rbd-1318 (0 seconds elapsed)
Sep 30 06:45:50.192: INFO: waiting for PVC rbd-1318 (2 seconds elapsed)
Sep 30 06:45:50.199: INFO: Waiting for PV pvc-626fafad-908a-4a53-88de-cce70479d2b1 to bind to PVC rbd-1318
Sep 30 06:45:50.200: INFO: Waiting up to timeout=10m0s for PersistentVolumeClaims [rbd-1318] to have phase Bound
Sep 30 06:45:50.203: INFO: PersistentVolumeClaim rbd-1318 found and phase=Bound (3.129072ms)
Sep 30 06:45:50.203: INFO: Waiting up to 10m0s for PersistentVolume pvc-626fafad-908a-4a53-88de-cce70479d2b1 to have phase Bound
Sep 30 06:45:50.205: INFO: PersistentVolume pvc-626fafad-908a-4a53-88de-cce70479d2b1 found and phase=Bound (2.568213ms)
Sep 30 06:45:50.217: INFO: Waiting up to pod-run-as-non-root to be in Running state
Sep 30 06:55:50.229: FAIL: failed to validate normal user pvc and application binding with error timed out waiting for the condition

This doesn't look like an issue related to this PR
https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/rest/organizations/jenkins/pipelines/mini-e2e-helm_k8s-1.20/runs/2619/nodes/109/log/?start=0

/retest all

small suggestion. LGTM. requesting changes to hold this one till we have the next ceph release

Maybe you mean until the cookie PR is merged in ceph repo!?
DNM is already in place + there is a waiting task on the ceph PR which should keep this on track

@pkalever you also mention we have dependencies with ceph and kernel also. what if ceph has --cookie flag but the kernel does not support it. do you see any problem?

If the kernel doesn't support cookie then rbd-nbd (ceph) will just ignore it even if the user (ceph-csi) passes the --cookie option, hence it's safe and doesn't hurt to pass --cookie even if the kernel doesn't support it

@nixpanic could you also please help review this?
Thanks!

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/mini-e2e/k8s-1.20

X Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.20/detail/mini-e2e_k8s-1.20/2998/pipeline

X Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: Error creating machine: Error in driver during machine creation: IP not available after waiting: machine minikube didn't return IP after 1 minute

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/upgrade-tests-cephfs/detail/upgrade-tests-cephfs/3579/pipeline

/retest ci/centos/upgrade-tests-cephfs

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.21

/retest ci/centos/mini-e2e-helm/k8s-1.22

/retest ci/centos/mini-e2e/k8s-1.21

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20

/retest ci/centos/mini-e2e-helm/k8s-1.20


DOI references not matching RFC 2629 DTD

From @kesara https://github.com/ietf-tools/xml2rfc/pull/804#issuecomment-1175684226
Tests are failing because reference.DOI.10.1145/2975159 doesn't have date element under front element.
This violates rfc2629.dtd.
Originally posted by @kesara in https://github.com/ietf-tools/xml2rfc/issues/804#issuecomment-1175684226

@stefanomunarini can we add tests to validate bibitems (selection of tests across all datasets) against the BibXML schema?

bibxml-service reference: https://bib.ietf.org/public/rfc/bibxml-doi/reference.DOI.10.1145/2975159.xml
current tools.ietf.org reference: http://xml2rfc.tools.ietf.org/public/rfc/bibxml-doi/reference.DOI.10.1145/2975159.xml
New bibxml-service output's title is incomplete.
Also it lacks <seriesInfo name="Communications of the ACM" value="Vol. 59, pp. 88-97"/>.

Incomplete title

Original: "Jupiter rising: a decade of clos topologies and centralized control in Google's datacenter network"
New: "Jupiter rising"

Right, this needs to be fixed (@strogonoff ).

<seriesInfo name="Communications of the ACM" value="Vol. 59, pp. 88-97"/>.

@kesara while this could be useful, this value is explicitly invalid according to RFC 7991:
2.47.3.  "name" Attribute (Mandatory)

   The name of the series.  The currently known values are "RFC",
   "Internet-Draft", and "DOI".  The RFC Series Editor may change this
   list in the future.

Yes, we don’t adapt any dates from Crossref to Relaton format yet. It looks like #215 needs to expand on that ASAP.

<title>: it looks like IETF xml2rfc tools concatenated title and subtitle using a colon. Relaton-py could do that if that’s reliable. Currently, relaton-py’s bibxml serializer doesn’t do any such title adaptation and ends up using the first available title when serializing to BibXML. We can either change BibXML serialization in relaton-py, or change the way we format the main title when parsing Crossref data in bibxml-service.

“Communications of the ACM” is apparently taken from container-title, we could use that when creating a bibliographic item from Crossrefdata.

Can anyone point to preexisting IETF’s xml2rfc tools Crossref API handler (i.e., what code runs under /public/rfc/bibxml-doi/)? https://github.com/ietf-tools/xml2rfc-bibxml doesn’t seem to have it🤔

What you're looking for is in the RFP, in the section for bibxml7.

@strogonoff the bibxml-doi code is here: https://github.com/ietf-tools/xml2rfc-website/tree/56c0be788c4fd22ae475302dcd399439815927f0/public/rfc/bibxml-doi
It uses doilit, which we have already reimplemented:
https://github.com/ietf-tools/xml2rfc-website/blob/56c0be788c4fd22ae475302dcd399439815927f0/public/rfc/bibxml-doi/nph-index.cgi#L189

I'm a little perplexed: our doi2ietf already implements dates but why is not serialised into BibXML?

Yes, we don’t adapt any dates from Crossref to Relaton format yet. It looks like Feat/crossref integration expansion #215 needs to expand on that ASAP.

Yes we need to adopt the dates from the Crossref API and map them to the Relaton model.
Relaton supports these date/time types:

https://github.com/relaton/relaton-models/blob/ec12a0b5f00fd9e5dd19a63e6d0e1658d0165331/grammars/biblio.rnc#L293

Crossref metadata includes the following date/times:

indexed: ignore
created: Relaton created
deposited: Relaton created
issued: Relaton issued
published: Relaton published
published-online: ignore

<title>: it looks like IETF xml2rfc tools concatenated title and subtitle using a colon. Relaton-py could do that if that’s reliable. Currently, relaton-py’s bibxml serializer doesn’t do any such title adaptation and ends up using the first available title when serializing to BibXML. We can either change BibXML serialization in relaton-py, or change the way we format the main title when parsing Crossref data in bibxml-service.

We should concatenate the Crossref title and subtitle at the doi2ietf level.

“Communications of the ACM” is apparently taken from container-title, we could use that when creating a bibliographic item from Crossref data if that’s always how it should be parsed.

As I pointed out in https://github.com/ietf-ribose/bibxml-service/issues/228#issuecomment-1175771552 , we really want explicit permission from @rjsparks that this is correct usage of <seriesInfo>. Thanks.

@ronaldtse

our doi2ietf already implements dates but why is not serialised into BibXML?

We are not using doi2ietf for at least these two reasons:

doi2ietf-py used obsolete, unsupported Crossref API to retrieve data.
doi2ietf-py’s purpose was to transform Crossref API data directly into BibXML, not to Relaton. We don’t need that; we need to transform Crossref to Relaton, and use relaton-py’s bibxml serializer after that.

With that in mind, it was faster to bypass doi2ietf-py and implement this directly in bibxml-service and relaton-py.

Yes we need to adopt the dates from the Crossref API and map them to the Relaton model.

Yes, @stefanomunarini’s PR should take care of all that. I’ll merge it once we confirm that new <seriesInfo name> values are acceptable, because it contains that as well.

@ronaldtse It is expected that seriesinfo will have more than the 3 possible names listed in 7991. We will make sure that gets clarified in 7991bis. A better thing to read at the moment is the seriesInfo entry at https://authors.ietf.org/en/rfcxml-vocabulary

Note that the RPC uses seriesInfo for documents that are part of a series and have a unique value. Examples of document series include RFC, IEEE Std, ITU Recommendation, DOI, 3GPP TR, 3GPP TS, ISO/IEC, and FIPS PUB.
The RPC uses refcontent to capture journal or conference proceedings information: journal or conference title, volumes, pages, conference location, etc. For example,
<refcontent>Communications of the ACM, Vol. 59, pp. 88-97</refcontent>

Thanks @rjsparks @ajeanmahoney .
Valid values for <seriesInfo> "name"
Is the seriesInfo value from a controlled vocabulary or free form text? If the former, it would be great to have the specifications.
https://authors.ietf.org/en/rfcxml-vocabulary seems to describe the "name" attribute as the name of the standardization organization outside of IETF ("other names such as "ISO", "W3C" for exist for other standardisation organisations")

Is "name" supposed to take the "series name" or the "organization name"?
From the illustrative list provided it looks like it is the "series name" (which makes sense given the element name), not the "organization name".
Some question regarding the example list:

I understand the separation of "3GPP TS" and "3GPP TR". Are "ISO/IEC", "ISO/IEC TR" and "ISO/IEC TS" also separated (and there are other deliverable types as well)?
IEEE offers other deliverable types that are not standards, such as "Recommended Practices" and "Guidelines". Should they be considered series?
"ITU Recommendations" are published as "ITU-T Recommendations" and "ITU-R Recommendations". They also have a dozen deliverables types. Are they supported?
NIST and W3C are also supported by bibxml-service.

Proper structuring of a DOI entry in BibXML
The item in question has source metadata provided through this Crossref link:

https://api.crossref.org/v1/works/10.1145/2975159

Notice that "Communications of the ACM" exist in container-title.
As specified by @ajeanmahoney , this information is to be in <refcontent>, not <seriesInfo>, and should look like this:
<refcontent>Communications of the ACM, Vol. 59, pp. 88-97</refcontent>

This formatted reference string can only be built from the raw Crossref metadata, by also including these elements:
"page":"88-97",
"volume":"59"

I would like to confirm with @ajeanmahoney that:

Every BibXML item generated from DOI will be using refcontent, not seriesInfo.
We will programmatically construct the formatted reference string in refcontent using Crossref metadata. This is about citation rendering.

Thanks!

Crossref metadata includes the following date/times:

indexed: ignore
created: Relaton created
deposited: Relaton created
issued: Relaton issued
published: Relaton published
published-online: ignore

@ronaldtse Crossref metadata may include all those different dates/times, however doi2ietf-py implementation only includes issued (see here).
So far I've tried to mimic the behaviour of doi2ietf-py, however here it seems like we're wanting to include more date types. How should I proceed?

seriesInfo name and value attributes take freeform text. The name attribute holds the name of the series. The RPC uses the following seriesInfo names:

3GPP TR
3GPP TS
BCP
DOI
FIPS PUB
IBSN
IEEE Std (note the lack of a period at the end)
ISO/IEC
ISSN
ITU Recommendation
RFC

These are what we have identified so far. We will be discussing this list this week.

Thanks @ajeanmahoney , since there's going to be a discussion if you don't mind let us provide some additional input 😉
Basis:

RFC, BCP are IETF-related series and there is no issue
ISBN, ISSN and DOI are internationally standardized identifiers (ISO standards), no problems with those

Questions:

I believe seriesInfo name should support all series that BibXML service supports today (as part of the ietf-tools suite), including those published by the following organizations:

3GPP
IEEE
NIST
W3C
IANA

Consider whether seriesInfo name (for organizations external to IAB/IETF) represents the name of the SDO, or a document type of the SDO. Developers and users would certainly prefer a consistent application. Amongst values supported today:

document types: 3GPP TS, 3GPP TR, ITU Recommendation, IEEE Std
organization name: ISO/IEC
series name: FIPS PUB (published by the Department of Commerce as executed by NIST)

Thanks!

Tests are failing because reference.DOI.10.1145/2975159 doesn't have date element under front element. This violates rfc2629.dtd.
Originally posted by @kesara in ietf-tools/xml2rfc#804 (comment)

Can I clarify where is <date> required? It’s not in this spec.
@ronaldtse While this particular issue may have been resolved, since we can rely on DOI to provide at least one date, we cannot be so sure with some other sources.
For example, we have recently found that some 3GPP documents are lacking dates, and this may be the case with other sources.

We may be facing the same choice as with missing authors: some authoritative sources simply seem to not provide the data, so we could either violate the spec or we could provide a placeholder date that is not real.
Regardless of that choice, it seems warranted to go through all sources and take note of all items that are missing any  dates. Perhaps in some cases, like with 3GPP, we could make those

There are some cases where a date is never provided in a bib entry (IANA registry entries, for instance).
Sometimes, an author points to a landing page for a spec (a 3GPP or IEEE entry may fall into this category). Those kind of entries don't have dates. I haven't looked to see if the bibxml-service datastore contains landing-page references.

refererences without dates are syntactically legal and appropriate in cases like Jean calls out above. But when the document does have a publication date (as the original DOI the ticket was opened with), the date must be provided, well formed, in the reference.

I think I've pointed this out in other places, but rfc2629.dtd is not v3 rfcxml - it is strict v2, and while we want to be v2 backwards compatible as much as we can be, there are many RFCs in the v2 era that were published with references that didn't contain dates. In short, date cannot be treated as a mandatory element here.


Refactor: DuneInterface.refresh return type

In order for users to cache results, they need access to the JOB ID of their execution. The refresh method now returns more enriched data giving these advanced options to the user.
We lost the convenience of not having to check for an optional field, but introduced a similar convenience in the ResultsResponse (i.e. the new method get_rows which performs the necessary assertion check) and always returns a list of dune records.
Bonus feature is the Query__hash__ implementation which will allow people to cache results of different executions of the same query with different parameters.
Closes #25  and closes #27

This is an interface breaking change so we will have to bump the version to 0.1.0


PKGBUILDs not shown when chaotic-aur repo is enabled

Steps to reproduce

Enable chaotic-aur repo
Search with pacseek for an AUR package which is also available in the choatic-aur
Try to view PKGBUILD of AUR package (shows 404: Not Found error)

This does not happen for AUR packages which are not in the chaotic-aur.

(This may be relevant: A similar problem exists with yay when the chaotic-aur is enabled.
Running yay -Gp informant will not show the PKGBUILD and shows an error.
This could be fixed by running either yay -Gpa informant or yay -Gp aur/informant)

Hello @Mudskipper875
The new 1.6.6 version should fix this issue.
Please give it a try...

It works now, Thanks!


sidebars: Replace chevron with ellipsis-v icon from the sidebars.

Fixes #7115

@timabbott can you review this

I think this is okay. Maybe it's just me, but I feel like the three dots are a little too large. (the click area is about right though).
We should probably change names like .all-messages-arrow i, .stream-sidebar-arrow since I think the arrow is referring to the chevron.
Also, It's worth keeping in mind that #14086 also made this shift for the message box and this PR does not. (you don't need to change it immediately, it's just something to be aware off).

We should probably change names like .all-messages-arrow i, .stream-sidebar-arrow since I think the arrow is referring to the chevron.

Yeah, I should change those name since those are not arrow any more.

Also, It's worth keeping in mind that #14086 also made this shift for the message box and this PR does not. (you don't need to change it immediately, it's just something to be aware off).

Oh, I missed that, Thanks for pointing this out @YashRE42

What are your thoughts on whether we should change it for the message box?  I guess I'm tempted to not do that for now, since it's a different type of component, and less complexity is probably better.

I think we could use something similar to verticle-ellipses in place of arrow.

What are your thoughts on whether we should change it for the message box? I guess I'm tempted to not do that for now, since it's a different type of component, and less complexity is probably better.

yeah we can leave that for the message box

If we're renaming the "arrow", what do you think it should be? Something that indicates "menu launcher"; but I feel weird calling it "menu" since that would be the popover itself.

how about using vertical-dot-menu? @timabbott

So, I have a couple requests:

Can you swap the order of commits, so I can merge the "sidebar-menu-icon` commit to master now and simplify this branch?
I feel like the click targets for the ellipses are too small, because of their lesser horizontal width, and as a result it's annoying to try to click them.  Can you adjust things to address that?

This is great; I merged the first commit.  I think we can also do a high-value new first commit that adds a sidebar-menu-icon class to all of these elements, and uses that for the common CSS to simplify things (We have the list of the 5 widgets with a sidebar-menu-icon in 5+ places).

I'm test-deploying the new version of the last commit to chat.zulip.org.

I think we can also do a high-value new first commit that adds a sidebar-menu-icon class to all of these elements, and uses that for the common CSS to simplify things (We have the list of the 5 widgets with a sidebar-menu-icon in 5+ places).

This seems a great idea will do that in a follow-up

This is causing Firefox Nightly to reject the zulip-icons font and display placeholder glyphs on chat.zulip.org. I see the following errors in the console.
downloadable font: GSUB: Failed to parse lookup list table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:1) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff
downloadable font: GSUB: Failed to parse table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:1) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff
downloadable font: rejected by sanitizer (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:1) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff
downloadable font: GSUB: Bad component count of 16 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: GSUB: Failed to parse ligature 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: GSUB: Failed to parse ligature set 1 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: Layout: Failed to parse lookup subtable 3 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: Layout: Failed to parse subtable 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: Layout: Failed to parse lookup 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: GSUB: Failed to parse lookup list table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: GSUB: Failed to parse table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: rejected by sanitizer (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:2) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.woff2
downloadable font: GSUB: Bad component count of 16 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: GSUB: Failed to parse ligature 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: GSUB: Failed to parse ligature set 1 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: Layout: Failed to parse lookup subtable 3 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: Layout: Failed to parse subtable 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: Layout: Failed to parse lookup 0 (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: GSUB: Failed to parse lookup list table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: GSUB: Failed to parse table (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: rejected by sanitizer (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:3) source: https://chat.zulip.org/static/webpack-bundles/files/zulip-icons.e63bae59973eaf312c9a.ttf
downloadable font: no supported format found (font-family: "zulip-icons" style:normal weight:400 stretch:100 src index:5) source: (end of source list)

I diagnosed the Firefox sanitizer problem and filed a Firefox bug and a webfonts-loader bug.

@SiddharthVarshney OK, I did a careful look through this, and I have a few requests:

Can you split the changes to make that ellipses icon usable into its own prep commit?  I'd like to merge that to master now since that piece looks great.
The right sidebar focus behavior is wrong; if you hover over the click area for the ellipses, it doesn't darken the ellipses like it does in the left sidebar.
The vertical and horizontal alignment in the left sidebar feels a bit off; for vertical alignment, it feels like top: 1px makes it look centered within the grey highlighted reason, which is I think what we want.

@timabbott by the first bullet did you mean to extract THIRTPARTY and ellipsis-v-solid.svg  file changes in a separate commit?

The right sidebar focus behavior is wrong; if you hover over the click area for the ellipses, it doesn't darken the ellipses like it does in the left sidebar.

I guess I should make this thing correct first in a separate commit because its also a problem in our current chevron hover behaviour also

Can you rebase this?  And then I'll try putting it on chat.zulip.org.

@timabbott I have done the rebase

Merged, thanks @SiddharthVarshney!  I think we can fix-forward from here.
Can you do a PR updating the documentation in templates/zerver/help/, and other references here that are clearly to the sidebars?
$ git grep chevron
Some are for the message actions menu, so aren't ready to be updated; we should at least fix the docs for the ones referencing the sidebar.  (You could also start on a separate PR to try out changing the message actions menu; that one will require care with the click area but is otherwise likely simpler).

Sure, I will make those changes


FE: Filters: Display CEL help when editing filter

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #622

Removed the check which was not rendering CEL help icon on edit filter. So the help icon is now visible for both add filter and edit filter.
Added unit test for same icon to be visible and enabled in  both add and edit cases.

Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[x] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@Haarolean
Can you guide me on why the smoke tests check is failing ? and what steps should I take to fix it.

@pisal-shubham thanks for your first contribution to kafbat UI!


Add --open param

Automatically tries to open tunnel URL in the browser if the --open params is set.

Issues with this PR:

Won't work on windows or linux cause
You are bumping the package version.. not your call to make what the new version is :)
not following any of the existing project style for the new code.

This feature would be desired but this PR is not ready.

Hey @defunctzombie just changed the code to also work on linux & windows. Sorry for that.
One question, what do you mean by:

not following any of the existing project style for the new code.

How could I improve the code to follow the module style ?

Take a look at the code style of other files (spacing, indentation, etc).

Commits squashed

:+1:


New version: ImageMagick.ImageMagick.Q8 version <IP_ADDRESS>

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Program Files\ImageMagick-7.1.1-Q8\magick.exe returned exit code: 1

(Automated response - build 881.)


Added file completion support for update command

fixes #1012
To test : Try file name completion for update --local and --binary

:white_check_mark: odo build 430 completed and artifacts can be found here (for commit https://github.com/redhat-developer/odo/commit/5a1aa099c6 by @mik-dass)


ImportError

I read a really good paper.
After following 5.example of README, importerror occurred and asked what to do.

ImportError: No module named models.carlini_models

I guess you could re-download the code and check if  there is the carlini_models.py file in the models folder. Besides, which python version are you using? Thank you.

Thanks, I didn't check my python version when i make my virtual env.


undefined is acting like any in generics extension checks

Bug Report

🔎 Search Terms
generic function call
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about generics

⏯ Playground Link

playground link
💻 Code

type IfAny<T> = 0 extends (1 & T) ? true : never

declare function bool<T extends IfAny<T>>(value?: T): 'caught';
declare function bool<T>(value?: T): 'not caught';

declare function bool2<T extends {['gibberish']: T}>(value?: T): 'caught';
declare function bool2<T>(value?: T): 'not caught';

const A = bool(undefined);  // caught ???
const B = bool2(undefined); // caught ???
const C = bool();           // caught ???
const D = bool2();          // caught ???

🙁 Actual behavior
both implicit and explicit undefined arguments seems to act like any when used in a generic when the argument is optional.  This behavior is not seen when the argument is required
🙂 Expected behavior
undefined shouldn't extend everything

Your function is typed T | undefined because it's an optional parameter. So when you call it passing undefined or without an argument, there's nothing to infer T from, so T resolves to never, and never extends every type.

never extends every type.

This seems incredibly!  What's the logic here?

never is the bottom type which is the opposite of the top type unknown.  It conceptually represents the result of operations that never complete (a function that throws, e.g.), so you can treat it as any type you want.  In set-theoretical terms, never is an empty set (because there are no values of that type)--which is a subset of every other set.


Back to mu-javascript-template

Because we would like to be able to debug this service live, we change it back to be based onto the mu-javascript-template, because the mu-javascript-template has live debugging baked in. There is also live reloading when developing now. The mu-javascript-template and the Node Docker image used before share the same Node version, so the switch was almost trivial.
Because this service was once switched to a basic Node image, the mu-helper package was copied to maintain that functionality. Some subtle changes where introduced to that code and it is no longer trivial to get rid of these copies. They where left in. (See the git commit history for a failed attempt at removing them.) Leaving them in has a benefit: we can reuse the tests (not in a Docker container).

@mirdono Thanks for noticing. I haven't used/run any tests yet, since I'm not introduced to them yet. Made a PR to use the correct image here: https://github.com/lblod/app-lpdc-digitaal-loket/pull/31


Use oceanicNext dark theme for website

What type of PR is this:
/kind documentation
/area documentation

What does this PR do / why we need it:
Which issue(s) this PR fixes:

Fixes #6002
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:
Change to dark mode on the website.

/override OpenShift Integration tests/OpenShift Integration tests
Docs PR.

Looks really great when comparing the YAML codeblocks between main and this PR. Just wondering if a variant of monokai or jellybeans themes is available. Especially monokai is very popular for good reasons, IMO. But just a personal preference.
Thanks for addressing this.
/approve

Just wondering if a variant of monokai or jellybeans themes is available. Especially monokai is very popular for good reasons, IMO. But just a personal preference.

I just saw all the other available themes. I am glad something as good as oceanicNext is there. Phew.


Overflow error when showing SelectableMenuItem

selectable: ^0.2.4
the selectable menu item does not show it keeps throwing overflow error

The way I use Selectable doesn't exhibit this problem, but I'm using it for a large amount of rich text interspersed with other widgets, so there's always room for the menu.
For the menu I should be using an Overlay for the menu, that way it will work for even a small amount of text. I'll work on these changes when I have time -- it may take a few weeks, as I'm pretty busy right now.

Hi, did you make any changes to fix this issue? I have also same problem with small texts.


Blocking abusive clients

Originally filed at https://github.com/spanicker/ip-blindness/issues/14 by @spanicker

At some point, a service may have confidence that a given request is associated with an abusive client. Perhaps the request is willfully causing quality of service issues, demonstrates intent to harm another user, or otherwise violates a site’s terms of use.
Historically, services would ban a user by their IP address. This has become less common with the rise of the mobile internet, but IP is still a surprisingly common tool in scaled abuse scenarios.
We would like to provide websites with the ability to request that the proxy no longer send traffic from the user of the proxy that issued the given request. We need to do this without re-introducing the cross-site tracking risk that the proxy is designed to counter.
Are there existing protocols or limitations relevant to your service that we should be mindful of? Would it be acceptable if embedded services would have to ban a user once for each top-level context (e.g. a.com on example1.com and a.com on example2.com would need to ban the user separately

Hello Mike,
Within my role in cyber security, a significant aspect involves the examination, authorization, and limitation of access to our corporate software by way of IP Addresses. Despite employing various other techniques to limit access, we've observed that this remains one of the most effective approaches to prevent extensive misuse.
After thorough internal deliberation regarding the IP Protection proposal, we have notable apprehensions about the potential consequences of eliminating IP addresses. This change could render us vulnerable to misuse, which is a concern we share across our legal department due to its implications for compliance.
Could you kindly provide insights into how the proposal aims to address these challenges?
Appreciate your assistance.

I would like to also chime in on this one, and ask how legitimate websites will see protection proxy users.  Will we see just all zeros or blank IP addresses?  Or will we see a leased fake IP?  If a fake IP, how many times per year, month, week, day, or hour can they change to a new fake IP?  I ask because I'd like to know whether website designers would be able to at least temporarily block abusers (until they change their fake IP again).  TIA for a reply.

When traffic flows through the IP Protection proxies, websites will see the IP address of the second proxy. Multiple users can share the same proxy IP address at a time. When a user loads multiple web pages, those loads can use different IPs. This is required to prevent tracking of users. Because of this, proxy IP addresses cannot be relied upon as stable identifiers for any purpose.

Hi David,
As a result of this feature, application layer attacks can be more difficult to detect and mitigate, ranging from Distributed L7 DDoS to various business logic abuse/fraud attacks performed by malicious bots. How is Google going to prevent such attackers and fraudsters from abusing this feature? These risks cannot be solved by authenticated browsers. In today's market, there are many security risk-based solutions that use various ways to positively correlate the user, session, browser, and source IP to ensure that the user is indeed who he claims to be.

When traffic flows through the IP Protection proxies, websites will see the IP address of the second proxy. Multiple users can share the same proxy IP address at a time.
this way if a web application firewall will block a malicious user, it will block many innocent users as well; whitelisting Google network is  obviously not an option.

I would rather block a few legitimate users than allow some hacker unlimited freedom to test out their various exploits.


istioctl get is case sensitive

gateway works but Gateway does not work.
root@gyliu-icp-9:~# istioctl get gateway
NAME		KIND					NAMESPACE
bookinfo-gatewayGateway.networking.istio.io.v1alpha3	default

root@gyliu-icp-9:~# istioctl get Gateway
Usage:
  istioctl get <type> [<name>] [flags]

Examples:
# List all virtual services
istioctl get virtualservices

# List all destination rules
istioctl get destinationrules

# Get a specific virtual service named bookinfo
istioctl get virtualservice bookinfo

Flags:
  -h, --help            help for get
  -o, --output string   Output format. One of:yaml|short (default "short")

Global Flags:
  -i, --istioNamespace string         Istio system namespace (default "istio-system")
  -c, --kubeconfig string             Kubernetes configuration file (default "$KUBECONFIG else $HOME/.kube/config")
      --log_as_json                   Whether to format output as JSON or in plain console-friendly format
      --log_caller string             Comma-separated list of scopes for which to include called information, scopes can be any of [default]
      --log_output_level string       The minimum logging level of messages to output,  can be one of [debug, info, warn, error, none] (default "default:info")
      --log_rotate string             The path for the optional rotating log file
      --log_rotate_max_age int        The maximum age in days of a log file beyond which the file is rotated (0 indicates no limit) (default 30)
      --log_rotate_max_backups int    The maximum number of log file backups to keep before older files are deleted (0 indicates no limit) (default 1000)
      --log_rotate_max_size int       The maximum size in megabytes of a log file beyond which the file is rotated (default 104857600)
      --log_stacktrace_level string   The minimum logging level at which stack traces are captured, can be one of [debug, info, warn, error, none] (default "default:none")
      --log_target stringArray        The set of paths where to output the log. This can be any path as well as the special values stdout and stderr (default [stdout])
  -n, --namespace string              Config namespace
  -p, --platform string               Istio host platform (default "kube")

Error: configuration type Gateway not found, the types are routerule, egressrule, destinationpolicy, httpapispec, httpapispecbinding, quotaspec, quotaspecbinding, servicerole, servicerolebinding, virtualservice, gateway, serviceentry, destinationrule, policy

Same for other resources, such as virtualservices etc.

kubectl works fine without considering case.
root@gyliu-icp-9:~# kubectl get virtualservice
NAME       AGE
bookinfo   9m

root@gyliu-icp-9:~# kubectl get VirtualService
NAME       AGE
bookinfo   9m
root@gyliu-icp-9:~#


Friend favourite page

Users can see their friend's favorite movie list by clicking the "View More" button. This action redirects them to the friend's favourite movie page. The title confirms that they are viewing a friend's list. Users do not have permission to remove any movies from this list, and the recommendation feature is also disabled.
Snippet (when user view friend favourite list):

Snippet (Users themselves favourites list):

Contribute #80

Thank you, Alex, I remove the closing tag!


Address Space Detail - Console UI

Description

Displays the header with Address Space detail and a navigation bar for addresses and connections
Design
https://marvelapp.com/4hgeg9j/screen/62669875
Tasklist

[ ] Address Space Detail Header -Visual ,Stories,Data, Test
[ ] Navigation Bar for Addresses/Connections - Visual ,Stories, Test-Visual Components

Fixed in Console 1.4


Add category path to pinned tile in grid view

Reading the code, I think it will show the category path for the current page, not the items that are pinned.

Yes, fixed that already, locally. It should have been a draft pull request.  I am exploring the code base a bit first

Ok perfect!

Closed as this should have been a draft and does not include the proper fix. (New PR welcome :) )


Make topics pub in Log so we can implement Compact codec in reth_codec

Ref https://github.com/paradigmxyz/reth/pull/7474
@mattsse

The field is private intentionally, use the getter methods instead.


µtvm debug improvements

A couple of patches to improve the debugging experience for µTVM:

Make UTVMDone noreturn, so that the device doesn't jump to arbitrary code locations after stopping the debugger. This was causing it to often execute from peripheral memory and HardFault.

Make debug mode extendable using a PackedFunc. This allows scripts to accept a --debug parameter and allows them to be selective about which runs to debug.

@tqchen @tmoreau89 @liangfu @weberlo @u99127 @tom-gall

LGTM


[SPARK-9659][SQL] Rename inSet to isin to match Pandas function.

Inspiration drawn from this blog post: https://lab.getbase.com/pandarize-spark-dataframes/

cc @davies for review.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1373 has started for   PR 7977 at commit 4f4a35d.

Test build #1373 has finished for   PR 7977 at commit 4f4a35d.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class In(value: Expression, list: Seq[Expression]) extends Predicate
case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression with Predicate

Merged build triggered.

Merged build started.

Test build #39971 has started for   PR 7977 at commit 7c1b6cf.

Test build #39971 has finished for   PR 7977 at commit 7c1b6cf.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39989 has started for   PR 7977 at commit 2197d37.

Test build #39989 has finished for   PR 7977 at commit 2197d37.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #40001 has started for   PR 7977 at commit 9b1d3d6.

Test build #40001 has finished for   PR 7977 at commit 9b1d3d6.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.


Update "Testing" post

better connecting "solution" with "problem"

e.g., point to "problem" from "solution", provide more "solutions"

drill down into a specific "failure" case resonate more with audience
give more specific suggestions for (early-stage) startups

Done


aded styling for images, links, heading and commenting buttons to art…

…icle page
@peterp ready for review

:+1:


Update yahoogroupsapi.py

Solves:
https://github.com/IgnoredAmbience/yahoo-group-archiver/issues/38

I think this is now solved in master.


Update width in config

Changed width to 400px due to crawler being mobile.
Before:
Desktop:

Mobile:

After:
Desktop:

Mobile:

Hey @AVGP, could you please delete this PR from history? Was supposed to be merged to a forked repo :) Thanks in advance!


In Ios ,picker is opening the keybord

After picking or taking an image through the picker it makes the keyboard visible for the first time?

This isn't necessarily a fix, but I use react-navigation and I had a screen with a TextInput that came before my screen with the image picker. If I add a Keyboard.dismiss() when I submit the text, this prevented it from coming back.

I'm not convinced this is related to the image picker.  Most likely that a text input (or something similar) is taking focus once the picker closes.
I don't see this behaviour in the iOS example app of 3.x.x.  Compare your code to the example app and if the issue perists, share reproducible code here.  Thanks.

I hope the issue is solved, if not reply here or create new issue with details I am happy to fix it.

The same problem. I think Keyboard.dismiss() is not a good fix.

The same problem. I think Keyboard.dismiss() is not a good fix.

We have the same issue in our project. We do not have any input, we are just uploading an identity document.
When document is uploading, we render a <Loader /> component , on top of it, we have eraticaly the keyboard showing up:

Could this be reopened?


fix: daily email routine crashes app

resolves #119

OK. It's working now. I updated one of the tradingAccepted entities and got the email.


usdCycles schema support

To properly support cycles rendering from a USD document, we must implement a custom USD schema to bridge the gap.
The result of this will be a separate open sourced repository which defines the custom schema for usdCycles.
It will be possible to build hdCycles without the schema, but 1:1 rendering support will not be possible.
More information to come.

The main integration of this has been pushed into main as of 18/12/2020. The opensourcing of the usdCycles schema and houdini_cycles pacakges will come early in the new year. Until then, the default building of HdCycles will not build with usdCycles schema support...


use T to allow kriging on data that is not Float64

I was trying to perform kriging on Float32 input data, but ran into MethodErrors because here the type is set to Float64, and because of this it will not be able to enter here since not all T are the same type.
I know about the dangers of reduced floating point precision, but the rest of the code seems to be set up in a way that should allow this.
Here is a Gist that shows it generates approximately the same results. I could add this separately as a test.

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   96.82%   96.82%
=======================================
  Files           6        6
  Lines         126      126
=======================================
  Hits          122      122
  Misses          4        4

Impacted Files
Coverage Δ

src/ordinary_kriging.jl
100% <100%> (ø)
:arrow_up:

src/simple_kriging.jl
100% <100%> (ø)
:arrow_up:

src/universal_kriging.jl
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04311df...fd42e67. Read the comment docs.

Thank you @visr for catching this, I am merging it right away. Please let me know if you run into trouble with any other part of the code because of single precision.


V1.1 seems to be less reliable than v1.0 (SCPH-101 4.5 BIOS)

I was testing with the newest version on my 4.5 SCPH-101, but lt seems to be less reliable (at least on this specific revision) than 1.0.
I've only tested with backups of SOTN and Klonoa so far, but I still managed to find some odd behaviour on 1.1.
First, SOTN loads fine but it gets stuck when reading my MC. Obviously, I tested without the exploited MC plugged on while the game was running. I also tried formatting my mc, but that didn't work either. 1.0 works fine and reads the mc without issue. though.
Secondly, is Klonoa. The game gets stuck at the Namco logo on 1.1, but it works fine on 1.0 works just fine and also reads the mc without issue.
One last thing to note is that the payload loads faster on 1.1 vs 1.0 fastload. This also happens when pressing R1 to launch the games.
My apologies if the info I presented wasn't clear. I'm not used to opening issues, so my descriptions might sound weird.
Let me know if you need some clarification.

SOTN of the night works just fine for me with 20210421 on the 4.5 BIOS. No problems reading a non exploited memory after booting the game.

After Unirom is loaded, the memory card may be removed (no need to wait for the game to start - this could make things less reliable). FreePSXBoot stops running as soon as Unirom starts running. It doesn't matter which version was used to load Unirom at that point.


Add: TeekshaHarish

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

Hi @TeekshaHarish , thanks for your interest in contributing to DevDisplay!
We noticed you adding your profile on #DevDisplay but forgot to star the repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟
💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌
Thanks 👍🏻


MSID: 92919 Version: 1 DOI: 2<IP_ADDRESS>1977

"msas": "Physics of Living Systems"
"msid": "92919"
"preprintDoi": "10.1101/2<IP_ADDRESS>1977"
"Reviewed Preprint posted": "2023-12-28"
"Sent for peer review": "2023-10-16"
"Posted to bioRxiv": "2023-10-17" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1977v2/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92919)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/92919/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1977)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/92919/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/92919)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/92919

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/92919

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/92919/v1/92919-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/92919)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references


PDFViewerApplication annotations misplaced

Link to PDF file (or attach file here): http://<IP_ADDRESS>/test/web/compressed.tracemonkey-pldi-09.pdf
Configuration:
Web browser and its version: Android 5.01 webview
Operating system and its version: Samsung Galaxy Tab with Android 5.0.1
PDF.js version: 1.3.91
In order to use less memory possibile I'm loading the file in chunks and here is the configuration code:
PDFJS.disableWorker = true;
PDFJS.maxCanvasPixels = 393216;

I'm using pdfviewer in my application; the viewer works fine and is loaded ad documented here https://github.com/mozilla/pdf.js/issues/7127
The pdf have many data annotation; very often in the scenario presented in configuration the annotations are misplaced.
Often (not always) I see the issue in this way:

scroll to page 12
scroll a lot of pages and go to page 90
using the page selector, go to page 12

Now I see the data annotation misplaced like:

but it must be:

How can I fix the issue? I'm trying a lot, but I'm unable to reproduce this issue in a desktop browser...
Kind regards,
Irvin Dominin

Hi @timvandermeij do you have any idea on this? What can I check?

Try using the most recent PDF.js version (https://github.com/mozilla/pdf.js/releases). I recall there was an issue about flipped annotations before that has been fixed. The link to the PDF file above is dead, so please update it as well (or better, upload to GitHub).

Hi @timvandermeij thanks; I try with the latest version, I update you and eventually close this issue ASAP. Here is the file Catalogo_XS_1.pdf

I recall there was an issue about flipped annotations before that has been fixed.

Are you perhaps thinking of PR #6814, by any chance? If so, I'm unfortunately not sure if that will help here, since the annotations that this issue is about appear to just be standard LinkAnnotations with a border.

The pdf have many data annotation; very often in the scenario presented in configuration the annotations are misplaced.

The "very often" part seems to suggest that this is an intermittent issue, thus making any sort of debugging quite hard.

Web browser and its version: Android 5.01 webview
Operating system and its version: Samsung Galaxy Tab with Android 5.0.1
[...]
I'm trying a lot, but I'm unable to reproduce this issue in a desktop browser...

This further suggests that the issue might be platform and/or even browser specific, thus making debugging even harder.
So, to summarize: Based on all of the information provided, it seems very likely that this is a browser (or platform) specific bug, and thus unfortunately most likely not something that can be fixed on the PDF.js side.

Closing, since based on https://github.com/mozilla/pdf.js/issues/7434#issuecomment-266419093 there doesn't appear to be much that can really be done about this in PDF.js unfortunately.


Add cskd loaders for aircrafts and dog datasets

Hi Ahmed,
I've added a cs-kd supported version of the aircrafts and the dog120 dataset. Can you give it a try to see if it works for you? You will need to change some of the hard coded values as well as enable cs-kd.
When I run this on my side, I'm seeing a consistent 2-4% decrease in performance for the dog dataset for both smoothing and cs-kd, and a 2-4% increase for smoothing in the aircrafts dataset. This may be due to just variance. But for cs-kd on aircrafts, I'm seeing a 6% increase in performance. I wanted to check if there is something different with the cs-kd loader you used to cause this performance discrepancy, and if there's some data processing you may have done specifically for the dog dataset (everything is resized to 256x256 currently).
Thanks!
Hattie

Hi Hattie,
I checked-out your commit, but I can't run it because it leverage datasets.ImageFolder. My datasets doesn't have train, val, test directories. Accordingly, I can't run/evaluate your code. It is convenient to use ImageFolder but this is not a good choice on the long-run. For instance, if you want to train or eval on a subset of your dataset, you have to create a new directory and copy subset of images to this new directory. In contrast, if you use csv files, you only create a new csv file with a subset of image names -- no need to copy images.
Regarding the performance degradation, I am not sure what is wrong. I see you are using CS_KD authors implementation[1].
The images inside my dogs directory are Not normalized to 256x256. Sorry for such inconsistency. As mentioned previously, I don't remember resizing all datasets.
For stanford_dogs, If the original images didn't fix the cs_kd issue, I want you to try something crazy! Assuming, batch-size=4, the current PairBatchSampler returns a batch with labels as follows: [c_1, c_2,c_3,c_4, c_1, c_2,c_3,c_4]. Can you please change that to [c_1,c_1,c_2,c_2,c_3,c_3,c_4,c_4]. Basically, change yield batch_indices + pair_indices to yield list(itertools.chain(*zip(batch_indices,pair_indices ))). Keep the trainers.default_cls as it is. I know that doesn't make a lot of sense, but I hope you try it and let me know if it makes any difference in performance.
Thanks
[1] https://github.com/alinlab/cs-kd


ZVM: Need vswitch name when creating Subnet

Add a new filed "vswitch" when creating Subnet which records the vswitch name for z/VM. Save it to database.

Fixed. Close.

Fixed. Close.


chore: fix a broken link in README

https://github.com/contra/graphql-helix/blob/master/packages/core/examples is not the right link for the examples.

@chentsulin thanks 😊 🙏


how to show menu at the bottom of the button?

Describe the question
I want the menu open and show blew the button?
Blazorfiddle link
Please provide a mock implementation of your code on www.blazorfiddle.com, if possible. This makes it a lot easier for us and you can get faster feedback on your question. 😉
Hit save and post the URL under this header.
<MatIconButton Icon="expand_more" OnClick="@OnMenuClick" RefBack="@buttonForwardRef"></MatIconButton>
                <MatMenu @ref="menu" TargetForwardRef="@buttonForwardRef">
                    <MatButton OnClick="@OnLogoutButtonClick">Logout</MatButton>
                </MatMenu>

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots or .GIF captures to help explain your question.
current position:

Additional context
Add any other context about the question here.

This is default Material Design Components (MDC) behaviour, but you can add your own styles and overrides to the mix.
While not the prettiest solution, you could just translate it a few pixels down.
For example like this: https://blazorfiddle.com/s/s148zdx5
The changed parts are some CSS.
.example-menu-offset-down{
    transform:translateY(32px);
}

And an added class to the menu element.
<MatMenu @ref="Menu"  TargetForwardRef="@buttonForwardRef" class="example-menu-offset-down">...</MatMenu>

ok, thank you


refactor(autoware_lidar_transfusion): split config

Description
This PR split autoware_lidar_transfusion parameter file for two configs:

Parameters strictly related to deployed model.
Parameters related to runtime behavior.

The same approach is applied in autoware_lidar_centerpoint package.
Related links
Parent Issue:

https://github.com/autowarefoundation/autoware_launch/pull/1093
https://github.com/autowarefoundation/autoware/pull/5036

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@kminoda @knzo25
json-schema-check fails due to same file name prefix here.
Unfortunately, we can't remove asterisk from {base_name}*.param.yaml in CI because this convention is widely used among Autoware packages to apply schema file on multiple param files. We can:

Change file name convention from <MODEL>_ml_package.param.yaml to ml_package_<MODEL>.param.yaml.  We will need to change deployment path and launch files for transfusion, centerpoint and pointpainting.
Bypass this test by file extension thus don't check this config in CI as it is now in centerpoint.

I would go for change naming convention if I didn't miss any drawback. If you have no objection, I will apply this for centerpoint and pointpainting as well.

@amadeuszsz Thanks for the proposal :pray:
However, I don't think it is a good idea to rename the parameter file name, as they are already widely used both in Autoware and Pilot.Auto / Web.Auto, and changing those file names would take a bit of time.
So I would say it's better to consider a workaround.

@amadeuszsz
In centerpoint we face similar concerns, and as a workaround (https://github.com/autowarefoundation/autoware.universe/pull/7421) we are considering calling the vanilla model centerpoint_base, which sounds awful, but is compatible with the schema.
I agree with your name change, but also understand that the change would affect several places, so it would time...

@amadeuszsz In centerpoint we face similar concerns, and as a workaround (#7421) we are considering calling the vanilla model centerpoint_base, which sounds awful, but is compatible with the schema. I agree with your name change, but also understand that the change would affect several places, so it would time...

I'm not a big fan of this. It will require few copies of same schema files and still affects many places due to file renaming, as you said.
We could restructure design for both packages to:
|-config
|----|-ml_package.param.yaml
|----|-ml_package_tiny.param.yaml
|----|-ml_package_sigma.param.yaml
|----|-centerpoint.param.yaml
|----|-centerpoint_tiny.param.yaml
|----|-centerpoint_sigma.param.yaml
|----|-detection_class_remapper.param.yaml
|
|-schema
|----|-ml_package.schema.json
|----|-centerpoint.schema.json
|----|-detection_class_remapper.schema.json

At the same time we can keep old configs on cloud server to let people pull files if they didn't update repository.

Update: we decided to skip the problematic schemas in the meantime, so this PR can be merged


[1.19.2] Guard relocating

Hi
I live across a lake from a village. This means that even if I am not at the village, it's still in my loaded chunks range. Early on, despite the guards, the village was overrun and everyone died.
I've spent a week or two building defenses around it and slowly repopulating it. I went to the next nearest village in hopes of kidnapping their guards via boat and relocating them to mine. But despite being a good couple hundred blocks away, after getting out of the boat, the guards are beginning the trek all the way back to their homes.
Could there ever be added functionality for changing the "home village" of the guards?

Closed because I was wrong, I just had a homesick guard, the rest have stayed


feat(components): add carousel dot buttons

Add dot buttons to carousel component based on the availablity of dot buttons in embla carousel vue.

IMO this is too much and also not working well with Orientation

Thank for your suggestions! I will fix it so that it can look good with orientation

I have fixed the code to make it work with orientation. Please let me know what you think!


docs(wiki): ci overview

This documentation will eventually land in the wiki, once approved here. It aims to provide an overview of our CI pipeline.
I'll close this PR and move the contents into the wiki once approved here.

@Eakam1007 do you want to put the E2E docs in here as well? I think it makes sense as part of the "CI pipeline overview".

Yeah, I think it is fine to put them here as those are part of CI as well

If people are happy with this, I'll add this to the wiki for now. We can add the E2E stuff later on.

@shawnyu5, could you squash and merge this PR?

These docs has been added to the wiki
https://github.com/DevelopingSpace/starchart/wiki/CI-pipeline-overview


Rule 941310: false positive for Russian letters "м" and "о"

Description
I just enter a word from all the letters of the Russian alphabet and get a false positive.

абвгдеёжзийклмнопрстуфхцчшщъыэюя – false positive
абвгдеёжзийклнопрстуфхцчшщъыэюя – true negative
абвгдеёжзийклмнпрстуфхцчшщъыэюя – true negative

I decided to check the whole alphabet after I started noticing problems with some Russian sentences. As it turned out, the problem is in specific letters
¼ = bc
¾ = be

м = d0 bc
о = d0 be

Audit Logs / Triggered Rule Numbers
"response":{"body":"\r\n<title>403 Forbidden</title>\r\n\r\n
403 Forbidden
\r\n
nginx\r\n\r\n\r\n","http_code":403,"headers":{"Server":"","Server":"","Date":"Fri, 04 Dec 2020 08:50:05 GMT","Content-Length":"146","Content-Type":"text/html","Access-Control-Allow-Origin":"*","Connection":"close","Access-Control-Allow-Credentials":"true","Strict-Transport-Security":"max-age=15724800; includeSubDomains"}},"producer":{"modsecurity":"ModSecurity v3.0.4 (Linux)","connector":"ModSecurity-nginx v1.0.1","secrules_engine":"Enabled","components":["OWASP_CRS/3.3.0\""]},"messages":[{"message":"US-ASCII Malformed Encoding XSS Filter - Attack Detected","details":{"match":"Matched \"Operator `Rx' with parameter `\\xbc[^\\xbe>]*[\\xbe>]|<[^\\xbe]*\\xbe' against variable `ARGS:json.description' (Value: `\\xd0\\xb0\\xd0\\xb1\\xd0\\xb2\\xd0\\xb3\\xd0\\xb4\\xd0\\xb5\\xd1\\x91\\xd0\\xb6\\xd0\\xb7\\xd0\\xb8\\xd0\\xb9\\xd0\\xba\\xd0 (156 characters omitted)' )","reference":"o27,5v17,64t:urlDecodeUni,t:lowercase,t:urlDecode,t:htmlEntityDecode,t:jsDecode","ruleId":"941310","file":"/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf","lineNumber":"527","data":"Matched Data: но found within ARGS:json.description: абвгдеёжзийклмнопрстуфхцчшщъыэюя","severity":"2","ver":"OWASP_CRS/3.3.0","rev":"","tags":["application-multi","language-multi","platform-tomcat","attack-xss","paranoia-level/1","OWASP_CRS","capec/1000/152/242"],"maturity":"0","accuracy":"0"}},{"message":"Inbound Anomaly Score Exceeded (Total Score: 5)","details":{"match":"Matched \"Operator `Ge' with parameter `5' against variable `TX:ANOMALY_SCORE' (Value: `5' )","reference":"","ruleId":"949110","file":"/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf","lineNumber":"80","data":"","severity":"2","ver":"OWASP_CRS/3.3.0","rev":"","tags":["application-multi","language-multi","platform-multi","attack-generic"],"maturity":"0","accuracy":"0"}}]}

Your Environment

CRS version (e.g., v3.2.0): v3.3.0
Paranoia level setting: 1
ModSecurity version (e.g., 2.9.3): v3.0.4
Image: k8s.gcr.io/ingress-nginx/controller:v0.41.2

Confirmation
[X] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

Also https://github.com/coreruleset/coreruleset/issues/1645

As already stated in the linked #1645 the same problem exists for german Umlaute:
Ü and ä for example: Über den Wolken gehört...
[2021-02-16 15:33:52.762256] [-:error] <IP_ADDRESS>:36123 XXXXXXXXXXXXXXXXXX [client <IP_ADDRESS>] ModSecurity: Warning. Pattern match "\\\\xbc[^\\\\xbe>]*[\\\\xbe>]\|<[^\\\\xbe]*\\\\xbe" at ARGS:myarg. [file "/xyz/httpd/modsecurity/crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "546"] [id "941310"] [msg "US-ASCII Malformed Encoding XSS Filter - Attack Detected"] [data "Matched Data: \\xbcber den Wolken geh\\xc3\\xb6rt ...
I do not know how to easily prevent these false positives. But I think this rule is too strict and definitely does not belong to PL 1.
So I see the following possibilities:

Move the rule to a higher PL
Eliminate the rule entirely
Extend the rule so that a script must follow like @theseion proposed in the linked issue above.

What do you think?

The differences in encoding are due to different ways that the glyph ü can be written in UTF-8. There is a single glyph called U with two dots (code point U+00FC) and it is also possible to write it as a combination of the glyph u and the combining diaeresis glyph (code point U+0308, also known as "trema"). This will often trip up fonts that don't support all combining diacritical marks. When you write a test, be sure to use some way to generate the exact byte sequence (e.g. using hexadecimal encoding), so that your editor doesn't change the glyph to one supported by the font you are using.

Oh, that's smart. Thanks a lot for your input!!
Yes, it seems that my editor is changing the u and the trema (¨) to a ü.
Is it possible to find a curl example that reproduces this problem?
I proposed a PR that moves the rule to PL2. You proposed to extend the rule with a script. I thought that maybe this is too limited. But if we extended the rule with script and img and maybe other valid tags this would be the better solution.
What do you think?

Thank you @theseion for explaining this once more. I did not get it when @franbuehler mentioned it above.
Here is how I get the "incorrect" UTF-8 representation. Maybe this helps with reproducing.
$ echo "666f6f3d75cc880a" |  xxd -plain -revert > /tmp/tmp1
$ hexdump -C /tmp/tmp1
00000000  66 6f 6f 3d 75 cc 88 0a                           |foo=u...|
00000008
$ curl http://localhost -d "@/tmp/tmp1" --trace-ascii -
...
=> Send data, 7 bytes (0x7)
0000: foo=u..
...

That looks good @dune73.
@franbuehled As detailed in the description of the evasion (https://www.owasp.org/index.php/XSS_Filter_Evasion_Cheat_Sheet) this particular evasion only works with US-ASCII and the only known web server to use US-ASCII is Tomcat. So we could say that PL2 is enough since it is not a common configuration (and it would take a misconfigured Tomcat anyway).
Additionally, checking for script would disable the most powerful attacks that use this evasion. However, as you pointed out, other tags could possibly also be used, e.g. an img with a maliciously encoded image (assume for example, that the there's a zero-day exploit in a decompression or image processing library). Therefore, we would probably need to check for any tag that can be used to load external resources:

script
img
link
a
embed
audio
video
source
iframe
map
object
picture
portal
...

This clearly isn't a maintainable option. Then again, most of these would today be covered by CORS policies.
I went back and looked at https://github.com/coreruleset/coreruleset/issues/1645. My original proposal \xbc[^\xbe>]*[\xbe>]|<[^\xbe]*\xbe doesn't work because only the last byte of the two-byte UTF-8 sequence is being considered. This is actually correct because the first byte could be anything else, only the last byte is relevant to the evasion. But that also means that the regular expression isn't specific enough and will match many false positives.
There is one thing we could do with this expression, which is to extend it to look for a complete tag and optional end tag. That should mitigate the false positives that were reported. There are generally two cases here:

the tag does not have an end tag and ends with />
the tag has an end tag </xxx>

Let's do the first case: (?:\xbc[^\xbe>]*/\s*[\xbe>])|(?:<[^\xbe]*/\s*\xbe).
For the second case it's probably better to combine two rules to minimize the cost of running the regular expression. The first rule can check for a start tag and the second for an end tag if the first rule matches:
start tag: \xbc[^\xbe>]*[\xbe>]|<[^\xbe]*\xbe
end dat: (?:\xbc\s*/\s*[^\xbe>]*[\xbe>])|(?:<\s*/\s*[^\xbe]*\xbe)
It would be interesting to test this against content from @Ais8Ooz8 since I don't have a good understanding of the possible byte combinations in the Russion alphabet.

Meeting decision May (https://github.com/coreruleset/coreruleset/issues/2053#issuecomment-831462202):
We go to PL2 and @franbuehler or @dune73 ask @theseion to implement his idea and then we check and we take it back to PL1

I'll take a look in the next few days.

That would be awesome, thank you!!

Just to let you know: I haven't forgotten. I'm finishing up some other stuff and will start working on this ASAP.

@franbuehler I've opened a PR. Could you take a look?

Thank you @theseion!! Yes, I'll take a look.


feat: add image of player profiles

Description
added a feature that shows user profile pics and also signify when it's a user turns to play
Related Issue(s)
Closes #
Checklist:

[ ] Read the contributing docs (if this is your first contribution)

[x] Verified this is not a duplicate of any existing pull request

[x] Performed a self-review of the code

[ ] Rebased to the last commit of the target branch (or merged it into my branch)

[x] Linked the issues which this PR resolves

[ ] Documented the changes in code (API docs will be generated automatically)

hello @princeibs @vibenedict kindly review


[sftp] Handshake failed: no matching client->server cipher

On Windows 7.
VSC Insider version 1.20.0
sftp version 1.0.4
After  upgrade to sftp version , No upload or download in workspaces that worked until today.
Getting below  error [sftp] Handshake failed: no matching client->server cipher

Config algorithms in sftp.json. Get more detail in readme.

Thanks , working fine.
Closing the issue