Cannot Uninstall [!!!]

I have tried everything to get rid of this config for all my projects, and it seems to be stuck loading up the green titleBar + activityBar for one project.
Been tinkering with this for over an hour trying to remove/override whatever setting is being controlled for those elements background colors.
I've done the following already:

disable the package
remove the package from VSCode
remove the folder in /.vscode/extensions/
reset ALL VSCode Settings....

Please advise.

Yea, I would update your README to let people know they need to remove the .vscode folder that gets added to their projects if they want to undo the settings (maybe I missed it?) 👍

hey thank you for letting me now.  good idea for the README.  working on a next version for the extension now.  working on improving the uninstall process & docs
have you tried deleting the colors from .vscode/settings.json?

yea, that was the most frustrating part - I couldn't undo or override the settings on a global level (in settings.json). All good 👍

gotcha, cool.  makes sense.  thanks again for the feedback!

FYI, It appears that .vscode/settings.json can be used for other projects as well, so you shouldn't just automatically delete the .vscode folder (as suggested above).
This project appears to add the lines:
  "workbench.colorCustomizations": {
    ...
    "activityBar.background": "#312B3D",
    "titleBar.activeBackground": "#443C55",
    "titleBar.activeForeground": "#FAFAFB"
  }

So only those 3 lines should be deleted, if there are also other items in workbench.colorCustomizations.
Of course, if there is nothing else in .vscode/settings.json, you can go ahead and delete it ;-)

It would be kind of the extension to automatically remove those settings on uninstall.


Ensure e2e tests use correct runtime images

The e2e tests aren't using some of the ci-built images since we switched to use ServingRuntimes. This PR ensures that the runtime images are updated for testing.

/retest

/retest
One note: the paddleserver image that is being used in the e2e tests seems to have been incorrect for a while, so this  PR should also ensure the most up to date kserve/paddleserver version is used.
As for the E2E tests, the first run failed the following:

predictor/test_xgboost.py::test_xgboost_kserve
pytest predictor/test_paddle.py::test_paddle

While the second run (retest) failed:

predictor/test_raw_deployment.py::test_raw_deployment_kserve
pytest predictor/test_paddle.py::test_paddle

So likely just some flakiness, as all these tests run fine locally for me. The paddle test was giving me issues earlier because of timeouts in the storage initializer when trying to download the model.

/retest

/retest One note: the paddleserver image that is being used in the e2e tests seems to have been incorrect for a while, so this PR should also ensure the most up to date kserve/paddleserver version is used.
As for the E2E tests, the first run failed the following:

predictor/test_xgboost.py::test_xgboost_kserve
pytest predictor/test_paddle.py::test_paddle

While the second run (retest) failed:

predictor/test_raw_deployment.py::test_raw_deployment_kserve
pytest predictor/test_paddle.py::test_paddle

So likely just some flakiness, as all these tests run fine locally for me. The paddle test was giving me issues earlier because of timeouts in the storage initializer when trying to download the model.

The AWS auth token expires after 5 mins, possibly the paddle model sometimes takes long time to download which then causes the python client API to fail. Not sure how it fails the other tests, likely due to resource constraints because the paddle test took too long to finish and other test pods need to wait to get the resource.

/retest

/retest

/lgtm
/approve


Support for dot-separated properties in values files

Is your feature request related to a problem? Please describe.
My KafkaTopic resources use default config properties from a values file like this:
topics:
  defaults:
    partitions: 6
    replicas: 3
    configs:
      retention.ms:<PHONE_NUMBER> # 28 days

Applying those values in the template with the toyaml filter results in a YAML resource with the dot-separated properties split like this:
---
apiVersion: "kafka.jikkou.io/v1beta2"
kind: "KafkaTopic"
metadata:
  ...
spec:
  partitions: 6
  replicas: 3
  configs:
    retention:
      ms:<PHONE_NUMBER>

And then, the tool fails with this error:
|  #1 | TopicConfigKeysValidation | Config key 'retention' for topic    | {}      |
|     |                           | '...' is not valid                  |         |

For reference, here's the code in the template:
...
{% set defaults = values.topics.defaults %}
...
spec:
  partitions: {{ customizations.partitions | default(defaults.partitions) }}
  replicas: {{ customizations.replicas | default(defaults.replicas) }}
  configs:
    {% set configs = {} %}
    {% do configs.update(defaults.configs) %}
    {% do configs.update(customizations.configs) %}
    {{ configs | toyaml | indent(4) }}

Describe the solution you'd like
Honestly, I am quite surprised no one has faced this problem. Either I'm doing something wrong or my use case isn't that common (FWIW, we are moving from an imperfect but working Helm chart with Julie).
So, my request is to either:
a) Don't split YAML keys in values files.
b) Dot-join the nested config properties under configs in the KafkaTopic resource before actually validating and applying them.
c) Enable recursive macro support in JinJava (I've defined a recursive macro to "flatten" the nested maps but recursion is disabled):
JinjavaConfig.newBuilder().withEnableRecursiveMacroCalls(true)...
Describe alternatives you've considered
As I said above, maybe my template is wrong. If so, any advice is greatly appreciated.
Additional context
Thanks very much.

Hi @dav-garcia, you should now be able to test the early-access release which provide a fix for your needs (i.e., configs will be automatically flatten internally). In addition, I've added the capability to enable/disable recursive macro calls.
Out of curiosity, what motivated your migration from JulieOps to Jikkou? If you found any missing feature feel free to open github issues. Thank you.

Great! Thanks a lot @fhussonnois!
Regarding Julie, our main concerns are: a) It's no longer maintained. b) No template support (we relied on Helm for it).
Anyway, I really like the Jikkou approach of declaring configurations as k8s resources; it fits nicely.

I can confirm that flattening the nested maps works. :ok_hand:
I haven't tested the recursive macros feature.
Thank you.

Thank you very much for your feedback @dav-garcia. Don't forget to add a star to the Github project. It's really rewarding and useful for promoting the project ^^. 🙏


can you simplify the code of vmamba.py?

This script seems too long, making read a little bit hard. Can it be splited into multiple scripts?

Thank you for your advice, I'll consider it.


Add plastic stress analysis

Hi I just discovered this library and it's fantastic, great work. Plan to use it on a project tomorrow (Thursday); I am analyzing the X section properties of some aluminum extrusions (creating load span tables for the rails of a solar panel racking system; an image is attached in case anyone is interested).

[x ] I have searched the issues
of this repo and believe that this is not a duplicate.
[x ] I have searched the documentation and
believe that my question is not already covered.

Feature Request
I am not sure how complicated it would be to add this feature, but it would be great to be able to analyze plastic behavior of a cross section under a given set of loads, and not just linear elastic behavior. I'm especially interested in pure bending for my purposes. However I suppose to be added to the library, all forms of stress would need to be considered, and not just a pure bending moment.
The main reason for this is the manufacturer wants to squeeze as much performance out of these rails as possible even if it means permanent deformation, which could be acceptable for an extreme scenario like a hurricane.
Thanks for the consideration!

Cool, I agree it's good to stick to the project scope.
I'll have a look at the other project. Thanks!


Add Docker healthcheck

Codecov Report

Merging #14 (6bf92da) into main (358c919) will increase coverage by 0.06%.
The diff coverage is 0.00%.

:exclamation: Current head 6bf92da differs from pull request most recent head 7417936. Consider uploading reports for the commit 7417936 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   72.04%   72.10%   +0.06%
==========================================
  Files          13       13
  Lines        1098     1097       -1
==========================================
  Hits          791      791
+ Misses        267      266       -1
  Partials       40       40

Files Changed
Coverage Δ

internal/inbound/rest/server/server.go
2.43% <0.00%> (+0.02%)
:arrow_up:


Support question: is lazy loading possible for data-original?

At this moment, the image referenced in the data-original attribute is loaded on page load. Is it possible to lazy load that image when activating zoom? Any plans to add this functionality in the future?
Kind regards,
Jan

@janlemmens The option preloadImage is enabled by default. You can set it to false so that it loads data-original only after it starts zooming in:
const zooming = new Zooming({
  preloadImage: false
})

Great! Thanks for the quick feedback. Must have missed that setting. Nice work on the library btw!


Refactor key import function

Following up on #26, I have refactored the import_key function out into two separate functions and have done some general cleanup.
As for the precomputations, I haven't done them yet as I don't know what is safe to adapt over from rsa's generate_multi_prime_key() and PrecomputedValues.

Seems like I didn't tag all the methods I needed to in #[cfg(feature = "untested")]. I only ran cargo check --features untested. locally, my bad there.

Looks like an improvement so far.
@str4d any thoughts on this?

I took a stab at calculating the RSA pre-computation values but ran into a small snag. The BigUint rsa uses is from a forked crate, and on top of that, the ModInverse trait for the same reason. I tried switching the crate yubikey-priv uses to the forked version, but the X509 certs have the standard one.
Do you have a recommended approach for managing the two types of BigUints?

 You may need to use the "semver trick"?

I looked into the semver trick and found this post, which worked just like I wanted.
For the precomputation values, I tried to follow what the RSA crate does as close as possible. I had to bring in a few more of the num- crates as well for some traits.

Cool, glad you got it working.
It'd be good to maybe open some issues upstream to try to coordinate the versions so we don't need to use two of them in perpetuity.

As for the upstream issues, I opened one here on num-bigint-dig about upstreaming the ModInverse trait, hopefully its a reasonable thing and possible.

I tried to test that this works with my Yubikey, but I get an auth error every time I try. No clue if this is because the API is being used wrong or if because I did something with my Yubikey when I first got it and forgot. The official tool mentions something about the management key and how a default is provided, but I wasn't able to pinpoint exactly where that happens in the C code, nor in this library.
Would you mind giving it a try? This is the code I used in tests/integration.rs:
#[test]
#[cfg(feature = "untested")]
fn import_rsa_2048_key() {
    let mut p = [0u8; 32];
    let mut q = [0u8; 32];

    getrandom(&mut p).unwrap();
    getrandom(&mut q).unwrap();

    let key_data = RsaKeyData::new(&p, &q);

    let mut yubikey = YUBIKEY.lock().unwrap();
    let slot = SlotId::KeyManagement;
    let algorithm = AlgorithmId::Rsa2048;
    let touch_policy = TouchPolicy::Default;
    let pin_policy = PinPolicy::Default;

    import_rsa_key(&mut yubikey, slot, algorithm, key_data, touch_policy, pin_policy).unwrap();
}

There is a fair chance that you will have to run a few times to get past the RsaKeyData::new() because the random bytes aren't always primes, so the exp.mod_inverse(&totient) fails sometimes.


Applicant experience: Make top left "CiviForm" a link to applicant home page

The "CiviForm" in the top left corner of the navigation bar in the applicant UI should link back to the home page on click.
Question: Where should this navigate to when the user is a TI?

Applicant experience should link to the ProgramIndexView.
TI experience should probably link the the TrustedIntermediaryDashboardView.

OK, this is much easier now that I realized I can just send any user to the "home index" page, which will properly handle the redirect!


Adding an IsEnabled property to commands

This fixes #75

Tested this on stream, and it does seem to resolve #75


Support unification for Micro module

Type

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description

Related

Related Issue #
Closes #

Don't know how to change target brunch(
Bot has changed it from the main

Don't know how to change target brunch( Bot has changed it from the main

Done, you need to hit Edit on the PR title, it's an odd ux imho


Option to trust HTTP-username

In order to allow users to authenticate against our corporate mechanism, we will front Uchiwa with an Apache-based proxy. Apache will verify the user's credentials and forward the request -- including the username -- to Uchiwa.
We'd like Uchiwa to accept that username and treat each such user according to settings for their roles -- without asking for password, indeed, without even having the password-fields in the "users":-substree of the configuration JSON.
Can such a feature be added, please?

Thank you for opening an issue! We already have a similar request (https://github.com/sensu/uchiwa/issues/295) for this feature so I'll go ahead and close this one to avoid any confusion.


Release to production

Just following up on a Thread over the weekend. It's been quite a while since we did a release, so it would be handy.

[x] Ensure auto-import isn't happening when not flagged.  https://github.com/textileio/photos/issues/1067
[x] Get latest mobile enhancements into app. https://github.com/textileio/go-textile/releases/tag/v0.1.14

Done.

Are either of these blocking release?
https://github.com/textileio/photos/issues/1085
https://github.com/textileio/photos/issues/1083

Not sure. I haven't seem those problems. Anyone else?
Did those happen when installing the latest beta?

The wiped state I'm not certain. I believe it was after doing an update yesterday.
The blank screen i can get anytime launching out of a hard kill.


float() argument must be a string or a number, not 'FloatNode'

Since there is no support for numpy.linspace, I was trying to make a following workaround:
 def linspace(start, end, num):
     l = autograd.numpy.zeros((num))
     for i in range(num):
         c = i / (num-1)
         v = start * (1-c) + (c) * end
         l[i] = v
     return l

This is embedded in an algorithm where start and end depend on the parameters wrt. which we differentiate and num is a fixed constant. Unfortunately, this code produces an error:
`float() argument must be a string or a number, not 'FloatNode'''
in the line ` l[i] = v'.
I may by making a simple mistake here - if someone has a quick fix for my use case, I'd be very grateful.

Autograd doesn't support assignment into arrays. However, you could rewrite your code like this and even avoid the Python-level loop:
def linspace(start, end, num):
    return start + np.arange(num) * (end-start)/(num-1)

Both the original and this version have a divide-by-zero problem when num is 1, so you might want to check that with an if statement or assertion.
Which argument were you planning to differentiate with respect to? I think this code should work for differentiating with respect to start and end, though I didn't test it.
Thanks for bringing up the lack of linspace gradients. Hope this comment helped solve your issue, and feel free to reopen if it didn't!

Just added support for numpy.linspace. Don't know how we missed that one.


scmc-seq attribute updates to data model

PR used to address the following issue: https://github.com/ncihtan/data-models/issues/95

Humm.. Github seems to think they are level. Not sure what is going on there.

@adamjtaylor Ah okay - apologies for that. Just updated with the main.

Looks good to me. @PozhidayevaDarya can you create an issue to link to this PR in which you include links to thr relevent RFCs - once done and if @elv-sb is happy we can merge.

Yay! Thanks @adamjtaylor -- just linked PR in the description to original issue posted by Dave

These are new components so I will also need to add to the HTAN-data-curator config


Simplify GHA CI

This PR extremely simplifies our GHA workflow. The motivation is a previous PR where some bugs didn't get caught because they weren't being tested. The workflow had become so complex that it effectively became a black box where it was hard to identify problems. Some tasks were executed twice, some were incoherent, and some were missing.
The workflow in this PR is extremely simplified into one optional action per step: patch boost, cmake workflow, or b2 workflow. This is much more readable and any complex details are handled by the actions, which include their own steps with relevant optimizations.
Assuming runners are available, which they usually are, the final result is also more efficient than our current drone workflows even with the public-hosted runners:

It might look like the complexity is only being moved to the actions files here, but the intention is to later move these actions to a separate repository, from where they can be reused. It's already the 4th repository where I use these actions and a new repository will be created for them once they are battle tested. So these are the actions:

The boost_clone action includes a script to scan dependencies before cloning boost and caching based only on these dependencies. Caching saves us about 4 minutes in the workflow. When there's no cache, the scanning scripting saves us about 2 minutes.
The b2_workflow action takes the boost source directory and does whatever it needs to test the specified modules. This includes compiling b2 if needed and generating a proper user-config.jam file.
The cmake_workflow validates the cmake version installed in the system, updates cmake if the library has a different minimum version, identifies how features that cmake version supports, and runs a complete cmake workflow (configure, build, test, install) adjusting the parameters as needed according to the features that cmake version supports. It also creates github annotations when warnings or errors are emitted at any of these steps.

A few adaptations were made in the CMake scripts to make these workflows simpler and more efficient.

The main CMakeLists.txt was split into sections that are smaller and easier to read.
A separate section is dedicated to looking for Boost source files in BOOST_SRC_DIR, which still defaults to ../... The section implements the logic to create any interface targets Boost.URL might need. This means anything after this section can assume Boost was found from "../..", and any logic related to find_package(Boost) or any other way of finding boost was been completely removed.
The standalone install target has been removed. It never worked and we just didn't know about it because it wasn't being tested properly.
Other internal CMakeLists.txt files were standardized so they all look the same.

I just noticed something. The GHA workflows are faster but only as long as the machines become available. I noticed it never takes more than a few seconds when working on it but it usually takes several minutes once it's in boostorg. We will never know for sure, but it seems like GitHub implements some kind of load balancing weighted by profiles. So boostorg is just always consuming its public quota with hundreds of repositories testing with dozens of machines and even scheduled tasks sometimes.

What happens when you build the Visual Studio solution using the VS2022 generator?


NTR: galactose free diet

Parent: dietary intervention (MAXO:0000088)

Label: galactose free diet
Definition: Avoidance of breast milk, proprietary infant formulas containing lactose, cow’s milk, dairy products, casein or whey-containing foods, and medications with lactose and galactose for the management of classic galactosemia or clinical variant galactosemia.
Reference: PMID:20301691, PMID:20625932
Avoidance terms: lactose, galactose, dairy, casein, whey, human milk
I wasn't certain if this definition felt too infant oriented, obviously this is still present in adults so I was hoping for more encompassing.

See the consolidated ticket. Closing.


Upgrade botocore to 1.4.93

Thanks!
This fulfills a prerequisite for https://github.com/rusoto/rusoto/issues/468 .


Subscribe/unsubscribe to should be done on the postfix 'sent' not 'send'

This broke the tests, but used it for the basis of https://github.com/octoblu/meshblu/commit/74b9692b0d7753855e99587fb5ea06058ab0074a.

Ah I had just fixed the tests locally. You're too fast :)


v-if with attribute added after page load

I have something like this:

{{color.value}}

	{{color.color}}

and that's my instanse:
vue = new Vue({
    el: 'body',
    data: {
        colors: [
			{
				color: "red",
				value: "#f00",
			},
			{
				color: "green",
				value: "#0f0",
			},
			{
				color: "blue",
				value: "#00f",
			},
			{
				color: "cyan",
				value: "#0ff",
			},
			{
				color: "magenta",
				value: "#f0f",
			},
			{
				color: "yellow",
				value: "#ff0",
			},
			{
				color: "black",
				value: "#000",
			}
		],
    },
    computed: {
    },
    methods: {
    	open: function(i){
    		setAll(this.test, 'show', false);
    		this.test[i].show = true;
    	}
    }
});

If every color is formatted like this:
{
	color: "black",
	value: "#000",
	show: false,
}

It's working good.
My issue here is if i don't have the 'show' attributes set at the start and i'm doing colors[0].show = true AFTER the page loads it's not working.
Any idea why and how to override this?

vue cannot detect the changes you add afterwards. You have to set the show variable to false or undefined in the data object. You can also use the $set method or so. Look at http://vuejs.org/guide/#Model


Example

Hello,
Could you please provide a quick example on how to use this library?
Thanks

Thanks for submitting this issue! I have updated the documentation, so now there are a couple of examples at https://godoc.org/github.com/carterjones/signalr


The action "stop" on a Machine resource does not appear to work

From the documentation https://docs.chef.io/resource_machine.html
Attempted to stop a machine with the action of stop in a machine resource.
machine 'MyMachine' do
action :stop
end
However, this results in the below error.
RuntimeError
Chef::Provisioning::AWSDriver::Driver does not implement stop_machine
This is reproducible with
Chef-client 12.4.3
chef-provisioning-aws - 1.5.1
chef-provisioning - 1.4.1
Or
Chef-client 12.4.3
chef-provisioning-aws - 1.3.1
chef-provisioning - 1.3.0

Closed issue - because the I believe the problem is with the chef-provisioning-aws driver.


screen state

Hi
Is it possible to detect somehow if the video goes to full screen?

@szuniverse Hi! Sorry for the delay. Thanks for your question.
I suggest checking out the WebKit full screen APIs. If there's some kind of JavaScript method to end full screen mode, you can call that in your playerStateChanged(videoPlayer: YouTubePlayerView, playerState: YouTubePlayerState) body, checking for playerState == .Ended.
It seems like you're not alone, as @bobbyali requested something similar in #5. I'd certainly be open to merging a feature like this if you want to build it.
This Apple doc on "Controller Media with JavaScript" might be helpful for starters!
Let me know how it goes :)

Okey Thanks! :)


Add cross-platform NumberInput spinner buttons

Right now the increment/decrement spinner buttons are small and don't match the rest of the styling
Looking into it, these are webkit-specific spinners. I may disable the spinners and make some form hover buttons that appear onfocus
Marking as high priority as it will block cross platform support

completed with #78


Build with VS 2017 fails when the 2015 toolset is not installed

Even though the README says that RetDec build should work with VS 2015 Update 2 or later, the build currently does not work with VS 2017 unless the 2015 toolset is installed (see e.g. #50, #61, https://github.com/avast-tl/fileformat/issues/4).
We are working on a fix. This is a tracking issue for all issues related to the build with VS 2017 without the 2015 toolset.

Fixed in 7ccf79f3efbae32200dc9a0ab65b5d1b7b3c5389


Remove Double Slashes From URL

There are some cases, when the resulting path contains double slashes.
For example
http://minio:9000//img-cache//rs/default/unsafe/430x100/thumbor.jpg

Could you please make an additional check when building the path ?

@beeyev, can you create a PR to help us reproduce this scenario?

If you set these variables like this:
AWS_RESULT_STORAGE_BUCKET_NAME='img-cache'
AWS_RESULT_STORAGE_S3_ENDPOINT_URL='http://minio:9000/'
AWS_RESULT_STORAGE_ROOT_PATH='/abc'

The result path will contain double slashes:
http://minio:9000/img-cache//abc/unsafe/320x400/yezhik.jpg

I'm sorry @beeyev, but I couldn't reproduce this issue


Can we make it so this file only affects the README, Readme, README.md, or Readme.md files?

Otherwise it appends the block to any Markdown file!

+1 to heading option, -1 to filename "filter".
Over at the Level org we have the table in CONTRIBUTORS.md, because it gets too big for the README. For example: https://github.com/Level/levelup/blob/master/CONTRIBUTORS.md

@vweevers how about a config param that a certain number should be inserted into the README otherwise into a CONTRIBUTORS file?

how about a config param that a certain number should be inserted into the README otherwise into a CONTRIBUTORS file?

That could make remark-contributors too opinionated. I prefer the simple solution by @wooorm.

@hughsk Are you still interested in maintaining this? We can also move it to the remarkjs org where I can help out and that would make it easier for the community to help out?


do not encode rgw label endpoint

Instead, let's use plain but replace the colon with an underscore.
Otherwise setting the label will fail with:
message: 'Error while reconciling: NooBaa.noobaa.io "noobaa" is invalid: metadata.labels:
  Invalid value: "MTAuMS44LjQxOjgwODA=": a valid label must be an empty string
  or consist of alphanumeric characters, ''-'', ''_'' or ''.'', and must start
  and end with an alphanumeric character (e.g. ''MyValue'',  or ''my_value'',  or
  ''12345'', regex used for validation is ''(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?'')'
reason: ReconcileFailed

Fixes the issue caused by: #580
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>Corresponding Noobaa PR: https://github.com/noobaa/noobaa-operator/pull/360

/retest

/test ocs-operator-e2e-aws

/cherry-pick release-4.5


对话保留上下文吗？

实现方式是每次都将之前的圣诞内容传过去吗？

I think the conversation is not associated with previous conversations currently.

This is supported in the new version v1.0.2.
You can take a series of messages (including the conversation history) as input, and it will return a response message as output.


Question about dataset preprocessing

Hi, thanks for your excellent work!
When I run command make create_data, I got the following error:

Through debug, I traced back to coperception\utils\mapping\mapping.py, and run command python mapping.py, I got the following error:

My system is Windows 11 x64, and python version is 3.7.12.
Is this because the .pyd file dosen't match my system?
Could you tell me what the problem is?

This could be the error. Or it could also be that your system is missing some C++ dependencies.
If you like, you could try to build mapping under your system using the code in this directory: https://github.com/coperception/coperception/tree/master/coperception/utils/mapping/dynamic_library
But I would strongly recommend running coperception on a Linux machine instead, since currently we don't have full support over Windows systems. You can use WSL for example.

This could be the error. Or it could also be that your system is missing some C++ dependencies. If you like, you could try to build mapping under your system using the code in this directory: https://github.com/coperception/coperception/tree/master/coperception/utils/mapping/dynamic_library But I would strongly recommend running coperception on a Linux machine instead, since currently we don't have full support over Windows systems. You can use WSL for example.

Thank you for your prompt reply!
I will try it with WSL.

I successfully ran coperception with WSL and trained with when2com and lowerbound. My dataset is v2.0 and I also set num_agent to 2 and used RSU. But when I trained with v2v, I got the following error:

Then I set num_agent to 6, I got the following error:

Could you tell me what the problem is?

My dataset is v2.0 and I also set num_agent to 2 and used RSU.

The number of agents should be left unchanged (equal to the number of agents we currently have in the dataset), or there will be errors.

Then I set num_agent to 6, I got the following error.

Does the error only occur for v2v? And are you able to reproduce it every time?

Closing this issue due to inactivity. Feel free to reopen if needed.


Vault User

changing the user runs as to vault
changing the base image to alpine:3.5
updating the examples
changing the golang version to 1.7.5

fixes https://github.com/UKHomeOffice/vault-sidekick/issues/30


Removed console.log from date.js.

Hi there,
There was a console.log in the date.js file as part of mail catcher. This causes issues when using with ie - see http://stackoverflow.com/questions/11147553/ie9-makes-ajax-call-correctly-only-ofter-hitting-f12/11147595#11147595
I compared this date.js with the original from https://github.com/datejs/Datejs and it wasn't present there - so saw no harm in removing.

Weird, I don't know how that got in there. Thanks!

This is shipped in the latest version, v0.8.0.
gem install mailcatcher


Added charset that allow for emojis

As per https://github.com/usememos/memos/issues/4127, emojis are causing migration and website usage issues
MySQL required a specific charset to store emojis.
This PR adds the required charset to the field that store the full list of available emojis for reactions as well as the field that stores emoji reactions added to memos

@boojack , the mySQL docs shows using mysql_prod as the db name, but previous migrations scripts alter db memo. I used mysql_prod in the pr. What is the db name to use in the scripts?


fix(sec): upgrade org.apache.kafka:kafka-clients to 2.7.2

What happened？
There are 1 security vulnerabilities found in org.apache.kafka:kafka-clients 2.7.0

CVE-2021-38153

What did I do？
Upgrade org.apache.kafka:kafka-clients from 2.7.0 to 2.7.2 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
How was this patch tested?
Run mvn compile failed locally, couldn't complete the build process.
Run mvn clean test failed locally, unit-test couldn't pass.
The specification of the pull request
PR Specification from OSCS

@vvsd fix the dependencies check according to the doc https://linkis.apache.org/zh-CN/community/development-specification/license#license-检测规则


The v2 is a folder on main branch, not a branch. Is this ready to use and replace v1?

Or maybe it's still WIP, and I should use v1 instead. A bit confused.

I'm pretty sure this is standard practice.
https://go.dev/blog/v2-go-modules

You can bring go-anytime/v2 into your project by running
go get github.com/ijt/go-anytime/v2
and importing it like this:
package main

import (
	"fmt"
	"log"
	"time"

	"github.com/ijt/go-anytime/v2"
)

func main() {
	r, p, err := anytime.ParseRange("January is so cold!", time.Now(), anytime.Past)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Printf("range start: %#v, parsed string: %q\n", r.Start().Format(time.RFC3339), p)
}


[BEAM-6988] solved problem related to updates of the str object

Update to Beam 6988. Removed comment since it was wrong. Will update

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @aaltay  @fredo838  @Juta  @tvalentyn

No ;( sorry for having two badly looked through PR atm. I will look at

No worries!

BACKGROUND: I thought I understood the reason for the error(thought it was to difference in str.split in python2 vs python3) and changed in the test. However @tvalentyn pointed out that that was not the case. Thus it is unclear why it fails and changing in the test is not a good solution.
The test fails in "/beam/sdks/python/apache_beam/typehints/decorators.py", line 298, in getcallargs_forhints" when calling the function inspect.getcallargs(func, *packed_typeargs, **typekwargs). This function fails due to that in python3 to few positional(1 is passed) arguments are passed where two args are need(self,chars). This result in that the test fails with the error strip() missing 1 required positional argument: 'chars'.  In python 2 one positional argument is passed and one arg is required. I would be very happy for some help on this @udim(know you mentioned earlier you would be happy to help) since I can't figure it out. Have really tried my best :)
What i have figured out:

There is a difference in the inspect.getcallargs between python2 and python3
There seams to be a difference in the required arguments when using str.split in python2 vs python3

If you have any tips/questions/advice on how to solve it, let me know :)

I tested this function, for python 2.7 - 3.5 - 3.6 - 3.7.
The result of calling getfullargspec(fstr.split)
2.7 FullArgSpec(args=['_'],  ...)
3.5 FullArgSpec(args=['self'],  ...)
3.6 FullArgSpec(args=['self'],  ...)
3.7 FullArgSpec(args=['self', 'sep', 'maxsplit],  ...)
Seems that is related to the 'monkeypatch' specified in here, which is already an issue in JIRA (BEAM-5490, which was partially fixed by PR-6781, but this assumed all python 3 versions behaved the same. Author of this PR is @tvalentyn , so I guess that makes a full circle. I think we need to rework the typehints file to remove the monkey patch. It shouldn't be necessairy in python3.7, because the  inspect module can now take str.split as input, while it fails on python3.6 and python3.5. But then how would we go about on python3.5-3.6? @thoughts?

getargspec and getfullargspec has not worked on builtin functions before 3.7.
What we're getting in 3.5 and 3.6 is the result of:
>>> typehints.decorators.getfullargspec(str.strip.__call__)
FullArgSpec(args=['self'], varargs='args', varkw='kwargs', defaults=None, kwonlyargs=[], kwonlydefaults=None, annotations={})

Note that this is a bogus argspec with self, args, and kwargs.
Does anyone know what corner case these lines handle?
https://github.com/apache/beam/blob/5c7ee600ba8560102f61622c894633955d208f87/sdks/python/apache_beam/typehints/decorators.py#L131-L133

In apache_beam.typehints.typed_pipeline_test:MainInputTest.test_non_function, getcallargs_forhints is called twice:
https://github.com/apache/beam/blob/ef4b2ef7e5fa2fb87e1491df82d2797947f51be9/sdks/python/apache_beam/transforms/ptransform.py#L761-L762
The second time fails, since type_hints is equals to ((<class 'str'>,), {}), but inspect.getcallargs fails because it thinks str.strip has 2 required positional args (self and chars). I opened a bug for this (https://bugs.python.org/issue36920), but I believe we can use inspect.Signature instead in Python 3.
The code generating the type hint is I believe:
https://github.com/apache/beam/blob/5c7ee600ba8560102f61622c894633955d208f87/sdks/python/apache_beam/typehints/decorators.py#L330-L331
So this brings up some questions (cc: @robertwb)

Are partial type hints okay?
Is the type hints heuristic from decorators.py above useful? Should it stay?

To summarize: the type hints generated for str.strip are partial and inspect.getcallargs is buggy and believes that str.strip has 2 required positional args instead of 1.
I think that if we decide to not guess type hints for builtin functions in Python 3 (the code in decorators.py), then this will solve the issue.
Another option is to replace inspect.getcallargs with inspect.signature(fn).bind(...), which seems to be less buggy, but only works for builtins in 3.7.

I'm not exactly sure what you mean by "partial type hints" but we should attempt to provide as much information as possible, but not fail if we can't. We'll probably just have to work around 3.5 and 3.6, referencing the bug.
As for (2), this should probably stay until inspect works well on builtin methods.

fn.__objclass__ is a partial type hint for some builtin methods, since it doesn't provide type information to all possible arguments.
In Py3.7:
>>> inspect.signature(str.isupper).bind('a')  # okay
<BoundArguments (self='a')>
>>> inspect.signature(str.strip).bind('a')  # missing optional arg chars
<BoundArguments (self='a')>
>>> inspect.signature(str.join).bind('a')  # missing required arg iterable
TypeError: missing a required argument: 'iterable'

We can avoid the TypeError above by using bind_partial(), but the type information for arguments beyond self will be missing from all builtins. Hence, these are partial type hints.

BTW, I'm still trying to come up with a fix for 3.7.


updating build

Checklist

[ X ] Used a personal fork of the feedstock to propose changes
[ X ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

I didn't mean to close this.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Thanks! This is now superseded by #36


ed25519 keys

This guide is phenomenal -- a real source of valuable, concise info.
With the introduction of ed25519 support in Yubikeys made from 2020, are there any plans to include them/replace the RSA keys in this guide? Just curious.

I think the guide should have a section on choosing your key type rather than defaulting to ed25519. A discussion on the differences of RSA, ecdsa and ed25519 and the other variants would be beneficial to some but a right out off for many beginners.
Many people buy second hand Yubikeys (notably the Yubikey 4 and neo varieties) off eBay  not knowing the difference.
RSA is the lowest common denominator (and the default for most organisations using PIV mode).
Although ed25519 had many benefits including speed, size and probably harder to crack, it is still considered NEW (“Danger Will Robinson”) as some consider it too new for any cracks to be found. I personally prefer ed25519 for most applications.
There is also the other issue of the real world not really keeping up with the technology. Routers often aren’t replaced for several years (sometimes even decades on government networks) and many of those are stuck with either RSA or DSA. The same goes for older servers stuck on old OS versions because “the application breaks if we upgrade the OS”
The choice of RSA is a safe choice for beginners. But once they know a little more about cryptography and how it is used and more importantly what is supported in the users organisation then we should encourage them to consider better cryptography if feasible.

On 17 Jul 2022, at 00:06, Kristopher James Kent @.***> wrote:

This guide is phenomenal -- a real source of valuable, concise info.
With the introduction of ed25519 support in Yubikeys made from 2020, are there any plans to include them/replace the RSA keys in this guide? Just curious.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Great points!

I think at a minimum it would be good to mention it as an option. The yubikey docs link here and i had to go looking to find out if it's supported. Many people probably aren't up to date with all the product releases.

Until there's a known problem with RSA, I see no need for changes. Certainly PRs are welcome to educate readers on the general crypto primitives and differences between algorithms.


As a [end user], I want to receive a notification when a transfer is completed

Problem
Users want to fire a transaction and click away, and so they won't know when their transaction is completed unless they check manually.
Proposed Solution
Some notification system (like a sound) to alert the user that the bridging was completed.
Acceptance Criteria
Reliably notify the user when a transfer is completed.

I like this

@pjenviri @nrsirapop i'm just reviewing outstanding issues, let me know if this might need more scoping or specifics on how to show notifications, i realize it's open-ended

We're concerned about building a separate backend system for solely maintaining this feature and don't think it will be worth the effort for now (it's hard to maintain).


Configuration generation is currently broken

Upon finishing my config generator journey, I found an error waiting right at the end:

Turns out the webui is 500'ing when trying to generate a config:

This is due to attempting to call generate_config in Synapse with the database_conf argument, which was removed as part of a configuration cleanup PR.
Looks like this option was only related to the database however, and should not affect any other sections.
This makes synapse-config-generator incompatible with Synapse v1.13.0+.

why is this even a thing? surely the config generator shouldn't need to run code from within synapse?


Suppress newTaskTempFile method warnings for Spark 3.3.0 build

Fixes #4632.  Suppressing the deprecation warnings caused by SPARK-38015.  I don't think it's worth shimming these until we move to a Spark version that has removed these methods.

build

I am assuming that 3.3 didn't change their code either.

They just added the deprecations.  As noted in SPARK-38015:

We didn’t delete the existing file naming functions (newTaskTempFile(ext) & newTaskTempFileAbsPath(ext)), because we were aware of many other downstream projects or codebases already implemented their own custom implementation for FileCommitProtocol.

So they realistically cannot break the semantics until a new major version of Spark, or they are convinced they won't break things downstream significantly.  This would happen on a minor release boundary at best.  In any case, when they decide to do something, the old methods will be removed, and we'll notice when the build cannot find them.


Cannot restore Git dependency on Azure web sites

Description
I tried using Paket to install Git dependencies in Azure web sites - running Paket on Azure machine - and it fails to restore Git dependency:
Paket.exe <IP_ADDRESS> is up to date.
Paket version <IP_ADDRESS>
Paket failed with:
	Checkout to D:\home\site\repository\paket-files\github.com\ionide\FsAutoComplete failed.
Message: Could not run "git clone file:///.paket\git\db\FsAutoComplete".
Error:
Cloning into 'FsAutoComplete'...
fatal: 'D:/Program Files (x86)/Git/.paket/git/db/FsAutoComplete' does not
appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Paket failed with:\r\n
  Checkout to D:\home\site\repository\paket-files\github.com\ionide\FsAutoComplete failed.\r\n
  Message: Could not run "git clone file:///.paket\git\db\FsAutoComplete".\r\n
  Error: \r\nCloning into 'FsAutoComplete'...\r\n
    fatal: 'D:/Program Files (x86)/Git/.paket/git/db/FsAutoComplete' does not appear
       to be a git repository\r\n
    fatal: Could not read from remote repository.\r\n\r\n
      Please make sure you have the correct access rights\r\n
      and the repository exists.\r\nD:\Program Files (x86)\
         SiteExtensions\Kudu\57.50815.2378\bin\Scripts\starter.cmd build.cmd deploy

Repro steps
All I had in my paket.dependencies was
framework: >= net40
source https://nuget.org/api/v2

nuget FAKE

git https://github.com/ionide/FsAutoComplete.git cors build:"build.cmd LocalRelease", OS: windows
git https://github.com/ionide/FsAutoComplete.git cors build:"build.sh LocalRelease", OS: mono

Related information
Version of Git on the Azure box is:
git version 2.8.1.windows.1

I don't have azure, so I'm not able to debug this. Any ideas what's going
wrong?
Am 21.08.2016 03:45 schrieb "Tomas Petricek"<EMAIL_ADDRESS>
Description
I tried using Paket to install Git dependencies in Azure web sites -
running Paket on Azure machine - and it fails to restore Git dependency:
Paket.exe <IP_ADDRESS> is up to date.
Paket version <IP_ADDRESS>
Paket failed with:
Checkout to D:\home\site\repository\paket-files\github.com\ionide\FsAutoComplete failed.
Message: Could not run "git clone file:///.paket\git\db\FsAutoComplete".
Error:
Cloning into 'FsAutoComplete'...
fatal: 'D:/Program Files (x86)/Git/.paket/git/db/FsAutoComplete' does not
appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Paket failed with:\r\n
Checkout to D:\home\site\repository\paket-files\github.com\ionide\FsAutoComplete failed.\r\n
Message: Could not run "git clone file:///.paket\git\db\FsAutoComplete".\r\n
Error: \r\nCloning into 'FsAutoComplete'...\r\n
fatal: 'D:/Program Files (x86)/Git/.paket/git/db/FsAutoComplete' does not appear
to be a git repository\r\n
fatal: Could not read from remote repository.\r\n\r\n
Please make sure you have the correct access rights\r\n
and the repository exists.\r\nD:\Program Files (x86)
SiteExtensions\Kudu\57.50815.2378\bin\Scripts\starter.cmd build.cmd deploy
Repro steps
All I had in my paket.dependencies was
framework: >= net40
source https://nuget.org/api/v2
nuget FAKE
git https://github.com/ionide/FsAutoComplete.git cors build:"build.cmd LocalRelease", OS: windows
git https://github.com/ionide/FsAutoComplete.git cors build:"build.sh LocalRelease", OS: mono
Related information
Version of Git on the Azure box is:
git version 2.8.1.windows.1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/1863, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNJH7x-IXzU9DllxFdAT8kMUNGM_eks5qh63GgaJpZM4JpNFC
.

To my understanding you do not have write permissions to D:/Program Files (x86) in Azure web sites.

Weird. Why would we write there?

@cdrnet Yeah, I would imagine that that's the problem, although the error message could be a little clearer.

So if someone can find the place where we try to write there it would be really helpful

Is there a way to get more verbose log than with -v?
The script runs in D:\home\site\repository and the output message says that it tries to check out into D:\home\site\repository\paket-files\github.com\ionide\FsAutoComplete, but then it says Could not run "git clone file:///.paket\git\db\FsAutoComplete", which makes me think that perhaps (for some reason), the command that Paket runs is somehow incorrectly generated?

-v is all we have. More details can only be added in pull request.
Am 21.08.2016 19:00 schrieb "Tomas Petricek"<EMAIL_ADDRESS>
Is there a way to get more verbose log than with -v?
The script runs in D:\home\site\repository and the output message says
that it tries to check out into D:\home\site\repository\paket-files
github.com\ionide\FsAutoComplete, but then it says Could not run "git
clone file:///.paket\git\db\FsAutoComplete", which makes me think that
perhaps (for some reason), the command that Paket runs is somehow
incorrectly generated?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/1863#issuecomment-241268854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNA-PV99ouJl6RICcz5qnvdbZQ0C8ks5qiIQbgaJpZM4JpNFC
.

@tpetricek any chane for me to reproduce that with your project? like pushing more and more paket releases with more detailed logs and see what happens?

when I run locally I get:

so it's using my user path where it's using D:/Program Files (x86)/Git/ for you

@tpetricek what's Environment.GetFolderPath(Environment.SpecialFolder.UserProfile) giving you?

@forki Good psychic debugging skills!

> System.Environment.GetFolderPath(System.Environment.SpecialFolder.UserProfile);;
val it : string = ""

ok. then I need to work around that.

any ideas for alternative location for git repo cache?

I suppose LocalApplicationData might work:

> System.Environment.GetFolderPath(System.Environment.SpecialFolder.LocalApplicationData);;
val it : string = "C:\DWASFiles\Sites#1tryfsharp-autocomplete\LocalAppData"

(Unless the hash sign in the URL breaks something else :-))
Alternatively:

Allow an override via an explicitly specified environment variable? (Probably too much hassle)
Local directory of paket.exe (Not that useful, but would likely always work)

ok let's test LocalApplicationData  - but tomorrow...

:+1:

ok release new version with a fix. please try it

:tada: :clap: Everything working now!

awesome!


Avoid duplicates on load balancer ingress rules

What this PR does / why we need it
Towards https://github.com/giantswarm/giantswarm/issues/28705
In our templates we were always adding GiantSwarm VPN IPs when custom ingress rules were added. That worked fine for workload clusters, but we ran into a special corner case for our management clusters. The management cluster only needs the nat gateway IPs to be in the ingress rules, which is automatically added by CAPA, together with the GiantSwarm VPN IPs, which is automatically added by our cluster-aws chart. We don't have any more custom ingress rules to add. Without specifying any custom rule, the GiantSwarm VPN IPs were not added by the chart. But if we added the VPN IPs as custom ingress rules, AWS would complain due to duplicated cidrs on the security group.
So I tweaked the logic a bit. The end result from the user perspective is the same. But now we can specify the VPN IPs as values, and the chart will filter them out because they are duplicates, applying the right ingress rules. This only make sense on the special case of management clusters that should only be accessed by GiantSwarm.
Checklist

[X] Update changelog in CHANGELOG.md.

Trigger e2e tests
/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites


[Bug]: invalid content-type when generating a POST request with openapi generator

Package name
generator-sdk
Package version
Latest alpha
Reproduction steps
Generate an api library using the newly schematic ng generate sdk and use a spec yaml file that contains a POST request with consumes: -application/x-www-form-urlencoded
Launch the typescript services / models generation.
Current result
Observe that the typescript api will contain the following:
  const headers: { [key: string]: string | undefined } = {
    'Content-Type': metadata?.headerContentType || 'application/json',
    ...(metadataHeaderAccept ? {'Accept': metadataHeaderAccept} : {})
  };

Expected result
The part above should be:
  const headers: { [key: string]: string | undefined } = {
    'Content-Type': metadata?.headerContentType || 'application/x-www-form-urlencoded',
    ...(metadataHeaderAccept ? {'Accept': metadataHeaderAccept} : {})
  };

Additional comments
This is due to a regression in the api.mustache file when switching to the openapi generator.
We are using HeaderJsonMimeType custom lambda but giving an invalid input.

The internal SDK may need to be re-generated with the latest version of the generator including the support of the consumes headers.

[ ] regeneration of @dapi/amadeus-gateway-sdk based Otter 9.1+

Thanks @quentinderoubaix for your contribution.
We have included your fix in the version 9.1 of the  ama-sdk-schematics (sdk generator) package.


Istio is running wherever it feels like

Need to figure out how to make Istio listen to taints

This is good enough for now. I added an istio node label, but by default Istio will be placed on the workers. Init jobs still seem to run wherever they feel like. It's not a big deal though since they just run once and can be deleted after completion.


ResponseError comment is unclear

I created a PR to address this here https://github.com/awslabs/smithy-rs/pull/2304
Details in the PR description. The comment isn't incorrect, but it requires a specific interpretation to be correct.
It think the updated phrasing is clearer.

Looks like this was fixed a while ago.


Intellisense not working in WSL

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.2
OS Version: Windows 11 (WSL)

Steps to Reproduce:

Open WSL workspace in VS Code
Install node & npm using nvm
Create an index.ts file and import anything

Intellisense will not work for any of the imports. On Windows (outside of WSL) it works fine.
WSL:

Windows:

It also doesn't work when developing via Remote SSH extension.
It could be something on my end but I spent countless hours trying to fix this to no avail.
It starts TS server fine (screenshot of TypeScript output window), but it uses tsserver from the host and not WSL. Could that be a problem?

I try to force it to use WSL's tsserver by specifying path in workspace json settings:
"typescript.tsdk": "/home/marko/.nvm/versions/node/v20.18.0/lib/node_modules/typescript/lib"
But I get the following error despite the fact that the file exists at the given path:

Notice how the error message shows backslashes instead of forward slashes in the file path

Same issue here. No idea how to fix.

Are you using the wsl remote extension to open the workspace or directly opening the wsl folder through windows? It looks it could be the second case, which you almost almost never want. In the true wsl case, the typescript server will automatically run under the wsl linux environment too.
Can you try using the wsl extension to open the workspace instead?

So many things puzzle me. I see "initializing project... " and it works on startup but stops later. And the node VIRT memory usage seems outa of hand

Are you using the wsl remote extension to open the workspace or directly opening the wsl folder through windows? It looks it could be the second case, which you almost almost never want. In the true wsl case, the typescript server will automatically run under the wsl linux environment too.
Can you try using the wsl extension to open the workspace instead?

Yes, I'm using WSL extension to open the workspace and TS server seems to start but I still get no IntelliSense


Composer changes

Add composer.lock and remove composer.phar per this discussion: https://github.com/zfcampus/zf-apigility-skeleton/pull/92#issuecomment-109941631
(Moving the Vagrant addition to its own PR)

@samsonasik thanks for spotting the copy/paste issue with the github url in the readme.

:+1: the proper way.

:+1: for composer.lock..
Composer phar into the VCS was added for an old discussion and for help a speedy project startup..
I agree with you but this implementation has already discussed

@gianarb whats so speedy about it? Its outdated, you even have to run self-update before running it. This downloads a new phar, just like the updated description does. If any, this is faster, because the user won't have to download the outdated .phar at all :)

composer.phar is outdated is because this project has the problem of maintenance..
obviously it borns to be always updated

Then why does the README.md tells you to run "self-update"? Composer is very well maintained and updates to a propery release pretty often, so the self-update would download a new version very often. Honestly, I think the composer.phar in the project adds a little confusion for new users. Especially since it will show up as a change after the self-update.

Oh yes I agree with you composer.phar into the VCS creates confusion and is
a bad practice IMO :) I hope that this issue resolve
this misunderstanding..
But this argument is already discussed here
https://github.com/zendframework/ZendSkeletonApplication/issues/62
2015-06-09 10:22 GMT+02:00 Rob Quist<EMAIL_ADDRESS>
Then why does the README.md tells you to run "self-update"? Composer is
very well maintained and updates to a propery release pretty often, so the
self-update would download a new version very often. Honestly, I think the
composer.phar in the project adds a little confusion for new users.
Especially since it will show up as a change after the self-update.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/ZendSkeletonApplication/pull/286#issuecomment-110272778
.

--
Gianluca Arbezzano
www.gianarb.it

I'm +1 for removing composer.phar. It made sense back in 2012, but doesn't any more.
Ping @weierophinney for his thoughts as he had the last word on #62.

I discussed with @weierophinney and we both agree, we are going to remove composer.phar in the skeleton applications now and for the future. Having a correct README that shows how to install composer is the correct solution.

:+1: Beautiful!

@jeremiahsmall In the README, please put back the create-project method as this is the best way to install it. (Note, rebase from master first as I've just merged an improvement to the create-project command.)
Then remove the part about cloning manually and then running composer as there's no point in doing it this way given that we now expect the user have a composer installed.

@ezimuel have you discussed about the vendor this?
Maybe we can remove even this directory

I've updated the README to include the create-project as Option 1, however, I've also shown how to do the same without curl as Option 2, and I've added steps to copy your newly minted composer.phar into your project afterward. I've also included two additional options. Option 3 is the via curl and tar option that was already in the README, and Option 4 is manual git clone and non-curl composer installation.
For your reading convenience: https://github.com/jeremiahsmall/ZendSkeletonApplication/blob/hotfix/composer-changes/README.md
Frankly, installing composer.phar first outside the project and then using it for create-project seems a bit more cumbersome to me, because it then either gets abandoned in some arbitrary directory, and composer still has to be installed inside the project, or it has to be moved into the project (as I've suggestion in options 1 & 2).

I'm curious. Why do you think that composer has to be installed inside the project? It's perfectly happy living in /usr/local/bin.

@akrabat, it's not that it has to be installed in the project, or anywhere in particular for that matter.  I think it's out of scope for a README like this to try to explain best practices for how/where to install composer.
Based on that, and on the fact that we can't count on curl, I'm actually in favor of only showing the Option 4 recipe.

Merged after rebasing.

Thx. Small typo in the word "donload" on revised README.md

Also, still not clear why we put curl in the default instructions when there is another equally simple alternative with readfile.

Fixed Typo. I picked curl as that's the first option in the Composer documentation and was already in the README. One way as an example is enough with a link to the documentation. We don't document using Composer-Setup.exe either, or installation on an IBM i-series, so we don't need to cover all bases.


BUG: Footer in Dark mode

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
@PatilHarshh
check this out,
footer background not changed in dark mode

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Go Ahead !

Thank you


unable to initiate postgresql cluster with sudo pg_createcluster 9.5 main --start

Build: latest
Hi,
after updating to 16.04 LTS with do-release-upgrade -d and installing postgresql 9.5, the system fails to initiate a database cluster.
heres the feedback of the cluster init command:
root@WS1:/mnt/c/Windows/System32# sudo pg_createcluster 9.5 main --start
Creating new cluster 9.5/main ...
  config /etc/postgresql/9.5/main
  data   /var/lib/postgresql/9.5/main
  locale en_US.UTF-8
FATAL:  could not create shared memory segment: Function not implemented
DETAIL:  Failed system call was shmget(key=1, size=56, 03600).
child process exited with exit code 1
initdb: removing contents of data directory "/var/lib/postgresql/9.5/main"
Error: initdb failed
root@WS1:/mnt/c/Windows/System32#

FATAL:  could not create shared memory segment: Function not implemented
seems like not all common kernel-functions are implemented yet?

No.
https://msdn.microsoft.com/en-us/commandline/wsl/release_notes
If you have a fatal error coming from a program with the result "Function not implemented", it means that there's a missing syscall or socket mode or option or whatever.  I think for this, you should have searched for Postgresql in the issues page before opening up a new issue, since there is an open thread with lots of comments and information already:
https://github.com/Microsoft/BashOnWindows/issues/61
iirc the thing that's failing in this case is something involving sysVipc
(If you could close this topic and subscribe to the linked one, the devs would probably appreciate it)

this topic propvides some further info, thanks for the link...


[WIP] First full site version with menu enabled

and generated schedule from css data.

@thilo Menu styles and some other issues are fixed now. Can you review and merge if ok?


SbS guide for 1POS-1TSE

Step-by-step guide for one TSE per cash register.

Hi @fiscoal, looks good :) - can you please remove one of the images folder, and rename the images. One should use "-" as a separator, not "_". Also pls have a look to the foldername "1 - a-tse-per-cash-register". Pls remove the blank there after the "1" an d after the "-" .
Thx


Stash the Sensu SSL certs/keys]

TASK [cmacrae.sensu : Stash the Sensu SSL certs/keys] **************************
fatal: [ee-sensu.ee.ic.ac.uk]: FAILED! => {"failed": true, "msg": "failed to transfer file to /etc/ansible/data/dynamic/ee-sensu.ee.ic.ac.uk/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/cacert.pem:\n\n/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/cacert.pem: No such file or directory\n"}
dynamic_data_store: /etc/ansible/data/dynamic is defined in all.yml

Have you checked your dynamic data store to see if the data does exist?
No such file or directory would imply it doesn't

There is nothing in the dynamic data store.  The folders are created properly but no certificates.
on the andiuble host /etc/ansible/data/dynamic/ee-sensu.ee.ic.ac.uk/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/ is empty
On the sensu_master
[root@ee-sensu sensu_ssl_tool]# tree
.
├── client
│   ├── cert.pem
│   ├── keycert.p12
│   ├── key.pem
│   └── req.pem
├── sensu_ca
│   ├── cacert.cer
│   ├── cacert.pem
│   ├── certs
│   │   ├── 01.pem
│   │   └── 02.pem
│   ├── index.txt
│   ├── index.txt.attr
│   ├── index.txt.attr.old
│   ├── index.txt.old
│   ├── openssl.cnf
│   ├── private
│   │   └── cakey.pem
│   ├── serial
│   └── serial.old
├── server
│   ├── cert.pem
│   ├── keycert.p12
│   ├── key.pem
│   └── req.pem
└── ssl_certs.sh

oh I see am using ansible/data/dynamic instead of ansible/config/data/dynamic. I will change that and test!

👍🏻

Sorry it is the same problem cacert.pem is reported as missing.

after running with -vvvv
fatal: [ee-sensu.ee.ic.ac.uk]: FAILED! => {
"failed": true,
"msg": "failed to transfer file to /etc/ansible/config/data/dynamic/ee-sensu.ee.ic.ac.uk/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/cacert.pem:\n\nExecuting: program /usr/bin/ssh host ee-sensu.ee.ic.ac.uk, user (unspecified), command scp -v -t /etc/ansible/config/data/dynamic/ee-sensu.ee.ic.ac.uk/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/cacert.pem\nOpenSSH_6.6.1, OpenSSL 1.0.1e-fips 11 Feb 2013\r\ndebug1: Reading configuration data /etc/ssh/ssh_config\r\ndebug1: /etc/ssh/ssh_config line 56: Applying options for *\r\ndebug1: auto-mux: Trying existing master\r\ndebug2: fd 3 setting O_NONBLOCK\r\ndebug2: mux_client_hello_exchange: master version 4\r\ndebug3: mux_client_forwards: request forwardings: 0 local, 0 remote\r\ndebug3: mux_client_request_session: entering\r\ndebug3: mux_client_request_alive: entering\r\ndebug3: mux_client_request_alive: done pid = 61771\r\ndebug3: mux_client_request_session: session request sent\r\ndebug1: mux_client_request_session: master session id: 2\r\n/etc/sensu/ssl_generation/sensu_ssl_tool/sensu_ca/cacert.pem: No such file or directory\n"

cat all.yml
dynamic_data_store: /etc/ansible/config/data/dynamic
rabbitmq_host: ee-sensu.ee.ic.ac.uk
redis_host: ee-sensu.ee.ic.ac.uk
sensu_api_host: ee-sensu.ee.ic.ac.uk

It's failing specifically at server/key.pem. If I copy the files over manually it still fails at key.pem
There are some other files in the server folder.
-rw-r--r--. 1 root root 1.1K Dec 14 18:01 cert.pem
-rw-r--r--. 1 root root 2.3K Dec 14 18:01 keycert.p12
-rw-r--r--. 1 root root 1.7K Dec 14 18:01 key.pem
-rw-r--r--. 1 root root  907 Dec 14 18:01 req.pem

Switched ansible.cfg to use SFTP instead of SCP.
That works.


Internationalize local FAQ.

Because we don't set inner HTML in the app, links are shown as text, e.g. "Try Google (www.google.com)", <strong>'s were removed, and <p>'s were removed. <p>'s were taken out of the text, and instead coded into the faq.html template. I think it might also be good for the website to remove <p>s out of strings.
TODO: reconsider how to best keep this + website up to date

@lucyhe is there a way that, for the purpose of this page, we could have something in the ready function that goes through and handles internationalization based on data-i18n?  In that case, we could probably imagine having uproxy-faq be a npm (or bower) package we pull into both the website and the app.
If that's not feasible, :thumbsup:

Yay :+1:

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@jpevarnek done, thanks for the suggestion!


Removed closeMutex

Closes getlantern/lantern-pro#137

LGTM. I've been running Lantern without closeMutex for several hours and didn't see problem


There is no access to the processor voltage change registers

Hello!
Windows 11 blocks access to processor voltage change registers when the virtual machine subsystem or kernel isolation is enabled.
You can read more about the problem on the techpowerup forum.

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Be more consistent with CAMLparam

v_fileoff is a boxed value in 32bit systems, so it should be under CAMLparam.
While here fix the same thing in another couple of places and consistently use
v_fileoff when it refers to the Int63.t file_offset.

The old code is certainly inconsistent. But now I wonder if we need CAMLparam at all for most of these. I guess anything marked as [@@noalloc]  in uring.ml shouldn't need to be registering GC roots at all (https://blog.janestreet.com/faster-ocaml-to-c-calls/, https://v2.ocaml.org/manual/intfc.html#ss:c-direct-call).

That makes more sense tbh, none of them block so they can all be @@noalloc, in that case should i just zap every CAMLparam ?

in that case should we just zap every CAMLparam?

For all the noalloc ones, yes, I think so.

zefixed.
I also had forgotten to mush the .ml change for Uring.submit, should be fine now


Create Beer List

As a user,
when I visit the homepage,
I expect to see a list of beers

Add Mock Beer Data


chore: vendor Mitt into src/common/third-party

As discussed in #6203 we need to vendor our common dependencies in so
that when we ship an ESM build all imports point to file paths and do
not rely on Node resolution (e.g. a browser does not understand import mitt from 'mitt').

The standard pattern is to put it in a root folder under third-party or lib, and I think we should do that here rather than embedding it in the file structure. That way it is very clear that it has been vendored in without digging.

The standard pattern is to put it in a root folder under third-party or lib, and I think we should do that here rather than embedding it in the file structure. That way it is very clear that it has been vendored in without digging.

I normally would agree but I want to make it clear that we only vendor things in that are needed in all environments. E.g. we're not vendoring in any node-only dependencies.
WDYT?

I normally would agree but I want to make it clear that we only vendor things in that are needed in all environments. E.g. we're not vendoring in any node-only dependencies.

Could we achieve that by adding vendor/README.md stating as much?

I just realised it will complicate our setup much more if we have code outside of src - because we generate that directly into lib, but if code is outside of that structure the lib directory will change.
Therefore, how do people feel about having src/vendor, with a README as @mathiasbynens suggested explaining the setup?
We could have vendor at the top level, but it will mean a fair bit of tweaking of the build system that doesn't feel worth the effort, to be honest with you.
@mathiasbynens @paullewis LMK what you think

I'd be alright with src/vendor or src/third_party, possibly with a symlink to it at the actual root for extra discoverability. Paul, would that address your concerns?

We could have vendor at the top level, but it will mean a fair bit of tweaking of the build system that doesn't feel worth the effort, to be honest with you.

With vendor/third_party at the top-level + a symlink perhaps the build system wouldn't need any tweaks?

@mathiasbynens we ended up chatting it through and going for the top level vendor directory, which I do think is probably cleaner in the long run. We've had to do some tweaking of the configuration but actually it's probably a bit cleaner now, and has some more clear divides between all the various ways we use TS (docs, tests, source code).

Nice! I'm happy when Paul's happy. Thanks for resolving this 👍

(note: please change the commit message accordingly while squash+merging)


GCP Serving - Features required not used in model

After deploying model to GCP i found predictions required features 'company' and 'timely response' although these are not used in model. The other features below were also required but 'state' and 'zipcode' were not.
exampledict = {'product': 'Bank account or service', 'sub_product': 'Savings account', 'timely_response': 'No', 'company_response': 'Closed with monetary relief' ,'issue':'Cash advance','company':'test','consumer_complaint_narrative':'happy with the service' }
featuredict = {}
for key,value in exampledict.items():
featuredict[key]=tf.train.Feature(bytes_list=tf.train.BytesList(value=[value.encode('utf-8')])),
example = tf.train.Example(
features=tf.train.Features(feature=featuredict)
)
input_data_json = {
"signature_name":"serving_default",
"instances":[
{
"examples":{"b64": base64.b64encode(example.SerializeToString()).decode('utf-8')}
}
]
}
request = ml_resource.predict(name=model_path, body=input_data_json)
response = request.execute()
if "error" in response:
raise RuntimeError(response["error"])
for pred in response["predictions"]:
print(pred)
[0.123692594]

In addition to the above the following predicts locally using saved_model_cli (pg140) - replace the model number:
cli_input="examples=" + repr([example.SerializeToString()]).replace("'", """)
!saved_model_cli run --dir ./interactive-pipeline/serving_model_dir/1600007776/ \
--tag_set serve
--signature_def serving_default
--input_exprs='{cli_input}'

In addition to the above the following predicts locally using saved_model_cli (pg 140) - replace model number:
cli_input="examples=" + repr([example.SerializeToString()]).replace("'", "\"")
!saved_model_cli run --dir ../../interactive-pipeline/serving_model_dir/1600007776/ \
--tag_set serve \
--signature_def serving_default \
--input_exprs='{cli_input}'

Certain values, eg 'sub_product': 'Savings account', cause local prediction to fail but GCP works fine.
Difference seems to be those value Serialize to include a " character causing:
SyntaxError: unexpected character after line continuation character


Intel hotfix

@porteri If you're able to test this with the morfeus_fd branch of FAST on windows it would be much appreciated. This resolves the linking issues on Linux with Intel 18, but the codecvt issues from nodelocking is still present (working on that now) so FAST itself won't compile all the way (on Linux).
@rouson If you use this intel-hotfix branch with morfeus_fd on FAST you should be able to reproduce the test failures I was seeing. I've attached a log as a txt file.
failures.txt
To get FD stuff built that you need for testing you can run:
make -j <n> -k

inside build_fd/FAST after a normal build fails due to codecvt or whatever. -k tells make to keep going and build as much as you can.

@zbeekman this builds on Windows


SF: Send Key Biblical Terms to Serval as training data

See issue 13 here: https://docs.google.com/spreadsheets/d/13Y8d3z3JajAoR2B1zDbsjb0q_GLVQaB6iX9rZPM9it4/edit#gid=0

This was developed in SF-2258 and merged in sillsdev/web-xforge#2091.


homebrew installation command issue

Dear cargo-dist community,
Congratulations for this work, it is amazing!
 I have a cargo dist GitHub pipeline in which I added the Homebrew installer https://github.com/eth-cscs/manta/blob/main/Cargo.toml#L101 . I can see the .rb file with the brew formulae, the release Github page says:

Install prebuilt binaries via Homebrew
brew install manta

However I can't find the part of the Github pipeline which uploads the artifact to the brew repository, I have the impression the command to run would be brew install --build-from-source ...?
thank  you very much

hi @Masber - i used to be a middle school teacher ;) no stupid questions. so you have selected the homebrew installer, so it is getting built (the .rb file) BUT you haven't provided the config for a homebrew tap, and so you are correct that it's not there!
so i think there's a few questions i have to make sure i can point you in the right direction and also to make sure we are handling homebrew correctly
publish to a tap
many folks have a github repo that is considered a "tap" that allows you to have a brew install tap/formula install (this is what cargo-dist does!). to be honest, this is what i would recommend that you do (assuming i'm not missing important details of your particular situation, which i may be). to set this up- you'll need to create an empty repo on github, and then set this config to point to that repo:
tap = "axodotdev/homebrew-formulae"
publish-jobs = ["homebrew"]

it's worth noting here that you'll need to generate a github personal access token with "repo" access and set and action secret called HOMEBREW_TAP_TOKEN, so that we have push to publish to the repo.
this is explained in the docs here: https://opensource.axo.dev/cargo-dist/book/installers/homebrew.html
command if not publishing to a tap
i didn't know about the build from source flag for brew- i defer to our expert @mistydemeo on this. i suspect that you wouldn't want to suggest build from source, as the installer you just built points at pre-compiled binaries. i suspect that the command would be something closer to brew install file.rb but i'll have to do a little research to see what that would need to be!
if you don't want to publish to a tap i would be curious to learn why you don't! it seems to be to be a pure win, but i'm always interested in hearing other perspectives.


Broken Pypi link

Just to let you know, the homepage link on Pypi is broken. It points to: https://github.com/jetbridge/flask-cognito. Maybe you should also put a banner in the readme to point to Pypi?
Keep up the good work, cheers!

Thanks! just uploaded a fix

On Feb 17, 2019, at 11:06 PM, Émile Fugulin<EMAIL_ADDRESS>wrote:
Just to let you know, the homepage link on Pypi is broken. It points to: https://github.com/jetbridge/flask-cognito. Maybe you should also put a banner in the readme to point to Pypi?
Keep up the good work, cheers!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/jetbridge/flask_cognito/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO9i4YOy9NU_DZZrFa70q905FPi0QjMks5vOcQ-gaJpZM4a_yp8.

Maybe also change the URL in the setup.py?

Just pushed the changes

On Feb 17, 2019, at 11:41 PM, Émile Fugulin<EMAIL_ADDRESS>wrote:
Maybe also change the URL in the setup.py?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/jetbridge/flask_cognito/issues/2#issuecomment-464513350, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO9izvcOWT3WWrUhZ_O2LobvtFzna3vks5vOcyBgaJpZM4a_yp8.

Thanks!


Add Nagios checks to alert us, instead of root mail

Currently: Updates are applied nightly. We get notified via root mail when something goes wrong applying updates.
Aha! Link: https://penn-state-university-libraries.aha.io/features/MDDB-9

This isn't something that's currently visible to the DSRD team, but it was done long ago.


[fixed] remove portal context in timeout

Fixes #344, fixes #348.
Changes proposed:

Fixes the binding of the removePortal call in the setTimeout callback
by capturing a this reference in a variable in the closure scope.
Doesn't use bind which apparently causes warnings.

Upgrade Path (for changed or removed APIs):
n/a
Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[ ] Documentation (README.md) and examples have been updated as needed.
[ ] If this is a code change, a spec testing the functionality has been added.
[ ] If the commit message has [changed] or [removed], there is an upgrade path above.

@claydiffrient Thanks for merging. Do you intend to release 1.7.x patch version? We are broken in the wild currently.

v1.7.3 has now been released @adjohnson916 :)

@claydiffrient Thanks, I see v1.7.3 on npm, but don't see a tag for it here on GitHub.

Sorry about that @adjohnson916 I guess something was messed up with the release script last time and the tag didn't get pushed.  I just pushed it up though :)


Purge unused strings

How about a command for purging unused strings in lang files?
There is a potential problem with trans('app.type_' . $type) kind of translations, as the user will create custom entries in the files... but, still, I think that a command like this would be useful.
Maybe all the custom strings could be placed in files that could be blacklisted from purging at config level.
@themsaid, have you thought about a feature like this?

Regarding the command for purging strings, I'm not quite sure if we can consider all the cases to check for an unused translation line, do you have any ideas on how to guarantee?

Not sure either, but thinking on my workflow:
Hypothetically I would blacklist on config/langman.php files like resources/lang/en/status.php where things like ticket_open should be. This kind of translations are the ones that I use with trans('status.ticket_' . $status). In this files we should never assume that a string is not longer used (because we don't know) and live with it.
With the rest of the files, I would simply search all the translations that do not have an entry on Manager::collectFromFiles result and remove them, maybe with a preview and a prompt.
If on your project you're unable to separate translation keys like the ones on the "status" example from the normal keys, well, maybe you are not a candidate for a "purge" command, and you should continue using the rest of the commands as usually.
Too drastical? Are you thinking on more scenarios?

Well I assume such command can be useful if you know what you're doing :) If you can PR such thing I'd gladly consider merging.

Perfect! I think I could have something by the next week for you to review.

👍 :)

Have you guys been able to add this? I haven't installed langman yet, but i was indeed looking for the feature to purge unused strings.
Isn't it something like:

'fake' remove all keys keep them in a map,
2 run the find missing translation keys function keep that in a map,
remove all found in 2 from 1 > resulting in a list of unused keys to remove?

(probably what joelcuevas is referring to, and indeed variable ones are harder anyway, the would not pop up in step 2 then anyways)
If there isn't another package that has this, and you are not continuing on this, i might take a shot at it?

#100 implements a --unused flag for the Show command that can give you a list of all keys that are not actively found in your project files. You can use the Remove command to remove those keys.
You can then script this to filter the list of unused keys with a known list of keys to retain anyway and remove the rest.


Change the app name Boost to Boostnote

Hi, developers! Our team has changed the app name Boost to Boostnote. And also changed its logo. So I'd like to change the content in https://electron.atom.io/apps.

Looks good. Thanks.


Cache images

or put them behind a CDN. The page loads will feel much better.

I think it's good on load. Maybe implement a placeholder for banner images.


[ISSUE #3890] add 'brokerAddress' param for ConsumerConnectionSubCommand

To solve the problem described in ISSUE #3890
By the way, optimize ConsumerStatusSubCommand also.

Codecov Report

Merging #3891 (b369a99) into develop (9f9b109) will increase coverage by 0.08%.
The diff coverage is 61.53%.

@@              Coverage Diff              @@
##             develop    #3891      +/-   ##
=============================================
+ Coverage      47.37%   47.45%   +0.08%
+ Complexity      5044     4922     -122
=============================================
  Files            627      633       +6
  Lines          41348    42517    +1169
  Branches        5372     5582     +210
=============================================
+ Hits           19588    20177     +589
- Misses         19332    19832     +500
- Partials        2428     2508      +80

Impacted Files
Coverage Δ

...messaging/rocketmq/consumer/LocalMessageCache.java
37.50% <0.00%> (-1.21%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
50.35% <50.00%> (+5.94%)
:arrow_up:

...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java
39.83% <50.00%> (+0.04%)
:arrow_up:

...mmand/connection/ConsumerConnectionSubCommand.java
74.41% <83.33%> (+1.91%)
:arrow_up:

...ols/command/consumer/ConsumerStatusSubCommand.java
38.88% <83.33%> (+3.06%)
:arrow_up:

...pl/consumer/ConsumeMessageConcurrentlyService.java
48.35% <100.00%> (+0.29%)
:arrow_up:

...apache/rocketmq/tools/admin/DefaultMQAdminExt.java
41.40% <100.00%> (+0.46%)
:arrow_up:

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-8.70%)
:arrow_down:

... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9b109...b369a99. Read the comment docs.

Coverage increased (+0.01%) to 51.565% when pulling b369a991e2ca0e732335050aaa75148022143ff8 on MatrixHB:optimize_command into b606d9c638c2b9bf018d9a9968fdc9e5d6acf07f on apache:develop.

Coverage increased (+0.01%) to 51.565% when pulling b369a991e2ca0e732335050aaa75148022143ff8 on MatrixHB:optimize_command into b606d9c638c2b9bf018d9a9968fdc9e5d6acf07f on apache:develop.

is another commit to optimize the clearExpireMsg logic? it's better to create a new PR for it.

is another commit to optimize the clearExpireMsg logic? it's better to create a new PR for it.

I've rollback it.


policy: include L3-only policy in L4Filter

This allows for all policy at L3 to be stored in a single construct, and means that all resolved policy is now specified in terms of selectors.
Resolution to identities is now done in the translation to PolicyMap keys and in the xDS layer, apart from when requirements are analyzed. Because L3-only policy is computed as part of L4Filter, and we still need to calculate the sets of denied identities for xDS policy, we only need to calculate whether requirements deny specific identities now in ResolvePolicy. Do just that, and factor out the code which calculates requirements, as well as analysis of ToEndpoints and FromEndpoints into separate functions to be reused elsewhere, specifically the policy tracing logic.
This allows us to potentially change how tracing works, since we store computed policy in the L4Filter for L3 as well now, but I've kept it the same for now to reduce the amount of changes in a single PR.

This change is

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Coverage increased (+0.08%) to 42.659% when pulling 92b20f2870b4f840d5ad7c814dcf0a56c4094aa2 on pr/ianvernon/consolidate-l3 into 720316a724bfa8c4ed99584db446dc33911bf037 on master.

Build failure: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/11288/
Looks suspicious. Investigating.

test-me-please

test-me-please

@joestringer I've addressed your feedback all as follow-up commits, please review again.

test-me-please

test-me-please

@joestringer addressed all of your comments, please review again

FQDN restart test failed: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/11398/testReport/junit/k8s-1/14/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

test-me-please

test-me-please

Merging; this has been out for review for some time and the added functionality into files owned by ci / api codeowners is minimal.


Copy evaluation result in more formats

e.g. CSV, TSV

Export (save as file directly)

Duplication of https://github.com/nk2028/tshet-uinh-autoderiver/issues/54


[no ticket] Small documentation & GKE updates

The alternative git commands allow the repos to be pulled without entering a GitHub password. This worked much better for me – happy to revert if there's a preferred way for me to be setting up my GitHub creds.

I think this way requires a SSH key set up on your github account. I assume you have that, but this broke mine.
https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/adding-a-new-ssh-key-to-your-github-account


baggit, foregleam

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,f]

/trunk merge


Variant Annotation re-merge

This PR re-merges the Variant Annotation API first discussed in #302, now with additional documentation, a reference server implementation and compliance tests.
Major new developments have been avoided. The differences are:

removal of all graph-related functionality
rename AnnotationSet to VariantAnnotationSet for clarity
a VariantAnnotationSet is now derived from a specific VariantSet, rather than a Dataset
AlleleLocation overlapEnd can be null
SearchVariantAnnotationsRequest feature_ids key renamed to featureIds to match the standard
avro corrections - addition of missing null values

+1  this longs sane and a good step forwards within the restrictions of the current variant schema.

Thanks for the detailed review @jeromekelleher! I've responded to the individual comments and created a few PR with the suggested changes. I'll merge these shortly unless there are further comments.

Thanks for the updates and comments @sarahhunt, these were very helpful. I think this API makes a lot of sense, and hopefully we can get some wider input on it so that it can be merged into master soon.
@dglazer, @calbach, have you any thoughts on this?

@jeromekelleher - thanks for the further comments. I've had a second pass through this and merged the updates into branch so it is cleaner for others to review.

+1 This looks good to me. I just made a PR to the variant_annotation branch updating documentation by adding the schema diagram.

This looks reasonable to me. I added a few minor comments inline.

+1 time to merge?

I'm +1 also. The server implementation requirements have been met, so the schemas have been proved to be implementable. @david4096, can you comment on the compliance tests please?
One minor query that I have is about ISO formats for times. We should commit to a complete changeover to ISO format for times in the API before we release the next version (it would be confusing to have a mixture, where variation annotation part uses ISO 8601 and the rest uses unix time). Is there a plan to make this conversion with server and compliance tests implementations?

Yes, we are planning to do a separate PR to convert the other
times and make the field names consistent.
Jerome Kelleher<EMAIL_ADDRESS>writes:

I'm +1 also. The server implementation requirements have been met, so the
schemas have been proved to be implementable. @david4096, can you comment on
the compliance tests please?
One minor query that I have is about ISO formats for times. We should commit to
a complete changeover to ISO format for times in the API before we release the
next version (it would be confusing to have a mixture, where variation
annotation part uses ISO 8601 and the rest uses unix time). Is there a plan to
make this conversion with server and compliance tests implementations?
—
Reply to this email directly or view it on GitHub.*

Yes, we are planning to do a separate PR to convert the other times and make the field names consistent.

Great. Definitely +1 on this PR then!

@jeromekelleher Compliance branch is also ready to be merged (thx @sarahhunt !).
https://github.com/ga4gh/compliance/pull/141

+1  lets move forward on this

+1

@jeromekelleher this has more than enough +1s, do you want to do the merger?

@calbach, have you any thoughts here?

@calbach, as one of the people who reviewed this it would be good to get your final opinion on it before we merge. However, the clock is ticking, and I think we should merge this quickly.


Support custom client SSL contexts.

My use-case is setting up client-side certificates for TCP connections. I haven't bothered to look at the tests to see if I should add anything there yet.

src/aleph/netty.clj (check-ssl-args): new function.
(ssl-client-context): add docstring, optional kwargs. Set up private key, certificate chain if requested.
src/aleph/tcp.clj (client): add ssl-context argument.

Thanks, much appreciated.

Just a heads up: I've changed the keyword args to ssl-client-context to a single options map, since that's more consistent with the rest of Aleph.


[Cantina-L-01]: _validateRefinance() updates

In the refinancing flow, the following checks have been added to validate the new loan terms:

(L-01) Check that the payable currency used in the new loan terms is still whitelisted, as it could have been removed from the whitelist while the loan was active. Test added.
(L-01) Check that the collateral address used in the new loan terms is still whitelisted, as it could have been removed from the whitelist while the loan was active. Test added.
Test added showing that a loan cannot be refinanced if the current loan's interest rate is the minimum allowable interest rate.

This check is already present in OriginationController:: rolloverLoan() here.
One change I did make after re-looking at this logic, was to create a helper function to check the whitelist status of both the payable currency and the collateral at the same time so only one external call needs to be made by RefinanceController:: _validateRefinance(). While making this change, I noticed getMinPrincipal() also checks the whitelist status of the payable currency so I decided to combine this functionality in the new validateWhitelist() method. This will save a SLOAD of the allowed principal mapping. Due to combining these two methods, I was able to remove the getMinPrincipal() if statement from RefinanceController:: _validateRefinance() also saving another external call.


Headers in list items do not render AT ALL

Testing
this should work

Testing Again

When there is content indented between list items, headers should render properly, but redcarpet does not follow this pattern at all. The above is an example of this usage. The example below is what redcarpet does:

As you can see it not only does not render the list properly it also does not parse headers. I am currently facing this issue and was wondering if there is something I could down now perhaps a custom cooked plugin for redcarpet that deals with this?

I have found the issue, it requires 4 spaces, instead of the common 2 or 3 to avoid issues with code blocks.

Alright, so it halfway works:
If someone can spot what I am doing wrong that would be great:

Setting :disable_indented_code_block to true does not fix the issue.

setting disable_indented_code_block to true fixes the issue.

This doesn't work at all with:
- A

  Some text here

- B

  Some more text here


Title adjustment on BGV credential

Title in credential bleeds over on mobile page

@alexfigtree - I think we should up the priority on this.Below are sceenshots of another credential where the title goes offscreen.

Ok, changing priority to Priority and moving to To Do.

Keeping open until after deployment

Deployed to both Google Play and App Store (release 2.1.0-build80), closing ticket.

Confirming that this still works on Build 82

Completed, moving to Done.


Added a local font for offline usage

Closing #53
The Problem
Trying to run r3f-perf in an offline environment or an organization reserved internet connection (that blocks access to third-party URLs or CDNs) will bring errors to the console and completely hide the stats of r3f-perf, like the image below:

The Solution
I downloaded and optimized the Roboto font from Google Fonts. I added it to the src directory and imported it directly in TextsHighHZ.tsx.
The result, while offline:

It worked just fine in the dev environment and got built just fine.
Additional Size
The font initially weighted 164.69 KB. After using Font Squirrel, the size down to around ~26 KB

@RenaudRohlinger, I am open for editing this PR, if nessasery.

If I remember correctly there is an online tool to cherry pick the characters we want to use. For example we could re-generate the Roboto font with only<PHONE_NUMBER> instead, it would go down to 1kb I guess.

If I remember correctly there is an online tool to cherry pick the characters we want to use. For example we could re-generate the Roboto font with only<PHONE_NUMBER> instead, it would go down to 1kb I guess.

I will see my options and update this PR.
Thanks for your comment ❤

Hi @RenaudRohlinger,
I did my best to reduce it, and this was the best version at 11.66 KB. This has the subset of the numbers only and all others, like uppercase/lowercase/special/...etc characters, will be generated from the system's default font.
I couldn't make it lighter. Have you seen one before that I can test out? I used https://transfonter.org/

Thanks!


Add TP_RunLength to GenerateTrials

Pull Request instructions:

Please follow the update protocol
Answer the questions below in detail. Your responses will be emailed to experimenters.
If the experimenters must do anything new, provide detailed step by step instructions on the wiki
If computer maintainers need to manually update anything, provide detailed step by step instructions
Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
If you use the keyword "skip email" in the title, it will skip the email updates
Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

Add variable TP_RunLength to GenerateTrials

What issues or discussions does this update address?

resolves #857

Describe the expected change in behavior from the perspective of the experimenter

None

Describe any manual update steps for task computers

None

Was this update tested in 446/447?

[ ] 446/7

@micahwoodard Can you merge this into production_testing?

@alexpiet tested on rig and appears to be working