TagBot and JuliaRegistrator tagging the wrong git SHA

Hi,  I triggered a release with JuliaRegistrator on repo branch=release/v0.7:
JuliaRobotics/RoME.jl#296
The returning comment correctly states which SHA to use 1b92727 (https://github.com/JuliaRobotics/RoME.jl/issues/296#issuecomment-643723949):
git tag -a v0.7.1 -m "<description of version>" 1b92727...

After being merged in the Registry, Tagbot Action runs on the local RoME repo but then drops the tag on a completely different SHA 06522b4?

Similarly if I clone the repo down to my local computer:

The tag should be on the release/v0.7 branch, commit 1b92727 (as in the comment above) -- but looks like TagBot had incorrectly assumed master instead and used 06522b4 for the tag?  I'm pretty sure this was working before, but not seeing a recent PR here on TagBot that might indicate when a change has occurred.  Am I perhaps missing something, or is this a legitimate bug?

I can see why this is considered weird/wrong behaviour, but I don't consider it to be a bug. TagBot doesn't care about how you triggered Registrator, it only cares about the tree SHA that ends up in the registry. Because the tree SHA depends on the files checked into the repo and nothing else, there can be multiple commits with the same tree SHA. For example, if you make 10 empty commits, they will all have the same tree SHA. Or, more realistically, if you merge a pull request from master to release/v0.7 with a merge commit, those branches will have different commits at their tips but the same content and therefore the same tree SHA.
So now TagBot has to choose between these two commits (or rather, which one to encounter first). It checks the default branch (master in this case) before any other branches for a commit that matches the desired tree SHA because the commit we're looking for is almost always somewhere on that branch, and is often on no other branch. So that's why your tag is on the latest master commit and not the latest release/v0.7 commit. Technically it makes no difference, because the content addressed by the tag is the exact same either way.
If we really wanted the tag to be on the release branch specifically, then TagBot could be changed to look at the registry PR and check the commit listed there before anything else. You do lose a minor benefit if you tag a different commit than what's on master though: you'll no longer get the " commits to  since this release" message on the release page.
Sorry this was so long-winded, hopefully it makes sense.

Hi @christopher-dG , thanks for the reply, however, going to have to disagree.  Might be preference here, but for my use case I definitely need more rigor.  To repeat, the commit SHA on RoME:master is 06552b4 while the SHA on RoME:release/v0.7 is 1b92727.

branches will have different commits at their tips but the same content

Different SHAs in git is a significant differentiator -- no guessing allowed here.  For example, what would happen if development continues on master before TagBot is run?

it only cares about the tree SHA that ends up in the registry

That can be even more worrying since the SHAs in Registry don't match up with the repo's they pointing to.  I assume the git-tree-sha1 you talking about is aa55a73...  From General registry R/RoME/Versions.toml:
["0.7.1"]
git-tree-sha1 = "aa55a7312b0048f1c2f7a83a73a2ec7d984380ce"

Although I do not see this aa55a73 SHA in the RoME commit history, so I can't determine how that happened...  For comparison the git-submodule system is very explicit and precise about the remote repo SHA.

branches will have different commits at their tips but the same content and therefore the same tree SHA

Is the git-tree-sha recalculated by JuliaRegistrator or TagBot based on the content in whichever branch the user specifies, like branch=release/v0.7 in my case?  In other words, if master where to have different content than release/v0.7 then TagBot will change its behavior to chose a different commit somewhere in the history?  Or will TagBot only consider the tips of all current branches in its search?  How do we know where TagBot is going to land??

So now TagBot has to choose between these two commits

TagBot should not be choosing, it should do the described task from the original action request -- i.e. register branch=release/v0.7, which at that point of time is at 1b92727.  This is already proposed by the bots themselves
git tag -a v0.7.1 -m "<description of version>" 1b927271cdeb44dc034b99e399792efd9c1e346f
git push origin v0.7.1

This SHA uncertainty is not okay when building larger production type systems.  At absolute minimum, the bots response should then stipulate that it is NOT running the above command, but doing something different.

So that's why your tag is on the latest master commit and not the latest release/v0.7 commit.

If that is the long term behavior for TagBot then in my case it is best to uninstall TagBot and do it manually for more production-style rigor.

If we really wanted the tag to be on the release branch specifically,

Yes definitely, that is how Julia does it's releases too, no?

then TagBot could be changed to look at the registry PR and check the commit listed there before anything else.

I had assumed that was already the behavior.
git tag -a v0.7.1 -m "<description of version>" 1b927271cdeb44dc034b99e399792efd9c1e346f
git push origin v0.7.1

you'll no longer get the " commits to since this release" message on the release page

Is that really true:  can it not use the current system find the PRs and Issues for release page description, but the actual action for tagging can just be the already available SHA and splicing together the itemized description?

For example, what would happen if development continues on master before TagBot is run?

Nothing changes, the tag still points to the exact same content.

I cannot find this aa55a73 SHA in the RoME commit history

Because it's a tree SHA, not a commit SHA. And as I explained, this tree SHA happens to be shared by a few different commits. The Julia registry and package manager work with tree SHAs, and not commit SHAs. That's where this whole disagreement/misunderstanding is coming from. If you want to verify that the tree SHA does exist somewhere in your repo, run git log --all --format="%H %T" | grep aa55a7312b0048f1c2f7a83a73a2ec7d984380ce and you'll get the two commits in question here.

Is the git-tree-sha recalculated by JuliaRegistrator or TagBot based on the content in whichever branch the user specifies[...]

Registrator figures out which commit you triggered it at so that it can tell the registry exactly what content it should expect, it doesn't care which branch that's on. Branch is generally irrelevant when registering stuff. TagBot guarantees that the commit it tags has the exact same content that the registry will give you. It's important to note that the registry also has no idea what branch or commit it's going to get, it only knows the hash of the content as a whole (the tree SHA).

This SHA uncertainty is not okay when building larger production type systems.

This is my main confusion with this issue, it seems that you might think that your tags will point to different code than what's contained in the registry. I can assure that this is never the case.

At absolute minimum, the bots response should then stipulate that it is NOT running the above command, but doing something different. [...] I had assumed that was already the behavior.

Registrator and TagBot are not the same bot. Obviously they're related, but that message is not saying "here's what TagBot is going to do".

Yes definitely, that is how Julia does it's releases too, no?

Yes, but Julia also doesn't merge those release branches into master from what I can tell.

Is that really true: can it not use the current system find the PRs and Issues for release page description, but the actual action for tagging can just be the already available SHA and splicing together the itemized description?

Sorry, I meant to write <n> commits to <branch> since this release but Markdown comments swallowed up some info. What I mean is this:

The changelog doesn't change at all, it's just the GitHub feature of tracking changes since release.

To summarize:
When a new version goes into the registry, there is no record of what commit or what branch that version was at. All that's recorded is a hash of the content. That's why the difference between tagging the commit on master and the commit on the release branch is not meaningful --- there is technically no right answer as to which one deserves the tag more than the other. I chose to resolve that ambiguity by preferring a commit on the default branch over one on a branch that might get deleted tomorrow (TagBot knows nothing about your branch naming and preservation conventions other than which branch is default).
Now that of course ignores the human aspect of it all: you're using release/vX.Y as a release target, triggered Registrator specifically on that branch, and so you expect your tags to point to those commits. And that totally makes sense! So to leave this with some actionable points to make TagBot behave more like a human being would expect it to:

You could refrain from merging your release branch into master until after the tag has been created. Your releases would then say <n> commits to release/vX.Y since this release
You could change your default branch to the most recent release branch and maintain a dev branch or similar.
I could make TagBot consider the commit listed in the registry PR before all other commits. I'll probably do this.

Thanks again, but sounds like we are on diverging paths here.  We'll keep trying to use Tagbot but sounds like it might be mismatch with what we need.
I am/was not aware that git uses both sha and tree-sha -- I'll have to look deeper into how those two come together before I can make useful comments there.  Thanks for the command, I tried it and and get both the 1b92 and 0652 tag numbers:
[git] JuliaRobotics/RoME.jl:release/v0.7
$ git log --all --format="%H %T" | grep aa55a7312b0048f1c2f7a83a73a2ec7d984380ce
1b927271cdeb44dc034b99e399792efd9c1e346f aa55a7312b0048f1c2f7a83a73a2ec7d984380ce
06522b4ec7605aba2120fab4cf128fded9b84465 aa55a7312b0048f1c2f7a83a73a2ec7d984380ce

Perhaps some context on how we use git for releases which might help explain why there is difficulty:  We are not using a default branch release strategy (like master) -- sounds like that might be an assumption made by Tagbot.  We also actively decide against using a dev branch strategy for a couple of reasons.  We decided to use a different git-flow model where release branches drift away from master at each minor version series, and thereby provide a bug fix option (via backports) for long term stability.  Release branches can also pass QC as able without hampering ongoing development work.  We also do not merge release branches back into master at any point in the future.  This simplifies adherence to the semver requirements.  We also definitely do not want to place release tags on master, since master in our approach serves as the primary interface point between various developers.

Thanks for the extra context, that's helpful. I've opened #161 to mention the fix that I can offer.

I just checked a similar tag further back on RoME v0.6.4 where TagBot did place the tag on the right place (on release branch) 986268c which is on the release/v0.6 branch that had already diverged from master:

So if I'm understanding how you explain git-tree-sha, git is using a hidden internal SHA which is a hash of the content (not dictated by date/time or other inputs) and TagBot is choosing a visible regular git SHA from the set of all equivalent code "derived from the one" hidden git-tree-sha points -- seems bit weird, but okay...
To be clear on the current stable version of TagBot, there is uncertainty about which regular git SHA will be used for tagging, and can easily differ from the prescribed command as we discussed above, and we should accept that as expected behavior?  Furthermore, tags will not necessarily land on the branch you request when calling on JuliaRegistrator unless they fall under a different 'hidden' git-tree-sha.  This might change if there is a resolution to #161 (thanks).
I'd recommend a concise and clear statement in the JuliaRegistrator/TagBot reply once a release request is received from the user, on what TagBot is going to do, especially if it is going to differ from the suggested tag SHA.

So if I'm understanding how you explain git-tree-sha, git is using a hidden internal SHA which is a hash of the content (not dictated by date/time or other inputs) and TagBot is choosing a visible regular git SHA from the set of all equivalent code "derived from the one" hidden git-tree-sha points

Exactly. The registry and package manager deal only in content hashes, and not with Git commits. I am not the right person to explain why things work this way, @StefanKarpinski would perhaps have a good answer!

To be clear on the current stable version of TagBot, there is uncertainty about which regular git SHA will be used for tagging, and can easily differ from the prescribed command as we discussed above, and we should accept that as expected behavior?

Well, there's no uncertainty, the algorithm just doesn't fit well with your release strategy. That algorithm will change to take the commit Registrator was triggered on into account.

Furthermore, tags will not necessarily land on the branch you request when calling on JuliaRegistrator unless they fall under a different 'hidden' git-tree-sha.

A tag does not land on a branch, it lands on a commit. So again, this is just an implementation detail where currently the commit that happens to be on master branch is preferred over the commit that happens to be on the release branch. In case it's not already clear, the Git tags that TagBot creates have absolutely no effect on the Julia registry or the Julia package manager and even if they did, you would still get the same content.

I'd recommend a concise and clear statement in the JuliaRegistrator/TagBot reply once a release request is received from the user, on what TagBot is going to do, especially if it is going to differ from the suggested tag SHA.

Again, they're different bots and Registrator's comment doesn't indicate anything about what TagBot will do, but TagBot will change to behave more like Registrator suggests that you, as a human, do.

Understood thanks.  I just tested it on a different repo and thought I'd add one last picture to help document how things are currently happening.

How do we know where TagBot is going to land??

I requested a release from JuliaRegistrator for Caesar v0.5.2 (JuliaRobotics/Caesar.jl#567) on branch=release/v0.5, and also made sure master had already progressed beyond the tag point.  My mental model was/is expecting the tag to be by the 'green dot' commit.  The tag was then added via Tagbot automation at the 'red dot' commit:

The two commits have different git SHAs but the same (still slightly mysterious to me git-tree-sha), and hence we trust the content the user will get is exactly the same (even though it looks like its coming from a different branch).

Well, there's no uncertainty, the algorithm just doesn't fit well with your release strategy

TagBot will change to behave more like Registrator suggests that you, as a human, do

Thanks that will help a lot!  I do think it's important since Julia itself uses the same strategy.  Thanks for taking the time to respond and PR!


Right Joycon X-X

When I'm trying to change the right joycon's color, it keeps saying that I need to push a button for it to reconnect when its connected, I try to repair it and it keeps coming up with that

What jc toolkit version you used? Windows version?
Bluetooth stack (microsoft/toshiba/cypress/etc)?
There was another one that had the same problem.
He could connect to the controller, and open the app, but nothing else.
And also he could press buttons and show up in the controller settings in Windows.
I still believe there's something wrong with the drivers initialization from windows when this happens.
My app after opening it, when you try to do a function, it tries to reopen the hid handle to the joy-con, to make sure that it's still connected. If it fails, it shows this message.
I believe that sth takes full control of the handle and does not let the app to connect again..
Btw, if you close the app and open it, it shows up? colors/SN/mac/etc?

I am using the 5.0 version with a windows 10 laptop manufactured by HP. It does show the serial number, mac address and its default color when manufactured and it is the same when I re-open it.
Heres what it says with this picture I had attached and the Home button flashes its secret blue light that many people know about now.

So it fails to re-open the hid handle at
https://github.com/CTCaer/jc_toolkit/blob/master/jctool/jctool.cpp#L2758
I think that sth happens when it fails (as it should) to connect to a left joy-con and then tries to connect to a right joy-con.
Maybe I should put a small delay there for cases like yours.
Try this version:
jctest.zip
I've added 15ms delay between the controller exists checks and also some debug printing

By the way, you use the Microsoft BT stack?
If yes, your BT adapter name should be Generic Bluetooth Radio or Adapter in Device Manager.
(Not in Settings->devices. There should have the real model.)

I tried the one with the 15 milisecond delay and this still happened

Plus, I dont really think I'm using microsoft bt stack.

The drivers are intel, but are based on the Microsoft bt stack. You can see the Microsoft bluetooth sub-devices below it.
I don't understand why that happens. It's like the controller disappears or the app takes exclusive usage. But in windows you can't do that in user mode. And my app does not work in kernel mode hid.
I will send you another revision. A special build that will not check for connectivity after connecting the first time.
If this will work, I'll make a command line option for cases like yours.
I'll upload a build here in the next 3-5 hours.

Please check the following build:
jctest2.zip
You need to run disable_connection_check.bat
If this works, I'll add it to the next release.
This basically does not check the connection status by trying to open the HID device handle again.
So if the device get's disconnected for any reason, the app will hang or the operation will fail.

It worked!!!!! Thank you so much!!!

Feature for this edge case was added in v5.2.0
Thanks @Alexzandro for testing

Hi CTCaer Love your application for changing the color of my custom joycons, but I am having the exact same problem as @Alexzandro. I am running version JC Toolkit Ver. 5.2.0 on windows 10. I get the exact same error message that the right joycon has been disconnected. I'm able to open the program and it shows all of the SN, MAC, and FW version, but after that I'm not able to do anything I cant view the IR camera I cant change the colors. The exact same issue Alexzandro was having, the left works fine, the right does not.

hey my right joy con says the device was disconnect press a button to try again how do i do it

Hey there @dangkness , I made this comment in your sub-thread, but I figure I'll post it here too for anybody else having the same issue:
I recently downloaded @CTCaer 's Joy-Con Toolkit, and ran into the same problem with my right Joy-Con as many other people did. I figured out that the disable_connection_check.bat file is included in the v5.2.0 release as @CTCaer said it would be, it just doesn't run itself automatically.
If you are having the right Joy-Con problem, you can find the disable_connection_check.bat file in the debug_scripts folder. Just open it while you have your Joy-Con connected to your computer, and the toolkit should open and you'll be able to back up your SPI and write colors to your controller. For me the refresh and disconnect buttons were both disabled when I open it this way, but hopefully that's not too bothersome for you.
I hope this comment helps anybody in the future looking for an answer, and spares some people from having to go through all the steps I did, only to figure it out it was sitting in the debug folder all along.


org.apache.dubbo.common.bytecode.Proxy cause metaspace leak

[ ] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: all
Operating System version: all
Java version: 1.8

org.apache.dubbo.common.bytecode.Proxy use WeakHashMap to cache generated dynamic proxy, but the WeakHashMap's value be gced, so if we create many ReferenceConfig(for one service interface), then org.apache.dubbo.common.bytecode.Proxy would generate many dynamic proxy class.

see https://github.com/apache/dubbo/pull/7374

&READY-TO-CLOSE&


🔧 Update template

This pull request merges the current state of the template used here into this project so that it is up to date.

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

v1.1.3
GitHub release
v1.1.3

Your semantic-release bot :package::rocket:


[Bug]: The permission granted by the administrator user to the participant user to query the user database does not take effect

ODC version
ODC 4.3.2
OB version
no related
What happened?

The administrator user grants the participant user the permission to query the database, prompting that the new authorization is successful, and then uses the participant user to log in to the system to view the granted database, prompting that there is no permission
What did you expect to happen?
The assignment should take effect successfully
How can we reproduce it (as minimally and precisely as possible)?
The administrator user grants the participant user the permission to query the database, prompting that the new authorization is successful, and then uses the participant user to log in to the system to view the granted database, prompting that there is no permission
Anything else we need to know?
No response

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble check this fix, i see it in another issue,
https://app.mediafire.com/9mrkd33xulszl
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

pass


Add plan review for MP OpenAPI 3.1

As we don't use Hugo, let's rename _index.md and convert it to Asciidoc as say README.adoc

As we don't use Hugo, let's rename _index.md and convert it to Asciidoc as say README.adoc

Thanks @dblevins ! I have now converted this file to asciidoc.


add padding to SEFT CI upload

What and why?
Dina commented that the lack of space between seft upload and listed SEFTs didnt look good, had added some padding to give some space
How to test?
Trello

/deploy harrisonj


springdoc-openapi giving 404 with spring 6

I am trying to migrate from springfox to  openapi because springfox  swagger2 is not working with Jakarta. I am using spring 6 and followed this https://springdoc.org/v2/ to migrate.  Below are the dependencies added. It is giving me 404 with swagger-ui.html.

org.springdoc
springdoc-openapi-starter-webmvc-ui
2.0.4

org.springdoc
springdoc-openapi-starter-webmvc-api
2.0.4

org.springdoc
springdoc-openapi-starter-webflux-ui
2.0.4

I'm also using a v2 version (2.5.0, 2.6.0) and got 405 with swagger-ui/index.html


Revert proto changes from #2381, as they invalidated JSON stored in the Minder database

Note that this means deployments between #2381 and now may end up with the following internal error:
2024-02-21T20:58:53.447Z
Unknown
cannot convert rule type pr_trusty_check to pb: cannot get rule type definition: cannot unmarshal rule type definition: proto: (line 1:29): unknown field "trusty"
ListRuleTypes

coverage: 36.323%. remained the same
when pulling d77c2e36c196c60c6f6a5c7fe5fd690f73baf442 on evankanderson:restore-proto
into 23f7803423f06bafdedcb619099bb25496194412 on stacklok:main.


Add support for jQuery in noConflict mode

Materialize would break when used in an environment where jQuery was loaded in noConflict mode

+1

I did not include a bin version of the javascript assets but I could add one if required

This one's pretty much a must when using Materialize.css in a WordPress environment -- please consider merging ASAP

it says the pull requeest contains merge conflicts that must be resolved...not  sure what exactly that means (new gitter) but it might be stopping them.

That's because I included a compiled version of the JS assets -- they should be able to just resolve using their version and then re-compile

Merged changes from master back in -- should be automatically mergeable now

+2

Sorry this slipped through the cracks. I just added it in a simple commit: 67c93cf

Thanks for letting us know.


python3Packages.geopandas: 0.14.4 -> 1.0.1

Description of changes
Update geopandas to the latest major version.
Release notes:
https://github.com/geopandas/geopandas/releases/tag/v1.0.0
https://github.com/geopandas/geopandas/releases/tag/v1.0.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 327871 run on x86_64-linux 1

12 packages failed to build:

python311Packages.folium
python311Packages.folium.dist
python311Packages.momepy
python311Packages.momepy.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.momepy
python312Packages.momepy.dist
python312Packages.osmnx
python312Packages.osmnx.dist

32 packages built:

python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.geodatasets
python311Packages.geodatasets.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.wktutils
python312Packages.wktutils.dist

Apart from the dependant packages build failure, looks good to me!

I've just checked the build failures: all are already broken on "trunk" on hydra.
For folium, I've opened https://github.com/NixOS/nixpkgs/pull/328500 (unrelated to geopandas I think).

And osmnx is actually broken because of folium.

Just merged https://github.com/NixOS/nixpkgs/pull/328500 and running nixpkgs-review again.

Result of nixpkgs-review pr 327871 run on x86_64-linux 1

2 packages marked as broken and skipped:

python311Packages.shimmy
python311Packages.shimmy.dist

4 packages failed to build:

python311Packages.momepy
python311Packages.momepy.dist
python312Packages.momepy
python312Packages.momepy.dist

40 packages built:

python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.geodatasets
python311Packages.geodatasets.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.wktutils
python312Packages.wktutils.dist


update peerDependecies for mocha-framework

Is your maintenance request related to a problem? Please describe.
Fix peerDependency:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

Describe the solution you'd like
The warning not to be displayed.
Describe alternatives you've considered
Additional context

To think we even had an issue for this @nicojs

To be fair, continue to running it, I believe it tells us to uninstall it. But i was migrating from 3, so that was the context in which I saw that message after doing npm outdated...

ow wait. no. @quoininc-huudatran mocha-framework is obsolete now! we have removed this package (my fault). You can easily remove this dependency ;)
I guess you should only use now:
core
your-runner
(optional) typescript-checker

so i guess this issue is to be closed. Just remove framework dependency. Its no longer needed :)

well, in that case, it should have a deprecation on install, I didn't see. All i saw was that peerDependency missing.

I think there was throw in code 'stop using mocha framework', but im not sure + it is already removed from master branch so there is nothing we can do now :/


boards: dptechnics: Add support for Walter board

This PR adds support for DPTechnics Walter, a compact IoT development board combining an ESP32-S3 with a Sequans Monarch 2 GM02SP cellular modem.
Definitions are based on the other ESP32-S3 boards and includes the necessary modifications to quickly get started with the modem subsystem and modem_cellular driver.

@vThibo Thanks for the contribution. I missed this review before.

@vThibo Thanks for the contribution. I missed this review before.

No problem, thanks for the review suggestions.

some minor feedback regarding the documentation Thanks for the PR!

Thanks for the feedback!

@sylvioalves @marekmatej the CI failure with LZ4 sounds vaguely familiar, does this ring a bell and do you know what needs to be changed to make it pass?

@sylvioalves @marekmatej the CI failure with LZ4 sounds vaguely familiar, does this ring a bell and do you know what needs to be changed to make it pass?

I remember rebasing and push again did the trick for me.

@vThibo Sounds error is related to this:
devicetree error: 'bus-speed' is marked as deprecated in 'properties:' in /__w/zephyr/zephyr/dts/bindings/can/espressif,esp32-twai.yaml for node /soc/can@6002b000.

Would you check it?

@sylvioalves please revisit

Apologies for the delayed response. Tested on upstream, let me know if a rebase is needed.

Overall LGTM, waiting for last doc update.

Changed docs with feedback and small reference change.
Now also using the generic purpose partition tables added in #76976.


PFI Structure Tests

What type of PR is this? (check all applicable)

[ ] ♻ Refactor
[ ] ✨ New Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 👷 Example Application
[ ] 🧑💻 Code Snippet
[ ] 🎨 Design
[ ] 📖 Content
[ ] 🧪 Tests
[ ] 🔖 Release
[ ] 🚩 Other

Description

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].
Related Tickets & Documents

Resolves #
Mobile & Desktop Screenshots/Recordings

Added code snippets?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

No tests? Add a note

Added to documentation?

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 general documentation
[ ] 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Test is failing

Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.037 s <<< FAILURE! - in website.tbd.developer.site.docs.tbdex.pfi.PfiStructureTest
Error:  PFI initializes server  Time elapsed: 0.037 s  <<< ERROR!
java.lang.NoClassDefFoundError: io/ktor/server/plugins/contentnegotiation/ContentNegotiationKt
at website.tbd.developer.site.docs.tbdex.pfi.PfiStructureTest.PFI initializes server(PfiStructureTest.kt:66)
Caused by: java.lang.ClassNotFoundException: io.ktor.server.plugins.contentnegotiation.ContentNegotiationKt
at website.tbd.developer.site.docs.tbdex.pfi.PfiStructureTest.PFI initializes server(PfiStructureTest.kt:66)


Fix CloudStack userCustomDetails not triggering creation of templates

Summary
This change fixes an issue where the CloudStackMachineConfig's userCustomDetails field could have a key updated and not trigger a the creation of a new template. The issue occurs only when the value of a key-value pair is an empty string. See #5791 for more details.
Other notes
The cyclomatic complexity of the NeedsNewMachineTemplate function violated linting rules so has been refactored.
Further refactoring will be done on the NeedsNewMachineTemplate unit tests to turn them into table tests.
Fixes #5791

/approve


feat: allow custom execution methods and arguments

Motivation
Closes #34
Changes

Add support for custom execution methods and arguments in macOS and Windows
Add tests with custom arguments
Add tests with a custom execution method

Notes
Before adding support for Linux we will have to stop downloading and executing GitLab's script. This will require a small decoupling effort that I'll get to in another PR.

I'll close this PR and delete the branch since GH is not letting me clone the demo game for whatever reason 🤦 .


Send logs to socket

@amazingalek  something I need some help deciding: OWML.ModHelper.ModConsole does't exist anymore, which means this update isn't backwards compatible. Is there a way we could somehow have something in OWML.ModHelper.ModConsole  that just points to OWML.ModHelper.Logging.ModConsole?

@amazingalek something I need some help deciding: OWML.ModHelper.ModConsole does't exist anymore, which means this update isn't backwards compatible. Is there a way we could somehow have something in OWML.ModHelper.ModConsole that just points to OWML.ModHelper.Logging.ModConsole? Or how should I handle this?

It's backwards compatible if it's used the same.
It's still ModHelper.Console.WriteLine("lol");, right?
Ofc we have to test it but this is my understanding.

@amazingalek something I need some help deciding: OWML.ModHelper.ModConsole does't exist anymore, which means this update isn't backwards compatible. Is there a way we could somehow have something in OWML.ModHelper.ModConsole that just points to OWML.ModHelper.Logging.ModConsole? Or how should I handle this?

It's backwards compatible if it's used the same.
It's still ModHelper.Console.WriteLine("lol");, right?
Ofc we have to test it but this is my understanding.

That part works, the part that's broken is doing ModHelper.ModConsole.OnConsole += etc like what Nebula is doing here:
https://github.com/misternebula/OWConsole/blob/master/OWConsole/Main.cs#L61

That part works, the part that's broken is doing ModHelper.ModConsole.OnConsole += etc like what Nebula is doing here:
https://github.com/misternebula/OWConsole/blob/master/OWConsole/Main.cs#L61

It looks to me like ModHelper.ModConsole.OnConsole still exists and looks the same as before?

That part works, the part that's broken is doing ModHelper.ModConsole.OnConsole += etc like what Nebula is doing here:
https://github.com/misternebula/OWConsole/blob/master/OWConsole/Main.cs#L61

It looks to me like ModHelper.ModConsole.OnConsole still exists and looks the same as before?

@amazingalek ModConsole has been moved to ModHelper.Logging, so you'd need to call ModHelper.Logging.MoConsole.OnConsole instead, right? I only noticed this because I started the game using Nebula's mod and it threw an error about that

@amazingalek ModConsole has been moved to ModHelper.Logging, so you'd need to call ModHelper.Logging.MoConsole.OnConsole instead, right? I only noticed this because I started the game using Nebula's mod and it threw an error about that

Nope, you haven't changed IModConsole, so you still use it like this: ModHelper.ModConsole.OnConsole
The error might be related, but it's not exactly this.

@amazingalek ModConsole has been moved to ModHelper.Logging, so you'd need to call ModHelper.Logging.MoConsole.OnConsole instead, right? I only noticed this because I started the game using Nebula's mod and it threw an error about that

Ah yeah, because the namespace has changed, and it's static.
🤔


Fix documentation of inline filters

I noticed that inline field filters didn't work for me as documented:
class SignupForm(Form):
    name = StringField('name')

    def filter_name(form, field):
        return field.strip()

This resulted in TypeError: filter_name() missing 1 required positional argument: 'field'.
According to https://github.com/wtforms/wtforms/blob/0beff0b5c29f4995ea1c573d3c1d043471b6e1c3/src/wtforms/fields/core.py#L334, only the field's data member is passed as an argument. Adjusting the argument list of my code resolved the issue for me.
This patch updates the documentation accordingly.

I am not sure I understand the issue here. Let us look indeed at this snippet:
https://github.com/wtforms/wtforms/blob/0beff0b5c29f4995ea1c573d3c1d043471b6e1c3/src/wtforms/fields/core.py#L334
This is totally valid if filter is a variable for a class method.
>>> class Foo:
...     def bar(self, baz):
...         print(f"Foo.bar {baz}")
>>> bar = Foo().bar
>>> bar("baz")
Foo.bar baz

Here we just pass one argument to Foo.bar but the self argument is implied when assigning the variable with bar = Foo().bar
Plus, this behavior is tested:
https://github.com/wtforms/wtforms/blob/0beff0b5c29f4995ea1c573d3c1d043471b6e1c3/tests/fields/test_filters.py#L44-L58
If you actually spotted a bug, would you give a piece of code to help reproduce it, and if you provide a patch, would you include a test proving its resolution?


Add AD plugins to 2.2 manifests

Signed-off-by: Tyler Ohlsen<EMAIL_ADDRESS>Description
Add AD plugins to 2.2 manifests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2425 (0d9366d) into main (95b8b73) will increase coverage by 5.37%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2425      +/-   ##
=============================================
+ Coverage     94.62%   100.00%   +5.37%
=============================================
  Files           210         6     -204
  Lines          4317       105    -4212
  Branches         29        19      -10
=============================================
- Hits           4085       105    -3980
+ Misses          226         0     -226
+ Partials          6         0       -6

Impacted Files
Coverage Δ

...teg_test/integ_test_start_properties_opensearch.py

...rtifacts_actions_OpenSearch_Dashboards_Jenkinsfile

src/ci_workflow/ci_check_list.py

src/ci_workflow/ci_check.py

src/sign_workflow/signer_pgp.py

...jobs/PromoteArtifactsQualifier_actions_Jenkinsfile

tests/jenkins/jobs/BuildShManifest_Jenkinsfile

src/assemble_workflow/dist.py

src/run_sign.py

src/ci_workflow/ci_check_gradle_properties.py

... and 194 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Multi Users

Is your feature request related to a problem? Please describe.
no easily switching accounts
Describe the solution you'd like
so i know ive suggested multi tabs in the past but that is just one solution to what i want and ive thought of another
you know lastpass and other password managers
well a account manager all login details stored locally so no chance of being hacked
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've
considered.
Additional context
so i went searching runelite for forks and found one which says it has this in its feature list so i know its possible im just hoping its in the scope of the vision for runelite

Duplicate of #641


feat: change pachage name: autoware_msgs -> tier4_msgs

Related Issue(required)
https://github.com/autowarefoundation/autoware.universe/issues/1
https://github.com/autowarefoundation/autoware.universe/issues/2

Description(required)
rename autoware_msg to tier4_msg
Review Procedure(required)

build check
check that autoware_*_msg are no longer used.

Related PR(optional)
CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

cc. @isamu-takagi

@tkimura4
Are there any plans to change the package name of external_api_msgs?

@isamu-takagi
I forgot it!

@taikitanaka3
Could check test error of behavior_velocity_planner ?

--- stderr: behavior_velocity_planner
1: [ RUN      ] state_machine.set_state_stop
Errors while running CTest
1: [       OK ] state_machine.set_state_stop (0 ms)

1: [ RUN      ] state_machine.set_state_stop_with_margin_time
1: [       OK ] state_machine.set_state_stop_with_margin_time (0 ms)
1: [ RUN      ] state_machine.set_state_go_with_margin_time
1: /__w/autoware.universe/autoware.universe/planning/behavior_velocity_planner/test/src/test_state_machine.cpp:73: Failure
1: Value of: state_machine.getDuration() < margin_time
1:   Actual: false
1: Expected: true
1: [  FAILED  ] state_machine.set_state_go_with_margin_time (201 ms)

The test error may be fixed by https://github.com/autowarefoundation/autoware.universe/pull/156

@tkimura4
I might miss equal case for unit test
    // be sure that duration is less equal to margin_time
    EXPECT_FALSE(state_machine.getDuration() > margin_time);


Fixes #196 makes it possible to add server port as a env.

I hope that this is the only place that has to be altered in order to pass server port and change it in the server.properties.

What scenario did you encounter that needed this? If it is indeed needed you could established the default value along with the other environment variables:
https://github.com/itzg/dockerfiles/blob/master/minecraft-server/Dockerfile#L44-L49

The problem is when you have a bungeecord proxy setup. Here each minecraft server has to have awareness about the actual port it is running on (as i understand)... So building a docker-compose file with multible minecraft servers, on the same host... then it is a pain to start them, and then configure server.properties afterwards.
I'll change the default env's as well. didn't notice that.


[macOS] Fix kcpassword compatibility issue with Python 3

Description
In scope of https://github.com/actions/virtual-environments/pull/5115, we switched kcpassword script to use Python 3 instead of Python 2 because Python 2 was removed from macOS 12.
After that, kcpassword started to produce incorrect results. See https://github.com/actions/virtual-environments/issues/5231 for details.
Root cause
chr function was changed in Python 3 and don't produce char by number anymore.
More details can be found in https://python-future.org/compatible_idioms.html#chr
Fix

I have removed converting to string completely and convert to byte array instead
Writing byte array directly to file

How it was tested
I have compared all test cases reported in https://github.com/actions/virtual-environments/issues/5231 and after my changes script product correct result for both Python 2 & 3
Related issue: https://github.com/actions/virtual-environments/issues/5231

It seems like the compatibility issue isn't chr() itself, but that
b'a' == 'a' # True in Python 2, False in Python 3

Anyway, using bytestring here seems appropriate.
I don't have context on the application domain.  What is /etc/kcpassword and how do we use it?


Cookies are not set if there is data in the response

Environment

Operating System: Windows_NT
Node Version:     v20.11.1
Nuxt Version:     3.12.4
CLI Version:      3.12.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      compatibilityDate, devtools, modules, tailwindcss, css, routeRules, vite, nitro, runtimeConfig, app, fontLoader
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
link
Describe the bug
// Cookies are being set
export default defineEventHandler(async (event) => {
	setCookie(event, 'token', '123', { maxAge: 60 * 60 * 24 * 7, path: '/' });
	return ;
});

// Cookies are not set
export default defineEventHandler(async (event) => {
	setCookie(event, 'token', '123', { maxAge: 60 * 60 * 24 * 7, path: '/' });
	return 'response';
});

//In both cases I get the contents of set-cookie
const { data, error } = await useFetch('/api/settings/get', {
	onResponse({ request, response, options }) {
		const headers = response.headers;

		const cookie = headers.get('set-cookie');

		if (cookie) {
			console.log('COOKIE:', cookie);
		}
	}
});

Additional context
No response
Logs
No response

but I found it's working

I found that there is only /api/test in the network request, but no /api/test2. This is how I understand it:
There is an option server in the useFetch API with a default value of true, which completes the fetching of /api/test and /api/test2 requests on the server and completes the rendering of related components. Under normal circumstances, the client (browser) will not initiate /api/test and /api/test2 requests. However, since /api/test does not return a response (usually only middleware will do this), /api/test initiates another request on the client, returns the server-side cookie settings, flows through the client (browser), and updates document.cookie
If you want to set cookies, you can refer to the following:
<script setup>
const { data: data2 } = useFetch('/api/test2', { server: false });
console.log('response data2', data2.value);
</script>


update the dependent version of timely-dataflow.

Some operations are not supported in the newest timely-dataflow and can lead to compile error, such as input_graph.advance_to(prev_time.inner + 1)(examples/motif.rs:107) and timely::progress::timestamp::RootTimestamp;(examples/triangles.rs:14).
So the dependency of timely-dataflow should be changed into an older version.

Thanks for the PR! It seems smart to merge this, but I should probably also correct the code to work with the most recent version of timely. Sigh. :D


Pick up an item?

Hi,
is there any way to pick up item with the protocol lib?
I know that if someone else picks up an item the ServerCollectItemPacket will be send.
I already managed to drop all items in the hotbar, but picking them up is kind of a struggle right now. Also as outline in other issues, it would be good to know how I could move an item from the inventory to the hotbar (so basically either picking up an item to the inventory / hotbar; or dropping them).
Any help is highly appreciated.
Thanks,

Alright I finally got it working :-)
Interact with inventory (e.g. drop all items)
	private void dropItems() {
		// via hotbar
		for (int index = 0; index < 9; index++) {
			getSession().send(new ClientPlayerActionPacket(PlayerAction.DROP_ITEM_STACK,
					new Position((int) x, (int) y, (int) z), Face.BOTTOM));

			selectHotbarInventorySlot(index);
			sleep();
		}
		// via player inventory
		// Magic numbers are documented here: wiki.vg/Protocol#Window_Items
		for (int slot = 9; slot < 45; slot++) {
			// https://github.com/DragonetMC/DragonProxy/blob/master/src/main/java/org/dragonet/proxy/network/translator/pe/PEPlayerEquipmentPacketTranslator.java
			int windowId = Constants.PLAYER_INVENTORY_WINDOW_ID; // The ID of the window which was clicked. 0 for player inventory.
			WindowActionParam param = ClickItemParam.LEFT_CLICK;
			WindowAction action = WindowAction.DROP_ITEM;
			ItemStack clicked = null; // The clicked slot. Has to be empty (item ID = -1) for drop mode.
			getSession().send(new ClientWindowActionPacket(windowId, actionId++, slot, clicked, action, param));
			sleep();
		}
	}

	private void selectHotbarInventorySlot(int index) {
		if(index < 0 || index > 9){
			return;
		}
		getSession().send(new ClientChangeHeldItemPacket(index));
	}

	protected void sleep() {
		// prevent: [NoCheatPlus] ${username} failed FastClick: tried to move items in their inventory too quickly.
		try {
			Thread.sleep(150L);
		} catch (InterruptedException e) {
			e.printStackTrace();
		}
	}

Pick up item
Here are pretty much the steps / packets that are involved:
Entities are published via the ServerEntityPositionPacket according to http://wiki.vg/Protocol#Collect_Item The server only checks for items to be picked up after each Player Position (and Player Position And Look) packet sent by the client.  so basically what the final code looks like is this:
if (event.getPacket() instanceof ServerEntityPositionPacket) {
			ServerEntityPositionPacket p = event.getPacket();
			if(p.isOnGround()){
				bot.getSession().send( new ClientPlayerPositionRotationPacket( true, bot.getX(), bot.getY(), bot.getZ(), bot.getYaw(), bot.getPitch() ) );
			}
		}

The initial x/y/z coordinates can be obtained by listening to the ServerPlayerPositionRotationPacket:
if ( event.getPacket() instanceof ServerPlayerPositionRotationPacket ) {
            ServerPlayerPositionRotationPacket packet = event.getPacket();
            bot.setX( packet.getX() );
            bot.setY( packet.getY() );
            bot.setZ( packet.getZ() );
            bot.setYaw( packet.getYaw() );
            bot.setPitch( packet.getPitch() );
            // TODO: onPositionRotationEvent
            bot.getSession().send( new ClientPlayerPositionRotationPacket( true, bot.getX(), bot.getY(), bot.getZ(), bot.getYaw(), bot.getPitch() ) );
        }

With this solution it seems that the bot keeps picking up item's even though he does not have any more inventory space. If you want to prevent this investigate the ServerCollectItemPacket (which will be send once a player collects an entity) and the ServerSetSlotPacket (which updates the player's inventory slot with the picked up item). the final code looks similar to this:
if (event.getPacket() instanceof ServerEntityPositionPacket) {
			ServerEntityPositionPacket p = event.getPacket();
			if(p.isOnGround() && bot.hasInventorySpace()){
				bot.getSession().send( new ClientPlayerPositionRotationPacket( true, bot.getX(), bot.getY(), bot.getZ(), bot.getYaw(), bot.getPitch() ) );
			}
		}else if(event.getPacket() instanceof ServerWindowItemsPacket) {
			// before joining the game this will tell us what we have in our inventory
			ServerWindowItemsPacket p = event.getPacket();
			if(Constants.PLAYER_INVENTORY_WINDOW_ID == p.getWindowId()){
				ItemStack[] itemStacks = p.getItems();
				bot.setBotInventory(itemStacks);
			}
		} else if (event.getPacket() instanceof ServerSetSlotPacket) {
			ServerSetSlotPacket p = event.getPacket();
			if(Constants.PLAYER_INVENTORY_WINDOW_ID == p.getWindowId()){
				bot.updateBotInventory(p.getSlot(), p.getItem());
			}
		}

with
public void setBotInventory(ItemStack[] inventory){
		this.inventory = inventory;
	}

	public void updateBotInventory(int slot, ItemStack item){
		this.inventory[slot] = item;
	}

	public boolean hasFreeSpaceInInventory(){
		boolean hasFreeSpace = false;
		for(ItemStack is: inventory){
			if(is == null){
				hasFreeSpace = true;
				break;
			}
		}
		return hasFreeSpace;
	}

Disclaimer:
Permission is hereby granted, free of charge, to any person obtaining a copy of this example code and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

 IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

:-)


sql: improve schema not found msg

PR Description
Type of change

[x] Bug fix

Summary of the change and which issue is fixed
Main changes: TODO

Checklist

I have run format.sh under script
I have commented my code, particularly in hard-to-understand areas
New and existing unit tests pass locally with my changes

cc @Commelina @daleiz
before we split the invalid SQL into specified error classes, let us have this tiny fix first


Is it possible to make the menu framerate match the game

This game has the same issue with P3R where the game menu is locked to 60 FPS

When you enter a menu, t.maxfps gets set to 60. Manually editing t.maxfps once in the menus will let you navigate them at custom fps but it resets once you open the menu again. No idea how this could even be fixed.
-offtopic- The game is quite a mess since FXAA (default AA: on option) causes shimmers and forcing TAA breaks ambient occlusion but fixes all the jagged edges. Using the built-in FXAA option means resolution scaling won't work either. Either have to live with good shimmery visuals or have no ambient occlusion but have great anti-aliasing. What a dilemma.

It should be easy enough to add an override to stop the framerate changing. I shall look into it.

-offtopic- The game is quite a mess since FXAA (default AA: on option) causes shimmers and forcing TAA breaks ambient occlusion but fixes all the jagged edges. Using the built-in FXAA option means resolution scaling won't work either. Either have to live with good shimmery visuals or have no ambient occlusion but have great anti-aliasing. What a dilemma.

With regards to the image quality stuff. I have found a way to have TAA and working ambient occlusion. It's the half-res ambient occlusion that breaks with TAA enabled. I will try and add an "Enable TAA" option to SMTVFix to enable this and fix the bug.

Okay, in v0.8.2 I've added the option to remove the 60FPS cap in menus. That should address this issue. I've also added (and enabled by default) an option to enable TAA. If you spot any issues or have any problems, feel free to reopen the issue and yell at me.

Heya, thanks for your hard work.
I just tried it out with the 60FPS fix set to true. It works on the titlescreen when selecting a save to load, but once in-game, the menu is still choppy, even though the FPS is uncapped - according to steam.

Heya, thanks for your hard work.
I just tried it out with the 60FPS fix set to true. It works on the titlescreen when selecting a save to load, but once in-game, the menu is still choppy, even though the FPS is uncapped - according to steam. It also happens in battles, when selecting the main action such as Items/Skills etc. but for some reason the skill selection itself runs buttery smooth. This was the case even without the fix you made, I thought that maybe this info could help you figure something out.

Yeah I'm not 100% sure why that is. I'm guess some of the menus must just be animated at a lower frame rate and not interpolated. Not sure what I can do about that on my end really I'm afraid.


Use of Heartbeat in activeMQ

Can anyone please explain the use of Heartbeat in stomp
If heartbeat is disabled will it cause any issues?
What are some scenarios where heartbeat is necessary?

Currently I am using stomp protocol to send messages to activeMQ and to listen to messages. This is done in Nodejs using stompit library.
When the application is having high CPU or Memory usage, it stops sending heartbeat to broker. So the broker redelivers the message which is currently being processed, leading to repetitive processing of the same message
On disabling heartbeat, the application seems to work fine but I am unsure of the further issues disabling heartbeat might cause. Even when the broker is stopped while sending messages, behaviour seems to be same with or without heartbeat
I have read that it is an optional parameter but I am unable to find out it's exact use cases
Can anyone mention scenarios where no heart beat can cause issues to the application?


Stop producing nightly snapshot maven builds

We currently have Jenkins set up to deploy nightly snapshot builds of our maven artifacts to Sonatype. There are several reasons we do this:

when we still had a multi-repository setup, it was necessary to publish maven artifacts in a place where the other repo could get them - so for example rdf4j-storage needed to be able to download rdf4j artifacts as part of its build.
we provide these nightly snapshot builds as a courtesy to developers who want to try out the latest/greatest (see https://rdf4j.org/download/#source-code-and-nightly-builds).

However, there are some downsides as well:

when a developer runs a maven command the first time every day, maven will check and download the latest snapshot dependencies from sonatype (even if the developer uses their own local build process) - not harmful, but it can take a long time, which is annoying.
it can sometimes cause confusion for developers to know which exact version of the code they are depending on (they changed something locally in a module they depend on, but the build still uses the downloaded snapshot , causing odd errors).
the Jenkins deployment process is not 100% reliable, and sometimes falls over with errors.

So the question is: do we still want to provide nightly snapshot builds on Sonatype?

I really like it for testing the newest features. Essentially I have some projects that use rdf4j and if I've added some new features I want to test out to develop, then I'll use the SNAPSHOT version in one of my projects. It's a lot simpler than having to checkout code from github and building it locally within that project.

really like it for testing the newest features. Essentially I have some projects that use rdf4j and if I've added some new features I want to test out to develop, then I'll use the SNAPSHOT version in one of my projects. It's a lot simpler than having to checkout code from github and building it locally within that project.

You'd still be able to do that though - the snapshots would just come from your own local maven repo rather than from sonatype (assuming you've ran mvn install on the rdf4j project recently). I mean, you already have the rdf4j project checked out from github, right?
Still, I see your point, this is essentially advantage #2 from my list.
What we're struggling with is that for developing RDF4J itself, having these snapshots is a hindrance. However, like you mention as well, for doing feature testing in a separate project there's clearly an advantage.
It should be possible to set things up in such a way that we still deploy snapshots for reuse in separate projects, but make sure that RDF4J's own build process doesn't depend on them. That would be the best of both worlds. I'll take a look at this.

My own projects use docker to build or a build server. So I would have to add a new step to checkout the develop branch and mvn install it.

Fwiw I am now unsure there is a problem worth solving here. Having trouble reproducing the snapshot download during build thing.

I think I have seen it in my logs every once in a while. Cant reproduce now. Maybe it'll happen if you remove the rdf4j cache from your .m2 folder and try to mvn install from inside one module in the rdf4j project.

I think I have seen it in my logs every once in a while. Cant reproduce now. Maybe it'll happen if you remove the rdf4j cache from your .m2 folder and try to mvn install from inside one module in the rdf4j project.

That is, now that I think about it, normal/by design: the idea of the snapshot repo was (also) to make it possible to compile individual modules without having to first build the entire project. However, what I was trying to solve was that it occassionally downloads these snapshots even when building from the project root (when it definitely shouldn't happen, because everything it needs is in the reactor).
I've just found that it happens on the project root level as part of the enforcer plugin firing its enforce-bytecode-version goal. I think this is because that plugin fires before compilation (in the validation phase) - so it can't use the locally compiled code, and instead downloads the snapshot build to check its bytecode version. That's a bit backward, I'll try to move that check to somewhere after the compilation phase (probably verify), so it doesn't need the download.

We could also just get rid of the plugin altogether and instead rely on the fact that we run a github action CI with the full testsuite on Java 8.


pull request for e2e test at 12/27/2016 05:26:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use secondary index on get_transaction

This PR partially solve #105.
The new query makes use of the secondary index transaction_id, and should make the look up from O(n) to O(1).

:+1:

:+1: Optimize all the things!

I'm currently working on #192 which duplicates and extends this functionality.  In fact most query methods benefit from a secondary index, and all require a check on block validity anyway.  This seems to require some restructuring to the query methods. I haven't prepared the PR yet but you can see the changes on branch https://github.com/bigchaindb/bigchaindb/tree/core/192/ignore-invalid-blocks .  So maybe we can wait on merging this PR until I'm done?

So maybe we can wait on merging this PR until I'm done?

Yes, it's better. Even if we don't merge my PR, I did some extra work profiling the old and the new query. The new one is much faster, and less CPU intense for RethinkDB (and this is for your queries in your PR as well). :clap:

Will close this in favor of #192. There are also some other optimizations I have in mind, will discuss it in another issue.


Sub-Scrambled Cube 21 is not appearing in its img-big page

Sub-ScrambledCube21.mp4 is not appearing in its img-big page.

The img HTML tag was replaced by a video one, with controls and autoplay after alt="Sub-Scrambled Cube 21".


Lua moments wrapper hangs during I/O in parallel

When running moment app simulations in parallel using the g0-app-merge branch of G2, the simulations will randomly hang. Some debugging shows this is occurs in L624-L629 of mpi_comm.c, most likely when grid_sub_array_decomp_write_fp is called. A single process is failing, causing the whole job to freeze. The issue is random, sometimes occurring during the initial write, sometimes during a later one, sometimes not at all. Repeatable with greater frequency the more cores are used.

After some debugging this seems to occur due to the way Lua tables work and the non-determinism in the order of species on different cores. We know how to fix and will submit a fix and test soon.


Slight mistranslation

Microsoft PowerToys version
0.56.2
Utility with translation issue
Settings
🌐 Language affected
German
❌ Actual phrase(s)
Settings of Powertoys Run
... vom Laufwerksbuchstaben "C:" ... (from the drive letter "C:")
✔ Expected phrase(s)
... vom Laufwerk "C:" (from the drive "C:")
ℹ Why is the current translation wrong
As far as I understand the drive/volume (so the drive letter is not in the main focus) itself is meant

https://microsoft.visualstudio.com/OS/_workitems/edit/39148431

this should be in .60  /needinfo

We released 0.60.1 and this is included in it!  https://aka.ms/installpowertoys


Some Issues with TickEvent

With alkaid, developers can handle ticks as some events, which is a good practice in some scenarios
However, There're some issues with TickEvent (and its implementation):

TickEvent.tick is always 1

https://github.com/hanbings/alkaid/blob/d173945101714597a4594079ccb5639c973a2bca/alkaid-bukkit/src/main/java/com/alkaidmc/alkaid/bukkit/extra/AlkaidExtra.java#L39
https://github.com/hanbings/alkaid/blob/d173945101714597a4594079ccb5639c973a2bca/alkaid-bukkit/src/main/java/com/alkaidmc/alkaid/bukkit/extra/event/TickEvent.java#L12

It sends tons of events even unused, which stresses GC

Please check out the new commit.
[commit 6301953] (https://github.com/hanbings/alkaid/commit/6301953d867ab05332c680f251e854a8ea88b0eb)
I've changed AtomicLong to static because Alkaid will detect duplicate loads and I believe this change will work. Thanks!

Just close this issue with your confidence.

There're still some issues with your new commit.
TickEvent, which should be immutable, varies its tick when a newer one is fired, breaking its immutability. (And it should be immutable.)
Once TickEvent is immutable(or not), an AtomicLong is no longer necessary. Also, events are fired on the Main Thread where you can confidently avoid thread-safe issues, you don't have to use such a wrapper.
Additionally, You'd better use methods like getAndIncrease that guarantee thread-safe(CAS inside) instead of tick + 1.

New commit: https://github.com/hanbings/alkaid/commit/8368a3f6b768041b83f4f780ba2cfca8a00d66cc
In this commit (and the first two of this) we separated the Event from the Tick / Second counter so that the tick / second inside the Event is no longer mutable.
The problem has been fixed, thanks again!


comparision operator

@Guna-777 Please go through the README.md file. One pattern (in any language) should be submitted in any language. Please update your code and PR again.


[improve][ci] support to add first contribution label

Use GitHub graphQL API to check first contribution.
The example graphQL output is:
{"data":{"user":{"contributionsCollection":{"commitContributionsByRepository":[{"contributions":{"totalCount":15},"repository":{"owner":{"login":"apache"},"name":"pulsar"}},{"contributions":{"totalCount":1},"repository":{"owner":{"login":"apache"},"name":"pulsar-client-go"}},{"contributions":{"totalCount":1},"repository":{"owner":{"login":"apache"},"name":"pulsar-site"}}]}}}}

So just search the string to check if the PR is the first contribution.
First pull request will be added a first-pr label, example here: https://github.com/labuladong/pulsar/pull/11
Not first pull request will do nothing, example here: https://github.com/labuladong/pulsar/pull/12
This part is just for testing, I will remove it before merging:
- name: Checkout
      uses: actions/checkout@v3
      with:
        repository: labuladong/pulsar-test-infra

cc @tisonkun @nodece

Why add the first contribution label?

@nodece Because first contribution is an essential indicator for community, people are more likely to become long-term contributors if they can get timely attention or help.

@tisonkun OK, I will improve this.

@nodece Because first contribution is an essential indicator for community, people are more likely to become long-term contributors if they can get timely attention or help.

Oh, I see. In my opinion, I suggest we should be proactive about PR/ issues, which makes more sense.


Two examples - shouldn't it sanitize this?

When we run these examples through the jsonsanitizer this is what happens. I was under the impression this sanitizer should eliminate these types of XSS attacks? Or do you presume the JSON is broken down into key/value pairs and input validated/output encoded on a field by field basis? That would not scale very well for performance so was hoping jsonsanitizer would work.
public void testSVGAttack() throws Exception {
String json = "{test: "<svg/onload=alert(/XSS Owned/)>"}";
String clean = JsonSanitizer.sanitize(json);
System.out.println(clean);
}
input: {"test": "<svg/onload=alert(/XSS Owned/)>"}
output:  {"test": "<svg/onload=alert(/XSS Owned/)>"}
and then there is this........
String json = "{"test": "MDM%3c%73%43%72%49%70%54%20%74%59%70%45%3d%74%45%78%54%2f
%76%42%73%43%72%49%70%54%3e%4d%73%67%42%6f%78%28%31%32%38%31%35%29%3c%2f
%73%43%72%49%70%54%3e"}";
input === output
unencoded that is
{"test": "MDM"}

https://github.com/OWASP/json-sanitizer#security says
This library only ensures that the JSON string → Javascript object
phase has no side effects and resolves no free variables, and cannot
control how other client side code later interprets the resulting
Javascript object.  So if client-side code takes a part of the parsed
data that is controlled by an attacker and passes it back through a
powerful interpreter like eval or innerHTML then that client-side
code might suffer unintended side-effects.
var myValue = eval(sanitizedJsonString);  // safe
var myEmbeddedValue = eval(myValue.foo);  // possibly unsafe

Additionally, sanitizing JSON cannot protect an application from
Confused Deputy attacks
var myValue = JSON.parse(sanitizedJsonString);
addToAdminstratorsGroup(myValue.propertyFromUntrustedSource);

Without schema information about the meaning and provenance of embedded strings, there's no way to filter out embedded payloads without severely restricting the places where the sanitizer can be used so we don't even try.  For example, generating HTML from a trusted server-side template and sending it to the client.
Extending the sanitizer to take into account schema info could be worthwhile but I haven't done that yet.


Allow async connections to update auth when reconnecting

#291 will add support for reconnections to the async client. Once that lands, we should give the app an opportunity to update its connection settings (address, auth, etc.), because the original settings may not be valid by the time a reconnection is required.
Adding something like an on_reconnect callback on the builder would allow us to do this without any breaking changes, like so:
let client = rust_socketio::asynchronous::ClientBuilder::new(server)
    .on_reconnect(|| {
        async move {
            // Do something async...
            sleep(Duration::from_secs(5)).await;

            // Generate and return new config
            let mut settings = ReconnectSettings::new();
            settings.auth(json!({"token": "foo"}));
            settings
        }
        .boxed()
    })

Hey @rageshkrishna, just checking in with you: Do you plan to implement this as well? Just want to know if I should release a new version of the crate already or wait till this is in? Anyways it's also oke if you're not the one implementing this.

Yes, I'll have a PR for this right after the weekend. It would be nice if the release could wait for this because the reconnect feature feels like it's only half done without the ability to authenticate successfully.
Let me know if you have any thoughts on the proposed API for this.

Alright, perfect! The API looks good to me, it is nice and extensible. We could potentially also add it to the sync version later as well :)

@1c3t3a I've opened a PR for this one. Please take a look when you can. Thanks!


UncontrolledDropdown in 8.0.0 does not find toggle function in this.context

components: UncontrolledDrownDown
reactstrap version #8.0.0
import method umd/csj/es
react version #16.4.1
bootstrap version #4.3.1

What is happening?
On clicking the dropdown button in the UncontrolledDropdown component, an unhandled exception is raised and the dropdown menu does not appear.
What should be happening?
On clicking the dropdown button, the dropdown menu should appear.
Steps to reproduce issue

Render the UncontrolledDropdown as provided in the docs
Click on the button
Observe that the dropdown menu does not toggle open and that there is an exception in the consolee.

Error message in console
Uncaught TypeError: this.context.toggle is not a function
    at ProxyComponent.onClick (DropdownToggle.js:59)
    at ProxyComponent.onClick (react-hot-loader.development.js:693)
    at ProxyComponent.onClick (Button.js:52)
    at ProxyComponent.onClick (react-hot-loader.development.js:693)
    at HTMLUnknownElement.callCallback (react-dom.development.js:100)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:138)
    at Object.invokeGuardedCallback (react-dom.development.js:187)
    at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:201)
    at executeDispatch (react-dom.development.js:461)
    at executeDispatchesInOrder (react-dom.development.js:483)
    at executeDispatchesAndRelease (react-dom.development.js:581)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:592)
    at forEachAccumulated (react-dom.development.js:562)
    at runEventsInBatch (react-dom.development.js:723)
    at runExtractedEventsInBatch (react-dom.development.js:732)
    at handleTopLevel (react-dom.development.js:4477)

Code
<UncontrolledDropdown>
                <DropdownToggle caret>
                    Dropdown
                </DropdownToggle>
                <DropdownMenu>
                    <DropdownItem header>Header</DropdownItem>
                    <DropdownItem disabled>Action</DropdownItem>
                    <DropdownItem>Another Action</DropdownItem>
                    <DropdownItem divider />
                    <DropdownItem>Another Action</DropdownItem>
                </DropdownMenu>
            </UncontrolledDropdown>

I've also tested the same example in reactstrap==7.1.0 and get the expected output.

This works with the latest version of react: https://stackblitz.com/edit/reactstrap-v8-6oafs2?file=Example.js
I can confirm that I am gettin the same error when using<EMAIL_ADDRESS>We'll have to look into it.
For now, the suggested workaround is to upgrade react to 16.8 if you can.

@twheys Hi, Did you solve the problem? I use<EMAIL_ADDRESS>and<EMAIL_ADDRESS>but i see this.context.toggle error :(

I also get this error with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I'm also getting this error with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

It turns about the minimum supported version for the way context is being consumed within DropdownToggle is react 16.6 which would explain why it works in newer version of react and not the 16.4 version reported here.
I know the minimum version of react listed in peerDeps for this project is 16.3, but we will need to bump that (Or change the way we consume the context.)
For everyone reporting this issues while using the latest version of react, please provide an example using stackblitz or something similar as I cannot reproduce it in the latest version of react. (see my sample: stackblitz.com/edit/reactstrap-v8-6oafs2?file=Example.js) Chances are that you are not using the version of react you think you are using.

Using your example, I have worked out how to replicate it. It appears to only be an issue if you're importing the DropDownToggle (or DropDownMenu) directly out of the lib folder.
Here is the modified stackblitz with the issue:
https://stackblitz.com/edit/reactstrap-v8-j1pprd?file=Example.js
I am running<EMAIL_ADDRESS>and also had the issue with<EMAIL_ADDRESS>(there is no way I could be running an earlier version of react as I'm using hooks quite extensively).
So the simple "fix" is just to change how you do the imports for reactstrap.

Thanks to @leighmetzroth
I got a fix. I am also using<EMAIL_ADDRESS>with<EMAIL_ADDRESS>and I was also importing DropdownToggle from reactstrap directly. Adding UncontrolledDropdown as per example given by @leighmetzroth helped me out.
Earlier:
<DropdownToggle nav>

</DropdownToggle>

Fixed code:
<UncontrolledDropdown>
  <DropdownToggle nav>

  </DropdownToggle>
</UncontrolledDropdown>

Ok, so when importing directly it seems that two different versions/instances of DropdownContext are being used. To avoid this, always import things the same way (or know which import style is getting used under the hood.)
reactstrap provides a few different flavors to import: es, cjs, UMD, as src (as well as bundled and minified versions of each... because why not) (see here<EMAIL_ADDRESS>for the generated files)
Using different import types means that Dropdown from 'reactstrap' can end up getting /es/DropdownContext.js where DropdownToggle from 'reactstrap/lib/DropdownToggle' import references lib/DropdownContext.js These files are different and reference different context instances.

@TheSharpieOne with react 16.8 I get the same error. @YaroslavLyzlov no I did not solve the issue, but rolling back to reactstrap 7.1 fixed it for me.

I have the same Issue for me, version 8.0.0 React 16.x.x

@twheys, @canotech: Can you create an example showing the issue via something like stackblitz

@TheSharpieOne
import { PureComponent } from 'react'
import Link from 'next/link'
import Router from 'next/router'
import { connect } from 'react-redux'
import { FaUserCircle } from 'react-icons/fa'

import {
  NavLink,
  Collapse,
  Navbar,
  NavbarToggler,
  NavbarBrand,
  NavItem,
  Nav,
  UncontrolledDropdown,
  DropdownToggle,
  DropdownMenu,
  DropdownItem,
  Label,
} from 'reactstrap'
import { GoSignOut } from 'react-icons/go'

import { Routes } from '../../constants'
import { doLogOut} from '../../redux/modules/security'
import { logOut  } from '../../services/security'
import { openAlert } from '../../redux/modules/notificationsAlerts'

class NavbarComponent extends PureComponent {
  constructor(props){
    super(props)
    this.state = {
      isOpen: false,
    }
    this.logOutUser = this.logOutUser.bind(this)
    this.toggle = this.toggle.bind(this)
  }

  getRoutesWithoutAuthentication(){
    return this.props.url === Routes.assignPassword ||  this.props.url=== Routes.recoveryPassword || Routes.terms || Routes.privacy
  }

  logOutUser(){
    logOut().then((resp)=>{
      if(resp.status === 200){
        this.props.doLogOut()
        this.props.openAlert('success', '¡Adiós, Vuelve Pronto!')
        Router.push({pathname: Routes.home})
      }
    }).catch((e)=>{
      console.log('error',e)
      if(e){
        if(e.response){
          if(e.response.status !== 401)
            this.props.openAlert('error', 'Sucedió un error al cerrar su sesión. Intente de nuevo')
        }
      }
    })
  }

  toggle() {
    this.setState({
      isOpen: !this.state.isOpen
    })
  }

  render() {
    let unauthenticated = false
    if(!this.props.authenticated && this.getRoutesWithoutAuthentication()){
      unauthenticated = true
    }

    if(!this.props.authenticated && !unauthenticated) return null

    return (
      <Navbar color="primary" light expand="md" className="box-shadow" >
        <NavbarBrand href="/">
          <Link href={Routes.home}>

          </Link>
        </NavbarBrand>
        <NavbarToggler onClick={this.toggle}/>
        { !unauthenticated ?
          <Collapse isOpen={this.state.isOpen} navbar>

              <NavItem>
                <Link href={Routes.quotations}>
                  <NavLink href={Routes.quotations}>Cotizaciones</NavLink>
                </Link>
              </NavItem>
              <NavItem>
                <Link href={Routes.request}>
                  <NavLink  href={Routes.request}>Solicitudes</NavLink>
                </Link>
              </NavItem>
              <NavItem>
                <Link href={Routes.policies}>
                  <NavLink href={Routes.policies}>Pólizas</NavLink>
                </Link>
              </NavItem>
              <NavItem>
                <Link href={Routes.notifications}>
                  <NavLink href={Routes.notifications}>Notificaciones</NavLink>
                </Link>
              </NavItem>
              <UncontrolledDropdown nav inNavbar>
                <DropdownToggle nav>
                  <FaUserCircle className="icon-size"/>
                </DropdownToggle>
                <DropdownMenu right>
                  <Link href={Routes.home}>

                      <DropdownItem>
                         Home
                      </DropdownItem>

                  </Link>
                  <Link href={Routes.profile}>

                      <DropdownItem>
                         Mi cuenta
                      </DropdownItem>

                  </Link>
                  <DropdownItem divider />
                  <DropdownItem onClick={()=>this.logOutUser()}>
                    Salir {' '} <GoSignOut />
                  </DropdownItem>
                </DropdownMenu>
              </UncontrolledDropdown>

          </Collapse>: null
        }
      </Navbar>
    )
  }
}

export default connect(state => ({
  authenticated: state.security.authenticated,
  username: state.security.username,
}), { doLogOut, openAlert })(NavbarComponent)

@canotech the dropdown in your example works perfectly: https://stackblitz.com/edit/reactstrap-v8-n8zlcz?file=Example.js
Make sure the version of react you are using is 16.6+

@TheSharpieOne I tried to put together an example ( https://stackblitz.com/edit/react-5evsqd ) but wasn't able to reproduce the issue, and then I tried to upgrade my project to reactstrap 8.0.0 again and magically it no longer occurred there either. Strange, since I tried it yesterday and still got the same exception.  Wondering if maybe some downstream dependency got upgraded fixing the issue?
From my perspective, this issue is resolved. I will provide an update if I run into it again.

https://stackblitz.com/edit/react-5evsqd
To reproduce the error, click on the dropdown button

@TheSharpieOne and also I make sure the version of react-dom is 16.8.+
That's works for me! thank you @TheSharpieOne !

Please expose the context as said in #1462 . There is no way to import it via /es/DropdownContext nor /lib/DropdownContext nor /src/DropdownContext in NextJs.
Every possibility returns the same error upon compilation Unexpected Identifier: (function (exports, require, module, __filename, __dirname) { import React from 'react';.
On standard Webpack + Babel configuration it works fine but still looks hacky.

This simply solved it for me. I added toggle prop with an empty function.
<Dropdown
        isOpen={isOpen}
        toggle={() => {}}
      >

may also work with UncontrolledDropdown haven't tried it tho.

@canotech the dropdown in your example works perfectly: https://stackblitz.com/edit/reactstrap-v8-n8zlcz?file=Example.js
Make sure the version of react you are using is 16.6+

I didn't even have to use UncontrolledDropdown to replace Dropdown. From the quoted example I found missing inNavbar and added to
           <Dropdown nav inNavbar isOpen={this.state.menuOpen} toggle={this.toggleMenu}>
The one property.

Anyone working on it. I would like to take this issue.

@onlywicked, It's all your. Thank you!

stackblitz.com/edit/react-5evsqd
To reproduce the error, click on the dropdown button

Dropdown requires onToggle, it is not provided in your example. If you used UncontrolledDropdown or provide onToggle with the minimum version of react mentioned above (16.6) it works fine.

it still not works in v8.9.0


Fixed #34464 -- Fixed queryset aggregation over group by reference.

Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7.
Refs ticket-28477.
Thanks Ian Cubitt for the report.

@charettes Thanks :+1:

Merged in 9daf8b4109c3e133eb57349bb44d73cc60c5773c.

@felixxm will this fix be making it in 4.2.X, this regression has caused us issues when recently upgrading to 4.2 (from 3.2) I see it was not in the latest bug fix release 4.2.2, any chance it makes it in the next 4.2 release?

@dtorres-sf the patch should be part of Django 4.2.1 which was released on May 3rd.

Thanks, diving deeper it turns out this is not the fix we needed - I posted a comment to the Trac ticket describing instead of here.


[HW] Riya Roshan

Name: Riya Roshan
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/riya-roshan-2464661b2/
Attach the homework step I screenshots below:
My Astra database:

My Netlify account:

The Tiktok Clone App:

Attach the homework step II screenshots below:

Congratulations, well done! Enjoy your badge and see you on the next episode, this week!

WARNING: the fourth screenshot displays your Astra DB token for all to see. Please revoke it and generate a new one as soon as possible (adjusting the application if you want to).

Hey Riya Roshan, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/ZCAGDZfZTv-5NTpiAWC5og


Bug reporting directly from CLI

Which component is your feature related to?
Forge, Cast
Feature Request
In case forge or cast encounter a bug, show a link in console to open a bug report. Additionally, we could collect the stack trace and automatically include that in the report.
Open question is where these issues should be collected - if we do it through GitHub it could result in a lot of duplicates and noise. Perhaps some intermediate platform from where issues would be manually created would be beneficial.

We have links to our support groups in the --help, should be sufficient.


New package: Aladin.eBook version <IP_ADDRESS>

Microsoft Reviewers: Open in CodeFlow

Verify:

The application doesn't allow interaction without login.


Only set the project id in the request when applicable.

Coverage decreased (-0.006%) to 19.841% when pulling 20d9965ba2867211054d306eb42a578e41a7afd9 on deflaux:master into 0aa3e54eae4ce6d26fbdce05ae83961335c35854 on googlegenomics:master.

LGTM


Mount option for CW2?

It seems that this repo comes highly recommended on many Voron community resources, but the one thing that is missing from the mounts is a mount for Clockwork2. There is a slighly modified mount floating in Voron Discord that is modified from LGX lite.
Would it be possible to get CW2 versions of the mounts here too?

I decided to leave it to Voron to develop mounts for the stock toolheads.  My mounts are primarily to help folks running non standard setups.


[bug] Shell plugin spawn behaves differently when the release build is open with different methods.

I was running command like this
const command = Command.create("ffprobe", [
    "-v",
    "quiet",
    "-print_format",
    "json",
    "-show_format",
    "-show_streams",
    videoPath,
  ]);

It worked fine in debug mode, but stopped working when the app is bundled and installed.

After enable devtools in release mode, I see error: No such file or directory.
Then I found that the shell command doesn't work if I open the app the usual way (i.e. double click the .app).
But if I open the app with open command (open /Applications/myApp.app), everything works fine. The No such file or directory is gone.
What's the difference between the two methods?
I am using "@tauri-apps/plugin-shell": "2.0.0-beta.6",

I just found that in capability file I need to use absolute path for the command I am running.
 {
      "name": "ffprobe",
      "cmd": "/opt/homebrew/bin/ffprobe",
      "args": true,
      "sidecar": false
},

I suspect it's because the app doesn't inherit PATH variable from shell when it's open, while running the app with open from terminal let it inherit the PATH variable.

Can you try using this? https://github.com/tauri-apps/fix-path-env-rs/


lnch: init at 2017-02-16

Motivation for this change
lnch is a small go app that launches a process and moves it out of the process
group. It is useful to some scripts that need to launch a process without
killing the previous one, like custom script app launchers for lightweight
window managers.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I do not quiet understand your use case but it seems that the standard setsid utility would fulfill it too.


Condition support

remove deprecated getCondition()
add test
add indexing

WIP - This is not yet working, there seems to be issues with inheritance
Getting this to work is not going well. May need to get some ISPN or HS help internally... I hit different problems using ispn dsl or hs dsl.

WIP - This is not yet working, there seems to be issues with inheritance

Getting this to work is not going well. May need to get some ISPN or HS help internally... I hit different problems using ispn dsl or hs dsl.

Polymorphic is supported in ISPN and HS but needs

Add @Indexed annotation on parent and child classes (under same or different name, that's a performance consideration that can be reviewed later).
Also, I think you are hitting the NPE that I found and I reported to ISPN

<lponce> anistor, I think I spot a potential bug here https://github.com/infinispan/infinispan/blob/9.0.0.Final/object-filter/src/main/java/org/infinispan/objectfilter/impl/util/ReflectionHelper.java#L261 if I am not wrong the getDeclaredMethod() only look into the class but not take into consideration parent classes, so I reach that in an example using the above discussed.
<anistor> lponce: so you do have a failing test :)
<anistor> lponce: share it pls
<lponce> sure, a second and I can push it
<lponce> anistor, https://github.com/lucasponce/hawkular-alerts/tree/ispn-backend, you can mvn clean install -DskipTests ; cd engine ;  mvn test -Dtest=IspnAlertsServiceImplTest
<lponce> anistor, it's easy to trace the call with a debugger
<anistor> lponce: thanks

So, workaround for this until it is merged is just to bring the getXXX method on the child class over is indexing (until we have a patch and we can bump version), I'm using that strategy in Alert/Event and queries work fine.
Next week I'm going to be some time off, so I'm planning to work on weekend on this, I suggest I can merge it and take a look to this.

You are right.
When storing the child, parent is not well indexed.
I think we can re-use the workaround for the ActionPlugin.
If you look into the org.hawkular.alerts.engine.impl.model I put a ActionPlugin class which is just a private for the implementation, only used for storing in the cache and put the current indexes there.
I guess we can put a generic "Condition" class there and make the same strategy, put the indexes fields there, so internally.
Let me know what do you think, I won't merge this one, I will continue the work about Alert/Event and I suspect I will need same trick, I found a related issue but focus on fields from parent.
Anyway I guess that anistor from ISPN is aware of this with my chat.

Or thinking in general, perhaps we can extend this and use the org.hawkular.alerts.engine.impl.model for all entities and apply the indexes there. I think it is a clear approach, so we can hide the indexes (which in theory is an implementation detail). And we can complete the discussion about clonning objects, as we now need to create the wrapper objects.
I think this can resolve questions commented before.
I am going to apply that to the existing getTriggers to see how it looks like.

@lucasponce Updated to use the new pattern.  Removed DNM flag.


Black screen for mesh_renderer_gpu_example.py and mesh_renderer_simple_example.py

After clean install from pip I have a black screen instead of (supposed) rgb image in both scripts:
mesh_renderer_gpu_example.py

mesh_renderer_simple_example.py

output of e.g. mesh_renderer_gpu_example.py:
INFO:root:Importing iGibson (gibson2 module)
INFO:root:Assets path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/assets
INFO:root:Gibson Dataset path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/g_dataset
INFO:root:iG Dataset path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/ig_dataset
INFO:root:3D-FRONT Dataset path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/threedfront_dataset
INFO:root:CubiCasa5K Dataset path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/cubicasa_dataset
INFO:root:Example path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/examples
INFO:root:Example config path: /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/examples/configs
pybullet build time: Apr 16 2021 03:37:45
INFO:root:Device 0 is available for rendering
INFO:root:Command '['/home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/render/mesh_renderer/build/test_device', '2']' returned non-zero exit status 1.
INFO:root:Device 2 is not available for rendering
INFO:root:Using device 0 for rendering
WARNING:root:Environment texture not available, cannot use PBR.
INFO:root:Using cuda device 0 for pytorch
INFO:root:Loading /home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/data/g_dataset/Rs/mesh_z_up.obj
/home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/render/mesh_renderer/mesh_renderer_cpu.py:462: RuntimeWarning: divide by zero encountered in true_divide
  delta_uv1[:, 1] * delta_uv2[:, 0])
/home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/render/mesh_renderer/mesh_renderer_cpu.py:464: RuntimeWarning: invalid value encountered in multiply
  delta_pos2 * delta_uv1[:, 1][:, None]) * r[:, None]
/home/safoex/Documents/code/objectrenderer/igibson/lib/python3.6/site-packages/gibson2/render/mesh_renderer/mesh_renderer_cpu.py:466: RuntimeWarning: invalid value encountered in multiply
  delta_pos1 * delta_uv2[:, 0][:, None]) * r[:, None]
[Object(0)->VAO([0])] [Instance(0) -> Object(0)]
{0: Material(material_type: texture, texture_id: 9, metallic_texture_id:None, roughness_texture_id:None, normal_texture_id:None, color: [0.5, 0.5, 0.5]), 1: Material(material_type: color, texture_id: -1, metallic_texture_id:None, roughness_texture_id:None, normal_texture_id:None, color: [0.5, 0.5, 0.5])} [0]
Render: 71.75 fps, 0.01394 seconds
[many lines of profiler output]

looks like WARNING:root:Environment texture not available, cannot use PBR., can you download the ig_dataset, since the environment textures are there? Or turn off PBR? (by setting enable_pbr=False when creating MeshRendererSettings. thanks!

Many thanks, enable_pbr=False helped, now I have rgb image as well!
However, when I want to render some other object, e.g. one YCB object, I have both screens black :(
I try to substitute model_path with some YCB object path as follows:
model_path = YCBObject('003_cracker_box').visual_filename
# model_path = os.path.join(get_scene_path('Rs'), 'mesh_z_up.obj')

I checked that YCB object models and textures loaded correctly to this path...
How to correctly load YCB objects ?

The solution is to change the camera pose and viewing direction so that the camera points at the YCB object, which is at the location [0, 0, 0].
You can change these lines in mesh_renderer_gpu_example.py to
     camera_pose = np.array([0.5, 0.5, 0.5])
     view_direction = np.array([-0.5, -0.5, -0.5])

and run
python mesh_renderer_gpu_example.py ../../data/assets/models/ycb/003_cracker_box/textured_simple.obj

You should see something like this

I am running with enable_pbr=True. You can download the environment texture (which is needed for PBR, as suggested by Fei above) using the following script:
python -m gibson2.utils.assets_utils --download_ig_dataset

I changed camera pose / view direction and it worked out!
Even better for my case, if I disable pbr by enable_pbr=False, I have YCB object on a black background:

Thanks for prompt reply!! I can close the issue now.


i tried the example but i get a opposite result

The example was missing something, try with:
$.rmFromArray($.range(10), x => x % 2 == 0);

Should work 😊.


Large refactor, addition of Task Manager and conversion to PSQ

This refactors a large amount of the Turbinia code and touches almost everything.  It's still a WiP, but the major refactoring is done and the general flow works end to end.  Here are some of the major changes:

Converts Turbinia from Celery to using PSQ for managing tasks
Implements a Task Manager to manage new evidence to process and creates and manages PSQ tasks.
Adds usage of different Evidence types
Feeds newly created output evidence from Tasks back into Turbinia to be re-processed.
Turbiniactl can add different evidence types, start workers, list jobs and by default (for now) will run the Task Manager indefinitely.

Caveats:

Plaso/BE Tasks are broken
Still lots of TODOs spread throughout the code
Some PubSub code is there, but a lot of it references a previous iteration that was planning to use native PubSub for all task management.  Should probably be mostly ignored for the purposes of this PR, and I will clean it up later.

Thanks!  PTAL.

LGTM