Numeric input is not scaled on HiDPI

part of https://github.com/consulo/consulo-apache-subversion/issues/1


Errno::ENOENT: No such file or directory on to_file

Having an issue to get PDFKit to work. I can let the wkhtmltopdf command run manually, but when using it via pdfkit I get an error.
The error I get:
[1] pry(main)> kit = PDFKit.new('http://google.com').to_file("/tmp/google.pdf")
Errno::ENOENT: No such file or directory @ rb_file_s_size - /tmp/google.pdf
from /home/docking_staging/app/releases/6/vendor/bundle/ruby/2.3.0/gems/pdfkit-0.8.2/lib/pdfkit/pdfkit.rb:190:in `size'

My initializer:
PDFKit.configure do |config|
  config.wkhtmltopdf = ENV['WKHTMLTOPDF_PATH'] || "/usr/local/bin/wkhtmltopdf"
  config.verbose = true
end

My launch script for wkhtmltopdf:
#!/bin/bash
WKHTMLTOPDF="/usr/local/bin/wkhtmltopdf"

xvfb-run /usr/local/bin/wkhtmltopdf $@

Same error also happens if I just pass an html string to the engine.
Thanks!

Did you ever solve this? Having the same problem.

sudo apt-get install fontconfig

I'm running into this problem as well. Has anyone figured this out?

I can confirm I'm having the same issue on Ubuntu.
@entersoftapps this issue is unrelated to fontconfig.

I figured out the problem in my case. I didn't have config.threadsafe! in development.rb.

I am also facing this problem in my production environment. In development env I had to add write permissions to the folder, to be able to write a new file to the specified directory to resolve this. But not able to resolve this in production. Any solutions?

@chizelcoco Perhaps you should try writing to the tmp file in the rails directory instead?
For example:
File.join(Rails.root,'tmp','myfile.pdf')


Document how to use pigeon and update to the latest version.

This mainly splits out the test logic from the messages.dart file.

https://github.com/flutter/packages/pull/246 shows the pigeon changes

This will fail until https://github.com/flutter/plugins/pull/3342 lands.

@Hixie the PR landed, so it should be good now

So the problem now is that I added a file to video_player_platform_interface which video_player can't see because the package isn't on pub yet but I can't use dependency overrides? I'm not sure how to resolve this.
cc @amirh

So the problem now is that I added a file to video_player_platform_interface which video_player can't see because the package isn't on pub yet but I can't use dependency overrides? I'm not sure how to resolve this.
cc @amirh

@Hixie I don't know if this is a bug, but you could publish video_player_platform_interface even if it isn't merged on master.
pub global run flutter_plugin_tools publish-plugin --package=video_player/video_player_platform_interface

@Hixie I don't know if this is a bug, but you could publish video_player_platform_interface even if it isn't merged on master.
pub global run flutter_plugin_tools publish-plugin --package=video_player/video_player_platform_interface

I'm rather terrified of publishing a version of the plugin that I haven't managed to get pass the tests...

I'm rather terrified of publishing a version of the plugin that I haven't managed to get pass the tests...

Yeah, it is a bit cumbersome. For the null-safe work, we ended up having to push one package at the time.
Temporary path dependencies (Just to get the presubmits results) could work as well assuming there's no conflict.

Yeah, it is a bit cumbersome. For the null-safe work, we ended up having to push one package at the time.
Temporary path dependencies (Just to get the presubmits results) could work as well assuming there's no conflict.

From Discord:

<David Iglesias> @Hixie if you use path dependencies on the pubspec.yaml, IIRC, all checks should pass normally (except the 'publishable' one). Then you can prepare a PR only for the platform_interface package, get that merged and published; and THEN go back to this PR, and update it to the version that you just published and see all the tests pass normally again.

From Discord:

<David Iglesias> @Hixie if you use path dependencies on the pubspec.yaml, IIRC, all checks should pass normally (except the 'publishable' one). Then you can prepare a PR only for the platform_interface package, get that merged and published; and THEN go back to this PR, and update it to the version that you just published and see all the tests pass normally again.

Would be great to have contributor documentation on this pubspec version dance as well for landing a change.

Would be great to have contributor documentation on this pubspec version dance as well for landing a change.

Ok I've updated the CONTRIBUTING.md to reflect my understanding of what has to happen (it's in this PR), now we'll see if it works...

Ok I've updated the CONTRIBUTING.md to reflect my understanding of what has to happen (it's in this PR), now we'll see if it works...

I'm really at a loss as to how to get this to pass.

I'm really at a loss as to how to get this to pass.

@Hixie unfortunately, the path dependency is causing a conflict. It looks like the only alternative is to split the PR, so video_player_platform_interface is merged first.

@Hixie unfortunately, the path dependency is causing a conflict. It looks like the only alternative is to split the PR, so video_player_platform_interface is merged first.

Ok, following up in https://github.com/flutter/plugins/pull/3443

Ok, following up in https://github.com/flutter/plugins/pull/3443

One of the failures was a regression in pigeon, work continues in https://github.com/flutter/packages/pull/265

One of the failures was a regression in pigeon, work continues in https://github.com/flutter/packages/pull/265

thanks, will land on green

Format command started to fail after some subsequent changes:
https://github.com/flutter/plugins/blob/3222a3e4458b659d98714722f3ad9577d07c5903/packages/video_player/video_player/CONTRIBUTING.md#L11
Could not find an option named "travis".

Should --travis flag be omitted now?

```
video_player % (cd ../../../; ./script/incremental_build.sh format --travis --clang-format=clang-format-7)
Running for all packages
script/tool/lib/src/main.dart: Warning: Interpreting this as package URI, 'package:flutter_plugin_tools/src/main.dart'.
Unhandled exception:
Could not find an option named "travis".
Usage: pub global run flutter_plugin_tools format [arguments]
-h, --help                             Print this usage information.
--plugins=<plugin1,plugin2,...>    Specifies which plugins the command should run on (before sharding).
--shardIndex=                   Specifies the zero-based index of the shard to which the command applies.
(defaults to "0")
--shardCount=                   Specifies the number of shards into which plugins are divided.
(defaults to "1")
-e, --exclude                          Exclude packages from this command.
--[no-]run-on-changed-packages     Run the command on changed packages/plugins.
If the plugins is specified, this flag is ignored.
The packages excluded with exclude is also excluded even if changed.
See base-sha if a custom base is needed to determine the diff.
--base-sha                         The base sha used to determine git diff.
This is useful when run-on-changed-packages is specified.
If not specified, merge-base is used as base sha.
--clang-format                     Path to executable of clang-format.
(defaults to "clang-format")
Run "pub global run flutter_plugin_tools help" to see global options.
#0      Command.usageException (package:args/command_runner.dart:399:7)
#1      CommandRunner.parse (package:args/command_runner.dart:130:15)
#2      CommandRunner.run. (package:args/command_runner.dart:112:36)
#3      new Future.sync (dart:async/future.dart:218:31)
#4      CommandRunner.run (package:args/command_runner.dart:112:14)
#5      main (package:flutter_plugin_tools/src/main.dart:63:17)
#6      _delayEntrypointInvocation. (dart:isolate-patch/isolate_patch.dart:281:32)
#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
video_player %
</details>


Refactoring features

Coverage decreased (-0.007%) to 83.396% when pulling 5b25b07282b6f52047122f796cd030d274eb9059 on tany:refactor into 22d01a57ad25fa9c93b518f5cb3fd4c3756da2ed on shirasagi:master.


Add print error function (boot.s)

The error_print function
This function will print out in red FlowerOS boot failed, code 0x and then the error code.
 Merging


Example "Command Chaining" doesn't work

The example "Command Chaining" in the online documentation doesn't work:
╭─ Error ──────────────────────────────────────────────────────────────────────╮
│ Unknown option: "--flag".                                                    │
╰──────────────────────────────────────────────────────────────────────────────╯

Process finished with exit code 1

The execution fails on argument parsing and doesn't reach 'main' function.
Using main() directly
    # app.meta(["foo", "123", "AND", "foo", "456", "AND", "bar", "--flag"])
    main("foo", "123", "AND", "foo", "456", "AND", "bar", "--flag")

produces the expected result.
But it looks like "app.meta()" is to be used in that case.

Seems like those docs were a little stale; I updated them in #214 and they should work now. Thanks for opening this issue!


Add metadata to portal to enable rich Twitter card preview

From Rebecca on comms:
"In looking at our social for today, realizing it would be great to make sure we have all the metadata set up to have a Twitter card preview for https://cellxgene.cziscience.com/. Is that possible with how the site is built? Happy to share more on what I'm looking for."
https://czi-sci.slack.com/archives/C024GHUSDQU/p1634690294015000
Link to Twitter card validator: https://cards-dev.twitter.com/validator
Link to tweet that shows no portal card preview: https://twitter.com/cziscience/status/1450499859631407107
Comments:

https://www.netlify.com/blog/2020/05/08/improve-your-seo-and-social-sharing-cards-with-next.js/

{/* Twitter */}
<meta name="twitter:card" content="summary" key="twcard" />
<meta name="twitter:creator" content={twitterHandle} key="twhandle" />

{/* Open Graph */}
<meta property="og:url" content={currentURL} key="ogurl" />
<meta property="og:image" content={previewImage} key="ogimage" />
<meta property="og:site_name" content={siteName} key="ogsitename" />
<meta property="og:title" content={pageTitle} key="ogtitle" />
<meta property="og:description" content={description} key="ogdesc" />

Meta example:
https://www.meta.org/papers/half-a-century-of-research-on-antipsychotics-and/35303594!Screen Shot 2022-03-19 at 3.02.31 PM.png

Will still need an image for the social media card and website description!
branch: thuang-add-open-graph

We will need to change the details when we work out the branding outcomes. I played with including an image of the data portal itself, but because the filters aren't yet released, decided against it. For now, I think the following will work:
Text:
Cellxgene Data Portal
Find, download, and visually explore curated and standardized single cell datasets.
Image:
cc @brianraymor

This is verified in prod!


Improve loading time of Profile page (#1394)

@marcinbodnar can we please load the 'in staking pools' balances after the initial account balance has loaded vs loading them when the user expands the accordion? That way the initial balance still loads instantly and the user doesn't have to wait for staking pool balances if they expand 'in staking pools'

Somewhat related https://github.com/near/near-api-js/pull/492 – we can potentially cut some requests at near-api-js level I think.

@marcinbodnar can we please load the 'in staking pools' balances after the initial account balance has loaded vs loading them when the user expands the accordion? That way the initial balance still loads instantly and the user doesn't have to wait for staking pool balances if they expand 'in staking pools'

@Patrick1904 done, please test, it wasn't so trivial as I thought


Allow query to restrict to certain vocabs

Everything looks good on my end, and runs fine locally. code looks good


Partial AntiSpam Matching

Updated for new TabbyChat beta version.
Includes 2 settings:
-partial matching - enables the feature, default true
-partial matching amount - percent difference of strings to count as a spam match, default 8%
(Not yet applied to GUI)
Tested and working as of this writing.

I did some changes to your pull in d80c1e483d9d2c7125c0c1225401f80136b26b6e. Does everything seem alright to you?

Everything looks good.


Risk on propagating Pinocchio developments

In GitLab by @cmastalli on Feb 13, 2019, 00:01
I'm very concert with the propagation of new developments of Pinocchio (not for v2.0.0) inside crocoddyl. I understand that this is a painful necessity for crocoddyl, however I believe that this isn't a moment for doing it.
1. We have disable CI jobs.
We have been already waiting a lot of time for Pinocchio v2.0.0 release. Really think that each passed minute is a risk for breaking something without any checking. It's very unpleasant joke that after waiting so much we propagate latest Pinocchio developments
2. Example of what we shouldn't do now
In !95, we indeed propagate Pinocchio latest developments (further than v2). This is a huge problem because we won't be able to enable CI jobs for the devel branch. Really? we need to wait more to enable CI jobs??
3. Team working policy
I strongly believe that our priority is having a solid Python software, and then to move to c++ code. Further improvements in Python efficiency are really low priority. Low priorities don't hurt if they don't affect main team efforts.
Additionally, I believe that devel branch has to be tested for our CI support. Any devel should break current code status.
4. How do we deal with this?
Well ... I guess we should have a meeting and make a decision about 3. Nonetheless, if you make a PR where some Pinocchio branch is needed, then you should put in the PR comment.

In GitLab by @cmastalli on Feb 13, 2019, 00:03
changed the description

In GitLab by @ostasse on Feb 13, 2019, 06:56
Dear Carlos,
I do believe that this is related to the way we are doing CI on our repository.
Doing this on binary packages on robotpkg can be done only when we reach a stage where all releases are coherent with each other.
The appropriate solution is to have a dockerfile with the appropriate branches and releases of your dependencies.
While working on a solution which satisfies everyone, you will have to take into account that a CI upon non-released code cannot be put on the sole shoulder of Guilheim.
People developing their code are in charge of identifying the release (prefered solution), branches (possible) of the repositories they depend upon.
I will try to provide tools to generate the appropriate docker file. But right now we do not have the man power to generate the appropriate docker file to everyone.

In GitLab by @proyan on Feb 13, 2019, 09:47
Discussed orally. We'll continue with the development on devel.

In GitLab by @proyan on Feb 13, 2019, 09:49
closed

In GitLab by @nmansard on Feb 13, 2019, 09:51
Summary: we are based on current developments in Pinocchio, so we cannot have another policy. When adding new functionalities in Pinocchio, remember to not break the API, ie:

only add functionalities (new methods) as a rule of thumb.
when 1 not possible (i.e you need to change some existing method), unittest the previous API, and do not change or break the unittest after modifying pinocchio.

If 1 and 2 are respected, we can really expect high-frequency release of pinocchio (e.g once a week).


SEO: individualized content previews for DVC pages (and maybe /doc pages)

Currently preview of contents for all DVC pages has the same info:

Maybe it could have the actual title of each page at least? Ideally also a short excerpt of the beginning of the page contents.

👍 Any ideas how should we customize it depending on a link? The most obvious one - title. Not sure about snippet and image.

Yeah well we have a markdown parses so other than a custom title such as Data Registry | Use Cases | DVC, the text preview could be the first paragraph from the md contents (After H1), truncated to some length.

As for research, these excerpts at least in Slack come from the <meta name="description" tag. I guess we could find out what other metadata Google, Bing, etc pay attention to. Maybe <meta name="keywords"? I understand that's mostly ignored by search engines now a days (they have algorithms to extract keywords from the actual contents instead).

I wonder if we can use an image to put that custom text + logo. And use generic text - so that users always see what DVC is.

can use an image to put that custom text + logo

This is probably possible on more advanced engines, but image rendered text wouldn't help search result ranking.

Yeah, probably I don't care that much about SEO per se (they are good at extracting information), more about user experience when you send a link, share a link.

There's <meta name="thumbnail", or more advanced PageMaps for G we can try.

Related: #982

Hi,
The meta tag is the most important factor for search engines to find out the core meaning if the website. For that we have to enable the open graph protocol with our customised JavaScript engine I hope. I would like to work on this issue.
Thank you.

Currently preview of contents for all DVC pages has the same info:

Maybe it could have the actual title of each page at least? Ideally also a short excerpt of the beginning of the page contents.

I hope <meta property="og:site_name">  is missing in the site. Adding this meta tag would resolve the issue. I will raise a pull request on this.
Thank you.

As for research, these excerpts at least in Slack come from the <meta name="description" tag. I guess we could find out what other metadata Google, Bing, etc pay attention to. Maybe <meta name="keywords"? I understand that's mostly ignored by search engines now a days (they have algorithms to extract keywords from the actual contents instead).

It is, <meta property="og:site_name">  is missing in the site. So we would get the individualised content on the preview.

Hi Team,
I have submitted a pull request to this issue. Kindly check. Thank you.

Any ideas how should we customize it depending on a link? The most obvious one - title. Not sure about snippet and image.

I have made the pull request that could fix this issue. Please check here,
SEO: individualized content previews for DVC pages #1379
Thank you.

I wonder if we can use an image to put that custom text + logo. And use generic text - so that users always see what DVC is.

Yes, I understand this.

The meta tag is the most important factor for search engines to find out the core meaning if the website.

As noted in https://github.com/iterative/dvc.org/pull/1379#issuecomment-636387293 and https://github.com/iterative/dvc.org/pull/1379#issuecomment-636542906 that seems to relate more to #1119. Let's move the conversation there?

I have submitted a pull request to this issue. Kindly check.
I have made the pull request that could fix this issue. Please check here,

Yeah, don't worry, we get the notifications and emails from GH. No need for 2 comments about this 😋 but thanks a lot for the contribution

Currently preview of contents for all DVC pages has the same info:

Maybe it could have the actual title of each page at least? Ideally also a short excerpt of the beginning of the page contents.

When I share I blog link in slack, it's displaying the page title and the image in a smaller size. If we further want to increase the size of the image, we have to work with the Twitter summary of cards with larger dimensions of the picture. So please help me in knowing the absolute requirement of this issue @jorgeorpinel also I have raised a pull request before on this issue with some additional twitter cards on #1379. Kindly help me in this regard to understand the SEO requirement. Thank you

@jorgeorpinel @shcheklein
I can't add image at #1379 so I am referencing here.

Hey @MerlynMShelley thanks. TBH pasting these long vertical emails is not very easy to read so I hid you comment. Can't you just copy/paste the key text from there or paste a link to the reference? I also don't really understand what it is about or why you cant comment in #1379, which BTW is now closed. Don't you have another PR open for this?

Sorry, it's been a few really busy weeks and I'm not keeping close track of things, will need your help to make sure everything you comment is easy to read and in the right context.

If we further want to increase the size of the image, we have to work with the Twitter summary of cards with larger dimensions of the picture

Why is this a Twitter-specific issue? Thanks

help me in knowing the absolute requirement of this issue

The custom image idea comes from https://github.com/iterative/dvc.org/issues/857#issuecomment-565226918 but the goal is to keep both the basic description of DVC and also the excerpt from each page in these previews somehow. It's not a perfectly defined requirement, it needs a creative solution, probably. Any suggestions?
It's a good point that the blog previews already have custom excerpts, it seems cc @shcheklein @rogermparent how can we replicate that everywhere?

why you cant comment in #1379, which BTW is now closed. Don't you have another PR open for this?
Sorry, it's been a few really busy weeks

I see that was your only PR @MerlynMShelley, but it got complicated and was closed. Are you planning to try again with a smaller PR so it's easy to review and follow up on? Or do you prefer to work on something else? I've seen you've commented in https://github.com/iterative/dvc.org/issues/1119#issuecomment-640201071, for example.
Again, this week will probably be a little difficult to work with you very closely so if you have a small, specific, complete contribution you'd like to make, please send a PR 🙂 otherwise let's touch base in a few days.

providing that component the data we want to display in the other templates should do the trick

Sounds worth a shot 🙂

Closing in favor of #1785


[Feature] 🚀Compare the mapping_desc of 2 mappings

Take 2 mappings in parameter
parse them with pyyaml
compute their mapping_descr
compare the two mapping descr (What are the classes in common? What are the properties in common?)

Solved in commit bb289ea8b7f7c02569475e53ae37810bb3b2f483


Buffer name

What's the buffer name for Spaceport?
Context: I need it to disable the statuscolumn(using statuscol.nvim).
I tried spceport, Spaceport and it didn't work.
I tried :lua print(vim.bo.filetype) and it doesn't show anything(not even nil).
I checked the code and found a variable buf but couldn't find a value for it.

Update: Turns out someone just forgot to add a buffername(cause the type is "string" and the length of that string is 0).
The buffername is literally "".
So where is the buffername set?

I dont have a buffer name set right now, but i can publish a change for that later today.
I'll probably set the buffer name to "spaceport.spaceport", with the file extension as "spaceport"

Ok, I just committed the solution:
The buffer name is just 'spaceport', but the file extension is still 'spaceport'
I also added the User SpaceportEnter event that you could also attach an autocmd to instead of detecting the filetype.
All of this is documented in the readme, or by running :h spaceport in neovim

Problem fixed 😃.
Filetype is now "spaceport" and bothe events are emitted properly.
A note for people who might use "statuscol.nvim" and "spaceport.nvim": ft_ignore option won't work on spaceport.
You need to use autocmd to set the statuscolumn to "".

I will be closing the issue now.

I dont think the first problem can be fixed because im setting all the buffer metadata before setting the buffer as the viewed buffer.
The second problem should be a pretty easy fix, just by adding a property to colorOpts, i could have the name be set. I'll probably publish a change for that tomorrow

Totally forgot about that 🤦♂.
Anyway thanks for reminding me.
Guess I will write a wrapper for the recent's part to support highlights(file 🗃 icon highlights). Startup screen is coming along nicely 😁.

I added the ability to make global highlights using the _name property on colorOpts. These highlights can be overridden globally in your config. All these changes are documented in the README


ERROR: Unknown directive type "margin"

Describe the bug
context
When I do sphinx-build -b latex source build\latex\, followed by .\make latexpdf.
expectation
I expect to build my PDF without any warnings.
bug
But instead, Sphinx throws the following error:
ERROR: Unknown directive type "margin"

Sphinx generates the output anyway. But the warning seems to indicate a buggy behavior.
Reproduce the bug

Run: sphinx-build -b latex source build\latex\
Next, type the command: .\make latexpdf

List your environment
Python v3.10.5
Sphinx v4.5.0
sphinx-book-theme v0.3.2
Windows 11 OS

Maybe unrelated, but how can we use the margin directive with rst files?
.. margin:: Some title here
   Some margin note here.

This doesn't work either with the same error:

ERROR: Content block expected for the "margin" directive; none found.


CodeIgniter :-)

https://codeigniter.com
https://github.com/bcit-ci/codeigniter-website/tree/develop/assets/images
If you need more information probably @jim-parry would help.

The CodeIgniter icons are ok to include, the BCIT ones not.

Just added an icon for CodeIgniter, and bumped the project to 0.4.0.
Thanks for the suggestion

Closing for now. Please comment or re-open if the icon is not what you expected.

Thank you.


Hash Function

Create a hash function to hash passwords for security

Noting down we may not actually store passwords and use spotify logins instad

closed because we are no longer hashing passwords


Bug: running optimize() multiple times produces different result compared to running it once

Running optimize(n_iter=1) for 100 times should give the same result as optimize(n_iter=100), but it doesn't. Here is a reproducible example:
n = 100
np.random.seed(42)
X = np.random.randn(n, 2)

from openTSNE.affinity import PerplexityBasedNN
from openTSNE import TSNEEmbedding
from openTSNE.initialization import random as random_init

A = PerplexityBasedNN(X)
I = random_init(n, random_state=42)

E1 = TSNEEmbedding(I, A, random_state=42)
E2 = TSNEEmbedding(I, A, random_state=42)

E1.optimize(n_iter=100, inplace=True)

for i in range(100):
    E2.optimize(n_iter=1, inplace=True)

plt.figure(figsize=(4, 4), layout='constrained')
plt.scatter(E1[:,0], E1[:,1])
plt.scatter(E2[:,0], E2[:,1])

Maybe it has something to do with how the gains are saved in between the optimize() calls?

Hmm, does not look like it's due to gains: if I use 2 iterations instead of 100 in the snippet above, then E1 and E2 are still not identical, yet E1.optimizer.gains and E2.optimizer.gains are the same.

So I figured out what is going on here. update vectors are not save between the optimize() calls, so momentum term has no effect if one uses optimize(n_iter=1). I guess it's debatable what is better, but I would say that if we keep the gains between the optimize() calls, then we should also keep the update vectors.
I prepared a quick PR that implements that but unfortunately it makes some tests fail, and I could not fix it yet.

Thanks for tracking this down. This is definitely a bug. Calling optimize once with iter=100 should definitely be the same as calling optimize 100 times with iter=1.


Update attention template

Ths commit updates the attention
template to include promote operands
and decomposition_config.

Thanks, can you also change this line https://github.com/nod-ai/iree-kernel-benchmark/blob/main/.github/workflows/run_bench.yml#L19 to mi300-sdxl-kernel, so a runner gets picked up for CI

Thanks @saienduri can you "suggest" the change? .. so that I can commit it :). I need to setup ssh on the machine im currently in to change a workflow as PAT does not allow that.

nvm let me setup ssh... I dont think you can suggest as it is not changed in the PR.

Cool, you can also just use the github UI and edit the file on your branch if it's too much trouble

@saienduri thanks for the tip! i did not know about GH UI :o

@saienduri as first timer here, who should merge the PR :) ?

Once you get an approval, go for it :). Merging it now though


fix(chat): Send button indicator

What this PR does 📖

Fix send button not changing color if using emojis

Which issue(s) this PR fixes 🔨

Resolve #695

ticket
vs
app in this branch

there's no emoji button


Missing javascript method html_unescape.

When adding an element to a sortedm2m field through the admin (through a popup).
When saving the instance the popup doesn't close, and there is this single error in the javascript console:
ReferenceError: html_unescape is not defined  (widget.js:91:17).
It apparently can't find the html_unescape javascript function for some reason.
tested with Django1.10.3, django-sortedm2m==1.3.2
if (window.showAddAnotherPopup) {             var django_dismissAddAnotherPopup = window[dismissPopupFnName];             window[dismissPopupFnName] = function (win, newId, newRepr) {                 // newId and newRepr are expected to have previously been escaped by                 // django.utils.html.escape.                 newId = html_unescape(newId);

The javascript function was removed from django in this commit (if that can help.)
https://github.com/django/django/commit/cbaa3ee3ee45d453ab6aa36d57847515dd130b9f

Hey, thanks for the report. Do you have any suggestions on how to fix it? I'm happy for any PR on this topic, so if you are interested, feel free to hack on it.

https://github.com/gregmuellegger/django-sortedm2m/pull/92

My project also needs this, please merge as soon as possible.

merged

https://pypi.python.org/pypi/django-sortedm2m new version 1.3.3 released


Move FixedSizeBinaryArray to array_fixed_size_binary.rs

Signed-off-by: remzi<EMAIL_ADDRESS>Which issue does this PR close?

None. This is a subtask of #2217.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #2218 (425e158) into master (acd8042) will decrease coverage by 0.00%.
The diff coverage is 89.87%.

@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
- Coverage   82.53%   82.53%   -0.01%
==========================================
  Files         239      240       +1
  Lines       62299    62299
==========================================
- Hits        51417    51416       -1
- Misses      10882    10883       +1

Impacted Files
Coverage Δ

arrow/src/array/mod.rs
100.00% <ø> (ø)

arrow/src/array/array_binary.rs
94.80% <75.00%> (+1.93%)
:arrow_up:

arrow/src/array/array_fixed_size_binary.rs
90.37% <90.37%> (ø)

parquet/src/encodings/encoding.rs
93.43% <0.00%> (-0.20%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.75% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


Void functionality

Trying to use omnipay to void payments for beanstream. However, calling beanstream gateway with  ->supportsVoid() call returns false. Do you support void?

Resolved with https://github.com/lemonstand/omnipay-beanstream/pull/4.


fallback-message hiding moved to impress-common CSS file

I’m not home yet, but did the changes rq anyway. Will also close the issue. If anybody else has any suggestions, let me know

I also had the suggestion to hide the fallback-message class from js. I could add that one if you’d like.

Right. I kinda messed up there because I have not really worked with pull requests before

Then it's a good time to give it a second, fresh try? :)

I'm removing all the commits from master and reopening the PR

I also had the suggestion to hide the fallback-message class from js. I could add that one if you’d like.

No, using CSS is correct. The fallback message is content. It may or may not exist, and user may use whatever HTML and CSS class around it.
Everything under impress-common.css is optional, while impress.js is of course not. (Although you could rebuild your own and leave out some plugins.) So as much as possible should be HTML+CSS because that leaves the end user the choice to do whatever they want.

how do I reset my master branch?

Hey @simplePCBuilding, you could jump back to the latest commit of the original impress/impress.js repository, and create a new branch from that.  It says it couldn't read from remote repo... yikes. Anyway. If we could merge the GettingStarted guide, I'd anyway have a clean master branch again. All this mess was caused due to me being new to PRs

I will, once I have a clean master branch again, reopen this PR. I was not willing to delete my fork because I had already done a lot of work when it comes to the website, so I will just delete this branch sooner or later.


Desync Occurred

Product and Version:VSCode
OS Version: Linux
Live Share Extension Version: 1.0.2000
Target Platform or Language: Ruby on Rails
What were you doing when you encountered the desync?
General pair-programming, nothing intense: renaming files, typing text
How often have you encountered desyncs?
Past 2 days

@mlk5060: thanks for filing this issue! We're currently investigating a few desync issues and the rename scenario is often the culprit. If you have consistent repro steps please do let use know as these desync issues can be hard to reproduce. Also, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

Closing as a duplicate of #2086.


Add instructions on how to open terminal

Have a link to this in FAQ from the prerequisite section and running the application section (wherever we mention to open the terminal)


Update enable-admx-backed-policies-in-mdm.md

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/3996
Added two links to notes.

@manikadhiman The PR that addresses issue #3996 is available for review. Thanks.

@ManikaDhiman Following up for updates. Thanks.


Recover from swap file failed on windows ?

Describe the bug
Recover from swap file failed on windows ?
When I using :set dir =$TEMP//
To Reproduce
Detailed steps to reproduce the behavior:

Run cmd.exe and input gvim --clean --cmd ":set dir=$TEMP//" "%ProgramFiles(x86)%\Vim\_vimrc"
Modify some lines and use windows task manager to kill gvim.exe
Then back to Step 1, and choose Recover to restore last modified state.
Gvim will produce E305: No swap file found for _vimrc

Expected behavior
Recover from swap file.
Screenshots

Environment (please complete the following information):

VIM - Vi IMproved 8.1 (2018 May 18, compiled May  8 2019 23:53:53)
MS-Windows 32-bit GUI version with OLE support
Included patches: 1-1296
Big version with GUI.   I am confused, that there are 2 path separators in the dialogue above.

Does it occur in other directory than C:\Program Files (x86)?

so what does :set dir? show? I am confused, that there are 2 path separators in the dialogue above.

Please refer to options.txt about 'directory':
	- For Unix and Win32, if a directory ends in two path separators "//",
	  the swap file name will be built from the complete path to the file
	  with all path separators substituted to percent '%' signs. This will
	  ensure file name uniqueness in the preserve directory.
	  On Win32, it is also possible to end with "\\".  However, When a
	  separating comma is following, you must use "//", since "\\" will
	  include the comma in the file name. Therefore it is recommended to
	  use '//', instead of '\\'.

I know what the meaning of the double path separators in the option dir means. That was not what I meant. What confuses me is that the swapname in the swap exists dialog also contains double slashes. IIRC it should contain an absolute path to the swapfile. Also, I am wondering, if Windows File Virtualization might cause this, since you are trying to access a file below C:\Program Files (x86). So the answer to Kens question is also relevant.

Does it occur in other directory than C:\Program Files (x86)?

Yes! But I got different error message.
To Reproduce
Detailed steps to reproduce the behavior:

Run cmd.exe and input gvim --clean --cmd ":set dir=$TEMP//" ""C:\Tcl\license-at8.6-thread.terms"
Modify some lines and use windows task manager to kill gvim.exe
Then back to Step 1, and choose Recover to restore last modified state.
Gvim will produce E309: Unable to read block 1 from B:\Temp\C%%Tcl%license-at8.6-thread.terms.swp

Screenshots

Gvim will produce E309: Unable to read block 1 from B:\Temp\C%%Tcl%license-at8.6-thread.terms.swp

That is expected if you don't give gvim time to actually write the swapfile.

Gvim will produce E309: Unable to read block 1 from B:\Temp\C%%Tcl%license-at8.6-thread.terms.swp

That is expected if you don't give gvim time to actually write the swapfile.

I  modify some lines and wait about 20 seconds...Then I notice the .swp size changed.
This time will recover successfully.
Some test results

C:\Program Files (x86)\Vim\_vimrc --> E305: ...
C:\Program Files (x86)\Vim\test.log --> E305: ...
C:\Program Files (x86)\test\_vimrc --> Recover successfully
C:\Program Files (x86)\test\test.log --> Recover successfully

Screenshots

so it only happens when you want to edit something in the $VIM installation directory below C:\Program Files (x86)\Vim
I wonder if this could be a permission problem?

so it only happens when you want to edit something in the $VIM installation directory below C:\Program Files (x86)\Vim
I wonder if this could be a permission problem?

No! I changed to using :set dir =$TEMP. It will recover successfully.
So the double path separators will caused this issue when edit files in $VIM.
Screenshots

so does the swapfile actually exists? can you do a :recover .swapfilename?

Reproduced with C:\tmp\x.c. When I terminate gvim, then open the file again, E325 is shown. It says that a swapfile exists and it is actually exists. But when I select Recover, E305 is shown.

Does *.scr is special ?
ps1. test.scr and test.log are new create zero size file, add some lines then wait 20 seconds.
ps2. Set default 'directory' setting by :set dir&
Another weired test results

D:\test.scr --> E305: ...
D:\test.log --> Recover successfully

Screenshots

Just to make sure, does it make a difference whether you use:
:set dir =$TEMP//

or
 :set dir =$TEMP\\

No difference between \\ and // for me.

Just to make sure, does it make a difference whether you use:
:set dir =$TEMP//

or
 :set dir =$TEMP\\

The results are the same. only different is *.swp file name.

I think I found the cause of this.
When editing C:\tmp\x.c and setting dir=C:/swap//, the swap file name becomes C:/swap//C%%tmp%x.c.
The function recover_names() in memline.c, calls expand_wildcards() with the swap file name.
expand_wildcards() expands not only wildcards but also environment variables. The string %tmp% inside the swap file name is expanded as the environment variable. So, Vim fails to find the swap file.
This does happen when a directory name is the same as one of the environment variables.
C:\Program Files (x86)\Vim\foo also fails because we have $VIM.
We should avoid expanding %var% in expand_wildcards() in this case. Maybe we need to add a flag to avoid expanding the environment variables? (E.g. EW_NOTENV)

How about this patch?
--- a/src/memline.c
+++ b/src/memline.c
@@ -1887,7 +1887,7 @@ recover_names(
 	if (num_names == 0)
 	    num_files = 0;
 	else if (expand_wildcards(num_names, names, &num_files, &files,
-					EW_KEEPALL|EW_FILE|EW_SILENT) == FAIL)
+			    EW_NOTENV|EW_KEEPALL|EW_FILE|EW_SILENT) == FAIL)
 	    num_files = 0;

 	/*
--- a/src/misc1.c
+++ b/src/misc1.c
@@ -4020,7 +4020,7 @@ gen_expand_wildcards(
 	    /*
 	     * First expand environment variables, "~/" and "~user/".
 	     */
-	    if (has_env_var(p) || *p == '~')
+	    if ((has_env_var(p) && !(flags & EW_NOTENV)) || *p == '~')
 	    {
 		p = expand_env_save_opt(p, TRUE);
 		if (p == NULL)
--- a/src/vim.h
+++ b/src/vim.h
@@ -808,6 +808,7 @@ extern int (*dyn_libintl_wputenv)(const
 				 * if executable is in $PATH */
 #define EW_DODOT	0x4000	/* also files starting with a dot */
 #define EW_EMPTYOK	0x8000	/* no matches is not an error */
+#define EW_NOTENV	0x10000	// do not expand environment variables

 /* Flags for find_file_*() functions. */
 #define FINDFILE_FILE	0	/* only files */

How about this patch?

It's simpler than I expected.  Should be OK to include.
How about a test?
--
CRONE:  Who sent you?
ARTHUR: The Knights Who Say GNU!
CRONE:  Aaaagh!  (she looks around in rear) No!  We have no licenses here.
"Monty Python and the Holy editor wars" PYTHON (MONTY) SOFTWARE LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I think I found the cause of this.
When editing C:\tmp\x.c and setting dir=C:/swap//, the swap file name becomes C:/swap//C%%tmp%x.c.
The function recover_names() in memline.c, calls expand_wildcards() with the swap file name.
expand_wildcards() expands not only wildcards but also environment variables. The string %tmp% inside the swap file name is expanded as the environment variable. So, Vim fails to find the swap file.
This does happen when a directory name is the same as one of the environment variables.
C:\Program Files (x86)\Vim\foo also fails because we have $VIM.
We should avoid expanding %var% in expand_wildcards() in this case. Maybe we need to add a flag to avoid expanding the environment variables? (E.g. EW_NOTENV)

Good catch.  Yes, adding an EW_NOTENV sounds like the right solution.
There already is  EW_NOTWILD, perhaps that would work?
--
FIRST VILLAGER: We have found a witch.  May we burn her?
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

There already is EW_NOTWILD, perhaps that would work?

That might not work, because we still need to expand ?. E.g. C:/swap//C%%tmp%x.c.sw?.
(My previous comment was a bit incorrect. I forget to add .sw? at the end of the swap file name.)

How about a test?

Hmm, I have no idea how to test this at all.
We need to edit a file with Vim and terminate Vim, then open the same file again. And when E325 is shown, select "Recover", and make sure that E305 is not shown. I don't know whether we can do this automatically.

There already is EW_NOTWILD, perhaps that would work?

That might not work, because we still need to expand ?. E.g.
C:/swap//C%%tmp%x.c.sw?.
(My previous comment was a bit incorrect. I forget to add .sw? at
the end of the swap file name.)

OK, we do need a new flag.

How about a test?

Hmm, I have no idea how to test this at all.
We need to edit a file with Vim and terminate Vim, then open the same
file again. And when E325 is shown, select "Recover", and make sure
that E305 is not shown. I don't know whether we can do this
automatically.

This probably requires running Vim in a terminal window.  The swap file
can be created by having Vim create one, make a copy, exit Vim, then put
the copy in place of the original swap file.  Then start Vim for
recovery and use term_sendkeys() to have it do its thing.  Check the
expected behavior with either term_scrape() or a screenshot (that might
show a different path on different machines, then it doesn't work).
--
I have read and understood the above. X________________
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

How about this patch?
--- a/src/memline.c
+++ b/src/memline.c
@@ -1887,7 +1887,7 @@ recover_names(
 	if (num_names == 0)
 	    num_files = 0;
 	else if (expand_wildcards(num_names, names, &num_files, &files,
-					EW_KEEPALL|EW_FILE|EW_SILENT) == FAIL)
+			    EW_NOTENV|EW_KEEPALL|EW_FILE|EW_SILENT) == FAIL)
 	    num_files = 0;

 	/*
--- a/src/misc1.c
+++ b/src/misc1.c
@@ -4020,7 +4020,7 @@ gen_expand_wildcards(
 	    /*
 	     * First expand environment variables, "~/" and "~user/".
 	     */
-	    if (has_env_var(p) || *p == '~')
+	    if ((has_env_var(p) && !(flags & EW_NOTENV)) || *p == '~')
 	    {
 		p = expand_env_save_opt(p, TRUE);
 		if (p == NULL)
--- a/src/vim.h
+++ b/src/vim.h
@@ -808,6 +808,7 @@ extern int (*dyn_libintl_wputenv)(const
 				 * if executable is in $PATH */
 #define EW_DODOT	0x4000	/* also files starting with a dot */
 #define EW_EMPTYOK	0x8000	/* no matches is not an error */
+#define EW_NOTENV	0x10000	// do not expand environment variables

 /* Flags for find_file_*() functions. */
 #define FINDFILE_FILE	0	/* only files */

I have tested your patch. Its almost fixed this issue...but still can't recover for *.scr ?
I can recover only by input :recover B:\Temp\B%%test.scr.swp
Screenshots

Another weired test results

"C:\Tcl\test.log" --> Show only one swap file can recover
"%ProgramFiles(x86)%\Vim\test.log" --> Show two swap file can recover

Screenshots

Another weired test results

"C:\Tcl\test.log" --> Show only one swap file can recover
"%ProgramFiles(x86)%\Vim\test.log" --> Show two swap file can recover

Okay, I found the cause of this.
In recover_name(), fullpathcmp() is used to compare the swap file names, and if it matches with the current swap file ("*%test.log.swo" in this case), it is removed from the list. However, fullpathcmp() also expands the environment variables, so it doesn't match and causes the problem.
Maybe we should add a flag to fullpathcmp() not to expand the env variables?
Not sure about *.scr.

Add a test:
https://bitbucket.org/k_takata/vim-ktakata-mq/src/c3ec1efe18c3cd759e5969f2de8e10a9b108f44d/test-for-4369.patch?at=default
And updated the patch:
https://bitbucket.org/k_takata/vim-ktakata-mq/src/be1422cf12d00fb0f9af560d7ddc1cf42214d7ed/fix-4369.patch?at=default

About *.scr, it also occurs on Linux, not only on Windows. So, it's different from the env var expansion.
It seems that *.s?? is (wrongly) considered as a swapfile at here:
https://github.com/vim/vim/blob/5c017b2de28d19dfa4af58b8973e32f31bb1477e/src/memline.c#L1131-L1148

I created a PR for the two issues #4415.

I created a PR for the two issues #4415.

All test pass. Thanks everyone! :)


Add styling implementation

Resolves #18, based on the implementation in #13 by @mjablecnik.
TODO

[x] main Style class with .raw and .combine factories
[x] Color
[ ] .text() style
[ ] .background() style
[ ] .box() style
[ ] .flex() style
[ ] .grid() style
[ ] .position() style

Will be continued in the wip/v0.2 branch


Add and configure renovate to pin k8s and controller-runtime for dev preview

pin k8s and controller runtime to be in sync with lib-common and configure renovate to keep the pin
pin ocp api version to a hash in sync with lib-common instead of the nonexistent v3.9.0+incompatible tag

Also @gibizer we should onboard swift to renovate


Dynamic Programming: Leetcode: 188. Best Time to Buy and Sell Stock IV

I want to upload solution for this problem, It will be helpful If you can assign this issue to me.

can i work on this probleam ?

Hey! Shall i work on this issue?

Hello, @gantavyamalviya I have added code for this problem in the above pr please review it.


Silencing 'loading in progress, circular require considered harmful'

/Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2: warning: loading in progress, circular require considered harmful - /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:4:in  `<main>'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:4:in  `select'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:15:in  `block in <main>'
  from /Users/tj/.rvm/gems/ruby-2.3.0/gems/rake-11.1.2/lib/rake/rake_test_loader.rb:15:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/test/integration/consumer_test.rb:1:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/test/integration/consumer_test.rb:1:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/test/test_helper.rb:14:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/test/test_helper.rb:14:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth.rb:9:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth.rb:9:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb:2:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/helper.rb:2:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/consumer.rb:4:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/consumer.rb:4:in  `require'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2:in  `<top (required)>'
  from /Users/tj/github/opensource/oauth-ruby/lib/oauth/client/net_http.rb:2:in  `require'

Can you issue a new gem release with this fix? (and other warning messages etc.) to silence the warning noise on Rubies >= 2.3.1

Sure, give me some 30 minutes and I'll release it

@matthutchinson done

Wow, that was fast! Thanks ! 👍


feature: re-read .lazy.lua when changing directory

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
My workflow usually involves using my session plugin to select one of my sessions, which will then most likely change my cwd. However, this change doesn't source a .lazy.lua in the new directory.
Describe the solution you'd like
Changing the current working directory should trigger a reload of .lazy.lua, if possible.
Describe alternatives you've considered
An alternative would be to integrate with possesion's hook system to trigger the reload, but I'm not sure how to that on lazy.nvim's side.
Additional context
A similar issue was raised with neovim's .nvim.lua, but it was later closed as not planned, as it caused some controversy.

That's not really something that can easily be added since the full state of your plugins has already been calculated.


host.publicEndpoints not updated when ports are changed/added when editing container.

Server version - v0.47.0-rc1
Deploy a container with exposed port in host1.
host.publicEndpoints includes information about the exposed port.
Edit container and add an additional exposed port/edit existing port and change its value.
host.publicEndpoints information does not include information about the new port added/ the port that was edited.

Tested with build from master:
host.publicEndpoints is updated when existing ports are changed when editing container.
But host.publicEndpoints not updated when new ports are added when editing container.

Tested with rancher server version - v0.47.0-rc2.
host.publicEndpoints gets updated when new ports are added when editing container.


Modernize 0.10.2

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

This simple PR:

Modernizes the v0.10.2 package building against python 3.9 (note that 0.11 seems an unreleased version)
Fixes the download URL (otherwise checksum fails)
Disables windows builds (pytorch is not build for win in CF, using pytorch-cpu might be an option)

This compiles just fine now (see it in my personal channel, sdvillal::fairseq). It would potentially alleviate the pain of a few users (1 and 2), or at least give some hints as of why #16 and #14 fail.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sdvillal Any chances of this getting merged soon ?

@maclandrol I do not have rights.

@conda-forge/core could you merge this PR or give the correct permissions to @sdvillal to do it please?

Thank you @hmaarrfk


v0.0.2: Pinning Summit + initial feedback

This version is  following spec drafted during Pinning Summit where we switched API to operate on "pin objects" with some improvements based on initial feedback and discussions received from the community this week.
This is by no means the finished spec: goal is to close some topics and kick-off discussions on remaining items.
Changes in this PR
:question: – needs clarification or further discussion
⁉– potentially controversial

[x] Changes from Pinning Summit, namely change API to operate on "pin objects" (closes #2)

[x] Replaced vendors-specific fields such as replicationParam with a free form meta

[x] Basic pagination with skip and limit parameters (closes #12)
[x] Added ability to filter pin objects using arrays of CIDs and/or statuses (closes #1)
[x] :question: simplified authorization based on opaque string that can be passed in HTTP header or query param, as suggested by @mikeal in https://github.com/ipfs/pinning-services-api-spec/issues/6#issuecomment-655056961
[x] Examples and missing descriptions
[x] :question: Status enum in which pin object can exist at a pinning service
(for now those are just strings)
[x] ⁉ replaced "pin type" with more flexible depth
It can represent direct (0) and recursive (-1) pins just fine, but opens more advanced strategies in the future.
[x] ⁉ GET /pins/?cid=Qm&depth=1 could return pin status of arbitrary subtree
(open question: how to represent indirect pins in PinStatus object? add indirect Status enum?)

Documentation Preview
Docs for feat/pinning-summit-variant-v0.0.2 branch can be viewed at:

https://bafybeibarvujzcxuqikzdb22pzdbza4hz4rdvaagrcunjs7zhaqamw46ku.ipfs.dweb.link/

cc @pooja @jacobheun @aschmahmann @achingbrain @autonome @gozala @momack2 @olizilla
@obo20 @sanderpick

⁉ replaced "pin type" with more flexible depth
It can represent direct (0) and recursive (-1) pins just fine, but opens more advanced strategies in the future.
⁉ GET /pins/?cid=Qm&depth=1 could return pin status of arbitrary subtree
(open question: how to represent indirect pins in PinStatus object? add indirect Status enum?)

I'm not sure if filtering based on pin depth is possible right now. As far as I'm aware all current pinning services (including Pinata) only track pinned items by the root CID.

@obo20 fair enough. I believe we should be ok with removal of depth filter, as long cid filter accepts an array of CIDs to keep at least one way of addressing need described in #1

This overall seems fine to me, although I've got a few thoughts/questions about pinning service flow and the pinning objects we're introducing here.

My concern is that if users are expecting something like ipfs pin add --with-service=mypinner QmXYZ to immediately ship the data to the pinning service that we could run into problems if QmXYZ is not already published to the DHT
This becomes worse with the pinning objects since we'll generate a new pin object that we'll have to wait for the DHT to finish providing before the pinning service can find the data. We'll likely want to not even send the HTTP request until the DHT put is completed

We can work around this by pre-connecting to a pinning service upload IPFS node, if that's available, but since my understanding was that having one of those was not a requirement for implementing this API it's a shame that users may have to wait for a DHT provide to finish before the pinning can start
If we expect users to have many different pin objects that they'll be providing to the network they could get bogged down in the provide queue. How many pin objects do we expect an "average" user to create if they are pinning N objects?
If we could send the pin object over HTTP then this problem basically goes away

@aschmahmann good catch! I failed to document that aspect, fixed now.
Pinned data may not be present at a pinning service and at the same time pin object creation should not be a blocking operation. User may be pinning big data set that takes time to transfer and we don't want CLI and other tools to hang. Instead of waiting for remote pinning to finish, cid-of-pin-object is returned immediately in PinStatus response, and can be used for periodical status checks later.
I've added Pin object lifecycle to the spec and missing PinStatus  responses required for async status checks of ongoing pinning operations.
Pin status/progress check can be done via GET /pins/{cid-of-pin-object} or GET /pins?cid={cid-being-pinned}.
Q: how specific should the status reporting be?
Right now Status is an enum string with values like "pinning" vs "pinned", but I wonder if ability to return % value would be more flexible / useful for UIs here. Thoughts?

Right now Status is an enum string with values like "pinning" vs "pinned", but I wonder if ability to return % value would be more flexible / useful for UIs here. Thoughts?

I'd skip this for now. This could come back in the meta object for pins that are in progress.

Q: how specific should the status reporting be?
Right now Status is an enum string with values like "pinning" vs "pinned", but I wonder if ability to return % value would be more flexible / useful for UIs here. Thoughts?

I don't think % pinned is currently possible, but we could certainly provide statuses that signify the object is currently being fetched. For reference, this are the current statuses we have in Pinata's system when pinning by CID.

"prechecking" - Pinata is running preliminary validations on your pin request.
"searching" - Pinata is actively searching for your content on the IPFS network. This may take some time if your content is isolated.
"retrieving" - Pinata has located your content and is now in the process of retrieving it.
"expired" - Pinata wasn't able to find your content after a day of searching the IPFS network. Please make sure your content is hosted on the IPFS network before trying to pin again.
"over_free_limit" - Pinning this object would put you over the free tier limit. Please add a credit card to continue pinning content.
"over_max_size" - This object is too large of an item to pin. If you're seeing this, please contact us for a more custom solution.
"invalid_object" - The object you're attempting to pin isn't readable by IPFS nodes. Please contact us if you receive this, as we'd like to better understand what you're attempting to pin.
"bad_host_node" - You provided a host node that was either invalid or unreachable. Please make sure all provided host nodes are online and reachable.

Obviously not all of these would apply to every service, but I do think it would be good to have a standard set of statuses that we can all agree on.


lettuce-eventExecutorLoop are still in blocking state when my application is idle

My application has connected to three different redis clusters. we have created three redisClusterClient corresponds to every redis cluster.
Machine config:- 8 core
Lettuce client version :- 5.2.2.RELEASE
When there was traffic on server:-

There were total 128 threads those prefix is "lettuce".

Total number of threads whose prefeix is lettuce-nioEventLoop = 64(All are in runnable state)

Stack trace for lettuce-nioEventLoop :-
stackTrace:
java.lang.Thread.State: RUNNABLE
at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method)
at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269)
at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93)
at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)

locked <0x00000005cc93e520> (a io.netty.channel.nio.SelectedSelectionKeySet)
locked <0x00000005cc93e510> (a java.util.Collections$UnmodifiableSet)
locked <0x00000005cc93e4c8> (a sun.nio.ch.EPollSelectorImpl)
at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
at io.netty.channel.nio.SelectedSelectionKeySetSelector.select(SelectedSelectionKeySetSelector.java:68)
at io.netty.channel.nio.NioEventLoop.select(NioEventLoop.java:803)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:457)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:745)
Locked ownable synchronizers:
None

Total number of threads whose prefeix is lettuce-eventExecutorLoop = 64(56 in WAITING state , and 8 in TIMED_WAITING)

Stack trace for lettuce-eventExecutorLoop :-
stackTrace:
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)

parking to wait for <0x00000005ccebcf78> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
at io.netty.util.concurrent.SingleThreadEventExecutor.takeTask(SingleThreadEventExecutor.java:243)
at io.netty.util.concurrent.DefaultEventExecutor.run(DefaultEventExecutor.java:64)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:745)
Locked ownable synchronizers:
None

When there was no traffic(for almost 20 hours) on server:-

There were total 128 threads those prefix is "lettuce".

Total number of threads whose prefeix is lettuce-nioEventLoop = 64(All are in runnable state)
stack trace is same as above

Total number of threads whose prefeix is lettuce-eventExecutorLoop = 64(56 in WAITING state , and 8 in TIMED_WAITING)
stack trace is same as above

Questions:-

Why even after no traffic on server "lettuce-eventExecutorLoop"  threads are in wating state ?? May be because of this  RedisCommandTimeoutException exception if we make it live again with out restarting this machine.
How many number of event-loop, ettuce-eventExecutorLoop threads(maximum) will be created if connected with three redis cluster and have three redisClusterClient?

There were total 128 threads those prefix is "lettuce".

Lettuce creates up to 2 x (CPU Count) Threads (I/O and computation thread pools). You can tweak these settings through ClientResources. Generally, when creating multiple RedisClient instances, make sure to reuse ClientResources to avoid excessive resource usage. See also https://lettuce.io/core/release/reference/index.html#advanced-usage.

Why even after no traffic on server "lettuce-eventExecutorLoop" threads are in wating state

Because that's how netty works. Event loop threads poll on their work queue.

@mp911de, sorry to bring this up, I have a simple spring boot app locally that just has a controller, and its connecting to Redis running on Docker. I have spring-boot-starter-data-redis, and not using any custom ClientResource. I am using VisualVM to monitor my threads. Once the app has started, i see that a couple of lettuce-nioEventLoops exist for the redis connection. But when i restart redis (while the app is running), more threads (lettuce-nioEventLoop) are created. This is fine. However, is it expected behavior for the old threads to remain? My assumption was that lettuce would close the old threads.


Fixing Libiio build

Motivation for this change
Closes https://github.com/NixOS/nixpkgs/issues/124948
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Not sure why but this fixed the build.
It seems similar to https://github.com/bincrafters/community/issues/930.

Result of nixpkgs-review pr 124951 at e26ad6c6 run on aarch64-linux 1

2 packages skipped due to time constraints:

libiio
sdrangel

3 packages built successfully:

python38Packages.libiio
python39Packages.libiio
urh

1 suggestion:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/development/libraries/libiio/default.nix:26:15:
   |
26 |   patches = [ ./cmake-fix-libxml2-find-package.patch ];
   |               ^

Thanks for the fix! Can you please base it against staging?

Thanks for the fix! Can you please base it against staging?

 Or the rebase action has been broken lately, as this is not the first time I see this. Could you open a PR against master, please?

This PR needs a rebase.
It appears that github removed more requests for review; I only intended to remove myself because the list was excessive.


Gemma Onnx suuport

System Info
My system currently is
python = 3.8
optimum-intel : optimum-1.18.0.dev0

Who can help?
@JingyaHuang  @echarlaix
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)
I am following the provided examples on #1714 but am running into some issues.
when I run
optimum-cli export onnx -m google/gemma-2b gemma_onnx
I get the following error

When I execute the python script provided I get the following error

Expected behavior
The expected behavior is for the model to compile and be stored in onnx form

Answered on the other thread

@fxmarty can you give me your version of optimum and transformers? I am running in the latest version and still have the error:
ValueError: Trying to export a gemma model, that is a custom or unsupported architecture, but no custom onnx configuration was passed as custom_onnx_configs. Please refer to https://huggingface.co/docs/optimum/main/en/exporters/onnx/usage_guides/export_a_model#custom-export-of-transformers-models for an example on how to export custom models. Please open an issue at https://github.com/huggingface/optimum/issues if you would like the model type gemma to be supported natively in the ONNX export.
I am using the same command that you are using

@fxmarty I encountered the same issue with this project as well while adding 'google/gemma-2b-it' as a LLM option.
openvino-llm-chatbot-rag
cc @tchen48

you'll need to install from main pip install optimum@git+https://github.com/huggingface/optimum.git for gemma support

Closing as supported on main.


Create a handler channel per collector

We have seen a lot of contention between different collectors over the
single metrics channel provided to write to handlers. Also given that
handlers were only reading on one channel we made a parallel colleciton
system eventually single threaded which killed performance and also
caused a lot of strange behaviours relating to emissions to the
different storage backends, like missing aggregation buckets which for
cumulative counters leads to saw toothed charts
This commit makes sure that each collector has a dedicated channel to
it's handlers and each handler spins off a go routine for responding to
that channel. What that eventually means is that we can tolerate any
contention raising from an aggressive collector on one channel since it
can only affect itself and its own emissions.

Part of me was thinking - it will be better to have one complete handler instance per collector, rather than having per-collector channel (via channels map that handler stores).
At the end of day, channel best communication is expensive because it requires lock on two sides of channel and maximum throughput can be achieved by not using channels at all. So what if - the collector had one or two instance of handlers and metrics are directly emitted to handler without using a channel.
Handler still does batching and actual emit can still happen in a goroutine, but handler basically becomes a property of collector.

@gnufied Initially I had a similar idea as per the tracking ticket internally, however that changed for the following reasons:

Having a handler er collector means we will have N open http connections where N is the number of collectors, this means that the receiving end will suddenly have to deal with an N x increase in inbound connection
having stats per handler will become very convoluted since we have multiple of the same handler and determining which handler is doing what and keeping track of all of them in the internal metric server will become difficult to follow especially for calculations like min, max, percentiles etc,
concurrency in go has been made around the use of channels and it has been built around it really so I would rather use that behaviour for concurrency than coming up with an object level parallelism which is basically throwing all that away. Channels hold locks on both sides that is true, however with this new approach with multiple channels the number of times the lock is held is significantly decreased since now the demand for the channel has ben spread among many channels unlike the old behaviour where there was one central channels.

:shipit:

Please consider earlier shipit on this invalid. I need to have a look at again. this is for my own understanding more than anything else. :-)

lgtm! Well aside from @gnufied 's comment about the CononicalName causing issues for multi-instance collectors being handled.

:shipit:

Hold off on merging this, I will experimenting with something and then merge it, my experimentation work will not affect the current code

I was able to get that same bug in go 1.4.1 and go 1.5.1 and go 1.5.2 (check the relevant travis builds) so this seems to be non compiler related, it looks like a flaky test, since the same test would sometimes pass and other times fail


Treat edge blocks as cold if they generated as part of a cold block

This modifies the lowering stage to mark edge blocks as cold if either the predecessor or successor block is cold.
This provided significant runtime speedups (~11%) for my code (which is severely frontend bound).
Fixes: #4635

I had intended to write a follow up comment to discuss this issue - here it is now:
There are two main uses of cold blocks I can think of:

Cases where there is code that needs to be executed in rare circumstances (e.g., error handlers).

Situations where a value is obtained via two (or more) different paths of code, one significantly rarer than the other (in my case, this corresponds to a fast path from a cache hit, and a slow path that needs to recompute the value).

These have different behaviour with respect to the edge blocks they generate (Note: overall Cranelift seems to do a decent job at avoiding extra edge blocks in many cases):
In 1., the cold block might be shared (e.g., a common return for all error cases), and so might require an edge block along the incoming edge. However, simple cases may never need to jump back to a shared block, so don’t require an edge-block on outgoing edges.
In 2., the cold block only as a single incoming edge so doesn’t require any moves to occur along the incoming edge (at least as well as I can understand). However, since the cold path rejoins the hot path, it frequently requires an edge block on the outgoing edge to ensure that the values.
Admittedly, I was only thinking of 2. when I changed the heuristic (to attempt to solve the issue below), so my intuition was that there would never be an edge-block that contained for the incoming edge.
An issue I observed (as a result of the existing cold-blocks test: isa::x64::test::test_cold_blocks), is that there is a subtle interaction of this change with trivial edges (i.e., edges without any moves) that occur when the cold path is reached as part of an untaken branch.
e.g., if we have:
block0:
    brnz v1, block2
    jump block1

block1 cold:
    ; ....

block2:
    ; ...

If block1 is shared, then Cranelift seems to generate something equivalent to the following:
block0:
    brnz v1, block2
    jump block0_to_block1_edge

block0_to_block1_edge:
    jump block1

block1 cold:
    ; ....

block2:
    ; ...

Normally the redundant block0_to_block1_edge jump is eliminated because it acts as a "fallthrough" to the next block, however if it gets marked as cold then it is no longer a fallthrough block and we end up with a redundant jump, e.g., see the branch at 0x23 below:
.00:  push    rbp
.01:  mov     rbp, rsp
.04:  add     edi, 0x1234
.0a:  test    edi, edi
.0c:  je      0x2e

.12:  mov     r8, rdi
.15:  mov     rax, rdi
.18:  sub     eax, 0x1234
.1e:  sub     eax, r8d
.21:  test    edi, edi
.23:  jne     0x46

.29:  mov     rsp, rbp
.2c:  pop     rbp
.2d:  ret

.2e:  mov     r8, rdi
.31:  add     r8d, 0x1234
.38:  test    r8d, r8d
.3b:  jne     0x2e
.41:  jmp     0x15

.46:  jmp     0x2e

I originally slightly misunderstood what was going on and believe that removing the heuristic that propagated the cold annotation to incoming edges would fix the redundant branch (in combination with my assumption that all edges to cold blocks would not contain any moves). However, this is not really the case, and the same issue can crop up in the cold->hot edge case as well.
In summary: I think it makes sense to re-enable the heuristic for edges with cold blocks as successors, however in both cases we can end up with a redundant edge in some cases.

OK, I see; it would be helpful to see the actual CLIF that generates the disassembly (the edge block 0x46 being placed after the block it leads into at 0x2e is very surprising; RPO sort should place preds to the block before the block itself, absent any cycles among the cold blocks, and assuming the pred edge block and main cold block are both marked cold and sunk accordingly). If you want to dig into it further, in addition to the RPO sort you see in blockorder.rs, this code does the actual sinking at the last second, during emission (we do it this way because we need to generate vcode in postorder to see uses before defs).
In the meantime I'd be happy to merge this with the heuristic returned to "edge is cold if pred or succ is cold"; that seems pretty reasonable and robust to me.

I've reverted the commit back to the "edge is cold if pred or succ is cold" heuristic.

The assembly code came from the test here: https://github.com/bytecodealliance/wasmtime/blob/0b1f51f80427a79fbd7d77849f7e2301a1d128f5/cranelift/codegen/src/isa/x64/mod.rs#L219
I translated it to CLIF:
function %test_cold(i32) -> i32 {
block0(v10: i32):
    v0 = iconst.i32 0x1234
    v1 = iadd.i32 v10, v0
    brnz v1, block1(v1)
    jump block2

block1(v20: i32):
    v2 = isub.i32 v1, v0
    v3 = iadd.i32 v2, v20
    brnz v1, block2
    jump block3(v3)

block2 cold:
    v4 = iadd.i32 v1, v0
    brnz v4, block2
    jump block1(v4)

block3(v30: i32):
    return v30
}

Looks like there is a cycle.

@mchesser I fixed the redundant-jump issue over in #4652 just now -- thanks for noticing this!


Add list of software libraries for image-based profiling workflows

At present, we have only cytominer.
Here are others I could think of

scanpy
PurifyR

We now also have

pycytominer

Also one could add CellPose ?
http://www.cellpose.org/


[Breadcrumbs] Breadcrumb on Mobile

Description
Extension to the breadcrumb in Carbon 10 to support mobile use cases within applications that have extensive nested navigation
Name of Pattern or Asset
Breadcrumb
User outcome
User can easily navigate up a breadcrumb trail on a phone
Proposal
Do you have a proposed solution? or something you have tried already?

Additional context
Trick here is to avoid wrapping, which would consume a majority of the screen. If we want to suppress wrapping, I recommend we suppress it entirely (rather than saying 2-line max). To make this work, we will need to programmatically determine the container size at runtime and trunkate the first and last breadcrumb so that the overflow (center menu) is directly in the middle of the container (which will need to be full-width on mobile but may be smaller on desktop).

PAL tracking issue: https://github.ibm.com/Watson-IoT/pal-tracking/issues/18
assigned to https://github.ibm.com/cswangbj. waiting to hear about their public github account to assign.

Hi, cause the space efficient function in Carbon-core Breadcrumb hasn't been finished. So I  implement it in here. Although I have finished it, there are something I am not sure: in Carbon-angular ``

I've opened an issue, https://github.com/carbon-design-system/carbon/issues/4815, to discuss the implementation with the Carbon team in aim to potentially contribute this directly to carbon-components-react

@lukefirth @JordanWSmith15 Guidance from the Carbon spec shows we should use the overflowMenuHorizontal icon as it is centered vertically, not an ellipsis

@tay1orjones They seem to have a bit of inconsistency in their own site. The "usage" tab shows this: https://www.carbondesignsystem.com/components/breadcrumb/usage/
I have zero preference.


fix stage out

Fix stageout configuration. Adding parameters for personal storage as backup endpoint

Closing since these changes have been already included in the master.


Decrease timeout for faster test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5654/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5660/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5692/
Test PASSed.

Jenkins, test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5694/
Test PASSed.

Jenkins, test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5695/
Test PASSed.

alluxio-bot, merge this please

The last build took 29 minutes :O


can't generate UClass body in the SomeService_Private.h in case bidirectional streaming

for example some.proto
service SomeService
{
   rpc SomeStream (stream SomeRequest) returns (stream SomeResponse);
}

after generation - in the SomeService_Private.h will be #include "SomeService_Private.generated.h"
but without UClass LambdaWrapper, that contains wrappers OnResponse, OnContextStateChanged and InnerClient, Handle etc.
in case SomeRequest without stream - all is ok.
@thejinchao could you give some hints please

and I realize now, thanks for your Demo!, that there are - no need to generate .generated.h . because all behavior will be through client context directly, not through the client by Call.


Fixed Type Declaration for toArray Method in Collection

Pull Request Description: Fixed Type Declaration for toArray Method
Overview:
This pull request addresses an issue with the type declaration in the toArray method within the Laravel framework. The current type declaration always returns mixed type whatever the data in collection.

I don't think this PR correctly resolves what type should be used, since toArray will also convert any underlying Arrayable classes to its mixed type whenever possible.

Thanks for the feedback.
In order to further investigate the matter, I conducted a test using the following example.
/**
 * Class ArrayModel
 *
 * @implements Arrayable<string, int>
 */
class ArrayModel implements Arrayable{
    public function toArray()
    {
        return [
            'id'=>1
        ];
    }
}

assertType('array<string, int>', collect(new ArrayModel)->toArray());
assertType('array<int, ArrayModel>', collect([new ArrayModel])->toArray());

The first assertion confirms that the type is directly inferred from the Arrayable type. Moreover, in the case of an array containing instances of such a class, the type is identified as an array of the Arrayable class.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Add cpp/winrt implementation

Overview

Adding cpp/winrt implementation and a sample app.
Closes: https://github.com/microsoft/react-native-windows/issues/4390.
Test Plan

System requirments.
yarn install
yarn start:windows
Open example/windows/NetInfoExample.sln with Visual Studio and run.

👋 Thanks for the contribution! I've never used React Native on Windows, so can you clear up  a few questions for me:

This library already had Windows support. How is this implementation different?
Assuming it is different, can the two implementation coexist?
Is this a breaking change for users of this library on Windows?
Would you be able to help to maintain this implementation once it's merged in? As I don't have a Windows development environment, I'll need help with dealing with bug reports and general maintenance when things come up.

@matt-oakes if I understand correctly react-native-windows just went from a C# implementation for older versions to a C++ implementation going forward, which requires native react-native-windows to switch their implementations. I haven't done that for device info yet but if I received a pull request like this that did it I'd be a happy man

@mikehardy Sounds good! As I don't use RN Windows I had no idea about the language change. Happy to include it in the library for those that need it though!
Would still be useful to get some more details about backward compatibility and maintenance going forward 👍

Hi @matt-oakes, as @mikehardy mentioned react-native-windows just switched from C# to c++ implementation for better performance, and we want to provide c++ implementation for native modules as well for the same purpose. Feature-wise, C++ and C# are the same for now (I pretty much just re-wrote the existing C# code in C++).
Those 2 implementations can coexist. I think we need to keep both in for a while since this c++ version only works on RN 61+. Going forward, we'll probably want to move over to C++, since it can be consumed by both C++ and C# apps and has better performance.
It's not a breaking change as long as we keep the C# implementation.
Yes we'll help maintain it going forward. There are a few teams inside Microsoft working on this RN Windows effort and many more teams depending on the work, NetInfo c++ implementation was one of our internal partner asks, so we'll definitely help keeping it up-to-date : )

I'll keep my fingers crossed one of your internal partners or teams also wants react-native-device-info 😄 🤞  - device-info has a c# implementation right now and github action contributed by an MSFTer also but it has gone a little stale and that makes me sad. Glad to hear of the internal react-native action in MSFT though, cheers @kaiguo

As I have no real way to test it, I'm going to have to merge this in and assume that it's all correct.
It seems like Github and CircleCI are having issues at the moment, so there's likely to be a delay, but once it's released can you test and report back with any issues @kaiguo?

As I have no real way to test it, I'm going to have to merge this in and assume that it's all correct.
It seems like Github and CircleCI are having issues at the moment, so there's likely to be a delay, but once it's released can you test and report back with any issues @kaiguo?

As I have no real way to test it, I'm going to have to merge this in and assume that it's all correct.
It seems like Github and CircleCI are having issues at the moment, so there's likely to be a delay, but once it's released can you test and report back with any issues @kaiguo Kai Guo FTE?

Yeah will do, thanks!

I did some testing with the released package, everything looks good, thanks for merging @matt-oakes!

Great! Thanks for your help!


Add private person domain to CozyTouch login

Tested with 2 different user logins. Got this from the Jeedom plugin.


Added python3-open3d via .deb package

Please add the following dependency to the rosdep database.
Package name:
python3-open3d
Package Upstream Source:
https://github.com/isl-org/Open3D
Purpose of using this:
This package already exists in the index as a PIP dependency, this adds it as a distribution package (for Ubuntu and Debian, I couldn't find it for Fedora)
Distro packaging links:
Links to Distribution Packages

Debian: https://packages.debian.org/

https://packages.debian.org/bullseye/python3-open3d

Ubuntu: https://packages.ubuntu.com/

https://packages.ubuntu.com/jammy/python3-open3d

@audrow thanks for the quick review. Shall I merge this or do I wait for one of @ros/rosdeputies ?


mkpr

Applied mkpr on package.json
sed s/"@kronos-integration\/service": "^.*"/"@kronos-integration\/service": "^8.3.13"/

:tada: This PR is included in version 2.0.11 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Trying to fix the annoying bug in n8n. Looking for recommendations

I am trying to develop the best strategy to fix an annoying bug related to the old curlconverter@3 dependency. Since n8n uses CommonJS and cannot migrate to ESM in the near future, I would like to know if there is a chance you could release a new v3 version of curlconverter if I create a substantial pull request to migrate the version 3 json generator to something similar to https://github.com/curlconverter/curlconverter/blob/v4.10.1/src/generators/json.ts (but, converted to JS).
I would be happy to create a PR if this sounds adequate.
Here is the related PR in n8n:
https://github.com/n8n-io/n8n/pull/9769#issuecomment-2211079129

release a new v3 version of curlconverter if I create a substantial pull request to migrate the version 3 json generator

yes.
Currently curlconverter uses a Bash parser written in C compiled to Wasm, which requires it to be ESM only (kind of, it's possible to not but being ESM only makes it much easier). It would be helpful if there was an up to date version of curlconverter that was JavaScript only. You just have to replace the parsing part with some javascript that returns an array of Bash tokens and then it should be possible to use all the new generator code and we could have all the new languages that were added since version 4 without requiring Wasm and ESM.
If you'd like to work on it, it would be ideal to replace the Wasm stuff with https://github.com/withfig/lezer-bash which is JS only.


FilteredStreamingTweet - remove the oneOf definition

Remove the oneOf definition of FilteredStreamingTweet and group all oneOf properties to be the object's members.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.tmoskovitch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


added spring 2022 contributors to README.md

Summary
Add spring 2022 contributors to README.md
Test Plan
Verify that the list of contributors for SP22 in the README.md file is visible and correct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Warning promise gives wrong file/line

Using "bluebird": "^3.4.1", on node v6.3.1, I had a warning about promise not returned.
That's okay, but the Warning tell me that :
(node:33144) Warning: a promise was created in a handler at domain.js:293:12 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (D:\Projects\giraf-back\node_modules\bluebird\js\release\promise.js:77:14)`

Which is not a file in my project (I assume it belong to node).
If I now go in debuggability line 441 in release (or see here the file:line in the bluebird repo ), by removing the break, I can see the proper location
(node:34872) Warning: a promise was created in a handler at D:\Projects\giraf-back\databases\MongoDB\collection.js:77:12 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (D:\Projects\giraf-back\node_modules\bluebird\js\release\promise.js:77:14)

(Edit: In fact, I can't, the proper location was the second items models\\request.js)
This is what I have by default (eg: not removing the break), if I display the stacktrace (by adding console.log(stack) between L440 and L441).
[ '    at Collection.insert (D:\\Projects\\giraf-back\\databases\\MongoDB\\collection.js:77:12)',
  '    at D:\\Projects\\giraf-back\\models\\request.js:10:30',
  '    at bound (domain.js:280:14)',
  '    at runBound (domain.js:293:12)',
  '    at runCallback (timers.js:570:20)',
  '    at tryOnImmediate (timers.js:550:5)',
  '    at processImmediate [as _immediateCallback] (timers.js:529:5)' ]
(node:36620) Warning: a promise was created in a handler at D:\Projects\giraf-back\databases\MongoDB\collection.js:77:12 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (D:\Projects\giraf-back\node_modules\bluebird\js\release\promise.js:77:14)

I'm getting the same from<EMAIL_ADDRESS>on node 6.9.1
[ '    at addLinks (/usr/src/docca-pdf-server/node_modules/docca-pdf-document/lib/render/index.js:185:29)',
  '    at renderImage.then (/usr/src/docca-pdf-server/node_modules/docca-pdf-document/lib/render/index.js:204:7)',
  '    at bound (domain.js:280:14)',
  '    at runBound (domain.js:293:12)',
  '    at runCallback (timers.js:637:20)',
  '    at tryOnImmediate (timers.js:610:5)',
  '    at processImmediate [as _immediateCallback] (timers.js:582:5)' ]
(node:29) Warning: a promise was created in a handler at domain.js:293:12 but was not returned from it, see http://goo.gl/rRqMUw
    at Function.Promise.each (/usr/src/docca-pdf-server/node_modules/bluebird/js/release/each.js:24:12)

getting the same issue as well
(node:15560) Warning: a promise was created in a handler at domain.js:293:12 but was not returned from it, see http://goo.gl/rRqMUw
at Function.Promise.attempt.Promise.try (/Users/blah/blah/node_modules/bluebird/js/release/method.js:29:9)

Shouldn't it be better to well, just display the full stacktrace ?

sorry don't have a full stack trace :( its not an environment i have control over

I'm getting the same warning messages, and it's pretty much impossible to track down where my leaky promises are when I don't have LOC to track them down with. It's very difficult scouring through 184269 lines of JS!

Seems like a bug, doesn't look like those lines should be removed by cleanStack

I've test it. This is what cleanStack(traceLines) returns me.

So i'm not sure it's a problem from cleanStack but instead going further I found that :

In fact, I can fix it by removing traceLines[i - 1] and replacing it by traceLines[i]

I've fix it doing so :

I added a conditionnal verification of traceLines[i] and keep the original lines (I'm not sure, but I think there is sometimes where this gaves the good answer ?)

Just ran into this problem. Such is life =/


Added rosdep keys for libsvm3 and libsvm-dev

Package for SVM classifiers (c/cpp, python, matlab, etc.).

+1


Op registered for Upsample is deprecated in domain_version of 15

Hi,,
I am trying to convert my Darknet YOLOV3 tiny weight to Onnx but got this error. The model input size is 416 with 9 classes, use filter = 42 from (class+5)*3 .

I think I found my problem, I install it on my PC instead of my Jetson Xavier therefore it keep failing. It work well now. Thank you very much!

@akashAD98

Not able to install onnx 1.4.1

Maybe you could try pip3 install pybind11 before onnx==1.4.1...

Refer to: https://github.com/jkjung-avt/tensorrt_demos/issues/539#issuecomment-1119218462
The code has been updated to use onnx==1.9.0 now.


tmt test export --how nitrate generates metadata which are making tmt lint unhappy

tmt version: 1.32.1
Command tmt test export --how nitrate adds the following metadata to the main.fmf file:
extra-nitrate: TC#0608166
extra-summary:
    /tools/pcp/Regression/bz1825386-gfs2-kernel-trace-points-turning-on-by-themselves
extra-task:
    /tools/pcp/Regression/bz1825386-gfs2-kernel-trace-points-turning-on-by-themselves
id: c094c785-9d33-47c6-8fec-ef94c9b0132f

When I run tmt lint on the main.fmf after the tmt test export --how nitrate, the lint complains about the following issues:
  26:15     error    trailing spaces  (trailing-spaces)
  27:5      error    wrong indentation: expected 2 but found 4  (indentation)
  28:12     error    trailing spaces  (trailing-spaces)
  29:5      error    wrong indentation: expected 2 but found 4  (indentation)

Where line number 26 refers to the extra-summary: in the example above.

Hmm, that does not look like tmt lint output, it looks more like a yamllint output. Is there a chance there might be some YAML (fmf is just a fancy YAML) formatting/linting in play? The extra-summary and extra-task keys are indeed incorrect, their value being moved to next lines & indented - not a way to set a value of a key. But tmt lint does not report this kind of issues, and its YAML parser would die on the first error & raise an exception, so there must be something else in play.
happz@multivac /tmp/foo $ cat main.fmf
extra-nitrate: TC#0608166
extra-summary:
    /tools/pcp/Regression/bz1825386-gfs2-kernel-trace-points-turning-on-by-themselves
extra-task:
    /tools/pcp/Regression/bz1825386-gfs2-kernel-trace-points-turning-on-by-themselves
id: c094c785-9d33-47c6-8fec-ef94c9b0132f

test: /bin/true
happz@multivac /tmp/foo $ tmt test ls
/
happz@multivac /tmp/foo $ tmt test lint
/
pass C000 fmf node passes schema validation
warn C001 summary key is missing
pass T001 correct keys are used
pass T002 test script is defined
pass T003 directory path is absolute
pass T004 test path '/tmp/foo' does exist
skip T005 legacy relevancy not detected
skip T006 legacy 'coverage' field not detected
skip T007 not a manual test
skip T008 not a manual test
skip T009 library/file requirements not used

happz@multivac /tmp/foo $

All tmt does is calling fmf's https://github.com/teemtee/fmf/blob/29190c78e4065adf98cbb3ccf747b01973d761e2/fmf/base.py#L823
Simpler reproducer is:
$ fmf init

$ cat <<EOF > main.fmf
key: lllllllllllllllllllllllllllllllllllllllllllllllllllllllllloooooooooooooooooooooooooooonnnnnnnnnnnnnnnnnnnngggggggggggggg
EOF

$ cat <<EOF | python3
import fmf
with fmf.Tree('.').find('/') as data:
    data['foo'] = 'foo'
EOF

and you will see that 'key' got modified as well. If we will be "fixing" (read: making linter happy) change will need to happen on fmf side (or ruamel?)

True, but just the note I mentioned above, tmt lint will not complain about this. yamllint would, but not tmt lint :)