separate include paths for each installed dependency

Is your feature request related to a problem? Please describe.
Before going further I want to make it clear, this is my fault but I think vcpkg could arrange the includes differently to prevent accidentally running into this problem.
The issue is that vcpkg puts all dependency include files in a single root path so as soon as my library depends on a vcpkg managed dependency it gains access to all the other paths as well. In other words i can include headers that i haven't done a 'target_link_library(...)' on. this causes two main categories of issues:

'multiply defined symbols'. if the header was part of a dependency that has dual use as header only or statically linked library (like spdlog) then I can have a static library (say, libA) that accidentally includes spdlog/spdlog.h without a 'target_link_libraries( spdlog::spdlog)'. This library builds fine, but libA will have its own copy of the definitions for all the spdlog symbols and leads to errors for multiply defined symbols when linking to the final executable which was properly linking to spdlog.lib via target_link_libraries(app spdlog::spdlog).
'Can't find header xyz.h'. If the header was part of a always header only library (like many boost libraries) then everything works fine until i try compile my library in a system that is not using vcpkg. for example, using yocto/bitbake that uses unique paths per dependency / per target i will get include errors.

I also worry about ODR violations where a header changes its interface depending on compiler flags/definitions but they never get set because cmake doesn't know about the dependency. but I don't think that i've run into any so far
Proposed solution
all dependencies should get their own include folder.
Current:
<vcpkg_root>\installed<triplet>\include\boost...
<vcpkg_root>\installed<triplet>\include\spdlog\spdlog.h
<vcpkg_root>\installed<triplet>\include\spdlog...
<vcpkg_root>\installed<triplet>\include\fmt\fmt.h
<vcpkg_root>\installed<triplet>\include\fmt...
Proposed:
<vcpkg_root>\installed<triplet>\boost\include\boost...
<vcpkg_root>\installed<triplet>\spdlog\include\spdlog\spdlog.h
<vcpkg_root>\installed<triplet>\spdlog\include\spdlog...
<vcpkg_root>\installed<triplet>\fmt\include\fmt\fmt.h
<vcpkg_root>\installed<triplet>\fmt\include\fmt...
<vcpkg_root>\installed<triplet>\zlib\include\zlib.h
<vcpkg_root>\installed<triplet><...>\include...
then the include path for each target would be unique. so for target_link_libraries(libA spdlog::spdlog) would then add '<vcpkg_root>\installed<triplet>\spdlog\include' to libA's include paths and would prevent it from accidentally including zlib.h.
Describe alternatives you've considered
AFAICS this is the only solution that fixes the problem without intrusively modifying the other projects (ex: having a different include for spdlog as header only vs. statically linked) or adding compiler defines for each project and check they match at the beginning of each include file.
Additional context
I took a quick look at existing open & closed issues but couldn't find any

And what happens to cmake find modules? They won't find their INCLUDE_DIRs anymore since the don't expect another sub directory.

And what happens to cmake find modules? They won't find their INCLUDE_DIRs anymore since the don't expect another sub directory.

IMHO (vcpkg-built) libraries should only ever be included using find_package(<name> CONFIG REQUIRED). The corresponding <name>-targets.cmake files will take care of the rest. Sadly not many libraries are consumable like this yet, and AFAICT this isn't something vcpkg wants to tackle for its ports (and thus ports have wildly differing ways on how they have to be consumed).

And what happens to cmake find modules? They won't find their INCLUDE_DIRs anymore since the don't expect another sub directory.

I'll be honest your comment is over my head. most of my use as a consumer of vcpkg managed dependencies has been find_package(). Looking into the include directory i can see every dependency has its includes thrown together, and as I've explained it causes all sorts of odd problems. From my perspective, i shouldn't be able to create a dependency on something if i didn't' explicitly request it in my cmakelists.
AFAICS find_package() for most of the libraries i use could still work with that use case. As always things are more complicated than a naïve inspection reveals. if its not possible to do anything about it then so be it. This has been a major pain point for me recently, I sure hope it could be fixed.

Sadly not many libraries are consumable like this yet, and AFAICT this isn't something vcpkg wants to tackle for its ports (and thus ports have wildly differing ways on how they have to be consumed).

Simply said. Needs upstream changes/fixes ;). Not something VCPKG should care about.

MHO (vcpkg-built) libraries should only ever be included using find_package( CONFIG REQUIRED)

Not all libraries are built with cmake and probably will never be. Furthermore supplying unofficial targets (e.g. like Conan) makes downstream packages not agnostic to the package manager which is bad design.

Not all libraries are built with cmake and probably will never be.

That doesn't really matter. What matters is that the library is consumed with cmake.

Furthermore supplying unofficial targets (e.g. like Conan) makes downstream packages not agnostic to the package manager which is bad design.

That's not true. find_package has nothing to do with vcpkg or any other package manager. You could do this manually if you wanted (but this is cumbersome, and something I'd expect a package manager to take care off). For the ports I use I've added targets files where missing. Makes it really easy to integrate a library and beats the manual find_include, find_library, add imported target dance.
Also, vcpkg already renames library names (like adding a d suffix) and thus introduces incompatibility.

This is one of those things that sounds great in theory, but is almost impossible to do in practice. In a perfect world, yes this is how it would work. I'd personally love this at least.

its been a while since I first posted. I think the main motivation has been solved with more recent VCPKG versions:
use vcpkg.json and its ability to specify dependencies manually per project
only the specified dependencies get installed to 'cmake_outputdir//include/'.
I've switched my projects over to this method on mac/windows/linux and it is working great so far and i can confirm that i can't accidentally include a header that is part of a project that i didn't previously specify in vcpkg.json. So although i can still get link errors if i forgot to add a target_link_libraries to one of the dependencies, at least i can be confident the dependency was listed in vcpkg.json.
VCPKG keeps getting better, Thanks!


DayPickerRangeController not working as expected

react-dates version
"react-dates": "^20.2.4"
Describe the bug
DayPickerRangeController only showing one calendar and the date cannot be selected
Source code (including props configuration)
Here is the source code
import React from 'react';
import { Link } from 'react-router-dom';
import 'react-dates/initialize';
import 'react-dates/lib/css/_datepicker.css';
import { DayPickerRangeController } from 'react-dates';

class HomePage extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      startDate: null,
      endDate: null,
      focusedInput: 'startDate',
    };
  }

  handleDateChange = () => {
    console.log('do something here');
  }

  render() {
    return (
      <div>
        <DayPickerRangeController
          startDate={this.state.startDate}
          endDate={this.state.endDate}
          onDatesChange={({ startDate, endDate }) =>
            this.handleDateChange(startDate, endDate)
          }
          focusedInput={this.state.focusedInput}
          onFocusChange={focusedInput =>
            this.setState({ focusedInput: focusedInput || 'startDate' })
          }
        />
      </div>
    );
  }
}

export default HomePage;

Screenshots/Gifs

Desktop (please complete the following information):

OS: Mac OS X
Browser chrome
Version latest version

Is the issue reproducible in Storybook?
this issue is not reproducible in storybook.
https://airbnb.io/react-dates/?path=/story/daypickerrangecontroller--default

@aibrahim3546 this is working as expected - you should add numberOfMonths property to 2 for displaying two calendars, also there is no problem with onDatesChange

Hey @mmarkelov thanks for the solution it works perfectly. Look like I have been missing the numberOfMonths props and I also forget to setState for the startDate and endDate


optimizer.step() does not check if the parameter has gradient

Currently, the optimizer does not check whether the parameters have gradients when calling .step(), It could be valuable to return a warning.
This could be checked in get_gradient_and_context_text function of optimizer.py.

great point.. we should add this in the next release. thank you @linyuhongg !


Minimal rights to connect remotely to a taskscheduler service

Hi,
What are the minimal rights to connect remotely to a taskscheduler service on another server?
Code used:
            using (TaskService ts = new TaskService ("\\servername", "account", "domain", "password"))
            {
                Task t = ts.GetTask("MyTask");
                t.Run();
            }

The "account" is a valid account on our domain.
If the "account" is member of the local administrator group on the remote server, it works. The code can connect and run successfully the task.
But I don't want to put this account in the local administrator group on the remote server!
If I give the account only the right "Log on as batch job", I get
System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
at Microsoft.Win32.TaskScheduler.V2Interop.TaskSchedulerClass.Connect(Object serverName, Object user, Object domain, Object password)
at Microsoft.Win32.TaskScheduler.TaskService.Connect()
In the Event Viewer I see a successful logon of the account and directly a logoff, probably because of the error.
(when the account is in the admin group, I see only a successful logon in the Event Viewer)

Some mentioned on the internet to add read and execute rights for the used account on the c:\windows\system32\tasks folder ==> Like I thought already
didn't work, the error appears on the first line of the code when trying to connect, before trying to execute a task.
Because of the word "Interop" in the error stack, I thought at a COM security problem, so I added the account to the COM security tab in the two sections
(run dcomcnfg, right-click on My Computer, take tab COM Security, add the account to Access Permissions and to Launch and Activation Permissions)
==> didn't work.

The windows firewall is disabled on the remote server, so it can't play a role here.
Any thoughts about this?
Is adding the account to the local administrator group the only way to connect remotely to the taskscheduler service?
Originally posted: 2014-02-27T01:36:13

Anyone been able to solve this?
I'm looking to do the exact same thing, run a predefined task, remotely, as as user with bare minimum permissions as possible.
I've successfully run the task programmatically as a user with administration privileges, however I'm having trouble with a stripped down account.
Kind Regards,
Liam Flanagan
Originally posted: 2014-11-24T10:27:37

In theory, you need to connect to the remote server using the TaskService constructor and supply credentials that have Administrator rights. Of course to get this far, you will have to have all the firewall and rights specified at https://taskscheduler.codeplex.com/wikipage?title=TaskSecurity. Once connected, you can then create the task and register it as the account under which you want it to run. You will have to register the task using the username and password of the intended account and then use the TaskLogonType.Password.
Originally posted: 2014-12-01T08:14:57


Missing main CraftSim windows on opening profession windows

Steps to repeat:

Open a profession window
Craft results, and price override windows are open; all other usual windows are missing including the main bar
Switching to specializations or crafting orders and back restores the main bar, but none of the checked modules are visible
Checking and unchecking the boxes does not cause any modules to reappear, nor does closing and reopening the profession window.

The issue persists after removing CraftSim and all CraftSim cache files in the WTF folder, then restarting the game and reinstalling the addon.
Bugsack report:
60x CraftSim/Util/Cache.lua:50: bad argument #1 to 'GetAddOnMetadata' (Invalid AddOn name KeyCount_dev. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable))
[string "=[C]"]: in function `GetAddOnMetadata'
[string "@CraftSim/Util/Cache.lua"]:50: in function `GetCacheEntryByVersion'
[string "@CraftSim/Main/CraftSim.lua"]:227: in function <CraftSim/Main/CraftSim.lua:211>
[string "=[C]"]: ?
[string "=[C]"]: in function `Init'
[string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185>
[string "=[C]"]: in function `SetShown'
[string "@SharedXML/TabSystem/TabSystemOwner.lua"]:33: in function `SetTab'
[string "@SharedXML/TabSystem/TabSystemOwner.lua"]:69: in function `SetTab'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:413: in function `SetTab'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:294: in function `UpdateTabs'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:241: in function `Refresh'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:203: in function `SetProfessionInfo'
[string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:139: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:102>

Locals:
(*temporary) = "KeyCount_dev"
(*temporary) = "Version"
(*temporary) = "Invalid AddOn name KeyCount_dev. - Usage: local value = C_AddOns.GetAddOnMetadata(name, variable)"

Oof, I didn't even recognize that as another addon. I'll uninstall it and check when the servers are up.

Disabling KeyCount fixes the issue. Thanks for your assistance, Domi!


Upgrading php buildpack to v3.2.1

Upgrading to latest stable version of php buildpack
--Buildpacks Team

Please note that this is the "skinny" buildpack.


{CI} Auto manage milestone for pull request

Related command

Description

Auto manage milestone for pull request
Revert auto manage milestone for issue

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

CI


Fix typo: catastropic to catastropHic

I just downloaded and ran this utility and got that typo in my face so I figured I could just as well fix it :-)

Shameful ... :(
Thanks !

@lqez nothing to be ashamed of! by the way I love keycastr, it's superuseful. thanks! :)


Minor gui issues

Two small usability enhancements:

Strips leading and trailing whitespace from the subject's first and last name before searching
Saves any unsaved notes on terminate servers.  If there is note text, but no task has been selected, a popup tells the user to delete the note or select a task. After the unsaved note is fixed, terminate server can be performed.

agreed, but:

a fix would mean rewriting the terra query code
the sql injection would require access to the machine (either directly or
via chrome)
we might be going to change the gui to query by id
(unfortunately) there's probably a ton of these issues

On Wed, May 8, 2024 at 12:32 PM Brandon Oubre @.***>
wrote:

@.**** approved this pull request.
LGTM
In neurobooth_os/iout/metadator.py
https://github.com/neurobooth/neurobooth-os/pull/408#discussion_r1594311880
:

 table_subject = Table("subject", conn=conn)

 subject_df = table_subject.query(

   where=f"LOWER(first_name_birth)=LOWER('{first_name}') AND LOWER(last_name_birth)=LOWER('{last_name}')"

   where=f"LOWER(first_name_birth)=LOWER('{f_name}') AND LOWER(last_name_birth)=LOWER('{l_name}')"

I'm not suggesting we fix at the moment given the use case, but looks like
SQL injection potential. Could be the source of some special character
issues.
—
Reply to this email directly, view it on GitHub
https://github.com/neurobooth/neurobooth-os/pull/408#pullrequestreview-2046131227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2FPAT3TTDFUPT7FWT66XDZBJHQVAVCNFSM6AAAAABHNFZ2DGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBWGEZTCMRSG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

agreed, but: - a fix would mean rewriting the terra query code - the sql injection would require access to the machine (either directly or via chrome) - we might be going to change the gui to query by id - (unfortunately) there's probably a ton of these issues

Agreed on all points.


chore: release 3.0.1

:robot: I have created a release *beep* *boop*
3.0.1 (2019-06-13)
Bug Fixes

docs: move to new client docs URL (#212) (b7a8c75)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/node-gtoken/releases/tag/v3.0.1

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Cannot find module '../lib/config/schema'.

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

With the below package.json , I perform "npm start" -> ng serve

The log given by the failure.

Build gets to 92% and gives below error

Desired functionality.

I am using below project and facing the issue :  https://github.com/microsoftgraph/angular-connect-rest-sample
Mention any other details that might be useful.

Heya, can you try using the latest version of the CLI in the project instead? Right now that is 1.2.7, and you are using 1.2.7.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


Clickable Links in Widgets?

How would I make a clickable link inside say the List widget? That way a user could interact with a widget square?

@alexcurtin this is an issue with Gridster. See this thread on Dashing's repo for more information on a workaround.

Furthermore, with Gridster appearing to be a dead project (https://github.com/dustmoo/gridster.js/issues/51) we should investigate switching to something like gridstack.js


[#6244] Add CompletableFuture Plugin

#6244

Codecov Report

Merging #6267 into master will increase coverage by <.01%.
The diff coverage is 5.4%.

@@            Coverage Diff             @@
##           master    #6267      +/-   ##
==========================================
+ Coverage   39.58%   39.59%   +<.01%
==========================================
  Files        3055     3058       +3
  Lines       91291    91328      +37
  Branches    11833    11836       +3
==========================================
+ Hits        36138    36159      +21
- Misses      52173    52188      +15
- Partials     2980     2981       +1

Impacted Files
Coverage Δ

.../completable/JdkCompletableFuturePluginConfig.java
0% <0%> (ø)

...nterceptor/CompletableFutureMethodInterceptor.java
0% <0%> (ø)

...in/jdk/completable/JdkCompletableFuturePlugin.java
0% <0%> (ø)

...orp/pinpoint/profiler/UnmodifiableClassFilter.java
50% <33.33%> (-12.5%)
:arrow_down:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
56.25% <0%> (-18.75%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0%> (-2.13%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.9% <0%> (-1.94%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea97dd...b0ed29a. Read the comment docs.


Which version of SnapKit and Xcode can use to update my app to Swift 3, before moving to Swift 4?

I've been trying Xcode 8.2.1 with Swift 3.0.2, and SnapKit 3.2.0. But there's a lot of Swift compiler errors.
I'm trying to figure out which Xcode version I need: https://en.wikipedia.org/wiki/Xcode#Latest_versions
Please let me know if there's a specific commit I can point to that supports Swift 3.0.2.
I'm going to try Xcode 8.0 and Swift 3.0 now.

I solved this by using Xcode 8.0 and Swift 3.0.


add deployment_target of osx, tvos and watchos

Updating to 1.52.0-pre2 for release versioning

removed, in favor of podspec files in native dir


add envinfo package, —info flag

I realize the file says not to modify the createReactApp.js, but a better way to do this did not occur to me. If there is a better way, I am certainly open to it.
To help the issue process and better narrow down environment and version issues, I have added create-react-app --info which should print the following:
Environment:
  OS: macOS High Sierra 10.13
  Node: 8.6.0
  Yarn: 1.2.1
  npm: 5.5.1
  Watchman: 4.9.0

Packages: (wanted => installed)
  react: ^16.0.0 => 16.0.0
  react-dom: ^16.0.0 => 16.0.0
  react-scripts: 1.0.17 => 1.0.17

Let's also check for duplicate react / react-dom in the tree?

That's a great idea. Will add.

With the new option--duplicates on envinfo, duplicates will now also show in parentheses.
Environment:
  OS: macOS High Sierra 10.13
  Node: 8.6.0
  Yarn: 1.2.1
  npm: 5.5.1
  Watchman: 4.9.0

Packages: (wanted => installed)
  react: 16.0.0 => 16.0.0 (15.6.2)

You can actually test this in an existing CRA with npx<EMAIL_ADDRESS>--packages "react,react-dom,react-scripts" --noNativeIDE --duplicates

Still doesn't have a react-scripts-dangerous version to test out. cc @Timer
The test failure isn't related to this PR.

Is there anything I can do to trigger the test build for react-scripts-dangerous?

Ping @Timer

I shut off the react-scripts-dangerous bot as I started to get quite expensive.

Cost $6 for one month, then randomly went wild -- no clue what happened here. 😅

Whaat! That's a bummer @Timer. Was really helpful but doesn't make sense if it costs you that much. Thanks for building it. Maybe we can find someone willing to host it later.

I think there was just some bug that caused the lambdas to run rampant; eventually when I have some free time I'll adjust it to prevent this from happening again.


Store service#37

Store service with get(params) method, that you can pass:
get({}) -> all stores
get({id: 5}) -> api/stores/:id
get({otherParam: xxx}) -> api/stores/?otherParam=xxx

Should be all done. Only question from my side: Does the get method make sense, or would you do it differently?

Good work!
We need to add query parameters to groups GET, too. So we can get all groups of a single user.

@Sneezoo group service is fixed already :slightly_smiling_face:

Current coverage is 70.19% (diff: 89.25%)

Merging #38 into master will increase coverage by 7.36%

@@             master        #38   diff @@
==========================================
  Files            19         27     +8
  Lines           113        255   +142
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             71        179   +108
- Misses           42         76    +34
  Partials          0          0

Powered by Codecov. Last update bf61b70...923bf45


Corrected PM Message Documentation

I think this should adressed in the code rather than in the docs

I'm fine either way; I wasn't sure what the preferred return value was, so I deferred to what the current functionality is.

I wrote the documentation for this particular property and it seems to me that the general convention of the docs is to specify a parameter as 'null', even if it's really undefined.

If I encounter it elsewhere, I'll fix it there too. But as is, this is incorrect and should be updated


[PD] Manage time with your calendar

Coursework content
Set up your Google calendar to show your weekly availability for calls with your peers. Share your calendar with your pair of the week.
Set up an appointment schedule  and put the booking link in your Slack profile.
Estimated time in hours
0.5
What is the purpose of this assignment?
Use your calendar to manage your time and to collaborate with your peers and volunteers. In any professional job, you will be expected to manage your time, attend meetings, and share your availability with others on a calendar like this.
How to submit
Put your appointment schedule in your Slack profile. Book a meeting with your pair.
Anything else?

Create a Google calendar
Share your Google Calendar

Kamino cloned this issue to Ebtesammm/Coursework-Planner

Kamino closed and cloned this issue to DianaRCruz/Coursework-Planner

Kamino closed and cloned this issue to DelwinMansur/DelwinMansur-Coursework-Planner

Kamino cloned this issue to kostiantynkovalchuk/Coursework-Planner

Kamino cloned this issue to FabioMedinaD/Coursework-Planner


Parallel staging

We can optimize the staging process by leveraging that Hype encourages usage patterns with multiple submission from the same JVM. This PR adds:

Parallel uploads - files are uploaded on a thread pool
A static cache for uploaded files - don't try to upload the same files multiple times

Codecov Report

Merging #25 into master will increase coverage by <.01%.
The diff coverage is 58.97%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
+ Coverage     31.57%   31.58%   +<.01%
- Complexity       59       66       +7
============================================
  Files            27       27
  Lines           874      877       +3
  Branches         68       67       -1
============================================
+ Hits            276      277       +1
- Misses          575      578       +3
+ Partials         23       22       -1

Impacted Files
Coverage Δ
Complexity Δ

...tter/src/main/java/com/spotify/hype/Submitter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rc/main/java/com/spotify/hype/gcs/StagingUtil.java
59.83% <61.33%> (-0.67%)
14 <8> (+7)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4a5a9...df4c37b. Read the comment docs.


Keep componentWillReceiveProps lifecycle method as safe

Hi
In your post about adding "UNSAFE_" prefix to some method names, you tried to cover the most common use cases to prevent using those methods.
Here's a use case I don't know how to migrate:
Let's say we have a component <ProductView /> to display a product. It receive as props:

productId :  the product's to fetch and display.
onBuyClicked : callback to event like when the user click on a 'buy' button.

As you can see, the productId prop is critic. By critic, I mean that the component has to reset its state, and restart to fetch data to display a completely different product. It has to cancel the fetching promise, and restart a new one.
While the onBuyClicked prop isn't critic at all. If its value change, nothing in the component's behavior has to change. It should display the same product.
That's why the componentWillReceiveProps method is so important. Because inside of it, it's possible to compare critic old props with new ones, and decide the component behavior, if it need to reset the state, because a critic prop was changed, or not, and then doing nothing.

Can you explain how this is different from this example? I think it does what you just described.
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#fetching-external-data-when-props-change

You're are right, I didn't see this example.
Thanks this close the issue.
But I don't get it. This isn't logic to set props into state.

I don’t understand what you’re asking then. If you could show your code I can show how to convert it.

My first question was:
How to check previous props without componentWillReceiveProps(props)?
With this example you gave me, you already answered it. The answer was:
Store props into state, so you will be able to compare them inside the static getDerivedStateFromProps(nextProps, prevState) function.
This answer makes me close the issue.
Now I'm asking another question:
Why do we need to store props into state? This isn't intuitive/logic/normal. Props are from parent component, while state is from internal behavior. This difference allowed us to develop in a really nice and clean way.

You can read the discussion here: https://github.com/reactjs/rfcs/pull/40. It contains several reasons why that wouldn’t work well.
In any case you shouldn’t be using getDerivedStateFromProps very often. There will also be better data fetching APIs coming in the future but in order to ship them we need to migrate people away from componentWillReceiveProps first.

We posted more specific recommendations. In most cases you don’t need getDerivedStateFromProps because there are better alternatives. Check out this post for more details:
https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html


Fix the mount when we have a disk from a previous CSI plugin versions

In our cluster we've  end up with a bug when we upgrade the CSI plugin from 0.0.14beta to the current one. Withe the change of the default FStype (from ext4 to xfs), we saw that the already existing disks could not be anymore mounted if the fstype was not set in the StorageClass.
The reason was that the plugin tries to mount with the default fstype (xfs) but the disk was formatted in ext4.
To fix this, we check that the disk has a format type and if so, we check that this is the same and if not, we take the fs type of the disk and display a warning.

In addition of the description, we also ensure that the DSTYpe in the PV's description is set


fix RangeError in encoding BLOB

Resolve  #65

Codecov Report

Merging #66 into master will decrease coverage by 0.74%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage    96.9%   96.15%   -0.75%
==========================================
  Files          15       15
  Lines         905      911       +6
  Branches      183      183
==========================================
- Hits          877      876       -1
- Misses         28       35       +7

Impacted Files
Coverage Δ

src/Encoder.ts
94.87% <100%> (-2.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed070f...d16cfdc. Read the comment docs.


Story: Integration Testing: User management

We support the following APIs at the SDK:
// PutUser introduce new user into database
PutUser(user *types.User, acl *types.AccessControl) error

// GetUser obtain user's record from database
GetUser(userID string) (*types.User, error)

// RemoveUser delete existing user from the database
RemoveUser(userID string) error

Scenario 1: Testing the Access Control on Read and Write to Database

Create databases
Create users with the required certificates and different access control permissions
Test whether the access control logic on databases work

Scenario 2: Testing User Updates

Create users with the required certificates and access control privileges
Updates users' certificate and access control privileges
Test whether the update executed successfully

Scenario 3: Testing User Removal

Create users with the required certificates and access control privileges
Remove users
Test whether the update executed successfully


Instructions on coredns yield error

The instructions to install this module on the CoreDNS website say:

The trailing slash yields an error and halts building while making CoreDNS:
github.com/coredns/coredns imports
        github.com/coredns/coredns/core/plugin imports
        github.com/oz123/coredns-netbox-plugin/: malformed import path "github.com/oz123/coredns-netbox-plugin/": trailing slash
make: *** [Makefile:23: core/plugin/zplugin.go] Error 1

Thank you for the issue report. I guess this needs to be fixed in coredns documentation.
I am happy you could fix it yourself!


Cannot read properties

FVTT Version 11.302
PF2e Version 5.0.1
Exploit Vulnerability Version 0.11.1
Socketlib Version 1.0.13
No other modules active.
Also happens in brand new blank world with nothing else configured.
Linux hosted world connecting via Edge(no addons)
Opening any PC actor gives the first error. Rolling any strikes gives the 2nd.

Are you a player or a GM?

GM. But have tried as player, and they get the same errors

I'm not able to reproduce the issue. I created a completely clean world, created a brand new actor, and did nothing else and it's working for me. Can you try removing the module, making sure the data folder is completely removed, and reinstall?

Done. Still happens, but seems to only occur on the built in unarmed strike. Any weapon attacks seem OK now.

Hey @mysurvive, I think this one is related to #37. I had both these errors and found out that accessing the Thaumaturge's sheet when his token isn't on the canvas throws this error and makes him unable to select his implements

I will take a look at it sometime this weekend. Sorry about this, I've been pretty busy this week.

Someone on Discord found the problem. It's related to opening a sheet when you don't have an actor selected.

This also happens when attempting to cast Harm and breaks PF2e Animations.

Haven't seen this crop up in a while, and I fixed where the hook was breaking. Unfortunately I can't check the AA workflow because I don't have the JB2a premium content, so I don't have the harm effect (I tried it and it couldn't find the animations), but I believe this is fixed now.

As a note, you don't require the Patreon version of JB2A at all.


iOS: Add export_project_only flag

As per https://github.com/godotengine/godot-proposals/discussions/7147
This diff adds the following:

Add an export flag for iOS projects called 'export project only'
This creates the iOS project, but does not archive or produce the .ipa

This is useful for situations where there are third party build tools doing additional configuration, e.g. Fastlane
I've tested locally and everything is working okay. My only additional thought was the feature might need better naming or description.
Thanks

should be good for review if anyone is available :)

okay, I think everything should be good now. I had to use a ternary for EditorProgress, as I couldn't hoist it, as it does not have a default constructor. Tested building on MacOS and running locally, everything worked okay.

any recommendations for an ios reviewer? ideally hoping to get it in the next release :)

It's already assign for review by the iOS team, but we're in complete feature freeze for 4.1 so reviewing features isn't the priority right now.

Seems OK.
https://github.com/godotengine/godot/blob/fb7aa93c2d6a6f3f5a0de44896b67d9e65ecdc37/platform/ios/export/export_plugin.cpp#L1903-L1905
This warning shown when exporting from non-macOS system probably should be suppressed if export_project_only.

It still needs MacOS for step 2 though, so I think it's okay.?
https://github.com/godotengine/godot/blob/fb7aa93c2d6a6f3f5a0de44896b67d9e65ecdc37/platform/ios/export/export_plugin.cpp#L1836-L1847
Perhaps adjusting the error might be the way? Or as both export types require MacOS to complete, should we just deny non-MacOS at the start rather than handling it later?

Could you please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing.

just squashed and pushed, let me know if it's all good!

@phil-hudson Almost! You have an unrelated commit in there somehow. Also, we don't use the feat, chore, etc format. So prefer the title of the PR instead.

I force-pushed on your behalf to update the commit message.

Thanks!


add additional check against @rsyslog_version in case rsyslog is not installed

In a couple erb templates, the versioncmp check against the rsyslog_verion fact causes some issues if rsyslog is not already installed due to the fact being set to nil, which won't work with versioncmp.
Issue https://github.com/saz/puppet-rsyslog/issues/165 has some more details.
This is fixed by adding an additional check against rsyslog_version in the two erb files where it was causing issues, so the condition will short circuit before attempting to run versioncmp on nil.
Thanks :)

:+1:


fix: avoid colon in PR labels causing issues

fixes https://github.com/jenkins-x/jx/issues/7881

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add michael-chiu to stakeholders

I work on a chain of projects
[XThread] Simple threading library to manage threads
[spartanX] socket framework using kqueue/epoll on multiple thread
[SXF97] HTTP parser
[CoreCache] Caching
[SML] Type safe HTML generation
[CKit] C API helper
[swiftTLS] libressl wrapper

Can you please put your name following ascending alphabetical order?

Oops, sorry I didn't realize it is sorted by first name. Fixed.

Sorry, we've now got merge conflicts that I can't fix on merge. Can you clean up?

Merging.


CompressionLevel can't be set via the command line

changing compression level to a repo config parameter in repo-1-0-format branch


Make it Swifty!

Too much Objective-C for nerdy modern devs 😆

@gtranchedone You should read hipchat :D I asked for a review some days ago https://github.com/albertodebortoli/Skopelos


Pipeline to populate OpenSearch with Rasa YAML files

AS AN Architect
I WANT populating OpenSearch with Rasa YAML files to be based on a fully automated pipeline
SO THAT there wouldn't be multiple similar solutions doing the same thing
Acceptance Criteria
Technical stack
Based on Bükstack

[ ] Convert YAML to JSON by using Data Mapper
[ ] Custom pipelines as Data Mapper helper pipelines
[ ] Ruuter as the middle-man

Setting up new indices

[ ] Create appropriate OpenSearch indices automatically
[ ] Populate OpenSearch with all of the existing data

Updating existing data

[ ] Update specific data in OpenSearch based on YAML input
[ ] Pipeline to update OpenSearch only with YAML input that has not been updated yet

Scope of affected issues
... [ ] TBA

Implemented in actual developments by @ExiRain @KasparMinn @MarkoKull


Cop name collision with rubocop-rspec

I was playing with the current rubocop build and noticed a new warning:
/dev/projects/rubocop/.rubocop.yml: RSpec/FilePath has the wrong namespace - should be Rails

This might be confusing for users that depend on rubocop-rspec and rubocop itself. I think the proper solution here would be to not emit this warning if a cop exists for each case (RuboCop::Cop::RSpec::FilePath and RuboCop::Cop::Rails::FilePath). Before releasing the current build on master would you be open to fixing this? If you don't want this to be a release blocker it seems like it might also be valid to rename the rails cop to Rails/RailsRoot maybe.

By the way I don't want to give the impression that I expect the rubocop maintainers to be aware of 3rd party dependencies like rubocop-rspec. This is basically just a wart brought on by #3414 and I figure it is easier for everyone if we catch this before issues are reported after a release

Thinking about this now can probably help inform our design decisions for the extension system, too. 😀

Yeah, I guess extensions should register their namespaces so their properly handled by RuboCop. Sadly we've made zero progress with #3414...

Sadly we've made zero progress with #3414...

I've been doing some research. Still organizing my notes. I'm very busy at the moment though, so it's quite intermittent. 😓

By the way, I think this bug can be resolved with some improvements to CopStore. I'm working on this now and I'll hopefully have a PR up soon

This is actually still an issue. https://github.com/backus/rubocop-rspec/issues/299


Update UG screenshots with new application status colours

Codecov Report

Merging #231 (4738a5c) into master (e81c1b4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage     70.51%   70.51%
  Complexity      595      595
=========================================
  Files            85       85
  Lines          1923     1923
  Branches        259      259
=========================================
  Hits           1356     1356
  Misses          448      448
  Partials        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81c1b4...4738a5c. Read the comment docs.


chore: Included the digest for the docker image

https://cloud.google.com/architecture/using-container-images
https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies

Thank you as always Naveen @naveensrinivasan!
Merging.


handling errors could be improved

In a lot of places, possible errors will just be given to the Check function, which logs the error and happily continues on. This can result in runtime errors. Some instances are:
https://github.com/ewhal/Pastebin/blob/8f7528cbc6513d647901e3784399b2442a74708f/pastebin.go#L89
Here it is just assumed that opening the database connection will be successful. It will log an error, should one happen, but it will blindly run into the call at line 92.
Same thing on https://github.com/ewhal/Pastebin/blob/8f7528cbc6513d647901e3784399b2442a74708f/pastebin.go#L182 and the following lines.
I think those errors could be handled more gracefully.
In addition, I'd recommend renaming the Check function into something like LogError. This way, it is obvious what the function actually does.

I did want to improve error handling at some point in time and I should probably get on that.
Good idea with renaming Check to LogErrror.


create one-click apps for VMs

The approval process is a bit slower on these.

[ ] DigitalOcean
[ ] Vultr (blocked by bug)
[ ] Linode
[ ] AWS

hey @bpmct I added fly.io here: https://github.com/coder/deploy-code-server/pull/112


Eliminate Squashing PUT operations

Due to my misinterpretation of the client implementation guide, Riak-Cpp currently allows a user to replace any number of siblings blindly with a new value. The correct behavior as described by Russell Brown:

"Clients (that automatically fetch before store) must chose to either
a) perform automatic Sibling Resolution or
b) abort the write and notify the presence of siblings to the caller."

Sibling resolution now appears to be working! Will verify with manual tests.


Test Image

Any suggestions on testing it in demo.ipynb for own test-images?

Any suggestions on testing it in demo.ipynb for own test-images?

Hi, how I test on other images is demonstrated in testing-demo.ipynb. Hope it helps!

Thanks


Call OnConnectedToSpatialOS directly rather than binding to a delegate

Description
We were crashing on a client travel since we were calling the OnConnectedDelegate on an old SpatialNetDriver. We now directly call OnConnectedToSpatialOS on the current NetDriver directly rather than binding to a delegate.
Primary reviewers
@improbable-valentyn @aleximprobable

@padhansell Think you should take a look at this.

Shouldn't this be going straight into the RC?

LGTM. How would we recommend that people hook in to the connection flow now?

@padhansell you would still hook in like normal. We just don't need to hook in the NetDriver since we know the exact function.


MockFileSystem.Path.GetTempPath() returns temp directory with no trailing DirectorySeparatorChar

Describe the bug
When getting the temp path, the returned directory string does not end with DirectorySeparatorChar.
To Reproduce
var fileSystem = new MockFileSystem();
var tempDir = fileSystem.Path.GetTempPath();

Value of tempDir = "/temp"
Expected behavior
Should be tempDir = "/temp/"
Additional context
Using .NET 8 MacOS. Same issue on Windows but with drive letter.
https://learn.microsoft.com/en-us/dotnet/api/system.io.path.gettemppath?view=net-8.0&tabs=linux

Thanks for reporting. I will have a look at it shortly. As a workaround you could also use the MockFileSystem from Testably.Abstractions.


added code to share a query

Closes #879
Test plan:

[x] Checkout this branch of labo-workspace-components, the share-query branch of labs-user-space-api and the 879-share-query branch of clariah-mediasuite
[x] Run the Media Suite locally with a local userspace API  or shall we deploy to test for review?
[x] Create a query and save it to your workspace
[x] Click on the Share button for the query.
[x] Log out of the Media Suite
[x] Paste the link from the clipboard (do NOT log in to the Media Suite when doing this)
[x] Check that you can now view your query

@mwigham will try to have a look today or tomorrow

@mwigham I also updated the npm packages, so you should do a npm install again or run npm update locally to make sure to be in sync with the package-lock.json as well


Mechanical ventilation in eICU

I need the total ventilation time in ICU unit. I checked the respiratorycare table; however, when I checked the minimum and maximum values of the ventstartoffset, ventendoffset columns, and it seems to me that they are inconsistent. And also I checked there are 865224 entries with zero ventendoffset out of 865381 total entries. In other words, only 157 entries have non zero values.
Is there any way to extract this information?

#49 mentions that most of the offsets in respiratorycare are indeed zero. One can get a sense of ventilation times by looking at the timestamps of records that imply ventilation. That is what we are doing for a manuscript under preparation. Once it is finished, we will publish our code.

See https://github.com/nus-mornin-lab/oxygenation_kc/blob/master/data-extraction/eICU/eicu_oxygen_therapy.sql for how we extracted ventilation start and end times.

@willemvandenboom the vantilation start time and end times you extracted means oxygen_therapy? if we want extracte mechanical ventilatio（mv）n duration, we should refer this or some part of your code can represent mv?

@Victorfy Indeed, our focus was oxygen therapy. Oxygen therapy is closely related to (mechanical) ventilation. Therefore, our script for MIMIC (https://github.com/nus-mornin-lab/oxygenation_kc/blob/master/data-extraction/MIMIC/mimic_oxygen_therapy.sql) heavily leans on the one that you reference (https://github.com/MIT-LCP/mimic-code/blob/master/concepts/durations/ventilation-durations.sql).
Getting rid of exclusions due to lack of oxygen therapy in our script for the eICU-CRD (https://github.com/nus-mornin-lab/oxygenation_kc/blob/master/data-extraction/eICU/eicu_oxygen_therapy.sql), yields a way of extracting ventilation start and end times from the eICU-CRD.


refactor out use of numpy.distutils

Fixes #5607 by refactoring places that import numpy.distutils, which is deprecated. numpy.get_include has existed forever (well, since 2006), there is no fear it is missing from an older NumPy.

While looking at the windows CI runs, I saw that the python3.6 one was finishing successfully in 2 minutes, which didn't make sense because all the other windows runs were failing. Looking more closely, it was failing to build a wheel for pywinpty (a dependency of jupyter), which declares support for python>=3.6 on versions 2.0.1 to version 2.0.3 but does not supply a wheel, and fails to build from source. So I added a test-requirements-36.txt file and pinned the version there. I also relaxed the non-numpy restraint on python3.12 since NumPy released a 1.26.0rc1 wheel specifically for python3.12, let's see if tests pass.

CI is green, but 4 jobs failed with exit code 1, all python3.12-dev. I will try to make that fail and not pass, and then fix the dependency

Of course, CI was set to allow failure for 3.12, with a note
Temporary - Allow failure on Python 3.12-dev jobs until they are in beta (feature frozen)

3.12 is now in beta, so I will remove that condition

pstats_profile_test and pstats_profile_test_pyfunc are failing on 3.12. This is the source. Is there a way to run that test stand alone in python? Maybe the pstats format has changed for 3.12.

Maybe due to inlining comprehensions

Is there a way to run that test stand alone in python?

Should just be python3 runtests.py pstats_profile_test_pycfunc. The other thing that might be useful is --no-cleanup-sharedlibs (which leaves the .so files in TEST_TMP so you can run them manually there. With that said, I don't think this needs to be in a numpy.distutils change...

While looking at the windows CI runs [...]

Yeah, there were a few Windows runs that I couldn't easily make work when I was turning off "allow-failures" on the others.

I don't think this needs to be in a numpy.distutils change...

OK. I will open an issue and backout the removal of allowed_failure: true for 3.12-dev

Should just be python3 runtests.py pstats_profile_test_pycfunc

Right, I meant is there a way to run the test in pure-python mode without any cython compilation. I think there may be failures due to changes in traces that appear in the profile.

Right, I meant is there a way to run the test in pure-python mode without any cython compilation. I think there may be failures due to changes in traces that appear in the profile.

Not without editing it manually I think.

Thanks


[Feature]: Document the distributed launch of the carla simulator and agent

Description
No response
Definition of Done
No response

[ ] how to start the remote simulator
[ ] how to finde the correct docker-compose file


Clarify that you can use your own provisioned cluster in create cluster section

In create cluster topic, make it clear you can use your own cluster too

wrong repo


console frontend

not planned?

Hey, what do you have in mind exactly? you mean a ncurses based interface? if so, yeah. i have that in mind using Tcl Ctk lib.

I mean ncurses ofcourse

Yeah, that is planned. in a near future vy would run on console :D


[AutoPR cognitiveservices/data-plane/VisualSearch] Py conf for VisualSearch

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2970

Codecov Report

Merging #2488 into restapi_auto_cognitiveservices/data-plane/VisualSearch will not change coverage.
The diff coverage is n/a.

@@                                   Coverage Diff                                   @@
##           restapi_auto_cognitiveservices/data-plane/VisualSearch    #2488   +/-   ##
=======================================================================================
  Coverage                                                   54.46%   54.46%
=======================================================================================
  Files                                                        6181     6181
  Lines                                                      138036   138036
=======================================================================================
  Hits                                                        75186    75186
  Misses                                                      62850    62850

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e83c2...28a0170. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2489


Cannot slide image?

Bug is related to

[x] embla-carousel (core package)
[ ] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-docs (documentation website)

Embla Carousel version

Latest based on loading Embla from CDN.

Describe the bug

Styling is working but can't get slider to slide.
Refresh page and 99% of the time slider doesn't work, 1% is working.

CodeSandbox
I'm testing on Astro Build.

Steps to reproduce

Slide, it remain on the 1st image, does not slide to the next image.

Expected behavior

I think it might have to do with loading image from 3rd party site? It work for Keen slider when loading images from Unsplash. And note that I'm building and testing on Astro Build .astro page. (https://astro.build/)

Hi @jamesli2021,
What happens when you resize the window. Does the slider start working then?
Best,
David

I remember I have resize and still didn't side, out of my breathe.

@jamesli2021 please log the following and let me know what you get.
console.log(embla.slideNodes());

Captured the console log.
Array(3) [ div.embla__slide.astro-FT4CRSVD, div.embla__slide.astro-FT4CRSVD, div.embla__slide.astro-FT4CRSVD
 ]
0:

1:

2:

length: 3
<prototype>: Array []

I have tested Slide 1...3 text worled but not images.

Hi @jamesli2021,
Thanks for helping out. So this is why your carousel isn’t working.
Either set image placeholders for your images so they take up their space before they’ve finished loading, or run embla.reInit() once all images have finished loading.


[DEP0060] DeprecationWarning

After recently updating my system, when running a build with
npx --version
10.8.3

There now is a DepeciationWarning. To trace the warning, I started the build (server) via
NODE_OPTIONS='--trace-deprecation' npm run serve

and the output is
(node:349871) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
    at Object.<anonymous> ($PROJECTPATH/node_modules/htmlencode/index.js:14:1)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Module.load (node:internal/modules/cjs/loader:1317:32)
    at Module._load (node:internal/modules/cjs/loader:1127:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)
    at require (node:internal/modules/helpers:135:16)
    at Object.<anonymous> ($PROJECTPATH/node_modules/@kevingimbel/eleventy-plugin-mermaid/.eleventy.js:1:20)

Would be great if you could have a look.
Thanks!

If needed, my project is available at https://gitlab.com/senarclens/htl-bulme

Will have a look, thanks for bringing it to my attentions!

Ah well, the dependency hasn't been updated in 12 years! :D https://github.com/danmactough/node-htmlencode
Will need to find a replacement or fork it.


Batch updates on .NET monikerized readmes and tocs and plugins

The OPS build for this branch has failed.

@danieljurek
https://review.learn.microsoft.com/en-us/dotnet/api/overview/azure/?view=azure-dotnet&branch=add_readme_monikers

I'm seeing an error on the review site. Navigating to a package-level overview page causes the ToC to disappear:
(left is actual, right is expected)


Exclude non-contributor extended profile values from embedded map search

In embedded map, we don’t show the extended fields from other contributors. However, when searching by extended fields, we search on fields submitted by other contributors. So for example, Contributor A and Contributor B both submit Facility X. Contributor A says that Facility X has 2000 workers, but Contributor B says it has 100 workers. On Contributor B’s embedded map you will only see 100 workers listed in the facility details. However, Facility X will still be returned in searches for facilities with over 1000 workers. This could make it look like the search is broken in embedded maps.

@mariel-oar - we just wanted to make sure this was on your radar in case this changes upcoming priorities. Happy to discuss in our sprint planning time tomorrow.

Thanks @obrienad , will discuss with the team an update the order in Zenhub accordingly

@jwalgran , to confirm, you mean that the search within EM will still return Facility X as a facility with over 1000 workers instead of a facility with less than 1000 workers, which would be consistent with the EM owners data?
(returning facility X with over 1000 workers in the public search field would be the expected behavior)

Yes, your description is correct.

Mariel confirmed that the focus is on the investigation at this point.

@TaiWilkin I believe you created a writeup of our the implementation we decided on. Could you please attach it to this issue?

The design is located in issue #1867. I've added this to the issue text above as well for easier reference.


Revamping rekor e2e - part 4 of N

Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>Summary

Updated tests for ssh
Updated tests for minisign
Updated tests for intoto
Updated tests for rekord
Updated tests for rc3161

Release Note
NONE
Documentation
NONE

Codecov Report

Merging #1218 (fa1106c) into main (69597b8) will decrease coverage by 22.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1218       +/-   ##
===========================================
- Coverage   64.19%   41.96%   -22.24%
===========================================
  Files          82       74        -8
  Lines        7628     7209      -419
===========================================
- Hits         4897     3025     -1872
- Misses       2102     3874     +1772
+ Partials      629      310      -319

Flag
Coverage Δ

e2etests
?

unittests
41.96% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Cleanup obsolete entries in nodeModules for project files.

Fixes #1334
Problem:
In the process of trying to reproduce #1330, it was noticed that there's almost a completely inverse issue. If a file is renamed, currently it is possible to import from the old name.
Fix:
As a result of falling back from project contents to node modules, as the former are also stored in the latter they were not kept up to date when the project contents had rename or delete type changes which left zombie entries in the node modules which could still be retrieved. The fix was to make incorporateBuildResult cull those obsolete entries by comparing them against the project contents.
This also fixes the origin of files being added in there as they were all being incorrectly attributed to NODE_MODULES as their origin.
Commit Details:

Fixes #1334.
incorporateBuildResult now includes a fix to ensure that entries
get tagged with the correct origin.
incorporateBuildResult ensures that entries for project files
which do not have a matching entry in the project contents are culled.

This PR fixes #1315 too.


Inconsistent password after password change

I changed the password of an account while I had two tabs open to that account (in the same browser). The old page still uses the old password for locking and unlocking the account. I'm also wondering if it's possible that the old password could be inadvertently saved back to the browser cache by the page that still uses the old password.

This issue was moved to bitshares/bitshares-ui#33


Backport Bincoin PR#7348: MOVE ONLY: move rpc* to rpc/ + same for Dash-specific rpc

This is backport of Bitcoin PR bitcoin/bitcoin#7348.
Original description follows.
Was just playing around with the RPC, and found the constant prefixing of file names frustrating.
This also seems to be in line with the way other modules (zmq etc) have been grouped.
Should be easy to review.
Note: This won't negatively impact git blame

PR description is misleading since this also moves Dash-specific rpc files and probably should be fixed. Otherwise looks good.

For me backporting means not just blindly applying changes, but also making all commits look like they were applied to Dash codebase originally. This means adapting Dash-specific parts as well. Without that I would call it "partial backport".
In this case there is a commit that renames all rpc*.{h,cpp} files to rpc/*.{h,cpp}. It would be illogical to rename only files mentioned in original commit and forget to rename a few Dash-specific files.
Of course, I'll try to be more clear how commit was changed to affect Dash-specific code in further backports. But does it make sense to always add "and adapt Dash-specific parts" to backport PR descriptions?


Diffie-Hellman key exchange

Idea
Use of Diffie-Hellman key exchange via minecraft /msg to obtain a shared secret that can be used as the decryption key or phrase for encrypted chat between two NCR users.
Reasoning
To share an encryption key or passphrase in a secure way with another NCR user if you don't have any other form of contact with the other player.
Other Information
No response

the server can still change the key before it reaches the other player (mitm), it doesnt matter if you use some rsa public key to encrypt data or a key for use in dh exchange.
if public keys are sent with minecraft chat, you still need to verify with a secure channel between the 2 users that the right key is received

with DH key exchange, no observer can know the complete key.  It would be quite hard to find valid data to spoof a key during negotiation and would be impractical (at that point you could likely just as well bruteforce the actual key and decrypt messages that way)
You could do it out-of-band as well (like over some external server)

with DH key exchange, no observer can know the complete key

the server is not only an observer, it can change content on the way to the receiver

It would be quite hard to find valid data to spoof a key during negotiation and would be impractical (at that point you could likely just as well bruteforce the actual key and decrypt messages that way)

no.
imagine player A and B, and a server
keypairs are generated
player A has a keypair (a, A) (a is the private key, A the public key) A, B has (b, B), and the server generates two keypairs (s1, S1) and (s2, S2).
normal procedure:
player A sends A in the chat, player B sends B in the chat, player A sees it and calculates aB, player B sees player A's message and calculates bA. aB == bA so you have a shared secret.
now the server is evil:
player A sends A in the chat, the server records this and sends out S1 (as if player A sent this), player B sends B and the server again intercepts this and sends S2. player A has aS2, a shared secret between the server and player A and B has bS1, a shared secret between the server and player B. the server has As1 and Bs2. when player A encrypts a message using aS1, the server decrypts it using As2 and encrypts it with Bs1, so player B can decrypt it with bS1, player A and B think their communication is private, but the server can read and change the messages.
A and B at least have to verify using a secure channel that their shared secrets are the same (or hashed to not have to send a secret but instead a fingerprint)

You can sign the sent key with the player's chat reporting key and then verify that on the other player's client, retrying/refusing the key exchange if said signature is invalid

You can sign the sent key with the player's chat reporting key and then verify that on the other player's client, retrying/refusing the key exchange if said signature is invalid

this would work, but this introduces a trusted third party (microsoft), why not use the chat keys in the first place then? that key exchange is already done when connecting to servers

@kcinnaJlol by the way, this would not be safe on realms, as microsoft owns the chat signing keys


xdg-activation: Pass on activation id when we don't find a token

If the activation happened via another protocol (such as startup
notification protocol,  gtk_shell1 or other compositor specific
mechanisms the compositor might know about the id but don't have a valid
token. Just pass on the id in this case so it can match up things against
it's token list.
See https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/staging/xdg-activation/x11-interoperation.rst

Maybe a better approach would be to allow compositors to generate fresh new xdg-activation tokens.

Has this been superseded by https://github.com/swaywm/wlroots/pull/3146?

Please re-open if necessary.


[v3] reanimated interpolateColor doesn't update theme color

Description
When using interpolateColor from reanimated, with theme colors from unistyles, if the theme is changed, the color is not updating to the right theme's color.
unistyles.ts
// ...

const themes = {
  light: {
    background: "#ffffff",
    box: "#0000ff",
  },

  dark: {
    background: "#000000",
    box: "#ff0000",
  },
};

StyleSheet.configure({
  themes,
  settings: {
    adaptiveThemes: true,
  },
});

index.tsx
// ...

export default function Index() {
  const { box } = UnistylesRuntime.getTheme();
  const sv = useSharedValue(0);

  const boxStyle = useAnimatedStyle(() => ({
    backgroundColor: interpolateColor(sv.value, [0, 1], [box, "#00ff00"]),
  }));

  return (
    <View style={s.wrapper}>
      <Animated.View style={[s.box, boxStyle]} />
    </View>
  );
}

// ...

https://github.com/user-attachments/assets/4964cf30-ce1d-4b9c-9dec-4849f3fc5506
Steps to Reproduce

git clone git@github.com:jeremybarbet/interpolate-color-reproducer.git
yarn/yarn ios
Go to system settings, switch from light to dark mode
Box background doesn't update

Snack or Repository Link (Optional)
https://github.com/jeremybarbet/interpolate-color-reproducer
Unistyles Version
3.0.0-beta.1
React Native Version
0.76.3
Platforms
Android, iOS
Expo
Yes

Thanks for putting it down from Discord to Github.
Context:
Unistyles is not (yet) capable of using worklets or sharing up-to-date values. But it will be!
I will definitely bring it on before 1st stable release.


Vizalert_Issue

Hi
How do I send email notification and PDFs generated on my tableau server to my gmail ID?
Thanks

Closing as a duplicate of Issue #100


Add authTokenSettingName parameter to ValidateRequestAttribute

Currently, to use ValidateRequestAttribute, you have to pass the Twilio auth token to the authToken parameter.
This can only be done by hard-coding the token into the parameter or into a const string and passing the const to the parameter, either of which result in embedding the auth token into your assembly.
Hard-coding the auth token is a bad practice.
IMO, we should offer an alternative and mark the existing parameter as obsolete.
I suggest we add a new parameter authTokenSettingName which will

for .NET Framework, look up the auth token in AppSettings.
for .NET (Core), look up the auth token from IConfiguration

An alternative solution for .NET Core would be to add code to the startup class which will configure the auth token using the Options pattern.
Both these options seem like sensible defaults to me, and if the user wants a different implementation, they can inherit from ValidateRequestAttribute and add their own logic to it.

Solution added in 6.0.0-alpha, see PR #64 for more details.
.NET Framework is still todo.

.NET Framework solution has been merged in. Will be part of the next major release.


[DOCS] Add basic developer documentation

Which page or section is this issue related to?

Add basic developer documentations as here: https://docs.v1.argilla.io/en/latest/community/developer_docs.html
Although pointing to the READMES for most of the cases.

@sdiazlor I agree. I think we can redirect users to the corresponding readmes within argila-server and argilla-frontend where needed.


Adjusting dates for child flows DLP rollout

Learn Build status updates of commit 8b7f80b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/prevent-data-loss.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 8a359c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/prevent-data-loss.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add ever use to simple choice module

Once ever use is added as an attribute (issue #360), update simple choice contraceptive function to include this as well as age. Coefficients are attached.
contra_coef_simple_pp1.csv
contra_coef_simple_pp6.csv
contra_coef_simple.csv

this has been implemented in PR #359


Signature algorithm falsely assumes CA private key type

When we tried to deploy aws-pca-issuer and we hit by the following issue:
2021-05-25T11:33:33.261830000Z {"level":"error","ts":1621942413.261467,"logger":"controllers.CertificateRequest","msg":"failed to request certificate from PCA","certificaterequest":"opa/akunszt-test-9jl58","error":"InvalidArgsException: Signing algorithm SHA384WITHECDSA cannot be used with key type RSA_2048. Valid signing algorithms are: SHA256WITHRSA, SHA384WITHRSA, SHA512WITHRSA.","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132\ngithub.com/jniebuhr/aws-pca-issuer/pkg/controllers.(*CertificateRequestReconciler).Reconcile\n\t/workspace/pkg/controllers/certificaterequest_controller.go:171\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:298\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:253\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:216\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:99"}

This was caused that the signatureAlgorithm function determines the signature algorithm from the certificate request, not from the signing CA.
https://github.com/jniebuhr/aws-pca-issuer/blob/f2e355d766e625d3c55b287d2a260bbdff5d61ff/pkg/aws/pca.go#L161
We have a CA in ACMPCA with an RSA_2048 key and we wanted to issue an ECDSA certificate. This doesn't work in aws-pca-issuer but it works if you properly set the signing algorithm.
We're using this to issue a certificate using ACMPCA from the command line - it's a snippet from a far bigger script, this is just the bare logic.
# the algorithm for the local key
LOCAL_CURVE_NAME="secp384r1"

# the algorithm used by the PCA to sign the certificate
# - if the PCA has an EC key then this should be SHA512WITHECDSA
# - it the PCA has an RSA key then this should be SHA512WITHRSA
PCA_SIGNING_ALGORITHM="SHA512WITHRSA"

### zillion lines of code to create a private key and a CSR, check a lot of things, etc...

aws acm-pca issue-certificate \
                        --certificate-authority-arn "$PCA_ARN" \
                        --csr file:///dev/stdin \
                        --region "$AWS_REGION" \
                        --signing-algorithm "$PCA_SIGNING_ALGORITHM" \
                        --template-arn "arn:aws:acm-pca:::template/$TEMPLATE" \
                        --validity "Value=$EXPIRES_IN,Type=DAYS" \
                        --query CertificateArn \
                        --output text < "csr.pem"

We use the same algorithm everywhere but for a general solution you can fetch the signing CA private key easily with:
aws acm-pca describe-certificate-authority --region "$REGION" --certificate-authority-arn "$ARN" --query "CertificateAuthority.CertificateAuthorityConfiguration.KeyAlgorithm" --output text

The aws-pca-issuer should fetch that and then use that information to construct the signing algorithm. Another solution could be to set that in the AWSPCAClusterIssuer/AWSPCAIssuer resources. It's rarely changes on it's own as it requires to recreate the CA on the AWS side.
A little background information why we wanted to do this:
You can use the ACMPCA to sign certificates in ACM only if the CA uses an RSA-2048 key. It's a known limitation of ACM at the moment. We have one regional CA - as they're quite costly - which we can use to issue certificates from the AWS web console in ACM or from Kubernetes using Certificate resources. This is why we have to use the RSA-2048 for the CA but we would like to use ECDSA for the certificates issued by the CA to make them a bit more future proof.

I will be looking at this issue early next week.

This issue was resolved with https://github.com/cert-manager/aws-privateca-issuer/pull/35.


Add dark mode

Is your feature request related to a problem? Please describe.
Maybe not a problem, but with the dark mode feature it becomes a comfort for users, especially in the eyes.
Describe the solution you'd like
I want to contribute to adding a dark mode feature to your application, with the features offered by Tailwind version 2.0+.
Describe alternatives you've considered
By adding it in the header or navbar.
Additional context
I hope and I want to contribute to developing this feature. please permission🙏🏼

okay thanks for your contribution

You're welcome, ok I'll try

see my pull req.


Sync release-2023a branch with ODH 2023a branch

Sync release-2023a branch with ODH 2023a branch
This contains cherry-pick from the ODH 2023a, following is list:
https://github.com/opendatahub-io/notebooks/commit/b6b346a3ad9fab970200e99345411bce6908cada
https://github.com/opendatahub-io/notebooks/commit/10933ddf9af8f5c72e912cec3f4e0493e3151350
https://github.com/opendatahub-io/notebooks/commit/17561d071dbe3bcad31dcfefa63d8b773e452dd5
https://github.com/opendatahub-io/notebooks/commit/0e6c7bec8529b73247a8e36a1d98428442ff76fe
https://github.com/opendatahub-io/notebooks/commit/ad4cf21917763a670e05d13ac4c6545544f194fe
https://github.com/opendatahub-io/notebooks/commit/6f108109c7a6fc02cf8e151495b25a6c5011b98c
https://github.com/opendatahub-io/notebooks/commit/8c0a7e526b648c622e0a660ee58d6adf270742e2
https://github.com/opendatahub-io/notebooks/commit/860c8279f5b3c0d966570649f8532501aed3bd18
https://github.com/opendatahub-io/notebooks/commit/70700f27a50547664b065d318379556424f2e408
https://github.com/opendatahub-io/notebooks/commit/6a6098de58c28f1b9d7d7014b1c86e819d0e0424
https://github.com/opendatahub-io/notebooks/commit/ae91983cacb189559d5a10087403a733fad9903d

Merging in to get the final image to be built from release-2023a branch


Add an javascript index file in component

In order to use import 'button'; instead of import 'button/button';, we should add an index.js in component folder which only do import of button.js.

When using collection of components packaged into a npm module, its more concise to just import component with the name of the component instead of component_name/component_name. But we can delayed the feature, and discuss about it.

I am closing this issue, feel free to reopen to discuss more about usage of an index.js file instead of explicit naming.


Memory pool using lru algorithm

May I ask why your memory pool implementation uses the LRU algorithm? Where is the specific role reflected?

HevMemoryAllocatorSlice has caching capability, using the LRU algorithm to evict the least recently used size of memory blocks.

I mean does this really improve performance? Because I have almost never seen the lru algorithm in memory pool projects


Add ability to pass in .gif file into layers instead of having to split it into png using https://ezgif.com/split

This will be tracked here https://github.com/jalagar/Generative_Gif_Engine/issues/15


Fixed the coin value to display it's actual value.

Description
When checking the value of coins, it will now display the coins quantity (value) instead of false.
Related Issue
#99
Motivation and Context
The coins would display a false value when inspecting it's value.
How Has This Been Tested?
Q&A (manual testing)
Screenshots (if appropriate):

Types of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

You rock! Thank you.


[SPARK-10081][Core ] Skip re-computing getMissingParentStages

JIRA: https://issues.apache.org/jira/browse/SPARK-10081
This is a small patch that skips one unnecessary getMissingParentStages calling in handleJobSubmitted.

Merged build triggered.

Merged build started.

Test build #41105 has started for   PR 8269 at commit 8416b7f.

Test build #41105 has finished for   PR 8269 at commit 8416b7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41105/
Test PASSed.

lgtm

Merged build triggered.

Merged build started.

Test build #41509 has started for   PR 8269 at commit 8416b7f.

Test build #41509 has finished for   PR 8269 at commit 8416b7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41509/
Test PASSed.

How much time does this actually save? This seems fine I wonder if this is actually worth doing since you only traverse the stage hierarchy again, which most likely isn't that deep.

On second thought I don't think the optimization here is worth the extra complexity. How much time do you actually save? Even in something like ALS you only have say 20 stages or something. The new signature is actually somewhat confusing: what does it mean to pass in both a stage and its missing stages? What if we accidentally pass in the wrong missing stages?
I would recommend we close this PR since the scheduling delay it saves is negligible.


How Can I Help?

I would love to contribute to this project. Let me know I can be the most help.

Great :) You could help with any of:

Developer Req's / "real world" test:  right now I've only re-created some very basic examples from the Angular2 site, and I'm working on an adoption of the TodoMVC app (which still doesn't even use http or routing). Hence most of the Angular2 features are not available yet. So it would be great if you could start a somewhat complex pet project with angulate2, and post an issue (or a pull request :) whenever you hit the wall due to missing features. Furthermore, it's not always the best option to simply mimic the TypeScript experience of Angular2, when there is a simpler solution due to Scala's own features. I would appreciate any feedback discussion on usability, etc.

Implementation: well, take a pick from the Angular2-API... I have rewritten the macro code for annotations, so it should be quite simple to add new/ extend existing annotations. Furthermore, I think angulate2 should also provide façade traits for the Angular2 ES5 API (e.g. ng.core.Component(...).Class(...)).

Design/ integration with Angular2 libs: currently, angulate2 uses the all-in-one ES5 libs of Angular2. I'm not sure, if this is the best approach in the long term, especially w.r.t integration with Angular2 libs. I think it would be useful to evaluate the "ES2015 API" (is it feasible to use it with Scala.js? I haven't even checked the differences, maybe it's only the modue loading?)

Tests: I had started a very basic test suite for one of the Angular2-alphas, but it is now defunct. angulate2 really should have at least some unit tests to detect changes in the Angular2 API...

Just let me know, if you need any help.

Great thanks. I'll start on the Developer Req's / "real world" test in conjunction with integration of the angular2 libs. One of my primary interests is to get Ionic2(and by necessity angular2) running on scala.js . Since some members of the ionic2 team are also on the angular2 team, I would consider their approach to tooling angular2/Ionic2 a good starting point.
My initial approach would look something like this
-integrate webpack into sbt for constructing usable input of angular2 components(or any other web component based JS) into the scala.js compiler.
-migrate my typeapp project to scala.js and angulate2. This app has routing, local and library services, data binding and integration with couchbase lite via its REST API implemented. It could become a kitchen sink example for angulate2

identify and implement the angular2 APIs needed to get a kitchen sink app running

That's a good idea - I don't use Ionic myself (yet), so your typeapp port would be a perfect complement to my own pure-Angular2 examples. I'm also looking forward to your sbt webpack solution; it would be awesome if we could customize the angular2 modules to be used (and even include them in the Scala.js dependencies file?), instead of loading the full ES5 lib (which still is not minified correctly)!

Is there a repository trying to port typeapp to angulate2?

No, not that I'm aware of. Are going to?

I'm working on implementing the entire MEAN stack in Scala.js (https://github.com/ldaniels528/MEANS.js). So far I have basic bindings/facades for MongoDB, Express, AngularJS (inspired by your excellent scalajs-angulate) and Node. I'd love to replace my AngularJS bindings with your Angular 1 and Angular 2 bindings, and I'm working on porting one of my applications to MEANS.js (see attached image), which would provide an awesome example of how to implement both Angular and Node.
I'd really like for us to pool our efforts and create something really great!

@ldaniels528 I've browsed your MEANS stack, which is really quite impressive already! Your angular binding is much cleaner (and more complete?) than scalajs-angulate, so you probably shouldn't replace your implementation, but sure, let's pool our efforts.
Right now I'm mostly working on angulate2 (which still has problems with the static object annotations required by Angular2 and integration with ES6 modules), and I will publish scalajs-angulate 0.3.0 with new features for AngularJS 1.5 (components, component router).

@ldaniels528 Some additional thoughts: I think it would be useful to have a (partially) synchronized release cycle for your stack and other Scala.js bindings (angulate2) to avoid dependency problems (e.g. with the Scala.js version). A common policy for API design or even a shared utilities packages (e.g. for conversions, "enriched" types, etc) could be useful as well. WDYT?

@jokade I would agree. What I'd really like to accomplish is creating a rich ecosystem for Scala.js, where developers have bindings for the vast majority of popular JavaScript libraries; thus, to accomplish this, we have to ensure that the bindings properly interact with one another without headaches and/or compromises. I think the first step toward that is what you're suggesting here.

@jokade BTW, I have published the full-featured example application pictured above: https://github.com/ldaniels528/socialized

@jfspencer I could definitely use your help with MEANS.js (https://github.com/ldaniels528/MEANS.js) if you're interested?

@dejvid I do plan to port the typeapp over, I have needed to shelf that work, but will be starting on it soon. I'll let you know when I have the repo started.
@ldaniels528 I will be able to contribute in a couple weeks. I will ping you when I'm ready.

@dejvid @jfspencer
Hello,
It's been awhile, so I figured I'd reach out to see if perhaps you're still interested in pooling our efforts to build out a new platform. Currently, ScalaJs.io [https://github.com/scalajs-io] (formerly MEANS.js) is at version <IP_ADDRESS> (v<IP_ADDRESS> should be out in the next couple of days - lots of bug fixes) and there are about 60 bindings for the most popular npm packages. It's still lacking an Angular 2 binding, but I'm hoping with your help we could remedy that problem.

@ldaniels528 Hmm, not sure I understand your goal; what's currently in the way of using this project with ScalaJs.io?


Issue when adding inline style on  root

Hi, thanks for this project! I am integrating it into an app running React 16 and quickly ran into this issue when adding an inline style tag onto the <Treebeard /> react element.
I need to dig some more, but would be happy to fix and PR.

style key value must be an valid JSON object. Please create your own style as per given format. Please refer:
https://github.com/alexcurtis/react-treebeard/blob/master/src/themes/default.js


I want to ask about how to change link to https in larecipe

Currently, when my site use https, but css file and js file still load as http. So, this error occur:
Mixed Content: The page at 'https://abc.net/docs/v2.1/overview' was loaded over HTTPS, but requested an insecure favicon 'http://pinpoint-qat-development.geocomply.net/'. This request has been blocked; the content must be served over HTTPS.

So, can anyone suggest to me how to fix it? Thank you!

Search for and destroy that fav icon. That’s not an issue for anyone else using larecipe out of the box or with custom css

Hi @Will Goldstein
I don't understand what do you mean
Sorry
I mean I want to ask about how to load with https
<html>
    <head>
        <!-- META Tags -->
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
        <title>PinPoint Overview | PinPoint Beacon Manager</title>
        <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
        <meta name="viewport" content="width=device-width, initial-scale=1">

        <!-- SEO -->
        <meta name="author" content="">
        <meta name="description" content="">
        <meta name="keywords" content="">
        <meta name="twitter:card" value="summary">
                    <link rel="canonical" href="http://beacon-mgmt-web.geocomply.local/docs/v2.1/overview" />
                                                                                <meta property="og:type" content="article" />

Example
I want to canonical load as https, not http

I've not seen that in the larecipe code base - it's not in mine. I may not be fully up to date, but I doubt it's in the master. Can you show me which larecipe file has that?

Literally just downloaded master. Cannot find that anywhere. This is an issue with your code

Hi @will Goldstein

hello

Hi @will Goldstein

hello

@will geeze that must happen way too often to you 🤣

have you fix it?

Hi
I have already fix it. Thank you.
On Thu, Mar 12, 2020 at 12:35 Saleem Hadad<EMAIL_ADDRESS>wrote:

have you fixed it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/saleem-hadad/larecipe/issues/196#issuecomment-598015083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACEWHJINUIXIOX74MA574XDRHBYBPANCNFSM4KY4BLMA
.

--
Mr. Trần Công Minh
Technical Leader
GREVO CO., LTD
90 Nguyen Dinh Chieu St, Ward Da Kao, Dist 1, HCMC
Mobile: (+84) 901313290


feat(base): Set Default Path to '*' for app.use()

fixed: #1754
In the previous implementation, if a path was not specified in the app.use method, the route would default to the current path. This was inconvenient when wanting to apply middleware to all requests without specifying a specific path.
The main change is as follows:
We modified the use method in the Hono class so that if the first argument is a middleware function, the default path is set to '*'. This could be a breaking change when the first argument is not specified, and therefore, it might be appropriate to manage this under the v4 branch
Author should do the followings, if applicable

[x] Add tests
[x] Run tests
[x] yarn denoify to generate files for Deno

Hi @watany-dev,
Totally agree. And as you've pointed out, since this will be a breaking change, let's plan to introduce it in v4. Thanks!

I like this! This was the behavior I expected when calling .use() without a path, and every time I get confused when it doesn't work

Hi @watany-dev !
I made the v4 branch. I'll merge this into v4 now!


Allow for use of other registries in docker::image

The current docker/manifests/image.pp does not allow for using registries other than docker.io.
The docker::params should really be updated to allow for passing a registry value and any authentication needed.  Then those values can be used in docker::image.  If there's auth, then you have to login to the registry before running docker::pull.
The image_find variables need to be updated to also look for the registry provided in the image name.

I see now that it looks like 4.1.1 has this ability.   (I'm on 4.0.2).  Looking for changelogs now to see what else has changed.

aha.  So if you use the fully qualified registry and image name, you could pull from it.  However, with 4.1, we now have the ability to use a registry with authentication.


Fixed #29637 -- Protect against unauthorized edits without breaking TabularInline formsets

See #29637

I could not reproduce the failed checks, using a dockerized Python 3.5 environment on my macOS system, so I would be more than happy to get some external insight if I am to fix these issues.


misc: avoid using fs.realpathSync in website

fixes yarn start, from @Josh-Cena

For context: this doesn't work on virtually every Windows machine. See https://github.com/facebook/docusaurus/issues/7052 for one.
fs.realpathSync is really not very useful because it just points to the original directory. We may well just use the original one, then.

I don't understand, how do we test for our symlinked dir support now?

How is fs.realpathSync testing anything in practice, though? It always evaluates to "_dogfooding/_docs tests". On machines that don't support symlinks (i.e. all Windows machines), it always causes an error that I have to teach them to fix. Previously when we had resolve.symlinks: false for Webpack, it seems more worthwhile to test.

ok 👍 true


Right click performs left click

Having the option of clickable url is great, so is setting for new tab or not. So I link clickable urls and not open in new tab as when I want to do this I right click on the link and choose from the Chrome menu Open In New Tab but is not an option using this extension as right clicking on a link just performs the left click action. Apart from that it is great.

This is related to issue #93 and I totally agree that this should be improved. Thanks!

PR fixing this #118 (not merged yet)

It is possible to configure if the links should be opened in a new tab or in place (openLinksInNewWindow), maybe this is enough, what do you think?

I'd like to do both..single left click stays in the tab but when I want a new tab I can right click on a link and choose open in new tab....plus I've read you can't' highlight then right click to choose copy either

It looks like this issue is more generally that "Any mouse click triggers a clickable link to open", since this also occurs for mouse buttons other than Left/Right (e.g. middle, thumb buttons).

It looks like this issue is more generally that "Any mouse click triggers a clickable link to open", since this also occurs for mouse buttons other than Left/Right (e.g. middle, thumb buttons).


Fix acme_r2d2 test and make GitHub auto-run it on linux-only

The current test which is ignored by the GitHub auto-testing infra setup uses agentos install to pull down the different Acme R2D2 components using the registry, each of which lives in its own GitHub repo.
We should have a test for each agent we support. For now, I ported the Acme R2D2 agent as a directory inside of example_agents rather than components available via the registry. So we should write a simple test that cds into that agent's directory, pip installs its requirements, and then executes agentos run and agentos learn, and possibly agentos reset
In addition we should make sure that we still have test coverage of the registry functionality (install/upgrade) -- tracked in #162

@nickjalbert I'm pretty sure this is done so I marked it as complete. Can you just confirm you agree?


Stencil attachment with format VK_FORMAT_S8_UINT replays as D8 with incorrect results

Description
Using a render pass with a stencil attachment with format VK_FORMAT_S8_UINT, RenderDoc detects it as a depth attachment with the D8 format. This causes the replay to look incorrect, for example the values read from the stencil texture show as float depth values, the contents show as LOAD DONTCARE (because depth load is dont't care), the overlay shows stencil test failing, and overall the result is incorrect.
RenderDoc capture on Nvidia/Linux: https://drive.google.com/file/d/1l_i6JLkiAQvN8SOHrRMLxPxkPvklmN5b/view
Steps to reproduce

Create a render pass with color and stencil attachment. Use VK_FORMAT_S8_UINT for stencil format.

Use load/store=DONT_CARE and stencilLoad/Store=LOAD/STORE

Capture and replay through RenderDoc, observe that the stencil attachment is detected as a depth attachment with D8 format

Here is a capture of a test that is similar to the above (has 2 render passes, but that's inconsequential): https://drive.google.com/file/d/1l_i6JLkiAQvN8SOHrRMLxPxkPvklmN5b/view

Environment

RenderDoc version: tag: v1.17 (built from source with -DCMAKE_BUILD_TYPE=Release -Bbuild -H. -DENABLE_GLES=OFF -DENABLE_GL=OFF)
Operating System: Linux
Graphics API: Vulkan
GPU: Nvidia Quadro P1000

Thanks for the repro case. That commit should fix the issue - S8 should be correctly identified as stencil and everything else falls out from there. There's slight overlap between this and #2437 so the fix for that issue also applies here (properly respecting the stencil load/store ops for stencil aspect instead of using the depth ones for discard patterns).


jinja2 requirement not declared, refgenie fails to run

I believe that I have tracked a refgenie failure to run to this package
I think it is caused because jinja2 dependency in not listed as a requirement of this package
Running a fresh install of refgenie generates the following error:
pipestat/html_reports_pipestat.py", line 9, in <module>
    import jinja2
ModuleNotFoundError: No module named 'jinja2'

@ialbert thank you for raising this issue! sorry for the inconvenience
I believe we have solved this on dev: https://github.com/pepkit/pipestat/issues/91
@donaldcampbelljr we should probably do a bugfix release to fix this ASAP, since it's breaking other tools (refgenie), unless the release of full new pipestat version is imminent

I feel that the bug is a showstopper for anyone not sufficiently well-versed in Python packaging - basically renders the refgenie tool unusable.
The conda versions do work as expected - but now that I looked more closely the same refgenie 0.12.1 installed via conda does not the use pipestat library - which I found quite suprising
upon even more investigation, it looks like a package called piper that started to use pipestat with a certain version.  The conda version being in a working state is more of an accidental outcome of the various package resolution orders. But basically what this means that piper does not work either on a fresh install on the same account. Even more reason to add the bugfix.
With tools like refgenie I would strongly suggest that the documentation recommends installation via  pipx - rather than pip  the tool has a large number of dependencies with unexpected resolutions.

Thank you for bringing this to our attention @ialbert
There is now a new pipestat point release available which addresses this issue.
https://github.com/pepkit/pipestat/releases/tag/v0.5.2

thanks everyone for the quick resolution!Qqqqq