Access to pinpoint app id using cloudformation

Before opening, please confirm:

[x] I have searched for duplicate or closed issues and discussions.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

JavaScript Framework
React Native
Amplify APIs
Authentication, Analytics, REST API, Push Notifications
Amplify Categories
auth, function, api, analytics, notifications
Environment information

  System:
    OS: macOS 11.4
    CPU: (4) x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
    Memory: 1.50 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.3.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.16.0 - /usr/local/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Browsers:
    Chrome: 92.0.4515.107
  npmPackages:
    @aws-amplify/pushnotification: ^4.1.2 => 4.1.2
    @aws-amplify/ui-react: ^1.2.2 => 1.2.2
    @babel/core: ^7.12.9 => 7.14.5
    @babel/plugin-proposal-decorators: ^7.14.5 => 7.14.5
    @babel/runtime: ^7.12.5 => 7.14.5
    @react-native-async-storage/async-storage: ^1.15.5 => 1.15.5
    @react-native-community/eslint-config: ^2.0.0 => 2.0.0
    @react-native-community/netinfo: ^6.0.0 => 6.0.0
    @react-native-community/push-notification-ios: ^1.8.0 => 1.8.0 (1.0.3)
    @react-native-picker/picker: ^1.16.1 => 1.16.1
    HelloWorld:  0.0.1
    RNCameraExample:  0.0.1
    advanced:  0.0.1
    amazon-cognito-identity-js: ^5.0.3 => 5.0.3
    aws-amplify: ^4.1.0 => 4.1.0
    aws-amplify-react-native: ^5.0.2 => 5.0.2
    babel-jest: ^26.6.3 => 26.6.3
    eslint: 7.14.0 => 7.14.0
    hermes-inspector-msggen:  1.0.0
    javascript-time-ago: ^2.3.7 => 2.3.7
    javascript-time-ago-cache:  1.0.0
    javascript-time-ago-gradation:  1.0.0
    javascript-time-ago-prop-types:  1.0.0
    javascript-time-ago-steps:  1.0.0
    jest: ^26.6.3 => 26.6.3
    metro-react-native-babel-preset: ^0.64.0 => 0.64.0
    mlkit:  0.0.1
    mobx: ^6.3.2 => 6.3.2
    mobx-react: ^7.2.0 => 7.2.0
    react: 17.0.1 => 17.0.1
    react-chat-elements: ^10.15.0 => 10.15.0
    react-native: 0.64.2 => 0.64.2
    react-native-camera<EMAIL_ADDRESS>=> 4.0.0
    react-native-device-info: ^8.1.3 => 8.1.3
    react-native-elements: ^3.4.2 => 3.4.2
    react-native-get-random-values: ^1.7.0 => 1.7.0
    react-native-gifted-chat: ^0.16.3 => 0.16.3
    react-native-inappbrowser-reborn: ^3.5.1 => 3.5.1
    react-native-permissions: ^3.0.5 => 3.0.5 (2.2.2)
    react-native-push-notification: ^7.4.0 => 7.4.0
    react-native-qrcode-scanner: ^1.5.4 => 1.5.4
    react-native-safe-area-context: ^3.2.0 => 3.2.0
    react-native-svg: ^12.1.1 => 12.1.1
    react-native-vector-icons: ^8.1.0 => 8.1.0 (4.6.0)
    react-test-renderer: 17.0.1 => 17.0.1
    src:  undefined ()
    tests:  0.0.1
  npmGlobalPackages:
    @aws-amplify/cli: 5.2.0
    ios-deploy: 1.11.4
    npm: 7.16.0
    yarn: 1.22.10

Describe the bug
There it is my amplify stack:

Category
Resource name
Operation
Provider plugin

Function
fooEndpoint
No Change
awscloudformation

Auth
cognito10309729
No Change
awscloudformation

Api
fooapi
No Change
awscloudformation

Notifications
foo
No Change

Analytics
foo
No Change
awscloudformation

I try to retrieve the pinpoint app id (associated to Notifications foo) and to use it in the definition of my lambda function fooEndpoint.
When I try do an amplify push when fooEndpoint define a dependency with Notification foo such it is supposed to looking for the pinpoint notification app id, the command raise the following error:
Template error: instance of Fn::GetAtt references undefined resource notificationsfoo
An error occurred during the push operation: Template error: instance of Fn::GetAtt references undefined resource notificationstestdOdfZ

Expected behavior
I expected to be able to retrieve and use the pinpoint notification app id as a parameters of my lambda function
Reproduction steps
Step 1:
create an amplify project with notifications and a lambda functions.
(Even if you allow the lambda function to create/delete and so on with notifications services nothing happen)
Step 2:
Based on the documentation https://docs.amplify.aws/cli/usage/customcf#n3-optional-reference-existing-parameters I configure the following files as below:
amplify/backend/backend-config.json :
{
   ...
   "fooEndpoint": {
       ...
       "dependOn": [{
            "category": "notifications",
            "resourceName": "foo",
            "attributes": ["Id"]
        }]
   }
   ...
}

amplify/backend/function/fooEndpoint/parameters.json :
{
  "notificationsFooId": {
    "Fn::GetAtt": [
      "notificationsfoo",
      "Outputs.Id"
    ]
}

and amplify/backend/function/fooEndpoint/fooEndpoint-cloudformation-template.json with notificationsFooId in Parameters section (+ where I need it...)
Step 3: amplify push
Code Snippet
// Put your code below this line.

Log output

(base) elix@mbpdejebaptiste test % amplify push
✔ Successfully pulled backend environment dev from the cloud.

Current Environment: dev

| Category      | Resource name   | Operation | Provider plugin   |
| ------------- | --------------- | --------- | ----------------- |
| Function      | fooEndpoint    | Update    | awscloudformation |
| Auth          | cognitoe2a041e8 | No Change | awscloudformation |
| Notifications | foo       | No Change |                   |
? Are you sure you want to continue? Yes
Installing dependencies from Pipfile.lock (e02f68)...
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/0 — 00:00:00
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
✖ An error occurred when pushing the resources to the cloud

Template error: instance of Fn::GetAtt references undefined resource notificationsfoo
An error occurred during the push operation: Template error: instance of Fn::GetAtt references undefined resource notificationsfoo

aws-exports.js
No response
Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response

Hey @jeanbaptistepriez :wave: thanks for raising this! Unfortunately given the current implementation where notifications are created via the AWS SDK and not CloudFormation, this is currently not possible out-of-the-box as we are unable reference the output. For that I will mark this as a feature-request.
As a workaround we can leverage environment variables or secrets with Lambda functions to manually input the notification's ID for consumption inside your Lambda. For reference, the ID's value is captured as an output in the amplify-meta.json file.

Ok thanks for your answer.
I found a workaround:

As you describe I retrieve the pinpoint id in amplify/backend/amplify-meta.json
I add this id in the amplify/team-provider-info.json file:

{
  "dev": {
     ...
     "categories": {
        ...
        "function": {
           ...
           "maFunction": {
              "pinpointId": "xxxxxxxx",
              "deploymentBucketName" ...
              ...
           }
        }
     }
  },
  "prod": {
     ...
     "categories": {
        ...
        "function": {
           ...
           "maFunction": {
              "pinpointId": "yyyyyyyyyy",
              "deploymentBucketName" ...
              ...
           }
        }
     }
  }
}

I add this pinpointId as a parameter of the cloudformation template
the amplify push (+ amplify env checkout ...; amplify push) works.

Is it a "not so bad practices" or I risk to get some side effect ?
If it makes sense I suggest to you to enrich the documentation https://docs.amplify.aws/cli/usage/customcf#n3-optional-reference-existing-parameters to describe this ability to pass env specific parameters from outside of cloudformation

Hey @jeanbaptistepriez glad you were able to find a workaround.

Is it a "not so bad practices" or I risk to get some side effect ?

This value will be included in your stack's CloudFormation template.

I have a similar issue where I'm trying to configure a DynamoDB trigger to point to a lambda function in the respective dev and prod Amplify environments. Is this a sanctioned approach, @josefaidt? It seemed to work upon pushing to each of my environments. Is manually modifying team-provider-info.json something the Amplify team expects or might this blow up in the future?
To expand on the solution from @jeanbaptistepriez...
Within my amplify/team-provider-info.json:
  "prod": {
      "....": {},
      "function": {
        "myFunction": {
            "deploymentBucketName": "amplify-...-deployment",
            "s3Key": "amplify-builds/...-build.zip",
            "dynamodbTransitStreamARN": "arn:aws:dynamodb:us-east-1:..."
         }
     }
}

And at the top of my amplify/function/myFunction/myFunction-cloudformation-template.json:
"Parameters": {
  "dynamodbAccountItemStreamARN": {
        "Type": "String"
  }
}

Hey @chancyk :wave: from the documentation page for Amplify files and folders it is not recommended to manually edit the team-provider-info.json file. We may see these values are removed after performing additional amplify commands to the resource.

@josefaidt Thanks! Is there a recommended approach to achieve the same affect? It seems like the parameters.json files may be intended for a similar purpose, but they don't seem environment aware like team-provider-info.json.
In my case I'm trying to attach a Lambda function to a DynamoDB stream, so I need to grab the stream ARN for both dev and prod. This is kind of a band-aid though due my ignorance of how to properly sequence the stream association and DynamoDB table creation to just grab it using CloudFormation in the first place.


Need Backbone support for latest SDK

I am currently building an backbone app (items added to a table for each Google form submitted for review). I am on parse 1.2.13 JS SDK.
Migrating to 1.6 will obviously mess up my working code since there is no Collection class.
I am somewhat new to web development. Could someone let me know if Backbone support is in the works or if there is a simple workaround?
Thanks!

There is no simple workaround and Parse / FB is not going to do it because you know React! Good news is that I'm almost done with creating a Backbone fork 1.2.3 that works fully with Parse 1.6. About 95% of the way there at this point pending a little more testing. Nice thing too is that I modularized Backbone  and made it ES6. I'll also be distributing ES5 bundles meant to be consumed in various module systems (RequireJS, SystemJS, etc.) along with a bundle meant for global usage.

Thanks a million, @typhonrt ! Looking forward to it.

My app just came to a screeching halt because of this. Looking forward to your implementation  typhonrt.
The least Parse could do is provide a migration guide or something.

@cfoulston Thanks for reminding me of this issue...
I've had the repos up for a week or so, but have been polishing off documentation and I have still to get a repo up for a full SystemJS / JSPM demo which is a great way to consume the ES6 source. If you want to check things out though the Backbone-Parse-ES6 repo is: https://github.com/typhonjs/backbone-parse-es6
The /dist directory has various ES5 bundles for AMD, CJS, and global consumption.
If you weren't using Backbone / Parse previously with a module system you'll want to choose the global bundles. The basic global bundle has Backbone & Parse. You'll need to load Underscore & a jQuery equivalent via script tags before the backbone-parse library. The "global inclusive" bundle also contains Underscore and jQuery.
and the main SystemJS / JSPM + global demo will be up here before the end of the week most likely:
https://github.com/typhonjs/backbone-parse-es6-demo
Technically you should be able to use things just like before and I have a whole framework on top of Backbone that works, but that doesn't mean I have all the angles tested. I'm going to be updating to Backbone 1.2.4 / or the next latest release and port over all of the tests from the original Backbone repo at that time and also see if I can come up with some way of auto-testing Parse thoroughly.
Drop an issue in the repos for questions.

@typhonrt I have an old parse project which uses JS SDK 1.2.12, Can I use your library as a drop in replacement for parse library? I'm already using require-js for my modules like,
define(
[
	'jquery',
	'underscore',
	'parse',
	'models/Comment',
	'collections/Comments'
], function($, _, Parse, Comment, Comments)
{
}
);

Do I need to make code changes in every files to get it work with new parse open-source server?

Unfortunately RequireJS support is a bit challenging. There is an existing issue: https://github.com/typhonjs-backbone-parse/backbone-parse-es6/issues/8 regarding RequireJS support where I detail the problem. A small change to the Parse JS SDK could solve the problem: https://github.com/ParsePlatform/Parse-SDK-JS/issues/144, but @andr

@typhonrt Thank you so much for the prompt response. Could you please point a PR or add somewhere the changes required in Parse JS SDK, so we can continue with AMD module from your repo?

We'll my hands are tied as I'm not involved with Parse and #144 has gone without answer or confirmation from @andrewimm for months, so a PR is pointless as it will just sit by the wayside as well most likely. There is a simple solution; Parse.encode = encode; Parse.decode = decode; in Parse.js, but if I can't get FB to acknowledge it then it's beyond what I can do personally. I already provided the only community solution to the outright abandonment of Backbone in regard to Parse.
It works great for modern package managers such as JSPM presently. It's not like I don't want to support legacy solutions like RequireJS as well, but such is life. Upgrading your web app while taking more work to use JSPM, Webpack, etc. will solve things. I've posted the solution above, but it's a crapshoot if FB will add it to the JS SDK.
Unfortunately the solution to https://github.com/typhonjs-backbone-parse/backbone-parse-es6/issues/5 outweighs the side effect of breaking easy RequireJS support, but once again a small modification to the Parse JS SDK would allow things to proceed with full RequireJS support out of the box. Contact the Parse team and let them know you'd like to see this solved.

I'm using parse-bone with require-js with few modifications to remove the wrapper and it is working as expected. Thanks for your support @typhonrt

@midhunanew parse-bone may work for now and is the best drop in replacement, but likely won't see much further progress. I guess the difference with https://github.com/typhonjs-backbone-parse/backbone-parse-es6 is that I am supporting the latest Backbone release and updates and you can use the latest version of the Parse JS SDK.
The problem I outlined above is that to get nested pointer relationships to encode / save correctly I have to directly access the encode file of the Parse JS SDK. This makes usage in RequireJS a bit messy. I haven't tried all too hard to get it working as well I don't need that functionality as modern package managers solve the problem transparently. I gather one can duplicate the parse JS SDK to create a hack workaround with RequireJS, but it's not clean per se. I'm not getting paid for any of this so can't exactly focus on this since there is such an easy solution if the Parse JS team takes my suggestion up for consideration. The problem is that encode.js references a bunch of other internal Parse JS files and the dependencies continue to chain up to foul things up w/ RequireJS. If it were exposed via Parse.js / ala Parse.encode(...) there would be no problem.

So I know that this a bit old but was able to fix a lot of the bugs in are parse code by doing this close to start of the page load. Hope this helps other solve this problem.
define (['underscore', 'parse', 'backbone'],  function (_, Parse, Backbone) {
	Parse.Collection = Backbone.Collection;

	function extend(obj, destination, source) {

		for (var k in source) {
			if (!destination.hasOwnProperty(k)) {
				obj[k] = source[k];
			}
		}
  		return obj;
	};

	// add all methods that are in backbone and not in parse, to make it more like the old parse library
	extend(Parse.Object.prototype, Parse.Object.prototype, Backbone.Model.prototype);

       var models = {};
       models.Campaign = Parse.Object.extend({
       // parse model logic
       });

    return models;
});


Export with offset rows

I have template.xls and I want to export into him. But
https://github.com/arogachev/yii2-excel/blob/master/src/export/basic/Exporter.php
has
$this->_phpExcel = new PHPExcel;

Need options. And need point (cell) of ActiveSheet for start export

@githubjeka You better split this issue into two separate.

One without the other is not effective.


Two typos in Rmd

Hi Aaron,
I'll say again how much I enjoyed your paper. I thought I'd mention two small typos in Manuscript.Rmd that I noticed while reading your manuscript. Wasn't sure if you prefer issues or pull requests, so I thought I'd make this an issue to start.

The first is that at line 245 you write "There are two principled ways to share a Docker image"; I think you meant "There are two principal ways to share a Docker image." Principled would mean "having principles," where as you seem to mean "primary ways." See https://www.merriam-webster.com/dictionary/principal?utm_campaign=sd&utm_medium=serp&utm_source=jsonld

The second is at line 349, where your code to reproduce the reproducible analysis working example has the user clone workflow-showcase, but then cd reproducible-research.

Thanks,
Gabriele

Thank you so much I will correct them asap.

Hey Gabriel,
I am delighted to take a pull request anytime. It is wonderful that you have put in so much effort into these issues. If you have any other suggestions on how to improve this (e.g. make it easier; things we forgot) go ahead.


A way to request Android permissions from the user

Currently Godot allows specifying permissions the game may require on Android, but it provides no way to request these permissions from the user. Enabling permissions requires the user to go into their Android settings and enable permissions for the app.
Typically if an Android app that requires a disabled permission is run, it will request the permission and Android will show a dialog to the user allowing them to approve or deny the request. Godot apps do not do this, and Godot does not provide a way for games to request the permission (short of calling into some module).
Godot should do one or both of:

Automatically request all permissions that were listed by the developer in the project settings
Expose an API in GDScript for checking the enable status of permissions and requesting permissions.

If that label is directed at me, I unfortunately don't have Android dev experience outside exporting from Godot, only experience as a user. It might take some time for me to learn what is necessary, as opposed to someone who already has experience. I'm sorry if my description of the problem gave the impression that I would know how to implement this. It may even already be possible through a shell command or something, but I wouldn't know.
A concrete effect this has had is that I can't have my users select a file from their SD card or internal storage without first entering their Android settings.

By the way, permissions being requested at runtime is a new feature of Android 6.0+, so this issue will not affect older versions, I think.

I remember there being some way to set the Android API version when exporting the game, and was thinking to try messing with the setting to see if I can get permissions working that way. Did this option actually exist? I can't find it anywhere now.

Seems like  #26756 solves this.

Actually nevermind, that method is hardcoded to only work with the audio permission.

@raymoo maybe you can checkout my pr #31583

This feature has apparently been vetoed in https://github.com/godotengine/godot/pull/32246#issuecomment-538422392, so I'll close this.


Build tests are working on mac

Pushing through as this completes #16. #31 will fix this build failure.


Adds get method for vm with optional properties

Closes #284

@joechainz Hi Joe, is it possible to help merge this PR? I'm not good with pytest and currently dont have an environment to write integration tests.


Include malvolio::P's new attrs field when transforming it into an Element

…n Element

bors merge

bors r+


Down- and upstream padding a la RFC7830 & RFC8467

When padding needs to be done, an EDNS0 Padding option is appended to edns_data's opt_list, but it is then still zero sized.  Padding block size is carried in a new data member in edns_data (padding_block_size) and only applied at the very end when encoding the packet.

I would prefer the default for pad-queries: as yes instead of off right now.  Because that is a secure default.  Even if breaks stuff (does it?).

It should not break stuff and is also only applied on TLS connections (which I assume support all support edns0 fine), so yes, I suppose this would be safe.
One more commit will follow then.

I wanted to try this patch and apply it against master. Since it has merge conflicts and the generated natured of some of the affected files, I chose to remove the changes to util/configlexer.c, util/configparser.c and util/configparser.h. This made it necessary to add the following change to util/configparser.y:
@@ -263,6 +263,8 @@
 	server_shm_enable | server_shm_key | server_fake_sha1 |
 	server_hide_trustanchor | server_trust_anchor_signaling |
 	server_root_key_sentinel |
+	server_pad_responses | server_pad_responses_block_size |
+	server_pad_queries | server_pad_queries_block_size |
 	server_ipsecmod_enabled | server_ipsecmod_hook |
 	server_ipsecmod_ignore_bogus | server_ipsecmod_max_ttl |
 	server_ipsecmod_whitelist | server_ipsecmod_strict |

otherwise the new keywords would be considered valid during configuration check. Perhaps that is solely needed if you don't apply the changes to mentioned files, but I got warnings like warning: nonterminal useless in grammar: server_pad_responses.

In this patch, padding is only applied when the connection is both over SSL and TCP. On my setup, the unbound service would be behind a loadbalancer (dnsdist in my case) and the loadbalancer doesn't apply the padding itself. Unbound, with this patch doesn't either since the connection between dnsdist and unbound is not encrypted (but on a trusted network) and over UDP.
Neither RFC7840 nor RFC8467 limits the application of padding to SSL + TCP connections (correct me if I'm wrong!) so would it perhaps make sense to drop that limitation?

@skoef Thanks for the heads-up on the missing keywords in configparser.y!
@skoef I am reluctant about enabling padding for other transports than DoT, though I do acknowledge your use case. Are running on Linux? I think this might be resolvable with XDP... @DRiKE , WDYT?

@skoef Thanks for the heads-up on the missing keywords in configparser.y!
@skoef I am reluctant about enabling padding for other transports than DoT, though I do acknowledge your use case. Are running on Linux? I think this might be resolvable with XDP... @DRiKE , WDYT?


Cranelift: look into removing redundant SSA parameters

@sunfishcode, we were discussing redundant SSA parameters.  Here's a simple example.  It's possible that the return block is a special case and that this is not what you were thinking about when you said redundant parameters should not occur.
Using the SpiderMonkey embedding here.  Wat source:
(module
  (func (export "f") (param i32 i32 i32 i32 i32 i32 i32 i32 i32 i32) (result i32)
    (i32.div_s (local.get 5) (local.get 1))))

IR code:
$ RUST_LOG=debug dist/bin/js --wasm-compiler=cranelift ~/moz/manyparam.js
...
function u0:0(i32, i32, i32, i32, i32, i32, i32, i32, i32, i32, i64 vmctx) -> i32 uext baldrdash {
                                ebb0(v0: i32, v1: i32, v2: i32, v3: i32, v4: i32, v5: i32, v6: i32, v7: i32, v8: i32, v9: i32, v10: i64):
@0041                               v12 = sdiv v5, v1
@0042                               jump ebb1(v12)

                                ebb1(v11: i32):
@0042                               fallthrough_return v11
}

(Will look for additional examples.)

Renaming this to a slightly more general topic (remove redundant SSA parameters); this might be an interesting pass to have eventually. It looks like right now the specific case above -- the return arg -- is still generated. In general we don't have an invariant that we keep minimal SSA, so this is a potential enhancement rather than bug (to be explicitly clear about it); labeling as such.


New version: Yemiao.Xtranslator version 2.5.5

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

This is the URL I found when searching for the program myself, linked from the homepage from this change:
https://secure-bigfile-danger.wostatic.cn/static/puXd6c4z5wUC8AChXkk8gr/XTrans_setup2.5.5A.exe?auth_key=1652745790-bWB4Rq9dmEzA1uLm2qJGpT-0-8ba1fe7dc0f555e1574777547668a042&download=XTrans_setup2.5.5A.exe

The URL you provided looks like it might be a personal copy of the installer, which is against our policy.  If the official URL has an intentionally limited lifetime, then I don't think this is a viable candidate for winget-pkgs.


fixed everything (you are welcome)

please accept I am begging you, trust me I improved it (also I turned off edits by maintainers :trollface: )

there are a lot of problems, and this is abandoned

problem solved

there are a lot of problems, and this is abandoned

Thought I would fix a few things anyways


xdp-tools: use emacs-nox for build to prevent cross compilation issues

Description of changes
The emacs-nox package fails to build with target set to armv7l but xdp-tools does not need it to be able to work with correct target. It is only used to generate man pages and for that we can use build package.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I had no idea that emacs even had the third concept of target.

Me neither. I suspect that it has something to do with lisp and its byte code.

Yes, emacs extensions are compiled in nixpkgs since recently, so probably around that.


[Style]: Enhance Background Pattern Visibility

Description:
The current background pattern is minimally visible and becomes apparent only when viewed closely against the plain white background. To improve user experience and aesthetics, I propose adding a dynamic and more visible moving pattern background with distinct colors.
Proposed Changes:
Introduce a moving pattern background that enhances visibility and adds a touch of color to the overall design. This will contribute to a more engaging and visually appealing user interface.
Additional Context:
Consider experimenting with different color schemes and patterns to find the optimal combination that not only improves visibility but also aligns with the design aesthetics.
Expected Behavior:
Users should experience a more noticeable and dynamic background pattern that complements the overall design.
Screenshots

Record

[x] I agree to follow this project's Code of Conduct
[x] I'm a SWOC 4.0 contributor
[x] I want to work on this issue

@thevirengarg I'm attempting to set up this project locally, but I encounter the same error every time. I've tried a few solutions without success. Even when attempting to install it on Codespaces, I still face this persistent issue. Can you assist me with this?

@thevirengarg I'm attempting to set up this project locally, but I encounter the same error every time. I've tried a few solutions without success. Even when attempting to install it on Codespaces, I still face this persistent issue. Can you assist me with this?

@Kajol-Kumari

@harmeetsingh11 Make sure you are on node version 14, you can manage multiple node versions using nvm package. Then delete the node_modules , then run npm install and then try runing the project

@harmeetsingh11 Make sure you are on node version 14, you can manage multiple node versions using nvm package. Then delete the node_modules , then run npm install and then try runing the project

@Kajol-Kumari it worked!
Thanks for the solution:)

@harmeetsingh11 What's the progress on this pull request??

@thevirengarg I am working on it.


refactor: get rid of googleauth internals

googleauth.ts was reaching into the internals of google-auth-library. Most of it wasn't needed here.

Codecov Report

Merging #790 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   79.49%   79.23%   -0.27%
==========================================
  Files           5        4       -1
  Lines         239      236       -3
  Branches       53       53
==========================================
- Hits          190      187       -3
  Misses         30       30
  Partials       19       19

Impacted Files
Coverage Δ

lib/apirequest.ts
97.26% <100%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c694b...1f04799. Read the comment docs.

CI issues aside, LGTM!


feat: add Kinoite variant

oops deleted my repo by mistake #16 🫥

To sum up the advantages: try Cosmic apps on other Desktops, have a different fallback version (so people could daily drive this image and use Kinoite), test KDE apps and services on COSMIC (spectacle, kdeconnect, Dolphin, kio, ...)


get_historical_klines return wrong OHLC data for highs and lows

Describe the bug
get_historical_klines returns historical OHLC data as expected, but the data itself doesn't match with actual spot prices. In that particular case 'high' and 'low' values for some candles differ significantly from the actual.
To Reproduce
client = Client(api_key=api_key, api_secret=api_secret, testnet=True)
hist =client.get_historical_klines(symbol="BTCUSDT", interval=self.client.KLINE_INTERVAL_1MINUTE, limit=1000)

h[0] is a timestamp, h[2] is low, h[3] is high
following loop detects extreme high-low discrepancy (round(float(h[3])-float(h[2]))) in retrieved data
for h in hist:
        t = datetime.datetime.fromtimestamp(h[0]/1000)
        print(t, h[1:5], round(float(h[3])-float(h[2])))

output sample:
2023-06-07 18:17:00 ['26486.29000000', '52980.20000000', '26480.90000000', '26531.10000000'] -26499
2023-06-07 18:18:00 ['26525.84000000', '29898.26000000', '26516.73000000', '26552.90000000'] -3382
2023-06-07 18:19:00 ['26552.90000000', '29910.94000000', '26547.94000000', '26552.77000000'] -3363
2023-06-07 18:20:00 ['26550.61000000', '26843.00000000', '23146.02000000', '26535.92000000'] -3697
2023-06-07 18:21:00 ['26535.92000000', '26555.12000000', '26529.87000000', '26555.12000000'] -25
2023-06-07 18:22:00 ['26555.54000000', '29973.00000000', '23131.36000000', '26541.92000000'] -6842
2023-06-07 18:23:00 ['26541.92000000', '29958.81000000', '26524.92000000', '26531.49000000'] -3434
2023-06-07 18:24:00 ['26533.62000000', '26533.63000000', '26488.19000000', '26493.91000000'] -45
2023-06-07 18:18:00 shows high 52980.20 which is clearly not right.
Correct values are for 2023-06-07 18:21:00 and 2023-06-07 18:24:00 in that sample.
Expected behavior
It is expected to receive data that matches the actual historical data that can be verified on Binance Spot.
Environment (please complete the following information):

Python version: 3.11
Virtual Env:  virtualenv
OS: Mac OS Ventura 13.4
python-binance v1.0.17

Logs or Additional context
Add any other context about the problem here.

The plot of this data is as follows:

Is problem still appearing after testnet=False?


MailService and raw attachments

When using raw mail attachments, very large log entries are created.
Because copies of the mails are / can be stored in the Log, and the message field is a LONGTEXT. For example, this is like 1% of a single log entry:

How shall we tackle this problem?
I can think of:

Making sure the raw attachment is not stored in the Logs table.
A way to alter the 'Mail Details' section that's written to the log.
A 'read more' / 'expand' button on the Logs page.

This has been reported here: https://github.com/concrete5/concrete5/issues/5473
I think we should fully strip attachments to mail logs – they aren't relevant.


[FIX]: geoLocation changed to geolocation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Missing "@types/react" dependency

Hello!
Thank you for this great library!
You are referencing react in public type declarations of your components, however, the @types/react dependency is missing from the manifest of the @material-ui/core package.
This leads to type-checking errors, because the types for react package couldn't be resolved from your declarations:
ERROR in /node_modules/.registry.npmjs.org/@material-ui/core/4.3.3_react-dom@16.9.0+react<EMAIL_ADDRESS>
ERROR in /node_modules/.registry.npmjs.org/@material-ui/core/4.3.3_react-dom@16.9.0+react@16.9.0/node_modules/@material-ui/core/Avatar/Avatar.d.ts(1,24):
TS7016: Could not find a declaration file for module 'react'. '/node_modules/.registry.npmjs.org/react/16.9.0/node_modules/react/index.js' implicitly has an 'any' type.

This happens in projects, which use more strict dependency management tools, like rush / pnpm, because they block access to implicit dependencies (like in your case).
In order to fix this, I would suggest to add @types/react and @types/react-dom packages to the peerDependencies section of the @material-ui/core package manifest.
Thanks!

In order to fix this, I would suggest to add @types/react and @types/react-dom packages to the peerDependencies section of the @material-ui/core package manifest.

Interesting, I see that it's the approach used by Apollo but that Antd uses the same approach as us. I think that we should pick a tradeoff that best serves npm and yarn users, rush / pnpm have a marginal user base. We can better support them at the condition it doesn't harm the majority.
cc @eps1lon, @pelotom.

Declaration files are the same code modules as anything else and if you use some third-party types in them and expose them in your own types then those types must be specified as dependencies for your package. It is as simple as that.
The way it works in npm / yarn projects is just a happy coincidence due to the simplified way of how those package managers install dependencies.
There are no multiple ways to handle this, there is only a one way, correct way — explicitly specify all the dependencies in the manifest.
pnpm is very good at detecting such issues and it's behavior is much more precise than of npm (which just closes it's eyes on many dependency issues).
And there is no harm in explicitly specifying the dependencies, it won't break anything :)

@slavafomin Maybe we would have these two packages as dependencies like we do with @types/react-transition-group (not peer)?

In whatever way we depend on react itself (currently peerDependencies?) we should depend in the same way on @types/react. This is my understanding of the best way to manage type dependencies.

This is where peerDependenciesMeta (i.e. optional peer dependencies) comes in. yarn already implements this, npm as well (though not the version bundled with node yet) and pnpm implements this as well.
I'll put together a PR that we'll merge once npm 6.11 is bundled with node. Basically once https://github.com/nodejs/node/pull/29273 is released to node LTS (10).


Violations of pointer passing rules

At least at one place we hand over Go pointers to the Ceph API that gonna get stored in a handler registry after the call returns, which violates the pointer passing rules:
https://github.com/ceph/go-ceph/blob/312e4cf6b5cfb02e69768232d0fb0888a7ba51ba/rados/read_op.go#L80-L81
So there is no guarantee that the pointers remain valid.
With the iterator right before:
https://github.com/ceph/go-ceph/blob/312e4cf6b5cfb02e69768232d0fb0888a7ba51ba/rados/read_op.go#L79
we are safe, since - as far as I can tell - it doesn't get stored anywhere.

Fixing this should largely just be a matter of allocating C-memory and storing C-pointers into our structs right?

Fixing this should largely just be a matter of allocating C-memory and storing C-pointers into our structs right?

Right. Or allocating the whole struct in C memory, if that is easier.

Also, do you have any thoughts on why this wasn't caught by the stricter checking we enable with the env var?

I think the checker can not do anything in this case, because it only can observe, what is passed to C, which is legal in this case. But it can't really check, what the C code is doing with the pointers. So we always have to be aware of that, to make sure, no ceph API is storing some pointers we are passing to it.

Isn't the byte buffer writeStep.cBuffer in write ops susceptible to the same problem as well and might need to be malloc'd?
https://github.com/ceph/go-ceph/blob/87f456311866ddf8c65911c4b0226cd5b5e7e4c2/rados/write_step.go#L25-L28


Changes to use karma and adds firefox headless

Addressses #1045

@kamilogorek Not sure why SAUCE variables are missing, pls halp? :)

@deiga Travis doesn't expose ENV vars to PRs coming from external contributors (non-org accounts), as they could be easily extracted and used on other projects. We're working on getting around this soon.
I'll review your PR today, thanks! :)

@kamilogorek Could you use https://docs.travis-ci.com/user/encryption-keys/ to add the SAUCE env variables?
You need to run npm test, since the tests are still dependent on build built first :)
I'll work on those comments tonight

@kamilogorek I addressed the issues with the index and saucelabs by changing to use karma for that too.

@kamilogorek Could you use https://docs.travis-ci.com/user/encryption-keys/ to add the SAUCE env variables?

Not really, it will still fail. Per docs:

Please note that encrypted environment variables are not available for pull requests from forks.

You need to run npm test, since the tests are still dependent on build built first :)

I got bitten by my own setup... 🤦♂
Thanks! Will reverify it Today :)

Oh, yeah. That's a bummer. Does SauceLabs have any kind of ACL, where you could have "public" credentials which only travis could use to send data?

Not that I know of. We'll most likely write a bot that'd run those tests for us instead.

@deiga can you grant me write access your fork? I rebased your changes and added some changes that would like to include here, as I don't want to open a new PR :)

@kamilogorek done

@deiga merged :) You can take a look at my latests commits to see what had to be changed in order to run everything on SauceLabs


Feat : Updated SignUp UI with password constraints

ScreenShot:

Fixes #585

Please follow commit guidelines

I'll commit code for constraints today itself, and then if you want I can squash all commits.

Please Review my PR.

@iamareebjamal Okay sir, so should I place a toast whenever user enters a password less than 6 characters?

No, display TextInputLayout error

@iamareebjamal  I have taken care of the error message this time. Now until and unless user writes a password greater than or equal to 6 characters this warning in red will be displayed (it will not be displayed initially when length of password is zero or when user clears the password field)

Explanation for latest commit ( b737bc4 ) : What if user clicks the sign up button even after seeing the warning? Later the application let user to signup, but now it will show a toast as shown below and won't let user to signup until and unless user obeys the password constraints.

@simarsingh24 When I posted the issue no one commented on this thing! You can tell me the limit, no problem.

@iamareebjamal please merge this PR

Please merge this PR

I think something went wrong!
git showed me this
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
then I did

git pull upstream develepment --rebase
git  push origin bb -f

Now all my previous commits are again stacked here again :/ can anyone help!

I think something went wrong!
git showed me this
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
then I did

git pull upstream development --rebase
git  push origin bb -f

Now all my previous commits are stacked here again :/ can anyone help?

@shikhart98 Simply follow these steps :

run git checkout bb
run  git pull --rebase upstream development
run git log
copy the latest commit id of (upstream->development)
run git reset --soft "paste commit id here"
now commit your changes 'git commit'
now run git push origin +bb

@liveHarshit its all sorted now :)
@nikit19 @simarsingh24 @iamareebjamal  Please review!

@liveHarshit its all sorted now :)
@nikit19 @simarsingh24 @iamareebjamal Please review!

@shikhart98 But you have nine commits, so you need to squash them. Simply follow the steps.

squash your commits


CI pipeline fails in docs step

CI pipeline sometimes fails in the docs step. See https://drone.owncloud.com/owncloud/ocis/27722/106/2 for example.
Reason is that bingo tries to download some dependencies and gets a 403 somehow. We need to vendor these dependencies somehow or get rid of bingo

I see that these pipelines are not routed through our proxy. So the ip addresses of the runners are sometimes blacklisted.
We can add
"environment": {
                "HTTP_PROXY": {
                    "from_secret": "drone_http_proxy",
                },
                "HTTPS_PROXY": {
                    "from_secret": "drone_http_proxy",
                },
            },
``
`

Good idea :+1: Let's try it like this. We can reopen the ticket if we still see issues...


Proxy Transparency

goal
A goal of the proxy is to be transparent, meaning that the application need not change behavior to benefit from the proxy. Transparency is primarily achieved by using iptables(8) to redirect traffic into the proxy.

all tcp traffic enters the proxy on a single port.
support for h2, http, and raw tcp transport

accept-side
HTTP1
An incoming HTTP/1 request has the format of method request-target HTTP/1.{0,1}\r\n. Unfortunately, that means that with a really large request target, it can require multiple reads and buffering before finally knowing if this is an HTTP/1 request.
It’s likely that non-HTTP1 data will be quick to identify, since as soon as it doesn’t match the shape of 3 words, we can assume its not HTTP.
A question that arises is whether slightly invalid HTTP requests should be classified as raw TCP instead. If the target route only speaks one of those options, the answer is simple, but if it speaks both, the answer is unresolved.
HTTP2
We have this working as the required default at the moment. With transparency, we could know incoming is HTTP2 by peeking the socket for the PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n magic bytes header (or from ALPN in the TLS detection).
TCP
If an accepted connection does not parse as either HTTP1 or HTTP2, then we may assume it’s plain TCP. There is an unresolved question around whether to accept the plain TCP or to reject as an invalid HTTP request, see the HTTP1 section.
TLS
We can peek the socket looking for the start of a TLS record to determine if TLS should be used. This peek should happen before the HTTP/TCP detection happens.
On a brand new connection, we can assume that the first TLS record is a handshake, and thus can peek for these bytes:

0x16 0x03 0xNN 0xNN 0xNN 0x01 - We’re looking for a HANDSHAKE byte (0x16), TLS version (3.N), some length we don’t yet care about, and then the CLIENT_HELLO byte (0x01).
We could decide to be more lenient or more strict with the version check and the length bytes.

Another question here is whether we want to assume that a slightly broken TLS record should just be considered plain TCP, or should we send an error back about the bad TLS format.
connect-side
Knowing what protocols to route to a destination likely requires some prior knowledge, retrieved by the Destination service from the controller.
Eventually, if no hint can be provided by the controller (a user hasn’t configured the service with such a hint), we can try some defaults: use HTTP1 with an Upgrade header to allow upgrading to HTTP2.
Would this default mean that without a prior knowledge hint from the controller, we assume the destination does not want plain TCP or TLS?
Prior knowledge from controller
The destination service would be updated to report back hints about what protocols a destination supports. A proposed new destination service:
service Destination {
  // Given a destination, return all addresses in that destination as a long-
  // running stream of updates.
  rpc Get(common.Destination) returns (stream Update) {}
}

message Update {
  oneof update {
    Add add = 1;
    Remove remove = 2;
  }
}

message Remove {
  repeated common.TcpAddress addrs = 1;
  repeated Protocol protocols = 2;
}

message Add {
  repeated WeightedAddr addrs = 1;
  repeated Protocol protocols = 2;
}

message WeightedAddr {
  common.TcpAddress addr = 1;
  uint32 weight = 3;
}

enum Protocol {
  HTTP_1 = 0; // should we differentiate between 1.0 and 1.1?
  HTTP_2 = 1;
  TCP = 3;
  TLS = 4; // should we include TLS versions?
}

These hints can be stored in Kubernetes metadata annotations in the Endpoints API.
Work to be done
Here is a list of tasks to be done to acheive this goal:
Accept

[ ] Peek new connections for TLS records
[ ] Peek new connections for HTTP2 preface
[ ] Peek new connections for HTTP1 start-line

[ ] Include an HTTP1 server (hyper?)

[ ] Forward connections that don't match any protocol as plain TCP

Connect

[ ] Update controller Destination service to include Protocol hints

[ ] Document how to configure protocols

[ ] Use protocol hints in proxy

[ ] Add an HTTP/1 client (hyper?)
[ ] Create a TCP forwarding client
[ ] Add TLS to proxy Connect

[ ] Default to HTTP/1 with Upgrade to H2 if no prior knowledge

[ ] Get HTTP/1 with upgrades client (hyper?)

use HTTP1 with an Upgrade header to allow upgrading to HTTP2.

Is any application actually using HTTP1 with an Upgrade header to HTTP2? I am skeptical that it is worthwhile to spend time on this unless we see some evidence it is actually done in the real world. I've literally never seen it done IRL.

accept-side

Let's distinguish between the two cases of accept-side traffic: public traffic from outside the pod, and private traffic from the service within the same pod that the proxy is in. I agree that the plan makes sense w.r.t. the private traffic we accept from the service within the same pod as the proxy. And I agree in the short term it is OK for the public traffic from outside the pod. However, in the long term I think the plan makes less sense.
In particular, the long-term plan is to provide automatic TLS and to enforce that TLS is used by default. That means that, in the long term, absent any annotations, we need to reject any non-TLS public traffic. While the annotation to opt into accepting non-secure public traffic could be a boolean flag, if the user has to add an annotation for plaintext traffic to work anyway, we might as well make the annotation value be the name of the plaintext protocol: HTTP or whatever. Then we wouldn't have to do the sniffing on the public listener, which would be better for security, predictability, and reliability.

@seanmonstar What should we do with this issue? GitHub says 0/13 tasks have been done but that seems far from accurate: new tasks were identified and many tasks were already done. Should we just close this in favor of having a separate GitHub issue for each currently-outstanding issue?

I'd say this could be closed, as it is not an accurate record of how this was implemented.


Hash pin GitHub Actions

Closes #592
Changes

I've hash pin GitHub Actions by using step security to help on identifying the right hash commit.

Thank you @joycebrum - we would very much like to accept this change, but it would help to know whether you are able to sign the Eclipse Contributor Agreement. If so then this will make accepting the change very easy, if not then we can investigate with the Eclipse IP team whether it's possible to get an exception for this PR.

I checked all versions and tags.

wrapper-validation-action/v1.0.5 exists in an newer version but this be picked up by dependabot later

Sorry for the delay on accepting the CLA. I had some issues regarding the associated email.
I've upgraded the wrapper to 1.0.6 (https://github.com/gradle/wrapper-validation-action/commit/8d49e559aae34d3e0eb16cde532684bc9702762b), nice catch.
Thanks for double checking it @stbischof !

@joycebrum could you please sign off you last commit?

LGTM


Remove moot version property from bower.json

Per bower/bower.json-spec@a325da3
Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property

@kkirsche ,
Is there a problem when I add the version in the bower.json?

It's 100% pointless. A waste of time and space, nothing more


Added SDN option

What does this PR do?
Allow user choose OpenShift SDN in ARM template
How should this be manually tested?
Deploy OCP using the ref. arch. and select any of the provided and supported SDN options and check the value on the /etc/origin/{master|node}/{master|node}-config.yaml file.
Is there a relevant Issue open for this?
Nope
Who would you like to review this?
cc: @glennswest  @cooktheryan  PTAL

Looks good


Drop node 0.6 support

Does anybody care about this still? By dropping support, I mean, I'd remove automated tests from being run against 0.6. I assume things will continue to work, but I won't be aware of something does break it.
It's causing the build to fail on Travis and I don't personally care to try and fix it.
See: https://travis-ci.org/getsentry/raven-node/jobs/42419289

+1 for dropping and adding support for 0.12

and iojs!


Some weights of ViTModel were not initialized from the model checkpoint at facebook/dino-vitb16

When I try to use the training code to overfit one object to test the model and I encounter this:
Some weights of ViTModel were not initialized from the model checkpoint at facebook/dino-vitb16 and are newly initialized: ['encoder.layer.3.adaLN_modulation.1.bias', 'encoder.layer.1.adaLN_modulation.1.bias',
'encoder.layer.1.adaLN_modulation.1.weight', 'encoder.layer.4.adaLN_modulation.1.weight',
'encoder.layer.11.adaLN_modulation.1.bias', 'encoder.layer.8.adaLN_modulation.1.bias', 'encoder.layer.7.adaLN_modulation.1.bias',
'encoder.layer.5.adaLN_modulation.1.weight', 'encoder.layer.6.adaLN_modulation.1.weight',
'encoder.layer.4.adaLN_modulation.1.bias', 'encoder.layer.2.adaLN_modulation.1.bias', 'encoder.layer.0.adaLN_modulation.1.bias',
'encoder.layer.10.adaLN_modulation.1.weight', 'encoder.layer.0.adaLN_modulation.1.weight',
'encoder.layer.11.adaLN_modulation.1.weight', 'encoder.layer.9.adaLN_modulation.1.bias',
'encoder.layer.9.adaLN_modulation.1.weight', 'encoder.layer.7.adaLN_modulation.1.weight',
'encoder.layer.10.adaLN_modulation.1.bias', 'encoder.layer.6.adaLN_modulation.1.bias', 'encoder.layer.5.adaLN_modulation.1.bias',
'encoder.layer.2.adaLN_modulation.1.weight', 'encoder.layer.3.adaLN_modulation.1.weight',
'encoder.layer.8.adaLN_modulation.1.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.

It seems that the ViTModel is slightly modified?
I'm wondering if I just use the pretrained weight, can I successfully overfit an object?

We add AdaLN modulation layers into the original dino model to inject camera poses. This warning is from the transformers package and will not influence the model's performance, since our pretrained weights contain these parameters and can be loaded properly.

Thanks for your reply!
 Or should I load the pretrained weights, but it seems that the pretrained weight for the modified ViTModel isn't published?
Thanks again for your work!

We add AdaLN modulation layers into the original dino model to inject camera poses. This warning is from the transformers package and will not influence the model's performance, since our pretrained weights contain these parameters and can be loaded properly.

Thanks for your reply!
 Or should I load the pretrained weights, but it seems that the pretrained weight for the modified ViTModel isn't published?
Thanks again for your work!

As I have stated, all the weights of the modified ViT encoder are just in the ckpt file. How can our model even work without these weights? The transformers package gives this warning bacause the pretrained DINO does not contain the weights of AdaLN modulation layers, but our pretrained ViT encoder does.

As I have stated, all the weights of the modified ViT encoder are just in the ckpt file. The transformers package gives this warning bacause the pretrained DINO does not contain the weights of AdaLN modulation layers, but our pretrained ViT encoder does.

Hi, may I know how did you load the openlrm weights for your training of instantnerf? Is it like matching the openlrm keys to instantnerf model keys mannually? There are literally 300+ kv pairs to match...


[region-isolation] When RegionIsolation is enabled, delay the preconcurrency import not used diagnostic to the SIL pipeline.

The reason why I am doing this is that I am going to be adding support for
preconcurrency imports to TransferNonSendable. That implies that we can have
preconcurrency import suppression in the SIL pipeline and thus that emitting the
diagnostic in Sema is too early.
To do this, I introduced a new module pass called
DiagnoseUnnecessaryPreconcurrencyImports that runs after the SILFunction pass
TransferNonSendable. The reason why I use a module pass is to ensure that
TransferNonSendable has run on all functions before we attempt to emit these
diagnostics. Then in that pass, we iterate over all of the modules functions and
construct a uniqued array of SourceFiles for these functions. Then we iterate
over the uniqued SourceFiles and use the already constructed Sema machinery to
emit the diagnostic using the source files.
rdar://126928265

@swift-ci smoke test


supabase-cli: 1.75.6 -> 1.79.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for supabase-cli is: A CLI for interacting with supabase
meta.homepage for supabase-cli is: https://github.com/supabase/cli
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.79.0 with grep in /nix/store/3x64x5si32llvhd625f2n5qldy01d7sz-supabase-cli-1.79.0
found 1.79.0 in filename of file in /nix/store/3x64x5si32llvhd625f2n5qldy01d7sz-supabase-cli-1.79.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
supabase-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3x64x5si32llvhd625f2n5qldy01d7sz-supabase-cli-1.79.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A supabase-cli https://github.com/r-ryantm/nixpkgs/archive/5e3dcc35f4d43c2e522e7d8727abdf81fd0f321e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3x64x5si32llvhd625f2n5qldy01d7sz-supabase-cli-1.79.0
ls -la /nix/store/3x64x5si32llvhd625f2n5qldy01d7sz-supabase-cli-1.79.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

supabase-cli

Maintainer pings
cc @Gerschtli for testing.

Result of nixpkgs-review pr 244105 run on aarch64-darwin 1

1 package built:

supabase-cli


IOKit/IOKitLib.h not found under macOS 10.14 (Mojave)

Hi,
I am getting the error message that IOKit/IOKitLib.h could not be found.
The code I try to compile is:
import serial

for port in listSerialPorts():
  echo port

First I've tried it with --cincludes:/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Kernel.framework/Versions/A/Headers as it contains the subdirectory IOKit.
However, after a few attempts I realized that IOKitLib.h is not there but instead inside /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers.
What's missing is the subdirectory IOKit that contains IOKitLib.h.
Is this problem only related to macOS Mojave or am I maybe missing some SDK settings?
Kind regards,

I haven’t tested on Mojave yet, but I assume you have XCode and the XCode command line tools installed? I think they might be required, which I should document if so.

On 28 Sep 2018, at 07:50, Harris Brakmić<EMAIL_ADDRESS>wrote:
Hi,
I am getting the error message that IOKit/IOKitLib.h`could not be found.
First I've tried to compile it with --cincludes:/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/IOKit
However, after a few attempts I realized that IOKitLib.h is not there but instead inside /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers.
Is this problem only related to macOS Mojave or am I maybe missing some SDK settings?
Kind regards,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, I have the latest XCode 10.0 and I also have installed the command line tools with xcode-select --install.

I'll have to give this a go this weekend. I haven't updated my Mac to Mojave just yet, so I need to do that first and see if I can figure out the problem. The code doesn't hard code the path to the library (see here) so I think this is something at the compiler/linker level.


Consider skipping zng.(*Record).TypeCheck()

Calling TypeCheck() on every record is costly and leads to a nearly ~3x slowdown on a simple processing task.  These measurements were made on a zar archive where the dubset year1  conn.log had been imported:
$ GOMAXPROCS=1 time zar zq -t "* | tail 1" _
[..]
       95.87 real        92.31 user         2.12 sys

Now with the call to TypeCheck() in zngio.Reader commented out:
$ GOMAXPROCS=1 time zar zq -t "* | tail 1" _
[...]
       32.19 real        29.14 user         1.74 sys

Unless there's a low-hanging fruit way to speed up TypeCheck significantly (nothing obvious jumps out at me, but I don't know the zcode stuff well), it seems like we should be able to skip it for zar/zqd since they run on stuff that was imported.
For zq, there may be more of a case for checking, but for as long as there is a single zng implementation, it doesn't seem unreasonable to skip it there too. Possibly with the addition of a -check flag to turn on checking.

For zq, there may be more of a case for checking, but for as long as there is a single zng implementation

Having dug in a little I think we should leave it on by default in zq. The reason is that this check catches errors not only in .zng-formatted files, but also in text formats (.tzng and .zjson). Insofar as a developer or user experimenting with zng formats might hand-edit or hand-write text-formatted files, it seems best to leave the check on by default.
As an example, without TypeCheck(), zq will happily process
#0:record[a:string,b:string]
0:[a;]

whereas with TypeCheck(), it errors with input.tzng: b (string): record missing a field.


User Details - Function - Create New Timesheet redirect

•	Once you click on the [Create a new timesheet] button it takes you straight to that timesheet

Implemented in last Push.


Add recurringJobs to StorageClass

Fixes #1129

We can add an option to the storage class for recurring jobs, but we cannot add a default value to it, since the user should choose how they would want to setup the recurring job. Also, if there is no backup target, we cannot have a recurring backup job as well.

@yasker I corrected the templates a bit, take a look please

Also, please squash the commits into one.


Add plotly to sciserver compute image (prepare script)

We need to add plotly to the deepforge image on sciserver. In the meantime, we should install it in the preparation script.

The other issue is since we are pinning matplotlib version to 3.2.2 in the image?

good question. I think it should be good this time but might be good to test just to make sure. The dockerfile uses the exported worker environment file created from deepforge create-env.


Identity public key can't be exported

Both the CogRPC server and the certificate rotator job are failing because PKI.js is trying to export a public key from a private key using the private key's parameters (instead of actually export()ing the private key to SPKI).
 GCPKeystoreError: Private key cannot be exported (requested format: jwk)
at .GcpKmsRsaPssProvider.onExportKey ( /opt/gw/node_modules/@relaycorp/awala-keystore-cloud/src/lib/gcp/GcpKmsRsaPssProvider.ts:36 )
at .GcpKmsRsaPssProvider.exportKey ( /opt/gw/node_modules/webcrypto-core/build/webcrypto-core.js:220 )
at .SubtleCrypto.exportKey ( /opt/gw/node_modules/webcrypto-core/build/webcrypto-core.js:1465 )
at .CryptoEngine.exportKey ( /opt/gw/node_modules/pkijs/build/index.js:5555 )
at .derSerializePublicKey ( /opt/gw/node_modules/@relaycorp/relaynet-core/src/lib/crypto/keys/serialisation.ts:17 )
at .getRSAPublicKeyFromPrivate ( /opt/gw/node_modules/@relaycorp/relaynet-core/src/lib/crypto/keys/generation.ts:55 )
at .InternetGatewayManager.get ( /opt/gw/node_modules/@relaycorp/relaynet-core/src/lib/nodes/managers/NodeManager.ts:46 )
at process.processTicksAndRejections ( node:internal/process/task_queues:95 )
at .InternetGatewayManager.getCurrent ( /opt/gw/src/node/InternetGatewayManager.ts:37 )
at .<anonymous> ( /opt/gw/src/queueWorkers/crcIncoming.ts:48 )

https://console.cloud.google.com/errors/detail/CMyRtJ_Opc7mHg?project=gw-frankfurt-4065

Fixed in https://github.com/relaycorp/cloud-gateway/commit/90942a9e9ef6d1dbd32df3ab091d2a854094ee60


Can't Get List of Available Devices

I'm using AudioKit v5-main, Swift 5, XCode 12.3, MacOS 10.15.7.
When I try to get engine.outputDevices, I get "Static member 'outputDevices' cannot be used on instance of type 'AudioEngine'.
import AudioKit

class Player {

    let engine = AudioEngine()

    func setOutput() {
        if let devices = engine.outputDevices {
            // ...
        }
    }

}

Right, so replace engine.outputDevices with AudioEngine.outputDevices. Let me know if that just works.


onAdLoadFailed not triggered when ads aren't loading due to lack of consent

MAX Module Version
6.2.1
React Native Version
0.68.7
Device/Platform Info
Android, haven't tested iOS
Current Behavior
onAdLoadFailed is not called when ad fails to load, due to lack of consent.
It is however called when the ad is automatically refreshed, giving error code 204 as it should.
Expected Behavior
onAdLoadFailed is called when ad fails to load, due to lack of consent.
How to Reproduce

Add eventlistener onAdLoadFailed to a banner that's shown in an app.
In the Google UMP dialog, choose Manage options, then deselect everything and Confirm choices.
Observe how the ad doesn't load, and the eventlistener isn't called.

Additional Info
No response

@bitfabrikken, sorry for not getting back to you soon.   Since then, we have updated the underlying SDK that handled the event dispatch.   Could you try this again with the latest version?


Use Web Activity to launch Marketplace rating

Marketplace allows ratings via Web Activity: https://github.com/mozilla/fireplace/wiki/Web-Activities#marketplace-app-rating
As the current behavior isn't perfect I also filed https://bugzilla.mozilla.org/show_bug.cgi?id=1164072 to have the rating window show inline and to get a return value.

This should be fixed at https://github.com/dcoloma/fxosRate/commit/a2343660d607fad4d77b384e803826b31c5edbb7


Allow to disable kube-vip sub-chart

Allow to disable kube-vip sub-chart

Signed-off-by: Jian Wang<EMAIL_ADDRESS>Co-authored-by: Anton Donskoy <https://github.com/adonskoy>

Issue: https://github.com/harvester/harvester/issues/6527
This PR is based on https://github.com/harvester/charts/pull/279 by @adonskoy, thanks.
The PR for release branch is https://github.com/harvester/charts/pull/305.
Will be rebased after below PR is merged.

[ ] https://github.com/harvester/cloud-provider-harvester/pull/49

Closed as #316 was merged. Thank you.


Posture checks for policies

Is your feature request related to a problem? Please describe.
Doesn't seem you can apply posture checks to policies.
Describe the solution you'd like
It would be cool if policies could be applied to the access granted via policies, e.g., a peer could use x but not y because they're using an outdated OS version. E.g., LAN gaming on an old OS rig? Fine. Access to a server admin panel? Lol no.
Describe alternatives you've considered
Not adding machines to the tunnel, but that defeats the purpose of it.

Actually looks like this is possible after all if you Add Policy in /access-control.


CI against Ruby 2.1.10

Ruby 2.1.10 was released.
https://www.ruby-lang.org/en/news/2016/04/01/ruby-2-1-10-released

Thanks!
@bundlerbot r+


Remove ability to auto-restore before build in integration tests

We already restore at build-time and very few tests need to restore by themselves anyhwo (I've already changed them in previous PRs to restore manually).
This mechanism of restoring didn't technically work because any NuGet resolved MSBuild pieces would not be included during Build.

Stuff's broken yo:
Microsoft.AspNetCore.Razor.Design.IntegrationTests.Assert+BuildFailedException : Build failed.
/Users/vsts/agent/2.154.3/work/1/s/.dotnet/dotnet msbuild /nr:false /bl /p:RunningAsTest=true /p:MicrosoftNETCoreApp30PackageVersion=3.0.0-preview8-28373-17 /p:MicrosoftNetCompilersToolsetPackageVersion=3.3.0-beta2-19374-02 /p:RuntimeAdditionalRestoreSources=/Users/vsts/agent/2.154.3/work/1/s/src/Razor/test/Microsoft.NET.Sdk.Razor.Test/../testapps/TestPackageRestoreSource /p:_RazorBuildServerPipeName=\"bed36866-6f9c-461d-8cff-88868bb8a2be\" /t:Build /p:Configuration=Release

Microsoft (R) Build Engine version 16.3.0-preview-19329-01+d31fdbf01 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

/Users/vsts/agent/2.154.3/work/1/s/.dotnet/sdk/3.0.100-preview7-012821/MSBuild.dll -maxcpucount -verbosity:m /bl /nr:false /p:RunningAsTest=true /p:MicrosoftNETCoreApp30PackageVersion=3.0.0-preview8-28373-17 /p:MicrosoftNetCompilersToolsetPackageVersion=3.3.0-beta2-19374-02 /p:RuntimeAdditionalRestoreSources=/Users/vsts/agent/2.154.3/work/1/s/src/Razor/test/Microsoft.NET.Sdk.Razor.Test/../testapps/TestPackageRestoreSource /p:_RazorBuildServerPipeName=bed36866-6f9c-461d-8cff-88868bb8a2be /p:Configuration=Release /t:Build ./AppWithP2PReference.csproj
 You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview
 ClassLibrary -> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Razor/x3ukvizy.zid/ClassLibrary/bin/Release/netcoreapp3.0/ClassLibrary.dll
 ClassLibrary -> /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Razor/x3ukvizy.zid/ClassLibrary/bin/Release/netcoreapp3.0/ClassLibrary.Views.dll
/Users/vsts/agent/2.154.3/work/1/s/.dotnet/sdk/3.0.100-preview7-012821/Microsoft.Common.CurrentVersion.targets(4563,5): error MSB3030: Could not copy the file \"/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Razor/x3ukvizy.zid/AppWithP2PReference/obj/Release/netcoreapp3.0/AppWithP2PReference\" because it was not found. [/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Razor/x3ukvizy.zid/AppWithP2PReference/AppWithP2PReference.csproj]

Exit Code:1

Ugh, looks like git clean -xdff was not sufficient on my box then.


Fix build

zz builds and runs inside Google now.
@niklaseen Can you review?

Looks good. Should I click "Close and comment" in this scenario?

Nah, if pull request are good one should close them by pressing merge.


[BDGR-180] Consider replacing vMix in-process mocks with mock server

Some of Desktop's vMix tests use MOCK_VMIX which uses strong-mock to mock the vMix client. This isn't great for a few reasons:

The user experience from Playwright tests isn't great, as you need to app.evaluate (and we need to copy the TypeScript definitions on both sides to get the experience nice)
It means that the vMix client needs to be tested separately (though those tests wouldn't go anywhere as they're specific and useful)
We've been moving towards having less and less test-only code in the main bundle, first with MockOBSWebSocket, then with MicroServer in BGDR-161

The potential complication with these is that the vMix API is very different to Server's and OBS's. Rather than having a number of small functions that return chunks of the state, it primarily returns the state of the entire vMix application as one XML document using the XML function, or a slice of it using XMLTEXT, and then manipulates it using FUNCTION. This would mean that, in order to properly mock its behaviour, we would need to reply with XML documents that match (as far as possible) those returned by vMix.
Arguably we should move towards using XMLTEXT rather than than XML where possible, which would make testing this easier (and reduce the amount of data transferred on the wire). But this makes typesafe vMix operations more difficult, may not always be possible, and the data transfer is less of an issue since (currently) it's always on localhost. See BDGR-181.
From SyncLinear.com | BDGR-180

One idea I've had is to design the API slightly differently that MockOBS's. Rather than specifying the full returned state in the mock handler, we provide an initial state (likely as JSON, which then gets serialised to XML) which MockVMixAPI stores internally and always returns on a call to XML/XMLTEXT. The user then defines handlers for FUNCTIONs which can manipulate that state.

Was done in #645 but reverted in #709.


Introduce rebootId into ServerState in Cluster

A server boots if it is started on a previously non-existing data
directory and hence does not have a UUID yet.
A server reboots if it is started on a pre-existing data directory

We keep a rebootId in the cluster's agency under Current/ServersRegistered/$uuid/rebootId.
When rebooting (and subsequently re-joining a cluster), the server increments
its rebootId. This way it can be detected within the cluster whether a server was restarted.
This information will later be used  to handle cases where server restarts can lead to problems, for example with transactions or in-progress queries.
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[ ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[ ] The behaviour change can only be verified via automatic tests

Related Information
(Please reference tickets / specification etc )

[ ] There is a GitHub Issue reported by a Community User:
[ ] There is an internal planning ticket:
[ ] There is a JIRA Ticket number (In case a customer was affected / involved):
[x] There is a design document: https://github.com/arangodb/documents/blob/master/DesignDocuments/01_IDEAS/BetterFailureCleanup.md

Testing & Verification

[x] There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
[ ] I ensured this code runs with ASan / TSan or other static verification tools

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5303/

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/6981/

Q: What about documentation for this?

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/6988/ Jenkins is green!

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr-linux/7006/ still blue.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5435/

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5576/

Jenkins above is green.

This has been merged through #9523


Window has moved off the screen

VSCode Version: 1.50.0
OS Version: Windows 7

If i click on the icon "Visual Studio Code" on Windows taskbar - window VSC is moved out of screen (behind left side).
The window cannot be seen.

This sounds like a bug of the Windows OS window manager to me that it allows to move windows offscreen, I suggest to report this against windoofs.

Ok, thanks for comment.


Manual twitterkit installation instructions are wrong

The instructions are wrong: https://github.com/twitter/twitter-kit-ios/wiki/Installation#install-twitter-kit-manually
The correct installation is to add TwitterKit and TwitterKitCore to embedded binaries and add TwitterKit to linked libraries.
For cordova this can be done using this code: https://github.com/guylando/twitterkit3-plugin/blob/master/plugin.xml#L61
Explanation:

TwitterKit.framework and TwitterCore.framework must be embedded or otherwise there is a runtime dyld missing library error
Must not link TwitterCore.framework or otherwise will get the runtime warnings discribed here: https://github.com/twitter/twitter-kit-ios/issues/91, https://github.com/twitter/twitter-kit-ios/issues/18

thanks, this works!

Ahh, actually this didn't help with one of the errors on CI, private submodule 'TwitterCore.Private' in private module map, expected top-level module. Sorry for bothering but do you know anything about this error @guylando?

And this error prevents your oauth from working? My oauth works well after the fix inside cordova app (android + ios)

Our problem was just related to warnings so not sure about the oauth. Thanks so much though, this still fixed one of the warnings we had! 😊


Fix requirements-agent-release.txt updating

What does this PR do?
Also

Fixed package name of checks base (was datadog-datadog-checks-base)
Updated/froze agent packages and deps

Codecov Report

Merging #2617 into master will decrease coverage by 8.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2617      +/-   ##
==========================================
- Coverage    83.9%   75.88%   -8.02%
==========================================
  Files         644       66     -578
  Lines       36427     3840   -32587
  Branches     4427      445    -3982
==========================================
- Hits        30564     2914   -27650
+ Misses       4551      804    -3747
+ Partials     1312      122    -1190


Display formatted status during status wait

Signed-off-by: Raphaël Pinson<EMAIL_ADDRESS>

@derailed I believe I've addressed all comments!

I think all jobs need to be rerun, looks like there was an issue with helm.cilium.io yesterday.

OK, let's run again 👍🏼

looks like "https://helm.cilium.io/" is not a valid chart repository or cannot be reached: Get "https://helm.cilium.io/index.yaml": tls: failed to verify certificate: x509: certificate signed by unknown authority

still broken 😢

That's really weird though, that repo works on my machine 🤔


Autoformat html

Add djlint to pre-commit to autoformat html files and autoformat existing html files

Any style things we don't don't to manually think about I support!

Same here, I will happily autoformat :allthethings:.