[SPARK-45718][PS] Remove remaining deprecated Pandas features from Spark 3.4.0

What changes were proposed in this pull request?
This PR proposes to remove remaining deprecated Pandas features from Spark 3.4.0
Why are the changes needed?
To match the behavior of Pandas. We cleaned up most of APIs, but there are still some features that deprecated from Spark 3.4.0 need to be removed.
Does this PR introduce any user-facing change?

Yes, some parameters and APIs are removed from Spark 4.0.0.
How was this patch tested?

The existing CI should pass.
Was this patch authored or co-authored using generative AI tooling?

No.

Please re-trigger the CI, @itholic .

It seems that three PySpark test pipelines fails still unfortunately.

Oh, just realized that there was actual failure. Thanks for the notice!

It seems to be fixed. Could you re-run linter pipeline?

Seems actually like it's a real error:
Warning, treated as error:
[autosummary] failed to import 'pyspark.pandas.Index.is_all_dates': no module named pyspark.pandas.Index.is_all_dates
make: *** [Makefile:35: html] Error 2
                    ------------------------------------------------
      Jekyll 4.3.2   Please append `--trace` to the `build` command
                     for any additional information or backtrace.
                    ------------------------------------------------
/__w/spark/spark/docs/_plugins/copy_api_dirs.rb:130:in `<top (required)>': Python doc generation failed (RuntimeError)

Right. Finally, it's fixed and passed. Merged to master. Thank you, @itholic and @HyukjinKwon .


Fix broken tap syntax, def needed kwarg

Fixes invalid syntax exception in tap
("def fetch")
Error: gem-XXXXX: Calling def fetch
in a subclass of Formulary:: FormulaNamespaceYYYYYYYYYY:: RubyGemsDownloadStrategy is disabled!
Use def fetch(timeout: nil, **options)
and output a warning when options
contains new unhandled options instead

All homebrew taps affected!
With this fix all commands of brew gem * are working.


Authentication with phone number and password

Describe the solution you'd like
We want to start using Serverpod where i work, but the auth system that we're using is phone number and password, I hope you consider adding that to the supported auth
I think adding phone number and password will not be that hard to implement, because it will be similar to email and password auth
Describe alternatives you've considered
I tried to use email and password auth as  a work around and send the phone number instead of the email and disable email verification but didn't work out

There is a PR from the community on this here: https://github.com/serverpod/serverpod/pull/1362. I haven't had the chance to deal with it yet but I agree, this is a nice feature to add!

Issue created for this here: https://github.com/serverpod/serverpod/issues/2050
Closing this issue as it will be tracked there.


Initial skeleton code for C++ Implementation

Add libcask native dll project to sln
Add stub implementation and P/Invoke interop to it to tests
Revert back to CRLF on Windows, there are too many issues with VS putting snippets with CRLF into files and making them have mixed line endings
Use MSBuild magic so that we

Have a good experience in VS on Windows for C++
Don't regress the C# dev experience x-plat for C#

This currently works only on Windows x64 and only with full VS, but everything is set up there to the point where you can drop a breakpoint in .cpp and hit it from the Test Explorer.
More work will be needed to match this experience for Linux, Mac, VS Code on Windows, and non-x64 architectures.
There is also no PR validation coverage yet because that will require infrastructure to build with big VS and/or solving x-plat.

@nguerrera Taking a look at this PR.

Thanks, I have it in draft while I fight the build. I think it's going to work now.

@KalleOlaviNiemitalo Docs will come very soon. That said, this project is just getting off the ground and you may continue to see things hit the repo out of natural order.

please get a sign off from someone with production C++ experience (which does not include me)!

@michaelcfanning OK to merge?


Restrict access to application.

We have a situation where abc.com/xyz should be restricted to certain IPs in such a way that abc.com/pqr/123 should be excluded (i.e it should not be restricted).
Can this be achieved by WAF Custom Rules?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26c3e97e-759e-c50e-ce05-29dbd91830ab
Version Independent ID: 28f16dcd-4cef-366a-154e-b56f9c29b868
Content: Azure Web Application Firewall (WAF) v2 custom rules
Content Source: articles/application-gateway/custom-waf-rules-overview.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

Adding:
abc.com/xyz- this means anything in the domain except for abc.com/pqr/123 should be restricted to certain IPs

@sahilpnckr123 , Yes this can be achieved.
Custom rules support using compounding logic to make more advanced rules that address your security needs. For example, (Condition 1 and Condition 2) or Condition 3). This example means that if Condition 1 and Condition 2 are met, or if Condition 3 is met, the WAF should take the action specified in the custom rule.
You need to create 2 condition. One to match the query string /xyz and one for matching IP which you wanted to restrict. Then create a block rule.
Reference: https://docs.microsoft.com/en-us/azure/application-gateway/create-custom-waf-rules

@msrini-MSFT
/xyz can be anything for now i cannot specify /xyz because we may add more webpages later.

@sahilpnckr123 , You can use Regex if the path is different or dynamic.

@sahilpnckr123 , I will go ahead and close this issue. If you have any further questions, please tag me.


fix some typos, update example IPs to 400:/7 subnet

Thanks for doing mycelium!
I read some of the sources and found some typos, and sent a PR to fix it :-)

thanks :)


python should creat shim for py.exe on Windows

It looks like py.exe doesn't exist in Python 3.5. But their new installer is hard to deal with. Do you have any ideas?

Not for now, but for reference:
https://docs.python.org/3/using/windows.html?highlight=python launcher windows#installation-steps

Huh?
$ gcm py.exe|fl

Name            : py.exe
CommandType     : Application
Definition      : C:\Users\schwarzenegger\AppData\Local\Programs\Python\Launcher\py.exe
Extension       : .exe
Path            : C:\Users\schwarzenegger\AppData\Local\Programs\Python\Launcher\py.exe
FileVersionInfo : File:             C:\Users\schwarzenegger\AppData\Local\Programs\Python\Launcher\py.exe
                  InternalName:     py
                  OriginalFilename: py
                  FileVersion:      3.5.0
                  FileDescription:  Python Launcher for Windows (Console)
                  Product:          Python Launcher for Windows
                  ProductVersion:   3.5.0
                  Debug:            False
                  Patched:          False
                  PreRelease:       False
                  PrivateBuild:     False
                  SpecialBuild:     False
                  Language:         English (United Kingdom)

Weird. This one was installed via scoop as well, and py.exe is there and on the PATH. But on my other PC it wouldn't work... Need to investigate more.

It seems this sorted itself out after restarting.


CB-7704 [opdb] Revert "CB-7343 [opdb] Add Hue in the opdb blueprint"

Addition of hue to opdb template depends upon CM 7.2.1 version hence removing this change from the 7.2.0 blueprint.
This reverts commit 1ef188066b2427e61c12cdf1d566bf18ca851d7e.
Testing: Created cluster from custom blueprint and verified that dh cluster turns up.

This change also needs to go into master branch. Kindly let me know if for that a new pr needs to be created. or this branch would get merged to the master branch in which case a new pr might not be necessary.


Trim down CSS

As we discussed recently -- there is a lot of stuff in the ~900-line empress.css file that is currently unused (e.g. ~50 lines of code styling modal dialogs, none of which are used in the current version of Empress). It would be good to remove a lot of this stuff, both to simplify maintenance and to avoid nasty side effects (e.g. the CSS impacting Emperor's CSS, as is the case with a checkbox somewhere in Emperor's controls).
Related to #168.

Something within this issue to address -- would be good to remove the extra vertical scrollbar that is shown during Empress + Emperor plots. The reason for this scrollbar is probably attributable to something hiding within the CSS.


multi-arch: create build scripts for multi-arch

Signed-off-by: huoqifeng<EMAIL_ADDRESS>

@rootfs @SamYuan1990 may you help review the scripts to build multi-arch images?

@huoqifeng on systems without docker installed, we use buildah and podman, can you see if both can be supported? thanks

buildah vs docker: https://danmanners.com/posts/2022-01-buildah-multi-arch/

I'd suggest rename build-images.sh to build-images-docker.sh and provide a new scripts for buildah as this tends to be used by developer.

sounds good, looking forward to the dev scripts.

We should update the makefile at some point to use this script


chore(main): release 1.5.4

:robot: I have created a release beep boop
1.5.4 (2024-03-29)
Bug Fixes

improve error msg when adding coauthor with invalid key (81fd16d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Mubashwer/git-mob/releases/tag/v1.5.4 :sunflower:


non-interactive SSH run - fixes #19

please review @cescoffier @pmlopes

Couple of questions inline but LGTM otherwise

One minor comment otherwise, LGTM

Thanks @vietj !


Skip pod on duplicate IP error during initial snapshot.

Similar to https://github.com/istio/istio/pull/51081 - in the real world we may have misconfigured IPAM or other problems, and during initial snapshot of the node, we could get 2 pods with the same IP.
This is an error state for the cluster generally, and there's not much we can do about it, but one thing we can do is skip the problem pod and carry on processing the rest, rather than immediately stopping and returning an error.
This at least means only the pod with the dupe IP will fail healthchecks, rather than the dupe + everything we hadn't tried yet.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b4c538f5bf32ccb5043a5b219c246295d4973459
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
b4c538f5bf32ccb5043a5b219c246295d4973459
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

When duplicate ip can be allocated, is there such ipam in production?

every CNI does it afaik - just run 255+ pods that Complete on one node

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
1fd26c650f17864067ae2fb93e7cfd208856125f
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
1fd26c650f17864067ae2fb93e7cfd208856125f
link
true
/test integ-basic-arm64

integ-helm_istio
fa4808eb376643dd9b5198a5e3b3369b5f5fab51
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

the other wrinkle is that according to the kube docs a job pod may either be recreated or restarted - if the latter, I think we end up with the same problem we have with restarting init containers in the sidecar arena.

there is nothing special about a job - they just create pods. Usually pods are made by deployments which restart the container on exit (restart policy) though, so jobs end up generally causing different behavior. When it's in restart mode is identical to a typical pod, the container restarts. Init containers do not

there might be a higher level restart on job that spins up a whole new pod actually, not entirely sure. Either way nothing weird

there might be a higher level restart on job that spins up a whole new pod actually, not entirely sure. Either way nothing weird

Okay, the wording here around restartpolicy implies strongly it works like init containers: https://kubernetes.io/docs/concepts/workloads/controllers/job/#handling-pod-and-container-failures
I'll check either way.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-helm_istio
fa4808eb376643dd9b5198a5e3b3369b5f5fab51
link
true
/test integ-helm

lint_istio
50f98cae28e0474cb91e339343b720c9517969ef
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e3e24a314e0b40c1718684cf919095d343604a83
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc25bd46fbf32959be1ffd00370389708e1735b0
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc25bd46fbf32959be1ffd00370389708e1735b0
link
true
/test lint

gencheck_istio
cc25bd46fbf32959be1ffd00370389708e1735b0
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc25bd46fbf32959be1ffd00370389708e1735b0
link
true
/test lint

gencheck_istio
cc25bd46fbf32959be1ffd00370389708e1735b0
link
true
/test gencheck

integ-basic-arm64_istio
fd91519549e316052da9ef39280857a1e6e87892
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
f1d444c0091629fcf7e517e310a9966ed0deb64d
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

there might be a higher level restart on job that spins up a whole new pod actually, not entirely sure. Either way nothing weird

Okay, the wording here around restartpolicy implies strongly it (can) work like init containers, depending on the policy you pick: https://kubernetes.io/docs/concepts/workloads/controllers/job/#handling-pod-and-container-failures
I'll check either way, I might just be being paranoid.

Yeah the restart policy does still retrigger the CNI plugin, despite the wording that "the container will be restarted but the Pod will be reused".

/test integ-pilot

Does this logic need to be replicated in Istiod ? How much divergence
between how CNI interpretes the world and
what Istiod does can we tolerate ( or understand ) ?
On Thu, Jun 6, 2024 at 7:58 AM Ben Leggett @.***> wrote:

@.**** commented on this pull request.
In cni/pkg/nodeagent/informers.go
https://github.com/istio/istio/pull/51429#discussion_r1629710597:

// only checks if the pod state just changed from not-terminated to terminated.

// if pod state changed in *any* other way, this should be false.

justTerminated := !wasTerminated && isTerminated

// Check intent (labels) versus status (annotation) - is there a delta we need to fix?

changeNeeded := (isAnnotated != shouldBeEnabled) && !isTerminated

// nolint: lll

log.Debugf("pod %s events: wasAnnotated(%v), isAnnotated(%v), shouldBeEnabled(%v), changeNeeded(%v), wasTerminated(%v), isTerminated(%v), oldPod(%+v), newPod(%+v)",

	pod.Name, wasAnnotated, isAnnotated, shouldBeEnabled, changeNeeded, wasTerminated, isTerminated, oldPod.ObjectMeta, newPod.ObjectMeta)

// If it was a job pod that (a) we captured and (b) just terminated (successfully or otherwise)

// remove it (the pod process is gone, but kube will keep the Pods around in

// a terminated || failed state - we should still do cleanup)

//

// Note that kube may either restart the same pod, or spawn a new one, depending on how

Also, if it is going to, it will never transition to Failure or Success. a
pod in those states will never change afaik
Yeah - that statement is at some variance with "the pod is not restarted
but the containers are" tho. Or my mental model of how K8S works is broken.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/51429#discussion_r1629710597, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2TWAHZYWA4OAGT4XC3ZGB2KHAVCNFSM6AAAAABI3VX6TSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBSGIZTSNRSGM
.
You are receiving this because your review was requested.Message ID:
@.***>

Does this logic need to be replicated in Istiod ? How much divergence between how CNI interpretes the world and what Istiod does can we tolerate ( or understand ) ?

Istiod is already aware of pod status so no - but also Istiod doesn't interact with the pod lifecycle in the same way or in as granular a fashion, so there's always going to be (some) difference.

In response to a cherrypick label: #51429 failed to apply on top of branch "release-1.22":
Applying: Skip pods with duplicate IPs when adding to host probe exclusion set
Using index info to reconstruct a base tree...
M	cni/pkg/nodeagent/net.go
M	cni/pkg/nodeagent/net_test.go
Falling back to patching base and 3-way merge...
Auto-merging cni/pkg/nodeagent/net_test.go
Auto-merging cni/pkg/nodeagent/net.go
Applying: Lint
Applying: Relnote
Applying: Actually exclude terminated job pods
Applying: Shorten log
Applying: Derp
Applying: More robust checks
Applying: Use old pod
Applying: Test
Applying: More test
Applying: Lints
Applying: Smarter IP add
Using index info to reconstruct a base tree...
M	cni/pkg/nodeagent/net.go
M	cni/pkg/nodeagent/net_test.go
Falling back to patching base and 3-way merge...
Auto-merging cni/pkg/nodeagent/net_test.go
CONFLICT (content): Merge conflict in cni/pkg/nodeagent/net_test.go
Auto-merging cni/pkg/nodeagent/net.go
CONFLICT (content): Merge conflict in cni/pkg/nodeagent/net.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0012 Smarter IP add
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #51687


Add definitions for CanvasRenderingContext2D

Fixes #19195

These files are not meant to be edited by hand. If you need to make modifications, the respective files should be changed within the repository's top-level src directory. Running jake LKG will then appropriately update the files in this directory. (https://github.com/Microsoft/TypeScript/tree/master/lib#readme)

-> https://github.com/Microsoft/TypeScript/tree/master/src/lib#readme

Sorry, my bad

@ikatyang moved to Microsoft/TSJS-lib-generator#325


Parse bban property in account details

Parse bban property in account details (https://nordigen.com/en/docs/account-information/output/accounts/).

Hi, @Dhi13man! Can you have a look?


elementMatches function does not work with :focus pseudo-class

It seems like currently there is no way to check if an element is focused. We tried to do it using by is helper, but the elementMatches does not work with ':focus' pseudo-class.
Maybe some kind of isFocused getter should be added, for example like this:
function isFocused(selector) {
  return computed(function () {
    const el = this.$(selector);
    return document.activeElement === el;
  });
}

Hi @Robdel12 ! The example of using is(':focus') is actually the code that I'm working on. These tests fail for some reason. Maybe something changed from the moment when they were written, idn. It's nice to know, that validations are coming :) Thanks for your reply!

@Robdel12, when can we expect to see validations introduced? It's a highly expected feature for our project. Are there at least approximate dates of the next release?


Added VOEvent_Spec.txt - [closed]

In GitLab by @nicholaspad on May 2, 2019, 15:07
Merges master -> master

In GitLab by @nicholaspad on May 6, 2019, 14:57
closed


Player list request command

Added a player list request command (/list). Fixed a typo on the login message and made the /cheat command invisible.
It looks like this

I realize now the "return 0" to hide the /list command should be at the end of this "if message:sub(1,1) == '/' then" if statement.
Unless there's a way for you to change it before merge. I will be pushing that fix when I finish the teleport commands, if you guys see fit.


*: Upgrade Rust compiler version to 2019-04-25.

What have you changed? (mandatory)
Upgrade Rust compiler version to 2019-04-25.
With the latest rust compiler, we have new HashMap implementation and stabilized std::future.
Then, we can remove hashbrown from our dependencies and change the alias in tikv_util::collections to the HashMap in the standard library.
Also, std::future is stablized since this version and probably won't change in the future. So maybe we can try to migrate to the new future ecosystems and even try async/await.
I also upgrade the url crate to 1.7.2 as the new NLL finds a lifetime bug in the previous version.
What are the type of the changes? (mandatory)
Engineering.
How has this PR been tested? (mandatory)
make dev is run
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

@brson I think the version constraint does not change if I change it from Cargo.toml from 1.5 to 1.7.2. Anyway, I change it as you suggest.

@brson I think the version constraint does not change if I change it from Cargo.toml from 1.5 to 1.7.2. Anyway, I change it as you suggested.

We discussed offline. It is true that in practice, with tikv, the lockfile is sufficient for recording version requirements, mostly since tikv is never used as a library, so the lockfile is always "in play". But it's not really the purpose of the lockfile. The lockfile is for ensuring that the crate resolution is reproducible between builds and between environments.
Imagine that tikv was an end-user library - you couldn't leave correctness decisions to the lockfile.
It is a simple policy to treat the manifest and lockfile the same regardless of whether the project is a lib or bin.


Docker mini compose file

sometimes, people want a mini try. because it's very very slow for docker pull in China.
run by docker-compose -f docker-compose-mini.yml  up

@rolandpoulter

@panpan0000 this overlaps with https://github.com/RackHD/RackHD/pull/339/files - you won't be able to easily merge both of them given the changes happening in each. You may want to consider rebasing so that these changes are separate - docker in one PR, rackHD shell script install script in another.
Can you explain what the additional roles are for and how you see them being used? packer/ansible/rackhd_install_from_src.yml seems to overlap extensively with https://github.com/RackHD/RackHD/blob/master/packer/ansible/rackhd_local.yml which is also meant to install from source.

this is a bad PR...
I made accident raise Pr with wrong branch...
I will rework it.
I meant to Make PR for  docker-compose-mini.yml ONLY

*** BUILD #665 ***
Test Name: pollers_data_get
Error Details: Condition was True.
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/RackHD/build/test/tests/api/v2_0/pollers_tests.py", line 158, in pollers_data_get
    assert_false(poller.get('lastFinished', False))
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 67, in assert_false
    raise ASSERTION_ERROR(message)
AssertionError: Condition was True.

this is please

*** BUILD #674 ***
Test Name: pollers_data_get
Error Details: Condition was True.
Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/RackHD/build/test/tests/api/v2_0/pollers_tests.py", line 158, in pollers_data_get
    assert_false(poller.get('lastFinished', False))
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/asserts.py", line 67, in assert_false
    raise ASSERTION_ERROR(message)
AssertionError: Condition was True.

test this please

good idea, @zyoung51 .
But I copied those code from docker-compose.yml.
So will involve @rolandpoulter    to  the discussion.

Honestly, we could have this replace the current docker-compose.yml as the default configuration. And rename the old docker-compose.yml to docker-compose-advanced.yml?

@panpan0000 Can you add a section to docker/README.md explaining how to use the alternative docker-compose file?
Maybe add docker-compose -f docker-compose-mini.yml up as an example of running RackHD under poor network conditions with docker.

test this please

test this please

@rolandpoulter  , I've updated per your comment ( add into README)

👍

test this please

test this please

test this please

:+1:


Add show counter items code

Hi in this PR I added a counter display code

Hey @williamrolando88,
Almost ready for the weekend now!! 🥳 🌮


switch to solcjs, fix formatting unit test, update chalk dependency

Unfortunately I also had to update chalk to get it to build correctly.

@krzkaczor I think this is as ready as it's ever going to be. I didn't find a way to tidy up the contract filenames (apart from manually renaming them).

@linusnorton thanks! Sorry, i was busy. I will make a review of this and the other branch before monday!


Focus on Input in IE is no longer working properly

This image shows the problem:
http://i.imgur.com/LDqiO.png

Closing for #1466.


Why isn't memory released?What occupies memory?

helm charts kong version:0.27.2
plugin:key-auth,prometheus

Why isn't memory released?What occupies memory?

Kong has to allocate space for the many shared dictionaries (under the hood, this is just an mmap call). This mapping lives for the lifetime of the process. Depending on how your tooling reports the memory allocation, even if no memory pages are demanded to be used from this allocation, it can still be reported as in-use.


Support Loaders

Aurelia supports quite a varied array of loaders some of which change the local context. For example:
https://github.com/bryanrsmith/aurelia-binding-loader
<template>
  <require from="styles.css!module!bind" as="styles"></require>

First

Second

</template>

The comprehensive solution would be to actually use the loader plug-in directly and use the template resources it produces. However, this also means that the base project files require transpiling i.e. if you are using .scss then any look up for a .css file would require transpiling the scss to css first, in memory.
Same applies to any relative path "module" look-up with a typescript file requiring transpiling into memory before being fed to the loader.

this explicit example could be triaged by examining the as="styles" and adding styles to the template context. That at least would allow ignoring (not cause issues) any bindings to it.

https://github.com/bryanrsmith/aurelia-react-loader
<template>
  <require from="my-react-component.js!react-component"></require>
  <my-react-component props.bind="{ name: in.value, onClick: submit }"></my-react-component>
</template>

... can also be triaged by ignoring any unknown custom element (current behaviour in 0.9).

Best I can do for now is to stub a Loader class and abstract this away. The default would be called for all require elements. Configurable by changing loader in Config


"Error during WebSocket handshake: 'Connection' header is missing" in React app with authentication in ASP.NET Core 3 Preview 3

Describe the bug
A brand new React app with authentication created with ASP.NET Core 3.0 Preview 3 generates a client-side error when browsing to its homepage: Error during WebSocket handshake: 'Connection' header is missing
To Reproduce

Using ASP.NET Core 3.0 Preview 3 create a new project with dotnet new react --auth Individual
Fix the client-side issues described in #8281 and #8283.
Build and run the project with VS 2019
Browse to the app homepage (e.g. https://localhost:44341/) in Chrome and open the developer console to see the error:

WebSocket connection to 'wss://localhost:44341/sockjs-node/681/drhzrqa1/websocket' failed: Error during WebSocket handshake: 'Connection' header is missing
WebSocketBrowserDriver @ websocket.js:7
WebSocketTransport @ websocket.js:32
push../node_modules/sockjs-client/lib/main.js.SockJS._connect @ main.js:222
push../node_modules/sockjs-client/lib/main.js.SockJS._receiveInfo @ main.js:197
g @ emitter.js:29
push../node_modules/sockjs-client/lib/event/emitter.js.EventEmitter.emit @ emitter.js:53
(anonymous) @ info-receiver.js:68
g @ emitter.js:29
push../node_modules/sockjs-client/lib/event/emitter.js.EventEmitter.emit @ emitter.js:53
(anonymous) @ info-ajax.js:38
g @ emitter.js:29
push../node_modules/sockjs-client/lib/event/emitter.js.EventEmitter.emit @ emitter.js:53
xhr.onreadystatechange @ abstract-xhr.js:134

Expected behavior
No errors in console.
Additional context
I'm running on Windows 7, which I know does not support WebSockets. Nevertheless, this is not the expected behaviour. It's unclear to me why it's even trying to use web sockets, why there is no server side error if the server tries to start a WebSocket server and what the impact is.

It seems that the impact is that the authentication doesn't work at all! Is there a way to get this to work on Windows 7? I can't even find any server-side WebSocket code in the generated C# project.

This is a known issue. See Single Page Applications with authentication enabled throws method not found exception when visiting the register or login pages for details on https://github.com/dotnet/core/blob/master/release-notes/3.0/preview/3.0.0-preview-known-issues.md

Thanks, but I'm not getting a MethodNotFoundException or any other exception in the server-side code and applying that workaround made no difference.

Ok, let me take a look. I'll get back to you

FYI, I can register now after applying the Import error "Cannot find module "./components/api-authorization/Login" workaround, but I still get the WebSocket error logged in the console and am now running into #8405

@loop-evgeny are you able to repro this issue with a react app and no authorization? I believe this is an issue with the react development server. So I don't think there's anything we can do here.

Hi. We're closing this issue as we have heard no response from you for some time now. If you have more details and are encountering this issue please add a new reply and re-open the issue.


Update Danalock_V3-BTZBE.md

Im using the device with ZHA and confirm to be working flawlessly.

Thanks


Upgrading from 0.4.0 to 0.5.2 breaks code

Hi!
I've had a version of medium-draft 0.4.0 running with no issues for several months. Now, I upgraded to 0.5.2 and when I try to change an existing document, I get:
EditorState.js:108 Uncaught TypeError: newContent.getEntityMap is not a function
    at EditorState.js:108
    at Record.Map.withMutations (immutable.js:1341)
    at Function.set (EditorState.js:78)
    at Function.push (EditorState.js:349)
    at Object.toggleInlineStyle (RichTextEditorUtil.js:266)
    at MediumDraftEditor._toggleInlineStyle (editor.js:394)
    at StyleButton._this.onToggle (stylebutton.js:37)
    at Object.ReactErrorUtils.invokeGuardedCallback (ReactErrorUtils.js:69)
    at executeDispatch (EventPluginUtils.js:85)
    at Object.executeDispatchesInOrder (EventPluginUtils.js:108)

If I create a new document, no issues appear.
I assume it must be related with the way in which I setEditorData.
For a new document I:
this.refs.myeditor.initializeEditorState();

For an old document I:
this.refs.myeditor.setEditorData(nextProps.list.text_json);

where text_json is the json returned by getEditorData().
I repeat this works if I downgrade to 0.4.0. Any ideas what I may be doing wrong? Thank you!

The breaking change was introduced by draft-js itself. Try to upgrade draft-js version too and test.

thanks again @brijeshb42! Keep up with the good job with this lib!


Maybe warn when FlaskForm is initialized with request.form?

I was going to file a bug report for a different issue until I realized this is a design decision issue so I'll just outline what led up to this suggestion.
It is a common and recommended pattern to initialize wtforms object with POSTed form data.
# http://wtforms.readthedocs.io/en/latest/crash_course.html#using-forms
def register(request):
    form = RegistrationForm(request.POST)
    ...

With flask (and just wtforms), equivalent would be:
def register():
    form = RegistrationForm(request.form)
    ...

Here flask-wtf offers a convenient shorthand:
def register():
    form = RegistrationForm()
    ...

I say "offers" because currently flask-wtf does not enforce nor actively discourage the use of request.form in the initialization. (It only mentions that "you don't have to")
And both works equivalent on most part, leading many to leave request.form as is. (e.g. cookiecutter-flask project)
However, the problem arises when the behavior of these two are different, namely when request.files is not None.
Example modified from this stackoverflow question:
class SettingsForm(FlaskForm):
    photo = FileField('Photo')

@app.route('/', methods=['GET', 'POST'])
def login():
    form = SettingsForm(request.form)
    if form.validate_on_submit():
        # `form.photo.data` is `None` here!

So, this is why I believe FlaskForm should warn when request.form is supplied. I am curious about what you think about this suggestion.

I don't think there's a practial way for the instance to know that request.form was passed. It either knows that something was passed, in which case it uses it, or nothing was passed, in which case it builds a default. It is reasonable to pass in a value in order to avoid the overhead of building the default, so I wouldn't want to warn in those cases.


error on zat package

Hi, when I try use zat package I receive this message
/Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-2.8.1/lib/zendesk_apps_tools/command.rb:280:in `check_for_update': uninitialized constant ZendeskAppsTools::Command::DateTime (NameError)

I have the same issue. @pedrorenan Have you found a workaround?

@PolRod Your PR has now been merged and released in v2.8.4 of Zendesk Apps Tools.


reintroduce CDX LSP

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@amiramw @manwithafox please review. I am not sure about the launcher paths in language_server_node_cdx.yml


Make async-std dependency optional

Hello! Would it be possible to make the async-std dependency optional and feature-gated? Currently, async-std is used for the following: async_std::io traits, async_std::sync::channel, and async_std::fs. If futures-lite and async-channel are used instead (NOTE: these are already dependencies for async-std, so no new dependencies would be added), a bunch of transitive dependencies would be removed without sacrificing any functionality.
Cargo.lock diff, with default-features = false, after making async-std optional: https://gist.github.com/akhilles/60d553d797f9e0e94056da3274285e31.
It's also a fairly straight-forward change: https://gist.github.com/akhilles/29a8de956cf7beb274a2f8d6959d8e4f
Feel free to close this if it doesn't align with this library's design goals.

Hi, sure we can do this — but in order to not break the API we should enable it by default. A PR to add an async-std feature flag would be welcome!


Not downloading all stories

Hello,
I am having a problem where it doesn't download all the stories, for example, yesterday I tried the simple code:
instaloader --login MY_USERNAME :stories --dirname-pattern="F:\Users\Documents\Instagram!stories{profile}" --filename-pattern={profile}_{date} --no-metadata-json --no-compress-json
And it only downloaded 58 out of the 78 stories that were avaible.
Even if I try to write user by user, like:
instaloader --login MY_USERNAME target1 target2 target3...  --dirname-pattern="F:\Users\Documents\Instagram!stories{profile}" --filename-pattern={profile}_{date} --no-video-thumbnails --no-captions --no-metadata-json --no-compress-json --stories --no-video-thumbnails --no-posts --no-profile-pic
It doesn't download everything, it appears that only a % of it.
Why does this happen?
Help appreciated, happy new year to everybody!

Have the same issue, I found 2 ways to mitigate this problem:

Decreasing userids_per_query from 50 to 5 (https://github.com/instaloader/instaloader/blob/5509ea7daf7f5e81534d4eb996c8afd478704426/instaloader/instaloader.py#L809C33-L809C33).
Maybe higher than 5 also works but I didn't test that.
Calling get_stories with all ids that had no stories returned previously repeatedly until there are no more stories returned.

Obviously those are just temporary solutions and result in way more requests then necessary

I tried to run 5 names at a time, but it still ignores some users, maybe it's because I'm putting users who don't have stories posted that day together, I don't know

Have the same issue, I found 2 ways to mitigate this problem:

Decreasing userids_per_query from 50 to 5 (https://github.com/instaloader/instaloader/blob/5509ea7daf7f5e81534d4eb996c8afd478704426/instaloader/instaloader.py#L809C33-L809C33).
Maybe higher than 5 also works but I didn't test that.

I can confirm that 10 works, 20 usually works (depending on how many stories a user posts), but more than 30 almost never works.
What I also run into is if I don't pass any userids into get_stories, I only get 90 users back, and even then that is wrong compared to the result of (https://github.com/instaloader/instaloader/blob/5509ea7daf7f5e81534d4eb996c8afd478704426/instaloader/instaloader.py#L805) which lists 150 userids (of my 943 followees). So what I've been doing is loading my own profile and calling get_followees(), then batching them into blocks of 10 to pass to download_stories


How to Get Response Body in middleware

I want to impl a middleware that can log request and response body
#[async_trait]
impl Middleware for LoggingMiddlware {
    async fn handle(
        &self,
        req: Request,
        extensions: &mut Extensions,
        next: Next<'_>,
    ) -> ReqResult<Response> {
        req.body().clone()
			.and_then(|b| b.as_bytes())
			.and_then(|v| {
				println!("Request: {:?}", std::str::from_utf8(v).unwrap());
				Some(())
			});
        let res = next.run(req, extensions).await;
        // since response is a future
        // how can I get its response body without changing it?
        res
    }
}

Any updates on this one? I had the same scenario, trying to log the response body within the logger middleware but the current design just doesn't support this. In the end, I needed to pull out my logging logic out of the middleware and wrap around HTTP client's execute method in order to invoke the .bytes() method.
I guess the culprit is that body streaming methods such as .bytes() are consuming the whole Response object (self) so it becomes unusable after it is invoked.

I am interested in adding a body trace to my OTLP span but that seems even more difficult as fn on_request_end  ofReqwestOtelSpanBackend is not even async.


Add inceptionV3 through Onnxruntime MIGraphX EP via DLM

Use Onnxruntime + MIGraphX EP to perform inference  of InceptionV3
Ensure fp16 and fp32 cases are run through the EP

[ ] fp16 inference
[ ] fp32 inference

Useful https://pytorch.org/vision/main/models/generated/torchvision.models.inception_v3.html#torchvision.models.inception_v3


Support Node.js 17

In the Readme there is no mention to Node.js v17. Is it officially supported?

Sorry, may I have any news=

The test suite passes, so I presume that everything works.


FLAKE in windows build prepare step:  chocolatey installation of NASM occasionally fails

https://source.cloud.google.com/results/invocations/fae6257c-f5d0-4884-a50f-fe306e5625e6/log
the installation error
nasm v2.14.02 [Approved]

nasm package files install completed. Performing other installation steps.

Attempt to get headers for https://www.nasm.us/pub/nasm/releasebuilds/2.14.02/win64/nasm-2.14.02-installer-x64.exe failed.
  The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://www.nasm.us/pub/nasm/releasebuilds/2.14.02/win64/nasm-2.14.02-installer-x64.exe'. Exception calling "GetResponse" with "0" argument(s): "The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel."

Downloading nasm 64 bit

  from 'https://www.nasm.us/pub/nasm/releasebuilds/2.14.02/win64/nasm-2.14.02-installer-x64.exe'

ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://www.nasm.us/pub/nasm/releasebuilds/2.14.02/win64/nasm-2.14.02-installer-x64.exe'. Exception calling "GetResponse" with "0" argument(s): "The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel."
This package is likely not broken for licensed users - see https://chocolatey.org/docs/features-private-cdn.

The install of nasm was NOT successful.

Error while running 'C:\ProgramData\chocolatey\lib\nasm\tools\chocolateyInstall.ps1'.

 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.

 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

The build afterward fails with
https://source.cloud.google.com/results/invocations/fae6257c-f5d0-4884-a50f-fe306e5625e6/targets/github%2Fgrpc/tests
-- The ASM_NASM compiler identification is unknown
-- Didn't find assembler
CMake Error at third_party/boringssl-with-bazel/CMakeLists.txt:120 (enable_language):
  No CMAKE_ASM_NASM_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "ASM_NASM" or the CMake cache entry CMAKE_ASM_NASM_COMPILER to the
  full path to the compiler, or to the compiler name if it is in the PATH.

This error prevented the nightly builds from being published last night.

We no longer use choco for installing nasm:
https://github.com/grpc/grpc/commit/e324bf5eeefcefc8868dc45eaec43c39a71d2146#diff-5e8429633f5611637361884c7228235b5c128ac42482cf15add437bd591fbb4bR42


[FLINK-11046][elasticsearch] Bump elasticsearch-rest-high-level-client to 7.5.0 in connectors

What is the purpose of the change
In FLINK-11046, We know that ElasticSearch6Connector cause thread blocked when index failed with retry. In either case, elasticsearch rest-high-level-client's bug can deadlock when bulk requests fail.  this can still happen in  7.3.0+ .
see details：
BulkProcessor can deadlock when bulk requests fail
Prevent deadlock by using separate schedulers
We should bump elasticsearch-rest-high-level-client to 7.5.0 in connectors
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

The Jira issue is only slightly related. Could you please open a new Issue for bumping the version, with a description of the deadlock problem? And please ping me.


metrics: pretty ugly d3 plotting

bare with me, my d3 and react isn't very good.. ipfs/go-ipfs#1163 adds an API endpoint on port 5001 that exposes metrics about the memory consumption of the daemon (memstats) and custom metrics about the datastores. (here is a sample of the JSON)
I like to visualize those, after some googling I stubmled over some handwoven d3 react magic and finally
react-d3.
Currently it looks like this:

but after some time the plots stop to update and I get this in the console:
Uncaught Error: Invariant Violation: setState(...): Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.

Like I said, my reactjs knowledge isn't very good (this might be my first public commit) and I wanted some feedback (and maybe a better plotting lib suggestion?) on the general approach before I sink more time into this.
Obvious TODOS:

[x] time on the x axis
[ ] formatting the Y axis properly
[ ] hiding data lines by clicking the legends?
[ ] the custom metrics also have histogram data in percentiles. Might want another chart type for that.

ps: I needed to add /debug/ to ipfs-node-server-static so that the requests are proxied properly.

Awesome!
So a few things on ReactJS (see https://facebook.github.io/react/docs/component-specs.html).
Looks like some of this was covered in any resources you may of found, or maybe you found the page above. I personally am not amazing at ReactJS, but I would say we would want to set the interval for getData(); inside of componentDidMount, as it only runs on the client. Not a big deal though, I don't think it will make a difference in this case.
Right off the bat for the error you are getting I would of assume it was because you switched views, causing your time to be cleared, but the http request would of still been in-flight. But this doesn't appear to be the case for you as it just happening as you watch the plots?

I'd like to have this in soon, cause i want to inspect my nodes. what's missing here? @cryptix @travisperson

I haven't pulled this one down yet, but I'll take a closer look tonight. Currently in the middle of exams (school).

thanks Travis! I'm really fishing in the dark here. :)
On 05.05.2015 18:16, Travis Person wrote:

I haven't pulled this one down yet, but I'll take a closer look tonight. Currently in the middle of exams (school).

Reply to this email directly or view it on GitHub:
https://github.com/ipfs/webui/pull/40#issuecomment-99129110

I'd like to be able to use this -- @travisperson ?

@cryptix Where are you exposing debug/vars for development? When I pull down the PR and run it, I get errors for not being able to request debug/vars. I can curl it http://localhost:5001/debug/vars, but it doesn't appear to be proxying.
I'm assuming you went in and modified the ipfs-node-server-static code, to remove the check for the api value in the first part?

Pretty sure this is an issue with react-d3. I haven't found any references so maybe we are just using it wrong, but this is what I have come up with as to why there is that error.
Inside of the DataSeries the react-d3 lib uses immstruct which is an observable.
        // Create an immstruct reference for the circle id
        // and set it to 'inactive'
        props.structure.cursor('voronoi').set(id, 'inactive');

        // Having set the Voronoi circle id cursor to 'inactive'
        // We now pass on the Voronoi circle id reference to the
        // circle component, where it will be observed and dereferenced
        var voronoiRef = props.structure.reference(['voronoi', id]);

        return (
          <Circle
            voronoiRef={voronoiRef}
            voronoiSeriesRef={voronoiSeriesRef}
            structure={props.structure}
            cx={cx}

https://github.com/esbullington/react-d3/blob/master/src/linechart/DataSeries.jsx#L106
The circle component is listening for these changes, and when it happens it calls _restoreCircle, which runs a setState
componentDidMount:function() {
    var props = this.props;
    // The circle reference is observed when both it is set to
    // active, and to inactive, so we have to check which one
    var unobserve = props.voronoiRef.observe(function()  {
      var circleStatus = props.voronoiRef.cursor().deref();
      var seriesName = props.id.split('-')[0];
      if (circleStatus === 'active') {
        this._animateCircle(props.id);
        props.structure.cursor('voronoiSeries').cursor(seriesName).update(function(){return 'active';});
      } else if (circleStatus === 'inactive') {
        this._restoreCircle(props.id);
        props.structure.cursor('voronoiSeries').cursor(seriesName).update(function(){return 'inactive';});
      }
    }.bind(this));
  },

https://github.com/esbullington/react-d3/blob/master/src/linechart/Circle.jsx#L43
  _restoreCircle(id) {
    this.setState({
      circleRadius: this.props.r
    });
  }

https://github.com/esbullington/react-d3/blob/master/src/linechart/Circle.jsx#L73
Since the props.structure.cursor('voronoi').set(id, 'inactive'); is happening inside of a render method, we get this error being thrown back at us.

@travisperson thanks for looking at this!

I'm assuming you went in and modified the ipfs-node-server-static code, to remove the check for the api value in the first part?

Yup, I patched it here to allow /debug as well. I should have posted a PR for this as well.

Ok so I just looked at this, and have some questions/opinions
If we want to export this debug information, i really think it should go through the ipfs api, like everything else, not through custom http requests.
It does not make a whole lot of sense to add implementation specific stuff to the api though, so maybe we could have a /metrics url that would just return key-value pairs of whatever your implementation supports?
@jbenet, @cryptix, @tperson any thoughts?

Another thing, if we're going this way, we should probably also do the saving of the values in the backend, so that you don't have to keep the cache of older values in the browser. We should probably also support range queries, like 'last 5 minutes, last 30 minutes' etc.

@krl: I tried to convey this with the meme picture in the initial post. I don't have any strong feelings about any of this. I just wanted to get this out there to show that we have this data now.
re format: I think this is pretty specific to the go implementation and I'm not sure adding it to the IPFS API and specifying it for ipfs in general makes much sense.
IMHO we should be fine with documenting the json values we expose through expvar and what they mean.
re storing metrics: I don't know.. running every node with a full fledged time series DB sounds excessive. I'd be more in favor of either supporting influxdb or Prometheus backends, depending on wether we want to support a pull or a push model and leaving this as a pure feed/stream.

Stubmled over this blog post yesterday. Maybe someone with a higher webui-belt can vet this approach?

@cryptix is this something you are still looking into finishing, or should we close this for now?

I'm fine with closing. I had zero time to get my teeth into frontend recently... :-/
I hope somebody does this sometime for network throughout / ram useage / etc..
The data is already there with the Prometheus endpoints.

On 19.11.2015, at 18:29, Friedel Ziegelmayer<EMAIL_ADDRESS>wrote:
@cryptix is this something you are still looking into finishing, or should we close this for now?
—
Reply to this email directly or view it on GitHub.

It would be really, really nice to have it built into the webui. once the webui modularizes we can have an explosion of little apps to try.
we should come up with a good permissions model for them-- i.e. grant permissions to an app to a strict subset of the API. (say RO, or on subset of commands, etc).
since our API is a command tree, we could create policies that effectively do this:
deny *
allow ipfs/object/get
allow ipfs/cat
allow ipfs/bitswap/stat
allow ipfs/logs?filter=bitswap

Thanks @jbenet closing this here. I fully agree that this would be nice and will be adding it to the list of nice visualizations/apps to have :)


Error sending overdue notifications to Slack

Expected behaviour
Send overdue notifications to Slack
Actual behaviour
PHP Notice:  Undefined index: task in /var/www/[folder]/public_html/plugins/Slack/Notification/Slack.php on line 30
PHP Catchable fatal error:  Argument 3 passed to Kanboard\Plugin\Slack\Notification\Slack::sendMessage() must be of the type array, null given, called in /var/www/[folder]/public_html/plugins/Slack/Notification/Slack.php on line 31 and defined in /var/www/[folder]/public_html/plugins/Slack/Notification/Slack.php on line 98

Steps to reproduce

copy plugin source to plugins/Slack
configure slack incomming webhook-url under user > profile > integration (or admin > settings > integrations)
activate Slack via user > profile > notifications
run ./cli notification:overdue-tasks --group on shell

Configuration
Version: 1.0.35
PHP Version: 5.5.9-1ubuntu4.20
PHP SAPI: apache2handler
OS Version: Linux 3.13.0-57-generic
Datenbanktreiber: mysql
Datenbank Version: 5.5.53-0ubuntu<IP_ADDRESS>
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0.1 Safari/602.2.14

Thank you, this is now fixed. You can download the last version of the plugin.


Can we authenticate users with Facebook Account?

Authenticates with Facebook Account
Among authentication functions presented there is not a function that gives the ability to connect a user with his facebook account. Can you implement this function in the authentication API. If it already exists, the documentation should be updated with the adequate process.

Thanks for the job done ✅

No, Firebase Auth is not supported as it requires introducing a dependency on the weighty Facebook SDK. For this reason it will not be added to this plugin directly though possibly will be added as a child/sibling plugin in future if I have need for it.


Need a button that allows me to go one slide to the right

Hi, I am unsure of how to implement a button in the carousel itself that will take me one slide to the right or one slide to the left. Any help would be greatly appreciated.

Share your code on plunker

Figured it out.
If anyone else is wondering, you have to define a class in your slide

and then in arrows:

Slick also provide style sheets you can customized those css according to you.


xtensa/esp32-s2: Adds support to rt_timer and systimer to ESP32-S2.

Summary
Espressif newer chips come with systimer peripheral which is suitable for OS tick generation and timekeeping.
RT timer is a component that allow multiple clients (like drivers) to set timeout alarms and keep tracking of the time.
Like Wi-Fi driver.
This MR adds support for RT timer relying on systimer.
P.S: Note that on ESP32-C3, one systimer comparator is used for OS tick generation and the other for rt timer, but on ESP32-S2, systimer is exclusively used for rt timer and it's not used for OS tick generation. Instead, internal xtensa timers are used for this purpose. The reason is that on ESP32-S2, systimer has only edge interrupt and the processor has a small amount of edge interrupts available, therefore, we manage better our resources using this approach.
Impact
N/A
Test
Internal rt timer test on GL.

FYI: Ready for review.


Does this package support phantomjs?

If so, any example? If not, any plan to add it?

I doubt it. Personally integration tests with selenium are much faster than with phantomjs and I don't plan on going back.
Also PhantomJS has been abandoned.


Enable Feature Photo/Media Selection for Notes

Enable Feature Photo/Media Selection for Notes
Issue:
We want users to select their favorite image or video from the set of media attached to a note. The selected media would be the preview featured image on the home page when showing the note for the first time.
Acceptance Criteria:

Users can select a favorite photo or video from the media attached to a note.
Selected media is displayed as the preview featured image on the home page.

Note:
For video, the thumbnail of the video will be used.

This was merged in with deliverable-5 resolving


Indent guide lines,  line numbers, and hide the run and delete button part in jupyter notebook cell ?

Is there a way to display the Indent guide lines and line numbers in jupyter notebook cell ?
By the way, to concentrate on coding, can we hide the run and delete button part ?

/extPython


fix: ndt flooding log

Description
When the point cloud is not coveraged the NDT node log is flooding the console:
[ndt_scan_matcher-2] [WARN] [1686639831.364509671] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.364542779] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.465749727] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.465800431] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.565748955] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.565782885] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.675421152] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.675484404] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.772806544] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.772857134] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.873371754] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.873421510] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639831.974010692] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639831.974074547] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.074415036] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.074455322] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.164526713] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.164564351] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.274345591] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.274391287] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.363971271] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.364008761] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.474264725] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.474310611] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.565764173] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.565804341] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.668706515] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.668742463] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.768846657] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.768882351] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.868564785] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.868601798] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639832.963634663] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639832.963663521] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639833.063880979] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639833.063915366] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639833.164153859] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639833.164185414] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639833.268700324] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639833.268738485] [localization.pcr.ndt_scan_matcher]: Not Converged
[ndt_scan_matcher-2] [WARN] [1686639833.381691998] [localization.pcr.ndt_scan_matcher]: Nearest Voxel Transformation Likelihood is below the threshold. Score: 0.000000, Threshold: 2.300000
[ndt_scan_matcher-2] [WARN] [1686639833.381748896] [localization.pcr.ndt_scan_matcher]: Not Converged

Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Hi, thank you for creating the PR.
However, The logs informing about the score falling below a threshold are crucial. To ensure that it is clearly indicated when the score drops after successful initialization, I believe it would be better not to change it to RCLCPP_WARN_THROTTLE.
By the way, in the logs you provided, the score is shown as 0. Rather than indicating a matching failure, it suggests that there might be abnormalities in the map or the sensors.
Once the abnormalities in the map or sensors are resolved, I believe the issue of the logs flooding the screen will be resolved as well.

Thank You for Your fast response. i think this needs some clarification though:

However, The logs informing about the score falling below a threshold are crucial.
I believe so, however once the screen is flooded with this information You might not be able to find the real cause for this error, E.g. Not loaded map, or some other performance/localization issues.
In our case, this log appears when we drive through suburbanized terrain, where the NDT doesn't have many orientation points, and also, as You mentioned, the map quality is quite low, but still this shouldn't disallow diagnosis of other parts of our system.

To ensure that it is clearly indicated when the score drops after successful initialization,
The disappearance of a log message shouldn't be the indicator that the system is initialized, this should rather be noticed as e.g. low covariance values, and also warning messages should be used as notifications of serious node issues.

Thank you for explaining the problem you are facing. I understand it. :smile:
However, even if the NDT logs are filling up the screen, we can still identify the underlying issue by using rqt_console to exclude logs streamed from specific nodes. The image below illustrates the exclusion of logs from ndt_scan_matcher using rqt_console.

One the other hand, reducing the logging frequency makes it more difficult for us to notice matching failures.

@ralwing What is the status of this PR? Still under review, or should it be converted into draft?

@ralwing What is the status of this PR? Still under review, or should it be converted into draft?

If You agree with my argument's then it's ready to merge, otherwise it should be closed (as won't merge)

@ralwing Thank you! Although I understand your concern, I personally agree with @KYabuuchi. Given that the log won't flood as long as the system is working correctly, I also think that it is reasonable to output the log without THROTTLE as it is right now.
(Anyway, we appreciate your contribution :pray:)


Add instrumentation to Catalyst's frontend

Adds frontend instrumentation to QJIT class methods. To use the instrumentation a session needs to be started:
with instrumentation("identifier", filename="optional_file_path_for_yaml_results", detailed=<True/False>):
    qjit(my_function)(my_args)

Example output (YAML):
2024-03-14 22:32:56.016040:
  name: circuit
  system:
    os: macOS-13.6.4
    arch: arm64
    python: 3.11.6
  results:
    - pre_compilation:
        walltime: 0.003459
        cputime: 0.003
    - capture:
        walltime: 181.768209
        cputime: 181.65
        programsize: 4689
    - generate_ir:
        walltime: 141.458708
        cputime: 141.301
        programsize: 2985
    - compile:
        walltime: 1545.747416
        cputime: 1260.893
        programsize: 11480
    - run:
        walltime: 5.508291
        cputime: 4.384

Example output (console):
[DIAGNOSTICS] Running pre_compilation           walltime: 0.006 ms      cputime: 0.006 ms
[DIAGNOSTICS] Running capture                   walltime: 4.08 ms       cputime: 4.08 ms        programsize: 55 lines
[DIAGNOSTICS] Running generate_ir               walltime: 8.417 ms      cputime: 8.417 ms       programsize: 59 lines
[DIAGNOSTICS] Running compile                   walltime: 309.765 ms    cputime: 309.765 ms     programsize: 194 lines
[DIAGNOSTICS] Running run                       walltime: 9.098 ms      cputime: 9.098 ms

@maliasadi Could you have a look? I'll add some tests as well to complete the coverage.


Check watch plugins for key conflicts

Summary
Watch plugins now are checked for key conflicts…

Some built-in keys remain overridable (specificically t and p).
Any key registered by a third-party watch plugin cannot be overridden by one listed later in the plugins list config.

Fixes #6693.
Refs #6473.
Test plan
Additional tests are provided that check every conflict / overwritable scenario discussed.
Request for feedback / “spec” evolution
The “spec” is an ongoing discussion in #6693 — in particular, the overwritability of some built-in keys, such as a, f and o, may be subject to discussion. This PR tracks the decisions in there and may evolve a bit still.
Ping @SimenB @thymikee @rogeliog for review and discussion.

Codecov Report

Merging #6697 into master will increase coverage by 0.1%.
The diff coverage is 96.77%.

@@            Coverage Diff            @@
##           master    #6697     +/-   ##
=========================================
+ Coverage   63.71%   63.81%   +0.1%
=========================================
  Files         235      235
  Lines        8998     9027     +29
  Branches        3        4      +1
=========================================
+ Hits         5733     5761     +28
- Misses       3264     3265      +1
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-cli/src/watch.js
81.97% <96.77%> (+2.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05e53a...20cfedc. Read the comment docs.

I just force-pushed an updated branch on top of latest master, to fix conflicts w/o butchering the graph with a reverse merge (as GitHub's UI would do). As I was force-pushing anyway, I fused both commits (original and lint:md:ci fix) as I'm not on in this for the contributors hall of fame anyway 😉

We squash on merge anyways 🙂
@rogeliog would you be able to take a look at this?

I think this deserves some docs as well, mind updating https://github.com/facebook/jest/edit/master/docs/WatchPlugins.md?

@SimenB sure thing, here goes. I took the opportunity to rebase on top of the latest master, too.

@SimenB unrelated: what's the Jest site release process like? I thought this would be automated, but it lags behind a bit most of the time (right now it's stuck on 23.3 for instance).

See https://jestjs.io/docs/en/next/getting-started.html.
We cut new versions when the doc warrants it. None of the changes in 23.4 had doc changes

Ah, OK. 23.4.1 had (the broader updatable options set), but as it's very recent and a patchlevel, that probably explains why it's not there yet.

(also weird: the next version fails on watch-plugins?!)

(also weird: the next version fails on watch-plugins?!)

I just pushed a rebased history on top of the latest master that addresses @rogeliog's good wording points.

 I'm fairly
confident its breakage on Netlify was circumstancial.
On Thu, Jul 19, 2018, at 17:54, Rogelio Guzman wrote:

@rogeliog approved this pull request.

Awesome!

— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].
--
Christophe Porteneuve
<EMAIL_ADDRESS>
Links:

https://github.com/facebook/jest/pull/6697#pullrequestreview-138739538
https://github.com/notifications/unsubscribe-auth/AAAOqPaydHsrZpUvbGVzPC1oTbjJ9Rwvks5uIKuqgaJpZM4VQOcf

I'm not sure how to retrigger the Netlify check. I guess you could amend your last commit and re-push 😕?

@rogeliog @SimenB Netlify check fails fast still. The message is extremely unclear:

9:34:08 AM: Failing build: Failed to prepare repo
9:34:08 AM: failed during stage 'preparing repo': exit status 1

If anyone on the build infra team could look at it…

Hi, I've re-triggered the netlify preview. There is a build cache error causing it to fail.

@endiliey thanks!
Dang it, this time it's a Yarn registry timeout that failed test-jest-circus. As for the CHANGELOG conflict, I'll rebase and force push, we'll see how CI goes.

@endiliey @rogeliog @SimenB success! all checks pass now! Ready to merge 😉


Develop a testing strategy

Ideally, the following tests should exist:

reasonably high test coverage via unit-tests inside this repo
integration tests between lazyledger-app and optimint
run the simapp with optimint (see https://docs.cosmos.network/master/building-modules/simulator.html and https://github.com/cosmos/cosmos-sdk/blob/deaee531111fb4aad3ccabbfa6771f9a67ae42ce/simapp/app.go#L1)
integration tests between lazyledger-app and another very simple ORU app based on the Cosmos-SDK (using optimint under the hood)
spin up a small network with the LL main chain and two simple apps with their own dedicated clients

The first point is the only one that we needs immediate and continuous action. And I think we are on the right track for this. For the other points it is a bit too early but we should have them before the first testnet with ORU support.
We should definetely split this up into several issues. Point 5. alone is a bigger project on its own. I just wanted to jot this down for now. We could use this issue as a kind of meta issue to link between all relevant issues (and prs).

Closing this since testing has been added extensively to Rollkit


AdlerID?

Do we want entries in the AdlerData database to have their own AdlerID number?

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

If we go down the multi-apparation route then we may have more than one entry in the AdlerDatabase with the same ssObjectId, so this would be handy, as we probably shouldn't use MJD timestamps as IDs.


Fix internal links

Uppercase internal links don't work when clicked in the 'Protocol Messages' tables of Client Protocol and Cluster Protocol pages. Changing links to lowercase (e.g. #PUB -> #pub) should make them clickable again.

Note: This problem does not occur on github.com, only when the files are rendered on github.io.

Also removing a number HTML anchors which should be made obsolete by this PR and adding a number of missing internal links.

lgtm - @morrisio thanks for the fix!


Why does data/snyk.json contain duplicate entries?

ie. 8 SNYK-DEBIAN11-SYSTEMD-3111119, CVE-2022-3821
Is there a difference between the 8 that I am missing?

Ye, these do look the same. No idea why snyk outputs dups, is that a function of the --app-vulns flag?

For now, there is a unique filter that removes the exposures that have the same ID, pkg, and version


fix: rewords some few things

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Revert "Add History to Profile page"

Reverts jcarney2024/climacloset#25

un-doing the commits that broke our website :(


[Feature Request] Leave VC when sharing the channel with only bots

Is your feature request related to a problem? Please describe.
When using two separate instances of the music bots (or other bots) and then leaving the Voice Channel, the bots do not automatically leave the channel.
What is your ideal solution to the problem?
When the bot shares the channel only with other bots, it leaves the channel.
How would this feature be used?

Have the bot join a voice channel.
Have a different, unrelated bot join the voice channel.
Leave the voice channel.
MusicBot is now expected to leave the voice channel after a certain amount of time.

Additional Info
No response
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

This is already what the alonetimeuntilstop field in the config is for. Bots and users that are deafened do not count as "listening", and therefore don't count against the bot considering itself "alone."

https://github.com/jagrosh/MusicBot/blob/master/src/main/java/com/jagrosh/jmusicbot/audio/AloneInVoiceHandler.java#L90-L97


chore: fix ledger, ref #4861

Try out this version of Leather — Extension build, Test report

Not happy with this solution, though quick.
The cause of this bug was duplication of the JSX.
            <Link
              hideBelow="md"
              invert={isAtleastBreakpointMd}
              flex={1}
              mt={[0, 0, 'space.05']}
              data-testid={OnboardingSelectors.SignInLink}
              onClick={onRestoreWallet}
              size="lg"
            >
              Use existing key
            </Link>
            <Button
              hideFrom="md"
              variant="outline"
              invert={isAtleastBreakpointMd}
              flex={1}
              mt={[0, 0, 'space.05']}
              onClick={onRestoreWallet}
            >
              Use existing key
            </Button>
            <Link
              hideBelow="md"
              invert={isAtleastBreakpointMd}
              flex={1}
              mt={[0, 0, 'space.05']}
              onClick={onSelectConnectLedger}
              size="lg"
            >
              Use Ledger
            </Link>
            <Button
              hideFrom="md"
              variant="outline"
              invert={isAtleastBreakpointMd}
              flex={1}
              mt={[0, 0, 'space.05']}
              onClick={onSelectConnectLedger}
            >
              Use Ledger
            </Button>

The duplication here was a temp solution, I believe, just so we could get the new button changes merged in and not create a lot of conflicts with Pete's open container changes branch. We should revisit after that work gets merged if still present.

We can try and get rid of some duplication when I deprecate invert= and have a custom UI here.
However, this duplication of tags is what panda suggest you do to show/hide stuff on different views. So rather than:
const isAtleastBreakpointMd = useViewportMinWidth();

<Component size={isAtleastBreakpointMd ? 'md' : 'sm'}/>

They suggest:
<Component size='sm' hideFrom='md'/>
<Component size='md' hideAbove='sm'/>

Although this is duplication I believe it will make things smoother as the elements are already in the DOM and CSS is used to show/ hide rather than a hook and re-render.
I started doing this as on some pages e.g. the Receive dialog, as you move from screen to screen useViewportMinWidth re-runs to check the size and causes a re-render flash


Add additional tests for only and all arguments for session_and_runs

TODO: currently only working for session and run, as well as
'all' for sessions but not for runs, is not tested. This is relatively
minor because the underlying code is shared with 'only', nonetheless
it will be necessary to add a test for this. This will necessitate adding
another toy example dataset.

also check that the is raised for 'all' or 'only' if they are not the only inputs to the run level.

also test the assert for the sessions going out of order when globbing.

Also need to test for sorting


Micrometer: Router policy should be disabled by default (to be consistent with Camel)

Bug description
As you can see in Camel documentation, RoutePolicyFactory is not enabled by default. CQ should be consistent with this behavior and change default value for property camel.metrics.enableRoutePolicy to false (code)

The docs state that the default is true:
https://camel.apache.org/components/3.20.x/micrometer-component.html#_sb_option_camel_metrics_enable-route-policy

Default is true for CSB, unfirtunately for **plain Camel default is false**. Because users have to set routePolicy like in the test. (Explanation in the doc is From Java you just add the factory to the CamelContext as shown below: context.addRoutePolicyFactory(new MicrometerRoutePolicyFactory());
Therefore CQ  should default to false and ticket should be reported for CSB.

@JiriOndrusek it can be closed? or is there anything about document we need to do?


Beginner question about frozen layers and transfer learning

When training the RPN Model for example, wouldn't be more suitable to reuse the weights for 'imagenet' instead of retrain all model from scratch?
Did you noticed better results when training all model instead of only last layers?
Thank you

Hi @emipasat,

The model is already using imagenet weights. You need to read about default params of keras applications, for VGG16.
The model is already working to train not only the last layers but all the layers.

Sorry for not being clear. My question was if is worth to freeze the backbone layers and to train only the ones added by you, the last ones.
Would it work that, too?
Thank you

You could give it a try. However, in my experience, fine-tune generally gives better results than transfer learning.


added repr methods to base home class[Issue #21]

#21
For the sake of testing, I have added __str__ and __repr__ a single class. Please do see if they work

Codecov Report
Base: 87.20% // Head: 86.96% // Decreases project coverage by -0.24% :warning:

Coverage data is based on head (518322e) compared to base (e2dd06d).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   87.20%   86.96%   -0.25%
==========================================
  Files          31       31
  Lines         977      982       +5
==========================================
+ Hits          852      854       +2
- Misses        125      128       +3

Impacted Files
Coverage Δ

tibber/types/home.py
93.82% <40.00%> (-1.72%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov bot is a bit strict... I should look into it's settings... But anyway, thanks for the contribution! My internet is currently down so I won't be able to check this PR on my computer just yet, but once I've just checked how it looks I'll comment here again or merge it. Great work! 😄

Thanks
On Thu, Dec 8, 2022 at 5:55 PM Eric B @.***> wrote:

Codecov bot is a bit strict... I should look into it's settings... But
anyway, thanks for the contribution! My internet is currently down so I
won't be able to check this PR on my computer just yet, but once I've just
checked how it looks I'll comment here again or merge it. Great work! 😄
—
Reply to this email directly, view it on GitHub
https://github.com/BeatsuDev/tibber.py/pull/22#issuecomment-1342691724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI2VVZRXKQ3R2ZGXQEFCEU3WMHLFFANCNFSM6AAAAAASX4A5JQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, I tested it on the demo account now and here is the output:
Vitahuset is owned by <tibber.types.legal_entity.LegalEntity object at 0x000002138E79EE90> with 5 residents at None

Could you make it display the name of the owner instead? Maybe you could also add a check to see if the city is defined before adding it to the string? Otherwise, it looks good!

Nice! Just a last little change; it would be great if you could use double quotes instead of single quotes just to stay consistent with the rest of the project 😄


loading button

Please pull the main branch before commiting also please don't modify any other files apart from the file that are related to your commit, like package.json
Please fix these issues and PR again


Error while invoking Init function in chaincode: Cannot use metadata. Metadata did not match schema

Hi,
I am trying to deploy a chaincode in my fabric network with init function invoke. My chaincode is getting committed on peers but I am getting an error message while invoking init function.
Note: I am running my custom chaincode on test-network sample setup.
Please find the following attached screenshot to see the proper error message.

Let me know the cause of this error.

@mbwhite any ideas?

@denyeart This error was caused by Peer package included in chaincode. I just removed Peer package and changed returnType of chaincode functions from Peer.Response to (Asset, error). Is there any new change introduced in Peer chaincode package which requires some parameters to be passed? I remember it used to work completely fine when I was working on fabric 1.4 version.

@Dimple-Kanwar are you able to share your code please that caused the issue.
Are you using the fabric-contract-go ? or fabric-shim-go?


Simple Change: Make resolveRoute a class member of UniversalRouter instead of privately scoped

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] other (Please do not submit support requests here (below))

Feature request
Would there be any backwards compatibility issues with moving the resolveRoute function to be inside the UniversalRouter class? The reason for this is when extending UniversalRouter, you cannot override the resolveRoute function as its a privately scoped function in the UniversalRouter.js file, outside of the UniversalRouter class.
Currently I have my resolveRouter passed in as a parameter, but I have a custom class for my router to add in functionality like history API. Being able to override resolveRouter inside that class would be a cleaner interface, keeping like logic together. I don't see any conflicts with this change and would improve class support. Is there a good reason for this to stay as a private function?
Proposed Change
class UniversalRouter {
    constructor(routes, options) {
         ...
    }

    resolve(pathnameOrContext) {
        ....
        const resolve = this.options.resolveRoute || this.resolveRoute;
        ...
    }

    resolveRoute(context, params) {
        if (typeof context.route.action === 'function') {
            return context.route.action(context, params);
        }
        return undefined;
    }
}

Then custom router classes can override it or it can still be passed in as an option.
class MyRouter extends UniversalRouter {
    resolveRoute(context, params) {
        // custom logic
    }
}

You can override resolveRoute in your custom class like this:
class YourRouter extends UniversalRouter {
  constructor(routes, options) {
    super(routes, { ...options, resolveRoute: this.resolveRoute })
  }
  resolveRoute(context, params) {
    // custom logic
  }
}

But could you tell us a little about why you need to extend the UniversalRouter class, i.e. what functionality are you missing?


Selections reveal horizontally delayed

Since a few weeks now I notice how a selection that is out of the viewport horizontally only reveals with a slight delay. Here I am navigating between 2 editors:

I can't reproduce anymore on latest. I believe this was fixed via https://github.com/microsoft/vscode/pull/174266


catalob-backend: make CodeOwnersProcessor handle url locations

@andrewthauer this is very much untested, but I'm assuming it will work since the target URLs are unchanged. Do you happen to have a good example laying around that it could be tested with?

@andrewthauer this is very much untested, but I'm assuming it will work since the target URLs are unchanged. Do you happen to have a good example laying around that it could be tested with?

Quick glance suggests this should work if the URL can be parsed properly with git-url-parse. I suspect this could be tested by trying to import a location looking something like { type: 'url', target: 'https://github.com/spotify/backstage/blob/master/catalog-info.yaml' }.


Fixed resize view

If we use match_parent for the MaterialCalendarView but the size available is not enough, the view was truncated.
Fix for https://github.com/prolificinteractive/material-calendarview/issues/416
Same but better fix for PR https://github.com/prolificinteractive/material-calendarview/pull/435

If you take the max size, that means you want the width to be as large as the height. Even if you don't have enough place. So some columns will disappear.
Taking the min size can make the calendar a bit smaller but that's because the container tell me that I cannot exceed this size.

👍 LGTM, will be testing and merging in the near future.


[DNM]add example for hardcode metrics list

What problem does this PR solve?
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Codecov Report
Patch coverage: 66.67% and project coverage change: -1.62 :warning:

Comparison is base (c0cacb0) 30.11% compared to head (79ca7ff) 28.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   30.11%   28.49%   -1.62%
==========================================
  Files          50       50
  Lines        4218     4212       -6
==========================================
- Hits         1270     1200      -70
- Misses       2778     2844      +66
+ Partials      170      168       -2

Flag
Coverage Δ

unittests
28.49% <66.67%> (-1.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/diag/command/root.go
20.29% <66.67%> (+0.57%)
:arrow_up:

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

example metrics are dumped from a tiup-playground deployed local cluster, may not precise


Shell Box translation should be updated to conform to latest HD commits

https://codeberg.org/mc776/HideousDestructor/commit/902061bd8f22fdbdd4ee2727114938904d201c3c
https://codeberg.org/mc776/HideousDestructor/commit/35353f487a89f3b10603c360312f94c6730c134f
this allows reskins to use the brassy color for shell ends.

Ah, I saw that; so basically then the translation located in the ShellBox.zs class can be removed?


Update Plugin Artifacts Links for v0.171.0

Automated changes by create-pull-request GitHub action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Inconsistency between JSX and TSX

JSX

TSX

can you please paste larger code sample? Tsx and Jsx both use same grammar so it would be interesting to see why colorization could be different.

That was the full text.

Seems like some other issue to be diagnosed on vs side since vscode shows this correctly. we are scoping it correctly.

I see the same.  VS has classification in .jsx and .js, but not in .tsx or .ts.  I'll investigate.

I can't figure out where it's consumed, but the behavior seems to hinge on the value of the defaultFileExtensionForGrammar buffer property.

Yep, it's a VS bug.  Sorry for the noise.


Add Capture Stream functionality

It would be helpful to provide the end user with a way to capture a raw RTL-SDR data stream for diagnostic/debugging purposes.  My vision here is a relatively simple Client Specific setting that would prompt the user to select from the list of existing known channels, specify a capture path, and specify a capture length (something like 30s, 1m, 5m, 10m).
The debug version of the addon would of course need the ability to read data from this capture as opposed to a USB/RTL_TCP device for the value-add ...

I'm questioning the usefulness of this when the rtl_sdr application is provided in the toolkit.  Let's table this until/unless somebody asks for it?


WCAG 1.4.3: (EditingExaminerDemo/document '' CoreXaml)[High Contrast 1] Contrast ratio failure for regular text

The following accessibility issue needs investigation.
App: EditingExaminerDemo
Element path: document '' CoreXaml red text
Issue Details: Contrast ratio failure for regular text in High Contrast 1.
How To Fix: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.


Feature/cpu only

A couple bugfixes and removed dependencies to allow running PTB demo code out of the box on Mac OS X in CPU-only mode. GPU acceleration is untested and the Text8 example doesn't quite work.

Sorry a little confusion on how github's fork process works; I didn't mean to try to merge back to the original repo :)


Add a few methods to the controller to support grabbing crawl metrics

I am open to moving these methods into a metrics class but it sounds like you would reject that PR. Is that correct? For what its worth, I understand there is a balance between features and maintainability but these aren't complicated features.