clickhouse-jdbc-0.6.0-patch3-all.jar includes CVE-2023-3635

The included com.squareup.okio:okio should be updated to version 1.17.6 from the current 1.17.5
I have no idea if the vulnerability itself has any effect in this JDBC driver use case, but updating the dependency seems like the easiest solution.

@jjtt Thank you for reporting!

@jjtt
this dependency is related to the GRPC client and GRPC client is going to be deprecated soon.
As I may see this dependency has very old version and only several latest do not have the CVE. So it would require some effort to upgrade to the latest version.
We will handle it later while removing the GRPC client.

GRPC client has been removed in https://github.com/ClickHouse/clickhouse-java/releases/tag/v0.7.0


Add Observer render and inject sugar #387

@Sunshine168 Thanks for the PR! @FredyC's PR is merged, could you rebase?
PR looks good :). One remaining question; could you update the Readme as well describing this alternative syntax?

Also, it's obvious that using children has a priority, but there should be test showing a use of both at once. And reflect this in docs as well.

i will rebase later  , i am still in working

done !

@FredyC  Ohhhh  very thank you for your help    .tat   now will be better?

Great work @Sunshine168 and thanks for the extensive reviews @FredyC and @Gvozd ! Will release tomorrow

This is broken. Results in Warning: Failed prop type: propValue is not defined errors due to usage here https://github.com/mobxjs/mobx-react/blob/master/src/observer.js#L368

@mvestergaard That's an unfortunate oversight. Could you send in the PR please? Some tests for this should be probably included as well.

Just released 4.4.1, that should fix the issue. Unclear yet why this passed the tests, so if somebody could add a test testing the prop types checking that would be appreciated :D


Is it possible to make mex work on windows-latest?

According to issue 29, it was not possible to make mex work on windows-latest as of February 2022. What about now in 2023, with newer MATLAB?
Many thanks!
Zaikun

Hi Mark @mcafaro ! Thank you for your response.
I did some tests just now. R2022a/b both failed, complaining "Did not find installed compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2019'."
2022a: https://github.com/equipez/setup_mex/actions/runs/3883944407/jobs/6625854081
2022b: https://github.com/equipez/setup_mex/actions/runs/3883944407/jobs/6625854209
Other versions (all succeed): https://github.com/equipez/setup_mex/actions/runs/3883944407
The workflows: https://github.com/equipez/setup_mex/actions/runs/3883944407/workflow
Installation of Intel OneAPI: https://github.com/equipez/setup_mex/blob/main/.github/scripts/install_oneapi_windows.bat
It would be great if you could take a look.

Sorry, I should have mentioned Visual Studio 2022 only has a C and C++ compiler. If you need to compile Fortran MEX files, you'll still need to bring your own Fortran compiler with windows-latest and 22a/b.
R2022a and R2022b require Intel oneAPI 2021 for Fortran. It looks like you may be using oneAPI 2023.

Hello Mark,
I made some new tests:
https://github.com/equipez/setup_mex/actions/runs/3889645833
Different from the documentation, MATLAB never looks for VS above 2019. See, for example,
https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085171
It is true that the oneAPI version in this workflow (2023) is higher than expected (2021). However, it does not seem to be the reason for the failure. MATLAB does not complain about it, but says that it cannot find VS 2015, 2017, or 2019.
I am afraid that this might be a bug similar to a previous one, where an early version of R2022a does not support gfortran 8.x as documented. This has been confirmed as a bug by the MEX team of Mathworks.
Would you mind having a look at this problem, or drawing the attention of your colleagues on the MEX team? Thank you very much!
(PS: I also tested oneAPI 2021. The test also failed, but for a different reason: the offline installer of oneAPI does not work with windows-latest, which has been reported to the Intel CI team).

Hi Zaikun
The two issues are different.
R2022a and R2022b support intel 2021 only, as mentioned on the supported compilers page(https://www.mathworks.com/support/requirements/supported-compilers.html).
You must have VS 2019 and Intel 2021 in order to build a Fortran MEX function in these releases.
That said, I will investigate this issue further.
Can you put a link to the exact log file that has the error messages?
If possible can add "-v" to your MEX commands and try to rebuild the mex commands.
-Sriram

Hello Sriram @ssankarmw ! Thank you very much for looking into this issue.
Here are the error logs, where mex was always called with "-v". I hope you can see them. I will attache them at the end of this comment, just in case.
R2022a: https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638084886
R2022b: https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089
I would like to highlight the following points.

According to the official documentation, MATLAB R2022a/b supports not only VS 2019 but also VS 2022, the latter being available on windows-latest.

However, according to the error logs, MATLAB looks for VS 2015/7/9, disregarding the existing VS 2022, and hence the failure.

Even if the oneAPI version is different from the documentation (e.g., 2022 vs 2021), MATLAB seems to be fine with it.
Indeed, on windows-2019, MATLAB works happily with VS2019 + oneAPI 2022 or 2023 (see, e.g., https://github.com/equipez/setup_mex/actions/runs/3902273795/jobs/6665150402)

R2022a:
MATLAB is running in headless mode.  Figure windows will not be displayed.

  	Sponsored License -- for use in support of a program or activity sponsored by MathWorks.
  	Not for government, commercial, or other non-sponsored organizational use.

  Verbose mode is on.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2015' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow64[32](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:34)Node\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  Did not find the installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2015'.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Enterprise -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Professional -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Community -property installationPath -format value' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2015' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2015'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER20' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER20' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER21' ...No.
  ... Looking for environment variable 'ONEAPI_ROOT' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  Did not find installed compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER21' ...No.
  ... Looking for environment variable 'ONEAPI_ROOT' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Enterprise -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Professional -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Community -property installationPath -format value' ...No.
  Did not find installed compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2019'.
  {Error using command_186d8d9f_e6a7_[41](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:43)[51](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:53)_a6c4_13e14d32dc[69](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:71)
  Supported compiler not detected. For options, visit https://www.mathworks.com/support/compilers.
  }
  ERROR: MATLAB error Exit Status: 0x00000001
  exit status 1

R2022b:
MATLAB is running in headless mode.  Figure windows will not be displayed.

  	Sponsored License -- for use in support of a program or activity sponsored by MathWorks.
  	Not for government, commercial or other non-sponsored organizational use.

  Verbose mode is on.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2015' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow64[32](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:34)Node\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 14.0 ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2015'.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER18' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Enterprise -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Professional -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Community -property installationPath -format value' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2018 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2015' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2015'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER19' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2019 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER20' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER20' ...No.
  Did not find installed compiler 'Intel Parallel Studio XE 2020 for Fortran with Microsoft Visual Studio 2019'.
  ... Looking for compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2017' ...
  ... Looking for environment variable 'IFORT_COMPILER21' ...No.
  ... Looking for environment variable 'ONEAPI_ROOT' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for registry setting 'HKLM\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  ... Looking for registry setting 'HKCU\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7' 15.0 ...No.
  Did not find installed compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2017'.
  ... Looking for compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2019' ...
  ... Looking for environment variable 'IFORT_COMPILER21' ...No.
  ... Looking for environment variable 'ONEAPI_ROOT' ...Yes ('C:\Program Files (x86)\Intel\oneAPI\').
  ... Looking for file 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows\Bin\intel64\ifort.exe' ...Yes.
  ... Looking for folder 'C:\Program Files (x86)\Intel\oneAPI\compiler\latest\windows' ...Yes.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Enterprise -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Professional -property installationPath -format value' ...No.
  ... Looking for environment variable 'ProgramFiles(x86)' ...Yes ('C:\Program Files (x86)').
  ... Looking for file 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' ...Yes.
  ... Executing command '"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -version "[16.0,17.0)" -products Microsoft.VisualStudio.Product.Community -property installationPath -format value' ...No.
  Did not find installed compiler 'Intel oneAPI 2021 for Fortran with Microsoft Visual Studio 2019'.
  {Error using command_186d8d9f_e6a7_[41](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:43)[51](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:53)_a6c4_13e14d32dc[69](https://github.com/equipez/setup_mex/actions/runs/3889645833/jobs/6638085089#step:5:71)
  Supported compiler not detected. For options, visit https://www.mathworks.com/support/compilers.
  }
  ERROR: MATLAB error Exit Status: 0x00000001
  exit status 1


Onboard to Dependabot

TODO

[x] Dependent on #3
[x] Onboard to Dependabot
[ ] Add a badge (https://badgen.net/dependabot). This may be dependent on public repositories.

i added the badge but it's not displaying a status. i'm waiting for the next Dependabot run to see if the badge is dependant on some metadata?


Enable flake8-bugbear + adapt existing codebase

In short: Will enable flake8-bugbear that is a flake8 plugin to track even more stuff during code quality checks.
Solve issue https://github.com/huggingface/huggingface_hub/issues/966 (originally posted in https://github.com/huggingface/huggingface_hub/pull/959#issuecomment-1206145019). This PR also include duplicate work from https://github.com/huggingface/huggingface_hub/pull/959.
I also took the chance to group all the repo_name generations in a single utility function in tests.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


chore: golf using filter_upwards

This is presumably not exhaustive, but covers about a hundred instances.
Style opinions (e.g., why a particular change is great/not a good idea) are very welcome; I'm still forming my own.

Thanks for the hint: I pushed a few more golfs, including looking for occurrences of Eventually.{mp,and}.
awaiting-review

Thank you, all fixed. (Sorry for going overboard - I rather wanted you to tell me "this is not better" than the other way. Now I know.)
awaiting-review

This looks good, thanks!
bors merge


Allow customization of TextSpan in EditableText

This would allow to create a descendant with customized appearance.
Example use case: detecting dates in input text, like in recording below. Currently I have a very dirty workaround which tries to paint differently styled text underneath text input. This is not working very well obviously.

Please consider this a proposal. I also thought buildTextSpan could be an extra field on EditableText instead, e.g. textSpanBuilder function, which maybe a bit more user friendly ( no need to even define a descendant).

Any chance someone can take a look at this PR soon? This is a bit of a blocker. The only way to workaround this currently is to copy-paste EditableText entirely with all companion classes.

This is great.
Just one thing (plus the minor tweaks suggested above): can you add a test that verifies that overriding this method works? That way we won't "optimise away" the possibility of doing so.

Thanks for taking a look!
I pushed fixes for inline comments (sorry for styling issues, this file isn't formatted with dart_style so I had to manually adjust things to avoid unrelated changes in the diff).

can you add a test that verifies that overriding this method works?

Sure, will do.

Fixed remaining CS issues and added a test. PTAL.

Thanks! Will land when the tree is green.

Just a friendly reminder (I'm waiting on this to land before I can upgrade Flutter again).

Thanks for the reminder!

...and the contribution, of course!


Phantom ringtone

Just wondering if anyone has experienced this, wasn't able to make it very far with support because we can't document the issue.
We use the default ringtone for voice but a custom ringtone from a CloudFront distribution from S3 for chats.  With no evidence of a contact coming in, no activity on the CCP visually or in the logs, the agents will start to hear the chat ringtone.  The audio file itself is 5 seconds long but it will play on a loop until the agent refreshes.  Often times when this happens the agent is even on a custom status and not available for incoming contacts.  I have been told that nothing but refreshing the page will stop the ringing.
Has anyone experienced this?  Any ideas on finding something in the logs about it?

We are facing same issue of chat ringtone playback failure


Inference

How to implement inference?

th infer_example.lua?

Hi @bernard24 , should we be using 'plants_convlstm.model' in line 34 of infer_example.lua (x = model:forward(input))? I'm getting this error when I try to use it or 'plants_pre_lstm.model':
unknown Torch class <torch.CudaTensor>
The variable 'model' doesn't seem to be defined in this particular inference script I assume so that users can pick whichever model they please.

Hi @bernard24 & @xjoshramos , I have added some missing modules, require 'cunn' and 'cudnn', which has fixed the above mentioned error. However, while I'm able to torch.load() either 'plants_convlstm.model' or 'plants_pre_lstm.model' and able to print their contents (ie, they are not nil) they do not respond to the forward() command. Is there another way I have to read in a model?
I have opened a new issue addressing this.


(122) Finish ingest of files - Frontend Changes

Task status needs to reflect what is happening. So, when file upload begins, change status to in_progress.
Poll API to check status of ingest/validation
If all submission entries have status of validated, then show a simple message to the user
If more than one submission entry have status of errored then show a simple message that there are errors

@leeky this is ready for a second look!


fix(ui): Reference secrets in EnvVars. Fixes #3973

Checklist:

[X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[X] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] My organization is added to USERS.md.
[ ] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Bump! This is draft. Close or continue?

@alexec I'm continuing, sorry it is taking me a while. I've managed to add the Tooltip too!
I'm going to need guidance in regards to adding tests, can't find where the UI tests are nor how to run them.

@aletepe this looks fine to me. We do not have tests for UI code. Is this ready for review?

@alexec in that case, yes it is! I'm moving the PR to Ready for review.
The build step CI / UI Ensure nothing changed is failing though (because the UI has changed), and I'm not sure how to address it.

Run yarn lint to fix the UI.

That did fix the issue, though there are now tests failing (TestCleanFieldsExclude). I have checked and they are failing in master too.

Back-ported to v2.12.0-rc5


SCons fails to handle .ll files correctly on Mac OS X

This issue was originally created at: 2007-05-24 08:45:16.
This issue was reported by: themiwi.
themiwi said at 2007-05-24 08:45:16

When trying to build a C++ file from a lex file (.ll suffix) SCons fails to:

either call flex++
or add -+ to the command line options

on Mac OS X which causes flex to create C instead of C++ output.
I do not know whether this issue also applies to other platforms, as I Mac OS X
is the only one available at the moment.

gregnoel said at 2008-06-09 17:26:21

Bug party triage.

gregnoel said at 2008-12-26 13:30:38

Adjust triage of issues.

garyo said at 2012-09-01 10:04:01

de-assigning all tickets assigned to Greg Noel (no longer working on SCons)

Fixed in: 0.96.D535 according git history.


add EMBEDDED_IN_VM compilation flag to remove debugging and signal handling

I am using pigpio by embedding it in the Erlang VM in Elixir. The current behavior does not allow clean integration because:

It overrides the signal handlers set by the virtual machine
Outputs on stderr

I added a compilation flag to modify this behavior, -DEMBEDDED_IN_VM

I've no objection in principle.  I need to check for conflicts with my work in progress version which is not maintained by git.


Removing path and fs as dependencies.

Is there any special reason for using npm's path and fs modules rather than default ones node provides?
path
fs
can be removed, so that dooboo-cli use native modules node provides.

Again good point. I was willing to ensure that they are installed correctly as discussed in issue. However, if you are confident that those are not needed we can get that away!

#5

Moreover, path & fs modules currently installed are out of date(almost 3~4 yrs). Way better use default  modules node provides

Just released 1.2.1 with this update. Let's see how it goes.
Thanks for the PR. The first one to contribute to dooboo-cli!


Vim9: should we disallow a space after :g ?

It is allowed for :g to be followed by a space.  This seems inconsistent in legacy, and can give unexpected results in Vim9:
In legacy:
eval ['aaa', 'bbb']->repeat(3)->setline(1)
g x^bxd

Notice that all the bbb lines have been removed.  It means that:

x was used as a delimiter
Vim had no issue with us separating :g from its pattern with a space

1. is wrong.  Vim should not have used x as a delimiter, because it's an alphanumeric character.  This is documented at :h pattern-delimiter:

pattern-delimiter E146
Instead of the '/' which surrounds the pattern and replacement string, you
can use any other single-byte character, but not an alphanumeric character,
'', '"' or '|'.  This is useful if you want to include a '/' in the search
pattern or replacement string.  Example: >
:s+/+//+

IMO, that's a bug, but that's not the point of this issue.  This issue is about 2..  It's inconsistent with :s:
call setline(1, ['aaa', 'bbb']->repeat(3))
%s x^bxrepx

E146: Regular expressions can't be delimited by letters

Notice that this time, Vim didn't skip over the space.  And it didn't accept the space as a delimiter.  This is correct, and :g should probably behave in the same way.  I can't find anything at :h :g which documents that we can write a space after :g.
And here is another issue caused by 2.:
vim9script
g - a - p

Pattern not found:  a

Here, g is parsed as a command.  But it could also be read as a variable name at the start of an arithmetic computation.  Although, it's useless to evaluate this expression if we don't do anything with it...
In any case, there would be no such confusion if we disallowed the space (provided that we keep enforcing spaces around binary operators).  The previous snippet would always be interpreted as a computation.  And the next one as a global command:
vim9script
g-a-p

Notice that this time, Vim didn't skip over the space.

Actually, it did skip over the space.  Still, I think it should not (because of 2.; i.e. it helps make the code more readable in Vim9).

Never mind, all the other commands expecting a pattern accept a space between them and the pattern.
I guess the only issue is that we can use an alphanumeric character around a pattern with :g; that should definitely not be allowed.  I'll try to open a separate issue later.

Right, skipping the space is expected, but using an alphabetic character to delimit the pattern is not.
Would anybody rely on the missing check?  That would be unexpected, thus I think we can add this check.


Fixed #27118 -- Made get_or_create()/update_or_create() error for a non-field in defaults.

Specifying an incorrect field in the get_or_create / update_or_create should not fail silently because it is likely a programming error.
For more details, see https://code.djangoproject.com/ticket/27118.
As Tim noted, this is a backward-incompatible change. If a smoother landing of this feature seems like a better option, we could first raise a warning then turn it into an error in a next version.
This solution covers for incorrect defaults and incorrect exact keyword arguments (without LOOKUP_SEP) that would be used for the model creation. It does not cover invalid non-exact lookups such as does_not_exist__icontains.
I would not document this change outside of the changelog as I would have expected Django to tell me if my defaults / fields lookups were incorrect, but it could help some users if an error pops out during a version upgrade. What do you think?

As far as documentation goes, I think a mention in the 1.11 release notes should be sufficient.

Could you add a sentence or two in the backwards-incompatible changes section of docs/releases/1.11.txt? Perhaps similar to 67732a9b183d2e84c85147b04fdf9499f4395ac6, although I'm not sure an example is needed.

I'm not sure if we should try to raise a more explanatory message. For select_related(), the message is something like: django.core.exceptions.FieldError: Invalid field name(s) given in select_related: 'child_1'. Choices are: genus.
I'm concerned that the new traceback here might be confusing:
Traceback (most recent call last):
  File "/home/tim/code/django/django/db/models/options.py", line 616, in get_field
    return self.fields_map[field_name]
KeyError: 'nonexistent'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tim/code/django/tests/get_or_create/tests.py", line 495, in test_get_or_create_with_invalid_defaults
    Thing.objects.get_or_create(name='a', defaults={'nonexistent': 'b'})
  File "/home/tim/code/django/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/home/tim/code/django/django/db/models/query.py", line 468, in get_or_create
    lookup, params = self._extract_model_params(defaults, **kwargs)
  File "/home/tim/code/django/django/db/models/query.py", line 532, in _extract_model_params
    self.model._meta.get_field(param)
  File "/home/tim/code/django/django/db/models/options.py", line 618, in get_field
    raise FieldDoesNotExist("%s has no field named '%s'" % (self.object_name, field_name))
django.core.exceptions.FieldDoesNotExist: Thing has no field named 'nonexistent'

Any opinions?

I agree that the error message should be improved. I've implemented something similar to select_related. The error message would look like:
Invalid field name(s) supplied for Thing: 'nonexistent'. Choices are id, name.

The choices given are almost correct, if we exclude the possibility to specify foreign objects' primary key as in https://github.com/francoisfreitag/django/blob/7a2c27112d1f804f75191e9bf45a96a89318a684/tests/many_to_one/tests.py#L393-L397.
Since specifying an explicit FK is not documented for get_or_create or update_or_create, I chose to display the choices. But we might prefer correctness?

I guess it could be nice to list the choices, but probably not as critical since the list of model fields is usually easy to lookup. In the case of select_related(), figuring out model relations is trickier. If the list of choices isn't correct, we'll likely eventually get a bug report about that.

Looking good. A few cosmetic edits: http://dpaste.com/11HX2G6
How about a test for the case of multiple incorrect field names?

merged in a5e13a0b926156f7885a0f1d8b300221f74601fc, thanks!


Iframe drag&drop issue

In our front-end, we are now having a function that drag&drop an iframe and with useSortable for it. This function works fine previously, however since this week, the drag turns to be very laggy and not able to drop.
To provide more context, the drag&drop is still working for other html tag but only not working for iframe. We haven't update our code/packages/dependency, and the functionality suddenly not working on Chrome, but still working on other browsers(FireFox & Safari). We just started seeing this impact from Mar 25th, but it may be safe to assume this impact started no earlier than one week ago (Mar 18th).
We tried to downgrade chrome version but have reproduced in older versions still. Is this a known issue or have anyone encounter this before?

Getting the same problem

same problem

Have the same problem.
@MIAOYANZ have you found a solution?  thanks

@paulm17, How did you solve scrolling in iframe?

@dvorakdominik I don't have a problem with scrolling in iframe

@paulm17
I mean when the iframe is larger than the viewport height and you need to drag the element inside.
If I set pointer-events: none; then scrolling in iframe doesn't work. But when I have pointer-events: all; drag and drop is unusable.


Patch dbutils.notebook.entry_point... to return current local notebook path from env var

Changes

Users are using dbutils.notebook.entry_point.getDbutils().notebook().getContext().notebookPath().get() to get the current notebook path in notebooks (referring https://stackoverflow.com/questions/53523560/databricks-how-do-i-get-path-of-current-notebook).
This does not work from our current dbutils proxy. This PR patches this to read from a DATABRICKS_SOURCE_FILE env var when using local dbutils.

Proposal

Allow users to add their own patches to make is easier for users using dbutils from sdk to workaround such issues in the future.

Tests

Unit tests

[x] make test run locally
[ ] make fmt applied
[x] relevant integration tests applied

Codecov Report
Attention: Patch coverage is 87.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.77%. Comparing base (a1055d1) to head (5e9cefb).
 Consider uploading reports for the commit 69bccc1 to get more accurate results

Files
Patch %
Lines

databricks/sdk/dbutils.py
87.50%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   57.89%   57.77%   -0.12%
==========================================
  Files          44       46       +2
  Lines       27956    32199    +4243
==========================================
+ Hits        16185    18604    +2419
- Misses      11771    13595    +1824

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Example12 featuring TestEm3-like transport in arbitrary geometry imported from GDML.

The example implements TestEm3-like workflow, but the geometry can be taken from an arbitrary GDML file.

The geometry is first read by the Geant4 parser and the G4HepEm state is initialized based on this
The geometry is then imported via vecgeom::vgdml and the geometry hierarchy is visited in parallel with the Geant4 one to match G4LogicalVolume<->vecgeom::LogicalVolume and build the LUT (logical volume index) -> (G4HepEm material-cut couple index)
GPU data is initialized and showering/scoring is done as in TestEm3
Scoring is done per placed volume, no sensitivity selection

I tested this with cms2018.gdml, it works and gives reasonable (at first glance) results (the energy deposit per primary equal to the primary energy) when shooting electrons of 10 GeV perpendicular to the beam axis.

@hahnjo the test is now passing

Renamed to Example12 as discussed, since the example is not CMS-dependent.

Thanks @hahnjo this should be ready now


No matching HTML_Escape error

I'm getting an error on the following code segment DataFrame(ODBC.query(dsn, "select Sex from persons WHERE persons.PersonId = 2")) and other similar queries where the result contains a string. The error message is:
MethodError: html_escape has no method matching html_escape(::UTF16String)
in writemime at C:\Users\Adam.julia\v0.4\DataFrames\src\abstractdataframe\io.jl:184
in sprint at iostream.jl:206
in display_dict at C:\Users\Adam.julia\v0.4\IJulia\src\execute_request.jl:39
When I remove the DataFrame conversion or if the result is of a different data type, I don't have any issues. Oddly enough, this was working perfectly fine just an hour ago. I wasn't having any trouble with strings. I spent some time trying to install node-julia, and then came back to this, where I encountered this error for the first time. Has anyone seen this before? Thanks!

@andreasnoack Looks like you introduced this bug by replacing html_escape(cell::AbstractString) with html_escape(cell::String). I don't think this is needed since that function merely calls replace on the string. You seem to have done that in a lot of places, not sure why.

That was not intentional.

Fixed by #964


Changed memory layout in TrackedObjectKinematics compared to autoware_auto_perception_msgs version

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
With the introduction of the autoware_perception_msgs, the memory layout of the TrackedObjectKinematics message was changed compared to the old autoware_auto_perception_msgs version, because the orientation_availability property was moved below the various geometry_msgs. Due to this changed memory layout, simply renaming the message type from autoware_auto_perception_msgs to autoware_perception_msgs, e.g., by using the autoware_msg_bag_converter without explicitly setting each property during conversion results in broken objects.
Expected behavior
I expected the memory layout to be the same as before to maintain compatibility with recorded rosbags and the autoware_msgs_bag_converter.
Actual behavior
The values of the converted autoware_perception_msgs/TrackedObjectKinematics message (seen on the left-hand side) are shifted compared to the original autoware_auto_perception_msgs/TrackedObjectKinematics (on the right-hand side)

Steps to reproduce

ros2 topic echo of a topic with autoware_auto_perception_msgs/TrackedObjects in a bag
Convert bag with the autoware_msg_bag_converter
ros2 topic echo of the converted topic with autoware_perception_msgs/TrackedObjects
Compare contents of the output

Versions
No response
Possible causes
If the orientation_availability property was placed directly behind pose_with_covariance as before, conversion of bags with TrackedObjects with the autoware_msg_bag_converter would still be possible.
Additional context
No response

Closing this issue, because this change would break compatibility with bags that contain autoware_perception_msgs/TrackedObjects.


Trigger render when Animated.Event stream pauses

Summary:
This PR is doing essentially the same thing as https://github.com/facebook/react-native/pull/37836, but for animated events instead of the animations.
The two kind of sketchy things I did are:

To have access to the value of native Animated.Value I needed to add a no-op listener to it.
In order to avoid re-renders on every frame, which defeats the purpose of using the native driver, I arbitrarily chose to delay the render by 64 milliseconds on every event. This seems to work okay, but I'm not sure if it's the best solution.

Fixes https://github.com/facebook/react-native/issues/36504
Changelog:
[GENERAL] [FIXED] - When a stream of Animated.Event pauses, trigger re-render to update Pressability responder regions
Test Plan:
Tested on the reproducer from the issue

Hello @j-piasecki! I started looking into this again.
The approach works, but as you mentioned in your PR, there are a couple of not-so-clean parts:

the need to add a dummy listener
the need to use a timer.

In general we would not like to use this approach, as it triggers to many rerenders of the trees, basically one every 64 sec when events are involved.
One solution we were discussing internally was to have the source of the animation (e.g. a scroll view) to emit an event when the animation is done. [0]
Then , the NativeAnimatedTM can emit the event to JS [1] to retrigger the rerender. In that way we only need 1 single rerender for each user driven animation
We only have a finite number of user driven animations in Core: ScrollView scrolls and PanResponders, so we can handle them explicitly.
This approach should solve point 2.
I discovered that without the dummy listener, the approach above does not seem to work, but I can't figure out why.
This is also a part of the codebase I'm not really familiar with and as someone who spent time working on this already, I wanted to ask you:

What do you think about the approach?
Could you find why/where the dummy listener is used?

In general we would not like to use this approach, as it triggers to many rerenders of the trees, basically one every 64 sec when events are involved.

That's understandable, maybe 64 ms was too low of a value to actually debounce this.

What do you think about the approach?

I thought about something vaguely similar to that initially but decided not to go in that direction since it involved adding much more code than the JS-based solution I ended up with.
If the size is not a problem, then it's definitely a better approach than what I've done in this PR as it would require, as you mentioned, a single render to synchronize the native state with the shadow tree.

Could you find why/where the dummy listener is used?

I used a dummy listener as without any JS listener the animated values using the native driver don't synchronize the value with the native side (i.e. calling getValue on them will return the initial value). I guess _userDrivenAnimationEndedEvents could be extended to also update the values associated with them to circumvent this.


Add TPoses to be used with Mecanim animations

Add Mecanim avatar configuration for human models.
Provide Mecanim compatible TPose assets.

@mysticfall what version of unity did you use to configure the avatar and extract the tpose?

I think it was 2017.1.x and now I'm using 2017.3b.

MysticFall - can you include the old tpose assets also (rename them with "_legacy" at the end perhaps?

@Jaimi I didn't replace or change anything that I thought might cause a compatibility problem (but please check if it's really the case before merging).
The T-pose files (with _Mecanim suffix) are new additions and I didn't changed the race data to use these files instead of the old ones. Do you mean I can change them also, as long as I keep the old T-pose files?
And the changed meta files of FBX models contain avatar configuration settings for the new T-poses, which I believe was absent previously, so I didn't think it would cause problems for other people.

Oh, OK - sorry about that, it's hard to tell sometimes with the way the pull request works. No need to change anything!

Please don't worry. I'm just glad that I didn't screw up something :smile:

@Jaimi @mysticfall So we should not make the new one default then? Then what is the use of including this,i doubt ppl will notice and use it if its not default?

It definitely has value to include it (I'll be using it myself). But not
sure about making it the default, because it has the potential to cause
people to re-adjust their animations again.
On Tue, Oct 31, 2017 at 12:24 PM, Victor Hagsand<EMAIL_ADDRESS>wrote:

@Jaimi https://github.com/jaimi @mysticfall
https://github.com/mysticfall So we should not make the new one default
then? Then what is the use of including this,i doubt ppl will notice and
use it if its not default?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/umasteeringgroup/UMA/pull/53#issuecomment-340838304,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK564HfBHHodyH6l5l8nQWFJvF0YLiZzks5sx1fegaJpZM4P5h_N
.

Hmm, ok. I just assume that 99% of the users have no idea thet you can even change t-pose file. Maybe we can switch this with 3.0 then.


Analytics (update): update add_gene event for explorer

Overview
Tool: Explorer

Feature (Optional):

Description: Right now, the ADD_GENE_AND events do not capture the use case of a user creating a gene set and then adding a gene. We would like to include this as part of the explorer engagement metric
Updates needed
ADD_GENE_AND events

Current: User adds a gene to quick add gene section
Requested change: Include when a user creating a gene set and then adds a gene

People to cc
PM: @signechambers1
DS: @ainfeld
Privacy policy: https://cellxgene.cziscience.com/privacy

Closing! Amanda confirmed that this is not needed anymore!


PLAT-4947 : Fix to get email address

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Codecov Report

Merging #178 into dev will decrease coverage by 0.64%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##              dev     #178      +/-   ##
==========================================
- Coverage   89.54%   88.89%   -0.65%
==========================================
  Files         144      175      +31
  Lines        2726     3530     +804
  Branches      261      340      +79
==========================================
+ Hits         2441     3138     +697
- Misses        221      291      +70
- Partials       64      101      +37

Impacted Files
Coverage Δ

...rovisioning/service/CompanyCertificateService.java
81.33% <90%> (ø)

...ion/provisioning/client/model/AppStoreBuilder.java
90.69% <0%> (ø)

...n/provisioning/IntegrationProvisioningService.java
79.81% <0%> (ø)

...ioning/exception/AppRepositoryClientException.java
100% <0%> (ø)

...on/provisioning/service/AuthenticationService.java
96% <0%> (ø)

...ion/provisioning/client/model/AppStoreWrapper.java
100% <0%> (ø)

...isioning/client/model/AppStoreSettingsWrapper.java
100% <0%> (ø)

...ation/provisioning/service/UserKeyPairService.java
97.77% <0%> (ø)

...ning/service/ConfigurationProvisioningService.java
93.93% <0%> (ø)

...ng/exception/ApplicationProvisioningException.java
100% <0%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d51cf...20fa6a7. Read the comment docs.


Adds Immerse to Showcase

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.
Adds Immerse to showcase - a React Native WebRTC app for daily language practice.

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

A big overhaul to the showcase page is happening with https://github.com/facebook/react-native/pull/8263/ --- so I want to land that first and then this will have to be rebased on top of that.

cc @lacker

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Verbling seems like a good showcase candidate. We need a link to some sort of useful news or something though. Maybe just https://www.crunchbase.com/organization/verbling#/entity - did you guys do any PR around the launch of Immerse?

@markthom-as #8263 has landed. So this pull request can be rebased and updated on top of that.

@markthom-as do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes.

@markthom-as I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment asks a question. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to add Immerse to the showcase.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain thumbmunkeys.com has exceeded the max emails per hour (70/60 (116%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from filter03.reliabledns.org ([<IP_ADDRESS>]:42644)
by en02-ams.stablehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1biJVe-003LGn-FR
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 10:58:16 +0000
Received: from o6.sgmail.github.com ([<IP_ADDRESS>])
by filter03.reliabledns.org with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128)
(Exim 4.85)
(envelope-from<EMAIL_ADDRESS>id 1biJVa-0000FM-Pk
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 03:58:14 -0700
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=LWM+5b88Kq6joxyPA4uJPpsY3+k=; b=Z42Jdr1R6Pf/Xa+B
drSgBvXlbUynaHufv0wRCKFOhtLDzhGK1vk4O8gwmiF0HGryZJ5M5fscBPEEzZt6
gpGBKIdHCP03zDKk2E52B6kkN4Z3Y4v9mfQ4iusqVJB9jaYpCMy5JQHKYT83k6bd
OaUmllMPKECiAUPu3uiLQXLWBMs=
Received: by filter0993p1mdw1.sendgrid.net with SMTP id filter0993p1mdw1.10052.57D295C1E
2016-09-09 10:58:09.109071843 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id tK9ggrcdSkSonijO70xBkQ
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 10:58:08.980 +0000 (UTC)
Date: Fri, 09 Sep 2016 03:58:08 -0700
From: Martin Konicek<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [facebook/react-native] Adds Immerse to Showcase (#8284)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_57d295c0cca2b_18053f9d0bd1f2bc21617";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mkonicek
X-GitHub-Recipient: bunnyboy1
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARoNg4ID29GYAWVtb0iMGrCHvYuO0l7Rks5qoTvAgaJpZM4I7DhE
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: wxILpmbMy+DMOe8s3uTnYJqhMhAtpIHhpRnO60rP0k9kN9xGu14YFab2XVFdY8L+4rzvF52jJ9FyVm
TUfk/HePntTQUyAoo01tC2w0g0XRUe0wl+zVuYGCmZj7fwUSVBOVi2iDYiieEwsLQIzGgk+FfEnFnS
KbW8idCYTzkUTSQv/s07y+Nx0A1LdihbtJPTj3GkTW5HLENSdh/DqqP8MaJjBMq1BOZr9+h+j84r+Q
k=
Received-SPF: pass (filter03.reliabledns.org: domain of sgmail.github.com designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS><EMAIL_ADDRESS>helo=o6.sgmail.github.com;
X-SPF-Result: filter03.reliabledns.org: domain of sgmail.github.com designates <IP_ADDRESS> as permitted sender
X-Sender-Warning: sgmail.github.com has no MX records
Authentication-Results: filter03.reliabledns.org; dmarc=pass header.from=github.com
X-Filter-ID: s0sct1PQhAABKnZB5plbIT1RbOwy06L9REYyr9AwRQTwqQ7CW4gxUeeyoz1oed5P/SEnTgrA37IX
TZjA4tFfC9o7/kuvJ3wuZWRdcwKwe1+/dW/xGlBq3/UmIKUCpDxGneIVwSf+lCa+FY3nagRj3wdr
IZ+D/FAg6XyPDmfkLA7rcxAODBZO2BOkcGk4nUtahhgrW7I+ZXG20/0X1caNLFarIGSMLt5vX9V9
rVXE/wBcR6vcRlDk/cSBa4A2VcTnkxlSZxHxTWgJwgGAdAfYxweCqUHNpGSpYKgbbQ0hVpRxm940
ctLUITjZf6gf+2Fizz1bCpnNHITHKyl2nl6wGRK0O98URW+2T2uZExjyNcO8Ksk+aedMfNWSnJsw
rtlNCErxkxEH9mfa7Qdifyqj/h5hjsTbVRmo7nFMDV0g9As05guNsa2Nl1J/2pvGKzma3QvsX4RE
TS3JSGA7o3YcxlrAjbKXivi44/S5bCQthzgaVYuvXXjnIQ9UbG2xl1SQsFdeAnz4j2Jd9hHlkVeQ
3ao/9L1Mqcpxtd0+tyg8J/Iy7Y119RzUL9F8dpacW6kaCrY+kJNJ92N3RoBtBQoJKxmiZP9O0EDT
2pu/KzzTvSwSPwGIuc1yringzpgD134Pt4tUiGmSGoKroysefhIxuDEvuGslKTrRIXcXpFg5ivY=
X-Report-Abuse-To<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; spf=pass<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; dkim=pass header.i=github.com
X-SpamExperts-Class: ham
X-SpamExperts-Evidence: Combined (0.00)
X-Recommended-Action: accept
X-Spam-Status: No, score=1.1
X-Spam-Score: 11
X-Spam-Bar: +
X-Ham-Report: Spam detection software, running on the system "en02-ams.stablehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  @markthom-as I'm going through all pull requests and noticed
this one hasn't been updated in a while and the last comment asks a question.
I'll close this pull request so it doesn't stay open indefinitely but please
send a new one if you want to add Immerse to the showcase. [...]
Content analysis details:   (1.1 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
trust
[<IP_ADDRESS> listed in list.dnswl.org]
1.5 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
1.6 HTML_IMAGE_ONLY_24     BODY: HTML: images with 2000-2400 bytes of words
0.0 HTML_MESSAGE           BODY: HTML included in message
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_57d295c0cca2b_18053f9d0bd1f2bc21617
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
@markthom-as I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment asks a question. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to add Immerse to the showcase.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/pull/8284#issuecomment-245882660
----==_mimepart_57d295c0cca2b_18053f9d0bd1f2bc21617
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
@markt=
hom-as I'm going through all pull requests and noticed this one hasn't =
been updated in a while and the last comment asks a question. I'll close th=
is pull request so it doesn't stay open indefinitely but please send a new =
one if you want to add Immerse to the showcase.
&mda=
sh;You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, view it on GitHub, or mute the thread.

=
----==_mimepart_57d295c0cca2b_18053f9d0bd1f2bc21617--

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain thumbmunkeys.com has exceeded the max emails per hour (71/60 (118%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from filter03.reliabledns.org ([<IP_ADDRESS>]:42648)
by en02-ams.stablehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1biJVk-003LIa-2v
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 10:58:25 +0000
Received: from o5.sgmail.github.com ([<IP_ADDRESS>])
by filter03.reliabledns.org with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128)
(Exim 4.85)
(envelope-from<EMAIL_ADDRESS>id 1biJVi-0000Fu-RN
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 03:58:20 -0700
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=adn9+nFqAV/B0hubtOdttfoi6TY=; b=a5VTTvU9kHpLa6Ow
zTryjtmyxy1u/Bn59en3Rp3SpvirURy1NY5t8q6rVkhuba5Q2ATSlSnVQ9yuPoq2
T1d9BeHSh/gYpidWQ3ADNZYVmZ3oGpq11zmHFFHm6gT28cEdK2oC1fei1WiWXnkz
YE2T/AJcXWqi3DJ/0JlX5p0bNPo=
Received: by filter0977p1mdw1.sendgrid.net with SMTP id filter0977p1mdw1.10927.57D295CA11
2016-09-09 10:58:18.310916519 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [<IP_ADDRESS>])
by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id GLTtikFeTHOO7emAfOxOHQ
for<EMAIL_ADDRESS>Fri, 09 Sep 2016 10:58:18.328 +0000 (UTC)
Date: Fri, 09 Sep 2016 03:58:18 -0700
From: Martin Konicek<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [facebook/react-native] Adds Immerse to Showcase (#8284)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_57d295ca26d97_10553ff7d18092c0290066";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mkonicek
X-GitHub-Recipient: bunnyboy1
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARoNgynU97zGp5VD_GxpxoGdu_vnJmHKks5qoTvKgaJpZM4I7DhE
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-SG-EID: wxILpmbMy+DMOe8s3uTnYJqhMhAtpIHhpRnO60rP0k9erw4fGEeMLx2J26RThJeWqe6Sm2lUZZ/Ob3
fFBaD9mJcXm2X6XJxPPr3fdR7CGizqBTFhiMG7+LKWwvgI+w57HWpdJYWBe26ZDSVhGvR41ggNFXmb
cRQDHe8awKvut1Aji5nB9REgxWVXXQvk4lboRmLPQNacyYLaMpdAJzBmQXQ2/yZkk6yQqj6gjTVIYt
A=
Received-SPF: pass (filter03.reliabledns.org: domain of sgmail.github.com designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS><EMAIL_ADDRESS>helo=o5.sgmail.github.com;
X-SPF-Result: filter03.reliabledns.org: domain of sgmail.github.com designates <IP_ADDRESS> as permitted sender
X-Sender-Warning: sgmail.github.com has no MX records
Authentication-Results: filter03.reliabledns.org; dmarc=pass header.from=github.com
X-Filter-ID: s0sct1PQhAABKnZB5plbIT1RbOwy06L9REYyr9AwRQTwqQ7CW4gxUeeyoz1oed5P/SEnTgrA37IX
TZjA4tFfC9o7/kuvJ3wuZWRdcwKwe1+/dW/xGlBq3/UmIKUCpDxGneIVwSf+lCa+FY3nagRj3wdr
IZ+D/FAg6XyPDmfkLA7rcxAODBZO2BOkcGk4nUtaK+NKmfKT1VzfmhD1tR7fxVarIGSMLt5vX9V9
rVXE/wBcR6vcRlDk/cSBa4A2VcTnkxlSZxHxTWgJwgGAdAfYx53FhV76KbMsOYR+FTXGtytdrGGC
2LxSkr2RZ7YVzBA/SmEIS4GON+6FOG36iMWh1MkJ+S1xR7tBHCAvxXNNyU893SsS4aMXJmiJ2G0e
b5ahm8p6HlShAEYnwZBavOYADGb0g2n0QCK0NUarjxzvKHXDqcigOvSxdRnthmhn8Zn6s8w/N/eB
P5qFKj1/fsvit0UWb7Au9+OsDspaYXORD9DExXy0aVT1HuhJQmP8nOV/gcSXPi64HW9TLHbE1xGc
sIqosGRVic0wJZbsnU20WkB8LSJSyBhtnWbngGtasJkXBf0jdZtXXwRMZ/pKak7GRV+Sy3brvYFg
uJ068d7ZjkeRv8Gjvtc3eeZ2pvOmIPvav2ToL5w5nDAUe12FhqWGsTEvuGslKTrRIXcXpFg5ivY=
X-Report-Abuse-To<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; spf=pass<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; dkim=pass header.i=github.com
X-SpamExperts-Class: ham
X-SpamExperts-Evidence: Combined (0.00)
X-Recommended-Action: accept
X-Spam-Status: No, score=1.1
X-Spam-Score: 11
X-Spam-Bar: +
X-Ham-Report: Spam detection software, running on the system "en02-ams.stablehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #8284. -- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/facebook/react-native/pull/8284#event-783763961
[...]
Content analysis details:   (1.1 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
trust
[<IP_ADDRESS> listed in list.dnswl.org]
1.5 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
1.6 HTML_IMAGE_ONLY_24     BODY: HTML: images with 2000-2400 bytes of words
0.0 HTML_MESSAGE           BODY: HTML included in message
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_57d295ca26d97_10553ff7d18092c0290066
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #8284.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/pull/8284#event-783763961
----==_mimepart_57d295ca26d97_10553ff7d18092c0290066
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #8284.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_57d295ca26d97_10553ff7d18092c0290066--


Prevent registering of profiler arguments with a wrong dest name

Description
In order to be passed to the relevant profiler, the dest of profiler-specific arguments must be prefixed with the profiler's name. This PR asserts they're named correctly.
Motivation and Context
I tried to add an argument without knowing this and spent some good amount of time debugging that could've been saved with this assert.
How Has This Been Tested?
Just ran gProfiler and saw that this assert isn't triggered, and then ran it again with a wrong arg dest.
Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have updated the relevant documentation.
[ ] I have added tests for new logic.

Make sure that all the current profilers are not broken by this change, especially the node profiler can be problematic.

@alonbentamar nodejs doesn't have it's own profiler and IIUC doesn't use the interface this PR modifies altogether. Am I missing something?

Make sure that all the current profilers are not broken by this change, especially the node profiler can be problematic.

@alonbentamar nodejs doesn't have its own profiler and IIUC doesn't use the interface this PR modifies altogether. Am I missing something?

Exactly, I just remembered it as an edge case that you should make sure is not broken


Added more buffer manipulations

Import/export buffers as hex string, binary strings, or boolean arrays.
Create buffer from UInt value up to Number.MAX_SAFE_INTEGER.
Added bitwise shifting and resizing.
Create a subbuffer from the current buffer.
Read numeric values from any bit offset and width of bits. Bits selection is resized before being read so you can get the value of bits that are a non standard number of bytes (including incomplete bytes) from across byte boundaries.
Mocha no longer seems to be compatible with test.js. Added a test() function to test.js to mocha is no needed to run tests.

Wow, that is a lot of work, thanks!
I have not yet looked at everything and it will take me a bit to go through completly.
From the first impression it seems that some stuff you implemented could already be archived by using the Buffer api:

Import/Export hex strings:

	var b = new BitBuffer(8, Buffer("0a", "hex"))
	console.log(b.buffer.toString("hex"))

Create a subbuffer:

	var b = new BitBuffer(32, Buffer("aa55ff00", "hex"))
	b.buffer.slice(1,3)

Other parts could be made more similar to the Buffer api:

instead of getValue what do you think of implementing the range of:

readDoubleBE(offset[, noAssert])
readDoubleLE(offset[, noAssert])
readFloatBE(offset[, noAssert])
readFloatLE(offset[, noAssert])
readInt8(offset[, noAssert])
readInt16BE(offset[, noAssert])
readInt16LE(offset[, noAssert])
readInt32BE(offset[, noAssert])
readInt32LE(offset[, noAssert])
readIntBE(offset, byteLength[, noAssert])
readIntLE(offset, byteLength[, noAssert])
readUInt8(offset[, noAssert])
readUInt16BE(offset[, noAssert])
readUInt16LE(offset[, noAssert])
readUInt32BE(offset[, noAssert])
readUInt32LE(offset[, noAssert])
readUIntBE(offset, byteLength[, noAssert])
readUIntLE(offset, byteLength[, noAssert])

functions where offset would would be the bit-offset to allow unaligned access?
Corresponding write* functions might also be interesting.
Further notes:

this._getTypedValue: I don't think it is correct to make this decision here based on the current OS. This should be left to the consumer of BitBuffer to decide. If parsing a file format or data from the network the byte order might be different than the current system.

toNumber: I think it would be better to be explicit and have the user call one of the read(U)IntNNXE functions or .buffer.toString("hex")

fromUInt is actually fromNumber. If we implement the write* functions this would not be needed as the write* would be more correct.

I know this is controversial, but please try to use tabs instead of spaces and no semicolons if not needed so the style is consistent with what was already there ;-)

To make this all easier to review and integrate maybe consider splitting this up into different issues:

to/from BitArray and BinaryString
non-aligned read (and maybe write) functions
resize
shifts

Thanks!
PS: are you using the new functionality in anything public? Might be interesting to have a look at the use-case.

re subbuffer: oh I see, your code actually also allows unaligned slices. How about renaming that to .slice([start[, end]]) where start and end are bit offsets?

Hey,
I wrote this as part of a

Ha! Apparently I have no idea how to use the GitHub interface. I didn't mean to send that last comment...
Anyway....

Import/Export hex strings:

var b = new BitBuffer(8, Buffer("0a", "hex"))
console.log(b.buffer.toString("hex"))

That works fine as long as you are using a whole number of bytes. However if you wanted to use an odd number of nybbles in your hex string:
var b = new BitBuffer(16, Buffer("eb9", "hex"))
TypeError: Invalid hex string

Also using this method means that you have to keep track of the number of bits in your hex string and if you get it wrong (but to be fair this could be fixed in the constructor for BitBuffer):
var b = new BitBuffer(8, Buffer("eb90", "hex"))
b.buffer.toString("hex") //'00'

Create a subbuffer:

    var b = new BitBuffer(32, Buffer("aa55ff00", "hex"))
    b.buffer.slice(1,3)

As you already mentioned subbuffer does not require byte alignment. The reason I chose not to call it slice() is that Buffer#slice uses the original Buffer object and the new Buffer use the same underlying chunks of memory. So if you make a changed to your slice, you make a change to your original Buffer.
This is incompatible when you throw out byte alignment.  For example if you have this buffer:
0b111111110010 (which is stored in memory as 0b0000111111110010) and you take a "slice" (keeping the same underlying memory) of bits 0 through 3 you would get 0b0010 (stored as 0b00000010) it would clobber the original buffer by leaving the original memory chunk looking something like 0b0000111100000010. Obviously this isn't actually what happens because the new memory is allocated to the subbuffer. So, I wanted to avoid any implication that the two BitBuffers shared the same memory as you would normally have with a Buffer#slice. Instead, I chose the name subbuffer and used the String#substring API.

instead of getValue what do you think of implementing the range of...:
I think there is some value is keeping a getValue function. When unpacking a bunch of different types of data from arbitrary bit offsets, its nice to have one function which you can just give the type (uint, int, float), the offset, and the width. That being said, I do think you are right that it would be a good idea to duplicate that area of the Buffer API. How would you feel about keeping getValue and replacing _getTypedValue with an object that points at the duplicated read[type][value][endianness] functions?

On endianness:
Because we are taking an arbitrary number of bits and forcing them to live in a complete number of bytes I was originally thinking that I needed to force endianness to avoid ambiguity about where the padding would happen. However, after looking at it a second time, I think you're right and it should just be left to the user (with the OS's endianness being the default for getValue).
on toNumber:
This is to create a Javascript Number object, not just an arbitrary number as the English language may lead you to believe. More specifically, the result of 'toNumber' would be the same as what you would get if you typed a hex string into the JavaScript console. That is to say, it assumes that your bit buffer is a two's complement binary number. This is espcially helpfull if you want to read an int that is between 32 and 53 bits wide since the readInt functions to out at 32 bits. Maybe it would be a better to just add readUInt53 and readInt53 functions?
on fromUInt:
Yep, you're right. That will read a signed number wont it? I agree about implementing the write functions. fromUInt was something I tacked on in a few minutes before submitting the pull request and didn't really think it though I guess.
on formatting:
Yeah, I meant to keep tabs, but my editor disagreed and I forgot to change it back. And yes, I will begrudgingly remove the semicolons.
I will try to break this up into chunks and resubmit some pull requests.

The project I am using this for is not currently public, but it will be in the near future. Basically it reads data packets that are stored as huge hex strings from a database, selects a few bytes, and reads an int,uint, or float. The values are not byte aligned and they are not the correct bitwidth either. For example, I might select the two bytes 0b1110001101100011 from a hex string and I need to get an int that is 3 bits wide and stored at offset 6. I tried using the regular Buffer object by found myself writing some pretty terrible functions for selecting the correct bits. Then I found your BitBuffer and decided to use it as a starting point and build in some extra functionality.


Windows DPI Settings not getting applied correctly

Describe the bug
Changing the DPI Scaling of a Screen doesn't get applied to the league client.
To Reproduce
Steps to reproduce the behavior:

Go to Display Settings
Change Scaling to 150% or more
Hook League
Start League

Expected behavior
League should be displayed correctly (as it is unhooked)
Screenshots
Hooked: https://cdn.discordapp.com/attachments/542307049745285120/831545180649816074/NVIDIA_Share_21-04-13_17-03-37.webp
Unhooked: https://cdn.discordapp.com/attachments/542307049745285120/831544480246136862/NVIDIA_Share_21-04-13_17-00-51.webp
Desktop (please complete the following information):

Windows 10
League of Legends Patch Version: 11.7
Antivirus (if any): Windows Defender

Additional context

No plugins enabled

Hey!
Thank you for the report, I have successfully reproduced the bug.
I am not entirely sure what is causing it. I have a feeling that the issue lies either within CEF or the client, as Mecha itself doesn't do anything that could trigger this behavior.
I will look more into it.

After reviewing the entirety of the Mecha codebase and finding nothing indicative that could be causing this issue, I will mark this issue as "out of scope" and close it for the time being. I will take a look at it again in future versions, and see what Mecha can do to potentially fix this unwanted behaviour.
A quick search yielded this result, which may be closely related to this issue.


Inconvenient Behavior with Enter Key in Python

This issue has been moved from a ticket on Developer Community.

[severity:It bothers me. A fix would be nice]
When using the Enter key in Python editor, there is inconvenient behavior that differs from C# editor. In Python, pressing Enter adds spaces on a new line, whereas in C#, this does not occur. This creates inconvenience and complicates code editing. I constantly have to manually remove these spaces.
Steps to Reproduce the Issue:

Open a Python editor.
Write code that starts not from the beginning of the line but after a few spaces.
Press the Enter key.
Notice that extra spaces are added on a new line after pressing Enter (they are visible when selecting the entire code).

Watch the attached video for a visual demonstration:

download Video.wmv.zip
or view on Youtube

Expected Behavior:
Pressing Enter should not automatically add spaces on a new line, as observed in the Python editor. The behavior should match that of the C# editor.
Explanation of the Issue:
The problem leads to the following undesirable consequences:

Pressing the backspace key adds spaces to the end of the previous line, which can distort the intended formatting of the code.
The constant appearance and disappearance of spaces create more differences in code versions (Git), leading to frequent code merges and conflicts.
This behavior complicates code editing and readability, making it harder for developers to maintain and collaborate on projects effectively.

Original Comments
Feedback Bot on 5/12/2024, 07:55 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Hi there, thanks for your issue. In Python, indentation is used to define the structure of code blocks, such as loops, conditional statements, and function definitions. Incorrect indentation can lead to syntax errors or alter the logic of your code.
In C#, indentation is not required for the compiler to understand the structure of your code, as it uses curly braces {} to define code blocks.
But that said, you can still disable smart indentation by going to Options -> Text Editor -> Python -> Tabs and turn off the indenting there.


BottomNavBar for only iOS is impossible

Currently it's not possible to generate an iOS app with a bottom nav bar and and Android app without one.
This was the code I tested:
PlatformScaffold(
  appBar: PlatformAppBar(title: PlatformText('TEST', ),),
  ios: (context) => CupertinoPageScaffoldData(
      bottomTabBar: CupertinoTabBar(
      items: <BottomNavigationBarItem>[
          BottomNavigationBarItem(
              title: PlatformText("Feed"),
              icon: Icon(Icons.subject),
           ),
          BottomNavigationBarItem(
              title: PlatformText("Settings"),
              icon: Icon(Icons.settings),
          ),
       ],
  )),
  body: Container(),
);

In this case using PlatformScaffold may not be what you need. It maybe better to use PlatformWidget and use Material and Cupertino widgets directly. This library aims to provide a similar interface between ios and android. Having said that, I notice that perhaps it would be better to separate the PlatformScaffold into a Tabbed and NonTabbed version which I may put up at some stage.

@aqwert that was my next question  of how to do tabbed and you gave me a solution already great!


Update proposal with design details.

How does this look?

It looks good. I've got 2 comments:

The rotation point is used to be called as middle and not the pivot. Have you considered naming pivot point as middle?
There is a Reverse.swift file in the Swift/stdlib/public/core folder. We might need to place mutating reverse functions there

Great points—I've updated the naming (was thinking about the partition algorithm for some reason) and made some other revisions.


too-old setuptools (likely due to too-old virtualenv)

Virtualenv bundles pip, wheel and setuptools. The Python packaging ecosystem is moving quite rapidly at the moment, and the version of virtualenv used to build the docs is sufficiently old that the bundled setuptools cannot handle the new version of mock (which needs setuptools 17.1).
Options:

upgrade your virtualenv to 13.1.0
add a call to pip install -U pip wheel setuptools between making the virtualenv and installing projects

I believe you should be able to specify this in your requirements file also. Which seems like a good idea if you require a specific, newer version. I'll look into upgrading our versions as well though.

Ah, I see, it's the bundled verisons in venv. I will update that.


automated testing

Ahead of my nixpkgs changes merging, I thought I'd try my hand at a script to compare against a "LKG" (last known good) of the platform/board binary.
Some quick thoughts/questions:

Should there be a slight refactor so that something exposes a combination of { image = ...; tow-boot-binary = ....; } so that it's easy to walk to output boards and have the corresponding platform binary inside that we want to test?
Alternatively, it seems like some of the boards are basically just wraps around the builder, indicating maybe that we don't want to have a binary for each board necessarily? (This even applies to rpi4 where I have two board outputs, one with and one without ATF, where there's only a single TB binary to test).

Just stashing some thoughts, curious what you think or have a preference or if I'm overthinking it.

As for slight refactors and such, I expect to make a big refactor and the builder for Tow-Boot will be totally unrecognizable. The main goal is going to make it much easier to configure, and more resilient. As an example I will integrate the configuration validation harness that is now in Mobile NixOS's kernel builder so that we can be more confident that additional configuration options are enabled.
So anything is up for consideration.

I don't follow why you need the binary here. Can you explain? The current expected update path will be to dd the partitions, including for the Raspberry Pi. Editing the filesystem through file copy/move operations may cause more hurt down the line. Though just now I'm thinking that for the dastardly Raspberry Pi family it might not be correct as config.txt would be reset...

Roughly the thought was to restructure outputs so that it's easy to access:

board.image
board.firmwareBinary
(maybe even) board.updateScript to update the eeprom/firmware/etc files

Access to the firmware binary was to be able to script capturing and then checking against "known good" firmware binary hashes. This would allow potentially even automating nixpkgs updates in the majority of cases where the u-boot binary is not changing. (something we discussed a couple weeks back)


Fix log playback GUI display

🦟 Bug fix
Fixes https://github.com/gazebosim/gazebo_test_cases/issues/1640
Alternative to: https://github.com/gazebosim/gz-sim/pull/2590
Summary
Loading the logging playback plugin before SceneBroadcaster prevents playback from being displayed on the GUI.  This order was changed in #2452 which caused the regression.
I haven't had time to delve into why the order matters, but it can easily be verified by running test/worlds/log_playback.sdf with <playback_path> set to the log directory. If the plugin comes before SceneBroadcaster, the playback is not displayed on the GUI.
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Regression test added in https://github.com/gazebosim/gz-sim/pull/2619

The CI failure seems to be flaky and is also present in the target branch https://build.osrfoundation.org/view/gz-ionic/job/gz_sim-ci-gz-sim9-noble-amd64/test_results_analyzer/


Create new closing balance record on statement upload

Creating the balance record on statement upload instead of
download ensures that it is unaffected by the order in which
files are downloaded.

retest this please

retest this please

retest this please


Unable to bundle javascript file built with emscripten

Bug report

What is the current behavior?
After creating a bundle made up of one line importing a emscripten-built javascript file, the client fails to run properly.
The developer console prints the following:
speex.js:40215 Uncaught ReferenceError: util is not defined
    at eval (speex.js:40215:1)
    at eval (speex.js:40339:2)
    at Object../src/speex.js (bundle.js:29:1)
    at __webpack_require__ (bundle.js:63:42)
    at eval (index.js:2:67)
    at Module../src/index.js (bundle.js:19:1)
    at __webpack_require__ (bundle.js:63:42)
    at bundle.js:115:37
    at bundle.js:117:12

If the current behavior is a bug, please provide the steps to reproduce.
I've created a very basic test repository with the code in question here that will create the issue:
https://github.com/grkblood13/webpack-speex

What is the expected behavior?
The developer console in Chrome shouldn't output any errors.

Other relevant information:
webpack version:  5.72.1
Node.js version: v16.4.0
Operating System: Ubuntu 21.10
Additional tools:

regarding builded code it should be not util.xxxx, code should looks like global.util.xxxx. in speex.js code global is this, but in common js modules this is equal to module.exports, so speex.js doesn't work as bundled version. So you have 2 options:

build speex to commonjs and use it as module
or insert speex as script tag and use as external in webpack


Bad request when deleting a non-existing entity

Instead of a 404
$ curlcimi -v -X DELETE -k https://dashboard.mf2c-project.eu/api/service/blabla
*   Trying <IP_ADDRESS>...
* Connected to dashboard.mf2c-project.eu (<IP_ADDRESS>) port 443 (#0)
* found 148 certificates in /etc/ssl/certs/ca-certificates.crt
* found 592 certificates in /etc/ssl/certs
* ALPN, offering http/1.1
* SSL connection using TLS1.2 / ECDHE_RSA_AES_128_GCM_SHA256
*        server certificate verification SKIPPED
*        server certificate status verification SKIPPED
*        common name: TRAEFIK DEFAULT CERT (does not match 'dashboard.mf2c-project.eu')
*        server certificate expiration date OK
*        server certificate activation date OK
*        certificate public key: RSA
*        certificate version: #3
*        subject: CN=TRAEFIK DEFAULT CERT
*        start date: Thu, 11 Apr 2019 14:49:50 GMT
*        expire date: Fri, 10 Apr 2020 14:49:50 GMT
*        issuer: CN=TRAEFIK DEFAULT CERT
*        compression: NULL
* ALPN, server accepted to use http/1.1
> DELETE /api/service/blabla HTTP/1.1
> Host: dashboard.mf2c-project.eu
> User-Agent: curl/7.47.0
> Accept: */*
> slipstream-authn-info: [...]
>
< HTTP/1.1 400 Bad Request
< Content-Length: 199
< Content-Type: application/json
< Date: Fri, 12 Apr 2019 15:20:25 GMT
< Server: Aleph/0.4.4
<
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: No implementation of method: :alter-name of protocol: #'camel-snake-kebab.internals.alter-name/AlterName found for class: nil"
* Connection #0 to host dashboard.mf2c-project.eu left intact
}

@rosogon please shout out if you still have the problem


Bump airflow version

Signed-off-by: Raul Sevilla<EMAIL_ADDRESS>Description
Fixes

Codecov Report

Merging #181 (9f1b08d) into master (d3c4330) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   93.50%   93.50%
=======================================
  Files          24       24
  Lines        1000     1000
=======================================
  Hits          935      935
  Misses         65       65

Flag
Coverage Δ

gha
93.50% <ø> (ø)

python-3.9
93.50% <ø> (ø)

unit
93.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0faa6bf...9f1b08d. Read the comment docs.


Write a Guide for Deploying this static site to Azure

Please name it Azure_Deploy.md
Make and place it inside the Guides/ directory of the master branch
Add Snapshots of the process as and where required
Add Useful Tips section for certain optimizations, bug fixing advice, and site corresponding references

hello
I can do it please assign it to me.

@Ayush2020012016 go ahead

ah here is the commit file  #129


cpu_instrs 1 log does not have LY = 0x90 as the docs suggest

$ ./gameboy-doctor cpu_state.log cpu_instrs 1
============== ERROR ==============

Mismatch in CPU state at line 16509:

MINE:	A:86 F:---- B:FB C:1F D:D0 E:00 H:C7 L:B1 SP:DFF3 PC:C367 PCMEM:FE,90,20,F5
YOURS:	A:90 F:---- B:FB C:1F D:D0 E:00 H:C7 L:B1 SP:DFF3 PC:C367 PCMEM:FE,90,20,F5

The CPU state before this (at line 16508) was:

	A:FF F:00 B:FB C:1F D:D0 E:00 H:C7 L:B1 SP:DFF3 PC:C365 PCMEM:F0,44,FE,90

The last operation executed (in between lines 16508 and 16509) was:

	0xF0 LDH A (a8)

Perhaps the problem is with this opcode, or with your interrupt handling?

The CPU instruction executed is F0 44 = LDH A, (0x44) which should be loading the LY register into A. The docs say to hardcode LY to return 0x90 always but it seems the internal log ("mine") was not generated this way.

I just ran into this exact same problem with mine. Looking at the log file for 1, it seems like LY was not stubbed when generating the file. It would have to be redone.

Good spot and thanks for the bug report. Does https://github.com/robert/gameboy-doctor/commit/04b8858665715cdf9412e00d4a2eff9b0ef599b2 (now on master) fix things for you?

It seems to be fixed, it got past line 16509. But now it gives very strange behaviour:

Mismatch in CPU state at line 148318:

MINE:	A:13 F:---- B:13 C:01 D:12 E:00 H:C3 L:04 SP:DFFD PC:C31F PCMEM:F5,D1,79,E6
YOURS:	A:13 F:---- B:13 C:01 D:12 E:00 H:C3 L:04 SP:DFFD PC:C31F PCMEM:F5,D1,79,E6

The CPU state before this (at line 148317) was:

	A:00 F:00 B:13 C:01 D:12 E:00 H:C3 L:04 SP:DFFB PC:C31E PCMEM:F1,F5,D1,79

The last operation executed (in between lines 148317 and 148318) was:

	0xF1 POP AF

Perhaps the problem is with this opcode, or with your interrupt handling?```

Now that I look at, maybe it's checking the lower nybble of AF?


useState composables return default value, instead of actual value in plugins

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.10.0
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-1dmzwk?file=plugins%2FmyPlugin.ts
Describe the bug
When using the Shared State strategy, the composables defined always return the default value in plugins, instead of the actual value.
When setting the value in middleware, the plugin keeps referring to the default value instead of the current value.
Maybe this isn't a bug and works as "intended", but the docs suggest that useState is the way to share data between server and client.
it's important to note that other things (like pages) use the current value correctly, it's only plugins that don't.
Additional context
I'm trying to store a cookie value as useState, so that I can reference that instead of having to use useCookie, but setting the value from middleware doesn't change the value the plugin uses.
Logs
No response

I'll check this when I'm back at my computer but the first key thing is that plugins all run before middleware. Then middleware run.
So I would expect that in the ssr logs we'd get the initial value from the plugin, but in the browser the plugin would show the set value. If this isn't the behaviour, it's a bug.

Hmmm okay, that's problematic in the sense that we handle session/cookie stuff in middleware (where it belongs in my opinion) and want to access the values set there in plugins that are used in the app.
Maybe one strategy would be to move the session stuff to a plugin? That just feels odd...

The plugins run first in case they need to add middleware.

Ok in that case I might need to move the session logic to a plugin. Thanks!