add categories field to scorecard data sources

Issues
Add Categories field to Scorecard datasource
Changelog
Add categories field to both opslevel_scorecard and opslevel_scorecards datasources.
Add this field to relevant tests.

[X] List your changes here
[X] Make a changie entry

Tophatting
With this Terraform config
data "opslevel_scorecards" "all" {}

data "opslevel_scorecard" "one" {
  identifier = data.opslevel_scorecards.all.scorecards[0].id
}

output "all_categories" {
  value = data.opslevel_scorecards.all.scorecards[*].categories
}

output "all_category_ids" {
  value = flatten(data.opslevel_scorecards.all.scorecards[*].categories[*].id)
}

output "one" {
  value = data.opslevel_scorecard.one
}

Run terraform plan
data.opslevel_scorecards.all: Reading...
data.opslevel_scorecards.all: Read complete after 1s
data.opslevel_scorecard.one: Reading...
data.opslevel_scorecard.one: Read complete after 0s [id=Z2lkOi8vb3BzbGV2ZWwvUnVicmljLzEzMTg]

Changes to Outputs:
  + all_categories   = [
      + [
          + {
              + id   = "Z2lkOi8vb3BzbGV2ZWwvQ2F0ZWdvcnkvODMyMQ"
              + name = "Test Scorecard"
            },
        ],
    ]
  + all_category_ids = [
      + "Z2lkOi8vb3BzbGV2ZWwvQ2F0ZWdvcnkvODMyMQ",
    ]
  + one              = {
      + affects_overall_service_levels = false
      + aliases                        = [
          + "test_scorecard",
        ]
      + categories                     = [
          + {
              + id   = "Z2lkOi8vb3BzbGV2ZWwvQ2F0ZWdvcnkvODMyMQ"
              + name = "Test Scorecard"
            },
        ]
      + description                    = "example_description"
      + filter_id                      = "Z2lkOi8vb3BzbGV2ZWwvRmlsdGVyLzM1NzA"
      + id                             = "Z2lkOi8vb3BzbGV2ZWwvUnVicmljLzEzMTg"
      + identifier                     = "Z2lkOi8vb3BzbGV2ZWwvUnVicmljLzEzMTg"
      + name                           = "Test Scorecard"
      + owner_id                       = "Z2lkOi8vb3BzbGV2ZWwvVGVhbS8xNzQzNA"
      + passing_checks                 = 0
      + service_count                  = 2
      + total_checks                   = 0
    }

You can apply this plan to save these new output values to the Terraform state, without changing any real infrastructure.

@davidbloss can you do 1 tophat test to ensure its easy and intuitive to pipe a given category into a check.
I worry that data.opslevel_scorecards.all.scorecards[0].id is not intuitive enough


AttributeError: 'EvalHook' object has no attribute 'file_client'

I want to know what is it happening?How to solve it?
Thank you
Describe the bug
AttributeError: 'EvalHook' object has no attribute 'file_client'

Could you follow the issue template to describe what you do and how to reproduce it?


Update data-classification-content-explorer.md

Hi @chrfox
This is per the email we discussed

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

Hi @shadansan, I notice that you have closed this PR after you committed the suggested changes. Was that deliberate?

Hi
Sorry I didn't know what is next and the close button was the only button available. Can you please let me know what is the process?
Best regards
Shadan
From: JohanFreelancer9 @.>
Sent: August 4, 2021 7:15 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Shadan Saniepour Esfahani @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update data-classification-content-explorer.md (#5838)
Hi @shadansanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshadansan&data=04|01|shadans%40microsoft.com|90f4630c7adb4dda9cc308d957523cf3|72f988bf86f141af91ab2d7cd011db47|1|0|637636833010877030|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=npMjTSS7xAs5aIIKpd3Io8x4vboo83QILahR6UyyviQ%3D&reserved=0, I notice that you have closed this PR after you committed the suggested changes. Was that deliberate?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F5838%23issuecomment-892695666&data=04|01|shadans%40microsoft.com|90f4630c7adb4dda9cc308d957523cf3|72f988bf86f141af91ab2d7cd011db47|1|0|637636833010877030|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dpyBf9uhlRDcqVzP2iRiHdTzGCbU5WgNIRGmz7nhT7E%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAURCWHWZ4RFUMIUQ537VXITT3FDOBANCNFSM5BP56AVQ&data=04|01|shadans%40microsoft.com|90f4630c7adb4dda9cc308d957523cf3|72f988bf86f141af91ab2d7cd011db47|1|0|637636833010886987|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ysCU98sIE5SB8Ib9yUrSMkJW29vNxV5R%2FHTtsG5hbxw%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|shadans%40microsoft.com|90f4630c7adb4dda9cc308d957523cf3|72f988bf86f141af91ab2d7cd011db47|1|0|637636833010886987|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=tJ2XAm9Bby4N5MIMTw7idflaET0Yuk4R2As3Y8NcIHk%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01|shadans%40microsoft.com|90f4630c7adb4dda9cc308d957523cf3|72f988bf86f141af91ab2d7cd011db47|1|0|637636833010896940|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=kwyJ19wJYE%2FKP6dWvZUnhLXswuWqtmxPQH8x9oN1DAQ%3D&reserved=0.

@shadansan Not a problem. You would need to re-open the PR for Chris to approve and merge.

Thanks so much for the information. I re-opened it. Is there anything else I should do or Chris will see it?
Best regards
Shadan
From: JohanFreelancer9 @.>
Sent: August 4, 2021 7:29 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Shadan Saniepour Esfahani @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update data-classification-content-explorer.md (#5838)
@shadansanhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshadansan&data=04|01|shadans%40microsoft.com|fa0db17dcace4b88b0d108d95754434f|72f988bf86f141af91ab2d7cd011db47|1|0|637636841736554257|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5pmY9YIzMnbU38l%2F%2Fle%2B%2BFnCGBsuB%2BqpH9K5xd6WV%2F4%3D&reserved=0 Not a problem. You would need to re-open the PR for Chris to approve and merge.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F5838%23issuecomment-892707324&data=04|01|shadans%40microsoft.com|fa0db17dcace4b88b0d108d95754434f|72f988bf86f141af91ab2d7cd011db47|1|0|637636841736554257|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=9LNjxYcbQ6cJ1FH3yxzMTCPzagUFENRskRs4lXObWg0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAURCWHR537KMAUHNDAIAMFTT3FFENANCNFSM5BP56AVQ&data=04|01|shadans%40microsoft.com|fa0db17dcace4b88b0d108d95754434f|72f988bf86f141af91ab2d7cd011db47|1|0|637636841736564213|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yP1TB6SqqA1ZMeFMkTvXEjqlF%2B%2BJ2Irar2cX9jUivfY%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|shadans%40microsoft.com|fa0db17dcace4b88b0d108d95754434f|72f988bf86f141af91ab2d7cd011db47|1|0|637636841736574174|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KTRnQGHWhT61s9pX3CxcLwI8xWXsEylSNXlT9u21Id4%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01|shadans%40microsoft.com|fa0db17dcace4b88b0d108d95754434f|72f988bf86f141af91ab2d7cd011db47|1|0|637636841736574174|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LaOrydNjkEYJefve1HtxwO57kuAZwzLGU19qL%2BraFkc%3D&reserved=0.

Nothing more is needed from you at this time. Thanks so much.

Thank you!
From: JohanFreelancer9 @.>
Sent: August 4, 2021 7:46 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Shadan Saniepour Esfahani @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update data-classification-content-explorer.md (#5838)
Nothing more is needed from you at this time. Thanks so much.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F5838%23issuecomment-892719857&data=04|01|shadans%40microsoft.com|ea9b7c7745d6470620d108d957568aa9|72f988bf86f141af91ab2d7cd011db47|1|0|637636851489240200|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=llBlwBCYBQBeCgZQ7ut6XVWhsfZFvWTN%2Fz6eyz02s94%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAURCWHSAON5UY2EB5JJSWQLT3FHBTANCNFSM5BP56AVQ&data=04|01|shadans%40microsoft.com|ea9b7c7745d6470620d108d957568aa9|72f988bf86f141af91ab2d7cd011db47|1|0|637636851489250160|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GE0Kz97x9o7Wid7lhbncKPzC%2Blg6jnLFuOZMfVJqF88%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|shadans%40microsoft.com|ea9b7c7745d6470620d108d957568aa9|72f988bf86f141af91ab2d7cd011db47|1|0|637636851489250160|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=IUt3rsV7GWSRtdc0mSn%2FSkn2rL9YBQq9W%2FCuk4MTNns%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01|shadans%40microsoft.com|ea9b7c7745d6470620d108d957568aa9|72f988bf86f141af91ab2d7cd011db47|1|0|637636851489260114|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=aNv3neUXUL6lxLth5i4p1G6%2BvJIV3NbYlmI5NC15QXg%3D&reserved=0.


React native webView move to another page when wrong url enter

'I am using the webview when  i enter the wrong url it will redirect to another white screen for a little moment show a pagenotfound screen then navigate to another screen.I am disable the warning then now when i enter wrong url it will redirect to white screen what is the solution i want to open pagenotfound screen as in our browser if pagenotfound..my code is
<WebView style={{flex:1,margin:20}}
ref={WebView_Ref}
source={{uri: this.state.go}}
/>

@rigdern  plz give solution

This issue looks like a question that would be best asked on StackOverflow.
StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.
Will close this as this is really a question that should be asked on StackOverflow.


Improve the performance of gRPC-related code in concurrent environments

This changeset updates the server part of Spine.
In particular:

Pushing the updates through the Subscription observer is now synchronized. Previously, this piece of code was using the underlying gRPC mechanism directly, which wasn't thread-safe.

It is now possible to configure the Executor for the gRPC server inside of GrpcContainer. Previously, only gRPC-default values were used — namely, directExecutor for in-process mode, and some hard-coded shared executor for the "remote" mode.

The library was updated with the latest config code.
The version is now set to 2.0.0-SNAPSHOT.27.

@armiol

The version is now set to 2.0.0-SNAPSHOT.27

In #1379 I'm advancing the version to ...40. So that it's in sync. numbers with base and time. Just FYI.

@dmdashenkov PTAL, again.


Do not set cifmw_cephadm_first_mon_ip from Ceph spec

Fixes bug from e23977349353fad521dd4ded0f149d3cab18c6fd
The "Set IP address of first monitor" task broke when the Ceph spec was changed to always use the ssh_network because that network is not necessarily the same as the storage_network_range. Update this task to get the first monitor IP not from the spec but from the hostvars of the host where the play is run after filtering for only the storage network.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

/approve


screenshots in server/workbench docs are too large

Screenshots in SHACL section are not properly scaled, leading to layout issues.

duplicates #1589


ros2 galactic / ubuntu 20.04 installation fail

make command fails, building the default micro_ros_tivac_launchpad_app on ubuntu 20.04.. however I have better log this time:
Starting >>> lifecycle_msgs
Starting >>> std_srvs
--- stderr: lifecycle_msgs
CMake Error at /home/ubuntu/micro_ros_tivac_launchpad_app/microros/install/micro_ros_src/install/share/rosidl_typesupport_c/cmake/get_used_typesupports.cmake:35 (message):
  No 'rosidl_typesupport_cpp' found
Call Stack (most recent call first):
  /opt/ros/galactic/share/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cpp-extras.cmake:8 (get_used_typesupports)
  /opt/ros/galactic/share/rosidl_typesupport_cpp/cmake/rosidl_typesupport_cppConfig.cmake:41 (include)
  /home/ubuntu/micro_ros_tivac_launchpad_app/microros/install/micro_ros_src/install/share/rosidl_default_generators/cmake/rosidl_default_generators-extras.cmake:21 (find_package)
  /home/ubuntu/micro_ros_tivac_launchpad_app/microros/install/micro_ros_src/install/share/rosidl_default_generators/cmake/rosidl_default_generatorsConfig.cmake:41 (include)
  CMakeLists.txt:14 (find_package)

---
Failed   <<< lifecycle_msgs [0.93s, exited with code 1]
Aborted  <<< builtin_interfaces [0.99s]
Aborted  <<< micro_ros_msgs [0.95s]
Aborted  <<< std_srvs [0.91s]
Aborted  <<< unique_identifier_msgs [0.97s]

Summary: 24 packages finished [12.5s]
  1 package failed: lifecycle_msgs
  4 packages aborted: builtin_interfaces micro_ros_msgs std_srvs unique_identifier_msgs
  8 packages had stderr output: builtin_interfaces lifecycle_msgs micro_ros_msgs microxrcedds_client rcutils rmw std_srvs unique_identifier_msgs
  33 packages not processed
arm-none-eabi-gcc -mthumb -mcpu=cortex-m4 -mfpu=fpv4-sp-d16 -mfloat-abi=hard -ffunction-sections -fdata-sections -MD -std=c99 -Wall -pedantic -DPART_TM4C123GH6PM -c -g -D DEBUG -O0 -DTARGET_IS_TM4C123_RB1 -DUART_BUFFERED -Itivaware_c_series/examples/boards/ek-tm4c123gxl/ -Itivaware_c_series -Imicroros/install/include -Isrc -Dgcc -o gcc/microros.o src/microros.c
In file included from src/microros.c:2:
src/./microros_usbcdc_transport.h:8:10: fatal error: rmw_microros/custom_transport.h: No such file or directory
    8 | #include <rmw_microros/custom_transport.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [tivaware_c_series/makedefs:175: gcc/microros.o] Error 1

Best regards,
Can

colcon-common-extensions.txt
make.txt
make2.txt
on a default lxc image with ros-galactic installed, when pip3 install colcon-common-extensions is run, it gives a warning like:
ERROR: pytest-rerunfailures 10.2 has requirement pytest>=5.3, but you'll have pytest 4.6.9 which is incompatible.
After this, I upgraded pytest to 7.1.1 with pip3, but the install still fails - for an irrelevant reason - and that is logged in make2.txt
Best Regards,
Can Altineller

I can't replicate this on netiehr on my local ubuntu 20.04 or ubuntu:latest and ros:galactic docker images.
Could you give more info about your environment? How did you install ROS?
We may need to add the upgrade flag -U on this command to fix that versioning errors:

pip3 install -U catkin_pkg lark-parser empy colcon-common-extensions

Ok, it is fixed. It was a combination of number of things.
First,
pip3 install -U pytest
and then
pip3 install -U catkin_pkg lark-parser empy colcon-common-extensions
is required. Also the .local/bin must be in path, and /opt/ros/galactic/setup.bash must not be sourced.
if /opt/ros/galactic/setup.bash is sourced, then compilation fails.
Best Regards,
Can


Overloads for Named Tensors missing

There are currently missing overloads for named tensors in all factory methods in the following factories:

torch.empty
torch.rand
torch.randn
torch.ones
torch.tensor
torch.zeros

There is also missing the redefine_names method:
var t = torch.tensor(new[] { 1.345, 2.564, 3.456 });
t.redefine_names(new [] { "channels" });

Example
Tensor tensor<T>(IList<T> rawArray, long[] dimensions, ScalarType? dtype = null, Device device = null, bool requiresGrad = false, string[] names = null)
where T:INumber
{
    // ....
}

Usage
var t = torch.tensor(new[] { 1.345, 2.564, 3.456 }, names: new [] { "channels" });

Right -- named tensors aren't currently supported in TorchSharp. Good to know there's a demand for it.

Just an implementation note:
Taking a closer look at the API, I noted that there doesn't seem to be any native support for named dimensions in libtorch.
Thus, this will have to be supported in the managed code APIs and may add some overhead.

There is also missing the redefine_names method:

refine_names, right?

There is also missing the redefine_names method:

refine_names, right?

yes ;-)
There is a full list of operators found here: Named Tensors operator coverage

WIP NAMED TENSORS

INTRODUCTION TO NAMED TENSORS IN PYTORCH

Creating named tensors

[ ] torch.empty()

[x] torch.rand()

[x] CreateRandomTensorWithNames()

[ ] torch.randn()

[x] torch.ones()

[x] CreateFloat32TensorOnesWithNames

[x] torch.tensor()

[x] CreateFloat32TensorFullWithNames()

[x] torch.zeros()

[x] CreateFloat32TensorZerosWithNames

Named dimensions
Name propagation semantics
Explicit alignment by names

[x] align_as()

[x] TestAlignAs()

[x] align_to()

[x] TestAlignTo()

Manipulating dimensions

[x] flatten()

[x] TestFlattenNamed

Named tensor API reference

[ ] CLASS torch.Tensor

[x]  rename(*names, **rename_map)

[x] TestRenameTensor()
[x] TestRenameNamedTensor()

[x] refine_names(*names)

[x] TestRefineNames()


22.7.5 OpenVPN Default DNS Default Domain - unable to remove

Describe the bug / To Reproduce
When activating "DNS Default Domain" in the OpenVPN Server settings and hitting save - everything works. When trying to remove the setting by unticking the setting and hit "Save" the setting will not be removed. After reentering the OpenVPN Server settings, the previously deleted DNS Default domain is still there.
Expected behavior
Setting will be removed and the OpenVPN Server will push options correctly to newly connected clients.
Workaround: The only way to delete this setting is by leaving the setting ticked and remove the domain from the list and hit save.
*Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 22.7.5 (amd64, OpenSSL).

The configuration wants you to remove the domain entry and the checkbox is just clutter. It would probably be better to remove the checkbox and always show the field.
Since this is a bit of work to audit all fields relevant to this I'll queue this up for 23.1.


[Bug]: Text overflow out of the box

Contact Details
<EMAIL_ADDRESS>What happened?
on https://digitomize.com/contests
the contests having long text is getting overflowed on all device resolutions.
the demo could be seen in below image:

What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Are you interested in contributing?

[X] I'd like to work on this issue

Code of Conduct

[X] I have used the search function to check if an issue already exists
[X] I agree to follow this project's Code of Conduct

Which program are you contributing in?
gssoc

Hey @Yash-Ainapure, kindly assign this issue to me, I'd love to contribute.

Hello @Yash-Ainapure,
I would like to contribute to this issue. I have already implemented a fix for the problem.

Sir, I am not the owner, I am only waiting for the owner to assign the issue to me

duplicate #822


Fix LAMBADA for LLaMA

0 accuracy in https://github.com/EleutherAI/lm-evaluation-harness/issues/443 is due to the space added in lm_eval/tasks/lambada.py, as LLaMA has no tokens for such spaces. Removing it gets

Task
Version
Metric
Value

Stderr

lambada_openai
0
ppl
3.6224
±
0.0723

acc
0.7308
±
0.0062

on LLaMA-7B.

can you check the performance of Pythia, GPT-2, and T5 using this modification? I want to make sure that we don’t add support for LLaMA at the expense of other models.


DropDown: Value gives UnicodeDecodeError (Greek Alphabet)

Dropdown value with greek characters for the dropdown.Option gives: UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd0 in position 0: invalid continuation byte.
This is only applicable for the dropdown value as if I try to receive a value from a Textfield I don't get any errors
`
class WindowsUiCard(UserControl): #Windows Object
    def __init__(self)->None:
        super().__init__()

        self.window_type = Dropdown(label="Τύπος", hint_text="Επιλέξτε μία από τις τρεις κατηγορίες", options = [
                                          dropdown.Option("Aluminum"),
                                          dropdown.Option("Πλαισιο ξυλου με ενεργειακο υαλοπινακα"),   #Wood frames
                                          dropdown.Option("Πλαισιο PVC με ενεργειακό υαλοπίνακα") ,   #Pvc frames
                                      ],
                                  border_color=colors.BLACK,
                                  color = colors.BLACK,
                                  )
      self.window_btn = FloatingActionButton(text="Υπολογισμός", on_click= self.on_window_calc) #Calculate

  def build(self):
        return .......

def on_window_calc(self, e)-> None: #Calculate window price based on type
    type = self.window_type.value
    print(type)
  `

I tried the following code on both macOS and web clients and couldn't reproduce the issue:
import logging

import flet
from flet import Dropdown, ElevatedButton, Page, Text, colors, dropdown

#logging.basicConfig(level=logging.DEBUG)

def main(page: Page):

    dd = Dropdown(label="Τύπος", hint_text="Επιλέξτε μία από τις τρεις κατηγορίες", options = [
                                          dropdown.Option("Aluminum"),
                                          dropdown.Option("Πλαισιο ξυλου με ενεργειακο υαλοπινακα"),   #Wood frames
                                          dropdown.Option("Πλαισιο PVC με ενεργειακό υαλοπίνακα") ,   #Pvc frames
                                      ],
                                  border_color=colors.BLACK,
                                  color = colors.BLACK,
                                  )
    def calc_click(e):
        type = dd.value
        print(type)

    page.add(
        dd,
        ElevatedButton("Calculate", on_click=calc_click),
    )

flet.app(target=main)

What OS are you running on? Can you try the code above?

I think I have found the problem. When I run the program from python /.main.py it works fine. When I try to run it with hot-reload using flet main.py this is where the problem appears. I have used all the flet commands but the problem still appears. I don't know if it's a bug or if I'm doing something wrong.
Thanks for the fast reply and for your great work with flet.

Gosh, there is something to do with encoding while running subprocess and grabbing its output and it's especially nasty on Windows. I've tried a few tricks but no avail :(

Related to https://github.com/flet-dev/flet/issues/1000
It looks like I'm about to fix this issue.

You can try the fix with pre-release version of Flet module:
pip install flet --upgrade --pre

Let me know how it worked.

Yes everything works fine now.
I had to work with version 0.2.4 because it didn't work but now it's
perfect.
Thank you very much.
I have also made an IntField and a FloatField .
You can check at discord in the contribution section. Its a bit hacky but
gets the job done.
Maybe i can send a pull request if you approved it.
Thanks a lot with the greek alphabet. I can now finish and pushlich my app
on the microsoft store.
By the way great job with flet.
On Wed, Feb 8, 2023 at 9:55 PM Feodor Fitsner @.***>
wrote:

You can try the fix with pre-release version of Flet module:
pip install flet --upgrade --pre
Let me know how it worked.
—
Reply to this email directly, view it on GitHub
https://github.com/flet-dev/flet/issues/302#issuecomment-1423162411, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMIOVUVVHAMVBMQXGF66AJ3WWP22XANCNFSM6AAAAAAQI3N74Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

I can now finish and pushlich my app on the microsoft store.

@Tasos306 How?

It's a bit complicated but I can guide you through.
This is the manual process I have found. There is another programmable but
i don't know it.
First you need to make an account at the Microsoft partner center. (you
must pay to be a partner), put your bank information and sign the contract
with microsoft. (Be careful in the tax information fields if you are not
american) . After you set your account you must have a website because in
order to upload your app you must point the user to a url with your policy
agreement and your licence agreement about the app.
For the licence and the policy you must have a lawyer to guide you through
the process (maybe your app has other libraries or dependencies with
different licences or if your app collects user information). If your app
collects user information you must declare that in the final steps of the
upload process (metadata in an xml file).
After that, make an executable of your app with pyinstaller (with no
console flag). Then use a free program called "Inno setup installer" to
make your executable instalable. Then the output off the installable you
have to put it in another microsoft free tool called MSIX Packaging Tool
(you can find it on the microsoft store for free) to make an msix package.
Then run your package with another free microsoft tool called Windows App
Center Kit to check for errors. After that you can upload the msix package
to the Microsoft Store. Before your app is uploaded, it is checked by the
microsoft team and they may ask you questions about what your app does (by
email). The process is a bit difficult with all the fields you have to
fill, but if you need any help, just let me know. I' be happy to help.
On Fri, Feb 10, 2023 at 11:16 AM TheEthicalBoy @.***>
wrote:

I can now finish and pushlich my app on the microsoft store.
@Tasos306 https://github.com/Tasos306 How?
—
Reply to this email directly, view it on GitHub
https://github.com/flet-dev/flet/issues/302#issuecomment-1425471339, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMIOVUSZYXXFR5437I5QSELWWYBNPANCNFSM6AAAAAAQI3N74Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for the details.
I believe you've tried it already..¿
Can I have an app you've made which is in the Ms store already?
Thanks.


Create a dir for vision data with a dummy file

please don't merge if no one, i.e. zack, didn't review this pr
you don't need to create empty folds, you can create it if doesn't exist on the fly

Sorry. I will only send pull request in the future for this repo.


feat: Implement configurable minimum number of readers for popular tables

Summary of Changes
Related issue: #534
This PR adds num_readers variable for the neo4j popular table query. This allows the minimum number of readers for popular tables to be configurable.
Need to update frontend's config.py
Tests
Modified

test_get_popular_tables
test_should_get_popular_tables_with_default_args

New

test_should_get_popular_tables_with_requested_limits
test_should_get_popular_tables_with_requested_readers

Documentation
No documentation changes at this time
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   72.01%   72.01%
=======================================
  Files          26       26
  Lines        1197     1197
  Branches      121      121
=======================================
  Hits          862      862
  Misses        308      308
  Partials       27       27

Impacted Files
Coverage Δ

metadata_service/api/popular_tables.py
100.00% <ø> (ø)

metadata_service/proxy/atlas_proxy.py
80.38% <100.00%> (ø)

metadata_service/proxy/base_proxy.py
67.14% <100.00%> (ø)

metadata_service/proxy/gremlin_proxy.py
45.45% <100.00%> (ø)

metadata_service/proxy/neo4j_proxy.py
74.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4cb7c...3d4127f. Read the comment docs.

Thanks for picking it up @jacobhjkim LGTM 👍
Need Tao or someone else from Lyft to merge it.

I am adding FrequentUsers functionality for AtlasProxy (PR 147) now and was thinking on something similar, will wait with my merge until this one is in :crossed_fingers:

sorry for the delay in review, will take a look!


fix: allow replace marker for metadata.name

Signed-off-by: Jeff Davis<EMAIL_ADDRESS>

@JefeDavis this didn't fix the error.  I added a test for this to the application test case

closing in favor of #224


Groq tools

Groq has recently announced tools support for Llama and Mixtral models similar to OpenAI tools. e.g. https://console.groq.com/docs/tool-use
Given that, Groq model configuration should have the same tools parameter as OpenAI configuration:
providers:
  - id: openai:chat:gpt-4o-mini
    config:
      tools: [
        {
        "type": "function",
          "function": {
            "name": "get_current_weather",
            "description": "Get the current weather in a given location",
            "parameters": {
              "type": "object",
                "properties": {
                  "location": {
                    "type": "string",
                      "description": "The city and state, e.g. San Francisco, CA"
                    },
                    "unit": {
                      "type": "string",
                      "enum": ["celsius", "fahrenheit"]
                    }
                  },
              "required": ["location"]
            }
          }
        }
      ]
      tool_choice: 'auto'

@poborin I’ve updated the Groq integration in this PR, and it’s now available in version 0.79.0. You can find the setup instructions in our documentation, and there’s a tool use example here. Please try it out and let me know if you encounter any issues. I’d also appreciate any help improving the documentation and examples if you're interested in contributing to promptfoo. Thanks so much for suggesting the feature!


Missing information about using services.Configure<> to inject configuration into controllers

This article is missing a very useful and relevant technique to inject a custom configuration using services.Configure<MyConfigCustomObject>(Configuration.GetSection("MyConfig"))
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @mxa0079 ... That's part of the Options API and covered here :point_right: https://docs.microsoft.com/aspnet/core/fundamentals/configuration/options#general-options-configuration-1


onTouchStart does not update value in input field.

If this is expected then it is more likely suggestion.
Observed behaviour: The selected value onTouchStart does not set as value in input field. I wonder this it expected.. if it is then this might be suggestion as it is not working my touch device.
Expected behaviour: The selected item should be set as value in input field onTouchStart.
Just wonder we can change this https://github.com/moroshko/react-autosuggest/blob/master/src/Autosuggest.js#L420 to be same as click behaviour. When a user touch the item in the select items then should treat the touch as click.  At the moment it does not update value in input field..

Realised that ontouchstart differs from click/tap


Something about "LossCosine" function

It seems that there is something wrong about your function "LossCosine", located at /Layers/TAL_pytorch.py. When I train with cosine regularization, the loss is less than zero, which is totally impossible. And I notice that in function "LossCosine", before returning the mean value of loss, you multiply it with minus one, which is different from that in function "LossDis" function.
And in your paper, the math formulation of your Cosine regularization is also multiplied by minus one, which makes the loss value is less than zero. Is there something wrong with me?

Cosine similarity ranges from -1 to 1, and the larger value means that the two vectors have closer directions. So multiplying it by -1 means that we want to maximizing the cosine similarity.

Cosine similarity ranges from -1 to 1, and the larger value means that the two vectors have closer directions. So multiplying it by -1 means that we want to maximizing the cosine similarity.


refactor: replace hyphens and dots in environment variable keys

Added import for the "strings" package
Defined a replacer for "-" and "." with "_" in variable "replacer"
Added a call to "SetEnvKeyReplacer" for the "viper" object in the "initConfig" function.

fix https://github.com/appleboy/CodeGPT/issues/16

Codecov Report

Merging #25 (e294734) into main (98155ea) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff          @@
##            main     #25   +/-   ##
=====================================
  Coverage   9.67%   9.67%
=====================================
  Files          2       2
  Lines         31      31
=====================================
  Hits           3       3
  Misses        28      28

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


||= operator crashes the compiler

I have an x = x || y in my code and when I change it to x ||= y it crashes the compiler when I try to build the app. The unit test works fine though.
http://cl/177018393
http://sponge/55d81721-568d-459f-a71f-480c5828082b

The ||= operator isn't valid Dart 1, it will be valid Dart 2.
(Shoulnd't crash anything, though).

Hi @dskloetg, thanks for filing.
It appears that I already fixed this issue, it just hasn't been rolled to you. The fix landed in 606e8502f8, which appears to be included in the sdk 2.0.0-dev.4 (from your logs, it seems you are using 2.0.0-dev.3).
I'm closing the issue here assuming this will be fixed on your end as soon as we roll the new sdk.


added encoding/decoding for URL in markdown editor

What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4590
Description (What does it do?)
This PR aims to encode/decode URLs in text editor in ocw-studio for correct browser readable URLs.
The opening and closing brackets will be saved as %28 and %29 respectively for being later used in course compilation.
How can this be tested?

Switch to branch umar/4590-links-to-urls-that-have-parentheses

Create any resource and link a URL with parentheses, e.g https://commons.wikimedia.org/wiki/File:Saint_Joseph_charpentier_(La_Tour).jpg in the text editor.

Save and publish changes.

Visit the published site. and Click on the URL it follow proper URL.

Additional Testing

The content data in markdown should be save in encoded format.

Does this only address parentheses? Will there be other characters that hit this type of problem, or is there something special about parentheses?

Does this only address parentheses? Will there be other characters that hit this type of problem, or is there something special about parentheses?

@pdpinch this happens for () only. Markdown has [title](url) syntax to store hyperlinks. When a url with parentheses is inserted it becomes [title](url_with\(parentheses\)). The () inside url needs to be escaped to meet the markdown syntax. This escaped markdown string is saved in DB which is then used for site compilation.
The html url encoding for () is %28%29. However, for the escaped characters \(\) it is encoded to %5c%28%5c%29 which makes the URL invalid on compiled site.
To handle this, we encode/fix the url before saving it to DB. Then the correct encoded url is used in compilation. On author side, we decode it to show the original utl with parentheses.


Fix caching of weights for total task in fast mode

weights_path must match the folder name in the zip file (that ends with _v204).
If it does not match (which was the case here) then the weights are re-downloaded each time the model is used.
fixes #196

Great. Thank you.


Add join/leave functionality to Missions

[x] Join Mission functionality added
[x] Leave Mission functionality added
[x]  Display reserved Missions in My profile

Hi @Rana-Mudassir
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Linters are passing 👍
The project is running successfully 👍
PR is well descriptive 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @sawmon71293 in your question so I can receive the notification.


back-merge 19.7.0 -> develop

Pull Request Test Coverage Report for Build 3173

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.599%

Totals

Change from base Build 3171:
0.0%

Covered Lines:
6864

Relevant Lines:
7983

💛  - Coveralls


Update docusaurus.config.js

per slack thread, creating pr to add a hideable property in the docusaurus.config.js file.
one of the objectives for the docs team is to first test and preview as a must to understand docs site behavior
Things the Docs team want to test:

how will text size/images/tables resize or render?
will the text wrap?
will the sidebar reappear if a link is clicked?, etc.

docusaurus link
asana ticket
What are you changing in this pull request and why?

Checklist

[ ] Review the Content style guide and About versioning so my content adheres to these guidelines.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry _redirects
[ ] Ran link testing to update the links that point to the deleted page

thank you as always for your guidance @JKarlavige ! i learned a lot on this one and really appreciate it! I've reached out to the docs team for review and testing and will hopefully merge this soon

The only note I have (and it is by no means a blocker and may just be a limitation of the feature):
The hidden sidebar persists when jumping between areas that also have a sidebar (docs, references, guides, join the community, etc). If I navigate to a page that doesn't have the sidebar (developer blog or join the community) the sidebar is no longer hidden when I go back to another page.

The only note I have (and it is by no means a blocker and may just be a limitation of the feature):
The hidden sidebar persists when jumping between areas that also have a sidebar (docs, references, guides, join the community, etc). If I navigate to a page that doesn't have the sidebar (developer blog or join the community) the sidebar is no longer hidden when I go back to another page.

Hi @matthewshaver, just confirming that looks like the default functionality when viewing the Docusaurus docs as well. If you hide the sidebar on this page, then navigate to Blog, then back to the docs, the sidebar reappears.

thank you @JKarlavige and @matthewshaver for the feedback and collaboration ✨i'm going to go ahead and merge this pr


Appstudio update test-component-pac-eaym

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-eaym-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
45 seconds
deprecated-base-image-check

✅ Succeeded
46 seconds
inspect-image

✅ Succeeded
4 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
1 minute
sbom-json-check

✅ Succeeded
12 seconds
label-check

✅ Succeeded
12 seconds
optional-label-check

✅ Succeeded
46 seconds
show-sbom

✅ Succeeded
46 seconds
show-summary


Support transactions

👀 I see you really went at it @johnnyshields, good stuff ;)

👀 I see you really went at it @johnnyshields, good stuff ;)

Yes, I did. I think I've come up with pretty good logic at this point, am using threads in the tests to check simultaneous actions for various scenarios (add, change scope, etc.)

Yes, I did. I think I've come up with pretty good logic at this point, am using threads in the tests to check simultaneous actions for various scenarios (add, change scope, etc.)

Yes, I did. I think I've come up with pretty good logic at this point, am using threads in the tests to check simultaneous actions for various scenarios (add, change scope, etc.)

I did a cursory look at the code and I think it's a net "a lot better". Good call on dropping older MongoDB support as well and just moving forward. Either way if it doesn't work correctly we can blame all data loss on MongoDB again ;)

Yes, I did. I think I've come up with pretty good logic at this point, am using threads in the tests to check simultaneous actions for various scenarios (add, change scope, etc.)

I did a cursory look at the code and I think it's a net "a lot better". Good call on dropping older MongoDB support as well and just moving forward. Either way if it doesn't work correctly we can blame all data loss on MongoDB again ;)

Main reason for dropping older Mongoid is that this gem really should only be used in production with transactions enabled, and I don't think they work before Mongoid 7. I've just pushed version 6.0.0 to Rubygems by the way, please give it a try.

Main reason for dropping older Mongoid is that this gem really should only be used in production with transactions enabled, and I don't think they work before Mongoid 7. I've just pushed version 6.0.0 to Rubygems by the way, please give it a try.


Liocoin Wallet

Where can I download the Liocoin wallet and how to run it?

aqui
https://www.lio-coin.eu/register/kZolEI


Add GetRemoteCandidates()

This is analogue to GetLocalCandidates() and provides the user with the ability to get a slice of previously added remote candidates without keeping track of them in the application code.

Hi @at-wat,
sure. I also added one for GetLocalCandidates().


"Mârghia de Jos" is listed in the drop-down menu

Description:
"Mârghia de Jos" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Mârghia de Jos" in the search bar.

Expected results
The location is listed in the drop-down menu as "Mârghia de Jos, Argeș (Lunca Corbului)".


Issue Getting the code to utilize google collab GPU

Hi, I'm Parsa a master's student at the university of Semnan.
I am trying to get gossipy (particularly main_onoszko_2021.py) to run In google collab. although successful; it takes long training times and shows 0 utilization of GPU . that is when CUDA is available for PyTorch. and also GPU is enabled in collab. let me know if you wanna take a look at my code I will email it to you.
btw I have tried solutions like (numba @jit(target_backend='cuda')  ). if you can put me in the right path. may tell me how you managed to get it to use GPU? I will be grateful

Hi Parsa, thank you for your interest in gossipy.
Currently, gossipy does not support GPUs; however, I am planning to add it soon.
It should be rather a quick fix; unfortunately, I did not have much time to work on it.

This issue has been fixed in 8bd4fbf
It is possible to set the device using the GlobalSetting singleton object:
GlobalSettings().set_device("cuda")

before generating the clients and setting up the simulation. I suggest putting it at the beginning of your python scripts.


Empty tuple type

According to the specifications (3.8.5), the following two should be illegal.  Tuple types should not be empty and there should be no trailing comma.  However, the implementation seems to allow them.
var t1 : [];
var t2 : [number,];

If they are to be allowed and the specifications are to be revised, let me suggest that the tuple type be generalized in the same way as array literals are, in JS.  E.g.
var t: [, number,, string,,];

where t is a 5-tuple whose 2nd element is a number and whose 4th element is string (the other three are unknown --- any).

This is what I get when I compile this:

(1,10): error TS1122: A tuple type element list cannot be empty.
(2,17): error TS1009: Trailing comma not allowed.

What version are you running?

Sorry, I should have mentioned this.  Version 1.9.0, from a (slightly outdated, 6 days ago) git clone, commit f06423b.  It seems that the current version (commit 9f6f871) issues the errors that you mentioned, so it seems to have been fixed in the last 6 days.  Sorry about the false alarm.
On the other hand, I really wouldn't mind allowing these two and adopting the more liberal view of tuple types that I suggested above.  I'm leaving this open, in case somebody wants to think about it...

Oops, sorry, I was wrong once again.  The problem seems to be still there in the current commit 9f6f871.

I think something's wrong with whatever setup you're using to test this. I'm on the same commit and am seeing the errors.
If you want to open a separate suggestion for gapped tuple types, please do, but I'd rather not have this issue tracking it since it's logged as if it were a bug.

The issue seems to be more complicated than I thought.  My setup seems to be OK (jake runtests completes successfully).
In fact, I was testing a slightly larger example containing these two lines.  With that larger example, there were no errors reported for these two lines, but there were errors in lines following these two.  Here's a MWE showing this strange behaviour:
var t1 : [];
var t3 : [number,,];

Now (in the current commit 1156141), although both lines are erroneous, only the second one produces an error message:
binding-patterns.ts(2,18): error TS1110: Type expected.

That's normal behavior. When you have a syntax error, we don't issue type errors. A missing entry in a delimited list is a syntax error, but an empty tuple type is a type error (as you can see this distinction is sometimes a bit arbitrary, but it usually makes sense).
You can see the same behavior e.g.:
var t1 : [];
var y = 1 & ; // Syntax error here, so no type error issued on line 1

OK, understood.  My mistake then...  Issue closed.


Configuring deployment limits and environment

At present, any settings such as memory limits or environment variables of the deployments in the CSV cannot be configured. Although memory limits etc. is not very critical for operators that have a low footprint in general, api-servers configured in OLM may need to have limits increased, or even replicas changed. Having some way for making such settings configurable at operator install/apply time would be a useful feature in order to manage different settings for dev vs production for instance.

Hi @lulf -
We have a proposal for this and have begun implementation on it:
This doc describes the feature: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/Documentation/contributors/design-proposals/operator-config.md
Currently we have only implemented Env vars, but the rest will come soon (in the 4.3 timeframe)


Add a persistent handle type.

Rendered
Create a persistent handle type that allows native Rust data structures to hold references to Node.js objects.

@abrodersen I should've thanked you right away when you submitted this, I just went into chewing-on-it mode right away and forgot to respond. This RFC is really intriguing!
Here are my initial thoughts and questions:

Can you motivate this with some more concrete/illustrative examples of where and why a programmer would want to use the feature? This is important for the guide-level docs, so users can understand quickly what the purpose is and whether it's relevant to their interests. It's also important for motivating the design, to make sure we're rationalizing it against practical use cases. Personally, the latter would be helpful because while I understand the mechanism for persistent handles, I haven't used them myself in practice.
I think the most interesting and exciting piece of this design is the Drop trait and threading. One of Rust's underappreciated qualities is that it's hard to unintentionally leak memory, since most lifetimes follow a stack discipline. While V8's C++ API has leak-prone-by-default persistent handles, tying our Neon version of this feature to Rust's RAII mechanisms seems like it's got the promise to give you the benefits of V8 persistent handles without the accidental leaks.
One thing I think is a little underspecified so far in this RFC is the semantics of sharing PersistentHandle across threads. My first interpretation was that it's something like Arc, but maybe that's the wrong way to understand it? Is it possible to implement this without using any atomics?

Thanks so much for this work! I'm very excited to see where it goes.

Hello @dherman, and thank you for the feedback!
The most concrete example I can think of is the one I'm using Neon for right now: Essentially, I have a Rust library that reads in data from a stream and performs some transforms on it. I want to integrate this library into an existing Node.js program. Because of our requirements, the Rust library must be able to pipe the data from a Node.js stream and do it asynchronously. After multiple iterations of prototyping, I finally found the (currently) only feasible design: run the Rust library code in a background task. When it needs input, it sends a signal to a dispatcher task. The dispatcher invokes a callback, passing it a continuation function (using the new closures 😉) that sends a response signal back to the library. The library then uses the data to perform its transformations and return the results. This design allows the callback implementation to asynchronously read all necessary data and send the results back to the library.
I have been working on this problem for a while, and as far as I can tell, it's the most workable solution. This design requires a persistent handle implementation, as the current Task API requires all referenced data to be stored in the implementing struct. Since this struct is moved when calling schedule, it cannot contain scoped Handle values. I need a reference the the callback function to be stored in the dispatcher task struct, because I want to reschedule the task after the callback has been invoked.
Yes, it appears the Drop trait should be effective in preventing memory leaks. 😃
There shouldn't be any atomic operations involved. The PersistentHandle type will simply hold a pointer to a heap-allocated native reference. The PersistentHandle can be moved around safely without any atomic operations. When we want to interact with the underlying value, the PersistentHandle must be moved (or cloned) to the main thread where we have access to a Scope reference. There it can be consumed into a local Handle reference and safely interacted with normally.

Hi,
I have created an example app showing how PersistentHandles can be used to reference Node.js objects in callbacks from a Neon Task.
A MainBackgroundTask signals a DispatchTask to return data from Node.js when it needs it.
https://github.com/rebo/async-neon-example

It looks like #25 really found the right abstraction level for being able to do background work in Rust threads—thanks in no small part to N-API demonstrating a good design. Thanks for this contribution and for helping us understand the design space!