add support for network wasm filters

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests-arm64

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests-arm64

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests-arm64

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests-arm64

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Donot we need to update WasmPlugin API?

Donot we need to update WasmPlugin API?

Not needed.  I think we can match by port based on what filter chain we build.

I think we need a strong way to indicate a network Wasm API plugin. At a minimum this would be a new field that defaults to HTTP plugins.
Re: using TCP RBAC to deny - this doesn't work as expected since Envoy implementation opens the upstream connection before RBAC is applied. We'll need to find another way to implement it.

I think we need a strong way to indicate a network Wasm API plugin. At a minimum this would be a new field that defaults to HTTP plugins.

Will add one in the API

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

lint_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

lint_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test lint

unit-tests_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

lint_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test lint

unit-tests_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
8f93bdeca8dd1965bc1233a8764b66440ddea6e2
link
true
/test integ-telemetry-mc

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

lint_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test lint

unit-tests_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests-arm64

lint_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test lint

unit-tests_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry

integ-telemetry-mc_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry

integ-telemetry-mc_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry

integ-telemetry-mc_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-pilot-multicluster

integ-telemetry-istiodremote_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
cfd605bd132d48ab27938dd20b30addfa5856b03
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-pilot-multicluster

integ-telemetry-istiodremote_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-pilot-multicluster

integ-telemetry-istiodremote_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry

integ-telemetry-mc_istio
dc4d24e26b3b380d2254567a2d23fcdd0dcd1b55
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu @kyessenov Updated all review comments. Only thing pending is an Integration test - The current test WASM does not implement Network StreamContext. Once this PR is merged, I will update the test WASM and add an integration test.
@howardjohn  PTAL when you get chance

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
df92c8e5657848495ad745e5fc2d212900b69dc9
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster

So if it's FAIL_CLOSED and wasm fails to download - what does the agent send as a filter? ECDS has to send something. Any TCP filter can't stop upstream from being connected to in Envoy, so it doesn't quite work.

In Http, if download failed and is fail closed, we just return error https://github.com/istio/istio/blob/a292d6d0b57dee4e9c595659fcbcc1ee549cdbca/pkg/wasm/convert.go#L85  and we send NACK.  In fail open case we send the NOOP filter. The RBAC is used only for Fail open cases

Ah, gotcha. So RBAC is just used as ALLOW.

I am OOO, will review next monday

@hzxuzhonghu Thank you for your detailed review. Simplified the code a bit and ensured network filter order is maintained with pre built filters. PTAL.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests-arm64

unit-tests_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test unit-tests

integ-pilot-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote

integ-cni_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-cni

integ-pilot_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot

integ-pilot-multicluster_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-multicluster

integ-pilot-istiodremote-mc_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry

integ-telemetry-mc_istio
4d156f55db056508af691f4cb081cfc054f11dca
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think you are mistaken about wasm pugin phase

Yeah. You are right. I read the docs now - I thought it is appended at authn phase but docs show it otherwise. thanks. I will change

@hzxuzhonghu changed. PTAL

@howardjohn @kyessenov PTAL

can you add some e2e tests for this?

can you add some e2e tests for this?

Yes. I will add. We need to update the existing WASM filter to be used in tests with Network interface. Will do that.

thank you


IDB converting : txt to SQLite DB & IDB manager : support Operation periods for IDBs

Codecov Report

Merging #14 (9372e64) into master (7aea798) will decrease coverage by 13.22%.
The diff coverage is 45.21%.

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage   99.44%   86.22%   -13.23%
===========================================
  Files           6        6
  Lines         363      472      +109
===========================================
+ Hits          361      407       +46
- Misses          2       65       +63

Impacted Files
Coverage Δ

stixcore/idb/manager.py
55.31% <36.36%> (-44.69%)
:arrow_down:

stixcore/idb/idb.py
99.54% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aea798...9372e64. Read the comment docs.


[Epic - Planting Flow] Planting Feature Redesign / Additions

Quick summary:
The planting feature has some issues once you start the flow. Some issues include getting redirected to the sign-in page, no indicator of the geolocate being on or off, the plant pin looking like a loading screen. We want all these issues to be resolved by making the flow clear for anyone using it.
Resources:

Figma Link  https://www.figma.com/file/5C3v1LUNwMPQy9JOgnKEtr/Water-the-Trees?t=aBC5OVBAzIfH8zZd-0
Miro Board https://miro.com/welcomeonboard/cnh5VUkxWEloaEJabjNkeDlINlQ4UXBheGpxRWVtNnk3MHJIeHFQeFpBMnA0N1B3SURxRWhITllQMjVmNjRnbnwzMDc0NDU3MzY3MDk2MjMyMDg0fDI=?share_link_id=529228906114
Design git issue with discussion  #314

What's out:

Bug List - Critical Path

[ ] #506
[ ] #464

Milestone 1 - Planning the Feature

[x] #504

Milestone 2 - Adding / Revising with what is existing
UX Flow

[x] #538
[ ] #585

Redesign + Additional Features

[x] #365
[x] #456
[x] #457
[x] #473
[x] #477
[x] #478
[x] #505
[x] #514
[x] #513

Tree Information Input Fields Redesign

[x] #466
[x] #467
[x] #469
[x] #581

Milestone 3 - Integrating Additions and Revisions to Planting Feature
Implementation Roadmap

[ ] #516

Redesign + Additional Features

[ ] #515
[ ] #517
[ ] #518
[ ] #519
[ ] #533
[ ] #532
[ ] #531

New Location Support Static Page

[ ] #530

Tree Information Input Fields Redesign

[ ] #534
[ ] #535
[ ] #536
[x] #537
[ ] #470

Milestone 4 - Bulk Planting

[x] #305
[ ] [Planting Flow - Design Bulk Planting] After Dragging Tree Pin, Will Ask how many trees will be planted
[ ] [Planting Flow - Design Bulk Planting] Before Inputting Info, Will Ask if all trees are the same species
[ ] [Planting Flow - Design Bulk Planting] If trees different species, then will have sections per planted tree
[ ] [Planting Flow - Design Bulk Planting] Revise Tree Confirmation Screen

Milestone TBD - Will need to be implemented once features are built out.

[ ] #471
[ ] #510
[ ] #521
[ ] Renaming the "Planting" feature to "Add Tree" or something similar

Milestone Unfinished Tree Data Saved for Later

[x] #582
[ ] [Planting Flow - Design] Add Multiple Planters to One Tree
[ ] [Planting Flow - Design] Request Tree to be planted by city

@zoobot  what are your thoughts on this epic? Do you think we need to add anything?

For planting flow, it would be great to have a "request"/"planting" toggle, that way some of the health fields would make more sense divided up. Request could notify the city you want a tree in your empty vacant, stump, dead, missing tree hole. Or just report a dangerous condition with a dead overhanging tree or something.
We'd also need to keep in mind many people plant and track their own trees.

Question about this, is the idea to have the request be part of the tree health / status input field? Or a separate field? I was thinking if a user labels a "vacant tree lot" then it would notify the city? Or do we want to be more specific? I guess the tree taxonomy would help in this situation plus that integration you mentioned in the greener jc meeting (about requesting trees that would go directly to the city).

@zoobot what feature do you want to see next for planting? Is it bulk planting or is it requesting / maintenance from the city? Or something different? I am trying to map out what needs to be done for the next design.


_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 37s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  3s
Maven dependency ordering for patch

+1 :green_heart:
hadolint
0m  1s
There were no new hadolint issues.

-0 :warning:
pylint
0m 15s
The patch generated 6 new + 7 unchanged - 35 fixed = 13 total (was 42)

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 36s
patch has no errors when running spotless:check.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  3s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 34s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  3s
Maven dependency ordering for patch

+1 :green_heart:
hadolint
0m  1s
There were no new hadolint issues.

-0 :warning:
pylint
0m 12s
The patch generated 2 new + 5 unchanged - 37 fixed = 7 total (was 42)

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 33s
patch has no errors when running spotless:check.

_ Other Tests _

+0 :ok:
asflicense
0m  1s
ASF License check generated no output?

3m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4851/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4851

Optional Tests
dupname asflicense spotless pylint hadolint shellcheck shelldocs

uname
Linux adf77646f976 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5e251c49d0

pylint
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4851/2/artifact/yetus-general-check/output/diff-patch-pylint.txt

Max. process+thread count
33 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4851/2/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6 hadolint=1.17.5-0-g443423c pylint=2.4.4

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add getSerialNumber

Coverage increased (+0.09%) to 74.46% when pulling 7f28ca5f520b44472f67a6a918d628c7644e7767 on feature/get-serial-number into 290f4bda7e5e51865da3fe112520c453fdb46b30 on master.


Column wise operator, filter and slice row

What this PR does / why we need it:

In this PR, we add new capabilities in standard transformer:

Conditional Update
Column wise operator
Filter row
Slice row
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

https://user-images.githubusercontent.com/2369255/160731414-199675b7-8817-4815-a8cb-95f198894aab.mov

Checklist

[X] Added unit test, integration, and/or e2e tests
[X] Tested locally
[X] Updated documentation
[ ] Update Swagger spec if the PR introduce API changes
[ ] Regenerated Golang and Python client if the PR introduce API changes

Can you rebase?

Can you check why the CI is failing? What's the video resolution? It seems very blurry, I am not sure if github perform compression but can you set the resolution to at least 720p?


fix: deploy-image for sdk to generate the bundle with the apis created by it

Description
fix deploy-image for sdk to generate the bundle with the apis created by it
In SDK we need to update the manifests with the APIs created so that we can generate the bundle.

We did not release it yet and we have the changelog to add the plugin. So, would we need to have one to fix at well? WDYT I think we can move without one in this case.

We did not release it yet and we have the changelog to add the plugin. So, would we need to have one to fix at well? WDYT I think we can move without one in this case.
@camilamacedo86 I think that even though we haven't released it yet, it might be nice to mention that we added the functionality to build bundles separately from adding the plugin itself. I don't think in the description we need to include the word fix, but rather just say something like: deploy-image/v1alpha - add functionality to generate bundles for apis created with this plugin


DedicatedHostReboot

Resource Provider

Microsoft.Compute
Description of Feature or Work Requested

The new API allows users to restart their dedicated host.
Minimum API Version Required

July 2021
Swagger Link

Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/16737
SDK PR: https://github.com/Azure/azure-sdk-for-net/pull/25258
Powershell Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1087
Target Date

January 2022

@vbhasker-msft  The new commands and parameters that CLI needs to support are designed as follows.
New command: az vm host restart
New parameters: --resource-group/g, --dedicated-host-group, --dedicated-host
Do you think this meet the expectations?

@vbhasker-msft By the way, I plan to release this feature on 2022-02-01, do you think this date is acceptable?

@zhoxing-ms  Yes, that date is acceptable
Yep, those parameters are good.

@zhoxing-ms  Yes, that date is acceptable for me.
Yep, those parameters are good.
@smotwani Is this acceptable?

Yes, it is acceptable.

Hi, @vbhasker-msft , when I use az vm host restart, the service return (BadRequest) Operation 'restart' is not supported on the resource 'my-host', are there any restrictions on the host?
vm host info:
{
"autoReplaceOnFailure": true,
"hostId": "869e8e2d-5bd4-4cfc-a0d5-7da5064268e4",
"id": "/subscriptions/mysub/resourceGroups/myrg/Microsoft.Compute/hostGroups/my-host-group/hosts/my-host",
"instanceView": null,
"licenseType": null,
"location": "westus",
"name": "my-host",
"platformFaultDomain": 2,
"provisioningState": "Succeeded",
"provisioningTime": "2022-01-07T07:23:40.988401+00:00",
"resourceGroup": "myrg",
"sku": {
"capacity": null,
"name": "DSv3-Type1",
"tier": null
},
"tags": {
"foo": "bar"
},
"timeCreated": "2022-01-07T07:23:38.816516+00:00",
"type": "Microsoft.Compute/hostGroups/hosts",
"virtualMachines": [{
"id": "/subscriptions/mysub/resourceGroups/myrg/providers/Microsoft.Compute/virtualMachines/myvm",
"resourceGroup": "myrg"
}]
}


Input drops to almost nothing when using FaceTime

Hi, I downloaded eqMac to try to boost the volume when I use FaceTime. However, my input disappears to almost nothing when I turn eqMac on, according to the people I'm talking to. I am just using my built-in speakers/microphone, and don't really want to use earbuds/headphones. Is there a way to make it so that my regular built-in microphone works on FaceTime with eqMac enabled to boost the output volume?

Hi, this is a known issue that we are trying to fix. There is already an open issue regarding this. #605 So I am closing this issue as it is duplicate to that.


feat: Lists and extension sets with splicing

This PR allows lists and extension sets in hugr-model to splice lists and extension sets, e.g. [0 xs ... 1 2 3]. This is used to import and export rows and extension sets with variables. Closes #1609.

Yeah, I was also wondering about functional style lists. This is one of a few attempts, which turned out to be the most natural. I also tried an option where there was Term::ListEmpty, Term::ListCons and Term::ListConcat. However the code to handle these turned out quite tedious.

Looks good to me!


[BUG] Azure.AI.TextAnalytics.AnalyzeActionsOperation throws System.NullReferenceException

Describe the bug
I am trying to pick up a previously created Text Analytics job using the async API through the
public AnalyzeActionsOperation(string operationId, TextAnalyticsClient client);

constructor. When calling something like GetValuesAsync() on that operation, the call throws a NullReferenceException.
However, I can see that the job succeeded when doing a HTTP GET on ..../text/analytics/v3.1/analyze/jobs/{operationId}
Expected behavior
I would expect that I can pick up the results from my Async Operation using the operationId. In my scenario, I can't keep the AnalyzeActionsOperation that the StartAnalyzeActionsAsync() call returns alive, but need to pick up the result independent of the job creation.
Actual behavior (include Exception or Stack Trace)
Calls like WaitForCompletionAsync or GetValuesAsync throw a NullReferenceException:
System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=Azure.AI.TextAnalytics
  StackTrace:
   at Azure.AI.TextAnalytics.Transforms.<>c__DisplayClass39_0`1.<SortHeterogeneousCollection>b__0(T result)
   at System.Linq.EnumerableSorter`2.ComputeKeys(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.ComputeMap(TElement[] elements, Int32 count)
   at System.Linq.EnumerableSorter`1.Sort(TElement[] elements, Int32 count)
   at System.Linq.OrderedEnumerable`1.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Azure.AI.TextAnalytics.Transforms.SortHeterogeneousCollection[T](List`1 collection, IDictionary`2 idToIndexMap)
   at Azure.AI.TextAnalytics.Transforms.ConvertToAnalyzeSentimentResultCollection(SentimentResponse results, IDictionary`2 idToIndexMap)
   at Azure.AI.TextAnalytics.Transforms.ConvertToAnalyzeSentimentActionsResults(AnalyzeJobState jobState, IDictionary`2 idToIndexMap, IDictionary`2 tasksErrors)
   at Azure.AI.TextAnalytics.Transforms.ConvertToAnalyzeActionsResult(AnalyzeJobState jobState, IDictionary`2 map)
   at Azure.AI.TextAnalytics.AnalyzeActionsOperation.<Azure-Core-IOperation<Azure-AsyncPageable<Azure-AI-TextAnalytics-AnalyzeActionsResult>>-UpdateStateAsync>d__55.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at Azure.Core.OperationInternal`1.<UpdateStateAsync>d__35.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Azure.Core.OperationInternal`1.<UpdateStatusAsync>d__34.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at Azure.Core.OperationInternal`1.<UpdateStatusAsync>d__29.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at Azure.AI.TextAnalytics.AnalyzeActionsOperation.<UpdateStatusAsync>d__49.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()

To Reproduce
Running the following code reproduces the issue:
            var textAnalyticsClient = new TextAnalyticsClient(new Uri("https://westeurope.api.cognitive.microsoft.com"), new AzureKeyCredential(subscriptionKey));

            var actions = new TextAnalyticsActions
            {
                DisplayName = "TestName",
                AnalyzeSentimentActions = new List<AnalyzeSentimentAction>() { new AnalyzeSentimentAction() }
            };
            var documents = new[] { new TextDocumentInput("testId", "This is a test.") };

            var operation = await textAnalyticsClient.StartAnalyzeActionsAsync(documents, actions).ConfigureAwait(false);

            // this call works fine
            await operation.WaitForCompletionAsync();

            var newOperation = new AnalyzeActionsOperation(operation.Id, textAnalyticsClient);

            // this call fails
            await newOperation.WaitForCompletionAsync().ConfigureAwait(false);

Environment:

Package: Azure.AI.TextAnalytics 5.1.0

I'm running on .NET Core 3.1.20
Thanks!

@HenryvanderVegte  thank you so much for reporting this. I confirm I am able to reproduce the issue and understand the problem.
What is happening is that we are trying to organize the output with the input of the documents, but when rehydrating an AnalyzeActionsOperation we don't know what the output was, so our code fails.
I have created a quick fix and was wondering if you could give it a try and let me know if this solves your issue.
Here is the package: https://dev.azure.com/azure-sdk/public/_packaging?_a=package&feed=azure-sdk-for-net&package=Azure.AI.TextAnalytics&protocolType=NuGet&version=5.2.0-alpha.20211005.2&view=overview
The concern with the fix provided here, is that we won't be able to guarantee that a document and its result will have the same index in the input and result collections.
How will this impact you?

Thanks @HenryvanderVegte . We are looking into other strategies that will also preserve the input order.
Once we have a package for you to test I will let you know.
Apologies for the inconveniences this is causing you

okay, thanks - looking forward!

Hello @HenryvanderVegte,
We have released version 5.1.1 of Azure.AI.TextAnalytics today, and we believe it fixes the issue you reported. Could you give it a try? Please be aware that operation IDs created with version 5.1.0 or below of the SDK still won't work. Only long-running operations started with 5.1.1 can be recovered.

Hi @kinelski,
sorry for the delayed response. I can confirm now that this works, thanks a lot for your help!


How to use as a UIView subclass

Hi
I came across this library and you guys have done an awesome work. I want to ask an question that how can I use it as UIView component not UIViewController Component

ZSSRichTextEditor does not currently work outside of a subclassed UIViewController.


Can't connect two identical Terra AC chargers

It seems like I'm facing issues where the OCPP server mixes up the serial numbers for the two Terra AC chargers that I'm trying to connect to the same OCPP server @port 9000. Can you please advice how the device & entities is completely deleted or how it can be rectified? When I connect both the OCPP mixes them up and none of the chargers are working. Only one at the time where the only way I can identify the right charger is to disconnect the other one from the OCPP.
home-assistant_ocpp_2023-09-17T16-45-26.794Z.log

The home assistant OCPP integration currently only supports one charger per server. If you want to use multiple chargers then you should create multiple servers, with different ports (e.g. 9000 and 9001)

Okey. I created two servers and changed the names of the servers and chargers to new ones that haven't been used before and used the Alias from the Terra chargers. Then it did work. Thanks for such quick reply.


Rename public structs

IMO, the types exposed by the crate have a bad "stutter" problem. It'd be much easier to just rename:

GraphQLQuery → Query
GraphQLBody → Body
GraphQLResponse → Response
GraphQLError → Error

collisions should be dealt with on the use side of things (e.g., a crate may rename them back to GraphQL prefixes, it may be easier to use a Http prefix, or possibly just use them scoped).

Yep it's reasonable. It's not a conscious decision, but I think the current names are aligning with what I read in the juniper and apollo-client codebases.
I need some more time (and maybe input from others) to think about it - let's gather the discussion in this issue.

For another example, see this rename in the log crate.

I’m generally in favor of renaming.


Start SSH Server

I want to start ssh service just after docker startup
in my Dockerfile
FROM accetto/ubuntu-vnc-xfce-g3:24.04
....
RUN sed -i '234i\sudo /etc/init.d/ssh restart' /dockerstartup/startup.sh
RUN echo "headless ALL = (ALL) NOPASSWD:/etc/init.d/ssh" > /etc/sudoers.d/headless_sshd
....
no effect at all
what should i do, can you please help me?

Hello,
an SSH server is not included in this image. However, you can install it yourself in a running container:
sudo apt-get update
sudo apt-get install openssh-server

If you need it permanently, you can customize the Dockerfile and to install and configure it there. Then you can build your own images using the Dockerfile.
Regards,
accetto

sorry for incomplete code
I installed openssh-server in my dockerfile and tried to run it  in /dockerstartup/startup.sh just as
in my Dockerfile
FROM accetto/ubuntu-vnc-xfce-g3:24.04
....
RUN apt update && apt install openssh-server -y
…
RUN sed -i '234i\sudo /etc/init.d/ssh restart' /dockerstartup/startup.sh
RUN echo "headless ALL = (ALL) NOPASSWD:/etc/init.d/ssh" > /etc/sudoers.d/headless_sshd
....
It was ok to run it manually but no effect from startup.sh

latest update
insert "sudo /etc/init.d/ssh restart" to the very begin in /dockerstartup/startup.sh can resolve my question
thanks a lot

Close it

Close


Reactivestack typings

I would like to make a request for react-cookie to have typescript type definitions added. I want to use react-cookie in a project, but I need typings because I write all my React apps in tsx. Makes error catching much smoother.

I would be happy to include the TypeScript defintions with the library if somebody can make a PR. I don't have much time for this unfortunally and I'm only fluent with FlowType.

Hi gents, I know as I am writing this that I won't be able to do this properly with a PR and possible fixes afterwards. However, I still think somebody might find these useful and they can even end up being official eventually. These are react-cookie typescript typings done in a hurry. I'll update it here if I make any fixes.
declare module 'react-cookie' {
    import * as React from 'react';

    export type Cookie = string;

    export class CookiesProvider extends React.Component<{},{}>{}

    export function withCookies<T extends ReactCookieProps>(Component:React.ComponentClass<T>): React.ComponentClass;

    export interface ReactCookieGetOptions{
        doNotParse?: boolean;
    }

    export interface ReactCookieGetAllOptions{
        doNotParse?: boolean;
    }

    export interface ReactCookieSetOptions{
        path?: string;
        expires?: Date;
        maxAge?: number;
        domain?: string;
        secure?: boolean;
        httpOnly?: boolean;
    }

    export interface ReactCookieRemoveOptions{
        path?: string;
        expires?: Date;
        maxAge?: number;
        domain?: string;
        secure?: boolean;
        httpOnly?: boolean;
    }

    export type ReactCookieProps = {
        cookies: {
            get: (key: string, options?: ReactCookieGetOptions) => Cookie;
            getAll: (options?: ReactCookieGetAllOptions) => Cookie[];
            set(name: string, value: string, options?:ReactCookieSetOptions);
            remove(name: string, options?:ReactCookieRemoveOptions);
        }
    };
}

Missing class:
export class Cookies {
    get: (key: string, options?: ReactCookieGetOptions) => Cookie;
    getAll: (options?: ReactCookieGetAllOptions) => Cookie[];
    set(name: string, value: string, options?: ReactCookieSetOptions): void;
    remove(name: string, options?: ReactCookieRemoveOptions): void;
}

That's basically copy paste from what comes into props, isn't it? Would be better to share that among the 2 then. But yep that's right, I admit I only did the ones I use :)

Yes :)

@eXon Would you be so kind as to update the npm package for react-cookies so the typings are included? I would be willing to work on typings for the remainder of the "cookies" packages.

@eXon The the packagejson was right, but typings were not in latest npm release.

@Guymestef The Cookies typing seems to prevent you from constructing an instance of Cookies with new Cookies([string])


Upgrade to Pillow>=3 api

Fix for #191.

Current coverage is 86.38% (diff: 100%)

Merging #192 into master will increase coverage by 0.07%

@@             master       #192   diff @@
==========================================
  Files            17         17
  Lines          2155       2152     -3
  Methods           0          0
  Messages          0          0
  Branches        242        242
==========================================
- Hits           1860       1859     -1
+ Misses          243        242     -1
+ Partials         52         51     -1

Powered by Codecov. Last update 5fc0f76...fc99b2c

LGTM.  just to clarify, the modified code also works for PILLOW 2.x?

I have only tested with Pillow 3.3. However, it seems tostring() has been deprecated since version 2.2: https://github.com/python-pillow/Pillow/blob/2.2.x/PIL/Image.py#L560

Thanks @asnt

@asnt we're listing names of contributors to every release in the release notes. For the next release those notes are in gh-206. We'd be happy to list your name instead of your Github handle if you tell us what it is.


How do I add my own service to gatt_security_server? (IDFGH-13301)

Is your feature request related to a problem?
How do I add my own service to gatt_security_server?Currently I have successfully added the service in gatt_server, but I can't connect with the phone, only using gatt_security_server I can connect with the phone properly, so I would like to ask how to add my own service in that routine, looking forward to your reply, thank you very much!
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response

In the esp-idf/examples/bluetooth/bluedroid/ble/gatt_server example, the SMP (Security Manager Protocol) feature is disabled. As a result, some phones may not respond to pairing requests and may disconnect shortly after connecting.
The esp-idf/examples/bluetooth/bluedroid/ble/gatt_security_server example has the SMP feature enabled. If you intend to use this with a phone, I recommend using the esp-idf/examples/bluetooth/bluedroid/ble/gatt_security_server example.
You can refer to the service creation process in this example to create your own services.

@esp-zhp Thank you very much for your reply!

If there are no further issues, please close this issue.


the word "actions" is a keyword

We have a schema with many proprieties and two of them are something like this:
actions: {
   type: Array,
   optional: true
},
'actions.$': {
   type: ActionSchema,
}

And these are not saved in the database because the actions is a reserved key. One of the errors was: Actions must be of type string. We renamed actions in something else and all worked like magic.

I think the reserved word is action. Just had the same issue, took me a couple of hours to figure it out.


Duration of task should be 0 for Cumulative constraint when capacity is insufficient

Hi,
I am trying to use the CP-SAT solver to find a solution for a Cumulative constraint where the durations are integer variables.
When the required resource of a task exceeds the total capacity I would assume the duration of the task is put to 0.
However, in the following example this is not the case and the solver does not find a solution:
from ortools.sat.python import cp_model as ort

model = ort.CpModel()
solver = ort.CpSolver()

start = [model.NewIntVar(0,4,f"start_{i}") for i in range(3)]
end = [model.NewIntVar(0,4,f"end_{i}") for i in range(3)]

dur = [model.NewIntVar(0,1,f"dur_{i}") for i in range(3)]
# dur = [1,0,1]

intervals = [model.NewIntervalVar(s,d,e,f"{s}-{d}-{e}") for s,d,e in zip(start,dur,end)]

model.AddCumulative(intervals, [1,5,1],1) # requirement of second task exceeds capacity

# solver.parameters.cp_model_presolve=False
status = solver.Solve(model)

if status == ort.INFEASIBLE:
    print("Model is UNSAT")
else:
    print("Found solution")

>> Output: 'Model is UNSAT'

By uncommenting the line forcing the durations to [1,0,1] the model becomes SAT.
Also by disabling presolve the solver finds a solution.
I am using OR-tools version 9.7.2996 on Ubuntu 22.04.
Kind regards,
Ignace

Fixed on main.
Thanks for the report.


Report for Default Dashboard: GitLab Issues Closed per Month

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1767
Originally created by @dmor on 2020-02-20 15:14:40

Report type: bar chart
x-axis: time (month)
y-axis: number of issues closed

Replicate the dashboard found at https://gitlab.com/groups/meltano/-/insights/#/issues

View 2 previous comments from the original issue on GitLab


MS MARCO Passage Retrieval - Entire Set Replication

Same results were reproduced.
No issues were found.

Awesome, thanks again for replicating @Dahlia-Chehata !

Awesome, thanks again for replicating @Dahlia-Chehata !


Inconsistent results of Crystal::ASTNode::Call#id

After #14490, I checked if any other #to_macro_id implementation is also problematic. This is the one for Call:
https://github.com/crystal-lang/crystal/blob/562fb7bf7a580fa915c5ac7330c362ac4d19a564/src/compiler/crystal/macros/methods.cr#L2158-L2164
It looks like the @name branch is for Call nodes that have no arguments at all, but this misses a few cases:
macro foo(x)
  {{ x.id }}
end

foo(bar(&a))   # => bar
foo(bar(a: 1)) # => bar

It also most certainly suffers from the same issue as https://github.com/crystal-lang/crystal/issues/14489#issuecomment-2056950608 regarding global Calls:
foo(::bar)       # => bar
foo(::bar(1))    # => ::bar(1)
foo(::bar(a: 1)) # => bar

The implementation should probably just delegate to #to_s.
I'm even wondering why we even have a separate #to_macro_id. Shouldn't #to_s always be correct?

{{ 'a'.id }} is just a, not 'a'.

Yeah right. Besides these exceptions?

I mean for every other type than CharLiteral and StringLiteral, #to_macro_id could be identical to #to_s.

There is also SymbolLiteral#to_macro_id which drops the leading :. But I think the point is that the defined overloads avoid having to create a fresh Crystal::ToSVisitor every time ASTNode#id is called.


Parent Link wrong set...

Hi, I have problems having the right parent link.
router is :
for Child (vendor)
.state('edit vendor', {
url: '/vendor/:vendorId/edit',
templateUrl: 'vendor/views/edit.html',
ncyBreadcrumb: {
label: '{{vendorCompany}}',
parent: 'portal by id'
}
})
for the Parent (portal) :
.state('portal by id', {
url: '/portal/:portalId',
templateUrl: 'portal/views/view.html',
ncyBreadcrumb: {
label: '{{portalCompany}}',
parent: 'all portal'
},
resolve: {
loggedin: checkLoggedin
}
})
In breadcrumb is shown everything OK :

but the link is without the parent Id! I really do not know how to continue. Can someone help me?
It's common issue like here : #107
can someone help?

see if this can help: https://github.com/ncuillery/angular-breadcrumb/issues/157#issuecomment-275435735


fix: Support windows by replacing zip command.

Fixes #93
Currently, deploying on Windows fails because the zip file generation command is written for Linux / MacOS.
I added the command to spawn powershell and generate zip with Compress-Archive command. This should work in any modern Windows environment.

If the change is ok, please merge and release the new version

@Lagyu, which package manager did you use to get this (powershell Compress-Archive) to work? I'm trying to use PNPM on windows but getting symlink errors.


[Semantic API] NodeFinder captures variable decl itself

Currently the NodeFinder captures the BLangSimpleVariable even if the range is given for the def stmt itself. This isn't causing issues. Hence closing this.

Currently the NodeFinder captures the BLangSimpleVariable even if the range is given for the def stmt itself. This isn't causing issues. Hence closing this.


Support watchOS and tvOS

Add watchOS and tvOS targets to the project to support them.

A colleague of mine indicated that there is an issue with Swinject and Xcode 7.1 beta 2 (Swift 2.1)
I've done this already in https://github.com/jondwillis/Swinject/blob/master/Swinject.podspec

Thank you for trying Swinject with tvOS because I still didn't try. It looks I can merge the podspec later.
A problem here is supporting watchOS is not so straightforward because UIStoryboard class is not accessible in watchOS. I might split SwinjectStoryboard into another project, and might keep Swinject project as pure Swift code to easily modify the core features for all the targets (iOS, OSX, watchOS and tvOS).
In contrast, Supporting SwinjectStoryboard in tvOS looks ok.

Swinject version 0.2.3 supports watchOS.

tvOS is supported in xcode7.1 branch. To install Swinject with CococaPods or Carthage, specify the commit 6f55e9caae24dc059874a338b3be5086393f1f40 or later.

@jondwillis, I didn't merge your commit but it was a good guidance to modify the podspec to support watchOS and tvOS. Thank you.

Version 0.4 supports tvOS too.


element_interface imported but not in requirements

Bug Report
Description
element_interface is imported: https://github.com/datajoint/element-deeplabcut/blob/0c71ecbd60730a322b6631de1667155fde1f3bbe/element_deeplabcut/model.py#L16
but not in requirements.txt, so the package cannot be imported.
duplicate of https://github.com/datajoint/element-array-ephys/issues/66

Thanks for the report @sneakers-the-rat.  We opted not to keep element-interface in the requirements.txt because element-interface is used to install third-party packages, some of which are not on PyPI.  From what I understand, all packages within the requirements.txt or setup.py must be published to PyPI in order for the package of interest to be published to PyPI.  Please let us know if you have any suggestions as we are trying to find a cleaner way of setting up these dependencies.

you can require something from git in a requirements.txt file!
package-name @ git+https://github.com/whatever/repo@branchname

see https://pip.pypa.io/en/stable/topics/vcs-support/
I have several packages on PyPI that have git dependencies, so it's definitely allowed! for example: https://github.com/wehr-lab/autopilot/blob/637064da3d10e9eeb186483827c8b7dadaa2f356/pyproject.toml#L55


Update nf-winuser-postmessagew.md

GetLastError returns ERROR_NOT_ENOUGH_QUOTA when the limit is hit.

The above sentence was at the end of the "returns" section. It looks like copy-pasta to me, so I removed it.

Rather than removing the comment about ERROR_NOT_ENOUGH_QUOTA, it should instead be moved to the Remarks section of the article. GetLastError returns ERROR_NOT_ENOUGH_QUOTA when PostMessage fails due to exceeding the posted message limit described in the Remarks section.

Accepting this request to remove info from the Returns section. I've submitted a separate PR to add the info to the remarks as suggested by @cts-davean.


 CTRL+R (really handy), copy/paste (well..), writting Polish diacritics like ALT+A for "ą" or ALT+O for "ó" or any other. Every combination I try with CTRL or ALT is blocked except for CTRL+H for hiding/showing log monitor.
When I build my files with production env (so disabled devtools) - everything works without any problems.

This was fixed in https://github.com/gaearon/redux-devtools-dock-monitor/pull/2.
It will be published with next release.

Oh sorry then, I've checked the wrong repo..


New version: Vivaldi.Vivaldi.Snapshot version 6.10.3468.4

Created by 🥟 Dumplings in workflow run #8124.

Log
Updated: 6.10.3466.4 → 6.10.3468.4
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

This package installs and launches normally in a Windows 10 VM.


MSVCP140D.dll error when trying to open

Every time I try to open the program, I get this error. I have all Visual Basic installed on my computer
Can you tell me what could be going on?

Download Visual C++ 2005 to 2022
Because this EAC Bypass coded on C++ and C

Unfortunately for me it still does the same :
Thank you anyway


Redesign Phase 1 - Building the Encounter

Hi all,
I've completed the first phase of the redesign I've been working on for Kobold.club.  I use this site a ton and realized it could do with a lot of design love.  So a web site designer at my work and I decided to spend some free time and redesign it.  Hopefully it keeps to the core of what @Asmor was trying to do and he likes what I've done.
There's a lot of code changed so I wanted to try to give a good write-up of everything I did and why.
Design Goals:

Keep the core site structure and behavior the same, to avoid alienating core users.
Update the design to a more modern look and feel
Focus on information hierarchy to prioritize the more important components of the site

Make prime components such as party layout, search, and monster names/quantities bigger
Minimized the noise of less important components like some of the filters and the legend of difficulties

Even out the information density in different parts of the site to make it easier to use and read

Redistribute the dead space in the monster table to provide more information in the same space

Allow basic usage through mobile/tablet or at least make it possible to use the site awkwardly.

Coding Goals:

Convert the project to a node module for easier development

This made my life easier but could just as easily be ripped out

Add in Twitter Bootstrap for an easy interface baseline

My Redesign Phases
Since this is such a large scale redesign, I really wanted to do it in parts.  I'm organizing myself to finish things in phases.
Phase 1. Redesign the Encounter Builder page.  This will likely be the biggest part.
Phase 1.5. Code refactoring, further design tweaks, any bug fixes.  The main part of this is a LARGE scale refactoring to move the site from using Angular partials to using the more modern patterns of Angular Directives and/or Components.  I don't want to do this without @Asmor giving the go ahead though.
Phase 2. Redesign the Manage Encounters page
Phase 3. Redesign the Run Encounter workflow and pages.
One note about the pull: I don't have pull request #21 included.  And also, we are going to want to update some of the Set Sources choices for Volo's I think.
Ok, now on to the reveal.  I've taken a bunch of screenshots below to hopefully give everyone a good idea of the new design without needing to boot up my fork.
I really want to hear everyone's feedback on this, thanks!
For a baseline, here is the current site.

And here is the redesign.

I also annotated the new site to show off the different design goals I was talking about.

Here are the old vs new designs when looking at a built encounter.

This is the new legend.  I've moved it out of the way so that it is only open if someone needs to understand the colors.

Customizing the sources you were using was a bit of an awkward process.  I've tried to streamline it.

Lastly, here is a comparison of the old vs the new on a mobile device.  I did a bit of work but I would like to do a lot more.

This looks phenomenal.

Phase 1.5. Code refactoring, further design tweaks, any bug fixes. The main part of this is a LARGE scale refactoring to move the site from using Angular partials to using the more modern patterns of Angular Directives and/or Components. I don't want to do this without @Asmor giving the go ahead though.

This was, I think, the second thing I ever did in Angular, and I'm quite embarrassed by that. If you want to put in the work to refactor things out to directives, you're more than welcome. I fully support that, but I didn't know to do it when I first wrote this and I don't really actively work on it much anymore.
Before I merge this pull request, I just wanted to confirm that node isn't necessary for deployment (I think I mentioned this to you in my email, but my web host doesn't allow node, and my "deployment" is basically just "git pull").

No need to be ashamed for this code.  You did a ton of work just to put it together and learn Angular enough to get it this far.  I'll start working on the refactor soon.  I'm definitely having a good time working on something that people use.
You make a really good point about node.  My intention was that node would be a dev-only resource for launching an http server and compiling sass.  I went back and double checked and node isn't required.  The only production pieces I added were added via CDN or downloaded manually to the third-party folder and checked it.  So we should be good.
On a side note, I don't do github much.  Once you've merged this pull request, how can I continue development?  Is there a way to rebase or merge your base master branch into my fork again?

I'm not all that familiar with forking myself, but I believe you just continue working in your fork and submit a new pull request whenever you think it's ready. You can also use fetch to make sure your fork is up to date with this version.
http://www.dataschool.io/simple-guide-to-forks-in-github-and-git/
https://git-scm.com/docs/git-fetch

I've merged this in and will be updating the site with it in a bit (it's actually live at http://kobold.club/fight-new right now). Just want to play with it a bit and make sure nothing major was broken.
I do have a couple suggestions for future changes...

Make the CR column either center- or left-aligned
Make the column widths static (right now they jump around when you page depending on the contents of that particular page).

Just testing some values out real quick, I think these would make good good settings for the columns (although I'm looking at this on desktop, so might not make sense on mobile)
Source: 200px
Alignment: 120px
Type: 120px
Size: 100px
CR: 30px
Name: *
Button: 49px

Oh, the text in the buttons for running an encounter has lost its vertical centering
Current:

Original:

Yeah, I was noticing the messed up buttons on the other pages.  I spent minimal time on those pages.  I think I'll spend a bit of time this evening changing all those buttons to Bootstrap (giving them the "btn btn-sm" classes) which will fix their styling.  A lot of what I did was to rip out the custom css in favor of Bootstrap's which is a bit more elaborate and exact.
Good idea on the column widths.  I'll try out a few things.  The super long source names usually muck up things so some jumping around may be a good thing, but standardizing the columns with mostly same-sized data should be easy enough.

It's live now at the regular address. Last thing I noticed was that it doesn't highlight when you have filters enabled (i.e. under the old one, if I specified an environment, that filter would get a yellow background to show it was active). This is helpful because otherwise it's easy to forget you have filters active...
For the sources, I'm thinking it might make sense to give every source a short hand (e.g. Monster Manual = MM) and use that, with the full name in a title attribute so you can see it on mouse over. Could also add the full names to the legend.

Hmm, seems to be broken for me.

I think there's a caching issue with the CSS or something. I had to clear my cache to get it working.

Seems to be some kind of caching issue.  It REALLY wanted to hang onto the other html files it was pulling in.

Yep, all working now.

Oh, it was the HTML and not the CSS? That makes sense... The browser's caching of HTML files that it fetches via AJAX ignores reloading the page, even if you do the shift+reload
Still really obnoxious, and probably going to be a problem for visitors... I'll look into adding a cache-busting param to the files

Yeah, the CSS is all one big compiled file, so a Shift+F5 fixed that.
However, the other html files didn't want to refresh.
Cache-busting might be a good short term fix.  At my work we use gulp to
compile all the angular files into a single CSS and a single JS/HTML.  It
automatically adds that param.  When I do the refactoring I might use that.
But yeah, for now we're a bit screwed.
On Sun, Nov 20, 2016 at 12:43 PM Ian Toltz<EMAIL_ADDRESS>wrote:

Oh, it was the HTML and not the CSS? That makes sense... The browser's
caching of HTML files that it fetches via AJAX ignores reloading the page,
even if you do the shift+reload
Still really obnoxious, and probably going to be a problem for visitors...
I'll look into adding a cache-busting param to the files
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/pull/22#issuecomment-261796339, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdyRqgpOyoVNhFDPHy4GxQ4X87nRQvCks5rAJS_gaJpZM4K3fEx
.

And in reply to your earlier comment:
I intentionally ditched the highlighting on the filters for now.  If you
feel like you miss it, and its really easy to miss having a filter, I'll
start thinking up another way to highlight them.  Shouldn't be that hard to
do something that brings attention.
Yeah, I deliberated on some kind of way to show what sources were chosen
without having to open the modal.  In the end, I thought this way fine for
now, but annoying, and I'd brainstorm ideas with my designer on Monday.
On Sun, Nov 20, 2016 at 12:46 PM Joe Barzilai<EMAIL_ADDRESS>wrote:

Yeah, the CSS is all one big compiled file, so a Shift+F5 fixed that.
However, the other html files didn't want to refresh.
Cache-busting might be a good short term fix.  At my work we use gulp to
compile all the angular files into a single CSS and a single JS/HTML.  It
automatically adds that param.  When I do the refactoring I might use that.
But yeah, for now we're a bit screwed.
On Sun, Nov 20, 2016 at 12:43 PM Ian Toltz<EMAIL_ADDRESS>wrote:
Oh, it was the HTML and not the CSS? That makes sense... The browser's
caching of HTML files that it fetches via AJAX ignores reloading the page,
even if you do the shift+reload
Still really obnoxious, and probably going to be a problem for visitors...
I'll look into adding a cache-busting param to the files
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/pull/22#issuecomment-261796339, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdyRqgpOyoVNhFDPHy4GxQ4X87nRQvCks5rAJS_gaJpZM4K3fEx
.

You're going to want to update your fork before doing any work. Adding cache busting required me to alter the indentations of several files (which had previously just been defining an object, but now need to define a function that returns an object).
I added a new constant for version, and just appended that to all HTML files.

Here are a couple suggestions for highlighting active filters:

Updating my code now.
I like the first suggestion.  I was leaning towards something like that but
maybe trying to make the font bold as well.
On Sun, Nov 20, 2016 at 1:07 PM Ian Toltz<EMAIL_ADDRESS>wrote:

Here are a couple suggestions for highlighting active filters:
[image: image]
https://cloud.githubusercontent.com/assets/2127204/20465415/897db090-af2a-11e6-959d-e8ad6dccd9f8.png
[image: image]
https://cloud.githubusercontent.com/assets/2127204/20465417/9fe33f80-af2a-11e6-8051-f199ae67a72c.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Asmor/5e-monsters/pull/22#issuecomment-261797811, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADdyRugif6UOk_MIJGE8LQgU-WoZS7foks5rAJphgaJpZM4K3fEx
.

FYI, I went ahead and added support for shorter names (the longest one, I think, is HoardSup for the Hoard of the Dragon Queen online supplement. Short names will be used when the screen is narrower than 768px, which is the same break point where the top menu gets folded in.


feat: add slsa verification and publish

Description
Adds slsa to Pepr release process. Now, in npmjs this includes only dist and package.json, LICENSE, and README.md, which is what is necessary to run the CLI. I think this is okay. Lets chat further about this.
https://www.npmjs.com/package/peppr?activeTab=code
┌─[cmwylie19@Cases-MacBook-Pro] - [~/not-pepr/pepr] - [2024-07-29 11:35:08]
└─[0] <git:(938 1a9636b) > npx peppr -V
0.37.9-rc

Related Issue
Fixes #938

Relates to #
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

@daveworth 👀


build: replace insecure polyfill use in website

See https://blog.cloudflare.com/automatically-replacing-polyfill-io-links-with-cloudflares-mirror-for-a-safer-internet
Replace polyfill.io with Cloudflare alternative.
polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter. Since then, there have been concerns raised by the community, and main contributors
The concerns are that any website embedding a link to the original polyfill.io domain, will now be relying on Funnull to maintain and secure the underlying project to avoid the risk of a supply chain attack. Such an attack would occur if the underlying third party is compromised or alters the code being served to end users in nefarious ways, causing, by consequence, all websites using the tool to be compromised.
In July, the Sansec forensics team published a report revealing a supply chain attack targeting the widely-used Polyfill.io JavaScript library. The owners of this project began redirecting users to malicious sites and deploying malware.

Another benefit of being a Google project: this vulnerability was reported to us by Google security engineers.


add messaging for non-main branch without pr

the api currently requires that a pull-request be present when scanning a non-main branch
this poses a problem since circleci jobs will often trigger before the PR has been opened.
to work around this, we temporarily add an info message and noop

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/boostsecurityio/scanner?version=dev:b99d6ce6ff2b1d8bdc45d3c6f14e96be5286ed2a

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/boostsecurityio/scanner?version=4.0.1

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/boostsecurityio/scanner?version=dev:b99d6ce6ff2b1d8bdc45d3c6f14e96be5286ed2a

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/boostsecurityio/scanner?version=4.0.2


 :(

I use vscode, if you know how to fix the autowrapping in lines...

Your code has been rated at 9.63/10 (previous run: 9.37/10, +0.26)


import/no-unresolved doesnt respect package exports

If I import something from package foo, that has in it's package.json the following exports map:
"exports": {
  "./bar.js": "./src/bar.js"
}

The following import will cause an import/no-unresolved error, while being completely valid:
import 'foo/bar.js';

Duplicate of #1810.

I'd suggest making that package have an actual ./bar.js file, so that pre-exports nodes (and tooling) can locate the file also.

A better structural fix would be for tooling to catch up with package exports instead

Both fixes are needed; packages should remain backwards-compatible, instead of being hostile to those users.
Certainly this package, and the ecosystem's tooling, will eventually catch up as well.

packages should remain backwards-compatible, instead of being hostile to those users

The foo package I mentioned doesnt have this requirement

I gathered that - I'm saying that all packages should have that requirement.

I disagree with that, but I guess its besides the point. You mentioned that "eventually" this plugin will support package exports, the issue you linked has been open for 2 years, is there already work started to support package exports? If not, would you be willing to take a PR? I might be able to spend some time and take a stab at it

The work needs to be done in the resolve package; it has begun and is moving slowly.


Do not inject git:: to url when git 2.3.0 or above found

Related: #161
/cc @bruno-
This commit takes advantage of $GIT_TERMINAL_PROMPT variable added in git 2.3.0. So if the git installed on the system is 2.3.0 or above, vim-plug will not use git:: hack to prevent user prompt. However, the downside of the current implementation is that it runs git --version command on startup which should increase the startup time by a little.

There are two alternatives that come to mind:

Defer setting up URI until it's needed. However, this requires some changes in g:plugs structure.
Remove git:: part from uri using string substitution before update/install.

Implemented the second method. (We may need to revert the value of GIT_TERMINAL_PROMPT though.)

Hi @junegunn,
:+1:
Much more elegant code than if I had submitted a pull request.
Also, I updated vim-plug locally and tested it a bit and things seem to work fine.

Thanks. I appreciate your feedback!


netbox: not possible to omit externalDatabase password

Using the netbox chart 5.0.7 it is not possible to omit existingSecretPasswordKey.
I use Google CloudSQL with IAM based auth (via CloudSQL proxy), which does not need a password.
When setting the connection info like this, everything works:
externalDatabase:
    host: localhost
    port: 5432
    database: netbox
    username<EMAIL_ADDRESS>    password: ""

But when I try to use an existing secret with an empty password like so:
externalDatabase:
    existingSecretName: cloudsql-proxy-iam
    existingSecretHostKey: PGHOST
    existingSecretPortKey: PGPORT
    existingSecretUserKey: PGUSER
    existingSecretDatabaseKey: PGDATABASE
    existingSecretPasswordKey: PGPASSWORD

I get:
django.db.utils.OperationalError: connection failed: fe_sendauth: no password supplied

If I remove existingSecretPasswordKey completely, the chart fails with:
MountVolume.SetUp failed for volume "secrets" : references non-existent secret key: db-password

I think my usecase is not super common, but viable. Could you please change the handling of existingSecretPasswordKey, so it can be omited?

This is because I arrogantly assume that any external database should have password already.
Even as far as to do auto generate if it empty.
Will fix on next release.
external-db.yaml
data:
  db-password: {{ include "common.secrets.passwords.manage" (dict "secret" (printf "%s-%s" (include "netbox.fullname" .) "external-db") "key" "db-password" "length" 32 "providedValues" (list "externalDatabase.password") "context" $) }}


Add Nextflow for TES Regression testing

Problem:
For Nextflow TES add in this repo for regression testing
https://github.com/seqeralabs/nf-canary

To run Nextflow we will need the following requirements:
TES Task:
CPU: 2
Mem: 32 GB
Docker Nextflow: nextflow/nextflow:24.04.4
Command: nextflow run main.nf -w 'az://work'
Nextflow Config
plugins {
   id 'nf-ga4gh'
 }

process {
  executor = 'tes'
}

azure {
       storage {
          accountName =
          accountKey =
       }
    }

tes.endpoint=
tes.basicUsername =
tes.basicPassword =

process {
    container     = "docker.io/library/ubuntu:latest"
}


Handle failure when getting ResponseData

fix #23
added basic error handling in user_repos. I'm not sure if you prefer checking leading and trailing whitespace(s) in the token before calling the function.

Thanks for the PR! I'll take a look soon. I need to read up on error handling a bit as well.

I'm still learning Rust so I might have missed a few things. Let me know if you have any feedback. Thanks!


Problem in class TQuickAmazon.PutObject ( StreamToArray )

Problem in class TQuickAmazon.PutObject
The "StreamToArray" function is not converting the STREAM to ARRAY correctly. At the end of the file, null characters (<0x00>) are remaining.
To solve the problem I had to replace the function with the code below:
function ByteContent(DataStream: TStream): TBytes;
var
  Buffer: TBytes;
begin
  if not Assigned(DataStream) then
    exit(nil);

  SetLength(Buffer, DataStream.Size);
  // the content may have been read
  DataStream.Position := 0;
  if DataStream.Size > 0 then
    DataStream.Read(Buffer[0], DataStream.Size);

  Result := Buffer;
end;

Fixed in next version. Thanks for your report and solution.


Sample payload for "Log alert for Log Analytics" example is not complete

The sample payload is not complete in the first example. It doesn't have schema id like the second example for "Log alert for Application Insights".
https://docs.microsoft.com/en-us/azure/azure-monitor/alerts/alerts-log-webhook#log-alert-for-log-analytics

Second example - Log alert for Application Insights:
https://docs.microsoft.com/en-us/azure/azure-monitor/alerts/alerts-log-webhook#log-alert-for-application-insights

Please note, both are log search alerts and uses standard JSON payload and not common alert schema.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 181b6940-cfae-726c-6530-e7df76acb362
Version Independent ID: 603e4c70-b4e1-9f43-27fb-6072c398c774
Content: Webhook actions for log alerts in Azure alerts - Azure Monitor
Content Source: articles/azure-monitor/alerts/alerts-log-webhook.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @yanivlavi
Microsoft Alias: yalavi

@sachinpanwar Thanks for your feedback. We will review the issue and get back to you shortly.

@sachinpanwar @SwathiDhanwada-MSFT at the moment the payload is sent without the schemaId field and data object when a Log Alert for Log Analytics is used. So the sample payload for Log Analytics was correct and is now wrong.


Build fails on x32

Fails with these errors:
error[E0432]: unresolved import `std::arch::x86`
  --> src/x86/mod.rs:17:16
   |
17 | use std::arch::x86::{__m128, __m128i};
   |                ^^^ could not find `x86` in `arch`

error[E0432]: unresolved import `std::arch::x86`
  --> src/x86/mod.rs:19:5
   |
19 | use std::arch::x86;
   |     ^^^^^^^^^^^^^^ no `x86` in `arch`

error[E0432]: unresolved import `std::arch::x86`
  --> src/x86/swizzle_f32x4.rs:14:5
   |
14 | use std::arch::x86;
   |     ^^^^^^^^^^^^^^ no `x86` in `arch`

error[E0432]: unresolved import `std::arch::x86`
  --> src/x86/swizzle_i32x4.rs:14:5
   |
14 | use std::arch::x86;
   |     ^^^^^^^^^^^^^^ no `x86` in `arch`

Complete log here: https://buildd.debian.org/status/fetch.php?pkg=rust-pathfinder-simd&arch=x32&ver=0.5.1-1&stamp=1647460848&raw=0

Sorry, this was a horrible bug report, I shouldn't write those while tired.
The background for the bug report is that the Debian build system for rust builds all the different features, and also no features, and that makes the build of this crate fail for x32 in Debian.
Your suggestion about pf-no-simd is an excellent place to start digging into this problem, I will try to write a patch for it.


Reverse-mode auto differentiation didn't reject invalid axis input as expected for API tf.math.reduce_logsumexp

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
tf 2.9
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Input parameter axis for API tf.math.reduce_logsumexp should be at most rank 1. with input axis=[[0,1]],  which is rank 2 and invalid, It should throw ValueError in both line 11 and line 17. Now forward-mode autodiff threw error as expected but reverse mode didn't validate the axis parameter and passed.
Standalone code to reproduce the issue
import tensorflow as tf

input = tf.constant([[0.44943833]])

axis = [[0,1]]

with tf.GradientTape() as g:
    g.watch(input)
    # should throw ValueError here, because axis is rank 2, which is invalid, but didn't
    res = tf.math.reduce_logsumexp(input, axis, keepdims=False)
grad = g.gradient(res,input)
print(grad)

with tf.autodiff.ForwardAccumulator(input,tf.constant(1.,shape=[1,1])) as acc:
    # throw error as expected
    res_fwd = tf.math.reduce_logsumexp(input, axis, keepdims=False)
jvp = acc.jvp(res_fwd)
print(jvp)

Relevant log output
tf.Tensor([[1.]], shape=(1, 1), dtype=float32)
ValueError: Shape must be at most rank 1 but is rank 2 for '{{node gradient_tape/Sum}} = Sum[T=DT_FLOAT, Tidx=DT_INT32, keep_dims=false](gradient_tape/Cast, inputs_1)' with input shapes: [1,1], [1,2].

@gadagashwini I was able to replicate the issue on colab, please find the gist here for reference. Thank you!


Only send debug images referenced in the stacktrace

Description
Ref: https://github.com/getsentry/team-mobile/issues/158

Can be implemented for cocoa debug images similar to how react native does it.

@buenaflor replace getDebugImagesForAddresses with either SentryDebugImageProvider.getDebugImagesFromCacheForFrames or SentryDebugImageProvider.getDebugImagesFromCacheForThreads added in With https://github.com/getsentry/sentry-cocoa/pull/4435. getDebugImagesForAddresses is slow and caused AppHangs on iOS; see https://github.com/getsentry/sentry-cocoa/issues/4399.

this is unblocked now, 8.39.0 is out  https://github.com/getsentry/sentry-cocoa/releases/tag/8.39.0


Skip confirmations

C'mon kap move faster faster skip all this
macOS version:    19.0.0 (darwin)
Kap version:      3.0.0-beta.6
Current behavior:
Lots and lots of steps just to grab some jiffy to file!

Invoke Kap2 with shortcut (with a hyper key modification via Karabiner-elements, my hyper key is called 💩 so hyper+2 has shorthand 💩2)
Kap2 appears, I can click+drag to select area of screen
I click on "Record"
??? (but no profit!)
Kap2 moves to menu bar, but I don't really know when the first frame actually was recorded, because there is a lot of animation going on:

Screen outside selected area is dimmed
The dimmed area fades out so everything is visible
Some sort of animation that has the Kap2 circle shrink and expand before it turns to a black square in the middle, this animation I think happens simultaneously as the dimming dissappearing, but I'm not sure this is rendered the same every time.  (See below feature request, a way to solve this better IMHO.)
I take it when the icon turns to a black square in the middle the first frame is recorded, but running in HiDPI resolution on 27" iMac (pro) this square is visually very small, at least for my eyes.

I click on the  menu bar icon in order to stop the recording
Main window appears. I select, every time, the following information, to get it according to project requirements: width 320
FPS 12
Destination GIF and SAVE TO DISK is preselected from time to time which is great, now I click EXPORT
Filename. It is prepopulated with "Kapture 2019-10-07 at 13.03.19.gif" and I click SAVE

That is 10 steps to create a GIF animation from start to finish.
Wanted behaviour

Invoke with 💩2
Click+drag area of the screen, when I let go of the click, recording starts immediately, frame-perfect

(meaning a recording-cache or similar activates as poop 💩2 is pressed and/or poop+drag  commences, then all frames before end of click+drag flushed).
My poopkey is configured to rightAlt+rightCmd+rightShift+Ctrl simultaneously. So that means we can configure poop-drag 💩drag  such that 💩mouse1ReleasedAfterDrag have *Kap actually automatically start a recording just with the poopdrag.

That's it. Phew!

...was auto-configured to stop after 8 seconds unless stopped
After 8 seconds, autosave according to preset.
Filename  autopopulated just as today, but xattr metadata set correctly for each file:

URL/URI to what was recorded (browser link, link to file system etc) correctly formatted and stored in the com.apple.metadata:kMDItemWhereFroms extended attribute.
Because Finder is incredibly stupid, also add a plaintext copy of the above to com.apple.metadata:kMDItemFinderComment (*see below).

GIF properties: fps, width/aspect, compression, dynamic color palette settings and all other properties was already saved as a pre-set and was applied automatically.
Sharing/export properties was already saved as pre-set and applied automatically.

*notes:

because it is the only metadata field that can actually natively be added as a sortable column to Finders' ⌘2 list view.

This way you can see the file name and its source at the same time.
Kap2's job is to be really good at what it does (and it is! and getting better!) so all the logic of getting the file-name just the way people want it, should be deferred to other utilities, like Hazel or DevonThink3 or some other Folder Action script.
 Kap2 needs to write everything it knows about the scenario it recorded and stuff it in the file itself as extended attributes, and document this, the rest is the job of the community to contribute with. But source of recording (URL) and a real epoch time stamp should be provided at creation of file.

This got long, but creation of GIF animations is serious business, better get it right so the liquid uranium doesn't start leaking everywhere.

BONUS: Better visual menu bar representation

Kap2 is not recording: show circle as it is today but with a smaller, solid black circle in the middle if clickable. The ubiquitous symbol for not recording, start recording when clicked solid circle on outlined/not-solid background
Kap2 is recording: show circle filled red, with a smaller white filled square in the middle. Understood as now recording in progress, click to stop solid square on solid red background

alternatively show the "pause" icon smaller, in white solid icon, on solid red background. Understood as recording in progress, click to pause. [Optionally keep pressing and it will stop]

Thank you for the detailed issue and suggestions @haakonstorm! Have you tried the latest Kap beta? Would be great to hear your thoughts on it.

I can agree this is pretty detrimental to app usability currently. I don't need the editor; I don't need the choice to export or not; I don't want the export history window to popup. Just hotkey, drag, capture, copy to clipboard automatically. No popups or confirmations.


feat: Safety disable if sensor unavailable or not updated

Fixes #168

Hi, where is documentationm for this?

Sorry. it's here: https://github.com/swingerman/ha-dual-smart-thermostat?tab=readme-ov-file#outside-temperature-and-fan-hot-tolerance


Restful Endpoint with HTML content as payload?

My experience with Nodejs is limited, so someone might be able to help me:
Is it possible to make chromeless restful and take a POST payload as input that contains the HTML content to be rendered? The output should be a screenshot of the content.
I assume this would be doable through AWS Gateway & Lambda.
Thanks

Yes, create a new Lambda for it.

@k1p1l0
Hey! Can you show me an example, like send a login url(with user info by POST method) to remote headless Chrome  and return a logged-in page. I can't find an API in chromeless related to this issue. Thanks!

Hi @reinhoceros — I believe I've answered your same question on StackOverflow, so I'll close this issue here. 😃


clever-tools: 3.8.2 -> 3.8.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/CleverCloud/clever-tools/releases.
meta.description for clever-tools is: Deploy on Clever Cloud and control your applications, add-ons, services from command line
meta.homepage for clever-tools is: https://github.com/CleverCloud/clever-tools
meta.changelog for clever-tools is: https://github.com/CleverCloud/clever-tools/blob/3.8.3/CHANGELOG.md
Updates performed

NPM version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.8.3 with grep in /nix/store/5l0zyhxi0q18ls63lkr9sndq4y314i5k-clever-tools-3.8.3
found 3.8.3 in filename of file in /nix/store/5l0zyhxi0q18ls63lkr9sndq4y314i5k-clever-tools-3.8.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

clever-tools

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5l0zyhxi0q18ls63lkr9sndq4y314i5k-clever-tools-3.8.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clever-tools https://github.com/r-ryantm/nixpkgs/archive/952b83be9973c8b9d4294d647d22b4cb10940495.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/952b83be9973c8b9d4294d647d22b4cb10940495#clever-tools

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5l0zyhxi0q18ls63lkr9sndq4y314i5k-clever-tools-3.8.3
ls -la /nix/store/5l0zyhxi0q18ls63lkr9sndq4y314i5k-clever-tools-3.8.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

clever-tools

Maintainer pings
cc @florian-sanders-cc for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Xcode 6.4

This makes Alcatraz work again in Xcode 6.4 beta
There's an open issue, though, building with 6.4 didn't work for me, because the NIBs would actually not end up in the final bundle. Building Alcatraz with these changes using 6.3.1 would load just fine in 6.4 beta, though.  ¯\_(ツ)_/¯
Fixes #264

@neonichu you are the man

@neonichu thank you!

Thanks @neonichu !


Add Delta E 2000 function

Self explanatory. Works on #22.

Whoops, I didn't notice that.

Awesome, thank you very much!


Is JointBert save the best model that achieves the best results on dev ?

I would like to know whether if JointBert save the best model that achieves the best results on dev  or no ?

Sadly it doesn't

ok thank you


Animation not working when using OffscreenCanvas

Expected behavior
Animations work when using workers
Current behavior
Animations do not work
Reproducible sample
NA
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
V3.7.1
Browser name and version
No response
Link to your project
No response

@Waxolunist do you have a test case for this?

Closing as this is working as-designed

You could have had at least updated the documentation. I wasted my time to get ChartJS to work inside a web worker only to find out that animations won't work.


Update Dart language to latest version which supports null safety

we need dart null safety

Duplicate of #1673