[opencv4] Build the opencv4 with the MinGW compiler.

The current opencv4 ports cannot be built successfully with the mingw triplet on the windows platform.
The problem is related to the issue: https://github.com/microsoft/vcpkg/issues/23165 which is not solved actually.
I want to add the following code into the portfile.cmake file under the opencv4 port directory.
if(NOT MSVC)
  message(WARNING "The compiler is not Microsoft Visual Studio C/C++")
  message(WARNING "This compiler is not supported Microsoft Media Foundation (MSMF)")
  set(WITH_MSMF OFF)
endif()

The above code snippet will be added below the following section in the portfile.cmake:
set(WITH_MSMF ON)
if(NOT VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP)
  set(WITH_MSMF OFF)
endif()

The solution is based on the stackoverflow.
Could someone tell me is this proposed feature valid under all scenarios? Thanks!

The if(NOT MSVC) is wrong, since CMake is running in script mode, therefore it has no notion of a compiler.
Instead, you can change the existing condition, from if(NOT VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP) to if(NOT VCPKG_TARGET_IS_WINDOWS OR VCPKG_TARGET_IS_UWP OR VCPKG_TARGET_IS_MINGW)
I'll probably go back and investigate why it failed, since mingw-w64 is supposed to provide Media Foundation headers.

This issue was fixed with #25431.

Thanks for posting this issue. This issue has been fixed, so I am closing this issue for now.


OUTREACHY WINTER 2024 STARTER ISSUE

This issue is a starting issue for Outreachy intern applicants for Winter 2024. All intern applicants are expected to begin with this issue. All intern applicants are expected to complete this issue.
To start, please read the welcome post on the ODK-X Forum and join the ODK-X slack.
https://forum.odk-x.org/t/welcome-outreachy-winter-2024-applicants/2696
NOTE: Since everyone can do this issue (and is expected to do this issue), the issue will not be assigned to people.
To begin with, applications should familiarize themselves with the three mobile tools following these directions
https://docs.odk-x.org/basics-install/
https://docs.odk-x.org/survey-sample-app/
https://docs.odk-x.org/tables-sample-app/
ALL ODK-X Outreachy Winter 2024 projects involve the ODK-X mobile apps, so you should try them out.
The second stage of preparation involves making your own form to be rendered in Survey AND a custom view in Tables. Please follow these directions: https://docs.odk-x.org/build-app/
While going through the documentation, we encourage you to make an improvement to the instructions (it counts as a contribution!)
Relevant issue https://github.com/odk-x/tool-suite-X/issues/485
*When done post screenshot here to proof you've completed this starter task, Best of luck!
Also, you might want to run older emulators that target Android version 10, as we are in the process of updating some features to work with newer versions of Android.

Noted @Redeem-Grimm-Satoshi
I will get on this immediately..

Noted @Redeem-Grimm-Satoshi, I'll start working on it.

@Redeem-Grimm-Satoshi  thank you for the issue

This is duly noted @Redeem-Grimm-Satoshi . Thank you

Thank you

Thank you

This is Noted @Redeem-Grimm-Satoshi.
Thank you.

Noted, @Redeem-Grimm-Satoshi. Thank you!

noted and seen @Redeem-Grimm-Satoshi .

Hi @Redeem-Grimm-Satoshi , I have been able to complete the task

@TunrayoIlawole weldone?

I finished the starter task

web view

mobile view

Hi, I have finished the starter task

I ahve finished starter task. i don't have a working android phone.

Done with the starter task

Done with tha starter Task

well done @siva224513

Done with the starter task

On Mobile

Done with the starter task

@Redeem-Grimm-Satoshi  While going through the documentation, I made improvement to the instructions. What branch do I point the pull request to?

Done with starter Task,
While working with the ODK-X Application Designer, I encountered an issue where the "Save to File System" button fails to automatically save the generated files. The error message suggests that something went wrong, which can disrupt the workflow.
To improve the documentation and make it more user-friendly, I propose adding a section that provides clear instructions on how to manually save the generated files when this error occurs.

@Redeem-Grimm-Satoshi, I successfully completed the first task of creating a custom from to be rendered in ODK-X Survey as shown:

and to create a custom view to be rendered in ODK-X Tables as shown:


Release a new version

There has been many nice additions, but the version still stand at 0.2.0.
Awesome if you could mint a new release to npm. 💯

There's nothing in master that's not in 0.2.0. https://www.npmjs.com/package/@mapbox/polyline

Please help me understand. It was published 10 months ago and there are many commits on master.
This diff shows a fix for the rounding error, among other things.

@sandstrom Are you using the @mapbox/polyline package?

@jfirebaugh Yes you are right!
I got confused by the changelog which shows no changes since 2015.
I've made a PR with some adjustments: https://github.com/mapbox/polyline/pull/34


Fix "error: Forever detected script exited with code: null"

When a process dies from a signal and has no exit code, forever logs this incorrectly.  It is checking isNaN(code), which is wrong.  isNaN(x) does not check that x is numeric; it merely checks if x is equal to NaN; since code is either null or an integer, this can never be true in this context.  isNaN(null) === false.
This patch corrects this bad check, to verify that code was in fact passed by the exit handler.  If it wasn't, then we fall through to print the signal that killed the monitored process.

I would love to see this fix added. I am having an issue where I am trying to SIGKILL my app programmatically which results in a code===null. But since the isNan(null) resolves to true, my app restarts when it should not.

This solve my issue with upstart. When trying to stop the service the app return null and forever keeps restarting when it should simply stop.

Should this not be merged?

This looks good at first glance, but we should have test coverage for this before merging it in.


Cache results of setup_controls so we don't send redundant controls setup to the client

The ClientImpl::setup_controls method in mercutio-client/src/client.rs will send a new "controls" payload to the client with the following info:

Which key combinations the Frontend should listen to
Which buttons the Frontend should display
Which buttons are highlighted (i.e. representing the result of the latest action).

Because we already know the previous ClientCommand::Controls we sent to the client, it would be helpful if we could

Cache the most recently sent ClientCommand::Controls data in pub struct Client, and
Not send a new payload if this structure hasn't changed.

There's a few ways to do it, but the trivial way would be to just track the previously sent information and then compare it with the new packet.
One option here is to extract the "keys" and "buttons" fields of ClientCommand::Controls into a "ControlState" struct, so we don't have to match against the ClientCommand enum to compare these values. Then we can change ClientCommand::Controls to ClientCommand::Controls(ControlState) rather than imbedding the data directly.

Hey, @tcr. Apologies for the delayed response.
I've been having issues implementing this fully: realized that I need to improve my knowledge of Rust to do it well. I'm going to raise a PR so that you can track my progress and offer some guidance. 😅
Have opened a PR for #45 and marked it as WIP for the same reason.

@briankabiro So now that Controls the struct is broken out, it can be stored directly on an object.
https://github.com/tcr/edit-text/blob/master/edit-client/src/client.rs#L304-L331
If you look at fn setup_controls(), it creates a Controls { keys, buttons } object (and wraps it in UserToFrontendCommand::Controls and sends it off. If we can save the most recent Controls struct, and each time setup_controls is called check if the old Controls struct and the new one are equal, then we can decide only to call self.send_client` when we create a Controls object that is different.
I would add a last_controls: Option<Controls>, property to pub struct Client. Everywhere a struct Client is constructed last_controls can be set to None. And you can simplify the conditional logic with like if Some(controls_object) != self.last_controls { ... }; self.last_controls = Some(controls_object); to avoid having to check for None versus Some values.

Appreciate all the help, @tcr. Was strapped for time, but working on this now.  💯

Think we can close this fella now. 😃


qpl_execute_job returns 206 or 204 when runing decompress operation

hi, I'm integrating qat compression and iAA decompression，QPL can decompress most of the data compressed by qat，only a small percentage of data blocks cannot be decompressed by the QPL with qpl_path_hardware, it returns error codes “204“ or ”206”,  but zlib or qpl with qpl_path_software can decompress it successfully. Could you tell me the reason of this issue?

Closed per offline discussion.


Changing timezone unconditionally

The client changes the system timezone to Etc/UTC in the VIESAPIClient::__construct method unconditionally. This can lead to sideffects in applications where other timezone is in use.
I recommend using gmdate() instead of date() so that no timezone change is necessary.
If this is not enough the timezone could be changed temporarily in the methods where it is necessary then changed back to the original.

Function date_default_timezone_set() was removed from constructor. From now on, dates returned will have the default time zone of the PHP server.


Extra space in buffers when .setup called?

Info

Operating System: MacOS, Arch Linux

Shell: zsh

Terminal: kitty

nvim --version: 0.9.1

fzf --version: 0.4.2

[ ] The issue is reproducible with mini.sh

fzf-lua configuration

require('fzf-lua').setup()

Description
I've noticed something similar to https://github.com/ibhagwan/fzf-lua/issues/814, (extra padding when using buffers) which is in fact fixed nicely when using mini.sh:

However, with any call to .setup() whatsoever, even an empty one, this happens:

Am I perhaps inadvertently overwriting config? Could be user error, but I've tried the most minimal config I can think of, and reproduced the issue.
I'm otherwise an extremely happy plugin user, thanks for all your hard work!

Am I perhaps inadvertently overwriting config? Could be user error, but I've tried the most minimal config I can think of, and reproduced the issue.

Seems to me like there’s an issue with coloring not being applied (current buffer % isn’t red), the ansi escape sequencing adds a lot of invisible characters which are then aligned with string.format, when the coloring sequences are missing the spacing will appear much wider.

Are you calling setup() with no arguments?
mini.sh is also using setup, does it also reproduce with the mini script?
Can you call run :lua require'fzf-lua'.setup_highlights() and then buffers?
Can you run :FzfLua highlights and post all the highlights starting with FzfLua…?

Yeah I did notice the highlight change, you're right. Lemme see if I can come up with a foolproof repro.

Yeah I did notice the highlight change, you're right. Lemme see if I can come up with a foolproof repro.

My guess is the highlight groups are returning invalid colors.
Try this step:

Can you run :FzfLua highlights and post all the highlights starting with FzfLua…?

It would also be helpful to see the the highlight group details from the preview for the FzfLuaBuf… groups.

Yikes. OK, this is weird. There are no FzfLua highlight groups if I have any kind of require("fzf-lua").setup(... call in my config. But take it out, and they all mysteriously appear (26 groups in total). This is testing with .setup() (no args), but the same thing happens with profiles, or with my usual config which is just:
require "fzf-lua".setup {
  files = {
    fd_opts = '-t f -H -I -E "{.git,tags,dist,__pypackages__}"'
  }
}

This definitely does not happen with mini.sh.

Can you call run :lua require'fzf-lua'.setup_highlights() and then buffers?
Yep, this fixes it! Hrm. Incompatibility with another plugin?

Yikes. OK, this is weird. There are no FzfLua highlight groups if I have any kind of require("fzf-lua").setup(... call in my config. But take it out, and they all mysteriously appear (26 groups in total). This is testing with .setup() (no args), but the same thing happens with profiles, or with my usual config which is just:

In order to avoid forcing the user to call setup, highlight setup is called twice, once when loading the plug-in:
https://github.com/ibhagwan/fzf-lua/blob/2fa4913c7db0c22e02c003c6f09b7ebb2d0ed367/lua/fzf-lua/init.lua#L106-L109
And optionally a second time as part of setup:
https://github.com/ibhagwan/fzf-lua/blob/2fa4913c7db0c22e02c003c6f09b7ebb2d0ed367/lua/fzf-lua/init.lua#L150
Now why the call from setup fails in your case is unclear but I would suspect plug-in load ordering:

What plug-in manager so you use (lazy or packer?)

Using packer, and unless I've misunderstood, I don't think I'm lazy loading either the colorscheme or fzf-lua. But now I'm able to repro the issue with this config (no explicit .setup call) which leads me to believe something in my environment is off:
-- init.lua
require("plugins")
vim.api.nvim_set_keymap("n", "<C-\\>", [[<Cmd>lua require"fzf-lua".buffers()<CR>]], {})

-- lua/plugins.lua
vim.cmd([[
  augroup packer_user_config
    autocmd!
    autocmd BufWritePost plugins.lua source <afile> | PackerSync
  augroup end
]])

return require("packer").startup(function(use)
  use "wbthomason/packer.nvim"

  use { "ibhagwan/fzf-lua", requires = { "nvim-tree/nvim-web-devicons" } }
end)

At this stage it doesn't look like an fzf-lua problem, but I appreciate your debugging assistance thus far!

At this stage it doesn't look like an fzf-lua problem, but I appreciate your debugging assistance thus far!

It might be something in your config, but I’d still argue this shouldn’t happen and might be fixed from fzf-lua, these lines create the highlights:
https://github.com/ibhagwan/fzf-lua/blob/2fa4913c7db0c22e02c003c6f09b7ebb2d0ed367/lua/fzf-lua/init.lua#L69-L73
It would be interesting to see if these get called and create the highlights, if it fails then I can probably find out why and fix it from fzf-lua.
The other and more likely cause, is that something in your config is calling hi! clear which removes all highlight groups and that’s why calling setup_highlights again solves the issue.
Clearing highlights is usually called at the start of setting up a colorscheme, maybe you can add some prints in your config and see which gets called first, fzf-lua or the colorscheme plug-in (although it technically could be any plug-in).
Although I’m not a big fan of workarounds you could add a call to setup_highlights at the end of your config (after all plugins are loaded) which will also solve the issue.

Yeah, I'll keep looking, if I find anything I'll attempt a PR. It almost feels like something is getting cached, though I've removed everything in the usual places (.cache/nvim, .local/share/nvim).

@richchurcher, any findings why the highlights are getting cleared (or err during creation)?

I'm sorry for not getting back... I had to unexpectedly job hunt (employer funding crisis, all too common these days!) which has been taking up all available RAM. I'll revisit soon :crossed_fingers:

I'm sorry for not getting back... I had to unexpectedly job hunt (employer funding crisis, all too common these days!) which has been taking up all available RAM. I'll revisit soon 🤞

GL friend!

I had the same issue. Using LazyVim distro
Correctly specifying the colorscheme fixed it.
Previously I had
require("config.lazy")
vim.cmd("colo catppuccin")

Now I removed the second line. Instead, my colorscheme.lua contains:
return {
  {
    "LazyVim/LazyVim",
    opts = {
      colorscheme = "catppuccin",
    },
  },
}

Ty for the the info @patnr!

Oh, interesting. I'm not a LazyVim user (although see below) so can't comment on that aspect.
I did recently switch from Packer (which is now unmaintained) to Lazy's package manager https://github.com/folke/lazy.nvim and I note the problem has disappeared. I know that's not very helpful in solving the underlying problem, but it does provide something to trial for those who might also be seeing this issue. I also switched colo to https://github.com/edeneast/nightfox.nvim, as another data point.
Happy for this to be closed unless you'd like to use it to track further reports.

Ty for the update @richchurcher! Closing.


fix: resolves memory leak issue by using WithExternalConnectDisconnecter

Description of your changes
Fixes #138
This PR is trying to solve the memory leak issue by handling the io.Closer when creating the argocd client. The original implementation ignore the io.Closer, and this PR is trying to handle it on WithExternalConnectDisconnecter.
Before the fix, you can see that the memory usage is growing overtime, just like mentioned in the #138

Afterr the fix, you can see that the memory usage becomes stable overtime.

I haven't figure it out how to make a good graph to present the result, but it would be good to get some help to verify the changes.

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

E2E are still failing due to a bug in the script. https://github.com/crossplane-contrib/provider-argocd/pull/149 is about to fix this.
Can you rebase on master once the fix is merged - and squash your commits?

I updated the PR and rebase to the latest main branch.

Thank you cychiang!
@MisterMX, thanks for helping resolve this. Since this change has been out for a few months now and seems stable, can you please release + push a new patch version that includes this change? I have been referring to the package built on this commit, but a proper release would be appreciated, thanks.

Thank you cychiang!
@MisterMX, thanks for helping resolve this. Since this change has been out for a few months now and seems stable, can you please release + push a new patch version that includes this change? I have been referring to the package built on this commit, but a proper release would be appreciated, thanks.

Yeah - this will be useful!


Define a RELEASE.MD for the Alertmanager Project

Will helps us get to a more regular cadance of releases.

The release.md of Prometheus should cover the procedure for all repos. What's needed here is the schedule and the table I guess.

My plan is to go through the instructions (I haven't done my first release) and document along the way if I find something that does not add up.
My reason for copying the responsibilities is that I found:

With the pre-release, the release shepherd is responsible for running and monitoring a benchmark run of the pre-release for 3 days, after which, if successful, the pre-release is promoted to a stable release.

Does not really apply to us - we don't have the equivalent of a prombench. However, I don't think that's stopping us from exercising best judgement.
That said,  I agree that we should just reference to the Prometheus file to keep things consistent.

@simonpasquier @roidelapluie friendly ping - any thoughts?

Hi team,
Thank you for your time and dedication to maintaining this project.
I appreciate your support and look forward to seeing #3324 in the upcoming release.
It seems that the release process is stuck for over 2 months. Is there anything I can help?
I am glad to get involved if needed.

Superseded by https://github.com/prometheus/alertmanager/pull/3445


deriveAvro example doesn't work

Hi,
I just started testing this library and the deriveAvro example doesn't seem to work:

person.avsc

{
  "type": "record",
  "name": "Person",
  "fields": [
    {
      "name": "name",
      "type": "string"
    }
  ]
}

MyModule.hs

{-# LANGUAGE TemplateHaskell #-}
{-# LANGUAGE DeriveGeneric   #-}

module MyModule where

import Data.Avro.Deriving

deriveAvro "schemas/person.avsc"

Stack resolver 13.26

I get this compilation error:
    • Couldn't match expected type ‘GHC.Exts.Item
                                      (f0 (Data.Text.Internal.Text,
                                           Data.Avro.Types.Value.Value Data.Avro.Schema.Type))’
                  with actual type ‘(Data.Text.Internal.Text,
                                     Data.Avro.Types.Value.Value Data.Avro.Schema.Type)’
      The type variable ‘f0’ is ambiguous
    • In the expression:
        (Data.Text.pack "name" Data.Avro.ToAvro..= p_1_alvH)
      In the second argument of ‘Data.Avro.record’, namely
        ‘[(Data.Text.pack "name" Data.Avro.ToAvro..= p_1_alvH)]’
      In the expression:
        (Data.Avro.record schema'Person)
          [(Data.Text.pack "name" Data.Avro.ToAvro..= p_1_alvH)]
  |
8 | deriveAvro "schemas/person.avsc"
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

However this compiles fine with deriveFromAvro
Is there something I missed? I may very well have done an error :sweat_smile:
Cheers!

Works on my machine against LTS-13.26. Do you perhaps have something unusual about the way you've set up stack/cabal/ghc?

I just tested on my Windows machine and this works. So I guess this is something NixOS related 🤔 I'll investigate on my side and explain in this issue when I find out. Sorry for bothering you 😞 Cheers!


new experimental version

Fix solution explorer, now projects correctly list source files
based on:

FSAC  PR #347 on commit https://github.com/fsharp/FsAutoComplete/pull/347/commits/98c418b720b86846b72373117d2ca04781e976ef
Dotnet.Proj.Info v0.34

@Krzysztof-Cieslak ready to release


Support for non-English inline tags

When you set non-English tags to customize map markers, inline tags wouldn't recognise non-English texts as tags and custom markers wouldn't show. They seem to work fine in marker preview tester though.

Indeed the regex that parses inline tags did not take non-English text into account (which is funny when I think about it, because many of my notes are not in English either... Yet I never considered non-English tags :shrug: )
Will fix.


Question about Pixhawk Cube Orange & Pixhawk Cube Black

Does the MAVSDK C++ support both versions of pixhawk? ( Orange Cube & Black Cube )

I guess it might be good to describe what you are trying to achieve. What is your setup wrt PX4 or ArduPilot, etc. What have you tried so far? Giving more details will allow people to help you better.

MAVSDK supports mainly PX4, and I have seen people use at least parts of it with Ardupilot.
It's not related to pixhawk though: pixhawk is the hardware, and MAVSDK does not care about the hardware. So you can run PX4 on a pixhawk, a raspberry pi, your laptop or a coffee machine, as long as MAVLink messages reach MAVSDK, it will be fine.
Does that answer your question? :blush:

Closing as there was no follow up.


Prepare release 20.07.0b2

@chrisjsewell, please have a look at this PR.

Yep just run it through:
$ pip install .
...
$ pip check
No broken requirements found.


Molecule properties not retained with MolStandardize.rdMolStandardize.Cleanup()

Configuration:

RDKit Version: 2<IP_ADDRESS>
Operating system: Centos 7
Python version (if relevant): 3.6, 3.7
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? rdkit
If you are not using conda: how did you install the RDKit? N/A

Description:

Rdkit Team,
Certain molecules do not retain their properties when standardized with the rdkit.Chem.MolStandardize.rdMolStandardize.Cleanup function. This updated function was changed in an earlier release for speed improvements and to fix this very issue. We did not experience this molecular property dropping problem in the 2<IP_ADDRESS> release, but it seems to have appeared again. Running on a collection of a million smiles, we found that the molecular properties are dropped on about 5% of the constructed molecules. Here are some examples of smiles that fail:
Cl.c1cnc(OCCCC2CCNCC2)cn1
CC@@H[C@H]1C(=O)N2C(C(=O)O)=C(S[C@@H]3CNC@HC3)C<EMAIL_ADDRESS><EMAIL_ADDRESS>CN1CCC2CCN(C(=O)C3CNC3)C2C1.Cl
COc1cc(NC(=O)CNC(=O)C@@HC(C)C)ccc1NS(C)(=O)=O.Cl
CNC(=O)C(c1ccccc1)n1cnc2c([NH2+]C)ncnc21.[Cl-]
C=CCN+(C)CC=C.[Cl-].[Cl-]
CN1C(=C2C(=[NH2+])N3CSCC3C2=O)N(C)c2ccccc21.[Cl-]

from rdkit.Chem.MolStandardize import rdMolStandardize
from rdkit.Chem import MolFromSmiles

smiles = "COc1cc(NC(=O)CNC(=O)[C@@H](N)C(C)C)ccc1NS(C)(=O)=O.Cl"
mol = MolFromSmiles(smiles)
mol.SetProp("testing_prop", str(1234))

print("Smiles", smiles)

print("Props Before CleanUp")
print(mol.GetPropsAsDict())

standard_mol = rdMolStandardize.Cleanup(mol)

print("Props After CleanUp")
print(standard_mol.GetPropsAsDict())

Thank you,
Zach Kaplan

Hi Zach,
Thanks for reporting this. I'll take a look and try and get this fixed


fix(ajaxobservable): fix operator import path

Description:
Related issue (if exists):
https://github.com/ReactiveX/rxjs/issues/2971

Coverage remained the same at 97.399% when pulling d9b62ed23d74a9445d4968abdf2f682c06569be6 on kwonoj:fix-import into 9538a2024973d9a5c3cbeb26503cc8090dd6b806 on ReactiveX:master.


Multiple objects support

Hey - this is a more conceptual question - would love some help here. From what I read, it looks like the following may be somehow possible, but I would love some help on how I can make this happen:
recordA.avsc:
{
	"type": "record",
	"name": "A",
	"fields": [ { "name": "id", "type": "long"} ]
}

recordB.avsc:
{
	"type": "record",
	"name": "B",
	"fields": [
		{ "name": "id", "type": "long" },
		{ "name": "a", "type": "A" }
	]
}

I.e., I would like to be able to embed A within B. Is there a preferable way to load my schemas to make this happen? I would hate to have to put the entire A object within recordB.avsc – I'm sure there's a better way.

Ah, I see "The parse-schema function may be passed multiple schemas, in which case later schemas may reference types defined in earlier schemas".
it would be great to do this automatically though - not sure if possible - to detect a schema's dependencies so they can be loaded

There's been some periodic proposals to have a sort of "schema server" as part of of the core distribution which would allow this sort of automatic resolution.  I believe LinkedIn even provided an implementation, but I'm not sure of the current status. It might be worth checking out if you're motivated, but without support in the core Avro distribution I'm going to say this is out of scope for abracad.

That's fair - I wrote something quick to do it myself :-)


[18.09 backport] Makefile and test changes

Backports of:

https://github.com/moby/moby/pull/37879 go {build,test}: rm -i option, add go cache volume
https://github.com/moby/moby/pull/37845 Allow to override the Makefile's DOCKER_MOUNT variable
https://github.com/moby/moby/pull/38370 Update Dockerfile to skip source copy for speed up
https://github.com/moby/moby/pull/38529 Makefile: make help: fix newline wrapping, and missing targets
https://github.com/moby/moby/pull/38523 CI: Introduce flaky test finder
https://github.com/moby/moby/pull/38693 hack: Have TIMEOUT take -test.count into account when testing for flakiness
https://github.com/moby/moby/pull/38847 Enable buildkit for Makefile build target

git checkout -b 18.09_backport_makefile_and_test_changes ce-engine/18.09

# https://github.com/moby/moby/pull/37879 go {build,test}: rm -i option, add go cache volume
git cherry-pick -s -S -x bdcd81d3301a053eefc320de16ac842ec47ed459

# https://github.com/moby/moby/pull/37845 Allow to override the Makefile's `DOCKER_MOUNT` variable
git cherry-pick -s -S -x aea6fdf3d340835a1b0af208839ce42ace3a5b89

# https://github.com/moby/moby/pull/38370 Update Dockerfile to skip source copy for speed up
git cherry-pick -s -S -x e6d7df2e5d313800414b955e10a26d6687e7a1bf

# https://github.com/moby/moby/pull/38529 Makefile: make help: fix newline wrapping, and missing targets
git cherry-pick -s -S -x 202c9d8c98614e7cce2017f5c99d3d783fe8b509

# https://github.com/moby/moby/pull/38523 CI: Introduce flaky test finder
git cherry-pick -s -S -x 8a8fd37f6fb53716cb4b3a7e93e1e3cf385927e2

# https://github.com/moby/moby/pull/38693 hack: Have TIMEOUT take -test.count into account when testing for flakiness
git cherry-pick -s -S -x 42dcfc894a64e9b4c1751b21db1537b3b68a36d8

# https://github.com/moby/moby/pull/38847 Enable buildkit for Makefile build target
git cherry-pick -s -S -x 1275a001a68722494d090d5beca6749a83710cc2

no conflicts; cherry-picks were clean

@kolyshkin @vdemeester ptal
I think all of these should be safe to take, and keeping the Makefile in sync with upstream; this would also make us benefit from BuildKit (once CI is updated to have a daemon that supports it)

rebased


Missing tests

There are no tests yet.
I understand the project is in its infancy, but I thought I could submit a PR at some point. So I opened this issue in the hopes that we can discuss your expectations of how the program should work, and hence what the tests should test for.

I'm almost done basic elements, then will do commands:

build - Compile the current project by running a build.py if present, otherwise creates a universal wheel
new - Create a new Python project, includes git init if in path
init - Create a new Python project in an existing directory, includes git init if in path
grow - Increment version number. major, minor, or patch. defaults to patch
test - Run the tests using pytest and also optionally check coverage
update - Updates all packages in a requirements.txt if present. --all updates all installed packages in current env
release - Uploads to PyPI (this will simply use twine)

https://github.com/ofek/hatch#contributing


[Feature]: Added Support so the Process needs not be ended with process.exit()

What do you want?
currently the process.exit() is needed for node to end correctly, cause the StdIn Interface is not correctly closed.
Why do you want it?
Implement the GUI correctly even during close.
How do you implement it?
The changes needed can be seen here. I'm not sure if all components are working, but a small implementation does not need the on("exit") process.exit() structure anymore
https://github.com/Elius94/console-gui-tools/compare/main...haeferer:console-gui-tools:main
Now this code works
GUI.on("exit", () => {
    console.clear();
})

you can even remove these lines, if you dont want to clear the console on exit
Are you interested in developing this feature?

[ ] Yes, I am interested in developing this feature
[ ] No, I am not interested in developing this feature

Hey! thanks.
Please make a PR when you are ready


[PE-D][Tester B] schedulewithout arguments is not handled

Schedule without arguments is not handled and there is no specific error message for this.

Labels: severity.High type.FeatureFlaw
original: UdhayaShan1/ped#17

The schedule command will show reminders and events for the next 14 days if no arguments are provided.
SO, this bug report should be rejected.


Dark Mode

If not built in, a guide of one or more ways to implement it. We are using vueUse to toggle the mode, so we are at least started. When adding our own custom classes, how do we add them?

Hi @sosensible,
The dark mode is not built in Wave UI for now, but already in my Todo list, and I've been very keen on dedicating some time soon.
For now, since it is not yet implemented, I will start with these few directions, then I will leave this thread open and might come back to give you more advice.

Add the dark prop to the <w-app>
If you want, you can detect the dark mode preference yourself with this line on mounted:

this.darkMode = window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches

If you use that, you need to declare the darkMode variable in data (or use a ref with composition API) then on the w-app: <w-app :dark="darkMode">
3. Add a dark background to your <body> or <w-app>. E.g. .theme--dark {background-color: #202124;}
4. Use a light color as the primary color, and provide it to Wave UI in main.js:
new WaveUI(app, {
  colors: {
    primary: '#d3ebff'
  },
})

Also make the default text color of the primary background dark with:
.primary--bg {
    color: #000;
}

to gain some time in CSS overrides, I would also override the SCSS defaults by following this: https://antoniandre.github.io/wave-ui/customization

Your overrides should be adapted to dark mode, something like this:
// Override Wave UI's SCSS defaults.
$border-color: rgba(#fff, 0.15);
$box-shadow: 0 3px 1px -2px rgba(#000, 0.5),
             0 2px 2px 0 rgba(#000, 0.5),
             0 1px 5px 0 rgba(#000, 0.5);
$disabled-color: #333;

// w-drawer.
// --------------------------------------------------------
$drawer-bg-color: #111;

// w-slider.
// --------------------------------------------------------
$slider-track-color: #444;

// w-table.
// --------------------------------------------------------
$table-tr-odd-color: rgba(#fff, 0.02);
$table-tr-hover-color: rgba(#fff, 0.05);
$table-color: rgba(#fff, 0.7);

// w-tooltip.
// --------------------------------------------------------
// $tooltip-bg-color: #000;
// $tooltip-color: rgba(#fff, 0.7);

This should already be a very good start and there shouldn't be too much work remaining.
But I will soon go over each component to adapt to dark mode and add some overridable defaults in SCSS variables file.

Hope it helps.
I'll keep you posted of my future changes for the dark mode.

Awesome. Most of the other frameworks are putting the dark mode on the  tag, have never seen a class on that tag before but that is just FYI.

Hi @sosensible, the dark theme feature is now available in Wave UI 3.0.
You can check the changes here https://antoniandre.github.io/wave-ui/release-notes#v3.0
And follow the migration guide to add theming feature to your app.
Let me know if you are missing anything :)


Midterm Submission

got invented astropy to save us from math, but i suppose my astropy solution was longer
also just personally, DST should be abolished. dont know why i would think that, coming from a country where it doesn't exist
ps. i think my plots look very pretty indeed :D

We can all agree that DST should be abolished.


pyodbc fast_executemany feature doesn't work

Hello!
pyodbc has a fast_executemany feature, which significantly increases inserts speed when using the ODBC Driver 17 for SQL Server driver. It works perfectly when I creating connection and cursor using pyodbc API directly:
conn = pyodbc.connect(conn_str, autocommit=False)
cursor = conn.cursor()
cursor.fast_executemany = True

cursor.executemany(f'INSERT INTO [{table_name}] ({columns_string}) VALUES ({columns_values_placeholders_string})', data)
conn.commit()

However, I get no effect (no speed boost and MSSQL profiler shows the exec sp_prepexec calls instead of the exec sp_execute ones, which appear when fast_executemany really works) when using it with Django API (i.e. via wrapper provided by django-mssql-backend):
with connection.cursor() as cursor:
    cursor.fast_executemany = True
    inserts go here

Am I doing something wrong or this feature simply not implemented?
Thank you.

Years later but this may help others.
There are wrappers around the actual cursor object when you use Django. In this case there are two, Django itself, and django-mssql.
You can set the fast_executemany attribute on the cursor itself via:
with connection.cursor() as `cursor:`
    cursor.cursor.cursor.fast_executemany = True
    # cursor.executemany() is much faster here

Silly, but without changes to both Django and django-mssql I don't believe there's a cleaner method.


no-inline-styles false triggers on unary variables

Issue #185 (https://github.com/Intellicode/eslint-plugin-react-native/issues/185) is that when there is an unary expression with a variable (eg +blah or -foo) in the style it is flagged for the rule. Only styles with literal values should be flagged (eg -1 or +5 ), whereas those with any variables should be allowed (per the description in the rule docs)

Coverage remained the same at 71.91% when pulling f37c764f23aa383d0bf5dcf961d7be2acfc7cea0 on alex288ms:patch-1 into a6b3af51eaa919486b9ce43f61cade28f2ff63b9 on Intellicode:master.

Hi @alex288ms, thanks for your PR!
If you don't mind, would you like to add a small test case to verify this fix?


see who or why triggered a dependabot run?

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
n/a
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
No response
Updated dependency
No response
What you expected to see, versus what you actually saw
When you look at dependabot logs, there's no way to see who or why triggered it - is there a place to look?
Looking for this for auditing, thanks!
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response

any update on this? thanks!

would still love this - what's best way to get this info?


modules: nanopb: Move pip dependencies to optional module

The west packages extension can be used to install module dependencies.
Upstream nanopb has added the pip package dependencies to the zephyr/module.yml file. Remove in-tree pip package dependencies.
Ref #80782

Removing the DNM as the change in module.yml is the intention of this PR.

Changes to module.yml approved.


Separate api endpoints from Rails view urls

It is becoming difficult to manage the separation of API and Rails view rendering in the same controllers. Separating these out into and  /api namespace will relieve this, and provide a clear path towards a more consistent API.

:+1:  all good for me.
I don't like that this has to happen (from a RESTful API design point of view) but if it makes things simpler go for it

Currently, this would not be worth the effort it would require.

Just refresh my memory here, why was this getting hard to manage?

it was getting difficult due to the branching logic for Rails views / REST API. However, I forget the exact problems, and from what I can see, it would not really gain much at the moment.


Checklist window disappeared, reload and/or exiting page or browser hasn't resolved issue.

Challenge http://freecodecamp.com/challenges/waypoint-add-borders-around-your-elements has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

Checklist window under "RESET HELP BUG" has disappeared on me.

run test button non-responsive

What browser are you in?

@michaelcaetano thanks for posting this issue!
This issue seems global so I'm closing it as a duplicate of https://github.com/FreeCodeCamp/FreeCodeCamp/issues/2904. You can continue further discussion there, thanks.

Please review the Guidelines for Contributing, thank you!.


pytorch 1.6

What does this PR do?
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@yukw777 there is some issue with loading, mind have a look
        if zipfile.is_zipfile(cached_file):
            with zipfile.ZipFile(cached_file) as cached_zipfile:
                members = cached_zipfile.infolist()
                if len(members) != 1:
>                   raise RuntimeError('Only one file(not dir) is allowed in the zipfile')
E                   RuntimeError: Only one file(not dir) is allowed in the zipfile

Hello @Borda! Thanks for updating this PR.

In the file tests/models/test_tpu.py:

Line 231:94: E231 missing whitespace after ','

pytorch 1.6 issue: https://github.com/pytorch/pytorch/issues/42239

@yukw777 good job! it seems not that the update is not completely compatible with PT 1.3 mind check it?
we cal also just make a check of used PT version and adjust usage...

@tgaddair https://github.com/PyTorchLightning/pytorch-lightning/blob/8ab5bcda3d040fbe6fd616ff45793e3dfd1061ce/.github/workflows/ci-testing.yml#L104 why do we skip 3.8? can we add it back in?

why do we skip 3.8? can we add it back in?

if we can, let's re-enable it in another PR :]

@tgaddair
https://github.com/PyTorchLightning/pytorch-lightning/blob/8ab5bcda3d040fbe6fd616ff45793e3dfd1061ce/.github/workflows/ci-testing.yml#L104
why do we skip 3.8? can we add it back in?

Yes, see my comment on #42239.

@tgaddair got it, thanks! sorry for the weird location of my comment. it was late at night and i mixed up the issues lol you can delete that and post it over here if you'd like.

No worries, comment has been moved.

@tgaddair @yukw777 resolving this issue here #2764


[rtl,doc] Add double fault detection.

Fixes #1117

The failing CI is because we also need to update the top-level in the RISC-V compliance test:
ERROR: %Warning-PINMISSING: ../src/lowrisc_ibex_ibex_riscv_compliance_0.1/rtl/ibex_riscv_compliance.sv:133:7: Cell has missing pin: 'double_fault_seen_o'
  133 |     ) u_top (
      |       ^~~~~
                     ... Use "/* verilator lint_off PINMISSING */" and lint_on around source to disable this message.


[Feature] Need to add contributor modal instead of mailto

need to add a proper modal pop-up for contributors. the modal should be able to show the below details:

the pop-up should show the name of the contributor.
the pop-up should be able to show the email and contact information provided by the contributor.
the pop-up should be able to show/fetch information about the contributor from a source file (database or just a reference file).
the pop-up should be able to show the contributor's ORCID if possible.

these are tentative features as of now. they can be worked upon in the near future, but these would be some basic requirements.

most of the required feature-set is finished. however, still some more work needs to be done.

currently, the user's profile photo is shown but there is no support for a default photo when nothing seems to be available. this seems like a step-back from what the feature should be offering.

currently, there is no support for URL-parsed images. this is something that needs to be worked up on at the earliest. based on the current understanding, below should be the tasks list:

[ ] add support for default photo with proper setup of images directory under _build/build.
[ ] add support for parsing images based on URLs.
[ ] add support for parsing optional ORCID.
[ ] add support for dynamic scaling of user's reachability options based on different socials provided by the user.


Use aws-sdk 2.10.x

Coverage remained the same at 100.0% when pulling 209454dc7850610577a8cee653f2efa47324fae5 on aws-sdk-2.10 into d0930d181463fae2495d5950a9f7d08a62864d50 on master.


[Bug] Ctrl-C does not terminating the current shell operation in pulsar shell

Search before asking

[X] I searched in the issues and found nothing similar.

Read release policy

[X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version
3.2.2
Minimal reproduce step
Issue Description:
In the Pulsar-Shell environment, when a user presses Ctrl-C during a shell operation to terminate the running shell operation, an exception org.apache.pulsar.shell.PulsarShell$InterruptShellException occurs but it does not terminate the running shell operation, it prints the below stack trace and the current execution keeps on running. Ideally, it should terminate the current execution.
^CException in thread "SIGINT handler" org.apache.pulsar.shell.PulsarShell$InterruptShellException
	at org.apache.pulsar.shell.PulsarShell.lambda$run$2(PulsarShell.java:230)
	at org.jline.terminal.impl.AbstractTerminal.raise(AbstractTerminal.java:89)
	at org.jline.terminal.impl.PosixSysTerminal.lambda$handle$1(PosixSysTerminal.java:65)
	at org.jline.utils.Signals.lambda$register$1(Signals.java:53)
	at jdk.proxy2/jdk.proxy2.$Proxy3.handle(Unknown Source)
	at jdk.unsupported/sun.misc.Signal$InternalMiscHandler.handle(Signal.java:198)
	at java.base/jdk.internal.misc.Signal$1.run(Signal.java:219)
	at java.base/java.lang.Thread.run(Thread.java:840)

To reproduce it locally:

Run pulsar in standalone mode.
Start pulsar-shell using ./bin/pulsar-shell
Run some command for example, client produce my-topic -m "my-msg" -n 1000 or client consume -s s1 my-topic -n 1000
Then try to press Ctrl+C immediately. The expected behaviour should be that it terminate the above command immediately and return to the shell terminal. But it will print the above stack trace instead and keeps running the command till it finishes producing 1000 messages or till it finishes consuming 1000 messages respectively.

What did you expect to see?
When the user presses Ctrl-C to terminate the currently running shell operation it should terminate the current execution and return to the shell terminal.
What did you see instead?
On pressing Ctrl-C during a shell operation, the current shell operation keeps on running. In addition, it also prints the below stack trace:
^CException in thread "SIGINT handler" org.apache.pulsar.shell.PulsarShell$InterruptShellException
	at org.apache.pulsar.shell.PulsarShell.lambda$run$2(PulsarShell.java:230)
	at org.jline.terminal.impl.AbstractTerminal.raise(AbstractTerminal.java:89)
	at org.jline.terminal.impl.PosixSysTerminal.lambda$handle$1(PosixSysTerminal.java:65)
	at org.jline.utils.Signals.lambda$register$1(Signals.java:53)
	at jdk.proxy2/jdk.proxy2.$Proxy3.handle(Unknown Source)
	at jdk.unsupported/sun.misc.Signal$InternalMiscHandler.handle(Signal.java:198)
	at java.base/jdk.internal.misc.Signal$1.run(Signal.java:219)
	at java.base/java.lang.Thread.run(Thread.java:840)

Anything else?
This PR is related which fixes #19218.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

The latest(3.3.0-SHAPSHOT) version works fine.
Welcome to Pulsar shell!
  Service URL: pulsar://localhost:6650/
  Admin URL: http://localhost:8080/

Type help to get started or try the autocompletion (TAB button).
Type exit or quit to end the shell session.

test(localhost)>
Goodbye!

control + C, and you can see Goodbye!.

@nodece I tried with latest(3.3.0-SHAPSHOT) version. And i see the same issue. It is reproducible on this version as well.
Might be you are misunderstanding the issue at hand.
The problem is when a user the presses Ctrl-C during an ongoing operation let's say client consume -s s1 my-topic -n 1000, the user wants to terminate the client consume command but as per current behaviour, the shell keeps running the command until it finishes. It just print an exception on pressing Ctrl-C org.apache.pulsar.shell.PulsarShell$InterruptShellException the stack trace is added in the issue description.


Add sdist on PyPI as well

Hello,
Could you please add the sdist on PyPI as well?
A lot of different packages managers use the sdist instead of wheels (debian, conda, etc...)

Thanks for letting me know. Apparently I completely forgot this on the last release.
Just added it on PyPi.


Error starting provider *kubernetes.Provider: invalid ingress label selector

What did I do?
We need a multiple ingress cluster and ingress objects.To handle this in k8s, I am trying to set the label selectors on the Træfik Deployments such as traffic-type=internal and traffic-type=external via helm 3.We are using v1.7.20
values.yaml for traefik
# Kubernetes ingress filters
kubernetes:
  labelSelector: "traffic-type: internal"
kubectl get ingress -n ingress

NAME                                 HOSTS   ADDRESS   PORTS   AGE
ingress-internal-traefik-dashboard   *                 80      30m
ingress-traefik-dashboard            *                 80      91m

kubectl describe svc ingress-traefik --namespace ingress
Name:                     ingress-traefik
Namespace:                ingress
Labels:                   app=traefik
                          chart=traefik-1.86.2
                          heritage=Helm
                          release=ingress
Annotations:              <none>
Selector:                 app=traefik,release=ingress
kubectl describe configmap ingress-internal-traefik -n ingress

Name:         ingress-internal-traefik
Namespace:    ingress
Labels:       app=traefik
              chart=traefik-1.86.2
              heritage=Helm
              release=ingress-internal
Annotations:  <none>

Data
====
traefik.toml:
----
# traefik.toml
logLevel = "info"
defaultEntryPoints = ["http", "httpn"]
[entryPoints]
  [entryPoints.http]
  address = ":6080"
  compress = true
  [entryPoints.httpn]
  address = ":8880"
  compress = true
  [entryPoints.traefik]
  address = ":8080"
[ping]
entryPoint = "http"
[kubernetes]
labelselector = "traffic-type: internal"
values.yaml for app

ingress:
  enabled: false
  annotations:
    kubernetes.io/ingress.class: traefik
  labels:
    traffic-type: internal
  hosts:
    - host:  host
      paths: [/]
  tls: []

How can I resolve the below error? Should also add some label in deployment and svc yaml or configmap is enough to point Ingress kind to correct Ingress controller?
What did you see instead?
Error starting provider *kubernetes.Provider: invalid ingress label selector:

fix labelselector = "traffic-type= internal"


panic: send on closed channel

Getting this panic in the server when a build outputs large logs:
panic: send on closed channel

goroutine 168623 [running]:
github.com/drone/drone/server.LogStreamSSE.func2.1(0xc428365a38, 0x1, 0x1)
       /go/src/github.com/drone/drone/server/stream.go:196 +0xc4
created by github.com/drone/drone/vendor/github.com/cncd/logging.(*log).Write
       /go/src/github.com/drone/drone/vendor/github.com/cncd/logging/log.go:74 +0x1cd

Possibly related error on the agent just before the panic:
grpc error: upload(): code: ResourceExhausted: rpc error: code = ResourceExhausted desc = grpc: trying to send message larger than max (6135644 vs. 4194304)

We are experiencing the same behavior. I've verified the logs on both on the server and the agent.
IMO this is a big problem because it causes the server to crash which in turn causes an outage.

@greysond
What version are you on?

v0.8.6

Same... We're on 0.8.6.

Sorry, that's pretty relevant!

I pushed a fix to recover on panic. As soon as we verify the change we will tag an 0.8.7 release (hopefully tomorrow).

I'm running Drone 0.8.8 and I'm seeing panics similar to the original error. These are also in stream.go but in a different location in the file:
-sh-4.2$ sudo docker logs --since 24h drone-server 2>&1 |grep -A 5 panic:
panic: send on closed channel

goroutine 1915572 [running]:
github.com/drone/drone/server.EventStreamSSE.func2.1(0x0, 0x0, 0xc421511400, 0x93e, 0xb5f, 0xc422abf050)
	/go/src/github.com/drone/drone/server/stream.go:89 +0x176
created by github.com/drone/drone/vendor/github.com/cncd/pubsub.(*topic).publish
--
panic: send on closed channel

goroutine 292436 [running]:
github.com/drone/drone/server.EventStreamSSE.func2.1(0x0, 0x0, 0xc422188800, 0xae5, 0xb39, 0xc42149d890)
	/go/src/github.com/drone/drone/server/stream.go:89 +0x176
created by github.com/drone/drone/vendor/github.com/cncd/pubsub.(*topic).publish
--
panic: send on closed channel

goroutine 293348 [running]:
github.com/drone/drone/server.EventStreamSSE.func2.1(0x0, 0x0, 0xc423918800, 0xa7c, 0xb9e, 0xc4214b1cb0)
	/go/src/github.com/drone/drone/server/stream.go:89 +0x176
created by github.com/drone/drone/vendor/github.com/cncd/pubsub.(*topic).publish

https://github.com/drone/drone/blob/master/server/stream.go#L79-L94
I've created a PR which runs a recover() similarly to the earlier fix.

closing this as resolved in 1.0


baseHref/deployUrl option for universal build in @angular-devkit/build-angular:server

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Area
- [ x] devkit
- [ ] schematics

Versions

angular-devkit/architect         0.6.5
Repro steps

Cannot pass baseHref or deployUrl option when running
ng run web:server:production
which contains
 "server": {
          "builder": "@angular-devkit/build-angular:server",
          "options": {
            "outputPath": "dist/server",
            "main": "src/main.server.ts",
            "tsConfig": "src/tsconfig.server.json"
          },
          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ]
            }
          }
        }

Which causes wrong assets path in css on the universal generated response.
Where as when doing a browser build the baseHref is properly appended in postCss processing as expected.
baseHref set to "https://cdn.example.com"

  .icon {
     background: url('/assets/icon.svg') no-repeat center center;
   }

angular-devkit/build-angular:browser-> postCss ->
 .icon {
    background: url('https://cdn.example.com/assets/icon.svg') no-repeat center center;
  }

angular-devkit/build-angular:server -> postCss ->  no change which leads to wrong URL in first initial server rendered response in combination to html base href tag
Desired functionality
The postcss step in server build should append the path with baseUrl or deployUrl  as in browserBuild
so that the initial response generated by universal has correct path to assets if relative URL is used

The same issue !!!

This issue was moved to angular/angular-cli#12093


Can't use any primary key name?

Hi.
So let's me get this straight, i can't use any table schema i want? I mean use any primary key id name i want?
This is unacceptable. I was looking for a simple orm solution, but it isn't.
I was fighting it for hours, i want to use it on a existing database that will be downloaded from internet.
Problems started with only camel case table names in query, ok i found i need to use table name annotation on entity names.
Then it started to return 0 records, but the data was there.
I have pinpoint it to this https://github.com/satyan/sugar/blob/master/library/src/main/java/com/orm/SugarRecord.java#L361
So if my database table does not have a primary long key with name ID it won't work?
I keep getting java.lang.IllegalStateException: Couldn't read row 0, col -1 from CursorWindow.  Make sure the Cursor is initialized correctly before accessing data from it.
And there is no workaround now, the "ID" is hardcoded (and need to be UPPERCASE), i don't get, why the ORM forces me to use specific primary key when it uses refection anyway?
The ORM library should be compatible with databases not the other way around, won't you say?
Now im frustrated, cuz there are no workaround, and i need to ditch it, time wasted.
Are you planning to fix it? Or maybe there is a workaround?
In my use case i can change the tables ids, they have different names like pk_i_id and there are not always long, just int.
It is a part of larger system and the need to be compatible.

Does anyone is supporting this ORM or not? Is it dead for good?

this PR https://github.com/satyan/sugar/pull/556 should address this

Well, for the time being i just made PK annotation with name just like table and a fix for https://github.com/satyan/sugar/blob/master/library/src/main/java/com/orm/SugarRecord.java#L361 just checking the PK annotation name.
Don't have time to wait for PR that god knows when will be released. Such things should be made long ago. Still great project to base on, hance i still want to use it, could be close to perfect with some changes.
And sadly this PR won't fix a thing based on the changes.
And i can't say that sugar is universal, it favors SINGLE database usage, MANIFEST CONFIGURATION, CREATING NEW DATABASE use cases not using existing ones and INVERTED DEFAULT approach.
But an ORM should be universal and cover all needs, not forcing some "rules"

SINGLE db, you can't change the db when you want, no programmatic way to change db name or use another
MANIFEST config, again not needed, should be optional, anything in manifest must be configurable in code also
CREATING NEW DB, that's just the filling, more like ORM to create and use new db than universal way to use any db, new or existing or/and multiple ones, also other design decision shows that, like default naming scheme
INVERTED default approach, an ORM should use the default names from user provided classes without annotation and without forcing it own table or column naming scheme as the default one, what is the point if it isn't plug and play and i needed to create a class for table and then duplicate the same names in column annotation and table? Just cuz the names scheme was forced by default.

And i'm 100% sure that most people won't have a DB with such column names as sugar schema, so they will need to use annotation.
But there it the PK, can't change that folks.
From the linked PR i can see it won't be better, adding another MANIFEST option for PK ID name? Why, where is sense in this? Any table can have different pk id name.
Just don't force people to change anything, most need, a plug and play ORM, that support single or many db usage, new or existing, without any xml config, than can do anything and configure programmatically and don't force any naming of table and columns.
Just an universal ORM that don't put strings on them and forces to change their db designs.

@andrewpros thanks for your descriptions of sugar current problems
could you please provide one PR for each one of the issues pointed out? I will be glad to review it

I would be glad to, but sadly for now i just don't have time more than make simple fixes for my own project, i have removed final from DATABASE_DEFAULT_NAME so i can set it before sugardb init and i also have made said PK annotation to overcome the primary ID naming issue.
And for the inverted default i just had to make table classes and duplicate again every column name to a column annotation, again to overcome the default sugar ORM naming issues.
And i have only 10 tables with about 50 columns total, was not quick but faster that fixing the code, but what if someone has 20 tables and 200 columns and it is just a mirror of another database from some larger system that needs to be column compatible so no no for any changes.


Add documents

Writing as following topics:
1. Project setup
2. Application architecture

server side

client side

3. Essential Business logic

App deployment
Runtime creation
Repo creation

4. Building system
5. Performance tuning


WIP - git sync failures on Windows - change root directory from / to /repo

Initial approach is to set /repo as the base dir. Windows cannot handle the double slash route (eg //.insomnia/ApiSpec/) that gets created by using / as the base dir.
Further notes in the linked issue.

Closing in favor of #2194


[Task]: Make email filter work | multiselect

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
Refer: https://github.com/appsmithorg/appsmith/issues/15373

Multi select is working.


feat: add reason argument to pardon commands

Closes issue #1565.
Due to the nature of the bot internals, it would be messy to only change the unban command to take a reason argument. Therefore, all pardon commands that call the method pardon_infraction() provided by the InfractionScheduler cog will have a reason argument and append the pardon reason to the infraction through InfractionScheduler.deactivate_infraction()'s HTTP patch call to the moderation API when the infraction is marked as non-active.
If anyone would like to see a demo of the pardon at work, here's a video I've uploaded to YouTube.
The format of the pardoned text is still up for debate, as what I've done was a placeholder.

Oops, it seems that I've forgotten about tests - working on that now!


Add documentation for running CiviForm with a modified version of USWDS

For https://github.com/civiform/civiform/issues/8143 I proposed a fix to the USWDS library, and wanted to test it with CiviForm to show that it solved the root issue we were seeing in CiviForm. Add a wiki page to document how to run CiviForm with a modified version of USWDS.

I also sent https://github.com/uswds/uswds-sandbox/pull/146 to add instructions for developing uswds with uswds-sandbox

Updated the frontend development wiki with instructions for modifying USWDS and running it with CiviForm: https://github.com/civiform/civiform/wiki/Frontend-Development/_compare/7c67d7545de1880b8c38e41f5cccf654c07dbf6b...e8e63a87b04396d1d66c29ab39a6e5cff481b1f4


Re-implement node connection creation/deletion slots and node movement signal.

The following slots have been fixed as they were never being called:

NodeDelegateModel::inputConnectionCreated
NodeDelegateModel::inputConnectionDeleted
NodeDelegateModel::outputConnectionCreated
NodeDelegateModel::outputConnectionDeleted

The following slot has been implemented:

BasicGraphicsScene::onNodeClicked

The following signal has been fixed as it was never being emitted:

BasicGraphicsScene::nodeMoved

A nuance concerning nodeMoved, unlike AbstractGraphModel::nodePositionUpdated which is called every frame of movement and captured by BasicGraphicsScene::onNodePositionUpdated, nodeMoved will only be called when the mouse is released, locking the node into its new position. Similarly, onNodeClicked is only called when the mouse is released. See Issue 364 for more information.
Note also that TestFlowScene.cpp is old and no longer works in v3, but does contain some example uses of the fixed slots.

A general remark: could you please format the code using .clang-format file from the root directory? Or at least fix the indentaion (4 spaces). Thanks

I fixed the formatting manually and merged

I fixed the formatting manually and merged

Sorry, I've been at work and did not have time to reply. I'll make sure to format it next time.