Android cross-compile on macOS: Fix for compile error addressed Float80 data type.

Swift forum discussion: https://forums.swift.org/t/android-crosscompilation-on-macos-is-swift-float80-support-really-needed-for-android-intel-x86-and-x86-64-targets/25835
This PR disables Float80 support for Android.

#error "Are you certain `long double` on this platform is really Intel 80-bit extended precision?"
 ^
1 error generated.

CC: @stephentyrone

@swift-ci please smoke test

Note that @stephentyrone is wrong in that thread when he says "it appears to me that long double on Android is just an alias of double, even on x86." It may seem that way on 32-bit Android platforms, where double and long double are both 64-bit, even on x86, but on 64-bit Android, long double is 128-bit, even on x86_64.

@swift-ci please smoke test

Looks like we can merge this PR.
Thank you!

Note that @stephentyrone is wrong in that thread when he says "it appears to me that long double on Android is just an alias of double, even on x86." It may seem that way on 32-bit Android platforms, where double and long double are both 64-bit, even on x86, but on 64-bit Android, long double is 128-bit, even on x86_64.

That is a spectacularly bad choice, but I suppose they'll get to learn why in the fullness of time. In any event, it doesn't change the basic correctness of this patch; if/when the stdlib vends a Float128 type, we can import long double as that on Android and arm64 Linux.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 484bae678099136541cbd49f88e30adb15154577

Build failed
Swift Test Linux Platform
Git Sha - 484bae678099136541cbd49f88e30adb15154577

Seems like CI trying to build non-existing branch and this cause build failure :0


mta builder not available / di-builder not available.  HXE1.0 XSA WebIDE

Hello,
 I am running HANA Express 1.0 on AWS. I was following the tinyworld sample application blog.

While building the HDB module I am getting the error which says "hdi-builder is not available for workspace workspaceXXXXXXXX ". If I build the whole project I get error "mtabuilder is not available for workspace"
I followed The comments on the blog but could not resolve the issue. So far I have done the following:

xs apps command tells me that all the apps including di-core are running under space SAP. I have tried to restart the di-core.
I have set the dev space to SAP. I have assigned my user XSA_DEV the SpaceDeveloper for same space.
I have rebuilt the app 3-4 times from scratch to make sure di-builder gets redeployed.
I have tried restarting HDB and rebuilding the app.

Any idea what the next steps should be?

Hi, Anuj,
I suggest you post questions in the Community Q&A so that you can get support from the community. This repo is to provide feedback on the tutorials. In the meantime, I would suggest you use the development or DEV space (not sure what the default was in SPS12) or go into HANA 2.0 SPS01 if possible.
Regards,
Lucía Subatin.

Thanks Lucia. I have posted the question on QnA as well. I understand this is not the right place.  Just to respond to your comment about DEV space, post installation there was no DEV_SPACE parameter on di-core, since xs apps was showing SAP as space where all the apps were running I ended up setting it to SAP via command line. I will wait for the community at QnA to respond to the query!

Closing this and following up in Q&A

Hi Anuj - Did you ever resolve this issue?  I just spun up the HANA Express edition on AWS and running into the same issue on the build.  I did all of the same issues you had listed and still can't build it.  I created a question - https://answers.sap.com/questions/264342/hana-express-builder-mtabuilder-is-not-available-f.html.
Thanks,
Jay


protocol-tests-with-code-coverage consistently times out in CI

Expected Behavior
protocol-tests-with-code-coverage should regularly succeed on master and produce a coverage report
Current Behavior
Job fails consistently with the error Too long with no output (exceeded 10m0s): context deadline exceeded and coverage is not reported

Closing in favor of #5411

Closing in favor of #5411


Ubuntu 20.04.1 + ROCm 3.9.0 + Davinci Resolve = BROKEN

Hardware: x399 TR 1950x. VEGA FE.
OS: Ubuntu 20.04.1
With AMDGPU-PRO 20.40 it all works. Davinci, blender, etc. Except the display driver is slow and incompatible with OBS and Natron.
With standard X11 AMD drivers and ROCm 3.9.0, blender works but Davinci Resolve doesn't. Can't display video in the preview and edit windows. Or in Fusion. Or the Color tab. Essentially useless.
Is this a known problem? Seems like ROCm hasn't worked properly with Resolve since ROCm-2.2.

Thank you for reaching out.
Request you to kindly paste or attach the logs of  following commands :

/opt/rocm/bin/rocminfo
/opt/rocm/bin/rocminfo
3)/opt/rocm/bin/rocm-smi

@paranoidfactoid rocm 3.3 worked as well.  See my thread here:
https://github.com/RadeonOpenCompute/ROCm/issues/768

3.9.1 causes clinfo and DaVinci Resolve to throw the same errors:
dlerror: libhsakmt.so.1: cannot open shared object file: No such file or directory
Is this software actually tested before being rolled out? The repo doesn't even let me forcefully roll back to an earlier version :/ we really need the repos to have earlier versions of ROCm for when bugs like this come up.
Ubuntu 20.04 btw

I've tested Davinci Resolve 16, DaVinci Resolve 17 and Natron on a fresh Ubuntu 20.04 installation on a Threadripper 1900x + Vega 64 machine with ROCm driver. Nothing worked.
Is amd even testing this driver?? What is wrong with them? It all works fine on any shitty Nvidia gpu but you buy a flagship AMD GPU mostly because you want to support their efforts and then nothing works because of their drivers.
Please, someone from AMD answer us. Do you even test ROCm with supported GPUs against the commonly used software like DaVinci Resolve??
I've been writing bug reports for years already and nothing changed.

@paranoidfactoid which version of DaVinci Resolve did you test?  (16.x or 17.0-beta)?
@KristijanZic I agree.  AMD has been doing a very poor job here.  Here is my perspective.  In short, I have lost patience & faith that this ROCm team knows what it is doing, given all of the re-architectures, regressions, bugs, lack of communication, and slow progress.

https://github.com/RadeonOpenCompute/ROCm/issues/768#issuecomment-726784192

Is there a repo we can use to go back to earlier versions, such as say ROCm 3.8?  Also, is there a better way to actually get the dev's attention?

@BloodyIron  Yes.  See my linked thread above for instructions for specifying the repo.  Here it is again (it's the second post in this thread):

https://github.com/RadeonOpenCompute/ROCm/issues/768

Alternatively, in some cases, you can also do the "multiversion" install to specify your version, depending on the package components.  In this scenario, you could append "dev" onto the package name.  For example:  rocm-dev3.8 (as opposed to rocm).

Following @beatboxa 's steps on reverting to ROCm v3.3 I can now get Davinci Resolve 16 running! This is on Ubuntu 20.04 btw.
I'm now just going to not upgrade ROCm until I somehow see a need.

Remember to test for video in Fusion and try to use the pen tool on the canvas in the color tab. Also, render a large dnxhr file and see if it crashes.

@BloodyIron Glad it worked!
Heads up though:  Davinci Resolve 17 beta came out earlier this week.  Unfortunately, the new version of Resolve does not work with any ROCm version, including 3.3.

Yeah I'm also planning to just stick with DaVinci Resolve 16 for now.

Unfortunately, the new version of Resolve does not work with any ROCm version, including 3.3.
But nothing works with ROCm or AMDGPU-PRO.  I remember when they were showing my GPU rendering 8K composition with millions of polygons in less than 8 seconds and I can't render a 1080p composition wiht less than 100 polygons in less than 120 seconds per frame in Cycles. Ridiculous.

3.9.1 causes clinfo and DaVinci Resolve to throw the same errors:
dlerror: libhsakmt.so.1: cannot open shared object file: No such file or directory
Is this software actually tested before being rolled out? The repo doesn't even let me forcefully roll back to an earlier version :/ we really need the repos to have earlier versions of ROCm for when bugs like this come up.
Ubuntu 20.04 btw

This suggests you don't have all packages installed. Unfortunately a lot of deb packages of ROCm do have wrong dependencies, so not all of them are always installed correctly.
Please provide output of:
dpkg -l | egrep 'roc[mtrc]|hsa'
and
/opt/rocm-3.9.0/bin/rocminfo

@BloodyIron Glad it worked!
Heads up though: Davinci Resolve 17 beta came out earlier this week. Unfortunately, the new version of Resolve does not work with any ROCm version, including 3.3.

@beatboxa
Davinci Resolve 17 beta works for me with ROCm 3.9 just fine.
I needed to disable the pocl  (i.e. uninstall pocl-opencl-icd package, or comment it out in /etc/OpenCL/vendors/pocl.icd ), because otherwise it crashes in pocl. It is not an ROCm issue, but pocl bug.

Resolve 17 is an early beta. A more important question here is: does removing pocl-opencl-icd allow Resolve 16.2.x to run? And properly. Because just checking it gets through the splash screen isn't good enough. Do viewports work? Does Fusion work? How about the pen tool and other crucial mask tools? I'll remove AMDGPU-Pro and see if removing pocl actually does anything here for 16.2.x. If it starts, I'll check the rest of it. Because AMDGPU-Pro has its own set of problems, not least of which it isn't spinning up the fan on my VEGA FE card, leading to auto system shutdowns under GPU load.

What's going on with the repo? Suffice it to say, I followed instructions.
foo@bukowski:~/Desktop$ sudo apt install rocm-dkms
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
comgr gcc-7-base hip-base hip-doc hip-rocclr hip-samples hsa-rocr-dev
hsakmt-roct hsakmt-roct-dev libasan4 libcilkrts5 libdrm-dev libelf-dev
libgcc-7-dev libstdc++-7-dev libubsan0 llvm-amdgpu mesa-common-dev
openmp-extras rock-dkms rock-dkms-firmware rocm-clang-ocl rocm-cmake
rocm-dbgapi rocm-dev rocm-device-libs rocm-gdb rocm-opencl rocm-opencl-dev
rocm-smi rocm-smi-lib64 rocm-utils rocminfo rocprofiler-dev roctracer-dev
Suggested packages:
libstdc++-7-doc
The following NEW packages will be installed:
comgr gcc-7-base hip-base hip-doc hip-rocclr hip-samples hsa-rocr-dev
hsakmt-roct hsakmt-roct-dev libasan4 libcilkrts5 libdrm-dev libelf-dev
libgcc-7-dev libstdc++-7-dev libubsan0 llvm-amdgpu mesa-common-dev
openmp-extras rock-dkms rock-dkms-firmware rocm-clang-ocl rocm-cmake
rocm-dbgapi rocm-dev rocm-device-libs rocm-dkms rocm-gdb rocm-opencl
rocm-opencl-dev rocm-smi rocm-smi-lib64 rocm-utils rocminfo rocprofiler-dev
roctracer-dev
0 upgraded, 36 newly installed, 0 to remove and 0 not upgraded.
Need to get 633 MB/638 MB of archives.
After this operation, 721 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Err:1 https://repo.radeon.com/rocm/apt/debian xenial/main amd64 rock-dkms-firmware all 1:3.9-19
404  Not Found [IP: <IP_ADDRESS> 443]
Err:2 https://repo.radeon.com/rocm/apt/debian xenial/main amd64 rock-dkms all 1:3.9-19
404  Not Found [IP: <IP_ADDRESS> 443]
...
E: Failed to fetch https://repo.radeon.com/rocm/apt/debian/pool/main/r/rocm-utils/rocm-utils_<IP_ADDRESS>901-19_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 443]
E: Failed to fetch https://repo.radeon.com/rocm/apt/debian/pool/main/r/rocprofiler-dev/rocprofiler-dev_1.0.0_amd64.deb  File has unexpected size (253996 != 254002). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
Hashes of expected file:
- SHA256:90c1b51b2174cb46bf4c319f0c478316707407606b4a83594ffec40f9f4c6dd2
- SHA1:10d623591e8ee52dc3a73a84f316d41ef0866214 [weak]
- MD5Sum:550a17049af7b2a9df815b187d8fb3b7 [weak]
- Filesize:254002 [weak]

@paranoidfactoid They had a temporary issue with the repo.
Please do sudo rm -rf /var/lib/apt/lists/*; sudo apt update, and try again.

@paranoidfactoid I never used Davinci Resolve before really, so I can't test it in depth. But I can try doing some simple things.

Does ROCm 3.3 work with Ubuntu 20 ? If so, how do I install this old version ?
I need to return to an older version of ROCm as I see a large
OpenCL performance degradation with current 3.9

Hi @boxerab
We started supporting Ubuntu 20.04 from recent releases only and so we can not give guarantee of Ubuntu 20.04 support for ROCm 3.3.
But it might work, you can give a try.
You can uninstall present ROCm completely like clean uninstallation and then install ROCm 3.3 from the path: http://repo.radeon.com/rocm/apt/3.3/

And what about every version after 3.3 @ROCmSupport ?

@BloodyIron please open separate issue about this. This thread is about Davinci Resolve specifically.
You can find information about supported versions in the readme and on the installation instruction website.

Yes and I just asked about the literal subject line which talks about a newer version of ROCm than 3.3 and DaVinci Resolve...

@baryluk just to confirm:  you are running Davinci Resolve 17 + Ubuntu 20.04 + ROCm 3.9, with the only modifications being uninstallation of pocl-opencl-icd?  Because I did not install or have this component.

@baryluk Can you also tell us which model of gpu card are you using?

Does ROCm 3.3 work with the AMD 6800 series? Hoping I can stay on Ubuntu 20.04, ROCm 3.3 and stock Linux kernel (yes, this is on topic).

@beatboxa @KristijanZic  I used Debian Testing, Linux 5.7.6, AMD Radeon R9 Fury X (FIJI, GFX8), and ROCm 3.9 with Davinci Resolve 17.

@baryluk and it is functional?  As in previews load and render live, editing and effects works, etc, all specifically using the GPU and not falling back to CPU for rendering?

Davinci Resolve 16.2 is definitely NOT functional with ROCm 3.9.

Just to let you guys all know:
You can't even install AMDGPU-PRO 20.45 on Ubuntu 20.04. No matter which kernel you try on. It's totally broken.
AMDGPU-PRO 20.40 will install only up to 5.4.0-54-generic kernel and Ubuntu 20.04 is on 5.4.0-56-generic kernel.
And even if you install it on older kernel it still gives you terrible screen tearing under Wayland, and half apps that need OpenCL don't even launch under X11 with AMDGPU-PRO 20.40.
ROCm is also broken hahaha.
So thank you all for throwing your money at AMD, you are all effectively *****d!

Hi @KristijanZic
We are working on ROCm installation issue on 5.4.0-56, and fix will be ready soon.

@ROCmSupport:
Will Davinci Resolve work? How about Blender, which has a known issue posted at the AMD download site.

So, I just downloded Davinci Resolve 16, and downloaded a tutorial project from the BlackMagicStudio training subsite.
And there are issues.
Playback and video previews in cut and edit modes, break constantly, sometimes it works, sometimes it doesn't. Usually doesn't. I sometimes can get video without audio to work, or sometimes to get audio without video to work. Sometimes neither (but timeline is playing). Never both.
I the log file I see these things very often:
[0x7f90a3c80700] | DVIP                 | ERROR | 2020-12-09 01:46:34,809 | Failed to register OpenGL object for OpenCL interop: CL_MEM_OBJECT_ALLOCATION_FAILURE.
[0x7f90a3c80700] | DVIP                 | ERROR | 2020-12-09 01:46:34,809 | Failed to register GLIO compute interop mapper.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:34,809 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:37,544 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:37,551 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:37,559 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:40,925 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:40,932 | Failed to get texture for Handle1, job was aborted.
[0x7f91abb0d680] | UI.GLIO              | WARN  | 2020-12-09 01:46:40,939 | Failed to get texture for Handle1, job was aborted.

In dmesg I see things like this:
[22132.715735] Evicting PASID 0x8002 queues
[22132.739515] Restoring PASID 0x8002 queues
[22133.955470] Evicting PASID 0x8002 queues
[22133.979487] Restoring PASID 0x8002 queues
[22134.335795] Evicting PASID 0x8002 queues
[22134.347480] Restoring PASID 0x8002 queues

from time to time.
This is Debian testing, with ROCm 3.10 upstream amdgpu, Linux 5.9.9, and AMD Radeon R9 Fury X (FIJI, GFX8). Also Mesa 20.2.2.
It feels maybe it would be higher chance of working with AMDGPU-PRO? It looks like it requirest OpenGL and OpenCL interop.

@baryluk
In fact, amdgpu-pro 20.45 doesn't work either. But if you downgrade your kernel to the previous 5.4.0-54 you can still use amdgpu-pro 20.40. If you can find it. And that does actually work with Resolve 16.2.
Even Blender is borked with 20.45.

@baryluk
In fact, amdgpu-pro 20.45 doesn't work either. But if you downgrade your kernel to the previous 5.4.0-54 you can still use amdgpu-pro 20.40. If you can find it. And that does actually work with Resolve 16.2. This is with Ubuntu 20.04.
Even Blender is borked with 20.45.

Actually it doesn't, Fairlight timeline views don't render (it's just black). So you can't do any audio engineering and mixing, just cutting in the Edit pane.

We are working on ROCm installation issue on 5.4.0-56, and fix will be ready soon.

It has been almost two months without a single change, I hope you are working hard!!!

We are working on ROCm installation issue on 5.4.0-56, and fix will be ready soon.

It has been almost two months without a single change, I hope you are working hard!!!

Hi All,
As per the latest information and clarity provided in our Documentation that ROCm does not support GUI applications officially.
Docs also updated accordingly @ https://github.com/RadeonOpenCompute/ROCm#hardware-and-software-support
Hardware and Software Support
ROCm is focused on using AMD GPUs to accelerate computational tasks such as machine learning, engineering workloads, and scientific computing. In order to focus our development efforts on these domains of interest, ROCm supports a targeted set of hardware configurations which are detailed further in this section.
Note: The AMD ROCm™ open software platform is a compute stack for headless system deployments. GUI-based software applications are currently not supported.

@KristijanZic @ROCmSupport
And 3 months later:
"We have been working on the fix.  But we failed, so we decided to give up and change the scope of ROCm instead.  We'll call this change a 'clarification.'  Sorry it took 3 months for us to attempt to change history by telling you that we never supported graphical applications with our graphics cards in the first place, even though we clearly did."
So I am assuming @ROCmSupport will also close all threads related to Blender, Darktable, etc. as well.  I will link to @ROCmSupport's comment here so that those users can also be made aware that their applications are not supported.

What does this mean for AMDGPU Pro, considering they've merged ROCm into
the pro driver line?
Are you guys saying AMD GPUs will no longer support GUI computational apps
like Blender and Davinci Resolve on Linux going forward?
Because that's bonkers. I might as well throw away my VEGA FE card now and
buy NVIDIA as soon as possible.
On Mon, Mar 1, 2021 at 7:59 AM beatboxa<EMAIL_ADDRESS>wrote:

@KristijanZic https://github.com/KristijanZic @ROCmSupport
https://github.com/ROCmSupport
And 3 months later:
"We have been working on the fix. But we failed, so we decided to give up
and change the scope of ROCm instead. We'll call this change a
'clarification.' Sorry it took 3 months for us to attempt to change history
by telling you that we never supported graphical applications with our
graphics cards in the first place, even though we clearly did."
So I am assuming @ROCmSupport https://github.com/ROCmSupport will also
close all threads related to Blender, Darktable, etc. as well. I will link
to @ROCmSupport https://github.com/ROCmSupport's comment here so that
those users can also be made aware that their applications are not
supported.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RadeonOpenCompute/ROCm/issues/1281#issuecomment-788061754,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7GYKYKBKSXQ7XXAE3LNNDTBO2URANCNFSM4TORUDPA
.

When I initially set up ROCm to be used with my AMD GPU it was because it could offer me the ability to use OpenCL while also using the AMDGPU driver (NON PRO). This way I could get actually good gaming performance, and OpenCL acceleration for applications that leverage it. The whole point of supporting an application-agnostic API such as OpenCL is so that you don't have to support each and every application that can interface with it.
The fact that AMD clearly seems to be unwilling to support "GUI applications" that leverage OpenCL demonstrates to me that the implementation of the OpenCL API with ROCm is non-standard and inherently flawed. If the OpenCL API were implemented correctly, then it would not matter whether I'm using a GUI tool with it or not.
This is looking to be yet another reason for me to switch to nVidia. Not only the fact that ROCm has been an utter nightmare to deal with (on a product I've paid for), but the sudden wilful negligence that is "ROCm does not support GUI applications officially".
AMD, you are going to lose customers by not actually supporting ROCm in the way that your users bought your cards for.

This is an internal misunderstanding - I'm trying to get the messaging fixed and tickets re-opened.

This call never got reopened, did it!

Yeah what's going on?

1345 is still closed too.
https://github.com/RadeonOpenCompute/ROCm/issues/1345#issuecomment-788373240

How did the internal alignment go? Should we be worried again?


sync tries https for sftp

root@host ~ # juicefs -v sync<EMAIL_ADDRESS>b2://xxxx:yyy/cloudstorage
2023/12/19 14:57:30.030460 juicefs[672723] <DEBUG>: maxprocs: Leaving GOMAXPROCS=4: CPU quota undefined [maxprocs.go:47]
2023/12/19 14:57:30.031713 juicefs[672723] <DEBUG>: Creating sftp storage at endpoint https://user.rsync.net [object_storage.go:171]
2023/12/19 14:57:30.033716 juicefs[672723] <ERROR>: connect to https failed: dial tcp: lookup https: no such host [sftp.go:539]
2023/12/19 14:57:30.033841 juicefs[672723] <FATAL>: create sftp https://user.rsync.net: dial tcp: lookup https: no such host [main.go:31]

Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version: 1.1.1
Cloud provider or hardware configuration running JuiceFS: rsync.net / b2
OS (e.g cat /etc/os-release): Arch Linux
Kernel (e.g. uname -a): 6.1.68
Object storage (cloud provider and region, or self maintained):
Metadata engine info (version, cloud provider managed or self maintained): redis
Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage): local

Yes, there's a bug parsing the uri. As a temporary workaround you may try:
juicefs -v sync user:pass@user.rsync.net:/juicecloud b2://xxxx:yyy/cloudstorage

The workaround leads to another issue:
2023/12/20 15:41:04.883244 juicefs[1115587] <DEBUG>: Creating sftp storage at endpoint user.rsync.net/juicecloud [object_storage.go:171]
panic: runtime error: slice bounds out of range [:-1]

We need a : before the slash /, i.e, xxx:/juicecloud.

It's common to use relative path in SFTP, but URI does not support that, so JuiceFS does NOT support specify the SFTP address as URI, it should be in format  [USER[:PASS]@]HOST[:PORT]:PATH, the path could be absolute or relative.

We will support it as URI, but you can't have relative path in it.


OSM sync feature displays nodes in incorrect order

When a building looking like this appears on OSM, the sync feature shows a building with its nodes in the wrong order:

Here is another example.
Building on OSM:

In OSM Building Detector:

I think this was solved in the latest push onto the branch improveAlgorithm


How to get Editor value in vue2-ace-edit

i know in simple ace code
editor.getValue()
but how to get value of vue2-ace-editor
please give me proper full code

<editor ref='myEditor'>
this.$refs.myEditor.editor


How to extract an intermediate feature from efficientnet?

Hi, I'm making U-Net encoded by efficient-b4.
I tried extracting feature as I did in resnet, but it doesn't work with 'NotImplementedError'
backbone = EfficientNet.from_pretrained('efficientnet-b4')
nn.Sequential(*list(backbone.children())[:3])(torch.rand(2,3,512,512))
Error>

NotImplementedError                       Traceback (most recent call last)
 in
----> 1 nn.Sequential(*list(backbone.children())[:3])(inp)
/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py in call(self, *input, **kwargs)
491             result = self._slow_forward(*input, **kwargs)
492         else:
--> 493             result = self.forward(*input, **kwargs)
494         for hook in self._forward_hooks.values():
495             hook_result = hook(self, input, result)
/opt/conda/lib/python3.6/site-packages/torch/nn/modules/container.py in forward(self, input)
90     def forward(self, input):
91         for module in self._modules.values():
---> 92             input = module(input)
93         return input
94
/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py in call(self, *input, **kwargs)
491             result = self._slow_forward(*input, **kwargs)
492         else:
--> 493             result = self.forward(*input, **kwargs)
494         for hook in self._forward_hooks.values():
495             hook_result = hook(self, input, result)
/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py in forward(self, *input)
86             registered hooks while the latter silently ignores them.
87         """
---> 88         raise NotImplementedError
89
90     def register_buffer(self, name, tensor):
NotImplementedError:

There is a way to extract the final feature by 'extract_features' function, however I want to get an intermediate feature for skip connection.
Is there any method to extract it?

Hi, I found the solution that a hook callbacks can do that!
I close this issue

Can you, please, elaborate on the solution? It would be appreciated

I also also having the same error, can you please explain how you resolve it, @Soo95. Thank you.

Look forward to your answer too @Soo95

Hi, I just notice many of you wonder how to do this.
It'd be good to see this nice open repository (https://github.com/zhoudaxia233/EfficientUnet-PyTorch) which implemented it by hook callback.


[Snyk] Security upgrade python from 3.10-slim to 3.13.0b3-slim

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

model_training/s3/Dockerfile

We recommend upgrading to python:3.13.0b3-slim, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

Information Exposure SNYK-DEBIAN12-UTILLINUX-2401083
  150

Information Exposure SNYK-DEBIAN12-UTILLINUX-2401083
  150

Information Exposure SNYK-DEBIAN12-UTILLINUX-2401083
  150

Information Exposure SNYK-DEBIAN12-UTILLINUX-2401083
  150

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Information Exposure

well auto PR for security fix is good, but can we avoid multiple ? as #314 ,#313

@SamYuan1990 I will close these two and merge the last one.


High CPU on tasks that keep the terminal open

When starting a task that is keeping the terminal open; for example building and running an application, the plugin drives all cpu's to at least 50%. Also if the task isn't started by this plugin.
when the task is run without this plugin enabled; all cpu's remain around 1-2%
Is the watcher going into overdrive?
Another 'more or less related' issue; how do I exclude folders from the watcher; i've tried all kinds of variations with the glob '!' for excluding, but whenever I add a '!' it seems the watcher is watching all files.
my config:
"triggerTaskOnSave.on": true,
"triggerTaskOnSave.restart": true,
"triggerTaskOnSave.selectedTask": "Build and run",
"triggerTaskOnSave.tasks": {
	"build": [
		"**/*.go",
	]
}

Can you have a look in the output channel (View->Output and select Trigger Task On Save from the drop down) and see what it is showing when using the CPU?
The exclude probably doesn't work as you would expect because it just tries to match each glob until it finds one that works. I'll see if I can make a change so that you can add excludes.

this is the output from View->Output.
3:56:00 PM vscode.workspace.onDidSaveTextDocument: /home/marc/Development/xxxx/app.go in workspace: marcworkspace
3:56:00 PM {"build":["/*.go"]}
3:56:00 PM task:build
3:56:00 PM vscode.workspace.onDidSaveTextDocument: match:/*.go
3:56:00 PM findAndRunTask: executing Build and run
3:56:00 PM vscode.tasks.onDidStartTask Build and run
and nothing else is added, until I press save on a *.go file again, and the output is similar.
if I start the task via command palette; then this is added to the output
4:00:03 PM vscode.tasks.onDidStartTask Build and run
and upon breaking the terminal:
4:00:31 PM vscode.tasks.onDidEndTask Build and run

and thanks for looking into an exclude option; I've created another issue for that one.

OK,  that suggests that the extension isn't actually doing anything once the task has started. The only thing I can think of is that the busy indicator (the spinning icon in the status bar) is causing it!? There is a setting to disable it - triggerTaskOnSave.showBusyIndicator. Can you see if it makes a difference?

Yes you are right the busy indicator is the source of this issue.
The High CPU issue is solved by setting:
triggerTaskOnSave.showBusyIndicator: false
For me this is acceptable, since i'm not in need of the indicator.! Thank you, and hope you can fix it!

It's not part of the extension - it's just an icon that can be specified for a status bar item. Seems weird that it causes such high load though. I might raise an issue on vscode if I can find an easy way to reproduce it. Unfortunately, all my tasks are fairly intensive anyway, so I've never noticed it as an issue.

It would be easy for you to test, this also results in high cpu when triggertaskonsave is active as plugin
task:
     "label": "Testing",
     "type": "shell",
     "command": "sleep 60",
     "group": {
        "kind": "build",
        "isDefault": true
     },
}

and this for the extension:
"triggerTaskOnSave.restart": true,
"triggerTaskOnSave.selectedTask": "Testing",
"triggerTaskOnSave.showBusyIndicator": true

hopes it gives you some insights!

Thanks - I'll give it a try.

OK, tried it but I don't see any increase in CPU (under Ubuntu). Maybe it's something different in your set up?

I'm using
Version: 1.39.0-exploration
Commit: a715df3459718a501686bd03414f69929bf6e9a2
Date: 2019-09-13T06:32:38.451Z
Electron: 6.0.9
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-32-generic
on Ubuntu 18.04

Only real difference is that I'm on 16.04. That's really odd. Not sure what to suggest...

That graph is from running the Testing task from before; made sure nothing else was running. But I think bringing it to vscode dev attention might be worthwhile ;) for me setting the indicator to false suffices.

Just tried it on this one:
Version: 1.40.0-insider
Commit: 37d34176a6ecf1d09b16a0cad11bb619f3b1e48f
Date: 2019-11-01T10:17:00.077Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-32-generic
Still the same; not using the indicator and it's all good

Perhaps good to know; if using KDE Plasma (v5.15.4) as my desktop; I'll try to install another desktop manager and test again, update here when I have some more info

Just tried it on XFCE4, and it does make a difference, however.. as on KDE Plasma the CPU goes up to 50%, on XFCE it goes up to 15%
When I turn off the showBusyIndicator the average CPU on both is between 1 and 3%.
Even though on Plasma it's higher, on XFCE it also shows an significant increase, and just for an busy indicator. ;) ..

I'm going to close this as it's been 6 months. If it occurs again, feel free to re-open.


Feature/add org managers

Closes #24

Looking good. Be sure to focus on consistency here. Particularly, be consistent with i18n tokens, as they are clearly outlined in our contributing guidelines.

@brylie clearly missed that part with i18n, thanks for noticing.

Looking good so far. We can probably merge when you are ready. Just double check the safety of code and data handling.

@nnn @brylie My PR #266 depends on that.
@nnn Could you resolve conflict if my PR will be merged before yours?

Can you rebase this branch on develop to get the latest .eslintignore?

git checkout develop
git pull (to get the latest develop)
git checkout feature/add-org-managers (go back to your branch)
git rebase develop (bring develop branch and put your commits on top)
git push --force origin/feature/apis-filter (as you changed your tree, you will not be able to push without forcing)

After this, you will have .eslintignore with the ignored files. You should remove all files you touch in this pull requests from .eslintignore.
At this point, travis-ci will check the lint for you. You can also always do npm run-script lint or meteor npm run-script lint to check.

@nnn When will it be ready? I have task which is blocked by this.

As discussed with @nnn, we need to change the autoForm code, so that it has a type=method attribute.

Reverted last changes for now.
Will try one more time in the following task.

@marla-singer merged!

@brylie Great :confetti_ball:


Create search filter for icons in forms

Closes #8350
Fixes Issue
Initially searchbar for links and milestones pages allowed user to select icons from different page (Search Icon page), where user has to first go to that page copy that icon then fill form.
Changes proposed
A search filter has been implemented directly within the same form, allowing users to search for icons from the list of available icons. This enhancement provides users with convenient options to add icons directly through the search feature, eliminating the need for users to navigate to a separate page to access icons. With the integrated search filter, users can easily find and select icons while filling out the form, enhancing efficiency and user satisfaction.

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Let me know anything I missed, this is my second pr in this repo.

We can replace the search bar with this one for https://linkfree.io/icons  page also.

This looks good, I will have a proper test and play tomorrow, thank you 👍

Great suggestion, I will follow in next pr.


Platform HTTP consumer does not support matchOnUriPrefix

We first need CAMEL-14699. Then QuarkusPlatformHttpConsumer needs some mods to handle the matchOnUriPrefix URI param.

Superseded by https://github.com/apache/camel-quarkus/issues/1144 as this capability is present in camel-platform-http-vertx.


Improve AQE support by capturing SQLPlan versions

Contributes to #1172, Fixes #1351
This issue is to change the tools structure to support multiple version of SqlPlan.
Before that PR, if AQE is enabled, only the last plan is kept in the AppBase.SqlPlans map.
For sake of memory optimization, this PR adds the full implementation that supports capturing multiple versions but only caches the DSInformation extracted from old plans.
This allows the tools to generate the metadata of ReadV1 from original plans in case the metadata has been truncated in the finalPlan.
Change in output

New columns added to data_source_information.csv

sql_plan_version: an integer that represents the version number of the SqlPlaninfo where this row comes from.
from_final_plan : Boolean True/False to indicate whether this row comes from final plan or not.

Impact on API:

If users are interested in looking into all the information (ReadV1 and ReadV2) across all the versions
If users only want the datasource from finalPlan, then they should filter the rows using "from_final_plan=true"

Sample output file after the change:
data_source_information_after_change.csv

In this file the versions [1-5] are skipped because they have no V1 metadata
The last 4 rows represent the final plan
The first 4 rows show the detailed datasource from the original plan.

Headers of the new file:
appIndex,sqlID,sql_plan_version,nodeId,format,buffer_time,scan_time,data_size,decode_time,location,pushedFilters,schema,data_filters,partition_filters,from_final_plan

Code Changes:

Get rid of the AppBase.sqlPlans, replacing it with SqlManager class
Each Sql is represented by SqlPlanModel that keeps track of properties related to SQLplan and the versions.
The entity that contains the SparkPlanInfo is SqlPlanVersion.
For sake of memory optimization, a derived class SQLPlanModelWithDSCaching from SqlPlanModel will not keep track of all previous PlanInfo. Instead, it only caches the DataSourceRecord if any.

Future Work:

When we are confident on how to map the metadata between originalPlans and finalPlan, then we can eventually replace the truncated data with the new one.
Process DSourceV2 in addition to DSV1 in previous versions
Do some cleanup to get rid of all the maps inside AppBase and move the fields into the new class SQLPlanModel
Some cleanups related to extracting information of the readSchema and readParser.
File an issue on Spark open source to avoid truncating this information with AQE.

@wjxiz1992 and @leewyang
Let me know if you have any feedback on the workaround to Spark truncating the schema from the AQE.

Tested with eventlogs that previously failed to generate data_source_information.csv, and this PR seems to do better, so LGTM!

Tested with eventlogs that previously failed to generate data_source_information.csv, and this PR seems to do better, so LGTM!

Thanks @leewyang !


Segmentation fault with macros

I'm not sure what I'm doing wrong but I'm getting another segmentation fault. On OSX. Here is the code:
(import macros)

(using-namespace std.macros
  (def def-type-alias (macro extern (new old)
    (qq def (uq new) (macro extern ()
      old)))))

% dalec def-type-alias.dt
zsh: segmentation fault  dalec def-type-alias.dt

If a macro doesn't take parameters, it should have '(void)', rather than
'()', as its parameter list.  The error message could be better, though. :)
On Tue, Apr 14, 2015 at 11:54 AM, Isak Andersson<EMAIL_ADDRESS>wrote:

I'm not sure what I'm doing wrong but I'm getting another segmentation
fault. On OSX. Here is the code:
(import macros)
(using-namespace std.macros
(def def-type-alias (macro extern (new old)
(qq def (uq new) (macro extern ()
old)))))
—
Reply to this email directly or view it on GitHub
https://github.com/tomhrr/dale/issues/35.

Ah!
Yeah I realized that my code was wrong, but the bug report was mainly because of the segmentation fault :dancer: Trying to figure out how to build dale with sanitizers, thought it was just CXXFLAGS="-g -fsanitize=address" make. But it seems to have made no difference. Could also be that address is the wrong sanitizer for this error though.
I'll give void a try though!


Proving that is a bug on xunit.

@tig this is really a bug. Iterate though the collection it pass.

@BDisp Thanks. See: https://github.com/xunit/xunit/issues/2821


Update README.md and INSTALL.md for v6.0.0

Prepare for v6.0.0 release.

This change is

Merging this, with agreement on https://github.com/kubernetes/client-go/pull/347/files#r157535202.
I think we all agree that we have to work on these two files and simplify things. But we should do that in follow-ups, it's nothing specific to v6.


[WIP][SQL] Handle invalid UTF-8 strings in StringInstr

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Given the 3-week idle time, I'd recommend @uros-db to open a testing PR to your forked repository.
Both opening a PR to Apache Spark repo and opening a PR to your forked repo uses your GitHub Action resources. So, I guess it's more natural for your personal testing. Let me close this [WIP].


spin-orbital MO antisymmetrized integrals ordering

I'm looking over the psi4numpy CCSD.py code and trying to figure out the order of the integrals returned by "MO_spin = np.asarray(mints.mo_spin_eri(C, C))"
https://github.com/psi4/psi4numpy/blob/master/Coupled-Cluster/Spin_Orbitals/CCSD/CCSD.py#L79
Does Psi4 order the integrals where the alpha and beta spin functions alternate? For example, even-numbered orbitals corresponding to alpha, and odd-numbered to beta.
Also, are the integrals of the form  [phi_i(1) phi_j(1) 1/r_12 phi_k(2) phi_l(2)] or <phi_i(1) phi_k(2) 1/r_12 phi_j(1) phi_l(2)>?
Thank you

Does Psi4 order the integrals where the alpha and beta spin functions alternate? For example, even-numbered orbitals corresponding to alpha, and odd-numbered to beta.

Yes, it starts with alpha electrons, and goes on to beta. even/odd indexing of alpha/beta happens because the indexing starts from 0 for arrays in python (that's also the case for C/C++, but not Fortran)

Also, are the integrals of the form [phi_i(1) phi_j(1) 1/r_12 phi_k(2) phi_l(2)] or <phi_i(1) phi_k(2) 1/r_12 phi_j(1) phi_l(2)>?

If this is a question regarding the convention being used, then the integrals obtained are in chemist's notation i.e.
$$[ij|kl] = \int dx_{1} \int dx_{2} \   \chi_{i}^{*}(x_1) \chi_j(x_1) \frac{1}{r_{12}} \chi_{k}^{*} (x_2) \chi_l(x_2)$$
where coordinate $x$  is used to represent both spatial coordinates $r$ and spin $\omega$ of the electron. (For reference see Szabo and Ostlund)


Codecov CI error uploading report

Describe the bug
Originally from #2006 (comment), but also seen at #2007.
The reported error is related to upload.
To Reproduce
Steps to reproduce the behavior:

Go to any PR updated on the last days and see the failing workflow.

For example: https://github.com/pvlib/pvlib-python/actions/runs/8659882128/job/23746657398?pr=2006#step:10:102

Expected behavior
To be uploaded correctly.
Screenshots

Versions:
N/A
Additional context
These links may be useful:

Long discussion at https://github.com/codecov/codecov-action/issues/598
What seems to be the problem and the fix, instructions, https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954

Pinging @pvlib/maintainers, I can't be of help with this issue.

Thanks @echedey-ls.  Looks like codecov very recently made it easier for us to solve this problem: PRs from forks no longer require a codecov token to upload coverage data.  It seems to be working, at least in #2022.
However, coverage also gets uploaded when new commits land on main.  From the codecov docs, I think these uploads will not be able to use the "tokenless" route available for PRs.  For that, I have added a github secret with a codecov upload token.
With those two changes, I think this problem will be solved.  I will proceed with merging #2022 and see if things work as expected on main.

Looks like everything is working after the second PR (#2024): https://app.codecov.io/gh/pvlib/pvlib-python/commit/25ec2968d97af1a0ad9814dc559b7ebaaaa619e2
PR uploads may still randomly fail; I don't think there's much we can do about that, at least for now.  Re-triggering failed jobs continues to be the workaround.
Thanks @echedey-ls for making an issue :)


Add in rank heatmap

This can help allow for diagnostics for posterior distributions of the resulting ranks.

Hey Jamie I am interested in this issue, could you assign to me?
Just to make sure we are on the same page, do you have any sample images of how you would like this plot to look?

Thanks @nbokulich !
There are 2 types of heatmaps that are used in the paper.
Heatmap of the conditional probabilities (below)

This was just using seaborn, highlighting some of the microbes of interest.  The challenge here will be to figure out the minimal functionality to expose to users (i.e. probably don't want to enable filtering / sorting in the first pass).
Paired heatmap to show matched microbes to metabolites.  The right figure are the abundances of 2 microbes across samples, the left figure is the top 50 metabolites for each of these microbes across samples.

This will be harder to pull off, since it may require more interactively (but would be great, because this is very tedious to put together manually).


Arabic letters with Arial fonts doesn't work in Oracle Linux 8

Hi,
On windows we have Arial fonts in a jar file that located in "C:\Program Files\Apache Software Foundation\Tomcat 9.0\webapps\JasperReportsIntegration\WEB-INF\lib" and it works fine, but on Oracle Linux 8, we did the same thing but it doesn't work.
Any help ?
Thank you.

Hi @HamzaAlabbasi,
did you figure it out?
I would have guessed that it works. The way you created the fonts, might there be a path registered in the generated .jar file? This might not work on Linux.
Alternatively, can you install the fonts locally on the Linux server so that the Java runtime can access the locally installed fonts?
Good luck, Dietmar.


include/drivers/flash: document on the unrestricted alignment of reads

Unaligned read-out capability become fact among all drivers.
Let's cut this in stone as API requirement.
fixes #16439
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

Blocked by #25292

API Meeting:

@nvlsianpu did you check all the current drivers beyond the qspi?
@nvlsianpu did you consider a compile-time option? I seem to recall you did, but I don't remember what the outcome of that dicussion was
During the API meeting it was suggested we could default to not supporting unaligned access unless a Kconfig option is enabled, hence the previous question

This will be scheduled for discussion in the next API meeting.

Blocked by #25292

I don't think that PR blocks this change, but it highlights that QSPI needs work before the new requirement can be confirmed.  That is a minimal change for a very specific function to support using an external flash to store the alternative image for mcuboot (fixing #25289).
Also we should extend the promise ofs to not only alignment but memory region: i.e. that it is permitted to writes of data that is located in flash, rather than RAM, which impacts any implementation (like QSPI) that uses DMA that only works on RAM addresses.

https://github.com/zephyrproject-rtos/zephyr/pull/26772 going to add unrestricted alignment of reads for nordic qspi flash driver.

@pabigot

We should also document the expectations regarding memory region for material written to the device. In particular that even if a device only supports DMA, and DMA requires the source buffer be in RAM, that it must still be permitted to write material where the source buffer is in flash. Or, if that is not required, document that on some devices such writes may fail and will return a particular error code.

For being consistent I prefer to force all to support source buffer anywhere.

@pabigot Added note on write source buffer location.

@pabigot Added note on write source buffer location.

Thanks @nvlsianpu. @pabigot please take another look.


is this package using UIWebView

After update my app and try upload to Apple store ,
I got this message

ITMS-90809: Deprecated API Usage - New apps that use UIWebView are no longer accepted. Instead, use WKWebView for improved security and reliability. Learn more (https://developer.apple.com/documentation/uikit/uiwebview).

So I want to know if this package still using  UIWebView ?

I solved it by remove pod 'TwitterKit' from Podfile.


Unable to open any file from a particular workspace from terminal

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: 1.61.2
OS Version: Ubuntu 20.04.2

Description
I am not able to open any file from a particular workspace from terminal. Also I am unable to open that particular workspace. Although I am able to open those file using other editors. Restarted my computer, but I am facing the same problem.
Since, its strange, I suspect that some cache has got corrupted. How can I clear all cache (without deleting any extension or vscode settings)?
What I tried?
cd "${HOME}/.config/Code"
rm CachedData/* Cache/* User/workspaceStorage/*

Help
How can I delete all kinds of cache stored by vscode except extension and settings?

@IllusionMH

What error or behavior do you see when you try to do that?

Nothing happens, the file won't open. No error. Even when opening from terminal like code "${FilePath}", nothing happens!

Can you open VS Code and than open that workspace trough UI?

No

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

@bpasero  I would like to substantiate my issue with recent observations:
I start a workspace from cron, when my Ubuntu 20.04 reboots. I can see that the vscode opens the workspace but without GUI  as can be seen in the following when I check the status:
$ code -s
(code:12560): Gtk-WARNING **: 09:57:56.472: Theme parsing error: gtk.css:10:4: Expected semicolon

(code:12560): Gtk-WARNING **: 09:57:56.472: Theme parsing error: gtk.css:12:4: Expected semicolon
(code:12560): Gtk-WARNING **: 09:57:56.500: Theme parsing error: gtk.css:8916:21: Not using units is deprecated. Assuming 'px'.
Version:          VScode 1.62.2 (3a6960b964327f0e3882ce18fcebd07ed191b316, 2021-11-12T00:22:43.314Z)
OS Version:       Linux x64 5.4.0-90-generic
CPUs:             Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz (8 x 1275)
Memory (System):  7.67GB (2.12GB free)
Load (avg):       13, 10, 5
VM:               0%
Screen Reader:    no
Process Argv:     --ms-enable-electron-run-as-node --new-window --extensions-dir /home/nikhil/Documents/Git/Life/PersonalManagement/PersonalManagementSrc/Workspace/Linux/.Ws/Extension /home/nikhil/Documents/Git/Life/PersonalManagement/PersonalManagementSrc/Workspace/Linux/.Ws/Linux.gen.code-workspace
GPU Status:       2d_canvas:                  enabled
                  gpu_compositing:            enabled
                  multiple_raster_threads:    enabled_on
                  oop_rasterization:          disabled_off
                  opengl:                     enabled_on
                  rasterization:              disabled_software
                  skia_renderer:              enabled_on
                  video_decode:               disabled_software
                  vulkan:                     disabled_off
                  webgl:                      enabled
                  webgl2:                     enabled

CPU %   Mem MB     PID  Process
    0      149    2928  code main
    0       39    2931     zygote
    0      259    2993       gpu-process
    0       24    3030         broker
    0       39    2933     zygote
    0        8    2938       zygote
    0       55    3044     utility
    0      220    3108     window (Linux.gen (Workspace) - DisplayFunctions.sh)
    0      149    3526       extensionHost
    0       79    8078         electron_node server.js
    0        0   12562         git status -z -u
    0       71    3541       watcherServiceParcel
    0      118    3509     shared-process
    0       71    3557       ptyHost
    0        8    3769         /bin/bash
    0        8    8455         /bin/bash
    0        0   12543           sh /usr/bin/code -s
    0       63   12548             /usr/share/code/bin/../code /usr/share/code/bin/../resources/app/out/cli.js --ms-enable-electron-run-as-node -s
    0      118   12560               /usr/share/code/code --ms-enable-electron-run-as-node -s
    0       39   12565                 zygote
    0       63   12595                   gpu-process
    0       24   12601                     broker
    0       39   12566                 zygote
    0        8   12568                   zygote
    0       47   12610                 utility
    0        0   12621                 /bin/sh -c /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0        0   12622                   /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0      212    8399     window (VScode)
    0      110    8429       extensionHost

Workspace Stats:
|  Window (Linux.gen (Workspace) - DisplayFunctions.sh)
|    Folder (TestRepository): 151 files
|      File types: md(17) 0(11) ~1~(11) trashinfo(11) tsv(9) json(9) mp4(6)
|                  ~2~(6) ~3~(6) ~4~(6)
|      Conf files:
|    Folder (DotFiles): 939 files
|      File types: py(70) json(69) md(44) log(40) wav(33) desktop(32)
|                  backup(30) mp3(30) sh(27) txt(23)
|      Conf files: settings.json(3) package.json(1)
|    Folder (Backintime): 169 files
|      File types: md(15) 0(11) markdown(9) ~1~(9) trashinfo(9) tsv(8) log(8)
|                  json(7) 1(4) html(4)
|      Conf files:
|    Folder (Architecture): 9644 files
|      File types: md(3301) png(489) ~1~(372) ~2~(247) txt(221) ~3~(184)
|                  sh(165) html(159) ~4~(138) ~5~(107)
|      Conf files: makefile(16) package.json(3) grunt.js(1)
|    Folder (GitScripts): 1232 files
|      File types: md(273) sh(60) js(58) png(55) json(54) gif(53) markdown(31)
|                  txt(29) diff(24) ~1~(22)
|      Conf files: package.json(8) tslint.json(2) launch.json(2)
|                  webpack.config.js(2) settings.json(1) tasks.json(1)
|    Folder (AmazingNotes): 2602 files
|      File types: md(345) sh(129) js(82) markdown(70) trashinfo(64) pdf(60)
|                  html(56) css(54) ~1~(49) png(47)
|      Conf files: makefile(29) package.json(6) dockerfile(2) launch.json(1)
|                  settings.json(1) gulp.js(1)
|      Launch Configs: bashdb(3) python

And, since the vscode is running (with the workspace), I am unable to start the same workspace again (even though it does not let me access its GUI).
So, is it possible to show the GUI?

Is it intentional that you see no GUI or a bug?
//cc @deepak1556 on the GTK warnins

I start a workspace from cron

What command are you using to launch vscode from the cron ? Also, are you using snap or deb installation ?

I am sorry, I corrected my last comment.
I start vscode using systemd (user daemon) and not cron.
[Unit]
Description=Editor Service

[Service]
ExecStart=/bin/bash -c '. "$0" && exec "$@"' %h/.bashrc.d/Custom.bash %h/.config/MySettings/WsBeforeShutdown.sh
Type=forking
Restart=on-failure
RestartSec=10
SyslogIdentifier=EditorService

[Install]
WantedBy=graphical-session.target

This executes bash script ~/.config/MySettings/WsBeforeShutdown.sh, which executes Vscode with the path to the workspace last opened before Shutdown:
code /home/nikhil/Documents/Git/Life/PersonalManagement/PersonalManagementSrc/Workspace/Linux/.Ws/Linux.gen.code-workspace

Are you able to open other GUI application via systemd with that configuration ?

This executes bash script ~/.config/MySettings/WsBeforeShutdown.sh, which executes Vscode with the path to the workspace last opened before Shutdown:

VSCode should restore the workspace it had open when re-launching the application from the dock or cli. Can you avoid using a systemd setup to perform this operation if it is the only use case ?

Yes I am able to run Firefox, Thunderbird with similar scripts.
Actually my script does a little bit more stuff. If there were multiple workspaces it opens both. Also, it populates the PATH environment variable differently depending on the workspaces.

Also, are you using snap or deb installation ?

It is installed using deb file

@anishmittal2020 can you clarify why you need to start VSCode with a cron job exactly?

@bpasero I start it with systemd as corrected  in my previous comment. I have also included the unit file.
I use it to start vscode automatically after reboot.

@anishmittal2020 is there maybe another way on Linux to let an application run on startup that would ensure the UI is also visible?

@bpasero as I mentioned above I am able to use systemd to start other gui applications like Firefox, thunderbird. Also, sometimes the vscode gui starts perfectly, but other times there is no gui.

Does it help if you configure --disable-gpu as argument to launching VSCode?


Add new easier mappings for slurp and barf

The default mappings for paredit ">)", "<)" and such are not easy to use and also are not intuitive. This PR remaps them to <localleader>a|A|d|D, where a and d move the closure of current form backwards or forwards and A and D revert these same movements (in the spirit of vim).

Hey thanks for your contribution, I'm talking to @practicalli to create a bigger and more opinionated version of cajus, while keeping this repo simpler as a startup or a bootstrap for your nvim+fennel config.
When we have more details about this repo I will comment here and we can discuss if this improvements can be done there :)


backgroundPermissionRationale is not working on Android

Your Environment

Plugin version: 4.2.2

Platform: Android

Device OS version: 11

Capacitor info (npx cap doctor)

Latest Dependencies:
@capacitor/cli: 3.1.2
@capacitor/core: 3.1.2
@capacitor/android: 3.1.2
@capacitor/ios: 3.1.2

Installed Dependencies:
@capacitor/cli: 3.1.2
@capacitor/android: 3.1.2
@capacitor/core: 3.1.2
@capacitor/ios: 3.1.2
Expected Behavior
On Android devices, a pop up declaring why I'm using background geolocations should appear.
Actual Behavior
The backgroundPermissionRationale dialog is not showing.  It goes directly to the permission request.
Steps to Reproduce

Add both @transistorsoft/capacitor-background-fetch and @transistorsoft/capacitor-background-geolocation to package.json
run npx cap sync android
run npx cap open android
Run app in simulator

Context
I have the following config set up:
const state = await BackgroundGeolocation.ready({
    desiredAccuracy: BackgroundGeolocation.DESIRED_ACCURACY_HIGH,
    distanceFilter: 1000,
    stopTimeout: 1,
    startOnBoot: false,
    debug: false,
    logLevel: BackgroundGeolocation.LOG_LEVEL_OFF,
    locationAuthorizationRequest: "WhenInUse",
    backgroundPermissionRationale: {
        title: "Allow XXXX to access to this device's location in the background?",
        message: "XXXX uses background location services to track where the service techs are and shows them on the desktop schedule map view.  In order to track your activity in the background, please enable {backgroundPermissionOptionLabel} location permission",
        positiveAction: "Change to {backgroundPermissionOptionLabel}",
        negativeAction: "Cancel"
    },
    locationAuthorizationAlert: {
        titleWhenNotEnabled: "Location services are not enabled",
        titleWhenOff: "Location services are off",
        instructions: "XXXX requires background location tracking to be turned on. You must enable 'Always' in location-services",
        cancelButton: "Cancel",
        settingsButton: "Settings"
    }
})

if (!state.enabled)
    BackgroundGeolocation.start();

When I run in the emulator, I do not get any kind of pop up window explaining why I'm using background mode.
I've also tried using locationAuthorizationRequest: "Always",, to no avail.

You're likely using targetSdkVersion < 30.
Use 30


Generic verify function

The "built-in" functions are convenient, but maybe you want to add your own check quickly.
Give a function that takes a DataFrame, does it's operation, and asserts it's Truthiness.
def verify(df, func, *args, **kwargs):  # defined in engarde
    assert func(df, *args, **kwargs)

df.pipe(verify, lambda x: x > 0)

The above naive implementation would probably fail since the truth of Series([True, True]) is ambiguous. Is it too magic to automatically reduce that down to a True with a np.all?
Should also make a decoratize function that makes arbitrary functions usable in decorators.

I do think it's "too magic", it should be more explicit.  I think you can get that done, via a solid naming convention.  Consider,  "verify_all", "verify_any".  Might do it.
But, bigger picture here, this is where I'm stuck.  I sat down tonight, and thought a bit harder about both the API, and slicing, and the plans for the kinds of tests I want/plan to contribute.  I'm going to add some notes to my other PR...

Great thanks.
I promise to be a better maintainer starting next week :wink: Real-life stuff has taken priority the last couple weeks, but I want to get this polished and usable before PyData Seattle at the end of July.


Add missing migration for Browse Page

Additions

migration for Browse page

Testing

cfgov/manage.py migrate

Review

@chosak

For the record, this PR is necessary because of a missed change to a StreamField block in PR #2415. :+1:


provider: upgrade Docker to v1.11

Install Docker 1.11 on machines instead of v1.9.

Remove apt-get update optimisation. Ignoring the universe repo prevents
successful install of Docker 1.11 dependencies.

Make sure that Docker API calls to /container/create use nonempty HostConfig.
Empty HostConfig worked with Docker 1.9 but fails on 1.10+.

Can't download 1.12 yet.
Provides:
1.11.2-0~wily -
1.11.1-0~wily -
1.11.0-0~wily -
1.10.3-0~wily -
1.10.2-0~wily -
1.10.1-0~wily -
1.10.0-0~wily -
1.9.1-0~wily -
1.9.0-0~wily -
1.8.3-0~wily -
1.8.2-0~wily -
1.8.1-0~wily -
1.8.0-0~wily -
1.7.1-0~wily -
1.6.2-0~wily -
1.6.1-0~wily -
1.6.0-0~wily -
1.5.0-0~wily -

Commit message should be "provider: Upgrade Docker to v1.11". You forgot to capitalize "Upgrade" 😃

Done with first round review

ready for more review~!

Merged


Creds-init writes to fixed location when HOME override is disabled

Changes
Fixes #2165
Relates to https://github.com/tektoncd/pipeline/issues/2013
When the disable-home-env-overwrite flag is set to "true" each Step in a Task can conceivably have its own HOME directory. The concept of "HOME" is further muddied in systems that randomize the UID of containers.
When the disanle-home-env-overwite flag is set to "true", creds-init will write its credentials to /tekton/creds instead of /tekton/home.  Then the entrypoint binary will copy the credentials from /tekton/creds into $HOME before the Task's Steps are allowed to run.  The upshot of all this is that the change here should be completely transparent to the user - they shouldn't notice a single difference.
For those users who were for some very specific reason actually relying on the credentials being in /tekton/home we'll now expose a new variable substitution: $(credentials.path) will get replaced with the directory that creds-init writes to - either /tekton/home or /tekton/creds depending on the state of the disable-home-env-overwrite flag.
This is a stop-gap measure as we work towards beta. It seems that we will probably need to revisit our recommendations around auth and the contract we're making with creds-init.

[x] Variable replacement for $(credentials.path)

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Users who disable Tekton's HOME env overwrite will now find that git and docker credentials are written to a volumeMount, /tekton/creds, before they're copied into $HOME by the entrypoint. A new variable replacement has been introduced, $(credentials.path), which expands to the directory where creds-init writes its credentials, either /tekton/home or /tekton/creds.

/hold
Want to look at this again with fresh eyes on Monday before committing.

I've written up a very short design doc covering the solution in this PR and a slight alternative.  Doc here: https://docs.google.com/document/d/1SVuDt-SXPHymz41dveSXFSPrx5Z-Wzb9eHliJAyYg4o

Note to self: This would probably break PipelineResources when the disable-home-env-overwrite flag is enabled (and eventually flipped to on by default in the following release).  Might need to update PipelineResources to account for this.

Updated to write to /tekton/creds instead of /tekton/home.
Still looking at:

Variable replacement for $(credentials.path)
Fixing PipelineResources to work with the credentials path.
Some kind of integration testing (though at the moment I might have to postpone this until after the flag gets flipped to be default true... not sure)

I've added variable replacement from $(credentials.path) to /tekton/home or /tekton/creds depending on what the disable-home-env-overwrite flag is set to.
I've updated the git PipelineResource to deal with the possibility that creds are in /tekton/creds instead of /tekton/home.

This change should be pretty much invisible to users now, no extra copying in their Steps should be necessary.  The entrypoint binary now copies the creds into $HOME instead of creds-init (when the disable-home-env-overwrite feature flag is true) so the net result is the same regardless of the feature flag: creds end up in container HOME dirs.

/hold cancel
I think this is probably ready for review now.

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-build-tests


Adding --strict-vcf flag

See #244

In the future, I'll probably make this default, and switch it so that the old way is only optionally enabled. There are a number of other compatibility tweaks I'd like to put in; for instance the DP4 field and such.


Promiscuous mode net sample cannot be build

Describe the bug
The subject says it all ..
To Reproduce
Steps to reproduce the behavior:

cd zephyr/samples/net/promiscuous_mode && mkdir build && cd build
cmake -DBOARD=qemu_x86  ..
make run
See error
...
[  7%] Building C object CMakeFiles/app.dir/src/main.c.obj
zephyr/zephyr/samples/net/promiscuous_mode/src/main.c:17:10: fatal error: net/tcp.h: No such file or directory
#include <net/tcp.h>
^~~~~~~~~~~
compilation terminated.

Expected behavior
Compilation successful
Impact
obvious
Environment (please complete the following information):
Linux/ SDK 0.10.0

It's also important to ensure this failures are caught automatically


Fix failing python 3.7 tests

following Dylan's advice to see if removing the cache step (and replacing it with caching from the setup-python action) fixes the failing python 3.7 tests

Codecov Report

Merging #152 (5232765) into main (c157e4b) will decrease coverage by 31.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #152       +/-   ##
===========================================
- Coverage   75.19%   43.62%   -31.57%
===========================================
  Files          34       34
  Lines        3080     3076        -4
  Branches      646      646
===========================================
- Hits         2316     1342      -974
- Misses        571     1630     +1059
+ Partials      193      104       -89

Impacted Files
Coverage Δ

plenoptic/synthesize/eigendistortion.py
17.33% <0.00%> (-77.34%)
:arrow_down:

plenoptic/synthesize/autodiff.py
20.00% <0.00%> (-66.67%)
:arrow_down:

plenoptic/tools/display.py
7.74% <0.00%> (-60.15%)
:arrow_down:

plenoptic/simulate/models/portilla_simoncelli.py
9.75% <0.00%> (-57.12%)
:arrow_down:

plenoptic/simulate/models/frontend.py
54.20% <0.00%> (-39.26%)
:arrow_down:

...simulate/canonical_computations/non_linearities.py
54.90% <0.00%> (-39.22%)
:arrow_down:

plenoptic/synthesize/mad_competition.py
38.87% <0.00%> (-38.31%)
:arrow_down:

plenoptic/synthesize/metamer.py
42.00% <0.00%> (-34.75%)
:arrow_down:

...e/canonical_computations/steerable_pyramid_freq.py
56.79% <0.00%> (-29.65%)
:arrow_down:

...enoptic/simulate/canonical_computations/filters.py
74.28% <0.00%> (-22.86%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c157e4b...5232765. Read the comment docs.


Add MapViewPlus

Project URL
https://github.com/okhanokbay/MapViewPlus
Category
Maps
Description
MapViewPlus gives you the missing methods of MKMapView which are: imageForAnnotation and calloutViewForAnnotationView delegate methods.
Why it should be included to awesome-ios
Implementing custom callout views and image annotation views seems easy at first but when you dive deep into it, you see how tricky it can become. MapViewPlus covers all of these trickiness and just asks you for the UIView instance for callout view and UIImage instance for annotation view. It handles the rest and deals with the limitations of MKMapView itself. Also, allows you to use cool spring animations.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

2883
301
http://www.ioscookies.com/ redirects tohttps://www.ioscookies.com/

  Generated by :no_entry_sign: Danger


Duplicate button does not work

duplicate button doesn't work...

I can't duplicate this - is it happening across all your sites/blocks?

right so i just checked back on this matter to make sure I'm not messing around, basically, I noticed only top-level sections can be duplicated, here's an example:


Convert to jetpack compose

@hafizsaadiftikhar I see you have closed original PR https://github.com/Minimalistic-Apps/price-converter/pull/18 and created this one instead.
Please lets not do this and lets keep our work in one place so we can check that all comment were sorted out.

-> https://github.com/Minimalistic-Apps/price-converter/pull/20


Added information for connecting to an Oracle Express DB

Hey, thanks for this plugin, I needed it desperately. Also, would it be very difficult to make a Logstash 1.5.0 compatible gem?

Thanks for the patch, its appreciated.
It's on my todo list to convert this to be 1.5 compatible (it's currently holding up my progress in upgrading to 1.5, so it will happen). However, it's not the top of my todo list right now.
I've not really done much investigation to see how hard it will be yet. I did have a 2 minute search for documentation on upgrading plugins a few weeks ago - but didn't come across anything obvious at the time :disappointed:

Cool then! I will look for some solutions too when I find some time :D


description wording recommendations

Self Checks

[X] I have searched for existing issues search for existing issues, including closed ones.
[X] I have searched for existing pull requests search for existing pull requests, including closed ones.

Provide a description of requested docs changes
Any method (I recommend we use any "channel"): Different users are familiar with different forms of data access, we hope users can access data through various means, including but not limited to: SQL, DataFrames, HTTPS, gRPC, FTP, WebDAV, FUSE
Any data (I recommend we use any "format": Users should be able to access data in any format, such as: JSON, CSV, ORC, XML, XLSX, BLOB
Across any service (I recommend we delete "across") : Users’ expected data storage services also vary, we hope users can access, transfer, and control data in any service, such as: RPC, S3, IPFS, Azblob, HDFS, Google Drive, BigQuery, WebDAV, MySQL, PostgreSQL

Hi @Lukisong82
Suggestions are welcome~
“Method” encompasses various ways of data access and operations, such as SQL queries, DataFrame manipulations, HTTPS requests, and gRPC calls. These are technical means or interfaces for achieving data interaction and are concepts familiar to developers and data consumers.
“Channel” often refers to the path or medium of data transmission, such as network channels and communication protocols. It emphasizes the pathway of data transfer rather than how data access or operations are conducted, which can be misleading and suggest it only involves communication-level technologies.
“Any Data” refers not only to the format of data but also to its content and semantics. In data science and data engineering, data involves more than just format—it includes the processing and analysis of data content. This covers traditional big data storage (such as HDFS) and vector databases in AI, representing not just format differences but distinctions in data content and application methods across different scenarios.
“Any Format” might be misunderstood as merely supporting different file formats or data structure forms.
If there are more ideas, we can continue to discuss them further.


Enhance the Feature Template

📋 Description
Purpose and Goals:
This feature is being added to improve the project by enhancing functionality and user experience. It aims to provide new capabilities that meet user needs and add value to the project.
Core Functionality:
This feature will enable users to [describe specific functions and capabilities, e.g., "filter search results by categories" or "track user activity"]. This will improve usability and project performance.
Dependencies:
This feature relies on:

[Library/Dependency Name] for [purpose, e.g., "data visualization"]
[API Name] for [data retrieval]
Any other project components or services this feature depends on

🔨 Changes Made

Added [specific functionality]
Updated [existing components for compatibility]
Refactored [code areas or modules for efficiency]
Fixes #347

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation (if applicable).
[x] My changes generate no new warnings.
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[x] Bug fix (non-breaking change which fixes an issue) 🐛
[x] New feature (non-breaking change which adds functionality) ✨
[x] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

🤝 Related Issues

Fixes #347

📸 Screenshots (if applicable)
N/A
Reminder:
Please ensure your pull request is made to the test branch, not main.
Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

@Vignesh025  the task has been Completed. Kindly review the PR

Thanks for Contributing!


SvelteKit release candidate migration: privacy page

Migrated existing Svelte code from /privacy.
Requires #547 Block component

Replaced by mega-PR #577.


New User: FINN.no

Name: FINN.no AS
Homepage url: https://finn.no/
Brand Guidelines/Licensing: no
Logo: https://www.dropbox.com/s/lk6nsy46cwz49i3/finn.svg?dl=0

Nice, wanna open a PR for it? Here's some examples


Unable to save a component which previously failed validation

Resets the serverside validation when a complex editor, like NestedContent, is not validated properly the first time.

Thanks!


feat: ledger poc

Try out this version of the Hiro Wallet - download extension builds.

To remove
Currently this PR contains auth related changes not to be merged.

[x] Fix send form render loop
[x] Fix settings drop down missing items in ledger mode
[x] Add Ledger item to settings drop down
[x] Update sign out modal with new copy
[x] Onboarding flow
[x] Send tokens flow
[x] Transaction signing flow
[x] Ledger specific analytics
[x] Polish inline UI errors
[x] Add waiting animation to approve screen
[ ] Fix scroll bug on tx signing
[ ] Increase fee flow
[ ] Integrate animations

Thanks for keeping progress in the open.
Can you gives us a heads up whenever there is something here (even if its very early) for us to play with on the PR build, please 🙏 ?

No illustration is showing up for me in the first prompt:

This URL should go to https://www.hiro.so/wallet-faq/how-can-i-use-my-ledger-device-with-hiro-wallet

If I select cancel in my browser during connection, the screen goes blank:
https://user-images.githubusercontent.com/28991/161964772-11c3ea1b-210a-4798-bda8-b064bba08c51.mov

If I close the connection modal, the screen also goes blank:
https://user-images.githubusercontent.com/28991/161965324-3c10e83b-dc4a-4679-804c-156fbf0e9a96.mov

I'm getting an error and blank screen upon connecting my Nano X:
https://user-images.githubusercontent.com/28991/161968722-d2a6ff43-e582-4ea5-84eb-ff0f6c22ee6d.mov
Note that I'd previously confirmed selection of the device in the browser's prompt in a previous attempt, which is why it doesn't show again in this video apparently.

Sorry @markmhx, these are all relating to the lottie animation CSP issue. Commenting it out and should work in the next build. I'll let you know when ready.

I'm able to connect with the latest build, but now I see the unlock screen unexpectedly after connection is confirmed as a success, instead of a password entry screen?

Image isn't loading here:

I found a thing ™
If your ledger has let's say 10k STX being stacked and 3k STX unclocked, the web wallet will only show the available tokens.
I don't think this is a blocker, but we'll need an FAQ to explain what's happening and later on introduce stacking info in the web wallet.

Create an account is still there even though it doesn't do anything. It's both on the extension view as well as in the list of accounts when trying to authenticate to an app

If your ledger has let's say 10k STX being stacked and 3k STX unclocked, the web wallet will only show the available tokens.

My suggestion here is that we show all tokens instead of just the unlocked (available) tokens in the UI for this release (with the idea that we distinguish these balances as in the desktop wallet as a fast-follow enhancement).
It's scarier to not see some of your tokens than to see all of them then later hit an error when you try to take an action that requires more STX than clearly available.

@andresgalante RE 4: I have a feeling that this is because you're using an out of date version of the Ledger app. If you update in LL, do you still see it

should we handle ledger app versions in the wallet? show a msg if a users is using an out of date version?

Definitely. Would this check be performed during the "connecting" part flow? Could we use the inline alert for this? With this info I can add this case to the prototype.

I was running 0.19
I'll delete the app, install it from zero and try again

I have the same issue as @andresgalante. My Ledger Live app was out of date, so I updated it to 2.40.02. Stacks app was already installed v0.19. The error toast keeps appearing.
https://user-images.githubusercontent.com/239215/162204119-1fcd87c4-4e54-45a7-af5e-a7d5d274be00.mp4

If the Ledger Live app is open, the toast appears on page reload and after clicking Connect
If the Ledger Live app is closed, the toast appears only after clicking Connect

I then deleted the Stacks app in Ledger Live and re-installed it. The error toast keeps appearing.

The Stacks app was not open in Ledger. So I opened it, and then it worked! So I guess the error was related to Stacks app not being open after all. Is that specific error screen implemented @kyranjamie ?

Testing the Send flow, I've noticed the Wallet verification screen shows fewer transaction details than the Ledger screen. The wallet shows only 2: Recipient and Amount, while the Ledger screen shows Origin, Nonce, Fee, Amount (uSTX), To, Memo.

Note that on the Ledger, the Amount is described as Amount (uSTX), since it's a different unit. More on this discrepancy in the next message.

As mentioned here, we are not showing in the transaction details verification screen on the Wallet side. For example, in my experience, I wanted to send 3 STX from my Ledger. As I went through the Send flow, the transaction verification screen was showing 300000 in, which I assume is STX since that's what the Send screen was asking for. Later, @kyranjamie explained that the Ledger uses uSTX, which they clarify in their UI. Still this is a discrepancy that is confusing as it is.
Can we display STX in the Ledger, instead of uSTX?
If not, we should match what the Ledger shows so that it's not confusing to the user. Maybe also add a clarification or the conversion to STX in a tooltip next to the amount value.

Amount values are inconsistent during the transaction verification details process. There were a few times that the amount was shown as 0.

Memo values are inconsistent. There were a few times the memo message didn't go through to the Ledger device during verification. And a few times I saw the memo message from a previous transaction on the Ledger screen.

Aborted transactions are not in sync between Ledger and Wallet. Tested with the Send flow

I start a transaction and on the verification step I don't approve/reject on Ledger but I close it on the Wallet.
I initiate a new transaction on the Wallet and that derives in a Disconnected ledger error message, while the Ledger screen shows the approval/rejecting state from the previous transaction

Seems the Ledger and Wallet are not in sync when the transactions are not promptly accepted or rejected.

Another thing to consider: right now, clicking on the backdrop area of the modal closes the Ledger dialog. I think it would be better to remove this functionality and just allow closing it via keyboard (esc) and clicking on the close X button only.
I just accidentally clicked while verifying the transaction and I lost my progress.

As mentioned here, the amounts are shown in different units during the Send flow with Ledger. For example, in my experience, I wanted to send 3 STX from my Ledger. As I went through the Send flow, the transaction verification screen was showing 300000 in, which I assume is STX since that's what the Send screen was asking for. Later, @kyranjamie explained that the Ledger uses uSTX, which they clarify in their UI. Still this is a discrepancy that is confusing as it is.
Can we display STX in the Ledger, instead of uSTX? If not, we should match what the Ledger shows so that it's not confusing to the user. Maybe also add a clarification or the conversion to STX in a tooltip next to the amount value.

In the case we can't display the amount in STX in the Ledger device, here's what we could show in the wallet to clarify the different units displayed.

Making a note here to handle error message in ext popup when the full page view is open:

We've recently discovered that there are edge cases to cover related to having the Wallet installed but not yet set up (account not yet created). This can happen if the user drops off the happy path and does not continue the setup as intended.
There are 3 paths, where the user resumes the setup:

Creates an account from a new tab
Creates an account from the Hiro Wallet extension widget
Creates an account when trying to connect to a dApp

The problems

For (2) choosing Ledger will not work as it requires a webpage to connect the USB device to the browser.
Even if we route the user to a new tab, the experience is not optimal as they would land in a modal for Ledger. Landing on a modal is not a good practice as the user has no context on what's below the modal.

So I've been talking with @markmhx and @kyranjamie to come up with a low-effort solution to unify as much as possible and remove points of failure
Proposed solution

For Creating an account from the Hiro Wallet extension widget, we change the behavior: when the Wallet is not yet set up and there's no account, we force the onboarding in a new tab. This would make Ledger onboarding possible.
For Creating an account when trying to connect to a dApp,
-- we could detect if no account has been created and show a message in the popup that they should set up the wallet first.
-- they would click "Setup wallet" button which would open a new tab with the onboarding.
-- the popup would close and the app would return to the unauthenticated state. Meanwhile, the user would set up the wallet.
-- Once they land in the Wallet homepage, we could show a message to return to the dApp

Potential drawbacks
For the use case of connecting wallets to a dApp, today, software wallets are set up inside the widget and they provide a quick and seamless experience, without removing the user from the context of the app. By making this chase to force the setup in a new tab, this would be lost in favor of a unified setup experience.
We should definitely add telemetry to determine how often these would occur.

@landitus thanks for the description and for proposing a solution that allows us to ship Ledger and iterate later.

@kyranjamie I tested this locally and it looks like all the changes I made to creating an account are working fine. The error page is hitting a Generic error reason rather than Unauthorized so it isn't showing the <UnauthorizedRequestRedirect /> so maybe there is something hardcoded somewhere for testing ledger? Other than that, I think I will try to rebase on this now.

Given the m/888' bug and intro of jwt signing, users will need the latest version of the Stacks app. I've added this inline warning when they're below the necessary version:

Should a . be added after the second sentence? Do we typically not have one?

🤷🏼
Typically, as it's one sentence, I'd definitely omit the full stop. As it's two, the first is necessary, but then does that mean the last one is needed?  We're mainly awaiting Ledger's approval for an upgrade to the Stacks app for Ledger devices that's required to support this on the Hiro Wallet side. We're actively working with them to get it.


Implement Pull Requests API

[x] List pull requests
[x] Get a single pull request
[x] Create a pull request
[x] Update a pull request
[x] List commits on a pull request
[x] List pull requests files
[x] Get if a pull request has been merged
[x] Merge a pull request (Merge Button)

Re-opening since there's still stuff to implement:

[ ] Parameters for "List pull requests"
[ ] A way to provide media type when getting a single PR
[ ] Alternative input when creating a PR
[ ] Input for Merge Button (blocked on #43)


Consider re-directing Workshops page

What is the problem?
Recommend redirecting https://librarycarpentry.org/workshops/ to https://carpentries.org/workshops/
@sheraaronhurt  if you approve I will make the change.
Location of problem (optional)
No response

fixed with #197


Standard fields counted as custom fields (twice)

I have a custom field on Opportunity named Amount__c
OrgScore shows me 3 'Amount' custom fields, with different usages.
Also: the following Opportunity fields, despite being standard fields, are listed as custom fields twice:
CloseDate
ForecastCategoryName
Probability
StageName

I don't know about OrgScore (which might be another tool I presume) but OrgCheck in this tab is ONLY listing custom fields and not standard fields.
I did a quick test, and after adding a custom field "Amount__c" on "Opportunity", it shows the field as follow:

With the following dependencies:

For the second part of your question, again OrgCheck is only listing custom fields and not standard ones.

Sorry, I meant OrgCheck.
Here are some screenshots of the Custom Fields tab:

After a call with @vaumont and me, we discovered that the issue is in link with the use of custom metadata type.
In the previous example, the "Opportunity" object here is a custom metadata type and not a custom object.
I reproduced the error with a custom metadata type called "Opportunity" and a custom field "Amount" (text) on this cmt.

In this case visually you don't see the difference between the object and the custom metadata type.
I would say:

add a column in the table to say if the "container" of the custom field is a "Standard Object", "Custom Object" or "Custom Metadata Type"
make sure the link to the "container" is working (depending on its type for example)
make sure the link to the "field" is working as well

Little fun here for the test, I created:

a custom field called "Amount" on the standard "Opportunity"
a CustomMetadataType called "Opportunity" with a field called "Amount"
a CustomSetting called "Opportunity2" (can't use a name already used by another entity) with a field called "Amount"
an ExternalObject called "Opportunity3" (can't use a name already used by another entity) with a field called "Amount"

At this stage it looks like this:

In this case:
Let's list the Amount custom fields in CustomField table. The "amazing" (let's call it that way) column called TableEnumOrId is an id if custom (starting with 01I) or API name if standard object.
SELECT Id, DeveloperName, TableEnumOrId
FROM CustomField
WHERE ManageableState='unmanaged'
AND DeveloperName LIKE '%Amount%'

ID                  DEVELOPERNAME  TABLEENUMORID
──────────────────  ─────────────  ──────────────────
00N3V000000UiUOUA0  Amount         Opportunity
00N3V000000UiJGUA0  Amount         01I3V000000DFgZUAW
00N3V000000UhC9UAK  Amount         01I3V000000DFdkUAG
00N3V000000UiUJUA0  Amount         01I3V000000DFgeUAG

The EntityDefinition contains information to guess the type of the "container" in the QualifedApiName (only the prefix) and the IsCustomSetting (to distinguish custom obj and custom settings)
SELECT DeveloperName, DurableId, IsCustomSetting, QualifiedApiName
FROM EntityDefinition

DEVELOPERNAME  DURABLEID        ISCUSTOMSETTING  QUALIFIEDAPINAME
─────────────  ───────────────  ───────────────  ────────────────
Opportunity2   01I3V000000DFgZ  true             Opportunity2__c
Opportunity3   01I3V000000DFge  false            Opportunity3__x
Opportunity    01I3V000000DFdk  false            Opportunity__mdt

The custom object contains very few information we cannot distinguish the type...
SELECT Id, DeveloperName
FROM CustomObject
WHERE DeveloperName LIKE 'Opportunity%'

ID                  DEVELOPERNAME
──────────────────  ─────────────
01I3V000000DFgZUAW  Opportunity2
01I3V000000DFdkUAG  Opportunity
01I3V000000DFgeUAG  Opportunity3

So I would go with this pseudo algo:
List the custom field from **CustomField** and get the column **TableEnumOrId**.
IF (the **TableEnumOrId** DOES NOT start with **'01I'**) THEN {
    >> The container is a "Standard Object"
} ELSE {
    Look at the **TableEnumOrId** in **EntityDefinition**
    IF (**IsCustomSetting** = **'true'**) THEN {
        >> The container is a "Custom Setting"
    } ELSE {
        IF (**QualifiedApiName** endsWith **'__c'**) THEN {
             >> The container is a "Custom Object"
        } ELSE IF (**QualifiedApiName** endsWith **'__x'**) THEN {
             >> The container is a "External Object"
        } ELSE IF (**QualifiedApiName** endsWith **'__mdt'**) THEN {
             >> The container is a "Custom Metadata Type"
        } ELSE IF {
             >> The container is a "Custom Entity We Don't Know Yet..."
        }
    }
}

Done @vaumont !!!
Look at this!

And the link to the object (or "container") is also dynamic!
Thanks for your feedback!!


Use latest link setup for Demo

This will lead to the new try page.

Coverage remained the same at 82.598% when pulling e83a45016dea53a1da3d12027c8208673c07bddb on FinalAngel:release/3.4.x into a7ad5efb69de5bb5974092f5140f96de188ef53f on divio:release/3.4.x.


add cache and timer for dd

Implementing a configurable cache and timer for Datadog, very similar to the Cloudwatch implementation.

@robpickerill Can you please update the branch? I am not able to do it because of some conflicts.

@robpickerill Can you please update the branch? I am not able to do it because of some conflicts.

Hi @manugarg, thanks, could you try again?