Feat beautifier

Motivation
during my first PR to this repo i struggled with the tab convention over space, and had to re push a few times.
the command npm run lint should have told me what was wrong before i pushed to the repo...
Changes

Using better rules in .eslintrc to make it obvious that code adhere to the repo
Add a .jsbeautyrc file following code style so it is easier to reformat the code when contributing (using js-beautify or any code editor plugin built on top of it)
Fix a few of the most obvious lint errors and warnings

An editorconfig exists in the repository, which addresses code style. The fact that you ran into this issue is a documentation problem, in my opinion. I'm not sure if jsbeautify is useful, but the .eslintrc changes are good :+1:

@hkal, the editorconfig is not honored by every editor, that's why i think a jsbeautify does not hurt. that way you are not dependent on the editor but more on your build process or global commands
if you prefer i remove it though i don't have any objection

Could you add the jsbeatify script to the package.json scripts?

@sokra not sure what you mean by that...

Something like npm run beatify, which should beatify the code.

Thanks

I hope I'm able to merge this with the webpack-2 branch...

I improved the PR a bit: https://github.com/webpack/webpack/commit/e68108a43261cf6639c509d34fbe4e03c1d62788
It now checks for beauty files on CI and npm test


Some tests, declared as automated are really descr...

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
Some tests, declared as automated are really described in a very fuzzy way. It is not always clear what has to be tested and how, sometimes tests are 'suggested' (e.g. A.09.IR04.srv.linkage)
Proposed Change
Be more precise on the test method.

Proposed Resolution
This is addressed in the resolution of several other issues with label type:CT or type:ED

Duplicates cross cutting issue: https://github.com/inspire-eu-validation/ats-cross-cutting/issues/11


test: Added static specifier to zero-initialize structure to avoid uninit memory error.

Description:
Google internal tests detected an uninitialized memory error in running the test MainCommonTest.ConstructDestructLogger. The problem turns out to be that a structure from the external spdlog library was being used and the constructor for that structure did not initialize all data members. This was the only reference to that structure anywhere in the envoy code, and making the variable declaration static avoided the error (since static memory is zero-initialized before construction).
(Originally in https://github.com/envoyproxy/envoy/pull/4884; closed via learning a new bit of git syntax the hard way.)
Risk Level: Low; test only change.
Testing: Test passes.
Docs Changes: None.
Release Notes: None.
[Optional Fixes #Issue]
[Optional Deprecated:]

ok but I might not get to it today. Is this urgent?

Nope.  This is currently a non-problem in the envoy repository as the tests currently executed apparently don't pick up the uninitialized memory reference.  And it's covered by our (Google's) import script.  So driving this is just doing the right thing to unwind a patch in our import script.

Marking as waiting.
/wait

I believe that means I can (and should) close this PR.


Reindex API

Elasticsearch released their new Reindex API in Elasticsearch 2.3.0, does the latest version of NEST (2.2.0) make use of this API yet? If not, are there any plans to do so?
I am aware that the current client has a reindex method, but it forces you to create the new index at the time of reindexing. For my use case, the index already exists, so it's not very useful..

We already have the reindex API mapped as per #2017 which also lands the other new API's from Elasticsearch 2.3.
We're still adding the XPack related API's around graph, license and shield which I hope will land in 2.x branch early next week and in NEST 2.3 end of next week :)
The new reindex API will be mapped as ReindexOnServer() as our Reindex() is still very useful.
Our Reindex() should expose a way that assumes the index exists already, that's a great feature request :+1:

@Mpdreamz Did this function get implemented? 'Our Reindex() should expose a way that assumes the index exists already'

It did not. Created a new ticket for it: https://github.com/elastic/elasticsearch-net/issues/2164
PR's are welcome if you fancy a challenge :+1:


Prevent white-spaces within VERSION constant

The change allows white spaces and new lines in VERSION file

oops, my bad.
thanks!


Add Travis CI file

The tests are failing because perhaps the tensorflow version needs to be pinned.
See https://travis-ci.org/rht/DeepMoji.

Thanks. Yes, this does indeed seem to be because of the newest tensorflow version (see https://github.com/fchollet/keras/issues/7736). Can you in this PR also change Keras to 2.0.9 in setup.py and check that nothing is failing?

@bfelbo I have reduced the err count to 1 with keras==2.0.9 and tensorflow==1.4.0. The error persists when I tried the permutation of [keras==2.0.7, keras==2.0.9] x [tensorflow==1.3.0, tensorflow==1.4.0].
Any idea of what went wrong?

https://travis-ci.org/rht/DeepMoji/builds/298894532

(also, I will follow-up this PR with one that does macOS testing and another for PEP8 check cleanup)

Wait, it actually passed ! The Travis URL I told at ^ (https://travis-ci.org/rht/DeepMoji/builds/298894532)

Looks good! I'll merge.

Btw., sounds great with macOS testing and PEP8!


ci: Install ostree from coreos/continuous copr

ci: Drop hack to build skopeo
A new enough version is now in Fedora.

ci: Install ostree from coreos/continuous copr
Mainly to pick up https://github.com/ostreedev/ostree/pull/2548
What we really want of course is to have FCOS and build containers
that consume the continuous directly.  This is just dipping our toes
in that water.

CI can't find skopeo

Ah, right it's not in the buildroot, we were actually always building it.  Changed to just install current Fedora version.


Kong excessive configuration reloading and memory leak caused by secret creationTimestamp

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When there is multiple secrets referencing the same TLS certificate with same timestamp (replicated by kubed for example) for the same SNIs. Kong-Ingress-Controller keeps reloading the configuration (roughly every 3 seconds). These excessive reloading coupled by a memory leak cause the pod to be OOMKilled by Kubernetes.
Expected Behavior
When two TLS Secrets contains the same certificate for same SNIs, Kong-Ingress-Controller should keep the same UID in its configuration.
Steps To Reproduce
1. Deploy latest Kong chart with default `values.yaml`
2. Create 2 Secrets with same creationTimestamp and same TLS content
3. Create 2 Ingress having:
  - Same Tls.Hosts
  - Pointing each on it's own Secret created on step 2

K3D + Pulumi project to reproduce bug here: https://github.com/Elssuy/kong-ingress-controller-bug-config-reload

Kong Ingress Controller version
v2.2.0

Kubernetes version
Any Kubernetes version

Anything else?
Kubed is a tool commonly used to replicate secrets on multiple namespaces. When used it syncs secrets across namespaces and sometimes sync creationTimestamps.
My initial solution of ordering certificates returned by getCerts() in internal/dataplane/parser.go doesn't seems to work... I'm counting on your codebase knowledge to help me through this.

#2338 solves the excessive reloading issue. Memory leak might not be resolved.

@Elssuy
not sure if this is the same issue, but it sounds similar to what i just experienced (still v2.1 though)
I had old/orphaned cert-manager certificate requests which seem to have caused a loop with "updating sni.." messages in kong.
Ran up to 20Gb of mem when i saw it :)
Deleting the old certificate requests solved it.

@erSitzt Thanks for your comment.
2.1 has been released a while ago (more than a year actually). If you'd like to upgrade at some point and report if you're seeing the same issue then we could take a closer look.


equalDeep vs deepEqual

Can you elaborate on the difference of equalDeep and deepEqual in 15utility?

It should be only one functions. Let it be deepEqual() (like in assert module).

Great.
Would you prefer if I put every question in a new issue or is it ok with a bunch in https://github.com/agershun/alasql/issues/243 ?

One question - one issue. So we can keep track on each even smallest part.
When we have too many issues to maintain here we can migrate to Jira.
2015-06-23 17:28 GMT+03:00 Mathias Rangel Wulff<EMAIL_ADDRESS>
Great.
Would you prefer if I put every question in a new issue or is it ok with a
bunch in #243 https://github.com/agershun/alasql/issues/243 ?
—
Reply to this email directly or view it on GitHub
https://github.com/agershun/alasql/issues/318#issuecomment-114523925.

:+1:

equalDeep has been eleminated

:+1:


Switch between Grid and List on TabSwitcher screen

Task/Issue URL:

https://app.asana.com/0/856498667320406/1182275725806795
https://app.asana.com/0/856498667320406/1183105629066081

Tech Design URL:
CC:
Description:
Added an option to switch between Grid and List on TabSwitcher screen and fixed the problem when previews could disappear randomly.
Steps to test this PR:
Tab switcher

Open tab switcher.
Toggle between Grid and List views.

To check:

Transition animation.
Whether the setting is properly persisted.
Basic functionality (removing tabs, reordering, swipe to delete).
When list mode is enabled, new previews are not stored in the file system cache (old ones will be purged when given tab is removed or when app is restarted).
General smoke tests.

Previews improvements

Migration from previous version should work.
Old previews location (Cache dir) should be purged.
As old one, new location should not be backed up.
Auto Clear functionality and tabs purging/removing should also remove previews.

Orientation Testing:

[x] Portrait
[x] Landscape

Device Testing:

[x] iPhone SE (1st Gen)
[x] iPhone 8
[x] iPhone X
[x] iPad

OS Testing:

[x] iOS 10
[x] iOS 11
[x] iOS 12
[x] iOS 13

Theme Testing:

[x] Light theme
[x] Dark theme

Internal references:
Software Engineering Expectations
Technical Design Template

Thank you!


Community Questions 02/05

https://community.influxdata.com/t/influxdb-error-http-tls-handshake-error-from-x-x-x-x-eof/17968/3
https://community.influxdata.com/t/query-too-slow-when-group-by-small-time-interval/18003
https://community.influxdata.com/t/influx-freezes-vm-maxing-out-memory/17960/5
https://community.influxdata.com/t/deleting-data-that-hasnt-updated-in-the-last-7-days/18067
https://community.influxdata.com/t/influx-v2-telegraf-configuration-on-docker/17557/8
https://community.influxdata.com/t/use-influxdb-docker-container-in-a-commercial-product/18132/2
https://community.influxdata.com/t/batch-kapacitor-tick-to-influx-2/18144/4
Thank you!

@danxmoran @docmerlin Try to answer what you can and check off the ones that get responded to.  Thanks.


cleanup, docstrings, etc.

No new functionality here, just a lot of cleanup and (I think) addition of all missing docstrings. @qmac, you should probably glance at this, but there shouldn't be anything that requires serious review, as these are pretty much all minor fixes for issues caught by flake8.

Changes Unknown when pulling 578dee18ddc00ba7df605710b1e575cf88101cf4 on cleanup into ** on master**.

I tried running flake8 on the code base and still get a good number of things to clean up, a lot are from external/. But here's a small snippet of other ones:
./pliers/extractors/api.py:127:12: E714 test for object identity should be 'is not'
./pliers/extractors/audio.py:35:80: E501 line too long (107 > 79 characters)
./pliers/extractors/audio.py:73:9: F841 local variable 'events' is assigned to but never used
./pliers/extractors/audio.py:122:33: E127 continuation line over-indented for visual indent
./pliers/extractors/base.py:133:80: E501 line too long (85 > 79 characters)
./pliers/extractors/image.py:77:9: F841 local variable 'data' is assigned to but never used
./pliers/extractors/models.py:1:1: F401 'sys' imported but unused
./pliers/extractors/models.py:38:80: E501 line too long (102 > 79 characters)
./pliers/extractors/text.py:9:1: F401 'pliers.datasets.text.datasets' imported but unused
./pliers/extractors/text.py:13:1: F401 'collections.defaultdict' imported but unused
./pliers/extractors/video.py:46:17: F841 local variable 'total_flow' is assigned to but never used
./pliers/filters/text.py:18:37: W291 trailing whitespace
./pliers/filters/text.py:44:80: E501 line too long (80 > 79 characters)
./pliers/stimuli/audio.py:3:1: F401 'six' imported but unused
./pliers/stimuli/base.py:48:80: E501 line too long (84 > 79 characters)
./pliers/stimuli/base.py:158:1: E305 expected 2 blank lines after class or function definition, found 1
./pliers/stimuli/compound.py:4:1: F401 'abc.abstractmethod' imported but unused
./pliers/stimuli/compound.py:4:1: F401 'abc.ABCMeta' imported but unused
./pliers/stimuli/compound.py:4:1: F401 'abc.abstractproperty' imported but unused
./pliers/stimuli/compound.py:5:1: F401 'six.with_metaclass' imported but unused
./pliers/stimuli/compound.py:39:75: E225 missing whitespace around operator
./pliers/stimuli/compound.py:40:80: E501 line too long (89 > 79 characters)
./pliers/stimuli/compound.py:117:80: E501 line too long (82 > 79 characters)
./pliers/stimuli/image.py:25:80: E501 line too long (81 > 79 characters)
./pliers/stimuli/text.py:63:80: E501 line too long (80 > 79 characters)
./pliers/stimuli/video.py:5:1: F401 'pandas as pd' imported but unused
./pliers/stimuli/video.py:7:1: F401 '.audio.AudioStim' imported but unused
./pliers/support/download.py:11:1: E305 expected 2 blank lines after class or function definition, found 1
./pliers/tests/test_converters.py:4:30: E128 continuation line under-indented for visual indent
./pliers/tests/test_converters.py:5:30: E128 continuation line under-indented for visual indent
./pliers/tests/test_converters.py:6:30: E128 continuation line under-indented for visual indent
./pliers/tests/test_converters.py:7:30: E128 continuation line under-indented for visual indent
./pliers/tests/test_converters.py:9:1: F401 'pliers.stimuli.DerivedVideoStim' imported but unused
./pliers/tests/test_converters.py:11:1: F401 'pliers.config' imported but unused
./pliers/tests/test_converters.py:15:1: F401 'os' imported but unused
./pliers/tests/test_converters.py:16:1: F401 'time' imported but unused

Just made another pass. I think I got all the big stuff. We don't really care about line length (I mean, it's good to try to keep to <= 79, but in most of these cases I think it's more readable as-is), and I haven't touched the external/ stuff for the most part.

Changes Unknown when pulling f40e017f741d82e8ae46f14948e3429913f4b11b on cleanup into ** on master**.


Route with passport.authenticate results in bad request

I'm using passportjs with expressjs 4.12 and I'm having a bad request when trying to limit access to a route.
The following code gives a bad request
router.get('/users', passport.authenticate('local'), function(req, res) {
        res.json({ currentUser: req.user });
});

But this one works and gives me the logged in user.
router.get('/users', function(req, res) {
        res.json({ currentUser: req.user });
});

What could be wrong in the setup? The login system seems to work, the user is saved in the request session, the serialize/deserialize function from passport are called when executing the second code (without the access check).

The doc says:

In a typical web application, the credentials used to authenticate a user will only be transmitted during the login request. If authentication succeeds, a session will be established and maintained via a cookie set in the user's browser.

I can see in the request that the cookie is sent.
Could be something with the Local strategy? The code there seems to only check the username/password from the request. But the request is always empty.

The passport-local example helped me find my error: https://github.com/jaredhanson/passport/blob/master/test/strategies/session.test.js
I has to use req.isAuthenticated() to check if the user was auth. Not make a call to passport.authenticate('local').

I'm running into the same problem. The passport-local documentation specifically states that you should use passport.authenticate('local'), but I'm just getting Bad Request. Any tips?

app.post('/login', (req, res) => passport.authenticate('local', {   successRedirect: '/',   failureRedirect: '/login', })(req, res));

It'd be helpful if this caveat was documented on passportjs.org. Would've saved a few hours of stress :)

Most of the problem i get was because the lib never mention body-parser as a dependency.

For me the trick with process.nextTick worked

I'm still facing the same error of Bad Request.
@hudsonpereira I'm not sure but i don't think body-parser is a dependency for passportjs. Added body-parser to test it out but still no progress.

I also needed body-parser with app.post. Post arguments are sent via the body, ie. req.body.
var bodyParser = require('body-parser');
app.use(bodyParser.json()); // support json encoded bodies
app.use(bodyParser.urlencoded({ extended: true })); // support encoded bodies

https://github.com/jaredhanson/passport/issues/679
similar problem
can you help?

Hi facing bad request error while registering a new user like below
user.register(newuser,req.body.pass,function(err,user){
    if(err)

    {
        console.log(err);
        return res.render('register');
    }
    //console.log("inside post register");
    passport.authenticate("local")(req,res,function(){
        //console.log("inside passport authenticate");
        res.render('/campground');
    });

pls help...

passport expects that in the form the names of username and password are those like that username and password, you are using pass for password, change the name in the html attributes.

I am just going to leave this blog post here for anyone who is getting random errors and is unable to figure out how to debug : https://dmitryrogozhny.com/blog/easy-way-to-debug-passport-authentication-in-express
I wasted hours before I could try and figure out what that "Bad Request" corresponds to. It was 'Missing credentials' in my case which was because the body parser was not configured properly.
Adding the line app.use(express.json()) to my middleware fixed the problem for me, but this blog post hopefully will help others who are stuck in the crappy undescriptive message of 11 characters i.e "Bad Request" which really doesn't tell anything.
Just replace your passport.authenticate('local') with the following:
function (req, res, next) {
    // call passport authentication passing the "local" strategy name and a callback function
    passport.authenticate('local', function (error, user, info) {
      // this will execute in any case, even if a passport strategy will find an error
      // log everything to console
      console.log(error);
      console.log(user);
      console.log(info);

      if (error) {
        res.status(401).send(error);
      } else if (!user) {
        res.status(401).send(info);
      } else {
        next();
      }

      res.status(401).send(info);
    })(req, res);
  },

There seriously needs to be a better error message for a library such widely used.

passport.authenticate("local") fetches username and password from the view engine.Try naming them username and password in the login form.

I am having the same bad request issue. Can someone help me by sending the appropriate code? It will be very helpful. It's been two days now, and I couldn't solve the problem yet. Some help will be very useful.

@Deepanshu088

You can follow the steps that I mentioned above, this helped me determine and fix my problem : https://github.com/jaredhanson/passport/issues/371#issuecomment-513893423

There is an undocumented failWithError option that you can use that might help determine the problem : https://github.com/jaredhanson/passport/issues/458#issue-131801590

Few things to check:

Is your username and password variable the same as the one specifieid in usernameField and passwordField? What are your username and password variable.

Can you check if your body parser is configured properly? That was the problem in my case. Use express's own body parser instead of bodyParser() constructor if that's what you are doing.

https://stackoverflow.com/questions/47232187/express-json-vs-bodyparser-json
const express = require('express');
app.use(express.json());

Hope this helps. Can you be more elaborate with your problem? Maybe share some code as well?

I faced a similar issue. In my case, it was a wrong post body.

I was using form-data which results in a bad request. When i switched to x-www-form-urlencoded it works fine.

Most of the problem i get was because the lib never mention body-parser as a dependency.

this 4 year old reply just ended my 2 hrs of debugging lol. been debugging til i see this and used bodyparser and boom it works! thanks!

I figured it out.
Instead of using passport.authenticate(),  use User.authenticate() @Jyosiva

passport expects that in the form the names of username and password are those like that username and password, you are using pass for password, change the name in the html attributes.

thank you for this advice.... with advice i have solved my problem..

passport expects that in the form the names of username and password are those like that username and password, you are using pass for password, change the name in the html attributes.

thank you for this advice.... with advice i have solved my problem..

you have to named your login form input as username and password same as i write because passport authenticate look form the same data via your view engine. so if you named it as Userpassword Userusername or any other name then change it to username and password.

you have to named your login form input as username and password same as i write because passport authenticate look form the same data via your view engine. so if you named it as Userpassword Userusername or any other name then change it to username and password.

I find that the documentation for passport is generally lackluster and not thoroughly detailed, which leads to confusion for new comers (me). It would be more helpful if the documentation was written in a style similar to Sequelize, where all api methods are described in great detail. I know it's open source software and a lot is community maintained and I am asking a lot as an outsider, but this is just my opinion and would like to see this great piece of software be improved.
Anyways, the comments here helped me solve my issue.

app.post('/login', (req, res) => passport.authenticate('local', { successRedirect: '/', failureRedirect: '/login', })(req, res));

Thats for login, not protected routes

passport expects that in the form the names of username and password are those like that username and password, you are using pass for password, change the name in the html attributes.

Thank you! changing the name of the email input from 'email' to 'username' solved my problem, the annoying part is that it's not the first time when I make this mistake

People who have posted the answer as change the input name to username and password are saviours.

The passport-local example helped me find my error: https://github.com/jaredhanson/passport/blob/master/test/strategies/session.test.js
I had to use req.isAuthenticated() to check if the user was auth. Not make a call to passport.authenticate('local').

passport.authenticate('local') if you name email/username form fields => name="username" in the schema too.

@jaredhanson would you mind making passport local log out the errors. It silently fails with a "bad request" and nothing in the logs to point out issues.
The issue is that even when trying to add logging in the strategy itself, it fails before getting there:
passport.use(new LocalStrategy(   function(username, password, cb) {     console.log('in strategy b4 db');  //never got here
It's very tough to troubleshoot because with logins you are never sure if it's a cross site rejection, setup issue, route issue etc.
I think the community would very much appreciate logging errors

Let's summarise it guys.
First, make sure if you're using any json parser in you express middleware. Body-parser looks depricated, so hust make sure you have this line in your code: app.use(express.json()).
Second, sometimes people get 400 from passport.authenticate because of credentials. So make sure your axios requests from frontend to backend has this {withCredentials: true} as a parameter.
And finally, make sure to use "username" and "password" spelled exactly like this in your userSchema, in your frontend input names, and in your strategy options.  I used passport-local-mongoose, and looks like there's no need to configure local strategy, cause it use "username" and "password" by default.
Try any of this, 99% you'll be able to authenticate user and finally move on. Later, you'll find a way to specify "username" and "password" to be different, but for now I'm sure, your primary mission is to unstack)

you have to named your login form input as username and password same as i write because passport authenticate look form the same data via your view engine. so if you named it as Userpassword Userusername or any other name then change it to username and password.

Thank you! it works

var path= require('path');
var express=require("express");
var request=require("request");
const https=require("https");
const session=require("express-session");
const passport=require("passport");
const passportLocal=require("passport-local");
const passportLocalMongoose=require("passport-local-mongoose");
var app=express();
const bodyParser=require("body-parser");
const mongoose=require("mongoose");
const { Http2ServerRequest } = require('http2');
const multer=require("multer");
const { func } = require('assert-plus');
const { userInfo } = require('os');
const { ecNormalize } = require('sshpk');
app.set('view engine', 'ejs');
app.use(bodyParser.urlencoded({extended: true}));
app.use(bodyParser.json());
app.use(express.json()) ;
// const { stringify } = require('querystring');
app.use(express.static("public"));
app.use(session({
secret:"Our little secret.",
resave:false,
saveUninitialized:false
}));
app.use(passport.initialize());
app.use(passport.session());
mongoose.connect("mongodb://localhost:27017/newhomesDB" ,{
useNewUrlParser:true,
// useFindAndModify: false,
useNewUrlParser: true,
useUnifiedTopology: true
},err=>{
if(err) throw err;
console.log('Connected to MongoDB!!!')
});
const registerSchema=new mongoose.Schema({
firstname:String,
lastname:String,
mobileno:String,
email:String,
password:String,

// Password:Password

});
const propertySchema=new mongoose.Schema({
submitprice:String,
submitarea:String,
submitbedroom:String,
submitbathroom:String,
submitmessage:String,
submitcity:String,
landmark:String,
submittransaction:String,
submitpropertytype:String,
// PropertyLocality:String,
Image:{
data:Buffer,
contentType:String
},
})
registerSchema.plugin(passportLocalMongoose);
const Property=mongoose.model("Property", propertySchema);
const Detail=new mongoose.model("Detail",registerSchema);
passport.use(Detail.createStrategy());
passport.serializeUser(function(user, done) {
done(null, user);
});
passport.deserializeUser(function(user, done) {
done(null, user);
});
app.get ('/', function(req,res){
res.render("index");
})
app.get('/my-profile.html',function(req,res){
if(req.isAuthenticated()){
res.sendFile(__dirname+"/my-profile.html");
}else{
res.redirect("/login");
}
});
app.post('/',function(req,res){
})
app.get('/register',function(req,res){
res.render("register");
})
app.get('/login',function(req,res){
res.render("login");
})
app.post('/register',function(req,res){
const newUser=new Detail({
    firstname:req.body.firstname,
    lastname:req.body.lastname,
    email:req.body.email,
    mobileno:req.body.mobile,
    password:req.body.password

})
if(req.body.password==req.body.repeatpassword){
    Detail.register({username:req.body.email},req.body.password,function(err,detail){
        if(err){
            console.log(err);
            res.redirect("/register");
        }
        else{
            console.log("done");
            passport.authenticate('local')(req,res, function(){

                res.sendFile(__dirname+"/my-profile.html")
            })
        }
    })
 }

// res.sendFile(__dirname+"/my-profile.html");

})
app.post('/login',function(req,res){
const user=new Detail({
username:req.body.loginemail,
password:req.body.password
})
req.login(user, function(err){
if (err) {
console.log(err);
} else {
passport.authenticate("local")(req, res, function(){
res.redirect("/my-profile.html");
});
}
});
});
app.get('/submit-property.html',function(req,res){
res.sendFile(__dirname+"/submit-property.html");
});
app.post('/submit-property.html',function(req,res){
const register=new Property({
    submitprice:req.body.submitprice,
    submitarea:req.body.submitarea,
    submitbedroom:req.body.submitbedroom,
    submitbathroom:req.body.submitbathroom,
    submitmessage:req.body.submitmessage,
    submitcity:req.body.submitcity,
    landmark:req.body.landmark,
    submittransaction:req.body.submittransaction,
    submitpropertytype:req.body.propertytype,

    Image:{
        data:req.body.files,
    }

});
register.save();

})
app.post('/my-profile.html',function(req,res){
if(req.isAuthenticated()){
res.render("/my-profile.html");
}else{
res.redirect("/login");
}
});
app.get('/estate-details-right-sidebar.html',function(req,res){
res.sendFile(__dirname+"/estate-details-right-sidebar.html");
})
app.listen (3000,function(){
console.log("server started on port 3000");
})

its showing bad request

passport expects that in the form the names of username and password are those like that username and password, you are using pass for password, change the name in the html attributes.

Thank You so much man. You can't believe I was stucked for about 4 hours in this. I can't express my word to thank you.


Branch switching conflicts over multiple files

Branch switching happens over multiple files which leads to confusing and potentially damaging states.
To Reproduce
Steps to reproduce the behavior:

Open Token Studio in one file (File A) and switch to a new branch (Branch A) - do some changes so you get the "Recover local changes" on plugin startup (cancel and close the plugin again)
Open Token Studio in another file (File B) and create or switch to a completely new branch (Branch B)
Go back to file A and open Token Studio
File A is now also on Branch B and asks if you want to recover the local changes
-> Local changes from Branch A can now be applied to Branch B

Expected behavior
I would expect that the Token Studio Plugin on File A is still on Branch A, as that was the branch I was working on and left my local changes. When I switch the branch in File B, it will have the Branch B selected, but doesn't influence the Token Studio of File A. The local changes recovery are file dependent, so why are the selected branches not?
The plugin stops you from switching branches when there are still local changes which are not pushed - but with this process you are able to work around this. This leads to a state where I am not sure whether the branch is still correct or if I messed something up.
Screenshots:
File A with the dialog that tells me I cant switch the branch (to "main" branch) because of unpushed changes (cancel this):

File B where I switched to the "main" branch and pulled the tokens:

Close and reopen Token Studio in File A again - Message with local changes pops up (confirm):

File A now also on the "main" branch with the recovered local changes applied:

Small mistake on the Screenshot 3 (Recover Local changes).
Text should be "Close and reopen Token Studio in File A again - Message with local changes pops up (confirm):"

Thanks for the detailed report 🙏 agree that each file should keep its branch.

Added to FeatureBase Roadmap- ❖ ❇ Non-local support of variables and styles


hidden nodes are not clickable if i am using require('./view-electron.js') in view-electron.html

When i use  instead of  in view-electron.html then mid layer nodes in graph are not clickable.

Thank you so much for quick fix.


refactor: use absl::optional

This PR changes google::cloud::optional<T> to be an alias template for
absl::optional<T>. This is an ABI change, but should be API
compatible.
I also moved the internal::OptionalRow alias into the private section
of the one class where it's used. The TODO referenced by this old alias
had already been closed
(https://github.com/googleapis/google-cloud-cpp/issues/277).

This change is

Drive by: shouldn't we be able to remove optional_test.cc too?

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Yep. I originally left it to ensure absl::optional worked the same way we thought/tested our previous optional class. The tests passed. Then I forgot to remove it. Thanks for reminding me.


locale is not completely switched??

VSCode Version: 1.12.2
OS Version:WIndows 10

Steps to Reproduce:
0. System locale is russian

start vscode with -locale=en
look at hotkeys in menus

Please advise @dbaeumer @michaelchiche

The short cuts don't come from the translations. To my knowledge the are computed by the keyboard shortcut server. @amigo421 which keyboard layout are you using?
@alexandrudima assigning to you.

There is english (US) and russian keyboard layouts installed in my system,
however I can't reproduce the problem now! :)
so please close the issue, I'll reopen if I'll can to find the steps

Duplicate of #24361


onSelect is getting called multiple times when i use the same component in multiple pages

Describe the bug
When the same component is used on multiple pages onSelect is called multiple times
To Reproduce
home.tsx
<Container width={width} height={height}>
      <Page>
        <DefaultFocus>
          <SpatialNavigationScrollView offsetFromStart={140}>
            <Box padding="$10">
              <HeroWrapper data={data} />
              <Spacer gap="$20" />
              <SwiperListWrapper data={data} title="Latest in *" />
              <Spacer gap="$20" />
            </Box>
          </SpatialNavigationScrollView>
        </DefaultFocus>
      </Page>
      <Menu />
    </Container>

singleOttPage.tsx
<Container width={width} height={height}>
      <Page>
        <SpatialNavigationScrollView offsetFromStart={140}>
          <Box padding="$10">
            <View>
              <Hero
                key={mainVideo.title}
                fullData={mainVideo.fullData}
                image={mainVideo.image}
                width={avilableWidth}
                height={aspectRatioHeight}
                title={mainVideo.title}
                descArray={mainVideo.descArray}
                rating={mainVideo.rating}
                desc={mainVideo.fullData?.standaloneTitleDetails?.logLine}
                onSelect={(onSelect) => {}}
                buttons={buttons}
              />
            </View>
            <Spacer gap="$10" />
           </Box>
        </SpatialNavigationScrollView>
      </Page>
      <Menu />
    </Container>

The menu component is same as the one in example folder.
I have 2 pages. Home page and single video page. when click on the menu item I'm pushing the route, navigation.push(route)
First-time menu click works as expected but after navigation, onSelect is called multiple times and I also get the warning
[React Spatial Navigation] No registered node on this page.
Same behaviour is happening on hero card and swiper card too.
Expectedbehaviourr
onSelect should be called only once

Hey!
Are you using react-navigation?
Are you sure you are disabling the SpatialNavigator on the pages that don't have the focus ? 😄
Because they still live in the background and still listen for keyboard events.
References in the example :

https://github.com/bamlab/react-tv-space-navigation/blob/a5fd1e0cac04e0808ab79e1ea95ccf91106913e5/packages/example/src/components/Page.tsx#L38
https://github.com/bamlab/react-tv-space-navigation/blob/a5fd1e0cac04e0808ab79e1ea95ccf91106913e5/packages/example/src/components/Page.tsx#L51

It is present in Page.tsx. however, in the example menu was rendered only once in APP.tsx. I have moved it to each page
I will add it there too.

Yes the menu is rendered once for everywhere to be able to keep its state. It has caused us animation issues to have one menu rendered per page. But it's a valid choice to have one menu per page 👍
I don't understand your problem though 🤔
Having multiple onSelect really means that you have multiple active instances of the spatial navigator. There's no other way to have multiple onSelect triggered at once.
Can you make sure that you have only ONE spatial navigator active at the same time?


Automatically mark the first attribute of its type as primary

Created by: @andskaal May 31 2021 at 13:48 CET
Last updated: Jul 05 2021 at 16:24 CET
ClickUp ID: IK-927
Assigned in ClickUp to: Bohumil Pospíšil
Currently this cypher is used to create properties: https://github.com/indykite/jarvis-proto/blob/develop/pkg/cypher/properties.go#L267
And if it should be marked as primary, then executing this one https://github.com/indykite/jarvis-proto/blob/develop/pkg/cypher/properties.go#L321 which is taken from here
Following modification is required:
If the attribute is the first one of its type (like first email, surname, phone, etc) it should be marked as primary automatically.
There are those possibilities:
Modify the Create Cypher to make relationship with Primary: true automatically. - Must also return some flag, to skip executing second cypher if user requesting Primary to true.
Modify the Create Cypher to only return that relationship should be marked Primary to execute the second cypher even user did not request Primary property.
Code Documentation
// CreateDigitalTwinPropertyCypher adds a single property.
// Input:
// 	* singular
//  * unique
//	* digital_twin_id
//  * property
// Return:
//	{
//    digital_twin_id,
//    property_id,
//    must_set_primary - flag indicating if 2nd cypher should be ran
//  }
Sample parameters:
// Adding givenname to grandpa.joe - initially grandpa.joe has no givenname
:params {digital_twin_id: 'aW5keWtpRGWAAAkPAAmQAA', singular:false, unique:false, property:{id:8395799673973146, value:'givenname', type:'givenname'}}
// Adding 2nd givenname to grandpa joe
:params {digital_twin_id: 'aW5keWtpRGWAAAkPAAmQAA', singular:false, unique:false, property:{id:8395799673973147, value:'givenname', type:'givenname'}}
Cypher
WITH
CASE WHEN  $ singular THEN ':Singular' ELSE '' END AS singular_label,
CASE WHEN  $ unique THEN ':Unique' ELSE '' END AS unique_label
WITH singular_label+unique_label+':Property' AS label
OPTIONAL MATCH (dt:DigitalTwin {id: $ digital_twin_id})
CALL apoc.when( $ singular,
'RETURN apoc.map.merge(property,{dt_id:dt_id}) AS property',
'RETURN property',
{property: $ property, dt_id:id(dt)}
) YIELD value
WITH label,dt,value.property AS property
OPTIONAL MATCH (dt)-[r:HAS]->(p:Property {id:property.id})
OPTIONAL MATCH (dt)-[rp:HAS|SHARING_FROM]->(pp:Property) WHERE property.type = pp.type AND property.id <> pp.id
WITH label,dt,property,p,count(rp)=0 AS must_set_primary
CALL apoc.do.case([
dt IS NOT NULL AND p IS NOT NULL,
'RETURN NULL AS property_id, dt.id AS digital_twin_id',
dt IS NOT NULL AND p IS NULL,
'CREATE (p'+label+') SET p=property CREATE (dt)-[r:HAS]->(p) RETURN p.id AS property_id, dt.id AS digital_twin_id'],
'RETURN NULL AS property_id, NULL AS digital_twin_id',
{dt:dt,property:property}
) YIELD value
RETURN {
digital_twin_id: value.digital_twin_id,
property_id: value.property_id,
must_set_primary: must_set_primary
}

Commented by: @Bohumil Pospíšil Jun 11 2021 at 10:01 CET
@andskaal, @yetizer please can I find somewhere sample parameters for the first cypher that is used to create properties?

Commented by: @yetizer Jun 14 2021 at 10:12 CET
@andskaal in the 1st option: "Modify the Create Cypher to make relationship with  Primary: true  automatically. - Must also return some flag, to skip executing second cypher if user requesting Primary to true." what does the 2nd cypher do in this case, i.e. why do we need to return any flag?


Task fails if use overwrite option while downloading a build.

@michel-kraemer I am trying to download some artifact from artifactory server.
task downloadTask(type: Download) {
def userHome = System.getProperty("user.home")

src "${SRC_URL}"
dest new File("${userHome}/native-libs", "Some.zip")
overwrite false

}
When I am using overwrite is false, my understanding is it will detect if the file is present in the path or not if the file is not present it will go-ahead for the download if it is present then it will ignore re-download. But when I use this option then if the file is not present it Task fails straight away it doesn't go ahead to download that file.
Is it a bug or is there any flaw in my understanding?

Your understanding is correct. What error message do you get?

I checked that it works correctly if I remove the .gradle file from my project. Looks like gradles caches the setting but does not get updated if I delete the file.

Sorry for my late response. So, did this solve your problem? It doesn't seem to be a bug in gradle-download-task, or is it?


Add A New Baseline: TCN

Please use black to format your code
https://github.com/microsoft/qlib/blob/main/docs/developer/code_standard.rst#continuous-integration

@f-cg Could you please add a README for TCN?
Thanks


Fix documentation code formatting

Code blocks should always follow an empty line; otherwise, jekyll will
fail to properly format the code block. Also, github's code fencing (with triple backticks) does not work in the middle of item lists.

@regisb Looks good overall without minor. Left comment.

+1

Thanks @regisb, merged into master and 1.x-branch.
I've had other works to do, so website update will be done later.

Great, thanks for the quick review and merge!


Refactor FEMAIN.C

[PC] Fix flickering bugs

[PC] Move button drawing logic to DrawScreen

[PC] Better game names lookup system (names verified to be correct)

Fixed bugs in high score table

Other misc changes/fixes

I hope nothing were broken


fix: Selenium Grid in case multiple scaler triggers are activate

Implement strictly the condition to trigger the scaler in complex cases that Selenium Grid includes autoscaling Nodes (with multiple scaledObject with different triggers metadata), non-autoscaling Nodes, relay Nodes, and so on.
In general, update the scaler logic should be aligned with Selenium Grid core in DefaultSlotMatcher - which can be inspected https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/grid/data/DefaultSlotMatcher.java
It is also recommended to set the browserName, browserVersion, and platformName to align across request capabilities, Node stereotype and scaler trigger params to have  correct scaling behavior.
In terms of SlotMatcher in Grid, there is no value latest for the capability browserVersion. So, remove that value latest and keep the default value EMPTY.
For example, client sends the request (in Python binding)
options = ChromeOptions()
options.set_capability('platformName', 'Linux')
driver = webdriver.Remote(options=options, command_executor=SELENIUM_GRID_URL)

It is equivalent to scaler trigger params.
  triggers:
    - type: selenium-grid
      metadata:
        url: 'http://selenium-hub:4444/graphql'
        browserName: 'chrome'
        platformName: 'linux'

For example, client sends the request
options = ChromeOptions()
options.set_capability('platformName', 'Linux')
options.set_capability('browserVersion', '131.0')
driver = webdriver.Remote(options=options, command_executor=SELENIUM_GRID_URL)

The scaler trigger param should be aligned as
  triggers:
    - type: selenium-grid
      metadata:
        url: 'http://selenium-hub:4444/graphql'
        browserName: 'chrome'
        platformName: 'linux'
        browserVersion: '131.0'

Most people are using the popular browser node image from the project docker-selenium. In default Node stereotype, the short browser version is set for browserVersion, it might cause breaking backward compatiblity, or request without browserVersion could not trigger scaler anymore. Via https://github.com/SeleniumHQ/docker-selenium/pull/2520, you can set SE_NODE_BROWSER_VERSION as empty to unset the default version (take newer docker image tag from that project, which contains the change onwards).
This also avoids multiple scalers, for example same browserName combines multiple browserVersion could have issue with overlapping in counting number of ongoing and pending sessions belonging to each scaler trigger.
In terms of Selenium Grid v4, it has a kind of Relay Node, which has capabilities to forward commands to the Appium instance. With this Node type, the browserName is optional. So, updating the trigger param browserName to optional.
Checklist

[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

/run-e2e selenium

/run-e2e selenium

Can you try e2e run one more time, I guess pull image could take time or reach pull limit rate...Here is result in my local
EXECUTION SUMMARY
##############################################
##############################################
Passed tests:
        Execution of tests/scalers/selenium/selenium_test.go, has passed after "one" attempts

It looks like issue reaching the hub ->
scale_handler	error getting scale decision	***"scaledObject.Namespace": "selenium-test-ns", "scaledObject.Name": "chrome-selenium-test-so", "scaler": "seleniumGridScaler", "error": "error requesting selenium grid endpoint: Post \"[http://selenium-hub.selenium-test-ns:4444/graphql\](http://selenium-hub.selenium-test-ns:4444/graphql/)": dial tcp ***0.0.***5***.***4***:4444: connect: connection refused"***
github.com/***/keda/v***/pkg/scaling.(*scaleHandler).getScalerState
	/workspace/pkg/scaling/scale_handler.go:780
github.com/***/keda/v***/pkg/scaling.(*scaleHandler).getScaledObjectState.func***

I'm checking another issue in my local, once I finish I'll try to check this too

@JorTurFer, I also done other tests in downstream repos. Let's rerun the e2e job here to see any luck :)

/run-e2e selenium

Now I don't see connection issues trying to reach the hub, but it doesn't pull the values from the hub. I see 6 items in the queue:

But KEDA doesn't scale out the workload and no error is shown either

Thanks for your info, I am checking it in local again now

The cluster can be accessed, right? how about when kubectl get deployment, can it list 3 deploy resources, since I updated it to use image selenium/node-chrome:nightly (similar for firefox, edge). Not sure the deployment can be created?

The cluster can be accessed, right? how about when kubectl get deployment, can it list 3 deploy resources, since I updated it to use image selenium/node-chrome:nightly (similar for firefox, edge). Not sure the deployment can be created?

let me check

Currently, I can see 6 items in the queue:

And I have tried to scale out manually the workloads to 1, and KEDA has scaled in to 0, so the current value calculated is 0. The deployments are correct

I've added a print, and this is the content of the Hub response's body (the missing 2 are most probably because when I started the pod manually, they were processed)
{
  "data": {
    "grid": {
      "sessionCount": 0,
      "maxSession": 0,
      "totalSlots": 0
    },
    "nodesInfo": {
      "nodes": [
      ]
    },
    "sessionsInfo": {
      "sessionQueueRequests": [
        "{\n  \"acceptInsecureCerts\": true,\n  \"browserName\": \"firefox\",\n  \"moz:firefoxOptions\": {\n    \"args\": [\n      \"-remote-debugging-port\",\n      \"40627\"\n    ]\n  }\n}",
        "{\n  \"acceptInsecureCerts\": true,\n  \"browserName\": \"chrome\"\n}",
        "{\n  \"acceptInsecureCerts\": true,\n  \"browserName\": \"firefox\",\n  \"moz:firefoxOptions\": {\n    \"args\": [\n      \"-remote-debugging-port\",\n      \"40947\"\n    ]\n  }\n}",
        "{\n  \"acceptInsecureCerts\": true,\n  \"browserName\": \"chrome\"\n}"
      ]
    }
  }
}

Now I'm debugging this function:
// This function checks if the request capabilities match the scaler metadata
func checkRequestCapabilitiesMatch(request Capability, browserName string, browserVersion string, _ string, platformName string) bool {
	// Check if browserName matches
	browserNameMatch := request.BrowserName == "" && browserName == "" ||
		strings.EqualFold(browserName, request.BrowserName)

	// Check if browserVersion matches
	browserVersionMatch := (request.BrowserVersion == "" && browserVersion == "") ||
		(request.BrowserVersion == "stable" && browserVersion == "") ||
		(strings.HasPrefix(browserVersion, request.BrowserVersion) && request.BrowserVersion != "" && browserVersion != "")

	// Check if platformName matches
	platformNameMatch := request.PlatformName == "" && platformName == "" ||
		strings.EqualFold(platformName, request.PlatformName)

	return browserNameMatch && browserVersionMatch && platformNameMatch
}

And the platformName doesn't match
	// Check if platformName matches
	platformNameMatch := request.PlatformName == "" && platformName == "" ||
		strings.EqualFold(platformName, request.PlatformName)

So the result of the function is false. The current value for request.PlatformName is "". As I understand, it means that the isn't any platform requirement, so the logic should be something like
	// Check if platformName matches
	platformNameMatch := request.PlatformName == "" ||
		strings.EqualFold(platformName, request.PlatformName)

WDYT?

Yes, that is reason I also updated in deployment container env
        env:
        - name: SE_NODE_BROWSER_VERSION
          value: ''
        - name: SE_NODE_PLATFORM_NAME
          value: ''

To override the Node stereotypes be aligned with scaler metadata

Does it make sense to update the logic to not check the platform/browser/version if the request doesn't specify it? I mean, from my naive pov, if the request doesn't define those values it's because any node can handle that request.

I changed imagePullPolicy: Always, I guess it might used the cache images without changes yet

/run-e2e selenium

I changed imagePullPolicy: Always, I guess it might used the cache images without changes yet

I'm checking it locally right now

The problem that I see is that the nodes aren't starting, so any change applied in nodes isn't taken into account, at least until the node starts. As all the nodes are deployed scaled to 0, any configuration in the node won't be reflected in the hub

yeah, locally it still not working, 6 items and no nodes

Without set platfromName as EMPTY in Node config, it looks like it assumes as Windows by default in Grid...then the scaler scale it down to 0, due to mismatch with metadata

Give me some time, I will fix the test need to enforce platformName is Linux same as Node stereotype and scaler metadata

I've written you by Slack, maybe it'll be faster :)

/run-e2e selenium


cooking clay is sloooow!

You need 9 clay bricks to make 1 brick block; it means that you need to cook 9 clay. The current cooking we have seems not to be the fastest. I've had ~400 brick blocks done with 6 furnace in one hour, which means that having enough clay bricks is very slow...
Maybe someone can investigate and accelerate it, for a better gameplay :)

thank you for this issue, you're right we need to reduce the "burning_time" of the clay !
So, i suggest to divided the burning_time per 4 (60min => 15min)

There is no such value as a burntime for an input item, we can't reduce it. Only fuels have those values. What fuel were you using?

the burntime for clay(and other minerals)is taken from the burned fuel ?!

No, we must add "cooktime = *"

https://github.com/Ombridride/minetest-minetestforfun-server/commit/5efa99ee3060e90ac355517f20b4064f049502e6

The cooktime is now set to 2 seconds
We also find a mistake on the clay "max_stack" value, we re-set it to 200 (99->200)
Thank you for your issue !


Random Profile Picture

Would be nice if the Person in addition to the birthDate also has a way to obtain a profile picture ideally also with male/female/neutral just like we can do when generating names.

Hi @vanniktech ,
Thanks for the suggestion, sounds like a valid use-case, but would like some more details.

Do you want to return a  file, a link to a file, or something else?
Are you thinking of an array of pics for each type, or just one picture per type?

If we want an array of pictures, do you have any suggestions on where to source the data from? This likely needs to be some open third-party source with fake profile pics or something similar.

With consideration of https://github.com/serpro69/kotlin-faker/issues/226 the best might to just to get a ByteArray of an image with 32bit RGBA values?
Ideally, different pictures. Regarding the source, I don't have one in mind.

With consideration of #226 the best might to just to get a ByteArray of an image with 32bit RGBA values?

Good point.
I also don't know where one would be able to get pics that can be used for this, considering all sorts of things like privacy etc on top of it.
But I'll try to research a bit.
Feel free to update with more details if you come up with something.

https://uifaces.co/ this is as close as I've gotten when I took some time today to find some pictures.

Good find, @vanniktech , thanks!
I've downloaded all the avatars and pushed them to a separate repo for now - https://github.com/serpro69/uifaces-ai-avatars
I'm not sure yet if I want to fetch and read avatars from remote location, or include as part of the jar. With the latter, I'd probably use a separate module, so that the size of the core module jar isn't needlessly increased.
Would you like to submit a PR for this? Otherwise I can take a look at implementing it myself.

Would you like to submit a PR for this? Otherwise I can take a look at implementing it myself.

I'm currently traveling so I have limited time. Doing it in a separate module sounds perfect!

Did some very simple implementation in #254 . Feel free to take a look and provide some feedback, if you like ;)

Should be available in the latest 2.1.0-SNAPSHOT version once the build is complete.


canged the references to kvm and kre to align with the latest renaming changes

Not sure how much of this is actually correct but it seemed better than wrong info :smile:

kvm > dnvm
kre > dnx
ASP.NET vNext > ASP.NET 5
K Version Manager > .NET Version Manager
K Runtime Environment (KRE) > .NET Execution Environment (DNX)

NOTE: left the Homebrew stuff as is because I don't know if it is changed.

Hi @tugberkugurlu, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

Closing in favor of https://github.com/aspnet/Home/pull/375.


[BUG] Width calculation for percentage widths incorrect

Describe the bug
When using a responsive grid with grid items that have their widths defined in percentage, filterizr does not correctly calculate the width in pixels of each grid item.
Filterizr version
2.2.4 - Vanilla JS version
To Reproduce
I've created a codepen that illustrates the issue.

I've setup a basic grid with 25% width items
Then added a wrapper on the whole grid with a width (622px)  that is not divisible by 4 without having decimals.
Normally the calculated width of each grid item in pixels should be 155.5px, but filterizr makes it 156px. I'm guessing it might be a rounding issue?
Result is that instead of displaying 4 items on one row, there are only 3.

Desktop (please complete the following information):

OS: OSX 10.14
Browser: Chrome
Version: 85

Additional context
I think it might be related to #33, although the issue is marked as fixed already in 2.2.0

I have this issue too and it's affecting my design a lot. Has anyone found a fix for it?

I have the same issue with Bootstrap columns. Setting a small negative value for gutterPixels (for example -1) seems to work around the bad calculation.

I have the same issue with Bootstrap columns. Initializing filterizr with a small negative value for gutterPixels (e.g. -1) seems to work around the bad calculation.

This fixed the problem. Thank you so much for the fix. 😍


Add http- prefix to port names in collector and agent services

Signed-off-by: Karol Szwaj<EMAIL_ADDRESS>
Which problem is this PR solving?

https://github.com/jaegertracing/helm-charts/issues/344#issuecomment-1100166786 (partially)

Short description of the changes
Adding a prefix to service port names, resolves issues with istioctl
Info [IST0118] (Service tracing-jaeger-agent.kyma-system) Port name config-rest (port: 5778, targetPort: 5778) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector-headless.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.

Potentially possible problems similar to this old issue.

hi @cnvergence, could you tell me how you produced those lines using istioctl?
Info [IST0118] (Service tracing-jaeger-agent.kyma-system) Port name config-rest (port: 5778, targetPort: 5778) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector-headless.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.

hey @frzifus, yes, it is istioctl analyze :)


Nodes OOM after ~4h of soundness test

Long running soundness test caused the nodes to OOM, producing 1.4Gb of debug logs each. Tested on commit 78c58599596271e267890a23fb8ff5a91866a34a with the test modified to:

not end after 0.5h (as it does normally)
allow nodes 6 minutes to sync (instead of 2, as normal)

No output from the console available, since system got unresponsive and I had to force-reboot.
Logs attached (luckily, they compress quite well).
https://files.slack.com/files-pri/TDVFB45LG-F05AYJN7CDU/download/logs_-_oom.zip?origin_team=TDVFB45LG

@RitaMAllenCA
I think we can close this one - the OOM fix is merged.
Also, the huge log issue caused by logging full execution results has been improved.
cc: @Fraser999


tauri: Stopping Whisper is taking lot of time

Using the latest release v0.1.5 I run Whisper and then from within the detail page, I try to stop it. The spinner hangs
If I reload it shows as Running state, but if I enter playground and upload an audio it gives me error as not reachable. the process seems to be correctly stopped, just is never communicated to the UI somehow?

Running in cargo tauri dev I have these logs
src/download.rs:78 2023-11-02T23:46:07 [WARN] - File already downloaded: /Users/tiero/Library/Application Support/io.premai.prem-app/models/whisper-tiny-cpp/ggml-tiny.bin
src/download.rs:78 2023-11-02T23:46:09 [WARN] - File already downloaded: /Users/tiero/Library/Application Support/io.premai.prem-app/models/whisper-tiny-cpp/whisperd-aarch64-apple-darwin
src/controller_binaries.rs:101 2023-11-02T23:48:19 [INFO] - serve_command: whisperd-aarch64-apple-darwin serve  --model-path=ggml-tiny.bin --port=9446
src/controller_binaries.rs:106 2023-11-02T23:48:19 [INFO] - binary_path: "/Users/tiero/Library/Application Support/io.premai.prem-app/models/whisper-tiny-cpp/whisperd-aarch64-apple-darwin"
src/controller_binaries.rs:126 2023-11-02T23:48:19 [INFO] - args: ["serve", "--model-path=ggml-tiny.bin", "--port=9446"]
src/controller_binaries.rs:163 2023-11-02T23:48:19 [ERROR] - Failed to send request: error sending request for url (http://localhost:9446/v1): error trying to connect: tcp connect error: Connection refused (os error 61)
src/controller_binaries.rs:156 2023-11-02T23:48:19 [INFO] - Service started: whisper-tiny-cpp
2023-11-02 23:48:21.287 Prem[19524:112254] +[CATransaction synchronize] called within transaction
src/controller_binaries.rs:182 2023-11-02T23:48:43 [INFO] - stopping service service_id = whisper-tiny-cpp
src/controller_binaries.rs:191 2023-11-02T23:48:43 [INFO] - service pid = 20659
src/controller_binaries.rs:198 2023-11-02T23:48:43 [INFO] - terminating service: process_name(whisperd-aarch64-apple-darwin) process_id(20659)

Seems process was maybe stopped, just UI was not catching up and spinner was loadin @Janaka-Steph is maybe a cahcing issue?

I just tried and don't reproduce. It stops directly without issue.
I had to reinstall it because the binary name has changed.


taxonworks:task generator should update user_tasks.yml to reflect the purpose of the task.

When the taxonworks:task generator modifies the user_tasks.yml file, it currently ignores information about what the task is to do (from the generator). It can, and should, update the newly added entry with information given to the generator.

There are two fields that could be populated, but we don't have params for them.  I think this isn't worth pursing.


"Allow" button is greyed out for approving new permission request

Reference:
https://docs.microsoft.com/en-us/azure/active-directory/verifiable-credentials/issue-verify-verifiable-credentials-your-tenant
While configuring VC with Azure AD tenant I went through all steps but stuck in permission approval steps.
"Allow" button is not enabled and hence I could not complete this tuitorial.
Kindly advise what all I can verify.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ace782b7-663f-c6b1-9fef-38b1a4bc13f3
Version Independent ID: ce32432d-42fe-c2c6-9dc8-fa89b5857065
Content: Tutorial - Issue and verify verifiable credentials using your Azure tenant (preview)
Content Source: articles/active-directory/verifiable-credentials/issue-verify-verifiable-credentials-your-tenant.md
Service: active-directory
Sub-service: verifiable-credentials
GitHub Login: @barclayn
Microsoft Alias: barclayn

@AmitavaHazra , thank you for your feedback. We'll review this and get back to you shortly!

@AmitavaHazra I followed the steps in my lab and I was able to get the Allow option working totally fine.

Can you confirm if you followed all the steps correctly ? Let us know if you have any doubts in any step.

@vipulsparsh  yes initially it failed for me. but now it is working as expected. thanks for checking this.
Can you please let me know if there is any sample .net application where exactly we can implement this VC for sign in.
Is there any sample available for that. ? My point is how we can leverage this stand alone use case with an actual application.

@AmitavaHazra There are some 3rd party links which shows some implementations. :
https://damienbod.com/2021/05/10/present-and-verify-verifiable-credentials-in-asp-net-core-using-decentralized-identities-and-mattr/


Bug in base.r2q

I get the following surprising result when using the UnitQuaternion class as the input
R = np.array([ [0, -1, 0],
               [-1, 0, 0],
               [0,  0, -1]])

UnitQuaternion(SO3(R)).SO3()

produces a different rotation matrix
SO3(array([[ 0.,  1.,  0.],
           [ 1.,  0.,  0.],
           [ 0.,  0., -1.]]))

and
UnitQuaternion(SO3(R)).vec_xyzs

produces
array([0.70710678, 0.70710678, 0.        , 0.        ])

If I try it with scipy, I get:
from scipy.spatial.transform import Rotation
Rotation.from_matrix(R).as_quat()

Output in (xyzs) format:
array([ 0.70710678, -0.70710678,  0.        ,  0.        ])

Also, the spatialmath.base.r2q_old method gives the same result as scipy (in sxyz format):
r2q_old(R)
array([ 0. ,  0.70710678, -0.70710678,  0.        ])

which indicates that spatialmath.base.r2q might be erroneous.
Is it possible that spatialmath.base.r2q be the culprit?

Thanks for spotting this.  Using base I get
>>> R
array([[ 0, -1,  0],
       [-1,  0,  0],
       [ 0,  0, -1]])
>>> r2q(R)
array([0.        , 0.70710678, 0.70710678, 0.        ])

and the sign of the third element is wrong.  If I uncomment r2q_old as you did, I get
>>> r2q_old(R)
array([ 0.        ,  0.70710678, -0.70710678,  0.        ])

This also agrees with the native MATLAB implementation and my previous MATLAB Toolbox implementation which was translated to r2q_old.
The code is a faithful implementation of A Survey on the Computation of Quaternions from Rotation Matrices by Soheil Sarabandi and Federico Thomas (76) to (79). The problem is with the sign transfer mentioned below the equations:  $(r_{13} - r_{31})$  is zero $(0-0)$ in this case  so $e_2$ does not get set to a negative value, which it should be.  In fact, for this example, all the expressions have a value of zero.
The solution isn't as simple as changing < to <= or adding a tolerance because it would flip the sign of both terms.
I should probably revert to r2q_old and maybe contact the authors of the paper.  I made the change for performance reasons, and the cases I tested for gave the correct answer.

I had a very helpful reply from Federico Thomas, coauthor of the referenced paper.  This is fixed now on future branch and I've added more extensive unit tests as well.  Please have a play and let me know.

I read the paper you linked and clearly Cayley's method seems to be the best. The new implementation looks good but would it be possible to expand a bit on the logic behind how the choice of which of the four cases is made (depending on the result from np.argmax(...)?

Ah yes, I get it now: "assuming that an element of the quaternion close to zero is positive is a bad choice because a small perturbation in the rotation matrix might induce a chance of its sign leading to an inconsistency with the rest of signs. A better option is to assume that the largest component of the quaternion is positive".
Makes sense.


DONOTMERGE: 4844 interop for geth with skip withdrawals

A branch to inteop with geth 4844

@g11tech can this be closed now that 4844 is based on capella?

yes, closing :slightly_smiling_face:


Fix generated doctests failure

Fixes https://github.com/TheBevyFlock/bevy_quickstart/issues/300.

Hm okay this doesn't work. This will need to be updated on the cargo-generate branch instead.


WIP: [Release] Verify release-8.0.0

PR to verify Release Candidate

@github-actions crossbow submit --group verify-rc-source --group verify-rc-binaries --group verify-rc-wheels --param release=None --param rc=None


Typing 🗓... in a TextField makes Flutter crash on iOS

Steps to reproduce
Create a new flutter project and add a TextField.
const TextField(
              decoration: InputDecoration(
                border: OutlineInputBorder(),
                labelText: 'TextField',
              ),
)

Run the app on an iOS simulator (iPhone 14, iOS 16.1) , tap on the text field and type 🗓... (the calendar emoji followed by three dots)
Crash logs
The app crashes and Xcode shows the following error:

Crash report
-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Incident Identifier: DDFE1C64-311F-485F-99ED-35790EB8A849
CrashReporter Key:   92EFE2BA-FF27-44D9-6B9B-848DB39A560C
Hardware Model:      MacBookPro15,2
Process:             Runner [51500]
Path:                /Users/USER/Library/Developer/CoreSimulator/Devices/006F9717-8F06-40BF-B9D0-1D1FEE0E20F5/data/Containers/Bundle/Application/EFEB4E76-1CDE-4B23-A44B-0ED0D92E938D/Runner.app/Runner
Identifier:          com.example.emojiDots
Version:             1.0.0 (1)
Code Type:           X86-64 (Native)
Role:                Foreground
Parent Process:      launchd_sim [5910]
Coalition:           com.apple.CoreSimulator.SimDevice.006F9717-8F06-40BF-B9D0-1D1FEE0E20F5 [3542]
Responsible Process: SimulatorTrampoline [1594]

Date/Time:           2022-11-07 16:12:15.5975 +0100
Launch Time:         2022-11-07 16:09:08.4285 +0100
OS Version:          macOS 13.0 (22A380)
Release Type:        User
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Triggered by Thread:  0

Last Exception Backtrace:
0   CoreFoundation                	    0x7ff8004278bb __exceptionPreprocess + 226
1   libobjc.A.dylib               	    0x7ff80004dba3 objc_exception_throw + 48
2   Foundation                    	    0x7ff800b8637c _userInfoForFileAndLine + 0
3   Flutter                       	       0x1071f4b5f -[FlutterJSONMessageCodec encode:] + 380
4   Flutter                       	       0x1071f4e8b -[FlutterJSONMethodCodec encodeMethodCall:] + 190
5   Flutter                       	       0x1071f3d79 -[FlutterMethodChannel invokeMethod:arguments:] + 51
6   Flutter                       	       0x106c02a37 -[FlutterEngine flutterTextInputView:updateEditingClient:withState:] + 119
7   Flutter                       	       0x106c1941c -[FlutterTextInputView updateEditingState] + 617
8   Flutter                       	       0x106c19c44 -[FlutterTextInputView insertText:] + 847
9   UIKitCore                     	       0x11252c1ac -[UIKBInputDelegateManager _deleteBackwardAndNotify:reinsertText:] + 469
10  UIKitCore                     	       0x1129649ad -[UIKeyboardImpl deleteBackwardAndNotify:reinsertText:] + 318
11  UIKitCore                     	       0x112958882 -[UIKeyboardImpl performKeyboardOutput:checkingDelegate:forwardToRemoteInputSource:] + 1991
12  UIKitCore                     	       0x112957d74 -[UIKeyboardImpl performKeyboardOutput:forwardToRemoteInputSource:] + 31
13  UIKitCore                     	       0x112957d3f -[UIKeyboardImpl performKeyboardOutput:] + 130
14  UIKitCore                     	       0x112931ed6 -[UIKeyboardImpl performOperations:withTextInputSource:] + 34
15  UIKitCore                     	       0x112955faf __55-[UIKeyboardImpl handleKeyboardInput:executionContext:]_block_invoke_2 + 941
16  UIKitCore                     	       0x1129ae3b0 -[UIKeyboardTaskEntry execute:] + 191
17  UIKitCore                     	       0x1129acb3c -[UIKeyboardTaskQueue continueExecutionOnMainThread] + 360
18  Foundation                    	    0x7ff800c7f5f7 __NSThreadPerformPerform + 177
19  CoreFoundation                	    0x7ff800387035 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
20  CoreFoundation                	    0x7ff800386f74 __CFRunLoopDoSource0 + 157
21  CoreFoundation                	    0x7ff800386771 __CFRunLoopDoSources0 + 212
22  CoreFoundation                	    0x7ff800380e73 __CFRunLoopRun + 927
23  CoreFoundation                	    0x7ff8003806f7 CFRunLoopRunSpecific + 560
24  GraphicsServices              	    0x7ff809c5c28a GSEventRunModal + 139
25  UIKitCore                     	       0x112bcb62b -[UIApplication _run] + 994
26  UIKitCore                     	       0x112bd0547 UIApplicationMain + 123
27  Runner                        	       0x104146f2f main + 63 (AppDelegate.swift:5)
28  dyld_sim                      	       0x1043072bf start_sim + 10
29  dyld                          	       0x10b992310 start + 2432

Flutter doctor -v

Result of doctor -v
[✓] Flutter (Channel stable, 3.0.2, on macOS 13.0 22A380 darwin-x64, locale en-GB)
    • Flutter version 3.0.2 at /Users/gustavo/flutterCode/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cd41fdd495 (5 months ago), 2022-06-08 09:52:13 -0700
    • Engine revision f15f824b57
    • Dart version 2.17.3
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/gustavo/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (4 available)
    • iPhone 14 (mobile)     • 006F9717-8F06-40BF-B9D0-1D1FEE0E20F5 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • iPhone 14 Pro (mobile) • 5322B2C8-E221-48B9-B503-98E02A91612A • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @gustanas, I'm following your Steps to reproduce but can not reproduce this issue.
As far as I can see, you are using the old Flutter version 3.0.2, the latest Flutter stable is 3.3.7 and the master is 3.5.0. Please try upgrading them and retry to see if this issue still reproduces.

Demo

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.7, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e99c9c7cd9 (27 hours ago), 2022-11-01 16:59:00 -0700
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] VS Code (version 1.72.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.5.0-12.0.pre.168, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.5.0-12.0.pre.168 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a1432a9c5d (39 minutes ago), 2022-11-07 19:17:03 -0600
    • Engine revision e7d7edab98
    • Dart version 2.19.0 (build 2.19.0-374.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.87

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Hi @huycozy thank you for checking this. You're right, updating to the latest version did the trick 👍 !

@gustanas Given your last message, I feel safe to close this issue as fixed on new versions. Thanks!


Updates to Tables spec

Addresses the comments from PR https://github.com/Azure/azure-rest-api-specs/pull/8151

@shurd - this PR should be good to go if you have no additional comments/concerns.


Cannot read property 'has' of undefined

Versions:

VueJs: 2.8.0
NuxtJs: 1.4.0
Vee-Validate:2.0.6

Description:

my config file

my .vue file

When I first entered the page，it's ok。When I refresh the page, I get an error。Error message：“Cannot read property 'has' of undefined”

Does anyone know how to solve please inform, thank you

make sure to read this note when using vee-validate with Nuxt:
http://vee-validate.logaretm.com/advanced#injection

make sure to read this note when using vee-validate with Nuxt:
http://vee-validate.logaretm.com/advanced#injection

Hey, @logaretm
I'm having the same problem and the link you posted looks like it's changed. Any chance you have the new link?

make sure to read this note when using vee-validate with Nuxt:
http://vee-validate.logaretm.com/advanced#injection

Hey, @logaretm
I'm having the same problem and the link you posted looks like it's changed. Any chance you have the new link?

Figured out my problem (not related to this). When I restart the Nuxt.js app, all my imports are no longer in index.js...


Add an advanced search function to the site

Some options to search by are the subject code, the level (1000, 2000, or 4000), when it is offered, whether it is hass inquiry/communication intensive, and what pathway(s) it is part of.

Closed by #135


Code Folding in gherkin mode does not work. Is it even supported ?

I have a web editor which is in gherkin mode and I need to add support of code folding. In ngx-codemirror there's an option called foldGutter and I have made it true in the option. Also set "CodeMirror-foldgutter" in "gutters" option.
here is the component -
<ngx-codemirror #codemirrorr
[options]="{
 lineNumbers: true,
 theme: 'idea',
 mode: 'gherkin',
 gutters: ['CodeMirror-linenumbers', 'CodeMirror-foldgutter'],
 foldGutter: true
}"
[(ngModel)]="dataSet"
(ngModelChange)="setData($event)">
</ngx-codemirror>

Imported following addon js
import 'codemirror/lib/codemirror';
import 'codemirror/mode/gherkin/gherkin';
import 'codemirror/addon/fold/comment-fold';
import 'codemirror/addon/fold/markdown-fold';
import 'codemirror/addon/fold/foldgutter';
import 'codemirror/addon/fold/brace-fold';
import 'codemirror/addon/fold/foldcode';
import 'codemirror/addon/fold/indent-fold';

Also in my styles.scss i have imported following css
@import '~codemirror/addon/fold/foldgutter.css';
But the code folding option is not coming up in the editor.  Or does codemirror even support code folding on gherkin mode or its only available for JS, HTML, Python and XML?

not sure


Add Yang to ci-team

Yang needs to be able to build the images for code_search project.
The GCB build is currently configured to use kubeflow-ci.

This change is

/assign @IronPan

/lgtm

/approve


routing error -> lead to 404 page

go to bancor.network
click swap
click pool
click create new pool
refresh
expected: see the same screen
actual: get 404 page.

done


Toast with progress bar and optional offscreen animation

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines
[X] Sample code created and tested

Proposal
I have seen a few concepts of animated progress bars in Toasts, but they seem quite complex. It would be great  if we had the option in the future to have a visual indicator, using the data-bs-delay value for width as a percentage. An option for sliding the animation offscreen would also be nice.
Motivation and context
Contextual notifications can be used both with, and without the auto-hide. Having a progress bar assists with the visual communication of when a Toast will close. Allowing a user to animate off-screen aids the visual experience.
I have created an example (work in progress) that I hope to improve further. I had to override .toast:not(.show) display in order to achieve the off-page animation.
Working example
https://codepen.io/404ryannotfound/pen/KKZgagL
Screenshot

Hopefully this isn't seen as YACB (yet another code bloat) or pointless UX exercise, but little features like these should always be reviewed if they can can be implemented nicely ¯_(ツ)_/¯

Thanks @GeoSot , feel free to  delete this Request (so as not to confuse).


What is EmissionsBreakdown for?

Is it to show details for a particular EmissionsAgg row? If so, we probably don't need actor_id, methodology_id, datasource_id, and year.

Yes, that is to show details for a particular EmissionsAgg row. Agreed that we don't need the items mentioned if that is the case


Collision Update Bugs

go through and fix all the bugs from collision update
ex. ladders
can shoot player clipsa

done. maps need to recompile to fix playerclip/ladders


'const' input support for SYCL-DNN

@Bensuo  and @ProGTX. I think all the comments were resolved. Can you approve the PR?

@Bensuo and @ProGTX. I think all the comments were resolved. Can you approve the PR?

@KumudhaN please see this comment. It is important to have the readme documentation for each option we are putting, so that we know, when, how and why to use it.

@KumudhaN please see this comment. It is important to have the readme documentation for each option we are putting, so that we know, when, how and why to use it.

Thanks, I had missed this. This is fixed now.


UI Spring Server Chassis - compile failure with Java 16

The current (non LTS) version of Java fails to compile 'UI Server Platform Chassis for Spring'
Egeria currently supports Java 8 and Java 11, however generally the code does compile with later versions of java, and we aim to keep it compliant.
Opening as a note in case others see this, plus an action to understand/resolve
The failure occurs at:
10:53:59,990 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project ui-chassis-spring: There are test failures.

The root cause is likely down to a change to 'java.naming' not exporting 'com.sun.jndi.ldap'. It's worth noting that 'com.sun' classes have been deprecated in java for many many years and releases, so it may be we have picked up some old or non-compliant code through our spring/java support, which could indicate there are other issues with old/contaminated dependencies:
java.lang.IllegalStateException: Failed to load ApplicationContext
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthContributorRegistry' defined in class path resource [org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapHealthContributor' defined in class path resource [org/springframework/boot/actuate/autoconfigure/ldap/LdapHealthContributorAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapHealthContributor' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapTemplate' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapTemplate' parameter 1; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ldapContextSource' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.ldap.core.support.LdapContextSource]: Factory method 'ldapContextSource' threw exception; nested exception is java.lang.IllegalAccessError: class org.springframework.ldap.core.support.AbstractContextSource (in unnamed module @0x11028347) cannot access class com.sun.jndi.ldap.LdapCtxFactory (in module java.naming) because module java.naming does not export com.sun.jndi.ldap to unnamed module @0x11028347
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.actuate.health.HealthContributorRegistry]: Factory method 'healthContributorRegistry' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapHealthContributor' defined in class path resource [org/springframework/boot/actuate/autoconfigure/ldap/LdapHealthContributorAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapHealthContributor' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapTemplate' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapTemplate' parameter 1; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ldapContextSource' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.ldap.core.support.LdapContextSource]: Factory method 'ldapContextSource' threw exception; nested exception is java.lang.IllegalAccessError: class org.springframework.ldap.core.support.AbstractContextSource (in unnamed module @0x11028347) cannot access class com.sun.jndi.ldap.LdapCtxFactory (in module java.naming) because module java.naming does not export com.sun.jndi.ldap to unnamed module @0x11028347
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapHealthContributor' defined in class path resource [org/springframework/boot/actuate/autoconfigure/ldap/LdapHealthContributorAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapHealthContributor' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'ldapTemplate' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Unsatisfied dependency expressed through method 'ldapTemplate' parameter 1; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'ldapContextSource' defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.ldap.core.support.LdapContextSource]: Factory method 'ldapContextSource' threw exception; nested exception is java.lang.IllegalAccessError: class org.springframework.ldap.core.support.AbstractContextSource (in unnamed module @0x11028347) cannot access class com.sun.jndi.ldap.LdapCtxFactory (in module java.naming) because module java.naming does not export com.sun.jndi.ldap to unnamed module @0x11028347

Full log : https://1drv.ms/u/s!ApVqcIDT57-fluBnuE_WbijVHniAYQ?e=HONhzP
Current java version:
$ java -version                                                                                [11:08:40]
openjdk version "16" 2021-03-16
OpenJDK Runtime Environment Zulu16.28+11-CA (build 16+36)
OpenJDK 64-Bit Server VM Zulu16.28+11-CA (build 16+36, mixed mode, sharing)

There's a suggestion that the issue is a missing export - see https://github.com/spring-projects/spring-boot/issues/25527 (though I don't think any code should be using com.sun.* ?)

WORKAROUND
export JAVA_TOOL_OPTIONS="--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED"
prior to running the build (and probably actually running the code -- as the issue here was in FVT).
This can only be applied in Java 11 & above
Still some investigation here on WHY as this seems an internal java implementation class?

The referenced issue has lots of references to 2.4.4 changes, but note that we are already using spring boot 2.4.5 and see this issue.

Following June's dependency updates, this now seems to compile ok with Java 16, so closing


conflict with WP Smush

Reported by @stbeli
in case web site has activated WP Smush for Resize, optimize and compress image, wp-statteles output PHP Error:
PHP Catchable fatal error:  Object of class stdClass could not be converted to string in /home/ucdev/web/wp-stateless.update.care/public_shtml/wp-content/plugins/wp-stateless-2.0.0-rc1/lib/classes/class-bootstrap.php on line 521, referer: https://wp-stateless.update.care/wp-admin/post.php?post=11&action=edit
Server Configuration:
PHP: 7.0.19-1~dotdeb+8.1;
Web Server: Apache / nginx
WordPress: 4.8.1

It's causing a 500 error on /wp-admin/upload.php as well.
When WP-Smush is enabled with v2.0 (or higher), I get a 500 error in the console.
When WP-Smush is disabled, the 500 error goes away.

@ewsopp I can not replicate any mentioned issue. I have two plugins activated:

Please, provide more details how I could replicate the issue ( and/or link me to site where you got 500 Error on loading upload.php ).
Thank you.

@ewsopp Fixed. The fix included to 2.0.2 release


[keymgr/dv] minor update: remove unneeded core file dependency

sec_cm is included in cip, so it can be removed
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

rebased to solve the CI failure


Create local windows drives as "network" instead of "removable"?

Is it possible to create the local windows drive as a network drive instead of a removable disk?
The problem is that whenever my virus scanner runs, it hammers my SSH server because it thinks the SSH drive is a local jump drive or something so it wants to scan all the files.  Most virus scanners doesn't scan network disks in my experience, so it would be nice to either always create them as network drives, or have the option to choose removable or network disk in configuration.

By using DokanNet.DokanOptions.NetworkDrive as param ofDokan.Mount(...), you will be able to do this :smiley:

@Liryna - Not sure where the setting you referenced would be (I'm not familair with Dokan other than WinSSHFS uses it behind the scenes), but you got me pointed in the right direction....
In the "WinSshFS.exe.config" there's a setting for "UseNetworkDrive", which I changed the value to True, and now they show up as network drives instead of removable drives.
Thanks!

Exactly, you can change manually in config file.


Fix readme typo

recheckcla

recheckcla

Jina CLA check
❤ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.

I have read the CLA Document and I hereby sign the CLA

hi, there. Thanks for the PR. Your contribution is greatly appreciated. Would you please sign the CLA above?


Dependabot Security Updates (Server)

Summary
Dependabot Security Updates keep projects secure by opening pull requests that update dependencies to a non-vulnerable version.
This extends Dependabot Security Updates to GitHub Enterprise Server (GHES).
Intended Outcome
Update dependencies which have known vulnerabilities. This helps keep a project secure.
How will it work?
Today, Dependabot Security Updates automatically create a pull request in your repository to upgrade a vulnerable dependency to the minimum possible secure version needed to avoid the vulnerability. This is an automated action corresponding to Security Alerts in your repository, for repositories where Dependency Graph is enabled.

🚢 This has shipped<EMAIL_ADDRESS>


[UNDERTOW-1875] - add system property to allow ID less matrix parameters

Issue: https://issues.redhat.com/browse/UNDERTOW-1875
This is alternative to: https://github.com/undertow-io/undertow/pull/1133

Thanks @baranowb !


Question: is there a way to disclose our private channels to certain peers?

Use case 1: I want an external service to plot a route for me accounting for my private channels
Use case 2: I want certain nodes to be able to route through my private channels, but keep those channels private for general network

In theory, you should be able to make a custom invoice that has hop hints which may not be directly adjacent to your node. This would let you create a sort of backbone private network, which is what I think you're after here. The AddInvoice call lets you set a set of custom route hints: https://api.lightning.community/#addinvoice
If the invoice is created w/ the invoice.Private flag, then it'll combine the hop hints that were passed in with its own hop hints: https://github.com/lightningnetwork/lnd/blob/4bab68a8085cd38526e62bc701725443631db5da/lnrpc/invoicesrpc/addinvoice.go#L278

What I really want is an external node that has no channels with me to be able to plot a route for me and my private channels via QueryRoutes

In theory this should be possible if you use QueryRoutes, but set the SourcePubKey to the node with the private channels, and the destination as normal. It should then treat the provided hop hints just as extra edges in the graph and work as expected*.

And second use case is that I want certain node that has no channels with me to be able to route through my private channels

This second case should also be possible if you, give them a route that already includes those private channels. This stuff should already work, but we haven't explicitly tested these scenarios.
What've you tried so far?

In theory this should be possible if you use QueryRoutes, but set the SourcePubKey to the node with the private channels, and the destination as normal. It should then treat the provided hop hints just as extra edges in the graph and work as expected*.

I've tried that, but that only works if client has public channel. as soon as I set it to private - queryRoutes on 3rd party node starts to fail.
I've built an API for this: http://lndhub.herokuapp.com/queryroutes/03864ef025fde8fb587d989186ce6a4a186895ee44a926bfc370e2c366597a3f8f/03c2abfa93eacec04721c019644584424aab2ba4dff3ac9bdab4e9c97007491dda/100
this API can plot a route from A to B, but only through public channels. if A has only private channels - this will fail.
example topology:
mobile client has private channel with ACINQ.
ACINQ has public channel with TIPPINME.
LNDHUB may or may not have channels with ACINQ or TIPPINME, but actively syncs graph.
mobile client asks LNDHUB to plot a route from himself to TIPPINME.
actual result: fail, because client's channel is private.
I know a workaround for this, that is, ask LNDHUB to plot a route from ACINQ to TIPPINME, and then manually add a hop from myself to ACINQ, but
that feels hacky