Update cncf.yaml - More repos for Score

Adding more repos for the Score project to provide more visibility here https://clomonitor.io/projects/cncf/score and also allowing to have their good first issues listed here: https://clotributor.dev/search?foundation=cncf&project=score.
Also, updated and classified the checks's types according to: https://github.com/cncf/clomonitor/blob/main/docs/checks.md.

Ready for your review, thanks!

Thanks @mathieu-benoit 👍

Thanks @tegioz! Just for my information, do you know when I could expect to have the https://clotributor.dev/search?foundation=cncf&project=score updated accordingly? In the main README.md, it says "periodically every hour", but not sure about that.

No worries!
Yes, every hour. Could you point me to some issues you'd expect to have been indexed?
Please note that, as mentioned in the repository's readme file, CLOTributor only indexes issues that match certain criteria:

Contain the help wanted label
Their state is OPEN
They are unassigned
Updated within the last year

Sure, for example these ones:

https://github.com/score-spec/score-compose/issues/179
https://github.com/score-spec/score-go/issues/47
But I see, that's the help wanted label which is missing, fixing this on my end, thanks!


Support external deletion of non-terminal map task subtasks

TL;DR
Updating the flyteplugins version to pickup support for external deletion on map task subtasks.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/2701
Follow-up issue
NA

Hi Flyte team, could you please confirm if FlytePropeller v1.1.21 is prod ready ?


move everything into autonomous and independent roles

Massive refactor of playbooks logic to autonomous and independent roles.
This makes Seapath very modular, and should help with the merge. This also allows to publish the majority of the seapath code in an ansible collection on galaxy.
At the end of the whole process, there is no file left in the ./src/ and ./templates/ folder, since all files and templates are now in there respective role folders.
This is just code organizing, there is no API change.

Change the "test" commit message otherwise LGTM.

That was a test commit, I just dropped it and rebased everything on debiancentos


[NFC] Add a test for constraint generation failures in a pattern binding decl inside of a function builder

This used to crash, but was fixed in #32221

@swift-ci please smoke test

@swift-ci please smoke test Linux platform


feature request: res.on('finish', callback)

Adding a callback when the request has finished would be useful for tidying up any post-request actions (e.g. sending logs/metrics/traces).
Currently we're working around this using a polling approach on res.hasEnded, but this is quite wasteful (all of the polling effort, added complexity and that after the request finishes but before the next poll the app will be sitting doing nothing).

Agreed this would be useful, looks like @doramatadora is the main contributor here maybe they could help/provide some insight?

I'm sorry this one took a while–we aim to do better! You can now use res.on('finish', cb) in<EMAIL_ADDRESS>


"Error loading plugin" message doesn't include backtrace even with --verbose or --troubleshoot

New Issue Checklist

[ ] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
If a plugin fails to load, fastlane will print an error like
Error loading plugin 'fastlane-plugin-foo': Some error message.

But it won't include any backtrace, which means I can't figure out the cause of the error. The error message is enough to identify the line of code throwing the error, but I can't determine why this code is being invoked during the plugin load.
Even adding --verbose or --troubleshoot does nothing. I would have expected one of those flags to include the backtrace of the load error.
Captured Output
Command Used: lanes --capture_output
Output/Log

DEBUG [2021-01-21 16:28:43.12]: Checking if there are any plugins that should be loaded...
DEBUG [2021-01-21 16:28:43.12]: Loading 'fastlane-plugin-firebase_app_distribution' plugin
INFO [2021-01-21 16:28:43.12]: gem 'fastlane-plugin-firebase_app_distribution' is already installed
DEBUG [2021-01-21 16:28:43.16]: Loading 'fastlane-plugin-test_center' plugin
INFO [2021-01-21 16:28:43.16]: gem 'fastlane-plugin-test_center' is already installed
ERROR [2021-01-21 16:28:43.22]: Error loading plugin 'fastlane-plugin-test_center': Could not determine installed iOS SDK version. Try running the _xcodebuild_ command manually to ensure it works.
DEBUG [2021-01-21 16:28:43.22]: Loading 'fastlane-plugin-sentry' plugin
INFO [2021-01-21 16:28:43.22]: gem 'fastlane-plugin-sentry' is already installed

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.15.7

Ruby
2.6.6

Bundler?
true

Git

Installation Source
/nix/store/gar5pyjxnwa5z95zqywxxf0f65apjm6n-fastlane-2.161.0/bin/.fastlane-wrapped

Host
Mac OS X 10.15.7 (19H114)

Ruby Lib Dir
/nix/store/sr4l5lknv8f35mxpj3sb7qkn57yc0w3s-ruby-2.6.6/lib

OpenSSL Version
OpenSSL 1.1.1g  21 Apr 2020

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Library/Developer/CommandLineTools/

Xcode Version

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.161.0
🚫 Update available

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-firebase_app_distribution
0.2.5
✅ Up-To-Date

fastlane-plugin-test_center
3.15.1
🚫 Update available

fastlane-plugin-sentry
1.8.0
✅ Up-To-Date

Loaded gems

Gem
Version

rake
13.0.3

CFPropertyList
3.0.3

concurrent-ruby
1.1.7

i18n
1.8.7

minitest
5.14.3

tzinfo
2.0.4

zeitwerk
2.4.2

activesupport
6.1.1

public_suffix
4.0.6

addressable
2.7.0

artifactory
3.0.15

jwt
2.1.0

atlassian-jwt
0.2.0

atomos
0.1.3

aws-eventstream
1.1.0

aws-partitions
1.416.0

aws-sigv4
1.2.2

jmespath
1.4.0

aws-sdk-core
3.111.0

aws-sdk-kms
1.41.0

aws-sdk-s3
1.87.0

babosa
1.0.4

bundler
2.1.4

claide
1.0.3

colored
1.2

colored2
3.1.2

colorize
0.8.1

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.20

declarative-option
0.1.0

digest-crc
0.6.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.7.6

emoji_regex
3.2.1

excon
0.78.1

faraday-net_http
1.0.1

multipart-post
2.0.0

ruby2_keywords
0.0.2

faraday
1.3.0

http-cookie
1.0.3

faraday-cookie_jar
0.0.7

faraday_middleware
1.0.0

fastimage
2.2.1

gh_inspector
1.1.3

memoist
0.16.2

multi_json
1.15.0

os
1.1.1

signet
0.14.0

googleauth
0.14.0

httpclient
2.8.3

mini_mime
1.0.2

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.38.0

rexml
3.2.4

google-apis-core
0.2.0

google-apis-iamcredentials_v1
0.1.0

google-apis-storage_v1
0.1.0

google-cloud-env
1.4.0

google-cloud-errors
1.0.1

google-cloud-core
1.5.0

google-cloud-storage
1.30.0

json
2.5.1

mini_magick
4.11.0

plist
3.6.0

rubyzip
2.3.0

security
0.1.3

naturally
2.2.0

simctl
1.6.8

slack-notifier
2.3.2

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.19.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

fastlane-plugin-firebase_app_distribution
0.2.5

fastlane-plugin-sentry
1.8.0

trainer
0.9.1

xctest_list
1.2.1

fastlane-plugin-test_center
3.15.1

oauth
0.5.4

jira-ruby
2.1.4

xcode-install
2.6.8

generated on: 2021-01-21

Notes
For this particular error I can file an upstream issue with the plugin author, but without knowing the cause I can't seek any local workarounds.
Also I checked the fastlane code that loads plugins and it hasn't changed in at least 4 years, so I'm pretty sure updating fastlane won't change anything.

This issue is literally only a month old.  Would you like to open a PR with this tiny change? Or, could you provide steps to reproduce this issue so I can test it myself and open the PR? 🙏

@rogerluan I no longer work at the company that had this problem, so I don't have precise reproduction steps, but my recollection is it involved loading fastlane-plugin-test_center when there was some issue with the currently-selected default Xcode. The plugin was for some reason trying to fetch information from Xcode at load time, instead of when the plugin was later used. The Fastfile specified a working version of Xcode, so everything would have worked just fine if it simply deferred whatever loading it was doing until later.
I located the code that produced the error message by searching for the message itself, that particular error was thrown from the Fastlane core, but I could not for the life of me figure out how fastlane-plugin-test_center was getting to that method while loading. This is why I wanted the stack trace, so I could figure out what was actually going wrong.


Problem with date-calculation

currently calculating the day of a month with:

export const `MONTH_AS_MILLISECONDS = DAY_AS_MILLISECONDS * 30;

problem: not every month is 30 days long
maybe think about another time-system -> currently from beginning of extension time starts and runs e. g. 1 month -> when in middle of month, then it should reset on the end of the month

Release: for now this is not mandatory for the mvp-release


aurbuild_chroot: sync databases not updated

As a workaround, manually deleting the user container before each build seems to work fine, as the root container is updated successfully.

Thanks for the feedback. Do you have a pointer as to when this stopped working? I don't think I've made particular changes in aurbuild(_chroot) that explain this behavior...

https://github.com/AladW/aurutils/commit/04f27f49e7afadfd4db1ce5282b9e7d56dbfffc3

Yes, this did the trick, the user container is updated again, thanks! 👍

==> Synchronizing chroot copy [/var/lib/aurbuild/x86_64/root] -> [klemens]...done


Is this project still maintained?

@jjtykkyl are you still alive?
If you don't have the time to maintain it anymore you might want to ask if somebody else wants to step in. And not, not me. :)

Hi @burzum,
Thanks for the concern! We're still maintaining the project as it's a core part of our product.
We've unfortunately been very busy with other development requirements as we've gained more and more customers and haven't thus had as much time for maintaining the project and engaging the community as we would've liked.
If there are volunteers interested in maintaining the project, we're glad to take people onboard, just let us know!


Icon overlapping with border highlight texture

Reported by a user:
Is there any way to get the indicator icons to overlap the frame highlight , like the default buffs and debuffs do. When you highlight a target it clips the icon, one way I've dealt with this is by moving the poisoning in the lua but then you end up with a cluttered raid frame, as everything is squeezed in to account for the raidframe highlight. Let me know and thank you so much.
below is a screen show, the debuff is blizzards debuffs, all other icons are done in raidframe addon and are partially cutoff, where as the debuff is above the highlighted border and more visible whereas the addons raidframe icons are clipped by the raidframe highlight border and less visible.

fixed


Issues retrieving data from sites containing different agency codes

I am having issues retrieving data, it won't retrieve data at all and give me the errors below, when I add a Site number that contains a different agency code aside from the USGS agency code. Only USGS agancy coded site numbers will work.
Errors:
[1] "Problem with data import, please check import criteria"
[1] "ODBC message: Site does not exist in environmantal or QA database sitefile, check site number

To import from sites with non-USGS agency codes, append the agency code and a dash before the site number. Example: USEPA-333330112164801
This documentation is in the R package help file for readNWISodbc, but needs to be added to the WQReview 2.0 GUI User Guide. I'll keep this Issue open until that change is made.

@cpenn-usgs Thank you so much, Colin! It worked :)

closed by PR #175. Now added clarification to the User Guide on how to get sites with different agency codes


[Fields] Construct fields from definition on form creation

When the CREATE_FORM action is dispatched, a middleware (still don't know which one, might be the form middleware) must populate the created fields based on the definition provided to the form.

Si dans le dataSet il n'y pas tout les champs de la definitions, alors l'informations n'est pas dans le fields.


Reduce total downloads and image sizes to a fraction by using intermediate image(s)

E.g. "ChatQnA" service is based on 9 microservices, of which several use images with the same large python libraries (like PyTorch) duplicated on them.
By building/using intermediate image containing the shared dependencies:

Large dependencies are downloaded / built only once during image builds
Rest of the images are small as those deps are on shared layer, instead bloating sizes of all the images
Smaller images mean first run of the given containers (on given host) being much faster

I.e. it will take significantly less bandwidth, disk space and time, which all are cost reductions on rented clusters.
As an example, here's documentation on how Kubeflow images are layered: https://www.kubeflow.org/docs/components/notebooks/container-images/
(Once this ticket has been fixed, similar doc+graph for OPEA images and their layering would be nice.)

we will split it after other tasks

will assign to ashahba


fix: adding parameter aggregation functionality

Types of changes

[ ] Hot fix (emergency fix and release)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
Addition of parameter aggregation when a certain parameter for a given control has to aggregate values from other parameters.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

Still in draft mode, test cases improvement to be more precise will be added.


Update sample key

REF: #189
Signed-off-by: yi1 li<EMAIL_ADDRESS>

I think we can fix https://github.com/DMTF/spdm-emu/issues/7 as well.

Looks good to me.


E3002 Invalid Property Resources/RESTAPI/Properties/Mode

cfn-lint version: 0.52.0
AWS::ApiGateway::RestApi.Mode is a valid property, but cfn-lint shows an error:

E3002 Invalid Property Resources/RESTAPI/Properties/Mode

This is similar to #1219, but this property was released on April 15, 2021, so it doesn't just look like the AWS CloudFormation resource specification is lagging, but that the property was completely forgotten to be added.

@PatMyron any thoughts on this?  We've been fortunate to not have to patch much in lately but the fact that we haven't seen this one in the spec yet has me a little concerned.

I've asked the team if it's possible to get this fixed in this week's release

AWS::ApiGateway::RestApi.Mode has been added to the spec

#2066 will be the PR for getting it into cfn-lint


discussion: no documentation on how to prevent CSRF to pass PCI compliance

My search for CSRF revealed that the CSRF NPM package might be vicariously required. Then search for token revealed that you have a userToken concept.
What I can't figure out is:
How do we implement CSRF on Algolia search boxes?
I really don't care about the security, but the PCI audit does.

The yarn.lock you linked in case isn't used in the library, but rather in a devdependency. Could you explain what the goal of the CSRF is in your use case?

Even though I know that CSRF against the Algolia search form is not a danger, our quarterly PCI compliance audit requires us to prove it and get granted an exception. All over again each quarter.
I'd like to implement something like: https://en.wikipedia.org/wiki/Cross-site_request_forgery#Cookie-to-header_token
The idea would be that the form submission would come with a cookie and a header that must match. If they do not, reject the search.

Could you  clarify how there's a  form submission for a regular Algolia search? Normally if you are using the js client, you'd search frontend without ever submitting a  form (only sending XHRs). If you are submitting forms, then this should be done in your own backend, since the search can not know what a user has access to. I advise you to maybe take a look at secured api keys: https://www.algolia.com/doc/api-reference/api-methods/generate-secured-api-key/. You can add a set time to the key and revalidate before it expires. This way a stolen api key only stays useful as long as the user is logged in.

Because this issue seems to be inactive for quite some time now, I've closed it. If you feel this issue deserves some attention feel free to reopen it.


Bug: Library does not work under strict Content-Security-Policy

Describe the bug
Library does not work under strict Content-Security-Policy
Steps
Because of the dependency to js-sha256, the package does not work when the Content-Security-Policy does not include unsafe-eval. (see this issue in js-sha256)
Expected behavior
@coinbase/wallet-sdk should be able to work under CSP, remove packages that use eval()
Version
3.1.0
Additional info
No response
Desktop
No response
Smartphone
No response

Bug

Sir please please help me how i can get came back my money
On Thu, Jun 16, 2022 at 19:10 Brian Chitester @.***>
wrote:

@joestakey https://github.com/joestakey I've created a pull request to
hopefully resolve this issue for you. Are you able to pull the branch and
verify?
—
Reply to this email directly, view it on GitHub
https://github.com/coinbase/coinbase-wallet-sdk/issues/520#issuecomment-1157855852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYCRSP5HNS45AJ6XHSCE7V3VPNGV5ANCNFSM5VZKYG3A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Fixed with #577 released in v3.4.0

What do you mean now please i need help you
On Fri, Jul 22, 2022 at 18:20 Brian Chitester @.***>
wrote:

Closed #520 https://github.com/coinbase/coinbase-wallet-sdk/issues/520
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/coinbase/coinbase-wallet-sdk/issues/520#event-7047332267,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYCRSP56HMWCR4AB2WIXMYTVVK33NANCNFSM5VZKYG3A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


Multus Readme, change cniVersion for Kubernetes 1.16

Readme Documentation change:
At least Here https://github.com/intel/multus-cni/blob/master/doc/how-to-use.md#networkattachmentdefinition-with-json-cni-config
cniVersion should be changed, errors observed in logs
[plugin multus does not support config version ""]

In new Kubernetes release they changed API a bit:
So we need to make assumption in docs that for Kubernetes 1.16 - cniVersion should be changed to 0.3.1 from 0.3.0

Last week Kubespray has released its latest stable release (v2.12.0) which deploys Kubernetes v1.16.3.  The kube_network_plugin_multus configuration value enables Multus CNI installation. This tool uses the nfvpe Docker images for its deployment and the multus_image_tag configuration values to specify the version to be used which for this release is v3.2.1.
If Multus is enabled, the 00-multus.conf file created by the kube-multus-ds-amd64 Daemonset will have the following content for flannel.
{
  "name": "multus-cni-network",
  "type": "multus",
  "kubeconfig": "/etc/cni/net.d/multus.d/multus.kubeconfig",
  "delegates": [
    {
      "name": "cni0",
      "cniVersion": "0.3.1",
      "plugins": [
        {
          "type": "flannel",
          "delegate": {
            "forceAddress": true,
            "hairpinMode": true,
            "isDefaultGateway": true
          }
        },
        {
          "type": "portmap",
          "capabilities": {
            "portMappings": true
          }
        }
      ]
    }
  ]
}

This configuration is only causing errors in Kubelet when Kubernetes v1.16.3 is deployed.
[plugin multus does not support config version ""]

I'm wondering which is the right configuration value or version to be used for Kubernetes v1.16.3

CNI version v0.3.1 and Multus v3.4 not working on k8s v1.16.7


Moving Bucket._patch_properties (and patch) to _PropertyMixin.

NOTE: Has #688 as diffbase.
Also updating _PropertyBatch to call patch on __exit__.
It seems removing _patch_properties outright is a possibility

Coverage remained the same at 100.0% when pulling f85f0d9fd6c616388a5ed644e623038ef003ed36 on dhermes:storage-remove-patch-properties-blob into 83f92cc1edf1e8e0e39a5f6b7f37fb8c0ffbaf95 on GoogleCloudPlatform:master.

LGTM, module my quibble on set.update() (which you can ignore, if you disagree).

Coverage remained the same at 100.0% when pulling fcbffb53f361c02fa12bf2ca84a713ddbf3df9f9 on dhermes:storage-remove-patch-properties-blob into 982dd564528e17cb4371cd33514a801ca0afb001 on GoogleCloudPlatform:master.


[Support]: Clean the render without console.clear

What are you trying to do?
Is there a way to clean the render without console.clear like glow (https://github.com/charmbracelet/glow)?
https://github.com/user-attachments/assets/d493b51b-fea0-4725-b15e-27b8f393c534
Code

Library Version
3.7.0
Node Version
20.16.0
What operating system are you using?
Windows
Terminal
Wezterm + WSL

Thanks for the issue 🙏
I'll check when I return home after summer holiday.
Have a nice day

@Elius94 Nice, thanks! Enjoy your holiday!

Hi! I can add console.clear() at the end of the console-gui-tools life, but there are no alternatives I think.


Downgrade JDK package

For some reason, the "openjdk-11-jre-headless" package will produce a certificate bundle that Java can't read.
This can be verified locally with Docker. Use the following Dockerfile:
FROM ubuntu:18.04
RUN apt-get update && apt-get install -y --no-install-recommends openjdk-11-jre-headless
CMD ["keytool", "-list", "-keystore", "/etc/ssl/certs/java/cacerts"]

Build the image and run it:
Warning: use -cacerts option to access cacerts keystore
Enter keystore password:
*****************  WARNING WARNING WARNING  *****************
* The integrity of the information stored in your keystore  *
* has NOT been verified!  In order to verify its integrity, *
* you must provide your keystore password.                  *
*****************  WARNING WARNING WARNING  *****************

Keystore type: PKCS12
Keystore provider: SUN

Your keystore contains 0 entries

(keytool -list -cacerts produces output without the warning but isn't portable.)
Using the "openjdk-8-jre-headless" package, however, will produce a valid bundle.
I added a guard to the scripts for generating the Heroku-16 and Heroku-18 stack images to guarantee that we don't introduce this regression.
The failure prior to the downgrade is demonstrated by 334adbb9888e6deeff020d1af36cc7104ba6da30.

It seems that if you provide the key store password ("changeit") to keytool -list -keystore /etc/ssl/certs/java/cacerts, it works with both packages.

The problem appears to be due to a change in format from JKS to PKCS12. For whatever reason, the new format now requires the use of the password ("changeit") to read/list the certs in the bundle. I recommend that we track this issue, and escalate to Canonical if it's not fixed.


go/format: go1.11 gofmt regression in map entries indent

What version of Go are you using (go version)?
gofmt from go1.11rc1
Does this issue reproduce with the latest release?
yes, go1.11rc1
What did you do?
main.go formatted with gofmt from go1.10:
package main

var x = map[string]bool{
	"aaaaaaaaaaaa":                             true, // <---
	"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": false,
	"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb":   true,
	"bbbbbbbbbbbb":                             false,
}

$(go1.11rc1 env GOROOT)/bin/gofmt -d main.go
diff -u main.go.orig main.go
--- main.go.orig	2018-08-16 12:52:52.329803591 +0200
+++ main.go	2018-08-16 12:52:52.330541553 +0200
@@ -1,7 +1,7 @@
 package main

 var x = map[string]bool{
-	"aaaaaaaaaaaa":                             true, // <---
+	"aaaaaaaaaaaa": true, // <---
 	"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": false,
 	"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb":   true,
 	"bbbbbbbbbbbb":                             false,

What did you expect to see?
No change in formatting of this code between go1.10 and go1.11
What did you see instead?
gofmt from go1.11rc1 reformats this code in a lesser readable way than go1.10: first entry of the map is not indented in the same way as other entries.
package main

var x = map[string]bool{
	"aaaaaaaaaaaa": true, // <---
	"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": false,
	"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb":   true,
	"bbbbbbbbbbbb":                             false,
}

This is expected. From the release notes:

One minor detail of the default formatting of Go source code has changed. When formatting expression lists with inline comments, the comments were aligned according to a heuristic. However, in some cases the alignment would be split up too easily, or introduce too much whitespace. The heuristic has been changed to behave better for human-written code.

Also note that:

[...] these kinds of minor updates to gofmt are expected from time to time. In general, systems that need consistent formatting of Go source code should use a specific version of the gofmt binary.

Closing as this is working as intended. Please see https://github.com/golang/go/issues/26228 for more details.
Thank you.


Add method to get time since start of match

Currently there is an offset between the output of Robot.time() and the time into a match caused by the time spent at wait_start().

This difference is expected and normal. It's also explicitly documented that the zero time here is the start of the simulation, so this would be a breaking change.
I am strongly against this, for a number of reasons:

this would not have a well-defined meaning when in development mode
this is not how time.time works on the Robot kits (and it would be complicated to make it behave like this on the kits)
this is not representative of how general APIs work -- you don't usually find that APIs provide a value for your local convenience, rather they provide tools for you to work with

This is also super easy to custom implement:
R = Robot()
start_time = R.time()

Should team need this, I think that's totally fine to require them to do, especially given it's explicitly documented and super simple.

How obvious to teams is it that time has slightly different properties in comp mode? If it's not obvious that there is this waiting period at the start of matches teams could quite resonably write something that works fine in dev but doesn't account for this delay.

How obvious to teams is it that time has slightly different properties in comp mode?

I'm not sure that's a true framing of this. The behaviour of Robot.time() is documented as being in reference to the start of the simulation. The docs themselves already show that time should be measured as that between two measurements, rather than as an absolute value.

If it's not obvious that there is this waiting period at the start of matches teams could quite resonably write something that works fine in dev but doesn't account for this delay.

That competition mode has different properties is well established (although perhaps not well documented). If this is proving to be an issue the we should fix that issue.
Another option here might be to record the real time.time() value at the start of the simulation and add that to the value returned by Robot.time(). That would make it really obvious that the absolute value should not be used, without creating cases which are complex to solve (such as what to do outside competition mode). This would of course be a breaking change, so not something we can do this year.

From the discussion on discord and a look through the docs, the fundamental issue here is that at no point do we state that in comp mode the robot will wait at the R = Robot() line until the match begins. As such it is unclear to teams where to measure the start time from, especially as in dev mode the value returned both before and after that line are the same.

Ah, yeah. This was trivially obvious on the kits because of the start button. The simulator does somewhat mask that.
It would be easy enough to force a timestep during wait_start even in dev mode.

Ultimately this is probably a docs issue but adding a little delay in wait_start dev mode is probably a good move.


Expose CompareLimit variable, controlling recursion when comparing cyclic data.

Fixes https://github.com/google/starlark-go/issues/360

The code change seems fine, but please follow our conventions for the commit message and PR: a concise summary line, a motivation, and a list of other effects or risks.

Alan, thanks for the review. What can I do to help this move forward?


Please add support to use MicrosoftCognitiveServicesSpeech.xcframework using Swift Package Manager.

Is your feature request related to a problem? Please describe.
I did not see if we can link MicrosoftCognitiveServicesSpeech.xcframework using SPM in my app. I do not want to use cocoa pods or link a downloaded XCFramework (every new version would need downloading it again)
Describe the solution you'd like
Please provide support for Swift Package Manager for iOS and Mac developers so we can link the framework as swift package.

Agreed

Hello, and thank you for reaching out with your feature request!
We understand that integrating Speech SDK through Swift Package Manager (SPM) would be beneficial for iOS and Mac developers, providing a more streamlined and convenient approach.
While we can't provide a specific timeline for adding SPM support, we greatly appreciate your suggestion and have taken note of it. Community feedback, upvotes, and support play a significant role in helping us prioritize our work and make improvements to the SDK. We encourage other developers to chime in and express their interest in this feature, as this will help us understand the demand and prioritize accordingly.
Once again, thank you for your valuable input, and please feel free to share any additional ideas or concerns you may have.

Internal work item ref. 7044008. No ETA.

Closing the issue since we actually have a backlog item about this that was created 2 years ago - and there isn't any faster resolution expected in the near future... If this does get planned for release at some point, we'll update status here.

Please support SPM, make it to be Priority number one


Validate if all tracks have been played at the end

This provides an extra guarantee in conjunction with #22.

It might make sense to instead return a tuple (numberOfTracksPlayed, numberOfTracksAvailable). This for me is particular useful to assert expectations. I had cases where with RAC, I was expecting an HTTP Request to be made once, and it was actually being called twice.

You can restrict the number of times a certain track, and consequently a request, should and can be played using #22, so right now you have mechanisms to catch that kind of situations where a request was performed twice instead of one.
But I see your point and one of our main goals is flexibility and with that in mind I would like to propose provide hooks to promote extensibility and which could be the base to support that kind of validations. Do you agree with that approach?


TypeError: pcm2float() got an unexpected keyword argument 'dtype'

The parameter name of 'dtype' in the call to pcm2float() does not match the actual parameter name of 'output_dtype'.
https://github.com/bjbschmitt/AMFM_decompy/blob/9921baa2d6208de7a61b0fabb2da2e9fe8ed7bc7/amfm_decompy/basic_tools.py#L39

Hi Richard, thank you for your feedback. Could you please send me the wav that caused the issue, so that I can implement the proper fix?

http://www.ws.binghamton.edu/zahorian/yaapt/yaapt.zip
Within zip,
YAPPT_v4.0\sample\f1nw0000pes_short.wav
import amfm_decompy.basic_tools as basic
signal = basic.SignalObj('f1nw0000pes_short.wav')
From: bjbschmitt
Sent: Sunday, February 16, 2020 8:07 AM
To: bjbschmitt/AMFM_decompy
Cc: Richard Hemphill; Author
Subject: Re: [bjbschmitt/AMFM_decompy] TypeError: pcm2float() got anunexpected keyword argument 'dtype' (#8)
Hi Richard, thank you for your feedback. Could you please send me the wav that caused the issue, so that I can implement the proper fix?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Ok, I have tested
import amfm_decompy.basic_tools as basic
signal = basic.SignalObj('f1nw0000pes_short.wav')
and everything went fine. Could you please send a print screen from your error message? Maybe it can help me to find out why it is not working in your computer.

See attached.
From: bjbschmitt
Sent: Monday, February 17, 2020 8:50 PM
To: bjbschmitt/AMFM_decompy
Cc: Richard Hemphill; Author
Subject: Re: [bjbschmitt/AMFM_decompy] TypeError: pcm2float() got anunexpected keyword argument 'dtype' (#8)
Ok, I have tested
import amfm_decompy.basic_tools as basic
signal = basic.SignalObj('f1nw0000pes_short.wav')
and everything went fine. Could you please send a print screen from your error message? Maybe it can help me to find out why it is not working in your computer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Ok, I understand now your point, the name of the variable is wrong. I will fix it then and also make some improvements.
The only thing strange is the fact that this bug remained unnoticed for so much time. As I mentioned, my computer ignores it and probably employs the default value for output_dtype. Maybe it is something related with the installed Python/Conda version, or something like that.

Hi Richard, sorry about the delay. I have fixed the bug and uploaded the new AMFM_decompy 1.0.9 version to both PyPi and github repositories. The documentation has also been updated as well.
Please upgrade your AMFM_decompy version through pip and check if the problem has in fact been solved.

Latest version works.  Thanks.


code --add breaks if executed repeatedly

VSCode Version: Code 1.18.0
OS Version: Darwin x64 17.3.0

Executing a command like code --add path1 && code --add path2 (...) code --add pathN completely breaks the window, I only get a couple of paths added no matter what, duplicated icons in the statusbar and the entire thing basically becomes unstable/unusable.
Executing code --add path1 path2 (...) pathN works just fine, unfortunately for a high number of paths I can't submit this command to the terminal via the terminal#sendText method because of https://github.com/Microsoft/vscode/issues/38137.

@fabiospampinato what exactly happens in your case? For me I just see the last folder not getting added (only 2 work) and an exception in the console. Do you also see an exception?

@bpasero I've made a screencast to properly illustrate this.
Basically: I only get 2 folders, no exceptions, duplicated icons in the statusbar and the window basically freezes for a while.

@bpasero do you need "more info" from me? If so, what else is needed?

This is a race condition where the first --add request causes lots of work to happening. A pushed a change to buffer the requests for --add for 100ms before processing them. I think that should solve the issue.


Allow CLI watching with piping

This is a feature request concerning the node-sass CLI.
Although it's possible to pipe the result of a CLI compile command to another process, e.g. postcss-cli, and it's also possible to watch files with the CLI, it seems it's not possible to do both at the same time. It would be nice if this was possible without needing another process to wrap it. In the meantime however, it can be done that way e.g. node-sass-watcher.

I'm looking at this for v5. Could you please show an example command you'd expect to use? So that I can verify its working as expected.

Well I guess the underlying pattern would be this...
node-sass [options] [relative-input-path] | [other-app] [other-app-options] > [relative-output-path]

...and the actual use-case that I had in mind, basically this
node-sass -w input.scss | postcss -u autoprefixer > output.css

Do you have an example of a tool that does this. It's not clear to me how
this would work given that the watch flag make node-sass a long running
process.
On Tue., 24 Apr. 2018, 10:02 pm Lu Nelson<EMAIL_ADDRESS>wrote:

Well I guess the underlying pattern would be this...
node-sass [options] [relative-input-path] | [other-app] [other-app-options] > [relative-output-path]
...and the actual use-case that I had in mind, basically this
node-sass -w input.scss | postcss -u autoprefixer > output.css
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2099#issuecomment-383905526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWP6PN52U5SqI6C_RVTrg9w1NzRFuks5trxRygaJpZM4Pb6GD
.

No, and I can see that my expectation WRT syntax here is naïve and probably not possible. If I understand it right, node-sass' CLI can't really be 'aware' of what comes after the | character right? But essentially what I'm asking for is for node-sass to go in to watch mode and pipe itself to another process every time it runs. So if it's not possible in the form above, maybe the entire args after the | (which could in theory might be more than one piping) needs to be passed to node-sass as an arg? Like
node-sass -w input.scss --pipe 'postcss -u autoprefixer > output.css'

You can pipe a stream of bytes. But how the receiver would know that the file is over and the next one begins? Even if this would be applied to one file only, how do we tell 'the file is complete, now waiting for changes'
I can imagine something like this stream the endless tape archive, but probably there are no tools to receive such a stream and process it accordingly.
What could work is streaming just if file names, line by line.

chokidar-cli lets you do the following:
chokidar 'src/scss/**/*.scss' -c 'npm run build-task:scss-compile && npm run build-task:autoprefixer'

Effectively, it only watches the files for changes and runs the provided commands on change. The instruction could itself then include an instruction to process sass files, among other things (such as in my case, an autoprefixer).

That's a pretty good alternative, but IIRC node-sass makes internal use sass-graph in watch mode to track the actual @import graph of the entry file you give it, rather than a catch-all glob (which could run the build unnecessarily)

So I've done a bunch of looking around for prior art or conventions in this
space and couldn't find anything.
I'm very hesitant to add this bespoke behaviour to node-sass. I wanted to
suggest a generic glue tool instead.
That chokidar things is interesting. The sass-spec point bus a good one.
You could however use the sass-graph bin to figure out the ancestors of the
changed file to know which to pipe into node-sass.
On Tue., 8 May 2018, 10:46 am Lu Nelson<EMAIL_ADDRESS>wrote:

That's a pretty good alternative, but IIRC node-sass makes internal use
sass-graph in watch mode to track the actual @import graph of the entry
file you give it, rather than a catch-all glob (which could run the build
unnecessarily)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2099#issuecomment-387330898,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWOjjntqhgbromoedvNc3AErK89PMks5twVt5gaJpZM4Pb6GD
.

We could export a second binary that encapsulates the additional sass-graph
logic for these use cases
On Tue., 8 May 2018, 9:20 pm Marcin Cieślak<EMAIL_ADDRESS>wrote:

I think we should enable others to extract sass import graph and run
watchers on the resulting tree. Maybe we could get rid of watch
functionality in our CLI then.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2099#issuecomment-387513215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWJvoy_Plwwik6XbwVGLj5VDLnZLpks5twfAagaJpZM4Pb6GD
.


net_buf reference count not protected

Describe the bug
I tested heavy TCP traffic load by 32 connections sending data to 32 tcp echo server threads on MIMXRT1060_EVK board, and at the same time using 'ping -f' to make zephyr busy handling ICMP packet.  After one day, system crashed as following:

I tested many times, and there was a time the system halted due to assertion in k_spin_unlock() saying "Not my spinlock %p" in which the spin lock pointer pointed to _net_buf_pool_area. I didn't capture the error message at that time, but I tried to use atomic operation to protect reference count of net_buf by referencing https://github.com/zephyrproject-rtos/zephyr/commit/5ef825fdf6e760db0fcd9107bc3fbdbba15d547a committed by @jukkar . I changed 'uint8_t ref' in 'struct net_buf' to 'atomic_t atomic_ref', and simply used atomic_inc(&buf->atomic_ref) to replace original 'buf->ref++',  atomic_dec(&buf->atomic_ref) to replace original 'buf->ref--',  atomic_get(&frag->atomic_ref) to replace original code reading  reference count.
Though not knowing why this modification can solve my problem, but after protecting net_buf reference count using atomic operation, my test has run for 3 days and keeps running.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit: Zephyr v2.5.0

I changed 'uint8_t ref' in 'struct net_buf' to 'atomic_t atomic_ref', and simply used atomic_inc(&buf->atomic_ref) to replace original 'buf->ref++', atomic_dec(&buf->atomic_ref) to replace original 'buf->ref--', atomic_get(&frag->atomic_ref) to replace original code reading reference count.

This change would be welcomed and it most probably fixes your issue. Could you create a PR for this change?

I changed 'uint8_t ref' in 'struct net_buf' to 'atomic_t atomic_ref', and simply used atomic_inc(&buf->atomic_ref) to replace original 'buf->ref++', atomic_dec(&buf->atomic_ref) to replace original 'buf->ref--', atomic_get(&frag->atomic_ref) to replace original code reading reference count.

This change would be welcomed and it most probably fixes your issue. Could you create a PR for this change?

OK, but as a newbie, I am reading Contribution Guidelines and then will create a PR.

I think the main reason it's a uint8_t is that it creates a smaller struct size. We should consider solving the same by adding irq_lock/unlock or similar to the appropriate places in the implementation.

@jhedberg we would need spinlock in order to support SMP. Either global for all net_bufs or one per net_buf, which would consume more space than atomic.
Just to confirm, was using net_buf supposed to be thread-safe? There are not so many places where net_buf_ref() is actually used...
I am uncertain that using atomic reference counting is actually solving described bug. TCP application should operate on net_pkts underneath. net_pkts have their own reference counting and net_buf is only unrefed once after net_pkt reference count reaches zero. In other words, I don't see who is calling net_buf_unref second time, that results in race condition.

Unfortunately my system crashed on the 4th day of test with messy text dumped on debug console:

I wrote a modified net_pkt_print() to monitor the usage of net_buf
void _net_pkt_print(void)
{
	printk("[%u] TX %4u(%p) RX %4u(%p) TXBUF %4u RXBUF %4u\r",
	        k_uptime_get_32(),
		k_mem_slab_num_free_get(&tx_pkts), tx_pkts.free_list,
		k_mem_slab_num_free_get(&rx_pkts), rx_pkts.free_list,
		atomic_get(&tx_bufs.avail_count),
		atomic_get(&rx_bufs.avail_count));
}

In my test described above, net_pkt count was set to 1024 and net_buf count was set to 4096 which is a large value. To verify whether there is something wrong with net_buf allocation/free, I reduced net_buf count on purpose:
CONFIG_NET_PKT_RX_COUNT=1024
CONFIG_NET_PKT_TX_COUNT=1024
CONFIG_NET_BUF_RX_COUNT=1024
CONFIG_NET_BUF_TX_COUNT=1024

The net_buf count was 1024 when system started:
[17909] TX  978(0x80107b30) RX 1024(0x800f7318) TXBUF 1024 RXBUF 1024
Then with 32 TCP connections sending data to Zephyr, Data buffer (%zd) allocation failed was frequently dumped.  After several times of TCP connecting/disconnecting, transmit net_buf count cannot restore to its original value:
[333486] TX  933(0x80104f08) RX 1024(0x800f28d8) TXBUF  831 RXBUF 1024
I think I should first solve the problem of lost net_buf.

@jhedberg we would need spinlock in order to support SMP. Either global for all net_bufs or one per net_buf, which would consume more space than atomic.

@mniestroj ok, in that case we're probably better off with moving to atomic_t. I think we should at the same time consider changing the behaviour of net_buf_ref() so that it returns NULL if you give it a 0 reference count, similar to what we did with bt_conn:
https://github.com/zephyrproject-rtos/zephyr/blob/b182ec78a16670f21c87ee7a33c2910f413f67db/subsys/bluetooth/host/conn.c#L1864-L1899
We could even consider creating a k_ref abstraction around atomic_t to make refcount implementation simpler (and harder to do wrong). Linux has something like this in the form of struct kref and refcount_t

k_ref abstraction seems a good idea. Recently I needed to add refcounting to drivers/wifi/esp/ to manage sockets lifetime, which could benefit from k_ref as well.

I think we should at the same time consider changing the behaviour of net_buf_ref() so that it returns NULL if you give it a 0 reference count

I am not sure this brings much benefit to net_buf_ref(). If you had a net_buf and somebody already decreased refcount to 0, then this net_buf landed in net_buf_pool. Assuming that it is still in the pool, adding check on 0 refcount in net_buf_ref() makes sense. But it is possible that such net_buf was already allocated once again, so effectively net_buf_ref() caller references new net_buf object (which is placed in the same memory, but still it is something different than desired). This means that we should not call net_buf_ref() on something that might be already dereferenced. In other words, caller is responsible for making sure net_buf_ref() is called only on buffers with refcount > 0.

Have you tried just make this a uint32_t and testing that.  That might convey if its a memory or atomic issue.

Have you tried just make this a uint32_t and testing that. That might convey if its a memory or atomic issue.

Changing type of net_buf ref form uint8_t to atomic_t finally did not prevent my system from crashing, so I did not try uint32_t.
The zephyr master branch solves some race condition problems after v2.5 release, so I changed to use master branch code. The system crashed with ARM hard fault as following:
E: ***** USAGE FAULT *****
E:   Illegal use of the EPSR
E: r0/a1:  0x1f9650b4  r1/a2:  0x00000000  r2/a3:  0x00000000
E: r3/a4:  0x00000000 r12/ip:  0xa0000000 r14/lr:  0x80006917
E:  xpsr:  0x00000000
E: r4/v1:  0x8011105c  r5/v2:  0x00000000  r6/v3:  0x00002710
E: r7/v4:  0x80110728  r8/v5:  0x00000500  r9/v6:  0x00000000
E: r10/v7: 0x00000006  r11/v8: 0x80021798    psp:  0x800c8740
E: EXC_RETURN: 0xfffffffd
E: Faulting instruction address (r15/pc): 0x8002164c
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Current thread: 0x800233a0 (tcps_25)
E: Halting system

The faulting instruction address locates to a non-text area, it seems to be a stack problem, but I have set all threads' stack size to 8192, also with CONFIG_HW_STACK_PROTECTION=y. It is hard to see what happened before this ARM hard fault. What I am doing now is to use ARM MPU (Memory Protection Unit) to set non-text area to non-executable, so I can know at what point the PC register is changing to an illegal address.

@andrewboie @jukkar @chyu313
Looks like this issue relate to #27032 and might be solved in https://github.com/zephyrproject-rtos/zephyr/commit/dde03c67709a0ed4b84d4892ca05361716b75c80 ?

@andrewboie @jukkar @chyu313
Looks like this issue relate to #27032 and might be solved in dde03c6

It seems there are also more protections needed in kernel.
I tested dde03c6 (without modification to protect net_buf) and MPU fault occurred:
E: ***** MPU FAULT *****
E:   Data Access Violation
E:   MMFAR Address: 0x0
E: r0/a1:  0x80026260  r1/a2:  0x00000000  r2/a3:  0x00000000
E: r3/a4:  0x00000000 r12/ip:  0x80020850 r14/lr:  0x8001b2cf
E:  xpsr:  0x210000a8
E: r4/v1:  0x80026260  r5/v2:  0x00000000  r6/v3:  0x00000000
E: r7/v4:  0x00000010  r8/v5:  0x00000010  r9/v6:  0x80020850
E: r10/v7: 0x00000000  r11/v8: 0x00000000    psp:  0x8028df80
E: EXC_RETURN: 0xfffffff1
E: Faulting instruction address (r15/pc): 0x8001b2bc
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Fault during interrupt handling

E: Current thread: 0x80026260 (rx_q[0])
E: Halting system

To avoid NULL pointer access, I use MPU to set ARM address 0x0 (located in ITCM which is not used in my program) as no-access attribute, so that NULL pointer access to 0 will cause MPU FAULT.
The faulting instruction address 0x8001b2bc is located in sys_dlist_remove() which is called by unpend_thread_no_timeout(). The NULL pointer in sys_dlist_remove() is 'prev' which is compiled into r2 (value is 0 when MPU fault).
The comment of sys_dlist_remove() says: "This and other sys_dlist_*() functions are not thread safe."
8001b2b8 <sys_dlist_remove>:
	sys_dnode_t *const next = node->next;
8001b2b8:	e9d0 3200 	ldrd	r3, r2, [r0]
	prev->next = next;
8001b2bc:	6013      	str	r3, [r2, #0]
	next->prev = prev;
8001b2be:	605a      	str	r2, [r3, #4]
	node->next = NULL;
8001b2c0:	2300      	movs	r3, #0
	node->prev = NULL;
8001b2c2:	e9c0 3300 	strd	r3, r3, [r0]
	sys_dnode_init(node);
}
8001b2c6:	4770      	bx	lr

8001b2c8 <unpend_thread_no_timeout>:
{
8001b2c8:	b508      	push	{r3, lr}
	sys_dlist_remove(&thread->base.qnode_dlist);
8001b2ca:	f7ff fff5 	bl	8001b2b8 <sys_dlist_remove>
	thread->base.thread_state &= ~_THREAD_PENDING;
8001b2ce:	7b43      	ldrb	r3, [r0, #13]
8001b2d0:	f023 0302 	bic.w	r3, r3, #2
8001b2d4:	7343      	strb	r3, [r0, #13]
	thread->base.pended_on = NULL;
8001b2d6:	2300      	movs	r3, #0
8001b2d8:	6083      	str	r3, [r0, #8]
}
8001b2da:	bd08      	pop	{r3, pc}

@chyu313 can you confirm this is still an issue in current main?

@chyu313 can you confirm this is still an issue in current main?

Yes, it still an issue. I keep pulling Zephyr code and testing it. Fault still occurs.

I created a PR that implements k_ref: https://github.com/zephyrproject-rtos/zephyr/pull/64798


Timeout attempting to update creds

I have configured my ECR registry in Rancher and can successfully pull from it.
However the ECR updater just times out ...
14/12/2016 18:23:46Updating ECR Credentials
14/12/2016 18:25:47Error updating ECR, RequestError: send request failed
14/12/2016 18:25:47caused by: Post https://ecr.eu-west-1.amazonaws.com/: dial tcp <IP_ADDRESS>:443: i/o timeout

I configured via the catalogue and entered the required variables for ACCESS_KEY, SECRET_KEY and AWS_REGION (eu-west-1).
If I SSH to the instance that is running the container I can succesfully call
$ aws ecr get-login --region eu-west-1
docker login -u AWS -p AQECAHh+dS+BlNu0NxnXwowbILs115yjd+LNAZhBLZsunOxk3AAAAxkwggMVBgkqhkiG9w0BBwagggM.... -e none https://XXXXXXXXXXXX.dkr.ecr.eu-west-1.amazonaws.com

If I curl to https://ecr.eu-west-1.amazonaws.com I can see that is can get out to the endpoint ...
$ curl https://ecr.eu-west-1.amazonaws.com
<MissingAuthenticationTokenException>
  <Message>Missing Authentication Token</Message>
</MissingAuthenticationTokenException>

What could be wrong here ?
Kind Regards
Fraser

I'm assuming that the URL that the credentials updater is trying to hit is correct, i.e.
https://ecr.eu-west-1.amazonaws.com
shouldn't be ...
https://dkr.ecr.eu-west-1.amazonaws.com
or even .....
https://123456789012.dkr.ecr.eu-west-1.amazonaws.com

it appears that the container isn't able to reach out to the internet to call the AWS API. the https://ecr.eu-west-1.amazonaws.com URL is the URL for the ECR API, so it's coming from the AWS client itself.
I just pushed a new image version tagged latest that's using the latest release for the AWS sdk. Could you try that?

Hey John,
just got back to this one. Tried the latest image but unfortunately the same result.
I also ran outside of Rancher altogether following your docs but again the log contained ..
docker logs -f ecstatic_austin
Updating ECR Credentials
Error updating ECR, RequestError: send request failed
caused by: Post https://ecr.eu-west-1.amazonaws.com/: dial tcp <IP_ADDRESS>:443: i/o timeout

and if if do ....
curl https://ecr.eu-west-1.amazonaws.com

<MissingAuthenticationTokenException>
  <Message>Missing Authentication Token</Message>
</MissingAuthenticationTokenException>

I assume the values passed to the container sort that out, and in any event, the curl returns immediately whereas the container waits for the HTTP request timeout.
I made sure that the local ec2-user account and root account both had a credentials file under .aws containing the aws_access_key_id and aws_secret_access_key properties.
I can successfully push and pull from the host to/from ECR repositories.
Not sure where else to look ??

Can you possibly try a different region?

I just tried this locally:
$ docker run -e CATTLE_URL=####### -e CATTLE_ACCESS_KEY=#### -e CATTLE_SECRET_KEY=#### -e AWS_ACCESS_KEY_ID=###### -e AWS_SECRET_ACCESS_KEY=#### -e AWS_REGION=eu-west-1 objectpartners/rancher-ecr-credentials

and that appears to work fine:
Updating ECR Credentials
Returned from AWS GetAuthorizationToken call successfully
Looking for configured registry for host ######.dkr.ecr.eu-west-1.amazonaws.com
Successfully updated credentials 1c2292 for registry 1sp181; registry address: #######.dkr.ecr.eu-west-1.amazonaws.com

The error seem to indicate that you cannot request externally from where you are running.

I used exactly that command too.
I agree it appears that the endpoint seems unreachable from within the container, although I don't understand how it is that I can access ECR without problem with a direct docker pull, and even curl shows that the endpoint is reached. That's still hitting the same HTTP endpoint isn't it ?
Could it be proxy settings inside the container ?
For the CATTLE_ACCESS_KEY I used a global API one, is that correct ?

No, you should use an Environment API key since registries are linked to environments.
If you use a global key, then CATTLE_URL is required to be the path to a specific environment (e.g. http://rancher.company.com:8080/v1/project/1a15)

There are no proxy settings in the container. There's many things that could be problematic here, but it's pretty evident that it's a configure on your systems and not the container image itself (since the same image is run effectively on many, many systems).
Are you trying to do this on your local development machine? What OS are you running? (if it's Mac are you using Docker for Mac or the old Boot2Docker)? If this is a deployed machine, what's the OS? How is Docker installed on that machine? What version of Docker?

Ok, makes sense it's an Env level access key, I'll change that and try again.
Yes I'm sure you are right that it's specific to my set up. Here are the details ..
RHEL 7.3
AWS
Docker 1.12.5
docker-compose 1.9.0
Rancher v1.3.0
Docker is installed as part of our packer AMI build for docker, it's a build process we have been using for more than 12 months successfully. ECR is new to us though, previously we just used our own private registry using the standard docker registry image, backed by S3, and that has actually been pretty rock solid, but company policy has changed so ECR it is !
I also have the Amazon ecr-credentials-helper binary installed which removes the need to generate the ECR login password or call docker login when SSH'd locally (albeit that is not encouraged), and that works perfectly in the sense that I have never had to generate a new password for any docker pull from ECR. See here:
https://aws.amazon.com/blogs/compute/authenticating-amazon-ecr-repositories-for-docker-cli-with-credential-helper/
These instances do have some significant hardening. They are based form the Amazon CIS image for RHEL and we apply additional security software, in our case Trend Deep Security Agent which covers off IPS and AV amongst other things. This has caused a few issues for us in other network use cases but it's hard to see how it could play any part here TBH.
Don't know if any of that shines a light on something obvious ?
Thanks for your continued help
Fraser.

Tried with Env API values. No change.
This is what a simple curl looks like ?
$ curl -v https://ecr.eu-west-1.amazonaws.com

About to connect() to proxy management-proxy.nonprod.management.aws-euw1-services.com port 80 (#0)

Trying <IP_ADDRESS>...

Connected to management-proxy.nonprod.management.aws-euw1-services.com (<IP_ADDRESS>) port 80 (#0)

Establish HTTP proxy tunnel to ecr.eu-west-1.amazonaws.com:443

CONNECT ecr.eu-west-1.amazonaws.com:443 HTTP/1.1
Host: ecr.eu-west-1.amazonaws.com:443
User-Agent: curl/7.29.0
Proxy-Connection: Keep-Alive

< HTTP/1.1 200 Connection established
<

Proxy replied OK to CONNECT request
Initializing NSS with certpath: sql:/etc/pki/nssdb
CAfile: /etc/pki/tls/certs/ca-bundle.crt

CApath: none

SSL connection using TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384

Server certificate:

  subject: CN=ecr.eu-west-1.amazonaws.com,O="Amazon.com, Inc.",L=Seattle,ST=Washington,C=US

  start date: Dec 28 00:00:00 2016 GMT

  expire date: Jan 26 23:59:59 2018 GMT

  common name: ecr.eu-west-1.amazonaws.com

  issuer: CN=Symantec Class 3 Secure Server CA - G4,OU=Symantec Trust Network,O=Symantec Corporation,C=US

GET / HTTP/1.1

User-Agent: curl/7.29.0

Host: ecr.eu-west-1.amazonaws.com

Accept: />

< HTTP/1.1 403 Forbidden
< Server: Server
< Date: Thu, 12 Jan 2017 23:56:47 GMT
< Content-Type: null
< Content-Length: 127
< Connection: keep-alive
< x-amzn-RequestId: c74d0e88-d922-11e6-ab18-998ca4caa771<

Missing Authentication Token

I would try running that curl command from within the ecr-credential container or any docker container for that matter.
docker exec -it <ecr-credential-updater container id> /bin/bash and then run your curl command.
It appears that your system is using a HTTP proxy to establish outgoing connections. I suspect this information needs to be configured inside the docker container as well. You can use the HTTP_PROXY envvar as defined here to configure the HTTP proxy settings - https://golang.org/pkg/net/http/#ProxyFromEnvironment

Hey John,
If I set my host's http_proxy, https_proxy and no_proxy values inside the container everything appears to work nicely.
Do you think you could provide an updated image that would allow me to pass those as environment variables with docker run ? .... unless you know another way of injecting them in at launch time ?

Have you tried setting the HTTP_PROXY envvar on the container with the appropriate information?
I linked to the documents in my previous comment. That will propagate to the program itself.
The great thing of Docker is that you can use this as a starting point and add your own customizations. I'm not going to including customized behavior in this image.


Add initial components

Re-uploading this PR after a failed rebase.
No routing yet, the buttons don't do anything for the moment.
Changed the styling of the main page to use css grid, this may need to be changed with the collapsible  sidebar.

CSS grid will work for the collapsible sidebar don't worry, its just changing grid columns!

Looks good to me, for initial components this seems to cover all of the bases.
The only thing I would say is that, once we start using a framework for component styling, we shouldn't need much CSS. In my (limited) experience I've been told to only use CSS if you cannot get something to display correctly - otherwise the framework should be used.
I appreciate the CSS is here now to give the page a bit of structure.

By this do you mean specifically the layout, so we don't have to specify how containers respond, or the specific styling such as colours/margins?
I guess we don't really have UX here telling us specific colours or pixel widths to use, so working with a framework is maybe our best bet,  though I've not used many myself.
Perhaps an alternative would be to create several base classes, or mixins, which would style all the buttons, or divs, a certain way across our app, applying specific css properties we want to evey instance.

Looks good to me, for initial components this seems to cover all of the bases.
The only thing I would say is that, once we start using a framework for component styling, we shouldn't need much CSS. In my (limited) experience I've been told to only use CSS if you cannot get something to display correctly - otherwise the framework should be used.
I appreciate the CSS is here now to give the page a bit of structure.

By this do you mean specifically the layout, so we don't have to specify how containers respond, or the specific styling such as colours/margins?
I guess we don't really have UX here telling us specific colours or pixel widths to use, so working with a framework is maybe our best bet, though I've not used many myself.
Perhaps an alternative would be to create several base classes, or mixins, which would style all the buttons, or divs, a certain way across our app, applying specific css properties we want to evey instance.

I think a bit of both, and also by using a framework (or creating our own styled components) it allows better levels of abstraction in a component. Basically it allows a component to make this transformation (Image credit):


Improve statistics/counters in the LSU

We only have one counter -- tlb_hits.   Need more .. a lot more!
@arupc can you add a bunch?

Some sample LSU stats:
dcache_hits/misses
tlb_hits/misses
occupany of fill buffers
hit on fills

Added additional stats via https://github.com/riscv-software-src/riscv-perf-model/pull/30
Some proposed stats such as occupancy of fill buffers, hit on fills requires a cache model, which is not present at the moment. I will add these stats to the appropriate issue.


HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters.

What changes were proposed in this pull request?
This PR adds a new API in Recon for listing keys for OBS buckets, Legacy buckets with filters and recursively in a flat structure for FSO buckets.
New API:
api/v1/namespace/listKeys?startPrefix=/volume1/obs-bucket/&count=105
Default values of API parameters if not provided:
1. replicationType - RATIS
2. creationTime - empty string and filter will not be applied, so list out keys irrespective of age, else list out keys which got created on or after provided creationTime
3. keySize - 0 bytes, which means all keys greater than zero bytes will be listed, effectively all.
4. startPrefix - /
5. count - 1000

Behavior of API:
For OBS bucket - list out count number of keys on the provided path.
This API will implement pagination support using count  params.
Get List of All Keys:
GET /api/v1/namespace/listKeys
 API params:
  1. replicationType
  2. creationTime in "MM-dd-yyyy HH:mm:ss" string format.
  3.
Added Junit test cases and tested various assertions.

replicationType - RATIS
creationTime - empty string and filter will not be applied, so list out keys irrespective of age, else list out keys which got created on or after provided creationTime
keySize - 0 bytes, which means all keys greater than zero bytes will be listed, effectively all.
startPrefix - /

I think default replication types should be all of them. This is consistent with the key size and create time filters which have no effect if no value is provided.

count - 1000
...
This API will implement pagination support using count params.

How can we make sure the user knows the value is truncated and that there is not only 1000 keys in the prefix?
How is pagination implemented to tell the server where the next 1000 keys should start?

replicationType - RATIS
creationTime - empty string and filter will not be applied, so list out keys irrespective of age, else list out keys which got created on or after provided creationTime
keySize - 0 bytes, which means all keys greater than zero bytes will be listed, effectively all.
startPrefix - /

I think default replication types should be all of them. This is consistent with the key size and create time filters which have no effect if no value is provided.

count - 1000
...
This API will implement pagination support using count params.

How can we make sure the user knows the value is truncated and that there is not only 1000 keys in the prefix?
How is pagination implemented to tell the server where the next 1000 keys should start?

Agree, ReplicationType default value can be empty, so listing effectively all.
Thinking of providing total count based on filters provided in response, which tells how many keys in the prefix.
Still not decided the solution, but I was thinking to provide one more param -> offset. So e.g. if client provides offset as 0 and count as 10, then server will give first 10 records. And if client provides offset as 100 and count as 50, then server will skip first 100 records and provides next 50 records.

I think just providing the last key in the list as a start key might be easier to resume pagination from than adding a count based offset.

Since this endpoint /listKeys is part of the various NSSummaryEndpoints, can we introduce an integration test for the endpoint as well? We currently do not have one, and in our discussions, we had decided to add one in the future. For now, we can just test out the ListKeys feature. We could test it out for various bucket types, with various hierarchies and also test out the pagination part as well. The other methods part of NSSummaryEndpoint could be included in subsequent jira's later on.

Ok, sure will add integration test.


feature:document support multiple version

What's the purpose of this PR
document support multiple version
Which issue(s) this PR fixes:
Fixes #4327

Codecov Report

Merging #4452 (83ecca9) into master (804ffae) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4452      +/-   ##
============================================
+ Coverage     53.38%   53.53%   +0.15%
- Complexity     2688     2691       +3
============================================
  Files           490      488       -2
  Lines         15252    15229      -23
  Branches       1586     1587       +1
============================================
+ Hits           8142     8153      +11
+ Misses         6553     6518      -35
- Partials        557      558       +1

Impacted Files
Coverage Δ

...k/apollo/portal/controller/ConsumerController.java
10.52% <0.00%> (-0.91%)
:arrow_down:

...ork/apollo/common/customize/LoggingCustomizer.java

...ork/apollo/biz/customize/BizLoggingCustomizer.java

...m/ctrip/framework/apollo/biz/config/BizConfig.java
26.78% <0.00%> (+0.92%)
:arrow_up:

...mework/apollo/openapi/service/ConsumerService.java
58.46% <0.00%> (+3.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov.  Read the comment docs.

What kind of version style do you want？
@nobodyiam

Currently, apolloconfig.com refers to the latest version of the docs folder.
By supporting multiple versions of documentation, users could switch to different versions of the docs folder, e.g. when user chooses 1.9.2, then it should refer to the 1.9.2 tag.
I'm not sure how that could be achieved, but it should behave like this way.

Maybe we need to create version folder in docs and to put different versions of the files in the corresponding version folder.

@Anilople

Maybe we need to create version folder in docs and to put different versions of the files in the corresponding version folder. @nobodyiam

Currently, this seems the way to go. @Anilople do you have any suggestions?

That will consume large cost to maintain it.
Reference to different tag seems better.
Can we combine them together? i.e generate the version folder during CI rather than commit them to the git repo directly.

generate the version folder during CI rather than commit them to the git repo directly.

It will be best to do so during CI as this is the most consistent way.
If we can't do so during CI, then we need to add a step to copy the docs to a version folder when releasing a new version.

It will be best to do so during CI as this is the most consistent way. If we can't do so during CI, then we need to add a step to copy the docs to a version folder when releasing a new version.

What should I do if we generate the version folder during CI? i don't kown how to do that

There is a proposal in docsify that apollo uses to render the sites: https://github.com/docsifyjs/docsify/issues/1289.
However, there doesn't seem to be any progress...


To Review: Crop and TextureCrop GameObject Components

Currently these 2 components exist:

Phaser.GameObjects.Components.TextureCrop (for texture based objects ie. Sprite, Image, Particle, Video)
Phaser.GameObjects.Components.Crop (for non texture objects ie. Text and TileSprite)

Both components have identical functions with TextureCrop having additional setTexture and setFrame methods.
Do we still need to have separate components or can it be merged into a single component in future releases?

I looked at this the other day while going through the docs because there are several duplicated functions between these two mixins. This can't become one single component. What it could maybe do is become 'Crop', and then you add a second component for the 'Texture' side of it. Which is still two components, but it would eliminate a little bit of duplicate code.
Given the restructure we'll do for Phaser v4 I don't think it's worth changing this at this late stage.


ModuleNotFoundError: No module named 'tables'

I am currently having difficulty importing CCAL. When I try to open import ccal in a gene pattern nb, I get the error ModuleNotFoundError: No module named 'tables'
The full error message is below. What should I do?
CCAL version 0.6.25 @ /home/jovyan/ccal/ccal/init.py
ModuleNotFoundError                       Traceback (most recent call last)
 in
1 import sys
2 sys.path.insert(0, '/home/jovyan/')
----> 3 import ccal.ccal as ccal
~/ccal/ccal/init.py in
8 from .nmf_map.nmf_map.access_nmf_map import dump_nmf_map
9 from .nmf_map.nmf_map.access_nmf_map import load_nmf_map
---> 10 from .variant.variant.VariantHDF5 import VariantHDF5
11 from .variant.variant.access_maf import split_maf_by_tumor_sample_barcode
12 from .variant.variant.access_maf import make_maf_from_vcf
~/ccal/ccal/variant/variant/VariantHDF5.py in
4 from warnings import warn
5
----> 6 from tables import (Filters, Float32Col, HDF5ExtError, Int32Col, IsDescription,
7                     StringCol, open_file)
8
ModuleNotFoundError: No module named 'tables'

Try pip isntall pytables

Try pip isntall pytables

pip install pytables
isn't working, I'm getting the following error in my terminal:
Could not find a version that satisfies the requirement pytables (from versions: )
No matching distribution found for pytables
When I do
"conda install pytables"
the command  goes through but then I still get the original error (ModuleNotFoundError: No module named 'tables') when I attempt to import ccal.
I never had this  problem before - has something  changed on the ccal side?

You may have issue in your environment. Could you try following the instructions here (up to configuring vi) to re-create an environment?

I tried the instructions under
"Install jupyter extension"
at https://github.com/KwatME/environment/blob/master/configure_environment.md
because I am using GenePattern NBs. Here was the output:
jovyan@3a147c448deb:~$ jupyter nbextension install --user https://github.com/drillan/jupyter-black/archive/master.zip &&

jupyter nbextension enable jupyter-black-master/jupyter-black &&
jupyter nbextension install --user https://github.com/lambdalisue/jupyter-vim-binding/archive/master.zip &&
jupyter nbextension enable jupyter-vim-binding-master/vim_binding &&
jupyter nbextension list
Downloading: https://github.com/drillan/jupyter-black/archive/master.zip -> /tmp/tmp2mdojph2/master.zip
Extracting: /tmp/tmp2mdojph2/master.zip -> /home/jovyan/.local/share/jupyter/nbextensions
Enabling notebook extension jupyter-black-master/jupyter-black...
Traceback (most recent call last):
File "/opt/conda/bin/jupyter-nbextension", line 11, in
sys.exit(main())
File "/opt/conda/lib/python3.6/site-packages/jupyter_core/application.py", line 266, in launch_instance
return super(JupyterApp, cls).launch_instance(argv=argv, **kwargs)
File "/opt/conda/lib/python3.6/site-packages/traitlets/config/application.py", line 658, in launch_instance
app.start()
File "/opt/conda/lib/python3.6/site-packages/notebook/nbextensions.py", line 988, in start
super(NBExtensionApp, self).start()
File "/opt/conda/lib/python3.6/site-packages/jupyter_core/application.py", line 255, in start
self.subapp.start()
File "/opt/conda/lib/python3.6/site-packages/notebook/nbextensions.py", line 898, in start
self.toggle_nbextension(self.extra_args[0])
File "/opt/conda/lib/python3.6/site-packages/notebook/nbextensions.py", line 888, in toggle_nbextension
logger=self.log)
File "/opt/conda/lib/python3.6/site-packages/notebook/nbextensions.py", line 413, in enable_nbextension
logger=logger)
File "/opt/conda/lib/python3.6/site-packages/notebook/nbextensions.py", line 351, in _set_nbextension_state
cm.update(section, {"load_extensions": {require: state}})
File "/opt/conda/lib/python3.6/site-packages/notebook/config_manager.py", line 136, in update
self.set(section_name, data)
File "/opt/conda/lib/python3.6/site-packages/notebook/config_manager.py", line 123, in set
f = io.open(filename, 'w', encoding='utf-8')
PermissionError: [Errno 13] Permission denied: '/home/jovyan/.jupyter/nbconfig/notebook.json'

Unfortunately, my problems remains even after doing this.
What would you recommend doing?

You don't have to install the extension. You just need to make it up to vi part.
I would try out ccal once more. pip uninstall ccal and then pip install ccal.  If it still does not work, then I would contact people at gene pattern server because the server might have some restrictions.
Best,

@xaviergonzalez I recommend that you give
 pip install --user ccal
a try. The PermissionError tells me that you are trying to modify files which users don't have root/write access to. However, by passing the --user flag to pip, it knows to modify only local files. I tried this on a dummy account and worked for me (the installation worked, haven't done any tests).
Let us know if that helps!
Edwin.

Never mind!
I finally got the code to work by importing some packages and changing my import line from
import ccal.ccal as ccal
to
import ccal
Thank you so much for all of your help!!


Add typescript support

Taking over https://github.com/project-serum/anchor/pull/537 since it has conflicts and not much movement.
Let me know what needs to be done to get this through

Can you give me push access to your repo/branch so that we can get this in more quickly?

Can you give me push access to your repo/branch so that we can get this in more quickly?

Done. Sorry, this is a pretty rushed merge as we're doing the beta monday

Can you give me push access to your repo/branch so that we can get this in more quickly?

Done. Sorry, this is a pretty rushed merge as we're doing the beta monday

Still don't have push access.

Note to self: two things to check

bare bones anchor init project
hypenated-workspace

Why anchor build does not generate type file in target/types? I accidentally anchor clean


LIFX Color Bulbs Do Not Adapt

Describe The Bug:

LIFX Color Bulbs on 3.70 firmware so not appear to adapt with adaptive lighting enabled on 0.2.2
To Reproduce:

Compare color of LIFX Color bulbs with adaptive lighting enabled in Home App with LIFX Mini White to Warm on 3.60 and note that the LIFX Mini White to Warm change to a warm color in the evening hours while the LIFX Color bulbs do not.
Expected behavior:

Both LIFX Mini White to Warm and LIFX Color bulbs adapt equally and to the same color tone at the same time of day.
Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version: 0.2.2
Homebridge Version: 1.4.0
Node.js Version: 16.14.0
NPM Version: 8.3.1
Operating System: Debian

The problematic bulbs are these:
LIFX Mini 800-Lumen LED Light Bulb (L3A19MC08E26) Multi Colored
How do I check Kelvin support?

I assume this is what you mean. All three show the Whites tab with K color in Lifx app. Notice how all three are set to different colors at a given point in time. Second Floor Sconce and Desk Lamp are Mini White to Warm. The Nightstand is a Mini Color and is skewed way towards the cooler side of the spectrum and doesn’t appear to change much at all throughout the day.

Here is the problematic bulb type again about 30 minutes after sunset. It’s still very cool (too cool in my opinion) compares to the other bulbs.

Unfortunately, the original app does little for me.
I mean from the HomeKit app. A screenshot of this would already help me a lot:

Do you notice any improvement with the latest version v0.2.4?


Multiple node fields resolve to the same GraphQL field

After Updating the Dependencies I got this Below While Error Build or develop the Site
$ gatsby build

success open and validate gatsby-configs — 0.040 s
success load plugins — 0.351 s
success onPreInit — 1.294 s
success delete html and css files from previous builds — 0.191 s
info One or more of your plugins have changed since the last time you ran Gatsby. As
a precaution, we're deleting your site's cache to ensure there's not any stale
data
success initialize cache — 0.131 s
success copy gatsby files — 0.018 s
success onPreBootstrap — 0.007 s
⠁ Fetching AccountInfo
⢀ source and transform nodesFetching Configuration
⢀ source and transform nodesFetching accountFavoriteMovies
Fetching accountMovieWatchlist
Fetching accountFavoriteTv
Fetching accountTvWatchlist
Fetching accountLists
Downloading remote files [==============================] 51/51 11.8 secs 100%
Downloading remote files [==============================] 73/73 24.9 secs 100%
success source and transform nodes — 31.067 s
warning Multiple node fields resolve to the same GraphQL field `poster_path` - [`poster_path`, `poster_path___NODE`]. Gatsby will use `poster_path___NODE`.
warning Multiple node fields resolve to the same GraphQL field `poster_path` - [`poster_path`, `poster_path___NODE`]. Gatsby will use `poster_path___NODE`.
warning Multiple node fields resolve to the same GraphQL field `poster_path` - [`poster_path`, `poster_path___NODE`]. Gatsby will use `poster_path___NODE`.
warning Multiple node fields resolve to the same GraphQL field `poster_path` - [`poster_path`, `poster_path___NODE`]. Gatsby will use `poster_path___NODE`.
warning Multiple node fields resolve to the same GraphQL field `poster_path` - [`poster_path`, `poster_path___NODE`]. Gatsby will use `poster_path___NODE`.
success building schema — 0.600 s
success createPages — 0.097 s
success createPagesStatefully — 0.110 s
success onPreExtractQueries — 0.003 s
success update schema — 0.034 s
success extract queries from components — 0.204 s
Generating image thumbnails [==============================] 7/7 2.2 secs 100%
success run graphql queries — 5.805 s — 6/6 1.03 queries/second
success write out page data — 0.005 s
success write out redirect data — 0.001 s
Generating image thumbnails [==============================] 17/17 5.8 secs 100%
success onPostBootstrap — 0.005 s

info bootstrap finished - 46.13 s

success Building production JavaScript and CSS bundles — 17.761 s
success Building static HTML for pages — 2.880 s — 5/5 4.70 pages/second
Generated public/sw.js, which will precache 12 files, totaling 281406 bytes.
info Done building in 67.451 sec

Fixes with v2 of https://github.com/LekoArts/gatsby-source-tmdb


[13] [UI] Create NFC scanning screen

#13
What happened 👀
After the scanning of the MRZ information from the passport information page or manual input, the user navigates to this screen to press the back of the phone against the passport NFC chip to read the NFC data.
Insight 📝

Created NfcScanningActivity and activity_nfc_scanning.xml
Created dimens.xml

Proof Of Work 📹
Note: PoW was captured with a button at the bottom of the screen to toggle between loading and loaded states, it does not exist in final code
https://user-images.githubusercontent.com/53168251/179935061-fdbf3830-9095-46f1-9f00-1b22c7456469.mp4

I think we need to add one more for Signature image too.

1 more idea - how about we add another ImageView at the bottom of all the labels to show the fingerprint image? I've updated the issue accordingly.

I think we need to add one more for Signature image too.

@AVI5HEK @lydiasama How about having all the images together at the top of the screen? What do you think? 🤔

@AVI5HEK @lydiasama How about having all the images together at the top of the screen? What do you think? 🤔

@ryan-conway @AVI5HEK It's a new idea. 👍🏻  I haven't thought about that before. 😂
Yes, we can.  However, do we have a designer role? Then we will follow @AVI5HEK 's decision. 😂

@AVI5HEK @lydiasama How about having all the images together at the top of the screen? What do you think? 🤔

@ryan-conway the suggested design looks nice. Also, think about the cases when we can't extract the images from the passport. Some passports don't have the signature and/or fingerprint. In such cases, we can do either of the following:

Hide the image (easier IMO)
Use placeholder

@ryan-conway the suggested design looks nice. Also, think about the cases when we can't extract the images from the passport. Some passports don't have the signature and/or fingerprint. In such cases, we can do either of the following:

Hide the image (easier IMO)
Use placeholder

@AVI5HEK The plan was to hide the images, that's why the xml has additional groups in it for each imageview-textview pair :smile:


Lab 06: Implement Directory Synchronization

Module: AZ-500
Lab/Demo: Lab-06
Task: Task 2: Use an ARM template to deploy an Azure VM hosting an Active Directory domain controller
Step: 05
Description of issue
Populating 'DNS Prefix', that is a mandatory parameter, seems to be missing in the instructions

Repro steps:

Task 1 Step 4 helps us to find the DNS prefix value.
Test-AzDnsAvailability -DomainNameLabel  -Location ''

Step 4 states the following:

Setting
Value

Subscription
the name of you Azure subscription

Resource group
click Create new and type the name AZ500LAB06

**Dns Prefix
the DNS hostname you identified in the previous task**

Location
the Azure region you identified in the previous task

Admin Username
Student

Admin Password
Pa55w.rd1234

Domain Name
adatum.com

VM Size
Standard_D2s_v3

rgds

Marcin


[ODS-5192] Record Ownership Phase 2 - Add data migration script

In its current form this looks good and is working. Will need to re-review once other feature work is done related to this on other PRs.


logstream errors abort all tests

/area API
/area test-and-release
/kind bug
/kind cleanup
If you look at this continuous build, you will see that every single failure (that I clicked through) failed with the following:
kubelogs.go:236: Error during logstream error container "autoscaler-hpa" in pod "autoscaler-hpa-8c5988c8d-shw6x" is terminated

This is because once k.err is set here every single "cancel" function we return will error here.  I believe this is similarly true for tests that hadn't even started when the pod was killed!
Given that this is purely diagnostic, I'm going to suggest that we bias heavily towards t.Log for this sort of error instead of using t.Error because it's entirely plausible that there's nothing really wrong.
cc @markusthoemmes @vagababov @dprotaso for thoughts

ack!
/assign
(unless you wanted to PR it)


Failed to locate opened application window with appId

I have an application i wish to open. This application has a splash screen that runs for approx 3-5 seconds. Then causes the process to temporarily stop responding and then continues to the login screen. This is all done on the same process Id and does not change.
This is the body of the request i am sending at start up
"{"desiredCapabilities":{"app":"{PATH TO EXE GOES HERE}","platformName":"windows","deviceName":"WindowsPC"},"capabilities":{"firstMatch":""},"session id":null}"
The issue is the app launches no problem, but the response from the request says that it fails to locate the application window.
I cannot put in a sleep because this is all happening on the request call through the HttpClient. My timeout is 60 seconds so i can't be that.
Thoughts?

Use the ms:waitForAppLaunch capability to delay the session from starting after app launch. This requires WinAppDriver 1.2.
I also found it useful to explicitly set the ms:experimental-webdriver to false to fend off odd behavior.
AppiumOptions options = new AppiumOptions();
options.AddAdditionalCapability("app", AppPath);
options .AddAdditionalCapability("ms:waitForAppLaunch", $"{SecondsToWaitOnOpen}");
options .AddAdditionalCapability("ms:experimental-webdriver", false);
session = new WindowsDriver<WindowsElement>(WindowsApplicationDriverUrl, options);

I have the same issue.
DesiredCapabilities desiredCapabilities = new DesiredCapabilities();
desiredCapabilities.setCapability("deviceName", "WindowsPC");
// https://github.com/microsoft/WinAppDriver/issues/1092
desiredCapabilities.setCapability("ms:waitForAppLaunch", "8");
desiredCapabilities.setCapability("ms:experimental-webdriver", false);
WindowsDriver<WindowsElement> windowsDriver = new WindowsDriver<>(winappServerUrl, desiredCapabilities);
return windowsDriver;

The application (calc.exe) opens, but the WebDriver is not created.
org.openqa.selenium.SessionNotCreatedException: Unable to create a new remote session. Please check the server log for more details. Original error: Failed to locate opened application window with appId: C:\Windows\System32\calc.exe, and processId: 12772 (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 12.06 seconds
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'

WinAppDriver (1.2.1) log:
==========================================
POST /session HTTP/1.1
Accept-Encoding: gzip
Connection: Keep-Alive
Content-Length: 493
Content-Type: application/json; charset=utf-8
Host: localhost:4723
User-Agent: selenium/3.141.59 (java windows)

{
  "desiredCapabilities": {
    "app": "C:\\Windows\\System32\\calc.exe",
    "ms:waitForAppLaunch": "8",
    "ms:experimental-webdriver": false,
    "platformName": "Windows",
    "deviceName": "WindowsPC"
  },
  "capabilities": {
    "firstMatch": [
      {
        "appium:app": "C:\\Windows\\System32\\calc.exe",
        "appium:deviceName": "WindowsPC",
        "ms:experimental-webdriver": false,
        "ms:waitForAppLaunch": "8",
        "platformName": "windows"
      }
    ]
  }
}
HTTP/1.1 500 Internal Error
Content-Length: 168
Content-Type: application/json

{"status":13,"value":{"error":"unknown error","message":"Failed to locate opened application window with appId: C:\\Windows\\System32\\calc.exe, and processId: 12772"}}

It works when I use the application Microsoft.WindowsCalculator_8wekyb3d8bbwe!App

We have tried to Automate Control Panel in windows using WinAppDriver and trying to go to View by Large Icon and click on System to get the Computer Name in it. We are running WinAppDriver on a <IP_ADDRESS> 4723 and tried to automate using TestNG and Selenium.
When we are automating applications like notepad.exe this is got successfully automated by using application path, but when we are trying to automate Control Panel, Command prompt, etc. with the application path from system32 of windows and even with AppID's also getting the issues (Errors are mentioned in the below sections).
Scenario 1: Tried with Application path as below:
DesiredCapabilities cap = new DesiredCapabilities();
cap.setCapability("app", "C:\WINDOWS\system32\control.exe");
cap.setCapability("Platform", "Windows 10");
cap.setCapability("Device Name", "Windows PC");
driver = new WindowsDriver(new URL("http://<IP_ADDRESS>:4723"), cap);
Assert.assertNotNull(driver);
driver.manage().timeouts().implicitlyWait(5, TimeUnit.SECONDS);
Error:
org.openqa.selenium.SessionNotCreatedException: Unable to create a new remote session. Please check the server log for more details. Original error: Failed to locate opened application window with appId: C:\WINDOWS\system32\control.exe, and processId: 8768 (WARNING: The server did not provide any stacktrace information)
Scenario 2: Tried with AppID as below:
DesiredCapabilities cap = new DesiredCapabilities();
cap.setCapability("app", "Microsoft.Windows.ControlPanel");
cap.setCapability("Platform", "Windows 10");
cap.setCapability("Device Name", "Windows PC");
driver = new WindowsDriver(new URL("http:// ://<IP_ADDRESS>:4723"), cap);
Assert.assertNotNull(driver);
driver.manage().timeouts().implicitlyWait(5, TimeUnit.SECONDS);
Error:
org.openqa.selenium.SessionNotCreatedException: Unable to create a new remote session. Please check the server log for more details.
Original error: The system cannot find the file specified (WARNING: The server did not provide any stacktrace information)
We are using WinAppDriver V1.2.1, OS Windows 10 pro and OS Build Version 19042.867
Since we are very new to WinAppDriver can anyone help us in resolving this issue? Please find the capabilities we have used for automation.

@KitoCoding
Can you try cache for initial start app, then attach to it using process id or desktop session by window name in a loop until window will appear

@mreiche Are you still facing the issue or if it is resolved then let me know the resolution I am also facing the same issue?

@mreiche Are you still facing the issue or if it is resolved then let me know the resolution I am also facing the same issue?

Yes. But this doesn't affect my real world scenario. I was able to implement a working stable automation even without calc.exe.

@mreiche  How your desktop automation is working on the Remote machine?

@mreiche How your desktop automation is working on the Remote machine?

Well I'm actually not running tests against remote Windows. But when you have trouble to get your WindowsDriver to run with an application, try to find the running application by window title and initialize the driver using the window handle. That worked for me, is described here: https://github.com/Microsoft/WinAppDriver/blob/v1.0-RC2/README.md#attaching-to-an-existing-app-window and implemented here: https://github.com/telekom/testerra-appium-connector/blob/testerra2/appium/src/main/java/eu/tsystems/mms/tic/testframework/appium/WinAppDriverFactory.java#L104

@mreiche I have tried with the above solution but still it didn't help to resolve the issue on the remote machine.

@mreiche I have tried with the above solution but still it didn't help to resolve the issue on the remote machine.

Thats unfortunate.

I installed my test environment on a remote windows VM, which is working so far.

I created a admin user with RDP access
Enabled autologin for this user via https://docs.microsoft.com/en-us/sysinternals/downloads/autologon
Enabled development mode
Started WinAppDriver with public IP and port
Enabled this port in Windows firewall rules
Tested remote port access from local machine
Smoke tests where working as expected like running on localhost

Hi,
I am trying to automate the Microsoft LinkedIn application with java -Selenium, WinAppDriver for demo purpose. Application get launch but  its getting failed due to Failed to locate opened application window with appId. This error is getting shown.
Could you please provide any one suggestion that can help as of now i have tried all the online solutions that are related with this issue.

Hi, I am trying to automate the Microsoft LinkedIn application with java -Selenium, WinAppDriver for demo purpose. Application get launch but its getting failed due to Failed to locate opened application window with appId. This error is getting shown. Could you please provide any one suggestion that can help as of now i have tried all the online solutions that are related with this issue.

@Sameer9767  Please create separate issue, provide code sample, WinAppDriver log


Allow query params for create, update, and save

Same as #198, but for the instance methods create, update, and save. This is pretty straight forward (motivation & usage can be seen in mentioned PR).

@tpodom any news on this PR? It's pretty straight forward


Issue 68 function node

Description
#68 Implements Function and FuntionParamter as well as machinery for dynamically loading a function given string representing the filename.
Fixes #68
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #147 into master will increase coverage by 0.65%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   95.34%   95.99%   +0.65%
==========================================
  Files          36       38       +2
  Lines        1311     1674     +363
==========================================
+ Hits         1250     1607     +357
- Misses         61       67       +6

Impacted Files
Coverage Δ

pybamm/parameters/parameter_values.py
100% <100%> (ø)
:arrow_up:

pybamm/expression_tree/function_parameter.py
100% <100%> (ø)

pybamm/util.py
93.84% <100%> (+5.61%)
:arrow_up:

pybamm/expression_tree/unary_operators.py
100% <100%> (ø)
:arrow_up:

pybamm/geometry/geometry.py
91.11% <0%> (-8.89%)
:arrow_down:

pybamm/discretisations/base_discretisation.py
98.18% <0%> (-0.99%)
:arrow_down:

pybamm/parameters/standard_parameters.py
100% <0%> (ø)
:arrow_up:

...m/discretisations/finite_volume_discretisations.py
100% <0%> (ø)
:arrow_up:

pybamm/models/base_model.py
100% <0%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5100b6...8b29164. Read the comment docs.


Removes support for Annotation.duration and associated apis

While this is a breaking change, I can't find any uses even with global GitHub
search, apart from an experiment and spring-cloud-sleuth, which I'll address.
If we ever want to remove this, it would be best to do so before 3.0 is final.
See https://github.com/openzipkin/zipkin/pull/717

don't merge this until openzipkin/zipkin#717


Only run benchmarks for tagged PRs

This adds a new optional setting for workers (following the request: https://github.com/ocaml/merlin/pull/1485#pullrequestreview-1018443932 ) in our environments/*.conf:
{
  "repositories": [
    {
      "name": "owner/repo",
      "if_label": "bench"
    },

When if_label is configured, the benchmarks will run only for PRs that have this flag/label/tag enabled on github. Benchmarks still run as normal for the main/master branch (otherwise PR would have zero context to decide if a regression happened!) or when no if_label has been set (which is currently the case for every projects).
Since the label is configurable per worker, it allows to toggle only some workers off (for example "rpi-bench" could be an optional tag, as the raspberry benchmarks are much slower than the normal workers).
PS: I had to upgrade ocamlformat to the latest 0.22.4, sorry for the noise!

I force-pushed a rebase of the branch on main. It doesn't compile anymore, but at least it's not because of a bug that we already fixed on main.

I force-pushed a rebase of the branch on main. It doesn't compile anymore, but at least it's not because of a bug that we already fixed on main.

My rebase was very bad so I just undid it. Will rebase properly soon.

Thanks to ocurrent merging my PR this one is ready for a full review. I tested it locally and everything seems to be in order.

Thanks a lot!