RASA_NLU performance really bad with faq data.

Rasa version: 0.14.6
Python version: 3.6
Operating system: Windows
Issue: RASA_NLU performance really bad with faq data.
I am in the process of developing faq bot with around 250 unique QNAs. I am using tensorflow pipeline but its results are really bad.
I am open to providing the dataset privately to get the best possible pipeline. I am also not sure if rasa is a good fit for faq bots but I am a big advocate of rasa framework in general, So I would really want to make this work. Any help will be greatly appreciated.
Content of configuration file (config.yml):
language: "en"
pipeline:

name: "tokenizer_whitespace"
name: "intent_featurizer_count_vectors"
token_pattern: '(?u)\b\w+\b'
max_ngram: 2
name: "intent_entity_featurizer_regex"
name: "intent_classifier_tensorflow_embedding"

how many examples do you have per intent? we're actually currently researching how we can do faqs/chitchat better

Per intent, I have just one example as of now. I understand that for every intent at least 3 examples are required, but for me, this will be at least a 2-day exercise and I am not sure even then it will be very accurate to take into production.

3 examples per intent ? With so many QNAs you are going to need much more IMHO, like 20 or even better 50 per intent.
The problem for me is Q&A do not map well into "intents". Intent is something users want to do, like book a trip or order a table. On the other hand, two separate, but similar questions might mean to the same intent.
For instance the questions: Where can I open an account ? How can I open an account? are the same "intent" (open an account) but require two separate answers. Good luck training that.
I would think about alternative approaches: merging some of your questions and/or force users into "paths" by selection of multiple choices.

I absolutely get your point. With the approaches you suggested I can merge few question but I would still be left with way too many faqs. The other option is not feasible for me.
I have worked with Microsofts qnamaker in the past and it works really really well but again I can only use open source frameworks.
Any other approaches you have in mind which I can give a try?

yeah you should probably have more examples per intent for now. Like i mentioned we're working on something for chitchat/FAQs in general though, we'll let everyone know when that work is ready. I'm going to close this issue in the meantime because it's more of a usage question, and those should be posted in our forum

i am a newbie to rasa but i may have few suggestions for you. you can use Chatito  https://rodrigopivi.github.io/Chatito/ to generate more data. and also, i think you can reduce number of intents using slots. for example, there may be questions like Where can I open an account ? How can I open an account?. both of these intents can be taken into one intent and fill categorical slot as How, Where ... etc. then after you can write stories depend on the slot value, and pass different utter messages. hope this help someone if there is any mistake, please reply.


get rid of suse-prime (usage); this tool is obsolete!

This tool creates more harm than benefit nowadays. See https://negativo17.org/prime-optimus-laptops-and-multi-gpu-systems/ how to correctly setup Hybrid graphics system

@scaronni-nvidia JFYI ...


Say if it can scan barcodes also

On Google Play, see if this app is only good for scanning QR codes, or if it also can scan barcodes.

@jidanni I don't recall adding the option to scan different codes, but it's simple to do. Could you test it out for me to see if it scans barcodes?

My mom confiscated my phone (I'll just have to trust your own tests.)

I am able to scan barcodes with this app as of now.


fix fd resource leak

@jow- think this should be merged problem is the wrong commit form....

https://github.com/openwrt/packages/blob/master/CONTRIBUTING.md

No reaction from contributer -> closing


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2129

Questions ?
Please refer to the Backport tool documentation


Lookup module does not seem to work well with tide-references

What did you expect to happen?
I would like gD to run tide-references when editing a Typescript file
What actually happened?
Nothing happens
Additional details:
I added this in my config.el
(set-lookup-handlers! 'typescript-mode
  :definition #'tide-jump-to-definition
  :references #'tide-references)

The definition part seems to work well (ie gd works as expected) but the references one doesn't do anything visible (I could not find any error)
M-x tide-references works as expected, only the binding does not seem to work.
Steps to reproduce:

enable tools/lookup and lang/javascript modules
edit a typescript project
try to find references of a symbol using gD

System information:
Looks like doom info is broken on my system. It complains :
x There was an unexpected error
  Message: Symbol's value as variable is void
  Data: (void-variable . emacs-repository-branch)

I'm using the lastet develop branch to test

I think I have fixed it on my own
(set-lookup-handlers! 'typescript-mode
  :definition #'tide-jump-to-definition
  :async t
  :references  #'tide-references
  :documentation #'tide-documentation-at-point
  )

Adding :async: t right before :references seems to have done the trick. I cannot say I fully understand what's going on, so if someone wants to chime in and give details for posterity, feel free ;)
Also I don't know why this is not the default of how the javascript module is configured. It's currently configured as
https://github.com/hlissner/doom-emacs/blob/develop/modules/lang/javascript/config.el#L193-L195 but it does not seem to work at all here in a TS project. I don't know if it's "normal" or if something is wrong with my setup


Summarizing:

Make it shellcheck compliant.
Making its output similar to python  koans
Convert *.c to bash
Added one test file addressing first page of gnu bash reference manual contents.
Renaming all tests
...
Propose to have a license

Try it and tell me if you like it.

This is fantastic!
Although I'm saddened by the removal of my C files ;) - I think it's a great idea! All bash!
A few questions:

Why do almost all files start with 00_? Is this on purpose?
I'm running grep (BSD grep) 2.5.1-FreeBSD and I get grep: unrecognized option '--perl-regexp' when I run ./meditate

Regarding the license - I'll feel free to add a MIT license, or I'll do it when we merge this in.

It's on purpose (in d7f1ce4 i should explained it) as an easy way to preserve initial order and add below bash manual inspired koans.
OK fixed in 0dbfd67

License: I'm OK with whatever free license you add into the report, but is convenient to choose one to enable collaboration.


Special chars in plugin function arguments cause the function to not get called.

Plugin functions don't get called when we pass in some special characters in argument strings.
For example: some reply ^addMessageProps(greeting, happy) works (i.e. the addMessageProps is called) whereas some reply ^addMessageProps(greeting, happy!) doesn't work. The function addMessageProps is simply not called.
Need a way to escape special chars when passing strings as function arguments.
One option could be to allow "" as a way of escaping arguments - everything inside "" including commas, etc. gets passed in as a single argument.

+1 we need this badly as well!

@nsaraiya and @jelko – Unfortunately you cannot use special characters and dots. My solution is using encodeurl() or an escape() and encode the dots as well. So you can use special characters and dots in a function and decode it if needed. I hope this is solving your problem.

Fixed in v1.0.0 - you can now use arbitrary parameters like objects or arrays too.
So now you'd use ^addMessageProps("greeting", "happy")


Isolate Giraffe code from Moose production deployments

Describe the task
Once giraffe-develop has been merged into develop, we will need to ensure that the Registration and Reporting apps, as well as the API, can all be deployed independantly. If we do not, then then Registration release / deploy process will also deploy Reporting code that may not be production ready. This would expose unfinished work to the end users.
Acceptance Criteria

[ ] Plan for synchronizing API releases
[ ] Isolated release and deployment processes for each app (Reg., Rep., API)
[ ] Documentation on decisions and processes

Additional context
We will want to ensure that members of both teams have an understanding of the approach taken.

Irrelevant based on work already completed.


Make 'Sync Source Control Mgmt' true by default

Or at least mention that this needs to be ticked on the front page. I just wasted at least an hour trying to figure out why this build step wasn't synchronizing. It wasn't exactly helped by the fact that the 'advanced' button was off screen.
Thanks for your work on this amazing plug-in!

This was the default when #36, #38 was merged and I agree it should be the standard. @brantone removed his own defaulting for some reason in 66c1dc682a176289652f9d69958e2c98340310aa. Please put it back (via a PR to the new repo https://github.com/jenkinsci/ez-templates-plugin)

My reasoning was : the typical purpose for using this plugin is to have similar build steps but for different projects, and since different projects are most often in different repos than default to not sync SCM. Granted the job could be set up with parameters for SCM, but that'll only work at a high-level ... and won't work at all if (in my use case) different projects are in different SCM types altogether (ex: some in Perforce, some in Git). But, whatever works, just a checkbox either way :)

FYI I already amended this one, no further work required. I get what you're saying about different projects but I imagine its perfectly common for all impls to share the same scm provider. The out-of-the-box behaviour needs to remain as advertised (clone except job params) until we manage to get something working for the V2 stream that allows us to avoid the ugly way we have implement each specialisation.


promise api?

a promise based api would be pretty nice now that async await is available in most browers and node, any thoughts on switching to something like that in a newer version ?

I would not be opposed to doing something like that.  I think that is a good direction to take this library, since it is now available in most browsers and node.  I will add this to the list of things to do.

Came here to request the same thing. Well, a promise API specifically - probably still a bit premature to adopt async/await.
I tried using node-promisify but without success. For instance:
const promisify = require('promisify-node');
const geopackage = promisify('@ngageoint/geopackage');
geopackage.openGeoPackage('data.gpkg').then((gpkg) => {
    return promisify(gpkg.getFeatureTables)();
}).then(tables => {
    console.log(tables);
}).catch(console.error);;

caused
TypeError: this.getGeometryColumnsDao is not a function
    at GeoPackage.getFeatureTables (/Users/stevebennett/odev/freelancing/crc-si/ziggurat/node_modules/@ngageoint/geopackage/lib/geoPackage.js:194:18)

I assume the this is not being maintained correctly.

I am actively working this issue on the api-changes branch

This has been published as 2.0.0


Networking issues after upgrade to 4.2.5

UTM Version: 4.2.5
macOS Version: 13.3.1
Mac Chip: M1

I used to run UTM 4.1.x with two VM: one Ubuntu 23.04 and one Windows 11. In fact, I started with lower versions of macOS, UTM and Ubuntu. Then all updates succeeded without major problem.
Today, I upgraded UTM to 4.2.5 and I now have weird networking issues.
Each VM has one network interface, configured as "shared network". With UTM 4.1.x, the two VM consistently received the following IP addresses each time:

Ubuntu: <IP_ADDRESS>
Windows: <IP_ADDRESS>
macOS host: <IP_ADDRESS>

Now, when I boot the various VM, I get this:

Ubuntu: <IP_ADDRESS>
Windows: <IP_ADDRESS>
and on macOS host: <IP_ADDRESS>

Note the new subnet .66 instead of .64.
I did many restarts of the various VM's and I am positively sure that, at some point, the two VM had two different subnets .65 and .66. At that time, the macOS host had two interfaces <IP_ADDRESS> and <IP_ADDRESS>. Now, for some unknown reason, only .66 is used. I cannot reproduce the situation with two subnets .65 and .66 at the same time but you can see that the subnet moved from .64 to .66.
EDIT 1: After a couple of hours, my Debian VM now boots as <IP_ADDRESS>, jumping to a new subnet .67.
I see no configuration menu for DHCP in UTM. How does the VM receive its IP address? Is there some embedded DHCP server inside UTM? How do you configure it? How can we get stable IP addresses?
Additionally, there is some new weird behavior in the UTM networking GUI since the upgrade to 4.2.5. I just created a new VM and installed Debian 11. The Debian VM gets address <IP_ADDRESS>.
When I edit the configurations of the various VM ("Modify" menu), I get this on the two older VM which were created by some previous version of UTM (can't remember which one exactly). The GUI is in French.

And the network choices are:

In the new Debian VM, created by UTM 4.2.5, I see this:

You can no longer select the NIC type and the advanced settings.
And the network choices are more limited:

The "Emulated VLAN" and "Host only" options are gone. But they are still present in the older VM.
Can't we use "Host only" interfaces with new VM? Can't we specify advanced settings, with a fixed address for instance?
EDIT 2: The "Modify" window for the older pre-4.2.5 VM Ubuntu and the new VM Debian are also different. The old one had "QEMU" and "Input" options. The new one has "Boot" and "Virtualization" instead. We can no longer have access to the full QEMU command with new VM.
Older VM options menu layout:

New VM options menu layout:

It's getting worse. I reverted to UTM 4.1.6 and my Ubuntu VM now gets <IP_ADDRESS>. But the macOS host no longer has any address on that subnet. My virtual machines can no longer be accessed from the host (ssh from host to guest).
I used to have a stable pair of Ubuntu & Windows VM but I end up with no usable VM at all (no network connection to host).
Does anyone know what's going on with networking on UTM macOS?

while I cannot comment on the networking (subnet) issues, the differences you showed in your "EDIT 1" and "EDIT 2" seem to indicate that your new VMs were created using the "Virtualize" option whereas the older ones were created using the "Emulate" option. With this UTM is using Apples Virtualization framework instead of QEMU as backend. You can choose between these in the first step of the "Create new Virtual Machine" wizard.

Thanks @tbussmann
Recreating a new Debian VM with QEMU option gives the same result as the previous Ubuntu VM. I probably clicked on some other option when creating the previous Debian VM. It is a pity we cannot review the creation options after the creation.
However, what does "emulate" mean in that case? Not "emulate" in the sense that QEMU can emulate another CPU architecture I suppose. In the past, I have run an "emulated" arm64 Linux system on a native Intel x64 Linux system and the difference of performance between the host and the emulated arm64 system was huge (and expected). Here, the performance of the VM is similar to the host (tested on large compilations) and there must be some other sort of virtualization, under the control of Qemu.
How does Qemu work in that case?

FWIW I've noticed the same behaviour using other virtualization tools that use Apple's Virtualization Framework underneath them (like multipass or docker desktop).
My understanding is that the subnet used by Apple's Virtualization Framework is the "Internet Sharing" network defined in the /Library/Preferences/SystemConfiguration/com.apple.vmnet.plist file.
I cannot say what triggers it, but from one moment to the other macos decides that the subnet must be changed and uses the following one. A had it change from <IP_ADDRESS> to <IP_ADDRESS> and then to <IP_ADDRESS> with no apparent reason (even without restarting the os). All the VMs that were already running or created previously with the old subnet obviously get affected and their networking breaks because they can't access anything.
I'd really like to know what is triggering the subnet change, but it seems that I am not putting the right keywords in the search engines. This issue is the only related thing that I found with someone experiencing a similar behaviour.
This other issue could be related:

https://github.com/utmapp/UTM/issues/5128


Find graph creating tools for react

Is your feature request related to a problem? Please describe.
Currently we have no tools for generating Graphs such as histograms. Creating home made graphs will take time and be hard
Describe the solution you'd like
We should have some suggestions of tools that are avaible for react that can create graphs such as histograms.

Available tools to look into:
Recharts
Victory
Visx
Nivo

NFC group is using TOAST ui so using that could be an advantage. However I think recharts looks good and seems to be what most people use. I will try creating some simple graphs with it to see how easy it is to use.

This is what I have gathered so far

Recharts
Seems to have good docs and is easy to use. However does not have good support for box diagrams, there is one example in the storybook but it is not build into the api. It also is well integrated with react.

Victory
Has what we need with good examples of how to get it running. However not as easy as recharts

Visx
Has tons of features but examples and docs are not so good which would probably make it hard to use.

Nivo
Has good documentation and examples with where items can changed directly on their website before placing in our code. The only problem is I can not find a boxplot

Toast ui
Is used by another group which could make for some good collaboration. Has everything we need, but implementation seems to be harder than for example with recharts.

I would personally chose recharts just because it is easy to use. boxplots could be a bit annoying to implement since there is no simple api call but there are
examples of how to do it.
I attached a picture with what could be created in recharts in quite a short time

And to create this graph with 2 bars this is all i needed to do was
import { Bar,BarChart, LineChart, Line, CartesianGrid, XAxis, YAxis } from 'recharts';

const data = [
  { name: 'Metric A', uv: 100, pv: 100, amt: 2400 },
  { name: 'Metric B', uv: 200, pv: 200, amt: 2200 },
  { name: 'Metric C', uv: 230, pv: 300, amt: 2200 },
  { name: 'Metric D', uv: 300, pv: 430, amt: 2500 },
  { name: 'Metric E', uv: 800, pv: 100, amt: 2400 },
];

const renderBarChart = (
  <BarChart width={500} height={500} data={data}>
    <CartesianGrid stroke="#ccc" />
    <Bar type="monotone" dataKey="uv" fill="#8884d8"/>
    <Bar type="monotone" dataKey="uv" fill="#82ca9d"/>
    <XAxis dataKey="name" />
    <YAxis />

  </BarChart>
);

And inside a div in the html to render the graph
{renderBarChart}

I have now tested Victory aswell and it is quite nice. It was harder to use than recharts but has built in histogram and boxPlot. It also seems more powerful but I have not done super complicated things.
Here is a picture of what I was able to do during this morning

If anyone is curious about the code it is in this branch

https://github.com/PUM04/pum-04/tree/19-find-graph-creating-tools

Victory was decided to be used


Remove amo.tests.test_locales, django has 'mn' locale these days.

One less file that imports tower

I think the point of the docstring was to say that the test should be changed to some other non-existent locale when we have a mn locale :)
Maybe use a locale code that doesn't exist?

Correct if I'm wrong but it also mentions z-messages.po which doesn't exist anywhere? And django officially loads everything in LOCALE_PATHS first and doesn't appear to return en-US as a fallback anywhere.

Not sure, but those "particularities" might be related to our specific implementation (using tower and such)?

With the django 1.7 branch tower will be gone and the particular code that is referenced on introduction of the test - https://github.com/clouserw/tower/commit/c2690bb8 - is gone. Since marketplace and others are not using tower anymore it appears django is doing this correct. I mean, I'm pretty sure it does, there are a few patches to django that might relate to this but fix this in different ways.

if you're sure, then ok ;)
r+


Update assessment permission/aqua229

Assessment permission:
Now permission to /GET an assessment will be given if:

Have access to the revision of the assessment
Have access to the reference of the assessment (if it exists)

The latter is achieved using this select clause in sql alchemy:
stmt = (
            select(Assessment)
            .join(BibleRevision, BibleRevision.id == Assessment.revision_id)
            .outerjoin(ReferenceRevision, ReferenceRevision.id == Assessment.reference_id)
            .filter(
                BibleRevision.bible_version_id.in_(version_ids),
                or_(
                    Assessment.reference_id == None,
                    ReferenceRevision.bible_version_id.in_(version_ids),
                )
            )
        )

Here you make a join with revision.id that we now exists, we check if the version id of that revision is on the list of version_ids accessible by the user, and other join(outer) with the reference revision(also revision table but with alias), with the or_ clause we say, either the reference_id is null(we don't have to check anything), and if not, we have to check that the version id is in our version_ids list.
Additionally, we removed the assessment access table since we won't be using it anymore. Also had to make some changes on alembic because the async operations were causing a bit of trouble, so basically, we configured it to work async

easily roll back?

Yes it should be fairly easy to rollback, as we are going to delete the assessment table, we could roll back the db with alembic, but in any case, I am going to take a snapshot. And we can test it first on our dev runner to see if it works well

easily roll back?

Yes it should be fairly easy to rollback, as we are going to delete the assessment table, we could roll back the db with alembic, but in any case, I am going to take a snapshot. And we can test it first on our dev runner to see if it works well

Great. I think you can go ahead and merge when you're ready then.


Build macos arm64 wheels

Overview
Description of the changes proposed in this pull request:
SHAP does not provide arm64 wheels for MacOS, which is essential since most of modern Mac computers use this architecture. With this PR, I am enabling the building of amr64 wheels.
I would also be very happy if arm64 wheels would be added to PyPi as soon as possible.
I ran the building process on the branch, and it successfully build arm64 wheels: https://github.com/PrimozGodec/shap/actions/runs/5504208255
Checklist

[ ] Closes #xxxx
[ ] All pre-commit checks pass.
[ ] Unit tests added (if fixing a bug or adding a new feature)
[ ] Added entry to CHANGELOG.md (if changes will affect users)

Thanks for the PR! Yes, it would be great to get a broader range of wheels built. For last week's release, we took a pragmatic decision last week to build with a relatively restricted set of wheels (mirroring the set chosen in scikit-learn), accepting it wasn't as comprehensive as we'd like.
I'm running a build on a temporary branch now to confirm that arm64 builds on macos and aarch64 builds on linux, as per #3061.  As you mention you're eager to have wheels on PyPI as soon as possible, maybe we can make a patch release soon with further architectures added.  What do you think @thatlittleboy ?
One snag I noticed is that cibuildwheel can't currently run tests on arm64:

While arm64 wheels can be built on x86_64, they cannot be tested. The ability to test the arm64 wheels will be added in a future release of cibuildwheel, once Apple Silicon CI runners are widely available.

I don't know if there's anything we can do about this, so may have to just take the chance. @PrimozGodec , are you by any chance able to run the tests locally on your machine against the wheel on arm64?

The way I see it is that for those on arm64 macs, (in the absence of the appropriate CI runners) it's either we release an untested wheel or None at all, and I think the former is a better scenario for us to be in.
It's the same situation with our cuda c extension module actually. 😅
A patch release sounds good. We need one anyway because of #3075.

@connortann, thank you for taking quick action.

I don't know if we can do anything about this, so we may have to just take the chance. @PrimozGodec , are you, by any chance, able to run the tests locally on your machine against the wheel on arm64?

I think we cannot do anything about it. Also, numpy/scipy don't test wheels on arm64. I tested the wheel locally and the tests passed.

it's either we release an untested wheel or None at all

I think it is better to provide a wheel and the community report if anything is wrong. Having wheels makes life easier for people without compilers on the computer.


docs(codemod): update installation and usage instructions

I noticed that the codemod script name is wrong.
TODO

[ ] Verify the best practice for installing codemods: local repo clone or global registry?

@aaronmcadam Can you add instructions for how to apply this to a whole project from start to finish?

do i have to install this as a dev dependency for my project?
how is there some typical find *.js | xargs ... command to run this over my entire project?

...

You need to be careful to ignore your dist or other bundle output. You can use your .gitignore file for this.
Can you try jscodeshift -t lib/codemod/src/transforms/update-organisation-name.js --ignore-config .gitignore path/to/your/project?
We also need to check whether we have to tell users to clone the repo, like react-codemod, or like the docs say, install the package and register it with jscodeshift somehow.

@aaronmcadam Do you think you can demo this?
We could create a video like so:

create a folder
start CRA in it
start 2.x.x storybook in it
run codemods
cleanup
run cra & storybook
cake

I need help with step 4.

@aaronmcadam how hard would it be to add this to getstorybook? Or is that a terrible idea? 😬

I have big plans for the cli, and that would be one of them @shilman
I actually want to build something like this (eventually):
storybook start   # starts and opens storybook

storybook start --public  # starts and create a temp public url to share

storybook build  # builds to static site

storybook deploy  # builds to static site & deploy to heroku

storybook help <searchterm>  # search our documentation

storybook migrate  # run codemods to latest version

@aaronmcadam it's not working for me. here's my steps:
  505  yarn create react-app testapp
  506  cd testapp/
  507  yarn add getstorybook
  508  ./node_modules/.bin/getstorybook
  509 cd ../storybook
  510 jscodeshift -t ./lib/codemod/src/transforms/update-organisation-name.js --ignore-config .gitignore ../testapp/

I'm getting errors that look like this:
MBP:storybook shilman$ jscodeshift -t ./lib/codemod/src/transforms/update-organisation-name.js --ignore-config .gitignore ../testapp/
Processing 17179 files...
Spawning 3 workers...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
 ERR ../testapp/node_modules/asn1.js/test.js Transformation error
SyntaxError: Unexpected token (6:0)
    at Parser.pp.raise (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/location.js:24:13)
    at Parser.pp.unexpected (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/util.js:82:8)
    at Parser.pp.parseExprAtom (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:425:12)
    at Parser.parseExprAtom (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/plugins/jsx/index.js:412:22)
    at Parser.pp.parseExprSubscripts (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:236:19)
    at Parser.pp.parseMaybeUnary (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:217:19)
    at Parser.pp.parseExprOps (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:163:19)
    at Parser.pp.parseMaybeConditional (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:145:19)
    at Parser.pp.parseMaybeAssign (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/expression.js:112:19)
    at Parser.pp.parseVar (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:493:24)
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
Sending 50 files to free worker...
 ERR ../testapp/node_modules/errno/cli.js Transformation error
SyntaxError: 'return' outside of function (8:2)
    at Parser.pp.raise (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/location.js:24:13)
    at Parser.pp.parseReturnStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:275:10)
    at Parser.pp.parseStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:89:19)
    at Parser.parseStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/plugins/flow.js:655:22)
    at Parser.pp.parseIfStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:268:26)
    at Parser.pp.parseStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:87:19)
    at Parser.parseStatement (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/plugins/flow.js:655:22)
    at Parser.pp.parseTopLevel (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/statement.js:30:21)
    at Parser.parse (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/parser/index.js:70:17)
    at Object.parse (/Users/shilman/.config/yarn/global/node_modules/babel-core/node_modules/babylon/lib/index.js:45:50)

And the resulting files look something like this (note this is from a different app, but the pattern is the same):
import { configure } from undefined;

import undefined

const req = require.context('../src', true, /.story.js$/);

function loadStories() {
  req.keys().forEach(filename => req(filename));
}

configure(loadStories, module);

Hey @shilman judging from that output, it looks like the .gitignore isn't ignoring node_modules. I'll try this later though and get back to you

Here's the implementation of the codemod:
https://astexplorer.net/#/gist/f2d0b42c37e4556a4f816892be6ca402/ad64d6387a68461556dd57d1cc3d4124425f1573
Give it a test

@ndelangen I am still having problems running this on my project. Can you please test it on a from-scratch project that is not part of the monorepo and tell me if it works for you. Here are my exact repro steps:
  505  yarn create react-app testapp
  506  cd testapp/
  507  yarn add getstorybook
  508  ./node_modules/.bin/getstorybook
  509 cd ../storybook
  510 jscodeshift -t ./lib/codemod/src/transforms/update-organisation-name.js --ignore-config .gitignore ../testapp/


OOP rewrite of conf and user I/O code

Here is a proposal for a continuation of the work made in https://github.com/Eigenbahn/ai-dungeon-cli/pull/4.
@idangur, @otreblan and @Zer0xFF I would really appreciate if you could do a small code review.
tl;dr

configuration loading moved from main class into dedicated one
user / terminal I/O code turned into a class

Details
I wasn't super satisfied w/ having the config loading being done in the game logic class AiDungeon (bad separation of concerns).
Also, the coding style was heterogeneous between the user / terminal I/O code (module as an object) and the rest (objects are class). So I also turned it into class(es).
It should (I hope) help greatly using this package as a library to integrate it with other systems (like @Zer0xFF did in https://github.com/Eigenbahn/ai-dungeon-cli/pull/9).
I could have gone full retard and extract API calls from class AiDungeon into a dedicated one as well but as there is only one public instance of this API it's not worth the effort.

Oopsie, well spotted. Should be fixed.

from a visual inspection it looks good, but just a nitpick comment.
config file path should be an argument, with perhaps defualt value.

@Zer0xFF I thought about adding argparse to be able to change behavior via arguments.
All config keys would be mapped to parameters, making the config file either optional or fallback values.
But I didn't think about having an argument to load a file from a specific location. I'm taking note.


Backplane Rev C Errata

[x] USB !BUSPWR is wrong: Currently tied to GND, which states that the hub and all downstream devices are powered from the upstream port. Should be tied high, stating that the hub has an "external" power supply. In both modes, the hub still will perform overcurrent and poweroff protections.

Symptom: This limits the hub to 500mA max total draw, as each downstream port has a minimum 100mA allotment (USB spec), so the hub disables higher ports (cannot use USB in Module 5 or Module 7 slot)
Remedy: Cut trace at pin 10 (!BUSPWR) and short pins 10 and 9.

[ ] Between power module and backplane isolation circuitry, something needs to protect against shorts.

Currently, the power module has a limiter downstream of the regulator, which protects the regulator by limiting to no more than 2A (?) sustained draw. The backplane module power switches are rated for 1.5A (?), so shorting a module will cause the isolation to blow.


[BUG] Job Scheduler Lock index should not use any user templates

What is the bug?
If a user creates an index template on pattern *, any mappings, settings get applied to the job scheduler lock index as well. This can cause issues when there is an overlap in field names or dynamic mapping is getting applied.
How can one reproduce the bug?

Create a template with lock_time mapping set to short
Start job scheduler through an ISM policy to create a new job
Job lock acquire will fail due to failure in create index

What is the expected behavior?

OS: Amazon Linux
Version [e.g. 22]
Plugins ISM, Job Scheduler

Do you have any screenshots?
NA
Do you have any additional context?
NA

@mgodwan What version of OpenSearch was this seen in? In general, index templates should filter out system indices before trying to create an index.

Fixed with https://github.com/opensearch-project/OpenSearch/pull/16418


Re-enable Windows builds

Starting with #14, Windows builds are skipped due to r-terra skipping Windows builds.
Were https://github.com/conda-forge/r-terra-feedstock/issues/61 to be resolved, then Windows builds should subsequently be re-enabled on this feedstock.

Windows was not re-enabled in the R 4.4 migration in https://github.com/conda-forge/r-dismo-feedstock/pull/19 because r-terra still does not work on Windows - see https://github.com/conda-forge/r-terra-feedstock/pull/102 for the latest effort to resolve this.


Implement fs instance for browser

GitKit currently only implements an FS for Node.js, it should provides an FS storing file in the localstorage/memory.

You might find inspiration in js-git, in the unlikely chance you haven't looked at it already.


Made LayoutBuilder's builder param required as well as added null check

Description
A LayoutBuilder without a child as parameter would have no use so it's been added.
Related Issues
Fixes #51363
Tests
Given that super constructor for this class would throw an error if the builder parameter is null, I am unsure of how to write a meaningful test for this fix. As mentioned here . I am seeking some guidance on how the analyzer behavior could be tested to catch this particular fix @Hixie .
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[x] Yes, this is a breaking change. If not, delete the remainder of this section.

@googlebot I signed it!

You could test that when you pass in null for the builder argument an assertionError is thrown.

@goderbauer I was thinking that as well, but as @dnfield mentioned here  that would be a false positive since the super constructor would throw an assertion as well.

The "real" test for this would be to run the analyzer on code that fails to do this and make sure that analysis picks up the issue here.  That's what this is really fixing.
I'm inclined to say we shouldn't bother with that, and instead focus on NNBD efforts, which will be changing this code around anyway and add better support from the langauge that would make this code an error that needs to be fixed.
I'm fine with this change as is.  @hixie - can we get an exception from the need to test this?

I'm voting we land this on the idea that a test for it will soon be useless since when we go to the null-saftey version of this the langauge keyword required will be mandatory, and whatever test we devise for this now would have to be retired (since it will no longer be an optional analysis lint but an actual compiler error).
If my understanding is wrong we can revisit adding a test for this, and other similar places in the codebase where we're missing @required on a subclass or composing class.

Sounds good.

@maschad Thanks for landing this change. Been bugging me for sometime.


If previously closed with any edge(s) overflows the screen border, window will relaunch at left top corner.

As is described, the re-generated window would appear at the {x:0,y:0} position with defaultWidth and defaultHeight, instead of the actual size and position when the window was closed.

I have had this issue as well, when I drag a window and set it to a corner on windows 10/11 (top-left, top-right, bottom-left, bottom-right) and then close the application, it will relaunch, but it will not go to the previously set position.

@kamaslau did you find a solution to this issue? I'm having the same problem, wondering how to re-generate without the bounds


API Documentation?

Hello,
This looks like a really cool project! Do you have any API documentation available? Things I'm looking at doing in particular:

How can I export an image template to some sort of JSON object so I can parse it myself and render server-side?
Is there documentation showing how to turn features on/off? e.g. turn off paint brush, add/remove fonts, etc?

Thanks!

Hello @anthonyeden!
The API documentation doesn't exist yet. But you can learn a lot from examples.

How can I export an image template to some sort of JSON object so I can parse it myself and render server-side?

Check the svelte demo, there you can find an example how to render images in the backend.

Is there documentation showing how to turn features on/off? e.g. turn off paint brush

The crop example has disabled almost all features in the toolbox.

add/remove fonts, etc?

This is not configurable yet. Fill free to open a merge request. The EditorConfiguration type should be extended.


Test the common sd-bus interfaces  (ex. org.freedesktop, org.openbmc interfaces)

https://github.com/openbmc/openbmc/issues/476

May have to tweak our test suites to accomodate sd-bus interfaces.

This is unit test related. We need to close it.


Custom fakeable types

There are occasions in which it is not possible to add field tags in a struct in order to use this library.
This PR defines an single method interface that can be implemented by a type.
When gofakeit.Struct() or gofakeit.Slice()`  calls the method in the interface, it uses the returned value as the generated value for the type.
There are now three ways to control the generation: field tags, Fakeable interface implementation, and gofakeit defaults. That is also the precedence in which they are applied in the case of multiple options being available. The reason why the field tags are always preferred over the rest of the options is because they are explicit instructions at the struct where the generation happens.
Would you be open to merging this?

I think I like the idea. It makes sense to me. Looks like all tests are passing so it should effect the current working usages.
Were you able to run coverage? Just want to make sure we are fully testing things.
Let me pass this along to a few other developers and get everyone's thoughts.

Thanks for the quick response!
I checked the code coverage. It changed a bit because there are a few error handling code paths that have been added but are not tested.
I'm happy to add additional tests to cover those cases if you want.
Before:
ok  	github.com/brianvoe/gofakeit/v6	1.211s	coverage: 95.7% of statements
ok  	github.com/brianvoe/gofakeit/v6/cmd/gofakeit	0.931s	coverage: 95.7% of statements
ok  	github.com/brianvoe/gofakeit/v6/cmd/gofakeitserver	0.538s	coverage: 69.1% of statements
ok  	github.com/brianvoe/gofakeit/v6/data	0.545s	coverage: 100.0% of statements
After:
ok  	github.com/brianvoe/gofakeit/v6	1.050s	coverage: 95.3% of statements
ok  	github.com/brianvoe/gofakeit/v6/cmd/gofakeit	0.401s	coverage: 95.7% of statements
ok  	github.com/brianvoe/gofakeit/v6/cmd/gofakeitserver	0.830s	coverage: 69.1% of statements
ok  	github.com/brianvoe/gofakeit/v6/data	0.680s	coverage: 100.0% of statements

I think as long as the coverage is good around what you did you should be fine

First of all, I really like the idea! Only one thing that we could talk about. How could the interface work with the faker object? So, for example, if I want to generate a fake first name through the interface, right now the only way I can do it, is by using the global faker object and there is no way I can use a local faker object.

type testStruct1 struct {
	B string `fake:"{firstname}"`
}

type strTyp string

type testStruct2 struct {
	B strTyp
}

func (t strTyp) Fake() interface{} {
	return FirstName()
}

func ExampleFake() {
	var t1 testStruct1
	var t2 testStruct1
	var t3 testStruct2
	var t4 testStruct2
	New(314).Struct(&t1)
	New(314).Struct(&t2)
	New(314).Struct(&t3)
	New(314).Struct(&t4)

	fmt.Printf("%#v\n", t1)
	fmt.Printf("%#v\n", t2)
	fmt.Printf("%#v\n", t3)
	fmt.Printf("%#v\n", t4)
	// Output:
	// gofakeit.testStruct1{B:"Margarette"}
	// gofakeit.testStruct1{B:"Margarette"}
	// gofakeit.testStruct2{B:"Two Hearted Ale"}
	// gofakeit.testStruct2{B:"Maudite"}
}

I don't know if it's possible, but it would be nice to pass a faker object to the Fake method, what do you think?

Interesting idea!
To make it work nicely I've refactored a bit struct.go to pass a *Faker object around instead of the *rand.Rand.

Thanks for the review! I'll get to it.
BTW I have a follow up PR after this one is merged. Just mentioning it in case you want to hold the release until you decide if that one is interesting too as it builds on this and the other PR that you just merged.

ya we can get this merged in once your ready and ill wait for you to submit the other pr and we can go from there.

Let me know if their is anything else you would like to add before I merge this.

https://github.com/brianvoe/gofakeit/releases/tag/v6.21.0

https://www.reddit.com/r/golang/comments/12mf47m/gofakeit_v6210_adds_fakeable_interface


Decoder Initial State and Input

Hi @RobRomijnders ,
Thanks for sharing your code. I am very new to RNNs so forgive me for a silly question. In your decoder I am a little confused about the inputs and initial state. Shouldn't the input be the one obtained from the encoder (the latent space)? It seems in your code
initial_state_dec = tuple([(z_state, z_state)] * num_layers)
dec_inputs = [tf.zeros([batch_size, 1])] * sl
outputs_dec, _ = tf.contrib.rnn.static_rnn(cell_dec, inputs=dec_inputs,
                                                       initial_state=initial_state_dec)

the initial state is obtained from the encoder and not the inputs? So if you could please explain me the reason for that?

Hi @shubhamagarwal003 ,
I know its really late for the answer. But if anyone comes here and is stumbled upon the same question, it may be of some help.
In the section Lat_2_dec, latent_vector (z_mu) is passed through a linear layer to obtain z_state.
Now, z_state is of hidden_size dimension, which serves as an initial hidden layer in the decoder.
That's what initial_state_dec is meant by.
And for the inputs for the decoder, they're initialized by zeros, given by dec_inputs.
So, we have inputs and hidden of a decoder.
Let me know if you have any questions.


Add Zoomify to quilt versions

The title, Quilt versions don't have Zoomify preinstalled for whatever reason lmao

/remind me about this tomorrow

help how do i use this bot lmao

/remind me about this october 24th


Changing padding with plugin

I'm writing my own horizontal legend plugin which injects under the x axis and wraps the keys to new rows when necessary. Its not clear if there is a way to increase the padding below the x-axis dynamically depending on how much space I need.
Is there a way to update the padding under the x axis to make room once the legend knows how much height it needs?

That will be tricky as it's kind of a chicken egg problem. If a plugin updates the chart it will cause a complete redraw which is again causing the plugin to re-render causing an infinite loop I guess. Except you can design your plugin that it will not cause a chart update if the space calculated is fitting because of the first re-draw. You can use chart.update to update any options.

We should consider this when working on #810


Improve CI logs in case of failure

Output the kubeconfig information and how to connect to the ci-runner.

/retest pipeline-service-test


v0.33.2 Karpenter won't scale nodes on 1.28 EKS version:

Description
Observed Behavior:
Karpenter pod logs:
Could not schedule pod, incompatible with nodepool "np-244-nodepool", daemonset overhead={"cpu":"780m","memory":"1120Mi","pods":"6"}, no instance type satisfied resources {"cpu":"6780m","memory":"11360Mi","pods":"7"} and requirements karpenter.k8s.aws/instance-category In [c m r], karpenter.k8s.aws/instance-cpu In [16 32 36 4 48 and 1 others], karpenter.sh/capacity-type In [on-demand], karpenter.sh/nodepool In [np-244-nodepool], kubernetes.io/arch In [amd64], topology.kubernetes.io/zone In [us-east-1a us-east-1b us-east-1c] (no instance type has enough resources)
I tried to remove everything from the requirements to make NodePool flexible as much as possible, but I got the same error:
Could not schedule pod, incompatible with nodepool "np-244-nodepool", daemonset overhead={"cpu":"780m","memory":"1120Mi","pods":"6"}, no instance type satisfied resources (no instance type has enough resources)
Expected Behavior:
Karpenter scales nodes dynamically regardless of the workload.
Reproduction Steps (Please include YAML):
`resource "helm_release" "karpenter" {
namespace        = "karpenter"
create_namespace = true
name       = "karpenter"
repository = "oci://public.ecr.aws/karpenter"
chart      = "karpenter"
version    = "v0.33.2"
wait = true
set {
name  = "serviceAccount.annotations.eks\.amazonaws\.com/role-arn"
value = var.karpenter_controller_arn
}
set {
name  = "settings.clusterName"
value = var.eks_name
}
set {
name  = "settings.clusterEndpoint"
value = var.cluster_endpoint
}
set {
name  = "settings.defaultInstanceProfile"
value = "np-244-KarpenterNodeInstanceProfile"
}
set {
name  = "logLevel"
value = "debug"
}
}
resource "kubectl_manifest" "nodepool" {
yaml_body = <<-YAML
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
name: ${var.workspace}-nodepool
spec:
template:
spec:
requirements:
- key: "karpenter.k8s.aws/instance-category"
operator: "In"
values: ["c", "m", "r"]
- key: "karpenter.k8s.aws/instance-cpu"
operator: "In"
values: ["4", "8", "16", "32", "36", "48"]
- key: "topology.kubernetes.io/zone"
operator: "In"
values: ["us-east-1a", "us-east-1b", "us-east-1c"]
- key: "kubernetes.io/arch"
operator: "In"
values: ["amd64"]
- key: "karpenter.sh/capacity-type"
operator: "In"
values: ["on-demand"]
nodeClassRef:
name: ${var.workspace}-node-class
limits:
cpu: "1000"
disruption:
consolidationPolicy: "WhenUnderutilized"
expireAfter: "720h"
YAML
}
resource "kubectl_manifest" "ec2nodeclass" {
yaml_body = <<-YAML
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
name: ${var.workspace}-node-class
spec:
amiFamily: "AL2"
role: "${var.workspace}-karpenter-controller"
subnetSelectorTerms:
- tags:
"karpenter.sh/discovery": "${var.workspace}"
securityGroupSelectorTerms:
- tags:
"karpenter.sh/discovery": "${var.workspace}"
blockDeviceMappings:
- deviceName: "/dev/xvda"
ebs:
volumeSize: 100
volumeType: "gp2"
encrypted: true
deleteOnTermination: true
YAML
}
IAM configurations:
data "aws_iam_policy_document" "karpenter_controller_assume_role_policy" {
statement {
actions = ["sts:AssumeRoleWithWebIdentity"]
effect  = "Allow"
condition {
  test     = "StringEquals"
  variable = "${replace(aws_iam_openid_connect_provider.this.url, "https://", "")}:sub"
  values   = ["system:serviceaccount:karpenter:karpenter"]
}

principals {
  identifiers = [aws_iam_openid_connect_provider.this.arn]
  type        = "Federated"
}

}
}
resource "aws_iam_policy" "karpenter_policy" {
name        = "${var.workspace}-KarpenterPolicy"
path        = "/"
description = "Policy for Karpenter"
policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "KarpenterInstanceProfileManagement",
"Effect": "Allow",
"Action": [
"iam:CreateInstanceProfile",
"iam:AddRoleToInstanceProfile",
"iam:RemoveRoleFromInstanceProfile",
"iam:PassRole",
"iam:GetInstanceProfile",
"iam:TagInstanceProfile"
],
"Resource": ""
},
{
"Sid": "KarpenterEC2Actions",
"Effect": "Allow",
"Action": [
"ec2:RunInstances",
"ec2:DescribeSubnets",
"ec2:DescribeSpotPriceHistory",
"ec2:DescribeSecurityGroups",
"ec2:DescribeLaunchTemplates",
"ec2:DescribeInstances",
"ec2:DescribeInstanceTypes",
"ec2:DescribeInstanceTypeOfferings",
"ec2:DescribeAvailabilityZones",
"ec2:DescribeImages",
"ec2:DeleteLaunchTemplate",
"ec2:CreateTags",
"ec2:CreateLaunchTemplate",
"ec2:CreateFleet",
"ssm:GetParameter",
"pricing:GetProducts"
],
"Resource": ""
},
{
"Sid": "ConditionalEC2Termination",
"Effect": "Allow",
"Action": "ec2:TerminateInstances",
"Resource": "*",
"Condition": {
"StringLike": {
"ec2:ResourceTag/Name": "karpenter"
}
}
}
]
}
EOF
}
resource "aws_iam_role" "karpenter_controller" {
assume_role_policy = data.aws_iam_policy_document.karpenter_controller_assume_role_policy.json
name               = "${var.workspace}-karpenter-controller"
}
resource "aws_iam_policy" "karpenter_controller" {
policy     = aws_iam_policy.karpenter_policy.policy
name       =  "${var.workspace}-karpenter-controller"
}
resource "aws_iam_role_policy_attachment" "karpenter_controller_attach" {
role       = aws_iam_role.karpenter_controller.name
policy_arn = aws_iam_policy.karpenter_controller.arn
}
resource "aws_iam_instance_profile" "karpenter" {
name = "${var.workspace}-KarpenterNodeInstanceProfile"
role = aws_iam_role.kubernetes-worker-role.name
}`
Versions:

Karpenter: v0.33.2:
Kubernetes Version (1.28):

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Can you share the status from your EC2NodeClass? Typically, you will see this error when Karpenter isn't able to discover your subnets and you don't have any zones that Karpenter can leverage for scheduling pods to instance types.

Hi @jonathan-innis I figured out the issue. The core issue was that the initial error message:
Could not schedule pod, incompatible with nodepool "np-244-nodepool", daemonset overhead={"cpu":"780m","memory":"1120Mi","pods":"6"}, no instance type satisfied resources
was misleading! The problem was that the EC2NodeClass manifest was referring to a role:
role: "${var.workspace}-karpenter-controller" rather than the InstanceProfile. In the official documentation: https://karpenter.sh/v0.33/concepts/nodeclasses/
It is mentioned that the InstanceProfile is optional and also mentions that you can specify either role  or InstanceProfile. In my case, it did not work with role, but worked with InstanceProfile, thus the error message did not provide me any useful information for debugging and instead led me in the other direction... It was purely resolved by experimenting.. I guess in this case the expected log output should mention something about the necessity of having InstanceProfile and maybe documentation should be updated?

@jonathan-innis  Another issue that I noticed, when I create NodePool and EC2NodeClass from the plain K8s yml manifests it works as expected. However, if I create NodePool and EC2NodeClass from the kubernetes_resource terraform resource, it will result in the same error even though the configuration is identical. Why it does not work with   kubernetes_resource ?

In my case, it did not work with role, but worked with InstanceProfile

@VladFCarsDevops are you using a private cluster?

However, if I create NodePool and EC2NodeClass from the kubernetes_resource terraform resource, it will result in the same error even though the configuration is identical

Is this when you are using role for the EC2NodeClass?

My EKS cluster endpoints are both Public and Private.
Yes! When I switched to using InstanceProfile instead of role in EC2NodeClass it fixed that misleading error. The official documentation gives you the option to set one of them, but not both as it results in error when applying. My role had almost full access permissions and was correctly attached, but this resulted in the errors I posted above until I switched to InstanceProfile

@VladFCarsDevops would you be will make to a PR for the documentation update?

@engedaam Sure, can you point me to the right location?

was misleading! The problem was that the EC2NodeClass manifest was referring to a role

@VladFCarsDevops This is surprising to me. From what I know about the current state of the code, we shouldn't return back a different response during scheduling when using an instance profile vs. using a role. It's a bit hard to parse the terraform manifests that you pasted above (also, unfortunately none of the maintainers on the karpenter team are TF experts). Do you have direct access to the cluster and if you do, could you post the YAML version of the EC2NodeClass and NodePool when you have the instance profile vs. when you have the role?
Also, as for surfacing this information better. We're currently talking about how we can improve observability for Karpenter using status conditions across all of our resources. This is talked about here: https://github.com/kubernetes-sigs/karpenter/issues/493. I'd imagine that surfacing a condition directly like InstanceProfileReady would have helped debug here.

was misleading! The problem was that the EC2NodeClass manifest was referring to a role

@VladFCarsDevops This is surprising to me. From what I know about the current state of the code, we shouldn't return back a different response during scheduling when using an instance profile vs. using a role. It's a bit hard to parse the terraform manifests that you pasted above (also, unfortunately, none of the maintainers on the karpenter team are TF experts). Do you have direct access to the cluster and if you do, could you post the YAML version of the EC2NodeClass and NodePool when you have the instance profile vs. when you have the role?
Also, as for surfacing this information better. We're currently talking about how we can improve observability for Karpenter using status conditions across all of our resources. This is talked about here: kubernetes-sigs/karpenter#493. I'd imagine that surfacing a condition directly like InstanceProfileReady would have helped debug here.

@jonathan-innis Oh I tried creating EC2NodeClass and NodePool with plain yamls and had the same errors up until I changed from role to an InstanceProfile, a friend of mine working at another company faced the same issue.  I think updating the instructions in the docs, will save a ton of time for people debugging a wrong log output when it has nothing to do with resources.

Oh I tried creating EC2NodeClass and NodePool with plain yamls and had the same errors up until I changed from role to an InstanceProfile

I don't disagree if this is really what is happening, but what I am trying to say is that these issues seem potentially unrelated to me. From looking over the code and reasoning about where we evaluate the instance profile and the role when it comes to making scheduling decisions, we don't have them affect scheduling decisions at all, which is why I'm thinking that it's odd that you are seeing "Could not schedule pod, incompatible with nodepool" and pointing back to the fact that you were using a role vs. an instance profile as the reason. Do you know if the EC2NodeClass that you were referencing was properly resolving the subnets or security groups that you were specifying by checking the status?
One common problem that we see is that subnets don't get resolved; therefore, the instance types aren't able to produce zones and so you will see the error that you pasted over here when you are scheduling pods

@VladFCarsDevops  can you please share your final ec2nc and where do you get the right instance-profile from?

@ahoehma `resource "kubectl_manifest" "nodepool" {
yaml_body = <<-YAML
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
name: default
spec:
template:
spec:
requirements:
- key: kubernetes.io/arch
operator: In
values: ["amd64"]
- key: kubernetes.io/os
operator: In
values: ["linux"]
- key: karpenter.sh/capacity-type
operator: In
values: ["on-demand"]
- key: karpenter.k8s.aws/instance-category
operator: In
values: ["c", "m", "r"]
- key: karpenter.k8s.aws/instance-generation
operator: Gt
values: ["2"]
nodeClassRef:
name: default
limits:
cpu: 1000
disruption:
consolidationPolicy: WhenUnderutilized
expireAfter: 24h
YAML
depends_on = [
helm_release.karpenter
]
}
resource "kubectl_manifest" "ec2nodeclass" {
yaml_body = <<-YAML
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
name: default
spec:
amiFamily: AL2
instanceProfile: ${var.workspace}-KarpenterNodeInstanceProfile
subnetSelectorTerms:
- tags:
karpenter.sh/discovery: "${var.workspace}"
securityGroupSelectorTerms:
- tags:
karpenter.sh/discovery: "${var.workspace}"
amiSelectorTerms:
- id: "${var.default_ami_id}"
blockDeviceMappings:
- deviceName: ${var.ebs_device_name}
ebs:
volumeSize: ${var.ebs_volume_size}
volumeType: ${var.ebs_volume_type}
encrypted: true
deleteOnTermination: true
tags: ${jsonencode(merge(data.aws_default_tags.current.tags, {"Name" = "${var.workspace}-Karpenter-autoscaled-node"}))}
YAML
depends_on = [
helm_release.karpenter
]
}
`


Words cut off after subscript (CO2-Einsparung becomes CO[newline])

Thanks a lot for realizing this fantastic project! I found this error when browsing through speeches on climate and energy. See the results of this sql select:
next=# select id, document_url, (regexp_match(speech_content, '.{40}CO.{40}'))[1]
next-# from open_discourse.speeches
next-# where speech_content ~ 'CO\n'
next-# limit 3;
   id    |                   document_url                    |                regexp_match
---------+---------------------------------------------------+--------------------------------------------
 1028335 | https://dip21.bundestag.de/dip21/btp/19/19115.pdf | . Dann kommt es zu einer Bepreisung von CO+
         |                                                   |                                           +
         |                                                   | ({4})                                     +
         |                                                   |                                           +
         |                                                   | Das ist ein Gesamtkonzept, das
 1028251 | https://dip21.bundestag.de/dip21/btp/19/19114.pdf | , festzustellen, bei welchem Betrag ein CO+
         |                                                   |                                           +
         |                                                   | ({0})                                     +
         |                                                   |                                           +
         |                                                   | Der kann sehr hoch sein, und da
 1028253 | https://dip21.bundestag.de/dip21/btp/19/19114.pdf | ahr wird berichtet werden, wie sich der CO+
         |                                                   |                                           +
         |                                                   | Ich bin fest davon überzeugt, dass das
(3 rows)

next=#

Seems to be some parsing issue, potentially happening if the subscript appears before a linebreak or an interjection?

Thanks for bringing this to our attention!
I just took a quick look at the XML-Structure where the error happened
Dann kommt es zu einer Bepreisung von CO2 im nationalen Emissionshandel.

I think the 2 is messing up the extraction logic somehow. The 19th and 20th election period logic needs a rework anyway, which will probably happen in #81.
For now I'll probably add the quick and dirty fix of just removing all s and s - I think this should work and also have no side effects.
If this fix works then this issue will be taken care of in #99.

Thanks for the quick response! A hunch from my brief attempt to understand the code:
https://github.com/open-discourse/open-discourse/blob/faa39e02ea1d315256b5c5b58601ca93587f718d/python/src/od_lib/05_electoral_term_19/01_extract_speeches_and_contributions_electoral_term_19.py#L368-L370
This is where text is extracted from
 tags in the speech content. However, content.text only parses the top level text. If it is conceivable that there are other nested tags, then it might make sense to use itertext() instead:
>>> import xml.etree.ElementTree as et
>>> xmlstring = '
A lot of CO2 is in the atmosphere.
'
>>> content = et.fromstring(xmlstring)
>>>
>>> print(content.text)
A lot of CO
>>>
>>> print(''.join(content.itertext()))
A lot of CO2 is in the atmosphere.
>>>
>>>

Nice catch! Thanks for pointing that out! That definitely is the problem.
However I just checked for unintended side-effects when using ''.join(content.itertext()) and so far I have found around 5.000 instances which is quite a lot for only 277 session, so for now I'll still only implement the quick and dirty fix and use the ''.join(content.itertext()) solution in #81 when reworking the whole logic.

This Issue should be fixed in the new release. Thanks again 👍


Bump docker image to v1.0.3 in action.yml

I guess you will either have to recreate the v1.0.3 tag and the release manually from the merged commit, or go forward with a v1.0.4 release but you will need to bump the version in action.yml again.

Doh 🤦♂, well spotted @jderrough.

Released a new version v1.0.4 to be sure the correct container is used.


image not found even with ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES set to YES

I'm trying to get react-native-sentry installed and I can't get past the "image not found" issue even though I've enabled ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES in the build settings and did a clean build. Any ideas?
I'm not sure what extra info would be useful for you to see but happy to upload anything that might help. I haven't added the uploading of debug symbols step yet since I'm just trying to get it working on the simulator.
Exception:
dyld: Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: [...]/Build/Products/Debug-iphonesimulator/Sentry.framework/Sentry
  Reason: image not found

Did you make sure you changed the build step?
https://docs.sentry.io/clients/react-native/#xcode-build-steps

Ah ok that fixed it. Sorry about that. Since the documentation in the error was in the section before I thought that it wasn't related.
Thanks!

We will try to improve that, glad it worked!


Run SObject masking from the SObjectMask record

Is your feature request related to a problem? Please describe.
The framework runs after a sandbox refresh if we setup the dedicated class during refresh process.
Some users may need to run the masking outside of a sandbox refresh process, they must be able to run it manually
Describe the solution you'd like
A button on the SObjectMask record to run the masking on this object.
User should be able to select between a full run (with all the SObjectMask records or just the recordId)
Describe alternatives you've considered
Run the batch from execute anonymous window.

Partially delivered with Launch Batch LWC


Issue: Code breaking when there is no change in a line

Suppose if there are 5lines of code to check difference and there are changes in Line:1,2,5. The library is helping to print the difference with line number for line:1,2 and when there is a break in line number i.e.,line5 here line number is not getting printed instead char count number is being printed
Error:

@dmsnell, can you see in screenshot that it is showing 85 as line number but there are only 7lines in the input

aha, thanks @ravellaabhinav - that's clear now, and I missed that.
what tool are you using there? the library itself doesn't really report line numbers, so that's why I was confused.

That's my UI and nothing much.
I used the same logic:

function diff_lineMode(text1, text2) {   var dmp = new diff_match_patch();   var a = dmp.diff_linesToChars_(text1, text2);   var lineText1 = a.chars1;   var lineText2 = a.chars2;   var lineArray = a.lineArray;   var diffs = dmp.diff_main(lineText1, lineText2, false);   dmp.diff_charsToLines_(diffs, lineArray);   return diffs; }

@ravellaabhinav this is a bit beyond me, and I'm guessing if you could share the code powering that UI it might help.
do you think it's possible there's a mismatch between what diff-match-patch is reporting and what is being interpreted as line counts?
what is the output of the call to diff-match-patch in the example behind the screenshot? can you paste the output directly here?


Fix typo on intro.md

Small typo on the documentation related to the "presentation" field on the example JSON.

QA Bypassed since change is very small

I was exploring integrating this with another business, and noticed the
typo.
Thanks.
On Thu, Aug 8, 2024 at 11:54 AM Everardo J. Barojas M. <
@.***> wrote:

@.**** approved this pull request.
Thanks for pointing this out @wilsotobianco
https://github.com/wilsotobianco
Question just out of curiosity - are you working on integrating?
In any case, thanks - we appreciate this PR very much.
In docs/intro.md
https://github.com/Prescrypto/prescrypto-docs/pull/41#discussion_r1710104398
:

@@ -29,7 +29,7 @@ Additionally, it is recommended adding the category "unstructured_drug"

// Example for a free medication
{
-  "presentation": "Algún Medicamento Libre", // Observe that "presentatio" field must be filled
+  "presentation": "Algún Medicamento Libre", // Observe that "presentation" field must be filled

[image: :godmode:]

—
Reply to this email directly, view it on GitHub
<https://github.com/Prescrypto/prescrypto-docs/pull/41#pullrequestreview-2228632703>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIONRJ4KHGVU2THKDFOYVTZQO5FNAVCNFSM6AAAAABJALI2KWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRYGYZTENZQGM>
.
You are receiving this because you were mentioned.Message ID:
<EMAIL_ADDRESS>

--
Wilmer Soto Capobianco
+1<PHONE_NUMBER>


[Bug]: only deleted volume be ignored when do dps cache transfer

Describe the bug
only deleted volume be ignored when do dps cache transfer, or else datanode cann't get cold volume info from master follower, and may trigger error log print

looking forward to the new version


Modify Chip text-overflow

Description

References #
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Hello - a quick few points:

Please always run npm run lint-css if you edit any of the SCSS files. It will re-sort all the properties alphabetically.
I don't think that storybook/src/index.html changed in this PR is intended to be used for tests like that.
Should the Modus chip container include a max-width?

Hello - a quick few points:

Please always run npm run lint-css if you edit any of the SCSS files. It will re-sort all the properties alphabetically.
I don't think that storybook/src/index.html changed in this PR is intended to be used for tests like that.
Should the Modus chip container include a max-width?

Noted @coliff , the max-eidth was set to try whether the chip ellipsis is getting triggered.

Hello - a quick few points:

Please always run npm run lint-css if you edit any of the SCSS files. It will re-sort all the properties alphabetically.
I don't think that storybook/src/index.html changed in this PR is intended to be used for tests like that.
Should the Modus chip container include a max-width?

@coliff Yes, we need a new configuration maxWidth. And it looks like the close icon size is too big

Hello - a quick few points:

Please always run npm run lint-css if you edit any of the SCSS files. It will re-sort all the properties alphabetically.
I don't think that storybook/src/index.html changed in this PR is intended to be used for tests like that.
Should the Modus chip container include a max-width?

@coliff Yes, we need a new configuration maxWidth. And it looks like the close icon size is too big

@coliff  Looks like on production the close icon is big, we have created a separate issue.

@ElishaSamPeterPrabhu Please reference the original issue link and update the PR description about how to test the fix.

#1771 is being fixed in this branch;
Test it by adding max-width property to the chip and the ellipsis are enabled when the value reaches end of the chip.


WebKit detection does not work for apps saved to the iPhone home screen

Downloaded Framer, ran it locally, pointed mobile Safari to it, runs great on mobile Safari.
The problem arises when I then tap the Share icon in mobile Safari and choose "Add to Home Screen". When I run the app from its new Home Screen icon, it throws the "only WebKit browsers are currently supported" error.
Dismissing the error, the app seems to work fine, but the error is pretty annoying to have on every page load.
I always try to run prototypes from a Home Screen icon to eliminate the mobile Safari browser chrome, which is otherwise in the way.

Fixed, see #19


Update targets parameter in cam

Update README so that the example code runs. Add correct target parameter name.

Hi, this seems already fixed in the master branch.


energy cli cannot be interupted by Control + c

The current issue exists because the pterm is blocking it. Not yet optimized


How to parse the crawled content?

Thanks for open-sourcing this awesome package!
I am currently experimenting with its functionalities, and want to learn how you parse the retrieved content.
Say on Crawl4AI.com, I wanted to crawl https://engineering.fb.com/2023/09/07/data-infrastructure/arcadia-end-to-end-ai-system-performance-simulator/, the retrieved content in markdown on the UI was pretty neat, but I couldn't seem to find a way to clean the HTML.
I did notice that the REST API template indicates "provider": "groq/llama3-70b-8192", does this mean you deploy an LLM for the raw HTML parsing?
Thanks!

@zukangy  I'm extremely sorry that I missed this issue, and I know it's been a few months since you posted this. Firstly, the library has changed enormously. We now have around 14,000 stars, and for what you're asking, you can basically combine our crawler with one of our large language model extraction strategies. I will leave the code here, and then you can see how it goes. In this code, you can see that we're using OpenAI, but technically, you can use any other provider as long as you have their API token or use a local LLM like Ollama, and then you can have fun with it. Please let me know if you have any issues, and again, I apologize for the delayed response.
async def extract_structured_data_using_llm(provider: str, api_token: str = None, extra_headers: Dict[str, str] = None):
    print(f"\n--- Extracting Structured Data with {provider} ---")

    if api_token is None and provider != "ollama":
        print(f"API token is required for {provider}. Skipping this example.")
        return

    extra_args = {}
    if extra_headers:
        extra_args["extra_headers"] = extra_headers

    async with AsyncWebCrawler(verbose=True) as crawler:
        result = await crawler.arun(
            url="https://openai.com/api/pricing/",
            word_count_threshold=1,
            extraction_strategy=LLMExtractionStrategy(
                provider=provider,
                api_token=api_token,
                schema=OpenAIModelFee.schema(),
                extraction_type="schema",
                instruction="""From the crawled content, extract all mentioned model names along with their fees for input and output tokens.
                Do not miss any models in the entire content. One extracted model JSON format should look like this:
                {"model_name": "GPT-4", "input_fee": "US$10.00 / 1M tokens", "output_fee": "US$30.00 / 1M tokens"}.""",
                extra_args=extra_args
            ),
            bypass_cache=True,
        )
        print(result.extracted_content)

async def main():
    await extract_structured_data_using_llm("huggingface/meta-llama/Meta-Llama-3.1-8B-Instruct", os.getenv("HUGGINGFACE_API_KEY"))
    await extract_structured_data_using_llm("openai/gpt-4", os.getenv("OPENAI_API_KEY"))
    await extract_structured_data_using_llm("ollama/llama3.2")


verify OnRunCompleted waits for pipeline to complete

an attempt to verify #488.
@Sibusten can you post a failing test or point to a repo where this is failing?  I updated a test that seems to verify OnRunCompleted is called only after the pipeline is executed.  I might be missing something.

Here's a reproduction of the issue which shows disposal before the command finishes
https://github.com/Sibusten/commanddotnet-488-repro

If you change the command in the test to async Task Do and await the Task.Delay you should see the issue. Right now the test is not waiting for the delay to finish because that task is not being awaited.


As a TaxonWorks data curator I would like to export to ITIS (https://itis.gov/) TWB import format

Target initial use is Odonata.
Import data format descriptions is here: NTWBimport_layout_dapp_20230214workingupdate.docx
Considerations:

It would be good if the ITIS team could map the nomenclature statuses they recognize to NOMEN concepts
It would be nice if the ITIS TWB would export in kind to a TaxonWorks formatted import (presently something like NOMEN/Castor batch load). Have not ascertained whether something is already possible.

Technical

Consider a Download API endpoint sensu https://github.com/SpeciesFileGroup/taxonworks/pull/2936

TODO:

[ ] Is there an official import mechanism into the TWB, or do files have to "manually" loaded?
[ ] If TaxonWorks develops this will ITIS recommend to stakeholders TaxonWorks as a viable alternative to TWB?

Re Considerations:
If you can give me the info or link to it that gives the "NOMEN concepts" for TW, I can take a shot at mapping relevant ITIS statuses to them.
Currently, those who want to get data from ITIS have the following options:

Full download of ITIS database in various formats
Download particular node of ITIS data as DwC-A or as ITIS TWB-specific import format (designed for old desktop Taxonomic WorkBench)

If there is a desire for a TW-specific export for arbitrary node(s) to facilitate use in TW we can consider it. David Mitchell would be key to bring in to discussion (I will point him here to consider). Or if the current DwC-A export from ITIS works, that's an option.
Re TODO:
Importing into the ITIS TWB is done from within the software itself. The TWB user has to invoke it and provide the incoming data file. I guess that is a "manual" load?
Re TW as a viable alternative to TWB, I assume you mean as a method of bringing data into ITIS (via TW, instead of having any given stakeholder use ITIS TWB for that purpose). Or did you mean as a method of bringing new data into BOTH ITIS and TW (that is: stakeholder->TW->TWB->ITIS vs. stakeholder->TWB->ITIS->TW)? If we get a reasonably robust system working, either are options very much worth considering.

Soon it might be possible to get a lot of the core ITIS data into TaxonWorks via the ChecklistBank API, although it might not cover all of the ITIS data because converting the ITIS schema to CoL data package format loses some of the information.

These acceptance criteria are written out as if one was trying to convert an ITIS usage and unacceptability_reason values into ColDP field status for in Name.tsv file, which uses NOMEN status values. Not exactly what this export functionality is doing, but it does provide the mapping.
Let me know if you are looking for something else.

Animalia (kingdom 5) and Protozoa (kingdom 2) are filled with http://purl.obolibrary.org/obo/NOMEN_0000224 for all ITIS names with a usage of valid
Archaea (kingdom 7) and Bacteria (kingdom 1) are filled with http://purl.obolibrary.org/obo/NOMEN_0000081 for all ITIS names with a usage of valid
Chromista (kingdom 6), Plantae (kingdom 3) and Fungi (kingdom 4) are filled with http://purl.obolibrary.org/obo/NOMEN_0000383 for ITIS names with a usage of valid
For the invalid/not accepted names, the values are specified in the table below per kingdom. The only value ITIS has that doesn't seem to be represented in NOMEN is pro parte. That's why the NOMEN value is null in the "table" below.

||Kingdoms||unacceptability_reason||status||
|5 and 2|homonym & junior synonym|http://purl.obolibrary.org/obo/NOMEN_0000287|
|5 and 2|junior homonym|http://purl.obolibrary.org/obo/NOMEN_0000289|
|5 and 2|junior synonym|http://purl.obolibrary.org/obo/NOMEN_0000276|
|5 and 2|misapplied|http://purl.obolibrary.org/obo/NOMEN_0000274|
|5 and 2|nomen dubium|http://purl.obolibrary.org/obo/NOMEN_0000225|
|5 and 2|nomen oblitum|http://purl.obolibrary.org/obo/NOMEN_0000284|
|5 and 2|original name/combination|http://purl.obolibrary.org/obo/NOMEN_0000132|
|5 and 2|other, see comments|http://purl.obolibrary.org/obo/NOMEN_0000272|
|5 and 2|pro parte| |
|5 and 2|subsequent name/combination|http://purl.obolibrary.org/obo/NOMEN_0000131|
|5 and 2|unavailable, incorrect orig. spelling|http://purl.obolibrary.org/obo/NOMEN_0000044|
|5 and 2|unavailable, literature misspelling|http://purl.obolibrary.org/obo/NOMEN_0000275|
|5 and 2|unavailable, nomen nudum|http://purl.obolibrary.org/obo/NOMEN_0000174|
|5 and 2|unavailable, other|http://purl.obolibrary.org/obo/NOMEN_0000168|
|5 and 2|unavailable, suppressed by ruling|http://purl.obolibrary.org/obo/NOMEN_0000219|
|5 and 2|unjustified emendation|http://purl.obolibrary.org/obo/NOMEN_0000278|
|5 and 2|unnecessary replacement|http://purl.obolibrary.org/obo/NOMEN_0000279|
|5 and 2|unspecified in provided data|http://purl.obolibrary.org/obo/NOMEN_0000272|
|7 and 1|homonym & junior synonym|http://purl.obolibrary.org/obo/NOMEN_0000102|
|7 and 1|junior homonym|http://purl.obolibrary.org/obo/NOMEN_0000097|
|7 and 1|junior synonym|http://purl.obolibrary.org/obo/NOMEN_0000096|
|7 and 1|misapplied|http://purl.obolibrary.org/obo/NOMEN_0000100|
|7 and 1|nomen dubium|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|nomen oblitum|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|original name/combination|http://purl.obolibrary.org/obo/NOMEN_0000132|
|7 and 1|other, see comments|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|pro parte| |
|7 and 1|subsequent name/combination|http://purl.obolibrary.org/obo/NOMEN_0000135|
|7 and 1|unavailable, incorrect orig. spelling|http://purl.obolibrary.org/obo/NOMEN_0000099|
|7 and 1|unavailable, literature misspelling|http://purl.obolibrary.org/obo/NOMEN_0000099|
|7 and 1|unavailable, nomen nudum|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|unavailable, other|http://purl.obolibrary.org/obo/NOMEN_0000083|
|7 and 1|unavailable, suppressed by ruling|http://purl.obolibrary.org/obo/NOMEN_0000104|
|7 and 1|unjustified emendation|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|unnecessary replacement|http://purl.obolibrary.org/obo/NOMEN_0000093|
|7 and 1|unspecified in provided data|http://purl.obolibrary.org/obo/NOMEN_0000093|
|6, 3 and 4|homonym (illegitimate)|http://purl.obolibrary.org/obo/NOMEN_0000016|
|6, 3 and 4|horticultural|http://purl.obolibrary.org/obo/NOMEN_0000130|
|6, 3 and 4|invalidly published, nomen nudum|http://purl.obolibrary.org/obo/NOMEN_0000379|
|6, 3 and 4|invalidly published, other|http://purl.obolibrary.org/obo/NOMEN_0000008|
|6, 3 and 4|misapplied|http://purl.obolibrary.org/obo/NOMEN_0000376|
|6, 3 and 4|orthographic variant (misspelling)|http://purl.obolibrary.org/obo/NOMEN_0000375|
|6, 3 and 4|other, see comments|http://purl.obolibrary.org/obo/NOMEN_0000369|
|6, 3 and 4|pro parte| |
|6, 3 and 4|rejected name|http://purl.obolibrary.org/obo/NOMEN_0000385|
|6, 3 and 4|superfluous renaming (illegitimate)|http://purl.obolibrary.org/obo/NOMEN_0000015|
|6, 3 and 4|synonym|http://purl.obolibrary.org/obo/NOMEN_0000372|
|6, 3 and 4|unspecified in provided data|http://purl.obolibrary.org/obo/NOMEN_0000093|

I know that in the above there will be NOMEN values missing, since it is written from an "ITIS-value-first" perspective. But hopefully this will give us a start. Some NOMEN values are not applicable because ITIS does not include viruses (so there are no ICVCN - International Code of Viral Classification and Nomenclature - NOMEN values) or names of cultivated plants (so no ICNCP - International Code of Nomenclature for Cultivated Plants - NOMEN values). I'll continue to look at NOMEN semantics and come up with ideas on what to do about them. For right now, I assume the largest gap is in the not available names. Right now my recommendation is to make those either invalid or not accepted (based on kingdom) with a unacceptability_reason of other, see comments.


Excluding times from weekly rule not working

I have a schedule set up like so:
IceCube::Schedule.new(Time.zone.local(2011, 6, 14, 14, 0, 0)).tap do |schedule|
  schedule.add_recurrence_rule IceCube::Rule.weekly.day(:tuesday, :thursday)
  schedule.add_exception_time Time.zone.local(2011, 12, 27, 14, 0, 0)
end

But it doesn't seem to respect the exception time, and insists the next occurence is exactly the same time as the exception.

I was unable to duplicate this in a test.  Are you using >= v0.7?  Can you provide some more details - spec attached

I'm experiencing the same behavior with 0.7.6, and I think I know why at least for my case. I'm adding a recurrence rule just like above, but for my exception I specified just a date, instead of a date with time. If I include the exact time of the originally scheduled occurrence then everything works fine, and the occurrence is excluded.
I don't know if this is the desired behavior or not. If it is, having the alias Schedule#add_exception_date is a bit misleading, as the only way you can exclude an occurrence is by specifying the exact date and time.
It looks like the problem is in either SingleOccurrenceRule#next_time or Rule#on? next_time returns the exact date/time of the event, while on? tries to match exactly to the exception value. Which of course means if you use just a date, it will fail. I could be completely wrong though. I just did a quick glance at the code, and that jumped out, but I might be missing something somewhere else.


Automated Prometheus version update 0.63.0-45.10.1

Automated changes by the cron-prometheus-update GitHub action
Adds [Prometheus add-on](https://kurl.sh/docs/add-ons/prometheus) version 0.63.0-45.10.1.

Just a flake in a old targeted OS:

It seems ok to fly.


Update existing network, return boolean from connectTo function

Updating network removes the need to loop through the existing networks twice.
This also resolves the issue of creating duplicate SSIDs.
Returned a boolean from connectTo which gives feedback as to whether all of the steps within connectTo were successful (still need to watch for change of SSID externally).

Thanks mitch104 for your collaboration!


BUG: fillna maximum recursion depth exceeded in cmp (GH18159).

[x] closes #18159
[x] tests passed
[x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[x] whatsnew entry

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   91.38%   91.38%
=======================================
  Files         163      163
  Lines       50068    50068
=======================================
  Hits        45755    45755
  Misses       4313     4313

Flag
Coverage Δ

#multiple
89.19% <100%> (ø)
:arrow_up:

#single
40.36% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pandas/core/internals.py
94.54% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dac633...254193b. Read the comment docs.

Squash commits please, then proceed with PR to upstream.


Consistency & clarity across related pages could be increased

In this page, the "Prepare the PerfSDKSample solution for multi-user testing" step 4 doesn't provide the same level of detailed instruction to modify the "Test settings" as https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/perf-test/perfsdk-tutorial-lbd does.  In that tutorial, it's clearer that vsonline.testsettings is a solution file: "In your solution files, double-click the vsonline.testsettings file to modify the test settings."  If that guide was one of the pre-requisites for this one, I think the briefer description here would be reasonable, but as it is, consistency is probably desirable.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa57e22a-a4d4-a433-8cf8-2e1257083a10
Version Independent ID: 1251373f-3092-0825-cd85-ab49bbad9f71
Content: Multi-user testing with the Performance SDK and a local test controller - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/fin-ops-core/dev-itpro/perf-test/multi-user-testing-local-test-controller.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @hasaid
Microsoft Alias: jujoh

Thank you for your suggestion. @hasaid, can you please take a look at this feedback?

@hasaid updated the topic. Thanks.


Add an optional property of management port for Spring actuator module

Motivation:
To avoid a conflict between armeria-spring-boot-actuator port and spring-boot-actuator port when using management.server.port.
Modifications:

Add armeria.management.server.port property

Result:

Closes #3685
Users can set a port to armeria.management.server.port for exposing armeria spring actuator
Output the warn log when users use management.server.port

BTW, are we still need armeria.management.server.port to solve the port collision? I guess armeria.internal-services.port can be used instead for that.
For example:
management.server.port = -1

armeria:
  internal-services:
    port: 18080
    include: metrics, health, actuator

Ah, @ikhoon is right. I guess you can use the armeria.internal-services.port instead of armeria.management.server.port.

Thanks, @ta7uw for your enthusiasm for Armeria project. I should've closed #3685 when internal-service feature was added.
Do you think armeria.management.server.port could be replaced with armeria.internal-services.port?

I think it's enough to just use armeria.internal-services.port.


IPython kernel restart failed ERROR: SPARK_HOME envar not defined,SPARK_HOME envar not defined

Unable to run Pyspark tutorial on Beaker Notepad chrome.

you need to set that environment variable, as per the instructions in the notebook.


missing file database.g.dart in examples folder

Seems like the database.g.dart is missing
here is the complete log when I try to run the sample.
Compiler message:
lib/database.dart:9:6: Error: Error when reading 'lib/database.g.dart': No such file or directory
part 'database.g.dart';
^
lib/database.dart:9:6: Error: Can't use 'lib/database.g.dart' as a part, because it has no 'part of' declaration.
part 'database.g.dart';
^
lib/main.dart:9:26: Error: Getter not found: '$FloorFlutterDatabase'.
final database = await $FloorFlutterDatabase
^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception: Errors during snapshot creation: null
Failed to build bundle.
Error launching application on iPhone 11.

@cassioseffrin, first you need to generate this file. Just run in project folder flutter packages pub run build_runner build.

I just realize that I have forget one step:
flutter packages pub run build_runner build.
This issue can be closed!

hi! I am still facing the issue even after running command of  flutter packages pub run build_runner build in terminal. looks like file is generated in .dart_tool but I can't access it in main file.
getIt.registerSingletonAsync(
() async => FloorAppDatabase.databaseBuilder('notes.db').build());
Here is the line of code


Upgrade deps

coverage: 78.76% (-0.02%) from 78.777%
when pulling 2f3810e77f6f5f1e82175f1612e5b0a62d7e0747 on dissoupov
into 597f54b9559428070e6909c605393edcd3131090 on main.


Set SSL Client Certificate

Hi, is there a way to set a specific Certificate (X509Certificate) for a SSL connection? I see options to set one but it requires a InputStream which I don't have. In the KeyStore I have 3 certificates and I need to be able to use a specific one. Or maybe a SSLContext like JSOUP uses
  SSLContext sc = SSLContext.getInstance("TLS");   sc.init(new X509ExtendedKeyManager[] {km}, null, null);   Jsoup.connect(URL).sslSocketFactory(sc.getSocketFactory()).ignoreContentType(true).execute();

for filtering out you can have a look at the comment of method setSSLClientCertificate

Yeah I know. The problem is that if I load the entire KeyStore, it chooses the first Certificate in that KeyStore ... if I have multiple Certificates well I can't choose a specific one (they are all valid and usable). I have multiple certificates that I use for different websites, and of course they are on a USB stick so I can't store them and build another KeyStore.

but you can wrap the key store and provide only the one required

but i will have a look again, maybe we can provide a more convenient way to do that, or maybe we can have a default impl for that use case

Implement a keystore, that forwards most of the methods to the containing keystore but filters the certificates.
See the wrapper pattern....

@alexvrv

you are (more or less :-)) right - i think the naming of the method is confusing (e.g. setSSLClientCertificate should be named setSSLClientCertificateKeyStore)
i like to change this a bit and provide more documentation

Can we do this together - i will update the impl and the documentation and you do the review and testing?

@alexvrv ok my hint with the wrapped keystore was totally wrong - there is no way to implement such a wrapper.
Instead you can create a new (in memory) KeyStore and add only the certificates you like to use.
see https://www.baeldung.com/java-keystore for some hints how to do this
Then you set this KeyStore using WebClientOptions.setSSLClientCertificateKeyStore(KeyStore, char[])
Does this work for you?

@alexvrv

you are (more or less :-)) right - i think the naming of the method is confusing (e.g. setSSLClientCertificate should be named setSSLClientCertificateKeyStore)
i like to change this a bit and provide more documentation

Can we do this together - i will update the impl and the documentation and you do the review and testing?

Sure!

@alexvrv ok my hint with the wrapped keystore was totally wrong - there is no way to implement such a wrapper.
Instead you can create a new (in memory) KeyStore and add only the certificates you like to use.
see https://www.baeldung.com/java-keystore for some hints how to do this
Then you set this KeyStore using WebClientOptions.setSSLClientCertificateKeyStore(KeyStore, char[])
Does this work for you?

I've tried this but it works only with PKCS12. I have PKCS11 (certificates on a USB memory stick) which cannot be stored... I can't save the private key and move it into a "in memory" keystore :(

@alexvrv maybe is still on the wrong path:
My current understanding is

you have an usb stick holding some (3) PKCS11certificates - but in one 'file'
you are able to read the certificates together into one (java) key store

there is no way to read only one certificate

you like to provide only one certificate to HtmlUnit - not the whole key store with all three

Correct?

and the solution from #623 does not work - reading all three and then remove the not used ones?

@alexvrv maybe is still on the wrong path:
My current understanding is

you have an usb stick holding some (3) PKCS11certificates - but in one 'file'

you are able to read the certificates together into one (java) key store

there is no way to read only one certificate

you like to provide only one certificate to HtmlUnit - not the whole key store with all three

Correct?

I have 3 USB sticks, each having their own certificate. The rest is correct.

and the solution from #623 does not work - reading all three and then remove the not used ones?

This method kind of works. I can delete the not used certificates, but they get deleted for good. If I want to use another certificate (that I've deleted earlier) I need to reinstall it xD

Any news about this? :(

made a new snapshot build - @alexvrv please have a look at the impl and please try

Snapshot 4.5.0 isn't working as intended in my PR ....

Some more details please

I don't have much more details other than the, using the SNAPSHOT it doesn't set the SSLContext that i'm providing ... works perfectly with my changes that I've submitted in the PR

there was also a stupid error in my code - snapshot is updated

I've just refreshed the dependencies and tested. Works perfectly! Thank you!

Ok, great will close this. Many thanks for your contribution.