Some feature requests

Is your feature request related to a problem? Please describe.

You cannot exit the program if you have unsaved changes, which is good, but there is no prompt about it and people have to guess to save first.
Adding a component from Primo Library needs an unnecessary extra step: first add to Site Library and then add that to the Page
You cannot edit the code of content block, you have to go to Components > Create to create a custom component
Drag'n'drop on images is not working and I doubt this is a Windows only bug
Ability to export/import custom components

Describe the solution you'd like

Any kind of prompt/alert/warning would be ok
Merging the 2 libraries would be wrong as you need to customize your local component copies, but that extra step is confusing. Better have the action for Primo Library components changed to Add to Page which would also add it to the Site Library.
Make it so the content block is a custom component by default and give it a random name like block_34gjh2g43 in the Site Library
Enable drag'n'drop for images, check here
Plain json just like how sites are saved in %AppData%\Roaming\primo\sites is ok

Thanks for this @rallisf1! I'm gonna convert this into a discussion and break out the individual items into separate issues


Add GPU support for CRI environment with nvidia container runtime. #269

#269
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Fixed comments

rebased

Shipped!

I have checked, tests have passed successfully. So, let fix the comment and I will merge this PR

Fixed a comment

Shipped!


Remvoed params which are fine left with defaults

Resolves #176

This probs also closes #58

Cool man; I'll take another go at running the CI job for this. As you've seen already it was failing :(


Vagrant configuration for Dexter Server and README.md

For developers, local development environment is essential. I add Vagrantfile to make to set up easily and provide the same dev environment for the developers.
README instruction are added accordingly.

Thank you for the contribution. I will review the codes.


ability to include own window titles and media icon without directly changing index.ts for both

I think this is a necessary feature as users might have different choices of browsers, applications, terminals and media players (as for myself i prefer to use foot and thorium over kitty and firefox sometimes)
I have to edit the index.ts for both the bar modules everytime doing git pull as they get overwrite when there is a change of code
maybe sourcing another file which has all the window titles and icons for specific media player into the index.ts so that users can have their custom applications show with icons and correct window title

@rishav12s The Window Title Mappings option in Configuration > Bar > Window Titles now has an input to let users define this. The option has a link to the wiki on how to define custom mappings as well: https://hyprpanel.com/configuration/panel.html#window-title-mappings


Use time-based required tasks list in release

https://issues.redhat.com/browse/HACBS-1238
Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

Still a couple things needed to finalize https://issues.redhat.com/browse/HACBS-1238:

Docs reference to time-based required tasks list.
Apply the same logic for pipeline definition validation.

But I think this PR is self-contained, and could be merged once reviewed.


Paket 5.1 Log4net 2.0.3 client version

Description
We are using log4net version 2.0.3 (yes...this is old...we know!)
We target all projects to .net 4.5 (again, old....we know!)
With paket 4, we got log4net net40-full
We now get log4net net40-client being referenced.
This is odd, as the target framework is v4.5 not a client profile version.
Repro steps

Create project targeting net 4.5
Add log4net 2.0.3 as dependecy
Set frameworks in paket.dependencies to net45 only
run paket install with 4.x
run paket install with 5.x

Expected behavior
No change to the version of log4net being used
Actual behavior
Log4net changes from full to client
Known workarounds
Do not upgrade to paket 5.x....

https://docs.microsoft.com/en-us/dotnet/framework/deployment/client-profile
Client profile should no longer exist starting with 4.5
Can you post the diff paket is doing on your project-file you feel is suspicious?

log4net 2.0.3 does not have a net45 version, so uses the net40 version.
it used to use the net40-full
but now uses net40-client


STEP_6

JRTB-5: added ability to subscribe on group
JRTB-6: added ability to see the list of the group subscription.

-[x] Docs change / refactoring / dependency upgrade
-[ ] Bug fix (non-breaking change which fixes an issue)
-[x] New feature (non-breaking change which adds functionally)
-[ ] Breaking change (fix or feature that would cause existing functionality to change)

added in #23 pull-request


'triggers' is plural. Does that mean we can have more than one?

I noticed while working in the JSON that triggers was plural. Made me wonder if I can have two of them. The schema, turns out, does allow you to do this. It even deployed out to Azure.
However, upon viewing the Logic App in Azure, designer view refused to load and kicked me back out to code view (no errors or complaints, though).
If in fact multiple triggers are a thing, it'd be good to see some examples & docs around when/why one might take this approach.

It is a limitation of the Logic Apps designer that it does not allow more than one trigger.  However, the Logic Apps runtime supports more than one trigger.

sweet; would be cool to see some docs/samples on this

The extension supports multiple triggers so closing this.  I've asked PMs about documenting this though be advised that support for multiple triggers is being considered for deprecation.


CRYP-170: create use case diagram

JIRA: https://cryptify.atlassian.net/browse/CRYP-170

At a first glance, it's missing sign up, sign in, sign out. There's probably a few more missing that I'm forgetting about right now but this is a good start.
On a side note, how detailed are the use case diagram expected to be? Should we have 1 use case for main feature?

SIgn in, sign up, and sign out aren't use cases they are costraints on the system i.e. non functional requirements. The use cases are like what the user can do with the system. No one "wants" to sign up or sign in, they want to check their wallets, but they have to sign in to do that.
There are much better explanations here https://softwareengineering.stackexchange.com/questions/370739/when-log-in-should-be-a-use-case-and-when-not
In general I think use case should be high level enough that there isn't clutter, like I don't think having a specific use case for "remove wallet" would make sense that's why I bundle them up together.


Update node.js in the CircleCI config

Tests are failing, having a look

Bumped nock to 11.0.0-beta.13 as per https://github.com/sindresorhus/got/issues/817


Add loading circle for when sending reactions

I'm not sure I want to do this actually. I'm going to close unless someone really really wants it. Apple doesn't do this, so I don't think we should


GCE backend returns googleapi: Error 400: Parse Error, parseError

This sometimes but not always happens when I run a benchmark that puts a couple hundred files.
I did some research but couldn't quite figure out what the cause might be.  I will just try update our GCE dependencies and see if that solves the problem.

Update: updating the dependencies doesn't seem to solve the problem.

Update: This page seems to imply that GCS can have problems with burst traffic (e.g. > 1000 writes per second): https://cloud.google.com/storage/docs/best-practices#traffic

Looks like this issue has been identified.  Basically we need to compile Pachyderm with golang 1.7.3 or above.  Reopening so we remember to do that.
https://github.com/GoogleCloudPlatform/google-cloud-go/issues/389#issuecomment-255881983


Fix RGBA error with plot_survival

Address issue #221, by which an error is raised on lifelines version >= <IP_ADDRESS>.  Though, to be fair, it's not clear if the error is due to matplotlib or lifelines.
We will fix the error for those versions of lifelines & incrementing the requirements to depend on more recent versions of lifelines.

Coverage decreased (-0.08%) to 56.871% when pulling de16b7d17048b8eff58fe651a77a0c7e1c190d08 on fix-issue-221-rebase into 31545c4b03d9a1edd9cc543ac1f863a140e88cd8 on master.

This is a good point - increasing the version to 0.10+ would also fix this. Though in general I try to keep requirements as flexible as possible in case of conflicts. What do you think, would it be cleaner to force a more recent version?


Can't "gcloud ssh" into docker-machine

Google Compute Engine (GCE) automates key generation for approved users of the project to which instances are scoped using Google Developers Console and the gcloud CLI. This permits any authenticated user of the project to access|manipulate instances. Unfortunately, it appears docker-machine breaks Google's mechanism:
docker-machine create [INSTANCE-NAME] \
--driver google \
--google-project [MY-PROJECT-ID] \
--google-zone [GOOGLE-ZONE]

Correctly permits:
docker-machine ssh [INSTANCE-NAME]

However, a Google developer would expect to be able to:
gcloud compute --project [MY-PROJECT-ID] ssh --zone [GOOGLE-ZONE] [INSTANCE-NAME]

This errors:
Warning: Permanently added 'XX.XX.XX.XX' (ECDSA) to the list of known hosts.
Permission denied (publickey).
ERROR: (gcloud.compute.ssh) [/usr/bin/ssh] exited with return code [255]. See https://cloud.google.com/compute/docs/troubleshooting#ssherrors for troubleshooting hints.

This is because, docker-machine has created an sshKeys entry in the instance's metadata for docker-user. The act of adding a single user manually, stops gcloud from managing user credentials. See here:
https://cloud.google.com/compute/docs/instances/managing-ssh-keys
To revert to gcloud management of user credentials (but break docker-machine's credential management), it's possible to delete the ssKeys entry for the instance:
gcloud compute instances remove-metadata [INSTANCE-NAME] --keys sshKeys

Or, edit the keys in the console:
https://console.developers.google.com/project/[MY-PROJECT-ID]/compute/metadata/sshKeys
Once this is done, it's possible to ssh using gcloud ssh.
Alternatively, it should be possible to force gcloud to use the docker-machine generated credentials but I believe because of the incorrect format, this does not work. The docker-machine created credentials for docker-user appear to not be in this format and I was unable to get this to work:
https://cloud.google.com/compute/docs/instances/managing-ssh-keys#ssh_key_format
https://cloud.google.com/compute/docs/instances/connecting-to-instance#gcloudownkeys
Full disclosure: I'm a Google employee in cloud but not a developer

@DazWilkin Have you tried with Docker Machine 0.6.0-rc? I don't think that anything was fixed but at least we would get a refresh.

Will try it next week once back from vacation.

The issue appears to be resolved but I don't understand why :-(
I'm able to  create a machine, docker-machine ssh and gcloud ssh into it without problem:
docker-machine.exe version 0.6.0-rc1, build 174e390
Docker version 1.10.0-rc2, build c1cdc6e

Some would say magic?

I changed the way ssh key metadata management is done. This might have an impact. I'll check further tomorrow to give you a better answer!

@DazWilkin The only thing that changed is that with https://github.com/docker/machine/commit/b995a4d65a3e666b6cdec79036db0379b3d58b69, ssh metadata are better formed.
Anyways, happy to see everything is working ok


About the data split of NQ 320K

Hi, Dr. Zhuang.
Thanks for your contribution again.
I've successfully conducted some experiments on MSMARCO with DSI-QG.
To keep going, I plan to conduct the experiments on NQ dataset.
The only thing I want to make sure is:
Refer to NQ's huggingface, which says the data split is train: 307373 | dev: 7830.
These values are quite close to the amount you mentioned in your work: "The NQ 320k dataset has ≈307k training query-document pairs and ≈8k dev query-document pairs."
May I treat 307373≈307k and 7830≈8k?
(By the way, I am also curious about the reason for the number, dev: 6980, in MSMARCO-100K dataset.)
Thanks for your confirmation in advanced!

To be honest, Im also not quite sure why they call it NQ320k 😄.
For msmarco, dev 6980 is actually a subset of full dev (The full dev is very big). But this subset is used for MSMARCO leaderbord submissions thus people just use this subset for papers.
Check out this web page: https://microsoft.github.io/msmarco/Datasets.html

Oh, I see. I think it's a rough number XD.
So may I ensure that you use the same setting as NQ's huggingface says?
And for MSMARCO:
Thanks for your introduction; it helped me to understand your data processing further!
But I am still curious about how you determine the number 6980.
Thanks again, you just respond as fast as usual!

yeah, I just use the NQ dataset from huggingface.
I did not decide the number of 6980, the official msmarco passage dev small has 6980 queries, so I just used all of them by default.

Thanks for the confirmation!!
But I only found dev rather than dev-small, did you mean you reserve the dev rows that are also in train-small?

is it not in the Queries link? I don't exactly remember where to find it, but it is the official dev set. Maybe you can use ir_dataset to download it: https://ir-datasets.com/msmarco-passage.html#msmarco-passage

it is probably in this link collectionandqueries.tar.gz

Thanks for the patient explanation and the links. I finally saw the 6.8K in the links XD

Hi, Dr. Zhuang.
Sorry to bother you again, and I hope you are doing well!
According to your information, I set --train_num to 307373 and --eval_num to 7830 and tried reproducing the experiment on NQ-320K.
The preprocessing code is modified from your old repo (The reason I modified it is to follow the new preprocessing codes).
However, I couldn't reach the score 82.36 for t5-base. I only reach 58.24.
I've checked the training pairs and it seems normal with the QG ckpt mentioned in #12 .
I also noticed that a document in NQ could be longer than max_seq_len for a transformer-based encoder.
I would like to know did you do any other preprocessing for the training data and dev data?
Thanks in advance.
 Maybe try to increase the number to 50

Thanks for the advice. Before I start reproducing, will this change increase performance by 20%, according to your gut feeling?
Since my computation resources are not very generous, I think I should run this script more carefully.

according to my experience more generated queries is always better, but indeed it will take even longer to converge..

Alright ... This is life ... 😢

Hi, Dr. Zhuang.
I've finished the training with query generation number = 50.
Compared to HIT@10 = 58.24 from query generation number = 10, it makes progress to HIT@10 = 69.12.
However, it still doesn't reach HIT@10 = 82.36.
Should I try:

Increase the query generation number to 100
CE reranker (but may I acquire the training args for NQ dataset? As for training data, I think I could generate them according to DPR format by myself.)

Thanks for the passionate reply!

how many steps you have trained?
maybe go ahead with 100 queries

there is no need to use CE when use 100 queries

Ok. I'll try 100 queries first. Thanks for the confirmation!
Nevertheless, I have one more concern: what's the --max_length you used to generate queries in NQ Dataset?
Thanks again!

@hi-i-m-GTooth Hi GTooth.
Thanks for showing your reproduced result.
I have tried to run the code on another dataset with less size than NQ320k, but after 80k steps, hit@1 just reaches 0.03. I don't know why it is.
Your figure shows that when training 50k steps, the hit@1 already achieves 0.2.  Running 50k steps means just 2 or 3 epochs, since it is about 228k unique documents in NQ320K, and if you generate 10 queries for each docs, there will be 11 * 228k training samples in total. Is my understanding correct?
Thanks for your confirmation in advance!

hi @yuxiang-guo
In my code, I actually did not use the original doc at all. So that will be 10 * 228k training samples/
If you are getting very low sores I suggest you have a look at generated queries. Do they look correct?

Hi @yuxiang-guo ,
@ArvinZhuang already confirmed it XD.
But I want to add:
According to my experience, batch_size is also a critical factor.
You could also try to increase the batch_size or gradient_accumulation_steps.


GEOPM agent/endpoint integration with slurm

Integrate the agent and enpoint interfaces into a slurm plugin.  Related to issue #10, but this is in reference to the specific work being done for SLURM by @r-sakamoto here:
https://github.com/r-sakamoto/power-slurm
The end goal is to have slurmd call into the interfaces documented here:
https://geopm.github.io/man/geopm_agent_c.3.html
https://geopm.github.io/man/geopm_endpoint_c.3.html

Also related to #610.  If possible, open a new issue for endpoint integration and close this issue @cmcantalupo

Now broken down.


Make all args required in convert_lit_checkpoint

This PR makes all arguments of convert_lit_checkpoint required. More context as to why is provided below.
The default output during finetuning saves checkpoints in the shown manner.

This structure does not set the model name correctly when using the current method shown below.
def convert_lit_checkpoint(
    *,
    checkpoint_name: str,
    checkpoint_dir: Path = Path("checkpoints/tiiuae/falcon-7b"),
    model_name: Optional[str] = None,
) -> None:
    if model_name is None:
        model_name = checkpoint_dir.name
    config = Config.from_name(model_name)

Making all args required allows users to convert exactly the finetuned model they intend to convert with something similar to:
python scripts/convert_lit_checkpoint.py \
    --checkpoint_name lit_model_adapter_finetuned.pth  \
    --checkpoint_dir out/adapter_v2/alpaca/ \
    --model_name Llama-2-7b-chat-hf

Apologies for the changes failing. Trying to get this done from an iPad while in-flight.

I think this script does not finish yet.
For example, I post "python scripts/convert_lit_checkpoint.py --checkpoint_name out/dolly/open_llama_3b/lora/lit_model_lora_finetuned.pth --model_name open_llama_3b --out_dir .   "
and it output "KeyError: 'transformer.h.{}.attn.attn.lora_A'"
The blog for this script does not right either.
I think they are still working on this.


Implementation in a docker  container.

Hello,
First of all, congrats for the solution. Is quite complete and well done!
I am trying to deploy my solution using the Net.Contrib into a docker/container environment and I am having a hard time with the SqlServer.Types.
It keeps hitting the " Unable to load shared library 'SqlServerSpatial140.dll' or one of its dependencies" error.
I have tried put the dll in the app folder, in the usr/bin folder. everywhere.
Have you guys faced a scenario like this? Could you share me some wisdom?
Thanks in advance.

Hi @rodriguesmvinicius, yes it's sometimes a headache.
Did you try, in your top level program, to run the following code ?
SqlServerTypes.Utilities.LoadNativeAssemblies(AppDomain.CurrentDomain.BaseDirectory);
AppDomain.CurrentDomain.BaseDirectory can be any directory where the sql bits files resides.


feat: Do not convert table names & permission roles to snake case when exporting metadata.

Resolve #143

Codecov Report

Merging #144 (412e25b) into main (e7d75b0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #144   +/-   ##
=========================================
  Coverage     94.66%   94.66%
  Complexity      603      603
=========================================
  Files           132      132
  Lines          2118     2118
=========================================
  Hits           2005     2005
  Misses          113      113

Flag
Coverage Δ

phpunit
94.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/metadata/src/YamlOperator.php
95.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d75b0...412e25b. Read the comment docs.

Thank you @vcttai!


Edit and Continue failed in ASP.NET Core web project

Describe the bug
Error CS8055: "Cannot emit debug information for a source text without encoding." is reported when editing ASP.NET Core web project while debugging.
Reported as VS feedback: https://developercommunity.visualstudio.com/content/problem/414645/edit-and-continue-not-working-with-aspnet.html.
Internal bug 736856.
To Reproduce

Create a C# ASP.NET Core Web Application (MVC). ASP.NET Core 3.0.
Set a break point in Index method in HomeController.cs.

public IActionResult Index()
{
   // int i = 1;
   return View();
}

F5 (The platform is AnyCPU).
Uncomment // int i = 1;
F10

Expected
ENC is successful.
Actual
ENC failed with error CS8055: "Cannot emit debug information for a source text without encoding."

I added a comment line inside a method. There are no compile errors, but I get  a dialog that states "Edits were made which cannot be compiled. Execution cannot continue until the compile errors are fixed."
When I click the "Edit"  button on the dialog then I see the error described above, CS8055.

Thanks for contacting us, @tmat.
@NTaylorMullen, can you please look into this? Thanks!

This is something that @BillHiebert should look at not @NTaylorMullen

I'm pretty sure we don't support Edit and Continue in .NET Core projects.

@DamianEdwards I tried a .NET Core console application and it seems to work there. I'll need to do some follow up to figure out why it doesn't work for ASP.NET Core.

@DamianEdwards, @tmat the reason it doesn't work for ASP.NET Core is because it has the debugger attach to the running process. The good news is that the debugging team added support for ENC in attach scenarios a couple of versions ago by setting the environment variable COMPLUS_ForceENC=1 before starting the process. I verified this works. I reactivated the original VS customer feedback item so you can close this issue

Done

So is this something that will be fixed in the next update?

@BillHiebert Thanks for looking into this. The error message is not reported by the debugger not being able to perform the edit (that would be indicated by a dialog box), but by Roslyn APIs used to create debuggable compilations with SourceText objects that do not specify encoding. So it seems that multiple fixes might be needed in order to make this scenario work.

@tmat - setting the environment variable seems to work but more testing may be required to verify all scenarios.
Note that a simple workaround is to add COMPLUS_ForceENC = 1 to the environment variables section in launchsettings.json.

FYI, I added that workaround to my launchsettings.json and it did not make any difference in my experience.

I'm facing the exact same issue and it is quite frustrating.
any updates or possible work-around will be much appreciated...

I'm also facing this same issue. It's also tracked here https://developercommunity.visualstudio.com/content/problem/414645/edit-and-continue-not-working-with-aspnet.html
Bill Hiebert says "There is an issue in the way compiled razor page classes are being added which is preventing ENC from working" and I can confirm that that's what it looks like in my project. In my project the error message is related to partials like for example "_MenuPartial.g.cs"
I don't know of any workarounds since COMPLUS_ForceENC is not working for me either.

I think the issue should be reopened. I set COMPLUS_ForceENC = 1 in launchSettings.json, but it doesn't work...☹

It worker for me in VS2017 but after updating to VS2019 it stopped working

This is fixed in VS 2019 16.1 Preview 1

This is fixed in VS 2019 16.1 Preview 1

Na, it's not (really) fixed. I'm using VS 2019 16.1 Preview 2 and the only thing that works is starting the application with STRG-F5 (Without the debugger). Still you have to press F5 in the browser to see the changes, however. Running the application using F5 won't work.
Check also https://github.com/aspnet/AspNetCore/issues/11489 and https://github.com/aspnet/AspNetCore/issues/5456.
Quote from @danroth27 from https://github.com/aspnet/AspNetCore/issues/11489#issuecomment-505102412:

To clarify, if you're using the latest Visual Studio Preview (https://visualstudio.com/preview) you should be able to run the app without debugging (Ctrl-F5), edit files in the project including .razor files, and then VS will rebuild and restart the app automatically so that you can just refresh the browser to see the change. If this isn't working for you with the latest bits please let us know!

@SeppPenner It sounds like you're still hitting issues in VS. Please try out the latest VS preview (https://visualstudio.com/preview) and if the problem can still be reproduced please open a new GitHub issue with a detailed description of the problem you are hitting and we'll take a look.

@danroth27 It's alright. What I was trying to say is: Running without the debugger works properly (As I told in https://github.com/aspnet/AspNetCore/issues/11489#issuecomment-505330487). Like you pointed out in the comment I quoted above: The support for complete live reload (https://github.com/aspnet/AspNetCore/issues/5456) is not yet done.
I don't have other issues, I'm just waiting for https://github.com/aspnet/AspNetCore/issues/5456 to be done :)

Have this issue after updating VS Community 2019

I think you have to start Visual Studio having this env var setup, since the debugger is part of VS and has to be properly setup at its startup.


[condenast] fix extraction and add support for other sites

Should be r'var\s+video....

i changed it.

Thanks, cherry-picked.


pamixer: 1.3.1 -> 1.4

Motivation for this change
fixing updates @r-ryantm has trouble doing.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @
[2 built, 0.0 MiB DL]
1 package were build:
pamixer

@GrahamcOfBorg build pamixer


Add Zribbble to showcase

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

By analyzing the blame information on this pull request, we identified @lacker and @alexleventer to be potential reviewers.

Hey, thank you for sending a pull requet. I forget but did you submit this before and someone asked for there to be better content? I feel bad if so because we had to change the guidelines recently and they are now:
1/ An English-language news article discussing the app, built either by a funded startup or for a public company
2/ An English-language technical post on a funded startup or public company blog discussing React Native
So by the current guidelines this would not be an app to add to the showcase. I think Zribbble is pretty cool, it just is not quite the direction we are trying to go with the showcase. I'm sorry!


buftabline and goyo don't work together

Weird things keep appearing in the tab line when goyo is activated.
See the following issue on the goyo repo:
https://github.com/junegunn/goyo.vim/issues/171#issue-290189123

Somehow this issue completely escaped my attention. Sorry about that. I’m looking into #67 right now.

Well… this is quite a mess, really.
The problem is a Buftabline feature that’s necessary because Buftabline doesn’t support Vim tabs at all. What it does is it allows the standard Vim tab feature take over when the user or another plugin has created a Vim tab. Otherwise you wouldn’t see what’s going on.
Goyo collides with Buftablines because it breaks my underlying assumption that the user needs to be able to see what’s going on when a Vim tab is created. Goyo works by creating a new Vim tab that it wants to hide. This is… not a use case  I had foreseen. It makes complete sense given Goyo’s aim, of course.
Not sure yet how I’m going to address this…

For history: I've made a PR few days ago (#67) that was addressing this issue.
Unfortunately that patch works for me only and is not good enough to go mainstream.
Moving conversation from PR to this issue.
How about (arguably dirty) check if exists('#goyo') before check for number of tabs?

like this:
https://github.com/vigilancer/vim-buftabline/commit/2058d75bb55fd075830c3470a2bd8db1978df426

Arguably dirty. 🙂
Right now I’m thinking of adding another setting in Buftabline to disable the Vim tabs fallback. In the future when Buftabline supports tab pages, the same setting could be expanded to allow the user to control whether tab pages should trigger Buftabline’s internal support, the fallback to Vim tabs, or nothing. And once this setting exists, Goyo could use it to override Buftabline’s handling of tabs while Goyo is active, much as it already does for several other plugins.
Logically I don’t see a problem with that, but I can’t yet say whether it feels right, so I wanna sleep on it for a bit. Adding a setting is a long-term commitment.


group_add option doesn't work as described

File: compose/compose-file/index.md, CC @londoncalling
The group_add option is described as being a second level property, right under "services". This option doesn't work. Please note I also tried to put it nested under a service, and it didn't work either, so for now I don't really know what the documentation should read.
See my comment on ticket #3328

@dnephin @shin- @nathanleclaire @ManoMarks Can you all take a look at the above comment, and also the referenced issue #3328. It sounds like from the discussions that group_add is not working in Compose?

group_add works fine in Compose, but that example snippet is indeed wrong. It should be something like:
version: '2'
services:
  myservice:
    image: alpine
    group_add:
      - mail

@londoncalling If you're working on this change, it might be a good occasion to remove group_add from the v3 docs as well, since it's only a valid option in v2.

@shin- oh!? okay, thanks

@shin- on issue #3328 psoare's seems to have tried this format as a second try and says it didn't work ...?

I confirm this works on version 2 and not on version 3.

@psoares thanks for the feedback, the docs updates are published now, so I'm going to close this issue. Feel free to re-open the discussion or a new issue if you find something else.

group_add example should be correct now for Compose v2
it's been removed from Compose v3 (since it's a v2 only thing)
Versioning details have been updated
More details are in the referenced PR #2684

What's the alternative if user need group_add in a version 3 compose file ? Should it be handled manually in Dockerfile ?


Output of the http-trace-logs sample is incorrect

Pack - Tools build on 18/04/2018
Oracle JDK - "1.8.0_161"
Windows 7
Description:
Output of the http-trace-logs sample is incorrect. The logs documented in the below link are not visible to the user.
https://github.com/ballerina-platform/ballerina-examples/blob/master/examples/http-trace-logs/http-trace-logs.server.sh

can you give more details about the difference? The logs appear correct. Some details will be different from sample output, due to port assignment etc. We will not fix those changes.


Add an attribute-transformation directive

From David Sankel and me, from the Boost review:

If a parser p has attribute type T (a T parser), and you have a function f of type U(T), I would expect there to be an easy way to convert the T parser into a U parser. Something like map(f, p).

This seems like a nice addition. Though you can certainly do this with a rule+semantic action combo, it would be much more ergonomic to be able to do this in a simpler way.  I would make this a directive, like transform(f)[p].

Will this address the use case from https://github.com/tzlaine/parser/issues/63?

I don't think so, or at least I don't yet see it.  The thing proposed here is taking an attribute that definitely exists, and transforming it into an attribute of a different type.

Well, not strictly directive defaulted[], but I can do:
transform(map_nullopt_to_default_constructed)[ (char_ >> int_) % ',') | eps ]

I get it now.  Then, yes, I could definitely be used in that case.  I still think writing attr(x) is easier.


Replaced guava ImmutableMap and ImmutableSet

What
Replaced test code usage of ImmutableMap and ImmutableSet with new
CollectionFactory.
Testing
Updated tests to use CollectionFactory, tests pass.
Issues
Part of #308

LGTM +1


migrate Go keys and values to treesitter

This doesn't handle all uses of key and value.
Missing still are assignment statements (name, value),
function signatures (name, value), and possibly other
places (perhaps type declarations?).
It does handle all existing uses of key, value, and name,
though, so we can start here.
The handling of multiple return values is complicated,
particularly around the handling of comments and removal ranges.
It would be nice to find a simpler approach.
Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

I haven't added any tests yet. Before I did that, I wanted to get around of feedback about the behavior, so that I don't waste time adding tests with the wrong behavior.
There are a lot of tests to add.
To make it easier to get initial feedback I have included two videos of the scope visualizer.

return values:
https://github.com/cursorless-dev/cursorless/assets/67496/e15d9ba4-7063-4526-bc0c-4c215cb779ca

keys and values in maps and lists:
https://github.com/cursorless-dev/cursorless/assets/67496/7b7675ef-1fd2-4af1-90bb-46d6668f4413

keys and values in maps and lists:
visualize_key_value.mov

this looks great!

I need to take another pass over this, marking as draft in the interim.

update: I'll have a look to see if there's stuff we can easily pick up to take this one home

update: I'll have a look to see if there's stuff we can easily pick up to take this one home

Sounds good, thanks. I'm eyeball deep in other stuff, so I don't anticipate much cursorless bandwidth for a fair while.

Removing myself as assignee so that someone else can pick it up


tetra getevents filtering with --pods returns no pod

What happened?
When going through execution monitoring, the --pods filter doesn't seem to be working in my environment
Tetragon Version
CLI version: v1.1.2
Kernel Version
Linux tetragon-control-plane 6.9.3-orbstack-00146-g1a8d02c90788 #1 SMP Wed Jun 12 00:20:38 UTC 2024 aarch64 Linux
Kubernetes Version
Client Version: v1.30.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.0
Bugtool
tetra-bugtool.log
tetragon-bugtool.tar.gz
Relevant log output
No response
Anything else?
No response

actually found my error, quite silly (i was grabbing the wrong tetragon pod name 🫠 😑)
but thinking that the output of tetra getevents --help shows --pod (deprecated) instead of --pods, may be a tiny follow up on that


Added adjustable system catch up time for macOS

pyautogui seemed quite slow in comparison to the other alternatives like pynput and mouse for macOS. After some digging i found out that this catch up time was responsible for the delay in my case.
IMO it makes more sense to make this catch up time adjustable so everyone can find out the sweet spot for their usecases.
The better solution would be to find a way to let Quartz catch up in dynamically.

Thanks!


"TypeError: from field must match key's 0x6C4D37343C5e4AfaafB37033B29A4D12bD96b2A1, but it was 0x90F8bf6A479f320ead074411a4B0e7944Ea8c9C1"

Pre-edit: I found the same topic but it was closed.
Hello friends, I am getting "TypeError: from field must match key's 0x6C4D37343C5e4AfaafB37033B29A4D12bD96b2A1, but it was 0x90F8bf6A479f320ead074411a4B0e7944Ea8c9C1" error.
It seems visual code storing the first address in somewhere but I could not figure out how to delete it. Any help appreciated. Thank you.

Hello @rekatop this means you are comparing two different accounts, most likely one you have on metamask and another which comes directly from ganache accounts.
Please make sure the $PRIVATE_KEY you are using is correctly imported to path.
Additionally you can put print statement along the way to know exactly which account you are using each time.

Thank you for your response @cromewar, I set the variable on windows so I finally figured out. Thank you again!


[improve][client] add physicalAddress as part of connection pool key

Motivation

Context: https://github.com/apache/pulsar/pull/22085/files#r1497008116
Currently, the connection pool key does not include physicalAddress (currently logicalAddress + keySuffix). This can be a problem when the same logicalAddresses are in the migrated(green) cluster. (the connection pool will return the connection to the old(blue) cluster)
Modifications
Add physicalAddress as part of the connection pool key
Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.55%. Comparing base (bbc6224) to head (c716ce6).
Report is 22 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22196      +/-   ##
============================================
- Coverage     73.57%   73.55%   -0.02%
- Complexity    32624    32653      +29
============================================
  Files          1877     1878       +1
  Lines        139502   139634     +132
  Branches      15299    15328      +29
============================================
+ Hits         102638   102711      +73
- Misses        28908    28929      +21
- Partials       7956     7994      +38

Flag
Coverage Δ

inttests
26.63% <48.00%> (+2.05%)
:arrow_up:

systests
24.22% <48.00%> (-0.10%)
:arrow_down:

unittests
72.84% <76.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../org/apache/pulsar/client/impl/ConnectionPool.java
75.62% <76.00%> (+1.10%)
:arrow_up:

... and 63 files with indirect coverage changes


feat(poly): impl lagrange poly for cyclic group

Motivation
Close #255
Overview
N\A

Blocked by #258

@chaosma You can review the current version, all I plan to change is to pre-calculate with wolfram and add tests

We can optimize in the future and get away from the lazy computation model if we need to, but at first glance iter+rayon may be enough


Creating Money Object Errors on large number

It seems that the object for MoneyPHP is crashing on large amounts, is this known ?
I cannot find out yet on which number it fails but I started to see it on this amount:
$money = new Money('16333.17', new Currency('EUR'));
I hope this is not a bug because when I change 16333.17 to 100 it works again.

@Yamakasi - 16333.17 is not a large amount -- in the grand scheme of things.
What version are you using? In my composer version (^3.0) your example with throw an InvalidArgumentException('Amount must be an integer(ish) value').
Quick Test 1:
$amount = '16333.17';
var_dump(filter_var($amount, FILTER_VALIDATE_INT)); // bool(false)
$number = Number::fromString($amount);
var_dump($number->isInteger()); // bool(false)

Try this instead (note, no decimal):
$money = new Money('1633317', new Currency('EUR'));

Quick Test 2:
$amount = '1633317';
var_dump(filter_var($amount, FILTER_VALIDATE_INT)); // int(1633317)
$number = Money\Number::fromString($amount);
var_dump($number->isInteger()); // bool(true)

... If you still have issues after attempting what's above then please reply with as much information and surrounding context as possible. For example, saying "it fails" is useless for people who want to help, but an actual exception, fatal error, stacktrace, etc., etc., goes a long way to getting an answer and solution expediently.

@Yamakasi - There's also very good documentation at http://moneyphp.org/en/latest/ if you haven't come across it. Below is a small screenshot from http://moneyphp.org/en/latest/getting-started.html which looks related to what you're attempting to do.

@bmeynell:
Thanks, this is indeed wrong at my side but it's strange it works good with a value of 100000.00
I don't see the exception, could be codewise here, I need to check, but the above working example is strange isn't it ? It does seem to crash from some higher number.

@Yamakasi - The documentation (and screenshot above) states that trailing .00 will resolve as valid, but nothing else will. It does seem odd, but I'm sure there's reason and discussion behind that behavior, I simply don't know what it is. Glad your code is working better now!

@bmeynell thanks, I'm always curious about such behaviour. What is best to store the money in a Database: as Decimal and create an Integer out of it for this library or an Integer is best ?

What is best to store the money in a Database

There is much active discussion about this here (search the repo) and overall -- as well as how to integrate with an ORM. Personally, I lean toward storing the smallest possible denomination (e.g., "cents") in one column and the ISO currency code in a tandem column.

Yes I have exactly the same way. Thanks for the confirmation!

@Yamakasi - Please close this issue if you're satisfied it's been resolved. TY!


Update copyright across all files

Updates the copyright at the top of all files for the range 2020-2024. Also adds it in the files where it was missing.
I just opened this PR because the inconsistency kept frustrating me. 🙃

Agreed, it is a bit frustrating when copyrights go out of date. I've worked on some projects where I solved this by just not including them anymore.
Tagging self for review and starting the arduous 236 file diff ...

Only recommendation I would have would be write an issue to consider automating this (or removing the copyright altogether?)

The reason we have a copyright header in cesium-unreal and nowhere else is because it's required by Epic's Marketplace guidelines. Or at least it was, I haven't checked lately.


Follow up design history

What
Follow up design history app
Why
So we record our design decisions
Who needs to work on this
Designer
Done when

[ ] We know what we're doing with the design history

@joelanman I'm sure you are aware of the https://x-govuk.github.io/govuk-design-history/
From the current and X DfE designers?  Like @fofr @paulrobertlloyd @frankieroberto and others.
I personally prefer the above specific design and not the template. But in general the template is extremely versatile and easy to add a CMS onto.
#The DfE design Ops folks use Strapi, but I have seen Forestry.io and even open source versions like NetlifyCMS which ties well with the hosting.
In older attempts we used the GDS way and a lot principles like Tech Architecture https://dfe-digital.github.io/architecture/ and Devs still use variations of the Middleman app for documentation. Now, I am not certain how recent these are or if they're maintained.
Have I misunderstood your question here?
Apologies for tagging everyone in, but, if I am not wrong these are the people to help you.

@Nikolaos-Gkionis Given that this project is now in maintenance mode, I very much doubt a design history will be added.

@paulrobertlloyd 🤣 that’s what you get for reading issues on a PWA.


Uncaught TypeError: this.dragSourceFor is not a function

Hi
when using react-dnd from the dist folder, I get the following error in chrome:
this.dragSourceFor is not a function

and so on for all the functions relating to react-dnd?
I have the following html file with the javascript files:

and the following snippet of jsx code for one of the classes:
var DragDropMixin = ReactDnD.DragDropMixin;

const ItemTypes = {
  TASK: 'task'
};

var Task = React.createClass({
  mixins: [DragDropMixin],

  statics: {
    configureDragDrop: function(register) {
      register('task', {
        dragSource: {
          beginDrag: function(component) {
            return {
              item: {
                text: component.props.text,
                deleteTask: component.props.deleteTask
              }
            };
          }
        }
      });
    }
  },

  render: function(){
    var dragSource = this.dragSourceFor(ItemTypes.TASK);

    return(

        {this.props.text}

    );
  }
});

Any advice/help is most grateful. Thank you for your hard work!

You are using trying to use an outdated api.
The api has drastically changed since v1.0.0.

Yep. Sorry, 1.0 also has many improvements, and works without mixins. Please use it instead.


python37Packages.zstandard: 0.14.0 -> 0.14.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.zstandard is: "zstandard bindings for Python"
meta.homepage for python37Packages.zstandard is: "https://github.com/indygreg/python-zstandard"
meta.changelog for python37Packages.zstandard is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.14.1 with grep in /nix/store/lwiyq90889h7ldf4cg2vgdjzz2f2pjcm-python3.7-zstandard-0.14.1

directory tree listing: https://gist.github.com/90ed42cf88fc81454584b644246b306e

du listing: https://gist.github.com/1e124ceda95866d8b7a82633e67d1ace

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
mitmproxy
python37Packages.mitmproxy
python37Packages.zstandard
python38Packages.mitmproxy
python38Packages.zstandard
python39Packages.mitmproxy
python39Packages.zstandard

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lwiyq90889h7ldf4cg2vgdjzz2f2pjcm-python3.7-zstandard-0.14.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.zstandard https://github.com/r-ryantm/nixpkgs/archive/305004038de2a2686d8ec540fccd8850eaa9d5ce.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lwiyq90889h7ldf4cg2vgdjzz2f2pjcm-python3.7-zstandard-0.14.1
ls -la /nix/store/lwiyq90889h7ldf4cg2vgdjzz2f2pjcm-python3.7-zstandard-0.14.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

6 packages built:

mitmproxy (python38Packages.mitmproxy)
python37Packages.mitmproxy
python37Packages.zstandard
python38Packages.zstandard
python39Packages.mitmproxy
python39Packages.zstandard

Maintainer pings
cc @arnoldfarkas for testing.

Result of nixpkgs-review pr 106147 run on x86_64-darwin 1

6 packages built:

mitmproxy (python38Packages.mitmproxy)
python37Packages.mitmproxy
python37Packages.zstandard
python38Packages.zstandard
python39Packages.mitmproxy
python39Packages.zstandard


Wip/multilanguage

include locale when generating and reading parameter datasets
updated i18n files (please verify italian.js and chinese.js)

[also probably won't merge this until after hw2 deadline]

By the way, now that you're contributing more to genie-toolkit, it's time for you to clean up your commit history, and clean up your commit messages.
Please follow the guidelines at https://chris.beams.io/posts/git-commit/: include one line of subject and a longer description in every commit, and explain both what you're doing, and why you're doing it.

You did something to the branch that makes it hard to review, there are lot of unrelated commits.
Can you do a clean rebase on top of master, rearrange the commits in a sensible order with fixups, and then do a force push to the branch?

The problem was some of the earlier commits were merges from master branch without rebasing, so that's why It looks disordered. All the master commits are preserved though. Let me see what I can do...

 Please make a clean rebase.


support universal wheels

Ack. We want to make sure this works with our installation logic.

Mark as enhancement? Python 2 is deprecated and this SDK is moving on to Python 3.

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information


[conda-build-all] re-enable py36

Whoops. Did we jump the gun on the last merge?

Maybe. I think this is mergable, the linux build already produced a lot of py36 pkgs.

Thanks!


Implement Color Box Action

Show/hide color box
Requires a template change of color box/status bar
Requires checkable menu items (#6)

Closed in https://github.com/christianliebel/paint/commit/75eebfe98ee12d57eef809ed2fe580d042916179


Uncaught TypeError: Cannot read property 'addEventListener' of null

I'm getting an addEventListener error when I try to use drop in via coffee script with a rails project.Here is the setup:
application.js
//= require jquery
//= require jquery_ujs
//= require jquery.turbolinks
//= require turbolinks
//= require hubspot/tether.min.js
//= require hubspot/drop.min.js
//= require moment.min.js
//= require_tree .
//= require_self

accounts.js.coffee which is included by the //= require_tree . line
accountSwicher = new Drop
  target: document.querySelector('.account-switcher')
  content: 'Welcome to the future!'
  position: 'bottom left'
  openOn: 'click'

The resulting js that is render in the browser is:
(function() {
  var accountSwicher;

  accountSwicher = new Drop({
    target: document.querySelector('.account-switcher'),
    content: 'Welcome to the future!',
    position: 'bottom left',
    openOn: 'click'
  });

}).call(this);

But when the page loads I get:
Uncaught TypeError: Cannot read property 'addEventListener' of null
which is throwing an error on this line
The weird thing is that if I just take the resulting js above, and include it directly in a js file, commenting out the contents of accounts.js.coffee to take it out of the picture, everything works fine.
Any thoughts here?

Hmm, that's strange. It seems like the element isn't on the DOM when accounts.js.coffee is being executed. Are you waiting for the DOMContentLoaded or the DOM ready event before trying to create the Drop?

Haha that was it. I feel so dumb.
Some questions you just want to delete from the universe, this is one of them. That is what I get for coding after only sleeping 2 hours.

No worries. Happens to the best of us :sweat_smile:


[BUG] Image not loading / displaying in nested adaptive card

Good day,
TLDR; When sending an adaptive card with another inside that can be opened with Action.ShowCard the inner card does not display any images.
The issue
I'm trying to send an adaptive card with expandable content over the bot framework and wanted to use the showcard action for this. I discovered that the image does not render (and at the start it was because the image was too big). Afterwards, I believed that because Images get proxied over urlp.asm.skype.com, my webserver was serving the images wrong (or wrong mimetype or whatever). This was not the case as other images displayed correctly. After testing, I found out that all images inside of the nested adaptive card will not display.
How to reproduce:
Send this JSON as an adaptive card to a teams channel:
{   "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",   "type": "AdaptiveCard",   "version": "1.3",   "body": [     {       "type": "Image",       "url": "https://upload.wikimedia.org/wikipedia/commons/thumb/c/c9/Microsoft_Office_Teams_%282018%E2%80%93present%29.svg/258px-Microsoft_Office_Teams_%282018%E2%80%93present%29.svg.png",       "size": "Medium"     }   ],   "actions": [     {       "type": "Action.ShowCard",       "title": "Action.ShowCard",       "card": {         "type": "AdaptiveCard",         "body": [           {             "type": "Image",             "url": "https://upload.wikimedia.org/wikipedia/commons/thumb/c/c9/Microsoft_Office_Teams_%282018%E2%80%93present%29.svg/258px-Microsoft_Office_Teams_%282018%E2%80%93present%29.svg.png",             "size": "Medium"           }         ]       }     }   ] }
The image does not get rendered regardless of web or desktop teams application. (I assume it's because the desktop teams-app just renders a webpage)
-> The inner nested adaptive card does not have the src attribute, only the ng-src attribute. If you add the src attribute, it displays correctly. So it might just be an angularjs thing.
Also, your webclient throws a LOT of errors in the console, some angular, some not. It's hard to find the errors that are actually caused by my nested card.

Hi,
We were able to repro this issue. The card works fine in adaptive card designer but does not work in teams. This seems like a platform bug. We have raised a request with concerned team.

@joschi27 - Sorry for the late response.
This issue has already resolved, Please check and confirm here.


Updates Sonos.Controller to PackageVersion: 70.1.34112

[ ] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

I updated the license property.


No coverage reports for files that are executed by vm.runInContext.

🐛 Bug Report
No coverage reports for files that are executed by vm.runInContext.
To Reproduce
Steps to reproduce the behavior:

create a js file with single line console.log('hello');
create a test file which loads the content of 1. , and run it by vm.runInContext.
jest --coverage, no coverage report of 1. file.

Expected behavior
Show the coverage report.
Link to repl or repo (highly encouraged)
https://github.com/istanbuljs/istanbuljs/issues/85
Not sure if it's related. However istanbul-lib-hooks is removed recently from Jest.
envinfo
System:
OS: macOS Mojave 10.14.6
CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
Binaries:
Node: 12.13.0 - /usr/local/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.12.0 - /usr/local/bin/npm
npmPackages:
jest: ^23.6.0 => 23.6.0
System:
OS: macOS Mojave 10.14.6
CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
Binaries:
Node: 12.13.0 - /usr/local/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.12.0 - /usr/local/bin/npm
npmPackages:
jest: ^24.9.0 => 24.9.0
Both jest versions are the same.

This should work correctly if using v8 coverage, which will be available in the next version of Jest

I checked again with v8 coverage setting, and there's still no coverage reports for vm.
Here is the reproducible repo:
https://github.com/JoHuang/jest-vm-test
thanks

Any update for this?
Thanks

Hi,
I found it works with c8.
Please refer to the repo:
https://github.com/JoHuang/jest-vm-test

https://github.com/facebook/jest/blob/3641e3cc7309caf4c755add40bebcb77fc18b786/packages/jest-runtime/src/index.ts#L830
I found that it works after commenting this line.
It filters the files which are not required by normal node.js require or import.
However, codes run in VM usually are read as string content, and then put into VM.runincontext ...etc.
V8 coverage is there but Jest filters out the files.
Hope this is helpful.

However, this test case e2e/__tests__/v8Coverage.test.ts cannot pass.


npm install --save-dev failed at postinstall stage

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.  (Found similar issues, but none of them addressed my problem)

Describe the bug
When running npm install supabase --save-dev, the process hangs and then failed. The log shows that it fails at the postinstall stage with<EMAIL_ADDRESS>postinstall { code: 13, signal: null }.
I tried a lot of methods from online, all didn't actually work for me unfortunately. Things I have tried:

different node version (tried v16, v18, v20)
force clean npm cache
delete package-lock.json and retry installing
delete node_modules and retry installing
completely uninstall node and npm and then re-install them
manual overwrite npm registry
restarted my MacBook
factory reset my MacBook
reset user permission for /usr directory
check that no proxy has been configured for npm
check that .npmrc file has no outdated access token or wrong registry (in fact currently I don't even have .npmrc in the $HOME so it should be running default settings!)

Here are some additional information that might help:

My MacBook is M1 Pro MacBook Pro (Running on Sequoia 15.1)
node version currently use via NVM : v20.10.0
npm version: 10.2.3
supabase cli version: @latest

Some observations:

running sudo npm install supabase --save-dev works for me. Therefore, I suspect does supabase cli postinstall script tries to access some files that require higher privileges?
running npm install<EMAIL_ADDRESS>--save-dev works for me too. Therefore, suspect there is some update to the postinstall.js script between the latest version and the v1.1 version such that this bug is introduced?
managed to find out that v1.89.1 works for me and then v1.90.0 failed. So there is some changes introduced in v1.90.0 that causes this to happen? -- I drilled down and found that this particular commit https://github.com/supabase/cli/commit/571f336c117c182f015b6f6ba270c726a01732a7 causes subsequent version installation to fail.

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Run npm install supabase@latest --save-dev
The npm process will hang when it reaches run<EMAIL_ADDRESS>postinstall step
And then it will fail after hanging for some time T_T

(However, this might not be reproducible for you because I have used some other laptops to try, and they all can install successfully 😭 I really don't know what happened to my device)
Expected behavior
Running npm install supabase@latest --save-dev should succeed.
  Downloading https://github.com/supabase/cli/releases/download/v1.207.9/supabase_darwin_arm64.tar.gz
npm ERR! Downloading https://github.com/supabase/cli/releases/download/v1.207.9/supabase_1.207.9_checksums.txt
npm verb exit 13
npm verb unfinished npm timer reify<PHONE_NUMBER>448
npm verb unfinished npm timer reify:build<PHONE_NUMBER>533
npm verb unfinished npm timer build<PHONE_NUMBER>534
npm verb unfinished npm timer build:deps<PHONE_NUMBER>534
npm verb unfinished npm timer build:run:postinstall<PHONE_NUMBER>308
npm verb unfinished npm timer build:run:postinstall:node_modules/supabase<PHONE_NUMBER>313
npm verb code 13

System information

OS: macOS
Version of supabase: 1.207.9
Version of Node.js: v20.10.0
Version of npm: 10.2.3
M1 Pro MacBook Pro (Running on Sequoia 15.1)

I’m running into the same issue in a Vercel build. The issue is caused by the postinstall script in my case as well. Logs:
[11:09:29.860] Running build in Washington, D.C., USA (East) – iad1
[11:09:30.007] Cloning github.com/<REDACTED> (Branch: <REDACTED>, Commit: <REDACTED>)
[11:09:35.845] Warning: Failed to fetch one or more git submodules
[11:09:35.846] Cloning completed: 5.838s
[11:09:45.690] Restored build cache from previous deployment (<REDACTED>)
[11:09:45.773] Running "vercel build"
[11:09:46.445] Vercel CLI 37.12.0
[11:09:46.903] > Detected Turbo. Adjusting default settings...
[11:09:48.596] Running "install" command: `bun install`...
[11:09:48.803] bun install v1.1.30 (7996d06b)
[11:09:49.933] file:///vercel/path0/node_modules/tar/dist/esm/mkdir.js:3
[11:09:49.933] import { mkdirp, mkdirpSync } from 'mkdirp';
[11:09:49.933]          ^^^^^^
[11:09:49.933] SyntaxError: Named export 'mkdirp' not found. The requested module 'mkdirp' is a CommonJS module, which may not support all module.exports as named exports.
[11:09:49.933] CommonJS modules can always be imported via the default export, for example using:
[11:09:49.933]
[11:09:49.933] import pkg from 'mkdirp';
[11:09:49.933] const { mkdirp, mkdirpSync } = pkg;
[11:09:49.933]
[11:09:49.934]     at ModuleJob._instantiate (node:internal/modules/esm/module_job:123:21)
[11:09:49.934]     at async ModuleJob.run (node:internal/modules/esm/module_job:191:5)
[11:09:49.934]     at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
[11:09:49.934]     at async loadESM (node:internal/process/esm_loader:34:7)
[11:09:49.934]     at async handleMainPromise (node:internal/modules/run_main:106:12)
[11:09:49.934]
[11:09:49.934] Node.js v18.20.4
[11:09:49.934]
[11:09:49.934] error: postinstall script from "supabase" exited with 1
[11:09:49.941] Error: Command "bun install" exited with 1
[11:09:50.397]

In case you're here: pinning 1.207.0 worked for me. A higher version between 1.207.0 and 1.207.9 might also work, I’d suggest trying it out.

In case you're here: pinning 1.207.0 worked for me. A higher version between 1.207.0 and 1.207.9 might also work, I’d suggest trying it out.

Thanks! I tried but unfortunately it still failed :( The latest version so far tested working for me is 1.89.1, 1.90.0 onwards cannot already. From the commit of 1.90.0 seems like the fetching checksum and verifying checksum was introduced so I'm not sure if my issue was caused by this.

I wonder if your OpenSSL library doesn't support sha256 https://github.com/supabase/cli/blob/571f336c117c182f015b6f6ba270c726a01732a7/scripts/postinstall.js#L128 (although it would be weird, since sha256 is a very common hash algorithm).
You can try running
openssl list -digest-algorithms

Alternatively, it's also possible that your version of Node.JS doesn't have crypto support (although I've only seen this before on IoT devices, not laptops!) Check out: https://nodejs.org/api/crypto.html#determining-if-crypto-support-is-unavailable
Try running the following function, just to sanity check sha256 and crypto works on your computer:
alois@pc:~$ node --eval="console.log(require('crypto').createHash('sha256').update('alice', 'utf8').digest())"
<Buffer 2b d8 06 c9 7f 0e 00 af 1a 1f c3 32 8f a7 63 a9 26 97 23 c8 db 8f ac 4f 93 af 71 db 18 6d 6e 90>


Add dev mode only tags

Address #62
I'm not sure if this approach is too simple - but as far as I can tell this should achieve what is needed. Doesn't add any overhead if you're not using the tags.

Thanks for your contributions, @emab!
Just a thought: wouldn't it be cleaner to add an extra parameter (i.e. dev_only=True) to the already existing {% vite_asset %} and {% vite_asset_url %} templatetags?

Instead of:
{% vite_asset '<path to your asset>' dev_only=True %}

Could we just do:
{% if DJANGO_VITE_DEV_MODE %}
    {% vite_asset '<path to your asset>' %}
{% endif %}

It seems like this functionality could be handled on the project-level without needing to add anything to django-vite. For comparison, it doesn't seem like similar projects like django-webpack-loader or vite-ruby have support for this.


Enchant dependency not in requirements.txt

Default setup doesn't run without it, and it doesnt' seem to be present in requirements.txt

Added now


Remove version: DG0JBJ.HDSDR version 2.81-b11

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://www.hdsdr.de/download/HDSDR281b11_install.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 897)


Add number of stars next to each tool in overview

The overview page for each tag should show the number of Github stars for each tool.
This information is already available in the GraphQL data in Gatsby. (Run the project and go to http://localhost:8000/__graphql). We would have to add the stars to the queried fields here and show it on the page. (Maybe next to the title of the tool.

Hi @mre, Want to take this up. Please assign

Is this already done? That yellow circle is the star count?

Sure @saraogipraveen. Assigned.

Nope, that's the vote, which is not the number of Github stars (that's a different field).

@mre Issue can be closed now. Thanks

Ah right. Thanks again for the contribution @saraogipraveen.


ERROR: Cannot locate specified Dockerfile: .//Dockerfile

PS C:\Program Files\docker\sandbox> ./sandbox up
C:\WINDOWS\system32\cmd.exe /c ""C:\Program Files\docker\sandbox\sandbox.bat" up"
Spinning up Docker Images...
If this is your first time starting sandbox this might take a minute...
WARNING: The TYPE variable is not set. Defaulting to a blank string.
Building influxdb
ERROR: Cannot locate specified Dockerfile: .//Dockerfile
Opening tabs in browser...
Press any key to continue . . .
PS C:\Program Files\docker\sandbox>
It appears environment variable TYPE is not set as noted by others. If that is the case what would be the best way to address this issue?
.yml files has the following:
dockerfile: ./${TYPE}/Dockerfile
.env file has no setting for TEMP
.env-latest has the following;
export TYPE=latest
.env-nightly
export TYPE=nightly
Would it make a difference if I clone the repo. I downloaded a zipfile.

This is a problem in the sandbox.bat file. TYPE isn't defined.
There's also a problem that ${INFLUXDB_TAG} (and other tags) aren't defined (they should be descend from TYPE, 'eh?)
I can get around this by hard-coding latest into the docker-compose.yaml file, but then I hit a snag with a source path in telegraf.
- /var/run/docker.sock:/var/run/docker.sock isn't a valid windows path.
I'll see if I can't get things running on Windows 10 and submit a PR.

I spent some time with the sandbox files running on Windows 10 Pro in an effort to work around the TYPE and other arg issues. I have the TICK stacking running by 'hacking' the following files:
docker-compose.yml file.
Replaced $(TYPE) with latest.
Removed all args statements for each service
- args:
INFLUXDB_TAG: ${INFLUXDB_TAG}
DOCKERFILE files
Changed DOCKERFILE contents ( all service except Chronograf) to include only 1 line of code
FROM influxdb:latest
Chronograf DOCKERFILE
FROM chronograf:latest
ADD ./sandbox.src ./usr/share/chronograf/resources/
ADD ./sandbox-kapa.kap ./usr/share/chronograf/resources/
Not very pretty but everything seems to be up and running.
PS C:\Users\ross1\documents\sandbox-master> ./sandbox up
C:\WINDOWS\system32\cmd.exe /c ""C:\Users\ross1\documents\sandbox-master\sandbox.bat" up"
Spinning up Docker Images...
If this is your first time starting sandbox this might take a minute...

Press any key to continue . . .

hey guys...sorry, Windows edition is broken at the moment.  We are working on putting this back together.


Add example PNS payload for id-only notifications

A customer infosec team was requesting an example.  Publishing this same example here.

For reference, I did a tcpdump on my MPNS host to view the payload contents:
sudo tcpdump -i eth0 -s 0 -A 'tcp dst port 8066 and tcp[((tcp[12:1] & 0xf0) >> 2):4] = 0x504F5354'


fix java Engine.Builder method access modifiers.

1. Fix Java Engine.Builder methods access modifiers.
The default java class method access modifier is protected, The Engine.Builder is a static inner class of Engine, so the Builder's methods, except the public constructor, are not accessible outside of Engine namespace.
And the Engine.create methods are announced deprecated. So I believe the Engine.Builder's build methods should be publicly access from outside.
2. Fix warning that still use the deprecated Engine.create api.

The default visibility is package private not protected, but yes those methods need a public access modifier. Engine.create() is not deprecated, there's no reason to stop using it.


[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

When I scroll to down on box on chrome I get this error
[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
What do I do ;-(

When simulating touch screen devices in inspect mode, as we scroll the container with perfect-scrollbar and when the container finishes scrolling and body start scrolling then this error occurs.

It can be solved using css --> "touch-action: none;" on container having scrollbar

It can be solved using css --> "touch-action: none;" on container having scrollbar

Why disabling the scroll by touch can solve this problem?

Hi there,
I had the same issue, and it was super annoying to see more than 200k logs with this error in PROD, so we did a fork with the fix - https://www.npmjs.com/package/perfect-scrollbar-patch
You can see the changes here: https://github.com/mdbootstrap/perfect-scrollbar/compare/main...PashaTkachuk:perfect-scrollbar-patch:main
The fix is available in this version:
"perfect-scrollbar-patch": "1.5.6"

Hi there, I had the same issue, and it was super annoying to see more than 200k logs with this error in PROD, so I did a fork with the fix - https://www.npmjs.com/package/perfect-scrollbar-patch
You can see the changes here: main...PashaTkachuk:perfect-scrollbar-patch:main
The fix is available in this version: "perfect-scrollbar-patch": "1.5.6"

Does it work with React as well?


Add Italicize, Bold, Underline

Would like to see these in editor !

Hello @rudrathedev,
Thanks for your suggestion, but can you please provide some extra information for example
If you want bold in all keywords in the editor you can make this easily like any other TextView
From XML
   android:textStyle="bold"

or from Java
codeView.setTypeface(textView.getTypeface(), Typeface.BOLD);

Or you mean for example to add style for a specific pattern like language keywords
Thanks
Amr Hesham

I want it to be for a specific pattern

@rudrathedev
i think it can be added as overflow menu when user select text in code (not sure if it already appear or not).
Could u share a the business case for having bold some text based on pattern.


Remove jsdom

The version of JSDOM we were requiring fails to installs properly on my
machine.
Upon closer inspection, it seems the modern version of raven-js nolonger needs
a window, so we can omit JSDOM all together.

Review @idris?


 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1594/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

2m 45s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1594/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1594

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 68912a38742a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 39a1bc53f8

Max. process+thread count
44 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1594/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I noticed that we don't set -e anywhere, so a user can export GREP="foo" and we'll proceed along as if everything is fine.

ugh. lord. really? ugh. I hope this is already tracked in our jira for "reasons we need a good scrub of our bootstrapping scripts".


Release cobigen-core-v5.3.1

This issue has been automatically created. It serves as a container for all release related commits

Automatically processed.
The decisions taken by the developer and the context of the decisions throughout the script:

User confirmed that tests are running on CI and the build is not failing.
User confirmed that tests are running on CI and the build is not failing after pushing release changes to development branch.


Inconsistent heading spacing behavior

There is inconsistent behavior on Lagrange 1.14.1 on Windows 10 with spacing after headings.
With the first heading level putting a blank newline between the heading and content
# Heading 1
Content
actually decreases the spacing between the heading and subsequent content,  when the expected behavior would be either to increase it or do nothing.
Consequently, removing a blank new line
# Heading 1
Content
actually increases the spacing between the heading and subsequent contents, when the expected behavior would be the decrease it or do nothing.
The next two levels of headings ## & ### work as expected: a blank line in-between increases spacing, and removing it decreases spacing.

You are right, the spacing after h1 is not right. The intended behavior in this layout is that that the spacing is exactly the same with or without one empty line after the heading.

Is that only for h1, or should the other levels not increase and decrease at all (even though their change is at least logical)?


Add rollback tests to CI pipeline

Description
Adds rollback tests to CI pipeline
Related issues
Addresses User Story 113052: Add rollback tests to OSS CI
Testing
Ran the CI pipeline with the new definition
FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)
Skip

/azp run


Removed duplicate dependency

react-hot-loader was depended upon twice

Awesome, thanks for submitting these 👍 !  I will review your second one tomorrow.


[BUG] true == false condition in Successful Purchase logic app

Describe the bug
In the last step of the logic app for a successful purchase where is an AND condition. One of the condition is a "true equals false" condition, which obviously cause it never to be true and therefor never resolve the subscription.
Kind of confusing... :)
https://github.com/microsoft/mona-saas/blob/main/Mona.SaaS/Mona.SaaS.Setup/integration_packs/default/on_purchased_workflow.bicep#L233

Let me explain the logic here and get your thoughts, @tfsjohan.
If this flag is set to true (e.g., true == true), the Marketplace will be automatically notified that the subscription is ready (activated) at the end of the workflow. If this flag is set to false, the Marketplace will not be automatically notified. Think of it as a "shutoff valve." In general, I think it's better to "opt in" than "opt out" when it comes to these types of business impact situations.
All this being said, we definitely need to document this behavior prominently in the README.
So, how should this condition be set by default? Ideally, we could just toggle actions on and off but, unfortunately, Logic Apps doesn't support that and this is the best solution I could find.

Ok. I thought it more was a debugging thing to temporarily disable it.
I think the confusing part is that you think you should only need to touch the "Add you logic here" block and the rest should be as is.
I understand the reason when you explained it. But maybe it could be more obvious? For instance, could it be it's own block and named clearly before hitting the last "builtin" block?

Yeah, you're right, @tfsjohan. I think we just need to document it very prominently -- likely on the main README and in the FAQ. Want to take a crack at it? Would recommend you call it out and blockquote it like this...

⚠ This is what the switch does and it's currently enabled (or disabled) by default. Enable it when you want to activate subscriptions immediately after purchase. Disable it if you don't wish to immediately activate the subscription with the Marketplace. Something like this...

As I experienced this problem today, I took the liberty of creating the fix as @caseywatson suggested. @tfsjohan - hope you don't mind :)

Closing this out as the auto-complete behavior has been described in the FAQ and a warning has been added to the setup script. @piotrgradzinski, @tfsjohan, thank you for working this.


TypeError: SIP.WebRTC.getUserMedia is not a function

Hi,
When I try to make a call the console shows this error:

TypeError: SIP.WebRTC.getUserMedia is not a function

and the call never complete.
What could be the problem?
Thank you.

Are you using https?

The websocket is encrypted (wss before the host IP). But the browser connection is not. This can be the problem? Thank you.

Yes, access for getUserMedia() is allowed only over https.

Okay. I will try with https. Thank you very much.


Unexpected token '=' at Safari

I have found bug since 8.3.0 version of @vuepic/vue-datepicker.
When i connect datepicker
...
import VueDatePicker from '@vuepic/vue-datepicker';
...
i've got error "Unexpected token '='. Expected an opening '(' before a method's parameter list."
Error is found in function:
class Setter {
subPriority = 0;  <-------- Here
validate(_utcDate, _options) {
return true;
}
}
This error occurs at Safari 13.1.2 (136<IP_ADDRESS>.5) at MacBook.
Chrome works normaly.

Sorry, test again.
This error appears from v.8.0.
On v.7.4.1 there is no problem

It appears as a Safari problem, you can inspect the code and try adding needed polyfill
Safari 17.* looks ok
https://github.com/Vuepic/vue-datepicker/assets/23171105/9715718e-ce2e-44bb-abfb-792e7e2faeb8


Did the version string just change?

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
I have a script that invokes YT-DLP and downloads the latest version.
Until earlier today the version of YT-DLP-min I had saved had the version string "2022.04.08".
When I ran the script last I saw that I was now running "2022.03.08" (one month prior) and that the releases page, despite not showing a new update, does not list file hashes for this "new" version.
What happened?
Verbose log
PS C:\Program Files\YTDLP> .\yt-dlp_min.exe --version
2022.03.08

When I ran the script last I saw that I was now running "2022.03.08" (one month prior) and that the releases page, despite not showing a new update, does not list file hashes for this "new" version.

Always check versions with <, not =!

But yeah, the issue is #3653


Optimize Use of Codeset C for GS1-128 Barcodes

Summary
At present, barby does not optimally minimize the length of generated GS1-128 barcodes.
Our pull request modifies the existing minimization algorithm to properly account for FNC1 characters when choosing to switch to codeset C. We have also added a GS1-128 test suite to validate conformance to the GS1 specification reproduced below.
Details
Given the barcode data: [FNC1]10123456[FNC1]2099
The barcode is encoded as follows:
With the current implementation: [STARTB][FNC1][CODEC]10123456[CODEB][FNC1][CODEC]2099
After our proposed changes: [STARTC][FNC1]10123456[FNC1]2099
This breaks certain barcode scanners that impose very strict requirements on the width of GS1-128 barcodes.
We did notice that barby currently implements most of the guidelines offered by the GS1 General Specifications, Version 15 (issue 2) to minimize the length of generated barcodes. However, optimal handling of FNC1 characters in GS1-128 barcodes is currently missing.
We have reproduced the relevant section of the specification below:
<IP_ADDRESS>. Use of Start, Code Set, and Shift Characters to Minimize Symbol Length (Informative)

  The same data may be represented by different GS1-128 barcodes through the use of different combinations of Start, code set, and shift characters.

  The following rules should normally be implemented in printer control software to minimise the number of symbol characters needed to represent a given data string (and, therefore, reduce the overall symbol length).

  * Determine the Start Character:
  - If the data consists of two digits, use Start Character C.
  - If the data begins with four or more numeric data characters, use Start Character C.
  - If an ASCII symbology element (e.g., NUL) occurs in the data before any lowercase character, use Start Character A.
  - Otherwise, use Start Character B.
  * If Start Character C is used and the data begins with an odd number of numeric data characters, insert a code set A or code set B character before the last digit, following rules 1c and 1d to determine between code sets A and B.
  * If four or more numeric data characters occur together when in code sets A or B and:
  - If there is an even number of numeric data characters, then insert a code set C character before the first numeric digit to change to code set C.
  - If there is an odd number of numeric data characters, then insert a code set C character immediately after the first numeric digit to change to code set C.
  * When in code set B and an ASCII symbology element occurs in the data:
  - If following that character, a lowercase character occurs in the data before the occurrence of another symbology element, then insert a shift character before the symbology element.
  - Otherwise, insert a code set A character before the symbology element to change to code set A.
  * When in code set A and a lowercase character occurs in the data:
  - If following that character, a symbology element occurs in the data before the occurrence of another lowercase character, then insert a shift character before the lowercase character.
  - Otherwise, insert a code set B character before the lowercase character to change to code set B.
  When in code set C and a non-numeric character occurs in the data, insert a code set A or code set B character before that character, and follow rules 1c and 1d to determine between code sets A and B.

  Note: In these rules, the term “lowercase” is used for convenience to mean any code set B character with Code 128 Symbol character values 64 to 95 (ASCII values 96 to 127) (e.g., all lowercase alphanumeric characters plus `{|}~DEL). The term “symbology element” means any code set A character with Code 128 Symbol character values 64 to 95 (ASCII values 00 to 31).
  Note 2: If the Function 1 Symbol Character (FNC1) occurs in the first position following the Start Character, or in an odd-numbered position in a numeric field, it should be treated as two digits for the purpose of determining the appropriate code set.

We would like to highlight the following rule:
Note 2: If the Function 1 Symbol Character (FNC1) occurs in the first position following the Start Character, or in an odd-numbered position in a numeric field, it should be treated as two digits for the purpose of determining the appropriate code set.
The current minimization algorithm employed fails to adhere to this guideline, and treats FNC1 characters as non-codeset C characters. This results in unnecessary switching from codeset C to one of codeset A or B, and significantly increases the length of the generated barcode.

Hello,
Just wondering if there are plans to consider this pull request.
I very much understand that jobs / real life are higher priority.  :)
The reason I'm asking is because it would allow us to decide on how to proceed with getting access to the changes in this pull request.
Currently, we're proceeding with the assumption that the official barby gem will incorporate these changes. However, if the timing isn't good for you, then we will consider alternative options.
Thanks!

Sorry, I haven't had time to look at this yet. At first glance it looks
good and I expect that I will pull it into the gem, but I'll need some time
to look at it first.. I guess you've already built your own version to use
locally using these changes?
On Wed, Nov 30, 2016 at 8:20 PM, Clemens Park<EMAIL_ADDRESS>wrote:

Hello,
Just wondering if there are plans to consider this pull request.
I very much understand that jobs / real life are higher priority. :)
The reason I'm asking is because it would allow us to decide on how to
proceed with getting access to the changes in this pull request.
Currently, we're proceeding with the assumption that the official barby
gem will incorporate these changes. However, if the timing isn't good for
you, then we will consider alternative options.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/toretore/barby/pull/74#issuecomment-263968024, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAA-_LAIkAuHV7tvouLhEXfNSE41C3iks5rDcybgaJpZM4Ki4Sx
.

Thanks for the reply. =)
To re-iterate, no rush at all, just wanted to see how you wanted to proceed.
For now, we're pointing to a SHA, because we don't want to create a custom version of Barby.
We'd like to point to the official barby gem.
If your timeline is a bit far away (let's say a couple months away), then we will probably create roll a gem for the time being, for a bit more stability.

I've pushed 0.6.5 with your changes

Thanks!


function as trigger.enabled

many triggers' condition (like care about magic) are consistent in the whole battle, so there is no need to match regex then check if it fit the condition.
When we are loading a trigger, check it it's enabled with basic data properties like job, role.
then we could have something like this:
--- a/ui/raidboss/data/05-shb/eureka/delubrum_reginae.js
+++ b/ui/raidboss/data/05-shb/eureka/delubrum_reginae.js
@@ -33,7 +33,7 @@ export default {
       netRegexCn: NetRegexes.startsUsing({ source: '求道之三位一体', id: '5AB6', capture: false }),
-      condition: Conditions.caresAboutAOE(),
+      enabled: Conditions.caresAboutAOE(),
       response: Responses.aoe(),
     },
     {
@@ -658,7 +658,7 @@ export default {
       netRegexCn: NetRegexes.startsUsing({ source: '女王战士', id: '5800', capture: false }),
-      condition: Conditions.caresAboutAOE(),
+      enabled: Conditions.caresAboutAOE(),
       response: Responses.aoe(),
     },
     {

a litter bit more discussion:

But doesn't it cause performance issues? Since you have to iterate the huge trigger set array on every time you changed your job.

save references of triggers with function as enabled in a new container.
Triggers that could know if itself is enabled isn't that much I think.  We only need to check them on job change.

I think I'd be interested in understanding if there were reports of performance problems and if there were, then some measurements of what's slow so we could direct what the fix was.
I agree with you that this could be more efficient, but my priority is simplicity >>> efficiency.  In other words, only make things more complicated if it's solving a problem directly and don't add complexity to solve theoretical problems.

I'll say that I like this idea a lot; I think that performance, in general, is probably not the biggest concern here and that there's probably easier wins in other areas of the code, BUT I really like this concept.
I wonder if we could find a way to pre-process all of the triggers on TimelineReload to see if they have simple conditions that can already be met (such as no calls to matches and everything within the data they expect exists). This would help the runtime in the same way I think you've listed here, although it might add some complexity in timeline/popup-text, which I think people generally consider to be inaccessible? Or, at least, I see far fewer pull requests in that area of the code. What do you think about tackling this in another way that leaves the end-user's interface unchanged?

This just extend enabled property , user didn't need to change their code for this change.

I'd be more for implementing this as a new trigger property than trying to extend an existing property to fit this as well.
Something like:
type PreConditionFunc = (data) => boolean;
// On BaseTrigger...
  preCondition?: PreConditionFunc;
// On a trigger...
{
  id: 'something',
  preCondition: Conditions.caresAboutAOE(),
}

Order of operations would be:

Check disabled
Check preCondition
do preRun
As normal from here on out

This can be implemented in PopupText's OnLog and OnNetLog via something like:
  OnNetLog(e: EventResponses['LogLine']): void {
    const log = e.rawLine;
    // This could conceivably be determined based on `new Date(e.line[1])` as well, but
    // not sure if that's worth the effort
    const currentTime = +new Date();
    for (const trigger of this.netTriggers) {
      if (trigger.preCondition && !trigger.preCondition(this.data))
        continue;
      const r = trigger.localNetRegex?.exec(log);
      if (r)
        this.OnTrigger(trigger, r, currentTime);
    }
  }

For user interface, this just extend enabled property , user or we didn't need to change existed code for this change.

I think there is also complexity in popup-text.js.  Having to handle an additional property and think about cases where we need to reload where previously we didn't need to reload is just extra complexity.  If nobody will ever notice the performance improvement, then I think it's better to have the code be as simple as possible (to prevent bugs in the future, reduce the amount of features we have to support, reduce the cognitive load to understand the entire system).
If you're interested in raidboss performance, I would be interested in performance numbers to motivate making changes.  Personally, I don't see performance issues myself and haven't heard of people complaining about cactbot being slow.  On the other hand, I do feel like cactbot is pretty complicated (especially raidboss!) and so I am much more interested in making it simpler (or keeping it simpler).
If regexes are the problem, then numbers that would be help convince me are:

how many log lines per second does cactbot handle (mean/median/percentiles) in practice
pick 2-3 fights that have a lot of triggers (zadnor? an ultimate? e12s?) and run some tests to say "how long does it take to regex match an entire fight"

Once we have those two numbers, we can ask "is it worth doing some performance improvements" and "if it is worth it, how much do things improve when we make some specific change"? It might not even be the case that regexes are the biggest issue.  It's possible that time spent in regexes is small compared to time spent in Chrome internals and so the best performance win is to fix up CSS to reduce rendering time.  Or maybe OverlayPlugin's time spent generating DPS information is much huger than any time spent in raidboss and so that would be a much better thing to fix.  It's not clear to me at all where time is being spent and what proportion of time is being spent in various parts of the system.
Sorry to be negative here, but what I'm trying to get is that I would like to avoid optimizations where we assume we know what the problem is and add performance fixes without measuring and end up adding complexity with no benefit.

I still am iffy about this feature without any additional numbers to show if it's worth it or not.  Feel free to reopen if you have some examples of performance problems where adding this feature would help.


Response Caching Sample update to csproj

Response Caching Sample update to csproj

Hi @GuardRex, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@GuardRex  thanks again 👍


How to get this dataset?

Hello, how should i get this dataset?

Please email to<EMAIL_ADDRESS>

hello, i have emailed to you last week, did you received my email? If you cannot find it, please contact me at<EMAIL_ADDRESS>. Thank you very much!

Please email to<EMAIL_ADDRESS>
Hello, I emailed  to you again a few days earlier, did you receive it?


/data: Fix 'undefined' Zygarde ability

Tested all 4 cases (hidden, special, neither, both), they should look fine

Duplicate of #5153


Hashtags to indicate whether to cross-post to each platform?

Hey,
Sometimes I want to post something to only one platform (e.g. only to Mastodon, not Twitter) and it's obviously a huge pain in the arse to have to go back to moa.party to temporarily disable cross-posting (especially since that site doesn't seem to keep me logged in, so I have to reconnect it to Twitter and Mastodon each time - is that expected behaviour or something I'm doing wrong..? Can I maybe only be logged in from one device at a time, and logging in from another device kills the previous session?).
It'd be much easier if I could use hashtags to either opt-in or opt-out of cross-posting to the different platforms, like the ancient Twitter-to-Facebook cross-poster used to do with the #fb hashtag.
Ideally the hashtags would be as short as possible, to consume as few characters as possible (especially on Twitter), so my first thought is literally to use #t, #m and #i to opt-in to Twitter, Mastodon and Instagram cross-posting, respectively - maybe then using #nt, #nm and #ni as "NOT-Twitter", "NOT-Mastodon" and "NOT-Instagram" opt-outs for when Moa is configured to cross-post by default? I'm open to suggestions there, though 😸
With how Moa works now I'm currently inclined to keep cross-posting disabled from Mastodon-to-Twitter and always post on Twitter if I want something to end up on both platforms. It's a bit limiting, but that's the best set-up I've come up with so far without being able to easily opt-in and opt-out of cross-posting.

OK, I'll add this to the list. I'm inclined to simply offer a "conditional posting" setting and then set then make the hashtags non-customizable.