Glitchy transition on iOS Safari

Describe the bug
The transition between images is glitchy on mobile safari on iOS.
When swiping, the next image flashes up in the centre then jumps to its correct position off-screen to slide in, making the transition feel janky.
It's most noticeable when swiping, but something also flashes when I tap the next/previous buttons, although it's not so prominent.
Expected behavior
I expect when swiping or pressing 'next' the old image to slide away and the new image to slide in smoothly with no flashes of content.
How to reproduce
Load the "Basic example" from this page on mobile safari and then swipe through: https://yet-another-react-lightbox.com/examples/basic
Screenshots / Logs
See this screen recording on iOS 16.0 - note that the second or third swipe it becomes more prominent.
https://user-images.githubusercontent.com/66421/219638034-f636feb7-2231-4e72-b33c-1ac20798f722.mov
Additional context
No response

Hi Jamie,
Thank you for the detailed report. As crazy as it may sound, but have you tried restarting your browser? (force quit and reopen)
I've seen this glitch in the past but have never been able to reproduce it reliably, and restarting the browser always cured the glitch.

Writing this made me realise my iOS was a few updates behind, so I installed the update (which restarted the whole phone of course) and now the glitch is gone!
So I guess either a version update or a restart of the phone or browser solved it.

Yeah, this sporadic glitch has been driving me crazy for a long time (though I haven't seen it on my iOS devices for quite some time now). This library uses FLIP + WAAPI animation technique to animate slide swipes, and I'd really prefer to keep it this way rather than going back to CSS animation.
At this point, I have two theories about the root cause of this glitch:

Some pesky bug in my code that randomly causes this glitch in iOS Safari.
Some strange WebKit bug in iOS Safari that randomly manifests itself (dunno, maybe memory leak related since browser restart makes it go away).

I hope it's the latter and that it was fixed in one of the recent Safari versions since I haven't seen this glitch in a while.
Please let me know if you see this glitch again in the latest Safari version.

OK, thanks for this great info. I'll comment if I notice it again.

I'll go ahead and close this ticket in the absence of additional reports.


The maximum upload file size should be 50MB.

This error was actually a misconfiguration of the nginx-proxy, adding the following line to the configuration file (/etc/nginx/conf.d/(ishlearn).conf) fixes it:
client_max_body_size 50M;


feat: add support for \(\) and \[\] instead of $'s

Not too sure on some of the organization, particularly treating \( and \[ as dollars syntactically.
#import "packages/mitex/mitex.typ": *

= Converted

#let test_text = "
  \\(1 + 2\\)
  \\[1 + 2\\]
"

#raw(mitex-convert(mode: "text", test_text))
= Rendered

#eval(
  mitex-convert(mode: "text", test_text), mode: "markup", scope: mitex-scope,
)

gives

Closes #124

I'm not sure whether someone would like to override the command \( by renewcommand, in which we will fail since we treat \( as BeginMathInline rather than a generic command. Similarly, so do \), \[, and \]. But that is an edge case, so overall it looks good to me.

Thanks for the feedback! I added two tokens TokenStartMath and TokenEndMath, which seems to be the minimal necessary additions to clearly distinguish what's being used. (as opposed to adding StartMathDisplay and StartMathInline, which seemed inconsistent with the treatment of $ and $$ as one token)
Please let me know if there's anything else you see that could be improved

I have run tests and benchmarks locally, now the PR looks well to me.
This PR still lacks of an important thing, that add parsing tests to the mitex-parser to \(..\) and \[..\], but I forgot to tell you that.
I will push some parsing tests in later PR by myself.


Value resolver for hocon that converts the sys prop variable into int…

Description
A HOCON value resolver that's capable of doing value type detection. It should be able to detect Integer, Boolean and finally string based on the value. It's a must have in order to have an ability to merge with JSON having values in those types
Motivation and Context
HOCON supports variables resolving from system properties. However, by design it always wraps it as String. However, we're using JSON extensively to configure verticles. Verticle implementations are looking forward for values in type of Integer (e.g. port) or boolean, so there is a need to be able to properly inject those values.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

fixed comment


Hotfix/service search column filter

#91 Pull request for fix.

This change is

[Current coverage][cc-pull] is 58.31%

Merging [#98][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

File ...VOImageResource.java (not in diff) was modified. more

Misses 0
Partials -1
Hits +1

@@             master        #98   diff @@
==========================================
  Files          1873       1873
  Lines         95966      95970     +4
  Methods           0          0
  Messages          0          0
  Branches      11926      11926
==========================================
+ Hits          55957      55962     +5
  Misses        37064      37064
+ Partials       2945       2944     -1

[][cc-pull]

Powered by Codecov. Last updated by [e3b8d9e...cfcc576][cc-compare]
[cc-base-branch]: https://codecov.io/gh/servicecatalog/development/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/servicecatalog/development/compare/e3b8d9ee5a571ee6c8f4afb87011393b993fa850...cfcc576693c1c543059fcf4b2f1482fa9b3e95bf
[cc-pull]: https://codecov.io/gh/servicecatalog/development/pull/98?src=pr

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


No protection to against DDoS Attack from P2P

Description
The node won't be punished which keep sending malformed data through P2P.

I agree that it's better to have the P2P port protection.
Potential solution: whitelist rule
In reality, there are fewer cases where one would actively want to run a sync-node of an app-chain, which are usually maintained by several trusted validators.
If an app-chain is not completely permissionless, then open p2p port with a whitelist rule is accessible IMO.
So I suggest to postpone this optimization plan. Would like to hear @driftluo 's opinion.


[Circletracer] Add panel for circletracer webview

Add panel for circletracer webview
ONE-vscode-DCO-1.0-Signed-off-by: Donggil Lee<EMAIL_ADDRESS>

from draft #179
from issue #66.


file lock auto closed by go

i come across a problem and can not find a same issue, using go1.4
i used a file lock for process anti-reentry setting it to syscall.LOCK_EX|syscall.LOCK_NB in a function, but this lock would always be auto closed  after 2 minutes
i have attempted to use an struct member variable to store this file descriptor, but it was closed after 2 minites again
i have attempted to use an global variable to store it , and it works.
func LockUntilEx(lockfile string) (*os.File, error) {
    var mode os.FileMode = 0777
    file, err := os.OpenFile(lockfile, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, mode)
    if err != nil {
        return nil, err
    }

    err = syscall.Flock(int(file.Fd()), syscall.LOCK_EX|syscall.LOCK_NB)
    if err != nil {
        return nil, err
    }

    _, _, errno := syscall.RawSyscall(syscall.SYS_FCNTL, file.Fd(), syscall.F_SETFD, syscall.FD_CLOEXEC)
    if errno != 0 {
        return nil, errors.New(fmt.Sprintf("fail to set FD_CLOEXEC, for ", lockfile))
    }
    return file, nil
}
var usefulLock *os.File

type TestLock struct {
    uselessLock *os.File
}

func (this *TestLock) Lock() (err error) {
    path := "/tmp/filename"
    this.uselessLock, err = LockUntilEx(path)
    if err != nil {
        return err
    }
    return nil
}

func  Lock() (err error) {
    path := "/tmp/filename"
    uselessLock, err := LockUntilEx(path)
    if err != nil {
        return err
    }
    fmt.Println("lock succ ", uselessLock)
    return nil
}

func main() {
    l := new(TestLock)
    if err := l.Lock(); err != nil {
        fmt.Println(err)
        return
    }
    for {
        fmt.Println(time.Now())
        time.Sleep(time.Second)
    }
}

my questions are:

is this file descriptor closed by gc? why struct member variable closed and global variable not?
is there any suggested way to use file lock

Yes, your file descriptor is being closed when all references to the
os.File you created to lock goes out of scope.
On Mon, 15 Aug 2016, 19:30 galric<EMAIL_ADDRESS>wrote:

i come across a problem and can not find a same issue, using go1.4
i used a file lock for process anti-reentry setting it to
syscall.LOCK_EX|syscall.LOCK_NB in a function, but this lock would always
be auto closed after 2 minutes
i have attempted to use an struct member variable to store this file
descriptor, but it was closed after 2 minites again
i have attempted to use an global variable to store it , and it works.
func LockUntilEx(lockfile string) (*os.File, error) {
var mode os.FileMode = 0777
file, err := os.OpenFile(lockfile, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, mode)
if err != nil {
return nil, err
}
err = syscall.Flock(int(file.Fd()), syscall.LOCK_EX|syscall.LOCK_NB)
if err != nil {
    return nil, err
}

_, _, errno := syscall.RawSyscall(syscall.SYS_FCNTL, file.Fd(), syscall.F_SETFD, syscall.FD_CLOEXEC)
if errno != 0 {
    return nil, errors.New(fmt.Sprintf("fail to set FD_CLOEXEC, for ", lockfile))
}
return file, nil

}
var usefulLock *os.File
type TestLock struct {
uselessLock *os.File
}
func (this *TestLock) Lock() (err error) {
path := "/tmp/filename"
this.uselessLock, err = LockUntilEx(path)
if err != nil {
return err
}
return nil
}
func  Lock() (err error) {
path := "/tmp/filename"
uselessLock, err := LockUntilEx(path)
if err != nil {
return err
}
fmt.Println("lock succ ", uselessLock)
return nil
}
func main() {
l := new(TestLock)
if err := l.Lock(); err != nil {
fmt.Println(err)
return
}
for {
fmt.Println(time.Now())
time.Sleep(time.Second)
}
}
my questions are:

is this file descriptor closed by gc? why struct member variable closed
and global variable not?
is there any suggested way to use file lock

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/16700, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcAx-V2lOQQBhkNh6_XilT7GqUW-8Hks5qgDGTgaJpZM4JkPRv
.

when i used member variable of a struct to store this  os.File object, it was also closed even if the struct object not out of scope

Can you provide a complete runnable example?

On 15 Aug 2016, at 21:14, galric<EMAIL_ADDRESS>wrote:
when i used member variable of a struct to store this os.File object, it was also closed even if the struct object not out of scope
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

The GC and the compiler are conspiring here to do their best to clean up a
program that does not close a file. "Their best" in this case means that
the compiler notices that "l" is dead after line 3 in main. The GC notices
that it hasn't done a GC is a long time so it executes a GC. The GC
correctly notices that "l" is no longer live and the referent is collected.
The GC sees that the file that has not been closed so it runs a finalizer
that closes the file.
All this could have been avoided if the program simply closed the file
instead of relying on when the GC and finalizers are run and how good the
compiler is about identifying dead variables.
Your questions.
my questions are:

is this file descriptor closed by gc? Yes, by the finalizer.
why struct member variable closed and global variable not?
The compiler thinks the global variable is live. The compiler can prove
the local variable is dead. The GC relies on this information.
is there any suggested way to use file lock
If a program opens a file, close the file. Never rely on a finalizer,
they will cause pain. "Never rely on a finalizer to close a file" is an
instance of the more general statement "Never rely on a finalizer". Sure
sometimes a program has no choice but finalizers should never be the first
choice.

The compiler and the GC will keep getting smarter. In this case 1.7 figured
out that "l" is dead after line 3.
On Mon, Aug 15, 2016 at 7:16 AM, Dave Cheney<EMAIL_ADDRESS>wrote:

Can you provide a complete runnable example?

On 15 Aug 2016, at 21:14, galric<EMAIL_ADDRESS>wrote:
when i used member variable of a struct to store this os.File object, it
was also closed even if the struct object not out of scope
—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/16700#issuecomment-239779874, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7Wn5sbfmhj87CSe-aTxfSH6dTVXRzpks5qgEqAgaJpZM4JkPRv
.

Closing, since this is more of a question than a bug report. It's also about a quite-old release of Go.
(Question policy: https://golang.org/wiki/Questions)


ENH: Use ITKPythonPackage with updated dockcross

Closes #13. Closes https://github.com/google/tensorstore/issues/69.

It should be merged, via a merge commit so the sha1 used here remain valid. PR open: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/249.


in_tail: avoid unnecessary open()s

As discussed in https://groups.google.com/forum/#!topic/fluentd/BBRde4Lyl9E

The Travis CI build failures seem unrelated to my change ... (UdpInputTest EADDRINUSE)

Possible file rotation cases:

File is rotated before stat = FileWrapper.stat(@path)

No problem.

File is rotated ater stat = FileWrapper.stat(@path)

2a. if @inode != inode || fsize < @fsize is false
No problem. Next trigger should detect file rotation.
2b. if @inode != inode || fsize < @fsize is true
It seems no problem. on_rotate also checks stat info with previous file.
So this patch should not effect existing behaviour.
Does anyone have any concern for this patch?

There are no problem, I will merge this patch today.

@sonots Could you check again?

LGTM

Thanks for the patch!


$whatif not working on Graph Explorer

Describe the bug
$whatif does not work for Microsoft tenant in Graph Explorer
To Reproduce
Steps to reproduce the behavior:

Go to Graph Explorer while not logged in
Paste this: https://graph.microsoft.com/v1.0/me?$whatif
This works
Try the same query while logged in Microsoft tenant
Fails.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

The microsoft graph sdk version should fix this. We have tested $whatif with @nikithauc

@thewahome is the linked pull request here correct?  Isn't the change needed here to pick up the next JS sdk version?

@thewahome is the linked pull request here correct?  Isn't the change needed here to pick up the next JS sdk version?

The linked pull request should bring in the latest JS sdk version.


Issue with 'AudioInput' namespace

Issue:
Console error appears on import of KlakLasp.unitypackage
Error Message:

Assets/Klak/Audio/AudioInput.cs(82,26): error CS0234: The type or namespace name 'AudioInput' does not exist in the namespace 'Lasp' (are you missing an assembly reference?)

Fix:
Change line 82 of AudioInput.cs

get { return Lasp.AudioInput.CalculateRMSDecibel(_filterType); }

to ->

get { return Lasp.MasterInput.CalculateRMSDecibel(_filterType); }

version: Unity 2019.2.9f1

I ran into this same issue... but @lkewis' fix did not work for me. Trying to debug whether this is due to a related plugin (LASP v2 maybe?)

On Sun, Apr 5, 2020 at 4:17 PM Patrick Ewing<EMAIL_ADDRESS>wrote:

I ran into this same issue... but @lkewis https://github.com/lkewis'
fix did not work for me. Trying to debug whether this is due to a related
plugin (LASP v2 maybe?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keijiro/KlakLasp/issues/4#issuecomment-609501431, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AI277CYDUN2SFARJHHKYVNLRLEGPBANCNFSM4JHL7H3A
.

Wrong email address

I'm having the same issue after installing Lasp then KlakLasp... The 'fix' didn't work for me.


WIP

Hey there @rajkalemsft - Was this PR supposed to be against our repo?  I see it's WIP/Draft, but want to be sure since it looks like it's got a mix of personal project artifacts and yet some potential contributions around introducing a devcontainer.  Can you summarize what your plan is for this PR in the body as part of good PR hygiene?  Thanks.  Feel free to reach out to me on Teams as well, if you'd like to chat offline.


The code uses more GPU memory with Multi-scale Vision Transformers

Hi,
Thanks for the great work! I'm currently trying to apply your code to vision transformers, specifically, on this code base:
https://github.com/facebookresearch/SlowFast/tree/main/projects/mvit
When using torch.optim.SGD(momentum=0.9), the code consumes 9221MiB GPU memory during training. After changing it to use bnb.optim.SGD8bit() with the same arguments, it consumes even a bit more GPU memory of 9235MiB. Do you have any idea why this would happen? Thank you! My CUDA version is 10.2 and torch version is 1.9.1.
Best,
Junwei

Hi Junwei, how many parameters does the model have? From the paper, it seems some models have about 50M parameters from which you would expect to save about ~150MB of memory. If you look at the memory of nvidia-smi, then you see maximum allocated memory which is not necessarily equal to the actual memory usage. It is closer to peak usage.
Do you see this excessive memory consumption with you start the model with these setups with different random seeds?

Hi Tim,
Thanks for replying. Based on the MViT paper(Table 5), the one I'm using (MViT-B_32x3) has 36.8 million parameters. I'm not sure why this model would takes 9GB GPU memory in peak usage even with batch_size=1 per GPU in the first place.
I changed the random seed and the GPU memory consumption with SGD8bit did not change. I think if in theory we are looking at only 36.8*3 MB memory saving, it would not be noticeable from nvidia-smi.


Exception during disconnection

Just a word, to start
!!! Thank you very much for your excellent job !!!
Describe the bug
When using MQTTNet with ASP .Net Core 3.1,i sometimes have an exception during disconnection.
Which project is your bug related to?

Client

To Reproduce
Steps to reproduce the behavior:

Using this version of MQTTnet '3.0.13'.
Run this code 'see below for Controller class'.
See error.

Expected behavior
The expected behaviour is that the controller doesn't throw any exception. But from times to times (unpredictable), i receive the exception in the next paragraph.
I took a look at the MQTTnet.Client.MqttClient code but wasn't able to figure how DisconnectAsync could directly call itself.
Additional context
As you can see, i used a method called TimeoutAfter. It is because i'm working on a more general problem : my service hangs, from times to times, but silently. More precisely, it consumes CPU and just do nothing (it doesn't receive messages anymore, for example).
When upgrading from 3.0.10 to 3.0.13, with stricly no changes at my code, i had a good improvement of my problem, with less occurences.
Additional logging
System.OperationCanceledException: The operation was canceled.
   at MQTTnet.Adapter.MqttChannelAdapter.SendPacketAsync(MqttBasePacket packet, TimeSpan timeout, CancellationToken cancellationToken)
   at MQTTnet.Client.MqttClient.DisconnectAsync(MqttClientDisconnectOptions options, CancellationToken cancellationToken)
   at MQTTnet.Client.MqttClient.DisconnectAsync(MqttClientDisconnectOptions options, CancellationToken cancellationToken)
   at APIK.Binding.ActilityHub.Controllers.UplinkController.TimeoutAfter(Task task, Int32 millisecondsTimeout, String taskName) in /src/src/APIK.Binding.ActilityHub/Controllers/UplinkController.cs:line 94
   at APIK.Binding.ActilityHub.Controllers.UplinkController.Post() in /src/src/APIK.Binding.ActilityHub/Controllers/UplinkController.cs:line 60

Code example
namespace Controllers
{
    [ApiController]
    [Route("uplink")]
    public class UplinkController : ControllerBase
    {
        private readonly ILogger<UplinkController> _logger;
        private readonly IMQTTConnectionFactory _mqttConnectionFactory;

        public UplinkController(ILogger<UplinkController> logger, IDbConnectionFactory dbConnectionFactory, IMQTTConnectionFactory mqttConnectionFactory)
        {
            _logger = logger;
            _mqttConnectionFactory = mqttConnectionFactory;
        }

        [HttpPost]
        public async Task<IActionResult> Post()
        {
            try
            {
                using (var mqttClient = await TimeoutAfter(_mqttConnectionFactory.GetClientASync(), 5000, "_mqttConnectionFactory.GetClientASync()"))
                {
                    var payload = "Hello, world!";

                    var message = new MqttApplicationMessageBuilder()
                        .WithTopic("ActilityHub/Uplink/")
                        .WithPayload(payload)
                        .WithQualityOfServiceLevel(MqttQualityOfServiceLevel.AtLeastOnce)
                        .Build();
                    await TimeoutAfter(mqttClient.PublishAsync(message), 5000, "mqttClient.PublishAsync(message)");

                    message = new MqttApplicationMessageBuilder()
                        .WithTopic("actilityhub/uplink/")
                        .WithPayload(payload)
                        .WithQualityOfServiceLevel(MqttQualityOfServiceLevel.AtLeastOnce)
                        .Build();
                    await TimeoutAfter(mqttClient.PublishAsync(message), 5000, "mqttClient.PublishAsync(message)");

                    await TimeoutAfter(mqttClient.DisconnectAsync(), 5000, "mqttClient.DisconnectAsync");
                }
            }
            catch (Exception ex)
            {
                _logger.LogError("Une erreur de traitement grave a été rencontrée : {exception}", ex.ToString());
            }
            return Ok();
        }

        public async Task<T> TimeoutAfter<T>(Task<T> task, int millisecondsTimeout, string taskName = "undefined task")
        {
            if (task == await Task.WhenAny(task, Task.Delay(millisecondsTimeout)))
            {
                return await task;
            }
            else
            {
                _logger.LogError("Expiration d'un timeout durant le traitement de {task}", taskName);
                throw new TimeoutException("Expiration d'un timeout durant le traitement de " + taskName);
            }
        }

        public async Task TimeoutAfter(Task task, int millisecondsTimeout, string taskName = "undefined task")
        {
            if (task == await Task.WhenAny(task, Task.Delay(millisecondsTimeout)))
            {
                await task;
            }
            else
            {
                _logger.LogError("Expiration d'un timeout durant le traitement de {task}", taskName);
                throw new TimeoutException("Expiration d'un timeout durant le traitement de " + taskName);
            }
        }
    }
}

@fphilippe Please try with latest RC from nuget. We changed some bits in exactly that area.

@fphilippe Please try with latest RC from nuget. We changed some bits in exactly that area.

Hi @chkr1011,
Thank you very much for your reply. I've put the 3.0.14-rc8 version of your lib in test and as you expected, the function TimeoutAfter has not thrown any more exception. However, i continue to have a strange behaviour regarding to the disconnection behaviour... From time to time, my program hangs without exiting nor throwing any exception. When using dotnet trace, i see a hot trace around MqttTcpChannelDispose, after beeing passed in TryInitiateDisconnect. You'll find, in the following screenshot, the hot trace :

I make a link with the previous behaviour i've described in this issue. Perhaps i'm totally wrong, or i make a mistake in using the lib...
Regards,
Fabien

Please test with version 4 and reopen this ticket if the issue still occurs.


Use sklearn's input validation?

I wrote some input validation functions (e.g., Basis._check_array), but it might be better to just use scikit learn's.

we decided to not depend on sklearn in the end. We might use pydandic eventually


Python funcions do not work since kubernetes 1.9.4, Init container fail

Is this a BUG REPORT or FEATURE REQUEST?:
Bug report
What happened:
when testing a simple Python  function, the Init container of the created pod failed with the message:
sh: can’t create /src/post.py.sha256: Read-only file system
when the pod was scheduled on a node with Kubernetes 1.9.4 .
when the pod was scheduled on a node with Kubernetes 1.9.3 it works correctly
What you expected to happen:
That it works even on a 1.9.4 node
How to reproduce it (as minimally and precisely as possible):
Use a testing python function as shown in the quick start.
Anything else we need to know?:
With Kubernetes 1.9.4, Config map are always mounted in read only mode https://github.com/kubernetes/kubernetes/pull/58720
Environment:

Kubernetes version (use kubectl version): 1.9.4
Kubeless version (use kubeless version): 0.4.0
Cloud provider or physical cluster:

Hi @daverick,
Could you provide more information about the error you are receiving? I have tested a python function with dependencies with minikube 0.25.0 (which uses Kubernetes v1.9.0) and it deployed the function successfully. What are the logs of the init container that is failing for you? You can retrieve them executing:
kubectl logs <YOUR_FUNCTION_POD> -c install

Also kubectl describe <YOUR_FUNCTION_POD> can provide some additional info about the issue.

Hi @andresmgot,
The log from the Init container is
sh: can’t create /src/post.py.sha256: Read-only file system
The problem occurs  only with Kubernetes 1.9.4 not with previous version (or at least not with 1.9.3 the version of my other node).
When I try to found what was wrong with my configuration, replicating what the pod was doing I have found that config maps were mounted  read only, which explains this  failure.
The Kubernetes 1.9.4 contains  the PR https://github.com/kubernetes/kubernetes/pull/58720 : Ensure that the runtime mounts RO volumes read-only.
( i will use my 1.9.3 node while the issue is solved)

Indeed, I am able to reproduce it using Kubernetes 1.9.4. I will submit a PR for fixing this.

@daverick the fix has been merged. It will available in the next release of Kubeless. Thanks for reporting!

@andresmgot, thanks!

@andresmgot  when is this getting released?

@gkarthiks we plan to do a release next week, this new release will include a lot of changes so we are making sure everything is in order before we release.


implement new api for publishReport

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

closes #19, #64 and #58


How to trigger event on load finish?

I need to know when the panorama has finished loading, is there a way of doing so?

Ok, so i changed a variable every time onImageLoad() was called and then i listened to changes on this variable.


Issue 1150 Bugfix video restart

Fixes #1150
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Smoke testing as described in the issue
Summary
Reset the proper flags in proxy base
CLA

[X] I have signed the CLA

Codecov Report

Merging #1160 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop    #1160      +/-   ##
=============================================
- Coverage      46.98%   46.97%   -0.01%
  Complexity      4185     4185
=============================================
  Files            470      470
  Lines          22830    22832       +2
  Branches        2588     2588
=============================================
  Hits           10726    10726
- Misses         11460    11462       +2
  Partials         644      644

Impacted Files
Coverage Δ
Complexity Δ

...n/java/com/smartdevicelink/proxy/SdlProxyBase.java
8.3% <0%> (-0.01%)
27 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8aeea1...ac56792. Read the comment docs.

Closed in favor of #1161


docs: add Paquet to showcase

Just adding a production app that uses deno_kv_oauth in the showcase.

This is very nice to see! Great stuff! Thank you.


Fix flair inference for NER

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.25%. Comparing base (16c2e0f) to head (36ae7ca).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   47.50%   50.25%   +2.75%
==========================================
  Files          13       16       +3
  Lines         640      796     +156
==========================================
+ Hits          304      400      +96
- Misses        336      396      +60

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Get and set row headers

Would it be possible to get and set the row headers (labels)? The default labels enumerate the rows 1, 2, 3,... in the leftmost column, and it would be nice to be able to change those labels using get and set methods.

Or hide them entirely would also be an option. I can't seem to find anything in the documentation at the moment if that is possible.


LauraTTS的GPT没有任何优化吗? 直接用的torch.matmul?

如题... 这样batchsize能撑起来吗?

Sorry, I can't understand your question, please provide more details to specify the question, thanks.

My bad, let me explain my question.
As far as I know, big GPT-like models always use some optimization in attention like FlashAttention for less GPU mem cost and improve the forward speed. However, I didn't find any like this, only find a "torch.matmul" at here. I'd like to make sure that I'm correct, or there is optimization somewhere else~

Yes, you are correct. In FunCodec and LauraTTS, we didn't include any optimization on attention operation, since the model is very small.

Thanks for your reply!
After reading the code, I still have two little questions:

Is LauraTTS a totally independent model, which is trained from scratch without any pretrained parameters from LauraGPT?
2.Since I see LauraGPT paper is also referenced in this repo, also taking into consideration that LauraGPT and LauraTTS has highly similar name, what's the relevance between both?

Yes, LauraTTS is a totally independent model, you can train it from scratch on LibriTTS corpus with the released code.
The reason of LauraGPT paper referencing this repo is because LauraGPT use the same codec model to tokenize speech signals. In fact, LauraTTS can be treated as a improved version of LauraGPT for TTS task only. There are two main differences between LauraTTS and LauraGPT in terms of TTS task: 1) LauraTTS use two codec groups in LM model rather than one. 2) In LauraTTS the LM and NAR model are jointly trained while they are trained separately in LauraGPT.

Thanks for your reply! After reading the code, I still have two little questions:

Is LauraTTS a totally independent model, which is trained from scratch without any pretrained parameters from LauraGPT?
2.Since I see LauraGPT paper is also referenced in this repo, also taking into consideration that LauraGPT and LauraTTS has highly similar name, what's the relevance between both?

Yes, LauraTTS is a totally independent model, you can train it from scratch on LibriTTS corpus with the released code.
The reason of LauraGPT paper referencing this repo is because LauraGPT use the same codec model to tokenize speech signals. In fact, LauraTTS can be treated as a improved version of LauraGPT for TTS task only. There are two main differences between LauraTTS and LauraGPT in terms of TTS task: 1) LauraTTS use two codec groups in LM model rather than one. 2) In LauraTTS the LM and NAR model are jointly trained while they are trained separately in LauraGPT.


fixed build after pull request #2

After merging the pull request #2 the project doesn't build anymore. This fixes the problem.
With this fix I can confirm, that changing the logo works as expected.

Interested in this to be merged, the SlotOptions is not accessible in the main branch so the logo can't be updated.


The objects list is not displayed correctly

Hi! I am doing a controller that has to receive an object. This object has a list of objects of type < ShippingAddressDTO>.
My problem is that swagger does not show the object type of the list. Even knowing the object type and introducing the fields in swagger, it arrives as null in the controller.

I use the following libraries for the code:
Swashbuckle.AspNetCore.Annotations Version="5.6.3"
Swashbuckle.AspNetCore.SwaggerGen Version="5.6.3"
Swashbuckle.AspNetCore.SwaggerUI Version="5.6.3"
Swashbuckle.AspNetCore.Filters Version="6.0.0"
Microsoft.AspNetCore.Authorization;
Microsoft.AspNetCore.Mvc;
Microsoft.AspNetCore.Mvc.ModelBinding;
I have deleted the unnecessary code. Here is the swagger file.
{   "openapi": "3.0.1",   "info": {     "title": "Distrib WebAPI",     "description": "Welcome to Distrib WebAPI. Please check Authentication paragraph at the end of the document to know how to authenticate against the API before using it.You can switch between definitions at the top of documentation to watch the API methods corresponding to the version of the API you are using",     "version": "v<IP_ADDRESS>-ECommerce"   },   "servers": [     {       "url": "/pccom"     }   ],   "paths": {     "/PCCOM.Distrib.Clients.ECommerce/Clients": {       "post": {         "tags": [           "Clients"         ],         "summary": "Creates a new B2B or B2C client",         "requestBody": {           "content": {             "multipart/form-data": {               "schema": {                 "required": [                   "ShippingAddresses"                 ],                 "type": "object",                 "properties": {                   "Role": {                     "$ref": "#/components/schemas/PCCOM.Distrib.Core.DTOs.RoleType"                   },                   "PDFDocument": {                     "type": "string",                     "format": "binary",                     "nullable": true                   },                   "ShippingAddresses": {                     "type": "array",                     "items": {                       "$ref": "#/components/schemas/PCCOM.Distrib.Clients.DTOs.v1_6.ShippingAddDTO"                     }                   }                 }               },               "encoding": {                 "Role": {                   "style": "form"                 },                 "PDFDocument": {                   "style": "form"                 },                 "ShippingAddresses": {                   "style": "form"                 }               }             }           }         },         "responses": {           "201": {             "description": "Creates a new client",             "content": {               "application/json": {                 "schema": {}               }             }           },           "400": {             "description": "Invalid model submitted"           },           "401": {             "description": "User not successfully authenticated"           },           "403": {             "description": "User without client creation permission"           },           "500": {             "description": "Internal server error"           }         }       }     }   },   "components": {     "schemas": {       "PCCOM.Distrib.Core.DTOs.RoleType": {         "enum": [           1,           2         ],         "type": "integer",         "format": "int32"       },       "PCCOM.Distrib.Clients.DTOs.v1_6.ShippingAddDTO": {         "type": "object",         "properties": {           "address": {             "type": "string",             "nullable": true           },           "phoneNumber": {             "type": "string",             "nullable": true           }         },         "additionalProperties": false       }     },     "securitySchemes": {       "Bearer": {         "type": "apiKey",         "description": "JWT Authorization header using the Bearer scheme. Example: \"Authorization: Bearer {token}\"",         "name": "Authorization",         "in": "header"       }     }   },   "security": [     {       "Bearer": []     }   ] }

As far as I'm aware, this is a SwaggerUI issue - it will only pre-populate the forms in the UI if you provide an example payload.


Update phinx dependencies

There is phinx 0.10.x already, which has a lot of nice features. It would be nice to use it and not being restricted to some phinx version.

I'm not using Phinx anymore. I'm prepared to merge this if you have tested everything an can confirm, that it still works.
On another note I've created a Migratum as I have been dissatisfied with the way Phinx was going.


Move failed log in logging to trigger when authentication fails rathe…

…r than when form has errors
Description
Prior to this change, the logging for failed sign in error was triggered when the sign in form had errors, however after seeing the logging go live it became clear that this logging should be triggered when authentication fails. This PR corrects this misplaced logging.

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

Codecov Report

Merging #1724 (3f736b1) into master (8734e3c) will decrease coverage by 86.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #1724       +/-   ##
==========================================
- Coverage   89.72%   3.67%   -86.05%
==========================================
  Files         399     399
  Lines        8619   13123     +4504
  Branches     1253     231     -1022
==========================================
- Hits         7733     482     -7251
- Misses        703   12640    +11937
+ Partials      183       1      -182

Impacted Files
Coverage Δ

app/controllers/users/sessions_controller.rb
0.00% <0.00%> (-98.12%)
:arrow_down:

app/jobs/send_user_invitation_job.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/role.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/team.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/alert.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/contact.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/country.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/product.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/accident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/incident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8734e3c...3f736b1. Read the comment docs.


Fix broken doc links

What type of PR is this?

/kind documentation
What this PR does / why we need it:
broken links
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

NONE

Thanks @frankbu!
/lgtm
/approve

Clearing accidental auto-hold because this touched a GEP.
/hold cancel


Close multi diff refactor preview editor on discard and accept

Fixes https://github.com/microsoft/vscode/issues/205694
note: not sure if should make the schema in the provider static and if the two schemas should maybe be grouped in the same class

if the two schemas should maybe be grouped in the same class

What do you mean with that?

I meant to say that I have a BulkEditPane.Schema and a BulkEditPreviewProvider.Schema which correspond to the full multi diff editor schema and the individual editor schemas. I was thinking maybe these should be grouped in the same class since they are closely related.


Transaction continued

continue #156

[ ] remove the is_mock_connection checks and still make the test suite pass
[ ] investigate how to remove the extra * from Rocket example save(&*conn)
[ ] enhance our MockConnection such that it also 'supports' transaction

investigate how to remove the extra * from Rocket example save(&*conn)

It seems that we need a dynamic dispatch version &dyn ConnectionTrait to really eliminate the &*conn quirk.


Hierarchical tags, better tags management

Adds tree-like structure to tags and the ability to manage both flat and hierarchical tags.

👍 Looks great!


Discard master/slave phrasing

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

I agree completely with this sentiment. However, this is a historical repository (it's the pre-OpenStack version of what eventually became Nova) and I would prefer to keep it pristine, i.e. exactly as it was when it was imported.


Version 3.0 Not Showing Notifications if app in foreground

Is version 3.0 meant to show the notification in the foreground? I believe the change-log says it does, but I am not able to get that to work.
On iOS.  Removed old plugin version, cleaned out iOS platform, then added new version of plugin.
Example:
component.ts
require("nativescript-local-notifications");
import { LocalNotifications } from "nativescript-local-notifications";  /*btw, I used to use 'import * as LocalNotifications from "nativescript-local-notifications" but that does not work anymore for some reason*/
...
LocalNotifications.schedule([{
        id: 1,
        title: 'title',
        body: 'this should be the body',
        at: new Date(new Date().getTime() + (10 * 1000)) // 10 seconds from
    }])

This works if I put the app in the background, but not if the app is in the foreground. It does seem like I can hear the notification if the app is in the foreground, but I cannot see the notification.

It’s in the F manual: forceShowWhenInForeground

Thanks very much! Sorry to miss that. It does seem to work now.
On another previous issue--adding an array of notifications (so that one notification could show up at an interval set by user)--prior working code no longer works after upgrade. I have added a comment to that issue [https://github.com/EddyVerbruggen/nativescript-local-notifications/issues/102(here).


Feature Request: SwaggerUI Auth Options

Describe the issue
SwashBuckle.ASpDotnetCore Provides built-in UI support for for OAuth 2.0 flows that help developers quickly stand up Swagger UIs with data pre-filled in, such as OAuth ClientIds, etc. This also reduces the amount configuration the user needs to do per function and would reduce the developer's need to copy and paste this information from another source.
Would it be possible for this to support such functionality or would that fall out of scope for the intended use of the extension?
If not, since SwashBuckle is not compatible with Az Functions, do you have a suggested way I might pre-full this?
Screenshots
For example, with SwashBuckle, I can configure The SwaggerUI such that the API itself can fill this out without the user needing to copy and paste these kinds of secrets from elsewhere:

Would be interested in this aswell

@ctraftoncodes Thanks for the issue! We already support OAuth2 authentication. But it seems that you want some extra features in addition to it. Would you please eleborate?

@ctraftoncodes Thanks for the issue! We already support OAuth2 authentication. But it seems that you want some extra features in addition to it. Would you please eleborate?

I'm facing a similar situation. Using swashbuckle as a basis for comparison, if you check out the class OAuthConfigObject it exposes properties allowing the client id and selected scopes to be pre-set in swagger UI; that's really just a convenience, but a very convenient one, particularly for my testers.
More importantly for my use case it provides a property UsePkceWithAuthorizationCodeGrant. Specifically I'm trying to configure swagger UI to allow sign-in to the same AzureAD B2C tenant/client that our Angular webapp uses, and without access to PKCE configuration that's not currently possible.  However it's unclear from the OpenAPI.NET repo whether they support 3.1.0 yet, which is when PKCE support appears, so this may be contingent on one of your dependencies updating first.

@DanMannMann that is the use case I am referring to - it would be nice to be able to pre-set a few values the way that you have described with Swashbuckle's OAuthConfigObject. For my use case, it is, as described, simply a convenience that would help us when testing and remove the need to copy and paste the ClientID for OAuth2.
I understand this may be out of scope for this package but could be a useful as others have described.
Please let me know @justinyoo if I can provide further clarification. :)

@ctraftoncodes Oh I see. Let's keep this discussion open and see how it goes. I don't currently have a clear roadmap on this, though.

Any progress on adding support for allowing the client id and selected scopes to be pre-set in swagger UI?

+1

I'd say problem is that this extension lacks decent extension points for configuring SwaggerUI. I managed to get PKCE working and configuring default ClientId, scopes, etc by injecting custom JavaScript which configures OAuth after swagger bundle is configured and assigned to window.ui.
services.AddSingleton<IOpenApiCustomUIOptions>( _ =>
{
    var assembly = Assembly.GetExecutingAssembly();
    var options = new OpenApiCustomUIOptions( assembly )
    {
        GetStylesheet = () => Task.FromResult( string.Empty ),
        GetJavaScript = () => Task.FromResult(
            """
            function onValueUpdate(ui) {
               ui.initOAuth({
                    clientId: "<my_client_id>",
                    clientSecret: "<my_client_secret>",
                    scopeSeparator: " ",
                    scopes: "openid profile",
                    usePkceWithAuthorizationCodeGrant: true
               });
            }

            Object.defineProperties(window, {
                _ui: {
                    value: 'object',
                    writable: true
                },
                ui: {
                    get: function() {
                        return this._ui;
                    },
                    set: function(val) {
                        this._ui = val;
                        onValueUpdate(this._ui);
                    }
                }
            });
            """ )
    };

    return options;
} );

It needed some tweaking because how the default index.html looks like.
https://github.com/Azure/azure-functions-openapi-extension/blob/main/src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/dist/index.html#L36-L62
A better option would be to do like Swashbuckle.
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.SwaggerUI/index.js
Swagger UI OAuth2 configuration docs:
https://swagger.io/docs/open-source-tools/swagger-ui/usage/oauth2/


Server stopping bug

Investigate, why the production backend service stops from time to time.

The full error message is quite lengthy...

 Full Error
 packages.GetPackageUpdates() error: error getting apt updates: error running /usr/bin/apt-get with args ["update"]: exit status 100, stdout: "Get:1 http://security.debian.org/debian-security buster/updates InRelease [34.8 kB]\nGet:2 http://deb.debian.org/debian buster InRelease [122 kB]\nGet:3 https://nvidia.github.io/libnvidia-container/stable/debian10/amd64  InRelease [1484 B]\nGet:4 http://deb.debian.org/debian buster-updates InRelease [56.6 kB]\nHit:5 https://nvidia.github.io/nvidia-container-runtime/stable/debian10/amd64  InRelease\nHit:6 https://nvidia.github.io/nvidia-docker/debian10/amd64  InRelease\nGet:7 https://download.docker.com/linux/debian buster InRelease [54.0 kB]\nGet:8 http://deb.debian.org/debian buster-backports InRelease [51.4 kB]\nGet:10 http://packages.cloud.google.com/apt cloud-sdk-buster InRelease [6396 B]\nGet:11 http://packages.cloud.google.com/apt google-cloud-packages-archive-keyring-buster InRelease [5163 B]\nGet:9 https://packages.cloud.google.com/apt kubernetes-xenial InRelease [8993 B]\nGet:12 http://packages.cloud.google.com/apt gcsfuse-buster InRelease [5004 B]\nGet:13 http://packages.cloud.google.com/apt google-compute-engine-buster-stable InRelease [5136 B]\nErr:10 http://packages.cloud.google.com/apt cloud-sdk-buster InRelease\n  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nErr:11 http://packages.cloud.google.com/apt google-cloud-packages-archive-keyring-buster InRelease\n  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nErr:9 https://packages.cloud.google.com/apt kubernetes-xenial InRelease\n  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nErr:12 http://packages.cloud.google.com/apt gcsfuse-buster InRelease\n  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nErr:13 http://packages.cloud.google.com/apt google-compute-engine-buster-stable InRelease\n  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nReading package lists...\n", stderr: "E: Repository 'http://security.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'stable' to 'oldstable'\nE: Repository 'http://deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'stable' to 'oldstable'\nE: Repository 'http://deb.debian.org/debian buster-updates InRelease' changed its 'Suite' value from 'stable-updates' to 'oldstable-updates'\nW: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://packages.cloud.google.com/apt cloud-sdk-buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nW: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://packages.cloud.google.com/apt google-cloud-packages-archive-keyring-buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nW: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://packages.cloud.google.com/apt kubernetes-xenial InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nW: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://packages.cloud.google.com/apt gcsfuse-buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\nW: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://packages.cloud.google.com/apt google-compute-engine-buster-stable InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY B53DC80D13EDEF05\n"

What you will notice is the repition of: NO_PUBKEY B53DC80D13EDEF05
I followed this article and sshed into the gcp instance and added a public key.
I see it attempted the apt update again now and I am happy to report a shorter error :))

 Shorter Error
 packages.GetPackageUpdates() error: error getting apt updates: error running /usr/bin/apt-get with args ["update"]: exit status 100, stdout: "Get:1 http://security.debian.org/debian-security buster/updates InRelease [34.8 kB]\nGet:2 https://nvidia.github.io/libnvidia-container/stable/debian10/amd64  InRelease [1484 B]\nGet:3 https://download.docker.com/linux/debian buster InRelease [54.0 kB]\nHit:4 https://nvidia.github.io/nvidia-container-runtime/stable/debian10/amd64  InRelease\nHit:5 https://nvidia.github.io/nvidia-docker/debian10/amd64  InRelease\nGet:7 http://packages.cloud.google.com/apt cloud-sdk-buster InRelease [6396 B]\nGet:8 http://deb.debian.org/debian buster InRelease [122 kB]\nGet:9 http://deb.debian.org/debian buster-updates InRelease [56.6 kB]\nHit:10 http://deb.debian.org/debian buster-backports InRelease\nGet:11 http://packages.cloud.google.com/apt google-cloud-packages-archive-keyring-buster InRelease [5163 B]\nGet:6 https://packages.cloud.google.com/apt kubernetes-xenial InRelease [8993 B]\nGet:12 http://packages.cloud.google.com/apt gcsfuse-buster InRelease [5004 B]\nGet:13 http://packages.cloud.google.com/apt google-compute-engine-buster-stable InRelease [5136 B]\nGet:14 http://packages.cloud.google.com/apt cloud-sdk-buster/main amd64 Packages [396 kB]\nGet:15 http://packages.cloud.google.com/apt google-cloud-packages-archive-keyring-buster/main amd64 Packages [389 B]\nGet:16 https://packages.cloud.google.com/apt kubernetes-xenial/main amd64 Packages [63.2 kB]\nGet:17 http://packages.cloud.google.com/apt gcsfuse-buster/main amd64 Packages [1871 B]\nGet:18 http://packages.cloud.google.com/apt google-compute-engine-buster-stable/main amd64 Packages [2235 B]\nReading package lists...\n", stderr: "E: Repository 'http://security.debian.org/debian-security buster/updates InRelease' changed its 'Suite' value from 'stable' to 'oldstable'\nE: Repository 'http://deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'stable' to 'oldstable'\nE: Repository 'http://deb.debian.org/debian buster-updates InRelease' changed its 'Suite' value from 'stable-updates' to 'oldstable-updates'\n"

Will provide further updates upon knocking down this error - something about "http://deb.debian.org/debian buster InRelease' changed its 'Suite' value from 'stable' to 'oldstable'"

So with regards to my previous posts shorter error I followed (this article)[https://stackoverflow.com/questions/68802802/repository-http-security-debian-org-debian-security-buster-updates-inrelease] and their recommendation is to change sudo apt-get update to sudo apt-get --allow-releaseinfo-change update resolves the issue.
As such I ran that command on the instance and it has not thrown an error like it does every 10 minutes.
Unfortunately (translate.masakhane.io)[http://translate.masakane.io/] is still down - I am thinking of rebooting the instance but that might not work as I will probably need to update the sudo apt-get update within the Dockerfile.prod
I am not that well versed running servers  on cloud instances so I am going to do some research on that regard.
Will continue to update this thread :))


OdhApplication, OdhDocument are k8 CRDs

[x] updated frontend/src, backend/src to fetch/watch OdhApplication, OdhDocument k8 resources
[x] moved data/{applications,documents} to install/deploy/base/{odh-application.yaml,odh-document.yaml}
[x] added CRDs for OdhApplication, OdhDocument to install/deploy/base
[x] updated Makefile targets deploy, build, build-local, undeploy, defaults

@jeff-phillips-18
Hi Jeff - this is the PR from red-hat-data-services/odh-dashboard.
Could I ask you to approve the workflow? Please review when you get a chance.
Thanks.

@kkasravi Thanks! I will take a look shortly. Will the resources (apps and docs) will be added upon deployment or is there some action necessary to add them?
@cfchase Can you also take a look?

yes 'make deploy' will deploy the apps and docs to the cluster.
I need to open a sibling PR in odh-manifests so that odh-manifests/odh-dashboard can be deployed in the same way (but with the auth overlay).

This is a really good direction to head in so we can dynamically add applications, etc.  In fact I believe it's necessary for some other requirements. In my opinion, though, all the CRD and deployment work needs to go into the applicable operator repos and should not be in the odh-dashboard.  For that reason, I think we need to get @vpavlin, @nakfour, and @crobby involved to plan the CRDs and their deployment.  This work would be split up and separate the responsibilities.

This is a really good direction to head in so we can dynamically add applications, etc. In fact I believe it's necessary for some other requirements. In my opinion, though, all the CRD and deployment work needs to go into the applicable operator repos and should not be in the odh-dashboard. For that reason, I think we need to get @vpavlin, @nakfour, and @crobby involved to plan the CRDs and their deployment. This work would be split up and separate the responsibilities.

I agree. I'm in the middle of creating an aikit-operator that adds an ImageStream (for JupyterHub) and several OdhDocuments when its run.
I had a few questions related to OdhApplications that are 'Enabled' versus those that appear under Explore

Do all apps in 'Explore' move to 'Enabled' once their action is executed? eg if an Explore App has you run an operator that adds a new container to the jupyterhub spawner dropdown menu and adds new document types does it need to be shown as an enabled app afterwards?

Do all apps in 'Explore' move to 'Enabled' once their action is executed? eg if an Explore App has you run an operator that adds a new container to the jupyterhub spawner dropdown menu and adds new document types does it need to be shown as an enabled app afterwards?

Once the app is discovered to be enabled, it will appear in the Enabled tab. There are various ways of enabling (based on the enabled settings in the yaml file for the app.

I like the direction as well.
It feels like the CRDs and actual manifests would fit into odh-manifests the best, but that would need some tweaking in the Makefile to simplify development.
I cannot really comment on the TypeScript code, but the yamls look reasonable at a first glance.

@vpavlin

I like the direction as well.
It feels like the CRDs and actual manifests would fit into odh-manifests the best, but that would need some tweaking in the Makefile to simplify development.
I cannot really comment on the TypeScript code, but the yamls look reasonable at a first glance.

thanks for the review. I've modified odh-manifests already along these lines. I'll open the PR in odh-manifests within the red-hat-data-services org.
@vpavlin @jeff-phillips-18
One aspect of this PR is I've only done OdhApplication, OdhDocument. The directory ./data/{getting-started,quickstarts} should also be converted to and watched as k8 kinds rather than being read from disk. I think these can be done as follow PRs.
Note: the backend doesn't act like a typical k8 operator/controller despite watching for OdhApplication, OdhDocument resources. As an operator/controller, it should update OdhApplication, OdhDocument status, add itself as the owner and add a finalizer. I think this is doable in typescript using @kubernetes/client-node though i've typically done it in golang. This can also be done as a follow up PR.
I need to rebase as well and address @jeff-phillips-18 comments.
thanks again
Kam

Do all apps in 'Explore' move to 'Enabled' once their action is executed? eg if an Explore App has you run an operator that adds a new container to the jupyterhub spawner dropdown menu and adds new document types does it need to be shown as an enabled app afterwards?

Once the app is discovered to be enabled, it will appear in the Enabled tab. There are various ways of enabling (based on the enabled settings in the yaml file for the app).

thanks @jeff-phillips-18 for this feedback. The 'enabled' settings would be these?

@vpavlin @jeff-phillips-18 could I ask one of you approve the PR workflow? thanks.

The 'enabled' settings would be these?

correct

@vpavlin @jeff-phillips-18 could I ask one of you approve the PR workflow? thanks.

done

@jeff-phillips-18 @vpavlin
I've updated this branch to sync with whats currently in data/{applications,docs}. EG:
data/applications/* -> install/deploy/base/odh-applications.yaml
data/docs/* -> install/deploy/base/odh-documents.yaml

Please have another look. I can continue converting the remaining files under "./data/ to be k8 kinds once this is merged.
thanks.

Closing in favor of https://github.com/opendatahub-io/odh-manifests/pull/482 and https://github.com/opendatahub-io/odh-dashboard/pull/97


Add remaining predefined color spaces to CSS color() function test

Following #5956 I'd be nice to have the remaining predefined color spaces srgb, a98-rgb, prophoto-rgb, rec2020, and xyz from the spec available to test at https://tests.caniuse.com/css-color-function in addition to the already present display-p3 :)
Should only be copypasta. I'd do it myself… 0:-)

Good idea, done!


Generic text field

Added all functionalities of the PageObject GenericTextField:
-PageObject GenericTextField
-GenericTextFieldTest
-IntegrationTest
-Assert
-AssertTest
-Matcher
-MatcherTest

This change is

Looks good to me :)
Can you please update the documentation (support-hamcrest.md and support-assertj.md)?

Nico, I merged your backport of GenericTextField. Thanks, and don't forget to pull the current master branch!


@azure/msal-node-extensions doesn't provide a VerifyPersistence() method

Library

[x]<EMAIL_ADDRESS>
Description
AzureAD/microsoft-authentication-extensions-for-dotnet provides a cacheHelper.VerifyPersistence helper on Linux and OSX which allows us to determine whether the Keychain or the KeyRing are available. Without this feature, the best I can do today is to load() the persistence plugin to verify if it works. An alignment across languages would be very helpful!
Source

[x] Internal (Microsoft)
[ ] Customer request

We are working on a PR to address this and will update this issue soon.

@samuelkubai will be working on this

Currently in our backlog and will mostly cover this in the next couple weeks.

@samuelkubai should we close this issue?

Yes, Closing it.


Installation Error: conda channel does not have noarch directory

I just tried to install plotly-orca using the recommended conda installation method conda install -c plotly plotly-orca and get the following error:
Solving environment: failed
CondaHTTPError: HTTP 403 AUPDOWNLOADPNS for url https://conda.anaconda.org/plotly/noarch/repodata.json
Elapsed: 00:00.253400
The remote server could not find the noarch directory for the
requested channel with url: https://conda.anaconda.org/plotly
As of conda 4.3, a valid channel must contain a noarch/repodata.json and
associated noarch/repodata.json.bz2 file, even if noarch/repodata.json is
empty. please request that the channel administrator create
noarch/repodata.json and associated noarch/repodata.json.bz2 files.
not sure if this is a problem with the conda plotly channel or if there is something weird with my conda configuration. I tend to think the first case is true since I can install fine from other conda channels.

Thank you @josephcarmack for your interest in plotly.js. I am having trouble reproducing your issue and could install plotly-orca using Conda 4.3:
$ docker run -i -t continuumio/anaconda:4.3.1 /bin/bash # to create a container with conda 4.3
$ conda --version
conda 4.3.14
$ conda install -c plotly plotly-orca
Fetching package metadata ...........
Solving package specifications: .

Package plan for installation in environment /opt/conda:

The following NEW packages will be INSTALLED:

    plotly-orca: 1.2.1-1       plotly

The following packages will be UPDATED:

    conda:       4.3.14-py27_0        --> 4.3.30-py27h6ae6dc7_0

Proceed ([y]/n)? y

plotly-orca-1. 100% |#############################################################################################################################| Time: 0:00:04  10.02 MB/s
conda-4.3.30-p 100% |#############################################################################################################################| Time: 0:00:00   4.24 MB/s

Maybe something is wrong with your conda configuration or your network?

@antoinerg Thanks for the feedback. I will dig in a littler deeper to the conda environment and connection to see if I can isolate the problem better and report back what I find.

On a previous computer I used the command pip install -U pyvisa, but it was single user.  I am attempting to use this same command with a multi-user install on Anaconda and this is the error I get.  I have been able to execute the mkdir command and the echo command, but am unable to execute the bzip2 command.  I have worked on this for 6 hours and am pretty frustrated.  I did attempt using the conda install -c anaconda bzip2 command, but then I get the error failed - Permission Error 13.  A also tried a sudo chown command that was offered on github with no success.
(base) C:\ProgramData\Anaconda3>conda install -c AltumRF-Dallas-Admin pyvisa
Solving environment: failed
CondaHTTPError: HTTP 404 NOT FOUND for url https://conda.anaconda.org/AltumRF-Dallas-Admin/noarch/repodata.json
Elapsed: 00:00.711005
CF-RAY: 4b0f20b1fbd5c7f8-DFW
The remote server could not find the noarch directory for the
requested channel with url: https://conda.anaconda.org/AltumRF-Dallas-Admin
As of conda 4.3, a valid channel must contain a noarch/repodata.json and
associated noarch/repodata.json.bz2 file, even if noarch/repodata.json is
empty. please request that the channel administrator create
noarch/repodata.json and associated noarch/repodata.json.bz2 files.
$ mkdir noarch
$ echo '{}' > noarch/repodata.json
$ bzip2 -k noarch/repodata.json
You will need to adjust your conda configuration to proceed.
Use conda config --show channels to view your configuration's current state.
Further configuration help can be found at https://conda.io/docs/config.html.


Release

Please, make a release.
It will allow to create a packages for distributives.

By release you mean code compiled into executable?

No, I mean tarball / git tag (https://github.com/solusipse/fiche/releases).

Done.


Document BZDB settings

This is an effort to document all of the support BZDB variables used by BZFS. Feedback, corrections, and improvements are welcome!
I'm leaving this PR as a draft until I can finish documenting all of the remaining variables and creating a respective page for it on the website.

Not being at all connected with the documentation methodology, this feels like an inevitably intractable maintenance burden. Just the two files in the most recent commits are 80% redundant with each other. Making the same change in 2 places is a losing proposition.
Seems to me that the only viable documentation solution is tied to the code. You can either write your documentation and generate code from that (a la protobuf), or you can write your code and generate documentation from it (Doxygen). Hand-maintaining separate and unwieldy documentation metadata is begging for the docs and the code to get out of sync.


Appstudio update test-custom-default-branch-omph

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-wadk-on-pull-request-
creating pipelinerun test-simple-build-wadk-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-mcmm-on-pull-request-
creating pipelinerun test-simple-build-mcmm-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-uqzm-on-pull-request-
creating pipelinerun test-simple-build-uqzm-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-lqle-on-pull-request-
creating pipelinerun test-simple-build-lqle-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nwtb-on-pull-request-
creating pipelinerun test-simple-build-nwtb-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nyrh-on-pull-request-
creating pipelinerun test-simple-build-nyrh-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-ufgi-on-pull-request-
creating pipelinerun test-simple-build-ufgi-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-imul-on-pull-request-
creating pipelinerun test-simple-build-imul-on-pull-request- in namespace build-e2e-snga-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


fix build error

Summary
[linguini@pastabox nuttx]$ make -j
CC:  tcpblaster_server.c
LN: platform/board to
/home/linguini/cuinspace/pico-nuttx/apps/platform/dummy tcpblaster_server.c: In function ‘tcpblaster_server’: tcpblaster_server.c:159:14: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Wimplicit-function-declaration]
159 |   acceptsd = accept4(listensd, (FAR struct sockaddr *)&myaddr,
&addrlen,
|              ^~~~~~~
|              accept
make[3]: *** [Makefile:92: tcpblaster_server.hobj] Error 1
make[2]: *** [Makefile:53:
/home/linguini/cuinspace/pico-nuttx/apps/examples/tcpblaster_context]
Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:180: context] Error 2
make: *** [tools/Unix.mk:457:
/home/linguini/cuinspace/pico-nuttx/apps/.context] Error 2
make: *** Waiting for unfinished jobs....
Impact
from https://github.com/apache/nuttx-apps/issues/2632
Testing
CI TEST

[Experimental Bot, please feedback here]
NuttX PR Requirements Review
Meets Requirements? Partially
Summary:
While the PR addresses a real issue (#2632), the summary section lacks crucial details:

Missing: Explanation of WHY the change is necessary. What's the underlying cause for the implicit declaration error?
Missing: Description of HOW the change fixes the issue. Does it add a header file? Implement a missing function?
Present:  References the related NuttX Apps issue.

Impact:

Insufficient: The impact section is overly brief.

Does this fix introduce a new feature or modify an existing one?
Are there any user-facing changes?
Will this impact specific architectures, boards, or drivers?
Does this require documentation updates?

Testing:

Insufficient: "CI TEST" is not descriptive enough.

Specify the build host OS, CPU, compiler, and versions used.
Detail the target architecture, board, and configuration.
Provide actual testing logs before and after the change.  This is essential to demonstrate the issue and the fix.

Recommendation:
Expand the Summary and Impact sections with the missing information.  Provide detailed testing logs to showcase the change's effectiveness.


Issue 40082: Assay transform script errors

Re-implement transform script html errors.  Adds errors written to errors.html into the Run Properties section of assay import.

@labkey-jeckels Ok, I updated to use api.util.DOM.


Document Kops default resource requests

Kops gives all pods default resource requests of 100m CPU. This can be problematic when user spin up small-ish clusters since every worker and sidecar use the default resource requests if unset in the pipeline spec.
This default exists for reasonable reasons, but we should document it in the Kops docs. We should also document (either in AWS or troubleshooting docs) how they can turn of those defaults:
kubectl delete --namespace=default limits/limits
Or change them:
kubectl edit --namespace=default limits/limits
(need to double check above commands)

@msteffen I think this is outdated and not a problem anymore because kubernetes changed the defaults? We also document that users should use larger nodes. closing.


Automated cherry pick of #3958: add lock on host detected offline

Cherry pick of #3958 on release/2.10.0.
#3958: add lock on host detected offline

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@2507f89). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #3962   +/-   ##
================================================
  Coverage                  ?   7.49%
================================================
  Files                     ?     418
  Lines                     ?   66656
  Branches                  ?       0
================================================
  Hits                      ?    4997
  Misses                    ?   61232
  Partials                  ?     427

Flag
Coverage Δ

#aFlag
7.49% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.39% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2507f89...3f28bec. Read the comment docs.

/lgtm

/lgtm

/approve


help needed

hello,i try to update this mod https://mods.factorio.com/mod/Flow_Control_Fix
could i use your sources code and mentionned you?
if yes, any idea how to do that ?

Hello! It might be easier to simply depend on this mod, and use the valve I provide. 2.0 valves are a little tricky to implement and debug issues, and work different than 1.1 valves.
I'm gonna try do the same for the Flow Control mod.
If you want to handle migrating valves from 1.1 you can see how I did it for Pyanodons in the migrations/ folder.

thanks you for your information, it's out of my skill atm :/


refactor!: remove GetState() on connection interface

Description
A step towards removing the connection interface. As a nice side affect it removes a lot of unnecessary casting
closes: #XXXX
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7df8644) 81.50% compared to head (f84b7f3) 81.53%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5769      +/-   ##
==========================================
+ Coverage   81.50%   81.53%   +0.03%
==========================================
  Files         199      199
  Lines       15225    15191      -34
==========================================
- Hits        12409    12386      -23
+ Misses       2349     2338      -11
  Partials      467      467

Files
Coverage Δ

modules/core/03-connection/types/connection.go
79.10% <ø> (+2.29%)
:arrow_up:

modules/core/04-channel/keeper/packet.go
99.09% <100.00%> (-0.02%)
:arrow_down:

modules/core/04-channel/keeper/handshake.go
90.20% <80.00%> (+0.49%)
:arrow_up:

modules/core/04-channel/keeper/upgrade.go
92.46% <70.00%> (+0.75%)
:arrow_up: