[Feature] Serializable guard (string conditions)

Description:
Hi,
I've been thinking about serializable guard  (i'm loading my statechart from server).
Does Function object (mdn link) could work for that ?
usage of Function :
const add = new Function ("a", "b", "return a + b")

add(2, 3)
// --> 5

Potential implementation:
The implementation could look like :
// ...
const condFn = !cond
  ? () => true // we can go forward if we don't have guard
  : typeof cond === 'string'
    ? new Function('extendedState', 'eventObject', cond) // create the function if cond is a string
    : cond; // use directly otherwise

if (condFn(extendedState, eventObject)) {
// ...

usage of cond :
const searchMachine = Machine({
  initial: 'idle',
  states: {
    idle: {
      on: {
        SEARCH: {
          searching: {
            // only transition to 'searching' if cond is true
            cond: "return extendedState.canSearch && eventObject.query && eventObject.query.length > 0"
          }
        }
      }
    },
    searching: {
      onEntry: ['executeSearch']
      // ...
    },
    searchError: {
      // ...
    }
  }
});

Advantage

simple to implement
doesn't have to create something custom
good browser support
keep function working

Drawback

implicit call of return inside the string.
can't change the extendedState & eventObject variable name.
can't guaranty user doesn't call an global object (example : return window.foo > 3).

I like this and have been thinking of how to serialize guards so that e.g. conditionals can be stored in a database, or interpreted by other languages.
We can probably omit return as a sugar (so it reads just like a traditional statechart/UML diagram); ideally, conditional statements should be simple expressions (as they tend to be in normal application code).
I'll wait to hear what others think about this. 👍

Guards are tricky.  The way I understand them, they're supposed to be able to ask things about the world that the statechart might not be privy to.  I also don't like that I have to pre-compute the data that might be needed by a guard when I call transition.
When I first learned about xstate I had an idea that a guard check could be handled by exposing the "guard check" as the response of transition — i.e. that transition was essentially asking for a guard check, and it would pass the string of the guard check back to the caller, saying, essentially: "please give me the boolean value of this guard".
states: {
  A: {
    on: {
      event: {
        B: { cond: "foo" }
      }
    }
  },
  B: {}
}

Calling transition("A", "event") would yield an object representing the original state, which "was about to transition" to state B, except it asks: "what is foo"?  I would then have to pass in the value of "foo" somehow:  Perhaps transition("A", "event", undefined, {foo: true})
Anyhow, for cond: "extendedState.canSearch && eventObject.query && eventObject.query.length > 0" it would be up to the caller to determine if it is true or false, implement boolean logic or punt and just eval it.
But my own feeling about this idea is that it's over-engineering the solution; it becomes mighty chatty if every guard requires a new call to transition.  A simple string of a function body works for me.
You could consider defining a formal language, and not allow arbitrary JavaScript, but simple boolean logic.

You could consider defining a formal language, and not allow arbitrary JavaScript, but simple boolean logic.

This is what I want to aim for. To my understanding, a "guard" is just an abstract concept that splits actions into mutually exclusive subsets. That is, let's say you had an data.x > 100 guard for CLICK.
This is equivalent to having two actions, fired when the conditions are met:

CLICK_WHEN_X_IS_LTE_100: 'somewhere'
CLICK_WHEN_X_IS_GT_100: 'somewhereElse'

Of course, nobody would write the above (hopefully). The point is to illustrate that this "subset" separation of actions is purely boolean, so some sort of common boolean logic expression would be ideal. (And we can statically analyze it!)
I also like having a string like @mogsie is suggesting, e.g., 'condition_is_met': 'foo' and then you'd map 'condition_is_met' to some predicate function (implementation detail). With that, you could also say that the string 'data.x > 100' also maps to some predicate function as well 😝
Are there established standards for writing boolean expressions? I wonder what SCXML uses.

Mapping 'data.x > 100' to a function is just horrible.  I know it was a joke, but I have an anecdote:  I tried writing a Statechart debugger and quickly ended up right here:  I made a checkbox for each unique guard expression.  I ended up with the following guards:

foo
!foo
foo && bar
!foo || (bar && !baz)
etc...

It was impossible to use, I'd have to do lots of boolean logic in my head to evaluate each one to know how the guards were when trying to debug an issue in my statechart.
I quickly ditched that idea and parsed the guard using some rules and ended up with the three checkboxes I needed: foo, bar and baz and had the debugger evaluate the guards.
It's simple for booleans; question is if it should support ranges, e.g. x > y.
AFAIK, scxml leaves it as an implementation detail, up to the implementation.  This of course is an interoperability problem, since you end up with JS SCXML files vs Java SCXML files vs C# SCXML files and so on.

This goes hand-in-hand with the transition array proposal in #43, since each subsequent condition implicitly represents the union of the previous condition's complement and the current condition.
Okay, so how should we do this as an MVP? Should we just support string conditions in general and leave the interpretation up to the interpreter?

When you say leave the interpretation to the interpreter, that mean we provide an interface to execute guard condition when we create the instance of the machine ?
I think of something like that :
interface GuardInterpreter {
  isValid(guard: string, state: State, extendedState?: any): boolean;
  check(guard: string, state: State, extendedState?: any): boolean;
}

and constructor
// constructor machine
 constructor(
    public config:
      | SimpleOrCompoundStateNodeConfig
      | StandardMachineConfig
      | ParallelMachineConfig,
     public guardInterpreters: List<GuardInterpreter>
  ) // ....

On the execution, we check which one is valid, stop on the first valid and and launch the guard.
Is this what you think of ? I like the flexibility about interpretation of the conditions
What happen to the function based guard ? Should it be deprecated, still supported or just remove ?
When the change is ok about guard string conditions, I would like to help if this is ok for you.

Something also to consider - I'd like to serialize the "in someState(s)" conditional since, especially for parallel machines, it looks like it's going to be a common use-case (I've already ran into this use-case multiple times, and when generating tests, it's a pain to stuff this condition in a function instead of having it be declarative).
Example:

The statechart could look like this:
Machine({
  key: 'Y',
  parallel: true,
  states: {
    A: {
      initial: 'B',
      states: {
        B: { on: { alpha: 'C' } },
        C: {
          on: {
            beta: {
              // 'in' is always relative to parent
              B: { in: 'D.G' }
            }
          }
        }
      }
    },
    D: {
      initial: 'F',
      states: {
        F: { on: { alpha: 'G', mu: 'E' } },
        G: { on: { delta: 'F' } },
        E: { on: { gamma: 'G' } }
      }
    }
  }
});

The 🆕 notation here would be B: { in: 'D.G' }. Since in can only apply to a parallel machine, it makes sense that it is relative to B's parent state, so the rules in #52 would still apply.
Here's the parallel (no pun intended) to SCXML:

The SCXML processor must define an ECMAScript function named 'In()' that takes a stateID as its argument and returns 'true' if and only if that state is in the current state configuration, as described in 5.9.1 Conditional Expressions. Here is an example of its use, taken from G.3 Microwave Example (Using parallel)

        <state id="idle">
          <transition cond="In('closed')" target="cooking"/>
        </state>

        <state id="cooking">
          <transition cond="In('open')" target="idle"/>

          <!-- a 'time' event is seen once a second -->
          <transition event="time">
            <assign location="timer" expr="timer + 1"/>
          </transition>
        </state>

In the above example, closed and open are states in a different orthogonal state (i.e., not the same one as idle and cooking).
Some more thoughts:

{ B: { in: 'D.G', cond: 'someCond' } } would be equivalent to someCond && in('D.G')
This also opens the possibility for defining multiple orthogonal states as a condition, e.g.:

{ B: { in: { D: 'G', FOO: { BAR: 'BAZ' } } } which would be satisfied if we're in the D.G and the FOO.BAR.BAZ states

Alternatively (or additionally), we could pass stateValue as the 3rd parameter for the guard:
{
  B: { cond: (data, event, stateValue) => matches('D.G', stateValue) }
}

Thoughts?

More info: this is how Amazon serializes their conditionals: https://states-language.net/spec.html#choice-state
(not sure we want to get that verbose, though)

Yes ! I like the in. That could be confusing to partially handle the guard with the in and let the rest for the interpreter. We need to do that as a  InStateInterpreter that xstate could provide.
So the guard could be a string or an object.  This is even more flexible if someone doesn't want to serialize with string but object, like amazon did (thank for the link, it's really interesting).
That mean :

if the machine is initialized without interpreter(s), we use a default [InStateInterpreter].
if the machine is initialized with interpreter(s), we need to choose if :

InStateInterpreter is always provided as an interpreter : [InStateInterpreter, ...customInterpreters] (I find that great to not have to think about)
or export InStateInterpreter and developer have to provide their custom interpreters with the InStateInterpreter if they want it.

The state as a third argument is great for me.
If i understand correctly :

data represent extendedState today so type is any
event is EventObject
state is StateValue

The interface of Interpreter with that change :
interface GuardInterpreter {
  isValid(guard: string | object, data: any, event:  EventObject, state: StateValue): boolean;
  check(guard: string | object, data: any, event:  EventObject, state: StateValue): boolean;
}

As for a default interpreter, that's being discussed in #50, however, the core xstate library will remain a pure transition function in order to ensure flexibility and not be opinionated (and also to keep the library size small). With that said, doing something like import { Interpreter } from 'xstate/interpreter' should be straightforward in the future.
In the GuardInterpreter interface, what would isValid report? That the conditional expression is valid?
Also, I found this: http://jsonlogic.com seems to be fairly popular, and representation of boolean/relational expressions as a binary tree, albeit not natural, seems robust enough.

Oh well I missed that one !
My thinking was only about "guard interpreter" in a way that we can provide a list of "guard interpreter".
Then isValid could be use to filter on the correct guard to execute.
As an exemple, if we have a InStateGuardInterpreter as describe before and a JsonLogicGuardInterpreter.
We provide a list of these guard interpreters [InStateGuardInterpreter, JsonLogicGuardInterpreter].
Then, when a transition occur,  we check which "guard interpreter" should be use to execute the guard.
// for inState check
isValid(guard: string | object, data: any, event:  EventObject, state: StateValue): boolean {
  return typeof guard === "object"
}
// for jsonLogic check
isValid(guard: string | object, data: any, event:  EventObject, state: StateValue): boolean {
  return typeof guard === "string"
}

(this example is just provide as an exemple, the isValid is not tested)
That way, we can use more than one way to execute guard.
Perhaps i'm going too deep about what is really needed for this library. The advantage is that we can do anything we want. We can mix custom "guard interpreter" with the InStateGuardInterpreter provided by xstate and more. An implementation with JsonLogic link is really easy.
What i'm not sure about right now after reading ticket #50 :  the list of guard should be provided to the interpreter discussed in #50 or to the machine.
example :
import { Machine, Interpreter } from 'xstate';

const myMachine = Machine({ ... });
const interpreter = Interpreter(myMachine);

// choice one
interpreter.guardInterpreter([InStateGuardInterpreter, JsonLogicGuardInterpreter])
// choice two
Machine({ ... }, [InStateGuardInterpreter, JsonLogicGuardInterpreter])

Hi, been following this thread and found this:
https://www.npmjs.com/package/serialize-javascript
It is a general purpose serialization library and not a statecharts/state machine DSL. And of course everything ends being just eval'd 🤷♂. Probably something more  constrained as http://jsonlogic.com is a better fit.
Also, thank you both for evangelizing FSMs and statecharts. We need more of this.

Just to add another data point to this discussion.
We've recently started using state machines in our app, and have built our own state machine runner using Redux Sagas. We wanted to add support for nested and parallel states, and rather than do the work myself, I thought it would be nice to switch out the core of our runner for xState and have our code just be a thin interpreter around it.
Unfortunately I don't think that is going to be possible, as our cond functions are Redux Sagas, and as such are able to use selectors to pull in the external state they want. But in xState cond functions are run by the Machine, so won't be run as Sagas, and so won't be able to pull in state using selectors.
It would be great if we could define cond functions the same way we do for actions, and just pass in string name/reference to the function.
xState could then pass the function reference to us, we could call it as part of the Saga, and then let xState know the result. This would have the added benefit of keeping the state description serialisable and keeping parity with the way actions works.

@karl That's going to come in 3.2 - next on my list 📃
What I'm thinking is that a statechart defined with string conditions will have to be "set up" with those functions, otherwise it'll throw an error (of course, otherwise the state will be nondeterministic).
How's this for an API?
const machine = Machine({ ... }, {
  guards: {
	isFoo: (fullState, event) => fullState.foo === 'bar',
    isBar: myBarConditional
  }
});

Then the machine can be defined with cond: 'isFoo', etc.
But if it encounters a string condition 'isFoo' and there isn't a guard function set up for it, it'll throw an error.

With that API I’m still not clear on how I would run the functions as part of my Saga (so they would be able to use selectors to access state).
I haven’t thought it all through but I would have expected to be returned an array of function ids and then I would run those and return the results to the Machine wherein it would return me the new state.

Yeah in my head I'd imagined something a bit like that.
Although I wasn't sure if you'd need to have two steps. One to get all the conditions, and a second one to do the actual transition. I wonder if the second step would be needed so that xState can return you all the actions that you would need to call (e.g. actions for the transition, onEntry, onExit, etc).
const conditions = machine.getConditions(state, event);
const results = conditions.map(cond => cond()); // execute the cond functions however you want.
const newState = machine.transition(state, event, {}, results);

One thing I would say is to take any API suggests from me with a big grain of salt. I've only been using state machines for a couple of weeks so don't have much experience with them!

With that API I’m still not clear on how I would run the functions as part of my Saga (so they would be able to use selectors to access state).

@karl Do you have a demonstration of how this would look normally? I still don't see why this wouldn't work:
const machine = Machine({ ... }, {
  guards: {
	isFoo: (fullState, event) => fullState.foo === 'bar',
    isBar: myBarConditional
  }
});

And then you can do this in redux-saga:
const fullState = yield select();
const currentState = fullState.app; // or wherever you're keeping the finite state

// This will properly evaluate the state with your custom guards
const nextState = machine(currentState, event, fullState);

Your guards should always be pure functions, so putting a yield select(...) in them doesn't make sense.

My brain has slowly come to the same conclusion!
I think we should be able to get the full state in the interpreter saga and pass it to the transition function. Then within a guard we could just call the selectors we want on that state.
const machine = Machine({ ... }, {
  guards: {
    isFoo: (fullState, event) => selectFoo(fullState) === 'bar',
    isBar: myBarConditional
  }
});

const runner = function*() {
  const fullState = yield select();
  const currentState = yield select(selectAppState);

  // This will properly evaluate the state with your custom guards
  const nextState = machine(currentState, event, fullState);
}

I was initially reluctant to do this as it means you can't use the usual yield select(xxx) that you we be using in actions, onEntry, and onExit, etc. Instead you would need to know that cond functions are treated differently.
But perhaps that is a blessing in disguise as letting cond functions run as full sagas would let them run asynchronously which could cause all kinds of pain 😱

@davidkpiano Thank you for taking the time to coach me through this!
I'm finding that state machines are great for tackling some of the inherent complexity in our code, but it's a learning curve to work out the best way of using them!

Yep, state machines (and especially statecharts) are huge learning curves with a lot of history behind them, but it's worth it!
I'm moving this to 3.3, there's still a lot to think about.

I just wanted to put in a few words that I think providing guards when "setting up" the machine would be a good idea.  Independently of this thread (unless my brain's subconscious self has managed to connect to the Internet) I wrote down the following:
// simple state machine x, y, with event e for transition (x→y) guarded by the condition 'empty'
const definition = {
  initial: 'x',
  states: {
    x: {
      on: {
        e: {
          y: {
           cond: 'empty'
          }
        }
      }
    },
    y: {}
  }
};
// empty is provided when constructing the machine,
// so the resulting machine ends up referencing the right guards at the right places.
const machine = Machine(definition, {guards: {empty: s => s.length == 0}})

machine.initialState would be 'x', and machine.transition('x', 'e', '') would call the guard function.
My only addition would be to support boolean logic in the guard definitions themselves: so e.g. cond: "!empty" would be allowed and even cond: "!foo && bar && (baz || joe)"


chore: minor updates to cdk-node-config

Description
This PR addresses configs in the cdk-node-config.toml file. Tested deployment to Sepolia.

Looks like there is something wrong in our configs... The workflow failed to virtualize and verify batches on fork 9 and 11 but succeeded on fork 12... However the change in this PR only targets fork 12... I'm wondering if the templates are correctly generated...


let(:params) fails with unhelpful error when params includes a symbol indexed hash

require 'spec_helper'
describe 'symbol_issue' do
  context 'symbol_indexed_hash' do
    let(:title) {'symbol_indexed_hash'}
    let(:params) {{:hash => { :one => '1' }}}
    it { should compile}
  end
end

Will fail with:
Failures:

  1) symbol_issue symbol_indexed_hash should compile into a catalogue without dependency cycles
     Failure/Error: it { should compile}
       error during compilation: Could not parse for environment rp_env: Syntax error at ':' at line 1:48 on node rrenshaw
     # ./spec/defines/symbol_issue_spec.rb:6:in `block (3 levels) in <top (required)>'

Finished in 0.02312 seconds (files took 0.73286 seconds to load)
1 example, 1 failure

I know that params hashes should be indexed with strings, not symbols, but this error is very misleading about the actual issue with the test code.

:+1:
Confusing for an rspec newbie

There doesn't seem to be a reason why rspec-puppet shouldn't accept symbols as keys and render them out correctly (as strings) to the manifest.

693c04a (in master) fixed this.

Closing as the commit @domcleal mentioned addresses this issue.


Updated and fixed JSDocs

Recreation of #2475
There were a lot of problems with the JSDocs; missing parameters, parameters that didn't exist, references to types that didn't exist, that sort of thing. I fixed most or all of them. Some parameters may need better explanations, but I did the best I could on that end.

Hold off on merging this, I just discovered a bunch more problems.

Ok, I'd appreciate it if someone else could look this over. I corrected everywhere I could, but I feel like there's a chance I might have gotten a few of the params wrong, particularly when it comes core stuff.

Also, I feel like all the math shapes should inherit from some common object, just for param simplicity if nothing else.

I notice in some of the changes that you changed the JSDocs from
PIXI. to
core.
For example:

@param renderTexture {PIXI.RenderTexture}

@param displayObject {core.DisplayObject} the object to be rendered

I think the PIXI variant is better; it's consistent with the rest of pixi, and it works in WebStorm! It also makes more sense in the generated JSDocs.
Speaking of which, creating the docs no longer works with a number of "unable to parse a tag's type expression" errors.

@themoonrat, I actually changed those because WebStorm was complaining.

hmmm, yeah, there are some places I can see that whatever way you choose, WebStorm will complain.
But it must be PIXI.DisplayObject or it harms the JSDoc html output

hello! I agree with @themoonrat, priority should be a correct JSDoc html output. great pr!


1.10 branch ?

Hi @artml.
Since 1.10 is already tagged in beta, do you think you could push a 1.10 branch ?
Have a good day,
Samuel

@sadortun not sure I understood this, or am capable of doing so. I am not a developer, sorry :) can you please explain?

@sadortun The pre-release identifier part (beta.X) in the 1.10.0-beta.X tags correlates with the _OroCommerce _ release cycle just for the referencing purpose. OroPlatform doesn't have pre-release versions for minor releases in 1.x (rare exceptions possible).
OroPlatform 1.10 will be pushed when the OroPlatform team is ready to release it.

Perfect! Thanks!


golangci-lint: enable and fix thelper linter

Which problem is this PR solving?

Thelper detects tests helpers which is not start with t.Helper() method.

Description of the changes

Add Thelper linter to golangci-lint and fix issues

How was this change tested?

CI

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[ ] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

I am not sure I understand why this is better. When I see an error message in the logs, it's always most useful to know the exact line number that logged it, not a line number several scopes above it. t.Helper() seems to do exactly the former. Not to mention that I see the tests usually log the full stack on errors, so that both the helper line and the main test line are shown (perhaps it's because we use testify).


Fixed cs_CZ translation

Word “feature” should be translated as “funkce”, not as “fičurka”.

LGTM @MekliCZ


Ear, Nose, Neck detection

Hi All,
New here with Jeeliz, I have gone through the demos and I was wondering if I could quickly ask for possible application we can build with it.
Can we detect ear, nose and nect with jeeliz or not ?
if I can then I can make jwellery AR  filter application or lipstick AR filter application.
I have seen demos, I understood face tracking and detection is possible. Dog face demo detecting face but not ears it's just y position it's managing.
Could you please let me know if individual face part tracking is possible or not?

duplicate of #1


Provide quick fix for resolving a bad comment reference with a doc-import

Essentially, provide a quick fix for comment_references which offers the same import choices as are currently offered with other "add/update import" quick fixes, but adds @docImport comment directives.

CC @goderbauer

Yes, please!

Just ran across this again. Any chance this can get bumped?

Sorry, I think other things are still higher priority. Hopefully soon.


Older age

Hi, is there a way that when filling this date DD/M/YYYY
the part of the year only give years of older age people? i mean dates since 18 years old.
For example: Years until 2009
15/07/2009
Thanks for the help

There is no way to do that at the moment but I will be happy to accept a pull request for this :)


”Moara Grecilor”, ”Rediu”, ”Viișoara” are listed in the drop-down menu

Description:
When user writes ”Moara Grecilor”, ”Rediu”, ”Viișoara” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Moara Grecilor"

Expected results
The location appears in the drop-down menu as "Sat Moara Grecilor, VASLUI (VASLUI)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Rediu"

Expected results
The location appears in the drop-down menu as "Sat Rediu, VASLUI (VASLUI)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Viișoara"

Expected results
The location appears in the drop-down menu as "Sat Viișoara, VASLUI (VASLUI)".


NavigationView TopNav: fix insertion bug and upgrade top nav performance/fix flyout positioning

Description

This PR corrects the update of index in original vector while inserting an element in custom data source and upgrades performance of topnav overflow flyout rendering.
Motivation and Context

First, I've fixed the procedure of insertion of the element at already existing index in raw data source. Before, it was not incrementing the index at which the new element was inserted. It resulted in two elements referencing the same data in the original vector and it messed up the animations and correct ordering.
Second, I've removed width cache invalidation for custom data source when content of NavItem changes. That cache invalidation call was leading to our own "layout cycle" that resulted in poor performance and sometimes incorrect positioning of the overflow items flyout when overflow button was clicked. The reason why it could be removed without affecting behavior of TopNav when content of any of ithe items changes (so it can potentially properly resize and may move some items from OverflowItems due to some of them shrinking in size) is because when Custom data source changes, all the items will be moved to PrimaryList and recalculation of the cache will happen anyway. We still need cache invalidation in case of non custom data source being used because changing content of NavItem in this case won't lead to cache invalidation - it will simply try to rearrange items with existing width values stored in the cache.
How Has This Been Tested?

Manually.

/azp run

/azp run


Couldn't find trained model at .........

andy1028@andy1028-Envy:~/github/chatbot-retrieval$ python udc_train.py
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcublas.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcudnn.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcufft.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcurand.so locally
WARNING:tensorflow:Setting feature info to {'utterance_len': TensorSignature(dtype=tf.int64, shape=TensorShape([Dimension(128), Dimension(1)]), is_sparse=False), 'context_len': TensorSignature(dtype=tf.int64, shape=TensorShape([Dimension(128), Dimension(1)]), is_sparse=False), 'utterance': TensorSignature(dtype=tf.int64, shape=TensorShape([Dimension(128), Dimension(160)]), is_sparse=False), 'context': TensorSignature(dtype=tf.int64, shape=TensorShape([Dimension(128), Dimension(160)]), is_sparse=False)}
WARNING:tensorflow:Setting targets info to TensorSignature(dtype=tf.int64, shape=TensorShape([Dimension(128), Dimension(1)]), is_sparse=False)
INFO:tensorflow:No glove/vocab path specificed, starting with random embeddings.
INFO:tensorflow:Create CheckpointSaver
I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:925] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
I tensorflow/core/common_runtime/gpu/gpu_init.cc:102] Found device 0 with properties:
name: GeForce GTX 950M
major: 5 minor: 0 memoryClockRate (GHz) 1.124
pciBusID 0000:01:00.0
Total memory: 4.00GiB
Free memory: 3.08GiB
I tensorflow/core/common_runtime/gpu/gpu_init.cc:126] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_init.cc:136] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:839] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 950M, pci bus id: 0000:01:00.0)
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:244] PoolAllocator: After 5742 get requests, put_count=3297 evicted_count=1000 eviction_rate=0.303306 and unsatisfied allocation rate=0.617381
I tensorflow/core/common_runtime/gpu/pool_allocator.cc:256] Raising pool_size_limit_ from 100 to 110
INFO:tensorflow:Error reported to Coordinator: <class 'tensorflow.contrib.learn.python.learn.estimators._sklearn.NotFittedError'>, Couldn't find trained model at /home/andy1028/github/chatbot-retrieval/runs/1476255016.
E tensorflow/core/client/tensor_c_api.cc:485] Enqueue operation was cancelled
[[Node: read_batch_features_train/random_shuffle_queue_EnqueueMany = QueueEnqueueMany[Tcomponents=[DT_STRING, DT_STRING], _class=["loc:@read_batch_features_train/random_shuffle_queue"], timeout_ms=-1, _device="/job:localhost/replica:0/task:0/cpu:0"](read_batch_features_train/random_shuffle_queue, read_batch_features_train/read/ReaderReadUpTo, read_batch_features_train/read/ReaderReadUpTo:1)]]
E tensorflow/core/client/tensor_c_api.cc:485] Enqueue operation was cancelled
[[Node: read_batch_features_train/file_name_queue/file_name_queue_EnqueueMany = QueueEnqueueMany[Tcomponents=[DT_STRING], _class=["loc:@read_batch_features_train/file_name_queue"], timeout_ms=-1, _device="/job:localhost/replica:0/task:0/cpu:0"](read_batch_features_train/file_name_queue, read_batch_features_train/file_name_queue/RandomShuffle)]]
Traceback (most recent call last):
File "udc_train.py", line 70, in
tf.app.run()
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 30, in run
sys.exit(main(sys.argv))
File "udc_train.py", line 67, in main
estimator.fit(input_fn=input_fn_train, steps=None, monitors=[eval_monitor])
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 240, in fit
max_steps=max_steps)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 578, in _train_model
max_steps=max_steps)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/graph_actions.py", line 280, in _supervised_train
None)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/supervised_session.py", line 270, in run
run_metadata=run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/recoverable_session.py", line 54, in run
run_metadata=run_metadata)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/coordinated_session.py", line 70, in run
self._coord.join(self._coordinated_threads_to_join)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/coordinator.py", line 357, in join
six.reraise(*self._exc_info_to_raise)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/coordinated_session.py", line 66, in run
return self._sess.run(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/monitored_session.py", line 107, in run
induce_stop = monitor.step_end(monitors_step, monitor_outputs)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/monitors.py", line 396, in step_end
return self.every_n_step_end(step, output)
File "udc_train.py", line 64, in every_n_step_end
steps=None)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 356, in evaluate
name=name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/estimator.py", line 620, in _evaluate_model
% checkpoint_path)
tensorflow.contrib.learn.python.learn.estimators._sklearn.NotFittedError: Couldn't find trained model at /home/andy1028/github/chatbot-retrieval/runs/1476255016.
andy1028@andy1028-Envy:~/github/chatbot-retrieval$

sorry, it was fixed by the new code..


doc: net: Enhance net_timeout API documentation

Add overview to net_timeout API documentation.
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Codecov Report

Merging #13571 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13571   +/-   ##
=======================================
  Coverage   52.45%   52.45%
=======================================
  Files         322      322
  Lines       46592    46592
  Branches    10768    10768
=======================================
  Hits        24441    24441
  Misses      17246    17246
  Partials     4905     4905

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2072fbd...2fef0e2. Read the comment docs.

Updated according to comments.


simplify flash BEM API and deprecate the convert_flash_mris function

follow up on https://mne.discourse.group/t/creating-flash5-mgz-files-for-bem-segmentation/4891/1
@larsoner is this going on the right direction for you?

Yes it looks reasonable already!

ok so the test is failing has the convert_flash_mris function effectively does something I don't do here:
        logger.info("\n---- Creating the parameter maps ----")
        if unwarp:
            files = glob.glob(op.join(flash_dir, "mef05*u.mgz"))
        if len(os.listdir(pm_dir)) == 0:
            cmd = (['mri_ms_fitparms'] +
                   files +
                   [op.join(flash_dir, 'parameter_maps')])
            run_subprocess_env(cmd)
        else:
            logger.info("Parameter maps were already computed")
        # Step 3 : Synthesize the flash 5 images
        logger.info("\n---- Synthesizing flash 5 images ----")
        if not op.exists(op.join(pm_dir, 'flash5.mgz')):
            cmd = ['mri_synthesize', '20', '5', '5',
                   op.join(pm_dir, 'T1.mgz'),
                   op.join(pm_dir, 'PD.mgz'),
                   op.join(pm_dir, 'flash5.mgz')
                   ]
            run_subprocess_env(cmd)

this is only done if flash30 is present and this actually changes a bit the surfaces that are produced. I am becoming a bit relunctant do actually remove convert_flash_mris now as otherwise we drop the support for flash30 (no use anymore), and we prevent users for using multiple echos. I would then assume that the multi-echo data have already been synthesized/converted to a single flash5.mgz volume.
@larsoner at UW you have multi-echo flash? how do you deal with it?
@jasmainak @SherazKhan at MGH any opinion? are you using all echos? are you using the mne flash_bem command?

@larsoner at UW you have multi-echo flash? how do you deal with it?

We get DICOM files and dcm2niix them to $SUBJECTS_DIR/$SUBJECT/nii/flash5.nii and flash30.nii. Then we run this script:
#!/bin/csh -ef

set SUBJECT = `pwd|sed 's:/.*/::'`
set source_dir = $SUBJECTS_DIR/$SUBJECT/nii
set dest_dir = $SUBJECTS_DIR/$SUBJECT/mri/flash/parameter_maps

cd $SUBJECTS_DIR/$SUBJECT/mri

mkdir -p flash
cd flash
mkdir -p parameter_maps
mne_setup_mri --mri T1 --subject $SUBJECT --overwrite
cd $dest_dir
mri_convert $source_dir/flash30.nii  ./flash30.mgz
mri_convert $source_dir/flash5.nii  ./flash5.mgz
fsl_rigid_register -r ../../rawavg.mgz -i ./flash30.mgz -o flash30_reg.mgz
fsl_rigid_register -r ../../rawavg.mgz -i ./flash5.mgz -o flash5_reg.mgz
mkdir -p ../../flash30/
mkdir -p ../../flash5/
mri_convert -ot cor ./flash30_reg.mgz ../../flash30
mri_convert -ot cor ./flash5_reg.mgz ../../flash5
cd ../../
mri_convert -ot cor brainmask.mgz brain
mri_convert -ot cor T1.mgz T1

mri_make_bem_surfaces $SUBJECT
mne_watershed_bem --subject $SUBJECT --overwrite

cd ../bem/
mne_convert_surface --tri inner_skull.tri --swap --surfout inner_skull.surf
mne_convert_surface --tri outer_skull.tri --swap --surfout outer_skull.surf
cp ./watershed/${SUBJECT}_outer_skin_surface ./outer_skin.surf

(I have no idea if this script does something correct, I inherited it 10+ years ago and we've just been using it without issue as far as we have seen...)

from this code I understand that flash5.nii and flash30.nii don't have all the echos anymore. Do you if you average all the echos?

I have no idea what gets kept :(
I could share some sample files with you if that would help?

First you use mne_watershed_bem after the mri_make_bem_surfaces

Yes that happens here...
mne_convert_surface --tri inner_skull.tri --swap --surfout inner_skull.surf
mne_convert_surface --tri outer_skull.tri --swap --surfout outer_skull.surf

so the flash images are not used as the BEM files are overwritten.

... but they are overwritten again by the .tri conversion in these lines that follow I think:
mne_convert_surface --tri inner_skull.tri --swap --surfout inner_skull.surf
mne_convert_surface --tri outer_skull.tri --swap --surfout outer_skull.surf

I'm hoping that these .tri files are the ones produced by mri_make_bem_surfaces rather than watershed_bem. So in the end we only keep the outer skin surface from watershed_bem. But I haven't checked...

I think that mri_make_bem_surfaces ignores flash30 so in your code the flash30 is not used at all.

It's possible. I don't really understand how this code works yet, and the BEMs always looked reasonable so I never checked the code I inherited

To summarize from offline conversations/work with @agramfort : my code snippet does produce inner/outer skull from the flash5 (only the outer_skin from watershed is used) but it does not actually use the flash30

@larsoner For whatever it's worth, several years ago when I asked our local Siemens engineer about gradient unwarping he indicated that it was handled on the scanner computer (but for the record, for Siemens the nonlinearity coefficients needed for this should be in the scanner computer's C:\MedCom\MriSiteData\GradientCoil\coeff.grad). Which means that, as far as I can tell, at least for Siemens if you aren't using a flash30 all convert_flash_mris is doing for you is running freesurfer's mri_convert to save the arithmetic mean (not RMS) of the echoes to flash5.mgz.
Our bidsification script is already spitting out a nifti RMS flash5, so I've been using nipype.interfaces.freesurfer to convert that file to mgz and feeding it to make_flash_bem. This also helps with some older data where the flash5 had 5 echoes instead of 8, since (like the classic MNE-C script mne_flash_bem) convert_flash_mris is hard coded for 8 echoes. After that, make_bem_model & make_bem_solution handle the rest.
If a flash30 was available (i.e., --noflash30 was not called), the old MNE-C mne_flash_bem script did have the mri_synthesize step, after running mri_ms_fitparms on all the echoes. Those are both freesurfer binaries so there is probably no easy way to duplicate their function.

Those are both freesurfer binaries so there is probably no easy way to duplicate their function.

I don't think this is much of a problem -- our current flash_bem code uses freesurfer already, so even if we can fix it by using more freesurfer calls it's a step in the right direction

Test failures look real here @agramfort

This is weird:
________________________________ test_flash_bem ________________________________
mne/commands/tests/test_commands.py:324: in test_flash_bem
    mne_flash_bem.run()
mne/commands/mne_flash_bem.py:122: in run
    make_flash_bem(subject=subject, subjects_dir=subjects_dir,
<decorator-gen-77>:10: in make_flash_bem
    ???
mne/bem.py:2041: in make_flash_bem
    run_subprocess_env(cmd)
<decorator-gen-1>:12: in run_subprocess
    ???
mne/utils/misc.py:147: in run_subprocess
    err = err_q.get(timeout=0.01)
/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/queue.py:180: in get
    self.not_empty.wait(remaining)
/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/threading.py:316: in wait
    gotit = waiter.acquire(True, timeout)
E   Failed: Timeout >120.0s

Maybe try increasing to timeout=0.1 or something in run_subprocess?

Awesome, thanks @agramfort !


need public repo for example app source materials (config scripts etc.)

Example: https://github.com/bluek8s/kubedirector/blob/master/deploy/example_catalog/cr-app-spark245.json
"defaultImageRepoTag": "bluedata/spark245:<IP_ADDRESS>"

App config is embedded in the image
    "defaultConfigPackage": {
      "packageURL": "file:///opt/configscripts/appconfig-<IP_ADDRESS>.tgz"
    },

Because I couldn't find the image source code in an open-source repository, to look at what the app-config scripts contained, I had to use docker run -it bluedata/spark245:<IP_ADDRESS> -- /bin/bash to look at the app config source.

The images are in a public repo, but yes we need a better place to store the app config scripts. I need to get caught back up with what the plans for that are.

I meant to say the Dockerfile should be in a public repo, not the docker image.


support multiple webapps

I think we already did that with this structure. So, I would suggest to close this issue.

:+1:


Can you share the datasets of Tmall

Hello, the dataset(Tmall_purchase) given  is not as same as described in the paper (Table  2)
Can you share it  or help me confirm that the origin data is from "Shop Info and User Behavior data from IJCAI-15"
Furthermore, it seems that the ratings in the dataset are re-ranked depending on the original data.
But the meanings of the rankings are not declared.
Can you briefly introduce it
Thank you.

The format of data is "\t\t\t", which is obtained by the specific preprocessing mentioned in the paper.
Actually, since only the date when a user purchased or viewed an item is known, we use one record on the last day as the test data of each user and ignore other records on the very same day. That's why there are only 352,768 purchase records instead of 464,426 records.

Can you share the dataset of Tmall(Tmall_view)?
Thank you!

What is the exact meaning of every column in tmall dataset? It seems that it is different from the original dataset from "Shop Info and User Behavior data from IJCAI-15"?

The format of data is \t\t\t\n"


Orma v3.0.0 has been released!

With lots of bug fixes: https://github.com/gfx/Android-Orma/compare/v3.0.0-rc2...v3.0.0

👀


Wrap code in a check for whether $.validator is defined

This will generate a warning if the validation and unobtrusive validation libraries have not been loaded, rather than causing an error.

De nada. :)


[BUG] - most of the time status icon ia yellow instead of green

When I enter the app the connection status icon at left of the connection name is yellow instead of green

Device: Pixel 7 Pro
Android Version: 14, GrapheneOS
App Version: 3.5.

Uploading wg_tunnel_logs-1724260079.txt…

Hello! I also use grapheneOS and basically what the yellow is signifying is that there has not been a tunnel handshake in a while. If you click on the tunnel you can view the statistics and see the last handshake time. This is expected behavior if there is no traffic going through the tunnel. When you start performing network related tasks, it goes green again.
I am definitely open for to ideas on how to better display this information, but I'll mark this bug as closed for now.
Feel free to add any further feedback here or open a new feature ticket with ideas on how to improve this behavior.


Fix display of local announcement banner

Closes #1817
A small refactor of the announcement banner display logic to fix the display of local announcement banners.

Closing in favor of #1808, thanks all.


feat(e2e): add e2e tests for stream disconnect, vhal methods [WD-11812]

Done

Determine architecture automatically by querying the /nodes endpoint of AMS.
Add e2e tests for stream disconnect + done callback.
Add e2e tests for VHAL: vhalReady callback, getAllVhalPropConfigs, getVhalProperties, setVhalProperties methods.

Until #37 is merged, you can see the test passing here.
Fixes WD-11812

Just one small question: with this change, we would only be running e2e tests against AAOS 13, right? Should we run these tests against multiple LXD images versions? I'm not sure if it's too useful, but I would like to have other opinions.

For now, I'm focusing on having a single image downloaded, and running tests on a session created from that one only. This is to make the tests run reasonably fast. If there is an actual need of running on different images, technically we could do that, however I don't know if it's in the scope of the e2e tests, as it seems more about "testing the images" rather than "testing the features of the Anbox streaming SDK end-to-end". However, this is just my point of view, so I'm happy to hear other opinions and change the workflow accordingly. :)

For now, I'm focusing on having a single image downloaded, and running tests on a session created from that one only. This is to make the tests run reasonably fast. If there is an actual need of running on different images, technically we could do that, however I don't know if it's in the scope of the e2e tests, as it seems more about "testing the images" rather than "testing the features of the Anbox streaming SDK end-to-end". However, this is just my point of view, so I'm happy to hear other opinions and change the workflow accordingly. :)

There are quite a few nuances we do not necessarily can test with every image (e.g. I doubt we have virtual keyboard support for AAOS atm). I think you definitely want one per image variant (android, aaos and generic as well once we start officially supporting that).

@lorumic I've merged https://github.com/canonical/anbox-streaming-sdk/pull/37, if you update the PR we should be able to get tests running now.

@morphis @ajanon
I'm laying the ground for when we'll need to test different features on different images. For this purpose, I tested locally the parallel creation of an AOSP-based app + session and AAOS-based ones. Thanks to the parallel execution, it should not take too much additional time - the test is still running, though, and we'll have to see how it behaves on the runner, since we'd also need to download both images there, unlike locally where they are already downloaded.
If that works well, I will run the join + disconnect stream test on the AOSP session, and the VHAL test (which includes join + disconnect anyway) on the AAOS one. Anything else, I'd like to keep as a future addition so as not to grow too much the scope of this task, which was planned to comprise only what is listed in the "Done" section of the PR description above.
Does that sound reasonable to you?

@lorumic I think we're blocked on https://github.com/canonical/anbox-streaming-sdk/pull/43 before we can merge this one?

As discussed with @edlerd, there are changes to the workflow in this PR which won't get picked up, making the tests still fail. I have another addition of e2e tests in the works (based on this one) which doesn't make changes to the workflow, so we can test the CI changes on that one once I open it. You can check that the tests for this branch are passing by looking at the fork run. So I'm merging this now.


proto: duplicate proto type registered: pb.ConnectRequest

Error message:
2019/12/21 23:58:27 proto: duplicate proto type registered: pb.ConnectRequest

It's likely that some internal dependencies also has this name for a protocol buffer object. If

Closed by https://github.com/RTradeLtd/s3x/pull/11


Support [<BasePath>]

E.g. from their docs:
[BasePath("v1")]
public interface ISomeApi
{
    [Get("first")]
    Task<FirstResponse> GetFirstAsync();

    [Get("{url}")]
    Task GetSecondAsync([Path] string url);
}

Remember, this needs to respect any /absolute/paths in the member annotations: if we pass /foo to GetSecondAsync, the result is that we skip the v1 from the BasePath.
Also from the docs:

If it's specified both ways, then the [BaseAddress(...)] attribute is ignored. This means that you can have a default Base Address specified on the interface, but this can be overridden when actually instantiating it using RestClient.

Oops, I implemented BaseAddress and not BasePath in #44.


How to train Dialogrnn on MELD dataset ?

We have provided the script to train it on the MELD dataset. Please check the DialogueRNN folder.

Thank you！I tried to fix the problems of the previous version of the codes but failed, the new version works.


Master branch tests fails

I'm working from the master branch. I guess that's the right place to start?
I discovered that nothing happens when I press Submit on the Survey builder.
So I decided to run the tests:
PhantomJS 2.0.0 (Mac OS X): Executed 6 of 77 SUCCESS (0 secs / 0.04 secs)
ERROR [karma]: [TypeError: Line must be greater than or equal to 1, got 0]
TypeError: Line must be greater than or equal to 1, got 0
  at SourceMapConsumer_findMapping [as _findMapping] (/Users/martins/Work/ReactJS/bleeding-edge-sample-app/node_modules/karma/node_modules/source-map/lib/source-map/source-map-consumer.js:286:15)
  at SourceMapConsumer_originalPositionFor [as originalPositionFor] (/Users/martins/Work/ReactJS/bleeding-edge-sample-app/node_modules/karma/node_modules/source-map/lib/source-map/source-map-consumer.js:3
46:24)
  at /Users/martins/Work/ReactJS/bleeding-edge-sample-app/node_modules/karma/lib/reporter.js:49:28
  at String.replace (native)
  at /Users/martins/Work/ReactJS/bleeding-edge-sample-app/node_modules/karma/lib/reporter.js:36:23
  at /Users/martins/Work/ReactJS/bleeding-edge-sample-app/node_modules/karma/lib/reporters/base.js:105:14
  at Array.forEach (native)

Am I doing anything wrong or is it a bug in the master branch?
Cheers,
Martin

Hi,
Can I get feedback on this issue? I want to believe that the book is worth reading.  When the master branch fails and I get no feedback I get the feeling that this is a half ready product.
Please let me know why the examples fail and how to fix them.

1

Would be great to have a working demo..

Closed: see #49


PHP version bump

@EvanK - any chance we could get the PHP version bumped to >= 5.4?

This is tricky because we're using Ubuntu's stock apache/php packages, and genesis is still based on Precise (12.04).
So...we'd have to find ppa's for precise that backport not only PHP 5.4+, but any php extensions in use (including mysql, curl, gd), and possibly the php apache module (I'd have to investigate further if that's the case).
It might be simpler (and I'd highly recommend) to import the existing genesis site into evolution, which is based on Trusty (14.04) and comes with stock php 5.5 and apache 2.4

Yeah an import to Evolution makes most sense then.  Thanks.


Can this only fetch files/images from the web or also files stored locally?

How can i reference files like pdf, docx stored locally?

Also all of the documents don't load for me on the 1.2.0 version. PDF and JPEG online files load fine using 1.1.0 version.

Also all of the documents don't load for me on the 1.2.0 version. The error message i get is "File extension is not supported." on 1.2.0 version. PDF and JPEG online files load fine using 1.1.0 version.

Firstly to expose your local files to the public. You can use packages like localtunnel or ngrok.
About supported file, make sure the file extension is 'pdf'

@avipunes ?

@avipunes Do you know how can i view .docx and .xlsx blob files ?

Under the hood, this library uses Microsoft API which needs a public URL. Can yo6 share the URL of the file you're using?

@avipunes Do you know how can i view .docx and .xlsx blob files ?

Under the hood, this library uses Microsoft API which needs a public URL. Can yo6 share the URL of the file you're using?

This is the url generated by the createObjectURL function after passing the uploadedFile into it.
blob:http://localhost:8080/9cf55be4-a822-4a49-bf56-812ce6f9a87e

@avipunes Do you know how can i view .docx and .xlsx blob files ?

Under the hood, this library uses Microsoft API which needs a public URL. Can yo6 share the URL of the file you're using?

This is the url generated by the createObjectURL function after passing the uploadedFile into it.
blob:http://localhost:8080/9cf55be4-a822-4a49-bf56-812ce6f9a87e

Its not a public URL, its a file url of a file that was uploaded locally. I guess my other option would be a DOCX to HTML converter library that i can use to preview the file with? Or any better suggestions?

As I said, the library supports ONLY URLs publicly open to the internet. Localhost won't work.


Animate when clicking on active dot of navigation

When i use fade effects for transition and clicking on the current active dot of navigation. It still animates though it should not.

There were some problems with this in beta 2.4, but it's fixed in beta 3. Test Case


Added Github-Readme-Quotes Project

[feat] added github-readme-quotes README Utility tool for contribution
ℹ Repository information
The repository has:

[x] At least three issues with the good first issue label.
[x] Detailed setup instructions for the project.
[x] CONTRIBUTING.md
[x] Actively maintained.

Thank you for accepting my PR!
Cheers!


DQ over datasets no longer in preview

The link on the bottom of the page referencing DQ over PBI datasets still says preview although that feature is now GA.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1ed1625f-12a2-5962-2959-696188711efe
Version Independent ID: d8796367-6bd1-c63c-db86-59eb5a66c213
Content: DirectQuery in Power BI - Power BI
Content Source: powerbi-docs/connect-data/desktop-directquery-about.md
Service: powerbi
Sub-service: pbi-data-sources
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @gmuenster. This issue has been assigned to the doc author for review.

Thanks for pointing that out, I've fixed that reference to clarify it's no longer in preview. Much appreciated.


Conditionally assign Flux variable - error

The following code results in an unexpected error:
WINDOW = 1d
START = if WINDOW == 1d then today() else 2022-01-01

Result:
unsupported binary expression duration == duration

Environment info:
Linux 5.13.19-6-pve x86_64
InfluxDB v2.3.0+SNAPSHOT.090f681737 (git: 090f681737) build_date: 2022-06-16T19:33:50Z
Submitted at the request of @Anaisdg

@ot3, the syntax is correct for conditionally setting the variable and this type of variable assignment is supported. The problem here is the type constraints assigned to duration values. It looks like durations types aren't currently equitable or comparable. This seems like a bug to me, but it may be by design.
I'm going to rename this issue and transfer it to the Flux repo.
In the mean time, there is a workaround. You can convert your duration value to an integer and then compare it. For example:
WINDOW = 1d
START = if int(v: WINDOW) == int(v: 1d) then today() else 2022-01-01


out of memory when using sem seg post processing before inference

Hi,
I am recently using your model and I think it was an excellent work!
However, I noticed that you set the value sem_seg_postprocess_before_inference to be true when panoptic_on or instance_on is true. Is it mandatory to do that? I am using the same setting and it keeps reporting oom when doing the inference on relatively larger images and the computing are sent to cpu which leads to very low speed.
Looking forward to hearing from you, thank you in advance!

Hi @TianjinTeda, the sem_seg_postprocess_before_inference is crucial because we check that flag to decide whether to resize the predictions to the original resolution before post-processing. If your image resolution is very high compared to your GPU memory, it's expected to obtain an OOM error.
https://github.com/SHI-Labs/OneFormer/blob/4962ef6a96ffb76a76771bfa3e8b3587f209752b/oneformer/oneformer_model.py#L327-L330
If you want to try something different, you could resize the final panoptic_map and result.pred_masks instead. However, note that we have not tested the performance using this approach.
https://github.com/SHI-Labs/OneFormer/blob/4962ef6a96ffb76a76771bfa3e8b3587f209752b/oneformer/oneformer_model.py#L434
https://github.com/SHI-Labs/OneFormer/blob/4962ef6a96ffb76a76771bfa3e8b3587f209752b/oneformer/oneformer_model.py#L475


Remove .only

@matteofigus
I'm confused how it still runs the whole suite with .only. Anyway might as well to remove it.

Ah! Good catch, thanks @nicotaing
I think the "whole" is unit, integration and client-side, but in case of acceptance, it was executing only this one (each suite runs in a separate task and the only is relative to that).


Auto create issue on unhandled exception

Currently. when an unhandled exception occurs, it logs the error to the technical chat group. We should also have it create a GIT issue.

API available https://developer.github.com/v3/issues/#create-an-issue


eval data of dyval2

Hello, could you please release the generated eval data of dyval2?

Sure, could you please send an email to<EMAIL_ADDRESS>so that I can send you all the evaluation data?


JAVA - import contact return error 429

hi
I use this code in java
client.send(new TdApi.ImportContacts(contacts), object -> {
                        switch (object.getConstructor()) {
                            case TdApi.Error.CONSTRUCTOR:
                                System.out.println("Receive an error for GetChats:" + newLine + object);
                                break;

                            default:
                                System.out.println("Receive wrong response from TDLib:" + newLine + object+ newLine+object.getClass());
                        }
                    });

and allways response is:
Error {
  code = 429
  message = "Too Many Requests: retry after 282"
}

I use different size of contact 10,600,5000 but nothing happend in all import contact request give this error

You are restricted from importing contacts by the server. This method has a very tight flood control.

It is a server restriction. We can't do anything about it.

ok tnx


style: Remove unused styles/classes from global.scss

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[ ] Feature
[X] Refactoring

Context

[X] Closes #9012
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[X] My contribution builds clean without any errors or warnings
[X] I've merged recent default branch -- main and I've no conflicts
[X] I've tried to respect high code quality standards
[X] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[X] Fill up your DOT address: Payout

Community participation

[ ] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

thanks!
pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 7.11 USD/DOT ~ 2.813 $DOT
🧗 16hqk8Tjugo9AwSzKkxXc1dsRK7iJetpx1YBaoXYwdHzuNAt
🔗 0x6e1a4eaff736b85934a354fec4df8098e7ffec63de0e053987806071774454bf
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Stop taking a Guice Injector instance around

Embulk takes a Guice Injector instance around as a service locator. It makes everything complicated, tightly-coupled, and depending on Embulk's internal structure. We should (gradually) stop taking the Injector instance around.

Created for EmbulkEmbed.

Passed for ExecSession from EmbulkEmbed

Guess
Preview
Run

Disclosed from Exec through ExecSession => Plugins can see.

Passed for BulkLoader
Passed for ExecSession ==> Plugins can see.

Resume
Cleanup

[ModelManager]
[JRubyScriptingModule]

[JRubyInitializer]

=> Plugins can see.

[PluginManager]

[InjectedPluginSource]
[MavenPluginSource]

[FileInputRunner]
[PreviewExecutor] (not used actually?)
[GuessExecutor] (not used actually?)

Guice has been removed through v0.10.


add headerimage option

@kirschbombe Have you tried it in Firefox. The current branch does that in safari. I has some cross origin blocking for localhost.

I haven't tried it in Firefox, but if it's not working in Safari, then we should resolve that before merging it into the master branch. I'll merge it into refactor, but refactor won't be merged until everything is working :) Also, I won't be able to test future PRs if refactor is resulting in a blank page.

@kirschbombe Should work in Safari locally now.

@dnoneill - this fixed it and I merged the changes into refactor, but there shouldn't be a running title on the home page. Can you remove that? Also, the favicon is now a IIIF logo instead of the hexagon image.


111f release commits

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Go


Add "Create Unity C# Projects" option to Project Config dialog

I love being able to set the project build settings with "one click" using the Apply Project Settings option. There is one setting, however that I always have to go to Unity's build dialog for: "Unity C# Projects".
It would be nice to not have to do that step manually. In fact, the same is true for devs who use the "Development Build" option.

The build window has it.

I must be blind today :)


Adding in UITableViewCell

I’m adding LCBannerView in a UITableViewCell, it seems that it is adding this again and again as i’m seeing overlapped images after scrolling.
Any suggestions how can I fix this?

Sorry this is my fault... But I can't fix it now...
But I have some Advice, you could change some properties in .m file, like imageName, imageURLs... You could move those from .m file to .h file, and than, you should reset bannerView.imageName, bannerView.imageURLs... in UITableView's delegate method tableView:cellForRowAtIndexPath:, for example:
cell.bannerView.imageName = self.dataSourceArray[indexPath.row][@"imageName"];
cell.bannerView.imageURLs = self.dataSourceArray[indexPath.row][@"imageURLs"];

If I'm free, I will fix it like this way :)

Thanks. 👍
I’ll give it a try.

Hey, I had fix this bug a moment ago, you could run pod update to get the Latest release.
For more information you could see the README's Release Logs.

Thanks much appreciated.


Closes #206 | Add Dataloader SleukRith Set

Closes #206
Sorry if this PR is made before any final decision in #206, I just want to rush things.
Some possible discussions:

Add another task for OCR (see #555). After that one is merged, I will remove the corresponding file here.
Used third-party libraries to download the data, i.e., pip install gdown. I am aware that I should made a separate PR for this, just want to put this here first for reviewers to discuss the implementation. Related discussion is on #206.
I store the downloaded data in data/sleukrith_ocr/, thus the updated .gitignore. Again, should be on a separate PR, right?
The raw image dataset is in binary. I convert the image data as numpy arrays, and then save the image as a file so I can store the image path for the schema (see _generate_examples()). What do you think about that? Should I just store the image as numpy arrays instead?

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@holylovenia Resolve some changes and added additional package handling.

This task has to be added in a separate PR.

I'll make the new PR once everything on the dataloader part is done and reviewed.

IDK why constants.py is still listed as a changed file here even tho I already changed it by running git checkout upstream/master -- seacrowd/utils/constants.py. I think I will delete the file manually then.
I think I also need to make a new PR for adding data/ in .gitignore, right? @holylovenia

I think I also need to make a new PR for adding data/ in .gitignore, right? @holylovenia

Yes yes, I'll approve that PR once you create it.

Yes yes, I'll approve that PR once you create it.

#658 and files removed. This PR should be done on my part.

A friendly reminder for @akhdanfadh to address @sabilmakbar's suggestions. 🙏

@sabilmakbar Done, please check my replies.

@sabilmakbar Done with the inline comments.

lgtm, thanks @akhdanfadh!


WIP: Create .appveyor.yml

I like the use of vcpkg!
Here's my previous attempt, in case there's anything worth stealing. Something was causing the build to fail, but I don't recall what it was now. I think I couldn't download some dependency I needed or something.
Some of the other OSVR repositories have appveyor.yml files already, too. However, you might want to update those to make use of vcpkg (and generate packages) if you haven't already.

yeah, I have a WIP vcpkg for osvr-core but vcpkg isn't very friendly to the idea of submodules with your deps.


Parser: implement __builtin_choose_expr

Similar to conditional operator, except:

First argument must be an integer constant
return type matches that of chosen expression and does not undergo promotion
unchosen expression is not evaluated
can return an lvalue if the chosen expression is an lvalue

Needing to add 2 arguments to Tree.isLval seems like a bit of a code smell - is there something I'm missing that would be easier?


Add mint & burn to L2 ETH

Description
Questions

Metadata
Fixes

Fixes # [Link to Issue]

Contributing Agreement

[x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

Maybe consider adding increaseAllowance and decreaseAllowance to prevent frontrunning with approve. I believe this could also be taken advantage within a single transaction if an evil contract is called and transfers the full approve amount before  approve is called again later in the execution path
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#ERC20-decreaseAllowance-address-uint256-

Maybe consider adding increaseAllowance and decreaseAllowance to prevent frontrunning with approve. I believe this could also be taken advantage within a single transaction if an evil contract is called and transfers the full approve amount before  approve is called again later in the execution path
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#ERC20-decreaseAllowance-address-uint256-

Maybe consider adding increaseAllowance and decreaseAllowance to prevent frontrunning with approve. I believe this could also be taken advantage within a single transaction if an evil contract is called and transfers the full approve amount before approve is called again later in the execution path
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#ERC20-decreaseAllowance-address-uint256-

@tynes what do you think about holding off on this for now & adding it in a future release? mint/burn covers the basics of what we need for ETH deposits & so at this point trying to just focus on that

Maybe consider adding increaseAllowance and decreaseAllowance to prevent frontrunning with approve. I believe this could also be taken advantage within a single transaction if an evil contract is called and transfers the full approve amount before approve is called again later in the execution path
https://docs.openzeppelin.com/contracts/2.x/api/token/erc20#ERC20-decreaseAllowance-address-uint256-

@tynes what do you think about holding off on this for now & adding it in a future release? mint/burn covers the basics of what we need for ETH deposits & so at this point trying to just focus on that

I'm fine with adding it in a future release, makes sense to not squeeze too many things in at once. Would be more useful when there is arbitrary contract deployment

I'm fine with adding it in a future release, makes sense to not squeeze too many things in at once. Would be more useful when there is arbitrary contract deployment

LGTM

LGTM


New tutorial for ROS 2 rqt_console

Signed-off-by: maryaB-osr<EMAIL_ADDRESS>

@clalancette or @hidmic can I merge?


Undo use of 1.9 Hash syntax

This seemed to be the only location that was using the 1.9 Hash syntax, so I undid that, and everything works fine on 1.8.

Good catch, thanks.


Code Sharing -- Issue #443

This has a lot of overlap with the .NET Standard Library doc. We should focus all of the definitional content in that doc. I skipped some of that material (like that image) because I wasn't keen on it.
I was proposing that you focus this doc exclusively on binary and source sharing and not specific to .NET Standard, but inclusive of it.

@rpetrusha, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Closing to open a new pull request from my own fork.


Ensure calling webview.send will not block the renderer

When the browser process is busy, calling webview.send (a method that appears on its face to be non-blocking) will actually block, because most webview methods are remoted to a guest view instance in the browser process. Instead, define a few methods which will instead send its call over an async IPC message.

:+1:


Figure out to do about Websocket's terminate

Currently we call terminate/3 with Req undefined. Is that really what we want? Is there a more appropriate solution?

The appropriate solution is of course to keep some of Req. I can see a Websocket option that allows users to specify what they want to keep from the request, that would default to the uri components.

This is done, new option req_filter was added.


About menu does not show

The about menu is not shown when clicking on About.

The problem has been fixed in the most recent commit to a new branch smcfadden-fc-polishPass


Remove IVF_FLAT_NM index type

IVF_FLAT_NM increases the complexity for following feature's development:

IVF_FLAT + COSINE support GetVectorByIds
zero copy

it's time to remove IVF_FLAT_NM index type

/assign

/close


Add vcredist2013 to p4merge dependencies

Fixes #1762

Do not depend on vcredists. Make it only suggest.


[SPARK-48394][CORE] Cleanup mapIdToMapIndex on mapoutput unregister

What changes were proposed in this pull request?

This PR cleans up mapIdToMapIndex when the corresponding mapstatus is unregistered in three places:

removeMapOutput
removeOutputsByFilter
addMapOutput (old mapstatus overwritten)

Why are the changes needed?

There is only one valid mapstatus for the same mapIndex at the same time in Spark. mapIdToMapIndex should also follows the same rule to avoid chaos.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Unit tests.
Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun Thanks for the reminder. Have created a separate ticket: SPARK-48394.

Merged to master only because this was defined as Improvement.

@dongjoon-hyun  @mridulm  Sorry, can we make it a bug and backport to maintenance release branches? This actually causes us an issue internally. I was pushing a quick fix before realizing it is the root cause.
The issue leads to shuffle fetch failure and the job failure in the end. It happens this way:

Stage A computes the partition P0 by task t1 (TID, a.k.a mapId) on executor e1
Executor Y starts deommission
Executor Y reports false-positve lost to driver during its decommission
Stage B reuse the shuffle dependency with Stage A, and computes the partition P0 again by task t2 on executor e2
When task t2 finishes, we see two items ((t1 -> P0), (t2 -> P0)) for the same paritition  in mapIdToMapIndex but only one item (mapStatuses(P0)=MapStatus(t2, e2)) in mapStatuses.
Executor Y starts to migrate task t1's mapstatus (to executor e3 for example) and call updateMapOutput on driver. Regarding to 5), we'd use mapId (i.e., t1) to get mapIndex (i.e., P0) and use P0 to get task t2's mapstatus.

// updateMapOutput
val mapIndex = mapIdToMapIndex.get(mapId)
val mapStatusOpt = mapIndex.map(mapStatuses(_)).flatMap(Option(_))

Task t2's mapstatus's location then would be updated to executor e3 but it's indeed still located on executor e2. This finally leads to the fetch failure in the end.

Looks like a valid bug to me - can you raise a backport ?
@dongjoon-hyun , thoughts on changing the type from improvement to bug ?

Of cource, @Ngone51 can.
Feel free to update the JIRA issue and backport this.
BTW, please create the JIRA issue properly next time, @Ngone51 , because it's used for our communication .

Thanks. Created the backport PR (https://github.com/apache/spark/pull/46747) for branch-3.5.


Debug.WriteLine don't work like string.Format

In branch master there are some Debug.WriteLine that uses string.Format syntax which will result in some strange output.
e.g.
In ModbusMasterTcpConnections.cs - ReadHeaderCompleted (line 87)
 Debug.WriteLine("MBAP header: {0}", string.Join(", ", thisRef._mbapHeader));
The output will be:
0, 1, 0, 0, 0, 69: MBAP header: {0}
Instead of the intended:
MBAP header: 0, 1, 0, 0, 0, 69
Debug.WriteLine is using this method WriteLine(string, string)
So to get the intended output you either use

Debug.WriteLine(string.Format("MBAP header: {0}", string.Join(", ", thisRef._mbapHeader)));
 Debug.WriteLine( string.Join(", ", thisRef._mbapHeader),"MBAP header");

Suggestion:
Debug.WriteLine(**$**"MBAP header: {string.Join(", ", thisRef._mbapHeader)}");


added_new_databases

New Datasets for Aave Liquidations v2/v3

Can we merge this? Need to load the liquidations datasets.


Problem with amd modules: "define cannot be used indirect"

Sometimes webpack throws an error saying define cannot be used indirect. It's caused by various third-party modules (like moment.js) which use a module pattern like
(function (factory) {
    if (typeof define === 'function' && define.amd) {
        define(['moment'], factory); // AMD
    } else if (typeof exports === 'object') {
        module.exports = factory(require('../moment')); // Node
    } else {
        factory(window.moment); // Browser global
    }
}(function (moment) { ... }))

What's wrong with this module definition? And what can we do about it?

https://github.com/dfahlander/Dexie.js/blob/master/src/Dexie.js#L3203-L3204 line gets built with same error.

+1 about Dexie error

@sairion @shichongrui Have you found a workaround to use Dexie with webpack?
Resulting bundle throws on initial execution for me...

@tp For now I pulled down my own copy and changed the line publish("Dexie", Dexie) to module.exports = Dexie

@sairion @shichongrui @tp
Hacky, hacky, hacky-hacky... hacky work around seems to work for me:
In my webpack.config.js file I added this:
// ...snip...
module: {
    loaders: [
      // ...other loaders...
      {
        test: /Dexie.js$/,
        include: /node_modules\/dexie/,
        loader: StringReplacePlugin.replace({ // from the 'string-replace-webpack-plugin'
          replacements: [
            {
              pattern: /define\.amd/ig,
              replacement: function(match, p1, offset, string) {
                return false;
              }
            }
          ]
        })
      }
    ]
  }

I believe the reason this works is because by turning the define.amd into false webpack sees this as a now dead branch and is able to prune it from the code.
Sorry if my work around made you cry but it is better than including the static file in the repo.

In the latest version of the request package I seem to get this error. Not sure why/where the error occurs or how to find out, and therefore not sure if this should be fixed in webpack or request. It seems to me it would be nice if webpack could just compile these packages... Here's the issue on the GH page of the request package: https://github.com/request/request/issues/1920

The same problem with request(node-gitlab dependency) in trace,  but problem was in Validate.js
module: {
    noParse: /validate\.js/
}

Fixes "define cannot be used indirect"  problem

Your noParse config is very risky. It will ignore any file with that name. You should add node_modules or something to disambiguate it.

Thanks, changed to
module: {
    noParse: /node_modules\/json-schema\/lib\/validate\.js/
}

@artem-russkikh  That solved it for me as well. Thanks

Same problem here. noParse solved it.

+1
this one helped me

@artem-russkikh +1

I'm experiencing the same problem with the validate.js dependency however if I specify a pattern with more path levels than just /validate\.js/ in noParse, the amd-define.js built-in is added by webpack and the error about anonymous define is thrown. Can anyone think of a reason the full node_modules path to the script as provided by @artem-russkikh wouldn't match (yes, it is in the file system at that path).

Worked! Yay! +1 jmlane for the hint.
Stuff worked again after adding:
            module: {                 noParse: /node_modules\\json-schema\\lib\\validate\.js/             }
to my webpack config on a windows machine

@artem-russkikh I use what you post.but still a same error on console.

@YeZhiqiuSev provide more info

I used the solution provided by @artem-russkikh but still not working yet.
I am using phantomJs with karma for unit testing.
npm -v phantom/karma/webpack ==> 3.9.5
node -v ==> v6.2.2
I encounter this problem whenever I run the unit test.
Thanks for any help.

I am experiencing this same issue with ace editor. Is this something that is going to be fixed? It seems like this behavior is incorrect.
Uncaught Error: define cannot be used indirect
module.exports @ amd-define.js:1
(anonymous function) @ mode-pgsql.js:1
__webpack_require__ @ bootstrap 19e4fb2…:19
(anonymous function) @ index.js:9
__webpack_require__ @ bootstrap 19e4fb2…:19
(anonymous function) @ bootstrap 19e4fb2…:39
(anonymous function) @ bootstrap 19e4fb2…:39

I tried the "noParse" solution to exclude the package "request", but then the "request" package started trying to require files from a wrong folder
Error: Cannot find module '/home/rafa93br/meteor/meteor-webpack-redux/.meteor/local/build/programs/server/npm/node_modules/lib/cookies'
W20160901-23:15:31.046(-3)? (STDERR)     at Function.Module._resolveFilename (module.js:325:15)
W20160901-23:15:31.046(-3)? (STDERR)     at Function.Module._load (module.js:276:25)
W20160901-23:15:31.047(-3)? (STDERR)     at Module.require (module.js:353:17)
W20160901-23:15:31.047(-3)? (STDERR)     at require (internal/module.js:12:17)
W20160901-23:15:31.047(-3)? (STDERR)     at Npm.require (/home/rafa93br/meteor/meteor-webpack-redux/.meteor/local/build/programs/server/boot.js:185:18)
W20160901-23:15:31.047(-3)? (STDERR)     at Object.version (webpack:///~/pokemon-go-node-api/~/request/index.js:21:1)
W20160901-23:15:31.047(-3)? (STDERR)     at __webpack_require__ (webpack:/webpack/bootstrap e2ea476b94c7f37bb993:22:1)
W20160901-23:15:31.047(-3)? (STDERR)     at Object.<anonymous> (webpack:///~/pokemon-go-node-api/poke.io.js:18:1)
W20160901-23:15:31.048(-3)? (STDERR)     at Object.<anonymous> (webpack:///~/pokemon-go-node-api/poke.io.js:882:1)
W20160901-23:15:31.048(-3)? (STDERR)     at __webpack_require__ (webpack:/webpack/bootstrap e2ea476b94c7f37bb993:22:1)

'/home/rafa93br/meteor/meteor-webpack-redux/.meteor/local/build/programs/server/npm/node_modules/lib/cookies'

is wrong, it should be:
'/home/rafa93br/meteor/meteor-webpack-redux/.meteor/local/build/programs/server/npm/node_modules/request/lib/cookies'

Why is this happening? Please help me i'm losing my mind =(

@rafaelcorreiapoli is this related to the issue? If this is a bug, please open a new bug report. If you need support, please create a stack overflow question. This way, others may profit from the answer.

Hello people,
Got the same problem. I've tried all recommendation from this thread but no success.
The problem happens when I import 'list.pagination.js';. List pagination plugin has 2 dependencies:
var classes = require('classes');
var events = require('event');

https://github.com/Gozala/event
https://github.com/kbjr/class.js
"webpack": "^1.13.1",
How can I fix that?

I'm getting this same error in Webpack 2. The code is like this:
define({
    Foo: './Foo',
    BaseClass: '../BaseClass'
}, function (imports) {
    var Bar = BaseClass.extend.call(Foo, 'Bar', {
        initialize: function initialize(args) {
            Foo.call(this, args);
        }
    });
    return Bar;
});

which compiles to
__webpack_require__(67)({
    Foo: './Foo',
    BaseClass: '../BaseClass'
}, function (imports) {
    var Bar = BaseClass.extend.call(Foo, 'Bar', {
        initialize: function initialize(args) {
            Foo.call(this, args);
        }
    });
    return Bar;
});

where module 67 throws that error.
Is it because the define syntax is wrong (i.e. it normally doesn't accept an object as first arg)?

@jafar-rezaei
I ended up adding this to my Webpack config:
{
    test: require.resolve("jquery-migrate"),
    use: "imports-loader?define=>false",
},


--log-format unix timestamp epoch

Is there a way to set unit timestamp epoch using --log-format? I cannot find any idea based on the docs here https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-log-format.

Hmmm, seems this was an old problem and IIRC matt had some comments. But I forget the issue link.
cc @mattklein123


update ubuntulinux.md

Signed-off-by: Yuan Sun<EMAIL_ADDRESS>

Nice catch. Thank you.  LGTM

ping @jamtur01 @SvenDowideit @fredlf

LGTM


[DOCU-2790] Retire konnect legacy docs

Summary

Deleting konnect legacy docs. They don't need to be archived or kept anywhere for reference, as the old environment will no longer be accessible by any users.
Deleting old Konnect API docs from the archive. They were kept there as reference until we got a new API for Konnect, which we now have.
Search for and scrub konnect.konghq.com from the rest of the docs.
Redirects from old docs to /konnect/

Reason
Now that Konnect accounts have all been migrated from konnect.konghq.com to cloud.konghq.com, we can remove legacy docs from the site.
Testing
https://deploy-preview-4777--kongdocs.netlify.app/konnect/

Test redirects from /konnect/legacy/ to just /konnect/
Check that the legacy docs no longer display on the site

With the redirect written this way if a customer has this bookmarked https://docs.konghq.com/konnect/legacy/runtime-manager/gateway-runtime-docker/ it would redirect to /konnect/ Why not have it point here: https://docs.konghq.com/konnect/runtime-manager/runtime-instances/gateway-runtime-docker/

Based on conversation outside of GH, keeping the redirects more general. We already have redirects for the old locations of the docs, pre-IA rework. For Konnect legacy docs - which were always meant to be temporary - the usage was always extremely small, so maintaining a large list of redirects for docs that we only had for a few months is an unnecessary maintenance burden for us.

Smoke test is being flaky, isn't an actual failure. Merging with that in mind.


adding fixes in varnish-mui

PR addresses:  #58 , #54

@jonborchardt - modified to just be the header + link changes, will follow up with button disabled investigations as we've discussed


New article: troubleshoot dotnet tool usage

/cc @KathleenDollard @wli3

I had a round of read, it looks good

This is ready for a new review @wli3. It should finish building soon and should show up at https://review.docs.microsoft.com/en-us/dotnet/core/tools/troubleshoot-usage-issues?branch=pr-en-us-14619

Thanks @wli3. I believe I've addressed your feedback.

looks good now. what's next? can we just merge it and see it shows up in doc?

I can merge as soon as @KathleenDollard or one of the folks from my team review this.


Issues with parsing multiple commands on the same line

An issue seems to arise when trying to parse say 'G04 S10' which would mean dwell the machine for 10 seconds, but this is impossible due to the current design of the parsing algorithm, which interprets the S as the spindle speed command by the same char naming 'S' as the G04's parameter for seconds.
I'm not sure how to fix this completely without going off and changing everything about the parsing system.
Perhaps adding a priority system for parameters would be an ideal option, but this will definitely require a redo of the system.

Fixed the issue by creating a new Rule<List<ICommand>> named CommandPriorityRule which works by checking if the list of commands contains a supposed SpindleSpeedSetter (The 'S' Command), if it does it proceeds to delete it and transfer it's value to the previous command which is likely to be of type G04 or M00 which both require either a S (seconds) or P parameter.
This works flawlessly in the code context, however there is still a persistent issue in the GCodeEditor, telling the user that the 'S' parameter is actually the SpindleSpeedSetter which is incorrect. But this isn't major in any case, just a visual fault for the user.

This seemed okay, but is now messing with Regex color coding.
Regardless, it is not of a high priority currently.

Ruling out the regex color coding, this work as intended, but a further fix will not be delivered for the time being.


Add support python 3.12

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:loudspeaker: Thoughts on this report? Let us know!.

Hi @gaugup. I'd be quite keen to get this merged in.
I'm doing some work with dice-ml, and pandas >= 2.0.0 is quite important.
Would you be able to re-run testing, to see if the windows py312 issue has resolved itself?


supply crate tracker

Is your feature request related to a problem? Please describe.
There's recently been added a few new trackers for for example birds nests / seed packs, and it's kind of inconsistent that there hasnt been added one for Wintertodt supply crates, as I'd like to be able to track the loot I get from wintertodt over long periods of time.
Describe the solution you'd like
The loot tracker expanded to check and log wintertodt supply crates, just like how we've recently got Seed packs and Birds nests added to the loot tracker

Duplicate of #5824


ParseError: KaTeX parse error: Expected & or \ or \cr or \end at end of input: ...

in vscode ,  the formula is rendered with katex, an KaTeX parse Error occurred

in pycharm , it's rendered  properly with mathjax

latex code:
%%latex
\begin{gather}
        H(x)=\log{\left(\sqrt{2} \right)}h_1(x)+\log{\left(\frac{\sqrt{15}}{3} \right)}h_2(x)+\log{\left(\frac{\sqrt{21}}{3} \right)}h_3(x)
        \\
         \displaystyle
   h_1(x)=\begin{cases}
    1 \ & \mathrm{if} \  x>=5.5 \\
    -1 \ &\mathrm{if} \  x<5.5
    \end{cases}
    ,\quad \displaystyle
   h_2(x)=\begin{cases}
    -1 \ & \mathrm{if} \  x>=4.5 \\
    1 \ &\mathrm{if} \  x<4.5
    \end{cases}
    ,\quad \displaystyle
   h_3(x)=\begin{cases}
    1 \ & \mathrm{if} \  x>=3.5 \\
    -1 \ &\mathrm{if} \  x<3.5
    \end{cases}
\end{gather}

The equation renders fine if you wrap it in $$ so I recon it's related to how we handle bare math blocks. Relevant code: https://github.com/mjbvz/markdown-it-katex

wow

Hi @viocha @mjbvz Can I work on this?

sure
---Original---
From: @.>
Date: Thu, Jun 16, 2022 00:04 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] ParseError: KaTeX parse error: Expected & or \ or \cr or \end at end of input: ... (Issue #149593)
Hi @viocha @mjbvz Can I work on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@viocha Can you let me know where to get started?
As per the last comment, it works when wrapping with "$$" so I figure I need to look into how vscode is rendering lateX in general? any other pointers?

https://katex.org/docs/options.htmlhttp://docs.mathjax.org/en/latest/options/input/tex.html
the reason is probably katex can't process environments outside $$ , but i wonder if katex has a similar option 'processEnvironments' like MathJax provides
---Original---
From: @.>
Date: Fri, Jun 17, 2022 19:33 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] ParseError: KaTeX parse error: Expected & or \ or \cr or \end at end of input: ... (Issue #149593)
@viocha Can you let me know where to get started?
As per the last comment, it works when wrapping with "$$" so I figure I need to look into how vscode is rendering lateX in general? any other pointers?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

This is the same for .NET Interactive


Vercel Edge Error: Dynamic require crypto is not supported

Describe the bug
I am currently trying to leverage edge functions however, I am getting the following error after a successful build and deploy when trying to access the route that is configured with the edge runtime:
Error: Dynamic require of "crypto" is not supported
    at (../../../../.svelte-kit/vercel-tmp/fn-5/edge.js:13:7)
    at (../../../../node_modules/@hapi/iron/lib/index.js:3:15)
    at (../../../../.svelte-kit/vercel-tmp/fn-5/edge.js:13:7)
    at (../../../../.svelte-kit/output/server/chunks/cookie.js:1:61)
    at (../../../../.svelte-kit/vercel-tmp/fn-5/edge.js:13:7)
    at (../../../../.svelte-kit/output/server/chunks/hooks.server.js:1:0)
    at (../../../../.svelte-kit/vercel-tmp/fn-5/edge.js:13:7)
    at (../../../../.svelte-kit/output/server/chunks/internal.js:92:47)
    at (../../../../.svelte-kit/output/server/index.js:45:11981)
    at (../../../../.svelte-kit/vercel-tmp/fn-5/edge.js:14:1)

My feeling is it's something with @hapi/iron library which I'm using to decrypt encrypted cookies in my hooks.server.js file.
In my test I created a simple route:

Here is the config in the page.js file:
export const config = {
	runtime: 'edge',
	external: ['stream', 'crypto', 'os', 'path', 'fs', 'http', 'https']
};

I am included the externals as I was getting errors during the build and from my understanding this is what at that property is for (But could be wrong).
Reproduction
https://github.com/livlabs/edge-issue-repro
The error appears when you go to this page: https://edge-issue-repro.sitepreview.page/sverdle
Logs
[GET] /sverdle/__data.json?x-sveltekit-invalidated=01 reason=EDGE_FUNCTION_INVOCATION_FAILED, status=500, user_error=true

Error: Dynamic require of "crypto" is not supported
    at (../../../../.svelte-kit/vercel-tmp/fn/edge.js:13:7)
    at (../../../../node_modules/@hapi/iron/lib/index.js:3:15)
    at (../../../../.svelte-kit/vercel-tmp/fn/edge.js:13:7)
    at (../../../../.svelte-kit/output/server/chunks/hooks.server.js:1:17)
    at (../../../../.svelte-kit/vercel-tmp/fn/edge.js:13:7)
    at (../../../../.svelte-kit/output/server/chunks/internal.js:176:9)
    at (../../../../.svelte-kit/output/server/index.js:2689:23)
    at (../../../../.svelte-kit/vercel-tmp/fn/edge.js:14:1)

### System Info

```Shell
Chrome Version 113.0.5672.134 (Official Build) (64-bit)

Severity
serious, but I can work around it
Additional Information
My app is up and fully functional without the use of edge functions, however, I would love to be able to leverage edge functions for our app.

Iron is trying to use node's crypto module, which vercel doesn't seem to support. They also mention (as you have run into) you can't call require.
You may have to polyfill node:crypto here or switch to a different library - I am not sure

I am going to try using js-cookie and crypto-js and see if I can get a working version. Let me know if anyone recommends another alternative to @hapi/iron for encrypting and decrypting cookies. I'll report back.

Replacing @hapi/iron seems to have done the trick. Thanks, @ghostdevv! Much easier than I expected.


Add useFlowControl option

Fixes #511

Out of curiosity, what was the reason to disable flow control by default?

Found the answer in #511, seems reasonable.


Fine grained masking global configuration

What does this PR do?
Fine grained masking global configuration. This includes:
• Start/Stop/StartRecordingImmediately apis
• ImagePrivacy
• TouchPrivacy
• TextAndInputPrivacy
• Fix for placeholder dimensions
• Deprecation of legacy privacy
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 92.82511% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (87ac85e) to head (630d35c).
Report is 20 commits behind head on develop.

Files with missing lines
Patch %
Lines

...com/datadog/android/sessionreplay/SessionReplay.kt
28.57%
2 Missing and 8 partials :warning:

...oid/sessionreplay/internal/SessionReplayFeature.kt
96.83%
0 Missing and 2 partials :warning:

...lin/com/datadog/android/webview/WebViewTracking.kt
89.47%
0 Missing and 2 partials :warning:

...internal/recorder/DefaultOnDrawListenerProducer.kt
0.00%
1 Missing :warning:

...internal/recorder/mapper/SeekBarWireframeMapper.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2254      +/-   ##
===========================================
- Coverage    70.12%   70.03%   -0.09%
===========================================
  Files          727      729       +2
  Lines        27052    27161     +109
  Branches      4558     4586      +28
===========================================
+ Hits         18970    19022      +52
- Misses        6818     6848      +30
- Partials      1264     1291      +27

Files with missing lines
Coverage Δ

...ndroid/telemetry/internal/TelemetryEventHandler.kt
82.73% <100.00%> (-1.31%)
:arrow_down:

...nreplay/material/internal/SliderWireframeMapper.kt
97.40% <100.00%> (ø)

...ndroid/sessionreplay/SessionReplayConfiguration.kt
100.00% <100.00%> (ø)

...tadog/android/sessionreplay/TextAndInputPrivacy.kt
100.00% <100.00%> (ø)

.../com/datadog/android/sessionreplay/TouchPrivacy.kt
100.00% <100.00%> (ø)

.../sessionreplay/internal/DefaultRecorderProvider.kt
93.44% <100.00%> (+0.11%)
:arrow_up:

...nreplay/internal/recorder/SessionReplayRecorder.kt
96.90% <100.00%> (+0.07%)
:arrow_up:

...essionreplay/internal/recorder/SnapshotProducer.kt
92.11% <100.00%> (ø)

...nreplay/internal/recorder/ViewOnDrawInterceptor.kt
89.19% <100.00%> (+0.30%)
:arrow_up:

...lay/internal/recorder/WindowCallbackInterceptor.kt
100.00% <100.00%> (ø)

... and 14 more

... and 23 files with indirect coverage changes


Allow using urls for navigation by exposing sidebar

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.

Contributor checklist

[ ] :tada: This PR closes #ISSUE_NUMBER.
[ ] :scroll: I have broken down my PR into the following tasks:

[ ] Task 1
[ ] Task 2

[ ] :robot: I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
[ ] :book: I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Thanks @ManInFez :tada: :+1:
I think #230 from @HansKallekleiv addresses this as well (in addition to do a related change, going away from dcc.Tabs, which gives a huge improvement wrt. initial loading time for large apps... as well as automatic urls for "page" changes). Let's keep this open some days while we see if #230 is able to reach the :goal_net:.

yes, I saw his PR. I was about to start on something similar before I saw that.

Closing after merge of #230.


HDDS-9387. [hsync] Reduce updating block length times at OM during hsync

What changes were proposed in this pull request?
Update block length at OM per block when hsync is called.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9387
How was this patch tested?
new unit tests

Thanks Sammi and Ashish!