Avoid using ruby 3.1 methods to keep gem compatible with older ruby versions

uri.origin method has been introduced to URI since ruby 3.1, see URI::HTTP ruby 3.1 vs URI::HTTP ruby 3.0
I would suggest to avoid using this method and replace it with a custom implementation to keep the gem compatible with older versions of ruby. Otherwise to set required_ruby_version in gemspec.

@alexeyschepin Good call. Thank you for catching this and putting up a PR. I've merged it and I'll push a new version in a few minutes.

@alexeyschepin Done. Please try it and let me know if it works. If so, can you also please update the activeadmin_addons PR? Thanks!

Hey @dkniffin! Thanks! I'll update my PR https://github.com/platanus/activeadmin_addons/pull/501, although the project seems to be dead.
BTW would you mind to add a new release to https://github.com/dkniffin/active_material/releases ? It might be misleading for somebody not to find new releases there.

@alexeyschepin Thanks for pointing that out! I just added all the release notes for missing versions, and I will add that to the contributing doc, so I don't miss that in the future.


Moved the metadata into setup.cfg

Summary
Moved the metadata into setup.cfg.
Vetsion is fetched automatically from git tags.
Details and comments
IMHO this small change doesn;t worth any mention in changelogs.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for pushing this up as I said on your other PRs I like the idea of using configuration files to define metadata and moving logic out of the setup.py. But I'm closing this based on this comment: https://github.com/Qiskit/qiskit-aer/pull/800#issuecomment-647780875
If someone would like to pick this up they have the author's permission to create a new PR with the same changes. But, unfortunately signing the CLA is a requirement for contribution to Qiskit (which wasn't my decision) but as long as that requirement exists we can't merge this unless the CLA is signed by the commit author. So I'm going to close this for now.


Added error code to Deployment Script error table

I am implementing deployment scripts at a client and stumbled upon the error code DeploymentScriptExistingStorageNotInSameSubscriptionAsDeploymentScript with the message The existing storage provided in deployment is not found in the subscription where the script is being deployed.. Was not in present is the list, so added it.

Learn Build status updates of commit 7a80666:
⚠ Validation status: warnings
File	Status	Preview URL	Details
articles/synapse-analytics/sql-data-warehouse/quickstart-arm-template.md	⚠Warning		Details
articles/azure-resource-manager/bicep/deployment-script-bicep.md	✅Succeeded
articles/synapse-analytics/sql-data-warehouse/quickstart-arm-template.md

Line 32, Column 1: [Warning: invalid-code] The code snippet "~/quickstart-templates/quickstarts/microsoft.sql/sql-data-warehouse-transparent-encryption-create/azuredeploy.json" could not be found.

For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Is there something required from my side? @mumian @ShannonLeavitt

@johnlokerse - I tried closing/reopening your PR to clear the warning, and more showed up! They aren't caused by the changes you made, so after @mumian reviews your changes and approves/signs off, we can try another close/reopen to clear those warnings.

Confirm the information with Lei.
#sign-off


fix: read and apply per target Cxx settings and consolidate private includes

Read and apply Cxx settings for Swift package targets.
Consolidate the list of private includes for clang targets to smallest possible number by removing those with a common parent leaving the shortest of the common parent paths.
Add GEOSwift package to the interesting_deps example.

Closes #674.

cc: @AttilaTheFun

Thanks @cgrindel ! I verified that the GEOSwift targets build with:
git_override(
    module_name = "rules_swift_package_manager",
    commit = "b6b73e44e094b5c4d6cfc2f54d9aa9dc90182e93",
    remote = "https://github.com/cgrindel/rules_swift_package_manager",
)


fix: prefix all css variable names

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.19%. Comparing base (e6397df) to head (6a7e41f).
Report is 7 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   93.18%   93.19%
=======================================
  Files         316      316
  Lines       25389    25403   +14
  Branches     2063     2063
=======================================
+ Hits        23660    23674   +14
  Misses       1696     1696
  Partials       33       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


{handler} and {project} not working in Reminder textarea

Hi,

The tag {project}  it does not show the current project but it is showing  All Projects

The tag {handler} not working as expected, the tag as it is printed in a textbox.

Note: In Note, Description, Steps To Reproduce, Additional Information is working fine as expected but only in Reminder isn't working.
Kindly refer the below-attached screenshot

Hello dregad,
We have same problem. When you think publish 2.2.6 ?
We need this so much.
Thank you

There are in fact 2 distinct issues here.
The main problem is that the plugin is not retrieving the bug_id from the Send Reminders form, causing the placeholders to be replaced by a default value instead of the expected one.

The tag {project} it does not show the current project but it is showing All Projects

For the record, it actually does show the current project (when no bug_id is passed to the Snippet::patterns() method, the code calls helper_get_current_project()), but that may not match the project of the issue being displayed.
Fixing this requires updating the JavaScript, so the bug_id is retrieved from the page.

The tag {handler} not working as expected, the tag as it is printed in a textbox.

In addition to the root cause explained above, there is an additional problem, as the placeholder is left as-is if the Issue is unassigned. This affects other Snippets locations, not just the Reminders page. I'll open a separate issue to track this.


On windows:  Editor crashes and can't be opened after installing Arcadia develop branch

reproduce
windows 10, Unity 5.3.5f1
create new project, 3d.
Enable Run in Background
.NET 2.0
cd path/to/assets
git clone arcadia
cd assets
git checkout develop
return to editor.  Import is displayed, shows Arcadia Started!
attempt to exit the editor via x in upper right.
Editor crashes.
Kill process, attempt to reopen unity and reselect project.  project selection window closes, nothing opens.
reopen unity, reselect project.  Error displayed that the project is already open.
kill that process manually, reselect project, again project select closes and the project view does not open.

Very odd. Can you attach your log file?

Okay, first the log up to the crash... I'm looking at it and dont see any errors - possibly because I had to kill the process, which prevented it from successfully appending the crash data to the log?
Editor-crash.txt

Okay, then if I attempt to display the project again, the project select panel disappears, but the project window isnt loaded:
Project-Wont-Display.txt

Then if I try to re-open unity and re-select the project, it throws an error saying i cant open the project twice:
attempt-to-re-load-project.txt

At the suggestion of selfsame, I tried removing the Arcadia directory and reloading the project in order to load into the editor.  didnt work  -- it still only loaded into a background process.  here's the log:
arcadia-removed-still-wont-load-editor.txt

unsuccessful-loading-existing-project-without-repl-start.txt

now attempting to remove repl initialization from startup.

success!
successfully-started-project-when-repl-never-started.txt

just to clarify a few things:

With no code change, if I stop the REPL before exiting the editor, the editor does not crash.  However, the project will still be loaded in the background only if I try to reopen it -- no editor window is displayed

the problem (project not loading) was not present if I comment out StartREPL() before I ever import arcadia.

The problem is present if I comment out StartREPL() after the Arcadia is imported the first time

via @worrel with procmon
https://www.dropbox.com/s/c7pz46yjpi7pblr/unity-wait-chain-on-freeze.PNG?dl=0

Excellent detective work everyone! This confirms that this is a REPL closure issue on Windows. I will revisit our REPL teardown code and push out a fix as soon as I can.

on the contrary this issue is caused by the repl socket being opened in initialization.cs too early which somehow blocks the unity editor from loading in windows 10, issue #157 has similar symptoms and is caused by the socket being closed before the editor quits -  thanks!

OK – thanks for the clarification. I will really need a Windows machine to look into this. I have a Windows 7 rig in the lab that I will dual boot to Windows 10 when I get back.
In the meantime, how about replacing arcadia.repl/start-server with this:
(defn start-server [^long port]
  (if @server-running
    (Debug/Log "REPL already running")
    (Debug/Log "Starting REPL"))
  (when-not @server-running
    (reset! server-running true)
    (let [socket (UdpClient. (IPEndPoint. IPAddress/Any port))]
      (set! (.. socket Client SendBufferSize) (* 1024 5000)) ;; 5Mb
      (set! (.. socket Client ReceiveBufferSize) (* 1024 5000)) ;; 5Mb
      (.Start (Thread. (gen-delegate ThreadStart []
                                     (Thread/Sleep 5000)
                                     (if (@configuration :verbose)
                                       (Debug/Log "Starting REPL..."))
                                     (while @server-running
                                       (listen-and-block socket))
                                     ;; TODO why does this line not execute?
                                     (if (@configuration :verbose)
                                       (Debug/Log "REPL Stopped")))))
      socket)))

The Thread/Sleep line is the new one. Would that simulate the REPL starting "later", do you think?

@nasser that Sleep did the trick! (at 5000 & 1000, though not 100)

I should add that attempting to exit Unity after successfully loading an Arcadia project, connecting the REPL & successfully doing a (create-primitive) call caused Unity to hang.  I think @Mechrophile mentioned this somewhere (have to stop REPL before quitting)

Thanks @worrel! OK, so this is some kind of timing bug with opening the socket "too soon". That kind of stuff makes me nervous. I will look into it as soon as I get the chance. In the meantime, sleep the REPL on startup as above and stop the REPL before quitting Unity to dodge #157. Not great, but at least there are workarounds in place until we get real fixes in.

this bug reproduces in Windows 7 with Unity 5.4.03f (it's not just a windows 10 thing)


Cross-lingual

Hello, I used the checkpoint file you trained with librispeech to infer the Chinese audio and it still works well. Is that what you expected? Because your dataset doesn't seem to use Chinese, only English data.

I'm the same


adding django-extensions as dependency

Was just trying out your library, and after following the "getting started" docs, I got this error:
`Unhandled exception in thread started by <function check_errors..wrapper at 0x107afd6a8>
Traceback (most recent call last):
File "/redacted/python3.5/site-packages/organizations/fields.py", line 78, in
BaseSlugField = getattr(import_module(module), klass)
File "/redacted/python3.5/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 944, in _find_and_load_unlocked
File "", line 222, in _call_with_frames_removed
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 944, in _find_and_load_unlocked
File "", line 222, in _call_with_frames_removed
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 956, in _find_and_load_unlocked
ImportError: No module named 'django_extensions'
During handling of the above exception, another exception occurred:`

Thanks Justin - I think this calls for more improvement to the docs and perhaps a better warning system, rather than adding django-extensions back to the project as a dependency. It was originally required as you've added it, but was removed b/c it's not, strictly speaking, required (even though it's the default!).
Adding a message to the docs and/or a better warning that the backing slugifer dependency must be installed would be a fantastic improvement though... 👀

Makes perfect sense, thanks @bennylope


Expose combine_with option in multilineConfig section

Is your feature request related to a problem? Please describe.
When using multilineConfig in the helm chart, it defaults to using the filelog operator default option for combinie_with which is \n
This can cause extra whitespace/lines to be rendered in the Splunk back end, where what I actually want for some recombined logs is to set combine_with to ""

Describe the solution you'd like
Expose the option for combine_with in the multiline_config section.
Describe alternatives you've considered
To workaround this, I would have to grab the rendered router and recombine operators from the config map and move them to the extraOperators section in the helm chart instead.
Additional context
We had a similar experience in Splunk Connect for Kubernetes, and eventually exposed more of the concat plugin features to control these things in the helm chart as well.
https://github.com/splunk/splunk-connect-for-kubernetes/blob/a65f108f0e41b6ababf811be9217ae10f0f079ba/helm-chart/splunk-connect-for-kubernetes/values.yaml#L266

bump...
Ran into another situation where exposing max_batch_size of the filelog operator would have been much easier exposed as a part of the multilineConfig section, kinda like we did with the max_log_size

Still want this..


PodVolumes backed up restic not restored during backup

I'm trying to migrate workload between OKD 4.5 with OADP Operator 0.2.3 and OKD 4.7 with OADP Operator 0.2.6.
The command I'm using to restore is:
velero restore create --from-backup daily-backup-20210730115427 --include-namespaces build-infrastructure --restore-volumes

The setup in the 4.7 instance recognizes the backup and podvolumebackups correctly. Here is the description of the backup I'm trying to restore:
Name:         daily-backup-20210730115427
Namespace:    oadp-operator
Labels:       app.kubernetes.io/instance=oadp-operator-dev
              velero.io/schedule-name=daily-backup
              velero.io/storage-location=default
Annotations:  kubectl.kubernetes.io/last-applied-configuration={"apiVersion":"velero.io/v1","kind":"Schedule","metadata":{"annotations":{},"labels":{"app.kubernetes.io/instance":"oadp-operator-dev"},"name":"daily-backup","namespace":"oadp-operator"},"spec":{"schedule":"0 3 * * *","template":{"defaultVolumesToRestic":true,"excludedResources":["storageclasses.storage.k8s.io"],"includeClusterResources":false,"includedNamespaces":["build-infrastructure"],"includedResources":["*"],"ttl":"168h0m0s"}}}

  velero.io/source-cluster-k8s-gitversion=v1.18.3
  velero.io/source-cluster-k8s-major-version=1
  velero.io/source-cluster-k8s-minor-version=18+

Phase:  Completed

Errors:    0
Warnings:  0

Namespaces:
  Included:  build-infrastructure
  Excluded:  <none>

Resources:
  Included:        *
  Excluded:        storageclasses.storage.k8s.io
  Cluster-scoped:  included

Label selector:  <none>

Storage Location:  default

Velero-Native Snapshot PVs:  auto

TTL:  168h0m0s

Hooks:  <none>

Backup Format Version:  1.1.0

Started:    2021-07-30 11:54:27 +0200 CEST
Completed:  2021-07-30 12:15:19 +0200 CEST

Expiration:  2021-08-06 11:54:27 +0200 CEST

Total items to be backed up:  3905
Items backed up:              3905

Resource List:
  ... heavily redacted ...

  v1/Pod:
    - build-infrastructure/jenkins-0
    - build-infrastructure/test-pod

   ... heavily redacted ...

Velero-Native Snapshots: <none included>

Restic Backups:
  Completed:
    build-infrastructure/jenkins-0: jenkins-home, plugin-dir, plugins, sc-config-volume
    build-infrastructure/test-pod: data

test-pod has no owner references and is correctly restored. jenkins-0 belongs to a stateful set and is not restored. There are podvolumebackups that correspond to those pods and to the backup.
During backup I can see this message in the log:
time="2021-07-30T11:53:50Z" level=info msg="[pod-restore] Entering Pod restore plugin" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:34" pluginName=velero-plugins restore=oadp-operator/daily-backup-20210730115427-20210730135333
time="2021-07-30T11:53:50Z" level=info msg="[pod-restore] pod: jenkins-0" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:39" pluginName=velero-plugins restore=oadp-operator/daily-backup-20210730115427-20210730135333
time="2021-07-30T11:53:50Z" level=info msg="[pod-restore] skipping restore of pod jenkins-0, has owner references and no restic backup" cmd=/plugins/velero-plugins logSource="/opt/app-root/src/github.com/konveyor/openshift-velero-plugin/velero-plugins/pod/restore.go:55" pluginName=velero-plugins restore=oadp-operator/daily-backup-20210730115427-20210730135333

The pod has an owner reference, but also has a restic backup. Why is this backup skipped? What annotation is necessary here? I'm using defaultVolumesToRestic and pods should not need to be annotated to be included in a backup or restore.

OK, I think this #74. IMO the problem is not upstream but in the velero-openshift-plugin. It relies on the velero backup annotation, which is not present with defaultVolumesToRestic.

I can confirm that adding the unnecessary annotation backup.velero.io/backup-volumes: 'jenkins-home,plugin-dir,plugins,sc-config-volume' to the pods triggers the restore correctly.


Add no-else return to pylintrc

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @aaltay PTAL

Coverage remained the same at 70.662% when pulling b073e664313043560e957f7e4f04ae96efa398aa on sb2nov:BEAM-1964-no-else into 8302783c3239ddcf8b5259b4aff8ee33673d02cd on apache:master.

LGTM


jsqueeze fails to minimize ExtJS

When I attempt to minify ExtJS, I receive the following invalid code:
Ext.Date=(function(){var e,t=Date,r=/(\\.)/g,l=/([gGhHisucUOPZ]|MS)/,d=/([djzmnYycU]|MS)/,s=/\\/gi,u=/\{(\d+)\}/g,o=new RegExp('\\/Date\\(([-+])?(\\d+)(?:[+-]\\d{4})?\\)\\/'),i=Ext.String.leftPad,a=['var me = this, dt, y, m, d, h, i, s, ms, o, O, z, zz, u, v, W, year, jan4, week1monday, daysInMonth, dayMatched,','def = me.defaults,','from = Ext.Number.from,','results = String(input).match(me.parseRegexes[{0}]);','if(results){','{1}','if(u != null){','v = new Date(u * 1000);','}

Firefox says: SyntaxError: unterminated string literal in colum 480.

I just tried reproducing this bug without success so far. Can you link to the original source you're squeezing? Can you try also with latest master?

I tried to minimize the file https://github.com/partkeepr/extjs6/blob/master/build/ext-all-debug.js
I will try with dev-master later.

Thanks for the link, I can reproduce the issue now

After some investigation #34 and #30 share the same root cause, and are related to #15.

Should be fixed in master, can you please confirm?

Yes, I can confirm that the issue is fixed. Thank you!

Cool


[text] TextFormat() silently fails when the formatted text is longer than MAX_TEXT_BUFFER_LENGTH

Issue description
TextFormat() silently truncates when the formatted text is longer than MAX_TEXT_BUFFER_LENGTH. I spent a long time thinking there was an issue elsewhere but TextFormat was just truncating the result and not aborting or logging a message.
Environment
macOS
Code Example
char *someReallyLongString; // must be longer than MAX_TEXT_BUFFER_LENGTH
char *result = TextFormat("File contents:\n%s", someReallyLongString);

@danielchasehooper I could be wrong, but I believe data validation is up to the user on raylib (reference https://github.com/raysan5/raylib/issues/3246#issuecomment-1682256790).

It's not a data validation issue. the parameters sending to the function were valid. The function doesn't do what it says it will do for certain inputs, and doesn't warn you when thats happening.

I don't disagree, but, IMHO, you still have to control what you're passing to the functions. If you look at other the library functions, you'll see very few of them have complete/full parameter validation.

I could be wrong, but I believe data validation is up to the user on raylib

@ubkp Yes, you are right, raylib does not consider all the possible (wrong?) use case scenarios, it would imply lots of functions review and increase in code complexity.
That was the original approach of the library that actually fit very well on the original education context to warn the students about writing valid code.
Still, in the past years many checks and validations have been added to the library, specially for memory-critic scenarios. I think in this specific case it could log some warning... but for this specific function the warning will be logged 60 times per second, that's something that I also avoid in raylib.
An easy solution I can think of is appending a "TRUNCATED" (or similar) to the input string, so the users will be aware that something happened in there.

An easy solution I can think of is appending a "TRUNCATED" (or similar) to the input string, so the users will be aware that something happened in there.

@raysan5 This would be an excellent solution.

I like that idea

So I looked into this and implementing it is rather trivial because vsnprintf() is used. vsnprintf() returns the number of chars that would have been required to make the string, so all we need to do is just compare that to MAX_TEXT_BUFFER_LENGTH and then we will know if we have overflow or not.
I just posted a PR with this fix (I tried to make sure there wasn't any weirdness this time): #3399
Using the following code:
TraceLog(LOG_INFO, TextFormat("The quick brown fox jumps over the lazy dog."));
Before the fix with a 1024 buffer generates:
\-----------------------------
INFO: The quick brown fox jumps over the lazy dog.
[Finished in 313ms]

Now if I change the MAX_TEXT_BUFFER_LENGTH to 16:
\-----------------------------
INFO: The quick brown
[Finished in 292ms]

Now using the suggested fix:
\-----------------------------
WARNING: RTEXT: TextFormat string was [TRUN]cated. If you need longer strings, please increase MAX_TEXT_BUFFER_LENGTH.
INFO: The quick[TRUN]
[Finished in 297ms]

@orcmid I agree with your concern, just modified it.

Possible Pitfall: If TextFormat() accepts and possibly incorporates muti-byte (especially UTF8) encodings, backing up 4 characters is not necessarily the same as backing up 4 bytes.  It is then necessary to do this in a way that does not create an invalid multi-byte or UTF8 string.


Jumps on refocus when previous focus is out of view region

When working with long documents, and the user unfocuses the editor, and scroll down/up the page  such that the previous cursor is out of view, upon refocus the editor changed the scroll position.
The new cursor is in view, and is correctly placed where the user clicked, but the position on the screen is changed to either the top or the bottom.
This jump is quite confusing, and it takes a couple of seconds to reorient.
This happens for Chrome on both OSX and Windows.

Making sure the cursor is visible on focus is intentional. What would you expect it to do instead?

I expected it to not change scroll position if the cursor will be visible with current view region on focus.

But didn't you say the cursor had been scrolled out of view? How are you focusing the editor?

User is focused on the editor, and writes something.
User unfocuses editor by click off and explores the surrounding UI.
User begins to read what they have written, and scrolls down.
User spots a mistake, and want to correct it.
User click on the text where he wants to edit expecting the cursor to move into view.
User is confused because the scroll position is updated when they click even though it didn't have to.

Explanatory GIF:

(The selection is because I was click too slow, so it moved the viewport while I was pressing down the left mouse button)

Does this happen in the demos on the website as well? If I go to http://codemirror.net/mode/javascript/ , put the cursor on the first line of the editor, blur the editor, move that line out of view by scrolling down, and then click in the editor again, I simply get the cursor where I clicked, without any scroll jumping (Chrome Linux).

No. I think it's because it uses its own scroll system.

"native" is the default scrollbar style, so the demos use that too


Rework the let example to use transform(..., evaluation())

I did a bunch of work towards this, and it turns out to make the code so complicated that it no longer makes a good example.


Reconsider use of the 'from' reserved keyword

Afternoon kind folk,
I've been querying my audit-trail today to find any previous transitions to and from particular states, and I've found myself getting syntax errors because of the use of the 'from' keyword as a column name. This means that queries like this will fail:
state_transitions.where('from = ?', 'my_initial_state_name')

You then have to implement DB-Specific workarounds into the syntax to get the query running properly, in Postgres for instance, wrapping from in double quotes does the trick.
I wonder if we should consider a move away from using reserved words as database column names?

Agreed that a different name would be easier, but if you use AR syntax it just works anyway:
state_transitions.where(from: 'my_initial_state_name')

If you need to reference the column in bare SQL you can include the table it belongs to:
state_transitions.where('my_table.from LIKE ?', 'something_%')

This would be a breaking change and I'm not sure the migration pain is warranted.  If there is greater demand I'm happy to reopen this.


WIKI : Bad solution code for the "Profile lookup" challenge

Challenge Name

https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/Checkpoint-Profile-Lookup#code-solution
Issue Description

The code solution in the profile lookup challenge wiki page is wrong(I think), I added the correct code below with an explanation inside comments in front of the modified line.
Your Code
for (var x = 0; x < contacts.length; x++){
    if (contacts[x].firstName === firstName) {
        if (contacts[x].hasOwnProperty(prop)) {  //instead of contacts[x][prop] because in that case it would return the value of that prop and if that prop was e.g 0  the if statement wouldn't work has expected.
            return contacts[x][prop];
        } else {
            return "No such property";
        }
    }
}
return "No such contact";

Please open this issue in the wiki repository. Thanks.
https://github.com/freecodecamp/wiki
Happy Coding


Add PyMdown Extensions

Add PyMdown Extensions.
Project URL
https://facelessuser.github.io/pymdown-extensions/
Category
Libraries > Python
Description
PyMdown Extensions is an extensive set of extensions for the default Python Markdown rendering engine.
Why it should be included to awesome-markdown (optional)
This collection is popular in the Python ecosystem and is actively and well maintained (you can tell by the clean and precise documentation).
Checklist

[x] Only one project/change is in this pull request
[x] Addition in alphabetical order
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 7 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

62
301
https://blog.ghost.org/markdown/ redirects tohttps://ghost.org/blog/markdown/

147
301
https://notable.md/ redirects tohttp://notable.app/

169
522
https://dillinger.io/

173
Error
https://markable.in/  SSL_connect returned=1 errno=0 state=error: certificate verify failed (ok)

176
Error
https://www.tablesgenerator.com/markdown_tables  SSL_connect returned=1 errno=0 state=error: certificate verify failed (unable to get local issuer certificate)

179
Error
https://socrates.io/  SSL_connect returned=1 errno=0 state=error: certificate verify failed (self signed certificate)

200
502
https://gitprint.com/

  Generated by :no_entry_sign: Danger

Thanks again @BubuAnabelas for the quick merge! I'm pinging @facelessuser to let him know about the good news! 🎉


Better error messages in IDE

Problem
The diagnostics that users see in-editor were originally tailored for the CLI:

Specifically, the messages associated with "random.rbi" and other sub-locations could be improved significantly. These are related information attached to an error that provide additional context to the error. We control their location and their text, but not their overall presentation.
On the CLI, they look decent because the location is printed after the message. The order is reversed in-IDE.
Proposed solution
Change these messages so they are formatted differently in IDE and CLI. Make them look good in both places, but without adding a significant maintenance burden.

@jvilk-stripe Can we do something like put the CLI-prettified message directly in the hover text?
The most useful thing for me in the CLI error messages is having the actual source code that was written under that range present in the error message.

@jez The related information is plaintext, not markdown, so we can't customize its appearance. I have a feeling it would look very ugly / wall-of-text like. I'm willing to see what it looks like before making a final judgement, though.


tweaking gitignore to cover windows bin files

post composer install, we get several .bat files on windows.
$ git status
On branch develop
Your branch is up-to-date with 'origin/develop'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        bin/behat.bat
        bin/jsonlint.bat
        bin/phpcs.bat
        bin/phpunit.bat
        bin/validate-json.bat

this otherwise-pointless patch results in both types of files being safely ignored.
$ git status
On branch gitignore-windows
nothing to commit, working tree clean

Thanks!

you're welcome :)


It doesn't work,if i call othen method Under the showState Until the method is executed

and i use
new Future.delayed(new Duration(seconds: 1), () {
     //call othen methond
      });

the circle Stop turning, how can i use this？
@mmcc007

Run the example app to see a modal_progress_hud in action.
git clone https://github.com/mmcc007/modal_progress_hud.git
cd modal_progress_hud/example
flutter run

Review the example code and see if this helps.
https://github.com/mmcc007/modal_progress_hud/blob/master/example/lib/main.dart


Run AQA Workflow: Implement build-jdk sdk_resource, Remove redundant checkouts

This PR builds on top of #170: Run AQA (Comment-Triggered PR Build) workflow

Change the Echo parameters step to simply echo the entire JSON of build parameters instead of each individual value in addition to it.

Reduce redundant checkouts by using the fact that the current repo is the TKG repo. This also removes the need to modify the TKG checkout action to test changes to runAqaArgParse.py.

Implement a new sdk_resource build-jdk which uses the AdoptOpenJDK/build-jdk action to build a JDK using a provided openjdk-build repo.

This functionality was requested in issue https://github.com/AdoptOpenJDK/openjdk-tests/issues/2296 but was blocked due to issue https://github.com/AdoptOpenJDK/build-jdk/issues/24 which is still unresolved, but has a (unintended?) workaround that works due to the usePRRef input not causing the action to pull from the PR ref but instead have the action use whatever existing openjdk-build directory is in the workspace (if any).
The same workaround does not work for the eclipse-openj9/build-openj9 action because its similarly-named usePersonalRepo input does checkout the PR ref and also does not accept a custom repo and branch input (https://github.com/eclipse-openj9/build-openj9/issues/18), so the action would need to be rewritten.
Example run: 734853617

@renfeiw or @sophia-guo can either of you view this PR? Thanks

Implement a new sdk_resource build-jdk which uses the AdoptOpenJDK/build-jdk action to build a JDK using a provided openjdk-build repo.

The new added sdk_resource enabled to build a JDK using a provided openjdk-build repo. However the JDK isn't setup as TEST_JDK_HOME and used by run-aqa https://github.com/Icohedron/TKG/blob/d39cb9dab495526fd0eeb1ad6c8e9c2b2aaa81e4/.github/workflows/runAqa.yml#L151. The example of run-aqa use a upstream build jdk:
https://github.com/adoptium/run-aqa
    - name: AQA
      uses: AdoptOpenJDK/run-aqa@v1
      env:
         TEST_JDK_HOME: ${{ steps.buildOpenj9.outputs.BuildOpenJ9JDK }}
      with:
        build_list: 'openjdk'
        target: '_jdk_math'


packunused thinks base is redundant

If a package doesn't explicitly import any functions from Prelude, then packunused will claim that a dependency on base is redundant. For example,

> cabal get hello
> cd hello-<IP_ADDRESS>/
> cabal sandbox init
> cabal configure -O0 --disable-library-profiling
> cabal build --ghc-option=-ddump-minimal-imports
> packunused
detected package components
~~~~~~~~~~~~~~~~~~~~~~~~~~~

 - executable(s): hello

(component names suffixed with '*' are not configured to be built)

executable(hello)
~~~~~~~~~~~~~~~~~

The following package dependencies seem redundant:

 - base-<IP_ADDRESS>-1a55ebc8256b39ccbff004d48b3eb834

Of course, removing base from the build-depends field of hello.cabal will reveal that it is not redundant:
> cabal install -j1
Resolving dependencies...
Configuring hello-<IP_ADDRESS>...
Building hello-<IP_ADDRESS>...
Preprocessing executable 'hello' for hello-<IP_ADDRESS>...

src/hello.hs:1:1:
    Could not find module ‘Prelude’
    It is a member of the hidden package ‘base’.
    Perhaps you need to add ‘base’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘haskell98-<IP_ADDRESS>’.
    Perhaps you need to add ‘haskell98’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘haskell2010-<IP_ADDRESS>’.
    Perhaps you need to add ‘haskell2010’ to the build-depends in your .cabal file.
    Use -v to see a list of the files searched for.
Failed to install hello-<IP_ADDRESS>
cabal: Error: some packages failed to install:
hello-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1

Closing stale issue.


Release @google-cloud/pubsub v0.28.1

This pull request was generated using releasetool.

Release is at https://github.com/googleapis/nodejs-pubsub/releases/tag/v0.28.1

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


Adjust list scroll position when navigating with keyboard

With a max height on the list, need to auto adjust the scroll position when navigating with the keyboard or you will lose the selector.

Implemented in https://github.com/timberio/react-query-assist/pull/16.


Container: allow make() with unnamed parameters

Currently, when passing parameters to Container::make, they are required to be named (eg app()->make(SomeClass::class, ['parameterName' => $parameterValue]). This PR incldues 2 small changes to allow parameters to be unnamed (eg app()->make(SomeClass::class, [$parameterValue]). This is done by using the getPosition() method of ReflectionParameter. A test has been added to confirm this behavior, and all tests in the framework are passing. (Note: I did not run the Redis tests, as I don't have that installed.) Because the Container has thus-far required named parameters, this should be fully backwards compatible.
This is my first PR to such a large project, and I would appreciate any feedback or critiques you may have.
Thank you all for this wonderful framework, and thank you for considering this PR.
Why
I recently found myself wondering, "Functions and methods don't require me to pass them the names of their parameters, does the Container really need them?" Often, the explicitness of using named parameters is nice, but sometimes it feels cumbersome and unnecessary. This is especially true when refactoring existing uses of new to use the container, as I was recently doing.
Refactoring this:
$adapter = new WebsiteItemAdapter($branch, array_except($item, ['sizes']));
$model = $adapter->asModel();

to this:
$model = app()->make(WebsiteItemAdapter::class, [$this->branch, array_except($this->item, ['sizes'])])
              ->asModel();

is convenient and straightforward, and doesn't require tracking down the names of the constructor parameters.
How
The Container uses ReflectionParameter to get the name of the parameter, and check for it's existence in the array of parameter overrides. With this PR, if the parameters don't contain a key that matches name, we also check to see if they contain a key for ReflectionParameter::getPosition(). Because PHP doesn't allow method or function parameters to have numeric names (at least as far as I can tell, though I can't find the docs), then it should be impossible for this logic to confuse a named parameter with a "positional" parameter.
Notes/Caveats
This is meant to address/handle a simple, and presumably common use case: passing a full list of parameters. If we start omitting parameters, or naming some parameters but not others, then I have assumed that the user has left behind the "simple" use case. (Note: default parameters work as expected if omitted.) As such, I have done nothing special to handle cases like arrays of the form ['value1', 'key2' => 'value2', 'value3'] or when passing partial parameter lists that rely on implicit type resolution. For example, from the tests:
class ContainerDefaultValueStub
{
    public $stub;
    public $default;

    public function __construct(ContainerConcreteStub $stub, $default = 'taylor')
    {
        $this->stub = $stub;
        $this->default = $default;
    }
}

// Works
$container = new Container;
$instance = $container->make(ContainerDefaultValueStub::class, ['default' => 'adam']);

// Does not work, because 'adam' will be used as argument 0, but is not an instance of ContainerConcreteStub
$instance = $container->make(ContainerDefaultValueStub::class, ['adam']);

These cases aren't defects, they're just not "simple", and passing the parameters with names will continue to work as expected in all cases.
Examples
From the docs:
$api = $this->app->makeWith('HelpSpot\API', ['id' => 1]);

With this PR, this could be written as:
$api = $this->app->makeWith('HelpSpot\API', [1]);

From the tests:
$instance = $container->make(ContainerConstructorParameterLoggingStub::class, ['first' => 'adam', 'second' => 'taylor']);

With this PR, this could be written as:
$instance = $container->make(ContainerConstructorParameterLoggingStub::class, ['adam', 'taylor']);

This looks like a change that is done solely because we can, and not because we should. I see nothing to gain here. All examples are either satisfied with the factory pattern, or are just really bad changes that lowers the maintainability of the code.

No plans on adding.


Consider how to incorporate Backend relevant information in wider context

Problem
Currently we rely on backend to deliver information about supported opcodes, etc. This is suboptimal as

this information is not always relevant,
we may not need it in dynamic form (ie. interacting with backend)
we can deliver it through other means

Happy Case
Declare supported opcodes information in static way (ie. through Nargo.toml.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

We no longer rely on the backend to tell us the supported opcodes, going to close this unless it becomes relevant again


rdar://70975582 SwiftPM crashes when parsing XCBuild's output (v2)

The original patch missed that XCBuild still emits empty strings for the
interestingPath field. Handle this.

@swift-ci please smoke test


Forex Exchange Rates

Free Forex Providers:

https://polygon.io/:

Pricing and free offerings: https://polygon.io/pricing
Docs: https://polygon.io/docs/stocks/getting-started

https://www.alphavantage.co/:

Free api key: https://www.alphavantage.co/support/#api-key
Docs: https://www.alphavantage.co/documentation/#

https://currencylayer.com/:

Pricing and free offerings:https://apilayer.com/marketplace/currency_data-api?_gl=11v6oz1d_gaNjIwMjc5NTkzLjE2NzI3NjczMDE._ga_HGV43FGGVM*MTY3Mjc2NzMwMS4xLjEuMTY3Mjc2Nzg5Ni4xOS4wLjA.#pricing
Docs:https://currencylayer.com/documentation

@rbajollari nice! do all of these support the necessary components of our candles / tickers?
If so, it looks like implementation will be very similar, just with more rate limiting

Upon some further inspection they all have some limitations in their free verions that might not work for us. polygon.io looks like the free version only gives you end of day data instead of real-time. I also just noticed that the minimum time series for exchange rate data on the free version of alphavantage is daily, and currencylayer doesn't allow time-frame queries in general for the free version. @adamewozniak I haven't come across a forex api that will offer real-time interval data for free yet. The only real-time data thats offered for free is just the rate at a given time but that would require us to calculate stuff like open, close, high, and low prices in interval ourselves by storing prices in that interval. However, even that would probably be inaccurate since the api would have a request limit which most likely wont be grannular enough.

🤔 high LOE with largely outdated / incompatible data. Let's talk about this in our standup


Not working properly?

Not sure if I'm using this wrong or not, but I've downloaded Healer-1.1.0.jar from Releases and tried to put it in mods or in mods\1.7.10.
In both cases, running ${date:YYYY} on singleplayer prints 2021 onto the game log which is not supposed to happen.
Any idea what's going wrong?
Thanks!

Try jndi something instead. This mod does not remove all lookups. Only JNDI is removed.

I'm actually not sure how to test that but thank you for the response. Why not disable all lookups?

Sure I can clear the lookup map, but it will not help speed up the logging in any way. (Log4j will still attempt to search for ${, and if there is any, it will still step into the Interpolator code and do regex matching) That can only be achieved by using another log4j jar (this is what peterix is doing with MultiMC, as with many other launchers) Since there is no gain, I didn't bother to clear the lookup map.

Thanks for the detailed response!


The project is no longer working with the recent awesome_panel_extensions

Any ideas?
Thanks
Running with invoke site.serve triggers the following exception
ERROR:bokeh.application.application:Error running application handler <bokeh.application.handlers.script.ScriptHandler object at 0x7f4419cc9430>: 'TemplateConfig' object has no attribute 'js_files'
File "base.py", line 512, in _template_resources:
for name, js in self.config.js_files.items(): Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/bokeh/application/handlers/code_runner.py", line 197, in run
    exec(self._code, module.__dict__)
  File "/home/meir/web-dashboard/awesome-analytics-apps-template/src/apps/home/app.py", line 31, in <module>
    view().servable()
  File "/usr/local/lib/python3.8/dist-packages/panel/viewable.py", line 315, in servable
    self.server_doc(title=title, location=True)
  File "/usr/local/lib/python3.8/dist-packages/panel/template/base.py", line 292, in server_doc
    return self._init_doc(doc, title=title, location=location)
  File "/usr/local/lib/python3.8/dist-packages/panel/template/base.py", line 464, in _init_doc
    self._update_vars()
  File "/usr/local/lib/python3.8/dist-packages/panel/template/base.py", line 613, in _update_vars
    self._render_variables['template_resources'] = self._template_resources()
  File "/usr/local/lib/python3.8/dist-packages/panel/template/base.py", line 512, in _template_resources
    for name, js in self.config.js_files.items():
AttributeError: 'TemplateConfig' object has no attribute 'js_files'

@cloud-rocket I think the template used in the example is not correct. You should change the ListTemplate to GalleryTemplate
I have proposed a PR here. I would open a PR but I do not think I have the requested credentials.


web public path is not working in .scss background image url

Versions
Angular CLI: 1.7.3
Node: 8.10.0
OS: macOS High Sierra
Angular: 5.2.7
Repro steps
In my pollyfils.ts file I have this code:
import '../web-config-code';

Inside web-config-code.ts I modify in runtime the web public path variable:
__webpack_require__.p = newUrlValue;

And I have in a .scss file this class:
.className {
    background: url(../../../dir1/dir2/images/imageName.jpg) no-repeat;
}

The project compiles without any issue, the bundle files are using the newUrlValue assigned to webpack_require.p.
When is the turn to render the background image from the scss file, the url that is using is not the newUrlValue.
I was using @angular/cli version 1.6.7 and everything was working fine, now if I update to any other version 1.7.x, then the image error appears, if I rollback to version 1.6.7 everything is working great.
I tested using others versions of node, is not that I think.
Is something different in the way that urls are being compiled in this new versions? Something has changed with the way the web public path is used? What is the difference between versions?

The use of webpack is considered an internal implementation detail of the CLI.  Assuming that webpack is used or that files are processed by it will generally lead to an eventual breakage of the application.
For a case such as, changing the base HREF of the page would be a standardized method for adjusting the retrieval location of page resources.  This can be used in combination with the Angular APP_BASE_HREF token (doc) if the Angular routing root would be different than the modified base HREF.

@clydin  I'm not quite sure of understand your answer. But can you help to understand at least why the above code that I'm using works just fine with @angular/cli 1.6.7 and webpack 3.10.0 but is not working if I only update to angular/cli 1.7.2 for example? btw, the version of webpack now is 3.11.0


OSSMC graph does not work locally

Describe the bug
OSSMC graph does not work locally, throwing following error message:
main-chunk-ab2caeaac4b7213d2269.min.js:1 unhandled error: Uncaught Error: [mobx] There are multiple, different versions of MobX active. Make sure MobX is loaded only once or use `configure({ isolateGlobalState: true })` Error: [mobx] There are multiple, different versions of MobX active. Make sure MobX is loaded only once or use `configure({ isolateGlobalState: true })`
    at invariant (http://localhost:9000/api/plugins/ossmconsole/vendors-node_modules_patternfly_react-charts_dist_esm_components_ChartBar_ChartBar_js-node_mo-e96a7b-chunk.js:102016:15)
    at fail (http://localhost:9000/api/plugins/ossmconsole/vendors-node_modules_patternfly_react-charts_dist_esm_components_ChartBar_ChartBar_js-node_mo-e96a7b-chunk.js:102011:5)
    at http://localhost:9000/api/plugins/ossmconsole/vendors-node_modules_patternfly_react-charts_dist_esm_components_ChartBar_ChartBar_js-node_mo-e96a7b-chunk.js:103490:17 Error: [mobx] There are multiple, different versions of MobX active. Make sure MobX is loaded only once or use `configure({ isolateGlobalState: true })`
    at invariant (mobx.module.js:16:1)
    at fail (mobx.module.js:11:1)
    at mobx.module.js:1490:1

OSSMC works fine when it is installed through operator, so it only affects local development (it seems something related to patternfly...)

Fixed via #232


New WorkFlow, Add slash command Insert week number link

Insert the week number for this week
Enable the reference by the link for weekly review

/Insert week number link
like [[2023-W32]]


Tree fluid extractor requires wooden log to be placed vertically

Industrial Foregoing Version: 1.10.3
TeslaCoreLib Version: 1.12.2-1.0.14
Crashlog (If Any): -
When a wooden log is placed in front of a tree fluid extractor, to extract latex the log needs to be placed vertically (as in most trees), when placed in any other direction, the tree fluid extractor does not work.
Not sure if it is a feature or a bug, yet most block placers from other mods happen to place blocks in different directions (actually additions placer, refined storage constructor, ..) without a configuration option. For them to place to log in the correct direction, an unintuitive placement is required.
I would like to request either a change to the functionality, or a change to the in-game manual for the machine, to include clear statement about this requirement for the log rotation. It is pretty hard to find out the cause of the problem, took me a while.
Thanks.

Update the mod


[CP] Fix VM crash due to incorrect flowgraph float representation (JIT/debug configurations)

Commit(s) to merge
ff2d661d5ba07766fc27196e98df6c6ae80444b9
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/279917
Issue Description
Mixed use of double and float calculation could cause to VM crash in debug/jit configuration.
What is the fix
The fix ensures correct (float) representation for phi-instructions, fixing the crash.
Why cherry-pick
Flutter and dart users are affected by the crash
Risk
medium
Issue link(s)
https://github.com/flutter/flutter/issues/118559, https://github.com/dart-lang/sdk/issues/50622
Extra Info
No response

@a-siva thoughts on this cherry-pick as it is a medium risk?

lgtm

@itsjustkevin and @a-siva  Can we get this in please 🙏
It's impacting a lot of people

Thanks for the cherry-pick @aam

The cherry-pick still needs to be landed by the author

@aam you are free to land the change as it has been approved!

Not sure why this is still open. Is this merged so it will land in 3.7.2?

It is merged, but the stable releases haven't been built and published yet.


Hover fix not complete?

The hover fix seems to not work with the text color. In this example both files, with and without changes.
It also seems like it the fix for the backgrown does not work with tabs colored by path or extension.

But to be honest, not sure if the update/reinstall worked propperly... cause it seems to leave some of the edited files in between. If there is a hook for disable/deleting extensions maybe the injected css files should be clean or something.

Thanks for your work!

are you still experiencing an issue with the hover ?


Contextmenu on table row

Hi is there a way we can attach context menu to the table?
I'm trying to add a dynamic context menu to the rendered table. Hope someone can help.
Thanks.

Sorry i missed the link you provided in official vue documentation, already figure it out thanks.


Just a test issue

Concrete problem to solve

THis is my comment

Closing the isue

Added ~45 label


Preference window position broken after disconnecting external monitor

How to reproduce:

With a large external monitor connected to a laptop, bring up QS preferences for the first time: window is in center of larger monitor.
Close the preferences window
Disconnect external monitor
Open QS preferences

Expected result: preferences window should be displayed in the center of the laptop screen
Actual result: prefs window appears in the top right of the laptop screen, with the title bar off the screen and therefore not draggable.
Cheers!
-Steve

Fixed by #2182. Please reopen if that's not the case !


Support NeoVim

Fixes #13, #68, #93. Punts on #100 for now since it's an orthogonal issue.
TODO:

[x] Test more thoroughly, especially how well interrupts are handled

CI failure seems unrelated. Nix is failing to build Coq 8.5


[Mod] Ven's New Parts subdirectory renaming in next version

Mod info

Mod name: Ven's New Parts
Author(s): Kerbas_ad_astra
License: CC-BY
Homepage: https://forum.kerbalspaceprogram.com/index.php?/topic/189732-19x-vens-stock-revamp-resurrected-v1151-nattering-nodes-of-negativism-02020-mar-15/
Download: https://github.com/Kerbas-ad-astra/Stock-Revamp/releases

To facilitate Module Manager patches, the subfolder containing Ven's New Parts is being renamed from "Part Bin" to "PartBin".  I believe this will require a change in the netkan file: https://github.com/KSP-CKAN/NetKAN/blob/3a59435cd45e92c8f348a3ce17c6ef8588008b64/NetKAN/VenStockRevamp-NewParts.netkan#L26.

Thanks for the heads-up. You can go ahead and upload the release, the NetKAN bot will print an error and we will make the update.

We can handle this change without having an open issue for it; closing to tidy up a bit.


User interface not working in Windows 21h2

To Reproduce

Install the app from Microsoft Store on windows 21h2
Start the app
Only side buttons are visible but not working
Unable to create or use the app
trying hotkeys also not working

Open Developer mode with Ctrl + Shift + I
The only error visible there in the Console is:
Uncaught (in promise) Error: Error invoking remote method 'userData': No handler registered for 'userData'
When clicking on the buttons no new error comes is triggered
Expected behavior
A working app
Screenshots

Desktop (please complete the following information):

OS: Windows 10 21h2
Version of sleek <IP_ADDRESS>
Source: Windows Store

Just did a small test: removed the 1.1.9 and installed version 1.1.4. And version 1.1.4 is working on the same computer

The same situation in the Windows 11 21H2 with downloaded distributive from Microsoft Store.

@comicsserg @DmDrMos sorry for checking in so late.
I only have access to a Windows 11 VM. Here I do have access to the Windows app store and I just installed the currently available sleek v1.2.7 (1.3.0 is currently in review and should be available too soon, btw).
I am able to start this release and the only issues I can see are interface problems. Two icons are missing.
But unfortunately I cannot reproduce your initial issue. Can I ask you guys to install 1.2.7 from the store and re-check it? After starting sleek, please double check in ? that 1.2.7 is installed.

@comicsserg @DmDrMos 1.3.0 should be available in the app store as well by now. Any improvements on your sides?


escaping issue in the visualization

From Rich
"You will want to check your debug statements for single quotes ( ' ).. The
rest of the details are that our simulations did run, but the visualization
couldn't display them.  There is probably an escaping issue here. "

Duplicate of #58.


treewide: support NIX_SSL_CERT_FILE as an impureEnvVar

(this is a reopened version of https://github.com/NixOS/nixpkgs/pull/271161 for technical reasons)
Description of changes
tl;dr this PR makes NIX_SSL_CERT_FILE the preferred way to control CA certificates throughout nix, by allowing it to be set as in impureEnvVar, including it in proxyImpureEnvVars, and ensuring fetchers support it.

Nix (the executable) as well as much of its packaged software respects NIX_SSL_CERT_FILE as the preferred way to specify a custom set of root certificates. Within derivations, this is typically done by the setup hook of cacert.
However, there's no way to inject this variable from outside (with impure env vars used in fetchers). This is required for most use cases of an an https proxy, as the proxy's own certificate will not likely be trusted by nix's builtin cacert package.
Functionality for injecting a custom trust store has been added to fetchgit, but because the setuphook will always override NIX_SSL_CERT_FILE, a different envvar had to be used (NIX_GIT_SSL_CAINFO). I have an open PR to add this same customisation to the go module fetcher.
However, it'd be preferable if we didn't invent a new envvar, and instead made NIX_SSL_CERT_FILE the single way to control this setting for both fetchers and nix itself.
For this to work, we need two small changes:

cacert should only set this variable if it's not already set, so that any impure version is not overwritten

this is in a setuphook so it's a mass rebuild

add "NIX_SSL_CERT_FILE" to proxyImpureEnvVars (fetcher.nix). It's not strictly a proxy-only variable, but:

this needs to be overridden for all HTTPS proxy use cases, and most things are https these days. Currently fetcher support for custom certs is patchy, because they're all doing their own thing (see below notes)
using the certificates the system has explicitly set for nix (if any) is inline with user expectations even outside proxy setups, and this only affects fixed-output derivations anyway

Various fetchers current (and updated) behaviour is oulined below:

fetchgit: previously added explicit support for NIX_GIT_SSL_CAINFO as the impure overrideable version. This is still supported, but the standard NIX_SSL_CERT_FILE now works and is preferred.
fetchurl: passes --insecure to curl for a fixed-output derivation, so I guess it doesn't need modification
fetchgomodule: previously no support for custom certs for git dependencies, now sets GIT_SSL_CAINFO to the value of NIX_SSL_CERT_FILE using whatever's provided by the user / setup hook

Looking through other fetchers, it seems most of them either have their own schemes or delegate to fetchurl. So this isn't a wide-reaching code change, but I think it's important to support NIX_SSL_CERT_FILE as an impureEnvVar, so that we don't force fetchers to invent their own envvars for this purpose.
Things done
Since this is a mass-rebuild, I tested locally by only applying these changes to the version of cacert used by fetchers. With these modifications I tested fetching over https (using custom certs) with:

fetchurl
fetchgit (over https)
go modules fetch (git https)

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@roberth would you mind taking another look at this now that I've rebased?
(I had to close the old PR which you commented on previously, https://github.com/NixOS/nixpkgs/pull/271161#issuecomment-2049183843)

Suggestions applied and rebased, thanks for the review @3noch

Rebased again. I'd love to get this PR merged if anyone knows how to get any attention to it. It's been reviewed by a few people since I raised it nearly a year ago (as #271161), but I don't know who has authority to actually merge it. It is a bulk-rebuild, but it's also pretty small and should be a no-op in the typical case of "not using an HTTPS proxy".

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4457


what is usecase for this package?

Am not sure i understand the usecase for this package
is this to let all users on an app have same API key???
what happens to x-api-key and x-secret-key combo that other apis use for user api key authentication?

what is usecase for this package?
Simple API key protection for your endpoint. This is not maintained anymore.

I don't know about x-api-key and x-secret-key you're talking about, at the time this package is written, there are no libraries for API key validation for Fiber.


[Issue] - Health Checker not recognizing Feb updates installed. reporting Exchange 2019 CU12 not current

Provide Version Number
<IP_ADDRESS>2
Describe the issue
healthchecker script does not seem to recognize the installation of the feb KBs and also reports CU12 for Exchange 2019 is not the current SU
Expected behavior
as far as i can tell CU12 is still the current release for exchange 2019 and the update history shows the kbs as being successfully installed
likewise the build version reported after installing all the Feb 2023 updates (15.02.1118.022) .doesnt match what is listed on the exchange server build numbers page (15.02.1118.025)
Script Output
If applicable, add the exception that wasn't handled.
Additional context
Add any other context about the problem here.

https://learn.microsoft.com/en-us/exchange/new-features/build-numbers-and-release-dates?view=exchserver-2019
that link says the build number should be 15.02.1118.025 not 15.02.1118.022

investigating if there is some sort of latency issue where the patch was installed by windows update tool, but everything has not yet been rebuilt and the detection by the healthchecker script doesnt yet find the updated files its looking for

i'll have to look closer at this on other systems but i forced a run of a manually downloaded version of the KB5023038 even though update history showed it installed (it was not listed as installed in the "uninstall an update" area) and although i ended up with all the exchange services disabled after the "re"-install all the bits seemed to have gotten installed and healthchecker now confirms installed
i'm gonna close this one as a possible hiccup on my part

Oddly enough I just came here to check if anyone else was seeing this exact problem. I installed the Feb 2023 SU for Exchange 2019 and have the same issue where HealthChecker doesn't recognize it.

I haven't seen the files in use issue popup but that could explain why I have a sort of half-baked installation at the moment. I grabbed the KB from Windows Catalog as a .msp file and tried that + a reboot and got the same result (not working, health checker flagged it as not installed.)
I'm giving the EXE variant a go (https://support.microsoft.com/en-us/topic/description-of-the-security-update-for-microsoft-exchange-server-2019-2016-and-2013-february-14-2023-kb5023038-2e60d338-dda3-46ed-aed1-4a8bbee87d23) for Exchange 2019 and should know shortly if that fixed it.

Finally got this fixed:

EXE version of the KB seems to have fixed the issue, I now report the correct build number:

I did have a problem where one of the services was disabled; a quick trip to services.msc and moved that from disabled to automatic and the service started right up.

No vulnerabilities detected now:

One oddity I am seeing however is that the XML size of the health checker script output is massive -- this was ~2-3MB in January's run.

And one other note is that it's not just us -- I see some reports here of the same problem: https://www.reddit.com/r/exchangeserver/comments/112bte1/released_february_2023_exchange_server_security/
Thanks for the help!

not clear to me why i've seen the KB5023038 show as installed under windows update, but not under the list of actually installed updates.
i had to manually run the KB5023038 update package on about 60% of systems and even then i often had to retry for open files mid update. its possible the open file issue is something that is impacting the updater when run in a non-interactive manner
thankfully the healthchecker flags the issue of the missing update when regular check for updates does not

Finally got this fixed:

EXE version of the KB seems to have fixed the issue, I now report the correct build number (I'm not sure why the MSP version from the Windows Catalog didn't work.):

I did have a problem where one of the services was disabled; a quick trip to services.msc and moved that from disabled to automatic and the service started right up.

No vulnerabilities detected now:

One oddity I am seeing however is that the XML size of the health checker script output is massive -- this was ~2-3MB in January's run.
And one other note is that it's not just us -- I see some reports here of the same problem: https://www.reddit.com/r/exchangeserver/comments/112bte1/released_february_2023_exchange_server_security/
Thanks for the help!

Thanks for reporting this size difference. Went back and addressed that after the recent changes. See PR #1495


Screen lock option

sorry for bad pull requsets.
#162 #163 #164 #165
we made feature that check screen lock before show token.
by time last check passed and time option(currently 10, 30, 60 sec), request screen lock pass or just show token.
user can set this function disable and also default is disable.
for manage this option, added setting activity and menu item.
we know UI design and string resource is VERY poor,
but before we change this, want to know how you think about this feature.
any suggestions are welcome.

This pull request needs to be cleaned up. It must cleanly apply to master, which it does not currently.  There should be less than 12 commits, divided logically. There must not be any merge commits in the series. Comments and commit messages need to be in English. Commit messages need to follow the rules outlined here: https://chris.beams.io/posts/git-commit/


I have a problem

Hello
so, when i tried to build game, its gave me this information:
PS C:\Users\FiFi\Desktop\modding\Kade-Engine-stable> lime test windows
C:/HaxeToolkit/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 10-23 : Warning : This typedef is deprecated in favor of haxe.xml.Access
C:/HaxeToolkit/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 30-43 : Warning : This typedef is deprecated in favor of haxe.xml.Access
source/PlayState.hx:299: characters 3-39 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
C:\Users\FiFi\Desktop\modding\Kade-Engine-stable\export\release\windows\obj>setlocal enabledelayedexpansion
Warning: Could not find Visual Studio 2017 VsDevCmd
Missing HXCPP_VARS
Error: Could not automatically setup MSVC
Can somebody tell me how to fix it? I tried to search this for like 2 days and nothing
Thanks

Are you 100% sure you have all of the Visual Studio dependencies installed?

it looks like you're missing Visual Studio 2017 VsDevCmd
what version of Visual Studio do you have installed

it looks like you're missing Visual Studio 2017 VsDevCmd
what version of Visual Studio do you have installed

2019

Are you 100% sure you have all of the Visual Studio dependencies installed?

I can not find "MSVC v142 - VS 2019 C++ x64/x86 build tools" in my Visual Studio

have you read this?

Yes, and when i go to individual components and tyle this nothing was found

Are you 100% sure you have all of the Visual Studio dependencies installed?

I searched and i can not find "MSVC v142 - VS 2019 C++ x64/x86 build tools" in my Visual Studio

doesnt have to be necesarily v142 i think? try searching just MSVC in the installer

don't we all

i also have the same problem, did someone fix it?
=(

I'm having almost the same exact issue, and even after I installed Visual Studio (with all the dependencies), it still gave me a bunch of errors. :(

try to reinstall (or add I still don't know how VS works) with these

it's the required ones of the Mic'd Up engine wich I was modding before getting onto the Kade Engine and I had no issues what so ever do try that (don't ask me why I switched from Mic'd Up to Kade Engine, it just seems more not 'overhaul' like)

comment from VMGuy23 on #835:

get this and will work

I can't find anything related to "MSVC" when I search it up on the Visual Studio 2017 installer.

try to reinstall (or add I still don't know how VS works) with these

it's the required ones of the Mic'd Up engine wich I was modding before getting onto the Kade Engine and I had no issues what so ever do try that (don't ask me why I switched from Mic'd Up to Kade Engine, it just seems more not 'overhaul' like)

thanks i found this!

I don't know how but I fix the problem. I just reinstall kade engine and then in the code window it asked me: You need to install visual studio components? And I say yes and then everything start to work. (Sorry for my bad english)


[cdc-base][hotfix] Fix TM hangs caused by uncaught exception

The executor in IncrementalSourceScanFetcher ignores the uncaught exception.
If an error like OutOfMemoryError occurs, the taskmanager hangs forever.
Closes #2510

Hi @ruanhang1993 @GOODBOY008, please help review it when you have time.


Option to configure the (Gone for: xxxx) Message

I think it would be pretty nice to be able to change the text for the message for how long a player was afk.
So maybe a option under [messageOptions] in the afkplus.toml could be possible?
Example
For me i would like to change (Gone for: xxxx) to (Abwesend für: xxxx).
Maybe it could then look something like this in the .toml
displayDuration = true
displayDurationFormat = " (Gone for: %afkplus:duration%)"
Edit:
In the same way a option for renaming the afk reason (for example timeout) would be more than great for me

The config will be slightly different; because the way the mod works, is the Time/Date and Duration handling are configured separately between the placeholders and the Message / AfkInfo fields; so in order to accomplish this and in an attempt to make the Duration and Time/Date formatting configurable; it made it a selection of multiple options; and each has an optional "format" option, with a configurable format string.
This is a complicated topic to describe; but the changes I have pending do make this a bit easier code-wise; once you have it all configured.


Creating app with bytenode and  electron-packager

Hi there,
I've successfully compiled the bytenode version of my server.js file (server.jsc) via electron and I've written the entrypoint (main.js) as follows:
const bytenode = require('bytenode'); const v8 = require('v8'); v8.setFlagsFromString('--no-lazy'); require('./server.jsc');
If I try to run electron ./main.js everything works fine but as I create the package via electron-packager, the program show me the error
Uncaught Error: Invalid or incompatible cached data (cachedDataRejected)     at Object.Module._extensions.<computed> [as .jsc]
Any suggestion?
Thank you

As you say, you need to create server.jsc using exactly the same Node.js runtime as is used by electron. I don't think there's anything the bytenode package itself can do to help you here.
@OsamaAbbas It seems like this kind of issue keeps recurring and is consuming a lot of effort. Is there a way we can improve the error messages coming out of bytenode so it makes it clearer what happened? E.g. can we prefix the output bytecode with some kind of header which indicates exactly which version+platform of Node.js, performed the compilation? Then at run time we can inspect the header, compare it with the current version+platform of Node.js, and if there is a mismatch, throw an exception stating what happened.

@s100 I install the 12.14.1 version of node with nvm. So now I have:

node version 12.14.1
electron node version 12.14.1

but nothing changed

@s100 I install the 12.14.1 version of node with nvm. So now I have:

node version 12.14.1
electron node version 12.14.1

but nothing changed

You HAVE to compile using the SAME electron executable which you will use in your final production. You can NOT use Node.js to compile .js to .jsc that will be run in Electron.
Please check our electron example to see one way of doing it. Basically, your code should have some logic that checks if some_file.jsc exists? If not, it will be generated from some_file.js on the fly. After first run of your production version, delete some_file.js and ship some_file.jsc to your users.

@OsamaAbbas It seems like this kind of issue keeps recurring and is consuming a lot of effort. Is there a way we can improve the error messages coming out of bytenode so it makes it clearer what happened? E.g. can we prefix the output bytecode with some kind of header which indicates exactly which version+platform of Node.js, performed the compilation? Then at run time we can inspect the header, compare it with the current version+platform of Node.js, and if there is a mismatch, throw an exception stating what happened.

Seems good idea, but it needs some consideration. My initial thought is that the "mismatches" can occur at many levels, not just the platform and version. We intentionally ignore or fix some of these mismatches (which I don't fully remember now!). So the whole situation needs to be re-visited again.
I'm now thinking that maybe we could change the error message in Electron and put a link to a page here that explains this error and how to fix it. This will be a lot easier than playing with file headers. What do you think?

@OsamaAbbas Ok, I thought it was sufficient to use electron instead of node to generate the .jsc file.
Anyway when I use the executable with the code to check if the jsc file is already here, it says that it cannot find the requested file to be compiled.
ENONET: no such file or directory, open './server.js'
The server.js file actually is in resources/app folder. Have I to add absolute path to it or something like that?

The server.js file actually is in resources/app folder. Is it mandatory to add absolute path to it?

I don't have your exact setup obviously, but it is not mandatory to use an absolute path. No differences between node and bytenode here. Check your setup and make sure that regular node fs functions (and require function) can find your file.
Please check the example and do something similar.

For some reason only putting the absolute path do the job.
Anyway, now everything is ok.
Thank you!


Cannot make a Computed close over an ObservableArray...

This crashes, saying something like...
Uncaught Error: cannot internalize ko.ObservableArray
type ViewModel struct {
	*js.Object
	Values   ko.ObservableArray `js:"values"`
	MaxValue ko.Computed        `js:"maxValue"`
}

// ...

	self.MaxValue = ko.NewComputed(func() interface{} {
		log.Print("MaxValue being called!")
		max := float64(0)
		log.Print("self.Values: %v", self.Values)
		for i := 0; i < self.Values.Length(); i++ {
			max = math.Max(max, self.Values.Index(i).Float())
		}
		return max
	})

I don't think you can internalize JavaScript values into Go ko.ObservableArray.
ko.ObservableArray is a Go interface. GopherJS will internalize/externalize basic types as documented here:
https://godoc.org/github.com/gopherjs/gopherjs/js
To implement ko.ObservableArray, you need to create a wrapper struct that implements that interface by using the underlying *js.Object.
That's my understanding. I don't deal a lot with interacting with JavaScript libraries, however.

https://godoc.org/github.com/gopherjs/gopherjs/js#MakeWrapper may be relevant. But I've never used it, so I can't say.

I think this problem mainly comes from interface type of Go being passed to JavaScript world.
I've modified a  KnockoutJS binding using struct instead of interface which has no such problems.
The example works
package main

import (
	"github.com/Archs/js/gopherjs-ko"
	"github.com/gopherjs/gopherjs/js"
	"math"
)

type ViewModel struct {
	*js.Object
	Values   *ko.ObservableArray `js:"values"`
	MaxValue *ko.Computed        `js:"maxValue"`
}

func New() *ViewModel {
	self := new(ViewModel)
	self.Object = js.Global.Get("Object").New()
	self.Values = ko.NewObservableArray()
	self.MaxValue = ko.NewComputed(func() interface{} {
		max := float64(0)
		for i := 0; i < self.Values.Length(); i++ {
			max = math.Max(max, self.Values.Index(i).Float())
		}
		return max
	})
	return self
}

func main() {
	vm := New()
	for i := 0; i < 100; i++ {
		vm.Values.Push(i)
	}
	println(vm.MaxValue.Get().Float())
}

This should now be resolved with #2


WIP Test a style change. DO NOT MERGE.

This change is

/retest

Replaced with https://github.com/kubeflow/website/pull/1192
/close


colordiff: 1.0.20 -> 1.0.21

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/colordiff/versions.
meta.description for colordiff is: Wrapper for 'diff' that produces the same output but with pretty 'syntax' highlighting
meta.homepage for colordiff is: https://www.colordiff.org/
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.21 with grep in /nix/store/4xzjmygg4fgyqhjx3hjx2vmfn5jhdc77-colordiff-1.0.21
found 1.0.21 in filename of file in /nix/store/4xzjmygg4fgyqhjx3hjx2vmfn5jhdc77-colordiff-1.0.21

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
colordiff
cvise
diffoscope
diffoscopeMinimal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4xzjmygg4fgyqhjx3hjx2vmfn5jhdc77-colordiff-1.0.21 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A colordiff https://github.com/r-ryantm/nixpkgs/archive/f2d6eec45e052a2d6d68aebf0d84e10325ae276b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4xzjmygg4fgyqhjx3hjx2vmfn5jhdc77-colordiff-1.0.21
ls -la /nix/store/4xzjmygg4fgyqhjx3hjx2vmfn5jhdc77-colordiff-1.0.21/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

colordiff
cvise
diffoscope
diffoscopeMinimal

Maintainer pings
cc @SuperSandro2000 for testing.

Result of nixpkgs-review pr 209925 run on x86_64-linux 1

4 packages built:

colordiff
cvise
diffoscope
diffoscopeMinimal


Make fields with defaults not required in the serialization schema by default

Closes https://github.com/pydantic/pydantic/issues/7209
Note this PR is not against the main branch, but against @Kludex's branch for fixing the JSON schema generation based on config settings as it shares some implementation
This should have tests added for the new config settings before being merged into main, but I wanted to open now to get some initial review. Reading the discussion in the issue linked above may be helpful for understanding the motivation for this change.
Selected Reviewer: @lig

please review

Assigning myself since I'm already in the loop here.


passing an absolute path to kubectl manifest

Is your feature request related to a problem?
my k8s manifests are not in the same directory as devspace.yaml.
Which solution do you suggest?
I need an option to give an absolute path to kubectl manifest directory.
/kind feature

👋 @agarwalarjun123
Unless I'm miss-understanding, this should "just work" ™ -- you should be able to provide relative or absolute paths no problem. here in the python devspace example we have a manifests dir, then in the devspace.yaml we refer to the manifests like:
deployments:
    simple-project:
      kubectl:
        manifests:
          - manifests/deployment.yaml
          - manifests/ingress.yaml
          - manifests/svc.yaml

Let us know if thats not working. If it isn't please provide a minimum reproducible example so we can understand whats going on.


$schema keyword not supported

Simple, I can't use $schema:
{
  "$id": "...",
  "$schema": "http://json-schema.org/draft/2019-09/schema#",
  "title": "Event",
  "type": "object",
  "properties": {}
}

Error:
  message: 'no schema with key or ref "http://json-schema.org/draft/2019-09/schema#"',

<EMAIL_ADDRESS>https://json-schema.org/understanding-json-schema/reference/schema.html

also "$schema": "..." gives weird errors with require

Draft 2019-09 is supported in ajv v7, you cannot use it in v6. Your specific schema should work in draft-07 though - so you need to change $schema to point to draft-07 metaschema.

@epoberezkin I'm still getting the error after updating to<EMAIL_ADDRESS>:(
$ npm list ajv

├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
And I import AJV like this:
import Ajv from 'ajv/dist/2019'
import EventSchema from 'schema/bf-tracker/event.json'

...

    const ajv = new Ajv()
    const validate = ajv.compile(EventSchema) // Error!    'no schema with key or ref "http://json-schema.org/draft/2019-09/schema#"'

  message: 'no schema with key or ref "http://json-schema.org/draft/2019-09/schema#"',
  stack: 'Error: no schema with key or ref "http://json-schema.org/draft/2019-09/schema#"\n' +
    '    at Ajv2019.validate (.../node_modules/ajv/lib/core.ts:304:21)\n' +

Found the issue
1c1
< "$schema": "http://json-schema.org/draft/2019-09/schema#",
---
> "$schema": "https://json-schema.org/draft/2019-09/schema#",

You might want to consider this a bug, as it doesn't allow the schema ref from the spec (it has http not https)

This is actually the mistake on their website - it has changed to https in draft-2019-09 - see here for example: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.10.4

There is issue + PR there:
https://github.com/json-schema-org/understanding-json-schema/issues/134
We found the culprit!


NVIDIA Jetson AGX Orin running Balena unable to detect SD Cards / USB devices

We have Balena installed on NVIDIA Jetson AGX Orin Dev Kit and it seems it is unable to detect when a USB device / SD card has been plugged in. We do not have this issue on the same device running Ubuntu instead of Balena.
Plugging in a device results in the device receiving power but not showing up anywhere on the Host OS. Here is what we have tried:
inserted sd after boot:

ran dmesg to look for corresponding messages. no changes when inserting sd card
lspci shows “SD Host controller: Genesys Logic, Inc GL9755 SD Host Controller”
lsblk -f does not show the block device

inserted sd card before boot:

same results as above

inserted same sd card into another NVIDIA Jetson Orin AGX Devkit running ubuntu not balenaOS:

sd card block device shows up as expected

similar results with USB devices:
lsusb output on Balena Orin:
Bus 004 Device 001: ID 1d6b:0003 Linux 5.14.21-yocto-standard xhci-hcd xHCI Host Controller
Bus 003 Device 001: ID 1d6b:0002 Linux 5.14.21-yocto-standard xhci-hcd xHCI Host Controller
Bus 002 Device 001: ID 1d6b:0003 Linux 5.14.21-yocto-standard xhci-hcd xHCI Host Controller
Bus 001 Device 002: ID 8087:0026
Bus 001 Device 001: ID 1d6b:0002 Linux 5.14.21-yocto-standard xhci-hcd xHCI Host Controller

lsusb output on Ubuntu Orin:
Bus 002 Device 002: ID 0bda:0420 Realtek Semiconductor Corp. 4-Port USB 3.0 Hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 004: ID 1a2c:4324 China Resource Semico Co., Ltd
Bus 001 Device 003: ID 0bda:5420 Realtek Semiconductor Corp. 4-Port USB 2.0 Hub
Bus 001 Device 002: ID 13d3:3549 IMC Networks Bluetooth Radio
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Bus 001 Device 004 is my keyboard, everything else shows by default.

Hi, just to clarify, this happens in the hostOS, right, and not in a container?
Could you also please tell me which ports you've tried? There are two near the eth port, another two near the 40 pin header and another usb-c on that same side. None of them work?

On my devkit I can use the usb ports on both sides and the sd-card reader is detected successfully from the hostOS. Maybe you are using a different type of AGX Orin module?

@acostach Thanks for the replies! I can confirm this is on the host OS. None of the ports register. Would you mind sharing your lsusb output for when you have a usb device connected?
It also would be helpful if you have any version / diagnostic info if possible :)

@treygillilansure, sure, I clean flashed the AGX Orin Devkit with v2.114.19+rev1 and the latest master of jetson-flash and here's dmesg + lsusb with a USB SD-CARD adapter: https://gist.github.com/acostach/8705f302408d798ba39a56f760f84db3
It worked fine and I could mount the contents of the stick.
Next, I plugged the sd-card from the USB SD adapter directly in the AGX Orin's sd-card slot:
root@90c1085:~# dmesg | tail
[  310.906819] mmc1: card never left busy state
[  310.906844] mmc1: error -110 whilst initialising SD card
[  311.369284] mmc1: new ultra high speed SDR104 SDHC card at address e624
[  311.370121] mmcblk1: mmc1:e624 SP32G 29.7 GiB
[  311.380432] GPT:Primary header thinks Alt. header is not at the end of the disk.
[  311.380437] GPT:5218303 != 62333951
[  311.380439] GPT:Alternate GPT header not at the end of the disk.
[  311.380440] GPT:5218303 != 62333951
[  311.380441] GPT: Use GNU Parted to correct GPT errors.
[  311.380460]  mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10

root@90c1085:~# umount /tmp/mnt/
root@90c1085:~# mount /dev/mmcblk1p9 /tmp/mnt/
root@90c1085:~# ls /tmp/mnt/
lost+found  machine-id  remove_me_to_reset  root-overlay

Is your module 32 or 64GB RAM? The module currently supported by the cloud images is the original one, with 32GB RAM

I see.. let us know if updating to the latest version solves the problem


Seus PTGI HRR 3 and 2.1 having rendering errors while using create mod  + Oculus flywheel compat

I am trying to use sues ptgi hrr 3 or 2.1 and they are having weird rendering errors, i thought that this was fixed...  if there is a way it can be fixed by a setting or using another compatibility mod let me know...  (info : Minecraft 1.20.1 forge 47.3.0, embiddium + oculus + oculus/iris flywheel compat )

Fixed in 2ae07d5.


[v3.0.0-alpha.1] Disable exporting traces by default

Description
I thought I would update my registries to the 3.0.0-alpha.1 for testing and I am seeing that it looks like the registry is trying to connect to an endpoint for tracing but I have not configured anything.
Reproduce

start a registry as a registry mirror
pull images through it and eventually you'll see messages like this:

2024/01/31 21:13:05 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:13:10 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:13:15 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:13:42 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:25:22 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:25:27 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused
2024/01/31 21:25:52 traces export: Post "https://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused

Expected behavior
I would expect that tracing is not enabled by default and is only enabled if configuration is passed.
registry version
3.0.0-alpha.1
Additional Info
Not sure if this comes from https://github.com/distribution/distribution/pull/4188 but I don't see docs that were written for that PR on the configuration.

I experience same issue with new image 3.0.0-alpha.1 Anyway I was able to turn it off by setting one of default env variable for opentelemetry -> https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/
specifically this env variable: OTEL_TRACES_EXPORTER=none

I appreciate you sharing the OpenTelemetry docs @Thumbiceq!  I saw a mention on one of the PRs about suggesting that we not use the config yaml since apparently it's standard for OpenTelemetry implementations on apps to use the env vars but hadn't looked into what it would take to explicitly disable it.

I appreciate you sharing the OpenTelemetry docs @Thumbiceq! I saw a mention on one of the PRs about suggesting that we not use the config yaml since apparently it's standard for OpenTelemetry implementations on apps to use the env vars but hadn't looked into what it would take to explicitly disable it.

@mbentley , can you please link this communication?

I would also expect the tracing to be off by default and explicitly enabled on demand via config option. By config option I mean the well-known config of the project, not and env var such as OTEL_TRACES_EXPORTER=none.
The fact that logs are spammed with
2024/02/05 13:53:18 traces export: Post "https://localhost:4318/v1/traces": dial tcp [::1]:4318: connect: connection refused

makes me think that either the default tracing thingy is wrongly configured by default or it requires additional things to make it work properly (maybe running something that serves on that port).

@gotgelf @milosgajdos could you help getting this fixed?

@mbentley , can you please link this communication?

I guess, that's it: https://github.com/distribution/distribution/pull/4184#issuecomment-1846962269.

From https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/

The goal of this specification is to unify the environment variable names between different OpenTelemetry implementations.
Implementations MAY choose to allow configuration via the environment variables in this specification, but are not required to. If they do, they SHOULD use the names listed in this document.

We are following the OpenTelemetry Environment Variable Specification to the letter. Per the spec, the distribution daemon's OpenTelemetry integration is configured using the standardized environment variables, and will by default attempt to export telemetry traces to an OTLP collector at localhost:4318. If no OTLP collector is listening, the trace data is discarded. Aside from the unexpected log messages, how are these defaults problematic? Would you be satisfied if the new behaviour was documented?

I have opened #4275 to address the issue of OpenTelemetry SDK errors not being logged in the same format as other application logs.

Just as an example, I don't see similar behavior when using BuildKit but I am not sure if it is a scenario where it is just not being logged.  I would just expect that the default configuration would default to not being configured, expecting that something like tracing should be something where it explicitly needs to be enabled.  While maybe not likely, I suppose a scenario could occur where there is a listening port host/port of <IP_ADDRESS>:4318 so it would send data without the user enabling it and being aware.  While not very likely and probabaly not very impactful, I think there is something to be said for predictable behavior when the default for many if not most people is to not need to configure OpenTelemetry.

Don't use BuildKit as an example of any OTEL best practices. It is abusing the OpenTelemetry SDK in awful ways which inflicts tremendous pain on the Moby project.

I would just expect that the default configuration would default to not being configured, expecting that something like tracing should be something where it explicitly needs to be enabled.

Someone familiar with the OpenTelemetry ecosystem might expect exporting spans to localhost:4318 using OTLP to be the default. That being said, I concede that while defaulting to tracing enabled is a reasonable default for an SDK which may be incorporated into bespoke software that is deployed only by its author, it might not be the right default for software projects such as distribution that are deployed by third parties. Neither nginx nor Envoy enable tracing by default, for example.

I would just expect that the default configuration would default to not being configured, expecting that something like tracing should be something where it explicitly needs to be enabled.

Someone familiar with the OpenTelemetry ecosystem might expect exporting spans to localhost:4318 using OTLP to be the default. That being said, I concede that while defaulting to tracing enabled is a reasonable default for an SDK which may be incorporated into bespoke software that is deployed only by its author, it might not be the right default for software projects such as distribution that are deployed by third parties. Neither nginx nor Envoy enable tracing by default, for example.

Thank you for bringing up this important consideration regarding the default configuration for tracing. It's clear that having sensible defaults that align with the expectations of both developers and third-party deployers is crucial for the usability and adoption of our software. Taking this into account, i see two potential paths to address this concern:

By Using OTEL_SDK_DISABLED (opentelemetry documentation) environment variable and setting it to true by default. During the OpenTelemetry initialization phase in the InitOpenTelemetry function within tracing.go, we would check this environment variable, and if it's set to disable the SDK, we would immediately return nil, effectively disabling the auto-exporter provided by the OpenTelemetry auto export library.
Disabling Trace Exporting by Default: Setting the OTEL_TRACES_EXPORTER environment variable to none by default would specifically stop the exporting of traces. The auto-export library would recognize this configuration and not export any traces.

Wdyt?

Environment variables are for users to configure, and are literally global variables. We shouldn't tamper with them ourselves unless we have no other choice.
I don't think we should modify the default value of OTEL_SDK_DISABLED. It's a big hammer which also disables non-tracing aspects of the OTEL SDK, such as metrics. We aren't using OTEL for metrics export yet, but if we ever start, users who set OTEL_SDK_DISABLED=0 to enable tracing would be surprised to also have metrics implicitly enabled. And I highly doubt that many environments which have OpenTelemetry environment variables set would bother setting OTEL_SDK_DISABLED=0 because that's the default.
I think that the right way to disable exporting traces by default is to disable exporting traces by default. Frustratingly, the autoexport package almost makes it possible to do that without tampering with environment variables by providing WithFallbackSpanExporter but not exporting the noopSpanExporter type to pass into the option. While it is a trivial implementation to copy, the copy would be a distinct type and therefore autoexport.IsNoneSpanExporter(noopExporterCopy{}) would incorrectly return false.
@gotgelf would you have any interest in opening a feature request or PR on opentelemetry-go-contrib to afford changing the autoexport default exporters to no-ops without having to tamper with environment variables?

@gotgelf would you have any interest in opening a feature request or PR on opentelemetry-go-contrib to afford changing the autoexport default exporters to no-ops without having to tamper with environment variables?

Yes, definitely.

Hi @corhere ,
I've opened a related issue in the opentelemetry-go-contrib repository to address the default trace exporting behavior discussed here. You can find the issue here.

Was just hit by these unexpected error messages as well:
ERRO[0010] traces export: Post "https://localhost:4318/v1/traces": dial tcp [::1]:4318: connect: connection refused  environment=testing go.version=go1.20.6 instance.id=cd11f821-b2df-42f4-ab80-982defe5456d service=registry version=v3.0.0-alpha.1.m+unknown

My config is very basic:
❯ cat ~/.config/registry/registry.yaml
version: 0.1
log:
  level: info
  fields:
    service: registry
    environment: testing
storage:
    cache:
        blobdescriptor: inmemory
    filesystem:
        rootdirectory: /var/lib/registry
http:
    addr: <IP_ADDRESS>:5500
    secret: hello
    debug:
        addr: localhost:5501

I would have expected telemetry to be opt in, or at least opt out and documented in https://distribution.github.io/distribution/about/configuration/
I'm interacting with this product (registry/distribution), so the expectation is that the behavior is configurable through the product's config. Not by having to know that the telemetry is internally implemented via a 3rd party module, that has alternate ways of configuring (environment variables).

OTEL_TRACES_EXPORTER=none registry serve ./config.yml


Migration to Temporal

Temporal finally reached Stage 3 and there's also pretty good polyfill available as npm package.
I think it would be great to migrate obsolete moment library to Temporal.

Duplicate of #208.
Temporal shouldn’t be at stage 3 yet, really, because it’s still having normative changes. When that settles down, it’ll be time to consider it.
Additionally, that polyfill isn’t anywhere near backwards compatible enough to be sufficient.