Fantasy theme

The two most common themes of RTS games are sci-if and medieval/fantasy, so it’d be nice to have an example of the latter as well. Thankfully there are some great CC0 assets available!

Main RTS pack:
https://quaternius.com/packs/ultimatefantasyrts.html
Nature assets:
https://quaternius.com/packs/ultimatestylizednature.html
Human units:
https://quaternius.com/packs/ultimatemodularcharacters.html
https://quaternius.com/packs/ultimatemodularwomen.html
Music:
https://alkakrab.itch.io/free-25-fantasy-rpg-game-tracks-no-copyright-vol-2
SFX:
https://leohpaz.itch.io/minifantasy-dungeon-sfx-pack
https://leohpaz.itch.io/minifantasy-forgotten-plains-sfx-pack

Thanks for bringing those asset links - that may be useful.
As for the themes, I think having multiple ones is out of the scope of this project - that would require a lot of work to unify units, HUD, UI, maps, music, SFX, balance etc. There's still a lot to do to fully support the current theme. Anyway, that's definitely a good idea for a fork.


Update expensify-common and remove appending the newline to the codefence content

Details

The new expensify-common includes the codefence newline as the content/children, so we don't need to append the newline manually anymore.
Related Issues

https://github.com/Expensify/App/issues/43750
Manual Tests

Local test in live-markdown example:

Type a codefence with \r\n as the newline
Verify there is no Parsing error: the processed text does not match the original Markdown input. error.

Expensify test:

Submit an expense with code block as description
Open the transaction thread
Open the description
Verify there is no Parsing error: the processed text does not match the original Markdown input. error.

cc @Skalakid

@bernhardoj I just noticed that \r\n is not supported. That's something we should fix.

Btw did you get the parsing error on main? (without the fix)

I can't get the native example app running, keep running into error, but I get the parsing error on web,
https://github.com/Expensify/react-native-live-markdown/assets/50919443/735e73af-2a45-4277-8910-9ba389216d3f
and the markdown style is also applied in web.

On web it works fine.
On native the newlines are formatted

I can finally run the examples on native by reinstalling the node_modules.

On native the newlines are formatted

I found that it's an issue on the native side itself.

Hmm, interesting I didn't caught this bug on Android, @bernhardoj can you look into this?
cc @tomekzaw

For now, E/App doesn't use backgroundColor for codeblocks so that's not an actual issue.
Another fix might be to move the start index of the codeblock to the next position so it doesn't include the newline character. This can be done on the parser/formatter side in JS.
Finally, we're working on improving the behavior of backgroundColor for inline code and codeblocks so that the whole block has a background color.


Update install-unifi.sh

No description provided.

I have made a new pull request under #211 , this is the newest Official Release from Ubiquiti. Also, the current patch that you have made for 6.0.23 does not fix dependency errors. My pulls do, just an FYI.

Thank you!


Updates MenuEntry creation for Runelite API changes.

MenuEntry was made abstract and concrete instances are made through a builder, which takes a menu entry position as a parameter for initial creation.
This still requires a version bump, but I don't know what convention you want to follow for choosing version numbers.

On some extra testing, this isn't working as expected because I haven't hooked into the new event system for clicks. This gets part of the way there, but not all the way. I'll keep working, but this isn't merge-worthy w.r.t. fixing the problem completely.

I've applied this commit https://github.com/Adam-/runelite-plugins/commit/3452f9dc16c3193f606b669e4d2489a2af56e79a and readded it to the plugin hub. Feel free to merge it and move the plugin back to here if you want.


Don't show an uncollapse button if there is no content to uncollapse

Testing #223080

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Odd spacing on bottom of modals in IE11

Odd spacing is being added to the modals in Internet Explorer 11 when adding labels and inputs enclosed in a div.  The spacing grows larger for each added block.
Code Pen Here

          aaa
          <input type="text" name="name" value="" />

If you take the enclosing div out, the spacing goes away, but blows the layout.
          aaa
          <input type="text" name="name" value="" />

This behavior does not seem to manifest in edge, chrome, or firefox.
Summary:

OS: Windows 10
Browser: Internet Explorer 11
Code Pen Here
bs-css: https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.1.1/css/bootstrap.css
bs-js: https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.1.1/js/bootstrap.min.js
jquery: https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js
popper: https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.3/esm/popper.js

I've seen this reported for selects too in modals and I have no idea what's causing it. The presence of a
 should have no impact here. This has to be something unique to IE11, but I never was able to figure out what. Regrettably, I think this is a can't fix. Please share if there's been any improvements or insights to the problem though!


Is it possible to have the road labels be rendered underneath an object placed on the map?

Currently I have a map with various objects anchored to the map, but the issue I'm having is that road labels and other related stuff are being rendered on top of my objects, I want them to be rendered under my objects. Is there a way to do this, or would I have to render my objects onto a separate canvas?

@nigelkp9 , thanks for your issue. Are these objects 3D or 2D objects? Currently there isn't a way to put 3D objects on top of the text, you can see this in MapView that we have first the call to  this.mapRenderingManager.render which renders the scene, then a few lines later we have a call to finishRenderTextElements which renders the text.
We support user text / poi elements with the addOverlayText api on the MapView. But not yet with 3D.
If you have 3D objects, what you could do is have a separate threejs scene and render it after the map has completed, you could do it like this:
        const mycustomescene = new Scene...
        const renderCustomThreeJSScene = () => {
            mapView.renderer.clearDepth();
            mapView.renderer.render(mycustomescene, mapView.camera);
        };
        mapView.addEventListener(MapViewEventNames.AfterRender, renderCustomThreeJSScene);

Does that help?

@nigelkp9 , thanks for your issue. Are these objects 3D or 2D objects? Currently there isn't a way to put 3D objects on top of the text, you can see this in MapView that we have first the call to  this.mapRenderingManager.render which renders the scene, then a few lines later we have a call to finishRenderTextElements which renders the text.
We support user text / poi elements with the addOverlayText api on the MapView. But not yet with 3D.
If you have 3D objects, what you could do is have a separate threejs scene and render it after the map has completed, you could do it like this:
        const mycustomescene = new Scene...
        const renderCustomThreeJSScene = () => {
            mapView.renderer.clearDepth();
            mapView.renderer.render(mycustomescene, mapView.camera);
        };
        mapView.addEventListener(MapViewEventNames.AfterRender, renderCustomThreeJSScene);

Does that help?

Yes, they are 3D objects. Thank you, I figured I'd have to do something like

@nigelkp9, I will close this, please reopen if you have any further questions.


[release-0.41] virt-launcher: fix UEFI-mode without secureboot

This commit fixes UEFI mode with secureboot disabled
for base images (for virt-launcher) where only OVMF_CODE.secboot.fd
is shipped, letting the combination OVMF_CODE.secboot.fd +
OVMF_VARS.fd to be used to correctly boot in EFI mode with
no secureboot.
Previously when disabling secureboot virt-launcher would only try
to use OVMF_CODE.fd + OVMF_VARS.fd resulting in a VMI failure
when the former firmware file was not shipped.
Signed-off-by: Antonio Cardace<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/retest

/retest

/retest

/lgtm

/approve

/retest

/retest

I think the errors are not related to the changes in this PR or general flakiness or the 1.18 lane, bazel fails at build time, for instance here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5971/pull-kubevirt-e2e-k8s-1.18-0.41/1435874708988891136#1:build-log.txt%3A238:
ERROR: /home/prow/go/src/github.com/kubevirt/kubevirt/pkg/virt-launcher/virtwrap/converter/BUILD.bazel:3:11: GoCompilePkg pkg/virt-launcher/virtwrap/converter/go_default_library.a failed due to Exec failed due to IOException: null

Looking at ci-search it seems that we only get this IOException: null error on 0.41 lanes: https://search.ci.kubevirt.io/?search=IOException%3A+null&maxAge=48h&context=1&type=build-log&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
On it, will post here any progress.

/hold

Hi @fgimenez! Thanks for looking into this, I'll wait for some good news :)

/test pull-kubevirt-e2e-k8s-1.18

/test pull-kubevirt-e2e-k8s-1.18-0.41

/test pull-kubevirt-e2e-k8s-1.18-0.41

/unhold
After temporarily disabling the bazel cache for 1.18-0.41 lane the build seems to be working fine https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/5971/pull-kubevirt-e2e-k8s-1.18-0.41/1435985550992478208
Somehow some of the cache entries related to the 0.41 lanes are missing in the cache, maybe there was a problem during its creation. Anyway, in the next bazel cache reset this will be fixed, for the time being this PR will persist the temporary fix https://github.com/kubevirt/project-infra/pull/1562

/retest

Looks like we need to disable the cache on all the lanes, on it

/retest

/test pull-kubevirt-e2e-k8s-1.17-rook-ceph

/test pull-kubevirt-e2e-k8s-1.17-rook-ceph-0.41

/test pull-kubevirt-e2e-k8s-1.17-rook-ceph-0.41


Fix go_to_revious typo in docs

Love the repo! Found a small typo in the docs.

Love the repo!
Thanks a lot, I really appreciate it!

Found a small typo in the docs.
And thank you for that too.

May I ask if there's anything you are missing from this plugin. Like a feature or a setting, or anything else?
I'm always curious to hear people's opinions :)


Helm operator image not using newest ubi 8 image, possibly Dependabot bug

Bug Report

What did you do?

Noticed the latest helm-operator image has 2 high security vulnerabilities https://quay.io/repository/operator-framework/helm-operator?tag=latest&tab=tags.
The latest ubi8 image is 8.3-298.1618432845 https://catalog.redhat.com/software/containers/ubi8/ubi-minimal/5c359a62bed8bd75a2c3fba8?gti-tabs=unauthenticated, but I do not think Dependabot is picking this up as the Dockerfile is still using 8.3-298 https://github.com/operator-framework/operator-sdk/blob/master/images/helm-operator/Dockerfile#L20
What did you expect to see?

Dockerfile to be using ubi8 image with tag 8.3-298.1618432845 since that fixes the vulnerabilities in 8.3-298
What did you see instead? Under which circumstances?
Dockerfile using 8.3-298 ubi8
Environment
Operator type:

/language helm
Kubernetes cluster type:

$ operator-sdk version

$ go version (if language is Go)

$ kubectl version

Possible Solution

Probably a Dependabot issue, but this could be fixed by manually opening PR to update base image for now
Additional context

Closed by #4873


Improve mobile performance

I didn't seen an issue already tracking this, so filing to make sure we don't lose track. We currently have relatively poor performance on mobile, as scored by Google:

This is hurting our SEO and ads performance.
Some specific ideas from @zchase to help move the needle here are:

Lazy load images
Take advantage of hugo's image resize api to properly size images when served on mobile
Figure out what to do with the unused css issue. We use tailwindcss library and I am assuming we have to load the entire library on each page

I'm assigning to both @cnunciato and @zchase since I'm unsure who technically owns this.

I'm going to close this out as wont-fix for now. Site performance remains around 40, and past investments to address this haven't seen meaningful improvement on moving that needle. If this ever becomes a significant issue (e.g. performance drops noticeably from our current norms) we can reopen at that time.

Please leave this one open .. you can move to asafs repo ... We ARE
tracking this
On Tue, Nov 12, 2024, 6:04 PM Troy Howard @.***> wrote:

I'm going to close this out as wont-fix for now. Site performance remains
around 40, and past investments to address this haven't seen meaningful
improvement on moving that needle. If this ever becomes a significant issue
(e.g. performance drops noticeably from our current norms) we can reopen at
that time.
—
Reply to this email directly, view it on GitHub
https://github.com/pulumi/docs/issues/11789#issuecomment-2472180663, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AB77TQT5U5QMLANNVWAFGG32AKXSJAVCNFSM6AAAAABRVLWMW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZSGE4DANRWGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Will do!


Support chef yum cookbook v3.0.4

and /etc/yum.repos.d actually does exist

I'm seeing the same issue, but /etc/yum.repos.d does not exist.  However, /etc/yum/repos.d does exist.


Update substitute.yaml to support Subaru Forester 2022 - 2023

Ran into a bug where my 2022 Subaru Forester failed to match the substitute value when checking torque params in interfaces.py/get_torque_params(). It fingerprinted with the candidate "SUBARU FORESTER 2022 - 2023" but since substitute.py only has "SUBARU FORESTER 2022" it failed to map. This fixed the issue and allowed openpilot to correctly map to the torque params. Attached is the tmux output of the error for reference.

Thanks for pointing it out, I reverted the value change in values.py


Add codeowners file

Adds the same CODEOWNERS file we're using in forms-admin and elsewhere. forms-devs will be added as the default reviewer on all PRs in this repo.

Good spot, dodgy copy-pasting on my part! Have resolved


Save API tokens and default server URL locally

Resolves #251

Thank you so much for the review @sofiaritz ! That simplified and clarified things! Let me know if my response on passing a version makes sense. Re: ayb clean, I haven't seen it in too many CLIs, but we can look out for use cases for it and add it if we encounter them. What do you think?

Thank you so much @sofiaritz! :)
I like the ayb client clean idea. A nice uninstaller for when you no longer want it! We can keep our eyes out for people who ask for it. Thank you again!


Style/SymbolArray autocorrects without respecting Style/PercentLiteralDelimiters

Style/PercentLiteralDelimiters:
  PreferredDelimiters:
    "%i": "[]"

Will autocorrect [:foo, :bar] to %i(foo bar).

Looks like the PercentLiteral mixin doesn't care for delimiter configuration at all at this point. Fixing it will likely also impact Style/WordArray (hopefully for the better.) 🙂

I'll fix this bug.


DT Add instructions on how to print to the print page

For review - still needed?  FreeBMD1 has download as a text file.  Browser based print function or keyboard selection and saving available to users.

Transferring a similar issue from systmwiee #423  to FreeBMD and closing this.


[ISSUE #36] Connect api upgrade

If the configuration items of SinkConnector and SinkTask are the same, could return the SinkConnector config directly，Avoid duplicate code between SinkConnector and SinkTask about configuration item extraction

@odbozhou @duhengforever @duhenglucky I suggest you create another pr to remove oms comments in our new interface. OpenConnect could grow dependently without OpenMesssaging :-) We'd like to see this strong case happen.


Changelog Fine Release Candidate

Changed title
Added items merged since Beta-2
[skip ci]

@miq-bot add_label documentation

@Fryguy


Regression : FancyZones does not work anymore with VSCode windows

Microsoft PowerToys version
0.76.2
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
Install PowerToys FancyZones
Move VSCode & see a zone higlighted,

✔ Expected Behavior
should snap to the zone
❌ Actual Behavior
does not snap to the zone
Other Software
VS Code Version: 1.86.2
OS Version: Windows 10

FancyZones has received some fixes since 0.76.2. Can you please upgrade to the latest (0.79) and check if your issue still exists? /needinfo

I get the same issue, does this get any progress?

Same issue here, using version 0.80.1

Same issue here, using version 0.80.1

In case this points anyone in the right direction for a fix, a workaround is to run both Power Toys and VS Code as an admin. Not ideal, but works for now.

Still present in v.0.83.0
Admin workaround works for me

same issue with version 0.85.1

same issue with version 0.85.1 and running admin doesn't work.  Feels bad

same issue with version 0.86.0, both FancyZone and VSCode are running as an admin but doesn't work.


Attempting to enable live testing

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.


[Action]: Check if Long Running ElastiCache Clusters Have Reserved Nodes Purchased for Them in AWS

Contact Details
No response
HealthCheck

[X] Is this Action a Check Action?

Action Name
Ensure Long Running ElastiCache Clusters Have Reserved Nodes Purchased for Them in AWS
Action Inputs
region
Action Outputs
list of ElastiCache Clusters, region
Comments
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Same logic as redshift one i guess?


Matplotlib from conda missing baseline images when pyinseq --test is called

The --test option of pyinseq, which uses pytest in the rootdir, throws this exception when called:
$ pyinseq --test
2021-08-09 14:55 - INFO - pyinseq - Process command line arguments
=============================================================================================== test session starts ===============================================================================================
platform darwin -- Python 3.6.13, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/emanuelburgos/opt/miniconda3/envs/test_pyinseq_py36/lib/python3.6/site-packages
plugins: cov-2.12.1
collected 0 items / 1 error

===================================================================================================== ERRORS ======================================================================================================
__________________________________________________________________________________________ ERROR collecting test session __________________________________________________________________________________________
../importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:994: in _gcd_import
    ???
<frozen importlib._bootstrap>:971: in _find_and_load
    ???
<frozen importlib._bootstrap>:941: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
<frozen importlib._bootstrap>:994: in _gcd_import
    ???
<frozen importlib._bootstrap>:971: in _find_and_load
    ???
<frozen importlib._bootstrap>:955: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:665: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:678: in exec_module
    ???
<frozen importlib._bootstrap>:219: in _call_with_frames_removed
    ???
matplotlib/tests/__init__.py:7: in <module>
    'The baseline image directory does not exist. '
E   OSError: The baseline image directory does not exist. This is most likely because the test data is not installed. You may need to install matplotlib from source to get the test data.
============================================================================================= short test summary info =============================================================================================
ERROR  - OSError: The baseline image directory does not exist. This is most likely because the test data is not installed. You may need to install matplotlib from source to get the test data.

I believe this happens because calling pytest.main() does not correctly append the test directories to the PYTHONPATH. For now, you can clone the source code (or cd into site-packages/pyinseq in your python architecture) to verify the software. However, this will not cause issues since TravisCI testing frameworks are implemented in the pyinseq github

The tests passed on the TravisCI instance. It looks like that is because the software is installed via pip there. Once this issue is addressed, can we redesign the Travis script so that the installation on Travis mirrors a user's conda installation?
It seems to me there is a chicken-and-egg issue here (the commits here need to be in place before they appear in conda!). Perhaps there is a clever solution...


Minor modifications related to both Drive and Bucket integration

Content of this PR:
Copy to the Drive allows to:
1.  copy to any place in the Drive (owned and shared Libraries)
2. check the size of the file (< 1 GB)
3. copy subdirectories
4. check the existence of the (sub-)directory, file before the copy
Copy to the Bucket allows to:
1.  copy only to the current collab bucket
2. check the existence of the file before the copy
3. init a bucket (because by default, the collab bucket is not created)
4. check the size of the file if needed in the future. I put an arbitrary size limit of 100 GB .
Import code fro the Drive:

allows to import multiple files and folders
creates a zip with no parent folder (when unpack)

This PR replaces PR #50
Works with https://github.com/msenoville/nmpi-job-manager-app/tree/bucket for the front-end

manually merged in 394fb9ae574d7fd8fb2ab0128a1b56b1b588f589


JavaScript Troubleshooting Tutorial: RangeError: Invalid code point

Write a short tutorial on JavaScript's RangeError: Invalid code point error message, following the "How to troubleshoot Python ZeroDivisionError" example tutorial.
The tutorial should be organized as follows:
---
title: How to troubleshoot JavaScript RangeError Invalid code point
author: your name
tags: [tutorial, JavaScript, troubleshooting]
publicationDate: today's date
description: Learn how to error handle JavaScript RangeError, Invalid code point
image: https://storage.googleapis.com/sourcegraph-assets/learn/headers/sourcegraph-learn-header.png
imageAlt: Sourcegraph Learn
browserTitle: RangeError, Invalid code point in JavaScript error handling
type: posts
---

Introduction with the error message

## Reproducing the error

Show how the error can be created.

## Solution 1

Provide a possible solution.

## Solution 2

Provide another solution.

## (optional) Solution 3

Optionally provide a third solution.

## Learn more

Search across open source JavaScript repositories that have the `RangeError` to understand the message more.

<SourcegraphSearch query="RangeError: Invalid code point" patternType="literal"/>

Check out more Sourcegraph Learn tutorials on [JavaScript](https://learn.sourcegraph.com/tags/javascript).

If this seems like a tutorial that you can write effectively for the developer community, please follow our Hacktoberfest 2021 contributor guidelines to proceed.

Hi Itagliaferri, I would like to work on it. :)


App becomes slow when screen got scrolled back by closing keyboard

There is an issue with widgets which react to onTapDown/onTapUp such as buttons when focussing a textfield which leads the screen to scroll. I were able to track it down to the screen being scrolled by closing the keyboard after focussing a textfield.
Here is a minimal example / reproduction of the issue including instructions to reproduce the "lag/slowdown".

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyButton extends StatefulWidget {
  @override
  _MyButtonState createState() => _MyButtonState();
}

class _MyButtonState extends State<MyButton> {
  Color myColor = Colors.blue;
  @override
  Widget build(BuildContext context) {
    return GestureDetector(
      onTapDown: (_) {
        setState(() {
          myColor = Colors.red;
        });
      },
      onTapUp: (_) {
        setState(() {
          myColor = Colors.blue;
        });
      },
      onTapCancel: () {
        setState(() {
          myColor = Colors.blue;
        });
      },
      child: Container(
        alignment: Alignment.center,
        width: 200,
        height: 50,
        color: myColor,
        child: Text("Tap me"),
      ),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Container(
        height: MediaQuery.of(context).size.height,
        width: MediaQuery.of(context).size.width,
        child: SingleChildScrollView(
          child: Container(
            padding: EdgeInsets.all(50),
            height: MediaQuery.of(context).size.height,
            child: Column(
              mainAxisAlignment: MainAxisAlignment.start,
              children: <Widget>[
                Text(
                  '1. Tap the button very quick, youll see it blink.\n2. Focus the textfield so the keyboard comes up.\n3. Close the keyboard\n4. Tap the button again very quick, it kinda laggs.\n\nTo fix the bug:\n1: Open the keyboard\n2: Scroll the page back down (so the keyboard overlap the screen as if it never scrolled)\n3: Close the keyboard\n4: Button works as supposed again',
                ),
                Expanded(child: SizedBox()),
                MyButton(),
                SizedBox(
                  height: 40,
                ),
                TextField(),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Only tried it on Android yet. Web isnt a problem, as there is no keyboard popping up.
Target Platform: Android
Target OS version/browser: /
Devices: OnePlus 6T
Logs

Logs

no issues found

[√] Flutter (Channel stable, 2.0.0, on Microsoft Windows [Version 10.0.19041.804], locale de-DE)
    • Flutter version 2.0.0 at C:\src\flutter
    • Framework revision 60bd88df91 (2 hours ago), 2021-03-03 09:13:17 -0800
    • Engine revision 40441def69
    • Dart version 2.12.0

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\xxx\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.53.2)
    • VS Code at C:\Usersxx\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.20.0

[√] Connected device (3 available)
    • ONEPLUS A6013 (mobile) • 95a75628 • android-arm64  • Android 10 (API 29)
    • Chrome (web)           • chrome   • web-javascript • Google Chrome 88.0.4324.190
    • Edge (web)             • edge     • web-javascript • Microsoft Edge 88.0.705.74

onTapDown and onTapUp get fired without any delay, i guess the setState just get ignored? the buttons are working but the UI doesnt get updated.

I can reproduce the issue on latest master channel.

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-11.0.pre.97, on macOS 11.2.1 20D74 darwin-x64, locale en-AO)
    • Flutter version 2.1.0-11.0.pre.97 at /Users/pedromassango/Code/flutter_master
    • Framework revision c14c8d8177 (86 minutes ago), 2021-03-03 21:40:34 -0800
    • Engine revision 72bbc5d92c
    • Dart version 2.13.0 (build 2.13.0-93.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 54.0.3
    • Dart plugin version 203.6912

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.2.1 20D74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 88.0.4324.192

! Doctor found issues in 1 category.

This seems similar to https://github.com/flutter/flutter/issues/76605.


Missing files or invalid fixture scripts?

I tried some of the examples in the "fixtures" directory, and the simulator works great!  Nice work!
However, I discovered that there are some examples that don't run either because their mesh files don't exist in the repo or because of some other problem.
For example, this example is missing its meshes:
https://github.com/ipc-sim/rigid-ipc/blob/main/fixtures/3D/mechanisms/expanding-lock-box.json#L11-L57
This example says [2021-09-30 19:57:28.039] [error] Invalid Json file:
https://github.com/ipc-sim/rigid-ipc/blob/main/fixtures/2D/compactor.json

Glad to hear it is working well for you.
The lockbox model was one that we bought here and used in our paper, but we do not have the rights to distribute it, unfortunately. I left the JSON fixture in the repo simply to provide the setup and parameters used in our paper. Maybe I will add a note about this in the README.
As for the broken JSON files, that is most likely a find-replace that left a trailing comma at the end of an object. JSON is annoying about that. Thanks for pointing me to that file. I will fix it and try to check all the files can be read.

Fixed

Thank you again!


Default value in DefaultValueValidator won't make its way through post

Having for instance:
[['myAttribute'], 'default', 'value' => 0]

Then in controller (say in actionCreate) :
if ($model->load(Yii::$app->request->post())) {

I expected $model->myAttribute to be 0 before doing $model->save() but it is empty in turn.
So I don't know whether this is a bug or it is really intended that way.
Regards,
Antonio

Validators are triggered on Model::validate(), which is triggered by ActiveRecord::save(). Before validate() invocation no default values specified via DefaultValidator can be applied.


Add logging

Check List
Resolves: #99

[x] I added tests for the changed code.
[x] I updated the documentation for the changed code.
[x] I ran the full tox test suite locally, so the CI pipelines should be green.
[x] I added the change to the History section on the README.

With the restructure in #100 the --debug flag was removed. With this PR the logging module is implemented to bring a better logging experience with more logging levels.

@weibullguy I am done. Could you review the changes?
I added the std-lib logging. The logging is deactivated if rstcheck is used as a library and no logging config is set. If rstcheck is used a CLI application however a logging config is set in the cli module and the messages are printed to the console.
I placed some messages I think are helpful around the code base, but the core was the config module like discussed in #99.
Currently only two functions from the config module are called by the rest of the code base:

load_config_file_from_path in runner.py if --config is set
load_config_file_from_dir_tree in checker.py for every file that is checked

In both occasions the functions is called with the default behavior.
The default behavior which is used across all config loading functions in the config module is the following:

If the path is a concrete file path, a message at WARNING level will be logged, if the file has no config section.
If the path is a directory path, a message will be logged at INFO level, if no config was found. The reason can be: No file found or no config section in files found.
If the path is a directory path and a .rstcheck.cfg file is found and has no [rstcheck] config a WARNING level message is logged.

I will merge this PR now, but I would still appreciate your opinion @weibullguy. :)


use try and except in getting org, etc.

I recommend using try/except while doing some things like tweeting to Twitter or something so that if something fails - the program can return a understandable error instead of normal errors

@hitblast I'll do this if you want

Sure @thenishantsapkota

@thenishantsapkota If you'd like then sure, assigning it to you then.

This can be closed as it was done in #57

Thanks @thenishantsapkota


Add missing inputs to the incremental task "test"

Hi
This pull request fixes the incremental task test.
This task depends on some test resources included in the test/resources directory.
However, this directory is not declared as input to this task, so tests are not executed whenever there are updates to any of those dependent files.
This commit fixes this issue by declaring test/resources as input of task test.

Thanks for your contribution.


Forecast.io integration for weather/light data

There's a companion PR in the DRIVER repo.

+1
Consider adding some error handling and use of get instead of indexing directly to deal with unexpected API responses.

I'm guessing there's something going on with the build and/or Travis causing the failures; would be good to check that tests pass locally.

Thanks, I'll do that.


Packaging

Pull Request Test Coverage Report for Build 633847176

13 of 88 (14.77%)  changed or added relevant lines in 4 files are covered.
71 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 31.268%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mlir_graphblas/engine.py
0
1
0.0%

mlir_graphblas/cli.py
9
16
56.25%

mlir_graphblas/explorer.py
0
67
0.0%

Files with Coverage Reduction
New Missed Lines
%

mlir_graphblas/engine.py
7
27.03%

mlir_graphblas/cli.py
26
54.46%

mlir_graphblas/explorer.py
38
0%

Totals

Change from base Build 633700401:
0.0%

Covered Lines:
106

Relevant Lines:
339

💛  - Coveralls

Pull Request Test Coverage Report for Build 633847176
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

13 of 88 (14.77%)  changed or added relevant lines in 4 files are covered.
71 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 31.268%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mlir_graphblas/engine.py
0
1
0.0%

mlir_graphblas/cli.py
9
16
56.25%

mlir_graphblas/explorer.py
0
67
0.0%

Files with Coverage Reduction
New Missed Lines
%

mlir_graphblas/engine.py
7
27.03%

mlir_graphblas/cli.py
26
54.46%

mlir_graphblas/explorer.py
38
0.0%

Totals

Change from base Build 633700401:
0.0%

Covered Lines:
106

Relevant Lines:
339

💛  - Coveralls


Make fuzzy searching more generic

I named the branch bad but this evolved from enabling fuzzy badge searching into making fuzzy searching more generic in general. This PR enables the API to do fuzzy searching by either badge, last name, or first name, and weights them in that order. I'm still trying to get better at the weighting thing but I think this is pretty good for right now. I'm opening this as a draft PR so everyone can try it out and let me know what they think of the search feature.
We'll want to update the website to provide some recommendations on getting better search results after this is implemented. Specifically, it is best for badges to just put a guess in for a digit if you don't know it, e.g. if you know that a badge number is 58_3 you should put in 5803 or something similar because the fuzzy matching will perform better with that than say just 58 or 583, which which will likely not provide the desired results.

@mpuckett159 should this be closed? Re-addressed later?

This should probably just be closed period and we'll figure out if it's even necessary later.


std::vector<vector> not correctly being read in .array() method

Hello! I am analyzing a TTree where one branch is of type std::vector<vector> is not being read. file_str is the ROOT file:
ttree1 = uproot4.open(file_str)["CharmAnalysis"]
ttree1["TruthParticles_Selected_daughterInfoT__eta"].array()
Here is the full stack trace:
IndexError                                Traceback (most recent call last)
<timed eval> in <module>

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/behaviors/TBranch.py in array(self, interpretation, entry_start, entry_stop, decompression_executor, interpretation_executor, array_cache, library)
   1284             interpretation_executor,
   1285             library,
-> 1286             arrays,
   1287         )
   1288

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/behaviors/TBranch.py in _ranges_or_baskets_to_arrays(hasbranches, ranges_or_baskets, branchid_interpretation, entry_start, entry_stop, decompression_executor, interpretation_executor, library, arrays)
    493
    494         elif isinstance(obj, tuple) and len(obj) == 3:
--> 495             uproot4.source.futures.delayed_raise(*obj)
    496
    497         else:

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/source/futures.py in delayed_raise(exception_class, exception_value, traceback)
     31         exec("raise exception_class, exception_value, traceback")
     32     else:
---> 33         raise exception_value.with_traceback(traceback)
     34
     35

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/behaviors/TBranch.py in basket_to_array(basket)
    467                     branch.entry_offsets,
    468                     library,
--> 469                     branch,
    470                 )
    471         except Exception:

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/interpretation/objects.py in final_array(self, basket_arrays, entry_start, entry_stop, entry_offsets, library, branch)
    218                 for global_i in range(start, stop):
    219                     local_i = global_i - start
--> 220                     output[global_i - entry_start] = basket_array[local_i]
    221
    222             start = stop

~/.local/cori/3.7-anaconda-2019.07/lib/python3.7/site-packages/uproot4/interpretation/objects.py in __getitem__(self, where)
     67         if uproot4._util.isint(where):
     68             byte_start = self._byte_offsets[where]
---> 69             byte_stop = self._byte_offsets[where + 1]
     70             data = self._byte_content[byte_start:byte_stop]
     71             chunk = uproot4.source.chunk.Chunk.wrap(self._branch.file.source, data)

IndexError: index 12344 is out of bounds for axis 0 with size 12344```

This is helpful—there's some inconsistency about how many entries a basket is believed to have (trying to get entry 12344 from a basket with 12344 entries... this might just be the first one that fails).
Could you send the file to that I can run it and look for the reason why there's this disagreement about how many items the basket has? If it's large or private, you can send it to me by email: jpivarski at GMail. Thanks!

Thanks for the file—you helped me fix a super-dumb error. (See the correction: four if-cases need to assign basket_array, one didn't. This is a cogent argument for test-coverage: none of my sample files enter this case. Then again, it's hard to do test-coverage when your inputs are ROOT files; you have to find files that exhibit each of the cases you want to test. Thanks for sending me yours!)
Your original question was about performance. This branch takes 10 seconds to read on my computer. Since it's an inline object (vector of vectors), it's going through the slow Python code right now (this), though this will eventually be replaced by a compiled routine in Awkward 1. In the last plot of this talk, your case is on the green line (original; no speedup) at the "doubly jagged" point, which is much lower than the "singly jagged" because of the difference in serialization format. The speedup shown in this plot from green line to orange line was made with experimental code that hasn't been integrated into the codebase, so it shows that we can expect a factor of 100 speedup when that's finished, bringing the "doubly jagged" case up to the same speed as "singly jagged." This is consistent in your file, because your std::vector<float> branches take 0.05‒0.08 seconds to load, which is that factor of 100 over 10 seconds.
As for when that will actually happen, it could be a matter of months, since getting Uproot 4 feature-complete is a higher priority. (Sorry!)


Roll Engine from 2eab395ee2fc to 4ac4e5cc2228 (8 revisions)

https://github.com/flutter/engine/compare/2eab395ee2fc...4ac4e5cc2228
2021-07-02<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 4MLcvcjCH... to QbIpQIqxK... (flutter/engine#27146)
2021-07-02<EMAIL_ADDRESS>Support right-clicking on iPadOS (flutter/engine#27019)
2021-07-02<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from jzKy-rCeR... to oiyYFMOd3... (flutter/engine#27145)
2021-07-02<EMAIL_ADDRESS>enable DisplayList by default (flutter/engine#27130)
2021-07-02<EMAIL_ADDRESS>[web] replace browser-related conditional logic with BrowserEnvironment (flutter/engine#27084)
2021-07-02<EMAIL_ADDRESS>Update goldens test for Thai. (flutter/engine#27144)
2021-07-02<EMAIL_ADDRESS>Roll Skia from 1c467774e56e to e9ab391765c7 (1 revision) (flutter/engine#27143)
2021-07-02<EMAIL_ADDRESS>[web] skip overlay test on Safari (flutter/engine#27114)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4MLcvcjCHy-1 to QbIpQIqxKb03
fuchsia/sdk/core/mac-amd64 from jzKy-rCeRWNt to oiyYFMOd30Op
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gold has detected about 2 new digest(s) on patchset 8.
View them at https://flutter-gold.skia.org/cl/github/85805


OCD: Rainy day: Change inline-block to floats

Browsers render line-returns betwee inline elements (including inline block) as a space. This kills centering of stacked elements and makes them off.
Instead of dib use cf on parent and db on elements.

Handled in #59


How would I query multiple ModelIndexes simultaneously?

I'm looking through your docs, and this project looks pretty cool, but I have a question. I'm building a site-wide search feature that will query multiple models from multiple apps and display all of them in one, unified interface.
It appears that your ModelIndex associates a single Model to a single Index. Is there any way to query multiple ModelIndexes in a single expression?

If I recall correctly (I haven't used this project in about a year now to be honest), it is possible to use the main Bungiesearch object to pass a list of indices to search. However, this functionality does not directl integrate with the ModelIndex classes, so you need to do the mapping to Django objects yourself.
Another solution is to run the queries independently and assemble all the results together in the app. Last time I was using this, we had multiple models to search, some defined on different indices, and we simply had a list of these Django model (e.g. [Article, Patent]) and iterate through that. Each had its own index defined via a ModelIndex (e.g. Article was associated to the content_new index and Patent to the content index). The query would be applied to each model, the results aggregated in a list, and that list had some further processing before being returned by the API.
Hope this helps.

Do you think the "query all models and assemble the results" strategy will grossly affect performance as our indexes grow in size?
This also sounds like it could get tricky if I need to correctly sort multiple result sets with different scores, boosts, etc.

The scores and boosts happen at the elasticsearch level, so the performance of these depend solely on the size and performance of your cluster. Concerning the assembling of results, it really depends a lot on how much data you plan on grabbing from each index, and on whether you also request the actual object from the database, or do the assembly solely from the ES response (which has a dictionary with all the requested fields for each item returned). In my case, we had seven models and would return 20 or 25 items of each model (so 140 to 170 items), did another in-app filter of the data using only the ES response, and then trimmed down the data based on what we actually wanted returned to the requester.

I could probably do something like that.
Since I'm querying each index in isolation, will the scores be skewed or inaccurate in some way since each index is not aware of the other indexes' matching documents?

Yes, the scores will be skewed, so you will need some kind of
normalization. Not sure if ES now provides a way to find the highest score
attainable but until last year it could not. Hence, in my application, we
would normalize based on the highest score returned by the query. That's
far from perfect though, and we had a number of odd results that way.
On Tue, Dec 13, 2016, 15:41 Nathan Jones<EMAIL_ADDRESS>wrote:

I could probably do something like that.
Since I'm querying each index in isolation, will the scores be skewed or
inaccurate in some way since each index is not aware of the other indexes'
matching documents?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ChristopherRabotin/bungiesearch/issues/159#issuecomment-266885464,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEma6MLaohc4pzWE2JqVtU4XjDnDG7GHks5rHx8WgaJpZM4LMRUm
.

Ah, ok. I think I'll revert back to haystack usage for now, but if multiple index searching ever becomes a feature of this project, please let me know!

Okay, good luck. I hope that Haystack has changed in speed for the past two years as it was painfully slow on ES when I started bungiesearch. That was one of the reasons for starting this project.
P.S.: Now that I write this, I do recall reading that Haystack's ES layer is now done by the ES team via elasticsearch_dsl so it probably is faster now.

I didn't realize that, thanks for the heads up. I'll keep an eye on their progress. I think there's development work going into modernizing the elasticsearch backend, so we'll see what happens.
Thanks again for all of your help and timely replies!


Make the class autoloadable using the buildin Composer autoloader

Register namespace with Composer so the autoloader works.
After adding "ulrichsg/getopt-php" to your composer.json you can now do the following in your main package.
// Require the composer autloader
require_once __DIR__.'/../vendor/.composer/autoload.php';
use Ulrichsg\Getopt;
new Getopt();

Nice idea, thanks :)


61 new nav org switcher

Context
Following on from #2668, this PR adds a Change organisation button for providers who have multiple orgs.
Changes proposed in this pull request

Add dynamic view component
Render component if: current user exists, feature flag enabled, user org count greater than 1, provider not nil, not on a support page
Add view preview page

Guidance to review

Login as a multi org user and ensure you can change orgs using the new link
Repeat for a non multi org user and ensure you cannot
Repeat for any of the support pages and ensure you cannot

Screenshot

 New nav org switcher


Add @PATCH annotation to support HTTP PATCH method

@uschi2000 @markelliot
We use PATCH methods on our server, so this adds support for annotations here. I'm more confident that this makes sense in http-remoting, but if not we can just include this in our API project as well.
DropWizard and OkHttp both support this, so the addition of this annotation is sufficient to properly support this from a client perspective (and verified that in unit test and against local server).

Cool, so I think the annotation ought to live in its own project, though, or to use this annotation on a server project we end up taking the dependency on the clients project.

Got it -- will make the change for the next review

Moved the PATCH file to its own project. Also, found that DropWizard basically implements this exact same annotation in the same way in io.dropwizard.jersey.PATCH. This change may still be relevant since asking all clients to import DropWizard doesn't make much sense, but just FYI.

Interesting. I guess we could actually skip adding this since users who want PATCH can use it successfully by defining this annotation or borrowing dropwizard's. Less clear that we should be including it given there's another library out there?

Since the annotation is so small/easy to define, I'm not opposed to leaving it to clients to do it. For an API project like mine I don't think I want to pull in io.dropwizard.jersey just for the annotation, but fine re-defining it. PATCH is also probably rare enough amongst our projects right now that it doesn't really matter. Will close this out for now, but may be worth re-considering if we find numerous projects having to re-define it.

Yep, makes sense, thanks.


fpga clock name changed to Clk_C16 and Clk_C21

Why do we need to change this again? Note that this will also require changes in arch-defs' tests

+Tara
Hi Karol,
Our Firmware team wants the FPGA clock to be named as Clk_C16 & Clk_C21 instead of Clk16 & Clk21 respectively as these clocks are described as C16 and C21
in the datasheet and TRM.

Yes, I have made the changes in symbiflow-arch-defs ( techmap/cells_map.v  & tests) as well and raised PR.

           quicklogic/pp3/techmap/cells_map.v

quicklogic/pp3/tests/counter/counter.v
quicklogic/pp3/tests/quicklogic_testsuite/clock_test/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/counter_al4s3b/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design1/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design10/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design2/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design3/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design4/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design5/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design6/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design7/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design8/AL4S3B_Fabric_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/design9/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/fifo_test/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/inferred_ram_test/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/ram_test/AL4S3B_FPGA_Top.v
quicklogic/pp3/tests/quicklogic_testsuite/spi_master_top/spi_master_top.v
quicklogic/pp3/tests/ram/ram.v
quicklogic/pp3/tests/sdiomux_counter/counter.v
quicklogic/pp3/tests/soc_clocks/soc_clocks.v
quicklogic/pp3/tests/soc_litex_pwm/AL4S3B_FPGA_Top.v
Regards,
Rakesh
From: Karol Gugala<EMAIL_ADDRESS>Sent: 03 March 2021 18:36
To: QuickLogic-Corp/yosys<EMAIL_ADDRESS>Cc: Rakesh Moolacheri<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [QuickLogic-Corp/yosys] fpga clock name changed to Clk_C16 and Clk_C21 (#72)
Why do we need to change this again? Note that this will also require changes in arch-defs' tests
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/QuickLogic-Corp/yosys/pull/72#issuecomment-789700452, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM4XMKHSZX6OBS2LFH5E34LTBYX25ANCNFSM4YRDWC2Q.

lgtm


azure appservice not using correct version of NPM when using child process

0
I am trying to use child process in my dot net core application to run some npm and ng commands. I have set WEBSITE_NODE_DEFAULT_VERSION =12.18.0 and WEBSITE_NPM_DEFAULT_VERSION=6.14.4 and in kudu powershell/cmd its showing correct version
D:\home>npm --version 6.14.4
D:\home>node -v v12.18.0
My code in c# to run npm commands :
    ProcessStartInfo processInfo = new ProcessStartInfo();
    processInfo.FileName = @"cmd.exe";
    processInfo.ErrorDialog = true;
    processInfo.UseShellExecute = false;
    processInfo.RedirectStandardOutput = true;
    processInfo.RedirectStandardError = true;
    processInfo.Arguments = $"/C npm -version";

    Process process = Process.Start(processInfo);
    process.WaitForExit();
    string output = process.StandardOutput.ReadToEnd();
    string error = process.StandardError.ReadToEnd();

shows npm version as as 1.1.37 but it will display node version correclty if i use node -v as command.
Deploying from VS to AZURE
I hope some one has solution for my problem. Thank you

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Unittest times out if failure occurs during async callback while waiting for a future

I am trying to use the unittest module to implement integration tests that open a connection to a subprocess, exchange data with it, and check that the appropriate responses are received from the subprocess.
Since there will be many integration tests, I've placed the code for communicating with the subprocess in a separate class.  This class provides convenience functions to allow the tests to be written at a reasonably high level; those convenience functions generally do their work using asynchronous callbacks (which are guarded by  expectAsync()), and then use the Completer class to signal to the test when it is time to proceed to the next step in the communication protocol.
The problem I'm running into is that if the helper class detects an error condition (using expect()) while the test is waiting on a future, the unit test doesn't stop--it continues to execute until it times out.  Then, when the unit test times out, only the timeout is reported; the error condition is lost.
Here is a short contrived example that illustrates the problem:
  import 'dart:async';
  import 'package:unittest/unittest.dart';
  main() {
    test('foo', () {
      var completer = new Completer();
      new Timer(new Duration(seconds: 1), expectAsync(() {
        expect(false, isTrue);
        completer.complete();
      }));
      return completer.future;
    });
  }
This produces the result:
  ERROR: foo
    Test timed out after 120 seconds.
  0 PASSED, 0 FAILED, 1 ERRORS
  Unhandled exception:
  Exception: Some tests failed.
  #0      SimpleConfiguration.onDone (package:unittest/src/simple_configuration.dart:189:9)
  #1      _completeTests (package:unittest/unittest.dart:487:17)
  #2      _runTest (package:unittest/unittest.dart:436:19)
  #3      _nextTestCase (package:unittest/unittest.dart:376:11)
  #4      _runTest.<anonymous closure> (package:unittest/unittest.dart:452:24)
  #5      _createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:11)
  #6      _handleTimeout (dart:io/timer_impl.dart:292)
  #7      _handleTimeout (dart:io/timer_impl.dart:301)
  #8      _handleTimeout (dart:io/timer_impl.dart:301)
  #9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:124)
I would have expected for the test to terminate as soon as "expect(false, isTrue);" executed, with a stacktrace of that failure.
Note that I can work around the problem by replacing the line "return completer.future;" with "completer.future.then(expectAsync((_) {}));".  But I'd rather not do this since it's counterintuitive.

This issue has been moved to dart-lang/test#256.


Release notes for March 5th release

Please review & approve (Mx 7.12 release)

@arjan-h Please sign the CLA.


Do not allow Service Broker registration with basic auth in the broker_url

Story
Do not allow broker registration that contains basic auth credentials in the URL #155659461
Why
At the moment when a Service broker returns an invalid response, CC error handling logs the full URL that was used to register the SB. If that URL contains basic auth username:password, then this will be visible to the user whose request was answered with invalid response regardless of who registered the broker.
What
Adds a validation for basic auth in the URL for the ServiceBroker model, if basic auth is included in the broker_url field the object fails validation.

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the master branch

[x] I have run all the unit tests using bundle exec rake

[x] I have run CF Acceptance Tests

Thanks, SAPI team

@zrob @Gerg This PR includes some small breaking changes, so it would be valuable that the CAPI team reviews it.

Discussed with @mattmcneeney and @ablease.

This does feel like a breaking change, but it is an acceptable one if the SAPI team feels it is worth it.
SAPI to follow up on how this affects folks that already have brokers registered this way.  They should still be able to perform actions like catalog updates, etc.

We've validated that users who have registered service brokers with credentials in the URL will still have their broker working, but will be enforced to remove the credentials from the URL upon next update.  We've also added additional test that covers the update service broker flow as a separate commit.

Hey @zrob We confirmed that folks wouldn't end up in a sticky situation if they had already done this and that this would improve the security in the platform, so we decided to update and merge this PR. Let us know if you have any questions!


Check that .txt and .py ingest actually fully work, add .md support

Also plz support .md ingest, treat it just as a .txt file.

Added .md ingest and fixed .py ingestion. PythonLoader() was not reading the temp file, currently storing as regular file and deleting it after ingestion.

Is there PR for this? Let's test & merge ASAP. It's due very soon.

Oh it would be ideal if you open separate PRs (on separate branches) for each feature. Otherwise we can't merge them independently. Here's the relevant commit, but now we can't merge it yet :(  https://github.com/UIUC-Chatbot/ai-ta-backend/pull/33/commits/07238a21648279ada15cdccc571e3c0963fe6c90

Issued a new PR - created a branch from base and copied the changes there.

Ok I requested minor changes about weird media/ string in s3_path


Chat view, retain scroll on last viewed msg

This issue also applies to sphinx-ios.
To recreate the state of the problem:

view any chat
scroll back a few pages to see an older message
leave the chat and return to it
the chat view is reset to the most recent message (even if no new message comes in)

A better experience is common in Discord and other views:

always return to the last point viewed in the conversation even if a new message comes in
indicate a new message is available (already implemented) and scroll to the bottom when the new message icon is tapped

@tomastiminskas working on this right now

Starting with iOS b/c it's slightly easier then will port over to mac: https://github.com/stakwork/sphinx-ios/pull/143

Addressing on https://github.com/stakwork/sphinx-mac/tree/jc/develop/retain-chat-scroll


Increase wait time between builds for embedded runner

So the file timestamps can be used to distinguish between the output
files since the optimized incremental Java compilation now made
builds too fast so this is a problem now.
Fixes gradle/gradle-private#3364

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test and merge

Your PR is queued because #16817 is being built.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued because #16868 is being built.

OK, I've already triggered a build for you.

Pre-tested commit build failed.


Copy converters

Interim solution to solve the problem for the k8s runner of converters that expect scripts but also have requirements and therefore use mulled containers. This should not be an issue with pulsar as the tool directory (and hence scripts) will be staged into the container if I understand correctly.

Closing in favor of https://github.com/galaxyproject/galaxy-helm/pull/265


Mobile and Ubiquitous Computing not counted as a foundational class

Describe the bug
The "Mobile and Ubiquitous Computing" class is listed as not foundational, which doesn't match the official page

Fixed! Thank you ⭐


fix(nvme): snapshot creation command opcode changed

Since now NVMe replica creation has payload which needs to be transferred along with thew vendor specific command (currently 0xc0), we need to use a new opcode: 0xc1, since data direction for the command is encoded in the lowest 2 bits, and WRITE commands should be 0x01, so we have to adjust the opcode to 0xc1.

bors merge


SGU and DSGU

I implemented SGU and DSGU.
http://arxiv.org/abs/1604.02910

This comment about MGU is true of SGU and DSGU, too.

Same as #1101. How about adding the prefix Stateless to SGU and DSGU?

Could rename L.SGU and L.DSGU to L.StatelessSGU and L.StatelessDSGU, respectively?

Also, please resolve the conflict.

Is it OK to abandon this PR?

@unnonouno How do you think of it? I don't think it takes too much time to write it up. If you cannot spare time to work on this, somebody could take it over.


Get on the Mesosphere DC/OS app store

They already have crappy Jenkins. How hard would this be?
https://dcos.io/

Probably not difficult, but I suspect this is going to be one of those things that someone will need to contribute, rather than a core roadmap item.
Would you be interested in taking a stab at it?

FWIW: we are running a Drone.io 0.4 server in our DC/OS Marathon cluster.  Just had to create an application, you can use the JSON here as a starting point:
drone-0.4.json.txt
That being said, I think it'd be super cool to have 0.5 running and be able to scale the workers... I wasn't able to get that working within the time I had... so had to just stick with 0.4.

FWIW: we are running a Drone.io 0.4 server in our DC/OS Marathon cluster.  Just had to create an application, you can use the JSON here as a starting point:
That being said, I think it'd be super cool to have 0.5 running and be able to scale the workers... I wasn't able to get that working within the time I had... so had to just stick with 0.4.
drone-ci-0.4.json.txt

@nodesocket / @gtaylor / @kamilchm / @xiaods / @gaocegege / @jpzk
It's underway at https://github.com/mesosphere/universe/pull/903 (and I'd love some input from folks here).  I've put down @bradrydzewski as the "Maintainer" (since I'm not in the drone org but just love what you guys are doing here).  Also, if you wanted to add any additional goodies to that PR I'd be super grateful!  Looking forward to getting it added to the Mesosphere!

@dellintosh Awesome work! And a very good idea.
As mentioned in that PR, you're probably going to want to put yourself as the maintainer, since we don't want to volunteer Brad for that responsibility.

@gtaylor Good call, I've put down my own personal email for the Maintainer... I went back and forth on that (since I'm not on the core dev team, but I'm technically the one who put this package together).  One thing that I'd ask from you guys is a few screenshots/logos/etc?
Can you take a look at this section and let me know if you'd like to see anything Drone-specific added?

Oh, that's a good question. The various Drone sites are in a state of flux right now with 0.5 looming. I'd imagine there will eventually be some graphics that we could use here, but they unfortunately don't exist just yet.

@dellintosh I do have https://github.com/drone/brand which has some branding assets, including logos in various formats and a few screenshots.
Note that the screenshots include browser chrome and therefore may need to be cropped to meet the style guidelines of the DC/OS website.

closing this since it is being handled by the community (thanks by the way!)


Markulf intervals

a didactic example based on
https://www.joachim-breitner.de/blog/734-Finding_bugs_in_Haskell_code_by_proving_it

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: markulf sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@markulf From today's discussion with @aseemr-msr, this is ready to merge, but you need to sign the CLA before that can happen :)

oldest pull request ever, just signed the CLA

will resolve and try to merge ASAP

Finally! : )


add prometheus library to all workflows (build, pypi, documentation, ....)

https://github.com/test-fullautomation/robotframework-prometheus

integrated in 0.12.1


Images changing too quick, resulting in the chat moving up and then down.

I'm seeing similar behaviour to your gif in 3.2.0, messages with large attachments especially only taking the default line of space until the image starts loading, then suddenly pushing everything above it up. It's most obvious when first switching to the channel


Gnome freezing with GPU HANG: ecode 12:1:4c0452c8, in gnome-control-c [18002]

On my new XPS 13 plus with Ubuntu 22.10, I was noticing it freezing, requiring a hard reset. However, I later found out that while no keyboard or mouse input worked, if I ssh'ed into the machine, it was still alive. I could recover it by doing a killall -9 gnome-shell.
There's a recent thread about this in https://gitlab.freedesktop.org/drm/intel/-/issues/4825 .
After further investigation, I suspect this was not happening randomly, but only happening while I was playing in gnome settings (I also originally thought this was due to my experimentation with an older kernel).
I've narrowed it down to being able to be consistently reproduced by scrolling around the power settings screen for less than a minute.  I'm going to keep seeing whether the issue ever is reproduceable in any other way.
This issue has been brought up in:

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2003
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1504 (vaguely related)

This is annoying, but easy to avoid. Switching power profiles is still possible too with the quick menu and even in settings if I don't linger long on the screen. Hopefully this is not a hardware issues with my machine.
When bug occurs, output of sudo journalctl -f /usr/bin/gnome-shell:
Nov 17 01:19:26 superlappy gnome-shell[32011]: See https://wayland.freedesktop.org/libinput/doc/1.21.0/touchpad-jumping-cursors.html for details
Nov 17 01:19:26 superlappy gnome-shell[32011]: libinput error: event12 - VEN_04F3:00 04F3:31D1 Touchpad: kernel bug: Touch jump detected and discarded.
Nov 17 01:19:26 superlappy gnome-shell[32011]: See https://wayland.freedesktop.org/libinput/doc/1.21.0/touchpad-jumping-cursors.html for details
Nov 17 01:19:26 superlappy gnome-shell[32011]: libinput error: event12 - VEN_04F3:00 04F3:31D1 Touchpad: WARNING: log rate limit exceeded (5 msgs per 24h). Discarding future messages.

There is a large thread that seems related in https://community.frame.work/t/hard-freezing-on-fedora-36-with-the-new-12th-gen-system/20675/171?page=3 . Things that didn't work:

Disabling enable_psr (ie: setting i915.enable_psr=0 for GRUB_CMDLINE_LINUX_DEFAULT.
Disabling automatic brightness.
sudo apt-get remove xserver-xorg-video-intel

Issue seems to pop up a lot: https://gitlab.freedesktop.org/drm/intel/-/issues/?search=gpu hang&sort=created_date&state=opened&first_page_size=20
Issue is not fixed in Kernel 6.0.9.  Was looking a bit at https://www.reddit.com/r/linuxquestions/comments/yiiua7/does_anyone_know_what_the_status_is_on_the_i915/ .

https://gitlab.freedesktop.org/drm/intel/-/issues/4825 suggests mesa v22.2.3 may fix this issue. However, there was also talk of kernel 6.0.9 fixing the issue, but I verified that is not the case personally.
Ubuntu is currently on 22.2.1.
Apart from the way to reproduce via the power gnome menu, I've only had the issue occur once in Chrome while browsing google maps on an external display. It's otherwise been pretty darn stable, but it's pretty annoying when it happens.

Under normal use, this has effectively been a non-issue for me. Just going to close it out and hope it never pops up again for me.


Create credit-card-feature-parsing.yml

I've been working through sample 1d8fd13c890060464019c0f07b928b1a (which was pushed to the testfiles repo) and making sure that rules are triggering on all significant behaviour.
@williballenthin I noticed that you had a credit card rule, but it wasn't triggering on this sample, due to the read process memory rule hitting on a different function.  I added in the additional sentinel checks that were performed by this sample and added it as another nursery rule.
Running against the sample will now show
credit card feature parsing
namespace  collection/credit-card
scope      function
matches    0x402860

good rule!
if this passes the linter with no warnings, then we can put it directly in the appropriate directory. the nursery is our way of saying to the linter "i know, i know, i'll get to it".

i'll merge this and move the file around myself, so that i can address https://github.com/fireeye/capa/issues/182
thanks @re-fox !


Fix: Useless reference to PUHandler

Codecov Report

Merging #330 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   57.95%   57.96%   +<.01%
==========================================
  Files          49       49
  Lines        5038     5034       -4
==========================================
- Hits         2920     2918       -2
+ Misses       1884     1882       -2
  Partials      234      234

Impacted Files
Coverage Δ

configurator/configurator.go
69.96% <ø> (+0.5%)
:arrow_up:

monitor/rpcmonitor/rpc.go
76.19% <100%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07c932...11446e7. Read the comment docs.


add parameter to avoid torch.distributed.init_process_group get timeo…

…ut when some rank takes much longer time loading partitioned dataset than others

Fixed in #103


Release 29.2.0

Releases #463.

Yeah this should be a minor bump to 29.2.0

Thanks, I had my gem rules mixed up! Amended now.


Can client separately run on non-Orca-built kernel?

Hi, I'm trying to run Orca in remote mode without Mahimahi.
I have a dumb question here: it seems that the client (compiled from client.c) is a simple receiving/acknowledging tool. So and it run on a linux kernel without Orca patched?
Thanks!
@Soheil-ab

Hey @meng-tong
Correct. As mentioned in the paper, Orca is a sender-side TCP. That means it only requires change at the sender side and as long as the client sends back Acks, the client can use any TCP protocol (on any Kernel, e.g. without Orca patch).

Hey @meng-tong
Correct. As mentioned in the paper, Orca is a sender-side TCP. That means it only requires change at the sender side and as long as the client sends back Acks, the client can use any TCP protocol (on any Kernel, e.g. without Orca patch).


gedcomq now supports variables

The internal gedcomq compiler and engine has been rewritten to allow for more complex syntax, including variables.
Variables allow multistage processing of queries by separating the expressions with ";". For example:
Names are .Individuals | .Name; Names | .String

This change is

Codecov Report

Merging #171 into master will increase coverage by 1.4%.
The diff coverage is 92.07%.

@@            Coverage Diff            @@
##           master     #171     +/-   ##
=========================================
+ Coverage    46.2%   47.61%   +1.4%
=========================================
  Files         152      155      +3
  Lines        4352     4486    +134
=========================================
+ Hits         2011     2136    +125
- Misses       2306     2311      +5
- Partials       35       39      +4

Impacted Files
Coverage Δ

gedcomq/main.go
0% <0%> (ø)
:arrow_up:

gedcomq/question_mark.go
100% <100%> (ø)
:arrow_up:

gedcomq/variable.go
100% <100%> (ø)

gedcomq/token.go
100% <100%> (ø)

gedcomq/accessor_expr.go
82.89% <100%> (ø)

gedcomq/length.go
100% <100%> (ø)
:arrow_up:

gedcomq/engine.go
100% <100%> (+25%)
:arrow_up:

gedcomq/variable_expr.go
100% <100%> (ø)

gedcomq/parser.go
87.95% <87.65%> (-5.8%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64856c...17cb74a. Read the comment docs.


TabContainer's tab_changed signal runs every time you click tab

Operating system or device - Godot version:
v2.1.2 (on Steam)
Issue description:
The tab_changed( int tab ) does not only run when you change tab, it also runs when you select a tab regardless if you are changing it. (Video example at 6:06'ish)
Steps to reproduce:

Create a TabContainer with a few tabs.
Setup the "tab_changed( int tab ) signal from TabContainer
Make it print some text when the signal runs
Play the scene and click the same tab over and over again

Link to minimal example project:
https://mega.nz/#!oQNxCZTJ!k2o2y6I5do4fqKFkaE9abWSRIRY91VD4z1VJxXHQMaw (Project used in the video example)

I don't think this is a bug, in fact, it is advantageous as is. It is the programmer's job to check if current tab has been changed. By comparing current tab number with a local variable in tab container script, initialized at _ready() function. I rely on current behavior.

Well, actually, it is called tab_changed. not tab_clicked, so it makes sense to have no signal for repeated clicks of the same tab.
@RebelliousX Can you give a concrete example of the "advantageous" part? I see no common uses for this behaviour (but, if there are common uses, we can add another signal without autochecking).

@RebelliousX - If that were true, the signal name would be misleading and should have been changed to tab_selected.

@bojidar-bg I use it in a multiviewport setting in one of my projects, to reload the scenes without switching tabs.
Besides, I remember not to long ago, I complained about something similar, that if a variable that has a signal (setter/getter), the setter functions will be called even if the value doesn't change.
Suppose there is a setter function for variable x, which currintly has the value of 5. If you later say x=5 then the setter function will be called again. It was decided by the majority that it was the intended behavior, which I came to accept.
What I mean by this, if the signal of tab switching is using the same principle of signals for variables, then it shouldn't contradict that.

One thing is that detecting duplicate tab_changed emmision needs additional bookkeeping in the form of a variable + an if statement + an assignment, while the duplicate set_x call needs just an if statement to check.
Another is that the signal's name implies that the tab changed, while the set X function's name doesn't imply that it can't be called for with a value returned by the get X function.

Well, I have no complains if the nameof the function changes.let it be tab_clicked or tab_selected or even tab_set. But functionality wise, it souldn't change IMO.

changing current signal's name to "tab_selected" and adding a new signal named "tab_changed" with intended behaviour is a better approach I think.

As I mentioned in #7752, I don't think that a tab_selected signal that is only emitted when the current tab is selected makes sense.
IMO, tab_changed should be renamed to tab_selected (and continue emitting a signal regardless of the tab being selected, whether a different one or the current one), and then if there's a use case for it, tab_changed could be readded for when it's a different tab and the actual change is happening (not just the click event).
So basically similar to what #7805 does but without limiting tab_selected to the current tab, that's a bad API.

@akien-mga That would break compatibility with existing code that relies on that signal. The user won't know what went wrong, that is, tab_changed changed to be tab_selected.
BTW, is there a reason why the tab class is almost identical (with maybe some differences) to TabContainer?

Aren't we in a compatibility-breaking phase anyway? I prefer that we use that opportunity to make things more user-friendly. I'm leaned to believe that more people find strange that tab_changed is emitted when the tab is not changed than the ones that rely on such behavior.

Ok, I closed that PR and created another with the changes you suggested #7916


perf: update indexedb persistor to store queries separately

re: our discussion yesterday, took a stab at writing our own persistor client.

seems much slower actually, I guess because we're separately awaiting each query to be read from the cache on restore.

might have been a temporary issue with the dev moon I was using, seems fine now.

Won't delete the branch, just closing the PR for now.


Merge mqttv5 quic protocol layer into mqttv311 quic protocol layer

shouldnt it be merged before 0.22.0 release?

Nope. I didn't do that because there were too many differences between those two files that needed to be handled.


MINOR: fix error in quota_test.py system tests

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@rajinisivaram could you review?
All 9 system tests pass: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-10-15--001.1602776749--rondagostino--rtd_fix_system_tests_due_to_KAFKA-10131--bee4bbfc9b/report.html

Merging to trunk without waiting for builds since this is only changing a system test.


[WIP] boost sum-product

Provides boost_algo API for speeding up the sum-product computation.
Added dependencies: OMEinsum and MLStyle.
Example
algo = compile_algo("../examples/problems/paskin/paskin.uai");
algo2 = boost_algo(algo)
eval(algo2)

A preliminary benchmark shows a ~4x speed up, however the result is incorrect.

Code for benchmark
using JunctionTrees

problem_number = "34"
problem_filename = joinpath("Promedus_" * problem_number)

problem_dir = joinpath("examples/problems/Promedus/", problem_number)
uai_filepath = joinpath(problem_dir, problem_filename * ".uai")
uai_evid_filepath = joinpath(problem_dir, problem_filename * ".uai.evid")
uai_mar_filepath = joinpath(problem_dir, problem_filename * ".uai.MAR")
td_filepath = joinpath(problem_dir, problem_filename * ".tamaki.td")

reference_marginals = JunctionTrees.read_uai_mar_file(uai_mar_filepath)
obsvars, obsvals = JunctionTrees.read_uai_evid_file(uai_evid_filepath)

# ------------------------------------------------------------------------------
# Posterior marginals given evidence
# ------------------------------------------------------------------------------

algo = compile_algo(
            uai_filepath,
            uai_evid_filepath = uai_evid_filepath,
        )
eval(algo)
@time run_algo(obsvars, obsvals) |> x -> map(y -> y.vals, x);  # run twice

# boost the algorithm using OMEinsum
eval(boost_algo(algo))
@time run_algo(obsvars, obsvals) |> x -> map(y -> y.vals, x);  # run twice

Benchmark result
Before:
0.264508 seconds (94.18 k allocations: 47.904 MiB, 8.46% compilation time)
After:
0.060672 seconds (127.25 k allocations: 16.023 MiB, 53.52% compilation time)


PurgeOnStartup has no effect

Is this a bug report?
Yes

Can you also reproduce the problem with the latest version?
Yes
Environment

Operating system: Windows Server 2019
Visual Studio version: 2019 version 16.5.5
Dotnet version: 4.6.1
RabbitMQ: 3.8.2

Steps to Reproduce

I use a shared assembly with a class to create the bus:

public class MassBus
{
    public delegate void DataEvent(cmData data);

    public event DataEvent OnNewCMData;

    IBusControl bus;

    public void Connect(string QueueName)
    {
        bus = Bus.Factory.CreateUsingRabbitMq(cfg =>
        {
            cfg.Host(new Uri("rabbitmq://localhost"), host =>
            {
                host.Username("user");
                host.Password("password");
            });

            cfg.ReceiveEndpoint(QueueName, ep =>
            {
                ep.PrefetchCount = 1;
                ep.PurgeOnStartup = true;

                ep.Handler<cmData>(HandlecmData);

            });
        });
        bus.Start();
    }

    private Task HandlecmData(ConsumeContext<cmData> context)
    {
        return Task.Run(() =>
        {
            OnNewCMData?.Invoke(context.Message);
        });
    }

    public Task PublishAsync(cmData data)
    {
        return bus.Publish(data);
    }

    public void Publish(cmData data)
    {
        bus.Publish(data).Wait();
    }

    public void Close()
    {
        bus.Stop();
    }
}

Startup a publisher console app to publish 10 messages

static void Main(string[] args)
{
   Console.WriteLine("Start Sender...");
   var myBus = new MassBus();

   myBus.Connect("Sender");
   for (int i = 0; i < 10; i++)
   {
      myBus.Publish(new cmData { MsgID = i.ToString() });
      Console.WriteLine($"Published: {i}");
      Task.Delay(100);
   }
   Task.Run(() => myBus.Close());
}

Start the receiver console app to receive the messages

static void Main(string[] args)
{
   Console.WriteLine("Start Receiver...");
   var myBus = new MassBus();
   myBus.OnNewCMData += MyBus_OnNewCMData;

   Task.Run(() => myBus.Connect("Receiver"));

   Console.WriteLine("Press Key to Close...");
   Console.ReadLine();
   Task.Run(() => myBus.Close());
}

private static void MyBus_OnNewCMData(cmData data)
{
   Console.WriteLine($"Received: {data.MsgID}");
}

Expected Behavior

I would expect the receiver to not show any received messages.
Actual Behavior
It does receive all 10 messages. In a previous version of MT version 2.10.1 the same principle worked.

Reproducible Demo

I doubt I can reproduce this, PurgeOnStartup has always worked and I don't see why it would have changed.

As mentioned, it works fine in the old version but we are upgrading and now, on my dev VM,  it does not. Do you anything wrong in the code or can you point me in other directions how to fix this? I fixed my problem by putting the ep.AutoDelete parameter to 'true' which probably is a cleaner methode anyway.

Hey, I want to apologize. You actually did find a bug that was introduced a year ago. Thanks for finding it, I'll add it to the list to be fixed in 7.0.1.

Thanks for checking and fixing!

I found this thread by trying to around issue https://github.com/MassTransit/MassTransit/discussions/3853
I tried to set PurgeOnStartup (see screenshot) in a couple of places, but the queues are not cleaned up when the service starts.

No idea what version of MassTransit you're using (your configuration is seriously outdated) but it should work as long as they are no consumers active on the queue.


ocamlPackages.ppx_blob: 0.2 -> 0.4.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ocamlPackages.ppx_blob

Success on aarch64-linux (full log)
Attempted: ocamlPackages.ppx_blob
Partial log (click to expand)
post-installation fixup
moving /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0/doc to /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0
shrinking /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0/lib/ocaml/4.06.1/site-lib/ppx_blob/ppx.exe
shrinking /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0/lib/ocaml/4.06.1/site-lib/ppx_blob/ppx_blob.cmxs
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0/lib
patching script interpreter paths in /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0
checking for references to /build in /nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0...
/nix/store/b8jbj0zdrbw8xpkaz5zy0chrlybb21vk-ocaml4.06.1-ppx_blob-0.4.0

Success on x86_64-linux (full log)
Attempted: ocamlPackages.ppx_blob
Partial log (click to expand)
post-installation fixup
moving /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0/doc to /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0
shrinking /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0/lib/ocaml/4.05.0/site-lib/ppx_blob/ppx.exe
shrinking /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0/lib/ocaml/4.05.0/site-lib/ppx_blob/ppx_blob.cmxs
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0/lib
patching script interpreter paths in /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0
checking for references to /build in /nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0...
/nix/store/4pxjd2v6n2npcazrhw0qg6kqxms3gwid-ocaml4.05.0-ppx_blob-0.4.0

Success on x86_64-darwin (full log)
Attempted: ocamlPackages.ppx_blob
Partial log (click to expand)
The full test results are available in `_build/_tests`.
Test Successful in 0.001s. 2 tests run.
installing
Processing file ppx_blob.install as ppx_blob.
post-installation fixup
moving /nix/store/10pq656qhs5spywlw7v15a2iw275x4js-ocaml4.05.0-ppx_blob-0.4.0/doc to /nix/store/10pq656qhs5spywlw7v15a2iw275x4js-ocaml4.05.0-ppx_blob-0.4.0/share/doc
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/10pq656qhs5spywlw7v15a2iw275x4js-ocaml4.05.0-ppx_blob-0.4.0/lib
patching script interpreter paths in /nix/store/10pq656qhs5spywlw7v15a2iw275x4js-ocaml4.05.0-ppx_blob-0.4.0
/nix/store/10pq656qhs5spywlw7v15a2iw275x4js-ocaml4.05.0-ppx_blob-0.4.0


[PDI-17471] Preview Dialog has sporadic behavior and no error logging

@pentaho-lmartins @pentaho/tatooine

:white_check_mark: Build finished in 10m 17s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1125, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 17s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1125, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 16m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMqttStreamSingleTopic (click to expand)
${result.errorDetails}

Tests run: 1122, Failures: 1, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 16m 40s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1122, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 15m 21s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.mqttReadsBinary (click to expand)
${result.errorDetails}

Tests run: 1123, Failures: 1, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 48s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1123, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 16m
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1123, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 16m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1123, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 39s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1123, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 58s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1125, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 51s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1125, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 58s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1125, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 13m 14s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 8s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 33s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 38s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 43s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 15m 54s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1126, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 52s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1130, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 20s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1131, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 14m 17s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1131, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 12m 40s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1131, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 12m 39s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1131, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:x: Build failed in 4m 16s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message

:x: Build failed in 4m 17s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message


improper handling of Regular Expressions

Tab Modifier RegEx
Browser: Opera
Extension version: 0.22.0
Can be found here: https://addons.opera.com/en/extensions/details/tab-modifier/
The way this Extension implements Regular Expressions is wrong!
Your example RegEx does not escape special characters (the forward slash in this case):
github[.]com/([A-Za-z0-9_-]+)/([A-Za-z0-9_-]+)
correct RegEx should be like this:
github[.]com\/([A-Za-z0-9_-]+)\/([A-Za-z0-9_-]+)
or
https?:\/\/(|w{3}\.)github\.com\/([\w-]+)\/([\w-]+)
to match the protocol and web standard
Example RegEx to match a webpage:
https?:\/\/(|w{3}\.)example\.com\/([\w-]+)\.html
would match following sites:
http://www.example.com/page_1.html
https://www.example.com/page_2.html
http://example.com/page_1.html
https://example.com/page_2.html
I created two sample sites on my domain for testing purpose:
http://1info.tk/page1.html
http://1info.tk/page2.html
Their current page title is "Hello World!"
What would be the correct syntax for your Extension to change their titles to "Testpage 1" or "Testpage 2" respectively?
A proper RegEx for matching could be:
https?:\/\/(|w{3}\.)1info\.tk\/([a-zA-Z-]+)([0-9])+\.html
and the corresponding proper RegEx for replacing:
Test\2 \3

Hello,
Check out the source: https://github.com/sylouuu/chrome-tab-modifier/blob/master/src/js/content.js
Search for new RegExp you'll find out how the way it's handled.
Best

Thanks!
It seems that I made a mistake in the pattern. The forward slash doesn't need to be escaped. If escaped the pattern doesn't match.
As in ECMAScript-262  the following characters should be escaped:
^ $ \ . * + ? ( ) [ ] { } |
Kind regards
Pete