Main Project Cleanup

Description

Clean up of the main source code project
Removed irrelevant files
Added support for .NET 4.7, .NET 4.8
Removed preprocessor to enable events registration for all
Updates to the SvgOptions class to support key-value properties. Will use it to resolve issue raised in #987
Split ItemGroup for references into supported Frameworks, so dependent package versions can be separately updated.
Resolved main concern in #1019

Type of change

[x] Removed https://svg.codeplex.com/ and https://svg.codeplex.com/license from description.
Why? Links no longer exist.
[x] Removed Microsoft.NETFramework.ReferenceAssemblies
Why? SDK-style projects include this reference by default.
Ref: https://learn.microsoft.com/en-us/dotnet/framework/migration-guide/reference-assemblies
[x] Dropped <Title>Svg for .Net Framework 4.6.2</Title> in project file for simplicity.

Why? Per-package title is not used/displayed by Visual Studio or nuget.org

[x] Removed DisableImplicitFrameworkReferences for .NET 4.6.2

Why? Not applicable

[x] Removed .NET 4 support preprocessors, like

Enum.TryParse: Is supported on all current platforms
string.Join(String, IEnumerable):  Is supported on all current platforms

[x] Dropped Svg.Enums.TryParse for System.Enum.TryParse: No longer needed
[x] Removed irrelevant files

NuGet.Config: Empty NuGet configuration file
Svg.csproj.vspscc: Old MS Teams file
Svg.nuspec: Unsed NuGet package file
Svg.sln.DotSettings: Empty reshaper file
Svg.vsmdi: MSTest file
Local.testsettings: MSTest file
TraceAndTestImpact.testsettings: MSTest file

[x] Clean up (non-breaking change which fixes an issue)
[x] This change does not require a documentation update
[ ] Resolved review issues.

How Has This Been Tested?

[x] SvgW3CTestRunner is tested for each supported platform
[x] Svg.UnitTests tested on command line for each supported platform
[x] Svg.Benchmarks tested on command line for each supported platform, warnings are as before will be addressed later.

@mrbean-bremen Sorry for the crazy tabs, I have fixed it.
I only applied Edit -> Advanced -> Format Document, but unfortunately the tabify option is still on in my current machine.

Looks good to me, but I would want to have @H1Gdev have another look.

Thanks, trying to add him to the reviewers, but the name is not showing up.

Thanks, trying to add him to the reviewers, but the name is not showing up.

I also had tried to add him to the contributors. Anyway, he will get notifications from mentioning. And I think he is in a similar timezone as you, so it should be easier for you to communicate ;)

@mrbean-bremen  Unfortunately, not all interpolation modes will allow the SVG-log to pass the tests. So, I set the default as Default, let any user who wants to experiment with his/her desire mode of interpolation to use the SvgOptions.
Since this is not a W3C test file, I do not know how the reference PNG is created.

@mrbean-bremen @H1Gdev Sorry, if it OK with you, I will merge this PR.


Deprecate mapped outputs

Instead of using
@OutputFiles Map<String, File> reportOutputs

use
@Nested Map<String, Report> reports
...

class Report {
    @OutputFile File reportLocation
}

What is the incentive to do this? Out of nowhere, it just feels like an arbitrary complication of something that used to be simple to do.

@melix We introduced the mapped outputs version of outputs as a quick workaround when the AGP plugin required this kind of feature. Later, we started supporting nested polymorphic inputs for Maps and we think that is what should be used if a dynamic number of inputs or outputs is required.
If we continue supporting Map<String, File> for outputs, then we probably should also support Map<String, File> for input files (@InputFiles/@InputDirectories).
It seems like the use case is not very frequent, and the main ones we saw are better solved using @Nested, for example for the different kinds of reports of code quality tasks.
Note that you can use a simple Iterable<File> as @OutputFiles, which is enough for most use cases, so no Map required.
Do you have a compelling use-case for using mapped output files?

I don't have a specific use case, but I just recognize that having to create a Report class as one level of indirection to do this seems redundant. I understand we support Iterable<File> but in this case it means we should also deprecate and require @Nested Iterable<Report>. I'd be happier if we special cased types we know about.

I'd like to add as a user (by coincidence I've encountered exactly this issue yesterday - see #8646), that it makes no sense to me why Iterable<File> are supported and Map<String, File> are not and  require a level of indirection. There seem to be no conceptual difference between these two cases, because in both of them we have a collection of Files (and you can get Iterable<File> from Map<?, File> just by calling the values() method).
In my particular use case (referenced in that ticket) the map of files is the semantic input of the task, and the necessary wrapper would have no semantic meaning at all, so my map would look like MapProperty<String, FileWrapper> since there is no better name for the value type.
But I do agree that this kind of distinction between inputs and outputs is even worse. Either both input and output properties should not allow maps with files (and this should be pointed out in documentation), or both should be allowed.

Oh, and by the way - for my use case this would require introducing two wrappers for files, because in one task I have this Map<String, File> as @OutputFiles, and in another task I have them as @InputFiles. Therefore, to connect these two tasks I would also need to apply a conversion method. This looks like a really great pain without any reason.

We decided not to deprecate mapped output files, but support mapped input files as well.

I just want to mention, for completeness, that there is one advantage with your technique @wolfs, which is that the nested object can mix inputs and outputs:
@Nested
Map<String, Whatever> config

class Whatever {
    @InputFile File inputFile
    @OutputFile File outputFile
}


CLI ETA?

Hey,
Thanks for this one!
I'd like to test on a React Native using CLI.
Is there an ETA?
Pasting in a code editor didn't work :(

@j2l , hi, thanks.
Can you please show which code doesn't work? Or what error are you getting in dev-tools. Thanks.

Thanks for replying quickly!
First I tried to paste some react native code in a online editor (from Under the hood ReactJS) and svg wasn't produced, no error seen.
Then I tried CLI: npm i -g js2flowchart installed it but jsflowchart is a unknown command.

Hey, it wasn’t implemented yet, that’s why it didn’t work like global install. I pushed a CLI feature yesterday, please update js2flowchart from npm and try again. Thanks. Let me know if still have issues.

Cool!
But it doesn't like some react native:
js2flowchart App.js
Error at parseCodeToAST: Unexpected token (51:8)
C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:18131
        throw e;
        ^

SyntaxError: Unexpected token (51:8)
    at Parser.pp$5.raise (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:13702:13)
    at Parser.pp.unexpected (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11009:8)
    at Parser.pp$1.parseClassProperty (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11819:50)
    at Parser.pp$1.parseClassBody (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11764:34)
    at Parser.pp$1.parseClass (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11654:8)
    at Parser.pp$1.parseExport (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11890:19)
    at Parser.pp$1.parseStatement (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11132:74)
    at Parser.pp$1.parseBlockBody (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11516:21)
    at Parser.pp$1.parseTopLevel (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:11026:8)
    at Parser.parse (C:\Users\pm\AppData\Roaming\npm\node_modules\js2flowchart\dist\js2flowchart.js:10921:17)

@j2l, there is a code
state = {
    appIsReady: false
  };

inside of class definition. It's not like es6 way of doing that and I use es6-only parser which doesn't like it  (it's not valid actually from that point of view), so it breaks there. So if you remove that 3 lines and try without it, you'll see it works fine.

Indeed :)
Fixed for me.
Cheers!


UI bug in case search haven't data

Version test: v1.0.6(185)

[x] Search provider
Devices test: IP 11

[ ] Search Account, Token
Devices test: Android

Need more discussion in case use KeyboardAvoidingView in android

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-187-829-merge-2023-06-29T03-02-46.apk
Validation passed.


--terragrunt-tf-logs-to-json logs are out-of-order

Describe the bug
Terraform logs appear out-of-order when --terragrunt-tf-logs-to-json flag is enabled, but not in every cases. I can successfully reproduce with the below code:
Steps To Reproduce

Create following files

==> main.tf <==
variable "foo" {
  default = ""
}

resource "null_resource" "foo" {
  count = 2

  lifecycle {
    precondition {
      condition     = var.foo == "foo"
      error_message = "invalid variable value"
    }
  }
}

data "google_compute_image" "image" {
  count = 2

  family  = "debian-12"
  project = "debian-cloud"

  depends_on = [
    data.google_compute_image.image
  ]
}

==> terraform.tfvars <==
value1 = "1"
value2 = "2"
value3 = "3"
value4 = "4"

==> terragrunt.hcl <==
terraform {
  source = "."
}

Execute terragrunt plan:

terragrunt plan --terragrunt-json-log --terragrunt-tf-logs-to-json 2>&1  | jq .msg -r

Expected behavior
I would expect logs to appear in order, as when the --terragrunt-json-log --terragrunt-tf-logs-to-json flags aren't set. Running the command with GOMAXPROCS=1 seems to work around the bug.
GOMAXPROCS=1 terragrunt plan --terragrunt-json-log --terragrunt-tf-logs-to-json 2>&1  | jq .msg -r

Nice to haves
Logs appear in a different order after every runs. See screenshots:

Versions

Terragrunt version: terragrunt version v0.59.3
OpenTofu/Terraform version: Terraform v1.6.6
Environment details (Ubuntu 20.04, Windows 10, etc.): darwin_amd64, macOS Somona 14.5 (23F79)

Additional context
I tried recompiling Terragrunt, switching the logrus format to time.RFC3339Nano to use jq to sort lines by timestamp, but the timestamps are also output out-of-order.
Output seems correct with GOMAXPROCS=1 set on the terragrunt process.
Setting GOMAXPROCS for Terraform only doesn't change the output ordering.
terraform {
  source = "."
  extra_arguments "default" {
    commands = ["plan"]
    env_vars = {
      GOMAXPROCS = "1"
    }
  }
}

Ok, it looks like it's stdout and stderr being mixed as they aren't using the same logger. I have to split log outputs by level to get a clean output.

maybe I don't understand your initial message but the null_resource and data google_compute_image resources are independent of each other, the underlying execution engine will schedule each of them to run in a goroutine and there is no guarantee on the order they will be finish, when you set the GOMAXPROCS you are allowing only one of them to be schedule at a given time.

maybe I don't understand your initial message but the null_resource and data google_compute_image resources are independent of each other, the underlying execution engine will schedule each of them to run in a goroutine and there is no guarantee on the order they will be finish, when you set the GOMAXPROCS you are allowing only one of them to be schedule at a given time.

Hi again, the output is out-of-order unless I run terragrunt using GOMAXPROCS=1. Any GOMAXPROCS value on the terraform process won't change the resulting output.
I investigated further after posting and it looks like this is related to the usage of separate writers for stdout and stderr.


Add a way to skip parameter updates when the gradient is None

When the gradient of a parameter is None, GradientMethod currently overwrites it by a zeroed array and passes it to the update_one method. Sometimes we want to skip the update of such a parameter. I don't know if it should be the default behavior (since it changes the definition of updating rule of each optimization method, and the current one is correct in a strict sense), but at least we need to provide an option to enable user to skip such updates.

Is anyone interested in it?

Close since it's ignored for a long time. Feel free to reopen or make a new one if you are interested in it.


Property 'attributes' missing on pt_BR lang

Tried to validate an property with in rule and a undefined error was caused
Cannot read property 'hasOwnProperty' of undefined
messages.js:52:41
I checked other lang files ('en', 'ru', etc) and that ones have the 'attributes' property with a empty object.

@LiserLine ya we have cleared up all the language files and have missing attribute. We had some commits messed up so we broke a few different languages.
We have a new build prepped which will be released to the wild early next week


Numeric input shows invalid on floats

I use this code to generate a numeric input <input class="mdl-textfield__input" pattern="-?[0-9]*(\.[0-9]+)?" name="urenOpWeekbasis" type="number">.
When I type 500 everything is fine, 500**.** is fine as well but when I type 500**.5** the input turns red.
I've tested the pattern on https://regex101.com/#javascript and it works there.

What I learned from my many failed attempts at resolving this is the fact that input type="number" by default has step="1", which doesn't allow decimals. Setting step="any" would resolve this. Also another important thing is input type="number" ignores pattern. If you want to use pattern, use input type="text". I know it's weird.

Closing as this isn't a problem with the code we provide but instead and implementation issue.


#127 bump kafka version and release version

Upgrade Kafka version to <IP_ADDRESS> and update release version/changelog
Fixes #127

@original-brownbear change the version and merge it in!


Cite thing in the top black bar

just a suggestion

translated: click on cite, open new page with citable items? Please specifcy

Yes or just go to the bottom where citations are. If you think it’s
unnecessary just ignore this issue :)
On Tue 26. Jul 2022 at 13:25, Christian Dallago @.***>
wrote:

translated: click on cite, open new page with citable items? Please
specifcy
—
Reply to this email directly, view it on GitHub
https://github.com/sacdallago/embed.predictprotein.org/issues/24#issuecomment-1195358282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARN46TRCGRDCLKUV2Y7BHF3VV7DK3ANCNFSM54SLJWCA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Update Required] usePath is deprecated in new Skia version

undefined is not a function (near '...(0, _$$_REQUIRE(_dependencyMap[5], "@shopify/react-native-skia").usePath)
Hey, great work putting together this library! Was integrating it into a project of ours and noticed that usePath isn't used in the latest Skia version and has created a breaking change.
Was wondering if you could update the Squircle.tsx file to accommodate for this new change?
Best!

hi thanks for your interest!
but i am not in the situation to fix it up…
can you make a pull request for me? and i think i can handle it. otherwise i won’t be able to handle it as you want..(
sorry to say this but still thanks for your interest!
best :)

Hey, makes sense.
Currently also don't have the time but will try to make time for it in the coming weeks to submit the PR.
The current solution is locking the version number of Skia in the package.json ->   "@shopify/react-native-skia": "0.1.118",


Add user id to slack message

Because of GDPR we are required to keep track of which user created each message, so that we can delete them if asked to.

@jobergum, I have a new PR that needs a review. 🧑🏭

Probably not! It should just be able to delete messages based on user ID. Should I remove indexing then?

And I don't have the permissions to merge


Prefixed nix install: can't find glibc

Issue description
Following the instructions at https://nixos.org/wiki/How_to_install_nix_in_home_(on_another_distribution), I bootstrapped a nix installation.  However, now when I run nix-env under the nix store, I get the errors below
(Note I downloaded and compiled nix 1.11.2 and installed it via nix-env, but when that didn't work I also installed and tried nix-1.12pre ).  Shouldn't the new nix be self contained under the nix-store?
glib-2.23 is installed there.
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by nix-env)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by nix-env)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixexpr.so)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixexpr.so)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/vhvaab4kmd5wzz1lpgk4lbrihf7fiakw-boehm-gc-7.2f/lib/libgc.so.1)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixmain.so)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixmain.so)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixstore.so)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixstore.so)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixutil.so)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixutil.so)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixformat.so)
nix-env: /source/gcc/4.9.2//lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /data/pnl/soft/nix/store/i8ka115v5hvyav7c72yjjvjv8pw39djg-nix-1.12pre4523_3b81b26/lib/libnixformat.so)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/cj50l9i33p427myw791m304r22ysd0sb-openssl-1.0.2h/lib/libcrypto.so.1.0.0)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/lh5gin2y58b0z1d68jrr1l477wrwdwgl-libsodium-1.0.10/lib/libsodium.so.18)
nix-env: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /data/pnl/soft/nix/store/wjdl2b28g5rz1bkx80379q0kb0wyq648-xz-5.2.2/lib/liblzma.so.5)
nix-env: /lib64/libc.so.6: version `GLIBC_2.17' not found (required by /data/pnl/soft/nix/store/wjdl2b28g5rz1bkx80379q0kb0wyq648-xz-5.2.2/lib/liblzma.so.5)

Steps to reproduce
Follow directions at
https://nixos.org/wiki/How_to_install_nix_in_home_(on_another_distribution) to bootstrap
nix 1.11.2 with gcc 4.9.2 and its libs, and then run newly installed nix-env after logging back
into the shell, using the full path to nix-env in the store.
Technical details

System: Red Hat Enterprise Linux Server release 6.5,  x86_64 GNU/Linux

This might better fit into the nix repository directly.

Unsetting LD_LIBRARY_PATH fixes this issue.  See also NixOS/nix/issues/902.
And as per @vcunat's comment in NixOS/nix/issues/902, I confirmed that the system ldd will show that the nix binaries rely on .so files in system paths such as /lib64/, but using the ldd in the nix store will show the real paths used during runtime, all which point to the nix store.


lstrip vs. dropwhlie

I notice more_itertools.lstrip is similar to itertools.dropwhile:
import itertools as it

import more_itertools as mit

iterable = [0, None, 1, 2, 0, 3, None, 0]
pred = lambda x: x in {None, 0}

list(mit.lstrip(iterable, pred))
# [1, 2, 0, 3, None, 0]

list(it.dropwhile(pred, iterable))
# [1, 2, 0, 3, None, 0]

I recall lstrip is a derivative of strip, but It may be worth noting in the docstring the similarity between lstrip and dropwhile (see #122).

This is intentional; lstrip is only there as a companion to rstrip. The former is just another name for dropwhile, but the latter is more complicated.

Understood, as evident in the [source][1].  I'm suggesting a minor note in the docs for clarity.  Example:

Note that this a wrapper of dropwhile() from the itertools module.


I can't use the vue devtools in vscode-devtools

vscode:

chrome devtools:

Unfortunately all chrome browser extensions are managed by the chrome browser itself, and can't be used by the stand alone devtools I'm using for vscode. This means that the Vue devtools extension won't show up in the vscode devtools.
I don't know of a good way to fix this without changes to chrome itself so I don't think I'll be able to fix this any time soon.

Same goes for React Dev tools too I guess. I came across this https://discuss.atom.io/t/solved-unable-to-load-react-devtools-in-a-webview/42607 maybe it is possible to add?

You can set it as your new release aim. I have an idea you can make the extension understands Vue as HTML and open it in another window. I think this wouldn't be hard.

Is someone here?

Sorry, I haven't had a whole lot of time to look into this (or in general). I think you would need to modify the extensions in order for them to no longer require content scripts since they aren't available over CDP.
Work to enumerate the extensions and actually load them would also need to be done since this isn't going to be provided when not running directly in the browser.
To be clear, the devtools used here are the chrome devtools frontend ones available via npm. This isn't running the full embedded browser ones like electron and chrome use as there is no way to do that currently.
It would probably be easier to just create a standalone react/Vue extension for vscode rather than trying to add it here.
Is there some special integration that the extensions do with the other parts of the devtools that would be lacking in a standalone vscode ext?

@CodeMooseUS In fact, the Vue Team has already created a standalone Vue DevTools that works in Electron or can be hosted (if you review the architecture). I'm not sure the React Extension is setup the same way however.
https://github.com/vuejs/vue-devtools/blob/master/shells/electron/README.md


Make Linter requirements for PR more prominent

Currently it's not clear to contributors that they'll need to run lint before submitting PRs. We need to make this more prominent and easier.

Closing this as I think it's addressed by #842


setAccessibilityDelegate and getSelectionStart() like Edittext

Hello.

I need to get cursor position when I touched on text like EditText but a didn't find it.

Example for Edittext
EditText edittext = findViewById(R.id.title);
int currentCursor = 0;
editText.setAccessibilityDelegate(new View.AccessibilityDelegate() {
public void sendAccessibilityEvent(View view, int eventType) {
super.sendAccessibilityEvent(view, eventType);
if (eventType == AccessibilityEvent.TYPE_VIEW_TEXT_SELECTION_CHANGED) {
currentCursor = editText.getSelectionStart();
}
}
});

How can I do like this editText.getSelectionStart() and getSelectionEnd()  for RichTextEditor
I have dublicates font family, Android 5.1

Hi,
i don't know if i can help you with all your problems.

Actually i don't even know what setAccessibilityDelegate() does :).
I can only provide the methods of WebView. I think your request (e.g. implementing this manually) is out of scope.

Also here i don't think i can help you as the underlying implementation is done with HTML contenteditable and JavaScript.
JavaScript's window.getSelection().getRangeAt(0) would provide a start- and end index, but only relative to the element that contains to selected text.
I don't think there's a function in JavaScript to get the selection start- and end index in absolute position (do you know any?).

But depending on your use case i may can help you otherwise. What are trying to archive?
E. g. getting selected text would be no problem (at least not as plain text).

Here i think i found the culprit. As newer Android versions use a different system to store font information, there i take care that each font name only gets added once.
But as you said you're using an older Android version, there i use a simple ArrayList to collect all installed fonts. Trying to find an Android 5 phone and fix this at the weekend. Let you know if this solves the issue.

I need to get selection text for rotation screen to save it.
For Edittext I did it like this:
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
etContentView(R.layout.activity_main);
// get saved data and restore selected text before rotation screen
if (savedInstanceState != null) {
    selectionTextStart = savedInstanceState.getInt("selectionTextStart");
    selectionTextEnd = savedInstanceState.getInt("selectionTextEnd");
}

final EditText editText = findViewById(R.id.editText);

editText.setAccessibilityDelegate(new View.AccessibilityDelegate() {

	// When cursor position changed sendAccessibilityEvent will add new position selected text
	// touch anywhre on text or change position orange text slider
	public void sendAccessibilityEvent(View view, int eventType) {
	    super.sendAccessibilityEvent(view, eventType);
		selectionTextStart = editText.getSelectionStart();
		selectionTextStart = editText.getSelectionStart();
	}
});

}
protected void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);
outState.putString(Constant.TEXT, text);

outState.putInt("selectionTextStart", selectionTextStart); // put before rotation a screen
outState.putInt("selectionTextEnd", selectionTextEnd); // put before rotation a screen

}
I will try to do somethig with WebView
Image 1. I selected text.
Image 2. I have this result.

Just released version 2.0.15 (should be visible at maximum in two hours).
The font bug should be fixed now. Thanks for reporting it to me!
To restoring the selection:
That's not that easy.
I tried saving selected range with var rangeToRestore = window.getSelection().getRangeAt(0). (See https://gist.github.com/dantaex/543e721be845c18d2f92652c0ebe06aa .)
But restoring with window.getSelection().addRange(rangeToRestore) does not work as after setting html it's a new document and therefore backed up anchor element is not valid anymore.
What could work is using the JavaScript library rangy as suggested here: https://stackoverflow.com/questions/39566611/how-can-i-save-and-restore-selection-range-in-javascript
But as i already spent enough time on this, this is something what you would have to do. If you implement it and give me a pull request, i'd be glad to integrate it.
Cheers.

I just added it in AndroidManifest.xml in my

I go on test it yet.

<activity             android:name=".EditorActivity"             **android:configChanges="keyboardHidden|orientation|screenSize"**>         </activity>


Cannot use with mongoid ~> 4.0.0

https://github.com/taganaka/polipusBundler could not find compatible versions for gem "bson":
In snapshot (Gemfile.lock):
bson (1.9.2)
In Gemfile:
mongoid (~> 4.0.0) ruby depends on
moped (~> 2.0.0) ruby depends on
bson (~> 2.2) ruby
Running bundle update will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

Were you able to get this working with Mongoid (> 4.0.0) ?
Mongoid 4.0.0 depends on bson (2.2) whereas mongo (1.10/11) depends on bson(1.11). Anyway I get this working with Mongoid 4.0.0?

@sandeepravi,  Yes working on Mongoid 4.0.0


[Bug]: Damage Reduction

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
SkillAPI will not reduce damage below the base weapons damage (Vanilla items, did not test prorpgitems)
Tested in PvP, the damage reduction should still work on mobs
My results (Player that got hit had 70% damage resist from attributes):

Hand - 0.3 damage
Wooden sword - 4 damage, with sharpness 5 still 4 damage
Golden sword - 4 damage, with sharpness 5 still 4 damage
Stone sword - 5 damage, with sharpness 5 still 5 damage
Iron sword - 6 damage, with sharpness 5 still 6 damage
Diamond sword - 7 damage, with sharpness 5 still 7 damage
Netherite sword - 8 damage, with sharpness 5 still 8 damage

Wooden sword sharpness 5 with attributes that boost damage:

With attribute that gives 4.5x damage (31 damage total) - 9 damage

Expected Behavior
Damage to go below base vanilla weapon
Steps To Reproduce
You need 2 players to test this, 1 dealing damage and 1 taking damage
The one that is taking damage needs to have an attribute that reduces physical damage
The one dealing damage needs to do the following:

Test with a normal vanilla weapon (no enchants no attributes)
Test with adding adding more damage to the weapon (either more sharpness levels or an attribute that increases damage)

Environment
- Server Software: Paper 1.17.1-328
- ProSkillAPI Version: <IP_ADDRESS>-ALPHA
- ProMCCore Version: <IP_ADDRESS>-ALPHA

latest.log
No response
Anything else?
No response

Do you also have ProRPGItems installed? If so, have you tried testing without it?

Indeed it is ProRPGItems

Indeed it is ProRPGItems

So are you meaning that RPGItems is actually the culprit here? It's not a problem with SkillAPI as much as compatibility between RPGItems and SkillAPI?

Without RPGitems it works as intended. Not sure what happened but it affected vanilla items that did not have any custom stats from RPGitems

Turns out this issue affects skills as well.
I made a skill that does 1 damage and with wooden sword in hand I do 4 damage (5 stone, 6 iron, 7 diamond).
Without the sword I do normal intended damage.

Forgot to mention that the skill damage was tested on a normal zombie and that it didnt have any resists or anything


REST API Token is not Working...

Well... If i generate a Token... "You need to specify a Token". If i Copy the Token from the API help Website: "You need to specify a Token".
I dont know what im doing wrong...

You can get your token by clicking "Make token visible" and copying from the text box:


Getting Error 405 Method Not Allowed for create NFT, create account etc.

My colleague and I recently tried to follow the instructions for the one click deploy on vercel but we both get a 405 Method Not Allowed when doing the create NFT or create Account calls.
Has anyone done them recently?
I have tried with https://serverless-hedera.vercel.app/ and with https://serverless-hedera-git-main-rossconsultinghts.vercel.app/. Since it is a Testnet account I am happy to provide my API key if someone wants to reproduce.

How strange, let me look into this for you.

I've deployed on my end, a new version of the repository to a new vercel installation.
And I am able to create NFTs, tokens, and Inscriptions.
I wonder if it is Vercel cold start issue, feel free to look at your logs and test some more calls.

Hi Matt,
Wow thanks so much for the rapid response!
I had a look at the Vercel logs and saw this line:
Error - Your project has an older version of ESLint installed (6.8.0).
Please upgrade to ESLint version 7 or above
I have included the rest of the logs as well in case you spot anything else.
I did a redeploy in Vercel and saw the same warning and I get the same 405
error on nft create.
It would be great if you can advise what I need to do next. I was just
following the one-click approach.
Regards
Rod
[08:56:53.509] Running build in Washington, D.C., USA (East) – iad1
[08:56:53.613] Cloning github.com/RossConsultingPrivate/serverless-hedera
(Branch: main, Commit: 42ef340)
[08:56:53.964] Previous build cache not available
[08:56:54.090] Cloning completed: 475.742ms
[08:56:54.297] Running "vercel build"
[08:56:54.791] Vercel CLI 33.2.0
[08:56:55.142] Installing dependencies...
[08:56:55.484] yarn install v1.22.17
[08:56:55.557] [1/4] Resolving packages...
[08:56:55.866] [2/4] Fetching packages...
[08:57:03.460] warning @.: Invalid bin entry for "🚘" (in
"ipfs-car").
[08:57:11.577] [3/4] Linking dependencies...
[08:57:11.580] warning "next > styled-jsx > @@."
has unmet peer dependency<EMAIL_ADDRESS>[08:57:11.580] warning " > @@."
has unmet peer dependency<EMAIL_ADDRESS>[08:57:11.580] warning " > @@." has
unmet peer dependency<EMAIL_ADDRESS>[08:57:11.580] warning @./plugin-transform-react-jsx >
@@." has unmet peer dependency @./core@
^7.0.0-0".
[08:57:17.455] [4/4] Building fresh packages...
[08:57:17.877] Done in 22.40s.
[08:57:17.906] Detected Next.js version: 12.0.7
[08:57:17.908] Running "yarn run build"
[08:57:18.098] yarn run v1.22.17
[08:57:18.124] $ next build
[08:57:18.792] Attention: Next.js now collects completely anonymous
telemetry regarding usage.
[08:57:18.792] This information is used to shape Next.js' roadmap and
prioritize features.
[08:57:18.793] You can learn more, including how to opt-out if you'd not
like to participate in this anonymous program, by visiting the following
URL:
[08:57:18.793] https://nextjs.org/telemetry
[08:57:18.793]
[08:57:18.812] Browserslist: caniuse-lite is outdated. Please run:
[08:57:18.813] npx @.*** --update-db
[08:57:18.813]
[08:57:18.813] Why you should do it regularly:
[08:57:18.813]
https://github.com/browserslist/browserslist#browsers-data-updating
[08:57:18.855] info  - Checking validity of types...
[08:57:19.118] error - Your project has an older version of ESLint
installed (6.8.0). Please upgrade to ESLint version 7 or above
[08:57:19.123] info  - Creating an optimized production build...
[08:57:19.154] info  - Disabled SWC as replacement for Babel because of
custom Babel configuration ".babelrc"
https://nextjs.org/docs/messages/swc-disabled
[08:57:19.400] Browserslist: caniuse-lite is outdated. Please run:
[08:57:19.400] npx @.*** --update-db
[08:57:19.400]
[08:57:19.400] Why you should do it regularly:
[08:57:19.400]
https://github.com/browserslist/browserslist#browsers-data-updating
[08:57:19.742] info  - Using external babel configuration from
/vercel/path0/.babelrc
[08:57:31.247] info  - Compiled successfully
[08:57:31.248] info  - Collecting page data...
[08:57:33.236] info  - Generating static pages (0/3)
[08:57:33.264] info  - Generating static pages (3/3)
[08:57:33.276] info  - Finalizing page optimization...
[08:57:33.279]
[08:57:33.299] Page                                        Size     First
Load JS
[08:57:33.299] ┌ ○ /                                       3.74 kB
74.6 kB
[08:57:33.299] ├   └ css/613fafb658682558.css              792 B
[08:57:33.300] ├   /_app                                   0 B
70.9 kB
[08:57:33.300] ├ ○ /404                                    3.08 kB
74 kB
[08:57:33.300] ├ λ /api/account/[id]/[token_id]            0 B
70.9 kB
[08:57:33.300] ├ λ /api/account/[id]/holdings/[token_ids]  0 B
70.9 kB
[08:57:33.300] ├ λ /api/account/balance                    0 B
70.9 kB
[08:57:33.300] ├ λ /api/account/create                     0 B
70.9 kB
[08:57:33.300] ├ λ /api/consensus/message                  0 B
70.9 kB
[08:57:33.300] ├ λ /api/consensus/topic                    0 B
70.9 kB
[08:57:33.300] ├ λ /api/consensus/topic/[id]               0 B
70.9 kB
[08:57:33.300] ├ λ /api/inscription/[tick]/burn            0 B
70.9 kB
[08:57:33.300] ├ λ /api/inscription/[tick]/mint            0 B
70.9 kB
[08:57:33.300] ├ λ /api/inscription/[tick]/transfer        0 B
70.9 kB
[08:57:33.300] ├ λ /api/inscription/deploy                 0 B
70.9 kB
[08:57:33.300] ├ λ /api/nft                                0 B
70.9 kB
[08:57:33.301] ├ λ /api/nft/[token_id]/mint                0 B
70.9 kB
[08:57:33.301] ├ λ /api/nft/batch                          0 B
70.9 kB
[08:57:33.301] ├ λ /api/nft/claim                          0 B
70.9 kB
[08:57:33.301] ├ λ /api/nft/metadata                       0 B
70.9 kB
[08:57:33.301] ├ λ /api/nft/transfer                       0 B
70.9 kB
[08:57:33.301] ├ λ /api/status                             0 B
70.9 kB
[08:57:33.301] ├ λ /api/token                              0 B
70.9 kB
[08:57:33.301] ├ λ /api/token/bequest                      0 B
70.9 kB
[08:57:33.301] ├ λ /api/token/send                         0 B
70.9 kB
[08:57:33.301] └ λ /api/webhook                            0 B
70.9 kB
[08:57:33.301] + First Load JS shared by all               70.9 kB
[08:57:33.301]   ├ chunks/framework-6e4ba497ae0c8a3f.js    42 kB
[08:57:33.301]   ├ chunks/main-8eac6eed8f057324.js         26.8 kB
[08:57:33.301]   ├ chunks/pages/_app-46237eb5a8b4228b.js   553 B
[08:57:33.301]   ├ chunks/webpack-0c54995ac8bc3e0f.js      1.48 kB
[08:57:33.301]   └ css/2974ebc8daa97b04.css                209 B
[08:57:33.301]
[08:57:33.302] λ  (Server)  server-side renders at runtime (uses
getInitialProps or getServerSideProps)
[08:57:33.302] ○  (Static)  automatically rendered as static HTML (uses no
initial props)
[08:57:33.302]
[08:57:33.568] Done in 15.47s.
[08:57:33.969] Traced Next.js server files in: 358.265ms
[08:57:35.332] Created all serverless functions in: 1.361s
[08:57:35.338] Collected static files (public/, static/, .next/static):
3.459ms
[08:57:35.846] Build Completed in /vercel/output [41s]
[08:57:36.062] Deploying outputs...
[08:57:45.867]
[08:57:46.118] Deployment completed
[08:57:51.794] Uploading build cache [48.49 MB]...
[08:57:53.599] Build cache uploaded: 1.805s
On Fri, Jan 26, 2024 at 12:52 PM Matt Smithies @.***>
wrote:

Screenshot.2024-01-26.at.10.50.02.png (view on web)
https://github.com/trustenterprises/hedera-serverless-api/assets/6974163/586868b7-cbaa-431a-a406-73a9efe66a9b
I've deployed on my end, a new version of the repository to a new vercel
installation.
And I am able to create NFTs, tokens, and Inscriptions.
I wonder if it is Vercel cold start issue, feel free to look at your logs
and test some more calls.
—
Reply to this email directly, view it on GitHub
https://github.com/trustenterprises/hedera-serverless-api/issues/51#issuecomment-1911865410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJAVK2C4IKOKDK3B657QPDYQODH7AVCNFSM6AAAAABCLETZBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJRHA3DKNBRGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey @RossConsulting,
Just wanted to doublecheck with you did you try your API with postman?
Here are some screenshots of me, hitting your endpoints. Obviously, I don't know your API secret - but you should see that it gets past the "405 issue", normally 405's is a symptom of using the wrong request type, so a PUT instead of a POST.
Inscription Deployment

Deploying of the NFT

As this is testnet, feel free to send me your API key (privately), and we can always change it later.

Hi Matt,
Apologies for the radio silence, I have been battling with a wrist issue
and the doc said I should lie low for a while.
I am more than happy to send you the API key, since this is in any case
just a test environment.
How do I reach you?
Regards
Rod
On Sat, Jan 27, 2024 at 3:33 PM Matt Smithies @.***>
wrote:

Hey @RossConsulting https://github.com/RossConsulting,
Just wanted to doublecheck with you did you try your API with postman?
Here are some screenshots of me, hitting your endpoints. Obviously, I
don't know your API secret - but you should see that it gets past the "405
issue", normally 405's is a symptom of using the wrong request type, so a
PUT instead of a POST.
Inscription Deployment Screenshot.2024-01-27.at.13.31.06.png (view on web)
https://github.com/trustenterprises/hedera-serverless-api/assets/6974163/1f3b92d5-a69c-4700-b2a5-3269af6067e6 Deploying
of the NFT Screenshot.2024-01-27.at.13.31.34.png (view on web)
https://github.com/trustenterprises/hedera-serverless-api/assets/6974163/5b09f108-4b58-4176-b315-3d6f827f85f6
As this is testnet, feel free to send me your API key (privately), and we
can always change it later.
—
Reply to this email directly, view it on GitHub
https://github.com/trustenterprises/hedera-serverless-api/issues/51#issuecomment-1913157720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJAVKYQRTFQ2PX3WHOSSDTYQT63BAVCNFSM6AAAAABCLETZBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE2TONZSGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add a few more type hints

Codecov Report

Merging #47 (102af9e) into main (09744e4) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 102af9e differs from pull request most recent head 000ac65. Consider uploading reports for the commit 000ac65 to get more accurate results

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          317       321    +4
=========================================
+ Hits           317       321    +4

Files
Coverage Δ

sphinxcontrib_django/__init__.py
100.00% <100.00%> (ø)

sphinxcontrib_django/docstrings/classes.py
100.00% <100.00%> (ø)

sphinxcontrib_django/docstrings/field_utils.py
100.00% <100.00%> (ø)

sphinxcontrib_django/roles.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bugs in sample_linker.py

Hi，author,
1. wrong checkpoint name
when I tried to generate linker for custom pocket and molecule with command:
"
python -u sample_linker.py
--ckpt 500.pt
--pdb_path 3WZE/pocket.pdb
--mol_file 3WZE/3wze-mol.sdf
--mask 0 1 2 3 4 5 6 7 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32
--num_atom 4
--num_samples 100
--sampling_type generalized
--batch_size 32
"
but I got a error:
"
Traceback (most recent call last):
File "/home/PMDM/sample_linker.py", line 293, in
data_list, = construct_dataset_pocket(num_samples*1,batch_size,dataset_info,num_points,None,start_linker,None,
File "/home/PMDM/utils/sample.py", line 154, in construct_dataset_pocket
atom_type_linker = torch.cat([start_linker['linker_atom_type'], atom_type])
RuntimeError: Sizes of tensors must match except in dimension 0. Expected size 10 but got size 8 for tensor number 1 in the list._
"
if I rename the checkpoint to "500_pocket.pt", this bug have been fixed.
2. missing QVinaDockingTask in sample_linker.py
QVinaDockingTask.from_generated_data(protein_filename,gmol,protein_root) line 391.

Thanks for your feedback.

I have revised the bug of sample_linker.py.
The QVinaDockingTask file exits in evaluation/docking.py. I suggest you comment this code since it is time consuming to calculate the vina score. Instead, you could evaluate them independently.

Thank you @Layne-Huang

Hi，
by, your new version sample_linker.py files, when I tried to generate linker for custom pocket and molecule with command:
"
_python -u sample_linker.py
--ckpt 500.pt
--pdb_path 3WZE/pocket.pdb
--mol_file 3WZE/3wze-mol.sdf
--mask 0 1 2 3 4 5 6 7 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32
--num_atom 4
--num_samples 100
--sampling_type generalized
--batch_size 32
"
there is not any molecule gengeraed, and I get an error of Open Babel  and Vina:
"
generated smile: [C][C][C][C][N]C([N])=O
largest generated smile part: [C][C][C][C][N]C([N])=O
Generate SA score: 0.39
Generate QED score: 0.44795408144569576
Generate logP: -0.4310400000000001
Generate Lipinski: 5
[b'1 molecule converted\n', b'/bin/bash: line 10: ./qvina2.1: No such file or directory\n', b'==============================\n', b'*** Open Babel Error  in OpenAndSetFormat\n', b'  Cannot open bzkdjhxnzncstkznbnpmukvmuncykr_ligand_out.pdbqt\n', b'0 molecules converted\n']
[Error] Vina output error: /home/PMDM/tmp/bzkdjhxnzncstkznbnpmukvmuncykr_ligand_out.sdf
'NoneType' object is not subscriptable
"
for vina “./qvina2.1: No such file or directory”， it need put the qvina in the ./tmp foler.
Then all codes run well.
But, the generate molecule is quit small, and It is only the part of linker.
How can I get the gennerated whole molecules with fragments?

It works now, thanks.


.trackTiming() 'name' is required

Without including the 'optional' name value my timing reports never showed up in GA dashboard. This stackoverflow question seems to reinforce this finding.

Thanks for the heads up. Can't do much except note this in the README. :+1:


Remove debug statement from configuration example

Description
There was a debugging statement left in the configuration example. This commit removes it.
Signed-off-by: Hal Spang<EMAIL_ADDRESS>Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: Chore
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Looks good to me !

@halspang Can this be merged ?


Recruitment: validate group not found error when adding a non existing member into a group

Process function error when the email address is a DBLP url:
https://api.openreview.net/logs/process?id=Pxlk_Zr0ijO
https://api.openreview.net/notes?id=Pxlk_Zr0ijO
This error only occurs in the API 2.

can you verify this is fixed?

Yes, this is caught and printed in the status as
{   "InvalidGroup": [     "https://dblp.org/pid/XXX"   ] }


VSCode and Ruby/Rails Debugging

I've set-up VSCode 1.45.1 with Ruby support and installed the following VSCode plugins:

Bust a Gem 0.1.8
Rails 0.16.4
Ruby 0.27.0
VSCode Ruby 0.27.0
vscode-ruby-ctags 1.4.1

I've also installed the ruby-debug-ide and debase Gems. My Ruby version is 2.5.7.
After adding the debug configuration like this:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Rails server",
            "type": "Ruby",
            "request": "launch",
            "program": "${workspaceRoot}/bin/rails",
            "args": [
                "server"
            ]
        }
    ]
}

I started debugging by pressing F5 and can see the server boot-up properly. I can also open the web-application via browser.
However, the breakpoints I've set-up are just ignored by VSCode. When I try to add more breakpoints to the code I see Not available in the Debug Console.
Am I mssing something in my setup?

Please report the issue against the ruby extension


does this tool only work on the desktop?

I looked for the chrome driver for my chrome android version but it doesn't seem to be there, and I downloaded the closest to that version and it failed, and I tried without the chrome driver and that also failed 😞

Hello, the script only works on a pc or desktop.


Allow an extension to extend quick open

In Quick Open (Cmd+P), I want to add a 'next step' action when 'No results found'.
But, I do not find a way where an extension can provide extra results or actions to Quick Open.
On the other hand, creating a command on top of the Quick Open isn't ideal.

thanks @vscodebot it isn't a duplicate


extra backslash in the pop-up blame detail's link.

GitLens Version:  v9.9.3

VSCode Version: Version: 1.39.0-insider,  latest stable version also has the problem.
OS Version: macOS Mojave 10.14.6

Steps to Reproduce:

move cursor to the git line blame, then the blame details contain some related issue links pop up;
check the end of the links

further desc:
The correct link in blame detail should be: https://somedomain.com/repo/merge_request_id,
but actually, it is: https://somedomain.com/repo/merge_request_id.
The link with an extra backslash can't be accessed by chrome except I remove the \ manually.
Check the pic below:

.

@bryceyang those links are included in the commit message itself correct?

@bryceyang those links are included in the commit message itself correct?

Hi, I checked the commit message.
The links in the origin commit message are surrounded by a pair or angle brackets.
Like: Tested-by: <https://somedomain.com/repo/merge_requests/id>
So the brackets could be the reason cause the extra backslash?


Add auth enveloped recipients for KEK and KeyAgree

Currently it is possible to use CMSAuthEnvelopedDataParser only with KeyTrans. This adds support for KEK and KeyAgree. The AEADInputDecryptor is separated to CMSInputAEADDecryptor as it is the same for all recipient types. A new test is added to properly test CMSAuthEnvelopedDataParser usage.

@ligefeiBouncycastle would you be able to check this when you have time? It's an addition to your commit https://github.com/bcgit/bc-java/commit/3eb6ed55c3dedfb3b3280e59dd3450adb378d8b3


Receiving constant "Desync" running factorio-docker 2.0.8 on arm64

Client is on x64. Tried looking around for a fix but was not able to find anything. Just want to confirm from the maintainers that if this can be related to running on arm64.
I have been running version before space age using factorio-docker for a few months on the same system without any issues. The issue started after i tried hosting a brand new space age save.

server-settings.json
`{
"name": "???",
"description": "Game hosted at home for home play!",
"tags": ["game", "tags"],
"_comment_max_players": "Maximum number of players allowed, admins can join even a full server. 0 means unlimited.",
"max_players": 1,
"_comment_visibility": ["public: Game will be published on the official Factorio matching server",
"lan: Game will be broadcast on LAN"],
"visibility":
{
"public": false,
"lan": true
},
"_comment_credentials": "Your factorio.com login credentials. Required for games with visibility public",
"username": "",
"password": "",
"_comment_token": "Authentication token. May be used instead of 'password' above.",
"token": "",
"game_password": "",
"_comment_require_user_verification": "When set to true, the server will only allow clients that have a valid Factorio.com account",
"require_user_verification": true,
"_comment_max_upload_in_kilobytes_per_second" : "optional, default value is 0. 0 means unlimited.",
"max_upload_in_kilobytes_per_second": 0,
"_comment_max_upload_slots" : "optional, default value is 5. 0 means unlimited.",
"max_upload_slots": 5,
"_comment_minimum_latency_in_ticks": "optional one tick is 16ms in default speed, default value is 0. 0 means no minimum.",
"minimum_latency_in_ticks": 0,
"_comment_max_heartbeats_per_second": "Network tick rate. Maximum rate game updates packets are sent at before bundling them together. Minimum value is 6, maximum value is 240.",
"max_heartbeats_per_second": 60,
"_comment_ignore_player_limit_for_returning_players": "Players that played on this map already can join even when the max player limit was reached.",
"ignore_player_limit_for_returning_players": false,
"_comment_allow_commands": "possible values are, true, false and admins-only",
"allow_commands": "admins-only",
"_comment_autosave_interval": "Autosave interval in minutes",
"autosave_interval": 5,
"_comment_autosave_slots": "server autosave slots, it is cycled through when the server autosaves.",
"autosave_slots": 25,
"_comment_afk_autokick_interval": "How many minutes until someone is kicked when doing nothing, 0 for never.",
"afk_autokick_interval": 0,
"_comment_auto_pause": "Whether should the server be paused when no players are present.",
"auto_pause": false,
"only_admins_can_pause_the_game": true,
"_comment_autosave_only_on_server": "Whether autosaves should be saved only on server or also on all connected clients. Default is true.",
"autosave_only_on_server": true,
"_comment_non_blocking_saving": "Highly experimental feature, enable only at your own risk of losing your saves. On UNIX systems, server will fork itself to create an autosave. Autosaving on connected Windows clients will be disabled regardless of autosave_only_on_server option.",
"non_blocking_saving": false,
"_comment_segment_sizes": "Long network messages are split into segments that are sent over multiple ticks. Their size depends on the number of peers currently connected. Increasing the segment size will increase upload bandwidth requirement for the server and download bandwidth requirement for clients. This setting only affects server outbound messages. Changing these settings can have a negative impact on connection stability for some clients.",
"minimum_segment_size": 25,
"minimum_segment_size_peer_count": 20,
"maximum_segment_size": 100,
"maximum_segment_size_peer_count": 10
}`

mod-list.json
{
  "mods":
  [

    {
      "name": "base",
      "enabled": true
    },

    {
      "name": "elevated-rails",
      "enabled": true
    },

    {
      "name": "quality",
      "enabled": true
    },

    {
      "name": "space-age",
      "enabled": true
    }
  ]
}

When running a arm64 image, factorio will run in a box64 environment instead native:
https://github.com/factoriotools/factorio-docker/blob/master/docker/Dockerfile#L37-L44

So you recon the issue is with the platform? I thought the same but as the issue started after space age update, I am not certain.
Have you been able to run the factorio-docker with space age update/mods enabled?

I haven't touched factorio yet.
I am still busy to RL things, but meanwhile I try to fix the updater because it keeps doing strange things.

I went with a different approach, as I am the only one playing on the server, I wrote some scripts to download and upload saves on server when I launch and close the game. This way there will be no collection issue.
Thank you so much for your prompt replies and taking the time to answer the questions.


[stable/docker-registry] Affinity settings

Is this a new chart
No

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
This allows specifying affinity settings on the Deployment resource.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@rendhalver @jpds Appreciate an ok-to-test and a quick review please.

@rendhalver @jpds Appreciate an ok-to-test and a quick review please.

/ok-to-test
/assign
/lgtm


Fix error when game window start as minimized and don't have a swapchain

Should fix #84905, although it's a bit wierd that godot allow game start in a minimized window.

Thanks for working on the issue! I'll compile and test this as soon as I have some free time.

Superseded by #88289.


General Bookshelf issues

Breaking a populated bookshelf doesnt drop books
Breaking a bookshelf with a silent gear axe doesnt always drop a shelf
quark enchanting matrix breaks with some book shelf population combos (e.g. modded enchant books vanilla enchant, and books all on same shelf causes issues)

This is happening on buildersaddition-1.19.2-20220926a.jar
for forge 1.19.2 as well. I hope this will get fixed before 1.19 is abandoned.


bench: fix results makedir to prevent exception with multiple MPI processes

When running the benchmark with MPI, all ranks try to make the result directory to save the json file. This might generate an exception, when a process tries to create an existing directory. This PR fix this issue by adding a parameter to the os.makedirs function. With the parameter exist_ok = True, the function does not generate an error when the directory already exists.

thanks!


Update README.md

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command
Blueprint environment

/qovery  preview 13a77fc7-ab42-4472-b9a2-15ee0346f6f0
blueprint

/qovery  preview {all|UUID1,UUID2,...}
To preview multiple environments

This comment has been generated from Qovery AI :robot:.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command
Blueprint environment

/qovery  preview 13a77fc7-ab42-4472-b9a2-15ee0346f6f0
blueprint

/qovery  preview {all|UUID1,UUID2,...}
To preview multiple environments

This comment has been generated from Qovery AI :robot:.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months


Eliah Kagan: Watch dentalclinictoronto.dentist

Eliah Kagan requests the watch of the watch_keyword dentalclinictoronto\.dentist. See the MS search here and the Stack Exchange search here.

dentalclinictoronto\.dentist has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Document: ENV key configuration

#208 introduced ENV keys with HUTCH_ prefixes.
TODO: Update the README's Configuration Reference section to reflect this new way of configuration.
Perhaps these can go into each line, after the default value has been presented.
String configuration settings
HUTCH_MQ_HOST
HUTCH_MQ_EXCHANGE
HUTCH_MQ_VHOST
HUTCH_MQ_USERNAME
HUTCH_MQ_PASSWORD
HUTCH_MQ_API_HOST
Numeric configuration settings
HUTCH_MQ_PORT
HUTCH_MQ_API_PORT
HUTCH_HEARTBEAT
HUTCH_CHANNEL_PREFETCH
HUTCH_CONNECTION_TIMEOUT
HUTCH_READ_TIMEOUT
HUTCH_WRITE_TIMEOUT
HUTCH_GRACEFUL_EXIT_TIMEOUT
HUTCH_CONSUMER_POOL_SIZE
Boolean configuration settings
HUTCH_MQ_TLS
HUTCH_MQ_VERIFY_PEER
HUTCH_MQ_API_SSL
HUTCH_AUTOLOAD_RAILS
HUTCH_DAEMONISE
HUTCH_PUBLISHER_CONFIRMS
HUTCH_FORCE_PUBLISHER_CONFIRMS
HUTCH_ENABLE_HTTP_API_USE
HUTCH_CONSUMER_POOL_ABORT_ON_EXCEPTION

This is now documented using YARD in #219.

http://www.rubydoc.info/gems/hutch/Hutch/Config is where it will end up.


Training taking too much time when evaluation begins

I am training multilingual models using your library, some of the key points observed during training:

Training takes too much time in epochs where evaluation starts
If we set (evaluation_begin>num_epochs) model does not save checkpoint after training

Attaching a screenshot of the training

Hello,
yes, evaluation is very expensive. the evalute_begin should be in (0, num_epoch-1), and we can set a large save span to save time, e.g., config.log_step=200

Ok thanks a lot for clarifications!


[7569] Update smoke tests in preparation for dsi change

Context
Smokey
Changes proposed in this pull request
Update smoke tests in preparation for dsi change
Guidance to review
The flow has changed, previous one form now a form each, one for username and one for password.
Check it out here
https://github.com/DFE-Digital/register-trainee-teachers/actions/workflows/smoke-test.yml
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Update smoke tests in preparation for DSI change


Bump release version to v0.7.0-alpha.3

Preparing for the v0.7.0-alpha.3 release.

/test pull-trust-manager-smoke

/approve


Setup CMS Settings in one test step

Setup CMS Settings in one step for Behat test. The fields should be DB fields defined in table "SiteConfig".

bump @chillu

Looks like this is mergeable? I'd probably put it on the 3 branch though

Cherry picked into 3 branch with 4f1417502290e59432c8e052d57635464f8751b8.
It's already documented (and prematurely merged) through https://github.com/silverstripe-labs/silverstripe-behat-extension/pull/79/files#diff-04c6e90faac2675aa89e2176d2eec7d8R662


Integrate manufacturer into catalogue items v2 #108

Description
Integrated manufacturer into catalogue items, changed dialog so that users are able to select a manufacturer from a autocomplete dropdown. they can also add a new manufacturer, which will then be added to dropdown list. The ID of the manufacturer is then passed through to the backend to be added to the catalogue item. Currently the table view displays all the fields of a manufacturer (name, address ,url, telephone number) but this is subject to change based upon CLFs feedback
Note - #132 merged into this PR. So this PR will essentially close it and the issue for it
Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage

Agile board tracking
closes #108
closes #129

I tried to simplify the logic for selectedManufacturer in the Dialog. The solution I found doesn't seem to work when you then navigate to the landing page and try to edit an item from there. I can keep trying if you guys wish but it is as compact as I can make it

I tried to simplify the logic for selectedManufacturer in the Dialog. The solution I found doesn't seem to work when you then navigate to the landing page and try to edit an item from there. I can keep trying if you guys wish but it is as compact as I can make it

If this is about the comment I made in catalogueItemsDialog, replacing
  const { data: selectedCatalogueItemManufacturer } = useManufacturer(     selectedCatalogueItem?.manufacturer_id   );
with
  const selectedCatalogueItemManufacturer =     manufacturerList?.find(       (manufactuerer) =>         manufactuerer.id === selectedCatalogueItem?.manufacturer_id     ) || null;
appears to work. But don't worry about it if not.

Needs to be merged in first priority after christmas


Will Spring-AI support async processing?

Please do a quick search on GitHub issues first, the feature you are about to request might have already been requested.
Expected Behavior
I recommand that Spring AI provide SPI/API that supports asynchronous processing.
Current Behavior
The ChatClient is currently
public interface ChatClient {

    default String generate(String message) { // implementation omitted
    }

    AiResponse generate(Prompt prompt);

}

which only allows synchronous processing. In similar frameworks like langchain they have both generate and agenerate. It would be good and reasonable for SPring-AI framework to support async so that we can make use of many async process features & libs in Java for example netty, project reactor, RxJava, etc., perhaps with better performance.

Yes, but the documentation needs to be updated. The interface that supports this is StreamingChatClient
@FunctionalInterface
public interface StreamingChatClient {

	Flux<ChatResponse> generateStream(Prompt prompt);

}

There are implementations for

OpenAI
Azure OpenAI
AWS Bedrock Antropic
AWS Bedrock Cohere
AWS Bedrock Llama2
AWS Bedrock Titan
Ollama

I've created an issue to add docs for these.
We need to look into the other model providers we support to see which support streaming and then create issues for each of them.  Created this issue to track that.


Completely migrated to Golang 1.15 and Github Actions (fixes #360)

@lanwen any more things to fix?


Remove LF from  content

In Confluence Cloud, due to an unknown reason, a "white-space: pre" is added to the content of each page.
I don't know if it's the default behavior or if a theme is adding the style.
I think that is the first because the editor is preserving LF, but I'm not sure
If that is this way, then the LF policy in asciidoctor is different than Confluence's one.
So, although Asciidoctor is ignoring LF, Confluence is not.
It will be nice to have a flag or some other configuration to be able to remove LF characters inside p blocks (and its descendants)
A flag because I don't want to change current behavior of the publisher.

Duplicates #357


Quick fix for kid_policy.py

passing eos_token_id when no knowledge term token id has been retrieved

The failed checks (flake linter) come from the original code, it is unrelated to this (small) proposed fix:
Run flake8 . --count --show-source --statistics
  flake8 . --count --show-source --statistics
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.8.16/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.16/x64/lib
./KID/agent/base_agent.py:1[2](https://github.com/microsoft/KID/actions/runs/4291815055/jobs/7477480401#step:6:2):5: B027 __init__ is an empty method in an abstract base class, but has no abstract decorator. Consider adding @abstractmethod.
    def __init__(self, **kwargs) -> None:
    ^
./KID/agent/base_agent.py:19:5: B027 post_func is an empty method in an abstract base class, but has no abstract decorator. Consider adding @abstractmethod.
    def post_func(self, inp: Any) -> Any:
    ^
./KID/envs/base_env.py:12:5: B027 __init__ is an empty method in an abstract base class, but has no abstract decorator. Consider adding @abstractmethod.
    def __init__(self, **kwargs: Optional[Dict]) -> None:
    ^
./KID/envs/gptneo_env.py:4:1: F401 'transformers.GPT2LMHeadModel' imported but unused
from transformers import GPT2LMHeadModel, GPT2Tokenizer, GPTNeoForCausalLM
^
./KID/policy/base_policy.py:8:5: B027 __init__ is an empty method in an abstract base class, but has no abstract decorator. Consider adding @abstractmethod.
    def __init__(self, **kwargs):
    ^
./KID/policy/kid_policy.py:195:88: E501 line too long (96 > 87 characters)
        # tackle case where no knowledge term token id has been retrieved (otherwise it crashes)
                                                                                ^
./scripts/predict.py:1:1: F401 'colorama' imported but unused
import colorama
^
./scripts/predict.py:8:1: F401 'KID' imported but unused
import KID
^
4     B027 __init__ is an empty method in an abstract base class, but has no abstract decorator. Consider adding @abstractmethod.
1     E501 line too long (96 > 87 characters)
[3](https://github.com/microsoft/KID/actions/runs/4291815055/jobs/7477480401#step:6:3)     F[4](https://github.com/microsoft/KID/actions/runs/4291815055/jobs/7477480401#step:6:4)01 'transformers.GPT2LMHeadModel' imported but unused
[8](https://github.com/microsoft/KID/actions/runs/4291815055/jobs/7477480401#step:6:9)
Error: Process completed with exit code 1.


[Bug]: Documentation of Mock Service integration is missing

It is unclear to users of our templates how to define an own user specific mock.py, i.e. that it is possible to place a mock.py in root folder of the app repo.
Severity
Medium
What release version, tag or commit-hash did you use?

Current Behavior
No Documentation
Steps to Reproduce

Expected Behavior
Documentation shall be available
Possible Solution
No response
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

fixed by https://github.com/eclipse-velocitas/velocitas-docs/pull/114


Updated README and a slight modification to witcher3 script

Hello!
Please merge.

Waiting for a review

Seen.


671_Enable_Search_Templates_Usage | initial commit

Looks good ! We use standards to format the code, can you just run this on the source, thanks.
Also searchTemplate isn’t supported by all versions of node, check the version and throw an error if it doesn’t

moved to https://github.com/taskrabbit/elasticsearch-dump/pull/673

run the linting, should be ok now.


Data Export

As an admin, I can export catalogue data based on certain criteria.
Acceptance Criteria:

Export functionality supporting CSV/PDF.
Option to export based on search and filters.

done using MUI in aggregate stat


GH-505 Make node context menu items multi-select aware

Fixes #505

Applied to main (=2.1) and branch 2.0.


What was it like to learn Fortran?

We’ve recently started a project to find the best way to design our tracks, in order to optimize the learning experience of students.
As a first step, we’ll be examining the ways in which languages are unique and the ways in which they are similar. For this, we’d really like to use the knowledge of everyone involved in the Exercism community (students, mentors, maintainers) to answer the following questions:

How was your experience learning Fortran? What was helpful while learning Fortran? What did you struggle with? How did you tackle problems?
In what ways did Fortran differ from other languages you knew at the time? What was hard to learn? What did you have to unlearn? What syntax did you have to remap? What concepts carried over nicely?

Could you spare 5 minutes to help us by answering these questions? It would greatly help us improve the experience students have learning Fortran :)
Note: this issue is not meant as a discussion, just as a place for people to post their own, personal experiences.
Want to keep your thoughts private but still help? Feel free to email me at<EMAIL_ADDRESS>Thank you!

Learning Fortran

I think that very few people since the 1990’s have learned Fortran because they felt curious or fascinated by this very old language. Instead, Fortran is a very common tool to solve numerical problems. Many robust and tested solutions are written in Fortran and many are still in production today and in many years to come.
I think there are two ways to Fortran; the scientific or as a software developer.
Many scientific communities have been using Fortran for many decades for solving numerical problems. Therefore, people as myself with a scientific or engineering background, typically learn Fortran in masters or PhD programs. Another way to Fortran is to be hired in an organization (like mine, Dassault Systèmes www.3ds.com) where many numerical algorithms are in Fortran and they continue to be developed in Fortran.

How was your experience learning Fortran?

I learned a bit of Fortran during my mechanical engineering studies as part of a finite element course where the main part of the program was prepared in Fortran and our assignment was to add critical parts, eg. the finite element formulation. But mainly as I started working full time on structural optimization full time in 2005.

What was helpful while learning Fortran?

Fortran was one of my first software languages after learning Basic and Pascal in my youth and Matlab in my studies. Fortran (FORmula TRANslator) is really good for writing numerical routines and not having object orientation kind of helped me, because I feel object oriented programs confuses me (any many other non-software folks, e.g scientists) more in the beginning than they helped.

What did you struggle with?

Anything else than numerics is a pain in Fortran. File io, graphics, structuring code is often much better in almost any other languages. Therefore, many codes have C/C++ or Python wrappers around Fortran to avoid parts of this pain.

How did you tackle problems?

I did not tackle these problems - other people in my organisation mainly did.

In what ways did Fortran differ from other languages you knew at the time?

Fortran is procedural like Pascal and Basic so that part felt easy at the time. Fortran is fairly easy to learn, because it is fairly limited and most Fortran programmers are generally conservative and not using too many new language features, even though Fortran has developed over the 60 years it has been in use.

What was hard to learn?

The Fortran90 modules takes some getting used to. Also very old Fortran77 code can be difficult to read and will have memory saving constructs like equivalence, implicit variables and too many goto’s. If the code is still being actively maintained and modified I think removing these constructs is often worth the hassle but it is a risk and YMMW.

What did you have to unlearn?

Nothing really. One index may be an issue of you come from Java, C/C++ or python.

What syntax did you have to remap?

Fortran syntax is fairly limited compared to other languages

What concepts carried over nicely?

The best thing in Fortran90 is array operations, an essential component of numerics.
A(:,:) = B(:,:) + C(:,:)
Which is similar in Python and Matlab.

Learning Fortran

For what it's worth, I learned Fortran out of curiosity. I haven't met anyone else that has done that, though. I'll second that the big developer community I've seen is related to scientific computing. I've also seen some applications in data science where Fortran is a better choice than C when implementing something low level.

What did you have to unlearn

Variables being scoped to a call stack instance of a function. (i.e. general recursion)

We're closing this issue as it was part of our research for the v3 version of Exercism which has just been released.
Thanks everyone for chipping in! It has been greatly appreciated.


fix content offset being reseted when frame is assigned

Fix #63
Didn't want to use swizzling, but left no choice.
Hopefully this doesn't impact App Store reviews.

Codecov Report

Merging #69 into master will increase coverage by 0.46%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   55.11%   55.57%   +0.46%
==========================================
  Files          34       34
  Lines        1056     1067      +11
==========================================
+ Hits          582      593      +11
  Misses        474      474

Impacted Files
Coverage Δ

Sources/Other/CollectionReloadable.swift
91.66% <100%> (+7.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f1d95...200b071. Read the comment docs.


check what to do with line conditions on 3D elements

line condition connectivities can be in the opposite direction as what Kratos recognizes on the 3D elements. Check if Kratos needs to be extended by recognizing, or find out beforehand what the connectivity direction should be

solved


Migrate YAIM container to UMD-4

UMD-3 is discontinued. The first version of SIMPLE Grid Framework must feature UMD-4 based containers.

Need to modify run_lwce.sh. We need an option to either pull a repository from docker hub or build it from scratch

For now, the file can be directly edited. As run_lwce.sh is not mandatory for the framework to function, it is up to the user/developers or testers of the container to decide if they want to build the image locally or download it form docker hub.


Update deps

The important change here is that node-buffer has been bumped from 0.1.x to 0.2.0, but I also removed some trailing whitespace and that kind of stuff.

Actually I'm just going to go ahead and release this.


Show not so usefull verbose output only with -v

Currently these 3 lines are outputed for every single file php-cs-fixer scans
Loaded config default from ".../.php_cs.dist".
Using cache file ".php_cs.cache".
Paths from configuration file have been overridden by paths provided as command arguments.

which adds a lot of noise on pre-commit hooks and there is no way to turn it off

Hi @Gamesh and thanks for your PR!
Could you target 2.12 as it is the lowest supported branch? It will bring this enhancement to all supported versions :)

@SpacePossum should i just change the base or cherry pick the commits to 2.12 branch?

Would it be hard to have test to ensure no extra ouptut is displayed without verbose mode?

Would it be hard to have test to ensure no extra ouptut is displayed without verbose mode?
@kubawerlos we could probably create an integration test for it, do you have a good example i can look at already in your tests folder?

ReadmeCommand has a test to verify it's up to date - I'd imagine something similar - with checking output against some RegEx, or simply if it has anything more that version message.

@Gamesh a rebase on top of 2.12 and than updating the target here in the PR would be best :)
There is a test; tests/Console/Command/FixCommandTest.php this one already fetches the output, however it asserts the exit code only.

the problem is that there is no way to hide this output in any way and it produces noise a lot of it, if we use it as a pre-commit hook, developer modifies 20 files and gets 60 lines of this noise and then in between something meaningful might get outputted and you miss it. We are not removing it we're just hiding it under verbose flag so we can control it.
Current implementation outputs it to STDERR so we can't even filter it with grep as it works only on STDOUT
Also we explored using -q, that hides the messages but it also hides the final output of fixed files which is something we need, so it's no go also
i'm open to other suggestions, maybe a config option that by default leaves the current behavior on.
We seem to have a lot of output but it's on the same level of verbosity

since we don't have an agreement and found another way and i don't want to make your life as a maintainer harder, i'm closing this review :)
But i still think much of the output in daily usage is too verbose and could be hidden. Sure it's useful when debugging, but not so much in daily actual usage. It would be beneficial to make some of the output verbose or very verbose only

developer modifies 20 files and gets 60 lines

hint: modified 20 files? run tool once, not 20 times.

We are not removing it we're just hiding it under verbose flag so we can control it.

sadly, regular user run tool without debug, see unexpected (for him) outcome, he doesn't understand why, he doesn't run verbose flag

hint: modified 20 files? run tool once, not 20 times.

on that you're right but there is no way to list the files that were changed, so we opted for per file run.

sadly, regular user run tool without debug, see unexpected (for him) outcome, he doesn't understand why, he doesn't run verbose flag

could also be true, or when we don't understand we usually run tools in verbose mode. For most tools that's what it's for, to debug, to see what wget/curl or other tools are doing behind the scenes


Clarify the nature of the Link.Type enum

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##             master   #413   +/-   ##
=======================================
  Coverage        90%    90%
  Complexity      583    583
=======================================
  Files            98     98
  Lines          2031   2031
  Branches        210    210
=======================================
  Hits           1828   1828
  Misses          150    150
  Partials         53     53

Impacted Files
Coverage Δ
Complexity Δ

...main/java/io/opencensus/trace/SpanBuilderImpl.java
85.93% <0%> (ø)
17 <0> (ø)
:arrow_down:

...i/src/main/java/io/opencensus/trace/base/Link.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05cb3...dfe7b77. Read the comment docs.

I guess the otherwise wordy sounding child-linked-span on a span's links
hints at there is a non span type of link happening? Also is it needed to
add the word linked? Isnt the type already telling you that? If not, maybe
link isnt the right type name...


Labels of agent nodes bootstrapped by Rancherd are reverted

We're trying to let users adding custom labels to Nodes while installing Harvester. Adding labels by modifying /etc/rancher/rancherd/config.yaml works just fine. However, I've observed the following behavior after Nodes rebooted:
Let's say I have a label bootstrapped by Rancherd foo=bar:

For Node in cluster-init role, I update the label to foo=notbar then reboot the Node, the label would still be foo=notbar
For Node in agent role, I update the label to foo=notbar then reboot the Node, the label would be reverted back to foo=bar.

According to issue https://github.com/rancher/rancherd/issues/4, I think foo=bar should only be applied once during bootstrapping? In other words, the agent node should have the same behavior as cluster-init node?

Can you share the full yaml that reproduces this behavior?

These are the config YAML of the agent node. Let me know if I missed anything:

/etc/rancher/rancherd/config.yaml
server: https://<IP_ADDRESS>:8443
role: agent
token: 'harvester'
kubernetesVersion: v1.21.5+rke2r1
labels:
 - harvesterhci.io/managed=true
 - rancherd-label=installer-provided

/etc/rancher/rke2/config.yaml.d/40-rancherd.yaml
{}

/etc/rancher/rke2/config.yaml.d/50-rancher.yaml
{
  "node-label": [
    "harvesterhci.io/managed=true",
    "rancherd-label=installer-provided",
    "rke.cattle.io/machine=947a3577-7261-443c-a0fb-f8afb72955c7"
  ],
  "server": "https://<IP_ADDRESS>:9345",
  "token": "harvester"
}

/etc/rancher/rke2/config.yaml.d/90-harvester-agent.yaml
node-label+:
 - harvesterhci.io/managed=true

Not sure if this helps, but one thing I noticed is that in the cluster init Node, although /etc/rancher/rancherd/config.yaml contains the label I want to set, but /etc/rancher/rke2/config.yaml.d/50-rancher.yaml doesn't have the label config:

cluster-init Node /etc/rancher/rke2/config.yaml.d/50-rancher.yaml{
  "agent-token": "harvester",
  "cni": "calico",
  "node-label": [
    "rke.cattle.io/machine=96b24bc6-826e-463d-b97f-a40313926e1e"
  ],
  "token": "harvester"
}

@johnliu55tw The reason for this is when you assign node labels for an agent node the labels get set on the capi Machine object in Rancher.  If you don't want rancher to ensure that the node labels are set they have to be removed from the capi.Machine rke.cattle.io/labels annotations.
If you don't want the labels to persist you can try the following.  Add to /etc/rancher/rke2/config.yaml.d/90-harvester-agent.yaml kubelet-arg: ["node-labels=foo=bar,foo1=bar1"]  That should only set the node-label on create.

@ibuildthecloud Using kubelet-arg works, thanks!


Edit Distance algorithm. [Dynamic Programming]

I'd like to implement the edit distance algorithm between two strings.
[The minimum number of operations (insertions, deletions and substitutions of symbols) to transform one string to another.]
Input: two lines of input containing strings (latin characters)
Output: edit distance between the two strings.

@angelgilhotra I just noticed that edit distance has already been implemented. You can contribute some other algorithm if you'd like.

@angelagilhotra I just noticed that edit distance has already been implemented. You can contribute some other algorithm if you'd like.

@faheel oh, my bad! I must've missed it. Could I do the dynamic programming implementation of Lowest Common Subsequence of two sequences?


Windows: System.Windows.Forms assembly isn't found in CLI calls

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Run the following from cmd.exe (or Windows PowerShell):
pwsh -nop -c "Add-Type -Assembly System.Windows.Forms && [System.Windows.Forms.Form]"

Note that running the code in-session in a PowerShell Core session works fine.
Expected behavior
IsPublic IsSerial Name                                     BaseType
-------- -------- ----                                     --------
True     False    Form                                     System.Windows.Forms.ContainerControl

That is, the assembly should load and make the Form type available.
Actual behavior
Add-Type: Cannot find path 'C:\Users\jdoe\System.Windows.Forms.dll' because it does not exist.

That is, it only looks for the assembly in the current directory rather than in $PSHOME (which is what happens in-session).
Error details
No response
Environment data
PowerShell Core 7.4.0-preview.3 on Windows 11 22H2

Visuals
No response

it only looks for the assembly in the current directory rather than in $PSHOME

Is this behavior only with this assembly? In 7.3.4 on windows works. On Linux in 7.4.0-preview.3 works with available (but not preloaded) assemblies. I tested System.Linq.Parallel
pwsh -nop -c { Add-Type -AssemblyName System.Linq.Parallel && [Linq.ParallelEnumerable] }

My bad:
I accidentally ran the v7.3.4 CLI on my ARM64 Windows 11, and in 7.3, due to an unrelated problem, the WinForms assemblies weren't included.
The latter problem was fixed in 7.4.0-preview.3, and everything works as intended.


Issue with 'Run the app locally' step + updated tutorial?

I'm unsure if this article was just updated, but the old tutorial I was following seems to have disappeared, and the Docker step has been introduced. I would've like to finish the old tutorial, is there anywhere I could find it?
At this point, I've restarted the tutorial, and I'm stuck at the 'Run app locally' step after cloning the remote repo into a local directory. My command prompt is returning the error " Get https://registry-1.docker.io/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers) " when I run the build command. What should I do?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0077a811-b0b7-93b1-80b0-a4d45615ef4b
Version Independent ID: cc95198d-5560-2bf1-09ae-b8d210e45f2d
Content: Deploy a Python app in Azure Web App for Containers
Content Source: articles/app-service/containers/quickstart-python.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@akhterare Thank you for the feedback.
@cephalin Would you happen to know what document the customer is referring to and if so, would you be able to share it with the customer? Please let me know if not and I can take a troubleshooting perspective on this and take back ownership of the issue.

We retired the Windows content for Python as an internal choice to favor the Linux flavor. More clarifications will come later but suffice to say this is the direction we're going.

If I'm running from Windows, should this tutorial still work? I'm having issues with the bash command "docker build --rm -t flask-quickstart ." What would be the Windows equivalent?

Yes. I just tested it with Docker for Windows inside a Powershell session.

@akhterare We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


WDFReader Error: "ValueError: WMAP Xpad is not same as in ORGN!"

Hi,
I am trying to open a streamline scan obtained using a Renishaw Raman microscope using your package. When attempting to open the ".wdf" file the following error occurs: ValueError("WMAP Xpad is not same as in ORGN!"). Have you come across this error before? And do you know how I go about resolving it?
Regards,
Joseph

Hi Joseph,
Is it possible to send me the file that you used for debugging? The thing is I’ve only obtained data using the StreamLine HR previously (the renishaw instrument I don’t own). Probably there are some different implementations in original Streamline mode.
In brief I just checked the position information from WMAP and ORGN blocks, it could be that they are slightly different. If indeed there is such issue, I will update a version which shows a warning instead of throwing exceptions.
Best wishes
Tian

On Sep 4, 2020, at 1:35 PM, JLevermore<EMAIL_ADDRESS>wrote:
Hi,
I am trying to open a streamline scan obtained using a Renishaw Raman microscope using your package. When attempting to open the ".wdf" file the following error occurs: ValueError("WMAP Xpad is not same as in ORGN!"). Have you come across this error before? And do you know how I go about resolving it?
Regards,
Joseph
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/alchem0x2A/py-wdf-reader/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDNCVT5CAB7EGNLHKSE23SEDGJLANCNFSM4QYEZRMQ.

HI Tian,
Thank you for your prompt response and please see attached the .wdf file I am attempting to open. Just out of interest I have been trying to improve my python skills for accessing differing data files, I was wondering whether you know of any books or material you could recommend.
Regards,
Joseph Levermore
On 4 Sep 2020, at 13:26, T.Tian <notifications<EMAIL_ADDRESS>wrote:
Hi Joseph,
Is it possible to send me the file that you used for debugging? The thing is I’ve only obtained data using the StreamLine HR previously (the renishaw instrument I don’t own). Probably there are some different implementations in original Streamline mode.
In brief I just checked the position information from WMAP and ORGN blocks, it could be that they are slightly different. If indeed there is such issue, I will update a version which shows a warning instead of throwing exceptions.
Best wishes
Tian

On Sep 4, 2020, at 1:35 PM, JLevermore <notifications<EMAIL_ADDRESS>wrote:
Hi,
I am trying to open a streamline scan obtained using a Renishaw Raman microscope using your package. When attempting to open the ".wdf" file the following error occurs: ValueError("WMAP Xpad is not same as in ORGN!"). Have you come across this error before? And do you know how I go about resolving it?
Regards,
Joseph
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/alchem0x2A/py-wdf-reader/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDNCVT5CAB7EGNLHKSE23SEDGJLANCNFSM4QYEZRMQ.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falchem0x2A%2Fpy-wdf-reader%2Fissues%2F29%23issuecomment-687111342&data=01|01|joseph.levermore%40kcl.ac.uk|dd4da2265d4a42e2cffa08d850cdb835|8370cf1416f34c16b83c724071654356|0&sdata=ftFe7jvEpJWUXPW94PrmiFI9A53lhfV4tLt%2F36O8iyo%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKNYUC4DWOEGDSXJQGRNUBDSEDMGPANCNFSM4QYEZRMQ&data=01|01|joseph.levermore%40kcl.ac.uk|dd4da2265d4a42e2cffa08d850cdb835|8370cf1416f34c16b83c724071654356|0&sdata=7YQrJYDFG61PKbMjmPnuzVJqA%2FFffoA%2FegX13l92GnI%3D&reserved=0.

Hi Joseph
Much appreciated for your response. Unfortunately I couldn’t see the attachments in the issues, possibly they were just eaten by the Github octopus. Could you maybe post a link to that file (i.e. via dropbox) to my working email<EMAIL_ADDRESS><EMAIL_ADDRESS>you can set expiration of 12 h etc.
For the APIs to read the data of the wdf file I heavily rely on the codes by Gwyddion (https://sourceforge.net/p/gwyddion/code/HEAD/tree/trunk/gwyddion/modules/file/renishaw.c https://sourceforge.net/p/gwyddion/code/HEAD/tree/trunk/gwyddion/modules/file/renishaw.c). Many of the C-like chunks can be easily converted to a python-flavored codes.
Best
Tian

On Sep 4, 2020, at 2:38 PM, JLevermore<EMAIL_ADDRESS>wrote:
HI Tian,
Thank you for your prompt response and please see attached the .wdf file I am attempting to open. Just out of interest I have been trying to improve my python skills for accessing differing data files, I was wondering whether you know of any books or material you could recommend.
Regards,
Joseph Levermore
On 4 Sep 2020, at 13:26, T.Tian <notifications<EMAIL_ADDRESS>wrote:
Hi Joseph,
Is it possible to send me the file that you used for debugging? The thing is I’ve only obtained data using the StreamLine HR previously (the renishaw instrument I don’t own). Probably there are some different implementations in original Streamline mode.
In brief I just checked the position information from WMAP and ORGN blocks, it could be that they are slightly different. If indeed there is such issue, I will update a version which shows a warning instead of throwing exceptions.
Best wishes
Tian

On Sep 4, 2020, at 1:35 PM, JLevermore <notifications<EMAIL_ADDRESS>wrote:
Hi,
I am trying to open a streamline scan obtained using a Renishaw Raman microscope using your package. When attempting to open the ".wdf" file the following error occurs: ValueError("WMAP Xpad is not same as in ORGN!"). Have you come across this error before? And do you know how I go about resolving it?
Regards,
Joseph
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/alchem0x2A/py-wdf-reader/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDNCVT5CAB7EGNLHKSE23SEDGJLANCNFSM4QYEZRMQ.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falchem0x2A%2Fpy-wdf-reader%2Fissues%2F29%23issuecomment-687111342&data=01|01|joseph.levermore%40kcl.ac.uk|dd4da2265d4a42e2cffa08d850cdb835|8370cf1416f34c16b83c724071654356|0&sdata=ftFe7jvEpJWUXPW94PrmiFI9A53lhfV4tLt%2F36O8iyo%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKNYUC4DWOEGDSXJQGRNUBDSEDMGPANCNFSM4QYEZRMQ&data=01|01|joseph.levermore%40kcl.ac.uk|dd4da2265d4a42e2cffa08d850cdb835|8370cf1416f34c16b83c724071654356|0&sdata=7YQrJYDFG61PKbMjmPnuzVJqA%2FFffoA%2FegX13l92GnI%3D&reserved=0.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/alchem0x2A/py-wdf-reader/issues/29#issuecomment-687117217, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDNCWVOC5USNLJQ2MQKH3SEDNVRANCNFSM4QYEZRMQ.

Hi
The bug is caused because the previous code cannot handle XY-scan that starts with y-direction first, which appears in your testing wdf file.
PR #30 has been created for your issue. You could pull the commit (437c097) to check if the fix works for your other files that taken using the Streamline method. A quick previous of your testing raw data now looks as follows

If that works, I'll merge the revisions in the master branch :)


target 'hotspot-server-libs' failed

Platform:
jdk-linux-ppc64le-hotspot
jdk-aix-ppc64-hotspot
jdk-linux-s390x-hotspot
Architecture:
Please describe the issue that you are having with our binaries and if possible how to recreate it.
https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk/job/jdk-aix-ppc64-hotspot/148/console
lib/CompileJvm.gmk:149: recipe for target '/ramdisk0/build/workspace/build-scripts/jobs/jdk/jdk-aix-ppc64-hotspot/workspace/build/src/build/aix-ppc64-server-release/hotspot/variant-server/libjvm/objs/interp_masm_ppc_64.o' failed 07:46:33 make/Main.gmk:259: recipe for target 'hotspot-server-libs' failed

Possibly an upstream bug as this did not recur on subsequent builds.


Feature/relax google account scope

Changing google OAuth scope to readonly google analytics access
Adding copy explaining access required for setup
updated readme with redis instructions.

ping @edenspiekermann/backend


Replace assertThrows with assertThatThrownBy

Description
We use AssertJ in java unit tests to perform assertions, including for asserting exceptions. There are few places where we use Junit's assertThrows though. This PR migrates those calls to use assertThatThrownBy. Improves consistency. Downside is that it's harder to remember compared to simple assertThrows :/

Codecov Report

Merging #3051 (335f581) into main (553f2eb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3051   +/-   ##
=========================================
  Coverage     77.88%   77.88%
  Complexity     2151     2151
=========================================
  Files           274      274
  Lines          8575     8575
  Branches        582      582
=========================================
  Hits           6679     6679
  Misses         1678     1678
  Partials        218      218

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Local installation problems

I am having problems running FASTRAL after what seems a successful local installation using pip (without sudo). I am not a Python expert, but it seems that FASTRAL assumes that is installed globally and looks for ASTRID's executables in the global dist-packages instead of the local site-packages.

Can you please try in a virtual environment (like a Conda environment) and let me know if you still get the error?

Can you please try in a virtual environment (like a Conda environment) and let me know if you still get the error?

I am having problems running FASTRAL after what seems a successful local installation using pip (without sudo). I am not a Python expert, but it seems that FASTRAL assumes that is installed globally and looks for ASTRID's executables in the global dist-packages instead of the local site-packages.

Can you please try in a virtual environment (like a Conda environment) and let me know if you still get the error?

I am having problems running FASTRAL after what seems a successful local installation using pip (without sudo). I am not a Python expert, but it seems that FASTRAL assumes that is installed globally and looks for ASTRID's executables in the global dist-packages instead of the local site-packages.

Can you please try in a virtual environment (like a Conda environment) and let me know if you still get the error?