Adopt async/await in the MQTTnet internals

Today there are several Task.Run invocations to work around deadlock situations. In a properly designed async/await stack these should not be necessary. By implementing the async/await pattern throughout the internals would make the MQTTnet internals (effectively) single-threaded and thus further resolve issues like  #523. This issue also relates to #524.

This issue further relates to #554, #535, #523 and #506.

Some discussion already happened in PR #550, starting with this comment.

We should at first discuss how MQTTnet should behave when a PUB is received. It may send PUBREL or PUBACK to the broker:

on receipt before calling user space (before invocation of ReceivedApplicationMessageHandler)
on receipt after calling user space

With option two we can opt to not send PUBREL or PUBACK when an unhandled exception handles in user space when handling the PUB.

After crawling the issues, this issue appears to be a duplicate of #506 and @dealproc appears to have already done some more to make MQTTnet completely async. I would like to kindly invite @dealproc, @ramonsmits and @chkr1011 to join this conversation and make this happen as a joint effort.

FYI with the current develop branch I can get into a deadlock when I unplug the wifi router (or move out of its range). Reconnection attempts will start but eventually a deadlock occurs.

@BennyM there have been several incidents of deadlocks in the past with bad/broken connections, seems to be a recurring theme (which is understandable given the complexity of the project and intended purpouse).

@BennyM I observed that too and a fix should be the outcome of this issue.

@BennyM Do you have some example code to reproduce this? To you have event handlers etc. attached? My devices are reconnecting without problems. So I am wondering about the diff.

Ah OK I understand.

I will try to create a repro with code. Though probably not that easy. I really tested with unplugging the router :)

I observed a starvation (not necessarily a deadlock scenario) with the new task api when I attempted to forward a previously published message to another topic and returning the task returned by PublishAsync(). Ideally, that task is implemented as TaskCompletionSource that, depending on QoS, completes either when:

QoS0: the publish was sent (with tcp transport this would mean that it actually was received and ack'd by the broker)
QoS1: puback was received
QoS2: pubcomp was received

I have summarized the expected async behavior in a sequence diagram. It consists of four sequences:

In the last of the four sequences I outlined how a long running task could be started while the publish completes immediately. The code in the ApplicationMessageHandler would in this case read like:
Task StartLongRunningTaskHandler(ApplicationMessage message) {
    Task.Run(LongRunningTask); // fire and forget
    // it would be wise to record the long running task into a registry that would further allow it to be cancelled
    // using new CancellationTokenSource() for this purpose would be a good option
    return Task.Completed;
}

I stumbled upon this interesting discussion while investigating at which point in time other mqtt client libraries send puback / pubrel (i.e. before calling userspace or after).
While we discuss changing the api by adding async interfaces, does it make sense to pass the message handler into SubscribeAsync instead? MQTTnet could then take care of matching the topic and calling the appropriate message handler when a publish arrives that matches the subscription. We could then further add an overload of SubscribeAsync that allows to customize the point in time when puback / pubrel are sent.

Since a long time has passed please try with version 4 and reopen this ticket of the issue persists.


Mobile device searches do not retrieve position nor SERP.

Hello
For a 2 weeks at least, the crawler of Serposcope does not retrieve any data when set to mobile device.
No keyword is checked and no URL are stored for any keyword :

Screenshot in the keyword page :

No error in the logs.
The URL in the logs are good anyway. Don't know why there are no result.
When I parameter the keywords with DESKTOP (0 in the device colum in table in database), i get the data.
On the following screenshot, on the frontpage, you can see the data are back when all searches are Desktop-based :) I had to delete all task but the last one with mobile device. Now I can remove this mobile task.
I had to remove something like 2 weeks of bad data

regards

I can confirm, I'm also getting this. just upgraded to 2.8.0 and still like this

when will this get resolved? same issue

Hi,
Same here, hoping you will get some time to look at this issue.

+1 Same issue here to with the 2.8.0 version.


Having Issues Creating the QnA Maker Knowledge Base-Step 4

I am having Issues creating a Knowledge Base . This is the Error Message that I get “Oops!! Something went wrong. Please try again. If this error persists, please provide details via the feedback menu.”
On Step 4, we have to create a Knowledge base, by following the Instructions listed here https://docs.microsoft.com/en-us/azure/cognitive-services/qnamaker/tutorials/create-publish-query-in-portal#create-a-knowledge-base
And I’m stuck in Step 7 under “Create a Knowledge Base”.
Any help on this matter would be greatly appreciated!

I'm having the same issue, attempting to create a new knowledge base results in the below ### error.

same error no endpoint keys found. Anyone can provide help?

Ok, I just reported this issue as well, but now realized that others are facing the same. Seems like some configuration is missing in the QnA service created via ARM template. This error is not addressed anywhere on Google either.

I found the fix for the issue (or at least a workaround). If your Resource Group (RG) holding all resources from the template, is in a different location than the one hosting your QnA Cognitive service, then you will face this issue with Keys not being discoverable by the QnA Maker service.
For example, in my case I had chosen East US as the location for hosting a dedicated RG for all these resources, but the QnA service endpoint was provisioned in West US. I am not sure why that was the case since all three required services: Application Insights, QnA Maker and Azure Search are available in East US as well. However, as soon as I deleted my RG and created it again in West US region, I was able to create the Knowledgebase without any errors.

This appears to be a performance problem with the Cognitive Services platform.
These failures are intermittent,  If I persistently retry a failure, the knowledgebase will often eventually get created.
This often happens for 1 out of 3 or so attempts.
Currently I am running a for loop to test creation, today is particularly bad with all out of 100 tries failing over a period of an hour. Running the loop for 10 000 iterations at 20 second intervals, will post back my results in a few hours.

After 100 tries, I delete the resource group and run the creation script again, knowledgebase is created. This is without any changes to the configuration process. This service has serious reliablity and consistency issues!

Oh wow, thats incredibly poor 😬
Nice research @archmangler 👍🏻

Hello all, another trick to get the knowledge base creation to work is at the time of deployment select the following values:

You should do this for the first time, and after you have created the knowledge base, and published it - then you can always downgrade.
Hope this helps

I can concur that some configuration is missing from the ARM template creation.  If I provision everything from the QnA Maker web site, it works, but if I use an ARM template for all of the supporting Azure resources, it does not work.  I made sure to make sure that the ARM template resources had all of the exact same configuration as the resources created from the QnA Maker site UI.

i hace this problem:


use multi workor in nodejs

there is a c++ version  multi workor in one instance.
how can i archive this  in nodejs?

You want to see an example like the examples/multithreaded_echo.cpp but for Node.js? It [uws] should work just like any other Node.js module as far as I know. You can either expose a port range, one port per process, or somehow distribute file descriptors via IPC in some way (I never tried this in Node.js).

i like the idea  multi worker node  base on libuv  from this repo  https://github.com/ibc/mediasoup
that is awsome  if uWebSockets will have this.

I don't follow. You use uws just like you use ws.


Improve IRQ real-time compliance

This PR adds support for interruptible crypto operations (in an abandon-and-restart fashion) + use SSA memory pointer for enclave register content instead of enclave stack.
Still needs to be done before merging:

[x] remove UNPROTECTED_IRQ_REG_PUSH from the code base
[x] fix failing test cases in run_all_sancus (likely changing the asm stubs to the new SSA convention)
[x] update linker to the new SSA convention
[x] update trusted runtime (sm_entry.S) to the new SSA convention
[x] update sm_support to the new interruptible crypto HW contract
[x] disable HW support for confidential loading (not compat w interruptible crypto)

Added https://github.com/sancus-tee/sancus-compiler/pull/33 which add the SSA compatibility for linker and trusted runtime. Those work flawlessly now with maybe 50% of the sancus examples (the rest probably failing because of sm_support and confidential loading)

okay, added some comments on the trusted runtime in the compiler repo. I suspect those may be the cause of the failing tests rather than the interruptible crypto. Normally the sancus-examples don't have a lot of (random) IRQs and confidential loading is still enabled in the core, so I don't expect those to fail the tests.

I think this concludes the changes to sancus-core :-) All todos above have been addressed and all unit tests are normally passing now w/ and w/o the ATOMICITY_MONITOR, but make sure to do a careful review @fritzalder esp for the atomicity monitor changes..
Some notes:

the core should normally behave "backwards compatible" before any SM is loaded. Both w/ and w/o ATOMICITY_MONITOR, as also validated by the testsuite.
To make sure GIE is respected, I disabled non-maskable interrupts (NMIs) in the openmsp430_defines config file
Upon a  violation the core always vectors to the registered handler for that IRQ number. The saved status register R2[14] bit can be used later by the interrupted program to learn it suffered a violation. If the violation happens inside an SM in atomic mode, the SSA is completely untouched and all registers still cleared (including r2[14]), else the violation is processed as a normal IRQ (the only difference being R2[14]=1 in the saved SSA frame). This also means that software should be written such that a violation is never expected to happen in (benign) atomic section usage (i.e., don't derefence untrusted pointers in atomic sections). I think this is sufficient and makes sense, atomic sections are already small hand-written asm stubs, and this behavior also corresponds to the "atomic" nature of the code (eg atomic code may want to inspect and change SSA memory w/o having it overwritten).
When interrupt-restart crypto is enabled (through ATOMICITY_MONITOR), confidential loading is transparently disabled. Normally any attempt to do sancus_enable with a wrapped SM, will properly indicate verification failure to the software invoking sancus_enable (but I didn't test this explicitly).

Last but not least, I only tested the core under the custom assembly unit test framework. So no guarantees everything still works with the sancus-compiler and this should be checked and ran against sancus-examples. I did push a small commit in sancus-tee/sancus-compiler#33 that should normally add transparent compiler support for interrupt-restart crypto, but again I didn't test this at the level of the compiler/sancus-examples.

I think this concludes the changes to sancus-core :-) All todos above have been addressed and all unit tests are normally passing now w/ and w/o the ATOMICITY_MONITOR, but make sure to do a careful review @fritzalder esp for the atomicity monitor changes..
Some notes:

the core should normally behave "backwards compatible" before any SM is loaded. Both w/ and w/o ATOMICITY_MONITOR, as also validated by the testsuite.
To make sure GIE is respected, I disabled non-maskable interrupts (NMIs) in the openmsp430_defines config file
Upon a  violation the core always vectors to the registered handler for that IRQ number. The saved status register R2[14] bit can be used later by the interrupted program to learn it suffered a violation. If the violation happens inside an SM in atomic mode, the SSA is completely untouched and all registers still cleared (including r2[14]), else the violation is processed as a normal IRQ (the only difference being R2[14]=1 in the saved SSA frame). This also means that software should be written such that a violation is never expected to happen in (benign) atomic section usage (i.e., don't derefence untrusted pointers in atomic sections). I think this is sufficient and makes sense, atomic sections are already small hand-written asm stubs, and this behavior also corresponds to the "atomic" nature of the code (eg atomic code may want to inspect and change SSA memory w/o having it overwritten).
When interrupt-restart crypto is enabled (through ATOMICITY_MONITOR), confidential loading is transparently disabled. Normally any attempt to do sancus_enable with a wrapped SM, will properly indicate verification failure to the software invoking sancus_enable (but I didn't test this explicitly).

Last but not least, I only tested the core under the custom assembly unit test framework. So no guarantees everything still works with the sancus-compiler and this should be checked and ran against sancus-examples. I did push a small commit in sancus-tee/sancus-compiler#33 that should normally add transparent compiler support for interrupt-restart crypto, but again I didn't test this at the level of the compiler/sancus-examples.

@fritzalder why did you need to add an extra wait cycle in the " Adding wait cycle after violations " commit above?
Not sure why exactly, but this extra cycle breaks some test cases. Probably a timign issue in the stimulus files, but I would like to make sure the extra wait cycle is really needed before I figure out how to fix the test cases?

The wait cycles are indeed necessary after loading the SSA address. At least in verilator, the read SSA address is otherwise not writeable into the mab in the next cycle which means that on an SM IRQ, the SSA will not be correctly written and the SSA remains empty. Whenever an SM then wants to restore itself from an SSA, it will only read zero bytes and crash.

for reference, after digging deeper with @fritzalder, we established that the wait cycle is needed (at least in verilator simulations) since the result of mdb_in is used in the same cycle for mab when writing the PC to the SSA frame (somehow this doesn't manifest as an issue when using iverilog for the test bench sm_irq).
I'll update the failing unit tests before this commit can be merged.

for reference, after digging deeper with @fritzalder, we established that the wait cycle is needed (at least in verilator simulations) since the result of mdb_in is used in the same cycle for mab when writing the PC to the SSA frame (somehow this doesn't manifest as an issue when using iverilog for the test bench sm_irq).
I'll update the failing unit tests before this commit can be merged.


darkness scene bug

Sibling: https://github.com/webaverse/totum/pull/136
There are some issues in darkness scene.

We could not equip the group object at the correct position in the darkness scene(lantern and fairy)

https://user-images.githubusercontent.com/60634884/186737875-023acf57-ec9c-4cde-a748-14bba547182c.mp4
That is because we do not initialize the app.lastMatrix so it update the physics objects in app-manager based on the wrong lastMatrix

So I initialize the subApp.lastMatrix when we create the subApp
https://github.com/webaverse/totum/blob/00f6f6863555126035157b92ba086cd8ae1ff1bd/type_templates/group.js#L94

Even we could equip the object at the initial position now, we could not equip it again if we drop the object.

https://user-images.githubusercontent.com/60634884/186740724-b16e4e48-5d17-4d95-bbfc-41797f83da6c.mp4
That is because we update the same physic object of this app twice in app-manager(subApp and app)
So I comment out app.getPhysicsObjects in totum so that it would just update subApp's physic object once.
https://github.com/webaverse/totum/blob/00f6f6863555126035157b92ba086cd8ae1ff1bd/type_templates/group.js#L110

We can not equip pet in darkness scene.

https://user-images.githubusercontent.com/60634884/186741689-738edc42-13dc-4ebd-89ee-7a469a0d130f.mp4
That is because the app is in the world.appManager.apps But we searched the app in localPlayer.appManager.apps.
https://github.com/webaverse/app/blob/ec8d75f24aed0787a518fbf0e665ced093deee93/metaversefile-api.js#L974
So instead of using getPlayerByAppInstanceId(app.instanceId); to find the player, I use e.player.
This is the result: (the light is not correct, would fix it with another PR)
https://user-images.githubusercontent.com/60634884/186742448-45810e23-7f8a-4bfb-b1dd-671805e6b5d4.mp4

We are not available to test this PR because of this issue: https://github.com/webaverse/app/issues/3672
@tcm390 you can rebase the totum with no useAvatarRenderer version, but I think that seems like the duplicate work.
I will check this with panther.

This PR has the lighting issue now. anyway @tcm390 want to get feedbacks about current changes from @avaer
https://user-images.githubusercontent.com/92342281/188943133-b08fea16-88e1-4eb3-aedf-fbf0e6329486.mp4

@avaer  can you please review current changes and give @tcm390 feedback?


Tweak build

Hi @nisrulz I saw your library on Android Weekly. Good stuff!
I thought I'd tweak the build.gradles a bit, hope the PRs ok.

Thank you for the PR 😄


Pagination fix

Closed without merging because, it would lot of other commits in addition to pagination fix to current-deployment branch.


Change highlight color for search results from green to blue

To align with the desktop design (search on settings screen) please update the color for search highlights. Make it blue with glowing, not green (as now). https://zpl.io/bJGNzO3

Checked


Playback Speed Controller Not Displaying

Bug Description:
The playback speed controller does not display at all when attempting to adjust the playback speed.
The issue is caused by Spotify changing the page HTML layout and element classes.
Steps to Reproduce:

Navigate to the Spotify.
Attempt to access the playback speed controller.
Observe that the playback speed controller is not visible and a "Speedify - Critical Error" message is displayed in the console.

Expected Behavior:
The playback speed controller should be visible and accessible, allowing users to adjust the playback speed.
Actual Behavior:
The playback speed controller is not displayed, and a "Speedify - Critical Error" message appears in the console, making it impossible to change the playback speed.
Screenshots/Recordings:

Issue resolved.
Patched in version:  1.0.2

Issue resolved.
Patched in version: 1.0.2


Notebook scroll scroll font feels inconsistent

Does this issue occur when all extensions are disabled?: Yes/No

The notebook sticky scroll is using the text editor font other than the workspace font, which made it look inconsistent with the breadcrumb and notebook toolbar.
It looks less polished compared to the list view sticky scroll.

Fixed via #202200


Crashes with new Transformers version

Here's the error:
Traceback (most recent call last):
File "run_clm.py", line 478, in
main()
File "run_clm.py", line 422, in main
trainer = Trainer(
File "/root/miniconda3/lib/python3.8/site-packages/transformers/trainer.py", line 295, in init
logging.set_verbosity(log_level)
File "/root/miniconda3/lib/python3.8/site-packages/transformers/utils/logging.py", line 161, in set_verbosity
_get_library_root_logger().setLevel(verbosity)
File "/root/miniconda3/lib/python3.8/logging/init.py", line 1409, in setLevel
self.level = _checkLevel(level)
File "/root/miniconda3/lib/python3.8/logging/init.py", line 194, in _checkLevel
raise ValueError("Unknown level: %r" % level)
The fix was to install transformers v4.6.0 from pip

Thanks for reporting! I pinned now the transformers dependency to 4.7.0.


TypeError: undefined is not an object (evaluating 'daysArray[8].year')

Year does not show

Hi, could you provide more error message and your code?
I think I didn't write the documention very well. Maybe this error is caused by wrong way using the props.

Closed because no acitvity.


Add option to restart #23.1

New code for the auto Daemon restart. It's now a checkbox in Settings -> Daemon Configuration -> Restart on Boot.
If checked, upon phone startup the app will start, go to MainActivity, wait 30 seconds and toggle the Daemon switch to ON.
Adds RECEIVE_BOOT_COMPLETED permission.

Sorry for late review @gwicks56 and thanks for submitting this.
If you're still interested in this pull request, please be aware that it requires a rebase and resolving conflicts before we can proceed.
I'd also recommend naming the setting something like "Auto-start on boot", I think "auto-start" is clearer than "restart", "restart" sounds like we're shutting down the daemon and starting it back up.


Update DG for v1.2

Use cases now capture that multiple fields can be edited at once
Added 'save data' features (saving automatically and locally) as high-priority user stories

Closes #31

Codecov Report

Merging #34 (cf6cbbf) into master (575c9c6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575c9c6...cf6cbbf. Read the comment docs.


Migration of flatfield and pedestal components from lstchain

This PR draft adds a migration proposal for the flatfield and pedestal components from lstchain into ctapipe. Shared functionality is moved into a parent component, while the different subcomponents hold the _process() function for the conventional processing of flatfield and pedestal events. Additional subcomponents with complex processing routines of flatfield and pedestal events can be added in the future.

Hi @TjarkMiener thanks, this is much needed.
However, I think we should first discuss a bit how we want the general API of these classes to look like.
I think we certainly don't want to keep the current one.

Do we need an abstract base class for the calibration like we have currently?
This would depend on whether we can use the same general structure and algorithm per telescope. Will all telescopes use the F-Factor method?

Do we use a custom tool to compute these calibration coefficients or do we integrate into ctapipe-process.
I think specific tool is the way to go.

What structure do we need?
Currently we have three classes, one for pedestal events, one for flatfield events and one tying these two together to compute the final calibration coefficients. That makes sense I think, but there is also a lot of duplication between the flatfield and the pedestal base class in lstchain currently. This should be refactored.

How do we store the output?

How do we read it back in for calibration?

There are a couple of related open issues:

https://github.com/cta-observatory/ctapipe/issues/1836 (as  calibration events come with two gains)
https://github.com/cta-observatory/ctapipe/issues/1397
https://github.com/cta-observatory/ctapipe/issues/1226
https://github.com/cta-observatory/ctapipe/issues/1147
https://github.com/cta-observatory/ctapipe/issues/856

@FrancaCassol I think it doesn't make much sense to apply any optimization to the existing code, as we now we need to replace it completely relatively soon.

The logic is already somewhat different to what is implemented in LST currently, so clearly this at least has some new development.

This PR draft was meant to refactor the current lstchain components for flatfield and pedestal to remove repeated code and start a discussion on the migration. In addition, I added this config parameter, which allows the calculation of the stats after a given iteration and not once the sample buffer is filled. Originally I had in mind to follow what @kosack suggested (pre-process/integrate charges and arrival times, dump dl1-like events, and then table read plus the calculation of coefficients). I dropped this idea because a presumed 2x 100Hz calibration rate and an obs block duration of 20-25 mins would exceed the RAM limitation of 2GB per job when reading the whole table. However, as we discussed in a separate thread, the calibration rate will be likely reduced in the near future. So I guess we could reconsider the suggestion of integrating and temporarily storing dl1-like calibration data to read them afterward using the TableLoader and apply functions to all events at once.
The idea I followed in this PR for the design of the components was to be able to flexibly add subcomponents that could host the "fancy algorithms" via the _process() function. You could in principle increase the sample_size and then apply the complex functions on the self.charges and self.arrival_times arrays as you would do for all the events read with the TableLoader. Those complex functions could even be applied on a pixel-wise level, i.e. we might want to treat pixels that are affected by stars differently. The current subcomponents FlatFieldExtractor and PedestalExtractor were targeting the cat-B processing, while fancy subcomponents can be added in the future for cat-C processing.
I like the idea proposed in #1226 for the on-the-fly computation of flatfield and pedestals, even though we might want to store the charge statistics monitoring of the calibration events for the data quality monitoring.

The table loader also supports chunked loading, which allows you to iterate through chunks and keeping consecutive chunks in memory, you only need roughly the amount of events of your windows sizes.

True, good point! My initial plan was to follow a workflow like: integrating charges and extracting arrival times via the process tool  ($ ctapipe-process ... --write_images --no-write_parameters). And then code a tool for the calculation of the camera calibration coefficients based on the TableLoader. Therefore, I would need to make the process tool compatible with calibration events, i.e. allowing two gains integration. By using the process tool we would directly ensure to follow the standard ctapipe DL1 data model, which then probably needs some adjustments for the allowance of two gains images and peak_times. I think the dl1-like files for the calibration events can be stored temporarily. One advantage would also be that those dl1-like calibration files could be sent directly to the off-site data center after production rather than the waveforms of the calibration events. A naive guess from my side would be that we don't want to repeat the charge integration and arrival time extraction for the calibration events each time we are calculating camera calibration coefficients (on- or off-site).
I'm closing this draft for now and working on the suggestion above in a separate branch. In case you think we should the design of this PR feel free to comment and I will reopen this draft. Thanks for the discussion and suggestion!


Are you using Carvel?

Are you using Carvel?
If you are using any of the Carvel tools, first we would like to Thank You. Our goal is to grow the community, improve Carvel and help each other.
The purpose of this issue
We are always interested in finding out who is using Carvel, what attracted you to using the tool suite, how we can listen to your needs, and, if you are interested, help promote your organization.

We have people reaching out to us asking, who uses Carvel in production?
We’d like to listen to what you would like to see in Carvel and your scenarios.
We'd like to help promote your organization and work with you.

What we would like from you
Submit a comment in this issue to include the following information, which would then also get included into the ADOPTERS.md file in this repo for others to see:

Your organization or company
Link to your website
Your country
Your contact info to reach out to you: blog, email, Kubernetes Slack workspace handle, or Twitter (at least one).
What is your scenario for using Carvel?
Are you running you application in testing or production?
Attach a PNG version of your logo to your comment. Name the image file something that reflects your company (e.g., if your company is called Acme, name the image acme.svg).

If you have any questions please email us.
Organization/Company: Revng
Website: https://rev.ng/
Country: Italy
Contact: @Filippo Cremonese (K8s Slack)
Usage scenario: Revng is a small company with expertise in compilers, emulation and binary analysis. Revng uses ytt as a flexible templating tool to generate the configuration for orchestra, their meta build system/package manager.
Status: Production

Company: TeraSky
Website: https://terasky.com
Country: Israel
Contact: @vrabbi (github and k8s slack) @vrabbi_il (twitter)
Usage: TeraSky is an Advanced Technology Solutions Provider. We utilize the carvel suite in order to streamline k8s configuration and deployment by many of our customers. We also utilize ytt to manage additional yaml based systems such as vRealize Automation and CloudFoundry.
Status: Production

I used a png file as it complains about not supporting svg format uploads

I used a png file as it complains about not supporting svg format uploads

@vrabbi ah, good to know! I updated the text to "PNG" thank you!!

✋Intro
Hi, I'm Adrien Sales  from OPT-NC New Caledonia

✅Questions

[x] Your organization or company : Office des Postes et Télécommunications de Nouvelle-Calédonie
[x] Link to your website :

[x] linkedIn : https://www.linkedin.com/in/adrien-sales/
[x] Github profile https://github.com/adriens
[x] Dev.to : https://dev.to/adriens

[x] Official Orgnization website : https://www.opt.nc/
[x] Link to Official linkedIn page : https://www.linkedin.com/company/opt-new-caledonia/mycompany/
[x] Your country : New Caledonia
[x] Your contact info to reach out to you: blog, email, Kubernetes Slack workspace handle

[x] linkedIn : https://www.linkedin.com/in/adrien-sales/
[x] Github profile https://github.com/adriens
[x] Dev.to : https://dev.to/adriens
[x] Twitter : https://twitter.com/rastadidi

[x] What is your scenario for using Carvel : we are using vendir to sync repos to build docker images, ytt to instanciate templates and are currently working on packaging services as applications with kapp. We are prototyping on a onPrem Tanzu instance. We are using Github.com and GH Actions to automate the whole thing and are evaluating Harbor vs. Artifactory vs. Github Container Registry to store/release our images, also for public ones DockerHub
[x] Are you running you application in testing or production? For now we are testing and train our new DevOPS process on this technology.
[x] Attach a PNG version of your logo to your comment. Name the image file something that reflects your company (e.g., if your company is called Acme, name the image acme.svg) : please see below

Hi! I am not quite ready to disclose the organization I am working for and make things official. I probably need clearance from upper management for that.
But let me just take this opportunity to say thank you for your work! We've just introduced kbld and kapp into our deployment pipelines, and these are a big help!
Some background: We recently moved from "Docker Swarm" to Kubernetes (self hosted k3s). We are templating our yaml-files (previously docker-compose-yaml, now kubernetes-yaml) using Ansible/Jinja, because our teams are used to Ansible and we didn't have time to switch to another templating engine, so Helm was no option for us.
So, at first our pipeline looked like this:
Ansible+Jinja -->

Hi! I am not quite ready to disclose the organization I am working for and make things official. I probably need clearance from upper management for that.
But let me just take this opportunity to say thank you for your work! We've just introduced kbld and kapp into our deployment pipelines, and these are a big help!
Some background: We recently moved from "Docker Swarm" to Kubernetes (self hosted k3s). We are templating our yaml-files (previously docker-compose-yaml, now kubernetes-yaml) using Ansible/Jinja, because our teams are used to Ansible and we didn't have time to switch to another templating engine, so Helm was no option for us.
So, at first our pipeline looked like this:

Ansible+Jinja to generate a set of docker-compose files for Docker swarm, on file for each application (called "stack" in Docker-Swarm)
Deploy using docker stack deploy -f docker-compose-yaml [stack-name]

You can probably see where I am going with this: Docker-Swarm has the concept of "stacks" that roughly translate to "apps" when using kapp. So, when updating a stack later with a new docker-compose.yaml-file that contains fewer services than before, Docker-Swarm was smart enough to remove the now-missing service from the stack.
Also: When deploying using docker stack deploy, docker first converts all image-tags into image-digests. This ensures that all nodes use the exactly same image, even when deploying latest tags.
After switching to Kubernetes, our pipeline initially looked like this:

Ansible+Jinja to generate a set of kubernetes manifests (Deployment, Service, Ingress, ....)
Kustomize to merge all files of one application into a single kubernetes.yaml (which is our replacement for the docker-compose.yaml from before) while also use its configMapGenerator and secretGenerator to convert raw files into ConfigMaps and Secrets.
Deploy using kubectl apply -f kubernetes.yaml for each application.

This works nicely, but we quickly encountered two issues:

kubectl apply doesn't convert latest-tags to digests. This leads to unexpected image-updates when kubernetes relocates a container from one node to another.
If a new kubernetes.yaml (which, again, is a concatenation of all kubernetes resources that together describe an application) contains fewer resources than before (like a removed Ingress), kubectl apply won't delete the removed resource from the cluster. (Yes, I know about --purge, but let's not speak about that....).

As I already said, we absolutely have to use Ansible (for variable management) and Jinja (for templating), because migrating away from that would be a huge project by itself. This means we can't use Helm. And let's be real: Most people seem to hate Helm with strong passion.
This was when I discovered the carvel tools:

kbld: Convert image tags to digest right before deploying to emulate the behavior of Docker Swarm.
kapp: Deploy a set of manifests as "applications" which is very similar to how Docker Swarm handled "stacks".

Our pipeline now looks like this:

Ansible+Jinja to generate a set of kubernetes manifests (Deployment, Service, Ingress, ....)
Kustomize to merge all files of one application into a single kubernetes.yaml (and generate ConfigMaps and stuff).
Pipe the kubernetes.yaml  of one application though kbld to convert image tags to digests.
Deploy using kapp deploy -a [app-name] -f kubernetes.yaml for each application.

This works really well!
Seriously, I think the carvel tools deserve a lot more love from the community. When searching sites like hacker-news and reddit for tools like "kapp" you barely find any mentions of them. I am really curious about why this is the case, because I think these tools really fill a gap, especially if you don't want to use Helm.

Organization: Fabrique Numérique des Ministères Sociaux
Website: https://www.fabrique.social.gouv.fr/
Country: France
Usage:
We are using kapp CLI as deployer for our CI/CD tooling that we are developing and implementing actively: Kontinuous
The project started as a wrapper around Helm and Kapp, then evolved to offer more abstraction and a rich plugins system. Doc will be updated soon to reflect our current state of art.
Many thanks for great tooling you provide !
Dependencies tree management using change-group and change-rules are greatly valuable and offer much flexibility for our use cases.

Company: orange
Link to your website: https://www.orange.com/
country: France
Your contact info to reach out to you: Kubernetes Slack workspace handle: Guillaume Berche
What is your scenario for using Carvel?

Crossplane CRD templating while preserving coding assistance. See https://github.com/crossplane/crossplane/issues/3197#issuecomment-1194624402 and https://github.com/vfarcic/devops-toolkit-crossplane/issues/4
Triggering/scheduling execution of kuttl tests within the k8s cluster

Are you running you application in testing or production? Testing, customer early access (not yet production)
Logo svg: https://fr.wikipedia.org/wiki/Orange_(entreprise)#/media/Fichier:Orange_logo.svg

Company: nemlig.com
Country: Danish
Contact info<EMAIL_ADDRESS>What is your scenario for using Carvel:

We are in the Platform team at nemlig.com, developing an  in-house kubernetes platform, which is deployed, managed and configured using a plethora of open-source tools like: kcli, helm and many many more.
We have developed the platform from scratch, stitching together many open-source tools. But a few of the most important tools in our toolbox is yq, jq and of course the glue that binds all of the tools together ytt.
Ytt is often the last step before helm install in a tool we have created called the component-handler which, as  the name eludes to, handles components (e.g., helm releases in our clusters) in a generic but also hugely extendable way. Without ytt, this had been hell for us to develop like we wanted it, so we are very grateful for this awesome tool and are planning to contribute back when time allows.
Awesome work you guys!

Env: Test & Production

@Havnevej thank you so much for your contribution to this issue!


simplify snapshot without copying prototype props

After releasing v0.4.1, I'm a bit uncomfortable because it seems pretty hard to maintain all those edge cases.
This will drop some use cases to use prototypes in snapshots.
The rationale behind it is we would not track function call results.

Tic Tac example
https://codesandbox.io/s/valtio-tic-tac-forked-tfbcy?file=/src/index.js
It's not very fancy, but internally it makes sense, and I expect it's less fragile.

After releasing v0.4.1, I'm a bit uncomfortable because it seems pretty hard to maintain all those edge cases.
This will drop some use cases to use prototypes in snapshots.
The rationale behind it is we would not track function call results.

I understand that it introduces some complexities in the code, but with v0.4.1, the Tic Tac example with getters ( https://codesandbox.io/s/valtio-tic-tac-forked-p14i1?file=/src/index.js) was working like a charm, rerendering only the square that was clicked. Now, with this commit, the previous behaviour came back, and all squares rerender in every click.
I think Computed properties or Getters are a big win for a state management package, and one of the reasons for Mobx success, so it would be good to support it out of the box.
The Tic Tac valtio refactor to use subscribe (https://codesandbox.io/s/valtio-tic-tac-forked-nwp42) needs four abstractions (store, computed, subscribe and actions) instead of just one (a class with getters). Sometimes we need to access properties and getters in the same component, which leads to the situation to need two useProxy, one for the store and the other for the computed, which can cause some confusion. It makes the code harder to maintain, because you need to remember which property comes from the store and which one comes from the computed.
So, it would be great if it would be possible to keep the features introduced in v0.4.1

I wasn’t aware 1.4.1 solved rerender issue, which wasn’t the case in 1.4.0, correct?
Honestly, I didn’t think getters work as expected. Let me investigate it again.

Exactly.
v0.4.1 was working ok (just rerender the square clicked, not the others).
Verified with React Dev Tools.
OK (Rendering the clicked):

Not OK (Rerendering all):

v0.2.3 Not OK❌:  https://codesandbox.io/s/valtio-tic-tac-j0nut
v0.4.1 OK✔:  https://codesandbox.io/s/valtio-tic-tac-041-i9zqb
#27 Not OK❌: https://codesandbox.io/s/valtio-tic-tac-forked-tfbcy

https://codesandbox.io/s/valtio-tic-tac-040-rv1nl
Confirmed this is not OK in v0.4.0.
This is crazy, so nice! I didn't expect this behavior while making v0.4.1 (I know usage tracking didn't work and wanted to fix it.)
So, the getters or functions that read this read from proxies (by createDeepProxy) and the usage is tracked. This is not technically computed (like the result is not memoized), but it should cover many use cases in React.
I will add some more tests to check this behavior.

Closing this as #29 will be a proper fix.


DOM elements don't support remove method in IE 10.

In IE 10, DOM Element doesn't support remove method.
(https://stackoverflow.com/a/37477096/3349945)
So the code below will not work properly in IE 10.
      if (!document.querySelector('body > #fb-root')) {
        // There may be multiple #fb-root elements in a post's content: remove them
        // all in favor of a new body-level div.
        [...document.querySelectorAll('#fb-root')].forEach(n => n.remove());

        // Prepare and create the fb-root element. We only need one.
        const fbDiv = document.createElement('div');
        fbDiv.id = 'fb-root';
        document.body.prepend(fbDiv);
      }

https://github.com/humanmade/react-oembed-container/blob/master/src/embeds.js#L18
I think it would be nice to change this in the following way for a wider browser support. What do you think?

Oops. The same goes for prepend method.
https://github.com/humanmade/react-oembed-container/blob/master/src/embeds.js#L23

I added a PR for this: https://github.com/humanmade/react-oembed-container/pull/7/files

Merged #7, releasing this as a beta tag shortly and should have a formal release out soon after.


Fix deletion error

@chamer81 this should at least print the cause of the deletion
Can you try again on your end?
How did you set up your test repository and image streams? Might be very useful to setup some sort of integration test suite for automated testing :)
Internal ref: https://ticket.vshn.net/browse/VT-1348

It seems it was just the reporting, deletion actually worked in my test setup:
$ oc login <lab cluster>
$ docker push registry.lab.appuio.ch/vt-1348/seiso:latest
$ oc get is seiso
NAME      DOCKER REPO                                      TAGS      UPDATED
seiso     docker-registry.default.svc:5000/vt-1348/seiso   latest    3 seconds ago
$ ./seiso images orphans vt-1348/seiso --older-than 1s --deletion-pattern ".*" -f
INFO[2020-04-09T11:35:47+02:00] Found image tag candidate                     imageTag=latest
INFO[2020-04-09T11:35:47+02:00] Deleted image tag                             image=seiso imageTag=latest namespace=vt-1348
$ oc get is seiso
NAME      DOCKER REPO                                      TAGS      UPDATED
seiso     docker-registry.default.svc:5000/vt-1348/seiso

@chamer81 Can you confirm the same in your test setup?


Add Jobs API

Dapr v1.14 adds support for the Jobs API which uses the Scheduler control plane service under the hood. This new API allows users to schedule/get/delete jobs to be triggered at some point in the future. Once triggered from the Scheduler control plane service, daprd will send the job to the app via either grpc or http via OnJobEventAlpha1 or /jobs repspectively. The API is exposed to the user for both grpc + http via the ScheduleJobAlpha1/GetJobAlpha1/DeleteJobAlpha1 apis.
Reference implementation for the go-sdk.
Note the API is called jobs

@cicoyle Can I work on this?

@charan2628 Absolutely! Please assign yourself this issue by commenting ‘/assign’. Definitely refer to the go sdk example and reach out to me for additional assistance as needed

/assign

@cicoyle Can you please verify once my changes, so I can continue this approach

@charan2628 we will look into your changes.. I think that @artursouza already made some comments.


Fixtheproblem

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.
Resolved or fixed issue:
Affirmation

[ ] My code follows the CONTRIBUTING.md guidelines

this was suggested in error


Extension Host is unresponsive

Dear community,
I am sharing with you the issue "Extension Host is unresponsive"  that I have with my Vscode editor.
The extension that was causing this problem was " Bracket Pair Colorizer",
so I follow the steps in https://code.visualstudio.com/updates/v1_28#_extension-host-unresponsive" and I just Uninstall the extension and the problem was solved.
I hope it was helpful.

Thank you for your report. This warning has caused confusion and we will correct it, pls see #60318


show logical operator type in editor

closes #394

Consider also showing bundling somehow, i.e. start and end of parenthesis.


CI Failing due to CPU limits on Action Runners [bug]

Github hosted action runners have 2 cores.  With the latest PR adding Prometheus/Grafana to Qhub by default, the CI is failing because we are requesting ~2.5 cores from our minikube cluster, but as stated, we only have 2 cores.
https://github.com/Quansight/qhub/pull/733
I want to try using CIRun (https://cirun.io/), as an alternative which allows us to spin up Action Runners of various sizes only as needed.   @aktech do we have a Quansight account with access to CIRun?

the CI is failing because we are requesting ~2.5 cores from our minikube cluster

Ah interesting.

@aktech do we have a Quansight account with access to CIRun?

Yep we do have one via @quansight-bot

Amit let me know that some work has been done on this at https://github.com/aktech/qhub/tree/run-tests-cirun

Also, from Amit

Also, when you do that, I would suggest to move the kubernetes tests job to a separate file:
https://github.com/Quansight/qhub/blob/528bb850158d78d2eabdb561e1d37040052119a1/.github/workflows/test.yaml#L93

Waiting for a Quansight org owner to add the Cirun github app to the qhub repo

This was fixed here: https://github.com/Quansight/qhub/commit/265d6c5b8a1e01032402d4b2c94d12d5365e5e6e


Transients fail to compile when using boxed incomplete types

Hello! I've read that immer doesn't handle complete types in its containers, which is why it's provided box. I'm using box successfully, with vector, map, and set, but I'm unable to compile the transient forms of all of them.
A full reproduction case is included; I'm using the latest immer master and compiling with GCC 10.2.0 on Arch.
#include <iostream>

#include <immer/vector.hpp>
#include <immer/box.hpp>

struct object
{
  using vector_type = immer::vector<immer::box<object>>;

  int data;
};

int main()
{
  // This works fine.
  object::vector_type v;
  v = v.push_back(object{ 1 });
  std::cout << v[0].get().data << std::endl;

  // Fails to compile. Incomplete type.
  //object::vector_type::transient_type t;
}

The error I see from GCC:
❯ c++ -I lib/immer main.cpp
main.cpp: In function ‘int main()’:
main.cpp:20:39: error: aggregate ‘immer::vector<immer::box<object> >::transient_type t’ has incomplete type and cannot be defined
   20 |   object::vector_type::transient_type t;
      |                                       ^

Hi jeaye, vector_type::transient_type is incomplete in vector.hpp (uses forward declared vector_transient), so you just need to #include <immer/vector_transient.hpp>

Oh no! :facepalm: I'm sorry for the inconvenience. Thank you so much for pointing this out.

Thanks @jon-smith for the quick response!


fastlint init crash

Output and stack
password has been deleted.
You will have to re-run the recent command to use the new username/password.
DEBUG [2015-03-24 11:38:06.92]: [Transporter Output]: DBG-X: The error code is: -20101
FATAL [2015-03-24 11:38:06.92]: Transporter transfer failed.
WARN [2015-03-24 11:38:06.92]:
ERROR [2015-03-24 11:38:06.92]: Your Apple ID or password was entered incorrectly. (-20101)
FATAL [2015-03-24 11:38:06.92]: Return status of iTunes Transporter was 1: Your Apple ID or password was entered incorrectly. (-20101)
ERROR [2015-03-24 11:38:06.92]: Your Apple ID or password was entered incorrectly. (-20101)
Return status of iTunes Transporter was 1: Your Apple ID or password was entered incorrectly. (-20101)
FATAL [2015-03-24 11:38:06.92]: Could not download metadata from iTunes Connect! It's probably related to your password or your internet connection.
FATAL [2015-03-24 11:38:06.92]: Error occured with the setup program! Reverting changes now!
INFO [2015-03-24 11:38:06.92]: Deleting the 'fastlane' folder
/Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/app_metadata.rb:302:in `read': No such file or directory @ rb_sysopen - /tmp/956389856.itmsp//metadata.xml (Errno::ENOENT)
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/app_metadata.rb:302:in `parse_package'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/app_metadata.rb:66:in `initialize'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/app.rb:113:in `new'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/app.rb:113:in `metadata'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/deliverfile/deliverfile_creator.rb:59:in `create_based_on_identifier'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/deliver-0.8.0/lib/deliver/deliverfile/deliverfile_creator.rb:31:in `create'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/fastlane-0.3.0/lib/fastlane/setup.rb:80:in `ask_to_enable_other_tools'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/fastlane-0.3.0/lib/fastlane/setup.rb:18:in `run'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/fastlane-0.3.0/bin/fastlane:45:in `block (2 levels) in run'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/command.rb:179:in `call'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/command.rb:179:in `call'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/command.rb:154:in `run'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/runner.rb:421:in `run_active_command'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/runner.rb:81:in `run!'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/commander-4.3.0/lib/commander/delegates.rb:15:in `run!'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/fastlane-0.3.0/bin/fastlane:60:in `run'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/gems/fastlane-0.3.0/bin/fastlane:64:in `<top (required)>'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/bin/fastlane:23:in `load'
	from /Users/quanlong/.rvm/gems/ruby-2.1.5/bin/fastlane:23:in `<main>'

To set up your account, try starting with deliver first by running deliver init. Does your password contain any special characters? Are you behind a firewall?

It's succeed after rerun fastlane init

I realize what the problem was now. I named the project "fastlane" and the script was getting confused because it tried to generate a fastlane folder and found the project folder there instead.


feat(vital-signs): add vital signs narrative text

Jira: XDS-141

:tada: This PR is included in version 2.9.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I'd like to present my solutions and discuss with the course!

Repository
mobi-fs7-python
Access rights

[X] I hereby confirm that the supervisors can access my GitHub repository.

Git commit and push

[X] I hereby confirm that I have committed and pushed to my GitHub repository.

Lab session
Lab Session 2
Additional context for the comments
No response

Thanks!


write/xcoff: add support.

Convert this PR to draft for now, since this PR will rebase on #484.

@philipc Thanks a lot for your comment and I apologize for my late reply as I was on vacation last month. I just post a PR https://github.com/rust-lang/rust/pull/107583 to support metadata on AIX, which is related to this PR, specifically the C_INFO symbol here.

I think this is good to merge once CI is passing, so please continue working on fixes for that.

Thank you for your review. Checks are clean now.

Hi @philipc , what abstraction level do we expect from object crate? Is it user's responsibility to make the final object file legal?
For example, in XCOFF, there is a .info section, AIX toolchain expects the data inside this section is a sequence of string  whose first 4 bytes is the length of this string. When user appends data to this section, should user be aware of this knowledge?

The object crate will never be able to ensure that the final object is 100% legal. We rely on the user to have knowledge about the file formats and what they require. For the .info section specifically, the object crate will never validate the data that the user appends to the section. We could add a helper function that appends data in the correct format, but we wouldn't prevent the user from appending invalid data using other functions.

Thanks @philipc , I'll also validate this PR via bootstrapping rustc on AIX. I'll get it done as soon as possible.


Remove active column from events table. Closes #167

Coverage remained the same at 100.0% when pulling 8798d25150678505e192e44c616d385c41d28c05 on 167_removeActiveField into 22df70ed22828775315d64c1e37fc743253c0402 on dev.

Coverage remained the same at 100.0% when pulling 69492bca4edb6fb87b81578c5124b0e51775e5dc on 167_removeActiveField into c60f378b511d066f65b04962ffb651c18f5ef933 on dev.


项目不支持ARM平台吗

⚠ 搜索是否存在类似issue

[X] 我已经搜索过issues和disscussions，没有发现相似issue

总结
No response
举例
[+] Running 3/3
✔ Network root_default                                                                                Created                   0.1s
✔ Container chatgpt-on-wechat                                                                                Started                  29.0s
! chatgpt-on-wechat The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested                           0.0s
动机
No response

支持的，已经在树莓派平台成功部署

请看 #1335


Partial, which takes a table type and returns a type where all fields are optional

I currently have a ReplaceComponent function, which lets you patch over a component table with new fields.
I have types for my components, but unfortunately I can't seem to create types for patching without manually creating a second Partial version with everything ?.
TypeScript has Partial<T>, which does the following:
type Dog = {
    name: string,
    age: number,
};

type PartialDog = Partial<Dog>; // { name: string?, age: number? }

This would perfectly fit my use case.

I'm going to put this and other issues suggesting features for type-level computation in the icebox for now - the use case makes sense, but we currently aren't ready to contemplate this class of features for the type checker, as we have a solid roadmap for type checker fundamentals and a large rework of much of type checking in progress. Once we're solid on that we will reevaluate issues from the icebox, but for now that makes tracking easier.


Individual Icon import option

I've added all the icons as individual components and they can now be imported as
import ArrowLeft from 'react-bytesize-icons/lib/components/ArrowLeft'.
We can still import icons as we used to do previously, but the reason for doing this is when i'm only using 10 icons from a set of 94 icons my JS bundle increases significantly.
The icons bundle is almost 52K.Technically i should be importing those specific icons so i import few kb's from icon-bundle instead of whole 52K.
Hope my explanation is clear.
You can see the difference with both approaches in screenshot attached.

Hi @afzaalb this is great! I have one requests though: make sure the import path is short, so it should be import Info from "react-bytesize-icons/info"; as that's much more discoverable. Can you also add a little to the README.md under 'how to use'?

Icons can now be imported as import Twitter from react-bytesize-icons/Twitter.I've also updated the readme and added a link to this PR.  @Kilian

I will make a new release in the next few days, Thanks again @afzaalb!

Thank You !


"signed fields" for the representation of PIC S9 fields

Hi Ram,
I wonder if "signed fields" for the representation of PIC S9 fields (for example, PIC S9(5)   COMP-3.) are properly supported.
Thank you,
Anton

ok, it seems like PIC S9(5) COMP-3. are supported.


from_structured: add non-dimensional coords

E.g. a 2D DataArray with dims (y, x) but a time or layer "label".

Fixed in https://github.com/Deltares/xugrid/pull/202


Typo in documentation?

You may wish to override areStatesEqual to always return false (areStatesEqual: () => false) if you have impure reducers that mutate your store state. (This would likely impact the other equality checks is well, depending on your mapStateToProps function.)
This paragraph's last line says "is well"

Can you make this a PR instead of an issue? Just hit the little pencil icon at the top right of the file.


Update htype docs

Can we add some of the other information like compression, default dtype, and other htype-specific information? Not sure if that's the plan, or if you're aiming to merge asap?
The stuff in the PR is good, but it would be a lot better if we complete the job.

Can you remove the comment about "tensors with htypes can be visualized in platform."
Also, say "Specifying an htype allows for strict settings and error handling, and it is critical for increasing the performance of hub datasets containing rich data such as images and videos."


mock pa 2: checking isValid for Fraction.java

Under the sub() method in level 5, i have a snippet of code like this
Optional<Num> numerator = this.opt.flatMap(x -> f.opt.map(y ->
                        x.first().mul(y.second()).sub(x.second().mul(y.first()))));
     Optional<Num> denom = this.opt.flatMap(x -> f.opt.map(y ->
                        x.second().mul(y.second())));
AbstractNum<Num> top = new AbstractNum<>(numerator);
AbstractNum<Num> bottom = new AbstractNum<>(denom);
if (top.isValid() && bottom.isValid()) {
//create new frac
}

i create a abstractNum to store the optional and call the isValid() method, but somehow, even if top/bottom is an Optional.empty(), isValid() still returns true. can anybody help me to figure out why that happens?

hi im not sure on how your code works. But I can tell you that I left it in optional, filter and hashcode to check if it is valid.

To avoid explicitly checking for validity in the sub method, you can use the Optional
The subtraction operation (ad.sub(bc)) is performed within the map function of Optional. This ensures that if either x or y is empty, the mapping function won't be executed, and the resulting Optional will also be empty.

Can you check if your numerator and denominator are actually empty?
It also looks like you dont check if your numerator becomes negative or if your denominator becomes 0

The issue is that you need to check how isValid() works in the AbstractNum class.
It returns through whenever there is something within the optional, regardless of the value. You need to filter out the invalid values using a filter function and the predicate given to return an empty optional so that the isValid() works as you intend.

I think the best way to visualise it would be to see the Optional as a whole, so if the Fraction is valid, the optional should have a valid Frac which is a pair of 2 Num objects. If the fraction is not, it should have an empty Optional. That way, when you call a fraction1.isValid() for eg, it will invoke the AbtractNum class isValid() method and it should work well. That way your code becomes reusable also. All the best!

think for new AbstractNum<> it is good practice to include the type parameter. for instance: AbstractNum...

finals is over you can close this issue


Keep password case-sensitive in kvrocks2redis

This closes #964

@PragmaTwice Complete the refactoring according to your suggestion.

Thanks all, merging...


fix: R class fields alias

Hello, when deobfuscation processes fields, it does not check whether alias is already set in FieldInfo. As a result, you can see that the class R fields are renamed twice.
Without deobfuscation (alias set by AndroidResourcesUtils):
    public static final class array {
        /* renamed from: enum */
        public static final int pref_widget_font_sizes =<PHONE_NUMBER>;
        /* renamed from: ll1l */
        public static final int widget_theme_entries =<PHONE_NUMBER>;
        /* renamed from: null */
        public static final int pref_widget_font_families =<PHONE_NUMBER>;
    }

With deobfuscation (alias set by AndroidResourcesUtils and then replaced by Deobfuscator):
    public static final class array {
        /* renamed from: enum */
        public static final int f2654enum =<PHONE_NUMBER>;
        /* renamed from: ll1l */
        public static final int widget_theme_entries =<PHONE_NUMBER>;
        /* renamed from: null */
        public static final int f2655null =<PHONE_NUMBER>;
    }

This will work, but I suggest a more clear approach: in AFlag add something like DONT_RENAME, for generated or renamed fields in AndroidResourcesUtils add this flag (after check NameMapper.isValidIdentifier), and in Deobfuscator don't run rename if this flag exists. For methods needed to work with flags (add and contains) see IAttributeNode interface which FieldNode implements.

This will work, but I suggest a more clear approach: in AFlag add something like DONT_RENAME, for generated or renamed fields in AndroidResourcesUtils add this flag (after check NameMapper.isValidIdentifier), and in Deobfuscator don't run rename if this flag exists. For methods needed to work with flags (add and contains) see IAttributeNode interface which FieldNode implements.

I agree, this approach is better. In this PR, I can implement a check of the DONT_RENAME flag for fields only. For methods I think it is better to make a separate PR


can't ride rocket or access guidance computer 1.7.10

Version of Advanced Rocketry
AdvancedRocketry-1.7.10-1.4.0-16
Have you verified this is an issue in the latest unstable build
Y
Version of LibVulpes
LibVulpes-1.7.10-0.2.8-33-universal
Version of Minecraft
1.7.10
Description of the problem
Hello,
i have a double issue but maybe they are linked.
I upgraded advanced rocketry from 1.2 to 1.4.
I was able to mount on my rocket seat but something seemed strange. So i went down and try to access my guidance computer to check my moon chip. Impossible to access it like issue 1247.
Then i disassembled my rocket, there i can see my chip. I reassembled my rocket. No guidance computer access again. But worst i'm able to mount on my rocket seat anymore....

Ok, i dismonted totally the rocket and rebuilt it. So i can select moon, so there without any issue.
When i want to go back to earth, as i can't access to the chip, i select earth as destination and launch the rocket. It begin to consume fuel but rocket is not mooving... And i can take damage from nearby monsters, where is should not ....

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Android 13+ (API 33+) Needs runtime Notification Permission

Describe the bug
For Android 13+ to work and have Ongoing notification of BackgroundGeolocationService.java properly, we need to prompt the runtime notification permission. in lower Android versions this has not been needed.
To Reproduce
If you set up and config the plugin correctly, it will have Notification access, but you should also check Allow Notifications manual from App info settings of your app.
Expected behavior
Plugin must be cared about runtime Notification Permission for Android 13+
Smartphone (please complete the following information):

Device: Galaxy S20 FE 5G (SM-G781B/DS)
OS: Android 13
One UI: 5.1

Is this not addressed in the README? https://github.com/capacitor-community/background-geolocation#android

Yes, it is, but I don't know Java and Android too much, I don't know even where the runtime permission should be included in the code, in which file, which class, and which activity.
I mean it could be better if this case was handled by the plugin itself, if possible. or maybe a straightforward example.

Thank you for your fast response


[FEATURE] ChatMemory supports separate memory for different users

I want to develop a chatbot that supports group chat and single chat, and needs to have a separate MemoryChat for each user. I hope to support this feature, thanks!

@chenhaoqiang this is definitely possible. We will add this in the coming days.

thank you so much! But I ran into another problem，Please help me! #62

@chenhaoqiang support for a separate ChatMemory for each user was added in 0.19.0, please see example here.


Update min sdk version and remove redundant checks

Description (required)
Fixes #1131
What changes did you make and why?

updated minSdk version
removed redundant checks for lower SDK versions

Tests performed (required)
built and ran the betaDebug variant of the app. It seems to be working fine.

Codecov Report

Merging #2608 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2608      +/-   ##
=========================================
+ Coverage    2.69%   2.69%   +<.01%
=========================================
  Files         258     258
  Lines       12319   12304      -15
  Branches     1117    1110       -7
=========================================
  Hits          332     332
+ Misses      11961   11946      -15
  Partials       26      26

Impacted Files
Coverage Δ

...main/java/fr/free/nrw/commons/utils/DateUtils.java
0% <0%> (ø)
:arrow_up:

.../commons/contributions/ContributionController.java
0% <0%> (ø)
:arrow_up:

...ee/nrw/commons/upload/SpinnerLanguagesAdapter.java
0% <0%> (ø)
:arrow_up:

...e/nrw/commons/upload/UploadCategoriesRenderer.java
0% <0%> (ø)
:arrow_up:

...ava/fr/free/nrw/commons/upload/UploadActivity.java
0% <0%> (ø)
:arrow_up:

...ain/java/fr/free/nrw/commons/utils/DialogUtil.java
0% <0%> (ø)
:arrow_up:

...ava/fr/free/nrw/commons/filepicker/FilePicker.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1b003...d68ee44. Read the comment docs.


Page Design

We can move the logo to the left side of the nav bar.
Change the background colour from white to another light colour.
Add  dark mode.
Add some CSS to better the user experience .

Hi @Rohan0617e , assign this task to me.

Sir , please assign me this issue.

How does this work? do I fork and start working or should I get permissions?

From where is this sudden crowd coming from

Can I work on this?

hello sir,I want to work on this issue.please assign it to me

Hi @Rohan0617e , I want to work on this issue. I think i will resolve this issue.
Please, assign it to me.

hii rohan please assign me this issue i can solve it within lesser time.

Hello, @milligram I'm interested in contributing to this project and I noticed the issue you posted.
Could you please assign this issue to me.
Thank you!

hii @Rohan0617e illigram please assign me this issue i can solve it within lesser time.


Changed icon and remove unnecesary import

Description
The filter icon on search functionality is confusing for the user.
Changes proposed in this pull request:

Changed filter icon to search
Deleted import Luigi, because I forgot about it in #819
...

Related issue(s)
Closes #833

/test pre-busola-integration-test-k3s


check ppa subset of eebo-tcp xml contents (div types, inline elements, check for notes)

rerun xqueries on ppa subset of eebo-tcp (div types; check for notes)

inline elements:

milestone

example xml <MILESTONE N="5" UNIT="argument key no."/>
example display "[argument key no. 5]" - https://quod.lib.umich.edu/e/eebo/A12229.0001.001/1:4.2?rgn=div2;view=fulltext

figure; figure in a marginal note
empty list item in a list of plays
gap inside a stage tag (?) with place=marg (margin)
lb tag (line beginning)
empty paragraph tags
empty table cell ->

elements we're not handling;

table:

example on page 899 https://quod.lib.umich.edu/e/eebo/A04632.0001.001/1:160?firstpubl1=1470;firstpubl2=1700;rgn=div1;singlegenre=All;sort=occur;subview=detail;type=simple;view=fulltext;q1=payre+of+naked+feet
example search result https://test-prosody.cdh.princeton.edu/archive/A04632/?query=+payre+of+naked+feet

Here's a list of all the unique div types that occur in our subset of documents (have not restricted it to page ranges for excerpts):
eebo_tcp_divtypes.txt

Here are all the note types that occur in our subset:

marg (~ margin)
foot
foot1  (occurs once, in A52335 on <PB N="xxv" REF="163"/>; typo?)
inter
parend (~ paragraph end?)

Here's an example marginal note:

xml: handling of that subject,<NOTE PLACE="marg">§. I.</NOTE> I have here proposed
eebo-tcp displays it as a linked footnote: https://quod.lib.umich.edu/e/eebo/A66045.0001.001/1:7.1?rgn=div2;view=fulltext
ppa current display /archive/A66045/?query="handling+of+that+subject"

Here's an example of an "inter" note (also displayed at end):
https://quod.lib.umich.edu/e/eebo/A65112.0001.001/1:5?rgn=div1;view=fulltext#backDLPS2
Example of "parend" note, also displayed at end: see page 152
https://quod.lib.umich.edu/e/eebo/A29229.0001.001/1:8?rgn=div1;view=fulltext#backDLPS3

@rlskoeser thanks for these notes! I think it makes sense to me, and appreciate the detail. A few initial thoughts:

What does it mean that we're not handling tables? In the example from page 899 you provide, the PPA search result is kind of what I'd expect - string of text without the table formatting. Because the search still comes up, it doesn't seem like a problem to me, but maybe I'm missing something.
Are the "inter" notes and "parend" notes also displayed inline in PPA search? Would we force the text to appear somewhere else (end of page or end of text?), and would that be better? Because it appears in search, it doesn't seem like a problem to me because the user can click on the page image thumbnail for clarification. But I'm curious have an idea to make it better, and how easy/hard it would be to implement.
Side note that I tried to check how the "inter" note displays for A65112 and couldn't get any search results at all. Hopefully it's a simple issue like it needs to be reindexed? But thought I'd flag.

ok! figured out a way to query solr to see what the plain text looks like (I tried using the corpus export but that was too slow/inefficient).  I'll share how these look in plain text in the format we're generating now to help us decide what (if any) action to take).
tables
Here's what the beginning of the table content that I linked above looks like (example p.899):

The Names.
The Symboles.

The Queene.
1.
EVPHORIS.
1.
A golden tree, laden with fruit.

Co. of Bedford.
AGLAIA.

La. Herbert.
2.
DIAPHANE.
2.
The figure Isocaedron of crystall.

Co. of Derby.
EVCAMPSE.

If we care about how the table looks in plain text, we might want rows to appear on a single line - but I'm honestly not sure we care about this for either the webapp or the nlp work.  There are libraries that will generate nicely formatted plain text tables but that seems like overkill for both of our use cases.

Documenting for myself how I'm doing this in django shell in case we need to do this again:
from ppa.archive.solr import PageSearchQuerySet
psq = PageSearchQuerySet()
result = psq.filter(source_id='A04632', label=899).also('content')[0]
print(result['content'])

inline note
Here's an example of the text we're currently generating for inline note (example p. 5). I'm putting the text of the note in bold.

another. So there are several words common to the Turks, Germans,Boxhorn. Origin. Gallic. cap. 6. & 8. Greeks, French, sometimes of the same, and sometimes of several significations; which is not sufficient to argue that all these were of the same Original.

We're currently including the text of the note inline with no spacing or indication that it's a note.
I think we should either omit the note entirely or we need to put it at the end of the page with the number. Omitting is easier;  putting it at the end of the page is a small effort.

Following on your side note: I reindexed all the eebo-tcp content and I'm getting page results for the ones I've tested, so hopefully that's no longer a problem.

@mnaydan thanks for finding this - I wondered if there were any like this, I'd only seen the short notes but I know you all have talked about poetry excerpts showing up in footnotes.  I agree, this seems worth the effort to include the notes at the bottom of the page text.  (This may be useful for other goals too.)
Can we use the same approach for all note types, including marginal notes?

@rlskoeser I don't see why not. I think transforming all note types to appear at the bottom of the page makes sense.

@rlskoeser you want to close this issue and create a new one tracking the dev work needed for the change?

@mnaydan you read my mind. Yes, that would be great.


Cannot clone logtalk, no correct access rights

In response to this:
ulrich@p0:~$ cd /opt/gupu/
ulrich@p0:/opt/gupu$ git clone git@github.com:LogtalkDotOrg/logtalk3.git
Cloning into 'logtalk3'...
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is 7b:99:81:1e:4c:91:a5:0d:5a:2e:2e:80:13:3f:24:ca.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
ulrich@p0:/opt/gupu$

Nothing to do with the Logtalk repo. You're trying to clone using a SSH URL, which requires creation of an SSH key pair on your computer and adding the public key to your GitHub account. Use the HTTPS cloning URL instead.

See also https://docs.github.com/en/repositories/creating-and-managing-repositories/troubleshooting-cloning-errors

Thank you! The interface must have changed since last time I cloned. Yes, it was too obvious for me...


[CI] Fix turbo build

Description
Saw the following error
wallet-kit-site:build: It looks like you're trying to use TypeScript but do not have the required package(s) installed.
wallet-kit-site:build:
wallet-kit-site:build: Please install @types/react by running:
wallet-kit-site:build:
wallet-kit-site:build: 	pnpm install --save-dev @types/react
wallet-kit-site:build:
wallet-kit-site:build: If you are not trying to use TypeScript, please remove the tsconfig.json file from your package root (and any TypeScript files in your pages directory).
wallet-kit-site:build:

in https://github.com/MystenLabs/sui/actions/runs/4412694507/jobs/7732961648
Test Plan
Cherry-pick to https://github.com/MystenLabs/sui/pull/9234 to test

Will probably merge with https://github.com/MystenLabs/sui/pull/9234 since it can only repro in that PR


Add dark mode vim-plug logo and use correct logo version in README

The vim-plug logo in the README wasn't visible in dark mode due to black lettering on a dark background. This PR fixes this by adding an color-inverted version of the logo, and using the right version in the README depending on the result of the prefers-color-scheme CSS media query.

Ready to be merged?

Merged, thanks!


Add Coveo to the list of Falco adopters

Signed-off-by: Jean-Philippe Lachance<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7786ec72b134497ce0c135ca0c50397b7556d565

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JPLachance closing and reopening to trigger tests again - I don't know why it didn't work. Once everything is green this will be automatically merged. Thanks again!


Can lowPowerMode of WIFI Nina be used on combination with streams

Can the low power mode (https://www.arduino.cc/reference/en/libraries/wifinina/wifi.lowpowermode/) of WIFI NINA be used when only using streams?

This is library operated in application layer.
The network interface layer e.g. WiFi can be controlled by user.


defineEntityIndexComponent in std-client

Currently I am using defineNumberComponent to store entities and I cast the component value to an EntityIndex. Having a built-in defineEntityIndexComponent in the std-client makes code more legible and adds some type safety.

oh this does exist hehe

Sike there is one for entityId, but not one for entity index. Having both would be nice

this package has been removed


Tiny UI flaw when using standard popover

Once again, great work. When I use the standard popover, I notice this very tiny UI flaw. It is essentially a small nick. It is only visible when using. .mostCounterClockwise and .mostClockwise
Is it somehow possible to fix this, either on your end or mine?

If interested, this is How I apply the code:

.popover(
    present: $present,
    attributes: {
        $0.sourceFrameInset.top = -8
        $0.position = .absolute(
            originAnchor: .top,
            popoverAnchor: .bottom
        )
    }
) {
    Templates.Container(
        arrowSide: .bottom(.mostClockwise),
        backgroundColor: .green
    ) {
        Text("This is a pretty standard-looking popover with an arrow.")
            .foregroundColor(.white)
    }
    .frame(maxWidth: 300)
}

Similar to https://github.com/aheze/Popovers/issues/40

I’ll need to fix this later, but for now you can do “Templates.BackgroundWithArrow.arrowSidePadding = 2.5” inside an onAppear or init and it should work.

@aheze the issue seems to somewhat correlate with the corner radius. Perhaps calculating the padding based off the corner radius would fix it

I recently came across this library. And it has been very useful. However, I am also facing the same issue @NickG-DK mentioned.
Setting the Templates.BackgroundWithArrow.arrowSidePadding using onAppears works, but it would really appreciate if there was a proper fix for this in the library itself.
Or perhaps having arrowSidePadding  parameter in the Templates.Container itself would be a nice addition.

I recently stumbled upon this library, and it has proven to be incredibly useful. However, I have encountered the same issue that @NickG-DK mentioned.
As @aheze  pointed out, adjusting the Templates.BackgroundWithArrow.arrowSidePadding using onAppears does work, but it would be highly appreciated if there were a more permanent solution within the library itself. Alternatively, adding an arrowSidePadding parameter to the Templates.Container would also be a valuable enhancement perhaps.


License?

Hi,
Thanks for creating this library. Which license does it use?
https://help.github.com/en/articles/licensing-a-repository
Cheers

Hi,
I've added a license file,
I guess that's the most free and open for all license :)
Effy

Thank you!

@codecontemplator Glad I could help :)


[AMQ-9447] Added Logic to check underlying transport connector limits

Hello Team,
With Regards to Transport Connector, Have added a check based on the connection count.
Also in the ticket, With regards to JDBC Persistence Check, We may need to have JDBC persistence associated classes in activemq-broker,jar, Post that we can have a logic something like following:
        if (brokerService != null && brokerService.getPersistenceAdapter() != null          		&& brokerService.getPersistenceAdapter() instanceof JDBCPersistenceAdapter ) {         	JDBCPersistenceAdapter jdbcAdapter = (JDBCPersistenceAdapter) brokerService.getPersistenceAdapter(); 			String message = "Issue with Persistence layer";             try {             	ResultSet rs = null;             	Statement stmt = jdbcAdapter.getDataSource().getConnection().createStatement();             	rs = stmt.executeQuery("SELECT 1"); 				String message =              	if(rs.next()) 					if(rs.getInt(1)!=1) 						answer.add(new HealthStatus("org.apache.activemq.store.jdbc.JDBCPersistenceAdapterIssue", "ERROR", message, jdbcAdapter.toString()));             } catch(Exception e) {             	answer.add(new HealthStatus("org.apache.activemq.store.jdbc.JDBCPersistenceAdapterIssue", "ERROR", message, jdbcAdapter.toString()));             }                     }
Ive Tested the above and it works as expected. But again that would require whole jdbc persistence adapter code.

That's a good start, on Tcp transport. I will add additional more "specific" transport (like http/https/ws transport).

Hello @jbonofre
Have Re-opened as #1194
Sorry for the inconvenience.
Thanks
Anubhav


Be able to cancel image.decode operations

Thanks @ahocevar  for the hasListener idea !

I didn't see this before putting up #9558.  I think we can simplify things by just returning an unlisten function in all cases.

#9558


Patch parent node RPC error

This PR creates a patch to the RPC error that causes missing validator changes to the running cluster. It ignores the validator changes from the RPC node and returns empty array.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update dockbit test

  7) Dockbit
       deploy status

	[ GET /DockbitStatus/health.json?token=TvavttxFHJ4qhnKstDxrvBXM ]:
     ValidationError: child "value" fails because ["value" must be one of [success, failure, error, working, pending, rejected]]
      at Object.exports.process (node_modules/joi/lib/errors.js:201:19)
      at internals.Object._validateWithOptions (node_modules/joi/lib/types/any/index.js:751:31)
      at module.exports.internals.Any.root.validate (node_modules/joi/lib/index.js:146:23)
      at Object.pathMatch.matchJSONTypes (node_modules/icedfrisby/lib/pathMatch.js:303:9)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:563:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

In production this is returning:
{
name: "deploy",
value: "not found"
}

It probably needs a new project.
Ref #1359

@paulmelnikow Nope, service has been discontinued. I've opened #2410


Ajax should utilize more complete promise

I find it confusing and limiting when the Ajax call returns a promise but doesn't utilize the reject capability.
So instead of handling success/failure in the resolved promise (the then()):
ATV
			.Ajax
			.post('someURL', {data: data})
			.then((xhr) => {
				// xhr succeeded
			}, (xhr) => {
				// xhr failed
			});

You would have more true promise-based logic using then() and/or catch() and/or finally():
ATV
			.Ajax
			.post('someURL', {data: data})
			.then((xhr) => {
				// xhr succeeded
			})
			.catch((xhr) => {
				// xhr failed
			})
			.finally(() => {
				// regardless of success/failure, also do this
			});

For developers who understand promises, the current implementation seems halfway done. It also prevents normal promise chaining, which flattens out the old "callback hell" problem.

@DavidFrahm Can you please be more elaborate? The library implementation of ATV.Ajax is 100% promise compliant and you can do ATV.Ajax.get(/*params*/).then(/*success*/).catch(/*error*/).
As far as finally or done is concerned, it's not part of the standard ES6 or Promises/A+ specs. If you need those sugars, you can ditch atvjs provided ajax in favour of other libraries that provide finally/done out of the box. By the way even the native fetch would give you the same then/catch, without finally, as it's not part of standard promise specs :)
Provide more infos if you meant something totally different that I somehow missed here, else can we close this issue?

Definitely... I should have played with the code more. I just based my request off of the sample code (which never shows a catch()) so I assumed it didn't work.
And the finally() I should not have combined in my example code for what I expected or wished for.
I would recommend changing the sample code to be more fully promise based to suggest best practices, however that's just my opinion.
BTW, Thanks for everything you've done with this incredible project. It is enabling our team to experiment with some Apple TV stuff while still remaining mostly-JavaScript focused.

I would recommend changing the sample code to be more fully promise based to suggest best practices, however that's just my opinion.

Sure, I totally agree that the sample code should have been more thorough, my apologies. Due to the lack of time I'm not able to invest more effort to this project, and being the sole developer, it gets difficult to show all possible use cases through examples and sample code. There's a lot baked into the library, and the documents and examples just scratch the surface. I've created milestones and issues to tackle every aspect of possible enhancements to the project, including documentation updates, will definitely take it further, but expect delays unless there are more contributors.

BTW, Thanks for everything you've done with this incredible project. It is enabling our team to experiment with some Apple TV stuff while still remaining mostly-JavaScript focused.

I'm glad it's working out for your team, that was the whole point of open sourcing this, fast prototypes without much noise. I did not want other JavaScript developers to have the same frustration that I went through writing the initial TVJS application. By the way, it's not just for the experiments and prototypes, I can assure you there are many full fledged complex streaming apps (couple of which I hand coded myself) running in production, written solely using atvjs. May be you'd find below links useful.

Movie Catalog App
AppleTV App Boilerplate
Building AppleTV App - Presentation

And do spread the word about atvjs, spread the love ❤


Fix 27086. Ignore directories starting with a dot.

Fix for https://github.com/Microsoft/TypeScript/issues/27086 .
If we find a folder in @types with a name starting with . (dot), and this folder doesn't have a package.json file, then we should ignore this folder, and not throw an error.

Could use a test -- tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts containing:
// @noImplicitReferences: true

// @Filename<EMAIL_ADDRESS>declare const a: number;

// @Filename<EMAIL_ADDRESS>declare const a: string;

// @Filename: /a.ts
a;

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: valera-rozuvan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@andy-ms I have updated this PR as per your suggestions.

@typescript-bot test this

@ahejlsberg Can you please review? It seems @sheetalkamat is OOO.

@ahejlsberg Can you please review? It seems @sheetalkamat is OOO.


Include pg_activity in base image

We find ourselves to be installing this quite often to track performance and concurrency issues, so it's better to bundle it.

Why <1.5?

1.4.0 is the latest available. I don't think they will change dependencies before 1.5, if ever.
Recently we had https://github.com/Tecnativa/docker-odoo-base/pull/140 problem and I don't want to repeat it. Almost all packages are version-pinned here, so this one too.

I prefer to not put that kind of limitation. If there's any incompatibility, then we will fix it freezing in that moment, but not before. And this kind of dependency is very soft, so in the worst case, we won't get pg_activity working, not Odoo.

Chances that something is broken are low, but are still higher than the chance that there's something new in pg_activity 1.5+ that we really can't wait for, so I'll stick with the conservationist preference this time if you don't mind.

Sorry, but no, please free the version.


Update Jenkins CI on savelogs and ns deletion

delete ns after get-secret fails
fix savelogs command not found issue
e.g. https://jenkins.antrea-ci.rocks/view/antrea-for-pull-request/job/antrea-conformance-for-pull-request/610/console

/skip-all


Auto change the number of games per line

(Im on a 1440p screen so, these screen shots don't show off the issues very well...)
Older phone screens (600px)

This should probably be 1 per row
When the screen is narrow (900px)

This should probably be 2 per row, maybe even 3 per row.
When the screen is normal (1920px)

This should probably be three or four.
When the screen is wide (2,560px)

I'd go for 5 or 6 for wider than normal screens

Yeah, I asked @local-minimum to get width controls working (see the tiny gear hiding between the filters bar and games themselves). Mobile vs Desktop needs different defaults, and IMO there's no reason to be able to select 1-wide on Desktop.

This is not implemented yet, issue should be re opened.

Oh sorry, I missed the word "auto".


Wrong error message on login

The message error in Red is : [{"name":"usernamePasswordMismatch","message":"Invalid username and password combination."}]

I know, it's already on my list !
Thx for reporting :)

Fixed in Gladys 3.0.


Can't acces example-robot-data path

Hi
I'm using ROS2 humble on Ubuntu 22.04, coding in python.
I'm trying to implement Pinocchio example in my own ROS2 package but I am facing an issue: accessing example-robot-data path (for getting .urdf and .srfd).
In the example join(dirname(dirname(str(abspath(__file__)))),"models") is used, but this does not work in other packages than Pinocchio.
I've tried two installations:

The one from Debian using openrobotics, but then example-robot-data is in /opt/openrobots/share/example-robot-data and I haven't found a way to access it other than using the absolute path.
The recommended one by cloning the repo in my workspace, but after the usual colcon build, example-robot-data is in the install directory, but isn't found by nether ros2 pkg prefix or get_package_share_directory.

For now I'm using the absolute path from openrobotics, but is there a better way to do it?

Now, I understand your issue. This code is designed to work within Pinocchio.
If you want to use the Romeo humanoid robot, then do
import example_robot_data

romeo = example_robot_data.load("romeo")
print("this is the Pinocchio model", romeo.model)

Please next time try

To understand the code on your own. This has nothing to do with Pinocchio or example-robot-data
To create an issue in the right repository.

We are a small team with many responsibilities and I cannot answer each one's question. I hope you can understand this.


[Request] Check all accounts when clicking a discord jump link

I usually hate when people remove templates, but the default one for feature requests is garbage, and I can describe it better without.
When clicking on a Jump URL, sometimes the currently signed-in user doesn't have access to view it. If they don't, they get an error like this:

If this happens, it should cycle through the different accounts until one returns a proper response and then jumps that channel on the specified account.
Just an idea that would help me a lot. I have an account for work I need to switch back and forth between, and sometimes I like to link to channels I can't access on my main account. This would save a little bit of time!

To check automatically which account has access would require a connection to discord which I really do not want to do, that could easily get flagged for being a selfbot, or it would require quite some storage space to save all channel ids for every account and then it might not even be correct anymore, maybe you left the sever or got kicked. And just trying with every account is definitely not something I would do, first bc there might not be a single account and secondly bc that is a very bad solution to this problem.

What about right-clicking jump URL, Jump to as > Account names? This is essentially the same effect minus all the unnecessary stuff.


Upgrade ruby/setup-ruby v1.121.0 -> v1.122.0

This PR contains the following updates:

Package
Type
Update
Change

ruby/setup-ruby
action
minor
v1.121.0 -> v1.122.0

Release Notes

ruby/setup-ruby
v1.122.0
Compare Source

[ ] If you want to rebase/retry this PR, click this checkbox.

@Stephan202 yes let's do that. Every 3 weeks seems perfect to me 😄. I can open a PR for that.

New suggested commit message:
Upgrade ruby/setup-ruby v1.121.0 -> v1.123.0 (#345)

See:
- https://github.com/ruby/setup-ruby/releases/tag/v1.122.0
- https://github.com/ruby/setup-ruby/releases/tag/v1.123.0
- https://github.com/ruby/setup-ruby/compare/v1.121.0...v1.123.0


chore(rnw): update from 0.1.13 to 0.6.0

Why
react-native-web version is too old. #61
What
update to 0.6.0
And
Close #61

but @piranna where is the test codes ?

but @piranna where is the test codes ?

Unluckily there are no tests :-( I was thinking a test would be to create a project using the templates and check if they work, but react-native has a bug and templates needs to be published on npm to be used... :-/

[offtopic] by the way, I love your avatar :-)

👍  thanks for your great work.

thanks for your great work.

You are welcome :-)


Create a tests bundle for maven

Right now, test classes are not pushed to maven.  However, some test classes are useful for users to test their own code locally, like LocalGcdHelper.

It does look we can push test artifacts and people can use them using a test-jar type.
I can see a potential value in having a test artifact (e.g. we could share base test classes,..) but
at the moment the only thing we care about is the test helper LocalGcdHelper and soon RemoteGcsHelper.
Another option we can take is to move these test-helpers which are not tests themselves to a "testing"
sub package in the main src directory (e.g. com.google.gcloud.datastore.testing.LocalGcdHelper in src/main).
The benefit of the latter is a greater visibility.
Thoughts?
/cc @ajkannan @mziccard @jgeewax

I see 3 options here:

Text artifact with test-jar type: people can re-use test classes (not only LocalGcdHelper and RemoteGcsHelper) and run the tests contained in the jar
Put helpers in a testing package inside each module's src
Create a gcloud-test module and put all helpers there

is the most flexible solution and also allows users to re-run tests from the jar (even though I struggle to find a reasonable use case for this for a user), 2) is also ok as I expect users to only reuse helpers, this also gives helpers more visibility and allows us to document their usage in package's javadoc 3) Has the same benefits of 2 (maybe less visibility?) and also puts all helpers in the same module.

I don't have a strong opinion. If we want users to reuse and rerun tests we must go with solution 1. Otherwise I think solutions 2 and 3 as equally good (I have a slight preference for 3).

I like the submodule option 2.  I agree that it's hard to find a use case for option 1, and I have a slight preference for 2 over 3 since option 2 automatically gives users the relevant test classes without having to list another dependency.

I have slight preference for option 2.
Mostly because I think it is simple and likely to have the best visibility (including a place to document it, per service,  in their respective package-info).


[BUG] Modal Responsiveness

Is there any existing issue for this?

[X] I have searched the existing issues

Description
Modal isn't looking nice on mobile view
Screenshots

Any additional information?
Modal should look nice on all screen sizes
What browser are you seeing the problem on?
All Browsers

Eugene44-hub I could not find that bug.
Can you provide the link of that bug?

Hi, I would like to work on this issue...

Hi, I would like to work on this issue...

Hi, thanks. you can start working on this


Some logos are not properly visible

Some logos in Internship and Full time are not properly visible

see my pull req.


Ablation experiment

How can I run only Backbone in the code without PDD、RA、EA.

you can remove them and then just retrain the ablative model