replace hand-rolled lexicalCast

High Level Overview of Change
Replace hand-rolled code with std::from_chars for better performance and maintainability. The only minor change in semantics is the inability to parse the + sign, but that functionality is unused in practice.

Context of Change

Type of Change

[x] Refactor (non-breaking change that only restructures code)

better performance

Can you quantify the change in performance in any way?

better performance

Can you quantify the change in performance in any way?

This change does not have a directly measurable impact in performance and synthetic benchmarks are unlikely to be helpful. The C++ std::from_chars is intended to be as efficient and fast as possible and it's unlikely that it will be any slower than the code that it replaces. And given that it also reduces the amount of hand-rolled code it's a net gain.

I'm reluctant to remove support for parsing + sign.

@gregtatcam why?

I'm reluctant to remove support for parsing + sign.

@gregtatcam why?

I agree that it's probably not used in practice. But are we 100% sure that it's never used? And it's easy to add support for + parsing.

are we 100% sure that it's never used? And it's easy to add support for + parsing.

@dangell7 thoughts?

@dangell7 can you address the '+' issue as discussed above?

Optional drive-by fix: #include <iostream> is unnecessary and adds a small amount of code bloat. Needs removing from LexicalCast.h.

Thank you for this. Building and testing now. Is there a program you're using to identify these or any recommendations you can make?

Is there a program you're using to identify these or any recommendations you can make?

No program. <iostream> is the only header in the std::lib that can cause a slight run-time cost just for including it. So it's special and Howard tends to look for it.


groups/channels: connection and saga visibility

This includes @jamesacklin 's previous work to add connection indicators everywhere in #2698. This PR adds on top of that to also include protocol compatibility checking and adds a few more places to check including the invite dialog and all channels list as well as anywhere that we perform actions on the group/channel.
Fixes LAND-532

Checked this out locally (and committed the desk changes), connectivity indicators look good and function.
Is there a way I can bump a saga here or there to check out the disabled states?

You might have to commit the backend changes to the moon? unless you did that already. I know we see those messages when we try to cache an error response (which we should probably handle).

@latter-bolden Feel free to add interactivity blockers to:

drag action in All Channels
edit capabilities for each channel and creating/deleting channels in All Channels

The "Leave" should stay; you should be able to leave regardless of protocol version.


Full Color Icons Explanation

Add description on how to use full color icons. (With CLA signed now).
This repo is currently on low maintenance. See README for details
What are you trying to accomplish with this PR?
Please provide a link to the associated GitHub issue.
Checklist
For contributors:

[x] I have updated the docs to reflect these changes, if applicable.

For maintainers:

[ ] I have :tophat:'d these changes.

Solves this issue: https://github.com/Shopify/slate/issues/298


The bar format is saved between the instances

Hi! If I use a progress bar with custom format defined, for example:
const bar = new _cliProgress.Bar({
                format: 'Downloading [{bar}] {percentage}% | ETA: {eta}s | {value}/{total}',
            }, _cliProgress.Presets.shades_classic);

Then I see a bar with Downloading prefix, as expected. Later, I create a new bar with default options, i.e.:
const bar2 = new _cliProgress.Bar({}, _cliProgress.Presets.shades_classic);

I expect to have a progress bar without any prefix, i.e. the default output format:
[{bar}] {percentage}% | ETA: {eta}s | {value}/{total}

But in this case I also see the Downloading prefix. To solve this issue, I always have to define the format, otherwise a new object will use the format of the previous object. I think that's not a correct behavior.

Hi @rvalitov ,
thanks for your report.
of course..it's a bug within the preset processing: the options are overriding the preset object properties. i will fix it asap.
best regards, Andi


Proper handaling of outdated mods

Geode Version
v2.0.0 beta 12
Related Problem
Currently, if a mod cannot be loaded because it has been designed for an older version of geode, the warning "some mods failed to load" will be displayed with nothing else happening.
The only way to remove these mods is to delete the .geode files manually
Suggested Solution
a pop-up is displayed listing the incompatible mods and providing the option to delete or ignore the mods
Additional Information
No response

fixed with d9c65b3


Email Template Directory For devise_token_auth

Version: devise_token_auth (1.1.3)
I want to use app/views/devise_token_auth/*.html.erb files as email templates if there are any files in the directory.
Because when I want to use both devise and devise_token_auth, this gem use app/views/devise/mailer/*.html.erb files as email templates. It causes a problem that confirmation link in confirmation email is always confirmation_url even if developers want to another controller like Api::V1::ConfirmationsController.
For example,
devise: Registrations → app/views/devise/mailer/*.html.erb → confirmation_url in email
DTA: Api::V1::Registrations → app/views/devise_token_auth/*.html.erb  → api_v1_confirmation_url in email
If you have any ideas about this issue, please let me know. Thanks!

I found a code that sends a confirmation_instruction email.
https://github.com/lynndylanhurley/devise_token_auth/blob/387306a180e955da077a67a6b77b1feda9497202/app/models/devise_token_auth/concerns/user.rb#L57-L66
Unfortunately, Is send_devise_notification method implemented in devise?
So, this is not just a issue of devise_token_auth.

I tried to switch the confirmation url in the template by Class name like this.
= controller.controller_name == Api::V1::RegistrationsController : api_v1_user_confirmation_url : confirmation_url

But it cause error.
[16] pry(#<#<Class:0x000055bef54980e0>>)> controller.controller_name
NoMethodError: undefined method `controller_name' for #<Devise::Mailer:0x00007f94540f2400>
from (pry):15:in `_app_views_devise_mailer_confirmation_instructions_html_slim__4327844298565262421_70137521114820'

Does anyone know how to switch the url in the template ?

Temporally I resolved by using instance variable to pass the confirmation url by each RegistrationsController, I don't know why I used such easy way such easy way :)
However I suggestion that DTA has email template directory option.


Test suite fails with OTP 21.2

When we upgrade .travis.yml otp_release from 21.1 to 21.2, we get a test failure. On closer examination, it looks like a nif is crashing the BEAM.
Expected Behavior

make javascript should pass
Current Behavior

make javascript fails with:
test/javascript/tests/config.js                                Error:
FAIL isRunning
Stacktrace:
	waitForSuccess((function () {CouchDB.last_req = CouchDB.request("GET", "/");return typeof CouchDB.last_req == "object";}),"isRunning")@test/javascript/test_setup.js:64
	@test/javascript/cli_runner.js:46
Failed to execute script.
fail

However, when run on it's own make javascript suites=config passes, as does make javascript suites=compact. However, looking at the couch logs for the latter, there is this suspicious entry:
nifs/common/prim_file_nif.c:388:[notice] 2018-12-28T07:41:03.834726Z<EMAIL_ADDRESS><0.3868.0> aaa8c4d9b0 <IP_ADDRESS>:15984 <IP_ADDRESS> undefined DELETE /test_suite_db_lvxwriai/?sync=true 200 ok 10
owner_death_callback(): Internal error: Failed to defer prim_file close.

My hypothesis is that during the full suite run, the nif crashes the BEAM at the end of compact.js after it passes, but then config.js fails to run because the db process crashed from the previous test.
Possible Solution

Steps to Reproduce (for bugs)

Install OTP 21.2 (currently brew install erlang will do that on a mac)
make javascript

Context

Discovered when attempting to upgrade .travis.yml but reproducible locally on a mac.
Your Environment

Version used: latest development master
Browser Name and version: N/A
Operating System and version (desktop or mobile): macos 10.13.6
Link to your project:

I checked the release notes for 21.2., and didn't see anything obviously related to changes in nifs.

I wonder if it is this commit:
https://github.com/erlang/otp/commit/d15bd6b9366ff4eef81ec9c4bcc875dfe694fe98#diff-2d07be10f253f2c53640f98f104b3f23
It landed in the 21.1.x series sometimes in Nov 13. 21.1 was released in Sep.
The crashing line is:
https://github.com/erlang/otp/commit/d15bd6b9366ff4eef81ec9c4bcc875dfe694fe98#diff-2d07be10f253f2c53640f98f104b3f23R387
enif_send say that it either fails if calling env process is dead or the that prim_file (the destination) is dead. I suspect it is the sending process that's dead. But then also wonder how come it wasn't crashing  in routine tests, as a process with an open handle dying would trigger this issue...
http://erlang.org/doc/man/erl_nif.html#enif_send

Confirmed it's an Erlang/OTP bug. Filed it as: https://bugs.erlang.org/browse/ERL-821


viewWillAppear , viewWillDisappear are not called

Hello, the viewWillAppear and viewWillDisappear  methods are not called when app start for the main center viewController, but if I navigate to another view and then go back to this view those method are called normally. so it's just for first time before any interaction with the app viewController

+1, facing the same issue

+1, same issue

+1

+1

+1

+1

+1

+1

+1, please fix.

+1 !!!

+1

+1

anything on this?

+1

+1

+1


bug fix 2518

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes

[ ] Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

#379 is going to fix the issue this pull request was opened for.


Java migration dev devops changes

CI: No IaC security warnings found

CI: No IaC security warnings found

CI: No IaC security warnings found

CI: IaC Security warnings found!

CI: No IaC security warnings found

CI: IaC Security warnings found!

CI: IaC Security warnings found!

CI: IaC Security warnings found!

CI: No IaC security warnings found

CI: IaC Security warnings found!

CI: No IaC security warnings found

CI: No security warnings found


Update script-api.md

tiding up functions with alternative names

This file is auto-generated from https://github.com/spelunky-fyi/overlunky/blob/main/docs/generate.py so any changes have to be made to the generator and not to the file directly


Problem measuring multiple Qubits

I am writing the teleportation program. The message seems to be teleported correctly (just need to add the correction gates only), but i get the wrong results when I measure the 0th and 1st qubits. Even though I get the correct waveform for the result, when I measure the qubits, I get different values.  Here is my teleportation program:
ins = pq.Program()
ins.inst(I(1), H(1), I(2), CNOT(1,2))  #Creating Bell State 00
ins.inst(H(0), Z(0), CNOT(0,1), H(0)).measure(0,0).measure(1,1) #Teleporting (|0> - |1>)/√2

results = qvm.run(ins,  [0,1])
print results[0]
wvf, _ = qvm.wavefunction(ins)
print wvf

When I run the program, I don't usually get the right results. Some wrong results that I get:
[0, 1]
(0.7071067812+0j)|011> + (0.7071067812+0j)|111>

[1, 0]
(0.7071067812+0j)|011> + (0.7071067812+0j)|111>

Which I think is incorrect because both should return [1,1].

hey @rasa97, I'm not quite sure why you're having that issue with the [0,1] classical addresses. I also wrote up the teleportation program and it seems to work for me -- let me know what you think:
from pyquil.api import SyncConnection
from pyquil.gates import CNOT, H, I, MEASURE, X, Z
from pyquil.quil import Program
qvm = SyncConnection()

ins = Program(H(2), CNOT(2,1), H(0), CNOT(0,1), H(0), MEASURE(0,0), MEASURE(1,1)).if_then(1, Program(X(2))).if_then(0, Program(Z(2)))
print 'PROGRAM:'
print ins

print 'OUTPUT:'
for i in range(10):
    wvf, addrs = qvm.wavefunction(ins, [0, 1])
    print addrs, wvf

PROGRAM:
H 2
CNOT 2 1
H 0
CNOT 0 1
H 0
MEASURE 0 [0]
MEASURE 1 [1]
JUMP-WHEN @THEN1 [1]
JUMP @END2
LABEL @THEN1
X 2
LABEL @END2
JUMP-WHEN @THEN3 [0]
JUMP @END4
LABEL @THEN3
Z 2
LABEL @END4

OUTPUT:
[0, 1] (0.7071067812+0j)|010> + (0.7071067812+0j)|110>
[1, 0] (0.7071067812+0j)|001> + (0.7071067812+0j)|101>
[0, 1] (0.7071067812+0j)|010> + (0.7071067812+0j)|110>
[0, 1] (0.7071067812+0j)|010> + (0.7071067812+0j)|110>
[1, 0] (0.7071067812+0j)|001> + (0.7071067812+0j)|101>
[1, 1] (0.7071067812+0j)|011> + (0.7071067812+0j)|111>
[0, 0] (0.7071067812+0j)|000> + (0.7071067812+0j)|100>
[0, 1] (0.7071067812+0j)|010> + (0.7071067812+0j)|110>
[0, 1] (0.7071067812+0j)|010> + (0.7071067812+0j)|110>
[0, 0] (0.7071067812+0j)|000> + (0.7071067812+0j)|100>

@rasa97 I think what you are noticing is that the wavefunction call actually includes the projections caused by the measurements commands that you make.  For example, if you look at the wavefunction of your program before measurement (rather than after):
ins = pq.Program()
ins.inst(I(1), H(1), I(2), CNOT(1,2))  #Creating Bell State 00
ins.inst(H(0), Z(0), CNOT(0,1), H(0))
print qvm.wavefunction(ins)[0]

You will see:
(0.3535533906+0j)|000> + (0.3535533906+0j)|001> + (-0.3535533906+0j)|010> + (0.3535533906+0j)|011> + (-0.3535533906+0j)|100> + (0.3535533906+0j)|101> + (0.3535533906+0j)|110> + (0.3535533906+0j)|111>

Which has components across all the different bit strings for the zeroth and first qubits.  Does that help?

Thank you for the answers!
I was able to resolve my issue by removing the qvm.run command. Instead, I typed in:
ins.inst(H(0), Z(0), CNOT(0,1), H(0)).measure(0,0).measure(1,1)
wvf, addr = qvm.wavefunction(ins, [0,1])
print addr, wvf

I understand that I made the mistake of measuring two different wavefunctions (one during qvm.run() and the next during qvm.wavefunction() )


refactor: add trace for logging

:tada: This PR is included in version 0.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Where to override client alert boxes?

Hi there,
I was wondering where alert boxes are called for alert boxes from server side errors and throws. Was thinking of implementing my own solution.
Best regards,
Marcus

Closed due inactivity
Also check the issue guidelines.
If you still need help, you can ask this on stackoverflow with our new tag.
https://stackoverflow.com/tags/serenity-platform


Cannot export animations from model to model

3.2.stable
windows 10
have 2 different models that have different meshes but same skeleton, wanted to update animations on older one by getting animations from new one
export animation from one newer model that has more animations and load it to older one, it will be messed with wrong rotations on some bones
That is critical and I have no idea what to do now, I'm sure that skeleton is same, because in blender I can freely CTRL+C poses on all bones and CTRL+V on older model without any issues

I can confirm I have the same issue. Currently looking for a workaround.

@Favkis @Xylord This should be addressed by #36415, please check.

Closing due to lack of response. Moreover, this is a duplicate of https://github.com/godotengine/godot/issues/15560.


Store recordsPath paths relative to options.context

How difficult would it be to output relative paths for the recordsPath file? I feel like it would be useful in scenarios where you want multiple machines to predictably compile modules in the same way every time. This could apply to a dev/prod environment or even a multi-developer environment.

What's the status of this?

Not done yet...
You can do a PR...

Hi @sokra,
We just switched from OccurenceOrderPlugin to recordsPath (since OccurrenceOrderPlugin gave different output on different machines).
However, the paths in our records file are still absolute (even after your fix above).
Hence they still differ on different machines.
We are using Webpack 1.12.2.

We have now tried switching between jsx-loader and babel-loader and both gives absolute urls like this:
jsx-loader:
"node_modules/jsx-loader/index.js!/Users/vs/Projects/myproject/frontend/react/mixins/translations/index.js": 278,

babel-loader:
"node_modules/babel-loader/index.js!/Users/carlb/projects/myproject/frontend/react/apps/ntf/entry.jsx": 0,

Now suspecting that the needed change might be in webpack anyway. I've looked through your fix from 44cfedd but I haven't yet understood what change to webpack that would be necessary to get relative paths for loaders too.

@sokra @MPV
It seems 44cfedd doesn't handle relative paths for loaders. The identifier should split on '!'.
https://github.com/webpack/webpack/blob/44cfedd24e0a96f68dcdcb1c7d25ef4bc6bcc085/lib/RecordIdsPlugin.js#L13-L15

yep, I know, I already fixed it but forgot to commit it... Comming soon.

@sokra Amazing, thanks!
I noticed the change was only added to v2.0.0-beta and we're running 1.x.
Do you think it might be possible to create a new tag/release with this fix (for example 1.12.3)?


[BUG] Missing mesh when using prefabs and multithreading

Describe the bug
Sometimes when loading meshes in ComponentMeshRenderer some meshes are not loaded at all (nullptr).
To Reproduce
Steps to reproduce the behavior:

Create a Prefab with a ComponentMeshRenderer.
Instantiate it and save the scene,
Load the scene again.
See error (None is displayed in ComponentMeshRenderer inspector.

Expected behavior
Mesh is loaded
Additional context
This bug is non-deterministic. The thing is that when loading the same object without prefabs it loads perfectly

We faced this problem before, probably missing the reasigne call somewhere.

Fixed in #268


swayimg: 3.5 -> 3.6

Changelog: https://github.com/artemsen/swayimg/releases/tag/v3.6
Diff: https://github.com/artemsen/swayimg/compare/v3.5...v3.6
This new release adds support for two new image formats: DICOM and Farbfeld.
Both of which should have built-in support.
I also added myself as maintainer.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363155

x86_64-linux

:white_check_mark: 1 package built:

swayimg


Correctly define plugin name

Whilst debugging another issue using postcss-debug I was confused by a postcss plugin called postcss-reverse-props. This PR correctly defines the plugin name as postcss-safe-important.

Ops... Thanks for the PR


Sorted dataframe resets after indexing

I found a in issue when sorting followed by indexing in pandas when reset_index() is not used. I'm not sure why but the ordering of the rows reverts back after indexing and hence results in dfList containing dataframes that are ordered differently.
reset_index() works and helped to overcome the problem. This is really subtle and rather difficult to troubleshoot. I hope this would be useful for others.
currentReadFile = pd.read_table(currentFile)
matrix = currentReadFile.sort(['Ref','Var','Before','After'])
matrix_out = matrix.ix[:,4:]
dfList.append(matrix_out)

Thanks for the report. I don't fully understand what the issue is. Can you attach:

copy-pastable data
current / expected result
result of pd.show_versions()

Closing as stale.


Test failures with PROJ 7.2.0

pyproj 2.6.1 has several test failure with PROJ 7.2.0:
=================================== FAILURES ===================================
_ test_repr[7789-8401-<Transformation Transformer: helmert>\nDescription: ITRF2014 to ETRF2014 (1)\nArea of Use:\n- name: Europe - ETRF by country\n- bounds: (-16.1, 32.88, 40.18, 84.17)] _

from_crs = 7789, to_crs = 8401
expected_repr = '<Transformation Transformer: helmert>\nDescription: ITRF2014 to ETRF2014 (1)\nArea of Use:\n- name: Europe - ETRF by country\n- bounds: (-16.1, 32.88, 40.18, 84.17)'

    @pytest.mark.parametrize(
        "from_crs, to_crs, expected_repr",
        [
            (
                7789,
                8401,
                (
                    "<Transformation Transformer: helmert>\n"
                    "Description: ITRF2014 to ETRF2014 (1)\n"
                    "Area of Use:\n"
                    "- name: Europe - {}\n"
                    "- bounds: (-16.1, 32.88, 40.18, 84.17)"
                ).format("ETRF by country" if _PROJ_gte_701 else "ETRS89"),
            ),
            (
                4326,
                3857,
                (
                    "<Conversion Transformer: pipeline>\n"
                    "Description: Popular Visualisation Pseudo-Mercator\n"
                    "Area of Use:\n"
                    "- name: World\n"
                    "- bounds: (-180.0, -90.0, 180.0, 90.0)"
                ),
            ),
            (
                4326,
                26917,
                (
                    "<Unknown Transformer: unknown>\n"
                    "Description: unavailable until proj_trans is called\n"
                    "Area of Use:\n- undefined"
                ),
            ),
        ],
    )
    def test_repr(from_crs, to_crs, expected_repr):
>       assert repr(Transformer.from_crs(from_crs, to_crs)) == expected_repr
E       AssertionError: assert '<Transformat...40.18, 84.17)' == '<Transformati...40.18, 84.17)'
E           <Transformation Transformer: helmert>
E         - Description: ITRF2014 to ETRF2014 (2)
E         ?                                    ^
E         + Description: ITRF2014 to ETRF2014 (1)
E         ?                                    ^
E           Area of Use:
E         - - name: Europe - onshore and offshore: Albania; Andorra; Austria; Belgium; Bosnia and Herzegovina; Bulgaria; Croatia; Cyprus; Czechia; Denmark; Estonia; Faroe Islands; Finland; France; Germany; Gibraltar; Greece; Hungary; Ireland; Italy; Kosovo; Latvia; Liechtenstein; Lithuania; Luxembourg; Malta; Moldova; Monaco; Montenegro; Netherlands; North Macedonia; Norway i...
E
E         ...Full output truncated (3 lines hidden), use '-vv' to show

test/test_transformer.py:492: AssertionError
_ test_repr[4326-3857-<Conversion Transformer: pipeline>\nDescription: Popular Visualisation Pseudo-Mercator\nArea of Use:\n- name: World\n- bounds: (-180.0, -90.0, 180.0, 90.0)] _

from_crs = 4326, to_crs = 3857
expected_repr = '<Conversion Transformer: pipeline>\nDescription: Popular Visualisation Pseudo-Mercator\nArea of Use:\n- name: World\n- bounds: (-180.0, -90.0, 180.0, 90.0)'

    @pytest.mark.parametrize(
        "from_crs, to_crs, expected_repr",
        [
            (
                7789,
                8401,
                (
                    "<Transformation Transformer: helmert>\n"
                    "Description: ITRF2014 to ETRF2014 (1)\n"
                    "Area of Use:\n"
                    "- name: Europe - {}\n"
                    "- bounds: (-16.1, 32.88, 40.18, 84.17)"
                ).format("ETRF by country" if _PROJ_gte_701 else "ETRS89"),
            ),
            (
                4326,
                3857,
                (
                    "<Conversion Transformer: pipeline>\n"
                    "Description: Popular Visualisation Pseudo-Mercator\n"
                    "Area of Use:\n"
                    "- name: World\n"
                    "- bounds: (-180.0, -90.0, 180.0, 90.0)"
                ),
            ),
            (
                4326,
                26917,
                (
                    "<Unknown Transformer: unknown>\n"
                    "Description: unavailable until proj_trans is called\n"
                    "Area of Use:\n- undefined"
                ),
            ),
        ],
    )
    def test_repr(from_crs, to_crs, expected_repr):
>       assert repr(Transformer.from_crs(from_crs, to_crs)) == expected_repr
E       AssertionError: assert '<Conversion ... 180.0, 90.0)' == '<Conversion T... 180.0, 90.0)'
E           <Conversion Transformer: pipeline>
E           Description: Popular Visualisation Pseudo-Mercator
E           Area of Use:
E         - - name: World.
E         ?              -
E         + - name: World
E           - bounds: (-180.0, -90.0, 180.0, 90.0)

test/test_transformer.py:492: AssertionError
_________________ test_transformer__operations__scope_remarks __________________

    def test_transformer__operations__scope_remarks():
        transformer = TransformerGroup(28356, 7856).transformers[0]
        assert transformer.scope is None
>       assert [op.scope for op in transformer.operations] == [
            "Large and medium scale topographic mapping and engineering survey.",
            "Conformal transformation of GDA94 coordinates that have been derived through "
            "GNSS CORS.",
            "Large and medium scale topographic mapping and engineering survey.",
        ]
E       AssertionError: assert ['Engineering...hic mapping.'] == ['Large and me...ring survey.']
E         At index 0 diff: 'Engineering survey, topographic mapping.' != 'Large and medium scale topographic mapping and engineering survey.'
E         Full diff:
E         - ['Engineering survey, topographic mapping.',
E         + ['Large and medium scale topographic mapping and engineering survey.',
E         -  'Transformation of GDA94 coordinates that have been derived through GNSS '
E         ?   ^                                                                  -----
E         +  'Conformal transformation of GDA94 coordinates that have been derived through '...
E
E         ...Full output truncated (7 lines hidden), use '-vv' to show

test/test_transformer.py:538: AssertionError
____________________________ test_transformer_group ____________________________

    def test_transformer_group():
        trans_group = TransformerGroup(7789, 8401)
        assert len(trans_group.transformers) == 2
        assert trans_group.transformers[0].name == "helmert"
>       assert trans_group.transformers[1].description == ("ITRF2014 to ETRF2014 (2)")
E       AssertionError: assert 'ITRF2014 to ETRF2014 (1)' == 'ITRF2014 to ETRF2014 (2)'
E         - ITRF2014 to ETRF2014 (1)
E         ?                       ^
E         + ITRF2014 to ETRF2014 (2)
E         ?                       ^

test/test_transformer.py:555: AssertionError
__________________________________ test_repr ___________________________________

    def test_repr():
        with pytest.warns(FutureWarning):
>           assert repr(CRS({"init": "EPSG:4326"})) == (
                "<Geographic 2D CRS: +init=epsg:4326 +type=crs>\n"
                "Name: WGS 84\n"
                "Axis Info [ellipsoidal]:\n"
                "- lon[east]: Longitude (degree)\n"
                "- lat[north]: Latitude (degree)\n"
                "Area of Use:\n"
                "- name: World\n"
                "- bounds: (-180.0, -90.0, 180.0, 90.0)\n"
                "Datum: World Geodetic System 1984\n"
                "- Ellipsoid: WGS 84\n"
                "- Prime Meridian: Greenwich\n"
            )
E           AssertionError: assert '<Geographic ...: Greenwich\n' == '<Geographic 2...: Greenwich\n'
E               <Geographic 2D CRS: +init=epsg:4326 +type=crs>
E               Name: WGS 84
E               Axis Info [ellipsoidal]:
E               - lon[east]: Longitude (degree)
E               - lat[north]: Latitude (degree)
E               Area of Use:
E             - - name: World....
E
E             ...Full output truncated (7 lines hidden), use '-vv' to show

test/crs/test_crs.py:195: AssertionError
_______________________________ test_repr__long ________________________________

    def test_repr__long():
        with pytest.warns(FutureWarning):
>           assert repr(CRS(CRS({"init": "EPSG:4326"}).to_wkt())) == (
                '<Geographic 2D CRS: GEOGCRS["WGS 84",'
                'DATUM["World Geodetic System 1984 ...>\n'
                "Name: WGS 84\n"
                "Axis Info [ellipsoidal]:\n"
                "- lon[east]: Longitude (degree)\n"
                "- lat[north]: Latitude (degree)\n"
                "Area of Use:\n"
                "- name: World\n"
                "- bounds: (-180.0, -90.0, 180.0, 90.0)\n"
                "Datum: World Geodetic System 1984\n"
                "- Ellipsoid: WGS 84\n"
                "- Prime Meridian: Greenwich\n"
            )
E           assert '<Geographic ...: Greenwich\n' == '<Geographic 2...: Greenwich\n'
E               <Geographic 2D CRS: GEOGCRS["WGS 84",DATUM["World Geodetic System 1984 ...>
E               Name: WGS 84
E               Axis Info [ellipsoidal]:
E               - lon[east]: Longitude (degree)
E               - lat[north]: Latitude (degree)
E               Area of Use:
E             - - name: World....
E
E             ...Full output truncated (7 lines hidden), use '-vv' to show

test/crs/test_crs.py:212: AssertionError
________________________________ test_repr_epsg ________________________________

    def test_repr_epsg():
>       assert repr(CRS(CRS("EPSG:4326").to_wkt())) == (
            "<Geographic 2D CRS: EPSG:4326>\n"
            "Name: WGS 84\n"
            "Axis Info [ellipsoidal]:\n"
            "- Lat[north]: Geodetic latitude (degree)\n"
            "- Lon[east]: Geodetic longitude (degree)\n"
            "Area of Use:\n"
            "- name: World\n"
            "- bounds: (-180.0, -90.0, 180.0, 90.0)\n"
            "Datum: World Geodetic System 1984\n"
            "- Ellipsoid: WGS 84\n"
            "- Prime Meridian: Greenwich\n"
        )
E       AssertionError: assert '<Geographic ...: Greenwich\n' == '<Geographic 2...: Greenwich\n'
E           <Geographic 2D CRS: EPSG:4326>
E           Name: WGS 84
E           Axis Info [ellipsoidal]:
E           - Lat[north]: Geodetic latitude (degree)
E           - Lon[east]: Geodetic longitude (degree)
E           Area of Use:
E         - - name: World....
E
E         ...Full output truncated (7 lines hidden), use '-vv' to show

test/crs/test_crs.py:229: AssertionError
______________________________ test_repr_compound ______________________________

    def test_repr_compound():
>       assert repr(CRS.from_epsg(3901)) == (
            "<Compound CRS: EPSG:3901>\n"
            "Name: KKJ / Finland Uniform Coordinate System + N60 height\n"
            "Axis Info [cartesian|vertical]:\n"
            "- X[north]: Northing (metre)\n"
            "- Y[east]: Easting (metre)\n"
            "- H[up]: Gravity-related height (metre)\n"
            "Area of Use:\n"
            "- name: Finland - onshore\n"
            "- bounds: (19.24, 59.75, 31.59, 70.09)\n"
            "Datum: Kartastokoordinaattijarjestelma (1966)\n"
            "- Ellipsoid: International 1924\n"
            "- Prime Meridian: Greenwich\n"
            "Sub CRS:\n"
            "- KKJ / Finland Uniform Coordinate System\n"
            "- N60 height\n"
        )
E       AssertionError: assert '<Compound CR... N60 height\n' == '<Compound CRS... N60 height\n'
E           <Compound CRS: EPSG:3901>
E           Name: KKJ / Finland Uniform Coordinate System + N60 height
E           Axis Info [cartesian|vertical]:
E           - X[north]: Northing (metre)
E           - Y[east]: Easting (metre)
E           - H[up]: Gravity-related height (metre)
E           Area of Use:...
E
E         ...Full output truncated (11 lines hidden), use '-vv' to show

test/crs/test_crs.py:269: AssertionError
_______________________________ test_area_of_use _______________________________

    def test_area_of_use():
        crs1 = CRS.from_epsg(4326)
        assert crs1.area_of_use.bounds == (-180.0, -90.0, 180.0, 90.0)
>       assert crs1.area_of_use.name == "World"
E       AssertionError: assert 'World.' == 'World'
E         - World.
E         ?      -
E         + World

test/crs/test_crs.py:452: AssertionError
__________________________ test_coordinate_operation ___________________________

    def test_coordinate_operation():
        crs = CRS.from_epsg(26915)
>       assert repr(crs.coordinate_operation) == (
            "<Coordinate Operation: Conversion>\n"
            "Name: UTM zone 15N\n"
            "Method: Transverse Mercator\n"
            "Area of Use:\n"
            "- name: World - N hemisphere - 96°W to 90°W\n"
            "- bounds: (-96.0, 0.0, -90.0, 84.0)"
        )
E       AssertionError: assert '<Coordinate ... -90.0, 84.0)' == '<Coordinate O... -90.0, 84.0)'
E           <Coordinate Operation: Conversion>
E           Name: UTM zone 15N
E           Method: Transverse Mercator
E           Area of Use:
E         - - name: Between 96°W and 90°W, northern hemisphere between equator and 84°N, onshore and offshore.
E         + - name: World - N hemisphere - 96°W to 90°W
E           - bounds: (-96.0, 0.0, -90.0, 84.0)

test/crs/test_crs.py:507: AssertionError
______________________ test_crs__scope__remarks__missing _______________________

    def test_crs__scope__remarks__missing():
        cc = CRS(4326)
>       assert cc.scope is None
E       AssertionError: assert 'Horizontal component of 3D system.' is None
E        +  where 'Horizontal component of 3D system.' = <Geographic 2D CRS: EPSG:4326>\nName: WGS 84\nAxis Info [ellipsoidal]:\n- Lat[north]: Geodetic latitude (degree)\n- Lon[ea...bounds: (-180.0, -90.0, 180.0, 90.0)\nDatum: World Geodetic System 1984\n- Ellipsoid: WGS 84\n- Prime Meridian: Greenwich\n.scope

test/crs/test_crs.py:1248: AssertionError
=============================== warnings summary ===============================
.pybuild/cpython3_3.9_pyproj/build/test/test_transformer.py::test_transformer_group__get_transform_crs
  /build/python-pyproj-2.6.1+ds/.pybuild/cpython3_3.9_pyproj/build/pyproj/transformer.py:73: UserWarning: Best transformation is not available due to missing Grid(short_name=nl_nsgi_rdtrans2018.tif, full_name=, package_name=, url=https://cdn.proj.org/nl_nsgi_rdtrans2018.tif, direct_download=True, open_license=True, available=False)
    super().__init__(

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============== 11 failed, 539 passed, 1 warnings in 47.54 seconds ==============

Environment Information

pyproj version (2.6.1)
PROJ version (7.2.0)
PROJ data directory (/usr/share/proj)
Python version (3.8.6 (default, Sep 25 2020, 09:36:53)  [GCC 10.2.0])
Operation System Information (Linux-5.9.0-1-amd64-x86_64-with-glibc2.29)

Installation method

Debian packages

Thanks for the report 👍. Here is the PR with the updates: https://github.com/pyproj4/pyproj/pull/725

There currently aren't any issues with the upcoming 3.0 release: #727

#709 has some changes as well.

When is the expected release date of pyproj 3.0.0?
If it's not long after the release of PROJ 7.2.0 we update both package in Debian at the same time.
Otherwise we'll need to include many changes from master and/or PRs, or ignore the test failures and leave packages depending on pyproj possibly broken.

When is the expected release date of pyproj 3.0.0?

Not long after 7.2 is released. So, waiting for that would likely be the simpler for you.

Thanks again for the report :+1:


Score/points algorithme

Implement how the score is handle.
Maybe something like:
100_base_points - time - (10 * nbr_of_wrong_answers)

Added a first algorithm draft, to refine as we test

Score now handled as
1500 * correct answers / seconds elapsed

modifier is now 1500 again.
Issue closed.


Hangouts

Description:
Adds support for Google Hangouts as notify platform and automation trigger.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#6044
Example entry for configuration.yaml (if applicable):
hangouts:
  email<EMAIL_ADDRESS>  password: <password>
  commands:
    - name: ping
      word: ping

notify:
  - name: erwin
    platform: hangouts
    default_conversations:
      - id: <conversation_id>
      - name: <conversation>

automation:
  - alias: 'Hangouts: Ping'
    trigger:
    - event_data: {'command': 'ping'}
      event_type: hangouts_command
      platform: event
    action:
    - data_template:
        target:
          - id: '{{ trigger.event.data.conversation_id}}'
        message:
          - text: 'pong'
      service: hangouts.send_message

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @hobbypunk90,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I'd love to test this immediately.  Can I add this as a custom component and try it out?

I added this as a custom component to try out.  I'm only testing the notify portion for alerts.  Seems each message is being sent/recieved twice.  I tested this with an automation and straight from the dev panel manually.

@edif30 can you please show me your relevant config (without password and email 😉) i tried it the last days and don't have a problem with double messages 🤔
i test it at the moment with a simple "ping" -> "pong" automation. no multiple messages sent.

Sure thing!
hangouts:
  email: !secret hangouts_email
  password: !secret hangouts_pw

notify:
  - name: ha_hangouts_main
    platform: hangouts
    default_conversations:
      - id: <id from entity>
      - name: HA Main

#
  - id: zwave_up
    alias: ZWAVE Up
    initial_state: 'on'
    trigger:
      platform: event
      event_type: zwave.network_ready
    action:
      - service: input_boolean.turn_on
        entity_id:
          - input_boolean.zwave_up
      - service: notify.ha_hangouts_main
        data:
          message:
            "ZWAVE UP!"

Like I mentioned in the previous post, I tried sending a message manually via the dev panel and that shows 2 copies.

ahhh, i think i see the problem 😁
default_conversations:
  - id: <id from entity>
  - name: HA Main

you entered the id of the conversation "HA Main" and the name, am i right?
That are 2 conversations, so you got the in every conversation, if it is the same you get it twice. 😉
you only need the the id OR the name of a conversation.
It is both possible, because direct conversations normally don't have a name. 😉

Yup that was the problem.  I happened to name my conversation initially and it didn't work.  I then added the id and it did but I was getting the multiple copies.  I ended up removing the name and it works perfect!  Thanks!

@hobbypunk90 does this support sending images/gif?  I tried but doesn't look like anything sends.

@edif30 no, images are not supported, but hangouts shows them if they have a google content link.
But sending images could be a nice extension 🤔

Nah, just mock any call to hangups. Something like this: (did not test this code)
flow = HangoutsFlowHandler()

with patch('hangups.get_auth', side_effect=Google2FAError):
    result = await flow.async_step_user({'email': 'bla', 'password': 'bla'})
    assert result['type'] == data_entry_flow.RESULT_TYPE_SHOW_FORM
    assert result['step_id'] == '2fa'

Amazing work! 🎉


ES index data suffix support config by date format

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[x] Feature or performance improvement

Requirement or improvement
I want to make es index config by date format, eg. yyyyMMdd,yyyy-MM-dd or other pattern
There are other application's data besides skywalking's data in es, and move index of last week from ssd node to hdd node by job.
The job‘s migration index rule are based on index suffixes. So I hope  that index suffix can custom config.

I think your private works, no matter what they are, are not the community concern. Anyone could submit this kind of request to many things. We can't and shouldn't make all things customizable.


feat: modernize the Benchmark report

Convert to use the Timefold webjar.
Convert to Bootstrap 5.
Charts are now generated in the browser by JavaScript, not by JFreeChart.
Address several long-standing bugs identified during the process.

@mcimbora I see you recently fixed a bug in the benchmarker. Maybe you want to give this a try before we merge it? Any feedback appreciated.

Zdarec @triceo, I checked this out briefly from user perspective. The report looks a lot better 👍 JFreeChart is a great library, but the charts have a bit of 90s vibe. Perhaps they've added new renderers meanwhile? Haven't checked.
A couple of points/glitches, feel free to pick what's relevant:

output folder size 40 MB (new) vs 1.6 MB (old). Will make difference if you have 50 results in the output folder.

the charts are responsive, but one way only. If you descale the window and resize it back to original size, the charts don't rescale back, e.g.:

new charts sometimes don't include origin (see vertical axis on chart below) and sometimes add negative range values (see horizontal axis)

vs:

maybe provide better indication that the labels are clickable. Figured it out by chance :-)

the winner line is thicker and sometimes obscures other configurations, e.g.:

section labels could be aligned left:

Díky, @mcimbora ! I'll see what I can do about the things you mentioned.

I think I addressed most of the issues.


ACI didn't have access to script during data load

Container hack (BYOS) - I ran the deploy.sh from powershell. All the resources were created except that the data (tables and values) were not loaded. Upon debugging, I found that the ACI that pulls the dataload image failed as it didn't have access to sql_data_init.sh

@kavaithai
Please see the fix I just entered if you are still running the challenge.  Would be great to hear if that fixes your problem as well.


React 18 final support

Resolves #142 and #115. The APIs for React 18 had been implemented as communicated at the time, but the final release has some other changes made to it that require updating. Namely, hydrateRoot behavior and the removal of createBlockingRoot. This PR is a breaking change unfortunately because I couldn't find a way to conditionally apply types based on package version; as well as defaulting to createRoot. This PR also includes updated tests to use React's act utility and some other minor corrections to package metadata. I've tested this with two React applications generated with create-single-spa, one with TypeScript and one without. Below are the changes needed once the new version is installed.
import React from "react";
-import ReactDOM from "react-dom";
+import ReactDOMClient from "react-dom/client";
import singleSpaReact from "single-spa-react";
import Root from "./root.component";

const lifecycles = singleSpaReact({
  React,
- ReactDOM,
+ ReactDOMClient,
  rootComponent: Root,
- renderType: "render" // this should only be necessary if renderType had been explicitly defined
+ renderType: "createRoot"
});

Quick update. I still have to write the updated documentation for single-spa-react. This I'll be out of town for this week so I may try to publish an alpha, but no guarantees.

Any updates on when this PR will be merged? :) Ty

Any updates on when this update will be released?

Hate to pile on here but also curious when this might get released??

Any updates on when this PR will be merged? :) Ty
Any updates on when this update will be released?
Please release these changes ASAP. 🥹

FYI comments like this generally make me not want to work on something. I know they're not meant with bad intentions, but after five years of my expert labor being leeched for free by thousands of companies, it is hard for me to not to be spiteful towards the people trying to get me to do things.

Thanks for the feedback Joel! I'm reworking this to avoid the breaking change.


[Question] Internal version number

Hello,
Does the check also work for internal version numbers such as Android versionCode and iOS build number ?
If I release a 2.0.0 version with versionCode 100, can I know if there is a update of version 2.0.0 with versionCode 101 ?

Unfortunately not - Google and Apple don't expose the version code / build number publicly as far as I'm aware.


[11.x] Add geo-coordinates points validation

As in title, simple validation for geo points: latitude and longitude
It is equal to: ['numeric', 'between:-90,90'] and so on.
Geo points are universal and I believe that many apps are using them already.
There could be one more validation rule: geo_point:latitude,longitude where field is array and arguments are key names for coordinates. I can add it too.

Geo point validation added, supports associative array, indexed array and geo point as string with separator.

In my opinion, there is nothing wrong with using ['numeric', 'between:-90,90']. Seems explicit enough in definition. If you want something about more granular, you can add it in your own application or packages, but the framework shouldn't maintain it.

Writing the same thing dozens of times is a bit tedious and prone to error.
Equally, instead of the digits validation rule, you can use the regex /[^0-9]/ but still, for some reason, someone added such a validation rule.
public function validateDigits($attribute, $value, $parameters)
{
    $this->requireParameterCount(1, $parameters, 'digits');

    return ! preg_match('/[^0-9]/', $value)
                && strlen((string) $value) == $parameters[0];
}

Coordinates are something universal, immutable and fit into the needs of validation, I see nothing negative in not supporting it. I doesn't add it for its own sake. Coordinates occur in implementations of databases or search engines. It seems to me, however, that it is better to have it, even if it is a proxy, than not to have it just because it can be done differently. Personally, I think that the framework should make our lives easier, and this validation rule does just that.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Ingraph Data features

Chart.js don't had ingraph Data features.
My charts generator livegap charts is build on chartnew.js (a modified version of chart.js version 1).
From my xperience The most  feature users always use is ingraph data . (More than 90% of charts).
Attached sample charts  used this feature from livegap charts

I'm closing this since it's hard to know what this issue is asking for. I'm happy to look at issues requesting specific features, but things like the titles are already supported in v2 and we have samples showing how to do data labelling.
In the future, GitHub issues should be used for specific feature requests rather than large meta features or advertisements for other tools.

Advertisments !!!!!. Sure i don,t need traffic from here. As you can see there are no link to my site.
I think i will stop chart.js generator.
Thanks alot

@omarsedki we have no issue with you working on a generator for Chart.js. We're happy to review a pull request that adds a link to your project from the documentation.
The reason that a Github issue is not good for these is that we can't close the issue as there is nothing on our end to resolve. These kind of issues will stay open forever and that makes it harder to track things.

Linking this ticket to the associated plugin:  chartjs-plugin-datalabels

Add datalabels to the generator

I'm closing this since it's hard to know what this issue is asking for. I'm happy to look at issues requesting specific features, but things like the titles are already supported in v2 and we have samples showing how to do data labelling.
In the future, GitHub issues should be used for specific feature requests rather than large meta features or advertisements for other tools.

@etimberg  @simonbrunel
after  the plugin   chartjs-plugin-datalabels
are you still think it was post for advertisements for other tools?


Replace 6907 output bearing w/ 6007

Merge after #7.
New bearing is slightly larger, but substantial cost savings (~$11/module). Lengthens module by 4mm.
Also chamfered all bearing ODs to make installation easier.
Before:

After:

Whats total length of assembly now?
164.5mm cap to cap. Screw heads & output shaft & back nut stick out slightly beyond that.

Any significant weight impact from new bearing?
McMaster Carr doesn't list weights :(


Scheduled maintenance: June 3, 2021

Maintenance for: AXG-DE1, AXG-DE2, AXG-FR2.
Expect downtime or degraded performance.

Effective start: 07:00.
Effective end: 07:31.
No downtime.


My workspace App in not responding in case of Mobile Slack App but working fine with web/Desktop Slack.

When I type anything in my workspace app from mobile Slack the event that I get the team_id is missing from the event payload but when I type from web/desktop Slack I receive the team_id in the event payload. It used to work on mobile as well 2-3 months back but I don't know what happened suddenly it stopped working.
Can anyone please help as it's a blocker for me?
Reproducible in:
The Slack SDK version:
"slack/events-api": "^2.3.4",
"slack/interactive-messages": "^1.7.1",
"slack/oauth": "^1.4.0",
"slack/logger": "^2.0.0",
"slack/types": "^1.10.0",
"slack/web-api": "^5.15.0",

Node version: 14.21.3
Steps to reproduce:

Create any app in the enterprise grid.
type any message and check the event
The team_id will be missing from it.

Expected result:
We should receive the team_id on the event triggered from the mobile
{   "client_msg_id": "6c564b51-3312-4b83-93cc-7b14e7896bad",   "type": "message",   "text": "hi",   "user": "<user_id>",   "ts": "1707921031.568219",   "blocks": [     {       "type": "rich_text",       "block_id": "a8bcU",       "elements": [         {           "type": "rich_text_section",           "elements": [             {               "type": "text",               "text": "hi"             }           ]         }       ]     }   ],   "team": "<team_id>",   "user_team": "<user_id>",   "source_team": "<team_id>",   "user_profile": {     "avatar_hash": "ba68d4f1c35f",     "image_72": "https://avatars.slack-edge.com/2022-12-06/4469061237205_ba68d4f1c35f2da9553f_72.jpg",     "first_name": "<firstName>",     "real_name": <real_name>",     "display_name": "<name>",     "team": "<team_id>",     "name": "<name>",     "is_restricted": false,     "is_ultra_restricted": false   },   "channel": "<channelId>",   "event_ts": "<event_id>",   "channel_type": "im" }
Actual result:
the event from mobile slack
{   "client_msg_id": "0637d92d-1484-4a3e-a0c5-3967ad0a27b5",   "type": "message",   "text": "Hii",   "user": "<user_id>",   "blocks": [     {       "type": "rich_text",       "block_id": "NsxuO",       "elements": [         {           "type": "rich_text_section",           "elements": [             {               "type": "text",               "text": "Hii"             }           ]         }       ]     }   ],   "channel": "<channelId>",   "event_ts": "<event_id>",   "channel_type": "im" }
Questions:

Why does it only fail in an enterprise grid but not in a non-enterprise grid?
Do I need to upgrade the SDK, if yes will existing things break?

Hi @gs-ppatil - We've gotten reports of a similar vein and I've escalated previous issues internally, and at the moment, the issue seems related to mobile client.
I hate to bounce you around, but since root cause of this behavior isn't related to bolt-js, I would encourage you to report this behavior through the Slack help form.
I am happy to keep this open for now until you see a resolution your end!

Hi @srajiang
I tried to access the form that you've shared but seems like I don't have access to it
getting error
is there any other way to raise the issue ?

Hello @gs-ppatil are you still seeing the same issue with the mobile client? A BE fix has been deployed.

Hi @srajiang, yes we're still facing the issue.
Do we need to change the Slack SDK version (the existing versions are mentioned in this ticket)?
Do you need to remove the app and then add it again?

Whoops @gs-ppatil - I apologize I realized I shared the wrong link, here's the link to the help form.
I'm going to investigate a bit further. I thought perhaps it was related to another separate mobile client issue.

@gs-ppatil - Alright just so I have the details correct:

You're subscribed to message events.
From the mobile client on an enterprise grid, you don't receive the team_id.
From the mobile client on a non-enterprise grid, you DO receive the team_id
You always receive the team ID when not on a mobile client?

Questions for you:

What mobile client are you consistently able to reproduce this with? Android? iOS
Are your mobile clients on the latest supported version of Slack?

Your questions

Do I need to upgrade the SDK, if yes will existing things break?

At this point in time, I don't see a reason why you'd need to upgrade the bolt-js SDK, but this does seems like an issue server-side, possibly with the mobile client.
I do recommend that you fill out that help form in addition to responding this thread with the details I've asked for above instead of responding to this thread. The customer experience team there is REALLY good at reproducing issues, and escalating to the right teams. They'll also be able to connect this issue you're having with any other reports. I'll keep this issue open for others in the community who might also be experiencing this. as well.

Hi @srajiang

We're facing the issue both on Android and IOS
Yes I tried after updating Slack still facing the same issue.

Thanks, @srajiang for the update. I'll reach out via the above mentioned form

Having the same issue

facing the same issue

@filmaj @srajiang is there a recommended workaround for this issue? Is there another way to fetch the team_id from event metadata?

If you're being affected by this issue, please email<EMAIL_ADDRESS>and let them know you are upvoting the bug to be addressed. Sorry, on the SDK side there is not much we can do.

For others running into this issue

The greater body payload does still include the Team ID so you should be able to grab from that level. You may need to reach out to the developers of that to see if it can be configured to output more of the body than just the event object.

-From Slack Support

This also seems to prevent the user_profile from being included in messages from mobile, which means an extra users.info call is required to get things like "the display name of the message author".


fix: update three to four

Constants in the wolf-goat-cabbage puzzle

ahh build scripts are broken :)))
maybe we should just remove them


Unify CursorIcon management.

What problem does this solve or what need does it fill?
Having multiple sources of CursorIcon management (like bevy_egui) in a project can lead to confusing bugs.
What solution would you like?
Have CursorIcon be reverted by bevy on First based on a resource like DefaultIcon. "Backends" should only write to it if needed to minimize conflicts.
What alternative(s) have you considered?
Keep things as is?

I think this will be covered with a proper solution to #14351 / #9557.


Configure code format/prettier & remove unused imports/variables

I just changed a spelling and saved the file which triggered my code  prettier

Please use the repositories given prettier configuration; Would highly discourage using your global prettier settings.


Fix test of DatasetRow that can fail during certain times of day

See the commit message for notes. It's a funny issue!

Another way to solve this would be to mock the time zone:
setLuxon({ defaultZoneName: 'UTC' });

Then Luxon will act as if the machine is in UTC, causing the UTC date and the date in the local time zone to match.
You could also check the iso prop of the DateTime component rather than the text of the <time> element. That's usually what I end up doing.


Fork_and_work shortcircuit.

When worker.stop in a fork and work state, the forked process continue to loop waiting for a job to do.
If nothing come it will endlessly wait and query the queue.
Am I missing something there?

From what I remember there are issues with the latest QC version and forking. See #207 and #216 for more details.


Ledger Support on Firefox browser

Is your feature request related to a problem? Please describe.
During the testing, we discovered that ledger does not show up on Firefox browser.
Describe the solution you'd like
Support ledger on Firefox browser
Describe alternatives you've considered
For every wallet type integrated, if it has special condition not to support certain browser, notify on terminal as warning so developers are aware which browser isn't supported.
Acceptance criteria
Support Ledger on Firefox browser
Additional context
Chrome:

Firefox:

I will close this issue now, but feel free to reopen it if there are some other suggestions that you might have. Thanks @hcho112


Refactor forc-client to be aware of workspace manifest files

After #2893 is addressed we are going to have a workspace manifest file that holds various information for that workspace. As a first step going towards full workspace support we may want to do some refactoring around forc-client so that it can be aware of the workspace manifest file. Until we add the deployment dependencies to the workspace manifest file, we can deploy the members of the workspace as they are declared.

Until we add the deployment dependencies to the workspace manifest file

Just a note to add that we'll want to do this in the package manifest (not the workspace manifest) as mentioned here https://github.com/FuelLabs/sway/issues/2931#issuecomment-1267775595.
@kayagokalp we might be better off tackling #2931 first and leave any necessary refactoring of forc-client until after this. If we end up outputting the contract ID during forc build instead as mentioned here, then we shouldn't need to do much in forc-client at all other than:

Refactor deploy and run to use the contract ID from the out directory (or directly from the forc_pkg build function call used within the deploy function).
Add support for deploying all contract packages within a workspace at once.

Ahh just realized this exists after I created #3156. Since we longer have

Refactor deploy and run to use the contract ID from the out directory (or directly from the forc_pkg build function call used within the deploy function).

section of your summary as we handled that with introducing contract-dependencies at https://github.com/FuelLabs/sway/pull/3016. And second part of this issue is tracked by newer smaller issue #3156. I am closing this one but if you feel like tracking with this makes more sense I can reverse


ES-Country_fiches-2024

Dear @fabiovinci
As you have not yet closed the Country Fiche of Spain, he has taken the opportunity to include some more data.
This file contains the report of Spain on the implementation of the INSPIRE Directive regulations  in 2023. The last updated file is the one that contains all the information.
For any questions write to Paloma Abad (paloma.abad@cnig.es). Thank you.

Dear @fabiovinci,
As you have not yet closed the Country Fiche of Spain, he has taken the opportunity to include some more data.
Thank you,
Paloma

Dear @abadppa0,
I fixed some typos and the PR is ready to merge.
Please confirm if the file ES/Country_fiches/prueba is necessary, if not I will remove it and merge the PR.
Thanks

Hello @fabiovinci

I have tried to delete "prueba" in my github but I don't know how to do it. Please delete "prueba".
I´ve seen an "error" and I´ve taken the opportunity to change it.
I just made you the final folk.

Grazie mille per tutto
Paloma

Hi @abadppa0,
thank you for the submission.
I deleted the empty file and I will merge the PR.


Composer cannot find jetbrains/phpstorm-stubs repository

When running composer require felixfbecker/language-server I get the following error message:
Using version ^4.1 for felixfbecker/language-server
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - felixfbecker/language-server v4.1.1 requires jetbrains/phpstorm-stubs dev-master -> no matching package found.
    - felixfbecker/language-server v4.1.0 requires jetbrains/phpstorm-stubs dev-master -> no matching package found.
    - Installation request for felixfbecker/language-server ^4.1 -> satisfiable by felixfbecker/language-server[v4.1.0, v4.1.1].

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Installation failed, reverting ./composer.json to its original content.

It looks like Composer cannot find the jetbrains/phpstorm-stubs repository even though it is corrently configured in the composer.json. Running composer clear-cache did not help. Any idea what's going on?

Also, the minimum-stability is set to dev so that shouldn't be a problem.

Repositories are only valid for the root package for security reasons, see https://getcomposer.org/doc/faqs/why-can't-composer-load-repositories-recursively.md
If you "trust" the repository, you need to duplicate the repository definition in your own composer.json. I have a pending PR on JetBrain's repository to add a composer.json and publish on Packagist.
This should maybe be highlighted in the readme, feel free to do a PR.

Oh, I got it, thank you!

Sorry, can you show me steps what I have to do in this case?


Request: nautical miles unit option for MeasureControl

Hi,
It would be very nice to have a nautical miles unit option for MeasureControl, which would be useful for maritime and aviation applications.
It seems like this isn't supported because leaflet-measure doesn't yet support NM, but that package hasn't been updated in years. Is there any possible workaround to convert miles to NM?
Thanks,
Joseph

For version 1.0.3, you can now specify custom units, which should resolve this issue.


Better chat inbox row connectors

This PR splits each row type into its own connected component so we can control how much work is happening. Also switches to use rereselect for memoization
When scrolling around vs the branch this is based on i get around 57fps vs around 34

@keybase/react-hackers this is ready to look at

@keybase/react-hackers bump

@akalin addressed some of your stuff and discussed some others. PTAL

@keybase/react-hackers bump

:wave: haven't had a chance to review, but in testing it changes my small teams into normal conversations:
before

after

@buoyad doh! I'll fix in the morning, tnx!

@buoyad found the issue. The small rows from the inbox's perspective don't have any metdata around if they're a kbfs or team based chat so the ownProp is always null. I now pull that out of the selector for the small rows.


Automated Package Upgrade

:tada: This PR is included in version 13.0.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


About reproducibility

Hi, the tAPE and ePRE position embedding methods proposed in ConvTran are great and novel, and i have doing several experiments for them, while i met a problem during reproduction. The detailed information are as follows:
Hardware env:  i7-12700K, RTX 3060 12G
Software env: python3.8 pytorch2.0.1+cuda11.7 and other libs satisfy the requirements.txt
I use the code with no modification to procude the results on UEA datasets, and the comparison with which beyond to the paper can be seen as below:

(1) According to the fig above, there are gaps on some datasets which are marked red("OOM" represents out of cuda memory, which doesn't need to be considered here);
(2) i discovered that embedding size was set to 64 in paper rather than 16 in the code:

(3) reference to the issue proposed earlier(https://github.com/Navidfoumani/ConvTran/issues/5),  if the default set in code was used, about 190G cuda memory will be need, which have gone beyond the capacity of a single A5000(24GB) using in paper:

So, i wander if the reproduction problem is due to there is a separate experimental hyperparameter setting for each dataset within UEA datasets rather than sharing the default setting across all datasets in practice? or reasons else? Look forward to your reply!

Hi,
Thanks for informing me.
For reproducibility, there are a few points to note:
1- It's essential to run each dataset separately. I've recently noticed that running them consecutively (all in once) in Pytorch affects the results due to initialization issues. I achieved better results by running each dataset individually.
2- The datasets mentioned are generally small, leading to considerable result variance. To address this, you can average the results from 5 experiments.
Regarding memory concerns, these arose with only a few datasets. To manage them, I employed memory-saving methods like using memmap or reducing the batch size.


Removed check if file exists. Fixes #778

Short Description: Removed checks for location-{username}.json and last-location-{username}.json. Outfile can create file as well, so there is no need to create it.
Fixes:

fixes #778

It looks nice to me. Can anyone of the team approve this, please?

already fixed in #800


Collection synchronization utility

This an improved version of something I used in various projects. This one is now widely configurable, much more versatile.
** The changeset is a bit weird as some of the code was already committed in the develop branch. This PR mostly adds test for the utility.

Cool one @thatfrankdev!


cut new release

Hi. Would you mind cutting a v0.0.4 release for the typing addition. Thanks!

Sure! #22

Thanks! I'll test it soon.


Handle accessibility on sign in screen

🐏 Now: Motivation
⚜ Where's the issue?
The sign in screen.
⚜ What's the issue?
The sign in screen isn't as accessible as I thought it was.
⚜ Any ideas on how to solve it?

Decide if I should handle this in an issue or in a user story (e.g. 'Sign in with name using screen reader and/or keyboard')
Is the text content's language set? (on the html tag)
Can I navigate it with a keyboard? -- the answer is not really -- the input box isn't focusable for some reason
Use Vue Axe on the page to see if anything else is picked up
Progress bar isn't accessible for screen readers. See this article from Marcus
Error messages may not be accessible. Just use Vue Announcer? IDK. Check out Accessible Vue
Follow any lessons I learned from this #28 task

🦄 Later: Solving it
💠 The problem
Because this is a bug and not a new feature, I'll handle sign-in accessibility inside this issue.
💠 The method

[x] Set the text content's language (instructions)
[x] Ensure that I can navigate the screen with a keyboard (instructions)
[x] Make the progress bar accessible for screen readers (instructions)
[x] Use a more descriptive loading symbol for users who prefer reduced motion (e.g. an hourglass)
[x] Investigate making my error message accessibility more standardised with Vue Announcer (instructions)
[x] Let Vue Axe tell me if there's anything else to do

💠 Notes

Changed the focus ring colours of all focus rings to a colour with higher contrast against the dark background.

Made the sign in submit button contrast better against its text. Turns out, I didn't understand colour contrast as well as I thought I did. The 3:1 minimum contrast for interactive elements seems to refer to e.g. a button's contrast against the background, rather than the button text's contrast against the button itself.

Done!


create model classes for catalog

or copy over from fuse tooling

or reuse the ones from camel-idea-plugin
or extract one of them in a separate repo?

currently duplicating the one from camel idea plugin. Created https://github.com/lhein/camel-language-server/issues/32 to rationalized that


Add - Triplet note

My daughter complained about the triplets missing in MakeCode - So here they are and hopefully okay ;-)

Forgive my musical ignorance, but is a triplet a 1/3 beat?
While we're doing this, can we also list them in order in the dropdown?

Forgive my musical ignorance, but is a triplet a 1/3 beat?
While we're doing this, can we also list them in order in the dropdown?

@abchatra next release?

@abchatra next release?


[bug-fix] allow non-default child requirements to override inherited …

…requirements.
This change allows non-default child requirements override parent requirements
for requirements with the same name. Previously, both the parent and
child requirement would be produced, which causes issues during
downstream conda or pip package resolution.
A few other minor changes:

change the API docs to for Requirements.join to say a warning log
message is produced, where previously it said incorrectly an exception
would be thrown, when there were two requirements with the sane name
due to the bug fix above, the order of some of the dependencies may
change, for example in the output of Assemble or Tabulate.
added a test for Spec.compile to verify that default requirements are
applied to a parent environment before a child tries to inherit from it,
and that a child requirement can override the parent requirement for a
requirement with the same name.

Codecov Report

Merging #18 (3f3e452) into master (1116efc) will decrease coverage by 0.0%.
The diff coverage is 90.9%.

@@           Coverage Diff            @@
##           master     #18     +/-   ##
========================================
- Coverage    88.6%   88.5%   -0.1%
========================================
  Files          19      19
  Lines         493     498      +5
  Branches        1       1
========================================
+ Hits          437     441      +4
- Misses         56      57      +1


update for rust nightly

What's the project policy for tracking nightly? These changes seem to make it work with my nightly:
% rustc --version
rustc 1.15.0-nightly (3bf2be9ce 2016-11-22)

Thanks!
For docopt_macros, the policy is to track the latest nightly. There's really no other feasible policy I think.

docopt_macros 0.6.87 is now on crates.io. Thanks again!


Unable to take new photos when app has been put in background (iOS)

When first running the app with the plugin it works to take pictures that is saved to gallery - and I am notified each time through photoCapturedEvent. However when the app has been put in background and revisited - no photos can be taked.
I get the following log though:

CONSOLE LOG file:///node_modules/@nstudio/nativescript-camera-plus/camera-> plus.common.js:17:0 NativeScript-CameraPlus --- CameraPlus takePic options:,

each time I attempt taking photo. But photoCapturedEvent is not fired and no photo is saved to gallery.

A workaround I found was to via application lifecycle create a new instance of CameraPlus for each new application resume event

A workaround I found was to via application lifecycle create a new instance of CameraPlus for each new application resume event

Can I have an example? After all, the instance is created in onCameraLoaded


The SSIM of the SIDD does not match

Dear author:
As I show here :

The PSNR matches with the relults in your paper, but the SSIM does not. What is wrong?
Thank you!

Hello, I get the same results in paper. Here is my setting:

Download SIDD validation data, run
python download_data.py --noise real --data test --dataset SIDD
Download the Denoise folder pre-trained models.
2.1 Replace all files in denoise to the location of KBNet-main\Denoising.
And make sure copy the basicsr folder under root folder to Denoising folder.

Where to download sidd.pth,I can't find it

Where to download sidd.pth,I can't find it

Where to download sidd.pth,I can't find it

thanks
---Original---
From: @.>
Date: Sun, Mar 10, 2024 12:33 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [zhangyi-3/KBNet] The SSIM of the SIDD does not match  (Issue #9)
Where to download sidd.pth,I can't find it
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

OOPS。。。。。I still can't find this ,can you share me zhe link or url?

OOPS。。。。。I still can't find this ,can you share me zhe link or url?

https://mycuhk-my.sharepoint.com/personal/1155135732_link_cuhk_edu_hk/_layouts/15/onedrive.aspx?ga=1&id=%2Fpersonal%2F1155135732_link_cuhk_edu_hk%2FDocuments%2Fshare%2FKBNet%2FDenoising%2Fpretrained_models

eemmmmm，maybe something is wrong

 eemmmmm，maybe something is wrong

The author gave the link in https://github.com/zhangyi-3/KBNet/blob/main/Denoising/README.md#Real-Image-Denoising
you can find all models there


RLM-218 Removes /etc/rpc-release

In order to clean up after leapfrog since this repo no longer maintains rpc-release in RPC-O, we're removing the /etc/rpc-release file so that the outdated file doesn't cause confusion.
Removing it from this repo in order to prevent it from being regenerated on an RPC-O install.
See: https://github.com/rcbops/rpc-openstack/pull/2643

This has been added to https://github.com/rsoprivatecloud/openstack-ops/pull/48 as I restructure the module. Thanks


[duktape] Update to 2.7.0 and don't require python2 to build.

Instead use a release tarball which includes all codegened stuff.

@lemourin
Please try remove these lines in scripts/ci.baseline.txt
duktape:arm-neon-android=fail
duktape:arm64-android=fail
duktape:x64-android=fail
duktape:x64-osx=skip
duktape:arm64-osx=skip
duktape:x64-linux=fail

Tested usage successfully by duktape:x64-windows:
find_package(duktape CONFIG REQUIRED)

include_directories(${CMAKE_CURRENT_SOURCE_DIR} ${DUKTAPE_INCLUDE_DIRS})

target_link_libraries(main ${DUKTAPE_LIBRARY})


Mainly the later

I'd like these for first release

[ ] I wish the Node/Location info at the top looked like it does in the Scene Inspector (without the diff part for now I guess)
[ ] I find it awkward to have it on the same pane as the Viewer. I can't look at the mesh and inspect its prim vars at the same time.
[ ] Already mentioned on the ticket, but I really want to see Interpretation and Type with each prim var.
[ ] The columns on a given tab should be alphabetically sorted
[ ] Can we add some contrast between prim var columns? The Scene Inspector and Scene Hierarchy use alternating light gray / dark gray rows. Maybe we can use those same style hints? This might help to identify the boundary between prim vars vs x/y/x components.
Testing on a production ParticleGeo, I got an error that prevents Vertex prim vars from drawing at all. Its from an unsupported prim var type (orient QuatfVectorData).

[ ]  We should support quats for this release. It'll come up in production immediately.
[ ]  We should also gracefully handle non-supported types somehow.

Maybe display the other prim vars and list the heading for the broken one but with an error widget instead of its column?
It'd also be great for the actual traceback to list the bad prim var name. Currently its just assert( accessor is not None )

Would be nice, but maybe can wait on these, unless they're trivial:

[ ]  I'd love a filter to reduce the number of columns displayed
[ ]  It'd be nice to add a menu item to the gear menu in the Scene Inspector for the prim var. Gear->Inspect could reveal (or acquire) the Primitive Inspector and also reveal the proper interpolation tab.
[ ]  Might be nice to have a summary (num elements, num unique elements) but that should be for the whole prim var not the individual x/y/z components.
[ ]  Its a bit unexpected that nothing in this pane is drag/droppable. Most panes have something... I'm not sure what it should be though... maybe the selected cell values?

The columns on a given tab should be alphabetically sorted

Circling back on this, alphabetic probably isn't what we want. P should be the first one in Vertex regardless. We probably want to prioritize the ordering for P, Pref, N, & uv, since they all have special meaning. I first suggested alphabetic because of a production point cloud I was inspecting. It displayed Constant prim vars in this order: varmap (string), boxMin (v3f), sceneFile (string), boxMax (v3f). I found it odd that boxMin and boxMax weren't listed next to each other...
Thoughts?

@andrewkaufman would you take another look?

I haven't been able to resist the temptation to review more than just the VectorDataWidget changes, since I think we're getting close and there are a few obvious problems that will need fixing anyway.

Thanks for taking the time!

As for the VectorDataWidget, I've made a few comments inline, but to me these changes look like they will break things pretty badly (just try making a PathFilter). I think some of the stuff you're doing highlights problems with the original API, but we need to find a way of doing what we need and preserving backwards compatibility. Have a read of my comments and we'll figure something out...

I suppose I was considering if it was worth making the VectorDataWidget work for all cases or how the potentially different behaviour should be factored.


when installed,it shows NO INTERNET CONNECTION  Whoops! Your server has to be connect to the Internet in order to get your website working.

when installed,it shows NO INTERNET CONNECTION  Whoops! Your server has to be connect to the Internet in order to get your website working.
But the network connection is ok.

Please check your connection again. If it shows that it means you or your sever doesn't have Internet. Please check out by visiting http://google.com
Then, please restart the installation from scratch


Intermittently default EVAM pipeline not auto starting for ONVIF camera

🐞 Bug Report
Affected Services [REQUIRED]

 The issue is located in: Sample camera management app
Is this a regression?

 No, its newly added feature
Description and Minimal Reproduction [REQUIRED]
Intermittently default EVAM pipeline not auto starting for ONVIF camera
Repro steps:
Connect 2 onvif cameras and 1 USB camera (in my testing I used Hikvision, Bosch and C270 USB camera).
Deploy the sample app and ensure default evam pipeline starts on all connected cameras
Stop all running default pipelines by pressing stop (red button) on sample UI
Start some pipelines (randomly choose any pipeline) on all 3 cameras
Connect 2 more cameras ( one ONVIF and one USB). In this testing I used tapo and Logitech USB camera
Check running evam pipelines  on sample UI
Expected behavior:
Evam pipelines keep running for 3 existing cameras and start default evam pipeline on newly added 2 cameras
Actual behavior:
Intermittently Default evam pipeline not starting on newly connected ONVIF camera. In this test, after connecting 2 new cameras it shows only 4 running pipelines (3 existing pipelines and 1 new one for USB, but not starting default pipeline for newly added tapo camera).
🔥 Exception or Error

attached debug logs for sample app, evam, onvif and screenshot

🌍  Your Environment
Deployment Environment:
EdgeX Version [REQUIRED]:
Levski
Anything else relevant?

usb_logs.txt
Onvif_logs.txt

sample_app_and_evam_logs.zip


Not working anymore, request failed message

There's already a correction in analysis at the store, now we just have to wait for v 3.0.


Webpack: setup DLL for core vendor libs, use CommonChunk for others

@davezuko I will try to get around to setting up webpack DLL over the next few days :)
I will take care of #726 (RHL v3), which should remove nearly all the rendering boilerplate from main.js—There are a few issues with react-router I'm currently tracking (see issue)
I also have some general cleanup on fractal branch (ie. the devools extension you already fixed), I will put everything into a PR over the weekend
Finally, I didn't forget about #717.. I whipped up a little alias/noParse demo for you will push up soon

Awesome, the DLL plugin sounds super sane so it would be a great addition to the project.
Thanks for the other comments and all your work.

@justingreenberg - curious to see if there are any findings regarding using DLL for those core vendor libs. Would love to update the webpack docs to make it easier to set up too :)

@tsaiDavid I've been busy during the days so working on this late night, hopefully i'll get this in sometime this week :) in the meantime, check out #753 (i encourage you to merge in and give it a whirl)... TLDR, a balanced combination of parallelization with DLL referencing is what i'm aiming for

Closing in favor of a PR.


Plural forms of imports_* options

There are several options concerning imports:

imports_indent
imports_layout
imports_granularity

I'm not a native English speaker, but to the best of my understanding, the correct form for these would

import_indent
import_layout
import_granularity

To me, "imports granularity" sounds like "shoes-maker", when it should instead be "shoe-maker" (or actually "shoemaker").
Has anybody else thought the same thing when reading these option names?

@mgeisler thanks for sharing your thoughts on this. All of these options were added to the project before I joined the rustfmt team so I can't speak to the rational for having imports vs import in each of the names. That being said, it's unlikely that we'll rename these options any time soon if ever. Again, I appreciate you taking the time to open an issue, but I'm going to close this since there's nothing to take action on right now.

Fwiw I agree, both with the initial observation/question as well as treating this as a no-op for the time being. I'd rather do a holistic review of the option names at the same time, especially when targeting consistency, so that we don't end up doing them in batches with push & pull along the way

Hi @ytmimi and @calebcartwright, thanks for looking at the issue!

I'm going to close this since there's nothing to take action on right now.

I often see unactionable issues as a TODO for some future self: they represent something I (or someone else) should be aware of when doing a feature. Of course, now that two people from the project has through about the naming here, I guess it's  registered and will be remembered later if someone starts an option name cleanup 🙂

I'd rather do a holistic review of the option names at the same time, especially when targeting consistency, so that we don't end up doing them in batches with push & pull along the way

Makes sense to me! It would be great to make all the unstable option names consistent.


⚠ ClamAV has degraded performance

In 12ae9a4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 459 ms

Resolved: ClamAV performance has improved in 8fb4be0 after 6 minutes.


Understanding Spooky Ghosts

I was wondering if it would be possible for the styled-components team to answer a few product focused questions I have about the __DO_NOT_USE_OR_YOU_WILL_BE_HAUNTED_BY_SPOOKY_GHOSTS export?
Prior to asking these questions I have read the following existing issues and their associated comments:

https://github.com/styled-components/styled-components/issues/1487
https://github.com/styled-components/styled-components/issues/1660

At defty we are building a WYSIWYG static site generator in order to bring cheap, easy to build websites to small businesses and individuals who currently wouldn't know how to build a website or who wouldn't otherwise have the time or money to do so.
Our static sites are generated by rendering react elements to html using the ReactDOMServer.renderToStaticMarkup(); function. This doesn't in any way handle CSS. We would like to use styled-components because we love the API and it has good mindshare amongst potential future employees.
At the moment to extract the CSS required for a site we use the following code snippet:
import styled, {
  __DO_NOT_USE_OR_YOU_WILL_BE_HAUNTED_BY_SPOOKY_GHOSTS as styledComponentsInternals,
} from 'styled-components';

const { StyleSheet } = styledComponentsInternals;
StyleSheet.reset(false);
const bodyHTML = ReactDOMServer.renderToStaticMarkup(/* A styled.body with children */);
const styles = StyleSheet.instance.toHTML();

The name __DO_NOT_USE_OR_YOU_WILL_BE_HAUNTED_BY_SPOOKY_GHOSTS makes it clear that this is not a use-case you fully support at the moment and that we should expect breaking changes at any time. However, we have looked into alternatives such as linaria (which is much more static site focused, but doesn't allow quite enough dynamism for us), and none of them stack up to the ease of the code snippet above.
Some of the answers to these questions may be obvious, but I would rather be explicit:

Do you have existing plans to change the StyleSheet or __DO_NOT_USE_OR_YOU_WILL_BE_HAUNTED_BY_SPOOKY_GHOSTS export in ways which would break this set up?
If not, is this a use case you will consider in future when making decisions about backwards compatibility?
What kind of warning would the community receive before a breaking change was made to StyleSheet or __DO_NOT_USE_OR_YOU_WILL_BE_HAUNTED_BY_SPOOKY_GHOSTS? Would it be none/very little because this is explicitly considered internal and marked as such by the fun export name?
What suggestions would you make to user such as ourselves and the OP of https://github.com/styled-components/styled-components/issues/1487 in regards to continued use of styled-components for this use case or an alternative (if you know of one)?
Would you accept pull requests which explicitly improve the situation for this use case, or is this a use case which styled-components as a project has no interest in? (which is fine 👍)

Thanks to all contributors for their work on styled-components. Even if this use case is not supported going forward the library allowed us to get a MVP together very quickly, and we are very grateful! We hope we can work together with the styled-components team going forward to improve styled-components for the static site generation use case if this is something they are interested in exploring.
Thanks
Danny

I think as long as you lock the version of styled-components you depend on you should be fine!
I don't know if we want to guarantee that this will not break in the future (/cc @styled-components/core), but if we do ever break it and you notice during a routine upgrade we would definitely accept a PR to fix it again.

I think as long as you lock the version of styled-components you depend on you should be fine!

Agreed, we just don't want to get to a state in a year or so where we're X many versions behind styled-components because we cannot upgrade 😅

I don't know if we want to guarantee that this will not break in the future (/cc @styled-components/core), but if we do ever break it and you notice during a routine upgrade we would definitely accept a PR to fix it again.

Will be good to see what @styled-components/core have to say. Thanks for tagging them. As long as you guys are willing to accept PRs to fix this functionality going forward then I am happy 👍 Looking forward to seeing confirmation from core.

Looking forward to seeing confirmation from core.

I am @styled-components/core and I will accept PRs that fix that! :wink: I just tagged the GitHub team in case anybody disagrees, but I doubt anybody will since we added the export in the first place and need it for jest-styled-components.
I will close this for now since it seems resolved, good luck with your project!

@mxstbr My bad, thank you for styled-components and your help here!


Header issue when installed through nimble

When doing nimble test from Nimbus on mac I get the following:
/Users/.../Programming/Status/nimbus/nimcache/nimbus_rocksdb_backend.c:12:10: fatal error: '/Users/.../.nimble/pkgs/headers/c.h' file not found
#include "/Users/.../.nimble/pkgs/headers/c.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

which comes from https://github.com/status-im/nim-rocksdb/blob/92ac374a55ca822131a3c6a8bc05c53bb638f69d/src/rocksdb/librocksdb.nim#L38-L40
So:

headers should be added in the nimble file
The path resolution is wrong, it should be something like: ~/.nimble/pkgs/rocksdb-0.2.0/rocksdb/headers/c.h

Cloning rocksdb locally and using nimble develop instead of nimble install works fine however.
Given how nimble works, the package structure should be changed from
project/src/<files>
to
project/nimblename/<files>
because on nimble install the "src" directory disappears and we can't rely on paths.

An alternative solution would be to move the headers folder inside the src folder. It seems that the problem is that nimble deploys only the src folder on installations.

Yes this is my point 1, but beyond that nimble is checking the wrong place /Users/.../.nimble/pkgs/headers/c.h instead of ~/.nimble/pkgs/rocksdb-0.2.0/rocksdb/headers/c.h (which I agree would require installing both the src and the headers directories)

Fixed by changing pkg structure.


error when evaluate iou

hello, I try to eval iou after inferring them. For this example, I try in sequence 08.
I got this error.
evaluating label  /mnt/dataset/sequences/08/labels/000000.label with /mnt/result/infer_0108/sequences/08/predictions/000000.label
Traceback (most recent call last):
  File "evaluate_iou.py", line 176, in <module>
    label.open_scan(scan_file)
TypeError: open_scan() missing 2 required positional arguments: 'from_pose' and 'to_pose'

Can you help me? Thank you so much.

Hey @immaturehaan, thanks for using our code.
It seems like a data loading problem. You may double-check your data folder structure and the reference is here: https://github.com/PRBonn/LiDAR-MOS/tree/main/data#readme