Change JSF subsystem to use PersistentResourceDefinition

Windows Build 2949 is now running using a merge of 85089d3d7cd428d2d4e7fd97810b184681f83c8f

Linux Build 7908 is now running using a merge of 85089d3d7cd428d2d4e7fd97810b184681f83c8f

Linux Build 7908 outcome was SUCCESS using a merge of 85089d3d7cd428d2d4e7fd97810b184681f83c8f
Summary: Tests passed: 3060, ignored: 358 Build time: 00:49:14

Windows Build 2949 outcome was SUCCESS using a merge of 85089d3d7cd428d2d4e7fd97810b184681f83c8f
Summary: Tests passed: 3060, ignored: 358 Build time: 00:50:37


Can not redirct stderr in chdb.query()

Describe the unexpected behaviour
In version above 0.10, chdb.query() will print error message in stderr.
But it can not redirct or catch into variable.
How to reproduce
import chdb
from io import StringIO
import sys
from contextlib import redirect_stderr

f = StringIO()
with redirect_stderr(f):
    res = chdb.query("select 1", "csv")
    # sys.stderr.write("write stderr in python")
err = f.getvalue()

print("Capture err by redirect_stderr: ", err)

Expected behavior
Error msg catched and stored into err variable

Use https://github.com/minrk/wurlitzer can catch it.
from wurlitzer import pipes

with pipes() as (out, err):
    res = chdb.query("select 1", "csv")

errmsg = err.read()

Or use pipe_out, pipe_in = os.pipe()

It seems the wurlitzer created a new process to do that. I will fix it in chdb C++ after my "rebasing to 23.6" is finished.

Can we close this issue or is it still applicable to 0.11.4?

Still to be fixed

Fixed #105


published content not appearing as published

Issue found in 31e99e65e94ce6f485213f7ee5cb311526a2c9f4
All of the physics concepts (this may be true as well for maths concepts, I just haven't checked) are marked as unpublished on dev and staging, when they are actually published in the editor. Also, I don't think modifications to the concepts are being pushed to the live site. I know that I modified the Friction concept page two weeks ago and that you pushed to the live site since then, but the changes haven't appeared on the live site. This is rather worrying as there are mistakes on that page on the live site which have been corrected on staging.

Fixed in isaac-app.


chore(deps): update zod to ^3.23.8

Summary
This patch updated zod to ^3.23.8 to fix a type error related to https://github.com/samchon/typia/issues/1166.
Before upgrading, the EntryDescription type gives an output like:
type EntryDescription = {
    import: (string | string[]) & (string | string[] | undefined);
}

which will make typia complain.
After upgrading, the EntryDescription type gives an output like:
type EntryDescription = {
    import: string | string[];
}

which is clean and correct.
See the full changelog at https://github.com/colinhacks/zod/releases.

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

LGTM 👍

Please run pnpm api-extractor:local to update the api.md file


Add camunda modeler 4.0.0-alpha.0 release

One thing to consider: Should we link to 4.0.0-alpha.1 instead as it contains the fix for deployment-tool, or should we leave it up to Updates Server to promote the fix?

I left a few suggestions. Generally, it looks good! 🚀

@nikku Could you have a look at this?


Tooltip not working with hoverable and focusable components other than React Aria Buttons

Provide a general summary of the issue here
We are trying to use the Tooltip to create Tags that, when hovered, show a message.
Specifically, we have Tags (TagGroup) with some text and a Remove Button.
If we remove the Button from the Tag, the Tooltip never appears, even if it's a controlled open state. This makes it impossible to use Tooltips with components that are not buttons. And specifically, react-aria-components Buttons. It doesn't work with pure HTML buttons.
Additionally, we want to place the Tooltip on top of the Tag, pointing to the exact center of the tag. However, the Tooltip is placed in reference to the Remove button of the tag instead. We can reposition it using the triggerRef, but we wonder if it's because of the first behavior that this happens.
We would appreciate any help :)
Thank you.
P.S: We are aware that interactions on hover aren't very recommended, but it's required in our use case.
🤔 Expected Behavior?
The tooltip should be usable with any component that is hoverable and focusable, and it should be placed using the whole content of the Tooltip as a reference.
😯 Current Behavior
The tooltip should does not work with any component that is hoverable and focusable, other than React Aria Button, and it is placed using the first Button inside the tooltip as a reference.
💁 Possible Solution
No response
🔦 Context
We want the Tooltip to be usable with any hoverable and focusable component, like Tags, Buttons (our own buttons), etc.
🖥 Steps to Reproduce

Create a component that uses TooltipTrigger, Tooltip and has a button as trigger.
Hover over the button.
The tooltip should appear but it doesn't.

import {Button, OverlayArrow, Tooltip, TooltipTrigger} from 'react-aria-components';

<TooltipTrigger>
  <button>✏</button>
  <Tooltip>
    <OverlayArrow>
      <svg width={8} height={8} viewBox="0 0 8 8">
        <path d="M0 0 L4 4 L8 0" />
      </svg>
    </OverlayArrow>
    Edit
  </Tooltip>
</TooltipTrigger>

Version
react-aria-components 1.1.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
MacOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

The Tooltip should work with any component using useHover and useFocusable. So this could be a button created with useButton, and doesn't necessarily need to be a RAC Button. This is because it doesn't rely on native focus/hover state, but instead on the unified behavior provided by those hooks.
I think the tooltip not working with Tag is a different question, and may be related to how collections work. That might need more investigation.

Yeah it would be helpful to be able to wrap TooltipTrigger around Tag, MenuItem, etc when working with RAC collections.

Unfortunately, Tooltips will not be added around MenuItem. For that we recommend a pattern such as https://react-spectrum.adobe.com/react-spectrum/Menu.html#unavailable-items or including a description text. Tooltips are not accessible and should not be used to convey critical information.
Here are some good usage guidelines around using tooltips https://spectrum.adobe.com/page/tooltip/#Usage-guidelines

@snowystinger any chance of adding primitives to build something like ContextualHelpTrigger with RAC? There's a bit of complexity due to how the help dialog is shown using a submenu trigger, so it would be awesome to have a dedicated component/hook that would take care of that.

We have a plan to eventually add something we're referring to as "sub dialogs" as opposed to "sub menus", which is what could be used to create this more easily. I know we weren't entirely happy with the API we have in RSP right now for it. Let me check with the team and see where it is in our priorities.

The Tooltip should work with any component using useHover and useFocusable
Do you mean useFocusableRef()? I can't find useFocusable and also don't know how to make it work for useHover.

Is there an example I can look at?

here's where useButton uses useFocusable https://github.com/adobe/react-spectrum/blob/0c17289de18041e6f8b99df26a5a3ca922cc5145/packages/%40react-aria/button/src/useButton.ts#L99

When I use it on a focusable component, the placement is incorrect:

And when I try to repro it on codesandbox, it doesn't work:
sandbox link
I'm using the same versions locally and in codesandbox:

react-aria-components: 1.2.1
@react-aria/focus: 3.17.1

Ah, you've just missed making a ref. Here, I've fixed up the sandbox
https://codesandbox.io/p/sandbox/beautiful-brook-pkg7yc?file=%2Fsrc%2FDemo.jsx%3A7%2C32

@snowystinger thanks, that works!
A related question to useFocusable,
I'm getting type error:
const Focusable = forwardRef<HTMLSpanElement, PropsWithChildren<FocusableOptions>>((props, forwardedRef) => {
	// forwardRef doesn't guarantee a ref, so need to create a backup one so that we have a ref to our trigger every time
	const backupRef = useRef(null)
	const ref = forwardedRef ?? backupRef
        // Argument of type '((instance: HTMLSpanElement | null) => void) | MutableRefObject<HTMLSpanElement | null>' is not assignable to parameter of type 'RefObject<FocusableElement>'.
        // Type '(instance: HTMLSpanElement | null) => void' is not assignable to type 'RefObject<FocusableElement>'
	const { focusableProps } = useFocusable(props, ref)
	return
})

In react-spectrum code, it uses useFocusableRef instead.
Should I create something similar and use that instead?

export const TooltipFocusable = forwardRef<HTMLSpanElement, HTMLAttributes<HTMLSpanElement>>(
  (props, ref) => {
    const backupRef = useRef<HTMLSpanElement>(null);
    const determinedRef = (ref ?? backupRef) as RefObject<HTMLSpanElement>;
    const { focusableProps } = useFocusable(props as FocusableOptions, determinedRef);

    return ;
  });

Is here any specific reason that forwardRef is used as a solution and not just span with ref?
type FocusableSpanElement = HTMLSpanElement & FocusableElement;
type FocusableSpanProps = HTMLAttributes<FocusableSpanElement> &
  FocusableOptions;
function FocusableSpan(props: FocusableSpanProps) {
  const focusableSpanRef = useRef<FocusableSpanElement>(null);
  const { focusableProps } = useFocusable(props, focusableSpanRef);
  return ;
}


feat: Null safety.

Hi, as flutter 2.0 is released I've made implementation for null safety support.

Would be nice to have this reviewed merged and deployed please :) any plan @martinrybak ?

Could you atake a look at this @martinrybak ?

Any updates on this ?


Create google/cloud/README.md in -common

In the new monorepo world, every "product" in google/cloud/*/ has its own README.md file. Since our "common" package also contains user-facing stuff, we probably also want a README.md for that too. This is slightly weird since common lives in google/cloud/* directly, not a subdir, but I think that should be fine.

Fixed in https://github.com/googleapis/google-cloud-cpp-common/pull/285 and imported via #3918


Fix PHP APC pecl package name

I've said in your issue, that it can't be built, so we need a more wide fix.


Document that markdown.shikiConfig.theme can be a relative path

It came up in a support thread recently that Shiki themes can be loaded by providing a relative path: https://discord.com/channels/830184174198718474/1026227648055222363/1026235701777412157
Would be great to add a small example to the Markdown guide as it’s not obvious what such a path should look like, but this is often nicer than passing lots of config options.

Can I be assigned to this? I'd love to help

Can I be assigned to this? I'd love to help

You got it!


Square selection

For https://github.com/zyedidia/micro/issues/380
At the moment, you have to press "Shift" while selecting text with the mouse to create a "block selection".
Let me know what you think.

I'm not seeing the difference between holding shift and moving the cursor on this branch compared to on master.
What is the intended behavior of block selection?

You have to actually press shift then (hold) left-click and drag the mouse around.
It makes a square selection.

Oh ok I see.

Looks like there is some bugs with tabs when we delete/copy a square selection.
I'll reopen when fixed.

You have to actually press shift then (hold) left-click and drag the mouse around.
It makes a square selection.

What kind of terminal does it works with?
I'm using xterm (under Linux) and I'm not seeing the difference dragging the mouse around between holding shift key or not.
Does it work for console only?
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04 LTS
Release:        20.04
Codename:       focal

$ apt-cache policy micro
micro:
  Installed: 2.0.1-1
  Candidate: 2.0.1-1
  Version table:
 *** 2.0.1-1 500
        500 http://archive.ubuntu.com/ubuntu focal/universe amd64 Packages
        100 /var/lib/dpkg/status

Hmm... is it still not merged yet, after 2 years?


Introduce a new filename validation function

Based on the conversation here.
This PR introduces a new filename validation function which supersedes the existing filepathBreakout function. This new more complete validation includes that included in the atomic writer, as well as ensuring that the filename does not include '/'.
Whilst most if not more validation now occurs on a filename, it also now occurs earlier in the publish volume pipeline. This is beneficial since we now expose the offending volume attribute in the error message presented to the user.
/assign @munnerz

Awesome, this is a great improvement!
/lgtm


"Open Visualizer to the Side" shortcut should be CMD+K, V on Mac, not CTRL+K, V

This is pretty much expected behavior for Mac commands. CTRL should be saved for less frequent commands.
While we're at it, we might as well add SHIFT+CMD+V as a shortcut for "Open Visualizer" (not to the side) like markdown as well.

Feel free to assign to me.


Kedro context  in  jupyterhub

What are you trying to do?
In my company we use multi-user jupyterhub installation and have no freedom to start jupyter notebooks with custom ports. Can only execute jupyter notebooks from jupyterhub.
What is best practice to marry kedro and jupterhub?
I know how to add custom conda environment/kernel and make it visible in jupyterhub.
The question is how to automatically create kedro context on start of notebook of this kernel?

So, the way that Kedro works is that it has a file located at .ipython/profile_default/startup/00-kedro-init.py inside your project, which jupyter automatically picks up on. This file is responsible for loading the context and inserting it into the Jupyter session scope.
It's just a matter of you configuring your JupyterHub installation to run that same code on startup. This SO answer may be helpful, but you may need to do further investigation.

Thank you both, I'm closing this as answered. Please feel free to direct questions to StackOverflow (we monitor questions tagged with kedro) or get support from the community on Discourse. 😊


Typo on developer index

The developer index page says "May of our APIs". Should be "Many of our APIs".
http://open.gsa.gov/developer/

Updated, thanks!


Sync PVP - Only allow opponent access to level session

Instead of the world.
https://github.com/codecombat/codecombat/blob/master/app/views/play/level/PlayLevelView.coffee#L854

Not worrying about sync PVP stuff right now.


chore: add summary build with commit fest and patch id information

Closes #43

Can you please add this text as well? Please make sure you use the proper variables:
# CloudNativePG `Cluster`

You can create a cluster in CloudNativePG running this image:

```sh
(cat <<EOF
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  name: commitfest-48-4937
spec:
  imageName: ghcr.io/gbartolini/postgresql-trunk:17-commitfest-48-4937
  instances: 3

  storage:
    size: 1Gi
EOF
) | kubectl apply -f -
```


AppSync GraphQL: Add @connection data to a model as a batch

** Which Category is your question related to? **
AppSync, Mutation, Resolver
** What AWS Services are you utilizing? **
AppSync, GraphQLTransform, Cognito
** Provide additional details e.g. code snippets **
I have 2 models in schema.graphql (see image under). Radar.techList is an @connection with Tech. I want to create a feature where a Radar can be added with already added Tech. This means that all the Tech I want to add to the radar needs to be duplicated with another Tech.radar value.
I tried to simply add Radar with an array of Tech, which returns
{"data":null,"errors":[{"path":null,"locations":null,"message":"The variables input contains a field name 'techList' that is not defined for input object type 'UpdateRadarInput' "}]}
Is there any intended way of doing this? I see one solution which is to loop through all Tech and duplicate them while renaming the Tech.radar field. However, I'd prefer something more "batchy".

Currently, the way to do this is via a custom mutation or lambda resolver. You can read more about how to use custom resources to create custom resolvers & attach lambda function resolvers here https://aws-amplify.github.io/docs/cli/graphql#common-patterns-for-the-api-category.
PR #1346 implements the @function directive that provides a much simpler interface for configuring lambda resolvers (although the process is very similar under the hood). Once this is merged, you will be able to do:
type Mutation {
  createRadarWithTech(..): Radar @function(name: "CreateRadarAndTech")
}

I'd also point you to #1060 which discusses supporting custom transformers. With this you would be able to implement your own @batchCreate directive that configures the call in a reproducible way such that you can use it with multiple models.

Hi @mikeparisstuff and thanks for the reply. PR #1346 is a very welcome feature. I've found a working solution for now which I'll replace with batchCreate solution when ready. I prefer that towards creating custom resolvers as for now.
Thanks again! Love what you're doing here


RUF031: False positive when using with unpacking

The following run should not indicate any errors
>> ruff check --isolated --preview --select RUF031 --target-version py38 subscript-tuple.py
subscript-tuple.py:1:3: RUF031 [*] Avoid parentheses for tuples in subscripts.
|
1 | d[(*indices, 5)]
|   ^^^^^^^^^^^^^ RUF031
|
= help: Remove the parentheses.

Found 1 error.
[*] 1 fixable with the `--fix` option.

As far as I know, d[*indices, 5] is invalid syntax on Python 3.8, but should work for Python >=3.9 (with the new PEG parser, I think? definitely works on 3.12).
Expected result:

No errors / fixes reported when setting --target-version py38.
The recommended fix when setting --target-version py39 and above.

xref: CI failure resulting from the fix: https://github.com/inducer/pymbolic/actions/runs/10315281929/job/28555159989?pr=144

Thanks for reporting this preview error!
@dylwil3  do you want to take this. Surprising how many edge cases there are to this rule :open_mouth:

Sure!
This has been a good learning experience in both Rust and the intricacies of Python, so I'm happy to keep taking on RUF031 bugs 😄

The CI link above seems to also show a syntax error in Python 3.9, unless I'm reading it wrong:
https://github.com/inducer/pymbolic/actions/runs/10315281929/job/28555160514?pr=144
I can confirm 3.11 is ok, but I gotta go check 3.10. Will update PR once I get a chance to do that.

The CI link above seems to also show a syntax error in Python 3.9, unless I'm reading it wrong:

Ah, yes! I didn't check that because it got cancelled, but it seems like 3.9 also doesn't support unpacking in the subscript. Sorry for the confusion.

Looks like this is a syntax error in 3.10 as well. It was allowed starting in 3.11, hidden in PEP-646


Feedback on Mobile version

About section always goes first (who we are, what this is about):

resolved or redistributed to other issues.


fix: Use correct tokenUrl and fix typos (Sass -> SaaS)

It seems that the resource aquasec_role_mapping_saas today only works for the default SaaS region. The other regions eu-1, asia-1 and asia-2 cannot work with todays implementation.
Fixes #244
While here, I also fixed typos inside class names and comments.
Before change:

After change:

(Traces/screenshots are made using github.com/mitmproxy.)
/cc: @BaruchBilanski , @yossig-aquasec , @blanchardma , @the-technat

@semyonmor thx for merging this!
Can you trigger a release build now? Waiting for it :)


packer cache script should fail never to help to cache dependencies

Closed #805
Highlights

The responsibility to validate the build should not be addressed within the packer cache script.
This will help to fetch and cache all the maven dependencies and also the docker images independently of the maven build status.
-Dmaven.test.failure.ignore=true could be an option but I'd rather prefer to avoid failing the maven build instead.

+1 for -Dmaven.test.failure.ignore=true

I'd rather say -Dmaven.test.failure.ignore=true will be more prescriptive in the hypothetical case the master branch got a compilation error, when it should not happen, and therefore this script will be fail. That's the main reason for using fail-never instead. What do you think @felixbarny ?

I misunderstood the meaning of --never-fail. I thought it would behave as normal but always exit with exit code 0. But it seems like it continues when tests fail 👍


Update to OTel 1.10.1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #150 (338aac3) into main (8d438e4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #150   +/-   ##
=========================================
  Coverage     73.91%   73.91%
  Complexity       15       15
=========================================
  Files             3        3
  Lines            46       46
  Branches          5        5
=========================================
  Hits             34       34
  Misses            8        8
  Partials          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d438e4...338aac3. Read the comment docs.


Improve our style guide wrt RST headings

previously, our style guide for the lower-level RST headings was poorly thought out. I spent some time today trying to rethink this from a typography perspective and this is what I came up with
I looked at the RST spec, found the list of valid characters, and cut the list down to characters that actually resemble properly typeset underlines, and then ranked them by visual prominence so as to mirror the way that headings are typeset in a "rich text" document
the convention of using "=" and "-" was a bit of a limiting factor and I had to work around that. the convention is so strong at Crate and so widely spread, that I consider it unfeasible (and a poor use of time) to attempt to change it. the lower level headings are rarely used and where they are used, they usually do not follow our previous style guide because they were put in place before our style guide was adopted. so, my reasoning is: updating our style guide now, before too many additional changes have been made, is a net benefit
(for context: I only sporadically update heading markup. typically if I am in the doc making other changes for a story or what have you. so I've only done it once or twice. certainly not enough to justify "freezing" the style guide)

Just taking the chance here to drop my humble opinion about this. I would follow the guidelines as outlined on the Sphinx documentation at [1].
Regarding the legacy we would be fighting, it would be great to have a black-style formatter to align all documents with this automatically. Then, the effort required could be minimized.
[1] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

it would be great to have a black-style formatter

JFYI, there is rstfmt and blacken-docs, but I haven't looked into them yet.

https://github.com/dzhu/rstfmt
https://github.com/asottile/blacken-docs

I'll merge this now, and if you want to explore those auto-formatters that is cool with me! if you find a workable solution that is easy to rollout/implement I'd be happy with that (we could even integrate it into make check)


Issue when trying to connect

Hi,
Thanks you for sharing this repository and for the step by step video related to it.
I am not sure this is the better place to ask some but I am trying.
I have cloned the repository and tried to run the page with the python server.
I am encountering this issue:
At launching the page is well as expected

when clicking on the connect button, it switches to:

The web bluetooth is correctly enabled because I checked and I am able to connect to web bluetooth devices through other means. I am not sure how I could fix that. if you have any idea of what may be the issue.
Thanks for any possible help.
Best regards.
Florence Haudin.

Hi @HaudinFlorence
What's your browser and browser version?

Hello. Sorry for the late answer. I am using Chrome Version 128.0.6613.113 (Official Build) (64-bit).


$or is not working on the demo examples

Hi,
Great demo at http://nolanlawson.github.io/pouchdb-find/ but here is a weird thing.
$and seems to work fine, for example
// Multi-field queries and sorting are also supported
db.createIndex({
  index: {fields: ['series', 'debut']}
}).then(function () {
  return db.find({
    selector: {
      $and: [
        {series: {$eq: 'Mario'}},
        {debut: {$eq: 1990}}
      ]
    }
  });
});

but if I replace $and with $or then I get index error (even though both indices are there)
// Multi-field queries and sorting are also supported
db.createIndex({
  index: {fields: ['series', 'debut']}
}).then(function () {
  return db.find({
    selector: {
      or: [
        {series: {$eq: 'Mario'}},
        {debut: {$eq: 1990}}
      ]
    }
  });
});

Error
Error: couldn't find a usable index. try creating an index on: or. Make sure that only $eq, $gt, $gte, $lt, and $lte are used for the indexed fields.
    at createNoIndexFoundError (http://nolanlawson.github.io/pouchdb-find/dist/pouchdb.find.js:2145:10)
    at planQuery (http://nolanlawson.github.io/pouchdb-find/dist/pouchdb.find.js:2166:11)
    at http://nolanlawson.github.io/pouchdb-find/dist/pouchdb.find.js:1663:21

The issue here is the debut selector, which can't work with the ['series', 'debut'] index because series is first, not debug. In this case, the user would indeed be expected to create an index on debut.


Glutin does not show on GTX780 and Kubuntu 15.04

Thanks for glutin, I have it running fine on Windows 8.1
On Kubuntu 15.04 x64 and 16 GB of RAM, with an nVidia GTX70 card the window comes up properly but only displays the background colour. Nothing else draws. This happens in the examples and my own game. All the events are processed properly there is just no display. I have tried both nVidia and Nouveau drivers, and all the opengl display options.
Also if I try the fullscreen example, glutin spits the dummy with: OsError("Could not find a suitable graphics mode")
Steve

The OpenGL commands used by glutin's examples are old OpenGL 1.1 stuff that are maybe no longer supported. Are you using a library in your game or are you manually using OpenGL?
For the fullscreen problem, it should be fixed by #504

OK I had 2 errors, 1 my GLSL code was wrong for the new platform, and second one I believe is an error in "src/api/x11/window.rs"
Line 379 tries to find the supported display sizes available, testing it, showed it gets the width right, but the height is always returned as 0. So there is a problem with the foreign function call. I was able to plug this gap by setting best_mode to 0 manually, as I don't know how the inner libraries help. Hope this helps finding the problem.
Steve

Line 379 tries to find the supported display sizes available, testing it, showed it gets the width right, but the height is always returned as 0. So there is a problem with the foreign function call. I was able to plug this gap by setting best_mode to 0 manually, as I don't know how the inner libraries help. Hope this helps finding the problem.

Yeah I spent two hours on exactly this problem yesterday :smiley:
That's what #504 fixes

Should that issue be closed then?


Remove writing to final field

Description of the PR
Closes #841 by overriding a method instead of setting a field that has become final in IntelliJ IDEA 2022
@OlliKiljunen should the backgroundColor field be volatile? After all, there are no guarantees regarding which threads are these two methods inside MyEditorNotificationPanel restricted to.
Testing

unit
integration
manual

- [ ] new unit tests created
- [X] all unit tests pass

- [ ] new integration tests created
- [X] all integration tests pass

- [X] manual testing went well

Have you updated the TESTING.md or other relevant documentation on your branch?

[ ] Yes.
[ ] Not yet. I will do it next.
[x] Not relevant.

@OlliKiljunen should the backgroundColor field be volatile? After all, there are no guarantees regarding which threads are these two methods inside MyEditorNotificationPanel restricted to.

Methods in Swing (such as getBackground()) are not thread safe and shouldn't be called outside EDT. We can (and should) set the similar restriction for setColor() method. Now, there's a guarantee. :) So it doesn't have to volatile.

Please see my second comment on the ticket. I'd like to discuss the necessity to inherit EditorNotificationPanel before reviewing this ticket.

I'm pretty sure it was used solely for convenience reasons (i.e. already implemented & looks nice). It could certainly be a regular JPanel

Please see my second comment on the ticket. I'd like to discuss the necessity to inherit EditorNotificationPanel before reviewing this ticket.

I'm pretty sure it was used solely for convenience reasons (i.e. already implemented & looks nice). And perhaps consistency with IntelliJ-styled banners in the editor section. It could certainly be a regular JPanel, but if JetBrains already did the work (laying out the banner, making it consistent with themes) using it is objectively simpler

Inheritance shouldn't be used for the purpose of code re-use, but to model is-a relationships. Any idea how much work it would be take to re-implement the required functionality/design? (One can basically copy the relevant parts from EditorNotificationPanel because licensing ain't an issue between the projects.)

I kind of agree with that. To be honest, I wouldn't really mind using EditorNotificationPanel directly (without inheritance) if only it hadn't made the background color field final. Unfortunately they did (which, to me, is a questionable change - I don't see any reason why a Swing component would have an immutable color õ.õ).
Then again, it also depends on your point of view. If necessary, I can see the current implementation as follows: our class MyEditorNotificationPanel is an EditorNotificationPanel with the extended functionality of having a dynamic background color. It really does sound like inheritance, doesn't it?
Of course we can re-implement this banner from the basic JPanel, it shouldn't be more than ~60-70 lines of code. If you wish, I can make a parallel pull request with separate implementation using JPanel

I can see the current implementation as follows: our class MyEditorNotificationPanel is an EditorNotificationPanel with the extended functionality of having a dynamic background color. It really does sound like inheritance, doesn't it?

The thing is, we don't use it for editor. If the original implementor of the superclass has thought it to be used only with editor windows that might cause more compability problems in the future.

If you wish, I can make a parallel pull request with separate implementation using JPanel

I'd say a ticket of it is enough at this point.


Consolidate height of controls

I'd suggest consolidating the height of various Foundation controls for instance:

make the Switch the same height as buttons,
make dropdowns, selects, checkboxes and buttons the same height,
if we need (I agree we do) various fixed sizes of controls (Tiny, Small, Normal, Large), make their height the same across the board,
(optional) remove margins from controls when using flexbox positioning.

We heavily rely on align-items: center or align-items: baseline for horizontal positioning and having the controls different heights and with some default margins makes it hard to align (we are currently removing the margins manually from most controls).

I agree with all of these :)
Is there a PR for this I can review?

No, there is not yet a PR.


Feature Request: Always Search External on Enter

I like to have local search be the default, without a prefix, so as I type, local results are shown. However, when I press enter, it would be nice to have that automatically break out to an external default search provider (i.e. Google) without having to use a prefix.
It seems to be hard coded to use DuckDuckGo when local search is the default.
Have not used React/Typescript before, but I will give it a shot. Figured I'd put this here anyway in case it's helpful to others.

This would be super helpful. I want local search for everything, but if nothing is found and I press enter, I want to search Google instead of DuckDuckGo.

Could the implementation of this, resulted in this (https://github.com/pawelmalak/flame/issues/270) bug?


make dupefilter support create from spider

redis dupefilter is based on spider, it may suppport from spider.

Current coverage is 96.57% (diff: 100%)

Merging #83 into master will increase coverage by 0.30%

@@             master        #83   diff @@
==========================================
  Files            17         17
  Lines           696        700     +4
  Methods           0          0
  Messages          0          0
  Branches         55         55
==========================================
+ Hits            670        676     +6
+ Misses           10          8     -2
  Partials         16         16

Powered by Codecov. Last update 500039b...384996d

Thanks for your PR. I will think about this as it will break custom dupefilter classes.

@zoyanhui I think this PR is NOT needed.  If i'm right, you might want to make it possible to set specific settings for scrapy_redis in spider. To do that, you could just set them in custom_settings in your spider.
A simple
custom_settings = {
        ... ...
        'SCHEDULER_DUPEFILTER_KEY' = '... ...',
        ...


WIP: adding support for adding VBA macros

I have started working on adding support for adding macros extracted from xlsx files to rust_xlsxwriter. This is similar to the following XlsxWriter feature: https://xlsxwriter.readthedocs.io/working_with_macros.html
Initial working code is as follows:
use rust_xlsxwriter::{Workbook, XlsxError};

fn main() -> Result<(), XlsxError> {
    // Create a new Excel file object.
    let mut workbook = Workbook::new();

    // Add the VBA macro file.
    workbook.add_vba_project("examples/vbaProject.bin")?;

    // Add a worksheet and some text.
    let worksheet = workbook.add_worksheet();

    // Widen the first column for clarity.
    worksheet.set_column_width(0, 30)?;

    worksheet.write(2, 0, "Run macro say_hello()")?;

    // Save the file to disk. Note the `.xlsm` extension. This is required by
    // Excel or it raise a warning.
    workbook.save("macros.xlsm")?;

    Ok(())
}

Output:

Build the docs for details for view the raw docs here: https://github.com/jmcnamara/rust_xlsxwriter/blob/main/src/macros.rs

Upstream in v0.71.0.


Add option for custom player animations/skins/appearance

Add option for custom player animations/skins/appearance so other players can appear visually distinct from each other aside from just names.

Need to figure out the best way to get different players to have different animations. Also might need to figure out how to tell if a player actually has different animations in the first place.


Can we use backward within the forward function of a criterion?

❓ Questions and Help

What is your question?
Can we use a loss.backward() call within a criterion in fairseq? I am trying to write an adversarial version of the cross entropy loss.
Code (Forward Function)
   `sample2=copy.deepcopy(sample)
    sample2['net_input']['source']['video'].requires_grad=True
    net_output = model(**sample2["net_input"])
    loss_dummy, _ = self.compute_loss(model, net_output, sample2, reduce=reduce)
    sample2['net_input']['source']['video'].retain_grad()
    model.zero_grad()
    loss_dummy.backward()
    grad=sample2['net_input']['source']['video'].grad
    sign_data_grad = grad.sign()
    sample2['net_input']['source']['video']=sample2['net_input']['source']['video']+self.epsilon*sign_data_grad
    model.zero_grad()
    net_output_adv = model(finetune=False,**sample2["net_input"])
    loss_adv, nll_loss_adv = self.compute_loss(model, net_output_adv, sample2, reduce=reduce)
    net_output = model(finetune=False,**sample["net_input"])
    loss_clean, nll_loss = self.compute_loss(model, net_output, sample, reduce=reduce)
    sample_size = (
        sample["target"].size(0) if self.sentence_avg else sample["ntokens"]
    )
    loss=self.alpha*loss_clean+(1-self.alpha)*loss_adv`

What have you tried?
The line loss_dummy.backward() throws this error : Runtime error : Element 0 of tensor does not require grad and does not have a grad function. (During a fair-seq hydra script)
I tried  using the criterion in a python script, and it works perfectly fine, which made me assume it could be something to do with fairseq under the hood.
What's your environment?

fairseq Version (e.g., 1.0 or main): commit from https://github.com/facebookresearch/av_hubert
PyTorch Version (e.g., 1.0): 1.7
OS (e.g., Linux): Linux
How you installed fairseq (pip, source) : source
Build command you used (if compiling from source):(Instructions from https://github.com/facebookresearch/av_hubert)
Python version: 3.8
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

resolved


Updated Roles

All Submissions:

[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[YES] I have added tests to cover my changes.
[YES] All new and existing tests passed.
[YES] I have formatted the terraform code.  (terraform fmt -recursive && go fmt ./...)

Current Behavior or Linked Issues

#175
Does this introduce a breaking change?

[YES]

Not necessary anymore.


chore(RHTAPWATCH-741): Add recording rules for exporter

Add recording rules to translate the components existing metrics to expose availability.

/retest

/retest

@yftacherzog @amisstea I have updated the code. Please review again.

/retest

Looks good! Once you have this one merged, make sure you create the necessary changes in app-interface and update the readme here with the instructions for how to update the recording rules references.

Sure Yftach! I already created the MR for app-interface (https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/97295) and will update README as well. Thank you!


tbb/task.h deprecated, build failure

I found reference to a similar issue in the past couple years, but it seems those issues were resolved. This occurred today using the latest versions of OpenVDB cloned today, and the latest version of TBB from vcpkg which is: tbb:x64-windows 2020_U3#6
Host Environment

OS: Windows x64
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.30.30706 for x64

To Reproduce
Steps to reproduce the behavior:
As per the build instructions on this github:
PS C:\Users\milin\openvdb\build> cmake --build . --parallel 4 --config Release --target install
Failure logs
Copyright (C) Microsoft Corporation. All rights reserved.

  Checking Build System
  Activate.cc
  Activate.cc
  TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manu
  al.
  TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manu
  al.
  ChangeBackground.cc
  ChangeBackground.cc
  Clip.cc
  Clip.cc
  TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manu
  al.
  TBB Warning: tbb/task.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manu
  al.......```

This continues with many many files.

@physixtential Thanks for posting this issue, the TBB version update is still going on, we will continue to promote this process, and I will try to reproduce your problem locally.  see #19909 :)

@FrankXie05 that's good news. Thank you. In the meantime, do you have temporary advice for getting around this? I assume the answer is to just use some older version of tbb. Is there a particularly recommended one?

@FrankXie05 I just realized this morning that I accidentally submitted this issue to vcpkg. I meant to submit to openvdb directly, as the issue is really that their instructions tell us to clone openvdb, and vcpkg install a list of things, which doesn't work because it gets the most recent ones from your manager. What they need to do until they get up to date is recommend that we install openvdb directly from vcpkg, which automatically gets a working set of older dependencies.

@physixtential If you want to use the latest one, you can certainly submit an issue to openvdb, and we will continue to promote this update process. And you can use the following command to use openVDB provided by vcpkg. :)

git clone https://github.com/microsoft/vcpkg
.\bootstrap-vcpkg.bat
.\vcpkg.exe install openvdb

@physixtential Is still work for this issue? Is the problem still there?

@physixtential  I will close this issue temporarily, I will ping you as soon as I know the tbbupdate, obviously you can submit an issue to the Upstream to solve this bug. :)


Security Vulnerability in the project

Hello, I have discovered a security vulnerability in this project and I do not want to publicly discuss the vulnerability.
Please contact me, my email is<EMAIL_ADDRESS>Inviting you to my private repository which is the PoC of this security vulnerability is also okay.
@twxs , I will be very grateful if you can reply in time~

@twxs

@i-Taozi Can you please report the security vulnerability to Microsoft: see https://github.com/microsoft/vscode-cmake-tools/security/policy ? This CMake extension is currently bundled as part of the CMake Tools extension pack that Microsoft publishes: https://github.com/microsoft/vscode-cmake-tools/blob/db625d2b897cceb3141eec9b7f8b7e71e6b796ae/package.json#L2213 , so you should mention that in your bug report.

@sean-mcmanus  Thanks for your help!


Adding bcmath php module

This installs the php extension bcmath so that it is possible to use libraries such as phpamqplib
This is a patch for #37

@derekbelrose Thanks a lot! This is great :+1: .
Merged, and will be in the new builds.

@RobLoach any chance to push it to the docker hub? it has outdated version now with no bcmath extension.


Migrate codeforafrica to payload v 2

Description
On OCTOBER 9, 2023, Payload CMS announced the release of version 2.
Version 2 comes with a ton of features such as support for postgres, admin UI updates and support for migrations. Even though we are not going to use the postgres feature, support for migrations is a crucial for the maintenance of our app.
This PR updates payload version to 2.16.1 for Code for Africa app.
To test this PR,
Execute the command below
make codeforafrica.
The command will start codeforafrica in production mode and attach docker database
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Screenshots
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

@thepsalmist @kelvinkipruto Use this URL to test if anything has been missed out during migration


[BUG] Passing custom YAML file for Docker missing colon

What is the bug?
Here
It is missing colon for opensearch-dashboards
What is the expected behavior?
It should be opensearch-dashboards:

Missing colon should be in there now: https://opensearch.org/docs/latest/opensearch/install/docker/


Getting Error:  ERROR: Hook 'load_terraform_data' from /usr/local/lib/python3.7/site-packages/terraform_compliance/steps/terrain.py:5 raised: 'TypeError: 'NoneType' object is not iterable'

Description :
It looks as though when encountering a module output that is just a list it is not seeing it as iterable.
If I move the declaration of the list to a local and then assign the local to the output value it succeeds
Tests added and proposed fix in a draft PR https://github.com/eerkunt/terraform-compliance/pull/276 - You can see the failure scenario there.

terraform-compliance -p plan.out.json -f .
Fails with both python and docker container
Error output

mlogan at C02YV0U4LVCF in ~/Projects/mlogan/terraform-compliance/tests/functional/test_module_output_list on master [?]
$ terraform-compliance -p plan.out.json -f .
terraform-compliance v1.2.1 initiated

🚩 Features	: /target
🚩 Plan File	: /target/plan.out.json

🚩 Running tests. 🎉

Feature: The scenarios defined below  # /target/security_group.feature
    require an MR review if any
    of the resources below exist
    in a plan
1 features (0 passed)
4 scenarios (0 passed)
8 steps (0 passed)
Run<PHONE_NUMBER> finished within a moment
❗ ERROR: Hook 'load_terraform_data' from /usr/local/lib/python3.7/site-packages/terraform_compliance/steps/terrain.py:5 raised: 'TypeError: 'NoneType' object is not iterable'

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/radish/hookregistry.py", line 132, in call
    func(model, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/terraform_compliance/steps/terrain.py", line 7, in load_terraform_data
    world.config.terraform = TerraformParser(world.config.user_data['plan_file'])
  File "/usr/local/lib/python3.7/site-packages/terraform_compliance/extensions/terraform.py", line 42, in __init__
    self.parse()
  File "/usr/local/lib/python3.7/site-packages/terraform_compliance/extensions/terraform.py", line 344, in parse
    self._mount_references()
  File "/usr/local/lib/python3.7/site-packages/terraform_compliance/extensions/terraform.py", line 289, in _mount_references
    ref_list[key] = self._find_resource_from_name(ref)
  File "/usr/local/lib/python3.7/site-packages/terraform_compliance/extensions/terraform.py", line 259, in _find_resource_from_name
    resources = ['{}.{}.{}'.format(resource_type, module_name, res) for res in resources]
TypeError: 'NoneType' object is not iterable

Simple feature failure test - can be anything

Feature: The scenarios defined below
	 require an MR review if any
	 of the resources below exist
	 in a plan

Scenario Outline: changes to specific resources
    Given I have <resource> defined
    Then the scenario should fail

    Examples:
      | resource                       |
      | aws_elasticache_security_group |
      | aws_default_security_group     |
      | aws_security_group             |
      | aws_security_group_rule        |

Expected behavior :

Tested versions :

terraform-compliance version 1.2.1
terraform version 0.12.13
<python runtime version, 3.7.7 (BUt fails from docker as well)

Additional context
Add any other context about the problem here.

Released 1.2.3 with changes including your PR.

Assuming this is fixed with #276 by yourself, closing the issue.
Please let me know if the problem still persists.
Thanks 🎉


Updated github.com/go-sql-driver/mysql to the master HEAD.

Fixes bug https://github.com/go-sql-driver/mysql/issues/536 so now the same TLS config does not need to be registered for each host and with different name (I am working on the ability to have mixed TLS and non-TLS connections to different nodes of the topology).
Also, an interesting effect noticed: after the upgrade of the driver there was a 20% decrease of median poll time to orchestrator backend.

Also, an interesting effect noticed: after the upgrade of the driver there was a 20% decrease of median poll time to orchestrator backend.

very interesting indeed.

@maurosr can you kindly ping me after this had been deployed at your company for a few days in production? I like nothing better than knowing this runs successfully on X,000 servers.

Will do (3 hours running in production by now and is looking good).

@shlomi-noach everything looks fine in production with the driver upgrade.

Ok cool. I'll merge shortly

Sorry, forgot to make a new branch for TLS. I'll revert and create another PR for that.


analog write does not work on various pins

This is a follow up of https://github.com/Microsoft/pxt-adafruit/issues/604
Test sample:
#include "CircuitPlayground.h"
CircuitPlayground cplay;
int main()
{
    while(1)
    {
        cplay.io.a4.setAnalogValue(0);
        cplay.sleep(200);
        cplay.io.a4.setAnalogValue(512);
        cplay.sleep(200);
    }
}

Result:

A1, A2, A3: ok
A0, A4, ... : freeze

So I tracked this back to mbed.
It seems like the pin map for the peripheral is incomplete, so when you try and use these pins for PWM, mbed throws an error, not a hard fault, halting the user app.
From what I can make out on the datasheet, the following is the summary for user facing pins:

A0 (PA02) - DAC only, no PWM.
A1 (PA05) - PWM capable, and mapped correctly in mbed.
A2 (PA06) - PWM capable, and mapped correctly in mbed.
A3 (PA07) - PWM capable, and mapped correctly in mbed.
A4 (PB03) - PWM capable, and not mapped in mbed currently.
A5 (PB02) - PWM capable, and not mapped in mbed currently.
A6 (PB09) - PWM capable, and not mapped in mbed currently.
A7 (PB08) - PWM capable, and not mapped in mbed currently.

Actions for this is are as follows:

Disallow analog out on A0.
Add correct mappings for A4 - A7

Okay, further to my previous comment, it seems like the pins that aren't mapped in mbed use TC clocks, rather than TCC clocks (See section 7.1 of the datasheet). This means that the code for PWMOut WILL NOT work on the above pins, as the implementation assumes TCC.
It may be time to drop mbed for CPlay IO.

@pelikhan I don't have the cycles to write the replacement driver at the moment. In the meantime, it might be best to disable analog out operations on those pins.

Some clarification to my original comment after reading the datasheet again...

A0 (PA02) - DAC only, can be added.
A1 (PA05) - PWM capable, and mapped correctly in mbed.
A2 (PA06) - PWM capable, and mapped correctly in mbed.
A3 (PA07) - PWM capable, and mapped correctly in mbed.
- A4 (PB03) - PWM capable, cannot be mapped due to absence of TC6.
- A5 (PB02) - PWM capable, cannot be mapped due to absence of TC6.
A6 (PB09) - PWM capable, and not mapped in mbed currently.
A7 (PB08) - PWM capable, and not mapped in mbed currently.

So, this means that we would have a net gain of 3 "analogue out" pins, rather than the 5 I originally stated.


Crash when new version alert pops up

User reported crash of his wallet when the wallet shows the popup alerting a new version is available (https://github.com/navcoin/navcoin-core/blob/master/src/main.cpp#L3677).
It coincides with a steep fall in the difficulty around block 3111970 (https://chainz.cryptoid.info/nav/#@diff), making me think around that height >40% of the blocks were mined with 4.6.0, triggering the alert and causing all the nodes running an old version to crash.
I was not able to reproduce the issue by:

Connecting a modified 4.6.0 to mainnet and modifying:
int32_t nExpectedVersion = CLIENT_VERSION-10000;
and
if (nUpgraded > 10/2.5).
Connecting a 4.5.2 client to mainnet.
Using devnet with 2 local nodes with 4.6.0 and 4.5.2 and forcing the alert to show.

In all the cases I tested under OSX and the alert showed successfully without crash.
There's evidence the issue is real (or there might be other reason for the crashes) so it's worth to investigate.

I could not replicate this with my machines, I installed older versions and got the pop up / warning for did not crash.

I was running v4.5.2 when I received an alert of a new version but it did not crash. I am on Win 10 64-bit.

I think I was able to get a windows wallet to crash with the pop up.
Seems it happened when the popup was already open, then another 1000 blocks came in with new version bit, and the pop up tried to open again.
I'll see if I can replicate this again on test/devnet and upload some more info
@aguycalled  @craigmacgregor

were you able to replicate this? @mxaddict

Yes on windows, but I'm not sure if it was the wallet if it was because i was playing games when the pop up came.
It wasn't really a crash, it was more like i could not get the OS to focus on the wallet so I had to kill it via task manager.
Basically the pop up came up, then I noticed that the wallet was not hung, so I left it open.
Then i was playing Rainbow Six Siege. Then the pop up opened agian. But I could not get focus on the wallet, alt tab and clicking on wallet icon did not work. So I just killed it via task manager.

Was anyone else able to replicate this?

Is anyone still experiencing this? I could not replicate.

we disabled the popup

I guess we can close this now.


Farming skill issue, maybe

I'm not sure if this was intended or not but once a player breaks a crop in a location all future crops broken in that location don't give farming xp. If this was intended can you make a config setting for farming to continue to give xp for blocks broke in the same location?
As always, Thank you for your work on this plugin. We appreciate it.

There is currently a bug in sponge, that causes the ChangeBlockEvent.Grow event to never be posted, so i cant listen to block growing. Im currently working om a way around it, but its not very easy.

Mkay, seems a lot of plugins are waiting on sponge updates to get things to work correctly. No worries. As always, thank you for all your work on these plugins.


v0.8.1_37: By clicking download button a page with code is opened but file is not downloaded

SEVERITY: Minor
MODULE:

Bubble Chart
Mountain Chart

Platform:

MAC / Safari 8.0
iPad Air 2 iOS(8.3) / Safari 8.0

RELEASE: v0.8.1
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.8.1/preview/bubblechart.html
Bubble chart page will be loaded
Click the “Record” button available on the right panel
A red ball is shown on the right top of the chart
Take mouse to that red ball and click that
Note that a new page is opened with a messed code but file is not downloaded

ACTUAL RESULTS:
By clicking download button a page is opened but file is not downloaded
EXPECTED RESULTS:
File should be downloaded by clicking download button
SCREENSHOT:

Like #634, we shoulnd't worry about this


[Event Request] Page 344 Navigate OnAfterNavigateShowRecords

As ShowRecords is used from both after FindRecords and FindExtRecords we need additional parameters in the existing event OnAfterNavigateShowRecords:
old:
local procedure OnAfterNavigateShowRecords(TableID: Integer; DocNoFilter: Text; PostingDateFilter: Text; ItemTrackingSearch: Boolean; var TempDocumentEntry: Record "Document Entry" temporary; SalesInvoiceHeader: Record "Sales Invoice Header"; SalesCrMemoHeader: Record "Sales Cr.Memo Header"; PurchInvHeader: Record "Purch. Inv. Header"; PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; ServiceInvoiceHeader: Record "Service Invoice Header"; ServiceCrMemoHeader: Record "Service Cr.Memo Header")
new:
local procedure OnAfterNavigateShowRecords(TableID: Integer; DocNoFilter: Text; PostingDateFilter: Text; ItemTrackingSearch: Boolean; var TempDocumentEntry: Record "Document Entry" temporary; SalesInvoiceHeader: Record "Sales Invoice Header"; SalesCrMemoHeader: Record "Sales Cr.Memo Header"; PurchInvHeader: Record "Purch. Inv. Header"; PurchCrMemoHdr: Record "Purch. Cr. Memo Hdr."; ServiceInvoiceHeader: Record "Service Invoice Header"; ServiceCrMemoHeader: Record "Service Cr.Memo Header";ContactType: Enum "Navigate Contact Type"; ContactNo: Code[250]; ExtDocNo: Code[250];);
or another possibility to get the three parameters  ContactType: Enum "Navigate Contact Type"; ContactNo: Code[250]; ExtDocNo: Code[250];
at OnAfterNavigateShowRecords, maybe with the pagesender as get-procedure, because OnAfterNavigateShowRecords already delivers the page navigate as includesender=true

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Scroll region to utilize in page navigation to persist scroll position of a div element

Describe the problem
While redirecting to the previous page, the default page scrollTo takes care of persisting the scroll position of that page and the scrolling is happening on the window object. but in my case, the entire page is inside a div and that div has overflow-y auto. that means the window scrolling will not work for me to persist the page scroll position.
Describe the proposed solution
It would be better if we had a scroll-region option where we could set the div element to scroll on-page navigation.
I'm not sure if this is implemented currently in Svelte-kit, but in InertiaJs it's implemented where it uses Svelte.
REF: https://inertiajs.com/scroll-management
Alternatives considered
No response
Importance
i cannot use SvelteKit without it
Additional Information
No response

See https://github.com/sveltejs/kit/pull/8723#issuecomment-1423522635 for a workaround. Closing this as a duplicate of https://github.com/sveltejs/kit/issues/2733


Can not train nerfacto-big

When I run the command ns-train nerfacto-big --data xxxx, it shows
Argument {nerfacto,instant-ngp,mipnerf,semantic-nerfw,vanilla-nerf,tensorf}: │
│ invalid choice: 'nerfacto-big' (choose from 'nerfacto', 'instant-ngp',       │
│ 'mipnerf', 'semantic-nerfw', 'vanilla-nerf', 'tensorf')

But when I change nerfacto-big back to nerfacto, everything is right.

Hi! Can you confirm which version/commit of nerfstudio you're on?

Hi! Can you confirm which version/commit of nerfstudio you're on?

Sure. My system is Centos7 and the nerfacto version is 0.1.8. It seems that nerfacto could not be updated to the latest version because open3d>=0.16 is not supported in Centos7.

Hm, maybe try Python 3.9 or 3.10? Alternatively, you can try installing from source with open3d removed from the dependencies for now, it's not critical for most operations.

Thanks. I force to install nerfstudio==1.0.0 without open3d>=0.16.0. It works well now!


How to get my video to export to the specified path?

I'm new to nexrender and still figuring everything out - so I could be missing something.
I was able to figure out how to successfully render a job using a json file thanks to the videos online and one of the posts that mentioned to use the method here to get terminal to be able to complete the job. (using ./nexrender-cli-macos --file myjob.json
my issue is the encoded video is not actually exported to the specified path in the json. It exports to folders within the private folder in the sequence below - and each export seems to make a separate random folder in this similar format.
/private/var/folders/0r/zqg_yk4s50v7pk687jqrcw5m0000gn/T/nexrender/9HL5ksYJ9a_vJHSio_rp7/encoded.mp4
What can I do to get the video to actually export to the specified export path in the json file?

You will need to use the copy action to copy the rendered file to your desired location.

Thank you for your response - I was using the copy action based on the instructions on that link.
I seem to have been able to have gotten it to work. I changed the format from "output": "d:/mydocuments/results/myresult.mp4" to just "output": "d:/mydocuments/results and it is outputting the correct folder now, where it did not before.
Glad to get it working, but is that the intended format / behavior? Just curious. Thanks for your time!

How did it not work with "output": "d:/mydocuments/results/myresult.mp4"? Did it error? Did it not copy anything? Did it do something else unexpected?


Browser is not detected on Alpine

FROM php:8.1-alpine
WORKDIR /app
RUN apk add libzip-dev $PHPIZE_DEPS
RUN pecl install xdebug && docker-php-ext-enable xdebug
RUN docker-php-ext-install bcmath zip

COPY --from=phpbuild /app/vendor /app/vendor
COPY --from=jsbuild /app/public/build /app/public/build

# Chromium and ChromeDriver
ENV PANTHER_NO_SANDBOX 1
# Not mandatory, but recommended
ENV PANTHER_CHROME_ARGUMENTS='--disable-dev-shm-usage'
RUN apk add --no-cache chromium

CMD tail -f /dev/null

Browser will be installed as chromium-browser not chromium.
Adding ln -s $(which chromium-browser) /usr/bin/chromium after install fixes the issue

Hi @oleg-andreyev, thanks for the report!
BDI is currently not that smart about finding the executable path of the browser: https://github.com/dbrekelmans/browser-driver-installer/blob/main/src/Browser/Chromium/PathResolver.php.
There is an option you can pass to the command with a custom path to the executable (so you wouldn't have to rename/symlink it on your system): https://github.com/dbrekelmans/browser-driver-installer/blob/main/src/Command/BrowserCommand.php#L75
Feel free to open a PR that adds this specific support for the default chromium-browser name on alpine! Let me know if you need any pointers on that.

Hi @oleg-andreyev, did this solve your issue?


Unable to authenticate, need: Basic realm="GitHub"

Hiya!
Trying to install the package from npm and getting an authentication error.  Looks like this has been an issue in the past with repos that have always-auth as ours does.
npm ERR! code E401
npm ERR! Unable to authenticate, need: Basic realm="GitHub"

https://github.com/Cox-Automotive/alks-cli/pull/144
https://github.com/Cox-Automotive/alks-cli/pull/121
absolute dependency still exists in package.json
https://github.com/Cox-Automotive/alks-cli/blob/master/package.json#L44
Thanks!

@aaron-seitz no, per my PR this is an issue with using always-auth=true (required for private registries that need auth on GETs) and having a generic URL as a dependency.  If you use the shorthand for GitHub URLs, installs work perfectly.
If a GitHub dependency of the form Cox-Automotive/clortho#1.2.3 is causing issues with the build system, you can try using git+https://github.com/Cox-Automotive/clortho#1.2.3 to force downloading with https.  Either way is perfectly valid syntax, and the build system should support it.
This has prevented us from updating alks-cli past version 3.0.5.

I am trying to install the alks-cli on node v13.12.0 (nodejs stable), I am also getting the error message
Unable to authenticate, need: Basic realm="GitHub"
Is the alks-cli not compatible with node 13??

@rsturim The error you're seeing is a permissions error, not related to node version compatibility. If you have any custom npm registries defined, try commenting them out temporarily while you install alks-cli.

@rsturim we've also seen this issue recently, specifically here, where the issue ended up being that there are more than 1 alks instances found. Using the command which alks to find if there are more than one can help resolve this issue.

I'm running in to this issue as well. My naive assumption is that one could setup a custom registry and then npm would check that first and the standard registry if the package is not foundf. Certainly there must be a solution to allow for both custom and default registry that isn't "swap your .npmrc whenever you use npm"?

I'm running in to this issue as well. My naive assumption is that one could setup a custom registry and then npm would check that first and the standard registry if the package is not foundf. Certainly there must be a solution to allow for both custom and default registry that isn't "swap your .npmrc whenever you use npm"?

so I have the same issue. Reading into node docs I suggest creating different profiles and using npmrc to swap between company and public profiles. https://docs.npmjs.com/configuring-your-registry-settings-as-an-npm-enterprise-user

I'm experiencing the same issue with a different repo and it is rather frustrating to swap npmrc files.  There needs to be a better way of doing this.

Count me in on this issue. By switching to always-auth=false in .npmrc, I got past it. Would be nice to not have to remember to do that every time I upgrade alks.

This issue should be resolved for all users in versions 3.2.5 and up now that PR #191 has been deployed since we're no longer using github URLs for the clortho dependency. Please open another issue if any other issues occur as a result of this change


case query modification

case search query changes

Summary by CodeRabbit

New Features

Enhanced SQL query construction for case management, improving clarity and flexibility.
Introduced new methods for pagination and dynamic query building.

Bug Fixes

Updated database column references in data extraction to align with the new schema, reducing errors.

Tests

Refined test cases to reflect updated SQL query structures and column names, ensuring accuracy and consistency.

changes are not required


should support how to extend the base box with Chef on specific projects

Each specific projects have different requirements for configuration management.
The first step is to make sure teracy-dev is minimal enough for other projects to extend the VM by their needs.
Chef is our initial attempt, others will follow.
Need to upgrade the workflow of Chef.

related #166

verified


[Question] Support with relation model

Hi @alanhoff,
I have a problem when try to soft delete with related model. Is it package support for related model?
Below is my model.
Question Model
'use strict';

const Answer = require('./Answer');

bookshelf.plugin(require('bookshelf-paranoia'));

module.exports = bookshelf.Model.extend({
    tableName: 'questions',
    hasTimestamps: true,
    sofDelete: true,

    answer: function() {
        return this.hasMany(Question, 'question');
    },
});

Answer Model
'use strict';

const Question = require('./Question');

bookshelf.plugin(require('bookshelf-paranoia'));

module.exports = bookshelf.Model.extend({
    tableName: 'answers',
    hasTimestamps: true,
    sofDelete: true,

    question: function() {
        return this.belongsTo(Question, 'question');
    },
});

So, I want when the question was deleted, automatically answers are delete too.
Sorry for my bad english :)
Thanks!

@alimustofa sorry for the delayed response. We do not currently support deleting related models.
It would be fairly easy for you to do that. Checkout this issue to see some suggestions https://github.com/tgriesser/bookshelf/issues/135


[Bug] Parity round-trip is broken

Component
primitives
What version of Alloy are you on?
No response
Operating System
None
Describe the bug
Parity to_parity_bool was backwards for EIP-155 V values.
noted in https://github.com/alloy-rs/alloy/issues/144#issuecomment-1906720337

closed by #497?

yes


UserData should have a Blob shape

As far as I can tell RunInstances.userData (and probably other cases) needs to be base64 encoded and (I think) therefore should have a shape of "Blob"? An example of a base64 encoded member that does have Blob is PublicKeyMaterial.
I'm happy to raise a PR to fix the json, but it sounds like it's better to raise an issue. Thanks in advance.

@charleso
Yeah you are correct about the userData parameter needing to be modeled as a blob. To compensate, we actually have a handler: https://github.com/boto/botocore/blob/develop/botocore/handlers.py#L383 that will base64 encode the user data for you. Are you seeing the data not getting base64 encoded from your side?
Otherwise thanks for the offer to fix it.

https://github.com/boto/botocore/pull/522

As I mention in my comment for https://github.com/boto/botocore/pull/522, we will look into updating the upstream source to use blobs as opposed to strings to model UserData.

@kyleknap No worries. I misinterpreted the "thanks for the offer" part of your message. :) Apologies for the noise.

Closing out issue as per @kyleknap comment


Fixed Issue 13965 - More handy schwartzSort

The goal is to be able to specify a SwapStrategy without also explicitly specifying the predicate to sort by (see example in the ticket, changelog, or the test I added).

Someone else feel free to merge earlier.


[Event Request] Codeunit 5520 - OnAfterInsertProdOrderCompLine

Hi, would it be possible to get an event OnAfterInsertProdOrderCompLine in codeunit 5520, like this

 local procedure GetUnplannedProdOrderComp(var UnplannedDemand: Record "Unplanned Demand")
    var
        NeedInsertUnplannedDemand: Boolean;
    begin
        OnBeforeGetUnplannedProdOrderComp(UnplannedDemand, ProdOrderComp);

        with UnplannedDemand do
            if ProdOrderComp.FindSet() then
                repeat
                    UpdateWindow;
                    DemandQtyBase := GetProdOrderCompNeededQty(ProdOrderComp);
                    if DemandQtyBase > 0 then begin
                        NeedInsertUnplannedDemand :=
                            not ((ProdOrderComp.Status.AsInteger() = "Demand SubType") and
                            (ProdOrderComp."Prod. Order No." = "Demand Order No."));
                        OnGetUnplannedProdOrderCompOnAfterCalcNeedInsertUnplannedDemand(UnplannedDemand, ProdOrderComp, NeedInsertUnplannedDemand);
                        if NeedInsertUnplannedDemand then
                            InsertUnplannedDemand(
                                UnplannedDemand, "Demand Type"::Production,
                                ProdOrderComp.Status.AsInteger(), ProdOrderComp."Prod. Order No.", ProdOrderComp.Status.AsInteger());
                        InsertProdOrderCompLine(UnplannedDemand);
                        OnAfterInsertProdOrderCompLine(UnplannedDemand,ProdOrderComp);
                    end;
                until ProdOrderComp.Next() = 0;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterInsertProdOrderCompLine(var UnplannedDemand: Record "Unplanned Demand"; ProdOrderComponent: Record "Prod. Order Component")
    begin
    end;

?
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Question: What is the plan for plugin support?

Is it possible to provide backwards compat with pylint plugins, for example?
I had written one, but I do find pylint to be very slow (not just my plugin :) ), so would be happy to migrate to faster option.

Ruff will almost certainly support plugins. I'm not certain when, but it's very important :)
I don't expect pylint (or Flake8) plugins to work out-of-the-box; instead, there'll be a separate plugin API to implement for Ruff specifically. I'm hoping that users will be able to write plugins in Rust or Python.
If your plugin is generic and/or OSS, I'm also happy to see if I can include those rules in Ruff directly, if it's helpful for you!

Thank you. Ours is very context-specific.
OK. Supporting Python would definitely make it more feasible for us to adopt. 👍🏻

Closing this for now in favor of #283.


Update reqcontext.rst

Fixing a grammar error.

fixes #

This is just a typo correction.
Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

"an appcontext" is correct

"an AppContext" is correct

The way it displays shows up as ‘an The AppContext’
On Tue, Sep 21, 2021 at 4:17 PM David Lord @.***> wrote:

"an AppContext" is correct
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pallets/flask/pull/4267#issuecomment-924456529, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW7FSZZRKMTG53GMXJZBJ3UDEG7LANCNFSM5EP3PKXA
.

--
All Good Things,
Seth Rutner

Oh I see the one you were referring to now. Looks like there's a few other links with that issue, please address those as well.

I went through and fixed all the other uses of app and request context.


Images import and export

Prerequisites
Versions

PHP version: 7.1
Laravel version: 5.7.24
Package version: 2.1

Description
Is it possible to save pictures in your package when reading an Excel file? And also when exporting Excel file using a blade form. Ty =)

You should use version 3.1 of Laravel Excel. Older versions are no longer supported.
Are you sure you're using 2.1?

@GlennM Yes. I use 2.1 but I could not find in the documentation can this version work with pictures in Excel.
This version suits me because it supports styles for Excel in the blade. From what I understand, 3.1 it is not able.
I need to parse like this example. Save pictures to my server. Edit this data and then use the blade form to create a new Excel document in the same format with my pictures.

Some basic style is supported. Please refer to https://docs.laravel-excel.com/3.1/exports/extending.html#customize
Styling via CSS is no longer supported. See https://github.com/Maatwebsite/Laravel-Excel/issues/1580#issuecomment-375699913

@GlennM
 $event->sheet->styleCells(                     'B2:G8',
I don't know in advance which columns and rows I need to format. I have a dynamically generated table.
Is it possible to do this in the blade itself?
And I'm more interested in importing and exporting images.

3.2 will have support for blade styling again. We are waiting on the new phpspreadsheet release.

Okey, ty ✌
What about importing and exporting images?

Images in blade views is also added to the new phpspreadsheet code.

Okey, ty v
What about importing and exporting images?

did you find any method? I am searching but can't find any proper method to import images from excel to the collection.

I need to import this excel file with company image.
Any solution to import with image?

"maatwebsite/excel": "^3.1",
I used this version.
`namespace App\Imports;
use App\Offer;
use Maatwebsite\Excel\Concerns\ToModel;
use Maatwebsite\Excel\Concerns\WithStartRow;
use Maatwebsite\Excel\Concerns\WithHeadingRow;
class OffersImport implements ToModel, WithStartRow
{
/**
* @param array $row
*
* @return \Illuminate\Database\Eloquent\Model|null
*/
public function startRow(): int{
return 3;
}
// public function headingRow(): int
// {
//     return 2;
// }
public function model(array $row)
{
    // dd($row);

    return new Offer([
        'image' =>  $row[0],
        'company_name' => $row['1'],
        'price' => $row[2] ,
        'price_b' => $row[3],
        'size' => $row[4],
        'size_m' => $row[5],
        'buy' => $row[6],
        'indicative_structure' => $row[7],
        'website' => $row[8],
        'date' => $row[9],
        'market_data' => $row[10],
        'pitch_deck' => $row[11],
        'status' => '1',
        'type' => '1',
        'user_id' =>auth()->user()->id

    ]);
}

}`


Return undefined when unable to get bundle in getResource

Returns undefined when there is no bundle so that the language and key don't come back as a valid lookup when resolving the key. (Note: This change is the equivalent to line 381 in i18next.js of the i18next library)

published in<EMAIL_ADDRESS>


Add SurfaceProducer.onSurfaceCleanup, deprecate onSurfaceDestroyed.

Closes https://github.com/flutter/flutter/issues/160933.
The timing of this callback gives our users (and plugin authors) a chance to stop using the Surface before it becomes invalid, allowing us to fix https://github.com/flutter/flutter/issues/156488 - we no longer need to do shenanigans on storing and restoring state because ExoPlayer can now handle it out of the box; see https://github.com/flutter/flutter/issues/160933#issuecomment-2564092567.
It's unfortunate we have to go through a bit of churn on the callback API, but realistically this is the feedback we were looking for when originally creating it - it just took longer than expected due to the long release cycle.
/cc @hasali19, @xxoo, @camsim99

Thanks. I'm glad to see this change. Although I'm confused as to why it happened this time. Did something else change since #152839 was closed that made it more necessary?

Another user filed a bug report with more details, so I understand the issue being presented now.


Collect CloudVolumes and AvailabilityZones

The list_boot_volumes API call required the availability zone name so I also added availability zones here even though they don't seem related to storage

Backported to morphy in commit 1bc4314305a569f7ee92444470dfa2e78ad7967f.
commit 1bc4314305a569f7ee92444470dfa2e78ad7967f
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Tue Mar 2 16:18:37 2021 -0500

    Merge pull request #8 from agrare/storage_refresh

    Collect CloudVolumes and AvailabilityZones

    (cherry picked from commit 592af66e692b5e71e2aaee3c938f9b190c973878)


Blocking error in Synthesis

Program.cs(283,55): error CS1061: 'INpcGetter' does not contain a definition for 'ContainedFormLinks' and no accessible extension method 'ContainedFormLinks' accepting a first argument of type 'INpcGetter' could be found (are you missing a using directive or an assembly reference?)

This happened to me too on the newest 0.24 version of synthesis. Downgrading to my previous version of 0.20.5 and it runs.

@Jumu3668 wow thanks for the tip!


polish the document

See the issues #423

Fixed via 575fb31

Hi @ryanjbaxter
Thanks for your update, one more thing I want to ask. I see this commit(it only include how to create BackOffPolicy but not say how to create RetryListener and LoadBalancedRetryPolicy)
On the other hand I found this section we also should modify
http://cloud.spring.io/spring-cloud-static/Finchley.RELEASE/single/spring-cloud.html#_retrying_failed_requests
It's make sense ?
Thanks again

Thanks.  We could add some documentation about how to create a RetryListener but that was not what this bug was about.
We also need to correct the documentation about backoff policies here http://cloud.spring.io/spring-cloud-static/Finchley.SR1/single/spring-cloud.html#_backoff_policies.  I submitted a quick fix for that here https://github.com/spring-cloud/spring-cloud-netflix/commit/70008f771733b8ad38465f69c6b877c15786176e


Add C shell

Adding a language
See https://github.com/Mozilla-Campus-Club-IIT/Hello-World-Collection/blob/master/collection/C_shell_saidHello.csh

[x] The code displays "Hello World"
[x] I have updated the readme to include the new language
[ ] I have incremented the language count in the readme

All ready done


Fix commands to invoke run-tests.sh

Invoke the script directly, with optional applicable pytest aruments such as
v1, -x

good catch, thanks!


Update CodeQL to latest best practices

Which problem is this PR solving?
CodeQL Performance
Short description of the changes
👋🏻  Your current CodeQL workflow is using a slightly older template. Please consider the PR below which will parallelize the jobs and analyze both languages at the same time. Should speed you up a bunch.

I am still confused by this GH action. Where are the results? The logs show
Uploading sarif files: ["/home/runner/work/jaeger/results/go-builtin.sarif"]
Uploading results
Successfully uploaded results

Where does it upload results?

Where does it upload results?

The upload goes to the GitHub SARIF API, which is how we are able to process the results into actionable alerts displayed in the security tab.


Remove the Python console

This issue describes our reasons to remove the Python console from Spyder:

Broken on Windows: Executing code on it usually doesn't return the prompt. The situation is worst when Matplotlib integration is turned on because you have to press Enter several times to get a prompt back.
Matplotlib integration: Nowadays Matplotlib is tightly integrated with IPython and it's very difficult to have a different console with good Matplotlib support. Right now the only backend we are able to support in our Python consoles is the Qt one (not even Tk works!), and (as said above) it's broken on Windows.
Different implementations: We are a small project and don't have the resources nor the time to maintain two consoles with very different implementations (we're also in charge of qtconsole).
Debugging: It's not possible to detect when a Python console is running a debugging session, so we can't adapt certain functionality for debugging only (e.g. disabling buttons on the Debug toolbar).
Besides, we plan to improve debugging in Spyder 4 by creating an IPbd kernel, so that users can run multiline code from the Editor, have code completion and history browsing while debugging. Unfortunately, this is something we can't support in the Python console.
History log: The history log is semi-broken because we can't make it work reliably for both consoles.
Not testable: It's not easy to add tests for the Python console because you can't tell for sure when the console is up and ready nor when it has finished a computation. That's why there are no tests for it right now.

TODO:

[x] Remove connection with the Variable Explorer - PR #4525.
[x] Remove connection with Help - PR #4533.
[x] Remove connection with the Editor - PR #4541.
[x] Remove connections with the rest of plugins - PR #4549.
[ ] Clean sitecustomize.py.
[x] Don't check for the presence of the IPython console (i.e. make it mandatory instead of optional) - PR #4541.
[ ] Remove text about the Python console in the Run options dialog.
[ ] Fix add_pathlist_to_PYTHONPATH.
[ ] Add Execute in a dedicated console option to the IPython console.
[x] Add Environment Variables and sys.path contents entries to the IPython console - PR #4562.

Will "Add Execute in a dedicated console option to the IPython console." once implemented still resolve issues like
https://stackoverflow.com/questions/38042329/python-kivy-app-running-only-once
?

Yes, I think so because the kernel will be restarted every time on a dedicated console.


API Behaviour different between Desktop and Server

Hi devTeam!
I notice unexpected behaviour in Tableau Desktop compared to Tableau Server.
Our customer is using Dashboard Usage Extensions to monitor filter actions in dashboards. There is a action filter from Dashboard A to Dashboard B. This is working on Desktop which is unexpected but really handy because this action is really important to register.
On Tableau Server though this is not working. When switching to dashboard B no actions are registered. I also tried to add a parameter action and highlight action on the same sheet in Dashboard A besides the filter action (which switches between dashboards). But those events are also not working.
Best workaround for now is to use a filter action in Dashboard A which filters a hidden sheet to register the click. And a menu action to switch to Dashboard B.
Do you have ideas? Is this actually a 'bug' in Tableau Desktops Engine?

The good news is that this is related to https://github.com/tableau/extensions-api/issues/143. We have fixed several event notification issues that will be part of 2019.3. In general events will be more reliable for multiple extensions, and also be sent on undo/redo.
Let me see if I understand the setup for this issue. I have a workbook where I have:
Dashboard A, contains extension 1 listening to filter events for worksheet 1
Dashboard B, contains extension 2 listening to filter events for worksheet 1
Also on Dashboard A, there is a filter action on select that applies to Dashboard B (and navigates to Dashboard B).

On server, you do not get a filter changed notification on Dashboard B.
The reason I say sometimes, is that if you have never visited Dashboard B, then the listener is not set up, so when the action takes you to Dashboard B, the extension 2 is initialized. Once you have visited Dashboard B, then any future filter action will trigger the filter changed in Dashboard B also.
In server, the extension is initialized every time you visit Dashboard B, so you never get the notification. However, you should get the updated value when you query the filter after initialization.
Does this represent your setup, and answer you question? There is no filter notification for changed events that happen before initializeAsync.
Let me know if I missed your setup.
Thanks,
John

Thanks for your reply!
This is the use case:

In this example: we want to track the click on a State with Dashboard Usage. But we can't capture the event because we leave Dashboard A and go to Dashboard B. The extension on Dashboard B is not initialized yet and Dashboard A is not capturing anymore because we left it.
We tried several things such as a hidden sheet, hover action + click action and a extra button. Not working or a bad user experience.
Hope this helps!

Hi @johnDance
You may have to re-open this ticket/issue since Tableau Server (Tableau Online) does not register the dashboard action when you use the GoTo Dashboard action before it redirects to the new dashboard/sheet. We store the event of the dashboard action but it never gets stored because the GoTo action will have the user leave the dashboard and the extension does not get the important event of the dashboard action.
I can confirm it works in Tableau Desktop (2019.3 and higher) but on tableau Server the registration of the selection doe snot take place. I tested in all versions up to 2020.2 (Tableau Online) and i cannot get the dashboard action to be registered before the GoTo sheet/dashboard action will redirect to the new dashboard/sheet.
This is an urgent issue for us since one of our clients has indicated not to continue their subscription on the extension if this will not be fixed.

Copied from: https://github.com/tableau/extensions-api/issues/335
We will use this thread for discussion and follow-up.
Hi @SiebeG
Sorry for the delay. I was out of the office. Just to confirm... you register for selection events. You have a selection action that is a GoTo Sheet action. When you make the selection, the GoTo Sheet action fires before the extension gets notified of the selection. Do I have your scenario correct? What type of work is the extension doing as part of the selection notification?
Please confirm, and we will look into the issue.
Thank you,
John

Hi @johnDance
That is a correct interpretation of the issue. It malfunctions on Tableau Server / Tableau Online. When I use the GoTo action in Tableau Desktop the registration of the selection is registered before the goto action is executed.
The extension monitors user interactions (with filters, parameters, mark selections and dashboard actions) in the dashboard. It is important to know what selection a user clicks to trigger the GoTo action.  With the selection we can set a filter on the target dashboard but without the registration of the selection we never know what selection the user made in the originating dashboard.

Hello @SiebeG
I just wanted to give you an update. We have determined the root cause of this problem. It is in the server command handling outside of extensions. Our team is in communication with the server team and we are discussing how to fix this. We will update you again as we get more information.
Thanks,
John

Hi @johnDance
Thank you very much for investigating this issue and exposing the cause of the issue. Is there any time schedule to expect a solution?
Regards
Siebe

Hi @johnDance and @benlower is this fix already scheduled to be part of a release? Thanx in advance!
regards Siebe

Hi @johnDance thank you for fixing the 10K bug it appears to be working in desktop/server 2020.2.4 and online 2020.3. Ddi you also address this issue with the listening to events on Tableau Server?
_

Hello @SiebeG
I just wanted to give you an update. We have determined the root cause of this problem. It is in the server command handling outside of extensions. Our team is in communication with the server team and we are discussing how to fix this. We will update you again as we get more information.
Thanks,
John

_

@SiebeG - Sorry for the slow reply. I thought another team member had replied to you. We have hit a roadblock on handling the event in server. The architecture of how the page navigation works doesn't allow us to catch this event in a reliable manner before the current page is torn down. We don't have any great ideas on how to fix it. My best idea would be for the extension API to have a GoToSheet command (which has been a previous request), and then it could register the current selection and then fire the actual go to sheet command.
John

@johnDance I am very sorry to hear that. The strange thing is that you do manage the event in Tableau Desktop but not on Server/Online.
Can you already provide a planning/roadmap for expanding the Extensions API with a "GotToSheet" command?

@SiebeG - Sorry this got buried in my inbox, and I am just digging out. We are doing a lot of work with our integration with Salesforce and Einstein Discovery that was just demonstrated at TC20. I'm pushing to get GoToSheet in the 2021 plan.
John

Thank you for following up. I noticed the Einstein integration, this helps boost the use of extensions! Please let me know the expected date for integrating the GoTo sheet event in the Extensions API. This would really help a lot in navigating the dashboards.


Add schedule to perf-test job for openseach

Signed-off-by: Kunal Kotwani<EMAIL_ADDRESS>Description

Move CRON configuration from jenkins job to jenkinsfile

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2367 (67b216b) into main (ffe2328) will increase coverage by 5.38%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2367      +/-   ##
=============================================
+ Coverage     94.61%   100.00%   +5.38%
=============================================
  Files           209         6     -203
  Lines          4309       105    -4204
  Branches         29        19      -10
=============================================
- Hits           4077       105    -3972
+ Misses          226         0     -226
+ Partials          6         0       -6

Impacted Files
Coverage Δ

...PromoteArtifacts_OpenSearch_Dashboards_Jenkinsfile

src/manifests/build/build_manifest_1_0.py

src/jenkins/BundleManifest.groovy

src/test_workflow/perf_test/perf_args.py

src/manifests/bundle/bundle_manifest_1_0.py

...orkflow/integ_test/integ_test_runner_opensearch.py

src/assemble_workflow/bundle_opensearch.py

src/test_workflow/integ_test/local_test_cluster.py

src/test_workflow/bwc_test/bwc_test_runners.py

src/sign_workflow/signers.py

... and 193 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


where to put NA?

@amromeo If we don't have it in somewhere yet, I could make sure I include in stats. But, is there missing data in orders data?

the orders data has NA's in the cancel reason column and in some of the review times I think. So far I will mention in it in mind as I discuss is.na(), but I may choose to exclude this since mine might be too long as is


RUN-1392: fix events recorder crashes

Fix events.

-> 95 TestPassed vs. 6 TextFailed

https://github.com/replayio/build-test-dashboard/blob/master/06c174ff-3dc7-4362-aef4-eb4da45bd337

https://linear.app/replay/issue/RUN-1392/fix-events-recorder-crashes

It looks like UserEventProbe::~UserEventProbe needs to be fixed too.

@bhackett1024, ouch - not sure how I overlooked that. On it.

After my latest changes, I ran another test and got 14 TestFailed but 0 recorder crashes (see here). Merging.


Add a date picker for the licenses breakdown

This PR adds a data picker for the horizontal chart for showing licenses across datasets.
I first tried to use shadcn ui components, but I ended up with Tremor's date picker. I tried minimizing adding dependency. The new dependency for this PR is "data-fns"
Fixes #2

I checked the deployed app on mobile.
The data range picker is too wide, which turns on the horizontal axis scrolling, which I don't like.
https://github.com/nsunami/tue-rdm-dashboard-rw/assets/17035406/929dad75-eca4-4de5-b210-934e313c5356
The date picker UI is handled by Tremor, which is difficult to override.
One option is to write our own component for the data picker so that we have full control.
⏭ I will try writing own data picker (using shadcn)

I fixed the horizontal scroll issue by using a combination of chadcn/ui components.
https://github.com/nsunami/tue-rdm-dashboard-rw/assets/17035406/8b9626b6-04b5-4690-b1c8-02e829372375


Javascript implement runtime variables

Ensure the following runtime variables are all handled correctly. Currently outdir is implemented for Step class extractArguments method.
runtime.outdir: an absolute path to the designated output directory
runtime.tmpdir: an absolute path to the designated temporary directory
runtime.cores: number of CPU cores reserved for the tool process
runtime.ram: amount of RAM in mebibytes (2**20) reserved for the tool process
runtime.outdirSize: reserved storage space available in the designated output directory
runtime.tmpdirSize: reserved storage space available in the designated temporary directory

these have been implemented and should parse correctly now.


[MIST-1093] Fix closed MQTT connection

This PR resolves #1093 by

trying reconnection to MQTT broker when MQTT client is closed

LGTM. I will merge this PR.


Fix docker-compose

moved the directories to 'instrumented' that the docker-compose file expects to be there

tons of credit to @twunderlich-grapl for independently finding and providing a fix. @twunderlich-grapl we need these directories nested under the instrumented directory. the instrumented directory has it's own copy. This whole layout could probably use some rethinking.