Update a resource with relationships

I followed the example described in the readme to create a resource with attached relationships, and it works well.
The doc said that we could do the same on update but it doesn't seem to work.
Looking more closely, I think that we should add $data in get method from PatchResource and PutResource :
    public function get($id, array $data, $className, callable $findOneCallable, callable $update)
    {
        try {
            DataObject::assertPut($data, $this->serializer, $className, $this->errorBag);

            $model = $findOneCallable();

            if (empty($model)) {
                $mapping = $this->serializer->getTransformer()->getMappingByClassName($className);

                return $this->resourceNotFound(new ErrorBag([new NotFoundError($mapping->getClassAlias(), $id)]));
            }
            $values = DataObject::getAttributes($data, $this->serializer);
            $update($model, $data, $values, $this->errorBag);

            $response = $this->resourceUpdated($this->serializer->serialize($model));
        } catch (Exception $e) {
            $response = $this->getErrorResponse($e);
        }

        return $response;
    }

And of course add the same on JsonApiTrait:
    protected function updateResourceCallable()
    {
        return function (Model $model, $data, array $values, ErrorBag $errorBag) {
            foreach ($values as $attribute => $value) {
                $model->$attribute = $value;
            }
            try {
                $model->update();
            } catch (\Exception $e) {
                $errorBag[] = new Error('update_failed', 'Could not update resource.');
                throw $e;
            }
        };
    }

With this we can access $data in updateResourceCallable like in createResourceCallable, and we can access relationships.
What do you think about it ? I will make a PR later.

Can you provide a test too? I'm willing to merge this PR :)

Which test case am I supposed to do ? I did not see any case for update in JsonApiControllerTest.php.
Other point: I will also need to make a PR on https://github.com/nilportugues/php-json-api as PatchResource.php and PutResource.php are parts of this package :)

Write a new one @alexjoffroy. Provide one where you actually access to $data in updateResourceCallable :)

OK. I'll do it as soon as possible !


About page does not load

I think I followed the instructions correctly, as I do have the hello world post showing.
I then created an About page with slug about, but when I click on /about i still get the main blog list. Note that I am using multisite, and the page is to be found at http://localhost/<newwork_name>/about/, although I can't see why that would mess up wp-json if other posts show.

I am also unable to get the about page to load. Seems like a routing problem.
I am able to pull in a list of posts from an external website using wp-url.js
Any fix for this?

Same error is there a fix for this?

Make sure you are putting the dynamic routes after the about route.


[master] Review public methods in core and make private where required

As a rule we'd like to expose as many api's as possible. However if we know an api will be refactored, we'd rather not make them public for now.  The task here is to review access levels across classes.
Review and make changes based on the following criteria:

what is meant to be public, is public
what is not used outside of the class, make it private (with exceptions)
evaluate protected methods, make them private if there's no obvious need to extend the method or if the structure of the class isn't of great quality
consider what we expose in our public api's in our libraries... maybe not export entire classes in our public api e.g. ngrx (but tobias is going to think about that one) --- but if any other whole classes meet this criteria, discuss with tobias
feel free to be conservative. we can make methods public based on feedback from the community

List taken from: projects/core/public_api.ts
See tickets: https://github.com/SAP/cloud-commerce-spartacus-storefront/labels/public-api

We have this ticket https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/2514. So, when you pick up "api review" ticket, you can leave out occ for now.


added unbound generic type argument to Class in BeanNode and Lib

This change has been done in order to avoid compile time warnings.

Don't you want to fix the other warnings in the BeanNode.java file, too :) ?

Don't you want to fix the other warnings in the BeanNode.java file, too :) ?

I no longer know where this branch came from. The intention was just to share very small set of work. However, the number and variety of warnings which are not deprecation warnings is quite large in the class and project. Imo fixing them should probably occur once after a strict checkstyle and PMD setup is put in place which either NetBeans specialists can configure with the current build system or anyone after migrating to Maven (in case there're any plans). It's a separate issue/unit of work to be discussed (probably not here).

Is there any reason not to merge this? Any possible side effect, any problems that can be anticipated? Otherwise, will merge 24 hours from now.

Is there any reason not to merge this? Any possible side effect, any problems that can be anticipated? Otherwise, will merge 24 hours from now.

I can't think of anything. It might even be theoretically impossible that added unbound generics has any downside (I'm sure that was one of the design goals when generics where introduced).

Ping.

In general adding generics can pose problems for backwards compatibility, as it could change the method signature. In this case its generics inside one method, so it is safe.


Lint the generator with eslint

Use consistent rules with the rest of the repo.
Note that this required changing to babel's eslint parser to handle the async
functions in the generator tests.

@doug-wade 😁

lgtm ⛵ 👍


high score with empty document string

When qdrant is used for vector embedding indexing,  an empty document in the collection will obtain a high similarity score (strange).
Here we can observe that the empty document strange achieves "0.797" cosine similarity score.  If the document is empty, I assume that zero vector is used. cosine similarity score should be 0. Can you help ?
e.g.
from typing import List
import numpy as np
from qdrant_client import QdrantClient
documents: List[str] = [
"",
"email address",
"placeholder",
"",
"wireless customer",
"He died in 1597 at the age of 57",
"Maharana Pratap is considered a symbol of Rajput resistance against foreign rule",
"He had 11 wives and 17 sons, including Amar Singh I who succeeded him as ruler of Mewar",
"total active lines",
""
]
client = QdrantClient(":memory:")
client.set_model("BAAI/bge-small-en")
metadata = [ {"source": "docs"} for doc in documents]
ids = [ idx for idx in range(len(documents))]
client.add(
collection_name="demo_collection",
documents=documents,
metadata=metadata,
ids=ids
)
query = "Count the number of active residential customer"
search_result = client.query(
collection_name = "demo_collection",
query_text = query,
limit= 5)
print(search_result)
Results:
[QueryResponse(id=8, embedding=None, metadata={'document': 'total active lines', 'source': 'docs'}, document='total active lines', score=0.8843179222400359), QueryResponse(id=4, embedding=None, metadata={'document': 'wireless customer', 'source': 'docs'}, document='wireless customer', score=0.8295176016136243), QueryResponse(id=1, embedding=None, metadata={'document': 'email address', 'source': 'docs'}, document='email address', score=0.8228306079924803), QueryResponse(id=2, embedding=None, metadata={'document': 'placeholder', 'source': 'docs'}, document='placeholder', score=0.8144248465983718), QueryResponse(id=9, embedding=None, metadata={'document': '', 'source': 'docs'}, document='', score=0.7972171966992909)]

Hi @jdongca2003
I don't think that if the string is empty vector should be zero, it actually depends on the model you are using.
Could you please check whether you have a similar result with the original BAAI/bge-small-en model ? (What I mean is: take a model from huggingface, compute the embeddings manually for your documents and check whether the situation is the same)

Thank Joein for quick response. I checked embedding vector of empty document. It is not zero vector!  But it is still not a good behavior.

from typing import List
import numpy as np
from fastembed import TextEmbedding
import json
documents: List[str] = [
"",
"email address",
"placeholder",
"",
"wireless customer",
"He died in 1597 at the age of 57",
"Maharana Pratap is considered a symbol of Rajput resistance against foreign rule",
"He had 11 wives and 17 sons, including Amar Singh I who succeeded him as ruler of Mewar",
"total active lines",
""
]
embedding_model = TextEmbedding(model_name="BAAI/bge-small-en", max_length=512)
embeddings: List[np.ndarray] = list(
embedding_model.passage_embed(documents)
)  # notice that we are casting the generator to a list
#print(embeddings[0].shape, len(embeddings))
query = "Count the number of active residential customer"
query_embedding = list(embedding_model.query_embed(query))[0]
def print_top_k(query_embedding, embeddings, documents, k=5):
# use numpy to calculate the cosine similarity between the query and the documents
scores = np.dot(embeddings, query_embedding)
for score, doc in zip(scores, documents):
print(f'{doc}|score: {score}')
# sort the scores in descending order
sorted_scores = np.argsort(scores)[::-1]
# print the top 5
#for i in range(k):
#    print(f"score: {scores[sorted_scores[i]]} Rank {i+1}: {documents[sorted_scores[i]]}")
print_top_k(query_embedding, embeddings, documents, k=5)
I directly calculated cosine similarity score.
|score: 0.7972172498703003
email address|score: 0.8228306174278259
placeholder|score: 0.814424991607666
|score: 0.7972172498703003
wireless customer|score: 0.8295177221298218
He died in 1597 at the age of 57|score: 0.7157479524612427
Maharana Pratap is considered a symbol of Rajput resistance against foreign rule|score: 0.7073748111724854
He had 11 wives and 17 sons, including Amar Singh I who succeeded him as ruler of Mewar|score: 0.7003960609436035
dim = 384
[-2.53819916e-02 -5.44682052e-03 -5.09282853e-03 -1.49776395e-02
-1.08098146e-02  1.19938692e-02  1.92262717e-02  4.08581644e-02
-9.28279664e-03  1.56196468e-02  1.86153606e-03 -4.88135368e-02
6.96400367e-03  3.49483788e-02  3.50163616e-02  4.01080912e-03
3.18448767e-02  1.36998445e-02 -1.56665053e-02  1.64450370e-02
2.16239858e-02 -1.99406147e-02  1.17815230e-02 -1.80905703e-02
4.76054614e-03  2.72297114e-02 -5.90159511e-03 -8.18434451e-03
-4.85137738e-02 -1.91728160e-01 -3.33202034e-02 -1.37138087e-02
3.19078634e-03 -9.87244491e-03 -1.03822276e-02 -9.70588345e-03
-1.62116215e-02  1.38158510e-02 -1.09591316e-02  4.05766815e-02
2.16749441e-02  1.38471741e-02 -1.54241202e-02 -1.06100161e-02
5.69914840e-03 -2.26438437e-02 -1.67865120e-02 -6.69355411e-03
5.80454506e-02 -6.32909359e-03  2.05236953e-03  1.03720073e-02 ...

Could you elaborate on not a good behavior, what do you mean exactly?

I mean that a good scoring behavior is that a low score is for empty document when the query is a natural text.

Unfortunately, we can't do anything about this, Qdrant provides a way to operate with embeddings, it can't do anything with the embedding values.
Embedding values are determined by the model you've chosen.

Thank joein. Your clarification is very reasonable.


refactor(ast): remove duplicate TSNamedTupleMember representation

Removes duplicate representation of a TSTupleElement which is a TSNamedTupleMember.
Closes #3100.

#3101  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Unable to change the max_response_headers_kb using EnvoyFilter

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Trying to increase the Max header size of the response being sent back from the application, otherwise istio gives 503 because headers sizeif more than 64KB. This is as per the document in envoy https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/protocol.proto
trying to update the "max_response_headers_kb" but keep getting this error.
Envoy filter: can't unmarshal Any nested proto type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager: unknown field "max_response_headers_kb" in envoy.config.core.v3.Http1ProtocolOptions

`apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
name: http-header-count-size-control
annotations: {}
labels:
install.operator.istio.io/owning-resource: istio-operator
install.operator.istio.io/owning-resource-namespace: istio-system
operator.istio.io/managed: Reconcile
namespace: istio-system
spec:
workloadSelector:
labels:
app: my-app
configPatches:

applyTo: CLUSTER
match:
cluster:
context: SIDECAR_OUTBOUND
patch:
operation: MERGE
value:
"@type": type.googleapis.com/envoy.config.core.v2.HttpProtocolOptions
common_http_protocol_options:
max_response_headers_kb: 200
`

Version
./istioctl version
client version: 1.23.3
control plane version: 1.21.5
data plane version: 1.21.5 (64 proxies)

Client Version: v1.30.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.5-gke.1014001

Additional Information
No response

This envoyfilter is not indented well, and you donot need to set "@type": type.googleapis.com/envoy.config.core.v2.HttpProtocolOptions

Hi Zhonghu Xu
So sorry submitted the issue and realized the formatting was screwed up. Here is the updated on
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
 name: http-header-count-size-control
 annotations: {}
 labels:
  install.operator.istio.io/owning-resource: istio-operator
  install.operator.istio.io/owning-resource-namespace: istio-system
  operator.istio.io/managed: Reconcile
 namespace: istio-system
spec:
 workloadSelector:
  labels:
   app: my-app
 configPatches:
   - applyTo: CLUSTER
     match:
      cluster:
      context: SIDECAR_OUTBOUND
     patch:
      operation: MERGE
      value:
        "@type": type.googleapis.com/envoy.config.core.v2.HttpProtocolOptions
        common_http_protocol_options:
               max_response_headers_kb: 200

Ah, the istio 1.21 doesnot include max_response_headers_kb at all .  From https://github.com/envoyproxy/envoy/pull/36231, it is merged

aah Crap!! How do we get around this issue, disable the side car injection?

what is your use case to require such big header size? You can bump to istio 1.23 i guess

yeah not my call. the business need is to send so many headers. We'll upgrade to 1.23 and see if that resolves the issue

nah 1.23.1 does not solve this issue!! Same error message.

Then you can backport the patch and build your own proxy image

Closing this as this configiuration seems to be working on 1.24. Thanks a lot @hzxuzhonghu


[Feature][API] return the process instance id when create a process instance

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
how can i get the process instance id after start a new process instance?
/dolphinscheduler/projects/{projectCode}/executors/start-process-instance
i use this api to create, but it return just look like
{"code":0,"msg":"success","data":null,"failed":false,"success":true}
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@KevinJohn-GH  Could you tell me more details on how to use the process instance id for you.

@KevinJohn-GH Could you tell me more details on how to use the process instance id for you.

In my case， there is a external system which will  use api to create lots of process instances，and it need to know each process instance id to classify them。
For example，a “job” in my system will use api to create multi process instances，different “job” include different  process instances，so the “job” need  the process instance id return in order to know this process instance was created by this ”job“.
Thanks
@calvinjiang

Make sense. I think the feature would be very useful for you and the others. I'll deal with this feature. Thanks for your feedback.

@KevinJohn-GH I'm sorry to say that it's difficult to get the process instance id immediately when you start a new process. Because the process instance id is asynchronously generated by the component of Master. Maybe you could get the last running process instance id through the api like 'http://localhost:3000/dolphinscheduler/projects/3655870219936/process-instances?pageNo=1&pageSize=10&processDefineCode=4940490003842'.

@KevinJohn-GH I'm sorry to say that it's difficult to get the process instance id immediately when you start a new process. Because the process instance id is asynchronously generated by the component of Master. Maybe you could get the last running process instance id through the api like 'http://localhost:3000/dolphinscheduler/projects/3655870219936/process-instances?pageNo=1&pageSize=10&processDefineCode=4940490003842'.

What a pity，but thanks for your reply :)

@calvinjiang you can defineded a jobId request param, then translate jobId to Command Object, you asynchronously worker
then use Commond Object jobId write to t_ds_task_instance, so api user can query this task instance by jobId.
api user guaranteed to be unique.


Not working with every SVG for me!

Hi,
This is an awesome tool idea to work with SVG in React JS application, I was trying to convert by using it but somehow I'm getting an error message. This is my output component, hope you will give me an idea why its happening or fix the bug if it is.
Thank you for your initiative.

What's the error message?

Hi Thank you for your response, my error message screenshot is below.


certificates: allow reconfiguring cert validity for short lived certs

Description:
This change allows reconfiguring the validity period for short lived
certs. The validity period of such certs are no longer static, but
dynamically retrieved from the osm-config ConfigMap.
Additionally, the validity period at the time of certificate issuance
must be explicitly be specified to prevent issuing certs with wrong
validity.
Part of #1757

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [X]
Certificate Management [X]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #1799 into main will increase coverage by 0.03%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
+ Coverage   55.55%   55.58%   +0.03%
==========================================
  Files         125      125
  Lines        5166     5156      -10
==========================================
- Hits         2870     2866       -4
+ Misses       2294     2288       -6
  Partials        2        2

Impacted Files
Coverage Δ

cmd/osm-controller/certificates.go
30.00% <0.00%> (+0.42%)
:arrow_up:

cmd/osm-controller/osm-controller.go
26.49% <0.00%> (-0.14%)
:arrow_down:

pkg/certificate/providers/tresor/fake.go
35.29% <0.00%> (ø)

pkg/certificate/types.go
0.00% <ø> (ø)

pkg/injector/patch.go
10.16% <0.00%> (+0.08%)
:arrow_up:

pkg/injector/webhook.go
33.51% <0.00%> (+0.18%)
:arrow_up:

cmd/cli/install.go
63.70% <50.00%> (-0.21%)
:arrow_down:

...certificate/providers/vault/certificate_manager.go
50.63% <60.00%> (+1.25%)
:arrow_up:

...icate/providers/certmanager/certificate_manager.go
72.26% <90.90%> (-0.46%)
:arrow_down:

pkg/catalog/certificates.go
77.77% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95915a9...e7cc9f7. Read the comment docs.


MinhashDedup should use the language parameter

https://github.com/huggingface/datatrove/blob/1e27cc8819465d5246d89cd929423b76eb0bc5dd/src/datatrove/pipeline/dedup/minhash.py#L196

yes，because tokenizer will use it to select different language tokenizer

this has been addressed by having word_tokenizer be initialized based on the language


Add ability to specify output directory

Currently html-compiler always writes out to dist. Add the ability to specify a custom output directory.

Completed and merged to master


App won't see fonts with non-latin names

Hello! I've downloaded this Chinese font and installed it. Apps like Illustrator and Figma seeing it correctly, system fonts menu and classic Character Map also can find it. However this app can't, it's not in the list after app restart.
Here are font homepage and screenshot of what is happening after install:
https://www.freechinesefont.com/simplified-mini-jian-yi-hei-download/

FWIW, the app does recognise the font (you'll find it at the very bottom of the font list), but for some reason it's loading it with an incorrect / corrupted font name. Will have to investigate why.


Refactor hopla authorization

Currently, way too much code is used for something simple.
This has to do with the migration from bash.
Now we use a different config file format, for which python has a lot of support. Use that instead.

Marked it low-prio. It works as intended. And it nicely separated from the rest of the code base.

similar issue for config: https://github.com/melvio/hopla/issues/147


Consultant is cleared from banner after placing an order and should not be

Expected behavior
Consultant should remain in banner until the user either selects a different consultant or clears cookies.
Actual behavior
Consultant is being cleared from banner after order is placed.
Steps to reproduce behavior
Started with clean cookies
Added items to cart
Selected a consultant -CID #28
Went to cart
Verified cart notification table
Copied a closed party link in browser  - https://tastefully-simple-sandbox-2.mybigcommerce.com/p/10370585
Got the ‘darn party is over message’
Went to cart
Checked out

After placing the order, I clicked the TS logo to go back to the home page,  and my consultant is cleared from the header and should not be because I did not clear cookies.

Fixed order confirmation javascript. Business Sandbox and Prod had the correct version.

Retested. Fixed. :)


Support rollback_reason for global transaction

#292

Codecov Report

Merging #310 (f796e5c) into main (84ee15d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   97.14%   97.15%
=======================================
  Files          48       48
  Lines        2730     2739    +9
=======================================
+ Hits         2652     2661    +9
  Misses         48       48
  Partials       30       30

Impacted Files
Coverage Δ

dtmsvr/storage/trans.go
100.00% <ø> (ø)

dtmsvr/trans_status.go
92.81% <100.00%> (+0.44%)
:arrow_up:

dtmsvr/trans_type_tcc.go
88.88% <100.00%> (ø)

dtmsvr/trans_type_xa.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ee15d...f796e5c. Read the comment docs.

PR质量非常高，感谢！
Saga也有可能发生错误导致回滚，有空的时候帮忙看看，能否把saga的回滚原因也加上，当前这个PR我就县合并了


Not able to run this project

Tried running this :  cd pig/target/ambrose-pig-$VERSION-bin/ambrose-pig-$VERSION
AMBROSE_PORT=8080 ./bin/pig-ambrose -f script.pig
Getting this error :
Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2014-11-30 13:33:16,813 [main] ERROR org.apache.pig.Main - ERROR 2997: Encountered IOException. File script.pig does not exist
Details at logfile: /home/bismoy/Music/ambrose/pig/target/ambrose-pig-0.3.1-SNAPSHOT-bin/ambrose-pig-0.3.1-SNAPSHOT/bin/pig_1417334596354.log
[Shutdown] INFO org.mortbay.log - Shutdown hook executing

You are meant to run the above command on your own pig script. Running it on a non-existent script will produce the error you observed. This is expected behavior.


(OraklNode) Replace feed data buffer redis list to in memory channel

Description
Replace redis list into in memory channel
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Deployment

[ ] Should publish npm package
[ ] Should publish Docker image

@coderabbitai review


Add padding between link text and external-link Icon

In SETTINGS / ORGANIZATION PROFILE there is no space between link text and external-link Icon. for clean design is not looking good that's why I made some changes in CSS. I create PR if it seems legit :)
Before:

After:

Yeah, that definitely looks broken. It seems possible the right fix will involve deleting CSS rather than just adding CSS, and we should fix the vertical centering of the icon while we're at it.

@timabbott
Issue is solved
here is PR: https://github.com/zulip/zulip/pull/22762


Update documentation (#162)

Looks good, except we need a bit of discussion of how errors work and how they can be displayed to end users.

@samuelcolvin updated, check please

Looks good, I have some changes and improvements to the English, but that's probably better done in a separate PR.

Thanks!

#162


[dv] AON timer regression failure fixes

First commit is mostly about giving the test more time to settle software side registers. More interesting change is in the second commit.
@tjaychen : I did a change in the assertion around receiving an update pulse for the source(software) side in the case of a hardware request. Because we already catch the hardware request and process it in the arbitration module I moved the assertion there. This change possibly made this assertion weaker but I couldn't find any other way to make it consistent with the module behaviour. Could you have a look when you are available?

@ctopal could you let me know how the original assertion failed? I worry there's a hidden hardware bug here in the prim_reg_cdc stuff.
Adding @jeoongp since he also looked at this pretty extensively during reviews.

When you set a custom value to a either wdog or wkup timer counters if the count is bigger than the threshold, we see an interrupt happening on the next cycle. However on the hardware side, we still keep on counting.
I set up the test sequence in a way that in the case of detecting an interrupt, it would clear the registers. So, that resulted with us seeing two updates at the same time. Slow domain (the update from the hardware) was trying to write while the fast domain already initiated the handshake. At least that is what I understood from the whole deal, admittedly it was confusing and I am not sure if I did the correct thing with carrying the assertion inside arbitration module.
If you want to see the waveform itself (which I strongly suggest because I think I am not very good at explaining what's happening!), please rebase your master with 5d4b3fd72b78f33b7da4618e3fc3c720888874fc and then run
util/dvsim/dvsim.py hw/ip/aon_timer/dv/aon_timer_sim_cfg.hjson -i aon_timer_jump --reseed=1 --fixed-seed=1263529190 -w -vh --tool=xcelium
P.S. You can see the same behaviour with --tool=vcs but it does report the run as passed which is kind of concerning honestly...

When you set a custom value to a either wdog or wkup timer counters if the count is bigger than the threshold, we see an interrupt happening on the next cycle. However on the hardware side, we still keep on counting.
I set up the test sequence in a way that in the case of detecting an interrupt, it would clear the registers. So, that resulted with us seeing two updates at the same time. Slow domain (the update from the hardware) was trying to write while the fast domain already initiated the handshake. At least that is what I understood from the whole deal, admittedly it was confusing and I am not sure if I did the correct thing with carrying the assertion inside arbitration module.
If you want to see the waveform itself (which I strongly suggest because I think I am not very good at explaining what's happening!), please rebase your master with 5d4b3fd and then run util/dvsim/dvsim.py hw/ip/aon_timer/dv/aon_timer_sim_cfg.hjson -i aon_timer_jump --reseed=1 --fixed-seed=1263529190 -w -vh --tool=xcelium
P.S. You can see the same behaviour with --tool=vcs but it does report the run as passed which is kind of concerning honestly...

i'll need to run the test to confirm. But the conflicting updates case you're talking about (ie software makes an update, and also hardware makes an update) is supposed to be something that could happen.  If that caused the assertion to fail indeed something is fishy..either the assertion was wrong or the design is probably misbehaving.
Will definitely need to have a look.

util/dvsim/dvsim.py hw/ip/aon_timer/dv/aon_timer_sim_cfg.hjson -i aon_timer_jump --reseed=1 --fixed-seed=1263529190 -w -vh --tool=xcelium

I have some questions.

As I run the above command, it generates a simvision waveform that shows errors for Xcelium. But, when I run without Xcelium tool option, no error found. What is difference between Xcelium and no-Xcelium wrt aon_timer?
How can we run simvision gui?
Why is fsdb not supported in Xcelium different from normal case?

i had a closer look at this, and i'm 99% sure the assertion is just out of date.
It was written with the previous cdc scheme in mind and did not take into account some of the changes with the new scheme.
Let me double check one more to confirm, and if yes we can just merge this one.  I'll follow-up with another PR to slightly tweak the assertion.

Thanks @tjaychen and @jeoongp for having a look. I'll wait for the double check :+1:
For the questions:

util/dvsim/dvsim.py hw/ip/aon_timer/dv/aon_timer_sim_cfg.hjson -i aon_timer_jump --reseed=1 --fixed-seed=1263529190 -w -vh --tool=xcelium

As I run the above command, it generates a simvision waveform that shows errors for Xcelium. But, when I run without Xcelium tool option, no error found. What is difference between Xcelium and no-Xcelium wrt aon_timer?

If you do not specify the tool, it runs it with the default tool specified under aon_timer_sim_cfg.hjson which currently is VCS. Hence my earlier comment:
"You can see the same behaviour with --tool=vcs but it does report the run as passed which is kind of concerning honestly..."

How can we run simvision gui?

For simvision gui command I use:
simvision ./<scratch-path>/0.aon_timer_jump/out/waves.shm &

Why is fsdb not supported in Xcelium different from normal case?

Looks like a bug in waves.tcl @sriyerg do you have any suggestions?

Thanks @tjaychen and @jeoongp for having a look. I'll wait for the double check 👍
For the questions:

util/dvsim/dvsim.py hw/ip/aon_timer/dv/aon_timer_sim_cfg.hjson -i aon_timer_jump --reseed=1 --fixed-seed=1263529190 -w -vh --tool=xcelium

As I run the above command, it generates a simvision waveform that shows errors for Xcelium. But, when I run without Xcelium tool option, no error found. What is difference between Xcelium and no-Xcelium wrt aon_timer?

If you do not specify the tool, it runs it with the default tool specified under aon_timer_sim_cfg.hjson which currently is VCS. Hence my earlier comment: "You can see the same behaviour with --tool=vcs but it does report the run as passed which is kind of concerning honestly..."

How can we run simvision gui?

For simvision gui command I use: simvision ./<scratch-path>/0.aon_timer_jump/out/waves.shm &

Why is fsdb not supported in Xcelium different from normal case?

Looks like a bug in waves.tcl @sriyerg do you have any suggestions?

regarding the last point, @weicaiyang actually looked into this.
xcelium can dump fsdb, but there is no linkage between the waveform and the source code, which kills at least half the utility.
There is a way to make that work, but it just really isn't worth it right now.

Why is fsdb not supported in Xcelium different from normal case?

Looks like a bug in waves.tcl @sriyerg do you have any suggestions?

regarding the last point, @weicaiyang actually looked into this. xcelium can dump fsdb, but there is no linkage between the waveform and the source code, which kills at least half the utility.
There is a way to make that work, but it just really isn't worth it right now.

This is the related issue - https://github.com/lowRISC/opentitan/issues/12995

go ahead with this one, i'll merge a slightly tweaked check on top of it afterwards.

First commit is mostly about giving the test more time to settle software side registers. More interesting change is in the second commit.
@tjaychen : I did a change in the assertion around receiving an update pulse for the source(software) side in the case of a hardware request. Because we already catch the hardware request and process it in the arbitration module I moved the assertion there. This change possibly made this assertion weaker but I couldn't find any other way to make it consistent with the module behaviour. Could you have a look when you are available?

FSDB is supported with Xcelium. Pass -w fsdb to dvsim when running with Xcelium. If you just pass -w it will default to Xcelium's stardard wave format which is shm.


choppy performance

i have Intel Extreme Edition HEDT CPU from about 5 years go with 16 GB ram and M.2 SSD on Windows 10 and Chrome Browser and when i do CTRL+ or CTRL- to change the scale of the timeline it takes a solid 5 seconds or so to actually do it ( if i'm far enough down the timeline )...
basically my PC can launch Microsoft Office in about half the time it takes to zoom the timeline in or out ... which is something that is basically instant on any other web page ... with GAB being the slowest still taking about half a second to do it, or about 10 times faster than noStrudel ...
i understand NOSTR has a lot of overhead compared to basically any other webpage and also that most people rarely use CTRL+ and CTRL- to adjust page zoom level but i do it all the time depending on how my eyes are feeling ...
it seems to be slower after i have scrolled through a couple hours worth of timeline.  it isn't as bad when you're at the top of the timeline.
on the upside the content loads really fast.  it's resizing it that is slow.
i don't really expect this issue to be easily fixable or a high priority but i noticed this so i am reporting it

Unfortunately performance is something that will never be "fixed" but this should improve whenever I get the chance to work on pruning the timeline. basically if your 100 notes down and you change the window size it has to re-render 100 notes :(


Prepare for integration with windows

This are just minor changes that mostly cause some files to no longer compile under windows.
This way we will be able to make the modifications in smaller commits.

LGTM

@adiclepcea Are you still working on Windows support? Would you still this PR to be merged?

Yes @tomdee we are still working on windows support. I have just rebased the other PR for windows.


[WIP/bp/1.26] Backport stack (3)

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

one last bug to iron out


Double cursor

Many a times, it happens that brackets start showing two cursors at the same time. Because of this, basic functions like typing, copying, pasting, cutting, selecting do not behave as intended.

It's a feature, not a bug. You can hold down CTRL while clicking around the editor to create multiple cursors: this is especially handy when you need to create or remove same values for multiple places.

Oh ok. Cool. Thanks for clarifying.


[ISSUE #4568]Improve performance of consume queue

This pull request fixes https://github.com/apache/rocketmq/issues/4568

good improvement，looks to good to me.

@lizhanhui LGTM.
Currently, it may need to rebase the branch.

in some scenes，reduce 80% disk  bandwidth .


on_deployment_update  + mention_enricher creates multiple alerts.

Describe the bug
Triggers: on_deployment _update
actions: resource_babysitter and mention_enricher
sinks: Slack
Using on_deployment _update + resource_babysitter alone works just fine, but when used alongside mention_enricher produce multiple (i.e. four per pod) "empty" alerts as well as the actual "configured" alert. The "empty" alerts also triggers whenever there is any change to a deployment, even if the change is not in the field_to_monitor defined in resource_babysitter.
I have narrowed it down to being related to the trigger on_deployment_update trigger not working well with mention_enricher action. I have also tested that on_pod_update gives the same outcome. on_pod_create however will only create a single triggering resulting in a single alert.
I guess this has something to do with that a single change in a deployment will actually aggregate multiple changes to the deployment manifest. I.e. annotations.deployment.kubernetes.io/revision, kubectl.kubernetes.io/last-applied-configuration, creationTimestamp, generation e.t.c. And the mention_enricher action will be triggered for each of these changes instead of combining these changes into a single trigger?
Additionally: Alerts will be created even though the change does contain the specific field in specified in the resource_babysitter, but in this case we do not get the "configured" alert as expected.  Removing the resource_babysitter action all together while still leaving the mention_enricher action in will give the same result.
To Reproduce
1. Configure Robusta helm chart:
Custom Playbook:
    - triggers:
        - on_deployment_update: {}
      actions:
        - resource_babysitter:
            fields_to_monitor:
            - spec.template.spec.containers[0].image
        - mention_enricher:
            static_mention:
            - @kristian
            message_template: $mentions

Sink:
    - slack_sink:
        api_key: '{{ env.SLACK_API_KEY }}'
        default: true
        name: main_slack_sink
        slack_channel: tmp-robusta-test

2. Apply a Dummy deployment to the cluster:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: dummy-deployment
  labels:
    app: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx

apply to cluster using kubectl apply -f dummy-deployment.yaml.

Manually change the container image ...
to e.g. nginx:latest using kubectl edit deployment dummy-deployment

Expected behavior
Get a single alert in the tmp-robusta-test slack channel that is enriched with the slack mention @kristian, when the image of the dummy deployment is changed.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

I have pretty much the same behavior. But I'm getting five identical messages in tg/slack when updating a deployment
My config is:
  - triggers:
      - on_deployment_update:
          name_prefix: vroom
          namespace_prefix: staging
    actions:
      - deployment_status_enricher: {}
      - resource_babysitter:
          fields_to_monitor:
            - spec.replicas
      - customise_finding:
          severity: INFO
          title: "Deployment $name in namespace $namespace was updated"
          aggregation_key: "Deployment_updated"
          description: "Updated field for $name"```


Extract Pages to create other pdf

Hello,
I have a scenario where I need to extract specific pages from pdf and create a pdf only from those pages.
Can this library will be helpful in this scenario?
I will be thankful to your help.

I have a scenario where I need to extract specific pages from pdf and create a pdf only from those pages.

Grim can extract specific pages but it extracts them as individual images. It does not have any functionality for creating a new pdf from those images.


Figure out how to update our blog section

Now that we're moving to medium the Recent highlights from our blog section on the home page is going to be out of date. We need a way to populate this data.
Some questions to answer:

Does medium have an API we can call to do this automatically?
If not can this be scripted as a rake task?

Closing.. as we're now over on Medium. :)

@davidmolina I think we still need this so we can update the blog section on opcode.org with the content from medium...unless we want to remove the recent highlights section?

2

Auto update from Medium?

On Aug 26, 2016, at 6:42 AM, Rick<EMAIL_ADDRESS>wrote:
2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Basically yea. I haven't looked into if that's possible or not. We could just remove the blog section for now. I suspect it's not seen often (if at all). Let me see if I can pull some stats to confirm.

Remove from landing? Sure. Priority there is conference & code school scholarships, sponsors and in the news.

On Aug 26, 2016, at 6:07 AM, Rick<EMAIL_ADDRESS>wrote:
@davidmolina I think we still need this so we can update the blog section on opcode.org with the content from medium...unless we want to remove the recent highlights section?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

...it's not on there now. Ok then - this should be fine to close!

Will do..

On Aug 26, 2016, at 10:57 AM, Rick<EMAIL_ADDRESS>wrote:
...it's not on there now. Ok then - this should be fine to close!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


USHIFT-577: Change prometheus port to fix cadvisor conflict

Cadvisor also uses port 9090, made a var to set the Prometheus port.
New default Prometheus port updated across configs (including grafana), and set to 9091 which seems to be unused.

/lgtm

/assign @ggiguash

/lgtm


Use fuubar together with parallel-test?

Hello,
I am using the parallel-tests gem which REALLY REALLY speeds up test time (since we have an 8-core machine to develop on ...). However, looking at the spec results is a mess, since they just get spit out to the console.
Would you be interested in collaborating getting fuubar running with parallel-tests so that you get one progress bar per process, and the failing tests are output cleanly to the console?
Thanks!
Jens

Did you guys ever make any further progress on this issue?  I'd love to be able to utilize fuubar with parallel_tests.

Adding myself to this issue -- I've started a bit of work to get parallel-test working with Guard, so if I see anything that could be useful here I'll let you know.

@arsduo Take a look at parallel_split_test; that might make more sense to utilize with Guard.

+1

Hey all, I don't want to come across as a jerk, but I don't use Parallel Tests. I understand it's usefulness though. So as I said before, I'll gladly accept a PR.
So you can +1 this issue all you want but it's not going to change the fact that it's not getting done without a PR.

@jfelchner Any idea what needs to be done?

@thedrow no clue.

+1

Any solution to this in 2020? :)


New Query model object attached to Dataset as query attribute

Child of #34 - Data Query support

FIXED.


And is broken in latest version (0.35.0)

Looks like it return false or undefined even when defaultTrue is used.
At least it does not work same way as Ember.computed.and

#325 fixed it. Noob mistake hasOwnProperty.


make install target fails

@cpinter @TrosnyogoSzakoca
There seems to be something fishy with the "make install" CMake target.
I get:
make
[ 50%] Linking CXX shared library libvtkIECTransformLogic.so
[100%] Built target vtkIECTransformLogic
find ./ -name libvtkIECTransformLogic.so
./libvtkIECTransformLogic.so
make install
Consolidate compiler generated dependencies of target vtkIECTransformLogic
[100%] Built target vtkIECTransformLogic
Install the project...
-- Install configuration: ""
CMake Error at cmake_install.cmake:60 (file):
  file INSTALL cannot find
  "/opt/RadiotherapyTransformsIEC/build/libvtkIECTransformLogic.so": No such
  file or directory.
find ./ -name libvtkIECTransformLogic.so
No return ---> File has been removed by "make install" somehow

This was solved a while ago.


why two places for strings

[Enter feedback here]
One thing I find odd in the WAC SDK is that text strings are defined either in manifest.json or in strings.js. Seems like there should be only one place for defining strings, especially when dealing with I18N. Is there a way to refer to reference all the strings in the strings.js from the manifest.json?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c148af76-1727-0f80-6eee-acf12e7b762a
Version Independent ID: 63432638-b57c-35d1-3b96-634d2de2eddc
Content: Strings and localization in Windows Admin Center
Content Source: WindowsServerDocs/manage/windows-admin-center/extend/guides/strings-localization.md
Product: windows-server
Technology: windows-admin-center
GitHub Login: @nwashburn-ms
Microsoft Alias: niwashbu

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Embeddable property initializer is not ran during hydration

Describe the bug
I use an initializer on an embedded property but it doesn't get fired when hydrate function is called. This is as deep as I could debug since I started getting lost in how the hydrator functions worked. I used the "forceEntityConstructor" with the embeddable but I'm assuming it might not work with embeddables. This seems to happen when there's pre existing data for the embeddable entity.
Stack trace
N/A
To Reproduce
Steps to reproduce the behavior:
https://github.com/ryankauk/mikro-jest-global-setup/blob/master/src/embeddableInitializer.spec.ts
Expected behavior
I expected that it would use the initializer when the property doesn't exist. I knew that this isn't the case unless "forceEntityConstructor" is set, and expected this would solve my issue and use the initializer.
Additional context
Add any other context about the problem here.
Versions

Dependency
Version

node
v12.16.3

typescript
^4.1.3

mikro-orm
4.5.6

your-driver
mongo

This is correct behaviour, just like with entities, initializers are executed only in case of new entity/embedded instance, not for existing ones. If you don't use constructors in your entities and want this behaviour, just use forceEntityConstructor, or the onInit hook on parent entity.
We can add something like forceEmbeddedConstructor if you want.

Actually you can already use forceEntityConstructor option, you can specify it as an array of classes to have control over what entities will use constructors (and in this sense embeddable is an entity).
I see that you already found out this is possible, as you got it in your repro too.
Closing, I don't think we need another option for this, I'd expect people will usually won't one way or the other (e.g. don't care about using own constructors at all).


I'm running build on google cloud build, can i use google auth instead of using the JSON file?

@lappazos thanks for asking. It would be a good idea but think it may require some work to do that.

I believe all you need to do is make the credential parameters optional and create the Google cloud storage client with simply Client(). Google's libraries will use workload identity by default if you don't provide a credential file, so I think the only thing preventing that right now is that _load_credentials requires one of the credential file options to be set.

@rra thanks for the tip. Closing as FIXED.

I don't think this is fixed, unless I'm missing something. _load_credentials still requires one of the credential options to be set. I think the last else branch of _load_credentials needs to be changed to return None so that None is passed in as credentials, which will use workload identity.

@rra thanks for clarifying.

Addressed in https://github.com/datopian/giftless/pull/120

@athornton with your coder merged does this make this fixed?

Yeah, I think so.  A new container build/push would be ideal, but I think if you just check it out and run docker build you'll get the changes.
Note that if you're doing this under K8s actually setting up the service account mappings is a lot of pain, but it does work once you have all the right objects bound together.

FIXED.


LSP failing to start Rubocop LSP

Description
I have spent my whole day trying to figure it out Rubocop on LSP config. I have a legacy project that is running an old version of Rubocop and I have the latest version installed globally. I am also running Ruby 2.7.6 which is the project version.
This is the error I'm getting:
[START][2023-12-11 22:26:00] LSP logging initiated
[ERROR][2023-12-11 22:26:00] .../vim/lsp/rpc.lua:675	"rpc"	"bundle"	"stderr"	"invalid option: --lsp\nFor usage information, use --help\n"

And this is my config for LSP:
lspconfig.rubocop.setup {
  on_attach = on_attach,
  capabilities = capabilities,
  cmd = { os.getenv "HOME" .. "/.asdf/shims/rubocop", "--lsp" },
  filetypes = { "ruby" },
  root_dir = util.root_pattern("Gemfile", ".git"),
}

This is the output for LspInfo:
 Language client log: /Users/rafael/.local/state/nvim/lsp.log
 Detected filetype:   ruby

 1 client(s) attached to this buffer:

 Client: null-ls (id: 1, bufnr: [1])
 	filetypes:       typescriptreact, javascriptreact, javascript, typescript, markdown, json, jsonc, html, css, js, jsx, ts, tsx, luau, lua, go, ruby
 	autostart:       false
 	root directory:  /Users/rafael/Development/project
 	cmd:             <function>

 Other clients that match the filetype: ruby

 Config: rubocop
 	filetypes:         ruby
 	root directory:    /Users/rafael/Development/project
 	cmd:               /Users/rafael/.asdf/shims/rubocop --lsp
 	cmd is executable: true
 	autostart:         true
 	custom handlers:

 Configured servers list: lua_ls, html, clangd, rubocop, cssls, gopls, tsserver

Neovim version
NVIM v0.10.0-dev-1742+g17f3a3ae3-Homebrew
Build type: Release
LuaJIT 2.1.1700008891
Nvim-lspconfig version
No response
Operating system and version
macOS 14.1.2
Affected language servers
rubocop
Steps to reproduce

Setup an old rails project that uses ruby 2.7 and rubocop prior to 1.x
Install Rubocop globally gem install rubocop
Install the rubocop lsp config
Open a ruby file inside the project

Actual behavior
It does not work
Expected behavior
I was hopping to have LSP working with all the goodies.
PS: The same config on VSCode just works like magic. Using the same gem.
Minimal config
I'm using NvChad with the default configuration, just added rubocop.

LSP log
don't have

Thanks for your report. The configs in this repo are unsupported and provided only as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and send improvements.
If you found a bug in the core Nvim  vim.lsp module (not part of this repo), the best way to get it fixed is to report to Nvim (not nvim-lspconfig) with:

steps to reproduce it without the particular LSP server and other factors particular to your environment
(optional, but very helpful): by adding a failing test case to lsp_spec.lua, which has code to setup a fake LSP server to simulate various scenarios


NTR: positive regulation of morphogenesis of an epithelium

as child of GO:0002009 morphogenesis of an epithelium
TG doesn't load up after login in. If this is a short-term issue and TG is up and running again soon, I can add the term myself.
Birgit

Short term TG issue. Should now be working.  Please use the regulates template to add.   Let me know if any problems.  Cheers, David

Thanks, all done!


rbd: add validation for thick restore/clone

added validation to allow only Restore of Thick PVC snapshot to a thick clone and creation of a thick clone from thick PVC.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

In theory we can also call rbd_sparsify() on the new image if it should not be thick-provisioned.
Maybe there should be an issue to track what we actually want to do, and why?

In theory we can also call rbd_sparsify() on the new image if it should not be thick-provisioned.
Maybe there should be an issue to track what we actually want to do, and why?

To keep the feature simple for now let's allow only thick-thick will open one for this one and will open another issue to track thick-thin and thin-thick feature

@Madhu-1 please let me know your choice to accept or defer https://github.com/ceph/ceph-csi/pull/2174#discussion_r653297992, accordingly we can move :)

@Madhu-1 please let me know your choice to accept or defer #2174 (comment), accordingly we can move :)

Already replied at https://github.com/ceph/ceph-csi/pull/2174#discussion_r653298945 :)

@nixpanic @humblec added one more commit to fix some cases where parent PVC of the snapshot is created before Resotre operation. PTAL

/retest ci/centos/upgrade-tests-cephfs

/retest ci/centos/upgrade-tests-cephfs

 Error from server: error when creating "STDIN": etcdserver: request timed out

/test ci/centos/upgrade-tests-rbd

/test ci/centos/upgrade-tests-rbd

Error from server: error when creating "STDIN": etcdserver: request timed out

/retest ci/centos/mini-e2e-helm/k8s-1.19

/retest ci/centos/mini-e2e-helm/k8s-1.19

failed to create PVC with error etcdserver: request timed out


M3-714 Profile: Update email address

Purpose
Users should be able to update their account email address when viewing their profile.

Add form for updating email/username
Add routing logic to Profile.tsx
Add DisplaySettings component (will later hold timezone as well)
Add tests for 2 new components

Notes

The original design included an editable username field as well. Since this is not supported by the CF manager or the /profile endpoint, this has been dropped. The textfield with the user's display name is disabled, it may need to be removed pending design updates or review.

Coverage increased (+0.3%) to 26.991% when pulling 527f3fb67bec8856f58a6b17319c4b87493e2ae0 on Jskobos:M3-714-update-username-email into 4c88d39852e4301171478690782ffe025bd3f6e6 on linode:develop.

Will retest after @rjstires & @martinmckenna changes are addressed. Things looked good when i tested though

@Jskobos I agree with @rjstires, the state management should be moved into the component

The indentation for EmailChangeForm is 4 spaces, should be 2


Create a separate "Deals of the Day" page and remove deals section from home page

Please assign this issue to me.

@Swastik1710  I will assign you this issue when DevIncept will commence from 10th July.

I would like to do this .
Please assign me this issue.

I would like to do this .
Please assign me this issue.

@tjanhvi go ahead

@Swastik1710 ask first so he will be assigned if he will unable to solve issue @tjanhvi you will be assigned next

@Swastik1710 ask first so he will be assigned if he will unable to solve issue @tjanhvi you will be assigned next

okay :)

Hey @QAZIMAAZARSHAD , I'm thinking of adding Deals of the Day tab on the navbar in place of Offers.
It would be better imo.
What do u say ?

Hey @QAZIMAAZARSHAD , I'm thinking of adding Deals of the Day tab on the navbar in place of Offers.
It would be better imo.
What do u say ?

Yaa better.
But don't disturb the navbar.

So shall I remove Offers and add Deals of the Day ?

Here's the new Deals of the Day page with the modified navbar

Make deals of the day page stylish.
Refer to some websites and apply better design.

I think this one's looking good.

Add few more cards.

Yeah I'll add one more row

try to add border in each card 🤔 may be it will look good

How's this

Cool.
Is the time dynamic?
If not make it, also after reaching 0 timers should restart.
Also, all times are same, make each different.

Yeah it's dynamic.
As of now, I've set it as such that it shows "Expired" once the timer reaches 0.
I'll change it to reset as you said.

I've set the expiry date of 1 year later.

@Swastik1710 these number of days are too  much for an offer.
7 days, 3 months, 1 month, 16 days is fine.

@Swastik1710 ask first so he will be assigned if he will unable to solve issue @tjanhvi you will be assigned next

okay


Overridable default configuration via config file

We need the ability to have a customizable default configuration for things like

default graph size
default colors

would also be useful for the fileprefix stuff

61b1fe832 is taking a step in the right direction. now we just have to add a config file to let people set those outside of command line parameters

72e0194 is giving us config file parsing and implements an example option (figure size, due to popular demand)


Improve web UI for activity shared

The current interfaz is hard to difference between a shared and normal post, looks like duplicate, this PR improve this.

Coverage remained the same at 73.802% when pulling 2016df10bed38f16430b0f74a92a319eabdadaa6 on vxcamiloxv:feature-improve-share-post-ui into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.

Coverage remained the same at 73.802% when pulling 0e63ea5d382da94ec1ecb8694513c69c46229588 on vxcamiloxv:feature-improve-share-post-ui into d1037f2c6c149078b3b5dfbb8fe43751354a86e8 on pump-io:master.


remove hash from view name & regenerate

For illustrative purposes on https://github.com/masseelch/elk/issues/20

Closing because this is an inappropriate implementation-- it will clobber necessarily different views.


Use postgres-package in chainlink-node-package

Our chainlink-node package requires a postgres instance to back the chainlink node.
This issue is created to track the effort to use the new postgres-package in the Chainlink-node starlark script, instead of relying on the dockerhub postgres image

Specifically, replacing this entire starlark file with the postgres-package


Improve type detection

fixes #20
Adds additional tests.
Uses regex to decide between wgsl and glsl.
Improved error message.
Since this is rather basic regex, this will also find functions within comments. So edge cases might still be left.

You could search with both regexes and if both match, pick the one with the first index. At least that gives some control to sharer authors, instead of always letting wgsl win in this scenario

I suspect just counting the presence of "f32" vs "float" would be a reliable measure that makes little assumptions about the actual shader.

The reasonably predictable problem case here is when someone is porting GLSL to WGSL or the other way around and including the ported code in code comments. :)

two lazy ideas:

make type="glsl" a keyword argument with default. So wgsl can be specified.
try both variants and expect and error in _prepare_render()

If the user submitted code doesn't include either entry function and we don't give them an error. The error from wgpu will be a Parse error saying function shader_main not found. Which isn't really helpful (hijacking and rephrasing error messages is a long term goal)

Keyword argument sounds great.

FWIW I was just thinking out loud with regard to distinguishing between wgsl and glsl in general. In wgpu-py we check for "#version#  for glsl and "@vertex/@fragment/@compute" for wgsl, which is also not ideal. In the end, all these are measures of confidence that can fail in specific situations.
Anyway ... if for this particular case (shadertoy shaders) detectingvoid shader_main etc. is effective, I'd say go for it.
Having a keyword argument would be nice regardless. The default could also be auto-detect. Then you'd have convenience, but also a way for the user to override in case the autodetection fails.


[Feature Request] minimum torch for pyinstaller

When I make executable using pyinstaller,
it contains 3.9G of torch directory.
How can i reduce the size of torch directory?

Maybe using cpu version of torch or libtorch in c+o


Microsoft.Azure.DocumentDB 1.21.0 issues

I'm getting the following issues in my unit tests after upgrading:
.NET Framework 4.5.2:
Error Message:
 System.AggregateException : One or more errors occurred.
---- Microsoft.Azure.Documents.DocumentClientException : Message: {"Errors":["Owner resource does not exist"]}
ActivityId: 24f7ab71-6c7e-4ea9-94dd-6b26bcbf0aa6, Request URI: /apps/DocDbApp/services/DocDbMaster0/partitions/780e44f4-38c8-11e6-8106-8cdcd42c33be/replicas/1p/

.NET Core 1.0 & .NET Core 2.0:
[xUnit.net 00:00:04.2013498]       System.AggregateException : One or more errors occurred. (Invalid API version. Ensure a valid x-ms-version header value is passed.
[xUnit.net 00:00:04.2014028]       ActivityId: b1bb6273-79b8-475c-9ecd-1c90e49c609d, Windows/10.0.14393 documentdb-netcore-sdk/1.9.0)

The unit tests use the Cosmos DB Emulator (which might not support the new library version yet?)
My project is a library with .NET Framework & .NET Standard as target.
My unit test projects are running the tests for .NET Framework 4.5.2, .NET Core 1.0 and .NET Core 2.0.
Strangely the errors only occur on my AppVeyor build and not when I run the unit tests locally.
My project:
https://github.com/FelschR/AspNetCore.Identity.DocumentDB/tree/master
https://ci.appveyor.com/project/FelschR/aspnetcore-identity-documentdb/build/1.1.0-master-47

What is the version of the emulator that the tests fail against?

On the build server I download it from https://aka.ms/cosmosdb-emulator each time the build runs.
Locally I have <IP_ADDRESS> which I also got from the link yesterday,

@FelschR 1.21.0 has been unlisted. Does  this issue exist with 1.20.2?

Also, version 1.3.0 of the ChangeFeedProcessor still references 1.21.0 which causes build warnings when the ChangeFeedProcessor is added to a project with 1.20.2 already installed.

1.21.1 version published and now changefeedprocessir should be consumable.
Apologies for the in-convenience.

Resolving the bug for now. In-case of any issues, please re-activate or create a new bug.


Unable to get refresh token with Firefox

Describe the bug
I'm not familiar with selenium at all, but lidl-plus auth was reporting that I don't have firefox installed (I do). Removing executable_path, firefox_binary and firefox_profile arguments from webdriver.Firefox() in _init_firefox() fixed this issue.
Expected behavior
I'm supposed to get a refresh token.
Environment (please complete the following information):

Python-Version: 3.11
Release-Version: 0.2.6
OS: Fedora 37
Browser: Firefox and Chromium
Country: CZ
Language: cs

I have a similar issue, but only when trying to run the auth from an installed package -> then it fails with Can't connect to web browser. Please install Chrome, Chromium or Firefox.
However, when I just clone the repo and run it locally with python3 lidlplus/__main__.py auth it works smoothly and without issues.
I'm running it on maxOS Monterey 12.5.1, installing the package via pip.
I'd try to look into it more, but it's difficult to debug, as it runs without issues locally. Figured I would at least write it here to help someone.

Same problem here on my Linux box.
So I cloned the repo and tweaked it until it worked.
lidlplus uses Selenium. I'm also using Selenium in other projects. So, this package was already installed.
However the minimal Selenium program (two lines in a Python console) failed:
from selenium import webdriver
driver = webdriver.Firefox()

The geckodriver version (0.29.1) detected in PATH at /home/XXXX/bin/geckodriver might not be compatible with the detected firefox version (118.0.1); currently, geckodriver 0.33.0 is recommended for firefox 118.*, so it is advised to delete the driver in PATH and retry
The solution is simply enough: download the current geckodriver from the Mozilla project and try again.  The two-liner worked.
After that I changed the lidl-plus source code in the file api.py. In the procedure _init_firefox I commented out three parameters that apparently don't exist anymore. (I tried using them in the two-liner and Python complained.)
        return webdriver.Firefox(
            # executable_path=GeckoDriverManager().install(),
            # firefox_binary="/usr/bin/firefox",
            options=options,
            # firefox_profile=profile,
        )

The superfluous parameters made the function call fail which was interpreted as "Firefox is not installed".
Please note that lidl-plus tries to connect to Chrome first before it tries to connect to Firefox and the timeout is about half a minute. So, be patient.
I temporarily changed options.headless to False three lines earlier in order to see the Firefox window pop up and to observe the interaction.  You have to remember however that the PIN that you get on your mobile has to be entered in the command line window not into Firefox.

After cloning the repo change into its folder (in my case lidl-plus (with an -)).
From there change into lidlplus (without the -) and modify api.py.
Go back to the parent folder and call the script like

lidlplus/__main__.py auth
lidlplus/__main__.py --language=de --country=DE --refresh-token=XXXXXX receipt --all > data.json

Will this work in a native app in headless mode? So far I was unsuccessful. It either fails to get a driver or selenium times out.

@adithya995 What exactly do you mean by "native app" and "headless mode"? What are the exact errors you're getting when you say "fails to get a driver" and "selenium times out"?


chore: add tflint-ruleset-aws-serverless to releases

As tflint 0.29 is not out yet, we cannot use tflint --init to automatically initialize the aws-serverless plugin. At the moment, the only way to do it is to clone the repository and compile tflint-ruleset-aws-serverless manually.
The purpose of this ticket is to add automated generation of the binary in different formats (MacOS/Windows/Linux and amd64/arm64) so that people can download it directly.

Implemented in https://github.com/awslabs/serverless-rules/pull/27


When subtitles are displayed for on-screen text subtitles for dialog are not displayed.

Bug report
Your Environment

Netflix add-on version: 1.12.4
EDIT: I've upgraded to Kodi 19 and version 1.15.1+matrix.1 of the Netflix plugin. The bug remains.
Operating system version/name: Windows 10

Used Operating system:

[ x] Windows

Describe the bug

When subtitles are displayed for on-screen text subtitles for dialog are not displayed.
Expected behavior

Dialog subtitles should be displayed together with on-screen text subtitles.
Actual behavior

Only on-screen text subtitles are displayed and no subtitles are displayed for dialog.
Steps to reproduce the behavior

Play this video with english subtitles. https://www.netflix.com/watch/70303634?trackId=200257859
Fast forward to approximately 15:55
Watch the following 20 seconds or so

Possible fix

Debug log

The debug log can be found here:

kodi.log
Additional context or screenshots (if appropriate)
Other information

Screenshots

Correct subtitles as displayed on netflix website.

Incorrect subtitles as displayed with plugin

This have to be fixed on Kodi, i have tried to open a Kodi Issue https://github.com/xbmc/xbmc/issues/19698

@mlidbom are you running Kodi in fullscreen or windowed?

in fullscreen i do not see subtitle problems
and please test with original Kodi skin, not custom skin

@mlidbom As a temp solution you could use the modified Netflix plugin from @Paco8 repo on Kodi Matrix, it displays the subtitles in ssa format, in Improved subtitles settings disable "Allow timestamp manipulation"
https://github.com/Paco8/kodi-repo/blob/master/packages-kodi-19/repository.paco8/repository.paco8-1.1.0.zip
This is how it looks in the modified Netflix plugin by @Paco8.

@CastagnaIT Kodi seems to be not supporting the alignment tags in the webvtt subtitles, it looks like this

when it should look like this.

261
00:14:58.900 --> 00:15:06.365  position:50.00%,middle  align:middle size:80.00%  line:10.00%
FILE OF TRUE CROSS ACADEMY
REGIONAL EARTHQUAKE DAMAGE REPORTS
262
00:14:59.275 --> 00:15:02.570  position:50.00%,middle  align:middle size:80.00%  line:79.33%
That said, I'm going to continue
to keep an eye on Rin Okumura.

@CastagnaIT
Thanks you very much for taking action on this super quick. It is very much appreciated!

This have to be fixed on Kodi, i have tried to open a Kodi Issue xbmc/xbmc#19698
Hmm. Unlike what you describe there, I see no subtitles displayed at all, see screenshots. I've been using Kodi for many years with countless videos like this and never have I encountered this issue before.

Strange that we see different behavior. I wonder what is different between our environments. Hmm, I run dual screens with 4K resolution. I wonder if either resolution or dual screen is relevant. I will run some tests and report back the results. I'll also test with and without hardware acceleration allowed.

@mlidbom are you running Kodi in fullscreen or windowed?
I'm running fullscreen.

please test with original Kodi skin, not custom skin
I tried this and the result is exactly the same.

@mlidbom As a temp solution you could use the modified Netflix plugin from @Paco8 repo on Kodi Matrix, it displays the subtitles in ssa format, in Improved subtitles settings disable "Allow timestamp manipulation"

Thank you! After experimenting some with resolutions I will switch to that version for an instant fix!

@CastagnaIT
It is resolution dependent. I tried with 1920x1080 and then I see the subtitles displayed as in your screenshots in the other issue that you opened. Hardware acceleration does not seem to have any impact. Single or dual screen did not seem to have any impact.
I'm guessing that the incorrect positioning does not properly scale with screen resolution and end up displaying the dialog off-screen when running in 4k resolution. I'll add this information to the issue that you opened.

@CastagnaIT

@mlidbom As a temp solution you could use the modified Netflix plugin from @Paco8 repo on Kodi Matrix, it displays the subtitles in ssa format, in Improved subtitles settings disable "Allow timestamp manipulation"
https://github.com/Paco8/kodi-repo/blob/master/packages-kodi-19/repository.paco8/repository.paco8-1.1.0.zip

This works perfectly. Now I can go back to watching in peace :)
Again. A great big thank you for the excellent and very fast response! 🥇

@mlidbom If you just want to see all the subtitles, in @CastagnaIT Netflix plugin just turn on "Disable WebVTT subtitle support" in the settings, you will get the same result like this screenshot, but you will not be able to get the subtitles for many languages like the Japanese, Chinese, Korean, Arabic and many others (I prefer using @Paco modified version from the Netflix plugin because using the subtitles in ass format fixes some problems with the subtitles in the Arabic language need to be fixed in Kodi, and I can change the border style of the subtitles).

@mlidbom Try using this subtitle file as external subtitle and see if the problem is still exist.
Blue.Exorcist.S01E13.en.zip

@mlidbom Is the dialog disappear in 4K throughout the episode?

@Essam311
Only while translations of on-screen text are displayed. Works fine with the paco8 workaround that you suggested though, so I'm all good. Thanks again for that tip :)

with regard to incorrect off-screen text positioning
i'm working to make changes in to Kodi core to solve the problem at its root
that will see the light of day with Kodi 20 only
with regard to the dynamically text positioning in the top of screen, like the first screenshot
a different change is needed, maybe i will do in future
i close this Issue because now there is a WIP in Kodi


Error opening autocomplete window in tailwind css

When there is no space between the class and the parameter string, the parameter autocomplete window in tailwind css does not work
https://github.com/user-attachments/assets/490ec03c-8bbe-4950-803b-e8abe76bfb14
Environment:
Dioxus version: 0.6.0-alpha.2 (https://github.com/DioxusLabs/dioxus/commit/b25469208f999dd44e7884c42f525d48dca05a32) from github 19/09/24
Rust version: rustc 1.81.0 (eeb90cda1 2024-09-04)
OS info: Win11
App platform: web

That sounds like an issue with your tailwind.css config. You can change your class regex to "tailwindCSS.experimental.classRegex": ["class: ?\"(.*)\""] to make the space optional

Does dx format add the spacing? If yes, then the problem is less prominent.

My new settings
"tailwindCSS.classAttributes": [
    "class",
    "className",
    "ngClass",
    "class:"
  ],
  "tailwindCSS.experimental.classRegex": [
    "class\\s*:\\s*\"([^\"]*)"
  ],
  "tailwindCSS.includeLanguages": {
    "rust": "html"
  },
  "tailwindCSS.experimental.configFile": null,

But if you don't save when you type the code, the autocomplete won't work. So this is not a solution to the problem. The only thing left to do is to train yourself to always put a space between a colon and double quotes


use pulse_alignment from Target in PadDynamicalDecoupling

Summary
The intent for the Target argument in transpiler passes is that they will supply the necessary information for passes to use. There was an oversight when adding this for the PadDynamicalDecoupling pass, where users still had to separately pass pulse_alignment even though this information is contained in the Target.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.003%) to 89.549%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
5
91.44%

crates/qasm2/src/parse.rs
6
97.62%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
59587

Relevant Lines:
66541

💛  - Coveralls

Yeah, I agree this should update the docstring to reflect that target will supersede pulse_alignment if set (like it currently does for the other arguments).

I updated the docstring to make this clear. I believe this is the behavior across the board (in all passes target takes precedence).


Name intermediate results of Future composition, and other clarifications

The primary aim of this PR is to make it easier to comprehend the Future composition paradigm that I have used extensively throughout the codebase, by giving names to things that were previously anonymous.
I've also corrected some typos and made minor no-op changes for concision (hopefully not at the expense of clarity).
I'm open to all feedback as far as what you all think works, or doesn't.

Also, I'd like to pretend the branch name is "naming things".

I guess the tests ran slowly enough on that particular PR build that they triggered a timeout error. The timeout value on those tests is 10 seconds. My rationale for keeping those was that they provide additional specification of how the component under test should behave, although I am not opposed to removing them if they're going to fail intermittently when run in GHA.


Function testing

Is this feature request related to a new or existing Amplify category?
function
Is this related to another service?
No response
Describe the feature you'd like to request
Ability to quickly test functions
Describe the solution you'd like
I would like to be able to run:
amplify function test
amplify function test [functionName]
and have all (or just the named) function tests be run remotely (or in mock)
tests would be an input/output json file...and potentially a pre/post setup script
I would also like the option of failing a push if the tests fail...on a per function basis
Describe alternatives you've considered
This could maybe done with hooks, but I'm not sure it would be straightforward.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

Any ideas or examples on how one could perform automated testing on the lambdas today?


TemplateDoesNotExist Error

Hi. I like your implementation of Editorjs for Django. For the most part, it works until I try to go to the admin. Strangely, I can go to the admin of one of my models with this package but not in the other.

Hi! I just tested, it works on django versions 3 and 4 perfectly.
I don't understand where the file comes from editorjs.html?

@ronejercito issue resolved?


Bump versions to 0.40.0

How long normally typically after a version bump is the new version published to crates.io?


[idea] Make nodes with more connections larger

To show which nodes are the 'hubs' of the graph, it might be nice to be able to display nodes with lots of edges as larger, or make node size a function of connection count (maybe this falls under "Configurable parameters of graph simulation." in the roadmap?)

Personally, I feel like the edges themselves are visible enough to draw attention to the nodes with many of them. I'm not sure making the nodes larger would improve readability of the graph. If anything, I would reserve such markings to things that are not visible otherwise in the graph (e.g. note length, although I don't see actual need for that).

I have to disagree - in a large graph, the edges will look like a hairball. If the major nodes are larger, it will be easier to find them and start to make sense of the graph.
Here's an example from Obsidian.

@nixsee I was just about to let you know that similar thing is being worked on but I noticed that you are already well aware of that 😅 .
So in case somebody else is looking: #51.

Could probably close this issue given #51?

Until #51 is merged, it remains an open issue though 😄 .

Seems like this has been implemented with #51 , nice!


Prefix library versions with v

See https://github.com/dandi/dandischema/issues/2#issuecomment-848900472.
In addition to this PR, the tag for at least the most recent library release (0.2.0) must be renamed to have a v prefix, and the corresponding GitHub release must be updated to match.

Closing in favor of #20.


[Feature Request / Idea]: show eval in --help + brew

Suggestion / Feature Request
Your suggestion here

Done


chore: Use Renovate where Dependabot falls short

And I'll check out Renovate!

You can find examples of how I use it in my personal repos:
https://github.com/maxbrunet/bitbucket-semantic-pull-requests
https://github.com/maxbrunet/prometheus-elasticache-sd
They maintain themselves
Originally posted by @maxbrunet in https://github.com/parca-dev/parca-agent/issues/465#issuecomment-1157821734

Done in #484


Error LNK2019

Required Info

Camera Model
D435i

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
2.0

Language
C++

Segment
{Robot/Smartphone/VR/AR/others }

Hello.
An error occurred in the process of developing in C++, so please inquire.

Install the SDK
Launch Visual Studio 2019
In the Property Manager, set include and lib in the SDK folder
Set up dll files in linker
At run time

Error LNK2019 _rs2_get_librealsense_exception_type"public: __thiscall rs2::error::error(struct rs2_error *)" (?? 0error@rs2@@QAE@PAUrs2_error@@@Z) Unresolvable external symbols referenced in the function
Am I missing something?

Hi @noodle875  Though you seem to have found a solution to your LNK2019 issue, I will post a link to another case at https://github.com/IntelRealSense/librealsense/issues/8843 that had this error for the benefit of people reading this issue in the future.  Thanks!


OLS-1001: Added known issue into documentation

Description
Added known issue into documentation
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[x] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Related Tickets & Documents

Related Issue #OLS-1001

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.89%. Comparing base (6af39f6) to head (42ddb1e).
Report is 26 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage   94.88%   94.89%
=======================================
  Files          60       60
  Lines        2681     2685    +4
=======================================
+ Hits         2544     2548    +4
  Misses        137      137

Flag
Coverage Δ

94.89% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

/approve

/lgtm

/override "Red Hat Konflux / lightspeed-service-on-pull-request"


Adding mac address to new device event

Description: Adds mac address to event trigger
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
- alias: Notify for new devices
  trigger:
    platform: event
    event_type: device_tracker_new_device
  action:
    - service: notify.html5
      data_template:
        message: >
          New device: {{trigger.event.data.host_name}}
          MAC Address: {{trigger.event.data.mac}}

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @martokk,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@martokk You need to update the test file:
tests/components/device_tracker/test_init.py:466 TestComponentsDeviceTracker.test_new_device_event_fired

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Static variable in Util to hold Civ3Root and FileDialog and button to select it

Could we add a check so that it only adds the link on the main page if the install location cannot be auto-detected via the Windows Registry?  It looks strange having "Select Civ3 Home Folder" display right over the top of the Tower of Babble PCX file.
I'm rebuilding my Linux VM currently, so I haven't tested it there yet.  Looks plausibly correct though.

So I realized that you are trying to hide it if it's already detected, i.e. if DisplayTitleScreen goes according to plan.  Thus, why was I seeing it?  I noticed it was printing the "Could not set up the main menu" message despite the main menu being clearly visible, so I added a , ex to that message so it printed the error.  It printed:
  at MainMenu.DisplayTitleScreen () [0x0013a] in C:\Development\Civ Related Projects\Prototype\C7\MainMenu.cs:57```

After adding a few prints, line 57 was `SetCiv3Home.Visible = false;`

So, it seems like for some reason the DisplayTitleScreen method doesn't have proper access to SetCiv3Home.  Not sure why yet.

Huh, weird. I can replicate the issue on my Windows box. Checking into it. I don't see an access issue as it's a method in the class where the button is defined, and it doesn't freak out on build. But something is happening here....

Ok, fixed it. The button reference was getting assigned after the first DisplayTitleScreen run, so it doesn't exist if the menu succeeds the first time.

Made another commit. The first run of DisplayTitleScreen() didn't need the tailing initialization, but it hit me that it made no sense for DisplayTitleScreen() to not be at the very end of _Ready() lest we stub our toe on something like this again in the future. No reason to run code until the init is finished.


Request for documentation

I am working on a Block that fetches remote content from a JSON feed (this is interesting for pre-filling newsletters).

I am doing this here in this github repo:
https://github.com/woutersf/grapesjs-block-drupal-content-feed
It is not clear for me how I should make this (custom) block configurable.
If users want for example to render the content in different html (in columns for example).
Is there a possibility to ad an overlay of sorts with configuration or should I configure this externally and add it to the plugin options?

This could be achieved by creating a custom component


Add support for private catalog

Address #13371

support http/s helm catalog server with basic auth.
support git clone for private repo with username and password(access token).

Types PR: rancher/types#599
UI Issue: https://github.com/rancher/rancher/issues/16244

@vincent99 should we put username and password into a seperate resource like catalogCredential? or is it fine to just put it into catalog api.

@StrongMonkey the PR is updated with using FrogetError to stop back off.
@vincent99 @alena1108 @cjellick as what daishan mentioned above should we put username and password into a separate resource like catalogCredential?

@StrongMonkey the types PR is in https://github.com/rancher/types/pull/599, and I have addressed some feedbacks in the above, can you please help to review it, thanks.

LGTM

also @guangbochen can you squash your commits? once type is merged you should have two commits, one for rancher changes and one for updating vendor.

squshed and updated, thanks.


pythonDocs: 3.7 -> 3.10

Also include texinfo docs for Python 3 (they aren't generated for Python 2)
A few minor fixes had to be made to generate.sh as well.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Follow up to switch back to pname+version #192648

This broke eval, need to quote the URLs.

I'm on that already.

Merged as https://github.com/NixOS/nixpkgs/pull/192716


Make tutorial pop-up less frequent

Determine if the pop-up can "remember" if a user has already done the tutorial , or can we add a "Don't show me this again" check box

Can we track the user and know if they have already viewed the tutorial, and in that case can we make the pop-up no longer appear when backing out of one of the block sets,
If the user can't be tracked, can we add a " Don't show me the again" check box at the bottom of the pop-up
we will need to provide a link to the tutorial under the User puck so users can find the tutorial at any point
see here fro more info:
https://miro.com/app/board/uXjVKAZKZ84=/?moveToWidget=3458764591597167180&cot=14
Acceptance criteria:
The user is no longer given the option to view the tutorial as frequently.
the user can navigate to the tutorial at any point from the user "puck"


Not able to make flutter build apk --release in MacOS X

I want to export the apk in release mode of my flutter app the problem is that when I try i finally get the following issue, that don't let me create it. It's curious since i can create the APK in --debug and it works great.
flutter build apk
You are building a fat APK that
includes binaries for android-arm,
android-arm64.
If you are deploying the app to the
Play Store, it's recommended to use app
bundles or split the APK to reduce the
APK size.
To generate an app bundle, run:
flutter build appbundle
--target-platform
android-arm,android-arm64
Learn more on:
https://developer.android.com/g
uide/app-bundle
To split the APKs per ABI, run:
flutter build apk
--target-platform
android-arm,android-arm64
--split-per-abi
Learn more on:
https://developer.android.com/s
tudio/build/configure-apk-split
s#configure-abi-split
Initializing gradle...                                              4.0s
Resolving dependencies...                                          17.3s
Running Gradle task 'assembleRelease'..                                       registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
Running Gradle task 'assembleRelease'..                                       registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
Running Gradle task 'assembleRelease'..                                       registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
Running Gradle task 'assembleRelease'..
Running Gradle task 'assembleRelease'..                                       FAILURE: Build failed with an exception.
Running Gradle task 'assembleRelease'..
Running Gradle task 'assembleRelease'..                                       * What went wrong:
Running Gradle task 'assembleRelease'..                                       Execution failed for task ':app:validateSigningRelease'.
Running Gradle task 'assembleRelease'..                                       > Keystore file '/Users/jumpbotron/Documents/programming/projects/safer/android/app/ââ¨Usersâ©/â¨jumpbotronâ©/â¨Documentsâ©/key.jks' not found for signing config 'release'.
Running Gradle task 'assembleRelease'..
Running Gradle task 'assembleRelease'..                                       * Try:
Running Gradle task 'assembleRelease'..                                       Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
Running Gradle task 'assembleRelease'..
Running Gradle task 'assembleRelease'..                                       * Get more help at https://help.gradle.org
Running Gradle task 'assembleRelease'..
Running Gradle task 'assembleRelease'..                                       BUILD FAILED in 7s
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                       8.0s
Gradle task assembleRelease failed with
exit code 1
Thank you very much

I have seem that  apparently there is a problem at the key.jks route (it has some weird symbols), even though everything is fine at the file

This is the reason
Running Gradle task 'assembleRelease'.. > Keystore file '/Users/jumpbotron/Documents/programming/projects/safer/android/app/ââ¨Usersâ©/â¨jumpbotronâ©/â¨Documentsâ©/key.jks' not found for signing config 'release'.
```
it seems you haven't created a release keystore.
See https://flutter.dev/docs/deployment/android


Default projects to private

Notes on optional 2nd commit:
Felt that the empty checkbox causes unnecessary worry at point in the process where a user probably needs to write the description and organise datasets before making the project public. A note provides instructions on where/how to find the setting after the project is created.

Added some help text:

Corresponding update to the settings tab, showing the published project case:


No outgoing EOG edge for ThrowStatement without type of error.

In #1741 I realized that there's an issue if there's no type of the throw statement and the throw statement has no outgoing EOG edges. We should define a behavior in this case and ideally test it. See de.fraunhofer.aisec.cpg.frontends.python.statementHandler.ExceptionsTest.testEmpty

We should also check if we can match the catches based on subtypes/supertypes


OS X: Clicking tray icon quickly several times causes context menu to stop opening

I noticed that on OS X, clicking the tray icon quickly several times sometimes does not open the context menu. One can then continue clicking the icon, and the highlight and pressed image will toggle, but no tray menu will show at all, except the pressed image is shown when there is no highlight (and vice versa).
I did not attach any click listeners.
Here is a screenshot taken of the tray icon after clicking several times, the icon is highlighted but no context menu is shown, and the pressed image is not used as it should be. It remains in this state even after clicking elsewhere and focusing another application in the OS.

Other native tray icons toggle the context menu correctly, even after many successive clicks.

clicking the tray icon quickly several times sometimes does not open the context menu.

If clicking the tray icon too quickly, it will be regarded as double-click event, which explains why the context menu is not shown. I think it cannot be fixed due to the limitation of current implementation.

Here is a screenshot taken of the tray icon after clicking several times, the icon is highlighted but no context menu is shown, and the pressed image is not used as it should be. It remains in this state even after clicking elsewhere and focusing another application in the OS.

Which OS X version are you using? I could not reproduce it on OS X 10.10.4, even I clicked the tray icon many times.

Thanks for your help @hokein.

If clicking the tray icon too quickly, it will be regarded as double-click event, which explains why the context menu is not shown. I think it cannot be fixed due to the limitation of current implementation.

It would be great if Electron could then still keep the highlight and pressed icon in sync. That is, if a double-click event happens, the icon should not be highlighted and should not display the pressed icon.
I am using OS X 10.10.5. I just need to click the tray icon very quickly a few times to reproduce it easily.

Just to add, sometimes when I reproduce it, the pressed icon and highlight is shown, but without the context menu. Here is another screenshot:

Here is another screenshot, where clicking the tray icon again after the previous screenshot, causes the menu to show, but now the pressed image is not used as should be the case (should be a white plus).

Here it is again in another state, this time not pressed but highlighted.

Clicking again, and now the menu shows with highlight and correct pressed image:

Thanks @zcbenz and @hokein!