TS error Excessive stack depth comparing types when trying to wrap $fetch

Environment

Operating System: Darwin
Node Version:     v16.15.1
Nuxt Version:     3.0.0-rc.8
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      runtimeConfig, css, vite, typescript, modules, unocss
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
export const wrappedFetch: typeof $fetch = (request, opts?) => $fetch(request, opts)
wrappedFetch.raw = (request, opts?) => $fetch.raw(request, opts)

Describe the bug
In Nuxt 3.0.0-rc.8, when trying to wrap the $fetch method in a custom method with the same type signature (to set default options for example), typescript throw an Excessive stack depth comparing types error, forcing me to add // @ts-ignore on the line before.
This only happens for $fetch. useFetch can be wrapped without errors.
Is it normal ?
Additional context
No response
Logs
No response

The problem seems caused by method attribute in NitroFetchOptions type definition from nitropack package.
interface NitroFetchOptions<R extends NitroFetchRequest> extends FetchOptions {
    method?: Uppercase<AvailableRouterMethod<R>> | AvailableRouterMethod<R>;
}

interface $Fetch<DefaultT = unknown, DefaultR extends NitroFetchRequest = NitroFetchRequest> {
    <T = DefaultT, R extends NitroFetchRequest = DefaultR, O extends NitroFetchOptions<R> = NitroFetchOptions<R>>(request: R, opts?: O): Promise<TypedInternalResponse<R, T, ExtractedRouteMethod<R, O>>>;
    raw<T = DefaultT, R extends NitroFetchRequest = DefaultR, O extends NitroFetchOptions<R> = NitroFetchOptions<R>>(request: R, opts?: O): Promise<FetchResponse<TypedInternalResponse<R, T, ExtractedRouteMethod<R, O>>>>;
    create<T = DefaultT, R extends NitroFetchRequest = DefaultR>(defaults: FetchOptions): $Fetch<T, R>;
}

@pi0 can you take a look at this please? Can still reproduce in latest versions.

Still having this issue with:
import type { AvailableRouterMethod, NitroFetchRequest, NitroFetchOptions } from 'nitropack';

const $fetchApi = async <
  ResT = void,
  ReqT extends NitroFetchRequest = NitroFetchRequest,
  Method extends AvailableRouterMethod<ReqT> = ResT extends void ? 'get' extends AvailableRouterMethod<ReqT> ? 'get' : AvailableRouterMethod<ReqT> : AvailableRouterMethod<ReqT>
>(
  req: ReqT, opts?: NitroFetchOptions<ReqT>
)

Same here, problem still present:
const result:CasirestToken = await $fetch(settings.casirest.dev.endpoint + '/tokens', {
	method: 'POST',
	headers: {
		'X-API-Key': settings.casirest.dev.apikey
	},
	body: creds
});
console.log(result);

/cc @danielroe

It is the same when trying to do with useFetch or useAsyncData.
For those who stuck with useFetch, I managed it as this:
export const useFetchApi = <T>(
  ...[request, options]: Parameters<typeof useFetch<T>>
): ReturnType<typeof useFetch<T>> => {
  return useFetch<T>(request, {
    ...options,
    async onRequest({ options }) {
      const accessToken = await useAuthStore().getAccessToken()

      if (accessToken) {
        const headers = new Headers(options.headers)

        headers.set('Accept', 'application/json')
        headers.set('Authorization', `Bearer ${accessToken}`)

        options.headers = headers
      }
    },
  })
}

When using Nuxt, this is resolved by using an own tsconfig.json for the server folder:
{
  "extends": "../.nuxt/tsconfig.server.json"
}

Finally found this workaround if anyone is interested :
import type {
  NitroFetchRequest,
} from "nitropack";

export function $api<
  T = unknown,
  R extends NitroFetchRequest = NitroFetchRequest
>(
  request: Parameters<typeof $fetch<T, R>>[0],
  opts?: Partial<Parameters<typeof $fetch<T, R>>[1]>
) {
  return $fetch<T, R>(request, {
    onResponseError: async ({ response }) => {
      console.log(response);
    },
    ...opts,
  });
}

having the same issue with that code:
`const { data: cities, error: cityError } = await useAsyncData(
"posts",
() =>
// @ts-ignore
$fetch("/api/tool/data/city/", {
query: { departmentcode: departmentsSelect.value?.code },
}),
{
immediate: false,
watch: [departmentsSelect],
}
);
if (cityError.value) {
errorsHandler(cityError.value);
}`

having the same issue with that code:
const { data: cities, error: cityError } = await useAsyncData(
  "posts",
  () =>
    // @ts-ignore
    $fetch("/api/tool/data/city/", {
      query: { departmentcode: departmentsSelect.value?.code },
    }),
  {
    immediate: false,
    watch: [departmentsSelect],
  }
);

if (cityError.value) {
  errorsHandler(cityError.value);
}

my error:

For this scenario, have you tried using useFetch instead of useAsyncData ? You can pass query parameters too.

having the same issue with that code:
const { data: cities, error: cityError } = await useAsyncData(
  "posts",
  () =>
    // @ts-ignore
    $fetch("/api/tool/data/city/", {
      query: { departmentcode: departmentsSelect.value?.code },
    }),
  {
    immediate: false,
    watch: [departmentsSelect],
  }
);

if (cityError.value) {
  errorsHandler(cityError.value);
}

my error:

For this scenario, have you tried using useFetch instead of useAsyncData ? You can pass query parameters too.

yes I tried. Same error

@jervalles try this:
    $fetch<unknown>("/api/tool/data/city/", {
      query: { departmentcode: departmentsSelect.value?.code },
    }),

Worked for me on Nuxt.

finally I wrap $fetch
// types/index.d.ts

type FetchSchemaApi<DefaultApiResponse = unknown> = {
  statusCode: number
  data: DefaultApiResponse
}

declare module 'nitropack' {
  interface $Fetch<DefaultT = unknown, DefaultR extends NitroFetchRequest = NitroFetchRequest> {
    <T = DefaultT, R extends NitroFetchRequest = DefaultR, O extends NitroFetchOptions<R> = NitroFetchOptions<R>>(request: R, opts?: O): Promise<TypedInternalResponse<R, FetchSchemaApi<T>, ExtractedRouteMethod<R, O>>>;
    raw<T = DefaultT, R extends NitroFetchRequest = DefaultR, O extends NitroFetchOptions<R> = NitroFetchOptions<R>>(request: R, opts?: O): Promise<FetchResponse<TypedInternalResponse<R, FetchSchemaApi<T>, ExtractedRouteMethod<R, O>>>>;
    create<T = DefaultT, R extends NitroFetchRequest = DefaultR>(defaults: FetchOptions): $Fetch<FetchSchemaApi<T>, R>;
  }
}

Im on Nuxt 3.9.1 and Vue 3.4.5, I have this error when I use $fetch inside a function.

const debounceFn = useDebounceFn(async () => {
  results.value = await $fetch('/api/address/search', {
    query: {
      q: temp.value,
    },
  })
}, 750)

If I move $fetch outside, it doesn't complain

results.value = await $fetch('/api/address/search', {
  query: {
    q: temp.value,
  },
})

Have the same problem when using $fetch. Strangely I can't seem to reproduce it in a minimal reproduction, so it might have something to do with a large return type or the Nuxt project structure I have. Using Nuxt 3.11.2.

Yes, this issue is happening in big projects.
The only workaround I found and using for now is to specify certain return type:
$fetch<{
  item: ISomeItemType
  ...
}>(...)

Using the latest Nuxt 3.11.2

have same issue :(

workaround by @kenhyuwa work for me
Nuxt project info:                                                                                07:58:42

------------------------------
- Operating System: Windows_NT
- Node Version:     v20.7.0
- Nuxt Version:     3.11.2
- CLI Version:      3.11.1
- Nitro Version:    2.9.6
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      typescript, devtools, app, build, modules, cron, pinia, experimental, auth
- Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

This issue is still present. The workaround of providing a type to $fetch(), like $fetch<myType>() works, but of course this isn't ideal because we lose automatic type inference. This seems to point towards this automatic inference somehow tripping typescript.
I have tried again and again to reproduce this issue in a minimal app but it just doesn't show up there. It also only shows up for routes of a specific route folder. These routes do deal with numerous deep types inside them, returning large complex JSON data.
I am well aware that this is very difficult to fix if you can't make the error appear anywhere on your end, so it seems we're stuck providing the type hint ourselves for the time being.

this "Excessive stack" error comes and goes, but it's more likely to happen with default GET requests.
Explicitly setting method: 'GET' seems to resolve the issue.
Steps to Reproduce:
/server/api
  └── /something
        ├── index.get.ts
        └── [id].put.ts

Make a default GET request using $fetch, then another request with a different method (e.g., PUT) with param:
const getSomething = $fetch('/api/something')  // Likely to cause "Excessive stack" error
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

How I got rid of it:
const getSomething = $fetch('/api/something', { method: 'GET' }) // Explicitly setting GET
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

this "Excessive stack" error comes and goes, but it's more likely to happen with default GET requests. Explicitly setting method: 'GET' seems to resolve the issue.
Steps to Reproduce:
/server/api
  └── /something
        ├── index.get.ts
        └── [id].put.ts

Make a default GET request using $fetch, then another request with a different method (e.g., PUT) with param:
const getSomething = $fetch('/api/something')  // Likely to cause "Excessive stack" error
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

How I got rid of it:
const getSomething = $fetch('/api/something', { method: 'GET' }) // Explicitly setting GET
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

It doesn't seem to solve the issue when trying to wrap $fetch, at least not on my end.

this "Excessive stack" error comes and goes, but it's more likely to happen with default GET requests. Explicitly setting method: 'GET' seems to resolve the issue.
Steps to Reproduce:
/server/api
  └── /something
        ├── index.get.ts
        └── [id].put.ts

Make a default GET request using $fetch, then another request with a different method (e.g., PUT) with param:
const getSomething = $fetch('/api/something')  // Likely to cause "Excessive stack" error
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

How I got rid of it:
const getSomething = $fetch('/api/something', { method: 'GET' }) // Explicitly setting GET
const putSomething = $fetch(/api/something/${id}, { method: 'PUT' })

For me still happens, despite I have method defined.

Same for me, whether I try to wrap $fetch or not, and whether I explicitly set the method or not. It happens with Prisma so I suspect the type are indeed to complex to be inferred.

Same for me, whether I try to wrap $fetch or not, and whether I explicitly set the method or not. It happens with Prisma so I suspect the type are indeed to complex to be inferred.

Yes, it happens mostly because the types are complex to be inferred, or because there's lots of routes.
This should be optimized somehow, is annoying always having that error everywhere.

Same for me. I have a simple login endpoint that super simple login endpoint returns { redirectTo: string }.
I made a composable around $fetch to handle form validation and BadRequest errors with Zod. Here my code for it:
/**
 * An helper function that is used to fetch data from the server and handle validation
 * errors. It is used in conjunction with the useForm composable.
 *
 * @param fetcher A function that fetches data from the server, most likely using $fetch
 * @param form The form context object from vee-validate
 * @returns A promise that resolves to the data if the fetch was successful, or rejects with an error object
 */
export const useFormFetch = async <T>(
  fetcher: () => Promise<T>,
  form: FormContext
): Promise<Result<T, typeToFlattenedError<T>>> => {
  try {
    const data = await fetcher();
    useFormError(form).clearErrors();
    return { success: true, data };
  } catch (error: any) {
    if (error.data.statusCode !== 400) {
      throw error;
    }

    const errors = error.data.data.errors as typeToFlattenedError<T>;

    useFormError(form).setErrors(errors);

    return { success: false, error: errors, };
  }
};

And here's how I use it:
const onSubmit = form.handleSubmit(async (values) => {
  const result = await useFormFetch(
    () => $fetch('/api/auth/login', { method: 'POST', body: JSON.stringify(values) }),
    form
  );
});

const getSomething = $fetch('/api/something', { method: 'GET' }) // Explicitly setting GET

This either does nothing or somehow causes the vscode to just stop marking the type error, effectively silencing the typecheck. I didn't even notice it at first, thought this workaround succeeded.
And also for some reason IDE lies about the $fetch's awaited return type?

There's another workaround suitable for some cases: using an intermediary const. Infers types, marks errors. Name it data or result and it won't hurt eyes too much.


Updated a lot of ->pull() functions to ->offsetSet().

Also fixed some Repositories that had $class instead of $part, thus failing when using ->fetch($id) on them.

I also added checks on message update, sendMessage, etc.. to see if the user has 'storeMessages' as true before storing. Before it would just store those messages, so every Message Update would store a message, resulting in unwanted ram usage. (It would store duplicates as well)
Basically, this entire update removes duplicates in EVERYTHING.
$discord->users went from 130+ to just 41 after applying this update, 30 of the 130+ was just my account!
https://nig.tools/3dyns508.txt (130+) to https://nig.tools/hi1zp80f.txt (41)
Also applyed a fix on ->isSpeaking() in the Voice.php, added $embed support to $channel->sendFile(), added a check to see if user is a bot before making an application, ability to update a message's embed (add an embed or edit an embed), removed ->sendFile() from guzzle.php, changed some repositories so ->fetch() actually works on them (changed $class to $part on their file, and added, in ->fetch(), if ['guild_id'] exists, add it in (since ->fetch() on a members repository doesn't return guild_id when you require it to make a member)), and probably some more stuff.
(also $state->user_id, not $state->id in VoiceStateUpdate)
OVERALL IMPROVEMENTS, I RECOMMEND!

I added more fixes, replaced ->get('id', $id) with ->offsetGet($id) so it uses less processing power? idk lol

Updated it more (I also added the ability of the guild filling it's emoji repository, which was not the case before)

This PR actually reduce the memory leak (cf #174) from 60% than before. That's a very good new, keep it up. :+1:


Plugin should advertise version and features in HTCondor machine ads

Pelican Service:

[ ] Client
[X] Plugin
[ ] Registry
[ ] Director
[ ] Origin
[ ] Cache
[ ] Other (please give the detail)

HTCondor 23.7.1 is expected to add a feature that will let file transfer plugins advertise arbitrary classad attributes, as described in this ticket: HTCONDOR-1051.  OSPool currently advertises the plugin version by hand (in the OSDF_PLUGIN_VERSION and STASH_PLUGIN_VERSION attributes), but it would be nice if the plugin itself did that for us.
In addition, the plugin could advertise the availability of certain features.  For example, the ?recursive=true feature was added in 7.7.0, so a user wanting to use that feature needs to land on a machine with plugin version >= 7.7.0.  It would be nicer if the user didn't have to remember the specific version and could just put the feature in their requirements.
Strawman example: add this to the output of condor_stash_plugin -classad:
StartdAttrs = "OsdfPluginVersion, OsdfPluginFeatures"
OsdfPluginVersion = "7.8.0"
OsdfPluginFeatures = "pack, recursive"

I tagged this for 7.9.0 since HTCondor 23.7.1 is going to be released in early May, which would not let you test it in time for 7.8.0.

@matyasselmeci At the moment, here's what I see:
[brian.aydemir@ap40 ~]> condor_status -af PelicanPluginVersion | sort -u
7.10.1
7.10.9
7.11.2
undefined

It looks like @joereuss12 added that attribute in #1113.
Is there a less-strawman/more-official example of what you're looking for? I'm guessing it's easy enough to update cmd/plugin.go.

We didn't really discuss this feature so I'm not aware of more official examples than what I put in the description.
I think PelicanPluginVersion is enough for now; there hasn't been any demand for matching against features so I'm fine with putting that on hold and closing this ticket.


[BUG] GpuRegExpReplaceWithBackref with empty string input produces incorrect result on GPU in Spark 3.1.1

Describe the bug
There is a difference in behavior between Spark 3.1.1 and 3.3.2 when evaluating a regexp_replace against an empty string, but we do not currently respect this difference when running on GPU.
Spark 3.1.1 CPU
scala> spark.conf.set("spark.rapids.sql.enabled", "false")

scala> spark.sql("select REGEXP_REPLACE('', '.*$', 'PROD', 1)").show()
+------------------------------+
|regexp_replace(, .*$, PROD, 1)|
+------------------------------+
|                              |
+------------------------------+

Spark 3.3.2 CPU
scala> spark.conf.set("spark.rapids.sql.enabled", "false")

scala> spark.sql("select REGEXP_REPLACE('', '.*$', 'PROD', 1)").show()
+------------------------------+
|regexp_replace(, .*$, PROD, 1)|
+------------------------------+
|                          PROD|
+------------------------------+

The current GPU behavior is consistent with Spark 3.3.2.
Steps/Code to reproduce bug
See above.
Expected behavior
We should produce the same result as CPU on all Spark versions.
Environment details (please complete the following information)
Local workstation
Additional context

This was fixed in https://github.com/NVIDIA/spark-rapids/pull/8433


Add Presto Aggregate bitwise_xor_agg

Description
Presto is adding new agg function: bitwise_xor_agg(by myself): https://github.com/prestodb/presto/pull/20939, I'd like to add the same function to velox too after it is merged.

@xumingming Sounds good. Maybe use simple UDAF framework for this function. See example in https://github.com/facebookincubator/velox/pull/6470


Update README.md (for God's sake!)

I've updated the README and made the details more laconic.

Hi,
Will you merge this anytime soon?
Thanks,
@aliazam


Is there an API that can capture a screen shot of a rendered bim file?

I tried to implement it myself because it seems that API is not supplied, but it is not easy because it is WebGL based.
Is there an API that can capture a screen shot of a rendered bim file?

Did you look at Viewport.readImage?

Did you look at Viewport.readImage?

It works well.
Thank you for your advice. 👍

Glad to help.
Not a big deal, but please consider using the Discussions page for asking questions (issues are generally intended for tracking "problems").


Use mocks to fix failing tests

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

You should be able to reproduce assuming that something in <App/> is using the withAITracking HOC

import React from 'react';
import ReactDOM from 'react-dom';
import {act} from 'react-dom/test-utils';
import App from './App';

it('renders without crashing', () => {
    const div = document.createElement('div');
    act(() => {
        ReactDOM.render(<App />, div);
    });
    ReactDOM.unmountComponentAtNode(div);
});

Any log messages given by the failure

I have had a unit test commented out for a while now because the withAITracking HOC was throwing an exception...

  ● Test suite failed to run

    TypeError: Object prototype may only be an Object or null: undefined
        at setPrototypeOf (<anonymous>)

      48 | }
      49 |
    > 50 | export default mapContextToProps(contextMap)(withRouter(withAITracking(applicationInsights.reactPlugin, AppTelemetryProvider)));
         |                                                         ^
      51 |

Expected/desired behavior

I notice that this repo is failing its own test for what seems to be a similar reason, this example might be able to fix that
THE FIX
If you're running into this, I've figured out a work around that was not described in this example. You can mock that HOC and the ReactPlugin with Jest so that you can still use your unit tests while using this example. Here is the test for my app:

import React from 'react';
import ReactDOM from 'react-dom';
import {act} from 'react-dom/test-utils';
import App from './App';

jest.mock('@microsoft/applicationinsights-react-js', () => ({
    withAITracking: (reactPlugin, Component) => (<Component/>),
    ReactPlugin: Object
}));

it('renders without crashing', () => {
    const div = document.createElement('div');
    act(() => {
        ReactDOM.render(<App />, div);
    });
    ReactDOM.unmountComponentAtNode(div);
});

Maybe this was pretty intuitive to someone who is better at using jest, but this wasn't an answer I stumbled upon so I figured the best way to help whoever comes next would be to create an issue with my workaround

OS and Version?

Windows 10

Versions

"@microsoft/applicationinsights-react-js": "^2.2.2",
"@microsoft/applicationinsights-web": "^2.2.2",

I submitted a PR to fix this and it was pulled into master so I'll close this issue

I believe a common way to fix this sort of problem is to export your component in two different ways:

Using the default, with the withAITracking wrapping the component
Using a named value without withAITracking wrapping the component

Then in your test you pull in the named value rather than the default


Undefined error when click on error in output channel

Azure Data Studio Version:

[91283:0821/114353.435627:INFO:CONSOLE(2280)] "%c  ERR color: #f33 Cannot read property 'element' of undefined: TypeError: Cannot read property 'element' of undefined
at ErrorMessageDialog.open (file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/services/errorMessage/browser/errorMessageDialog.js:109:34)
at ErrorMessageService.doShowDialog (file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/services/errorMessage/browser/errorMessageService.js:34:38)
at ErrorMessageService.showDialog (file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/services/errorMessage/browser/errorMessageService.js:25:18)
at TaskHistoryView.onSelected (file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/contrib/tasks/browser/tasksView.js:115:50)
at file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/contrib/tasks/browser/tasksView.js:41:76
at Emitter.fire (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/common/event.js:456:38)
at Emitter.fire (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/common/event.js:459:41)
at TreeModel.setSelection (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/parts/tree/browser/treeModel.js:883:31)
at Tree.setSelection (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/parts/tree/browser/treeImpl.js:155:24)
at TaskHistoryController.onLeftClick (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/parts/tree/browser/treeDefaults.js:131:22)
at TaskHistoryController.onLeftClick (file:///Users/llali-mac/work/azuredatastudio/out/sql/workbench/contrib/tasks/browser/tasksController.js:32:26)
at TaskHistoryController.onMouseDown (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/parts/tree/browser/treeDefaults.js:97:29)
at TreeView.onMouseDown (file:///Users/llali-mac/work/azuredatastudio/out/vs/base/parts/tree/browser/treeView.js:884:37)

Seems intermittent as we we note able to repro for Sept Triage

Closing older issues without recent repro reports.  I couldn't repro on the latest build.  Please reactive if the issue persists.


Move shardscanner workflow tests to the shardscanner package

What changed?

Move existing tests for the shardscanner workflows to be in the shardscanner package.

Why?

Improve code coverage metrics

How did you test it?

Unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018f5495-ff35-464f-adfd-e78b0d8345c5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
50 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.1%) to 68.26%

Files with Coverage Reduction
New Missed Lines
%

common/task/weighted_round_robin_task_scheduler.go
1
89.05%

service/history/task/transfer_standby_task_executor.go
2
87.65%

service/history/shard/context.go
2
68.91%

common/peerprovider/ringpopprovider/config.go
2
81.58%

common/task/fifo_task_scheduler.go
2
85.57%

service/history/task/transfer_active_task_executor.go
2
72.9%

service/history/execution/mutable_state_util.go
2
78.52%

common/persistence/historyManager.go
2
66.67%

service/history/task/fetcher.go
3
85.57%

service/history/execution/mutable_state_task_refresher.go
32
56.65%

Totals

Change from base Build 018f5467-b337-442d-bcf0-8ad761c213c7:
0.1%

Covered Lines:
100260

Relevant Lines:
146880

💛  - Coveralls


tgi: revert xeon version to 2.2.0

Description
Due to bug opea-project/GenAIExamples#636, revert tgi xeon version to 2.2.0.
Issues
opea-project/GenAIExamples#636
Type of change
List the type of change like below. Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Dependencies
n/a.
Tests
Describe the tests that you ran to verify your changes.

The reason why gmc xeon test fails is because the model used by gmc chatqna CI test bigscience/bloom-560m doesn't work with tgi 2.2.0 anymore. We use bigscience/bloom-560m in GMC xeon CI because of bug #258.

note: TGI 2.2.0 cannot work with bigscience/bloom-560m

The reason why gmc xeon test fails is because the model used by gmc chatqna CI test bigscience/bloom-560m doesn't work with tgi 2.2.0 anymore. We use bigscience/bloom-560m in GMC xeon CI because of bug #258.

Whereas 2.0.x & 2.1.x versions regressed TGI Prometheus support so one does not get any token metrics out of them (although they worked fine with TGI 1.x).  That was fixed only in 2.2.0: https://github.com/huggingface/text-generation-inference/issues/2184


chore: ci3

Please read contributing guidelines and remove this line.

nag about not gleaning anything from commit messages

If we do want this just in one command we can organize things with
echo "::group::Foo"
echo "Foo"
echo "::endgroup"

echo "::group::Bar"
echo "Bar"
echo "::endgroup"

as for exit code 137 popping up, we can get this down but this will be tricky if we do want a shared runner, need to do memory accounting, hence why we did isolated runners


[ENHANCEMENT] changed street length from max 60 to 150 characters

CHANGELOG https://github.com/sulu-io/sulu/commit/9aa1e059953e336b2ee0761bf5e99750f2011e59


Configure linters to comply with Drake C++ style

Closes #15. Precisely what the title says. This patch configures ament_cpplint and ament_clang_format linters to match drake's style (pulling in their configuration).

This change is

@IanTheEngineer there's also a clang-tidy configuration in RobotLocomotion/drake, which would need extra steps to be configured here but should be possible.

Rebased to solve conflicts after #17.


adding a new FAQ

This information is already on the website, which is where we are centralizing information on how the community is run.


Candy Store Html, CSS and JavaScript

🛠 Fixes Issue #604

👨💻 Changes proposed
I added a Candy Store project. I created this website while learning web development. I used all the basic concepts of JS in this project and I want to share my project to help other learners to understand the basic concepts of JS.

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
I made this project using HTML, CSS, Bootstrap and JS.
📷 Screenshots
Here you can see complete website: Candy Store

@Astrodevil kindly review my PR. Thank you.

As I can see you have multiple files in html,css & images. You created a folder for html, please do the same for others. Also add your project in cards. json and README.

@Astrodevil all requested changes has been completed, kindly review and merge my PR. Thank you.


make motd use unescaped HTML

As it's passed in via flag via an admin l, it doesn't need to be escaped

Added!


check number for valid format. issue #12

issue #12

It will work only for India.
Different countries have a different phone number length. I am closing the issue, hence closing the PR.


Add tracing attribute for HTTP client tracing

Description

Add tracing attribute for HTTP client tracing
Use pagination on Sensu API events endpoint

Related Issue
N/A
Motivation and Context
Add tooling for additional debug of Sensu APIs errors
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #720 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   21.56%   21.54%   -0.02%
==========================================
  Files          27       27
  Lines        2875     2882       +7
==========================================
+ Hits          620      621       +1
- Misses       2196     2202       +6
  Partials       59       59

Impacted Files
Coverage Δ

uchiwa/logger/logger.go
13.18% <0%> (-0.94%)
:arrow_down:

uchiwa/main.go
41.33% <100%> (+0.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c1fd3...520435e. Read the comment docs.


Consume model / Add to solution: the NAMEs of Model and ConsoleApp projects : it would be useful if it could be SPECIFIED

At the end of the ML.NET Model Builder process: Consume model / Add to solution:
it would be VERY useful if the NAMEs of Model and ConsoleApp projectst could be SPECIFIED.
Why?: if the developer needs two or more Models (Scenarios) in one solution (e.g. one forecasting for X, and another value prediction for Y), it's frustrating if the latest  Model Builder process wants to OVERWRITE the prev. projects.
Recommended solution:
in addition to the existing default solution (Model and ConsoleApp project names come from Solution name):
with one (BASE name and DERIVED Model and ConsoleApp project names) or two input textboxes (two independent  Model and ConsoleApp project names) the user can specify project names.
Péter

@petersesztak This is great feedback! In our next public release we're moving to file based config for Model Builder. This means for your solution you would have two model builder files, forcasting.mbconfig and value.mbconfig for the project. We won't add two complete projects anymore, but specific code files for each solution (and they'd be named forcasting.x and value.x).
You will still be able to add complete sample projects to your app, and if you do we allow you to specify a name:

I think this will solve your problem. We're working on stabilizing this release now. It is available in a private preview build. If you're interested in trying it out I can send those details. Thanks!


KeyError: 'RAT_TOKEN'

Hi guys, need a help!
When i run python RATAttack.py, i have this errors:

python RATAttack.py
Traceback (most recent call last):
File "RATAttack.py", line 35, in
token = os.environ['RAT_TOKEN'] #you can set your environment variable as well
File "C:\Python27\lib\os.py", line 425, in getitem
return self.data[key.upper()]
KeyError: 'RAT_TOKEN'

so my telegram bot does not respond :( sos, pls help

This issue is already solved

tnx, for ur response. could u give a link for solution? tnx in advance

#token = os.environ['RAT_TOKEN']
Comment # helped me

and another question sir, for the chat id, is it possible to use my own id, not group id?

@Ubop0202 I don't understand the question. You can't choose an ID, it's assigned to you from Telegram.


Cocoapods and Templates

It is possible to integrate a own template with cocoa pods integration of Swiftgen? When I use Swiftgen via brew installation then it's possible to integrate owned templates. But when I would use via Cocoapods, Swiftgen can't find my template.

What is the command you're using in your build phase especially the path to your templates?

Ping @AFcgi ?

Sorry for my late reply. I use the --template option to integrate my template from ~/Library/Application Support/SwiftGen/templates path. The same path doesn't work with the cocoa pods integration.

I solved the problem.

Cool! Care to share the solution in case anyone have a similar issue? Thx!

I try --templatePath "$PROJECT_DIR/xxx.stencil" and it works fine.


feat: make possible to use SDK in React

make tsconfig.json more compactible with browser builds
move fs.openAsBlob to example
add missing dep

Awesome and than you, going to merge this into a new branch for feature/react-compatible and run through the changes and merge it in.


feat: support statement tags in comments in Connection API

Adds support for supplying statement tags as comments in the Connection API. This enables the use of statement tags in frameworks that only support SQL options.

Replaced by #3005


docs: remove examples directory in favor of docs page

Summary
Removes the examples directory in the repo in favor of the example code page in our documentation, which is more actively maintained.

https://docs.unstructured.io/examplecode/notebooks

Think the failure might just be the ingest tests being finicky. Will re-run and investigate if it's still failing.

@MKhalusova  - Test failure looks like out of date creds. Connector crew is working on updating that, but I've disabled it in the meantime.


Shape shift & ELk logo

Here is the link to the FOX & ELK icon.
FOX icon
ELK icon

@MoeNick I think we can close this.


ntr: detoxification of furfural

standard def
parentage "cellular detoxification"
PMID: 25656103

furfural?

yep

https://www.ebi.ac.uk/chebi/searchId.do?chebiId=34768
I think fufural sounds delightful though
On Jun 14, 2017 10:14, "Val Wood"<EMAIL_ADDRESS>wrote:

yep
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/13648#issuecomment-308444482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADGOUeRkIzaRotmBjMY1XPWz50YpGauks5sD-rEgaJpZM4N41Qs
.

@ValWood
It looks like there are already some annotations from this paper to GO:1901426 'response to furfural'.
http://amigo.geneontology.org/amigo/reference/PMID:25656103
As well as annotations from another paper:
migo.geneontology.org/amigo/reference/PMID:25656244
We could make the detoxification term a part_of the response to furfural and then check with SGD about what term they would prefer to use for their annotations?

Yes make the detoxification part_of the response to term. Then I'll contact SGD. I'm trying to normalize the unknowns between the 2 yeasts with a biologically relevant slim (and this doesn't include "response to" which could be cellular role....
cheers
val

Hi @vanaukenk  could we add this one. I'll ask SGD to migrate down when it's in place.

I'm trying to group the set of enzymes involved in detoxification so that we can  use as a "test set" for machine learning type processes to align the unknowns with exisiting bins. I think most of the pombe unknowns are detoxification but I don't have a good  "positive test set" to look for correlations with.

Maybe there should be a general
"detoxification of cellular aldehydes" term?
I have another "unknown" where the yeast ortholog is recently characterised
https://github.com/pombase/curation/issues/1721
"YKL071W from Saccharomyces cerevisiae encodes a novel aldehyde reductase for detoxification of glycolaldehyde and furfural derived from lignocellulose."
PMID: 29034432
so if we had
detoxification of  cellular aldehyde
-- GONEW detoxification of  furfural
-- GONEW detoxification glycolaldehyde
-- GO:0046294  formaldehyde catabolic process (which is under cellular detoxification)

also PMID:28265724
There might be a better way to do "detoxification"?
MF part of "cellular detoxification"? (ignoring specific compound in process)
or a general compound-type process grouping  (cellular aldehyde) rather than every chemical.
Happy for any solution....

Is it possible to get this  one? I can use
" detoxification of cellular aldehyde" for 3 pombe  orthologs.
I'm trying to tidy the unknows as part of a publication.
SGD have not annotated YKL071W yet, I pinged their helpdesk.
Let me know if there is an issue,
thanks
Val

Hi @vanaukenk ,
is it possible to add
"detoxification of cellular aldehyde"
I wan't to use for an analysis...
thanks
val

Hi @vanaukenk
is it possible to add this term (should be quick?), it's a blocker for my "unknowns" project and I'd like to get this wrapped up over the holidays so that I can move back to finishing the matrix paper in the new year.)
cheers,
val

note to self,
also "old yellow enzyme"

@ValWood - sorry for the delay with this one.
Shall I add:
GO:1990748 cellular detoxification
-is_a GO:new cellular detoxification of aldehyde
GO:1901701 cellular response to oxygen-containing compound
-is_a GO:new cellular response to aldehyde
-_part_of GO:new cellular detoxification of aldehyde

@ValWood - when you get a chance, just let me know if the proposal above makes sense and works for you.  Thx.

looks great! thanks.
v


AMD GPU through Portainer

Question:
Has anyone been able to get an AMD GPU to be added to Portainer successfully? If so, what did you do, what environment vars did you put in?  I've already made my device available and I have all the drivers needed installed. Thanks in advance.

@Dvalin21
Can you post the following:
[1] Version of Portainer
[2] Is this Portainer Server Docker Local?
[3] Is this Portainer Server with Docker Standalone Agent?
[4] Screenshots
[5] Reproduction Steps
You could also post this question in our Community Slack here:  https://join.slack.com/t/portainer/shared_invite/zt-190q9nm5v-uT0p0WFkn~K1yv2QlnHJNQ
Note:  I have not setup an AMD GPU, just Nvidia.  I will further investigate deploying.  Updates to follow.
Thanks!

@Dvalin21
Can you post in our Community Slack for further visibility?
https://join.slack.com/t/portainer/shared_invite/zt-190q9nm5v-uT0p0WFkn~K1yv2QlnHJNQ
Thanks!


[occm] recreate load balancer pool on protocol mismatch

What this PR does / why we need it:
Previously adding the proxy-protocol annotation after the pool got
created did not change anything. With this fix changing the annotation
also recreates the load balancer pool because the protocol of a pool
can't get changed via an update call.
Which issue this PR fixes(if applicable):
fixes #1167
Special notes for reviewers:

Release note:

Fixed a bug that prevented a load balancer pool from getting re-created when adding or removing the `loadbalancer.openstack.org/proxy-protocol` annotation or changing the protocol on another way.

Christian Schlotter , Daimler TSS GmbH,
Imprint

/ok-to-test

@zetaab do you maybe have some time to take another look at it? :-)

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.19

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

/lgtm
/override openlab/cloud-provider-openstack-acceptance-test-lb-octavia
/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.18

BTW, I've changed the Release note to make it more clear and readable.

@jichenjc @raminen Could any of you please review this PR?

/approve


[fea-rs] Tweak ligature sort order

Discussed in chat; this adopts a simple common sorting method for ligatures.
The sorting of ligature substitutions for a given glyph is surprisingly contentious. The spec says that the implementation should sort the input such that longer ligatures are applied first, but this means there is no way for the user to indicate that a given ligature should be prioritized over another.
This tweaks our implementation to try and address both concerns: we will now ensure that longer ligatures are first, but for ligatures of equal length we will respect the order provided by the user.
This tweaks a few of the 'expected_diff' files for the fonttools tests, as our behaviour is now different from fonttools in a new way; but the expectation is that fonttools will adopt this new sorting behaviour as well, and then everyone will be happy forever.
see https://github.com/fonttools/fonttools/issues/3428 & https://github.com/adobe-type-tools/afdko/issues/1727#issuecomment-1906703943

I can confirm that after applying this and https://github.com/fonttools/fonttools/pull/3429, I no longer see differently ordered ligatures when ttx_diff'ing Oswald built with fontc vs fontmake


HBASE-25420 Some minor improvements in rpc implementation

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
checkstyle
1m 35s
master passed

+1 :green_heart:
spotbugs
3m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
checkstyle
0m 29s
hbase-client: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)

+1 :green_heart:
checkstyle
1m  7s
hbase-server: The patch generated 0 new + 10 unchanged - 10 fixed = 10 total (was 20)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

44m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2792

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 7e870a687e6f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f600856a3b

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

+1 :green_heart:
shadedjars
6m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-client in the patch passed.

+1 :green_heart:
unit
132m 18s
hbase-server in the patch passed.

163m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2792

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b1ffc912ffea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f600856a3b

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/testReport/

Max. process+thread count
4601 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
1m 24s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 30s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  7s
hbase-client in the patch passed.

+1 :green_heart:
unit
139m  6s
hbase-server in the patch passed.

168m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2792

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d79f5eb44b1f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f600856a3b

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/testReport/

Max. process+thread count
4019 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2792/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


runInterval not beeing respected during document changes

Hello,
as mentioned in #67, I use the ruby interpreter with the digram extension to generate my documents. I know this is a very expensive process due to the external calls. However, I observe that for every keystroke (even with refresh_interval set to e.g. 5000ms) a new process is spawned. I would hope for some kind of throttling by managing the queue of re-renders.
[update]: I can confirm that this is not happening with the 0.5.0 version, but with the latest 0.7.1

Will be fixed in 0.7.2, but please be aware that the setting was also changed to "runInterval" (broken on 0.7.1).

0.7.2 was published, thanks for reporting the issue, it was really severe for large documents.

@joaompinto LOL, I copied the variable name from the code and not from my config. The bug was right before my 👀.

@joaompinto ok, looks good even with runInterval = default
Thanks for the quick fix.


Added Precision & Recall Metrics with average and threshold parameter

Description
Brief Description of the PR:
Fixes # (issue)
Type of change

[x] New Metric and the changes conform to the metric contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[x] By running Black + Flake8
[x] By running pre-commit hooks

[x] I have made corresponding changes to the documentation

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@marload @ssaishruthi
You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

do I have to take any action to push this forward!

I think this component is orphan. Are you interested to be a codeowner?

Yes, I will be interested.

@minesh1291 Before we change the codeowner can you open a ticket in https://github.com/keras-team/keras
So we could check if they are interested to maintain your PR there.

Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


review/jm-initial

This PR serves as the initial review of the Twilio Source package. Please read through the comments and address them individually. Please do not resolve the comments as I will be sure to close them during my re-review. All changes should be made to the main branch. This branch is not intended to be merged.

@fivetran-reneeli thanks for replying to my initial comments. I just went through and replied to your comments. There are some where additional changes need to be made. Let me know once those are updated. Thanks.


"Microsoft Rule Package." unable to export

After creating new rule packages I'm unable to export the built-in labeled   "Microsoft Rule Package."
PS C:\Users\xxxxx> Get-DlpSensitiveInformationTypeRulePackage

Invariant Name         Localized Name         Publisher             Encrypted Exportable
--------------         --------------         ---------             --------- ----------
Microsoft Rule Package Microsoft Rule Package Microsoft Corporation False     True
AdamCustomRulePack2    AdamCustomRulePack2    Adam                  False     True
Adam CustomRulePack    Adam CustomRulePack    Adam                  False     True

> > PS C:\Users\xxxxxx> $ruleCollections = Get-DlpSensitiveInformationTypeRulePackage -Identity "Microsoft Rule Package"
> > The operation couldn't be performed because object 'Microsoft Rule Package' couldn't be found on 'FfoConfigurationSession'.
> >     + CategoryInfo          : NotSpecified: (:) [Get-DlpSensitiv...TypeRulePackage], ManagementObjectNotFoundException
> >     + FullyQualifiedErrorId : [Server=BN3NAM04WS014,RequestId=5f5e486b-041f-4d5a-984a-88458d3e497f,TimeStamp=11/7/2019 2:08:05 PM] [FailureCategory=Cmdlet-ManagementObjectNotFoundException] C0E6F8D4,Microsoft.Office.CompliancePolicy.Tasks.GetDlpSensitiveInformationType
> >    RulePackage
> >     + PSComputerName        : nam04b.ps.compliance.protection.outlook.com
>

EDIT I've used the same Publisher Id in the customer rule packs as the one in the built-in XML since it was not mentioned to generate a new GUID for it as well https://docs.microsoft.com/en-us/microsoft-365/compliance/create-a-custom-sensitive-information-type-in-scc-powershell Might this be the issue?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1391cf1-588f-a4a9-8692-8c07cf1e459a
Version Independent ID: d57337a5-d0f3-de26-2259-6b7fa7613d05
Content: Customize a built-in sensitive information type
Content Source: microsoft-365/compliance/customize-a-built-in-sensitive-information-type.md
Service: o365-seccomp
GitHub Login: @chrfox
Microsoft Alias: chrfox

@mezzofix - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let me know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

Why has this been closed ?!

@mezzofix - Please understand that this site is a product documentation site and not a support nor a feature request site.  As such, the feedback section here is intended for feedback that improves the content in the Microsoft documentation and not intended for user feedback on product features nor troubleshooting.
Is there something within this article that you suggest to be added or edited? If yes, please share the appropriate text and where it should be placed, so a Pull Request can be created to get it added.
Otherwise, for technical queries or troubleshooting, you can visit support.microsoft.com, answers.microsoft.com or open a service ticket. Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products
For user feedback on product feature requests, you can submit via User Voice. I know the product teams are always looking for user feedback on how to make Office 365 better. You might find others have made a similar request that you can add to, or you can open a new one.
I hope this gets you pointed in the right direction. If you do find that it is a documentation error though, feel free to comment back and we'll gladly look into fixing it.
Thank you.


Added a basic order to the structures being build.

I always liked the security of a tower being up and running before additional extensions and such were build. So i added a basic order, yay, nay, or better suggestions? :)

This Pull Request has been merged by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

3
0
0
3

Vote Breakdown

User
Yes
No
Abstain

ViezeVingertjes
✔

tedivm
✔

TheRealMaxion
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
True


Implement StaticallySized for usize

usize is a type with a static size, but the value of the size is platform-dependent.
Therefore, we implement the trait StaticallySized but keep SIZE unimplemented.

LGTM


2017.2 Glitching out black scene

I dont know what to comment

Fixed, Had to tweak some settings


the map function document is out of order

https://duckdb.org/docs/sql/functions/nested
Map Functions
| Function | Description | Example | Result | |:—|:—|:—|:—| | map[entry] | Alias for element_at | map([100, 5], ['a', 'b'])[100] | 42 | | element_at(map, key) | Return a list containing the value for a given key or an empty list if the key is not contained in the map. The type of the key provided in the second parameter must match the type of the map’s keys else an error is returned. | SELECT element_at(map([100, 5], [42, 43]),100); | 42 | | cardinality(map) | Return the size of the map (or the number of entries in the map). | cardinality( map([4, 2], ['a', 'b']) ); | 2 | | map() | Returns an empty map. | map() | {} |

the margins lines should be dropped as
d|a|c
-|-|-
0|1|2

not

|a|
|-|
|1|

Function | Description | Example | Result
:—|:—|:—|:—
map[entry] | Alias for element_at | map([100, 5], ['a', 'b'])[100] | 42
element_at(map, key) | Return a list containing the value for a given key or an empty list if the key is not contained in the map. The type of the key provided in the second parameter must match the type of the map’s keys else an error is returned. | SELECT element_at(map([100, 5], [42, 43]),100); | 42
cardinality(map) | Return the size of the map (or the number of entries in the map). | cardinality( map([4, 2], ['a', 'b']) ); | 2
map() | Returns an empty map. | map() | {}

:—|:—|:—|:—
should be
:-|:-|:-|:-

Thanks for letting me know about the format error. However, it appears to render properly after the fix in #147 . All of our other markdown tables follow this same format - what is the advantage of the format you are recommending?

I test the markdown format with github input box preview.
and I use duckdb CLI to output the markdown format that including margin lines also works.

D .mode markdown
D select 1,'a';
| 1 | a |
|---|---|
| 1 | a |

1
a

1
a

Would you mind closing this ticket now that it is fixed? Thanks!


rio: Add version 0.0.36

Closes https://github.com/ScoopInstaller/Extras/issues/11772

[x] I have read the Contributing Guide.

Wonder if you could use already tested and tuned manifest from here:
https://github.com/melMass/scoop-mtb/blob/master/bucket/rio.json
to add add options you want.

Hey @aliesbelik,
after uploading the first version of the manifest I saw that repo and it helped me to solve the error of not showing the icon.
Credit to that guy for that, overall it's a pretty simple manifest.

/verify

/verify


Feature Request - How to use configure_connectivity_resources variable in a custom landing zone

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
How to use configure_connectivity_resources variable in a custom landing zone.
Is your feature request related to a problem?
Yes

Describe the solution you'd like
I'm creating a custom landing zones for core management groups. So I have set "deploy_core_landing_zones = false".
I would like to use the configure_connectivity_resources variable for creating and configuring VWAN resources for the custom connectivity landing zone I have created.
Kindly let me know if this is possible.

Additional context

This can be closed, as I got to know that even though custom landing zones are present its not related to deploying connectivity resources since , just enabling the below in the correct connectivity subscription will deploy the resources in them and  we can move the connectivity subscription into custom landingzone we created
deploy_connectivity_resources    = true
subscription_id_connectivity     = data.azurerm_client_config.connectivity.subscription_id
configure_connectivity_resources = local.configure_connectivity_resources

Glad you found a solution to this, and thank you for closing this.
You may find the following Wiki guidance useful as this shows using the connectivity capability independently as I believe you are trying to do:
[Examples] Deploy using multiple module declarations with remote state


Compare pauli matrices in commute using equality instead of is

To fix #2813

Updated as per the suggestion. PTAL.


client: add support for path prefix

Sometimes the access to influxdb is behind a proxy that may require a path prefix.

Thanks, @simon3z!


Authy cannot verify token

I am using authy and getting issue in verifying user. I successfully registered the user but failed to verify.
When i check user status it returns
{"status"=>{"authy_id"=>xxxxxx, "confirmed"=>true, "registered"=>false, "country_code"=>92, "phone_number"=>"XXX-XXX-3156", "devices"=>[], "has_hard_token"=>false, "account_disabled"=>false}, "message"=>"User status.", "success"=>true}
When i was verifying user by
Authy::API.verify(:id => xxxxxx, :token => token_on_app, :force => true)
it gives
{"success"=>false, "message"=>"Token format is invalid", "errors"=>{"message"=>"Token format is invalid"}}
but i am giving the correct token.
Please tell me what goes wrong? Thanks

token_on_app should be between 6 and 12 digits, otherwise the validation fails.


CC-94: Optimize inputs for mobile users

resolves https://github.com/Components-care/backlog/issues/94

Why did you modify Integer/Decimal/Currency Inputs? Why did you make them all stateful? They shouldn't be stateful.

We are displaying formatted value for Integer/Decimal/Currency Inputs. But now we are managing value in TextFieldWithHelp component, so we are loosing formatting. To manage the formatted value, adjusted those changes.

And in doing so you break the form engine. The only thing you need to do is clear the input value in the text field and trigger an onChange event if the user clicks the clear button => https://stackoverflow.com/a/46012210

And if that doesn't work add a new property to handle the clearing of the value.


fix: Correct minor typos in log output

Summary
Found a minor typo while setting up Reassurance.
Test plan

Run a test
Read the logs

Before:

@dereklucas thank's for spotting these and submitting the PR!


mutagen status is not in sync with mutagen monitor

Describe the bug
Command ddev mutagen status is not in sync with ddev mutagen monitor
To Reproduce
Start a project, open terminal and start command ddev mutagen monitor. After a second or two monitor will stop reporting anything as there is nothing more to do. Now start a second shell, open the same directory/project and execute command ddev mutagen status. You will see that executing this command will start some reports in monitoring shell. Status catches a random line of monitor report and echo it as status.
Expected behavior
If monitors last report is Status: Watching for changes and I execute status command in a second shell I expect Watching for changes instead of scanning for files or whatever.
Version and configuration information (please complete the following information):

Host computer OS and Version: MacBook Air M1 with macOS Big Sur
Docker Desktop version if on macOS or Windows: 3.6.0
ddev version information: v1.18.0
Do you have any custom configuration (nginx, php, mysql): no
config.yaml contents for the misbehaving project (the part before the comments)

name: typo3104
type: typo3
docroot: public
php_version: "7.2"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.3"
mysql_version: ""
nfs_mount_enabled: false
mutagen_enabled: true
use_dns_when_possible: true
timezone: Europe/Berlin
composer_version: "2"
web_environment: []

Nice greetings
Stefan

Thanks for looking closely!
ddev uses the mutagen sync list command to determine when it's safe to continue on during ddev start. https://github.com/drud/ddev/blob/920d65e24eca16491d77dfde93a468f1fe987743/pkg/ddevapp/mutagen.go#L223-L256
ddev mutagen monitor, however, is  a wrapper on mutagen sync monitor, which doesn't have exactly the same behavior.
So if that's a bug (it would be hard to convince me) then it's a bug in mutagen, but I think it's just two different ways of looking at things.
Kudos to you though for looking carefully and working to understand the whole process. I hope others are careful like you, because I think mutagen needs to be understood thoroughly for real success, as discussed in https://ddev.readthedocs.io/en/stable/users/performance/#caveats-about-mutagen-integration

No response, but happy to continue the conversation here or elsewhere. Please do continue it if you think this is important. Closing for now.


chore(ci): require tests to pass on Windows on PRs

This only applies to the Go codepath. The Rust codepath Windows tests will become required when all the Rust codepath tests become required.
Closes TURBO-1789

Checking out the repo for 46 mins... restarting workflow...

Merging this since the tests are just getting cache hits and passing. The ones that aren't done yet are just failing to checkout the code (some issue with Github Actions probably) https://github.com/vercel/turbo/actions/runs/7027911791/job/19124047738?pr=6625


optimize exec

it's just too slow to import all the stuff multiple times in python

New plan: port part by part to C


Added Datasets & DataLoader

Similar to PyTorch I added two friendly objects for TinyGrad: Dataset and DataLoader.
More specifically, here there is an example of usage:
from datasets import MNIST, CIFAR10, CIFAR100

ds = CIFAR10(root='./data', train=True, download=True)
dl = ds.dataloader(ds, batch_size=32, shuffle=True) # or datasets.utils.DataLoader(ds, ...)
x, y = next(iter(dl))
x.shape # [B, C, H, W]
y.shape # [B]

In particular,  as in PyTorch, the dataset can return lists, tuples, dicts, .... and the DataLoader returns the batched version maintaining the same original structure (batched lists, batched tuples, batched dicts, ...).
Main Changes

a new datasets folder that contains datasets stuff,
definition of Dataset and DataLoader in datasets/utils.py,
definition of the first few datasets for vision like MNIST, CIFAR10, CIFAR100,
a test for all the datasets and dataloaders in test/test_datasets.py,
improved train(...) function in extra/training.py for training models with dataloaders and not with full datasets (more flexible training...),
added datasets/transforms.py.

TO DO:

Implement parallelization with num_workers in the DataLoader.

There's tons of copy pasted code here between CIFAR10 and CIFAR100. How many lines does this really have to be?

Still tons of copy pasted code. What's the shortest number of lines you can write this in?

Again, I like the basic idea, but this all should be shorter than 100 lines.

Reopen when the dataloader is <100 lines and ideally reduces lines in the repo.


convert_composer_to_hf.py currently only supports MPT and not compatible with other models like llama

I tried finetuning llama2 model (without lora). I needed to convert the saved composer checkpoint (.pt) to hf checkpoint folder. For that, if I use convert_composer_to_hf.py, it will obviously give error because of following:
 # register config auto class
MPTConfig.register_for_auto_class()

# register model auto class
MPTForCausalLM.register_for_auto_class('AutoModelForCausalLM')

print(f'Loading model from {local_folder_path}')
config = MPTConfig.from_pretrained(local_folder_path)
# You have to edit the config this way, because attn_config is a nested dictionary
config.attn_config['attn_impl'] = 'torch'
loaded_hf_model = MPTForCausalLM.from_pretrained(local_folder_path,
                                                 config=config,
                                                 torch_dtype=dtype)

Are there any plans to make changes to convert non MPT models?

Yeah, that script is specifically for MPT because we have custom code files that we need to edit to be compatible with the huggingface hub. For other models that are in transformers proper, please see https://github.com/mosaicml/llm-foundry/issues/139#issuecomment-1555426919 and https://github.com/mosaicml/examples/blob/main/examples/end-to-end-examples/sec_10k_qa/convert_composer_to_hf_transformers.py for a full script using that function.

Thanks @dakinggg. I am able to do inference now.


Lookup race types, including for GA partisan primaries

Description
Looks up race types in state specific mappings using the election and contest names, includes primary and partisan primary codes for GA.
Test Steps
elexclarity 113667 GA --level=precinct

@chriszs Thank you! One more request, could you update the consts file to include all of these contest names for party mapping as well? Some counties have different contest names on their own xml files.
        'US Senate - Rep'
        'REP - US Senate'
        'DEM - US Senate'
        'US Senate - Dem'
        'Governor - Rep'
        'REP - Governor'
        'DEM - Governor'
        'Governor - Dem'
        'Secretary of State - Rep'
        'REP - Secretary of State'
        'DEM - Secretary of State'
        'Secretary of State - Dem'


When your hobby became your job

Well it's not always fun. Can definitely lead to burnout sometimes.

Some things I try to keep them separate. Main theme is setting boundaries.

Separate the programming you do for work and programming you do for yourself: it can be a different tech stack, a different language altogether, a different programming, paradigm etc.
Branch out to other hobbies? I learned pixel art!
Letting yourself potato

Closing this, I think it's fine, this has already been solved by the life growth framework blogpost


Creating image with white area around

Hi,
I am getting mostly what I want but some files are generating images with white areas around image with no particular reason (same settings, PDFs have no white borders or something).
I have attached image that I get and original PDF.
Please if you can help me how to handle this kind of bugs would be cool.
Thanks a lot.
planeo.pdf

I am getting same issue. Please help. Its urgent

I guess this has something to do with the particular PDF you're converting, I'm not getting this with the pdf's I try.
I'd accept a PR if there's something that can be fixed in this package.


Aren’t we missing out on a lot of reductions?

Hey,
I noticed that I get a bunch of new seeds when I fuzz, but by merging my results into the existing corpus, it only takes the ones that add new features and coverage. All the seeds that reduce the size but achieve the same coverage are not adopted into the corpus. Obviously, if I merged both the existing and my new seeds into an empty third directory, they’d get traversed by increasing size and I would get keep the shortest seeds that achieve the same coverage.
Should I:

merge my new seeds into the existing corpus and only upstream new features/coverage?
merge everything into an empty directory, add everything that ends up in that direct to the corpus and upstream it?

Currently, I’m following approach 1. which keeps the corpus smaller, but misses out on the reductions. Following 2. would grow the corpus more quickly, but then when we squash it at the branch off point we’d keep the best reduced seeds.

Yeah, something like that would work. The question is whether we want to do that?

Okay, I would like to do that at least right before we resquash the qa-assets repository.

I’ve created two variants as potential contributions to compressing the qa-assets repo with #153 and #154

Edited my comment to replace rm -rf with mv: #150 (comment)

Yeah, I had just merged into a /tmp/qa_assets_merge and copied the result back. I think we’re good.


GET endpoint with complex object results in booleans for top level class

I have described the issue on StackOverflow so I will attach the link to it
https://stackoverflow.com/questions/62473171/generating-spring-api-docs-using-swagger-over-get-endpoints-with-complex-objects
Springfox version: 2.9.2
What kind of issue is this?
In a controller, for a GET request, in the parameter list, if I use a nested/complex object then in the documentation, instead of seeing the fields of the complex objects I see only the fields of the first level class, as booleans.
I believe in spring boot 2.2 (I do not recall where I read this) they introduced this feature of using complex objects for mapping request params from query string in the form of GET .../search?firstLevelField.secondLevelField.thirdLevelField=dog

Hi, @dani-t.
Could you, please, provide full source code of your dto's with getters and setters.
Also, did you try annotating controller's parameters with @ModelAttribute annotation?

I have found the problem.
In my DTOs I had some getters which return Optional<Something>. By adding .genericModelSubstitutes(Optional.class) to my swagger config I managed to obtain the configuration I was looking for.
@Bean
public Docket api() {
    return new Docket(DocumentationType.SWAGGER_2)
            .select()
            .apis(RequestHandlerSelectors.any())
            .paths(PathSelectors.any())
            .build()
            .genericModelSubstitutes(Optional.class)  // added this line
            .securityContexts(Lists.newArrayList(securityContext()))
            .securitySchemes(Lists.newArrayList(apiKey()));
}


mass.search media type and limit not being respected

What version of Music Assistant has the issue?
2.0.0.b103
What version of the Home Assistant Integration have you got installed?
2024.2.0
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
When using the mass.search service call three problems are noted.

Radio results are always returned regardless of what is selected in the media type options
The LIMIT is not respected for albums or tracks
When using a local provider ONLY then doing a search with no media_id specified only returns the artist and no tracks. However, when streaming providers are available then all the fields are returned. For example this is returned with no streaming providers:

versus this with streaming providers:
search_results.txt
How to reproduce
Do this search and observe multiple tracks and albums and a radio station returned
service: mass.search
data:
  limit: 1
  name: Test
  media_type:
    - album
    - track

Or do this search with only a local provider to see the result shown in the image above
service: mass.search
data:
  limit: 5
  name: Billy Joel

Music Providers
Local files, Spotify, TuneIn, Radiobrowser
Player Providers
Not used
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.2.0
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi

fixed in b146 + HA integration 2024.5.0

This is working well except tracks are not respecting the limit
service: mass.search
data:
  limit: 1
  name: john

search.txt

Keeping open


Add a block param to build_from_dir to capture Docker build output.

This addresses #74, which requests that docker-api give users a way of getting the output produced by build_from_dir. I sort of needed this feature the other day, so here I am. With this PR, you could now do:
Docker::Image.build_from_dir('.') do |chunk|
  logger.debug chunk # or whatever
end

In this PR, Image.build_from_dir gets an extra argument, &block, that will get chunks of the stream Docker produces when building an image. This simply involves using Excon's :response_block parameter.
It seems as though giving Excon a :response_block means that it will no longer return the body of the output (this seems like reasonable behavior, so I haven't looked into it much). That's why the reponse_block_for_build internal method needs to be passed the body parameter, so it can "build up" the body by concatenating the chunks Docker produces.
I don't think this PR is good to merge -- it doesn't make much sense to have this feature only for build_from_dir and not have it for build, so I'm mostly opening this to get an idea of what y'all think.

Hi, has any way to have a more "readable" log from the code suggested?
Docker::Image.build_from_dir('.') do |chunk|
logger.debug chunk # or whatever
end


ISSUE: Unable to install via HACS

Describe the bug
I added this integration to HACS as a custom repository (since it's not available in HACS yet despite the docs) When I try to install the integration I get an unknown error
Environment (please complete the following information):

OS: HassOS
Type of system that HA is running on: VM (kvm)
Home Assistant version: 2024.2.2
Hassio/Docker/Core? Hassio
Component version: N/A
Lock integration name: Virtual (yes, I know, ZWave only but I'm just trying to install it!)
Lock make and model: Virtual

Logs
The only logs I'm getting even though it says to check logs for details, there's no extra details!
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/config/custom_components/hacs/websocket/repository.py", line 234, in hacs_repository_download
    await repository.async_install()
  File "/config/custom_components/hacs/repositories/base.py", line 893, in async_install
    await self.async_install_repository(version=version)
  File "/config/custom_components/hacs/repositories/base.py", line 990, in async_install_repository
    raise HacsException("Could not download, see log for details")
custom_components.hacs.exceptions.HacsException: Could not download, see log for details

Additional context
Trying to get a feel for what this offers over Keymaster so I can determine how / if I should support it as a lock manager for my Rental Control integration.

I'm going to do a manual install without HACS for now but wanted to call out that it's having an issue with HACS. Maybe because you don't have any releases yet?

No issues installing manually.

seeing the same. I think cutting a release would solve it since that's how HACS knows there's an update.

yes this is missing a release. I want to finish all my bug testing before I push an actual release and advertise this a little more widely

If you're interested in letting people test you could do a beta release and check "This is a pre-release." This would force users to select seeing beta releases and it wouldn't show up with the normal releases.
E.g., https://github.com/home-assistant/core/releases/tag/2024.2.0b11

Already pushed it as a non beta release so it should be installable now


feat(transport): Remove TLS 1.1 in accepted protocols by default

There were the following issues with your Pull Request

Commit: 4b48bdbd9a9402e48fc809df8e49d404b3866f8c
Your subject line is longer than 72 characters

Guidelines are available at https://github.com/lettre/lettre/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   91.07%   91.07%
=======================================
  Files          11       11
  Lines        1109     1109
=======================================
  Hits         1010     1010
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31442e9...4b48bdb. Read the comment docs.


Update the public roadmap

What
Update the public roadmap.
Why
So that our users, senior management and other stakeholders know what we're working on and what's up next.
Who needs to work on this
Product manager
Who needs to review this
Content designer, delivery manager

Please can I get a review from Kelly and Calvin? (Others are welcome to review it, but need a thumbs-up on content mostly.)


[Question] How could I customize what files a common chunk includes by webpack?

Let's say we have two pages: PageA, PageB, and they have pageA.js and pageB.js. Both of them depdends on a common bunch of stuffs, which can be packed into a file called "common.js".
pageA.js:
require(['common', 'someOtherThingsANeeds'], function(){//do sth.})
pageB.js:
require(['common', 'someOtherThingsBNeeds'], function(){//do sth.})
I want to load chunks when the page runs, so I use a config like this:
    new CommonsChunkPlugin({
      name: "pageA",
      async: true,
    }),
    new CommonsChunkPlugin({
      name: "pageB",
      async: true,
    })

But it comes out that both chunks of pageA and pageB have the same content of module "common", which are duplicated and should be extracted to a single module called "common"
In this example, we can just specify something like this:
        new CommonsChunkPlugin({
            name: "commons.js",
            chunks: ["pageA", "pageB", "admin-commons.js"],
            minChunks: 2
        }),

However, I have to declare the reference of "common.js" in the html file. In addition, I can't control when my "common.js" should be loaded by js. And I can't control my dependencies in my js only. I have to remember to write it and I have to ordering the declarations in an old way.
In r.js of require.js, there's such a config that we can customize which of the modules should be seperated into individual ones, like this:
modules:[ { name:"common",
      include:[ "allThingsCommonNeeds" ] },
{ name:"pageA",
      include:[ "blabla ],
    exclude:["common"] }]

So how could I achieve this by webpack? Do you guys have any suggestions or ideas? Thank you very much.

It's quite possible code splitting (dynamic import in webpack 2) could help here.
Can you re-open the question at Stack Overflow? We don't do support in this tracker anymore.
Thanks.


There are two different ways to set types of serial LEDs

Ran into this while pretending to be a beginner.
Depending on your specific type of LED, there are two ways to indicate that you are using that LED:

Set the type in drivers.serial.Serial (as in WS2811).
Use a different base class (as in WS2801).

This is not really explained anywhere and will probably confuse people.

Well... that's two entirely different scenarios.

Since the AllPixel case is identical for all LEDs aside from a few options
this makes sense.
In the SPI case, I could actually now see a use-case for having a driver
just called SPI() and then you giving it an LED type and under the hood it
does all the necessary stuff.
Since we have the SPI base class we kind of do that already so that would
not be hard. To be completely honest, that evolved out of BP originally
just being for the LPD8806, and then adding on other SPI drivers as I went.
THEN the AllPixel came around and things started to get interesting.
Personally, I say we don't change any code and just solve this with better
docs.
Does bring up a question though... In a project for the AllPixel serial
driver, how do you pass in the LEDTYPE value? It's actually an int enum,
but I'm assuming you cannot just put the name in the project file? That
might be a problem... or am I missing something?
On Thu, Jun 15, 2017 at 7:45 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

Ran into this while pretending to be a beginner.
Depending on your specific type of LED, there are two ways to indicate
that you are using that LED:

Set the type in drivers.serial.Serial (as in WS2811).
Use a different base class (as in WS2801).

This is not really explained anywhere and will probably confuse people.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/219, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA6a6kZZJLPSX1mAVr-vicC_z7HvR9sjks5sERlpgaJpZM4N7F_w
.

Heh, I have a fix for that last question almost done.  I noticed it after writing this.  Expect a pull request...

Regarding the ledtype/type - well, I'm still lost as to the specifics, though this was the same general idea I had.  But you can clear it up in seconds by correcting the following code blocks, particularly the last one...
# WS2912B drivers - this strip requires no special code.

# For SPI (e.g. Raspberry Pi)
driver = DriverSPIBase(num=10, type=LEDTYPE.WS2812B)

# For AllPixel.  From here:
# https://github.com/ManiacalLabs/AllPixel/wiki/Library-Install-and-Strip-Example
driver = DriverSerial(num=10, type=LEDTYPE.WS2812B)

# LPD8806 drivers - this strip DOES require special code.

# For SPI.  There is special code to handle LPD8806 in the class.
driver = LPD8806(num=10)

# For AllPixel - *seems wrong* because no special code??
driver = DriverSerial(num=10, type=LEDTYPE.LPD8806)

The AllPixel has to know what kinda of LED is connected so it knows what
protocol to switch to. No special code in BP, special code in the AP
firmware.
For now I say leave it as is and maybe change things up in 3.1 or
something. I'm not willing to change this late in the game.
On Thu, Jun 15, 2017 at 8:12 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

Heh, I have a fix for that last question almost done. I noticed it after
writing this. Expect a pull request...
Regarding the ledtype/type - well, I'm still lost as to the specifics,
though this was the same general idea I had. But you can clear it up in
seconds by correcting the following code blocks, particularly the last
one...
WS2912B drivers - this strip requires no special code.
For SPI (e.g. Raspberry Pi)
driver = DriverSPIBase(num=10, type=LEDTYPE.WS2812B)
For AllPixel.  From here:
https://github.com/ManiacalLabs/AllPixel/wiki/Library-Install-and-Strip-Example
driver = DriverSerial(num=10, type=LEDTYPE.WS2812B)
LPD8806 drivers - this strip DOES require special code.
For SPI.  There is special code to handle LPD8806 in the class.
driver = LPD8806(num=10)
For AllPixel - seems wrong because no special code??
driver = DriverSerial(num=10, type=LEDTYPE.LPD8806)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/219#issuecomment-308712355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6qqgAFJL2rjkZ81ndXyx-9dQyymKks5sER-cgaJpZM4N7F_w
.

I'm learning this (almost) entirely so I can document it...

Cool
On Thu, Jun 15, 2017 at 9:28 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

I'm learning this (almost) entirely so I can document it...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/issues/219#issuecomment-308729076,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6iFzSPb92Z18pdE6bROGm4shuMhkks5sETFwgaJpZM4N7F_w
.

I don't believe that code review really "fixes" this issue, so I'm moving it back to 3.x


Container With Most Water

Enter your question -
Given n non-negative integers a1, a2, ..., an , where each represents a point at coordinate (i, ai). n vertical lines are drawn such that the two endpoints of the line i is at (i, ai) and (i, 0). Find two lines, which, together with the x-axis forms a container, such that the container contains the most water.
Notice that you may not slant the container.
Enter link to the question(if question belongs to any online platform) -
https://leetcode.com/problems/container-with-most-water/
Tags for the question(eg - Array, Basic, Stack, etc.) -
Array, Two pointer

This is a very good question and I think every one should give it a try!!

@SarthakKeshari can you assign it to me??

@Lakshay-Pruthi,
Kindly add your solution to "leetcode" folder
Deadline - 05/10/2021


ZeResults do not track the time a test took

We probably want to track each assert timestamps.

Implemented a simple duration implementation.  Need to see how long running multiple resulting tests will be treated when they run with a single timer.  what time wins out.


Update install docs to reference intel module docs

Pointing to the modules documentation, from the install document, leads to a blank page, as the actual configuration documentation for each module is within the module's docs. This change updates the docs to tell readers to visit the docs in each relevant intel module.

@ryan-lane I think it's better to link to original docs for now.
https://github.com/lyft/cartography/tree/master/docs/setup/config

@ryan-lane I think it's better to link to original docs for now.
https://github.com/lyft/cartography/tree/master/docs/setup/config

@ryan-lane can you update the branch so we can merge it in?

Done!


Cannot generate random variates from noncentral chi-square distribution with dof less than 1

I'm using scipy 0.15.1
The random variate generation function of the noncentral chi-square distribution yields error when the parameter degree of freedom (dof)  is less than or equal to 1. For example,
import scipy.stats as stats
df = 1.0
nc = 4
stats.ncx2.rvs(df, nc)

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-55-6be68a9d384a> in <module>()
----> 1 stats.ncx2.rvs(1.0, nc, loc=0, scale=1, size=1)

/Users/zhangxiaowei/anaconda/lib/python2.7/site-packages/scipy/stats/_distn_infrastructure.pyc in rvs(self, *args, **kwds)
    833             return loc*ones(size, 'd')
    834
--> 835         vals = self._rvs(*args)
    836         if self._size is not None:
    837             vals = reshape(vals, size)

/Users/zhangxiaowei/anaconda/lib/python2.7/site-packages/scipy/stats/_continuous_distns.pyc in _rvs(self, df, nc)
   2931     """
   2932     def _rvs(self, df, nc):
-> 2933         return mtrand.noncentral_chisquare(df, nc, self._size)
   2934
   2935     def _logpdf(self, x, df, nc):

mtrand.pyx in mtrand.RandomState.noncentral_chisquare (numpy/random/mtrand/mtrand.c:15618)()

ValueError: df <= 0

A common implementation of the noncentral chi-square random variate generation differs depending on whether the dof is greater than 1 or not. In particular, suppose we want to generate a noncentral chi-square with dof d and noncentrality parameter v.

If d is greater than 1, then it can be generated by

import numpy as np
np.random.chisquare(d-1) + (np.random.standard_normal()+np.sqrt(v))**2

Otherwise, it can be generated by

import numpy as np
np.random.chisquare(d + 2*np.random.poisson(v/2.0))

I suspect that scipy only implements the first case and ignores the other.

Just found out that scipy uses the implmentation in numpy, which has documented here that it only considers the case where degree of freedom greater than 1.

The numpy docstring says >=1, so df=1 shouldn't give an error. Plus ValueError: df <= 0 is a weird error. Can you open a numpy issue for that?

At the end of your message you suggest a possible improvement for stats.ncx2.rvs. Needs deciding on, do we want to do this in stats.ncx2 or should we only consider it if np.random.noncentral_chisquare gets this enhancement?

The fact that df=1 raises error may be because the algorithm implemented is the one I suggested above: in this case, it needs to generate a chi-square random variate with df=0, which is not well defined in mathematics

I guess the best course of action is to add it to numpy.random and then bundle the compatibity fix  to scipy.stats.ncx2 until it can use the numpy version where it's implemented.

https://github.com/numpy/numpy/pull/5800 merged for numpy 1.10; I don't see a reason to not add it to stats.ncx2. @xiaoweiz @behzadnouri

Agree. It should also be an easy fix in scipy.

Am adding an easy-fix label then.

Hi, I just saw this issue. It seems that the code doesn't break for df>0 now and the PR is merged for numpy 1.10. Should the scipy code be changed now or is it just a documentation issue for scipy now since it automatically calls np.random.noncentral_chisquare which handles the issue.

agree. This can be closed now.

Thanks for clarifying :)


Widen calo cluster association time window

This 'fixes' the problem with KKDeP not getting calo clusters associated.  There is still an underlying bug, probably in the time cluster, as the standard window works fine for KKDeM and KKCalDeP, but this patches things for now.

I saw this by eye.   It’s not a formal error, just an unused definition.
That file has a large number of commented out lines, lots of
repetition/duplicate points of maintenance and no real structure, it needs
to be reorganized and commented to make it maintainable.
David Brown            @.***
Office Phone<PHONE_NUMBER>
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C)  Berkeley, CA 94720
On Fri, Mar 8, 2024 at 07:47 Rob Kutschke @.***> wrote:

@.**** commented on this pull request.
In core/trigSequences.fcl
https://github.com/Mu2e/mu2e_trig_config/pull/14#discussion_r1517895623:

   tprDeMHighPStopTargPS, @sequence::TrigRecoSequences.calReco,

   @sequence::TrigRecoSequences.trkPrepareHits,
   TTtimeClusterFinder, tprDeMHighPStopTargTCFilter, TThelixFinder, TTHelixMergerDeM, tprDeMHighPStopTargHSFilter, TTKSFDeM, tprDeMHighPStopTargTSFilter, tprDeMHighPStopTargTriggerInfoMerger ]

trpDeM               : [ tprDeMHighPStopTargPS, @sequence::TrigRecoSequences.calReco,

tprDeM               : [ tprDeMHighPStopTargPS, @sequence::TrigRecoSequences.calReco,

I am curious - was this caught by validated fcl?
—
Reply to this email directly, view it on GitHub
https://github.com/Mu2e/mu2e_trig_config/pull/14#pullrequestreview-1925170445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAH575HWDYLO23SHDB7ALDYXHMSZAVCNFSM6AAAAABEMQ3H4KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRVGE3TANBUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Always keep Comfy Workflow tab's loader/saver widget thingy at an optimal width

Feature Idea
When saving a workflow with a long name in the Comfy Workflow tab, that little 'widget', I suppose it could be called, grows in width to accommodate for some reason. This leaves empty space between the buttons on the left and the two dropdowns for 'MultiGPU' and 'Quick Load':

This affects the workflow area below, necessitating in moving the workflow around to get at the parts that the widget obscures. I tried using the arrow to disappear it into the smallest size but then I found that I keep having to click to get it back open again just to switch to a new saved workflow. It's also impossible to click the 'Use This Workflow in Generate Tab' button while it's in tiny widget mode. I use this button a lot. It also covers some functionality in things like Comfy Custom Nodes Manager (which can't be moved around) until it's made tiny:

I saved a new Custom Workflow called "Custom Comfy Workflow with a really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really long name":

Then I screenshotted the widget:

Then I deleted the workflow and found that the widget did not resize to be any smaller, so it was stuck at that huge width. I pressed F5 and got the error message:
Seems like the ComfyUI workflow editor direct-access hasn't loaded. Give it a second to load - if it doesn't there might be an error message in your browser console or the server logs.

It didn't reload - it just stayed like that. This is all that was in the logs for that period:
Debug Log:
2024-07-27 21:01:23.301 [Debug] check Custom Comfy Workflow with a really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really, really long name against Basic SDXL.json
2024-07-27 21:02:14.735 [Debug] Comfy backend 0 using model folder format: forward slash / as no backslash was found
2024-07-27 21:02:15.027 [Debug] Data refreshed!

Verbose Log:
2024-07-27 21:02:12.289 [Verbose] User local triggered a strong data refresh
2024-07-27 21:02:12.291 [Verbose] User local wants to list images in '', maxDepth=3, sortBy=Date, reverse=False, maxInHistory=1000, maxScanned=10000
2024-07-27 21:02:12.295 [Verbose] Comfy backend 0 loading value set...
2024-07-27 21:02:12.675 [Verbose] Listed 10000 images in 0.384 seconds.
2024-07-27 21:02:14.735 [Verbose] Comfy backend 0 loaded value set, parsing...
2024-07-27 21:02:14.735 [Verbose] Comfy backend 0 loaded value set and parsed.
2024-07-27 21:02:14.736 [Verbose] [Model Scan] Add all Stable-Diffusion from folder
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sdxl
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sdxllightning
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sdxlturbo
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sd15
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sdxlhyper
2024-07-27 21:02:14.737 [Verbose] [Model Scan] Add all Stable-Diffusion from folder sdxlpony
2024-07-27 21:02:14.745 [Verbose] [Model Scan] Add all Stable-Diffusion from folder
2024-07-27 21:02:14.746 [Verbose] [Model Scan] Add all VAE from folder
2024-07-27 21:02:14.747 [Verbose] [Model Scan] Add all VAE from folder sdxl
2024-07-27 21:02:14.750 [Verbose] [Model Scan] Add all LoRA from folder
2024-07-27 21:02:14.750 [Verbose] [Model Scan] Add all LoRA from folder other
2024-07-27 21:02:14.751 [Verbose] [Model Scan] Add all LoRA from folder sdxl
2024-07-27 21:02:14.751 [Verbose] [Model Scan] Add all LoRA from folder sdxlpony
2024-07-27 21:02:14.890 [Verbose] [Model Scan] Add all Embedding from folder
2024-07-27 21:02:14.891 [Verbose] [Model Scan] Add all Embedding from folder sdxlpony
2024-07-27 21:02:14.891 [Verbose] [Model Scan] Add all Embedding from folder sdxl
2024-07-27 21:02:14.897 [Verbose] [Model Scan] Add all ControlNet from folder
2024-07-27 21:02:14.904 [Verbose] [Model Scan] Add all ClipVision from folder
2024-07-27 21:02:14.905 [Verbose] [Model Scan] Add all ClipVision from folder sdxl
2024-07-27 21:02:16.890 [Verbose] Comfy Redir status code 200 from 200 and type application/json; charset=utf-8 for GET 'object_info'

After checking these logs and switching back to the Comfy tab, the error message was gone and the widget was resized to the previous width. So the error meant nothing much in the end but... Reporting it anyway for thoroughness.
My feature request is for the widget to remain at the smallest possible width regardless of the length of saved workflow names.
Whenever I F5 the browser, the widget does exactly what I mean, but only momentarily until it fully loads. This is what I'm asking for:

Thanks.
Other
No response

fixed


[USHIFT-1444] Flakey snapshotting test on metal

USHIFT-1444
Metal tests are flaking because the kickstart template is missing the thinpool creation command, an lvmd.yaml that reflects the actual storage config, and a storage class to expose the thin pool at the cluster layer.

/assign @pmtk
cc @dhellmann

@copejon , please see the https://github.com/openshift/microshift/pull/2073/commits/b6c5b2ce36a6ac43eb3cba490caf77406defb936 commit for deleting the lvmd.yaml file. It's necessary to leave the cluster in a consistent state.