Collection of enums/lookups

I've been tinkering with your EFCore Extensions package.  One question.
Let's say I have a field on my base object, Person, called Sports.  A given person can play multiple sports, and of course, many people can play a sport....classic Many-To-Many.
So I define an ICollection of Sports in my Person class, and an ICollection of Person(s) in my Sports class, and EFCore 5 predictably created the intermediary JOIN table PersonSports.  All the key relationships are good to go.
I also defined Sports as an enum in my code, and figured out how to seed the default Sports values.
But. what about weird sports?  Pickleball?  Curling?  Underwater Basket Weaving?
I'm looking for an open enumeration, I know that.  Assuming that I can put non-standard sports into the Sports table, and further assuming that when I make a GET call to my Person object, I want a comma-delimited string of the Sports they play, how would that work?   Will the Extensions package help me?

I am not sure, I am following. Our package helps to seed the enum values into lookup tables, we also created. Similar to the join table in EF Core 5 you mentioned.
But enum by definition is a set of named constants. What you are looking for is just a regular list of string, I believe?!


[SPARK-27604][SQL] Enhance constant propagation

What changes were proposed in this pull request?
This PR improves ConstantPropagation rule, the new implementation:

Collects constants into a map directly, instead of a list that is then transformed into a map.
Supports substituting in conflicting equalities:
e.g. a = 1 AND a = 2 => a = 1 AND 1 = 2
Before this PR this unsatisfiable filter was not reduced:== Physical Plan ==
*(1) Project [value#219 AS a#222]
+- *(1) Filter ((isnotnull(value#219) AND (value#219 = 1)) AND (value#219 = 2))
   +- *(1) LocalTableScan [value#219]

But after this PR it is:== Physical Plan ==
LocalTableScan <empty>, [a#222]

Extends propagation from attribute => constant mapping to deterministic expression => constant mapping:
e.g. abs(a) = 5 AND b = abs(a) + 3 => abs(a) = 5 AND b = 8
Allows substitution in other than EqualTo and EqualNullSafe expressions:
e.g. a = 5 AND b < a + 3 => a = 5 AND b < 8
Allows propagation of constant non-nullable expressions in Project and other nodes (except for Join):
e.g. SELECT a = 5 AND b = a + 3 => SELECT a = 5 AND b = 8
Before this PR only Filter was supported.
Allows deep constant propagation:
e.g. ... WHERE IF(..., a = 5 AND b = a + 3, ...) => ... WHERE IF(..., a = 5 AND b = 8, ...)
Before this PR only top level And/Or/Not nodes were supported.
During expression tree traversal tracks a boolean context that controls if constant propagation of a nullable expression can be safely applied.

E.g. in the case of ... WHERE a = c AND f(a) or IF(a = c AND f(a), ..., ...) where a is a nullable expression and c is a constant the null result of a = c AND f(a) means the same as if it resulted false therefore constant propagation can be safely applied (a = c AND f(a) => a = c AND f(c)).
In the case of SELECT a = c AND f(a) the null result really means null. In this context constant propagation can't be applied safely.
There is also a 3rd context due to an enclosing Not in which the context flips. E.g. constant propagation can't be applied on WHERE NOT(a = c AND f(a)) but can be again on WHERE NOT(IF(..., NOT(a = c AND f(a)), ...).

Why are the changes needed?
Improve performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

This PR is extracted from https://github.com/apache/spark/pull/24495 as @dongjoon-hyun suggested to make review easier.
Please note that new UTs added in https://github.com/apache/spark/pull/24495 depend on this change.

Can one of the admins verify this patch?

ok to test

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10550/
Test PASSed.

Test build #105274 has started for PR 24553 at commit 7a29f09.

Test build #105274 has finished for PR 24553 at commit 7a29f09.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105274/
Test FAILed.

retest this please

Test build #105275 has started for PR 24553 at commit 7a29f09.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10551/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10554/
Test PASSed.

Test build #105278 has started for PR 24553 at commit 96e54a7.

Test build #105275 has finished for PR 24553 at commit 7a29f09.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105275/
Test FAILed.

Test build #105278 has finished for PR 24553 at commit 96e54a7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105278/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10559/
Test PASSed.

Test build #105283 has started for PR 24553 at commit 8be22b6.

Test build #105283 has finished for PR 24553 at commit 8be22b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105283/
Test PASSed.

Any comments or suggestions @dongjoon-hyun or @gatorsmile ?

@dongjoon-hyun @gatorsmile @mgaido91 @viirya any feedback or suggestion is very welcome.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11024/
Test PASSed.

Thanks so much @mgaido91 for the review. Please let me know if you have any more questions.

Test build #105769 has started for PR 24553 at commit 6bccd84.

Test build #105769 has finished for PR 24553 at commit 6bccd84.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105769/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11035/
Test PASSed.

Test build #105780 has started for PR 24553 at commit 827cfe5.

Test build #105780 has finished for PR 24553 at commit 827cfe5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105780/
Test PASSed.

LGTM, thanks!

@dongjoon-hyun @gatorsmile @cloud-fan @viirya @HyukjinKwon could you please help me to review this PR?

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11736/
Test PASSed.

Test build #106493 has started for PR 24553 at commit 827cfe5.

Test build #106493 has finished for PR 24553 at commit 827cfe5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106493/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12013/
Test PASSed.

Test build #106794 has started for PR 24553 at commit 054624e.

Test build #106794 has finished for PR 24553 at commit 054624e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106794/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15695/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20597/
Test PASSed.

Test build #115806 has started for PR 24553 at commit 054624e.

Test build #115806 has finished for PR 24553 at commit 054624e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115806/
Test FAILed.

Test build #115947 has started for PR 24553 at commit 6a93b13.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20739/
Test PASSed.

Test build #115947 has finished for PR 24553 at commit 6a93b13.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115947/
Test FAILed.

Test build #116043 has started for PR 24553 at commit 3d129ea.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20834/
Test PASSed.

Test build #116043 has finished for PR 24553 at commit 3d129ea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116043/
Test PASSed.

Test build #116052 has started for PR 24553 at commit 7c09bc3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20845/
Test PASSed.

Test build #116052 has finished for PR 24553 at commit 7c09bc3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116052/
Test PASSed.

I modified this PR to fix some bugs in the current ConstantPropagation implementation.
cc @cloud-fan, @mgaido91

Test build #116102 has started for PR 24553 at commit cb7111c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20894/
Test PASSed.

Test build #116102 has finished for PR 24553 at commit cb7111c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116102/
Test FAILed.

Test build #116112 has started for PR 24553 at commit 5815a01.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20904/
Test PASSed.

Test build #116112 has finished for PR 24553 at commit 5815a01.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116112/
Test FAILed.

Test build #116121 has started for PR 24553 at commit 007d318.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20913/
Test PASSed.

Test build #116121 has finished for PR 24553 at commit 007d318.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116121/
Test PASSed.

Test build #116469 has started for PR 24553 at commit ce0660a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21256/
Test PASSed.

Test build #116469 has finished for PR 24553 at commit ce0660a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116469/
Test FAILed.

Test build #116630 has started for PR 24553 at commit 1b8c65a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21411/
Test PASSed.

Test build #116630 has finished for PR 24553 at commit 1b8c65a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116630/
Test PASSed.

Test build #116717 has started for PR 24553 at commit 39c563d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21493/
Test PASSed.

retest this please

Test build #116721 has started for PR 24553 at commit 39c563d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21496/
Test PASSed.

Test build #116717 has finished for PR 24553 at commit 39c563d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116717/
Test PASSed.

Test build #116721 has finished for PR 24553 at commit 39c563d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116721/
Test PASSed.

@cloud-fan, @dongjoon-hyun, @maropu I improved ConstantPropagation a bit in this PR. Do you think you could review it?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23112/
Test PASSed.

Test build #118355 has started for PR 24553 at commit 6d994ab.

Test build #118355 has finished for PR 24553 at commit 6d994ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118355/
Test PASSed.


Include maven url link to gradle plugins repo where palantir docker plugin is hosted

[long time reader, first time poster :) ] This pr adds the maven url link for the gradle plugins repository. Additional info here: https://plugins.gradle.org/plugin/com.palantir.docker
Without it, users (me) get errors like this:
Could not find gradle.plugin.com.palantir.gradle.docker:gradle-docker:0.19.2.
Searched in the following locations:
    https://repo.maven.apache.org/maven2/gradle/plugin/com/palantir/gradle/docker/gradle-docker/0.19.2/gradle-docker-0.19.2.pom
    https://repo.maven.apache.org/maven2/gradle/plugin/com/palantir/gradle/docker/gradle-docker/0.19.2/gradle-docker-0.19.2.jar
Required by:
    project :

I think this is obsolete - we switched to jib.


bitcoin: 0.17.3 -> 0.18.0, enable and run unit tests

Motivation for this change
https://bitcoincore.org/en/releases/0.18.0/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Can you tell me how to verify the SHA256 hash?
I have is 0ps0vw9iknz1b1sx74rabd1yhlxvwbd0aimjzn9hlqkvw286hkjy which is presumably the same, but I don't know how to tell.

@roconnor $ sha256sum bitcoin-0.18.0.tar.gz

Ah it is the literal result of sha256sum.  Silly me!

@jb55 In case you wish to review.

tests pass, running now. seems to be working. lgtm!


Fix #332 by having 10 minute timeout and kicking client on GUI debug

This fix does the following:

Increase peer timeout to 10 minutes.
On GUI debug start, if the peer is connected to the server, kick the peer and stop the yield.

This is to prevent debugger breakpoints for WAT Tests from timing out too early, and also to prevent a regression bug where if the debugger is force-stopped, it can never run again because it is still waiting for the peer to deliver the results.
With this fix, it enforces the fact that there can only be one test client connected at a time, which is the current behavior for GUI anyway, so this should be alright.
Note that this fix affects GUI debug only.

Thanks!


Release documentation update

Documentation has been updated for the 0.3.0 release.  Updates include:

Changing version numbers from 0.2.0 to 0.3.0
Updating API examples to reflect improvements in use of key and name
Adding runtime environment variable content
Adding python method names to summary table
Update contact information

Codecov Report

Merging #211 (4f3c415) into develop (725a993) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #211   +/-   ##
========================================
  Coverage    82.45%   82.45%
========================================
  Files           50       50
  Lines         2838     2838
========================================
  Hits          2340     2340
  Misses         498      498

Impacted Files
Coverage Δ

src/python/module/smartredis/client.py
95.78% <ø> (ø)

include/client.h
100.00% <0.00%> (ø)

include/srexception.h
24.13% <0.00%> (ø)


Expose Node.js API

Add support for using the npm pagefind package via node as discussed in #71

Could I register a vote for the nodejs API to support passing files on disk, but also passing actual entries to add to the index instead of HTML to be parsed? If you want to customize how an HTML document is turned into search results (or in my case, already have all that customization built), a node.js API that allowed adding individual results would make pagefind super useful. Folks would still be able to wire up pagefind's indexing and frontend bits, and could still use the CLI to generate indexes if they were starting from scratch, but if they wanted to customize it'd be super powerful to programmatically build up the index!

Good suggestion @airhorns — I might spin that up as a separate issue after implementing the simple version of the API.
To start with, the API will be setting CLI flags and running the Pagefind binary. To support adding entries I'll probably need to expand on the JS↔Binary communication for a nice way to pass in entries, since they don't really fit as CLI flags.

An update for anyone following the issue — work for this is underway. (Including passing actual entries @airhorns 👀).
Sample:
import * as pagefind from "pagefind";

const { errors, index } = await pagefind.createIndex({ /* opts */ });

await index.addFile("testing/index.html", "
Testing, testing
");

await index.writeFiles({ /* opts */ });

Still to come: index.getFiles to get the contents of the index instead of writing to disk, and a method to add direct entries rather than parsing HTML contents.

Awesome, can't wait :)

Hey all ! 👋
Good news — this has landed in Pagefind v1.0.0! ✨
See the full release notes here: https://github.com/CloudCannon/pagefind/releases/tag/v1.0.0 💙
See the library guide here: https://pagefind.app/docs/node-api/


TypeError: Cannot read properties of null (reading 'unit_amount')

Describe the bug
When clicking the Pricing button on the homepage I get the TypeError: Cannot read properties of null (reading 'unit_amount') in pricing.tsx.
To Reproduce
0. Clone and setup based on Readme.

Go to http://localhost:8000/pricing
See error on screen, also see error in terminal:

An error occurred during route handling or page rendering. TypeError: Cannot read properties of null (reading 'unit_amount')
    at comparePrices (file:///Users/nicu/dev/my/legis_gpt/saaskit/routes/pricing.tsx:18:52)
    at Array.sort (<anonymous>)
    at GET (file:///Users/nicu/dev/my/legis_gpt/saaskit/routes/pricing.tsx:28:27)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async handler (file:///Users/nicu/dev/my/legis_gpt/saaskit/routes/_middleware.ts:29:15)
    at async Server.handler (https://deno.land/x/fresh@1.1.6/src/server/context.ts:334:19)
    at async Server.#respond (https://deno.land/std@0.178.0/http/server.ts:299:18)

Expected behavior
I don't expect an error.
Screenshots

Desktop

OS: Apple M1 Pro
Browser Chrome
Version 114.0.5735.133 (Official Build) (arm64)

Additional context
I didn't look too much into it, but I didn't expect to get an any from the strip.products.list, which I assume causes the error.

Hi @nicu-chiciuc, I see that you followed the setup in the README. Specifically, did you complete the actions listed in the Payments and Subscriptions (Stripe) section?

To elaborate, the error you're getting appears to be caused by productA.default_price being null here. This would be caused by the Stripe products not being setup correctly or similar, rather than a type error.

I understand. That runtime error could've been prevented if this assertions aren't used. My PR makes this more explicit.

Could you please clarify whether you completed the actions listed in the Payments and Subscriptions (Stripe) section of the README?

I did initially. Then, in order to confirm that I didn't change anything else, I've cloned the repo once again and just copied over my .env file.


episode 2: Mini-app to use as teaching vehicle

From April 21 meeting:

hands-on example of offloading a loop, to get everyone excited. Needs to be prepared so people can compile for CPUs and GPUs and compare performance etc
could be an MPI code that can be compiled for CPUs with MPI or GPUs with OpenMP
this could be the final version of a code that we gradually improve throughout the workshop

https://enccs.github.io/openmp-gpu/miniapp/ now has the mini-app
If we still want some intro material to CPU OpenMP then we can do that also


automate debug process for tests execution

Too often to reproduce the issue and analyse the root cause we have to open project, compile it and run in debug mode based on stacktrace info.
I'd like to have ability to start debug process via right click.
based on information about test suites, env etc we just re-run it with new ci_run_id and using eclipse web start everything with debug end points based on stacktrace.
As only we achieve code line we shouold sent notification somehow: email, slack, hipchat etc

at first I'll be satisfied with such implementation:

add appropriate Debug menu item for test run
-> the similar approach should be achieve if someone start job on Jenkins with checked "Debug" argument
Zafira start job or read it's url and build_number from CI
Using jenkins api analyze job logs until we receive something like
waiting for connection on host 8000 port...
After that it should notification (popup message in zafira which can be closed only manually via click or maybe email) with content like:
"You have 10 minutes to connect remotely using your IDE to host:port to start debugging"
Optionally incorporate timer into the popup message.
Popup should disappear:
a) by user single click
b) as only job raw log changed - that's means we achieved timeout or user successfully connected


How to add timeout?

Wraith capture too quickly. How to add timeout for loading pages?

http://bbc-news.github.io/wraith/#beforeCapturehooks
e.g. http://bbc-news.github.io/wraith/#CasperJSbefore_capturemodule


fix: 避免公有云绑定秘钥后解密密码为空

这个 PR 实现什么功能/修复什么问题:
避免公有云绑定秘钥后解密密码为空
是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3593 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3593      +/-   ##
=========================================
- Coverage    6.96%   6.96%   -0.01%
=========================================
  Files         499     497       -2
  Lines       83677   83441     -236
=========================================
- Hits         5832    5813      -19
+ Misses      77347   77132     -215
+ Partials      498     496       -2

Flag
Coverage Δ

#aFlag
6.96% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.6% <0%> (ø)
:arrow_up:

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)
:arrow_up:

pkg/cloudcommon/db/lockman/inmemory.go
62.19% <0%> (-4.88%)
:arrow_down:

pkg/baremetal/manager.go
0.52% <0%> (-0.01%)
:arrow_down:

pkg/cloudprovider/fakeregion.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/guestdrivers.go
20% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/region.go
0% <0%> (ø)
:arrow_up:

pkg/compute/guestdrivers/base.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/securitygroup.go
0% <0%> (ø)
:arrow_up:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed050e6...eac3ff7. Read the comment docs.

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm

/approve


Add new address discovery schemes for testing and benchmarking

Relates to issue #100
Overview
This adds supplementary address discovery schemes for benchmarking.
Some things related to creating wallets needed to be moved around to accommodate.

@rvl I've changed the base the master and resolved conflicts.


Index and landing page Bug

If any body want to contribute in this issue then read it very careful

you have remove or rename  (file name - landing page) to (file name - Index.html)
there is already present a file with name Index.html, so its totally depend on you that how can you manage it. but try to run both file separatory(I thing landing.html file is bug free so you can use that file, but try once.)
Here landing page is known as index.html file name so no need to make a separate file with any other name
file and folder structure will be as I giving you

pages
-here you set all the html page except index.html

styles
-here you set all the CSS file

scripts
-here you can set all the script files

Images
-here you can set all the type of image (if you want to convenient then create sub-folder inner this folder according to use case)

Note - Do not make any changes in any other file and folder leave as it is.

I want to work on this issue under JWOC

I would like to work on issues under jwoc

remember one thing....give me output of you completion as a link (like GitHub page link)

I want to work under this issue @codervivek5 Please assign it to me

Guys actually this issue is created by @AK-shat-JAIN so firstly I have to assign it to him. If they are not able to do it with given time then I will assign it to you guys.


Promote constants in S/R CARBON_COEFFS_PRESSURE_DEP and S/R CAR_FLUX_OMEGA_TOP to double precision

What changes does this PR introduce?
Promotes constants in S/R CARBON_COEFFS_PRESSURE_DEP and S/R CAR_FLUX_OMEGA_TOP to double precision.
What is the current behaviour?
Unlike S/R CARBON_COEFFS with numerical values that are represented as double precision (e.g. 1. _d 0), many of the calculations in S/R CARBON_COEFFS_PRESSURE_DEP contain single precision coefficients (e.g. 1.0). These single precision coefficients are multiplied by double precision tracer concentrations, which probably results in larger round off errors. Likewise, with S/R CAR_FLUX_OMEGA_TOP.
What is the new behaviour
All calculations in S/R CARBON_COEFFS_PRESSURE_DEP and S/R CAR_FLUX_OMEGA_TOP are now done in double precision.
Does this PR introduce a breaking change?
Both S/Rs have to be enabled by the user with the cpp option CAR_DISS in DIC_OPTIONS.h - it is not the default. The carbon chemistry coefficients may change slightly.

@christophernhill I compiled the model with #define CAR_DISS and was getting the following compiler message after successful completion of the run:

Note: The following floating-point exceptions are signalling: IEEE_UNDERFLOW_FLAG

This was resolved by promoting values in S/R CAR_FLUX_OMEGA_TOP to double precision. I've included it here as it fits within the scope of this PR, edited slightly.

LGTM +1
$ git clone https://github.com/seamanticscience/MITgcm seamanticscience-20180817
$ cd seamanticscience-20180817
$ git checkout pkg_dic_updates
$ docker run -v `pwd`:/MITgcm -t -d mitgcm/testreport-images:centos-7.4-20180301 /bin/bash
$ docker exec -i -t practical_edison /bin/bash
[root@94075847b703 verification]# ./testreport -t tutorial_global_oce_biogeo
parsing options...  OK (COMMAND='./mitgcmuv > output.txt')
creating the comparison code (using CC=cc)...

-------------------------------------------------------------------------------

Experiment:  tutorial_global_oce_biogeo

genmake ... successful
clean build-dir: make Clean ... successful
make depend ... successful
make  ... successful
clean run-dir ... successful
linkdata from dirs: input
 ldir=input: bathy.bin data data.diagnostics data.dic data.gchem data.gmredi data.pkg data.ptracers eedata eedata.mth fice.bin lev_clim_salt.bin lev_clim_temp.bin lev_monthly_salt.bin lev_monthly_temp.bin pickup.0005184000.data pickup.0005184000.meta pickup_cd.0005184000.data pickup_cd.0005184000.meta pickup_dic.0005184000.data pickup_dic.0005184000.meta pickup_ptracers.0005184000.data pickup_ptracers.0005184000.meta shi_empmr_year.bin shi_qnet.bin sillev1.bin tr_checklist tren_speed.bin tren_taux.bin tren_tauy.bin ;
runmodel in tutorial_global_oce_biogeo/run ... successful
=> output from running in tutorial_global_oce_biogeo/run :
>  link mitgcmuv from dir ../build
> STOP NORMAL END
There were 16 decimal places of similarity for "Press. Solver (cg2d)"
There were 16 decimal places of similarity for "Theta minimum"
There were 16 decimal places of similarity for "Theta maximum"
There were 16 decimal places of similarity for "Theta mean"
There were 16 decimal places of similarity for "Theta Std.Dev"
There were 16 decimal places of similarity for "Salt minimum"
There were 16 decimal places of similarity for "Salt maximum"
There were 16 decimal places of similarity for "Salt mean"
There were 16 decimal places of similarity for "Salt Std.Dev"
There were 16 decimal places of similarity for "U minimum"
There were 16 decimal places of similarity for "U maximum"
There were 16 decimal places of similarity for "U mean"
There were 16 decimal places of similarity for "U Std.Dev"
There were 16 decimal places of similarity for "V minimum"
There were 16 decimal places of similarity for "V maximum"
There were 16 decimal places of similarity for "V mean"
There were 16 decimal places of similarity for "V Std.Dev"
There were 16 decimal places of similarity for "p01_min"
There were 16 decimal places of similarity for "p01_max"
There were 16 decimal places of similarity for "p01_mean"
There were 16 decimal places of similarity for "p01_StDv"
There were 16 decimal places of similarity for "p02_min"
There were 16 decimal places of similarity for "p02_max"
There were 16 decimal places of similarity for "p02_mean"
There were 16 decimal places of similarity for "p02_StDv"
There were 16 decimal places of similarity for "p03_min"
There were 16 decimal places of similarity for "p03_max"
There were 16 decimal places of similarity for "p03_mean"
There were 16 decimal places of similarity for "p03_StDv"
There were 16 decimal places of similarity for "p04_min"
There were 16 decimal places of similarity for "p04_max"
There were 16 decimal places of similarity for "p04_mean"
There were 16 decimal places of similarity for "p04_StDv"
There were 16 decimal places of similarity for "p05_min"
There were 16 decimal places of similarity for "p05_max"
There were 16 decimal places of similarity for "p05_mean"
There were 16 decimal places of similarity for "p05_StDv"

-------------------------------------------------------------------------------
No results email was sent.

Y Y Y Y 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 pass  tutorial_global_oce_biogeo
Start time:  Fri Aug 17 17:50:07 UTC 2018
End time:    Fri Aug 17 17:52:17 UTC 2018
======== End of testreport execution ========
# exit
$ docker kill practical_edison

LGTM +1

@christophernhill @jahn please add the following to tag-index:
o pkg/dic:

Promote constants in S/R CARBON_COEFFS_PRESSURE_DEP and S/R CAR_FLUX_OMEGA_TOP to double precision.

I've pushed this to master.

Thanks @jahn !


Fix: Stop page DSL updates in view mode.

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes #5834
Fixes #5816

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/stop-dsl-update

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
53.76 (0.01)
35.79 (0.02)
32.31 (0)
54.33 (0.01)

:green_circle:
app/client/src/sagas/PageSagas.tsx
24.74 (1.07)
7.46 (1.31)
15.63 (0)
26.42 (0.91)

:green_circle:
app/client/src/utils/hooks/useCanvasMinHeightUpdateHook.ts
100 (0)
90 (4.29)
100 (0)
100 (0)

@marks0351 Tested the deploy preview and working fine.


Web interface cannot recover from errors

If an error is encountered when submitting pipeline jobs via the web interface the job appears to be permanently broken. Any attempts to reprocess the run lead to it sitting with Queued status indefinitely.
e.g. https://dev.pipeline.vast-survey.org/piperuns/12/

Tested in real-time using this run: https://dev.pipeline.vast-survey.org/piperuns/17/
djangoQ tables show no jobs hanging in the queue list.
Processing seems to get stuck at the very first stage of processing, i.e. here: 2021-09-08 11:10:11,493 runpipeline DEBUG Copying temp config file.
Need to check qcluster output

I could not replicate this locally. Given that job had never run successfully when it is re-run it should automatically turn on the full re-run mode, which prints out a logger message after the above line. This is the only logging message that should happen afterwards, which means something is hanging in this bit of code, that's my best guess. But yeah it might show in the actual qcluster output.
https://github.com/askap-vast/vast-pipeline/blob/7bab8fd7d854560c4e9da7d36d4d07d6134ac164/vast_pipeline/management/commands/runpipeline.py#L97-L192
A working log file would look like:
2021-09-08 10:54:05,530 runpipeline DEBUG Copying temp config file.
2021-09-08 10:54:05,593 runpipeline INFO Cleaning up pipeline run before re-process data
2021-09-08 10:54:05,612 runpipeline INFO Cleaning up forced measurements before re-process data

Managed to reproduce locally after all, the real error is:
11:53:47 [Q] INFO Process-1:2 processing [test-data-ui]
11:53:48 [Q] ERROR Failed [test-data-ui] - [Errno 2] No such file or directory: '/Users/adam/GitHub/vast-pipeline/pipeline-runs/test-data-ui/config_prev.yaml' : Traceback (most recent call last):
  File "/Users/adam/anaconda3/envs/vast-pipeline-dev/lib/python3.7/site-packages/django_q/cluster.py", line 436, in worker
    res = f(*task["args"], **task["kwargs"])
  File "/Users/adam/GitHub/vast-pipeline/vast_pipeline/management/commands/runpipeline.py", line 220, in run_pipe
    config_diff = pipeline.config.check_prev_config_diff()
  File "/Users/adam/GitHub/vast-pipeline/vast_pipeline/pipeline/config.py", line 522, in check_prev_config_diff
    label="previous run config",
  File "/Users/adam/GitHub/vast-pipeline/vast_pipeline/pipeline/config.py", line 254, in from_file
    with open(yaml_path) as fh:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/adam/GitHub/vast-pipeline/pipeline-runs/test-data-ui/config_prev.yaml'

which comes about because of this bit below which is missing the same check but for a UI run.
https://github.com/askap-vast/vast-pipeline/blob/7bab8fd7d854560c4e9da7d36d4d07d6134ac164/vast_pipeline/management/commands/runpipeline.py#L151-L158


Memory leaks

Is your request related to a problem? Please describe.
There's several memory leaks that result in problems when the maya plugin unloads wips.
This thread will be used to note the findings of the inspection.
Describe the solution you'd like
These instances should be fixed.
Describe alternatives you've considered
N.A.
Additional context
Create an exit callback (call onexit(myCallback)), place a breakpoint on start and in the callback and take 2 snapshots to diff.

// Make sure we free the data objects we allocated.
for (auto& data : m_data)
{
	delete data;
}

In frame_graph.hpp Destroy function
Auto doesn't provide clarity about the type; but the type is void*. This means that it doesn't call free or the destructor of the object.

PhysicsEngine::destroy is never being called, leaving behind bullet's resources.
Memory impact
The biggest impact as bullet allocates several memory pools (est. 60%)

texture_pool ptr is potentially never reset; leaving behind some memory.
Memory impact
Not that much (est. 5%)

[ ] aiScene* isn't being cleaned up
[ ] Viknell probably still has materials left over
[ ] Sponza probably still has materials left over

[ ] Models don't clean up their allocated materials
[ ] Physics component doesn't clean up the rigid bodies, shapes, etc.

[ ] Thread pool enqueue leaks memory

[ ] Build acceleration structure task doesn't clean up the CB

Possible issues to look into further:
Left-over data includes; C++ initialization data which should be taken care of by the program finishing unloading. Other than that; file streams seem to have temporary memory that may or may not be deleted after program end.

Even though CPU memory leaks are mostly cleaned up, there could potentially still be GPU memory leaks.


TypeScript getProductTrades with options fails

TypeScript 2.8.1
const opts = { before: 1599086, after: 1599088, limit: 10 };
const trades = await publicClient.getProductTrades('BTC-USD', opts);

Results in a ts error:
TS2345: Argument of type '{ before: number; after: number; limit: number; }' is not assignable to parameter of type 'callback<any>'.
  Type '{ before: number; after: number; limit: number; }' provides no match for the signature '(err: any, response: Response, data: any): void'.

It appears that ts is matching the first def instead of the second here: https://github.com/coinbase/gdax-node/blob/master/index.d.ts#L165
Perhaps it is the newer version of TypeScript, but I'll throw up a small pr with one fix for it.

Fixed in #307


[ macOs - Asp.net core 1.1 ] Error at startup if node-gyp is on node-modules

Hello guys,
Since yesterday, I configurer my Asp.net core with Webpack and some loader in macOs. Sass-loader or node-sass seems to have a dependency to node-gyp so it was it is present in my node modules.
Firstly, after the package installed I get this errors in visual studio code :

That just warning so I didn't investigate a lot on them.
After all my configuration done, I start my application and I got this error :

This issue did not block me because I juste have to delete the folder to make work my application but every time the node module are reload or updated, I need to delete the node-gyp folder.
I create here an issue, if is not your responsibility I will create a issue for asp.net core team.
Thanks

It's not wholly clear to me what you are trying to do.  node-gyp is a build tool and one of its components is Find-VS2017.cs.  You are not supposed to invoke it directly.

I'm not invoking it. The package is on my node_modules folder and an exception as raised by asp.net core.

Let me rephrase: node-gyp is a script that you invoke from the command line to build add-ons (native modules) for node.js.  You should not be building it as part of your project.

Ok. So it's why I can delete without breaking anything.
So for this case what I should do :

continue deleting the folder to run my app?
open an issue in asp.net core ?
Something else...

The module that depends on node-gyp should probably remove it from its dependencies.  There is rarely a reason to take a direct dependency on node-gyp and in fact it's something of an anti-pattern.
I'll go ahead and close this out as it's not a node-gyp issue.

I'll go ahead and close this out as it's not a node-gyp issue.

There is something interesting here. Find-VS2017.cs is behind an if (process.platform == 'win32') so it should not be run on macOS.
@AlexTeixeira you said you are running it on macOS?

node-gyp isn't run.  VS Code rounds up everything ending in .cs and packages that up in an assembly.

@refack Yes I'm running my app using VS Code in macOS.
@bnoordhuis I will have a look to the dependencies of my packages and I will do the necessary. Thanks for your time and your explanations.


Star Wars Saga Edition New Feature Bonus HP tracker

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Add a new number box and heading in the HP section to allow players to track hit points on their character sheets.

Character Sheet Info Roll20 Internal Use only.


Custom Visual not updating in realtime on dashboard

I am fairly new to custom visual development.  I have a pretty simple control that allows you to select a bunch of fields and it displays a number of values in the last/bottom record in some HTML.   It works fine on a report and brings in new data (from stream analytics into a Power BI data source) if I hit refresh.   However, when I pin to a dashboard, it doesn't update like other controls.   Is there something special I need to implement to get the update method called again with new data?   My capabilities.json is below, hopefully something simple.  Is there maybe some documentation I'm missing?
{
"dataRoles": [
{
"displayName": "TextFields",
"name": "textFields",
"kind": 2
}
],
"dataViewMappings": [
{
"table": {
"rows": {
"for": { "in": "textFields" },
"dataReductionAlgorithm": { "bottom": { } },
"rowCount": { "preferred": { "min": 1 }, "supported": { "min": 1 } }
}
}
}
]
}

Is "textfield" a date? cos otherwise it won't get sorted right. The data in a DB is always considered unsorted, and we try to sort it by the role. Alternatively you can create a sort for a column while modelling the data in Power BI desktop.

I hope you got this to work, closing this issue, please reopen if you have an update or further questions.


Lint/UnneededDisable reports a warning if rubocop:disable all is used inside a block with already disabled cop

If # rubocop:disable all is used inside of code block with some cops already disabled, Lint/UselessAssignment reports a warning. For example for code:
# rubocop:disable Style/ParallelAssignment
# rubocop:disable all
x, y = 1, 2

Actual behavior
$ rubocop /tmp/1.rb
Inspecting 1 file
W

Offenses:

/tmp/1.rb:1:1: W: Lint/UnneededDisable: Unnecessary disabling of Style/ParallelAssignment.
# rubocop:disable Style/ParallelAssignment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/tmp/1.rb:2:1: W: Lint/UnneededDisable: Unnecessary disabling of Style/ParallelAssignment.
# rubocop:disable all
^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 2 offenses detected

Expected behavior
No warnings reported, # rubocop:disable all is used to disable all remaining cops, not all initially enabled cops.
RuboCop version
$ rubocop -V
0.43.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.1 x86_64-darwin16)

It's not the Lint/UselessAssignment cop that reports the warning but Lint/UnneededDisable, which, according to the comments in the code, was just build for this very case. Excerpt:
# This cop detects instances of rubocop:disable comments that can be
# removed without causing any offenses to be reported.

So I guess this is the expected behavior. You can disable the cop by simply adding
Lint/UnneededDisable:
  Enabled: false

to your .rubocop.yml.

Damn, I didn't really read the offense output. :-) Not a bug indeed.

Ouch, yeah, subject mentioned a wrong cop.
I still think that there is an issue: right now there is no way to disable all cops in situations like:
class Whatever
  # So so code
  # rubocop:disable Cop1,Cop2,Cop3
  def method_one
  end

  def method_two
  end

  # Code is total garbage
  # rubocop:disable all
  def method_three
  end
end

which is quite useful during cleanups (i. e. we do not want to introduce new offenses in the first part and don't care about second part because no one has touched it yet).
AFAIU right now we can:
a) Disable Lint/UnneededDisable via magic comment
b) Enable all disabled cops before rubocop:disable all
c) List all cops one by one instead of all
Less than elegant, I'd say.
As I've said in the first comment, I expect # rubocop:disable all to disable all remaining cops, not all initially enabled cops.
And, even if my reading of # rubocop:disable all expected outcome is wrong, Lint/UnneededDisable should not emit two warnings: one of the magic comments is in fact necessary to disable Cop.

Absolutely. Lint/UnneededDisable should only report Unnecessary disabling of all cops for rubocop:disable all when it's not needed. Saying Unnecessary disabling of Style/ParallelAssignment for that line makes no sense. Reopening.

The cop Lint/UnneededDisable ...

...detects instances of rubocop:disable comments that can be removed without causing any offenses to be reported.

(see https://github.com/bbatsov/rubocop/blob/ec3123fc3454b080e1100e35480c6466d1240fff/lib/rubocop/cop/lint/unneeded_disable.rb#L6)
This is clearly the case in a file with
# rubocop:disable Style/ParallelAssignment
# rubocop:disable all
x, y = 1, 2

So

Expected behavior: No warnings reported

should not be the expected behavior. If this cop wouldn't detect an offense here, I'd call it a bug.


chore(release): release 10.0.0

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

社区互助可以把 GitHub Discussion 加上去，另外是否可以考虑把 gitter 入口去掉了？那里我们基本没有在跟社区互动

页脚看着样式有点奇怪，最后一列宽度太小了

社区互助可以把 GitHub Discussion 加上去，另外是否可以考虑把 gitter 入口去掉了？那里我们基本没有在跟社区互动

把gitter换成github discussion吧

GitHub Discussion 加好了，页脚是justify-content: space-between 应该是我们只有 3 列看上去太松散的原因 😟


feature : implementing BitNet

Can you add an example of BitNet from Microsoft : https://github.com/kyegomez/BitNet ?

I would be very cautious about using references from unofficial implementations, especially from keygomez. FYI https://www.reddit.com/r/LocalLLaMA/comments/15spxn3/potential_scammer_on_github/

I don't think we are going to add this to MLX examples. It's still a bit niche. I would love to see a community contribution though!

@awni would you be able to point me in the right direction for how I would think about doing this? Basically the key is being able to support the linear layer instead being either binary or ternary.

@RonanKMcGovern you have two options:

Simulate the bitnet ops with casting and quantization / dequantization before matmuls.
Implement the quantized kernels themselves with custom gradients

Maybe you could say more about your goals here though.. in either case training will probably be a lot slower (but the first case would be way slower).

Thanks Awni, probably my goals were ill-conceived.
Seeing the BitNet and 1.58 papers, I had thought there could be merit -
both for a) reducing VRAM and b) reducing FLOPS - in using smaller 1-2 bit
kernels.
However, it appears that:

Hardware doesn't support less than fp8 (although Blackwell will support
fp4). So you're always up/down casting during inference, which costs time.
Training actually isn't stable in any of these smaller formats. Even
Nvidia TransformerEngine upcasts a lot. So there isn't so much gain on
training speeds (maybe a tiny bit in forward pass).
So one is left with two options:
a. Quantize a pre-trained model to 1/1.58 bits to save on VRAM - but
quality will be bad doing just that, and further training will be required.
b. Train a 1/1.58 bit model from scratch. But who is going to do that at
the 7B scale - because it's possibly slower than training in bf16...
(perhaps even if the results of BitNet do scale and quality is good in
1/1.58 format).

On Wed, Mar 20, 2024 at 5:03 AM Awni Hannun @.***>
wrote:

@RonanKMcGovern https://github.com/RonanKMcGovern you have two options:

Simulate the bitnet ops with casting and quantization /
dequantization before matmuls.
Implement the quantized kernels themselves with custom gradients

Maybe you could say more about your goals here though.. in either case
training will probably be a lot slower (but the first case would be way
slower).
—
Reply to this email directly, view it on GitHub
https://github.com/ml-explore/mlx-examples/issues/512#issuecomment-2008664828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASVG6CWKFAAFSAYIUW4D4CTYZEKBJAVCNFSM6AAAAABEBQMXQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGY3DIOBSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yea I agree with your assessment


FAQ Section Accordion width changes when collapsed

Should have a standard width when opened or closed.

Assign this on me. Thanks!

See #151 pul request for the fix


set client_max_body_size to 10M

The Jira documentation suggests setting client_max_body_size to 10M

By default Nginx allows 1MB file to be attached into JIRA. So, parameter client_max_body_size is necessary to set the maximum size of attachment that can be uploaded into JIRA

Did not see it in the location or server context in the nginx container.

This is servers default:
client_max_body_size  100m;

great, thanks for checking!


Some fixes for rank_genes_groups

Most importantly, this fixes https://github.com/theislab/scanpy/issues/754.
Also solves this problem https://github.com/theislab/scanpy/issues/753.

Fantastic!
Two questions:

Was the issue from the indexing?
How does this compare to other implementations? Is it equivalent?

Yes, the problem was in the indexing.
Do you mean equivalent to scipy.stats.mannwhitneyu? No it isn't, as scipy.stats.mannwhitneyu doesn't support matrix inputs. Also rank_genes_groups doesn't support tie correction yet, but i'm going to add it.

Yeah, I was thinking scipy.stats.mannwhitneyu though I'm not sure if that does an approximate or exact test.
It would be good if we could match some gold standard implementation.

It is also approximate, so the comparison will be valid after i add the tie correction.


Fixed #32028: Less padding around top-level form rows

https://code.djangoproject.com/ticket/32028#ticket
I think it would be an improvement if the h1, h2, fieldset labels and individual labels were aligned. It didn't bother me before but since updating to Django@master with the new h2 ("Startseite") subtitle (which I like!) it hasn't stopped bothering me.
I have checked collapsible fieldsets, tabular and stacked inlines – they all look alright.
Before:

After:

Closing per ticket.


Change to correct  Event import

I'm closing this PR in favor of this one:
https://github.com/doublesymmetry/react-native-track-player/pull/1516


Configurable location of binary

This change solves the issue of paths and other binaries conflicting with the name.
In my case, there's a RubyGem called tilt that also has the binary called tilt installed and was taking the precedence (because of the Ruby version manager).
Having the environment variable available, I can now have it configured and the check can be performed targeting the correct binary location.

filed as https://github.com/tilt-dev/tilt/issues/4167

As of Tilt 0.19.6+, sys.executable can be used to reliably get the path to the Tilt binary that's running!
(See tilt-dev/tilt#4436)


Update to last stable version of PyNaCl

I'm using bigchaindb-driver (hence bigchaindb, hence cryptoconditions) in another project. PyNaCl 1.1 has some nice improvements for nacl.secret that I'd like to use.
In the CC code we just use nacl.signing. Tests are all green, so everything should work as expected.

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   85.94%   85.94%
=======================================
  Files          17       17
  Lines         804      804
=======================================
  Hits          691      691
  Misses        113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54ffe8...1186081. Read the comment docs.

we'll also need to create a new release probably


How to zoom to current location?

What is the best method to zoom into the device's current location on the map? Would it be to use fitToCoordinates and pass the current location coords into it?

  With iOS, you can simply add "followsUserLocation" to your MapView.

what about android?

@Clcll Answer is correct.
If you have the proper latitude and longitude coordinates you can adjust the delta values for zooming.
This applies to both iOS and Android.

Do you need to set the lat and lng variables with the geolocation API or do those default to the user location in this context?

You will have to set it using the geo location API.

Thanks!

Hi @christopherdro
const DEFAULT_PADDING = { top: 40, right: 40, bottom: 40, left: 40 }

navigator.geolocation.getCurrentPosition(
      ({coords}) => {
        this.map.fitToCoordinates([coords], {
          edgePadding: DEFAULT_PADDING,
          animated: true,
       })
      },
      (error) => alert('Error: Are location services on?'),
      {enableHighAccuracy: true}
    )

But actually, now the map can't focus on my current location automatically because the zoom scale is wrong. Do you know what can I do to solve this problem?

@hanpanpan200 animateToRegion can center on a coordinate and allows you to set deltas:
    navigator.geolocation.getCurrentPosition(
      ({ coords }) => {
        if (this.map) {
          this.map.animateToRegion({
            latitude: coords.latitude,
            longitude: coords.longitude,
            latitudeDelta: 0.005,
            longitudeDelta: 0.005
          })
        }
      },
      (error) => alert('Error: Are location services on?'),
      { enableHighAccuracy: true }
    )


NodeClient initialization fails intermittently when attempting to pull get scala version

Describe the bug
NodeClient initialization intermittently fails when trying to pull package metadata.
Seems to be attempting to grab the scala version from the package version, and getting it in an unexpected format.
Introduced here:
https://github.com/ClickHouse/spark-clickhouse-connector/commit/6dd82f18f77166af50c79faa0c83f90255817922
Expected behaviour
Doesn't blow up.
Error log
2024-09-06T06:47:24.942658739Z java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
2024-09-06T06:47:24.942665879Z 	at com.clickhouse.spark.client.NodeClient.userAgent$lzycompute(NodeClient.scala:51)
2024-09-06T06:47:24.942667819Z 	at com.clickhouse.spark.client.NodeClient.userAgent(NodeClient.scala:45)
2024-09-06T06:47:24.942671599Z 	at com.clickhouse.spark.client.NodeClient.<init>(NodeClient.scala:70)
2024-09-06T06:47:24.942675009Z 	at com.clickhouse.spark.client.NodeClient$.apply(NodeClient.scala:38)
2024-09-06T06:47:24.942681709Z 	at com.clickhouse.spark.ClickHouseCatalog.initialize(ClickHouseCatalog.scala:77)
...

Environment

Apache Spark version: 3.5
Scala version: 2.13
Connection version: 0.8.0

ClickHouse server

ClickHouse Server version: 0.2.5

Hi @mikech-goodcover
Thanks for the feedback looking into it

I was testing with our example code works fine

So I am guessing this has something to do with shading.  It would be nice if we could wrap the whole thing in a try/catch and fall back to using the generic string

I planned to do this, but I would like to reproduce it.
Can you describe how you are running it?


react up to 18 ,npx create-react-app my-app --template redux command not work

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^17" from<EMAIL_ADDRESS>npm ERR! node_modules/react-redux
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

Yeah, it's a known issue with CRA, React 18, and NPM.  Please see https://github.com/reduxjs/react-redux/issues/1881#issuecomment-1083185140


[HttpParser] New component

Port the mongrel http parser to PHP. Or maybe the node one.
Also provide adapters for PHP extensions:

httpparser-php (mongrel)
php-httpparser (node)

Also consider checking out #233.

See https://github.com/reactphp/http/issues/14 and https://github.com/reactphp/http/issues/19


Update the README to include macOS trigger for Swift CI

@ahoppen Sounds good, I will add the support for Linux PR testing tomorrow.

Wow, this is amazing! Thank you for making it happen @shahmishal !

@swift-ci Please test macOS platform


GdipBitmapSetPixel doesn't support indexed formats

Returns InvalidParameter

Just as note on windows trying with .NET Core it isn't supported either:
Message: System.InvalidOperationException : SetPixel is not supported for images with indexed pixel formats.
Although in the documentation Bitmap::SetPixel there's no hint for this. There's only

When calling this method, you should use a member of the System.Drawing.Imaging.PixelFormat enumeration that contains a specific bits-per-pixel (BPP) value. Using System.Drawing.Imaging.PixelFormat values such as Indexed and Gdi will throw an System.ArgumentException.

(source)
but this should be unrelated.


⚠ GitHub has degraded performance

In 19865a9, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 262 ms

Resolved: GitHub performance has improved in 2b1ad44.


Upgrade CalculiX version to 2.8p2 in JuliaFEM/CalculiX-cmake

Very first step should be to use the latest sources from here http://www.dhondt.de/ccx_2.8p2.src.tar.bz2.
I did initial diff already. Most of the files are changed. This can be very easy or very laborious depending how much changes there have been made for the sources when uploaded to the JuliaFEM/CalculiX-cmake repository.

I broke this. In Calculix-cmake repo there is a tag "point_of_return" if you want to get the yesterday's working version.

I really broke it. It won't work even when I try to go back in time. https://gist.github.com/TeroFrondelius/9ec22e3aaae3ce876d91

I have isolated the problem to two files:

https://github.com/JuliaFEM/CalculiX-cmake/blob/master/src/fortran/gauss.f
https://github.com/JuliaFEM/CalculiX-cmake/blob/master/src/fortran/xlocal.f

error messages are:
tero@tero-Dell-System-XPS-L321X ~/dev/CalculiX/deps/builds/CalculiX $ make
Scanning dependencies of target calculix
[  0%] Building Fortran object CMakeFiles/calculix.dir/src/fortran/gauss.f.o
Error: Unexpected end of file in '/home/tero/dev/CalculiX/deps/src/CalculiX-cmake/src/fortran/gauss.f'
make[2]: *** [CMakeFiles/calculix.dir/src/fortran/gauss.f.o] Error 1
make[1]: *** [CMakeFiles/calculix.dir/all] Error 2
make: *** [all] Error 2

Any help is appreciated.
tero@tero-Dell-System-XPS-L321X ~/dev/CalculiX/deps/builds/CalculiX $ make
Scanning dependencies of target calculix
[  0%] Building Fortran object CMakeFiles/calculix.dir/src/fortran/xlocal.f.o
Error: Unexpected end of file in '/home/tero/dev/CalculiX/deps/src/CalculiX-cmake/src/fortran/xlocal.f'
make[2]: *** [CMakeFiles/calculix.dir/src/fortran/xlocal.f.o] Error 1
make[1]: *** [CMakeFiles/calculix.dir/all] Error 2
make: *** [all] Error 2

I think those two files shouldn't be compiled at first place. I think I now have a working system for debian style linux systems (Ubuntu, Mint etc.). Can somebody try to run this build.jl? Tests will take some time to run.


⚠ Bofrost.de has degraded performance

In 08336d5, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 802 ms

Resolved: Bofrost.de performance has improved in 5fb7ea4 after 13 minutes.


feat(kit): add appearances for toggle component options

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x ] Feature
[ ] Refactoring
[ ] Build or CI related changes
[ ] Tests related changes
[ ] Documentation content changes

What is the current behavior?
Closes https://github.com/Tinkoff/taiga-ui/issues/4765
What is the new behavior?

I'm not sure whether any extra work needs to be done to handle the loader/icon colours if the user modifies the appearance.


Project deployment

A link to the online version of Microverse
🚀 Live Demo

Live Demo Link

STATUS: APPROVED :green_circle: :clap:
Hi @yin-ka 🙋♂,
Your project is complete!  There is nothing else to say other than... Great job 👏

Congratulations! 🎉
TO HIGHLIGHT:

Your project is professional :heavy_check_mark:
Your repo is professional :heavy_check_mark:
Well-structured files :heavy_check_mark:
Professional README.md file 💯
No linter errors :heavy_check_mark:

Now you can merge this branch and move on :1st_place_medal:
Optional suggestions

Kindly refer to the inline optional suggestions made. Ensure to apply them to have a professional project that suits recruiters' needs.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
HAPPY CODING AND GOOD LUCK WITH THE COMING ONES :crossed_fingers: :four_leaf_clover:


Handle loading client-side certificates in egress gateways

Describe the feature request
There are cases when non-Istio-managed client certificate must be used for some hosts, in particular in the case of egress gateway performing mTLS with an external service. While DestinationRule allows specifying a client certificate and a private key in https://istio.io/docs/reference/config/networking/v1alpha3/destination-rule/#TLSSettings, it does not allow to specify the specific pod (for example the egress gateway) where the certificate/key must be loaded. Using the DestinationRule with client certificate in TLSSettings causes all the Envoys in the namespace to try to load the certificate/key and to fail in case the certificate/key are loaded in a single pod only.
The current "exportTo" field specifies namespaces. The proposal is to change the semantics, in the backward-compatible way:
exportTo: "./app=label" # export to the pods with label app=label in the current namespace

When the label part is omitted in the value of exportTo, the semantics is as previously:
exportTo: "." # export to all the pods in the current namespace.

Describe alternatives you've considered

Deploy the pod with client certificate/key in a separate namespace. Can be wasteful in the terms of namespaces, and also not feasible in some cases, for example in OpenShift, where namespaces can have separated networks and there could be a requirement to deploy the gateway pod in the same namespace with the application pods.
Mount client certificate/private key in all the pods in the namespace. Not good security-wise.

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context
Will solve https://github.com/istio/istio/issues/9659.

cc @rshriram

Any activity on this request ?

Any update on this feature? Or is there any workaround to specify caCertificate only available for relevant pod?

@saurabhygk no updates yet, sorry.

An alternative solution: add a selector to the DestinationRule, so it will be used at specific pods or gateways, similarly to VirtualService's https://istio.io/docs/reference/config/networking/virtual-service/#L4MatchAttributes sourceLabels/gateways fields.

Another alternative solution: Filtered out DestinationRules (also known as upstream clusters in Envoy) that are not referenced by any VirtualService. This filtering along with the VirtualService sourceLabels / gateways fields, can provide the same functionality of eliminating specific DestinationRules from specific pods.

The current behavior (Istio version 1.4, xDS enabled, mutual TLS mode) is that istio-proxy ignores an upstream cluster that is defined with a missing certificate/key (the certs are NOT mounted to the pod).
Here is the warning message that envoy (istio-proxy) reports when it receives from pilot an upstream cluster with missing certificate:
[Envoy (Epoch 0)] [2019-12-04 15:38:58.163][19][warning][config] [external/envoy/source/common/config/grpc_mux_subscription_impl.cc:82] gRPC config for type.googleapis.com/envoy.api.v2.Cluster rejected: Error adding/updating cluster(s) outbound|80||exampledr.myns.svc.cluster.local: Invalid path: /tmp/certs/myclientcert.pem, outbound|80|v1|exampledr.myns.svc.cluster.local: Invalid path: /tmp/certs/myclientcert.pem

Here is the DestinationRule that defines the missing certificate/key:
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: exampledr
spec:
  host: exampledr.myns.svc.cluster.local
  trafficPolicy:
    tls:
      mode: MUTUAL
      clientCertificate: /tmp/certs/myclientcert.pem
      privateKey: /tmp/certs/client_private_key.pem
      caCertificates: /tmp/certs/rootcacerts.pem
  subsets:
  - name: v1
    labels:
      version: v1

@vadimeisenbergibm do you think that this behavior is good enough ?

This issue should be taken into consideration in the design of the new APIs for DestinationRules, for Istio 1.5/Istio 1.6.
cc @duderino @louiscryan @rshriram

So the other pods rejecting entire CDS  because it contains one single cluster which intended only for egressgateway. Is that the problem?

@incfly No, currently the other pods rejecting ONLY the single cluster which intended only for the egress-gateway. That is, the other pods do not reject the entire CDS.

Then it's not that bad, only causing extra warning/error log, and traffic
can still flow as it should be? Or do I miss anything? What other harm it
does for current behavior?
On Thu, Dec 5, 2019 at 10:02 PM Idan Zach<EMAIL_ADDRESS>wrote:

@incfly https://github.com/incfly No, currently the other pods
rejecting ONLY the single cluster which intended only for the
egress-gateway. That is, the other pods do not reject the entire CDS.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/15517?email_source=notifications&email_token=AAMVXB7YK4ZKZEGMZ3N4QJDQXHTIFA5CNFSM4IDKYJI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGDDTUY#issuecomment-562444755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMVXBYVC53UWUK7BGIUEITQXHTIFANCNFSM4IDKYJIQ
.

@incfly you don't miss anything. No other harm, except the extra warning log message.
My thought is that it is good enough for now. For the next Istio releases, we may want to consider extending the DestinationRule API to support a list of gateways (similar to what is currently supported by the VirtualService API).

I tried adding a DR in a new namespace with exportTo: "." with egressgateways installed in that namespace (this namespace is not istio-system). I still see that Pilot is trying to push certificates for the cluster to all sidecars instead of just to egressgateway. This is with 1.3.6.

we are hitting this on 1.4.7, 1.5.1

any update on this one? seeing this on 1.5.5.

Ran into the same issue today and spent a significant amount of time debugging.  I have a work around for now which is to scope the DestinationRule as only exported to the namespace of the egress gateway as mentioned above but also deploy the egress gateway to its own namespace.
Not sure if this is related to: https://github.com/istio/istio/pull/12234 but i have read through a long list of historical issues it seems that Istio treats the istio-system namespace differently when applying DestinationRules and seems to ignore them if they are marked as not exported.

I am using istion 1.5.5/
I have been hit by a similar problem too.
I am not using an egress gateway but doing TLS origination directly from one pod.
The problem is that another pod, which does not care about that, does not start as it cannot find the certificates specified in the destination rule.


Fix/docs2

Summary
I'm breaking up #2687 into several smaller pieces as the other PR was error'ing out in some odd places and that large of a PR is hard to debug. I think I'm going to do it like

[ ] Fix up documentation website
[ ] Fix up docs for meta functions like value_type_t etc.
[ ] Several small Prs to remove errors from argument 'x' from the argument list of <FUNCTION> has multiple @param documentation sections

Tests
Only doc changes so no new tests
Side Effects
Nope
Release notes
Update math library documentation
Checklist

[ ] Math issue #(issue number)

[x] Copyright holder: Steve Bronder
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Thanks so much for finishing the revised PR.
I'm not going to review, because I don't understand the new math lib's C++ well enough.  Ideally, someone would have the time to follow along and see if the instructions work.    Barring that, I'd suggest someone who understands the C++ already.  Perhaps @rok-cesnovar or @wds15 or @andrjohns?

That's reasonable. If any of the three of yinz also have contributions that you think would help out the docs absolutely feel free to add to the branch!

Will review it this weekend! Thanks Steve!

Are there any objections to committing @rok-cesnovar's grammar suggestions and then merging this? I've had a few people recently ask me about getting started docs here

Are there any objections to committing @rok-cesnovar's grammar suggestions and then merging this?

Yes, I think it's better than what we have now and I don't think @SteveBronder has much time to revise.
I gave Steve a pile of feedback on the text---I just didn't want to be a final reviewer because I don't understand the C++ well enough and don't have time to verify it all.

Hey srry! Been busy ill look at this tmrw and make the changes

No worries Steve! I wasn't asking to try to rush you, but more ask if you wanted someone else (e.g. me) to go through Rok's suggestions and then merge this

I just went through all of @rok-cesnovar's grammar and spelling line edits, so assuming he is okay with the content of this I believe we should merge after CI


chore(main): release 0.32.0

:robot: I have created a release beep boop
0.32.0 (2023-05-11)
Features

Settings: Math Typesettings #71 (#74) (9e9c00f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/samuele-cozzi/obsidian-marp-slides/releases/tag/0.32.0 :sunflower:


Plv next

Latest changes made to both uCentral base client, as well as platform (brcm) specific changes

Ack from @phwhite
We can merge this;


update accumulo from 1.6.5 to 1.8.1

Addresses #242

@6487927a Would you be able to sign the license and make the minor change?

@6487927a - thanks very much for making the change, looks good.
I can't really merge the pull request in until you have signed our Contributors License Agreement. Are you able to do that?

@p013570 No worries at all.
I sent the agreement email on Monday shortly after your comment.  I've sent another with more information just in case.

@6487927a - sorry to be a pain, but the email doesn't seem to be coming through. Just to confirm, this the email template:
Email address<EMAIL_ADDRESS>Subject: GCHQ OSS Contributor License Agreement
Body:
Full name:
Email:
GitHub ID:
Date:

No worries, I understand - sorry I'm the one being the pain!  That's the address I've sent it to both times along with the supplied Subject and Body.
If this is too much of a hassle, I have no problems with you just making the minor changes and pulling them in yourself rather than accepting this.

@6487927a - no, we do really appreciate you making the effort to spot the bug and fix it for us!
I'm rather confused as to where your email is disappearing to. I've tested the mailbox a couple of times and it seems to be working perfectly. It must be being filtered somewhere. It would be nice to attribute the changes to you and accept your pull request if possible.

Merged in via: https://github.com/gchq/gaffer-tools/pull/350


How to know if a user is a subscriber

Hello! I am a newcomer, so please do not swear too much.
My searches are at a dead end.
I need to check if the user is a follower to the channel. Is there a ready-made solution for this?
Can you help me?

Why would we swear?
You title says "subscriber" but the post says "follower" so I'll give you both:
To determine if a user is a subscriber in a chat message, check the badges object in the tags for "subscriber":
client.on('message', (channel, tags, message, self) => {
    if(self) return;
    const { badges = {} } = tags;
    if(badges.subscriber) console.log(tags.username, 'is a sub');
});

tmi.js has no way to determine a follower, you need to use either the Helix (new) or Kraken (old) API. This is unrelated to tmi.js and that official documentation has plenty of information.


Error:Execution failed for task ':app:packageDebug'. --- Duplicate files copied in APK

Error:Execution failed for task ':app:packageDebug'.
Duplicate files copied in APK META-INF/services/javax.annotation.processing.Processor
File 1: abc.gradle\caches\modules-2\files-2.1\com.google.auto.service\auto-service\1.0-rc2\51033a5b8fcf7039159e35b6878f106ccd5fb35f\auto-service-1.0-rc2.jar
File 2: abc.gradle\caches\modules-2\files-2.1\com.pushtorefresh.storio\sqlite-annotations-processor\1.2.1\ac96eb5d2267f6e6e457a0e9e3a2f482782a1b08\sqlite-annotations-processor-1.2.1.jar
this helped:
exclude 'META-INF/services/javax.annotation.processing.Processor'

I'll close this since it's not the problem of StorIO itself, but a problem of dependencies with same info in META-INF.
@Rainer-Lang thanks for publishing, may be it'll help somebody who will google that!


requireSafeContextKeyword to enforce use of safeContextKeyword

Would be great if the use of a "safeContextKeyword" could be enforced. Maybe even with a setting to allow the use based on the function line count?

.jscsrc
{
  "safeContextKeyword": ["self"],
  "requireSafeContextKeyword": true
}

valid:
var obj = {
  // ...
  func: function() {
    var self = this;
    self.foo = 'bar';
  }
}

invalid:
var obj = {
  // ...
  func: function() {
    var self = this;
    this.foo = 'bar'; // usage of `this` is disallowed, use the safe context keyword
  }
}

.jscsrc
{
  "safeContextKeyword": ["self"],
  "requireSafeContextKeyword": "allButTinyPredicates"
}

valid:
var obj = {
  // ...
  func: function() {
    var self = this;
    self.foo = 'bar';
  },

  func2: function() {
    return this.func(); // valid now, because the method has less than two lines;
  },

  equals: function(val) {
    return this.foo === val; // valid now, because the method has less than two lines;
  }
}

<bountysource-plugin>
---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10186116-requiresafecontextkeyword-to-enforce-use-of-safecontextkeyword?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).
</bountysource-plugin>

Thanks for contributing @smeijer. This proposal sounds like a great candidate for a custom plugin. Unless others chime in on this PR, I'd vote for it not being in core.
By using safeContextKeyword, you're already enforcing that it's used (when needed). Your proposal would also have to ban use of .bind(this) if I understand correctly.
I'll wait for the opinions of other contributors before closing this issue.
cc @hzoo @TheSavior @alawatthe

Bind would not necessarily be banned. However the use of this will be for most part.
function () {
  var self = this;
  return self.color;
}.bind(car);

function parent () {
  var self = this;

  var child = function () {
    var self = this;
    return self.foo;
  }.bind(self);
}

The idea is to limit the usage of this, as it is a lot harder to trace the context of this, than the context of a property you've named yourself. You're not really enforcing such a thing by using safeContextKeyword. You're only enforcing that the context is given a certain property name when the developer is binding the context to a defined property.
For example "safeContextKeyword": ["self"] is not forbidding anything in the snippet below:
myObj = (function () {
  var self = this;

  self.foo = 'Foo';
  this.bar = 'Bar'; // this should be a problem, property should be referenced as 'self.bar'

  var instance = {
    baz: 'Baz',

    getFoo: function () {
      return this.foo; // an error should be highlighted here, possible unwanted context change
    },

    getBar: function () {
      return self.bar; // this one is ok
    },

    getBaz: function () {
      var self = this; // switch context explicitly
      return self.baz; // a property of 'instance'
    }
  };

  return instance;
}());

myObj.getFoo(); // returns undefined
myObj.getBar(); // returns 'Bar'
myObj.getBaz(); // returns 'Baz'

I agree with @mrjoelkemp that this should be a custom plugin, since it is a kind of special coding style. I don't want to criticize your (@smeijer) coding style in any way, I just never had problems, not knowing what this refers to. Furthermore, with the rise of arrow functions in ES6 the need to bind this or the use of a safe context keyword will decrease a lot, making the stuff around this a lot clearer. So requiring the use of a safe context keyword feels a bit weird.
On a site note: Not knowing what thisrefers to might be caused by code which is too complicated. So this might indicate the need for refactoring. In this light, requiring a save context keyword feels a bit like trying to fight the result (not knowing what this refers to) and not the cause (complicated code).

I agree @mrjoelkemp. This is definitely a plugin. @smeijer thanks for the feedback. I'm going to close this now. Let me know if you disagree.


Completion of non standard package?

I have code with external package import:
package main

import "gopl.io/ch4/github"

func main() {
	github.|
}

But there is no completion appears after I type github.| (pipe is cursor position).
Is it supposed to complete external packages at all? At the moment it does not.
If yes, could you please advise, what needs to be done in order to enable external package completion?
Here is my config:
let g:deoplete#enable_at_startup = 1
let g:deoplete#enable_smart_case = 1
call deoplete#custom#set('_', 'matchers', ['matcher_full_fuzzy'])

let g:deoplete#sources#go#gocode_binary = $GOPATH.'/bin/gocode'
let g:deoplete#sources#go#use_cache = 1
let g:deoplete#sources#go#json_directory = $HOME.'/.config/nvim/plugged/deoplete-go/data/json/1.6.2/darwin_amd64'

me too.
`let g:deoplete#enable_at_startup = 1
let g:deoplete#sources#go#gocode_binary = '/Users/kevin/.go/bin/gocode'
let g:deoplete#sources#go#package_dot = 1
let g:deoplete#sources#go#use_cache = 1
let g:deoplete#sources#go#json_directory = '/Users/kevin/.cache/deoplete/go/darwin_amd64'
`

@vbauerster @weghst Hi, thanks issue :)
Maybe, this problem caused by gocode original behavior. (and not issue, it's gocode normal behavior.)
If there import *** word in your code, gocode will parse ***.a file such as $GOPATH/pkg/darwin_amd64/gopl.io/ch4/github.a
So, If you want to complete of gopl.io/ch4/github method, needs go install gopl.io/ch4/github.
I was tested that flow, and it will work :)
Could you try it?

@zchee You are right, a custom package needs to be installed first, before it can be referenced by gocode. So after I run go install gopl.io/ch4/github, completion of the package started to work properly.
Thanks, for you valuable note!
I assume the issue may be closed now)

Closed.


Terrible item duplicate bug!

Open cooking station GUI, move curser on the water bar, then press Q, water bar will drop on ground and can infinitly duplicate. Please fix it!

Got it, will get to fixing this when I can.

Should now be fixed the the newest versions of the pack for 1.20.4, 1.20.6, and 1.21


java.lang.IllegalArgumentException: maxWidth(836) must be >= than minWidth(3024)

Please complete the following information:

Library Version [e.g. v1.0.0]
Affected Device(s) [All devices]

Describe the Bug:
`FlowRow(
modifier = modifier
.padding(all = 12.dp)
.fillMaxWidth(),
maxItemsInEachRow = rowSize,
horizontalArrangement = Arrangement.spacedBy(2.dp),
){
// ...
Box(
modifier = Modifier
.padding(top = 2.dp)
.clip(itemCorner)
.border(0.5.dp, Color(0x33000000), itemCorner)
.background(Color(0x33FFFFFF), itemCorner)
.aspectRatio(1f)
.weight(1f)
){
   GlideImage(
                                    imageModel = item.url,
                                    contentDescription = "",
                                    contentScale = ContentScale.FillBounds,
                                    modifier = Modifier.fillMaxSize()
                                )

}
}
`
Add a clear description about the problem.
Crashed when used in Flow with weight set to 1.
Turn to normal when i change GlideImage to use Image .
java.lang.IllegalArgumentException: maxWidth(836) must be >= than minWidth(3024)                                                             	at androidx.compose.ui.unit.ConstraintsKt.Constraints(Constraints.kt:424)                                                             	at androidx.compose.foundation.layout.OrientationIndependentConstraints.toBoxConstraints-OenEA2s(RowColumnImpl.kt:339)                                                             	at androidx.compose.foundation.layout.FlowLayoutKt.breakDownItems(FlowLayout.kt:635)                                                             	at androidx.compose.foundation.layout.FlowLayoutKt$flowMeasurePolicy$1.measure-3p2s80s(FlowLayout.kt:235)                                                             	at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:103)                                                             	at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)                                                             	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:323)                                                             	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)                                                             	at androidx.compose.foundation.layout.PaddingModifier.measure-3p2s80s(Padding.kt:364)                                                             	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:323)                                                             	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)                                                             	at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)                                                             	at androidx.compose.ui.node.BackwardsCompatNode.measure-3p2s80s(BackwardsCompatNode.kt:323)                                                             	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:155)                                                             	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1090)
Expected Behavior:
Diaplay as normal .
A clear description of what you expected to happen.

Hey @kevinroy-lo, would you provide the full context of your usage? Thanks!

Sorry, my mistake. The issue I mentioned earlier about the problem with using 'weight' in Compose within FlowRow is not caused by landscapist. Although the problem has been resolved, I still don't quite understand why it is necessary to set a width before using 'weight' in FlowRow, or else the previous issue may occur again.


Imported the generated semantic convention constants

Imported the generated semantic convention constants and replaced string literals with constants
Minor code style improvements (variable names clashing with package names)

The inclusive language checker brings up a good point: The links that go to the "master" branch of the Otel spec should be updated to "main" as the branch was renamed.
This would have to be fixed in our spec repository.


Add performance testing suite

Inspired by Martin Thompson's talk at http://codeforward.pl

So, although the build time has increased, the aim here is to analyze the output and reduce the general (not performance) testing time so that the build comes in below 3 minutes again.


adds role_id and role search params

Coverage increased (+0.01%) to 82.05% when pulling b508e97c41a182c4591caa13971ce5f336b8b009 on feature/canvas-roles into 2204c9b3f227d99a27a8c2da519f96e13592be06 on develop.


Re-Write Entire application as MVVM for better testing

Create an MVVM application to help with testing to not re-introduce bugs when changing

Not seeing how to covert application to MVVM renaming to just rewrite the application


Feat:Want to Enhance Ui of Contact Us Page

Describe the feature
Currently the Contact US section is Looking Odd I want to fix this
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

hey @himanshu-03 @Anushkabh Can i start working on this pr or is there any issue??

hello @nishant0708 !
you can start working on this issue.
Happy Coding ✨

Hello @himanshu-03 I want to work on this Issue #609 Feat:Want to Enhance Ui of Contact Us Page
Record

[ x] I agree to follow this project's Code of Conduct
[ x] I'm a GSSOC'24 contributor
[ x] I want to work on this issue


entity: multiple choice

please :eyes: @inyono @Knorrke

LGTM

updated logic to represent spec. kinda messy tho

still LGTM


Investigate predict() error

The current output for predict only returns overpass predictions between midnight and 12:59pm local time. The sgp4 propagation is probably correct, so the error is most likely within the conversion from TEME to ECEF coordinates in propagate() or somewhere in predict_passes()

The error was coming from an incorrect rotation matrix operation in rotations.teme2ecef()
Fixed in commit 51077d1891bf8831ce3614492ac640bb13e4e6c7


More details for workflow notes

00-workflow.md should include details on:

how to set up branch protection rules to require status checks to pass, require code owner review and (optionally) require additional reviewers
procedure for PRs, e.g., the reviewer who opens a conversation should resolve it when they think it's been resolved (not the submitter of the PR); how to alert people you want their review, both the first time and subsequent times; approximate time frames for review; relationship between issues and PR; how to scope a PR; etc

Also, general notes / resources on how to do PRs, like https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests

This seems helpful I'm not amazing at reviews :smile:

technical details about how to make changes and open PR, either from branch or fork
PR opening checklist (following should also be addressed in readme, docs):

[ ] search existing PRs, issues, and forums, and discuss on existing thread if it exists.
[ ] If it doesn't exist, before opening PR, contact developers. Can set on repo-to-repo basis: open issue or talk on forum.

PR scope: as limited as possible, ideally address a single issue. This makes it easier to review, as well as to work in parallel.

example, addressing basis class refactoring in GLM package. that's a pretty big set of changes, but they're all related. This PR should not include: additional bases (BSplines), additional functionality (plots of the basis functions). PR should focus on refactor of class.

How to review:

if any new functionality has been added, run the code
check that following checklist has been completed

Review checklist. These things must be true for PR to merge and should be talked about in PR template.

[ ] Sll status checks pass (automated)
[ ] Any new functionality must include tests, docstrings, and (if substantial) documentation. Documentation required if new concept is added or existing one defined.

For basis refactor: should include notebook to show how to construct and visualize bases, as well as a docs page to define structure

[ ] For classes that are important (e.g., synthesis methods in plenoptic, bases and GLM classes in GLM), write validation function(s) which are used in tests and referenced in documentation.
[ ] Bugfix PR: check that PR fixes bug (i.e., run locally), and that test has been added to address it. If substantial enough bug, document? If related to existing issue, that issue will have discussion about context, why it's important, etc. If PR is about a new bug, then an issue should be opened if it's above a threshold for any of: complexity (requires discussion), number of lines of code, or we think users might search for it in the future (e.g., broken install, unexpected exception)
[ ] Documentation PR:

Discussion question: how much of the above belongs in workflow notes vs. tests notes? probably, describe details in documentation or test notes, and refer to them from workflow notes.

CONTRIBUTING should also define the git workflow (INTERSECT lesson)

Should probably also describe how to make a good PR, some ideas here


fix: remove constraint for Firebase/Crashlytics iOS SDK dependency.

Using Capacitor 5, we can using another dependency for Firebase/Crashlytics.
This plugin requires you to use iOS Firebase/Crashlytics 8.12.1.
This PR allow to use Firebase/Crashlytics >= 8.12.1 for iOS and avoid to get this error:

[!] CocoaPods could not find compatible versions for pod "Firebase/Crashlytics":
In snapshot (Podfile.lock):
Firebase/Crashlytics (= 9.3.0)

In Podfile:
CapacitorCommunityFirebaseCrashlytics (from ../../node_modules/@capacitor-community/firebase-crashlytics) was
resolved to 3.0.0, which depends on
Firebase/Crashlytics (= 8.12.1)

@robingenz

@clemdesign I already reviewed your code a week ago and added a comment.

@clemdesign Sorry, this was my mistake. The review was still pending.

Please push this amendment through soon, much appreciated ;)

I close this as not planned, see https://github.com/capacitor-community/firebase-crashlytics/pull/80#discussion_r1417878457.


Avoid derefrencing nil when RLMValidateMatchingObjectType is passed a nil object

Fixes #2407.

/cc @tgoyne @segiddins

:+1:

:+1:
Test failure is unrelated (testNotificationsForChangesWhileSuspended).