Fix propTypes warnings

Fixes prop types warnings in dev mode

Building app in separate branch.

@josephbaylon I'm fixing some snapshots here.. any reason why would you want to build the PR using the CI? this should only affect dev environment

@enahum I'm testing both. I want to make sure the CI build also still works

@josephbaylon be my guest, but changes are only around property types, no changes in release mode should be visible..

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14903
https://circleci.com/gh/mattermost/mattermost-mobile/14902

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/14903
https://circleci.com/gh/mattermost/mattermost-mobile/14902

Artifact links:
https://14903-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://14902-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

Artifact links:
https://14903-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.apk
https://14902-70265724-gh.circle-artifacts.com/0/tmp/artifacts/Mattermost_Beta.ipa

Failed to delete ref. @mattermost/core-build-engineers have been notified. Error
DELETE https://api.github.com/repos/mattermost/mattermost-mobile/git/refs/heads/build-pr-5285: 422 Reference does not exist []

Cherry pick is scheduled.


Edtran/security Fix eslint

@grantborthwick yes, it's part of the build pipeline

@shurane yes, they were added from eslint suggestions


Ambiguous mapping. Cannot map 'xxx.TestFeignClient' method  xxx.TestFeignClient#invoke(String) to {GET /test/invoke}: There is already 'testController' bean method xxx.TestController#invoke(String) mapped.

Describe the bug
Caused by: java.lang.IllegalStateException: Ambiguous mapping. Cannot map 'xxx.TestFeignClient' method
xxx.TestFeignClient#invoke(String)
to {GET /test/invoke}: There is already 'testController' bean method
xxx.TestController#invoke(String) mapped.

Sample
@RestController
@RequestMapping("/test")
public class TestController {
    @Autowired
    private TestFeignClient testFeignClient;

    @GetMapping("/invoke")
    public String invoke() {
        return testFeignClient.invoke();
    }
}

@FeignClient("some-service")
@RequestMapping("/test")
public interface TestFeignClient {
    @GetMapping("/invoke")
    public String invoke();
}

I want to explain why does TestFeignClient write like this.
In fact, the interface of service provider is similar to TestController. When I want to access it with OpenFeign, a quick way is to copy it to my project and change @RestController to @FeignClient, and then delete the method body. right?
Back to the topic, why does the handler defined by OpenFeign conflict with the handler of spring mvc?

The essence of the problem seems to be that as long as @RequestMapping appears on the class, it will be registered into springmvc.
The relevant code looks like: org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping#isHandler.
protected boolean isHandler(Class<?> beanType) {
    return (AnnotatedElementUtils.hasAnnotation(beanType, Controller.class) ||
        AnnotatedElementUtils.hasAnnotation(beanType, RequestMapping.class));
}

I am confused, why the judgment condition is not just AnnotatedElementUtils.hasAnnotation(beanType, Controller.class)?

Yes, @RequestMapping should not be there at class level in a Feign Client.


Update Bootstrap Italia

Bump boostrap-italia to newer release.
This may break things.

Confirmed, this breaks the search results visualization. It also introduces some glitches in the auto-complete forms.


Flask app refactor

Since this is a refactor, I want to make sure it works beyond a few initial tests. Given that I did this in PyCharm (using their "smart" move/refactor feature) and didn't really change any functionality, just pulled functions to different files, the likelihood of regression is fairly low.
I will test it this weekend and ensure functionality is intact.

@mattastley Just tested error cases (using geo_shape instead of geo_point), the cache, and standard cases (plotting points, filters, etc.).
The only thing I haven't yet tested is plotting ellipses; however, that code didn't change, and I included unit tests for it.
Regarding the failing unit test. What should the default behavior be of split_fieldname_to_list? I assumed you were trying to do
foo.keyword -> ["foo"]

but it looks like it's implemented to do
foo..keyword -> ["foo"]

Anyway, this is ready to merge as far as I can tell.

BTW, I'd recommend squashing and merging so you don't have all 37 commits in master.

split_fieldname_to_list

You are correct, it should be:
if field[-1] in ('raw', 'keyword'):


Nlog unusable on Google Pixel devices due to failing to load extensions (present or not)

Type (choose one):  Bug
NLog version: 4.4.12 (happens on 5.0.0-beta09 as well)
Platform: . Xamarin Android

What is the current result?
On all google Pixel devices we have (a Pixel and 3 Pixel XLs), NLog fails to load the configuration file, so no logging occurs. We have many other types of phones, and this ONLY occurs on those Pixel devices.

This seems to happen at the point when extensions are attempted to be loaded. We are not using any extensions.
The line that searches for them fails with an exception:

System.UnauthorizedAccessException: Access to the path '/' is denied.

This happens on this line in ConfigurationItemFactor.cs (line 378)
var extensionDlls = Directory.GetFiles(assemblyLocation, "NLog*.dll")
		.Select(Path.GetFileName)
		.Where(x => !x.Equals("NLog.dll", StringComparison.OrdinalIgnoreCase))
		.Where(x => !x.Equals("NLog.UnitTests.dll", StringComparison.OrdinalIgnoreCase))
		.Where(x => !x.Equals("NLog.Extended.dll", StringComparison.OrdinalIgnoreCase))
		.Select(x => Path.Combine(assemblyLocation, x));

What is the expected result?
The config file should be loaded and NLog should be able to log as configured.

Are there any work arrounds? yes/no
I commented out that section searching for exceptions and NLog functions correctly for me again. This works since we aren't using any extensions, but the inability to search for them is a larger issue, seemingly with just Google Pixel devices.

That would help with my issue, but does it make sense why this is happening only on Pixels.
Also does that mean that extensions would just be unsupported on Pixels?

I think the root cause is that the value of assemblyLocation is wrong. I think it's / on the pixel device. Is that something you could check with the internal log?

That is the case, but it's the same on every phone I've tested. On all the phones, this is what I see:
assemblyCodeBase	  =  {file:///NLog.dll}
assemblyCodeBase.LocalPath   = "/NLog.dll"
assemblyLocation   ="/"
But only on the Pixel devices does passing "/" into Directory.GetFiles throw an exception.

@jpajak If you configure the NLog-setting throwExceptions=false (or use NLog.LogManager.ThrowExceptions = false;)
Then it should only log a warning, and continue to load the NLog-configuration.

I double checked the code. This is indeed a warning when throwExceptions=false (as @snakefoot)
That should be OK, we could lower the warning to debug, but I don't seen any benefit in that.
Of course, don't use throwExceptions=true in production.


Accessing nested maps from JS

I am returning maps to my script by using:
ProxyObject.fromMap(mapper.readValue("{\"a\":\"b\":\"nes\"}", Map.class)) where mapper is a Jackson instance. The problem with this is that the result is of type LinkedHashMap and the engine doesn't seem to play well with it (i.e. it is doesn't work like a JSON object where I can access fields).
For single level objects I can cast the result of readValue to Map<String,Object> (and it works well) but for nested objects, the 2+ levels will still be LinkedHashMap
(i.e. {a: JavaObject[java.util.LinkedHashMap]})
What is the preferred way to achieve this? Is it possible?

Hi @cemremengu
you might want to implement your own kind of MapProxy for that. See an example in https://github.com/oracle/graal/blob/c53864afa586192fe12ac0ac07430c936f3fc7cc/truffle/src/com.oracle.truffle.api.test/src/com/oracle/truffle/api/test/host/ExampleOptions.java#L58
Especially the getMember function there - either return the value, or if it is a nested array, wrap it in a Proxy again.
//CC @woess @chumer
Best,
Christian

Thanks works great!


[Bug]: JSONForm Add missing accent colors and enable missing properties access to JS convertible fields

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Few fields have missing accent color
Some properties' JS enabled text input does not have access to sourceData/formData/fieldState

Steps To Reproduce
FIelds that should have accent colors
CHECKBOX
CURRENCY INPUT
DATEPICKER
EMAIL INPUT
MULTILINE TEXT INPUT
MULTISELECT
NUMBER INPUT
PASSWORD INPUT
PHONE NUMBER INPUT
PHONE NUMBER INPUT
RADIO GROUP
SELECT
SWITCH
TEXT INPUT

Properties that have missing access to sourceData/formData/fieldState when JS mode enabled
Theme controls - borderRadius, boxShadow
Steps

Drop JSONForm
Go to field configuration of any field
Enable js mode for borderRadius
Type {{sourceData}}, it would not get evaluated.

Public Sample App
No response
Version
Release

Reducing the scope of this issue.
Not all properties that have missing access to sourceData/formData/fieldState will be fixed in this issue but only those which got introduced recenlty at the time of writing this and that are not present in production. These properties are accentColor boxShadow and borderRadius
The rest of them will be handled separately as they pose a risk which needs to be evaluated thoroughly


Create Load Process For the Data

Load the data for just this small module once the schema is created as part of #21

@rscottlundgren , please assign this to me. Once this is finalized with all of the data for the sqlite db, if we decide to move to postgres I will create an issue for that.

Closing this issue as this relates to the POC for the sql lite portion which is not going to be used for going forward.


Getting Time out issue often when trying push new bala to central

Description:
Getting Time out issue often when trying push new bala to central
Steps to reproduce:
We are getting the following issue when we try to push a new bala to central. This doesn't happen always. It gets success for some instances & fails for some instances.
Ballerina.toml structure
[package]
org = "rolandhewage"
name = "cdatatest.jira"
version = "0.2.0"
license= ["Apache-2.0"]
authors = ["Ballerina"]
keywords = ["CData","jira"]

[[platform.java11.dependency]]
path = "../../libs/cdata.jdbc.jira.jar"

Package includes following files
Ballerina.toml
main.bal
Package.md
 failed to push the package: 'rolandhewage/cdatatest.jira:0.2.0' to the remote repository 'https://api.central.ballerina.io/2.0/registry/packages'. reason: timeout

Affected Versions:
SL Beta 1
OS, DB, other environment details and versions:
Ubuntu 20.04
JDK 11
Suggested Labels (optional):
Area/Central

I was able to push the same package using curl. Timeout issues usually come when there connection issues.

Please reopen if issue exists. Try using a different ISP.


Underline changed portions of strings and comments

Sometimes the bold styling is too subtle.

Dupe of #328


[INTEGRATION] Artifact error

sandbox-example.ipynb returns
FileNotFoundError: [Errno 2] No such file or directory: './models/7d78b3e35db94de195ece4634cc7c389'

This is caused by the paths not being propagated from notebooks to workers.
One solution is to define the paths everywhere are environment variables.
The other solution is rely on ray's own mechanism for propagation of those variables.
In all cases, the artifact store must be a shared storage.

I get this error after deleting all data files from the artifacts folder, then running examples .ipynb.


bpf: Reset Pod's queue mapping in host veth to fix phys dev mq selection

Fix TX queue selection problem on the phys device as reported by Laurent.
At high throughput, they noticed a significant amount of TCP retransmissions
that they tracked back to qdic drops (fq_codel was used).
Suspicion is that kernel commit edbea9220251 ("veth: Store queue_mapping
independently of XDP prog presence") caused this due to its unconditional
skb_record_rx_queue() which sets queue mapping to 1, and thus this gets
propagated all the way to the physical device hitting only single queue
in a mq device.
Lets have bpf_lxc reset it as a workaround until we have a kernel fix.
Doing this unconditionally is good anyway in order to avoid Pods messing
with TX queue selection.
Related: #18311
Reported-by: Laurent Bernaille<EMAIL_ADDRESS>Signed-off-by: Daniel Borkmann<EMAIL_ADDRESS>Link: https://github.com/torvalds/linux/commit/edbea922025169c0e5cdca5ebf7bf5374cc5566c

/test

I tested this patch on a test clusters and it worked great (details on the test here : https://github.com/cilium/cilium/issues/18311#issuecomment-1006685252)

(updated commit desc)

/test

/test


workflows: fix docker hub pushing

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Fix second docker tag in workflow.
#7543

Thanks @dawidd6!


Y coordinates wrong for certain PDFs leading to highlighting wrong areas in the PDF

I am using pdfplumber which is built on top of pdfminer.six
But the issue is the coordinates coming from pdfminer.six.
Here is the pdf
v2.pdf
The characters when highlighted appear like this. There is a huge offset in y direction.

With the method get_bbox() from the Document in the konfuzio sdk  you can easily access the correct information of each character in your document.
It includes the character itself and the bounding box.
# pip install konfuzio_sdk
# in working directory
# konfuzio_sdk init
from konfuzio_sdk.data import Project
my_project = Project()
document = my_project.documents[0]
character_info = document.get_bbox()

The output is something like:
{'character_id': {'bottom': 243.0, 'line_number': 2, 'page_number': 1, 'text': 'I', 'top': 228.0, 'x0': 568.0, 'x1':<PHONE_NUMBER>285714, ... }
For more info check our website

Can you share the code that you are using to create this image?

Also seeing this issue when using pdfplumber https://github.com/jsvine/pdfplumber/issues/538 (that apparently depends on this lib for extraction). y coords are way off, x coords are correct. Extracting from bank statements so unfortunately not shareable directly.
A couple of anecdotal observations

When selecting text in the PDF in Preview/MacOS, line heights are much larger than expected.
When extracting characters, many have negative y-coordinates

From my experience with these types of docs they can sometimes be put together weirdly which can cause issues for extraction, there could also be issues if there are relative areas of the document then some parts would be scaled to screen size so a fixed pixel size would’nt work

Ack. My solution here was to convert source PDFs to images, rerun OCR using appropriate tessaract settings and then process with pdfminer. This resolved the two issues identified in my previous comment.


Morse2text

Created a method to decode a Morse code character, takes a string parameter, and return the corresponding character in uppercase (e.g. decode_char(".-") returns "A").

Created a method to decode an entire word in Morse code, takes a string parameter, and return the string representation. Every character in a word is separated by a single space (e.g. decode_word("-- -.--") returns "MY").

Created a method to decode the entire message in Morse code, takes a string parameter, and return the string representation. Every word will be separated by 3 spaces (e.g.
  decode("-- -.--   -. .- -- .")

returns "MY NAME").

Reused methods whenever possible. Made sure that code is DRY.

Proof added


Check symlink when trying to fetch debuginfo

Got error on parca-agent:
level=debug ts=2021-10-08T01:13:40.251386198Z caller=debuginfo.go:166 namespace=gitops-platform-storage pod=rook-ceph-osd-10-7746699478-n72kk container=osd component=debuginfoextractor msg="failed to find additional debug information" root=/proc/3820454/root err="failed to walk debug files: failed to extract elf build ID, failed to open elf: read /proc/3820454/root/usr/lib/debug/bin: is a directory"

/proc/3820454/root/usr/lib/debug/bin is actually a symlink to a directory.
/proc/3822251/root/usr/lib/debug# ll
total 4
lrwxrwxrwx 1 root root    7 Aug  9  2020 bin -> usr/bin
lrwxrwxrwx 1 root root    7 Aug  9  2020 lib -> usr/lib
lrwxrwxrwx 1 root root    9 Aug  9  2020 lib64 -> usr/lib64
lrwxrwxrwx 1 root root    8 Aug  9  2020 sbin -> usr/sbin
drwxr-xr-x 6 root root 4096 Aug  9  2020 usr

Source code of this error: https://github.com/parca-dev/parca-agent/blob/main/pkg/debuginfo/debuginfo.go#L204

I don't know if this is related, but I got the similar issue manifesting itself as:
level=warn ts=2021-10-10T13:35:15.42362483Z caller=maps.go:102 namespace=nextcloud pod=nextcloud-0 container=nextcloud msg="failed to read obj build ID" obj=/proc/3933198/root err="failed to open elf: read /proc/3933198/root: is a directory"


Optimize app icons in windows environment

Is your feature request related to a problem? Please describe
When you install an app on WSA, Its shortcut will be added to the start menu. The problem is that because most of the apps' icons have a background color, their icon is displayed smaller than other windows native apps. Take a look at Firefox lite in this picture.

Describe the solution you'd like
The solution that I suggest, is to display the legacy icon of apps in the windows menu because most of them are transparent. Applying this will at least fix this problem for some apps.
Update: Also displaying only the foreground part of the adaptive icon may do the trick.
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2301.40000.70

Can you elaborate on legacy icon? WSA gets icon from the Android app and while it's possible to do processing to remove the background, it'll need to be investigated and is not currently part of the future roadmap. Thanks for the feedback.

Can you elaborate on legacy icon part? WSA gets app icon from Android app and while it's possible to do processing to remove background of the icon, it is not currently in the future roadmap.

Can you elaborate on legacy icon part? WSA gets app icon from Android app and while it's possible to do processing to remove background of the icon, it is not currently in the future roadmap, but we'll continue to evaluate going forward.

You know there is a "legacy icon" for pre-Oreo devices in android apps.


Redesign: Implemented new text panel

Context
Implemented the new text panel except font picker.
Will fix the font picker in a follow-up PR (not yet created).
User-facing changes

Nefore
After

Testing Instructions
QA
This PR can be tested by following these steps:

Add two text elements and interact with them (individually and together) using the text style panel.

UAT

[x] UAT should use the same steps as above.

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6473

@googlebot I consent.


MacVIM doesn't load wal correctly

Hi, I can run this colorscheme on iTerm2, but not on MacVIM. All kinds of other schemes work but not this one.
On picture you can see first "set bg=dark" and "set bg=light"

Can anyone try, if he gets the same.
I am using macOS Catalina 10.15.7 and newest MacVIM

AFIK, MacVim does not respect terminal colors.  It uses its own color settings defined in the application bundle at
Colors: /Applications/MacVim.app/Contents/Resources/Colors.plist
ColorSchemes: /Applications/MacVim.app/Contents/Resources/vim/runtime/colors
Using wal colorscheme in macvim may achieve what you are after.
Alternatively, you could build a custom colorscheme starting from the vim pywal template.
Personally, I'd just use vim in terminal.

Thank you for your answer!


Blog Support Queries

Fixes #
Proposed Changes

@aprakash13 , @petebryan : a few rather important comments in this PR:
ActingProcessSHA256

The need to add ActingProcessSHA256 to the imFileEvent custom validation raises an issue we have to deal with on the validation side. We do promote normalizing as many fields even if we did not add them to the schema s they are not very common in sources, but don't do good in supporting validation for them.
That said, and expectedly for a non-schema field, using ActingProcessSHA256 in analytics presents a challenge: it is not part of the schema since file event sources do not commonly provide hash values for the process executable:

If there is a real need to get ActingProcess hash information, it is really recommended to correlate with a process event, probably based on the Acting Process Name. Maybe in this specific case, you want to correlate only with the process event (having the correct Hash for the process probably is much more important than the file names).

GuardDuty

In general, built-in tables do not need to have custom validation jsons. I have raised the issue with Amit and Alaa (who is in charge of the AWS connectors). Probably an issue with updating the validation system with the latest built-in schemas.


Added neptune to requirements for integration examples

Description
Added neptune back to requirements for integration examples as the neptune/neptune-client packages are being removed from the integration's internal requirements.
Related to: (ClickUp/JIRA task name)
Any expected test failures?
Tests on python3.11 might fail

Add a [X] to relevant checklist items
❔ This change

[ ] adds a new feature
[X] fixes breaking code
[ ] is cosmetic (refactoring/reformatting)

✔ Pre-merge checklist

[ ] Refactored code (sourcery)
[ ] Tested code locally
[X] Precommit installed and run before pushing changes
[ ] Added code to GitHub tests (notebooks, scripts)
[ ] Updated GitHub README
[ ] Updated the projects overview page on Notion

🧪 Test Configuration

OS:
Python version:
Neptune version:
Affected libraries with version:

Hey! Wanted to ask, is there a reason why we do the installation as
pip install neptune neptune-integration-name

instead of
pip install "neptune[integration-name]"

?
Just wondering if something changed from the discussion at https://neptune-labs.slack.com/archives/C01UGGJV5U0/p1678276563666419


"Once per bar close" option doesn't get selected consistently

I'm running add-alerts with the following alert config but for some reason "Once per bar close" option doesn't always get selected. Sometimes it creates an alert with "Only once" which is the default option.
alert:
  condition: # tertiary/quaternary rows might not exist for your indicator. If not remove those values
    primaryLeft: RSI
    primaryRight:
    secondary: Greater Than
    tertiaryLeft: Value
    tertiaryRight: 30
  option: Once Per Bar Close

Hi - please try re-initializing with the latest version of ATAT
Upgrade Instructions
From your tradingview-alerts-home directory, run the following:
npx @alleyway/create-tradingview-alerts-home


Close valiation readiness goroutine once it is ready

when the server is actually ready to serve, we should close the goroutine.
Signed-off-by: Chun Lin Yang<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

@ayj Thanks for your comments. I think Readiness probe is designed to let Kubernetes know when your app is ready to serve traffic. it is not designed to remove pod by k8s. it should be the responsible for Liveness probe. I do think we should add this health check in Liveness probe. What do you think?

Removed "from the service load balancer", i.e. the galley pod's IP is no longer included in the k8s endpoint ready list. This would handle transient failures. As you suggested, permanent failures should be still be handled by the liveliness probes.


[Feature]Enabling X509Certificate based authentication during ssl-termination

Currently we have X509 Certification based authentication which can work with SSL tunneling. According to the current implementation, X509 Certification based authentication will fail if load balancer configured with SSL-termination. So this need to be addressed.
A tomcat valve can be implemented to enable X509Cert based authentication during SSL termination enabled with a load balancer.

Merged with: https://github.com/wso2-extensions/identity-outbound-auth-office365/commit/80b4d0f0450fb14e94e993190936aba4a23ea907


Add @typePolicy(embeddedFields: String! = "")

@embed allows "embedding" objects in their parent records. Will be useful for pagination. This schema:
type Query @typePolicy(embeddedFields: "hero"){
  hero: Hero!
}

type Hero @typePolicy(embeddedFields: "friends"){
  friends: [Friend!]!
}

type Friend {
  name: String!
}

Will only produce a single Record. Note that it's opt-in because in the worst case where no object has an id, we could rewrite the whole cache on each query.

I updated this PR to leverage the existing @typePolicy, no only is this more in line with keyFields but it also makes possible to extend the existing types while keeping a GraphQL compatible syntax. Let me know what you think

I updated this PR to leverage the existing @typePolicy, no only is this more in line with keyFields but it also makes possible to extend the existing types while keeping a GraphQL compatible syntax. Let me know what you think

Yes, even better, smaller API surface 👍


upload react-router-performance to CDN on release

Goal
We agreed to make the @bugsnag/react-router-performance CDN bundle available on the CDN
Design
Same approach as for @bugsnag/browser-performance
Changeset
Include react-router-performance bundles in the upload script
Testing
Will need testing upon release

The release script needs to change as it will only check if the browser package has been updated before uploading to the CDN:
https://github.com/bugsnag/bugsnag-js-performance/blob/9a0eca7f223093bfa84a213d6220f939c333553c/bin/release.sh#L31-L32
The CDN upload script should probably then take the package and files to upload as arguments, so we don't need to upload everything all at once. Otherwise we'll bust the cache unnecessarily. e.g.:
# upload the browser package
$ ./bin/cdn-upload packages/platforms/browser/ build/bugsnag-performance.*
# upload the react router package
$ ./bin/cdn-upload packages/react-router build/bugsnag-react-router-performance.*

Also I'd say this shouldn't block the release — we can upload to the CDN separately if necessary to get the release out earlier


KeyError when word doesn't exist in Word2Vector model.

When using the cluster summary approach, I usually get a KeyError when summarizing a Wiki page.

Probably need to fix how sentences are vectorized.


[Issue] Unable to scroll in cart sheet.

Post adding Multiple item in the cart (10+) we are unable to should down to checkout button.

Fixed along with refactoring in commit/307cd3


sap.m.DatePicker: Asian locales should show year first in header

OpenUI5 version: latest
Browser/version (+device/version): any
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible): https://openui5.hana.ondemand.com/explored.html?sap-ui-language=ja#/sample/sap.m.sample.DatePicker/preview
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Bring up sample
Click on first icon to bring up "simple DatePicker"
Observe in the header at top that month is shown first, then year.

What is the expected result? In Asian locales such as Japanese, the year should be shown first, followed by the month.
What happens instead? The month is shown first, followed by the year.
Any other information? (attach screenshot if possible) Looks like a regression, where showMonthAfterYear isn't being set anymore. This used to work in 1.18.

Hi, I asked colleagues about this issue, unfortunately there is nothing new here.

Just a short update: no news, the ticket is still open with the responsible developer. :-(

Hi Chuck,
the responsible developer said that he asked the globalization experts and did not get a definite answer. He also talked with different colleagues about this and seems to have gotten a lot of different answers. “Asian locales” is a bit vague, and it was hard to find out for which locales this would be valid. Also the CLDR did not seem to help. The CLDR is – as you probably know – the global internationalization database we use, which is usually of high quality and is supposed to automatically handle formatting things like these. So it’s a bit unclear how to proceed.
Can you shed any light on this? Which languages would exactly be affected? How sure are you about this being wrong? Is there any public information, where we can see exactly what to do?
I haven't checked the CLDR myself, but would have expected to contain this type of information...
Thanks and regards
Andreas

At least Japanese is affected, but there may be more. The CLDR identifies the date format in the common/main/.xml files. For example, common/main/ja.xml defines:

y/MM/dd

Note the pattern shows year (y) first.

Hi Chuck, this topic seems to be a tricky one. The developer responsible for this control has come to the conclusion that he would not change anything. There have been no complaints from Japanese customers and the globalization standard owners also didn't disagree with the current way the calendar is shown. Another point is that the date formatting according to CLDR (I know: I brought this up) is not necessarily defining how the layout of a calendar should be. And the Japanese language tests were passed successfully.
So right now it does not look like this is going to be changed...
If you have strong evidence (as in: public documentation, first-hand knowledge, etc.) I guess we could do something. Sorry.


Implement care schedule screen

To implement

[ ] A user can navigate to their household's care schedule.
[ ] The care schedule is presented in a calendar-like format.
[ ] The care schedule has daily to-do items.
[ ] The days in the care schedule are colored from red to green, based on care-taking (= daily to-do items) progress.

Useful link about viewModels in SwiftUI screens


Update rules.json

Added conditions

Looks good.
If anyone has issues viewing these changes, it's likely your compendium is cached because it's big and stuff. To clear, open a console and type: sessionStorage.setItem("compendium", null); then refresh.


[Request] Better 4K/Ultrawide Support

Thank you so much for the theme! It's fantastic. However, although I know this is niche for most people, I would like to see better support for 4K and Ultrawide resolutions, as there's a lot of empty space in them.

For instance as you can see in here, there's a huge amount of empty space next to the RDR2 description. It would be great if there was an option to fill it with something - video trailers, achievement data, screeenshots, etc.
The same thing is the case with the details screen:

Is there an option to move it upwards so that there isn't so much empty space at the top?

I have the same issue. We now have to scroll down to see the trailers. The issue did not exist in the first versions of the theme.

I will look into better ultra wide support. However scrolling down in the Game Details page is not a bug, it is a feature. It was mentioned in the changelog that the Game Details page had been reworked. As this theme is based on modern UI's a lot of them have a scrolling details page, that is why I added this. The theme is always going to change and evolve. If I see a Details page on a modern UI that I like more then I will replicate it for this theme.

I understand. Good to know that it is not a bug, but a deliberate decision. Maybe the game description and trailer can be slightly moved up or down so it doesn't look like a bug. Only seeing the top part of the game description and trailer make it seems like its a bug. It cuts the information at an awkward place. Loving the Theme otherwise. Thanks for your hard work!

Thank you very much for the response! Personally my preference would definitely be to have the trailer in the top of the details screen at least, but I understand if that's not what you want to do. I'm also grateful for you looking into ultra-wide support.

Last update fixed the odd placements of the features on an ultra wide screen . Here is how it looks now :
Screenshot (4)
Better than I could have imagined it. Beautiful!
Thank you for your hard work.

I agree, it looks a lot better now - thank you.


Export dbi_resource_id's

Is your request related to a new offering from AWS?
No, it is already available on the aws_rds resources

Is your request related to a problem? Please describe.
I want to use IAM authentication (https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.IAMPolicy.html) The ARN for giving access would need the DbiResourceID's of the rds instances. I'm not able to obtain these id's from the module at the moment.

Describe the solution you'd like.

I would like to have an output for this module that has a list of dbi_resource_id's
Describe alternatives you've considered.

I have considered using the rds datasources to get these ids, but they are not available in data sources; only in resources.
Additional context

hi @psmit , this is already available https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/blob/1dbbd998ae62436eb13918d09ac0882f01ebd8e2/outputs.tf#L66

My apologies, somehow I missed this!

Actually, I replied a bit fast now. The instance ids are actually not the same as the resource ids.  Could the resource ids be added as well?

The value is present on the resource:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#dbi_resource_id
(Unfortunately I can't reopen this issue myself)

ah ok, now I see the attribute


flynn-install --clean doesn't correctly handle filesystems that are still mounted

After a failed bootstrap (due to the firewall) I had a flynn installation that was stuck with only some of the apps actually installed. Repeating the bootstrap command fails because of conflicting ports in use etc. After downloading flynn-install, I tried --clean and it failed to unmount /flynn-default as there were 3 other directories mounted inside it
flynn-default                    49233152       0  49233152   0% /flynn-default
flynn-default/data               49233152       0  49233152   0% /flynn-default/data
flynn-default/squashfs           49233152       0  49233152   0% /flynn-default/squashfs
flynn-default/ext2               49233152       0  49233152   0% /flynn-default/ext2

root@flynn:~# bash /tmp/install-flynn --clean --zpool-create-device /dev/sdb --zpool-create-options "-f"
===> 13:31:39.876 *** WARNING ***
===> 13:31:39.878 About to stop Flynn and remove all existing data
===> 13:31:39.882 Are you sure this is what you want?
(yes/no): yes
===> 13:31:41.383 stopping flynn-host daemon
===> 13:31:41.520 killing old containers
No .containerinit found running; none killed.
===> 13:31:41.549 destroying ZFS volumes
===> 13:31:41.555 running "sudo umount /flynn-default"
umount: /flynn-default: target is busy
        (In some cases useful info about processes that
         use the device is found by lsof(8) or fuser(1).)
===> 13:31:41.568 ERROR: failed to run "sudo umount /flynn-default", exit status 32
root@flynn:~#

After manually unmounting /flynn-default/*, the flynn-install command worked as expected.
root@flynn:~# umount /flynn-default/*
root@flynn:~# umount /flynn-default

Might be a dupe of #3773

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Analyse WDS widgets configs

It is necessary to analyse the widgets configs and add/remove the configuration of the properties.
Related thread: https://theappsmith.slack.com/archives/C04P60V0VQE/p1708448327343889

Hey team! Please add your planning poker estimate with Zenhub @ichik @jsartisan


Mv class return 1 for all negative integer power

The __ pow __ method claims supporting integer power but it is returning 1 for any negative integer power, it also didn't raise exception if it do not support negative integer power, the __ pow __ method should check if n < 0 and return self.inv() to the power abs(n)

@mammalwong Hi, thanks for reporting these issues! Sorry that I just noticed them.
Which version of GAlgebra are you using? Are these bugs recent regression or they existed for a long time?
P.S. I wonder what are you using GAlgebra for? Physics, computer graphics, learning GA etc.?

@utensil the version is 0.5.1. I was running the code on google colab, and it has to execute pip install galgebra whenever a new cloud machine is assigned to run my code. I have only start to use galgebra 2 days before I report this issue so I have no idea whether this issue is a recent regression or is a long existing issue.
My background is computer science and I have personal studies of traditional vector algebra based computer graphics and physics (which are mostly physics for games which are discretely approximated to just "convince" the player), I have also self studied basic geometric algebra (no geometric calculus and only GA with a diagonal metric tensor with 1/-1/0 elements, and primarily Cl(3,0,1) which is 3d projective GA for games).
I have implemented the methods in https://www.cphysics.org/article/86175.pdf to generate matrix representation of GA, I am using galgebra to crosscheck and validate whether the operations on matrix presentations are correct or not, and my main focus is to see how computational effective are GA compare to traditional vector algebra (which also have lots of hardware optimization).

Good to learn about Matrix Representations of Clifford Algebras, it would be nice to have matrix representations implemented but not a priority for me at present.
Would you be interested in discussing GA in a discord with many GA enthusiasts ? https://discord.gg/2tQZVYkD

Thanks for the discord invitation, yeah I will join it, is it the discord of bivector.net?
By the way, do you interest in how am I extending the non-degenerate GA only matrix representation generation to include also degenerate GA?

Yes, it is.
Yes, I'm also interested in degenerate GAs, and looking forwards to tests or new features in this direction.

I extended the non-degenerate GA matrix rep generation to include also degenerate GA like this: for Cl(p,q,r), I generate the matrix rep of Cl( p+r, q+r, 0) instead, then for each positive negative extra r basis pair a and b, the degenerate basis can be created as either $R_+ = (a+b)/2$ or $R_- = (a-b)/2$, choose only one of them and the other is discarded.

@mammalwong Can you also post minimal working example for this issue? Thanks!

here is an example to reproduce this issue:
ga = Ga('e', g=[1,1,1], coords=S.symbols(f"0:{3}", real=True), wedge=False)
x,y,z = ga.mv()
x**-1, ga.mv(1)/x

returns:
1, e0

expected correct output:
e0, e0

Thanks, this can be confirmed as a bug. The current implementation is naive and didn't consider negative cases. Will address it later.

@mammalwong This should also be fixed in the branch now.

@utensil I have tested this issue with the branch again, I can confirm this issue is fixed.

Thanks, it's also added to the test cases as examples/issue-511.ipynb to prevent future regression.

@utensil, looks like the current implementation of __pow__ is having $O(n)$ time complexity when raise a multivector to power n, I suggest to adopt this implementation which takes only $O(log_2 n)$:
def pow(x, y):
  if y < 0:
    x, y = 1/x, -y

  rval = 1
  y_int = int(y // 1)
  y_fictional = y - y_int
  # y_fictional always between 0 and 1
  if y_fictional > 0:
    rval *= x**y_fictional

  y = y_int
  while True:
    if y & 1 != 0:
      rval *= x
    y >>= 1
    if y == 0:
      break
    x = x * x

  return rval

# test
X,Y = 2,5.5
pow(X, Y), X**Y

Would the implementation also support non-integer powers? It doesn't look correct to me in that part.
As a symbolic library, my personal take is to prefer simple readable implementation rather than over-optimized ones. Although in this case it's simple enough, but to adopt such an implementation, much more unit tests upon more GAs and more blades are required. Your test only verified numeric x, y so far.

@utensil that implementation was copied from my previous code for other purpose, let me rewrite the code to compare with the current implementation of galgebra:
def __pow__(self, n):  # Integer power operator
        if not isinstance(n, int):
            raise ValueError('!!!!Multivector power can only be to integer power!!!!')

        x, y = self, n
        if y < 0:
            x, y = 1/x, -y

        result = S.One
        while True:
            if y & 1 != 0:
                result *= x
            y >>= 1
            if y == 0:
                break
            x = x * x

        return result

This should be still simple compare to the current O(n) implementation in galgebra

I'll be happy to take a PR to address this, with proper test coverage, and some investigation about the possibility to delegate such details to SymPy.
GAlgebra is built as a reference symbolic implementation and my usage of it relies on its correctness heavily. So I'll need to be very sure about the correctness (i.e. proper test coverage, or delegating to maintained dependencies e.g. SymPy which also breaks sometimes).
The implementation you are suggesting is simple and it's particularly good for GA, besides it's $O(\log_2 n$, x*x would be simplified a lot due to the quadratic form of GA.
But unfortunately I need to note that GAlgebra is in maintenance mode, as its maintainers are preoccupied from time to time, like I was in the last few years (when GAlgebra was almost idle, except for the changes being updated in #510 ). Lately I have more time to invest into it as I need it again for cross-library validations, so it will be actively maintained for a while.
Being in maintenance mode means that maintainers would accept PRs, fix bugs in the best effort, but will not be actively developing new features unless they need them themselves too.
In the case of the changes you're proposing, to ensure its correctness, I need 10x work to add the tests etc. for different GAs and blades, and it's not going to be a priority in weeks at least. Sorry.

Understandable and thanks for the explanation of the situation 👍

Thanks, and I've opened separate issues for them. This issue will be closed when the fixes of the original issues are merged into master.

Thank you, @mammalwong , the fix should be in master now as #510 is now merged.

@utensil thanks for the acknowledgement!


Fix condition status check in submarinerConfigController

meta.IsStatusConditionFalse only returns true if the condition type is present and set to False. So if it's not present it returns false. Use !meta.IsStatusConditionTrue  which does what we want.

/cc @skitt @aswinsuryan @sridhargaddam

/approve

/cherrypick release-2.4


Question: How to hide label

Great project and no issues for me. I'd like to hide the barchart label (Pink rectangle in image). Possible?

options:{
legends:{
  display:false
}
}

Hi @FGRibreau with this it's still showing:

options: {
          legends: {
            display: false
          },
            scales: {
                yAxes: [{
                    ticks: {
                        beginAtZero:true
                    }
                }]
            }
        }

@FGRibreau It was legend not legends ;)


PMIx MPI support in Slurm

Hello!
I'm trying to deploy a cluster with pmix installed as a slurm plugin using the "image-builder" blueprint ( https://github.com/GoogleCloudPlatform/hpc-toolkit/blob/develop/examples/image-builder.yaml ) and I can seem to get the image to build/deploy correctly.
The communication between the controller and login nodes keeps getting messed up, something similar to this https://groups.google.com/g/slurm-users/c/Q7FVkhx-bOsand this https://bugs.schedmd.com/show_bug.cgi?id=10066.
I'm guessing that I'm injecting my pmix installation stuff at the wrong moment (https://github.com/GoogleCloudPlatform/hpc-toolkit/blob/develop/examples/image-builder.yaml#L42). Also, it requires re-configuring and installing slurm so I would want to run this at the very end of everything getting setup.
My current guess is that I would actually need to make an Ansible task and follow something similar to how the “install_ompi” tasks are setup through Ansible?
https://github.com/GoogleCloudPlatform/slurm-gcp/blob/849107c9f2e8044051877de579c7308e4e655139/packer/main.pkr.hcl#L31
Is this something that is on the roadmap or possibly something that you all have done before?
Originally posted by @tomschultz-roivant in https://github.com/GoogleCloudPlatform/hpc-toolkit/discussions/2253

To summarize #2253 reported by @tomschultz-roivant:

the Slurm-GCP v5 images do not contain PMI support
support can be added in the v5 modules by installing PMIx development libraries before compiling slurm following the Slurm image building example (see below for a blueprint snippet)
More actions will be required for v6 modules because Slurm 23.11 no longer builds PMIx by default even if it is present

blueprint_name: hpc-build-slurm-image

vars:
  project_id:  ## Set GCP Project ID Here ##
  deployment_name: build-slurm-1
  region: us-central1
  zone: us-central1-a

  image_build_machine_type: n2d-standard-16
  build_from_image_family: hpc-centos-7
  build_from_image_project: cloud-hpc-image-public
  build_from_git_ref: 5.10.4
  built_image_family: my-custom-slurm
  # built_instance_image:
  #   family: $(vars.built_image_family)
  #   project: $(vars.project_id)
  # instance_image_custom: true

deployment_groups:
- group: setup
  modules:
  - id: network
    source: modules/network/vpc

  - id: slurm-build-script
    source: modules/scripts/startup-script
    settings:
      # Do not create Ansible virtual env; Install system wide Ansible below.
      install_ansible: false
      runners:
      - type: shell
        destination: prep-for-slurm-build.sh
        content: |
          #!/bin/bash
          set -e -o pipefail
          # Slurm build on Rocky8 will upgrade to python38 as part of build
          # This is not compatible with ansible-local runner
          yum install -y python3
          yum install -y pmix
          # alternatives --set python3 /usr/bin/python3
          python3 -m pip install pip --upgrade
          python3 -m pip install ansible
          python3 -m pip install selinux
          export PATH=/usr/local/bin:$PATH
          ansible --version
          ansible-galaxy role install googlecloudplatform.google_cloud_ops_agents
      - type: data
        destination: /var/tmp/slurm_vars.json
        content: |
          {
            "reboot": false,
            "install_cuda": false,
            "nvidia_version": "latest",
            "install_ompi": true,
            "install_lustre": false,
            "install_gcsfuse": true
          }
      - type: shell
        destination: install_slurm.sh
        content: |
          #!/bin/bash
          set -e -o pipefail
          ansible-pull \
              -U https://github.com/GoogleCloudPlatform/slurm-gcp -C $(vars.build_from_git_ref) \
              -i localhost, --limit localhost --connection=local \
              -e @/var/tmp/slurm_vars.json \
              ansible/playbook.yml

- group: build-slurm
  modules:
  - id: slurm-custom-image
    source: modules/packer/custom-image
    kind: packer
    settings:
      machine_type: $(vars.image_build_machine_type)
      source_image_family: $(vars.build_from_image_family)
      source_image_project_id: [$(vars.build_from_image_project)]
      image_family: $(vars.built_image_family)
    use:
    - network
    - slurm-build-script

Responding to https://github.com/GoogleCloudPlatform/hpc-toolkit/discussions/2253#discussioncomment-8572391
I suspect your issue is that you are combining pieces of 2 different blueprints and missing a setting here or there. I will suggest a complete blueprint in the next response shortly after I test it

I believe the issue you're reporting in https://github.com/GoogleCloudPlatform/hpc-toolkit/discussions/2253#discussioncomment-8572391 may be that the default partition (debug) is not using the PMIx-enabled image. Your compute partition has the correct configuration. You can test the same commands on a running cluster with srun -p compute .... where the dots represent the same flags you used without specifying the partition.
I'm still testing end-to-end blueprint but this suggestion might resolve your immediate issue.

@tomschultz-roivant for some reason I'm having a bit of trouble re-building the image from the blueprint snippet, but I do think your issue can be resolved by ensuring the default "debug" partition uses the same image as the rest of the cluster using
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm # Here is where I reference the images from the other script after I built them and confirmed they were in the GCP compute image list
        project: <project_id>

and/or specifying the "compute" partition when you run commands. This is the partition you're more likely to use for application workloads anyhow.

Sorry for my slow response. I have been trying a few things and sadly, I haven't made any breakthroughs.
For the image build script, I also tried adding yum install -y pmix pmix-devel instead of manually downloading pmix and building it.  Installing pmix with yum didn't appear to be picked up automatically and didn't put anything un /usr/local which I believe is required for slurm to pick it up.

If PMIx was installed to a standard location (i.e., with a prefix of /usr or /usr/local), then Slurm will find it and build the PMIx plugin by default. Otherwise, Slurm should be configured with the –with-pmix=path-to-where-pmix-was-installed option. The PMIx plugin will be built and installed under the Slurm location.

Ref: https://openpmix.github.io/support/how-to/slurm-support
Building pmix from source ensured that the files were in that location but slurm (23.02.7) again didn't appear to pick it up.
My next attempt will be to modify the ansible playbook to add the --with-pmi=/usr/local/pmix flag.
I have been testing by running srun --mpi=list on the login node and then srun -p compute -N 1 -n 1 srun --mpi=list to check on the compute nodes.  pmix doesn't show up in any case so far.
Image Build Blueprint:
blueprint_name: hpc-build-slurm-image

vars:
  project_id:  ## Set GCP Project ID Here ##
  deployment_name: build-slurm-1
  region: us-central1
  zone: us-central1-a

  image_build_machine_type: n2d-standard-16
  build_from_image_family: hpc-centos-7
  build_from_image_project: cloud-hpc-image-public
  build_from_git_ref: 5.10.4
  built_image_family: my-custom-slurm
  # built_instance_image:
  #   family: $(vars.built_image_family)
  #   project: $(vars.project_id)
  # instance_image_custom: true

deployment_groups:
- group: setup
  modules:
  - id: network
    source: modules/network/vpc

  - id: slurm-build-script
    source: modules/scripts/startup-script
    settings:
      # Do not create Ansible virtual env; Install system wide Ansible below.
      install_ansible: false
      runners:
      - type: shell
        destination: prep-for-slurm-build.sh
        content: |
          #!/bin/bash
          set -e -o pipefail
          # Slurm build on Rocky8 will upgrade to python38 as part of build
          # This is not compatible with ansible-local runner
          yum install -y python3 wget libevent-devel
          # alternatives --set python3 /usr/bin/python3
          python3 -m pip install pip --upgrade
          python3 -m pip install ansible
          python3 -m pip install selinux
          export PATH=/usr/local/bin:$PATH

          # Now manually install pmix in the location that slurm expects
          # Slurm defaultly looks for pmix in /usr/local/pmix
          mkdir -p /usr/local/src/pmix
          cd /usr/local/src/pmix

          # Download and install pmix
          wget https://github.com/openpmix/openpmix/releases/download/v4.2.4/pmix-4.2.4.tar.gz
          tar -xzvf pmix-4.2.4.tar.gz
          cd pmix-4.2.4

          # Slurm defaultly looks for pmix in /usr/local/pmix
          mkdir /usr/local/pmix

          ./configure --prefix=/usr/local/pmix |& tee config.out
          make -j 8 |& tee make.out
          make install |& tee install.out

          ansible --version
          ansible-galaxy role install googlecloudplatform.google_cloud_ops_agents
      - type: data
        destination: /var/tmp/slurm_vars.json
        content: |
          {
            "reboot": false,
            "install_cuda": false,
            "nvidia_version": "latest",
            "install_ompi": true,
            "install_lustre": false,
            "install_gcsfuse": true
          }
      - type: shell
        destination: install_slurm.sh
        content: |
          #!/bin/bash
          set -e -o pipefail
          ansible-pull \
              -U https://github.com/GoogleCloudPlatform/slurm-gcp -C $(vars.build_from_git_ref) \
              -i localhost, --limit localhost --connection=local \
              -e @/var/tmp/slurm_vars.json \
              ansible/playbook.yml

- group: build-slurm
  modules:
  - id: slurm-custom-image
    source: modules/packer/custom-image
    kind: packer
    settings:
      machine_type: $(vars.image_build_machine_type)
      source_image_family: $(vars.build_from_image_family)
      source_image_project_id: [$(vars.build_from_image_project)]
      image_family: $(vars.built_image_family)
    use:
    - network
    - slurm-build-script

Cluster Blueprint:
blueprint_name: psi-slurm-simple

vars:
  project_id:  ## Set GCP Project ID Here ##
  deployment_name: psi-slurm-simple-test
  region: us-central1
  zone: us-central1-a

# Documentation for each of the modules used below can be found at
# https://github.com/GoogleCloudPlatform/hpc-toolkit/blob/main/modules/README.md

deployment_groups:
- group: primary
  modules:
  # Source is an embedded resource, denoted by "resources/*" without ./, ../, /
  # as a prefix. To refer to a local resource, prefix with ./, ../ or /
  # Example - ./resources/network/vpc
  - id: network1
    source: modules/network/vpc

  - id: homefs
    source: modules/file-system/filestore
    use: [network1]
    settings:
      local_mount: /home

### STARTUP SOFTWARE ###

  - id: startup
    source: modules/scripts/startup-script
    settings:
      runners:
          - type: shell
          destination: "decompress.sh"
          content: |
            #!/bin/sh
            echo $2
            tar zxvf /tmp/$1 -C /
          args: "bar.tgz 'Expanding file'"

### Slurm Partitions and Nodes ###

  - id: debug_node_group
    source: community/modules/compute/schedmd-slurm-gcp-v5-node-group
    settings:
      node_count_dynamic_max: 4
      machine_type: n2-standard-2
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm
        project: psivant-dev

  - id: debug_partition
    source: community/modules/compute/schedmd-slurm-gcp-v5-partition
    use:
    - network1
    - homefs
    - debug_node_group
    settings:
      partition_name: debug
      exclusive: false # allows nodes to stay up after jobs are done
      enable_placement: false # the default is: true
      is_default: true

  - id: compute_node_group
    source: community/modules/compute/schedmd-slurm-gcp-v5-node-group
    settings:
      node_count_dynamic_max: 20
      bandwidth_tier: gvnic_enabled
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm
        project: psivant-dev

  - id: compute_partition
    source: community/modules/compute/schedmd-slurm-gcp-v5-partition
    use:
    - network1
    - homefs
    - compute_node_group
    settings:
      partition_name: compute

  - id: gpu_node_group
    source: community/modules/compute/schedmd-slurm-gcp-v5-node-group
    settings:
      enable_smt: true
      node_count_dynamic_max: 20
      machine_type: g2-standard-24
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm
        project: psivant-dev

  - id: gpu_partition
    source: community/modules/compute/schedmd-slurm-gcp-v5-partition
    use:
    - network1
    - gpu_node_group
    - homefs
    settings:
      partition_name: gpu

  - id: slurm_controller
    source: community/modules/scheduler/schedmd-slurm-gcp-v5-controller
    use:
    - network1
    - debug_partition
    - compute_partition
    - gpu_partition
    - homefs
    settings:
      disable_controller_public_ips: false
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm
        project: psivant-dev

  - id: slurm_login
    source: community/modules/scheduler/schedmd-slurm-gcp-v5-login
    use:
    - network1
    - slurm_controller
    # - startup
    settings:
      machine_type: n2-standard-4
      disable_login_public_ips: false
      instance_image_custom: true
      instance_image:
        family: my-custom-slurm
        project: psivant-dev

Ok I was able to get pmix working by adding the --with-pmix=/usr/local/pmix to my fork of slurm-gcp and then pulling that in the build script you shared.
see: https://github.com/tomschultz-roivant/slurm-gcp/blob/d87dfbde4e6f25b5a7d25b39c1328649f6db4b35/ansible/roles/slurm/tasks/install.yml#L54

I'll review why /usr/local appears to be necessary as the RPM description doesn't suggest it's putting any files under that path. Slurm 23.02 and below should autodiscover PMIx. It may be necessary or helpful to install pmix-devel package for autodiscovery. I am glad your are working for now, but we plan to create a reliable solution for both 23.02 and 23.11 (where autodiscovery has been disabled by SchedMD).

Sound good!  If there's anything I can do to help just let me know, I'm happy to test things or work on some tasks.  It's been a little bit since I contributed to OSS so I'm due to give back 😄

You might look at https://github.com/GoogleCloudPlatform/slurm-gcp/pull/53 for our official implementation in the Slurm-GCP v5 modules. We haven't yet published a public image based on this change, but you can use this implementation with:
          ansible-pull \
              -U https://github.com/GoogleCloudPlatform/slurm-gcp -C v5 \
              -i localhost, --limit localhost --connection=local \
              -e @/var/tmp/slurm_vars.json \
              ansible/playbook.yml

@tomschultz-roivant... we are expecting this support to be in the standard Slurm images in their next release (likely mid-April). A standard build on the latest tag will include this (in the preceding comment it was just on the v5 branch, but a git tag is part of the release process)
          ansible-pull \
              -U https://github.com/GoogleCloudPlatform/slurm-gcp -C 5.10.7 \
              -i localhost, --limit localhost --connection=local \
              -e @/var/tmp/slurm_vars.json \
              ansible/playbook.yml

Thanks! I will try this out today!

This worked great! I only tried it with Centos 7 so far. I'm also trying it with Ubuntu.

Default Slurm images with PMIx are now available on our develop branch in the Slurm-GCP 6.5.2 (#2594) and Slurm-GCP 5.11.1 releases (#2595)


BPA with Octree, core changes

This isn't any better than the other PR, please split this into multiple PRs. Removing or replacing a member of a struct should be its own PR, adding members to a struct should be its own PR, changing a function to allocate memory and return a pointer should its own PR, etc. One massive PR with all changes munged together makes it really difficult to understand what problem you were trying to solve.


crontab output prepends extra characters

I have a crontab set up to run a bash script. The output from my cron job prepends ?(B?[m. Trying to track down where this is coming from.
test.sh
#!/bin/bash

echo "Hello"

$ crontab -l

<EMAIL_ADDRESS>
* * * * * . ${HOME}/.bash_profile; ${HOME}/test.sh

Output from cron:
?(B?[mHello
I added the following to my ~/.bash_profile file to ensure that cron is using vim instead of vi:
export EDITOR=vim
alias vi="vim"

I don't think this configuration does anything to this. AFAIK I am not aware.


Add a keyboard shortcut

@estruyf thanks a lot for this plugin. A lot of people where waiting it for it: https://github.com/microsoft/vscode/issues/46505
Would it be possible to implement a keyboard shortcut to toggle comments fold / fold ?
Thanks a lot

Hi @Aarbel, yes you can do this in Visual Studio Code as follows:

Open the command palette
Use the Preferences: Open Keyboard Shortcuts command
Search for: @command:hidecomments.hide and @command:hidecomments.show
Double click on the command, and you are able to define your keyboard binding

A toggle command @command:hidecomments.togglewould be greatly appreciated to be able to bind it to one key!

^ Agreed! A toggle would be great.

Thanks again @Aarbel and @offlinemark, for the suggestion. I have added the Hide Comments: Toggle the show/hide of all comments command, you can use this command to add it with the keyboard shortcut of your choice.

More information can be found on the extension its readme.


Added creation of Config file to gather our datasets

Good to go, forgot to include the path to save the file

Thanks @muellerzr ! We're actually trying to move away from the complexity of Config in v1, so we don't want to pull all this code back in. Perhaps you can show us a failing test on the forums, then we can figure out a nice clean way to fix it?

Got it! Sure. I can do that!


AttributeValueChangedNotification for ControlConstruct

An additional AttributeValueChangedNotification would allow indicating changes that happened "somewhere" on the data tree.
This might help as a workaround, if not all the AttributeValueChangedNotifications at the technology specific modelings are supported by the hardware.

Potential Proposal:
The definition of the AttributeValueChangedNotification as it is comprised in the AirInterface modeling shall be added to the EquipmentAugment modeling.
Just the datatype of the _objectIdRef attribute shall be changed from LogicalTerminationPoint towards ControlConstruct.

This AttributeValueChangedNotification became obsoleted by the centralized definitions of notifications.


ci: merge the main and PR workflows into a single CI workflow

There are virtually no differences between the main and pr workflows. Let's combine them to a single workflow.
Additionally:

Update reusable DTE workflows to v0.9
Lock Node.js to 16.x, the latest version supported by Nx 15

@all-contributors
Please add @LayZeeDK for infra


Add DemoLink component to the mapbox.github.io/dr-ui/components/ library

Is your feature request related to a problem? Please describe.
I wanted to send colleagues from our Imagery team to the https://mapbox.github.io/dr-ui/components/ library so they could see the DemoLink component, but it does not appear in this library.
Describe the solution you'd like
Can we add  the DemoLink component to https://mapbox.github.io/dr-ui/components/ library  ?
Describe alternatives you've considered
I could just share descriptive text like this.
Additional context
@katydecorah says:

It will helpful to know if this component is needed for one or many repos
if it's only used in /help then it should likely stay in help

@domlet since this component is only used in /help right now, how about adding documentation to https://github.com/mapbox/help/blob/publisher-production/docs/components.md?
Here's a great example for DemoIframe: https://github.com/mapbox/help/blob/publisher-production/docs/components.md#demo-iframe

Added to /help repo docs in https://github.com/mapbox/help/commit/1aff5f6b66cac7b50c351ceede7f5143f0f34568 – thanks @katydecorah!


LabelEncoder doesn't handle missing values in dask series of strings

Describe the issue:
When using a LabelEncoder on a dask series with missing values (as np.nan), a TypeError is raised with "<" being undefined for floats and strings.
scikit-learn's encoder seems to handle this well for pandas and dask series. We seem to handle it well with a pandas series.
Minimal Complete Verifiable Example:
import dask.dataframe as dd
from dask_ml.preprocessing import LabelEncoder as dask_le
from sklearn.preprocessing import LabelEncoder as skl_le
import numpy as np
import pandas as pd

df = pd.DataFrame({
    "A": list("aaaabbbcccdddeeefffgggg")
})

df.loc[[0, 2, 5, 10, 21], "A"]  = np.nan

ddf = dd.from_pandas(df, npartitions=3)

# works
lenc = skl_le().fit(df["A"])
lenc = skl_le().fit(ddf["A"])
lenc = dask_le().fit(df["A"])

# fails
lenc = dask_le().fit(ddf["A"])

# but also works
lenc = dask_le().fit(ddf["A"].fillna(""))

Full Trackback:

➜ python label_encoder_repro.py
Traceback (most recent call last):
  File "/Users/paul/work/sources/dask-engineering/example-pipelines/criteo-HPO/label_encoder_repro.py", line 21, in
    lenc = dask_le().fit(ddf["A"])
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask_ml/preprocessing/label.py", line 119, in fit
    self.classes_ = classes_.compute()
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/base.py", line 315, in compute
    (result,) = compute(self, traverse=False, **kwargs)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/base.py", line 600, in compute
    results = schedule(dsk, keys, **kwargs)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/threaded.py", line 89, in get
    results = get_async(
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/local.py", line 511, in get_async
    raise_exception(exc, tb)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/local.py", line 319, in reraise
    raise exc
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/local.py", line 224, in execute_task
    result = _execute_task(task, data)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/core.py", line 119, in _execute_task
    return func(*(_execute_task(a, cache) for a in args))
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/optimization.py", line 990, in __call__
    return core.get(self.dsk, self.outkey, dict(zip(self.inkeys, args)))
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/core.py", line 149, in get
    result = _execute_task(task, cache)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/core.py", line 119, in _execute_task
    return func(*(_execute_task(a, cache) for a in args))
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/core.py", line 119, in
    return func(*(_execute_task(a, cache) for a in args))
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/core.py", line 119, in _execute_task
    return func(*(_execute_task(a, cache) for a in args))
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/utils.py", line 71, in apply
    return func(*args, **kwargs)
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/dask/array/routines.py", line 1626, in _unique_internal
    u = np.unique(ar)
  File "<__array_function__ internals>", line 180, in unique
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/numpy/lib/arraysetops.py", line 274, in unique
    ret = _unique1d(ar, return_index, return_inverse, return_counts,
  File "/Users/paul/mambaforge/envs/ml-example/lib/python3.10/site-packages/numpy/lib/arraysetops.py", line 336, in _unique1d
    ar.sort()
TypeError: '<' not supported between instances of 'str' and 'float'

Environment:

Dask version:  2012.12.0
Python version: 3.10
Operating System: M1 Mac
Install method (conda, pip, source): conda

Tags: @phobson
Hello, can I work on the issue titled "LabelEncoder doesn't handle missing values in dask series of strings #954".

@DuanBoomer I'd be happy to review a PR. Thanks for volunteering. Not that I'll be largely away from my computer this week through the New Year. So if my response time is slow, I haven't forgotten about you.

@phobson The PR will be submitted by Sunday if that's okay with you. Today is Monday.


Fix typos

Hi,
This PR fixes typos in the docs and the codes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Multiple Infinitely Repeating Sounds get stuck forever

Repro:
{
  "type": "PlayerChatAlert",
  "playerChatType": "ANY",
  "message": "*",
  "regexEnabled": false,
  "enabled": true,
  "name": "Test",
  "debounceTime": 0,
  "notifications": [
    {
      "type": "Sound",
      "path": "sound-1.wav",
      "repeatDuration": -1,
      "gain": 3,
      "fireWhenFocused": true,
      "fireWhenAFK": false,
      "fireWhenAFKForSeconds": 5
    },
    {
      "type": "Sound",
      "path": "sound-2.wav",
      "repeatDuration": -1,
      "gain": 3,
      "fireWhenFocused": true,
      "fireWhenAFK": false,
      "fireWhenAFKForSeconds": 5
    }
  ]
}

The alert above is the easiest way to reproduce this, but it can also occur if a repeatDuration: -1 sound exists in two different alerts that get triggered at the same time. What will happen is that both will play, the second one will stop, the first one will never be cancelled, regardless of what you do (including logging out, disabling the plugin, etc). The only way to recover is to completely close RuneLite.

Hmmmm...I wonder if it's because notifications are fired on their own thread. Might be a threading issue. Will probably have to put a lock on the playNext method of the player (I think that's what it's called). They're probably setting soundTimeout at the same time or some race condition. When you say the second one will stop do you mean it will stop when the first one plays? or that it will stop correctly after user interaction?

When you say the second one will stop do you mean it will stop when the first one plays? or that it will stop correctly after user interaction?

It'll stop correctly after user interaction. Although this seems to be inconsistent. Not sure exactly why, but sometimes all of the sounds that are looping cannot be canceled with user interaction, sometimes after user interaction one of them stops (seems like if that's the case, it's the last one which was triggered in order).

After doing some testing myself, it looks like this only happens if you're not using the sound queue

Ah good catch. Yeah I don't have the sound queue setting on. I didn't think of that. And the solution seems reasonable! Thank you :)


Wired PostCSS loader output

Hi,
I'm using "postcss-loader": "^2.0.6"  with the following postcss plugins, and I'm having weird post css loader output
    "postcss-cssnext": "^3.0.2",
    "postcss-import": "^11.0.0",
    "postcss-nested": "^2.1.2",
    "precss": "^2.0.0",

Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js??ref--6-2!node_modules/postcss-loader/lib/index.js??ref--6-3!src/style/index.css:
       [0] ./node_modules/css-loader?{"sourceMap":true,"importLoaders":1}!./node_modules/postcss-loader/lib?{"sourceMap":true,"plugins":[null,{"version":"6.0.11","plugins":[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null],"postcssPlugin":"precss","postcssVersion":"6.0.11"},null,{"version":"6.0.11","plugins":
[null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null],"postcssPlugin":"postcss-cssnext","postcssVersion":"6.0.11"}]}!./src/style/index.css 825 bytes {0} [built]

Is there compatible issues?  Or it might be my webpack config ?
The following is my webpack config
{
  test: /\.css$/,
  use: ExtractTextPlugin.extract({
    fallback: "style-loader",
    use: [
      {
        loader: 'css-loader',
        options: { sourceMap: true, importLoaders: 1 }
      },
      {
        loader: 'postcss-loader',
        options: {
          sourceMap: true,
          plugins: () => [
            postcssImport({ addDependencyTo: webpack }),
            precss(),
            postcssNested(),
            postcssCssnext({
              browsers: ['last 2 versions', 'ie >= 9'],
              compress: true,
            }),
          ],
        },
      }
    ]
  })
}

Thanks in advance for any help.

What do you exactly mean by 'weird' ?  The [null,null,null,null,null,null,null,null,null,null,null,null,null... stuff? Hard to believe at first but this is 'correct' and has to do with webpack internals nothing to worry about here. Check the bundle.css file for incorrect CSS, use a small setup (1-2 files) at best

Yes, I'm talking about the [null,null,null,null,null,null,null,null,null,null,null,null,null, ....
I check the css output, it seems correct.  I thought that was a bug, but not sure if anyone has that issues also.

It always appears like that, bc webpack uses a query string like syntax (JSON) postcss-loader?[options]./path/to/file.css internally an needs to handle {Function} options with additional logic to stringify them and keep the reference. The {Function} name is lost during this process and it simply displays null as the name per {Function} ¯_(ツ)_/¯

@michael-ciniawsky sorry to resurrect an old issue, but should this issue be forwarded to the webpack issue tracker? I found this page by googling postcss-loader "null,null,null,null,null".


pass down autoScrollStrategy and scrollTopOffset to the child iframe

PR: https://github.com/NationalSecurityAgency/skills-client/pull/185


Typing module considered unnecessary

As written in setup.py, google-vizier requires Python 3.9 or higher:
https://github.com/google/vizier/blob/990c23fce3450b220a9110c53769263d20524251/setup.py#L89
On the other hand, requirements.txt requires the installation of the typing module:
https://github.com/google/vizier/blob/990c23fce3450b220a9110c53769263d20524251/requirements.txt#L8
Since the typing module is a backport of the standard library typing module to Python versions older than 3.5, it is not considered necessary to install it. Indeed, this usually does not cause problems since the modules in the standard library take precedence when there is a module with the same name. However, there is no reason to keep unnecessary dependencies, so I'd suggest removing dependency on the typing module:
diff --git a/requirements.txt b/requirements.txt
index 95e07c3..a659286 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -5,7 +5,6 @@ coverage>=4.5,<=6.4.2
 protobuf>=3.6,<4.0
 mock>=3.0,<=4.0.3
 pytype>=2022.3.8,<=2022.4.22
-typing  # version dependent on Python version.
 grpcio>=1.35.0,<=1.47.0
 portpicker==1.3.1
 pytest  # Use the latest version to match github workflow.

Done, thanks! https://github.com/google/vizier/commit/4329daed2dc6d28a191c6f8123cfa3e1d83bd511


Handle pen pressure from wacom tablets

Use case
I want to detect pen pressure from pencil table like Wacom Intuos
Proposal
Today, you can use GestureDetector which handles pressure from screens.
I think this is do-able through a package which handles pressure on web and native.
Here is a current possible code, but does not work on Linux:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData.dark(),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return SafeArea(
        child: Container(
            child: GestureDetector(
      onForcePressPeak: (details) => print(details.pressure),
      onForcePressStart: (details) => print(details.pressure),
      onForcePressUpdate: (details) => print(details.pressure),
    )));
  }
}

Here is the flutter doctor:
[✓] Flutter (Channel master, 1.26.0-2.0.pre.167, on Linux, locale fr_FR.UTF-8)
    • Flutter version 1.26.0-2.0.pre.167 at /home/fodil/dev/flutter
    • Framework revision d3a2259541 (il y a 4 jours), 2020-12-31 15:14:03 -0500
    • Engine revision 82b4ae86d6
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /home/fodil/Android/Sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment (build
      <IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for
      more details.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from
      https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup
      for detailed instructions).

[✓] IntelliJ IDEA Community Edition (version 2020.1)
    • IntelliJ at /home/fodil/Téléchargements/idea-IC-201.7223.91
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin version 201.7846.93

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 87.0.4280.88

! Doctor found issues in 2 categories.

possible duplicate of
https://github.com/flutter/flutter/issues/63209
https://github.com/flutter/flutter/issues/65248
https://github.com/flutter/flutter/issues/42846
@TahaTesser
for what is worth I think those issue are divided even too granularity
I'd consider consolidating the aforementioned issues (plus apple pencil's)
under a new platform / vendor agnostic issue
just my 2 cents

possible duplicate of
https://github.com/flutter/flutter/issues/63209
https://github.com/flutter/flutter/issues/65248
https://github.com/flutter/flutter/issues/42846
@TahaTesser
for what is worth I think those issue are divided even too granularity
I'd consider consolidating the aforementioned issues (plus apple pencil's)
under a new platform / vendor agnostic issue
just my 2 cents

Hi @fodil-a
I agree with @iapicca, these issues are too granular, trying to achieve pretty same results but something like Apple Pencil might come with more features, it also added a text-input label which makes sense since Apple Pencil has some specific text input features.
Since you're trying to achieve on Linux, this is a duplicate of https://github.com/flutter/flutter/issues/63209
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @fodil-a
I agree with @iapicca, these issues are too granular, trying to achieve pretty same results but something like Apple Pencil might come with more features, it also added a text-input label which makes sense since Apple Pencil has some specific text input features.
Since you're trying to achieve on Linux, this is a duplicate of https://github.com/flutter/flutter/issues/63209
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Incremented version to <IP_ADDRESS>-SNAPSHOT

opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Github Issue # or road-map entry, if available:

N/A

Description of changes:

Incremented version to <IP_ADDRESS>-SNAPSHOT

Why these changes are required?

Keep current with project versions

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

N/A

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

mvn -B clean package

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

N/A

Is it backport from main branch? (If yes, please add backport PR # and commits #)

No
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1464 (83f0a4e) into main (6436c15) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1464      +/-   ##
============================================
- Coverage     64.88%   64.87%   -0.01%
- Complexity     3228     3229       +1
============================================
  Files           247      247
  Lines         17335    17335
  Branches       3072     3072
============================================
- Hits          11247    11246       -1
- Misses         4532     4534       +2
+ Partials       1556     1555       -1

Impacted Files
Coverage Δ

...security/configuration/DlsFlsFilterLeafReader.java
59.76% <0.00%> (-0.71%)
:arrow_down:

.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java
58.01% <0.00%> (+1.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6436c15...83f0a4e. Read the comment docs.

@davidlago Can you please sign all your commits?

Done!

Let's see if this breaks or doesn't the hack we put in place here.


Uncaught (in promise) Error: Backend not found: gitlab

Uncaught (in promise) Error: Backend not found: gitlab
Describe the bug
Im getting this error, when i tried to call function about adding images to draft and try to attach files into commit.
I tried to use function persistMedia(file); by connect()
export default connect(
state => {
 const { mediaLibrary } = state;
 return {
  config: mediaLibrary.get("config")
 };
},
map,
(stateProps, dispatchProps, ownProps) => {
 return { ...ownProps, ...stateProps, ...dispatchProps };
},
{ withRef: true }
)(MultipleUpload);

But when i call persistMedia() inside connect(), error appears:
Uncaught (in promise) Error: Backend not found: gitlab
   resolveBackend backend.js:904
   currentBackend backend.js:921
   persistMedia mediaLibrary.js:303
   Redux 2
   _callee$ multipleUpload.js:44
   Babel 8
   onFileUpload multipleUpload.js:44
   React 32
   Redux 11
   H entries.js:512
   Redux 2
   componentDidMount Editor.js:246
   React 14
   Redux 8
   authenticateUser auth.js:88
   promise callback*t.authenticateUser/< auth.js:82
   Redux 2
   loadConfig config.js:319
   Redux 2
   componentDidMount App.js:156
   React 12
   _ bootstrap.js:132
   js cms.js:13
   Webpack 3
backend.js:904

Thanks a lot for your help.
There is a link to my example (Gitlab repository)

Closing as stale and/or outdated.


Close LastPass Admins Mailbox

Background

Close mailbox when LastPass is finally decommissioned.
Approach

Raise SNOW request to close Google Group.
Acceptance Criteria

[ ] Raise SNOW request
[ ] Update runbooks to remove references to old mailbox and processes.

Reference
How to write good user stories

Await subscription to lapse

Request submitted

Done


Discrepancy between permissions listed on ATN and permissions requested by the add-on during install

This was reported for the q-note add-on, but is valid for all add-ons which are using Experiments.
The permission information popup on ATN does not state, if the add-on uses Experiments. In Thunderbird itself we do not prompt for any individual WebExtension permissions, if the add-on uses Experiments, but simply ask for the full-access permission.
We should at least list the full-access permission in that popup on ATN as well. If possible, drop the other permissions altogether, to be consistent with the permission-install-prompt

Today I had another reviewer, who blamed this on an add-on, and gave a 1 star review, even though the add-on is not able to fix this (besides mentioning the required full access permission in its description)

Thanks for the report and re-ping. I'll get to this as soon as I can.

Okay confirmed working in test environment, if an addon file is marked as "is_experiment==True" it will show the "Permissions" modal link, and only show the following:

L10n only applies to English, Italian, French, German, and Polish.


Checkbox, Radio, Radio Group, Toggle Switch - switch to kebab-case

Description / User story
After #970 we have to adjust all components to follow the new approach.
Requirements / Prerequisites

[ ] #970

Acceptance Criteria

[ ] The new casing has been implemented in the Checkbox component
[ ] The new casing has been implemented in the Radio component
[ ] The new casing has been implemented in the Radio Group component
[ ] The new casing has been implemented in the Toggle Switch component

Additional information

...

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Topic was already completed within #970 , this issue has been closed.


Yesterday, there was a DST change, it could be possible that it was the cause of the issue, if you happen to run into the same problem again, please post the following information in order to identify the problem

Device id
Time of last activity on the device (last update or last value pushed) - including timezone
Time when you saw the error - including timezone

Thanks

Hi @fsaravia ,
Here is the data:
Device id - f87e5178f9c47220839b60b9e4d1a398
Time of last activity on the device (last update or last value pushed) - including timezone - 03/09/2015 15:05:48.754 UTC
Time when you saw the error - including timezone - 03/09/2015 15:05:48.754 UTC

@chenfli everything looks good on this side, did you see it happen again? If not I would think of a DST related issue

Closing this one as it became stale, @chenfli feel free to open a new issue if this is still happening to you :). Thanks!


I'm getting We received a bad request trying to sign in

I'm getting "We received a bad request" trying to sign in. Any ideas of how I can resolve this?

I'll have to look into that one - not sure I even finished that part off yet in the source. I'm tied up the remainder of this week but will look as soon as I can.

Normally that means that something isn't configured right but it's really hard to say with only that info. I'd first make sure that your app is configured properly with Azure Active Directory.


[Consumer UI Refresh] Chat preview line shouldn't show in the chat row when creating a New Group

If you haven’t already, check out our contributing guidelines for onboarding!

Platform - version:
Desktop & iOS -  v1.0.1-419
Action Performed (reproducible steps):

Open Global Create
Select New Group
Notice the last message of the chat being displayed in the chat rows, or the chat rows are blank if you haven't chatted with that other user before

Expected Result:
When creating a New Group, the user's primary login should always be displayed as the second line of the chat row like so:

Actual Result:

Notes
CC: @lucas-neuhaus-dev @marcaaron @shawnborton
Logs - JS/Android/iOS (if applicable):
N/A

@parasharrajat Sorry this was also left out of the requirements for the issue you have worked on. Slipped my mind that we wanted to preserve the existing behavior and just modify it in OptionsListUtils e.g.
https://github.com/Expensify/Expensify.cash/blob/037293697faf8f823ecb854e287c8153872cff03/src/libs/OptionsListUtils.js#L364-L370
Should maybe have something like showChatPreviewLine that would be true for
https://github.com/Expensify/Expensify.cash/blob/037293697faf8f823ecb854e287c8153872cff03/src/libs/OptionsListUtils.js#L363
and
https://github.com/Expensify/Expensify.cash/blob/037293697faf8f823ecb854e287c8153872cff03/src/libs/OptionsListUtils.js#L297
And fallback to showing the email in the other cases.

Let me see this. Thanks

Thanks @parasharrajat 🎉


Regression - v1.19.0 reconciles continuously every minute

Bug Report

What did you do?

The latest Ansible Operator v1.19.0 is reconciling continuously every minute. Did not see this behaviour with the last version v1.18.1. The watches.yaml we use is ...
---
- version: v1
  group: wos.cpd.ibm.com
  kind: WOService
  snakeCaseParameters: False
  playbook: reconcile.yaml
  watchDependentResources: False

We do not set the reconcilePeriod in the watches.yaml for the Ansible Operator that watches the custom resource of kind WOService
This looks like a regression. Even though the custom resource is not modified after last reconcile, the reconcile is getting triggered continuously with a gap of a minute post the last successful reconcile.
If this is the expected behaviour in latest version, please let us know what should we be doing to not reconcile.
I tried setting reconcilePeriod: 0s, but that does not seem to stop reconciliation.
What did you expect to see?

Given the above watches.yaml, it should not have reconciled every minute
What did you see instead? Under which circumstances?

Even though the custom resource is not modified after last reconcile, the reconcile is getting triggered continuously with a gap of a minute post the last successful reconcile.
Environment
Operator type:

/language ansible

Kubernetes cluster type:

OpenShift

v1.19.0
$ go version (if language is Go)

$ kubectl version

Possible Solution

Additional context

Hi @venkataramanam,
This is because of the command-line flag reconcile-period has a default value of 1m. So, to avoid any interval-based reconciles, you can run the Ansible Operator like the following:
$ ansible-operator run local --reconcile-period 0s

No reconcile period must be specified in the watches.yaml file or the custom resource annotations either. By running the above command, no reconciles will take place unless an event comes into the cluster that requires a reconciliation.
Let me know if you have any further questions.

@VenkatRamaraju Thanks for looking into this issue.
I will try the suggestion to set the reconcile period as command-line arg to ansible-operator

@VenkatRamaraju Passing on the reconcile period to ansible-operator as commandline arg worked. Thank you.


Adding task to $promises array dynamically

What is the difference between the following
Promise\wait(Promise\some($promises));
Promise\wait(Promise\all($promises));
Promise\wait(Promise\any($promises));
For me, I'm getting the same result for all of the above. What I'm trying to do is if any of the tasks finished I want to add one more into the pool. I thought Promise\wait(Promise\any($promises)); will return immediately if any of the tasks finishes and I can add more to the $promises array. Is that possible?

You could use Amp\Promise\first, but it's likely better to use the concurrent iterator from amphp/sync: https://github.com/amphp/sync/blob/54e689fd2cfbe9e8311db5c5de14e9f4c5142b20/examples/queue.php

@kelunik - when I use Promise\wait(Promise\first($promises)); it's just returning NULL, I'm using some task id's in $promises   array as it indexes, I need those Id to update the status in DB.  Please see the below code
        $tasks = $this->load_taks_from_db($noOfTasks);
        for($i = 0; $i < self::MAX_POOL_SIZE; $i++) {
            // getting the service from the container
            $promises[$tasks[$i]->getId()] = Worker\enqueueCallable([$service, 'execute'], $tasks[$i]);
        }
        $responses = Promise\wait(Promise\first($promises));
         // when we reach here how I can add more tasks to the pool?

I would like to keep MAX_POOL_SIZE number for tasks processing at a time so whenever any of it finishes I need to add one more task again. How I can implement it?

Try something like this based on the example I linked above:
<?php

use Amp\Iterator;
use Amp\Sync\LocalSemaphore;
use function Amp\Promise\wait;
use function Amp\Sync\ConcurrentIterator\each;

require __DIR__ . '/../vendor/autoload.php';

wait(each(
    Iterator\fromIterable($this->load_taks_from_db($noOfTasks)),
    new LocalSemaphore(MAX_POOL_SIZE),
    static function ($task) {
        yield Worker\enqueueCallable([$service, 'execute'], $task);
    }
));

Thanks for the help,  just one question whether it always execute MAX_POOL_SIZE task's at a time? or it will wait for all the tasks to complete before adding the next task?

It'll start a new task once the previous completed.

It'll start a new task once the previous completed.

You mean everything in the pool or if one of them completes it will add a new one right?

One of them. If you add some logging, you'll see it.

Thanks for the help!


[Datasets] Transmit format to children

Transmit format to children obtained when processing a dataset.
Added a test.
When concatenating datasets, if the formats are disparate, the concatenated dataset has a format reset to defaults.

Closing as #607 was merged