[go test]: Incorrrect test results being reported

I know from the debugging wiki there are some issues with go test due to it not returning 0/1 exit codes after completion but I'm filing an issue in the hopes that there is a way, like in the debug flow, to attach an output parser.
As an example if I run a go test file using a call to :Ultest it shows the test as failing even though the actual output shows success.

I'm happy to help contribute if this doesn't already exist and isn't too deep in the weeds of what vim-test ultimately controls.

Hmm that is odd. Can you ULTEST_LOG_LEVEL=DEBUG ULTEST_LOG_FILE=ultest.log nvim <test_file>.go and paste the contents of ultest.log here?

12:30:08 | INFO | MainThread | logging.py:create_logger:74 | Logger created
12:30:08 | DEBUG | MainThread | init.py:init:40 | Handler created
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:08 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | MainThread | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | MainThread | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | MainThread | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | WARNING | Thread-1 | processes.py:run:135 | An exception was thrown when starting test TestUpsertCurrenciesTx6678823922465912131 with command: ['go', 'test', '-run', 'TestUpsertCurrenciesTx$', './services/secmaster/db']
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/handler/processes.py", line 128, in run
*cmd, stdin=in_handle, stderr=out_handle, stdout=out_handle
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/subprocess.py", line 217, in create_subprocess_exec
stderr=stderr, **kwds)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/base_events.py", line 1516, in subprocess_exec
bufsize, **kwargs)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 193, in _make_subprocess_transport
self._child_watcher_callback, transp)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 924, in add_child_handler
"Cannot add child handler, "
RuntimeError: Cannot add child handler, the child watcher does not have a loop attached
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | MainThread | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | WARNING | Thread-1 | processes.py:run:135 | An exception was thrown when starting test TestQueryCurrenciesTx2733261413546267579 with command: ['go', 'test', '-run', 'TestQueryCurrenciesTx$', './services/secmaster/db']
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/handler/processes.py", line 128, in run
*cmd, stdin=in_handle, stderr=out_handle, stdout=out_handle
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/subprocess.py", line 217, in create_subprocess_exec
stderr=stderr, **kwds)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/base_events.py", line 1516, in subprocess_exec
bufsize, **kwargs)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 193, in _make_subprocess_transport
self._child_watcher_callback, transp)
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 924, in add_child_handler
"Cannot add child handler, "
RuntimeError: Cannot add child handler, the child watcher does not have a loop attached
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | Thread-1 | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'
12:30:11 | ERROR | MainThread | logging.py:__deferred_flog:37 | Error converting args to str
Traceback (most recent call last):
File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/logging.py", line 34, in __deferred_flog
level, eval(fstr, frame.f_globals, frame.f_locals), stacklevel=3
File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/logging/init.py", line 1398, in log
self._log(level, msg, args, **kwargs)
TypeError: _log() got an unexpected keyword argument 'stacklevel'

Sorry for the noise in the logs, turns out you've uncovered a bug in the logging with python 3.7. All fixed now.
The actual issue you're having is here
Traceback (most recent call last):
  File "/Users/awalker/.local/share/nvim/plugged/vim-ultest/rplugin/python3/ultest/handler/processes.py", line 128, in run
    *cmd, stdin=in_handle, stderr=out_handle, stdout=out_handle
  File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/subprocess.py", line 217, in create_subprocess_exec
    stderr=stderr, **kwds)
  File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/base_events.py", line 1516, in subprocess_exec
    bufsize, **kwargs)
  File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 193, in _make_subprocess_transport
    self._child_watcher_callback, transp)
  File "/Users/awalker/.pyenv/versions/3.7.0/lib/python3.7/asyncio/unix_events.py", line 924, in add_child_handler
    "Cannot add child handler, "
RuntimeError: Cannot add child handler, the child watcher does not have a loop attached

which was a fun one to track down :sweat_smile: Turns out there's a bug with asyncio.create_subprocess_exec in python 3.7 https://bugs.python.org/issue35621. I've gone by the suggested solution at the bottom and seems to be working perfeclty for me.
Let me know if you have any trouble!


228 apply create snapshot database

Context
Production deployment needs to create a snapshot database to restore. This change will migrate PAAS to azure as we will now use Azure Postgres SQL Database for the snapshot database.
Changes proposed in this pull request
New Azure Postgres SQL server created on snapshot database toggle variable:

This server will not have high availability.
Production snapshot will use SKU of B_Standard_B1ms which will also be the default for snapshot databases till we can confirm whether we need to change this based on further usage.

New Azure Postgres SQL server Database created on snapshot database toggle variable
Guidance to review
Can set snapshot_databases_to_deploy variable to true in a more test environment like development and deploy to see if snapshot Database gets created.
Link to Trello card
https://trello.com/c/0SFPAg3o/228-apply-create-snapshot-database
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault

Tested successfully with deploy-plan


Expense report - System message that report was paid not displayed in ND when admin pays in OD

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.80-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4397017
Issue reported by: Applause - Internal Team
Action Performed:
precondition: user is a member of a collect workspace

Log in to ND as a member of a collect workspace
Navigate to the workspace report
Submit a manual expense
Log into OD as an admin
Open the submitted report
Approve the report
Paid the report either by marking as paid outside Expensify or via Direct Deposit if it was set up
Open the paid report in ND as the member

Expected Result:
The system messages that the report was approved and paid is displayed
Actual Result:
Only the system message that the report was approved is displayed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/008c3815-a2c1-4b3a-858a-da2159c13c36
View all open jobs on GitHub

@muttmuure  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Onyx is disabled in OldDot right now, so this is expected and will require a wider fix beyond the scope of this issue


allow access to metadata on participant struct

For now, user can't access to metadata store in a participant, the only way to get it is to use listener.
This make following code possible:
import (
  lksdk "github.com/livekit/server-sdk-go"
)

func main() {
  host := "<host>"
  apiKey := "api-key"
  apiSecret := "api-secret"
  roomName := "myroom"
  identity := "botuser"
	room, err := lksdk.ConnectToRoom(host, lksdk.ConnectInfo{
		APIKey:              apiKey,
		APISecret:           apiSecret,
		RoomName:            roomName,
		ParticipantIdentity: identity,
	})
	if err != nil {
		panic(err)
	}

  room.Callback.OnParticipantConnected = func(participant *lksdk.RemoteParticipant) {
     metadata = participant.Metadata()
  }

}

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for livekit btw ! You've all did a great work
and also thanks for fast merging my PR


Add about section

#12
implemented about section

Note: possible bug
current implementation permits if statements in about section introducing possible parsing errors as additional opcodes have not been accounted for

Can confirm that's a bug, I'll be fixing it along with a couple other things.


Feature Request: Test suite

Hi,
What do you think of having a test suite for this module?
I can suggest 1am:
https://github.com/lmj/1am

I have actually moved my working Seria project into holberg https://github.com/Izaakwltn/holberg/Seria though I have been wanting to put tests into that library as well. I'll check out 1am, previously I'd only tried fiasco

Hi, should this repo be archived then?
I had sent a package to GNU/Guix but it looks like I should package holberg instead:
https://issues.guix.gnu.org/59060

That's a good idea! I'm still kind of new to the process, so I'll archive it, and others tonight.

Will seria be vendored as part of holberg or it will be integrated into one large library? I saw that you had multiple asd files/systems.


casmpet-6615 Bump cray-spire to 1.4.2

The hostPath has changed for this chart. However, the PSP was not updated along with this path change, causing the spire-jwks service to fail to start. This fixes the permission issue.

/backport stable/1.5


Add unattened upgrades configuration to our salt scripts for ubuntu machines

There are some instructions here:
https://help.ubuntu.com/community/AutomaticSecurityUpdates
The interesting bit is probably not just turning on / automating it via salt, but also adding some of the extra bits (like autoreboot). I think I'd rather auto-reboot and risk requiring user intervention (via exception slave lost) than leaving an unpatched server on a public IP.

Better info in #275


Files in directory of mounted desk not up to date

Observed on ~marzod. The files in the unix directory of it's mounted %base desk were out of sync with what clay knew to actually be in that desk. Rebooting ~marzod caused a <<sync>> on boot to load in file changes even though those had not been made while it was not running.

Just hit this on ~samzod, this bug is way too impactful to go unsquashed for much longer. Any takers?

Cleaning up this area is in my vere shortlist.
Sent from my iPhone

On Apr 19, 2018, at 8:24 AM, Fang<EMAIL_ADDRESS>wrote:
...and on second reboot it happened to the base desk. Magical.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Observation: once a mount is out of sync, it stays out of sync. I had manually updated ~binzod's base desk before rebooting it, and it sync succeeded to home, but then upon rebooting it still synced in old files for the home desk, which I had neglected to check.

Hitting this on ~zod now. @Fang- @joemfb

Nevermind, just actually didn't mount the desk. Copied the files in before, so it just looked like there was a base desk. I'm hallucinating... three days of this; I need sleep.

@ixv


All triggerElement should expose current option

[x] I'm sure this does not appear in the issue list of the repository

Basic Info
What are the similar cases of this feature
Just DX improvement, because sometimes we don't need controlled input, but we need to custom triggerElement!
What problem does this feature solve?
Nowadays if want to custom triggerElement for Select component, the only way to get current option is storing the current option in state, so props triggerElement in all Select likes components, should expose current option, then we can access current option like (option) => <TriggerElement.option={options} />

In this case, this is no way to display current option
import { Select } from '@arco-design/web-react';
import { SelectorTrigger } from './SelectorTrigger';

export const TimeGranularitySelector = () => {
  return <Select {...{ triggerElement: <SelectorTrigger value={???}></SelectorTrigger> }} />;
};

I think is should provide another way to define triggerElement like this
import { Select } from '@arco-design/web-react';
import { SelectorTrigger } from './SelectorTrigger';

export const TimeGranularitySelector = () => {
  return <Select {...{ triggerElement: (currentOption) => <SelectorTrigger value={option.label}></SelectorTrigger> }} />;
};

Same for me. It really need a render-prop pattern api.

triggerElement appears in AutoComplete/Select/TreeSelect/DatePicker. Check them all.


Disable broken tests

This PR removes the broken tests from https://github.com/MinaProtocol/mina/pull/15019. cc @dkijania to fix and re-add them.

!approved-for-mainnet


fix(WEB-9029): Remove pagination tags for index with no pagination

Changes

Check routes for :index_pages when creating pagination tags

Pull Request Test Coverage Report for Build e0cc7390e041f1a07aa91fe6d9521336d190beb2

2 of 3 (66.67%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.05%) to 69.908%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/literature/router.ex
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/literature/helpers/meta_tag_helpers.ex
1
83.87%

lib/literature/router.ex
3
0.0%

Totals

Change from base Build faa8a36db374a0a8f4ecb477ef08032b897f675a:
0.05%

Covered Lines:
1222

Relevant Lines:
1748

💛  - Coveralls


Error when generating subtitles with selected language, while everything looks good in Console

This error only happens if I select a language in the dropdown (for example French here, but none of those I tested are working).
When I tried to generate subtitles with a language selected, it did parse correctly but I got an error preventing to go further
It seems to be a data type error : is not of type 'string' - 'messages.1.content'"
Indeed, it seems to be that in the error, the closing bracket is not followed by a closing double-quote. Could it be the issue ?
{
    "data": {
        "id": "3824e3b6-4983-40d5-8b61-5a9e1ea5a5a8",
        "status": 99,
        "options": {
            "subtitles": "true",
            "chapters": "false",
            "summary": "false",
            "language": "French",
            "chapters_amount": "5"
        },
        "file": "video/WbdjWwXetWKWKOBemY3XUcsgFJQAgVKZt0iawQBE.mp4",
        "error": "['00:00:00.000 --> Changed for sharing on github. Everything is correct'] is not of type 'string' - 'messages.1.content'",
        "transcript": "WEBVTT\n\n00:00:00.000 --> Changed for sharing on github. Everything is correct.\n\n",
        "summary": null,
        "chapters": null,
        "created_at": "2023-03-29T11:19:06.000000Z",
        "updated_at": "2023-03-29T11:19:19.000000Z",
        "message": "There was an error, check the console for more details"
    },
    "status": 200,
    "statusText": "OK",
    "headers": {
        "access-control-allow-origin": "*",
        "cache-control": "no-cache, private",
        "connection": "close",
        "content-type": "application/json",
        "date": "Wed, 29 Mar 2023 11:19:21 GMT, Wed, 29 Mar 2023 11:19:21 GMT",
        "host": "<IP_ADDRESS>",
        "x-powered-by": "PHP/8.2.4",
        "x-ratelimit-limit": "60",
        "x-ratelimit-remaining": "54"
    },
    "config": {
        "transitional": {
            "silentJSONParsing": true,
            "forcedJSONParsing": true,
            "clarifyTimeoutError": false
        },
        "adapter": [
            "xhr",
            "http"
        ],
        "transformRequest": [
            null
        ],
        "transformResponse": [
            null
        ],
        "timeout": 0,
        "xsrfCookieName": "XSRF-TOKEN",
        "xsrfHeaderName": "X-XSRF-TOKEN",
        "maxContentLength": -1,
        "maxBodyLength": -1,
        "env": {},
        "headers": {
            "Accept": "application/json, text/plain, */*",
            "X-Requested-With": "XMLHttpRequest",
            "X-XSRF-TOKEN": "Changed for sharing on github"
        },
        "method": "get",
        "url": "/api/process/3824e3b6-4983-40d5-8b61-5a9e1ea5a5a8"
    },
    "request": {}
}

Same error, no problem if i leave the language blank. German gets recognised correctly for the subtitles if i don't select anything.
Can't test it because of this error, but if a language is selected it should output the summary in the chosen language.

This was fixed and a new release was pushed out! If you use the aschmelyun/subvert:latest tag for the Docker image, it should pull in the new one.


[FEATURE] AMQP 1.0 support

Is your feature request related to a problem? Please describe.
Currently the plugin supports 0-9-1 which is very different from AMQP 1.0. Are there plans to support AMQP 1.0 ? This helps migrating from brokers which support AMQP 1.0 today (IBM, Artemis, etc)
Describe the solution you'd like
Having support for AMQP 1.0 in AOP Itself
Describe alternatives you've considered
QPID Broker J
Additional context
QPID Broker J supports multiple AMQP Protocols, which can be advantageous for AOP if supported as it makes migration easier when coming from AMQP 1.0 (IBM MQ, etc)

+1
We have a lot of components using AMQP 1.0 and we would like to move to Pulsar.


Add Conan support

Hello @viceice.
I'm working on #21912 and #948 is a subtask of #21912. On one hand I can see that this task is in progress, on the other hand the last commit was pushed 10 months ago. Can you tell me what the status of #948 is? Do you want to finish #948? Or maybe #948 is not necessary and can be extracted from #21912 into a separate task?
BR,
Tobiasz.

I started in #1071 but never got it finished. feel free to take it to the next level. see other python tools like pdm


Adding SSE support

For ongoing events, or large batches of data that take time to load in batches,
there is a need to proactively push the data from the server to the client side.
I have initially implemented this feature at On my branch.
He uses it to look like this

// hello.telefunc.ts
// Environment: server

import { SSEMessageEmit } from 'telefunc'

export { hello }

async function hello() {
  console.log('test')
  const ev = new SSEMessageEmit<string>()
  let count = 0

  const interval = setInterval(async () => {
    try {
      const data = `hello world ${count}`
      await ev.emit(data, { id: count.toString() })
      console.log(data)
      count += 1
      if (count > 20) {
        clearInterval(interval)
        ev.close()
      }
    } catch (error) {
      console.error(error)
      clearInterval(interval)
      ev.close()
    }
  }, 1000)

  return ev.readable
}

// index.ts
// Environment: client

import { hello } from './hello.telefunc'
const gen = await hello()
const writable = gen.pipeTo(
  new WritableStream({
    abort(reason) {
      const element = document.createElement('div')
      element.textContent = `aborted: ${reason}`
      document.querySelector('#view')?.appendChild(element)
    },
    close() {
      const element = document.createElement('div')
      element.textContent = 'closed'
      document.querySelector('#view')?.appendChild(element)
    },
    start() {
      const element = document.createElement('div')
      element.textContent = 'started'
      document.querySelector('#view')?.appendChild(element)
    },
    write(chunk) {
      const element = document.createElement('div')
      element.textContent = chunk.data
      document.querySelector('#view')?.appendChild(element)
    },
  }),
)

It currently lacks detailed testing and simple documentation

I did think a lot about it and I came to the conclusion that a good DX would be radically different than Telefunc's current DX. So I'm thinking it's best to implement it as a separate library.
Thanks for reaching out!


Peer to peer code review.

In this peer to peer code review, we achieved the following:

Nice commit formulation.
Please use alternative text in the alt section of the image.
Include a logo.

Otherwise Nice work.
Happy coding.🕺

Thanks a lot @Nowembabazi I will surely implement these changes 👍


running a command generates a seg fault error

When I don't have an API token set I get the error:
$ oneandone server fixedsizes
Segmentation fault: 11

That's an odd error. When I don't have set the API key I receive the following error:
$ oneandone server fixedsizes
No API key specified, use either --apikey global option or environment variable ONEANDONE_API_KEY


Updating oauth2client intersphinx link.

The previous one has been taken out of commision.
See google/oauth2client#249 for the removal and http://google.github.io/oauth2client/ for evidence of the removal.

LGTM (I guess latest is best, since the stable build is 404).

Yeah we can revisit stable when a new release is cut (hopefully soon).


Add dockstore yml

Hi, y'all, I'm Steve Von Worley, a software engineer on the Dockstore team.   A while back, @tetron mentioned that Dockstore could index the bio-cwl-tools repo, which sounded like a good idea, so...
This PR contains a .dockstore.yml file that you can add to the bio-cwl-tools repo that describes the tools to Dockstore.  It contains an entry for every CWL with class CommandLineTool or Workflow.  Add the Dockstore github app to the repo, push the new .dockstore.yml, and Dockstore will read the .dockstore.yml.  Soon thereafter, the referenced tools should appear on Dockstore.  Voilà!
More information about our github app and .dockstore.yml:
https://docs.dockstore.org/en/stable/getting-started/github-apps/github-apps.html
Please let me know if you have any questions.
Thanks!
Steve

https://github.com/dockstore/dockstore/issues/3475 (context)


Rollback Lambda application not working in case deployment failed before traffic routing stage

What happened:
In case of deployment failed before the traffic routing stage, the current rollback implementation will always skip running since we can not get the previous traffic routing config from metadata store.
ref: https://github.com/pipe-cd/pipe/blob/master/pkg/app/piped/executor/lambda/rollback.go#L93-L99
What you expected to happen:
How to reproduce it:
Environment:

piped version: 0.9.5
control-plane version:
Others:

/assign @khanhtc1202


add ability to specify CSP, Content-Security-Policy

https://github.com/komuw/ong/blob/07606656415a32bfc40c6f5e8737bd0187251b6b/middleware/security.go#L56-L74

https://github.com/komuw/ong/blob/f2c39ac4de331f892235b8c75470fe2fb6dda1e9/middleware/csp.go#L70-L74

If we do this, maybe we should also be able to configure the headers; https://github.com/komuw/ong/blob/f2c39ac4de331f892235b8c75470fe2fb6dda1e9/middleware/csp.go#L70-L109

https://observatory.mozilla.org/analyze/dushed.com


A way to work together with detour ？

Hello, very happy to found this project. I tried to make a rust dll mod to work with other c++ mods for richard burns rally game, but meet some errors:

the game already has many mods, they are hook the game's dx9 engine by detour or another asm inject, so when I tried to add this hubhook, other mods raise "detour failed createdevice", I guess the minihook is hooked by dllmain, other mods is hooked later by detour?
another question is I already get the d3d device and window handle with my c++ layer, and now I provide it to rust by ffi, so can I use the origin c++ d3ddevice pointer to initialize the hudbook ? And advanced usage, I already provide a hooked callback to rust, can I direct call render function in the callback ?
last question, the game support vr, the vr mod is hooking the dx9 also, so I want to render imgui frame direct by the origin dx9, so I can see the imgui texture in the vr world. I see you create an alone dx12 to impl renderer engine, or maybe you can provice the rendered texture out, so we can get the texture to call openvr_api and settexture to openvr ?

Forgive me for having so many questions, emmm.

Hi! Thank you, glad the project is useful to you!

the game already has many mods, they are hook the game's dx9 engine by detour or another asm inject, so when I tried to add this hubhook, other mods raise "detour failed createdevice", I guess the minihook is hooked by dllmain, other mods is hooked later by detour?

Interop with other mods has never been an explicit goal of the library, so I am not sure how to address this. My assumption is that once a function is detoured in any sort of way you can't really chain it with something else but I may be wrong. If you have strategies to suggest to solve this, I'm up for hearing them!
I'm not sure if this kind of support is something that I could ever offer, my hunch is that this is something that every detour strategy does slightly differently and usually every game modding community has their own mod loader with their own logic and supporting them all is a pipe dream. If someone is willing to do the research to figure out all the possible corner cases in an exhaustive way, I'd be glad  to offer support in hudhook, but for me personally it's not a goal at the moment. As usual, PRs are always well accepted.

another question is I already get the d3d device and window handle with my c++ layer, and now I provide it to rust by ffi, so can I use the origin c++ d3ddevice pointer to initialize the hudbook ?

It shouldn't be necessary with the latest version of the library, which is going to hit 0.6 release soon. A Direct3D 12 device is created in the rendering engine and it is separate from the game's render loop anyway.

And advanced usage, I already provide a hooked callback to rust, can I direct call render function in the callback ?

Not at the moment, no. hudhook is meant to be an end-to-end framework that does everything from hooking to rendering. If you are already hooked into rendering functions and are using C++, you'd be probably better off just using dear imgui's first party backends directly since you don't really need much more code than that and you save yourself the hassle of Rust FFI.

last question, the game support vr, the vr mod is hooking the dx9 also, so I want to render imgui frame direct by the origin dx9, so I can see the imgui texture in the vr world. I see you create an alone dx12 to impl renderer engine, or maybe you can provice the rendered texture out, so we can get the texture to call openvr_api and settexture to openvr ?

This is not possible at the moment but it's something that could be feasible eventually. The new renderer paradigm is a render pass to an offscreen surface and a composition step on top of the game's hwnd. This last step could be made flexible and could simply return a texture which you could use in openvr. At the moment things are kinda murky and I haven't settled on a solution for this, but this will probably be necessary to solve #151 anyway.

Forgive me for having so many questions, emmm.

No worries at all! Always glad to help 😄

After read source codes, maybe I can implement a custom Hook just like ImguiDx9Hooks, in my Hook only need to hook another address and provide the game's HWND.

Tested, rewrite a ImguiDx9Hooks with a given d3ddevice and direct access the vtable()->Present, it works. So the only thing is add a feature to support return a texture to support use in vr, once it done, I'll create a PR, close this issue now, thanks.


What's going on with all these ProvinceMapper releases?

https://gyazo.com/8cc923e54564bdc8406258bd54aa1c46
There have been 75 versions released in the last 3 hours.
It's taking over my github notifications and driving every non-ProvinceMapper release several pages back in the releases.
@Idhrendur

Oh my! Something has gone terribly wrong with the automated deployments. Thank you for pointing it out.

 Hope it's an easy fix.
Let me know if you want this issue closed now or if I should leave it open until the problem is sorted out.

It was easy enough to stop the CI system, but I'm not sure why it happened in the first place.
I was going to leave the issue open until I had finished cleaning up the excess releases.


Android build failed

Hi friends I updated the image_editor_plus from 0.1.3 to 0.1.4 and now my build failing with this error:
`../../../Documents/flutter/.pub-cache/hosted/pub.dartlang.org/image_editor_plus-0.1.4/lib/image_editor_plus.dart:1519:18: Error: The method 'HandSignature' isn't defined for the class '_ImageEditorDrawingState'.

'_ImageEditorDrawingState' is from 'package:image_editor_plus/image_editor_plus.dart' ('../../../Documents/flutter/.pub-cache/hosted/pub.dartlang.org/image_editor_plus-0.1.4/lib/image_editor_plus.dart').
Try correcting the name to the name of an existing method, or defining a method named 'HandSignature'.
child: HandSignature(
^^^^^^^^^^^^^`

How can I solve this thanks in advance!

fixed by running:
$ dart pub cache repair $ dart pub cache clean


Mono crash on Android version 4.4.4 (KitKat)

Godot version:

v3.2.4-beta3_mono
Godot_v3.2.4-beta3_mono_export_templates.tpz
OS/device including version:

GLES2
Android 4.4.4 (KitKat)
armeabi-v7a
Issue description:

"Dodge the Creeps!" , the  sample game is crashing on an Android device running version 4.4.4 (KitKat)
Relevant logcat :
12-07 10:00:58.384  5965  5965 E dalvikvm: dlopen("/data/app-lib/org.godotengine.dodgethecreepswithc-2/libgodot_android.so") failed: dlopen failed: could not load library "libmonosgen-2.0.so" needed by "libgodot_android.so"; caused by cannot locate symbol "sigemptyset" referenced by "libmonosgen-2.0.so"...: org.godotengine.dodgethecreepswithc
12-07 10:00:58.394  5965  5965 E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: could not load library "libmonosgen-2.0.so" needed by "libgodot_android.so"; caused by cannot locate symbol "sigemptyset" referenced by "libmonosgen-2.0.so"...: org.godotengine.dodgethecreepswithc
12-07 10:00:58.404   591  1413 I am_crash: [5965,0,org.godotengine.dodgethecreepswithc,8928838,java.lang.UnsatisfiedLinkError,dlopen failed: could not load library "libmonosgen-2.0.so" needed by "libgodot_android.so"; caused by cannot locate symbol "sigemptyset" referenced by "libmonosgen-2.0.so"...,Runtime.java,364]: system_server
Steps to reproduce:
install "Dodge the Creeps!"   on an Android device running version 4.4.4 (KitKat) and try to run it .
Minimal reproduction project:

https://docs.godotengine.org/en/stable/getting_started/step_by_step/your_first_game.html

@neikeq Checking e.g. https://github.com/eclipsesource/J2V8/issues/466, this error seems to mean that we're compiling libmonosgen-2.0.so under a too recent API level for armv7.
In platform/android/detect.py we use android-18 for armv7 (Android 4.3.x) which should still be compatible with Android 4.4.4 (android-19). So my guess is that https://github.com/godotengine/godot-mono-builds might be incorrectly using a newer API level for armv7.

Yep here's the bug: https://github.com/godotengine/godot-mono-builds/blob/master/android.py#L525
The default is set to 21, but it should be 18 to match platform/android/detect.py. It's then bumped to 21 automatically for arm64v8 and x86_64 which require it.

Thanks for the quick reply and fix .
It will take me some time to setup godot-mono-builds and compile my own *.so
If you have a precompiled libmonosgen-2.0.so (armeabi-v7a)  with the fix , I will be able to verify it

I'm making a full build of the Android templates for 3.2.4-beta3 using the fixed container, should be ready soon.

@elix22 Here's a test build with that fix: https://downloads.tuxfamily.org/godotengine/testing/android-mono-3.2.4-beta3.zip
To use it, you should go to your installation folder for 3.2.4-beta3 templates (on Windows %APPDATA%/Godot/templates/3.2.4.beta3/, on Linux ~/.local/share/godot/templates/3.2.4.beta3/) and replace the following files or folders with the contents of that zip:
android_debug.apk
android_release.apk
android_source.zip
bcl/godot_android_ext/
bcl/monodroid/
bcl/monodroid_tools/
godot-lib.release.aar

Note that the bcl/ folder contains other Mono stuff for other platforms, so you should only replace the three subfolders which match the ZIP's content.

Wait a few minutes, I posted too fast and the upload isn't completed yet :)

It's now ready to download.

Yep
It works !!
Thanks for the quick fix

The templates for 3.2.4 beta 4 and future versions should be good from the start :)


fixed a go vet suggestion in consumer group file

👋 by any chance you could complete CLA step please?

I thought I did, let me try again.

yup,

"GitHub username has already signed a CLA"

Thanks! GH being laggy ¯_(ツ)_/¯


device: avoid casting away const from config_info pointer

The driver-specific config_info structure referenced from the device structure is marked const.  Some drivers fail to preserve that qualifier when casting the pointer to the driver-specific structure, violating MISRA 11.8.
Changes produced by scripts/coccinelle/const_config_info.cocci which is added in this PR.
Fixes #25247

Updated semantic patch to include adding const to local variable definitions that were assigned in subsequent statement, or where the pointer came from DEV_CFG().

And another update to deal with declarations where the local variable is marked const, e.g.
	struct device *const dev = net_if_get_device(iface);

which must be handled explicitly since the optional_const isomorphism is disabled.


Minor trade model enhancements

Remove Attributable as had no real value.
Restrict builder on rate observations.
Add additional reference data access methods.
Reorder properties in DSF
Enhance test coverage.

That's everything.


feat(3165): enhance search, filter, and sort on private products

It failed e2e test

yeah. Artem is working on it.


Assure that target_subfragment is always one single value

We should add a check to make sure that target_subfragment is always one single value per prep info file.
This came to play when loading redbiom (found by @wasade) and some studies/prep-infos had multiple target_subfragment.

Tis is usually a fill-down error and easy to fix but very good to catch.
On Mon, Oct 16, 2017 at 7:11 AM, Antonio Gonzalez<EMAIL_ADDRESS>wrote:

We should add a check to make sure that target_subfragment is always one
single value per prep info file.
This came to play when loading redbiom (found by @wasade
https://github.com/wasade) and some studies/prep-infos had multiple
target_subfragment.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/qiita/issues/2354, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB69gIrCduZtqhCWTSyXbVq9U__cB3Zmks5ss2QagaJpZM4P6r-X
.

--
Gail Ackermann
Knight Lab
UCSD
<EMAIL_ADDRESS><EMAIL_ADDRESS>

This was solved in https://github.com/biocore/qiita/pull/2881


Update Space View/Container/Visualizer icons to represent both type and sub-type

Icons should generally encode two piece of information:

type: space view vs. container vs. visualiser vs. data (entities/component/group/query/etc.)
sub-type: 3D vs. 2d vs. timeseries vs. text etc.

One should immediately recognise a thing as being a space view even if that particular space view type was never seen before.
This issue is about (roughly in this priority order):

[ ] devising a "top-level" icon style for each of Space View, Container, Visualizer categories (stretch goal: the loosely defined Data category, which would include entities, component, instances, etc.)
[ ] updating/creating all Space View icons to the new style
[ ] creating all Container icons
[ ] (much lower priority) creating all Visualizer icons (list TBD)

Current list of space view types:

Current list of container types:

Note on where these icons will be used:

In the blueprint tree
In the "contents" section in the selection view when a container is selected
In the "add space view or container" modal. Note: these icons may be significantly bigger so it may be preferable to use larger illustrations instead for these.

Space View types
Here is the list of existing space views, followed by a few screenshot to illustrate the less obvious ones.

Bar chart:

Text document (can be either markdown or raw text):

Tensor:

Text Log:

Dataframe (big table of all the data):

Visualiser types
Short-term decision: let's have one icon for all visualiser types.
For context, the visualiser more or less match the list of archetypes, which can be found here: https://www.rerun.io/docs/reference/types/archetypes
Other icons
Things that are in used today:

Issues:

bullet vs. diamond is very hard to tell apart at default scale
the notion of "group" is likely to disappear
the notion of "entity-in-a-space-view" (vs. "entity-in-streams") is going to evolve

To sketch it briefly, the blueprint hierarchy will go Container -> Space View -> Queries -> Visualiser -> Data, where Visualiser will display "Data" that results from "Queries". This data will typically be entities from the store, but could also be other things (like inline data). This means that we will shortly need these icons:
Things in the data store:

entities
component

Things in the blueprint tree:

query
visualizer
"data" (this is yet ill-defined, there might be subtypes like "data-from-entity", or "static data", etc.)

Great progresses made today. TBC early Jan 2024. Battle plan here: https://www.figma.com/file/3WX8yUqa8ECmhLwV6NIF3a/Rerun-Design-System?type=design&node-id=1253-9760&mode=design&t=UqJM8rlATmsnLzze-0

This is mostly done. Remaining effort to be tracked here: https://github.com/rerun-io/rerun/issues/4827


Mapping gets called recursively

I have a simple mapping that is being called 3 times for each element in an array.
Here's my example:
mapperFacotry.classMap(TestDb.class, Test.class)
       .mapNulls(true)
       .field("name", "name")
       .field("getterMethodReturningList", "addresses")  //This gets called 3x for each element

In my TestDB.class I have the getterMethodReturningList as follows:
List<String> towns= new ArrayList<>();
for(Address a : this.getTests.getAllAddresses){
      towns.add(a.getTownName());
}
return towns

I am not sure why this is happening, but so far I have been unable to figure out how to find a work around.

Hi, can you send the complete test case?


XSS lesson - turn off HttpOnly to accommodate?

doing the first attack, it's only a yes/no answer, but the document.cookie doesn't work since we have HttpOnly turned on. Any votes against turning it off (assume we can do this in spring config)?

Whooops!!! Wrong Window/Project.


Fix non-ASCII hyphen characters

Fixed the hyphen characters because the characters are non ACSII characters.

@tksh164 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

thanks @tksh164 ! #sign-off


Fix permission checks in side-by-side view

Short description

Fix permission checks in side-by-side view.
Along the way, I noticed a few other inconsistencies in our permission checks.
Proposed changes

Implemented the following constraints:

only view permission: make form disabled, remove save buttons, show warning
only edit permission: only show "submit for review" button
publish permission: show "save as draft" and "publish/update" buttons

Resolved issues

Fixes: #1563

Can you fix the text alignment of the "back to the editor" button

Alright, done. I didn't like the way the buttons increased their height when the heading breaks into the new line anyway, so I adapted the flex behavior of the buttons instead.


Support Amplify Codegen In Pure Dart Projects

Describe the feature you'd like to request
It would be nice to have the ability to leverage features of Amplify Gen 2 (particularly the graphql model gen) in pure Dart packages, in addition to in Flutter projects. This would allow devs to integrate new Amplify features in projects and create packages that could be used in multiple Flutter apps, instead of being bound to a single app.
Currently, this is not possible because of how GraphQL model code is generated into Dart. Specifically, this generated constructor passes in a Flutter app, but throws a field_initializer_not_assignable error in a Dart app:
  const Todo._internal({required this.id, content, createdAt, updatedAt}): _content = content, _createdAt = createdAt, _updatedAt = updatedAt;

Describe the solution you'd like
It would be nice if the codegen that generates Dart code from the backend schema generates code that is supported in pure Dart packages.
Describe alternatives you've considered
The only alternative I can think of would be to only use Amplify on Flutter apps, not Dart packages, which would require repeating schema definitions across multiple Dart projects, and prohibit abstracting model generation within app architecture.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

Update: it turns out this does compile in pure Dart -- the root issue was my use of strict analysis rules in very_good_analysis.
Ignoring the Amplify-generated Dart code in analysis_options.yaml solves the issue.

I'll keep this as a feature request to modify the generated code to be compliant with very_good_analysis. In the mean time (as you have mentioned), ignore the generated files from any code analysis tools that cause issues.


tell people how to run it

some dumbasses (like myself) probably have no idea how to run this . Just a little line with that they gotta put into the command palette would help idiots like myself out.

Thanks for the PR, I added a chonky title right underneath the extension name :+1:


fix(@angular-devkit/build-angular): strip and use BOM for index.html

Fix angular/angular-cli#10210

Tests added.  Both UTF-8 with BOM and UTF-16LE with BOM.


Remove get_pending_certificates from verisign issuer

Coverage increased (+0.1%) to 61.06% when pulling b814a4f0093bf8be085331c61ab8bd9e03078aaa on castrapel:issue_1151_remove_get_pending_certificates into ffba1d2b852d0dacf9d8a0a12376820b61f822aa on Netflix:master.

lgtm


bug: update generator metrics in tutorial

Description of changes:
This update revises the formulas for the Noise Sensitivity metrics in the tutorial to correct inaccuracies in the previous version. The changes apply to both relevant and irrelevant chunks, ensuring the metrics are aligned with the intended definitions and methodology.
Changes Made:

Corrected the formulas for Noise Sensitivity in Relevant Chunks and Noise Sensitivity in Irrelevant Chunks.
Updated related explanations to maintain consistency.
These updates improve the clarity and accuracy of the tutorial, ensuring it is reliable for readers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @zjjzyl , thanks for pointing out the errors in the figure. I have revised the figure, but we will still keep the descriptions to distinguish noise in relevant/irrelevant chunks to align with the code.


[FEATURE]: Add google login frontend

Is your feature request related to a problem? Please describe.
I want to add the option to google login
Describe the solution you'd like
The frontend will send the access_token to the backend which will then work on it and allow the user to login with google

Hey @NK-Works , We don't need this feature right now, but thanks for the suggestion!


Clear chat options starts a new chat

I noticed that the Clear chat option starts a new chat rather than clearing the current chat. Is this a bug?

We've gone through various iterations of this.  The difference between "Clear Chat" and "New Chat" is really about what happens in this current tab.  As you point out, both create a new chat, but "Clear Chat" clears the current tab "New Chat" does it in a new window/tab.
We used to do what you're suggesting, and simply delete the messages in the window.  However, users complained about data loss (it was surprising that they lost their messages), so we switched to this.
In short, we err on the side of keeping vs. deleting data.
I don't think we want to change this, since it took a lot to get here.

Closing issue as it is expected behaviour


"error":"run Select error: invalid operation []map[string]interface {}

在执行如下查询时
select e.readings[0]->id from edgex_event_devicevirtual_stream AS e;
报这个错误：
kuiper > [{"error":"run Select error: invalid operation []map[string]interface {}([map[device:Temperature-Humidity-Device id:2f2c29c5-5d41-4e54-81fb-dc09050db1e7 name:Temperature origin:1584869772237825792 value:3.000000e+01]]) [] *xsql.BracketEvalResult(&{0 0})"}]
[{"error":"run Select error: invalid operation []map[string]interface {}([map[device:Temperature-Humidity-Device id:8a55d988-7a48-4fb3-9511-0d30deb681c6 name:Humidity origin:1584869773239062528 value:6.000152e+01]]) [] *xsql.BracketEvalResult(&{0 0})"}]
[{"error":"run Select error: invalid operation []map[string]interface {}([map[device:Temperature-Humidity-Device id:d4711724-3dd2-4f90-937e-6bb74b79a109 name:Temperature origin:1584869774243981824 value:3.000000e+01]]) [] *xsql.BracketEvalResult(&{0 0})"}]
我的流定义是：
edgex_event_devicevirtual_stream(id string, device string, origin bigint, readings array(struct(id string, origin bigint, device string, name string, value string)))
WITH ( datasource = "edgex/device-virtual", FORMAT = "json", KEY = "id");
下面查询正常的：
select e.* from edgex_event_devicevirtual_stream AS e;
结果如下：
[{"device":"Temperature-Humidity-Device","id":"20c29095-1026-41e7-bb58-ee5f5f861f72","origin":1584868638793188608,"readings":[{"device":"Temperature-Humidity-Device","id":"4a2e19ba-7bdc-43c7-9c1c-5c3f5cf516f8","name":"Humidity","origin":1584868638786348032,"value":"3.401297e+01"}]}]

@lesliechung88 Now it's fixed in 0.2.1 version. You can use AS to specify an alias name.
select readings[0]->id as rid from edgex_event_devicevirtual_stream;

Otherwise, an auto-generated field name rengine_field_xx  as below will be created for you. It's strongly NOT recommend to do so.
kuiper > select readings[0]->id from edgex_event_devicevirtual_stream;
Query was submit successfully.
kuiper > [{"rengine_field_0":"4a2e19ba-7bdc-43c7-9c1c-5c3f5cf516f8"}]

Also, you could try EdgeX source that released in 0.2.1, it should be much easier for you to use.

@jinfahua Thinks,!  0.2.1 is OK!


Updated Install Script

As this year's workshop will be conducted on Ubuntu 22.04, Robostack will be used for installations of ROS Noetic.
This PR updates the installation script to install ROS Noetic from Robostack's conda channels.

As discussed, I've made changes and divided the script into two parts. One for Ubuntu focal fossa distributions, and another for Ubuntu jammy jelly distribution.
I've also updated the README.md file with installation instructions.


Try preventing CI hang

Dispose resources in TestHost
Add Timeouts to awaits
Fix Timeout extension and add ConfigureAwait to it

No change Debian.9. and RedHat still hanging on Helix


Add "Thanks To All Contributors" section at the last of readme file

Add the Thanks To All Contributors section at the last of the readme file, which should look like the below screenshot.

⚠ Important Message
No need to wait for assigning, you can raise the pull request.

#15
the issue was looked upon

@theritikchoure
please review it


OpenSSL/custom CA cert pages are not in TOC

The following pages are not in the TOC for the website:

https://www.cockroachlabs.com/docs/v20.1/create-security-certificates-openssl

https://www.cockroachlabs.com/docs/v20.1/create-security-certificates-custom-ca

https://www.cockroachlabs.com/docs/v20.2/create-security-certificates-custom-ca.html

https://www.cockroachlabs.com/docs/v20.2/create-security-certificates-openssl

(Meta: we should consider whether things like this should fail the build.)

This is by design. They are toggle-pages for the cockroach cert (https://www.cockroachlabs.com/docs/v20.2/cockroach-cert) page. IIUC, toggle pages don't show up in the TOC.

Seems like this can be closed. Please feel free to reopen if you think there needs to be work done here.


Setting Page - Transaction ON / OFF button Required

ON / Off button required for Transaction Module

This is just display option,
hide menu for - Transaction Page, Ledger Options
Query Builder , And other integrated Option will work as it is,
Only cosmetic Options are hidden

Initiated by @vinpahilwani
Verified by @mitulpanch

#1931 wii complete this


Exposed endpoints for micrometer metrics

Added below changes in pom.xml file
    <dependency>
      <groupId>io.quarkus</groupId>
      <artifactId>quarkus-micrometer-registry-prometheus</artifactId>
      <version>${quarkus.version}</version>
    </dependency>

It will expose the metrics endpoints

I don't think that we should be making this change. It's up to users to decide how they want their metrics to be published.

I don't think that we should be making this change. It's up to users to decide how they want their metrics to be published.

@metacosm - So, you mean, we should not update the plugin and let user know that they can use this feature? Then, we can update tutorial accordingly.

This can be shown as part of the tutorial and/or examples but I don't think it should be part of the code generated by the plug-in.

This can be shown as part of the tutorial and/or examples but I don't think it should be part of the code generated by the plug-in.

Got your point. Thank you.

Closing this.

Closing this.

@metacosm - We were discussing the possible inclusion of the metrics part. I had word with @jmrodri, we enable metrics by default with our SDK. So it seems natural we do the same thing with Java projects.
We are planning to enable the Metrics by default.

Metrics are enabled by default. You just need to provide a metrics provider. Which metrics provider is used should be up to the user. Do go operators automatically expose things over Prometheus?

Metrics are enabled by default. You just need to provide a metrics provider. Which metrics provider is used should be up to the user. Do go operators automatically expose things over Prometheus?

yes.


Create a topical event organisations sub nav tab and page

Description
This PR creates an organisations sub nav tab and page for Topical Events using the GOV.UK Design System.
It does the following:

Adds topical events organisations index page
Adds a reorder topical event organisations page
Adds a toggle lead of topical event organisations route

Screenshots
Before

After
On landing

Make supporting (and only one lead organisation - with no reorder link)

Supporting organisations only

Lead organisations only (and make lead message)

Reorder lead organisations page

Organisations after reodering

Trello
https://trello.com/c/vJibQOQM
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Looking good so far :) Just some minor adjustments as per our conversation

For the reorder page -> Mind removing the back link, just have cancel
Increase the font size for Organisation to "large"
Increase the font size for Lead and Supporting to "medium"
Have a 50px gab between the last item on Lead list with the heading of Supporting list.


Use encoder/decoder to "parse" websocket messages

Should be using an encoder/decoder to consistently parse out the routing information: we can then use the result object for testing, rather than passing around an obscure array.

Fixed by master #29


Remove remaining traces of darglint

We moved to pydoclint for docstring linting a while ago so we no longer need the .darglint file or darglint-related comments.

Enabling auto-merge as it is quite trivial.


implement uptime

#43
#44

The basic features are completed, but there are some issues need to solve:

Declare sub struct correctly in C.utmpx

https://github.com/bminor/glibc/blob/master/sysdeps/gnu/bits/utmpx.h#L55

Resolve conflicts with C.timeval in <time.h>

C.timeval in <utmpx.h> is from <bits/types/struct_timeval.h>

Compilation error occurs when printing C.utmpx object.

cannot convert 'struct <anonymous>' to 'struct timeval'

Resolve different user counts when running uptime /var/log/wtmp

Files with C calls in them should be in .c.v files.  Only pure V code should be in plain .v files.
This will become an error in the future.
Plain .v files are assumed to be code that is portable to all systems, and all backends (including JavaScript, native x64, etc.).

The local test of uptime has passed, using GNU coreutils built from source code.

One of your tests is failing.  uptime_test.v - fn test_print_uptime
A assert is failing.

One of your tests is failing.  uptime_test.v - fn test_print_uptime
A assert is failing.

The problem has been mentioned in Discord. CI environment must use GNU coreutils built from source code, because some commands in Ubuntu are from procps.

Closing/re-opening to force CI to run again.

The expr test failure it is being looked into.  It appears there is also an uptime test failure.

The uptime failure is due to the output being different in the amount of time the system has been up.
[jamie@5950x coreutils]$ bin/uptime && uptime
 22:00:20  up  0:14,  6 users,  load average: 0.38, 0.36, 0.24
 22:00:20 up 14 min,  6 users,  load average: 0.38, 0.36, 0.24
[jamie@5950x coreutils]$

Note that the V version printed 0:14 while the GNU version printed 14 min.

The uptime failure is due to the output being different in the amount of time the system has been up.
[jamie@5950x coreutils]$ bin/uptime && uptime
 22:00:20  up  0:14,  6 users,  load average: 0.38, 0.36, 0.24
 22:00:20 up 14 min,  6 users,  load average: 0.38, 0.36, 0.24
[jamie@5950x coreutils]$

Note that the V version printed 0:14 while the GNU version printed 14 min.
The V version also has the extra space between current time and the word up.

GNU version doesn't print time unit, it is feature of procps version.
Command:
$ uptime --version;echo "";uptime;v run src/uptime

Output:
uptime (GNU coreutils) 8.32.169-d6125
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Joseph Arceneaux, David MacKenzie, and Kaveh Ghazi.

 13:32:34  up   0:26,  1 user,  load average: 0.44, 0.63, 0.70
 13:32:35  up  0:26,  1 user,  load average: 0.44, 0.63, 0.70

There is just some space align problem with V version.


Update class factory cache to detect rundown of remote factories and re-create

C++ WinRT caches agile factories. When the factory is remote, implemented in a win32 service, and that service is shutdown, calls on it will throw “RPC server is unavailable”. Since these services will auto-start attempts to re-bind will succeed.
The factory cache should detect this case, release the bad factory and try again.
This is similar to the support in event delegates that detect RPC server is unavailable and remove the delegate from the event collection.

As a workaround, callers can detect the failure and call winrt::clear_factory_cache to clear the cache. The next time a request is made, a new factory pointer will be cached.

#654 provides a work around

Feel free to reopen if there's interest in exploring this further.


extend _.compact(array) to support Objects

it would be great if _.compact would be something like:

// Trim out all falsy values from an array.
  _.compact = function(item) {
    if _.isArray(item){
        return _.filter(array, function(value){ return !!value; });
    }
    else return _.compactObject(item);
  };

       /**
         * Trim out all falsy values from an object.
         *
         * @param obj - object
         */
        compactObject : function compactObject(obj) {
            _.each(obj, function(value, key) {
                if(!value){
                    delete obj[key];
                }
            });
            return obj;
        }

This has already been proposed several times, so feel free to take a look at the old tickets. I'm afraid that it makes more sense for collection functions to always return a single type of value, rather than switching depending on their input.


fix: superfluous-parens

Kind of neutral on this one, since the readability may be better with them

Yeah, there's one case here I'd be okay with changing, but the rest I'd prefer leaving in place, as the priority of not vs other things is not intuitively obvious to me (which is why I added the parens in the first place).

Yeah, there's one case here I'd be okay with changing, but the rest I'd prefer leaving in place, as the priority of not vs other things is not intuitively obvious to me (which is why I added the parens in the first place).


Add File.readLine for buffered IO

One thing I'd like to improve is that readLine and fileReadLine return an Err on EOF. But EOF is expected in a normal flow, not truly an error. I'd like to return a tag union on Ok but I could not find any examples where we return Roc tag union in Rust code, do you know if this is possible @lukewilliamboswell?

One thing I'd like to improve is that readLine and fileReadLine return an Err on EOF. But EOF is expected in a normal flow, not truly an error. I'd like to return a tag union on Ok but I could not find any examples where we return Roc tag union in Rust code, do you know if this is possible @lukewilliamboswell?

That will be easy to add. Just want to clarify a couple of things @Anton-4 ;

Can we just return an empty list for EOF? then the API stays readLine : FileReader -> Task (List U8) [FileReadErr Path Str]. I suspect this will be the easiest to work with in roc.
If we want to change it, what tag union would you like? how about Task [BytesRead (List U8), EOF] [FileReadErr Path Str]?

Can we just return an empty list for EOF?

Interesting idea, let's try it out :)

Thanks to everyone involved :)
This is good to merge for me when Luke is ok with this.

Thank you @Anton-4, looks good. I guess I added that extra bit to help me validate it was actually closing the file. I was suspect of that just Droping the handle would close it and wanted to QA that manually. But it's no longer required for an example.


Changing a state variable in React causes Cornerstone Tools to lose it's zoom setting

Prerequisites

[6.0.8 ] Which version are you using? (Is it latest?)
[yes ] Are you reporting to the correct repository?
[ yes and no] Did you search existing issues? (Were any related?)

Description

Steps to Reproduce the issue

When I zoom an image and subsequently change a React state variable in response to a button being clicked,
Then the image reverts to its original size.

Expected behavior: I expect the image to retain its size as a result of zooming.
Actual behavior: (What actually happened)
CodeSandbox With Reproduction of Issue: I'll have to work on this. Need to setup a React app to reproduce the issue.

Basic Template

I was able to deal with this issue by writing the following function:
function saveViewport() {
    const el = document.getElementById('image-element');
    viewport.current = cornerstone.getViewport(el);
    translation.current = {
        x: viewport.current.translation.x,
        y: viewport.current.translation.y
    }
}

In response to an event such as a button click or slider change, I call this function to preserve the viewport in a reference variable. When the view is redrawn my useEffect function is called and I restore the viewport.
Notice that I copy the translation object explicitly. This is because assignment of objects in JavaScript is by reference and not value. The value attributes of the viewport are preserved when I assign the viewport to my reference variable but not the object attributes.


eos version 1.1.0,wallet create Error 3200006?

../../build/programs/cleos/cleos --wallet-url http://localhost:5555 --url http://localhost:6000 wallet create
Error 3200006: invalid http request
Error Details:
The server has rejected the request as invalid!
Please verify this url is valid: http://localhost:5555/v1/wallet/create
If the condition persists, please contact the RPC server administrator for localhost!
bios-boot-tutorial.py: exiting because of error

Well, I can replace localhost with <IP_ADDRESS>, but I don't know why this is the problem?

There is a http host validation in version 1.1.0 which checks whether your request host header matches with your server address or not.  Another solution is to set http-alias to your nodeos and keosd, i.e. http-alias=localhost:5555 and http-alias=localhost:6000 respectively.

Oh, understand, thank you.


fails to install on OS X 10.12 Sierra

Hey there,
Installing luasystem on OS X 10.12 gives the following:
$ luarocks install luasystem
Installing https://luarocks.org/luasystem-0.2.0-0.src.rock
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/core.c -o src/core.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/compat.c -o src/compat.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/time.c -o src/time.o
In file included from src/time.c:14:
src/time_osx.h:20:9: warning: 'CLOCK_REALTIME' macro redefined [-Wmacro-redefined]
#define CLOCK_REALTIME  0
        ^
/usr/include/time.h:154:9: note: previous definition is here
#define CLOCK_REALTIME _CLOCK_REALTIME
        ^
In file included from src/time.c:14:
src/time_osx.h:23:9: warning: 'CLOCK_MONOTONIC' macro redefined [-Wmacro-redefined]
#define CLOCK_MONOTONIC 3
        ^
/usr/include/time.h:156:9: note: previous definition is here
#define CLOCK_MONOTONIC _CLOCK_MONOTONIC
        ^
In file included from src/time.c:14:
src/time_osx.h:36:12: error: static declaration of 'clock_gettime' follows non-static declaration
static int clock_gettime(int clockid, struct timespec *ts) {
           ^
/usr/include/time.h:177:5: note: previous declaration is here
int clock_gettime(clockid_t __clock_id, struct timespec *__tp);
    ^
2 warnings and 1 error generated.

Error: Build error: Failed compiling object src/time.o

This thus prevents the installation of busted, which depends on luasystem. Some more info:
$ gcc -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-800.0.38)
Target: x86_64-apple-darwin16.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12
BuildVersion:	16A323

I can submit a patch but not sure how you would like to prefix those (I suppose)?

I believe this is fixed in PR #2

Try the latest master branch.  If everything works for you, then I'll make a new release with the fix.

The latest master branch is still failing with the exact same result for me. Not sure if it is the fix or an issue on my side, as I'm using Xcode 8 with the latest developers tools linked to it.

Sorry, I don't have access to a mac to test this on.  Can you try adding this to the begining of time.c?
#ifdef __APPLE__
  #include <AvailabilityMacros.h>
  #ifndef MAC_OS_X_VERSION_10_12
    #define MAC_OS_X_VERSION_10_12 101200
  #endif
#endif

#define HAVE_CLOCK_GETTIME   defined(__APPLE__) && MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_12

Please also change
#ifndef HAVE_CLOCK_GETTIME

to
#if !(HAVE_CLOCK_GETTIME)

No success with those either. I will investigate further once I have some time on my hands. Would love for other folks to give master a try, as I'm not sure where the problem could be coming from at this point.

The problem is actually very simple. Basically, HAVE_CLOCK_GETTIME is not defined, which means you need to manually define it or update the code to define it based on the version of OSX.  This is what I was trying to you do with the above changes, but I have no way of testing whether or not it works.

Correction: I totally get what the issue is, what I mean is that I don't know why I don't have those defined when I compile the project :sweat_smile: just wondering if I have my compiler/Xcode tools properly setup since I updated to 10.12.

Can you try compiling the changes with just luarocks or just gcc?  I don't think HAVE_CLOCK_GETTIME is defined by OSX at all, but I think <AvailabilityMacros.h> should be in the include path.
You can also try the following with just gcc main.c
#include <stdio.h>

#if __APPLE__
#include <AvailabilityMacros.h>
#ifndef MAC_OS_X_VERSION_10_12
#define MAC_OS_X_VERSION_10_12 101200
#endif
#endif

int main(int argc, const char * argv[]) {
#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_11
    printf("10.11\n");
#endif
#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_12
    printf("10.12\n");
#endif
    return 0;
}

If gcc main.c works, then I can update the master branch with the appropriate fix.
See also civetweb/civetweb#349

Has this been fixed? I'm having the same issue

Can you try the latest master branch?  If it works for you, then I'll make a new release with the fix.

@o-lim If you can tell me how to build it.. At the moment I'm running make with output:
➜  luasystem (master) ✔ make
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C src macosx
/Applications/Xcode.app/Contents/Developer/usr/bin/make all PLAT=macosx
gcc  -I/opt/local/include/lua/2.1  -Wall -O2 -fno-common -fvisibility=hidden   -c -o core.o core.c
core.c:1:10: fatal error: 'lua.h' file not found
#include <lua.h>
         ^
1 error generated.
make[2]: *** [core.o] Error 1
make[1]: *** [macosx] Error 2
make: *** [macosx] Error 2
➜  luasystem (master) ✔

Just use luarocks to build and install
luarocks make luasystem-scm-0.rockspec

@o-lim Still seems to be failing:
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/core.c -o src/core.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/compat.c -o src/compat.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/time.c -o src/time.o
In file included from src/time.c:23:
src/time_osx.h:20:9: warning: 'CLOCK_REALTIME' macro redefined [-Wmacro-redefined]
#define CLOCK_REALTIME  0
        ^
/usr/include/time.h:154:9: note: previous definition is here
#define CLOCK_REALTIME _CLOCK_REALTIME
        ^
In file included from src/time.c:23:
src/time_osx.h:23:9: warning: 'CLOCK_MONOTONIC' macro redefined [-Wmacro-redefined]
#define CLOCK_MONOTONIC 3
        ^
/usr/include/time.h:156:9: note: previous definition is here
#define CLOCK_MONOTONIC _CLOCK_MONOTONIC
        ^
In file included from src/time.c:23:
src/time_osx.h:36:12: error: static declaration of 'clock_gettime' follows non-static declaration
static int clock_gettime(int clockid, struct timespec *ts) {
           ^
/usr/include/time.h:177:5: note: previous declaration is here
int clock_gettime(clockid_t __clock_id, struct timespec *__tp);
    ^
2 warnings and 1 error generated.

Error: Build error: Failed compiling object src/time.o

It looks like your MACOSX_DEPLOYMENT_TARGET environment variable is being set to 10.8 instead of 10.12.  Looking at the luarocks source code, it looks like luarocks maxes out at 10.8 for some reason.  Can you copy paste the contents of /usr/include/time.h?

@o-lim Here you go:
/*
 * Copyright (c) 2000 Apple Computer, Inc. All rights reserved.
 *
 * @APPLE_LICENSE_HEADER_START@
 *
 * This file contains Original Code and/or Modifications of Original Code
 * as defined in and that are subject to the Apple Public Source License
 * Version 2.0 (the 'License'). You may not use this file except in
 * compliance with the License. Please obtain a copy of the License at
 * http://www.opensource.apple.com/apsl/ and read it before using this
 * file.

 * Please see the License for the specific language governing rights and
 * limitations under the License.
 *
 * @APPLE_LICENSE_HEADER_END@
 */
/*
 * Copyright (c) 1989, 1993
 *	The Regents of the University of California.  All rights reserved.
 * (c) UNIX System Laboratories, Inc.
 * All or some portions of this file are derived from material licensed
 * to the University of California by American Telephone and Telegraph
 * Co. or Unix System Laboratories, Inc. and are reproduced herein with
 * the permission of UNIX System Laboratories, Inc.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3. All advertising materials mentioning features or use of this software
 *    must display the following acknowledgement:
 *	This product includes software developed by the University of
 *	California, Berkeley and its contributors.
 * 4. Neither the name of the University nor the names of its contributors
 *    may be used to endorse or promote products derived from this software
 *    without specific prior written permission.
   IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 * SUCH DAMAGE.
 *
 *	@(#)time.h	8.3 (Berkeley) 1/21/94
 */

#ifndef _TIME_H_
#define	_TIME_H_

#include <_types.h>
#include <Availability.h>
#include <sys/_types/_clock_t.h>
#include <sys/_types/_null.h>
#include <sys/_types/_size_t.h>
#include <sys/_types/_time_t.h>
#include <sys/_types/_timespec.h>

struct tm {
	int	tm_sec;		/* seconds after the minute [0-60] */
	int	tm_min;		/* minutes after the hour [0-59] */
	int	tm_hour;	/* hours since midnight [0-23] */
	int	tm_mday;	/* day of the month [1-31] */
	int	tm_mon;		/* months since January [0-11] */
	int	tm_year;	/* years since 1900 */
	int	tm_wday;	/* days since Sunday [0-6] */
	int	tm_yday;	/* days since January 1 [0-365] */
	int	tm_isdst;	/* Daylight Savings Time flag */
	long	tm_gmtoff;	/* offset from CUT in seconds */
	char	*tm_zone;	/* timezone abbreviation */
};

#if __DARWIN_UNIX03
#define CLOCKS_PER_SEC  1000000	/* [XSI] */
#else /* !__DARWIN_UNIX03 */
#include <machine/_limits.h>	/* Include file containing CLK_TCK. */

#define CLOCKS_PER_SEC  (__DARWIN_CLK_TCK)
#endif /* __DARWIN_UNIX03 */

#ifndef _ANSI_SOURCE
extern char *tzname[];
#endif

extern int getdate_err;
#if __DARWIN_UNIX03
extern long timezone __DARWIN_ALIAS(timezone);
#endif /* __DARWIN_UNIX03 */
extern int daylight;

__BEGIN_DECLS
char *asctime(const struct tm *);
clock_t clock(void) __DARWIN_ALIAS(clock);
char *ctime(const time_t *);
double difftime(time_t, time_t);
struct tm *getdate(const char *);
struct tm *gmtime(const time_t *);
struct tm *localtime(const time_t *);
time_t mktime(struct tm *) __DARWIN_ALIAS(mktime);
size_t strftime(char * __restrict, size_t, const char * __restrict, const struct tm * __restrict) __DARWIN_ALIAS(strftime);
char *strptime(const char * __restrict, const char * __restrict, struct tm * __restrict) __DARWIN_ALIAS(strptime);
time_t time(time_t *);

#ifndef _ANSI_SOURCE
void tzset(void);
#endif /* not ANSI */

/* [TSF] Thread safe functions */
char *asctime_r(const struct tm * __restrict, char * __restrict);
char *ctime_r(const time_t *, char *);
struct tm *gmtime_r(const time_t * __restrict, struct tm * __restrict);
struct tm *localtime_r(const time_t * __restrict, struct tm * __restrict);

#if !defined(_ANSI_SOURCE) && (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE))
time_t posix2time(time_t);
#if !__DARWIN_UNIX03
char *timezone(int, int);
#endif /* !__DARWIN_UNIX03 */
void tzsetwall(void);
time_t time2posix(time_t);
time_t timelocal(struct tm * const);
time_t timegm(struct tm * const);
#endif /* neither ANSI nor POSIX */

#if !defined(_ANSI_SOURCE)
int nanosleep(const struct timespec *__rqtp, struct timespec *__rmtp) __DARWIN_ALIAS_C(nanosleep);
#endif

#if !defined(_DARWIN_FEATURE_CLOCK_GETTIME) || _DARWIN_FEATURE_CLOCK_GETTIME != 0
#if __DARWIN_C_LEVEL >= 199309L
#if __has_feature(enumerator_attributes)
#define __CLOCK_AVAILABILITY __OSX_AVAILABLE(10.12) __IOS_AVAILABLE(10.0) __TVOS_AVAILABLE(10.0) __WATCHOS_AVAILABLE(3.0)
#else
#define __CLOCK_AVAILABILITY
#endif

typedef enum {
_CLOCK_REALTIME __CLOCK_AVAILABILITY = 0,
#define CLOCK_REALTIME _CLOCK_REALTIME
_CLOCK_MONOTONIC __CLOCK_AVAILABILITY = 6,
#define CLOCK_MONOTONIC _CLOCK_MONOTONIC
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
_CLOCK_MONOTONIC_RAW __CLOCK_AVAILABILITY = 4,
#define CLOCK_MONOTONIC_RAW _CLOCK_MONOTONIC_RAW
_CLOCK_MONOTONIC_RAW_APPROX __CLOCK_AVAILABILITY = 5,
#define CLOCK_MONOTONIC_RAW_APPROX _CLOCK_MONOTONIC_RAW_APPROX
_CLOCK_UPTIME_RAW __CLOCK_AVAILABILITY = 8,
#define CLOCK_UPTIME_RAW _CLOCK_UPTIME_RAW
_CLOCK_UPTIME_RAW_APPROX __CLOCK_AVAILABILITY = 9,
#define CLOCK_UPTIME_RAW_APPROX _CLOCK_UPTIME_RAW_APPROX
#endif
_CLOCK_PROCESS_CPUTIME_ID __CLOCK_AVAILABILITY = 12,
#define CLOCK_PROCESS_CPUTIME_ID _CLOCK_PROCESS_CPUTIME_ID
_CLOCK_THREAD_CPUTIME_ID __CLOCK_AVAILABILITY = 16
#define CLOCK_THREAD_CPUTIME_ID _CLOCK_THREAD_CPUTIME_ID
} clockid_t;

__CLOCK_AVAILABILITY
int clock_getres(clockid_t __clock_id, struct timespec *__res);

__CLOCK_AVAILABILITY
int clock_gettime(clockid_t __clock_id, struct timespec *__tp);

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
__CLOCK_AVAILABILITY
__uint64_t clock_gettime_nsec_np(clockid_t __clock_id);
#endif

__OSX_AVAILABLE(10.12) __IOS_PROHIBITED
__TVOS_PROHIBITED __WATCHOS_PROHIBITED
int clock_settime(clockid_t __clock_id, const struct timespec *__tp);

#undef __CLOCK_AVAILABILITY
#endif /* __DARWIN_C_LEVEL */
#endif /* _DARWIN_FEATURE_CLOCK_GETTIME */

__END_DECLS

#ifdef _USE_EXTENDED_LOCALES_
#include <xlocale/_time.h>
#endif /* _USE_EXTENDED_LOCALES_ */

#endif /* !_TIME_H_ */

@hugomd I made an update.  Can you try again with the latest master branch?

Similar issue I'm afraid @o-lim:
➜  luasystem (master) ✔ luarocks make luasystem-scm-0.rockspec
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/core.c -o src/core.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/compat.c -o src/compat.o
env MACOSX_DEPLOYMENT_TARGET=10.8 gcc -O2 -fPIC -I/usr/local/Cellar/luajit/2.1_1/include/luajit-2.1 -c src/time.c -o src/time.o
In file included from src/time.c:23:
src/time_osx.h:20:9: warning: 'CLOCK_REALTIME' macro redefined [-Wmacro-redefined]
#define CLOCK_REALTIME  0
        ^
/usr/include/time.h:154:9: note: previous definition is here
#define CLOCK_REALTIME _CLOCK_REALTIME
        ^
In file included from src/time.c:23:
src/time_osx.h:23:9: warning: 'CLOCK_MONOTONIC' macro redefined [-Wmacro-redefined]
#define CLOCK_MONOTONIC 3
        ^
/usr/include/time.h:156:9: note: previous definition is here
#define CLOCK_MONOTONIC _CLOCK_MONOTONIC
        ^
In file included from src/time.c:23:
src/time_osx.h:36:12: error: static declaration of 'clock_gettime' follows non-static declaration
static int clock_gettime(int clockid, struct timespec *ts) {
           ^
/usr/include/time.h:177:5: note: previous declaration is here
int clock_gettime(clockid_t __clock_id, struct timespec *__tp);
    ^
2 warnings and 1 error generated.

Error: Build error: Failed compiling object src/time.o
➜  luasystem (master) ✔

@hugomd Can you try again?  I think it should work this time.

@o-lim It builds now! 👍 Thanks!


CORS error ( on github codespace and gitpod )

Bug description
CORS error when not on Wundergraph cloud.

CORS error

a) happens

when javascript is executed on browser:  url = 'https://9991-abngal-wgtestcors02-1kt6rl0bz8l.ws-us96b.gitpod.io'; fetch(url).then(r => r.text() ).then( r => console.log(r))
happens even when  export NODE_ENV=production;  npm start

b) no error

direct call on browser url for https://9991-abngal-wgtestcors02-1kt6rl0bz8l.ws-us96b.gitpod.io/operations/Dragons
when url is at wundergraph-cloud server: url = 'https://wgtestcors02.wundergraph.dev/operations/Dragons';  fetch(url).then(r => r.text() ).then( r => console.log(r))

screenshot of config:

How to reproduce

Go to (https://cloud.wundergraph.com/abngal/new)
Chose Next.js + react query
code generated pushed at repo https://github.com/abngal/wgtestcors02
open repo at gitpod.io
run npm install && npm start
run code at browser console and error :
 url = 'https://9991-abngal-wgtestcors02-1kt6rl0bz8l.ws-us96b.gitpod.io'; fetch(url).then(r => r.text() ).then( r => console.log(r))

Expected behavior
no CORS error when javscript below is executed on console:
` url = 'https://9991-abngal-wgtestcors02-1kt6rl0bz8l.ws-us96b.gitpod.io'; fetch(url).then(r => r.text() ).then( r => console.log(r)
WunderGraph information

Environment & setup
gitpod and github codespace.
codes are autocreated at https://cloud.wundergraph.com/abngal/new
WunderCtl Version
gitpod /workspace/wgtestcors02 (main) $ npx wunderctl version
Version: 0.146.1
Commit: ada177035c028093afeb4f3e889d15cfe12ddca8
Date: 2023-04-27T18:19:48Z
BuiltBy: ci

Maybe below is another issue I can create:
I noticed adding to .env file the env-var WG_SERVER_URL = https://9991-abngal-wgtestcors02-1kt6rl0bz8l.ws-us96b.gitpod.io seems to be not picked up, and the default localhost:9991 is still fetched instead.
That's why I am currently manually calling fetch() on the url to test CORS

Just noting that issue likely only exists on gitpod.io or gh-codespace.
Check out: https://www.gitpod.io/docs/configure/workspaces/ports#cross-origin-resource-sharing-cors


Handle equipment-spacific file management

I'll need to know a lot more about what this really needs and what problems Carpenters is having to solve.

This is probably no longer necessary. Will add to backlog again if it re-surfaces.


Half-Fan Weighting Artifacts

I observed a ring artifact in the overlapping region when using half-fan weighting. Are there any solutions?

cfg = get_config(sdd=990.805, sod=537.5, nAngles=720,
                 nBins=2, nPad=0, detPhyOffsetX=-138.23, detPhyOffsetY=-96,
                 volZDim=128, volXDim=512, volYDim=512, volXSpacing=1, volYSpacing=1, volZSpacing=1.28)
projs1, angles1 = readDcmProj(cfg, './20240717_504/AVG_504_120_30_air_cw.png', './20240717_504/504_120_30_cw/')
angles = np.linspace(-180, 180, cfg.nAngles).astype(np.float32)

leapct = tomographicModels()
leapct.set_conebeam(cfg.nAngles, cfg.detRows, cfg.detCols, cfg.detSpacing, cfg.detSpacing, cfg.detRowCenter, cfg.detColCenter, angles, cfg.SOD, cfg.SDD)
leapct.set_offsetScan(True)
leapct.set_truncatedScan(True)
# leapct.set_default_volume()
leapct.set_volume(cfg.volXDim, cfg.volYDim, cfg.volZDim, cfg.volXSpacing, cfg.volZSpacing, cfg.volOffsetX, cfg.volOffsetY, cfg.volOffsetZ)
leapct.print_parameters()

vol = leapct.allocateVolume(0)
leapct.FBP(projs1,vol)

print(vol.max(), vol.min(), vol.shape) # 0.030418077 -0.008564696 (128, 512, 512)
print(vol[40, 120:400, 120:400].max(), vol[40, 120:400, 120:400].min())  # 0.019195706 -0.00047323745
print(projs1[4].max(), projs1[4].min(), projs1[4].mean())  # 3.6975892 0.0 1.7670326
vol[vol<0] = 0

fig, axe = plt.subplots(2, 4, figsize=(20, 10))
# vmax = 0.018
vmax = 0.019
vmin = 0.015
_ = axe[0,0].imshow(vol[10, 100:412, 100:412], cmap='gray', vmin=vmin, vmax=vmax) #; fig.colorbar(_, ax=axe[0,0])
_ = axe[0,1].imshow(vol[20, 100:412, 100:412], cmap='gray', vmin=vmin, vmax=vmax)# ; fig.colorbar(_, ax=axe[0,1])
_ = axe[0,2].imshow(vol[40, 100:412, 100:412], cmap='gray', vmin=vmin, vmax=vmax)# ; fig.colorbar(_, ax=axe[0,2])
_ = axe[0,3].imshow(vol[50, 100:412, 100:412], cmap='gray', vmin=vmin, vmax=vmax)# ; fig.colorbar(_, ax=axe[0,3])
_ = axe[1,0].imshow(vol[60, 100:412, 100:412],  cmap='gray', vmax=vmax)# ; fig.colorbar(_, ax=axe[1,3])
_ = axe[1,1].imshow(vol[70, 100:412, 100:412],  cmap='gray', vmax=vmax)# ; fig.colorbar(_, ax=axe[1,3])
_ = axe[1,2].imshow(vol[80, 100:412, 100:412],  cmap='gray', vmax=vmax)# ; fig.colorbar(_, ax=axe[1,3])
_ = axe[1,3].imshow(vol[110, 100:412, 100:412],  cmap='gray', vmax=vmax)# ; fig.colorbar(_, ax=axe[1,3])

======== CT Cone-Beam Geometry ========
number of angles: 720
number of detector elements (rows, cols): 704 x 704
angular range: 360.500702 degrees
detector pixel size: 0.615057 mm x 0.615057 mm
center detector pixel: 507.583130, 576.243469
sod = 537.500000 mm
sdd = 990.804993 mm
======== CT Volume ========
number of voxels (x, y, z): 512 x 512 x 128
voxel size: 1.000000 mm x 1.000000 mm x 1.280000 mm
FOV: [-256.000000, 256.000000] x [-256.000000, 256.000000] x [-81.919999, 81.919999]

SDD: 990.805
SOD: 537.5
detColCenter:<PHONE_NUMBER>032332
detCols: 704
detPhyOffsetX: -138.23
detPhyOffsetY: -96
detPhySize: 433
detPixOffsetX: -224.74346420323323
detPixOffsetY: -156.08314087759814
detRowCenter:<PHONE_NUMBER>775981
detRows: 704
detSpacing: 0.6150568181818182
device: cuda:0
nAngles: 720
nBins: 2
nPad: 0
volOffsetX: 0
volOffsetY: 0
volOffsetZ: 0
volPhyXDim: 512
volPhyYDim: 512
volPhyZDim: 163.84
volXDim: 512
volXSpacing: 1
volYDim: 512
volYSpacing: 1
volZDim: 128
volZSpacing: 1.28

That's weird.  I simulated data with your geometry and I did not get an artifact.  If you are able to send your data to me, I can take a look it at.

@lc82111  I guess that  your thinking ring artifact is a real ring of your target sample.  As you can see the projection image, there is a circle tap on top of  cylinder. Those border area of this tap may be a ring.

Thanks for your kind help. The raw projections can be found at this link:
https://drive.google.com/file/d/1xb7X9mQo2kcIhWD_UGi40JXHCmd-6zQq/view?usp=sharing

@lc82111 I guess that your thinking ring artifact is a real ring of your target sample. As you can see the projection image, there is a circle tap on top of cylinder. Those border area of this tap may be a ring.

@hws203 Thanks for the suggestion. However, I believe the ring artifact I'm observing is not a physical characteristic of the sample. The phantom is flawless, and the ring and central dark region are absent in the full-scan data.

@lc82111, the data in the link has no air scan projection.  Could you send this and any other calibration files you have?

Well, I tried to reconstruct without the air scan data and I think I got something good.  It is different from what you showed, but there is still that inner circle.  I do think this inner circle is real.  Here is my result.

And you can see that the inner cylinder is indeed in the raw data, so it is indeed real.  See this projection:

Here is the script I used.  I turned your dicom files into tiff files before running the reconstruction.
import numpy as np
from leap_preprocessing_algorithms import *
from leapctype import tomographicModels
leapct = tomographicModels()

angles = np.linspace(-180, 180, 720).astype(np.float32)
leapct.set_conebeam(720, 704*2, 704*2, 0.615057*0.5, 0.615057*0.5, 507.583130*2.0, 576.243469*2.0, angles, 537.5, 990.804993)
leapct.set_offsetScan(True)
leapct.set_truncatedScan(True)
leapct.set_default_volume(4.0) # just show a low resolution example
leapct.print_parameters()

g = leapct.load_projections(r'D:\tomography\issue92\raw.tif')
ROI = [30, 80, 950, 1000]
makeAttenuationRadiographs(leapct, g, None, None, ROI)

vol = leapct.allocateVolume(0)
leapct.FBP(g,vol)

leapct.display(vol)

Above is the averaged air scan projection.
I will try your script and report back. Thanks for your help.

To avoid ambiguity, I have added a yellow circle to highlight the artifact. Apologies for any confusion.

This ring artifact appears to be more prominent in RTK reconstruction as below:

I believe this is a cone-beam artifact caused by the void cylinder at the bottom of that projection.  Notice that the diameter of your dark circle is about the same size as the air cylinder at the bottom of the projection.
I think you also have some beam hardening artifacts here.  If you know something about the spectra, you could use LEAP's BHC algorithms to help mitigate this.

I think so too.

Hello, I have converted the provided data into the tif file of<PHONE_NUMBER>8, and the following error appears. How can I solve it

这是我使用的脚本。在运行重建之前，我将你的 dicom 文件变成了 tiff 文件。
import numpy as np
from leap_preprocessing_algorithms import *
from leapctype import tomographicModels
leapct = tomographicModels()

angles = np.linspace(-180, 180, 720).astype(np.float32)
leapct.set_conebeam(720, 704*2, 704*2, 0.615057*0.5, 0.615057*0.5, 507.583130*2.0, 576.243469*2.0, angles, 537.5, 990.804993)
leapct.set_offsetScan(True)
leapct.set_truncatedScan(True)
leapct.set_default_volume(4.0) # just show a low resolution example
leapct.print_parameters()

g = leapct.load_projections(r'D:\tomography\issue92\raw.tif')
ROI = [30, 80, 950, 1000]
makeAttenuationRadiographs(leapct, g, None, None, ROI)

vol = leapct.allocateVolume(0)
leapct.FBP(g,vol)

leapct.display(vol)

Closing this due to inactivity, but feel free to reopen if you wish.


feat: implement auto webhook creation

What kind of change does this PR introduce?
feature
What is the current behavior?
Before these changes, the webhook was created manually which is error-prone and time-consuming.
#4
What is the new behavior?
Webhooks are automatically created and updated if there is any change on the stripe side.
Additional context
Add any other context or screenshots.

I think you might be the first external contributor here @thesayyn, thanks !
I'll try review this in the next couple of days, but from first skim this looks amazing

I think you might be the first external contributor here @thesayyn, thanks !
I'll try review this in the next couple of days, but from first skim this looks amazing

That’s awesome. I just wanted to have fun with this. 🤓

Any updates on this?

That would be amazing! Any updates on that? @thesayyn @kiwicopple Is it just blocked by review?

@kevcodez - perhaps you can jump on this one when you get a chance


Link to run variables documentation

The "az acr build" examples use for example "{{.Run.ID}" pattern for variables, but there's no further information about these. Might be good for example to provide a link to the following page:
https://docs.microsoft.com/en-us/azure/container-registry/container-registry-tasks-reference-yaml

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c608162e-cf40-9d53-da4a-51f51a0311ea
Version Independent ID: eccbb543-be68-7de2-d41d-abee55c81452
Content: az acr
Content Source: src/azure-cli/azure/cli/command_modules/acr/_help.py
Service: container-registry
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@northtyphoon Any idea about these related links?

https://docs.microsoft.com/en-us/azure/container-registry/container-registry-tasks-reference-yaml#run-variables

@jaysterp  @dlepow