[Runtime] Fix concurrent _typeByName with generic arguments, protocol conformances, and superclasses.

When constructing generic type metadata, we can end up checking protocol conformances for metadata that isn't fully built, and in particular the superclass field may not be set up yet. Handle this case properly by falling back to looking up the superclass by mangled name from the nominal type descriptor when necessary.
Previously we were just chasing Superclass fields, which would cause us to terminate the search early sometimes when concurrently looking up the same type from multiple threads. When a protocol conformance is on a superclass, this causes the search to fail incorrectly, causing type lookup failures.
This only arises on the very first attempt to instantiate a given type, since the lookup will be cached (and all metadata fully initialized) after the first success.
rdar://72583931

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 420ca5d1719bbcea65333b0a8a1b24c099e2eb28

Build failed
Swift Test OS X Platform
Git Sha - 420ca5d1719bbcea65333b0a8a1b24c099e2eb28

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 420ca5d1719bbcea65333b0a8a1b24c099e2eb28

@swift-ci please test linux platform

@rjmccall Does this look right to you? Just want to make sure I'm not overlooking anything important, as I'm a bit weak on the full implications of working with incomplete metadata here.

@swift-ci please test


Added orchestrator side changes to support "config-script" service type.

Merging this for CI. Integration tested.


Main merge

This PR was just for Gary to compare the conflict resolves after merging main back into his branch, so I'm closing this now, since his branch is in PR!


arm64 images contain no browsers

Issue

As discussed in https://github.com/cypress-io/cypress-docker-images/issues/695 cypress/browsers and cypress/included Docker images for linux/arm64 do not ship with the Chrome, Firefox and Edge browsers that the linux/amd64 images ship with. The reason is the lack of availability of each of these browsers for the linux/arm64 environment.

For linux/arm64, the cypress/browsers image adds no content that is not already in cypress/base. The images are identical.

This lack of content is not mentioned in the local README documentation or the Docker Hub documentation. (There is mention in CONTRIBUTING > Multi-Architecture Support, however this is not a document that regular users would expect to need to consult.)

Suggestion
Documentation should correctly describe the content of Cypress Docker images, also for linux/arm64 variants.

PR #1131 adds documentation to enable this issue to be closed.


Wondering if it could be brought back

Apple has allowed using Apple Watch to unlock macOS devices for years while we are dropping the function which was working. I do hope it can continue to be supported. It is really helpful to use a mobile device to unlock, since biometric methods will not always be available.

Agree.


How this package can works with jade-doc??

Hi,
I'm trying to get an html doc based on json maked by jade-doc package, but it doesn't work if json file isn't created before. I have tested it with callbacks, another packages like run-sequence or gulp-sync but I don´t get nothing. My code now:
gulp.task('jadeDocJson', function () {
jadeDoc({
input: 'doc.jade',
output: 'node_modules/jade-doc-html/doc.json'
});
});
gulp.task('jadeDocHtml', ['jadeDocJson'], function(){
var jdh = new JadeDocHTML({
output: 'doc.html',
input: 'doc.json'
});
});
gulp.task('jadeDoc', ['jadeDocJson', 'jadeDocHtml']);
Any idea??
Thanks!

so the complete callback doesn't work for you? Maybe something like this (untested)?
pugDoc({
  input: 'doc.jade',
  output: 'node_modules/jade-doc-html/doc.json',
  complete: function() {
    new JadeDocHTML({
      output: 'doc.html',
      input: 'node_modules/jade-doc-html/doc.json'
    });
  }
});

or use the complete: function(){} for pugDoc and stream.on('complete', function(){}) for pugDocHTML to call the callbacks of the gulp tasks. Haven't tested this code, but it should be something like this I guess.
gulp.task('pug-doc', function(cb) {
  pugDoc({
    input: 'doc.jade',
    output: 'node_modules/pug-doc-html/doc.json',
    complete: cb
  });
}

gulp.task('pug-doc-html', function(cb) {
  var stream = new PugDocHTML({
    output: 'doc.html',
    input: 'node_modules/pug-doc-html/doc.json'
  });

  stream.on('complete', function(){
    cb();
  });
}

gulp.task('jadeDoc', ['pug-doc', 'pug-doc-html']);

I've tested your code and I've got with this final code:
gulp.task('jadedocu', function () {
pugDoc({
input: 'doc.jade',
output: 'node_modules/pug-doc-html/doc.json',
complete: function() {
new pugDocHTML({
output: 'doc.html',
input: 'doc.json'
});
}
});
});
I tested the same code with packages jade-doc and jade-doc-html and it didn't work, but with pug-doc and pug-doc-html worked perfectly!
Thanks!

awesome.


/datasets API interpreting modification date as creation date

I believe I found a bug in the /datasets API. I was trying to fetch what was modified since X, but some datasets were missing. I narrowed problem down to min_ldate and min_cdate behaving strangely. After some digging through code here: https://github.com/dmwm/dbs2go/blob/af364c15950a305ec542a6c5a3b07432ed7e1c0a/dbs/datasets.go#L129-L181 I noticed that for both min_cdate/max_cdate and min_ldate/max_ldate query uses D.CREATION_DATE. I think it should be D.LAST_MODIFICATION_DATE in 3 places in the second if.
Now it is essentially impossible to query for "datasets changed since X".

Justinas, thanks for reporting the issue (and nailed down to precise part of the code). I fixed it in the following commit 3c02bd0 and will schedule shortly the test on testbed. Do you have any specific datasets to look at that I can test the changes

I noticed for and was using /BTagCSV/Run2016B-ver1_HIPM_UL2016_MiniAODv2_NanoAODv9-v1/NANOAOD. It was INVALIDated at some point, but our tools still show it as VALID.
Dataset: https://cmsweb.cern.ch/dbs/prod/global/DBSReader/datasets?dataset=/BTagCSV/Run2016B-ver1_HIPM_UL2016_MiniAODv2_NanoAODv9-v1/NANOAOD&dataset_access_type=*&detail=1
We know that it was VALID at<PHONE_NUMBER> and it's last modification date is<PHONE_NUMBER>, but if I do
https://cmsweb.cern.ch/dbs/prod/global/DBSReader/datasets?dataset=/BTagCSV/Run2016B-ver1_HIPM_UL2016_MiniAODv2_NanoAODv9-v1/NANOAOD&dataset_access_type=*&detail=1&min_ldate=1627509903
I get [].

Can confirm that it works. Thanks for the prompt fix!
Issue can be closed.


Added Number Guessing Game Updated-One

ISSUE - #285

[ ] Followed guidelines mentioned in the readme file.
[ ] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
[ ] Starred ⭐ the Repo (Optional)

Summary
This application is a Number Guessing Game where users are allowed to make guesses to see if how many tries it
takes them to get the correct number. The number of tries will equivalent to their score in the game.
Users can select you will only guess between the numbers 1-100.
After winning the game, users are allowed to keep playing if they would like to beat their high score.
Take a shot and try beating your score today, I know you can do it :).
---> The user is alerted and asked to submit a number between 1 and 100 if their prediction is less than 1 or greater than 100.
Screenshot

@LakshmanRam thank you, we'll merge your changes.

This Is My First PR
Thank You @PBJI  @thinkswell

@LakshmanRam Wonderful


Remove resources and add culture initialiser for test projects

This should fix issue #34, and fix the current issue with azure dev ops pipelines.
This adds an AssemblyInitializeCultureTest class for all unit test project, which sets the culture settings to CultureInfo.InvariantCulture. This should make the unit tests pass on machines with different culture settings.
    [TestClass]
    public class AssemblyInitializeCultureTest
    {
        [AssemblyInitialize]
        public static void AssemblyInitializeCultureTest_InvariantCulture(TestContext c)
        {
            CultureInfo culture = CultureInfo.InvariantCulture;
            CultureInfo.DefaultThreadCurrentCulture = culture;
            CultureInfo.DefaultThreadCurrentUICulture = culture;
            Thread.CurrentThread.CurrentCulture = culture;
            Thread.CurrentThread.CurrentUICulture = culture;
        }
    }

This pull request also removes the use of resources in all test projects, and instead uses a DataSetUtilities class to handle small test datasets. This also cleans up a lot of CsvParser code for leading the data.

SharpLearning-CI-Build is the new CI build using the proper .net core pipeline in azure dev ops.


Store attachment content in Memory when using local adapter

I've been playing with the Test adapter and found this issue #258.
This should resolve it, by embedding the raw data of the attachment in the Genserver "storage".
I didn't convert to :base64 to keep compatible with the rendering side where it doesn't decode: https://github.com/swoosh/swoosh/blob/e3beba436797850ceb664ceee8d5178487a82617/lib/plug/mailbox_preview.ex#L73-L76
Please let me know if you need any changes made.

Hi @theodowling, I'm currently traveling (and sick). If Steve doesn't get to it first, I'll take care of this in a few days. Thanks for the PR!

Thanks @theodowling !


Added Tolerance on pixel level

Pixel Tolerance
The Problem
Does it really matter if there is 2 shades of colour difference in an element on the screen ?
Is it really worth spending our time fixing it ?
There have been a couple of instances where the snapshot testing has produced entirely grey diff images, or at least seemingly so to the naked eye, when run on different machines. After increasing contrast in an image editor, there are minuscule changes (sometimes a couple of shades of grey difference) in the colour of a pixel. This brings about test failures which are difficult to diagnose, provide very little value and chew up developer time.
See #27 and #37 for an example of this.
Regular Tolerance
The default tolerance implementation in the test case is very simplistic:

no. of diff. pixels / total pixels = percentage difference

Under the current implementation introducing even the smallest of tolerances here to ignore a slight difference in colour could result in small actual UI changes being missed. Basically any change to any element with a small enough share of the screens pixels will be missed.
The Solution
Pixel Tolerance
This PR introduces a new tolerance implementation which considers the percentage change in a pixels RGBA colour components to determine whether or not a pixel is considered 'different'.

(referencePixel.colourComponent - actualPixel.colourComponent) / 256 = percentage difference

This new implementation means we are able to tolerate slight changes in a pixels colour components but still pick up what would be a 'major UI change' such as moving, adding, or removing an element on the screen or drastically changing its colour.
The new implementation can be used as a replacement, or work in tandem with the old implementation to provide the greatest flexibility to the developer. It's also fully backwards compatible and shouldn't cause any issues for consumers getting the latest version of ios-snapshot-test-case.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jerry Boyaji seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks Jerry. Great work.

How's it looking with this improvement?
Looking forward to use this 👍

Thanks @martinstolz ! haven't hear anything from the repo owners :(

Sorry @JerryTheIntern, I've been silent on this PR because we've been having a discussion internally about how this repository should evolve in the future. Since this PR came out of nowhere, we weren't expecting it, and we weren't sure if we should take it.
The first issue stems from us only getting this repository in the past year and not knowing it well enough to PR such a large contribution. If I was 100% intimate with every bit of this repo, it would be easier for me to review your change. But I'm not, so it's tricky. For smaller contributions I can usually take an hour or so to test the change and code review it. But for larger ones, we err on the side of caution and unfortunately they just don't get much attention — but that's my fault and I'm sorry for that.
The second is that we just didn't know at the time when your PR'd this if the library would continue to churn with lots of feature development or if we should focus on stability maintenance, mostly because someone found this in Xcode 10's betas.
But here's what I suggest for now. Re–implement your change on top of master (because it has changed a lot since you PR'd this and rebasing will be tough). Just try to follow the existing repository's code style (you can do $ find . -name *.[hm] | xargs bin/clang-format -i -style=file to format). I'll also leave a few comments on your older PR for you to address.
Once you update, I'll take a day to PR it and we'll see if it's ready to go.
Again, sorry for the delay in responding.


Router breaks setting paths with multiple leaf keys.

Copied from https://github.com/Netflix/falcor/issues/576:

@michaelbpaulson the matcher (operations/matcher/index.js) distributes collapsed PathSets into distinct (simple) matches, but when all the matches collapse back into a single PathSet, only the first match is pushed into the collapsedMatched list. The reducedMatch list has a match for each leaf in the original PathSet, but collapsedResults only has one element, since all the matches came from the same PathSet and can be re-collapsed into one Path.

I reproduced this with the following code in node:
var falcor = require("falcor");
var Router = require("falcor-router");
var inspect = require("util").inspect;
>
falcor({source: new Router([{
    route: ['path', 'to', ['a', 'b', 'c']],
    set: function(jsonGraph) {
        console.log('set route args:', inspect(arguments, {depth: null}));
        return {
            paths: [['path', 'to', ['a', 'b', 'c']]],
            jsonGraph: jsonGraph
        };
    }
}])}).set({json: { path: { to: {
    a: "aaa",
    b: "bbb",
    c: "ccc",
}}}}).subscribe(function(data) {
    console.log('result:', inspect(data, {depth: null}));
});

I just came across this today. I thought I was going mad thinking it was an issue with my code. Is there anything I can do to help fix this bug?

@ekosz we can try lobbying @michaelbpaulson or @sdesai to investigate further, though I believe Michael's still on leave.

also @jhusain

I can try and free up some time to look at this tomorrow.

Just pinging this issue again. I believe this is a major gotcha right now. It would be nice to be able to use an official release again rather than work off of a fork where this is fixed.
Thanks!

Hey @ekosz - Sorry, this fell through the cracks. my bad. @michaelbpaulson is on an issue resolution bender right now, I've asked if he could free up some cycles to look into it.

@ekosz I am off of the leaves and unto the falcor.  I'll take a look at this and see if I can get a fix into master.


Integrate with curios

Industrial Foregoing Version: 1. 15.2
TeslaCoreLib Version:
Crashlog (If Any):
Just wondering if you could add support for curios (similar to baubles), so when I have the meat feeder in a slot it will auto feed me, thanks.

Done in recent commits

Done in recent commits


Rendering multiple datasets in a plot?

I wonder how to get multiple datasets rendered inside the same figure? I've tried the following, but that shows only the last one:
import numpy as np
import ipyvolume as ipv

ipv.figure()
x, y, z = np.random.random((3, 1000))
ipv.quickscatter(x, y, z, size=2, color='red', marker="sphere")
x, y, z = np.random.random((3, 1000))
ipv.quickscatter(x, y, z, size=2, color='blue', marker="sphere")
ipv.show()

Maybe this a duplicate of #62?

ipv.quickscatter is actually creating its own ipv.figure() inside the convenience function, and adding the scatter points to that new figure object.  Try using ipv.scatter() instead:
import numpy as np
import ipyvolume as ipv

ipv.figure()
x, y, z = np.random.random((3, 1000))
ipv.scatter(x, y, z, size=2, color='red', marker="sphere")
x, y, z = np.random.random((3, 1000))
ipv.scatter(x, y, z, size=2, color='blue', marker="sphere")
ipv.show()

Works great! Thanks!
I had not realized this is the purpose of the quick prefix. And while scatter() gives a nice docstring, quickscatter() doesn't.

Good point about the docstrings, do you want to make a pull request? It's not entirely intuitive.
quickscatter() and quickquiver() could probably have their docstrings modelled after the quickvolshow docstring in ipyvolume/ipyvolume/widgets.py

quick* is for when you have some data and just want to show it, not deal with any other figure that may or may not already be present. PR welcome!


Add to-html co-maintainer

@Aloso you've been added as a co-maintainer on the package. Are you fine with the non-obfuscated email address?

@CosmicHorrorDev yes, the email address is fine.


Create Transformation task for Xenograft_sample

As a developer, I want to have a Luigi task that transforms the data/metadata given by providers into a suitable format for the entity Xenograft_sample.
Design
Database Schema

Create entry in scripts/init.sql for the creation of the table, pk and fks.
Create entry in etl/workflow/transformer.py with the class TransformModel.
Create entry in etl/jobs/transformation/spark_transformation_job.py
Create job etl/jobs/transformation/xenograft_sample_transformer_job.py
Create entry in luigi.cfg
Create entry in etl/workflow/loader.py

Acceptance Criteria

[x] Table model was created according with the designed database schema
[x] The transformation task can be executed and it finishes correctly
[x] Data in the Xenograft_sample table is the expected one for the provider(s)

@CsabaHalmagyi done


Out-Display not working as expected in VS Code.

Describe the bug
I've been experimenting outputting SVG, which worked in Jupyter with an older version of .Net Interactive, but not in VS Code, eventually I simplified this down to any HTML markup not working, with this simple example
"<body><b>Test<b><body>" | out-display -mimetype "text/html"

On  1.0.115407 / Jupyter  outputs Test    -this is preserved if I save the file and re-open in vscode.
On 1.0.145905 / VS Code outputs <body><b>Test<b><body>
I can't tell if there is an intentional change in behavior (does out-display need to be called differently), or if Out-display or something downstream from it is failing.
Please complete the following:
Which version of .NET Interactive are you using?   1.0.115407 (works) and 1.0.145905 (fails)

OS

[X] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[X] Edge  (86.0.622.10)
[ ] Firefox
[ ] Safari

Frontend

[X] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[X] Visual Studio Code  (1.49.0-insider)
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.

Above, vs-code failing, below Jupyter working

This was somewhat by design, as a result of a recent formatter overhaul, but it's worth discussing this scenario again.
@dsyme We changed this behavior to support formatting all strings in <div> elements, rather than rendering them with text/plain. Among other things, this allows columnar whitespace layouts to be preserved.
It also made things a bit more consistent. Two different behaviors were conflated in the display API previously, like this:

display("<b>hello</b>", "text/html") -> The input is HTML, please don't encode it.
display(someObject, "text/html") -> Please render a representation of the object into an HTML table.

The first case now encodes the HTML, so the meaning is consistent in both cases: Please transform the input into HTML.
If you want to use a string literal to emit HTML, you can still do this:

In #770 @colombod added some tests to illustrate the original scenario.
So the question is do we think we have the right behaviors and APIs here?
(There's a separate desire to create some more .NETish, less IPythonish alternatives to these APIs, but that's more of a naming discussion and we'll save that for another issue.)

THANK YOU
For PowerShell I had to call html() like this
[Microsoft.DotNet.Interactive.Kernel]::HTML($svg) | Out-Display

but it's working nicely :-)

I tweeted this earlier running in Jupyter and now it's in vscode - read a YAML specification of an azure-devops pipeline, draw it as a simple SVG chart. Output to notebook.

Wow


HACK: Non-optimal, but functional GeSHi syntax highlighting

Presented as a functional possibility.  This was my 5mins work, and is working, but surely needs cleanup and/or refactoring to fit general plugin style.

I have added a new Pull Request ( #19 ) which assumes less of the code - perhaps that would be suitable?


drivers: modem: wncm14a2a: remove socket_reading logic

Remove overly complicated logic to skip incoming data if we were
still waiting on a previous set of data to be read.
This fixes a bug where an error during data receive could end up
with the modem ignoring all incoming data.
Signed-off-by: Michael Scott<EMAIL_ADDRESS>

@pfalcon let me know if the comment makes more sense now.

@mike-scott: Yes, it's definitely much more detailed, and will help anyone who will need to debug this driver (or use it as a base for other hardware). Thanks!

@jukkar gentle ping (welcome back from vacation!)


Preview support for Date and Time Picker

WHAT

WHY
Previews are useful.
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

This doesn't show the selected day, but is an improvement.


Allow to show tile boundary in debug.html

Something like this

I think @upsicleclown had some experience with this?

A method in maplibre:
map.showTileBoundaries = true;

The map will render an outline around each tile and the tile ID
The uncompressed file size of the first vector source is drawn in the top left corner of each tile, next to the tile ID

Yes, good idea


CXM-5384 Fix fk validation with arrays of file names

It was recently discovered that even though we can specify an array of file names in the foreignKey property of our mvom schemas to validate the foreign key against, it is only ever validating against the first file. This PR changes the file name/entity name separator character from a , to a # since when an array of file names gets transformed to a string it inserts commas between each of them. Thus, when performing splitting logic later on in the process flow, it was not working correctly. After making this change the file names, were correctly split from the entity name, but additional splitting was needed to split each of the file names back into an array to pass to the u2 subroutine.

That's really cool that it allows you to just accept a suggestion like that. I accepted it, thanks!


Bar Chart default color accesor

Currently the bar chart is:

Before

I think expected color is the before one.

@MatthewHerbst Any thought on this ?

I agree. I could hot fix this now if you want, or maybe if we can figure out #237 then I can do the entire overhaul.

@MatthewHerbst Can we fix this first because I want to update our npm registry fast. Thanks.

I found it's not good to tweak the default colorAccesor property of BarChart so I think the best way to do this now it to turn BarChart into multi series chart.
If we pass it one series it will looks like the before.
Probably I can do this on tomorrow.

I was going to try doing this tonight:
// Recall that d3.scale.category20c() actually returns the function d3.scale.ordinal()
// category20c() is just short-hand for d3.scale.ordinal().range(d3_category20c);
colors: (colorAccessorValue) => (x) => '#3182bd'

But the tests break when I do that. Can't figure out when

Another way to solve this (which I think is better) is to make BarChart into multi series graph.
If we pass in one series, it will become what show in our website.

The cool thing about making BarChart me multi-series would also be that we could allow for stacked bar charts. I think that would be awesome. In fact, you can really think of all BarCharts as being stacked bar charts.

stacked bar charts
Working on this

Hey @yang-wei Let me know when you've got this ready. I'm holding off on making a pr for #237 until you make these changes since I don't want to have to do any crazy merge-conflicts.

@MatthewHerbst  This is merged in #245. Please go ahead !


fix(core): assign changed model in expressionProperties into formControl.

fix #723
What kind of change does this PR introduce? Bug fix

This change is

Codecov Report

Merging #724 into master will decrease coverage by 0.05%.
The diff coverage is 95%.

@@            Coverage Diff            @@
##           master    #724      +/-   ##
=========================================
- Coverage   94.26%   94.2%   -0.06%
=========================================
  Files          17      17
  Lines         767     777      +10
  Branches      221     224       +3
=========================================
+ Hits          723     732       +9
- Misses         44      45       +1

Impacted Files
Coverage Δ

src/core/src/services/formly.form.expression.ts
95.18% <95%> (-0.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901a431...c01dfdf. Read the comment docs.


Simplify special file/template name lookup

We never diff the filename/template based on the special file - so turn methods -> properties. I suspect this was done to original differ between C#/VB, however, now we have separate components for those.

tag @srivatsn @dotnet/project-system


[1.19.2] Emi does not respect Forge's IShapedRecipe

Quark's ShapedExclusionRecipe implements that, but it's shaped as though it was a 3x3 recipe, despite being 2x2.

That's peculiar, doesn't vanilla have a concept for shaped recipes? Oh well, I'll fix this

It does, but only for ShapedRecipe and this can't extend that for technical reasons

Oh, actually, this appears to be a Quark bug. Quark is returning true from Recipe.fits given large bounding boxes.

Oh wack
On Sun, Jul 9, 2023 at 4:55 PM Emily Rose Ploszaj @.***>
wrote:

Oh, actually, this appears to be a Quark bug. Quark is returning true
from Recipe.fits given large bounding boxes.
—
Reply to this email directly, view it on GitHub
https://github.com/emilyploszaj/emi/issues/233#issuecomment-1627822275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSKPDG44GUZCG4ER4GVYSDXPMLEBANCNFSM6AAAAAAZ52TMJQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Yoni Segal
Software Engineer
617-678-2815 <1-617-678-2815>
they/them

It's still likely reasonable to fix this on the EMI side so I will but yeah

huh. but we do return parent.canCraftInDimensions(width, height); (which i'm assuming is the mojmap for fits)

It only seems to consider the parent recipe's restrictions

well yeah, but the parent recipe is a 2x2 recipe here

boolean shapeless = recipe.fits(1, recipe.getIngredients().size()) && recipe.fits(recipe.getIngredients().size(), 1);
Not sure then, the only other possibility is your class extends shapeless recipe for some reason, which does not look like the case

Well it isn't showing the shapeless symbol, so I don't think it thinks the recipe is shapeless. It's just being improperly applied to the 3x3 grid instead of 2x2.

Ah, guess I gotta narrow in on the proper size, mods like ct must buffer with empty stacks for alignment. Okay this is my responsibility then.

This is fixed in EMI 1.0.7


Pan Gestures conflict with ScrollView?

Still trying to understand how react-native-drawer works (maybe react native, more generally).  In the below example, the Dashboard component has a ScrollView to allow panning in the vertical direction.  This works great, except in the area where react-native-drawer is waiting for the panGesture (the panOpenMask property).  In this area, only a horizontal swipe is recognized and it opens/closes the drawer.
Is this the expected behavior, or can the vertical gestures be left to the ScrollView?
   render: function() {
      return (
         <View style={styles.mainContainer}>
            <Drawer
               ref='leftDrawer'
               content={<LeftDrawer />}
               type='static'
               side='left'
               openDrawerOffset={75}
               onOpen={this.openLeftDrawer}
               onClose={this.closeDrawers}
               styles={{main: {shadowColor: '#000000', shadowOpacity: 0.4, shadowRadius: 3}}}
               tweenHandler={Drawer.tweenPresets.parallax}
               tweenDuration={100}
               >
               <View style={styles.container}>
                  <NavBar toggleLeftDrawer={this.toggleLeftDrawer}/>
                  <Dashboard />
               </View>
            </Drawer>
         </View>

The way react-native gesture negotiation works is that children have first dibs to handle a pan. This means that your scroll view should work and take precedence over the drawer pan.
The exception to that is if captureGestures={true} which inverts the negotiation flow and gives first dibs to the parent.
Depending on the details of your implementation there may be a few ways to "resolve" this issue. The simplest is typically to make your panOpenMask={5} which means only 5 pixels worth of the edge are valid to start a drawer open pan. In normal use no user starts a vertical pan that close to the edge, thus resolving the issue.
Let me know if that works

Zack - Thanks for the feedback.  I added panOpenMask and anything > 1 is giving the entire screen to react-native-drawer.  If I make it 0.5, the left half of the screen is available to open the drawer (with a swipe from left to right (left hand drawer)), but I can't vertically scroll in that section.  The right half of the screen is available for vertical scrolling (w/ the mask set to 0.5).  Am I doing something obviously wrong?  Using 1.90 of react-native-drawer
Thanks for the help.

Sounds like a bug, ill check it out

added pixel based masking in v1.9.1
Let me know if that solves your issue.

Just tried 1.9.1 .... pixel based masking does work, but I get the same behavior.  I set the mask to 5 and you have to start at the edge to swipe open the drawer (not the behavior I'd like) but the vertical scrolling works (except for those first 5 pixels).  I'm looking for Slack type behavior...... left right opens drawers.  Up down scrolls the ScrollView.

ah ok. Right now react-native-drawer only implements onStartShouldSetPanResponder.
To fully achieve slack (iOS) style you are going to need to implement onMoveShouldSetPanResponder and return true to what you consider to be "horizontal" moves. It will take some tinkering to get right, but should not be paricularly difficult.
Basically you would need to implement a method similar to https://github.com/rt2zz/react-native-drawer/blob/master/index.js#L246 but which only returns true if a horizontal gesture is detected. I think you will also need to disable onStartShouldSetPanResponder to allow the negotiation to happen.
If you get it working I will gladly accept a PR!

Created a PR for your review.  Thanks for all your help with this.


Bookstore: styling

Bookstore
In this pull request, I have :

[ ] Addd the missing JSX elements to the project without adding extra functionality
[ ] Used the CSS rules detailed in Zeplin to style the website to match the design
[ ] Fix all linter errors

Thanks @DeliceLydia for the approval. 😎


Add find-domains query

Hey, thanks for the contribution. I've pushed some changes but they were pretty minor, your code was great.
Basically I just added documentation for the new struct and function, added a few more domain test cases in the TestFindDomainsExpected test (so far I've found for different availability status: taken, in progress, available, and failed), and reverted the formatting change in provider.go (I know it's not the default Go formatting but I like to keep line lengths at around 80 characters or so).
Thanks for the contribution, and apologies for taking a while to get to it.

And now this is also been released under v0.2.0. Cheers!


ucl-1.03-1-x86_64.pkg.tar.xz fails PGP and checksum check

Not really sure if this is the correct place to report this but the latest binary build of the ucl package fails the PGP/checksum check.  I've tried to install it from multiple mirrors without success.  It is the only package I've had this issue with so I'm pretty sure it is actually messed up somehow.  I even tried rebuilding and refreshing my keys.  Maybe the signature is just wrong.

Maximum file size exceeded error occured trying to install the ucl-* files and seems to be related to the checksum mismatch of a signature resulting in the following terminal output:
Retrieving packages...
error: failed retrieving file 'ucl-1.03-1-x86_64.pkg.tar.xz' from repo.msys2.org : Maximum file size exceeded
warning: failed to retrieve some files
error: failed retrieving file 'ucl-devel-1.03-1-x86_64.pkg.tar.xz' from repo.msys2.org : Maximum file size exceeded
warning: failed to retrieve some files
error: failed to commit transaction (download library error)
Errors occurred, no packages were upgraded.

I still have the same issue:
:: Retrieving packages...
error: failed retrieving file 'ucl-1.03-1-x86_64.pkg.tar.xz' from repo.msys2.org : Maximum file size exceeded
error: failed retrieving file 'ucl-1.03-1-x86_64.pkg.tar.xz' from downloads.sourceforge.net : Operation timed out after 10727 milliseconds with 0 out of 0 bytes received
error: failed retrieving file 'ucl-1.03-1-x86_64.pkg.tar.xz' from www2.futureware.at : Maximum file size exceeded
warning: failed to retrieve some files
error: failed to commit transaction (download library error)
Errors occurred, no packages were upgraded.

Just wgetting it (and placing it in /var/cache/pacman/pkg) doesn't work either, it reports the package as invalid or corrupted then. The file itself is fine though, has to be a mismatch somewhere.

I meet the same issue too.  I grab the package myself and palce to the cache, but it still give the prompt "Invild GPG signature"

Does downloading the package contents from here on Github and running makepkg -sri fix the issue? I found a workaround for a similar issue with the ctags package a while back.


Fall back to 'other' if a plural form is missing

If a service currently has a character count inside an element with a non-English lang tag and tried to use the current implementation, the Character Count may throw an error and not update the count message when the user has a certain number of characters remaining.
This is because we are only providing default translations for the one and other plural forms (the only forms required in English).
But if the character count was in a cy-GB locale for example it would expect plural forms for two, few and many, and when the user got down to 6-2 characters remaining an error would be thrown and the count message would not be updated.
In order to preserve the existing behaviour, falling back to other is a reasonable thing to do, even if it may lead to incorrect plural forms being used in some cases.
Closes #2918.

I am not 100% sure about the warning – I think there are cases where users could omit plural forms and the translations would be fine.
Just because a language might use a different plural form, doesn't mean it will.
To give a slightly silly example, this would log a warning, but the localisation is perfectly correct:
const i18n = new I18n({
    'test.other': 'Ollie has %{count} sheep'
}

i18n.t('test', { count: 1 }) // Ollie has 1 sheep
i18n.t('test', { count: 2 }) // Ollie has 2 sheep

To silence the warning, they'd need to pass test.one even though it works exactly the same as other. Should we be trying to enforce passing all plural forms in code when they might not all be needed?

Should we be trying to enforce passing all plural forms in code when they might not actually be needed?

I'm gonna say yes, if just for consistency and error checking's sakes. In that example, it's more coincidental that the one and other forms of 'sheep' are the same than by the design of the language.
A reverse argument might be that we shouldn't require other in all situations because Chinese, Malaysian, Indonesian, etc. don't have plural forms at all and all nouns are singular. Russian is similarly weird, with the other form only used for decimal numbers, with all whole numbers using one of the other plural forms.
At least by pushing a warning out for a missing form, we can assist developers (who may not be speakers of the language at hand) in knowing if a required string is likely to be missing or malformed.

As a stray thought (sorry!), in my mind, the functionality to fall back to other is only present to avoid a breaking change in existing services where they upgrade Frontend, and have a situation where the page is set in one lang but the component has not been translated yet.
However, falling back to other is a 'best guess' assumption and is not reliably true for all languages, nor is this something we actually want service developers to use or rely on as an intended feature. (Ideally, all plural forms needed should be explicitly set.)
Would it be a good idea to have a follow up card to remove the fallback in a future breaking release?


Use model loaders or a fake resource pack for vanilla tweaks

This exposes control of those to the end user. Model would be a config model that swaps quads based on config. Resource pack would be like I did in Animal Crops

Added in 2bace3a


race in tsdb.headAppender.AppendHistogram

What did you do?
Run Mimir with race detection enabled.
What did you expect to see?
No race condition.
What did you see instead? Under which circumstances?
WARNING: DATA RACE
Write at 0x00c08329f350 by goroutine 148443:
github.com/prometheus/prometheus/tsdb.(*headAppender).AppendHistogram()
.../vendor/github.com/prometheus/prometheus/tsdb/head_append.go:668 +0x6ed
github.com/prometheus/prometheus/tsdb.(*dbAppender).AppendHistogram()
:1 +0xa1
...
Previous write at 0x00c08329f350 by goroutine 236366:
github.com/prometheus/prometheus/tsdb.(*memSeries).appendHistogram()
.../vendor/github.com/prometheus/prometheus/tsdb/head_append.go:1403 +0x1c9
github.com/prometheus/prometheus/tsdb.(*headAppender).Commit()
.../vendor/github.com/prometheus/prometheus/tsdb/head_append.go:1168 +0x2d48
github.com/prometheus/prometheus/tsdb.dbAppender.Commit()
.../vendor/github.com/prometheus/prometheus/tsdb/db.go:1278 +0x49
github.com/prometheus/prometheus/tsdb.(*dbAppender).Commit()
:1 +0x4e
...
System information
No response
Prometheus version
No response
Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Seems like we modify memSeries here https://github.com/prometheus/prometheus/blob/720a2599a6093f3416477bcc355c1aaf3c2df1da/tsdb/head_append.go#L676  without lock. The conflict is with https://github.com/prometheus/prometheus/blob/720a2599a6093f3416477bcc355c1aaf3c2df1da/tsdb/head_append.go#L1512 which is in fact under lock.

Use case when it happens: two different goroutines happen to create the same native histogram series as the same time . The two appenders race and conflict on the common memSeries.

Ok


Failed to build in iOS

Environment
(Which react-native version? What version of this library? iOS, Android, or both?)
react-native: 0.50.4
react-native-google-analytics-bridge: 5.6.0
Steps to Reproduce
Install with npm: npm install --save react-native-google-analytics-bridge
Link with: react-native link react-native-google-analytics-bridge
Run react-native run-ios
Expected Behavior
App would run.
Actual Behavior
CompileC /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/Objects-normal/x86_64/RCTGoogleTagManagerBridge.o /Users/nachogrondona/project/node_modules/react-native-google-analytics-bridge/ios/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge/RCTGoogleTagManagerBridge.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
cd /Users/nachogrondona/project/ios/Pods
export LANG=en_US.US-ASCII
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/nachogrondona/.rvm/gems/ruby-2.4.1/bin:/Users/nachogrondona/.rvm/gems/ruby-2.4.1@global/bin:/Users/nachogrondona/.rvm/rubies/ruby-2.4.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/nachogrondona/.rvm/bin"
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu11 -fobjc-arc -fmodules -fmodules-cache-path=/Users/nachogrondona/project/ios/build/ModuleCache -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/Users/nachogrondona/project/ios/build/ModuleCache/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wdocumentation -Wunreachable-code -Wno-implicit-atomic-properties -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DPOD_CONFIGURATION_DEBUG=1 -DDEBUG=1 -DCOCOAPODS=1 -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.2.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mios-simulator-version-min=7.0 -g -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wunguarded-availability -fobjc-abi-version=2 -fobjc-legacy-dispatch -index-store-path /Users/nachogrondona/project/ios/build/Index/DataStore -iquote /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/react-native-google-analytics-bridge-generated-files.hmap -I/Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/react-native-google-analytics-bridge-own-target-headers.hmap -I/Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/react-native-google-analytics-bridge-all-target-headers.hmap -iquote /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/react-native-google-analytics-bridge-project-headers.hmap -I/Users/nachogrondona/project/ios/build/Build/Products/Debug-iphonesimulator/react-native-google-analytics-bridge/include -I/Users/nachogrondona/project/ios/Pods/Headers/Private -I/Users/nachogrondona/project/ios/Pods/Headers/Private/react-native-google-analytics-bridge -I/Users/nachogrondona/project/ios/Pods/Headers/Public -I/Users/nachogrondona/project/ios/Pods/Headers/Public/HockeySDK -I/Users/nachogrondona/project/ios/Pods/Headers/Public/React -I/Users/nachogrondona/project/ios/Pods/Headers/Public/react-native-google-analytics-bridge -I/Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/DerivedSources/x86_64 -I/Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/DerivedSources -F/Users/nachogrondona/project/ios/build/Build/Products/Debug-iphonesimulator/react-native-google-analytics-bridge -include /Users/nachogrondona/project/ios/Pods/Target\ Support\ Files/react-native-google-analytics-bridge/react-native-google-analytics-bridge-prefix.pch -MMD -MT dependencies -MF /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/Objects-normal/x86_64/RCTGoogleTagManagerBridge.d --serialize-diagnostics /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/Objects-normal/x86_64/RCTGoogleTagManagerBridge.dia -c /Users/nachogrondona/project/node_modules/react-native-google-analytics-bridge/ios/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge/RCTGoogleTagManagerBridge.m -o /Users/nachogrondona/project/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/react-native-google-analytics-bridge.build/Objects-normal/x86_64/RCTGoogleTagManagerBridge.o
In file included from /Users/nachogrondona/project/node_modules/react-native-google-analytics-bridge/ios/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge/RCTGoogleTagManagerBridge.m:1:
/Users/nachogrondona/project/node_modules/react-native-google-analytics-bridge/ios/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge/RCTGoogleTagManagerBridge.h:1:9: fatal error: 'React/RCTBridgeModule.h' file not found
#import <React/RCTBridgeModule.h>
^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
** BUILD FAILED **
Code sample/demo project
(Write or link sample here.)

I'd re-install and try again, it's having problems resolving the RN framework.

Closing this because of inactivity


update NOTICE to reflect recent CLA signers

ram vennam has signed the CLA

another signer (avery huang)


arm-web generated swagger spec update

Hi @LukaszStem, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (lukaszs). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Hi @LukaszStem. Could you add a summary of the changes in the description for the commit/PR? It will make it easier for other people to see what changed in this update (which is important when client libraries will be generated from this spec). It also helps me review, since the number of lines is large enough that I can't review it in Github, but download the changes to my machine instead.


UnkeyedDecodingContainer - corrupted data causes crash

Could we add a guard check before we touch data array with start and end indexes?  We should throw an error if data doesn't contain requested range. It causes fatal error if data array doesn't contain range.startIndex..<(range.endIndex)
let container = _CBORDecoder.SingleValueContainer(data: self.data[range.startIndex..<(range.endIndex)], codingPath: self.codingPath, userInfo: self.userInfo)

A PR for this would be great - are you able to give it a go? Then I can review and we can get something merged


Add c shim wrapper codegen.

Add c shim wrapper codegen.
Support generate c shim wrapper for OPs in torch_xpu_ops which extend the c shim wrapper of Pytorch in-tree XPU ops.

This PR is relied upon by AOT Inductor PR https://github.com/pytorch/pytorch/pull/139026.
And should be able to pass the CI after Pytorch PR https://github.com/pytorch/pytorch/pull/136742 landed.
The design is descripted in https://github.com/pytorch/pytorch/pull/136742

CI failure. Because it depends on PyTorch PR, right?

@fengyuan14 can I merge this PR?


Update to current state of progress proposal

The proposal for reporting progress has changed quite significantly since it was added to haskell-lsp. There is now a branch for LSP 3.15 that contains the current state https://github.com/microsoft/language-server-protocol/blob/dbaeumer/3.15/specification.md so hopefully the current state is somewhat final and we can update haskell-lsp to use it.

Would anyone like to prepare a PR?

I’ll try to find the time but I’m not sure when I’ll get around to it.

I have a first draft of this at https://github.com/cocreature/haskell-lsp/tree/new-progress and a branch of ghcide that makes use of it and seems to work at https://github.com/digital-asset/ghcide/tree/fix-progress. It needs more work to get it into a mergable state so if anyone wants to help out, let me know or make a PR against my branch.


emitWithAck missing

I spent a little bit looking into the methods internally here and found a really nice feature seems to be missing or perhaps I am not seeing where/how it is implemented which is emitWithAck.
emitWithAck allows to send data to the server and then get back data as a promise. I REALLY could use this part of socket.io in my Unity project as right now I am having to resort to callback hell in order to pull off what I'm needing done.
Thanks for the help or consideration!

await socket.EmitAsync("getMD5", response => {
  string text = response.GetValue<string>();
  JSONObject jsonObject = new JSONObject(text);

  return jsonObject["data"]["test"].stringValue;
}, theData);

This is so close to being perfect, but the return from EmitAsync is void so it doesn't allow for passing the result back to the containing method, and I can't assign to a variable outside response function as despite EmitAsync being async, me trying to use the value after the EmitAsync results in empty variable (see below).
string res = "";
await socket.EmitAsync("getMD5", response => {
  string text = response.GetValue<string>();
  JSONObject jsonObject = new JSONObject(text);

  res = jsonObject["data"]["test"].stringValue;
}, theData);

Debug.Log(res); <== This is empty.

I might just change the source for EmitAsync to allow for a return type that is not void which should result in what I need to accomplish but still would be nice feature to not have to go in and modify the source.
Cheers!

use TaskCompletionSource:
using System.Threading.Tasks;

public class YourClass
{
    public async Task<string> GetResultAsync()
    {
        var tcs = new TaskCompletionSource<string>();

        await socket.EmitAsync("getMD5", response =>
        {
            string text = response.GetValue<string>();
            JSONObject jsonObject = new JSONObject(text);
            string res = jsonObject["data"]["test"].stringValue;

            tcs.SetResult(res);
        }, theData);

        return await tcs.Task;
    }
}

or this is better in term of performance

public async ValueTask<string> GetResultAsync()
    {
        var tcs = new TaskCompletionSource<string>();

        await socket.EmitAsync("getMD5", response =>
        {
            string text = response.GetValue<string>();
            JSONObject jsonObject = new JSONObject(text);
            string res = jsonObject["data"]["test"].stringValue;

            tcs.SetResult(res);
        }, theData);

        return await tcs.Task;
    }

usage:
public async Task UseGetResultAsync()
{
    YourClass instance = new YourClass();
    string result = await instance.GetResultAsync();
    // Use the 'result' here, it will contain the value from the callback.
    Debug.Log(result);
}

if not working check with @doghappy at: https://github.com/doghappy/socket.io-client-csharp

Hey, I was able to get what I needed in another fashion but this is looking mighty handy, I will do some unit testing probably tomorrow and try it out and get back here on how that goes, this could prove useful in the future for sure, thanks!

Forgot to close..


terminal link path separator should use backend os

Guess this was an existing bug, but this needs to be the backend's OS, not the frontend
Originally posted by @Tyriar in https://github.com/microsoft/vscode/pull/140676#r785024730

Bad link but it was this comment:

I don't see references to isWindows in the links folder anymore so closing off.


[UE5.2] Crash on shutdown

Hello there. We have crash on FAcousticsSpatializer::Shutdown() when HrtfEngineUninitialize called & also in FAcousticsSpatialReverb::ProcessAllSources when HrtfEngineProcess called. All this happens in the editor, when you exit the game mode. It is also often repeated when trying to launch the client + server in the main window in the editor.
We understand that there is no set timeline for an official update right now, but we hope someone will point us in the right direction in resolving this issue on our own.
Best regards

@afrostalin Thank you for reporting this problem.  We have a plan to do a UE5.2 marketplace update of our plugins in the next 4-6 weeks so we'll add this to the list of issues to address for this update.
Does this happen consistently when exiting game mode with the Microsoft Spatializer plugin chosen for spatialization?  Or does it only happen some of the time in your testing?

This happens stably in the editor on the second launch of the game mode. I added some changes to the call order and it helped a bit and removed the direct dependency, but it still happens at random times

@afrostalin The UE5.2 update is now on the UE Marketplace with a fix to address this issue.  Thanks for your patience.


Integrate future blocks at the start of the forging loop

Description
Closes https://github.com/input-output-hk/consensus-team-private/issues/16.
Checklist

Branch

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] The documentation has been properly updated
[ ] New tests are added if needed and existing tests are updated
[ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[ ] Self-reviewed the diff
[ ] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

Routine cleanup of stale PRs targeting Consensus components (which nowadays live in https://github.com/IntersectMBO/ouroboros-consensus).
No work is lost, see https://stackoverflow.com/a/17954767.


Add automation start/stop to alarm state change actions

Hi,
In addition to simply turning on a light or a switch it would be great to be able to start or stop a existing automation as part of the alarm state events.
Allowing this make a far more versatile way of enabling sound, flashing lights, media playing, etc all at the users discretion and imagination.
Thanks for consideration,
Trant

Hi,
good idea, I would love to be able to use it too.
Thanks

push request to not been closed ;)

Push


Better build run-times.

The run-time for a build is described as the total of the run-times of all the steps of the build. While this is useful, it does not tell a very good story of how long a build takes to run and this is mainly because after the analysis step, the rest of the steps run in parallel.
This PR introduces a build-run-time which is:
(run-time of the analysis step) + max ((run-time of step) | step in build)

This build_run_time is displayed prominently (in the same spot that the run-time for the build has been displayed). The total-run-time continues to be displayed, but now less prominently.

Thanks for this PR! What about Cumulative build time instead of Total? Maybe, it comes from my poor English vocabulary but with the too time on the screen, the total feel a bit confusing. WDYT?

Thanks @maiste and @benmandrew for the feedback. I've thought about this and looked at examples from other CIs (GitHub Actions and also Buildkite) and both of them use the word 'total.' I'm not convinced that using 'cumulative' is better than using 'total' ... I prefer the simpler term because of its common use. Unless there are objections, I'd like to continue with the terminology as it stands. If you think I am missing something, or would like to discuss this further, please feel free to do that here.

I understand your point of view, and I would keep total if we don't have any other time. If you take the case of GitHub Actions, they only display the total time. As it's monetized, you know how much it will cost.
The more I think about it, the more I wonder if we shouldn't invert time values instead, keep the Total on the right side, and put the max time in the middle.  Indeed, the max time reflects the maximum time you have run, while the total time reflects how much we have occupied CPUs, which is a value easier to visualise...

I find the current wording somewhat confusing.
Unless I'm mistaken, GHA doesn't show the cumulated time of all parallel build, but shows your definition of build-run-time that it calls "Total duration".
Wikipedia speaks of total CPU time which is for parallel programs the sum of the durations of each independent run (your total-run-time).
The less I could say is that the notion of total is not well defined ;)
As a user I think I'm more interested by the build-run-time than the total-run-time. If we're to display both numbers, I'd favor the wording cumulative (or even parallel or something else) instead of total.
I don't have a strong opinion on which should be placed where.

Thanks everyone for your input. I hope that once we have documentation for this page, and a tooltip, the different run-times will be clearer.


[sim] use custom VUnit loggers for better verbosity control

Close #48
This PR superseeds #48, but it needs to be merged after #80.
That is, @LarsAsplund's PR2 branch can be analysed/understood in three parts:

PR1 was already split and merged in previours PRs.
The software modifications for controlling UART verbosity are being handled in #80.
This PR adds VUnit loggers to the hardware testbench plumbing.

I'm looking forward to this as I am very interested in this logging feature! 👍

I rebased on top of master. I think this is now ready to be merged.

Hm, it's not due to this PR but probably happened when I was rebasing #80. It should be output on the UART like this but now it's not, the text is just "printed": https://github.com/stnolting/neorv32/pull/82/checks#step:7:560
The bad thing with my testbench is that there is no proper end of test mechanism. It just runs for a while and if all UART output meet the expectation than everything is good. There is nothing checking if all output has been produced, or any output at all. The good thing is that this problem is removed in my "PR3" that needs to be rebased. I will try to do some work on that this evening. Should probably try to fix it on main first.

The bad thing with my testbench is that there is no proper end of test mechanism. It just runs for a while and if all UART output meet the expectation than everything is good.

I know we already had some discussions here, but how about a simple mechanism in the testbench (like a specific GPIO output pattern) to indicate the processor has finishe executing the test program? It is up to the testbench to evaluate (all previous UART outputs for example) if the actual test succeeded.

IMHO, we can either have that fixed in #49, or afterwards. As soon as we start using Verification Components for the UART, I would expect to use them for the external wishbone interface too (thus reducing that maintenance burden from the simple tb).  Then, it will make sense to give a better thought at how to coordinate the VCs for deciding a success or failure.


Not able write to Chroma DB

I just upgraded both chorma and flowise. Now i am not able ro write to chome. Although Collection is created when i run the flow, but then nothing is inserted or embedded in chroma. I am not getting any error as well.

It might because we havent upgraded Chroma version in Flowise, can take a look

Appriciate it @HenryHengZJ, thanks a lot. If you can help me in choosing right version to make it work, that would gret help to me.

Hi @pgaurav007, after some testing on my side, chromadb/chroma:0.5.5 appears to work with flowiseai/flowise:2.0.7

thanks @boblyx for helping to identify that !

Hi @pgaurav007, after some testing on my side, chromadb/chroma:0.5.5 appears to work with flowiseai/flowise:2.0.7

NO, its not working still.

Hi @pgaurav007, after some testing on my side, chromadb/chroma:0.5.5 appears to work with flowiseai/flowise:2.0.7

Thanks a lot @boblyx


willReceiveProps is called initially

There's a danger of triggering some action twice, though didMount and willReceiveProps if not guarded. I would expect that willReceiveProps is only called if the component already exists, otherwise didMount can be used.
  this.didMount = function() {
    // load the document after mounting
    this._loadDocument(this.getDocumentId());
  };

  this.willReceiveProps = function(newProps) {
    if (newProps.documentId !== this.props.documentId) {
      this.dispose();
      // TODO: Use setState instead?
      this.state = this.getInitialState();
      this._loadDocument(this.getDocumentId());
    }
  };

Actually now that I look closer, what we probably need is a willMount hook to complement didMount, so we have a chance to compute derive state before the initial render is performed.

We could also decide to use the existing semantics but then we should call loadDocument only on willReceiveProps.
Related: https://facebook.github.io/react/tips/componentWillReceiveProps-not-triggered-after-mounting.html

This is not done anymore.


Fix dynamic redirect_uri calculation.

Verified on staging with the uploader add flow.

Uh, please update CHANGELOG to reflect this change...


Support set of "View" properties

elevation (Android 5+) https://github.com/eclipsesource/tabris-js/issues/678 ✓
translationZ (Android 5+) https://github.com/eclipsesource/tabris-js/issues/677 ✓
child clipping https://github.com/eclipsesource/tabris-js/issues/143
vertical text alignment

Not so easy to do on iOS, Simple on Android

padding

Can not be done on iOS (without nesting composites), Simple on Android

pivot point for rotation

could be done on both platforms rather easily. Not highest priority

Closing this one as umbrella bug that will not be resolved. The three missing features that do not have their own issue are postponed for now:

vertical text alignment

Not so easy to do on iOS, Simple on Android

padding

Can not be done on iOS (without nesting composites), Simple on Android

pivot point for rotation

could be done on both platforms rather easily. Not highest priority


[Bug] Error: could not compile regex-syntax

🐛 Bug
error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:474:20
    |
474 |             return Ok(true);
    |                    ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:476:9
    |
476 |         Ok(PERL_WORD
    |         ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:504:5
    |
504 |     Ok(match normalized_value {
    |     ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:505:18
    |
505 |         "any" => Some("Any"),
    |                  ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:506:23
    |
506 |         "assigned" => Some("Assigned"),
    |                       ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:507:20
    |
507 |         "ascii" => Some("ASCII"),
    |                    ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:519:5
    |
519 |     Ok(canonical_value(scripts, normalized_value))
    |     ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:556:9
    |
556 |         Ok(PROPERTY_NAMES
    |         ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:613:9
    |
613 |         Ok(PROPERTY_VALUES
    |         ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Err` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:683:21
    |
683 |             None => Err(Error::PropertyValueNotFound),
    |                     ^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:684:24
    |
684 |             Some(i) => Ok(AGES[..=i].iter().map(|&(_, classes)| classes)),
    |                        ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:707:24
    |
707 |             "ASCII" => Ok(hir_class(&[('\0', '\x7F')])),
    |                        ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:708:22
    |
708 |             "Any" => Ok(hir_class(&[('\0', '\u{10FFFF}')])),
    |                      ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Ok` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/unicode.rs:712:17
    |
712 |                 Ok(cls)
    |                 ^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/utf8.rs:360:28
    |
360 |                     return Some(Utf8Sequence::One(ascii_range));
    |                            ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/utf8.rs:380:24
    |
380 |                 return Some(Utf8Sequence::from_encoded_range(
    |                        ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/utf8.rs:398:13
    |
398 |             Some((
    |             ^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Some` in this scope
   --> /Users/piraveensivakumar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.8.3/src/utf8.rs:418:13
    |
418 |             Some(Utf8Range::new(start, end))
    |             ^^^^ not found in this scope

Some errors have detailed explanations: E0405, E0408, E0412, E0416, E0425, E0463, E0531.
error: could not compile `regex-syntax` (lib) due to 1261 previous errors
make[3]: *** [tokenizers/aarch64-apple-ios/release/libtokenizers_c.a] Error 101
make[2]: *** [tokenizers/CMakeFiles/tokenizers_c.dir/all] Error 2
make[1]: *** [CMakeFiles/mlc_llm_static.dir/rule] Error 2
make: *** [mlc_llm_static] Error 2

To Reproduce
Steps to reproduce the behavior:

when I run ./prepare_libs.sh as here, I got this error.


router: deprecating total_weight

Commit Message: router: deprecating total_weight
Additional Description:
The total_weight field in weighted clusters was used to validate that the sum of weights isn't 0.
This PR deprecates the field, and uses the sum of the clusters weights instead. This PR also validates that the sum of weights is above 0 (this constraint was relaxed in #21892).
Risk Level: Low
Testing: Updated current tests.
Docs Changes: Updated
Release Notes: Updated
Platform Specific Features: N/A.
Deprecated: total_weight from weights clusters.
Signed-off-by: Adi Suissa-Peleg<EMAIL_ADDRESS>

/retest

/lgtm api

Assigning Matt for !Google review. This PR is a follow up to the 0 total-weight for weighted-clusters issue, which we discussed offline.
/assign @mattklein123


run YCSB with a cluster with low specifications

Its not issue, but dont know the exact place to put this question.
I would like to know if for testing purposes,  i can use a cluster of 2 nodes with 1vCpu and 512 Mb Ram and run YCSB benchmark for mongo and couchbase, will I  be able to see differences, and results?

Most likely you will be able to see some results. It may not scale linearly if you were to add nodes. It also may fail if you put too much data in. If you are looking for a small comparison then it should work.

when you say small, how small is it?  500 000 rows maybe?

It depends on a lot of different factors.

@ivankirit were you able to make progress on this?

Closing due to no update.


chore: update badger link

Dgraph is dissolved and the original badger repo is not active anymore. Now the badger is maintained under the newly found org, see https://github.com/outcaste-io/badger

Let's keep the original link for now and see how things go. On the other hand, we are expected to split from the original implementation and optimize on our own for our specific cases, so the link is not important unless the repo is deleted.

@Connor1996 How about close it according to jay's suggestion?

Let's keep the original link for now and see how things go. On the other hand, we are expected to split from the original implementation and optimize on our own for our specific cases, so the link is not important unless the repo is deleted.

@BusyJay The situation is clear, the old repo is out of maintenance due to politics, and the core authors establish a new org to maintain it. You can check the article written by the CEO.


fix: typo

Change...React Native CLI tools ant UI Kitten template. to ...React Native CLI tools and UI Kitten template.
Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Thank you!


Merge Develop into Master 4.9.2018 - updating Support contact video, other small updates

Hello @ksigler7,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Playground:  fail to run code

Playground is failing to run code.
The code runs on node on vscode.

Repro:
Playground link

Code - dynamic builder patter:
type Constructor<T> = new (...args: any[]) => T;

type RequireAtLeastOne<T> = {
  [K in keyof T]-?: Required<Pick<T, K>> &
    Partial<Pick<T, Exclude<keyof T, K>>>;
}[keyof T];

type ExcludeKeys<T, U> = {
  [Key in keyof T]: T[Key] extends U ? never : Key;
}[keyof T] &
  keyof T;

type ExcludeType<T, U> = Pick<T, ExcludeKeys<T, U>>;

type NonFunctionPropsToSetters<T, OrigT, NonFunctions = ExcludeType<T, Function>> = {
  // -? make optional as required, otherwize the function will be optional as well
  // Exclude<T, undefined> removes the undefined, so if you call the setter you should pass the actual value
  [Property in keyof NonFunctions as `set${Capitalize<string & Property>}`]-?: (value: Exclude<NonFunctions[Property], undefined>) => BuilderType<Omit<T, Property>, OrigT>;
};

type BuilderType<T extends {} | Constructor<T>, OrigT = T, NonFunctions = ExcludeType<T, Function>> =
  NonFunctionPropsToSetters<T, OrigT> &
    (NonFunctions extends RequireAtLeastOne<T>
    ?  {} : {
        build: () => OrigT;
      }) ;

function getBuilder<T extends {} | Constructor<T>>(
  ctor: Constructor<T>
): BuilderType<T> {
  const fields = new Object() as Record<string, unknown>;
  function build(): T {
    return Object.assign(Object.create(ctor.prototype), fields);
  };

  const builderProxy: BuilderType<T> = new Proxy({} as BuilderType<T>, {
    get: (obj: Record<string, unknown>, prop: string) => {
      if (prop === "build") {
        return build;
      }
      // name is like so: setCapitalizedPropertyName
      const propName = `${prop[3].toLowerCase()}${prop.substring(4)}`;
      return function (value: unknown): BuilderType<T> {
        console.log(`set ${value} into ${prop}`);
        fields[propName] = value;
        return builderProxy;
      };
    }
  }) as BuilderType<T>;
  return builderProxy;
}

class User {
  firstName!: string;
  lastName?: string;
  birthDate?: Date;

  constructor() {}

  print() {
    console.log(this.firstName);
    console.log(this.lastName);
    console.log(this.birthDate);
  }
}
const b1 = getBuilder(User);
const res1 = b1.setFirstName("aa").build();

console.log("b1: ", b1);
console.log("res1: ", res1);

res1.print();
const res2 = b1.setFirstName("a").build();
res2.print();
b1.setBirthDate(new Date()).setFirstName("aa").build().print();

Expected behavior:
code runs and call print function
Actual behavior:
[ERR]: "Executed JavaScript Failed:"
[ERR]: str.replace is not a function

A duplicate of or at least heavily related: https://github.com/microsoft/TypeScript-Website/issues/2356

You're welcome to take a look at fixing this as it looks like its due to your object having issues with the proxy, it's a bug 👍🏻


Replace openssl & aws commands by clients

This removes the requirement to have aws cli installed

There's a problem with issuing a certificate now that didn't happen when using the CLI:
Exception `Aws::ACMPCA::Errors::RequestInProgressException'  - The request to issue certificate XXXX is still in progress. Try again later.


Renaming is* and from*, refactoring

Changed isSomeType(value) to match("someType", value) on Syntax and SyntaxOrTermWrapper, isKind("someType", value) on Enforester. They can all take a regex as a value (untested for now).
Syntax.fromSomeType(val, stx) has become Syntax.from("someType", val, stx).

I strongly prefer explicit methods rather than passing strings.
The is* methods on Syntax could be refactored to include checking the value though. That has been bugging me for a while.

Explicit methods really don't make sense to me, both from a macro writer's and a developer's perspective. As I said in #518, passing a string is more dynamic, which is key for something that's supposed to be built on.
As it stands, dynamically matching a syntax type requires including "is"+capitalize(type) somewhere, which is just plain weird.
Having all syntax types live in a single object also has clear advantages for development and extendability. In the refactored code, all syntax types just consist of a match and a create function (although create functions of some subtypes like literal booleans are still missing). All other match-like functions are passed to the Syntax object. Also, Syntax.from(type, value).match(type, value) is now always true for valid types.
What is it that you like about explicit methods?

Let me rephrase my objection :)
I strongly prefer using explicit methods (especially in the internals of Sweet) rather than having only the dynamic match method. The is* methods can obviously be defined in terms of match, but I still want them to exist and to be used in, for example, the enforester.

Well, since the the whole point of refactoring was to make matching play better with macros, we can just add an internal macro:
syntax is = ctx => {
	let type = ctx.next().value,
		args = ctx.next().value.inner(),
		stx = args.next("expr").value,
		seperator = args.next().value,
		value = args.next("expr").value,
		Syntax = #`;`.get(0).constructor,
		typeString = Syntax.from("string", type.val())

	if (value) {
		return #`${stx}.match(${typeString}, ${value})`
	}
	else {
		return #`${stx}.match(${typeString})`
	}
}

if (is braces(stx)) ...
if (is number(stx, 10)) ...

When custom operators are back, we can turn this into stx is number(10).

Why use a macro when a function works just as well?

A single macro is less bloated than a function for every type. Also, it's dynamic. If you add a type to syntax.js, you won't have to add any methods to the enforester.
The explicit methods don't add any functionality. They're just syntactic sugar. That's what macros are meant for.

Macro would allow for compile-time checking of the argument (so technically, it's even better than .isXYZ() methods that can be typo'd :P ).

Obviously I like macros 😄 but their complexity doesn't pay their way in this case.

Heh, I expected you to jump on this because of the macro. Do you understand why I dislike the current implementation?
Imagine that instead of document.createElement, the folks at Ecma gave us document.createDiv, document.createSpan, etc. This works fine for people who just need to create divs and spans, but it's a pain in the ass for people who want to write libraries like jQuery and React on top of JS, because they have to route every single tag name, instead of just passing an argument through to document.createElement.

As for the enforester, currently is* methods live on the prototype, like this:
class Enforester {
  ...
  isNumericLiteral(term) {
    return term && (term instanceof Syntax) && term.isNumericLiteral();
  }

  isStringLiteral(term) {
    return term && (term instanceof Syntax) && term.isStringLiteral();
  }

  isTemplate(term) {
    return term && (term instanceof Syntax) && term.isTemplate();
  }
  ...
}

This makes little sense considering that enforester instances have nothing to do with syntax matching.

As for a macro not being suitable for this situation, I frankly find it hard to believe that's the position you hold as the maintainer of sweet.js, and I suspect it's mostly familiarity bias speaking. If you don't want to use a small macro for eliminating something as repetitive and verbose as the above code, then what should we use macros for?

Imagine that instead of document.createElement, the folks at Ecma gave us document.createDiv, document.createSpan, etc.

Bad analogy. I’m not saying don’t have isKind/createElement. I’m saying have both isKind and the convenience methods is* (createDiv, createSpan etc.).

As for the enforester, currently is* methods live on the prototype

Yes that is wonky. A broader refactoring is certainly warranted.

If you don't want to use a small macro for eliminating something as repetitive and verbose as the above code, then what should we use macros for?

There is long-standing advice in the Scheme world to use macros only when functions don’t suffice. To my mind it only makes sense to reach for the power of macros if you want to introduce new syntax (something that can’t be expressed via a function) or to relieve some “onerous” repetition. What counts as “onerous” is admittedly a judgment call and I have judged the token types (all 15 of them) and found them wanting 😄.
To me seeing:
isIdentifier(value) {
	return this.match('identifier', value);
}
...

in the codebase is much more readable than trying to understand the macro that generates the equivalent.

Bad analogy. I’m not saying don’t have isKind/createElement. I’m saying have both isKind and the convenience methods is* (createDiv, createSpan etc.).

I can live with that. I took your reaction as "yeah, it's possible but not necessary".
But still:

To my mind it only makes sense to reach for the power of macros if you want to introduce new syntax

The plan is to introduce a new operator, although that's not yet possible.

all 15 of them

That's 45 functions across 3 modules.

in the codebase is much more readable than trying to understand the macro that generates the equivalent.

When pattern-based macros land, this should no longer be the case. For now, we can just add an example in the comments.

Simple mapping of the syntax types, no macros involved.

So I think the key utility you identified is the isKind("somekind", value) method on Syntax and SyntaxOrTermWrapper. That is definitely valuable for code that needs to dynamically select the kind of syntax it is matching. If you want to update this PR to just add that method on Syntax/SyntaxOrTermWrapper (while leaving the existing is* methods intact) I would be willing to accept it. Let’s defer changes to Enforester to a separate issue/PR discussion.

Oh cool! Didn't see you updated this PR. You need to add a comment when changes are made otherwise I don't get notified :)
I'll try to review soon.

Can you rebase and squash?

You should be able to squash this PR from the web UI, see https://help.github.com/articles/configuring-pull-request-merge-squashing/.


Update po_organization.sql

Update po_organization to fix data types and to add more extracted data fields.
The runlist.txt file already includes the po_organization file, so this does not need to be added.

Closes Issue #841


Markdown

Goal
We need to add markdown support for the contribution description and impact description.

Task

[x] Add support for writing markdown
[x] modify the markdown component to follow brand guideline
[x] Modify the project page to show the markdown properly
[x] Remove any restriction on description size

Bonus
Un-uglify it :))

sp:3


Issue with Key Up Key Down events in test application

Summary
In the test application "WpfApplication.exe" in the "Keyboard Controls" tab,
the Keyboard Down Events label does not work for some keys. E.g. Arrow Keys
(The Keyboard Up Events work)
Steps to reproduce

Go to the "Keyboard Controls" tab in the test application "WpfApplication.exe"
Select input field
Type keys: A, B, C
observe Keyboard Down Events label and Keyboard Up Events label
Type the arrow keys on the keyboad: Left, Right, Up, Down
observe Keyboard Down Events label and Keyboard Up Events label

The Keyboard Up Events displays everything correctly for me.
Did anyone else experience this behavior?
I wrote a test case to check the behavior.
I used the latest release 3.0.0

@GeoGegl
Thanks for you PR i think this shows the issue here in detail. Yes Issue 67 was about unity that keyboard events was not triggered.
We only send all command to FlaUI C# Keyboard implementation. I will recheck if any bug on robotframework wrapper side is made.
From issue 67 the last information was that the Keyboard implemention from FlaUI has to be adjusted probably a fix is done because i not recheck the library changes.

[ ] Recheck Robotframework-FlaUI if any wrong data is send to FlaUI Keyboard
[ ] Recheck FlaUI if a bugfix exists by Keyboard usage

i have retested WPFtestapp manually with the keyboard it seems the app itself has some issues.
The down button is not showing the arrows even when i am typing with keyboard manually.
I suggest also that we look for the source code of the test app

Reproductions steps are.
Open WpfApplication.exe
Go to keyboard Controls tab
Press and release 'a': everythin works fine
Press and release 'down arrow': still works fine
Press and release 'up arrow': the keyboard up event showing fine but keyboard down is not showing.

After verification and mentioned noubars text. OnKeyDown event is only triggered once by key operations.

@GeoGegl  Can you pls take changes from branch bugfix/#152
I adjusted the wpf test application to handle events correctly. But i see in your test case that the expected input by release_only is wrong by your test case pls adjust them.

Thanks a lot! I'll work on it ASAP

I updated to ignore case in the key up / down test case.
And I also did a change on the WPF application.
I took over your PreviewKeyDown / Up entries but changed the behvior of
displaying the events in the WPF application.
As I'm new to github I'm not sure: Can you see my changes in the pull request?
What do you think about the changed event displaying?
My intention was to display all key down events until the keys are released.
And to display all key up events when they occur until no key is held down anymore -
only then a new list of key up events is displayed.
-> My test case does not cover all of that - but I guess it should be added in future

I think you have done it very well
Make the small changes @Nepitwin has asked in PR review.
Then we can merge into the main
My concern is though this press_only or up_only feature currently works only with keys starting with s'SOMEKEY' but not with text t'SOMETEXT'. And there is no code implemented to prevent it. As example error message saying you cannot use press_only or up_only feature with text.

Thanks for your input. I added the check and error message for text pattern and updated the changelog.


test(client): happy blog-env test has no assertion

This test has no assertion. adding "expect.assertions(1)" at the beginning makes the test fail.
https://github.com/prisma/prisma/blob/main/packages/client/src/__tests__/integration/happy/blog-env/test.ts
On first look, it looks like it's trying to test PrismaClientInitializationError but the code never errors.
We should check and properly test PrismaClientInitializationError
Context https://prisma-company.slack.com/archives/C016KUHB1R6/p1616400507047100

it is hard to tell what this test is testing, however, here I have added my best guess and ported the test to the new functional style https://github.com/prisma/prisma/pull/13657


[DDW-500] Implement design for native tokens

This PR implements design for native tokens.
Design:
https://zpl.io/VDeA6BJ - multi-send
https://zpl.io/VxEwEPR - multi-send confirmation dialog
https://zpl.io/bAr9Roe - wallet with tokens
https://zpl.io/VQlz9XP - tx details
Todos

[x] Summary screen - loading state for the asset section
[x] Summary screen - always show ADA as the first asset in the assets section
[x] Receive screen - keep left and right paddings aligned with the existing screens (should be reduced)
[x] Assets should be renamed to Tokens everywhere
[x] Finalize multi-send dialog
[x] Finalize multi-send confirmation dialog
[x] Add translations

UI issues document:
https://docs.google.com/document/d/1R5lhnDGMIT6JguzGc0fiYTPDv4QiNTm4hSjMFIyab8w/edit
Screenshots

Testing Checklist

Slack QA thread
[ ] Test

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DeeJayElly please merge latest develop...

@alexander-rukin please test this one and update the report document (please add the link to it to the PR description).


cloud: support azure blob storage as external storage backend

Feature Request
Is your feature request related to a problem? Please describe:

The current cloud external storage backend doesn't support azure blob storage.
Describe the feature you'd like:

support azure blob storage so that we can backup/restore data to/from it.
Describe alternatives you've considered:

implement the external storage backend interface for azure blob storage
Teachability, Documentation, Adoption, Migration Strategy:

/feature feature

/feature developing


wasmtime-wasi-http includes absolute URI in HTTP requests

Thanks for filing a bug report! Please fill out the TODOs below.
Note: if you want to report a security issue, please read our security policy!
Steps to Reproduce
The default outgoing handler inserts the URI as-is into the request in absolute form which should only be used for proxies. It seems we can fix this fairly easily by stripping out the other parts from the uri in here https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-http/src/types.rs#L142
+    // remove the scheme and authority from the request
+    *request.uri_mut() = Uri::builder()
+        .path_and_query(
+            request
+                .uri()
+                .path_and_query()
+                .map(|p| p.as_str())
+                .unwrap_or("/"),
+        )
+        .build()
+        .expect("ok");

Otherwise, the absolute form uri will be used as-is, as described here https://github.com/hyperium/hyper/blob/master/src/client/conn/http1.rs#L175-L190.
Expected Results
I expect the http handler not to serialize requests using the absolute uri, since the support for this format is spotty (and potentially goes against the RFC)
Actual Results
The absolute form of the uri ends up in the http packet.
Versions and Environment
Version: Git master + hyper 1.1.0
Operating system: N/A
Architecture: N/A
Extra Info
N/A

Thanks - can you send a PR with the fix you outlined above?

PR here https://github.com/bytecodealliance/wasmtime/pull/7747 waiting on CI. I have an issue where it complains about missing witx running locally so if there are test failures I will update them


[Help] @react-pdf_renderer bug

Hi! In my App I have bug with  @react-pdf_renderer ,
when I generete pdf document
This bug only on Vite? When I use Webpack I didn't have this bug
If  some have any Ideas? please help me.
 @react-pdf_renderer.js?v=840c88b4:104898 RuntimeError: Aborted(CompileError: WebAssembly.instantiate(): Refused to compile or instantiate WebAssembly module because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' 'unsafe-inline'"). Build with -sASSERTIONS for more info.
at x (@react-pdf_renderer.js?v=840c88b4:11665:16)
at @react-pdf_renderer.js?v=840c88b4:12828:15

/////

@react-pdf_renderer.js?v=840c88b4:11663 Aborted(CompileError: WebAssembly.instantiate(): Refused to compile or instantiate
WebAssembly module because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive:
"script-src 'self' 'unsafe-inline'")

/////
@react-pdf_renderer.js?v=840c88b4:12827 failed to asynchronously prepare wasm: CompileError: WebAssembly.instantiate(): Refused
 to compile or instantiate WebAssembly module because 'unsafe-eval' is not an allowed source of script in the following Content
 Security Policy directive: "script-src 'self' 'unsafe-inline'"

Looks like the CSP protection.
Probably  you will need to change your index.html and add the CSP meta tag.
Example:
    <meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline' 'unsafe-eval';">

Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.3 to before v4.9.272",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d646960f7986fefb460a2b062d5ccc8ccfeacc3a",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=39c15bd2e5d11bcf7f4c3dba2aad9e1e110a5d94"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "d646960f7986fefb460a2b062d5ccc8ccfeacc3a",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "39c15bd2e5d11bcf7f4c3dba2aad9e1e110a5d94",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "nfc: fix NULL ptr dereference in llcp_sock_getname() after failed connect\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.272 by commit 39c15bd2e5d11bcf7f4c3dba2aad9e1e110a5d94, it was introduced in version v3.3 by commit d646960f7986fefb460a2b062d5ccc8ccfeacc3a. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000726


feat(moe): set epsize by config

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Users may want to set ep_size from the configuration file, for example, megablock dmoe requires ep_size to be 1.
Modification

internlm/core/context/parallel_context.py: set ep_size from config and run some check
internlm/model/moe/megablock/megablock_moe.py: reinit num_local_experts to fix bugs

BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

LGTM


[k8s] Custom Labels for Agent Pools

I need to assign custom labels to nodes in agent pools.  I think if something similar to how #138 was implemented for DCOS was ported for use in k8s, that would be a very flexible solution.  It would also cover #139.

This is a duplicate of https://github.com/Azure/acs-engine/issues/139.  I updated the title to make this more clear