[Bug][Java client] main thread won't exit if not close pulsar client

Search before asking

[X] I searched in the issues and found nothing similar.

Version
macOS 12.5.1
Pulsar 2.10.1
Pulsar Java client 2.10.1
Minimal reproduce step
Run this snippet:
public class Main {
    public static void main(String[] args) throws PulsarClientException {
        PulsarClient client = PulsarClient.builder()
                .serviceUrl("pulsar://localhost:6650")
                .build();

        System.out.println("hello world"); // print successfully
        // without client.close(), `main` will be hanging, never exit
    }
}

What did you expect to see?
Print hello world then exit normally.
What did you see instead?
Print hello world but never exit.
Anything else?
I know I should always close the client manually. But if I don't close it, is hanging to be the expected behavior?
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

We (+ @yaalsn) discuss this, seems that netty has a shutdown hook to prevent client exit.

@labuladong if you close the Pulsar client (client.close()) the process exits?

We (+ @yaalsn) discuss this, seems that netty has a shutdown hook to prevent client exit.

Live non-daemon threads are a common reason why normal shutdown doesn't happen in a Java application.
The javadoc of java.lang.Thread:

When a Java Virtual Machine starts up, there is usually a single non-daemon thread (which typically calls the method named main of some designated class). The Java Virtual Machine continues to execute threads until either of the following occurs:

The exit method of class Runtime has been called and the security manager has permitted the exit operation to take place.
All threads that are not daemon threads have died, either by returning from the call to the run method or by throwing an exception that propagates beyond the run method.

I believe that Pulsar client creates threads that are non-daemon threads. This might be intentional.
I assume that it's better to handle the shutdown in a controlled way in any case.
A simple fix to your problem is to add a shutdown hook that calls client.close().
@labuladong What is your actual use case? Could you share more of the scenario that you have in mind?

@labuladong if you close the Pulsar client (client.close()) the process exits?

Yes, it will.

@lhotari Hi, I'm just curious about how to exit even if missing client.close(). Now I figured it out from your answer. Thanks a lot!


1.13 cs4 link is broken

File: cs-engine/1.13/release-notes.md, CC @joaofnfernandes
I don't think 17.03.2 release actually happened (yet?)
cc/ @cpuguy83

That's correct.

Working now! :)


this.props. "ActionCreator" failed: Cannot read property "ActionCreator" of undefined

I am building and testing my redux project, but I encounter a problem which I cannot solve:
I have a Container - PostList (which is used to show posts), and in the PostList I have a Component: SimplePage, which is to show the pagination info of the posts list.
And in the SimplePage component, I can click on the page number and it will Dispatch a Action that is to load the posts list of that specific page. I pass in a function, "jumpToPage()", from PostList into the SimplePage for it to dispatch the action.
The code is as below:
PostList:
import React, { Component } from 'react'
import { load } from '../reducers/post'
import { connect } from 'react-redux'
import SimplePage from '../components/SimplePage'
import Explore from '../components/Explore'

class PostList extends Component {

  renderPost (item) {
    return (

 {item.title}

    )
  }

  jumpToPage (page_num) {
    console.log('hello, jumping page')
    this.props.load(page_num)
  }

  render() {

    const {loaded, pages, page, items, load} = this.props;

    return (

I am PostList

{loaded ? 'Loaded.' : 'Not Loaded Yet.' }

{ items.map(this.renderPost)}

        <SimplePage
          toPageFromParent = {this.jumpToPage}
          pages = {pages}
          page = {page} />

    )
  }
}

function mapStateToProps(state, ownProps) {
  const {
    post: { loaded, pages, page, items },
  } = state

  return {
    loaded,
    pages,
    page,
    items,
  }
}

export default connect(mapStateToProps, {load})(PostList)

SimplePage:
import React, { Component } from 'react'
import Class from "classnames"
import {Range} from "immutable"

class simplePage extends Component {

  ToPage(event, page_num) {
    event.preventDefault();
    this.props.toPageFromParent(page_num);
  }

  render() {
    const { pages, page } = this.props;

    return (

I am Simple Page Component

               this.ToPage(event, page - 1)}
                title={`To Previous Page`}>
                «

        ...

"load" is the action creator. Now when I click on the pagination, the "jumpToPage" is indeed executed, but I got the error ------ "Uncaught TypeError: Cannot read property 'load' of undefined".
I don't know why and I want help.
(
However, if I modify the code in PostList simply to:
 toPageFromParent = { load(page_num) }

It worked, but I think this is a ugly way to write the code, and I want to pass a function into the pagination component. Actually I learnt the above code style from the popular "erikras/react-redux-universal-hot-example" project, but here it does not work, and I do not know why. : (
As to my understanding, I already connect my ActionCreator ("load") the PostList. But in the "jumpToPage" function, it says  this.props.load(page_num) "Uncaught TypeError: Cannot read property 'load' of undefined".
)
Thanks!

"load" is the action creator. Now when I click on the pagination, the "jumpToPage" is indeed executed, but I got the error ------ "Uncaught TypeError: Cannot read property 'load' of undefined".

The jumpToPage method is not auto-bound to the class, so when passed down into the SimplePage component, "this" is now the global object, so this.props is now undefined which causes the error cannot read property 'load' of undefined. You'll need to bind the method in the constructor:
constructor() {
  super(...arguments)
  this.jumpToPage = this.jumpToPage.bind(this)
}

or better, just use the load prop directly with:
<SimplePage
  toPageFromParent = {this.props.load}
  pages = {pages}
  page = {page} />

@tgriesser  Thanks a lot, seems it is a common JavaScript gotcha, and I have to learn more about JS :100:   ^_^.  Thank you a lot for your help!

Sure thing!


Repo name is misspelled: Pacakage :)

@ericstj

Are you stalking me?  Thanks for the issue.

I follow


Use vendored LLVM in Dockerfile

From #3140:

@mfelsche: ponyc in the Dockerfile is built using the release llvm from releases.llvm.org.
We should switch to using vendored llvm there too.

Currently, the dockerfile is used to build on docker hub. Will we run into timeouts building LLVM there? That might take a long time.

Some discussion of their build limits: https://stackoverflow.com/a/34588866

Some things beyond timeouts:
1- we do a new build for every commit. is building LLVM every time an issue for that?

I don't think we can build on docker hub given the resource constraints that Joe posted.

If we verify our build-strategy is cache-friendly, it can alleviate some of those issues, but not completely.

I'm going to do this as part of getting us started using Github Actions.

This is in progress.

This is currently blocked. When GitHub Actions leaves beta in Mid-November, then I think I can send a webhook trigger from Cloudsmith when new packages are uploaded to trigger a new image build in GH. At the moment, I can't because GH Actions beta requires multiple headers in order to trigger and currently with Cloudsmith we can only set 1. I think post beta that a single header is all we will need. Will find out then.


Add subscriptions for connection opened and connection closed.

I believe this would solve #10
There are a number of reasons we would want to know when a connection is established or closed:

Provide connection indicator in the UI
Perform websocket specific authentication

Hypothetical not-well-vetted API:
type RetryInfo
     = NoRetry     -- Will not attempt to re-establish the connection
     | RetryIn Int -- Will attempt to re-establish the connection in the specified number of seconds

type alias ConnectionClosedHandler msg
    = String    -- Connection URI
   -> Int       -- CloseEvent code
   -> RetryInfo -- Retry information
   -> msg

connectionClosed : ConnectionClosedHandler -> Sub msg

connectionOpened : (String -> msg) -> Sub msg

I wouldn't mind taking a stab at implementing this, assuming I can get some feedback on the proposed API.

Another reason to have this is if you have a high-level protocol, i.e. app-specific protocol, that's stateful over a websocket, having the websocket reconnect and send queued items is NOT advantageous.
I think a simple solution would be to implement the following:

Send a message when a connection is LOST and when it's REESTABLISHED
Don't auto-send queued messages after a REESTABLISH
Add API functions to start sending queued messages AND to clear queued messages

This solution does complicate the trivial cases, so here are some possible options for that:

Make Auto-send an option that defaults TRUE when the websocket is established
Make LOST and REESTABLISHED something that the app must subscribe to, e.g. subscribe to connections status

This would make the trivial case trivial again and the complex case would have only 2 extra steps to be able to re-authenticate or re-establish some higher-level protocol state, e.g. stateful connection. And the extra API calls would be used by the complex cases (only 1 out of the 2 per case).

One thing I'd like to add regarding the possibility of having queued messages while the connection was down, and which accumulated during reconnect.
It's a possible case that the protocol in the server expects a certain handshake as the first message. For example passing the authentication credentials in the first message, or at least a simple "subscribe" message in certain cases.
At such cases I'd expect the queued messages to be sent only after the predefined handshake message.
Can I expect something like this to be implemented in the library, or should I resort to the Lowlevel api?

Is 2017 the year of the Elm Websocket? Seriously, this core lib needs some attention.

I wrote my own: https://github.com/panosoft/elm-websocket-browser.
Also a server version: https://github.com/panosoft/elm-websocket-server.

Thank you, but the problem in my case is other libraries that make use of elm-websocket.

Having coded https://github.com/orus-io/elm-nats, I think this feature would be super useful (especially, in my case, disconnection detection and not to auto-send queued messages).


Playerjs for videojs via embedly

I'm using the current videojs adapter to add playerjs functionality to our player. Everything works fine when using the player directly but it does not work when used via embedly here is a sample url that works
http://playerjs.io/test.html?url=http%3A%2F%2Fwww.slideshare.net%2Fslideshow%2Fembed_code%2Fkey%2FIx0GLB4uRp7atO
but the same video when used via embely does not pass all tests
http://playerjs.io/test.html?url=http%3A%2F%2Fcdn.embedly.com%2Fwidgets%2Fmedia.html%3Fsrc%3Dhttps%253A%252F%252Fwww.slideshare.net%252Fslideshow%252Fembed_code%252Fkey%252FIx0GLB4uRp7atO%26url%3Dhttp%253A%252F%252Fwww.slideshare.net%252Fslideshow%252Fembed_code%252Fkey%252FIx0GLB4uRp7atO%253Fconviva%253Dstaging%26image%3Dhttp%253A%252F%252Fcdn.slidesharecdn.com%252Fss_thumbnails%252F160303buildinghighperformanceteams-160324195034-lva1-app6892-video-thumbnail.jpg%253Fcb%253D1458849576%26key%3Dinternal%26type%3Dtext%252Fhtml%26schema%3Dslideshare
Is there something special I would need to do in the embedly case?
Here's the code that I use to initialize the videojs adapter
    const videojsPlayer = videojs(...);
    videojsPlayer.ready(() => {
      const playerjs = new playerjs.VideoJSAdapter(videojsPlayer);
      playerjs.ready();
    });

Hi @gabesoft, Can you shoot an email to<EMAIL_ADDRESS>This is an Embedly specific question.

Thanks


Publishing Blazor Web Assembly app to Azure = 404 not found

Describe the bug
When publishing from dotnet cli, a spurious web.config is created in the root folder which causes 404s if deployed to Azure.
To Reproduce
Steps to reproduce the behavior:

In Visual Studio create new Blazor app - selected Blazor Webassembly App (if you publish this via Visual Studio to Azure this will work)
Drop to CLI and run: "dotnet publish -c Release myApp"
Alternatively, use dotnet publish within Github Actions eg:

    - name: dotnet publish
          run: dotnet publish -c Release -o myApp

Check the myapp folder and you'll notice a web.config file has appeared.  If you are running the above command in your build pipeline ie. Github Actions (azure/webapps-deploy@v1) this web.config then gets deployed to the azure web app - which will case 404 errors

Expected behavior
dotnet publish should create correct web.config output
Workaround
My workaround has been to create a web.config within the Blazor Client application with the following contents, which prevents dotnet publish from creating it's own corrupt one.  If this is added to source control, then Github Actions - Azure/Webapps deployment will deploy this version and will work.
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <location path="." inheritInChildApplications="false">
    <system.webServer>
      <handlers>
        <add name="aspNetCore" path="*" verb="*" modules="AspNetCoreModuleV2" resourceType="Unspecified" />
      </handlers>
      <aspNetCore processPath="dotnet" arguments=".\myApp.Server.dll" stdoutLogEnabled="false" stdoutLogFile="\\?\%home%\LogFiles\stdout" hostingModel="inprocess" />
    </system.webServer>
  </location>
</configuration>

)

We're closing this issue as we plan to reimplement publishing for Blazor WASM.


Clean up redundant re-exports

Symbols are often accessible from a large number of modules.
Example Vector3 (a manually declared type):

Example Node (a GDNative auto-generated type):

This is confusing as to which symbol is "the right one" and adds redundancy without benefit. It can also make auto-complete in IDEs harder to use and leads to inconsistent use statements.
Goals:

For each symbol, work out one canonical module (e.g. Vector3 -> core_types or core_types::geom)
Remove all non-canonical, non-prelude modules, in particular:

Ones existing only due to file structure, as in gdnative::api::node::Node
Nested ones inside prelude

Review prelude (possibly out of scope)

This may break use statements in client code and will thus target v0.10.

@Bromeon I'll look into working on this change.


Update PerfRunData.cs

Make CreateDirectory method virtual so that derived classes can provide their own Directory implementation, allowing for benchmarking of custom Directory providers (e.q LiteDB)

Fine by me.
approved.

@shadowcaptain
Thanks for the PR. For future reference, please indicate where and why we have diverged from Lucene 4.8.0's API by leaving a comment prefixed with // LUCENENET specific -.


new ci config

migrated from https://github.com/impactMarket/mobile-app/pull/28

@Jonathansoufer I'll merge this. Not fully working, we need to get back to this one.


mdns_instance_name question

How can get mdns_instance_name from port.c to main.c ?

It's not part of public API.


Can't export items from @testmodule modules

It would be very useful to export items from a @testmodule, but that appears not to be possible right now, correct?
I have the following in a file called test/test_test.jl:
@testmodule TestHelpers begin
    f(x, y) = x + y
    export f
end

@testitem "Test the tests" setup = [TestHelpers] begin
    # Try the exported function
    try
        f(1, 2) == 3
    catch e
        println("Error f(1, 2): ", e)
    end

    # Manually export it
    f = TestHelpers.f
    @test f(1, 2) == 3
end

When I run that from the VS Code testing pane, I get this output:
Error f(1, 2): UndefVarError(:f)
Test Summary:                        | Pass  Total  Time
.../test/test_test.jl:Test the tests |    1      1  0.0s

Is there some other technique besides this hacky workaround that I might have missed?
I'm using TestItemRunner v1.0.5 and VS Code 1.95.1.  Thanks.

Yes, agreed.
At the moment the modules that are listed in the setup section are imported into the test item module, but I think we should change that to using instead, and then your scenario should work.
Technically that is a breaking change, but given how new all of this is I think we can just do that.

Yeah, that sounds good to me.  After all, for a @testmodule, if someone doesn't want stuff exported, they can just not export it.  Thanks.


Fix batch ackset recycled multiple times.

Fixes #7384
Motivation
Fix batch ackset recycled multiple times. The root cause is a race condition in group ack flush and cumulative Ack. So add recycled state check for the ackset.
Verifying this change
New unit test added.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Reproducing ZINC result with v2

Hi,
First, thanks for the code.
I tried to reproduce the result of ZINC subset with graphormer v2 code, but my best validation loss was 0.178 with parameters in the given script with test loss 0.164, and 0.186 with parameters in the paper with test loss 0.157.

Will look into it.

Do you have any update?

Do you have any update?

Same here. I used the given scripts on ZINC subset, then got an best validation loss 0.1750 and corresponding test MAE 0.1406.

Same here. I'm sure I used the original code and there is no problem with the environment configuration. However, the test MAE result I reproduced on the ZINC subset is 0.178.

Same here :(


Enhance fhir-bucket README to cover all usage options

The fhir-bucket Main app has expanded to cover a lot of use-cases. The README needs to be updated to properly describe each option.

usage options will change with #1640


Update for extension XLFs

Recently I discovered that the XLFs in the resources folder are out of date and no longer function properly with the most recent builds of ADS, this is a refresh of the XLFs in the folder (created using the vscode-translations-export tool and modified to fix irregularities) to be translated by the loc team.

Pull Request Test Coverage Report for Build 640828162

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.001%) to 43.178%

Files with Coverage Reduction
New Missed Lines
%

extensions/import/src/wizard/pages/fileConfigPage.ts
1
73.46%

Totals

Change from base Build 640625869:
0.001%

Covered Lines:
25298

Relevant Lines:
53436

💛  - Coveralls


fix(types): adding alias for the data and gas in the initial tx

This PR adds the aliases for the data and gas for the backward compatibility.

Closing this as not relevant to the solution.


i18n: fix interslavic translation

Trivial fix, please look. 🙏

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 29.582%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1318

Relevant Lines:
5445

💛  - Coveralls


Correct issues with package.json

gulp-ga is not listed in the package dependencies but it is required to run the gulp tasks. I also added the name and version because they were missing. Assumed version 1.0.0 since this is a fork of an already in-production project.

Nice @dsbert, thanks! Not a very experienced gulp user, so I appreciate it.


uncommitted tag messes with remote builds

It's not at all obvious that if you have uncommitted changes while waiting several minutes for the build to finish (which is pretty likely), then Kamal will tag the build with a random string in configuration.rb:
          [ Kamal::Git.revision, Kamal::Git.uncommitted_changes.present? ? "_uncommitted_#{SecureRandom.hex(8)}" : "" ].join

I have no idea what this achieves - perhaps something to help with CI - but it makes deployment more painful because it means I either have to dev in a separate repo on my own machine, or down tools while Kamal does its thing. Otherwise, the delivered build has a tag that kamal deploy -P can't find (it generates another new unique tag).
I would suggest making this a configurable option, starting with defaulting to the current behaviour (so as not to break people's builds) with clear documentation about turning this off unless you need it, and eventually making the default what will be helpful for most people who are setting up Kamal (assuming most people don't need these tags).

Added a pull request... not sure if this should have been done here instead. Apologies if so.
https://github.com/basecamp/kamal/pull/776
If you want to use that functionality in the meantime you can use the fork at https://github.com/swombat/kamal . See the pull request for simple example of how to use this feature.

@swombat please take a look at https://github.com/basecamp/kamal/pull/700 if this fixes your issue

@morgoth Yes, actually that would fix my issue! The point is to make it not default to creating remote builds that can't be accessed, and your solution achieves that.

@swombat can you close the issue then?


TopNQuery

Hi, TopNQuery can't return PostAggregator's result, it only returns aggregator's result! is it a bug?

Hi, that does not sound right. Can you please post the query that you are doing?


Hotfix: Safari CI test

Safari has less unusable space so it appears at a relative lower space
Safari windows have different "usable" spaces. So we need to account for that in our sticky test.

Fair point. So we scroll to the bottom of a 1280 window. And they appear at the top.


Traccar Service stops early after initializing

Hi there!
The traccar service stops early during initialization.
Seems there is a binding issue.
I think I has this problem befor, but I cannot find my old issues..
Below is the log.
What bindings are causing trouble?
How do I un-bind?
Thanks,
Eric
INFO|3816/0|Service traccar|17-07-17 16:13:54|Caused by: org.jboss.netty.channel.ChannelException: Failed to bind to: <IP_ADDRESS>/<IP_ADDRESS>:5001
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.bootstrap.ServerBootstrap.bind(ServerBootstrap.java:272)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.traccar.TrackerServer.start(TrackerServer.java:117)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.traccar.ServerManager.start(ServerManager.java:81)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.traccar.Main.main(Main.java:38)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	... 6 more
INFO|3816/0|Service traccar|17-07-17 16:13:54|Caused by: java.net.BindException: Address already in use: bind
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at sun.nio.ch.Net.bind0(Native Method)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at sun.nio.ch.Net.bind(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at sun.nio.ch.Net.bind(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at sun.nio.ch.ServerSocketChannelImpl.bind(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at sun.nio.ch.ServerSocketAdaptor.bind(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.channel.socket.nio.NioServerBoss$RegisterTask.run(NioServerBoss.java:193)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.channel.socket.nio.NioServerBoss.run(NioServerBoss.java:42)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
INFO|3816/0|Service traccar|17-07-17 16:13:54|	at java.lang.Thread.run(Unknown Source)
INFO|wrapper|Service traccar|17-07-17 16:13:54|calling onStop

Have you tried searching first? This issue has been discussed many times. You have a port conflict with some other process on you machine.

I wouldn't have started this issue if I had found the answer. There are many posts, true, but of the 15 I read, help resolve the issue I have now. Please give me some pointer.
svchost.exe is the process that uses port 5001, which I suppose is the one causing the issue. Correct me if I'm wrong.
Can I change the port from 5001 to something else in config. If the answer is yes, please thell me what entry of the config file I should use.
Thanks
Eric

How can I confirm something that I don't know? It can be any process on your system.
You can change or remove port in the config file:
https://www.traccar.org/configuration-file/

Because I knew that you would point me to the config file, I explicitly asked you for the entry in which to change the conflict with port 5001 - I still assume that that's the one that is causing the issue, as you didn't point out that y assumption was incorrect. Please be specific.
Thanks,
Eric

I tried changing the ports of the devices in the default xml, but that did not resolve the issue.
So any help is welcome.
Thanks,
Eric

Is the error still the same, including port number?

Yes
On Jul 17, 2017 20:10, "Anton Tananaev"<EMAIL_ADDRESS>wrote:

Is the error still the same, including port number?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/3362#issuecomment-315920418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AViSDxYn-2VGZv4Sf5HZAGYHGKlOMerQks5sO_fvgaJpZM4Oaf2M
.

That is not possible. You must be missing something.

Well unfortunately it is. I changed ports 5001..5050 to 5201..5250 and killed the prosees on port 5001. There is still a process on port 5002, which is now causing the issue, regardles of the chages in port numbers I made.
INFO|4536/0|Service traccar|17-07-17 19:31:43|java.lang.reflect.InvocationTargetException
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at java.lang.reflect.Method.invoke(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.rzo.yajsw.app.WrapperJVMMain.executeMain(WrapperJVMMain.java:60)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.rzo.yajsw.app.WrapperJVMMain.main(WrapperJVMMain.java:43)
INFO|4536/0|Service traccar|17-07-17 19:31:43|Caused by: org.jboss.netty.channel.ChannelException: Failed to bind to: <IP_ADDRESS>/<IP_ADDRESS>:5002
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.bootstrap.ServerBootstrap.bind(ServerBootstrap.java:272)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.traccar.TrackerServer.start(TrackerServer.java:117)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.traccar.ServerManager.start(ServerManager.java:81)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.traccar.Main.main(Main.java:38)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	... 6 more
INFO|4536/0|Service traccar|17-07-17 19:31:43|Caused by: java.net.BindException: Address already in use: bind
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.nio.ch.Net.bind0(Native Method)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.nio.ch.Net.bind(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.nio.ch.Net.bind(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.nio.ch.ServerSocketChannelImpl.bind(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at sun.nio.ch.ServerSocketAdaptor.bind(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.channel.socket.nio.NioServerBoss$RegisterTask.run(NioServerBoss.java:193)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.channel.socket.nio.AbstractNioSelector.processTaskQueue(AbstractNioSelector.java:391)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.channel.socket.nio.NioServerBoss.run(NioServerBoss.java:42)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
INFO|4536/0|Service traccar|17-07-17 19:31:43|	at java.lang.Thread.run(Unknown Source)
INFO|wrapper|Service traccar|17-07-17 19:31:43|calling onStop
INFO|wrapper|Service traccar|17-07-17 19:31:43|Win service stop - timeout: 30000
INFO|wrapper|Service traccar|17-07-17 19:31:43|Win service wrapper.control -> stopping application
INFO|wrapper|Service traccar|17-07-17 19:31:43|Win service stop - after shutdown
INFO|wrapper|Service traccar|17-07-17 19:31:43|Win service stop - before notify
INFO|wrapper|Service traccar|17-07-17 19:31:43|Win service terminated

If you change port from 5002 to something else, you shouldn't have any conflict with that port anymore.
You should not change port 5001 to 5050 because 5050 is already used by Traccar.
If you have so many conflicts, I would recommend to remove all the protocols that you don't need from default.xml config file.


[#2479] refactor: separate API for client using: SupportsMetalakes and SupportsCatalogs

What changes were proposed in this pull request?
Today Gravitino java client and server sides share the same interfaces, like SupportsMetalakes, SupportsCatalogs, SupportsSchemas, etc. These interfaces are good for server side, but not good for client side. After some discussion with Jerry and others, if we want to make it easier to use, and still keep server side code stable, the only way is to separate the APIs: create individual APIs for the java client.
This PR will introduce the simplified API for client: SupportsMetalakes and SupportsCatalogs (in the package com.datastrato.gravitino.client.api). Their method signatures have been changed, so the client code will be clear. The integration tests which uses Java client to manipulate metadata also be updated. (If we don't want to use the same classname, I can refactor them later in a batch)
Why are the changes needed?
To make the client API simple and easy to use.
Fix: #2479
Does this PR introduce any user-facing change?
Will change the Java client API, mainly on the method signatures; for example, "listCatalogs()" won't need an input parameter, "loadCatalog()" will use a String value as the input parameter instead of a NameIdentifier object, etc.
How was this patch tested?
All existing integration test will cover the API change.

Thanks @shaofengshi for the first step of client API refractory, I will spend time reviewing this.


Duplicate entities added after Home Assistant reboot

Hi!
I have an issue with the integration.
When Home Assistant is restarted, the integration adds duplicate entities.
In the entity ID, the duplicated are added with and "_2" tag at the end.
The original entities have status "unavailable".
These entities I have used now in quite some YAML files.

When restarting the integration manually, the original entities are being updated correctly and the duplicated ones show with status "unavailable".

Removing the duplicates does not help. On every Home Assistant reboot the duplicates are placed back.
Also note that the "sensor.control_cc1_flowtemperaturesensor" is always unavailable, however this is minor issue.
Currently running on HA  2023.12.3. However I have had this issue for a couple of months now on several HA versions.
Thanks in advance for your support!

i had this with another integration, i guess the cleanest way is to remove the integration and re-add


FC039 triggers with node['keys']

If you access node['keys'] then foodcritic flags it with:
FC039: Node method cannot be accessed with key

node['keys'] is valid and contains the SSH keys and such and shouldn't be flagged.

Because node['keys'] is where ohai puts them...

Its correct that node['keys'] is a bad key to use because node.keys won't give you what you think.
Same goes for node['ssh']['keys'] which will surprise dot-notation method_missing users who expect node.ssh.keys to give that value.
Any use of method_missing should itself probably be a warning (#371) but if a user types node.keys alone then that may be entirely valid ruby and we can't issue a warning in that case, we have to assume the user really meant to call Chef::Node#keys so can't alert on that.
I don't know what to do about this.  While we can do method_missing access it makes that a bad key to use to access nodes, but ohai itself does it, which should be a bug against ohai, but this is most likely commonly used and not easily changed in ohai.
The real solution is to eliminate method_messing access on the node object because eventually you get backed into a corner like this with no good option to escape.

Since method missing access is now gone, this makes more sense, but in the case of #428 the use of node['role_default'] instead of node.role_default is almost certainly an error.
If it isn't an error, then that is going to be hugely confusing to anyone reading the code without a deep knowledge, since node['chef_environment'] and node.chef_environment are wired up to be the same but those could never be wired up the same, similarly node['run_state'] and node.run_state could never be wired up to be identical but it is probably clear as mud to even moderately experienced chef users why chef_environment is special and run_state and role_default are completely different.
I can see how node.keys is likely so fundamental to the ruby language that there's less chance of confusing that with node['keys'] but its not clear to me where that crosses a line and becomes like 'run_stateorrole_default`.

So TL;DR:

node['chef_environment'] clearly should NOT fire FC039 because we allow that usage and they're wired up to be the same
node['run_state'] and node['role_default'] clearly SHOULD fire FCO39 because that is hugely confusing code
node['keys'] vs. node['keys'] i find to be an ambiguous edge case and IDK

its possible that FC039 should be left as-is but with whitelists for the magical attributes:
https://github.com/chef/chef-rfc/blob/eb1f7da5cc01f54bc6fcfc5bc95c74932a051622/rfc106-chef_env_attribute.md
along with putting node['keys'] in the whitelist because that usage in ohai dates back to 2009.


show fee for btc tx

Codecov Report

Merging #1220 (5969513) into master (1947af8) will decrease coverage by 0.32%.
The diff coverage is n/a.

:exclamation: Current head 5969513 differs from pull request most recent head 2fe41e8. Consider uploading reports for the commit 2fe41e8 to get more accurate results

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   37.17%   36.84%   -0.33%
==========================================
  Files         412      422      +10
  Lines        9537     9439      -98
  Branches     1763     1565     -198
==========================================
- Hits         3545     3478      -67
- Misses       5714     5927     +213
+ Partials      278       34     -244

Impacted Files
Coverage Δ

src/hdpath-preview/types.ts
65.00% <0.00%> (-17.61%)
:arrow_down:

src/components/accounts/Balance/Balance.tsx
80.76% <0.00%> (-15.53%)
:arrow_down:

src/settings/selectors.ts
73.68% <0.00%> (-10.53%)
:arrow_down:

src/components/common/ToggledIconButton/index.tsx
56.25% <0.00%> (-10.42%)
:arrow_down:

src/components/common/Input/Input.tsx
77.41% <0.00%> (-9.68%)
:arrow_down:

.../components/common/AccountSelect/AccountSelect.tsx
83.78% <0.00%> (-8.90%)
:arrow_down:

src/components/common/CoinIcon/CoinAvatar.tsx
58.33% <0.00%> (-8.34%)
:arrow_down:

src/blockchains/reducer.ts
86.66% <0.00%> (-8.08%)
:arrow_down:

src/components/common/ButtonGroup/ButtonGroup.tsx
92.30% <0.00%> (-7.70%)
:arrow_down:

...rc/components/common/IdentityIcon/IdentityIcon.tsx
92.85% <0.00%> (-7.15%)
:arrow_down:

... and 149 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Question] Help structuring imports

Hello, this is more of a question as I have tried multiple ways to get the below structure working. Any tips?
.eslint.js
        "import/order": [
            "error",
            {
                "groups": ["builtin", "external", "internal", "sibling"],
                "pathGroups": [
                    {
                        "pattern": "react",
                        "group": "external",
                        "position": "before"
                    }
                ],
            }
        ],

I would like the below ordering strucutre:
// import anything react related

import React, { useRef, useState } from "react";`

// import third party packages

import _ from "lodash";

// import absolute

import { Component } from "shared/Component";

// import relative

import { utilsFunction } from "./utils";

// import styling

import css from "./Component.module.css";
```

Anyone have any ideas about the above?

Anyone have any ideas about the above?

I think you have already found the solution. But maybe it will be useful for others
'import/order': [
    'error',
    {
      groups: [
        'builtin',
        'external',
        'internal',
        'parent',
        'sibling',
        'index',
        'object',
        'type',
        'unknown',
      ],
      pathGroups: [
        {
          pattern: 'react',
          group: 'builtin',
          position: 'before',
        },
        {
          pattern: 'react**',
          group: 'builtin',
        },
        {
          pattern: '@**/react**',
          group: 'builtin',
        },
        {
          pattern: './**/*.css',
          group: 'sibling',
          position: 'after',
        },
      ],
      pathGroupsExcludedImportTypes: ['react'],
      'newlines-between': 'always',
      alphabetize: {
        order: 'asc',
        caseInsensitive: false,
      },
    },
  ],


User wants more examples on device tags

Based on user feedback

Note that we already have some examples by @thgreasi at https://github.com/resin-io-playground/device-tags

@thgreasi Already covering the balena-io-examples here. We will list them all on one page  #1608

that's great @vipulgupta2048 :+1:


New action request: everlytic/branch-merge

Action name
uses: everlytic/branch-merge
Reasons
No response
Intended usage
No response
I have checked the internal marketplace for similar actions and couldn't find one that works for us.

[X] I have checked the internal marketplace first

:robot: Found these results:

Check
Results
Links

CodeQL on the forked repo
:white_check_mark:
CodeQL run

Security scan:

Check
Result

No Dependabot configuration found
⛔

No CodeQL Init found
⛔

No CodeQL Analyze found
⛔

:robot: Check completed with result: ✅
Found 1 Dependabot security vulnerabilities:
1 where high and 0 where moderate.
Use this link to verify the alerts.


Google Map features

I just added a Google Map in my portfolio #14. There are many things we can do with this map. Here are some ideas:

center the map based on where the user is
add markers showing things like who has visited my website (connect with Google Analytics API and update real time?) and places that I've been to/want to travel to (could be hardcoded to start with)
add info windows

#14 addresses 1. a marker and a "You are here" infowindow tells user where they are. The map is also centered aroudn there.

Need to error handle when users don't have location service enabled.

Need to error handle when users don't have location service enabled.

Fixed in PR #14


handling undefined paths is broken

Description
The site should handle all possible paths and redirect those that are undefined, and therefore not expected, to a generic error 404 page.
how to reproduce
1 - go to https://wallet.telos.net/foo
2 - the site shows a blank page

resolved


9.1.1版本 v-for="item in enquirySwipers" :key="item.inquiryId" 会报 "Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive" 的错误，在9.1.0版本就正常

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I'm using eslint-plugin-vue.
[X] I'm sure the problem is a parser problem. (If you are not sure, search for the issue in eslint-plugin-vue repo and open the issue in eslint-plugin-vue repo if there is no solution.
[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.33.0
What version of eslint-plugin-vue and  vue-eslint-parser are you using?

<EMAIL_ADDRESS><EMAIL_ADDRESS>
What did you do?

Configuration
<!-- Paste your configuration here -->

<swiper-slide
  v-for="item in enquirySwipers"
  :key="item.inquiryId"
>
  <div class="item-container">
    <img :src="item.inquiryImgUrl" alt="" />
  </div>
</swiper-slide>

What did you expect to happen?
没有 vue/valid-v-for 的报错
What actually happened?
eslint报错：Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive.eslintvue/valid-v-for
Link to Minimal Reproducible Example
null
Additional comments
No response

I don't know what kind of problem you have, but at least it doesn't seem to be a parser problem.

目前9.3.1版本都有这个问题，楼主怎么解决的？


Add Reader::Config::globalChromatogramsAreMs1Only (#798 on master)

added Reader::Config::globalChromatogramsAreMs1Only to satisfy Skyline's requirement of getting TIC chromatograms from only MS1 spectra
added TestFilesDir.GetVendorTestData()
changed TestTicChromatogram() to use vendor reader test data (too many of the existing test files had no MS1s, e.g. MRM data)
tweaked VendorReaderTestHarness for some more convenient functionality
added a version of GetProjectDirectory() that doesn't extend TestContext because it doesn't actually use TestContext anyway
fixed GetProjectDirectory() for Docker container context (TestRunner running from c:/pwiz/skyline while test data is in the checked out git repository in /pwiz_tools/Skyline)
added pwiz vendor reader test data to SkylineTester.zip, and fixed GetVendorTestData() to work with either location (which I tested manually with SkylineTester)
fixed Reader_ABI_Test.data files being deleted by clean.sh

@brendanx67 GitHub tip: in the files changed tab, hold alt and click on one of the file headers to minimize all files. That way you can easily see the changed filenames and only look at the Skyline ones you're interested in reviewing.


darksky: Fetch summary for daily forecasts

Description:
Dark Sky service provides a summary for each forecast day. This (very simple) change will introduce a new entity sensor.dark_sky_summary_<day> for each corresponding day listed in forecast parameter.
Example entry for configuration.yaml:
- platform: darksky
  forecast:
    - 1
  monitored_conditions:
    - summary

Checklist:

[X] The code change is tested and works locally.

What do you mean by that?
Dark Sky returns weekly summary in daily forecast, as well as daily summary for each day:
{
    "daily": {
        "summary": "Week summary",
        "data": [{
            "summary": "Day summary"
        }],
    }
}

The former was exposed by Home Assistant, the latter wasn't. This change exposes it. If you specify:
- platform: darksky
  forecast:
    - 1
    - 4
  monitored_conditions:
    - summary

you will get the following entities: sensor.dark_sky_summary (week summary), sensor.dark_sky_summary_1 (summary for day 1), and sensor.dark_sky_summary_4 (summary for day 4).

Thats the idea, but do you see it wokring like that?

I'm pretty sure it does. I'll check tomorrow and let you know.

I've checked today. With:
- platform: darksky
  forecast:
    - 4
  monitored_conditions:
    - summary

you'll get sensor.dark_sky_summary_4 with the summary of day 4.

Still seems like you are (accidentally?) fixing something that was introduced earlier (#5264).
Would be good to hear from someone using this functionality... I see @fabaff is code owner, maybe he has a better idea of what is happening here

I feel like we're having a misunderstanding. There was and still is (see https://darksky.net/dev/docs#/dev/docs#response-format):

minutely_summary, a "human-readable summary of this data block" for the next hour. Extracted from minutely.summary property in JSON.
hourly_summary, a "human-readable summary of this data block" for the next two days. Extracted from hourly.summary property in JSON.
daily_summary, a "human-readable summary of this data block" for the next week. Extracted from daily.summary property in JSON.
summary, which is a "human-readable text summary of this data point" for day 0 (today). Extracted from daily.data[0].summary property in JSON.

However, there was no way to get a "human-readable text summary of this data point" for days 1 to 7, while other properties of these days (like temperature, humidity, wind, etc.) were available. My change makes it possible to also get a summary.

Thx, clear now and I retested with some results. Maybe you can try to clarify in the official docs?


build error: libmultik_jni-linuxX64.so is not an ABI even though I'm not building for that target

Hi, I'm currently hitting this error when trying to build my Android app (for an arm64 emulator) on macOS:
Cause: multik-openblas-jvm-0.2.3 extracted from path ~/.gradle/caches/8.9/transforms/4d3515c442b573850b7bc131f7841f9c/transformed/multik-openblas-jvm-0.2.3/linuxX64/libmultik_jni-linuxX64.so is not an ABI

That file exists (as does the libmultik_jni-androidArm64.so version it seems is actually relevant) but I'm not building on Linux nor do I define linuxX64 anywhere in my config.
I can build and run my commonTest test cases which indirectly depend upon multik-core and multik-default.
I've got the following in my build.gradle.kts:
kotlin {
    androidTarget {
        publishAllLibraryVariants()
    }

    iosArm64 {
        config("iphoneos")
    }
    iosSimulatorArm64 {
        config("iphonesimulator")
    }

    sourceSets {
        commonMain.dependencies {
            ...
            implementation("org.jetbrains.kotlinx:multik-core:0.2.3")
            implementation("org.jetbrains.kotlinx:multik-default:0.2.3")
        }

        commonTest.dependencies {
            implementation(libs.kotlin.test)
        }

        androidMain.dependencies {
            ...
        }

        iosMain.dependencies {
            ...
        }
    }
    ...
}

Do I have a mistake in my build.gradle.kts? Can I / do I need to somehow explicitly exclude linuxX64 or that .so file?
Thanks!

After a lot of effort and asking around on the Kotlin Slack, I finally pieced together a stop-gap solution:
rm -rf ~/.gradle/caches/8.9/transforms//aa9c19370bfe38aa092acebe2995ebfb/transformed/multik-openblas-jvm-0.2.3/linuxX64

It works until I delete ~/.gradle so I probably won't hit it myself for a while (or until I update to the next multik release). But I'd really like a durable solution if possible.
Thanks!

Actually, I have to delete the file any time I invalidate build caches and will probably happen every time I upgrade multik so it is a little more of a problem than I asserted above.

After discussion on Slack, it seems the best option for me for now is to just use multik-kotlin as the build for openblas complicates the packaging (and dependency management) for Android and I don't strictly need the highest performance.
This issue still seems valid though so I'll leave it open.


[Core] Fix Variant::construct of Object

Variant type was not updated correctly causing leaks in ref-counted
This caused errors as objects constructed this way would be typed NIL and therefore not be freed, even though they went through reference counting, might have caused further issues elsewhere, like extensions, but haven't tested, this should be a safe fix as it just clears and initializes the type

Fixes: https://github.com/godotengine/godot/issues/90086

Can add a test case to GDScript if desired matching the issue report, but unsure if it's relevant in this case

The reason it breaks GDScript in this case is that this code passes fine, as value is NIL, which is valid for that check, a NIL variant is a valid type for an object here, now it will correctly error, as the resulting variant is now a valid OBJECT so it will go through the checks and correctly determine the type is wrong:
https://github.com/godotengine/godot/blob/29b3d9e9e538f0aa8effc8ad8bf19a2915292a89/modules/gdscript/gdscript.cpp#L1609

Adding a GDScript test for this, a scaled down version of the test in the issue for the error

There's still a strange leak when using set directly, but unsure what is causing that, it would be in some part of the code unrelated to this, will dig further but seems a different case

There, new fix, this is perhaps not exactly the cleanest, but I prefer to use the methods available there instead of assigning directly to the type, an alterative solution would be to instead:
diff --git a/core/variant/variant_internal.h b/core/variant/variant_internal.h
index dbd4a6a7ad..d867d08b2c 100644
--- a/core/variant/variant_internal.h
+++ b/core/variant/variant_internal.h
@@ -1493,13 +1493,13 @@ struct VariantDefaultInitializer<PackedColorArray> {
 template <typename T>
 struct VariantTypeChanger {
        static _FORCE_INLINE_ void change(Variant *v) {
-               if (v->get_type() != GetTypeInfo<T>::VARIANT_TYPE || GetTypeInfo<T>::VARIANT_TYPE >= Variant::PACKED_BYTE_ARRAY) { //second condition removed by optimizer
+               if (v->get_type() != GetTypeInfo<T>::VARIANT_TYPE || GetTypeInfo<T>::VARIANT_TYPE == Variant::OBJECT || GetTypeInfo<T>::VARIANT_TYPE >= Variant::PACKED_BYTE_ARRAY) { //second condition removed by optimizer
                        VariantInternal::clear(v);
                        VariantInitializer<T>::init(v);
                }
        }
        static _FORCE_INLINE_ void change_and_reset(Variant *v) {
-               if (v->get_type() != GetTypeInfo<T>::VARIANT_TYPE || GetTypeInfo<T>::VARIANT_TYPE >= Variant::PACKED_BYTE_ARRAY) { //second condition removed by optimizer
+               if (v->get_type() != GetTypeInfo<T>::VARIANT_TYPE || GetTypeInfo<T>::VARIANT_TYPE == Variant::OBJECT || GetTypeInfo<T>::VARIANT_TYPE >= Variant::PACKED_BYTE_ARRAY) { //second condition removed by optimizer
                        VariantInternal::clear(v);
                        VariantInitializer<T>::init(v);
                }

And just use the change method without clear like the other cases use, this would be slightly more invasive, but accomplish the same goal, either way works for me (though the current PR changes are cheaper in rebuilds)

Thanks!

Thank you!


Add MiniLogo to the Showacse

It would be nice having https://github.com/langium/langium-minilogo/ on the showcase. Maybe using threejs?

Or just HTML Canvas to minimize dependencies?

This would be possible and would be more effective for 2d graphics. When talking with @montymxb we thought about using some WebGL library to maybe be able to draw 3d graphics in the future.

Ok feel free to experiment. But I'd like to keep the complexity of the website under control. Remember that all code that is written must be maintained over time.


Installation issue

Hi, I am using a silicon Mac and used the pip install approach to install the package into a local virtual environment.
The issue is that after
pip install "crawl4ai[all] @ git+https://github.com/unclecode/crawl4ai.git",
this command crawl4ai-download-models threw an error:
FileNotFoundError: [Errno 2] No such file or directory: '.../.env/lib/python3.10/site-packages/crawl4ai/models/onnx/model.onnx'.
I checked the package inside the virtual environment as shown in the screenshot, and it is missing the ./models/ folder.

I fixed it by manually copying and pasting that folder from github repo to the local package, but is there a way to fix this issue without the extra work?
To give extra information, the virtual environment is created using pyenv at python 3.10.13.
Thanks!

Thanks for flagging this! Issue is fixed & code is now updated in the repo 🎉 It was a rookie mistake - forgot to remove the model from my local machine while testing, so the download feature never got tested 🤦♂ Glad it's sorted now!

@unclecode Thank you for the instant fix!
Quick question, I tried the example of using the javascript code to click the load more button. But in the case where I want to click the button multiple times, should I just use a for loop? or what would be the best practice with your package?

@zukangy Good question! Right now, I only run the script once before crawling starts. I'd recommend iterating carefully: first, click the button programmatically, then wait for the page to load before clicking again. You can also put a sleep between each click. This works better than a simple for loop. This week, I added the option to pass a list of JS scripts, running one after the other. When one finishes, the next can be passed.


Translate August 14 sit-rep into Polish

Greetings @nextstrain/polish,
It’s really great to work with you again after a long situation report hiatus.
Our August update on genomic epidemiology of COVID-19 is ready to be translated to Polish. This is just a one-off situation report, and we are not planning to resume weekly situation reports at this time. Translation of this report is less time sensitive than previous ones, so feel free to take a bit longer on the translation. I won’t be available for much of the weekend, so may not be able to publish it until Sunday anyway.
Branch to translate on: sit-rep_pl
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_pl/narratives/translations_ncov_sit-rep_pl_2020-08-14.md. You can translate directly in this file, but please remember to push often.
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_pl/ncov/sit-rep/pl/2020-08-14
Please translate the Twitter post below too :)
Thank you so much! Sending warm, safe thoughts to you and your loved ones and hoping for wisdom in our respective leaders.
Take care,
Cassia
Twitter post
Check out our August report on COVID-19 genomic epidemiology in Polish. In it, we explore the global spread of the virus broadly and provide specific updates for each world region.
Thank you to @, @, and @ for their rapid translation!
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/polish
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. Feel free to update internal links to refer to the Polish version of the narrative(s). I can also update those when I publish it though.
Please keep the number of and text for Table of Contents links the same in your translation as in the English narrative.
Please add your name under translators: with new line, tab, and dash, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Polish; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.

proofreading done, thanks again @M-nied7 for translating all text!
twitter post:
Sprawdź nasz sierpniowy raport dotyczący epidemiologii genomowej COVID-19 w języku polskim. Badamy w nim globalne rozprzestrzenianie się wirusa i opisujemy aktualizacje dla każdego regionu świata.
Dziękuję @pandkaruda i @afijarczyk za szybkie tłumaczenie!

Published and tweeted: https://nextstrain.org/narratives/ncov/sit-rep/pl/2020-08-14
Thanks so much Marta and Anna!


es.nodes redirection with aliases

Issue description
Hello, we have some troubles with es.nodes configuration for interactions with Pig Hive or Spark
Steps to reproduce
We have an nginx reverse proxy on a specific server with 2 aliases redirecting on 2 different clusters (workernodes) on port 9200.
It works pretty well for curl request or Kibana, but with interaction with es-hadoop, it always redirect on the default cluster (first configurated, it's also this cluster which is contacted if we use hostname of server instead of aliases.
Exemple of nginx configuration :
`server {
listen 9200 ssl;
server_name cluster1;
...
server {
listen 9200 ssl;
server_name cluster2;`
is it possible that es.nodes replace alias by server ip ? (in this case it's logical only first cluster can be contacted) ? How can I do in this case to have a good redirection with es-hadoop ?
Version Info
OS:         :  Ubuntu 16.04
JVM         :  1.8
Hadoop/Spark:  2.7.3
ES-Hadoop   :  5.2.0
ES          :  2.3.1 and 5.5.0
Best regards.

Hello and thanks to responding,
In fact i saw a configuration which do what I want : "es.nodes.resolve.hostname" when it set to false, nginx redirection works pretty well because alias is preserved :)
thx a lot


Add own turn server

Hello,
Please, could you help me to set my own turn server ?
thanks
Oussama

Sorry -- this is not a support forum.
I use this Twilio service for TURN.

Hello,
Thanks for your help, I'll try to put a static Turn server.
Regards,
Oussama
On Thu, Jun 2, 2016 at 10:20 PM, Feross Aboukhadijeh <
<EMAIL_ADDRESS>wrote:

Sorry -- this is not a support forum.
I use this Twilio service https://www.twilio.com/stun-turn for TURN.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/feross/instant.io/issues/111#issuecomment-223409933,
or mute the thread
https://github.com/notifications/unsubscribe/AFSHTVXT-z7-azh24XpPKaEgm4DKdAnLks5qHzsbgaJpZM4IslNX
.

--
Avec mes cordiales salutations.
*Oussama GHERMOUL *
06 68 43 17 56


Need help when navigating

Hi, currently i've implemented your code for my navigation, but currently i got an error on
maneuverImage.setImageResource(obtainManeuverResource(upComingStep));
the error is
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.ImageView.setImageResource(int)' on a null object reference
any idea how to solve this, btw great repo dude.

Hey @najmisyahir, you're using the same navigation code from this repo?  It sounds like your ImageView isn't being bound before you try to set the image resource for the first time.

Solve it by messing around with build gradle for the butterknife thx btw @danesfeder


Add the 202006.00 release version section header

Add the 202006.00 release version section header missed in #2098
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cbmc run checks


Incorrect usage of lang tag on pre

Describe the bug
Change #26 added the lang tag to pre nodes to indicate the programming language in use. However, the HTML spec says the lang tag should only be used for natural languages and not computer languages. Chrome's Lighthouse tool also flags the elements as having invalid (i.e. not BCP 47) tags.
There's additional discussion here about what the right approach is to include this data, which generally boil down to using class or data tags.
You may want to favor matching the CommonMark and Prism pattern of adding class="language-foo" to the code tag as a starting point.
Reproduction

System Info
-

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Indeed, Lighthouse all flags this up during it's accessibility checks:

[lang] attributes do not have a valid value

See https://dequeuniversity.com/rules/axe/4.7/valid-lang


EXX exchange api

Can anyone integrate this API?

You can propose a bounty and it can be done pretty quickly and well. I have done that several times.


[fix] networkFee calculation is not right in validateNetworkFee.

Bug
Networkfee calculation is based on the witnesses(signatures) of the transaction.
However the signatures are invalid before networkFee is set, so validation(calculation) of networkFee should be done before signing the transaction.
Fix
validateNetworkFee API needs param signers - accounts that will sign this transaction.

@snowypowers
To build a transaction, you need only the scripthash/address info of signers(sender and cosigners). Verificationscript in witnesses is account.contract.script, which should be unnecessary if just considering constructing a transaction.
TransactionBuilder is now a independent class, if we adding verificationscript in witnesses, there is possibility that user may directly use it, what if user wants to sign transaction when there is such dummy witness? And the transaction to validate may be constructed directly by Transaction class.
So I think to keep an isolated design, current solution is a better way.

Since validation of network fee will require the use of the verification script it's just a matter of whether are we gathering it at the build step first or at the validate step.
I'm not clear why are you mentioning the builder being an independent class. My suggestion doesn't not change that fact.
You can sign a transaction with dummy witnesses since signatures sign the transaction hex string without the witness data.
My suggestion will still allow the transaction to be constructed correctly, it just appends more data to the object earlier than later. And if we are gathering the data for the validate step, why not use it at the build step?

Since validation of network fee will require the use of the verification script it's just a matter of whether are we gathering it at the build step first or at the validate step.
It's not required to gather verification script at build step. Build and validate steps are independent, so we should not gather something in build step which is not necessary in build step, just for another step- validate.

It is possible that we populate the network fee in the builder too if it is fully offline. This looks like a job for the builder than the validator.
Having the information appended within the transaction makes it easy for each user to independently validate the transaction before signing. I will only have to transmit the transaction to everyone instead of the transaction and the list of accounts.
The data is going to be present in the transaction anyway upon signing so there is no extra overhead in adding this data.
Even as separate steps, the build and validate steps are going to be done closely together. I do not see an issue in gathering the accounts in the build step. It is also likely that the accounts can be provided as easily at either steps.

Even as separate steps, the build and validate steps are going to be done closely together.
One of the advantages to make processes independent is that it's flexible to arbitrarily combine the steps. Now TransactionValidator accepts 2 params: rpcClient and transaction, it indicates that I can use this class if I have a transaction and a network client. The transaction may be constructed by the basic Transaction constructor or even getTransaction rpc method, in which case the accounts info have not been gathered.

If we tell user validator must be used after builder, then why do we separate them?

The separation is mainly for separation of concerns and flexibility of usage.


Clean up MDL module from TypeNames and ClassName inappropriate usage

There are still some small issue with TextField in connection with ExpandableSearch, but I will probably handle that later in a separate issue.
Closes d5f1c0fae114fc3f864fc7bbbbed1d01169ace8d


Upgrade Bolt from Preact v8.x to Preact v10

Jira
N/A
Summary
Upgrades Bolt from Preact v8.x to Preact v10.
Details
These updates are ported over from the larger #1542; this PR includes the work mentioned in the Preact v8.x upgrade guide in addition to some minor updates to our Preact-based web component renderer + a small number of web components still rendering using Preact.
Also worth pointing out, this PR also requires us to upgrade Pattern Lab's UI to Preact v10 due to how Yarn dependencies in the monorepo are deduplicated and shared.
How to test

Review changes
Confirm tests passing as expected
Do a gut check on the Bolt components that are still rendering with Preact

Block List (small change required)
Code Snippet (small change required)
Video (no changes required)
Dropdown (no changes required)
Typeahead  (no changes required)
Icon (no changes required)

Confirm the Pattern Lab UI (especially the Tooltips that show up when you hover over the viewport resizer icons) are displaying correctly

This should be ready to take another look at @remydenton / @danielamorse!

@sghoweri approved 👍
Considering the pickle you were in, I think this is a fine solution (and pretty clever!).
I don't love the idea of printing all these functions to the page, along with both HTML as data and rendering the HTML, but I understand how it came to be. If we started using this pattern more, I wonder would there be a cost to including script tags on every element? Basically, I'd look for any other solution first, but I'm sure you have already done that. Look forward to discussing more.
Side note... it's not a regression caused by this PR, but Dropdown in IE11 appears to be broken:
.
Is Dropdown actually used anywhere? I figured we'd have heard about this breaking.

Thanks @danielamorse. Definitely more to explore with this SSR technique but at a minimum it gives us something to compare against.
Regarding Dropdown being broken... that’s what https://github.com/boltdesignsystem/bolt/pull/1384 was trying to patch up 🙂. As far as I know it’s not getting used but ya know, better safe than sorry.

PR was released with v2.13.0


Audit veGNO.sol

@auryn-macmillan Thanks for opening the issue. Would be great if you share a bit more details on the concerns you have about the code. Is there any particular issue you saw in the current implementation?

Hey @SHA-2048, sorry for the lack of content on the issue. I opened it originally because we were adding it to Gnosis' audit pipeline and I needed an issue to import into our Github project. Should have added that information here to make it a little more obvious to everyone else though :smile:


Backend prep for Codeformer WEBUI support

Putting up initial prep for Codeformer support in the WebUI. Have made significant updates to the metadata generation & backend support for Codeformer, but these are mostly aping GFPGAN with the addition of the codeformer fidelity param.
Peek at it and poke anything you see needing work. Will try to start working on FE for it as I have time

Closing as #1151 is full implementation.


[GSB] Add visualization of same-type constraints in an equivalence class

Introduce support for writing a GraphViz graph describing the
same-type constraints within an equivalence class. This visualization
helps debugging the minimization algorithm.
LLVM's GraphWriter is actually kinda awful, so there is some hackery
here both to dodge an overzealous static assertion and to munge the
output into an undirected graph.
Also do a little refactoring and cleanup around nested-type-name-match constraints.

@swift-ci please smoke test and merge

@swift-ci please smoke test Linux


Add testing

https://blog.jetbrains.com/go/2022/11/22/comprehensive-guide-to-testing-in-go/

Test for the get... functions written.
Automatic CI building/testing implemented.


What fonts are used in the screenshots?

Hey there! Thank you for the themes! I would like to know, what fonts did you use for making the screenshots?

I'm assuming you're referring to this screenshot (there are quite a few and not all of them are mine):

In which case, it's been a while since that screenshot, but iirc, the monospace font is either Inconsolata or Input Mono Narrow and the sans-serif font in the treemacs sidebar is Input Sans (from the same bundle).

What a coincidence, I have just installed them! Thank you :)

I know this issue is long-dead, but for anyone coming here from Google: after some closer inspection, the fonts in the image above appear to be Fira Mono and Fira Sans in code and the sidebar respectively.


⚠ Avatar API Endpoint has degraded performance

In 3e5f512, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 5373 ms

Resolved: Avatar API Endpoint performance has improved in d283844 after 2 minutes.


JWT Authorization

Create basic authorization using JWT. Authentication endpoint will be created to get JWT bearer token.

Create "/storage-pool/authenticate" endpoint. User will authenticate for using resource using basic auth, if authorized, JWT token will be generated and every request must include that token as bearer token which is will be verified by "RequestPrecondition()" module.

https://github.com/Hari-Kiri/virest-storage-pool/pull/46


parseDate doesn't convert time to local properly

C3 version: 0.4.18
D3 version: 3.5.17
Browser: Chrome 61.0.3163.79
OS: Mac OS

Graph settings:
  data: {
    x: 'x',
    xFormat: '%Y-%m-%dT%H:%M:%SZ',
    columns: [
      ['x', ...time_intervals.map(([from]) => from)],
      ...data.map(row => {
        return [row.dimensions[0], ...row.metrics[0]];
      })
    ],
    type: 'area'
  },
  axis: {
    x: {
      type: 'timeseries',
      tick: {
        count: 6,
        format: x => moment(x).format('M/D, hA')
      }
    }
  },

expected result: x axis displays local time
actual: x axis doesn't display local time
known workaround:  override parseDate implementation
import c3 from 'c3';

c3.chart.internal.fn.parseDate = function(date) {
  return new Date(date);
};

something weird happening here: https://github.com/c3js/c3/blob/master/c3.js#L1098
although as far as I understand I can't set data-xLocaltime to false: http://c3js.org/reference.html#data-xLocaltime

potentially it's a matter of the bad default:
data_xLocaltime: true

I suspect in most cases server endpoint returns data in UTC format so parsing as UTC by default makes more sense.


Restored window size set to maximized after exiting maximized

When I exit Atom and window state is restored, its size is remembered; so when I start Atom again, the window starts restored and remembers its size. However, when I exit Atom maximized, the restored window size is set to maximized size; so when I start Atom again, it start maximized and when I click restore, the window size remains just the same (maximized size).
Simply said, nonmaximized window is too often set to maximized size and is just too big to normaly drag around and I have to manually resize window to smaller size each time.
Reproduction Steps:

Exit Atom maximized
Start Atom again and click "restore window"
The window size is same as maximized

Expected behavior:
Restored window size should be remembered correctly, so you can actually restore window to its last size, not restore it to maximized size.
Observed behavior:
I am unable to test this on different OS than Windows 10. I think it's not Electron bug, since VS Code behaves correctly. The reason why this bothers me is that I can't just grab maximized window and drag it, because it's size is same as maximized (= just too big for dragging around screen).
Screenshots and GIFs

Atom version: 1.4.3
OS and version: Windows 10
Installed packages:
minimap
Additional information:

Problem can be reproduced in safe mode: Yes
Problem started happening recently, didn't happen in an older version of Atom: No
Problem can be reliably reproduced, doesn't happen randomly: Yes
Problem happens with all files and projects, not only some files or projects: Yes

I've definitely ran into this issue before on Windows but can't remember if there's an issue for it. :thought_balloon:

Still present as of Atom 1.7.0, despite the Electron update (I was secretly hoping that the update would fix it); using Windows 10 Pro 64 bit.

As I said in #9172:

I think Atom should follow Visual Studio Code's example (VS Code is also an Electron app) and set a default window size and position which is used in those cases the previous size is not remembered across sessions. At least, with the VS Code behaviour, the "restore down" button is not made useless.

Possible duplicates:
https://github.com/atom/atom/issues/6912 https://github.com/atom/atom/issues/10181

//cc @50Wliu check possible duplicates and maybe incorrect windows label. One of possible duplicates is linux mint.

Neither of those are duplicates of this one as those are saying that the window is not maximized, but this one is saying that restoring a maximized window results in a window that has the same size as a maximized one.

@50Wliu, This is indeed a duplicate of https://github.com/atom/atom/issues/6912.
When maximized and then exited, it saves the sizes and not the maximization. And it ends up opening un-maximized, but with the maximized sizes.
Please close one. The older issue (mine - #6912) also notes the aero-snap behavior for the same, while this issue seems to have a little more engagement.

My issue that made me confused is that I exit atom while in full screen (f11) and when restarting it is in fullscreen but then when leaving fullscreen it has the incorrect size and because I have the taskbar in the top I can't access the menu or anything in this state and have to use special steps to resize the window.
Maybe my separate but related?

@prasannavl However, @J-qak is saying that the window is maximized on restarting Atom:

when I exit Atom maximized, the restored window size is set to maximized size; so when I start Atom again, it start maximized

This issue is that the restored window size isn't set correctly.

@50Wliu, Makes sense depending on how you look at it I guess.
The cause of the issue and the expected behavior in #6912 there solves both of these though. Anyway, as you see it fit :)

Is the issue I described also covered by this?

I don't think fullscreen state should be remembered - does any other program do this?

@50Wliu my experience on Windows is that most programs remember both of the following:

maximised state (wheter the window was maximised upon closing)
restored size (the size that the window had before it was maximised)

In Atom, point n. 1 works as expected but point n. 2 doesn't

Actually I can't think of any other programs that restore fullscreen state at the moment.

Yeah, I'm bothered constantly by this as well and may take a look at it.  The only other program that I can think of that doesn't handle resizes correctly is Steam.

@Ben3eeE I have just conducted some tests on my Windows 10 Pro machine and some of the programs that remember both maximised state and restored size (restored size is remembered even if the window was maximised upon closing, except where noted using an asterisk) are:

Chrome 49
Firefox 43
MS Edge
Internet Explorer 11
Word 2016
Outlook 2016
Excel 2016
PowerPoint 2016
OneNote 2016
Photoshop CC 2015
Illustrator CC 2015 (*)
VS Code 1.0
Visual Studio 2015
Sublime Text 3
IntelliJ Idea 15

(*) similarly to Atom, this program does not seem to remember the restored size if it was maximised upon closing.

@mastazi My comment was regarding fullscreen state entered by pressing F11 in atom and all modern web browsers on windows not maximized state.
@50Wliu I tested chrome, firefox, opera and internet explorer and it seems split about remembering fullscreen state. Internet explorer and opera does while firefox and chrome does not. Maybe remembering it is unexpected for a text editor I don't know probably a matter of preference.
The window should however always be restored properly when exiting fullscreen and after restarting in fullscreen it does not. The size when exiting fullscreen is bigger than the screen. So this seems like the same issue from a different state only.

@50Wliu I just found https://github.com/atom/atom/issues/8443 regarding remembering fullscreen state.

I am so sad that this issue is still open.  😢

my experience on Windows is that most programs remember both of the following:
maximised state (wheter the window was maximised upon closing)
restored size (the size that the window had before it was maximised)
In Atom, point n. 1 works as expected but point n. 2 doesn't

Some apps remember full-screen and some don't. That is less important to expected behavior. Remembering the last restored size is much more important for living up to user expectations.
Should we remember or forget that the window was maxed when I closed it? I don't much care.
But I get super irritated 😖 when I must yet again drag an Atom window away from the side of the screen ... just so I can shrink it down to at least be smaller than the screen ... just so I can drag it to more or less where I want it to be on the screen ... so I can finally start working on carefully and painstakingly resizing it to the same size as I had it before I closed it, just because I forgot to un-maximize it before close.

This anoying bug is still alive in V1.25.1 on both windows 7 and 10

This bug is also still present in V1.28.1 on Windows 10. This happens to me whenever I don't resize the window after going into a new project folder.

Sooo....hello 1.30.0 x64 (Windows 10)

July 2020 - Bug still not fixed in Atom 1.49.0 x64 (latest version at time of comment) for Windows 10.
Too bad, Atom is my favorite editor but this bug can be frustrating at times.
Here's hoping it's fixed soon.

Still broken and annoying in 1.54.0 x64.


[Dubbo-3707]Merge dubbo-serialization-gson into incubator-dubbo

What is the purpose of the change
#3707
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

I have run the unit test, and write a demo to test the new module

Codecov Report

Merging #3714 into master will increase coverage by 0.09%.
The diff coverage is 92.3%.

@@             Coverage Diff              @@
##             master    #3714      +/-   ##
============================================
+ Coverage     63.55%   63.65%   +0.09%
  Complexity       71       71
============================================
  Files           703      706       +3
  Lines         31001    31066      +65
  Branches       5022     5023       +1
============================================
+ Hits          19702    19774      +72
+ Misses         9027     9019       -8
- Partials       2272     2273       +1

Impacted Files
Coverage Δ
Complexity Δ

...dubbo/common/serialize/gson/GsonSerialization.java
100% <100%> (ø)
0 <0> (?)

...bo/common/serialize/gson/GsonJsonObjectOutput.java
100% <100%> (ø)
0 <0> (?)

...bbo/common/serialize/gson/GsonJsonObjectInput.java
80% <80%> (ø)
0 <0> (?)

...e/dubbo/remoting/transport/netty/NettyChannel.java
57.64% <0%> (-4.71%)
0% <0%> (ø)

...bo/rpc/cluster/support/FailbackClusterInvoker.java
67.21% <0%> (-3.28%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
65.88% <0%> (+1.17%)
0% <0%> (ø)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
75.51% <0%> (+2.04%)
0% <0%> (ø)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4ff91...348f22b. Read the comment docs.

Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict?

Sorry, there is some conflict, I think it is due to the avro serialization has been merged. Could you please resolve the conflict?

OK, I will resolve the conflict.


Adding subnets taggings capability when creating a VPC

Motivation
When creating Kubernetes (k8s) clusters in EKS, subnets tagging is mandatory. Currently, it's not possible to create such clusters using this VPC module.
Changes
This PR aims at enabling the tagging capability on subnets created by the VPC module
Usage
In order to tag the subnets, simply inject values for public_subnet_tags and private_subnet_tags
  public_subnet_tags = {
    "kubernetes.io/cluster/cluster-name" = "shared"
    "kubernetes.io/role/elb"                      = "1"
  }

  private_subnet_tags = {
    "kubernetes.io/cluster/cluster-name" = "shared"
    "kubernetes.io/role/internal-elb"             = "1"
  }

@tminussi Looks ok, but can you make a small note in the examples or in the documentation to indicate why we have a separate public_subnet_tags and private_subnet_tags .

I have update both the README.md file as well as the examples under examples/


Use powers-of-two when displaying RAM

Closes https://github.com/dask/distributed/issues/3818
Twin of https://github.com/dask/distributed/pull/4649
Memory is ubiquitously expressed in power of twos.
The one and only exception that I'm aware of is when selling hard drives.
This change impacts:

dask.array.Array._repr_html_
distributed.Client.__repr__
distributed.Client._repr_html_
distributed.cluster.Cluster._widget_status
distributed.cluster.Cluster.__repr__
distributed.Scheduler.performance_report
distributed worker logs
distributed bokeh GUI

Do you want it to merge at the same time as the distributed one?

Ideally, one should

merge this one (this will cause regressions in distributed)
rebuild the distributed PR
merge the distributed PR


Change hypens to underscores for processing level/product type

The hyphens used for Sentinel 1 in PRODUCT_TYPE.py do not appear to be valid processingLevel choices.
For example the code below would yield 4 results:
import asf_search as asf
from datetime import date

wkt = "POLYGON((-160.8195 16.2245,-152.5101 16.2245,-152.5101 24.957,-160.8195 24.957,-160.8195 16.2245))"
startDate = date(2020,9,13)
endDate = date(2020,9,14)
results = asf.geo_search(platform=[asf.PLATFORM.SENTINEL1],
                         beamMode=[asf.BEAMMODE.IW],
                         start=startDate,
                         end=endDate,
                         processingLevel=["GRD_HD"],
                         intersectsWith=wkt)

However, if one replaces processingLevel=["GRD_HD"] with processingLevel=[asf.PRODUCT_TYPE.GRD_HD] (following the example in hello_world.py line 39), the search would return zero results.

Nice catch, thank you! Checked all the updated values and they look correct now. Merging to master.


Pixhawk offboard flight: not good Z tracking

These days I am doing outdoor experiments with a quadrotor using Pixhawk interfacing with an onboard Ordoid. The Odorid communicates setpoints that the drone has to reach.
To understand the setup:

I am using the 1.6.1dev version of the firmware with LPE estimator.
I am using a DJI Flame Wheel F330 frame
I was on a grass field without any shadow around midday (temperature 30 degrees), I do not know about the temperature of the Pixhawk, but it was high
I recalibrated the sensors several times, more or less always before each test.

One of the experiments is a waypoints navigation. The Odorid runs ROS and calculates waypoints in the local frame. It communicates the position to the Pixhawk using the rostopic /mavros/setpoint_position/local.
I did several tests, and after a while, the drone started to have a strange behavior.

As you can see from the graph the Odroid communicates:

takeoff waypoint (more or less from second -48 to -46): current position in xy (red and light blue lines), 2meters more in z (blue curve)
first waypoint (more or less from second -46 to -34): z remains initial z + 2 meters, x and y change (the waypoint is at 10 meters distance from the initial position)

Initially, tracking is good, the drone reaches the takeoff waypoint. Then the Odroid communicates the first waypoint, x and y try to converge to the desired position, while z starts to rise.
At second -34 I kill the publisher of /mavros/setpoint_position/local and ask for automatic landing, but as you can see the Drone is still going up.
At second -20 I take over with the remote control and land the drone.
The second image is another experiment in which I experienced the same behavior:

takeoff waypoint: ok
first waypoint: ok
second waypoint:  ok
third waypoint (come back at initial position): x and y are good, while z rises at 7 meters, and when I switch off the publisher of setpoint (second -140) it goes up until I take over with the remote controller at second -110

The state estimate seems correct, I am not sure how precise it was, but I was able to see that the actual behavior is like the one showed in these graphs.
Have you experienced something like that?
Do you have any idea about the causes of this problem? Do you think it can be related to overheating of the board?
What I will do now is reflash the firmware, and retry to do the same experiments.
Thank you very much.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)


Add a timer

As a user I want to have a timer, so that I can track the time I spend in a room

closed via #4


Inline statement to disable schema validation

Compare to // eslint-disable-line no-use-before-define for eslint, there might be an inline statement to disable schema validation for a certain line/file.

Is this currently possible? I see there was a merged PR but it says "partially fixes it" @acao, there's one line in my schema I want to disable because the schema is not up to date but I know it works


Demo Site with regular outages over the past few weeks.

The demo site (https://stewardle.com) frequently shows 504 GATEWAY TIME-OUT errors through most hours of the day, sometimes being unavailable for the whole day.

Thanks for raising this issue, apologies for the very late response, its likely the site was down due to an issue fixed in https://github.com/ssyyhhrr/stewardle/commit/930e1ec8b200d34c372302380fe719e973135c7b.
The game is now back online at https://stewardle.com/


[Question] Why does env.step in the HalfCheetah environment return 5 values if one of them if always False?

Question
This is code directly copied from this repo for the halfcheetah environment v4, specifically this
def step(self, action):
        x_position_before = self.data.qpos[0]
        self.do_simulation(action, self.frame_skip)
        x_position_after = self.data.qpos[0]
        x_velocity = (x_position_after - x_position_before) / self.dt

        ctrl_cost = self.control_cost(action)

        forward_reward = self._forward_reward_weight * x_velocity

        observation = self._get_obs()
        reward = forward_reward - ctrl_cost
        terminated = False
        info = {
            "x_position": x_position_after,
            "x_velocity": x_velocity,
            "reward_run": forward_reward,
            "reward_ctrl": -ctrl_cost,
        }

        if self.render_mode == "human":
            self.render()
        return observation, reward, terminated, False, info

That functions returns observation, reward, terminated, and info, which all makes sense, but then there is that False that I don't understand. What's the purpose of that? What am I missing?

In the change to v26 the values retured from step() became observation, reward, terminated, truncated, info.
So the false is the truncated. This implies that the episode can never be truncated, only terminated.
More information about the PR that brought in this change is here: https://github.com/openai/gym/pull/2752

what @axb2035 wrote is mostly correct as the environment doesn't internally truncate, i.e. stop an episode due to a time limit.
However, during gym.make, a time limit wrapper is applied to the environment that can enforce a time limit and truncate the environment. For all mujoco environments this time limit is 1000 steps.


version 1.19

Relicex version 3.2.2 for 1.19 says it requires cloth config v6 (i am using the most recent cloth config version for 1.19)

Hi there,
Would you be able to share an image/screenshot of the error message?
Thanks.

I figured it out i had 3 versions of cloth config (old ones), for some reason it was only reading the lowest one before giving me the error, sorry for the trouble ^^'

No worries, I'm happy things worked out.


Define a merge policy

We need a merge policy to fix how we are going to merge PRs. Here's my proposal -

One squashed commit merge with PR.
Even if PR contains multiple type of changes, it should reflect only a single topic and Rule 1 shall still withhold on it.

Why squashed merge ?
It preserves both the author as well as the committer, something that can be very useful.
Also one commit per PR provides the cleanest commit history possible.

@singhpratyush views?

 But I think that we may also go with rebase if PR contains only one commit with relevant commit message.
Also, shall we set the commit message format for various types of commits (doc update, new algorithm, improved algorithm, etc.)?

One commit should have all the necessary changes that need for inclusion of that algo. Commits like added spacing, minor changes gives bad impression. As every commit should add some new thing to the repo, not some reformatting. what do u think @singhpratyush

@yashLadha : That is exactly why we are planning to squash things in the first place.

It would be great @singhpratyush

One commit policy seems promising. But I think that we may also go with rebase if PR contains only one commit with relevant commit message.

:+1:

Also, shall we set the commit message format for various types of commits (doc update, new algorithm, improved algorithm, etc.)?

That discussion would go in a separate thread.

@aviaryan : Do we need a document for the policy?

Sir , what we can do is that we can tell the user to rebase at the end . When merging will be done.

@yashLadha I am not sure if everyone will be able to do that.  This will be helpful for future maintainers.

Sir, but there is a need to do. Because when i contributed to some other organisation, i have to learn to rebase the commits, as it is a standard practice to know. It would be better if contributors know about it. And it is just 2 more commands to use. @aviaryan

Let me sum this up -
Squash when

Many commits.

Rebase when

Single commit with a good commit message.


xml:space="preserve" is not handled

There is an unhandled case where xml:space="preserve" is not taken into account.
Input:
<t xml:space="preserve">  there are two spaces here  </t>

Current output:
{
  t: {
    "@xml:space": "preserve",
    "#text": "there are two spaces here"
  }
}

According to w3 spec it should instead return something closer to this:
Expectation:
{
  t: {
    "@xml:space": "preserve",
    "#text": "  there are two spaces here  "
  }
}

or this
{
  t: "  there are two spaces here  "
}

Hi 👋 !
Sorry for the delay, the directive should be supported as expected with the new release.
The output will be like the first result you posted (in order to be consistent with how attributes are currently handled)
We could add support for the later through an option if this is something requested


Implement option to make fields customizable before printout of badge

Users should have the option to edit fields on their badge before printing them out.
Implementation should be as follows:

Organiser should have the option to make fields customizable "Allow customizing of field"
This will result in a pop up "customize your badge before printing" when checking in.
Users can now choose the fields to customize or leave empty.
The badges get printed with the customized option.

I would love to work on this issue. Could you assign it to me.


"Unwrapping" unrelated nilable values in case branches not working and not rejected by the compiler

def int? : Int32?
    2
end

case true
when x = int?
    puts x # not reached
else
    puts ":("
end

This:
case exp
when something
  do_something
else
  do_something_else
end

is rewritten to:
if something === exp
  do_something
else
  do_something_else
end

In your case, your code is equivalent to:
if (x = int?) === true
  puts x
else
  puts ":("
end

and 2 === true is false.
Everything is working as expected. This is not a bug.

You probably wanted to write:
# Note that there's no case expression
case
when x = int?
  puts x
else
  puts ":("
end


Win95 Setup.bmp

Hey, I've seen your icons and themes and I love them, thanks for creating and sharing them!
Is there any chance you can do something to Windows 95's "setup.bmp"? I see it's not really "pixel art" but a dithered collage of pictures pictures, so I guess chances are slim... but I would love to have a widescreen high resolution version of it that has the same vibe, but with the quality we are used to in 2023.

Setup-95? :-) to blur, rescale and pixelate only. I don't have such mouse, keyboard and cables))
If you have originals of theese photos (or AI to recreate them from 1-bit maps), then I can make such wallpaper. You can help, so I'll can make it.
The win98 setup.bmp was a pc-artwork, so I recreated it with Blender3D.


Update tests and node scripts

Description

As part of build process, Heroku detects both "build" and "heroku-postbuild" scripts and then only runs heroku-postbuild so the sequelize migration has been added to heroku-postbuild command.
Added node scripts for checking db connection and for inserting sample produce data.

Testing

Only really tested the testdb script which was fine.

@DanielmAaron FYI


[VL] gluten-it: Shorten table creation and query runner logs

Mainly to compact "Creating catalog table" logs into one line.
Before:
Running query: q65...
Switching to SessionDesc(SessionToken(baseline),Vanilla Spark TPC-DS q65) session...
Successfully switched to SessionDesc(SessionToken(baseline),Vanilla Spark TPC-DS q65) session.
Creating catalog table: customer
Creating catalog table: catalog_page
Creating catalog table: catalog_returns
Creating catalog table: item
Creating catalog table: web_page
Creating catalog table: web_sales
Creating catalog table: web_returns
Creating catalog table: warehouse
Creating catalog table: store_returns
Creating catalog table: customer_demographics
Creating catalog table: income_band
Creating catalog table: date_dim
Creating catalog table: web_site
Creating catalog table: promotion
Creating catalog table: catalog_sales
Creating catalog table: reason
Creating catalog table: customer_address
Creating catalog table: household_demographics
Creating catalog table: call_center
Creating catalog table: time_dim
Creating catalog table: store_sales
Creating catalog table: inventory
Creating catalog table: store
Creating catalog table: ship_mode
Executing SQL query from resource path /tpcds-queries/q65.sql...

After:
Running query: q65...
Switching to SessionDesc(SessionToken(baseline),Vanilla Spark TPC-DS q65) session... Done.
Creating catalog tables: customer, catalog_page, catalog_returns, item, web_page, web_sales, web_returns, warehouse, store_returns, customer_demographics, income_band, date_dim, web_site, promotion, catalog_sales, reason, customer_address, household_demographics, call_center, time_dim, store_sales, inventory, store, ship_mode, ... Done.
Executing SQL query from resource path /tpcds-queries/q65.sql... Done.

Need to revert this PR since it may lead to some malformed log outputs. Optimizations needed.


Double-height font for hi-res launcher and Pocket

For the hi-res launcher, we will need to find a way to either convert or make a double-height font. This could also be very useful for the Pocket launcher, since it's hard to read the entries at the current size (of course, that will affect the layout, so we need to do some experiments there).

Be the change you want to see in the world:
https://github.com/amigavision/TopazDouble


Remove GO111MODULE=on and -mod vendor from Makefile

Travis CI is no longer in use
-mod vendor is the default behaviour Go 1.14 and the module contains a top-level vendor directory
GO111MODULE=on is the default behaviour since Go 1.16

/lgtm
/approve

/assign @vteratipally