move match_references to matcher module

Move the remaining matcher functionality to hep:

match_references https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/refextract/matcher.py#L112 to https://github.com/inspirehep/inspirehep/blob/master/backend/inspirehep/matcher/api.py
Move /linked_references endpoint https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/editor/api.py#L231

Tech Notes

Move  match_references https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/refextract/matcher.py#L112 to https://github.com/inspirehep/inspirehep/blob/master/backend/inspirehep/matcher/api.py and add tests
Move https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/editor/api.py#L81-L108 to editor views, update ingress to point to inspirehep and add tests
Move https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/editor/api.py#L231-L235 to matcher views, update ingress to point to inspirehep and add tests
Remove the endpoints from next.

I am not sure if we can remove match_references from next since it is used multiple times in workflows
https://github.com/inspirehep/inspire-next/blob/d237fe351bdfc2d04f5276a1d10e4198cfdd3165/inspirehep/modules/workflows/tasks/actions.py#L424-L438


align-issue-labels is broken

URL: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

I'm disabling it via hotfix.

I'm not sure if this is the same problem, but the PR list is somewhat broken too. Double checkboxes, no color highlight for "review required".

@AlCalzone I'm not seeing the doubled checkboxes. Can you make sure this is caused by RGH and if yes, provide an URL?

I don’t have any other extensions and I’m see it (Safari, but the user above likely a different browser)

Checkbox feature disabled via hotfix as well

In my case it's Firefox and no other extensions.


dasherized attributes with python and flask?

So as you know python implodes at the first sign of a - so you cant write out (easily) json which would read { first-name: 'foo' }
Thus attributes have underscores eg, first_name.
Any recommendations? Or just press on with underscores.

Three options:

Use the subscription syntax (obj['first-name']) if made possible by your framework.
Transform everything on import/export.
Just use underscores in names.

I've been meaning to open an issue on this too, as I'm curious as to why dasherized names are recommended when they are not valid identifiers in any programming language. I like dasherized names in URLs, too, but don't see any obvious reason to favor them in JSON keys.

they are not valid identifiers in any programming language

It doesn't really affect your point, but various Lisps use dashes in identifiers.

I would much prefer that the recommendation for attribute names is underscored instead of dasherized, and I don't think the dasherized recommendation is very popular.

Its an interesting one right, camel case is popular given its javascript origins but IMO is fugly when representing data. Dashes are ok and underscores cast back to elitist geekery. Considering dashes cause issues in languages such as python as we shoehorn in support it would be great to settle on one style to rule them all that is supported by all natively.
Droppin' bombs.
Regardless i think i'll keep the underscores for now.

In the Django REST framework adapter that I maintain we currently don't enforce dashes for this very reason.  It's relatively easy to force dashes when the output is being manually generated, but when it's used as part of another library with existing conventions it's slightly more difficult.
Of course, this is just one more reason to find out how it can be done, which is why I'm not opposed to enforcing dashes in attributes. The general consistency between the client and the server ends up being a plus in the long run.

This would be a great question for the eventual forum at https://github.com/json-api/json-api/issues/295 , but it's not an issue with the spec itself, so I'm going to close it. Hopefully we'll get that forum up soon. Thanks!

Thanks @steveklabnik and I <3 your talk at APIdays Sydney :)


Update HTTP/3 current status

HTTP/3 support has now been rolled out by default to Chrome and Edge between versions 88 and 89.
Firefox looks to have this enabled in 88.
Currently caniuse says Safari has enabled by default, but that doesn't appear to be the case so reverted that.

Confirmation that HTTP/3 is rolled out to at least 76% (and more likely nearer 100%) of up to date Chrome/Edge users: https://twitter.com/ericlaw/status/1377758311056048131?s=21

I'm not sure this change is quite right. I think
   "and_chr":{
      "89":"n"
    },

should be "Yes" (based on the Finch setting of ~96%), but I don't recall whether Finch impacts the Android WebView.

I'm not sure this change is quite right. I think
   "and_chr":{
      "89":"n"
    },

should be "Yes" (based on the Finch setting of ~96%), but I don't recall whether Finch impacts the Android WebView.

Fixed thanks @ericlaw1979 - I missed there where two Android settings (“Android Browser” and “Chrome for Android”) and only updated the former not the latter. That’s corrected now.

Also (unsure if it's worth mentioning) but Edge set to 100% in Edge 87.

Edge 87? Or 89?
Personally I think going into the whole Finch/ECS thing (explained excellently in your post on this is a bit too detailed and should just go with the majority.
And I’ve gone with the thinking that if an older version is grabbing the new Finch/ECS settings then highly likely they are getting to upgrade to be told there is a new version to and upgrade to that.
Hence why I’ve said this is active from version 89 onwards even if earlier version might have got it after their initial release, or if ~4% of Chrome 89 users don’t have it.
Lots of other reasons people won’t have it too (e.g. stuck behind corporate proxy, antivirus, or some other proxy) so never gonna be perfect.
Hoping that makes sense and you agree with the thinking here.

yeah, I think anything's an improvement here. We ramped to 100% back in 87, but yeah, given that 89 is now stable, older values are of historical interest at best.

Just to be clear, which if these is most accurate?:

Edge 87 was released with it ramped to 100%
Edge 87 was released without it on for vast majority and then quickly ramped up to 100% before Edge 88 was released.
Edge 87 and 88 were released without it on for vast majority and then ramped up to 100% before Edge 89 was released.

I presumed it was 3, which is what my PR is based upon, but if it’s 1 then happy to backdate to 87, and if it’s 2 then happy to backdate to 88.
Any ideas on Chrome? From my links above it seemed to be to be defaulted to on between 88 and 89 and, as per your Twitter posts, is now on for ~96%, in which case I’ll leave that as being support from 89.

It appears that Edge Stable went to 100% for h3-29,h3-q50 on November 5th for v86+, which had then been in stable for almost a month. So, Edge 87 had QUIC the whole time.
For Chrome, it's hard to do the archaeology here because we only have daily snapshots (not easily diffed) but on Nov5th, 2020, their Finch config looked much like it does today, with <10% of configs with H3-29 disabled.

Thanks @ericlaw1979 - based on that I’ve backdated the changes for both Edge and Chrome to 87.

Looking good, thanks all!


Use latest available minifier-css version

Fixes an issue in Meteor 1.8 (https://github.com/meteor/meteor/issues/10253) where a @babel/runtime related message is erroneously shown. Should be backward-compatible with previous versions of Meteor.

thanks


Add support for LSIF Typed

This commit adds the ability to emit LSIF Typed using the following
command:
lsif-java index --output dump.lsif-typed

LSIF Typed is used as the output format as long as the output filename
ends with *.lsif-typed.

To run it out locally against another repo:
# 1. start sbt shell
$ sbt
# 2. index a repo
> cli/run index --cwd /Users/olafurpg/dev/sourcegraph/sbt-sourcegraph --output dump.lsif-typed


Unable to reuse volumes after LDAP_TLS_ENFORCE is true

Hi there!
A really nice image, thanks for sharing :)
I run into an issue with docker-compose up -d --force-recreate --remove-orphans and LDAP_TLS_ENFORCE true. On the first run all work as expected, but on the second start I see the error below in my log, because /container/run/state/slapd-first-start-done file does not exist on my second start (as expected). My workaround for now is, to map /container/run as volume, too. But I'm sure this will break forward compatibility.
+ ldapmodify -Y EXTERNAL -Q -H ldapi:/// -f /container/run/service/slapd/assets/config/tls/tls-enable.ldif
ldap_sasl_interactive_bind_s: Confidentiality required (13)
*** /container/run/startup/slapd failed with status 13

It looks like that the issue #36 also has the same issue.
See also at http://serverfault.com/a/617965

Confidentiality required is probably related to the fact that olcSecurity is set to 1. See also this.

Hmm.. .I just noticed, if LDAP_TLS_ENFORCE is true, replication will not be set up.
Add replication config...
588e86e4 conn=1028 fd=14 ACCEPT from PATH=/var/run/slapd/ldapi (PATH=/var/run/slapd/ldapi)
588e86e4 conn=1028 op=0 BIND dn="" method=163
588e86e4 conn=1028 op=0 RESULT tag=97 err=13 text=TLS confidentiality required
ldap_sasl_interactive_bind_s: Confidentiality required (13)
588e86e4 conn=1028 op=1 UNBIND
588e86e4 conn=1028 fd=14 closed
588e86e4 conn=1029 fd=14 ACCEPT from PATH=/var/run/slapd/ldapi (PATH=/var/run/slapd/ldapi)
588e86e4 conn=1029 op=0 BIND dn="" method=163
588e86e4 conn=1029 op=0 RESULT tag=97 err=13 text=TLS confidentiality required
ldap_sasl_interactive_bind_s: Confidentiality required (13)
588e86e4 conn=1029 op=1 UNBIND
588e86e4 conn=1029 fd=14 closed

fixed in 1.1.8

I am facing the same issue on 1.1.8
This appeared when settings LDAP_ENFORCE_TLS in my config.ldif:
olcSecurity: ssf=128
olcLocalSSF: 128

switching off LDAP_ENFORCE_TLS doesn't remove these lines


redpanda: refactor template tests to use txtars

Template tests / golden tests for the redpanda chart were previously a collection of files on disk in the testdata directory. This resulted in very noisey git diffs and git statuses whenever changes to the chart were made and it diverged from the patterns set forth in the console and connectors chart. Adding regression tests was a bit unpleasant as well. They would need to be added as a "no-values.yaml" file or have an elaborate go setup.
This commit refactors the template tests to follow a pattern similar to console and connectors. To make adding new regression tests less painful, a minimal dynamic assertion system has been put in place.
Values files may specify assertions in the form of: # ASSERT-<NAME> ["OPTIONAL", "PARAMS"]
Which will cause various assertions to run and provides a framework for easily adding new assertions and selectively applying them.

Oh gofmt complains:
task: [ci:lint] gofumpt -w .
task: [ci:lint] git diff --exit-code
diff --git a/charts/redpanda/chart_template_test.go b/charts/redpanda/chart_template_test.go
index 89a05d8..e6d5e41 100644
--- a/charts/redpanda/chart_template_test.go
+++ b/charts/redpanda/chart_template_test.go
@@ -94,7 +94,7 @@ func TestTemplate(t *testing.T) {
 						// Trailing new lines are added by the txtar format if
 						// they're not already present. Add one here otherwise
 						// we'll see failures.
-						goldens.AssertGolden(t, testutil.Text, fmt.Sprintf("testdata/%s.yaml.golden", t.Name()), []byte(err.Error() + "\n"))
+						goldens.AssertGolden(t, testutil.Text, fmt.Sprintf("testdata/%s.yaml.golden", t.Name()), []byte(err.Error()+"\n"))
 					}

https://github.com/redpanda-data/helm-charts/actions/runs/10205242641/job/28235555473?pr=1460#step:5:291

Fixed, thanks for looking!


Login flow integration and manual tests

Error States
On Backup:

~invalid pin code~
~invalid passphrase~
fails on server side: error with a retry button
no internet: error with a retry button

On Recovery:

invalid pin code: you won't even get keys back, user goes back to the pin code screen saying invalid
invalid passphrase: you won't be able to decrypt the keys, user goes back to the passphrase screen
too many recovery attempts: if the user tries to recover keys more than 5 times, the server will throw an error, send user to error screen with a contact support & their unique recovery code.
fails on server side: error with a retry button
no internet: error with a retry button

On Cycle:

~invalid pin code~
~invalid passphrase~
duplicate pin code: force the user to enter a different pin code
duplicate passphrase: force the user to enter a different pin code
fails on server side: error with a retry button
no internet: error with a retry button

in progress

keys creation UI - style and clean.
automated tests for the errors in the keys creation flow.

TODO

automated testing for qr code recovery with error handling
keys pincode/passphrase recovery automated tests with error handling

automated tests are still wonky. will manual test and record results here for subsequent stories.

[x] backup

new issue: after submitting a valid passphrase the UI should move right to the creating keys animation

QR code recover: failed

app does not even present the necessary UI

remote recover: pass

new issue: add a success ui screen before cycling the pin/pass

– cycle require new passphrase: pass
new issue: update the text from "Please use a different passphrase" to something more helpful

cycle require new pin code: failed

bug: UI should stop the user from proceeding without a new pin code same as passphrase

bad passphrase on recover: fail

bug: UI should alert the user to a bad passphrase.

keys cycle: pass

new issue: add a network request animation or something like that for after submitting the backup passphrase & cycle passphrase.

too many recovery attempts: failed

does not show error just, just stays stuck on the passphrase screen

invalid pin: failed

stays stuck on the passphrase screen
new issue: wallet should return more explicit errors. currently it returns a null error for bad pin, block cipher error for bad passphrase, and the actual http response for a locked account.

no internet: failed

stays stuck on the passphrase screen

closing in favor of new, specific issues


Create example of smooth bypass

So we can demonstrate how to use special designated parameters

There are dedicated classes for this now, closing


Nix on droid

Installed app but there is bootstrap error.

On July 7, 2023 1:35:44 PM GMT+02:00, Piklubabu @.***> wrote:

Installed app but there is bootstrap error.

And what's the error?

Unable to install bootstrap. Device Is 32 bit.
On Fri 7 Jul, 2023, 5:25 PM Alexander Sosedkin, @.***>
wrote:

On July 7, 2023 1:35:44 PM GMT+02:00, Piklubabu @.***> wrote:

Installed app but there is bootstrap error.

And what's the error?
—
Reply to this email directly, view it on GitHub
https://github.com/t184256/nix-on-droid/issues/271#issuecomment-1625302205,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAU3GL6XOIZ72OCXEQ5GC6LXO72LHANCNFSM6AAAAAA2BWIJFM
.
You are receiving this because you authored the thread.Message ID:
@.***>

32 bit is not supported, sorry.


Scrape codeforces and fetch input output

Command : codemon fetch inside contest directory.

Check if the current working directory is a contest directory ? If not, display error message to cd into a contest directory.
Parse the contest number from the directory name, if contest number is not parsed, display error message to rename directory with the contest number i.e., if contest round is Codeforces Round 1234 then directory should be named 1234 or maybe round1234. Contest number should be present mandatorily.
Alternately give user option to add contest name as codemon fetch <contestName> .
After getting the contest number, go to Contest URL (https://codeforces.com/contest/1234/problems), scrape all inputs and outputs and store in respective question folder. For example, inputs and outputs of problem A should be stored in A/a.in and A/a.out respectively.

can you please assign this issue to me? @ankingcodes

@subhangi2731 - We are not assigning issues so that everyone gets equal opportunity to work on an issue. If you can fix an issue, feel free to send a PR.

@ankingcodes I have made a PR for this issue, please review.


Allow analysis of generated bundle and dependencies

This issue is a continuation from the Twitter thread discussing usage of webpack-bundle-analyzer with CRA.
webpack-bundle-analyzer can be used either as a CLI, providing it the stats.json webpack JSON output and the built files. With these, we are able to:

Show the sizes of each module as they are on disk
Show the sizes of each module after minifcation
Show the sizes of each module after minification and gzip

Here's an example I built from a project using create-react-app after first having to eject.
⏩ report.html.zip ⏪
The changes I had to do after ejecting are in this commit: https://github.com/valscion/arvontakone/commit/fbbc3069ef7a152bce6eb2087d91beeda7a9ec36
EDIT: Here's a GIF of that visualization:

Ideally this wouldn't require any changes to the CRA code, but I don't think that is possible. We'd need to at least get our hands on the stats.json that webpack can output if ran with the --json flag.
Are we able to come up with some way of gaining access to the module stats from the outside, or would it fall under the category of providing configuration and being excluded from CRA?

I highly recommend the Bundle Buddy tool from @samccone
https://twitter.com/franklinjavier/status/931324987654443008?s=17

If anyone from earlier in the discussion wants to take a gander at the code, PR is here: https://github.com/facebook/create-react-app/pull/3945

Yassss #3945 was merged so this issue can be closed, I think! :tada:
:100: :+1: work @joshwcomeau


Add tests to check for duplicate ports

Problem
No test coverage to detect if ports are duplicate between services.
Summary of Changes
Add tests for Node constructors
Fixes #

This came up as a bug that was created when we modified these functions for quic multibind. This will catch any issue with multiple ports sooner and give feedback.


Jad10309 api warning

This PR fixes the following API UX issues:

The samples are still clickable even when there's no API key.
The API warning is not reacting to API changes in runtime, for example, if there's no API key in the beginning and user enter one, the warning doesn't go away; similarly, if there's API key and user removes it, the warning doesn't appear. In general, our notification should always respond to user action in runtime instead of a static notification.

Overall, this PR does the following

[x] sample list greys out and deactivates when there's no API key on both project settings or sample viewer scene, or if users delete the API key
[x] Change the banner to warning signs per UI design, warning sign appears when there's no API key on both project settings or sample viewer scene, or if users delete the API key
[x] warning sign disappears when there's API key on either project settings or sample viewer scene, or if users enter the API key
[x] tooltip shows on hover

Can't test in UE 5.0 since this PR was done in 5.1

  Can't test in UE 5.0 since this PR was done in 5.1

which version did you test with?

Unreal 5.0 worked on my end so far. I haven't tested with 5.1 though.

Unreal 5.0 worked on my end so far. I haven't tested with 5.1 though.

Are you sure you are testing in 5.0? I get this warning when i open the project

It does not work in 5.1 and likely other newer versions. Please take a look at how I did it on the branch I sent you and make changes accordingly. I think you might be over complicating this a little bit...

I checked your branch. It appears that you're using a event tick which is expensive. Mine only check API key on event construct and when user starts typing because that's the only two times the API key might get changed. Whenever possible we should avoid using event tick.
A couple of other issues include that your warning message doesn't reappear when user starts deleting character from the original API key. The point of my PR is to make the warning message reacts to user typing in runtime. That's why I have extra steps in my PR,
As for make the warning message appear and disappear it appears you also use the set visibility node so it's the same approach as I used

Yeah, I did it on tick but that branch was for showing that it works and wasn’t intended to be merged into main unless we couldn’t find the issue.
The issue you are running into is that you are attempting to set the image variable that is on the canvas which is not allowed. You shouldn’t even need to set the image variable with the exception of in the canvas. After that changing the visibility should be enough to solve the issue.

A couple things I noticed when testing:
1.) If you put an API Key into the Make Literal Text Node in the Sample BP Game Mode the following happens (see images)

2.) If you put an API Key into the API Key Variable in the Sample BP Game Mode, it won't recognize the api key is in there at all.

@mmgaw113

this one is fixed now, good catch!
This issue is present in the original bp too, it only checks project settings and literal text node. I added another select node so that it now recognizes the API key variable.


MatPlot bug

Steps to reproduce

Do a Loop over a parameter (with not many steps)
eg data1 = qc.Loop(v1.power[1,5,1]).each(v1.trace())
Plot data using MatPlot
eg qc.MatPlot(data1.magnitude)

Expected behaviour
Hence I expect a measurements at power = 1,2,3,4 (although I also think it's worth a discussion over whether this is a bit misleading and it should include 5 but I realise that's a deliberate data acquisition decision). The plot should reflect this and have each measurement 'sweep/point' centred on the corresponding power at which it was measured.
Actual behaviour
Data acquisition is fine and plots fine in QtPlot but MatPlot shifts the data so that the centre of my power=1 data is at 1.5 etc and then my power=4 data is thrown away. In other words the plot shows data from power = 1-4 but am actually plotting data from 1=3 and shifting it all up by half so on the power axis what is shown between 1 and 2 is my data from my measurment at power=1 and so on.
Here's my actual case:

System
T5 Windows (sorry haven't checked version)
ZNB20_2 branch (merged master 8th July morning)

@jenshnielsen we did not fix this, right ?
Not sure it's a bug, rather a design flaw :P


[Suggestion] Add in support for betterUI proc chances

Ive recently downloaded the Riskymod and the main thing that is a bit annoying is the fact that betterui proc chance calculations are completely off. This could be a potential issue as better is installed by most.

It's something I'd like to do, but probably won't have the time for due to the amount of work required.


Added config file functionality + couple tests

Resolves #15
I have added some functionality to support config files. Here are some details:

If called config command, the specified config file will be read and parsed
Every key/value represents command/argument
If no input specified, the command aborts
If the specified file is not JSON, the command aborts
Config files are also parsing any future functionality that might be added, like output or lang, and ignoring them at current stage

Could you please make the update to the readme.md with the description of the new functionality?


Support History/Build configs in an immutable way

I was looking towards support for scratch containers, and I reasoned that I still wanted to use the ImageConfig type to store all of the user-supplied information, but in the case of the 'scratch' image there would be no base config. Therefore some of the required properties in a configuration would need to be specified more manually. So I elevated them to first-class fields in the ImageConfig type.
As part of that, I got around to an item I've wanted to do for a while - adding a log to the History collection in the config to trace the fact that we made one of the layers.
Here's what the history of one of our generated test containers looks like when viewed under docker history <imagename>:

Docker Desktop also has a more detailed view:

imo, with those changes on, having full model makes more sense and it looks more as it now.
However it might be easier to use ready solutions as DockerRegistryClient as discussed previously, if we need more interaction with the model.

re: DockerRegistryClient
yeah, I was thinking about that and wondering how much more source-build pain we wanted to incur :)

I added some tests, but then I started getting so many errors compiling in the build environment - I think because the net472 build is getting included in the unit tests in some way. That feels wrong. I am very confident in these changes with the tests, though.

I added some tests, but then I started getting so many errors compiling in the build environment - I think because the net472 build is getting included in the unit tests in some way. That feels wrong. I am very confident in these changes with the tests, though.

let me check it tomorrow, I think it's worth to include those tests. Feel free to merge if you need this PR earlier.

Thank you @vlada-shubina for the second set of eyes! I can wait for your findings.

Thank you @vlada-shubina for the second set of eyes! I can wait for your findings.

had to rebase to make conflict resolution easier.
previously merged PRs included net472 build for UnitTests, but ImageConfig has to be excluded.
I made it safer by removing UnitTests from net472 build and making dependency only for net7.0, however ideally it should be gone at some point.

Thanks Vlada - I agree with everything you wrote. If you're satisfied, can you approve so this can be merged?


How to use BjyAuthorize in ZF2 CLI application?

A need to run MVC application from CLI. MVC application uses BjyAuthorize very well. But how to authorize a user from command line?

Small syntax error, it's:
if (!Console::isConsole()) {
    array_unshift($config['modules'],'BjyAuthorize');
}

how to get config variable. ?

In modules.config.php:
\Zend\Console\Console::isConsole() ? 'ZfcUser' : 'BjyAuthorize'


Add Infinity Wallet Support

Added Infinity Wallet Inject support for desktop

Injected wallets are now managed through https://cloud.walletconnect.com you can either create a new entry for your project or add your unique injected flag to existing entry.

Injected wallets are now managed through https://cloud.walletconnect.com you can either create a new entry for your project or add your unique injected flag to existing entry.

Hello, we work a little difference from regular injected wallets hence why we made the PR request.


Transition from coveralls to codecov

It appears codecov.io has better integration with github. For instance, it provides visuals of code coverage changes to pull requests / commits.

Tested - done!


update worklfow:  generate & upload coverage report

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@fb942f0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage        ?   74.94%
=======================================
  Files           ?       40
  Lines           ?      942
  Branches        ?      190
=======================================
  Hits            ?      706
  Misses          ?      114
  Partials        ?      122

Flag
Coverage Δ

unittests
74.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb942f0...7649959. Read the comment docs.


Implement MissScheduleManager to support operations when miss schedule happens

Two major tasks inside missScheduleManager:

send email notification
back execution This PR only includes the thread pool and task creation. Each tasks would be taken from a task queue to execute on their own.
MissScheudleManager is controled by a feature flag: azkaban.miss.schedule.manager.enabled should help role out the feature in production clusters. Currently No real task would be put into task queue and the implementation would be in the subsequent PRs.

Pull Request Test Coverage Report for Build 7397

51 of 102 (50.0%)  changed or added relevant lines in 4 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.003%) to 44.749%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-web-server/src/main/java/azkaban/webapp/AzkabanWebServer.java
1
3
33.33%

azkaban-common/src/main/java/azkaban/utils/DaemonThreadFactory.java
4
7
57.14%

azkaban-common/src/main/java/azkaban/scheduler/MissedSchedulesManager.java
45
91
49.45%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/user/UserUtils.java
1
74.19%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractJob.java
2
37.93%

azkaban-common/src/main/java/azkaban/jobExecutor/AbstractProcessJob.java
3
54.64%

Totals

Change from base Build 7392:
0.003%

Covered Lines:
19067

Relevant Lines:
42609

💛  - Coveralls

Thank you for addressing all the comments!


cloud-galleon-pack causes that javaOpts port config isn't working for wildfly:run/dev

Hi,
the following POM doesn't respect the javaOpts port config for wildfly:run or wildfly:dev. In case I remove the cloud-galleon-pack it works as expected (e.g. Admin console listening on :9993).
<project xmlns="http://maven.apache.org/POM/4.0.0"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
	<modelVersion>4.0.0</modelVersion>
	<groupId>test</groupId>
	<artifactId>test</artifactId>
	<version>0.0.1-SNAPSHOT</version>
	<packaging>war</packaging>
	<build>
		<pluginManagement>
			<plugins>
				<plugin>
					<artifactId>maven-war-plugin</artifactId>
					<version>3.4.0</version>
					<configuration>
						<failOnMissingWebXml>false</failOnMissingWebXml>
					</configuration>
				</plugin>
				<plugin>
					<groupId>org.wildfly.plugins</groupId>
					<artifactId>wildfly-maven-plugin</artifactId>
					<!--<version>4.2.2.Final</version>-->
					<version>5.0.0.Beta3</version>
					<configuration>
						<version>31.0.0.Final</version>
						<feature-packs>
							<feature-pack>
								<location>org.wildfly:wildfly-galleon-pack:31.0.0.Final</location>
							</feature-pack>
							<feature-pack>
								<location>org.wildfly.cloud:wildfly-cloud-galleon-pack:6.0.0.Final</location>
							</feature-pack>
						</feature-packs>
						<javaOpts>
							<javaOpt>-Djboss.socket.binding.port-offset=3</javaOpt>
						</javaOpts>
					</configuration>
				</plugin>
			</plugins>
		</pluginManagement>
	</build>
</project>

(Ignore the "The server did not start within 60 seconds." this is caused by https://issues.redhat.com/browse/WFMP-244)

@martin-v , when using the cloud feature-pack, the server configuration is updated differently than on bare-metal.
The environment variable PORT_OFFSET (https://github.com/wildfly/wildfly-cekit-modules/blob/main/jboss/container/wildfly/launch/port-offset/module.yaml) is to be used in order to set a port offset.
The server shutdown in a cloud environment retrieves the offset thanks to this env variable (https://github.com/wildfly/wildfly-cekit-modules/blob/main/jboss/container/wildfly/run/bash/artifacts/opt/jboss/container/wildfly/run/run-utils.sh#L36).

I don't think actually that you will manage to run the server with a PORT_OFFSET. The cloud server is dedicated to run inside WildFly runtime docker image.
The problem is that run goal calls bin/standalone.sh although to have the PORT_OFFSET to be taken into account, the launcher: bin/openshift-launch.sh needs to be called.
I suggest that you don't build a cloud server when launching the server using the run goal.

@martin-v , I think that we could make a small change in order to have the standalone.sh be usable with PORT_OFFSET


Improvements to Renderer

more aggressively skip lighting/shadowing code that won't be
needed by the current view

Allow up to 64 KiB to be allocated from the render stream, up from
1 KiB

Renderer::renderStandaloneView() is a new method that can be used
outside of beginFrame/endFrame on Views that have a RenderTarget
associated. This can be used as a poorman's compute API.

Also your commit message isn't great since this introduces a new API.  :)   (makes it harder t owrite good release notes)

Would it make sense to change our rendertarget mirror demo to use this new API?
I'm not saying we should to thatin this PR, I'm just curious if that's a good example use case, or if this API is really more about doing compute-style stuff like cmgen.

Yes I think it would make sense -- in this case though, both ways of doing this are fine.


ion-range dualknob's position is not updating while dynamically changing their values

Bug Report
Ionic version:

[x] 4.x
Current behavior:

Dynamically update values (upper, lower) of dual knobs and the position of knobs will not change. They will stuck at the same place, although the values show that they should be somewhere else.
Expected behavior:

Change position of knobs, while changing their values.
Steps to reproduce:

Create ion-range with dual knob. Next change their values from code.
Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.2
   Ionic Framework               : @ionic/angular 4.0.1
   @angular-devkit/build-angular : 0.13.1
   @angular-devkit/schematics    : 7.3.1
   @angular/cli                  : 7.3.1
   @ionic/angular-toolkit        : 1.3.0

Capacitor:

   capacitor (Capacitor CLI) : 1.0.0-beta.17
   @capacitor/core           : 1.0.0-beta.17

@maedewiza as a workaround try to wrap your "dynamic change" in a timeout. Maybe this helps.

@maedewiza can you show your code or post a repo?

After several ionic serve, it repaired itself. Still, thank you for the answer.

I believe I have seen this behavior. Happy to research and code up a simple repo.

I can confirm I am having issues. The single range slider updates as expected. The dual slider does not. Binding via [(ngModel)] and changing the bound variable.
https://github.com/andleer/ionic4-range-bug
Ionic:
ionic (Ionic CLI)             : 4.10.3 (C:\Users\andrew.robinson\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework               : @ionic/angular 4.0.2
@angular-devkit/build-angular : 0.12.4
@angular-devkit/schematics    : 7.2.4
@angular/cli                  : 7.2.4
@ionic/angular-toolkit        : 1.4.0
System:
NodeJS : v10.15.0 (C:\Program Files\nodejs\node.exe)
npm    : 6.8.0
OS     : Windows 10

I would love to take a stab at fixing this and creating a PR. Not sure where to start but will read about it tonight... If you guys feel this is urgent, have at it.

Hi there,
Thanks for opening an issue with us! So this behavior is by design. Mutating an object will not trigger a view update, but returning a new copy of the object will. (see: https://stenciljs.com/docs/reactive-data/#updating-an-object)
The following will not work:
dualKnobElement.value.lower += 1;

The following will work:
dualKnobElement.value = {
  lower: lower + 1,
  upper: upper
}

This is not explained very clearly in the documentation, so I will be sure that gets updated.
Are you able to confirm whether or not returning a new copy of the object resolves this issue for you? Thanks!


any_connection stream customization

The new any_connection doesn't allow custom Stream types - it always uses detail::variant_stream. I'm not sure whether this is really required, since this stream is designed to cover almost all real use cases.
If your use case doesn't fit the default stream, please comment in this issue.

I strongly believe allowing this is a mistake. If you strongly need this, please comment.


Better error logging

Uses new logError function in bot.catch.
The function avoids string concatenation,
so that errors' stack trace is displayed;
it also uses console.error instead of console.log.

Thank you!


Does Qwen-VL support CPU deployment? Is there a tutorial?

欢迎参考此仓库 Native-LLM-for-Android。尽管主要面向Android，它也包含了用于导出ONNX模型及测试运行的ONNX-Python API，并支持指定CPU作为执行提供者。
Welcome to reference this repository Native-LLM-for-Android. Although primarily aimed at Android, it also includes the ONNX-Python API for exporting ONNX models and testing runs, with support for specifying the CPU as the execution provider.


Fix doc link and build bug

If we just copy in new docs then we never remove old doc files.

what's the value add? i found how our doc build setup to be obtuse, but can you explain the benefit of the change?

Rebased.

what's the value add? i found how our doc build setup to be obtuse, but can you explain the benefit of the change?

See #782.


Fix issue with using UUID primary keys in complex return types

When using a UUID as a primary key with PostgreSQL the grouping was
defaulting to the row which caused incorrect results to be returned.

Creating new pull request onto develop


Using Doctrine proxy classes

Seems like the forum discussions are not that active, so let's try this way. Original discussion is at:
http://www.concrete5.org/community/forums/5-7-discussion/location-of-the-doctrine-proxy-classes/
I'd like to hear some reasoning for the decision of the location of Doctrine's proxy classes.
Now if anyone creates package-specific or site-specific proxies, they lie in the core folder. And once the core is updated/swapped, they are all gone and would require re-generation. But there is no event we can attach to when an upgrade is made. So this could generally break things on a base-level if a package / the site takes advantage of the Doctrine proxy classes.
In my opinion better way would be to locate the whole proxies dir within the /application folder.

I'll close this one as we've now implemented it and it's already accepted to the core.


<EMAIL_ADDRESS>Prompt error can't get video stream

<EMAIL_ADDRESS>Prompt error，and can't get video stream
connect error: Network is unreachable

I think it's a problem about network.
Maybe you could try to ping "xxx.xxx.xxx.xxx" to check it


Change the default CompressionCodec.Factory to leverage compression support transparently

Describe the enhancement requested
Application code is currently required to choose upfront between handling compressed vs. uncompressed data by specifying one of the two (mutually exclusive) CompressionCodec.Factory implementations: NoCompressionCodec.Factory and CommonsCompressionFactory.
While this is totally acceptable (or even required) for the write path (e.g. ArrowWriter) it makes it really tedious to support compression on the read path, as it's not reasonable to choose between handling uncompressed-data-only and compressed-data-only when writing (e.g.) a client app for Arrow Flight.
As already reported in https://github.com/apache/arrow/issues/41457, the Java FlightClient currently fails with the following error when trying to decode a compressed stream:
java.lang.IllegalArgumentException: Please add arrow-compression module to use CommonsCompressionFactory for LZ4_FRAME
	at org.apache.arrow.vector.compression.NoCompressionCodec$Factory.createCodec(NoCompressionCodec.java:63)
	at org.apache.arrow.vector.compression.CompressionCodec$Factory$1.createCodec(CompressionCodec.java:91)
	at org.apache.arrow.vector.VectorLoader.load(VectorLoader.java:79)
	at org.apache.arrow.flight.FlightStream.next(FlightStream.java:275)

The FlightStream class does not explicitly pass a compression codec factory when creating a VectorLoader, which then uses the default NoCompressionCodec.Factory. Changing the default to CommonsCompressionFactory is not an option because:

CommonsCompressionFactory does not support uncompressed data
arrow-compression is not a dependency for arrow-vector

Instead of challenging these two design decisions, the proposed solution (upcoming PR) is to make the default CompressionCodec.Factory use a ServiceLoader to gather all the available implementations and combine them to support as many CodecTypes as possible, falling back to NoCompressionCodec.Factory.INSTANCE (i.e. the same default as today).
The arrow-compression module would then act as a service provider, so that whenever it's present in the module- (or class-) path, it will transparently fill in the gaps of the default factory.
As a side note, this is in fact the literal meaning of the above error message ("Please add arrow-compression module to use CommonsCompressionFactory"), so we can assume this might have been the original intention.
Component(s)
FlightRPC, Java

Issue resolved by pull request 43471
https://github.com/apache/arrow/pull/43471

Issue resolved by pull request 43471 #43471

@danepitkin the same applies to https://github.com/apache/arrow/issues/41457


Error: Cannot find module 'taiko' his is probably not a problem with npm. There is likely additional logging output above. npm WARN Local package.json exists, but node_modules missing, did you mean to install?

Getting the below error post running the node script
Error: Cannot find module 'taiko'
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>test:uat:EPL2LL: gauge run specs/ --tags=EPL2LL --env=uat
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>test:uat:EPL2LL script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

This should work after you run annpm install before gauge run command.
Closing this as it's an install issue. If it still does not work can you share more info with steps and version info to reproduce this error?

I have installed node,Gauge and Taiko.while running the script I am just using the command npm run tagname and post running this command i am getting the below error
Error: Cannot find module 'taiko'
and I have installed the taiko version 1.2.7

The taiko version you've installed is a global version, while the gauge run commands will need a local version of taiko installed. You need to run npm install command in the folder gauge-taiko-template

Hi Zabil,
I am getting the below error post runnig the npm install command in Gauge-taiko template.

gyp ERR! find VS
gyp ERR! find VS msvs_version not set from command line or npm config
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS could not use PowerShell to find Visual Studio 2017 or newer
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:397:5)
gyp ERR! stack     at ChildProcess.emit (events.js:400:28)
gyp ERR! stack     at maybeClose (internal/child_process.js:1055:16)
gyp ERR! System Windows_NT 10.0.18363
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--release"
gyp ERR! cwd D:\TelstraGlobal\Framework\testing-new\gauge-taiko-tests\node_modules\fibers
gyp ERR! node -v v14.17.6
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
I have installed the VS version is 1.60

Could you please let me know what i have to do ?

Looks like the error is not related to Taiko but about node and it's dependencies. There are a few answers available if you google search for the error for example.
https://stackoverflow.com/questions/57879150/how-can-i-solve-error-gypgyp-errerr-find-vsfind-vs-msvs-version-not-set-from-c


Storage json hotfix

@jsquire merge main -> this branch, resolving the issue.  Can you unblock this PR?


Recommend .NET as an extension if the notebook has a .NET kernel

Request from .NET team

Duplicate of #5651


forcing the document ID fails with "Detached document passed to persist()"

I am trying to add a document using an Id that is chosen by my application, not by the odm.
/**
 * @CouchDB\Document(indexed=true)
 */
class TestCouch {
    /** @CouchDB\Id(type="string") */
    public $id;
    /** @CouchDb\Field(type="string") */
    public $contents;
    // ... etc
}

I use
$obj = new TestCouch();
$obj->setId('test-123'); // commenting this line will work, but I will receive an ID automatically, not what I want
$obj->setContents($data);
$documentManager->persist($obj);
$documentManager->flush();

Expected behaviour
Document is saved with _id value of test-123
Actual behaviour
The error I receive is Detached document passed to persist(). which in Symfony2 also translates into a 500 Internal Server Error.

It is possible to work around this issue specifying the latest version of the document and using the merge method of the document manager.

The way around this is to to set @ODM\Id(strategy="ASSIGNED") instead of the default, which is UUID.


allow to configure i18n by bot configuration

Today it can only be configured by language, device type & connector type.
Use case: Two connectors of same type with different answers

The retained solution is to allow a configuration "by story & configuration name"

Resolves by #1041


The view is not readable

can you reproduce this in a codesandbox? i want to see what are your selector is overwriting our style.

Same here! I have an internal UI theme, so I can't publish the source. Really need a props or something to customize font and color of this devtool @bluebill1049

Same here! I have an internal UI theme, so I can't publish the source. Really need a props or something to customize font and color of this devtool @bluebill1049

Yea, too business right now, will come to that afterward.

Yea, too business right now, will come to that afterward.

Just another screenshot:

Main issue is the header at the top, which is getting our default p color, and as a result is almost invisible.
The second issue is our global table related styles which makes the table look a bit weird. I think it's mainly related to paddings, as the devtools code only override padding-right on the table cells in the first column. It should probably override all padding in all table cells.
The font itself is also different, but that's less of an issue, in my opinion.

thanks for the feedback @jsun969 is currently looking into improvement on the dev tool.

I assume the fundamental reason is your customized styles overwrite some styles of devtools component.
I will try to change the devtools to browser extension instead of component 😀

Hello 👋 I'm not sure why this was closed? I'm still seeing this issue on my end.


Add Github Action for Publishing to Comfy Registry

This PR adds a Github Action (publish-node-action) that will run whenever the pyproject.toml file changes. The pyproject.toml defines the custom node version you want to publish (added in another PR).
Action Required:

[ ] Create an api key on the Registry for publishing from Github. Instructions.
[ ] Add it to your Github Repository Secrets as REGISTRY_ACCESS_TOKEN.
More info on the registry.

Hey @Fannovel16 ! haha it's mentioned in the other PR but it's essentially a global custom nodes registry we are making for Comfy, similar to NPM or VS Code extensions that hopefully make custom nodes more reliable. The goal is to help authors better package, test, and version their nodes. We're working with Comfy Author and Dr.Lt.Data on this project and we also have a docs page here too
https://www.comfydocs.org/registry/overview
Let me know if this helps at all?


Allocations check works only within a test environment

Please run perf/allocs.jl from within the perf environment to reproduce the problem.

This has been solved by #21


#50 New processor for evaluating a DHF collector

The purpose of this processor is to invoke a DHF collector and batch up the stream of identifiers returned by the collector, with each batch being put into a new FlowFile and sent to the next processor (likely an ExtensionCallMarkLogic processor that invokes the harmonize endpoint). It includes support for using MergeContent later in the flow so it's possible to know when all of the identifiers have been harmonized.
TODO I need to add at least unit tests for a good chunk of the code in this class. Just wanted to get this out there for now.

@ehennum Going to hold off on adding tests for this until #35 is merged into develop, and then I can leverage the test support added by that.

Will submit this to https://github.com/marklogic-community/marklogic-nifi-incubator instead


Fork and cancelers

This is for discussion mainly... but is there any way we could have it so that cancelling a forked process runs the "inner" canceler? The way things are just now I think it's impossible, but unless I'm missing something, it seems like it would be a very useful thing to have happen, so maybe there's some way around it.

Actually, this is already the way it works! I thought it wasn't due to a mistake in the alt stuff I was working on.


Support demucs v4

demucs v4 has released.
Is there any plans of supporting it?
Thanks!

Hi, thanks I'll probably look into it - it's still bleeding edge/hasn't been published on PyPI so it might not be 100% stable

Just added support for v4 in the latest update 🙂


add docker image & CI

Thank you so much for your PR! It looks good to me.
Before merging it to master branch, could you please do a few trivial changes?

Could you please have a look on https://deepsource.io/gh/Endle/fireSeqSearch/run/47b09457-8a30-46cc-ba35-41c891da5174/rust/RS-W1031?listindex=0  If you have a strong reason to ignore this warning, could you please add a comment for it?
In the README file, could you mark the Docker method as experimental? I'll remove this tag later when the Docker release works good
Could you please add a quick note in README about how to use the Docker image without docker-compose? Besides, I'm a bit in doubt that if docker-compose could benefit fireseqsearch a lot, but I'll accept your proposal for adding a docker-compose.yml file

Thank you again for your contrib. Happy New Year!

@Endle comments resolved & Happy New Year!

Hmmmm DeepSource is even more pedantic than clippy...

Thank you for your work.
I'm sorry that I'm asking for one more change: Could you please revert to https://github.com/Endle/fireSeqSearch/pull/101/commits/31ef8cd5b52dd6f894498e262e9269178241680d ?
I'm very grateful for the style fix, but I prefer to split the style fix and the actual commit in different PRs to reduce review work, and make the git history clean.


Add verify method to secp256k1.PublicKey

Is your feature request related to a problem? Please describe.
It is not possible to verify if a []byte is signed by a public key.  This is a problem, when determining the public key from an address and there are multiple different public key possibilities due to the protocol allowing different key types.
Describe the solution you'd like
Implement Verify(message, sig []byte) bool  on secp256k1.PublicKey. Use secp256k1test package to test signed messages with both sofia and charlotte keys. This will mean that the validity of the signed data against this public key / key type can be verified.
Describe alternatives you've considered
N/A
Additional context
N/A

Test don't work on secp256k1
# command-line-arguments [command-line-arguments.test]
./public_test.go:41:31: undefined: charlottePublicKey
./public_test.go:43:4: undefined: charlottePublicKey
./public_test.go:49:24: undefined: charlottePublicKey
./public_test.go:51:4: undefined: charlottePublicKey
./public_test.go:59:4: undefined: charlottePublicKey
./public_test.go:67:4: undefined: charlottePublicKey
./public_test.go:89:16: undefined: PublicKeyFromHex
./public_test.go:122:20: undefined: ecdsaPrivateKeySofia
./public_test.go:123:21: undefined: ecdsaPrivateKeySofia
./public_test.go:143:16: undefined: ecdsaPrivateKeySofia
./public_test.go:143:16: too many errors
FAIL	command-line-arguments [build failed]
FAIL

@developerfred can you try running go test github.com/mailchain/mailchain/crypto/secp256k1

This can now be completed as #375 has been completed #373 provides a good example of how this can be implemented. Especially with the unit tests.

Is anybody working on this ? If now can I be assigned ? :)

Thanks @Despire I have assigned you.
Checking with @developerfred in case any work was started, but I have seen anything.

@Despire

Is anybody working on this ? If not, can I be assigned ? :)
You can do this feature, thanks for the reminder.

@developerfred seems like you already done pretty much all the work :) are you sure you don't want to finish it ?

closed by #416


Having issues with nested tabstop

snippet pT "Description" b
paddingTop: ${1:theme.spacing($2)},
endsnippet

Previously to the switch to cmp, i had this mapping that allowed to either replace completely $1 by typing or filling $2 by tabbing when on $1, this doesnt work anymore as I can t seem to tab to the next.
Can someone helps please as this was very useful for me.
Thanks !

Thanks for reporting, this issue with select-mode mappings was bugging me for a while and I am glad you brought it up again! Please also read the Known Issues section in the readme since you need to set an UltiSnips variable.
Related: #5.


Addressing #24 and #28 in catalog cleanup

Closes newrelic/nr1-customer-journey#24
Closes newrelic/nr1-customer-journey#28
removes moment lib
uses nr1-community lib

:tada: This PR is included in version 0.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Collaboration with universities

Some work can be relayed into universities: tutorials, benchmarking, seminar, etc, etc.

do you have any other thoughts on this one?  How do we reach out to these universities?  Any particular suggestions?

do you have any other thoughts on this one? How do we reach out to these universities? Any particular suggestions?

Have some contacts in Kuala Lumpur, if we're interested.
The guys here are hungry for technology.
I could offer them series of meetups or hands-on workshops
@randybias @mkraposhin

I think this a great idea. Maybe we can arrange a small meeting with them?

I think this a great idea. Maybe we can arrange a small meeting with them?

I will try to reach them and propose our service.
Can I speak on behalf of the community?

I think this a great idea. Maybe we can arrange a small meeting with them?

I will try to reach them and propose our service. Can I speak on behalf of the community?

Sure )


Licensing information

Thank you very much for posting this project!
Would you mind providing the licensing information for this repository?

Added, it's under MIT license!


Allow custom logstash plugins.

This uses a format that's slightly different from the one used for elastic and kibana plugins, but it's useful to be able to specify arbitrary arguments to the installer like --version. WDYT?

Hi @jmcarp and happy New Year!
What's the status of signing CLA from your side? Did our lawyers had a chance to talk?

Hi @axelaris, and happy new year to you too!
From David Schachner at Pivotal on 12/21/2016:

Apologies for the delayed response. Work is already underway to revise the CLA so that it accounts for the public domain use case you've raised.
In the meantime while this effort is underway, we can advise our project teams to accept your pull requests without CLA acceptance as long as you clearly mark your contributions with a public domain dedication.
Thanks again for bringing this issue to our attention!

Can you perhaps check with him to confirm?

Sorry, I had your CLA confused with Pivotal's. I'll check!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Merge conflicts resolved.

@Infra-Red: can I trouble you to take a look at this when you have time? Looking forward to building this release from upstream and not from our fork 😄

Thanks for catching that mistake, just reverted it.

LGTM after fixing. Thanks @jmcarp


Multiple unit tests seem to fail

./gradlew test results in failure for multiple unit tests:

FileInfoTest
AccountInfoTest
ContractUpdateTransactionTest
MessageSubmitTransactionTest

i am running all the tests fine with ./gradlew test right now


Powertool's Shortcuts incuding the powertool shortcuts

Description of the new feature / enhancement
I would suggest that when opening the shortcut menu (defult command win+shift+/) it also displays the shortcuts from powertools. eg. colour picker (defult win+shift+c) this should ajust itself depending on what things are enabled. ie. anything not enabled is hidden or grayed out.
Scenario when this would be used?
The shortcuts display is very usefull but it is hard to remember all the powertools shortcuts as well.
Supporting information
No response

/dup #890


excel.save() method seems unavailable

First of all, thanks for providing this extremely convenient piece of software for free here.
Everything seems to work fine, yet I find myself unable to export a generated document. In the documentation, it says that I should be able to call save() on an excel document, but this method seems unavailable.
In my pubsbec.yaml I'm using ^1.1.5. My code looks like this:
   var excel = Excel.createExcel();
    excel.rename('Sheet1', 'Excel test');

    Sheet sheet = excel['ExcelTest'];

    // Setup Top bar
    var titleCell = sheet.cell(CellIndex.indexByString('A1'));
    // More logic to setup the Top Bar

    // Add data
    for (var i = 0; i < data; i ++) {
      CampaignRecord record = campaigns[i];

      // Logic that sets data in the right column and row
    }

    // Save
    var data = await excel.save(); // UNAVAILABLE

I now implemented this solution, but when I try to open the document it generates, Excel says it's damaged and it shows data in the wrong cells.
What am I missing?

@joris1995
Please give me 1 to 2 days, I'll update the latest stable version on the pub.dev.
~ Best
~ Long Live 🔥pen Source

@justkawal Perfect! Thank you so much 🤩

@joris1995
Anytime ✌✌

Hi, just checking in, Do you have any update on when a patch including the .save() method will be available?

Hey joris1995, I've used encode() instead of save(). Maybe this helps.
excel.encode().then((fileBytes) async {       Future<Directory> _getDownloadsPath =           DownloadsPathProvider.downloadsDirectory;       var downloadsDir = await _getDownloadsPath;       var dowloadsPath = downloadsDir.path;       File(join("$dowloadsPath/test_wrap.xlsx"))         ..createSync(recursive: true)         ..writeAsBytesSync(fileBytes);

Works like a charm! Thanks

@justkawal till when we can expect the save function?

@surveshoeb The save function will be available by the end of the month. in Null-safe and non null-safe version.


[BUG] Fail to patch CCCL in versions.json

When compiling spark-rapids-jni, patching CCCL is faling:
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff cccl_symbol_visibility.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/cccl_symbol_visibility.diff': No such file or directory
[INFO]      [exec] --
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_disable_64bit_dispatching.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_disable_64bit_dispatching.diff': No such file or directory
[INFO]      [exec] --
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_faster_sort_compile_times.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_faster_sort_compile_times.diff': No such file or directory
[INFO]      [exec] --
[INFO]      [exec] -- rapids-cmake [CCCL]: failed to apply diff thrust_faster_scan_compile_times.diff
[INFO]      [exec] -- rapids-cmake [CCCL]: git diff output: error: can't open patch 'jni/thirdparty/cudf-pins/thrust_faster_scan_compile_times.diff': No such file or directory

Without patching, the build still proceeds successfully but there may be potential issues with the built binary due to non-patching CCCL.

${current_json_dir} is evaluated at runtime and points to the directory holding the current JSON file, which actually should target to the cudf path https://github.com/rapidsai/cudf/tree/branch-24.12/cpp/cmake/thirdparty/patches

@robertmaynard this appears to be a bug in the rapids-cmake code that generates versions.json when patch files are referenced for a dependency.  It's using ${current_json_dir}/ for the patch file locations, when they are not co-located with versions.json.  Seems like ${current_json_dir} should be expanded, per dependency, when emitting this file.


Fix flow generate transaction template

Closes #1763

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.68%. Comparing base (f99a061) to head (34a8b5a).

Files with missing lines
Patch %
Lines

internal/super/generate.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   29.68%   29.68%
=======================================
  Files          89       89
  Lines        5191     5191
=======================================
  Hits         1541     1541
  Misses       3463     3463
  Partials      187      187

Flag
Coverage Δ

unittests
29.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Component remounting and refetching data on client side in case of usage async components import

Versions

v2.14.6

Reproduction
https://codesandbox.io/s/crazy-browser-fw1wo?file=/components/ArchiveFetcher.vue
Steps to reproduce
data() {
    return {
      fetchedPosts: [],
    };
  },
  components: {
    //CountriesList,
    CountriesList: () => import("~/components/CountriesList"),
  },
  async fetch() {
    if (process.server) {
      let url = "https://jsonplaceholder.typicode.com/posts";
      console.warn(url, "Archive fetching");
      try {
        this.fetchedPosts = await this.$axios.$get(url);
      } catch (err) {
        return this.$nuxt.error({ statusCode: 404, message: err.message });
      }
      console.log(this.fetchedPosts); - return array of posts
    }
  },
  mounted() {
    console.warn(this.fetchedPosts); - return [];
  },

Async import component and try to use it with server-side data.
What is Expected?
Expected the same behavior as default components import, without remounting\refetching on the client.
What is actually happening?
When we use such construction (async components import) - the component is filling with data on the server-side, but then it looks like remounting on the client without any data and trying to fetch it again.
When I import a component in the default way, it works as expected, without losing data on the client.
I hope I describe the issue clearly enough, but let me know if you need any additional info.

+1
I'm seeing the exact bug on v2.14.12

+1
I'm seeing the exact bug on v2.14.12

+1
It seems like imported component should used as root component in the template
@ikoshele as temp solution you can try to wrap countriesList in to div
<tempalte>

    <countries-list>
      ...

+1
It seems like imported component should used as root component in the template
@ikoshele as temp solution you can try to wrap countriesList in to div
<tempalte>

    <countries-list>
      ...


Automated cherry pick of #8812: fix: avoid create bucket missing appid

Cherry pick of #8812 on release/3.5.
#8812: fix: avoid create bucket missing appid

Codecov Report

Merging #8813 (bf0cfbb) into release/3.5 (e3fe6c4) will decrease coverage by 1.81%.
The diff coverage is 0.26%.

@@              Coverage Diff               @@
##           release/3.5   #8813      +/-   ##
==============================================
- Coverage         6.03%   4.22%   -1.82%
==============================================
  Files              795     162     -633
  Lines           124282   24794   -99488
==============================================
- Hits              7503    1047    -6456
+ Misses          116114   23655   -92459
+ Partials           665      92     -573

Flag
Coverage Δ

aFlag
4.22% <0.26%> (-1.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/domainresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/modelbase.go
4.51% <0.00%> (-0.08%)
:arrow_down:

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/orderby.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/virtualresource.go
0.00% <0.00%> (ø)

pkg/cloudprovider/securitygroup.go
0.00% <ø> (ø)

pkg/compute/regiondrivers/aliyun.go
0.33% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/regiondrivers/base.go
1.03% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/regiondrivers/esxi.go
6.38% <0.00%> (-36.48%)
:arrow_down:

pkg/compute/regiondrivers/huawei.go
0.21% <0.00%> (-0.01%)
:arrow_down:

... and 575 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff7be6...bf0cfbb. Read the comment docs.


Added Data Augmentation.ipynb

This is interesting and useful work, but I am afraid at the moment it is a bit bare-bones. If you have the time, I would like to see this fleshed out a bit more. For example, you do not explain the techniques used here at all, you simply show as the code. I think the notebook would benefit massively from some description.

This is interesting and useful work, but I am afraid at the moment it is a bit bare-bones. If you have the time, I would like to see this fleshed out a bit more. For example, you do not explain the techniques used here at all, you simply show as the code. I think the notebook would benefit massively from some description.

Can you be a bit more specific about "explaining the techniques" please! Should I describe (logic) the code used in all cases or describe the sub-parts of each augmentation type like elaborating each type of blurring , noise used in the notebook or both? It would help in making the appropriate changes. Thanks for the review!

I would say you need to give the reader the background information on the technique (for example, what is 'translation'), the code doesn't need to be explained too much. It's mostly the theory that is lacking.

Sure thanks!

Also, I tried to close-reopen the PR (so that the tests would be rerun), but for some reason Github is glitching and I cannot reopen it.
Can you try opening it?

Oh, I think the problem is that you deleted your fork. I am afraid you have to create a new one, in this case.

Yes I did delete the fork by mistake but creating a new pr wouldn't be an issue as i have the notebook backed-up locally.
Will do it after the suggested changes have been made!


Update free-courses-fa_IR.md

Added a section for C# language.
Added a subsection for the .NET Core framework.
Added a beginner's course for the ASP.NET Core 5 framework.
What does this PR do?
Add a course , a section and a subsection
For resources
Why is this valuable (or not)?
It helps people who are interested in starting to learn .NET
How do we know it's really free?
You can get that course by registering on the site
For book lists, is it a book? For course lists, is it a course? etc.
it is a course
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Thanks, and welcome to free-programming-books!


Modify risk description

In the risk description, users can use 'force exit' to exit. it looks like a shortcoming, and we believe it is necessary to emphasize that this is a design feature. We suggest modifying it as follows.
"However, fortunately they can still exit the system."

In addition, we modify a section of text that was not very fluent.

@BergDev22 i made some changes because i didn't like the word "fortunately", it gives a subjective feeling while the presence of the mechanism is not. wdyt?


[WIP] Replaced SlickGrid with PatternFly in Control -> Import/Export

@skateman Tested. Looks good.

@miq-bot remove_label wip


Make sure containers always is cleaned up on test failures

After running the tests a handful of times ....

I see they are cleaned up after normal test failures. If the waiting strategy fails or similar, not so much


updating the dsHost test spec

Review request for the test spec document

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix last PR

This PR will resolve bugs that my last PR introduced

remove duplicated function
fix bug from mobile

Confirmed. This fix works well. Good job and thank you @doppiam !

Thank you very much for contribution, i really dont have time to maintain this project ATM.

i made a thanks note for everything you did in readme. thanks again


issuer/route53: fix delete for 'NotExist' errors

Fixes #736.
Prior to this change, it was quite possible to end up with a queue of
cleanup tasks that would never succeed.
Release note:

Fixed Route53 cleanup errors for already deleted records.

Running ./hack/update-deps.sh isn't providing any diff for me here despite the verify fail.
I'm using:
$ dep version
dep:
 version     : v0.4.1-264-g45be32ba
 build date  : 2018-07-17
 git hash    : 45be32ba
 go version  : go1.10.1
 go compiler : gc
 platform    : linux/amd64
 features    : ImportDuringSolve=false

I ensured I was on a completely clean checkout of this PR.
I assume this is due to a difference in dep version.

Also make sure you rebase onto master too. Our CI tests against the result
of merging your changeset with master, so if anything has changed you'll
see this kind of behaviour.
FWIW, this is where the image for that test is defined:
https://github.com/jetstack/test-infra/blob/master/images/gcloud/Dockerfile#L39
On Thu, 19 Jul 2018 at 19:21, Euan Kemp<EMAIL_ADDRESS>wrote:

Running ./hack/update-deps.sh isn't providing any diff for me here
despite the verify fail.
I'm using:
$ dep version
dep:
version     : v0.4.1-264-g45be32ba
build date  : 2018-07-17
git hash    : 45be32ba
go version  : go1.10.1
go compiler : gc
platform    : linux/amd64
features    : ImportDuringSolve=false
I ensured I was on a completely clean checkout of this PR.
I assume this is due to a difference in dep version.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/jetstack/cert-manager/pull/746#issuecomment-406369790,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbPyL7ezYjyhP-LRZa0H4mXXmWAQeqks5uIM4_gaJpZM4VWyyU
.

Reverting dep back to 0.4.1 seems to find the verify issue this was hitting. I find it quite an odd issue though; I'm surprised the input digest changed even though I didn't change "Gopkg.toml" at all.

/approve

/lgtm


Height of an embedded Dashbaord

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

When I am trying to embed a dashboard into a webpage using an iframe, I am not able to determine the height of the iframe so that it exactly matches the height of the dashboard to prevent a scrollbar from appearing inside the iframe without cropping it.
The dashboard and web page that contains the iframe are NOT on the same domain.

Am I missing something ? Or, is this a feature request ?
I have also found a workaround but that involves the dashboard sending a cross-domain message upon changing it's height.
I'm not sure if I'm the only one not able to figure this out or no one else is asking this.
Superset version
0.25.6
Expected results
Uncropped dashboard
Actual results
Cropped dashboard
Steps to reproduce
iframe code

javascript code

The 2 errors I get in the console are
1- Invalid 'X-Frame-Options' header encountered when loading 'http://<IP_ADDRESS>:8088/superset/dashboard/5/?standalone=true': 'ALLOW-FROM http://<IP_ADDRESS>' is not a recognized directive. The header will be ignored.
2- Uncaught DOMException: Blocked a frame with origin "http://<IP_ADDRESS>:8000" from accessing a cross-origin frame.
at resizeIFrameToFitContent (http://<IP_ADDRESS>:8000/scenario/:23:46)
at HTMLIFrameElement.onload (http://<IP_ADDRESS>:8000/scenario/:11:118)
resizeIFrameToFitContent @ (index):23
onload @ (index):11

The good thing about this is that we do not have to reinvent the wheel, all we need to do is add a javascript file from an existing library that sends the cross-domain message.
For example - [http://davidjbradshaw.github.io/iframe-resizer/](This one)
It simply needs one .js file to be placed in the dashboard HTML which sends the message.

Never mind, I have figured it out... If anyone else needs help with this, drop me a message...

Have you modified  HTTP_HEADERS on Superset config.py?
HTTP_HEADERS = {'X-Frame-Options': 'ALLOWALL'}

I have a question that might be out of topic,

@paritoshjchandran , Request you to provide  full solution on this issue, we too tried to embed super set demo dashboard in one of our client app, and superset demo is having a scroll

Whether IframeResizer file need to be placed under which directory i.e iframeResizer.contentWindow.min or iframeResizer.min and where the reference of this file should be embedded
In which file "" will be called and where to include script to call "iFrameResize({ log: false }, '#supersetDemo');"

A bit old but if you look at the superset embed SDK's embedDashboard it returns a callback:
// ...
return {
    getScrollSize,
    unmount,
    getDashboardPermalink,
    getActiveTabs,
  };
}

So you can call it to get the height:
useEffect(() => {
  const dashboard = embedDashboard();
  const { width, height } = await dashboard.getScrollSize();
  // proceed to use height in your page!
})


fix: handle case when whitespace on one side of interpolation

Fix #335

It's not directly the subject but can we add a assertTrue for the pipe like this :
  it('should work when space before and after "|"', () => {
      let source = `
      @Component({
        selector: 'foo',
        template: \`
          <div>{{ foo | async }}</div>
        \`
      })
      class Bar {
        foo: any;
      }
      `;
      assertSuccess('angular-whitespace', source);
    });

In a future release, we can manage the chain of pipes like this {{ foo | async |      bar }} ?


New  tag problem.

Thank you for your tough work. The last issue was fixed but I noticed some new problems, they might appear from v0.3.1. Below I took examples from my repository. All of them is similar, <em> tag, problem. \mathscr{...} is problematic?
$\bigcap_{\lambda\in\Lambda}\mathscr{F}_{\lambda}$
$(Y_{i}, \mathscr{G}_{i})$
$f_{i}\colon X\rightarrow Y_{i}$
$h^{-1}(f_{i}^{-1}(G_{i}))\in\mathscr{H}$
$(f_{i}\circ h)^{-1}(G_{i})\in\mathscr{H}$
$(\prod Y_{i}, \prod\mathscr{G}_{i})$
$\lbrace g_{ij}\circ f_{i} : i\in I, j\in J_{i} \rbrace$
$V\cap W\in\mathscr{A}_{\neg S}$
$\mathscr{V}\neq\mathscr{U}_{j}$
$\mathscr{U}_{j}$
$U_{j}\in\mathscr{U}_{j}$
$U\in\mathscr{U}_{1}\cap\dotsb\cap\mathscr{U}_{n}\subset\mathscr{V}$

@mathmathniconico by any chance is this repo of yours public? If so, do you mind sharing the link here? Thanks!

Here. But it's not written in English so you may not be able to read.
https://github.com/mathmathniconico/Notes
Above list can be found in Notes/ConvergentSpace


Add assert too Opnd::Free to ensure it is not in use

@sigatrev,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

LGTM, as long as all tests are run for a long time.

:shipit:


fix(iam-group-with-policies): Typo "enforcment" to "enforcement"

enable_mfa_enforcment should be enable_mfa_enforcement
https://github.com/terraform-aws-modules/terraform-aws-iam/blob/f537b20bb4d31f014c1c63a5b4151177aed694e0/modules/iam-group-with-policies/variables.tf#L37
Description
As far as I know, the word "enforcment" does not exist.
Motivation and Context
It offends the editor's spell checker, etc., so I fixed it.
It is a minor correction and has not been issued.
Breaking Changes
If any user is already using this argument in this module, it may need to be modified.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This issue has been resolved in version 5.27.0 :tada:


Jump to bottom Not showing thumbnail of YouTube feeds in flym app,

Not showing thumbnail of YouTube feeds in flym app .

Can you share a link of such feeds?

The app is showing shot brifing but there is not photo. The link is YouTube link.

All of my YouTube feeds are not supporting thumbnail. The feeds are
In opml form.
On Sun, 7 Jan 2024, 23:21 Marco Gomiero, @.***> wrote:

Can you share a link of such feeds?
—
Reply to this email directly, view it on GitHub
https://github.com/prof18/feed-flow/issues/107#issuecomment-1880121119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWGG5HQOF6D6LSO2EMHUINTYNLMKHAVCNFSM6AAAAABBQOV5OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGEZDCMJRHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Use scalapb 0.8.4, grpc 1.18.0, and dependencies

Yikes, V0.17.1 on Mac failed because of a network glitch: Unknown host: central.maven.org All other builds went green.

See https://github.com/bazelbuild/rules_scala/pull/691/files#diff-c7a717982f375d79e93079335dc26d4cR236

Thanks!


0.8.0 snapshot

Replace Mahout Math with Spark DataFrame manipulations, check for accuracy and speedups.

hmm, does not update the diff when new commits are made to 0.8.0-snapshot so re-create the PR?????


Allow conduits to decide what items they can accept as filters/upgrades

Implements the TODO about isFilterUpgradeAccepted in InventoryUpgrades
I ran into some issues while attempting to make a custom filter for a new set of conduits I am implementing and tracked it down to this in InventoryUpgrades.java
// TODO make a way to do this based on the conduit
private boolean isFilterUpgradeAccepted(@Nonnull ItemStack stack, IConduit con, boolean isInput) {

I decided to implement the TODO so that custom conduits can decide for themselves if they can accept a stack as a filter. While implementing this change I also ran into a few bugs where filters/upgrades could be voided in some conduits by shift clicking them in. For example, Redstone Conduits voiding speed upgrades, and Pressurized Liquid Conduits voiding fluid filters. This pull has the side effect of also fixing those bugs.
This pull changes InventoryUpgrades so that only classes that implement IFilterHolder can accept filters, and only classes that accept IUpgradeHolder can accept upgrades.
How it does this:

IFilterHolder has a new default method boolean isFilterUpgradeAccepted(@Nonnull ItemStack stack, boolean isInput), that allows Filter Holders to specify if they consider an ItemStack a valid filter. This method defaults to false.
IUpgradeHolder has a new default method boolean isFunctionUpgradeAccepted(@Nonnull ItemStack stack), that defaults to true. This means that any conduit that also is an Upgrade Holder can accept any upgrades, but also allows for them to be more restrictive if they choose to check additional information about the ItemFunctionUpgrade. Before this method is called InventoryUpgrades ensures that the stack is an ItemFunctionUpgrade so as to ensure that the stack is some form of Function Upgrade.

This looks fine at a glance. I'll test it more later today when I'm at home. What conduits asre you working on out of curiosity?

Mekanism gas conduits (as I know from reading that you guys don't want to deal with all the issues that would come from including them). I am putting/will put messages all over the place basically saying to report the issues to me rather than to either EnderIO or Mekanism directly. But it is just so nice being able to have two paths of wires/cables cross for compact machine setups that I decided to just do it myself in its own addon.

Sounds good. I was guessing that. Give me a buzz if you need any help with it. It should be pretty straightforward. My personal preference would be for them to match the fluid conduit tiering but it's up to you.

Ok, and I mostly have them matching the fluid tiers as I used the fluid code as a base to figure out how to add new conduits. However, I made it so that it is a little more in line with the Mekanism pressurized tubes when it comes to how much gas each can transfer by default so that it remains a viable alternative.


move to protodef org?

now that we're using this in prismarinejs for most stuff; what do you think of moving this repo to protodef org?

Sure


Custom width and height for Cards.

Currently the width and height are hard coded in the FrameLayout. This needs to be address if developers require to customize their layout. For e.g. changing the height of the card in card.xml or settings_card.xml does not have changes on the UI.

You could probably make setters, allowing developers to set custom width and height as you have it for CardGap and CardGapBottom.

Hey @OmkarAmberkar, that's a good suggestion! Would you mind raising a PR with the changes? We'll be happy to review and merge it :)

Sure 👍


Provide Documentation

Hi,
It would be nice to have proper JavaDoc information for each method (which is exposed to the public API).
Reading a JavaDoc header when using the library is much more convenient instead of digging through all the code to see what a method actually does.
Regards

Hello, actually this library used for my own project. But since it's on github and probably other people want to use it, I'll considering about that.


build: update to tagged versions of stringset and shell

Rather than pinning to specific random commit hashes, point to the release tags
for these libraries. This required a small change to the shim, which did not
handle the tag/commit combination quite correctly.
More libraries could probably productively be pinned this way, and it is
generally safer to do so since that's how Go modules will do it too. For now,
though, I'm just doing the ones I know the versions for.

Please update the go.mod module file as well.

What is the best way to do that? Last time I tried doing a go build and go mod tidy it made a lot of unrelated changes.

Please update the go.mod module file as well.

What is the best way to do that? Last time I tried doing a go build and go mod tidy it made a lot of unrelated changes.

Nevermind, I was able to update those packages individually without breaking anything.

git checkout go.mod
rm -f go.sum
go mod edit<EMAIL_ADDRESS><EMAIL_ADDRESS>go test ./kythe/...


fix starlink-grpc-go module hashsum

the old module version was invalid, leading to:
"go: [...] invalid version: unknown revision b37157d46ec6"

Ah ... i see that this fix is a duplicate of https://github.com/starlink-community/starlink-cli/pull/2, which did not have any activity since Jan 27, 2023.
Is this repo still active?


call success but getting From null and To null and when connecting call getting url music playing continuously

how can i solve to get my voice instead of mp3 used in twiml app

@Raj-impetrosys see https://github.com/diegogarciar/twilio_voice/issues/105#issuecomment-1260941399, could be useful.

Closing due top lack of responses, feedback or activity.


Inverted rflink cover

Breaking Change:
The configuration has to be updated when KAKU (newkaku) ASUN-650 covers are used. The 'type' property has to be specified and set to 'standard' when these devices have been wired 'the other way around'.

Description:
A class named InvertedRflinkCover has been added that inverts the commands to the KAKU (COCO) ASUN-650 devices. Also a property named 'type' has been added to the RflinkCover class that allows 2 values: 'standard' and 'inverted'. The InvertedRflinkCover class is used when:

The RflinkCover class detects 'newkaku' device and the type property is omitted.
The type property is set to 'inverted'.

Related issue (if applicable): fixes #10810
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10177
Example entry for configuration.yaml (if applicable):
cover rflink:
  - platform: rflink
    devices:
      newkaku_xxxxxxxx_x:
        name: kaku_inverted_by_type
        type: inverted
      newkaku_xxxxxxxx_y:
        name: kaku_not_inverted_by_type
        type: standard
      newkaku_xxxxxxxx_z:
        name: kaku_inverted_by_default
      nonkaku_yyyyyyyy_x:
        name: non_kaku_inverted_by_type
        type: inverted
      nonkaku_yyyyyyyy_y:
        name: non_kaku_not_inverted_by_type
        type: standard
      nonkaku_yyyyyyyy_z:
        name: non_kaku_not_inverted_by_default

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

I can't figure out yet why CI (Tests PyTest Python36) and CI (FullCheck Pylint) are failing.

Seems related with some merged code from dev branch:
tests/components/updater/test_init.py:151

@javicalle , are my tests failing because of #26187?
I also noticed that the Pylint test fails when setting up the environment.
ERROR: Could not find a version that satisfies the requirement bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)) (from versions: 0.0.1, 0.0.3, 0.0.4, 0.1.0, 0.2.0, 0.3.0, 0.4.0.dev0, 0.4.0, 0.4.1, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.9b0, 0.5.9b1)
ERROR: No matching distribution found for bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)))

Is this something I can/should fix or should I commit a change to trigger the tests again?

Also may be related with some code merged from dev branch.
What I would try is to review the 'files' that fail, see if there are
changes in the dev branch, make the merge only of those changes and commit
from my branch to force the execution of the tests.
I'm sorry not being able to help more.
El dom., 25 ago. 2019 14:25, fmartens<EMAIL_ADDRESS>escribió:

@javicalle https://github.com/javicalle , are my tests failing because
of #26187 https://github.com/home-assistant/home-assistant/issues/26187?
I also noticed that the Pylint test fails when setting up the environment.
ERROR: Could not find a version that satisfies the requirement bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)) (from versions: 0.0.1, 0.0.3, 0.0.4, 0.1.0, 0.2.0, 0.3.0, 0.4.0.dev0, 0.4.0, 0.4.1, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.9b0, 0.5.9b1)
ERROR: No matching distribution found for bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)))
Is this something I can/should fix or should I commit a change to trigger
the tests again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/26038?email_source=notifications&email_token=AHUEP7ONUKBZRKOO2VTDR43QGJ22HA5CNFSM4IMRS4X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CSQVY#issuecomment-524626007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHUEP7MHGMYLAE2WMZTLFHDQGJ22HANCNFSM4IMRS4XQ
.

@javicalle , thanks for all the support.


Typo in the code: key specifying the name of the folder

https://github.com/googleworkspace/python-samples/blob/bc61a48f13f1e29d4ded0c66bc7e244b0417b928/drive/snippets/drive-v3/file_snippet/create_folder.py#L38-L41
I think the string in the key specifying the folder name is 'name', not 'title'
file_metadata = {
    'name': 'Invoices',
    'mimeType': 'application/vnd.google-apps.folder'
}

This typo is critical in my opinion.
I had to search for hours to find why the Folder was not named correctly
Pls change
Also, this comment seams wrong:
https://github.com/googleworkspace/python-samples/blob/bc61a48f13f1e29d4ded0c66bc7e244b0417b928/drive/snippets/drive-v3/file_snippet/create_folder.py#L35-L37
Arent we creating an drive api client here?
edit: there is a pull request to change the comment, but not the dict key

This typo is critical in my opinion.
I had to search for hours to find why the Folder was not named correctly
Pls change

Thank you for reviewing the issue.
Yes, I also found a typo (gmail->drive) in the comment, but I didn't raise the issue because the pull request has already been submitted.

im not sure but i think the only pull request i found was for a different file with the same typo.
👍


Corresponding inheritance models to R's VariantFiltering

Hello,
I am moving my code from the R package VariantFiltering to Gemini. The following table has the inheritance models from VariantFiltering and the corresponding models in Gemini:
VariantFiltering	Gemini
autosomalRecessiveHomozygous	autosomal_recessive
autosomalRecessiveHeterozygous	comp_het
deNovo	de_novo
xLinked	(x_linked_dominant/x_linked_recessive)?

Is the conversion correct? I am not sure if VariantFiltering's xLinked is Gemini's x_linked_dominant or x_linked_recessive. Can you clarify?

based on the descripton for their xLinked:
This function identifies variants that appear only in the X chromosome of the unaffected females
as heterozygous, don’t appear in the unaffected males analyzed and finally are present (as homozygous)
in the affected male(s).

that appears to be x-linked-recessive
otherwise, yes, your conversion seems reasoable on quick glance.

Alright thanks!


Hard to reproduce result

Hello,
I ran your baseline system with weight sharing and without discriminative loss, I only got BLEU-4 around 25.6 instead of 28.2 reported in the paper. May I ask you how many epochs did you train your model ? I trained it for 3-4 epochs and then it converges somehow.

It seems that you didn't do beam search? What's your command to run the code?
I tried it myself and it can reproduce the exact numbers.

Oh, I see ! I saw this score from printout information during training on the validation set, I didn't use reason_att_eval.lua to evaluate, I will try it out now.


Audio PR 3 - One Augmentation support [PreEmphasis Filter]

Contains the changes needed in MIVisionX for PreEmphasis Filter

@swetha097 The update destinantion ROI is not required in this PR I feel, if required we can have a call to discuss this


docs: doc limitations

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1567  👈 (View in Graphite)
#1558
#1551
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Replaced str with Path

Checklist

[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Changes
In Rust, whenever dealing with the file system, it is recommended to use the Path and PathBuf structs instead of str and String. In the burn code though, str is often used to describe a file path or a directory. This PR changes these instances to use Path.
Testing
Since str can be safely converted to Path, this is a drop-in replacement for the previous code. Aside of running ./run-checks, I've also tested it on an external project.

Thanks for fixing. Once the CI testing is fixed we can merge

Merged. Thank you very much for your contribution!


part of the folder after "." goes to "ext" instead of "basename"

I noticed that in the latest ammonite a controversial decision to split path.name into baseName and ext was made. The main problem here is that if I have a folder with "." as part of the name, like "part.one.two" the baseName becomes "part.one" while ext becomes "two". I think that extension is File-specific thing and baseName should be "part.one.two" for the folder. Of course some people can have another opinion, the problem is that whenever name does not exist baseName / ext separation for folders will always lead to a big confusion.

This could be argued either way