Fix MessageBox Button Icons

Pull request type

Please check the type of change your PR introduces:

[ ] Update
[x] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes

What is the current behavior?

Currently, setting the icon for MessageBox buttons using PrimaryButtonIcon, SecondaryButtonIcon, or CloseButtonIcon properties has no effect. The icons do not appear on the buttons.
Issue Number: N/A
What is the new behavior?

The PrimaryButtonIcon, SecondaryButtonIcon, and CloseButtonIcon properties now use IconElement instead of SymbolRegular.
Icons set using these properties are correctly displayed on the MessageBox buttons.

Hey @stepwise-alan, thanks for the work you've put in


MB-9294: Migrates SystemAdmin routing components to new structure

Description
As part of both the efforts to reduce client test log pollution and to actively migrate/refactor deprecated front end components into the new structure, this pull request migrates the Home and index components from src/scenes/SystemAdmin into src/pages/Admin. (Other components in that folder weren't touched yet, as these were deemed to be the most complicated.) Additional tests were written for these components, which were refactored to bring them in line with contemporary project code quality standards.
Unfortunately, due to a downstream prop type issue with material-ui@core, the developers of the third-party react-admin library that we consume in these components have stated this component will be emitting prop type warnings when used in any development-level environment for the foreseeable future; this includes when client tests are run.
Reviewer Notes
Ensure that all tests are passing. Ensure that the admin site is working correctly. There should be no visible UI changes.
Since it's touching the core routing for the admin application, this pull request will be tested in the experimental environment at some stage; this note will be updated if everything goes according to plan.
Setup
make server_run
make admin_client_run

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Closes MB-9294.

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

Messages

:book:
:link: MB-9294

  Generated by :no_entry_sign: dangerJS against 5873b29b88d86999cb8903d1b57117aae2781a80

Is this PR still a thing that we plan on merging?


Filed not letting me have null and expects an object.

Whenever I use something like:
public QueryRule ReportRules { get; set; } or public Validation validation { get; set; }
it won't let it be null, it errors out expecting an object even though I've not set it to required and I need to be able to let the value be null and not have to put an empty object in it's place.  have you encountered this before as well?

Can you post the JSON Schema?
This test works for me:
[TestMethod]
public void When_property_can_be_null_then_null_is_allowed()
{
    //// Arrange
    var schema = new JsonSchema4();
    schema.Properties["test"] = new JsonProperty
    {
        Type = JsonObjectType.Null | JsonObjectType.Object
    };
    schema.Properties["test"].Properties["foo"] = new JsonProperty
    {
        Type = JsonObjectType.String
    };

    //// Act
    var data = "{ 'test': null }";
    var errors = schema.Validate(data);

    //// Assert
    Assert.AreEqual(0, errors.Count);
}

"validation": {                 "type": [                   "null",                   "object"                 ],                 "$ref": "#/definitions/Validation"               },
For public Validation validation { get; set; } and:
 "ReportRules": {       "type": [         "null",         "object"       ],       "$ref": "#/definitions/QueryRule"     },
for public QueryRule ReportRules { get; set; }.

Any clues?

This is a bad one, there is a problem with properties and schema refs.. I have to fix this but it will take a while...

Should be fixed in: https://github.com/NJsonSchema/NJsonSchema/commit/aa559b788a511fc74e7b913e679f04697b3c7f8a
I have to do more tests with these changes...

Fixed in NSwag v2.13


Update Mirror IsEmpty status on synchronize

Fix #9630
Fix #13183
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #13185 into master will decrease coverage by 0.03%.
The diff coverage is 4.44%.

@@            Coverage Diff             @@
##           master   #13185      +/-   ##
==========================================
- Coverage   42.10%   42.07%   -0.04%
==========================================
  Files         689      689
  Lines       75721    75764      +43
==========================================
- Hits        31881    31874       -7
- Misses      38610    38658      +48
- Partials     5230     5232       +2

Impacted Files
Coverage Δ

services/mirror/mirror.go
16.17% <4.44%> (-2.35%)
:arrow_down:

services/pull/temp_repo.go
26.59% <0.00%> (-3.20%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

services/pull/patch.go
53.97% <0.00%> (-1.71%)
:arrow_down:

services/pull/pull.go
40.78% <0.00%> (-0.50%)
:arrow_down:

modules/queue/workerpool.go
62.04% <0.00%> (+2.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d130cd1...0370066. Read the comment docs.


Can't find ion-sdk-widgets/Source/TransformEditor

I want to use this SDK, but got 404.
DOC: https://help.agi.com/STKWebVisualizationLibrary/TransformEditorViewModel.html?classFilter=TransformEditorViewModel
Repo: https://github.com/CesiumGS/cesium/blob/1.71/Source/Widgets/TransformEditor/TransformEditorViewModel.js#L392

Hi @TammyCT! That documentation is for the Cesium ion SDK, which is a separate, but related, project to CesiumJS. It's not open source.
I'm going to close this issue as it's unrelated to CesiumJS. If you have further questions, I would suggest asking on the Cesium Forum where there are members of the community and developers from the team who can help. Thanks!


Feature : deployment on kubernetes

Deploy to Kubernetes
I would like a deployment on to Kubernetes in order to make the squest portal more highly availale.
It looks like there is only a docker-compose deployment available.
An operator that will depploy and configure all components of squest.

Hi,
This is definitely in our pipe. It's a must have nowaday and we know that.
It's just a matter of time. We are working a lot on our instance of squest in prod here in HPE.
We'll provide this officially asap, but, you can already use this project made by a member of the community (@slarimore02).

How is this going? Also interested in an OpenShift compatible installation.

Hello! I can provide an helm chart to install Squest and its dependencies.
What is the best way ?

HewlettPackard create a git repo to hosts this helm chart, then I can fork the repo and send my updates
I fork this repo and send my updates in a /charts directory
Other idea ?

A CI/CD config will be needed to automatically build and publish the chart.

This feature is ongoing. You can take a look to my fork there is a dedicated branch that can be tested. It's based on ansible.

ok, nice! I will publish an helm chart too. It's more K8s specific than ansible.

Yes Helm is more specific to K8S. But it's a fire and forget tool that doesn't really handle what a production deployment can need.
And as the helm chart will need some dependencies to operators you would have to wrap anyway the install with some code to be able to deploy the full app from scratch.
But yes it can be cool to have both and see what are the limitations or advantages of each solution.

Agreed, the helm chart won't be enough for production. But peoples can deploy the helm chart using their tools/stack, like an ansible playbook (using kubernetes.core.helm module), or a gitops tool like argocd or fluxd (still configured with a lovely ansible playbook ^^ )

K8S deployment now available as beta feature.
Fell free to give us a feedback on this !


mailto markdown failed

Gitea version (or commit ref): 1.0.1
Git version: not relevant
Operating system: not relevant
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Is it possible to use mailto in markdown on gitea ?
When I try
[name<EMAIL_ADDRESS>
it produces an hyperlink
<EMAIL_ADDRESS>
instead of the mailto link
Anythink I am doing wrong?
many thanks

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This is a third-party library bug, see https://github.com/russross/blackfriday/issues/248

no it's not, you need to set this
[markdown]
CUSTOM_URL_SCHEMES = mailto

@bkcsoft could you send a PR to fix this?

bkcsoft : excuse my ignorance but where to add  [markdown] CUSTOM_URL_SCHEMES = mailto?

I confirmed #186 didn't resolve this. @andrew-boyarshin, could you have time to look at this one?

@lunny, yes, I didn't intend to resolve this issue in my PR. I should probably try.

So let's move this to v1.2.


List test datasets and update PR template

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (major / minor / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
Adds a list_datasets function to list datasets in the xclim-testdata repo using github's REST API.
Update the PR template because I want to list things in the first section but it's already a list.

Does this PR introduce a breaking change?
Nope

Other information:
The API calls are unauthenticated and thus rate-limited to 60 per hour (per id). The function makes 1 main + 1 per subdirectory, so 3 calls and you're blocked. This is not really a problem, this is just a convenience function, but I marked the test as "slow" so it's only executed in one build.

The 2 CodeFactor issues are non-issues (because we already know all URLs are https, there are no user-provided urls), thus this is ready!


New version: Zoom.ZoomRooms version 6.2.7

Pull request has been created with komac v2.6.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

No errors to post.

(Automated response - build 899.)


Simplify connection checks in RunQueryAction

This PR simplifies duplicated isConnected checks in RunQueryAction so we can reduce to one refreshAzureAccountTokenIfNecessary call for both run and runCurrent.
This is a follow-up to the AAD token expiration handling PR #16936

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 41.627%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
26386

Relevant Lines:
57392

💛  - Coveralls


Tree-Sitter function color

Environment:

OS: Linux
Vim (:version): Neovim 0.6
Terminal: Bash

If you have a trouble with coloration and are using Vim/Neovim with terminal:

[ x] Does your Vim support full colors? (:set termguicolors)
[ x] Does your terminal support full colors? (e.g. Terminal.app doesn't support it)

With Tree-Sitter the class, function etc. declarations are not in orange.

Please share a example code. This is important to investigate the issue.

Without tree-sitter for python it looks like this:

With tree-sitter for python:

Faced the same issue with the tree-sitter.

Hi, I'm interested in and took a quick look on this issue (with the help of :Inspect command).
It seems class definitions (SomeClass in the example) is in the @type group in treesitter. So, highlighting it into orange is possible, but makes all type keywords highlighted in orange, which puts a bit too much orange in the screen.

To avoid that problem, I am currently using a bit opinionated fork of mine that highlights types/classes in green and function/method definitions in orange.

If you are still having trouble, this may help you. Or if you came up with other solutions, please let me know!


fix(versions): update Activiti/activiti-cloud-runtime-bundle-service versions into develop

UpdateBot pushed maven dependency: org.activiti.dependencies:activiti-dependencies to: 7.1.52

UpdateBot commands:
updatebot push-version --kind maven org.activiti.dependencies:activiti-dependencies 7.1.52 org.activiti.api:activiti-api-dependencies 7.1.40 org.activiti.core.common:activiti-core-common-dependencies 7.1.36 org.activiti.build:activiti-parent 7.1.26


Homepage button overflows

Describe the bug
The "read and sign the manifesto" button overflows the image element on changing the screen size.
To Reproduce
Steps to reproduce the behavior:

Go to  'journal policy tracker homepage'
Right Click and choose inspect element
try changing the dimensions of the screen

Screenshots/Video
https://user-images.githubusercontent.com/75200954/163171997-08c4e642-466c-44ae-b415-9254257b079e.mp4

Can I work on this, please assign me this issue

This has been fixed by a previous PR. Can you please pull the recent push to the repo?


Windows 10 Iot entreprise is it supported by WUFB?

I need to manage Windows 10 IOT enterprise 2016 and 2019 with Intune to manage Software Updates.
WUFB can support Windows 10 IOT Enterprise (LTSC and SAC?)
Tank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c09aa9f9-959c-479b-f727-03f292e92b0a
Version Independent ID: 4664a228-83be-157b-fc75-45abe14abc27
Content: Onboarding to Windows Update for Business (Windows 10) - Windows Deployment
Content Source: windows/deployment/update/wufb-onboard.md
Product: w10
Technology: windows
GitHub Login: @jaimeo
Microsoft Alias: greglin

Hello @JuGhithub - Thank you for posting your query. Please note that as of now, you can not manage Windows 10 IoT with WUfB. The only supported SKUs are
Windows 10 Education
Windows 10 Enterprise
Windows 10 Pro
Windows 10 S (for Windows 10, version 1709 and earlier)
You can always use the user voice channel to request this feature for WUfB.  @nam31 can guide you on how you can request a new feature using the user voice channel.
Thanks
Imran.

@JuGhithub Please let us know if you still have any question regarding the issue you have raised initially.
The issue is being closed since your question seems to be answered. Feel free to re-open this issue if you feel that it hasn't been answered or that there are further suggestions to improve the documentation itself.
Thanks.


Basic astro site

Build astro site and move it to /astro, and link to the rest of the files.

Start tracking all the legacy content from the cnbc articles and yahoo finance articles.

Homepage with link to nlp based on category

get datatable to display all nlp hits
store all results and non results in a csv
implement tagging to filter by by data source and/or top hits
make simple homepage containing last hits.


The future returned from the function passed into Action::new_local has an unnecessary(?) Send requirement

Describe the bug
The signature of Action::new_local is
    pub fn new_local<F, Fu>(action_fn: F) -> Self
    where
        F: Fn(&I) -> Fu + 'static,
        Fu: Future<Output = O> + Send + 'static,

which makes this function less useful than it could be, since it means that all values held across await points must be Send.  I don't think the Send requirement on the future is actually needed though?  I forked leptos locally and removed it, and it still seems to compile and work properly.
Leptos Dependencies
leptos = { version = "0.7.0", features = ["csr"] }

Also checked my fork with the ssr feature in case there was a requirement for Sendness that only shows up when server-side rendering is enabled.
To Reproduce
Action::new_local(|()| async move {
  let x = Rc::new(0);
  futures_util::future::ready(()).await;
  *x
})

Expected behavior
This should compile.
Additional context
This came up in code ported from leptos 0.6, which has such a non-Send value being held across an await.

Oh cool! If you forked it locally and it works would you like to make a quick PR?

Sure thing; created this PR


General updates for coveralls

Pull Request Test Coverage Report for Build 483

5 of 7 (71.43%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 83.482%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/google/GoogleLsCommand.java
0
2
0.0%

Totals

Change from base Build 479:
0.9%

Covered Lines:
1971

Relevant Lines:
2361

💛  - Coveralls


feat: time all solutions

Codecov Report

Merging #2 (bbf104c) into main (d55758b) will decrease coverage by 3.95%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   91.70%   87.74%   -3.96%
==========================================
  Files           9        9
  Lines        1374     1436      +62
==========================================
  Hits         1260     1260
- Misses        114      176      +62

Impacted Files
Coverage Δ

src/main.rs
0.68% <0.00%> (-0.51%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Simplify 'FontHandles' management

Behavior should be equivalent to what it was before. Tested all examples as well.

SFMLBuildMaster: Build this please.

CI formatting jobs are in conflict which is rare. Long story short, you can fix this by adding our typical Doxygen headers above each and ever special member function. Then all the formatting jobs will be in agreement.

CI formatting jobs are in conflict which is rare. Long story short, you can fix this by adding our typical Doxygen comment blocks above each and every special member function. Then all the formatting jobs will be in agreement.

That would be overly verbose IMHO, let me try with // clang-format off

SFMLBuildMaster: Build this please.


[ADD AdditionalOptions] Wv:18

msvc 16\2019 error

I disagree with this work around.
The error comes from Provider abstract class calling a non virtual destructor, which may lead to undefined polymorphism behaviour.
To guaranty all destructors are called, should change ~Provider(void); to virtual ~Provider(void); in ndprov.h
Should also comment (or delete) ~NdV1Provider(); and ~NdProvider(); definitions, since these derived constructors are not implemented.


fix: import icons as svg files instead of using react components

This pr changes how svg files are stored in project and removes all css from them, this is first step to refactor how we import icons.
as we are using svgr to convert svg items to react components actual svg code stays the same
this may be considered a breaking change as icons do not contain styles anymore and consumers have to apply them when they are needed
related PR: #5865

@Josh-Cena let me know if there is something else that i have to do in here

I'm in favor of the current change. Just waiting for the input from @slorber

personally i do not like icons in css, as there is no way to easily style them/color outside of creating new one
in my opinion sprites are way to go, i tested this change with https://github.com/JetBrains/svg-sprite-loader (or rather inspired version of it) and simple wrapper for react and it seem to work perfectly,
i still can use:
import arrow from './icons/arrow.svg';

return <arrow>

if thats a case icons are added automatically, withotu change of api, only difference is that component returned by this import is:
<svg viewBox="....">
  <use xlink:href="#arrow" />
</svg>

i could give it a try to implement it in non "mockup" version

personally i do not like icons in css, as there is no way to easily style them/color outside of creating new one

As long as they are one color icons, using mask  for the svg, and background-color to set color makes it easy.


LinearGradient

When i try to use different shade of color(example : Colors.blue[100]) LinearGradiend on BoxDecoration it gives this error: The element type 'Color?' can't be assigned to the list type 'Color'.

you should use Colors.blue[100]! if this material color really exist

Hi @Davud44, as @laiiihz pointed out above, you can use Colors.blue[100]! but you should be certain that the shade exists before you force non null otherwise you might run into a null error.


DL-97: Remove unused methods in BKLogHandler

merge code change on remove unused methods in BKLogHandler.

@sijie the build is failing with the following error:
Results :

Failed tests:   testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync(com.twitter.distributedlog.TestAppendOnlyStreamWriter): expected:<33> but was:<0>

Tests run: 490, Failures: 1, Errors: 0, Skipped: 9

[ERROR] There are test failures.

is this transient ? Or do you need to review the change.


Get rid of github actions extension for determining changed files

It's buggy.
  - name: Get all changes
    id: file_changes
    uses<EMAIL_ADDRESS>

duplicate of https://github.com/open-traffic-generator/openapiart/issues/10


[Rest Server] Rename reserved cells to pinned cells

Rename reserved cells to pinned cells.
Closes #4410.

Depends on a new hived image change

Coverage remained the same at 34.684% when pulling ab79dee757fbb359dabfaf3aa131c4154c1158b5 on xiongyf/rename-reserved-cell into 3c2a6514363bbff41b2bd40ae104e9537e716fcb on master.


Removing clusterID from AWSIamConfig spec and generating uuid

Description of changes:
Removing clusterID field from AWSIamConfig CRD. By default the clusterID is set to a UUID during cluster creation and does not support upgrade/gitops to change the value.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

So, my understanding from the convo the other day is that we'd allow the customer to override the default value if they explicitly wanted to

So, my understanding from the convo the other day is that we'd allow the users to override the default clusterId value if they explicitly wanted to

spoke with @pokearu and we are moving forward with the removal of the clusterID configuration; we can always open up the option to configure it later based on user feedback.

So, my understanding from the convo the other day is that we'd allow the users to override the default clusterId value if they explicitly wanted to

spoke with @pokearu and we are moving forward with the removal of the clusterID configuration; we can always open up the option to configure it later based on user feedback.

Yup! Currently we are enforcing a default uuid 👍  and we can address this again based on feedback.

/lgtm

sorting out integration tests prior to merge

/unhold

/lgtm


fix: decoup gateway status updates from the reconciler

Fixes: https://github.com/envoyproxy/gateway/issues/4685
Release Note: Yes

were we deadlocking ?

were we deadlocking ?

It's my suspicion - I can't reproduce myself, but based on the description of the issue https://github.com/envoyproxy/gateway/issues/4685, it seems that the reconciler has been blocked because the pods changes haven't been propogated to the Envoy through xDS.

@arkodg I'm going to close this PR as it has race condition problem.
Fixed this issue in #4754

Verified with https://github.com/envoyproxy/gateway/pull/4904.


fix W::bits signature

Fixes #475.

r? @ryankurte
(rust_highfive has picked a reviewer for you, use r? to override)

This code doesn't fix problem in my view, as REG:Writer and W are different types.
https://github.com/rust-embedded/svd2rust/blob/1a2bf65b8f08c0a9a6f3c276e393c511ed236cf9/src/generate/register.rs#L84

I don't see any way (without traits) to implement generic bits function that will be work as before.
If we don't found better solution, I think it is better just delete generic unsafe fn bits.
And replace
https://github.com/rust-embedded/svd2rust/blob/29129c0e4e261bf4c38057f7585e7ddfc05fafd0/src/generate/register.rs#L168
with:
self.bits = bits

I'd agree that it is a bit surprising at first that this works.  I submitted the PR and went off to bed, but then had one of those moments lying in bed and thinking about it when I felt a sinking feeling that the fix would break everything.  I got back up and did a bunch more testing to verify that nothing breaks.
The key insight is that there's a deref coercion happening.  Since REG::Writer implements DerefMut<Target=W>, a mutable reference to the more specific type is just as good as a mutable reference to the more general type.  However, that's not true the other direction (we have to explicitly .into() for that to work).  This is why we need to relax the bounds at 1, 2, and 3.
A collection of resources I assembled while verifying that this was correct:

playground
DerefMut trait ref (specifically: Values of type &mut T are coerced to values of type &mut U)
the book Chapter 15.2

(As an aside, all this chicanery would be avoided with #478).

See what problem I see:
    reg.write(|w| { w
         .bits(10)    // <-- DerefMut here
         .field1().set_bit()  // <-- error! generic W<REG> doesn't have `field1`
    });

Ah, that's a fair point.  Though it would be a fairly marginal use-case, wouldn't it?  Setting the bits for the whole register explicitly and then overriding just one field?

Oh, thanks @burrbull for bringing up the specialized version of bits at https://github.com/rust-embedded/svd2rust/blob/29129c0e4e261bf4c38057f7585e7ddfc05fafd0/src/generate/register.rs#L167-L170, in all the hubbub I had forgotten about it.  That would certainly explain why in any normal code #475 didn't manifest as a bug, since the compiler will pick the impl directly on the specific type before even trying to deref.
So #475 will only manifest in code written to be generic over Writable, so I'm almost certainly the only one affected.
To close the loop, your example at https://github.com/rust-embedded/svd2rust/pull/477#issuecomment-697427710 will be fine, since w refers to the specific register writer, so w.bits refers to the version that returns self, not the generic version implemented here.

Is that example from real code somewhere?

I already saw something like this.
On the other hand this should work:
reg.write(|w| {
      w.bits(10);    // <-- DerefMut here, but drop ref
      w.field1().set_bit()
});

Can you test this?

I already saw something like this.

Do you mean just that you've seen that pattern before or that it exhibited a bug?  My current thinking is that there's no bug in that pattern, since the w.bits that gets called there is not the one added by this PR.
I've not been able to trigger #475 on master or any suspected bug from this PR in any testing (and it does seem like it would have to be both or neither, not one or the other).  If you have an example of somewhere that has an issue, please point me to it.

Ping @burrbull.  I don't believe there's a bug in any code except my own.  Happy to look at any counter-example that you might come up with.
Are there any other outstanding issues with this PR?  Thanks!

@burrbull, have you been able to identify any issues with this change?  To reiterate, I'm pretty confident that the only one affected by the bug is me.
@ryankurte it looks like you're still the @rust-highfive reviewer here, would you by chance be able to take a look at this PR?  Thanks!

Thanks for the reviews!


added trick tabIndex with html link

Shown how to use tabIndex /b> tag to navigate elements in a particular order
Next, all the text is centered using demo class present in main.css that means linked main.css to my html file
Also, added google-fonts link in my html file as well

@atapas @Alidhuniya Please add the tag/label hacktoberfest-accepted so that this PR is counted in hacktoberfest

solved issue #36


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.4.27 to before v5.4.128",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0c050d6554757f1be861b9f288406989c4053449",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=b6c0ab11c88fb016bfc85fa4f6f878f5f4263646"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "0c050d6554757f1be861b9f288406989c4053449",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "b6c0ab11c88fb016bfc85fa4f6f878f5f4263646",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: ll_temac: Fix TX BD buffer overwrite\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.128 by commit b6c0ab11c88fb016bfc85fa4f6f878f5f4263646, it was introduced in version v5.4.27 by commit 0c050d6554757f1be861b9f288406989c4053449. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000932


Add ruff linter and run unit tests in github actions

add ruff linter to ci/cd GitHub actions
add unit tests to GitHub actions

@danielbeach do your unit tests pass when you run them? They fail when I run them locally.

The unit tests don't pass:
https://github.com/jcorrado76/tinytimmy/actions/runs/6017840706/job/16324877849
@danielbeach  Do you still want to merge this in?
I know this PR achieves the individual goal it set out to do. If you want to fix unit tests in another issue, we can merge this in.

I just added a PR that brings all the DataQuality unit tests to green (#29).
So we can merge that first, and then merge this one, and the unit tests should pass.


Azure Stack: HTTP Header not in correct format [create_stemcell, delete_vm]

--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------
Sorry to hear you had a bad experience with Azure CPI :worried: But, in case you're just asking a question, we're happy to help. You can also check if the question might already have been asked here https://github.com/cloudfoundry-incubator/bosh-azure-cpi-release/issues?utf8=✓&q=is%3Aissue
We've created an outline of recommended sections to fill out that will help us to understand your issue!
--------------------MESSAGE FROM ADMIN, DELETE BEFORE SUBMITTING----------------------
Versions (please add them if you have more releases for this issue)
CPI      Version: 30 up to 33
BOSH     Version: "264.3.0"
CF       Version:
Diego    Version:
Stemcell
Version:3468.5
Distro:

[x] Ubuntu
[ ] CentOS

Environment

Azure Environment:

[ ] Azure
[ ] AzureChinaCloud
[ ] AzureUSGovernment
[ ] AzureGermanCloud
[x ] AzureStack
[ ] Others:

Location: (e.g. East US) local
Subscription ID:
Resource Group Name:
[ ] Use Managed Disks

Issue Details
We deploy bootstrap-bosh on our Azure Stack Development Kit. With bosh-azure-cpi versions up to 29, the deployment works well. With versions 32 or 33, the deployment fails in step create_stemcell with an issue indicating that 'The value for one of the HTTP headers is not in the correct format.' When trying to clean up the failed deployment, the same issue occurs in delete_vm.
Some API versions used in the Azure CPI which might not be compatible on Azure Stack?
Logs (Please redact all sensitive information in your logs)
creating stemcell (bosh-azure-hyperv-ubuntu-trusty-go_agent 3468.5):
CPI 'create_stemcell' method responded with error: CmdError{"type":"Bosh::Clouds::CloudError","message":"Failed to upload page blob: #\u003cAzure::Core::Http::HTTPError:47031128061200 @http_response: #\u003cAzure::Core::Http::HttpResponse:0x0000558c935ceae8 @http_response=#\u003cFaraday::Response:0x0000558c935ceb38 @on_complete_callbacks=[], @env=#\u003cFaraday::Env @method=:put @body="\xEF\xBB\xBF\u003c?xml version=\"1.0\" encoding=\"utf-8\"?\u003e\u003cError\u003e\u003cCode\u003eInvalidHeaderValue\u003c/Code\u003e\u003cMessage\u003eThe value for one of the HTTP headers is not in the correct format.\nRequestId:4414c11c-d815-0dcc-7b73-527f382941b1\nTime:2017-12-14T10:42:00.5608784Z\u003c/Message\u003e\u003cHeaderName\u003ex-ms-version\u003c/HeaderName\u003e\u003cHeaderValue\u003e2016-05-31\u003c/HeaderValue\u003e\u003c/Error\u003e" @url=#\u003cURI::HTTPS https://storageltdtxkbdficlkt.blob.local.azurestack.external/stemcell/bosh-stemcell-b42d7e2e-c44d-4526-b365-19a9b0e510b4.vhd?timeout=120\u003e @request=#\u003cFaraday::RequestOptions open_timeout=60\u003e @request_headers={"User-Agent"=\u003e"BOSH-AZURE-CPI; Azure-Storage/0.14.0-preview (Ruby 2.4.2-p198; Linux linux-gnu)", "x-ms-date"=\u003e"Thu, 14 Dec 2017 10:42:00 GMT", "x-ms-version"=\u003e"2016-05-31", "DataServiceVersion"=\u003e"1.0;NetFx", "MaxDataServiceVersion"=\u003e"3.0;NetFx", "Content-Type"=\u003e"application/atom+xml; charset=utf-8", "x-ms-client-request-id"=\u003e"d31603bc-f974-4958-b2bd-121636ea6d97", "x-ms-blob-type"=\u003e"PageBlob", "Content-Length"=\u003e"0", "x-ms-blob-content-length"=\u003e"3221225984", "x-ms-sequence-number"=\u003e"0", "x-ms-meta-architecture"=\u003e"x86_64", "x-ms-meta-container_format"=\u003e"bare", "x-ms-meta-disk"=\u003e"3072", "x-ms-meta-disk_format"=\u003e"vhd", "x-ms-meta-hypervisor"=\u003e"hyperv", "x-ms-meta-infrastructure"=\u003e"azure", "x-ms-meta-name"=\u003e"bosh-azure-hyperv-ubuntu-trusty-go_agent", "x-ms-meta-os_distro"=\u003e"ubuntu", "x-ms-meta-os_type"=\u003e"linux", "x-ms-meta-root_device_name"=\u003e"/dev/sda1", "x-ms-meta-version"=\u003e"3468.5", "Authorization"=\u003e"SharedKey storageltdtxkbdficlkt:plC3zSe+FX4GAOWFyhP/R7iby/yhZFoAMNS8Dbw0LNE="} @ssl=#\u003cFaraday::SSLOptions verify=true, ca_file="/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/jobs/azure_cpi/config/azure_stack_ca_cert.pem"\u003e @response=#\u003cFaraday::Response:0x0000558c935ceb38 ...\u003e @response_headers={"content-length"=\u003e"328", "content-type"=\u003e"application/xml", "server"=\u003e"Microsoft-HTTPAPI/2.0", "x-ms-request-id"=\u003e"4414c11c-d815-0dcc-7b73-527f382941b1", "date"=\u003e"Thu, 14 Dec 2017 10:41:59 GMT", "connection"=\u003e"close"} @status=400 @reason_phrase="The value for one of the HTTP headers is not in the correct format."\u003e\u003e, @uri=#\u003cURI::HTTPS https://storageltdtxkbdficlkt.blob.local.azurestack.external/stemcell/bosh-stemcell-b42d7e2e-c44d-4526-b365-19a9b0e510b4.vhd?timeout=120\u003e\u003e, @uri: #\u003cURI::HTTPS https://storageltdtxkbdficlkt.blob.local.azurestack.external/stemcell/bosh-stemcell-b42d7e2e-c44d-4526-b365-19a9b0e510b4.vhd?timeout=120\u003e, @status_code: 400, @type: "InvalidHeaderValue", @description: "The value for one of the HTTP headers is not in the correct format.\nRequestId:4414c11c-d815-0dcc-7b73-527f382941b1\nTime:2017-12-14T10:42:00.5608784Z", @header: "x-ms-version", @header_value: "2016-05-31"\u003e\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/http/retry_policy.rb:48:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/http/http_request.rb:104:in block in with_filter'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/http/signer_filter.rb:28:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/http/signer_filter.rb:28:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/http/http_request.rb:104:in block in with_filter'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/service.rb:36:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/filtered_service.rb:34:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-core-0.1.12/lib/azure/core/signed_service.rb:41:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-storage-0.14.0.preview/lib/azure/storage/service/storage_service.rb:55:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-storage-0.14.0.preview/lib/azure/storage/blob/blob_service.rb:61:in call'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/azure-storage-0.14.0.preview/lib/azure/storage/blob/page.rb:107:in create_page_blob'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:389:in upload_page_blob'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:63:in block in create_page_blob'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:414:in block in initialize_blob_client'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:403:in synchronize'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:403:in initialize_blob_client'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/blob_manager.rb:61:in create_page_blob'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/stemcell_manager.rb:48:in block in create_stemcell'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/2.4.0/tmpdir.rb:89:in mktmpdir'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/stemcell_manager.rb:42:in create_stemcell'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/cloud.rb:46:in block in create_stemcell'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/bosh_common-1.3262.24.0/lib/common/thread_formatter.rb:49:in with_thread_name'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/lib/cloud/azure/cloud.rb:40:in create_stemcell'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/bosh_cpi-2.4.1/lib/bosh/cpi/cli.rb:82:in public_send'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/vendor/bundle/ruby/2.4.0/gems/bosh_cpi-2.4.1/lib/bosh/cpi/cli.rb:82:in run'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/bosh_azure_cpi/bin/azure_cpi:39:in \u003ctop (required)\u003e'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli/exec.rb:75:in load'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli/exec.rb:75:in kernel_load'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli/exec.rb:28:in run'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli.rb:424:in exec'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/vendor/thor/lib/thor/command.rb:27:in run'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/vendor/thor/lib/thor/invocation.rb:126:in invoke_command'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/vendor/thor/lib/thor.rb:387:in dispatch'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli.rb:27:in dispatch'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/vendor/thor/lib/thor/base.rb:466:in start'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/cli.rb:18:in start'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/bin/bundle:30:in block in \u003cmain\u003e'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/lib/ruby/site_ruby/2.4.0/bundler/friendly_errors.rb:122:in with_friendly_errors'\n/home/vcap/.bosh/installations/0016721c-a1f9-47db-61ea-0fcbbe0409f5/packages/ruby-2.4-r3/bin/bundle:22:in `\u003cmain\u003e'","ok_to_retry":false}

Thanks for raising the issue. The storage data service version "x-ms-version"="2016-05-31" is not compatible with Azure Stack. We are working on fixing it.

@ClaudiaBaur We've merged PRs #347 and #349 to fix the issue.
Now the correct storage data service version is used. I've tested in my AzureStack deployment.
However, it would be better if you can verify the fix in your own test environment. We would appreciate your great help.
Here is a candidate release: https://cloudfoundry.blob.core.windows.net/share/bosh-azure-cpi-0.0.290.tgz.

hi Bin,
your patched version works fine for me.
Thanks!


[BEAM-7066] re-add python 3.6 and 3.7 precommit test suites

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

R: @tvalentyn

@pabloem Could you please help with the merge? Thanks a lot!


prepare: complain and abort on conflicting CLI flags

When a pod manifest is passed to rkt-prepare other conflicting
CLI flags are discarded, so far in a silent way.
This commit makes the issue explicit and abort when conflicting
flags are specified together with --pod-manifest.
Fixes #2418

@iaguis @alban

You should keep the same test in rkt/run.go.

@alban it was not in the scope of the original report so I missed it. Will add.

lgtm, but let's add the run one too before merging

Rebased, extended to cover run too.

LGTM


Poor performance in throughput test

Hardware: QCA9531(host) + efr32mg21 / nrf52840 (rcp); efr32 connect with usb2uart, nrf52840 connect with native usb
Software OS: OpenWRT 17.07.7
Test device version and uart config:

ot-br-posix(OTBR) version
ot-efr32(RCP) version
ot-nrf528xx(RCP) version
OpenThread version
UART

2021-10-19-ae90b33289
2021-10-19-1fbf6bb

71e4df9
460800B-8N1

2021-10-19-ae90b33289

2021-10-19-df6e2ff
71e4df9
460800B-8N1

Test method: We test with iperf3(support ipv6) on two devices in the same thread network.
Test result: efr32 start lose packet at 40kbps and nrf52840 start lose packet at 100kbps. The performance of efr32 is very poor.
 Is there a similar test done inside silabs?

@HeFeng1947 , this may be due to the performance difference between native USB and UART.

Yes, there may be some performance differences, but the EFR32's performance seems awful. Based on the results of current tests, the EFR32 solution does not appear to meet commercial standards.

Update some new test results:
QCA9531(host) + 52840DK(rcp), connect with usb2uart(same as efr32), no flow control
host msg buffer 356; 460800 bardrate: Lose 7% packet at 80kbps
host msg buffer 3076; 921600 bardrate: work great at 250kbps, lose 0% packet
When we test efr32 at host msg buffer 3076; 921600 bardrate, it doesn't work. We still try to find out the problem.

@HeFeng1947 Thanks for reporting this. May I know the exact usb2uart converter?
From our experience, most of the usb2uart converters don't work well enough and have an impact on the performance.
I'll do some tests and then get back to you.
Jim

@HeFeng1947 Thanks for reporting this. May I know the exact usb2uart converter? From our experience, most of the usb2uart converters don't work well enough and have an impact on the performance.
I'll do some tests and then get back to you.
Jim

Hi Jim, we are currently mainly based on three USB2UART converter tests.

CH340 (not support full hardware flow control)
CH343P (support full hardware flow control)
CP2102 (support full hardware flow control)

Considering the price, we currently prefer to use the CH343P.

@HeFeng1947 , is it possible to use SPI instead of UART? SPI allows for greater reliability and higher data rates.

@HeFeng1947 , is it possible to use SPI instead of UART? SPI allows for greater reliability and higher data rates.

This doesn't seem feasible in our product proposal. And the feasibility of UART scheme has been tested in Nordic 52840 scheme. I really don't understand why silabs scheme has such a serious problem or just my configuration error.

I tested with a USB stick based on EFR32 + CP210x (UART2USB converter with hardware flowcontrol).
I can get 0% packet loss as well with 250kbps, buffer count 3076.
`
iperf -V -c fd30:89c2:5240:1:438b:cad2:d205:169b -u -i 1 -b 250k -l 1k
Client connecting to fd30:89c2:5240:1:438b:cad2:d205:169b, UDP port 5001
Sending 1000 byte datagrams, IPG target: 32000.00 us (kalman adjust)
UDP buffer size:  208 KByte (default)
[  3] local fd30:89c2:5240:1:4d8f:8d5b:b2f9:ba5b port 33262 connected with fd30:89c2:5240:1:438b:cad2:d205:169b port 5001
[ ID] Interval       Transfer     Bandwidth
[  3]  0.0- 1.0 sec  32.2 KBytes   264 Kbits/sec
[  3]  1.0- 2.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  2.0- 3.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  3.0- 4.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  4.0- 5.0 sec  31.2 KBytes   256 Kbits/sec
[  3]  5.0- 6.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  6.0- 7.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  7.0- 8.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  8.0- 9.0 sec  31.2 KBytes   256 Kbits/sec
[  3] WARNING: did not receive ack of last datagram after 10 tries.
[  3]  0.0-10.0 sec   306 KBytes   250 Kbits/sec
[  3] Sent 313 datagrams
`
[  4] local fd30:89c2:5240:1:438b:cad2:d205:169b port 5001 connected with fd30:89c2:5240:1:4d8f:8d5b:b2f9:ba5b port 33262 [  4]  0.0-42.7 sec   306 KBytes  58.6 Kbits/sec  165.322 ms    0/  313 (0%)
I'm not sure why you test that with this data rate, but hope you understand that this is the data rate at UDP transport layer, not the actual radio.
The data rate of the PHY is 250kbps per IEEE802.15.4 standard. So most of those data will be buffered.
The schematic of the USB stick is attached here.
 Did you compile with the ot-efr32 project or did you use the silabs IDE? Is the baud rate 115200 or 460800?

@HeFeng1947 , I tested it with multiple commits.

RCP created by Silicon Labs Simplicity Studio Gecko SDK 4.0.2
OTBR 5be35949c6f
baudrate 460800, hardware flow control
Thread msg buffer 4096

And I also tested with the latest commit this morning.

RCP   cef0a4c on ot-efr32
OTBR 355a415db0
baudrate 460800, hardware flow control
Thread msg buffer 4096

Server side:
jim@jbuntu:~/develop/ot-efr32/build/efr32mg21/bin$ iperf -V -s -u -B fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e
------------------------------------------------------------
Server listening on UDP port 5001
Binding to local address fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e
Receiving 1470 byte datagrams
UDP buffer size:  208 KByte (default)
------------------------------------------------------------
[  3] local fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e port 5001 connected with fd8d:d5f8:20f8:1:b56:4fc0:d57b:b658 port 34193
[ ID] Interval       Transfer     Bandwidth        Jitter   Lost/Total Datagrams
[  3]  0.0-58.5 sec   306 KBytes  42.8 Kbits/sec  154.956 ms    0/  313 (0%)

Client side:
ubuntu@jim-pi4:~/develop/ot-br-posix$ iperf -V -c fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e -u -i 1 -b 250k -l 1k
------------------------------------------------------------
Client connecting to fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e, UDP port 5001
Sending 1000 byte datagrams, IPG target: 32000.00 us (kalman adjust)
UDP buffer size:  208 KByte (default)
------------------------------------------------------------
[  3] local fd8d:d5f8:20f8:1:b56:4fc0:d57b:b658 port 34193 connected with fd8d:d5f8:20f8:1:2aef:aed4:fbc7:95e port 5001
[ ID] Interval       Transfer     Bandwidth
[  3]  0.0- 1.0 sec  32.2 KBytes   264 Kbits/sec
[  3]  1.0- 2.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  2.0- 3.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  3.0- 4.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  4.0- 5.0 sec  31.2 KBytes   256 Kbits/sec
[  3]  5.0- 6.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  6.0- 7.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  7.0- 8.0 sec  30.3 KBytes   248 Kbits/sec
[  3]  8.0- 9.0 sec  31.2 KBytes   256 Kbits/sec
[  3] WARNING: did not receive ack of last datagram after 10 tries.
[  3]  0.0-10.0 sec   306 KBytes   250 Kbits/sec
[  3] Sent 313 datagrams

I have some problems with the tcp connections. So the test result is not that intuitive. But you can still find that there is no packet loss.
I'm still checking the tcp issue.
Probably I will raise an issue here.

@HeFeng1947  Update the test result here. After disabled the OpenThread's internal TCP implementation, I can run iperf3 test now.
Below is the test result.

I think you should change your usb2uart converter to a better one.
According to our experience, those based on FTDI and CP210x chips are recommended.
Thanks,
Jim

@HeFeng1947 I don't think you can use my firmware directly as I'm using a USB stick based on EFR32MG21B010F1024IM32.

But I still attached it here as you requested. Pay attention that you need to flash a bootloader for this rcp firmware.
ot-rcp.zip
And I don't think F768 and F1024 parts have different performances if used as RCP.

Update our new test result:
efr32mg21a020f768im32 + cp2102n + qca9531

wifi channel: 1
thread channel: 12
thread tx power: 10

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.06  sec   458 KBytes  42.1 Kbits/sec  161.678 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.24  sec   458 KBytes  42.0 Kbits/sec  160.405 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.30  sec   458 KBytes  42.0 Kbits/sec  162.768 ms  0/458 (0%)  receiver

wifi channel: 1
thread channel: 12
thread tx power: 20

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.55  sec   458 KBytes  41.9 Kbits/sec  161.632 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.50  sec   458 KBytes  41.9 Kbits/sec  161.902 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-89.59  sec   458 KBytes  41.9 Kbits/sec  160.445 ms  0/458 (0%)  receiver

wifi channel: 1
thread channel: 26
thread tx power: 20

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-10.00  sec   306 KBytes   251 Kbits/sec  0.000 ms  0/306 (0%)  sender
[  5]   0.00-59.02  sec   306 KBytes  42.5 Kbits/sec  159.260 ms  0/306 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.42  sec   458 KBytes  42.4 Kbits/sec  159.652 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.39  sec   458 KBytes  42.4 Kbits/sec  159.260 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.42  sec   458 KBytes  42.4 Kbits/sec  157.786 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.35  sec   458 KBytes  42.5 Kbits/sec  158.581 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.54  sec   458 KBytes  42.4 Kbits/sec  157.909 ms  0/458 (0%)  receiver

bufferinfo
root@KNBAC6AA51A4:~# ot-ctl  bufferinfo
total: 4096
free: 326
6lo send: 377 3770
6lo reas: 0 0
ip6: 0 0
mpl: 0 0
mle: 0 0
arp: 0 0
coap: 0 0
coap secure: 0 0
application coap: 0 0
Done

wifi channel: 1
thread channel: 26
thread tx power: 10

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-88.54  sec   458 KBytes  42.4 Kbits/sec  158.682 ms  0/458 (0%)  receiver

nrf52840 + cp2102n + qca9531

wifi channel: 1
thread channel: 26
thread tx power: 8

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-69.75  sec   458 KBytes  53.8 Kbits/sec  120.478 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-69.70  sec   458 KBytes  53.8 Kbits/sec  119.242 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-69.71  sec   458 KBytes  53.8 Kbits/sec  117.878 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-69.87  sec   458 KBytes  53.7 Kbits/sec  118.957 ms  0/458 (0%)  receiver

[ ID] Interval           Transfer     Bitrate         Jitter    Lost/Total Datagrams
[  5]   0.00-15.00  sec   458 KBytes   250 Kbits/sec  0.000 ms  0/458 (0%)  sender
[  5]   0.00-69.78  sec   458 KBytes  53.8 Kbits/sec  118.157 ms  0/458 (0%)  receiver

bufferinfo
root@OpenWrt:~# ot-ctl bufferinfo
total: 4096
free: 508
6lo send: 360 3576
6lo reas: 0 0
ip6: 0 0
mpl: 0 0
mle: 0 0
arp: 0 0
coap: 6 12
coap secure: 0 0
application coap: 0 0
Done

The above tests are all based on the shielding box environment. Maybe our module has not done a good job in rf calibration, and its performance is worse than NRF52840.

@silabs-JimL Jim, has silabs run similar throughput tests? I understand that EFR32 should be close to the theoretical upper limit in terms of purely 802.15.4 wireless transceiver. However, in current tests with OpenThread, the actual throughput of NRF52840 is approximately 26% higher than that of EFR32. Are there any EFR32 parameters that can be adjusted to improve performance?

@HeFeng1947 I'm not aware of any parameters that could impact this. The hardware is totally different.
May I know why this is important for you?

@HeFeng1947 I'm not aware of any parameters that could impact this. The hardware is totally different. May I know why this is important for you? EFR32MG21 is already a certified platform.

I just want to increase the communication speed as much as possible. I think this actual communication rate will be an important performance metric for OTBR. So far I have got the performance parameters I want, I think this issue can be closed.
@jwhui @silabs-JimL Thank you for your hard work!

@HeFeng1947 Sure.  I don't think that you should care about it too much. For the OTBR, the co-existence of Thread and WiFi will have a much bigger impact on the throughput. And we already have a mature solution for that.

@HeFeng1947 Sure. I don't think that you should care about it too much. For the OTBR, the co-existence of Thread and WiFi will have a much bigger impact on the throughput. And we already have a mature solution for that.

yeah, I agree with it. In fact, we test silabs's co-existence of zigbee and wifi about 2 years ago and the results not great. Silabs's solution works well with your own wifi chips, but it doesn't seem to work well with other manufacturers' wifi chips(we test with Qualcomm's ipq4019).
Please let me know if there is any new development recently.

Yes, that's true. The PTA solution is based on 802.15.2 which is not an official standard. Some of the wifi chips don't support this. It's recommended to choose those wifi chips with PTA support.
Please contact our local sales team to learn the latest status. Thanks.


Fix unintended frustum culling

When view some models in scene import settings dialog, the subviewport will have some unintended frustum culling.

Adding a custom aabb for the preview fix this bug.

The frustum culling fix is queued to be reviewed in 4.4.

This makes sense as a temporary solution, but I don't know why frustum culling would break in the first place. Is this because skinned meshes skip generating an AABB before being imported for some reason? I thought the advanced import settings dialog already imported the mesh once, with the AABB being set at import-time as an optimization (so it doesn't need to be generated by RenderingServer every frame).

@Calinou I've seen this. The AABB on skinned meshes seems wrong until the first update skeleton (e.g. if you rotate a bone and then undo). This could be the bug.
I wonder if this is a rendering server bug since I'm not sure how the AABB can get desynced, or as a hack, if there is a way to manually force an update on all skeletons during import or upon loading a scn

This makes sense as a temporary solution, but I don't know why frustum culling would break in the first place. Is this because skinned meshes skip generating an AABB before being imported for some reason? I thought the advanced import settings dialog already imported the mesh once, with the AABB being set at import-time as an optimization (so it doesn't need to be generated by RenderingServer every frame).
PS: I think we have a dedicated RenderingServer method to disable frustum culling for a specific node entirely, or do we? This would be more reliable than using a large magic number.

I dont think this is a problem of AABB. Initially I thought this was a problem of AABB but later I add
    auto show_aabb = [=](AABB aabb){
        MeshInstance3D* a = memnew(MeshInstance3D);
        auto box = memnew(BoxMesh);
        box->set_size(aabb.get_size());
        a->set_mesh(box);
        a->set_global_position(aabb.get_position()+aabb.get_size()/2.);
        a->set_transparency(.5);
        mesh_preview->get_parent()->add_child(a);
    };
    show_aabb(mesh_preview->get_aabb());

before scene_import_settings.cpp line 882 I got this

It seems the AABB generation is coreect. There's an error after adding the code node_3d.cpp:345 - Condition "!is_inside_tree()" is true. Returning: Transform3D() from get_position(). If there's better way of debugging the AABB plz let me know.
I think I've found the function for disable the culling: RenderingServer.instance_set_ignore_culling. I'll make changes to the commit later.

@Calinou I've seen this. The AABB on skinned meshes seems wrong until the first update skeleton (e.g. if you rotate a bone and then undo). This could be the bug.
I wonder if this is a rendering server bug since I'm not sure how the AABB can get desynced, or as a hack, if there is a way to manually force an update on all skeletons during import or upon loading a scn

Can you give me a way of editing the bones in this dialog? This bug only happens in this dialog. If I place this model into the scene, it works well.

This bug still exists in this commit. any update?

I don't think this is the correct fix. We need to figure why the mesh is getting incorrectly culled and then resolve the problem at the source instead of simply disabling culling.
In general, we don't merge PRs until we are happy that they are the correct fix for a problem

hmm... thanks for your reply. i will try to fix it myself.


Update NativeAOT

Ideally, I would include the remaining commits but this is close and I want to work on other parts of the project.


Remove outdated Unstoppable integration

Obsoleted by https://github.com/ScopeLift/umbra-protocol/pull/379


Vulnerability disclosure?

Hi AdrianVollmer,
I believe I may have found some potential vulnerabilities in PowerHub. Is there a way to privately disclose them to you, or should I open an (public) issue here?
BR
six-two

DM me on Twitter (@mr_mitm) or send me an e-mail (adrian.vollmer @ syss.de) pgp key

I received and decrypted your message, thanks. I'll take a look and get back to you.

See mail


Add "Serialize a URL" example for url/serde crates

Serializing urls with serde 1.0 is kinda weird, so maybe worth an example.

Hi,
I am not sure what is the exact idea for this example.
Until rust-url crate officially moves to serde-1.0 https://github.com/servo/rust-url/pull/327 the best that I've come up with is usage of auxiliary url_serde crate (but it would require adding it to Cargo.toml). Does it look ok? https://play.integer32.com/?gist=8199915f140db644a8bc3e480e582aea&version=undefined
If yes, I will make a PR.
cc @dtolnay

I would prefer to wait until we no longer need to use the roundabout approach. @SimonSapin

Will do. Thanks for your time :)

Judging from the original description I guess that the main reason for this example was the required roundabout approach.
Once https://github.com/servo/rust-url/pull/327 is merged then the Url will serialize just like any other well behaved type and this example would be redundanta with https://brson.github.io/rust-cookbook/encoding.html.
So maybe just close this issue? @dtolnay

Yes I agree.


Handle malformed login response

As of commit eed1f968:
2016-07-27 13:13:33,011 [     search] [   INFO]  6765 reqs in 01m26s  [ 78.2 reqs/s 132.4KB/s (up)  92.7KB/s (down)] 0.09s av. per request
2016-07-27 13:13:34,798 [     search] [   INFO]  6790 reqs in 01m28s  [ 76.9 reqs/s 130.3KB/s (up)  91.2KB/s (down)] 0.09s av. per request
2016-07-27 13:13:34,799 [     search] [   INFO] Scan finished. Sleeping 91.70 seconds before continuing.
2016-07-27 13:15:06,519 [     search] [   INFO] Starting scan of 6790 locations
2016-07-27 13:15:06,520 [     search] [   INFO] Login has or is about to expire
2016-07-27 13:15:06,520 [     search] [   INFO] Attempting login
2016-07-27 13:15:06,527 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:15:06,742 [   auth_ptc] [  ERROR] Could not decode response: Not found (error to origin)
2016-07-27 13:15:06,743 [     search] [   INFO] Login failed, retrying in 1.00 seconds
2016-07-27 13:15:07,749 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:15:17,885 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:15:17,887 [     search] [   INFO] Login failed, retrying in 1.80 seconds
2016-07-27 13:15:19,691 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:15:29,872 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:15:29,873 [     search] [   INFO] Login failed, retrying in 3.24 seconds
2016-07-27 13:15:33,120 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:15:43,281 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:15:43,284 [     search] [   INFO] Login failed, retrying in 5.84 seconds
2016-07-27 13:15:49,131 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:15:59,346 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:15:59,349 [     search] [   INFO] Login failed, retrying in 10.52 seconds
2016-07-27 13:16:09,877 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:16:20,040 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:16:20,041 [     search] [   INFO] Login failed, retrying in 18.94 seconds
2016-07-27 13:16:38,999 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:16:49,204 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:16:49,207 [     search] [   INFO] Login failed, retrying in 34.10 seconds
2016-07-27 13:17:23,336 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:17:23,480 [   auth_ptc] [  ERROR] Could not decode response: Not found (error to origin)
2016-07-27 13:17:23,480 [     search] [   INFO] Login failed, retrying in 61.41 seconds
2016-07-27 13:18:24,939 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:18:35,107 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:18:35,108 [     search] [   INFO] Login failed, retrying in 110.60 seconds
2016-07-27 13:20:25,805 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:20:36,000 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:20:36,002 [     search] [   INFO] Login failed, retrying in 199.16 seconds
2016-07-27 13:23:55,232 [   auth_ptc] [   INFO] Login for: ***
2016-07-27 13:24:05,431 [   auth_ptc] [  ERROR] Server timed out
2016-07-27 13:24:05,432 [     search] [   INFO] Login failed, retrying in 300.00 seconds
2016-07-27 13:29:05,502 [   auth_ptc] [   INFO] Login for: ***
Exception in thread search_thread:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/local/lib/python2.7/threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "pogom/pogom/search.py", line 233, in search_loop_async
    search_async(args)
  File "pogom/pogom/search.py", line 158, in search_async
    login_if_necessary(args, step_location)
  File "pogom/pogom/search.py", line 110, in login_if_necessary
    login(args, position)
  File "pogom/pogom/search.py", line 93, in login
    while not api.login(args.auth_service, args.username, args.password):
  File "pogom/pogom/pgoapi/pgoapi.py", line 151, in login
    if not self._rpc.auth_provider.login(username, password):
  File "pogom/pogom/pgoapi/auth_ptc.py", line 62, in login
    self.log.error('Could not decode response: {}'.format(r.content.decode('utf-8')))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 296: ordinal not in range(128)

Actually I suppose this is a bug in pgoapi, but it might be nice if you caught it and treated it as a login failure and continue retrying.
Closing.

Fixed in 5c3b1bbc819097452f2ddc279bb16dbbc51000d9


Manual osx migration

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This is ready for review @conda-forge/gnuplot @conda-forge/help-osx-arm64
Fixes #32 #42

@isuruf, would you have some time to review this? I have very little knowledge of our cross compiling setup.

@conda-forge/help-osx-arm64 is probably the right team to ping :)

I’ve already chimed in! I think it looks good as I said but a gnuplot maintainer would need to officially approve.

Oh I didn't know you're part of the osx-arm64 team @erykoff. Thanks for this!
@croth1 - are you happy with @erykoff's review, who is part of the official migration team?

Okay, then I will trust your judgment here @erykoff :)

Thanks @Tobias-Fischer for putting in all the effort and make it work! Very much appreciated!


Responsive Layout for Mobile Devices

I've been playing with:

Sweet IPFS (go-ipfs for Android packaged by a community member)
Firefox for Android Beta (runs the same webextensions as desktop version)
ipfs-companion beta v<IP_ADDRESS>70 (bundles new ipfs-webui)

I opened bundled Web UI and it works as expected :1st_place_medal:   \o/ but is missing some low hanging fruits such as collapsing  left menu on narrow viewport:

Status
Files
Settings

Rad! That'd be a pretty simple fix.

Scientists was so preoccupied with if they could, they didn't stop to think if they should

it was not simple.

Fixed in #877.

I'm happy to close this for now, but there is a ton of polishing to do to actually have a good reponsive layout, but that is a low pritority for now.

Yes, I jumped the gun closing this one because I thought it was only referring to the navbar responsiveness.
We can reopen it later when someone starts working on it!


0.1.1 Release isn't at the latest master

I think when you cut the release you didn't have the latest master, it's missing the changes I made to the ember-pusher library. Thanks!

@ivanvotti you able to take care of this please?

@dasnixon Actually I'm going to stop maintaining this repo and the ember cli wrapper. Instead I'll make an ember addon that will have no bower dependencies. Maybe on these weekends.

Sweet, thanks for the update.


URL of build is undefined

it seems that the Post hook format has changed or smth,
but all it got was :
Jenkins develop FINALIZED with SUCCESS undefined
Phase
----------------
FINALIZED

Status
----------------
SUCCESS

more sha info or full url might be cool :) (might be a bug or smth thing)
the post message look like this
{ name: 'feature%2Fexport',
  url: 'job/profiler/branch/feature%252Fexport/',
  build:
   { number: 4,
     queue_id: 22108,
     phase: 'FINALIZED',
     status: 'FAILURE',
     url: 'job/profiler/branch/feature%252Fexport/4/',
     scm:
      { url: 'git@bitbucket.org:profile/repo.git',
        branch: 'origin/feature/export',
        commit: '407adc3acc1a86a6c2a4ffc575a2b997f62b98a2' },
     log: '',
     artifacts: {} } }
{ message: { room: '#dev-ci' },
  content:
   { fields: [ [Object], [Object] ],
     color: 'danger',
     pretext: 'Jenkins feature%2Fexport FINALIZED with FAILURE undefined  <undefined|4>',
     fallback: 'Jenkins feature%2Fexport FINALIZED with FAILURE undefined  <undefined|4>' } }

Seems that setting the url of jenkins in the settings solve the URL issue,
but i'm still unable to see the commit or the project...


Ready for use with serde?

Hi, I'd like to be able to serialize and deserialize bitvecs via serde. I saw the latest commit b513a38 seems to make some progress towards that, but it's failing to build for me:
error[E0609]: no field `arr` on type `&wide::u64x4`
   --> src/lib.rs:214:5
    |
214 |     arr: [u64; 4]
    |     ^^^ unknown field

error[E0560]: struct `wide::u64x4` has no field named `arr`
   --> src/lib.rs:214:5
    |
214 |     arr: [u64; 4]
    |     ^^^ `wide::u64x4` does not have this field

I'm very new to Rust so I'm not totally sure what the problem is, but from inspecting wide, it looks like u64x4 has a variety of possible underlying definitions depending on the SIMD features of the compile target.
Is serde support not ready yet, or am I perhaps just doing something wrong?

Commit b513a38 is a temp version of serde function. New serde support has been updated and now it should work.


Fixes bug in compare_user on Linux systems

Description
d4c3b8ad111ec7ff6b32ebccf9edd1b6a2f9e8e2 introduced a bug making compare_user on Linux systems return %i{expire_date inactive} instead of wether @change_desc is empty.
Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@marcparadise @jaymzh This looks like it should fix the user resource for subsequent runs failing with calling usermod with no flags. Also see community slack for more information if needed https://chefcommunity.slack.com/archives/C55FCUGBS/p1664542267513479.

Thanks for this, this is a good catch!
I have put one request inline; separately in the spirit of 'if we had tested this function earlier, this would have been caught sooner' - can you add unit (and ideally functional) test cases to cover this?

Hi, I would love to add a functional test, but I don't have experience in this matter. I'll see what I can do. As I view it, there should be a linux_user_spec.rb alongside mac and windows in spec/functional/resource/user?

@tpowell-progress can help out with this

The current openSUSE build failure is a related to the build container at first glance, and not this PR.


FIXED: Separating the Rule DB in transmitter/receiver to enable

This allow cleaner implementation of rules for mutual authorization.

Current coverage is 54.69% (diff: 100%)

Merging #89 into master will increase coverage by 0.04%

@@             master        #89   diff @@
==========================================
  Files            19         19
  Lines          3140       3143     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1716       1719     +3
  Misses         1307       1307
  Partials        117        117

Powered by Codecov. Last update ce47988...e7aa466


loadPayments is executed twice when Home is rendered

Describe the bug
The loading/mounting of the home screen has to be reviewed.
It seems loadPayments is executed twice - once when the allowance is set and once without.
This leads to showing all payments even though there is an allowance set (and only the payments of that allowance should be shown)
Screenshots

To Reproduce
Steps to reproduce the behavior:

Make sure you have an allowance with payments
Open the popup
Only the payments of that website/allowance should be shown
But all payments a re shown

Expected behavior
Home rendering needs to be reviewed and we must make sure that those functions are only called once.
And we must make sure that payments are loaded in the current allowance context - meaning when an allowance for the current website is available, then we only show payments of that website.

I think this was introduced with the settings change?

Relates and/or duplicates #1347

As discussed the loading of payments twice is not really a bug as the effect chain does work correctly.
The problem is that the allowance is taking longer to load than the loading of payments.
And if allowance changed, the loading of payment is called again as this is one of its dependencies.
=> see code https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/screens/Home/index.tsx#L150
To solve this we agreed on refactoring the whole Home screen with:

[ ] divide view in two screens "Allowance"  and "Default"
[ ] load allowance on mount
[ ] if allowance exist => render Allowance Screen with already existing payments (allowance.payments)
[ ] otherwise render Default view and load all payments from DB

I opened a new ticket for the Home Refactoring:
https://github.com/getAlby/lightning-browser-extension/issues/1359
And opened a PR to fix only this problem.


⚠ Bofrost.de has degraded performance

In 351da3d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 981 ms

Resolved: Bofrost.de performance has improved in 97fcdfa after 47 minutes.


set and get dynamic data array

My validate login form print this array:
Array
(
    [0] => The Customer Name field is required
    [1] => The Customer Password field is required
    [2] => The Email field is required
    [3] => The Gender field is required
    [4] => The Credit Card field is required
)

how do can i send data to login/index using addData method like this:
    $this->templates->addData([`??` ], 'login/index');

and get in login index?!
Thanks for any help

$errors = [
    'The Customer Name field is required',
    'The Customer Password field is required',
    // ....
];

** @var \League\Plates\Engine $engine */
$engine->addData(['errors' => $errors], 'login/index');
// or...
$engine->render('login/index', ['errors' => $errors]);

...in your [path_to_templates]/login/index.php
<?php foreach ($errors as $error): ?>
    <?=$error ?><br>
<?php endforeach ?>

@napec Thank you for your response. @S3lfC0d3r @napec's response is precisely the way to go about this.
If you have any other issues let me know, otherwise, i'll close this issue. Thanks!

@napec @ragboyjr Sorry For Delay I'm So busy.
@napec I think your method good work but not complete:
with your method i need to style error(ie: bootstrap danger alert into div) before template then send array to template and print. in action i need to print each error into div in template not in my code(ie: controller Or Class).

@napec @ragboyjr Sorry For delay Im so Busy..
Thanks @napec Good Work.


Try to fix release CI with abi3 wheels

Fixes #19

Kinda odd that maturin did not find pyo3 with abi3 on Windows & macOS but worked on Linux.

Kinda odd that maturin did not find pyo3 with abi3 on Windows & macOS but worked on Linux.

But it does work on my local macOS machine:
❯ maturin build
🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.6
🐍 Not using a specific python interpreter (With abi3, an interpreter is only required on windows)
...
...
📦 Built wheel for abi3 Python ≥ 3.6 to target/wheels/cramjam-1.3.2-cp36-abi3-macosx_10_7_x86_64.whl

But it does work on my local macOS machine:
❯ maturin build
🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.6
🐍 Not using a specific python interpreter (With abi3, an interpreter is only required on windows)
...
...
📦 Built wheel for abi3 Python ≥ 3.6 to target/wheels/cramjam-1.3.2-cp36-abi3-macosx_10_7_x86_64.whl

I noticed this after I made the release, but didn't have time to investigate and see as you point out, on Mac and Windows it doesn't seem to create the abi3; I may have time later this week to poke around as well.
Worst case, we use abi3 for unix and normal per-python wheels on Mac/Windows? :man_shrugging:

I noticed this after I made the release, but didn't have time to investigate and see as you point out, on Mac and Windows it doesn't seem to create the abi3; I may have time later this week to poke around as well.
Worst case, we use abi3 for unix and normal per-python wheels on Mac/Windows? :man_shrugging:


fix bad yaml

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@cj-write thank you for your help. I have a few data files that are used for the tests. They are decent in size and I don't want every user to have to download them. So I need to make it so that those files aren't included but get downloaded if they are needed.
That's what was causing that error. I would really like to be able to run pytest within the conda workflow, so I'll fix up that data file download issue.

That's fine. The issue in the meta.yaml was causing problems with the auto update bot so this PR was to get that working again.

Ahh sorry about that. I did wonder how pymedphys all of sudden got so much attention overnight.

Don't worry about it


[feature] support to terminate task and train other task.

TODO: we need a "dashboard" to show the adapters' loss curve and terminate it early when the loss is abnormal.

CI TEST: https://github.com/TUDB-Labs/mLoRA/actions/runs/9725650566/job/26843232038


DTR in Tractus X tutorial >> Restrict Data

See the documentation from the following link --> https://eclipse-tractusx.github.io/docs/tutorials/e2e/boost/restrictData

child of https://github.com/eclipse-tractusx/sig-release/issues/634

Currently a fork branch exists with all changes. There is a new section for DTR Tutorial:
https://github.com/jkbquabeck/eclipse-tractusx.github.io/blob/main/docs/tutorials/e2e/boost/DTR_Tutorial.md
And one open PR to describe the access control in DTR:
https://github.com/jkbquabeck/eclipse-tractusx.github.io/pull/6


[terra-form-select] Fix behaviour wrt announcing selected/not selected state

Summary

What was changed:

Removed aria-checked from terra-form-select/src/shared/_Option.jsx.
Updated focus to shift on select based on browser.
Updated documentation, encouraging consumers to use Single Select Field.

Why it was changed: For JAWS to announce Selected instead of checked.
Testing

This change was tested using:

[ ] WDIO
[x] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[x] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9100

Thank you for contributing to Terra.
@cerner/terra

All the comments were addressed as part of this PR. Created a new PR to fix wdio issues.

Is there a reason a new PR was created? Just confused between the relation between wdio & creating a new PR.


Modularise

Part of the modularisation refactor -- removed everything but the actual integration pipeline. This module now only exports
function tracegeodesics(
    m::AbstractMetricParams{T},
    init_positions, init_velocities,
    time_domain::Tuple{T,T}
    ;
    μ = 0.0f0,
    callbacks=Nothing,
    solver=Tsit5(),
    solver_opts...
    ) where {T}
end

Still requires linking with GeodesicBase.jl

Docs, README, and Project.toml also need updating

Toying with the idea of a self-hosted registry to better resolve dependencies. Will merge this branch for now, and decide on how projects will link together later.


Make Bodypart fields public

Fixes #214.
I'm not 100% sure if there was a reason we had them private to begin with? If there was, then maybe this could be addressed with accessor methods instead.
I've added a _non_exhaustive field to make it a non-breaking change to add new properties (not that that matters that much).

I don't get the _non_exhaustive() hack?
Regardless, adding new public variables can't break anything, can it?

Yeah, I was referring to adding new public fields of Bodypart in the future, like if they added a mechanic like boosting parts, but with with power. Or any other change to that struct?
The only reason the _non_exhaustive: () field is there is that if a struct has only public fields, it would be a breaking change to add a new one since then old code doing let Bodypart { boost, part, hits } = bodypart; would no longer capture all fields and would error. Another case would be constructing it - this prevents let x = Bodypart { boost: x, part: y, hits: z }, which would also succeed but fail to compile if we ever add fields.

I don't have any fields in particular I want to add in the future, but this would let us do that if we ever want to. I would only consider doing it if the JavaScript representation added fields first.


[docs] add a vision document for Swift -> C++ interoperability

This is a draft Swift and C++ interoperability vision document that describes how Swift APIs are going to interoperate with C++.
Rendered markdown is here:
https://github.com/hyp/swift/blob/eng/re-road/docs/CppInteroperability/SwiftToCppInteroperabilityVisionDocument.md

This is awesome, thanks Alex!

@compnerd @zoecarver @rjmccall this is ready for another round of review.

@rjmccall I updated the document following all the feedback here, please let me know how it looks now.

This PR has been superseded by https://github.com/apple/swift-evolution/pull/1885 as the vision document has been approved by the Swift language workgroup.


Support for accessing and mutating the timestamp mode on the LiDAR

The on-LiDAR timestamp_mode can now be set in the config file. Additionally,
its state is fedback in the GetMetadata service.
I HIL-tested these changes via visual inspection and everything seems to
be working correctly. I see that in #10 there is a plan add some
automated testing. I think this is a very good idea. I'll add some comments
to that issue shortly.
Closes: #34

Looks good- the only other ask I think is also supporting a ROS time as well. It won’t be well synchronized but if they’re not using PTP then the clocks could diverge either way.

In terms of implementation for a ROS timestamp... I suggest we add a separate parameter (bool flag, default False) like use_reception_timestamp whose semantics indicate to explicitly ignore the LiDAR timestamp. Additionally, when running in this way, we should emit a log message at WARN level (once) alerting that we are applying timestamps in this way. I say that because, we know that the ROS time is explicitly incorrect and we have no real good way (without using something like PTP) to model how incorrect the stamp is. I'm happy to do this, but, wanted to share how I would plan to implement it. Do you agree?
Also, I would suggest we separate that out into its own PR as it sort of conflates issues. This PR focuses on which stamp is applied by the LiDAR. The subsequent one would handle whether or not use use the LiDAR stamp or a ROS timestamp (at time of data reception, not when the data are sampled).
LMK what you think.

I guess we could add something like TIME_FROM_ROS_RECEPTION in the timestamp_mode enum to keep the code cleaner. But, I'd still suggest we emit a warning since we know the stamp we are using is explicitly wrong.

That sounds reasonable. It also may be valuable in the readme to explicitly describe what those 3 modes do and why time syncing is important. I’ve run into PTP before from having clock skew issues but I wonder if its something we should specially mention the importance of and a one liner to enable on the host machine so the lidar can be a slave.

I’m working on a write up that I’ll post publicly on this topic specifically — PTP time sync using a Linux host as the PTP grandmaster and an Ouster LIDAR as a slave.  It will be easiest to link to it from the README once I publish, it’s more than a one-liner (it will happen this week). PTP claims accuracy to w/in +/- 1 usec while the Ouster docs claim +/- 50 usec. I want to characterize the OS1 specifically and see how to best tune it. What I have seen so far is that it oscillates rather wildly (+/- 200 users) around the set point (0, offset from master). I still have more analysis to do. Depending upon what I find out I may see if Ouster will expose some more knobs to the underlying ptp4l configuration so we can tune the servo params over the tcp interface.

@SteveMacenski There is a change I'd like to make to the last commit. Please hold-off on merging.

I'm good.

Thanks! I also added you as a collaborator if you check your email linked to github. Welcome and thanks!

Thanks Steve. Happy to collaborate with you.


What are these for?

Document why default apps come with this. https://github.com/meteor/guide/issues/314

The only documentation I can find is "use this when you want to use npm packages on the client". Some explanation how the package works and what it does (not) accept would be useful.

The meteor-node-stubs npm package provides browser-friendly implementations of Node's built-in modules, like path, buffer, util, etc, similar to the way Webpack, Browserify, and other bundlers handle built-in modules. Meteor's module system avoids actually bundling any stub modules (and their dependencies) if they are not used, so there is no cost to keeping meteor-node-stubs in the dependencies. In other words, leave meteor-node-stubs installed unless you really know what you're doing.

I've updated this in the guide as well https://github.com/meteor/guide/commit/4bd5f33b3c9a9051cfded3b26976f5eb00f62fc2


fix(datasource): saving new calculated columns

SUMMARY
Creating a new calculated columns isn't working.
Because the datasource is receiving a string ID from the frontend, which is resulting in invalid input.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
https://user-images.githubusercontent.com/66589759/233795894-eb6dec1e-2cbd-41fd-b8ee-1e7cc8dd4f45.mp4
After
https://user-images.githubusercontent.com/66589759/233795877-8eeb553c-e2b4-4150-8f5a-ba62cee8fc46.mp4
TESTING INSTRUCTIONS

Go to any datasource
Add calculated column
See an error

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

CC @jfrag1 #23678

Hello!
Integration test cases have returned an error, but there were no errors on the source branch from where I created the PR. Could we please re-run the CI tests?
Thanks!


Change fluent-plugin-elasticsearch dependency to fluent-plugin-opensearch

Problem
The current version will not work with AWS OpenSearch (the new name for AWS ElasticSearch) unless the ElasticSearch dependency is locked to an old one prior to the re-licencing.
Steps to replicate
Use this plugin, without locking the ElasticSearch dependencies, against AWS OpenSearch/ElasticSearch and it will error.
Expected Behavior or What you need to ask
It should work so this plugin should switch to using the fluent-plugin-opensearch.

We needn't inherit fluent-plugin-opensearch.
And we still need to maintain this plugin for old AWS OpenSearch instances before Elasticsearch 7.10.
see: https://github.com/uken/fluent-plugin-elasticsearch/issues/915#issuecomment-1012244803


Generic Host topic updates

Fixes #9278
Internal Review Topic

Clarifying what's set where.
Slight re-organization to the host config section. See if this content layout makes sense.

@Tratcher I worked on your feedback, and I updated the links.

I try an approach that details the method (extension or method) in the section heading and adds the class to the link text.

@scottaddie I think the last commit takes care of your feedback items. Let me know if it needs more work.


Push3DView don't work, please help

I added Push3DView function like this:
`class RenderView {
public:
INCONSTRUCTIBLE(RenderView)
VIRTUAL_METHOD(void, setBlend, 4, (float alpha), (this, alpha))
VIRTUAL_METHOD(void, setColorModulation, 6, (const float* colors), (this, colors))

VIRTUAL_METHOD(void, Push3DView, 43, (RenderContext* pRenderContext, const ViewSetup& view, int nFlags, ITexture* pRenderTarget, Frustum frustumPlanes), (this, pRenderContext, std::cref(view), nFlags, pRenderTarget, frustumPlanes))
VIRTUAL_METHOD(void, PopView, 45, (RenderContext* pRenderContext, Frustum frustumPlanes), (this, pRenderContext, frustumPlanes))

void setColorModulation(float r, float g, float b) noexcept
{
    float color[3]{ r, g, b };
    setColorModulation(color);
}

};`
but it doesn't work. What am i doing wrong?

Just stop trying if you already fail at this stage, paste. All you need to do is already in the post https://www.unknowncheats.me/forum/counterstrike-global-offensive/347519-draw-model.html
Also this method wont work for mainmenu 😄


Torch

Can you add torch?

Can you add torch?

The torch is add, please check the latest version.
dependencies:
qrcode: ^1.0.2


User state not updated as expected after approving a user

My Setup

Operating System: Win10
App Version: 2.17.9
Installation type: exe
[X] I have tested with the latest version
[X] I can simulate the issue easily

Description
When an administrator approves a user in the Administration - Users window, the status of the user is not refreshed.
Step by step:

As an admin you receive the request to approve a user
Open the administrator - users window
Click on the user at the top of the list, three dots icon and activate
The user in the list is still marked as deactivated
Click on Rooms and then back to Users from the Administration panel
Now the user is list  is correct

Current Behavior
The users list is not updated after a change on a user
Expected Behavior
An automatic refresh of the user list/state is expected

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


number field does not allow input from MacOS Japanese IME keyboard

Provide a general summary of the issue here
React Aria's NumberField does not allow input from Japanese keyboard on MacOS.
https://github.com/adobe/react-spectrum/assets/42168740/4f3782ff-298e-4ed0-97b9-39eae176768c
<input type='number' />
https://github.com/adobe/react-spectrum/assets/42168740/cebaf076-ce45-4e0b-9375-8ba51fea361a
🤔 Expected Behavior?
The number field receives value from the keyboard.
😯 Current Behavior
The number field does not receive value from the keyboard.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce

Switch input to Japanese.
Visit https://react-spectrum.adobe.com/react-aria/useNumberField.html#example
Press a number on the keyboard.

Version
latest
What browsers are you seeing the problem on?
Firefox
If other, please specify.
No response
What operating system are you using?
MacOS Sonoma 14.5
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

This may be due to me not knowing Japanese or maybe not knowing enough about the keyboard and IME input, however, if I change to a Japenese keyboard on my mac and type the 1 key, this is what I get ぬ which I don't think is a number as I think that is 一. I can't get the IME to show up on a native input type=number outside our docs. Could you include some more instructions for bringing it up?
That said, I have some guesses. I think we're preventing the IME from appearing possibly by not accepting any characters other than the supported numbering system symbols. Maybe we can lift that restriction during composition.

Gladly. The keyboard I'm using is Japanese - Romaji. I've included a screen capture for adding it below.
https://github.com/adobe/react-spectrum/assets/42168740/0a3b4ab3-aadf-432f-899b-fe00839cacf8
I'm using Options + Space to change my keyboard input to Japanese, but I'm not sure if yours would be the same.

Yeah, I was able to reproduce. It seems like it kinda works in Safari though (at least for me), and I noticed that it doesn't work in RSP NumberField either.

The input kinda works for Safari but there's a weird bug when you are cycling between the options.
https://github.com/adobe/react-spectrum/assets/42168740/57493596-cf1d-4e5c-b638-2798a17c3c67


New Services & 404 Page

Reference Issues/PRs
#35 #36  #46
What does this implement/fix? Explain your changes.

Add Hacker News & Yahoo Mail services
Add a custom 404 page (will be enabled on the main domain)
Minor edit on the primary color of the project to make it a bit lighter

Any other comments?

Thank you Fatemeh @F-Shahali for your effort, I liked the 404 page a lot! nice one!
I tested Yahoo and Hacker News, they both worked fine, but WhatsApp didn't worked well, the link for href is undefined.

@sepandhaghighi let us know your review too.
Thanks.

Thank you Fatemeh @F-Shahali for your effort, I liked the 404 page a lot! nice one! I tested `Yahoo` and `Hacker News`, they both worked fine, but `WhatsApp` didn't worked well, the link for `href` is `undefined`.
It happened in the direct mode, and in the indirect mode after clicking on the service icon, it ends up with infinite loading.
I'm in desktop and I do have WhatsApp installed.

So happy you liked it!
Thanks for your report, I'll fix it.


Listener only called once

Using Bond 2.0.1,  in an empty project
When I write this basic code :
var foo = Dynamic<Int>(0)

foo ->> { foo in
    println("foo changed: \(foo)")
}

foo.value = 1
foo.value = 2
foo.value = 3
foo.value = 4

It logs :
foo changed: 0

but I think it should do this :
foo changed: 0
foo changed: 1
foo changed: 2
foo changed: 3
foo changed: 4

Hi Raphaël, this is actually a feature. Bond exists while it is retained by someone. Designated Bonds on UIKit objects are retained by those objects. You should retain a Bond you create For example, you can save it in a property.
var myBond: Bond<String>?

...

self.myBond = foo ->> { foo in
    println("foo changed: \(foo)")
}

Thanks for the issue though, documentation was probably not clear on this, will have to improve it.

Thanks, I was going nuts !
Yes most of the documentation is centered around UIKit items.
I'll see if I have time to propose a PR for the doc.
Thank you for the quick answer!