[SPARK-5078] Optionally read from SPARK_LOCAL_HOSTNAME

Current spark lets you set the ip address using SPARK_LOCAL_IP, but then this is given to akka after doing a reverse DNS lookup. This makes it difficult to run spark in Docker. You can already change the hostname that is used programmatically, but it would be nice to be able to do this with an environment variable as well.

Test build #25039 has started for   PR 3893 at commit 85045b6.

This patch merges cleanly.

Test build #25039 has finished for   PR 3893 at commit 85045b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25039/
Test PASSed.

I put some thoughts on a new JIRA about how to clean this up overall in Spark - as for this patch. I'm fine to merge it, but it would be good if we did a proper clean-up of this for 1.3.
https://issues.apache.org/jira/browse/SPARK-5113

Okay let's pull this in for now. Don't want to block this on SPARK-5113.


Update input data usage to loop through to match user-specified sequence length

InferContext and SequenceManager no longer force sequence length to be equal to number of inputs in input data json
User can set sequence length, and InferContext/SequenceManager will loop through input data json accordingly

LGTM pending Elias looking at the gmock changes


Compile Static Resources

Is your feature request related to a problem? Please describe.
This issue is not related to any bug or problem.
Describe the solution you'd like
I was wondering why it is not feasible to compile and link static resources into the executable. If my memory serves me correctly, windows did this for bitmaps and meta??? files. Presently, a canonical Drogon Application consists of (1) the executable (2) database - say, SQLite3, (3) config.json, and (4) directory tree of static resources: CSS, Javascript, image files etc.. The executable maintains the full pathnames of these resources. Go web apps have similar behavior, but does not specify a config.json file.
Describe alternatives you've considered
None considered.
Additional context
Decreasing software entropy requires minimizing the files that have to be deployed for installation. Thus compiling the resources and linking them into the executable would appear to be desirable.
Thank you. By the way, this is a great project.

You should do some works for this, refer to CPP / C++ - Embed Resources Into Executables

Thank you kindly.


CIS Hardening Guide for v2.6

Placeholder until more details are available.

@btat This https://github.com/rancher/docs/pull/3761 is a first PR where I briefly restructured the contents of the security area in the docs and mentioned that a new version of the hardening guides is coming. IMO this PR can be quickly approved in the meantime.
I'm working on a second PR with the updates itself to the hardening guides. I'll let you know when it's ready.

Original issue is https://github.com/rancher/rancher/issues/35735

@btat Please see https://github.com/rancher/docs/pull/3810 for the final PR.

@btat FYI this is also a proposal to update K3s hardening guide - https://github.com/rancher/docs/pull/3897.

@btat both Rancher/RKE and K3s hardening guides are updated in master. It should be okay to close this issue.


Path aliases are not working properly with files

Describe the bug
SWC does not correctly resolve path aliases for standalone files.
in the config, I have a mapping
{
    "baseUrl": ".",
    "paths": {
      "utils/*": ["./src/utils/*"],
      "~/container": ["./src/container.ts"]
    },
}

SWC work perfectly with aliases to directories. However, it doesn't add the extension to the resolved file alias
so, instead of ./container.js it outputs ./container which is invalid import
Reproduction
Sorry, I could not make it work in Stackblitz, so I just created a repo, but the example is clear
input
output
Input code
// helper.ts

import { MyContainer } from '~/container';

export const helper = () => {
  const container = new MyContainer('helper');

  container.print();
};

Config
{
  "$schema": "https://json.schemastore.org/swcrc",
  "sourceMaps": true,
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false,
      "decorators": true,
      "dynamicImport": true
    },
    "baseUrl": ".",
    "paths": {
      "utils/*": ["./src/utils/*"],
      "~/container": ["./src/container.ts"]
    },
    "target": "es2020",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "es6"
  },
  "minify": false
}

Playground link
No response
Expected behavior
import { MyContainer } from "../container.js";
export const helper = ()=>{
    const container = new MyContainer('helper');
    container.print();
};

Actual behavior
import { MyContainer } from "../container";
export const helper = ()=>{
    const container = new MyContainer('helper');
    container.print();
};

Version
^1.3.50
Additional context
No response

Related to
https://github.com/swc-project/swc/issues/4585#issuecomment-1219984287

Did you try npx tsc from your repro? tsc generates
import { MyContainer } from '~/container';
export const helper = () => {
    const container = new MyContainer('helper');
    container.print();
};
//# sourceMappingURL=helper.js.map

and it seems like '~/container' is not transpiled at all.


String concatenation causes an error

version:
node version: v9.4.0
npm (or yarn) version: npm 5.6.0 yarn 1.6.0

Do you want to request a feature or report a bug?:
bug
What is the current behavior?:
Following code
import { defineMessages } from 'react-intl'

export default defineMessages({
  successMessage: 'Some long string  string  string  string  string  string  string  string' +
    '  string  string '
})

Produces an error:
[React Intl] An `id` must be provided to format a message.

What is the expected behavior?:
String concatenation should be handled without an error
Suggested solution:
Can't propose a solution for now.

Consider using Template literals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Fixed #47


network-manager-applet does not prompt for wifi passphrase when selecting a new network

Issue description
networkmanagerapplet (a.k.a. nm-applet) does not prompt for wifi passphrase when selecting a new network.
The problem can be circumvented by with services.gnome3.gnome-keyring.enable = true; or by using nmtui instead of nm-applet.
This started happening with 8dc518c2dfb58e986d5ea2ddc5a630862725276f which removed the dependency of nm-applet on gnome3.libgnome-keyring (among other things).
@jtojnar made two good points:

nm-applet can used other keyrings (https://github.com/NixOS/nixpkgs/commit/8dc518c2dfb58e986d5ea2ddc5a630862725276f#r28366386)
the fact that nm-applet silently fails when no keyring is available is an upstream bug (https://github.com/NixOS/nixpkgs/commit/8dc518c2dfb58e986d5ea2ddc5a630862725276f#r28369001)

I commented on the upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=750290#c3 but that bug has been open for 3 years now, so not holding my breath.
From the user's perspective, this is a pretty big regression: Consider the case of a user using the XFCE desktop manager, or nm-applet with i3. When upgrading from 17.09 to 18.03, this user will no longer be able to punch in wifi passphrases when s/he join new networks.
Unless someone has a better idea, I'd suggest adding back the dependency of on gnome3.libgnome-keyring in networkmanagerapplet (and/or any other dependency that's required to fix this issue).
Cc @jtojnar (and @volth / @yegortimoshenko who seem to be doing lots of XFCE work)
Steps to reproduce

Install NixOS 18.03 or unstable with XFCE desktop manager.
Attempt to join a new Wifi network secured by a PSK
The popup window prompting for the key never appears

is it related to gnome-keyring?
I see that WiFi passwords are saved in plain-text in /etc/NetworkManager/system-connections/
And the dialog does prompt for WiFi password (it does not for VPN, but it another bug):

Ah, sorry.
I'm using master from 2016-03-20, a bit before merging https://github.com/NixOS/nixpkgs/pull/36893 which caused the regression

Do you have a configuration.nix to reproduce this in QEMU? Perhaps with mac80211_hwsim.

Ok, here comes the repro:
{ config, pkgs, ... }:

{
  boot.kernelModules = [ "mac80211_hwsim" ];

  networking.networkmanager.enable = true;
  services.xserver.enable = true;
  services.xserver.libinput.enable = true;
  services.xserver.displayManager.lightdm.enable = true;
  services.xserver.desktopManager.xfce.enable = true;
  # services.gnome3.gnome-keyring.enable = true;

  users.extraUsers.guest = {
    isNormalUser = true;
    uid = 1000;
    initialPassword = "";
    extraGroups = ["users" "wheel" "networkmanager"];
  };
}

Then the usual:
nix-build -E '(with import <nixpkgs/nixos> { configuration = import ./configuration.nix; }; vm)' && rm -vf nixos.qcow2 && ./result/bin/run-nixos-vm

And finally inside the VM:
nmcli dev wifi hotspot ifname wlan1 ssid Test\ Wifi password testitnow123

(I wasn't able to get hostapd to work)
From there, you'll see the network appear in the menu but won't be able to connect. Will work fine with nmtui.
Uncomment the services.gnome3.gnome-keyring.enable line in the config and the password prompt now works fine.

Cool. When I kill nm-applet and then run it in a terminal, I can see the following output:
** Message: 07:33:19.892 Remote error from secret service: dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files

The message seems to come from libsecret itself.

@jtojnar, so this confirms your theory but how do we fix this in a way that's user friendly?

A note in release notes is friendly enough for me.
Other than that, if upstream is unable to reproduce it, we could try to find the offending codepath ourselves.
I tried running gdb --pid=$(pidof nm-applet) with
{
  …
nixpkgs.config.packageOverrides = super: {
    libsecret = enableDebugging (super.libsecret.overrideAttrs (super: {
      patches = [
        (pkgs.writeText "trap.patch" ''
          --- a/libsecret/secret-util.c
          +++ b/libsecret/secret-util.c
          @@ -125,7 +125,7 @@
           	remote = g_dbus_error_get_remote_error (*error);
           	if (remote) {
           		if (g_dbus_error_strip_remote_error (*error)) {
          -			g_message ("Remote error from secret service: %s: %s",
          +			g_error ("Remote error from secret service: %s: %s",
           			           remote, (*error)->message);
           		}
           		g_free (remote);
        '')
      ];
    }));
    networkmanager = enableDebugging super.networkmanager;
    networkmanagerapplet = enableDebugging super.networkmanagerapplet;
  };

  environment.enableDebugInfo = true;

  environment.systemPackages = with pkgs; [
    gdb
  ];
}

It trapped correctly after creating the hotspot and typing continue. backtrace produced the following:
#0  0x00007fa9e3311321 in _g_log_abort () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#1  0x00007fa9e33125fb in g_logv () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007fa9e331274f in g_log () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007fa9e2b88f7f in _secret_util_strip_remote_error (error=0x7fff79f1cbe8) at libsecret/secret-util.c:128
#4  0x00007fa9e2b88fa8 in _secret_util_propagate_error (async=async@entry=0x174bc30, error=error@entry=0x7fff79f1cbe8) at libsecret/secret-util.c:113
#5  0x00007fa9e2b853f8 in secret_service_search_for_dbus_paths_finish (self=<optimized out>, result=result@entry=0x174bc30, unlocked=unlocked@entry=0x7fff79f1cbf0, locked=locked@entry=0x0,
    error=error@entry=0x7fff79f1cbe8) at libsecret/secret-paths.c:583
#6  0x00007fa9e2b7a8ac in on_delete_searched (source=0x15ab5e0, result=0x174bc30, user_data=<optimized out>) at libsecret/secret-methods.c:1627
#7  0x00007fa9e38a4b76 in g_simple_async_result_complete () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#8  0x00007fa9e2b82d33 in on_search_items_complete (source=0x15ab5e0, result=0x7fa9c80045e0, user_data=<optimized out>) at libsecret/secret-paths.c:316
#9  0x00007fa9e38b6c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#10 0x00007fa9e38b7636 in g_task_return () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#11 0x00007fa9e38f5fc9 in reply_cb () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#12 0x00007fa9e38b6c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#13 0x00007fa9e38b7636 in g_task_return () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#14 0x00007fa9e38eaae9 in g_dbus_connection_call_done () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#15 0x00007fa9e38b6c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#16 0x00007fa9e38b6c49 in complete_in_idle_cb () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#17 0x00007fa9e330b7e5 in g_main_context_dispatch () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#18 0x00007fa9e330bbb0 in g_main_context_iterate.isra () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#19 0x00007fa9e330bc3c in g_main_context_iteration () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#20 0x00007fa9e38cc95d in g_application_run () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#21 0x00000000004108c7 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:81

Unfortunately, it is not very helpful due to all the threads and services. Not sure how to debug it better.

Other than that, if upstream is unable to reproduce it, we could try to find the offending codepath ourselves.

Very nice effort on the debugging. I learned a few tricks reading that comment, so thanks.

A note in release notes is friendly enough for me.

I must say I wholeheartedly disagree. I understand that NixOS targets power-users but finding yourself with a host that you can't get on the network after install/upgrade without any obvious error messages is one of the most frustrating experience we could give to our users.
I've confirmed that the following fixes the issue:
--- a/pkgs/tools/networking/network-manager-applet/default.nix
+++ b/pkgs/tools/networking/network-manager-applet/default.nix
@@ -32,7 +32,7 @@ in stdenv.mkDerivation rec {

   nativeBuildInputs = [ meson ninja intltool pkgconfig wrapGAppsHook gobjectIntrospection gtk-doc docbook_xsl libxml2 ];

-  propagatedUserEnvPkgs = [ hicolor-icon-theme ];
+  propagatedUserEnvPkgs = [ hicolor-icon-theme gnome3.gnome-keyring ];

   NIX_CFLAGS = [
     ''-DMOBILE_BROADBAND_PROVIDER_INFO=\"${mobile-broadband-provider-info}/share/mobile-broadband-provider-info/serviceproviders.xml\"''

Also, the additional closure is quite small:
$ nix-store -qR $(nix-build --no-out-link -E '(with import <nixpkgs> {}; gnome3.gnome-keyring)') | sort -u > keyring
$ nix-store -qR $(nix-build --no-out-link -E '(with import <nixpkgs> {}; networkmanagerapplet)') | sort -u > nm-applet
$ diff keyring nm-applet | grep ^\< | cut -f 2 -d \  | xargs du -csm | sort -rn
28	total
11	/nix/store/hk521cvcfcr4h86294xpsrq417141rkz-gnupg-2.2.5
6	/nix/store/yjad1cam4bxfncdp0sb4192flyaaalrz-openssh-7.6p1
6	/nix/store/qn7mp31l6c4dx69k5296lsf2gixg5i9n-gnome-keyring-<IP_ADDRESS>
4	/nix/store/bfl18g64b6pgyjr9l2nkskkfkg9g2hgd-gcr-3.28.0
2	/nix/store/p4kn6rx7akmnh5vps2pg9ag1i8419cgb-libgnome-keyring-3.12.0
1	/nix/store/xhx7fr3x4jzkv8s726ddncvfdrd93j40-pcsclite-1.8.23
1	/nix/store/rl35hp1q42ngxgdhv8awd681z6x7j7wk-libedit-20160903-3.1
1	/nix/store/pjw5r8xfxsf90qa6jl8zxcm837hvif7r-npth-1.5
1	/nix/store/f2l76817cjfm20894h4wzipbkaq4kqvb-libassuan-2.5.1
1	/nix/store/9b8aqmbivy7i0b5mzsf08wd2rws2p59i-libksba-1.3.5

I'd argue that unless we can find a better solution, adding this dependency is better than keeping the silent failure. Upstream has been unresponsive for years but if they ever wake up it's easy enough for us to revert the workaround.
Other than Gnome Keyring, what other backends to libsecrets are there? I could only find KWallet and greping into nixpkgs suggests that KDE doesn't even use networkmanagerapplet, at least unless a user explicitly installs it.

Other threads are completely useless:

GDB session
(gdb) c
Continuing.
[Thread 0x7f0b6eb43700 (LWP 1023) exited]
[New Thread 0x7f0b6eb43700 (LWP 1128)]

Thread 1 ".nm-applet-wrap" received signal SIGTRAP, Trace/breakpoint trap.
0x00007f0b88662321 in _g_log_abort () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
(gdb) info threads
  Id   Target Id         Frame
* 1    Thread 0x7f0b8ab0b9c0 (LWP 962) ".nm-applet-wrap" 0x00007f0b88662321 in _g_log_abort () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
  2    Thread 0x7f0b75887700 (LWP 981) "gmain" 0x00007f0b874f0a91 in __GI___poll (fds=0x26f7560, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  3    Thread 0x7f0b75086700 (LWP 982) "gdbus" 0x00007f0b874f0a91 in __GI___poll (fds=0x2708a20, nfds=3, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  4    Thread 0x7f0b6f54b700 (LWP 992) "dconf worker" 0x00007f0b874f0a91 in __GI___poll (fds=0x7f0b64001320, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  6    Thread 0x7f0b6eb43700 (LWP 1128) "pool" syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
(gdb) thread
apply  find   name
(gdb) bt
#0  0x00007f0b88662321 in _g_log_abort () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#1  0x00007f0b8866334c in g_log_default_handler () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007f0b886635dd in g_logv () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007f0b8866374f in g_log () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#4  0x00007f0b87ed9f5e in _secret_util_strip_remote_error (error=0x7ffd34b7acc8) at libsecret/secret-util.c:128
#5  0x00007f0b87ed9fa8 in _secret_util_propagate_error (async=async@entry=0x28a1f20, error=error@entry=0x7ffd34b7acc8) at libsecret/secret-util.c:113
#6  0x00007f0b87ed63f8 in secret_service_search_for_dbus_paths_finish (self=<optimized out>, result=result@entry=0x28a1f20, unlocked=unlocked@entry=0x7ffd34b7acd0, locked=locked@entry=0x0,
    error=error@entry=0x7ffd34b7acc8) at libsecret/secret-paths.c:583
#7  0x00007f0b87ecb8ac in on_delete_searched (source=0x270a2a0, result=0x28a1f20, user_data=<optimized out>) at libsecret/secret-methods.c:1627
#8  0x00007f0b88bf5b76 in g_simple_async_result_complete () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#9  0x00007f0b87ed3d33 in on_search_items_complete (source=0x270a2a0, result=0x7f0b68004440, user_data=<optimized out>) at libsecret/secret-paths.c:316
#10 0x00007f0b88c07c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#11 0x00007f0b88c08636 in g_task_return () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#12 0x00007f0b88c46fc9 in reply_cb () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#13 0x00007f0b88c07c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#14 0x00007f0b88c08636 in g_task_return () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#15 0x00007f0b88c3bae9 in g_dbus_connection_call_done () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#16 0x00007f0b88c07c13 in g_task_return_now () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#17 0x00007f0b88c07c49 in complete_in_idle_cb () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#18 0x00007f0b8865c7e5 in g_main_context_dispatch () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#19 0x00007f0b8865cbb0 in g_main_context_iterate.isra () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#20 0x00007f0b8865cc3c in g_main_context_iteration () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#21 0x00007f0b88c1d95d in g_application_run () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#22 0x00000000004108c7 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:81
(gdb) thread 2
[Switching to thread 2 (Thread 0x7f0b75887700 (LWP 981))]
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x26f7560, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
29	in ../sysdeps/unix/sysv/linux/poll.c
(gdb) bt
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x26f7560, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007f0b8865cb29 in g_main_context_iterate.isra () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007f0b8865cc3c in g_main_context_iteration () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007f0b8865cc81 in glib_worker_main () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#4  0x00007f0b886844f5 in g_thread_proxy () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#5  0x00007f0b877c32a7 in start_thread (arg=0x7f0b75887700) at pthread_create.c:465
#6  0x00007f0b874fa57f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 3
[Switching to thread 3 (Thread 0x7f0b75086700 (LWP 982))]
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x2708a20, nfds=3, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
29	in ../sysdeps/unix/sysv/linux/poll.c
(gdb) bt
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x2708a20, nfds=3, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007f0b8865cb29 in g_main_context_iterate.isra () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007f0b8865cec2 in g_main_loop_run () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007f0b88c49a96 in gdbus_shared_thread_func () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libgio-2.0.so.0
#4  0x00007f0b886844f5 in g_thread_proxy () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#5  0x00007f0b877c32a7 in start_thread (arg=0x7f0b75086700) at pthread_create.c:465
#6  0x00007f0b874fa57f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 4
[Switching to thread 4 (Thread 0x7f0b6f54b700 (LWP 992))]
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x7f0b64001320, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
29	in ../sysdeps/unix/sysv/linux/poll.c
(gdb) bt
#0  0x00007f0b874f0a91 in __GI___poll (fds=0x7f0b64001320, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x00007f0b8865cb29 in g_main_context_iterate.isra () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007f0b8865cc3c in g_main_context_iteration () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007f0b6fbe50ed in dconf_gdbus_worker_thread () from /nix/store/rv9vbbp5dapas5i5991ifcvp63ap4l4s-dconf-0.28.0-lib/lib/gio/modules/libdconfsettings.so
#4  0x00007f0b886844f5 in g_thread_proxy () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#5  0x00007f0b877c32a7 in start_thread (arg=0x7f0b6f54b700) at pthread_create.c:465
#6  0x00007f0b874fa57f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 6
[Switching to thread 6 (Thread 0x7f0b6eb43700 (LWP 1128))]
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
38	../sysdeps/unix/sysv/linux/x86_64/syscall.S: No such file or directory.
(gdb) bt
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x00007f0b886a267a in g_cond_wait_until () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#2  0x00007f0b8862fb81 in g_async_queue_pop_intern_unlocked () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#3  0x00007f0b88684e94 in g_thread_pool_thread_proxy () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#4  0x00007f0b886844f5 in g_thread_proxy () from /nix/store/dqlc8y4phlg1hmdbwkhqfwhnxcac88d1-glib-2.56.0/lib/libglib-2.0.so.0
#5  0x00007f0b877c32a7 in start_thread (arg=0x7f0b6eb43700) at pthread_create.c:465
#6  0x00007f0b874fa57f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

It would be nice to be able to set break point to nma_wifi_dialog_new.

Apparently, you can just use break nma_wifi_dialog_new and it will find the correct function. After removing the libsecret patch, I verified that the function never gets called – at least the breakpoint does not seem to get triggered.


Hub create > Permission denied (publickey).

Command attempted:
sudo hub create
What happened:
I'm using thiss command in a bash script:
It creates the repo on my account, but doesn't ask me my username/password, and outut an error and i cant push. (Strangly, i dont get this error while using the regular way (create repo on github.com, sudo git remote add ... ,  sudo git push origin master), and when i use this command in the command line:
In french :  ` Existing repository detected
Mise à jour de origin
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Impossible de lire le dépôt distant.
Veuillez vérifier que vous avez les droits d'accès
et que le dépôt existe.
error: Impossible de récupérer origin`
In english : `Existing repository detected
origin update
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from the remote repository.
Please make sure you have the correct access rights
and the repository exists.
error: Could not get origin`  (aproximative translation sorry))
More info:
OS : Raspbian GNU/Linux 10 (buster)
git verssion : 2.20.1
hub version : 2.7.0

I have this problem because i use sudo, but i have to (im creating some directory in the same bash script) so there is 2 ways to solve this issue :
-using toutch and mkdir without sudo permission
-hub create with sudo

i made a nw direcctory under \Documents, with "mkdir ", and the used my bash script without "sudo".


fix typo/missing char

"Deployent" should be "Deployment"

@SitecoreDave : Thanks for your contribution! The author, @minewiskan, has been notified to review your proposed change.

#sign-off


Rails and Rake not found

Container throws the following error
Status: Downloaded newer image for jamesbrink/lobsters:latest
/usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
	from /usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:302:in `activate_bin_path'
	from /usr/local/bin/rake:23:in `<main>'
2019-07-04 05:53:06 - DB Version:
2019-07-04 05:53:06 - Creating database.
/usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
	from /usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:302:in `activate_bin_path'
	from /usr/local/bin/rake:23:in `<main>'
2019-07-04 05:53:06 - Loading schema.
/usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
	from /usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:302:in `activate_bin_path'
	from /usr/local/bin/rake:23:in `<main>'
2019-07-04 05:53:06 - Migrating database.
/usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
	from /usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:302:in `activate_bin_path'
	from /usr/local/bin/rake:23:in `<main>'
2019-07-04 05:53:06 - Seeding database.
/usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
	from /usr/local/lib/ruby/site_ruby/2.3.0/rubygems.rb:302:in `activate_bin_path'
	from /usr/local/bin/rake:23:in `<main>'
2019-07-04 05:53:06 - No SECRET_KEY provided, generating one now.
2019-07-04 05:53:06 - Your new secret key: 72fbdf64319c9aab16793aa3dfdf0432ac220bbf9c8ae9ecc83b9117658cefc0bb58bdba8babdb02cab21f45b798952b7c58c97c264b772a2e279608baa15c08
/usr/local/bin/docker-entrypoint.sh: line 55: rails: not found
2019-07-04 05:53:06 - Exiting

Thanks, I'll take a look at this

@Rayraegah, this should be resolved now if you pull the most recent changes and be sure to update the submodule as well

Thanks @jamesbrink local dev is now up and running.


When will the evaluation code be released?

Thank you for your works!

I would also be super interessted in that!

You can find the inference code here: https://github.com/opennerf/opennerf/blob/main/datasets/replica_semantics.py
It produces the semantics per point from a trained NeRF representations.
The actual evaluation code for 3D semantic segmentation is the same as here:
https://github.com/ScanNet/ScanNet/blob/master/BenchmarkScripts/3d_evaluation/evaluate_semantic_label.py

Closing for now, let me know if this helps

Closing for now, let me know if this helps

@francisengelmann thank you!


Download Media

An option to download media will be great!

This would be nice, but my only concern would be that the app would need to ask for another (potentially broad) permission. I think it can be done without needing the "access all storage" permission, but then downloads wouldn't be accessible from outside Fritter.
I'll do some investigation 🙂

I was going to request a similar feature: The ability to "share" media to other apps.
E.g. You see a funny meme posted as an image inside a tweet - and you want to share the image on WhatsApp etc.


[ ] Does it proc from a buff? No, it procs after the hunter dodges
[x] Is it baseline or related to a talent? Baseline
[ ] Should it display a Spell Alert? No

[ ] Where? N/A
[ ] Which texture? N/A
[ ] Which size? N/A
[ ] Change color? N/A
[ ] Spell Alert enabled by default for all hunters? N/A

[x] Should it glow buttons? Yes, Classic Era only

[x] Which buttons should it glow? Mongoose Bite
[x] Which glowing buttons should glow by default? Mongoose Bite

Implemented in #148.


(refactor) Updated to Swift 5.0 and iOS 10.0

I refactored this to Swift 5 & iOS 10 for someone, and thought I could save you the work of updating it yourself with this handy-dandy PR.

Nice work. I will check the PR and merge it in a few days.


Browserless Chrome: Add on Does not start since 2.1.0 upgrade

Description
Since the 2.1.0 upgrade the add-on does not start. I have tried uninstalling and installing again.
Reproduction steps
1. Install v 2.1.0 of browserless chrome
2. Start

Addon Logs
exec ./start.sh: exec format error

Architecture
aarch64 -- corrected
OS
HAos

Thanks that's a wrong architecture in the upstream image my addon is based on. I've launched a rebuild if they corrected the issue

Hi
Not sure if 2.1.0-2 was supposed to resolve this, but it didn't. I did want to also add that I picked the wrong architecture in the option. It's aarch64 in fact.

Hi, probably the upstream maintainer has uploaded a wrong architecture, like amd64 under a aarch64 tag which would create this error... Now we need to wait for him to update his image and I can update my container. Here is the confirmation : https://github.com/browserless/browserless/issues/3803

Thanks! I've reverted to 2.0 and will wait. Thanks a lot for maintaining this.

Thanks! And you're actually right i'll revert the whole addon as anyway the next upstream update will trigger also an addon update

Hi,
2.1.0-2 have errors:
browserless.io:index Starting metrics collection. +5ms
browserless.io:error No handler or file found for resource / +0ms
browserless.io:error No handler or file found for resource / +5s

@alexbelgium can you make a new build? 🙏😊

Hi,
2.1.0-3 build still not working.

Thank you @alexbelgium
However the problem still exist. Is it possible to use the old docker image?

Hi, I've changed the endpoint to check

Unfortunately errors still occurs.

Which error exactly? If No handler or file found for resource /  then it is not an error : the url should end with /docs (corrected in webui) and not /.
If the functions of browserless itself you should probably check if it is not due the apps change when going from version 1 to 2

Which error exactly? If No handler or file found for resource /  then it is not an error : the url should end with /docs (corrected in webui) and not /.
If the functions of browserless itself you should probably check if it is not due the apps change when going from version 1 to 2

Yes. Sorry my mistake V2 was droped selenium support.

If everyone prefers i can revert to v1 then just let me all know

If everyone prefers i can revert to v1 then just let me all know
Thank you but i prefer rewrite my script for V2 :)

Perfect! And indeed more sustainable as v1 won't be developed anymore. Thanks!

V2 has a bug that makes it impossible to work in my case. I dont find it stable yet. Will it be possible to create another repository for v1? 😁


Application UX/UI breaks when close tab button is pressed with only 1 tab open.

Solution, have function cancel out if only one tab is open.

Fixed with #17


Where can I get the data of this project?

Hi
I'm currently learning the brain MRI image processing, which based on the neural network. And I'm interested in bnets. I wonder where can I get the data of this project. Please help if possible.(I'm a rookie. )
LS

Hi LS there is no data for this project. This is software for processing your own data.


fix: More durable parsing of semver from db

Testing for LogicalReplication listener mode revealed that newer PSQL
images include additional build information in the 'SHOW server_version'
call. This is a slightly more robust version of the initial
implementation (with added tests).
This is a subset of the changes contained in #37 and is intended to be a more focused/digestible/reviewable change.
Unit test output:
$ make test
go test -v ./...
=== RUN   TestParseSemver
=== RUN   TestParseSemver/9.5
=== RUN   TestParseSemver/9.5___(And_some_other_stuff...
=== RUN   TestParseSemver/9.5.1__(patch_version_ignored)
--- PASS: TestParseSemver (0.00s)
    --- PASS: TestParseSemver/9.5 (0.00s)
    --- PASS: TestParseSemver/9.5___(And_some_other_stuff... (0.00s)
    --- PASS: TestParseSemver/9.5.1__(patch_version_ignored) (0.00s)
=== RUN   TestPipeline
--- PASS: TestPipeline (0.30s)
=== RUN   TestNewConfigFromEnv
=== RUN   TestNewConfigFromEnv/test_with_namespace
=== RUN   TestNewConfigFromEnv/test_with_no_namespace
=== RUN   TestNewConfigFromEnv/test_parse_database_config
--- PASS: TestNewConfigFromEnv (0.00s)
    --- PASS: TestNewConfigFromEnv/test_with_namespace (0.00s)
    --- PASS: TestNewConfigFromEnv/test_with_no_namespace (0.00s)
    --- PASS: TestNewConfigFromEnv/test_parse_database_config (0.00s)
=== RUN   TestParseLogLevel
--- PASS: TestParseLogLevel (0.00s)
PASS
ok      github.com/perangel/warp-pipe   (cached)
?       github.com/perangel/warp-pipe/cmd/axon  [no test files]
?       github.com/perangel/warp-pipe/cmd/warp-pipe     [no test files]
?       github.com/perangel/warp-pipe/db        [no test files]
?       github.com/perangel/warp-pipe/internal/cli      [no test files]
?       github.com/perangel/warp-pipe/internal/store    [no test files]
Integration tests disabled. Use -integration flag to enable.
ok      github.com/perangel/warp-pipe/tests/integration 0.004s

Integration test output:
--- PASS: TestVersionMigration (26.37s)
    --- PASS: TestVersionMigration/9.5To9.6 (14.63s)
    --- PASS: TestVersionMigration/custom11To11 (11.74s)
PASS
ok      github.com/perangel/warp-pipe/tests/integration 26.373s

rebasing

test pass post-rebase, merging


[bug]: Cannot curl my Embassy A from the SSH of my Embassy B

Prerequisites

[X] I have searched for existing issues that already report this problem.

embassyOS Version
<IP_ADDRESS>
Device
Laptop/Desktop
Device OS
MacOS
Device OS Version
Monterey
Browser
Other
Browser Version
tmux
Current Behavior

MacMax:Repos dread$ ssh<EMAIL_ADDRESS>
Welcome to
          |                        ,---.,---.
,---.,-.-.|---.,---.,---.,---.,   .|   |`---.
|---'| | ||   |,---|`---.`---.|   ||   |    |
`---'` ' '`---'`---^`---'`---'`---|`---'`---'
                              `---'
   GNU/Linux (5.10.92-v8+ aarch64)
   embassyOS v<IP_ADDRESS> - 2f8a25ae2679a11161c7f3cc70be04ecedfbea1b

 * Documentation:  https://start9.com
 * Management:     https://embassy-scarce-yawns.local
 * Support:        https://t.me/start9_labs

start9@embassy-scarce-yawns:~ $ curl faded-soaps.local
curl: (6) Could not resolve host: faded-soaps.local

Expected Behavior
curl faded-soaps.local

<title>301 Moved Permanently</title>

301 Moved Permanently

nginx/1.18.0

Steps to Reproduce

Start Embassy A
SSH into Embassy A
curl embassy-b.local

Anything else?
No response

Additional information: the curl was working before I started the migration process. tried a system rebuild, no luck.
start9@embassy-f5fb24ed:~ $ curl faded-soaps.local

<title>301 Moved Permanently</title>

301 Moved Permanently

nginx/1.18.0

start9@embassy-f5fb24ed:~ $ sudo -i
root@embassy-f5fb24ed:~# mkdir -p .ssh
root@embassy-f5fb24ed:~# ssh-keygen -t ed25519 -N '' -f .ssh/embassy2.key
Generating public/private ed25519 key pair.
Your identification has been saved in .ssh/embassy2.key
Your public key has been saved in .ssh/embassy2.key.pub
The key fingerprint is:
[REDACTED] root@embassy-f5fb24ed
The key's randomart image is:
+--[ED25519 256]--+
|.E==o.           |
| *+oo            |
|..oo             |
|  o      o o     |
| . .  . S = .    |
| ....+ . . =     |
|. ==+.o o * o    |
|.+oO=  . * +     |
|..=oo. o= .      |
+----[SHA256]-----+
root@embassy-f5fb24ed:~# chmod 600 .ssh/embassy2.key*
root@embassy-f5fb24ed:~# cat .ssh/embassy2.key.pub
ssh-ed25519 [REDACTED] root@embassy-f5fb24ed
root@embassy-f5fb24ed:~# cd /embassy-data/package-data/volumes/bitcoind/data/main/
root@embassy-f5fb24ed:/embassy-data/package-data/volumes/bitcoind/data/main# rsync -e "ssh -i ~/.ssh/embassy2.key" -povgr --append-verify --rsync-path="sudo mkdir -p /embassy-data/package-data/volumes/bitcoind/data/main ; sudo rsync" ./{blocks,chainstate} start9@faded-soaps.local:/embassy-data/package-data/volumes/bitcoind/data/main/
ssh: Could not resolve hostname faded-soaps.local: Temporary failure in name resolution
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(228) [sender=3.2.3]
root@embassy-f5fb24ed:/embassy-data/package-data/volumes/bitcoind/data/main# curl faded-soaps.local
curl: (6) Could not resolve host: faded-soaps.local
root@embassy-f5fb24ed:/embassy-data/package-data/volumes/bitcoind/data/main#

unable to reproduce

I just recreated it again on my 0.3.3

I just recreated it again on my 0.3.3

What did you do to repro?

nothing more than what's in the screenshot.
I have the crime scene if you want to dig in

I was hoping you had reproduced since this is the only instance we have - have you gone through avahi to make sure it's healthy?  Can you curl by IP?

Please reopen if you can reproduce and demo

I can reproduce and demo, and have many times, which is what the screenshot is above.
Let me know what other steps are needed.

@islandbitcoin it is not working because you are missing embassy- the proper command is:
curl embassy-faded-soaps.local

no, my box was made when we didn't have embassy as the prefix, so the name is correct.

I've also tried this between two boxes that have the name embassy-xxxx-xxxx and embassy-xxxx-xxxx

understood. I'll leave this alone, it looks like it's specific to my network.


Fix broken tabs

Fix a issue with tabs since last update. (Wrong operator on for loop)
U can find the issue here: #53915
U can find the broken pr here: https://github.com/godotengine/godot/commit/3c5103ac1d9a97cfe94978896b50572c2138138f

This PR creates buggy behavior, now the last tab is never able to be selected.

This PR creates buggy behavior, now the last tab is never able to be selected.

Cant confirm. Working well.

Unless me eyes deceive me, that looks like a TabContainer, not Tabs.

Its seems like that _get_tabs cant find childrens..

If you update your issue report with an example project, I could help debugging it.

If you want a node that adds tabs automatically when children are added, use TabContainer. Tabs is a more fine grained node that gives you a lot of options, but you have to do stuff yourself.

If you want a node that adds tabs automatically when children are added, use TabContainer. Tabs is a more fine grained node that gives you a lot of options, but you have to do stuff yourself.

Then its a design / concept issue for the Tab Container. Lets talk about in the Issue Ticket.

Tabs is just a tab bar. It's all that is. There is no concept issue. It's just poorly named.


All archetype field converters should do validation

This is a much better place to catch / raise errors since we can attribute it directly to the field being converted and even warn about multiple bad fields.

Related:

https://github.com/rerun-io/rerun/issues/3849


Support powerpc64

The test_ioctl values are computed using ioctl-test.c

This is blocking on #590. Once we're using cross/trust to do cross-platform testing, we can enable powerpc64. That should be part of this PR once we merge #590.

Now that #590 is merged and we're using cross, let's go ahead and add PowerPC64 to the test framework as well. Please rebase these commits on top of the latest HEAD on top of adding powerpc64 to the Travis CI tests.

@lu-zero Are you still interested in getting this merged? Just wanted to check in since it's been a while on this.

I had been busy, if you can point me to the test harness I can have a look.

@lu-zero Was gonna point you to the right spot, but it looks like you found it! This is close to ready, but could you update the README adding powerpc64/64le to the Tier1 list? And also squash this into one commit?
Once that's done, this is RTM.

great :) I was afraid I was missing something, let me know if the update is fine. (changed to keep the lines grouped)

bors r+


feat(artifacts): Add SDK support for artifact tags

EDIT: Frontend PR merged: can merge this PR when ready.
Description

Fixes WB-19611

Adds SDK support for exposing and managing tags on individual Artifacts, via:

A new (mutable) property on Artifact instances: Artifact.tags
Allowing a new arg tags in the signature of Run.log_artifact()

i.e. run.log_artifact(...) -> run.log_artifact(..., tags=[...])

This deliberately attempts to ensure consistency -- wherever appropriate -- with the existing functionality/API that's already exposed for:

ArtifactCollection.tags
Artifact.aliases

[x] I updated CHANGELOG.md, or it's not applicable

Testing
Tested via system test(s)

@tonyyli-wandb note that your change won't work with older version of server since you modified the schema


[search] Add batch helper object

Implement a class to aid in composing index actions inside a batch.
Closes #7841

@heaths finally got around to addressing your feedback. Let me know if there's anything else you think needs to be tweaked!


Add mechanism to install plugins

Currently, in order to install plugins, users would have to build an image with the required plugins installed and use that image instead of the default image.
Plugins are needed for snapshots repo and other cases, therefore it is very important that installing plugins would be supported natively in the operator.
The idea is that the user could define the plugins he wishes to install in a new and separate CRD and that the operator would pick up the missing plugins, install them, and perform a rolling restart for that to take effect.

Already started to work about it, hope to create first PR tomorrow

https://github.com/Opster/opensearch-k8s-operator/pull/201

Added on latest release


remove underscore in require

right now when you require the GoogleMap you get this error
Uncaught Error: Cannot find module "./creators/_RectangleCreator"
removing the underscore removes the issue.

Released v2.0.0 and v2.0.1.

Thanks for pushing this out so fast!! :+1:

Thanks for @theverything 's contribution!


Sync does not recover on "connection reset by peer"

Hi there,
first of all: Thanks a lot for that great piece of software you've created!
Problem description and steps to reproduce:

sync upload a lot of data (for several hours or days)
wait for a "connection reset by peer" error. This will happen reliably after a while.

Expected behaviour:
auto-recover connection
Real behaviour:
The sync crashes fatal with a message like this:
16.8 MB/23.9 MB, Rate: 1.2 MB/sFailed to upload file: Post https://www.googleapis.com/upload/drive/v3/files?alt=json&fields=id%2Cname%2Csize%2Cmd5Checksum&uploadType=resumable&upload_id=AEnB2UrtlbEL7DYLL_XaCGpQyjwpQH7JuFqp1uaBPqkYRN0STxw8kPgkXfkALUmzgEDLARCClptAO9Q1GGJgKSwal73Qmj0NWNF-3K6XqtlIUKbUdYD0FGI: read tcp <IP_ADDRESS>:44387-><IP_ADDRESS>:443: read: connection reset by peer

+1 I have same issue

I can use --no-progress --skip --timeout 0 --path download > log/folder.log
and then monitor log file to restart same command once it stalls, but this is tedious and not reliable for really massive folders because this command actually reiterates all files and checks if the file is any different. Which means if above a certain size (for me about 20GB) it resets while just checking files it already managed to download.

SAME!! THIS IS FATAL! PLEASE FIX!!!!


Web site Theme Error On Arc

Current Behavior
Bug
On the page
https://www.skeleton.dev/docs/generator
I got an error console Invalid RGB value when using Arc. But not with Firefox or Safari.
This error stops the Js from working.
Expected Behavior
Working as expected.
Steps To Reproduce

Open Arc.
Go to the home page of skeleton. https://www.skeleton.dev/
Then navigate to the theme generator. https://www.skeleton.dev/docs/generator
You will get the error message of Invalid RGB value in the console.

Link to Reproduction / Stackblitz
No response
More Information
No response

Try it in Incognito Mode & with another chromium based browser please. Not sure if this is a browser specific problem, I tend to guess that it's a machine-specific problem and you might need to clear your local state for the site.
Definitely doesn't break in Vivaldi, Chrome and Edge for me, which are all also chromium based.

Hi,
I try with other chromium (Chrome) and Incognito mode. And It's working.
I cleared all the cache and now it's working.
Actually, I haven't played with the Theme generator since the V1. So it might explain this bug.
But now compare to before I clear the cache I got this new warning.

I don't know if this can help.

@Johjoh-6 we use localstorage for some of the data persistence, my assumption is you had some old values set that were interfering with the generator. Clearing your cache would resolve this, producing the results you're seeing. So we'll call this resolved. But let us know if you run into any other issues! Thanks


Work on cli release notes printed by the cli for the 3.x upgrade

Investigate how to display a different upgrade messages for the same target cli version based on the current cli version.
E.g. The newest 2.x cli version will handle the 3.0 upgrade gracefully and will work by "ignoring" the latest 3.x versions.
I.e it's going to work as-is 3.0.0 was never released.
However the older 2.x cli versions will resolve latest as 3.x and will break.
Users will be either forced to supply a 2.x version explicitly or forced to upgrade because of the inability to work with "latest" versions.
We can use the exiting cli release notes as a fallback for older cli versions, and introduce a new set of properties that can be handled by newer cli versions.
Doing this will introduce additional complexity in our cli metadata data model, we may decide to handle upgrade messages for "broken cli versions" with the existing mechanism. The trade-off will be that newer 2.x cli versions that aren't broken will display a 3.x upgrade message that won't apply entirely. The message would be like "if you are on version xxx then yyy".

See https://github.com/oracle/helidon-build-tools/issues/631
The fix that was implemented is graceful and none of the 2.x cli will break.
We still need to investigate if we can customize the message to inform users that they need a 3.x cli to use Helidon 3.x


ItemList truncation does not show ellipsis (...) with new script editor list minimum width

Tested versions
Appears in editor in 4.4 since https://github.com/godotengine/godot/pull/96909
Not visible in editor in 4.3, but the underlying behavior in ItemList is observable in 4.3
System information
Windows 10
Issue description
In an ItemList, names are truncated if they are too wide for the list. Usually this is done with an ellipsis ..., but when the width is small enough, no ellipsis is used. I think this is good intended behavior, otherwise only an ellipsis would be shown at very low widths.
Since https://github.com/godotengine/godot/pull/96909 set the minimum width of the script list to 100, the width is small enough that many script names are now truncated with no ellipsis. This happens right around a script list width of 100. For new_script.gd, the threshold for the behavior happens at 101px wide, so it was easily noticeable when testing.
I believe this is existing behavior of the ItemList truncation, but since the preview editor script list minimum was above the threshold, it was not visible to godot editor users. The MRP is created and tested in 4.3, and replicates the same behavior if the width is low enough.
Observed behavior in the https://github.com/godotengine/godot/pull/96909 artifact:
https://github.com/user-attachments/assets/17179298-3a6d-4d83-b0af-7be34a7d144e
Observed behavior in the MRP (created and tested in 4.3).
https://github.com/user-attachments/assets/bd7a7570-f944-4e00-a27c-fe37b4597373
Possible resolutions:

Tweak the truncation limits so that an ellipsis is still used at the minimum script width of 100.
Tweak the minimum script width to 105 or 110, to barely avoid this behavior.
Do nothing, as this is intended behavior, just an edge case that usually doesn't come up in the editor. In this case the user is knowingly making their editor UI crowded in exchange for extra script editor space, and minor "problems" like this may be expected. (It's me. I'm user. 😃)

CC @aXu-AP
Steps to reproduce
Open the MRP.
Adjust the HSplitContainer left and right. You can test with and without 16x16 icons.
Minimal reproduction project (MRP)
mrp-truncation.zip

4.3 (for MRP)

Don't list versions that aren't affected, unless you point out that they aren't affected, unless this isn't a regression from #96909 this isn't in 4.3

So to clarify, this is a pre-existing issue in ItemList that affects them already? But this report is specifically about how it affects the editor?
I think this should be solved in ItemList and a report should focus on the behaviour there and deeper details to test it, rather than trying to fix one symptom of it

Yes, this is a pre-existing behavior of ItemList (and maybe deeper code that actually does the truncation). It is good that at some point, item list labels are truncated without ellipses. As an example, new_script.gd truncated to 5 characters is new_s rather than ne....
There is some threshold for when this happens, set somewhere. Before https://github.com/godotengine/godot/pull/96909, the script editor list only showed truncations with ellipses, because it was sufficiently wide. So this behavior was not exposed to the editor, at least at that location.
I don't know how much thought went into the current truncation threshold is for ItemList text. I also don't know all the places where it could be used.
I opened this issue specifically focusing on the script editor list because it came out of a comment  from https://github.com/godotengine/godot/pull/96909. It's possible that either a local fix to the script editor or a deeper change to ItemList or truncation behavior is the right solution.

I think fixing this in ItemList is far more critical, I don't think it's very critical that it now doesn't work in the default state in the script editor, compared to that, so I'd say to open a dedicated issue report for the ItemList behavior and we'll see if we close this one or keep both open

I think that issue would look very close to this issue, just with a different title and slightly different emphasis? The MRP I posted for this one will work for testing the underlying issue.

It wouldn't, this issue is about the script editor, not ItemList, so either this should be changed to focus on ItemList or a different issue should be opened, we can't track two very different scopes of issue in the same issue report, that is a recipe for making bad errors
This issue would be solved by either changing the default size in the editor, or fixing the issue in ItemList, but the ItemList issue can't be solved by changing the editor code
It's really important to focus on the right place

Done in https://github.com/godotengine/godot/issues/97125.

It's related to TextServer, this issue exists with all the nodes that can change text_overrun_behavior.
The ellipsis only appears if there's enough space for it's text after at least 5 characters, it's very old issue, and maybe can be reproduced on 4.0 or 4.1 too.


4D53885C - Halo: Reach Beta

Marketplace (Delisted)

Tested on https://github.com/xenia-project/xenia/commit/f2c0ae46c11db7b0bfd4b4d638aaa3ff282d6ba0
Issues:
When attempting to run the Halo: Reach Beta, either from the stock or the unlocked executable, the game will play both the "intro_esrb_60.bik" and the "story_60.bik" intro videos in that order upon starting up the game, as normal. However, once you are meant to load into the menu, the fade-in to the game's main menu either does not work, or it does work but there's nothing to see. In either case, you are left with a black screen when you are usually meant to either see the beta welcome message upon first launch, or the main menu.
All menu audio seemingly works as normal, however, and controller input functions as based on the audio cues from navigating the menu.
Log:
xenia.zip
Screenshot(s):

Labels:
tech-engine-blam | marketplace-delisted | state-intro

how did nobody notice this is a master report in the canary repository


entql: add support for uuid fields

See #1002

Hey @BrentChesny, please see https://github.com/facebook/ent/issues/1002#issuecomment-736616095

Closing in favor of #1004


403

Hello! I started getting 403 error code on my project.
I found out that some characters cause that (https://api.jikan.moe/v3/character/74621, this one gives 403) and some work just fine (https://api.jikan.moe/v3/character/1, works properly).

Hi, this is the same issue as https://github.com/jikan-me/jikan-rest/issues/123

Closing due to duplication.


Bumped dependencies, added workflow_dispatch event for running action

Bumped dependencies to use node v20
Added workflow_dispatch event to run the update-readme action manually

Obselete, some changes required.


Node bot.js

I find the same problem

so do i

Check to ensure your JSON is properly formatted. The fact you are getting a syntax error means that it is not properly formatted. A good resource for verifying your JSON is http://json.parser.online.fr/
From the looks of the error from the OP si would say the token is not in quotes. Here is an example of a working auth.json file (the token has been redacted, of course):
{
"token:": "NSSSSDHDS&DSDFFFHFHFHFHHDHDH8787827627ASHD858686QZC"
}


Fix/air: Deprecated $GOPATH reliability

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
Closes #74;
Closes #111;
Description of Changes:

Changed make watch to rely on command null command respons instead to check if air is installed of checking for GOPATH.

Checklist

[X] I have self-reviewed the changes being requested

@Melkeydev Can you review this one? I think it is good to go.


Empty result on file access/download

I'm using the tus-js-client to upload some files on the server and everything works fine, the file get uploaded.
However, when I'm trying to access/download a file that was just uploaded on the server (i've checked and the file is there), however an empty page shows up in browser. I'm using the url returned by .url property in the response: https:///server.php/files/1e02ef98-09fc-4c5f-94f4-700652a8f87d. Note that the GET returns a Status Code: 200.
I'm running Apache 2.4 with HTTP2, PHP 7.3, redis cache
Here is the apache log:
 - - [06/Dec/2019:04:33:12 -0500] "GET /server.php/files/1e02ef98-09fc-4c5f-94f4-700652a8f87d HTTP/2.0" 200 - "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:71.0) Gecko/20100101 Firefox/71.0"
And the redis-cli monitor entry:
1575624884.590250 [0 <IP_ADDRESS>:37336] "SELECT" "0"
1575624884.590704 [0 <IP_ADDRESS>:37336] "GET" "tus:server:1e02ef98-09fc-4c5f-94f4-700652a8f87d"
My .htaccess file:
RewriteEngine on
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^files/?(.*)?$ /server.php?$1 [QSA,L]

  AddHandler application/x-httpd-ea-php73 .php .php7 .phtml

@myscienceisbetter you need to use GET /files/<key>/get to download the file. This was done since we need to treat HEAD and GET as an identical request as per RFC7231. File download in GET /files/<key> request is not a part of the tus specification.

Thanks, this seems to be doing the trick!


removing retroactive registration

Removing retroactive registration from the spec along with wording on smart contract factories.

Curious to know the reasoning behind removing retroactive registration -- is there an implementational constraint or just marginal demand?
Also, if I understand correctly, it'll still be possibly to "retroactively" register smart contracts any time after they are deployed, so long as they were deployed after the CIP is implemented?


[Question] Speaking at Reactive2017?

Hello folks!
You are doing amazing job with ChakraCore. Particularly time traveling debugger really got me.
I read this piece:
https://github.com/nodejs/node-chakracore/blob/xplat/TTD-README.md
I would love to invite somebody from your team to speak at ReactiveConf 2017, on 26–27 of October in Bratislava.
What do you think?

Here is time travel debugging with React Native - http://blog.nparashuram.com/2016/08/time-travel-debugging-with-reactnative.html

@liminzhu @bterlson @aruneshchandra @sethgaurav

@mrkmarron

@panarasi would be a good candidate for this.

I spoke to @ryanjsalva and either him or me could do the talk. I think @mrkmarron should also be at the conference, since he is the one who did all the hard work.

Sounds great! Of course, we will provide VIP tickets for all folks from the team who wants to come.

@panarasi let me know if you do end up speaking and have a recording available for sharing publicly. Could be something fun for https://github.com/Microsoft/ChakraCore/wiki/Resources.

@liminzhu I did cover this at ReactConf 2017 link at around 19 minutes

Closing this as we'll have Ryan speaking at ReactiveConf.


adding get_installed_version_office with installed software module

Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
the reason for this pull request is to add a better way to get the office version using the installed software package
what usually needed when developing application with this library is to get the possible office version installed I know my code can be fixed and updated more but something like this is a better solution .
example output

what is simply happening is that we use the installed software module to get list off software then we filter on any software with the string 'office' and 'Microsoft' combined in it.
Any other comments?
it's a great project hope to see it grow more.

Do you have a case where current functions did not return the office version even when installed ?

No but I work as an IT technician and I have seen when office is installed but not showing in software list wish happened to me a couple of times it means the office version is a hacked development version or a corrupted version and then MS office must be reinstalled, I think a simple solution can help at least in my situation also adding condition for office 365 can be checked like this.

sorry I miss understood your question if you are talking about the current function then I'm using office 2021 Pro Plus and it's not showing I understand the code has to be updated but something that auto update and always work is better.

Since your patch adresses corner cases where Office was installed in a "hackish" or "dev" way, I prefer to not merge.
Your case is well resolved by your actual code, but most people would want only "original" install detection.


Ledger trades stuck at signing when app not opened prior

Overview
If the user does not have the relevant ledger app open on the device at the time of tx signing, the app spins infinitely until the user goes back.
The app should disable the "sign transaction" button until the ledger app is open. Additionally there should be some sort of prompt to let the user know to open the relevant app on the device, like account management does.
References and additional details
Infinite spinner when opening bitcoin app after clicking "sign transaction"

Acceptance Criteria
Should be impossible to get into a state where a transaction is stuck due to ledger app not being open at the time of signing.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

@shapeshift/product tagged at needs product for UX details on flow

Acknowledgement trigger probably is best here.

@woodenfurniture what do you think about this:
If we detect the ledger app is not open, we should disable the sign transaction button. And pop open the ACK for connecting to the app on ledger.
Here is an example of this would look, very similar to the account management flow.

related to #7374

@shapeshift/product talked it over with @woodenfurniture and we decided the easiest way to get this done was to pop this open in a modal instead of the ack. Which I think totally works in the case.


chore: minimization of timeout in Mathlib.Algebra.Module.Submodule.Localization

This is a minimization of an isDefEq timeout from Mathlib.Algebra.Module.Submodule.Localization,
where it is reasonably fast with set_option backward.isDefEq.lazyWhnfCore false,
but very slow with the default isDefEq algorithm.

We found the performance issue and fixed at #4085


[Task]: Refactor OAuth2 code to ensure that expiresAt value in correct formats

SubTasks
The logic for handling the token expiration time in the getAccessTokenForGenericOAuth2 method has been updated to consider both the expires_in and expires_at fields from the OAuth2 token response. This is a positive change as it adds flexibility and robustness to the token expiration handling mechanism. However, ensure that the expires_at field, if present in the response, is in the correct time unit (seconds since epoch) as expected by Instant.ofEpochSecond. This is crucial because different OAuth2 providers might use different time units (e.g., milliseconds vs. seconds).
https://github.com/appsmithorg/appsmith/pull/30866#discussion_r1476175446

can I take this?


[5.8] Update option directive naming

Squash of https://github.com/apple/swift-docc/pull/448

Explanation: This updates the naming convention of "option directives" to match the Forum discussions.
Scope: Documentation using @Option directives to disabled various default behaviors.
Radar: rdar://104437275
Risk: Low. The syntax to disable default behaviors remain the same. Only redundantly writing out the directives to enable the behavior that's already on by default changed.
Testing: Updated tests to use new directive argument names. Existing automated tests pass.
Reviewer: @ethan-kusters

@swift-ci please test


Getting all users data?

I'm trying to implement a 'page review', so I've added a 'review' sidebar part on the page. My idea is to have a list of users that are in the 'Reviewer' group I've created so that I can add them to review the content on page save.
I've never worked with BookStack app before, and I'm searching for some method that will allow me to list all the users and then filter them, but no luck so far.
I've found getAllUsers() method in the UserRepo class, but I'm not sure how to use it inside my views.
I can access user() method, but this will only provide me with the currently logged in user.
Any help is appreciated.

Hi @dingo-d,
You could do something similar to below, Querying the role you want then getting the users:
    @foreach(\BookStack\Auth\Role::query()->where('name', '=', 'admin')->first()->users as $user)

            {{ $user->id }}
            {{ $user->name }}

    @endforeach

You'd need to change admin to the name of the role in the DB.
BookStack users Laravel so those docs may provide more info.
Note though, any of these kind of app code usages or these kind of customizations/modifications are not supported as part of the BookStack project and may cause you trouble during upgrades.

Yeah, this is something a bit specific so I'll have to be careful about the updates in the future.
I'll look into the code a bit more while implementing it. Thanks for the answer!


[RHOAIENG-11530] Add file field advanced settings for connection type fields

Closes RHOAIENG-11530
Description
Adds the field field advanced settings for connection type fields
How Has This Been Tested?
Tested manually. Added RTL tests.
Screen shots

Request review criteria:
Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.

/cc @simrandhaliw

We shouldn't allow the user to save if there are duplicate extensions (case insensitive)

/lgtm
/approve


fix: wrong detection of untagged commits

I was wrongly using .dev. Use .post, just like dunamai.
Fixes https://github.com/copier-org/copier/issues/603.
TODO:

[ ] Add tests

Codecov Report

Merging #637 (0a2f4bc) into master (bc50fe0) will decrease coverage by 17.45%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #637       +/-   ##
===========================================
- Coverage   96.36%   78.91%   -17.46%
===========================================
  Files          41       41
  Lines        2722     2722
===========================================
- Hits         2623     2148      -475
- Misses         99      574      +475

Flag
Coverage Δ

unittests
78.91% <0.00%> (-17.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

copier/template.py
97.39% <0.00%> (-0.53%)
:arrow_down:

tests/test_complex_questions.py
17.30% <0.00%> (-82.70%)
:arrow_down:

tests/test_prompt.py
14.64% <0.00%> (-73.89%)
:arrow_down:

tests/test_vcs.py
36.00% <0.00%> (-64.00%)
:arrow_down:

tests/test_updatediff.py
39.88% <0.00%> (-60.12%)
:arrow_down:

tests/test_tools.py
64.00% <0.00%> (-28.00%)
:arrow_down:

tests/test_templated_prompt.py
76.47% <0.00%> (-23.53%)
:arrow_down:

tests/conftest.py
69.23% <0.00%> (-23.08%)
:arrow_down:

copier/user_data.py
72.03% <0.00%> (-21.81%)
:arrow_down:

copier/cli.py
81.17% <0.00%> (-15.30%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc50fe0...0a2f4bc. Read the comment docs.


Poc/react external

What's the purpose of this pull request?
Considering the context, what is the problem we'll solve? Where in VTEX's big picture our issue fits in? Write a tweet about the context and the problem itself.
How it works?
Tell us the role of the new feature, or component, in its context.
How to test it?
Describe the steps with bullet points. Is there any external link that can be used to better test it or an example?
References
Spread the knowledge: is there any content you used to create this PR that is worth sharing?
Extra tip: adding references to related issues or mentioning people important to this PR may be good for the documentation and reviewing process

The problem I see with this approach is being dependent on unpkg. Can we use our cdn instead?

@tlgimenes yeah, I just used unpkg for the proof of concept, should use our own for the non-poc version


[cloudsql] need to set <IP_ADDRESS> address on container command

This page says like below.

The "<IP_ADDRESS>" in the instances parameter is required to make the port accessible from outside of the Docker container.

https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/master/cloudsql/mysql_wordpress_deployment.yaml#L45
The line should be "-instances=<INSTANCE_CONNECTION_NAME>=tcp:<IP_ADDRESS>:3306"

That’s only the case of you’re exposing proxy port to outside the Pod I believe.
If you’re using a sidecar container (which is more secure and recommended), you should not use <IP_ADDRESS> as it will accept connections from outside the Pod.


[No QA] Rename Button and Text components to ExpensifyButton and ExpensifyText

Details

This PR renames our custom Text and Button components to ExpensifyText and ExpensifyButton. This is to more clearly differentiate between our custom components and the standard react-native components Text and Button.
cc @roryabraham @marcaaron
Fixed Issues

$ https://github.com/Expensify/App/issues/3133
Tests

There's no clear way to test this. Mainly just clicked around to various pages in the app to make sure text and buttons seemed to be getting rendered correctly.
QA Steps

No specific QA. Just click around to various pages in the app and make sure that text and buttons seem to be behaving normally.
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

I'm including screenshots of some different pages on different platforms to show that things seem to be working normally.

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Can somebody review and merge this? It is breaking the Workspace landing page. https://github.com/Expensify/App/pull/6576

Reviewed! Will merge once tests pass. Thanks for jumping on that.

🚀 Deployed to staging by @marcaaron in version: 1.1.17-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


fix(region): sync aliyun remark to cloud

What this PR does / why we need it:

[x] Smoke testing completed

If yes, write the release branches name in the below format and submit the related cherry-pick PR:

release/3.9

/area region
/cc @zexi

close #12736


Same tool for Facebook

As the title says, since Facebook should be running with similar stuff as Instagram, would be nice to get this fix for that too.

It is a bit different, I dont think I will create fx for facebook


Where are versions after 12.1?

I see, that NPM library is referencing this repository. I see, that tags, same way as releases end at version 12.1, but NPM has few other versions, as in 13.0.0 and 13.0.1.
Where are they coming from? What changes do they contain? Why there are no tags for them?

See also #1165

@jeroenheijmans but is it bug or docs topic? Because at the moment one issue has one label and other issue has other label.

Sure I'll change this one to be the same, all good to me. 😄

Looking at the fact that new code has not been pushed in months i'm starting to fear this project might be dead/abandoned?

This is really disturbing

Pinging @manfredsteyer to get clarification on this?

@manfredsteyer What is the mystery behind this?


Add support for Dragonbane and Twodsix systems

That file no longer exists; I think you want Elevation Ruler for system specific additions.


chore(deps-dev): remove redundant @types/amqplib

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.831%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
238

Relevant Lines:
242

💛  - Coveralls

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


need to include jshashes as package dependency

Module depends on this package, but it is not included in the package.json. Had to install manually.

nevermind, looks like it's in there, not sure why it didnt auto-install it when i installed the package.


[sensor_ctrl / ast] AST alert outputs

The AST differential alert outputs are not differential ALL the time.
Instead, they should be treated as two independent alert lines that MAY assert at different times.
The sensor_ctrl module would need to handle these appropriately.
@msfschaffner
@eunchan
@zi-v
Ziv, would you mind updating the ast documentation to specifically point this out?

should also make use of the alert_sender ack as part of the ast alert ack.
This was the intent but it seems the implementation was forgotten.

should also make use of the alert_sender ack as part of the ast alert ack.
This was the intent but it seems the implementation was forgotten.


Smaller Slippage <0.5%

There is no possibility to set the slippage below 0.5% - The possibility to create orders without any slippage would be helpful.

There is no possibility to set the slippage below 0.5% - The possibility to create orders without any slippage would be helpful.

@virus-zip Does this problem still exist? Currently slippage is in range from 0 to 50 percents, but can't be zero.


Using acts_as_api with Paperclip

First, thanks so much for acts_as_api—very useful!
I'm trying to use it with Paperclip, but  I'm having some trouble. I have a model with:
has_attached_file :attachment
And I'd like to be able to include :attachment in my acts_as_api template (template.add :attachment)
Attempting to do so like that gives me the following error:
SystemStackError (stack level too deep):
app/controllers/rooms_controller.rb:34:in show'   app/controllers/rooms_controller.rb:32:in show'
Rendered /Library/Ruby/Gems/1.8/gems/actionpack-3.1.0/lib/action_dispatch/middleware/templates/rescues/_trace.erb (134.8ms)
Rendered /Library/Ruby/Gems/1.8/gems/actionpack-3.1.0/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (1.3ms)
Rendered /Library/Ruby/Gems/1.8/gems/actionpack-3.1.0/lib/action_dispatch/middleware/templates/rescues/diagnostics.erb within rescues/layout (154.1ms)
So clearly just adding :attachment to the template and hoping it'll magically work didn't pan out! Any ideas/suggestions for how I might tackle this? With paperclip, I can access different sizes of an uploaded image, for example, using something like @message.attachment(:large) (where @message is an object with has_attached_file and :large is one of the Paperclip-resized versions of the image).
Thanks!

Hi,
you can not simply add the :attachment attribute to the template, because it is a Paperclip::Attachment object and neither acts_as_api nor the Rails renderers know how to resolve it when rendering the response.
You could do something like
t.add lamda{|model| model.attachment(:large) }, :as => :attachment
Or if you want to return all of the sizes, just create a helper method in your model that constructs a Hash:
  def all_avatar_urls
    avatars = {}
    avatars[:small]   = concealed.avatar.url(:small)
    avatars[:medium]  = concealed.avatar.url(:medium)
    avatars[:large]   = concealed.avatar.url(:large)
    avatars
  end

and add it to the template:
t.add :all_avatar_urls
Hope this helps. :)
I'm closing the issue now, but let me know if you need further assistance.
Best,
Chris

Thanks so much, Christian—that absolutely works. Really appreciate the help!
Best,
Adam
2011/12/1 Christian Bäuerlein <
<EMAIL_ADDRESS>

Hi,
you can not simply add the :attachment attribute to the template, because
it is a Paperclip::Attachment object and neither acts_as_api nor the
Rails renderers know how to resolve it when rendering the response.
You could do something like
t.add lamda{|model| model.attachment(:large) }, :as => :attachment
Or if you want to return all of the sizes, just create a helper method in
your model that constructs a Hash:
 def all_avatar_urls
   avatars = {}
   avatars[:small]   = concealed.avatar.url(:small)
   avatars[:medium]  = concealed.avatar.url(:medium)
   avatars[:large]   = concealed.avatar.url(:large)
   avatars
 end

and add it to the template:
t.add :all_avatar_urls
Hope this helps. :)
I'm closing the issue now, but let me know if you need further assistance.
Best,
Chris

Reply to this email directly or view it on GitHub:
https://github.com/fabrik42/acts_as_api/issues/47#issuecomment-2972557


Revert "cri-o: force image from docker.io for now"

We have an official build now.
Closes: https://github.com/openshift/aos-cd-jobs/issues/627
This reverts commit 5f61ec496b6691d16b75e48d4215ef9c3f16a219.

@kargakis @runcom @jwhonce  is it fine to go with this?
Currently blocked on: https://github.com/openshift/openshift-ansible/pull/5490
Otherwise we will need to use openshift_crio_systemcontainer_image_override instead of openshift_crio_systemcontainer_image_registry_override as the change went in.

LGTM

Assuming it's based on cri-o v1 rc2, lgtm

@jwhonce confirmed rc2 is the base over e-mail today

@giuseppe can you rebase on master and rerun the generation script?

@kargakis done, but until the image is on registry.access.redhat.com we will still need to override it (now it is done with openshift_crio_systemcontainer_image_override=.  What registry should be used?   registry.ops.openshift.com?
/cc @ashcrow

Once we know which registry should be used for override and the update occurs I'll 👍

let's override with the docker.io image for now, we will switch back once we know the official image is updated
@runcom @mrunalp

/lgtm

Pushed up


Recoil crosshair for scoped AUG and SG553

For some reason netvar IsScoped is not contain AUG and SG553,

Please update


add critical-pod annotation for pods

Fixes: https://github.com/kubevirt/kubevirt/issues/1149
Signed-off-by: Shiyang Wang<EMAIL_ADDRESS>

ok to test

Thanks!
Let's see what the CI says.

@yanirq doyou mind opening an issue for the priorities?

@yanirq doyou mind opening an issue for the priorities?
@fabiand  It depends , if we/dscheduler project decide to add a scoring mechanism for load balancing which will utilize pod priority for rescheduling decisions then it would make sense.
Its not handled yet.


Some more capitalization tweaks

Sorry I'm annoying

No worries! :) It's not annoying.
Note, that the html files in public/ are build from templates in templates/. Currently, this doesn't happen with github actions, but might be in the future. If you make the changes in the templates, then I can rebuild the page with the simple python build script. (Or you can do it if you want to run the script).


fix: 64-Bits Windows, Path::exists() fails for files over 2GB.

Summary
I have modified the code to address the incorrect handling of files larger than 2GB in a 64-bit Windows environment.
Problem
I discovered that when using utils::Path to input a file path of more than 2GB and calling utils::Path::exists(), it throws an error indicating that the file does not exist.
example
    utils::Path src = utils::Path("big_file");
    bool exists = src.exists();
    // 'exists' would be false when the 'big_file' size is over 2 GB

Environment

OS: Windows 11 Enterprise 21H2 (x64 processor)
Build: 22000,2057
CPU: 12th Gen Intel(R) Core(TM) i9-12900K
RAM: 128 GB

(Mac and Linux(Ubuntu) have not occurred this error)
Test

I have tested various types of pre-defined syntax, but I have confirmed that only those two statements resulted in this error on my computer.

Test Code
#include <iostream>
#include <string>
#include <filesystem>

void stat_test(const std::string& url) noexcept
{
    {
        struct stat file;
        int i = stat(url.c_str(), &file);
        std::cout << "1) stat \tcase: " << (i == 0 ? "true" : "false") << " \tsize: " << file.st_size << std::endl;
    }

    {
        struct _stat64 file;
        int i = _stat64(url.c_str(), &file);
        std::cout << "2) _stat64 \tcase: " << (i == 0 ? "true" : "false") << " \tsize: " << file.st_size << std::endl << std::endl;
    }
}

int main(int argc, char** argv)
{
    std::cout << "stat test" << std::endl << std::endl;
    std::string url = "../big_file.ply"; // test file whose size is larger than 2GB.

    std::filesystem::path p = std::filesystem::path(url);
    if (!std::filesystem::exists(p))
    {
        std::cout << "file-path is invalid" << std::endl;
        return 0;
    }

#if defined(__LP64__)
    std::cout << "__LP64__" << std::endl;
#endif
#if defined(_WIN64)
    std::cout << "_WIN64" << std::endl;
    stat_test(url);
#endif

#if defined(__x86_64__) && !defined(__ILP32__)
    std::cout << "__x86_64__&& __ILP32__" << std::endl;
#endif

#if defined(_M_X64)
    std::cout << "_M_X64" << std::endl;
    stat_test(url);
#endif

#if defined(__ia64)
    std::cout << "__ia64" << std::endl;
#endif
#if defined (_M_IA64)
    std::cout << "_M_IA64" << std::endl;
#endif
#if defined(__aarch64__)
    std::cout << "__aarch64__" << std::endl;
#endif
#if defined(__powerpc64__)
    std::cout << "__powerpc64__" << std::endl;
#endif

    return 1;
}

Result

This result shows you which predefined syntaxes would be compiled and shown the wrong result at utils::Path::exists().

stat test
_WIN64
1) stat         case: false     size: 0
2) _stat64      case: true      size:<PHONE_NUMBER>

_M_X64
1) stat         case: false     size: 0
2) _stat64      case: true      size:<PHONE_NUMBER>

Detail
utils::Path::exists() const is defined as follows:
bool Path::exists() const {
    struct stat file;
    return stat(c_str(), &file) == 0;
}

Here, the struct stat is mapped to struct _stat64i32 in the Windows environment, and this structure supports 32-bit file formats.

https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=msvc-170#time-type-and-file-length-type-variations-of-_stat

Conclusion
To address the mentioned issue, I have added code that can choose the _stat64 or stat based on the pre-defined conditions.
I chose the conditions in the "Test Code" section.
This modification allows for distinguishing file sizes larger than 2GB.

Thanks for updating the release notes but more importantly you need to sign the CLA.

Thanks for updating the release notes but more importantly you need to sign the CLA.

Thank you for letting me know.
I have already signed the CLA as follows.

Agreement
Name
Date Signed
Manage

Google Individual CLA
Junsang Lee
Jul 06, 2023 18:53 PDT
Edit Contact Information

Please let me know if there is anything else I need to consider.

That's odd it still doesn't show up as a valid check.

That's odd it still doesn't show up as a valid check.

I have just confirmed that my email address was set to private.
Now, I have changed the email address permission to public!

It still fails, can you sign the CLA again please?

Looks like the issue is the email listed in the PR:

The following contributors were found for this pull request:
✅ https://github.com/google/filament/commit/f703c672ed9c8bc7048b3177598ca1142c97b3ae PR Opener: @emotiog
❌ https://github.com/google/filament/commit/f703c672ed9c8bc7048b3177598ca1142c97b3ae Author<EMAIL_ADDRESS>

I apologize for the mistake.
There was a typo in the email during the commit. It has been corrected now.

Thank you so much!


Add check on Xpath's start to SelenideElement find methods

The problem
When we use method find (ByXpath) or $/$$ on SelenideElement we expects that this method would be search element from this SelenideElement, but commonly it's not  true.
For example:
We have DOM:
<A>
 <B>
   <C>
       <button>H!</button>
       <D>
             <button>H!</button>
       </D>
    </C>
 </B>
 <B1>
    <C>
             <button>H!</button>
    </C>
 </B1>
</A>

$x("//B").findAll(By.xpath("//button"))  //should find "//B//button", but found just "//button"
To get "//B//button" we should specify Xpath like that
$x("//B").findAll(By.xpath(".//button"))
To avoid that nonintuitive behavior i suggest to add check for Xpath's start to all find methods which working with Xpath to SelenideElement. That check will be throw exception with message like "You must start Xpath with '.' (dot symbol) when you want to find element from another." in case when search method on SelenideElement called with Xpath starts on no '.' (dot) symbols.
Maybe, it make sense to add Configuration flag to turn off that behavior for backward compatibility and people who wants strange

I think the example is not very successful...
Should i specify all examples (on all methods) or it better to do in real tests?

You  should start your xpath from dot (.) if you want to find element in element
In Your example you should write $x("//B").findAll(By.xpath(".//button"))

Agree. Thanks)

@rusakovStas I agree, we should add such a check. I don't think we need a Configuration flag because this behaviour is just never needed.

I suggest different approach, maybe the '.' should be injected at start of string if someone uses xpath? From what i see it needs to be added in find(), findAll() and maybe $ methods.

@SeleniumTestAB Probably it's a good idea. Hard to choose one: if Selenide should throw an exception or just add "." automatically.
Probably exception is better because it forces people to learn XPath?

Probably exception is better because it would force people to learn XPath?
Please do not do anything with this functionality. This is a part ofXPath functionality not Selenium or Selenide.

@AlexKvasko
Could you write an example of usage that functionality?

@AlexKvasko
Could you write an example of usage that functionality?

//a[contains(.,'link')]
.//*[@id='awesomeId']
Dot is not a part of selenium.

I knew that)
I mean usage of Xpath which starts on no dot symbol in case like:
$("some element").$x("xpath which start on no dot symbol")

Implemented by PR https://github.com/selenide/selenide/pull/975 in Selenide 5.4.0


COMP: Remove deprecated uses of vxl for LEGACY ITK

When ITK specifies removing support for LEGACY code uses, then VTK should also remove support.
This patch sets "VXL_USE_HISTORICAL_IMPLICIT_CONVERSIONS=OFF" when ITK_LEGACY_REMOVE or ITK_LEGACY_FUTURE_REMOVE is requested.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

Thanks Hans. Just a nitpick:

When ITK specifies removing support for LEGACY code uses, then VTK...

Are you sure this is about VTK?


LineFormatter::includeStacktraces overriding allowInlineLineBreaks

Hey there,
so I'm using Monolog in my project and I'm configuring it using theorchard's Cascade library. As you might know it can configure options in two ways: constructor arguments and extra options handler. The LineFormatter for example gets its allowInlineLineBreaks option via constructor, while includeStacktraces is set via an optionHandler, calling LineFormatter's includeStacktraces method.
In my case, I need the whole message to be on one line, because I'm parsing each line for a log viewer. This has worked fine until the most recent patch 1.22.1, in which the string \n is replaced with an actual new line character.
So, the actual problem is, that allowInlineLineBreaks is set in the very beginning, when the formatter is constructed. When the Cascade configurator calls includeStacktraces() later on, however, the option is overridden.

I would much prefer includeStacktraces() to not change any other options than the actual includeStacktraces option and thus leave this decision to the developer.
Best regards

In this case you really should call ...->includeStacktraces(true); then ...->allowInlineLineBreaks(false). Having stack traces in a single line is usually quite messy as it results in long lines so this is just monolog trying to have the right defaults..  Maybe this could be fixed in Cascade directly /cc @rantonmattei


Helm deployment of Istio ingress gateway does not provide a way to configure gateway's TLS certificate Subject/CommonName

Bug Description
Istio (v1.16.0) deployment is done via helm charts as per the documentation:
https://istio.io/latest/docs/setup/install/helm/
Istio Helm charts repo location v1.16.0:

https://istio-release.storage.googleapis.com/charts
helm repo add istio https://istio-release.storage.googleapis.com/charts
helm repo update
kubectl create namespace istio-system
helm install istio-base istio/base -n istio-system
helm install istiod istio/istiod -n istio-system --wait
kubectl create namespace istio-ingress
kubectl label namespace istio-ingress istio-injection=enabled
helm install istio-ingress istio/gateway -n istio-ingress --wait

After the deployment completes, connect to the ingress-gateway LoadBalancer IP and dump the certificate subject using openssl command. The TLS certificate Subject is empty. With mutual TLS STRICT mode enabled will make the external TLS clients to fail to connect to ingress gateway as follows:
$ curl --cert client.crt --key client.key --cacert cacert.crt https://<IP_ADDRESS>:<portNo>/
curl: (51) Unable to communicate securely with peer: requested domain name does not match the server's certificate.

$ kubectl get svc -n istio-ingress
NAME            TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                                                                                AGE
istio-ingress   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>    443:31015/TCP   38m
$
$ openssl s_client -connect <IP_ADDRESS>:<portNo>
$ openssl s_client -connect <IP_ADDRESS>:9527 2>/dev/null | grep -A24 'Server certificate'
Server certificate
-----BEGIN CERTIFICATE-----
MIIDZDCCAkygAwIBAgIQDXNt1KGajOgCpaRMT3BdPzANBgkqhkiG9w0BAQsFADAY
MRYwFAYDVQQKEw1jbHVzdGVyLmxvY2FsMB4XDTIyMTIxMzA0NDQ1MloXDTIyMTIx
NDA0NDY1MlowADCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBANna4yn1
V1sAdiXZW5UKMcCbm3MV9EpnR81o4DMCvufq1O7Aq+CIPdfOoRme3Li6Pxt29Xxe
SRTF1/D5Ls2zsC6VW6qFfVVr5naTmCOhWWANiLEpz7xYtpYwzFVe5oFD8owW8GZv
Jb7pSREojafm7dxF2Irv56qn5NQK7B4RIhZhzY3tAqsZ0TMQQmvDlzU2GixUNScf
UWzhElzvTR02AcGFSAFwY9A8W6mIKz49mY02eal6FRLoxP70NjTzL7He00mN39mM
h9uKWf3dEbbZNILC1E91EiGqE0xjjEpd7y0iUaIjIMp5kkEV2qXe01PnNmU/tpcl
XbWIfVvrjZGKcekCAwEAAaOBwTCBvjAOBgNVHQ8BAf8EBAMCBaAwHQYDVR0lBBYw
FAYIKwYBBQUHAwEGCCsGAQUFBwMCMAwGA1UdEwEB/wQCMAAwHwYDVR0jBBgwFoAU
kwRiTP7Zc2bSgSNNzFF6hrASKc4wXgYDVR0RAQH/BFQwUoZQc3BpZmZlOi8vY2x1
c3Rlci5sb2NhbC9ucy9wdWxzYXIvc2EvcHVsc2FyLXNuLXBsYXRmb3JtLXN0cmVh
bW5hdGl2ZS1jb25zb2xlLWFjY3QwDQYJKoZIhvcNAQELBQADggEBALY5lTxrnqKl
at2WUXp/QykDERCBwUR5V9JLjs9GHcuy8LYFjc8NxbA2l4tW3SIWe4wqpYy4gE/t
Yt6kwPvqw00DwwpfYBanIqqcu4SvppNKLKXuK0HisLhKQ5YEE1d/IGF8CZbnmzAo
NJ+9MIU4v7ZRw1Qn66IfBosfKZ3IIzcoP7KwVeDix2f/7SmwjjE+7A+56gnf8EHo
Fa9LW6oWR+fm+MrQan0kciXAVScNaMfiFiOXHu+9ShAiYueAH6OcKBwBxG4YmXrp
WHZYZ/AHjSVE4jo7YmR2ulkooiN2n0yIm2cy5JeqIp6TZZFI3mKMbrtukvqKuotV
GAlA7jsF1Yk=
-----END CERTIFICATE-----
subject=
issuer=/O=cluster.local
---

Notice the "subject=" is empty and not populated. There has to be a way to specify the host value of the ingress gateway TLS certificate when deployed with helm charts.
Searched all the documentation to configure hostname on the istio (v1.16.0) ingress-gateway when deployed with helm charts and there is no way to specify the hostname on the TLS certificate of istio-ingress-gateway.
Version
$ kubectl version --short
Client Version: v1.23.10
Server Version: v1.23.10
$ helm version --short
v3.7.1+g1d11fcb
$

Additional Information
The deployment solely uses helm charts for istio/base, istio/istiod and istio/gateway (for ingress-gateway).
The deployment does not use istioctl
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Is this the right place to submit this?

[X] This is not a security vulnerability
[X] This is not a question about how to use Istio

TLS is configured using a Gateway object. This is done after installing. https://istio.io/latest/docs/tasks/traffic-management/ingress/secure-ingress/

Thanks for looking. The provided link does not point to the helm chart installation way.
Installation using Helm chart is key for automated deployment and ISTIO adoption.
Is there an agreement, this is a gap with the current ingress-gateway helm chart installation with "Gateway" object?


Fixed inconsistencies between listen and emit

Redo of #926
Please specify parts of this PR update:

[x] Specification
[x] Schema
[ ] Examples
[ ] Extensions
[ ] Use Cases
[ ] Community
[x] CTK
[ ] Other

Discussion or Issue link:
Closes #917 (and other little minor typo)
What this PR does:

Fixes inconsistencies between listen and emit

Added new event section in the specification documentation
Fixed the sample of emit in the specification documentation
Added new event definition in the JSON schema and referenced it in emit.event.with and eventFilter.with

Fixes a typo in the set feature
Fixed type of an http call endpoint by adding string
Added new (missing) endpoint section in the specification documentation
Escaped * character
Fixed double https://https://
Fixed links to runtime expressions
Fixed typo in implictly

Additional information:
-

@JBBianchi I was wondering if it wont be better to have a schema with the data that is shared by emit and listen (which I feel should contain type, source, subject, dataContentType and time?) which will be used for listen filter and another one that inherits it (and adds id, data and dataschema?) and is used for emit Then, you wont have to explain that id is required for emission only (you still have for source and type, which are shared by both), but at least a user wont be able to put id or data in a filter (I have doubts about if dataschema and time can be used for filtering or not, precisely to avoid this kind of doubt I feel we need two different schemas, that can share common properties)

Unless I'm mistaken, the current schema already shares the common properties and validates the ones that are required at their level. The explanation is necessary in the documentation because its describing the "shared" object properties.
As a side note, I'm still waiting for feedbacks ok @ricardozanini 's comment. I think it's a broader scope than just this PR though and would affect other object that could be built using runtime expressions. Should we open a dedicated issue ?

@JBBianchi
But id and data should not be part of the event filter on listen isnt it?

@fjtirado It can, but is not required

@cdavernas Ok, that was my doubt, so we can filter by any cloud event field.

Which remind me that maybe the right name for the schema, rather that eventproperties should be cloudEvent?

@fjtirado that was how JB named it first, but is IMHO opinion confusing. It's the properties/filter of the CloudEvent to produce/listen, not the event itself


App not compiling for the Flutter Web

I am building a Flutter app using a Supbase, I am getting an issue while building app for the Web.
Below error what I got
Launching lib/main.dart on Chrome in debug mode...
Waiting for connection from debug service on Chrome...
lib/screen/dashboard/profile/store/profile_screen_store.dart:166:43: Error: The argument type 'File/*1*/' can't be assigned to the parameter type 'File/*2*/'.
 - 'File/*1*/' is from 'dart:io'.
 - 'File/*2*/' is from 'package:universal_io/src/io/file.dart' ('../../../../.pub-cache/hosted/pub.dartlang.org/universal_io-2.0.4/lib/src/io/file.dart').
            .update('$fileName$imageExt', file);
                                          ^
lib/screen/dashboard/profile/store/profile_screen_store.dart:170:43: Error: The argument type 'File/*1*/' can't be assigned to the parameter type 'File/*2*/'.
 - 'File/*1*/' is from 'dart:io'.
 - 'File/*2*/' is from 'package:universal_io/src/io/file.dart' ('../../../../.pub-cache/hosted/pub.dartlang.org/universal_io-2.0.4/lib/src/io/file.dart').
            .upload('$fileName$imageExt', file);
                                          ^
Failed to compile application.

Link to Source code
profile_screen_store

You need to use the universal_io package, as dart:io doesn't work on web.

My bad, Thanks. Closing this.

@ibhavikmakwana, just a note that on the web you need to use uploadBinary.
Check out the example here

Sure, Thanks you :)


Fix link not to point to jburel

This is a follow-up of the outreach updating PR, see https://github.com/openmicroscopy/prod-playbooks/pull/67#issuecomment-391861695
cc @jburel

You can replace master by v0.1.0
when training-scripts is tagged today you will be able to run the playbook

If you rerun the playbook can you include https://github.com/openmicroscopy/prod-playbooks/pull/69 otherwise the https setup will be lost.

training-scripts has been tagged https://github.com/ome/training-scripts/releases/tag/v0.1.0

Do not know how to restart travis. It seems to fail on the link with the v0.1.0 which is now okay already. But, I do not have the little buttons in the travis UI to rerun the build, although I am logged in....

restarted

The playbook was run on outreach just now (with https://github.com/openmicroscopy/prod-playbooks/pull/69 merged in locally). All seems well on outreach server, https as well as the batch_roi_export.py are okay.

Merging so we can tag the training-repos