feat: make ttl & batch_size SUSET

What kind of change does this PR introduce?
feature
What is the current behavior?
Changing pg_net.ttl and pg_net.batch_size requires ALTER SYSTEM (which is SU-only) and a config reload.
What is the new behavior?
pg_net.ttl and pg_net.batch_size can be changed with ALTER ROLE ... SET ... + a config reload.

P.S. I'm unable to nix-shell on macOS:
❯ nix-shell --show-trace
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'nix-shell'
         whose name attribute is located at /nix/store/h37bdrm450d1whv8pfsv30wfpri0kir5-24.05/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'buildInputs' of derivation 'nix-shell'

         at /nix/store/h37bdrm450d1whv8pfsv30wfpri0kir5-24.05/pkgs/stdenv/generic/make-derivation.nix:378:7:

          377|       depsHostHost                = elemAt (elemAt dependencies 1) 0;
          378|       buildInputs                 = elemAt (elemAt dependencies 1) 1;
             |       ^
          379|       depsTargetTarget            = elemAt (elemAt dependencies 2) 0;

       … while evaluating derivation 'net-with-pathod'
         whose name attribute is located at /nix/store/h37bdrm450d1whv8pfsv30wfpri0kir5-24.05/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'text' of derivation 'net-with-pathod'

         at /nix/store/h37bdrm450d1whv8pfsv30wfpri0kir5-24.05/pkgs/build-support/trivial-builders/default.nix:103:16:

          102|       ({
          103|         inherit text executable checkPhase allowSubstitutes preferLocalBuild;
             |                ^
          104|         passAsFile = [ "text" ]

       … while evaluating derivation 'python3.7-mitmproxy-4.0.4'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/interpreters/python/mk-python-derivation.nix:105:3

       … while evaluating attribute 'nativeBuildInputs' of derivation 'python3.7-mitmproxy-4.0.4'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:217:11:

          216|           depsBuildBuild              = lib.elemAt (lib.elemAt dependencies 0) 0;
          217|           nativeBuildInputs           = lib.elemAt (lib.elemAt dependencies 0) 1;
             |           ^
          218|           depsBuildTarget             = lib.elemAt (lib.elemAt dependencies 0) 2;

       … while evaluating derivation 'python3-3.7.6'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:191:11

       … while evaluating attribute 'CPPFLAGS' of derivation 'python3-3.7.6'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/interpreters/python/cpython/default.nix:130:3:

          129|
          130|   CPPFLAGS = concatStringsSep " " (map (p: "-I${getDev p}/include") buildInputs);
             |   ^
          131|   LDFLAGS = concatStringsSep " " (map (p: "-L${getLib p}/lib") buildInputs);

       … while calling anonymous lambda

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/interpreters/python/cpython/default.nix:130:41:

          129|
          130|   CPPFLAGS = concatStringsSep " " (map (p: "-I${getDev p}/include") buildInputs);
             |                                         ^
          131|   LDFLAGS = concatStringsSep " " (map (p: "-L${getLib p}/lib") buildInputs);

       … while evaluating derivation 'zlib-1.2.11'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/libraries/zlib/default.nix:18:3

       … while evaluating attribute 'src' of derivation 'zlib-1.2.11'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/libraries/zlib/default.nix:21:3:

           20|
           21|   src = fetchurl {
             |   ^
           22|     urls =

       … while evaluating derivation 'zlib-1.2.11.tar.gz'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/build-support/fetchurl/default.nix:119:3

       … while evaluating attribute 'mirrorsFile' of derivation 'zlib-1.2.11.tar.gz'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/build-support/fetchurl/default.nix:139:10:

          138|
          139|   inherit curlOpts showURLs mirrorsFile postFetch downloadToTemp executable;
             |          ^
          140|

       … while evaluating derivation 'mirrors-list'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/build-support/fetchurl/default.nix:14:7
       … while evaluating attribute 'stdenv' of derivation 'mirrors-list'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:201:18:

          200|           args = attrs.args or ["-e" (attrs.builder or ./default-builder.sh)];
          201|           inherit stdenv;
             |                  ^
          202|

       … while evaluating derivation 'stdenv'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/default.nix:84:14

       … while evaluating attribute 'initialPath' of derivation 'stdenv'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/default.nix:114:14:

          113|
          114|       inherit initialPath shell
             |              ^
          115|         defaultNativeBuildInputs defaultBuildInputs;

       … while evaluating derivation 'xz-5.2.4'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/tools/compression/xz/default.nix:4:3

       … while evaluating attribute 'src' of derivation 'xz-5.2.4'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/tools/compression/xz/default.nix:6:3:

            5|
            6|   src = fetchurl {
             |   ^
            7|     url = "https://tukaani.org/xz/${name}.tar.bz2";

       … while evaluating derivation 'xz-5.2.4.tar.bz2'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/build-support/fetchurl/default.nix:119:3

       … while evaluating attribute 'nativeBuildInputs' of derivation 'xz-5.2.4.tar.bz2'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:217:11:

          216|           depsBuildBuild              = lib.elemAt (lib.elemAt dependencies 0) 0;
          217|           nativeBuildInputs           = lib.elemAt (lib.elemAt dependencies 0) 1;
             |           ^
          218|           depsBuildTarget             = lib.elemAt (lib.elemAt dependencies 0) 2;

       … while evaluating derivation 'curl-7.68.0'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/tools/networking/curl/default.nix:31:3

       … while evaluating attribute 'configureFlags' of derivation 'curl-7.68.0'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:231:11:

          230|           # This parameter is sometimes a string, sometimes null, and sometimes a list, yuck
          231|           configureFlags = let inherit (lib) optional elem; in
             |           ^
          232|             (/**/ if lib.isString configureFlags then [configureFlags]

       … while evaluating derivation 'openssl-1.1.1f'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:191:11

       … while evaluating attribute 'nativeBuildInputs' of derivation 'openssl-1.1.1f'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/stdenv/generic/make-derivation.nix:217:11:

          216|           depsBuildBuild              = lib.elemAt (lib.elemAt dependencies 0) 0;
          217|           nativeBuildInputs           = lib.elemAt (lib.elemAt dependencies 0) 1;
             |           ^
          218|           depsBuildTarget             = lib.elemAt (lib.elemAt dependencies 0) 2;

       … while evaluating derivation 'perl-5.30.1'
         whose name attribute is located at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/interpreters/perl/default.nix:29:5

       … while evaluating attribute 'disallowedReferences' of derivation 'perl-5.30.1'

         at /nix/store/l561dnq1r5xc7g4jwcxpjd5czap64990-2020-04-20/pkgs/development/interpreters/perl/default.nix:41:5:

           40|
           41|     disallowedReferences = [ stdenv.cc ];
             |     ^
           42|

       error: cannot coerce null to a string

P.S. I'm unable to nix-shell on macOS:
… while evaluating attribute 'nativeBuildInputs' of derivation 'python3.7-mitmproxy-4.0.4'

It's related to the pathod command, which is deprecated and likely has issues with newer python versions. I can clear that on https://github.com/supabase/pg_net/issues/106#issuecomment-2305413949.


Sample tests are now skipped with ".skip"

Related Issue

Fixes #427
Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[ ] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Realm repository changes (explain below)

Optional: Add any explanations here
Tried to add comments to help users that want to run these examples.
Also, a small error came up while testing with "class" being used over "className".
It was my mistake and so small that to make a new issue seemed overkill. It is fixed here.

Optional: Add any relevant screenshots here

Looks great!
Confirmed that with this change it skips the 5 sample tests:
Test Suites: 5 skipped, 5 passed, 5 of 10 total
Tests:       6 skipped, 9 passed, 15 total
Snapshots:   0 total
Time:        6.327 s
Ran all test suites.


Lex slot validation using lambda code hook in lex v2 console

I'm currently exploring the capabilities of Amazon Lex V2 and I have a question regarding slot validation using Lambda code hook.
In the Lex V2 console, I see that we can define slot validation rules using Lambda code hooks to validate user input before it's passed to the intent. However, I'm curious if this feature is available when using the generated dedicated bot in the QnABot AWS solution.
Can anyone confirm if we can utilize Lex slot validation using Lambda code hooks in the QnABot AWS solution?
Can we enable this?

If not, are there any alternative methods for slot validation in this context? Additionally, if you have experience with handling slot validation in QnABot or know of any alternative solutions, please feel free to share.
Any insights or experiences shared would be greatly appreciated! Thank you.
Example:
Using IntentSlotMatching.Example.Q1,

Let's say there's a slot named CarType. I'm interested in configuring the slot prompt to handle invalid slot values.
Here's an example scenario:
Bot: "What type of car would you like to rent? Our most popular options are economy, midsize, and luxury."
User: "sports car"
Bot: "I'm sorry, but 'sports car' is not a valid car type. Please choose from our available options: economy, midsize, or luxury."
Current experience:

@dangollayan thanks for your interest, we will get back to you

thanks @dougtoppin !!

@dangollayan - I will refer you to the implementation guide of QnA available at
more specifically the following two sections:
https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/architecture-details.html#amazon-lex-web-client
and
https://docs.aws.amazon.com/solutions/latest/qnabot-on-aws/configure-intent-and-slot-matching.html
this has in fact and example similar to your case and in addition, the notes and consideration explains that
"To take advantage of the additional features supported by Amazon Lex, such as confirmation prompts and regular expression to validate the value of a slot, you can also create the Amazon Lex intents and slot types in the QnABot Lex bot using the Amazon Lex console. For more information, refer to Adding intents in the Amazon Lex V2 Developer Guide.
Even if the Amazon Lex intents and slot types are created in the Amazon Lex console (created outside of the QnABot designer), you can reference any SlotType defined in the bot in a QnABot Item ID, and also map a QID to a manually created Amazon Lex intent in QnABot on AWS."
I hope this helps.
Fabien

I am closing this as the answer was provided above. Please re-open if needed


AllowCropping rotating the saved picture 90 degrees clockwise

Bug Information
Version Number of Plugin: 3.0.1
Device Tested On: iPhone 5, iPhone 7, Samsung Note4
Simulator Tested On: None
Version of VS: 7.0.1 build 24 (for mac)
Version of Xamarin:
Versions of other things you are using:
Steps to reproduce the Behavior

add AllowCropping = true to StoreCameraMediaOptions
Take Photo in portrait orientation (bottom of photo is at iPhone button)
Save Photo

Expected Behavior

Photo appears on page same as taken (bottom of photo is at iPhone button)

Actual Behavior

Photo appears on page rotated 90 degrees clockwise (right side of photo is at iPhone button)

Code snippet
		public async void TakePhoto(object sender, EventArgs args)
		{

            // Check to see if the camera is avialble and taking a photo is supported
		    if (!CrossMedia.Current.IsCameraAvailable || !CrossMedia.Current.IsTakePhotoSupported)
		    {

				await DisplayAlert("No Camera", ":( No camera available.", "OK");
		        return;
		    }

            // Take a photo.
            // Currently, save the file in a sample directory with the name test.jpg
			var file = await CrossMedia.Current.TakePhotoAsync(new StoreCameraMediaOptions
			{

                // RESET PHOTO SIZE
				// By default the photo that is taken/picked is the maxiumum size and quality available.
                // For most applications this is not needed and can be Resized.
                // This can be accomplished by adjusting the PhotoSize property on the options.
                // The easiest is to adjust it to Small, Medium, or Large, which is 25%, 50%, or 75% or the original.

				// Photo Size options examples

				PhotoSize = PhotoSize.Medium,

				//PhotoSize = PhotoSize.Custom,
                //CustomPhotoSize = 90, // Resize to 90% of original

                // PHOTO QUALITY
				// Set the CompressionQuality, which is a value from 0 the most compressed all the way to 100, which is no compression.
                // A good setting from testing is around 92
                CompressionQuality = 92,

                // SAVING PHOTO TO CAMERA ROLL
				// You can now save a photo or video to the camera roll/gallery.
				// When creating the StoreCameraMediaOptions or StoreVideoMediaOptions simply set SaveToAlbum to true.
				// When your user takes a photo it will still store temporary data, but also if needed make a copy to the public gallery (based on platform).
				// In the MediaFile you will now see a AlbumPath that you can query as well.
				// This will restult in 2 photos being saved for the photo.
                // One in your private folder and one in a public directory that is shown. The value will be returned at AlbumPath.
                // Android: When you set SaveToAlbum this will make it so your photos are public in the Pictures/YourDirectory or Movies/YourDirectory.
                // This is the only way Android can detect the photos.
                SaveToAlbum = true,

				// ALLOW CROPPING
                // iOS has crop controls built into the the camera control when taking a photo.
                // On iOS the default is false.
                // You can adjust the AllowCropping property when taking a photo to allow your user to crop.
                AllowCropping = true,

                // DEFAULT CAMERA
                // By default when you take a photo or video the default system camera will be selected.
                // Simply set the DefaultCamera on StoreCameraMediaOptions.
                // This option does not guarantee that the actual camera will be selected because each platform is different.
                // It seems to work extremely well on iOS,
                // but not so much on Android.Your mileage may vary.
                //DefaultCamera = CameraDevice.Front,

                // Where should we save our private copy of the photo
				Directory = "toms_camera_test_photos",

                // What should we name the photo
                // Might be a good idea to add a time stamp on here
				Name = "testPhoto" + DateTime.Now.ToString("yyyyMMddHHmmss") + ".jpg",

			});

			if (file == null)
				return;

			//Get the public album path
			var aPpath = file.AlbumPath;
			Debug.WriteLine("This is the file.AlbumPath " + aPpath);

			//Get private path
			var path = file.Path;
            Debug.WriteLine("This is the file.Path " + path);

            // Display an alert showing where the file was saved
			await DisplayAlert("File Location private path", path, "OK");

            // Update the Source for the image tag on the Xaml page with where we just saved the file
			image.Source = ImageSource.FromStream(() =>
			{
				var stream = file.GetStream();
				file.Dispose();
				return stream;
			});

			//or:
			//image.Source = ImageSource.FromFile(file.Path);
			//image.Dispose();
		}

Screenshotst

I am seeing this behavior as well using version 3.0.1

I have the same problem. However the file saved is correct.

Same behavior with my application. I will probably rollback to a previous version as a workaround.

@todorgrigorov this would be in all versions as I don't manipulate the photo and apple is rotating it.

Closing and putting this into a feature as rotating on iOS was never implemented like this.
See: https://github.com/jamesmontemagno/MediaPlugin/issues/334


chore(deps): update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.15.13

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.15.12 -> 4.15.13

Release Notes

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.15.13
Compare Source
Bug Fixes

deps: update terraform-module (#547) (1a284ed)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.3.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bug: Avatar is either not shown or is not the user

Describe the bug
I opened the notification and the avatars of the same user are either empty or not the user.
Screenshot

(I'm sure the first avatar is not @BekahHW 😁)
Steps to reproduce

Click the notification icon.
See the avatars of the users.

Browsers
Chrome
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

In your case, I think what's happening is that Bekah is reacting to different highlights (notice the different numbers) you've posted but since the profile pictures aren't being loaded, it looks odd.
I noticed something similar where people's profile pictures aren't being loaded even though I know they have images (like bdougie, martin, etc)

This error may due to the notification meta_id being used here. We have access to the user id, but we cache users based on usernames.
We will probably need an API update to include username.
https://github.com/open-sauced/insights/pull/1478/files#diff-2524a786a0bcb5deadfbb244b5d5ef18304b923e055b9f64c1dd9fd0c695a592R158
We will also don't need to add the meta_id to the message. Weird seeing 239 BekahHW did a thing

We will probably need an API update to include username.

Agree

We will also don't need to add the meta_id to the message. Weird seeing 239 BekahHW did a thing

Indeed, but we need to include the highlight_id though. Should we keep meta_id which can be the username or highlight_id and add a username property?
cc @brandonroberts

In my example above 239 is the highlight ID. The user does not need to see that in the text, to be clear keeping that in the response from the API is expected.
There is no value with having 239 in my notification. That needs to be removed in the UI.
This should be a straight forward API update. Could you open the issue @takanome-dev so we discuss there.

In my example above 239 is the highlight ID. The user does not need to see that in the text, to be clear keeping that in the response from the API is expected.
There is no value with having 239 in my notification. That needs to be removed in the UI.
This should be a straight forward API update. Could you open the issue @takanome-dev so we discuss there.

Yes, we can add "from" user information to each notification in the API.
Here is an example
https://github.com/open-sauced/api/blob/beta/src/user/user.entity.ts#L522
https://github.com/open-sauced/api/blob/beta/src/user/entities/user-collaboration.entity.ts#L53
The meta_id field should be used along with the type to build the URL of where it should link to, which is what we had in the UI before with the notification bell.

I realized that this was a silly mistake I made since I didn't have highlight reaction notification :sweat:. Submitted a fix for it.
Should I keep working on the pr in the API to include the user information, @brandonroberts @bdougie?


Turn .container into a utility component

Who is this for?
Devs/maintenance
What is it doing for them?

One step closer to getting rid of utility classes, see #10018 for more details
I had to add isContainer to Space as Container and Space are both styled components and I couldn't find another way to merge them - if we hate it, let's discuss.
Something is up with styled-components and type declaration where it ruins the rendering of the rest of the file (see screenshots). If we move that type declaration in its own right, it renders it properly. Extra faff, but so much more readable.

I don't love the isContainer

Same, I really don't like it!
I just realised there might be a simpler solution, it looks the same to me as prod does, so idk if I was just too close to it when I originally made the PR? Do confirm if I'm missing something?

Ha, that would work. It did actually cross my mind when I first looked at it and then I got caught up in trying to find a way to combine styled components and forgot.

Think that's what happened to me too 😅 sometimes we just have to walk away and come back. I'll merge on Monday 👍


gonna see if we get multiple approvals when queuing up labels during PR creation

Bug confirmed: GitHub is firing several events on PR creation when you do something like specifying a label or requesting a reviewer upfront, and that's triggering multiple parallel runs of the approval bot.


[spark] Replace create existing tag semantic with replace_tag

Purpose
In default way, the create_tag procedure for an existing tag means to update it or fail,  it's semantic is not very accurate, replace it with repalce_tag procedure.
before semantic
CALL paimon.sys.create_tag(table => 'test.T', tag => 'test_tag', snapshot => 1)")

-- success. update it
CALL paimon.sys.create_tag(table => 'test.T', tag => 'test_tag', snapshot => 1, time_retained => '1 d')")

-- failed
CALL paimon.sys.create_tag(table => 'test.T', tag => 'test_tag', snapshot => 2)")

after semantic
CALL paimon.sys.create_tag(table => 'test.T', tag => 'test_tag', snapshot => 1)")

-- failed
CALL paimon.sys.create_tag(table => 'test.T', tag => 'test_tag', snapshot => 1, time_retained => '1 d')")

-- success. use replace to update
CALL paimon.sys.replace_tag(table => 'test.T', tag => 'test_tag', snapshot => 2, time_retained => '1 d')")

Tests

API and Format

Documentation

addressed comments, thanks for review @wwj6591812
A little difference, keep the name 'replace_tag' not change. I think it's name is ok, and iceberg also uses 'replace tag' to update tag. what do you think?

addressed comments, thanks for review @wwj6591812 A little difference, keep the name 'replace_tag' not change. I think it's name is ok, and iceberg also uses 'replace tag' to update tag. what do you think?

ok


A11y_SQLAzureDataStudio_SQLServerBigDataCluster_ConfigurationProfile_Screenreader: Jaws doesn't announce, content of radiobutton

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yMAS;#A11yTCS;#SQL Azure Data Studio;#DesktopWeb;#Win32;#MAS1.3.1;#Benchmark;#A11y_SQLAzureDataStudioBenchmark;#A11ySev2;
Environment Details:
Version: 1.16.0-insider
Commit: 506c6a5
Date: 2020-02-17T05:43:18.399Z
VS Code: 1.42.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Additional Details:
MAS References: MAS1.3.1
JAWS Version: 2019.1912.1 ILM
Additional Details:
MAS reference: MAS1.3.1
Repro Steps:

Launch Azure Data Studio.
Select the Connections icon (if not already selected) from left bar.
Click on the ellipses '...' and select "New Deployment".
Select "SQL Server Big Data Cluster" card under deployment options.
Select the version & checkbox.
Navigate till Selet button & hit enter.
Launch JAWS screenereader
Navigate to any radiobutton and press down arrow key

Actual:
While JAWS is on and navigated to radiobutton and pressed down arrow key, screenreader doesn't announce content of radiobutton.
Issue doesn't repro with NVDA screenreader.
Expected:
While JAWS is on and navigated to radiobutton and pressed down arrow key, screenreader should announce content of radiobutton.
User Impact:
Screenreader users will face difficulty as they will not get the information present in radiobutton control.
Attachment link reference:
9341_A11y_SQLAzureDataStudio_SQLServerBigDataCluster_ConfigurationProfile_Screenreader.zip

@alanrenmsft Could you please the reopened the bug as it should be verified the Trusted Tested.
Please provide the latest environment details where we can verify this and take action accordingly.
GithubTags:#Regressed:06-02-23;

@alanrenmsft Tried to verify but not able to get "SQL Server Big Data Cluster" card under deployment options. Could you please look into this.
Env Details:
Version: 1.42.0-insider (system setup)
Commit: ac0dc4ee7627ba907c401c0c3d78746546b269b2
Date: 2023-02-06T06:50:44.371Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

@BhanuPrakashGit as I mentioned in my previous emails, this feature has been removed, you can skip the issues for big data cluster feature.

@alanrenmsft Thanks for the update.
GithubTags:#Closed;

GitHubTags:#SQLADS-Win32-Feb2020;


chore(Button): updating IconButton's variants' icon sizes

Overview
IconButtons use icons that currently size depending on the parent container using "calc(100% - 14)"
But for some reason this calculation seems to be done using the width/height of ::after which can be marginally larger (e.g. 40.8 when it should be exactly 40)

^ on the prod version of storybook, it comes out to 40 🤷
Regardless, the calculation of -14px should actually be -18px to enable a padding of 8px all around.
To make the sizing more explicit, concrete values were used:
normal: 24, <- from figma
small: 16, <- from figma
large: 40, <- assuming since currently a large IconButton is 56 and 56 - 16 = 40, the figma will need to be updated to reflect this size.
PR Checklist

[ ] Related to designs: https://www.figma.com/design/ReGfRNillGABAj5SlITalN/📐-Gamut?node-id=1106-90&m=dev
[ ] Related to JIRA ticket: https://codecademy.atlassian.net/browse/GM-702
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.
PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

📬Published Alpha Packages:@codecademy/gamut@55.22.4-alpha.163f33.0@codecademy/gamut-kit@0.6.416-alpha.163f33.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://666b16bc273aa9527803b3d5--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.22.5-alpha.f134e0.0@codecademy/gamut-kit@0.6.417-alpha.f134e0.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6675a2a6803efaa9e7dbf1b0--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.22.6-alpha.636d8b.0@codecademy/gamut-kit@0.6.418-alpha.636d8b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6675dfd6af420307ed07c73c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut@55.22.6-alpha.636d8b.0@codecademy/gamut-kit@0.6.418-alpha.636d8b.0<EMAIL_ADDRESS>
@dreamwasp ah wait -- I remember why I took out aria-hidden, Icon should come with aria-hidden true already, so I just removed it here because it wasn't needed.
I added it to IconButtonBase weirdly 🤔 (and it's breaking some tests lol)
gonna fix that now, but we can also disc on Monday. Thanks!

📬Published Alpha Packages:@codecademy/gamut@55.22.6-alpha.7a40b3.0@codecademy/gamut-kit@0.6.418-alpha.7a40b3.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6675ee49b8e00cf6bd9863e6--gamut-preview.netlify.appDeploy Logs

@dreamwasp ah wait -- I remember why I took out aria-hidden, Icon should come with aria-hidden true already, so I just removed it here because it wasn't needed.
I added it to IconButtonBase weirdly 🤔 (and it's breaking some tests lol)
gonna fix that now, but we can also disc on Monday. Thanks!

oh duh!!! you're totally right. this is perfect ✨


Add reason why validation can't be confirmed

Create hierarchical validation with 2 or more annotators
Finish annotations
Start validation, validate just one page
Try to finish validation (following popup appears)

exp.: error message appears, user get instructions to validate all pages
act.: nothing is happening when user clicks on the "confirm" button

Fixed the logic for validation: now the button finish validation is only available if all pages have been marked as valid or invalid, so the wronng modal won't appear

Fixed


Get docs version from project.version

Why are the changes needed?

Fix the docs version issue
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #1548 (dfee7b6) into master (609bb5a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1548      +/-   ##
============================================
- Coverage     59.29%   59.26%   -0.03%
  Complexity      172      172
============================================
  Files           241      241
  Lines         12224    12224
  Branches       1501     1501
============================================
- Hits           7248     7245       -3
- Misses         4364     4365       +1
- Partials        612      614       +2

Impacted Files
Coverage Δ

...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala
89.47% <0.00%> (-3.51%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
82.50% <0.00%> (-2.50%)
:arrow_down:

...ache/kyuubi/engine/spark/operation/GetTables.scala
97.36% <0.00%> (ø)

...che/kyuubi/engine/spark/operation/GetColumns.scala
98.52% <0.00%> (ø)

...che/kyuubi/engine/spark/operation/GetSchemas.scala
90.00% <0.00%> (ø)

...he/kyuubi/engine/spark/operation/GetCatalogs.scala
83.33% <0.00%> (ø)

...he/kyuubi/engine/spark/operation/GetTypeInfo.scala
98.68% <0.00%> (ø)

...e/kyuubi/engine/spark/operation/ExecuteScala.scala
88.00% <0.00%> (ø)

...e/kyuubi/engine/spark/operation/GetFunctions.scala
94.59% <0.00%> (ø)

.../kyuubi/engine/spark/operation/GetTableTypes.scala
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609bb5a...dfee7b6. Read the comment docs.

merging to master and branch-1.4, branch-1.3


osascript: can’t open default scripting component

Description
We are running macOS builds on macOS 11 machines.
From time to time creating disk images fails and it shows this error:
osascript: can’t open default scripting component
We are using osascript to generate DMG files.
After re-running jobs it usually works next time - so it's completely random behaviour
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[X] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Environment: macos-11
Version: 20210927.2
Is it regression?
No response
Expected behavior
osascript should be stable
Actual behavior
osascript is failing occasionally
Repro steps

Prepare a workflow using osascript
Run it multiple time as observe random failures

Hello, @grzegorzkrukowski
Could you please provide steps to reproduce the issue?

لينعل طبون مكوم

Hi I have a Mac OS can I help you today?

Hey - we have been trying to find a best way to reproduce this problem, but this week all builds are working just fine.
Last week it was completely randomly failing on different apple scripts.

@grzegorzkrukowski thank you for the information.
In order to investigate the issue further and figure out the reason of script failures, we need steps to reproduce the issue on our side.
Currently, I'm going to close the issue. In case of any questions, feel free to contact us.

Hey @Darleev @KVROHITH098
I managed to prepare a cut to minimum example which shows the problem.
Here is the failure:
https://github.com/raycast/github-oascript-bug/runs/3910385565?check_suite_focus=true#step:3:12
It basically failed after re-running all job 5 times - it's quite random.
But here you can see it's failing on /usr/bin/osascript being run.

@grzegorzkrukowski
Hi, while i was not able to reproduce the problem and get more tracing info of active script, can you please change your build to use dtruss with osascript in order to let us know that is going on on build fail.
Because of SIP limitation it is not possible to debug /usr/bin/osascript and you should create unsigned copy of it.
sudo cp /usr/bin/osascript /tmp
sudo codesign --remove-signature /tmp/osascript
sudo dtruss -a /tmp/osascript ...

The exact commit for your workflow:
https://github.com/akv-platform/github-oascript-bug/commit/da8742d015d20e3bc64142aba35a021dc797eef1

@grzegorzkrukowski I'm going to close the issue.
Please feel free to contact us if you have any concerns.
Thank you!

Hi,
I just thought I'd let you all know that I had this exact issue -
restarting / reinstalling macOS over the top didn't help whatsoever, I still encountered the:
"osascript: can't open default scripting component." error.
I found a little nugget of usefullness on another forum relating to this, that suggested an audio component file located within "/Library/Audio/Plug-Ins/Components" was to blame.
I removed all the components, and the osascript error disappeared immediately (no restart required).
I re-added the components one at a time, and found that one of my plugins (FabFilter Pro-C 2.component) was causing this issue all along.
Just thought I'd let you all know just in case anyone else has the same issue!
Cheers

Hi, I just thought I'd let you all know that I had this exact issue - restarting / reinstalling macOS over the top didn't help whatsoever, I still encountered the: "osascript: can't open default scripting component." error.
I found a little nugget of usefullness on another forum relating to this, that suggested an audio component file located within "/Library/Audio/Plug-Ins/Components" was to blame. I removed all the components, and the osascript error disappeared immediately (no restart required). I re-added the components one at a time, and found that one of my plugins (FabFilter Pro-C 2.component) was causing this issue all along.
Just thought I'd let you all know just in case anyone else has the same issue! Cheers

This worked for me. Moved all plugins from the components folder to the desktop and it was able to continue. Thanks!

I fixed this problem myself! i tried doing what "kalatix" said and it didnt work, but i kept looking at folders close to the library and audio plug ins.  Once I did that, it let me build and install open core to my hard drive, and now i dont need the flash drive to boot.
This is my first github post. am I a hacker now?

Hi, I just thought I'd let you all know that I had this exact issue - restarting / reinstalling macOS over the top didn't help whatsoever, I still encountered the: "osascript: can't open default scripting component." error.
I found a little nugget of usefullness on another forum relating to this, that suggested an audio component file located within "/Library/Audio/Plug-Ins/Components" was to blame. I removed all the components, and the osascript error disappeared immediately (no restart required). I re-added the components one at a time, and found that one of my plugins (FabFilter Pro-C 2.component) was causing this issue all along.
Just thought I'd let you all know just in case anyone else has the same issue! Cheers

I found a newly installed audio plugin component ChopSuey.component was causing the "osascript: can't open default scripting component." error. Thank you so much.

Oh my, thank you for this. Turns out I had a faulty audio plugin component as well that was causing this issue.


Update Deprecation warnings in the CI

updated node version 16 to 20 and all the deprecation warnings in the CI with latest versions.

Member

Thank you...


preprocessing methods

Hello,
What preprocessing methods are applied to data before the training phase? It would be nice to have a brief summary of all these steps in the doc.  By preprocessing, I mean: one-hot-encoding, normalization, imputation, etc.
Thank you,
Yassine

The docs contain such information.
Check the Preprocessing section in the User Guide and then the preprocessing sections of each datatype in the user Guide.
If you still have questions, please feel free to ask them here. Closing in the meantime.


Migrate MySQL virtual schema

Closes #1.

Nexted time let's try to do it like this: https://ariya.io/2014/07/extracting-parts-of-git-repository-and-keeping-the-history

Nexted time let's try to do it like this: https://ariya.io/2014/07/extracting-parts-of-git-repository-and-keeping-the-history

Nexted time let's try to do it like this: https://ariya.io/2014/07/extracting-parts-of-git-repository-and-keeping-the-history

sounds good! sure!

Nexted time let's try to do it like this: https://ariya.io/2014/07/extracting-parts-of-git-repository-and-keeping-the-history

sounds good! sure!


Feature request: fzf.vim like ordering for buffers

I recently changed from fzf.vim to fzf-lua, loving the plugin thank you.
One thing that trips me up often is the ordering of matches of buffers.
Say I opened up the following buffers in this order:

foo/a.html
foo/b.html
foo/c.html
foo/d.html

So the most recent buffer opened was d. If I FZF search for buffers and enter in the search term html, then the matches would be:

foo/c.html  - I.e. the best match
foo/b.html - Second best match
foo/a.html - third best match

It orders it according to the order of last accessed. I use it all the time when switching between files, it's like a reflex. Knowing the "best" match will be the most recent one, generally typing a phrase quickly and pressing enter before I even can read the results (the hand is quicker than the eye!). I am guessing fzf.vim uses the history (old_files) to sort the buffers matches.
I see there is :
      buffers = {
        prompt            = 'Buffers❯ ',
        file_icons        = true,         -- show file icons?
        color_icons       = true,         -- colorize file|git icons
        sort_lastused     = true,         -- sort buffers() by last used      <--------- This option
        actions = {
          -- actions inherit from 'actions.buffers' and merge
          -- by supplying a table of functions we're telling
          -- fzf-lua to not close the fzf window, this way we
          -- can resume the buffers picker on the same window
          -- eliminating an otherwise unaesthetic win "flash"
          ["ctrl-x"]      = { actions.buf_del, actions.resume },
        }
      },

I see the sort_lastused is set by default, but not working for me with my options set to:
    buffers = { prompt = 'Buffers❯ '},

Will investigate more

If I FZF search for buffers and enter in the search term html

Once you type something the initial ordering of the buffers doesn’t matter any longer, the ordering after typing is controlled by the fzf algorithm which you can tweak by adding --tiebreak to fzf_opts, have you tried that?

Will give it a try thanks, I never used to use that option on my old  setup, maybe FZF has tweaked their algorithm since a year or 2 ago.

Also, see a similar issue with oldfiles, setting tiebreak to index solved the issue: https://github.com/ibhagwan/fzf-lua/issues/592#issuecomment-1387609639

FYI https://github.com/ibhagwan/fzf-lua/commit/bcb5153f893829c78e59c1c788bb3f2b04dd46f2 sets the default tiebreak for both buffers and oldfiles to index.


BOS and EOS padding

This PR just adds the optional functionality to the tokenzier to pad EOS and BOS token IDs (important for some chat formats like llama2 and openassistant)

I'm curious, what does padding the token id's accomplish?

Padding with padding tokens allows you to run multiple sequences of different length in the same batch. "Padding" in this PR really more prepending and appending the BOS and EOS tokens, respectively. Maybe they arguments should be add_bos and add_eos to avoid this confusion?
Also, this is more of a workaround and I really would prefer to fully support encoding of control symbols, like in AutoTokenizer. I.e. you should just be able to add <s> and </s> at arbitrary places in the input string, as well as any other custom special tokens any given model requires. Ideally it would work when decoding as well.

Maybe the arguments should be called add_bos and add_eos to avoid this confusion?

Sure, will change!

Also, this is more of a workaround and I really would prefer to fully support encoding of control symbols, like in AutoTokenizer. I.e. you should just be able to add  and  at arbitrary places in the input string, as well as any other custom special tokens any given model requires. Ideally it would work when decoding as well.

I totally get that hence the question a couple of days prior to why sentencepiece, but llama2s repo is doing exactly this, appending eos and bos, tokenizing each 'role' prompt and concatenating all of those encoded IDs to a full prompt.
I wanted to implement exactly the same without messing with the tokenizer, so I believe that this change should also be merged in conjunction to tokenzier changes.
(and doesn't decoding output the eos and bos strings?)

I will later also commit a PR of the exact llama 2 chat completion implementation and I would like this tokenizer feature to be added for that, would that be ok with you?


Support unwinding after a panic

Fixes #658
This commit adds support for unwinding after a panic. It requires a
companion rustc PR to be merged, in order for the necessary hooks to
work properly.
Currently implemented:

Selecting between unwind/abort mode based on the rustc Session
Properly popping off stack frames, unwinding back the caller
Running 'unwind' blocks in Mir terminators

Not yet implemented:

'Abort' terminators

This PR was getting fairly large, so I decided to open it for review without
implementing 'Abort' terminator support. This could either be added on
to this PR, or merged separately.
I've a test to exercise several different aspects of unwind panicking. Ideally, we would run Miri against the libstd panic tests, but I haven't yet figured out how to do that.
This depends on https://github.com/rust-lang/rust/pull/60026

Please also add a test that check whether double panics cause an abort and don't confuse miri. Something like
struct Foo;
impl Drop for Foo {
    fn drop(&mut self) {
        panic!("second");
    }
}
fn main() {
    let foo = Foo;
    panic!("first");
}

@oli-obk: Double-panics are handled correctly, but end up causing an error due to uw::_Unwind_Backtrace being unhandled. This is due to the fact that when a double panic occurs, libstd unconditionally tries to print a backtrace.
Should we look into building libstd without the backtrace feature, or should we try to implement it (e.g adding a cfg(mir) into libstd's backtrace code?

Should we look into building libstd without the backtrace feature

That seems doable since we're building a libstd anyway. But you don't have to do that in this PR, adding the test so we see the failure is enough for me right now.

Running 'unwind' blocks in Mir terminators

Where is that happening? The cleanup field of the Call terminator still seems to be ignored, and that's where things should have to jump to during unwinding.

@RalfJung: 'unwind' processing is handled here

@RalfJung: I've updated this PR (and the corresponding rustc PR) to move more of the unwinding logic into rustc. Now, the implementation doesn't manually step through box_me_up - it's handled via the normal main loop.

Closing as the accompanying rustc PR got closed. @Aaron1011 if you want to pick this up again, just reopen!

cc @RalfJung @oli-obk Can this PR be re-opened?

Unresolved question: How do want to handle the abort intrinsic?
Currently, I throw a UB error. This doesn't seem quite right to me - while I think it's probably useful to have a stacktrace when the program aborts, it's not really undefined behavior. Is the a better category of error that we should use?

It's kind of an invalid program. I mean at runtime it's a "the OS killed this program due to an invalid instruction" kind of error

I don't see anything invalid about that. It's just a way of exiting the program -- the interpreter succeeded, just the program failed. So IMO raising InterpError::Exit would make most sense.

Note that Miri now fails when rust tries to print a panic backtrace, since it tries to get the current directory with isolation enabled.
Would it make sense to add a #[cfg(miri)] to the backtrace code?

Seems easier to adjust that code to handle current_dir returning Err?

@RalfJung: It does - but Miri errors due to isolation mode being enabled, I think we should be able to support panic backtraces without disabling isolation mode.

Oh I see. Probably Miir in isolation mode should return an error code from getcwd instead of raising an interpreter error. @christianpoveda do you think that is possible?

A lot of shims I did return an unsupported error if they are used with isolation enabled including this one.
Sent from ProtonMail mobile
-------- Original Message --------
On Oct 9, 2019, 16:57, Ralf Jung wrote:

Oh I see. Probably Miir in isolation mode should return an error code from getcwd instead of raising an interpreter error. @christianpoveda do you think that is possible?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

But to answer your question, yes it would be possible to set errno to EACCES (which seems to be a reasonable error in this case) when getcwd runs under isolation mode. I don't know about the other shims tho.

My concern is that this might subtly change the behavior of certain applications, making it very hard to determine why Miri is giving you weird output. I think the current behavior is better - we either correctly implement a foreign function, or exit the program with an explicit error.

I agree with @Aaron1011, I see no way of not panicking here other than having some sort of custom behaviour for getcwd with isolation enabled.

Given that the rustc code already supports the current directory being unavailable (it calls ok on the result), I think it would be simply to just a a #[cfg(miri)] cwd = None.

Personally I think returning an error is a great way to communicate to the application that it is running in a "sandbox" of sorts. But I won't fight for this; if you can get the relevant patch into libstd that seems fine for me as well.

@RalfJung: I've added a new miri_start_panic intrinsic, like you suggested. This required a few tweaks to libpanic_unwind, but ended up greatly simplifying the implementation in Miri.

I've added a new miri_start_panic intrinsic, like you suggested. This required a few tweaks to libpanic_unwind, but ended up greatly simplifying the implementation in Miri.

Great. :)

@RalfJung: I've addressed your latest comments.

I've addressed your latest comments.

Some older comments are still open, specifically

https://github.com/rust-lang/miri/pull/693/files#r336785268
https://github.com/rust-lang/miri/pull/693/files#r336785301
https://github.com/rust-lang/miri/pull/693/files#r336785439

@RalfJung: I've addressed the older comments.

@Aaron1011 awesome! As you can tell, we are entering the nitpicking phase. I am happy with the overall design. :)

:umbrella: The latest upstream changes (presumably #1049) made this pull request unmergeable. Please resolve the merge conflicts.

@Aaron1011 is this blocked on https://github.com/rust-lang/miri/issues/1057 or is there something that can be done in the mean time?

My guess is that it is not blocked (after all, we got Miri to work again with latest master). But what is a problem is the panic=abort situation. I'd be fine landing the rest of this though and opening an issue to track supporting panic=abort.

With your SEH fixes merged, I think this should be mergable.

All right, could you please rebase? I should have time to review this today or tomorrow.

The CI build is finally passing for this PR! :tada:

Could you add a #[should_panic] test to cargo-miri-test? That is one of the big use-cases for this enhancement after all. :)

@RalfJung: Done

You'll have to adjust the reference output as well (by hand, I am afraid).
You can run ./run-test.py locally to see if everything is right.

@bors try

:hourglass: Trying commit 660cd55cc74a6c391cf817d771181eeaa736967b with merge 65d2dc0aedca2ec26e2d1387b30d065e15fdfd9e...

:broken_heart: Test failed - status-appveyor

It looks like we don't have any dlsym-like handling for the Windows method GetProcAddress. This ia causing libstd to think that Windows doesn't have RWLock support, triggering a panic when we try to lock an RWLock during panicking.
I guess I need to implement GetProcAddress, at least partially. Ugh...

This is going to require the ability to read wide strings, which appears to be currently being worked on in https://github.com/rust-lang/rust/pull/66470.
@RalfJung: Is there any chance that we could just disable unwinding tests on  Windows for now? Getting this working is going to require https://github.com/rust-lang/rust/pull/66470 to be merged, after which we will need to implement GetModuleHandleW and GetProcAddress in a manner analogous to the current dlsym handling.

Is there any chance that we could just disable unwinding tests on Windows for now?

Seems fine to me, if you open an issue.
I also seem to recall that the reason RwLock uses GetProcAddress is to support Windows XP or so, but support for that was since dropped from Rust... so I think (but you might want to confirm that with some Rust team members) that we could patch RwLock on Windows to statically link against the platform methods, and not require GetProcAddress any more.

 Could you take a look whether the comments all still seem correct to you?
Then this is ready to land IMO, modulo my question about __rust_start_panic above.
@oli-obk any comments/concerns?

@RalfJung: This should now be ready to merge.

@RalfJung: I've fixed the two comments you mentioned.

@bors r+

:pushpin: Commit 2750f60d4f4c8090bd0d0230c074fc7d1e2b5a6e has been approved by oli-obk

:hourglass: Testing commit 2750f60d4f4c8090bd0d0230c074fc7d1e2b5a6e with merge e64caeb30b267e4721ca14504c86987c2fa9cb42...

:broken_heart: Test failed - status-appveyor

@oli-obk: I had forgotten to disable one of the panic tests on Windows. Can you re-try the build?

@bors r+

:pushpin: Commit 6fe89e45f44df216911de48958aed38965b0de1c has been approved by oli-obk

:hourglass: Testing commit 6fe89e45f44df216911de48958aed38965b0de1c with merge e588d9535c014d078ccf785c18618cc765a93afe...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing e588d9535c014d078ccf785c18618cc765a93afe to master...

Finally, after around half a year, this landed. Thanks @Aaron1011, this is awesome!


Draggable Markers reset to 0 degrees on drag.

As soon as dragging begins the icon is rendered without the set rotationAngle.
Edit: I quickly created this jsfiddle to demonstrate

It looks like this is due to the MarkerDrag._onDrag function setting the marker._latlng property directly.
	_onDrag: function (e) {
		var marker = this._marker,
		    shadow = marker._shadow,
		    iconPos = L.DomUtil.getPosition(marker._icon),
		    latlng = marker._map.layerPointToLatLng(iconPos);

		// update shadow position
		if (shadow) {
			L.DomUtil.setPosition(shadow, iconPos);
		}

		marker._latlng = latlng;
		e.latlng = latlng;
		e.oldLatLng = this._oldLatLng;

		// @event drag: Event
		// Fired repeatedly while the user drags the marker.
		marker
		    .fire('move', e)
		    .fire('drag', e);
	},

+1; I am also observing this in my code.

I'm closing the bug, as I've merged the fix and published the new version. Thanks a lot again @Andrew-SK!


test adding a second unit of slurmd

As a start to our charm testing we check that adding a second
unit of slurmd succeeds.

I think this can be closed in favor of #59. What do you think, @jamesbeedy ?


Add news crawler

Implemented news crawler. It downloads html page content which can be used to extract image and image captions.
To run it locally:
cd news_crawler/crawler
npm install
npm run build

# You need to provide it a crawl-input.json file that contains crawl config,
# target domains, starting urls...
npm run start -- --crawl-config ./crawl-input.json --dir-path ./data

Could you give more details on how the crawl input json file should be formatted (or even better, include an example json that is already formatted)?

Here's a sample json input. Save it as crawl-input.json.
targetWebsites is a dictionary of target domains as the key and value is the target paths to crawl for each domain. For example, TechCrunch articles has path like '/2023/...' but non-article pages on TechCrunch has different path.
startUrls is a list of links to start with (e.g. TechCrunch homepage to get scrape article links).
{
    "crawlName": "local-crawl",
    "crawlId": "test1",
    "targetWebsites": {
        "techcrunch.com": [
            "/20"
        ]
    },
    "startUrls": [
        "https://techcrunch.com/"
    ]
}

Looks good, I was able to get it running now. The comments in the code were helpful. Just need to create a README file with the two comments that you posted in the PR (the description of how to run it and the sample json), then should be good for merging.

@ArjunKrishna3367 Done


Serde should be rewritten for structured error handling

pub trait Deserialize<'de>: Sized {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: Deserializer<'de>;
}

should be rewritten as
pub trait Deserialize<'de, E>: Sized {
    fn deserialize<D>(deserializer: D) -> Result<Self, E>
    where
        D: Deserializer<'de>,
        E: From<D::Error>;
}

This will allow to use custom errors, like BlockchainError to differentiate high-level errors from parsing errors.
The current workaround is very ugly: to parse error messages text.

Someone else should feel free to pursue this in a different crate.

Additional note for "someone else":
Serialize also has a wrong type of serializer argument:
pub trait Serialize {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer;
}

It should be (regarding this argument, not regarding error handling, the change that I described above):
pub trait Serialize {
    fn serialize<S>(&self, serializer: &mut S) -> Result<S::Ok, S::Error>
    where
        S: Serializer;
}

to support
impl<'a, T> Serialize for HTML {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error> where S: Serializer {
        header.serialize(&mut serializer);
        body.serialize(&mut serializer);
        footer.serialize(&mut serializer);
    }
}


Update Repo

Goal
The goal of this PR is to update the GitHub org of the repository
Discussion

Updated LibertyDSNP -> frequency-chain
Move the CI image build to branch ci/ci-base-image
Updated Copyright names

Besides org name changes and linting, I see some removed logic related to the ci-base-image. Could you comment on the purpose of that in relation to the org move?

@JoeCap08055 It was noted in the PR where it went, but the reason why is:

The container registry images didn't move over, so we had to publish the images before being able to run any PRs
We had wanted to get out of the double PR requirement and disconnect the image publishing from the normal CI flow.


Update Float.java

additional fix 7010

Can one of the admins verify this patch? (see README)

Thanks


Default 'nothing allowed' state for ServiceComputePrivacy

At the moment, whenever a new compute data set is published all published algorithms are allowed to run on it by default, which seems unintended. This is because in the background there are some unexpected interpretations of non-existing or empty array value for publisherTrustedAlgorithms.
To make this more clear and explicit, we could have something like allowAllAlgorithms within ServiceComputePrivacy, set to false by default upon data set publish, as suggested in https://github.com/oceanprotocol/market/pull/417#issuecomment-803953523

As far as i know this was intended, empty publisherTrustedAlgorithms means all algorithms are allowed. But now that i think about it this is conceptually wrong. Everything should not be allowed until the publisher expresses its wishes


The List value type is rendered weird on the language ref HTML page

The List value type is rendered incorrectly on the language reference page because it has an anchor element with id="toc-list". The incorrect rendering is because website/style.css defines a selector with that name:
#toc-list {
    margin-left: -0.6em;
}

Notice the unexpected outdenting:

The simplest fix is to change ## List to ## Lists in website/ref/language.md. However, that is inconsistent with the naming of the other value types which use the singular form. TBD is how best to fix this stylistic issue.

Just changed the pandoc template to avoid the conflict.


Add a Code Of Conduct

Add a file to the root of this repo called CODE_OF_CONDUCT.md, with the content from the same file in our docs repo.

I'll pick this up!

Nice @DanielCBrooks

Pull request is here:
https://github.com/sendgrid/nodemailer-sendgrid-transport/pull/35


Failed download still shows "finished download" notification

When downloading something where not all blobs are available, eventually the daemon gives up and stops downloading, and gives the message in the logs about stopping an incomplete download. This triggers the "finished download" notification in my OS, but it really shouldn't.

This should not happen anymore


Add a SUPPORT.md file to our main repos

See https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-support-resources-to-your-project
Related to #280
@CaroFG happy to discuss this at our next meeting

https://github.com/meilisearch/.github/pull/5

Closed by https://github.com/meilisearch/.github/pull/5


Remove sslcertificates source

This PR aims to fix https://github.com/subfinder/subfinder/issues/106

Ok, I think I got everything.
$ grep -r --include "*.go" -i sslcert .


Detect Thrift-generated PHP class files.

The top of a Thrift-generated class file starts with:
<?php
 namespace Foo\Bar\Thrift\MyClass;
 /**
  * Autogenerated by Thrift Compiler (0.9.3)

Whoops, forgot to add appropriate extensions. New PR coming soon.

For next time: you can push new commits on the same branch and they'll be added to the pull request ;)


Added unit tests for read and scientificP

These tests correspond to documented examples. See #51.

Thanks!


Dev remove lakefim

This feature branch includes modifications to identify stream segments that overlap NWM lake areas. Our current HAND-FIM methodology and topography data can not adequately capture lake inundation features (i.e. we don’t have lake bathy), so this modification removes inundation output for all catchments that overlap with lake areas. FIM 2.3.3 removed most lake areas from the output inundation raster; therefore this change is also needed to ensure a fair comparison when examining the FIM2 vs. FIM3  #metrics. Resolve issue #106

Changes
snap_and_clip_to_nhd.py

Added code to loop through the NWM lakes multipolygon and remove any holes/islands polygon features (only keeping exterior polygons) and then overwrite the nwm_lakes_proj_subset.gpkg file for later use

split_flows.py

Added code to create a new lakes_buffer feature (20-meter buffer)
The split function is still using the original (non-buffered) polygon to define the split points at the polygon boundaries
The new buffered lake polygon is used to perform the geopandas spatial join → any reach segment fully contained (“within” function) in the lakes polygon is assigned a “LakeID” attribute value from the lakes_buffer feature
All segments that are not contained by the lake polygon are given a default “LakeID” value of -999

inundation.py

Added line of code to filter the hydroTable for locations not associated with NWM lake areas → filter for LakeID = -999 (not a lake)

Note that these changes appear to improve the identification of lake-associated catchments, but there are instances where catchments are not identified as lake catchments. The example below illustrates a case where the stream reach line meanders outside of the buffered lake polygon boundary. Recall that in order for a reach to be assigned a “LakeID” it must fall entirely within the lake polygon. Future testing and enhancements may be able to improve upon these methods (e.g. increased lake polygon buffer for spatial join, test additional shapely spatial join techniques).

Testing

Check out the dev-remove-lakefim branch and run the following:

fim_run.sh
fim_run.sh -u /data/temp/param_adjusted_files/dev_fim_ble_forbrad.lst -c foss_fim/config/params_template.env -n dev_remove_lakefim_FR_review -j 12
ble_autoeval.sh
/foss_fim/tests/ble_autoeval.sh -f dev_remove_lakefim_FR_review -b /data/temp/param_adjusted_files/dev_fim_ble_forbrad.lst -d dev_c12582e_fr -v "DEV" -s /data/temp/pull_requests/dev_remove_lakefim_FR_review

Compare aggregate CSIs to the following scores:

FR 100yr: 0.5568
FR 500yr: 0.5827
MS 100yr: 0.3845
MS 500yr: 0.4056

Make sure that the final inundation raster is excluding most lake areas & not creating new artifacts:
Use inundation_extent.tif (example hucs with lakes: 11130304)

Evaluation Metrics
Note that the metrics show a consistent regression due to the fact that we are removing inundated lake areas from the FIM output. These areas typically represented "True Positive" instances in the previous evaluation metrics.
*To view all statistics --> refer to google drive links
Full Res 100-yr CSI results (%change is comparing current dev to new feature branch)

total_area
fim_1_0_0
fim_2_3_3
dev_c12582e_fr
new_feature
eval
site
% change

CSI
0.596
0.632
0.621
0.621
100yr
11090202
-0.06%

CSI
0.464
0.479
0.475
0.470
100yr
11090203
-0.98%

CSI
0.553
0.536
0.569
0.532
100yr
11090204
-6.37%

CSI
0.561
0.583
0.584
0.573
100yr
11100303
-2.01%

CSI
0.499
0.585
0.598
0.594
100yr
11130302
-0.71%

CSI
0.473
0.555
0.567
0.563
100yr
11130303
-0.63%

CSI
0.548
0.493
0.583
0.509
100yr
11130304
-12.63%

CSI
0.535
0.587
0.612
0.596
100yr
11130301
-2.52%

CSI
0.575
0.588
0.597
0.588
100yr
12020001
-1.58%

CSI
0.505
0.534
0.510
0.508
100yr
12020002
-0.32%

CSI
0.572
0.542
0.551
0.546
100yr
12020003
-0.98%

CSI
0.632
0.674
0.657
0.651
100yr
12020004
-0.83%

CSI
0.496
0.584
0.584
0.571
100yr
12020005
-2.23%

CSI
0.505
0.544
0.536
0.536
100yr
12020006
0.00%

CSI
0.418
0.398
0.395
0.395
100yr
12020007
0.00%

CSI
0.546
0.521
0.545
0.521
100yr
12030104
-4.53%

CSI
0.518
0.547
0.561
0.551
100yr
12030107
-1.93%

CSI
0.561
0.527
0.518
0.514
100yr
12030108
-0.77%

CSI
0.484
0.514
0.504
0.499
100yr
12030109
-0.92%

CSI
0.528
0.578
0.613
0.568
100yr
12040101
-7.41%

CSI
0.494
0.578
0.563
0.555
100yr
12040103
-1.39%

CSI
0.493
0.488
0.494
0.476
100yr
12060202
-3.77%

CSI
0.529
0.595
0.577
0.577
100yr
12090301
-0.07%

CSI
0.571
0.574
0.577
0.567
100yr
12100201
-1.68%

CSI
0.608
0.653
0.641
0.636
100yr
12100202
-0.72%

CSI
0.575
0.599
0.599
0.599
100yr
12100203
0.00%

CSI
0.361
0.413
0.380
0.380
100yr
13020101
0.00%

CSI
0.351
0.359
0.348
0.339
100yr
13020102
-2.58%

CSI

0.625
0.625
100yr
11010004
0.00%

CSI

0.787
0.787
100yr
11010009
-0.02%

CSI

0.538
0.533
100yr
11010014
-0.99%

CSI

0.575
0.554
100yr
11110202
-3.76%

CSI

0.583
0.582
100yr
11110205
-0.19%

CSI

0.630
0.613
100yr
11050003
-2.81%

CSI

0.512
0.510
100yr
11120303
-0.34%

CSI

0.498
0.496
100yr
11130202
-0.37%

CSI

0.506
0.506
100yr
11130203
-0.03%

CSI

0.566
0.566
100yr
11130208
-0.03%

CSI

0.635
0.635
100yr
11140102
0.00%

CSI

0.565
0.564
100yr
11140103
-0.25%

CSI

0.683
0.683
100yr
11140104
0.00%

CSI

0.621
0.595
100yr
11110104
-4.15%

CSI

0.538
0.522
100yr
11140105
-2.93%

CSI

0.633
0.513
100yr
11070103
-19.02%

CSI

0.534
0.508
100yr
8040101
-4.87%

CSI

0.645
0.644
100yr
8040203
-0.25%

CSI

0.400
0.395
100yr
12060102
-1.34%

CSI

0.558
0.558
100yr
8070201
0.00%

Mainstem 100-yr CSI results (%change is comparing current dev to new feature branch)

total_area
fim_1_0_0
fim_2_3_3
dev_c12582e_fr
new_feature
eval
site
% change

CSI
0.596
0.632
0.552
0.552
100yr
11090202
0.00%

CSI
0.464
0.479
0.350
0.350
100yr
11090203
0.00%

CSI
0.553
0.536
0.489
0.416
100yr
11090204
-14.93%

CSI
0.561
0.583
0.478
0.424
100yr
11100303
-11.19%

CSI
0.499
0.585
0.469
0.469
100yr
11130302
0.00%

CSI
0.473
0.555
0.362
0.362
100yr
11130303
0.00%

CSI
0.548
0.493
0.433
0.362
100yr
11130304
-16.29%

CSI
0.535
0.587
0.288
0.254
100yr
11130301
-11.91%

CSI
0.575
0.588
0.296
0.283
100yr
12020001
-4.34%

CSI
0.505
0.534
0.299
0.299
100yr
12020002
0.00%

CSI
0.572
0.542
0.361
0.358
100yr
12020003
-0.88%

CSI
0.632
0.674
0.451
0.446
100yr
12020004
-1.04%

CSI
0.496
0.584
0.219
0.175
100yr
12020005
-20.09%

CSI
0.505
0.544
0.323
0.323
100yr
12020006
0.00%

CSI
0.418
0.398
0.233
0.233
100yr
12020007
0.00%

CSI
0.546
0.521
0.346
0.307
100yr
12030104
-11.04%

CSI
0.518
0.547
0.289
0.261
100yr
12030107
-9.89%

CSI
0.561
0.527
0.275
0.271
100yr
12030108
-1.35%

CSI
0.484
0.514
0.214
0.209
100yr
12030109
-2.30%

CSI
0.528
0.578
0.529
0.430
100yr
12040101
-18.71%

CSI
0.494
0.578
0.363
0.343
100yr
12040103
-5.42%

CSI
0.493
0.488
0.339
0.306
100yr
12060202
-9.68%

CSI
0.529
0.595
0.396
0.396
100yr
12090301
0.00%

CSI
0.571
0.574
0.414
0.404
100yr
12100201
-2.56%

CSI
0.608
0.653
0.490
0.482
100yr
12100202
-1.58%

CSI
0.575
0.599
0.460
0.460
100yr
12100203
0.00%

CSI
0.351
0.359
0.279
0.255
100yr
13020102
-8.63%

CSI

0.588
0.588
100yr
11010004
0.00%

CSI

0.557
0.557
100yr
11010009
0.00%

CSI

0.251
0.251
100yr
11010014
0.00%

CSI

0.531
0.444
100yr
11110202
-16.37%

CSI

0.438
0.405
100yr
11050003
-7.37%

CSI

0.366
0.366
100yr
11120303
0.00%

CSI

0.370
0.370
100yr
11130202
0.00%

CSI

0.462
0.462
100yr
11130203
0.00%

CSI

0.311
0.311
100yr
11130208
0.00%

CSI

0.497
0.497
100yr
11140102
0.00%

CSI

0.533
0.533
100yr
11140103
0.00%

CSI

0.326
0.326
100yr
11140104
0.00%

CSI

0.492
0.464
100yr
11110104
-5.74%

CSI

0.358
0.304
100yr
11140105
-15.07%

CSI

0.532
0.345
100yr
11070103
-35.10%

CSI

0.275
0.265
100yr
12060102
-3.72%

CSI
0.468
0.519
0.215
0.215
100yr
12110110
0.00%

Future commit message:
Modifications to identify stream segments that overlap NWM lake areas

Fills the NWM lake polygon to remove holes/islands
Using a 20-meter buffer on the lake polygon to perform spatial join
Lake associated catchments assigned a LakeID in the hydrotable
Inundation.py now filters LakeID catchments in the final inundation output

This addresses Github issue #106

I'm adding a note to create a task that moves the lake buffer argument from split_flows.py to params_template.env so it can be adusted.


Add Zelda Oracle of Seasons and Oracle of Ages - US

The built in save/load state on the Everdrive GB X7 doesn't work on these so it would be a good addition.
edit:
specifically the US/Aus versions:
c4639cc61c049e5a085526bb6cac03bb  Legend of Zelda, The - Oracle of Ages (USA, Australia).gbc
f2dc6c4e093e4f8c6cbea80e8dbd62cb  Legend of Zelda, The - Oracle of Seasons (USA, Australia).gbc

These already exist in the cgb subdirectory:  https://github.com/mattcurrie/gb-save-states/tree/master/patches/cgb
Also the built in saves work on my X7 no problem, maybe check if your roms are corrupt somehow.

I think those are the EU versions?
The roms check out sha1sum-wise so no idea...

The description is truncated and talks about several different files, the actual files for the US versions are there tho:
https://github.com/mattcurrie/gb-save-states/blob/master/patches/cgb/Legend of Zelda%2C The - Oracle of Ages (U) [C][!].gbc.bsdiff
https://github.com/mattcurrie/gb-save-states/blob/master/patches/cgb/Legend of Zelda%2C The - Oracle of Seasons (U) [C][!].gbc.bsdiff
Maybe try asking at the Everdrive board? Seems there have been some issues with the more recent hardware revisions:
https://krikzz.com/forum/index.php?board=17.0

Thanks @Too-Ticki, yes, they're the correct patches.
I noticed the md5 checksums were missing from the checksums directory so I've added those.


twitch-proxy-m3u8 breaks streamlink config parsing because of number

Adding twitch-proxy-m3u8 to the streamlink config ($XDG_CONFIG_HOME/.config/streamlink/config) seems to prepend 3u8= to the beginning of the URL. Maybe in the future change the flag to something without a number such as --twitch-proxy-playlist.

what does adding the proxy do?


Adapter crash since 3.9.x with TypeError: Cannot read properties of undefined (reading 'split')

Describe the bug
Since update to version 3.9.x of ioBroker.hue, the adapter is constantly crashing with the following error log message until the ioBroker disables the adapter:
2023-06-14 09:11:46.803  - error: hue.0 (2186349) TypeError: Cannot read properties of undefined (reading 'split')
    at Hue.handleUpdate (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1100:42)
    at HuePushClient.<anonymous> (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1083:30)
    at HuePushClient.emit (node:events:513:28)
    at HuePushClient.emit (node:domain:489:12)
    at _emit (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:287:17)
    at parseEventStreamLine (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:302:9)
    at IncomingMessage.<anonymous> (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:259:11)
    at IncomingMessage.emit (node:events:513:28)
    at IncomingMessage.emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:324:12)

To Reproduce
Steps to reproduce the behavior:

Update to ioBroker.hue 3.9.x
Wait until adapter crashes
See ioBroker.admin notifications that the ioBroker.hue adapter constantly crashes and was disabled.
See error log

Expected behavior
The adapter should work as expected and like 3.8.0
Screenshots & Logfiles
See here for the complete log right from upgrading to 3.9.2 until the hue adapter is started and then crashes right away with TypeError: Cannot read properties of undefined (reading 'split'):
2023-06-14 09:11:42.324  - info: hue.0 (2186349) starting. Version 3.9.2 in /opt/iobroker/node_modules/iobroker.hue, node: v18.16.0, js-controller: 4.0.24
2023-06-14 09:11:43.013  - info: hue.0 (2186349) Push connection established
2023-06-14 09:11:43.458  - info: hue.0 (2186349) skip switch: Daylight.configured
2023-06-14 09:11:43.458  - info: hue.0 (2186349) skip switch: Daylight.sunriseoffset
2023-06-14 09:11:43.459  - info: hue.0 (2186349) skip switch: Daylight.sunsetoffset
2023-06-14 09:11:43.463  - info: hue.0 (2186349) skip switch: Dimmer Switch 8 SceneCycle.status
2023-06-14 09:11:43.465  - info: hue.0 (2186349) skip switch: cycling.status
2023-06-14 09:11:43.467  - info: hue.0 (2186349) skip switch: cycleState.status
2023-06-14 09:11:43.468  - warn: hue.0 (2186349) channel "cycling" already exists, using "cycling_CLIPGenericStatus" for sensor 94
2023-06-14 09:11:43.468  - info: hue.0 (2186349) skip switch: cycling CLIPGenericStatus.status
2023-06-14 09:11:43.469  - warn: hue.0 (2186349) channel "cycleState" already exists, using "cycleState_CLIPGenericStatus" for sensor 95
2023-06-14 09:11:43.470  - info: hue.0 (2186349) skip switch: cycleState CLIPGenericStatus.status
2023-06-14 09:11:43.472  - info: hue.0 (2186349) skip switch: Start/stop.status
2023-06-14 09:11:43.474  - warn: hue.0 (2186349) channel "cycling" already exists, using "cycling_CLIPGenericStatus" for sensor 100
2023-06-14 09:11:43.474  - info: hue.0 (2186349) skip switch: cycling CLIPGenericStatus.status
2023-06-14 09:11:43.476  - warn: hue.0 (2186349) channel "cycleState" already exists, using "cycleState_CLIPGenericStatus" for sensor 101
2023-06-14 09:11:43.476  - info: hue.0 (2186349) skip switch: cycleState CLIPGenericStatus.status
2023-06-14 09:11:43.477  - info: hue.0 (2186349) created/updated 13 sensor channels
2023-06-14 09:11:46.304  - info: hue.0 (2186349) created/updated 37 light channels
2023-06-14 09:11:46.324  - warn: hue.0 (2186349) channel "Keller" already exists, using "Keller_Room" for group 4
2023-06-14 09:11:46.373  - info: hue.0 (2186349) created/updated 23 groups channels
2023-06-14 09:11:46.392  - info: hue.0 (2186349) created/updated 178 scenes
2023-06-14 09:11:46.392  - info: hue.0 (2186349) creating/updating bridge device
2023-06-14 09:11:46.718  - error: hue.0 (2186349) Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch().
2023-06-14 09:11:46.719  - error: hue.0 (2186349) unhandled promise rejection: Cannot read properties of undefined (reading 'split')
2023-06-14 09:11:46.803  - error: hue.0 (2186349) TypeError: Cannot read properties of undefined (reading 'split')
    at Hue.handleUpdate (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1100:42)
    at HuePushClient.<anonymous> (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1083:30)
    at HuePushClient.emit (node:events:513:28)
    at HuePushClient.emit (node:domain:489:12)
    at _emit (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:287:17)
    at parseEventStreamLine (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:302:9)
    at IncomingMessage.<anonymous> (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:259:11)
    at IncomingMessage.emit (node:events:513:28)
    at IncomingMessage.emit (node:domain:489:12)
    at addChunk (node:internal/streams/readable:324:12)
2023-06-14 09:11:46.803  - error: hue.0 (2186349) Cannot read properties of undefined (reading 'split')
2023-06-14 09:11:46.828  - info: hue.0 (2186349) cleaned everything up...
2023-06-14 09:11:46.828  - info: hue.0 (2186349) terminating
2023-06-14 09:11:46.828  - warn: hue.0 (2186349) Terminated (UNCAUGHT_EXCEPTION): Without reason
2023-06-14 09:11:47.333  - error: hue.0 (2186349) Could not sync object hue.0.Toilette_(OG).colormode: DB closed
2023-06-14 09:11:47.334  - error: hue.0 (2186349) Could not sync object hue.0.Toilette_(OG).mode: DB closed
2023-06-14 09:11:47.475  - error: host.iobroker Caught by controller[0]: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
2023-06-14 09:11:47.476  - error: host.iobroker Caught by controller[0]: TypeError: Cannot read properties of undefined (reading 'split')
2023-06-14 09:11:47.476  - error: host.iobroker Caught by controller[0]:     at Hue.handleUpdate (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1100:42)
2023-06-14 09:11:47.477  - error: host.iobroker Caught by controller[0]:     at HuePushClient.<anonymous> (/opt/iobroker/node_modules/iobroker.hue/src/main.ts:1083:30)
2023-06-14 09:11:47.477  - error: host.iobroker Caught by controller[0]:     at HuePushClient.emit (node:events:513:28)
2023-06-14 09:11:47.477  - error: host.iobroker Caught by controller[0]:     at HuePushClient.emit (node:domain:489:12)
2023-06-14 09:11:47.478  - error: host.iobroker Caught by controller[0]:     at _emit (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:287:17)
2023-06-14 09:11:47.478  - error: host.iobroker Caught by controller[0]:     at parseEventStreamLine (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:302:9)
2023-06-14 09:11:47.480  - error: host.iobroker Caught by controller[0]:     at IncomingMessage.<anonymous> (/opt/iobroker/node_modules/eventsource/lib/eventsource.js:259:11)
2023-06-14 09:11:47.480  - error: host.iobroker Caught by controller[0]:     at IncomingMessage.emit (node:events:513:28)
2023-06-14 09:11:47.480  - error: host.iobroker Caught by controller[0]:     at IncomingMessage.emit (node:domain:489:12)
2023-06-14 09:11:47.480  - error: host.iobroker Caught by controller[0]:     at addChunk (node:internal/streams/readable:324:12)
2023-06-14 09:11:47.480  - error: host.iobroker instance system.adapter.hue.0 terminated with code 6 (UNCAUGHT_EXCEPTION)
2023-06-14 09:11:47.481  - info: host.iobroker Restart adapter system.adapter.hue.0 because enabled
2023-06-14 09:11:56.697  - warn: hm-rega.0 (1141) Script "!# programs.fn 1.3 !# Dieses Script gibt eine Liste der Programme als JSON Strin" ignored, because still pending.
2023-06-14 09:11:59.829  - info: host.iobroker "system.adapter.hue.0" disabled
2023-06-14 09:12:18.973  - error: hue.0 (2186389) adapter disabled
2023-06-14 09:12:18.979  - warn: hue.0 (2186389) Terminated (NO_ADAPTER_CONFIG_FOUND): Without reason
2023-06-14 09:12:19.166  - info: nut.0 (1247) State value to set for "nut.0.battery.charge" has to be type "string" but received type "number"
2023-06-14 09:12:19.636  - error: host.iobroker instance system.adapter.hue.0 terminated with code 3 (NO_ADAPTER_CONFIG_FOUND)
2023-06-14 09:12:19.637  - info: host.iobroker Do not restart adapter system.adapter.hue.0 because disabled or deleted

Versions:

Adapter version: 3.9.2
JS-Controller version: 4.0.24
Node version: 18.16.0
Operating system: Ubuntu 22.04 LTS
Bridge model: Philips Hue Bridge

Additional context
Downgrading to the last 3.8.x version (3.8.0) immediately solves the issue.

Thanks for reporting, it seems the property which we assumed mandatory is optional, I will add a guard.


Setup empty labels in controller

This labels are important for service auto discovery on kube-prometheus. I'm following the exactly same pattern on kops.

Current coverage is 68.87% (diff: 100%)

Merging #221 into master will not change coverage

@@             master       #221   diff @@
==========================================
  Files             4          4
  Lines          1134       1134
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            781        781
  Misses          263        263
  Partials         90         90

Powered by Codecov. Last update 890315b...951a587

@gianrubio LGTM 👍  Thanks as always!


[BUG][Hybrid Engine] Hybrid Engine Raise "CUBLAS_STATUS_EXECUTION_FAILED " for opt-350m

Describe the bug
When hybrid engine is turned on, running facebook/opt-350m will raise error.
To Reproduce
wget https://gist.githubusercontent.com/sxjscience/2a2fb9955aa089859f36f20e9861665f/raw/8596e69cabd2305787f13d0ccf16f01e10ce5e4d/opt_350m_bug_reproduce.py -O opt_350m_bug_reproduce.py

# Following gives error
CUDA_LAUNCH_BLOCKING=1 deepspeed --num_gpus 1 --master_port 29501 opt_350m_bug_reproduce.py

# No error
CUDA_LAUNCH_BLOCKING=1 deepspeed --num_gpus 1 --master_port 29501 opt_350m_bug_reproduce.py --disable_hybrid_engine

# No error
CUDA_LAUNCH_BLOCKING=1 deepspeed --num_gpus 1 --master_port 29501 opt_350m_bug_reproduce.py --model_name facebook/opt-1.3b

Error message:
    generate_ret_vals = self._generate(*inputs, **kwargs)
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/transformers/generation/utils.py", line 1515, in generate
    return self.greedy_search(
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/transformers/generation/utils.py", line 2332, in greedy_search
    outputs = self(
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/transformers/models/opt/modeling_opt.py", line 937, in forward
    outputs = self.model.decoder(
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/transformers/models/opt/modeling_opt.py", line 724, in forward
    hidden_states = self.project_out(hidden_states)
  File "/home/xxx/anaconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/xxx/Documents/xxx/DeepSpeed/deepspeed/module_inject/layers.py", line 50, in forward
    output = torch.matmul(input, self.weight.transpose(-1, -2))
RuntimeError: CUDA error: CUBLAS_STATUS_EXECUTION_FAILED when calling `cublasGemmEx( handle, opa, opb, m, n, k, &falpha, a, CUDA_R_16F, lda, b, CUDA_R_16F, ldb, &fbeta, c, CUDA_R_16F, ldc, CUDA_R_32F, CUBLAS_GEMM_DFALT_TENSOR_OP)`

Expected behavior
For all the other combinations "no-hybrid-engine + opt-350m", "hybrid-engine + opt-1.3b", it will correctly generate the outputs
Building extension module utils...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
ninja: no work to do.
Loading extension module utils...
Time to load utils op: 0.04421091079711914 seconds
["DeepSpeed is a great company. I've been using them for a while now.\nI"]
[2023-05-16 14:41:29,788] [INFO] [launch.py:346:main] Process 178639 exits successfully.

ds_report output
Please run ds_report to give us details about your setup.
Setting ds_accelerator to cuda (auto detect)
Setting ds_accelerator to cuda (auto detect)
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires a torch version >= 1.5 and < 2.0 but detected 2.0
 [WARNING]  using untested triton version (2.0.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/home/xxx/anaconda3/lib/python3.10/site-packages/torch']
torch version .................... 2.0.0+cu118
deepspeed install path ........... ['.../DeepSpeed/deepspeed']
deepspeed info ................... 0.9.3+c8d3f5eb, c8d3f5eb, master
torch cuda version ............... 11.8
torch hip version ................ None
nvcc version ..................... 11.8
deepspeed wheel compiled w. ...... torch 2.0, cuda 11.8

Screenshots
If applicable, add screenshots to help explain your problem.
System info (please complete the following information):

OS: Ubuntu 22.04
GPU count and types 2x3090
(if applicable) what DeepSpeed-MII version are you using
(if applicable) Hugging Face Transformers/Accelerate/etc. versions
Python version: 3.10
Any other relevant info about your setup

Docker context
Are you using a specific docker image that you can share?
Additional context
Add any other context about the problem here.

After some investigation, I noticed that it may be related to misaligned CUDA address (may be due to workspace + offset calls?). If I force the token length to be a multiplication of 32, the error disappeared. If we revise the code https://gist.github.com/sxjscience/2a2fb9955aa089859f36f20e9861665f as follows, there will be no error
# Ensure padding sequence length to multiplication of 32
tokens = tokenizer.batch_encode_plus(prompt, return_tensors="pt", padding="max_length", max_length=32)

Original was
tokens = tokenizer.batch_encode_plus(prompt, return_tensors="pt", padding=True)


AGGREGATE filter not respecting codec

Recently, Redisearch added contains filters on aggregate queries, e.g.:
FT.AGGREGATE idx * FILTER "contains(@name, 'åæø')"
However, when using aggregate queries with lettusearch, it seems that the StringCodec is not respected unlike when using a select string.
More specifically, the filter string will be added with RediSearchCommandArgs::add, whereas the values of select strings are added with RediSearchCommandArgs::addValue. The former does not seem to respect the StringCodec used. As such, the query I gave above is not possible with lettusearch as far as I can tell since UTF-8 is used.

Fixed in lettucemod project


Changing target address after a project is created doesn't work

Reported by miketay on IRC. This should be allowed if there are no pledges.

Also related, when user clicks on "Create new project", an address is automatically generated.  If the user edits that address, but it's not a valid Bitcoin address, it doesn't warn or stop the user but continues to use the auto-generated one.

It should turn the edit red if it's not a valid bitcoin address. I'll try and reproduce this.

I was able to edit the address in a test project I just created. Are you replacing the original file? Changing the title? If you save the edited project to a new file, it's seen as a brand new project, effectively duplicating it.

Update pushed


Selection from range of provided prompts - Target Version 0.2.0b3

@eLn86
This one - a full beta update on its own because it's not a small job and has a high chance of breaking A LOT of things - I'll handle it after we push the version with the rate limiter to prod
Prompts:
DEFAULT_SYSTEM_PROMPT = """You are a testing system. Your job is to determine if an actual output matches the expected behavior.

    Important: You can only respond with EXACTLY:
    1. 'PASS' if it matches, or
    2. 'FAIL: <reason>' if it doesn't match.

    Any other type of response will mean disaster which as a testing system, you are meant to prevent.

    Be strict but consider semantic meaning rather than exact wording."""

    DEFAULT_HUMAN_PROMPT = """
    Expected Behavior: {expected_behavior}

    Actual Output: {actual}

    Does the actual output match the expected behavior? Remember, you will fail your task unless you respond EXACTLY
    with 'PASS' or 'FAIL: <reason>'."""

key: default

everything as is

key: literalist

SYSTEM_PROMPT = """You are a testing system. Your job is to determine if an actual output matches the expected behavior.

    Important: You can only respond with EXACTLY:
    1. 'PASS' if it matches, or
    2. 'FAIL: <reason>' if it doesn't match.

    Any other type of response will mean disaster which as a testing system, you are meant to prevent.

    Be strict and prefer literal interpretations of expected behavior but consider semantic meaning rather than exact wording."""

    HUMAN_PROMPT = """
    Expected Behavior: {expected_behavior}

    Actual Output: {actual}

    Does the actual output match the expected behavior? Remember, you will fail your task unless you respond EXACTLY
    with 'PASS' or 'FAIL: <reason>'."""

key: return_pass_reason

SYSTEM_PROMPT = """You are a testing system. Your job is to determine if an actual output matches the expected behavior.

    Important: You can only respond with EXACTLY:
    1. 'PASS: <reason>' if it matches, or
    2. 'FAIL: <reason>' if it doesn't match.

    Any other type of response will mean disaster which as a testing system, you are meant to prevent.

    Be strict but consider semantic meaning rather than exact wording."""

    DEFAULT_HUMAN_PROMPT = """
    Expected Behavior: {expected_behavior}

    Actual Output: {actual}

    Does the actual output match the expected behavior?  Your job is to determine if an actual output matches the expected behavior.

    Important: You can only respond with EXACTLY:
    1. 'PASS: <reason>' if it matches, or
    2. 'FAIL: <reason>' if it doesn't match.

    Any other type of response will mean disaster which as a testing system, you are meant to prevent.

    Be strict and prefer literal interpretations of expected behavior but consider semantic meaning rather than exact wording."""

    DEFAULT_HUMAN_PROMPT = """
    Expected Behavior: {expected_behavior}

    Actual Output: {actual}

    Does the actual output match the expected behavior? Remember, you will fail your task unless you respond EXACTLY
    with 'PASS: <reason>' or 'FAIL: <reason>'."""

[ ] create new branch feature/0.2.0b2-configurable-prompt-styles
[ ] store prompts in a separate file
[ ] use enums to deal with strings coming in from env
[ ] add validation to make sure people don't pass in AsserterPrompts object + provided prompts selector at some time
[ ] move default prompts out of AsserterPromptConfigurator
[ ] config hierarchy: direct args -> env -> defaults
[ ] use frozen dataclass to store the prompt styles
[ ] BehavioralAssertion constructor needs modification to accept prompt_style parameter, which must be something from the PrompStyles dataclass
[ ] validator must throw some kind of exception if someone passes in something other than from that dataclass - to figure out architecturally how this is going to work
[ ] assert_behavioral_match needs modification to return asserter output string if one of the PASS prompts are selected
[ ] documentation must be written - 30,000 executions for default prompts tested, expect instability because this increases the problem space
[ ] 100% coverage

Pushed to 0.3.1b1 because this is really not an important feature and it's going to cost north of $100 to validate every single one of these over 30k executions


List 5.4 name of ngFormControl should be "searchInput" instead of "search"

In Charter 5 list 5.4，The second bold notes says :
This <input> element is represented by the ngFormControl named **search**.
Should says "This  element is represented by the ngFormControl named searchInput."

Thank you for your comment. I'll add this to the next version of the Errata page.


About  CTAugment?

Hi, @KaiyangZhou. It is a very good toolbox. Just out of curiosity, will there be an implementation about CTAugment in the future.

no plan yet
feel free to submit a PR


github: add GitHub Actions configuration

This PR implements all actions currently running on Travis CI to be run as GitHub Actions.
It seems the actions in the main repository will only be executed once the PR is merged. Preview the actions here.
A complete run seems to finish in 30m 23s, not bad :tada:
It seems GitHub allows up to 10 jobs to run simultaneously, so this could be the starting point for parallelizing the integration tests more.

Removed the temporary branch name that was needed for the preview in my fork. This should be ready to be merged now.


Windows client won't connect to local server without Firebase account on server

Windows client won't connect (via setup workflow) to same lan server without Firebase account enabled on server.   Errors out on step 3/5 with unrelated generic authentication error.

Known issue and already fixed, once we make a new windows build it should work normally.


records-[fsharp].md

Textual paragraphs immediately following code snippets were wrongly formatted as code.

Looks good, thanks @masroore!


MetalLB lab uses an element from the "Exposing apps using a Route" lab

TL;DR: we should rearrange the navigational list to have attendees run the Route lab before the MetalLB lab as the latter uses an outcome of the former.
In step 3 of the metalLB lab, "Expose the database node externally" it uses a database exposed by a route in the lab that's listed after it in the navigation al menu ("Exposing apps using a Route").
While the labs can be done in any order if there's a dependency on one we should probably both mention that in the lab's intro and list them in the order they need to be run as it's common for people to follow the navigational list from top to bottom.

100% agree, also got confused myself on my dry run. I created a PR @augustrh feel free to review / comment / advocate for :)
https://github.com/rhpds/roadshow_ocpvirt_instructions/pull/45


Add new product to list

Add a new product on creation directly to the according list (fridgelist/cupboardlist/freezerlist) and remove the check in the notifier to create a new item if its new.

Check to remove e.g. cupboard:
 newcupboardItemList.contains(newcupboardItemList.firstWhere(             (cupboardItem) => cupboardItem.product.id == product.id,             orElse: () => const CupboardItem()))


Strange garbage on top of minified javascript in production build

This is at the beginning of the minified js, using the zurb foundation template with the --production setting:
"use strict";function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}function _classCallCheck(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}

This looks wrong.
I feel like there was something about this somewhere in this issue tracker, but I can not find any issue with some of these strings. I do not know why babel produces this. Looks not healthy.

Same.

Hi @COLABORATI,
That is how babeljs converts the class keyword from ES5 to ES6, so it creates those helper functions to simulate the class feature.
Take a look at this sample.
Thanks,


Text to Speech with MMS

SF may be very interested in converting chapters of the bible to audio - and because Meta's MMS can do this conversion, it may be feasible and valuable for Serval to do this.  It could be batch jobs, should be a simple amount of code to do this.  We could:

Per line, make an audio file
Per file in a corpora, make a file with timestamps per line
Add new endpoint to download files
Add new engine called TextToSpeech

We may need to support "finding the best language" for ones outside of the 1100 supported languages - one of them should work well - similar orthography at least.