Option parsing bug for start-component.sh

This might be related with #52 .
In https://github.com/linkedin/dynamometer/blob/master/dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java#L327 it is trying to find whether there is help option entered for the function, but internally it is using a GnuParser (which is deprecated from version 1.3), and during the flatten process it will try to pull the substring of -h from option -hadoop_binary_path and thinks it is asking for help information.
Note this only happens when you put the -hadoop_binary_path as the first option since other options will make the flatten end early.

Sorry for taking so long to address this, it slipped past me. Can you take a look at PR #90?


Build Arduino sketch on CI

As a developer, I want to be certain that my Arduino sketch is always buildable for my ESP32 based Smartcar.
Therefore, I want the sketch to be build after every push so I can ensure that the build is not broken.

You mean that I should create new arduinoSrc/WebServer (but called something else)  that we have on our code and change it to new version

On Oct 26, 2020, at 5:11 PM, Dimitris Platis<EMAIL_ADDRESS>wrote:
@platisd commented on this pull request.
In .github/workflows/arduino.yml https://github.com/DIT112-V20/group-11/pull/29#discussion_r512083395:

      arduino-cli lib install LIBRARY[@6.0.0](S) [flags]

      arduino-cli lib install "Smartcar shield"

If arduino-cli lib install<EMAIL_ADDRESS>installs version 1.0.0 of library "AudioZero" how should it be adjusted for version 6.0.0 of "Smartcar shield"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/DIT112-V20/group-11/pull/29#pullrequestreview-516940465, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5VLVPD6WCLCGVXKNDJGD3SMWNRNANCNFSM4OGUC5OA.

You mean that I should create new arduinoSrc/WebServer (but called something else) that we have on our code and change it to new version
…
On Oct 26, 2020, at 5:11 PM, Dimitris Platis @.> wrote: @platisd commented on this pull request. In .github/workflows/arduino.yml <#29 (comment)>: > + arduino-cli lib install @.(S) [flags] + arduino-cli lib install "Smartcar shield" If arduino-cli lib install @.*** installs version 1.0.0 of library "AudioZero" how should it be adjusted for version 6.0.0 of "Smartcar shield"? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5VLVPD6WCLCGVXKNDJGD3SMWNRNANCNFSM4OGUC5OA.

No. Please focus on line 22 of what you already have (and remove line 21 since its wrong). Considering the example I already mentioned, how would you download version 6.0.0 of the library "Smartcar shield"?

I get it, its work now.

On Oct 26, 2020, at 7:18 PM, Dimitris Platis<EMAIL_ADDRESS>wrote:
You mean that I should create new arduinoSrc/WebServer (but called something else) that we have on our code and change it to new version
… x-msg://18/#
On Oct 26, 2020, at 5:11 PM, Dimitris Platis @.> wrote: @platisd https://github.com/platisd commented on this pull request. In .github/workflows/arduino.yml <#29 (comment) https://github.com/DIT112-V20/group-11/pull/29#discussion_r512083395>: > + arduino-cli lib install @.(S) [flags] + arduino-cli lib install "Smartcar shield" If arduino-cli lib install @.*** installs version 1.0.0 of library "AudioZero" how should it be adjusted for version 6.0.0 of "Smartcar shield"? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (review) https://github.com/DIT112-V20/group-11/pull/29#pullrequestreview-516940465>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5VLVPD6WCLCGVXKNDJGD3SMWNRNANCNFSM4OGUC5OA https://github.com/notifications/unsubscribe-auth/AO5VLVPD6WCLCGVXKNDJGD3SMWNRNANCNFSM4OGUC5OA.
No. Please focus on line 22 of what you already have (and remove line 21 since its wrong). Considering the example I already mentioned, how would you download version 6.0.0 of the library "Smartcar shield"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/DIT112-V20/group-11/pull/29#issuecomment-716735834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5VLVOEEKHNTT2HMWQS3CLSMW4PXANCNFSM4OGUC5OA.

Good job. I sent you a follow up email.


Contact form validation checked before alert sent message issue

Related Issue
Closes: #393

@anmode Please review it!!

Thanks @Geeta259


Adds script for generating NCR shapefiles for GeoServer.

This PR creates the required shapefiles for upload to Geoserver for all NCR and ArcticEDS places and AOIs.
To test, go into utilities and run:
python create_updated_ncr_shapefiles.py
After a few minutes, 3 shapefiles and their associated additional files will be present in the directory: utilities/all_places/

I went ahead and tacked my work with the new Yukon areas onto this branch, pulling in the new Yukon area shapefiles from the add-yt-polygons branch.
I see some unresolved comments in this PR, but I'm pretty sure we'll want to merge this branch as-is without any additional changes that could impact the API or NCR in unexpected ways, such as changing the huc type to huc8 for example.
Xref: https://github.com/ua-snap/northern-climate-reports/pull/633
Xref: https://github.com/ua-snap/data-api/pull/407

OK, merging as-is, thanks @cstephen


ZoomInTo should take future data into account'

Coverage decreased (-0.006%) to 30.979% when pulling b5a699d7d238a64a77da11dccb1b3c5743fef542 on qingweibinary:qingwei/update_zoom into 39e51f3e9e7ebde856e9d3c44b9d50db7d4fec92 on binary-com:master.


Publish created post to facebook page

A user should be able to publish created post to facebook page

Posting to facebook as a page is successful with facebook-sdk library.

Nice! Submit a pull request for this issue.

All you have to do is include the
special keyword syntax "fixes #"(in your case => fixes #17) in the body of your Pull Request.

And the referenced issue will automatically be closed when the PR is merged
into the default branch.

Completed


How to build & run a container image with docker-compose.yaml

https://github.com/DavidVujic/python-polylith-example-uv/blob/ac4e86849d4be010daa1519bd87289630fa4ff7b/projects/my_fastapi_project/README.md?plain=1#L3-L20
I have been following the provided steps to build and run the project, which involve:
Exporting dependencies using uv export to generate requirements.txt.
Building a wheel file via uv build.
Building a Docker image using docker build.

These steps work well, but I’m looking for a more practical and efficient way to manage the project lifecycle, particularly when iterating on development. Instead of building the project each time, I’d like to simplify the process, ideally leveraging docker-compose to streamline dependencies and project setup.
as extra context, this is the project i'm working on https://github.com/Bot-detector/bot_detector

For local development I would recommend to run code and tests from the top of the repo: the Polylith workspace. The virtual environment there should have all the necessary dependencies and paths setup already from the top-level pyproject. I usually develop that way, running code in a REPL and develop & evaluate code all the time (not building wheels at this stage). Would that work for you?
When deploying (to a local cluster or to a remote environment): that's where building wheels and docker containers would fit in the workflow.

for local development i do extensively use docker containers, i'm kinda not getting why we even need a wheel if i'm just deploying an api, and if we are deploying from the root (top of the repo) than what is the purpose of the /projects.
i do need a place for a Dockerfile, so that would be /projects/ i suppose and than i just copy all the bases, components etc over?

The wheel is basically a way to collect all the needed bricks (components and bases) for a specific project and the needed third-party dependencies. But I think the same thing can be achieved with uv sync maybe?
I don't think you should deploy code from the root. That's what the projects are for. In a Monorepo, you will have several bricks, but each project will likely only need a subset of those. The top-level contains all the bricks, and is there for development: to have all the code available for development, testing and experimentation.
I think a dockerfile for a specific project would fit well to live in the projects folder. If you need something to run your development flow in, then maybe a compose file at the top-level would make sense. I usually run code on the local machine without docker (unless it is a dependent third-party service such as Kafka or similar, those ones I run in docker and "my" code locally).
I either the functions directly in a REPL or if I want to run a FastAPI app (or similar), then I execute the code locally too (the "app" parts and endpoints in a base).

I don't think you should deploy code from the root. That's what the projects are for.

i agree

I think a dockerfile for a specific project would fit well to live in the projects folder.

i agree

I either the functions directly in a REPL or if I want to run a FastAPI app (or similar), then I execute the code locally too (the "app" parts and endpoints in a base).
i would like to be able to run it in the terminal but also with docker-compose, the idea is that i can spin up multiple services at once locally. the challenge is that i can't get it to work even with the building, i'm a bit lost here cause i don't really understand the building process and the purpose, i only ever did it for a package and there it magically works when someone imports the package from pypi but in my container i just seem to have the wheel & requirements.txt

It would be great to have a smooth solution to that! I haven't that much experience of local development in that kind of style, other than deploying individual services into a local K8s cluster by packaging and installing them from built wheels. Something like the Dockerfile here: https://github.com/DavidVujic/python-polylith-example-uv/blob/ac4e86849d4be010daa1519bd87289630fa4ff7b/projects/my_fastapi_project/Dockerfile
With this, one would probably want a script like make deploy or something similar, that will run uv build for all the projects in the repo (or a selection o them) and also build & deploy the docker containers (maybe using Docker Compose).
To deploy one service from the monorepo, I would recommend to build a wheel and then install that wheel in the Docker container. I know others copy the necessary folders from the repo into a container and then run uv sync. I'll try to find an example - there's one in an github issue somewhere 😄

I think I found an alternative to building a wheel and install it in a container, from this resolved issue (the first comment), I think there are a bunch of optimization flags there that might not be relevant to your setup. But they run uv sync for an individual project here: https://github.com/DavidVujic/python-polylith/issues/307
My preference would still be wheels + pip install though.

It would be great to have a smooth solution to that! I haven't that much experience of local development in that kind of style, other than deploying individual services into a local K8s cluster by packaging and installing them from built wheels. Something like the Dockerfile here: https://github.com/DavidVujic/python-polylith-example-uv/blob/ac4e86849d4be010daa1519bd87289630fa4ff7b/projects/my_fastapi_project/Dockerfile
With this, one would probably want a script like make deploy or something similar, that will run uv build for all the projects in the repo (or a selection o them) and also build & deploy the docker containers (maybe using Docker Compose).
To deploy one service from the monorepo, I would recommend to build a wheel and then install that wheel in the Docker container. I know others copy the necessary folders from the repo into a container and then run uv sync. I'll try to find an example - there's one in an github issue somewhere 😄

i'm still pretty unclear on how to run it, you can see the my error
i managed to build the wheel in docker
# projects/hiscore_scraper/Dockerfile
# Build stage: Use uv to build the wheel
FROM python:3.11-slim-bookworm AS builder

# Copy uv from external repository
COPY --from=ghcr.io/astral-sh/uv:0.5.13 /uv /uvx /bin/

# Set the working directory for the build stage
WORKDIR /app

# Copy only necessary files for building the wheel
COPY ./projects/hiscore_scraper/pyproject.toml .
COPY ./projects/hiscore_scraper/uv.lock .
COPY ./projects/hiscore_scraper/ .

# Build the wheel using uv
RUN uv build --out-dir ./dist

# Production stage: Prepare the final production environment
FROM python:3.11-slim-bookworm AS production

# Copy uv from the builder stage
COPY --from=ghcr.io/astral-sh/uv:0.5.13 /uv /uvx /bin/

# Copy the built wheel from the build stage
WORKDIR /app
COPY --from=builder /app/dist/ .
COPY --from=builder /app/pyproject.toml .
COPY --from=builder /app/uv.lock .
# Install the wheel using uv
# RUN uv install --wheel ./dist/*.whl

# Run the package using uv
CMD ["uv", "run", "hiscore_scraper"]

[build-system]
requires = ["hatchling", "hatch-polylith-bricks"]
build-backend = "hatchling.build"

[project]
name = "hiscore_scraper"
version = "0.1.0"

requires-python = ">=3.10"

dependencies = [
    "aiokafkaengine>=0.1.0",
    "osrs>=0.0.14",
    "pydantic-settings>=2.7.0",
    "pydantic>=2.10.4",
]

[project.scripts]
hiscore_scraper = "bot_detector.hiscore_scraper.core:main"

# This section is needed for building
[tool.hatch.build.targets.wheel]
packages = ["bot_detector"]

[tool.hatch.build.hooks.polylith-bricks]

[tool.polylith.bricks]
"../../bases/bot_detector/hiscore_scraper" = "bot_detector/hiscore_scraper"
"../../components/bot_detector/proxy_manager" = "bot_detector/proxy_manager"
"../../components/bot_detector/schema" = "bot_detector/schema"

to run it from the root in my repo https://github.com/Bot-detector/bot_detector
docker build -f "./projects/hiscore_scraper/Dockerfile" -t hiscore_scraper . && docker run -d --name hiscore_scraper_debug hiscore_scraper sleep infinity && docker exec -it hiscore_scraper_debug bash

$ uv run hiscore_scraper
Traceback (most recent call last):
  File "/app/.venv/bin/hiscore_scraper", line 5, in <module>
    from bot_detector.hiscore_scraper.core import main
ModuleNotFoundError: No module named 'bot_detector'

I'm not sure if I understand it correctly, but shouldn't the first part of the dockerfile copy the entire repo structure, if it should be able to create a wheel from Python code in the top-level components and bases?
The second part of the dockerfile: I don't think you anything else than the wheel itself (and a requirements.txt if you want to do a 2-step install with fixed third-party dependencies from a lock file). I don't think you need uv here either (only needed to build the wheel). You can install it in the docker containing with pip install.

the tree you see is from within the dockerfile, its the created wheel so it has the files but when i try to run it than it says module not found, because i import from bot_detector (in your case from example) but it  somehow fails to see "bot_detector" as a package after the building

you know what maybe you are right just double checking stuf

okay still alot of work in progress going on here but i got the following
FROM python:3.11-slim-bookworm AS builder

# Copy uv from external repository
COPY --from=ghcr.io/astral-sh/uv:0.5.13 /uv /uvx /bin/

# Set the working directory for the build stage
WORKDIR /app

# Copy only necessary files to run the projects
COPY ./bases ./bases
COPY ./components ./components
COPY ./projects/hiscore_scraper .

RUN uv sync --frozen --no-editable
RUN uv build --out-dir ./dist
RUN uv pip install dist/hiscore_scraper-0.1.0-py3-none-any.whl
RUN uv sync --frozen --no-editable

# Production stage: Prepare the final production environment
FROM python:3.11-slim-bookworm AS production
# Copy uv from external repository
COPY --from=ghcr.io/astral-sh/uv:0.5.13 /uv /uvx /bin/
COPY --from=builder --chown=app:app /app/.venv /app/.venv

WORKDIR /app

CMD ["uv","run","hiscore_scraper"]

i can validate that hiscore_scraper is succesfully build inside the container
root@722dd6c3e610:/app# cat .venv/bin/hiscore_scraper
#!/app/.venv/bin/python3
# -*- coding: utf-8 -*-
import re
import sys
from bot_detector.hiscore_scraper.core import run
if __name__ == "__main__":
    sys.argv[0] = re.sub(r"(-script\.pyw|\.exe)?$", "", sys.argv[0])
    sys.exit(run())

however now bot_detector is not in the container packages
root@722dd6c3e610:/app/.venv/lib/python3.11/site-packages# ls
AioKafkaEngine                    annotated_types-0.7.0.dist-info     frozenlist-1.5.0.dist-info       pydantic-2.10.4.dist-info
__pycache__                       async_timeout                       hiscore_scraper-0.1.0.dist-info  pydantic_core
_virtualenv.pth                   async_timeout-5.0.1.dist-info       idna                             pydantic_core-2.27.2.dist-info
_virtualenv.py                    asyncio                             idna-3.10.dist-info              pydantic_settings
aiohappyeyeballs                  asyncio-3.4.3.dist-info             multidict                        pydantic_settings-2.7.0.dist-info
aiohappyeyeballs-2.4.4.dist-info  attr                                multidict-6.1.0.dist-info        python_dotenv-1.0.1.dist-info
aiohttp                           attrs                               multidict.libs                   requests
aiohttp-3.11.11.dist-info         attrs-24.3.0.dist-info              osrs                             requests-2.32.3.dist-info
aiokafka                          certifi                             osrs-0.0.14.dist-info            typing_extensions-4.12.2.dist-info
aiokafka-0.12.0.dist-info         certifi-2024.12.14.dist-info        packaging                        typing_extensions.py
aiokafkaengine-0.1.0.dist-info    charset_normalizer                  packaging-24.2.dist-info         urllib3
aiosignal                         charset_normalizer-3.4.1.dist-info  propcache                        urllib3-2.3.0.dist-info
aiosignal-1.3.2.dist-info         dotenv                              propcache-0.2.1.dist-info        yarl
annotated_types                   frozenlist                          pydantic                         yarl-1.18.3.dist-info

huray, i got it working
FROM python:3.11-slim-bookworm AS builder

# Copy uv from external repository
COPY --from=ghcr.io/astral-sh/uv:0.5.13 /uv /uvx /bin/

# Set the working directory for the build stage
WORKDIR /app

# Copy only necessary files to run the projects
COPY ./bases ./bases
COPY ./components ./components
COPY ./projects ./projects

WORKDIR /app/projects/hiscore_scraper

RUN uv venv
RUN uv build --out-dir ./dist
RUN uv pip install /app/projects/hiscore_scraper/dist/hiscore_scraper-0.1.0-py3-none-any.whl
RUN uv sync --frozen --no-editable

# Production stage: Prepare the final production environment
FROM python:3.11-slim-bookworm AS production

WORKDIR /app/projects/hiscore_scraper

COPY --from=builder --chown=app:app /app/projects/hiscore_scraper/.venv /app/projects/hiscore_scraper/.venv

CMD [".venv/bin/hiscore_scraper"]

i think this is a lot cleaner having the build in the container itself, and a generic Dockerfile in the root of the repository that mounts the bases, components, projects so you can run exec into the container and run from there, which allows networking to other containers similarly as you'd have in production
here is my repository
https://github.com/Bot-detector/bot_detector

maybe this is useful for the example repository?

Very nice! 👏
Do you need to do build, pip install and uv sync here?
RUN uv venv
RUN uv build --out-dir ./dist
RUN uv pip install /app/projects/hiscore_scraper/dist/hiscore_scraper-0.1.0-py3-none-any.whl
RUN uv sync --frozen --no-editable

I'm thinking it should work either by building + pip installing, or uv sync. Both options should create a virtual environment, and that one is copied into the second docker step (as I understand it).

I'm thinking it should work either by building + pip installing, or uv sync. Both options will add the code to the virtual environment, and the venv is copied into the second docker step (as I understand the Dockerfile).
Alternatively, you can build a wheel, and copy that one into the next step where you do a pip install.

you are right, this works
RUN uv sync --frozen --no-editable

Yes, this is useful for the example repository indeed! I will add your Docker setup to a project and will write something about the setups in the readme too. Thank you for sharing the repo 👏


[feat] Getting a URL to resources (assets, media, videos, files, etc) without loading the entire file into memory; streaming playback

Describe the problem
I'd like to make an application that can play videos from the filesystem. In some cases, the videos might be larger than the available system memory, so we don't want to load them as a Uint8Array, Blob or anything like that.
My reading of the code first introduced in #2104 AFAICT and now living at https://github.com/tauri-apps/tauri/blob/3e702cf8b15762cdca43c8d7ff6f6e8ee9670244/core/tauri/src/manager.rs#L640-L651= suggests that, when using the asset:// protocol (e.g. through convertFileSrc) the entire file will be read into memory as a Vec<u8> upon request (unless there's a Range header, in which case it will read part of the file).
Describe the solution you'd like
Naïvely, I'd like the asset:// protocol to stream the file from disk rather than buffer it all into memory.
It doesn't have to be the asset protocol; any mechanism where the Rust backend can expose a single file on the filesystem and have it streamed into a video tag on the page would be sufficient for my needs.
Alternatives considered
A workaround might be to expose the file over HTTP and stream it using a http:// URI. This kind of entirely bypasses Tauri though?
Additional context
No response

Did you see our streaming example? https://github.com/tauri-apps/tauri/tree/dev/examples/streaming
Sounds exactly like what you're looking for. The problem with that one is that it doesn't work on linux because webkitgtk didn't support headers for custom protocol until the last release, but it's not widespread enough to depend on it yet (also, in first tests it looked like it still doesn't work correctly iirc)

I must admit I didn't come across the examples before, so thanks for linking that one and for mentioning the current status.
However I still don't think that's right.
When there's no Range header, it uses read_to_end as far as I can see, buffering the entire file into memory.
content.read_to_end(&mut buf)?;

My experience with streaming HTTP requests and video playback (specifically Firefox to be honest; if other browsers behave differently then I haven't had experience with those) is that the video will be played back in one HTTP connection unless the user seeks to a different position (at which point a new request with a Range header is sent).
In my experience, the server-side code usually reads 'small' chunks of the file into a buffer and writes them out to the stream whenever possible. I always imagined that TCP applies backpressure so that the server ends up writing only as much as the client is able to cope with; after all, neither client nor server are holding the entire file in memory.
I realise that you're not using HTTP here, but I would have expected the principle to be the same: only read the file in chunks and write out to the response (tokio::io::copy is useful for this when using Tokio).
Have I got the wrong end of the stick?

However I still don't think that's right.

Well you can modify it however you want, it's just an example.

When there's no Range header, it uses read_to_end

That's correct, but at least in the context of videos (via the video&source html tags) the Range header is present (just comment out the read_to_end line and observe that it still works without increasing mem by 150mb at once).
I thought this read_to_end fallback is for linux (which as mentioned doesn't have/had header support), not sure about that.

Well you can modify it however you want, it's just an example.

The problem is that the API doesn't actually permit streaming, from what I can see (You can see that https://docs.rs/tauri/1.0.0-rc.0/tauri/http/struct.Response.html expects a Vec<u8> as the body. An API that supports streaming needs to give you a way to write to a stream rather than returning the entire body at once. One example is Rocket's Stream::chunked: https://api.rocket.rs/v0.4/rocket/response/struct.Stream.html. Axum has something else.).
The example as shown does not implement what would normally be called 'streaming' IMO. If you try to play a 10 GB video with it, assuming you have less than 10GB RAM + swap, the application will crash (on Linux [since it doesn't support headers according to your message] — I later noticed the part where the example shortens the requested ranges).

That's correct, but at least in the context of videos (via the video&source html tags) the Range header is present

I'm sorry, you're right. When I looked at the network requests last time, I wasn't using a <video> tag but instead just had the video itself open.
On a small example page (https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video), I see that there is a header of Range: bytes=0-.
However, doesn't this Range mean 'the entire file'? I checked https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range to be sure I'm not spouting nonsense.
However I now notice the example will shorten the range to 400 kiB. I'm surprised this works; I don't see on MDN anywhere that mentions that you're allowed to send a shorter range than the requested range? (If you have a reference about this being allowable, I'd be interested in seeing it!)

I realise I have crossed my wires a bit here, so I will sum up that I think there are kind of 2 different concepts going on here:

Range headers (in which the browser can request a smaller portion of the file) — I call these 'partial responses'.

If the web view requests small enough ranges for playing the video, then we may not even care about streaming responses
Playback of a video involves many requests for small portions of the file.
<video> tags seem to do this automatically (personally tested in Firefox)

Streaming responses (which is what I came here to talk about)

This is where you have only 1 request but the server doesn't have to have the entire response ready at once.

I still think streaming responses are valuable to be honest (do the webviews actually support them?) — for a start, it would avoid problems with custom headers not being supported.
Another application feature I had in mind involved letting you download/upload attachments (which could potentially be large). In this case, the browser might not even use Range headers to download the file.
(Though for that case, I believe you can get access to the file dialogue anyway and probably just do it all in Rust backend code, so I suppose it's not important)

For the WebkitGtk implementation, this code is relevant:
https://github.com/tauri-apps/wry/blob/494a11057f9ddd2bf4bcecdc96b43ed95c5bd08e/src/webview/webkitgtk/web_context.rs#L243-L244=
To support streamed responses, it looks like we'd have to use a different kind of InputStream other than MemoryInputStream. The good news is that this definitely seems possible. It probably needs a bit of massaging into the API though.


*:fix tsan in Pipeline Agg

What problem does this PR solve?
Issue Number: ref #6518
Problem Summary:
https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/8514/pipeline/ fix unstable test
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-sanitizer-test tsan

/run-sanitizer-test tsan

/run-all-tests


chore: sign container images on quay and signed releases

Signed releases #9769
This PR implements container images to be signed using sigstore/cosign  It also consolidates the checksums of the cli-binaries into a single file then signs it.
Three GitHub secrets will need to be created before this PR is merged. The process to do this is listed below.
TLDR: https://docs.sigstore.dev/cosign/git_support

Install Cosign on your workstation. Linux, Homebrew, and container options are available.  Execute the command cosign --version to verified it has been installed correctly.
Create or have a valid GitHub PAT token available.
Export your PAT as the environment variable "GITHUB_TOKEN"
Execute cosign generate-key-pair github://argoproj/argo-workflows This will start the process of creating the GitHub Secrets automatically for you, and prompt you to enter a password.  This Password will be stored as the Github secret COSIGN_PASSWORD I would recommend to use well respected password generator such as KeePassXC or Bitwarden and use a paranoid level of characters of at least 32.
Three GitHub secretes should have been created, please verify.  COSIGN_PASSWORD COSIGN_PRIVATE_KEY & COSIGN_PUBLIC_KEY
Please comment on this PR with the newly created public key (cosign.pub)

Updated to only sign multi-image tags

Not stale

We need some additional secrets required by this PR. @alexec @sarabala1979 Could you help add those?


[Flathub]Add downloads badge

Closes #5506

Thank you for the PR!
To avoid any bifurcation or loss of discussion for historical context, I'd recommend we first continue/resolve conversation back on the issue (especially the questions in https://github.com/badges/shields/issues/5506#issuecomment-1067129626) before diving to deeply into the proposed implementation

This was closed by mistake due to a typo in an unrelated commit message, reopening

In a holding pattern for now as the upstream service maintainers have stated they'd like to modify the API response before we start consuming

@calebcartwright flathub/website#67 has now been merged. I had updated my PR. This PR is now ready to merge.

I think this one is good to go. I'll leave it open in cast @calebcartwright wants to chime in before we merge but LGTM


Add support and instructions for defining input variables via cli

Add support and instructions for defining input variables via cli.
Currently input variables for submodules are defined in main.tf and variables.tf in repo root.
Other defaults are defined in each submodules variables.tf
User should be able to define from command line or with .tfvars:

name of the AKS K8S cluster
name of the Azure Resource Group the AKS K8S cluster is created under
number of hosts / machines in the cluster worker pool
(also enables shutting down the worker pool when it is not needed. Plain AKS K8S cluster doesn't cost anything!)
Something else?

See Terraform documentation for more info
https://www.terraform.io/docs/language/values/variables.html#using-input-variable-values

Idea is that one could e.g. run only the worker node pool down with a simple command like
terraform apply -var="k8s_agent_count=0"


Test passes locally but fails online

This particular test fails online but passes locally on my machine. My solution was very similar to one of the community solutions (https://exercism.org/tracks/php/exercises/clock/solutions/zembrowski) so I tried submitting an iteration that is identical and this test still shows failure for me.
Please note that this is the first time I've ever submitted a GitHub issue so I'm uncertain what type of formatting I should use or what further information would be valuable to include.
https://github.com/exercism/php/blob/92ef74bb9339fa639d3ffe40ed7c1c20a70d5209/exercises/practice/clock/ClockTest.php#L120-L127

Hi @dexmexter! Thanks for reporting the issue. It would be helpful to have the failure message you see. Copy&paste it in a code block (the <> icon on the editor or Markdown ``` before / after it on their own lines).
From a short look at the solution, it might miss : string in the required method signature:
public function __toString(): string

This is a new requirement of PHP in the current versions, and the solution dates before that.

Hello @mk-mxp
Here is the output I'm seeing from the website test results:
Code Run

$clock = new Clock(6, 15);

$clock = $clock->add(-160);

$this->assertEquals('03:35', $clock->__toString());

Test Failure

ClockTest::testSubtractMoreThanTwoHoursWithNegativeAdd
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'03:35'
+'08:55'

ClockTest.php:126

What is really odd is that it reports failure because it says that the solution returns '08:55' for that test.

For me it also fails locally, with the copy/pasted code from https://exercism.org/tracks/php/exercises/clock/solutions/zembrowski
Running tests for: clock
PHPUnit 10.5.33 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.12

..........F..................                                     29 / 29 (100%)

Time: 00:00.017, Memory: 8.00 MB

There was 1 failure:

1) ClockTest::testSubtractMoreThanTwoHoursWithNegativeAdd
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'03:35'
+'08:55'

And i think it's correct that it's failing. To me it looks like the check for negative minutes are missing. At least compared to my solution https://exercism.org/tracks/php/exercises/clock/solutions/tomasnorre
public function add(int $minutes): Clock
{
    if (0 > $minutes) {
        return $this->sub(abs($minutes));
    }
    $this->time->modify("+{$minutes} minutes");
    return $this;
}

@tomasnorre I see now that "+{$minutes} minutes" would evaluate to "+-160 minutes" and I agree that it would be better to handle this as you've suggested.
I don't understand why this would pass locally (php version is 8.3.13, phpunit version 10.5.37) but not online.

I don't understand why this would pass locally (php version is 8.3.13, phpunit version 10.5.37) but not online.

I haven't looked into that. I have this repository (https://github.com/exercism/php) checkout locally and replaced the linked solution with the on in https://github.com/exercism/php/blob/main/exercises/practice/clock/.meta/example.php then ran the tests with composer test:run.
Not 100% sure what happens in the online test runner. I haven't really touched that part of the code base yet.

@tomasnorre I see now that "+{$minutes} minutes" would evaluate to "+-160 minutes" and I agree that it would be better to handle this as you've suggested.

I haven't looked that much into the linked solution, that i can say it mine is better or not, just thought that part was missing. I'm btw. on PHP 8.3.12 and PHPUnit 10.5.33 so both older than yours.

OK, this is caused by a change in PHP 8.2.0. You can find it in the PHP docs on DateTime formats at the very end: number no longer accepts multiple signs, e.g. +-2. There is no specification of the current behaviour for this, but obviously it differs between PHP flavours (online test runner uses 8.3.10-cli-alpine3.20).
zembrowski's solution passed the online test runner 4 years ago, for sure using PHP < 8.2 which wasn't available at that time.

I'll close the issue since it is actually a problem with my solution and not the testing suite. I feel a bit silly knowing that, but am very appreciative of the time you both took to help me discover the root cause.


Lines containing parentheses are not coloured

When having a "Hervorhebung" like
DatabaseQueue (Logger)
it's not working.
When simply using
DatabaseQueue
it works.
Maybe the part within parentheseis is interpreted like a RegEx?

Everything is interpreted as regular expression. I guess it would be a better solution to have everything highlighted "as it is" and only have an optional regex as highlighting rule as this is an exception to the expected behavior.


Add AttributesAll function on query.go

This change provides get attributes for all matched elements by your query.

Coverage decreased (-0.4%) to 67.766% when pulling 3045c8f973100d6ff7bd25f89345f3c218092cb5 on kotamat:feature/attributes_all into f7ba4ae79bcdd7a05f7ba967bff8426d1c2a8f09 on knq:master.

Coverage increased (+0.6%) to 68.777% when pulling 42d0b4cfae5010624f19abc16e8f9ccc668da953 on kotamat:feature/attributes_all into f7ba4ae79bcdd7a05f7ba967bff8426d1c2a8f09 on knq:master.

Coverage increased (+0.4%) to 68.564% when pulling 42d0b4cfae5010624f19abc16e8f9ccc668da953 on kotamat:feature/attributes_all into f7ba4ae79bcdd7a05f7ba967bff8426d1c2a8f09 on knq:master.

Thank you, appreciate the contribution!


Util for threshold

Okay so the word 'threshold' could be wrong. I don't have any better word for this. So here's the problem i have.
We have 3 environments for our app DEV, UAT and Production. There are pipelines that push data in each of these environment's. This data is kinda live streaming data that doesn't always need to be consistent in dev and uat. Since the frequency of data being pushed is quite high and that becomes expensive, even if that's not needed.
That lead us to think is there any way we could handle this. So we can have something, may be a decorator, that can be used to control whether to proceed or not. This is somewhat similar to what sentry has for sampling_rate.
Any better name for this?
I would be happy to contribute.

I think a sample decorator could do the trick :)
Perhaps something along these lines? (not tested)
import logging
import random
import functools

def sample(sample_rate):
    def _sample(function):
        @functools.wraps(function)
        def __sample(*args, **kwargs):
            if random.random() <= sample_rate:
                return function(*args, **kwargs)
            else:
                logging.debug('Skipped execution of %r(%r, %r) due to sampling', function, args, kwargs)

        return __sample
    return _sample

This is exactly what we did. Shall i make a PR if it fits for this repo?

Yes, that would be fantastic :)


[WIP] added script for GeeksForGeeks submissions

This is the first time I'm writing code for/contributing to an extension 🙈
What works

getting content from page
sync submissions
GeeksForGeeks does not return any proper stats so only sending const text messages

Known issues

[x] too many requests to the API, need to fix the setTimeout
[x] extension context invalidated sometimes (trying to see why that might be happening)
[x] unable to find the id of button on DOM sometimes

@QasimWani any suggestions welcome!

@QasimWani would love to see this merged


ProcessException: ProcessException: Operation not permitted

command
flutter build appbundle
exception
ProcessException: ProcessException: Operation not permitted
Command: /Users/mokhtar/AndroidStudioProjects/restaurant_flutter_application/android/gradlew -q -Ptarget-platform=android-arm,android-arm64,android-x64 -Ptarget=lib/main.dart -Ptrack-widget-creation=true -Pshrink=true -Ptree-shake-icons=true bundleRelease

flutter doctor
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.7 19H2, locale en-EG)
    • Flutter version 1.20.4 at /Users/mokhtar/Developer/flutter
    • Framework revision fba99f6cf9 (5 weeks ago), 2020-09-14 15:32:52 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/mokhtar/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 48.0.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

Flutter Application Metadata
Type: null
Version: 1.1.0+2
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: null
Creation framework version: null
Plugins
firebase_messaging-6.0.16
flutter_plugin_android_lifecycle-1.0.9
fluttertoast-4.0.1
google_maps_flutter-0.5.29
location-3.0.2
location_web-1.0.0
path_provider-1.6.16
path_provider_linux-0.0.1+2
path_provider_macos-0.0.4+4
path_provider_windows-0.0.3
screen-0.0.5
shared_preferences-0.5.8
shared_preferences_linux-0.0.2+2
shared_preferences_macos-0.0.1+10
shared_preferences_web-0.1.2+7
sqflite-1.3.1+1
url_launcher-5.5.0
url_launcher_linux-0.0.1+1
url_launcher_macos-0.0.1+8
url_launcher_web-0.1.3+2
video_player-0.10.12+3
video_player_web-0.1.3+2
wakelock-0.1.4+2
webview_flutter-0.3.22+1

Hi @00AhmedMokhtar00
This issue was fixed  and merged .
Also see this  comment and try the same at your end to see if it works.
Thank you

Thanks @hamdikahloun for your quick response.
I tried 'flutter upgrade' but it didn't work, the same problem appears.
as for the iOS 'flutter build ios' succeeds normally, but 'flutter build apk', 'flutter build appbundle' always fail.
the problem is only with specific project, all ther flutter projects are working fine

@00AhmedMokhtar00 Can you switch to master channel please :

flutter channel master

flutter upgrade

@00AhmedMokhtar00 Can you switch to master channel please :

flutter channel master
flutter upgrade

I did that, then I tried  flutter build appbundle and had this ERROR:
null. The flutter tool cannot access the file or directory. Please ensure that the SDK and/or project is installed in a location that has read/write permissions for the current user.

@00AhmedMokhtar00 I guess error is telling that flutter upgrade didn't upgrade completely. Maybe use a VPN for upgrade?

Hi @00AhmedMokhtar00
If you install flutter somewhere that doesn't have rwx for the current user it won't work.
Thank you

@00AhmedMokhtar00
As the error says The flutter tool cannot access the file or directory. Please ensure that the SDK and/or project is installed in a location that has read/write permissions for the current user, try to have your SDK at a location outside of your current path which can be accessed by flutter tool properly.
If issue perists, please provide flutter build appbundle --verbose.

still have the same issue

@maen9911 did you create the project or the flutter folder with sudo ?
If you did, Can you please try sudo flutter build appbundle --verbose

@maen9911 did you create the project or the flutter folder with sudo ?
If you did, Can you please try sudo flutter build appbundle --verbose or cd android and sudo ./gradlew assembleRelease

no the project were zip file from another computer
`[  +50 ms] Running Gradle task 'bundleRelease'... (completed in 183ms)
[   +3 ms] "flutter appbundle" took 1,473ms.
[   +6 ms] null. The flutter tool cannot access the file or directory.
Please ensure that the SDK and/or project is installed in a location that has read/write permissions for the current user.
[   +2 ms]
#0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1      _throwFileSystemException (package:flutter_tools/src/base/error_handling_io.dart:672:3)
#2      _handlePosixException (package:flutter_tools/src/base/error_handling_io.dart:627:3)
#3      _run (package:flutter_tools/src/base/error_handling_io.dart:474:7)

#4      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:568:12)
#5      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:473:28)
#6      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:492:35)
#7      buildGradleApp (package:flutter_tools/src/android/gradle.dart:391:43)
#8      _AndroidBuilderImpl.buildAab (package:flutter_tools/src/android/android_builder.dart:121:13)
#9      BuildAppBundleCommand.runCommand (package:flutter_tools/src/commands/build_appbundle.dart:90:26)
#10     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1033:18)
#11     _rootRunUnary (dart:async/zone.dart:1198:47)
#12     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#13     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#14     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#15     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#16     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#17     Future._asyncCompleteWithValue. (dart:async/future_impl.dart:567:7)
#18     _rootRun (dart:async/zone.dart:1190:13)
#19     _CustomZone.run (dart:async/zone.dart:1093:19)
#20     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#21     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#22     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#23     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#24     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#25     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
[ +314 ms] ensureAnalyticsSent: 255ms
[   +2 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1
`

@maen9911 did you create the project or the flutter folder with sudo ?
If you did, Can you please try sudo flutter build appbundle --verbose or cd android and sudo ./gradlew assembleRelease

this is the second command output
Maens-MacBook-Pro:android maen$ sudo ./gradlew assembleRelease sudo: unable to execute ./gradlew: Operation not permitted Maens-MacBook-Pro:android maen$

cd android
chmod +x gradlew
./gradlew assembleRelease

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Cannot allow SVGs elements to get working

Step by step instructions to reproduce the behavior:

Create a SVG element with some gradient inside
Insert the code as v-html in Vue e.g.
Set allowedTags to: ['svg','g','use','defs','path','linearGradient', 'stop']
Set allowedAttributes to: ['*']
See that gradient elements are not rendered in latest Chrome or Safari

Expected behavior
Gradient should be visible
Describe the bug
Elements with gradient are not rendered, on Safari I am getting black instead of gradients
Details
When I set allowedAttributes and allowedTags to false everything is working properly, is that risky operation?

Do you mean you have allowedAttributes as something like { 'svg': ['*'] }? With only the array that wouldn't work. Or you could use false to allow all attributes on anything (probably not a great idea).
I do see a possible issue with viewBox and linearGradient where they might become fully lower-cased. Actually linearGradient seems rejected when camel cased. If I add 'lineargradient' to the allowed tags it gets through lowercased. This could be a htmlparser2 thing.

It looks like disabling lowercasing in the htmlparser2 options might be a way to go when you know you're using SVGs. https://github.com/fb55/htmlparser2/issues/539#issuecomment-687579675

I cannot add svg in allowedAttributes object, everything is working but with svg I am getting Error isPlainObject and this is caused only by svg without it everything is working but gradient is not being displayed
allowedAttributes: {             path: ['d', 'fill'],             svg: ['viewBox', 'viewbox'],             linearGradient: [               'id',               'x1',               'x2',               'y1',               'y2',               'gradientUnits',               'gradientunits',             ],             stop: ['stop-color', 'offset'],           },
I got fully working example by setting lowerCase to true but still allowedAttributes is set to false, any ideas?
Working example:
sanitizeHtml(text, {           allowedTags: [             'svg',             'linearGradient',             'lineargradient',             'path',             'stop',           ],           allowedAttributes: false,           lowerCase: true,         });


fix(loader): module.decorator order of operations is now irrelevant

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
See #12382
What is the new behavior (if this is a feature change)?
module.decorator declarations are now invoked via the configBlocks queue to ensure that the provider being decorated has been declared regardless of the order in which module.decorator is declared.
Does this PR introduce a breaking change?
Possibly.  If the same provider is decorated multiple times via a combination of module.decorator and $provide.decorator (via module.config), the decoration order may change now depending on declaration order of the module methods.
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)

Other information:
I didn't ngdoc the added queue param of invokeLaterAndSetModuleName because this fn isn't publically exposed and queue wasn't doc'd for invokeLater.
module.decorator() is now processed via the configBlocks order of operations and:

no longer throws if declared before the provider being decorated
guarantees the correct provider will be decorated when multiple,
same-name providers are defined

Closes: #12382

Thanks for the PR. I do think we should add a BC note to be on the safe side. Can you please add one, that describes the new behavior, how it's different from the old behavior and how this might break existing code? Small code example (that shows how order affects execution) would also be nice. You can have a look at the Changelog or the Migration guide to see how a BC note should look.

How?  Amend commit 478650c and re-push?  If so, won't that wipe out your comments above?

Yes amend and force push

The comments are independent of that. And comments on changes are also preserved if the code doesn't change

Thanks!  Please let me know if the new commit is not what you had in mind.

The commit message looks great, very nice!
I would only change the names anotherDecoratorFn and theDecoratorFn to provideDecoratorFn and moduleDecoratorFn to make it easier to see the new order.
I'd also like to see a test that ensures defining a decorator before its provider works.

I've made the following changes:

relocated the Closes tag to come before BREAKING CHANGE: in the commit message
renamed fn name examples in the commit message
created an additional unit test

Regarding the additional unit test...
I included the additional unit test in loaderSpec (as opposed to injectorSpec) because the failure described via #12382 is relevant to module.
However, I'm not entirely convinced this test is necessary because this PR is meant to move the processing of module.decorator declarations to the configBlocks queue. The originally modified unit test in loaderSpec proves that change works.
Regarding the Closes tag...
Neither the Contributing to AngularJS nor the AngularJS Git Commit Message Conventions documents seem to specify that the Closes #<issue number> tag needs to come before BREAKING CHANGE:.  In fact, the outline section displayed at the top of AngularJS Git Commit Message Conventions seems to indicate Referencing issues comes last in the Message footer.
Many BC commits seem to follow this pattern: d06431e, 98c2db7, 98528be, 983b059, etc...
Maybe the docs can be updated if format is critical and the above is no longer acceptable?
Thanks!

There's a typo in the new loaderSpec test that makes the tests fail.
I know that the test you changed validates the correctness of the fix, but it's important (to me) to have a test that exactly tests this change. The changed test doesn't make it obvious that the order doesn't matter now.
Wrt to the commit message guidelines, putting Closes #... before the BC notice makes the CL output prettier. But we could add that to the guidelines.

Oops, regarding the typo...
I had been testing via grunt test:unit all along.
I changed naming conventions that are used in the test at the last moment and then ran grunt test as a final sanity check before my commit.
Unfortunately the package task that is invoked before test.unit stalls on minall (more specifically, I had to remove the parseext item from min in order to resolve the stall in the test process), so I didn't noticed that test.unit was never re-run.
This behavior occurs on Win7 Pro 64-bit.

@robertmirro: Are you sure it "stalls". It usually takes a lot of time and CPU (and can give the impression that it's frozen), but its not.

@gkalpak I just waited 5-ish minutes. That feels "stalled" to me, but I'm open to using a different word to describe this behavior.  :smile:
With parseext included, minall never completes after angular.min.js is generated:
http://screencast.com/t/dhEVZizmxc25
With parseext commented out, minall completes and the next task (collect-errors) begins:
http://screencast.com/t/tD7StOaSML

That's odd (unless it just needs more time on your machine - depending on the available resources).
The tasks are running fine on my Windows 10 :smiley:
If I were you I would (1) try giving it some more time and (2) removing node_modules and re-installing (I guess that's the "switch it off and back on" strategy in the Node.js world :stuck_out_tongue:)

Being that I'm no stranger to anomalies such as this, I'll choose option (3)... Leaving parseext commented out while simultaneously attempting to forget that this issue probably only exists on my machine.  :stuck_out_tongue_winking_eye:
Thanks though!

Yeah that would work as well, I guess :smiley:

@Narretz Hi.  Why was this PR closed with no merge?


The relationship between DTU training data and Depth_raw

Can somebody tell me what the relationship is between these two data sets?
And how to follow with the example's folder structure.

DTU dataset contains depths as well, are those enough or is Depth_raw necessarily required?


add packages

xref.: https://github.com/oceanhackweek/jupyter-image/issues/20
closes https://github.com/oceanhackweek/jupyter-image/issues/19
needs:

[X] https://github.com/conda-forge/staged-recipes/pull/15763
[x] https://github.com/conda-forge/staged-recipes/pull/15772

It looks like the R packages may have exploded silently https://github.com/oceanhackweek/jupyter-image/pull/21/checks?check_run_id=3194966844#step:3:4363

Still cranky from upgrading r-gdal https://github.com/oceanhackweek/jupyter-image/pull/21/checks?check_run_id=3195393324#step:3:4269

rstackdequeue at https://github.com/oceanhackweek/jupyter-image/pull/21/checks?check_run_id=3195858068#step:5:3959

rstackdequeue at https://github.com/oceanhackweek/jupyter-image/pull/21/checks?check_run_id=3195858068#step:5:3959

See https://github.com/conda-forge/staged-recipes/pull/15772

I was just trying to access the Pangeo CMIP6 Cloud data on GCS and noticed that we are missing intake-esm and gcsfs dependencies on the hub. Any chance these could still be added? Sorry for the oversight.

Adding them now!


POC of automated Storybook accessibility/interaction testing

Pros:

can replay the interaction test step by step
catches more accessibility issues since it runs in browser

Cons:

needs storybook running
reporting from the automated test is kinda hard to read
some finicky behavior from interaction panel

✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Try running yarn test-storybook
Try going to the "With state" HelpText story and the "Default"/"Sections"/"Keyboard tab focus" Picker story and play around with the interaction addon panel.

🧢 Your Project:
RSP

This PR will need to wait for all of our stories to be converted to CSF 3, for now will serve as an example of additional storybook accessiblity/in browser interaction testing + example of using axe-core in our tests

Running the accessibility test yields the following results:
Test Suites: 32 failed, 84 passed, 116 total
Tests:       202 failed, 959 passed, 1161 total

Spot checked the failures against the accessibility addon in storybook and looked to be about the same. Will go through and try to hide the ones that we know are false positives

@reidbarber

Have you looked into the chromatic interactions integration? Maybe that's something we could use: https://www.chromatic.com/docs/interactions

Didn't realize that chromatic supported interactions, thanks for the link! Looks like we'd just have to write play functions in our chromatic stories and they will be run and snap shotted by Chromatic automatically. Def something we can explore using if we have a use case, but I'd like to get people's opinion of writing interaction tests via Storybook first (aka is it worth it or do we prefer the current react testing library tests?) IMO there are some use cases that are easier to test in browser, especially for cases that would require mocking of things like clientHeight/raf/etc

IMO there are some use cases that are easier to test in browser, especially for cases that would require mocking of things like clientHeight/raf/etc

@LFDanLu I like this idea a lot. I think it is better coverage and better DX. Makes sense for any interactions we have that come up similar to DnD and table column resizing.


Better libomp detection on macOS

This PR fixes three issues with libomp detection on macOS:

[x] macOS uses DYLD_LIBRARY_PATH and DYLD_FALLBACK_LIBRARY_PATH, not LD_LIBRARY_PATH
[x] libomp may have many different names (libomp in my case), search for all of them, not just libgomp
[x] ctypes.util.find_library() does not support absolute paths

There may still be problems with other compilers but I only encountered issues with Apple Clang on macOS.

Another option would be to add a pythranrc option to specify the full path to the OpenMP library. I would actually prefer that, but didn't want to do the work.

I tested this on macOS 10.15.7 with Apple Clang 12.0.0 and on Ubuntu 20.04 with GCC 9.3.0 and it seems to work fine. However, it seems to be failing in our CI for unknown reasons (not sure if you can see this: https://gitlab.spack.io/spack/spack/-/jobs/602032). It could definitely be made more robust. I'm open to suggestions!

The failing CI looks like download issues, right?

Hmm, it was definitely failing to find libgomp before, let me rebase and re-run the pipeline.

It seems this PR and #1868 address similar issues? @isuruf

@h-vetinari, nope. They are completely different.

I think I solved the issue I was seeing on Linux. The compiler was correctly set to g++, and g++ -print-file-names=libgomp.so was returning /usr/lib/gcc/x86_64-linux-gnu/7/libgomp.so, and that file does indeed exist. The issue is that ctypes.util.find_library() does not work with absolute paths to library names. The solution is to instead check to see if that file exists. This should be fixed in the latest commit.

Can anyone review this? It's getting difficult to rebase. Without this, I don't think it's possible to build pythran from source on macOS.

@adamjstewart sorry for the delay? I've added a refactoring hint, if you can take of it?

Done, see the latest commit. The error msg formatting could probably be fancier.

@rgommers could you test that one with scipy on osx, windows and Linux? We had issues in the past and I don't want to break scipy again ;-)

Sorry I missed this. And yep, it did break (https://github.com/scipy/scipy/issues/14687) - luckily we have CI to test Pythran master for SciPy now, so no damage done. I'll look into it.


Ignore unused clippy and unreachable code

To make the build clean I "temporarily" ignore some clippy warnings. We just have to remember to re-enable them again.

unsed: some fields/functions are unused at the moment
unreachable: everything after a todo! is unreachable

bors r+

bors r+


feature/better-passwordless-usernameless

To better support WebAuthn's passwordless and usernameless capabilities, additional info should be persisted after a successful attestation verification. This PR achieves this with the following changes:
The return value of verifyAttestationResponse() has been enhanced with additional information:

Values are now contained on attestationInfo

credentialID as a Buffer (replacing base64CredentialID)
credentialPublicKey as a Buffer (replacing base64PublicKey)
aaguid as a UUID string
credentialType as an attestation/assertion's PublicKeyCredential [[type]] slot as a string
userVerified as the boolean value of flags.uv  (now only when the attestation is verified)
attestationObject as the decoded response.attestationObject Buffer returned from the browser

Additionally, verifyAssertionResponse() has had its return data structure change to align with the above changes.

Values are now contained on assertionInfo

credentialID Buffer replaces the old base64CredentialID string
newCounter renames the old counter

The excludeCredentials argument of generateAttestationOptions() and allowCredentials of generateAssertionOptions() now expect the credential id to be a Buffer. Previously this was expected to be a string. This change was made to make it easier to feed the return value of verifyAttestationResponse() directly into future calls to generateAttestationOptions() and generateAssertionOptions(). This also reduces the amount of encoding/decoding between Buffer and Base64URL throughout attestation and assertion verification, which should be more performant.
Finally MetadataService picked up some preliminary log statements that had to be commented out at the last second. Enabling this logging will be the target of the next release pending a solution to anylogger Issue #17.
Related Issues

Issue #95
Issue #96

@MasterKale I can't see the UserHandle generation in your PR. Did you revert it? because you said that it'll be auto-generated but in the code, we have to pass it in option
And what is the difference between credentialId and aaguid ?

Ok I saw the comment in the code
So if I understant aaguid is used for MetadatService I guess? and credentialID to link the public-key with the credential

Yes, that's correct about aaguid. If you want to dive into a weeds a bit it's a part of the FIDO2 spec, and can be passed into MetadataService to retrieve the corresponding FIDO2 Metadata Statement.
credentialID and credentialPublicKey are a pair of values that must be maintained with each other. You'll pass credentialID into allowCredentials and excludeCredentials, and look up a credentialPublicKey by credentialID when trying to find the corresponding public key to verify an assertion.

@MasterKale and what about userHandle generation? we have to do it by ourself? because you told me last time you will auto-generate it

I made the decision not to generate a userHandle because the combination of RP ID and user handle are how authenticators internally track credentials. If the user handle is unique on every attestation (if SimpleWebAuthn were to automatically generate a userHandle every time) then the RP would lose track of credentials and be unable to pull up that credential for use when the user completes an assertion.
This would make it impossible for the RP to support usernameless in particular, as it's the userHandle that gets returned during assertion that helps the RP figure out which user is logging in. Therefore the RP needs to be particular about what value is provided here so that it has a chance at correctly associate an attestation credential to a specific user.

@MasterKale thanks for your explanation so I will generate by myself by I can see the type is string and in documentation it's a buffer. What about that?

user.id in the spec's PublicKeyCredentialCreationOptions is indeed a buffer. However, generateAttestationOptions() returns a JSON-compatible representation of options as PublicKeyCredentialCreationOptionsJSON. userID, then, is defined as a string so that it can be easily transmitted to the front end, at which point Browser's startAttestation() turns it into a UInt8Array before passing it to navigator.credentials.create().
By making userID a string it leaves it up to the RP to decide how to generate and encode the user handle.


Could not build sample by trying pod try

Should be fixed by now, related with #104

Verified by pod try EAIntroView, fixed in 2.7.3.


Fixed some coding style issues in ApplicationData solution.

I applied the followings:

When using a built-in type itself I used its C# alias but when using its static method I used its class name, eg. string output = String.Format(...);
Removed unnecessary "this" qualifications.
Removed unnecessary namespace qualifications.
Removed unnecessarily specified Exception type from catch blocks
Simplified some boolean expressions.
Reduced nesting code

Just a thought, but
•Removed unnecessary "this" qualifications.
•Removed unnecessary namespace qualifications.
might be unnecessary, but could be useful to novice developers. Which might have been the intent.

Could be true but I cannot really see in what way they can be useful, especially if they are not applied everywhere just in some parts of the code.
I think it may be more confusing for novice developers to have these unnecessary qualifications at some place and do not have them at some other place where they could also be applied. They might come to a wrong conclusion.
I think not these code samples are supposed to demonstrate how many (unnecessary) things can we avoid to write thanks to the smart C# compiler. :)
I think the code we provide should have a coding style as professional as possible so that novice developers can learn from that. Of course the code itself should be as simple and easy to understand as possible.
And if one has difficulties in understanding the code then there is always the option for everyone - including novice developers - to hover the cursor over a method call or a parameter type to see which class or namespace it belongs to.

Generally, we try to write samples so they are readable even to those who are not familiar with a language, because these samples are often the basis for translation to other languages (see the other discussions around VB and F#). Also, hovering over a method call to see its type doesn't work so great when you are reading the sample in a Web browser.

That is why we should (at least try to) write the code in a unified way according to the C# guidelines and best practises.
There are more options:

We might provide VB.NET code samples as well (as seen at some other place, e.g. MSDN) - also in a unified way according to the VB.NET guidelines and best practises.
One may use an online C# <--> VB.NET converter that might be not 100% perfect but can give one the idea.
One may learn the OOP / C# basics first before trying to write UWP apps.

I think the changes I made did not make the code readabilty worse even if one is not familiar with the C# language and even if it is read in a Web browser.
If someone would like to know anything about the details of a method / type / etc. then he/she should load the code sample into Visual Studio. I think it is part of learning. Anyway, the code sample cannot be tried out from the Web browser.
I do not think that we should write C# code in VB.NET / F# / Java / PHP / etc. style so that the code might be a bit readable to those developers.
If one would like to translate from one language to another language it can be assumed that he/she already has or would like to get (at least) a basic knowledge in both languages.

these changes seem reasonable to me.

When using a built-in type itself I used its C# alias but when using its static method I used its class name, eg. string output = String.Format(...);

What coding standard is this? I find it confusing. Should pick one or the other, not switch based on how the type is used.

What coding standard is this? I find it confusing. Should pick one or the other, not switch based on how the type is used.

I understand your concerns, it might be confusing, but I really like the concept behind this coding style, which is very simple and I think reasonable.
When we need the indication of the type we use the C# keyword / alias.
public string DoSomething(string someParameter)
{
    string result;
    // Doing something
    return result;
}

When we need to call a static method or to retrieve the value of a static property we use the CLR type name which looks more like a class due to the Pascal casing than the lowercase keyword, eg.
return someCondition ? String.Empty : String.Format(...);

Consider enum vs Enum. They are not interchangeable.
// "enum" must be used
enum Color { Red, Green, Blue }

// Causes "Unexpected token" error
Enum Color { Red, Green, Blue }

Color ParseColor(string value)
{
    // "Enum" must be used
    return (Color)Enum.Parse(typeof(Color), value);

    // Causes error
    return (Color)enum.Parse(typeof(Color), value);
}

int ParseInt32(string value)
{
    // Can be used and looks consistent when considering Enum.Parse(...)
    // The method name also contains Int32 according to Microsoft's naming convention.
    return Int32.Parse(value);

    // Can also be used but looks inconsistent when considering Enum.Parse(...)
    // In my opinion it looks a bit weird that a keyword has a callable method.
    return int.Parse(value);
}

The support of this coding style is also requested from ReSharper and I agree with them.


Report errors when loading YAML files with duplicate keys

This adds a custom constructor to the YAML loader created in
get_yaml_loader() so that duplicate keys in the YAML file result in a
PyYAML ConstructorError.
Duplicate keys are not allowed as per the YAML spec but are silently
ignored by PyYAML. This is a potential source of hard-to-detect errors
due to misconfigurations. It has been reported several times in the
PyYAML issues, e.g. https://github.com/yaml/pyyaml/issues/165. The
specific fix here was proposed at https://gist.github.com/pypt/94d747fe5180851196eb.

I guess "bugfix" is the most appropriate label for this PR, but I'm not totally sure.

Alright, error it is!


docs: object store configuration

Closes #1844

Documents how to configure S3 and GCS

This includes S3 Express

Added a CI job to check for broken links

Fixed various existing issues in docs that cause this CI job to fail

If I have time, I could also test and mention Azure blob storage.

@eddyxu @chebbyChefNEQ @changhiskhan Could I get a review here?


Exposing port 53 as localstack is also a DNS server

When running in K8S, we need to be able to use LocalStack DNS server capability (Transparent Endpoint Injection).
The helm chart does not allow to bind that port which makes this immposible to use this feature in K8S

Hi @ezraroi!
As discussed in #103, this is already in main and will be part of the next release (which will be created in the upcoming days after merging #107).

Thanks!

@alexrashed Don't we need also to expose this port as part of the service object? Otherwise, how can we configure all pods to you LocalStack as DNS server?

Also how did you think to use this feature in K8S? Config CoreDNS to forward all AWS domains to localstack DNS server? If yes, we need to edit the CoreDNS config.

Hi @ezraroi . We're developing a repo that runs LocalStack in EKS with the DNS Servicer configured in CoreDNS. It's all running now and I'll make it public by COB tomorrow (is my plan).

@ezraroi Heads up. I'm also using a dev container in the K8S namespace to be the client to LS. This diag doesn't have the K8S Services or CoreDNS in it but it gives you the idea.

@cabeaulac Thanks for your answer and digram. Waiting for that repo.

@cabeaulac Any updates on the repo with working example?

Hey @ezraroi . Find me and a link to the repo in this post. https://www.linkedin.com/posts/chad-beaulac_aws-eks-k8s-activity-7153140232622587905-hPO6?utm_source=share&utm_medium=member_desktop

Hey @ezraroi!
Please let me know if this sample repo from @cabeaulac helps.
If it does, I'd close the issue. If it doesn't please let us know what you are missing.
Thanks!

I would say pointing at another repo that requires devxpod to work isn't a real solution. I agree with @ezraroi that you should be exposing the DNS ports via the k8s service, and then configuring Coredns to delegate the localstack domain to it.
I've done some hand-edits to the manifests generated by this chart and it all works great once I add dns exposed on port 53, both TCP and UDP, setup a clusterIP: w.x.y.z value for the service as well so it has a static clusterIP, and the following in Coredns's Configmap Corefile:
localhost.localstack.cloud:53 {
  errors
  cache 30
  forward . w.x.y.z # the service's clusterIP
}

However, since this wouldn't be a default feature, and some nodes might not allow port 53 by default, I think this should be an opt-in feature (to enable the exposure of the DNS port 53).

Since it's exposed as a ClusterIP and not NodePort, I don't think the node has any limitations in this way

What do you think, @rattboi? Would you be up to creating a PR? 😛

I can definitely do this. I wanted to make sure that people were in alignment that this is an acceptable solution first.


Firefox windows 7 7.0.0 64bit, stats page stops refreshing after a bit.

Closing as it doesn't appear to happen anymore.


Failed RemoteJob retried immediately ignoring Epsilon setting

Is there a way to make failed job to retry after specified Epsilon time?

Unfortunately, no.  I ran into this as well, and after digging in found that the architecture/design isn't really set up for it.


Improve PolarsXXXEqualHandler

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d969950) to head (552b262).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #655   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           72        72
  Lines         1960      1977   +17
  Branches       241       244    +3
=========================================
+ Hits          1960      1977   +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update wasm-tools crates

Mostly comes with a split in wasmparser of simd/other ops since it's now possible to disable the simd feature at compile time (which we don't use in Wasmtime right now).

Upstream in wasm-tools the test suite for spec tests has stopped asserting that the spec-provided error message matches the wasmparser-provided error message. That means that the error-message-matching here in Wasmtime also needs to go since the same "failures" were cropping up there. I've adjusted the function to match errors in a similar way now which caused some tests to start passing. I think the new tests "passing" are probably where the error before was "wasmtime doesn't support this wasm instruction" and the expected error is something like "type mismatch" which would explain that.


 I was not able to find out here or from google. As logseq desktop version does have git build-in already and i can run git command from popup box so feel confused. Is this plugin adds some workflow like auto check/push, land GUI shortcut to git command, or it also deploys another git from scratch?
a more question, can it add auto pull after logseq startup, but not just checking/reminding the difference with remote?

I'm sorry I keep forgetting to add instructions for use
I wrote this plugin to address the following issues.

knowing explicitly if there are unsaved notes in the current repository and if they are synchronized with the remote repository.

When there are unsaved files locally, the plugin will show a red indicator in the toolbar icon

Quickly commit changes to notes.

The plugin provides shortcut keys (mod+s) to perform commit&push operations

provide buttons to quickly execute common commands

Click the plugin icon, and the drop-down menu will show you some buttons to help you quickly execute commands (you can specify the desired buttons in the settings)

prompt me if I have synchronized with the remote repository

I use a mac at work and windows at home. sometimes I commit actions on the mac to github later. I forget to pull code before writing notes on windows at home, which leads to frequent note conflicts. The plugin automatically detects if the current repository is up-to-date and prompts when logseq starts and other times.

I disabled auto commit on logseq because I didn't want to have too many commits in my repository, which caused the problem that I had to manage the repository manually, and this plugin is designed to make it easier for me to use git to store notes.
Also, there is an app for mac called shortery that automates shortcut execution, and with it you can push or pull code when the mac is locked or unlocked.
This is just my own way of using the plugin, you can use it any way you like, or use logseq's own git feature

great! cristical clear and thanks for sharing your experiences! this plugin made my logseq sync almost perfect. Maybe you can consider sharing this with more people in in README.
BTW, can you provide one more shortcut key option for 'Pull“? Sorry if I ask too much ;)

I apologize for the inconvenience, it seems that I accidentally closed the result message of the pull command. In the meantime, you can use "pull rebase" instead. I will make sure to fix this issue in the next release.

I have the plan to enable users to configure all of the short keys for commands. This will make the user experience more customizable and convenient.

The popup that you are seeing is a feature of Logseq. Unfortunately, I do not think that there are any good methods for addressing this issue at this time.

Thank you!! Really love logseq and your plugin!


Updates to readme and changelog

@cgmb @jzuniga-amd @tfalders @qjojo Can this PR be reviewed?

@jzuniga-amd can your team please review and merge this PR?

Same comments from the rocSOLVER PR apply here. We have not seen any changes there.

Same comments from the rocSOLVER PR apply here. We have not seen any changes there.

@jzuniga-amd how does this look? (We're paring down the number of categories in the changelog going forward.)


fix: Do not include organoid term_id as a descendant of term_id

Reason for Change
Do not include organoid term_id as a descendant of term_id. Example:
"UBERON:0001987": [
    "UBERON:0000453",
    "UBERON:0001987 (organoid)",
    "UBERON:0002450"
  ]

should be
"UBERON:0001987": [
    "UBERON:0000453",
    "UBERON:0002450"
  ]

Changes

modify descendant mapping logic to not include organoid self as an ontology term_id

Testing steps

updated tests

Notes for Reviewer

not needed


fix virtualcluster deploy yaml and virtualcluster controller bug

What type of PR is this?
/kind bug

What does this PR do?
fix virtualcluster deploy yaml and virtualcluster controller bug

Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

/hold

hold for discuss

/lgtm
/approve


perf: improve iterator

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe: improve iterator

Does this PR introduce a breaking change? (check one)

[x] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch, not the main branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

34 of 34 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1297

Relevant Lines:
1297

💛  - Coveralls


Adding an MCP backend to Mixer [Galley Integration]

This PR introduces an MCP-based backend to Mixer, that can perform demultiplexing of legacy Mixer resources.
THIS IS BLOCKED ON, AND CONTAINS: https://github.com/istio/istio/pull/7458. Please review it first.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]
mixer/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbce7e676d310fb93f883434ae4bbe777247376c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbce7e676d310fb93f883434ae4bbe777247376c
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
fbce7e676d310fb93f883434ae4bbe777247376c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [geeknoid,ozevren]
mixer/OWNERS [geeknoid,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
68fef55125eb9ae7b89e056fff3125342bfa56b3
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Wrong or missing translation

Some string are missing from the translation package . like
loading... , no item found, row found , <> of the <>,....

As per the Localization docs:

Note: Some components don't support localization yet. Contributions are welcome!

This package contains all translation keys currently available and will be updated once more are added. If you want to have a specific component translated, please open an issue for that component in the MudBlazor repo.

actually i need to get  the translation to the MudDataGridPager and MudTableGridPager
public sealed class AppDataGridPager : MudDataGridPager
{
protected override void OnParametersSet()
{
AllItemsText = "Tous";
RowsPerPageString = "Lignes par page";
PageSizeOptions = [10, 20, 50, 100, 500];
InfoFormat = "{first_item}-{last_item} de {all_items}";
base.OnParametersSet();
}

So what is the issue? They're already translated.

I Saw in the translation , but it 'not functioning . the column sort order is ok but not de pager

I can only help you If you explain what your issue is. Please elaborate:

Which language are you using
What are you expecting to happen
What is actually happening
Add a screenshot

hello ,  I'm using c#  in french language.
First screenshot show the translation is active in the datagrid column

in my second screenshot the first row show my own overload of the pager  the second row is  standard line of the pager without tranlsation

the code of my pager is
public sealed class AppDataGridPager : MudDataGridPager
{
protected override void OnParametersSet()
{
AllItemsText = "Tous";
RowsPerPageString = "Lignes par page";
PageSizeOptions = [10, 20, 50, 100, 500];
InfoFormat = "{first_item}-{last_item} de {all_items}";
base.OnParametersSet();
}
}

The relevant changes were added in 3673fe205297e7ff5a973de6576a4bc8e9adea2f which was not released yet.
Please upgrade to the new release v1.1.0 which includes these translations.

It is ok
Thanks for the reactivity.


stm32h7: CSI as PLL source is broken

Describe the bug
Due to missing definition STM32_PLL_SRC_CSI, CSI can't be used as PLL source on stm32h7

Closing since #41431 is now merged


Some font size changes not working correctly

@klepp0906 says: in the name of being thorough, also some of the font size changes arent working.

Can youngive me some examples?
Do the font size changes just not work at all or do they fail to save and be reapplied on next login?

its looking like the vast majority (maybe even all) arent working at current for me.  my numeric ones are some othe standouts that i try to get to work most frequently.  My white damage is extremely small and my crit dmg is barely bigger than regular dmg yet the slider is maxed at 64 p
speaking of, that font also is stuck w/ the default, wont change to the (svui dialog font) which I have it set as.


I started the cmd its brought me back to a website with camouflache I select but it does nothing in games

I'm still not sure what you mean, @sofiane6700? This tracker is completely separated from the game itself, nothing you change in the tracker will reflect in-game, and vice versa. I'm not sure what cmd you're referring to either?

Closing again due to inactivity. If you open another issue, please describe the issue in detail.


No --path flag available for migrate:rollback or migrate:reset

If you run a migration with the --path flag pointing to a non-standard folder, the up methods all run just fine from the new location. However, if you want to roll these migrations back, there is no option to specify the --path again so that the rollback can successfully run.

This is a duplicate. Sorry. Please check existing issues first.


Click People to Battle

What are you using to click the people to start the battles? I'm new to c# and looking at the code real quick I cant seem to find which image you're using to select the people to start the battles?
I'm looking to contribute and update the project :)

I made an active bot project for PC at https://github.com/AchmadFathoni/Duellink-PC-Bot. Its still far for complete but I promise to update it every three days.

Previously I used images of the people (duelist NPCs) to start the battle, but found that the images weren't working because of the different image sizes based on how far away the NPC was on the screen. Basically using the exact pixels in the pictures of the duelists proved to be inefficient and buggy.
The bot, when it was working, used color detection to set the start point of where it will click. Then it clicked horizontally across the screen, hoping to pick up a duelist, item, or whatever. It then detected when the "Duel" button is showing (meaning a NPC was clicked) and clicks on that button, then goes through the duel by finding the auto-duel button and waiting for the duel to end.


Ldanzinger/10015 patch

@mfeigl please review. Qt team is updating version to always include patch to make things easier when a patch release is created. Also, renamed calcite project file from calite to calcite

@mfeigl good call, updated those tests too. Strange, I did use git mv...


New Theme : hugo-owaraiclub

Theme submission
Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. Please tick the relevant boxes for your theme in the checklist below:
Link to my theme repository: https://github.com/tcgriffith/hugo-owaraiclub
I made sure that...

[x] the repository contains a good README.md describing my theme
[x] an open source license has been added to LICENSE.md
[x] all metadata have been added to theme.toml
[x] screenshots have been added in the images/ folder with the required dimensions
[x] in case I'm using a customized demo via the exampleSite folder that

[x] https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
[x] I tested that my theme's demo works with the content directory of gohugoio/HugoBasicExample

[x] I tested my theme against the gohugoio/HugoBasicExample

[x] I've checked the developer tools' console in my browser for error messages

[x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. You will need to keep an eye on whether your theme's demo generates on the Hugo website, whenever there is a new release. We are a very small team and we just cannot keep up opening issues in the various theme repositories to notify authors. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.
Feel free to ask questions. We're glad to help.

Hello @tcgriffith
Thank you for the theme submission.
I tested your theme with the Hugo Themes Build Script and its demo generates fine.
However since Hugo uses semver versioning please change line 8 of theme.toml to min_version = "0.58.0"
Once you do the above please let me know.

Done.

@tcgriffith
Everything looks fine on my end.
Once the tests for pull request #743 succeed, I will add the theme to the Hugo website.

@digitalcraftsman
This is a fork of the X-Mag theme that has been re-written and it comes with support for multiple authors.

I've promoted your theme on Hugo's official Twitter account.

Thanks! @digitalcraftsman


[iOS] when triggering action based message extensions the linkToMessage is broken

User presses Teams message on iOS and swipes to action based message extensions and selects bot
Bot receives composeExtension/fetchTask with the following payload (using nodejs):
  name: 'composeExtension/fetchTask',
  type: 'invoke',
<....>
  value: {
    messagePayload: {
      id:<PHONE_NUMBER>681,
      replyToId:<PHONE_NUMBER>681,
      linkToMessage: 'https://teams.microsoft.com/message/19:3a46e4de-c1ff-47b8-b750-17522bc7e33e_43f42ce3-2829-4fdc-ae94-06b15786804a@unq.gbl.spaces/1645075697681?{\n' +
        '    context =     {\n' +
        '        contextType = chat;\n' +
        '    };\n' +
        '}',

Please fix the linkToMessage attribute and remove the newlines, the spaces, the { after ? and the } in the end. It works fine on Android.

@matthiasdilger - Could you please elaborate more on your ask?

@Prasad-MSFT
The issue is an invalid URL in linkToMessage when the action based message extension is triggered in Teams iOS. It looks like formatted code, including newlines and whitespace, has been added to the message URL instead of url encoding it properly. A correct linkToMessage is very helpful so that the bot can later show to the user where the action originated from or for other programs to link into Teams to the specific message.
To reproduce:
User triggers action based message extension on Teams iOS

Bot receives composeExtension/fetchTask with the following payload (using nodejs):
  name: 'composeExtension/fetchTask',
  type: 'invoke',
<....>
  value: {
    messagePayload: {
      id:<PHONE_NUMBER>681,
      replyToId:<PHONE_NUMBER>681,
      linkToMessage: 'https://teams.microsoft.com/message/19:xxx@unq.gbl.spaces/1645075697681?{\n' +
        '    context =     {\n' +
        '        contextType = chat;\n' +
        '    };\n' +
        '}',

Even after cleaning the newlines and whitespace from the URL it still is invalid:
https://teams.microsoft.com/message/19:xxx@unq.gbl.spaces/1645075697681?{context={contextType=chat;};}

Doing the same task in Teams web or desktop sends this linkToMessage to the bot:
https://teams.microsoft.com/l/message/19:xxx@thread.v2/1645141670752?context=%7B%22contextType%22:%22chat%22%7D

which is the correct way. ✅
My ask: Please make Teams iOS send a correct URL in linkToMessage when an action based message extension is triggered, just like Teams does on web and desktop.

@matthiasdilger - We are able to repro the issue and we have raised a bug for this. We will inform you once we get any update from Engineering Teams. Thanks!

This issue has been fixed, thanks


Running as a GPO

How do you set this script up to run as a Group Policy Object when the user logs on? I have tried several ways but no luck...

There are some hints on usage in multiuser environment here - https://github.com/Disassembler0/Win10-Initial-Setup-Script/issues/29#issuecomment-333040591.
In domain environments, I suggest using the actual GPOs and push the rest of the registry keys for which there are no GPOs like this.


fix for missing overlapping blocks from selectOverlappingDirs

fixes https://github.com/prometheus/tsdb/issues/554
Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

cc  @naivewong

This is needed once https://github.com/prometheus/tsdb/pull/560 is merged?

nope I opened this PR first, but than @naivewong came up with another solution so it is one or the other.

The other PR has advanced more so closing this one for now.


Language List

While the Kroki diagram list is comprehensive, figuring out which language the codeblock wants is not intuitive. For example, C4 Plantuml and Plantuml are c4plantuml and kroki-plantuml respectively. How are we intended to guess which one?
Additionally, while an example is provided, it's hundreds of lines long! Not ideal for figuring out which language I'm supposed to specify.
Please amend the plugin documentation to assist with genuine usage.

The differences between c4plantuml and kroki-plantuml are unknown to me and are not the concern of the plugin.  Links to each language's specifics are given in the settings.  LMK if I am misunderstanding your concern.
As for the long example, I don't disagree.  If you'd like to make a PR with them split out, I promise to promptly merge it. :)