First time setup of framework repository doesn't work

@turnidge and I were following our official directions:
https://github.com/flutter/flutter/wiki/Setting-up-the-Framework-development-environment
and after doing everything on the page we tried to do a simple 'flutter create' and it ended up with:
turnidge@mumak workspace % flutter create honorfarm
Creating project honorfarm...
Resolving dependencies in `honorfarm`...
Note: leak_tracker_flutter_testing is pinned to version 3.0.5 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.
The current Flutter SDK version is 0.0.0-unknown.
Because every version of flutter_test from sdk depends on leak_tracker_flutter_testing >=2.0.3 which requires Flutter SDK version >=3.18.0-18.0.pre.54, flutter_test from sdk is forbidden.
So, because honorfarm depends on flutter_test from sdk, version solving failed.
turnidge@mumak workspace %

My questions:

How did we get into this state and precisely how do we exit it?

We ended up switching git branches (between upstream/main and origin/main) didn't help.
We ran 'flutter channel main' and that ended up downloading hundreds of mbs of stuff that we don't actually need and didn't have enough time to see if this would have resolved the problem.

What is missing from our "Setting up the Framework development environment?"
How are we testing this on-boarding flow?

But, even if 'flutter channel main' fixes the issue this experience has been absolutely terrible and without my guidance Todd would have just given up and moved on with his life.

Can you post the output of flutter doctor -v?

How are we testing this on-boarding flow?

They are not tested. Any suggestions for how to test this documentation?
I followed these instructions about a month ago to set up my new mac, though.

that ended up downloading hundreds of mbs

At some point during the setup these dependencies have to be downloaded, otherwise Flutter will not work. Usually, this happens when you run flutter update-packages from the instructions. Did that happen and go through?

How did we get into this state and precisely how do we exit it?

From the information given in the bug its not clear what state you're in (the output of flutter doctor -v could help).

Here's the current output. Let me know if you want me to scroll up and get the output from earlier in the session.
[!] Flutter (Channel [user-branch], 3.22.0-27.0.pre.20, on macOS 13.6.6 22G630 darwin-arm64, locale en-US)
    ! Flutter version 3.22.0-27.0.pre.20 on channel [user-branch] at /Users/turnidge/workspace/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at
      https://flutter.dev/docs/get-started/install.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
    • Framework revision 1c7e6a401e (8 hours ago), 2024-05-08 12:59:10 -0400
    • Engine revision f3ce5a59c2
    • Dart version 3.5.0 (build 3.5.0-131.0.dev)
    • DevTools version 2.35.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to
      perform update checks and upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/turnidge/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✗] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.
      Download at: https://developer.apple.com/xcode/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    ✗ CocoaPods not installed.
        CocoaPods is a package manager for iOS or macOS platform code.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      For installation instructions, see https://guides.cocoapods.org/using/getting-started.html#installation

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.6.6 22G630 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 124.0.6367.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 3 categories.```

Todd and I started looking at this issue again today.
We tried blowing away the flutter/flutter checkout and cloning again but the issue persisted.
Eventually we found https://github.com/flutter/flutter/issues/98020, which suggested we do the following:
git remote set-url upstream https://github.com/flutter/flutter.git
Running that command got the flutter tool out of the bad state and the flutter channel started to correctly report master/main instead of [user-branch]
I couldn't reproduce this in my usual environment, so, I created a new GitHub account that wasn't part of the organization.
Doing a fresh clone of the repository gave me the following output from flutter doctor:
[!] Flutter (Channel master, 3.22.0-35.0.pre.11, on macOS 14.4.1 23E224 darwin-arm64, locale en)
    ! Upstream repository git@github.com:cutchtemp/flutter.git is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to git@github.com:cutchtemp/flutter.git to dismiss this error.

So it seems related to using ssh:/ GitHub URLs when we aren't part of the Flutter organization.

❯ flutter create honor
Downloading Darwin arm64 Dart SDK from Flutter engine bf1c6da0dd31273405ae4107ba7225238686140b...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  201M  100  201M    0     0  50.4M      0  0:00:03  0:00:03 --:--:-- 50.4M
Building flutter tool...
Resolving dependencies...
Downloading packages...
Got dependencies.
Downloading Material fonts...                                      238ms
Downloading Gradle Wrapper...                                       27ms
Downloading package sky_engine...                                   87ms
Downloading flutter_patched_sdk tools...                           115ms
Downloading flutter_patched_sdk_product tools...                   110ms
Downloading darwin-arm64 tools...                                1,462ms
Downloading libimobiledevice...                                     31ms
Downloading usbmuxd...                                              21ms
Downloading libplist...                                             31ms
Downloading openssl...                                              71ms
Downloading ios-deploy...                                           40ms
Downloading darwin-arm64/font-subset tools...                      108ms
Creating project honor...
Resolving dependencies in `honor`...
Note: leak_tracker_flutter_testing is pinned to version 3.0.5 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

The current Flutter SDK version is 0.0.0-unknown.

Because every version of flutter_test from sdk depends on leak_tracker_flutter_testing >=2.0.3 which requires Flutter SDK version >=3.18.0-18.0.pre.54, flutter_test from sdk is forbidden.
So, because honor depends on flutter_test from sdk, version solving failed.

❯ flutter run
Downloading android-arm-profile/darwin-x64 tools...                324ms
Downloading android-arm-release/darwin-x64 tools...                130ms
Downloading android-arm64-profile/darwin-x64 tools...              159ms
Downloading android-arm64-release/darwin-x64 tools...              138ms
Downloading android-x64-profile/darwin-x64 tools...                127ms
Downloading android-x64-release/darwin-x64 tools...                136ms
Downloading Web SDK...                                           1,180ms
Downloading darwin-x64/framework tools...                          809ms
Downloading darwin-x64/gen_snapshot tools...                       243ms
Downloading darwin-x64-profile/framework tools...                  496ms
Downloading darwin-x64-profile tools...                            123ms
Downloading darwin-x64-profile/gen_snapshot tools...               242ms
Downloading darwin-x64-release/framework tools...                  348ms
Downloading darwin-x64-release tools...                            118ms
Downloading darwin-x64-release/gen_snapshot tools...               208ms
Resolving dependencies...
Note: leak_tracker_flutter_testing is pinned to version 3.0.5 by flutter_test from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.

The current Flutter SDK version is 0.0.0-unknown.

Because every version of flutter_test from sdk depends on leak_tracker_flutter_testing >=2.0.3 which requires Flutter SDK version >=3.18.0-18.0.pre.54, flutter_test from sdk is forbidden.
So, because honor depends on flutter_test from sdk, version solving failed.

To reproduce this issue do the following:

Create a GitHub account that isn't part of the Flutter organization.
Add an ssh-key to this account.
Fork flutter/flutter
Clone your fork via<EMAIL_ADDRESS>URL
flutter create test_app; cd test_app
flutter run

Thanks for digging into that. I've updated the instructions for now to tell people about potential issues with SSH. Will have to do some digging why SSH vs HTTPS matters here and why there's a difference between in-org and out-of-org accounts.

I had some time to dig into this. There are a couple of things at play here, so bear with me while I lay them all out.
The protocol (SSH vs HTTPS) and whether or not an account is part of the Flutter organization are red herrings.
The provided repro steps will always fail because they are missing crucial steps that were outlined on the setup wiki page before I just updated it: Namely, adding the upstream repository (git remote add upstream git@github.com:flutter/flutter.git), fetching tags (git fetch upstream), and updating dependencies (flutter update-packages). Without these, flutter run is never gonna work.
However (and I suspect this is were things originally went off the rails during the initial setup here), even if you followed those instructions to the letter there are some pitfalls that I discovered while debugging this:

flutter update-packages can fail silently, which is easy to miss because in certain situations it literally doesn't print any failure message. If it fails, flutter run will then also fail in mysterious ways. My suspicion is that you may have unknowingly run into that issue here. I've filed https://github.com/flutter/flutter/issues/148569 with the tools team to track and fix this.
Furthermore, even when you recognize that it is failing silently because of missing tags, fetch the tags, and then run update-packages again it may operate on outdated data and hence fail again. I've filed https://github.com/flutter/flutter/issues/148571 for that issue with more details.

Having said all that, I also just re-wrote the setup instructions in a way that removes both of these pitfalls from the critical path so the chances of success are much higher. Please take a look and let me know if something is unclear or not working (I appreciate it if you'd include full console logs with commands executed and their output in any issue report. That makes these kind of bugs much more actionable. Often, it is also helpful to get the verbose output with -v of these commands as that may contain additional hints of what's going wrong.)
Anyways, again sorry for the trouble and hopefully you'll have a good time with Flutter now.

Thanks for the updated documentation!


Idea: return ConsumedCapacity 'stats' for Write operations

Hey team!
Summary
I'm optimizing Dynamo writes for a write-heavy workload, and I wanted to make a case for adding support for WriteUnits to the stats API parameter. The OneTable documentation (stats param) suggests this is only for find/query/scan operations for now, and it would be great to have it for Write operations (e.g. DeleteItem, PutItem, UpdateItem, BatchWriteItem).
Motivation
Why this may be helpful to others:

Writes cost more than reads, per unit
Write Units may not be intuitive, especially for deletions or update expressions

Writing a 1 character field writes the whole entry (ie 1 byte may cause > 1 WCU write)
Indexes affect overall write usage

Estimations are helpful, but not as precise as empirical measurements with AWS counts

Or if someone can guide me to the place in the codebase where the change should be made, and it's quick enough, maybe I/someone else can find some time to submit a Pull Request.
Code Sample
Example Output with ConsumedCapacity when calling DeleteItem and PutItem:
/** Output via raw Dynamo lib, of the code snippet below:
 * Starting: dynamoWriteExperiments.ts
 * Deletion: { ConsumedCapacity: { TableName: 'example', CapacityUnits: 2 } }
 * Creation { ConsumedCapacity: { TableName: 'example', CapacityUnits: 2 } }
 */

Code sample using underlying AWS SDK:
import DynamoDB from "aws-sdk/clients/dynamodb";

const dynamodb = new DynamoDB({ region: "us-east-1" });
const table = "example";
const keys = { pk: { S: "pk1" }, sk: { S: "sk1" } };

const createParams = {
  Item: {
    ...keys,
    str: { S: new Array(2_000).join("0") }, // Generate 2k string of 0's
  },
  ReturnConsumedCapacity: "TOTAL",
  TableName: table,
};

// Deletion returns write units
const deletion = await dynamodb.deleteItem({
  Key: keys,
  ReturnConsumedCapacity: "TOTAL",
  TableName: table,
}).promise();
console.log("Deletion:", deletion);

// PutItem returns write units
const creation = await dynamodb.putItem(createParams).promise();
console.log("Creation", creation);

Thank you. That is actually an easy fix.
Will apply.

Awesome, thanks @mobsense!


Add a healthcheck for technical failures of delivery attempts

https://trello.com/c/sehNMIbL/339-make-healthcheck-test-for-technicalfailure
Alerts in Icinga:

You raise a good point. We should keep all DeliveryAttempts and that would mean the alert hangs around for a day unless it's ack'ed.
Maybe I should only check the last DeliveryAttempt for an email so that if one gets successfully delivered the technical failure is ignored?

Oh yeah, that sounds like a better check. Something that is more like "if there is an email which has only 'technical_failure' delivery attempts".

@thomasleese: I've added https://github.com/alphagov/email-alert-api/pull/235/commits/e8c6d66ba0dba25ae381e3ce6a2f917b7c3cd7af to address your comment.


error when loading a frozen biggan model

error message
Traceback (most recent call last):
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\framework\importer.py", line 418, in import_graph_def
    graph._c_graph, serialized, options)  # pylint: disable=protected-access
tensorflow.python.framework.errors_impl.InvalidArgumentError: Input 0 of node import/module_apply_default/cond/AssignVariableOp/Switch was passed float from import/module/prev_truncation:0 incompatible with expected resource.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:/python/biggan/optimize_model.py", line 18, in <module>
    tf.import_graph_def(gd)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\util\deprecation.py", line 488, in new_func
    return func(*args, **kwargs)
  File "C:\Anaconda3\lib\site-packages\tensorflow\python\framework\importer.py", line 422, in import_graph_def
    raise ValueError(str(e))
ValueError: Input 0 of node import/module_apply_default/cond/AssignVariableOp/Switch was passed float from import/module/prev_truncation:0 incompatible with expected resource.

Process finished with exit code 1

code to recreate
import tensorflow as tf
import tensorflow_hub as hub
import os

with tf.Session() as sess:
    module = hub.Module('https://tfhub.dev/deepmind/biggan-128/2')
    sess.run(tf.global_variables_initializer())
    inputs = {k: tf.placeholder(v.dtype, v.get_shape().as_list(), k) for k, v in module.get_input_info_dict().items()}
    output = module(inputs)
    converted_graph_def = tf.graph_util.convert_variables_to_constants(sess, sess.graph_def, [output.name.replace(':0','')])
    tf.train.write_graph(converted_graph_def, 'c:/temp/saved1', 'frozen_model.pb', as_text=False)

tf.reset_default_graph()
with tf.Session() as sess:
    with tf.gfile.GFile(os.path.join('c:/temp/saved1', 'frozen_model.pb'), 'rb') as f:
        gd = sess.graph_def
        gd.ParseFromString(f.read())
        tf.import_graph_def(gd)

it works fine for other modules. the advice here did not help either: https://github.com/tensorflow/tensorflow/issues/3628

@eyaler  Please provide the exacts steps you followed and a sample code snippet to reproduce the error. This would help to look into the issue and understand it clearly.

Hi, this seems like an issue of tf.graph_util.convert_variables_to_constants.
It is producing a GraphDef that cannot be loaded back, the reason seems to be that the switch statement expects a variable, not a constant.
Please try to find a corresponding issue here: https://github.com/tensorflow/tensorflow/issues?utf8=✓&q=convert_variables_to_constants+
If you don't find the same, you can either use https://github.com/tensorflow/tensorflow/issues/25721 or file a new one.

@hgadig provided above

@eyaler: I share vbardiovskyg's view that this looks like a problem with processing the graph in tf.graph_util.convert_variables_to_constants(), not an issue with TF Hub and how it helps build the graph. Can this be closed for tensorflow/hub?

cannot the switch statement be changed to something that is compatible with current tf.graph_util.convert_variables_to_constants() ?

With all due respect, I think that is an issue in core TF and its convert_variables_to_constants, not TF Hub.


WIP: Feature: MFA

Adds mfa routes by @tknoelle

@tknoelle @benjohnde @Ingwersaft Would you add a convenience method for the qr code generation, or do you think this should get handled outside of the library?

If it's not too much work getting this done here it would be awesome to have this :)

Just looked into it: there's no multiplatform solution for qr code generation. We could use https://github.com/g0dkar/qrcode-kotlin for jvm and android to avoid depending on zxing. For iOS I could create the qr code with platform calls. For js I'd need to import an npm library.


Web Socket Endpoints for querying in Pinot Broker

Currently, we have REST API endpoints in pinot broker for querying. However, adding a WebSocket endpoint helps with having low latency & high throughput queries once the connection is established between the pinot broker and the client service.
Use Case:
Using WebSocket to connect to a Pinot table that is being populated from a Kafka topic / some streaming source. By not directly connecting to the Kafka topic, we can take advantage of data manipulation and efficient filtering, and aggregation features in  Pinot. This approach provides more control and flexibility over the data flow and analysis process.
label: feature
cc : @atris @kishoreg @Aravind-Suresh
Related Slack Discussion : https://apache-pinot.slack.com/archives/CDRCA57FC/p1687701635253309

thanks for creating this proposal. Can we add some additional details..

will this be a standing query..
will the connection return something only when there is a change in response?
or is it periodic
is it going to incremental? That return only the changes from previous response? For e.g it's a filter query and the client is only interested in new rows that match the filter criteria.

@kishoreg  Thanks for the questions.

The initial version of WebSocket Endpoint won't be for the standing queries. Web Socket would serve as one additional interface ( than existing REST API way) for an external system to connect and query in Pinot, here we save the connection establishment time for each HTTP request . The client is expected to give any queries as we currently have with REST API.
The additional use cases of making it support standing queries to period response/return after a change in data ( with a periodic check at pinot ) can be added once the underlying web socket interface is there. This would be a nice feature to support at Pinot as it removes the work at the client system ( particularly data viz. applications ) to periodically call Pinot.
For incremental results bounded to standing queries, we can this support once point 2 is made.  Here we can utilise the time field of real-time data flowing in & a WebSocket connection at the pinot broker end can maintain the state of the last timestamp it served.

@atris Please add if I am missing any points.

Like the phased approach.


Assets and nfts improvements in sdk

Current behavior
The method sdk.asset.download require to DDO to have the service access to download the asset and the API of sdk.nft721 require load a contract in order to use methods like access however such contract is not  used for theses methods
Expected behavior

[x] sdk.asset.download shouldn't require service access to DDO
[ ] sdk.nft721 should have available all the methods that doesn't require to load a contract for their logic

NFT721Api require the loading of the contract because there is no a default contract deployed, the user needs to be specific about the nft-721 to use.
This is better because avoid potential errors of the api


Additional lights, what wave length?

Required Info

Camera Model
{ D400 }

Hi,
I have an application with the D435 and I also use a second camera for video capture. We need to illuminate the video with additional IR lights during the night to get a good video.
I can get this additional illumination with 850 or 940 nm wavelength. Would extra light source of 850nm disturb the Realsense IR-projector and readings more than the 940nm?
Does anyone have experience with this?

Intel's illustrated camera tuning guide says in its section about external projectors: "It is possible to use light in visible or near-infrared (ranging from ~400-1000 nm).  Example: 850 nm is invisible to the human eye whilst still being visible to the IR sensor".
This would suggest that either 850 or 940 nm light should be okay.  One of the Intel guys on this forum can confirm that for you though.
The full tuning guide can be viewed at the link below.
https://realsense.intel.com/wp-content/uploads/sites/63/BKM-For-Tuning-D435-and-D415-Cameras-Webinar_Rev3.pdf?language=en_US

Thank you for your reply.
Maybe the question was not so clear. I was asking if a extra light source of 850nm or 940nm would affect the Realsense camera in different ways or if it didn't matter. The IR projector is emitting at about 850nm, so my first thought would be that a 940nm extra light source would be better. But the other camera used in the system is better at "seeing" 850nm.

The RealSense camera sees both so in that way it does not matter, but there are some subtle aspects to consider. 1. If the scene has a lot of texture (not just flat white walls) then any uniform illumination actually helps the camera. However 2. The RealSense camera is less sensitive to 940nm so if you don’t want the RealSense camera to see the light this might be better to use. 3. You should consider what you want from the other camera - do you want to see the IR projector dots from the RealSense camera? If not then use 940nm and add a long pass filter to that camera.


Wrap long platform configurations

whatfeatures chrono -d

chrono/0.4.9
  features
    default: clock
    clock: time
    wasmbind: wasm-bindgen, js-sys
  dependencies
    normal
      libc                = ^0.2
      num-integer         = ^0.1.36
      num-traits          = ^0.2
      optional
        js-sys            = ^0.3    if cfg(all(target_arch = "wasm32", not(target_os = "emscripten")))
        rustc-serialize   = ^0.3.20
        serde             = ^1
        time              = ^0.1.39
        wasm-bindgen      = ^0.2    if cfg(all(target_arch = "wasm32", not(target_os = "emscripten")))
    dev
      bincode             = ^0.8.0
      doc-comment         = ^0.3
      num-iter            = ^0.1.35
      serde_derive        = ^1
      serde_json          = ^1
      wasm-bindgen-test   = ^0.2    if cfg(all(target_arch = "wasm32", not(target_os = "emscripten")))

it should split the attributes to fit within the BoundingBox

Not applicable anymore since 576d74f11d17614cdbf7096bbf110afbadeef9e6


Added couple of notes for minikube

-Taints prevent core-dns pods from getting scheduled
-core-dns pods are in Initializing state and get to
Running state after Cilium is installed
Signed-off-by: Arvind Soni<EMAIL_ADDRESS>

This change is

test-docs-please

worked fine this time.


Notify decrypt errors

Summary: Send a non-fatal error message through the gst pipeline and propagate the error up to the application in a new PlaybackError API.
Type: Feature
Test Plan: Unittests, Component Tests, Fullstack builds.
Jira: RIALTO-463

https://jenkins.code.rdkcentral.com/job/github-triggered/47723/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13273/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47726/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19613/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13276/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47728/ started

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/184/

https://jenkins.code.rdkcentral.com/job/github-triggered/47730/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47733/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47735/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47742/ started

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/60be7765875da6461f4d8e1d8f50344e

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/52935b8102c4d58284098e3807b0d6d4

https://jenkins.code.rdkcentral.com/job/github-triggered/47756/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13290/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19620/ started.

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/188/

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/094e5ff0b0498eeac86136ba9137c376

https://jenkins.code.rdkcentral.com/job/github-triggered/47847/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47851/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47852/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47854/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47855/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13352/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47857/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19733/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/47858/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13354/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19737/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/47860/ started

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/7da76d6451eae815f6d7de2f02611a7b

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/3db40cf0f982ae0c44b5f5d0f9901241

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13369/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47887/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19750/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/47890/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47892/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/47894/ started


[FLINK-12203] Refactor ResultPartitionManager to break tie with Task

What is the purpose of the change
The PR is based on #8133.
At the moment, we have ResultPartitionManager.releasePartitionsProducedBy which uses indexing by task in network environment. These methods are eventually used only by Task which already knows its partitions so Task can use ResultPartition.fail(cause) and TaskExecutor.failPartition could directly use NetworkEnviroment.releasePartitions(Collection). This also requires that JM Execution sends produced partition ids instead of just ExecutionAttemptID.
Later NetworkEnviroment.releasePartitions(Collection) could be refactored into ShuffleService.releasePartitions(Collection).
Brief change log

Change Execution to send partition ids instead of execution id to release task produced partitions
Change interface of TaskExecutorGateway.failPartition to releasePartitions
Index partitions by ResultPartitionID in ResultPartitionManager

Verifying this change
The change is simple refactoring and should be addressed by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot attention @tillrohrmann @zhijiangW

Thanks for the reviews @tillrohrmann @zhijiangW ! I've pushed a commit to address them

@tillrohrmann I have pushed fix, I will monitor travis build until it is mergable

@tillrohrmann PR should be good to go now.


Filter out Cloudflare error pages + performance improvement

Happy New Year! 🎉
This PR adds a new -filter-cf-errors flag to httprobe which causes it to read the first 512 bytes from listening servers in order to determine if they are a "wildcard" response from Cloudflare like the ones shown here:

If a Cloudflare signature string is found, the function returns false to treat it as not listening. The functionality is implemented in a generic fashion so that it can easily be extended to filter out other common false-positive responses.
The PR also implements a small performance improvement by performing a DNS lookup on incoming domains and ignore the unresolvable ones to avoid filling up the job channels with dead domains. I timed the execution with a list containing 1483 resolveable and unresolvable domains with the large port list and was able to shave off 7 minutes of execution time, which is not a lot, but also not insignificant:
cat hosts.txt | time httprobe -t 2000 -p large
httprobe -t 2000 -p large  10.73s user 10.15s system 0% cpu 47:13.08 total

cat hosts.txt | time new-httprobe -t 2000 -p large
new-httprobe -t 2000 -p large  12.39s user 11.03s system 0% cpu 40:10.77 total

cat hosts.txt | time new-httprobe -t 2000 -filter-cf-errors -p large
new-httprobe -t 2000 -filter-cf-errors -p large  13.13s user 10.86s system 0% cpu 40:00.91 total

@tomnomnom I came across the httpx project by Project Discovery and noticed that the tool has support for filter strings with  the -filter-string and -filter-regex flags. Would you be interested in having a similar feature for httprobe? If so, I will gladly refactor this PR to implement more generic filtering instead of the Cloudflare-specific filtering. :)

@tomnomnom I came across the httpx project by Project Discovery and noticed that the tool has support for filter strings with  the -filter-string and -filter-regex flags. Would you be interested in having a similar feature for httprobe? If so, I will gladly refactor this PR to implement more generic filtering instead of the Cloudflare-specific filtering. :)


CHEF-2652: backward-compatibility hack to ease migration from old config...

... files.

Merged to 0.10.6-rc


Update module docstring for core.py

https://github.com/NRL-Plasma-Physics-Division/turbopy/blob/9c11b9773b952045f5418c4c3bdf6023d7525a89/turbopy/core.py#L4
The module-level docstring for core.py needs to be update.

addressed in PR #87


Quantization appears to be broken, at least for AWQ and BnB

System Info
I have tried the following Lorax versions:
(official version) ghcr.io/predibase/lorax:0.12
(locally compiled) lorax:69bb989
CUDA:
12.4
12.6
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction

Obtain a AWQ or BnB quantized model, such as https://huggingface.co/unsloth/Meta-Llama-3.1-8B-bnb-4bit or https://huggingface.co/hugging-quants/Meta-Llama-3.1-8B-Instruct-AWQ-INT4
Using otherwise default settings, configure Lorax to use a quantized model

Expected behavior
I would expect Lorax to start normally, like when using a non-quantized model.  However, I have tried several different versions of AWQ and BnB 4bit models, different versions of Lorax, and CUDA/Drivers, all of which fail.
Example errors (also seen in other issue requests):
AWQ: "ValueError: too many values to unpack (expected 3)"
BnB: "AssertionError: [12582912, 1] != [6144, 4096]"
**Full AWQ Error:
2024-12-21T13:26:16.679407Z  INFO shard-manager: lorax_launcher: Starting shard rank=0
2024-12-21T13:26:25.250809Z ERROR lorax_launcher: server.py:317 Error when initializing model
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 92, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 449, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
self._run_once()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
handle._run()
File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)

File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 302, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 186, in get_model
return FlashLlama(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_llama.py", line 40, in init
super().init(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 1119, in init
model = model_cls(prefix, config, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 570, in init
self.model = FlashLlamaModel(prefix, config, weights, create_layer_fn)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 499, in init
[
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 500, in
create_layer_fn(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 431, in init
self.self_attn = FlashLlamaAttention(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 265, in init
self.query_key_value = load_attention(config, prefix, weights, layer_id)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 162, in load_attention
base_layer = load_attention_multi(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 179, in load_attention_multi
return _load_gqa(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 202, in _load_gqa
weight, input_scale, weight_scale = weight
ValueError: too many values to unpack (expected 3)

2024-12-21T13:26:26.400592Z ERROR shard-manager: lorax_launcher: Shard complete standard error output:
2024-12-21 13:26:20.746 | INFO     | lorax_server.utils.state::22 - Backend = fa2
2024-12-21 13:26:20.746 | INFO     | lorax_server.utils.state::24 - Prefix caching = False
2024-12-21 13:26:20.746 | INFO     | lorax_server.utils.state::25 - Chunked prefill = False
/opt/conda/lib/python3.10/site-packages/torch/distributed/c10d_logger.py:79: FutureWarning: You are using a Backend <class 'lorax_server.utils.dist.FakeGroup'> as a ProcessGroup. This usage is deprecated since PyTorch 2.0. Please use a public API of PyTorch Distributed instead.
return func(*args, **kwargs)
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 92, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 449, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 302, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 186, in get_model
return FlashLlama(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_llama.py", line 40, in init
super().init(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 1119, in init
model = model_cls(prefix, config, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 570, in init
self.model = FlashLlamaModel(prefix, config, weights, create_layer_fn)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 499, in init
[
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 500, in
create_layer_fn(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 431, in init
self.self_attn = FlashLlamaAttention(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 265, in init
self.query_key_value = load_attention(config, prefix, weights, layer_id)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 162, in load_attention
base_layer = load_attention_multi(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 179, in load_attention_multi
return _load_gqa(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 202, in _load_gqa
weight, input_scale, weight_scale = weight
ValueError: too many values to unpack (expected 3)
rank=0
2024-12-21T13:26:26.485424Z ERROR lorax_launcher: Shard 0 failed to start
2024-12-21T13:26:26.485464Z  INFO lorax_launcher: Shutting down shards
Error: ShardCannotStart
**Full BnB Error
2024-12-21T13:33:35.146822Z  INFO shard-manager: lorax_launcher: Starting shard rank=0
2024-12-21T13:33:43.387125Z ERROR lorax_launcher: server.py:317 Error when initializing model
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 92, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 449, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
self._run_once()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
handle._run()
File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)

File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 302, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 186, in get_model
return FlashLlama(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_llama.py", line 40, in init
super().init(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 1119, in init
model = model_cls(prefix, config, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 570, in init
self.model = FlashLlamaModel(prefix, config, weights, create_layer_fn)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 499, in init
[
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 500, in
create_layer_fn(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 431, in init
self.self_attn = FlashLlamaAttention(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 265, in init
self.query_key_value = load_attention(config, prefix, weights, layer_id)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 162, in load_attention
base_layer = load_attention_multi(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 179, in load_attention_multi
return _load_gqa(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 210, in _load_gqa
assert list(weight.shape) == [
AssertionError: [12582912, 1] != [6144, 4096]

2024-12-21T13:33:44.667486Z ERROR shard-manager: lorax_launcher: Shard complete standard error output:
2024-12-21 13:33:39.687 | INFO     | lorax_server.utils.state::22 - Backend = fa2
2024-12-21 13:33:39.687 | INFO     | lorax_server.utils.state::24 - Prefix caching = False
2024-12-21 13:33:39.687 | INFO     | lorax_server.utils.state::25 - Chunked prefill = False
/opt/conda/lib/python3.10/site-packages/torch/distributed/c10d_logger.py:79: FutureWarning: You are using a Backend <class 'lorax_server.utils.dist.FakeGroup'> as a ProcessGroup. This usage is deprecated since PyTorch 2.0. Please use a public API of PyTorch Distributed instead.
return func(*args, **kwargs)
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 92, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 449, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 302, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 186, in get_model
return FlashLlama(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_llama.py", line 40, in init
super().init(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_causal_lm.py", line 1119, in init
model = model_cls(prefix, config, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 570, in init
self.model = FlashLlamaModel(prefix, config, weights, create_layer_fn)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 499, in init
[
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 500, in
create_layer_fn(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 431, in init
self.self_attn = FlashLlamaAttention(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 265, in init
self.query_key_value = load_attention(config, prefix, weights, layer_id)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 162, in load_attention
base_layer = load_attention_multi(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 179, in load_attention_multi
return _load_gqa(config, prefix, weights)
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_llama_modeling.py", line 210, in _load_gqa
assert list(weight.shape) == [
AssertionError: [12582912, 1] != [6144, 4096]
rank=0
2024-12-21T13:33:44.753438Z ERROR lorax_launcher: Shard 0 failed to start
2024-12-21T13:33:44.753471Z  INFO lorax_launcher: Shutting down shards
Error: ShardCannotStart

The issue appears related to https://github.com/predibase/lorax/issues/595 and  https://github.com/predibase/lorax/issues/607, both closed, with no clear resolution.

Here is a another related case, https://github.com/predibase/lorax/issues/611 referencing container ghcr.io/predibase/lorax:07addea, which I could get to work with https://huggingface.co/hugging-quants/Meta-Llama-3.1-8B-Instruct-AWQ-INT4, but is very old.

The problem appears to be here:
if quantize in ["gptq", "awq"]:
...
weight = (qweight, qzeros, scales, g_idx, bits, groupsize, False)"
...
else:
...
return weight, input_scale, weight_scale
weight = torch.cat(weight_list, dim=dim)
...
https://github.com/predibase/lorax/blob/69bb989df8357fdc65bd5d8ce9df687baf521950/server/lorax_server/utils/weights.py#L120
"https://github.com/predibase/lorax/blob/69bb989df8357fdc65bd5d8ce9df687baf521950/server/lorax_server/utils/weights.py#L141
Weight can have a different number of parameters, which is not accounted for here:
https://github.com/predibase/lorax/blob/69bb989df8357fdc65bd5d8ce9df687baf521950/server/lorax_server/models/custom_modeling/flash_llama_modeling.py#L202


export default async function parsed as FunctionExpression

Input Code
export async function foo() {}
export default async function bar() {}

See https://astexplorer.net/#/V8ggvAMIw1
Babylon/Babel Configuration
Experimenting on AST explorer with babylon6-6.13.1 and all default options.
Expected Behavior
The second line should be parsed as an ExportDefaultDeclaration and a FunctionDeclaration.
Current Behavior
The second line is being parsed as an ExportDefaultDeclaration and a FunctionExpression.
A named export with a function declaration leads to FunctionDeclaration whenever it's regular, async or generator function.
But a default export with a function declaration leads to FunctionDeclaration only when it's regular or generator function. Async functions lead to FunctionExpression. I guess that's a bug.

Thanks for reporting I fixed it in #324

@mroch this is also an issue with flow, would be nice to get it fixed there as well :)

The fix was reverted, due to problems.

This works on babylon7:
https://astexplorer.net/#/gist/bd0c7fa15c96fe0553cb9961550d7ee3/latest


BSOD @ Ldr: Resolving kernel import

Hi,
I updated the DriverEntry and created DriverInitialize to match the Dummy.sys file, however whenever I use the loader to load my driver I end up blue screening at "Ldr: Resolving kernel import". Do you have any tips on checking what may be the cause for this blue screen?
Thanks!

Show your code. "Ldr: Resolving kernel import" is in user mode, it cannot bsod.

http://pastebin.com/Sg7Da23v

Rewrote the driver using the Dummy2 source as base, eventually got it to work! Closing out ticket, thanks.


[stable/redis] Add --no-auth-warning to health checks

What this PR does / why we need it:
Health checks currently show the warning message
Warning: Using a password with '-a' or '-u' option on the command line interface may not be safe which can be dismissed using the --no-auth-warning flag as mentioned in antirez/redis#5073
Continuation of #15062
Chart version bumped to 8.0.14 pending #15082
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @desaintmartin

/ok-to-test

@cpanato build didn't pass due to redis-lib-values image tagged with 4.0.11, changed to 5.0.5

@bbenzikry please update your PR with latest master and fix the conflict thanks!

/retest

@juan131 Looks ok now but there seems to be an issue with the cluster, I'm seeing the same as
https://github.com/helm/charts/pull/15128#issuecomment-506862438

/retest

/retest

/test pull-charts-e2e

/retest

/lgtm


Fix Caching Issues for MiqDiskCache Module

Purpose or Intent
Several caching issues have been uncovered and will be addressed here.
Similar changes have been made in MiqHyperVDisk via separate PR.

Cache requests where the request overlapped an existing cache entry
both at the start and end resulted in new entry duplicating the existing
entry plus the data at start and end.  This will instead be addressed by
creating new entries for the start and end and using the existing entry.
This is a performance issue.

Cache requests where the end of the request (but not the start) was present
in an existing cache entry used the incorrect offset into the entry for the data
returned. This is a data integrity issue.

The range of blocks cached for new entries was determined incorrectly.
Depending upon the request from the disk module less data might be cached than required.
This is a performance issue.

Concatenating cache entries with recursive calls to bread_cached used the "+"
operator exclusively. When possible this is changed to "<<" to eliminate some
temporary buffer allocation and speed things up a little.

Comments also added for clarity.

Links
For similar changes made to MiqHyperVDisk see https://github.com/ManageIQ/manageiq/pull/9981
@roliveri @Fryguy for your review.  Thanks.

I'm confused...does this rely on #9981 or does it supercede #9981.  Just having the link in the OP doesn't tell me how it's related.

@Fryguy #9981 is the reference from the 2nd line under "Purpose or Intent".  I updated the link to be more specific.

@jerryk55 Do you recall, was the initial PR for this cache module ported to Darga?

The original PR was 9445.

Darga backport details:
commit 42a4e88e489831bb8a028326790d43d9be77044b
Author: Richard Oliveri<EMAIL_ADDRESS>Date:   Wed Jul 27 23:24:39 2016 -0400

    Merge pull request #10002 from jerryk55/MiqDiskCache_Issues

    Fix Caching Issues for MiqDiskCache Module
    (cherry picked from commit 8064376eadddac60d8676c56b210af7f74ac045e)

https://bugzilla.redhat.com/show_bug.cgi?id=1375231


chore(release): bump version to v2.0.0-beta.0

请 review 完整的 changelog：https://github.com/leeyeh/javascript-sdk/blob/9ec095734e68ecb2900e460837d4b763f0870a39/changelog.md

Current coverage is 65.49% (diff: 100%)

Merging #371 into next will not change coverage

@@               next       #371   diff @@
==========================================
  Files            30         30
  Lines          2614       2614
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1712       1712
  Misses          902        902
  Partials          0          0

Powered by Codecov. Last update 10fa73c...9ec0957


Unable to install fontawesome6

[ ] Review the documentation: https://github.com/oblador/react-native-vector-icons
[ ] Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment
NPM

Description
Unable to install react-native-vector-icons/fontawesome6
execute "npm install --save @react-native-vector-icons/fontawesome6"
ERROR
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>0.0.1-alpha.5 is not avialble on npm page

Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, share a project, or share an app that reproduces the issue using https://snack.expo.io/. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve

@piotrbugla, you should just be installing react-native-vector-icons
@react-native-vector-icons/fontawesome6 is part of an upcoming release and is not ready for prime time


tjson: Enable fuzzing in CI

This task is a part of #683 epic.
This task should be taken after #899 is done.
As the result of #899, we should have some fuzzing for tjson tests. Let's research if it's reasonable to enable it on CI. (Let's enable it and see what happens).

@AlekSi I need your help to add some details to this task's description. I guess, it's something related to this https://github.com/FerretDB/FerretDB/blob/main/.github/workflows/go.yml#L154 place?..

I think it is fine to keep that task in the icebox for now


newman: init at 5.1.1

Motivation for this change
Package new application
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

inspiration from package spacegun: pkgs/applications/networking/cluster/spacegun

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/223

Works as far as --help and run --help are concerned. Tested with `nixpkgs-review.


NameError: global name 'pokemon_names' is not defined

I'm trying to combine the webhooks fork that @Brideau made with the discord fork @Devsome created and i think they are causing problems with each other.. When i start up my discordbot and the web.py i get this from the web.py
Traceback (most recent call last):   File "/Library/Python/2.7/site-packages/flask/app.py", line 2000, in __call__     return self.wsgi_app(environ, start_response)   File "/Library/Python/2.7/site-packages/flask/app.py", line 1991, in wsgi_app     response = self.make_response(self.handle_exception(e))   File "/Library/Python/2.7/site-packages/flask/app.py", line 1567, in handle_exception     reraise(exc_type, exc_value, tb)   File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app     response = self.full_dispatch_request()   File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request     rv = self.handle_user_exception(e)   File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception     reraise(exc_type, exc_value, tb)   File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request     rv = self.dispatch_request()   File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request     return self.view_functions[rule.endpoint](**req.view_args)   File "/Users/user/Documents/Pokemap/pokeminer-master/web.py", line 68, in discord     return json.dumps(get_pokeDiscord())   File "/Users/user/Documents/Pokemap/pokeminer-master/web.py", line 159, in get_pokeDiscord     name = pokemon_names[str(pokemon.pokemon_id)] NameError: global name 'pokemon_names' is not defined
And this from the Discord Bot
Invalid response code: 500
I'm not sure if i can post it here as a issue in the original pokeminer so please point me in the right direction!

@BallTongue0 if you want I can pull the newest pokeminer tonight and check it with the Discord Bot.
But as the error log shows, that has nothing to do with the Discord Bot, because he is only pulling the json from web.py (function who created) the newest pokémon.
Maybe pokemon_names is not defined in the web.py file.

@Devsome I found the problem... The pokemon_names was defined in CAPS so when changing the pokeDiscord name to POKEMON_NAMES the bot started working! Thanks anyways and awesome job with the bot!

@devsome i do have a question tho, if i want to send the actual time it dissapears and not the time left is there a simple way to do that?


iOS build fails if splashScreen image is not in root directory

I didn't see this documented anywhere, so I don't know if it's a "feature" or a bug, but I found that using a custom splash screen image crashes the iOS build if the image you use is not in your project's root directory. From build.settings:
Bad:
    splashScreen =
    {
        enable = true,
        image = "images/splash.jpg"
    },

Good:
    splashScreen =
    {
        enable = true,
        image = "splash.jpg"
    },

The build fails with a nondescript error:
Aug 04 15:41:42.357 BUILD ERROR: Build script failed
Aug 04 15:41:42.357
Aug 04 15:41:42.385 iOS build failed (1) after 6 seconds
Aug 04 15:41:42.749 ERROR: Build Failed: Build script failed

This should be resolved with #174 and probably will be included in next release.


Android 13 (Pixel 7) secure content from the phone puts a bank screen on mirrored windows screen.

Environment

OS: [Windows 11]
scrcpy version: [e.g. 1.24] Windows 64 bit
device model: Pixel 7 Pro
Android version: [13]

Describe the bug
Initially, the secure screens, such as passwords and one-time content from WhatsApp, and Snapchat, all showed up. But some android updates come up, and then whenever a secure screen is sent, it puts a blank screen.
Rest all the non-secure screen gets mirrored without issue.

But some android updates come up

Since Android 12: #2129.
There's nothing to do. 😞


Rework WorkflowNode column methods to be easier to think about

I've been having trouble understanding what's going on with various parts of the code that call input_column_names and flattened_columns, because it's unclear whether those are the input or the output columns. This PR refactors those methods out and replaces them with input_columns and output_columns to make some of the other graph/workflow code we're working on easier to think through.

input_column_names is obviously for the input, but flattened_columns is ambiguous. It gets trickier to think about when WorkflowNode.selector is added to the picture, because that's also currently a list of column names, which ought to represent the input columns for the current node but currently represents the input columns for the next node (i.e. the current node's output.)
We're trying to refactor our way out of this conundrum by changing some things about how the graph works:

WorkflowNode.selector should represent the current node's input columns
Then we wouldn't need separate "input nodes" at the beginning of the graph that have a selector but no op
In order to make that work with + nodes, we need to be able to use the selector to grab additional columns from the root dataframe of the workflow
In order to make that work, we need unambiguous input/output column methods on WorkflowNode to use in Workflow._transform_ddf (which this PR provides.)


Revert "Pass entry points JSON files to front-end server"

Reverts flutter/flutter#15180
Reason: buildbot failures on Mac.


Improvement/command layer accounts tests

Description
Begin to test the command layer. These initial tests are intended to serve as a discussion point to confirm the approach is adequate prior to proceeding horizontally.

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report

Merging #1 (f3be155) into master (ff1f8b1) will decrease coverage by 15.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
- Coverage   55.33%   40.15%   -15.19%
===========================================
  Files          36      102       +66
  Lines        1874     3995     +2121
===========================================
+ Hits         1037     1604      +567
- Misses        707     2189     +1482
- Partials      130      202       +72

Flag
Coverage Δ

unittests
40.15% <ø> (-15.19%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/project/project.go
100.00% <0.00%> (ø)

internal/config/init.go
0.00% <0.00%> (ø)

internal/emulator/start.go
4.65% <0.00%> (ø)

pkg/flowkit/output/emoji.go
27.27% <0.00%> (ø)

internal/accounts/create.go
58.06% <0.00%> (ø)

internal/transactions/sign.go
0.00% <0.00%> (ø)

internal/scripts/scripts.go
10.00% <0.00%> (ø)

internal/config/add-network.go
0.00% <0.00%> (ø)

internal/events/events.go
2.22% <0.00%> (ø)

tests/mocks/Gateway.go
51.09% <0.00%> (ø)

... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1f8b1...f3be155. Read the comment docs.


error: MemoryError

The error says
device memory (out of memory)

So, it is out of memory. However, this is probably due to your previous zombie jobs.


Add optional or nullable rules - useful for ValidateMap

[x] I have looked at the documentation here first?
[x] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10
Issue, Question or Enhancement:
When using ValidateMap I would like to set some entries as optional. So if it is not set or set to nil, none of the rules then is applied.
Because now when I have a rule for map entry, which does not exist in data map, I got an error.
Code sample, to showcase or reproduce:
// this returns an errors:
// - plan is required field <- this is OK
// - car must be one of volvo bmw <- this is not OK
res = v.ValidateMap(
	map[string]interface{}{},
	map[string]interface{}{
		"plan": "required,oneof=gold silver bronze",
		"car":  "oneof=volvo bmw",
	},
)

// would be nice to support something like this
// this would return ONLY 1 error:
// - plan is required field
// - car is optional, so no more validation happen
// - phone is optional, so no more validation happen even it is `nil`
res = v.ValidateMap(
	map[string]interface{}{
		"phone": nil
	},
	map[string]interface{}{
		"plan":  "required,oneof=gold silver bronze",
		"car":   "optional,oneof=volvo bmw",
		"phone": "optional,oneof=iPhone Android Other",
	},
)

You  are looking for omitempty https://pkg.go.dev/github.com/go-playground/validator/v10#hdr-Omit_Empty

Sorry, I was searching nullable and optional and totally missed that one


Can't get venv up

Tried to do the first step in the process of setting up the bot to run, on an Ubuntu 20.04 box, and got the following:
python -m venv venv
Command 'python' not found, did you mean:
command 'python3' from deb python3
command 'python' from deb python-is-python3
Please outline all the steps to get the environment setup properly. It will save time and increase the chances of winning. We may not have expertise in the languages and environment you have.
This means all dependencies, etc...
We tried to install Python on our own but then ran into other issues such as pip and venv missing and pip could not be installed as the version of Python that got installed was incorrect...
Do we need to use "python" or "python3"? Not sure.

We got it to work after switching over to Python3 and manually installing all the dependencies. Please update the docs to show these steps... would appreciate it.

Updated README to include setting up development environment.


about the last one MySqlSnapshotSplit

Describe the bug(Please use English)
A clear and concise description of what the bug is.
Environment :

Flink version :  1.13.5
Flink CDC version: 2.2.1
Database and version: mysql

To Reproduce
Steps to reproduce the behavior:

Thes test data :
The test code :
The error :

Additional Description
If applicable, add screenshots to help explain your problem.
When the last split is read, if the full amount of data is large and a lot of data is written per second, the last split directly uses the primary key > =?, The data volume is too large and the task fails

I also encountered such problem, the task manager OOM, looking for a solution

I also encountered the same problem，When table is very large, it's oom

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


move codecov upload to github workflow

https://codecov.io/gh/oam-dev/kubevela

move codecov upload to github workflow


Hour view displayed incorrectly on locale='de'?

Hey there,
when i use locale='de', the hours go from 1-24 as it should be. Anyway, in the hour - view where i am supposed to pick something like 17:05 it says 5:05 instead on the buttons.Is this a bug or am i doing something wrong?
thanks for the help!

Hi @headyrules,
Moment Picker directive renders minutes in the Hours View using the setting in the momentPickerProvider. As you can see from the README, the default value of minutes-format is set to "Locale format LT without meridiem part (AM/PM, am/pm)".
Indeed, German locale value of LT is equal to h:mm A, so removing the meridiem part will just return h:mm. Moment.js token h gets the hour from 1 to 12 without adding the zero padding.
If you want to change this behavior, you just have to set the value you want using the picker provider, like this:
angular
    .module('myApp', ['moment-picker'])
    .config(['momentPickerProvider', function (momentPickerProvider) {
        momentPickerProvider.options({
            minutesFormat: "HH:mm"
        });
    }]);


List some commands

With the creation of #284, the ability to send commands to Chaosbot is underway. What are some commands you would like to be able to perform?
Current commands proposed
Issue Management

[x] /vote close - closes issue when no nay reactions on this comment are added within voting window
[x] /vote reopen reopens issue when see above ^^^
[ ] /vote label=<LABEL_TEXT> adds label when ^^^
[ ] /vote remove-label=<LABEL_TEXT> removes label when ^^^
[ ] /vote assign=<USER> assigns to user when ^^^
[ ] /vote unassign=<USER> unassigns from user when ^^^

Possible Ideas

revert bad code
toggle stuff?

It would be cool if we can have some way of collaboratively choose something from a list of options. Say we want to decide on a frontend CSS framework to use, instead of creating different PRs for each option, we can create an issue with a list (in markdown) of options and include i.e. /vote options. Maybe chaosbot could then create comments for each option which could be voted on...? Of course we could do that manually... Maybe someone can think of a better way? Or we can encode options as reaction emoji's (that'll give us 6 options).

Good example. There could be lots of use cases for this functionality. Let's see if more people can think of ideas as well.

I would imagine that a post would look something like:
/vote on
[ ] foo -- optional description is preceded by --
[ ] bar
[ ] baz
And people would then vote for an option with
/vote for foo

/git revert  - manually force a revert if something goes bad or we just don't like it

I'm not fond of this idea... I would rather just create a PR that undoes whatever we want...

/vote for

[ ] foo
[x] bar
[ ] baz

🍻

/vote for :beers:

/vote for 🍻

Lol the bot isn't too smart yet

Time remaining: -44:00 - Vote status: passing

@phil-r @rudehn  Shouldn't it be "/vote on" to propose a poll?

There's no plan for a poll yet, so no syntax has been proposed. Feel free to offer suggestions for new commands to implement

@rudehn
me:
/vote on $title

- $option1
- $option2
- $option3
- $option4
- $option5
- $option6

There are a minimum of 2 options, and a maximum of 6.
chaosbot:
> /vote on $title

Options have randomly been assigned reactions:

- :smile: $option1
- :-1: $option2
- :tada: $option3
- :+1: - $option4
- :confused: $option5
- :heart: $option6

Use these to vote.

Chaosbot will react with every reaction assigned an option. This will give voters an easy way to vote (they don't have to look in the reaction menu, they can just click the reaction at the bottom).
If there are 4 or less options, :-1: and :confused: will not be used, as they are negative whereas the rest are positive.
Chaosbot doesn't need to follow up on this type of vote (it just posts the comment and reactions then moves on).

I would rather that chaosbot creates a post for each option and positive reactions on the post are a vote in favor.


How set a section size in CTR-ACPKM cipher mode with CMS

We develop our engine that works with Russian gosts and try to realize CTR-ACPKM cipher mode (https://tools.ietf.org/id/draft-irtf-cfrg-re-keying-10.html#rfc.section.6.2.1). It works correct when encrypting data with the EVP API (NID is equal to NID_kuznyechik_ctr_acpkm).
But there is problem when I try use CMS.
EVP_CIPHER* cipher = EVP_get_cipherbynid(NID_kuznyechik_ctr_acpkm);
CMS_ContentInfo* cms = CMS_encrypt(..., inBio, cipher, 0); // calls EVP_CipherInit_ex() and EVP_EncryptUpdate()

I need to hard set section size value (N) (the number of bits that are processed with one section key before this key is transformed) due to OpenSSL doesn't set it via EVP_CIPHER_CTX_ctrl() with EVP_CTRL_KEY_MESH. But in gost this value must be different for various protocols (CMS, TLS1.2). Bellow I put section size value for various gosts:

R 1323565.1.017-2018 (CTR-ACPKM gost)
Magma        N = 1 Kbytes
Kuznyechik  N = 4 Kbytes
R 1323565.1.025-2019 (CMS gost)
Magma        N = 8 Kbytes
Kuznyechik  N = 256 Kbytes
R 1323565.1.020-2018 (TLS1.2 gost)
Magma        N = 1 Kbytes
Kuznyechik  N = 4 Kbytes

How I can set section size when work with CMS? Or EVP_CIPHER_CTX_ctrl() with EVP_CTRL_KEY_MESH and correct section size should be called in CMS_encrypt()?

For now it works. We have a default value for TLS and a separate value for CMS/PKCS#12. Both CMS and PKCS#12 read the ASN1 parameters, and the callback is involved. So the design is not the best possible, but fits the Russian GOST standards.

Looks like now all the GOST engines are forced to implement the behavior identical to the gost-engine for CMS_encrypt support in OpenSSL 3.0. Will the issue be solved better in OpenSSL 4.0 with providers? What's your vision, how will it be solved?

Looks like now all the GOST engines are forced to implement the behavior identical to the gost-engine for CMS_encrypt support in OpenSSL 3.0.

The behavior is prescribed by the standard.

Will the issue be solved better in OpenSSL 4.0 with providers? What's your vision, how will it be solved?

I don't see a problem now. In theory it is possible to add a control call providing a context (CMS/PKCS#12/TLS) but it still was not necessary.


Update match.md

Corrected the name of the metric used in the field  fuzziness. It is called the Damerau–Levenshtein distance because the field  fuzzy_transpositions is equal to true by default.
Description
The change corrected the name of the metric used in the field fuzziness by default. Similar correction is requested on the PR 7842.
Issues Resolved
No issues resolved
Version
All
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter, I am ready for your doc review.

By the way I corrected the description of the field fuzziness as well.

Please fix DCO so we can merge this PR

@kolchfa-aws, Fixed.


TypeError: Cannot read property 'toString' of undefined(…) on bootstrap

I have TypeError: Cannot read property 'toString' of undefined(…) on bootstrap.
Looks similar to issue #108, but with different versions and no gulp.
I'm on Angular 2 rc1 and ng2-translate 2.1.
Issue was there for my project with Angular 2 beta 17 and ng2-translate 1.11, but ng2-play worked fine.
boot.ts:
import {provide} from '@angular/core';
import {bootstrap} from '@angular/platform-browser-dynamic'
import {HTTP_PROVIDERS, Http} from '@angular/http';
import {TranslateLoader, TranslateStaticLoader, TranslateService} from 'ng2-translate/ng2-translate';

import {AppComponent} from './app.component'

bootstrap(AppComponent, [
    HTTP_PROVIDERS,
    provide(TranslateLoader, {
        useFactory: (http: Http) => new TranslateStaticLoader(http, 'i18n', '.json'),
        deps: [Http]
    }), TranslateService]);

systemjs.config.js (not sure if it matters):
  var  map = {
    ....
    'ng2-translate': 'docs/default/libs/ng2-translate'
  };
  var packages = {
    ...
    'ng2-translate': { defaultExtension: 'js' }
  };

If I have breakpoint in boot.js, in the setter for ng2_translate:
            function (ng2_translate_1_1) {
                ng2_translate_1 = ng2_translate_1_1;
            },

ng2_translate_1_1 is "almost" empty:
JSON.stringify(ng2_translate_1_1)
=> "{"default":{}}"

Is your TranslateService provider undefined ?
It seems to be the same issue as the #120 ...

@andzhik maybe this will help you https://github.com/ocombe/ng2-translate/issues/120#issuecomment-224127374

@matthieubouvierthales , yes, TranslateService is undefined.
@Shootervm , no, that doesn't help.

It seems to be the same issue as me.
I found a solution (workaround?):

Import ng2-translate with script tag:
<script src="angular2/ng2-translate/bundles/ng2-translate.js"></script>

Do not reference ng2-translate in systemjs

In main component:

import { TranslatePipe, TranslateService, TRANSLATE_PROVIDERS } from 'ng2-translate';
[...]
@Component({
...
providers: [..., TRANSLATE_PROVIDERS, ...],
pipes: [TranslatePipe]
...
}
[...]
export class AppComponent {
constructor(..., private _translateService: TranslateService, ...) {}
[...]
}

Do you still have this issue ? Is there some kind of example plunkr or github/gist repo that I could use to reproduce the bug ?

Closing this old issue, let me know if I should reopen it.


Ordered list feature request

Don't know if this is possible given the # is used for headers but would it be possible to define ordered lists as:
#.
#.
#.
The number syntax is awkward. Either you use 1. for all your items which looks dumb (IMO) or you number them sequentially which is labor-intensive, especially when inserting/deleting/reordering.
Some variants:
#. foo

#) bar

(#) baz

Hi @mike-ward,
I agree, the syntax of the ordered list is awkward, it is used to keep the same as the markdown in order to migrate easily.
I definitely like the generic #. syntax.
I will add this one in my today iteration.
Thank you for the feedback.

Closed with the pull request #2


activity_id -- add 'LESFMIP'

LESFMIP is a new MIP that is documented in Smith et al. 2022 (https://doi.org/10.3389/fclim.2022.955414). It is closely aligned with CMIP6 DAMIP and as such fully complies with CMIP6 standards. The intention is to cmorize the output from LESFMIP and then publish it through ESGF along with the existing CMIP6 output.
I would much appreciate if following entry could be added to CMIP6_CVs
"LESFMIP":"Large Ensemble Single Forcing Model Intercomparison Project",
ps: I will create separate issues for experiment_id and source_id modifications

I just realised that a number of LESFMIP experiments (e.g., hist-GHG, hist-aer, hist-sol, hist-volc, hist-nat) are already defined in DAMIP (the rest of the LESFMIP experiments are new). The only differences are in the "activity_id" (which would change from DAMIP to LESFMIP), the end_year (would change from 2014 to 2020) and some of the tier values.
It might be confusing to define multiple entries of the same experiment. A better solution could be to add the missing experiments to DAMIP. I will check with Doug Smith (who is the PI of LESFMIP and DAMIP) what he thinks.

HI @IngoBethke
Unfortunately CMIP6 is closed for new activities and experiments -- the systems where changes would be needed to support this are no longer being developed and focus has turned to future planning for CMIP7.
However, the LESFMIP definition includes many of the DAMIP experiments and you can publish these to CMIP6 under the DAMIP activity id -- I've been doing exactly this for Doug Smith over recent months.
We are getting close, within a month or so, of having a new mip era set up to handle this, CMIP6Plus, (just looking to get the last approval we need from WGCM). We're planning for LESFMIP to be the first activity included alongside "CMIP" for the DECK + historical runs.
When we set up LESFMIP we will include all of the experiments defined in Doug's paper (i.e. including the CMIP6 experiments from DAMIP), but we would recommending adding to the CMIP6 archive under DAMIP where possible.
When CMIP6Plus is started there will be a discontinuity in the assignment of variables to MIP tables, but there will be a simple mapping (i.e. tas_Amon -> tas_APmon).
@durack1, anything more to add here?

@matthew-mizielinski you've covered all the pertinent points. We should have a couple of new activities listed before the end of the year is my guess, but the expectation is that it will be fairly low volume, mostly used for evaluating forcing datasets as they are prepared for CMIP7 prime time through the historical experiments.
@IngoBethke we are currently still working on these updated repos, but once we have these in shape to share, we'll make sure that you and others are notified, so you can migrated your workflows across to the latest updated configs.

Hi @matthew-mizielinski and @durack1
Thanks a lot for the detailed info.
We won't start the cmor-ization before August, so waiting for the CMIP6plus sounds like the best option for us (also considering that we have output for some experiments like LESFMIPhist-lu that are not defined under DAMIP).
Kind regards, Ingo


Update messages_cn.properties

Update messages_cn.properties.
https://github.com/naver/ngrinder/issues/634#issuecomment-674619218

Where does it come from?

@junoyoon
lijie1010 helped me.


Healt insights tests

Description
fix the livetests

/azp run java - healthinsights - tests

/azp run java - healthinsights - tests


Release/lottery terms release

Releases the following PRs from core:

https://github.com/bloom-housing/bloom/pull/4213
https://github.com/bloom-housing/bloom/pull/4217
https://github.com/bloom-housing/bloom/pull/4218
https://github.com/bloom-housing/bloom/pull/4186

Need to add Doorway-specific strings still


Implement the hamburger menu and drag and drop support for the flowchart

Create the hamburger menu and implement a demo of the drag and drop without API functionality
Advances vertical prototype in that the UI is pretty important

To appreciate the changes brought upon by this issue, please visit https://cp-groupname.herokuapp.com/

awesome. Cool drag & drop!


not working

When i open launcher i get this error:
C:\Users\PC\Desktop\lol-bot-main\scripts>python bot.py
Traceback (most recent call last):
File "C:\Users\PC\Desktop\lol-bot-main\scripts\bot.py", line 6, in
import launcher
File "C:\Users\PC\Desktop\lol-bot-main\scripts\launcher.py", line 10, in
import utils
File "C:\Users\PC\Desktop\lol-bot-main\scripts\utils.py", line 1, in
import keyboard
ModuleNotFoundError: No module named 'keyboard'
C:\Users\PC\Desktop\lol-bot-main\scripts>pause

I'm assuming you figured this out? If not, just make sure you run the requirements.txt file and that you don't have multiple versions/installations of python.


Invisible character instead of space

vscodium let me know:
The character U+00a0 is invisible.

Looks like that was in there. https://unicodeplus.com/U+00A0
Replaced by an actual space in there.

Thanks, I get that sometime when using Mac.


larboard/starboard left/right directions confusing due to 180 degree flip

Description
During o11n, Omega uses starboard and larboard cannons, while flipping 180 degrees. When used twice in a row, the second callout will give a direction which is easy to misinterpret.
This is because the direction is defined in terms of the boss facing, but since the boss just flipped and players likely haven't moved behind him, it would make sense to instead base the left/right before the flip instead.
I can make a PR for this, but wanted to determine opinion on whether this makes sense or not.

Hmm, I think this would be equally confusing to folks who see the flip.  I agree that it's ambiguous, but that's why it's left/right -> move (left)/stay (right) as the followup.  Is that not working, or do you think that's also confusing?

Hm. Yea I can see that being pretty confusing either way.
However I think it's less confusing to see:
go left -> stay left
Rather than
go left -> stay right
Especially since nothing else happens between the two mechanics and the boss also always flips back to point the way he faced originally.
But I also understand wanting to keep directions always boss relative, since that helps coordinate things more easily overall.
It's another case of "once you know it's not bad" but I had a few friends ask about it and be confused initially.

I had similar issues with the left/right wing on P3S, so I ended up overwriting the alert text to Front: >>> . . . . Back: <<< (or vice-versa for the other wing).  It both makes it into a visual rather than having to parse "left" vs. "right" in the midst of other mechanics, and gives me directions for both if I'm in front or behind the boss.  Not sure how easily that could be translated to the default alerts, but you should be able to apply similar overrides to any mechanics that are relative to the boss's facing.

Back in Savage days we always called the side left/right from behind view and then stay or move. Since the boss turns 180° if the call out was the same u have to move if the callout is opposite u stay.

Just cleaning up old issues.  Sorry again that this is confusing, but just trying to be consistent as much as possible that "left" means "left flank".  People are always going to disagree about "which left" and there's not any way to satisfy everybody and that's what config ui overrides are for to change the display text.  I'm going to close this for now.

That's fine, I think it's a reasonable position.


[Grafana] Error while logging into Grafana

https://dotnet-eng-grafana.westus2.cloudapp.azure.com

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

Now resolved. Looks like a simple expired secret.


feat: Adds owasp rules to vacuum

This PR serves to extend vacuum with the OWASP rules that already exist for spectral:
https://github.com/stoplightio/spectral-owasp-ruleset/blob/main/src/ruleset.ts
and use the tests that they provide to guarantee quality
https://github.com/stoplightio/spectral-owasp-ruleset/blob/main/__tests__/

So far, this all looks fine to me!
Do those JSON Path expressions work?

Yeah, all of them are working :)
It would be nice if we could generalize the rule of operaion_4xx_response. I am not sure if this can be done with the schema rule, but in spectral it can be done with oneOf e.g. . There are other rules that use it. I will probably create a function for it and it can be replaced afterwards.
There will be tests for each one of the rules, which will be easier to refactor later on if needed

I am so excited to see this come together! Thank you for all your work so far:

Feel like I am almost finishing it :)

This is really impressive, great work!
It looks like some of the changes in functions/core/schema.go switch the indentation style from 4 spaces to a tab character without otherwise changing much the content. Is there a defined style for this project in favor of tabs or spaces? It looks like that's the only changed file which previously had spaces, so is this PR intentionally also fixing a previously incorrect indentation style in that file?

This is really impressive, great work!
It looks like some of the changes in functions/core/schema.go switch the indentation style from 4 spaces to a tab character without otherwise changing much the content. Is there a defined style for this project in favor of tabs or spaces? It looks like that's the only changed file which previously had spaces, so is this PR intentionally also fixing a previously incorrect indentation style in that file?

Hey Oliver.
Thank you so much!
About your question:
Not really. I am using vscode and it indents automatically (I can disable it, but I am not to worry about this for now). In the end I will fix the indentation and it would be nice to squash all of these into one commit.
I have a table https://github.com/Ricagraca/vacuum/tree/rg/owasp/rulesets of the rules and what needs to be improved
I managed to make all the rules work with the exact same tests given in spectral, but still need to further improve some details. Some of them give more errors than it needs unfortunately.
Still need some hours to fix the issues

Amazing work. I am super impressed! Thank you so very, very much for all this work.

Thank you so much for your review @daveshanley . I will go trough each comment over the weekend and will fix the issues you pointed out

I have fixed all the issues. Feel free to let me know about other issues (if they exists) or feel free to fix them :).

Done

Excited to see this merged and release - planning on using it ASAP!

As soon as the conflicts are resolved, I can merge and release.


Doesn't build

0.1.3j-core/src/LevelListener.h:13:36: error: ‘uint32_t’ has not been declared

Works after including missing headers


511 - Drop-down arrow does not display if using long field names - LOW

In the layer pick list, if layer names are too long (e.g. longer than approx 35 characters), the drop-down arrow does not display.

Obstruct the text in favor of displaying the drop down arrow.

Will show like this now:

@lindsayking ready to be verified in the WAB repo

@jmhauck  I am now seeing the drop-down arrow at all times, however, if the length of the layer names vary, the length of the drop-down boxes vary slightly.  This is most visible in Firefox and Internet Explorer.
Firefox:

Internet Explorer:

Chrome, for comparison.  Note, the last box is only slightly shorter than the others in Chrome.

@lindsayking ok...will take a closer look at this

@lindsayking ready to be verified

@jmhauck  -  Alignment issues are now fixed with latest commit from WAB repo.


[Honorary Degree Index, 1748-2001] Remove duplicate header row

What maintenance needs to be done?
Remove duplicate header row from source data spreadsheet (FNAME, LNAME, etc.)
Level of urgency

[x] High (needed for Website migration)
[ ] Moderate
[ ] Low

Why is this maintenance needed?

This is not meaningful data and the main stakeholder has asked us to remove it.

Acceptance criteria

[ ] The row with FNAME, LNAME etc. does not appear in the static tables site.

Implementation notes, if any
Need to remove from source data sheet

Done.


Allow copy of taxons

We would like to allow users to export taxons in order to make it easier to
create tagging spreadsheets.
Those spreadsheets need a mapping between taxon names and their content IDs.
This commit adds a link from the taxons index page into a new view which
contains a table with the necessary columns: title, content ID and link type.
The user can then copy that HTML page into a spreadsheet and it would work as if
we copied CSV data.
From here:

We go here:

Trello ticket: https://trello.com/c/gRoOrJoo/121-spike-build-functionality-into-content-tagger-which-makes-creating-a-tag-importer-spreadsheet-easier

@mobaig is this more in line with your initial thoughts?

@carvil spot on 👍


Option to wrap %articleContent% in blockquotes?

Hi!
First of all: great plugin! Very helpful to extract pages for later reading and highlighting. I love the template feature which make using this with my own system a breeze.
Although I do like that the whole content is clipped, I'd like to hide it at first. Preferably by using callouts and collapse them dy default. I couldn't get this to work because article content could have more alineas and only the first alinea would have the > in front.
Is there a way to change this so I can use callouts with the article content?

This is something I tried within a template:
> [!quote] article content
> %articleContent

This only works when the content contains one alinea.

Update to the newest version with the new template engine and use this syntax to get article content in blockquote.
{{ articleContent|blockquote }}


Add notification emails for expiring deployed certificates

Adds a new notification type (for Lemur security team only) that notifies when an expiring certificate is still detected at any of its associated domains.
I also considered adding this logic to the regular expiration notification and notification summary emails; it's possible to do this, but I'm a little hesitant about how much additional load it might cause to add it in multiple places.

Still in progress; I will split up the current logic into two separate celery tasks in order to decouple the domain/port detection from the notification.

Should be ready for review now.


Failed to build archway-bindings 0.2.0

Crate name
archway-bindings
Build failure link
https://docs.rs/crate/archway-bindings/0.2.0/builds
Additional details
No response

Looking at the build-log this seems to be an issue with one of your dependencies (cosmwasm-std) and its activated backtrace feature.
Looking at the docs.rs metadata of cosmwasm-std, it's not active for the docs: https://docs.rs/crate/cosmwasm-std/latest/source/Cargo.toml.orig

When I try to compile your crate with nightly and --all-features (as you have in your own docs.rs metadata), I see the same error:
$ cargo build --all-features
[...]
error[E0635]: unknown feature `provide_any`
 --> /Users/syphar/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cosmwasm-std-1.4.1/src/lib.rs:2:45
  |
2 | #![cfg_attr(feature = "backtraces", feature(provide_any))]
  |                                             ^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `cosmwasm-std` (lib) due to previous error

Thanks for the quick reply, @syphar. I didn't notice it in the docs.rs metadata. I've identified the issue and fixed it.


Initial icon size?

Right now the view area of the SVG icons is 24x24. I don't know if that is good or bad.
Rocket.chat in their icons starts with 32x32: https://github.com/RocketChat/fuselage/tree/develop/packages/icons
What do you think @HScono, should we re-do the icons at that size or maybe a different size? We will need to revise all the icons anyway for proper naming conventions so we can consider making changes like this as well.

Let's go with 32px. Also in the next release I will fix few icon names to shape instead of function.

Finished in v0.4


PIL-168:Task 3: enter group's accounting period

The changes have been merged with another PR PIL-168-Al


Masthead L0 active link: selected menu item knob not working in a new tab

Detailed description
Describe in detail the issue you're having.
In Storybook, when I change the selected menu item knob, the update renders correctly in the same view but if I open the page in a new tab the active state is missing.

Is this a feature request (new component, new icon), a bug, or a general issue?
This could be Storybook issue, not sure.
Is this issue related to a specific component?
Masthead L0
What did you expect to happen? What happened instead? What would you like to see changed?
In this example, I expected to see a blue underline below Products & Solutions when I opened the page in a new tab.
What browser are you working in?
Chrome
Steps to reproduce the issue

Open the masthead here: https://ibmdotcom-react-canary.mybluemix.net/?path=/story/components-masthead--default
Change the selected menu item knob at the bottom of add-ons panel to reflect one of the L0 menu items
Once you see the update, click on the 'open canvas in new tab' icon in the top right of Storybook

Yep this is a storybook issue, specifically with special characters like &. If you try changing the selected menu item knob to a menu item that does not contain & (ie. Explore more) and then open a new tab, the blue underline will appear correctly.

As @asudoh comment references, this has been fixed and can be closed now.


staking: handle param change and unbonding edge case

This fix a bug in the claim logic that would cause the node to crash if a parameter change had occurred, or if an undelegation was marked to have taken place after the unbonding height specified in Unbonding { unbonds_at_height }. The latter can happen if a validator gets ejected from the consensus set for inactivity, and is equivalent to an Unbonded state.

Tested this manually, merging optimistically so that staking test work can be done against an up-to-date staking component implementation.

Thank you for labeling this as consensus-breaking :pray:. I noticed an apphash mismatch when running slightly outdated pd code against preview, and sure enough, it was already labeled.


zombie doesn't use latest jsdom (11.12.0)

Using old version of jsdom(11.5.1) causes some parsing errors, that were fixed in the latest versions of jsdom.
I was able to upgrade jsdom to 11.12.0.

PR: https://github.com/assaf/zombie/pull/1168

dear @assaf please take a look when you have some time. thank you!