[stable/prometheus-node-exporter]Add support for nodePort

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
Adding support for nodePort to the prometheus-node-exporter chart.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm

Does this need to be tested? I created a NodePort for node-exporter and try to access the endpoint with http://node_ip:nodeport_ip
  clusterIP: ""

  ## List of IP addresses at which the node-exporter service is available
  ## Ref: https://kubernetes.io/docs/user-guide/services/#external-ips
  ##
  externalIPs: []

  hostPort: 9100
  loadBalancerIP: ""
  loadBalancerSourceRanges: []
  servicePort: 9100
  type: NodePort
  nodePort: 31997


[14.0.x] ISPN-14242 RESP server can send results in incorrect order

https://issues.redhat.com/browse/ISPN-14242
https://issues.redhat.com/browse/ISPN-14245

@wburns you open the PR against the wrong branch :)

Replaced by https://github.com/infinispan/infinispan/pull/10409


Information about signed scripts is lacking

The run command on this pages only briefly describes how to run scripts. It does not mention anything about signing and the related advanced setting of Defender for Endpoint. Please add something about that or refer to an article about signing scripts, publishing the certificate in the local machine Trusted Publishers store etc.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5bbb2f7d-1aa5-4536-d22b-8b5b1f94f5b3
Version Independent ID: 8878dc91-fdb6-349f-a0c2-5d4717fb40ed
Content: Live response command examples
Content Source: microsoft-365/security/defender-endpoint/live-response-command-examples.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @diannegali
Microsoft Alias: diannegali

@diannegali Please help us in resolving this issue. Thanks

@yogkumgit looks like this is the same as issue #12842.


Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher:Error: Error creating connection/channel, metrics streaming disabled

Hi All,
I am facing below issue when i am debugging in local .net core 2.1 application and it is going to fallback method. Few days back these hytrx commands are working perfectly don't have any changes in configuration side.
And i am using Steeltoe.CircuitBreaker.Hystrix.MetricsStreamCore and Steeltoe.CircuitBreaker.HystrixCore are 2.1.1 version. Please help me.
Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher:Error: Error creating connection/channel, metrics streaming disabled: RabbitMQ.Client.Exceptions.BrokerUnreachableException: None of the specified endpoints were reachable ---> RabbitMQ.Client.Exceptions.OperationInterruptedException: The AMQP operation was interrupted: AMQP close-reason, initiated by Peer, code=530, text="NOT_ALLOWED - vhost / not found", classId=10, methodId=40, cause=
at RabbitMQ.Client.Impl.SimpleBlockingRpcContinuation.GetReply(TimeSpan timeout)
at RabbitMQ.Client.Impl.ModelBase.ConnectionOpen(String virtualHost, String capabilities, Boolean insist)
at RabbitMQ.Client.Framing.Impl.Connection.Open(Boolean insist)
at RabbitMQ.Client.Framing.Impl.AutorecoveringConnection.Init(IFrameHandler fh)
at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
--- End of inner exception stack trace ---
at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
at Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher.EnsureConnection()
The thread 0x2c94 has exited with code 0 (0x0).
Exception thrown: 'System.NullReferenceException' in Dell.Product.TransformLayer.Services.dll
Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher:Debug: Discarding Hystrix Metrics, no connection

Steeltoe 2.1.1 was released almost 2 years ago, please try updating to newer packages
This looks like a connection issue with RabbitMQ - is your local service running and have you configured the application to know how to find it?

Thanks a lot for your quick response Hess.

I am implementing CircuitBreaker in an existing application, in that application, some of the steelteo packages are 2.1.1, which they are using(like cloud foundry etc.) so Hystrix 2.4 is not compatible(got some compilation errors) with the old versions of stellteo packages.

2.I got the below issue, when I started using Steeltoe.CircuitBreaker.Hystrix.MetricsStream (in start up i placed this command services.AddHystrixMetricsStream(Configuration); ), then i added RabbitMq client and the issue is resolved. I deployed in pcf and tested everything(hystrix dashboard, circuit open and close) working fine. suddenly its started giving an error in PCF after a week. I debugged and found the above error.
Steeltoe.CloudFoundry.Connector.Connector.ConnectorException: 'Unable to find RabbitMQ connectionFactory type. RabbitMQ.Client assemby may be missing'
where I have to configure? do I need to configure something else?

I'm suggesting you should update all the Steeltoe packages, there have been numerous improvements in that timeframe.
That ConnectorException happens when you don't have a compatible package reference to RabbitMQ.Client - Steeltoe Connectors use reflection to work with a variety drivers without direct references, so it is possible for there to be incompatibilities between versions that aren't known until runtime. There aren't any known incompatibilities there though - what version of RabbitMQ.Client are you using?  I can't imagine that part of this puzzle would break on its own post-deployment.
If the deployed application was working and then stopped after some time (with no code changes or redeployments) then it would be worth checking with the platform team to make sure there weren't any changes or problem with the network or any of the involved infrastructure.

I am using RabbitMq.Client version 1.0.0. I contacted PCF foundations team. but i am facing this issue in local debugging as well.

That version number doesn't sound right - is that the file version or the package version? That would be an extremely old RabbitMQ client if that's the package version
Is your application running and throwing exceptions in the background or not running at all? I'm not clear on whether you're just having an issue seeing the metrics or if its interfering with the running of your application.
As far as I know, the Hystrix metrics stream (particularly over RabbitMQ) isn't very commonly used locally - how are you running the hystrix dashboard locally?

I upgraded my application framework .net 2.1 to 3.1 and upgraded
Steeltoe.CircuitBreaker.HystrixCore from 2.1.1 to 2.4.4
Steeltoe.CircuitBreaker.Hystrix.MetricsStreamCore 2.1.1 to 2.4.4
RabbitMQ.Client 1.0.0 to 6.1.0 and some other dependencies
Still, I am facing the same issue.
When I got the error(means fallback user-defined error) in PCF, I debugged locally and I am able to repro the fallback user-defined error but i found the actual above RabbitMq error in the output window. Also, I am not running a dashboard locally. I am not sure what happens. I completely struck now.
Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher: Error: Error creating connection/channel, metrics streaming disabled: RabbitMQ.Client.Exceptions.BrokerUnreachableException: None of the specified endpoints were reachable
---> RabbitMQ.Client.Exceptions.OperationInterruptedException: The AMQP operation was interrupted: AMQP close-reason, initiated by Peer, code=530, text='NOT_ALLOWED - vhost / not found', classId=10, methodId=40
at RabbitMQ.Client.Impl.SimpleBlockingRpcContinuation.GetReply(TimeSpan timeout)
at RabbitMQ.Client.Impl.ModelBase.ConnectionOpen(String virtualHost, String capabilities, Boolean insist)
at RabbitMQ.Client.Framing.Impl.Connection.Open(Boolean insist)
at RabbitMQ.Client.Framing.Impl.AutorecoveringConnection.Init(IFrameHandler fh)
at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
--- End of inner exception stack trace ---
at RabbitMQ.Client.ConnectionFactory.CreateConnection(IEndpointResolver endpointResolver, String clientProvidedName)
at Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher.EnsureConnection()
Steeltoe.CircuitBreaker.Hystrix.MetricsStream.RabbitMetricsStreamPublisher: Debug: Discarding Hystrix Metrics, no connection

OK. There are several ways to resolve the metrics stream issue:

Run a RabbitMQ Server so the metrics have somewhere to go (probably not worth it if you're not hooking up a dashboard)
Turn off the failure logging (set "Logging:LogLevel:Steeltoe.CircuitBreaker.Hystrix.MetricsStream"= "None" in appsettings.development.json)
Conditionally activate the metrics stream based on the environment you're running in  (eg: if (!env.IsDevelopment)...)

But that all seems to have been a distraction this whole time, because the metrics stream happens in the background so it doesn't interfere with the application. It sounds like the fallback code you have is throwing it's own exception after the main method fails. I don't have any way to help you figure that out without knowing what either of those blocks of code are supposed to do, but your stack trace does also have Exception thrown: 'System.NullReferenceException' in Dell.Product.TransformLayer.Services.dll so maybe that's part of it?

Closing.  Respond to the comment from @TimHess, if you are still having this issue and we can reopen it.
Thank you.

Sure thank you
On Fri, Aug 14, 2020 at 11:15 AM Jason Konicki<EMAIL_ADDRESS>wrote:

Closing. Respond to the comment from @TimHess https://github.com/TimHess,
if you are still having this issue and we can reopen it.
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SteeltoeOSS/Samples/issues/159#issuecomment-674150656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOO7MHTAJOFNMAEX754AKF3SAVPLBANCNFSM4OR6X55A
.


gui becomes blank when clicking on a target.

After clicking on any button the native dialog loses all functionality.

@SylvanFranklin did you install using brew install --HEAD airdrop-cli ?

works with head install.


Docker not working in macOS / OSX

Hi guys, I've been trying to get the MLDB running on my local using docker from quay.io/datacratic/mldb:latest
However, I've been facing with the following error:
Aborting boot: directory mapped to /mldb_data owned by root
FYI, I've created a new user called mldb (non-root) and change command to id mldb to use the non-root user, however it still returns the same error.
Any help would be appreciated.
OS: macOS 10.12.1
Docker: 1.12.3-beta30

Can you post the command line you're using to start the docker container?
On Nov 13, 2016 2:27 AM, "Davis"<EMAIL_ADDRESS>wrote:

Hi guys, I've been trying to get the MLDB running on my local using docker
from quay.io/datacratic/mldb:latest
However, I've been facing with the following error:
Aborting boot: directory mapped to /mldb_data owned by root
FYI, I've created a new user called mldb (non-root) and change command to id
mldb to use the non-root user, however it still returns the same error.
Any help would be appreciated.
OS: macOS 10.12.1
Docker: 1.12.3-beta30
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mldbai/mldb/issues/750, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQXTY6Hy23mxf-5nJrtGasWfVTAxf8qks5q9rv7gaJpZM4KwoVb
.

Given the default command in the documentation:
docker run --rm=true \ -v </absolute/path/to/mldb_data>:/mldb_data \ -e MLDB_IDS="id" \ -p <IP_ADDRESS>:<mldbport>:80 \ quay.io/datacratic/mldb:latest
What did you put for </absolute/path/to/mldb_data>? What are the permissions of that file?
Are you at PyconCA? If so plz send an email to<EMAIL_ADDRESS>so we can find each other and I can help you fix it before the tutorial.

Here's the command that I ran:
docker run --rm=true -v ~/mldb_data:/mldb_data -e MLDB_IDS="id mldb" -p <IP_ADDRESS>:5555:80 quay.io/datacratic/mldb:latest
I did create the folder manually and also tried removing it, which it was auto-created when running the docker.

Hi @davistan ,  can you show the permissions of the ~/mldb_data folder?
It should be owned by the mldb user, otherwise mldb won't be able to write to it (hence the abort).
Finally, I guess it is github markdown that is eating the back ticks, but just to make sure here's what the command should look like:
docker run --rm=true -v ~/mldb_data:/mldb_data -e MLDB_IDS="`id mldb`" \
  -p <IP_ADDRESS>:5555:80 quay.io/datacratic/mldb:latest

(along with a chown mldb:mldb ~/mld_data)

Yes, I did that too before creating this issue. Here's my ls dump:
drwxr-xr-x+  2 mldb      staff     68 Nov 13 15:11 mldb
drwxr-xr-x+  2 mldb      staff     68 Nov 13 15:12 mldb_data

The mldb is another directory I tried, but still the same result.
One possibility is I saw something that staff is also part of root, which may be the issue?
The mldb (standard) user is created from the macOS's System Preferences -> Users & Groups

Exact same issue.

Searching from code - looks like this line responsible for the issue.
Perhaps someone can fix this or remove this check?

Unfortunately, the fix is not that simple.
The check is there as a safeguard, if it is removed, mldb will encounter write errors when it won't be able to write to its home directory.
I didn't have a chance to test this on osx or macos, but from the info you have shown here, it seems that docker maps the volumes with root permission instead of the original permissions, which is weird.
When mapping the mldb_data folder from your mac to the container, did you add the source directory as a shared folder in the docker configuration. See instruction here: https://docs.docker.com/docker-for-mac/#/file-sharing
Also, to confirm that you're seeing the real directory in the docker, could you:

create a file in the mldb_data on your mac:
touch .../mldb_data/testing.123; ls -lan ...mldb_data/testing.123
boot a container based on the mldb image and run a simple ls to show the mldb_data directory contents:docker run --rm=true -v ~/mldb_data:/mldb_data -e MLDB_IDS="`id mldb`" \
  -p <IP_ADDRESS>:5555:80 quay.io/datacratic/mldb:latest  ls -lan /mldb_data

Both command should show similar output:
$ ls -lan ~/mldb_data
total 8
drwxrwxr-x  2 12019 12019 4096 Jan 18 02:06 .
drwxr-xr-x 21 12019 12019 4096 Jan 18 02:06 ..
-rw-rw-r--  1 12019 12019    0 Jan 18 02:06 test.123

$ docker run --rm=true -v ~/mldb_data:/mldb_data -e MLDB_IDS="`id mldb`"   -p <IP_ADDRESS>:5555:80 quay.io/datacratic/mldb:latest  ls -la /mldb_data
total 8
drwxrwxr-x  2 12019 12019 4096 Jan 18 02:06 .
drwxr-xr-x 58 root  root  4096 Jan 18 02:07 ..
-rw-rw-r--  1 12019 12019    0 Jan 18 02:06 test.123

Can you run the above commands and post the result?
Thanks.

For the shared folder it says that the folder I added is overlapped with Users folder - perhaps it is already shared.
My output as below:
$ ls -lan ~/mldb_data
total 0
drwxr-xr-x    3 503  20   102 Jan 18 10:28 .
drwxr-xr-x+ 151 502  20  5134 Jan 18 10:23 ..
-rw-r--r--    1 503  20     0 Jan 18 10:28 123

$ docker run --rm=true -v ~/mldb_data:/mldb_data -e MLDB_IDS="`id mldb`"   -p <IP_ADDRESS>:5555:80 quay.io/datacratic/mldb:latest  ls -la /mldb_data
total 4
drwxr-xr-x  3 0 0  102 Jan 18 02:28 .
drwxr-xr-x 58 0 0 4096 Jan 18 02:28 ..
-rw-r--r--  1 0 0    0 Jan 18 02:28 123

The mldb_data is owned by 503 and not root, not sure why it says that its owned by root.

thanks for the quick feedback.
Can you try  running the ls as the _mldb user in the docker?
docker run [...] sudo -u _mldb ls -lan /mldb_data

Yes, looks like it - confusing on docker side.
Here's my output after running with sudo -u _mldb:
total 4
drwxr-xr-x  3 1234567 1234567  102 Jan 18 02:28 .
drwxr-xr-x 58       0       0 4096 Jan 18 02:59 ..
-rw-r--r--  1 1234567 1234567    0 Jan 18 02:28 123

that's some mighty magic voodoo, I wonder if changes are persistent.

(You're my remote eyes and hands here, sorry about that,  but I'm genuinely curious about all that weird permission behaviour. It is a good contender for the worst offender of the principle of least surprise for 2017!)

Don't mind to help on some open source projects.
I got the below when trying chown.
chown: changing ownership of '/mldb_data/123': Operation not permitted
chown: changing ownership of '/mldb_data': Operation not permitted
I think in the macOS it is 503 but in docker, it is 0 or 1234567 (via _mldb).
So chown 503 inside docker is not recognized either.

Hmm ok. osxfs is probably started by your user (or some other user) who doesn't have the required rights to chown files to '503' (mldb) on osx.
I have a better understanding of the issue now, thanks for your help.
Until we figure a fix for this issue, may I suggest trying out mldb on https://mldb.ai ?

Sure, hope that we can have a fix soon :)

You can use this workaround in the meantime.
docker run  --entrypoint="chown" --rm=true -v ~/mldb_data:/mldb_data quay.io/datacratic/mldb:latest   -R _mldb: /mldb_data

This will change the ~/mldb_data owner to the one Docker is expecting.  Once you've run the command you can start MLDB normally.

The following trick worked for me: I had to run this command once:
docker run --entrypoint="chown" [...] -R _mldb: /mldb_data.
This command outputs nothing. but now, my MLDB container works just fine everytime I starts it (using the same command but without --entrypoint and -R flags). I hope this helps.

I am having the same issues using MLDB on my Mac Laptop.
Tried all the things as mentioned in the comments above and none worked. May I ask for the better documentation for kickstarting MLDB on Mac.


Add bot commands for custom configuration

Add bot commands, like:

!help
!track [player/guild/alliance] [name/id]
!untrack [player/guild/alliance] [name/id]
!track list
!set-channel [channel]
!clear

etc.

I will work on this tomorrow, as we already have support for multiple discord servers.

Implemented: !help, !channel
Remaining: !language, !track, !untrack, !list, !clear


ADD: Add notebooks on EMC2

Add initial notebooks on EMC2 + associated instrument simulators (@rcjackson)

Merged with #24


AADHttpClient awaiting forever

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[X] mobile (iOS/iPadOS)
[X] mobile (Android)
[ ] not applicable
[X] other (enter in the "Additional environment details" area below)

Additional environment details

browser version: Teams (Viva Connections)
SPFx version: v1.18.0
SP release: targeted release

Describe the bug / error
In Teams Viva Connections on mobile phone (both Android and iOS) anything related to AadHttpClient is not working and forever waiting on getToken method. This includes MSGraphClientV3. For example trying to get anything from Graph API will just be sitting there stuck forever.
No errors in console, no failed network requests, just nothing.
See sample code below:
 const aadHttpClient = await context.aadHttpClientFactory
  .getClient('https://graph.microsoft.com'); // this resolves fine
 const response = await aadHttpClient
  .get(`https://graph.microsoft.com/v1.0/me`, AadHttpClient.configurations.v1); // <== never resolves

IMPORTANT:
I'm able to reproduce this outside of Teams (Windows 11 Desktop) using this page (you have to deploy and install an Application Customizer on your site, this page is blank and only loads extensions) https://<tenant>.sharepoint.com/_layouts/15/preload.aspx?mbypass=1&env=WebView
If you remove WebView argument then it starts to work without any issues.
While debugging, this bit seems to be never resolving and saving forever pending promise in tokens cache:

Steps to reproduce 1 (Teams + Mobile phone)

Open Teams Viva Connections on Mobile phone (iOS or Andriod)
Try any web part that talks to Graph API
It's stuck forever and never resolves (not even rejects).

Steps to reproduce 2 (Browser + Desktop)

Open page https://<tenant>.sharepoint.com/_layouts/15/preload.aspx?mbypass=1&env=WebView
Try any extension that talks to Graph API (it has to be an extension to be able to load on this page)
It's stuck forever and never resolves (not even rejects).

Expected behavior
Graph token succesfully retrieved and Graph API request succeeds.

@SharePickle, let's follow up offline. one thing thou: the way you reproed it in the web is wrong and will always fail: when you add env=webView it is a signal for us that we are embedded in Teams. That's where we try to get the token from Teams and not MSAL. in the browser, we are not in Teams so we will always stuck forever.

@lucabandMSFT hello, could you please keep the ticket open? Teams issue still not resolved, even if my WebView steps are invalid.
Also, how is it possible to debug Teams Viva Connections on Mobile phone, do you guys have any tutorials? I could only find guides on how to test Teams Tab, but not Viva Connections page.

Looks like we have similar issue with any web part using Graph API in SharePoint app and in Teams app (through Viva Connections). Reported by customer and reproduced in multiple tenants.


Add pull request template

This is based roughly on the template from assisted-service.
/cc @filanov what do you think?
I didn't think the entire template from assisted service was really necessary since we don't have a ton of complicated CI here and everything should be the same regardless of environment.

Maybe adding a checklist can help as well so people that will open a PR should at least see it
 Title and description added to both, commit and PR.
 Relevant issues have been associated (see CONTRIBUTING guide)
 Reviewers have been listed
 This change does not require a documentation update (docstring, docs, README, etc)
 Does this change include unit-tests (note that code changes require unit-tests)


Nimjay i18n frontend

Background

Fixes

Change Summary

Additional Notes

Testing Procedure

Related PRs or Issues

update the code

latest code

latest code

latest

new commits


Fix empty range for cold start bug

Description
While collecting training data, we continue searching even if no data range has data.  This bug can cause "No [ranges] specified for the [date_range] aggregation" exception printed out.  This PR fixed that by returning empty training data instead of logging exceptions.
Testing done:

testing on a cluster with sparse data.  Verified we don't log exceptions anymore.

Check List

[ Y ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #90 (21ca333) into main (1a0dbc8) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #90      +/-   ##
============================================
- Coverage     79.39%   79.32%   -0.08%
  Complexity     2693     2693
============================================
  Files           243      243
  Lines         11129    11132       +3
  Branches       1013     1014       +1
============================================
- Hits           8836     8830       -6
- Misses         1880     1889       +9
  Partials        413      413

Flag
Coverage Δ

plugin
79.32% <100.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...n/java/org/opensearch/ad/ml/EntityColdStarter.java
88.82% <100.00%> (+0.18%)
:arrow_up:

...port/SearchAnomalyDetectorInfoTransportAction.java
54.54% <0.00%> (-4.55%)
:arrow_down:

...ava/org/opensearch/ad/task/ADTaskCacheManager.java
90.82% <0.00%> (-2.76%)
:arrow_down:

.../opensearch/ad/cluster/ADClusterEventListener.java
92.00% <0.00%> (-2.00%)
:arrow_down:

src/main/java/org/opensearch/ad/model/ADTask.java
96.56% <0.00%> (-1.57%)
:arrow_down:

...ain/java/org/opensearch/ad/task/ADTaskManager.java
72.54% <0.00%> (-0.67%)
:arrow_down:

.../main/java/org/opensearch/ad/cluster/HashRing.java
92.10% <0.00%> (+13.15%)
:arrow_up:


Release datadog_checks_dev

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Failures are flaky tests or the license validation (which is unrelated and arguably flaky).


Pipeline for multiple clusters

Currently we separate our nonprod and prod by deploying to different clusters. It would be nice to have a view/manage a pipeline for a repo that can deploy to multiple clusters.

We are interested in this as well.  Pipelines is awesome.  We need it for multiple clusters.

I'm interested in this as well


Upgrade to 5.2.0 will recreate all public dns zones created by the module

Upgrade from 5.1.0 to 5.2.0 will destroy and create all public dns zones thats earlier created by the module.
This is mentioned already in https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/pull/910
Should at least be warned in upgrade docomentation.

Hi - fair comment. Did you use the moved {} block to remedy this>?

Yes, or maybe i altered it using terraform state commands. But state modification was needed :)

Understood - apologies


Java Script

#Java Script
##User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

If you are a beginner in programming, it is important to not only focus on reading but also on doing projects and learning from them. When I was learning JavaScript, I worked on basic projects such as creating a to-do list which covered concepts like dynamic appending and local storage, and also creating a Tic Tac Toe game. It is also important to learn about REST APIs and concepts like PUT, GET, POST, and DELETE.

W3 Schools is a great resource to learn from:  https://www.w3schools.com/js/
You can also check out some of my basic projects on my LinkedIn profile:  https://www.linkedin.com/in/sohan-guptha/


Preparation of meeting and guide for transformation of equations to dimensionless form

The following actions are to do, in order to prepare the meeting and the guide:

[x] #486

[x] #487

[x] #488

Finished.


Basic URL support in detail page

Right now we probably don't do anything to explicitly support URLs in the details page. They may be passed through as text and then angular itself decides how to render the URL, which may mess up the URL encoding.
For example:
https://gpcr-dev.misd.isi.edu/chaise/record/#1/gpcr_browser:target_gui/id=545&site=iHuman
What we need is to support the URL annotation, at least in its simplest form:
https://github.com/informatics-isi-edu/ermrest/blob/master/user-doc/annotation.md#2015-url

in the absence of the URL annotation => the contents of the column should be treated as plain text and not be clickable
when a column is annotated with tag:misd.isi.edu,2015:url (and it can a the null or {} value) => then it should be properly encoded and rendered on the page.

@karlcz : see point #1 above. agreed right?

The only little glitch I'm seeing is that when clicking on the URL, it opens the referenced page in a new window AND it seems to cause the chaise record page to refresh. Maybe the target of the anchor is _blank. Would it work if it was _top?

Also, this feature needs to be applied to the columns of the primary entity viewed in the record page. Right now its only applied to the columns of the nested entities.


LoggerInitializer updated to create directory when it doesn't exists.

The intent of this change is to allow fluentd to create a directory that is passed by --log and don't exists on the system.
Cheers

Please check tests and CI results.

Thanks @tagomoris for the feedback. I'll give it a look and make the proper updates 👍

@bmandrade ping?

Sorry @tagomoris , I'll try to take on this as soon as possible

closed by https://github.com/fluent/fluentd/pull/2732


Fix typo

What kind of change does this PR introduce?
Docs update.
What is the current behavior?
Spelling error.
What is the new behavior?
Fixed spelling.

Thanks.


[Docs] Unnecessary scroll bars in code snippets

Current Behavior

Scroll bars in code sections even if not needed.
Expected Behavior

No scroll bars should be there unnecessarily.
Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Platform: Any
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@leecalcote Please assign this issue to me, I am willing to solve this. 😄

@chinu-anand good eye. You're right.


Provide checkboxes for case sensitive and whole words

This is definitely something I'd like to do! For now both can be replicated using regex


[RFC] Responsive props

The idea here is to allow consumers to add responsive behaviour to their components without baking the logic into every component in our design system.
Consumers would need to add a <BreakpointProvider> at the root of their application.
They can then use various tools to add responsive behaviour

makeResponsive is a higher-order-component which will turn all the props of a given component into responsive props e.g:

<Component color="white" />

could then be used as
<ResponsiveComponent color={{ default: "white", lg: "black" }} />

useResponsiveValue is a hook which will return a resolved value based on the viewport e.g:

const value = useResponsiveValue({ default: 'Small', lg: 'Large' })
value will be 'Small' on small viewports and 'Large' on large viewports

useResponsiveProps is similar to useResponsive value except you pass an object to the hook, and each key/value pair in that object will be turned into it's own responsive prop. E.g:

const value = useResponsiveProps({
    text: {
        default: 'Small',
        lg: 'Large'
    },
    color: {
        default: 'red',
        md: 'green'
    }
})

On small screens text is 'Small' and color is 'red'. On medium screens text is still 'Small' and but color is 'green'. On large screens text is 'Large' and color is 'green'.

ResponsiveChildren is a component which allows you to pass different ReactNodes to be used at different viewport sizes E.g.

<ResponsiveChildren md={
Medium
)>
    <button>Default</button>
</ResponsiveChildren>

will show a button by default but on screens above medium it will show an h1.
Other things to note

All components/hooks are typed with the appropriate breakpoints
a responsive configuration must pass a 'default' value which will be used as a fallback if none of the provided breakpoint values are matched
You don't have to use a responsive object for every prop of a component wrapped with makeResponsive. You can just provide a value as usual if you don't want that prop to have responsive behaviour.
The implementation uses matchMedia under the hood. Components only re-render on breakpoint changes
If a consumer is using different viewports then they can create their own responsive system using createResponsiveSystem e.g:

 const {
    BreakpointsProvider,
    useResponsiveProps,
    useResponsiveValue,
    makeResponsive,
    ResponsiveChildren
} = createResponsiveSystem({ tiny: 0, kindabig: 800, mahoosive: 1000 });

All the returned components/hooks/HOC will then be typed appropriately

LGTM!! this is really great stuff :)

Nice work, I wonder if we want to offer the HOC. What benefits do you think it provides?

Yeah I think it's really valuable, similar to something like the styled HOC for styled components. You can make your sub-components responsive outside the main body of your component and then inline the responsive props making it easier to. rationalise the behaviour.
In theory you could also use it to wrap all of your components where they are defined similar to memo, or forwardRef to make them all responsive. Not saying we would do this on our side, but consumers might want to.

Can you link to the Storybook examples please?  The link in the description takes me to a markdown cheatsheet for some reason...
Were any other solutions looked at before deciding on this API?  There are a few I can think of below:

Stiches - https://stitches.dev/docs/responsive-styles
Facepaint - https://github.com/emotion-js/facepaint
Vanilla Extract - https://seek-oss.github.io/braid-design-system/css/responsiveStyle/

One potential downside is that brreakpoints are triggered by screen size.  For touch devices it is usually better to use other methods e.g.
OK for mobile
@media (max-width: 64rem) {
    // triggered when screen size is <= 64 rem
}

Better for mobile
@media(hover:none) and (pointer: coarse) {
    // triggered when you can't hover and using a pointing device of limited accuracy (a finger)
}

Thanks for the comment! The link is fixed now!
With regards to existing solutions the approach was definitely inspired by existing solutions e.g. Braid or MaterialUIs sx prop. But there were a couple of reasons why existing solutions weren't quite right:

Salt is built using vanilla css and css-variables, so a css-in-js solution isn't really appropriate
Ideally we want to be able to change prop values as well as simply styling (e.g. conditionally render a component) so we need something which react can hook into and affects rendering

Having said that we recognise that depending on the application this might not be correct for the consumer project. This is why we avoided baking the logic into the components themselves, instead providing this as an optional tool which consumers can use if it's helpful.
i definitely get your point in terms of screen-size vs device. I think both are valid. Sometimes we want functionality to change based on screen size, even if the device type is the same. But changing behaviour based on device type is also interesting.

Closing for now since we can use it as a reference from the issue. We can reopen once we're ready


Added .gitignore with *.pyc. Removed *.pyc files from repo.

Hey, love that you're doing open source market work!
I removed the *.pyc files from the repo to clean it up a bit. Also, I added *.pyc to the .gitignore to prevent them from being added again.
I hope to contribute more in the future :) Best to you!

awesome, thnx for the kind words and help, just getting the hang of this...
look forward to your future contributions :-) thnx again


[IntelliJ Plugin] Add fix for debugger breakpoints

Purpose
Fixes #10584.

Codecov Report

Merging #12745 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #12745      +/-   ##
============================================
- Coverage     59.85%   59.84%   -0.02%
  Complexity      659      659
============================================
  Files          2065     2065
  Lines        101682   101682
  Branches      12936    12936
============================================
- Hits          60862    60849      -13
- Misses        35625    35635      +10
- Partials       5195     5198       +3

Impacted Files
Coverage Δ
Complexity Δ

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
80.24% <0%> (-6.18%)
0% <0%> (ø)

...java/org/ballerinalang/bre/bvm/BLangVMStructs.java
50% <0%> (-1.67%)
0% <0%> (ø)

...ain/java/org/ballerinalang/net/websub/hub/Hub.java
59.09% <0%> (-1.52%)
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0547701...b3fb303. Read the comment docs.


Run canary + A/B/n experiments with 3 TF serving models

Closing this for now. Will be covered as part of individual campaigns.


Desktop mode

What would you like to be added:
We would like to have a light wallet desktop app that can be installed on Windows, Mac and Linux. Light wallet means it doesn't need to run a full node (like our existing desktop wallet) but use APIs from whale to do transactions. As a first iteration, we will only support light mode but in the future we can have a full node version as well.
It should share state and architecture with the mobile app. The only difference would be in terms of UI state. While there are solutions out there to provide easier portability between mobile and desktop, it might cause more harm in the future. Features not existing, lots of hacks and gotcha to add (if desktop, if mobile etc.).
Acceptance Criteria:
Setup and Workflows

[ ] #864
[ ] #865
[ ] #866
[ ] #867
[ ] #869
[ ] #868

Features

[ ] #904
[ ] #870
[ ] #871
[ ] #872
[ ] #873
[ ] #874
[ ] #875
[ ] #876
[ ] #877
[ ] #879
[ ] #880
[ ] #881
[ ] #882
[ ] #883
[ ] #884
[ ] #885
[ ] #886
[ ] #887
[ ] #888
[ ] #889
[ ] #891
[ ] #890
[ ] #892
[ ] #893
[ ] #894
[ ] #895
[ ] #896
[ ] #897
[ ] #898
[ ] #900
[ ] #899
[ ] #901
[ ] #902
[ ] #903
[ ] Highlight differences between current full node desktop app vs light wallet

@jtlntno-cake We would also want to put some disclaimer/copy on some parts of the app that it's a light wallet and there are differences between the full node wallet. Like:

No .dat file
No import/export or backup
Restore recovery words only from Mobile wallet
No snapshots
No syncing needed
No blockchain state

@thedoublejay here's a rough initial design for our responsive grid in desktop light wallet. As it stands, we have the minimum size of 768px (to cater for tablet-portrait) but we can have the default size as 1024px.
With this, we can start laying out the components as what we have from the mobile light wallet.
Let me know your thoughts or add comments on Figma.


Export ExpectThunk e.g. to Carthage

I noticed that ExpectThunk is only available as a Pod subspec.
Since I don't use CocoaPods, I'm stuck with copying the file. I wonder if it makes sense to add another framework target, e.g. ReSwiftThunkTesting, that exports this type. The RxSwift package is split into RxTesting and all the RxSwift parts as well, and sharing the scheme produces another framework that you can use during tests.

Bump. I would also like to use ExpectThunk as a Cartharge dependency as we are using Rome caching.

There's a SwiftPM target for this now at least.


Denormalize Recent Subjects to new table

https://github.com/zooniverse/Panoptes/blob/master/app/controllers/concerns/recents.rb#L12
Looks like we are using it somewhere. Perhaps we can store these in a FIFO queue type data structure?

I can't find any info about whether ANY works with GIST indexes, but using that could also be an option.
Otherwise I agree with denormalizing recents maybe related to #292

@edpaget just wondering how you're going to achieve this? I had an idea about appending a per project set of recent classification IDs on the user project preferences model that gets built in the background like a FIFO queue. We could extract these ID's for a simple scope like Classification.where(id: [recent_ids]). Thoughts?

I was literally just gong to make it its own table. That just related classification_id to a subject_id. You'd be able to filter it by project and workflow

So the recents will really just be a full history?

I think it has to be. I'd like to find a way to handle this without having to use a full table, but I'm not sure how.

Sounds fine, i was thinking more along the lines of a capped collection.
Would this table be a more natural place to store a user's project : workflow classification counts?

I don't think so, the table is just going to be primary_key, classification_id, subject_id


Close #68 immutable map across code

and some other improvements (custom adapter, new state rendering and tests).

Change the use of lists for Gifs (State) to Map and perform necessary changes across code.
Change gifs type on AppState: from SortedMap/TreeMap to Map/LinkedHashMap. Sorted maps are automatically ordered by keys, so linked hash maps (keep insertion order) are the wanted type.
Change loadGifs location from onCreate to onStart and now it is called after stateListener setting.
Change hasStateChanged implementations to use classes equals to simply compare states change or other some specifically state comparison.
Create GifsAdapter following SimpleAdapter implementation from Anvil Recycler but with some custom changes to improve our usage.
Minimize Anvil.render calls by removing/change forced onStateChange moments, making stateChanged verification to be more specifically and calling Anvil.render on some specifically scenarios. (unnecessary render calls are creating undesirables bugs after new immutable and custom adapter changes)

Changes needed on tests after immutable, adapter and fixes:

Change withEqualsGifDrawable to withEqualsGifUuid to using on whenListKeepOrderedAfterPlayTest
Change actionOnItemAtPosition(lastAdapterPos, click()) to withRecyclerPos(lastScreenPos)).perform(click() because we don't need the scrolling of first option (the scrolling was made before to load gifs on time)
Remove the scrolling to top code on whenScrollUpAndPlayFirstItemTest because actionOnItemAtPosition(0, click()) scrolls to top and click.
Fixing and improving whenListKeepOrderedAfterPlayTest

Changes made, i fix one major problem that was related with multiple gif download start or any one shot action that we will make inside anvil view methods. With Anvil.render inside each specific stateListener view (gif, feed, activity) the first one start the render of others and so on...even when the others components state was not changed. My fix move the Anvil.Render to be made after all onStateChanged calls, and this render components with a less hunger approach. With other specific Anvil.Render calls (not stateChanged ones) we need to be cautious about desirables one shot actions inside view method.

:+1:


Add api ver to auth message

Our backend API is at version 2 and version 3 is soon upon us. we should have a "version" key the client uses to tell webexec how to play it.
This issue is just about adding the field. The rest of the work will be done in the APIv3 branch.

Ended up adding it to the connect message. Make more sense as this is the first message.

Ended up adding it to the connect message. Make more sense as this is the first message.


Can't create migration

Docs say that soda migrate create name_of_migration will create a new migration but the create command is not there.
See output:
soda migrate --help

Runs migrations against your database.

Usage:
  soda migrate [flags]
  soda migrate [command]

Aliases:
  migrate, m

Available Commands:
  down        Apply one or more of the 'down' migrations.
  reset       The equivalent of running `migrate down` and then `migrate up`
  status      Displays the status of all migrations.
  up          Apply all of the 'up' migrations.

Flags:
  -h, --help   help for migrate

Current soda version: v3.38.0

Docs ,just be out of date there. There’s a "soda generate” sub-command.

For you:
https://github.com/markbates/pop/pull/135


Update react-jsx-dev-runtime.development.js

Summary

How did you test this change?

hgh

@simo-vargasp-sonarsource


Support configuration like NGINX "proxy_request_buffering off;"

disable request body buffering in http proxy

never mind, i'm idiot🤣


Write a set of code solutions: "leader line js example" (js-leaderline)

Please write code solution for this topics:
leader line js example (technology: js-leaderline)
Fast way
Just write the code solution(s) in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

JS leaderline (anseki/leader-line) usage example to draw lines between elements
How to remove created line in anseki/leader-line?
How to set line z-index in anseki/leader-line?


[ART-5644] Add jenkins job microshift_sync

This is to make MicroShift dev-preview artifacts publicly available for 4.13+.

Test build with 4.12.0-rc.6: https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/yuxzhu/job/aos-cd-builds/job/build%252Fmicroshift_sync/20/console

@jupierce yeah, we probably need some special logic since building and managing microshift doesn't really fit our current design model. It could make it a lot of easier if we can encode the basis event in the NVR so those builds don't have to be explicitly pinned. Previously I was working on a doc about future automation improvements but i didn't really finish it. I think I could open that doc up as soon as possible, and get this issue with some tasks in the doc into jira so we can start working on them.


MG & MIS

Dear @joedf,
My MG and MIS is ready for review.
Thank you for your time and valuable feedback.

Done! #37 #38


Company - Per Project Billing - Change Service attach position

Change above design service button to

Initiated by @vinpahilwani
Verified by @mitulpanch

I guess sir need to create Service section as in Auto Billing
Per-project have no section for Service, direct table is coming that's why it was in header, but surely we can create section for services

@dharmendraecb  will follow up with sample design and will finish this


Remove numeral.js dependency. Factory directive pattern refactor.

The main reason for the directive refactor was so that I could inject things into the directive. With the previous typescript class pattern using new() in the directive creation It was impossible to inject services or anything else into the directive class. This paves the way for easier integration from other services in the future.

Also, added a sort to avail directive itself so we don't run into issues with the metrics default sort order changing when querying avail metrics.


Shipping broken in Arch Linux AUR repositories

OS/Platform
Arch Linux
Installed
OS/Platform's package manager
Version
111.0.5563.64-2
Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[X] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[X] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

Description
ungoogled-chromium-bin is shipping broken in the official Arch linux repos and is impossible to install
How to Reproduce?

yay -S ungoogled-chromium-bin
Wait for it to finish
Open it, nothing happens

Actual behaviour
It doesn't open and gives the error /usr/lib/chromium/chromium: error while loading shared libraries: libavcodec.so.60: cannot open shared object file: No such file or directory
Expected behaviour
For it to open
Relevant log output
`/usr/lib/chromium/chromium: error while loading shared libraries: libavcodec.so.60: cannot open shared object file: No such file or directory`

Additional context
No response

Duplicate of https://github.com/ungoogled-software/ungoogled-chromium-archlinux/issues/222


filter messages

Messages are now filtered by the searched input. If input is cleared all messages from firebase will be displayed.

Way to almost merge it.


"collections[2].admin.views" is not allowed

Bug Report
So similar to the bug that was discovered and already fixed in #95, I just found the same bug for collections.
[nodemon] starting `node server.js`
[09:40:42] INFO (payload): Starting Payload...
[09:40:43] ERROR (payload): There were 1 errors validating your Payload config
[09:40:43] ERROR (payload): 1: "collections[2].admin.views" is not allowed
[nodemon] app crashed - waiting for file changes before starting...

Expected Behavior
As referenced here: https://payloadcms.com/docs/admin/components#collections
Steps to Reproduce
My example code
const Users = {
  slug: "users",
  auth: true,
  admin: {
    useAsTitle: "email",
    views: {
      List: () =>
My List
,
    },
  },
  access: {
    read: () => true,
    create: () => true,
  },
  hooks: {
    beforeRead: [onlyNameIfPublic],
  },
  fields: [
    // Email added by default
    {
      name: "name",
      label: "Name",
      type: "text",
    },
  ],
};

export default Users;

Additional Bug in globals?
Also I found that the views.edit customization for globals does not seem to work either.  (Docs)
// file Navigation.js
...
  admin: {
    views: {
      Edit: () =>
My Edit
,
    },
  },
...

I think its actually an issue with our documentation.
The typescript type and our config validation has List under admin.components.views.List. Your example is missing components.
https://payloadcms.com/docs/admin/components#collections could be more clear about this.
Maybe we review the structure of this at some point, as it is a lot of nesting.

Oh thanks @DanRibbens!
admin.components.views.List works great!
I think we can close this then.


[Bug] $HOME/Library/Application: No such file or directory

Search before asking

[ ] 我在 issues 列表中搜索，没有找到类似的内容。
I searched in the issues and found nothing similar.

Pake version
➜  pake --version
2.1.9
System version
macOS Ventura 13.4.1
Node.js version
➜  node -v
v18.16.1

fnm install

Minimal reproduce step
➜  pake https://v2ex.com
✔ Enter your application name … V2ex
✼ No icon given, default in use. For a custom icon, use --icon option.
✸ Installing package...

up to date in 649ms

68 packages are looking for funding
✔ Package installed!
✼ The first packaging may be slow, please be patient and wait, it will be faster afterwards.
✦ Building app...
/bin/sh: line 0: cd: /Users/zzde/Library/Application: No such file or directory
file:///Users/zzde/Library/Application%20Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/dist/cli.js:369
                reject(new Error(`${code}`));
                       ^

Error: 1
    at file:///Users/zzde/Library/Application%20Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/dist/cli.js:369:24
    at /Users/zzde/Library/Application Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/node_modules/shelljs/src/exec.js:145:9
    at ChildProcess.exithandler (node:child_process:427:5)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket.<anonymous> (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28)
    at Pipe.<anonymous> (node:net:322:12)

Node.js v18.16.1

What did you expect to see?
pake success ? ( may be
What did you see instead?
/bin/sh: line 0: cd: /Users/zzde/Library/Application: No such file or directory
file:///Users/zzde/Library/Application%20Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/dist/cli.js:369
reject(new Error(${code}));
^
Error: 1
at file:///Users/zzde/Library/Application%20Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/dist/cli.js:369:24
at /Users/zzde/Library/Application Support/fnm/node-versions/v18.16.1/installation/lib/node_modules/pake-cli/node_modules/shelljs/src/exec.js:145:9
at ChildProcess.exithandler (node:child_process:427:5)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at Socket. (node:internal/child_process:449:11)
at Socket.emit (node:events:513:28)
at Pipe. (node:net:322:12)
Anything else?
找到一个类似的 issue？
https://github.com/tw93/Pake/issues/314
也是因为 fnm？但好像 1.2.6 已经修了？但我用的是 2.X
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

可以了，感谢


Getting error 1005 something went wrong please verify with your serve on payucheckoutpro flutter

I am getting this error every time I use card to do checkout. if anybody has experienced this error and has found a way to solve this please share the solution.

@architprasar  can you please connect with Integration team at<EMAIL_ADDRESS>


Add Vuforia SDK to AR/VR resources.

Please read the CONTRIBUTING file in the root of the repo and add the required info to your description.


[cli] switch rancher server

What kind of request is this (question/bug/enhancement/feature request):
feature request for rancher2/cli
summary
Add the ability to switch the cli context to point to a different rancher server.
description
Currently the rancher login command supports a --name flag to specify a name for the targeted rancher server. The cli then adds a server entry to the ~/.rancher/cli2.json and sets the CurrentServer field to the name specified (see source).
Sadly there is currently no mechanism available to switch the current server.
For our use case, we have multiple rancher servers, each responsible for it's own set of kubernetes clusters. We are looking for an easy way to switch the current cli context to point at the correct rancher server.
proposal
Extend the rancher context switch command as follow:
$ rancher context switch -h
Switch to a new context

The project arg is optional, if not passed in a list of available servers and projects will
be displayed and one can be selected. If only one server is available it will be automatically selected.  If only one project is available it will be automatically selected.

Usage:
  rancher context switch [OPTIONS] [PROJECT_ID/PROJECT_NAME]

Options:
  --server-name value             Name of the rancher Server

Example:
$ rancher login --token token-12345  --name rancher1 https://rancher1.example.com/v3

$ rancher login --token token-67890  --name rancher2 https://rancher2.example.com/v3

$ rancher context switch
NUMBER    SERVER NAME   SERVER URL
1         rancher1            https://rancher1.example.com/
1         rancher2            https://rancher1.example.com/
Select a Server: 1

NUMBER    CLUSTER NAME   PROJECT ID        PROJECT NAME   PROJECT DESCRIPTION
...
Select a Project: 2

$ rancher context current
Server: rancher1 Cluster:minikube Project:demo

implementation
I am happy to raise a PR for this work. I would appreciate some feedback on the design first.

@dramich @drpebcak Any thought?

@chaudyg We always welcome PRs. As for the design I think it would be best to add a new command called server that allows this manipulation. Under server it would have at least three subcommands:
switch - operate similar to context switch
current - operate similar to context current but show the current server-cluster-project. Ideally the func loginContext would be updated to also include the server then both commands can use this helper.
ls - list all servers that currently live in the json file and mark your current one

Thx @dramich
I did a quick first pass. Let me know what you think. Thx
https://github.com/rancher/cli/pull/243/files

Available in v2.3.0-rc3

Thx

Verified on v2.3.0-rc3
Command - ./rancher server --help
./rancher server --help

Operations for the server
Switch or view the server currently in focus.

Usage:
   rancher server command [command options] [arguments...]

Commands:
     current  Display the current server
     delete   Delete a server from the local config
     ls       List all servers
     switch   Switch to a new server

Options:
   --help, -h  show help

On Logging into multiple rancher servers -
./rancher server ls
CURRENT   NAME             URL
          rancherDefault   https://<x.x.x.x>
*         test1            https://<y.y.y.y>
          test2            https://<z.z.z.z>

Command: ./rancher server current
Name: test1 URL: https://<y.y.y.y>

Command: ./rancher server delete test2
INFO[0000] Saving config to /Users/sowmyaviswanathan/.rancher/cli2.json
INFO[0000] Server test2 deleted

Command: ./rancher server switch test1
INFO[0000] Saving config to /Users/sowmyaviswanathan/.rancher/cli2.json

./rancher server ls
CURRENT   NAME             URL
          rancherDefault   https://<x.x.x.x>
*         test1            https://<y.y.y.y>
          test2            https://<z.z.z.z>


dsq: 0.21.0 -> 0.22.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for dsq is: "Commandline tool for running SQL queries against JSON, CSV, Excel, Parquet, and more"
meta.homepage for dsq is: "https://github.com/multiprocessio/dsq"
meta.changelog for dsq is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.22.0 with grep in /nix/store/mxia93pvdaibdjs4k5wdh39lqyv8w025-dsq-0.22.0
found 0.22.0 in filename of file in /nix/store/mxia93pvdaibdjs4k5wdh39lqyv8w025-dsq-0.22.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
dsq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mxia93pvdaibdjs4k5wdh39lqyv8w025-dsq-0.22.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dsq https://github.com/r-ryantm/nixpkgs/archive/da0d2457aa950c88117ac3fcf8784091e4d95820.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mxia93pvdaibdjs4k5wdh39lqyv8w025-dsq-0.22.0
ls -la /nix/store/mxia93pvdaibdjs4k5wdh39lqyv8w025-dsq-0.22.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dsq

Maintainer pings
cc @liff for testing.

This update is broken due to upstream tag naming change. Fixed in #188610.


Java builder fails with UnicodeDecodeError

Under Python 2.7, the Java builder doesn't care how the java files are encoded, but for a project that's currently building with SCons 3.1.1 using Python 2.7, it fails when running Python 3.x.
Java files are being opened as text, assuming the default encoding, which is different from OS to OS.  Under Windows, this causes a new failure for an old project:
10:42:40 UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 1807: character maps to :
10:42:40   File "C:\Jenkins\CI\DLE18_special\32\dle-sandbox\DLE\SConstruct", line 1697:
10:42:40     libraries = swigenv.SConscript('SWIG.scons', exports={'env': swigenv}, variant_dir="$BUILDDIR", duplicate=0)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Script\SConscript.py", line 597:
10:42:40     return _SConscript(self.fs, *files, **subst_kw)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Script\SConscript.py", line 286:
10:42:40     exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
10:42:40   File "C:\Jenkins\CI\DLE18_special\32\dle-sandbox\DLE\SWIG.scons", line 260:
10:42:40     classes = javaenv.Java('classes', javaenv.Dir('$SOURCEPATH.abspath/../'))
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Environment.py", line 219:
10:42:40     return self.method(*nargs, **kwargs)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Tool\javac.py", line 196:
10:42:40     result.extend(b(t, s, *args, **kw))
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Environment.py", line 255:
10:42:40     return MethodWrapper.call(self, target, source, *args, **kw)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Environment.py", line 219:
10:42:40     return self.method(*nargs, **kwargs)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Builder.py", line 651:
10:42:40     return self._execute(env, target, source, OverrideWarner(kw), ekw)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Builder.py", line 563:
10:42:40     tlist, slist = self._create_nodes(env, target, source)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Builder.py", line 525:
10:42:40     target, source = self.emitter(target=tlist, source=slist, env=env)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Tool\javac.py", line 98:
10:42:40     pkg_dir, classes = parse_java_file(f.rfile().get_abspath(), version)
10:42:40   File "c:\jenkins\ci\dle18_special\32\dle-sandbox\python-env-win10-apdfl18\lib\site-packages\scons\SCons\Tool\JavaCommon.py", line 408:
10:42:40     data = f.read()
10:42:40   File "C:\Python36\lib\encodings\cp1252.py", line 23:
10:42:40     return codecs.charmap_decode(input,self.errors,decoding_table)[0]
10:42:40 Build completed with status 2
Required information

breifly discussed on dischord 2/20/2020 in #scons-help
Version of SCons: 3.1.1
Version of Python: 3.6, 3.7 (any 3.5+)
How you installed SCons: via pip
What Platform are you on?: Windows 10 (Mac & Linux work properly in this case)
How to reproduce your issue?: Build
How you invoke scons: scons VAR=value

Is this fixed? GIven that PR #3568 which referenced it is merged?

@mwichmann Yes the problem has been fixed.

closing


Fixed Xcode 8 Beta 4 issues with new Swift 3 changes.

@madhavajay Thanks a lot for this PR! Can you ensure that the changes don't break with Swift 2.2? See Travis CI failures.
The Xcode 8 test fails are fine for now, as we need to wait for Travis to update.

Fixed for 2.x, and working in Xcode 8 Beta 4. 😝

Awesome @madhavajay. Thanks a lot! Can you do me one last favor and remove the trailing whitespace in this line:
let contains = subscriptions.contains({ $0.subscriber === subscriber }  )

That will get rid of the linter warning.
Thanks so much!

Current coverage is 100% (diff: 100%)

Merging #139 into master will not change coverage

@@           master   #139   diff @@
====================================
  Files           8      8
  Lines         182    143    -39
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
- Hits          182    143    -39
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update d876943...4179c08

Sorry, should be all sorted now. 😎

@madhavajay Thanks a lot for the fixups! We're inviting all contributors to become a member of the ReSwift org. If you are interested you can accept the invite which will make it easier for you to contribute in future!


Package fails to install under R 4.0

According to its DESCRIPTION, the package requires R 4.0. However, the following line uses the native pipe operator, which is only available from R 4.1 onwards:
https://github.com/pharmaverse/admiraldev/blob/86c007a71a99a417ac9b8dbbc36672afc0e8a1b0/R/process_set_values_to.R#L96

Ohhh...goodspot @klmr !!
@pharmaverse/admiral and @pharmaverse/admiral_comm
ummm....how should we approach:

Remove native pipe and update to magrittr pipe
Require admiral/admiraldev to only work with 4.1  and keep native pipe?

Ohhh...goodspot @klmr !!
@pharmaverse/admiral and @pharmaverse/admiral_comm
ummm....how should we approach:

Remove native pipe and update to magrittr pipe
Require admiral/admiraldev to only work with 4.1  and keep native pipe?

I'd vote for the second option - R 4.1 is quite old anyway.

So should we handle this as an official bug fix with a re-release?

So should we handle this as an official bug fix with a re-release?

I don't think so. The min R version is something that is not correct is many many many pkgs on CRAN. I would just fix in dev, and it'll be correct in the next release

Could we add a CI/CD workflow which tries to install and test the package with the minimum versions stated in DESCRIPTION?

Perhaps we can just say somewhere on the website we support the last 2, 3, 4 (whatever we choose) versions of R, and supplement our workflows with the R CMD Check from Posit that makes it easy to check the last n versions of R.
          - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}
          - {os: ubuntu-latest,   r: 'release'}
          - {os: ubuntu-latest,   r: 'oldrel-1'}
          - {os: ubuntu-latest,   r: 'oldrel-2'}
          - {os: ubuntu-latest,   r: 'oldrel-3'}
          - {os: ubuntu-latest,   r: 'oldrel-4'}

We say we develop using the earliest of the last 3 versions of R, in documentation:
https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html#r-and-package-versions-for-development

I believe we are testing 4.4, 4.3, 4.2 with our CI actions.  We should add 4.1 to mix.

We already have the Posit workflow file here, and we can just uncomment the lines.
https://github.com/pharmaverse/admiraldev/blob/86c007a71a99a417ac9b8dbbc36672afc0e8a1b0/.github/workflows/R-CMD-check.yaml#L32

ah i see - ummm... can we re-work the admiralci one since it is used in admiral as well as well as the other admiral packages.  Just be nice to all pull from the same spot.  I'm totally fine to simplify the one in admiralci!

We say we develop using the earliest of the last 3 versions of R, in documentation: https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html#r-and-package-versions-for-development

There it says

Currently we test admiral against the three latest R Versions and the closest snapshots of packages to those R versions.

Is the part "and the closest snapshots of packages to those R versions" up to date? I remember vaguely that we changed our strategy to use the latest version of the packages for all R versions.

I believe we are testing 4.4, 4.3, 4.2 with our CI actions. We should add 4.1 to mix.

I think testing more R versions doesn't solve the issue. If we had tested with 4.1, we still wouldn't have discovered the problem.
If we can add a workflow which tests the package on the minimum R version and minimum package versions as specified in the DESCRIPTION file, it would be helpful. @cicdguy , is this possible?
Otherwise, I would rely on the developers and users that they report wrong minimum versions.

I believe we are testing 4.4, 4.3, 4.2 with our CI actions. We should add 4.1 to mix.

I think testing more R versions doesn't solve the issue. If we had tested with 4.1, we still wouldn't have discovered the problem.
If we can add a workflow which tests the package on the minimum R version and minimum package versions as specified in the DESCRIPTION file, it would be helpful. @cicdguy , is this possible?
Otherwise, I would rely on the developers and users that they report wrong minimum versions.

My understanding is that we are saying in our current DESCRIPTION that admiral works with R version 4.0.  However, we are using a pipe |> that was introduced in R version 4.1 in a few lines of code
If we had been testing the package build on 4.0 I believe we would of found this issue out.  Maybe we should just give a try to experiment.
Anyways, I do think the minimum version we suggest in the DESCRIPTION should be tested no matter what! :)


matcher: fix missing HTTP support in IP matcher

Signed-off-by: Xie Zhihao<EMAIL_ADDRESS>Commit Message: matcher: fix missing HTTP support in IP matcher
Additional Description:
Risk Level: Low
Testing: Integration
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #22336

/assign kyessenov


Confusing (incorrect) naming scheme of functions implemented in diffburstshapepop.py

As pointed out in https://github.com/LSSTDESC/lsstdesc-diffsky/pull/70, the functions _get_burstshape_galpop_from_params and _get_burstshape_galpop_from_u_params are mistakenly named. In reality, the _get_burstshape_galpop_from_params is implemented assuming that it accepts unbounded parameters, despite its name convention.
When the _get_burstshape_galpop_from_params is passed unbounded parameters, it behaves as expected. So this function should be renamed, and the current implementation of _get_burstshape_galpop_from_u_params will need to be renamed and modified accordingly.

Digging into this a little more, I'm actually not totally sure that the current functions are incorrectly named. It's possible that the wrong function was simply called in downstream uses of the burstshapepop.py module, such that the best-fitting values of the burstshapepop model were actually calibrated with a different meaning than intended. I think the only way to resolve this is by inspecting the optimization codes used by @alexalar and @gbeltzmo.

This is now resolved


aci: make NewCompressedReader an io.ReadCloser

now NewCompressedReader returns an io.Reader but gzip.NewReader returns an
io.ReadCloser that was leaked.
This patch makes NewCompressedReader return an io.ReadCloser and wraps others
implementing only io.Reader making them an io.ReadCloser with a fake Close
method.
Consequently NewCompressedTarReader must implement a Close method needed to
close the underlying CompressedReader.
In the meantime duplicated code from actool/validate.go is removed in favor of
the one provided by the aci package.
In another patch also XzReader will be changed to become an io.ReadCloser.
As this is an api change, at least rkt and docker2aci needs to be patched when
updating vendored appc/spec in rkt.

There is a stdlib ioutil.NopCloser that you can use instead of making this fake closer.

@vbatts someone stole my idea! :stuck_out_tongue:  Thanks for the suggestion!

@jonboulle please review

Updated after @jonboulle review.


W-13714296 ACB AI feature for Pilot

Because of unverified commits, I created a new PR for this feature.
https://github.com/mulesoft/docs-code-builder/pull/351


Add the kubernetes manifests

As kmm will use kubeadm to source the manifests, they should be provided as required from here in the first instance.

Fixed with #8

Done.


Costume tag delimeter

Hi,
I was wondering if support for costume delimeters, instead of only using spaces, is a feature you are looking to implement. I believe you just have to modify the onChanged in the TextField on main.dart to split value on a costume character. It would be really useful to have users separate tags with comas.
Thank you!

Hey, yeah I think we can do something like that. if onCommaSeperateEnable? 'seperateOnComma':'dontSeperateOnComma' ;


A little bit optimized if else flow in VestedToken

Thanks for contributing @k06a!
This is somewhat subjective but we prefer the style using else. It makes it very clear that the behavior is either-or. Early returns can make code harder to understand.


Skill - BarricadePlus

Reduce enemy damage of every attack after the first in the battle by 50% each time.
So if the enemy attacks 4 times a battle for 16 damage, then the totals will looks like this 16 -> 8 -> 4 -> 2

fine, I may update later


ASP.NET Core looks for index.html in wrong folder when using SSR

Describe the bug
I created a new project and added server-side rendering.
When I enable production mode by setting the (Project properties - Debug - ASPNETCORE_ENVIRONMENT) environment variable = Production, the app won't build anymore.
System.InvalidOperationException: The SPA default page middleware could not return the default page '/index.html' because it was not found, and no other middleware handled the request.
It seems that when using SSR in production mode, ASP.NET Core looks for the angular browser build in the ClientApp/dist folder instead of the ClientApp/dist/browser folder. However in development mode it works fine.
To Reproduce
Steps to reproduce the behavior:

Create a new ASP.NET Core Angular project.
Debug the project. The project works.
Switch to production mode. The project isn't working anymore.
Run ng build --prod or npm run build
Debug the project again. The project can find the angular app.
Setup SSR with following instructions (express-engine): https://medium.com/@pieterjandeclippel/server-side-rendering-in-asp-net-core-angular-6df7adacbdaa
a. Remove the ClientApp
b. Create a new app: ng new ClientApp --style=scss --routing
c. Build the project: ng build --prod. I see that this creates ClientApp/dist/ClientApp instead of ClientApp/dist.
d. Modify the call for AddSpaStaticFiles: configuration.RootPath = "ClientApp/dist/ClientApp";
e. Add Express to the ClientApp: ng add @nguniversal/express-engine --clientProject ClientApp
f. Add aspnet-prerendering: npm install --save aspnet-prerendering
g. Add the SPA prerendering middleware (article).
h. Add node to the types of tsconfig.app.json and tsconfig.server.json
i. Modify main.ts and main.server.ts
j. Remove the dist folder.
k. Run ng build --prod and npm run build:ssr
l. Run the project. The project isn't working
Notice ASP.NET Core throwing the above exception
Switch back to development mode. The project works fine.
Switch back to production mode. Copy over the files from ClientApp/dist/browser to ClientApp/dist (because that's where ASP.NET Core looks). The project works fine.

Repository: https://github.com/PieterjanDeClippel/AspNetCoreSSRIssue
Expected behavior
Equal behavior in production mode as in development mode. In production mode ASP.NET Core should look for the angular app in ClientApp/dist/browser
Additional context
Angular version: 8.1.1
Node version:11.7.0
NPM version: 6.10.1
.NET Core version: 2.2

I think this is a minimal setup.
Without SSR it works fine in DEV as well in PROD.
With SSR the spa-prerenderer looks in

DEV: ClientApp/dist/browser
PROD: ClientApp/dist

Currently I just copy the files from dist/browser to dist when publishing a new version, and the problem is solved.
All steps noted in the thread are required to get SSR working, so there's no step to skip. It's as minimal as it can get. To see the issue in action:

git clone  https://github.com/PieterjanDeClippel/AspNetCoreSSRIssue
Run in Development mode. Wait for the dist/browser and dist/server folder to generate.
Notice the working app. ASP.NET Core looks in ClientApp/dist/browser
(Remove the ClientApp/dist folder)
Run in Production mode. Wait for the dist-folders to regenerate.
Notice the app failing to find index.html (Output window)
Copy the files from dist/browser to dist
Notice the working app.


Create a prototype for OPENSSL_rdtsc

@dot-asm: Does this make sense?
I think so arches have it as long, other as long long.

I raised this a while back: #3125

Trouble is that there is no common type suitable for all platforms. Well, there is one thing one can tell for sure, that return value is 64 bits in all 64-bit builds. Another thing one can tell is that if one tries to use long long in 32-bit builds, then there are platforms where return value will appear gabled. This leaves us with following question, wouldn't long be least troublesome under the circumstances? Yes, long would be least troublesome. With reservation that on WIN64 long is 32 bits. So one can as well argue in favour of size_t, or one can simply say that 32 bits is enough [for purposes of short benchmarking, short enough for not having two wraparounds(*), around a second.]
One can also flip the question and aim for harmonization of all assembly implementations to return 64-bit value. Trouble is that not all processors can deliver that, in which cases single wraparound occurrences(*) will be broken. But one can as well choose disregard this. In other words no matter what one does there always is a corner case :-(
To summarize, given subroutine's usage pattern and overall context is not really inappropriate to be a bit opportunistic and just settle for long (or size_t), but not long long.
(*) one 32-bit wraparound works, because you ignore borrow anyway;

Or we could define an internal type that represents the return value: ossl_rdtsc_value or some such.
I'd also consider a name change: rdtsc is very x86 specific.  openssl_instruction_counter or openssl_fast_counter ?  This function is private so the possibility exists.
We not only use this as a timer but also as a low grade entropy source in the RNG infrastructure.

I'm currently leading towards just making it return an uint32_t.

Another alternative is to simply omit all those #ifdef segments. They are really debugging artefacts, and they are meant to produce meaningful output only in specific and controlled conditions. I won't miss them (since I kept original copies which are more suitable for debugging purposes) and users are better off using openssl speed...

So I've pushed a new commit changing it to uint32_t.  I just don't have an idea if the assembler versions still work properly.

As already said, assembler is good up to size_t.

As already said, assembler is good up to size_t.

This came out a little bit wrong. All assembly modules will work with return type declared up to size_t. [And some 32-bit ones would work with 64-bit return, some will fail...]

It seems like size_t might be the way to go.

Either way works [including removal of #ifdefs]. I'm giving it few day hours in case Kurt changes his mind, and then approving it.


Supporting mock components in snapshot tests

I was trying out the snapshot tests on larger components, closer to full pages instead of individual UI inputs, and was getting large snapshots since the test renderer fully rendered every component down to DOM primitives:

A bunch of snapshot output
```html
exports[`Layout renders correctly 1`] = `

      ...

      ...

    Welcome

      ©

`;
```

But instead of seeing all the divs and spans for my website chrome, I want to see the composite components like Header and Footer instead. For the same reasons why mocking is sometimes useful in traditional JS tests, I wanted mocking in snapshot tests as well:
exports[`Layout renders correctly 1`] = `

    Welcome

`;

So I tried jest.mock('../Header') and jest.mock('../Footer') and Jest ran without an error, but the generated snapshot was missing the header and footer:
exports[`Layout renders correctly 1`] = `

    Welcome

`;

So I think making the test renderer and snapshot generator preserve mocked components would be helpful for testing top-level components like entire pages or screens of an app where you care about the high-level structure and want to mock out some of the components.

Can you try jest.mock('Header', () => 'Header')?

That works well and adds  to the snapshot as expected. Thanks!


eventRender $el.popover is not defined for vue

	<full-calendar
		id="calendar"
		ref="calendar"
		:event-sources="eventSources"
		@event-selected="eventSelected"
		@event-created="eventCreated(true, $event)"
		@event-resize="eventResize"
		@event-drop="eventResize"
		@event-render="eventRender"
		:config="config">
	</full-calendar>

	eventRender(event, $el, element) {
		console.log($el,element);
		$el.popover({
		   title: event.title,
		   content: event.description,
		   trigger: 'hover',
		   placement: 'right',
		   container: 'body'
	    });
	},

emm, I want popover but console :   $el.popover is not defined.
vue /  elementui
What do I need to do?thanks~

Is this how you programmatically initialise the elementui popover? I have not been able to find any reference to the technique you are using in their docs?

Sure but I think #25 is using the Bootstrap popover are you using that too?

thanks,  I tried to introduce bootstarp, but when I was hover, it didn't trigger any effect.

If you are using the code in your previous message, would you need to add 'trigger: 'hover', to the popover config? Also, whereas I am happy to help, I don't think this is an issue with this repo.

			eventRender(event, element) {
				console.log(event,element);
				$(element).popover({
					trigger: 'hover',
					container: 'body',
					placement: 'right',
					title: event.title,
					content: event.description,
			    });
			},

EMM, I'm sorry. You can close this problem, but I may really need your help. Above is my current code. Thanks again

If you could replicate the issue in codesandbox I will take a look at that.

Thank you very much for not introducing the bootstarp style at first, which prevented Popover from being displayed. The problem is the Z-index hierarchy. Another problem with the subsequent introduction of bootstarp. CSS was that he overwrote my original style, and I had to copy the Popover related style into my own file. The following is some of the code, I hope that the eventRender behind the little partners take a detour.
	<full-calendar
		id="calendar"
		ref="calendar"
		:event-sources="eventSources"
		@event-selected="eventSelected"
		@event-created="eventCreated(true, $event)"
		@event-resize="eventResize"
		@event-drop="eventResize"
		@event-render="eventRender"
		:config="config">
	</full-calendar>

        methods： {
	eventRender(event, element) {
		if (event.caltype == '会议') {
			let title = event.title.split(']')[1];
            let room = event.title.split('[')[1].split(']')[0];
            let start = event.start._i.split(':')[0] + ':' + event.start._i.split(':')[1];
            let end = event.end._i.split(' ')[1].split(':')[0] + ':' + event.end._i.split(' ')[1].split(':')[1]
            let time = start + '-' + end;
			let line = '

';
			$(element).popover({
				html: true,
				trigger: 'hover',
				container: 'body',
				placement: 'auto right',
				title: title,
				content: room + line + time + line + event.slave + line + event.description,
		    });
		} else {
            let start = event.start._i.split(':')[0] + ':' + event.start._i.split(':')[1];
            let end = event.end._i.split(' ')[1].split(':')[0] + ':' + event.end._i.split(' ')[1].split(':')[1]
            let time = start + '-' + end;
			let line = '

';
			$(element).popover({
				html: true,
				trigger: 'hover',
				container: 'body',
				placement: 'auto right',
				title: event.title,
				content: time + line + event.description,
		    });
		};
	},
        }


chore: go generate for ISGOMOCK method

related https://github.com/uber-go/mock/pull/144
Whether it is a good idea to generate an ISGOMOCK method

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[SCB-367] Add third party notices

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
 A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #308 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   70.39%   70.36%   -0.03%
==========================================
  Files          17       17
  Lines        3455     3455
==========================================
- Hits         2432     2431       -1
  Misses        853      853
- Partials      170      171       +1

Impacted Files
Coverage Δ

server/service/tag.go
75.43% <0%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7c685...09bda71. Read the comment docs.

Coverage decreased (-0.2%) to 73.961% when pulling 09bda715147edc51032d8330bacb4ceb0d60ee20 on yangbor:master into 0b7c6854f1b7b4b62c67a0048677653d0225938c on apache:master.


TVM support on Android with OpenCL

With reference to the issue,https://github.com/dmlc/tvm/issues/921   i want to know one thing.
Do we need to add topi compute and schedule in CPP to support for running in Android device with OpenCL? or the ones with python alone can work fine?

no, the current example should run fine

Now I get the cross-compiled xxx_aarch64.so, but how can I use this lib in android? I can hardly find the C++ API.
I want to write a android app using the cross-compiled xxx_aarch64.so, can you give some examples ?
@tqchen @ezyang


Doesn't recognize JS Doc Type Information

I'm trying to use Tern to perform type inference on some Javascript code. However, the type inference doesn't seem to be using the JSDoc comments alongside the code.
I'm using the code /** @type {Foo} */ let x; as an example of the problem. On the Tern website's demo page (which uses CodeMirror), the editor is able to infer that the type of x is Foo.
Yet, when run locally via node, I get this back: { type: '?', exprName: 'x' }.
Here's a snippet that replicates the issue:
const tern = require('tern');

const ternServer = new tern.Server({
    plugins: {
        doc_comment: {
            strong: true
        }
    }
});

const js = `/** @type {Foo} */ let x;`;
ternServer.addFile("main", js);
ternServer.request({
    query: {
        type: "type",
        file: "main",
        start: js.length - 2,
        end: js.length - 2
    }
}, console.log);

Tern has otherwise been working perfectly fine for type inference. It's when using the JSDoc comments that it doesn't seem to work with the way I've initialized and called it.
Any ideas why this doesn't work?
FWIW, this is cross-posted on Stack Overflow but hasn't garnered much traction. I'm not sure whether this is an issue with tern itself, or that my code is messed up (probably the latter). The documentation for doing this was a little unclear, so perhaps that's worth some attention.
Thanks!

 After looking at the source of some of the other applications that use tern, I realized I was missing this line: require("tern/plugin/doc_comment");.


"alignOutput" doesn't work across different Logdown versions

I have a webpacked module (cryptobox.js), which bundles my application together with Logdown.
In my main application I am loading this module and I am loading another Logdown via the script tag, to log inside my main application (because the bundled Logdown is not accessible from the outside).
Doing this I realized that the alignment is different:

Maybe it would be a good idea to allow numbers as values for alignOutput, so that you can set the spacing manually as a fallback. @caiogondim: WDYT?
Here is my code:
<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8" />
    <title>Demo</title>
    <link rel="shortcut icon" href="data:image/x-icon;" type="image/x-icon" />
    <script src="lib/dynamic/logdown/index.js"></script>
    <script src="bundle/wire-webapp-cryptobox.js"></script>
  </head>
  <body>
    <script>
      var storage = new cryptobox.store.IndexedDB('bundle_test');
      var box = new cryptobox.Cryptobox(storage, 10);

      box.init().then(function() {
        var logger = new Logdown({prefix: 'bundle_test', alignOutput: true});
        var fingerprint = box.identity.public_key.fingerprint();
        var message = 'Local Identity: ' + fingerprint;
        logger.log(message);
      });
    </script>
  </body>
</html>

I guess we should strive for simplicity.
Your use case seems odd for me.
You're using a bundle with Logdown and Logdown without a bundle?
Since you already have a bundle system and a Logdown inside the bundle, it's just a matter of exposing it globally.
Then you would share the same class.
I don't see value on having more than one class of Logdown in the same env.

Ok, accepted. 😄


Translate How to Contribute

Translated How to Contribute page.
Please kindly review my work.
Thanks!

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!


Self-Signed Cert Check Is Broken

If a server doesn't send any intermediate certs, the self-signed check will indicate that it's self-signed, when in reality, it's missing an intermediate.
Missing intermediate:
https://www.ssllabs.com/ssltest/analyze.html?d=epdocs-test.engie-ep.com&hideResults=on
Self Signed:
https://www.ssllabs.com/ssltest/analyze.html?d=www.linux-faqs.info&ignoreMismatch=on

Note - this only impacts the --internalssl mode, not the default SSL Labs mode.


[AzureML] correct param desc in online_endpoint.py

I corrected description of param in online_endpoint.py
Mirror traffic is for inferencing, so I corrected from "train" to "inference".
This is a change to correct a description in the following document.
https://docs.microsoft.com/en-us/python/api/azure-ai-ml/azure.ai.ml.entities.onlineendpoint?view=azure-python-preview

#assign-reviewer: @dem108

#assign-reviewer: @hugoaponte