[Bug]:  Stretchly prevents system sleep on Debian with Gnome

Version

[X] I'm using version 1.6.0

Known issues

[X] I've checked Known issues

Existing issues

[X] I've checked Existing issues

What operating system are you using?
Linux
Operating System Version
Debian
Reproduction steps

Let the computer be idle

Expected Behavior
Computer sleeps
Actual Behavior
Computer doenst sleep while stretchly is running.
Relevant log output
No response
Preferences
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Interesting, I don't even know where to look. I have Debian with KDE. Could you please make a screenshot of your "Sleep" settings?

I believe it is the notifications. Just a minute ago my laptop had its screen off, and suddenly it went on, on the bottom displayed an information about a new notification from Stretchly.

Maybe try disabling notifications in Preferences -> Schedule?
What is your break schedule setup?

I'm trying your settings on my work ubuntu with gnome but all seems good, system went to sleep

I will investigate more, when I am back at that laptop!

I just had the time to test.

There was no other app running
I set the sleep timer to 700 seconds using dconf-editor

Without Stretchly: Sleep after 700 seconds
With Stretchly: No Sleep. It didn't matter if I had notifications
enabled. Also the "natural break" detection doesn't seem to work, when I
came back stretchly started a large break immidiately after.
Do you know if there is a log, about what keeps the system awake?

Do you know if there is a log, about what keeps the system awake?

No idea, never heard about it and could not google anything.
Could also paste the logs from your test here? Preferences -> About -> Ctrl+D -> logsFile

You need to find the inhibitors, a.k.a. which processes are preventing your suspend:
systemd-inhibit --list --mode=block
That will list the processes which do not "want to sleep"
says stackexchange. Will try it later and also send the log
18.05.2021 13:40:21 Jan Hovancik @.***>:

Do you know if there is a log, about what keeps the system awake?

No idea, never heard about it and could not google anything.
Could also paste the logs from your test here? Preferences -> About -> Ctrl+D -> logsFile
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[https://github.com/hovancik/stretchly/issues/931#issuecomment-843095301], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AQEZOY4ZCU6EJKQXPNQ2FDDTOJGZ5ANCNFSM43O5LZVA].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Verfolgungsbild][https://github.com/notifications/beacon/AQEZOY4QWONZ5TFNMPB3AG3TOJGZ5A5CNFSM43O5LZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGJAJ2BI.gif]

Here's what I get:
➜  ~ systemd-inhibit --list --mode=block
WHO        UID  USER  PID  COMM            WHAT                                                                       WHY                      MODE
PowerDevil 1000 conta 1328 org_kde_powerde handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch KDE handles power events block

1 inhibitors listed.

Systemd also doesnt list anything out of order:

WHO UID  USER PID  COMM           WHAT                                                     WHY                       MODE
xxx 1000 xxx  2456 gsd-media-keys handle-power-key:handle-suspend-key:handle-hibernate-key GNOME handling keypresses block

1 inhibitors listed.

Interesting then, not sure. Might be worth trying to see what systemD will show when system seems not to go to sleep. I found that there is some API in electron to disable sleep but I am not using it.

@ekasprzak could you try disabling pre break notifications and see what happens? It's in Schedule tab.

@hovancik yes, I meant those notifications exactly, I was pretty sure that those are the issue (not the notification itself, but its "stickiness" in GNOME), but I waited to actually test it and yes, I can confirm that at least in my case it makes screen/monitor auto off work.
@tzugen I know it's been some time, but if you're still using Stretchly, maybe you could check if this solves your problem with system sleep (then, we would be sure that it's the sticky notification, not Stretchly itself issue) ?
As a summary - I don't consider it as solved, cause I really like this pre break notification", so I have at least a short moment to finish/pause what I was doing and prepare for a break (instead of immediately click on skip when I'm in the middle of sth and there is no pre break notification).

@ekasprzak can you try running Stretchly from source, specifically PR linked above? I think it should fix it.

@ekasprzak can you try running Stretchly from source, specifically PR linked above? I think it should fix it.

Yes, it does!
Notification disappears by itself, doesn't prevent screen going off, which was my main issue.
But, because I kind of stole this issue (preventing sleeping) because I was pretty sure it's connected so tested that too, enabled system auto sleep and this also worked after inactivity time)
So, all good (Fedora 37 Workstation/GNOME), thanks a lot @hovancik!


Add Yicheng

Highlighted contributions

Flytekit timeline deck
Flytekit runtime metric
Real-time flyte deck
bug fixes for the Ray plugin
https://github.com/flyteorg/flytekit/pulls?q=is%3Apr+author%3AYicheng-Lu-llll

What repositories do you expect to keep contributing to?
flyteadmin, flytekit, flyteidl, flyteplugins, flytepropeller
What is the name of your current organization?
UIUC / Influxdata
Any other context that you wish to share?
cc @Yicheng-Lu-llll

+1

+1

+1

Off topic:

Real-time flyte deck

Can we maybe use this to solve this problem (display links to e.g. wandb which are generated at runtime in the flyte console before the task ends)?

+1

Approved. Welcome @Yicheng-Lu-llll!


Normalize error thrown in ObjectQueue Iterator#next()

use factory methods instead of implementing classes directly
use generics in test

LGTM

LGTM, too


Make Evidently Metric Server more configurable

Allow for

custom statistic test (so far determined by evidently)
threshold for drift detection
window size for determining drift

Links that might be helpful

https://docs.evidentlyai.com/reports/data-drift
https://docs.evidentlyai.com/user-guide/customization/options-for-statistical-tests
https://docs.evidentlyai.com/user-guide/customization/options-for-data-target-drift


How will we index posts for searching?

Up for discussion

Use hosted solution like https://www.algolia.com
Using existing database capability (e.g. postgresql)
Using specialise database like Elasticsearch

@lxcid @kajalsinha does this work for simple indexing to start with?
https://github.com/blevesearch/bleve


See if memory provider's queue can use a min-heap instead of a slice.

We can't implement LoadQueueMessages() on a heap >_<


Documentation

Currently README is the only documentation available regarding API endpoints, internals, configuration, and contribution.
To solve this issue, we should create comprehensive documentation detailing the workings of the system to make it easier for new contributors, or integrator to make use of Piston.
We could possibly use something like readthedocs or a GitHub Pages solution with Jekyll to complete this task, making it as simple as possible to modify and have a beautiful display for our docs.
cc @dthree

I made a small start in docs/, automatically publishing them at https://piston.readthedocs.io


feat: add support for stage/prod env switching

See also https://github.com/adobe/aio-lib-env
The env key in the constructor for the Ims object will override the global env value set.
Closes #32 as well
How Has This Been Tested?
npm test
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

LGTM. I guess we also need to change the default here? https://github.com/adobe/aio-cli-plugin-auth/blob/master/src/commands/auth/index.js#L44

actually looking at the code, it should have defaulted to env (thus the doc was wrong). I'll fix up the doc


I want fix the wind speed range in rose plot

please see the attached images
I want to compare the 2 plots but the wind speed that is shown in the legend is different
ax,set_ylim is not working
here is my code
from windrose import WindroseAxes
from matplotlib import pyplot as plt
import matplotlib.cm as cm
from numpy.random import random
from numpy import arange
import pandas as pd
MON=pd.read_csv(r'data.csv')
ws = MON["Ws"].values
wd = MON["Wd"].values
ax = WindroseAxes.from_ax()
ax.set_ylim(0,50)
ax.bar(wd, ws, normed=True, opening=0.8, edgecolor='white')
ax.set_title('plot2')
ax.set_legend()

Hi, it appears that the example you gave is using code from a different Python module, for example, there is no WindroseAxes object in this package. Also, your question is referring to matplotlib functionality.


Inventory of test certificates is out of date

The list of test certificates, tests/data_files/Readme-x509.txt, is out of date and needs updating.

ARM Internal Ref: IOTSSL-1231


Clock has wrong time

The Wombats have the wrong time. Serial # ending in DC0 seems to be ahead one hour. I do not know if this is a DST problem.

Probably related to issue #23 .


[WIP] Remote sync revamp

Don't review this.  This is actually four separate commits I will be splitting up in the very near future.
Uploading this to a branch in the event my computer gets hit by a bus.
Notable updates:

remote sync engine was moved to a serial statemachine
handle a sendCompletion (failure) in order to kick the state machine to an errored/clean up restart
Added cancel interface to cancel event reconciliation queue, model reconciliation queue, listeners, mappers, etc.
Added sending connection information from API in order to decide when subscribeInitialization succeeds (e.g., if we can't make a subscription connection, then we shouldn't be doing an initialSync)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this pr.. as i have split this PR into 4 distinct PRs:
https://github.com/aws-amplify/amplify-ios/pull/321 - migrating to a state machine
https://github.com/aws-amplify/amplify-ios/pull/322 -added retry logic to sync engine, without canceling downstream async operations
https://github.com/aws-amplify/amplify-ios/pull/323 - added in the cancelling interface
https://github.com/aws-amplify/amplify-ios/pull/324 - cancelling the downstream operations & wait for subscription to init.


Feature add support for markdown and mentioned people in /messages Posts

Added code to support markdown in messages. This is particularly needed in order to test bots in group spaces when the bot will only respond to commands where the bot is mentioned.
This commit also includes a set of postman based tests that sends markdown messages to the Spark platform and to the emulator and compares the return values.

note: as there were some overlapping bot-tests middleware, see other PR, I 've merged manually
closing this PR


Make it possible to run nfd as a DaemonSet

The option to run NFD as a one-shot job is still available

@marquiz Thanks for adding the details on how you tested it. I've left some minor comments on adding docs on --sleep-interval. LGTM after that.

I changed the documentation as you suggested. However, linking from the template to README is not possible when the template format is JSON. Please take a look at #108 which would ﬁx this problem.
Another change is that I also updated the "Command line interface" section of README to include the new command line options.

Thanks for making the changes @marquiz. May be the comment was confusing but I meant a link in the readme to the line in the template similar to https://github.com/kubernetes-incubator/node-feature-discovery/blob/master/node-feature-discovery-job.json.template#L34. We don't need #108 for this.

I pushed a new version addressing your comments.

We don't need #108 for this.

OK, but I'm waiting for comments on that, anyway :)


AUR package name

I'm planning on packaging vmd for Arch Linux. But "vmd" is already taken as a package name in the Arch User Repository (AUR) by a program that does "Visual Molecular Dynamics".
Is there a preferred alternative name that I should use? Any suggestions?

Maybe vmd-viewer, vmd-app, vmd-markdown or something like that.

vmd-markdown, vmd-md, vmd-npm, visual-markdown, view-markdown, varying-meat-dice, vexing-musk-dispenser ?

I presume the package is not yet in AUR? (I think vmd-markdown would be a good name.)

@kaptoxic Yeah, I'm still hesitating. The problem is that there is some logic (though little) inside bin/cli.js. This would mean that the AUR package would depend on both Node.js and Electron. Electron already contains Node so depending on a second time just to launch Electron would be a bit much.
I haven't yet figured out the best way to do it. There are several ways to create the package:
vmd as-is
Use vmd as-is and install Node just for bin/cli.js and Electron for the rest.
Pros:

Easy

Cons:

Large footprint because it depends on Electron and Node.js

Don't use bin/cli.js in the AUR package
Create a separate entry script in Bash that does the same as bin/cli.js but doesn't depend on Node.js.
Pros:

Doesn't depend on Node.js

Cons:

The entry script would have to be maintained separately and always updated with the functionality from bin/cli.js.

Separate vmd from Node
Update vmd so that vmd itself (all the stuff the runs inside Electron) is separated from the rest. This means that the package.json can not include the electron-prebuilt dependency and has to be separate. But then vmd could be launched with any compatible version of Electron like electron vmd/server.js my-markdown.md.
Pros:

Easy to maintain AUR package
Clean and modular solution
Independent from Node
Must not necessarily be bundled with Electron (could use shared binary) or could even be used with alternatives to Electron (or forks) with a compatible API or a compatibility layer
Electron and vmd could be updated independently
vmd could theoretically be made to auto-update

Cons:

A lot of work and will need structural changes
Two separate projects/packages needed:

The code that runs inside Electron needs to be a separate package
The package that's published on npm will then depend on electron-prebuilt and the new package, and include the bin/cli.js entry file

I am not confident about what would be the right decision (nor am I familiar with JS frameworks), but it seems that the solution with the smallest footprint/least internal dependencies (third one) is the right way to go. If I understood correctly, in that case, some work is required and the package would just depend on existing AUR packages (e.g. electron).

@kaptoxic I moved the logic from bin/cli.js (aa0f54f) and it should now be possible to create an AUR package without Node.js. It's still needed as a build dependency but it will be removed after installation unless you have installed it explicitly.
Depending on the electron AUR package would be ideal but it's also dangerous. Electron releases new versions very often and the API isn't stable yet and breaking changes are being introduced quite often. So in order to stay compatible with the Electron AUR package we'd have to constanty keep an eye on it.
It might be better to download a separate copy of Electron for vmd until Electron 1.0 gets released.


Lab3, part 2 pong will not save video correctly

"save_video_of_model(pong_model, "Pong-v0", filename='pong_agent.mp4')" will fail because
save_video_of_model does not call pre_process on the observations, the model expects a pre-processed tensor of size 80*80 and not the raw one that comes from the Pong-v0.
as a hack, I changed (just for the pong model)
action = model(tf.convert_to_tensor(obs.reshape((1,-1)), tf.float32)).numpy().argmax()
to
action = model(tf.convert_to_tensor(pre_process(obs).reshape((1,-1)), tf.float32)).numpy().argmax()

Thanks for sharing :+1:


fix: trim a new line to avoid making the invalid autofix result

Summary
close #1514

Test Plan
add snaps for cases

@togami2864
Could you add a changelog entry under linter / Bug fixes and then run just gen-web?

Thanks!


Handle Japanese Snowflake error message for non-existing schemas

resolves #834

Problem
Handling is failing because the error message is different between Japanese and English.

Solution
Handled Japanese error messages.

Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

<EMAIL_ADDRESS>USER MY_USER set LANGUAGE = 'ja';
+----------------------------------+
| status                           |
|----------------------------------|
| Statement executed successfully. |
+----------------------------------+
1 Row(s) produced. Time Elapsed: 0.096s
<EMAIL_ADDRESS>terse objects in db.schema;
002043 (02000): SQLコンパイルエラー：
オブジェクトは存在しないか、操作を実行できません。
<EMAIL_ADDRESS>USER MY_USER set LANGUAGE = 'en';
+----------------------------------------+
| status                                 |
|----------------------------------------|
| ステートメントは正常に実行されました。 |
+----------------------------------------+
1 Row(s) produced. Time Elapsed: 0.126s
<EMAIL_ADDRESS>terse objects in db.schema;
002043 (02000): SQL compilation error:
Object does not exist, or operation cannot be performed.

@dbeatty10
I fixed and CLA signed.
Please review.

Hi @pei0804 - Thanks for putting up this PR. What you proposed would work, but only for Japanese and only for this error. In order to merge a fix, we would need it to be generally applicable to all language changes. I've created #843 which is describes the change we would need.

@nathaniel-may
As for the other methods, do I fix another PR?

@dbeatty10 fixed.

@pei0804 thanks for the change! I'm adding this PR to the queue to be reviewed by an engineer.


Add additional pages to frontmatter

Puts the intro to QC and intro to Qiskit in the frontmatter (they are still accessible via in content links as well).

Artifacts look good.


SpectrumSlider vs NumberControl

In https://github.com/phetsims/wave-interference/issues/377 and moved to a new issue https://github.com/phetsims/wave-interference/issues/394, the wavelength slider in Wave Interference Diffraction Screen currently looks like this:

It was requested that:

Format like Wavelength NumberControl in Bending Light -- Readout between tweakers above track.

Here's how Bending Light's Wavelength control looks:

Unfortunately, NumberControl doesn't have an option to use a wavelength gradient for the track, and WavelengthSlider doesn't support the rich layouts that NumberControl supports.  In bending light this was accomplished with custom code which is roughly here: https://github.com/phetsims/bending-light/blob/a1ee4a52fbd48763975cb90e271674dfc33d8552/js/common/view/WavelengthControl.js#L43-L110 and can be described as "delete the tweaker buttons that come with the WavelengthSlider and create completely different ones".
@pixelzoom and @samreid are listed as authors of WavelengthSlider.  @pixelzoom is listed as author of NumberControl.  So first I'd like to reach out to @pixelzoom to see how he recommends to proceed.

BLL has yet-another layout (see below), and I suspect that there are others if we look around.
First, I don't recommend trying to shoehorn a WavelengthSlider (or SpectrumSlider) into NumberControl.
Second... What's the reason for the difference? They both display the same information. Did you push back on the design?  Could the current layout work for Wave Interference?  Could the newer layout be used for all sims?  What is the advantage of having different designs, shouldn't it be standardized?

@ariel-phet and/or @arouinfar can you please comment?

In my opinion, the layout used in Bending Light should be one of the standard layouts of the WavelengthSlider.
For context, here's the Diffraction screen of Wave Interference

A few reasons why I suggested using the Bending Light configuration

The panel is rather limited in width, and the slider track is pretty compressed. A wider track would provide for a more precise interaction with the thumb.
The readout follows the slider thumb. This looks VERY strange to me, and I have never seen it in any other sim before. To me, it looks much cleaner for the readout to live in a stationary white box, as other readouts do.
The requested layout used previously in another sim. How was I supposed to know that this was a sim-specific customization of a common component?

BLL has yet-another layout (see below), and I suspect that there are others if we look around.

Where would you recommend designers look for this information? Beer's Law Lab doesn't seem particularly generalizable, since the NumberControl readout needs to be separate from the slider track. I haven't seen that interaction pattern in other sims, though it certainly makes sense for BLL.
@pixelzoom are you suggesting that this layout (edited to remove radio group) is a supported layout of WavelengthSlider? It's not in the scenery-phet demo.

As a side note, I really wish we had a functional style guide. Manually searching through simulations for instances of some common component (and then trying to cross-reference associated .js files to make sure the visual in the sim truly is the common component it appears to be) is burdensome, prone to errors, and only gets more impractical as our library of HTML5 simulations grows.

First, I don't recommend trying to shoehorn a WavelengthSlider (or SpectrumSlider) into NumberControl.

I'd also like to hear more on this point.  SpectrumSlider seems like it is duplicating most of the work already done in NumberControl or Slider. What work would be necessary to combine these components other than (a) adding an option to draw a pattern in the track and (b) adding an option to show the thumb under the track?

@arouinfar said:

In my opinion, the layout used in Bending Light should be one of the standard layouts of the WavelengthSlider.

Bending Light does not label it as "Wavelength".  Is that acceptable for all sims? I doubt it.

Where would you recommend designers look for this information?

sun and scenery-phet both have UI component demos.  WaveLengthSlider is represented in scenery-phet, and here's what it looks like:

@pixelzoom are you suggesting that this layout (edited to remove radio group) is a supported layout of WavelengthSlider?

No.  I was recommending that (a) we should pick one standard layout, and (b) we do not attempt to shoehorn WavelengthSlider (or its superclass SpectrumSlider) into NumberControl.

As a side note, I really wish we had a functional style guide.

PhET doesn't really have that many common UI components.  The problem (imo) is that developers and designers are not familiar with everything with everything that's in sun and scenery-phet.  And the demos (visual guides) in sun and scenery-phet are incomplete.

@pixelzoom said:

First, I don't recommend trying to shoehorn a WavelengthSlider (or SpectrumSlider) into NumberControl.

@samreid said:

I'd also like to hear more on this point.  ...

There is much that could be generalized and factored out from NumberControl.   For the same reason that Slider can be used independently of NumberControl, WavelengthSlider should be usable independently of whatever more complex component it is ultimately part of.
Also keep in mind that a sim like MOTHA requires decoration of its WavelengthSlider with absorption wavelength indicators.

For the same reason that Slider can be used independently of NumberControl, WavelengthSlider should be usable independently of whatever more complex component it is ultimately part of.

How about a dependency injection approach, so that NumberControl can use Slider or WavelengthSlider?
But I'm still wondering if phet-io and accessibility will both be simpler if we make it so you can render a gradient (or optional absorption wavelength indicators) in Slider.  Maybe WavelengthSlider can be a subclass of Slider, for example.

More...  Slider and WavelengthSlider are very different beasts.  Slider and NumberControl are already exceptionally complicated.   And I think you're underestimating the complexity of (a) trying to make WavelengthSlider extend Slider, and (b) trying to add options to NumberControl to support subclasses of Slider.   I don't think that it's going to be good for Slider or NumberControl.

Can I also suggest that we transfer this issue to scenery-phet? It has nothing to do with scenery.

My mistake, I'll move it now.


[spi_device] implements Flash Status register in spid_status submodule

Flash mode STATUS register is implemented in this module rather than
relying on the regtool. The reason is that the STATUS read by the SPI
host system. The value should be propagated into SCK domain. Due to the
lack of SCK while CSb is de-asserted, it needs special cares to safely
used in SCK.
Before returning the STATUS register value to the host system
corresponding to the Read Status commands (05h, 35h, 15h), the logic can
get 8 SCK clock edges. The logic synchronizes CSb into SCK domain first.
Then create a pulse to latch the STATUS register in SCK domain.
If a command is uploaded (handled by spid_upload), it sets BUSY bit to 1.
The value is latched in the SCK domain first. Then, when CSb is
de-asserted, the logic synchronizes CSb into the bus clock domain to
create a pulse signal. That pulse signal will latch the STATUS register
from SCK domain into the bus clock domain.
The STATUS register in the bus clock domain can be updated only when CSb
is not asserted in order to prevent any CDC issue. The safest way is to
hand the busclock synched CSb signal over to SCK clock domain again but
it may not be possible to latch the register within the 8th posedge of
the SCK if the bus clock is slow.
BUSY is set by HW. The value is not directly broadcasted to the
passthrough module. It is, first, applied into the bus clock domain. Then
the signal is broadcasted to Passthrough to filter-out the following
commands until the BUSY signal is released

Merged in #7565


pylint next for search

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-search-documents

/azp run python - search - ci


Add ability to mark which projects need volunteers

So that we can focus efforts to the right projects and let project owners let people know when they don't need more help. Eventually we can filter/segment by this option.

Semi-resolved in #108 and #110 . cherry on top will be the new homepage (#101)


Add Template Input, Output and Error Properties

Add element template properties for inputs, outputs and errors reusing existing implementations.
Input Parameters

reuse existing group and entry
display template label or binding name as title
do not display name entry
display description
display Local Variable Assignment toggle

Output Parameters

reuse existing group and entry
display description
display Process Variable Assignment toggle
display Assign to process variable

Errors

reuse existing group and entry
disable Throw expression entry
do not display Global error referenced entry

Depends on https://github.com/bpmn-io/properties-panel/pull/115

In comparison to the old template output parameters, the properties for "Process variable name", "Assignment type" and "Value" are still visible. Is this intended? This is the state for the old properties panel:

In comparison to the old template output parameters, the properties for "Process variable name", "Assignment type" and "Value" are still visible. Is this intended? This is the state for the old properties panel:

No. I missed something. 😓

@pinussilvestrus fixed 🛠

We agreed to have a dedicated review with an artifact that contains all template implementations. Therefore, we skip design review for this PR.

https://user-images.githubusercontent.com/28307541/140496626-0cfd37a5-d969-4e03-9083-50bab80fc43c.mov
If it is to be disabled then the inputs should have disabled attribute.

We forgot to include the connector input/output in the plan. @philippfromme please tell whether you want to include it in this PR. It's also OK to do it in a separate PR by me or somebody else from the team.

Screen.Recording.2021-11-05.at.11.26.39.mov
If it is to be disabled then the inputs should have disabled attribute (or preferably be just text).

This case can only be produced by manually changing the XML. The element has a camunda:modelerTemplate attribute but no template was applied.

🎉


[TACHYON-1637] Add the Chinese version of documentation page 'Contributing-to-Tachyon'

https://tachyon.atlassian.net/browse/TACHYON-1637

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8399/
Test PASSed.

Thanks for the translation! left a few minor comments.

@ifcharming Well, I just thought these need not to be translated..

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8406/
Test PASSed.

LGTM
Thanks @saltylin  -- it's not big deal :)

LGTM. Thanks for the translation.


Unify naming in common.aggregation

What should be done?
To make naming more consistent, each aggregation stage should have stage suffix, see groupStage as an example. We need to ensure that all the stages have this suffix too.
Where?
https://github.com/FerretDB/FerretDB/tree/main/internal/handlers/common/aggregations
Definition of Done

spot refactorings done;
something else?

I don't think refactoring is ever a good first issue – that requires some prior experience with a code base to understand what is a good refactoring


Add near plugins

Description

Using near-plugins for the access control
Remove AdminControlled interface
Change access control: now only aurora_engine account can access to engines methods, not self/owner
Change access control: the Self don't have access to admin methods by default

Performance / NEAR gas cost considerations
For unknown reasons, the test test_migration_state had failed after this update, so it was fixed by increasing the gas burnt check from 1984 to 1992

Testing
All the tests were updated according to the new interface and new access rules.

How should this be reviewed

Additional information

@olga24912, please fix the tests


Add Exponential Retry Mechanism with Idempotency Headers

In order to enhance the resilience and reliability of our SDK, we would like to introduce an Exponential Retry mechanism for retrying failed requests. Additionally, to ensure the idempotent processing of requests, it's vital to incorporate support for providing an Idempotency Key as per the draft specified in the HTTP Idempotency Key Header Field.
The key requirements for this implementation include:

Exponential Retry Mechanism:

The SDK should retry failed requests following an exponential backoff strategy to minimize the contention and impact on the systems involved.
The SDK should ensure that the retry mechanism is configurable (e.g., max retries, initial delay, maximum delay).

Idempotency Key Provisioning:

The SDK should allow for either automatic or manual provisioning of an Idempotency Key for each request.
The Idempotency Key should conform to either CUID, ULID, or UUID formats as specified in the draft.
The Idempotency Key should be included in the HTTP Header as Idempotency-Key and following the standards outlined in the draft.

Configuration and Documentation:

The SDK should provide configuration options for enabling/disabling the Exponential Retry mechanism and Idempotency Key provisioning.
Comprehensive documentation should be provided explaining the configuration options, operational behavior, and the benefits of using the Exponential Retry mechanism along with Idempotency Keys.

Acceptance Criteria:

[ ] Implementation of the Exponential Retry mechanism with configurable parameters.
[ ] Provisioning of Idempotency Keys, either automatically or manually, conforming to specified formats (CUID, ULID, or UUID).
[ ] Adequate unit and integration testing to ensure the robustness and reliability of the implemented features.
[ ] Comprehensive documentation on the usage and configuration of the Exponential Retry mechanism and Idempotency Key provisioning.
[ ] Adherence to the specifications outlined in the HTTP Idempotency Key Header Field draft.

Update: You can reference the go-lang library to keep the method signature and configuration the same.
https://github.com/novuhq/go-novu/pull/62
Please refer to the draft for further details on the HTTP Idempotency Key Header Field and ensure adherence to the specified standards while implementing this feature in the SDK.

@Cliftonz I would love to work on this.

I just assigned this to you. @Eazybright

Thanks

@Cliftonz PR raised: https://github.com/novuhq/novu-ruby/pull/50
cc: @unicodeveloper

Thanks. @Eazybright this will be closed now.


Repo sync for protected CLA branch

The pull request is created from master637357001765600172 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


unit test compile error Msvc  Release

Search before asking

[x] I searched the issues and found no similar issues.

MSVC+Release+ninja/MSBuild/NMake have the same error
error C4737: 无法执行所需尾调用。性能可能会降级。

WINDOW11 + VS 2022
HOST : WINDOW X64
TARGET: WINDOW X64
MSVC: CXX compiler identification is MSVC 19.34.31935.0
SDK: Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.22621.

❗❗❗❗ code can‘t compile for some unit test target such as test_coro_rpc_server  ->compile process will stop for a long time  or exit

Debug Type no error
Release has error
Other Type ❓[no tested]

What happened + What you expected to happen

Strange error.

Could you use an elder version to test, before friendly cmake PR.

after some test I find that if you use add_compile_options("/EHa")  for msvc release host-win64+target-win64  , unit test code can compile and run .
But maybe "/EHa" is not so good.  Here is a page talk about /E option for msvc https://learn.microsoft.com/en-us/cpp/build/reference/eh-exception-handling-model?view=msvc-170

I also find that  if you use win32 toolchain :  msvc release host-x86+target-x86 unit test can compile, but they can't run.
C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx86/x86/cl.exe

Strange..............................

after some test I find that if you use add_compile_options("/EHa") for msvc release host-win64+target-win64 , unit test code can compile and run . But maybe "/EHa" is not so good. Here is a page talk about /E option for msvc https://learn.microsoft.com/en-us/cpp/build/reference/eh-exception-handling-model?view=msvc-170
I also find that if you use win32 toolchain : msvc release host-x86+target-x86 unit test can compile, but they can't run. C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.34.31933/bin/Hostx86/x86/cl.exe

Strange..............................

Yes, I found this workaround too. And I found some exists  unfixed issue in msvc.It seems a bug in msvc tail recursion optimization.

See bug report

Fix by #107


DOC: Update stylistic consistency in multiple files

Corrected punctuation, stylistic issues, and ensured consistency in multiple files. These are very minor revisions (such as changing 2-dimensional to 2-D, for instance) and do not interfere with the content proper of the code. I'll (very) soon submit new changes but wanted to split the pull requests to ensure a more manageable review.

What does this implement/fix?
Fixed stylistic issues and correct inconsistencies in the multiple files.

I think you are still behind the master. On your local computer first check if scipy is a remote repo. When I type git remote -v I get
origin  https://github.com/ilayn/scipy.git (fetch)
origin  https://github.com/ilayn/scipy.git (push)
upstream        https://github.com/scipy/scipy.git (fetch)
upstream        https://github.com/scipy/scipy.git (push)

origin is my own fork and upstream is the official repo.
On my local fork, master branch I write these one-by-one
git fetch upstream  # Gets the official updates
git rebase upstream/master  # rebases my own fork to the official
git push origin  # sends the changes to github

Do this before you branch off and your branches will be closer to the actual codebase as much as possible.

Thanks, @ilayn. Well, I get this:
Majas-Air:scipy Maja$ git remote -v
origin	https://github.com/mkg33/scipy.git (fetch)
origin	https://github.com/mkg33/scipy.git (push)
upstream	https://github.com/scipy/scipy.git (fetch)
upstream	https://github.com/scipy/scipy.git (push)

And before doing anything I fetch upstream. It's confusing because I sometimes edit files on two different computers and there might be some hidden mistake. I'll just delete the branch, try to update the fork again and create a new branch.

Fetching only brings the status of the upstream. It doesn't actually updates anything on your repo. It is the rebasing that fast forwards your repo.
Once you update your remote repository you can still do that delete/rinse/repeat operation. If you push your branch to remote and pull from the other computer you won't have any chance to make a hidden mistake. That's basically what all version control system is about.

Your branch is quite recent though so apparently you updated it successfully.

Yeah, I get that about version control :-) What I meant by hidden mistake was that the SciPy folder on one computer wasn't even a git folder (because the computer wasn't connected to the Internet). And the fork was on a different machine. Hence the confusion. OK, I think the problem has been solved now, thanks for the tip. I don't think it's a good idea to work offline but I had no other choice at one point. Thanks again!

Looks great, merged. Thanks Maja!


Fix product photos importing

Closes #150

Codecov Report
Base: 97.93% // Head: 97.62% // Decreases project coverage by -0.31% :warning:

Coverage data is based on head (3b34dc8) compared to base (02d4efe).
Patch coverage: 42.85% of modified lines in pull request are covered.

:exclamation: Current head 3b34dc8 differs from pull request most recent head dc96f5c. Consider uploading reports for the commit dc96f5c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   97.93%   97.62%   -0.31%
==========================================
  Files         174      174
  Lines        2854     2868      +14
  Branches      157      161       +4
==========================================
+ Hits         2795     2800       +5
- Misses         47       54       +7
- Partials       12       14       +2

Impacted Files
Coverage Δ

src/import-export/zip-serializer.service.ts
86.88% <0.00%> (-9.55%)
:arrow_down:

...products/product-photos/product-photos.exporter.ts
90.90% <60.00%> (-9.10%)
:arrow_down:

.../products/product-photos/product-photos.service.ts
92.72% <75.00%> (-1.40%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


drag speed when using css zoom

We are using css zoom to change the dynamically scale down the size of a group of react controls that includes a sortable and sortable items. When doing so, if we drag a control to sort then it will drag at a slower speed then the mouse.

interesting, I'm unfamiliar with how zoom works, so a working demo might help.
Sent from my iPhone

On Jun 17, 2016, at 20:56, mikevandre<EMAIL_ADDRESS>wrote:
We are using css zoom to change the dynamically scale down the size of a group of react controls that includes a sortable and sortable items. When doing so, if we drag a control to sort then it will drag at a slower speed then the mouse.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing for no further progress.

Im sorry. I left for vacation and just got back. If you could re-open this ticket I would really appreciate. Here is some sample code. You will notice that the cursor moves slower than the div being moved. If you change zoom to less than 1 then the cursor will move faster than the div:
import React, {PropTypes} from 'react';
import Sortable from 'react-anything-sortable';
import DemoHOCItem from './DemoHOCItem.jsx';

const styles= {
    superbig: {
        zoom: 2.5,
    }
};

class SortableZoom extends React.Component {

    render() {
        const {onRowMoved} = this.props;
        return (
            <div style={styles.superbig}>
                <Sortable onSort={onRowMoved}>
                    <DemoHOCItem className="item-1" key={1}>one</DemoHOCItem>
                    <DemoHOCItem className="item-2" key={2}>two</DemoHOCItem>
                    <DemoHOCItem className="item-3" key={3}>three</DemoHOCItem>
                </Sortable>
                </div>
        );
    };
};

export default SortableZoom;

No problem, I'll look into it.

Hi, i am also having the same issue. Please let me know if you have any solution for this.


Disable execution optimizations for invalid work

Fixes #15305

[x] disable caching for them (load or store),
[x] disable incremental execution,
[x] ignore the state of their inputs and outputs and run them every time,
[ ] prevent other work from running in parallel with invalid work,
[ ] invalidate the whole VFS before invalid work is executed.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

OK, I think this is taking shape nicely. Caching, up-to-date checks and incremental execution are all disabled now, and the VFS is invalidated. I've added some tests to confirm these. I'm having some trouble with CachedCustomTaskExecutionIntegrationTest.invalid tasks are not cached that tries to check for a multi-line string in the output and only fails on CI. 🤷
What's not done at all yet is disabling parallel execution. This has a few issues.
We need to move validation to somewhere close to DefaultExecutionPlan.canRunWithCurrentlyExecutedNodes() to make the decision there.
This means that we'll be validating earlier, which in turn means validating things that we don't currently validate. This might have a small performance impact, but there's a perhaps more important aspect, too.
The last time I tried to validate earlier it became apparent that Gradle builds today have a lot of invalid tasks that are skipped because their sources are empty or some similar reason. These would now show up as invalid, and would be prevented from running in parallel with others. We'll need to figure out what to do with them if they are still around.
One potential way to work around this might be to only validate the type in DefaultExecutionPlan, and let properties be validated during the actual execution, as they are now.
Another issue is that DefaultExecutionPlan uses the SystemRegistry to get to the few services it actually needs to resolve properties etc. This in turn means that the associated tests use ProjectBuilder which makes services very hard to customize. And we need to customize them because we must force the TypeAnnotationMetadataStore to ignore Spock mock methods (ISpockMock), otherwise we get validation errors for all the mock task types in the tests. 😞 I think the best course of action here will be to rewrite DefaultExecutionPlan to explicitly inject the services it requires, but this will be some work.

@bot-gradle test QFL please.

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test this please.

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

I've fixed the test, let's do the remaining disabling in a separate PR.

@bot-gradle test QF please.

OK, I've already triggered QuickFeedback build for you.

Yes, will do as soon as I figured out what to do with the now failing K9 and Android Large performance tests...

These are the tasks broken for the K9 test:

checkDebugManifest
createDebugCompatibleScreenManifests
extractDebugAnnotations
generateDebugRFile
mergeDebugResources
packageDebug
packageDebugResources
processDebugManifest
processDebugResources
signingConfigWriterDebug
transformClassesAndResourcesWithSyncLibJarsForDebug
transformClassesWithDexBuilderForDebug
transformNativeLibsWithIntermediateJniLibsForDebug
transformNativeLibsWithSyncJniLibsForDebug

And these are the ones failing for K9:

checkDebugManifest
compileDebugAidl
compileDebugJavaWithJavac
compileDebugRenderscript
extractDebugAnnotations
generateDebugRFile
packageDebug
processDebugManifest
processDebugResources
splitsDiscoveryTaskDebug
transformClassesAndResourcesWithPrepareIntermediateJarsForDebug
transformClassesAndResourcesWithSyncLibJarsForDebug
transformClassesWithDexBuilderForDebug
transformDexArchiveWithDexMergerForDebug
transformDexArchiveWithExternalLibsDexMergerForDebug
transformNativeLibsWithIntermediateJniLibsForDebug
transformNativeLibsWithMergeJniLibsForDebug
transformNativeLibsWithSyncJniLibsForDebug
transformResourcesWithMergeJavaResForDebug

@bot-gradle test this please.

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this please.

OK, I've already triggered ReadyForMerge build for you.


d3.summarize (for box plots)?

Something like:
function summarize(iterable, value = identity) {
  const values = map(iterable, value).sort(ascending);
  const min = values[0];
  const max = values[values.length - 1];
  const q1 = quantileSorted(values, 0.25);
  const q2 = quantileSorted(values, 0.50);
  const q3 = quantileSorted(values, 0.75);
  const iqr = q3 - q1; // interquartile range
  const r0 = Math.max(min, q1 - iqr * 1.5);
  const r1 = Math.min(max, q3 + iqr * 1.5);
  return {
    quartiles: [q1, q2, q3],
    range: [r0, r1],
    outliers: values.filter(v => v < r0 || v > r1)
  };
}

Although probably outliers should be a subset of the input elements rather than the mapped values?

Whoah great idea!

Possible to split into summarize and summarizeSorted, to skip the sort step in case values are already sorted.

I’ll probably use quantile instead of quantileSorted to avoid the sort step.

Years ago I implemented this box plot summary in much the same way, and it failed QA in that company because the output did not match the output from R, which the company viewed as the "industry standard".
Just wanted to flag that it may be worth doing a comparison of the output between this and the same summary function in R. The discrepancies came up with a small number of values as input, and degenerate cases as far as I recall.

If r0 and r1 are for whiskers, and if we are trying to implement box plots according to John Tukey's "schematic plot," they should be calculated differently. The correct way to calculate whiskers, according to p44-47 of Exploratory Data Analysis, are:

the smallest data within Q1 - 1.5 IQR and the largest data within Q3 + 1.5 IQR

This means that the whiskers should always indicate actual data points. For example, given dataset [0, 3, 4.4, 4.5, 4.6, 5, 7], the following shows incorrectly rendered whiskers:

The following shows the correct way:

Vegalite also has the same problem but they've fixed it since v3.0.0-rc13.
Here's a detailed explanation with a demo: https://observablehq.com/@akngs/vega-lite-renders-box-plots-differently

Agree with @akngs — on this issue see also https://github.com/observablehq/plot/issues/13#issuecomment-747955182

does the following look correct & efficient? It is robust against null, undefined and NaN, and seems to do the right thing (including for an empty data array, where it returns undefined quartiles and whiskers)
function summarize(iterable, value = identity) {
  const values = map(iterable, value)
    .filter((d) => d != null && d >= d)
    .sort(ascending);
  const min = values[0];
  const max = values[values.length - 1];
  const q1 = quantileSorted(values, 0.25);
  const q2 = quantileSorted(values, 0.5);
  const q3 = quantileSorted(values, 0.75);
  const iqr = q3 - q1; // interquartile range
  const w0 = Math.max(min, q1 - iqr * 1.5);
  const w1 = Math.min(max, q3 + iqr * 1.5);
  let i = -1;
  while (values[++i] < w0);
  const r0 = values[i];
  while (values[++i] <= w1);
  const r1 = values[i - 1];
  return {
    quartiles: [q1, q2, q3],
    range: [r0, r1],
    outliers: values.filter((v) => v < r0 || v > r1)
  };
}

https://observablehq.com/@fil/whiskers-180

I have corrected the implementation here: https://observablehq.com/@mbostock/plot-box

Looks good to me :)

We’ve implemented a nice box mark in Plot, so I’m not planning on implementing a separate summary method in d3-array. https://github.com/observablehq/plot/blob/main/README.md#box


Remove generic pointer array impls of ToGlibPtr and FromGlibContainer

This introduces new traits:

ToGlibContainerFromSlice: Conversion from a &[Self] into some GLib
container (array, GList, etc).

FromGlibContainerAsVec: Conversion from a GLib container (array,
GList, etc) to a Vec. This always requires the length to be
given and can be used for non-pointer containers (e.g. uint8_t[]).

FromGlibPtrContainerAsVec: Some as FromGlibContainerAsVec but does not
require the length, and instead requires pointers as elements and the
container to be NULL-terminated

They are all implemented for T and not [T]/Vec, which is required for this to
be possible to implement in crates other than the glib crate.
impls for Strings and fundamental types exist in GLib, glib_wrapper!()
is automatically implementing them too.
Based on these there are generic implementations for ToGlibPtr for [T]
and FromGlibContainer for Vec.
Also split FromGlibPtrContainer into FromGlibContainer and FromGlibPtrContainer,
the first requiring a length to be given (and thus is usable for
non-NULL terminated or non-pointer containers), the second requires
pointers and NULL-termination.
With all this in place it is now possible to implement conversions
from/to containers of fundamental types, enums, flags, etc.

I already said it earlier but for the records: didn't see anything shocking. Thanks for the huge update!

It might make sense to generate the impls in the macros by yet another macro, they're basically copy&paste right now. But that would mean that GLib exports yet another macro, so I'm not sure about that. Your decision

It depends on the final outcome: if we still just have to call one macro (which will call whatever macros), it's fine. I'd just prefer that we don't have to directly call multiple macros. (If that makes sense?)

Hm, the new traits should probably have different function names. Otherwise they conflict with the other ones and have to be explicitly specified. Doing so later, but for an initial review this should be ok.

Looks good for fast check, will check more tomorrow.
Thanks, @sdroege

It depends on the final outcome: if we still just have to call one macro (which will call whatever macros), it's fine. I'd just prefer that we don't have to directly call multiple macros. (If that makes sense?)

Yes it would still just be glib_wrapper!() that is called... but internally it would call some new macro

Actually can't use macros for this because of different mutability, and that's not easy to abstract over

Cairo now need adding feature like "use_glib" instead "glib" to include both "glib" and "glib_sys" crates

All complete and compiling from my side now

I'd prefer for this (and the related PRs) to be merged before my other PRs btw. I'll rebase the others as needed then (they just add features, don't break things).

Thanks, @sdroege all PRs look good, only last update to last gir when needed.

Updated gir

@GuillaumeGomez, 👍 for merge this and all linked PRs

Taking a look in a few hours.

Thanks a lot!

Thanks :) now only gio and gdk-pixbuf are missing


details component - aria-expanded not announced by Voiceover on Safari

The aria-expanded: true value for the details component is not being announced by Voiceover in Safari (Version 14.1.2). This is correctly announced in Chrome.
Working example of the aria-expanded value on a button can be found here, https://pauljadam.com/demos/button.html.
The only difference that might be causing the different behaviour is the nesting.

Might be related to the fact that the aria attributes are set incorrectly:

The id and aria-labelledby are now set correctly.
I'm closing this as it seem to be more of a bug with Safari rather than the structure of the component.
The aria-expanded is read correctly when tabbing to the element, it's just not read when toggling open/closed.


The type struct Reply is not Send?

I encountered an issue with the struct Reply when trying to use it in a concurrent context. I want to know why it is not Send and if there is a way to make it work. Thank you for the help.
Here is the code I am trying to run, the src/main.rs file:
use async_zmq;
use futures_util::stream::StreamExt;
use tokio;

async fn foo() {
    let mut socket = async_zmq::reply("tcp://localhost:1234")
        .unwrap()
        .bind()
        .unwrap();

    while let Some(Ok(msg)) = socket.next().await {
        let f = socket.send(msg);
        f.await.unwrap();  // <-- Commenting this line out makes the code compile.
    }

}

#[tokio::main]
async fn main() {
    // The spawn(x) requires x to be Send, and the compiler complains about the foo() function not
    // being Send. The compiler gives a hint that "within `Reply<std::vec::IntoIter<Message>,
    // Message>`, the trait `Sync` is not implemented for `*mut c_void`". I don't understand where
    // does the `*mut c_void` come from.
    let handle = tokio::spawn(foo());

    // tokio::spawn(bar());
    // tokio::spawn(other_tasks());

    handle.await.unwrap();
}

And the Cargo.toml file:
[package]
name = "test"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]

# common utils
futures = "0.3"
futures-util = "0.3"
tokio = { version = "1.0", features = ["full"] }
async_zmq = "0.3.3"

I'll close due to @jobfeikens comment, but @wongsingfo if you have a follow up on this feel free to reopen


Support For FASTCGI?

Many people failed to run NextCloud FPM version behind Nginx Proxy Manager because of lack of support.
For example I am running fastcgi on port 9000 for managing php files and my nextcloud static contents like css and html are on /nextcloud path in storage.
There is also nginx.conf file available for serving static content through nginx reverse proxy server and passing php to fastcgi port 9000. But I can not fit nginx.conf file into  NPM.

To run nextcloud fpm you can look at the bottom of https://github.com/NginxProxyManager/nginx-proxy-manager/issues/928

To run nextcloud fpm you can look at the bottom of #928

I moved to Caddy. It is very simple


Incorrect handling of negative zero in floating points

It seems that negation of zero and nan is not correctly represented in the compiler according to IEEE 754 standard.
This, for example, leads to the following inconsistencies:
let wrongNegativeZero = -0.0;
let correctNegativeZero = Prim.floatCopySign(0.0, -1.0);

Prim.debugPrint(debug_show(wrongNegativeZero) # " vs. " # debug_show(correctNegativeZero));
Prim.debugPrint(debug_show(1.0 / wrongNegativeZero) # " vs. " # debug_show(1.0 / correctNegativeZero));
Prim.debugPrint(debug_show(Prim.floatCopySign(1.0, wrongNegativeZero)) # " vs. " # debug_show(Prim.floatCopySign(1.0, correctNegativeZero)));
Prim.debugPrint(debug_show(Prim.arctan2(0.0, wrongNegativeZero)) # " vs. " # debug_show(Prim.arctan2(0.0, correctNegativeZero)));

Output:
0.000000 vs. -0.000000
inf vs. -inf
1.000000 vs. -1.000000
0.000000 vs. 3.141593

(Please note that -0.0 == 0.0 according to the specification. However, as the examples above show, -0.0 needs to be represented with a negative sign because of other operations that may rely on the sign.)
Moreover, negation of nan is not correctly handled (on drun):
let NaN = 0.0/0.0;

let wrongNegativeNaN = -NaN;
let correctNegativeNaN = Prim.floatCopySign(NaN, -1);

Prim.debugPrint(debug_show(wrongNegativeNaN) # " vs. " # debug_show(correctNegativeNaN));
Prim.debugPrint(debug_show(Prim.floatCopySign(1.0, wrongNegativeNaN)) # " vs. " # debug_show(Prim.floatCopySign(1.0, correctNegativeNaN)));

Output:
nan vs. -nan
1.000000 vs. -1.000000

Updated the description, since it is more general, negation of zero and nan.

The other issue https://github.com/dfinity/motoko/issues/3647 is related but different. While the other issue only affects wasmtime, this issue is general, also relevant for IC compilation.


Revert "output: add block_idle_frame"

This reverts commit cbb2781fed7944dae680a66a35443f5b1a678ec7.
In 1, we found issues with block_idle_frame and replaced it with
frame_pending. block_idle_frame is now unused.

Thanks!


updating readme for linux libwebp installation

Ran into an minor roadblock with the libwebp installation on ubuntu 20.04. This could maybe clear it up for future contributors.

Hey @kaushalpartani! So sorry for the delay. I know it's been a bit, do you recall more details on what issues you were running into? Preferably, folks will not have to compile libwebp from source and if you ran into an issue that required it, we'd certainly want to address it directly.

Unfortunately no, I just remember it was a little frustrating to figure out when the issue arose. I can try to recreate it and update here if I'm able to.

No worries at all, sorry again for the initial delay. I'm going to close this for now. We really want pixlet to be easy to use and if there is a need to compile from source, we'd want to address that issue directly. If you run into this problem again, please feel free to reopen this PR or create an issue with additional context and we will be sure to address the root cause.


Error message enhancement while adding a wallet address

Faced this error searching for a previous added wallet:

Can we improve the error message to mention if the contact address is already added stellar or tfchain so users can find contacts easily?

Still investigating.

Work completed:
Added chain type to err msg when the user tries to add an existing contact.

Verified on Android 14,
Threefold-Connect: 4.0.0-184
APK:12-12-2024
The Enhancement has been done, and an error message mentions if the contact address is already added in Stellar or TFChain.

Related Link:

https://app.testlodge.com/a/26076/projects/40893/suites/206114?expand_section=407473#case_4404602


SSL error in API - https://api.com/v1/discover

Environment: Xcode 11.3.1, iOS Simulator
@justinswart : Getting this below error. Looks like SSL error on the API - https://api.com/v1/discover
[Push Registration] Push token registration started 🚀 ⚪ [KsApi] Starting request https://api.com/v1/discover?client_id=[REDACTED]&currency=IDR&sort=magic 2020-02-13 16:54:21.348784+0530 KickDebug[71759:8432431] [Client] Synchronous remote object proxy returned error: Error Domain=NSCocoaErrorDomain Code=4099 "The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated." UserInfo={NSDebugDescription=The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated.} 2020-02-13 16:54:21.348800+0530 KickDebug[71759:8432677] [Client] Remote object proxy returned error: Error Domain=NSCocoaErrorDomain Code=4099 "The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated." UserInfo={NSDebugDescription=The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated.}

Thanks, this is not actually an SSL error but rather just some innocuous warnings resulting from using the CoreTelephony framework on the simulator. I opened a PR to silence these - https://github.com/kickstarter/ios-oss/pull/1069

@justinswart : Please check this below error:

@justinswart : Please check the below error.
2020-02-17 16:21:28.268936+0530 KickDebug[26700:9449654] [BoringSSL] boringssl_session_handshake_error_print(111) [C4.1:2][0x7fe772721310]<PHONE_NUMBER>29032:error:10000410:SSL routines:OPENSSL_internal:SSLV3_ALERT_HANDSHAKE_FAILURE:/BuildRoot/Library/Caches/com.apple.xbs/Sources/boringssl_Sim/boringssl-283.60.3/ssl/tls_record.cc:587:SSL alert number 40 2020-02-17 16:21:28.269097+0530 KickDebug[26700:9449654] [BoringSSL] boringssl_session_handshake_error_print(111) [C4.1:2][0x7fe772721310]<PHONE_NUMBER>29032:error:1000009a:SSL routines:OPENSSL_internal:HANDSHAKE_FAILURE_ON_CLIENT_HELLO:/BuildRoot/Library/Caches/com.apple.xbs/Sources/boringssl_Sim/boringssl-283.60.3/ssl/handshake.cc:596: 2020-02-17 16:21:28.269236+0530 KickDebug[26700:9449654] [BoringSSL] nw_protocol_boringssl_handshake_negotiate_proceed(726) [C4.1:2][0x7fe772721310] handshake failed at state 12288 2020-02-17 16:21:28.277258+0530 KickDebug[26700:9449654] Connection 4: received failure notification 2020-02-17 16:21:28.277425+0530 KickDebug[26700:9449654] Connection 4: failed to connect 3:-9858, reason -1 2020-02-17 16:21:28.277636+0530 KickDebug[26700:9449654] Connection 4: encountered error(3:-9858) 2020-02-17 16:21:28.281666+0530 KickDebug[26700:9449654] Task <7449329F-C4D4-4E9F-B910-EA8AE1E48C19>.<1> HTTP load failed, 0/0 bytes (error code: -1200 [3:-9858]) 2020-02-17 16:21:28.283177+0530 KickDebug[26700:9449628] Task <7449329F-C4D4-4E9F-B910-EA8AE1E48C19>.<1> finished with error [-1200] Error Domain=NSURLErrorDomain Code=-1200 "An SSL error has occurred and a secure connection to the server cannot be made." UserInfo={_kCFStreamErrorCodeKey=-9858, NSLocalizedRecoverySuggestion=Would you like to connect to the server anyway?, NSUnderlyingError=0x600001733b10 {Error Domain=kCFErrorDomainCFNetwork Code=-1200 "(null)" UserInfo={_kCFStreamPropertySSLClientCertificateState=0, _kCFNetworkCFStreamSSLErrorOriginalValue=-9858, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9858}}, NSLocalizedDescription=An SSL error has occurred and a secure connection to the server cannot be made., NSErrorFailingURLKey=https://api.com/v1/app/ios/config?client_id=deadbeef&currency=USD&no_cache=1581936687.718539, NSErrorFailingURLStringKey=https://api.com/v1/app/ios/config?client_id=deadbeef&currency=USD&no_cache=1581936687.718539, _kCFStreamErrorDomainKey=3} 2020-02-17 16:21:28.764888+0530 KickDebug[26700:9449627] [BoringSSL] boringssl_context_handle_fatal_alert(1872) [C5.1:2][0x7fe772536f60] read alert, level: fatal, description: handshake failure 2020-02-17 16:21:28.767136+0530 KickDebug[26700:9449627] [BoringSSL] boringssl_session_handshake_error_print(111) [C5.1:2][0x7fe772536f60]<PHONE_NUMBER>92840:error:10000410:SSL routines:OPENSSL_internal:SSLV3_ALERT_HANDSHAKE_FAILURE:/BuildRoot/Library/Caches/com.apple.xbs/Sources/boringssl_Sim/boringssl-283.60.3/ssl/tls_record.cc:587:SSL alert number 40 2020-02-17 16:21:28.767242+0530 KickDebug[26700:9449050] [TraitCollection] Class CKBrowserSwitcherViewController overrides the -traitCollection getter, which is not supported. If you're trying to override traits, you must use the appropriate API. 2020-02-17 16:21:28.767374+0530 KickDebug[26700:9449627] [BoringSSL] boringssl_session_handshake_error_print(111) [C5.1:2][0x7fe772536f60]<PHONE_NUMBER>92840:error:1000009a:SSL routines:OPENSSL_internal:HANDSHAKE_FAILURE_ON_CLIENT_HELLO:/BuildRoot/Library/Caches/com.apple.xbs/Sources/boringssl_Sim/boringssl-283.60.3/ssl/handshake.cc:596: 2020-02-17 16:21:28.767769+0530 KickDebug[26700:9449627] [BoringSSL] nw_protocol_boringssl_handshake_negotiate_proceed(726) [C5.1:2][0x7fe772536f60] handshake failed at state 12288 2020-02-17 16:21:28.771822+0530 KickDebug[26700:9449627] Connection 5: received failure notification 2020-02-17 16:21:28.772073+0530 KickDebug[26700:9449627] Connection 5: failed to connect 3:-9858, reason -1 2020-02-17 16:21:28.772797+0530 KickDebug[26700:9449627] Connection 5: encountered error(3:-9858) 2020-02-17 16:21:28.814434+0530 KickDebug[26700:9449627] Task <398AAFA0-E404-441D-A50A-4FFD14AA731D>.<2> HTTP load failed, 0/0 bytes (error code: -1200 [3:-9858]) 2020-02-17 16:21:28.820368+0530 KickDebug[26700:9449621] Task <398AAFA0-E404-441D-A50A-4FFD14AA731D>.<2> finished with error [-1200] Error Domain=NSURLErrorDomain Code=-1200 "An SSL error has occurred and a secure connection to the server cannot be made." UserInfo={_kCFStreamErrorCodeKey=-9858, NSLocalizedRecoverySuggestion=Would you like to connect to the server anyway?, NSUnderlyingError=0x60000168aaf0 {Error Domain=kCFErrorDomainCFNetwork Code=-1200 "(null)" UserInfo={_kCFStreamPropertySSLClientCertificateState=0, _kCFNetworkCFStreamSSLErrorOriginalValue=-9858, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9858}}, NSLocalizedDescription=An SSL error has occurred and a secure connection to the server cannot be made., NSErrorFailingURLKey=https://api.com/v1/discover?client_id=deadbeef&currency=USD&sort=magic, NSErrorFailingURLStringKey=https://api.com/v1/discover?client_id=deadbeef&currency=USD&sort=magic, _kCFStreamErrorDomainKey=3}


Computed property names in generated intersection types cannot be named

TypeScript fails to generate declaration files if a computed property name is used in an intersection type. I'm having trouble even figuring out what's going wrong myself. Hopefully the relevant code is at least marginally useful.
Search Terms
has or is using name from external module newtype newtypes unique symbol computed property name declaration d.ts intersection
Version & Regression Information
Still an issue on nightly as of 2021.03.14
Code
Unfortunately, since this issue is very peculiar, it requires multiple files so I can't link to a playground.
declaration must be set to true in one way or another for this issue to occur.
Here's a repo that also shows the issue. Just clone and npx tsc.
// http_host.ts
declare const unique_symbol: unique symbol;

type http_host_t = {[unique_symbol]: "http_host"};

type http_host = `http${"" | "s"}://${string}` & http_host_t;

type http<host extends string = string> = `http://${host}` & http_host;
const http = <host extends string>(host: host) =>
   `http://${host}` as http<host>;

type https<host extends string = string> = `https://${host}` & http_host;
const https = <host extends string>(host: host) =>
   `https://${host}` as https<host>;

export {http_host, http, https};

import {https} from "./http_host";

export const tsl = https("www.typescriptlang.org");

Actual behavior

Exported variable 'tsl' has or is using name 'unique_symbol' from external module "./src/http_host" but cannot be named.ts(4023)

Expected behavior
This file is generated:
// main.d.ts
declare const tsl = import("./http_host").https<"www.typescriptlang.org">;

I forgot to note that changing
type http<host extends string = string> = `http://${host}` & http_host;

to
type http<host extends string = string> = `http://${host}` & http_host_t;

is a stopgap solution and fixes the problem well enough for now. The issue only shows itself when there are two layers of intersection to the object type with the computed property name, it seems.
Also, if the computed property name's type is changed from unique symbol to something like 1, the issue goes away. This is an incredibly niche issue so sorry somewhat for piling onto the growing list of things to fix.

This is the intended behavior. The declaration emitter won't emit import(... types on its own since this tends to be nonportable in the long-run. You can write the import type as a type annotation in the second file if that's what you want to appear.

Ah. Well, it wasn't so much that I wanted that exact main.d.ts file to be generated. Rather that I was unable to get any main.d.ts file to generate because of the whole "cannot be named" issue. The expected behavior was just an example of what could happen, I suppose. Even doing this:
export const tsl = https("www.typescriptlang.org") as import("./http_host").https<"www.typescriptlang.org">;

seems to give me the exact same error as before:

Exported variable 'tsl' has or is using name 'unique_symbol' from external module "./src/http_host" but cannot be named.ts(4023)

I don't have a particular preference on what .d.ts files TypeScript generates for me as long as it generates at least something. In this case, trying to generate any declaration for this code fails.

A type assertion is different from a type annotation (sorry, technobabble here 😅) This should work:
export const tsl: import("./http_host").https<"www.typescriptlang.org"> = https("www.typescriptlang.org");

If it doesn't, that's a bug

Ah wonderful! Thank you for the help. It seems mildly unfortunate that "www.typescriptlang.org" would have to be duplicated within the type itself. Since this is not a bug, I suppose I will close the issue.


local PV failover enhancement

[x] support metad
[x] log volume configured
[x] failure host partial updating

https://github.com/vesoft-inc/nebula-operator/pull/488


Cannot control speaker volume on Yoga Pro 7 14AHP9 (AMD, Realtek ALC287)

Hi,
I just bought a Yoga Pro 7 14AHP9 which has a Realtek ALC287 controller. Everything works just fine sound-wise (maybe thanks to your work?) except for one small detail: the speaker volume control has no effect, the effective volume remains at 100% regardless of the set value EDIT: the volume goes from 0 to 100% in the first few pixels of the slider.
Headphone volume control works fine.
I tried setting the volume via pipewire (-pulse) and directly in alsamixer. The PCM volume slider does control the volume, but not the Speaker slider.
By any chance do you have any insight on this small issue?
alsa-info.txt

Actually I'm pretty sure this is a driver configuration issue so I've submitted a bug to https://bugzilla.kernel.org/show_bug.cgi?id=218928


Creating dynamic web content with createjs

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
This fixes #2140
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

Hello @john-amiscaray, sorry for the delayed review. I was going through your PR and it seems to have conflicts with three published articles. Could you please resolve the conflict(if possible) before we proceed. Otherwise, you can create a fresh PR. Please update me with your progress.

Hello @john-amiscaray, sorry for the delayed review. I was going through your PR and it seems to have conflicts with three published articles. Could you please resolve the conflict(if possible) before we proceed. Otherwise, you can create a fresh PR. Please update me with your progress.

No worries, that's okay. I'm not sure how I seemed to have accidentally modified some files in this branch I'll try to fix them shortly.

Thank you v much for your patience as we worked through our Repo re-structuring process.
The purpose behind this restructure - was to better allow us to handle more volume and allow students to publish more articles and get more involved with the community (with open-source contribution and suggestions).
With most of the changes coming to completion - we will be sure to get your article published asap.
Thank you again - and we are looking forward to more amazing articles.

I think the forked repo may need a git pull - to get the new structure then you can re-add your files

I think the forked repo may need a git pull - to get the new structure then you can re-add your files

Alright thanks for reminding me, I will do so

Hello @john-amiscaray, sorry for the delayed review. I was going through your PR and it seems to have conflicts with three published articles. Could you please resolve the conflict(if possible) before we proceed. Otherwise, you can create a fresh PR. Please update me with your progress.

I believe the conflicts should be fixed now. Sorry for that

@kayere Thanks for the review, I really appreciate it and will take your feedback for future articles. Although correct me if I'm wrong but I believe you've made a minor grammatical mistake in your commit in this sentence:

Each of these libraries is independent of the other but you can be used together.

where it says "but you can be used together". The sentence was referring to the fact that the libraries that CreateJS is comprised of can be used together or independently. Anyways, I'll just push a quick commit to fix that. Thanks.

plagiarism check done

Notice the minor edits I have made here - the article was really well put together - easy to follow along.
Notice the Heading - I deleted/replaced the unneeded capital letters in the headings.
Spacing - notice that paragraphs that seemed too long - I spaced them out. Any paragraph more than 3 sentences needs to spread apart.
Any sentence with an semi-colon: I space out.
Make note of how I rearranged the intro paragraph. Anything about the ----more tag will be previewed in the main page box view. (in this view we can not have ' or " as they will not rendered properly.)
Any words that are Italic with the "_" underscore - change to "*" asterisk to be italic.
I do this for most articles that come in @ahmadmardeni1 👀
cc @john-amiscaray
@kayere

great work gents @john-amiscaray
cc @kayere


⚠ ClamAV has degraded performance

In 70e9cb3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 552 ms

Resolved: ClamAV performance has improved in 08bbcf5.


avoid cache avalanche

At the beginning of client start, there is no table region info in cache.
If there are many go routine to access a table at same time, they will miss cache and send request package to get table region info.
In this case, too many duplicated requests should be avoid.

This seems a little bit similar to https://github.com/tsuna/gohbase/pull/164, not in the implementation but in what it tries to do.

Discussed this with @dethi today and after looking at data on our clusters with @aaronbee we decided to add an option to the client to perform a cache warm up during initialization by preloading all entries from meta for tables of interest.


Fullscreen apps aren't in fullscreen

This is mainly referring to games that play in full screen.
When I start a game or other fullscreen application, it is instead forced into borderless mode. Interestingly, this doesn't happen with applications like Mozilla Firefox while using youtube. This may be due to the difference in how fullscreen is handled there.

You can use filter to ignore them
// filters, workspacer will ignore windows with this names (I recommend ignoring games and fullscreen applications)
context.WindowRouter.AddFilter((window) => !window.Title.Contains("Getsu")); //Getsu Fuma Den
context.WindowRouter.AddFilter((window) => !window.Title.Contains("Lacuna")); //Lacuna context.WindowRouter.AddFilter((window) => !window.Title.Contains("Monster Train")); //Monster Train


MoRA复现

PR types
new features

PR changes

Description

开发中，目前在使用common_sense_170数据集做训练，但loss上下振荡，且出现loss为0，且显存占用也比较多。
训练模型：paddle的facebook/llama-7b
训练参数：batch_size=16, leaning_rate=3e-4, epochs=1, lora_dropout=0.1, r=8,
参考论文https://arxiv.org/pdf/[2405.12130](https://arxiv.org/pdf/2405.12130)
参考开源代码https://github.com/kongds/MoRA

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[KYUUBI #1578] Introduce flink-sql-client dependency to reduce some duplicated code

…uplicated code

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #1584 (90c2f89) into master (6e10eec) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1584      +/-   ##
============================================
- Coverage     58.99%   58.94%   -0.06%
+ Complexity      248      196      -52
============================================
  Files           260      255       -5
  Lines         12947    12663     -284
  Branches       1619     1601      -18
============================================
- Hits           7638     7464     -174
+ Misses         4667     4561     -106
+ Partials        642      638       -4

Impacted Files
Coverage Δ

...kyuubi/engine/flink/operation/FlinkOperation.scala
39.28% <ø> (ø)

...kyuubi/engine/flink/session/FlinkSessionImpl.scala
100.00% <ø> (ø)

.../engine/flink/session/FlinkSQLSessionManager.scala
66.66% <100.00%> (ø)

...e/kyuubi/engine/spark/operation/ExecuteScala.scala
82.75% <0.00%> (-5.25%)
:arrow_down:

...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala
90.16% <0.00%> (-2.82%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
82.50% <0.00%> (-2.50%)
:arrow_down:

...uubi/engine/spark/operation/ExecuteStatement.scala
86.07% <0.00%> (-1.43%)
:arrow_down:

...org/apache/spark/kyuubi/SQLOperationListener.scala
94.00% <0.00%> (ø)

...g/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala
88.46% <0.00%> (ø)

...ain/scala/org/apache/kyuubi/KyuubiSparkUtils.scala

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e10eec...90c2f89. Read the comment docs.

cc @pan3793

Thanks, merging to master


fix(show-hide-when): remove whitespaces from conditions before check …

When showWhen is used with whitespace like this...

... it doesn't work properly, the component just is not shown. This makes it difficult to debug and may cause misunderstandings because no error is reported (the developer may think that the problem may be elsewhere). And the whitespace may have been accidentally written by intuition.
So, to ensure this doesn't happen I just remove all whitespaces from conditions string before check phase. 😬

Thanks! Looks good. 👍


RetryPolicy handleIf not working with DynamoDbException in predicate

When I'm doing failsafe with this handleIf statement in the RetryPolicy builder
RetryPolicy.builder()
                .withBackoff(5, maxDelay, ChronoUnit.SECONDS)
                .withMaxRetries(maxRetry)
                .handle(DynamoDbException.class)
                .handleIf(e -> {
                    if (e instanceof IllegalStateException) {
                        return e.getMessage().contains("Record not Found");
                    }
                    if (e instanceof DynamoDbException) {
                        return e.getMessage().contains("Rate exceeded");
                    }
                    return false;
                })
                .onSuccess(e -> log.info("DynamoDb query success"))
                .onFailedAttempt(e -> log.error("No record found with exception {}, attempted: {}", e.getLastException(), e.getAttemptCount()))
                .build();
    }

With other kind of Exception, e.g. IllegalStateException, RuntimeException with custom message, it can match with predicate and handle correctly. But for that DynamoDbException, regardless of the message, it always retry.
I don't know if we can do something to enhance so the predicate can catch the condition  e.getMessage().contains("Rate exceeded"); correctly
Thank you guys

What happens when you remove the handle(...) line:
    //.handle(DynamoDbException.class)

I'm guessing you're following the model on this page:

I think that sample code is demonstrating different possibilities rather than being a single model of how to do it.

I think that sample code is demonstrating different possibilities rather than being a single model of how to do it.

That's correct.

I wonder if there's a simple markdown way to make that clear.

thanks guys, it worked perfectly now.


Issue with IE11/targeting es5

When running ng serve on a project using @marcj/marshal, I receive the following error in IE11:

Which points to:

I am also targeting es5 in my tsconfig.

Yes, Marshal is not built for ES5. If you require ES5 support, you need to transpile it down using Babel.

Would transpiling it to ES5 hurt performance much? I am trying to switch off class-transformer to this library (mostly due to poor performance), but without IE11 support this isn't an option unfortunately.

Although I've never tested such dated browser, I guess it still works. It's not ES5 that hurts performance, but the IE11 engine itself is slow. You can try and report issues you find. If it's not much work we can tackle them.

Thanks for the reply @marcj . I gave it a shot trying to add babel to the project but unfortunately it appears I have no idea what I'm doing.
If you ever get the chance to add ES5 support, it would be really appreciated. I'd love to rip out class-transformer and use this instead.

Maybe this helps: https://stackoverflow.com/questions/34404496/webpack-not-converting-es6-to-es5
I unfortunately don't plan to multi build this library. It should be pretty forward to use webpack+babel to compile all your code including third-party library like Marshal to es5.

Thanks for trying to help @marcj , I really do appreciate it.
I don't think this quite applies to me because I'm using Angular 9. It helped me figure out what to google though, and unfortunately it seems it's not possible to have Angular transpile external dependencies, even when using the es5 configuration.
I managed to get babel-cli to convert the files into es5 and dropped that into my node_modules, but I'm still getting the error listed by the original poster. Maybe I'm doing it wrong.
I think I'm out of luck here.

+1 for IE11 support! Would love to use this in my project.

I've create new Angular 9 project and installed Babel with configuration to automatically compile third-party modules down to ES5. Please see here https://github.com/marcj/angular-marshal-example, the commit with all changes is https://github.com/marcj/angular-marshal-example/commit/d1d54ce02f5adbee8a856cedec9d49d63a8de29b.

That is way more configuration than I could have imagined. Thank you for showing that it is possible!

That's all you'll get and the burden you pay for supporting an very old technologie since I won't publish Marshal. Sorry that's not worth it for me.


Cannot deploy via Vercel [BUG]

Description
During building phase, I get the following error
Error: Builder returned invalid maxDuration value for Serverless Function "api/trpc-node/[trpc]". Serverless Functions must have a maxDuration between 1 and 10 for plan hobby. : https://vercel.com/docs/concepts/limits/overview#serverless-function-execution-timeout
Device and browser
Windows 10 with Edge browser
Screenshots and more
No response
Willingness to Contribute

[ ] 🙋♂ Yes, I would like to contribute a fix.

Thanks @babulee - fixed. This should be on Vercel tho.

@babulee not sure this is fixed - please let me know and verify. I changed it to an environment variable instead, but Vercel was rejecting it, and it's important I can serve the official big-agi on Vercel with 25 seconds timeout instead of 10.

It now says
The value for maxDuration must be between 1 second and 10 seconds, in order to increase this limit upgrade your plan:
https://vercel.com/pricing
I guess since I am using free tier of Vercel, this is the limitation.

Reopening as the current fix does not work for both the public big-AGI and implementations.
High priority.

Thanks for reporting @babulee - this was harder than expected, but we got it sorted out in the end.


Fix alignment for commits on dashboard

Fix allignment issue between commit SHA and commit message
Old:

New:

Hmm this seems to make the text jump for me here:

@zeripath hmm weird -- does the dashboard on gitea.com look ok to you? Right now for me everything (which is only mirror synching) looks broken like my first screenshot. This change makes them all look normal for me in every browser.
Do you see them as broken but this change doesn't fix it?

No the gitea.com dashboard looks broken too.
Fiddling a little the issue might be that the SHA link isn't display: inline-block

Sorry or rather that the text.truncate is display: inline-block

Does not work here either, it's broken with and without this PR, just in different direction. Changing it to -4px works for me but that's a rather poor hack that most likely depend on font too.

Weird, must be some combination of font/os that gives different results it looks totally fine in all 3 browsers on MacOs with this PR but I just tried in a windows vm and see the same thing as @zeripath .
The fact that its a negative margin makes me feel like its making up for something else that needs to be fixed, though unsetting display: inline-block makes it look mostly better, and causes margin top and bottom to just have no effect. WIll need to look into more

Remove all hacky margins on img and span and set <li> to display: flex; align-items: center:

The flexbox makes the whitespace collapse so you'll need something like li > * + * {margin-left: .35rem} to restore it:

Also, I think you can add small top/bottom margins to <li> so multiple messages are not stuffed together so tightly, e.g. .125rem on both sides.

@silverwind thanks, applied those changes and seems to work better in all places now

seems not unfortunately

Works for me @zeripath

Works for me too:

@zeripath you use Ubuntu right? I set up a vm and think this is an issue with Liberation Mono font which was the font it chose with default settings
It seems to just size much different than others. Removing it from the mono font stack fixes it, but obviously a problem if that is going to be the default font selected for many users. Not really sure what would be a good way of working with that:

If Liberation Mono is causing issues, maybe we want to move it after all other monospace fonts, right before monospace. Thought I'm not sure if any better suitable fonts are present by default on Linux systems.

In this test for Ubuntu it falls back to 'monospace' when removing Liberation Mono which seems to then use DejaVu Sans Mono from the system which looks better imo. Not sure what other distributions have installed other than Liberation Mono but I can't imagine there is only one monospace font installed.

Adding DejaVu Sans Mono before Liberation Mono sounds like a good idea, if it works better.

Google suggest there are several other mono space fonts included in various linux distros -- Id vote to remove liberation mono as a specifically named font all together if it somehow has the ability to look different enough to break styling in some situations compared to all other monospace font.
I'm not a desktop Linux user though so not sure what the real experience with others is. Maybe somebody who is could say.

@CirnoT those changes seem to make it look ok and similar enough with Libertion Mono so seem good to me as long as this works for everybody and doesn't look broken as it does now

That baseline change does shift all the hash and message 1px up for me, I think I prefer the center and fix the fonts.

Fix the fonts is not a proper solution; you can try manipulate list to look fine to you but in the end you can never be sure what user has installed and what browser will use. Aligning to baseline seems like the only option where you can be sure that different fonts will be aligned to each other visually.

I'd say the behaviour in https://github.com/go-gitea/gitea/pull/11595#issuecomment-634224764 is a font/browser bug that should not require is to make specific workarounds for as these may bite us in the long run (after the font/browser is fixed).

Yes on Libertion Mono the text is around 1px too high compared to avatar, but that's because the font's baseline is off. My proposed changes do not workaround the font issue, they align items to their baseline. This looks off on Libertion Mono for same reason the original solution did, but at least it's less visible now. Other fonts look fine to me and text is aligned perfectly to avatar.

In the end, baseline is the only thing that is guaranteed to visually align two different font types and I consider it the proper solution long-term.

The alignment looks ok in those screenshots. What I don't quite get is how align-self: flex-end; on the <img> fixes the image. Care to explain?

Good question, I have no idea why it actually visually centers image.

There does indeed seem to be some misalignment when zoomed out

The new proposed changes (flex-start and line-height) seem to eliminate it at the cost of putting the image slightly down when zoomed in; same as on GitHub

it's possibly font x-height differences between the monospace font and the sans-serif font used for the message.
The solution might simply be to stick the sha in side a rounded-box like we do elsewhere then the jarring font change would be less visible.

The new changes seem to work rather well for me
Default font on Windows 10:

Liberation Mono:

For reference, GitHub:

@CirnoT applied those changes, looks ok to me on various systems/fonts
@zeripath I think one of my least favorite parts of Gitea UI is the SHA1 inside of a rounded box : (  I'd rather see those all eventually get replaced rather than add another one here. These changes seem to make it work and look as it is intended to look now

I think this should be backported to 1.12 -- I'm not sure exactly where but the bug this fixes seems like it was introduced somewhere in 1.12 (probably one of the larger timeline UI changes). I don't see it on 1.11

Please send backport


avm.importKey create duplicates

Describe the bug
If you perform multiple time the same call to the AVM importKey, the address linked to the private key is added each time to the list of address owned by the user.

To Reproduce
Perform multiple times the call to avm.importKey wit the same privateKey .
Expected behavior
Imho it should be the same behaviour as for platform.importKey , which does not create duplicates as per my tests
By submitting this issue I agree to the Terms and Conditions of the Developer Accelerator Program.

Thanks for catching this @tbrunain , I'll fix this ASAP


Update README.md

Remove traces of AB3

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (71abed1) compared to base (bc0d109).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


zju_09 [ADD] summer_ocean_style

提供 1 个兼容 MajicmixRealistic_v6 的风格模型：夏日海滩氛围(Jacket in Snow Mountain)。
训练用人像：

生成的结果：

please sync the latest code.

resolved conflict

the version control says that the whole constants file conflicts with the main branch, need fixing


BetterDiscord Plugin

The BetterDiscord plugin for TimezoneDB
To Do:

[ ] Add a Powercord plugin under platforms/betterdiscord
[ ] Display locations

[ ] Message
[ ] User hover cards
[ ] Autocomplete

[ ] Cache timezone data

Lol dupe of #54


updating firmware of the controller

I know that this repo is not the best place to find an answer for this but I wanted try my chance.
My DPG1C32 controller which normally has full features is modified with DPG1C02 firmware by linak as you can see from the below image.

Is there any way to reset this controller to its original firmware?

with further inspection it seems like this device has a nrf51802 soc inside it and the swd pins are exposed for (down/up)loading a new firmware.

But without having the original firmware it would be very hard to make the necessary edits with assembly. I'll just purchase a new controller from amazon :)


Add XGist Xcode Extension

Add XGist Xcode Extension
Project URL
https://github.com/Bunn/Xgist
Description
Xgist is a Xcode extension to send code to GitHub's Gist. The extension will send your selection or entire file to Gist and automatically copy the Gist URL into your Clipboard.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 3 link issues

Link issues by awesome_bot

Line
Status
Link

568
503
http://akordadev.github.io/AutoLayoutMagic/

1041
301
https://tapglue.github.io/ redirects tohttp://www.tapglue.com/

2214
301
https://github.com/s4cha/AssetChecker redirects tohttps://github.com/freshOS/AssetChecker

  Generated by :no_entry_sign: Danger

Hey @Bunn, nice extension! I'm always using Github gists....
Please take a look at the issue above

@lfarah done, README updated with 2 different installation methods.
Thanks :)

Thank you for contributing to awesome-ios 😄


Updating models and classes to support polymorphic model mappings

Hi @namumakwembo, I have created this pull request with the necessary changes to support the custom polymorphic classes . Review please.  #24

Thanks for working on this issue , i'll review it

Of course, give me a moment to review

I have run the tests and corrected the problem. @namumakwembo


About grapple

I spent an entire afternoon testing the possibilities with the grapple.
You guys are amazing! I just wanted to thank you for the work, this new option is really fun.
I noticed that you made the grabbed enemy kind of teleport to the hero's last position. Very clever.
My only regret was when I tried the "cheese grater" combo.
But I think that asking to add a condition to the spike growth spell to cause damage when a creature teleports to it could be complicated.
Anyway thank you very much.

Looking into this but will require more time to think about a good solution. Won’t mod this week but asked others in the team to continue from where I’ve stopped.

Looking into this but will require more time to think about a good solution. Won’t mod this week but asked others in the team to continue from where I’ve stopped.

No problem, you and your team are fantastic anyway. Hope all is well out there. Stay in the light!

Implemented.


Create Bitmap Library

This library will deal with bitmaps - the serialiser should serialise roaring bitmaps from version 0.1.5 up to the current version. Converting the serialised form of the bitmap to the latest compatible version where needed.

Merged into develop.