fix(api): Fix typescript types

Summary
#414 added typescript support (yay!), but there were a couple of incorrect types when the --typescript argument was added to the CLI with other args, specifically --title-prop & --ref.
For the --title-prop arg with --typescript, the title & titleId props added to the SVGRProps interface should be string, not String. The main problem is that the id prop in the <title /> element only takes string. But in general string should always be used.
For the --ref arg with --typescript the call to React.forwardRef implicitly has a type of React.Ref<unknown> but it's being passed to the svgRef which has a type of React.Ref<SVGSVGElement>.
This PR fixes both of these issues.
Test plan
I added a new test case for --typescript --ref --title-prop in the CLI tests, which generated a new snapshot with the proper typing. I also updated existing snapshots that tested typescript + ref and typescript + title by themselves.
Closes #418.

Thanks!

Sweet! Thank you too @gregberge! When will you release the patch version?


Apache Ignite support

Hi!
Added Apache Ignite support. Please, review.

Thanks a lot, I will look at it over the weekend.

Thanks again, released as 4.24.0


Latency stats logging in allreduce

To detect struggler at allreduce in multinode environment (esp. larger scale) first of all it'd be nice if all latencies at each processes is logged and able to visualize, after a job finished.

Working branch: https://github.com/chainer/chainer/compare/master...kuenishi:wip/allreduce-latency-tracer or https://github.com/chainer/chainer/commit/098c428e40341c9fd98dba7904e2c9ae8178e442

out argument is a little bit unclear and duplicate with trace_latency . Rather prefer filename format to be given as trace_latency='result/latency.{}.log' or just None to unset...

We talked offline and agreed not to work on it more.


TAB-8330 Vulnerable 3rd party component json-smart used

Fixed by upgrading json-path 2.7.0 to 2.8.0 and json-smart 2.4.7 to 2.4.10.
Fixed by adding json-smart in management-cli-oss maven build and adding it to 3rd party bom.

The checks have failed because it depends on third party BOM changes also. If third party bom changes merged (https://github.com/Terracotta-OSS/terracotta-thirdparty-bom-4.x/pull/508), the checks should pass.


Implement code and unit tests for SMF NF controller in free5GC operator

Implement code and unit tests for SMF NF controller in free5gc operator
Readme with functional specifications.
Parent issue.

https://github.com/nephio-project/free5gc/pull/17
https://github.com/nephio-project/free5gc/pull/22


Update the document

[Add more context on how to create/manage rules programmatically. Also update the old screenshots.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27b4ec3e-3d82-258b-2038-2990c9f24479
Version Independent ID: 6c0a6b2e-3b3a-bbd4-8262-fe2c82bd9402
Content: Configure IP firewall rules - Azure Synapse Analytics
Content Source: articles/synapse-analytics/security/synapse-workspace-ip-firewall.md
Service: synapse-analytics
Sub-service: security
GitHub Login: @ashinMSFT
Microsoft Alias: seshin

@ViralRana Thank you for sharing your valuable feedback. We are actively validating it. We will share updates soon.

@julieMSFT Requesting to validate customer feedback and update document as appropriate. Thank you.

@WilliamDAssafMSFT William, could you help find the right owner for this issue? Thank you! #reassign:williamdassafmsft

#reassign:williamdassafmsft

GitHub user julieMSFT has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

Thanks @ViralRana for contacting Microsoft with feedback about our product documentation. Will review this with the PG. If you have any more specific feedback, let us know. If you have a specific suggestion, might be easier for you to create a Pull Request for this doc and get the ball rolling on a change yourself. By opening a pull request, you're collaborating with the author to add changes directly to the documentation. After the updated article is published, GitHub lists you as an article contributor. Either way, thanks for your feedback! Your suggestions help improve our documentation.
#please-close


Tf lite gpu unity

Changes to the unity Interpreter script to allow optional use of the GPU delegate on android for tensorflow, and corresponding updates to the readme to explain the additional build changes required.

@googlebot I signed it!

hmm, seems like the delegate doesn't just work as is as well as I thought. On further inspection it seems the delegate failed to initialise properly and then it fell back to the cpu, which is why I thought it worked the first time. I'll continue investigating, but we should probably close this pull request as the scope may be larger


bugfix - translation of attribute values in ProductAttributeFacetHandler

1. Why is this change necessary?
Translations do not work for values of product attributes in filter frontend display.
2. What does this change do, exactly?
Fetch correct translation
3. Describe each step to reproduce the issue or behaviour.

Setup an attribute filter with translations for a language shop
View filter in frontend - the values will not be translated

4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ × ] I have written tests and verified that they fail without my change
[ × ] I have squashed any insignificant commits
[ × ] This change has comments for package types, values, functions, and non-obvious lines of code
[×  ] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19870.
Please use this issue to track the state of your pull request.

Hey @mkreusch ,
can you please sign the CLA?
Thanks! :blue_heart:

Hey @mkreusch,
unfortunately this has been already fixed in the latest version https://github.com/shopware/shopware/blob/5.5/engine/Shopware/Bundle/SearchBundleDBAL/FacetHandler/ProductAttributeFacetHandler.php#L186
Thanks anyways for your contribution :blue_heart:


error when compiling (via quick start)

After installing dotnet 3.1 sdk, rebuilding the program, and re-running the quick start script, I get this error:
$ python restler-quick-start.py --api_spec_path ../openapi.yaml --restler_drop_dir bin/
Log share was not specified.  Logs will not be uploaded.
Starting task Compile...

ERROR: Compiler failed. See logs in /home/aharper/restler_working_dir/Compile directory for more information.

Task Compile failed.
Collecting logs...

ERROR: The RESTler grammar file path /home/aharper/restler_working_dir/Compile/grammar.py does not exist.

The log file:
Restler Information: 0 : Log share was not specified.  Logs will not be uploaded.
    DateTime=2020-11-17T15:53:06.3059771Z
Restler Information: 0 : Starting task Compile...
    DateTime=2020-11-17T15:53:06.3131157Z
Restler Information: 0 : Launching 'dotnet "/mnt/c/Users/aharper/workspace/api-v3/.restler/bin/restler/../compiler/Restler.CompilerExe.dll" "/home/aharper/restler_working_dir/Compile/config.json"'
    DateTime=2020-11-17T15:53:06.5334522Z
Restler Information: 0 : Process execution terminated in 00:00:00.7213000 with exit code 0x86: 'dotnet "/mnt/c/Users/aharper/workspace/api-v3/.restler/bin/restler/../compiler/Restler.CompilerExe.dll" "/home/aharper/restler_working_dir/Compile/config.json"'
    DateTime=2020-11-17T15:53:07.2638454Z
Restler Information: 0 : (7061) dotnet "/mnt/c/Users/aharper/workspace/api-v3/.restler/bin/restler/../compiler/Restler.CompilerExe.dll" "/home/aharper/restler_working_dir/Compile/config.json" exited with code: 134
    DateTime=2020-11-17T15:53:07.2706808Z
Restler Error: 0 : Compiler failed. See logs in /home/aharper/restler_working_dir/Compile directory for more information.
    DateTime=2020-11-17T15:53:07.2782879Z
Restler Information: 0 : Task Compile failed.
    DateTime=2020-11-17T15:53:07.2822032Z
Restler Information: 0 : Collecting logs...
    DateTime=2020-11-17T15:53:07.2879897Z

The path .restler/bin/restler/../compiler/Restler.CompilerExe.dll seems odd, but .restler/bin/compiler/Restler.CompilerExe.dll does exist, along with all the other compilation artifacts. So not sure what the problem is or what the next thing to check would be.
(side note: hard coding a working dir in my home folder isn't cool... it should either be configurable or relative to the process working dir).

@aharpervc Thanks for the detailed feedback!  Can you please share the StdErr.txt log in /home/aharper/restler_working_dir/Compile?

Re: working dir in the home folder - absolutely, this is a bug, we will fix ASAP.  (This should have been created relative to the cwd).
Re: configurability, we were trying to minimize the arguments required to the quick start script, which is why that configuration option wasn't added for our quick start scenario.

Haha okay I guess that error message wasn't clear on which log file to look at...
I reduced my openapi.yaml file to a minimum repro for the same error, then re-ran the script.
---
openapi: 3.0.3
info:
  title: example api
  version: 1.2.3
paths:
  "/test_endpoint_1":
    post:
      responses:
        '200':
          description: OK
          headers:
            X-API-Revision:
              required: true
              description: API Revision
              schema:
                type: string

There is a StdErr.txt which shows this:
Unhandled exception. System.AggregateException: One or more errors occurred. (Unexpected token while deserializing object: EndObject. Path 'paths['/test_endpoint_1'].post.responses.200.headers.X-API-Revision.schema', line 1, position 268.)
 ---> Newtonsoft.Json.JsonSerializationException: Unexpected token while deserializing object: EndObject. Path 'paths['/test_endpoint_1'].post.responses.200.headers.X-API-Revision.schema', line 1, position 268.
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.Serialization.JsonSerializerProxy.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader)
   at NSwag.OpenApiPathItem.OpenApiPathItemConverter.ReadJson(JsonReader reader, Type objectType, Object existingValue, JsonSerializer serializer)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.DeserializeConvertable(JsonConverter converter, JsonReader reader, Type objectType, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateDictionary(IDictionary dictionary, JsonReader reader, JsonDictionaryContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member,
JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Populate(JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerProxy.PopulateInternal(JsonReader reader, Object target)
   at Newtonsoft.Json.JsonSerializer.Populate(JsonReader reader, Object target)
   at NJsonSchema.ExtensionDataDeserializationConverter.ReadJson(JsonReader reader, Type objectType, Object existingValue, JsonSerializer serializer)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.DeserializeConvertable(JsonConverter converter, JsonReader reader, Type objectType, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at NJsonSchema.Infrastructure.JsonSchemaSerialization.FromJson[T](String json, IContractResolver contractResolver)
   at NJsonSchema.Infrastructure.JsonSchemaSerialization.FromJsonAsync[T](String json, SchemaType schemaType, String documentPath, Func`2 referenceResolverFactory, IContractResolver contractResolver)
   at NSwag.OpenApiDocument.FromJsonAsync(String data, String documentPath, SchemaType expectedSchemaType, Func`2 referenceResolverFactory)
   at NSwag.OpenApiYamlDocument.FromYamlAsync(String data, String documentPath, SchemaType expectedSchemaType, Func`2 referenceResolverFactory)
   at NSwag.OpenApiYamlDocument.FromFileAsync(String filePath)
   --- End of inner exception stack trace ---
   at Microsoft.FSharp.Control.AsyncResult`1.Commit() in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 338
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronouslyInCurrentThread[a](CancellationToken cancellationToken, FSharpAsync`1 computation) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 870
   at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in
F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 878
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1142
   at Restler.Workflow.swaggerDocs@88-1.Invoke(String fp) in /mnt/c/Users/aharper/workspace/api-v3/.restler/src/compiler/Restler.Compiler/Workflow.fs:line 88
   at Microsoft.FSharp.Primitives.Basics.List.map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 x) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\local.fs:line 248
   at Microsoft.FSharp.Collections.ListModule.Map[T,TResult](FSharpFunc`2 mapping, FSharpList`1 list) in F:\workspace\_work\1\s\src\fsharp\FSharp.Core\list.fs:line 75
   at Restler.Workflow.generateGrammarFromSwagger(String grammarOutputDirectoryPath, FSharpOption`1 swaggerDoc, Config config) in /mnt/c/Users/aharper/workspace/api-v3/.restler/src/compiler/Restler.Compiler/Workflow.fs:line 88
   at Restler.Workflow.generateRestlerGrammar(FSharpOption`1 swaggerDoc, Config config) in /mnt/c/Users/aharper/workspace/api-v3/.restler/src/compiler/Restler.Compiler/Workflow.fs:line 233
   at Program.main(String[] argv) in /mnt/c/Users/aharper/workspace/api-v3/.restler/src/compiler/Restler.CompilerExe/Program.fs:line 37

@aharpervc This is unfortunately a failure to parse the yaml by the underlying library (NSwag) we are using.   The root cause of this particular error is the required: true.  As a workaround, if you remove the required, compilation succeeds.
It looks like the library is expecting the below syntax for required schema properties:
      responses:
        '200':
          description: OK
          headers:
            X-API-Revision:
              description: API Revision
              schema:
                type: string
          **required:
            X-API-Revision**

We'd need to investigate further why this is not supported in NSWag.  If it's intentional or they decide not to fix it, we'd need to introduce a preprocessing step to remove these unsupported elements in order to successfully compile these specs.  (See SwaggerSpecPreprocessor for an example).

Odd, that definitely sounds like a bug/limitation of NSwag. Per the OpenAPI spec, header objects are parameter objects (with changes to name/in, so unrelated to this). Parameter objects define required as an optional boolean, so providing it with a true value should be acceptable.

Linking open NSWag issue: https://github.com/RicoSuter/NSwag/issues/2928

Workaround merged.


How to import DevExpress.data.CustomStore ?

How to import DevExpress.data.CustomStore into TypeScript?
The only place I found this declaration is in devextreme/dist/ts/dx.all.d.ts. However, when I try
import { CustomStore } from 'devextreme/dist/ts/dx.all';
it doesn't work. It gives: [ts] File 'devextreme/dist/ts/dx.all.d.ts' is not a module. -- which is comprehensible, since there isn't a dx.all.js in this same folder.
For the sake of completion: I'm trying to port this code from Angular 1.5:
    this.gridDataStore = new DevExpress.data.CustomStore({
        load: (loadOptions) => $q.resolve(this.getBuffer(loadOptions.skip, loadOptions.skip + loadOptions.take)),
        totalCount: () => $q.resolve(this.data.length),
        update: (key, values) => { this.data[key.a] = values.c; return $q.resolve(values); }
    });

Using
"devextreme-angular2": "^16.1.7"
"typescript": "2.0.3"

BTW: I'm using angular-cli and I did follow the instructions from #110.  (I added jquery.min.js and dx.all.js in the "scripts" section of angular-cli.json).
Everything is working fine. I can create a <dx-data-grid> without problems.
The problem is how to create a CustomStore. I simply don't know how to "teach" TypeScript compiler  where it is.

@fdcastel
I think you are getting the Cannot find name 'DevExpress' error when tsc compiles our component. To resolve the issue, declare DevExpress in the following way:
declare let DevExpress: any;
GH165.zip

Thank you very much for the tips and for the sample, @GoshaFighten! 👍
I'm already using the :any declaration to work around this. 😉
But... So... there's no way to get strong types definitions for now? I really thought we could use the d.ts  😞

You can do this in version 16.2. Recently, we published an alpha version of 16.2: 16.2.1-alpha.1. With this version, you can declare CustomStore like this:
`
import CustomStore from "devextreme/data/custom_store";
orders = new CustomStore({
load: (opts) => {
return new Promise((resolve, reject) => {
resolve([{ text: "Test" }]);
});
},
totalCount: (opts) => {
return new Promise((resolve, reject) => {
resolve(1);
});
}
});
`
GH165.zip

Whoa! That's exactly what I was waiting for. :) 👍
I'm seeing that now there's support for import only specific modules instead of entire dx! Nice!
We could close this one. I'll certainly have more questions about the new modules but I'll open a new issue for this :)
Thank you very much, @GoshaFighten !

I implemented this approach, however, when in batch edit mode, update method gets called on each cell changed, which is not sufficient, i want to call the server once, not multiple time. And yes, i saw this http://jsfiddle.net/t24jt5mj/ which is still not very helpful.  Is there a way to get to the save changes button event?


add Wistia

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[x] Company name
[x] Company description
[x] Company location
[x] GitHub link
[x] How Elixir is used

Thank @jbodah!


Fix #include guard

This fixes the #include guard for src/detail/uri_parse_authority.hpp,
which, before this commit, uses the same #include guard definition as
src/detail/uri_parse.hpp. This commit gives uri_parse_authority.hpp a
unique guard definition.

Many thanks @cmbrandenburg !


x/build: mention notable benchmark changes in Gerrit comment

I think it's going to be too easy to miss significant benchmark changes with the current state of things where the URL to perf.golang.org is always included in the final Gerrit comment.
I think the gerrit comment should also mention any notable changes.
/cc @quentinmit @josharian

Yes please! And perhaps also always include any relevant geomeans?
This should get implemented behind a flag that is easy to turn on and off, because past experience with performance dashboards suggests that we're going to have lots of problems with noise.

I'd rather start with some noise than have no information. We have lots of noise as-is with flaky tests, sadly.

I'm not so sure noise is better than nothing, particularly if it desensitizes people and causes them to systematically ignore/discount the results. I'll file an issue with an example and we can discuss some details there.


Upgrade to v16

version: v15.1.0
The Angular v16 will be released soon, so the lib is going to be upgraded to v16.0.0 which based on Angular 16

The v16.0.0 has been published now!


feat(crux): reworked email and notification templating

Removed hardcoded notification and email texts from code and moved them to template files
Implemented a simple template file
Moved email and chat templates to a new assets folder
Moved the install scripts from the root folder to the assets folder as well
Fixed an issue with the node script generation form: selecting PowerShell for Docker, then selecting Kubernetes tries to generate a PS1 script for Kubernetes (which is not supported)

❓assets folder, template format (inplace + hbr file) /docs for this?/, notification.template.builder.ts service (naming?)

Codecov Report
Base: 17.97% // Head: 17.97% // No change to project coverage :thumbsup:

Coverage data is based on head (9141732) compared to base (b16279b).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #454   +/-   ##
========================================
  Coverage    17.97%   17.97%
========================================
  Files           57       57
  Lines         5965     5965
========================================
  Hits          1072     1072
  Misses        4818     4818
  Partials        75       75

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove placeholder from interface since it is adding more complexity

Remove the placeholder object in the memo for the interface.ts read method. Nothing should be using it but somehow when we first tried to remove it it broke most of the test suite, so we need to figure out why.

@dfellis I think this is no longer revenant with the class-based approach?

Unfortunately no. This is in the Crud2 class which survived that transition.


Potential Missing Word in Lecture 3, Slide 6

Could potentially use "The next word in a sequence" instead of just "Next word in a sequence".

I would argue this to be acceptable - "zero article" in a numbered list
https://ell.stackexchange.com/a/177473

Yeah, I won't fix this as stylistically I go for fewer words in bulletpoints. So 0 points.


I'm sure I got the code to turning an image to a link, but it's not recognizing it

According to the instructions, I think I have this one right, but it's not being recognized and allowing me to move forward to the next lesson. Please help.
This is what showed up on the lesson:
The picture shows up fine in my window, but I cannot get it recognized and move on to the next lesson. I think there is a bug somewhere.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

Do you mind posting the code between back-ticks?
Like so:
code here

Also, please provide the name of the exercise.


Parse incorrectly handles strings with place separators but without decimals

The following test case fails for parse(), as it treats the comma as a decimal marker and returns a float:
const parse = require('currency-to-float').parse;
console.log(parse('$1,234')); // returns 1.234

I see something similar was addressed in v1.2.3 but doesn't seem to be correct in v1.3.1
https://github.com/mateus4k/currency-to-float/issues/1

Hi! I'll take a look at this case 🙂

Hey! Are you expecting the int 1234 after parsing?

Are you expecting the int 1234 after parsing?

@mateus4k Yes, that's correct!

@src-code in this case you must add a decimal case to work well. It's necessary to make this works for all currencies at the same time without having to pass any options parameter :slightly_smiling_face:
const value = $1,234;
console.log(parse(`${value},00`)); //1234

@mateus4k Perhaps this could be done by the library - if the value isn't a valid Number (eg, contains a places separator somewhere) simply check the 3rd-to-last char and if it's a comma or period, you know you have a decimal portion already.  If one is not found, append it before parsing, using the appropriate type (if comma was previously found as places separator, use a period, etc.)

@src-code I'm not sure looking at the third-to-last digit would be a good idea, since then the values would be limited to two decimal places. Can you open a pull request with your suggestions? We can think of using a flag through the second parameter to enable this :thinking:


Add optional reporting of failing validation

lint-openapi has a "--print_validator_modules" which prints the name of the module that contains the failing validation,  but this information is of limited value because the information is an implementation detail that is invisible to a user of the tool from the command line.  It would be nice to have another option that resulted in printing the actual name of the config option that resulted in the validation failure so that users can understand what config option controls that result.
Today I see this for example:
$ lint-openapi ./api-validator-openapi-2x.yml
warnings
  Message :   Response schemas should be defined with a named ref.
  Path    :   paths./validation-jobs/{job_id}/junit.get.responses.200.schema
  Line    :   176

It would be ideal to have something like this:
$ lint-openapi  --print_validator_name ./api-validator-openapi-2x.yml
warnings
  Message  :  Response schemas should be defined with a named ref.
  Validator  :  inline_response_schema
  Path         :  paths./validation-jobs/{job_id}/junit.get.responses.200.schema
  Line          :  176

(sorry about the alignment above, dang markdown and non-fixed-width font)
It is true that the messages are directly correlated to the message, but the only way to do this now that I see is building a map of messages to the validator config names, which seems like a fragile and non scalable way to do it.
I am happy to help with implementation by submitting a PR.

I like this idea. I only added the --print_validator_modules option to be  helpful in development but that was before the configuration support and names for all of the rules, etc. I don't expect it to be of any help to users and it really doesn't do much for the developer anymore either. It will be removed in a future release.
As for the --print_validator_name feature, I'm in support of it. I can see its usefulness in mapping back to the configuration file. I think I would prefer using the word "rule" instead of "validator" since that's the naming convention we use in the documentation but that's a small detail.
One thing to note is, not all validations have a "name" that maps back into a configuration rule. There are some rules that are so basic and fundamental to the OpenAPI spec that we don't bother documenting them or making them configurable (example). This isn't a deal-breaker of course but we would want to think about what to print for the output for these cases.
As always, you are more than welcome to write a PR for this! If you are unable, I can try to look at it in the coming weeks. Thanks for the issue

--print_rule_name ?  No opinion here, whatever you think is intuitive.
Perhaps for those validations you mention above we can make up a name for them that follows a pattern, e.g. "builtin_xxxxx" where  and then simply document that it is not possible to turn builtin_* rules off or something like that.  I am guessing that implementing this will require adding an additional field to the JSON result object in each individual test?  I suppose it will be easy enough since in the place where the test is run you are checking for the config enabling the test anyway so the string is right there.
As an FYI, I am currently writing an API validation SaaS offering and associated command line tools that will be used internally inside of VMware for API specifications across the company.   We have many different APIs and lots of different legacy APIs that have their own way of doing things, so flexibility is key.  Right now I am planning on spawning/calling lint-openapi from this service as a major part of the API validation.  This is driving my desire for the --json option as well as the --print_rule_names and such.  This service itself may end up being open source (I am pushing for this)

@aspear I want to echo @dpopp07 and say thanks for the interest and contributions. From the beginning our goal was to create a configurable and extensible linter for OpenAPI documents, so all contributions in this spirit are welcome!

We should evaluate the open pr that Barrett openend.

Fixed in #44.


Add optional info arg to strategy success callback

Passport.js expects the strategy to call success() with a user and optionally an info argument. Missing info argument may introduce discrepancies between other passport strategies and this middleware.
Are you implementing a new feature?
No
Is this a security patch?
No
Checklist

[x] I have read the CONTRIBUTING guidelines.
[x] I have added test cases which verify the correct operation of this feature or patch.
[x] I have added documentation/examples pertaining to this feature or patch.
[x] The automated test suite ($ npm run test) executes successfully.
[x] The automated code linting ($ npm run lint) executes successfully.

Hi @iatsiuk did you check that ChaiPassportStrategy has a success method with only one param?

I added an optional info property to the ChaiPassportStrategy interface. Let me know if that works for you.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.


Adding remaining stuff to the Event Store

This PR contains the latest changes to the events components + some fixes. The previous accepted changes are now replicated in the remaining modules of SFX, for each of the elements that contains an event store component.
Also a check has been added to make sure that we only add the repair tasks if the repair manager is enabled in the cluster, this is done by checking the cluster's manifest.

id say fix the 2 nits and then you are good to merge it.


Updated npm engines config

Its better that we restrict node versions to node >= 4. I believe node 0.10 was deprecated.

I think just up to 4 is a little bit aggressive for us? I think 0.12 would be a little safer, though I am open to argument?

Also I just checked a project that I'm a collaborator of and we use >=3.x for node/npm semver targets. I've never run into an issue so i think this is okay. But its more clear to use a fixed semver, like >=3.0


Unable to send funds from Wallets(Petra)

Describe the bug
Using accounts that have been funded we are unable to send funds form wallet UI to other accounts on the suzuka testnetwork.
To Reproduce
Steps to reproduce the behavior:

Add Suzuka Testnet to Petra Wallet
Fund from Faucet
Attempt to send funds to another wallet but unable to do so
See error
Expected behavior
Funded wallet should be able to send Move to another wallet

It seems Razor Wallet is also running into similar issues see screenshot below after funding the account it is unable to send funds to any other wallet or do any basica transaction similar to Petra

Additional information from nightly team having same issue

Razor is fine sending to an initialized or uninitialized wallet

Petra transaction simulation errors on the same issue present on a persistent issue across the board. This error is produced whenever a request is made to the GraphQL Indexer, it doesn't receive a response and is unable to loop through the response object because the object is Not Found.

Should be solved by https://github.com/movementlabsxyz/movement/tree/l-monninger/indexer-integration

@0xPrimata @Rahat-ch the indexer will be included shortly but I don't think this will fix the issue.  The indexer as it has been termed is the raw gRPC stream of transactions that are consumed by the Transaction Stream Service which is in turn consumed by the Indexer API which finally exposes the expected GraphQL API.  Once we have the referenced PR merged and deployed infrastructure for the TSS and Indexer API would be needed.  We have plans to have this infrastructure in place within the next two weeks.


Reduce GitHub access necessary to start using Hound

Addresses https://github.com/thoughtbot/hound/issues/597 and https://github.com/thoughtbot/hound/issues/701.
The first time around we were missing public_repo. This change includes that scope and the original work.
Here are some screen shots taken during testing:

For public repos under an organization, Hound is still trying create a Team to add @houndci to. The public_repo scope doesn't include privileges for that, so it fails to activate org repos. Chatted with @salbertson and we think we can skip creating the team for public repos.

Is this pretty much the same PR as the one that was reviewed and merged, plus public_repo?

@gylaz yea, pretty much. Like @thorncp said we talked about an issue with teams. I'm going to try and add Hound as a collaborator for open source repos, instead of creating team etc.

I'm going to try and add Hound as a collaborator for open source repos, instead of creating team etc.

I think some older organizations might not support this feature -- adding a user to an org repo as a collaborator. However, if I'm wrong, and GitHub has rolled this out to everyone, the I don't see a reason not to always add Hound as a collaborator to all repos, and rip out the team code.

LGTM and works for me on staging :+1:

@fotinakis here's the PR I was talking about.

:seal_of_approval:

Cool, thanks for the ping @salbertson!
Gave this a glance over, I think it will introduce the weird problem we talked about. The flow is: user logs in, you get a token with low permissions, user clicks a button and upgrade to more scopes, user logs out then logs back in—since you can't know who the user is before they login, you have to send them to GitHub with your default lower-permissions scopes, so they get yet another GitHub login screen that now says "Removed permissions" and they click authorize, then your higher-permissions token gets revoked and they give you another new token with the original lower scopes.
This may or may not be an issue for you, depending on if you care about retaining the higher-scoped token or just using it once. It can also introduce a bit of UI confusion because users see lots of GitHub authorizations screens, some adding permissions, then removing, then adding again, etc. Separate GitHub apps for authentication and for private repo access might be the way to go to avoid these problems.

@fotinakis, yea, there's still the weirdness with signing out. We are counting on the fact that users don't interact with houndci.com much once the service is enabled for private repos, but we'll see.
The private access token being invalidated when they sign in again isn't an issue since we fall back to our houndci user to make the requests, which is added as a collaborator during setup. This is not ideal though, since making requests from houndci count against our rate limit and we went through the trouble to introduced user specific tokens to avoid our rate limit.
Thanks for taking a look!


docs(v2): add trpgengine showcase

Motivation
Just add showcase
Have you read the Contributing Guidelines on pull requests?
Yep
Test Plan
Take a look of showcases
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

thanks :)


请教下，我用新的训练集进行训练，一共10类，测试时候出现这个错误：

RuntimeError: Error(s) in loading state_dict for RFBNet:
size mismatch for conf.0.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.0.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.1.weight: copying a param of torch.Size([126, 1024, 3, 3]) from checkpoint, where the shape is torch.Size([66, 1024, 3, 3]) in current model.
size mismatch for conf.1.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.2.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.2.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.3.weight: copying a param of torch.Size([126, 256, 3, 3]) from checkpoint, where the shape is torch.Size([66, 256, 3, 3]) in current model.
size mismatch for conf.3.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.4.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.4.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
size mismatch for conf.5.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.5.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
我并不清楚前面的checkpoint的torch.size的126/84这个是在哪修改的

已经解决了

请问你在自己的10类数据集上成功训练了吗？@chenchch94
我在我的单类数据集上训练，AP=0。应该是代码没改对，可以告诉我你怎么改的吗？
非常感谢！
我改了 data/voc0712.py、models/*.py 、train_RFB.py和test_RFB.py 中的类别NUM_CLASSES及类别数目num_classes。
请问还需要怎么改？
谢谢！

请问你在自己的10类数据集上成功训练了吗？@chenchch94
我在我的单类数据集上训练，AP=0。应该是代码没改对，可以告诉我你怎么改的吗？
非常感谢！
我改了 data/voc0712.py、models/*.py 、train_RFB.py和test_RFB.py 中的类别NUM_CLASSES及类别数目num_classes。
请问还需要怎么改？
谢谢！

do you solve the problem?

我跑了新数据集，没收敛。
发自网易邮箱大师
在2018年12月10日 11:30，million 写道：
请问你在自己的10类数据集上成功训练了吗？@chenchch94
我在我的单类数据集上训练，AP=0。应该是代码没改对，可以告诉我你怎么改的吗？
非常感谢！
我改了 data/voc0712.py、models/*.py 、train_RFB.py和test_RFB.py 中的类别NUM_CLASSES及类别数目num_classes。
请问还需要怎么改？
谢谢！
do you solve the problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

我跑了新数据集，没收敛。 发自网易邮箱大师 在2018年12月10日 11:30，million 写道： 请问你在自己的10类数据集上成功训练了吗？@chenchch94 我在我的单类数据集上训练，AP=0。应该是代码没改对，可以告诉我你怎么改的吗？ 非常感谢！ 我改了 data/voc0712.py、models/*.py 、train_RFB.py和test_RFB.py 中的类别NUM_CLASSES及类别数目num_classes。 请问还需要怎么改？ 谢谢！ do you solve the problem? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

I also met the problem.😭  The training set may be too hard to train.

Voc数据集可以收敛到0.803+
发自网易邮箱大师
在2018年12月11日 16:48，million 写道：
我跑了新数据集，没收敛。 发自网易邮箱大师 在2018年12月10日 11:30，million 写道： 请问你在自己的10类数据集上成功训练了吗？@chenchch94 我在我的单类数据集上训练，AP=0。应该是代码没改对，可以告诉我你怎么改的吗？ 非常感谢！ 我改了 data/voc0712.py、models/*.py 、train_RFB.py和test_RFB.py 中的类别NUM_CLASSES及类别数目num_classes。 请问还需要怎么改？ 谢谢！ do you solve the problem? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I also met the problem.😭 The training set may be too hard to train.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

loss_f + loss_c equals 0.803+ ?
loss_c  in my experments is about 1.x, loss_f is about 0.8.
I tried many times, loss is very unusual.

The mAP of VOC2007
发自网易邮箱大师
在2018年12月12日 14:52，million 写道：
loss_f + loss_c equals 0.803+ ?
loss_c in my experments is about 1.x, loss_f is about 0.8.
I tried many times, loss is very unusual.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

RuntimeError: Error(s) in loading state_dict for RFBNet:
size mismatch for conf.0.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.0.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.1.weight: copying a param of torch.Size([126, 1024, 3, 3]) from checkpoint, where the shape is torch.Size([66, 1024, 3, 3]) in current model.
size mismatch for conf.1.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.2.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.2.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.3.weight: copying a param of torch.Size([126, 256, 3, 3]) from checkpoint, where the shape is torch.Size([66, 256, 3, 3]) in current model.
size mismatch for conf.3.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.4.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.4.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
size mismatch for conf.5.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.5.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
我并不清楚前面的checkpoint的torch.size的126/84这个是在哪修改的

请问是怎么修改的呢？

RuntimeError: Error(s) in loading state_dict for RFBNet:
size mismatch for conf.0.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.0.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.1.weight: copying a param of torch.Size([126, 1024, 3, 3]) from checkpoint, where the shape is torch.Size([66, 1024, 3, 3]) in current model.
size mismatch for conf.1.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.2.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.2.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.3.weight: copying a param of torch.Size([126, 256, 3, 3]) from checkpoint, where the shape is torch.Size([66, 256, 3, 3]) in current model.
size mismatch for conf.3.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.4.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.4.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
size mismatch for conf.5.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.5.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
我并不清楚前面的checkpoint的torch.size的126/84这个是在哪修改的

请问是怎么修改的呢？

could you solve it？ what about the performance？

RuntimeError: Error(s) in loading state_dict for RFBNet:
size mismatch for conf.0.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.0.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.1.weight: copying a param of torch.Size([126, 1024, 3, 3]) from checkpoint, where the shape is torch.Size([66, 1024, 3, 3]) in current model.
size mismatch for conf.1.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.2.weight: copying a param of torch.Size([126, 512, 3, 3]) from checkpoint, where the shape is torch.Size([66, 512, 3, 3]) in current model.
size mismatch for conf.2.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.3.weight: copying a param of torch.Size([126, 256, 3, 3]) from checkpoint, where the shape is torch.Size([66, 256, 3, 3]) in current model.
size mismatch for conf.3.bias: copying a param of torch.Size([126]) from checkpoint, where the shape is torch.Size([66]) in current model.
size mismatch for conf.4.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.4.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
size mismatch for conf.5.weight: copying a param of torch.Size([84, 256, 3, 3]) from checkpoint, where the shape is torch.Size([44, 256, 3, 3]) in current model.
size mismatch for conf.5.bias: copying a param of torch.Size([84]) from checkpoint, where the shape is torch.Size([44]) in current model.
我并不清楚前面的checkpoint的torch.size的126/84这个是在哪修改的

@chenchch94 请问这个怎么改，看到联系我一下麻烦了<EMAIL_ADDRESS>


Create Low VOC

Also, you can review the contributor license agreement above, and if you agree with it, just type "I have reviewed and hereby sign the CLA" in the comment box below. It just basically just says that you agree that we can release your work as open source software.

I have reviewed and hereby sign the CLA

I have reviewed and hereby sign the CLA

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9857310). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main      #2   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?       1
  Lines           ?       5
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?       5
  Partials        ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9857310...966abc0. Read the comment docs.


Fix search placeholder

Fixes #1723
The search box placeholder now shows the appropriate translation, but also expands to accommodate more placeholder text, and truncates with '...' when the placeholder text becomes too large.

This is ready to go. Anyone mind reviewing?


Some SDK pkgs not sorted and different lints

While working on https://dart-review.googlesource.com/c/sdk/+/401865 I noticed that pkg/dartdev/test/commands/fix_test.dart is not sorted as are the analysis_server files. Maybe some other packages are also not enforcing the same standards? Opening this issue to track this conversation.
We could also take a look at the analysis_option.yamls for them so we are more consistent as I've also noticed in other CLs that there are differences between the analysis_server and linter packages.
CC some of the people I've either talked about it or I think may have an opinion on the matter @bwilkerson @scheglov @srawlins @pq.

There are no official rules for sorting code in the platform libraries or packages.
As far as I know, only the analyzer team has chosen to sort members. Since there are no rules, that's not an incorrect ordering.
The two traditional perspectives here are:

Code authors should not need to make a choice, there is only one correct ordering and it's enforced by tools.
Alphabetical ordering is meaningless. It's usually better for readability to sort semantically, with related functions being close.

(I'm personally strongly in the second group.)

On personal small projects, I do prefer semantics for sorting, but I think it gets a bit complicated when you start having lots of small methods that are used in more than one place or that depend on each other in a "loop", or any other difficult-to-place anywhere reason.
(Take a look at pkg\analysis_server\lib\src\services\correction\dart\import_library.dart, where the producers getter needs 6 different methods that internally need others in common, it gets complicated to sort by semantics here.)
In big projects like this, I agree we should have some form of standard (hence this issue) so everyone knows what to expect.
But that was simply what caught my eye recently. I think the lints are even more impactful of a change since they'll help enforce what standards we'd like to follow (and avoid some meaningless reviews).
I won't remember which CL it was, but I had to add one new propriety to a class or something like that, and there was a missing empty line between it and the class constructor (I'm aware there is no lint for this currently but it is simply an example), everything else on the CL was fine, but I had to apply a change and wait for two new reviews after that.
If these simple things could be enforced by a lint, then some similar cases could be avoided.

 See the difference
analysis_server
linter:
  rules:
    - analyzer_use_new_elements
    - avoid_redundant_argument_values
    - flutter_style_todos
    - library_annotations
    - prefer_single_quotes
    - unawaited_futures
    - unnecessary_breaks
    - unnecessary_final
    - unnecessary_library_directive
    - unnecessary_parenthesis
    - unreachable_from_main

linter
linter:
  rules:
    - always_put_required_named_parameters_first
    - analyzer_use_new_elements
    - avoid_annotating_with_dynamic
    - avoid_catches_without_on_clauses
    - avoid_catching_errors
    - avoid_dynamic_calls
    - avoid_positional_boolean_parameters
    - avoid_print
    - avoid_redundant_argument_values
    - avoid_returning_this
    - avoid_setters_without_getters
    - avoid_slow_async_io
    - avoid_unused_constructor_parameters
    - cancel_subscriptions
    - cast_nullable_to_non_nullable
    - comment_references
    - directives_ordering
    - discarded_futures
    - flutter_style_todos
    - join_return_with_assignment
    - library_annotations
    - literal_only_boolean_expressions
    - no_adjacent_strings_in_list
    - noop_primitive_operations
    - only_throw_errors
    - parameter_assignments
    - prefer_asserts_in_initializer_lists
    - prefer_const_constructors_in_immutables
    - prefer_constructors_over_static_methods
    - prefer_expression_function_bodies
    - prefer_foreach
    - prefer_null_aware_method_calls
    - prefer_relative_imports
    - prefer_single_quotes
    - sort_pub_dependencies
    - test_types_in_equals
    - throw_in_finally
    - unawaited_futures # pedantic
    - unnecessary_breaks
    - unnecessary_final
    - unnecessary_lambdas
    - unnecessary_library_directive
    - unnecessary_null_checks
    - unnecessary_parenthesis
    - unnecessary_statements
    - unreachable_from_main
    - use_if_null_to_convert_nulls_to_bools
    - use_late_for_private_fields_and_variables
    - use_setters_to_change_properties
    - use_string_buffers
    - use_to_and_as_if_applicable

I'm well aware that either is going to be a big change and probably won't happen anytime soon, this was simply to point this out so we can have this in mind and discuss it.

P.S.: Small side note since this can help to reduce meaningless reviews. Another place where we could have some thoughts is the Copybara and GitHub PRs relation, see https://github.com/dart-lang/dart_ci/issues/166.


minimal-bootstrap.tinycc-*: static link by default

Description of changes

Make tinycc enable static linking by default as mes-libc doesn't support dynamic linking. this aligns us with how it behaves in guix and live-bootstrap.
Related #227914
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Would It be possible to create a tinycc wrapper in karm that could pass this and the -B flag too?

@Ericson2314 Kaem doesn't parse arguments in the most robust way. It would probably be a C wrapper to do it right. Maybe a port of makeBinaryWrapper would be useful. Perhaps scope for a later PR tho?

once we're at tinycc-musl we can start using bash if that'd help.
it's only a handful of cases we need to remember -B right now


Unable to find webpack.config.js

Im having some difficulty getting the webpack.config.js to read properly.
In Startup.cs::Configure() I have the following.
    app.UseWebpack("webpack.config.js", "bundle.js", new WebpackDevServerOptions("localhost", 5000));
And webpack.config.js sits in the app path.

Application startup exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ComponentModel.Win32Exception: The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Webpack.Webpack.Execute(String configFile, String outputFileName, WebpackDevServerOptions devServerOptions)
   at Webpack.WebpackExtensions.UseWebpack(IApplicationBuilder app, String configFile, String outputFileName, WebpackDevServerOptions devServerOptions)

I've tried going up two directories "../../webpack.config.js" from #1 but no luck.  I verified I am running Kestrel.
I tried going back to version 1.1.0 as well.  Thank you for your time.

Well I assumed it was my configuration file that wasn't found, but it was actually missing the webpack-dev-server dependency, and since I didn't have logger.  I see you are writing logs out that would've helped me had I had the logger configured in my pipeline.
You have some good logging information, I suggest mentioning enabling it to get better error messages. :smile:

Hello cgatian. I have an open issue on analyzing the configuration and check that the required node modules are installed but it's not so easy to implement because of the various combination. But for sure I can check against webpack and webpack-dev-server that are absolute requirements.
Regarding logging I didn't mention something as it's enabled by default so I assumed that most of the people will not remove it but probably I can add this in the documentation too.
Please let me know if you miss a feature on the project and if you have any ideas to further improve it.


Fix write-timestamp and a generation test

Thanks!

I pushed a new release to Clojars including this fix.

Great, thanks a lot!


Document when Galleys get invalidated

The current comment is incomplete.
Related to https://github.com/emilk/egui/issues/3023 .

I think you need to approve CI to run. I'll try updating the PR too in a sec.


set python version to 3 in sonar config

I think that's actually a bug in our workflow logic. When the external report (pydocstyle) is empty, the Sonarscanner crashes.


"configure" doesn't work if user globals is not set

If
git config --global user.email<EMAIL_ADDRESS>git config --global user.name "Your Name"

is not set, git elegant configure will fail.

@rultor please release, the tag is 0.3.0.

@rultor please release, the tag is 0.3.0.

@extsoft OK, I will release it now. Please check the progress here

@rultor please release, the tag is 0.3.0.

@extsoft Done! FYI, the full log is here (took me 3min)


Is it possible to change the view engine?

I personally come from a Django background so personally prefer template syntax like Jinja2 / Nunjucks as opposed to blade / edge.
Is there any way to do this at the moment or any plans to add it in the future?

It won't ever be added into adonis-framework but you could have a go at making your own. I have made a Pug templating provider, that mirrors the api of the build in edge engine and it wasn't too difficult - https://github.com/webdevian/adonis-pug

Awesome, thanks @webdevian

Closing since not actionable


Integration with Notion

We received a feature request from a user asking for an integration with Notion. It seems like this might be possible as an incoming webhook via their Zapier integration - https://zapier.com/apps/notion/integrations/webhook/599249/trigger-post-webhooks-with-new-items-in-notion-databases to send messages in Zulip about events in Notion

@sbansal1999 Would you be up for taking a look at this one?

I just had some initial thoughts that if there were a Zapier integration for Notion, users could simply use Zapier to create a Zap that would send a message when a particular event happens on Notion. The trigger event for this Zap would be 'New Database Item'. More information on how to add the Zapier integration can be found here.
Instead of Zapier sending a POST request to our server, processing it, and then sending the message, I think it would be better for the Zap to send the message itself. According to me, the users can just basically use Zapier and connect it to Zulip.
Let me know if I have misunderstood anything.

I might be wrong as never used our Zapier integration before but is there any specific reason why they can't just use our existing zapier integration?
https://zapier.com/apps/zulip/integrations/notion
Seems like it is possible.

In fact I think you were suggesting the same thing @sbansal1999

Yeah exactly that's what I am suggesting. Users can simply use the Zapier Integration and get messages from events on Notion.

At least in my opinion there would be no good reason to try and custom build one when the only way of sending a webhook from notion is through zapier, its easier and simpler to just link straight through zapier.
Not sure if we support doing it, but maybe we could just create an integrations docs page for notion which explains they can use zapier so it would still show them we supported the app but that its through zapier. Not sure what you think @alya

It indeed looks like Notion doesn't have a native API at all; we could consider writing a documentation page on how to setup Zapier with Zulip if that's not trivial; we have a couple other integration doc pages along those lines.

I think we already have instructions on how to set up Zapier with Zulip here. Also, I think the information given there is pretty straightforward and easy to follow as well.

Since Notion is a popular product, I think it's worth adding a dedicated documentation page, especially if there are any specific setup suggestions we can make. @sbansal1999 would you be up for taking a pass at that? You can use https://zulip.com/integrations/doc/asana as an example/starting point.

I got your point; Notion is pretty popular so creating a dedicated documentation for it is surely worth it.
I will work on creating the documentation for this and thanks for giving a heads up on the example.


Table not wide enough/text in cells wrap frequently

I found this thread here. https://github.com/blacksmithgu/obsidian-dataview/issues/186 but I'm not sure that solves my issue: I have a couple columns, and some of them have a few words in them, but the width of the table doesn't adapt, meaning that the words in the cells wrap frequently like so:
This is
an example
of what
I mean.

Describe the solution you'd like
Is there a way to change a table's width? So it uses the space on the left margins more efficiently?
Thanks :)

22222222222222222222222222222222

+1 even with the "Readable line length" off and entire screen taken up by the pane, the table still wraps text in date columns. Narrow columns such as date should not be wrapped when there is room.

Could potentially use some CSS but I'm not knowledgeable enough to help beyond that.

+1

+1

+1

+1

+1 there's gotta be some way. I have text that wraps when it shouldn't and there is plenty of room.

If you want them to never wrap you can add this css snippet to your obsidian:
.dataview.table-view-table td {
    white-space: nowrap;
}

In my case, this works pretty well.
You could also modify this to only happen on mobile.


Announcement on Temporary Support Reduction (5)

 Issue by gsscoder
Thursday Feb 25, 2016 at 07:38 GMT
Originally opened as https://github.com/gsscoder/commandline/issues/291

My current work commitments prevent me from dealing with open source projects for another month.
Start date: Now
End date: (few day before/after) 1 April 2016
Again,
sorry for the inconvencience. I'm very confident this will be the last and maybe I can back to work on this and other open source projects also soon than said.
Regards,
Giacomo
PS:
I also apoligize for being slow in related and/or other kind of communcation (problems often arose from current commitement and contractual rules). Thanks for patience!

 Comment by gsscoder
Monday Apr 04, 2016 at 06:08 GMT

Unfortunately to honor contractual commitments, I am forced to extend this period further until the day 5 June 2016.
I'm sorry,
Giacomo

This seems like it can be closed.


joyent/kang#7 Update Restify dependencies; drop restify-clients

This combines the approaches in #8 and #9.

@melloc @trentm ^^ (The "assign reviewers" button is all grayed out for some reason)

 make test
tools/catest test/tst.env.js test/tst.lib.js test/tst.snapshot_merge.js
Configuration:
    SRC:                         /home/jcsb/src/j/18.4/manta/kang
    Output directory:            /var/tmp/catest.6263
    Temp directory:              /var/tmp/catest.6263_tmpfiles
    Keep successful test output: false
    Found 3 test(s) to run

===================================================

Executing test test/tst.snapshot_merge.js ... success.
Executing test test/tst.lib.js ... success.
Executing test test/tst.env.js ... success.

===================================================

Results:
	Tests passed:	 3/ 3
	Tests failed:	 0/ 3

===================================================
Cleaning up output from successful tests ... done.

@cburroughs Looks good to me!

I made a couple tweaks to package.json, added a CHANGES.md entry and published<EMAIL_ADDRESS>(and tagged v1.3.0).


circleci have changed artefact upload path

it seems that artefact retrieval is not working anymore using
https://github.com/YOU54F/cypress-slack-reporter/blob/7fa3c8f0ea9b53fe1e955b18efd995a7e84898e0/src/slack/slack-alert.ts#L410
Will need to check docs and update function accordingly to construct new url

This is now fixed by #446


Update ISSUE_TEMPLATE.md

Add brew config for macOS and java version info.
I started a PR (https://github.com/caskroom/homebrew-cask/pull/35711) to add this a couple of months ago, it's more useful now then it was then.

Lets add the output of brew doctor also, just for completeness and to mirror what they do in brew cask.

Alternative option, add macOS and Java to brew cask doctor: https://github.com/Homebrew/brew/commit/9494ee7bee6d5b8fd2aed865548ebc5bdc6ab539

Merging for now.

I would have liked a 👍  from the other maintiners on this or https://github.com/Homebrew/brew/commit/9494ee7bee6d5b8fd2aed865548ebc5bdc6ab539 first.


PORT=0 in .env: random port, default interface localhost for security

Ability to use random port number

Multiple create-react-app can be run in parallel doing like real work
Activated by having a line PORT=0 in ./.env
Port number 0 is default behavior for Node.js

Test: PORT=0 yarn react-scripts start

The browser window opening should have a port number other than 3000

Default interface <IP_ADDRESS>

Confines the development environment Create React App to the local host only
All interfaces is a security risk:

App is available to attackers on the local network segment
App is available to remote attackers via any remote link that may be active

Note that this does not listen on IPv6. That is HOST=::1

I published<EMAIL_ADDRESS>so that this can be tested with any React project
It worky-works

update hash c8dabfb
random port is 3005…3014 so that browser windows are reused
detect-port-alt api is older 1.1.6
<EMAIL_ADDRESS>


Accessibility scan and remediation

Used https://www.accessibilitychecker.org/ and https://wave.webaim.org/


Zero-length measured length markup disables map refresh

Double-clicking to begin a measured length markup creates a zero-length line. The map will not refresh if one of these has been created. If the zero length line is deleted, the map will function properly again.
Very interesting bug. This issue does not appear to exist with any other type of markup. This has been tested & confirmed in Mac Safari, Chrome & Windows IE.

Fixed


#1205 update archetype in README

This addresses #1205
For all changes:

[ ] Is there a issue associated with this PR? Is it referenced in the commit message?

[x] Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit?

[x] Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern=**/*?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn clean verify?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@jnioche I made a few changes based on your recommendation.  What do you think?


Handle special domains better

Reviewer: @MariagraziaAlastra
CC: @dharb
Description:
Just tightening up how we determine what's a special page and what isn't.
(Note, there's an outstanding bug where the popup might not update if you go from a non-special page to a special page. This PR doesn't fix that one.)
Steps to test this PR:
Open a bunch of special pages on Chrome, Firefox and Vivaldi.
None of them should be showing a grade, and the description should be sane.
Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

@andrey-p this looks good, only thing is on Vivaldi the message for the new tab is "extension page" as opposed to "new tab". I think it's pretty minor though, and it improves functionality, so LGTM 👍


[CI] Divide CI into gates

Explain your changes:
Current Buildkite CI does not distinguish on dhall level if we are running nightly or PullRequest tests. However, from deep dive into logic, there is some work done, which can be extended to control which job should run on nightly. By  providing export BUILDKITE_PIPELINE_MODE=Stable we can signal Ci that we want to run nightly jobs so Monorepo triage is disabled and all known jobs will be run.
However, it's not satisfactory, as we also want to exclude some jobs from PullRequest stage and run only on Stable. Therefore I introduced new attribute of JobSpec struct : mode which by default is set to PullRequest, but in some occasion can be override to Stable. Then code in monorepo traige job analyze it and prevents this jobs from running.
Stable (a.k.a Nightly ) logic is unchanged.
Then i went a bit further into CI configuration and was experimenting with splitting pipeline into 2-3 pipeline gates.

1 Gate only runs fast jobs
2 Gate run remaining jobs only if 1 Gate is green.
3 Gate only run if 2 Gate is green. It contains only closing jobs like gathering coverage

Explain how you tested your changes:
I tested it on fuzzy zkapp tests job example, which is using $NIGHTLY parameter which on script level control if jobs is empty but evergreen on PullRequest or have actual test run on Stable. I removed that logic from script and put Stable as job mode in dhall. Then verified job is not run.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #8821

Effect of my changes can be observed on separate pipeline:
https://buildkite.com/o-1-labs-2/tmp-teardownjob/builds/89

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

Approving since the changes are only in the buildkite/CI related files

!approved-for-mainnet


IdPMetadataParser sets ServiceProvider data

In OneLogin_Saml2_IdPMetadataParser in the parseXML function the NameIdFormat is read from the XML and set into the result metadata array. However instead of it being set in the idp key in the array, it's set in the sp key instead.
https://github.com/onelogin/php-saml/blob/88c5e59eb1bc65760f63edc57b502cc939d0d5b9/lib/Saml2/IdPMetadataParser.php#L192
Depending on the configuration, this causes a notice or worse. At the very least, the IdP parser shouldn't set anything about the SP?

The toolkit sets the value stored in ['sp']['NameIDFormat'] while building the Subject/NameId of the AuthNRequest.
The SP is able to use only the NameIdFormat that the IdP supports, so makes sense at the metadata parser to fill the toolkit sp setting with such value.

Can you explain this? The IdentityProvider config shouldn't have anything to do with the ServiceProvider config?
In my case my ServiceProvider communicates with a lot of different IdentityProviders, why would the metadata from one of these change the way my ServiceProvider is configured?
It also seems very strange to me, to configure the ServiceProvider and then have part of that configuration overridden by something that seems to be made for the IdentityProvider? The array key 'sp' isn't initialized in the code, which made me think this code only works if the ServiceProvider has been configured in advance?
If the NameIDFormat isn't configured on the ServiceProvider, wouldn't the default work well in every instance? Why is this needed?

Is true that you can use 1 SP - Multiple IdP by loading each time the right SP-IdP configuration, but the toolkit right now is designed to work 1 SP - 1 IdP.  That said, the IdPMetadataParser is oriented to fill the settings with the use of parseXML and
injectIntoSettings.
With that in mind, the use of those method will retrieve the first supported NameIdFormat by the IdP and use it.
If you don't want to modify the already configured NameIDFormat, You can simply execute
unset($metadataInfo['sp']['NameIDFormat']);

before the call to injectIntoSettings

Is it required to have the NameIDFormat for the ServiceProvider match with the IdentityProvider? The parser seems to pick the first one available, unless a preferred one is supplied, then it attempts to pick that one and falls back to the first one if the preferred one isn't found.
The code doesn't initialize $metadataInfo['sp'] to be an array, like it does for $metadataInfo['idp'] on line 122. This made me think the code was wrong.

If the SP sends an AuthNRequest with a NameID which Format is not supported by the IdP the IdP could reject such AuthNRequest.
Is true that 'sp' is not initialized and it should.
Each IdP can have each own security requirements, NameIDFormat supported, request the SAML Messages sent by the SP to be signed .. so at the end, you don't need only to store the IdP data, but also those extra info.

Alright, thanks for all the info. I think I'm all set and now understand why the code was written like that. Came across as pretty weird and with the 'sp' key not being initialized I got confused and thought it was a mistake.
A more elegant solution would be for this parameter to be included in the IdentityProvider settings array for all the supported formats. Then in the ServiceProvider config a setting could be used if the SP prefers a certain format (optionally) and could throw an error if the requested format isn't included in the array of supported formats. That way the data about the IdentityProvider and the ServiceProvider gets a more clean separation.
But the current setup works fine and in the 1 SP - 1 IdP scenario it's not really an issue.
Thanks again for your time and effort!


System.Text.Encodings.Web nuget package required on server project.

I had to add System.Text.Encodings.Web nuget package to server project to get this to work.
You might mention that in the tutorial.
Thanks for providing it anyway :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08de9daf-79aa-ee76-431e-f2432f8d691e
Version Independent ID: 1a1ee728-1741-c82a-75e1-06159709935b
Content: Use ASP.NET Core SignalR with a hosted Blazor WebAssembly app
Content Source: aspnetcore/tutorials/signalr-blazor-webassembly.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @rob-github ... I've seen this come up a few times, but I can't repro it, and the posters never say exactly what bit of API in the app is requiring it ...

https://github.com/dotnet/AspNetCore.Docs/issues/20752#issuecomment-736523984
https://github.com/dotnet/AspNetCore.Docs/issues/20645

Can you say what API is requiring it in the app? ... perhaps paste in the method to clarify it so that I can try and repro this again.

Also, please specify more environment details: Framework version? SDK version? Platform (OS)?

This is a bug when users use System.Text.Json 5.0 in a netcoreapp3.1 project.
Issue: https://github.com/dotnet/runtime/issues/45560

Thx @BrennanConroy ... Although Eric gave it a 5.0.x milestone, it's easy for me to surface this to readers in a NOTE and open a follow-up issue cross-linked to the engineering issue to revert the NOTE later. It's probably the best course of action given that @rob-github is the third reader to open a docs issue on it.

I just had the same problem. I just updated my dependencies and suddenly the system won't run on the server anymore with this error (it runs fine in Visual Studio).
Adding System.Text.Encodings.Web 5.0.1 explicitly into my ASP.NET Core 5.0 project makes the error goes away.


Sending emails fails (1.2.8)

Magento Version 2.3.1
Extension Version:  1.2.8
When I try to send any email with this module on I always get PHP errors (even if I disable the extension on Admin panel). PDFs print out fine,
This is the error I get:
2019/05/04  [error] 17887#17887: *878 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Error: Call to a member function setFrom() on null in /usr/share/www/1234/vendor/magento/framework/Mail/Message.php:111
Stack trace:
#0 /usr/share/www/1234/generated/code/Eadesigndev/Pdfgenerator/Model/Email/Message/Interceptor.php(206<EMAIL_ADDRESS>'smth')
#1 /usr/share/www/1234/vendor/magento/framework/Mail/Template/TransportBuilder.php(206<EMAIL_ADDRESS>'smth')
#2 /usr/share/www/1234/generated/code/Eadesigndev/Pdfgenerator/Model/Email/TransportBuilder/Interceptor.php(102): Magento\Framework\Mail\Template\TransportBuilder->setFromByScope('sales', '2')
#3 /usr/share/www/1234/vendor/magento/module-sales/Model/Order/Email/SenderBuilder.php(111): Eadesigndev\Pdfgenerator\Model\Email\TransportBuilder\Interceptor->setFromByScope('sales', '2')
#4 /usr/share/www/1234/vendor/magento/module-sales/Model/Or" while reading response header from upstream, client: <IP_ADDRESS>, server: local.magento, request: "GET /admin/sales/order/email/order_id/126/key/7b40f53c312739805dfebae8053c822c39325d98ca79797f3db7f44998c22cf5/ HTTP/1.1", upstream: "fastcgi://unix:/run/php72-fpm/php-fpm.sock:", host: "local.magento", referrer: "http://local.magento/admin/sales/order/view/order_id/126/key/6bcf0882c1fd484f7b78806c4a6dc547fe399986e4b1fdbb651ab02ea58e22ef/"

Is this some sort of permission issue? What's causing this?

By changing:
magento/vendor/eadesignro/module-pdfgenerator/Model/Email/Message.php
from:
    public function setFrom($fromAddress)
    {
        $this->zendMessage->setFrom($fromAddress);
        return $this;
    }

To:
    public function setFromAddress($fromAddress, $fromName = null)
    {
        $this->zendMessage->setFrom($fromAddress, $fromName);
        return $this;
    }

I am able to send the email, but they are blank.

#82 Pull request fixes the issue.
Are you still maintaining this free extension?

This should be fixed in the new release. Let me know it there are other issues. Thanks for the help and sorry for the late response.


[1.10.2] Recipes are craftable but JEI does not display the added recipes

Issue Description:
Trying to add recipes using various mods, the recipe does get saved and it is craftable, however JEI does not show any added recipes whatsoever, not even vanilla crafting table recipes that have been added. Done the same recipe in another instance without any mods, except Crafttweaker, Modtweaker, JEI and that recipe has worked. Here is the mod list: https://pastebin.com/M3suuDW7
What happens:
You can craft the recipe, but JEI does not show any added recipe.
What you expected to happen:
You add a recipe, JEI should display that added recipe.
Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):
https://pastebin.com/WXe9b5rM
Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):
https://pastebin.com/kRnRw2Vf

Affected Versions (Do not use "latest"):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>6
Crafttweaker: 1.10.2-3.0.26
Modtweaker: 2.0.13

Your most recent log file where the issue was present:
https://gist.github.com/xTitanium/ef1182ae56e1ed7c7cfd5b68decb7d9d

I can't reproduce this. Update JEI?


Mouse Without Borders for Smartphone to Pc

Description of the new feature / enhancement
if you add mouse without borders for smartphones and pc option it would be very helpful.

Seamlessly move your mouse from your PC to your smartphone screen, controlling the smartphone’s interface with your mouse and typing with your PC’s keyboard.

Copy text on your PC and paste it directly into apps on your smartphone using the same mouse and keyboard, streamlining your workflow and boosting productivity.

Interact with mobile apps on your smartphone using your PC’s mouse and keyboard, enhancing the efficiency and accuracy of app development and testing.

Control your PC’s presentation software directly from your smartphone, allowing you to move freely while maintaining full control over your presentation.

Use the precise controls of your PC’s mouse and keyboard to play mobile games, potentially improving your gaming performance and enjoyment.

Switch your mouse and keyboard between your PC and smartphone to multitask efficiently, taking notes on your PC while managing video calls on your smartphone.

Drag and drop files directly between your PC and smartphone, simplifying file sharing without needing additional software or cables.

Manage social media posts, messages, and notifications across multiple accounts by easily switching between your PC and smartphone, improving your efficiency.

Scenario when this would be used?
Connecting the Mouse Without Borders feature to a smartphone with a PC could open up various interesting scenarios and functionalities:
1. Seamless Multi-Device Navigation
Scenario: You are working on your PC but need to quickly access an app on your smartphone.
Description: With Mouse Without Borders, you can seamlessly move your mouse from your PC screen to your smartphone screen, controlling the smartphone's UI with your mouse and even using your PC's keyboard to type on your smartphone.
2. Enhanced Productivity
Scenario: You are researching a topic and need to copy text from a website on your PC to a note-taking app on your smartphone.
Description: Instead of switching devices, you can copy the text on your PC and paste it directly into the note-taking app on your smartphone using the same mouse and keyboard.
3.
4. Remote Control
Scenario: You are giving a presentation from your PC but need to control some aspects of the presentation from your smartphone.
Description: Use Mouse Without Borders to control your PC presentation software directly from your smartphone, allowing you to move around the room while still having full control.
5.
Description: Connect your smartphone to your PC using Mouse Without Borders and use the more precise controls of your PC to play mobile games, potentially improving your gaming performance.
6. Streamlined Communication
Scenario: You are in a video call on your smartphone but need to take notes or share files from your PC.
Description: Seamlessly switch your mouse and keyboard between your PC and smartphone to multitask efficiently, taking notes on your PC while managing the call on your smartphone.
7. File Management
Scenario: You need to transfer files between your smartphone and PC.
Description: Use Mouse Without Borders to drag and drop files directly between your PC and smartphone, simplifying the process of file sharing without needing additional software or cables.
8. Social Media Management
Scenario: You manage multiple social media accounts on both your PC and smartphone.
Description: Easily switch between your PC and smartphone to manage posts, messages, and notifications across different platforms, improving your efficiency in handling multiple accounts.
Supporting information
https://www.fonearena.com/blog/417682/lenovo-motorola-smart-connect-multi-device-connectivity-solution.html

/dup https://github.com/microsoft/PowerToys/issues/26296


Fix API requests

Fixes the API requests made to get an election, get all elections and get the results of an election.
Update the mocks
Removes the tokens from all the requests' body

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 54.784%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
3006

Relevant Lines:
5487

💛  - Coveralls


CLI tab-complete

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3481
Originally created by @WillDaSilva on 2022-05-11 21:26:31

Meltano uses the Python package Click for its CLI, which provides tab-complete/autocomplete as described here: https://click.palletsprojects.com/en/7.x/bashcomplete/
In particular, completion is provided for bash, zsh, and fish.
First, generate the shell-specific meltano-complete script (using bash as an example):
_MELTANO_COMPLETE=source_bash meltano > meltano-complete.sh

This script can be generated by us in CI, and included in the Meltano wheels or sdist. When Meltano is run, it should check if the completions have been installed by verifying that the completions file exists in the installation location. If they have not been installed, then it should install them (see below).
Installing shell completions
fish
The Meltano completion script should be placed in ~/.config/fish/completions/. From there it will be sourced automatically when a fish shell starts.
bash
The situation around per-user tab-completion in bash is a bit messier. There are standard locations to add completion scripts for system-wide packages (installed as root), but we cannot use those without root permissions. The bash-completion faq has this to say:

Q. Where should I install my own local completions?
A. Put them in the completions subdir of $BASH_COMPLETION_USER_DIR
(defaults to $XDG_DATA_HOME/bash-completion or
~/.local/share/bash-completion
if $XDG_DATA_HOME is not set) to have them loaded automatically
on demand when the respective command is being completed.
See also the next question's answer for considerations for these
files' names, they apply here as well. Alternatively, you can write
them directly in ~/.bash_completion which is loaded eagerly by
our main script.

$BASH_COMPLETION_USER_DIR may not be defined. $XDG_DATA_HOME may also not be defined. The directory ~/.local/share/bash-completion may not exist. I have confirmed that the following two commands results in the shell providing completions for the meltano command:
mkdir -p ${BASH_COMPLETION_USER_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/bash-completion}/completions
mv meltano-complete.sh ${BASH_COMPLETION_USER_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/bash-completion}/completions/meltano

Now we more-or-less just need to translate the above two commands into Python.
zsh
I'm not yet sure how to handle this for zsh. We may have to put the file into /usr/local/share/zsh-completions, or some other directory listed in $fpath. I do have zsh available, but I do not have macOS running on any of my devices, so testing zsh completions in a realistic manner is a bit tricky. For instance, the default permissions of /usr/local/share/zsh-completions will be important for how we decide to handle this.
Upgrading shell completions
The shell completions provided by Click are dynamic, which is to say switching to different versions of Meltano requires no changes to the installed completions. As an example, if a new (sub-)command or flag is added, it'll automatically be picked up by the tab-completer.
This has obvious advantages, but is noticeably slow, and we may want to change how the completions work in the future e.g. if we switch from Click to something else.
To support changing how the completion script works, we can make it so that the installed completion script is a thin wrapper that locates the currently activate meltano installation (i.e. where the wheel was installed into), then sources a completion script from that location. Like that, one could upgrade Meltano, or switch virtual environments, and get all-new tab-completions.

View 6 previous comments from the original issue on GitLab

Copying this comment over from the original issue.

@aaronsteers I've thought of an approach that will fully remove the difficulty of installing the tab-completion, and make it available from the first run. It also has the benefit of working not just for the Meltano CLI, but for any CLI program that uses Poetry (and likely Click/Typer).
We can create a new repository/package that provides a new Python build backend, then use this new build backend instead of Poetry. This new build backend (aside: we'd need a name for it, likely related to tabs, poetry, CLI, and/or (auto)completion) would be a thin wrapper around Poetry. The only way in which it would functionally differ from Poetry would be that at install-time it would install the shell completions automatically based on cues from the environment.
It could also generate the shell completions, but I'd prefer leaving that to some CI step that produces the completion scripts beforehand, as not generating the completions would mean that this build backend could be used for any Python CLI that uses Poetry, rather than just those that use Click/Typer.
I'd be rather excited if we could solve this problem, as it's been an annoying unsolved usability problem for Python CLIs for a long time. With this build backend approach this problem could be solved for all CLIs made with Poetry at once! For what it's worth, I currently maintain a similar "thin wrapper" build backend package that enables the use of Flit's build backend with setuptools_scm to derive the package version from SCM tags.

We probably won't be able to install tab-completion using regular Python installation methods, since they essentially amount to unpacking a zip (wheel) file. That is, unless we want to stop providing wheels altogether, which we do not.
To support installing tab-completion scripts while using wheel files, we could add a command to Meltano that installs them, then install that plus whatever system dependencies are necessary on the Meltano Docker image so that it has tab-completion out of the box, and everyone else can install it manually. It should only be necessary to install it once system-wide, rather than for each meltano version/installation.
Another option (not mutually exclusive with the first) if we ever support using package managers other than pip/pipx, e.g. brew, apt, curl https://get.meltano.com | sh, etc., then we could install the tab-completion scripts automatically.

Using click=8.1.7, the command for bash is
_MELTANO_COMPLETE=bash_source meltano

instead of
_MELTANO_COMPLETE=source_bash meltano

Besides that, autocomplete is working for me.


Show performance improvement graph with file-system watching enabled in release notes

Closed in favor of https://github.com/gradle/gradle/pull/13285.


StatusMenu Visibility Fix

Closes #110
Summary
StatusMenu wasn't visible when an Infopanel was displayed over it. Because of this, the StatusMenu now closes Infopanels before use.
Local Tests
I listed the EVCs from mef_eline and then accessed the StatusMenu; the EVC list was then removed.

@italovalcy Just finished working on that issue that was assigned.

@viniarck I updated the changes here too.


feat: return empty array if from_map IO function raises certain exceptions

Discussed on Slack, this is a way to give from_map callers the ability to provide a list of "allowed" exceptions that should just return an empty array. It requires the io_func to have a form attribute such that a correctly formed empty array can be instantiated. cc @lgray

This currently lacks the ability to keep track of what arguments fail.

Codecov Report

Merging #400 (08b3344) into main (c9f10ab) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 82.14%.

:exclamation: Current head 08b3344 differs from pull request most recent head c7f5fbb. Consider uploading reports for the commit c7f5fbb to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   94.05%   93.93%   -0.12%
==========================================
  Files          23       23
  Lines        3061     3084      +23
==========================================
+ Hits         2879     2897      +18
- Misses        182      187       +5

Files
Coverage Δ

src/dask_awkward/lib/io/io.py
96.19% <100.00%> (+0.19%)
:arrow_up:

src/dask_awkward/lib/io/columnar.py
98.38% <66.66%> (-1.62%)
:arrow_down:

src/dask_awkward/layers/layers.py
93.07% <60.00%> (-2.83%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Alright I've reworked the PR to use a new mock_empty method which is designed to be restricted to one of ("cpu", "jax", "cuda")

We also need a way to communicate the backend to return_empty_on_raise

Great! This gives enough to prototype something that's a good analogue of what we have presently in coffea.


Why did you remove #trackAll ? (just curious)

Thanks for the useful gem!
Why did you remove #trackAll in the latest ahoy.js? (just curious)
One more question. Why did you stop mentioning ahoy.js on ankane/ahoy/README.md?

Hey @ts-3156, trackAll was removed to encourage developers to be more thoughtful about tracking.
I'm not sure I follow the last question - there are many references to Ahoy.js in the current Ahoy readme.

@ankane Thanks for the answer.

there are many references to Ahoy.js in the current Ahoy readme.

You are right. I was wrong. Sorry.
Have a nice day!


keras lstm cells

model.add(lstm(4)). This has 4 lstm blocks, but how many cells keras creates it? if I use stacked lstm, then keras lstm contain 2 hidden layer: it will be many to many. Is there any specific architecture keras has for lstm and as well as stacked lstm?

model.add(LSTM(4)) creates four LSTM cells in a single layer. If you want to stack more layers, call model.add(LSTM(4)) more times (once per layer).

creates 4 lstm blocks and each block has 4cells
Is this right. Or it has 4 blocks where each block has a single cell?

@vinayakumarr  a "block" is a single cell or memory unit in reference to your query. As mentioned by @carlthome model.add(LSTM(4)) will create 4 cells or "blocks" in a single layer.  For more info on lstm 1 & 2

according to thesis, first link lstm has blocks, which inturn has cells. But what about in keras? Reference fig 3.3 in thesis

no, FELIX GERS thesis, it is in english 1

Keras' LSTM() assumes you want as many "memory blocks" as cells. If you want to share gates for several cell states you'll need to implement your own custom layer.

So to answer your original question: it has 4 blocks where each block has a single cell.

yes you are right. so keras has 4 blocks where each block has a single cell for lstm(4) . in hidden layer 4 blocks which in turn has 4 cells: this has input gate, output gate, forget gate, error carousel (CEC) and peehole connection, fig 5.1 in thesis. Could you give a basic architecture for these 4 blocks. This helps to understand more clearly
one more question, in staked lstm, i will have two hidden layer am i right?
one hidden layer has 4 blocks , this layer feeds to other hidden layer (contains 4 blocks) for 2 stacked lastm layers am i right?

Honestly, if you're that curious about the particular details of Keras's LSTM, just look at it? Here it is.

In my opinion, before implementing a model you should take a deeper look into theory of RNNs and its variants. That'll will solve most of the problems. For cell architecture refer this and for stacked layer representation this issue.