Fix github workflow warnings

Is your feature request related to a problem? Please describe.
See warnings here https://github.com/ChainSafe/lodestar/actions/runs/4786942358

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/setup-node@v2, actions/create-release@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

As of Oct 15 2024, there are still warnings in our workflows. These should be resolved to avoid sudden breakages.


Break apart a set of five tests

I was taking these tests for my first time and I found the first question confusing. When the answer I submitted failed, I could not tell whether it was because I didn't understand how .combine() worked at all, or because one of my answers was wrong.
This PR takes the fifth .combine() test and moves it to a separate question.  I think this will be fine because the first 4 .combine() tests are so similar.

I looked at this repo because I had the same issue and wanted to fix that too :) great PR


Halo table read optimization

This PR reduces the runtime it takes to load a CachedHaloTable into memory. Speedup introduced here is ~2x. The only change is to ensure that the table is only read into memory once when performing all the self-consistency checks associated with the safe_for_cache test. Further speedups to continue addressing #515.

After running cProfile on the loading of a halo table, it's clear what's dominating the runtime: the call to broadcast_host_halo_property is sorting the entire table according to halo_hostid and then calling group_member_generator. It may be faster to use crossmatch instead, but in general this pre-sorting is a good idea and will be the bottleneck in table loading.


BUG: Fix cred table identifiers

I didn't notice that some of the tweaking of table identifiers for the Filtering PR broke the ID on the credential exchange table, so just fixing that quickly here.
Problem in Innkeeper identifier as well, fixing that.

Merging this as it's a quick fix and actively causing issues in dev env.


bug: range scan datum deserialization panicked at 'assertion failed: self.remaining() >= dst.len()'

Describe the bug
thread '<unnamed>' panicked at 'assertion failed: self.remaining() >= dst.len()', /risingwave/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-1.2.1/src/buf/buf_impl.rs:253:9
--
  | stack backtrace:
  | 0: rust_begin_unwind
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/std/src/panicking.rs:575:5
  | 1: core::panicking::panic_fmt
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/panicking.rs:64:14
  | 2: core::panicking::panic
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/panicking.rs:111:5
  | 3: bytes::buf::buf_impl::Buf::copy_to_slice
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-1.2.1/src/buf/buf_impl.rs:253:9
  | 4: bytes::buf::buf_impl::Buf::get_i64_le
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-1.2.1/src/buf/buf_impl.rs:554:9
  | 5: risingwave_common::util::value_encoding::deserialize_value
  | 6: risingwave_common::util::value_encoding::inner_deserialize_datum
  | at ./src/common/src/util/value_encoding/mod.rs:62:19
  | 7: risingwave_common::util::value_encoding::deserialize_datum
  | at ./src/common/src/util/value_encoding/mod.rs:53:5
  | 8: risingwave_batch::executor::row_seq_scan::ScanRange::new::{{closure}}
  | at ./src/batch/src/executor/row_seq_scan.rs:86:21
  | 9: core::iter::adapters::map::map_try_fold::{{closure}}
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/map.rs:91:28
  | 10: core::iter::traits::iterator::Iterator::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:2238:21
  | 11: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/map.rs:117:9
  | 12: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:195:9
  | 13: core::iter::traits::iterator::Iterator::try_for_each
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:2299:9
  | 14: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:178:9
  | 15: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/spec_from_iter_nested.rs:26:32
  | 16: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/spec_from_iter.rs:33:9
  | 17: <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/mod.rs:2748:9
  | 18: core::iter::traits::iterator::Iterator::collect
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:1836:9
  | 19: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter::{{closure}}
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/result.rs:2075:49
  | 20: core::iter::adapters::try_process
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:164:17
  | 21: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/result.rs:2075:9
  | 22: core::iter::traits::iterator::Iterator::collect
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:1836:9
  | 23: itertools::Itertools::try_collect
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/itertools-0.10.5/src/lib.rs:2014:9
  | 24: risingwave_batch::executor::row_seq_scan::ScanRange::new
  | at ./src/batch/src/executor/row_seq_scan.rs:81:13
  | 25: <risingwave_batch::executor::row_seq_scan::RowSeqScanExecutorBuilder as risingwave_batch::executor::BoxedExecutorBuilder>::new_boxed_executor::{{closure}}::{{closure}}
  | at ./src/batch/src/executor/row_seq_scan.rs:237:39
  | 26: core::iter::adapters::map::map_try_fold::{{closure}}
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/map.rs:91:28
  | 27: core::iter::traits::iterator::Iterator::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:2238:21
  | 28: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/map.rs:117:9
  | 29: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::try_fold
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:195:9
  | 30: core::iter::traits::iterator::Iterator::try_for_each
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:2299:9
  | 31: <core::iter::adapters::GenericShunt<I,R> as core::iter::traits::iterator::Iterator>::next
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:178:9
  | 32: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/spec_from_iter_nested.rs:26:32
  | 33: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/spec_from_iter.rs:33:9
  | 34: <alloc::vec::Vec<T> as core::iter::traits::collect::FromIterator<T>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/alloc/src/vec/mod.rs:2748:9
  | 35: core::iter::traits::iterator::Iterator::collect
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:1836:9
  | 36: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter::{{closure}}
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/result.rs:2075:49
  | 37: core::iter::adapters::try_process
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/adapters/mod.rs:164:17
  | 38: <core::result::Result<V,E> as core::iter::traits::collect::FromIterator<core::result::Result<A,E>>>::from_iter
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/result.rs:2075:9
  | 39: core::iter::traits::iterator::Iterator::collect
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/iter/traits/iterator.rs:1836:9
  | 40: itertools::Itertools::try_collect
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/itertools-0.10.5/src/lib.rs:2014:9
  | 41: <risingwave_batch::executor::row_seq_scan::RowSeqScanExecutorBuilder as risingwave_batch::executor::BoxedExecutorBuilder>::new_boxed_executor::{{closure}}
  | at ./src/batch/src/executor/row_seq_scan.rs:235:17
  | 42: <core::pin::Pin<P> as core::future::future::Future>::poll
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  | 43: risingwave_batch::executor::ExecutorBuilder<C>::try_build::{{closure}}
  | at ./src/batch/src/executor/mod.rs:195:29
  | 44: <core::pin::Pin<P> as core::future::future::Future>::poll
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  | 45: risingwave_batch::executor::ExecutorBuilder<C>::build::{{closure}}
  | at ./src/batch/src/executor/mod.rs:179:25
  | 46: risingwave_batch::executor::ExecutorBuilder<C>::try_build::{{closure}}
  | at ./src/batch/src/executor/mod.rs:191:64
  | 47: <core::pin::Pin<P> as core::future::future::Future>::poll
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  | 48: risingwave_batch::executor::ExecutorBuilder<C>::build::{{closure}}
  | at ./src/batch/src/executor/mod.rs:179:25
  | 49: risingwave_batch::task::task_execution::BatchTaskExecution<C>::async_execute::{{closure}}
  | at ./src/batch/src/task/task_execution.rs:273:9
  | 50: risingwave_batch::task::task_manager::BatchManager::fire_task::{{closure}}
  | at ./src/batch/src/task/task_manager.rs:96:37
  | 51: <risingwave_batch::rpc::service::task_service::BatchServiceImpl as risingwave_pb::task_service::task_service_server::TaskService>::create_task::{{closure}}
  | at ./src/batch/src/rpc/service/task_service.rs:73:13
  | 52: <core::pin::Pin<P> as core::future::future::Future>::poll
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  | 53: <risingwave_pb::task_service::task_service_server::TaskServiceServer<T,F> as tower_service::Service<(http::uri::path::PathAndQuery,tonic::request::Request<core::pin::Pin<alloc::boxed::Box<dyn futures_core::stream::Stream+Item = core::result::Result<alloc::boxed::Box<dyn core::any::Any+core::marker::Sync+core::marker::Send>,tonic::status::Status>+core::marker::Send>>>)>>::call::{{closure}}
  | at ./src/prost/src/sim/task_service.rs:478:29
  | 54: <core::pin::Pin<P> as core::future::future::Future>::poll
  | at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/future/future.rs:124:9
  | 55: <tracing::instrument::Instrumented<T> as core::future::future::Future>::poll
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/tracing-0.1.37/src/instrument.rs:272:9
  | 56: madsim_tonic::sim::transport::server::Router<L>::serve_with_shutdown::{{closure}}::{{closure}}::{{closure}}
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-tonic-0.2.11/src/transport/server.rs:262:56
  | 57: async_task::raw::RawTask<F,T,S>::run
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-4.3.0/src/raw.rs:511:20
  | 58: madsim::sim::task::Executor::run_all_ready
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-0.2.12/src/sim/task.rs:209:17
  | 59: madsim::sim::task::Executor::block_on
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-0.2.12/src/sim/task.rs:159:13
  | 60: madsim::sim::runtime::Runtime::block_on
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-0.2.12/src/sim/runtime/mod.rs:124:9
  | 61: madsim::sim::runtime::builder::Builder::run::{{closure}}::{{closure}}::{{closure}}
  | at ./.cargo/registry/src/github.com-1ecc6299db9ec823/madsim-0.2.12/src/sim/runtime/builder.rs:128:35
  | note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
  | note: run with `MADSIM_TEST_SEED=34` environment variable to reproduce this error
  | and make sure `MADSIM_CONFIG_HASH=1AD2E4ABC41F3553`

To Reproduce
No response
Expected behavior
No response
Additional context
https://buildkite.com/risingwavelabs/main-cron/builds/292#018574f6-e819-41db-ba51-80363d49c625

Which query caused this?  (See the full logs in the issue description).
2023-01-03T14:11:52.665825Z  INFO risingwave_meta::hummock::compaction_scheduler: Start compaction scheduler.
2023-01-03T14:11:52.739502Z  INFO services: risingwave_meta::hummock::compactor_manager: Added compactor session 1
2023-01-03T14:12:53.426276Z  WARN services: risingwave_meta::barrier: Failed to complete epoch<PHONE_NUMBER>140864: Rpc error: gRPC error (Unknown error): transport error
  backtrace of `MetaError`:
   0: std::backtrace_rs::backtrace::libunwind::trace
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2: std::backtrace::Backtrace::create
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/std/src/backtrace.rs:332:13
   3: <risingwave_meta::error::MetaError as core::convert::From<risingwave_meta::error::MetaErrorInner>>::from
             at ./src/meta/src/error.rs:66:33
   4: <T as core::convert::Into<U>>::into
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/convert/mod.rs:726:9
   5: <risingwave_meta::error::MetaError as core::convert::From<risingwave_rpc_client::error::RpcError>>::from
             at ./src/meta/src/error.rs:135:9
   6: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
             at /rustc/bdb07a8ec8e77aa10fb84fae1d4ff71c21180bb4/library/core/src/result.rs:2108:27
   7: risingwave_meta::barrier::GlobalBarrierManager<S>::inject_barrier_inner::{{closure}}
             at ./src/meta/src/barrier/mod.rs:718:9
   8: risingwave_meta::barrier::GlobalBarrierManager<S>::inject_barrier::{{closure}}
             at ./src/meta/src/barrier/mod.rs:651:72
   9: risingwave_meta::barrier::GlobalBarrierManager<S>::run::{{closure}}
             at ./src/meta/src/barrier/mod.rs:640:17
  10: risingwave_meta::barrier::GlobalBarrierManager<S>::start::{{closure}}::{{closure}}
             at ./src/meta/src/barrier/mod.rs:508:45

Seems related to Meta?

The failure on meta is caused by compute node exiting unexpectedly. The root cause should be panic on the compute node. I guess there's something wrong with the implementation of ser/de of some kind of data type. 🤔

First bad commit: da6114d2e80e6404d64611857cafc6891256f52d

Changing col_0 to be of type bigint explicitly works:
CREATE TABLE partsupp (
                          ps_partkey INTEGER,
                          ps_suppkey INTEGER,
                          ps_availqty INTEGER,
                          ps_supplycost NUMERIC,
                          ps_comment VARCHAR,
                          PRIMARY KEY (ps_partkey, ps_suppkey)
);

CREATE TABLE orders (
                        o_orderkey BIGINT,
                        o_custkey INTEGER,
                        o_orderstatus VARCHAR,
                        o_totalprice NUMERIC,
                        o_orderdate DATE,
                        o_orderpriority VARCHAR,
                        o_clerk VARCHAR,
                        o_shippriority INTEGER,
                        o_comment VARCHAR,
                        PRIMARY KEY (o_orderkey)
);

CREATE MATERIALIZED VIEW m5 AS SELECT 0::bigint AS col_0 FROM partsupp;

SELECT
    1
FROM
    m5 JOIN orders ON m5.col_0 = orders.o_orderkey
GROUP BY
    m5.col_0,
    orders.o_totalprice
HAVING
    SMALLINT '27538' = m5.col_0;

output
CREATE_TABLE
CREATE_TABLE
CREATE_MATERIALIZED_VIEW
 ?column?
----------
(0 rows)

Range scan is using int64 to deserialize m5.col0 when it should be using int32:
data: [1, 146, 107, 0, 0]
datatype: Int64
null_tag: 1
thread 'risingwave-main' panicked at 'assertion failed: self.remaining() >= dst.len()', /Users/noelkwan/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-1.2.1/src/buf/buf_impl.rs:253:9

In the query:
CREATE TABLE partsupp (
                          ps_partkey INTEGER,
                          ps_suppkey INTEGER,
                          ps_availqty INTEGER,
                          ps_supplycost NUMERIC,
                          ps_comment VARCHAR,
                          PRIMARY KEY (ps_partkey, ps_suppkey)
);

CREATE TABLE orders (
                        o_orderkey BIGINT,
                        o_custkey INTEGER,
                        o_orderstatus VARCHAR,
                        o_totalprice NUMERIC,
                        o_orderdate DATE,
                        o_orderpriority VARCHAR,
                        o_clerk VARCHAR,
                        o_shippriority INTEGER,
                        o_comment VARCHAR,
                        PRIMARY KEY (o_orderkey)
);

CREATE MATERIALIZED VIEW m5 AS SELECT 0::int AS col_0 FROM partsupp;

SELECT
    1
FROM
    m5 JOIN orders ON m5.col_0 = orders.o_orderkey
GROUP BY
    m5.col_0,
    orders.o_totalprice
HAVING
    SMALLINT '27538' = m5.col_0;

o_order_key is BIGINT.
However in scan_ranges eq_condshows a typeint32. I guess it should be int64` instead?
                                                      QUERY PLAN
----------------------------------------------------------------------------------------------------------------------
 BatchProject { exprs: [1:Int32] }
 └─BatchHashAgg { group_key: [m5.col_0, orders.o_totalprice], aggs: [] }
   └─BatchHashJoin { type: Inner, predicate: m5.col_0::Int64 = orders.o_orderkey }
     ├─BatchExchange { order: [], dist: Single }
     | └─BatchProject { exprs: [m5.col_0, m5.col_0::Int64] }
     |   └─BatchFilter { predicate: ('27538':Varchar::Int16 = m5.col_0) }
     |     └─BatchScan { table: m5, columns: [col_0] }
     └─BatchExchange { order: [], dist: Single }
       └─BatchProject { exprs: [orders.o_totalprice, orders.o_orderkey] }
         └─BatchScan { table: orders, columns: [o_orderkey, o_totalprice], scan_ranges: [o_orderkey = Int32(27538)] }

cc @chenzl25 @xxchan Could you please take a look? 🥺

create table t1(x int);
create table t2(x bigint);
insert into t1 values(1);
insert into t2 values(1);
create index i1 on t1(x);
create index i2 on t2(x);

explain select * from i1 join i2 using(x) where x=1;
                                     QUERY PLAN
-------------------------------------------------------------------------------------
 BatchLookupJoin { type: Inner, predicate: i1.x::Int64 = i2.x AND (i2.x = 1:Int32) }
 └─BatchExchange { order: [], dist: Single }
   └─BatchProject { exprs: [i1.x, i1.x::Int64] }
     └─BatchScan { table: i1, columns: [x], scan_ranges: [x = Int32(1)] }
(4 rows)

select * from i1 join i2 using(x) where x=1; -- panic

IIRC there are casts when building scan_ranges, so the OP's panic should not occur 🤔

It's the InputRef that has a wrong type 🥸

It is a bug of derive_predicate_from_eq_condition() which occurs when the equal condition lhs and rhs have two different data types. If @xxchan you don't mind, I can fix it.


refactoring and cleanup

The getWindowVariable function is needed as using window.eval(<variableName>) is the only way to access Javascript data from the original page if a @grant other than none is specified.
More information about this can be found at http://wiki.greasespot.net/Content_Script_Injection
Please update the PR accordingly such that it works again.


restructure english content and initialize japanese localization

Closes #145
As I mentioned in #145, I have reorganized some content and added minimal Japanese localization for the website.
Let me know what the team thinks and I would love to have some feedback from the maintainers.
As for the Japanese localization, I will ask the Japanese members who have experience localizing CNCF glossary.

PTAL @raravena80

PTAL @rajaskakodkar

Three people have approved this PR. I think this is sufficient LGTM to merge this PR!!
WDYT @raravena80??

Love all the progress here 🙌

@kaitoii11 can you sign the DCO? Thank you!

Is there anything from my end that needs to be done to move this forward?


HBASE-23912 Resolve the TODO of FSTableDescriptor's construct method …

…(#1225)
Signed-off-by: Duo Zhang<EMAIL_ADDRESS>

There are some conflicts when cherry-pick to branch-2. So create a new PR for brnach-2.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
7m 17s
branch-2 passed

+1 :green_heart:
compile
1m 14s
branch-2 passed

+1 :green_heart:
shadedjars
5m 13s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 44s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
5m  4s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
6m 52s
hbase-server in the patch failed.

37m 32s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1247

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e59833e3e836 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 77dc78437f

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/testReport/

Max. process+thread count
594 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m  2s
branch-2 passed

+1 :green_heart:
checkstyle
1m 21s
branch-2 passed

+0 :ok:
spotbugs
3m 25s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  8s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 35s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 212 unchanged - 5 fixed = 212 total (was 217)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  8s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
findbugs
3m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

46m  2s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1247

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux 24f88ca3a6b4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 77dc78437f

Max. process+thread count
85 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 25s
branch-2 passed

+1 :green_heart:
compile
1m  0s
branch-2 passed

+1 :green_heart:
shadedjars
4m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  4s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
63m 56s
hbase-server in the patch passed.

89m 15s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1247

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 26c970a854d5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 77dc78437f

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/testReport/

Max. process+thread count
8659 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1247/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Write Up 1 by Livy Taylor

what a mess

Hey, it looks great, not a mess at all 😄!  Just so you know, technically it isn't correct, since the tests don't pass. If you run the command testing/test_all.sh, then you will see the output:
``
Failure testing problem2 case 1, since there was a difference in output:
1d0
< Enter thy numebrs
...
What that means is that the correct output does **not** have the text "Enter thy numebrs", but your output does, and since that doesn't match, it is "wrong".

This won't matter for this assignment, since I can obviously check that your code is correct otherwise, but it probably will matter for later assignments, so make sure you run `testing/test_all.sh` to make sure everything matches.

Grade:
Problem 1: 2/2
Problem 2: 0/2
Output of testing/test_all.sh, showing differences in incorrect output:
Testing problem1
Success testing problem1 case 1 in 0.00 seconds.
Testing problem2
Failure testing problem2 case 1, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 2, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 3, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 4, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 5, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 6, since there was a difference in output:
1d0
< Enter thy numebrs
Failure testing problem2 case 7, since there was a difference in output:
1d0
< Enter thy numebrs


Potential clash of oauthIds

I am not sure if this a real problem, but I noticed that there is no prefix being added to the oAuthid for each provider.
In the case of 2 providers using the same id for different users, this would cause potential security issues.
A potential solution would be, to prefix the oauthId with the name of the oauth provider.
(My provider just using incrementing IDs starting with 1, so that has the potential to clash with others...)

Oh didn't look properly, it is not the case


[TASK] Create Line Chart

Description
Create Line Chart Block in new UI
Existing
Reference
Tasks
The following data fields, tools, and styling must be included within the chart.
Fields

[x] x-axis
[x] y-axis
[ ] Tooltip

Events

[ ] Brush event
[ ] Click event

Axis Features

[ ] Show/hide each axis
[ ] Add axis titles
[ ] Show/hide axis titles
[ ] Edit label font size of axis titles
[ ] Show tick marks
[ ] Rotate axis values (by a degree amount)

Styling

[ ] Change color scheme
[ ] Color by value
[ ] Add chart title
[ ] Curve type (how the line is formed) options of smooth, exact, step
[ ] Choose line type (solid, dashed, dotted)
[ ] Choose line weight

Features

[ ] Legend - toggle on/off
[ ] Display value labels
[ ] Customize value labels (choose position for the value label, rotate label by a certain degrees, select font and font size and font color)
[ ] Toggle tooltips on/off
[ ] Toggle trendline on/off

Branch : feat/Echart_LineChart

Added new field task - need to be able to multi-select/add on the y-fields so there can be multiple lines within the same chart


Some Feature Update

Multi-Threading in Folder Scanning
i18n updated
Session Check
Session Encryption with new lib. No gcc required any more
Error Handling. If artists close their accounts

Thank you, I'll check this later.


RedisClient.address always set to "<IP_ADDRESS>:6379" when 'options.tls' is set

The field is set here:
https://github.com/NodeRedis/node_redis/blob/master/index.js#L64
before the 'tls' options are copied. This leads to error message that read:
Redis connection to <IP_ADDRESS>:6379 failed - read ECONNRESET

instead of say:
Redis connection to myserver.net:6380 failed - read ECONNRESET

Came across this same issue and it was very misleading and sent me down a massive rabbit hole wondering why my client was trying to connect to localhost. Turns out it wasn't...
My issue is the same as with the OP. The address field is only set based on the passed in host and port, and not the tls ones passed in. Of course if the defaults are left undefined then they default to <IP_ADDRESS>:6379.
Easy fix is to simply add a line in the tls options check to set the address appropriately.
For the moment I've simply added the host and port to the base options, as well as the tls options. Little messy but it works.

The reason is that this was not the original intention when implemented. But this is indeed very misleading and a totally valid usage. Originally it was only thought about adding the port / host or the path in the options and all other tls options in the specific tls options.
Please feel free to open a pull request for it. I'm aboard at the moment and have little time, so this would be help to implement it faster.


Discuss the performance of Chinese message

Expected Behavior

If git message appears in Chinese, it will prompt a subject-case error.
Although it is possible to disable this verification through configuration, my hope is to be able to verify both subject-case and Chinese
Current Behavior

f Chinese appears, the following error will occur
git commit -m "feat(build): 增加 git commit message 验证"
 > running commit-msg hook: commitlint -E GIT_PARAMS
⧗   input:
feat(build): 增加 git commit message 验证

✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖   found 1 problems, 0 warnings

Affected packages

[x] cli
[ ] core
[ ] prompt
[x] config-angular

Possible Solution

Steps to Reproduce (for bugs)

module.exports = {
  extends: ['@commitlint/config-angular']
};

Context

Your Environment

Executable
Version

commitlint --version
7.0.0

git --version
2.17.1

node --version
10.3.0

// .commitlintrc
{
"rules": {
"subject-case": [0]
}
}

I don't think it is a bug. It should be a feature request.
It is true that now the @commitlint/config-conventional is not friendly to Chinese or other non-English languages.
I think we can create a new configuration for these languages.
If I have time, I'll create a pull request for it.

I think this issue might be relevant too, #438. In that issue, a non-alphabetic character (1) also incorrectly fails the subject-case test. I'm not familiar at all with the Chinese characters, but I guess it also should be ignored for the subject-case test right? If so, I think my fix for issue #438 will also fix this issue. It checks if it contains an a-z or A-Z character before running the test, and it will return true if it doesn't have this character.


Gateway tests [WIP]

This PR contains tests for Custom Gateways with Istio. See https://github.com/istio/istio/issues/29303
The first set of tests sets up a custom gateway and verifies access to the application via the custom gateway
The next set (coming soon) sets up a control plane and custom gateway using an older version of Istio, verifies connectivity, upgrades the control plane, verifies connectivity, upgrades the custom gateway, and verifies connectivity. The current plane is to test using in-place upgrades.
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
e80cd640f7e85d284ffbe2be26a6458d7986e093
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Updated PR with an upgrade test to show that upgrading via istioctl upgrade of the control plane and custom gateway does work. Now to clean up and move things around to reduce duplicated methods, etc.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8c74aabb2b5f3c70e750da4fa89b433c73ed77cc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8c74aabb2b5f3c70e750da4fa89b433c73ed77cc
link
/test lint_istio

analyze-tests_istio
8c74aabb2b5f3c70e750da4fa89b433c73ed77cc
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
8c74aabb2b5f3c70e750da4fa89b433c73ed77cc
link
/test analyze-tests_istio

lint_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test lint_istio

integ-pilot-multicluster-tests_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test lint_istio

integ-pilot-multicluster-tests_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
b89495aa3047a3943cb890bf9737503dd4c1cd1d
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
7cdbdcebdb182b58c833d65a7866fa3152bb59cf
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
7cdbdcebdb182b58c833d65a7866fa3152bb59cf
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
c372bf5d05ad3938d47240913d33b3106c5fb374
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c372bf5d05ad3938d47240913d33b3106c5fb374
link
/test lint_istio

integ-pilot-multicluster-tests_istio
c372bf5d05ad3938d47240913d33b3106c5fb374
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
c372bf5d05ad3938d47240913d33b3106c5fb374
link
/test integ-pilot-multicluster-tests_istio

lint_istio
56862d4cd6f66ec3f3288bfd5cc0b4488227c406
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
6740ef72a3cac241141b784d055148bba4f4472b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
6740ef72a3cac241141b784d055148bba4f4472b
link
/test gencheck_istio

lint_istio
6740ef72a3cac241141b784d055148bba4f4472b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
6740ef72a3cac241141b784d055148bba4f4472b
link
/test gencheck_istio

lint_istio
dc0bcc1c5faae07a7754ca2dc66ce5f0cf2d2628
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dc0bcc1c5faae07a7754ca2dc66ce5f0cf2d2628
link
/test lint_istio

gencheck_istio
dc0bcc1c5faae07a7754ca2dc66ce5f0cf2d2628
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
5e20bed0f7539d8f81b3b385eb694e470b9ecfaa
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6867ae55b2aaaeb882668806e86ab647077b75ee
link
/test integ-operator-controller-tests_istio

integ-pilot-multicluster-tests_istio
3e6d344379742ac141f41904481f4e2a070ebc85
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3e6d344379742ac141f41904481f4e2a070ebc85
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
3e6d344379742ac141f41904481f4e2a070ebc85
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
3e6d344379742ac141f41904481f4e2a070ebc85
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
08b2dfc25b123d5d09019a4f6b94f0cd87d4f152
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Presubmit test is now failing and it looks like it's because the control plane is not getting upgraded from the earlier version of the second operator init. This works when run locally.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
08b2dfc25b123d5d09019a4f6b94f0cd87d4f152
link
/test integ-telemetry-mc-k8s-tests_istio

integ-operator-controller-tests_istio
08b2dfc25b123d5d09019a4f6b94f0cd87d4f152
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
33b19636ee835439d14b2c2dfbdd8376892fd8c0
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Work is still on going on this test

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
33b19636ee835439d14b2c2dfbdd8376892fd8c0
link
/test integ-operator-controller-tests_istio

lint_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
33b19636ee835439d14b2c2dfbdd8376892fd8c0
link
/test integ-operator-controller-tests_istio

lint_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test lint_istio

analyze-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test lint_istio

analyze-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test lint_istio

analyze-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a55d3f7e14b0bfe2f4f0b72a142564989b0f2d28
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Work still being done on this test.

/retest

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
81957316db04f6a816b82059577050f7b9d4d4cd
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


how to use libcups3_native in C#

I install libcups3_native in VS2022 by NuGet, but I can't find any information how to start using this lib in C#,
Can you give me any help?  Thanks!

Sorry, I'm not sure how you'd use this C library with C#.


Public API for mesh axis index size

You can use jax.lax.axis_index(axis) to get your index along a mesh axis without needing access to the mesh object.  However, there does not seem to be a way to get access to the size of a mesh axis through the public API.
We have been doing:
        tensor_parallel_size = jax.interpreters.pxla.thread_resources.env.shape["TP"]

but jax.interpreters is not part of the public API.
Should such a function be added?  Or are we doing something wrong if we think we sometimes need it?

No, there is no public API yet but we are working on it.
One thing you can do is create your own context manager and thread the mesh around and access it wherever you want.

Thanks, that's a good idea for a workaround.


style: make margins even on left and right on mobile

Remove padding on card for post

closed in 4ef1f375f22699ea1c481e7c0c4281436e4ef45c


Extra step when deleting a storage account from the command palette

v2 forward compat
When using the Azure Storage: Delete Storage Account command in the command palette this extra step shows up after choosing which storage account you want to delete.

If you choose one of the options you get this message next.

In the end you're unable to delete the storage account.

https://github.com/microsoft/vscode-azureresourcegroups/pull/550 should fix this

Verified this no longer reproduces.


only gather list of streams if prefix is specified:

This helps the non -t flag case in two ways

Because we don't fetch log streams, we call the aws api less, so it's faster.
Since we don't filter log streams by last event, we don't miss streams that were updated recently for small --since durations

cc @tejasmanohar this should fix the issue of using near --since timestamps in the case where you are not also specifying --task

ah thanks! missed this


Large scale dataset training

Hi,
I have encountered an issue where the dataset I entered is too large to be read, and if it is particularly large, , it can cause the process to be Killed. For example,
Loading extension module split_decision...
Using /root/.cache/torch_extensions/py38_cu118 as PyTorch extensions root...
No modifications detected for re-loaded extension module split_decision, skipping build step...
Loading extension module split_decision...
Killed
How can I solve this problem? Does PGBM support batch training?
Thanks

Thanks for reporting, looking into it. PGBM currently doesn't support batch training, unfortunately. I'd suggest to try the CPU version based on Sklearn - let me know if that one does work for you?


Roles inherited from groups are not displayed

Is your suggestion related to an experience? Please describe.
I created a user named jenny and a group named baseball-team. Then created a role name sports-room-admin and assigned that role to the baseball-team group.
When I go to jenny's roles, sports-room-admin is not shown under the roles tab.
Describe the improvement
UI should show something like sports-room-admin via baseball-team group  under jenny's roles.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


export default lazyReducerEnhancer

the Redux store seems to need a default to work.

I'm using this code:
import { lazyReducerEnhancer } from "pwa-helpers/lazy-reducer-enhancer.js"
import { applyMiddleware, combineReducers, compose as _compose, createStore } from "redux"
import thunk from "redux-thunk"

// @ts-ignore
const compose = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || _compose

export const store = createStore(
  (state, action) => state,
  compose(lazyReducerEnhancer(combineReducers), applyMiddleware(thunk))
)

Your change would allow to use import lazyReducerEnhancer from ... instead of import { lazyReducerEnhancer } .... I think this is the intention behind this change.
lazyReducerEnhancer is also exported in pwa-helpers.js. So instead of
import { lazyReducerEnhancer } from "pwa-helpers/lazy-reducer-enhancer.js"

you can also use
import { lazyReducerEnhancer } from "pwa-helpers"

Prefer to keep this as is with no default export. See @hastebrot 's comment.


[💡 Feature Request] Field Type "Group"

Now, that I finally have time and a real project to sink my teeth into this CMS, I've come to my first little hurdle.
I think it would be nice to be able to group certain fields together visually and / or structurally.
Let's say that you have address fields that are in a single collection  (e.g. Settings). Currently all of the fields are visually each a full line of text, which makes editing more difficult.
In the data, that you receive in the FE, it does not bother me so much, that I can't group multiple fields together, but it would be a nice touch.
I think a (visual)-group field would be nice and could work similarly to the layout feature of the repeater field. More finetuning of sizes (like a option to give a percentage of the column / row width)  would be extra awesome, but the former works just fine imo.
What are your opinion on this @murisceman ?
Or did I just not see that feature in the docs?
In any case, I'm still extremely happy i stumbled upon this project. Stellar work my friend!
I'll get back with more feedback if something comes up!
Cheers 🍻

Hey, I'm glad to hear that you are enjoying working with it!
The good news is that field grouping is already available. There are many nice things that haven't been documented yet because I currently lack the time to write up more details and examples. However, here is what you're looking for: https://github.com/pruvious/pruvious/blob/main/src/runtime/collections/collection.definition.ts#L122-L164
Additionally, here is an example of its usage: https://pruvious.com/tutorial/03-header-and-footer#settings-collection
Cheers! 🍻

Oh excellent! Yeah I did not know this existed or could be also used like this! I did see the tutorial example, but I thought you were just able to set tabs with it (which was already pretty neat).
Thank you for your swift answer! ❤


Update desktop searchbar colors

Fixes

Fixes #1879 by @dhruvkb
Description

This PR updates the searchbar colors to match the desktop mockups, and adds the VR tests.
Testing Instructions

The searchbar on the homepage and on the search pages on the desktop widths should match the mockups.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Looks great, one small error. The hover state is also meant to be the gray background, and the text darkens a bit:

I tried changing the hover state to match the mockups you linked, @zackkrida, but then I noticed that they are not updated: the resting state is white, and the hover and active states are darker; the color they use is still dark-charcoal-06 while the new mockups use dark-charcoal-10. I think it's better to leave it the way it was in this PR and add changes after Francisco is back.

This is great, matches the mockups!
Would using a flag to differentiate the styles have been easier than splitting the input field into old and new components? That way we wouldn't have to update all the various references to the component.

I feel like it's much easier to safely develop both old and new components when they are separated than to use the flag for styles. It is very easy to accidentally break both :(


Improve reusability of API tests and others

The bugs haven't been discovered until launched to production. So, the tests being reusable would always be helpful.

We probably have to get rid of the fixtures and replace them with methods like the ones used in django-netjsonconfig.

@rohithasrk if this is done, please close


add pos trim array and string support

add pos trim array and string support
add pos trim test code

Codecov Report

Merging #53 into master will decrease coverage by 0.93%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   92.46%   91.52%   -0.94%
==========================================
  Files          10       10
  Lines         783      791       +8
==========================================
  Hits          724      724
- Misses         40       48       +8
  Partials       19       19

Impacted Files
Coverage Δ

gse.go
88.67% <0.00%> (-7.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50866d3...9a0d85e. Read the comment docs.


Feat: use diff/triggers to selectively run CI jobs

The CI job (sonar.yml, which should be renamed) runs separate CI jobs for the front-end, backend, and auth components. I'd prefer for these to only run if there are relevant changes in the corresponding source directories. Right now they each run all the time, each doing a separate SonarCloud scan, which results in SonarCloud spamming results emails.

Requested by @basilv, broken into separate issues.
The CI job (sonar.yml, which should be renamed) runs separate CI jobs for the front-end, backend, and auth components. I'd prefer for these to only run if there are relevant changes in the corresponding source directories. Right now they each run all the time, each doing a separate SonarCloud scan, which results in SonarCloud spamming results emails.

We have a ci_auth_artifact.yml that should likely be combined with the sonar.yml auth component job.

The ci_infrastructure.yml is working well, I did scope it to the right set of files so it only runs when needed, but I'd appreciate any feedback you have.

https://github.com/bcgov-nr/action-test-and-analyse/issues/22

This could take a little while, because the test action would need triggers added and to return a pass when not matched.


Initial generation of md from schema.json

Description
Generated markdown from zarf.schema.json to include in docs.
Related Issue
Fixes #606
Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist before merging

[X] Tests have been added/updated as necessary (add the needs-tests label)
[ ] Documentation has been updated as necessary (add the needs-docs label)
[ ] An ADR has been written as necessary (add the needs-adr label) [ 1 2 3 ]
[X] (Optional) Changes have been linted locally with golangci-lint. (NOTE: We haven't turned on lint checks in the pipeline yet so linting may be hard if it shows a lot of lint errors in places that weren't touched by changes. Thus, linting is optional right now.)

One piece as a note to overcome with this is how to get the generated docs back into git as a signed commit. See https://github.com/actions/runner/issues/667

Quick note as I was playing with this, sed for updating the $ref fields:
sed -ie 's/"$ref": "#\/definitions/"$ref": ".\/zarf.schema.json\/#\/definitions/g' zarf.schema.json

Deleted the branch due to matching the schema.json file extension inside of the .git folder :smh:


Prelaunch support like uwp apps in WinUi3

Startup performance of UWP apps on desktop device family devices is quite improved by proactively launching the apps that users use most often in the background.
is there anything like that supported in WinUi3?
/// <summary>
/// This method should be called only when the caller
/// determines that we're running on a system that
/// supports CoreApplication.EnablePrelaunch.
/// </summary>
private void TryEnablePrelaunch()
{
    Windows.ApplicationModel.Core.CoreApplication.EnablePrelaunch(true);
}

Also mentioned that

Performance considerations
Today in version 1.0 of Windows App SDK, launch speeds, RAM usage, and installation size of WinUI 3 apps are larger/slower than seen in UWP. We are actively working to improve this. We will have more information to share in the future.

Are there any guidance for moving to WinUi3 for production ready apps or is it still not matured enough as UWP?
https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/migrate-to-windows-app-sdk/what-is-supported

I doubt enabling prelaunch for WinUI 3 apps, which are Win32 desktop apps, would be a good idea (at least for now) since desktop apps don't get suspended and resumed. Prelaunched UWP apps essentially got suspended so the app didn't slow down your computer, but still load certain things into memory that could potentially slow down app launch times if the app was terminated and reopened very often.
You should probably ask this in the AppSDK repo as it's a system feature and not a feature of the WinUI framework.


[xmlwrapp] Add new port

Added port for xmlwrapp (https://github.com/vslavik/xmlwrapp), which is a C++ wrap library for libxml and libxslt.  I have tested on Windows/VS2019 and linux ubuntu/centos.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dough3nry sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @dough3nry
Thanks for this PR.
Could you please look into the regressions?
5>LINK : fatal error LNK1104: cannot open file '..\libxml\Debug\xmlwrapp.lib' [C:\agent\_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\src\libxslt\xsltwrapp.vcxproj]
     5>Done Building Project "C:\agent\_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\src\libxslt\xsltwrapp.vcxproj" (default targets) -- FAILED.
     3>Done Building Project "C:\agent\_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\ALL_BUILD.vcxproj" (default targets) -- FAILED.
     1>Done Building Project "C:\agent\_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\install.vcxproj" (default targets) -- FAILED.

Yes, I will look in to it soon. I believe the windows shared library is not building correctly. I only use static lib so I did not notice.
Sent from my iPad

On May 31, 2020, at 10:56 PM, NancyLi1013<EMAIL_ADDRESS>wrote:

Hi @dough3nry
Thanks for this PR.
Could you please look into the regressions?
5>LINK : fatal error LNK1104: cannot open file '..\libxml\Debug\xmlwrapp.lib' [C:\agent_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\src\libxslt\xsltwrapp.vcxproj]
5>Done Building Project "C:\agent_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\src\libxslt\xsltwrapp.vcxproj" (default targets) -- FAILED.
3>Done Building Project "C:\agent_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\ALL_BUILD.vcxproj" (default targets) -- FAILED.
1>Done Building Project "C:\agent_work\1\s\buildtrees\xmlwrapp\x86-windows-dbg\install.vcxproj" (default targets) -- FAILED.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @dough3nry
Could you please address the review suggestions and also look into the regressions?

@dough3nry
Is work still being done for this PR?

Sorry I have not followed up in this. I have it working internally, so we have lost the motivation to have it work with all the configurations you require. I guess if someone else finds the port useful they can help out otherwise maybe it just dies.

From: NancyLi1013<EMAIL_ADDRESS>Sent: Tuesday, August 4, 2020 4:27:20 AM
To: microsoft/vcpkg<EMAIL_ADDRESS>Cc: dough3nry<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/vcpkg] [xmlwrapp] Add new port (#11672)
@dough3nryhttps://github.com/dough3nry
Is work still being done for this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vcpkg/pull/11672#issuecomment-668458868, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADKVH23PDRBMSJIGWRQJSQTR67A6RANCNFSM4NO76R3A.

Thanks for your PR and also for your response.
I'm closing this for now. If you'd like to continue working on it in the near future, please reopen and ping us.
If someone else is interested in this port, he or she can open a new PR.


Improve write API responses

Codecov Report

Merging #46 (e816db6) into main (216d7d5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   82.94%   82.94%
=======================================
  Files           9        9
  Lines         780      780
=======================================
  Hits          647      647
  Misses        111      111
  Partials       22       22

Impacted Files
Coverage Δ

driver/grpc.go
90.17% <0.00%> (ø)

driver/http.go
82.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216d7d5...e816db6. Read the comment docs.


Update agosabe.toml for testnet-15

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

My previous PRs: anoma#826, anoma#998, anoma#1298


X::TypeCheck::Splice exception description is wrong

https://docs.perl6.org/type/X$COLON$COLONTypeCheck$COLON$COLONSplice
It seems the description is a lie for current rakudo. And example throws completely different exception.
It has to be investigated and, I suppose, rewritten.

The link is now this one. Is it still wrong?

Some places it shows up in roast:
*https://github.com/perl6/roast/blob/master/S32-array/splice.t#L186

https://github.com/perl6/roast/blob/master/S06-macros/unquoting.t#L68 and this one seems to be related to macro


Calling Path.getBounds() has the side effect of making future calls to Path.shift() or Path.transform() to fail valid path assertions

Steps to Reproduce

Run flutter create bug.
Add the following code before setState()
Run the code

final path = Path()
      ..moveTo(0, 1)
      ..lineTo(1, 2);

path.getBounds();
final newPath = path.transform(Matrix4.identity().scaled(200, 200).storage);
newPath.getBounds();
final path2 = newPath.shift(Offset(100.0, -100));

Expected results: The path should be shifted
Actual results:
Exception

Logs

════════ Exception caught by gesture ═══════════════════════════════════════════════════════════════
Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/html/path/path_ref.dart:831:12
isValid
is not true

[✓] Flutter (Channel dev, 1.24.0-3.0.pre, on Mac OS X 10.15.4 19E287 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2020.1.2)
[✓] Connected device (4 available)
• No issues found!

Not sure if this is specific to web, because on Android, same code returns below error log:

android log

════════ Exception caught by gesture ═══════════════════════════════════════════════════════════════
The following UnimplementedError was thrown while handling a gesture:
UnimplementedError

When the exception was thrown, this was the stack:
#0      Matrix4.scale (package:vector_math/src/vector_math_64/matrix4.dart:886:7)
#1      Matrix4.scaled (package:vector_math/src/vector_math_64/matrix4.dart:908:65)
#2      _MyHomePageState._incrementCounter (package:newweb/main.dart:57:55)
#3      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:985:20)
#4      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:1101:38)
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#13d1b
  debugOwner: GestureDetector
  state: ready
  won arena
  finalPosition: Offset(308.7, 553.3)
  finalLocalPosition: Offset(20.7, 33.3)
  button: 1
  sent tap down
════════════════════════════════════════════════════════════════════════════════════════════════════
W/libEGL  (13512): EGLNativeWindowType 0xc7111808 disconnect failed
W/libEGL  (13512): EGLNativeWindowType 0xc7111008 disconnect failed
D/mali_winsys(13512): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000,  [540x960]-format:1
D/mali_winsys(13512): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000,  [540x888]-format:1
E/BpSurfaceComposerClient(13512): Failed to transact (-1)
E/BpSurfaceComposerClient(13512): Failed to transact (-1)
W/libEGL  (13512): EGLNativeWindowType 0xc116b808 disconnect failed
W/libEGL  (13512): EGLNativeWindowType 0xc7111008 disconnect failed

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.82, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.24.0-4.0.pre.82 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision e5814756a2 (2 days ago), 2020-10-27 01:47:03 -0700
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.11.0 (build 2.11.0-260.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.4 19E2269
      darwin-x64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      86.0.4240.111

• No issues found!

web error log
For a more detailed help message, press "h". To quit, press "q".
══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following assertion was thrown while handling a gesture:
Assertion failed:
org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/html/path/path_ref.dart:831:12
isValid
is not true

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 216:49  throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 24:3    assertFailed
lib/_engine/engine/html/path/path_ref.dart 831:12                             debugValidate
lib/_engine/engine/html/path/path_ref.dart 350:5                              shiftedFrom
lib/_engine/engine/html/path/path.dart 63:27                                  shiftedFrom
lib/_engine/engine/html/path/path.dart 1281:19                                shift
packages/newweb/main.dart 59:26                                               [_incrementCounter]
packages/flutter/src/material/ink_well.dart 985:14                            [_handleTap]
packages/flutter/src/material/ink_well.dart 1101:38                           <fn>
packages/flutter/src/gestures/recognizer.dart 183:24                          invokeCallback
packages/flutter/src/gestures/tap.dart 598:48                                 handleTapUp
packages/flutter/src/gestures/tap.dart 287:5                                  [_checkUp]
packages/flutter/src/gestures/tap.dart 259:7                                  acceptGesture
packages/flutter/src/gestures/arena.dart 157:12                               sweep
packages/flutter/src/gestures/binding.dart 372:20                             handleEvent
packages/flutter/src/gestures/binding.dart 348:14                             dispatchEvent
packages/flutter/src/rendering/binding.dart 279:11                            dispatchEvent
packages/flutter/src/gestures/binding.dart 303:7                              [_handlePointerEventImmediately]
packages/flutter/src/gestures/binding.dart 267:5                              handlePointerEvent
packages/flutter/src/gestures/binding.dart 225:7                              [_flushPointerEventQueue]
packages/flutter/src/gestures/binding.dart 208:32                             [_handlePointerDataPacket]
lib/_engine/engine/platform_dispatcher.dart 895:13                            _invoke1
lib/_engine/engine/platform_dispatcher.dart 174:5                             invokeOnPointerDataPacket
lib/_engine/engine/pointer_binding.dart 128:39                                [_onPointerData]
lib/_engine/engine/pointer_binding.dart 477:16                                <fn>
lib/_engine/engine/pointer_binding.dart 438:21                                <fn>
lib/_engine/engine/pointer_binding.dart 208:16                                <fn>

Handler: "onTap"
Recognizer:
  TapGestureRecognizer#a84a0
════════════════════════════════════════════════════════════════════════════════════════════════════

I believe it is specific to web, the application runs fine on android and iOS, but fails on web

duplicate of https://github.com/flutter/flutter/issues/68702 , PR to fix will be in master shortly.


Don't set style height when it is unknown

Hey, it's me again :)
I was wondering if on initial render with type variable (when size of list items is unknown) react-list could skip setting the div's style to 0. Basically something like this in the render function:
const size = this.getSpaceBefore(length, cache);
    if (size) {
      style[SIZE_KEYS[axis]] = size;
    }

Currently if I want to position my elements at the bottom of the container they get pushed below it's bottom border due to height:0. Here is a sample to illustrate the issue:
import React from 'react';
import ReactList from 'react-list';

const getHeight = index => 30 + (10 * (index % 10));
getHeight.toJSON = () => getHeight.toString();

const renderVariableHeightItem = (index, key) =>

    {index}

;
renderVariableHeightItem.toJSON = () => renderVariableHeightItem.toString();

export default class TestList extends React.Component {
  render() {
    const props = {
      length: 2,
      itemRenderer: renderVariableHeightItem,
      type: 'variable'
    };

    return (
      <div key={1} className={`example axis-${props.axis}`}>
        Props

{JSON.stringify(props, null, 2)}

        Component

            <ReactList ref={c => this.test = c} {...props} />

      );
  }
}

I don't think I understand what you're trying to do. Could you put your example in a jsfiddle or codepen to help illustrate?

@caseywebdev https://jsfiddle.net/qsv7ct58/
As you can see list items [1,2] are positioned outside of the container div and a scroll bar is added. I've noticed that in the render function of react-list the outer most div's style is set to "position:relative;height:0;" since on the initial render height of all items is unknown.
I was wondering if this can be avoided by ignoring the incorrect height in the render function:
const size = this.getSpaceBefore(length, cache);
    if (size) {
      style[SIZE_KEYS[axis]] = size;
    }

Thanks for you time.

Could you explain what you're trying to accomplish? I removed type="variable", defaulting to the "simple" type, and your 2 list items were displayed at the bottom of the screen.

You are right in this case it's easier to use simple.


Nokia 5.1 Plus, Android 9 - solved

I have Nokia 5.1 Plus running Android 9. I disabled com.evenwell.powersaving.g3, still, all the services (mail apps, chat apps, etc) were being killed in background. Also, I could not find com.evenwell.emm in packages or DuraSpeed in logcat.
What helped me was disabling com.evenwell.batteryprotect. Since then, the services seems to be running properly.
Please keep this issue open, I'll update my findings in a few days.

Hello so far we do note have this reported, in general in our own research we did see any relation to battery protect and the background process optimizations. Can you please double check that?
We ave a complete thread on the Nokia issues here:
https://github.com/urbandroid-team/dont-kill-my-app/issues/55

Also please look here https://github.com/urbandroid-team/dont-kill-my-app/issues/55

Speaking of that, I obtained a Nokia 5.1 prototype unit few weeks ago and I found DuraSpeed option was available in the prototype build (6th option entitled with a rocket icon and Chinese word "快霸" in following screenshot).
Unfortunately I don't have more screenshots in English before I reinstalled retail firmware on it

, but I do have made a dump of emmc back then.

I have a Nokia 5.1 plus and I have used the command to disable DuraSpeed and power saver. The services working well now.
After I run the command to disable DuraSpeed it didn't give any response.

It seems that the latest update from July 5th (build number 00WW_2_16A_SP03) has completely resolved the issue for my Nokia 5.1 plus (TA-1105).

Sorry, false-positive. After a few days the phone startet killing my apps again. Don't know why it worked for a few hours after the update. Maybe an "intelligent" learning algorithm?

Somehow I managed to keep GSam Battery Monitor running without getting killed.
Just added a widget and it stays in the notification bar. Too bad AccuBattery doesn't have any widgets.

@Cybso: If your app is on external storage (SD card), try moving it to internal storage (#179).
@kohmy2036: If AccuBattery has neither a widget nor a permanent notification, it cannot be run in background and will always get killed.

I solved this problem by manually running
adb shell settings put global setting.duraspeed.enabled 2
adb shell settings put global setting.duraspeed.enabled 0

after each reboot.

Running something after each reboot is not an option for app developers out there…

I've spoke from the user's point of view.


fix(frontend): allow "constructor" property in response data

SUMMARY

Fixes #23953
Allows response JSON to be parsed with a property containing the name "constructor".
The json-bigint module has some safety options in place to prevent prototype pollution, but it prevents the queries from loading data where the columns contain constructor in the name/value. For example, test_constructor and constructor would both throw an error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

See #23953 for example query
ADDITIONAL INFORMATION

[x] Has associated issue: Fixes #23953
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks for the rebase @SpencerTorres :) Running CI now and added a few reviewers. Hopefully we can get this across the finish line and close out the issue!

looks like CI was broken on master when I pulled. Updated again

Looks like master is consistently failing to run, however I did fix a new one-line lint issue related to test code added in this commit. Updated again

CI running... fingers crossed!

Looks like CI is happy now! Re-pinging @betodealmeida @john-bodley @villebro to see if they have a moment to help with a review.

@SpencerTorres would you be able to rebase the PR? The mandatory CI workflows have changed since CI last run, causing a few of them to now be missing.

kicking off CI. Fingers crossed!


simple bot example not working

simple bot example is not working for me, on node v6.4.0

my fault, sorry...


Fix broken link to ResourceGroupArgs page

File: docs/reference/pkg/azure/core/resourcegroup.md
Link currently points to https://www.pulumi.com/docs/reference/pkg/dotnet/Pulumi.Azure/Pulumi.Azure.Core.Inputs.ResourceGroupArgs.html.  If it is only supposed to go to the section on Resource Group Arguments further down on the page, then it should be changed to an intra-document link.

Thanks for opening this issue! This will be fixed by #2820.

This is now fixed. The link for ResourceGroupArgs in the constructor will take you to the .NET docs page if you have the C# language chosen. I will go ahead and close this out now.