is it possible to install dsm 6.x into container

I tried to install DSM 6.2.3-25426 ,but there was some bugs; is it possible to do this ?

there was some error logs printed , then i got the message that the pat file couldn't install,maybe it's damaged

I'm come from china,so i'm using the PAT file : https://cndl.synology.cn/download/DSM/release/6.2.3/25426/DSM_VirtualDSM_25426.pat
but i have just tried to use the link https://global.synologydownload.com/download/DSM/release/6.2.3/25426/DSM_VirtualDSM_25426.pat,
then downloaded the PAT file by the link;I tested the docker image on tow different pc (unraid base), but got the same result ,it went wrong with the message below
[ 123.770583] blk_update_request: critical target error, dev synoboot, sector in range 45056 + 0-2(12)
[ 123.771781] Buffer I/O error on dev synoboot2, logical block in range 4096 + 0-2(12) , lost async page write
[ 123.773063] blk_update_request: critical target error, dev synoboot, sector in range 45056 + 0-2(12)
[ 123.774245] Buffer I/O error on dev synoboot2, logical block in range 8192 + 0-2(12) , lost async page write
[ 123.775550] blk_update_request: critical target error, dev synoboot, sector in range 61440 + 0-2(12)
[ 123.776732] Buffer I/O error on dev synoboot2, logical block in range 16384 + 0-2(12) , lost async page write
[ 123.778289] EXT2-fs (synoboot2): previous I/O error to superblock detected
[ 123.778289]
[ 123.779636] blk_update_request: critical target error, dev synoboot, sector in range 28672 + 0-2(12)
[ 123.780869] Buffer I/O error on dev synoboot2, logical block in range 0 + 0-2(12) , lost sync page write
[ 123.783262] EXT2-fs (synoboot2): previous I/O error to superblock detected
[ 123.783262]
[ 123.784759] blk_update_request: critical target error, dev synoboot, sector 32132
[ 123.785776] Buffer I/O error on dev synoboot2, logical block 1, lost sync page write

this is my settings when i set the dsm version 7.0.1 and it works well;

then I change the url to https://global.synologydownload.com/download/DSM/release/6.2.3/25426/DSM_VirtualDSM_25426.pat,
and i have removed all the files under the storage path,

,the pictures above  are the result after I tried to install the dsm with PAT file
ps: this is my first pc

this is my second pc

if i don't change any thing , it works well;
if i change the version to dsm 6.x ,i can't  install like the first pc and get the error logs above;
the settings :

ps: the image version is kroese/virtual-dsm:latest, the same between two pc

the reason that i run the container with privileged  is the  permission of data.img  is 644 , so i think the error maybe caused by the container running without root permision;
I have tried the settings that you said, and unfortunately，it doesn't work;
thanks for you help, i'll try to build a pc like your pc,and set up a container again;if it works ,i'll copy all of the files under the data path,then share these files to other containers, like a template。

I have tried to run the container again on a virtual ubuntu on unraid with ext4 disk format ,and it works well;
The disk format type of /mnt/users/domains/dsm is xfs,so i also tried to run the container on a centos virtual pc with xfs disk format, but the dhcp went wrong，and the dsm in the container got the ip <IP_ADDRESS> which couldn't access from outside;
Maybe the errors before were caused by the xfs disk format , I'll try to run the container on the disk  which is formatted to btrfs  which unRaid cache disk's format is that 。
Thanks for your help!


Implement Nonhydrostatic2DModel

closes #91.
This PR added the nonhydrostatic 2D model for the hybrid plane, and added a unit test for the rising bubble benchmark.

This is ready for review.

bors try

Looks great! I left a few comments. I saw the link to #110 has been removed - is it because the regression and validation tests haven't been set up?

Looks great! I left a few comments. I saw the link to #110 has been removed - is it because the regression and validation tests haven't been set up?

Yep, this PR only add RTB to unit test making sure it does bot break. Let's add the rest in a separate PR ;)

bors r+


Changing display rate should not change target rates

Currently, if a user enters a target rate of, e.g., 2 items/minute, and then changes the display rate to items/second, it will change the target rate to 2 items/second.
The underlying rate should remain unchanged when the display rate is changed, and the text in the "rate" boxes should be updated after the unit conversion.

Done in d69cced08197db2ba640e7f42994fcdc321269b7.


Distribution files for 2.2.5 have incorrect version number

In version 2.2.5, the headers for both svg.js and svg.min.js list the version as 2.2.4.
package.json and other tracking files have the correct version.

Yes I missed to run the final gulp before committing. Since this will be
fixes with the next commit I didn't change it :)
snowyplover<EMAIL_ADDRESS>schrieb am Sa., 09.01.2016, 10:52:

In version 225, the headers for both svgjs and svgminjs list the version
as 224
packagejson and other tracking files have the correct version
—
Reply to this email directly or view it on GitHub
https://github.com/wout/svg.js/issues/436.

Ah, I figured that must have been what happened.
While mislabeled files won't break user code, they can puzzle a human that pulls up the file (as happened to me), and could perhaps confuse automated versioning code somewhere.
My interpretation of the Semantic Versioning rules is that such mislabeled files count as "backwards incompatible changes" -- which, in a sense, they actually are. The way to deal with this might be to follow the part in the Semver FAQ concerning "What do I do if I accidentally release a backwards incompatible change as a minor version?" In other words, a new version could be released (just a patch in this case) that only

fixes the version number, and
adds a comment (to CHANGELOG.md, I guess) warning against using the invalid version

Anyway, that's my proposal. It is possible I'm just weird, though... :)

As far as I know a Backwards incompatible change is something which breaks the api which means methods and parameters are changing. This is not the case when just a comment is missplaced :D.
Maybe that is just my interpretation but since all packe manager will pull the right version anyway I didnt spend much time on something like this.
The Version number is generated when gulp is run which i accidentially missed after changing package.json. Its more or less a userinfo - in my opinion not worth a bugfix :P.

I suppose I am taking "backwards incompatible change" as having the intent of something like "any change that breaks the (admittedly subjective, in part) contract between dev and user". But if all the package managers are happy, I suppose there's nothing to worry about.
In any case, I can certainly understand the choice that this is not worth bothering with.

Next update will be soon so I will close that for now :)


MPL drawer displaying pi in decimal format if operated with a parameter

Information

Qiskit Terra version: 0.12.0
Python version: 3.7.6
Operating system: MacOS Catalina 10.15.3

What is the current behavior?
When drawing a circuit containing a gate such as qcircuit.u3(theta, eta-pi/2, pi/2, q[0]), the second variable is displayed as in latex $\eta-1.5707$ instead of $\eta-\pi/2$.
Steps to reproduce the problem
Plot a circuit containing qcircuit.u3(theta, eta-pi/2, pi/2, q[0]).
What is the expected behavior?
The second variable should be displayed as in latex $\eta-\pi/2$.

It seems like a https://github.com/Qiskit/qiskit-terra/pull/3666 needs to get deeper. What to have a look @sumitpuri?

Sure @1ucian0 is there a bug again?

@pedrorrivero Can you paste the code and your result.

Excuse my late response, I missed the notification.
## IMPORTS
from qiskit import *
from qiskit.circuit import Parameter
from numpy import pi

## QUANTUM CIRCUIT
q = QuantumRegister(1, 'q')
U = QuantumCircuit(q)

# State parametrization
theta = Parameter('$θ$')
eta = Parameter('$\eta$')
U.u3(theta, eta-pi/2, pi/2, q[0])

# Draw circuit
U.draw(output='mpl')

This is the same as #4170.

Fixed via #4807


Image Upload Funtion Not Run | Apply Button Remain Disabled After Uploading The Image

I am using the latest version of this library which 2.5.2 but still got the same problem. Console shows that image uploaded but Apply button remain disabled. However if I insert image link then it works fine but unable to upload file manually from computer.
Here is my code:
import { VuetifyTiptap } from "vuetify-pro-tiptap";
import "vuetify-pro-tiptap/style.css";
import { BaseKit, Image } from "vuetify-pro-tiptap";
const extensions = [
  BaseKit.configure({
    placeholder: {
      placeholder: "Write some text...",
    },
  }),
  Image.configure({
    upload(file) {
      console.log(file);
    },
  }),
];

const content = ref('')
Here is the template code i am using editor inside a vuetify modal/dialog:
                                                        <v-col cols="12" md="12" sm="12">
                                                            <!-- <v-textarea v-model="editedBody.body" label="Body"
                                                                rows="5"></v-textarea> -->
                                                            <VApp id="app">
                                                                <VContainer>
                                                                    <VuetifyTiptap v-model="content" label="Title"
                                                                        rounded :min-height="200" :max-height="465"
                                                                        :max-width="900" :extensions="extensions" />

                                                                </VContainer>
                                                            </VApp>
                                                        </v-col>

You need to return a Promise<string> for the upload function. You can try to simulate it like this:
Image.configure({
  upload(file: File) {
    const url = URL.createObjectURL(file);
    console.log('mock upload api :>> ', url);
    return Promise.resolve(url);
  }
})


Enhance client cache support in Gardenlet

How to categorize this PR?

/area performance robustness cost scalability
/kind enhancement
What this PR does / why we need it:
This PR adds a new cache SingleObject which can be used to built and start caches for individual objects - based in their object key. Gardenlet makes use of this new feature for object kinds that couldn't be cached for security reasons (see linked issue).
Which issue(s) this PR fixes:
Fixes #7593
Special notes for your reviewer:
Co-authored-by: Rafael Franzke<EMAIL_ADDRESS>Release note:

`gardenlet`'s cache support has been enhanced to virtually all object kinds it requires from the Gardener API server. Earlier, objects like `ShootState`s, `Project`s, `SecretBinding`s, `ControllerDeployment`s, etc. couldn't be cached for security reasons. Especially in large landscapes, this enhancement will lead to less load on the Gardener API server besides reducing the overall network traffic.

/assign

/retest

It took a while for me to check this. However,... 😄
/lgtm
/retest

There might be something wrong with the cache.
All e2e seem to fail when deleting the shoots. I see plenty of errors like s: "shoot \"e2e-hibernated\" still exists"

Thanks @oliver-goetz. I will have a look later.

The shoot namespace is stuck in terminating state. This is because gardenlet is not able to remove the finalizers of several secrets (apparently because the shoot state is gone)
This is an excerpt of my gardenlet logs when deleting a shoot in my local setup
{"level":"info","ts":"2023-03-15T10:08:03.060Z","msg":"Succeeded","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c291484b-5afd-495e-9113-7415b5cbd04c","operation":"delete","flow":"Shoot cluster deletion","task":"Destroying internal domain DNS record"}
{"level":"info","ts":"2023-03-15T10:08:03.068Z","msg":"Succeeded","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c291484b-5afd-495e-9113-7415b5cbd04c","operation":"delete","flow":"Shoot cluster deletion","task":"Deleting shoot namespace in Seed"}
{"level":"info","ts":"2023-03-15T10:08:03.085Z","msg":"Waiting until the namespace has been cleaned up and deleted in the Seed cluster","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c291484b-5afd-495e-9113-7415b5cbd04c","operation":"delete","namespaceName":"shoot--local--local"}
{"level":"info","ts":"2023-03-15T10:08:03.160Z","msg":"Succeeded","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c291484b-5afd-495e-9113-7415b5cbd04c","operation":"delete","flow":"Shoot cluster deletion","task":"Deleting Shoot State"}
{"level":"info","ts":"2023-03-15T10:08:08.085Z","msg":"Waiting until the namespace has been cleaned up and deleted in the Seed cluster","controller":"shoot","object":{"name":"local","namespace":"garden-local"},"namespace":"garden-local","name":"local","reconcileID":"c291484b-5afd-495e-9113-7415b5cbd04c","operation":"delete","namespaceName":"shoot--local--local"}
{"level":"info","ts":"2023-03-15T10:08:08.176Z","msg":"Removing Secret from ShootState and releasing its finalizer","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca","reconcileID":"b491d6c8-f35f-4b68-93a7-be30a5ef5e7d"}
{"level":"info","ts":"2023-03-15T10:08:08.188Z","msg":"Removing Secret from ShootState and releasing its finalizer","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-client-58f8e9ac","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-client-58f8e9ac","reconcileID":"85e5b34c-4120-4091-bd37-cd8e3ce634cf"}
{"level":"error","ts":"2023-03-15T10:08:08.189Z","msg":"Reconciler error","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca","reconcileID":"b491d6c8-f35f-4b68-93a7-be30a5ef5e7d","error":"shootstates.core.gardener.cloud \"local\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235"}
{"level":"info","ts":"2023-03-15T10:08:08.195Z","msg":"Removing Secret from ShootState and releasing its finalizer","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca","reconcileID":"1ddc9a1c-4838-4298-879f-f5a127f7b100"}
{"level":"error","ts":"2023-03-15T10:08:08.201Z","msg":"Reconciler error","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-client-58f8e9ac","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-client-58f8e9ac","reconcileID":"85e5b34c-4120-4091-bd37-cd8e3ce634cf","error":"shootstates.core.gardener.cloud \"local\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235"}
{"level":"info","ts":"2023-03-15T10:08:08.202Z","msg":"Removing Secret from ShootState and releasing its finalizer","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-etcd","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-etcd","reconcileID":"7bf94fc0-1ae1-4c3c-9ba1-7610b488af93"}
{"level":"info","ts":"2023-03-15T10:08:08.208Z","msg":"Removing Secret from ShootState and releasing its finalizer","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-client-58f8e9ac","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-client-58f8e9ac","reconcileID":"115b6247-6c31-49af-9c86-66ca912550cd"}
{"level":"error","ts":"2023-03-15T10:08:08.209Z","msg":"Reconciler error","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca","reconcileID":"1ddc9a1c-4838-4298-879f-f5a127f7b100","error":"shootstates.core.gardener.cloud \"local\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235"}
{"level":"error","ts":"2023-03-15T10:08:08.218Z","msg":"Reconciler error","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-etcd","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-etcd","reconcileID":"7bf94fc0-1ae1-4c3c-9ba1-7610b488af93","error":"shootstates.core.gardener.cloud \"local\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235"}
{"level":"error","ts":"2023-03-15T10:08:08.219Z","msg":"Reconciler error","controller":"shootstate-secret","controllerGroup":"","controllerKind":"Secret","Secret":{"name":"ca-client-58f8e9ac","namespace":"shoot--local--local"},"namespace":"shoot--local--local","name":"ca-client-58f8e9ac","reconcileID":"115b6247-6c31-49af-9c86-66ca912550cd","error":"shootstates.core.gardener.cloud \"local\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235"}

/hold
because of failing tests. I could reproduce the issue locally when deleting a hibernated shoot cluster. We're still investigating together with @rfranzke.

/unhold

/cla

/lgtm

okay, so let's go 🥳
/lgtm
/approve


TestFillAligned fails with -O1

https://github.com/hajimehoshi/go2cpp/runs/1610960823
TestPallocDataFindScavengeCandidate/SkipMisalignedMin64 also fails

Some operators around bits seem suspicious.

Minimized test case:
package foo_test

import (
        "testing"
)

func fillAligned(x uint64) uint64 {
        const m = 64

        apply := func(x uint64, c uint64) uint64 {
                return ^((((x & c) + c) | x) | c)
        }
        x = apply(x, 0x7fffffffffffffff)
        return ^((x - (x >> (m - 1))) | x)
}

func TestFoo(t *testing.T) {
        got := fillAligned(1)
        const want uint64 =<PHONE_NUMBER>3709551615
        if got != want {
                t.Fatalf("got: %v, want: %v", got, want)
        }
}

Further minimized
package foo_test

import (
        "testing"
)

func foo(x uint64) uint64 {
        const c uint64 = 0x7fffffffffffffff

        return ^((((x & c) + c) | x) | c)
}

func TestFoo(t *testing.T) {
        got := foo(1)
        const want = 0
        if got != want {
                t.Fatalf("got: %v, want: %v", got, want)
        }
}

Further minimized case:
package foo_test

import (
        "testing"
)

func foo(x uint64) uint64 {
        const m = 64

        // Use a function to avoid optimization
        apply := func(x uint64, c uint64) uint64 {
                return (((x & c) + c) | x) | c
        }
        return apply(x, 0x7fffffffffffffff)
}

func TestFoo(t *testing.T) {
        got := foo(1)
        const want uint64 =<PHONE_NUMBER>3709551615
        if got != want {
                t.Fatalf("got: %v, want: %v", got, want)
        }
}

https://wandbox.org/permlink/hVrp7lTO3k9Cevht
The result varies by the optimization??


digest: Only send digest emails once a week.

Currently the digest emails are both not very good and are sent very often. This encourages people to unsubscribe from digest emails.
Until we have time to improve our digest emails, we should reduce the frequency to once a week. The main file to start with is enqueue_digest_emails.py.
Also linking to #549, which is sort of related.

In enqueue_digest_emails.py the logic is tied to business days (tues/wed/thurs) - when you say 'a week', should that be a function of how many business days have passed, or should the logic just be to check if it's been >= 7 days and it's also business day?

I think aiming for every Tuesday is reasonable.

or should the logic just be to check if it's been >= 7 days and it's also business day?

Do we keep track of enough information to do this? (e.g. whether we already sent someone a digest in the last few days?)

No, just the number of days a user has been inactive.

Oh another thing I noticed: that file has VALID_DIGEST_DAYS = (1, 2, 3, 4) which means emails are actually being sent on tues-fri, not tues-thurs as the comments of handle suggest.

cool. Sending once a week on Tuesday if they've been inactive for the last 5 days seems reasonable.

@zulipbot claim


Syntax Error when generating models

When running amplify codegen models I get the following (amplify codegen works fine)...note 'repeatable' does not occur in my schema, so not sure where this is coming from..
GraphQL schema compiled successfully.
Edit your schema at /Users/georgebell/Code/mobile/amplify/backend/api/jcmobile/schema.graphql or place .graphql files in a directory at /Users/georgebell/Code/mobile/amplify/backend/api/jcmobile/schema
Syntax Error: Expected "on", found Name "repeatable"
GraphQLError: Syntax Error: Expected "on", found Name "repeatable"
at syntaxError (/Users/georgebell/Code/mobile/node_modules/graphql/error/syntaxError.js:24:10)
at expectKeyword (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:1480:32)
at parseDirectiveDefinition (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:1330:3)
at parseTypeSystemDefinition (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:739:16)
at parseDefinition (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:142:16)
at many (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:1523:16)
at parseDocument (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:113:18)
at Object.parse (/Users/georgebell/Code/mobile/node_modules/graphql/language/parser.js:48:10)
at /Users/georgebell/Code/mobile/node_modules/@graphql-codegen/core/node_modules/@graphql-toolkit/schema-merging/src/typedefs-mergers/merge-typedefs.ts:199:16
at Array.map ()

This seems to be related to Amplify CLI. Transferring issue to them

Can you post the schema.graphql?

schema.graphql.zip

this works with<EMAIL_ADDRESS>does not work with @2.15.5

@GeorgeBellTMH just to clarify, you came across this error when running npx amplify-app?

Please comment if you are still facing this


Want to have multiple geoJson Overlay

Dear all,
based on  folium Timestamped GeoJSON macro i want to have 2 geoJSON Layer on one map to have it selectable via the layerControl. But actually it creates two time sliders and it is not selectable via the layerControl.
On the following way both layers were added to the map:
L.timeDimension.layer.geoJson(geoJsonLayer,
                {updateTimeDimension: false,
                }).addTo(base_map)

The existend folium code is now taken layer_name and the layer object of all children from the parent map (base_map),  And to have the geoJSON as an overlay I guess I need to define a layer_name. But this property is not available
Any ideas or solutions?

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.
If you are really sure that this is a bug in leaflet, or a feature request, please change the wording to make it look like a bug report.

@IvanSanchez than please change the settings of the tracker board and delete the Support category.


make sysinstall: fatal error: 'Python.h' file not found

Mac OS 10.11.3 (15D21)
marc@osx ~ $ pyvenv myenv
marc@osx ~ $ source myenv/bin/activate
(myenv) marc@osx ~/bude/neon (master*) $ python --version
Python 3.5.2
(myenv) marc@osx ~ $ cd bude/
(myenv) marc@osx ~ $ git clone https://github.com/NervanaSystems/neon.git
(myenv) marc@osx ~ $ cd neon
(myenv) marc@osx ~/bude/neon (master*) $ make sysinstall
Installing neon dependencies system wide...
Collecting cython==0.23.1
  Using cached Cython-0.23.1.tar.gz
Installing collected packages: cython
  Running setup.py install for cython ... done
Successfully installed cython-0.23.1
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting configargparse==0.9.3 (from -r requirements.txt (line 1))
  Using cached ConfigArgParse-0.9.3.tar.gz
Collecting numpy==1.9.2 (from -r requirements.txt (line 2))
  Using cached numpy-1.9.2.zip
Collecting pyyaml==3.11 (from -r requirements.txt (line 3))
  Using cached PyYAML-3.11.zip
Collecting pep8==1.7.0 (from -r requirements.txt (line 4))
  Using cached pep8-1.7.0-py2.py3-none-any.whl
Collecting flake8==2.4.1 (from -r requirements.txt (line 5))
  Using cached flake8-2.4.1-py2.py3-none-any.whl
Collecting pytest==2.7.3 (from -r requirements.txt (line 6))
  Using cached pytest-2.7.3-py2.py3-none-any.whl
Collecting pytest-cov==2.0.0 (from -r requirements.txt (line 7))
  Using cached pytest_cov-2.0.0-py2.py3-none-any.whl
Collecting posix-ipc==1.0.0 (from -r requirements.txt (line 8))
  Using cached posix_ipc-1.0.0.tar.gz
Collecting pillow==2.9.0 (from -r requirements.txt (line 9))
  Using cached Pillow-2.9.0.zip
Collecting pylint==1.5.5 (from -r requirements.txt (line 10))
  Using cached pylint-1.5.5-py2.py3-none-any.whl
Collecting sphinx==1.3.1 (from -r requirements.txt (line 11))
  Using cached Sphinx-1.3.1-py2.py3-none-any.whl
Collecting h5py==2.5.0 (from -r requirements.txt (line 12))
  Using cached h5py-2.5.0-cp35-cp35m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting appdirs==1.4.0 (from -r requirements.txt (line 13))
  Using cached appdirs-1.4.0-py2.py3-none-any.whl
Collecting future==0.15.2 (from -r requirements.txt (line 14))
  Using cached future-0.15.2.tar.gz
Collecting pyflakes<0.9,>=0.8.1 (from flake8==2.4.1->-r requirements.txt (line 5))
  Using cached pyflakes-0.8.1-py2.py3-none-any.whl
Collecting mccabe<0.4,>=0.2.1 (from flake8==2.4.1->-r requirements.txt (line 5))
  Using cached mccabe-0.3.1-py2.py3-none-any.whl
Collecting py>=1.4.29 (from pytest==2.7.3->-r requirements.txt (line 6))
  Using cached py-1.4.31-py2.py3-none-any.whl
Collecting coverage>=3.7.1 (from pytest-cov==2.0.0->-r requirements.txt (line 7))
  Using cached coverage-4.2-cp35-cp35m-macosx_10_10_x86_64.whl
Collecting colorama (from pylint==1.5.5->-r requirements.txt (line 10))
  Using cached colorama-0.3.7-py2.py3-none-any.whl
Collecting six (from pylint==1.5.5->-r requirements.txt (line 10))
  Using cached six-1.10.0-py2.py3-none-any.whl
Collecting astroid<1.5.0,>=1.4.5 (from pylint==1.5.5->-r requirements.txt (line 10))
  Using cached astroid-1.4.8-py2.py3-none-any.whl
Collecting Jinja2>=2.3 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached Jinja2-2.8-py2.py3-none-any.whl
Collecting babel>=1.3 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached Babel-2.3.4-py2.py3-none-any.whl
Collecting docutils>=0.11 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached docutils-0.12-py3-none-any.whl
Collecting snowballstemmer>=1.1 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached snowballstemmer-1.2.1-py2.py3-none-any.whl
Collecting sphinx-rtd-theme<0.2,>=0.1 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached sphinx_rtd_theme-0.1.9-py3-none-any.whl
Collecting alabaster<0.8,>=0.7 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached alabaster-0.7.9-py2.py3-none-any.whl
Collecting Pygments>=2.0 (from sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached Pygments-2.1.3-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): Cython>=0.17 in /Users/marc/myenv/lib/python3.5/site-packages (from h5py==2.5.0->-r requirements.txt (line 12))
Collecting wrapt (from astroid<1.5.0,>=1.4.5->pylint==1.5.5->-r requirements.txt (line 10))
  Using cached wrapt-1.10.8.tar.gz
Collecting lazy-object-proxy (from astroid<1.5.0,>=1.4.5->pylint==1.5.5->-r requirements.txt (line 10))
  Using cached lazy-object-proxy-1.2.2.tar.gz
Collecting MarkupSafe (from Jinja2>=2.3->sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached MarkupSafe-0.23.tar.gz
Collecting pytz>=0a (from babel>=1.3->sphinx==1.3.1->-r requirements.txt (line 11))
  Using cached pytz-2016.6.1-py2.py3-none-any.whl
Installing collected packages: configargparse, numpy, pyyaml, pep8, pyflakes, mccabe, flake8, py, pytest, coverage, pytest-cov, posix-ipc, pillow, colorama, six, wrapt, lazy-object-proxy, astroid, pylint, MarkupSafe, Jinja2, pytz, babel, docutils, snowballstemmer, sphinx-rtd-theme, alabaster, Pygments, sphinx, h5py, appdirs, future
  Running setup.py install for configargparse ... done
  Running setup.py install for numpy ... error
    Complete output from command /Users/marc/myenv/bin/python3.5 -u -c "import setuptools, tokenize;__file__='/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-ik09d_fe-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/marc/myenv/include/site/python3.5/numpy:
    Running from numpy source directory.
    non-existing path in 'numpy/distutils': 'site.cfg'
    non-existing path in 'numpy/f2py': 'docs'
    non-existing path in 'numpy/f2py': 'f2py.1'
    F2PY Version 2
    blas_opt_info:
    blas_mkl_info:
      libraries mkl,vml,guide not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    openblas_info:
      libraries openblas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    atlas_3_10_blas_threads_info:
    Setting PTATLAS=ATLAS
      libraries tatlas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    atlas_3_10_blas_info:
      libraries satlas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    atlas_blas_threads_info:
    Setting PTATLAS=ATLAS
      libraries ptf77blas,ptcblas,atlas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    atlas_blas_info:
      libraries f77blas,cblas,atlas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

      FOUND:
        extra_compile_args = ['-msse3', '-DAPPLE_ACCELERATE_SGEMV_PATCH', '-I/System/Library/Frameworks/vecLib.framework/Headers']
        extra_link_args = ['-Wl,-framework', '-Wl,Accelerate']
        define_macros = [('NO_ATLAS_INFO', 3)]

    non-existing path in 'numpy/lib': 'benchmarks'
    lapack_opt_info:
    openblas_lapack_info:
      libraries openblas not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

    lapack_mkl_info:
    mkl_info:
      libraries mkl,vml,guide not found in ['/Users/marc/myenv/lib', '/usr/local/lib', '/usr/lib', '/usr/lib/']
      NOT AVAILABLE

      NOT AVAILABLE

    atlas_3_10_threads_info:
    Setting PTATLAS=ATLAS
      libraries tatlas,tatlas not found in /Users/marc/myenv/lib
      libraries lapack_atlas not found in /Users/marc/myenv/lib
      libraries tatlas,tatlas not found in /usr/local/lib
      libraries lapack_atlas not found in /usr/local/lib
      libraries tatlas,tatlas not found in /usr/lib
      libraries lapack_atlas not found in /usr/lib
      libraries tatlas,tatlas not found in /usr/lib/
      libraries lapack_atlas not found in /usr/lib/
    <class 'numpy.distutils.system_info.atlas_3_10_threads_info'>
      NOT AVAILABLE

    atlas_3_10_info:
      libraries satlas,satlas not found in /Users/marc/myenv/lib
      libraries lapack_atlas not found in /Users/marc/myenv/lib
      libraries satlas,satlas not found in /usr/local/lib
      libraries lapack_atlas not found in /usr/local/lib
      libraries satlas,satlas not found in /usr/lib
      libraries lapack_atlas not found in /usr/lib
      libraries satlas,satlas not found in /usr/lib/
      libraries lapack_atlas not found in /usr/lib/
    <class 'numpy.distutils.system_info.atlas_3_10_info'>
      NOT AVAILABLE

    atlas_threads_info:
    Setting PTATLAS=ATLAS
      libraries ptf77blas,ptcblas,atlas not found in /Users/marc/myenv/lib
      libraries lapack_atlas not found in /Users/marc/myenv/lib
      libraries ptf77blas,ptcblas,atlas not found in /usr/local/lib
      libraries lapack_atlas not found in /usr/local/lib
      libraries ptf77blas,ptcblas,atlas not found in /usr/lib
      libraries lapack_atlas not found in /usr/lib
      libraries ptf77blas,ptcblas,atlas not found in /usr/lib/
      libraries lapack_atlas not found in /usr/lib/
    <class 'numpy.distutils.system_info.atlas_threads_info'>
      NOT AVAILABLE

    atlas_info:
      libraries f77blas,cblas,atlas not found in /Users/marc/myenv/lib
      libraries lapack_atlas not found in /Users/marc/myenv/lib
      libraries f77blas,cblas,atlas not found in /usr/local/lib
      libraries lapack_atlas not found in /usr/local/lib
      libraries f77blas,cblas,atlas not found in /usr/lib
      libraries lapack_atlas not found in /usr/lib
      libraries f77blas,cblas,atlas not found in /usr/lib/
      libraries lapack_atlas not found in /usr/lib/
    <class 'numpy.distutils.system_info.atlas_info'>
      NOT AVAILABLE

      FOUND:
        extra_compile_args = ['-msse3', '-DAPPLE_ACCELERATE_SGEMV_PATCH']
        extra_link_args = ['-Wl,-framework', '-Wl,Accelerate']
        define_macros = [('NO_ATLAS_INFO', 3)]

    /usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'define_macros'
      warnings.warn(msg)
    running install
    running build
    running config_cc
    unifing config_cc, config, build_clib, build_ext, build commands --compiler options
    running config_fc
    unifing config_fc, config, build_clib, build_ext, build commands --fcompiler options
    running build_src
    build_src
    building py_modules sources
    creating build
    creating build/src.macosx-10.11-x86_64-3.5
    creating build/src.macosx-10.11-x86_64-3.5/numpy
    creating build/src.macosx-10.11-x86_64-3.5/numpy/distutils
    building library "npymath" sources
    customize Gnu95FCompiler
    Found executable /usr/local/bin/gfortran
    customize Gnu95FCompiler
    customize Gnu95FCompiler using config
    C compiler: clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes

    compile options: '-Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -c'
    clang: _configtest.c
    clang _configtest.o -o _configtest
    success!
    removing: _configtest.c _configtest.o _configtest
    C compiler: clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes

    compile options: '-Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -c'
    clang: _configtest.c
    _configtest.c:1:5: warning: incompatible redeclaration of library function 'exp' [-Wincompatible-library-redeclaration]
    int exp (void);
        ^
    _configtest.c:1:5: note: 'exp' is a builtin with type 'double (double)'
    1 warning generated.
    clang _configtest.o -o _configtest
    success!
    removing: _configtest.c _configtest.o _configtest
    creating build/src.macosx-10.11-x86_64-3.5/numpy/core
    creating build/src.macosx-10.11-x86_64-3.5/numpy/core/src
    creating build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npymath
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npymath/npy_math.c
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npymath/ieee754.c
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npymath/npy_math_complex.c
    building library "npysort" sources
    creating build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort/quicksort.c
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort/mergesort.c
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort/heapsort.c
    creating build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private/npy_partition.h
      adding 'build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private' to include_dirs.
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort/selection.c
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private/npy_binsearch.h
    conv_template:> build/src.macosx-10.11-x86_64-3.5/numpy/core/src/npysort/binsearch.c
    None - nothing done with h_files = ['build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private/npy_partition.h', 'build/src.macosx-10.11-x86_64-3.5/numpy/core/src/private/npy_binsearch.h']
    building extension "numpy.core._dummy" sources
    Generating build/src.macosx-10.11-x86_64-3.5/numpy/core/include/numpy/config.h
    C compiler: clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes

    compile options: '-Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/include -c'
    clang: _configtest.c
    _configtest.c:1:10: fatal error: 'Python.h' file not found
    #include <Python.h>
             ^
    1 error generated.
    _configtest.c:1:10: fatal error: 'Python.h' file not found
    #include <Python.h>
             ^
    1 error generated.
    failure.
    removing: _configtest.c _configtest.o
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/setup.py", line 251, in <module>
        setup_package()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/setup.py", line 243, in setup_package
        setup(**metadata)
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/core.py", line 169, in setup
        return old_setup(**new_attr)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/dist.py", line 955, in run_commands
        self.run_command(cmd)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/install.py", line 62, in run
        r = self.setuptools_run()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/install.py", line 36, in setuptools_run
        return distutils_install.run(self)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/command/install.py", line 539, in run
        self.run_command('build')
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/build.py", line 39, in run
        old_build.run(self)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/command/build.py", line 135, in run
        self.run_command(cmd_name)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/usr/local/Cellar/python3/3.5.2_1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/distutils/dist.py", line 974, in run_command
        cmd_obj.run()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/build_src.py", line 153, in run
        self.build_sources()
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/build_src.py", line 170, in build_sources
        self.build_extension_sources(ext)
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/build_src.py", line 329, in build_extension_sources
        sources = self.generate_sources(sources, ext)
      File "/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/numpy/distutils/command/build_src.py", line 386, in generate_sources
        source = func(extension, build_dir)
      File "numpy/core/setup.py", line 432, in generate_config_h
        moredefs, ignored = cocache.check_types(config_cmd, ext, build_dir)
      File "numpy/core/setup.py", line 42, in check_types
        out = check_types(*a, **kw)
      File "numpy/core/setup.py", line 293, in check_types
        "Cannot compile 'Python.h'. Perhaps you need to "\
    SystemError: Cannot compile 'Python.h'. Perhaps you need to install python-dev|python-devel.

    ----------------------------------------
Command "/Users/marc/myenv/bin/python3.5 -u -c "import setuptools, tokenize;__file__='/private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-ik09d_fe-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/marc/myenv/include/site/python3.5/numpy" failed with error code 1 in /private/var/folders/rv/9j67xvf11h33ydhbhk6plgq00000gn/T/pip-build-m_o587dr/numpy/
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
make: *** [sysdeps] Error 1

Note: without venv it works. However, I don't want to install neon globally. Any ideas why I'm not able to install numpy using your build script? Installing numpy using pip install numpy works in the venv.

Hi Marcj,
According to https://github.com/Homebrew/legacy-homebrew/issues/43916 it looks like this issue was fixed in Numpy 1.9.3.
You should be able to install if you edit the version of numpy in neon/requirements.txt, changing:
numpy==1.9.2
to
numpy==1.9.3
Then rerun make.
This should be fixed also once we release neon 1.6, as we will be bringing numpy up-to-date in this release.

Closing this issue as fixed in neon 1.6.0.


test [nfc]: Introduce "finish" helper for async checks

This brings the file test/api/core_test.dart up to being clean against the unawaited_futures lint rule, toward #731.
It does so with a smaller diff, and simpler resulting code, than by adding await on each of the futures.  For comparison:
https://github.com/zulip/zulip-flutter/pull/934#discussion_r1788454470

Looks like there is an issue with the dependency:
info • The imported package 'test_api' isn't a dependency of the importing package • test/test_async.dart:1:8 • depend_on_referenced_packages

Oops, thanks. I had a commit for that but it was missing from the PR branch — I think I must have accidentally dropped it when moving the changes to an independent branch, after developing them on top of #934.
Should be fixed now.

LGTM! Should be ready to merge then.


fix: avoid the padding of last data shard is not zero

if len(data) > (r.Shards * perShard), it will use the remaing space of data to padding the last shard, if these value of data is not zero, the padding will is not zero too.
if you have some good ideas, please give me some suggestions, thanks.

Thanks. Looks fine.


Module dependency error when combined with other projectdiscovery projects

When compiling katana with other projectdiscovery projects, a module dependency error is generated with the following error message.

I think this is because katana is using github.com/projectdiscovery/utils module 0.0.4, while other projectdiscovery projects are using the latest 0.0.6 version, and some code has changed between these two versions,which causes katana to compile the relevant code with an error. Can the developer update the code so that katana can use the latest utils library so that it can be integrated with other projectdiscovery projects?

Thank you for your efficient handling, in fact this problem exists on many projectdiscovery projects and I have mentioned issuse on some of them, but it is tiresome to keep replicating similar problems in each project, I would like to ask projectdiscovery if it is possible to update the dependency libraries used by these tools in a uniform way?

@nbxiglk0  , it was a troublesome but needed change if you are not aware of it we fixed lot of  url edgecases in nuclei https://github.com/projectdiscovery/nuclei/pull/3211 . not sure why you are facing this error but usually try to limit visibility of any such changes .  are you perhaps using them as library ??
I am not able to reproduce this with pdtm  tool or via direct installation of katana using go xx

but thanks for bringing this to attention . we will try to fix any such broken packages if we have missed them ASAP

https://github.com/projectdiscovery/subfinder/issues/752
https://github.com/projectdiscovery/httpx/issues/958
This is the issuse I created in other projects, want to reproduce the problem is very simple, you just need to subfinder,httpx,naabu,nuclei,shuffledns as libraries in a go project reference compile will get the conflicting code location, I described the problem in discord channel unified, you can check the post.
https://discord.com/channels/695645237418131507/1072060036475523072.


Switch master to Einstein release-train

This will be based on top of Spring Boot 2.1/SCSt 2.1 stack.
Relates to #165

Closing this in favor of #165.


Hero size abnormally changes when the keyboard is open with HeroControllerScope and nested navigation

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Paste the code sample into main.dart in an empty Flutter project.
Run it with iOS simulator or Android emulator.
Tap the search bar and press the back icon after hero animation.

Expected results
Widget size to stay the same.
Actual results
As seen in the videos below, Material widget is shrinking down for a split second on forward transition, and expands abnormally on reverse transition.
This issue only occurs when the soft keyboard is open, or while opening/closing.
And I belive it is related to HeroControllerScope and nested navigation, because it does not happen without them. You can also verify this by changing home property of the app to FirstPage().
There is also another issue where the soft keyboard is opening, closing and reopening in android, and I'm aware that it is being discussed at #106789.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Flutter Playground',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: HeroControllerScope(
        controller: MaterialApp.createMaterialHeroController(),
        child: Navigator(
          onGenerateRoute: (settings) {
            return MaterialPageRoute(builder: (context) => const FirstPage());
          },
        ),
      ),
      bottomNavigationBar: BottomNavigationBar(
        items: const [
          BottomNavigationBarItem(
            icon: Icon(Icons.home),
            label: 'Home',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.search),
            label: 'Search',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.person),
            label: 'Profile',
          ),
        ],
      ),
    );
  }
}

class FirstPage extends StatelessWidget {
  const FirstPage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(16),
          child: GestureDetector(
            behavior: HitTestBehavior.opaque,
            onTap: () {
              Navigator.of(context).push(
                PageRouteBuilder(
                  pageBuilder: (context, animation, secondaryAnimation) =>
                      const SecondPage(),
                  transitionDuration: const Duration(seconds: 1),
                  reverseTransitionDuration: const Duration(seconds: 1),
                  transitionsBuilder:
                      (context, animation, secondaryAnimation, child) {
                    final tween = Tween(begin: 0.0, end: 1.0);
                    final fadeAnimation = animation.drive(tween);
                    return FadeTransition(
                      opacity: fadeAnimation,
                      child: child,
                    );
                  },
                ),
              );
            },
            child: const Hero(
              tag: 'search_field',
              child: Material(
                color: Colors.black12,
                child: TextField(
                  enabled: false,
                  decoration: InputDecoration(
                    prefixIcon: Icon(Icons.search),
                    hintText: 'Type something...',
                  ),
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

class SecondPage extends StatelessWidget {
  const SecondPage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Padding(
          padding: const EdgeInsets.all(16),
          child: Hero(
            tag: 'search_field',
            child: Material(
              color: Colors.black12,
              child: TextField(
                autofocus: true,
                decoration: InputDecoration(
                  prefixIcon: IconButton(
                    onPressed: Navigator.of(context).pop,
                    icon: const Icon(Icons.arrow_back),
                  ),
                  hintText: 'Type something...',
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/45076094/1ae59f94-642f-470d-81ad-e56eb1684bc1
android.webm

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.3, on macOS 13.5.1 22G90 darwin-arm64, locale en-TR)
    • Flutter version 3.13.3 on channel stable at /Users/rasitayaz/Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (7 days ago), 2023-09-06 14:32:31 -0700
    • Engine revision b8d35810e9
    • Dart version 3.1.1
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/rasitayaz/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.82.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        • android-arm64  • Android 13 (API 33) (emulator)
    • iPhone 14 (mobile)          • 5B3EB205-1BE1-4FDF-B2E3-4E06B9ADC48F • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)             • macos                                • darwin-arm64   • macOS 13.5.1 22G90 darwin-arm64
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 107.0.5304.87

[✓] Network resources
    • All expected network resources are available.

• No issues found!

The issue is we cache the Overlay's size for the entire flight. If there is a keyboard pop up before the flight start, the cached size won't change even if the keyboard is dismissed mid flight. so it use the wrong size to calculate the rect.
I am not sure what may be the best way to fix this, the size change -> hero widget rebuild always has a one frame delay. so even if It uses the correct size, the animation is still janky.

The issue is we cache the Overlay's size for the entire flight.

Can't we just use a fixed size for the hero widget instead of a cached size?

My workaround for now is to unfocus the text field, wait 350ms and only than trigger the Navigation, like described here:
https://github.com/flutter/flutter/issues/106789#issuecomment-1920671370


Fix vector tile classification invert

To test, add these two lines to the 3D Tiles Point Cloud Classification Sandcastle example:
viewer.scene.invertClassification = true;
viewer.scene.invertClassificationColor = new Cesium.Color(0.25, 0.25, 0.25, 1.0);

Thanks @bagnell.


18.4.2 windows_service property "description": NoMethodError

Description
As of 18.4.2, the windows_service resource does not process the description property/argument correctly. Example code:
windows_service service_name do
  binary_path_name startup_command
   name new_resource.agent_name
   description "#{new_resource.agent_name} agent"
   delayed_start false
   timeout 30
   action %i[create enable start]
 end

The error is:
NoMethodError
-------------
undefined method `description' for #<struct Struct::ServiceConfigInfo service_type="own process",
 start_type="auto start", error_control="normal", binary_path_name="C:/vault/vault.exe agent
-config=C:/vault/config/agent.hcl ", load_order_group="", tag_id=0, dependencies=[],
service_start_name="LocalSystem", display_name="vault">

            current_resource.description(config_info.description)           if new_resource.description
                                                    ^^^^^^^^^^^^

Removing the description property from the resource works around the problem.
Chef Version
18.4.2 (was working in 18.3.0)
Platform Version
      System Info:
      ------------
      chef_version=18.4.2
      platform=windows
      platform_version=10.0.17763
      ruby=ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x64-mingw-ucrt]

Stacktrace
C:/cinc-project/cinc/embedded/lib/ruby/gems/3.1.0/gems/chef-18.4.2-x64-mingw-ucrt/lib/chef/provider/service/windows.rb:77:in `load_current_resource'
C:/cinc-project/cinc/embedded/lib/ruby/gems/3.1.0/gems/chef-18.4.2-x64-mingw-ucrt/lib/chef/provider.rb:228:in `run_action'
C:/cinc-project/cinc/embedded/lib/ruby/gems/3.1.0/gems/chef-18.4.2-x64-mingw-ucrt/lib/chef/resource.rb:601:in `block in run_action'

This is a result of https://github.com/chef/chef/pull/14064. ServiceConfigInfo does not include a description field, do we even test things anymore?

https://github.com/chef/win32-service/blob/67a0f7ac46a5e0332d95867f1ee2e7cd733b9117/lib/win32/service.rb#L206-L217

This is also on Chef 17.10.122

This is also happening on Chef 17.10.122

Makes sense.  They backported the change I referenced into 17 here.  https://github.com/chef/chef/pull/14151


Get data out of a referenced ImageSurface

ImageSurface::get_data returns an error if the surface is referenced, but I believe it should still be possible to copy the data out safely: since neither ImageSurface nor Context is Sync, there shouldn't be any concurrent modifications.
Of course, there's the question of how to return the data: you can't return &[u8], for reasons discussed in #279. But would you accept a PR to add a method like this?
impl ImageSurface {
    pub fn copy_data_to(&self, buf: &mut [u8]) -> Result<(), BorrowError>;

    // Or, a more general version
   pub fn with_data<F: FnOnce(&[u8])>(&self, f: F) -> Result<(), BorrowError>;
}

The with_data variant looks like a good idea to me


Fix assertion on unhandled exceptions

Follow up fix after #815 ('a187e6d'). Fixed the following
assertion on unhandled exceptions:

ICE: Assertion 'ecma_get_value_type_field (value) == ECMA_TYPE_OBJECT'
failed at ecma-helpers-value.c(ecma_get_object_from_value):375.

JerryScript-DCO-1.0-Signed-off-by: László Langó<EMAIL_ADDRESS>

Other than my two comments above, the patch looks good to me (FWIW).

@akiss77, fixed.

@LaszloLango thanks. Still LGTM (FWIW)

LGTM


Issue with applying Vulnerability security profile

I was browsing through code and come across this pattern in panos.go:1623.  Note that AntiSpyware string was used as Vulnerability.  The same pattern repeated in other places in the same file.  Can you check if this is intended?  Thanks.
if len(secprofiles.Vulnerability) > 0 { 						xmlBody += fmt.Sprintf("<vulnerability><member>%s</member></vulnerability>", secprofiles.AntiSpyware) 					}

Ah, thanks for finding this. Probably forgot to change the values when I copied certain parts!

No problem.  Thank you for your effort maintaining this!  Btw, do you have any sample code for security profile creation for antivirus or vulnerability?
Cheers,
Rex

On Aug 3, 2017, at 4:56 AM, Scott Ware<EMAIL_ADDRESS>wrote:
Ah, thanks for finding this. Probably forgot to change the values when I copied certain parts!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok, fixed the typo, and also added the ability to apply URL filtering and file-blocking profiles as well.
As for examples on profile creation, that is something that I'm working on currently, so I should have the ability to create profiles finished soon!

Very cool.  Looking forward to see the new capabilities.
Rex

On Aug 3, 2017, at 7:19 AM, Scott Ware<EMAIL_ADDRESS>wrote:
Ok, fixed the typo, and also added the ability to apply URL filtering and file-blocking profiles as well.
As for examples on profile creation, that is something that I'm working on currently, so I should have the ability to create profiles finished soon!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


No end-effector specified error

Run quadrotor_global_planner::moveit_path_planner
Unable to construct goal representation
Fail: ABORTED: Catastrophic failure
No end-effector specified

https://github.com/DaikiMaekawa/quadrotor_navigation/pull/41 tentative deal


fix(module:checkbox): fix checkbox host class lost bug

close #104
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information

Coverage remained the same at 52.233% when pulling 188b15e5b22db9041c5e788c3d10b99d0fbd241c on giscafer:checkbox-host-class-bug into 15f6aadb5d8e1f047bdf005fca09b5c1154b3cc5 on NG-ZORRO:master.


Dislocated SVG class position

Chart CHART position in div has been dislocated
Please change position to "relative" to fix

rendered:

bump


fix: Overflowing tabs in SqlLab not styled properly

SUMMARY
In SouthPane component, when the tabs overflow there should be a dropdown component that shows invisible tabs. Currently, the overflowing tabs stretch the whole container. I fixed it by adding overflow: auto to QueryPane.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

@rusackas Can we merge it?

Codecov Report

Merging #11367 into master will decrease coverage by 10.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #11367       +/-   ##
===========================================
- Coverage   65.78%   55.34%   -10.44%
===========================================
  Files         838      406      -432
  Lines       39841    13561    -26280
  Branches     3655     3443      -212
===========================================
- Hits        26208     7506    -18702
+ Misses      13532     5877     -7655
- Partials      101      178       +77

Flag
Coverage Δ

#cypress
55.34% <ø> (-0.67%)
:arrow_down:

#javascript
?

#python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...et-frontend/src/components/Menu/LanguagePicker.tsx
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...uperset-frontend/src/utils/getClientErrorObject.ts
0.00% <0.00%> (-89.19%)
:arrow_down:

.../src/dashboard/components/FilterIndicatorGroup.jsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...c/explore/components/controls/withVerification.jsx
9.09% <0.00%> (-87.88%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

...rset-frontend/src/profile/components/Favorites.tsx
0.00% <0.00%> (-86.67%)
:arrow_down:

... and 655 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae54ac...0622706. Read the comment docs.


Bazel installation Error for Python 2.7 in "/installPrerequisites.sh" command

My machine: Jetson TX2
Ubuntu 16.04 LTS
Python 2.7.12
CUDA  release 9.0, V9.0.252
cuDNN 7.0.5
Any clue ?

The installation scripts were written some time ago, when TensorFlow did not support CUDA 9.0. The issue is that an older version of JAVA is needed to build Bazel. For a more modern build, please see: https://github.com/JasonAtNvidia/JetsonTFBuild


Support tf.IsFinite lowering

1. System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
TensorFlow installation (pip package or built from source): pip
TensorFlow library (version, if pip package or github SHA, if built from source): nightly

2. Code
import tensorflow as tf

@tf.function
def func(x):
  return tf.is_finite(x)

converter = tf.lite.TFLiteConverter.from_concrete_functions([func.get_concrete_function(tf.TensorSpec(shape=(1, 2, 3)))])
converter.convert()

3. Failure after conversion
It will fail if flex is not enabled. However, tf.is_inf() is supported without flex because it is lowered to other ops in lower_tf.cc. It should be easy to support lowering pattern of tf.is_finite. Note that tf.is_finite is also being used in tf.keras.layers.Softmax with multi-axes reduction. I understand that I can enable flex to use it, but it should be a minimum work to lower it directly.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/layers/advanced_activations.py#L328-L345

Thanks for filing the feature request! Is there any plan for this in your side?

@WindQAQ I'll make a quick PR to support op lowering.

Thanks for filing the feature request! Is there any plan for this in your side?

@abattery Is probably like tf.logical_not(tf.logical_or(tf.is_nan(x), tf.is_infinite(x)))

@WindQAQ I'll make a quick PR to support op lowering.

Thank you for the help!

Finally my PR is merged at e89316dfca814d2d2ff2bef47d33bc33140cc112
The tf.IsFinite is lowered to tf.Equal(tf.Subtract(x, x), 0).


[Place] Sidebar of Hawaii overflows into footer of the page

In the "Economics" subtopic page for Hawaii, the sidebar seems to overflow into the footer of the page.

This has been fixed


enable compact storage for structs

example:
https://github.com/acebusters/economy/blob/develop/contracts/satelites/PullPayment.sol#L16
value and date can go into 1 32byte storage slot, like:
<28bytes>value<4bytes>date
implementation effort:

compacting
unwrapping
new boundary checks for values

I don't see any gas savings when using mapping(addess => uint) instead of mapping(address => Payment). Not worth the hassle. Am I missing something?

@johannbarbie or this is about moving pull payments to Storage contract?

nope, not about storage contract.
now Payment is taking 64 bytes, by packing the 2 dates into 1, we could reduce to 32bytes, no?

I thought so too. I played with it in Remix and seems not to be true. Probably because conversions from base uint256 take gas too.

I don't see any gas savings when using mapping(addess => uint) instead of mapping(address => Payment)

Sorry. There is a difference. I was talking about using struct that supposed to be packed into 32 bytes


Test gradle.properties jvm args are used

Adds a test case to check that jvmargs in gradle.properties are respected.
It's possible to set jvm args at various points of the tooling api.  This checks they're being set in the ProjectConnection.  If the tooling API spins off another process to retrieve the model and that doesn't use the same jvm args, then that wouldn't be tested for here.
Uses BuildEnvironment to check jvm args.

So it turns out the jvm args are picked by gradle?

@timreebow Could you share more information? Or is there any other way that we can leverage for testing?

So it turns out the jvm args are picked by gradle?

It seems so.  https://github.com/gradle/gradle/issues/22856 seems to back that up it but also suggests that there is a priority order so I did wonder if they were being overwritten somewhere rather than not being used.


Unsupported URL tvplay.tv3.lt

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.05.11
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl "https://tvplay.tv3.lt/i-siaure-10278493" -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://tvplay.tv3.lt/i-siaure-10278493', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.05.11
[debug] Python version 3.7.3 (CPython) - MY_KERNEL_VERSION_REDACTED
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[generic] i-siaure-10278493: Requesting header
WARNING: Falling back on generic information extractor.
[generic] i-siaure-10278493: Downloading webpage
[generic] i-siaure-10278493: Extracting information
ERROR: Unsupported URL: https://tvplay.tv3.lt/i-siaure-10278493
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.7/site-packages/youtube_dl/extractor/common.py", line 529, in extract
    ie_result = self._real_extract(url)
  File "/usr/lib/python3.7/site-packages/youtube_dl/extractor/generic.py", line 3329, in _real_extract
    raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://tvplay.tv3.lt/i-siaure-10278493

Description

I believe tvplay.tv3.lt changed their url, I think it used to be tv3play.tv3.lt, as a result the tvplay extractor doesn't work for tv3.lt anymore.

Same issue here. They once again dropped one part of the URL (it was https://tvplay.tv3.lt/i-siaure/i-siaure-10278493/ before, now its just https://tvplay.tv3.lt/i-siaure-10278493/). #17344 is similar.

same for Estonian one https://tvplay.tv3.ee and Latvian https://tvplay.skaties.lv


Change unsupported culture log level

Fixes #4504

Oops, seems origin/master little bit old, I will fetch upstream and fix the conflicts soon ..

Thanks @hishamco.
@ryanbrandenburg waiting for your review.

I've approved, but those tests that are failing are for real. There's a test somewhere that checks what level this log is, you need to adjust the expectations there before you'll get a green build and I can merge this.

Thanks @ryanbrandenburg.
@hishamco hope you can fix the tests too, so we can get this merged.

I will check them, pardon me I am not able to open the solution in VS 2019, I'm still blocked by an issue that I reported

:shipit:


On the first frame of rendering stock home, all tab views are built

For some reason, on the first build of the stock home, the portfolio tab is built even if it's not visible. This also happens when switching from the stock view back to the stock home, or when rotating the device (but only portrait to landscape; landscape to portrait is fine).
You can test this by putting print statements in the stock tab build function:
$ git diff upstream/master --stat stock_home.dart; git diff upstream/master stock_home.dart
 examples/stocks/lib/stock_home.dart | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/stocks/lib/stock_home.dart b/examples/stocks/lib/stock_home.dart
index bb1171c..b09619e 100644
--- a/examples/stocks/lib/stock_home.dart
+++ b/examples/stocks/lib/stock_home.dart
@@ -260,6 +260,7 @@ class StockHomeState extends State<StockHome> {
   }

   Widget buildStockTab(BuildContext context, StockHomeTab tab, List<String> stockSymbols) {
+print('building stock tab $tab...');
     return new Container(
       key: new ValueKey<StockHomeTab>(tab),
       child: buildStockList(context, _filterBySearchQuery(_getStockList(stockSymbols)).toList())
@@ -274,6 +275,7 @@ class StockHomeState extends State<StockHome> {
   }

   Widget build(BuildContext context) {
+print('top of $this build');
     return new Scaffold(
       key: scaffoldKey,
       toolBar: _isSearching ? buildSearchBar() : buildToolBar(),
@@ -282,7 +284,7 @@ class StockHomeState extends State<StockHome> {
         onSizeChanged: _handleSizeChanged,
         child: new TabBarView<StockHomeTab>(
           selection: _tabBarSelection,
          items: [StockHomeTab.market, StockHomeTab.portfolio],
           itemExtent: _viewWidth,
           itemBuilder: (BuildContext context, StockHomeTab tab, _) {
             switch (tab) {

This seems wrong. I can't see any reason why we'd need to build the portfolio tab view, especially since we apparently immediately thow it away.

Initially we don't know how wide the TabBarView (a ScrollableList) will be - see _viewWidth in stock_home.dart. After the SizeObserver runs only one view is built.  The code probably shouldn't build anything until _viewWidth is set. I will fix this.

It's critical that we render the list on the first frame otherwise heroes won't work.

This may have changed now that the SizeObservers are gone.

Probably fixed already.

Both functions are called explicitly from build:
        body: new TabBarView(
          children: <Widget>[
            _buildStockTab(context, StockHomeTab.market, config.symbols),
            _buildStockTab(context, StockHomeTab.portfolio, portfolioSymbols),
          ]
        )

This patch fixes it:
diff --git a/examples/stocks/lib/stock_home.dart b/examples/stocks/lib/stock_home.dart
index 105b5abcc..0e4ca006c 100644
--- a/examples/stocks/lib/stock_home.dart
+++ b/examples/stocks/lib/stock_home.dart
@@ -275,6 +275,7 @@ class StockHomeState extends State<StockHome> {
   }

   Widget _buildStockTab(BuildContext context, StockHomeTab tab, List<String> stockSymbols) {
+    print('building stock tab $tab...');
     return new Container(
       key: new ValueKey<StockHomeTab>(tab),
       child: _buildStockList(context, _filterBySearchQuery(_getStockList(stockSymbols)).toList(), tab)
@@ -319,6 +320,7 @@ class StockHomeState extends State<StockHome> {

   @override
   Widget build(BuildContext context) {
+    print('top of $this build');
     return new DefaultTabController(
       length: 2,
       child: new Scaffold(
@@ -328,8 +330,12 @@ class StockHomeState extends State<StockHome> {
         drawer: _buildDrawer(context),
         body: new TabBarView(
           children: <Widget>[
-            _buildStockTab(context, StockHomeTab.market, config.symbols),
-            _buildStockTab(context, StockHomeTab.portfolio, portfolioSymbols),
+            new Builder(
+              builder: (BuildContext context) => _buildStockTab(context, StockHomeTab.market, config.symbols),
+            ),
+            new Builder(
+              builder: (BuildContext context) => _buildStockTab(context, StockHomeTab.portfolio, portfolioSymbols),
+            ),
           ]
         )
       )

However, a better fix is to create a StockTab widget.

I'm going to close this since it's specific to the stocks demo. It'll probably eventually get fixed the next time someone does a clean-up sweep through that code.


Rancher pods restart with fleet errors

Rancher Server Setup

Rancher version: master-head version be7cdb8
Installation option (Docker install/Helm Chart): HA install

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1 k8s version v1.19.6

Describe the bug
Rancher pods are restarting in HA and hosted Rancher setups. Repeated fleet errors are seen in Rancher logs.
To Reproduce
Bring up a Rancher v2.6 HA setup (3 nodes, all roles, t3.xlarge) and leave the setup running.
View Rancher pods in System project deployments.
Result
Rancher pods are restarting:

Repeated errors are seen in Rancher logs:
[ERROR] error syncing 'cluster-fleet-local-local-1a3d67d0a899': handler namespace-auth: Operation cannot be fulfilled on clusterroles.rbac.authorization.k8s.io "p-h8dmm-namespaces-readonly": StorageError: invalid object, Code: 4, Key: /registry/clusterroles/p-h8dmm-namespaces-readonly, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 245d6429-b13f-4129-8e4e-c273816e5415, UID in object meta: , requeuing
2021/07/24 00:42:30 [ERROR] error syncing 'cattle-fleet-clusters-system': handler namespace-auth: Operation cannot be fulfilled on clusterroles.rbac.authorization.k8s.io "p-h8dmm-namespaces-readonly": StorageError: invalid object, Code: 4, Key: /registry/clusterroles/p-h8dmm-namespaces-readonly, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 245d6429-b13f-4129-8e4e-c273816e5415, UID in object meta: , handler resourceQuotaSyncController: projects.management.cattle.io "local/p-h8dmm" not found, handler resourceQuotaUsedLimitController: projects.management.cattle.io "local/p-h8dmm" not found, requeuing
2021/07/24 00:42:30 [ERROR] error syncing 'fleet-local': handler namespace-auth: Operation cannot be fulfilled on clusterroles.rbac.authorization.k8s.io "p-h8dmm-namespaces-readonly": StorageError: invalid object, Code: 4, Key: /registry/clusterroles/p-h8dmm-namespaces-readonly, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 245d6429-b13f-4129-8e4e-c273816e5415, UID in object meta: , handler resourceQuotaSyncController: projects.management.cattle.io "local/p-h8dmm" not found, handler resourceQuotaUsedLimitController: projects.management.cattle.io "local/p-h8dmm" not found, requeuing
2021/07/24 00:42:30 [ERROR] error syncing 'fleet-local': handler namespace-auth: Operation cannot be fulfilled on clusterroles.rbac.authorization.k8s.io "p-h8dmm-namespaces-edit": StorageError: invalid object, Code: 4, Key: /registry/clusterroles/p-h8dmm-namespaces-edit, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 539e3d53-9834-4278-b1a3-4067a85eceea, UID in object meta: , requeuing

Additional context
These errors are not seen on single install master-head.
These errors are also seen on a hosted Rancher setup.

These errors are not seen on single install master-head.

Pretty strange that non-HA doesn't encounter it. Fleet should not care how it is deployed.
CC: @StrongMonkey

@aaronRancher: I see this in single node as well on master-head.
[ERROR] error syncing 'local': handler provisioning-cluster-create: failed to create fleet-local/local provisioning.cattle.io/v1, Kind=Cluster for provisioning-cluster-create local: namespaces "fleet-local" not found, requeuing

@aaronRancher: I checked on both HA and single node with @kinarashah. These appear to be transient errors and are expected. The gitjob, fleet-controller, and fleet-agent pods come up in a reasonable amount of time and are running. Did they fail in your usage?

Tested on Rancher master-head version b395238
Gitjob, fleet-controller, and fleet-agent workloads are healthy.

Closing issue as these errors are expected.


[FLINK-13281] Fix the verify logic of AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest

What is the purpose of the change
FLINK-13060 ensure FailoverStrategies should respect restart constraints. However, this change did not cover the AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest which should also set as FixedDelayRestartStrategy. Currently, as the pending checkpoint would still be discarded due to failUnacknowledgedPendingCheckpoints within CheckpointCoordinator, AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest could pass the test.
This is actually not what we want the test did, we should actually verify that when region failover, pending checkpoints would be discarded.
Brief change log

Fix the verify logic of AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest

Verifying this change
This change modify previous test AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot attention @zentol

Why do you think that we no longer correctly test that pending checkpoints are being aborted with FLINK-13060 @Myasuka?

@tillrohrmann I would try to interpret this more clearly below:
After FLINK-13060, AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest still use previous InfiniteDelayRestartStrategy which means AdaptedRestartPipelinedRegionStrategyNG#resetTasks() would never be called when some task failed. The root cause why previous AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest could still pass is because of the pending checkpoints are aborted by failUnacknowledgedPendingCheckpointsFor() method in CheckpointCoordinator (which is actually introduced vai FLINK-7844 ).
In a nutshell, we expect pending checkpoints are aborted by AdaptedRestartPipelinedRegionStrategyNG#resetTasks() not CheckpointCoordinator#failUnacknowledgedPendingCheckpointsFor().

Why are you adding a second vertex?

@zentol If only one vertex, after that vertex sent acknowledge message to checkpoint coordinator and that checkpoint would be treated as completed checkpoint. Actually I just want that checkpoint still stay as pending checkpoint.


Files losing their properties after extraction

Sorry to reopen this issue (#18) but it seems you have fixed only the mode bug. Extracting files, especially symlinks as I noticed, are still losing their properties. Am I wrong?

@grebett, this should be fixed in 4.0.0.


Better error messages when Toil runs out of disk

For both caching and non-caching file store

I'll get on this


Is this project dead?

No releases in years and years.  Forks ahead with PR's that haven't been touched.  Whats up?

@bramski
Yes, I consider it dead.  I don't know what people are doing with their forks, of course.
I suspect the better way to do this now is to write ActiveStorage::Service.  I'm curious, but will probably not have time in the near future.


Adding the Search User Activity

Searching user by usernames
Fixing the previous bug
@Ijaiswalshivam Assign me this.

@Qomfortzone firstly fix issue #105 after that i'm assigning this to you.

@Qomfortzone can you please refork it and then implement these feature, as from now login and signup feature is fully functional

And why not search button on top of the bar?

@Ijaiswalshivam
It becomes more easy to reach there ... It can be improved later ..wherever you want to place it...According to me it is perfectly fine there...some style adjustments can be made....
I will fork again and implement everything in a single commit.

Hmm ok


only run betterC tests on buildkite

to avoid duplication of lengthy unittests (also run on auto-tester)

Mmh, hardly reduces test time, phobos unittest build time has become quite crazy since splitting up all tests (and adding more of 'em).


Fix instantiating unikernels and tailing logs

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

This makes several changes across subsystems to fix the instantiation and tailing of unikernels via kraft run. A number of changes were required, particularly:

Deprecating the use of a UNIX socket for the logs of a QEMU instance -- since there could be a synchronization issue if the consumer was not fast enough to start receiving logs. Instead, the logs are written verbatim to log file which itself has been made available in machine.MachineConfig. Necessary adjustments are made to facilitate "tailing" from a log file from QEMU. This has the added benefit being able to retrieved after the unikernel has ended its life.
Fixing the instantiation, tailing and monitoring of a unikernel in kraft run. The instantiation of the events monitor is made to be completely silent such that sub-process noise does not spill over into the executor's parent's stdout. The actual instantiation of the unikernel via driver.Start() is moved as late-as-possible such that go-routines can be established first. Additionally, the manipulation of the cancalable-context is fixed with respect to the fixed TailWriter.
Introduce an optional CLI argument for setting the name of the unikernel;
Introduce an optional CLI argument for setting the initrd (CPIO) file for the unikernel.

How to test
I used a simple "Hello, World" C unikernel, with 1 target (kvm-x86_64) and a simple loop in main.c, e.g.:
#include <stdio.h>
#include <time.h>
#include <errno.h>

static void millisleep(unsigned int millisec)
{
        struct timespec ts;
        int ret;

        ts.tv_sec = millisec / 1000;
        ts.tv_nsec = (millisec % 1000) * 1000000;
        do
                ret = nanosleep(&ts, &ts);
        while (ret && errno == EINTR);
}

int main(int argc, char *argv[])
{
        for (;;) {
                printf("Hello world!\n");
                millisleep(1000);
        }

        return 0;
}

Once built as a unikernel, I could do the following:
# this will instantiate `hello1` and immediately detach.
kraft run --detach --name hello1

# i can now see there `kraft events` and `qemu-system-x86_64` running in the background

# starting another unikernel will start to tail the logs
kraft run --name hello2

# Ctrl+C will stop tailing

# i can kill them both
kraft stop --all

# see that they are both exited
kraft ps

# clean up
kraft rm --all

# no lingering process should be on the system (aka `kraft events [...]`)

Thanks for the feedback @craciunoiuc, i'll take a look :)


Declaring a Default Queue

Is it possible to implement a default queue, similar to ActionMailer or Textris's ownfrom value?  I don't use the :textris queue and manually setting a queue on every delivery is quite repetitive.
Something like this:
class NotificationTexter < Textris::Base
  default queue: "notifications"

  def cool_update(user)
    ...
  end
end

Another nice option would be be able to override the default :textris queue in an optional initializer. For  example, this is how Rollbar approaches this issue:
# config/initializers/rollbar.rb
Rollbar.configure do |config|
  config.use_sidekiq 'queue' => 'low'
end

This is a fantastic gem overall, but being able to customize some fairly basic defaults (i.e. #29) would make it much cleaner to incorporate into existing Rails apps.

Hi! Sorry for a huge time without any response here. We're doing our best to de-dust open source projects, but as of writing I must say that we do not meet required throughput to provide resolution for this issue. I'll add Help Wanted label here and if anyone comes up - feel more than welcome to contribute and open a PR!


Replace des and md4 usage with pure javascript versions

If an OpenSSL3-based nodejs isn't started with --openssl-legacy-provider it will refuse to enable DES-ECB and md4 algorithms, see https://github.com/Catbuttes/axios-ntlm/issues/19
This PR replaces both algorithms with pure JS implementations.
I figure there may be some subtle safety issues (eg side channels) when using a JS-based implementation instead of OpenSSL, but the algorithms involved shouldn't be used at all anyway if you're concerned about security. (And neither should NTLM itself)

hi @unilynx, you haven't replaced md4 and des-ecb at all places used.

hi @unilynx, you haven't replaced md4 and des-ecb at all places used.

Are you referring to the files in lib/  ? I didn't touch those as they're built from src/ and rebuilding these myself also makes quite a few other changes (see https://github.com/unilynx/axios-ntlm/commit/846fc4fc5096a80401a4062bc4b9b464a999a267) and I wasn't sure if this repository preferred PRs to also include all the automatic changes

hi @unilynx, you haven't replaced md4 and des-ecb at all places used.

Are you referring to the files in lib/ ? I didn't touch those as they're built from src/ and rebuilding these myself also makes quite a few other changes (see unilynx@846fc4f) and I wasn't sure if this repository preferred PRs to also include all the automatic changes

Hi , I am referring to the files inside src.


Add mutex to logger

Fixes #1312.
God knows how to test this.

Thanks for the fix. However, adding a mutex is a lot heavier than simply using a print statement,  which is atomic by itself.

@Fjan I opted for a mutex for two reasons:

I’d prefer not to rely on #print being atomic — it is not documented to be atomic, and not all Ruby implementations might implement #print atomically.

Mutexes are so cheap that the slowdown of using mutex is unlikely to be noticeable.


feat: Make MAD process cancellable

A long time ago, during the initial development of the feature, somebody (Jan maybe?) suggested making the mod install process cancellable, in case it takes too long (slow Internet speed, for instance).
This PR does just that, implementing the ModDownloader::CancelDownload function (already present in the header btw), that can stop MAD process at two moments:

during archive downloading, using CURLE_ABORTED_BY_CALLBACK (returned from download callback function, see https://curl.se/libcurl/c/CURLOPT_XFERINFOFUNCTION.html);
during archive extraction.

Must be merged with mods counterpart (https://github.com/R2Northstar/NorthstarMods/pull/865)!
Media
mod_download_cancelling.webm
Here, mod install process is interrupted twice, by successively stopping archive downloading and archive extraction; note that this does not prevent mod install from completing successfully when ran a third time.
Testing

Install both launcher and mods PRs;
Launch game and go to server browser;
Enable MAD (allow_mod_auto_download 1);
Try to join Space battle server (this server requires a mod that's big enough to leave you enough time to click the new "cancel" button);
Enjoy the new "cancel" button!

What happens if a server requires two mods, and the first one completes but the second is aborted? Do we clean up the already-downloaded mod properly?

The download method is triggered once per mod: this means first mod would be installed, and second mod would be cleaned up.

The download method is triggered once per mod: this means first mod would be installed, and second mod would be cleaned up.

Do we enable the mods as soon as they are downloaded? Could this potentially cause issues?

Do we enable the mods as soon as they are downloaded? Could this potentially cause issues?

Works fine 👍
https://github.com/user-attachments/assets/2d6c7cc3-aa24-42fd-b6a5-2a3b373c3684

Thanks for testing. I'll push out the current release-candidate as a full patch release, give it a day or two to stabilise and then merge this and prepare the next minor release ^^

Tested on NorthstarCN but it works fine!


Error trying to parse settings when creating new post

Im trying Hugofy: New Post command on sublite text and I get the following error:
Error trying to parse settings: Unexpected character, expected a comma or closing bracket in Packages/Hugofy/hugofy.sublime-settings:9:3

I get the same error

I assume you installed Hugofy-sublime via Package Control. Right? Apparently the latest official version is installed in this case. However, this version contains the buggy file hugofy.sublime-settings.
At Github this was fixed a few months ago (https://github.com/akmittal/Hugofy-sublime/commit/903c0a54c27a8650b318578a474289776abf559c). Since then no new official version has been released.
So download Hugo-sublime as a zip file from Github and extract the contents into the package directory of Sublime (for me it is ~/.config/sublime-text-3/Packages/). Then Hugo-sublime should work.

@akmittal can you please release a new version so this gets fixed?

Tagged a new version, should be available soon


[Ready for Payment][$250] Android - Chat - On sending attachment+text, on edit url is not shown as hyperlink

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.14
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4787789
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause - Internal Team
Action Performed:

Launch app
Tap on a report
Enter a url + upload a image and send the message
Long press and edit the message sent
Enter a url and email id along with previous url entered and save the message

Expected Result:
On sending attachment+text, on edit url must be shown as hyperlink
Actual Result:
On sending attachment+text, on edit url is not shown as hyperlink
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/f2e1f5c9-6203-42f9-873d-fd450f03bf91
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a793178e3d46661b
Upwork Job ID:<PHONE_NUMBER>275560441
Last Price Increase: 2024-08-07

Issue OwnerCurrent Issue Owner: @JmillsExpensify

We think that this bug might be related to #vip-vsp

I'll open up this issue for proposal review since we have one already. If it's an easy fix we can address it. Otherwise, I think we should close the issue.

@bernhardoj I don't see any issues after applying the change too.
But i noticed it's not adding the text before the link as alt attribute of the image

Same issue on staging, do you think it's a bug and simple enough to handle it here?

I can repro that and the img tag itself has the alt attribute,

but our ImageRenderer never uses that (not sure why). We can fix it by passing the alt as accessibilityLabel to the image.

@bernhardoj the solution is working fine, but it's not highlighting the link in the composer if it's placed before the image.

@getusha we would need to update the live markdown to use the new update from expensify-common. You can test it locally by updating<EMAIL_ADDRESS>and search for the "autolink" rule.

@bernhardoj's proposal looks good to me.
🎀 👀 🎀 C+ Reviewed!

ah okay cool - if we don't have that bug anymore I'm fine with this fix. To double check, though, we should include testing steps for that issue as well as the issue raised here. Assigning!

expensify-common PR is ready
cc: @getusha

Not overdue, https://github.com/Expensify/expensify-common/pull/782 was just merged. I think we need an additional app PR to bump the version to 2.0.76 right?

We need to bump the version in live markdown first. I have opened the live markdown PR here
cc: @getusha

ah great, I'll take a look at that shortly and merge

The App PR is ready
cc: @getusha

This looks like it was affected by the missing automation on prod deploy. I think we're in the 7 day waiting period @JmillsExpensify? But not sure when it started.

I'm pretty sure this one has completed the 7-day regression period, but not 100%. @JmillsExpensify do you know if there's an easy way to confirm? There was discussion about this somewhere...

Now this is definitely ready to go.

Requested in ND.

Payment Summary:

Contributor: @bernhardoj $250
Reviewer: @getusha $250

$250 approved for @bernhardoj

@getusha do you mind filling out the BZ checklist?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/expensify-common/pull/661
[@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@] Determine if we should create a regression test for this bug. No, i don't think this issue is impactful. it's more like an edge case.
[@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a

$250 approved for @getusha

$250 approved for @getusha