silly - redirect to shopify

I browsed through the past issues and docs and could not find it :/
I want that clients will get redirected to my app inside shopify view, currently they are on my own domain.
Flow:

user installs my app, through install page or marketplace
accepts all the needed items
(current) gets redirected to my domain app.com
(expected) I want him to be inside shopify example.myshopify.com/admin/apps/myapp

any idea what am I doing wrong?
sorry for the stupid question :|

This is the correct flow as Shopify redirects to your domain for OAuth and then should automatically refresh back to Shopify, landing in the admin panel and your app. It happens almost instantly.
Where does your flow stop? What do you see?

Is your app enabled as an embedded app?

thanks
yes @fyroc embedded app is enabled
@MCKLtech
this the flow

user install my app
redirected to shopify to approve permissions
then he is redirected to my domain
then he is stuck on my domain and not in shopify app page

Can you post the code of your view?
On Thu, May 9, 2019, 7:13 PM Tzook<EMAIL_ADDRESS>wrote:

thanks
yes @fyroc https://github.com/fyroc embedded app is enabled
@MCKLtech https://github.com/MCKLtech
this the flow

user install my app
redirected to shopify to approve permissions
then he is redirected to my domain
then he is stuck on my domain and not in shopify app page

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ohmybrew/laravel-shopify/issues/236#issuecomment-490989384,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOQY3GDHYWGSVUOABRG75DPURLT5ANCNFSM4HLZASEA
.

hey @ncpope
just saw this part in the blade template:
            <script src="https://cdn.shopify.com/s/assets/external/app.js?{{ date('YmdH') }}"></script>
            <script type="text/javascript">
                ShopifyApp.init({
                    apiKey: '{{ config('shopify-app.api_key') }}',
                    shopOrigin: 'https://{{ ShopifyApp::shop()->shopify_domain }}',
                    debug: false,
                    forceRedirect: true
                });
            </script>

Im using react so I dont have it, but I'll use it.
any ideas on where I can find the api/docs for the
shopify.com/s/assets/external/app.js
file ?
Thanks!

got it:
https://help.shopify.com/en/api/embedded-apps/embedded-app-sdk/initialization
thanks


Write Client script

Client script to be written in python

Can I work on this issue?

I want to work on the client script, please provide me the details and i will complete the work in the given time


Add baseURI polyfill for IE 11 compatibility on Dart 2.13

Added this polyfill to react.js to fix failing web_skin_dart IE 11 functional tests.

Security Insights

(6) Vulnerable direct dependencies were detected
1 vulns in browserslist < 4.16.5 via yarn.lock
1 vulns in elliptic < 6.5.4 via yarn.lock
1 vulns in glob-parent < 5.1.2 via yarn.lock
1 vulns in lodash < 4.17.21 via yarn.lock
1 vulns in path-parse < 1.0.7 via yarn.lock
1 vulns in ssri < 6.0.2 via yarn.lock

Action Items

Review dependencies for available updates
See this Splunk dashboard for more CVE details
Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Public API Changes
No changes to the public API found for commit 353957eb2c929bc6ef86eca43f9f810b2f2e830f
Showing results for 353957eb2c929bc6ef86eca43f9f810b2f2e830f

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

@Workiva/release-management-p


Autocomplete for .NET 4.5.2...

I am upgrading a .NET 4.5.2 project from the old CodePlex Scintilla.NET v2.5.2 to VPKSoft ScintillaNET v<IP_ADDRESS>.  I've got everything working except the autocomplete.  The main problem that I'm running in to is that the old component had and AutoCompleteList property, and I can't find a corresponding property on the new component.
Looking at your wiki, I saw the link to the AutoCompleteMenu-ScintillaNET project.  However, when I tried to install that package, I found that it only supports .NET 4.6.1.
Is there an autocomplete solution that I can use for .NET 4.5.2?

Hi,
I'm not quite sure what auto complete menu do you mean? Is this AutoCompleteMenu-ScintillaNET the one you mean? I haven't worked with the CodePlex-series of the ScintillaNET. Just trying to keep this project originally by @jacobslusser alive.

Hi,
Yes, that is the autocomplete that I meant.  The v2.5.2 version evidently had the menu built in.  I looked at the project that you referenced, but it only supports .NET 4.6.1.  I was just wondering if anyone was aware of an existing solution for .NET 4.5.2.

Hi, I can create a PR for the AutoCompleteMenu-ScintillaNET, with net45, Core, .NET 5 and .NET6 support. I doubt that the process is going to be slow. And of course I have to get started with that in the ongoing decade.

Thanks! That would be awesome.
As an aside, I figured I would install earlier versions of [AutoCompleteMenu-ScintillaNET] (https://github.com/Ahmad45123/AutoCompleteMenu-ScintillaNET) to see if I could find a .NET v4.5.2 one.  I actually got AutoCompleteMenu-ScintillaNET v1.6.1 to install, but then I started getting version conflicts for ScintillaNET between v3.6.3 and the latest version.

Hi,
Here is the PR: https://github.com/Ahmad45123/AutoCompleteMenu-ScintillaNET/pull/10 and the NuGet package in an alpha release for manual download.
I don't know if the PR is ever going to be accepted and merged but it is done in either case.

The pull request is complete - the rest (release process) is up to the author.


Nodewatcher should be fixed.

Environment:

aws-parallelcluster-2.0.2
OS: centos
Scheduler: SGE
Master instance type: [e.g. m5.xlarge]
Compute instance type: [e.g. c5.8xlarge]

Bug description and how to reproduce:
Currently, node watcher check the CloudFormation status by

def stackCreationComplete(stack_name, region, proxy_config):
    log.info('Checking for status of the stack %s' % stack_name)
    cfn_client = boto3.client('cloudformation', region_name=region, config=proxy_config)
    stacks = cfn_client.describe_stacks(StackName=stack_name)
    return stacks['Stacks'][0]['StackStatus'] == 'CREATE_COMPLETE'

But when user update CloudFormation, the status could be 'UPDATE_COMPLETE'.
Therefore, the code must be modified to adapt both status.
I hope this issue be fixed as soon as possible.
(Or if this issue already fixed, all I have to do is 'pip install --upgrade pcluster' ?)

I confirmed that this issue already has been fixed in latest GitHub repo in aws-paralellcluster-node.
It will be fine if I just upgrade aws-parelellcluster ?
And I suggest that it would be okay if UPDATE_ROLLBACK_COMPLETE status also included.


Detection of Java Dummy Package

Feature Request.
The Java support in packages in OS is not very good. Therefore, I would like to add java or nginx by myself.
I would like to continue using the vuln. scan and I created a dummy package with openjdk name and version and nothing else. I expect to find CVE-2019-2422 but do not get it.
Docker image: quay.io/wurstbrot/ubuntu-cve-dummy-test:test4
What can I do to make it detected?
Dockerfile:
FROM ubuntu:18.10

COPY test.deb /tmp/test.deb
RUN dpkg -i /tmp/test.deb

DPKG:
root@8c85618a64d3:/# dpkg -l | grep jdk
ii  openjdk-11-jdk          11.0.1+1-1ubuntu<IP_ADDRESS> all          <short description; defaults to some wise words>

openjdk-11-jdk to create the package via equivs-build:
Standards-Version: 3.9.2

Package: openjdk-11-jdk
Version:11.0.1+1-1ubuntu<IP_ADDRESS>
Description: <short description; defaults to some wise words>
 long description and info
 .
 second paragraph

Hi @wurstbrot, thanks for the writeup. In this case I think the issue is a mismatch between your metadata and the vulnerability record from ubuntu.
The ubuntu cve record shows it is for the openjdk-lts package, not openjdk-11. Per the API in Anchore to get CVE data it knows about (I removed non-ubuntu 18.* records for clarity):
curl -u admin:foobar "http://localhost:8228/v1/query/vulnerabilities?id=CVE-2019-2422"
{
  "page": "1",
  "returned_count": 10,
  "total_count": 10,
  "vulnerabilities": [
  ...
    {
      "affected_packages": [
        {
          "name": "openjdk-8",
          "type": "dpkg",
          "version": "8u191-b12-2ubuntu<IP_ADDRESS>"
        },
        {
          "name": "openjdk-lts",
          "type": "dpkg",
          "version": "*"
        }
      ],
      "id": "CVE-2019-2422",
      "link": "http://people.ubuntu.com/~ubuntu-security/cve/CVE-2019-2422",
      "namespace": "ubuntu:18.04",
      "severity": "Low"
    },
    {
      "affected_packages": [
        {
          "name": "openjdk-8",
          "type": "dpkg",
          "version": "8u191-b12-2ubuntu<IP_ADDRESS>"
        },
        {
          "name": "openjdk-lts",
          "type": "dpkg",
          "version": "11.0.1+13-3ubuntu<IP_ADDRESS>"
        }
      ],
      "id": "CVE-2019-2422",
      "link": "http://people.ubuntu.com/~ubuntu-security/cve/CVE-2019-2422",
      "namespace": "ubuntu:18.10",
      "severity": "Low"
    },
  ...
]

For entries in the dpkg db, Anchore uses the distro cve data rather than the NVD data which doesn't take patches or other distro-specific changes into account. So based on this data, your package isn't vulnerable, but should be detected as vulnerable if you change the metadata to have a package name of openjdk-lts instead of openjdk-11-jdk.
Does that make sense, or am I missing something in the question/issue?

It makes sense why I could not find something, thank you.
It does not makes sense for the purpose of installing self create packages where I still would like to get informed about vulnerabilities. In case I install a package which doesn't exist in ubuntu, I won't get any info.

The enhancement requested is, as I understand it, to detect packages that are not in the distro's package repo and match those for vulnerabilities against the NVD or other non-distro-specific data source.
This will require:

Identify if a distro-type package (rpm, deb, apk) is one provided by the distro.
If not, then do the vuln match against NVD instead of distro source, since the distro will have no cves for it and thus lack of vuln match doesn't imply lack of vuln.


Check username for invalid characters

The first question for the application currently accepts any input. Some users will put "My username is blah" which screws up adding them.
It should at least check the username for invalid characters like punctuation or spaces and ask the user again for just their username.
It may be possible to check whether the account is a valid account via Mojang's API but that would also require code to handle if Mojang's API goes down. Would we just fall back to checking invalid characters?

We can use the Mojang API to validate the username (https://wiki.vg/Mojang_API#Username_to_UUID) it's just a simple GET request. It returns the username and the UUID if it's valid, otherwise, it returns a 204 No Content error.
If we're checking for invalid characters I think that should be enough if Mojang's API goes down. As you said, the request to Mojang's API would act as a double check that the username they have provided is correct.


bat: Use a defer for quota cleanup in BAT tests

This change fixes an issue where if the container workload was not found
then the restoration of the quotas will not occur as t.Skip() was
called. By using a defer we can ensure that the cleanup always happens
and we're not left with dangling quotas.
Signed-off-by: Rob Bradford<EMAIL_ADDRESS>

Coverage decreased (-0.004%) to 65.915% when pulling b0acc1771f8db3118dd8dfcb4d868b25e706a184 on rbradford:defer-quota-reset into 7f76f6c2ad44461f23a78008cd2337513d757264 on 01org:master.

Coverage decreased (-0.004%) to 65.915% when pulling b0acc1771f8db3118dd8dfcb4d868b25e706a184 on rbradford:defer-quota-reset into 7f76f6c2ad44461f23a78008cd2337513d757264 on 01org:master.

Coverage decreased (-0.004%) to 65.915% when pulling b0acc1771f8db3118dd8dfcb4d868b25e706a184 on rbradford:defer-quota-reset into 7f76f6c2ad44461f23a78008cd2337513d757264 on 01org:master.


Delete Poison Pill Operator

Signed-off-by: razo7<EMAIL_ADDRESS>Deleting old and deprecated operator after we have released the new (and updated) operator.
Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/test 4.9-deploy-operator-on-openshift

/test 4.9-deploy-operator-on-openshift

/merge possible


Add unit test support for Cosmos Client types

To enable users to unit test the client all the existing classes were refactored to append Core to the end of class names, and made internal. A new abstract class was created and only exposes the public members. This will allow users to mock the abstract class.

Thanks Jake.


exclude unsafe 503 from default RetryPolicy

Fixes https://github.com/istio/istio/issues/50506

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
592a122300c99773e2f3235f10027606412c8a50
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

I think we could not simply change a setting there for more than five years . The right way is to propose discussion swithin the TOC meeting.

@howardjohn WDYT? If you think it should go to TOC, can you please help with brining this in TOC?

We discussed this in the WG meeting today. There was a general consensus that this change is a better default, with the risks largely being from changing the default which is mitigated by compatibility versions.
WDYT @hzxuzhonghu @ramaraochavali

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

I am afraid issued fixed by https://github.com/istio/istio/pull/10566 will occur,
https://github.com/istio/istio/issues/7665
https://github.com/istio/istio/issues/9113

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
8822b91242a3f3c82c0e41af1a249134b06eb190
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
8822b91242a3f3c82c0e41af1a249134b06eb190
link
true
/test gencheck

lint_istio
8822b91242a3f3c82c0e41af1a249134b06eb190
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

I am afraid issued fixed by https://github.com/istio/istio/pull/10566 will occur,

https://github.com/istio/istio/issues/7665
https://github.com/istio/istio/issues/9113
I do not think retries is a safe solution for 503s coming because of scale down. We have to enable proper draining behaviour (which we mostly do).

We discussed this in the WG meeting today. There was a general consensus that this change is a better default, with the risks largely being from changing the default which is mitigated by compatibility versions.

+1 for this. Safety on "retry on 503" is not some thing that we can decide. It has to be decided by application and can configure it if it is safe. I would actually treat this as a bug.

@howardjohn @hzxuzhonghu how do we move forward with this?

Whatever even it is not very right, at least it is being relied for years.  i donot want to break existing users rely on this to handle case like scale down.
We donot want to see 503 error reported again and again.
I would agree with this if the scaling down 503 can be overcome

Whatever even it is not very right, at least it is being relied for years. i donot want to break existing users rely on this to handle case like scale down.

It does not break them immediately. They have to adjust the retry policy if 503 is safe to them. Otherwise users unknowingly retry non idempotent requests which is a big problem compared to scale down 503.  They may not be realizing it. There are options to solve scale down 503s

FWIW it is also a 1 line tweak to mesh config to add this back where desired.

All the comments make sense. However It is indeed a behavior change, turned on by default. We donot need to magnify this issue, I would treat idempotent as application developer's self bussiness , and for these years we have only one issue reported right?  I I donot want to see istio become a child's play, changing day by day
It cannot achieve idempotent ops simply via undelying tranport layer http/tcp protocol. Without server's own logic, even no proxy put on the path, idempotent cannot be achieved.

However It is indeed a behavior change, turned on by default.

That is why compatibility versions exist. If do not want behaviour change, run with that compatibility version and change. Also I do not think this is a huge problem turn this off or change it via MeshConfig - both are pretty straight forward solutions.

We donot need to magnify this issue, I would treat idempotent as application developer's self bussiness , and for these years we have only one issue reported right?

I do not think any serious user would rely on default retry policy for POST/PUT/DELETE requests. Every one might have changed because of this policy. See https://github.com/istio/istio/issues/13851 and specifically this comment.  503 default retry policy was added because at that we were retuning lot of 503s during scale down and we knew very well that it was a band aid. The proper fix was to implement draining - we added several features both in Envoy and Istio to improve the draining behaviour

It cannot achieve idempotent ops simply via undelying tranport layer http/tcp protocol. Without server's own logic, even no proxy put on the path, idempotent cannot be achieved.

But that does not mean, we just retry assuming that app handles - think about other way, when there is no Envoy infront, they never get duplicate request and with automatic retries in place they get these requests without they knowing it.,
Just because it has been there for 5 years does not make it right. IMO, this is similar to load balancing algo change we did (convert from RANDOM -> LEAST_REQ), it may not work for some but it is better default and we should be open changing the behaviour if there are issues with it.


Question: diff --name-only command implementation

Hey-hey,
I tried to create following git command with go-git: git diff --name-only --diff-filter=AM HEAD~5 HEAD -- .
At some point in my code I have a Patch and iterate over stats:
patch, _ := lastCommit.Patch(&firstCommit)
for i := 0; i < len(patch.Stats()); i++ {
	changedFiles = append(changedFiles, patch.Stats()[i].Name)
}

but all binaries files are missing. I guess because of https://github.com/src-d/go-git/blob/3bd5e82b2512d85becae9677fa06b5a973fd4cfb/plumbing/object/patch.go#L302
Perhaps I don't need Patch object and can do it differently?
Thanks for pointing me in the "right" direction.

@nerro Do you still have an example of your code?

Do you still have your code? I assume something like this:
		currentTree, err := commit.Tree()
		if err != nil {
			return err
		}

		prevTree, err := prevCommit.Tree()
		if err != nil {
			return err
		}

		changes, err := currentTree.Diff(prevTree)
		if err != nil {
			return err
		}

		for _, c := range changes {
			...
		}

@StevenACoffman, it's already about 1 year and I solved it different way. If you're interested I can check the code.

Yeah, I would still appreciate the code as a reference. Thanks!

package main

import (
	"fmt"
	"gopkg.in/src-d/go-git.v4"
	"gopkg.in/src-d/go-git.v4/plumbing"
	"gopkg.in/src-d/go-git.v4/utils/merkletrie"
	"os"
	"strconv"
	"strings"
)

// Example how to resolve a revision into its commit counterpart
func main() {
	fmt.Println("git ")
	CheckArgs("<revision1>")

	var hash plumbing.Hash

	prevSha := os.Args[1] //prevSha

	dir, err := os.Getwd()
	CheckIfError(err)

	repo, err := git.PlainOpen(dir)
	CheckIfError(err)

	if len(os.Args) < 3 {
		headRef, err := repo.Head()
		CheckIfError(err)
		// ... retrieving the head commit object
		hash = headRef.Hash()
		CheckIfError(err)
	} else {
		arg2 := os.Args[2] //optional descendent sha
		hash = plumbing.NewHash(arg2)
	}

	prevHash := plumbing.NewHash(prevSha)

	prevCommit, err := repo.CommitObject(prevHash)
	CheckIfError(err)

	commit, err := repo.CommitObject(hash)
	CheckIfError(err)

	fmt.Println("You are not crazy"+ prevCommit.Hash.String() + " "+ commit.Hash.String())

	isAncestor, err := commit.IsAncestor(prevCommit)
	CheckIfError(err)

	fmt.Printf("Is the prevCommit an ancestor of commit? : %v %v\n",isAncestor)

	currentTree, err := commit.Tree()
	CheckIfError(err)

	prevTree, err := prevCommit.Tree()
	CheckIfError(err)

	patch, err := currentTree.Patch(prevTree)
	CheckIfError(err)
	fmt.Println("Got here"+ strconv.Itoa(len(patch.Stats())))

	var changedFiles []string
	for _, fileStat := range patch.Stats() {
		fmt.Println(fileStat.Name)
		changedFiles = append(changedFiles,fileStat.Name)
	}

	changes, err := currentTree.Diff(prevTree)
	CheckIfError(err)

	fmt.Println("Got here!")
	for _, change := range changes {

		// Ignore deleted files
		action, err := change.Action()
		CheckIfError(err)
		if action == merkletrie.Delete {
			fmt.Println("Skipping delete")
			continue
		}

		// Get list of involved files
		_, to, err := change.Files()
		CheckIfError(err)

		//Ignore binary files
		bin, err := to.IsBinary()
		if bin || err != nil {
			fmt.Println("Skipping Binary"+to.Name)
			continue
		}
		fmt.Println(to.Name)
	}
}

The change.Files() gives only the names of the files with to.Name, with no paths inside the repository, however the change.toString() gives the full path.

@StevenACoffman this was an immensely helpful snippet of code to find. Do you think it could be moved into a test to ensure it doesn't bitrot?

Thanks! I have prototyped in bash and then usually convert to go, so I often search these issues for some equivalent. It would be nice to make a single page that is a translation between common git cheatsheet / cookbook and having go-git code snippets that did the same thing. Making them tests would keep ensure they are kept working though.

godoc has a nifty thing called a "testable example" which you could use if you would like the test to run on a regular basis. I ended up reading a bunch of src-d/hercules code last night and they have an interesting thing where their test cases are based on the first 100 commits of the hercules repo. You could load the root of the git repo and use that as your testbed.

Go for it! I think you have a great idea, and I'd love to see it!


Backend API for sending an invoice via phone number

Is your feature request related to a problem? Please describe.
Customer goes to counter at hotel
Counter sends customer an invoice via phone number - the hotel IT system calls our backend with

the invoice (json with line items and prices),
the phone number,
the total
a callback link

Backend API looks up Seeds name by phone number
Sends PN via firebase - deep link with all the data
Seeds Wallet receives the deep link, shows payment page, where user can confirm transaction
Ideally this page shows the line items, who to send the payment to, and has a cancel button too
Once it is paid, wallet or backend call callback link to inform the hotel payment system that the payment has been made successfully.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

@n13 3 It is this still valid feature valid/required?


why the dim is 3651

Hi, guys. I am wonder why the dim is 3651 in the file "athena-decoder/examples/hkust/wfst_scores.txt" while the length of vocab is 3650. Looking forward to your reply.

It is default setting in Athena-team that <sos> and <eos> are the same and are always the last label in table.
So the scores of the last dim (3651) is for <eos>


'ngx-image-zoom' is not a known element

i was trying to use this lib but i got thi error:
error
Error: src/app/cms-components/product/product-images/product-images.component.html:4:3 - error NG8001: 'ngx-image-zoom' is not a known element:

If 'ngx-image-zoom' is an Angular component, then verify that it is part of this module.
If 'ngx-image-zoom' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.

component.html
<ngx-image-zoom
[thumbImage]="myThumbnail"
[fullImage]="myFullresImage"
[magnification]="1"
[enableScrollZoom]="true"
[enableLens]="true"
[lensWidth]="200">

component.js
public myThumbnail="https://wittlock.github.io/ngx-image-zoom/assets/thumb.jpg";
public myFullresImage="https://wittlock.github.io/ngx-image-zoom/assets/fullres.jpg";
config:
"@angular/core": "^12.0.5",
"ngx-image-zoom": "^0.6.0",
....

use lib-ngx-image-zoom tag

Yeah, the tag changed names in version 0.5.0 to try and align with recommendations from Angular. So like AdrainAgui says, it's called lib-ngx-image-zoom now.


Coin & Token amounts disappear for a short period after sending a token

Operation System
Windows10
Expected Behavior
Coin wallet & Token wallet amounts should remain visible after sending a fixed supply token
Current Behavior
When sending a fixed supply token, the TKL amount showing in your coin wallet disappears (goes to 0) for a short period of time and the number in 'holdings' for your fixed supply disappears for a short period of time. They both reappear at the same time.
Steps to Reproduce
Send a fixed supply token to someone else and wait 5 seconds and the amounts will disappear (coin wallet amount goes to 0), give it about 10-15s and the amounts will return.
Note the 0 amount in coin wallet up the top and the absence of an amount under 'Holdings'
https://i.gyazo.com/e919c5beabaffe72ebca6dbc947c86c1.png

This is a side-effect of Tokel being a UTXO-based blockchain, where unspent FSTs all get sent to the blockchain if there is only a single UTXO assigning them to your wallet address.
But the UX isn't great here so I am working to change our transaction handling to not be a 1-1 mapping of blockchain state so that it makes more sense to the user.


fix clippy lint

Rationale for this change
When I run clippy locally, I get the following warning. This PR fixes it.
error: redundant field names in struct initialization
   --> datafusion/src/physical_plan/hash_join.rs:392:13
    |
392 |             visited_left_side: visited_left_side,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `visited_left_side`
    |
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

What changes are included in this PR?
fix clippy lint error
Are there any user-facing changes?
no

Also fixed in https://github.com/apache/arrow-datafusion/pull/253/files

Cool, let's merge this @alamb .
Not sure why the clippy wasn't caught by the github CI workflow?

Ah I am seeing it is explicitly allowed:
cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
Bit weird that this is set on a global level, I think we should change that.


Fix typo in code block in quickstart docs.

Great docs! Minor typo fixed :)

Doh! Absolutely right - many thanks :)


⚠ ClamAV has degraded performance

In 4f536af, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 220a524.


How to forward request (when in ssr) error status code to ssr status?

Hello, this framework is very nice, I really like this framework, in particular, it supports Layout, I've used NextJS before, but he doesn't support Layout. And NextJS not support fetching data on top and inject data by root context.
Rakkas can request data in Layout.tsx and then inject it downwards, which is great, or I can use the built-in ErrorBoundary to handle how the request should be rendered in case of errors.
But I've also run into a problem with useQuery, that is, requests are not always 2xx, sometimes they may hit a 4xx, such as 404, which throws a RequestError, and I can control how it should render the error page by determining the RequestError instance, which is great. But it only controls how the error page should be displayed, not the status code of the SSR page, which always returns a 500 status code whenever an exception is thrown.

Here I mock a request that is not 2xx and it will throw RequestError.
// about.page.tsx
import { useQuery } from "rakkasjs";
import { FC } from "react";

class RequestError extends Error {
  constructor(message: string, public status: number) {
    super(message);
  }
}

const AboutPage: FC = () => {
  const data = useQuery("about", async () => {
    throw new RequestError("404 Not Found", 404); // mock request error, throw RequestError 404
  });
  return (

About

      {data.data.text}

  );
};

export default AboutPage;

// layout.tsx
// ..
<ErrorBoundary
        fallbackRender={({ error, resetErrorBoundary }) => (

An error has occurred

{error.message}
      // catch error
            <button
              onClick={() => {
                resetErrorBoundary();
              }}
            >
              Try again
            </button>

        )}
      >
       {children}
      </ErrorBoundary>

//..

For example, in ErrorRender provide a parameter res?: ServerResponse, res is optional, but in server side render is always non-null, then I can access NodeJS response and modify the response code via res?.status =

Hi! Thank you for your interest!
It is true that throwing from a query function during SSR isn't a good way to handle errors at the present. Error handling docs touches on it:

[...] it's probably best not to use exceptions for error handling.

It doesn't suggest any alternative but the easiest solution is to handle the error yourself without throwing like in this example.
If that's too much of a hustle, HatTip (HTTP server library that Rakkas uses underneath) provides another way to solve this: If your error defines a toResponse method that returns a Response object, it will be called to build the response. See this example. Rakkas docs don't provide much detail on HatTip, so you should probably check at least the main readme there to see what else is possible.
Also please note that both methods of setting the status code are "best effort". Since Rakkas does streaming SSR, it may be that the headers (and the status code) have already been sent by the time your component is rendered. It happens when your component is buried deep under multiple layers of Suspense boundaries. If correct status code is important, you should either disable streaming or set the status code by implementing a headers function.
Rakkas does disable streaming for bots automatically, so there should be no SEO problems.
Hope this solves your problems.

Thanks. ☺


How to insert JSONB values in Postgres database

Hi,
I would like to leverage FastCRUD to also insert columns that have JSONB types in Postgres.
I've been scanning the source code, but I don't see an example of this. None of the issues seem to match either.
Is there a way to have a complex type automatically converted to a json value for insert/update, and vice-versa for retrieval?
Thank you.

Can't you do the conversion prior to using it in the entity? Not sure how Dapper handles this type.

Hi,
Dapper has a mechanism to handle it through  SqlMapper.AddTypeHandler(). FastCrud however will consider it a Text field. Even if I convert it beforehand, I still need to have the serialized value converted to the proper column type e.g. '['serialized'::jsonb
It would be nice to be able to achieve a similar approach with FastCRUD by leveraging OrmConfiguration. At the moment my List Property is not even registered with the entity, which means I can't query for it.
I ended up using something like this.
 OrmConfiguration.GetDefaultEntityMapping<Workshop>()
                .SetProperty(p => p.Features, prop =>
                prop.SetDatabaseColumnName(nameof(Workshop.Features))
                );

And I created a sql statement
  InsertWorkshopSql = OrmConfiguration.GetSqlBuilder<Workshop>().Format(
                    $@"INSERT INTO {nameof(Workshop):T}({nameof(Workshop.Name):C},
                    {nameof(Workshop.Features):C})
                    values (@{nameof(Workshop.Name)}, @{nameof(Workshop.Features)})
                RETURNING *");

I have the proper type handler defined in Dapper, and so I can do a basic query.
 results = con.Query<Role>(InsertWorkshopSql , new Workshop
                    {
                        Name = workshopName,
                        Features = featuresList
                    });

The configuration that FastCRUD exposes should be extended to support custom types, I just don't have enough knoweldge of the code base to handle this.
Maybe if you can provide some direction on what would need to be done to support it?

I struggled with this issue as well when trying to use PostgreSQL’s date-range capabilities. The trick I discovered was to implement range and DateRange  SqlMapper handlers as you would for standard Dapper use and then manually register the members using the SetProperty method mentioned above.   This approach seems to force the custom fuel types to register.  Hopefully this saves someone else the time I spent deciphering this issue.


Add missing properties to executors/schedulers

Adds support for thread_priority to parallel_policy_executor.
Adds support for all currently available properties (hint, annotation, priority, stacksize) to scheduler_executor, if the BaseScheduler supports them.
Adds more verbose message when a property is not supported.

Fixed the inspect warning.


Java 11 project gives warning: SneakyThrowsRemover caused an Exception

Short description
I've created a simple Java 11 based project using Lombok, when I build it using Intellij I get a warning:
Warning:java: Error during the transformation of 'Main$Test'; post-compiler 'lombok.bytecode.SneakyThrowsRemover' caused an exception: java.lang.UnsupportedOperationException

Expected behavior
No warning should be issued
Version information

IDEA Version: 2018.2
JDK Version: JDK 11
openjdk 11-ea 2018-09-25
OpenJDK Runtime Environment 18.9 (build 11-ea+25)
OpenJDK 64-Bit Server VM 18.9 (build 11-ea+25, mixed mode)
OS Type & Version: Mac OS X, 10.13.6
Lombok Plugin Version: 0.19-LATEST-EAP-SNAPSHOT
Lombok Dependency Version: 1.18.2

Steps to reproduce

Set up a Java 11 environment
Clone this repository: https://github.com/dnno/java11-lombok-plugin
When you build the project (or run a "Rebuild") you should see the warning

Additional information
A Maven build does not produce this warning.

Has anyone had the chance to look at this?

Hey, we looked at this with a number of people here, including some of the Lombok authors.
First of all, the warning does not appear for you because you have maven warnings disabled in your repository. Adding:
			<configuration>
					<showWarnings>true</showWarnings>
				</configuration>

should solve that problem.
Secondly, we found out that this is actually a lombok bug related to the concept of Nest-based access control. We're going to file a bug at Lombok and we have an idea for a fix as well.

Should be fixed in the next release of lombok: https://github.com/rzwitserloot/lombok/commit/182cb0cb9e8db6341fb4633c3849b5e90ba6d088

@rspilker Cool! Keep up the good work!
I'll close it here.


Start Protocols and Start Traffic operation must be isolated

Is your feature request related to a use case? Please describe.
In case of BGP scalability we run one test after the other by incrementing the routes, once we reach higher route range say 8k above often time what happens is the IPv4 and V6 sessions doesn't  come up due to which  traffic apply fails and script terminates.
Manually we can bypass this failure by doing the following steps
Steps:
1.start protocol
2.check for protocol state
3. if still down, then do a restart down ( this feature is not currently supported in snappi, raised another request for this) or from DUT side you can do a fast reboot to resolve it
4. if all are up proceed to traffic apply
But in current snappi version since protocol and traffic starts at once back to back , there is no way to enforce Step 2 and 3 chronologically.
If a solution can be provided for this issue, that would be helpful.

@selldinesh : The requested feature is available as part of snappi==0.6.x, but ixnetwork implementation is in progress. Please let us know how fast you want this feature
@ashutshkumr : FYI

The sooner the better, this is needed along with restart down support.
These 2 support is needed for the test gap coverage cases to be implemented

This should address in https://github.com/open-traffic-generator/snappi/releases/tag/v0.7.3


Rails 4.1 upgrade

This is to keep the app on a supported version of Rails.
The companion deployment pull request is here.

/cc @boffbowsh @jamiecobbett @binaryberry

:+1: for this change, but I'll leave merging this to someone with access to alphagov-deployment

@benilovj merged - the companion PR does need merging, but I'll let you resolve that when you're back.


Made with HyperUI

Add a page "Showcase" to display projects / websites using HyperUI.

Thanks for the suggestion but I'm not interested in adding that at the moment.


[Question] shard.getWrappedEntry Method return arguments

How about return nil instead of err?
// shard.go

func (s *cacheShard) getWrappedEntry(hashedKey uint64) ([]byte, error) {
	itemIndex := s.hashmap[hashedKey]

	if itemIndex == 0 {
		s.miss()
		return nil, ErrEntryNotFound
	}

	wrappedEntry, err := s.entries.Get(int(itemIndex))
	if err != nil {
		s.miss()
		return nil, err
	}

       //return wrappedEntry, err
       return wrappedEntry, nil
}
`

Codecov Report

Merging #327 (19a4f6e) into master (8f80589) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   88.01%   87.50%   -0.52%
==========================================
  Files          15       15
  Lines         776      776
==========================================
- Hits          683      679       -4
- Misses         77       80       +3
- Partials       16       17       +1

Impacted Files
Coverage Δ

shard.go
84.16% <100.00%> (-1.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f80589...19a4f6e. Read the comment docs.


Final Milestone - JavaScript Group Capstone Project - PR

 JavaScript Capstone - WebPack ES6 API Jest
👋 Hi Dear CR!, It's @Ruthmy and @ITurres here 👋
In this project, we built an API-based web application, and so we created a movie site that uses the TV Maze API to get data about movies and the Involvement API provided by Microverse to listen to users' likes and comments. The site allows users to browse movies, view their details, and add likes and comments.

🖥 Website Goals:
The goals of this project were to:

Create a movie site that is easy to use and navigate.
Provide users with access to information about movies, including their summaries.
Allow users to interact with the site by adding likes and comments.

🎯 Project Goals:

[x] Use the Kanban board to divide and separately manage the project requirements as a group of small tasks to achieve the objective.
[x] Understand how to use medium-fidelity wireframes to create a UI.
[x] The site must use the TV Maze API to fetch data about TV shows.
[x] The site must use the Involvement API to allow users to add likes and comments on shows.
[x] Follow the GitFlow as a workflow to create and unify the different features of the project.
[x] Follow the best practices for HTML & CSS and JavaScript.
[x] Documented the work in a professional way.
[x] ES6 syntax implemented and project divided into modules.
[x] Configure WebPack 5 with Linters for HTML, CSS, JavaScript, and the JavaScript testing library Jest.
[x] The project has a home page showing a list of items (shows) that users can "like" and comment on.
[x] By clicking on the "Comments" button, a pop-up window appears with more information about the show, the existing comments about it, and the form to create a new comment.
[x] Counters for the number of shows displayed on the screen and for the number of comments each show has.
[x] Peer code reviews were performed for each of the delivered tasks, writing clear, professional, and respectful review comments for team members.
[x] Unit tests were performed with Jest to check the performance of the implemented counters.

🎥 Presentation Video - JavaScript Capstone
🚀 Live Demo Link

🛑Important Notes
README issues/page link

Once this branch is merged into the main branch, the Link will redirect to the issues page. However, at the moment, it will result in a 404 error due to the relative path.

Webhint:

As you might already be aware, It appears that the Webhint modules on GitHub Actions have been experiencing ongoing issues for approximately the last three weeks. As a result of these issues, the Webhint module has been removed from the general Linters.

Thank you for taking the time to review this PR ⭐!

If you require additional information or have any questions, please feel free to contact me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to assist you. 🎯

Hi @Owusu-Desmond! Thank you for reviewing this PR 😃! Happy weekend and happy coding!


Support for spawned processes/threads

Summary:
Jest implements a sandbox for every test allowing you to run tests in isolation, and within that sandbox allows you to modify module resolution, globals and so on without worrying how it will impact other tests. But if people spawn subprocesses or worker threads, the sandbox is broken out of, and you lose support for Jest’s features like mocks and fake timers. In addition, we’re unable to collect code coverage for spawned processes. This project would explore ways for Jest to intercept subprocesses or worker threads so it can provide the same features it does in the main process.One avenue to explore is if V8 coverage allows Jest to collect coverage

Issue: jest coverage misses subprocesses · Issue #5274 · facebook/jest

Level of complexity: Medium
Experience wanted:

JavaScript
Jest testing framework

Deliverables:

Support for code coverage in subprocesses/worker threads
Injecting Jest’s module mocking and resolution into the spawned children

We will not be completing this task during the fellowship


Upload files between to server

Hello, how can I use your library to upload file between to node.js server, so the scenario is to read from filesystem (by using path or stream or anything else ...) then your uploader will upload it to the another node.js server. Now I use socket.io-stream to send files between servers but your library has a lot of features that it is useful like (chunk size, progress event) and I want to use it in my app.

Hello!
Unfortunately, Socket.io-file doesn't support file sending between servers,
because it focused on data transmission from Web Client to Socket.io-server.
Inside, Socket.io-file-client uses browser specific APIs, which will not
work in Node.js environment.
However, recently I heard similar issue like you, someone want to intercept
or redirect data stream flow to memory, not the disk, so this feature could
be very considerable thing.
I'll let you know when I decide to put this in, if do, this could be
feature in Socket.io-client, will also support Node.js server.
Feel free to give any suggestion!
Best regards,
.modernator
On Tue, Oct 30, 2018 at 2:39 AM kar<EMAIL_ADDRESS>wrote:

Hello, how can I use your library to upload file between to node.js
server, so the scenario is to read from filesystem (by using path or stream
or anything else ...) then your uploader will upload it to the another
node.js server. Now I use socket.io-stream to send files between servers
but your library has a lot of features that it is useful like (chunk size,
progress event) and I want to use it in my app.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rico345100/socket.io-file/issues/19, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJ3iWqnUkEMN63eJnhGhF9HgdQ4L9w6Fks5upz1MgaJpZM4X_tF4
.

this is feature may solved task with sending file to google drive and  other cloud files storage , am I right?


Update a paper's title in README.md

thanks for opening a PR! you're right that the README is outdated and confusing about what papers are implemented in this repo. it turns out that many papers are implemented in this repo (not just the predicate invention one). I opened #1618 to clarify.


Enable SSL for frontend-environment:

This patch enables SSL mode for frontend-environments managed by the operator

/retest


Add support for credentials when building images from a remote source

Building an image by a URL interface does not contain the Authentication fields (as per #1667) as it is the case with the new stack by git repository interface. Adding an option for credentials would allow us to build images from the private repos as well. GitHub in particular allows supplying traditional style of credentials to its HTTPS URI<EMAIL_ADDRESS>and personal access token with or without the user name such as<EMAIL_ADDRESS>I have verified the following to be working as expected:
$ docker image build -t<EMAIL_ADDRESS>$ curl --unix-socket /var/run/docker.sock -X POST<EMAIL_ADDRESS>

GIven it has been five years and no movement, maybe it is reasonable to ping this and say I could really use this feature?


Licensing information is not accurate

_Required subscriptions and permissions
Before you get started with IB, you should confirm your Microsoft 365 subscription and any add-ons. To access and use IB, your organization must have one of the following subscriptions or add-ons:
Microsoft 365 E5/A5 subscription (paid or trial version)
Office 365 E5/A5/A3/A1 subscription (paid or trial version)
Office 365 Advanced Compliance add-on (no longer available for new subscriptions)
Microsoft 365 E3/A3/A1 subscription + the Microsoft 365 E5/A5 Compliance add-on
Microsoft 365 E3/A3/A1 subscription + the Microsoft 365 E5/A5 Insider Risk Management add-on_
This conflicts with the guidance at https://learn.microsoft.com/en-us/office365/servicedescriptions/microsoft-365-service-descriptions/microsoft-365-tenantlevel-services-licensing-guidance/microsoft-365-security-compliance-licensing-guidance#information-protection which states:
Microsoft 365 E5/A5/G5, Microsoft 365 E5/A5/F5/G5 Compliance and Microsoft F5 Security & Compliance, Microsoft 365 E5/A5/F5/G5 Insider Risk Management, and Office 365 E5/A5/G5, provide the rights for a user to benefit from Information Barriers.
Office 365 A3/A1 are mentioned in the first - which might be deliberate to allow educational customers to put barriers between staff and students or students and different classes of students.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2baec804-4a76-95ac-3595-985629448fd9
Version Independent ID: c0a5fb9d-93be-b448-5bf2-4c3bdd787b8e
Content: Get started with information barriers - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/information-barriers-policies.md
Service: o365-seccomp
GitHub Login: @robmazz
Microsoft Alias: robmazz

@mantis Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10206
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba  and should Office 365 E5/A5/A3/A1 be removed?

@mantis Thank you. It has been updated now.

@mantis Thanks for your feedback! New issues and pull requests for this content are closed while we update this content to support upcoming feature improvements.


Support specific split pane distribution from command line arguments

Hi,
Is there any way to support the following split pane distribution from command line argument?

I've tried the following:
wt.exe -p "Ubuntu-18.04" ; split-pane -H -p "Ubuntu-18.04"; split-pane -H -p "Ubuntu-18.04"
But it didn't work because the the split pane is always splited in relative to the previous pane.
Any idea how?

Not yet - for that we'll need to implement focus-pane, which is being tracked in #5464.
/dup #5464


Missing Pet Fox (Beaver transmog)

Hey, I love your plugin. I use it all the time and am constantly checking out peoples pets. I even right click when I know what pet it is just to see who it belongs to. I noticed there were a few of the pets missing, like the beaver transmogs and the quetzin. I think you updated the plugin recently because I noticed the quetzin now works which is great. I really appreciate all the time I'm sure you've put into this plugin and I don't want to sound ungrateful but I think the pet fox is still missing. The Beaver transmog I mean, I think the pet fox and pheasant need to be added, and a nice description on how to get them would be cool too. Thank you for your time

Hey, sorry I didn't see this, I'll get to adding them now!

There we go, it should be updated now. Let me know if you have any other thoughts/ideas for the plugin or if you ever see another pet missing it's info.
Thank you for the help, and for enjoying the plugin!

Hey thanks for fixing it. Shortly after you sent me those messages I saw
someone with a pet fox in Morytania and I right clicked it and saw that you
fixed it. Looking great thanks for the cool plugin. I'll definitely keep an
eye out for anything else
On Thu, Jun 27, 2024 at 1:42 PM microtavor5 @.***>
wrote:

There we go, it should be updated now. Let me know if you have any other
thoughts/ideas for the plugin or if you ever see another pet missing it's
info.
Thank you for the help, and for enjoying the plugin!
—
Reply to this email directly, view it on GitHub
https://github.com/microtavor5/PetInfoPlugin/issues/31#issuecomment-2195298598,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BI2FV6JUCPUIXJSVO76CPZTZJRFKFAVCNFSM6AAAAABIP35GP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGI4TQNJZHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


python: envoy_requests depend on a specific version of protobuf

Description: This PR introduces a requirement that consumers of envoy-requests must have protobuf==3.17 to prevent crashes. I've been able to consistently reproduce crashes in Python applications on the main branch by:

Making a virtualenv
Building + installing a wheel built from //library/python:envoy_requests_whl on main
Install protobuf==3.14 (previous version before envoy bump) or protobuf==3.16 (current version after envoy bump)
Run the following script
Crashes with

std::bad_optional_access on protobuf==3.14
segfault on protobuf==3.16

import google.protobuf.descriptor
from envoy_requests.common.engine import Engine
Engine.handle()

This succeeds when running protobuf==3.17, however, hence the version I've chosen to require.
I've narrowed this problem down to an indirect import of google.protobuf.pyext._message. Importing that module calls InitProto2MessageModule which does a lot of initialization, but I'm not sure which part causes the problem. I'm still struggling to understand how this all happens, so if anyone has any ideas I'd love to hear them!
Risk Level: Low
Testing: Documented above
Docs Changes: N/A
Release Notes: N/A

Re-running unit tests since I don't see any output as to the what the failure was in GitHub Actions.

closing since this isn't the right fix. see https://github.com/envoyproxy/envoy-mobile/pull/1506 for more details


Error in adjustViewBounds with true value

I have in the xml file the following:
android:adjustViewBounds="false"
But when I change the value to true I get that the property is not supported. How can I solve this?

@hdodenhof

You can't solve that as it is a known limitation as stated in the README.

@hdodenhof Umm, I understand. I had not read the limitations of the library before. Thanks for your help. Have you thought of this support for future versions?

After some more research I decided against support for other scale types (which would be required for supporting adjustViewBounds) for now.
While I doubt this it still an issue for you (sorry for the late reply), feel free to post more details so we can find a workaround if it actually still is.


enable winit default features so that egui_glow can pass cargo check

we can either fix this by exposing the x11/winit features to users of egui_glow or just enable the default features of winit. I went with the second option for now.
Closes https://github.com/emilk/egui/issues/2286

Hum. In https://github.com/emilk/egui/pull/1971 we disabled the default features to not force any default features onto users.

should i instead expose x11/wayland features in egui_glow -> egui-winit?
or just remove the cargo check --all-features for egui_glow crate?
sorry for late reply.


Pass current java.home if java9Home property is not set

Currently, we have only performance tests running in Java 8 JVM, which requires java9Home
property to be set. Given that all of our builds are running on Java 9+, we can get
java9Home from java.home instead of setting it manually. This can simplify TeamCity build
parameters.

Thanks @jjohannes !


Fixed a typo

Fixed a typo where the author of the article forgot to pluralize the noun 'message' after the 'are' verb.

Pump.


Travis times out for Go 1.12

See
https://travis-ci.org/google/syzkaller/builds/515442474?utm_source=github_status&utm_medium=notification
https://travis-ci.org/google/syzkaller/builds/515445018?utm_source=github_status&utm_medium=notification
Both of these builds reflect relatively anodyne changes; both pass with Go 1.11, but time out with the gometalinter step for Go 1.12.
I decided to leave these two PRs merged for now, since I couldn't see any reason why these in particular might be the root cause, but @dvyukov please feel free to back the changes out if you can track them down to Travis's failings.  (And if they are not at fault, please let me know what the issue is; I'm curious to know for the future!)

Related to #977
Generally if one of them passes, then the commit is good.
I am out of ideas. I've tried to tune GOGC, GOMAXPROCS, remove generated packages from analysis. golangci-lint claims to consume less memory and be faster, but I couldn't make it work so far.


ETE Authentication?

Is the new test environment configured to do authentication?
If not, when will it be?

ETE would be configured to do proper Authentication and Authorisation, and to allow ease of testing we would provide a User Interface which would let you create test users/ninos.

What do you mean 'would be'?
Aren't the APIs pointing to ETE now?

No.
We have 2 environments right now.
One is the LIVE/PROD hosted at _https://api.service.hmrc.gov.uk/self-assessment_ and which requires real/live NINOs and performs Authentication/Authorisation.
The Other is Sandbox hosted at _https://api-sandbox.tax.service.gov.uk/self-assessment_ and which is IP restricted, can be used with any well formatted NINO and doesn't performs Authentication/Authorisation.
Going forward, the Sandbox would be replaced with new testing environment ETE.

Ok. Sorry I may be being slow on the uptake but something isn't making sense.
If I use the APIs now, are they stateful? Can I build up a narrative/workflow using a dummy NINO and self employment business? Where the data I supply is persisted and I can interact with it?
Or are the APIs still talking to the old test system that returned canned responses regardless of what data I supply?
We were informed that on 1st march we would have access to the full set of MVP APIs on a new stateful test environment and that here it would be as live like as possible, so reflect the authentication and authorisation functionality too. Are we not there yet?

If these APIs are not taking to ETE, so are not stateful and cannot replicate live like behaviour including authentication and authorisation then the delivery date for when this is available is utterly critical for me.
I cannot emphasise enough how important access to that is. We need that date.

All APIs except for the calculations ones (Trigger and Retrieve) are Stateful in both environment listed above.

OK - so when will sandbox have authentication in it?

@P-Tracy  Sandbox would soon be release with ETE, which would have Authentication/Authorisation.

@P-Tracy can I close this issue?

sure


Feat/delegation approval endpoint

A fresh PR based on work and feedback from https://github.com/WebOfTrust/keria/pull/248

I will change the keri dependency to the 1.2.0-dev5 tag once it is available.
Adds delegation logic to delegating.py and tests in test_delegation.py
Adds "/identifiers/{name}/delegation" end point per review comments from previous PR.
Passes IdentifierResourceEnd, similar to how credentialing.py, per previous PR review comment.
Only addresses the interaction case. A separate issue can be generated for handling/testing the rotation case.
Extends long running 'delegation' operation to handle delegator approval case.
Integration tested with updates to signify-ts which adds support for the delegation endpoint.

You need to rebase with main to resolve the conflict.


Early exit missed?

Isn't early exit missed here? As well as below, where we refuse query to a blacklisted domain but we still go, resolve and respond with ip later?
https://github.com/qdm12/dns/blob/4321cd7d2b8f463eee1ee9c296d4d824c78cffc7/pkg/dot/handler.go#L37
https://github.com/qdm12/dns/blob/4321cd7d2b8f463eee1ee9c296d4d824c78cffc7/pkg/dot/handler.go#L46
https://github.com/qdm12/dns/blob/4321cd7d2b8f463eee1ee9c296d4d824c78cffc7/pkg/dot/handler.go#L61

Thank you a hundred times. How did I not see that. Plus I made the copy pasta mistake on both dot and doh 🤮
It's now fixed on the branch/image tag v2.0.0-beta, I will fix it on master and v1.x.x branches later.


Adding explicit dependencies in buyer and seller modules.

E.g. removing firewall rules early causes healthcheck failures.
For some reason Terraform cannot proceed in destroying MIGs which are in "updating" state.

Hey @maciejkowalczyk thanks for this PR. Can you run builders/tools/pre-commit so we can import it without modification? I tested it out and everything seems to be working well.

LGTM. Available as of release 2.3.0. Closing this PR.
https://github.com/privacysandbox/bidding-auction-servers/blame/main/production/deploy/gcp/terraform/modules/buyer/service.tf#L61


react-native bundle command --bundle-output options not working

# Issue Description
I run bundle command a few times and i realized that it do not bundle file main.jsbundle.
I have to run command npm start && curl http://localhost:8081/index.android.bundle?platform=android -o ./android/app/src/main/assets/index.android.bundle to copy bundle source to my assets file
# Expectation
when i run command react-native bundle, it should bundle main.jsbundle file and copy to the path as --bundle-output option.
 This issue is being closed because {:search=>"repo:facebook/react-native is:open is:issue updated:<2017-05-25 -label:"Good First Task" -label:"Help Wanted" ", :message=>"it has been inactive for a while"}. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


feat: link to external typedocs

The TypeDoc docs describe how to link to third party symbols so this PR adds the beginning of support for that.
It adds a plugin with links to the docs of a few well-known types which will be used to link through to their definitions in generated docs.
It also adds the ability for third party modules to declare their own docs in their manifests.  For example for @multiformats/multiaddr to make use of the Multiaddr interface linkable in the documentation of other modules, it needs to add the following to it's package.json:
{
  // ... other stuff
  "docs": {
    "Multiaddr": "https://multiformats.github.io/js-multiaddr/interfaces/index.Multiaddr.html"
  }
}

Creating as a draft because we need a bit more done on this before it's ready.

[ ] Is "docs" ok for a package.json field?  Should be something else?
[ ] We should generate the "docs" field for aegir-managed modules during the release process, this will probably involve:
- Checking for the presence of a "docs" npm script in the current project to infer that docs will be generated
- Adding a typedoc plugin or similar that collects the locations for generated types
- prefixes them with the eventual gh-pages url for the current repo
- Adds those links to the package.json before publish
[ ] It needs testing with modules that have more complex exports

Thanks for getting this started @achingbrain , I assume this is in relation to https://github.com/libp2p/js-libp2p/pull/1476#issuecomment-1339932957

Is "docs" ok for a package.json field? Should be something else?

perhaps externalDocs considering we will be generating docs based on the exports map.

Adding a typedoc plugin or similar that collects the locations for generated types

Since TypeDoc assumes that if a symbol was referenced from a package, it was exported from that package we may have to enforce this as well in the plugin or at least make mention of it somewhere in the generation process.

It needs testing with modules that have more complex exports

could you provide an example repo to test this with? Not sure what you mean.

Is "docs" ok for a package.json field? Should be something else?

I've changed the implementation a bit, now it write a JSON file into dist that contains the symbol -> url mappings, the reason being updating the package.json file gets a bit messy during releases as we change the head of master.  This will affect semantic-release's attempt to abort a release if the remote master is ahead of the CI clone.
Instead the mapping file goes into the dist folder during release which is ignored by version control.

We should generate the "docs" field for aegir-managed modules during the release process

This is done now.

It needs testing with modules that have more complex exports

I've tried it with @libp2p/interface-* (a complex monorepo), @libp2p/tcp (simple typescript) and multiformats (typed ESM).


Improve spriteAnimation by spriteName

So I implemented this functionality and after writing my tests I noticed, much to my surprise, that it was already there 🤣
This PR adds api docs, some additional tests and closes #1076.

Right, this was implemented in #1091, but it looks like I let the lack of doc-comments slip by me.


Turned every image to .webp

🌆 Turned every image to .webp

Every image was compressed (lossless) to improve performance (this is related mostly to #14).
Every image was turned from either .png or .jpg/.jpeg into .webp.
Removed unused images.

I know this is a "major" change as it has more than 400 files changed. But I think this will help the site quite a bit ;)

No big changes can be seen.


feat: manager config model add is_boot key

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

manager config model add is_boot key

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1025 (b7bde8d) into main (dfb78e0) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   45.93%   45.95%   +0.02%
==========================================
  Files         128      128
  Lines        9139     9139
==========================================
+ Hits         4198     4200       +2
+ Misses       4468     4466       -2
  Partials      473      473

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.95% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_conductor.go
56.91% <0.00%> (-0.37%)
:arrow_down:

client/daemon/peer/piece_broker.go
88.88% <0.00%> (+3.70%)
:arrow_up:

cdn/supervisor/progress/progress.go
97.01% <0.00%> (+5.97%)
:arrow_up: