an error about parse_if

I want to use migraphx-driver to test a model but an error occurs in migraphx::parse_onnx. The migraphx is from commit f2531606c266dd548fee59f242849615cab7f613
the command I used:/opt/rocm/bin/migraphx-driver perf TextLinePred_0722_v1.onnx
the outputs: src/onnx/parse_if.cpp:72: parse: PARSE_IF: then and else sub_grahps must have same output shapes!
the model link: https://drive.google.com/file/d/18p1AAdjCA3kr1zd7lkRfmfcFOC7layrW/view?usp=sharing

This looks related to a similar issue we've been seeing for ResNext50. There's a PR in progress for the If operator that needs more work. @TedThemistokleous

Potentially. This looks like this was before we added the fix Charlie and I did with our input constants as well. Let me look at the model on netron and see why this is failing.

Confirmed its another issue with IF being parsed in but shapes not interpreting outputs based on stride
module: "If_641_else"
If_641_else:@0 = identity(main:@637) -> float_type, {1, 3, 1, 1}, {3, 1, 1, 1}
If_641_else:@1 = @return(If_641_else:@0)

module: "If_641_if"
If_641_if:@0 = squeeze[axes={2}](main:@637) -> float_type, {1, 3, 1}, {3, 1, 1}
If_641_if:@1 = @return(If_641_if:@0)

terminate called after throwing an instance of 'migraphx::version_1::exception'
  what():  /code/AMDMIGraphX/src/onnx/parse_if.cpp:74: parse: PARSE_IF: If_641 then and else sub_grahps must have same output shapes!
Aborted (core dumped)
root@c285b5e687d8:/code/AMDMIGraphX/build#

The branch you tried this on @qianqing13579 checks strict shapes. It's an issue we're currently working on with our shapes IF operator as the output case you're hitting requires dynamic output. We've seen this similar issues in a few other model's we've tested (#1283).

@CharlieL7 ,@TedThemistokleous , I think there is a bug in migraphx. the IF operator definition(https://github.com/onnx/onnx/blob/main/docs/Operators.md#If) says that The number of outputs must match the number of outputs in the else_branch instead of they must have same output shapes!so the exception code of src/onnx/parse_if.cpp:74 should be removed,and then the model can run successfully

@qianqing13579  good news this is completed and needs to finish up review.

hi @qianqing13579 , Ive gotten past the error with parse_if and fixed this issue.
I was able to run your network with the latest fix before it's gone into our develop branch
Here's a breakdown of the results when running
bin/driver perf  ~/Downloads/TextLinePred_0722_v1.onnx  --input-dim @src 1 3 25 25  --gpu
Summary:
gpu::convolution: 7.38415ms / 39 = 0.189337ms, 68%
gpu::miopen_fusion: 1.74431ms / 25 = 0.0697724ms, 16%
gpu::code_object::add_relu_kernel: 0.443138ms / 22 = 0.0201427ms, 5%
gpu::code_object::add_add_relu_kernel: 0.226756ms / 11 = 0.0206142ms, 3%
gpu::code_object::sub_mul_add_kernel: 0.211109ms / 10 = 0.0211109ms, 2%
gpu::code_object::concat_kernel: 0.199436ms / 10 = 0.0199436ms, 2%
load: 0.131432ms / 166 = 0.000791762ms, 2%
hip::hip_copy_literal: 0.120674ms / 139 = 0.000868155ms, 2%
gpu::code_object::gather_kernel: 0.0944559ms / 4 = 0.023614ms, 1%
gpu::code_object::contiguous_kernel: 0.0790783ms / 4 = 0.0197696ms, 1%
gpu::gemm: 0.0789602ms / 1 = 0.0789602ms, 1%
broadcast: 0.0617541ms / 59 = 0.00104668ms, 1%
gpu::code_object::concat_add_relu_kernel: 0.0426691ms / 2 = 0.0213346ms, 1%
slice: 0.0276975ms / 25 = 0.0011079ms, 1%
gpu::pooling: 0.0273466ms / 1 = 0.0273466ms, 1%
gpu::code_object::reduce_kernel: 0.0211819ms / 1 = 0.0211819ms, 1%
reshape: 0.00837126ms / 9 = 0.00093014ms, 1%
@param: 0.00260844ms / 4 = 0.00065211ms, 1%
transpose: 0.0024983ms / 3 = 0.000832767ms, 1%
step: 0.00231824ms / 2 = 0.00115912ms, 1%
squeeze: 0.00202164ms / 2 = 0.00101082ms, 1%
multibroadcast: 0.0013198ms / 1 = 0.0013198ms, 1%
check_context::migraphx::version_1::gpu::context: 0.00102604ms / 1 = 0.00102604ms, 1%
hip::hip_allocate_memory: 0.00095902ms / 1 = 0.00095902ms, 1%

Batch size: 1
Rate: 129.748/sec
Total time: 7.70722ms
Total instructions time: 10.9153ms
Overhead time: 0.143831ms, -3.
[TestLinePred_0722_v1_output.txt](https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/files/10550667/TestLinePred_0722_v1_output.txt)
20805ms
Overhead: 2%, -42%

I've attached a longer log of the output too.


Enforce names in map_partitions

This ensures that the names of the partitions match the column names
given in map_partitions calls
Fixes #620
Fixes #627

Merging soon if no comments.

Merging soon if no comments.


Time out a readline operation?

Is there a way to time out an Editor::readline() operation? That is, make it so that if the user doesn't enter anything within a time limit (say, 5 minutes), have readline() return with an error of some sort?

No.

How difficult would it be to add this?
Or is there a way I could emulate it, by spinning up a second thread and running a timer on it, or something like that?

You need to fix these calls:

https://github.com/kkawakam/rustyline/blob/master/src/tty/windows.rs#L118 on Windows
https://github.com/kkawakam/rustyline/blob/master/src/tty/unix.rs#L337 on Unix.
On unix, when a single ESC is expected, we use poll:
https://github.com/kkawakam/rustyline/blob/master/src/tty/unix.rs#L347
So you can do the same at line 377 with another/custom timeout.
And return KeyPress::Ctrl('C') for example.

And it seems linefeed already supports what you want.

Thank you for the suggestion! This works well enough for me for now.

See also #126, which subsumes this.


Initial flow implementation in mattermost-webapp

Summary
Initial flow implementation in mattermost-webapp (With some small examples of usage)
Checklist

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed

I going to close this until we decide to go for typescript or not.

fair enough... other projects will have no problem using typescript, as long as the mattermost-redux project still uses flow, but provides additional typescript definitions.


[doc] Update FPGA Synthesis Paragraph in Intro

Clarify FPGA register file situation in introduction.
Signed-off-by: ganoam<EMAIL_ADDRESS>

LGTM, too. Thanks @ganoam .


[BUG] On iPad , Keysign pair device screen , QRCode too small on landscape mode

iPad Keysign pair device screen , when it is in landscape mode , QRCode is too small , my iphone can't scan it.

Fixed in PR #125


Add my-name(Inayat) to the list of contributors

@Inayat61 Congratulations your PR is merged.

@allcontributors add @Inayat61 for code.


Does not subtract correctly?

What's the result of 3-1?

I am not sure if this is the expected result.

No that's a bug. The parser is doing something special with -x/-1 but I don't remember the details why it triggers in that case. I will check that asap.

That should be fixed in the upcoming 0.3.1
The original reasoning was to allow to pass -2 to a function parameter without parenthesis e.g abs -2 but it can bring too much confusion if you start to have x-2 in that case. So I have removed the ability to pass a unary negative without parenthesis to a function.


Wont open files

Anytime I go to edit my file, I'll do as it says. Open the game directory and the save files. I click on the save file I want and get this message every time.

Could you please share an affected save file?

Github doesnt let me upload the SAV File

You can attach a zip with the .sav file included.

Save that wont load.zip

It's the new map. I get the same error when loading a save from the lake valley map. The pine valley map saves still work as expected.

It's the new map. I get the same error when loading a save from the Lake Valley map. The pine valley map saves still work as expected.
At first I posted this comment before thinking to check whether they had changed the format on all save files, so I went back and opened one of my saves from a Pine Valley map, then saved it again to make sure it was saved with the most recent version. And it still works on railroad.studio as expected. So pretty sure it's saves from the new map causing this.

Files can now be opened in RS. See #29 for issues with exporting.


Cleaning Codebase

I want to work on cleaning codebase, please assign issue to me

Thank you for wanting to take up this issue @saurabhbakolia! Assigning it to you!

Hi, may I work on this, and could u specify the description of what exactly the goal, the title seems abstract, should I modularize it?

Yes we still need work on this @iamrahulrnair! The current code base is pretty inconsistent in terms of syntax, spaces, commas, semi-colons. Do you have anything in mind?

It would also be helpful to get rid of unused old functions that are commented. And add better comments describing what existing functions do. Some of them are missing that.

@KossakowskaKarolina Would you like to work on this issue?

@PrimalPimmy Yes, I can work on this issue, just need a few details for clarification. Which files should be included in this assignment? All of the html, css and js files? What should I do with files marked as old? Is there any specification in general that I should follow? Any clues would be appreciated :)

@KossakowskaKarolina I merged a PR that changes a few files and folder structure. you can update your fork accordingly :3 . Also, it may be nice if any spam comments are removed. I would suggest keep the .old files for now, I'll let you know when they are not needed.

@PrimalPimmy Ok, I think I got it :) Would you assign me to this?

Sure!


Remember last used category tab

Describe your suggested feature
There should be an option to set so that the app opens in the last used category tab instead of the default.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 2.0.0.
[X] I will fill out all of the requested information in this form.

what if a novel has more than one categories?

For example, if I close the app with this category selected, then the next time I open the app, it should open back up with the same category. Or make an option to select which category the app should open in.


auto update sbt version

demo https://github.com/xuwei-k/setup-sbt/pull/1

remote: Permission to sbt/setup-sbt.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/sbt/setup-sbt/': The requested URL returned error: 403
Error: Process completed with exit code 128.

😢
https://github.com/sbt/setup-sbt/actions/runs/11607879226/job/32322083207#step:3:18


Playbook gets stuck on dialog box for bsdinstall if zroot exists

The playbook hangs and never completes during the bsdinstall process run by depenguin_install.sh
Connecting to the mfsbsd image and running ps aux shows a process
dialog --title ZFS Configuration --backtitle FreeBSD Installer --hline --ok-label Ok --no-cancel --inputbox zroot is already taken, please enter a name for the ZFS pool \011(Or confirm using the same name by just pressing enter) 8 80 zroot

How do we pass enter to that dialog if it happens?

@click0 uses a background tmux session as outlined here
https://github.com/click0/ansible-freebsd-install-on-zfs-lite/blob/main/tasks/install_freebsd.yml

We could also set BSDINSTALL_LOG (Default: "$TMPDIR/bsdinstall_log") and use ansible to watch for text?
Also use expect to give response, with empty value being same as
responses:
'which text:': ''

@Click0 approach with tmux works, and then tmux send-keys to pass in ENTER


GridFieldDetailForm_ItemRequest wants to redirect but displays error

Affected Version
asyncphp/doorman                          3.0.0              Child process management
jeremeamia/SuperClosure                   2.3.0              Serialize Closure objects, including their context and binding
monolog/monolog                           1.23.0             Sends your logs to files, sockets, inboxes, databases and various web services
mpdf/mpdf                                 v6.1.4             A PHP class to generate PDF files from HTML with Unicode/UTF-8 and CJK support
phpunit/phpunit                           5.7.27             The PHP Unit Testing framework.
silverstripe/recipe-cms                   1.0.3              SilverStripe recipe for fully featured page and asset content editing
silverstripe/recipe-plugin                1.1.0              Helper plugin to install SilverStripe recipes
silverstripe/subsites                     dev-master f8f39c1 Run multiple sites from a single SilverStripe install.
stevie-mayhew/hasoneedit                  dev-master cf9cf6a Allows editing the fields of a has_one object directly in the CMS
symbiote/silverstripe-gridfieldextensions 3.1.1              A collection of useful grid field components
symbiote/silverstripe-queuedjobs          4.0.5              A framework for defining and running background jobs in a queued manner
symfony/polyfill-php56                    dev-master ebc999c Symfony polyfill backporting some PHP 5.6+ features to lower PHP versions
symfony/polyfill-util                     dev-master e17c808 Symfony utilities for portability of PHP codes
tractorcow/silverstripe-fluent            4.0.0-rc1          Simple localisation for Silverstripe
unclecheese/betterbuttons                 dev-master eeeb5b4 Adds new form actions and buttons to GridField detail form for usability enhancements.
undefinedoffset/sortablegridfield         2.0.0-beta2        Adds drag and drop functionality to SilverStripe 4.x's GridField
wazaari/monolog-mysql                     v1.0.4             A handler for Monolog that sends messages to MySQL
zendframework/zend-authentication         2.5.3              provides an API for authentication and includes concrete authentication adapters for common use case scenarios
zendframework/zend-eventmanager           3.2.0              Trigger and listen to events within a PHP application
zendframework/zend-ldap                   2.8.0              provides support for LDAP operations including but not limited to binding, searching and modifying entries in an LDAP directory
zendframework/zend-session                2.8.3              manage and preserve session data, a logical complement of cookie data, across multiple page requests by the same client
zendframework/zend-stdlib                 3.1.0

Description
Shouldn't SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest catch a possible redirect in the edit function?
It calls $form = $this->ItemEditForm(); and uses it in output immediately:
    $form = $this->ItemEditForm();

    $return = $this->customise(array(
        'Backlink' => $controller->hasMethod('Backlink') ? $controller->Backlink() : $controller->Link(),
        'ItemEditForm' => $form,
    ))->renderWith($this->getTemplates());

The ItemEditForm method can return a Form instance but it can also return a HTTPResponse instance.
For me, this results in the following error:
[Emergency] Uncaught BadMethodCallException: Object->__call(): the method 'forTemplate' does not exist on 'SilverStripe\View\ArrayData'
This error occurs in my setup because I have subsites and a modeladmin with dataobjects that are linked to 1 subsite. So in the modeladmin I filter the list of the gridfield by SubsiteID. Now, when I click on a row in the gridfield of the modeladmin to edit the record I go to the editform with a URL like http://localhost/admin/mydataobjects/MyDataobject/EditForm/field/MyDataobject/item/1/edit.
Until now, all is fine. Then I use the Subsite modules' switch in the top left corner of the CMS to switch to another Subsite. In this Subsite, MyDataobject with ID 1 is not part of the ModelAdmins' list.
The page gets refreshed but because the URL still is http://localhost/admin/mydataobjects/MyDataobject/EditForm/field/MyDataobject/item/1/edit but MyDataobject isn't in the list of the gridfield anymore I get the BadMethodCallException originating from the renderWith. I think this should be caught so the redirect to the ModelAdmin as instructed by the ItemEditForm method takes place (by returning $form immediately if != instanceof Form?)
Steps to Reproduce
See above

The ItemEditForm method can return a Form instance but it can also return a HTTPResponse instance.

I certainly wouldn’t expect a method named ItemEditForm() to be returning an HTTPResponse object, but it appears that it does:
https://github.com/silverstripe/silverstripe-framework/blob/9f4c83607212211c90860ead6da385a6c612bb43/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php#L170-L176
My initial thought is that GridFieldDetailForm_ItemRequest::edit() and view() should perform the checks for whether the record can be found (and whether canView() passes) before calling ItemEditForm()...


[CI] Add MKLML build and test

added mklml build and test
removed tests/python/gpu/test_forward.py, which will be covered in integration test.
used a new version pip instead of pip 1.5.4 shipped with ubuntu.

@piiswrong please have a check

@piiswrong added back test_forward. should be ready to merge.


KeyError: "The name 'batch_join:0' refers to a Tensor which does not exist. The operation, 'batch_join', does not exist in the graph."

Hi,
I am facing the issue when running the real_time_face_recognition.py script,
File "/mnt/work/rna_payload/ros2_ws/build/video_analysis/video_analysis/facenet/contributed/face.py", line 86, in identify
face.embedding = self.encoder.generate_embedding(face)
File "/mnt/work/rna_payload/ros2_ws/build/video_analysis/video_analysis/facenet/contributed/face.py", line 128, in generate_embedding
images_placeholder = tf.compat.v1.get_default_graph().get_tensor_by_name("batch_join:0")
File "/home/jaiganesh/.local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3972, in get_tensor_by_name
return self.as_graph_element(name, allow_tensor=True, allow_operation=False)
File "/home/jaiganesh/.local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3796, in as_graph_element
return self._as_graph_element_locked(obj, allow_tensor, allow_operation)
File "/home/jaiganesh/.local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3838, in _as_graph_element_locked
"graph." % (repr(name), repr(op_name)))
KeyError: "The name 'batch_join:0' refers to a Tensor which does not exist. The operation, 'batch_join', does not exist in the graph
May i know how to fix this issue?

some body resolve this issue?


Request to provision MS learning pathways template failed

Describe the issue
Your request to provision "Microsoft 365 learning pathways" template failed!
The remote name could not be resolved: '***-admin..com'
We use custom SharePoint Admin URL. From the exception it looks like it is failing to find the correct SP Admin URL.
Expected behavior
MS Learning Pathway SharePoint site should be provisioned.
Details (please complete the following information):

PnP Correlation ID: 668396e8-6d72-4099-b978-800614542eaa
Reference Template: https://lookbook.microsoft.com/details/3df8bd55-b872-4c9d-88e3-6b2f05344239
Primary language of the target tenant: English
Are you using a Tenant Global Admin account to provision the template: Yes

Additional context
Add any other context about the problem here.

Hi,
Thanks for using the Look Book site. It looks like you are using a vanity domain for your tenant. Unfortunately, vanity domains are not supported by the PnP Provisioning Engine. Eventually, you can manually setup the template following this document: https://docs.microsoft.com/en-us/office365/customlearning/custom_manualsetup. Thanks.

Thanks @PaoloPia i was able to setup MS learning pathways site manually. however, all the supporting pages like Get-started-with-Microsoft-365.aspx were not created. the home page is also blank. How do i setup these pages. Only 2 pages: CustomLearningAdmin.aspx and CustomLearningViewer.aspx were created with the manual steps.


Buffer signing incorrectly serializes payload

The documentation states that payload could be an object literal, buffer or string but this does not appear to match the implementation. The following code incorrectly transforms the buffer into a JSON object, instead of serializing it as-is.
let jwt = require("jsonwebtoken");
let payload = Buffer.from("TkJyotZe8NFpgdfnmgINqg==", "base64");

console.log(payload);

let token = jwt.sign(payload, "signing key");

console.log(token);

Expected behavior: payload is the 16-byte buffer provided.
Actual behavior: payload is {"0":78,"1":66,"2":114,"3":162,"4":214,"5":94,"6":240,"7":209,"8":105,"9":129,"10":215,"11":231,"12":154,"13":2,"14":13,"15":170,"iat":1465815291}
Adding the noTimestamp option makes no difference (besides removing the timestamp).

Thank you very much for reporting this. I found the issue and solved in v7.1.6


Example Dockerfile

Hi,
I was wondering if you have an example docker file I can use with Octo.
Thanks a lot!

We don't have a docker unfortunately, but you should be able to create a working python environment using the install instructions


Run local tests with run-test262

First commit is #579.

Love this!

I'll go ahead and land this because this whole exercise ultimately is so I can add an expect-fail test for #567 :-)


Support paths on the LND URL

Link this PR to an issue
Fixes #884
Type of change (Remove other not matching type)

New feature/bugfix (non-breaking change which adds functionality)

Describe the changes you have made in this PR -
Currently we replace the path - assuming that the REST API runs on the root path.
This change now appends the LND API path
How Has This Been Tested?
Tried to add a new account which was mentioned on twitter.

Can you describe a way to test this? Could add a test later on.

Not sure if it's worth creating a pure unit-test for this. Would rather create an integration test. What do you think? Could be add a test-env with a path?

I think both is not so easy to setup. the unit test would need some mocks and the integration test needs some non default lnd server setup.
I would leave it for now 🙈


Create Wrapper for SimplySql for easier sql pipeline

For easier pipeline input to sql databases, create a wrapper for SimplySql that allows exactly that. In Detail:

[x] Allow Pipeline input
[x] Create table automatically, if not existing
[x] Always create an update statement
[x] Allow commits/transactions every n records
[x] Allow Hashtable or PSCustomObject input
[x] convert pscustomobject or hashtable in columns in compressed json
[x] create new columns, if needed and wished

In testing I have fixed a problem with same column names but with spaces, which should be separate columns.

Also test boolean values in an object

All tests successful, changes are committed into main branch and closing this for now.


panic: !rep->hae_disconnected_previously at ha_entrypoint_state_cb() when a client app re-started too fast

When a client app re-started immediately on the same endpoint - the following panic is observed:
./c0rm<PHONE_NUMBER>084578698<PHONE_NUMBER>2460497882 -y
success! object deleted!!
c0rm success
./c0rm<PHONE_NUMBER>946530277<PHONE_NUMBER>113976076 -y
motr[05254]:  69f0   WARN  [ha/link.c:1285:ha_link_outgoing_fop_replied]  rc=-67 nr=1 hl=0x238d7b0 ep=<IP_ADDRESS>@o2ib:12345:1:1 lq_tags=(confirmed=2 delivered=2 next=2 assign=4)
motr[05254]:  69f0   WARN  [ha/link.c:1289:ha_link_outgoing_fop_replied]  old_rc=0 old_nr=0 hl=0x238d7b0 ep=<IP_ADDRESS>@o2ib:12345:1:1
motr[05254]:  68f0  FATAL  [lib/assert.c:50:m0_panic]  panic: !rep->hae_disconnected_previously at ha_entrypoint_state_cb() (ha/ha.c:310)  [git: 2.0.0-307-17-g7686dc3]
Motr panic: !rep->hae_disconnected_previously at ha_entrypoint_state_cb() ha/ha.c:310 (errno: 0) (last failed: none) [git: 2.0.0-307-17-g7686dc3] pid: 5254
Motr panic reason: HA has already decided that this process has failed. There is no good reason to continue doing something, and there is no code yet to handle graceful shutdown in this case. Let's just terminate the process and let HA do it's job.

@andriytk  can you confirm if you have seen this issue recently? can we close this?

@andriytk yes, @mssawant's analysis says that this issue is not seen in recent builds. Please check https://jts.seagate.com/browse/EOS-25567?focusedCommentId=2235623&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-2235623 in JIRA. i just wanted to confirm as you are the reporter for this issue. thanks.

I wonder if it was tested by the scenario that is described above in the issue description.

Mandar Sawant commented in Jira Server:

This is not reproduced in the latest several deployments and expected to be fixed.

Vaibhav Prakash Paratwar commented in Jira Server:

[~520414] can you please help here? is this issue seen in recent builds?

It's seen on the sage-2.1 branch installed on the Sage prototype cluster - yes. If it is fixed in the main branch - let me know the commit id which fixes it and is not present in sage-2.1 branch so that I could cherry pick it there. Thanks.

@andriytk, Kubernetes branch is now merged to main and hctl bootstrap is working as well, can you please try to rebase sage branch on cortx-hare main branch and try? cc @vaibhavparatwar .

Pavan Krishna Thunuguntla commented in Jira Server:

This particular panic was fixed in [EOS-19409: motr-mkfs fails with Motr panic: !rep->hae_disconnected_previously by mssawant · Pull Request #1586 · Seagate/cortx-hare (github.com)|https://github.com/Seagate/cortx-hare/pull/1586]
[~931950] please confirm with latest build and update it.

Supriya Chavan commented in Jira Server:

A reference file for output of mcp utility:
[^mcpfile.log]

Supriya Chavan commented in Jira Server:

.

Supriya Chavan commented in Jira Server:

This particular panic was fixed in [EOS-19409: motr-mkfs fails with Motr panic: !rep->hae_disconnected_previously by mssawant · Pull Request #1586 · Seagate/cortx-hare (github.com)|https://github.com//pull/1586]

Supriya Chavan commented in Jira Server:

.


Master

sorry, I merged branch to master directly it seems.

PR deployed at: https://pr42-app-noblocknoparty.surge.sh


split up the struct by domain

also ensure we satisfy the interface

gonna need a bot to tell me I need to sign it @duglin

LOL just get in the habit of signing all of your commits  :-)

Split up, because I believe in modularity, and while we may not agree on the totality of the interface yet, let's try to stay organized.

LGTM


RK3588S rknnlite版本1.4升级到1.5.2，yolov5推理速度变慢

硬件：RK3588S
软件：

rknn_toolkit_lite2-1.5.2-cp39-cp39-linux_aarch64.whl
rknpu2

升级命令如下：
升级rknpu2
cp rknpu2/runtime/RK3588/Linux/rknn_server/aarch64/usr/bin/rknn_server /usr/bin/rknn_server
cp rknpu2/runtime/RK3588/Linux/librknn_api/aarch64/librknnrt.so /usr/lib/librknnrt.so
cp rknpu2/runtime/RK3588/Linux/librknn_api/aarch64/librknn_api.so /usr/lib/librknn_api.so

代码如下：
rknn_handle = RKNN(verbose=False)

    rknn_file = "weights/FastestDet.rknn"
    ret = rknn_handle.load_rknn(rknn_file)
    if ret:
        color_print("Failed load rknn model: {}".format(rknn_file), "red_bg")
        sys.exit(-1)

    ret = rknn_handle.init_runtime()
    if ret:
        color_print("Failed init rknn runtime!", "red_bg")
        sys.exit(-1)

    img_file = "data/0.jpg"
    cv_img = cv2.imread(img_file)
    color_print(">>> cv_img: {}".format(cv_img.shape))
    h0, w0, _ = cv_img.shape

    resize_img = cv2.resize(cv_img, (352, 352))

    for i in range(100):
        start_t = time.time()
        output = rknn_handle.inference([resize_img])[0]
        mid_t = time.time()
        print(">>> forward cost time: {:.3f}ms".format((mid_t-start_t)*1000))
        confidence, bbox, category = process(output, 0.65, w0, h0)
        index = nms_boxes(bbox, confidence, 0.45)
        end_t = time.time()
        color_print(">>> single frame: {} cost time: {:.3f}ms".format(resize_img.shape, (end_t-start_t)*1000))

如果在init_runtime中添加target="rk3588"参数，会报错如下:
librknn_api.so: undefined symbol: rknn_set_core_mask

如果不指定target参数，会正常运行，但是速度会慢2-3倍，请问是什么原因？

Same issue, why we can't specify RK3588S as the target?

I've got same here, please let me know if someone managed with it.
Thanks in advance

@MHGL @rudimytro @daniilino
Try to follow the instructions below:

Clone the rknpu2 repository: git clone https://github.com/rockchip-linux/rknpu2.git (if you didn't install it)
Copy the shared lib file to the lib dir: sudo cp rknpu2/runtime/RK3588/Linux/librknn_api/aarch64/librknnrt.so /usr/lib/librknnrt.so

This should solve your problem.

@Guemann-ui thank you for your response, I did move the librknnrt.so file to /usr/lib/librknnrt.so, also tried adding it to LD_LIBRARY_PATH, but the issue is the same. Here is my full stack trace:
--> Init runtime environment
E Catch exception when init runtime!
E Traceback (most recent call last):
  File "/home/orangepi/.local/lib/python3.8/site-packages/rknnlite/api/rknn_lite.py", line 140, in init_runtime
    self.rknn_runtime = RKNNRuntime(root_dir=self.root_dir, target=target, device_id=device_id,
  File "rknnlite/api/rknn_runtime.py", line 319, in rknnlite.api.rknn_runtime.RKNNRuntime.__init__
  File "rknnlite/api/rknn_runtime.py", line 604, in rknnlite.api.rknn_runtime.RKNNRuntime._load_library
  File "/usr/lib/python3.8/ctypes/__init__.py", line 386, in __getattr__
    func = self.__getitem__(name)
  File "/usr/lib/python3.8/ctypes/__init__.py", line 391, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: /home/orangepi/.local/lib/python3.8/site-packages/rknnlite/api/lib/hardware/DOLPHIN/linux-aarch64/librknn_api.so: undefined symbol: rknn_set_core_mask

Is it because I use 3588S not 3588?

@rudimytro it could be… as RK3588S is not integrated as target and consider as RK3588, so try to replace it if you didn't yet

I see, but if I put 3588 as a target I get undefined symbol: rknn_set_core_mask as I mentioned above

Did you install another version before the current one? also, did you use the same version to convert model and run inference? if you want, share your model and I will try on my board

I used Ubuntu 20.04 with Python 3.8, both on the board and on the machine where I converted the model. When I do NOT specify the target it runs, but when I specify target as 3588 it gives me that error (same as for author of this Github issue). Here is the model:
yolo.zip

@rudimytro did you specify the target as this (should be RK3588, not 3588):
if host_name == 'RK3588':
        ret = rknn_lite.init_runtime(core_mask=RKNNLite.NPU_CORE_0)

if you can share a piece of code where you get the issue, that would be helpful to check it

same issue here,
I am using RK3588s

马上2024年7月了,这问题还是存在,rknnlite2.0

I RKNN: [13:27:50.940] RKNN Runtime Information, librknnrt version: 1.6.0 (9a7b5d24c@2023-12-13T17:31:11)
I RKNN: [13:27:50.940] RKNN Driver Information, version: 0.8.8
I RKNN: [13:27:50.940] RKNN Model Information, version: 6, toolkit version: 1.5.2+b642f30c(compiler version: 1.5.2 (c6b7b351a@2023-08-23T07:39:01)), target: RKNPU v2, target platform: rk3588, framework name: ONNX, framework layout: NCHW, model inference type: static_shape
W RKNN: [13:27:50.955] query RKNN_QUERY_INPUT_DYNAMIC_RANGE error, rknn model is static shape type, please export rknn with dynamic_shapes
W Query dynamic range failed. Ret code: RKNN_ERR_MODEL_INVALID. (If it is a static shape RKNN model, please ignore the above warning message.)
>>> cv_img: (1080, 1920, 3)
>>> forward cost time: 37.469ms
>>> forward cost time: 35.757ms
>>> forward cost time: 34.492ms
>>> forward cost time: 40.367ms
>>> forward cost time: 34.305ms
>>> forward cost time: 40.115ms
>>> forward cost time: 33.643ms
>>> forward cost time: 39.148ms
>>> forward cost time: 33.534ms
>>> forward cost time: 39.168ms
>>> forward cost time: 33.555ms
>>> forward cost time: 40.385ms
>>> forward cost time: 34.389ms
>>> forward cost time: 34.492ms
>>> forward cost time: 40.153ms
>>> forward cost time: 34.355ms
>>> forward cost time: 40.361ms
>>> forward cost time: 34.375ms
>>> forward cost time: 40.104ms

试试0.8.8 + 1.6.0，yolov5s 640x640, 平均延时30多，RK3588J，未开性能模式，估计也差不了多少
也可试试C API，平均延时不到20

Same issue, why we can't specify RK3588S as the target?

In their official documents, it described that there only one parameter in init_runtime, and the parameter is core_mask. So the target parameter is prohibited, it only can be used in RKNN-Toolkit 2 but not RKNN-Toolkit Lite2.
Hope that can help you!

02_Rockchip_RKNPU_User_Guide_RKNN_SDK_V2.0.0beta0_EN.pdf


sql/index/pilosa: better error messages

Related to https://github.com/src-d/gitbase/issues/971

Shall we merge this @ajnavarro?

@erizocosmico, you're co-maintainer so AFAIK you can already merge.

Oh, yes, you're right.


FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal

Running this code:
import uWS from 'uWebSockets.js';

class Application {
    #app;
    constructor(options) {
        this.#app = uWS.App(options);
    }

    listen(port, callback) {
        this.#app.listen(port, callback);
    }
}

const app = new Application();

app.listen(3000, () => {
    console.log('Server is running on port 3000');
});

Gives this error:
FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal
----- Native stack trace -----

 1: 00007FF6478F39EB node::SetCppgcReference+18459
 2: 00007FF647863379 node::OnFatalError+265
 3: 00007FF6482E5B63 v8::api_internal::ToLocalEmpty+83
 4: 00007FFD23493E24
 5: 00007FFD234B0EEA node::ArrayBufferAllocator::~ArrayBufferAllocator+96202
 6: 00007FF648292C5E v8::SharedValueConveyor::SharedValueConveyor+416270
 7: 00007FF64829285A v8::SharedValueConveyor::SharedValueConveyor+415242
 8: 00007FF648292B1F v8::SharedValueConveyor::SharedValueConveyor+415951
 9: 00007FF648292990 v8::SharedValueConveyor::SharedValueConveyor+415552
10: 00007FF64838DFFE v8::PropertyDescriptor::writable+677838
11: 00007FF6482FF6A0 v8::PropertyDescriptor::writable+93808
12: 00007FF6482FCBE6 v8::PropertyDescriptor::writable+82870
13: 00007FF64844A406 v8::PropertyDescriptor::writable+1448918
14: 00007FF6482FF6A0 v8::PropertyDescriptor::writable+93808
15: 00007FF64833AB51 v8::PropertyDescriptor::writable+336673
16: 00007FF6482FDA60 v8::PropertyDescriptor::writable+86576
17: 00007FF6482FD65B v8::PropertyDescriptor::writable+85547
18: 00007FF6481A7BD8 v8::StackTrace::GetFrameCount+3928
19: 00007FF6481A7D0B v8::StackTrace::GetFrameCount+4235
20: 00007FF6481A896D v8::StackTrace::GetFrameCount+7405
21: 00007FF647ED8072 v8::base::Thread::StartSynchronously+407106
22: 00007FF647EDA852 v8::base::Thread::StartSynchronously+417314
23: 00007FF647ED7990 v8::base::Thread::StartSynchronously+405344
24: 00007FF647F0D827 v8::base::Thread::StartSynchronously+626167
25: 00007FF6482C51AD v8::Module::Evaluate+621
26: 00007FF6478AA506 v8::base::CPU::has_idiva+8774
27: 00007FF648292C5E v8::SharedValueConveyor::SharedValueConveyor+416270
28: 00007FF64829285A v8::SharedValueConveyor::SharedValueConveyor+415242
29: 00007FF648292B1F v8::SharedValueConveyor::SharedValueConveyor+415951
30: 00007FF648292990 v8::SharedValueConveyor::SharedValueConveyor+415552
31: 00007FF64838DFFE v8::PropertyDescriptor::writable+677838
32: 00007FF6482FF6A0 v8::PropertyDescriptor::writable+93808
33: 00007FF648337B07 v8::PropertyDescriptor::writable+324311
34: 00007FF6483F00B5 v8::PropertyDescriptor::writable+1079429
35: 00007FF648327745 v8::PropertyDescriptor::writable+257813
36: 00007FF6482FD95B v8::PropertyDescriptor::writable+86315
37: 00007FF6481A7BEF v8::StackTrace::GetFrameCount+3951
38: 00007FF6481A7D0B v8::StackTrace::GetFrameCount+4235
39: 00007FF6481A8AFA v8::StackTrace::GetFrameCount+7802
40: 00007FF64817FCC2 v8::base::CPU::has_sse41+1410
41: 00007FF64817FA0C v8::base::CPU::has_sse41+716
42: 00007FF64792A852 node::CallbackScope::~CallbackScope+418
43: 00007FF64792A71E node::CallbackScope::~CallbackScope+110
44: 00007FF6477E9AE0 X509_STORE_get_cleanup+4816
45: 00007FF6477E8486 node::TriggerNodeReport+82278
46: 00007FF6477E8135 node::TriggerNodeReport+81429
47: 00007FF647929FD4 node::SpinEventLoop+436
48: 00007FF64780E6C2 X509_STORE_get_cleanup+155314
49: 00007FF6478A7F6D node::Start+4909
50: 00007FF6478A6C70 node::Start+48
51: 00007FF64765D7BC AES_cbc_encrypt+151020
52: 00007FF648AF28EC inflateValidate+19196
53: 00007FFD93C9257D BaseThreadInitThunk+29
54: 00007FFD94A6AF28 RtlUserThreadStart+40

----- JavaScript stack trace -----

1: Application (file:///D:/JS/server/src/application.js:6:25)
2: file:///D:/JS/server/src/application.js:14:13
3: run (node:internal/modules/esm/module_job:234:25)

But if I run this code instead:
import uWS from 'uWebSockets.js';

const app = uWS.App();

app.listen(3000, () => {
    console.log('Server is running on port 3000');
});

It works fine. So for some reason uWS doesn't work when it's inside class? Also tested a bit more and it doesn't work when it's inside a function too. I'm using Node.js 20.17.0 and uWS v20.48.0 on Windows 11.

Oh! It's apparently sending undefined as options causing this. I guess it should still handle it properly to avoid confusion, so I'll leave the issue open.


golang filter: do not clear route cache in ·HeaderMap.Set` by default.

introduce a new API ClearRouteCache to clear route cache.
fix #33082
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @wangfakang @spacewander

cc @wangfakang @spacewander
@doujiang24 I CCed few owner, but let me know if you think this is ready to merge, I can help to merge since this is contrib ext.

Thanks, @soulxu , let's wait an approval from from @wangfakang @spacewander .


DynamoDB-delete_table-ResourceInUseException is not raising if we pass the TableStatus is other than Active

Reporting Bugs
Please be aware of the following things when filing bug reports:

Avoid raising duplicate issues. Please use the GitHub issue search feature
to check whether your bug report or feature request has been mentioned in
the past.

When filing bug reports about exceptions or tracebacks, please include the
complete traceback. Partial tracebacks, or just the exception text, are
not helpful.

Make sure you provide a suitable amount of information to work with. This
means you should provide:

Guidance on how to reproduce the issue. Ideally, this should be a
small code sample that can be run immediately by the maintainers.
Failing that, let us know what you're doing, how often it happens, what
environment you're using, etc. Be thorough: it prevents us needing to ask
further questions.
Tell us what you expected to happen. When we run your example code,
what are we expecting to happen? What does "success" look like for your
code?
Tell us what actually happens. It's not helpful for you to say "it
doesn't work" or "it fails". Tell us how it fails: do you get an
exception? A hang? How was the actual result different from your expected
result?
Tell us what version of Moto you're using, and
how you installed it. Tell us whether you're using standalone server
mode or the Python mocks. If you are using the Python mocks, include the
version of boto/boto3/botocore.

If you do not provide all of these things, it will take us much longer to
fix your problem.

Please share some details @BVRAM - If you do not provide all of these things, it will take us much longer to fix your problem..
Based on the title alone, I don't know what's wrong/how to reproduce it.

@bblommers , I will the share the details soon.
I got your view.
Thank you.

Closing due to inactivity - let us know if you have anymore details, and we can reopen.


loadTranslations in getStaticProps doesn't get the selected namespace

export const getStaticProps: GetStaticProps = async (props: any) => {
  return {
    props: {
      ...(await loadTranslations(ni18nConfig, props.locale, [
        'common',
      ]))
    },
  }
}

obtains the "translation" namespace instead even though I do not have "translation" defined as a namespace

HI @CorVous, can you share your ni18nConfig?
You are seeing the translation namespace because we always return the defaultNS like i18next does, though this behaviour slightly changed in the recent i18next>=21 versions, so I might need to revisit the logic to fix unwanted behaviours. For now, if you are using common as your defaultNS you can set that in your config as below and it should work.
const ni18nConfig = {
  defaultNS: 'common',
  supportedLngs: [..your-langs],
  ns: ['common', ...all-other-namespaces],
}

I hope this helps :)

Hey @CorVous , were you able to fix the issue?


Unable to pull docker images - Getting timedout error

I am using Docker toolset on Windows. Trying to pull a docker image and getting the following error (both in Gitbash and Kitematic)
Network timed out while trying to connect to https://index.docker.io/v1/repositories/bigdatauniversity/spark/images. You may want to check your internet connection or if you are behind a proxy.
But I am able to open the same link in a browser.

@vmnamburu The timeout happens within the VM; making the connection test within your browser only confirms that your main computer is connected, but it's possible that the VM lost its connection.
Are you behind a proxy? If so, check out the wiki: https://github.com/kitematic/kitematic/wiki/Common-Issues-and-Fixes#add-proxy-settings-to-vm
I would also suggest a complete restart - Virtualbox's network daemon can sometimes be finicky.

Hub is also having some maintenance work being performed. Please check: https://status.docker.com/
Thanks!


Generic List contains more than 8 items not working with custom rewriter

Required Information

AEM Version 6.5.21 (On Prem)
ACS AEM Commons Version: 6.9.6
Reproducible on Latest? Yes

Expected Behavior
After upgrading ACS Common from 5.3.4 to 6.9.6, in authoring instance, existing generic lists should open in authoring mode when clicking on properties button from tool bar.
Actual Behavior
After upgrading ACS Common from 5.3.4 to 6.9.6, in authoring instance existing generic lists are not opening when clicking on properties button from tool bar. It opens a blank page in new tab.
Steps to Reproduce

Start a AEM 6.5.21 vanilla instance on your local having ACS common 5.3.4 with some generic lists.
Build and deploy custom rewriter with order greater than 1.
Upgrade ACS Common 6.9.6
Open generic list having more than 10 items.
Should see a blank page.

Can you try with  custom rewriter. I will check the logs and share.


cleanup ProfilerConfig

remove logback, log4j configuration.

Current coverage is 40.26% (diff: 0.00%)

Merging #2136 into master will decrease coverage by 0.04%

@@             master      #2136   diff @@
==========================================
  Files          1580       1580
  Lines         54541      54535     -6
  Methods       10743      10741     -2
  Messages          0          0
  Branches       7472       7474     +2
==========================================
- Hits          21987      21960    -27
- Misses        32554      32575    +21
  Partials          0          0

Powered by Codecov. Last update 911433b...857e0ad


[Question] Crashlytics not reporting all non-fatal bugs to firebase after unity 2020

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.26f1
Firebase Unity SDK version: 7.1.0
Source you installed the SDK: .unitypackage
Problematic Firebase Component: Crashlytics
Other Firebase Components in use: Analytics, Installations, Messaging
Additional SDKs you are using:
Platform you are using the Unity editor on: Windows, Mac
Platform you are targeting: iOS, Android
Scripting Runtime: IL2CPP

[REQUIRED] Please describe the question here:
All were working till unity 2019.4 and after updating to 2020.3.26f1 only a few non-fatal bugs are being reported, those that we manually get and report to Firebase Crashlytics and actual crashes. Those non-fatal bugs like the Null Reference Exception or FormatException are not being reported anymore.

Hi @Diogo-Queiroz,
Thanks for reporting this. I noticed that you're using an old version of the SDK. Could you try using its latest version and see if it makes a difference? If it doesn't, please provide a minimal, reproducible example of your project so that we can identify the cause of this behavior.

Hi, @paulinon I will do that. I will first try to use the updated SDK version, which I believe is 8.8.0.
Also, in this manner of updating the SDK, I would be able to get those new Unity Metadata information? Just asking.

Hi @Diogo-Queiroz, you should be able to retrieve the metadata after the SDK update. I look forward to your results.

Hi @paulinon, another quick question. In order to update the SDK to 8.8.0, I just simply download the zip file from the Getting Started page and add all the packages we use via Import Custom Package (Crashlytics, Analytics, Installations, Messaging) or some settings need to be updated as well? I noticed that after importing, the package finds old version of documents and ask to remove them.

Hi @paulinon, using the Getting Started tutorial to initialize Crashlytics the FirebaseApp.CheckAndFixDependenciesAsync() is throwing an exception. Which causes the Firebase to not initialize.
Debug.LogError($"{_className} [FirebaseEnabled] :: Could not resolve all Firebase dependencies: {dependencyStatus}");

The error log also said that FirebaseCppApp_8_8_0 could not be found.

Any suggestions?

Thanks for the update, @Diogo-Queiroz. Before I try to replicate this issue, I have a few questions:

Does this issue persist on both Windows and Mac?
Were the steps you shared performed in an empty Unity project?
Are you able to encounter this issue on both the app build and the Unity editor?

It would be great if you provide additional context about this behavior.

Hi @paulino.

Does this issue persist on both Windows and Mac?
I didn't test on Mac yet. Was tested on Windows.

Are you able to encounter this issue on both the app build and the Unity editor?
Firebase is enabled in Editor.
the task.Result returned Available.

Were the steps you shared performed in an empty Unity project?
It wasn't on an empty project. I updated our main project with it.

Thanks for your help.

Hi @Diogo-Queiroz,
It would be helpful if you could provide a minimal, reproducible example of your project along with the steps to reproduce the issue so that we can analyze this behavior you're facing.
I look forward to hearing from you soon.


Add version: JetBrains.Kotlin.Compiler version 1.3-rc

Pull request has been created with Komac v1.9.1 :strawberry:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116272&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Executable-Error


Default behaviour for workload bursting

Summary: when there are no region/zone related constraints, we should accept offers only from the local region
JIRA issues: MARATHON_EE-1695

@jeschkies yep, we have


List path

Addresses #1020 with windows fixes

See https://github.com/knausj85/knausj_talon/pull/1051#issuecomment-1437255863


Error starting gdbserver with CMSIS pack for F401RE

I am trying to start the gdbserver with the STM32F401RE using a CMSIS pack and have encountered a couple of issues. I am running pyocd built in dev from the latest master (0.19.1.dev61+dirty)
The first one was a bit straight forward, it looks like there is a typo in pyocd/target/pack/pack_target.py around line 194 where isinstane should be isinstance.
After editing that file, I ran into the following issue which is well beyond a python novice like me:
$ pyocd gdbserver -t stm32f401re --pack /Users/matost01/Downloads/CMSIS/STM32F4/Keil.STM32F4xx_DFP.2.13.0.pack
0000784:INFO:pack_target:Loading CMSIS-Pack: /Users/matost01/Downloads/CMSIS/STM32F4/Keil.STM32F4xx_DFP.2.13.0.pack
0000962:INFO:board:Target type is stm32f401re
0000962:ERROR:__main__:uncaught exception: unbound method _pack_target__init__() must be called with _PackTargetMethods instance as first argument (got Session instance instead)
Traceback (most recent call last):
  File "/Users/matost01/development/projects/mbed/pyOCD/pyocd/__main__.py", line 329, in run
    self._COMMANDS[self._args.cmd](self)
  File "/Users/matost01/development/projects/mbed/pyOCD/pyocd/__main__.py", line 545, in do_gdbserver
    **sessionOptions)
  File "/Users/matost01/development/projects/mbed/pyOCD/pyocd/core/helpers.py", line 196, in session_with_chosen_probe
    session = Session(allProbes[0], options=options, **kwargs)
  File "/Users/matost01/development/projects/mbed/pyOCD/pyocd/core/session.py", line 146, in __init__
    or Board(self, self._options.get('target_override', None))
  File "/Users/matost01/development/projects/mbed/pyOCD/pyocd/board/board.py", line 51, in __init__
    self.target = TARGET[self._target_type](session)
TypeError: unbound method _pack_target__init__() must be called with _PackTargetMethods instance as first argument (got Session instance instead)

Thanks @matt-oster! Will get this fixed quickly.

Ah, the second error is specific to Python 2.7 (it doesn't occur in Python 3).

Btw, I highly recommend using Python 3.7 as it's considerably faster than 2.7.


support installing pre-compiled fontc using cargo-binstall

now that fontc will be publishing precompiled binary artifacts in its Github Releases that are suitable for cargo binstall command (https://github.com/googlefonts/fontc/pull/827), I think this fontc-action could be modified to use that when available, or maybe install cargo binstall and attempt to install the latest, precompiled fontc unless the user passes options to select specific commits or branches etc. which would force building from source with regular cargo install command.
Or maybe check if fontc is already present (cargo binstall-ed beforehand) and skip compiling fontc from source. But then.. this whole action becomes a bit useless and one could simply do:
name: Install fontc and Compile Fonts

on:
  push:
  pull_request:

jobs:
  build:
    runs-on: ubuntu-latest
    name: Build fonts
    steps:
      - name: Check out font project source repository
        uses: actions/checkout@v4
      - name: Install the latest stable Rust toolchain
        uses: dtolnay/rust-toolchain@stable
      - name: Install cargo binstall
        uses: cargo-bins/cargo-binstall@main
      - name: Install the latest fontc
        run: cargo binstall fontc
      # - name: Install a specific fontc version
      #   run: cargo binstall<EMAIL_ADDRESS>      - name: Compile font
        run: fontc source/Font.glyphs

Per IM, let's instead fetch the latest release directly. That hsould mean that use of the fontc action doesn't require a rust toolchain at all.

Yes! Thanks Rod for making me realise there was an even simpler/faster solution ;)


CI actions for building on every push to main

This was one of the least painfull actiosn in my life.....
Also some gitignore casue you need it

Much obliged.


ORC-750: Fix bench to use orc pom as parent.

This refactors the benchmark pom so that it uses the orc pom as the parent.
That allows us to remove some duplication and means that the analyze profile becomes defined with benchmarks.
With that change, we now run findbugs and checkstyle on benchmark. Thus, we need to fix some findbugs
warnings and disable others.

Changes LGTM - +1

BTW, do you know why Travis CI is failing?

It looks like it is passing now. https://www.travis-ci.com/github/apache/orc/builds/217427153

Here is the PR to fix this.

https://github.com/apache/orc/pull/667


[gtk] Fix issue that cannot get keyboard layout data in case of using…

In US-Keyboard with Japanese Input, cannot get keyboard layout data.
Please see my report detail
https://developercommunity.visualstudio.com/content/problem/104471/visual-studio-for-mac-720540-cannot-launch-exc-bre.html

@akoeplinger Can we merge this? Looks good to me.

Actually, hold off on that. I'm still getting crashes with this patch. Trying to debug now.


HDF5/Silo built twice in CI?

In some CI instances, it appears that HDF5 and Silo are built in the test stage as well as the build one.
For example, these

https://github.com/MFlowCode/MFC/actions/runs/7231759732/job/19705284627
https://github.com/MFlowCode/MFC/actions/runs/7231759732/job/19705284264

but not this one

https://github.com/MFlowCode/MFC/actions/runs/7231759732/job/19705284960

Update: Also sort-of discussed here https://github.com/MFlowCode/MFC/pull/266

This issue was closed by #316


CAMEL-20087: Add data type transformers from Kamelet utils

Description

Backport data type transformer implementations from camel-kamelet-utils library
Data Types are:
Json (application-json, application-x-struct, application-x-java-object)
Avro (avro-binary, avro-x-struct, avro-x-java-object)
AWS SQS CloudEventsDataType (aws2-sqs-application-cloudevents)
AWS DDB JsonStructDataType (aws2-ddb-application-json)
Azure Storage CloudEventsDataType (azure-storage-blob-application-cloudevents)
Google Sheets JsonStructDataType (google-sheets-application-x-struct)
Google Cloud Storage CloudEventsDataType (google-storage-application-cloudevents)

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] Fixes CAMEL-20087

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@christophd you are welcome to merge


Event forwarding

Add webhook forwarding of events that is configurable by yaml. This way you wouldn't even need to touch Elixir.
Hasura Event Trigger yaml format: https://hasura.io/docs/latest/graphql/core/event-triggers/create-trigger.html
Or consider a similar config: https://github.com/subzerocloud/pg-event-proxy-example/blob/master/config_example.ini
Also see Supabase

Another idea is ability to transform requests: https://hasura.io/docs/latest/api-reference/kriti-templating/
^ but perhaps better suited for a different library

When casting to json, remove to Elixir map_diff specific columns:
"changes": {
    "event_id": {
      "added": "35ff67b6-4b9c-43f3-b51b-d2b7770e5796",
      "changed": "primitive_change",
      "removed": "6c59f0ed-e45b-44a7-98df-c2976835e875"
    },
    "updated_at": {
      "added": "2023-11-25T10:52:55.108562-05:00",
      "value": {
        "day": {
          "value": 25,
          "changed": "equal"
        },
        "hour": {
          "value": 10,
          "changed": "equal"
        },
        "year": {
          "value": 2023,
          "changed": "equal"
        },
        "month": {
          "value": 11,
          "changed": "equal"
        },
        "minute": {
          "value": 52,
          "changed": "equal"
        },
        "second": {
          "added": 55,
          "changed": "primitive_change",
          "removed": 54
        },
        "calendar": {
          "value": "Elixir.Calendar.ISO",
          "changed": "equal"
        },
        "time_zone": {
          "value": "Etc/UTC-5",
          "changed": "equal"
        },
        "zone_abbr": {
          "value": "-05",
          "changed": "equal"
        },
        "std_offset": {
          "value": 0,
          "changed": "equal"
        },
        "utc_offset": {
          "value": -18000,
          "changed": "equal"
        },
        "microsecond": {
          "added": [
            108562,
            6
          ],
          "changed": "primitive_change",
          "removed": [
            671907,
            6
          ]
        }
      },
      "changed": "map_change",
      "removed": "2023-11-25T10:52:54.671907-05:00",
      "struct_name": "Elixir.DateTime"
    },

In the above example, that means remove:

change type:  "changed": "map_change"
"value"
"struct_name": "Elixir.DateTime"

Maybe keep "value", not sure.

Consider providing option to send in Debezium format.

https://github.com/supabase/realtime/issues/33#issuecomment-632622973
Ability to config similar to this via json.

Added ability to forward events via webhooks or to EventRelay: https://github.com/cpursley/walex/releases/tag/v3.2.0

See also: https://github.com/eventrelay/eventsql


[Command] warden env up

Version of Warden
0.14.1
Operating System and Installation Method
Mac OS Sonoma 14.3 Beta
Describe the Bug
After the upgrade, it seems like Mutagen is stuck on this command:

To Reproduce

warden env up
it's getting stuck on: "

"

Expected Behavior
launch projects as before
Additional context
No response

@qsolutions-pl What version of mutagen are you running?
When you refer to "after the upgrade" are you referring to a Warden upgrade or an OS upgrade?

Update: seems like latest version of OrbStack has this issue, I've switched back to Docker-Desktop just to check and it works without issue.
@navarr  - I've did the same operation twice now, seems 100% OrbStack related.

@qsolutions-pl Looks like OrbStack released an update today, December 20. I've updated to 1.2.0 and not seeing this issue.
OrbStack 1.2.0
Mutagen 0.17.4
Warden 0.14.1


Update paper.md

Fixes to citations to multiple papers in one command (should use semicolon rather than comma)

Thanks @kyleniemeyer !


fix(interactive): Fix Bugs of OOM in CBO

What do these changes do?
as titled.

Related issue number

Fixes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.32%. Comparing base (d8e5c27) to head (609e42b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4330   +/-   ##
=======================================
  Coverage   34.32%   34.32%
=======================================
  Files         126      126
  Lines       13252    13252
=======================================
  Hits         4549     4549
  Misses       8703     8703

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e5c27...609e42b. Read the comment docs.

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Point the doc feedback button in Confluence docs to the git repo

Currently, the 'Doc Feedback' button in the confluence docs for WSO2 EI (versions prior to EI 7) are pointing the public jira.
Solution:
We need to change this by pointing the Doc Feedback button to this doc repo [1].
Also, it is good if we can automatically assign labels to Doc Feedback issues. The labels can indicate whether the doc issue originates from a 'legacy' version (example MB, DSS, etc), EI 6xx version, etc.
[1] https://github.com/wso2/docs-ei/issues

Duplicate of https://github.com/wso2/docs-ei/issues/993


Fix the build on 10.13. Missing LDFLAGS for OpenSSL from brew.

The build is broken on OS X 10.13 because they finally removed the OpenSSL libraries they had been shipping. They stopped shipping the headers back in 10.11 but have now stopped shipping the libraries. This diff adds the libraries from brew to LDFLAGS. We were already adding the headers from brew to CFLAGS for a while now.

The failure presents as:
checking for openssl/safestack.h... yes checking for MD5_Init in -lcrypto... no checking for MD5_Update in -lcrypto... no checking for MD5_Final in -lcrypto... no checking for SHA256_Init in -lcrypto... no checking for SHA256_Update in -lcrypto... no checking for SHA256_Final in -lcrypto... no
Applying this patch and doing the usual autoreconf --force --install will fix it.


feat: Qdrant Actor

Hey 👋. Greetings from Qdrant.
Description
This PR adds support for Qdrant to be used as a vector database in the project.
We were building an Apify actor for Qdrant and wanted to contribute here too.
Notes

Will commit the test cassette files after a confirmation to keep the diff sane.
To run Qdrant:

docker run -p 6333:6333 qdrant/qdrant

@Anush008 would you be open for a PR to include the Apify integration at qdrant integrations page ?

@Anush008 would you be open for a PR to include the Apify integration at qdrant integrations page ?

Absolutely. That's the next step for me.

I am planning to do the integration docs with some screenshots once the Actor is usable.
I'll let you know when I put out the PR for it.

I am planning to do the integration docs with some screenshots once the Actor is usable. I'll let you know when I put out the PR for it.

Cool thanks!

Hi @Anush008
sorry for the delay, The Qdrant Apify Actor is ready. Please try it out :).
The documentation for this Actor is also ready and will be published today, cf. PR: https://github.com/apify/apify-docs/pull/1077
Please let me know if you want to help with the documentation for the qdrant docs

Hi @jirispilka. Thank you.
The integration doc you made for the Apify docs is very comprehensive. I think we can have the same in the Qdrant integration docs page too. What do you think?

If you agree, I can put out a PR for the Qdrant docs and we can get going quickly.

Hi @jirispilka. Thank you.
The integration doc you made for the Apify docs is very comprehensive. I think we can have the same in the Qdrant integration docs page too. What do you think?

I think we can have similar documentation on qdrant.tech, except for the UI configuration. Since I will need to change the guide and screenshots next week, it makes sense to keep the detailed guide on Apify's site.
At Qdrant's documentation, we can provide a general overview indicating that Apify can scrape website content (or content from social media) and transfer it to the Qdrant database, along with code examples of how to call the Actor. For detailed UI setup instructions, we can direct users to the Apify's qdrant documentation.
I can ask our content team to draft general text about Apify and the Apify-Qdrant integration. What do you think? (I can have that quickly)

If you prefer that, sure. We have our social posts ready to go once the integration docs is in place.

Hey @jirispilka. I have put out a version based on your suggestion at https://github.com/qdrant/landing_page/pull/981
Please feel free to suggest any changes you'd want.

Hey @jirispilka.
As said, we posted about the integration at
https://www.linkedin.com/posts/qdrant_apify-a-web-scraping-and-browser-automation-activity-7210189889600974848-4lWz
AND
https://twitter.com/qdrant_engine/status/1804424088800092401

@Anush008 thanks 👏🏻 . I will let our team know to repost it.


Reconsider FakeContext usage in infractions code

I think we should consider (probably not in this PR) changing the type hints for any functions that can take a FakeContext, since just Context is misleading and makes it easy to introduce bugs like this.

I think the issue now is that we have 3 context classes: Context, FakeContext and FilterContext that are being used for conversion, and post_infraction takes either Context or FakeContext.
In this particular case, I think it's an instance of FilterContext that's being converted to FakeContext at the level of the InfractionAndNotification.action method .
But I do agree that it might need to be cleaned up.
I'll try to tackle this next.
Originally posted by @shtlrs in https://github.com/python-discord/bot/pull/2556#discussion_r1175085007

Places like this function https://github.com/shtlrs/bot/blob/6025015b471675de9f7eab9197899dd3eafcb4b0/bot/exts/moderation/infraction/_utils.py#L79 are currently type hinted as getting a Context, but they may instead get a FakeContext, which does not implement the full functionality of Context.
We should either update the type hints, or try and neaten stuff up another way that will help avoid bugs like https://github.com/python-discord/bot/issues/2555.

I'd like to note that for the linked issue, the bug would happen even if we used Context. The bug happened because we tried to issue an infraction from a type of channel that was unaccounted for.
I'm ok with trying to clean this up. This was a hack I wrote because I didn't always have a Context to work with, such as in the case of on_voice_state_update. If you have a better idea I'm happy to discuss it, but the current solution is the least hacky thing I could come up with.


Readme function names formatted consistently

The README's function names were inconsistenly formatted, and 3 of them look they're returning a pointer to a pointer. The PR fixes that formatting
Original

New

Thank you. Merging now.


Add version names to classes defined in generated Ruby tests

Fixes #2117 by appending a _version (i.e. _v1, _v2, etc.) suffix to the classes defined in the generated unit tests to avoid name conflicts when multiple versions exist.

Codecov Report

Merging #2181 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2181      +/-   ##
============================================
+ Coverage     86.86%   86.86%   +<.01%
  Complexity     5139     5139
============================================
  Files           456      456
  Lines         20385    20386       +1
  Branches       2184     2184
============================================
+ Hits          17707    17708       +1
  Misses         1908     1908
  Partials        770      770

Impacted Files
Coverage Δ
Complexity Δ

...api/codegen/transformer/ruby/RubySurfaceNamer.java
96.17% <100%> (+0.02%)
67 <1> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8030e4a...ec25ed7. Read the comment docs.


horizontal scrolling bug fixes

Fixed :

Horizontal scrolling
Cross page navigation now doesn't result in the scrolling being stuck.
images displayed via cloudinary
new package react-helmet for changing title and icon of tabs

yep done


Can you add a config file,so we can use scrcpy-noconsole with other parameter?

[x] I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

You could just create a .bat file containing for example:
scrcpy-noconsole -m800

You could just create a .bat file containing for example:
scrcpy-noconsole -m800

Thanks

You could just create a .bat file containing for example:
scrcpy-noconsole -m800

I try it. But find it still show a cmd window. What can I do for it?

start scrcpy-noconsole.exe -m800

start scrcpy-noconsole.exe -m800

It works well, ths


Software MFA

Add methods for software MFA setup via authorized Cognito user.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj, could you review my PR?

Thanks for the PR! It has been released as part of version 2.5.0.


A11y_AzureDataStudio_JuypyterBook_ScreenReader:  NVDA doesn’t announce selected state after selecting the tree item such as “TSG021 - Get Kubernetes cluster information” .

Check out Accessibility Insights!- Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11y_ADS_OctTestPass;#A11yMAS;#A11yTCS;#MAS1.3.1;MAS4.1.2;#DesktopApp;#JAWS;#NVDA;#SQL AzureDataStudio;#Win32
**Environment Details:	**
Application Name: Azure Data Studio
Version: 1.12.0-insider (user setup)
Commit:6582debd7388b1be512fc3a9b956d3e54f6115e7
Date: 2019-10-03T08:56:27.454Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
NVDA Version: 2019.2
JAWS Version:2019.1907.42 ILM
Additional Details:
Tool Name : NVDA,JAWS
Steps to Reproduce:
1.Install and Launch the application the azure data studio application.
2.Connet to the servers with the required credentials.
3.Navigate to the control panel and click on the "jupyter books" icon.
4.Press CRTL+SHIFT+P and search "jupyter books: SQL Server 2019 Guide"
5.Navigate to the left section of jupyter books under the untitled books and click on "save" icon .
6.Verify that all the elements of "Save juypyter book" are accessible and MAS Compliant.
7.Start NVDA.
8.Navigate till  tree item using arrows and select that item.
9.Observe the announcement by screen reader.
Actual:
NVDA doesn’t announce selected state after selecting the tree item such as “TSG021 - Get Kubernetes cluster information” .
Expected:
NVDA should announce selected state after selecting the tree item for example  “TSG021 - Get Kubernetes cluster information selected” .
User Impact:
Screen reader user will it difficult to navigate the screens as they won’t understand that particular tree item is selected or not.
Attachment for Reference:
7796_A11y_AzureDataStudio_JuypyterBook_ScreenReader.pptx
Does this issue occur when all extensions are disabled?: Yes

#Azure Data Studio - New Features_win32;

#Closed; #Regressed:07-14-23;


Fix Issue 16135 - missing std.format import in std.algorithm.comparison

Pretty trivial - as format was used in the lazily evaluated assert error, but I didn't know of a good way to test for static assert errors.
Moreover, I added the (modified) example from the bug as one can never have enough tests ;-)

Auto-merge toggled on


fix(patch): [sc-16747] Register in the remote Consul agent with the local IP address.

Description
Register in the remote Consul agent with the local IP address.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Minimal checklist:

[X] I have performed a self-review of my own code
[ ] I have added DocC code-level documentation for any public interfaces exported by the package
[ ] I have added unit and/or integration tests that prove my fix is effective or that my feature works

As of now when service is registered in the Consul agent running remotely it registers with the address of the host the Consul run on, so service get wrong IP and it does not work at all.
The fix solves the issue for simple case when client and service are on the same LAN.
It is not clear to me yet how will we configure case when service is behind NAT relative to the client. The problem here is different clients can use different IP for the same service from different LANs, so I think that issue should be handled in some other place, but not in the distributed system.


[TOPSAIL] Add macOS support for topsail container

In order to be able to work with the Topsail container in MacOS, the container scripts needed a few adjustments that are effectively introduced by this PR.
It mimics the toolbx behavior (simplistically) by using podman to create and enter Topsail environments.

@albertoperdomo2 , I've changed a bit the way we detect if has_toolbox, and I reshaped a bit the scripts to make them more reliable and readable
you'll let me know if you're fine with this version

@kpouget looks great 👍🏽

@kpouget can this be merged?

yes, thanks @albertoperdomo2 , mergin!


Split without matching "}" on the line deletes a line for TypeScript's forEach

I've found some strange behavior with the following piece of TypeScript code.
Here it works fine:
    this.state.hierarchy?.hierarchy
      .find((elem) => elem.id === id)
      ?.triggerList?.forEach((trigger) => { res[trigger.activation] = trigger })

And here it deletes a line:
    this.state.hierarchy?.hierarchy
      .find((elem) => elem.id === id)
      ?.triggerList?.forEach((trigger) => { res[trigger.activation] = trigger
      })

This is definitely an issue, except it's sort of several issues. I'll try to explain.
First off, the plugin, when splitting, should consider only a single line. This isn't something I'm enforcing on "moral" grounds or something, it's just technically difficult to parse things that could be broken up in several lines for the purposes of splitting. The splitters being limited to one line makes them much more reliable (I would say, "possible", even). It might be possible to implement something smarter on a case-by-case basis, but I feel that any attempt in that direction would cause issues.
So, in this case, the function that gets invoked is sj#SplitArgs, which calls the utility function sj#LocateBracesOnLine, which returns a pair of columns, except the "end" column is on the next line and is before the "start" column, which causes this issue.
So, one thing to fix is that the sj#LocateBracesOnLine function really needs to fail if the start and end column are not on the same line, and it does now. I can see a potential alternative function which returns a start-end line-column pair of pairs, but that would be the start of a lot of work -- what does it mean to "split" an arbitrary multi-line spanning expression between the opening and closing bracket?

That said, there's also a different issue here. This actually works in the "javascript" filetype, because the typescript support is just copied from javascript, but it was copied quite a long time ago :). Relevant PR: https://github.com/AndrewRadev/splitjoin.vim/pull/90.
So, now I've updated the typescript support with the modern set of javascript functions, and splitting both examples at the place you're splitting produces this (indentation probably wrong, I have no typescript support):
this.state.hierarchy?.hierarchy
  .find((elem) => elem.id === id)
    ?.triggerList?.forEach((trigger) => {
      res[trigger.activation] = trigger
    })

So, this splits the fat-arrow function, and not the arguments of the forEach call. I don't know if this is what you want, but also, I don't think it makes sense for TS and JS to do different things in this case. Though right now, with this change, if you have a fat-arrow function in a function argument list, you can't split the argument list instead, so that might be a problem as well. Even splitting with the cursor on forEach ends up splitting the square brackets? That doesn't seem right, really should limit those to around-the-cursor only.
So, for now, I may have improved the issue, or I may have made things worse, depending on your perspective :). But on a technical level, I've fixed a consistency issue in a utility function and made JS and TS consistent, so that's a step I needed to take. I'll see if I can make it more reliable to pick what to split depending on cursor position.

Note: I said that only single-line stuff is supported, so why does fat-arrow function splitting work with the bracket on a new line? An oversight -- somehow, the logic over there doesn't need to consider the "closing" area, I guess? So, it works by accident, and I would ideally not rely on closing brackets on a new line being considered. Again, just a technical limitation.

Okay, so I've just pushed a fix for the array problem, which means now, with this code:
this.state.hierarchy?.hierarchy
.find((elem) => elem.id === id)
?.triggerList?.forEach((trigger) => res[trigger.activation] = trigger)

If you split with the cursor on (trigger), you get:
this.state.hierarchy?.hierarchy
.find((elem) => elem.id === id)
?.triggerList?.forEach((trigger) => {
  return res[trigger.activation] = trigger
})

With the cursor on forEach:
this.state.hierarchy?.hierarchy
.find((elem) => elem.id === id)
?.triggerList?.forEach(
  (trigger) => res[trigger.activation] = trigger,
)

Which gives you the ability to choose whether you want to split the callback, or the arguments of the function call. (Trailing comma depending on options.) Splitting an array inside the callback doesn't work, unfortunately, because it breaks other things. But I figure if you want to break an expression down into multiple lines, you'll first split the callback, and then start breaking down its contents.

The problem is, for the incomplete line case, only the callback split works, the argument split doesn't:
this.state.hierarchy?.hierarchy
  .find((elem) => elem.id === id)
    ?.triggerList?.forEach((trigger) => { res[trigger.activation] = trigger
    })

this.state.hierarchy?.hierarchy
  .find((elem) => elem.id === id)
    ?.triggerList?.forEach((trigger) => {
      res[trigger.activation] = trigger
    })

As I said, the plugin can't handle splitting anything that's not on one line, and the fact that the callback works is mostly an accident and I wouldn't rely on it.
Does that make sense? Any thoughts or ideas on how things could work differently?

Thanks for the amazing response, I haven't anticipated the issue to be so complicated.
I think in the case of an incorrect split it is perfectly fine to press u, J and redo the split again, as this is still much faster than running something like prettier for the whole file.
My concern was that the split has gone incorrectly (the information was lost), but the code remained syntactically correct, therefore linter wouldn't notice it (not exactly the case of forEach to be honest, but it there is like a million functions where an arrow function in an optional parameter). It seems that you have fixed that problem.
I haven't looked into the internal workings of the plugin, but perhaps the actual problem you are facing is that the programming languages are context-sensitive ones, and regular expressions can be used to parse properly only regular languages, which is a smaller class. E.g. it's impossible to parse XML with regexes; or at very best it will be akward and the used construct won't technically be a regex.
Programs like prettier or yapf usually build a syntax tree of the code and then restore the code according to the used standards, more or less completely disregarding the initial formatting. Which naturally takes a lot of time.
Regexes are much faster, but they make such awkward situations literally unavoidable. So it is still very cool that the plugin works correctly most of the time.

I haven't looked into the internal workings of the plugin, but perhaps the actual problem you are facing is that the programming languages are context-sensitive ones, and regular expressions can be used to parse properly only regular languages, which is a smaller class.

Yes, it's a lossy operation, it's impossible to say something like "give me the expression the cursor is in", unless I have access to the full parse tree. Even then, I imagine it would be a very different process, but splitjoin handles itself well enough by matching key points. It's not all regexes -- there's syntax highlighting, and Vim provides bracket-matching functions, but in the end it's "can I find something nearby that can tell me what I'm working with". And that's always gonna be, at best, "good enough".

Programs like prettier or yapf usually build a syntax tree of the code and then restore the code according to the used standards, more or less completely disregarding the initial formatting. Which naturally takes a lot of time.

Yes, although it's less about speed for me. Code formatters try to turn the code into a canonical "good" form. Splitjoin assumes there are different forms that are good for different cases, and gives you the tools to switch between them. For example, it would make sense to say "a callback function should be single-line if it's less than X characters", but if you want to add more lines to it, you'll split it first, even if it's short. So, there's a temporary "bad state" that you want to be able to achieve. (I don't actually know if there's a rule like that, though, it's just an example.)
I definitely think it would be possible to achieve something like splitjoin with a parser, though it would ideally be something like tree-sitter for the incremental updates. But it would probably have very different challenges in terms of implementation.
Anyway, that's more on the philosophical side of things. For the practical problem, I think handling of this case is better now, so I'll go ahead and close the issue. Feel free to reopen if you find a related problem.


When uploaded of supply quotation csv. Success message does not states the number of rows uploaded

Is your feature request related to a problem? Please describe.
When uploading a CSV file a success message does not state the number of rows that are updated
Describe the solution you'd like
When we upload a CSV file to the Supplier Quotation Upload in Suppliers tab, the file is not uploaded successfully and there is no message which states the number of rows that are updated
Additional context

This issue is not there anymore.


ActionUtil does not apply blacklist when 'where' parameter is set.

Sails version: 12.4
Node version: 4.5.0
NPM version: 3.10.6
Operating system: OS X 10.11.1 (15B42)

In actionUtil.js in the method parseCriteria(), the blacklist only gets applied when req.param.all().where is tested false. This can be a major security issue. This means that you can circumvent the blacklist if you set your criterias with ?where={"xyz:123"}.
So a security policy that blacklists the criteria "xyz" can be easily circumvented.

Hi @Hanifb, can you say more about how you could see this being used as an exploit?  The criteria blacklist isn't intended as a security feature; it's simply to stop the blueprint "find" from interpreting a sort or skip in the query string as a search criteria instead of a filter for the result set.  If you specify sort or skip in a where clause, then you're explicitly trying to search on those properties (perhaps you have a boolean attribute named skip in your model), so we let it through.


Track chat routes on Plausible

Context
This allows us to track the route used in a chat message on Plausible in streamed chat.
Changes proposed in this pull request
Sends the route to the JS app for non-staff users in a new 'hidden-route' event type (this can be removed when the route is available to all users).
For both the 'route' and 'hidden-route' event types, trigger a custom Chat-message-route-[ROUTE NAME] event in Plausible:
https://plausible.io/docs/custom-event-goals#trigger-custom-events-manually-with-a-javascript-function
Guidance to review

For someone with experience with Plausible (@KevinEtchells) : Does this look like it will work?
Does the code run locally (without Plausible) without triggering console errors?

Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-439
https://plausible.io/docs/custom-event-goals#trigger-custom-events-manually-with-a-javascript-function
Things to check

[ ] I have added any new ENV vars in all deployed environments
[x] I have tested any code added or changed
[ ] I have run integration tests

If you feel this will be burdensome in future (e.g. if we're adding lots of routes, having to remember to add the custom events each time etc.) then it may be worth considering just having a single route event with additional props: https://plausible.io/docs/custom-props/for-custom-events#2-using-the-manual-method
Do we need the hidden-route message type in the webSocket.onmessage callback? I appreciate you've commented that this is only temporary, but as this is already hidden perhaps we don't need it at all? I'd be keen to not add any more complexity to this function than we need to, but my question may be due to my lack of understanding of the problem.

@KevinEtchells given that we sometimes add new routes for testing, I'm tempted to use the single 'route' approach you mentioned above
The difference between the hidden-route and the route event is that the hidden-route doesn't remove the 'hidden' attribute from the route object. The other option would be to pass the 'show_route' boolean from Python to JS, which I felt would be even more fiddly to unpick when we're removing it. Let me know if you think otherwise though.


IPC-86: Rate limit

Closes #86
The PR uses the gcra library to rate limit the amount of data that can go to any individual MultiAddress via Bitswap. The content::Config gets two new fields, rate_limit_bytes and rate_limit_period, so that we can configure e.g. that any peer cannot download more than 10MB/hour from us.
The Client has a new update_rate_limit method we can use to adjust this value on the fly, if we see that this is going to be too tight. The gcra library was picked because it allows passing in the limit with each request, unlike for example the governor.
To make it work, I had to fork libp2p-bitswap, because normally it sends the response straight to the connection handler, which writes it to the socket. To inspect the response, I had to redirect the channels, which required the hitherto private BitswapResponse type to be public.
I see that libp2p-bitswap has metrics like THROTTLED_INBOUND, however, they aren't used. This suggests that rate limiting was supposed to be part of the library, but apart from https://github.com/ipfs-rust/libp2p-bitswap/issues/22 saying it's a bit naive at the moment, I didn't find anything on this. I thought making the aforementioned type public is the lightest touch.
Another option which would have resulted in much less code and indirection on our part would have been to extend the BitswapEvent to not only report progress on our own queries, but the responses sent. I didn't want to break the API for anyone who uses this library, without talking to the devs, though. Maybe they would prefer to add throttling directly.

I agree that a fork is not ideal, I opened a PR to the upstream repo.
I also agree that most likely nobody is going to abuse our agents. However, library is agnostic of what you want to download, so someone can totally use it to download the entire state tree if they ask for that CID. At least in Fendermint I don’t want to go into gymnastics to filter what exactly can be downloaded, so this level of fair use limit can be a simple deterrent for people who don’t want to risk being unable to download stuff that matters, or to not latch on a single peer too much.


Python 3.6.7 support, seems broken

I am hitting trouble with miniconda on Python 3.6.7 and pyflame
python --version
Python 3.6.7 :: Anaconda, Inc.

 ./pyflame -v
pyflame 1.6.6 linux-gnu x86_64 (ABI list: 26 34 36)

I am utilizing the approach darindf recommended for conda:
sudo find ~/miniconda3 -iname python-*.pc # (find the pkgconfig directories)
export PKG_CONFIG_PATH=/home/brett/miniconda3/envs/far5/lib/pkgconfig/ # (far5 is the env I am using)
...build the normal way

(I am using the same conda environment to find the pkgconfig as the python program I am trying to trace), but I am getting
sudo ./pyflame -d --threads -p  15657
terminate called after throwing an instance of 'pyflame::PtraceException'
  what():  Failed to PTRACE_PEEKDATA (pid 15657, addr 0x55a8639c3508): Input/output error

For reference, i am trying to do this with a very minimal example:
import time

i = 0
while True:
    time.sleep(3)
    print('running', i)
    i += 1

I am hitting it in 3.6.8 in a conda environment.
sudo PATH=$PATH PYTHONPATH=$PYTHONPATH /home/awagner/miniconda3/bin/pyflame -o pyflame_profile.txt  --threads --trace python3 ../common/bench.py
Failed to PTRACE_PEEKDATA at 0x55628625c5a8: Input/output error
$ python --version
Python 3.6.8 :: Anaconda, Inc.


Update package.json

graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible.
Need to upgrade fs-extra to upgrade to<EMAIL_ADDRESS>

Thanks!


Path MTU Discovery support

Path Maximum Transmission Unit Discovery (PMTUD) is performed using binary search.
Ping frames are padded with dummy data, so we do not risk losing application data.
PMTU Probe timer is set to rtt (smoothed_rtt). Once expired, PMTUD probe is assumed lost and PMTU is reduced for the next send.

This PR is based on PR #372 by @ghedo

@divyabhat1 the build failures are unrelated to your changes. We just fixed up master so if you rebase, things will look better.


Grid lines

Is there a way to show gridlines? Like if you wanted to build a spreadsheet control with TextFields inside the grid.

You can use Grid cell background and overlay

Awesome! Thanks!


Addon lifecycle enhancements

This is the issue to support addon rolling upgrade on API level.
Proposal is in https://github.com/open-cluster-management-io/enhancements/pull/82

/kind feature

/assign @haoqing0110

/cc @qiujian16

this is finished
/close


[ERROR] soupault encountered an internal error: post-index hook got a JSON value that isn't an object.

Steps to reproduce
On Windows (didn't try on Linux).
Note: the weird powershell stuff is just to convert CRLF -> LF so that git apply can consume it successfully.
Note also the ^Z (i.e. Ctrl-Z, Enter) at the end of the file, it's needed to close the copy CON operation successfully.
This appears to be a minimal reproducer; if I remove any of the entries in soupault.toml, or the foo.html file, there's no error. Also it seems to error if foo.html is named foo.md instead.
C:> soupault --version
soupault 4.0.0
Copyright 2022 Daniil Baturin et al.
soupault is free software distributed under the MIT license
Visit https://www.soupault.app/reference-manual for documentation

C:> git init bug
C:> cd bug
C:> soupault --init

C:> copy CON bug.patch
diff --git a/site/foo.html b/site/foo.html
new file mode 100644
index 0000000..e69de29
diff --git a/soupault.toml b/soupault.toml
index 7e750c9..144462c 100644
--- a/soupault.toml
+++ b/soupault.toml
@@ -59,7 +59,8 @@

   # You can choose where exactly to insert the content in its parent element.
   # The default is append_child, but there are more, including prepend_child and replace_content
-  default_content_action = "append_child"
+  # default_content_action = "append_child"
+  default_content_action = "replace_content"

   # If a page already has a document type declaration, keep the declaration
   keep_doctype = true
@@ -120,3 +121,14 @@
   # By default this widget deletes all elements matching the selector,
   # but you can set this option to false to delete just the first one
   delete_all = true
+
+[index]
+  index = true
+
+
+
+[hooks.post-index]
+  lua_source = '''
+    -- nothing
+  '''
+
^Z

C:> powershell.exe -noninteractive -NoProfile -ExecutionPolicy Bypass -Command "& {[IO.File]::WriteAllText('bug2.patch', ([IO.File]::ReadAllText('bug.patch') -replace \"`r`n\", \"`n\"))};"

C:> git apply bug2.patch
bug2.patch:32: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

C:> soupault --debug
[DEBUG] Widget processing order: generator-meta page-title no-blink
[INFO] Build directory "build" does not exist, creating
[INFO] Processing page site\foo.html
[INFO] Using the default template for page site\foo.html
[DEBUG] Not inserting index data: page name does not match index
[INFO] Running the "post-index" hook on page site\foo.html
[INFO] Running the post-index hook on page site\foo.html
[ERROR] soupault encountered an internal error: post-index hook got a JSON value that isn't an object.
[ERROR] Please report a bug and attach the message and the exception trace to your report.
Fatal error: exception Dune__exe__Soupault_common.Internal_error("post-index hook got a JSON value that isn't an object")
Raised at Dune__exe__Soupault_common.internal_error in file "src/soupault_common.ml", line 21, characters 5-31
Called from Dune__exe__Hooks.run_post_index_hook.assoc_of_json in file "src/hooks.ml", line 112, characters 11-81
Called from Dune__exe__Soupault.extract_metadata in file "src/soupault.ml", line 348, characters 6-112
Called from Dune__exe__Soupault.process_page in file "src/soupault.ml", line 433, characters 21-68
Called from Dune__exe__Soupault.process_page in file "src/soupault.ml", line 444, characters 8-77
Called from Dune__exe__Soupault.process_page_files.(fun) in file "src/soupault.ml", line 623, characters 15-73
Called from Dune__exe__Utils.fold_left in file "src/utils.ml", line 74, characters 15-22
Called from Dune__exe__Soupault.main in file "src/soupault.ml", line 752, characters 21-91
Called from Dune__exe__Soupault in file "src/soupault.ml", line 774, characters 12-19

soupault-4.0.1-alpha1.exe.zip
This is really interesting. I thought that it's a completely impossible situation so I never even thought to log the real value. I attached a build with a change to log it in JSON (238234450a86).
That build also includes the fix for #44.
Ideally I'd like to have a complete source of that website to experiment with, but first could you run it with the test build and show me the output? Maybe that will give me enough information to attempt a fix.

That build also includes the fix for https://github.com/PataphysicalSociety/soupault/issues/44.

Fixes it for me, thanks! ❤

Ideally I'd like to have a complete source of that website to experiment with (...)

Hm; FWIW, the scenario I described above does deterministically reproduce the bug on my machine. Please note the patch to soupault.yaml and to site/foo.html (new file creation). So I think you should be able to experiment with it if you follow the steps, no? Possibly even on non-Windows OS (replacing copy CON bug.patch with cat > bug.patch <<EOF, etc). Or does it not reproduce on your machine if you follow the steps?
Regardless, the output from the executable when run with the reproducer scenario:
C:\prog\tmp\bug4>\dnload\tmp\soupault-4.0.1-alpha1.exe --debug
[DEBUG] Widget processing order: generator-meta page-title no-blink
[INFO] Processing page site\foo.html
[INFO] Using the default template for page site\foo.html
[DEBUG] Not inserting index data: page name does not match index
[INFO] Running the "post-index" hook on page site\foo.html
[INFO] Running the post-index hook on page site\foo.html
[ERROR] soupault encountered an internal error: post-index hook got a JSON value that isn't an object:
 [].
[ERROR] Please report a bug and attach the message and the exception trace to your report.
Fatal error: exception Dune__exe__Soupault_common.Internal_error("post-index hook got a JSON value that isn't an object:\n []")
Raised at Dune__exe__Soupault_common.internal_error in file "src/soupault_common.ml", line 21, characters 5-31
Called from Dune__exe__Hooks.run_post_index_hook.assoc_of_json in file "src/hooks.ml", line 112, characters 11-139
Called from Dune__exe__Soupault.extract_metadata in file "src/soupault.ml", line 348, characters 6-112
Called from Dune__exe__Soupault.process_page in file "src/soupault.ml", line 433, characters 21-68
Called from Dune__exe__Soupault.process_page in file "src/soupault.ml", line 444, characters 8-77
Called from Dune__exe__Soupault.process_page_files.(fun) in file "src/soupault.ml", line 623, characters 15-73
Called from Dune__exe__Utils.fold_left in file "src/utils.ml", line 74, characters 15-22
Called from Dune__exe__Soupault.main in file "src/soupault.ml", line 752, characters 21-91
Called from Dune__exe__Soupault in file "src/soupault.ml", line 774, characters 12-19

@akavel  Simply setting default_content_action = "replace_content" and adding an empty post-index hook doesn't crash soupault for me on Linux. Am I missing an important step?
It's really strange that in your case it receives an empty list though, this does indicate a logic bug somewhere in my code, I just need to find where it is and what causes it.

There's 4 elements that must all happen, any on missing removes the error:

default_content
index
post_index (with lua, I think; I didn't try keeping the sections but removing the values)
empty file at site/foo.html

@akavel Sorry, I missed the empty page part. I can reproduce it indeed, thanks for pointing it out! I'll look into it and let you know when I have a fix.

soupault-4.0.1-alpha2.zip
I think I've found the problem. It's likely related to the ambiguity of projecting Lua tables back to OCaml (e1424b784cd7e946c8ebd5). Could you try the attached build?

soupault-4.0.1-alpha2.zip
I think I've found the problem. It's likely related to the ambiguity of projecting Lua tables back to OCaml (e1424b7). Could you try the attached build?

Yep, that appears to fix the problem, thanks! :)


Can I contribute some debugging help to a specific language?

I'm using a Google Docs extension which is based on highlight.js. It formats code blocks within a Google Doc text.
When I use the Code Blocks extension to format a section of my .vimrc file, using the "vim" language choice, the formatting is inconsistent. Specifically, it emboldens various words and strings within the text of comments.
I don't know about you, but when some English text within a comment uses the word "for" to explain how a particular function works, I don't want that highlighted separately from the rest of the sentence.
Reading through some of the highlight.js material here, it's clear there may not be anyone around who would take is as their responsibility to fix it, so I guess it's up to me.
How would I go about doing that?

How do I find who's created the vim/vimscript module?
How do I find out if they're at all active and/or interesting in updating it?
Assuming negative results to 1 and/or 2, how do I go about getting access to the source for the module?
How do I go about testing it? Is there anyone here who could hand-hold me through this part?

I presume that to get any updates into the GDocs Code Blocks Extension, I need to talk to that developer to get a new build to test. Or maybe they automatically get the latest highlight.js, I don't know. Something else to research.
If someone could give me a hand getting starting at this, I'd be happy to whittle away at it, fixing the most annoying errors (like formatting within a comment) first and see how it goes.
Thanks,
August
.

1.2.
git log src/languages/vim.js

I'd say it hasn't seen much love over the years.

It's part of the core library. src/languages/vim.js

You may need to be more specific with your question.

The built in test suite has markup tests that take and input and then verify the output is correct.  For testing but hand you might need to write a tiny JS scaffold to analyze a file and spit out results... or you can just write a failing test and look at the test failures.

I'd suggest you raise an issue for the biggest issue or two you're facing (comments sound like a good start) and then we can track the discussion there and you can learn as you go.

Oh, I forgot there is also the super helpful tools/developer.html.  I'd suggest firing that up.

We'd love to have your help.  So again I'd start with opening a new issue for the exact comment bug you're seeing, and then we'll proceed from there and can help you with your first patch, PR, etc...
Resolving issue as asked and answered.

Thanks Josh,
I'll get a specific issue written up in a day or three.
August
.
On Tue, Apr 21, 2020 at 9:06 AM Josh Goebel<EMAIL_ADDRESS>wrote:

We'd love to have your help. So again I'd start with perhaps opening a new
issue for perhaps the exact comment bug you're seeing, and then we'll
proceed from there and can help you with your first patch, PR, etc...
Resolving issue as asked and answered.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/highlightjs/highlight.js/issues/2499#issuecomment-617259208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDL4F7TUBVHK5HLEBYPBALRNW76RANCNFSM4MNAYHOA
.