[Host.Kafka] Leverage autocommit to achieve faster consumption

Currently, the Kafka provider uses a manual commit approach (every N message, every M seconds).
We should also give the option to perform auto commits by Kafka. This should significantly increase consumption speed.

Hi!!!
Currently, messages are being auto-committed by the consumer. However, I need to handle the commit manually because my consumer is encountering an exception during message processing. Despite the error, the library is still committing the offset, which is not the desired behavior.
Is there a way to disable the auto-commit feature and manually commit the messages only after successful processing?

So yes, the kafka provider moves forward which is not desired in your case.
This is a standardized way to tap into error handling (in case you haven't seen it):
https://github.com/zarusz/SlimMessageBus/blob/master/docs/intro.md#error-handling
However, what is the desired error handling? If not auto commit and move forward then what else?
I could expose something similar as for RabbitMQ if that would work for you to give you a bit more control
https://github.com/zarusz/SlimMessageBus/blob/master/docs/provider_rabbitmq.md#custom-consumer-error-handler
See option 1 (new feature), but options 2-3 should be achievable now.
public class CustomRabbitMqConsumerErrorHandler<T>(IMessageBus Bus) : IRabbitMqConsumerErrorHandler<T>
{
    // Inject needed dependencies via construction

    public async Task<bool> OnHandleError(T message, Func<Task> retry, IConsumerContext consumerContext, Exception exception)
    {
        // Option1: New feature to stop consumer
        // consumerContext.StopConsumer();

        // Option 2: Retry once more
        // await retry();

        // Option3: or forward the message to another topic:
        // await Bus.Publish(message, path: "errors");

        return true; // signify the error has been handled, it will advance offset to next message
    }
}

Let me know.

How can I generate manual commit on the "SlimMessageBus.Host.Kafka" library? Since the "EnableAutoCommit" property is set to "false" in the "CreateConsumer" method of the "KafkaGroupConsumer" class. Additionally, what should be applied so that the "OnStart" method of the "KafkaGroupConsumer" class does not fire? since the exercise was done to modify this value of the "EnableAutoCommit" property to "true", but the "OnStart" method is still being triggered, which generates actions to process the message and commit the message

How can I generate manual commit on the "SlimMessageBus.Host.Kafka" library? Since the "EnableAutoCommit" property is set to "false" in the "CreateConsumer" method of the "KafkaGroupConsumer" class.

The current version of the provides only supports manual commits managed by the library, which you can set every N messages or after every T time. Looking at the docs right now, it's not documented so I will add it here soon.
The consumer implementation does override the EnableAutoCommit here to take over the the control on when to commit.

Additionally, what should be applied so that the "OnStart" method of the "KafkaGroupConsumer" class does not fire? since the exercise was done to modify this value of the "EnableAutoCommit" property to "true", but the "OnStart" method is still being triggered, which generates actions to process the message and commit the message

By default when the Bus starts it will auto start all consumers.
Wheather the consumers should start or to stop them during runtime could be controlled see here.
What I am getting from this conversation including feedback (from @themiken earlier) is that we need these features:

user driven manual commits (right now they are manually but controller by the library every N messages / T seconds)
improved error handling along the lines of what I proposed here.

This ticket was originally about enabling auto commit controlled purely by Kafka (to increase throughput)
Please help me understand given what I've explained above, what is missing feature wise and I can look at adding it. We'd have to look at the proposed API in this ticket, iterate few times to get it right and then I could follow with an enhancement.

Thank you very much in advance for answering our questions.
To better understand our problem, it is all related to the loss of messages when consuming them, either because an error occurs in our application layer or because an error occurs in the "SlimMessageBus" library.
In our tests, linking the library as a project, we have identified that in the "ConsumerLoop" method of the "KafkaGroupConsumer" class, the "OnPartitionEndReached(consumeResult.TopicPartitionOffset);" instruction is executed, which causes it to generate commits to the offset of partitions that have not been processed and therefore generate the loss of these messages, and then execute in the same loop statement the instruction "await OnMessage(consumeResult).ConfigureAwait(false);", which processes the message obtained from the identified offset and commits the corresponding offset. To avoid the above, the value of the "EnablePartitionEof" property found in the "CreateConsumer" method of the "KafkaGroupConsumer" class was modified to "false" and thus avoid executing the "OnPartitionEndReached(consumeResult.TopicPartitionOffset);" instruction. These actions could be controlled if the "EnablePartitionEof" property could be configured from the user, so that the "OnPartitionEndReached(consumeResult.TopicPartitionOffset);" instruction is not executed. Additionally, it was found that when applying the previously mentioned setting with the "await OnMessage(consumeResult).ConfigureAwait(false);" instruction and having around 5 events/messages in queue, commits are generated only for some messages, not for all 5 events/messages, even so they can be processed without incident in our application layer. Following up on this latest development, we found that after processing the offset message in our application and then applying the commit, it was not generated, since the return value of the "Increment" method of the "CheckpointTrigger" class was "false" preventing the commit from being made, this caused it to consume an event again at an offset that had already been processed, but without generating a commit, duplicating events/messages in the application.
We would appreciate your advice to achieve the correct generation of commits, without generating loss of events/messages, whether the control is held by the library or by the user.

@jarb46 thanks for reporting and the detail provided.
I have few additional questions:

What version of SMB.Host.Kafka are you using?
Did you pull the latest transitive dependency Confluent.Kafka? I noticed there was some breaking change introduced between 2.3.0 and latest causing this issue (might be unrelated).

Let me analyze the problem here on my side.
Also as part of #300, I clarified the documentation.
As a side note there is this Source Link which should allow you to step into the library source.

@jarb46 I've identified the issue around the PartitionEOF and fixed it in #301.
There is a preview version if you want to try it: https://www.nuget.org/packages/SlimMessageBus.Host.Kafka/2.5.3-rc1
I need to address a second part of the problem, so I will report here once I have an update.

@jarb46 the issue with PartitionEOF has been resolved.
Moreover, as mentioned earlier the commit settings have been documented now.
The Kafka client has been updated to the latest.
Here is the latest release - please give it a try!
https://github.com/zarusz/SlimMessageBus/releases/tag/2.5.3
https://www.nuget.org/packages/SlimMessageBus.Host.Kafka/2.5.3

Thank you so much for your effort, @zarusz !!!.
At the moment, we are testing the changes.
We will keep you updated.

Hello @zarusz! We conducted tests on the version across different services and observed the following:
There is a mismatch in the offset commit when processing messages. The consumer group offset is incorrectly shifted to the next number when performing the commit, causing a lag that does not correctly reflect the processing of the last message. Despite this behavior, no messages are lost; all messages are processed correctly.

A new topic is created with a replication factor of 2 and 10 partitions to simulate a production environment.

The service starts with the log level set to DEBUG. The log shows the registration of consumers and the creation of a consumer group with 10 partitions, corresponding to the number of partitions in the topic. Additionally, it is observed that the initial offset of each partition is 0, indicating that there are no previous messages in the topic.
 [Product] [14:41:26 INF] [Creating producers for Main bus...] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaMessageBus>
 [Product] [14:41:27 DBG] [Producer settings: ["[bootstrap.servers, mykafkabroker.com:9094]", "[linger.ms, 1]", "[socket.nagle.disable, True]"]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaMessageBus>
 [Product] [14:41:27 INF] [Starting consumers for Main bus...] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
 [Product] [14:41:27 INF] [Creating consumers for Main bus...] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
 [Product] [14:41:27 INF] [Creating consumer group ProductUpdatedDomainEventGroup] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaMessageBus>
 [Product] [14:41:27 INF] [Creating for Group: ProductUpdatedDomainEventGroup, Topics: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:27 INF] [Started consumers for Main bus] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
 [Product] [14:41:27 INF] [The DomainEventBackgroundService was initialize] [] {"Category": "Event"} <s:Siigo.Core.MessageBus.Services.DomainEventBackgroundService>
 [Product] [14:41:27 INF] [Group [ProductUpdatedDomainEventGroup]: Subscribing to topics: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:27 INF] [Group [ProductUpdatedDomainEventGroup]: Consumer loop started] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:27 DBG] [Load provider connection strategy: MultiTenant] [] {"Category": "Event"} <s:Siigo.Core.Provider.Providers.ProviderBase>
 [Product] [14:41:27 DBG] [The connection SiigoRedisCore registered successfully] [] {"Category": "Event"} <s:Siigo.Core.DistributedCache.Redis.RedisConnectionFactory>
 [Product] [14:41:28 WRN] [Overriding address(es) 'http://localhost:5000'. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.] [] {"Category": "Event"} <s:Microsoft.AspNetCore.Server.Kestrel>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [0]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [1]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [1]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [2]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [2]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [3]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [3]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [4]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [4]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [5]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [5]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [6]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [6]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [7]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [7]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [8]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [8]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:36 DBG] [Group [ProductUpdatedDomainEventGroup]: Assigned partition, Topic: ProductUpdatedDomainEventTopic, Partition: [9]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:36 INF] [Creating consumer for Group: ProductUpdatedDomainEventGroup, Topic: ProductUpdatedDomainEventTopic, Partition: [9]] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
 [Product] [14:41:37 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [2], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:37 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [9], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:37 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [1], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:37 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [8], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:37 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [5], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:38 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [7], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:38 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [4], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:38 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [6], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:38 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [3], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
 [Product] [14:41:38 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>

A test message is sent to the topic, which is received and processed correctly by the microservice. However, when committing the message, the service reports that it has reached the end of the partition at offset 1, even though the processed message has an offset of 0. The lag shows a discrepancy of 1 between the processed message’s offset (0) and the new end offset (1).

[Product] [15:49:44 DBG] [No message type header was present, defaulting to the only declared message type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageProcessor>
[Product] [15:49:44 DBG] [Type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent deserialized from JSON {"Id": 0} to Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.Serialization.Json.JsonMessageSerializer>
[Product] [15:49:44 DBG] [Creating message scope for Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent of type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
[Product] [15:49:44 INF] [Message receive!!] [] {"Category": "Event"} <s:Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent>
[Product] [15:49:44 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 1] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:49:44 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit at Offset: 0, Partition: [0], Topic: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
[Product] [15:49:44 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit Offset, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 0] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>

Four additional messages are sent, all processed correctly. However, the offset continues to exhibit the same erroneous behavior: the commit is performed at a previous offset, causing the lag to increase. The last message has an offset of 4, but the system reports an end offset of 5.

[Product] [15:54:32 DBG] [Group [ProductUpdatedDomainEventGroup]: Received message with Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 2, payload size: 9] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:32 DBG] [No message type header was present, defaulting to the only declared message type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageProcessor>
[Product] [15:54:32 DBG] [Type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent deserialized from JSON {"Id": 2} to Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.Serialization.Json.JsonMessageSerializer>
[Product] [15:54:32 DBG] [Creating message scope for Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent of type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
[Product] [15:54:32 INF] [Message receive!!] [] {"Category": "Event"} <s:Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent>
[Product] [15:54:33 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 3] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:33 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit at Offset: 2, Partition: [0], Topic: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
[Product] [15:54:33 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit Offset, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 2] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:40 DBG] [Group [ProductUpdatedDomainEventGroup]: Received message with Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 3, payload size: 9] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:40 DBG] [No message type header was present, defaulting to the only declared message type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageProcessor>
[Product] [15:54:40 DBG] [Type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent deserialized from JSON {"Id": 3} to Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.Serialization.Json.JsonMessageSerializer>
[Product] [15:54:40 DBG] [Creating message scope for Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent of type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
[Product] [15:54:40 INF] [Message receive!!] [] {"Category": "Event"} <s:Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent>
[Product] [15:54:40 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 4] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:40 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit at Offset: 3, Partition: [0], Topic: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
[Product] [15:54:40 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit Offset, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 3] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:48 DBG] [Group [ProductUpdatedDomainEventGroup]: Received message with Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 4, payload size: 9] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:48 DBG] [No message type header was present, defaulting to the only declared message type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageProcessor>
[Product] [15:54:48 DBG] [Type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent deserialized from JSON {"Id": 4} to Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.Serialization.Json.JsonMessageSerializer>
[Product] [15:54:48 DBG] [Creating message scope for Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent of type Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent] [] {"Category": "Event"} <s:SlimMessageBus.Host.MessageBusBase>
[Product] [15:54:48 INF] [Message receive!!] [] {"Category": "Event"} <s:Siigo.MyService.Domain.Aggregates.Product.Events.ProductUpdatedDomainEvent>
[Product] [15:54:48 DBG] [Group [ProductUpdatedDomainEventGroup]: Reached end of partition, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 5] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>
[Product] [15:54:48 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit at Offset: 4, Partition: [0], Topic: ProductUpdatedDomainEventTopic] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaPartitionConsumer>
[Product] [15:54:48 DBG] [Group [ProductUpdatedDomainEventGroup]: Commit Offset, Topic: ProductUpdatedDomainEventTopic, Partition: [0], Offset: 4] [] {"Category": "Event"} <s:SlimMessageBus.Host.Kafka.KafkaGroupConsumer>

This behavior is consistent across all partitions of the topic. When adding new consumers to the group, it is evident that the lag remains equal to (# partitions x 1). In production environments, this results in cumulative lag across all partitions, although no messages are lost.
The offset commit mismatch seems to be due to incorrect handling of offsets in the consumer group, causing an apparent lag without data loss. This behavior affects lag monitoring in production environments, potentially causing confusion about the actual state of message processing.

@themiken The offset reported by Kafka in the Partion EOF (Reached end of partition) indicates the next offset that will be assigned in case a message arrives after it. It is not the value we should be committing with, but we should be committing the index of the last message that was processed. So, what SMB in the Partition EOF event is to commit that last processed message offset (on the partition-topic) - not the next index that arrived in the Partition EOF event. This was actually the bug I've fixed last time that caused messages to be skipped.
For example, in the case on starting with brand new topics the EOF event will report 0 - meaning if a message arrives it will get 0 index.
Then when first message arrives, it actually has index 0, then if no subsequent messages arrive an EOF event with index 1 is reported, and SMB issues a commit for the last processed index (on that partition-topic) which is 0 in this case.
So it works properly.
Unless you see a message with the same index being processed twice?

Correct, I understand the purpose of Partition EOF better now.
But according to this behavior, there shouldn't be any lag, right?
This is exactly the behavior I’m experiencing. Messages are processed perfectly, but there is a lag of 1 for each partition.
In this example, a service with 10 consumers and 10 partitions has a lag of 10 (all messages have been processed, with no loss of messages/offsets or duplicates).

@themiken  perhaps this warrants another issue to be created, as we went off track here with the original intent of this ticket.
Reading this:

The difference between log-end-offset and current-offset is called consumer lag.

A small constant lag value often exists in a healthy cluster and is nothing to worry about. However, a continuously increasing lag value or a sudden spike in lag value often indicates a problem.

In your, example the constant lag of 1 made me search more on this, and I found there is some inconsistency in the API with the Confluent.Kafka.
I have created an RC release for you to try out now:
https://www.nuget.org/packages/SlimMessageBus.Host.Kafka/2.5.4-rc2
With that it also uses latest Confluent.Kafka lib.
Let me know your findings.


Major refactor & Superforms v2 support

Alright peeps, I'm planning on publishing this big update very soon, would appreciate some feedback on the changes, as well as documentation.
You can access the branch deployment here: https://formsnap-git-superforms-v2-huntabyte.vercel.app/docs
Closes: #127
Closes: #115
Closes: #130
Closes: #87
Closes: #117
Closes: #113
Closes: #108
Closes: #110
Closes: #119
Closes: #77

Come on guys! I need this update. All my bests


File error

Describe the bug
After updating, the launcher displays "install game" in stead of "launch", but my game files are still in my disk.
When I clicked the "install" button and selected the original folder, the box bellow appeared. Now I cannot launch the game.
Screenshots
If applicable, add screenshots to help explain your problem.

System Information (please complete the following information):

macOS: Sonoma 14.6.1
Device: Macbook air M3
CPU: M3
Dedicated GPU (if any):M3 10cores
RAM:16gb

Logs (if any)

If it's related to the launcher, upload neutralinojs.log in Yaagl Data Directory

If it's related to the game, upload `logs/game_{timestamp}.log in Yaagl Data Directory

Don't put game files in /Applications


[docs] add English source for the Thread Primer

For translation purposes.
The directory structure mirrors what we have on openthread.io, for easy import.  For now, I didn't bother with images, so those are all broken, but I can add them later if we really want.

@jwhui This is failing the pretty check, is there a way to disable for a PR?  I can eventually tweak the source so it passes and doesn't mess with how its rendered on openthread.io, but I'd rather not mess with it at the moment.

@jwhui This is failing the pretty check, is there a way to disable for a PR? I can eventually tweak the source so it passes and doesn't mess with how its rendered on openthread.io, but I'd rather not mess with it at the moment.

@Vyrastas , I think this PR should add doc/en to OT_EXCLUDE_DIRS so that this and future PRs exclude these files during the check.
https://github.com/openthread/openthread/blob/2c258a3f3e0a09315fe41ea2c32e8b0ecab8176b/script/make-pretty#L64

@jwhui This is failing the pretty check, is there a way to disable for a PR? I can eventually tweak the source so it passes and doesn't mess with how its rendered on openthread.io, but I'd rather not mess with it at the moment.

@Vyrastas , I think this PR should add doc/en to OT_EXCLUDE_DIRS so that this and future PRs exclude these files during the check.
https://github.com/openthread/openthread/blob/2c258a3f3e0a09315fe41ea2c32e8b0ecab8176b/script/make-pretty#L64

Great, so that we don't have to update that script for each language folder, I've moved the content in a doc/site folder and excluded that.

Also, to make the file look cleaner, I've removed project/book YAML tags at the beginning of each.  I can have my import script add those, they aren't necessary to have here on GitHub.

Would it be better to define a shared resource directory for various translations (eg: doc/share for storing images/styles/compressed packages, etc.)?

Would it be better to define a shared resource directory for various translations (eg: doc/share for storing images/styles/compressed packages, etc.)?

Let me take a look because now that you mention it, I'm not sure the images would work with the same links on openthread.io if they only exist in the en/ language directory.  For now I'd just leave the links.
Styles are built into the openthread.io authoring platform, so that's nothing we'd host here.

Regarding a shared resource directory, this will be handled by the openthread.io publishing platform.  For the Thread Primer we will use the existing images we have with the English text.
Ideally people should go to openthread.io to view the Primer and any translated pages.  If there comes a need to host images here on GitHub, we can do that later.

So I don’t need to modify the image address references in the original text, right?

So I don’t need to modify the image address references in the original text, right?

You do not, leave them as they are.


bug: dont see login button in incognito

Works fine for me in all browsers
This is a window machine

Sir, seems working in ubuntu machine

works for me in windows

Hi, @hkirat, Got the issue...
While opening in a incognito tab, there's a slight delay while loading session, and we aren't showing anything to the user during that time..

I am picking this up and fixing this...
Cheers :)

Unable to reproduce


Dark Mode

With the integration with Tailwind CSS, it's way easier to implement a dark mode in the GUI. This is a feature that can be validated in the upcoming user validations.
I put this idea on an issue to not lose track of it.

In GitLab by @kinow on Mar 14, 2024, 13:44
Issue #100! :tada:


Perm iam:UpdateServerCertificate is needed

When is this used?

I tried updating a cert using this client and I got an error that I don't have perms.

Do you have a traceback showing which operation failed with that error?

Tried to reproduce and it's now working. Maybe an AWS snafu? feel free to close this one.

Ok! If anyone else reports this issue I'll keep it in mind.


meguca: fails to build

Issue description
build log: https://gist.github.com/Mic92/160e50a5c922d31696a4295253f6775d
Steps to reproduce
happens on revision ae49c73644c05f1eaf8fbd5e88d0971e3dd6a8c5
$ nix-shell -p meguca

cc @chiiruno

Noticed in https://github.com/NixOS/nixpkgs/pull/51613

I have a good idea why this is happening, I'll see if I can fix it.

Ah, this will certainly collide with #51613 where the original build issues were encountered. @Mic92 any ideas how to do the merge then (I guess one of the two PRs requires a rebase onto master then)


Transparent guess

Need to add a transparent version of the current piece such that you can directly be awared of where the piece would fall

Done!


Centos Service

Is there a specific folder that the iptdata is supposed to be in?
Every time there is an update I have to modify the service to include so that jetty doesn't crash.
ReadWritePaths=/var/lib/ipt/
Can the service be modified to include this as the default location or is there another default location that I'm supposed to be using?

Thanks, this should be included in the next release.


Round on some fractions rounds down

Try it Online!

This is called Banker's rounding or round half to even, and it's the default rounding mode IEEE 754 operations for results in binary floating-point formats

Bruh, it's annoying, but whatever. I've never seen a language that does this


Question: How to change Style of MessagBox

Hallo, i have a question and hope someone can help me with.
I try to change appearance of default MessageBox in metrowindow.ShowMessageAsync() Method.
unfortunately without success.
There ist parameter for MetroDialogSettings, which i try to change.
my code looks like :
var mymessageboxsettings = new MetroDialogSettings()
{
    AffirmativeButtonText = "OK",
    NegativeButtonText = "Cancel",
    AnimateShow = true,
    AnimateHide = false,
    DialogMessageFontSize = 12,
};
var result = await this.ShowMessageAsync("Info", "Load", MessageDialogStyle.AffirmativeAndNegative, mymessageboxsettings);
var theme = ThemeManager.GetAppTheme("BaseDark");
var accent = ThemeManager.GetAccent("LightGreen");
ThemeManager.ChangeAppStyle(Application.Current, accent, theme);

In ThemeManager  should be are Method
ThemeManager doesnt change MessageBox Colors / Style. Is always default, white backgroundcolor and blue buttons for ok and cancel.
I use VIsual Studio 2019, .NET Framework 4.6.2 und Mah.Apps.Metro 1.6.5.

@Torchok19081986 You change the theme and accent after closed dialog, that's maybe the problem.

Thanks for answer, @punker76. That was the problem. I set it too early. After i set it after line
ThemeManager.ChangeAppStyle(Application.Current, accent, theme); It works fine. Only one question:
currently thememanager change also my main window in theme and accent. How do i set it only for messageBox ?

Hello @Torchok19081986 ,
you can use a custom resourcedictionary and aplly it just to the dialog. See the screenshots below.
The window:

The dialog:

        private async void Button_Click(object sender, RoutedEventArgs e)
        {
            var accent = ThemeManager.GetAccent("Red").Resources;  // Get a theme of your choise
            accent["AccentColorBrush"]=  Brushes.Pink;             // Change the resources you like

            var settings = new MetroDialogSettings()
            {
                AffirmativeButtonText = "Yeah",
                NegativeButtonText = "No :-(",
                CustomResourceDictionary = accent                   // And finally applay it in the MetroDialogSettings
            };

            await this.ShowMessageAsync("TEST", "This is a test", MessageDialogStyle.AffirmativeAndNegative, settings);
        }

Happy Coding :-)

Hallo and thanks for answer @timunie . Unfortenally isnt work for me. My MessageBox is always white with blue buttons. I show messagebox on WPF Form loaded event . Maybe is the problem .
Do i need to add custom Dictonarie or custom ressource im app.xaml oder my form ? I didnt until now.

@Torchok19081986 do you have a sample app? It works for me also in the loaded event.

thanks for quick answer, @timunie. if you mean some screenshot, unfortunally no. i try to create it just like you write, with only one change, i choose green for  accent["AccentColorBrush"]=  Brushes.Pink Line.
But its dont work for me.
in app.xaml i have

as source added.
Could be one of this ressources doesnt allow apply new style for messagebox ?

hmmmm ... sorry, no idea. Maybe you should try the latest pre-release 2.0.0-alpha. There are some breaking changes, so you need to make a few modifications to your code.


Reintegrate docker images build in the monorepo - 3.16.x

Issue
NA
Description
Apply https://github.com/gravitee-io/gravitee-api-management/pull/1403 on 3.16.x.

📚  View the storybook of this branch here

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

:youhou:


[JSON RPC] add fuzzing for JSON RPC service

Motivation
Add fuzzing for JSON RPC service
Remove fuzzing for admission control service

@bors-libra r=phoenix-antigravity

:pushpin: Commit 593746a has been approved by phoenix-antigravity

:hourglass: Testing commit 593746a2c31faa20b24f4e786e8de5e868996320 with merge 45a1c23fdfdc59084f9d78831fa5398b8675629a...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

@bors-libra r=phoenix-antigravity

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #2983

:pushpin: Commit 593746a has been approved by phoenix-antigravity

:hourglass: Testing commit 593746a2c31faa20b24f4e786e8de5e868996320 with merge a7612ac46192619ce069f93a177ac9722641b110...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: phoenix-antigravity
Pushing a7612ac46192619ce069f93a177ac9722641b110 to master...


I want to use accelerate for multi-new card inference, but I don't know how to set some of the parameters

model = load_checkpoint_and_dispatch(model, model_path, device_map="auto", no_split_module_classes=["?????"], dtype=torch.float16)
I don't know which modules can't be split, I hope the developers or others will give a list
Thanks！

I don't think you necessarily have to set that. Are you seeing an issue? Otherwise you typically set this to the name of the repeated module in the transformer architecture. If you just 'print' the model object itself in the pipeline, it'll show you the architecture and should be obvious, I just don't have it in front of me. It's a normal gpt-neox-based model


Update README.md

You could use this ESPHome component instead of the Riemann sum Integration: https://github.com/syssi/esphome-jk-bms/blob/main/yaml-snippets/esp32-ble-energy-dashboard.yaml


fix links error in guide

link in the guide leads to nothing, so here's the way how to fix it

Wow im dumb. Thanks!

Sorry accidentally closed it.


Refactor blackhole connector

Overview

Remove deprecated beginInsert usage
Use a method reference instead of lambda
Use assertEquals if applicable

Thanks!


connectionStateUpdatedTime from device identity not available in device twin

most of the fields in the device identity are available through the device twin (for example: connectionState is in both the device identity and the device twin), but connectionStateUpdatedTime is only in the device identity.  can it be added to the device twin?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e8b0b77-3c5d-5d9f-8f78-d750f5e620e5
Version Independent ID: c6eafb84-e897-5d29-f217-70de61273fea
Content: Understand the Azure IoT Hub identity registry
Content Source: articles/iot-hub/iot-hub-devguide-identity-registry.md
Service: iot-hub
GitHub Login: @wesmc7777
Microsoft Alias: wesmc

@larsonmpdx Thanks for the feedback! We are currently investigating and will update you shortly.

Hello @larsonmpdx this is a good observation\feedback! If I read here:
"Device identity properties. The root of the device twin JSON document contains the read-only properties from the corresponding device identity stored in the identity registry."
I would, like you, expect that "connectionStateUpdatedTime" property was added to device twin.
Please allow us some time to understand if we need to fix the doc or if that property will start showing on device twin's.
In the meantime what I would suggest is that you add that property to device twin using service\device iot sdk.
Thank you!

We have updated the document to mention that connectionStateUpdatedTime is not in the device twin JSON. This should show up in the document tomorrow. connectionStateUpdatedTime is something which we use internally. We would like to understand what the customer truly needs. If they want to know the connection time for the device, we recommend subscribing to Event Grid event - device connected and device disconnected. The event timestamp can be used as an estimate for connection time. - https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-event-grid#event-types

Thanks, Ashita.  I'll pass this info along to the customer

From: ash2017<EMAIL_ADDRESS>Sent: Wednesday, April 15, 2020 6:57 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Wesley McSwain<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] connectionStateUpdatedTime from device identity not available in device twin (#44935)
We have updated the document to mention that connectionStateUpdatedTime is not in the device twin JSON. This should show up in the document tomorrow. connectionStateUpdatedTime is something which we use internally. We would like to understand what the customer truly needs. If they want to know the connection time for the device, we recommend subscribing to Event Grid event - device connected and device disconnected. The event timestamp can be used as an estimate for connection time. - https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-event-grid#event-typeshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fiot-hub%2Fiot-hub-event-grid%23event-types&data=02|01|wesmc%40microsoft.com|1ffbca0154944606688f08d7e1906cf0|72f988bf86f141af91ab2d7cd011db47|1|0|637225882732077784&sdata=6w%2F235ClV5flkWeGS2v8ClsT08nZutsK3Jb%2BHjrj4TM%3D&reserved=0
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F44935%23issuecomment-614320656&data=02|01|wesmc%40microsoft.com|1ffbca0154944606688f08d7e1906cf0|72f988bf86f141af91ab2d7cd011db47|1|0|637225882732077784&sdata=75GR1QDYZ%2B59YPpABORGcEOv1MOiglLdL2OK%2By6Pp7M%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABKR7KAHI7JISUXIHPCPOEDRMY3W7ANCNFSM4J4UPDRQ&data=02|01|wesmc%40microsoft.com|1ffbca0154944606688f08d7e1906cf0|72f988bf86f141af91ab2d7cd011db47|1|0|637225882732087778&sdata=WEdLWyLEARhfUMXcfSzPihYLR6XgTmm6ohl%2B5l%2F8O60%3D&reserved=0.

I need connection updated time without the complication of tracking connect/disconnect events.  I'm able to get what I need by looking at the device identity, thanks.

#please-close


Uber Jar Blocks Basic HTTP Authentication

Now that the SMT build includes code for HTTP Basic Authentication, we were able to complete the path to loading a jar with the changes to our development K8s cluster and, from there, an instance of Kafka Connect.  Unfortunately, the were were still unable to complete a Basic HTTP Authentication, despite test cases implemented here that suggested all should be working fine.
Investigating the issue turned up two root causes, only one of which had a short-term workaround.  The issue that we could not work around did not manifest in the test suite because the tests are evaluated before the Maven shade plugin has relocated the Schema Registry client code from io.confluent to cricket.jmoore.confluent.
The relocation is an issue because the shade plugin is currently not configured to apply transformations specific to Java's ServiceProvider extension mechanism.  The Basic HTTP Authentication modules are implemented using this mechanism, so once relocated the /META-INF/services/io.confluent.kafka.schemaregistry.client.security.basicauth.BasicAuthCredentialProvider file from schema-registry-client.jar no longer enumerates the three strategy implementations, one for each of the three possible configurable values for basic.auth.credentials.source.  Since no implementation for any of the defined authentication strategies is found, the relocated client simply ignores otherwise valid authentication specification properties.
The simple correction is to add a directive to the Maven Shade plugin's configuration that informs it the relocated jar contains Service Providers.  It then takes care of renaming the file under /META-INF/services and changing each line entry as well, after which the client is able to locate its implementation classes.

Handled by #17 ?

Yes indeed.  This was the tougher of the two issues to identify, but the easier to fix.  I submitted a partial PR for the other one that includes a failing test case illustrating the problem, but have not yet created its corresponding issue yet, although I did describe the issue in that PR's comments already.


Improved array test coverage

Reached 100% line coverage on arrays tests.
Added FizzBuzz test case that wasn't previously tested and other intervals inside FizzBuzzTest

I was working on the repo as well, so there were conflicts. It was easier to integrate manually your suggestions. Thank you!


fix: Replace local-exec sleep with time_sleep

Description

Replace local-exec sleep with time_sleep to wait for dependency resources to get created and destroyed properly.
Motivation and Context

As per: https://github.com/hashicorp/terraform-provider-aws/issues/11025#issuecomment-660059684, using local-exec sleep was a temporary fix, time_sleep is more suited for specifically managing cross-platform compatibility and destroy-time issues.
Breaking Changes

N/A
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

CC: @antonbabenko

Does anyone know how I can fix the MAX TF pre-commit hook: https://github.com/terraform-aws-modules/terraform-aws-dms/runs/7408469458?check_suite_focus=true? I am not sure what I need to change to pass this check.

Do you know when this will be reviewed by? @bryantbiggs

This PR is included in version 1.5.3 :tada:


Unexpected unwrap in invalid_escape_sequence.rs

Been getting these errors in vs code as of late:
thread 'main' panicked at crates\ruff_linter\src\rules\pycodestyle\rules\invalid_escape_sequence.rs:215:18: called `Option::unwrap()` on a `None` value note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace )

This error message asked me to post here.
Would like to point out this usually happens while I'm typing code, so obviously there are going to be syntax errors but I'm not sure why Ruff is trying to parse them. If I need to post this on a different repo please let me know.

Thank you. Do you happen to know what version of Ruff you're using? Or of the VS Code extension?

I update all my extensions and be code daily but I can check this next Im at my pc. Thanks for the quick response. Am running windows 10

Usually happens when I'm actively typing f strings, or when I'm backspacing some of statements

It sounds like this was resolved in newer versions of Ruff, based on this similar issue: https://github.com/astral-sh/ruff/issues/9542.

Can confirm I haven't had it happen in two weeks


bsim: test: fix missing of warnings in bsim test build system

bsim test build system hides compile warnings.
This commit adds extra cc flags to prevent this.
Signed-off-by: Aleksandr Khromykh<EMAIL_ADDRESS>

yep, fix another issue is here https://github.com/zephyrproject-rtos/zephyr/pull/38205
btw, you are reviewer there :)

yep, fix another issue is here #38205
btw, you are reviewer there :)

Oh, that is a bigish PR.
If it is difficult for you to separate the commit here and then remove it in the other place after this is merged (you'd do a rebase of that other branch and drop the offending commit after this was merged), I guess we can ignore here the small fix out of place..


[FEATURE] Generate aws-sdk style client

Describe the feature
AWS SDK v3 client follows a pattern of Command/Input/Output. I can generate this type of client when I add this into type_safe_api.TypeSafeApiProject config:
          smithyBuildOptions: {
            projections: {
              "ts-client": {
                plugins: {
                  "typescript-codegen": {
                    package: `${apiDefaults.name}-client`,
                    packageVersion: "0.0.1",
                  },
                },
              },
            },
            maven: {
              dependencies: [
                "software.amazon.smithy:smithy-validation-model:1.43.0",
                "software.amazon.smithy:smithy-openapi:1.43.0",
                "software.amazon.smithy:smithy-aws-traits:1.43.0",
                "software.amazon.smithy.typescript:smithy-typescript-codegen:0.19.0",
                "software.amazon.smithy.typescript:smithy-aws-typescript-codegen:0.19.0",
                "software.amazon.smithy:smithy-model:1.43.0",
                "software.amazon.smithy:smithy-cli:1.43.0",
              ],
            },
          },

This config generates a client package in api/model/build/smithyprojections/<packageName>/ts-client/typescript-codegen but pdk/projen/nx do not see it, so it requires additional effort to publish this code to npm.
I'd like pdk to generate this code into api/generated similar to generated/runtime/typescript with all required projen configs
Use Case
It would be more consistent with existing AWS SDK to have client generated by smithy typescript generator.
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

PDK version used
0.22.49
What languages will this feature affect?
No response
Environment details (OS name and version, etc.)
macOS

Thanks for raising this Cyprian! We'd definitely like to build in better support for Smithy generated libraries (the existing runtimes/libraries etc are all generated from the OpenAPI projection for Smithy).
As you mentioned it is a bit of extra effort, but it is possible to get Smithy generators working and the generated code hooked up with the monorepo. I put together an example of this a little while ago here: https://github.com/cogwirrel/tsapi-smithy-client-example/ - it's pretty old but the same method should still work, essentially:

Add a projection to generate the client as you did above
Create a TypeScriptProject for the Smithy generated TS client, specifying all the dependencies (since the monorepo install happens before build we need the dependencies up front so can't use the smithy generated package.json so easily)

https://github.com/cogwirrel/tsapi-smithy-client-example/blob/8f1fbd29b4ed0e9893a62989cde69ea3837006e6/.projenrc.ts#L85

Add an implicit dependency on the model so that the project builds after the model
Add a pre-compile task to copy the source code out of the smithy build directory, into the source directory of the TypeScriptProject

https://github.com/cogwirrel/tsapi-smithy-client-example/blob/8f1fbd29b4ed0e9893a62989cde69ea3837006e6/.projenrc.ts#L140-L152

The workaround is a bit cumbersome though and it'd be awesome if Type Safe API could configure everything for you. To take it a step further it would be great if it could generate handler stubs which utilise the Smithy TS-SSDK instead of the Type Safe API handlers if users prefer.
I'm not sure when we'll be able to pick this up but it's certainly something we'd like to incorporate into Type Safe API!


make --autoconvert option import .safetensors too

Automatically import .ckpt and .safetensors files from a directory at startup time (like AUTO1111)
Since 2.3.0 launching invokeai with --autoconvert /path/to/directory would recursively search for .ckpt files in the directory, convert them into diffusers models, and import into models.yaml. This PR adds support for .safetensors as well.
Note that we use brittle heuristics to distinguish inpainting models from v1.x, from v2.x models -- if the model must contain 'inpaint' in its name or path, it is treated as a 1.5 inpainting model. If the key "model.diffusion_model.input_blocks.2.1.transformer_blocks.0.attn2.to_k.weight" is present in the checkpoint file and has a shape ending in 1024, then it is treated as a 2.x model.
The model's original VAE is always used. The VAE can be edited in the Web GUI and CLI, but possibly the VAE for all 1.X-derived models should be set to stability/sd-ft-vae. (comments welcome)

This PR is superseded by PR #2644


build(examples): add e2e path mapping to apps

Issue or need
In example apps, there are several imports using E2E fixture data
Those contain long relative paths traversing backwards ../../../ to reach the E2E directory
It's easy to mess those up

Proposed changes
Introduce a path mapping to refer to the E2E directory
Configure the example app creation script to set it up in tsconfig.json

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#522  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Added in basic floating support

Floating toggle support has been implemented. Floating modifier actions still need to be added, and focus l/r/u/d should also eventually try to support floating views.

Looks good for the most part. Testing now.

Works for me, let's get those issues dealt with and this is good to merge. Another thing - can we make pop-ups automatically floated?

Alright, everything should be good to go. I'll get on floating modifier stuff later today if I can.

Left a few more comments.

Alright, those should be taken care of.

:tada:


hamcrest v2.2

Upgrade to hamcrest v2.2 from v1.3

Build failure due to this travis error around the distribution. It's downloading snapshots, but won't the artifacts it needs be in a local repo? Otherwise what happens when multiple builds are happening at once?
[INFO] -----------------< org.apache.commons:commons-weaver >------------------
[INFO] Building Apache Commons Weaver Distribution 2.1-SNAPSHOT         [12/12]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Commons Weaver 2.1-SNAPSHOT:
[INFO]
[INFO] Apache Commons Weaver .............................. SUCCESS [ 13.941 s]
[INFO] Apache Commons Weaver Build Tools .................. SUCCESS [  2.122 s]
[INFO] Apache Commons Weaver Parent ....................... SUCCESS [  2.070 s]
[INFO] Apache Commons Weaver Processor .................... SUCCESS [  9.997 s]
[INFO] Apache Commons Weaver Maven Plugin ................. SUCCESS [  7.065 s]
[INFO] Apache Commons Weaver Antlib ....................... SUCCESS [  4.529 s]
[INFO] Apache Commons Weaver Modules aggregator project ... SUCCESS [  0.600 s]
[INFO] Apache Commons Weaver Privilizer Parent POM ........ SUCCESS [  0.561 s]
[INFO] Apache Commons Weaver Privilizer API ............... SUCCESS [  2.511 s]
[INFO] Apache Commons Weaver Privilizer Weaver ............ SUCCESS [ 20.172 s]
[INFO] Apache Commons Weaver Normalizer ................... SUCCESS [  4.485 s]
[INFO] Apache Commons Weaver Distribution ................. FAILURE [  3.089 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:12 min
[INFO] Finished at: 2020-10-13T07:21:49Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project commons-weaver: Could not resolve dependencies for project org.apache.commons:commons-weaver:pom:2.1-SNAPSHOT: The following artifacts could not be resolved: org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-privilizer-api:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-privilizer:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-normalizer:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-maven-plugin:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-antlib:jar:javadoc:2.1-SNAPSHOT: Could not find artifact org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]

@nhojpatrick
Please stop creating pull requests for version updates, we have Dependabot
for that. If a component you care about does not support Dependabot, then
provide a PR that adds Dependabot.
TY!
On Tue, Oct 13, 2020 at 4:03 AM John Patrick<EMAIL_ADDRESS>wrote:

Build failure due to this travis error around the distribution. It's
downloading snapshots, but won't the artifacts it needs be in a local repo?
Otherwise what happens when multiple builds are happening at once?
[INFO] -----------------< org.apache.commons:commons-weaver >------------------
[INFO] Building Apache Commons Weaver Distribution 2.1-SNAPSHOT         [12/12]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Commons Weaver 2.1-SNAPSHOT:
[INFO]
[INFO] Apache Commons Weaver .............................. SUCCESS [ 13.941 s]
[INFO] Apache Commons Weaver Build Tools .................. SUCCESS [  2.122 s]
[INFO] Apache Commons Weaver Parent ....................... SUCCESS [  2.070 s]
[INFO] Apache Commons Weaver Processor .................... SUCCESS [  9.997 s]
[INFO] Apache Commons Weaver Maven Plugin ................. SUCCESS [  7.065 s]
[INFO] Apache Commons Weaver Antlib ....................... SUCCESS [  4.529 s]
[INFO] Apache Commons Weaver Modules aggregator project ... SUCCESS [  0.600 s]
[INFO] Apache Commons Weaver Privilizer Parent POM ........ SUCCESS [  0.561 s]
[INFO] Apache Commons Weaver Privilizer API ............... SUCCESS [  2.511 s]
[INFO] Apache Commons Weaver Privilizer Weaver ............ SUCCESS [ 20.172 s]
[INFO] Apache Commons Weaver Normalizer ................... SUCCESS [  4.485 s]
[INFO] Apache Commons Weaver Distribution ................. FAILURE [  3.089 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:12 min
[INFO] Finished at: 2020-10-13T07:21:49Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project commons-weaver: Could not resolve dependencies for project org.apache.commons:commons-weaver:pom:2.1-SNAPSHOT: The following artifacts could not be resolved: org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-privilizer-api:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-privilizer:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-normalizer:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-maven-plugin:jar:javadoc:2.1-SNAPSHOT, org.apache.commons:commons-weaver-antlib:jar:javadoc:2.1-SNAPSHOT: Could not find artifact org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-weaver/pull/4#issuecomment-707566845,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJB6N7FEBJ7VCJLIC4P3WLSKQCT7ANCNFSM4SOHJFTA
.

@garydgregory As I noticed junit v4.13.1 had been released, I raised PR's
for every commons repo that was still using v4.x. Any repo where a
subsequent dependabot pr was raised for the same version, I subsequently
deleted my PR.
I did notice some commons projects were still using v4.10, 4.11 and 4.12,
so obviously dependabot isn't running for these.
I also noticed several commons projects where the master branch doesn't
build locally or pr fail to build on travis due to unrelated issues where I
added a comment on the pr about that issue.
From my view of a commons project I've no idea if Dependabot is running for
a given git repo. It might be that maintainers have chosen to
explicitly disable Dependabot. I also wasn't aware dependabot could be
enabled via a PR, I thought you had to go to Settings -> Security &
Analysis -> Dependabot alerts -> Enable.
Regarding hamcrest specifically, the artifacts have been refactored and
junit v4.x depends upon the older v1.x version. The artifacts
hamcrest-core, hamcrest-all and hamcrest-library were all circa 2018 when
v2.x was released, and replaced with simply hamcrest. So I wouldn't expect
Dependabot to upgrade hamcrest from v1.x to v2.x correctly without manual
intervention.
Also the error I've listed in this PR would happen for any PR raised,
irrespective if it was Dependabot or Human raising the PR. So you'll see
the same error if someone enabled Dependabot for commons-weaver for this
change.
John
On Tue, 13 Oct 2020 at 14:09, Gary Gregory<EMAIL_ADDRESS>wrote:

@nhojpatrick
Please stop creating pull requests for version updates, we have Dependabot
for that. If a component you care about does not support Dependabot, then
provide a PR that adds Dependabot.
TY!
On Tue, Oct 13, 2020 at 4:03 AM John Patrick<EMAIL_ADDRESS>wrote:

Build failure due to this travis error around the distribution. It's
downloading snapshots, but won't the artifacts it needs be in a local
repo?
Otherwise what happens when multiple builds are happening at once?
[INFO] -----------------< org.apache.commons:commons-weaver
[INFO] Building Apache Commons Weaver Distribution 2.1-SNAPSHOT [12/12]
[INFO] --------------------------------[ pom
]---------------------------------
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/maven-metadata.xml
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from sonatype-snapshots:
https://oss.sonatype.org/content/repositories/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-processor/2.1-SNAPSHOT/commons-weaver-processor-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer/2.1-SNAPSHOT/commons-weaver-privilizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-privilizer-api/2.1-SNAPSHOT/commons-weaver-privilizer-api-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-normalizer/2.1-SNAPSHOT/commons-weaver-normalizer-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-maven-plugin/2.1-SNAPSHOT/commons-weaver-maven-plugin-2.1-SNAPSHOT-javadoc.jar
[INFO] Downloading from apache-snapshots:
https://repository.apache.org/snapshots/org/apache/commons/commons-weaver-antlib/2.1-SNAPSHOT/commons-weaver-antlib-2.1-SNAPSHOT-javadoc.jar
[INFO]

[INFO] Reactor Summary for Apache Commons Weaver 2.1-SNAPSHOT:
[INFO]
[INFO] Apache Commons Weaver .............................. SUCCESS [
13.941 s]
[INFO] Apache Commons Weaver Build Tools .................. SUCCESS [
2.122 s]
[INFO] Apache Commons Weaver Parent ....................... SUCCESS [
2.070 s]
[INFO] Apache Commons Weaver Processor .................... SUCCESS [
9.997 s]
[INFO] Apache Commons Weaver Maven Plugin ................. SUCCESS [
7.065 s]
[INFO] Apache Commons Weaver Antlib ....................... SUCCESS [
4.529 s]
[INFO] Apache Commons Weaver Modules aggregator project ... SUCCESS [
0.600 s]
[INFO] Apache Commons Weaver Privilizer Parent POM ........ SUCCESS [
0.561 s]
[INFO] Apache Commons Weaver Privilizer API ............... SUCCESS [
2.511 s]
[INFO] Apache Commons Weaver Privilizer Weaver ............ SUCCESS [
20.172 s]
[INFO] Apache Commons Weaver Normalizer ................... SUCCESS [
4.485 s]
[INFO] Apache Commons Weaver Distribution ................. FAILURE [
3.089 s]
[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 01:12 min
[INFO] Finished at: 2020-10-13T07:21:49Z
[INFO]

[ERROR] Failed to execute goal on project commons-weaver: Could not
resolve dependencies for project
org.apache.commons:commons-weaver:pom:2.1-SNAPSHOT: The following artifacts
could not be resolved:
org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT,
org.apache.commons:commons-weaver-privilizer-api:jar:javadoc:2.1-SNAPSHOT,
org.apache.commons:commons-weaver-privilizer:jar:javadoc:2.1-SNAPSHOT,
org.apache.commons:commons-weaver-normalizer:jar:javadoc:2.1-SNAPSHOT,
org.apache.commons:commons-weaver-maven-plugin:jar:javadoc:2.1-SNAPSHOT,
org.apache.commons:commons-weaver-antlib:jar:javadoc:2.1-SNAPSHOT: Could
not find artifact
org.apache.commons:commons-weaver-processor:jar:javadoc:2.1-SNAPSHOT in
sonatype-snapshots (
https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/commons-weaver/pull/4#issuecomment-707566845
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAJB6N7FEBJ7VCJLIC4P3WLSKQCT7ANCNFSM4SOHJFTA
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-weaver/pull/4#issuecomment-707726701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABCXYDSPKH4C2UWGNDUILTSKRGRRANCNFSM4SOHJFTA
.

@garydgregory so dependabot has still not detected hamcrest v2.2 is available and is still stuck on v1.3, so trying to get merged in again.


Tasks of new commits are not propagating

Tasks of latest commits do not seem to be created correctly.  One from /api/refresh-chromebot-status

I switched it back to yesterday's version, and it seems working through now.
/cc @CaseyHillers

Related to https://github.com/flutter/cocoon/pull/1111
    if (prNumber != null) {
      ref = kDefaultBranchName;
    } else if (branch != kDefaultBranchName) {
      ref = branch;
    } else if (commitSha != null) {
      ref = commitSha;
    } else {
      loggingService.warning('Failed to find place for builders, using default branch');
      ref = kDefaultBranchName;
    }

The issue seems to be in branch != kDefaultBranchName, as we need to check if it's null as well.

Moving out of ticket queue as its no longer blocking prod. When we reland the PRs, we need to add regression tests to prevent this breakage.

Discussed offline, going to go with a different approach that doesn't modify this logic.


Release 2.3.1-b180717.0505 is not visible in Maven Central/Repo

Hello,
there was a fix for the problem
"Fix XJC ant task to work without fork. "
created with this commit:
https://github.com/javaee/jaxb-v2/commit/dad8495f19078cb05302132f83dafda5b3dfa98b#diff-9e91db6a172b85bd4a5588d9aa151e85
We checked the released versions of jaxb and this bugfix can be found starting from the
release 2.3.1-b180717.0505, but this release has never made it to Maven Central or Maven Repo.
We tried to get 2.4.x running, but we get a lot of dependency issues and compaitiblity problems there, therefore the most simple solution would be, if someone could create another 2.3.x release and make it official in Maven Central or make the release 2.3.1-b180717.0505 available there.
Thank you very much for the support in advance.
best Regards,
Reza

How is it going with publishing 2.3.1 to maven central?

2.4.0-b180830.0438 which is released to central is very similar to what
2.3.1 in staging now contains. You can test with that until 2.3.1 release.
Roman
On Tue, Oct 2, 2018 at 12:52 PM jbliznak<EMAIL_ADDRESS>wrote:

How is it going with publishing 2.3.1 to maven central?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/eclipse-ee4j/jaxb-ri/issues/1213#issuecomment-426230887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI8Ztu-SSavOgR2ZUlcroQgrFnIFvpxOks5ug0WIgaJpZM4W0kVV
.

It's on the way, should be there in <6hours

2.3.1 is in central now, closing this issue.


Running any program with primusrun results in  X Error of failed request:  BadValue

I've installed primus by following https://fedoraproject.org/wiki/Bumblebee. Previously i had no such problems on this laptop, but after recent reintall i get following error when i try to start most 3d applications
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  155 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  28
  Current serial number in output stream:  29

Here's output from glsanity-bbee:
[vharabar@localhost glsanity-bin]$ ./glsanity-bbee
Checking native (usually Mesa/i965) GL
Running 32-bit tests
info:  libGL.so.1:      loaded from: /lib/libGL.so.1
info:  libGL.so.1:      symlink to:  /usr/lib/libGL.so.1.2.0
info:  X display:       :0
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": not present; OK for non-nVidia drivers
info:  GLX server:      SGI
info:  GLX client:      Mesa Project and SGI
info:  GL vendor:       Intel Open Source Technology Center
info:  GL renderer:     Mesa DRI Intel(R) Haswell Mobile
info:  GL version:      3.0 Mesa 13.0.2
Running 64-bit tests
info:  libGL.so.1:      loaded from: /lib64/libGL.so.1
info:  libGL.so.1:      symlink to:  /usr/lib64/libGL.so.1.2.0
info:  X display:       :0
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": not present; OK for non-nVidia drivers
info:  GLX server:      SGI
info:  GLX client:      Mesa Project and SGI
info:  GL vendor:       Intel Open Source Technology Center
info:  GL renderer:     Mesa DRI Intel(R) Haswell Mobile
info:  GL version:      3.0 Mesa 13.0.2
Checking secondary (usually NVIDIA) GL
Running 32-bit tests
info:  libGL.so.1:      loaded from: /usr/lib/nvidia-bumblebee/libGL.so.1
info:  libGL.so.1:      symlink to:  /usr/lib/nvidia-bumblebee/libGL.so.1.0.0
info:  X display:       :8
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": present
info:  GLX server:      NVIDIA Corporation
info:  GLX client:      NVIDIA Corporation
info:  GL vendor:       NVIDIA Corporation
info:  GL renderer:     GeForce GTX 850M/PCIe/SSE2
info:  GL version:      4.5.0 NVIDIA 375.20
Running 64-bit tests
info:  libGL.so.1:      loaded from: /usr/lib64/nvidia-bumblebee/libGL.so.1
info:  libGL.so.1:      symlink to:  /usr/lib64/nvidia-bumblebee/libGL.so.1.0.0
info:  X display:       :8
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": present
info:  GLX server:      NVIDIA Corporation
info:  GLX client:      NVIDIA Corporation
info:  GL vendor:       NVIDIA Corporation
info:  GL renderer:     GeForce GTX 850M/PCIe/SSE2
info:  GL version:      4.5.0 NVIDIA 375.20
Testing offloading with primus
Running 32-bit tests
info:  libGL.so.1:      loaded from: /usr/lib/nvidia-bumblebee/libGL.so.1
info:  libGL.so.1:      symlink to:  /usr/lib/nvidia-bumblebee/libGL.so.1.0.0
info:  X display:       :0
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": not present; OK for non-nVidia drivers
info:  GLX server:      SGI
info:  GLX client:      NVIDIA Corporation
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  155 (GLX)
  Minor opcode of failed request:  24 (X_GLXCreateNewContext)
  Value in failed request:  0x0
  Serial number of failed request:  22
  Current serial number in output stream:  23
Running 64-bit tests
info:  libGL.so.1:      loaded from: /usr/lib64/primus/libGL.so.1
info:  X display:       :0
info:  X Ext. "GLX":    present
info:  X Ext. "NV-GLX": not present; OK for non-nVidia drivers
info:  GLX server:      NVIDIA Corporation
info:  GLX client:      primus
info:  GL vendor:       NVIDIA Corporation
info:  GL renderer:     GeForce GTX 850M/PCIe/SSE2
info:  GL version:      4.5.0 NVIDIA 375.20

As glsanity indicates, you're missing 32-bit primus library: it should be at /usr/lib/primus/libGL.so.1

Thank you, i had fixed the issue by installing .i686 version of package. Also, that message does not tell directly that 32-bit library is missing, only that the replacement so is not functioning. It would be nice if you had added some indication to what intended path should look like for the likes of me.

glsanity readme already shows the intended paths; also, in this case, comparing 32-bit test output against 64-bit test output also hints where the issue lies.


Prometheus 2.0.0-beta.0 gaps in metrics

I'm running the prometheus 2.0.0-beta.0 in our kubernetes 1.7.1 cluster and it's having trouble with gaps in the metrics which are scraped from cadvisor. Prometheus 1 .7.0 scrapes them fine:
2.0.0-beta.0

1.7.0

Scrape rule:
- job_name: kubernetes-cadvisor
  scrape_interval: 15s
  scrape_timeout: 10s
  metrics_path: /metrics
  scheme: https
  kubernetes_sd_configs:
  - api_server: null
    role: node
    namespaces:
      names: []

There's nothing suspicious in the logs.

The gaps are probably real, and this is the new staleness handling. Are you sure that the containers in question were returned at every scrape?

Are you sure that the containers in question were returned at every scrape?

I need to dig into this deeper.

The gaps are probably real, and this is the new staleness handling.

You can't always control what you're scraping so I'm wondering whether it makes sense to allow overriding this behavior per target.

I'm wondering whether it makes sense to allow overriding this behavior per target.

It's all or nothing.

The /metrics endpoint actually randomly alters between showing systemd cgroups and docker containers. So this is clearly a bug in kubernetes/cadvisor.
See:
https://github.com/prometheus/prometheus/issues/2916
https://github.com/kubernetes/kubernetes/issues/48483

The linked k8s issue does not resolve this in general I think.
Even after the fix, the cAdvisor endpoint exposes a lot of metrics only occasionally.

Just upgraded to 2.0.0-beta.0 seeing the same "gaps" with the cAdvisor target.
@fabxc - I'm not familiar with the staleness handling, but my understanding is in that case prometheus 1.7 metrics would be inaccurate too and therefore there's no point for us rolling back ?

Yea, so cAdvisor metrics are flapping on and off. 2.0 just happens to detect this and set staleness markers.
Practically, it's just reduced sampling frequency so what 1.7 shows is not totally wrong.
Overall it's definitely a cAdvisor issue though https://github.com/google/cadvisor/issues/1704


Add Private IP Configuration to CloudSQL

Terraform apply and tested the jobs.
The ray job and frontend app needs to run in the same network as the private IP configuration.

@sunnylovestiramisu
https://github.com/terraform-google-modules/terraform-google-sql-db/blob/v19.0.0/examples/mysql-psc/main.tf
lets use cloudsql module. it has additional user support + psc networking...

Opened #398 to address this feature request