[BUG] when changing current folder, old session file gets cleared

Describe the bug
Within a development session (with some buffers and tabs open, as well as a freshly saved session file done e.g. by SaveSession), changing the current folder to something else using cd <new-folder-path> re-initializes the session file of the former session.
To Reproduce
Steps to reproduce the behavior:

open nvim
move into favorite (or test) folder
open some tabs and buffers
create session by executing SaveSession
-> a session file is created within the respective session folder
leave the current folder by e.g. cd ..
-> a message is shown in the nvim status line saying "... buffers were deleted"
-> the former session file has been re-initialized (see e.g. file size as hint)

Expected behavior
When changing from one current folder to another, I would expect all session files to stay untouched. A write of a session file should only happen on the respective vim autocommand (default would be "nvim leave"). So, only on nvim leave (close nvim), the most recent session file should be updated if configured so.
Baseline (please complete the following information):

Result of set sessionoptions?:
sessionoptions=blank,buffers,curdir,folds,help,tabpages,winsize,terminal
OS. e.g uname -a:
Windows 10
Neovim version nvim --version:
v0.9.0-dev

What does your setup call look like?

You are probably not setting cwd_change_handling like the readme mentions

Hi,
I have been and I am still setting cwd_change_handling in my plugin configuraion, like:
  use {
    'rmagatti/auto-session',
    config = function()
      require("auto-session").setup {
        log_level = "error",
        auto_session_suppress_dirs = {
            "~/",
            "~/Projects",
            "~/Downloads",
            "/"
        },
        cwd_change_handling = {
          restore_upcoming_session = true,   -- already the default, no need to specify like this, only here as an example
          pre_cwd_changed_hook = nil,        -- already the default, no need to specify like this, only here as an example
          -- post_cwd_changed_hook = function() -- example refreshing the lualine status line _after_ the cwd changes
          --   require("lualine").refresh()     -- refresh lualine so the new session name is displayed in the status bar
          -- end,
        },
      }
    end
  }

As I am not using lualine, yet, I commented those lines out in order to prevent possible errors. But, anyway, the readme says that those active arguments for cwd_change_handling would be default. They should not make any difference in behavior, right?

Yes, correct. The behaviour is a bit weird with cwd_change_handling but the setup function you got there is correct and should work, that said, Windows is not really "officially" supported, as in I don't use Windows myself. It's very possible this is a Windows-specific issue, PRs are welcome if you'd like to dig deeper into it though!

I just configured "debug" mode for auto-session and recorded the outputs while doing the things I mentioned in the messages above. maybe by reading the debug messages, you could give me a hint where to start digging into the code? I would love to help by providing a PR, but as my time is very limited, I would like to ask for your support understanding your code:
After the start of neovim without specifying a specific folder, I see this when issuing :messages:
debug:  ==== Pager mode
debug:  sessions_dir, session_file
debug:  ==== Using session DIR
debug:  ==== Session Name:
debug:  ==== is_readable
info:  Session restored from C:\Users\user\AppData\Local\nvim-data/sessions/C++\%PROGS\%Neovim__v0_9_0_dev\%bin.vim

here, everything looks fine to me. the old session was correctly loaded (and the filetype colors are fine). then, after issuing the command cd c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1, I recognize that the currently loaded session file has been cleared again. This path is a valid path but without a defined session, yet. which should not be any problem. and I see this within the messages:
debug:  DirChangedPre
debug:    cwd: C:\PROGS\Neovim__v0_9_0_dev\bin
debug:    target: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1\
debug:    changed window: false
debug:    scope: global
debug:  ==== is_allowed_dirs_enabled
debug:  bypass_save_by_filetype: false
debug:  ==== SaveSession
debug:  Session saved at C:\Users\user\AppData\Local\nvim-data/sessions/C++\%PROGS\%Neovim__v0_9_0_dev\%bin.vim
9 buffers deleted
debug:  DirChangedPre
debug:    cwd: C:\PROGS\Neovim__v0_9_0_dev\bin
debug:    target: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1\
debug:    changed window: false
debug:    scope: global
debug:  ==== is_allowed_dirs_enabled
debug:  bypass_save_by_filetype: false
debug:  ==== SaveSession
debug:  Session saved at C:\Users\user\AppData\Local\nvim-data/sessions/C++\%PROGS\%Neovim__v0_9_0_dev\%bin.vim
debug:  DirChangedPre
debug:    cwd: C:\PROGS\Neovim__v0_9_0_dev\bin
debug:    target: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1\
debug:    changed window: false
debug:    scope: global
debug:  ==== is_allowed_dirs_enabled
debug:  bypass_save_by_filetype: false
debug:  ==== SaveSession
debug:  Session saved at C:\Users\user\AppData\Local\nvim-data/sessions/C++\%PROGS\%Neovim__v0_9_0_dev\%bin.vim
debug:  DirChanged
debug:    cwd: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
debug:    changed window: false
debug:    scope: global
debug:  sessions_dir, session_file
debug:  ==== Using session DIR
debug:  ==== Session Name:
debug:  ==== is_readable
debug:  ==== is_readable
debug:  File not readable, not restoring session
info:  Could not load session. A session file is likely missing for this cwd.c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
debug:  DirChanged
debug:    cwd: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
debug:    changed window: false
debug:    scope: global
debug:  sessions_dir, session_file
debug:  ==== Using session DIR
debug:  ==== Session Name:
debug:  ==== is_readable
debug:  ==== is_readable
debug:  File not readable, not restoring session
info:  Could not load session. A session file is likely missing for this cwd.c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
debug:  DirChanged
debug:    cwd: c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
debug:    changed window: false
debug:    scope: global
debug:  sessions_dir, session_file
debug:  ==== Using session DIR
debug:  ==== Session Name:
debug:  ==== is_readable
debug:  ==== is_readable
debug:  File not readable, not restoring session
info:  Could not load session. A session file is likely missing for this cwd.c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1
c:\Users\user\_NEXTCLOUD\_TOOLS\_Python\project1

any tips?

another oddity is that the DirChangePre event seems to be executed multiple times after issuing cd ... . This could be the reason for re-setting the session file in the 2nd event round...

to me, it seems as if the 9 buffers deletes occurs before Session saved even though the messages tell otherwise. Maybe some operating system internal synchronization problem which could be solved by some technical means...

I am facing the same problem under OSX.
If i change the Session by cd into another project the new project gets restored correctly, if i change back into the old project, all the buffers are deleted. So it seems like the Buffers get deleted first and then the session is saved.
@rmagatti It seems like this is not only related to windows

@rmagatti
seems like there is a problem with:
-- vim.o.sessionoptions="blank,buffers,curdir,folds,help,tabpages,winsize,winpos,terminal,localoptions"

if i remove the sessionoptions, the buffers don't get cleared

Session options are required for anything to be stored in the session at all so I wouldn't think it's related to that

That said, I've had a few issues in the past around saving localoptions, maybe try unsettling that from your sessionoptions. But also, to be clear, buffers should get cleared right after the session is saved so switching to another session is done cleanly without bleeding of buffers between sessions.

Okay very strange, even if i remove the localoptions i still get the same behavior, every time i switch to another session and go back to the previous all buffers are gone. Like it first removes the buffers and afterwards it saves the session

Do you have a video or gif of the problem you can show?

i had the same issue, cwd_change_handling = nil works for me.
my current config:
vim.o.sessionoptions = "blank,buffers,curdir,folds,help,tabpages,winsize,winpos,terminal,localoptions"

require("auto-session").setup({
	log_level = "error",
	auto_session_create_enabled = false,
	auto_restore_enabled = true,
	auto_save_enabled = true,
	cwd_change_handling = nil,
	session_lens = {
		load_on_setup = true,
		theme_conf = { border = true, winblend = 0 },
	},
})
vim.keymap.set("n", "<leader>pS", require("auto-session.session-lens").search_session, {
	noremap = true,
})

require("telescope").load_extension("session-lens")

@levioneyh is correct, there's some handling in the code that checks whether cwd_change_handing has been passed in at all and that triggers some different behaviour currently

Hi folks,
hi @rmagatti ,
here is a (hopefully) descriptive screencast about the issue how it appears on my local Windows computer. Please disregard all the speaking mistakes and the missing structure. I would have put in much more time if I wanted to avoid all this ;-) .
Hope it helps clarifying the issue and finally finding a solution for people on Windows systems.
https://github.com/rmagatti/auto-session/assets/5845602/c4430bd0-d099-4840-b22b-32610b85401b
Please see the post up in this thread where I had the "debug" logging level switched on. It would resemble the inner operations of the plugin.
Thanks.

@levioneyh wrote:

i had the same issue, cwd_change_handling = nil works for me.

yes, that "works" in the sense that (at least in my case) it switches off any automatic save / restore operations on change dir. but thus, I have to do everything manually (using :RestoreSession and :SaveSession after / before changing dicrectories), again. what should I use the plugin for, except for storing all my sessions in one default place ;-) ?

@nnako
If you want to change between sessions you can use the session_lens extension, it changes the session, the cwd and does not delete the previous session (unless you don't want to use the extension). If you just want to change directories with :cd without the "n buffers were deleted" problem, cwd_change_handling = nil works. :RestoreSession is not needed in any of these cases. :SessionSave doesn't seem to be a problem to me, I just want some sessions and have them loaded when running nvim, be able to move between them and not have the Session.vim in the same directory as my other files. (and that's what I use the plugin for).

@levioneyh
thanks again. yes, I will have a look at session_lens and check with my preferred workflow. But, generally, it is a pitty to not be able to use the nice auto-session plugin on Windows systems in a way it was intended to be used. Even worse, I can not even pull the current version of it as then, the plugin does not work at all (for me at least). Hope that session_lens plays nicely with older versions of auto-session. We will see...

Hi folks. Sorry for all the confusion. I just saw that somehow, my local git repo of auto-session got messed up during all the jumping back and forth within the commit tree. In the end, I still e.g. had to use the command :RestoreSession and not the "new" command :SessionRestore to operate on stored sessions. And also, the session keys still looked and worked like this within the session folder:
c++%Users%pkohm%_NEXTCLOUD%_TOOLS%_Python%LIB__freeplane.vim

instead of this:
c++-Users-pkohm-_NEXTCLOUD-_TOOLS-_Python-LIB__freeplane.vim

SOLUTION
So, in the end, I removed my local auto-session repo and cloned it again, manually. The plugin manager is in sync with the current state.
CONCLUSION
Now, the file structure seems the same as seen on the project GitHub site, again. And there are NO WARNINGS and NO ERRORS when starting neovim, anymore. Using the parameter cwd_change_handling = nil switches off the auto buffer save / restore, still. But when using the provided commands :SessionRestore and :SessionSave, after changing directories works fine. Even the file types are restored correctly :-) .
I will close this issue, now, as it I consider it "solved" for me.
Thanks to all of you for your support.


CSS bug on Shellbar in master detail page

OpenUI5 version:
1.110.0
Browser/version (+device/version):
Chrome, FF, IE (latest)
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible):
plnkr
Steps to reproduce the problem:

Add Shellbar to a master - detail Open UI5 page

What is the expected result?
Master - List should display items and be offset to exactly below the shellbar

What happens instead?
The Master - List is incorrectly offset by only 2.75rem, it needs to be offset by 3.25rem to be below the shellbar. So it does stick into the shellbar.

The team decided to work on this issue via backlog item BGSOFUIPIRIN-6322. Updates will be posted here.


add path run_time plan & unit case

Others LGTM. Maybe we need some documents to explain the steps of plan generation for FIND PATH concisely.

writing it


Increase information sharing

Single fold currently only looks at the chunk it is operating on. This produces more discontinuities than necessary. Introduce a pattern of taking all known edges and sharing them with each chunk, then search over each chunk in the context of all known edges. For merging, the same pattern can be applied. If a new corpus is added, it can update the single global store of all known edges and anything folded or merged after will take that into account. Anything from before will be set up for a larger merge.

As a note - this won't eliminate all discontinuities. Merge should still find things based upon results from each chunk (sifting)

Oddly, this does not work. It slows progress on single more than is worth it by a wide margin.


Adding end date info to the CourseInfoBox

What are the relevant tickets?
Related to https://github.com/mitodl/hq/issues/2833
Related to https://github.com/mitodl/hq/issues/2834
Description (What does it do?)
Updates the course info box to show:

end dates for all active course runs
The More Dates button is now dark blue and when you hover becomes red
updates the styles and text of the icons and the text for information about start and ends dates for all the runs.

This PR only addresses the Course Start and End dates section not the whole info box.
Screenshots (if appropriate):

How can this be tested?
Have a course with multiple active course runs (enrollment open). Go to the the course product page and verify that the functionality is still there and the design is as described here.

@collinpreston this is ready for a second review. Thanks!


Fix IconButton leaks its internal MaterialStatesController

Description
This PR adds a call to dispose the internal MaterialStatesController instantiated by _SelectableIconButtonState.
I found this memory leak while working on M2/M3 test update for about_test.dart. This memory leak only happens when using M3 because IconButton relies on _SelectableIconButton only when useMaterial3 is true:
https://github.com/flutter/flutter/blob/3a1190a5a85c3e6a0cf3a9c30f34548fdd48ac1e/packages/flutter/lib/src/material/icon_button.dart#L671-L721
Related Issue
Fixes https://github.com/flutter/flutter/issues/130708
Tests
Adds 1 test.

Oops I misclicked.


The issue seems to be @Preocts losing connection with the bed. I propose we establish a 2-way connection between @Preocts and the bed


Escape spaces in rustflags

This is a PR originally filed by @AxelMontini  for xargo: https://github.com/japaric/xargo/pull/221
Below the originial PR description:

Fixes an error on windows where paths with whitespaces don't get escaped at all, causing the error error: multiple input filenames provided. In my case it happens because my Windows username is "Axel Montini" and xargo doesn't like the space in the middle.
This commit adds a function in utils to escape a string and replace spaces with %20 on windows or \ on other operative systems.
I haven't tested this on a Unix machine, but it seems to work on windows.

@phil-opp, you can merge it if it works.

@AxelMontini Thanks!
I just tested in on Linux and it seems like \ escapes for spaces do not work:
> rustc - --crate-name ___ --print=file-names --sysroot /…/blog\ os/target/sysroot --target /…/blog os/x86_64-blog_os.json --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro

error: multiple input filenames provided

@phil-opp I'm not sure what is going on, but it looks like the target path isn't escaped. I've probably forgot to escape it somewhere. If you use a --target path that doesn't contain spaces it should work.

Oh, good catch! I completely missed the space in the target path.
Seems like the problem is in cargo:
> RUSTFLAGS="--sysroot /[…]/blog\ os/target/sysroot" "cargo" "build" "--target" "x86_64-blog_os.json" "--verbose"
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --sysroot /[…]/blog\ os/target/sysroot --target /[…]/blog os/x86_64-blog_os.json --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro` (exit code: 101)
--- stderr
error: multiple input filenames provided

Cargo canonicalizes the target path because it switches the working directory when compiling dependencies, but it does not escape it or wrap it in spaces.

Ok, it just seems to be a printing problem, not a bug in cargo.
The real problem is that rustc does not interpret the escaped spaces correctly:
RUSTFLAGS="--sysroot /home/philipp/blog\ os/target/sysroot" "cargo" "build" "--target" "/home/philipp/x86_64-blog_os.json" "--verbose"

This command has an escaped space in the sysroot path and no space in the target path. It still produces the "multiple input filenames provided" error.

@phil-opp after depressing myself in a various number of unsuccessful attempts, I've (probably) found an ugly workaround to this. Since rustc fails to parse a path with spaces and believes that it's two arguments instead, I've tried to create a symlinked directory /tmp/tmp-sysroot pointing to /home/.../project with spaces/.../sysroot. Setting rustflags to --sysroot /tmp/tmp-sysroot works and cargo build finishes successfully.
It's probably a pain to implement but I don't see why it shouldn't work.
Explained easier:
ln -s /the/path/target/sysroot /tmp/tmp-sysroot
export RUSTFLAGS="--sysroot /tmp/tmp-sysroot"
cargo build
Should we try to implement this on Unix systems or try a more universal approach, like using symlinks to the sysroot both on Windows and on Unix by default?

It's not a definitive solution, but it should at least solve the problem for Windows users. We can change the escape function to escape only on Windows and simply return the unchanged string on non-windows systems.

Ok, sounds good! Could you add a comment that explains why we only escape on Windows?

It's my first contribution on GitHub, so I'm not sure how it works. I've opened a pull request to merge to this branch so the final version can be ultimately merged to master.

@AxelMontini Thanks a lot! Released as 0.4.5.


Error in Windows 7 environment

@minwoo-jung
hello：
I turn on the pinpoint in the window environment
Error in Windows 7 environment：
ClassNotFoundException：com.naver.pinpoint.common.util.CodeSourceUtils
The native Java environment is normal，The package was downloaded from the official website。
Please help me thank you

It is very difficult to find the cause of a problem by using an exception message alone.
Please answer all the questions below.

Prerequisites
Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

[ ] I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?
master/v1.7.3/v1.7.2 etc.
Describe the bug
A clear and concise description of what the bug is.
What did you do to trigger the bug?
Steps to reproduce, for example:

Ran '...' with agent attached
'...' method invoked
'...' interceptor threw '...' exception

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
If applicable, please attach agent/collector/web DEBUG log that includes the code execution that led to the bug. In case of agents, including the start-up log may be of great help.
Additional context
Add any other context about the problem here, such as affected library for agents, how your collector/web/hbase is set up if applicable.

@minwoo-jung

 I used the version 1.8.3 and I download  in  official  website ，I used the version java <IP_ADDRESS> . in Windows 7 environment

After I start the call jar package ,I got the error:  ClassNotFoundException：com.naver.pinpoint.common.util.CodeSourceUtils

please help me thank you

Upgrade old JVM.

Your JVM is too old. 1.6.0_45 is recommended.

https://docs.oracle.com/javase/6/docs/api/java/lang/instrument/package-summary.html
There seems to be a problem with the Boot-Class-Path behavior in older JVMs.

Upgrade Pinpoint version

1.8.5 is recommended

Try the above recommendations.


Add concern which handles reordering records within a class

Description
This sort of follows on from https://github.com/alphagov/whitehall/pull/8557 which adds an association extension for reordering a models associations using the various ordering columns.
This adds very similar functionality but within a concern which handles reordering records within a class .
The final couple of commits update TakePartPages' to use the new concern. This may or may not be better. Very open to discussion. I've laid out my logic for doing so in the commit message
Trello card
https://trello.com/c/JoE5X6uD/2205-at-least-one-workflow-in-whitehall-relies-on-skipping-validations-as-some-organisations-are-known-to-be-invalid
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

I think I'd like for us to decouple the reorderable module tests from our application models, if at all possible.

Also, and I should have led with this, great work! Love that we're pulling database logic down into the model layer where it belongs and wrapping it in a single API

I think this ones ready for a re-review when you get a chance please @ryanb-gds

Thanks so much for all the feedback & the review 👍


don't drain the node if current NumVfs == 0

we don't need to remove PODs if none of them has VF(s)
This happends in the case that the current NumVfs == 0
Signed-off-by: Moshe Levi<EMAIL_ADDRESS>

/lgtm


Translation of website

Solved issue id: Website Translation using Google Translate API #231

there are conflicts resolve

and attach screenshot or recording to review?

home page

features page

contact page

team page

still conflicts.

and already done this. with chatbot and toggle key for dark theme.

if you can improve ui, you can make changes. otherwise no need.

I would like to try.

Does this mean the pull request is accepted? and I can work with UI.

Does this mean the pull request is accepted? and I can work with UI.

actually translation done already. sorry but i can't merge this one. you can work on other issues. i am really sorry


Convert null enums

Using null as the value for enum properties that have no value.  Adapted the Java code to support reading null as the value and setting the Java enum property value to null. As you suggested in the other PR.
Fixed two error in the boolean property export

boolean properties with value true are not in the model, just like enumerations with a default value.
boolean export used Boolean.getBoolean(...) should have been Boolean.valueOf(...)

@joswarmer I don't remember, should I review this or is this on hold until you make other changes?

No changes anymore, works fine in the project.


backport: V19.2 rc.1 backports

I was unable to backport 5397 due to conflicts @UdjinM6 please evaluate; also 5403 and later backports had conflicts so review them with more vigor.
Issue being fixed or feature implemented
backports
What was done?
backports
How Has This Been Tested?
hasn't
Breaking Changes
Checklist:
Go over all the following points, and put an x in all the boxes that apply.

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

pls see a4b8df7d9f and 2ab29e016e


Enable Field mode and run CT by default

curl -b cjar -k -H 'Content-Type: application/json' -X PUT -d '{"data":1}' https://$BMC_IP/xyz/openbmc_project/software/attr/FieldModeEnabled

Since this is going to be a run in the field..
Input from @anoo1

In review https://gerrit.openbmc-project.xyz/#/c/7907/


SDK 4.5.0

Hi,
I am looking really hard trying to find SDK 4.5.0, as newer sdk wont work in my project because of play services 12+.
Where can I find it?
Thank you

You can always download prior releases using the URL https://dl.google.com/firebase/sdk/unity/firebase_unity_sdk_${version}.zip
For example:
https://dl.google.com/firebase/sdk/unity/firebase_unity_sdk_4.5.0.zip
Why can't you use 4.5.1 in your project?  It should upgrade to the latest Google Play Services instead.

Thanks, you should really make that link more obvious, like a archive page.
Some of the plugins I am using work correctly only with 11.8 version of Play Services. As soon as they update to the latest, I will update to 4.5.1

@mmvlad FYI I think 4.5.1 will still work with Play Services 11.8 as we adopted no new API surface in the Android SDK.  You'll just need to change the referenced version number in the Dependencies.xml files (see https://github.com/googlesamples/unity-jar-resolver#usage)


Current release (3.8.3), reauthentication loop

Describe the bug
When I login with 2FA in the intregration, I hang in a reauthentication loop. After a reboot I must reauthentication again.
To Reproduce
Steps to reproduce the behavior:

Boot system
Reauthentication loop

Screenshots

System details

Home-assistant (version): core-2021.3.4
Hassio (Yes/No): yes
alexa_media  (version from const.py or HA startup): 3.8.3
alexapy (version from pip show alexapy or HA startup):
Amazon 2FA is enabled (y/n). We will not debug login issues if unanswered: yes

Logs
Please provide [logs](https://github.com/custom-components/alexa_media_player/wiki/FAQ#how-do-i-enable-debug-logging-for-the-component
home-assistant.log
). We'll be most likely asking for them anyway.
Additional context
Add any other context about the problem here.

Please close this issue. I updated to 3.8.4, and now it works.


feat(NumericUpDown): TextAlignment

What does the pull request do?

Add TextAlignment property to NumericUpDown
What is the current behavior?

It doesn't have the TextAlignment property. To change the alignment you need to create a style selector like this:
    <Style Selector="NumericUpDown /template/ TextBox#PART_TextBox">
      <Setter Property="TextAlignment" Value="Right"/>
    </Style>

This solution has the disadvantage of strictly depending on the theme used.
What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #12367

You can test this PR using the following package version. 11.0.999-cibuild0038213-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Enhancement: Text Extractor improve the recognition

Description of the new feature / enhancement
I use the text extractor a lot and I've noticed that it usually gets things a bit wrong and is limited in its features.
I've read that it is based on TheJoeFin's Text-Grab and that looks like a more interactive and fuller text grabber.
I would like to know if it's possible to import more of its features and mode over and if it's not too hard I would like to help with that if I can
Scenario when this would be used?
improving the Text Extractor tool is always useful
Supporting information
No response

This issue is covered by #20596 and #20899 Today the OCR Engine does not do a very good job of identifying wrapped text. I am closing this as a duplicate issue.
I am the maintainer of Text Grab and Text Extractor. Currently working on making Text Extractor more useful per the needs of the community.


"KeyError: 'security_type'" exceptions

ArcRest or ArcRestHelper
arcresthelper.securityhandlerhelper.securityhandlerhelper
Version or date of download
Either of:

"master" branch of https://github.com/Esri/ArcREST.git
"ArcREST_Package 3.5.6" from https://pypi.python.org/pypi/ArcREST_Package

Bug or Enhancement
🐛 Bug: The security_type configuration key passed to securityhandlerhelper is supposed to be optional and default to Portal.  However, if it's not specified, a "KeyError: 'security_type'" exception is thrown.
Repo Steps or Enhancement details
Found when running the "Fetch your folders" example from the Getting Started section of README.md.

I opened PR #281 with a fix for this issue.


Trapezoidal geometrical shape: does work only in one direction

Simple set up with a plane mirror:

In case parameter "totalWidth" is set to 50 and "
MatrixPMtrapez50-10.rml.txt
totalWidthB to 10 it looks reasonable:
RML-File: MatrixPMtrapez50-10.rml.txt

But in case the trapezoidal shape is rotated by 180°: "totalWidth" = 10; "totalWidthB" = 50 it looks wrong:
RML-File: MatrixPMtrapez50-10.rml.txt

There is no trapezoidal shape visible. It is a simple rectangular shape with a width of 10.
This is exactly the case we need at the RZP Array: totalWidthB (width upstream) > totalWidth (width downstream)

This seems to be how it is implemented in the shader. Maybe the formula use has a bug in it. I will check that

Correcting my previous comment: This is how it is implemented (ignore points 1 and 2)
After resolving some issues in the shader, I get the following outputs

For totalWidthA (LengthA) = 10 and totalWidthB (LengthB) = 50

For totalWidthA (LengthA) = 50 and totalWidthB (LengthB) = 10
This resolves the issue


String parameter incorrect

Challenge Check for Palindromes has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function palindrome(str) {
  // Good luck!
  console.log(str);

}

palindrome("eye");

When trying to complete the palindrome challenge, it appears that 1 of the strings is incorrect.
palindrome("0_0 (: /-\ :) 0-0"), when I log the string variable to the console i get 0_0 (: /- :) 0-0 instead. This causes the challenge to always fail.

@GavEnlighten the string is correct.

You'll need to remove all non-alphanumeric characters (punctuation, spaces and symbols) and turn everything lower case in order to check for palindromes.

GitHub issues are not for coding help. If you get stuck with a challenge, please ask questions first to the Help Room. Happy coding!

I am not asking for help.
The highlighted string in the image is a console.log of the str variable before any processing.
It is supposed to be 0_0 (: /-\ :) 0-0 not 0_0 (: /- :) 0-0. which is missing the "" character. I thought that the missing character was causing issues.
But I suppose what you are saying is with all the special characters removed it would then default to 0000 which is a palindrome

@GavEnlighten oh gotcha. The backslash \ is an escape character so that is why it appears to "disappear." But nonetheless, yes, the backslash would be removed because of the instructions.


_post_init()

In continuation https://github.com/carlmontanari/scrapli/discussions/281
Adding the _post_init method to the base class. This method could be called after the init method of the underlying sync/async drivers.
Needed for e.g. redefinition
conn.channel._auth_telnet_login_pattern

PS
Unfortunately, my knowledge is not enough to formalize the code correctly.
Only denote

👋 hey there! thanks for getting this rolling. I just pushed a commit to this that I think should do what we are looking for. would you mind testing this out and seeing if this works for what we were talking about in the discussion!?

Carl,
Everything works.
super :-)
Thank you

hah, don't close it we gotta merge it now :D thanks for the help on this one!

ouch.... I apologize. I'll fix it :-)
P.S. I have one more question... soon... :-)

hah no worries! its all sorted -- reopened and then merged!


[test] Enable impossible to support test POSIXErrorCode.

The REQUIRES written one in each line were impossible to satisfy in any
platform, so the test wasn't running at all. This was changed to a
REQUIRE-ANY listing all the platforms (and adding Android). I also
needed to add runAllTest() at the end to make the test pass.
This was like this since back in #6707. It seems to work on Android and my Linux installation. I hope it works on Darwin too.

@swift-ci  please test

Ah, good catch.
@swift-ci please test Linux platform

@swift-ci please smoke test

⛵


add experimental C++

This contains a branch where I attempt to port everything necessary for FastSubdirData.py to C++ so we can get rid of some of the Python.
This will need further love, but it shows how we can use librepo to download metadata for us and how we can structure the C++ to resemble conda.
We should expand on this, but for the moment we might take a direction where we still use the conda "frontend" to extract the data and correct all the paths, and then copy the necessary data into pybind11-exposed classes.
E.g. we would have a mamba.Channel class that is backed by C++ and contains fields like name, url, repodata_fn (which is tedious to get from the raw arguments right now).
This class + the Subdir class would then take care of downloading the metadata to the cache.

note that one needs to additionally have skyr-url installed (which is relying on another package called expected).

This has been superseded by everything added last month :)


Allowed Jest CLI arguments to be passed in as second argument.

Hey @Dakuan,
We use gulp-jest in our production environment, and love it. I added this feature because we were hoping to use verbose mode with gulp-jest.
Hope you can use this!

Whoops. I forgot to git add . before I committed.

@peteigel looks good to me, any reason this issue is closed?

I'm having a couple problems with it. Hopefully I'll get the sorted out on
Monday, but I wanted to make sure you didn't pull it prematurely. Sorry!
On Friday, July 10, 2015, Dominic Barker<EMAIL_ADDRESS>wrote:

@peteigel https://github.com/peteigel looks good to me, any reason this
issue is closed?
—
Reply to this email directly or view it on GitHub
https://github.com/Dakuan/gulp-jest/pull/18#issuecomment-120512442.

--
Pete Eigel


Fix find by char bug

When searching by name, if you search "a", it will match all clients whose name contains "a", which should not be the case.
Let's,

Change the way HustleBook matches client's name

Closes #173, closes #190

Codecov Report

Merging #242 (d44063f) into master (5b7461d) will increase coverage by 0.19%.
The diff coverage is 84.00%.

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     59.92%   60.11%   +0.19%
- Complexity      502      512      +10
============================================
  Files            96       96
  Lines          2006     2036      +30
  Branches        227      234       +7
============================================
+ Hits           1202     1224      +22
- Misses          721      725       +4
- Partials         83       87       +4

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...java/seedu/address/logic/commands/EditCommand.java
88.88% <ø> (ø)

src/main/java/seedu/address/model/person/Name.java
75.00% <82.60%> (+10.71%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
84.84% <100.00%> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
73.52% <0.00%> (-7.24%)
:arrow_down:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/FlagCommand.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7461d...d44063f. Read the comment docs.


(fix)annotation-injector-validation: fix the validation flags in CRD …as per new names in chaosengine API

Ref:

runnerAnnotations

experimenAnnotations

Signed-off-by: ksatchit<EMAIL_ADDRESS>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

We can update https://github.com/litmuschaos/litmus/blob/master/litmus-portal/litmus-portal-crds.yml and https://github.com/litmuschaos/litmus/blob/master/litmus-portal/graphql-server/manifests/cluster/2a_litmus_crds.yaml as well


Include gateway identifier in metadata

Summary

Include the gateway identifier in metadata.
Why do we need this?

For Home Networks to identify gateways in the Forwarder network.
What is already there? What do you see now?

No field for a gateway identifier in UplinkMessage.
What is missing? What do you want to see?

There should be a field, probably a structure with a friendly name, description and EUI. All optional.
How do you propose to implement this?

Add to the UplinkMessage proto message.
Can you do this yourself and submit a Pull Request?

Yes

Any updates on this one? It's preventing a few applications from moving to v3 for me.

I see that the uplink message JSON now indeed includes the gateway id, i.e. the rx_metadata element for the gateway has somthing like:
            "gateway_ids":{
               "gateway_id":"mjs-gateway-5",
               "eui":"1DEF5A0000000202"
            },

However, it seems that gateways that are connected to the v2 backend and connect to v3 using the packet broker (or at least that's what I understand) only have:
            "gateway_ids":{
               "gateway_id":"packetbroker"
            },

Multiple entries with the same id exist when multiple v2 gateways have received the messages.
Are there any plans to also show actual ids for such gateways? Or is this technically infeasible?

Are there any plans to also show actual ids for such gateways? Or is this technically infeasible?

It's technically not feasible. The gateawy_id shown in the RX metadata is the gateway in the network that you're connected to. You'll always know which gateway that is.
When networks offload traffic to Packet Broker, they may include the plain gateway ID, its hash or no ID, and/or optionally the EUI. This could overlap with names in the network that gateways are connected to, i.e. there could be a gateway mjs-gateway-5 in your network, but also in my The Things Stack open source that I connect to Packet Broker and also call mjs-gateway-5. The gateway ID packetbroker is there to ensure that the gateway is not a local gateway, that ID is blacklisted so it will not cause any confusion.
Then, for The Things Stack, from the compatibility commitment:

We will not break the API towards gateways and applications within the major version. This includes how gateways communicate (with Gateway Server) and how applications work with data (with Application Server)

So we cannot replace the current behavior as applications already depend on the current behavior. We can only do this in The Things Stack V4.

Thanks for clarifying, I see the problem. However, I wonder: Wouldn't it be possible to add another id? It already seems there are multiple parts to the id (though I'm not entirely sure what guarantees these id parts have, like if they should all be unique or not?). i.e. something like:
            "gateway_ids":{
               "gateway_id":"packetbroker",
               "original_gateway_id": "mjs-gateway-5"
            },

The current implementation also does not solve my original problem: uniquely identifying a coverage area. ie. a unique gateway. The combination of tenant+cluster+gateway ID should provide this.

Question: Is forwarder the network to which the gateway is connected to, and home the network the device is registered on?

What I currently see in the metadata:
"rx_metadata":[
         {
            "gateway_ids":{
               "gateway_id":"packetbroker"
            },
            "packet_broker":{
               "message_id":"01F3MHC7W44N2KR4301XNTSVE5",
               "forwarder_net_id":"000013",
               "forwarder_tenant_id":"ttn",
               "forwarder_cluster_id":"ttn-v2-eu-3",
               "home_network_net_id":"000013",
               "home_network_tenant_id":"ttn",
               "home_network_cluster_id":"ttn-eu1",
               "hops":[

What I want to see:
"rx_metadata":[
         {
            "gateway_ids":{
               "gateway_id":"packetbroker"
            },
            "packet_broker":{
               "message_id":"01F3MHC7W44N2KR4301XNTSVE5",
               "forwarder_net_id":"000013",
               "forwarder_tenant_id":"ttn",
               "forwarder_cluster_id":"ttn-v2-eu-3",
               "forwarder_gateway_id":"mjs-gateway-5",
               "forwarder_gateway_eui":"1DEF5A0000000202",
               "home_network_net_id":"000013",
               "home_network_tenant_id":"ttn",
               "home_network_cluster_id":"ttn-eu1",
               "hops":[

Also, the way we identify a tenant and cluster here is not consistent with how the same "domain" is identified via the headers:
  'X-TTS-DOMAIN' => 'eu1.cloud.thethings.network',

How about we use the same naming for both?
I don't see how adding this additional metadata will break the API.

Question: Is forwarder the network to which the gateway is connected to, and home the network the device is registered on?

Yes

What I want to see:
[...]

This is how it is supposed to be exactly. It's just that the forwarders running at V2 edges aren't updated yet to include the metadata. We are doing that now.

Also, the way we identify a tenant and cluster here is not consistent with how the same "domain" is identified via the headers:
  'X-TTS-DOMAIN' => 'eu1.cloud.thethings.network',

How about we use the same naming for both?

Hmm, what would you propose then?

Hmm, what would you propose then?

Maybe a forwarder_network_domain field which contains something like eu1.cloud.thethings.network? This will make sense for any TTS V3 cluster. Not sure how this will work in the future if we have other network servers talking via the packet broker. But any domain name will make sense and unqiuely identify the forwarder network - even non-TTS ones that does not have the concept of a tenant. Something like "forwarder_network_domain": "ns.lacuna.space" makes sense too.

All NetID + tenant ID is unique, and so are gateway IDs and EUIs within those. Tenant IDs are optional. Most networks won't use tenants, like Lacuna probably. We will, however, allow The Things Stack Open Source users to use 000013 NetID with their own tenant ID and we (that is, TTN, the authority of tenants in 000013) are responsible for making sure that tenants IDs within 000013 are unique.
Domain names aren't adding to uniqueness. It's just another value with another meaning, and Packet Broker doesn't use domain names for authenticating networks, while it does use NetID + tenant ID so those values are guaranteed to be correct. If we allow Packet Broker Agent to report the locally configured domain name, that can also be a local name like thethings.local in a local, on-site shop, with no internet accessible Console, while they are a client for Packet Broker.

Getting a little off-topic with this, but not sure where else to discuss this.
When we have this metadata in the json object:
               "forwarder_net_id":"000013",
               "forwarder_tenant_id":"ttn",
               "forwarder_cluster_id":"ttn-v2-eu-3",
               "home_network_net_id":"000013",
               "home_network_tenant_id":"ttn",
               "home_network_cluster_id":"ttn-eu1",

And we get this header at the same time as the json object via the webhook call:
'X-TTS-DOMAIN' => 'eu1.cloud.thethings.network',

How would one use the forwarder_tenant_id and the forwarder_cluster_id to match it up with a X-TTS-DOMAIN? Is a simple concatenation like this good enough?
forwarder_tts_domain := forwarder_tenant_id + "." + forwarder_cluster_id
home_tts_domain := home_network_tenant_id + "." + home_network_cluster_id

// Just as example, as doing this test doesn't make sense
if tts_domain == headers["X-TTS-DOMAIN"] {
  // Gateway is in same network as device
}

// Expecting this to be true
if tts_domain == headers["X-TTS-DOMAIN"] {
  // Device network should be home network
}

But ttn.ttn-eu1 is not equal to eu1.cloud.thethings.network!

What are you trying to achieve?
Strictly speaking you (only) can assume the following:

X-Tts-Domain suffix .cloud.thethings.network is The Things Stack Community Edition (The Things Network)
X-Tts-Domain suffix .cloud.thethings.industries is The Things Stack Cloud (The Things Industries)
home_network_net_id 000013 and home_network_tenant_id ttn is The Things Network
home_network_net_id 000013 with any other home_network_tenant_id can be anything: The Things Stack Cloud, The Things Stack Enterprise, The Things Stack Open Source, even ChirpStack using Passive Roaming and using address space of TTN

If you want to determine whether the message was picked up by a community network gateway, check the packetbroker gateway RX metadata and consider (3) above.
If you want to determine whether a user configured the TTN Mapper integration from TTN or TTSC, check the X-Tts-Domain suffix.

The X-Tts-Domain request header is the originating public domain of the calling The Things Stack network and is intended for the application layer to enqueue downlink messages. That's it.
Also, home_network_cluster_id is informative only and we don't guarantee any stable relationship between that and the domain name.

Scenario 1: Device on private network is received by public community network gateways.

Scenario 2: Device on public community network is received by a private network's gateway.

Note: I see the different TTN clusters as different networks. Should I see them as a single network? For me the Australia cluster is a completely standalone network, separate form the EU cluster.

Note: I see the different TTN clusters as different networks. Should I see them as a single network? For me the Australia cluster is a completely standalone network, separate form the EU cluster.

They are the same. With V3, au1.cloud.thethings.network is operated by TTI and is like any other TTN region.

Need to deduce that the gateway is connected to the-box.cloud.thethings.industries by using only these fields.

You get the 000013 and the-box. Those are guaranteed to be unique. Why do you need the host name?

Another note: I could not test the second scenario properly, as it seems like Public => Private works, but the exact opposite forwarding via the Packet Broker, Private => Public does not work.

By default private networks are not contributing to TTN. We're working on Console support to configure this (https://github.com/TheThingsNetwork/lorawan-stack/issues/3771). For now, use CLI to configure a routing policy from your private network to TTN: https://www.thethingsindustries.com/docs/reference/packet-broker/configure/routing-policies/

They are the same. With V3, au1.cloud.thethings.network is operated by TTI and is like any other TTN region.

For the first time tonight I logged into the au1 console, and I was surprised to see all my applications listed. I thought these were completely separate. But I now agree that they can be seen as the same network.

Using the 000013 and tenant_id to identify a network makes sense from the LoRaWAN Alliance perspective.
The problem however here is that the net_id and the tenant_id are not reported in either the json object or the headers when a packet is received directly (not via packet broker). See attached log. So if we need to use the net_id+tenant_id to identify a unique network, that info should always be available in the metadata. And in that case you are right that the domain name is redundant. But at this point the X-Tts-Domain/MQTT host is the only always available identifier.
TTS sample webhook data.txt

Private networks contributing to TTN: some of the TTI customers specifically want to do this to allow community members to map their networks for them. This is the main reason I need to identify the forwarding network for packet broker gateways.

So if we need to use the net_id+tenant_id to identify a unique network, that info should always be available in the metadata. And in that case you are right that the domain name is redundant. But at this point the X-Tts-Domain/MQTT host is the only always available identifier.

I see. Filed issue here: https://github.com/TheThingsNetwork/lorawan-stack/issues/4076

I'm still missing gateway ids for ttnv2 gateways in the MQTT data. @johanstokking previously said:

This is how it is supposed to be exactly. It's just that the forwarders running at V2 edges aren't updated yet to include the metadata. We are doing that now.

Is this being tracked anywhere?

@johanstokking can we open this issue again? As far as I can see the required data is still nor available in the metadata.

You probably already know this, but the same also applies to data received with the web hook integration:
{
    "uplink_message": {
        "rx_metadata": [
            {
                "gateway_ids": {
                    "gateway_id": "packetbroker"
                },
                "packet_broker": {
                    "message_id": "xxxxxxxxxxxxxxxxxx",
                    "forwarder_net_id": "000013",
                    "forwarder_tenant_id": "ttn",
                    "forwarder_cluster_id": "ttn-v2-eu-4",
                    "home_network_net_id": "000013",
                    "home_network_tenant_id": "ttn",
                    "home_network_cluster_id": "ttn-eu1",

... and no gateway EUI anywhere.

This is probably a configuration issue. This is not a Packet Broker API issue so this issue can stay closed.
We're looking into it and and get this fixed.
cc @KrishnaIyer @michalborkowski96


CLA assistant not registering my signature

I'm having trouble with the CLA assistant on my organization's github page. After following the process to sign, I'm still not listed as signing. The issue has persisted for over a week despite multiple attempts to sign.
One of the repo admins asked me to log an issue here (https://github.com/AllenInstitute/AllenSDK/pull/1474#issuecomment-620747779)
URL to the linked Repo/Org:
https://github.com/AllenInstitute/AllenSDK
https://github.com/AllenInstitute/AllenSDK/pull/1474
https://github.com/AllenInstitute/AllenSDK/pull/1474#issuecomment-620747779
Steps to reproduce the problem:

I click the "CLA not signed yet" button
I get routed to the "Please sign the CLA" page
I click "sign in with github to agree"

What is the expected result?
I expect the CLA to show up as 'signed' for my username
What happens instead?
There is still a red X next to my username in the CLAassistant box on github. However, there is additional text that reads: "You have signed the CLA already but the status is still pending? Let us recheck it."

I solved this issue. It turned out that I had a long-forgotten github account associated with one of my email addresses. For reasons I don't fully understand, github was associating my commits with that other username, even though I was logged in under my primary username when making those commits.
Presumably, CLA Assistant was having trouble associating the username with which I was signed in when signing the agreement with the username that was (erroneously) associated with my contributions.
I signed in under the alternate github ID to sign the CLA, which solved the immediate issue. I also cleared up the github username/email conflict to avoid future problems.

@dougollerenshaw thanks for detailed description. Glad, that you've solved the issue!


Create InfoHandler class

The InfoHandler class has a dependency on the ModelManager class. It retrieves the required data from the ModelManager and carries out read-only operations on the retrieved lists. Updates to the lists in the ModelManager class would also affect the lists retrieved by the InfoHandler class as a result of this dependency.
Resolve #66 , Resolve #67

In addition, you might want to update the details of the pull request if it does indeed include some functionality involving the daily statistics. This is on the assumption that it is included.


Include License File

It took me at least 10 minutes of trawling around to find out the project is licensed under Apache-2.0.
Technically Apache 2.0 requires you distribute the license with the software/source anyway.

It's distributed with the source at resources/license.txt.

Oh, I see. Not a typical location but good that it's there. Thanks.


Unable to build AlphaWallet from Xcode Cloud

I get the following error when trying to build alpha wallet with Xcode cloud.
Archive - iOS encountered a failure that caused the build to fail.
Image AlphaWalletFoundation
Undefined symbol: _$s10RealmSwift7ResultsVyxGAA0A14CollectionImplAAMc
Image AlphaWalletFoundation
Undefined symbol: _$s10RealmSwift0A14CollectionImplPAAE12makeIteratorAA11RLMIteratorVy7ElementQzGyF
It does most things.  You have to setup cocoa pods as stated in this document
https://developer.apple.com/documentation/xcode/making-dependencies-available-to-xcode-cloud
in the section "Make CocoaPods dependencies available to Xcode Cloud"

Thanks for the tip. We don't use Xcode Cloud at the moment. Would you be able to submit a PR if you need the functionality? From the documentation you posted, it looks like we just need a script which installs CocoaPods tools and use it to install the pods.

What is your build process?  Maybe I can adopt that one rather than using Xcode Cloud.

For CI with GitHub PRs:
.travis.yml

For TestFlight/submissions:
env FASTLANE_USER=<email> FASTLANE_PASSWORD=<password> FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD=<password2> bundle exec fastlane upload

Also see the Makefile for make test. But it's only used locally

Same issue with me but i take build without xcode cloud. Can you please help ?


Azure Firewall

Hi, please could you provide design with Azure Firewall ? Primary how to publish apps behind Azure Firewall

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b64cb7c-c1ac-59a5-6904-ca26e32dda77
Version Independent ID: 3de2a96c-e956-3803-5770-7cfc360de3fb
Content: Azure network security best practices
Content Source: articles/best-practices-network-security.md
Service: virtual-network
GitHub Login: @tracsman
Microsoft Alias: jonor

@jjindrich Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

I would appreciate if the page is updated with how Azure Firewall can complement or plays a role in designing the network architechture.

The article has been updated. Thanks!
#please-close


Fixes renderbuffer leaking when creating Fbo

If a FBO was created with stencil buffer but no depth buffer (like what ShaderTransition does today), it doesn't release the Renderbuffer created for the stencil.
The same renderbuffer is used for both stencil and depth, but only the depth id was checked for the release. This PR fixes the leak.
Ref #5581

Nice catch, maybe this fixes #4483?


UnicodeEncodeError when using unicode chars in supplied credentials

[-] <IP_ADDRESS>:445 ISIDORO\guest:admin SMB SessionError: STATUS_LOGON_FAILURE(The attempted logon is invalid. This is either due to a bad username or authentication information.)
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
result = self._run(*self.args, **self.kwargs)
File "crackmapexec.py", line 2935, in connect
smb = smart_login(host, smb, domain)
File "crackmapexec.py", line 2713, in smart_login
smb.login(user, passwd, domain)
File "/usr/local/lib/python2.7/dist-packages/impacket/smbconnection.py", line 210, in login
return self._SMBConnection.login(user, password, domain, lmhash, nthash)
File "/usr/local/lib/python2.7/dist-packages/impacket/smb3.py", line 678, in login
blob['MechToken'] = str(auth)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 170, in str
return self.getData()
File "/usr/local/lib/python2.7/dist-packages/impacket/ntlm.py", line 211, in getData
return Structure.getData(self)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 121, in getData
data += self.packField(field[0], field[1])
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 106, in packField
ans = self.pack(format, self.fields[fieldName], field = fieldName)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 263, in pack
return str(data)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-8: ordinal not in range(128)
<Greenlet at 0xb6552b1cL: connect('<IP_ADDRESS>')> failed with UnicodeEncodeError
[-] <IP_ADDRESS>:445 LS--20150801JUS\admin:admin SMB SessionError: STATUS_LOGON_FAILURE(The attempted logon is invalid. This is either due to a bad username or authentication information.)

@its0x08 I'm going to need the credentials you used to reproduce this

some times i use this command
python crackmapexec.py -t 100 <IP_ADDRESS>-255 -u admin -p ../list/user.txt --shares
sometime this
python crackmapexec.py -t 100 <IP_ADDRESS>-255 -u admin,guest,administrator -p admin,password,1234,guest,user,administrator --shares

once again ...
root@backbox:/home/its_0x08/Desktop/exploits/CrackMapExec# python crackmapexec.py -t 25 <IP_ADDRESS>/24 -u admin -p admin,password --shares
[*] <IP_ADDRESS>:445 is running Windows 6.1 Build 7601 (name:1-ПК) (domain:1-ПК)
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
result = self._run(*self.args, **self.kwargs)
File "crackmapexec.py", line 2937, in connect
smb = smart_login(host, smb, domain)
File "crackmapexec.py", line 2715, in smart_login
smb.login(user, passwd, domain)
File "/usr/local/lib/python2.7/dist-packages/impacket/smbconnection.py", line 210, in login
return self._SMBConnection.login(user, password, domain, lmhash, nthash)
File "/usr/local/lib/python2.7/dist-packages/impacket/smb3.py", line 678, in login
blob['MechToken'] = str(auth)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 170, in str
return self.getData()
File "/usr/local/lib/python2.7/dist-packages/impacket/ntlm.py", line 211, in getData
return Structure.getData(self)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 121, in getData
data += self.packField(field[0], field[1])
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 106, in packField
ans = self.pack(format, self.fields[fieldName], field = fieldName)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 263, in pack
return str(data)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 2-3: ordinal not in range(128)
<Greenlet at 0xb65a048cL: connect('<IP_ADDRESS>')> failed with UnicodeEncodeError
[] <IP_ADDRESS>:445 is running  (name:KATRIN) (domain:KATRIN)
[+] <IP_ADDRESS>:445 Login successful KATRIN\admin:admin
[] <IP_ADDRESS>:445 is running Windows 6.1 Build 7601 (name:ASUS-PC) (domain:ASUS-PC)
[*] <IP_ADDRESS>:445 is running Windows 6.1 Build 7601 (name:НИКА-ПК) (domain:НИКА-ПК)
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
result = self._run(*self.args, **self.kwargs)
File "crackmapexec.py", line 2937, in connect
smb = smart_login(host, smb, domain)
File "crackmapexec.py", line 2715, in smart_login
smb.login(user, passwd, domain)
File "/usr/local/lib/python2.7/dist-packages/impacket/smbconnection.py", line 210, in login
return self._SMBConnection.login(user, password, domain, lmhash, nthash)
File "/usr/local/lib/python2.7/dist-packages/impacket/smb3.py", line 678, in login
blob['MechToken'] = str(auth)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 170, in str
return self.getData()
File "/usr/local/lib/python2.7/dist-packages/impacket/ntlm.py", line 211, in getData
return Structure.getData(self)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 121, in getData
data += self.packField(field[0], field[1])
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 106, in packField
ans = self.pack(format, self.fields[fieldName], field = fieldName)
File "/usr/local/lib/python2.7/dist-packages/impacket/structure.py", line 263, in pack
return str(data)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-3: ordinal not in range(128)
<Greenlet at 0xb535f66cL: connect('<IP_ADDRESS>')> failed with UnicodeEncodeError
[-] <IP_ADDRESS>:445 ASUS-PC\admin:admin SMB SessionError: STATUS_LOGON_FAILURE(The attempted logon is invalid. This is either due to a bad username or authentication information.)
[+] <IP_ADDRESS>:445 KATRIN Available shares:
SHARE     Permissions
-----     -----------
PDF       NO ACCESS
print$       NO ACCESS
IPC$       NO ACCESS
[] <IP_ADDRESS>:445 is running Windows 6.3 Build 9600 (name:TOSHIBA_I7) (domain:TOSHIBA_I7)
^CKeyboardInterrupt
[] Got CTRL-C! Exiting..
root@backbox:/home/its_0x08/Desktop/exploits/CrackMapExec#

That seems to be an Impacket bug when negotiating against a machine that has those International  characters. Please fill up a bug at https://github.com/CoreSecurity/impacket/issues

@its0x08 this is a bug with the impacket library, just filed a bug report

@its0x08 I just fixed this issue, could you please recheck so I'm sure it's fixed correctly? You will need to git pull the latest impacket repo.

now its fixed :)


⚠ SpeakUpConference.com has degraded performance

In ba322f6, SpeakUpConference.com (https://www.speakupconference.com) experienced degraded performance:

HTTP code: 200
Response time: 9486 ms

Resolved: SpeakUpConference.com performance has improved in 02007bf after 20 minutes.


chore(package): update semantic-release to version 15.9.12

Coverage remained the same at 81.739% when pulling 5e440ebec1ab68b9b7552fced970832543c307d4 on greenkeeper/semantic-release-15.9.12 into bc67400612e36aa4a0572cc0f8b9c0aaa39cb380 on master.

:tada: This PR is included in version 7.7.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(build): logic for adding href token to help index.html

Currently, the index.html deployed in the help package does not include the $(APPLICATION_BASE_HREF) token, which is replaced during the package installation process.
This pull request rectifies the logic that inserts the $(APPLICATION_BASE_HREF) token into the index.html file during the execution of the cmf build.

This was superseeded by #349


WIP: Add ESLint configuration file

Instead of relying on Codacy, ESLint can be configured to run locally. There is even a VS Code extension that marks style violations directly in the editor.
The rules were chosen to fit well to our existing code style, but will probably need some more tweaking.
Fixing the violations (and there are quite a few) will also be part of this PR.

Plugin export diff
(Output of test script tests/github/export-diff.js.)
You can run view your uncommited changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin name> <fixtures>
Model modified in this PR
As the model affects all plugins, the output of all plugins is checked.
Tested with the following test fixtures that provide a possibly wide variety of different fixture features:

cameo/hydrabeam-300-rgbw
chauvet-dj/slimpar-pro-h-usb
coemar/prospot-250-lx
dts/xr1200-wash
elation/platinum-spot-15r-pro
generic/rgb-fader
martin/mac-viper-performance

:information_source: Plugin d-light
Outputted files not changed.
:information_source: Plugin ecue
Outputted files not changed.
:information_source: Plugin ofl
Outputted files not changed.
:information_source: Plugin qlcplus
Outputted files not changed.

Schema has changed
(Output of test script tests/github/schema-version-reminder.js.)
With every change on the schema, its version should be incremented and tagged. See the Fixture README for further information.

Export files validity
(Output of test script tests/github/exports-valid.js.)
Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>
Model changed in this PR
Tested with the following test fixtures that provide a possibly wide variety of different fixture features:

cameo/hydrabeam-300-rgbw
chauvet-dj/slimpar-pro-h-usb
coemar/prospot-250-lx
dts/xr1200-wash
elation/platinum-spot-15r-pro
generic/rgb-fader
martin/mac-viper-performance

Test results

d-light

attributes-correctness

:white_check_mark: cameo/hydrabeam-300-rgbw-6ch.xml
:white_check_mark: cameo/hydrabeam-300-rgbw-10ch.xml
:x: cameo/hydrabeam-300-rgbw-16ch.xml
Show errors

Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT
Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT

:x: cameo/hydrabeam-300-rgbw-26ch.xml
Show errors

Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT
Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT

:x: cameo/hydrabeam-300-rgbw-42ch.xml
Show errors

Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT
Duplicate parameter name: FOCUS/PAN
Duplicate parameter name: FOCUS/TILT

:white_check_mark: chauvet-dj/slimpar-pro-h-usb-6ch.xml
:white_check_mark: chauvet-dj/slimpar-pro-h-usb-7ch.xml
:white_check_mark: chauvet-dj/slimpar-pro-h-usb-12ch.xml
:white_check_mark: coemar/prospot-250-lx-strd.xml
:white_check_mark: coemar/prospot-250-lx-emul.xml
:white_check_mark: dts/xr1200-wash-Fresnel.xml
:white_check_mark: dts/xr1200-wash-PC.xml
:white_check_mark: elation/platinum-spot-15r-pro-Basic.xml
:white_check_mark: elation/platinum-spot-15r-pro-Standard.xml
:white_check_mark: elation/platinum-spot-15r-pro-Extended.xml
:white_check_mark: generic/rgb-fader-8bit.xml
:white_check_mark: generic/rgb-fader-16bit.xml
:white_check_mark: generic/rgb-fader-24bit.xml
:white_check_mark: martin/mac-viper-performance-bas.xml
:white_check_mark: martin/mac-viper-performance-ext.xml

ecue
ofl
qlcplus

xsd-schema-conformity

:white_check_mark: cameo-Hydrabeam-300-RGBW.qxf
:white_check_mark: Chauvet-DJ-SlimPAR-Pro-H-USB.qxf
:white_check_mark: Coemar-ProSpot-250-LX.qxf
:white_check_mark: DTS-XR1200-WASH.qxf
:white_check_mark: Elation-Platinum-Spot-15R-Pro.qxf
:x: Generic-RGB-Fader.qxf
Show errors

Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

:white_check_mark: Martin-MAC-Viper-Performance.qxf


Inconsistent element attributes

I have a question about the behavior of this code when presented with a document such as this:
<library location="uptown">
    <shelf category="fiction">
        <book author="Lewis Carol">Alice's Adventures In Wonderland</book>
        <book author="James Joyce">Portrait of the Artist as a Young Man</book>
    </shelf>
    <shelf category="non-fiction">
        <book author="Carl Sagan">Billions and Billions</book>
        <book>Webster's Collegiate Dictionary</book>
    </shelf>
</library>
<library location="downtown">
    <shelf category="fiction">
        <book author="J.K. Rowling">Harry Potter and the Prisoner of Azkaban</book>
        <book author="Homer">The Iliad</book>
    </shelf>
    <shelf category="non-fiction">
        <book author="Stephen Hawking">A Brief History of Time</book>
        <book author="Benjamin Franklin">The Autobiography of Benjamin Franklin</book>
    </shelf>
</library>

As you can see there's a book in there without an author attribute.
I can load this xml and print the schema:
val test = sqlContext.read.format("com.databricks.spark.xml").option("rowTag", "library").load("maprfs:///user/cmatta/projects/test.xml")
test.printSchema

test: org.apache.spark.sql.DataFrame = [@location: string, shelf: array<struct<@category:string,book:array<struct<#VALUE:string,@author:string>>>>]
root
 |-- @location: string (nullable = true)
 |-- shelf: array (nullable = true)
 |    |-- element: struct (containsNull = true)
 |    |    |-- @category: string (nullable = true)
 |    |    |-- book: array (nullable = true)
 |    |    |    |-- element: struct (containsNull = true)
 |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |-- @author: string (nullable = true)

If I want to select all the books by location and collect them I get a java.lang.ArrayIndexOutOfBoundsException: 1 error. If I just collect the whole dataframe without select I can see that the "Webster's Collegiate Dictionary" book array only has one element, where I would have expected two: the value and a null representing the author. Is this a correct expectation?
test.collect
res552: Array[org.apache.spark.sql.Row] = Array([uptown,WrappedArray([fiction,WrappedArray([Alice's Adventures In Wonderland,Lewis Carol], [Portrait of the Artist as a Young Man,James Joyce])], [non-fiction,WrappedArray([Billions and Billions,Carl Sagan], [Webster's Collegiate Dictionary])])], [downtown,WrappedArray([fiction,WrappedArray([Harry Potter and the Prisoner of Azkaban,J.K. Rowling], [The Iliad,Homer])], [non-fiction,WrappedArray([A Brief History of Time,Stephen Hawking], [The Autobiography of Benjamin Franklin,Benjamin Franklin])])])

If this behavior is expected, what's the best way to deal with inconsistent XML like this?

@cjmatta thenks for reporting this. I will look into this further.

Maybe this can help to track down the root cause: https://issues.apache.org/jira/browse/SPARK-12624
Apparently a java.lang.ArrayIndexOutOfBoundsException is thrown when row lengths do not match.

I see. Good niches. I think I should set null explicitly for the fields as well just like the other fields. This will be quicky fix. I will fix this tomorrow.

Fixed in https://github.com/databricks/spark-xml/pull/95.


Add animations work; Remove animations are clunky

Video: https://imgur.com/a/DoDWNvE
Hi, I'm using an animator like so:
    views.list.layoutManager = LinearLayoutManager(context)
    views.list.itemAnimator = SlideInLeftAnimator()

The add animation work nicely, there is cascading effect where the items arrives one by one.
However, the remove animation is clunky: all the items are removed at the same time. I would expect the items to be removed one by one as well.
After reading the source, I noticed that BaseItemAnimator uses ViewHolder.getOldPosition() to achieve the cascading effect for remove animations. But for me, the old position is always -1, meaning the RecyclerView is not recording ViewHolder's old position.
Are there any special setup you have to do to make RecyclerView record ViewHolder's old position?

@littledot @liguopengbenli any fix for the above said ?


Submission rules, especially compliance principles

Hi all,
We're getting close to submission and need to dust off the submission rules.
https://docs.google.com/document/d/1YNGymVFuQdoH7tPFHWk6siSkFdvyHqKi3FuBTXaoxfM/edit#heading=h.k6uj9xqxzwoe
It'd be especially good to make sure we're still on the same page regarding role of compliance.
Best,
Peter

SWG Notes:
There is general support for the same operating principles:
MLPerf v0.6 is a submission round of the “alpha” version of an agile benchmark. The role of the review process is to ensure fairness of submissions, not to litigate details in an effort to disquality competitors. For example:

Reviewing submitters should discuss issues with owning submitters before filing objections.
If an objection is supported by the review committee, the objecting submitter should communicate with the owning submitter to ensure a satisfactory fix.
The review committee should ignore small differences that do not substantially impact performance (less than 2% cumulative difference for a result), subject to its discretion.

AI(Submitters) Please review the document.

This was a notice for v0.6; already done.


enum's not generated for base_locale_empty_string

Describe the bug
I would like to sincerely thank you for the development of base_locale_empty_string. Here, I have made the necessary additions in the English JSON file. I'm also adding other languages as 'empty' just like in the examples. This way, the person doing the translations understands that they need to translate it. When I initially send the section parts like in the first example, there's no problem. However, when the translator translates some parts and not others in the second example, it becomes an issue.
Example 1
strings_en.i18n.json
    "sections(context=Sections, param=sections)": {
      "deviceInfo": "Device Info",
      "identification": "Identification",
      "information": "Information",
      "notes": "Notes",
      "purchaseInfo": "Purchase Info"
    },

strings_ro.i18n.json
    "sections(context=Sections, param=sections)": {
      "deviceInfo": "",
      "identification": "",
      "information": "",
      "notes": "",
      "purchaseInfo": ""
    },

Example 2
strings_en.i18n.json
    "sections(context=Sections, param=sections)": {
      "deviceInfo": "Device Info",
      "identification": "Identification",
      "information": "Information",
      "notes": "Notes",
      "purchaseInfo": "Purchase Info"
    },

strings_ro.i18n.json
    "sections(context=Sections, param=sections)": {
      "deviceInfo": "Informații dispozitiv",
      "identification": "Identificare",
      "information": "",
      "notes": "notes",
      "purchaseInfo": "Informații achiziție"
    },

Error Message
Failed to build iOS app
Error (Xcode): lib/translations/strings.g.dart:3819:11: Error: The type 'Sections' is not exhaustively matched by the switch cases since it doesn't match 'Sections.information'.

You will need to remove the whole context node. Currently, each language is generated separately from each other, so "ro" does not know how many strings in "en" exist

The context node is very useful for us; the slang library is one of the reasons we prefer it. Otherwise, the code becomes more complicated. The likelihood of encountering the situation in the second example is very high, and in that case, the application crashes. At the very least, to prevent the application from crashing, a default "" (empty string) can be provided in the string.g.dart file.
string.g.dart file
.
.
.
  @override
  String sections({required Sections sections}) {
    switch (sections) {
      case Sections.deviceInfo:
        return 'Informații dispozitiv';
      case Sections.identification:
        return 'Identificare';
      case Sections.notes:
        return 'Note';
      case Sections.purchaseInfo:
        return 'Informații achiziție';
      default:
         return '';
    }
  }
.
.
.

Even in this case, I will have to find the empty value in the generated files and process it. I am considering replacing "" (the empty values) with an expression like "untranslated key -> $keyvalue." That's the general situation. What do you think? Is there another way?

Im having the same issue. Any plans on handling this case?

Fixed in v3.29.0

When we tried to upgrade the package, we encountered this issue: issue
What changes have been made and what/how should we implement it? I would be happy if you can navigate me to find out whats the problem.


Imprecise scent - should it be an option somewhere?

Rule book doesn't have it as a listed "feat" pre se, but it is has it in several descriptions.  Example:
Hunting Catfolk
You come from a long line of skilled hunters and trackers and have a particularly keen sense of smell. You gain imprecise scent with a range of 30 feet.
Pathbuilder puts it under Special Feature Level, and when doing an import from Pathbuilder to Foundry there is not an Imprecise scent option.
Should there be one?

When you select the Hunting Catfolk heritage, the Scent ability is added. If it's not being added to the import from Pathbuilder, reach out to the dev of the importer for assistance. Beyond that, adding the Heritage from the compendium should add it to the senses.


Tutorials not working

None of the links on http://holoviews.org/Tutorials are working. Would be great if this could be updated.
Thanks!

Oh no, not sure what's gone wrong there! If you want to see a version of the tutorials right now, you can try http://build.holoviews.org/Tutorials/ (these are supposed to correspond to the most recent git version of holoviews, I think).

Actually, there's already an issue for this: #1726. The tutorials are now in the user guide (https://github.com/ioam/holoviews/issues/1726#issuecomment-317906417) at http://holoviews.org/user_guide/index.html.


Improve Step Extension Example

The current step extension example is pretty awful, it would be good to see this improved a bit, maybe with a form or something.

Duplicated by #214

@Delawen - Why have you closed this as a duplication? We are currently showing a default Step Extension that is just a button, so either we remove it and don't show any at all, or we improve it. The documentation is a separate thing to me, that is waiting on the Step Extension API to be developed.

I wonder if we still need this issue, or maybe with the step-extension-repository that would be enough?


Incorrect range header for DASH manifest with two representations

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
2.5.0-beta2
Can you reproduce the issue with our latest release version?:
I don't believe this is a new issue, but it's not easy for me to test.
Can you reproduce the issue with the latest code from master?:
Not sure.
Are you using the demo app or your own custom app?:
Custom app.
If custom app, can you reproduce the issue using our demo app?:
I was unable to figure out how to do this.
What browser and OS are you using?:
Chrome & Linux.
What are the manifest and license server URIs?:
Will send separately to<EMAIL_ADDRESS>What did you do?
Tried to play DASH manifest with two representations of the same audio. The representations are nearly identical (very close bandwidth, identical sampling rate).
What did you expect to happen?
Range header accompanying the media request would use the indexRange from the SegmentBase matching the URL.
What actually happened?
The request uses the BaseURL from the first representation, but has range header with SegmentBase/indexRange from the second representation.

My bad, this was user error -- we had some code that was rewriting the URL.


Refactor class_eval with string into class_eval with block

This commit changes the "class_eval with string"-style to "class_eval with block"-style.
The only worry I have is the remaining string eval in the method definition on line 96:
              define_method :scope_condition do
                eval "%{#{configuration[:scope]}}"
              end

Of course this eval happens in the current code, but just isn't that obvious as it is now.
Added bonus is that the position column is now quoted lazily, removing the need of an established database connection at model load-time, as mentioned in #214.
(Now let's see if all supported Ruby versions agree with this, Travis will let us know soon 😉)

Travis build fails because:

github_changelog_generator depends on rack, which will install the latest version 2.0.1, which in turn requires Ruby >= 2.2.2
acts_as_list depends on activerecord >= 3.0, which will install the latest version 5.0.0, which depends on activesupport version 5.0.0, which also depends on Ruby >= 2.2.2

I can fix the first by requiring rack < 2.0 in the Gemfile, but what about the second problem?

Thanks for this @rdvdijk. Let's take a look at this once we've sorted out the rack problem :)

Hi @rdvdijk, can you rebase this to master (I've fixed the tests), and see how the suite runs?

Rebased. I left the tab-to-spaces fix in the Gemfile :wink:
Thanks for improving upon my appraisals/rack PR.

Thanks @rdvdijk :) All seems to have passed.
@swanandp, @fabn, and @krzysiek1507 did you want to have any input into this one?

Good stuff! Just left a minor comment.

Ok, once that's fixed, I'll merge this one.

Oh, also needs rebasing :)

Ah, feedback! I've been away on holiday, I'll take a look at the comments soon. And do another rebase. 😄

@brendon I've fixed the variable name and rebased.
The quoted_position_column_with_table_name change made the rebase a little challenging, but I think all is well now. (I did notice that that there were no explicit tests for that particular feature...)

Thanks @rdvdijk, I think the reason why there were no explicit tests was that it was just a refactor of existing code, though for sure, they could have attempted to test for their obscure failure case. I might ping them on that. I'm happy to merge this now. Thank you for all your hard work on this.

Awesome, thanks!
About my initial comment about the remaining string-eval in scope condition: it might be time to deprecate unsafe code like that. I think the "symbol" way of providing a scope condition should suffice in all use cases. Or are there use cases that I'm just not seeing here?

Let's open this up in a new issue. :)


chore: release v0.1.2

🤖 New release

edi-format: 0.1.1 -> 0.1.2

Changelog

[0.1.2] - 2024-05-17
🚀 Features

Use Arg structure of clap (#18)
Support formatting stdin (#20)

This PR was generated with release-plz.

release-plz set-version v0.2.0


Fix nb subscriber count

Summary | Résumé
The subscriber counts need to be based on confirmed + unique emails.
close#129
known issues

the query can be optimized ( outerjoin vs subquery)

Testing this, currently the endpoints will only return Lists that have confirmed subscribers. ie, I have 3 lists on my local test environment. One of them has a confirmed subscriber, the second has an unconfirmed subscriber, and the third has no subscribers. Only the first list is returned.
Expected behaviour: We should see all three lists returned, the first with a subscriber count of 1, and the other two 0.

@dsamojlenko  I've raised this issue on one of the test. To be clear, this behaviour occurs on /list endpoint only but not  the /list/{service_di} ?
FYI:  i'm working on a fix.


Maybe add javax.lang.model API

From @Alexander--, re, javax.lang.model:

It is a bit exotic. More widely known in Android land (thanks to popularity of annotation processors there), not so much elsewhere. You probably don't want it as the only API, more like a supplement for situations, when loading classes to use reflection is unacceptable. Either way, learning how javac developers approached issue of compile-time introspection might be a good idea.

Look into supporting this as an alternative API?

javax.lang.model is used by the annotation processing API -- see:
https://youtu.be/2Dlo8OSwzaI?t=15m
Therefore, this issue is related to #184.

@lukehutch I think #184 is good enough to warrant closing this issue to keep things simple?

@johnou Well, that bug is about a very different issue (build-time scanning), and this one is about supporting an already-out-there API in the Java platform that is (very roughly) equivalent to the new ClassGraph v4 API. Actually the suggestion to support javax.lang.model is a very good one (at least as a secondary API). However, it's a bit of an obscure API and it may turn out to be a ton of work for not very much benefit.
Also, I took a look at the API, and it's mostly interfaces, but it's complex enough that I anticipate I'd get deep in the guts of implementing shims between javax.lang.model and the ClassGraph API, and then I'd find a huge "gotcha" that meant I couldn't cleanly map the APIs over. (I ran into similar issues when I was in the middle of implementing my own ByteBuffer that worked over the top of InputStream, for ClassGraph v4 -- I had almost the whole thing done, and it's a real pain of a class to implement, when I found that it's actually impossible to extend ByteBuffer because you have to define an abstract method that is package-private or something.)
So I have been mulling over whether to just close this. I think the new ClassGraph API is simple enough and complete enough that supporting a second parallel API doesn't make too much sense. If anyone finds this bug though and can point out a clear usecase where having ClassGraph plug into a javax.lang.model API consumer would be a huge win, please let me know, and I'll consider it.
Thanks, @johnou!


Added 404-Page animated Character

Added 404 page animated character project

Hi, I've completed the implementation of this project.
Close #3442

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Hi @MohitGupta121 please check this PR. Thanks!


docs: arxiv reference updates

Fixed: URL-generation code.
Added: arxiv references.
Regenerated: arxiv references page.
Improved: formatting of the concepts page

@eyurtsev Can you review it, pls?

@efriis Thanks!


Code Refactoring

@ag-hcoder : This PR is too small to be given points for. Check the code for more refactoring, I'm sure the code can be made a lot more tight !

Yeah sure. Are there any fixed standards that I should be following?

@ag-hcoder - As for standard, I'd suggest keep code readable, concise and better than before. You may make your commits, I'll request changes as necessary during code review.

Just one suggestion, should we go for the code being PEP-8 compliant?

Sure !

@ag-hcoder : Are you making changes in this PR or should we close it ?

I'm currently busy with some university work. I will get back to work once that is done. I hope it is fine with you


update-client should expect 2 args

Description

closes: #499

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

ACK, can you add a changelog entry under Bug Fixes? 🙏

ok I'll add the a changelog entry


Bounds checking

How do we feel about turning on bounds checks like normal arrays for StrideArrays? If you're writing good code, bounds checks should often be elided, and if people really want they can always use @inbounds. The fact that the only way to turn on bounds checks is by redefining a function makes it so that packages like Bumper.jl who depend on StrideArrays can't provide bounds checks by default.

Yeah, it's fine.
Base doesn't use @inbounds because "maybe people implemented their array types wrong".
There was some benchmark I wanted to win without reimplementing a bunch of base methods, but I don't care about those benchmarks anymore.

BTW, I have aliased Julia so that I get --check-bounds=yes by default, so I was probably less impacted by this than most people.


Dot parser incompatible with graphviz

If a label contains a html table cfgexplorer requires the label to be between quotes ("), while graphviz requires the label to be between < and >, otherwise it will render it as plain text.
Cfgexplorer:
digraph Mir {
    "bb6" [shape="none", label="

unreachable

"];
}

Graphviz:
digraph Mir {
    "bb6" [shape="none", label=<

unreachable

>];
}

Thanks for identifying this issue. CFGExplorer uses graphlib-dot a JS library for parsing dot files. It does not support parsing HTML based node labels (https://github.com/dagrejs/graphlib-dot/wiki#limitations). CFGExplorer uses dagre-d3 which does not use HTML labels for rendering the graphs.
We are looking for alternative parser and renderer which supports HTML based labels.


Support default json serializer in DaprClient and add .json helper

Describe the proposal
In the convenient layer spec, DaprClient doesn't have the default json serializer, but let users to handle JSON serialization. Like the other python pkgs, such as flask, requests, etc, DaprClient can have default json serializer to serialize and deserialize python dict type or primitive objects and provide .json() helper to DaprResponse and DataContent in AppCallback Layer. It will improve development experience instead of serializing and deserializing data object.

Will this work?
response = DaprResponse()
response.json() # Returns json
response.serialize() # Returns object

Will this work?
response = DaprResponse()
response.json() # Returns json
response.serialize() # Returns object

Hey @youngbupark , I want to tackle this again. Could I ask if this is the result you seek?

Yes, I think your proposal matches what we're looking for here. Would be glad to accept a PR with these changes.


fix retagging of vtable ptrs

Fixes a problem reported by @saethlin on Zulip.

@bors r+

:pushpin: Commit a4e7e1e6b59e006d5b5599e2d6a181a77bf8ee04 has been approved by RalfJung

:hourglass: Testing commit a4e7e1e6b59e006d5b5599e2d6a181a77bf8ee04 with merge 2e20cae150429785d9357d5bd060c6b48e3c36ca...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 2e20cae150429785d9357d5bd060c6b48e3c36ca to master...


JSDelivr: Package size exceeded the configured limit of 150 MB.

What happens?
Running the sample code with CDN is leading to error.
JSDelivr is not serving the package files and instead showing the below error:

Error:
Failed to load the file listing.
Package size exceeded the configured limit of 150 MB.
Consider asking the author to remove unnecessary files to make the package smaller.
To Reproduce
Use the example code with CDN as duckdb.getJsDelivrBundles()
Full code:
  const JSDELIVR_BUNDLES = duckdb.getJsDelivrBundles();

  // Select a bundle based on browser checks
  const bundle = await duckdb.selectBundle(JSDELIVR_BUNDLES);

  const worker_url = URL.createObjectURL(
    new Blob([`importScripts("${bundle.mainWorker}");`], { type: "text/javascript" })
  );

  // Instantiate the asynchronus version of DuckDB-wasm
  const worker = new Worker(worker_url);
  const logger = new duckdb.ConsoleLogger();
  const db = new duckdb.AsyncDuckDB(logger, worker);
  await db.instantiate(bundle.mainModule, bundle.pthreadWorker);
  URL.revokeObjectURL(worker_url);

Browser/Environment:
Edge latest
Device:
PC
DuckDB-Wasm Version:
1.28.1-dev65.0
DuckDB-Wasm Deployment:
jsdelivr
Full Name:
Gopalakrishna Palem
Affiliation:

Thanks, this was reported on https://discord.duckdb.org, I will be looking for ways to avoid this regression.

Relevant PR connected to this: https://github.com/duckdb/duckdb-wasm/pull/1574, see also the discussion there.
The problem I think here is that there are a lot of functions that are exported (about 80K), and they have on average names that are about 100 characters, and those names are repeated 5 times (1 in the wasm file and 4 in the js file).
80K * 100 * 5 = 40M that is about the overhead we are looking at (multiplied by multiple files since there are [browser | node] [mvp | eh | threads] versions.
@Y--'s solution cuts this to around 10%, that is a great results, but has some brittleness that if possible I would like to avoid.
I am exploring a similar solution that should cut about the same amount, look in the answer to the PR for more details, and long term an improvement of Emscripten is due since most of this overhead is unnecessary.
If there is any feedback, it's welcome.

To add, this problem is affecting the latest release on npm, e.g.:
https://cdn.jsdelivr.net/npm/@duckdb/duckdb-wasm/+esm
I’m wondering if you intended to make 1.28.1-dev82.0 the current release (@latest tag), or if you intended for this to be a prerelease? Because this version still works:
https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>If you intend these to be prereleases, I’d recommend publishing them to the next tag, say using npm publish --tag next. (I wrote a guide on this some years back.)

@mbostock: I like this a lot, I will have next be the tag for development versions. Opened #1591 to track that.

After #1589 and #1590 package size is now 137.8MB, and jsdelivr is back online: https://www.jsdelivr.com/package/npm/@duckdb/duckdb-wasm
And a cool side effect of the JavaScript side reductions is also that the shell.duckdb.org startup is now faster, even though there are further margin for improvement.
I have also set up a CI job that should compute the size of the package to be uploaded, see for example https://github.com/duckdb/duckdb-wasm/actions/runs/7566857429/job/20605607846#step:22:112, next step is setting up a check that will avoid publishing if the total size is above 150MB / flag this as failure for PRs.


Grow DataBuffer size to twice capacity when calling reserve method

When we call the velox parquet write API in Gluten, the execution time can be 800s when writing 1GB TPC-DS store_sales. And we found that the performance bottleneck is the constant reallocating of the memory pool. The reason is that DataBuffer is directly reallocated in reverse() method , and memcpy  must be called every time, resulting in performance degradation. We adjust the size of each reallocate to 2 times in this PR. The execution time can be 3s with this PR.

@mbasmanova Can you help to review? The existing unit test already test the this PR and maybe failed by the capacity size check. I will fixed the failed unit test if you agree with this change. Thanks.

cc: @Yuhta