[Tests required] publisher for es6 projects

Viewer, GUI and inspector will now be published as extra es6 packages.
The publisher has a configuration file now.

Adressing https://github.com/BabylonJS/Babylon.js/issues/3314

\o/ Thanks !!!

working on fixing the tests


[v1.0]Updated use case in dev guide

Use cases added:
Add person
Find person
Find person by tag

Coverage remained the same at 92.174% when pulling 2e3cd90ab3124634928a961b1cd885d403047142 on ALim95:V1.0_UpdateUseCase into 060345359f255a00d01ccc2490085e6fddd1f2d7 on CS2103AUG2017-T15-B4:master.


How do these scaling rules work?

Hi,
How do these scaling rules work:
If one of these 2 rules fire then one instance is added?
So these rules would fire only once or?
      {
        name: 'cpu-scaling-rule'
        custom: {
          type: 'cpu'
          metadata: {
            type: 'Utilization'
            value: '25'
          }
        }
      }
      {
        name: 'memory-scaling-rule'
        custom: {
          type: 'memory'
          metadata: {
            type: 'Utilization'
            value: '50'
          }
        }
      }

The code mentioned will be removed in my future updates, as it makes no sense to scale based on agent utilization. But if you want to read about those rules please refer to this doc https://learn.microsoft.com/en-us/azure/container-apps/scale-app?pivots=azure-cli


Carthage support

Would be nice to have this working on carthage

Hey @gordoneliel , these code is now part of SkeletonView, Carthage support should be added in the next version.

Awesome, thanks!


reflex --regex REGEX does not catch argument

reflex --regex REGEX does not catch the argument where reflex -r REGEX does.
It fails with: flag needs an argument: --regex

You have to write --regex=REGEX in the long form.

Thank you, sorry for inconvenience.


Exception initializing QuantBook() on local research notebook

Since the recent docker image updates, the following exception is thrown when trying to initialize QuantBook()
Launching a terminal on the docker yields that the mentioned folder '/Lean/Launcher/Data' doesn't exists, though '/Lean/Data' does exists and is correctly mounted from the local machine
qb = QuantBook()
 DirectoryNotFoundException: Could not find a part of the path '/Lean/Launcher/Data/market-hours/market-hours-database.json'.    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func2 errorRewriter)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
at System.IO.File.InternalReadAllText(String path, Encoding encoding)
at System.IO.File.ReadAllText(String path)
at QuantConnect.Securities.MarketHoursDatabase.FromFile(String path)
at QuantConnect.Securities.MarketHoursDatabase.FromDataFolder(String dataFolder)
at QuantConnect.Securities.MarketHoursDatabase.FromDataFolder()
at QuantConnect.Algorithm.QCAlgorithm..ctor()
at QuantConnect.Research.QuantBook..ctor()
`

Hi @ereztison, we couldn't reproduce the issue on our side.
Please try pulling the latests Docker images, installing the latest LeanCLI and running lean init on an empty folder for your organization. Pull your project, launch the research environment there, and let us know if the issue persists.


Update interested-technical-writers.md

Add Pronoy's name and profile

Thank you for your interest in Season of Docs! Would you please add your information to the end of the file as specified in the instructions? Thank you!


Improve deps in project generator

Fixes #5870

@sneridagh humm now can we move the lint packages that are in Volto dependencies to devDependencies?

Not yet 😊

@sneridagh done


Thank you test issue

This is an issue to test the thank you bot

Thank you @dpnl87 you for submitting this issue. We will get back to you shortly!

Thank you @dpnl87 you for submitting this issue. We will get back to you shortly!

Thank you @dpnl87 you for submitting this issue. We will get back to you shortly!

Thank you @dpnl87 you for submitting this issue. We will get back to you shortly!


IMGPROXY_FALLBACK_IMAGE_HTTP_CODE - doesn't work as documented

Issue opened by pitch.com

We are having issues setting IMGPROXY_FALLBACK_IMAGE_HTTP_CODE to zero.
The documentation from https://docs.imgproxy.net/configuration/options#fallback-image says:

IMGPROXY_FALLBACK_IMAGE_HTTP_CODE: the HTTP code for the fallback image response. When set to zero, imgproxy will respond with the usual HTTP code. Default: 200

However, the following command fails with a FATAL error:
$ docker run -p 8080:8080 -e IMGPROXY_FALLBACK_IMAGE_HTTP_CODE=0 -it darthsim/imgproxy
FATAL   [2024-08-20T11:04:44Z] Fallback image HTTP code should be between 100 and 599

Additionally, it isn't very clear from the documentation what is the "usual HTTP code". e.g. Is it 5xx in a case of internal failure?

Hey @pistazie!
Ahh, thanks for catching this, there was an error in this config's check. It's strange that nobody ever faced this.
Anyway, fixed in the latest build.

Additionally, it isn't very clear from the documentation what is the "usual HTTP code"

This is the HTTP code imgproxy would respond with if no fallback image is used.


Batched extraction of speaker embeddings for Nemo word-level baseline

@microsoft-github-policy-service agree company="BUT"

@microsoft-github-policy-service agree company="BUT"

Sure, the previous version of diarization on recording MTG_30860_plaza_0 runs 1 min and 36 s on NVIDIA RTX A5000, and the batched version runs 31 s. It can be further improved by inferring multiple segments in a batch. However, I see that Whisper per-channel inference is now the primary problem.

I suggest using the HuggingFace implementation of Whisper long-form decoding.

If you know of an implementation as accurate as Whisper large-v3 and also faster (or at least one that supports batching independent streams), it would be great to know. My impression was that there's a speed/accuracy tradeoff.

HuggingFace Transformers previously utilized a chunked algorithm. Recently, they have also introduced a sequential algorithm, similar to the one used in the original openai repository, supporting batched inference, flash attention, and speculative decoding.
After experimenting with it, I found that the text outputs are satisfactory. However, I noticed some noise in the timestamps. To address this issue, I integrated an external model for force alignment. As a result, the baseline ASR now runs in approximately 2-3 minutes with large-v3 compared to 8 minutes with the OpenAI implementation on an RTX A5000. Although I initially considered creating a PR, I ultimately decided against it due to the reliance on an additional model for force alignment.
Additionally, there is a helpful blog post that compares various Whisper implementations: https://amgadhasan.substack.com/p/sota-asr-tooling-long-form-transcription.


Time is off by an hour. Implement quick fix.

Something is causing the time to be displayed off by one hour (8:30 instead of 7:30) even though it appears to be written correctly. I couldn't track that down right now, but I did this quick and dirty fix just to get it right on the page.
@aaronj1335
@lawnsea

hey thanks for spotting this! the part i got wrong is actually the time zone, mind changing that to -05:00 instead of -06:00?

(and leaving the time at 7:30 PM)

I didn't know what the 06:00 was. Will do.

All done. Merge at your leisure. (pronounced leh-zhure)


[joy-ui][docs] Add Next.js App Router instructions on how to prevent flickering

Added Next.js App Router instructions on how to prevent Flickering on first load.
Tested, works.
Preview:

[X] I have followed (at least) the PR section of the contributing guide.

Thanks for PR! Just quickly reviewing the writing. Also, can I ask you to change the target base to next instead? Feel free to either change it in this PR or create a new one if there's too many conflicts to do that.

Hey! Thanks for the suggestion!
I've created a new PR here. Feel free to have a look! I believe I've made all the requested changes, but an extra pair of eyes wouldn't hurt :)


Update hardware section on the downloads page

Currently the hardware section on the downloads page states "As well, Ledger is working on integrating Monero into their hardware wallets." whilst both the CLI and the GUI are currently able to directly generate a Ledger Monero wallet. Thus, the hardware section basically needs an update.

You are correct.

This could be closed, since #815 is merged. @erciccione?

+resolved


GET search failed: cannot get X-Ratelimit-Limit from header

Hi,
First of all: Thanks for working on this client!
When doing Search() I often receive the following error:
GET search failed: cannot get X-Ratelimit-Limit from header
Is this ratelimit stuff really necessary or should we maybe expect responses without this header?
Full code example:
		photoResponse, err := image.client.PhotoService.Search(ctx, &pexels.PhotoParams{
			Query: "finance",
			Page:  1,
		})
		if err != nil {
			return images, err
		}

@sklinkert
HI,
Thanks for using this client library.
The X-Ratelimit-Limit is always included in the 2xx response header of the pexels api.
https://www.pexels.com/api/documentation/#statistics
Is there something I can't reproduce in my environment but not included in the 2xx response headers in yours?
If this is occurring in your environment, the code to check RateLimit may not be necessary.
Also, official client libraries such as pexels-javascript, pexels-ruby do not check RateLimit. Therefore, RateLimit checking in pexels-go may not be necessary either.

Hi @kosa3,
I just double-checked it and I receive a 200 OK:
RESPONSE: 200
Headers: map[Access-Control-Allow-Origin:[*] Alt-Svc:[h3=":443"; ma=86400, h3-29=":443"; ma=86400] Cache-Control:[max-age=0, private, must-revalidate] Cf-Cache-Status:[DYNAMIC] Cf-Ray:[6f6903b16ea744fe-TXL] Content-Type:[application/json; charset=utf-8] Date:[Mon, 04 Apr 2022 09:28:32 GMT] Etag:[W/"7b4ceea4aa12dafd5fe1f63dcc4a9ec4"] Expect-Ct:[max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"] Server:[cloudflare] Set-Cookie:[__cf_bm=GiTprZPW4NyTstlUblpGwYCZkg5p4RXlJwfhXX_UH68-1649064512-0-AVQ5e2rL9osMYA3Z1qyhQdz4UvZfT5NA2JF0sqvlZj6tud0rxRu4ZO1DaP5wZ53jMw1BN56uwYhfA1yqzeavENk=; path=/; expires=Mon, 04-Apr-22 09:58:32 GMT; domain=.pexels.com; HttpOnly; Secure; SameSite=None] Vary:[Accept-Encoding] X-Frame-Options:[SAMEORIGIN] X-Ratelimit-Remaining:[20000] X-Request-Id:[80c20f21-4973-4f9f-8b22-672999657010] X-Runtime:[0.083814] X-Server:[anteater]]

If I disable the call to RateLimitFromHeader() it just works and I get images. So we should either remove the code or make it aware of missing header fields.

@sklinkert
Fixed code has been released.
Please confirm with v0.0.3.
https://github.com/kosa3/pexels-go/releases/tag/v0.0.3

Works for me, thanks!


#20492 update data grid accessibility for the JAWs application

Accessibility is updated for JAWs application only in the data grid. For cells.
Please check it for JAWs and NVDA

If you change and do not save the cell value, move to another cell using the keyboard arrows - it stops reading, reads only even cell values, or even stops working altogether. Nvda works correctly

verified


Add 7 second search timeout to kill off unhealthy requests

Related to https://github.com/creativecommons/ccsearch-infrastructure/issues/119
We're having occasional issues with Elasticsearch getting stuck on a query in production. Since we are unable to set a global timeout due to limitations of AWS Elasticsearch Service, it seems reasonable to set a timeout on search queries instead.

@aldenstpage can we log timeouts in Graylog so we see how much this is happening?

Yes, timeouts will show up in the query logs


isFrozen - confusing behavior

I have no idea when objects are supposed to be frozen, and when they are not. Can you guess which tests fail, and which don't?
import 'package:api/api.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  group('gRPC mutability', () {
    test('gRPC mutability 1', () async {
      final foo = Foo();
      foo.bar = Bar();
      expect(foo.bar.isFrozen, isFalse);
    });

    test('gRPC mutability 2', () async {
      final foo = Foo();
      foo.ensureBar();
      expect(foo.bar.isFrozen, isFalse);
    });

    test('gRPC mutability 3', () async {
      final foo = Foo();
      foo.clearBar();
      expect(foo.bar.isFrozen, isFalse);
    });

    test('gRPC mutability 4', () async {
      final foo = Foo();
      expect(foo.bar.isFrozen, isFalse);
    });
  });
}

Nevermind, the code sample is wrong. It was oneof which cleared another variable and made it frozen.


Setting register values does not work

It seems changing the value of registers (at least when analyzing a crash dump) is not possible. Attempting to change a register with the r command or in an extension with the IDebugRegisters::SetValue function returns no error, but doesn't do anything. When attempting to set the register value using the "Registers" window in the UI the value will be displayed in red (like a changed value), but the actual value remains unchanged.
Tested with:
Debugger client version: 1.2206.19001.0
Debugger engine version: 10.0.25136.1001

Agreed, modifying a register with a dump target should fail.
We'll take a look and see how hard this might be to fix, but no guarantees. It's crazy how often we discover clients that depend on implementation quirks like this.

We'll take a look and see how hard this might be to fix, but no guarantees. It's crazy how often we discover clients that depend on implementation quirks like this.

I must admit I have dependent on the particular implementation quirks of the old WinDbg for this scenario in the past (I'm very sorry) in WinDbg extensions I wrote. I do think modifying register values in a dump analysis session might be useful, I used it to recreate the specific execution context (saved by setjmp or similar custom mechanisms) of error situations before the crash was triggered. In particular by resetting rip, rsp, rbp etc. to recreate the callstack of the moment the error occured. Failing when a register is reset in a dump target seems reasonable and correct to me, however I would need to search for a different solution for my usecase.
I mainly discovered this behavior and created the issue, because my extensions failed to work with WinDbg Preview, because the behavior has changed compared to old WinDbg.

Just wanted to follow up on the current issue. Is the problem you're having primarily UI related? It seems that the registers are being set at the engine level, (visible via the r command) although they aren't updated when set on the UI Pane.
In a dump, I tried running:
> r rbx=0x00034
> r rbx
// displays rbx=0000000000000034

Is your problem only with the windbg UI or also the engine? Also, would you be able to provide more info on how you're using the registers once they are changed in the dump analysis/what commands are no longer working as a result?

Is your problem only with the windbg UI or also the engine? Also, would you be able to provide more info on how you're using the registers once they are changed in the dump analysis/what commands are no longer working as a result?

It seems to be a problem with the engine. Even if I set the register with for example r rbx=0x00034 and query it with r rbx it remains on it's old value. Same applies when I attempt to set the register in an extension when calling IDebugRegisters::SetValue directly. There is also no warning or error printed or returned by the function. Note that I tested this in a kernel dump file, it might not be a problem on different targets.
My main use case is to restore a different cpu context (which was the cause of the crash, before KeBugCheck was explicitly triggered). In the old WinDbg resetting the registers also immediately updates the call stack according to rip, rbp, rsp etc. which is very useful.


Add architecture image to quickstart sample

All azd public templates should have an architecture diagram. The azd product team asked that we add one. I suggest that we add two - one with APIM as the main template and one without.
We also should align the quickstart documentation to the azd samples.
Example here: https://github.com/Azure-Samples/todo-csharp-sql-swa-func

Removed azd quickstart


graph api: allow creating users without email

The login at the IDP may happen by username and the user may have no email. We should allow provisioning users without an email.
Furthermore, keep in mind: multiple accounts may share the same email.

need change test after fixing https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L27

we allow creating user with same email: https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L24


Automate publishing to NPM

Fixes #118.
This adds a script that performs all the steps from these instructions.
This needs to be tested against more edge cases, but it's built in a way where failures of certain steps will not cause harm. The script will end and you can try running it again without issues.
The script is written in a self-checking way, so it will verify its own assumptions before taking action, and fail with a friendly error message otherwise. For example, it won't continue if you have local changes in your worktree, or if you're not up-to-date with the latest upstream version, or if you enter an incorrect version number, etc.
Once I have push access to NPM, I can give this script a spin!

That's amazing! Bash is not my cup of tea and I still find your script pretty clear!
Would it be possible to add a beta flag? Could be useful for the first time you're going to publish using this script

That's amazing! Bash is not my cup of tea and I still find your script pretty clear!

Glad about that! There is a strict subset of the shell language that I have learned over the years that is safe to use, is platform independent, and avoids bad practices (like not wrapping all uses of variables in quotes, etc.). It doesn't make the scripts more readable, though 🙈

Would it be possible to add a beta flag? Could be useful for the first time you're going to publish using this script

You mean publish the package under a beta tag on NPM? Absolutely, will do! 👍


Changed testing screen UI

Description
I moved the testing screen from the main screen to the bottom panel and I changed its UI to be more compact. This makes it easier to modify and test.
Modified on Godot 3.1.2
Changes

plugin.gd - Replaced lines that added a new Main Screen with a line that added a panel at the bottom of the editor.
WAT.tscn - Moved buttons to PopupPanels under MenuButtons. Moved Details to bottom right and MenuButtons to top.
WAT.gd - Changed expand/collapse code to connect id_pressed to set_up_expand_and_collapse and then call relevant methods based on the selected item id.
options.gd - Combined Run signals into code similar to WAT.gd and changed Folder and Script selection nodes' paths.

Context Switching regarding updating scripts is a very good point.
Looks a lot sleeker and that match statement is great (I could probably abstract this out too so that the CLI/GUI go through the same thing).


No internet connection on Lunix Box

Hi
Is there a way that I can build without internet connection? Or is there a way  I can download a lunix version of spark-dbf?

No sorry - that is why I gave u the source code - so u can maintain the binary


SpanMaker not working on custom dataset

Hey @tomaarsen ,
Thanks for sharing this amazing repo, while working on https://colab.research.google.com/drive/1XoAjmgyx_Sgj4WuY7w7fLR_ItBm7-Dzu?usp=sharing
I was not able to embed tags using the following dataset: https://huggingface.co/datasets/nlpaueb/finer-139
Love to hear how to improve on it.
Looking forward to hearing from you.
Thanks,
Andy

Hello!
The notebook looks quite good. Am I correct in that the only concern is the not quite so amazing performance of ~24F1? I think this would be improved fairly notably with additional training, i.e. not restricting the training dataset to just 8000 samples, and/or training for 3 epochs.

Tom Aarsen


WAPA (BSP application) some page attributes are missing

When serializing a BSP application some attributes are missing. E.g. "IS_START_PAGE", "LAYOUTLANGU" and "DEVCLASS".

I think we should use lo_page->get_attrs instead of is_page

yeah, feel free to submit a PR
the CHANGETIME and DEVCLASS are/should be cleared on purpose, as the content can vary from system to system

fixed in https://github.com/larshp/abapGit/pull/719


Please elaborate more about the dictionary secion

The inner working mechanism is quite difficult to understand. For example, why dictionary squashing is needed, and what is the relationship btw the dictionary squashing and proof generation need to be clarified.

Thank you for the feedback! I will think about how we can properly introduce this, I think it would require a complete section on the CairoVM to understand properly

@enitrat when you figure out and are ready to assign the issue, I would love to work on it, I also have some issues with dictionaries and would use the opportunity to solidify my understanding and usage of dictionaries. Thanks


feat(frontend): findTwinToken util

Motivation
The goal is to create a util for finding a twin token that can be reused in token-grouping.util as well as in the upcoming convert.store.

@AntonioVentilii ready for another look


Enable check and test for all branches

Enable check and test for all branches and all commits.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.322%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
748

Relevant Lines:
1456

💛  - Coveralls

Before this change, github actions only run code checks and tests after the PR is created. This change lets us see failed tests before the PR is created.

After the change the checks run on every commit:

Ah, so you want to run tests against every commit.  The trouble with that is, we only get a limited number of free CI time (3000 minutes per month) on GitHub's infrastructure.  We will quickly run out of that resource if we run tests against every commit.
It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

Ah, so you want to run tests against every commit. The trouble with that is, we only get a limited number of free CI time (3000 minutes per month) on GitHub's infrastructure. We will quickly run out of that resource if we run tests against every commit.
It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

Oh I see. that makes sense. I'll close this PR.


README.md: tweak readme to include instructions for including csfml

It should be documented, since it's a bit esoteric to be honest.

I would imagine this is OS specific, because on linux it would already be included/install. I'd imagine the same thing can be said with Mac since it's Unix.
Maybe mark it as a Windows thing?

I'll leave this for now (talked about this on IRC a while ago)


Migrate TFJob examples to TensorFlow 2

What this PR does / why we need it:
Upgrade TensorFlow version in all Dockerfiles to v2
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part of #2015

@kubeflow/wg-training-leads Could you approve CI?

@sandipanpanda Have you tried to build and run these in your local? I guess that some of these couldn't be buildable or runnable.

Thank you for your contribution @sandipanpanda 🎉
@tenzen-y Is right, unfortunately we don't run all TensorFlow examples in on CI to verify them.
I am pretty sure that some TensorFlow APIs that we are using in examples are not compatible with TensorFlow 2.0.
For example, tf.train.AdamOptimizer is  tf.keras.optimizers.Adam in TF2: https://www.tensorflow.org/guide/migrate/migrate_tf2

@tenzen-y @andreyvelich Thank you for reviewing.
I have started working on migrating TFJob examples to TensorFlow 2 using the migration guide.

[x] Upgrade TensorFlow version in all Dockerfiles to v2
[x] Run the automated script to convert some of your TF1.x API usage to tf.compat.v1.
[ ] Remove old tf.contrib.layers and replace them with TF Slim symbols. Also check TF Addons for other tf.contrib symbols.
[ ] Rewrite your TF1.x model forward passes to run in TF2 with eager execution enabled.
[ ] Validate the accuracy and numerical correctness of your migrated code.
[ ] Upgrade your training, evaluation and model saving code to TF2 equivalents.
[ ] (Optional) Migrate your TF2-compatible tf.compat.v1 APIs including TF Slim usage to idiomatic TF2 APIs.

Hi @sandipanpanda, do you have time to finalize this PR ?

Hi, I am sorry I lack the bandwidth on work on this for the next couple of weeks.


Inconsistencies between return types on different Client methods

Roblox endpoints that take in a single ID, like users.roblox.com/v1/users/{userId}, usually raise errors when the passed ID is invalid or does not exist. For example, /v1/users/{userId} returns the following data and a 404 error when an invalid user ID is passed:
{
  "errors": [
    {
      "code": 3,
      "message": "The user id is invalid.",
      "userFacingMessage": "Something went wrong"
    }
  ]
}

In ro.py, this means we can raise a NotFound error:
roblox.utilities.exceptions.NotFound: 404 Not Found: https://users.roblox.com/v1/users/4.

Errors:
	3: The user id is invalid.
		User-facing message: Something went wrong

Endpoints that take in multiple user IDs, like games.roblox.com/v1/games/multiget-place-details, tend to ignore invalid IDs and don't raise errors if none of the IDs are valid. In ro.py, all of our get_PLURAL functions like get_places and get_universes maintain this behavior and do not raise errors for invalid IDs.
The issue is that not all of our get_SINGULAR functions use endpoints that only take in one ID. multiget-place-details is the only endpoint ro.py uses for places. Because it does not raise an error, get_place returns None if the place is invalid and doesn't raise an exception. Multiple other methods also have this behavior.
This causes an inconsistency between methods where some methods (the ones that send requests that take just one ID) raise errors with invalid inputs, but other methods (the ones that take multiple IDs but only pass one) don't raise errors.
The following Client methods all return None with invalid IDs:
get_user_by_username()
get_universe()
get_place()
get_plugin()

All other singular methods raise exceptions for invalid IDs.
This causes an inconsistency between methods. What should we do?
We have a couple options here:

Make the other methods also return None instead of raising exceptions

Not only is this a large breaking change, but it's also not proper when compared to API responses which do raise errors. I feel better about raising errors manually than I do about replacing the API's error behavior.

Raise fake NotFound errors on these methods in particular

I don't like this because we're only supposed to raise NotFound for actual 404 errors.

Create custom errors, like UserNotFound that are raised in place of NotFound on get_user and get_user_by_username, and do the same for other methods

This means you can't do a try-except for NotFound on get_user anymore, which is breaking.
Making it a subclass of HTTPException kind of breaks the rules because it's really only for 4xx/5xx HTTP status codes, not for other purposes.
Making it a subclass of RobloxException means we're not raising the right exception for get_user anymore. That's an actual HTTP exception, so I think we should keep that there.
Only raising it for get_user_by_username and not get_user is a bit weird for the developer because there's an exception called UserNotFound that isn't raised on the method used to get users but is raised on the method used to get users by username.

Live with the inconsistencies.

Obviously not ideal. 😔

Completely get rid of get_user_by_username, get_universe, get_place and get_plugin and force developers to use their plural counterparts: get_users_by_username, get_universes, get_places and get_plugins.

This makes the methods consistent now but breaks existing code and is not really ideal.

Well it should give an error when the ID of the user is invalid or does not exists

I edited this issue with proper information - sorry for posting it too early!

Completely get rid of get_user_by_username, get_universe, get_place and get_plugin and force developers to use their plural counterparts: get_users_by_username, get_universes, get_places and get_plugins.

This solution probably isn't ideal since it probably is slower than the other events, but if you was to go ahead with it you could maintain backwards compatibility by doing something like
def get_user_by_username(username):
   return get_users_by_username(username)[0]

I personally thing the 3rd one (Create custom errors) will probably be the ideal solution, but make sure to mark the release as a major release so people know it has breaking changes.

This solution probably isn't ideal since it probably is slower than the other events,

There is no speed factor here. get_place always just returned index 0 or None from get_places - it was always a shortcut.

def get_user_by_username(username):
   return get_users_by_username(username)[0]

This wouldn't help because it just creates another issue - now we have a method that raises an IndexError when the ID is invalid rather than returning None, which would break compatibility regardless. Retaining compatibility is not possible here.

Why don't you just error if get_user_by_username has no values in it and then just give a 404 not found an error?

Why don't you just error if get_user_by_username has no values in it and then just give a custom not found error

It already raises an error when no value is passed. I outlined the issues with a custom NotFound error in the first post.

This has been fixed in 4ad3e3d7588d65458f0fa6df10fd658a4a3ad6a5 and 5922eb187f869c31bd03a34bdb655a5685743cd3. Thanks everyone!


Added timeDiff snippet

Hi, Sean 👋 Thanks for submitting this PR.
I don't see a particular use case for this snippet considering it's a one-liner subtraction. Modern date libraries do support this functionality but with far advanced formatting that is not in milliseconds. Things like 2 days ago, about a year ago, etc.
I'll let @Chalarangelo make a final decision here. Note that I think we had snippet like this one in the past but just didn't accept it since it's far too low value to be on the website and pollute it.

Thanks for the contribution. Indeed what @fejes713 said is true, as this is a trivial implementation that most people working with dates will learn pretty much instantly. Closing due to lack of value for the average reader.


Fixed #24319 -- Added validation for UUID model field

If Tim agrees it's worth fixing the patch LGTM.


Reduce max future block time to 80s

This effectively acts as a damper to block difficulty.
Note: merging this will result in a hard-fork of the network.

@niklaslong this will require all nodes to update correct? Nodes that don't update might potentially see their blocks rejected I assume.

i think the nodes are not affected. They don't set the time in the future.

Rebased.


Events in the view

The example in the readme about events in the view doesn't seem to work, as the alert never shows:
var view = new Backbone.View({
    initialize: function () {
        this.bind("ok", okClicked);
    },

    okClicked: function (modal) {
        alert("Ok was clicked");
        modal.preventClose();
    }
});

var modal = new Backbone.BootstrapModal({ content: view }).open();

This is the related code in backbone.bootstrap-modal.js:
'click .ok': function(event) {
  event.preventDefault();
  this.trigger('ok');

  if (this.options.content && this.options.content.trigger) {
	console.log("Content:", this.options.content);
	console.log("Modal  :", this);
    this.options.content.trigger('ok', this);
  }

  if (this.options.okCloses) {
    this.close();
  }
}

I'm rather new to Backbone so I don't fully get what's happening with the context when this.options.content.trigger('ok', this) is called.
If someone could explain this to me and nudge me in the right direction to get the above example working, that would be great!
Thanks!

+1 for this


Added a commonMessageHandler to share DataLoaders between subscribers

Thanks for the graphql-postgres-subscriptions library! It does exactly what I need it to do, with one omission: I could not find a way to share a DataLoader between the different subscribers of a message.
Use case
The messages we publish mainly contain the primary keys of modified records in a database. This is to avoid leaking personal information, and also to avoid hitting the 9000 character limit of a Postgres notification.
The resolver then loads the record based on the primary key, but this record is the same for all subscribers. It therefore makes sense to share a DataLoader to avoid hitting the database multiple times.
Solution
The graphql-google-pubsub library handles this by adding an optional commonMessageHandler parameter to the constructor of the engine (see https://github.com/axelspringer/graphql-google-pubsub/blob/master/README.md#commonmessagehandler)
I added this same pattern to the graphql-postgres-subscriptions library, and added some basic tests and documentation for usage.
Please let me know if this is fit to be merged, or if you would like to see some other changes made to this.
I also fixed one of the existing tests that was occasionally failing by adding an intentional delay.

Thanks so much @jvdneut for this PR. Code, tests and documentation are 💯. Great job.
I'll take a closer look, merge this PR and release a new version before tomorrow.
Have a great day!

Looks good @JulianMayorga
I didn't add it to the options before because the graphql-google-pubsub added it as an additional parameter. I too prefer named parameters, so the destructuring fix is the better one.
Minor nitpick: my understanding of SemVer is that when a feature gets added the minor version, not the patch version, should be increased. 😉
I will switch back to using this NPM package again, instead of my self-published one.
Thanks!


[Quick accent] Add combining accent characters

Description of the new feature / enhancement
Add combining characters for accents in Quick accent. ( like ◌̀, ◌́ or ◌̃).
They could be assigned to a special key. For example 0 (numpad) or something like this.
Scenario when this would be used?
Adding graves to charactes who normally don't have them.
Supporting information
No response

This has been addressed as part of the 0.67 release cycle. Thank you!


Fix incorrect specs in Network

Fix error in Application Gateway specs caused by merge.
Also copy change from https://github.com/Azure/azure-rest-api-specs/pull/5194 into API version 2018-12-01.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

Automation for azure-sdk-for-java

@dsgouda please take a look, Travis job has passed


Get env variable from config.json and model.json

Here is a good feature to add ! When building microservice architecture, we often need to build images from dockerfiles and use kubernetes to configure the architecture of services. For host server, host clients and database clients(postgres or redis), the configuration often depends on env variable set with kubernetes and passed to containers.
The standard library can access env variable using std::getenv(char* path), if add it to the method loadConfigFile to replace all ${ENV_EXAMPLE} by the corresponded value. for example we can have { host: ${HOST_SERVER}, port: ${PORT} } in the config.json and when call loadConfigFlie("config.json"), replace ${HOST_SERVER} by std::getenv("HOST_SERVER") and replace ${PORT} by std::getenv("PORT").

Thanks for the feature request!
I think this feature would then also need some kind of flag, or we would have to introduce a second config loading mechanism to keep backwards compatibility, but we would definitely need to distinguish between the old, default behavior, and the replacement behavior, introducing another configuration layer.
I just wonder what the use case here is to load environment variables over the configuration file / inject environment variables into the configuration file? Currently I fail to understand in which environments this would be beneficial, or let’s say easier to implement?

Thanks for the feature request!
I think this feature would then also need some kind of flag, or we would have to introduce a second config loading mechanism to keep backwards compatibility, but we would definitely need to distinguish between the old, default behavior, and the replacement behavior, introducing another configuration layer.
I just wonder what the use case here is to load environment variables over the configuration file / inject environment variables into the configuration file? Currently I fail to understand in which environments this would be beneficial, or let’s say easier to implement?


vue create FrontDemo  error occured

Version
3.1.1
Reproduction link
http://localhost:8080
Node and OS info
node 8.9
Steps to reproduce
vue create FrontDemo

What is expected?
vue create FrontDemo, success
What is actually happening?
vue create FrontDemo ,  error

See https://github.com/vuejs/vue-cli/issues/2547


error while loading shared libraries

Expected behaviour
The program can run without error.
Actual behaviour
➜  src git:(master) ✗ ./test
./test: error while loading shared libraries: librestclient-cpp.so.1: cannot open shared object file: No such file or directory

Environment and debugging details

compiler and version
g++ (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0
operating system
ubuntu 16.04
libcurl version and compile flags

➜  src git:(master) ✗ dpkg -l '*libcurl*'
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                   Version                  Architecture             Description
+++-======================================-========================-========================-==================================================================================
un  libcurl-dev                            <none>                   <none>                   (no description available)
un  libcurl-ssl-dev                        <none>                   <none>                   (no description available)
ii  libcurl3:amd64                         7.47.0-1ubuntu2.12       amd64                    easy-to-use client-side URL transfer library (OpenSSL flavour)
un  libcurl3-dbg                           <none>                   <none>                   (no description available)
un  libcurl3-dev                           <none>                   <none>                   (no description available)
ii  libcurl3-gnutls:amd64                  7.47.0-1ubuntu2.12       amd64                    easy-to-use client-side URL transfer library (GnuTLS flavour)
un  libcurl3-openssl-dev                   <none>                   <none>                   (no description available)
un  libcurl4-dev                           <none>                   <none>                   (no description available)
un  libcurl4-doc                           <none>                   <none>                   (no description available)
un  libcurl4-gnutls-dev                    <none>                   <none>                   (no description available)
un  libcurl4-nss-dev                       <none>                   <none>                   (no description available)
ii  libcurl4-openssl-dev:amd64             7.47.0-1ubuntu2.12       amd64                    development files and documentation for libcurl (OpenSSL flavour)

full error output of your build as an inline codeblock or gist
I installed the library by compiling the source code.

➜  src git:(master) ✗ g++ -std=c++11 test.cpp -o test -I /usr/include -L /usr/lib -l restclient-cpp  -lcurl
➜  src git:(master) ✗ ./test
./test: error while loading shared libraries: librestclient-cpp.so.1: cannot open shared object file: No such file or directory

test.cpp:
#include <string>
#include <iostream>
#include "restclient-cpp/restclient.h"
#include "../include/json.hpp"
using json = nlohmann::json;

int main() {
    json request = {{"type", "post"}, {"parameters", {{"path", "test/file1"}}}};
    std::string s = request.dump();
    std::cout << s << std::endl;
    std::string url = "xxx.com";
    RestClient::Response response = RestClient::post(url, "application/json", s);
    std::cout << response.body << std::endl;
}

(some of these things might not apply but the more you can provide the easier
it will be to fix this bug. Thanks!)

did you install restclient-cpp from a provided package or built it yourself?

closing this for inactivity. Please feel free to reopen the issue if the problem persists.


Direct dictionary dataload failure with lenient date parsing

For DirectDictionary the dataload is failing when the java.text.SimpleDateFormat  api is doing the lenient  parsing

Closing this issues fixed as part of PR #458


Web UI supports Swagger pages

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the feature
The new Web UI should support Swagger page like the existing one does

Motivation
Align capabilities so that we can remove the legacy UI framework in next release
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[ ] No. I cannot submit a PR at this time.

cc @zwangsheng

@pan3793 Thanks for mentioning me, i'd like to take this.


Create ChatQnA example that uses MongoDB

ChatQnA example that uses MongoDB. https://github.com/opea-project/GenAIExamples/tree/main/ChatQnA
This would require to include Mongo as part of the validation at . And then create an updated ChatQnA that would use this microservice to use Mongo.

/assigntome

https://github.com/ard383/OPEA-ChatQnA-milvusDB Looks like the work that you've done @ard383 correct?

Hello Rachel,
Good day!
Yes, it is done by me @ard383
Regards,
Afzal Dharwadkar
From: Rachel R @.>
Sent: Friday, November 1, 2024 11:10 PM
To: opea-project/GenAIExamples @.>
Cc: Dharwadkar, AfzalX @.>; Mention @.>
Subject: Re: [opea-project/GenAIExamples] Create ChatQnA example that uses MongoDB (Issue #887)
https://github.com/ard383/OPEA-ChatQnA-milvusDB Looks like the work that you've done @ard383https://github.com/ard383 correct?
—
Reply to this email directly, view it on GitHubhttps://github.com/opea-project/GenAIExamples/issues/887#issuecomment-2452302072, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIXSPIMU2BUB2BMFXFUH243Z6O4GJAVCNFSM6AAAAABO734X2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGMYDEMBXGI.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


build: use the modern spelling for the Swift compiler (NFC)

This uses CMAKE_Swift_COMPILER which is used by CMake rather than
CMAKE_SWIFT_COMPILER which was used by the local Swift build system.

@swift-ci please test


feat: Add -since-timestamp

Problem Statement
Start scaning option using oura watch --since-timestamp <unix timestamp> as opposed to --since <slot>,<hash>
Currently we have following option

--since <slot>,<hash>: an option to specify from which point in the chain Oura should start reading from. The point is referenced by passing the slot of the block followed by a comma and the hash of the block (,). If ommited, Oura will start reading from the tail (tip) of the node.

It would be great if we had an option to specify oura watch --since-timestamp <unix timestamp>, this feature for the MVP will require Implement Blockfrost source.
To get the required <slot> and <hash>...

Can't koios not be used instead of blockfrost? https://api.koios.rest/

can you provide more context regarding the use-case for the feature?
implementing this is not trivial. Using blockfrost or koios is a valid option, but introduces an external dependency on the watch command which is meant to be used as lightweight view of the node output. Introducing an external service means we need to start thinking about api keys,  api quotas, retry logic, etc, all of this before we even connect to the node.
The ticket #92 for introducing Blockfrost (and we can certainly analyse Koios too) is meant to work as a custom source in the pipeline to be used in daemon mode. This allows the implementor to provide its own configuration: api key, retry logic, etc.
I would like to understand which use-case requires a timestamp, understanding the goal rather than the implementation detail might help us find an alternative solution.

I think the current timestamp is ok, beside the 19 seconds offset :smile:

@gitmachtl 🤦  I know, but FYI, the 19-sec offset has already been fixed in main branch, to be released in the 1.1.

As stated above, implementation of this is not trivial and requires adding external dependencies. In my opinion, cost outweighs benefits. Closing this issue for the time being, we can revisit in the future if we find that it's blocking a concrete use-case.


Update dotnet SDK

Description

Update dotnet SDK to latest
Make code changes to accommodate analyzers
Update docker build image

Related issues
N/A
Testing
Existing tests and ad-hoc app service deployment

You can see there is a test CI deployment under the checks too


Scale value problem for cumulative data

Kamstrup 6841138AN243101090 (Kamstrup_V0001) in Sweden
Binary data captured directly on the meter and sent unaltered via MQTT

With the default config dialog scale value of 1 all sensors report correctly (power, current, voltage) except the cumulative values that in my case would need a scale value of 0.1. E.g. the meter has used 38062 kWh in total (as read on the display) but the "Cumulative hourly active import energy (A+) (Q1+Q4)" reports 380620 kWh. As this is the sensor I would like to use as the total consumption for the Energy dashboard in HA this setup does not currently work for this meter.
Not sure what the best solution would be but if the meter reports "incorrect" values maybe more than one scale value is needed in the configuration dialog? I.e. one general scale value and one for the cumulative measurements?
For now I've changed the scale values in sensor.py to fit my needs as a workaround.

Are you able to provide raw sample data from MQTT topic?

@StarkJohan  Are you able to provide raw sample data from MQTT topic?

Sorry for not getting back to you on this Tore. I've had to prioritize other things. I would be able to provide data but I've been using AmsToMqttBridge which has been spot on for the hourly data for 4-5 weeks at this point. As it "just works" (after a few code adjustments to fit my needs, e.g. the above mentioned scale values) I will have to return to help you get this sorted at a later date.

@toreamun Just installed. What an amazing integration! I am also getting incorrectly scalead cumulative values. It would be correct with a scaling of 0.1. Everything else is scaled properly.

I do have the same issue. How can I help to solve this?

@eribi Here is a the workaround I am using:
Disable the faulty entities:

`sensor:

platform: integration
source: sensor.kamstrup_active_power_import
name: Energy import (kWh)
unit_prefix: k
round: 2
platform: integration
source: sensor.kamstrup_active_power_export
name: Energi export (kWh)
unit_prefix: k
round: 2`

Here's a snippet of a hex dump of the hourly data packet over MQTT from Kamstrup_V0001:
Raw file and hex translation also attached.


Minimum Batch Size locked to 2

I might not be familiar enought with tensorRT or similar concepts/software to know the details, so apologies if it's not an issue but a natural limitation.
When Converting ONNX to TensorRT, I set the minimum/maximum batch size to 1, since with my amount of VRAM some upscalers run out of memory on batch sizes larger than 1, plus using batch count is generally more convenient.
However, the command for conversion looks like this:
"<...>\stable-diffusion-webui\extensions\stable-diffusion-webui-tensorrt\TensorRT-<IP_ADDRESS>\bin\trtexec.exe"
 --onnx="<...>\stable-diffusion-webui\models\Unet-onnx\dreamshaper_6BakedVae.onnx"
--saveEngine="<...>\stable-diffusion-webui\models\Unet-trt\dreamshaper_6BakedVaeHeightPromptTest1.trt"
--minShapes=x:2x4x8x8,context:2x77x768,timesteps:2
--maxShapes=x:2x4x96x64,context:2x462x768,timesteps:2 --fp16

Specifically, the first value here (--minShapes=x:2x4x8x8) is set to 2 instead of 1, and it's minimum batch size if I get it right. In any case, I get Exception: bad shape for TensorRT input x: (1, 4, 96, 64) whenever I try to use the batch size of 1.
In Python code there's a min_bs variable responsible for the batch size, if I get it right, and it gets multiplied by 2 for some reason:
x_min = f"{min_bs * 2}x4x{min_height // 8}x{min_width // 8}"
Changing this and converting the model again still throws an Exception.
Thanks!
So, am I doing something wrong or is it intended?

I'm getting this error as well and I have no idea why!

You might try setting your maximum prompt token count to 75 instead:
"<...>\stable-diffusion-webui\extensions\stable-diffusion-webui-tensorrt\TensorRT-<IP_ADDRESS>\bin\trtexec.exe"
--onnx="<...>\stable-diffusion-webui\models\Unet-onnx\dreamshaper_6BakedVae.onnx"
--saveEngine="<...>\stable-diffusion-webui\models\Unet-trt\dreamshaper_6BakedVaeHeightPromptTest1.trt"
--minShapes=x:2x4x8x8,context:2x77x768,timesteps:2
--maxShapes=x:2x4x96x64,context:2x462x768,timesteps:2 --fp16
this part here -->  --maxShapes=x:2x4x96x64,context:2x462x768,timesteps:2 --fp16
try changing to     --maxShapes=x:2x4x96x64,context:2x77x768,timesteps:2 --fp16

I made a fix for all these issues. You can check out my fork with the changes here: https://github.com/jebarpg/stable-diffusion-webui-tensorrt
I did all the manual testing and discovered the limits of all the shapes you can create with max width, height and batch sizes. The best batch size and max width and height I have found is bs: 7 maxW: 512 maxH: 512. You can max out the max tokens it has no effect on the shape size limit only the max batch size, max width, and max height have any effect. I also discovered a base number per every batch size from 1 to 11 which lets you know how far you can slide the max width and height. You will get a red label signaling that you are over the limit and green otherwise. I've created a pull request so hopefully it gets integrated in. Also you can do batch processing instead of just one model at a time. for both the onnx files and trt files. NOTE that your settings for max width height batch size tokens etc will apply to the entire batch. Let me know what you all think.


Do you have any plan for Descript List?

I like TwitterBooststrapMvc.
But this is useful for Create, Edit pages.
It's needed DescriptionList supports  tag for Delete, Details pages.
 It's not an MVC control (at least I'm not aware of such), it's not a Bootstrap component. I don't know what is the specification for it

Descript List is bootstrap component.  tag dl is simplified of description list.
https://getbootstrap.com/css/#description

I see now. I'll add it if more people show interest in it. The truth is, having a BMVC helper for it would not really reduce code complexity because it's just couple tags and there is no complex structure to it.


TestTemplateLevelHooks functional test is flaky

Flaky functional test.


AS3 incorrectly complains about duplicate IP when virtualAdddresses reference existing virtual-address in Common

Environment

Application Services Version: 3.46.0
BIG-IP Version: <IP_ADDRESS>

Summary
When posting declaration with 2 Service_TCP objects where each service is referencing separate existing virtual-address objects in /Common/Shared folder, AS3 incorrectly thinks that the 2 Services share the same IP and rejects the declaration,
Steps To Reproduce
Steps to reproduce the behavior:

Manually configure virtual-address objects in /Common/Shared folder in BIG-IP

ltm virtual-address Common/Shared/service_address_10_0_1_7 {
    address <IP_ADDRESS>%1
    auto-delete false
    inherited-traffic-group true
    mask <IP_ADDRESS>
    route-advertisement any
    traffic-group Common/traffic-group-1
}
ltm virtual-address Common/Shared/service_address_10_0_1_22 {
    address <IP_ADDRESS>%1
    auto-delete false
    inherited-traffic-group true
    mask <IP_ADDRESS>
    route-advertisement any
    traffic-group Common/traffic-group-1
}

Submit the following declaration:

{
  "class": "AS3",
  "declaration": {
    "AS3tenant": {
      "Shared": {
        "class": "Application",
        "example_22_VS": {
          "class": "Service_TCP",
          "profileTCP": {
            "bigip": "/Common/f5-tcp-progressive"
          },
          "virtualAddresses": [
            {
              "bigip": "/Common/Shared/service_address_10_0_1_22"
            }
          ],
          "virtualPort": 80
        },
        "example_7_VS": {
          "class": "Service_TCP",
          "pool": "example_POOL",
          "profileTCP": {
            "bigip": "/Common/f5-tcp-progressive"
          },
          "virtualAddresses": [
            {
              "bigip": "/Common/Shared/service_address_10_0_1_7"
            }
          ],
          "virtualPort": 80
        },
        "example_POOL": {
          "class": "Pool",
          "members": [
            {
              "serverAddresses": [
                "<IP_ADDRESS>",
                "<IP_ADDRESS>"
              ],
              "servicePort": 8082,
              "shareNodes": true
            }
          ]
        },
        "template": "shared"
      },
      "class": "Tenant",
      "defaultRouteDomain": 1
    },
    "class": "ADC",
    "label": "Manual AS3 Declaration",
    "remark": "Manually modified version of CIS",
    "schemaVersion": "3.45.0"
  }
}

Observe the following error response:

{
  "results": [
    {
      "code": 422,
      "message": "declaration failed",
      "response": "01070333:3: Virtual Server /AS3tenant/Shared/example_22_VS illegally shares destination address, source address, service port, ip-protocol, and vlan with Virtual Server /AS3tenant/Shared/example_7_VS.",
      "host": "localhost",
      "tenant": "AS3tenant",
      "runTime": 1190
    }
  ]
}

Expected Behavior
AS3 accepts the declaration and configure the 2 Virtual Server objects with different, pre-existing virtual-address as the destination IP.
Actual Behavior
AS3 rejects the declaration citing duplicate VS IP, although the declaration clearly references different virtual-address objects in /Common/Shared, and the virtual-address objects clearly have different address.

Thank you for your feedback. I have confirmed your issue and I have added it to our internal product backlog as AUTOTOOL-4001.
I noticed your virtual address objects are in /Common/Shared. If those objects are being managed by AS3, then I recommend referencing them with the use keyword instead of the bigip keyword. I was able to work around the issue by using the use keyword.

Please reach out to us at<EMAIL_ADDRESS>in order to prioritize this issue. Thanks.


Fix to showing Read More on post page #113

Fix to showing the description section of a post collapsed when viewing the post page.

@projectnoa After deploy this PR The behavior looks reverse as the requirement:
https://near.social/#/mob.near/widget/MyPage?accountId=devgovgigs.near (should clamp, but it does not)
https://near.social/#/devgovgigs.near/widget/gigs-board.pages.Post?id=532 (should not clamp, but it clamps)
Can you look into it?

I fixed it in https://github.com/near/neardevhub-widgets/pull/127

Thanks @ailisp!


Allow cross join functionality

In principle, it should be possible to construct what is effectively a CROSS JOIN by an expression with nested Selects like ds.Select(lambda e: e.jet_pt.Select(lambda pt1: e.jet_pt.Select(lambda pt2: pt1 + pt2))), but this currently won't work as expected (you'd just get 2 times each jet's pT). In order to handle this properly, there needs to be some kind of check on the depth in Select. This is needed to do anything using pairs, triplets, etc. of objects.
Using a dedicated operator would be much simpler, however. This depends on iris-hep/qastle#46.

I put this already into the xAOD backend - this is where most of the complexity in that library comes from, and most of the headaches. Basically, I have to associate a context with each lambda variable, so pt1 and pt2 don't go back to different things.
That said - the specific thing here - doing a double of an object, isn't supported in anything higher up (like hep_tables) because it is painful. :-)

What I'm learning is that this is probably the single hardest thing to do with a columnar backend. It quickly becomes very fragile and leads to unreadable queries. I think adding a CrossJoin operator is a much better solution here. If you don't allow closures (that is, lambdas that can capture variables that are not among its own parameters), things get much simpler.

Sketch:
[1, 2].CrossJoin([3, 4]) -> [[1, 3], [1, 4], [2, 3], [2, 4]]

After playing with a CrossJoin for a while, I realized it doesn't actually help much in the case that I was looking at (because I would also need GroupBy, but that already comes for free with the original pure Select version of cross join). This is going to be a pain no matter what, so it's probably not worth adding another operator. I'll just focus on getting the original example working.

Sounds like a good approach forward. LINQ has lots of operators. The difference between what we are doing here and the LINQ C# project I was doing is that we aren't expected func_adl to do everything. We want it capable enough to really cut down on the amount of data that needs to be sent upstream. And then it is fine to use awkward and other things to do the rest of the work.


Stuck on "Loading music library"

OS:
Debian GNU/Linux rodete
GPMDP Version:
4.6.1
Issue Descriptions:
Since last week, opening the app does not show anything, instead I get stuck on a "Loading music library" page
Steps to Reproduce:

Open the app
Stuck on loading page, nothing working.

Same issue on Windows on all PC's I have using it.

Open GPMDP from pinned taskbar icon, system icon, or other method.
Player never gets beyond "Loading Music Library," progress bar does not move at all.

I have the same problem от Windows 10 on Laptop and Desktop.

Start GPMDP 4.6.1 from Menu or Desktop Icon.
Player stops on window "Загрузка Фонотеки" (Loading Music Library).
Uninstall GPMDP and clear the registry .
Install GPMDP 4.6.1
5

. Player stops on window "Загрузка Фонотеки" (Loading Music Library).

Same problem on MacOS even after deleting the cache.

+1 happening on Debian x64 for the last few days as well

+1 here too, installed newest version, Ubuntu Linux 18.04

+1 Mac Pro, OSX 10.14.6, GPMDP 4.6.1
Did full uninstall (removed app and ~/Library/Applications/GPMDP dir) and reinstalled. Authenticated user account. Hanging on "Loading Music Library..." screen.
Tried downgrading to 4.6.0 and that made no difference, still hangs on "Loading Music Library..." screen after authenticating.
Not sure if this is related but I looked at the ~/Library/Applications/GPMDP/gpmdp.log and saw an error:
{"level":"info","message":"Application started.","timestamp":"2019-10-10T19:54:34.169Z"}
{"level":"error","message":"Failed to load bonjour with error: {}","timestamp":"2019-10-10T19:54:34.629Z"}

Possibly related, but this loading issue first started for me when the website certificate expired (GH-3639).

Running into the same issue of Windows 10

Not sure why this is happening. It's more than likely a problem in the player causing an error that prevents GPM from loading. If that's the case these steps may not work, but if you can try them anyway:

Press CTRL + SHIFT + G
Enter (without quotes): "DEV_MODE"
Click Go
You should now be in dev mode, and able to open developer tools from either the menu or by using CTRL + SHIFT + i
This is the main window console, you may see errors, take a screenshot or copy and paste and errors from this console.
In addition to this you can type openGPMDevTools() Enter and it will open another console, you may have more errors here, copy these as well.

Not sure why this is happening. It's more than likely a problem in the player causing an error that prevents GPM from loading. If that's the case these steps may not work, but if you can try them anyway:
1. Press CTRL + SHIFT + G

2. Enter (without quotes): "DEV_MODE"

3. Click Go

4. You should now be in dev mode, and able to open developer tools from either the menu or by using CTRL + SHIFT + i
   This is the main window console, you may see errors, take a screenshot or copy and paste and errors from this console.
   In addition to this you can type `openGPMDevTools()` Enter and it will open another console, you may have more errors here, copy these as well.

Running into these errors:
Console:

GPMDevTools:

I don't have access to listen_v2.js, as I'm being served listen.js. However, that is a weird error being thrown. window.customElements.upgrade is a function when I test it on the current release, so it shouldn't be throwing an error.

Same error on windows 10 started friday morning.
But youtube Music is still working tough.

I get the same console errors as above.  If I clear cookies and reload, it asks me to login again, but after login it goes to the same place.
I wonder if it is trying to show some kind of "upgrade" UI to some users based on their account status, and that thing is failing to load in this app environment.

In a regular Google Play Music tab window.customElements.upgrade is a native function, and chromestatus.com shows it as added in Chrome 68 https://chromestatus.com/features/5967337471606784
The package.json lists electron 3.18 which seems to be Chromium 66.0.3359.181

I can confirm that the artifact from the WIP Electron 4 PR https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/pull/3588 does seem to get past the Loading Music Library screen. Hopefully this can get merged before listen_v2.js is rolled out to everyone.

Ah interesting, maybe this just needs to ship a new build with newer version of the Chrome engine in it?

I see the same error for 4 days :(

You can start it with the following DEV_MODE (see above) workaround:
On the openGPM devtools (see above) console, put a breakpoint on listen_v2, line one. Then refresh the page, and enter window.customElements.upgrade = () => undefined [enter] and then continue running the script. It magically doesn't need the upgrade function because just setting it to something that does nothing at all makes it work.
In any case, it allows you to use your GDP with some pain at startup. You can close the DevToolss (?? plural2) and use the player as normal from there on in.

Windows 10. DEV_MODE say:
Local\GPMDP_3\app-4.6.1\resources\app.asar\node_modules\react\lib\lowPriorityWarning.js:38
Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead.
Pls fix it!

Fix available (for Windows, at least):

Install 7zip
Install Asar7z
Make sure GDMP is closed, exited and shut down
Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)
Make a backup copy of app.asar to app.asar.backup in the same folder
Open app.asar with 7zip (open as archive)
In 7zip, navigate to build\renderer\windows\GPMWebView\
Drag index.js from there to your desktop or some folder
Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++)
Changefunction _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

tofunction _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

(If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)
Save it or it's as if you did nothing
Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.
Close 7zip
Start your music player, it should work now

Fix available (for Windows, at least):

Install 7zip (at your own risk)

Install Asar7z (at your own risk, it could have a large number of hairy viruses)

Make sure GDMP is closed, exited and shut down

Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)

Make a backup copy of app.asar to app.asar.backup in the same folder

Open app.asar with 7zip (open as archive)

In 7zip, navigate to build\renderer\windows\GPMWebView\

Drag index.js from there to your desktop or some folder

Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++ at your own risk)

Change
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

to
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

(If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

Save it or it's as if you did nothing

Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.

Close 7zip

Start your music player, it should work now

Clean up the straggling index.js and if you're happy, confident and brave, your app.asar.backup. Also, clean your desk.

Do this each time you want to run it.

Just kidding, it'll work from now on.

Seemed to work for me. Thanks!!!

FWIW instead of copying the file out to edit it, I just used the edit option in the 7-zip right click menu, it copies it to a file for you and when you change that file it offers to update the zip file.

Yes, but that doesn't work if Notepad is your default editor due to bad line ending handling. That's why the long version...

Actually I made the change using notepad and it didn't cause a problem.

My bad I never went to W10 because GetWindows10 gave me a bad taste continued with Windows Spyware integration. Of course MS improved Windows massively by adding LF support and I was unaware. Are there any other changes in W10 that are important or matter in any way I should be aware of? Nvm... this is not a chat room...

For me, Windows 10 is the best Windows version.  Lots of little improvements all over the place.  Better notepad, dark mode, command line, etc..  But I know there are some in your face items that annoy people.  I think they might have annoyed me at first but over time I've gotten used to it and forgotten what they are.

  Instead of using Asar7zip I installed the asar NPM package:
npm i -g asar
Then I just extracted the package, backed-up/edited the file as you stated above, then re-packed it:
asar e app.asar app
... edit file ...
asar p app app.asar

Can anybody share their fixed app.asar?

Same is happening to me (4.6.1), although youtube music mode works.

Happening for me on macOS mojave

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

It was actually me that came up with the fix. tpetersen50 just quoted me.

It was actually me that came up with the fix. tpetersen50 just quoted me.

Yep, I take no credit for the fix!

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Works, Thanks

@crayfishuk your file works for me too, thanks for making it easy

@MarshallOfSound any word on updating to electron 4 to fix this issue?

For Mac users, you'll want to open your ~/applications/ folder, ctrl-click the app > "Show package contents" and then navigate and continue using @ddsol's instructions. (Thanks for a solution btw)
One difference is that I used Electrons asar command line tool which you can checkout here:
https://github.com/electron/asar

@bitojoe
I don't suppose you'd be willing to explain in a bit more detail how you did that, would you? I'm pretty new at all this (though I do have a fair amount of experience with javascript and web development). I just did a fresh install on Catalina on my MacBook Pro (Retina, 15-inch, Mid 2015), and I'm experience the same problem. I tried to follow your instructions, but I'm just getting a javascript error.

I assumed that I could ignore the  7zip / index.js parts of the instructions from @ddsol because 7zip is not a mac-compatible app anyway.
All I did was "show package contents," open the app.asar file and replace the block of code as instructed. Saved, closed, tried to execute the program to no avail.
I don't understand the significant of the asar command line tool you mentioned, which is probably the main issue here. I downloaded the files from the github link you provided, but I don't know what I'm supposed to do with them. Don't suppose there's a tutorial or something you'd recommend?

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Thanks! Worked for me (OSX 10.12.6), gonna patch my windows machine at home tonight.

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Worked for me. Thanks!

I don't know for sure if it's related, but now GMDP doesn't seem to populate the hamburger menu with its own settings option, nor does it respond to media keys for me.

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Works great, thanks for saving me the trouble!

Instead of patching, can we fix this and release an update?

I guess @MarshallOfSound is not maintaining this project or something.  Or just on a long holiday.  Or just hasn't gotten around to it yet?

What's the etiquette on poking a project maintainer?
(Also, updated app.asar worked for me. Thanks!)

I could PR this in for a fix, but ultimately it wouldn't get released until @MarshallOfSound creates the release, windows and mac builds are signed with his certs/keys.

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Thanks, that sorted this issue for me!!!

Also for what its worth. The asar is going to probably be system (windows,linux,mac) dependent. If you copy the ASAR posted here it will more than likely break things that weren't meant for your system to due the native modules not being loaded in that asar.

@tpetersen50 thanks!
app-asar.zip
Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Thankyou! Worked here as well.

Thanks for the patch! just in time for the holidays :-)

This is probably related to you possibly being on mac and loading a windows app.asar, or similar.

Definitely possible, I'm on Linux. I'll have a go figuring out how to edit it myself in the weekend if I get the chance.

Here's the fixed version I'm using for Linux. Caveat emptor, of course.
app_asar_amd64_deb.zip

Here's the fixed version I'm using for Linux. Caveat emptor, of course.
app_asar_amd64_deb.zip

fwiw, that works worse for me:
$ google-play-music-desktop-player
A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: _electron.app.requestSingleInstanceLock is not a function
    at /usr/share/google-play-music-desktop-player/resources/app.asar/build/index.js:81:31
    at Object.<anonymous> (/usr/share/google-play-music-desktop-player/resources/app.asar/build/index.js:225:3)
    at Object.<anonymous> (/usr/share/google-play-music-desktop-player/resources/app.asar/build/index.js:226:3)
    at Module._compile (module.js:642:30)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Object.<anonymous> (/usr/share/google-play-music-desktop-player/resources/electron.asar/browser/init.js:186:8)
    at Object.<anonymous> (/usr/share/google-play-music-desktop-player/resources/electron.asar/browser/init.js:188:3)

and the player window never opens.

OK, I found that on Ubuntu the asar snap lets you work with the archive, with that I was able to apply the changes and it works again, including media keys and settings option in the menu. Attached is my archive, for amd64:
app-debian-amd64.zip

fwiw, that works worse for me:

Strange, seems like the problem in electron/electron#14057. Could your installation be targeting a different Electron version?

@ddsol I hope you don't mind; I implemented your change in a branch and will PR it in pending another maintainer approves. At the very least people who use the CI builds can use it without the app.asar swaps.

Sorry folks I've been running a custom build for a few months that apparently doesn't have this issue 😄 Thanks to the solid work from folks in this thread and @jostrander the PR has landed and hopefully we can get something out to everyone this week.
Please note that anyone messing with their install files may not receive automated updates.

Fix available (for Windows, at least):
* Install [7zip](https://www.7-zip.org/) (at your own risk)

* Install [Asar7z](http://www.tc4shell.com/en/7zip/asar/) (at your own risk, it could have a large number of hairy viruses)

* Make sure GDMP is closed, exited and shut down

* Find your GDMP install (`C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources`)

* Make a backup copy of `app.asar` to `app.asar.backup` in the same folder

* Open `app.asar` with 7zip (open as archive)

* In 7zip, navigate to `build\renderer\windows\GPMWebView\`

* Drag `index.js` from there to your desktop or some folder

* Edit the file with an editor that can handle linux file endings (not Notepad, but you can use [Notepad++](https://notepad-plus-plus.org/) at your own risk)

* Change
  ```js
  function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

  global.isGPM = true;
  ```

  to
  ```js
  function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

  window.customElements.upgrade = window.customElements.upgrade || function(){};

  global.isGPM = true;
  ```

  (If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

* Save it or it's as if you did nothing

* Drag the `index.js` file back into 7zip into the same `GPMWebView` packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.

* Close 7zip

* Start your music player, it should work now

* Clean up the straggling `index.js` and if you're happy, confident and brave, your `app.asar.backup`. Also, clean your desk.

* Do this each time you want to run it.

* Just kidding, it'll work from now on.

Thank You
Should pin this in open issues ;)

Sorry folks I've been running a custom build for a few months that apparently doesn't have this issue  Thanks to the solid work from folks in this thread and @jostrander the PR has landed and hopefully we can get something out to everyone this week.
Please note that anyone messing with their install files may not receive automated updates.

Clarifying, does that include all builds including Linux?

While I HIGHLY recommend using the directions above and doing it yourself.  It's easy and works.
If for some reason you cannot modify the files, I have posted the modified index.js and fully modded app.asar here (mainly for my own convenience since I use this app on multiple computers):
https://github.com/DHOMD/google_music_desktop
It works for me, I offer no additional support or warranty ;)

While I HIGHLY recommend using the directions above and doing it yourself. It's easy and works.
If for some reason you cannot modify the files, I have posted the modified index.js and fully modded app.asar here (mainly for my own convenience since I use this app on multiple computers):
https://github.com/DHOMD/google_music_desktop
It works for me, I offer no additional support or warranty ;)

Works for me as well, thanks!

Shouldn't this remain open until the fix is actually released for visibility since it's affecting everyone? After wasting way too much time trying to figure out what was going on and fix it, I came and searched the issues here to see if other people were having a problem. I didn't see anything and almost opened a new issue before thinking to check the closed issues. Any reason we can't get a quick patch release?

Pinned the issue for visibility, I spoke with @MarshallOfSound and he's hoping to get a release out soon.

@jostrander, will the hoxfix mentioned above affect the updated release?

OK, I found that on Ubuntu the asar snap lets you work with the archive, with that I was able to apply the changes and it works again, including media keys and settings option in the menu. Attached is my archive, for amd64:
app-debian-amd64.zip

Can you explain what you did? I replaced my /usr/share/gpmdp/resources/app.asar with yours, but I still get stuck on loading Library.

Still having this issue. Not closed.

@epikMaowPhailure @TeaWithLucas  if you checkout the code and run yarn run make for your OS (yarn run make:deb:64 for 64 bit debian for example), the built version will work fine. Just mentioning in case you need a fix before the next release of GPMDP is put out

Fix available (for Windows, at least):

Install 7zip (at your own risk)

Install Asar7z (at your own risk, it could have a large number of hairy viruses)

Make sure GDMP is closed, exited and shut down

Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)

Make a backup copy of app.asar to app.asar.backup in the same folder

Open app.asar with 7zip (open as archive)

In 7zip, navigate to build\renderer\windows\GPMWebView\

Drag index.js from there to your desktop or some folder

Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++ at your own risk)

Change
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

to
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

(If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

Save it or it's as if you did nothing

Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.

Close 7zip

Start your music player, it should work now

Clean up the straggling index.js and if you're happy, confident and brave, your app.asar.backup. Also, clean your desk.

Do this each time you want to run it.

Just kidding, it'll work from now on.

Thank you, my man.  :)

Today I got this same problem. This is the log I get in dev mode:

Got the same issue today as well :
OS:
Windows 10 version 1903 build # 18362.476
GPMDP Version:
4.6.1

Same issue

I'm having this same issue.
MacOS 10.14.6

One more
MacOS 10.14.6 as well

Same, latest windows 10

Same issue MacOS 10.13.6

Working fine for me on Windows (7 & 10) after using the fix by ddsol.

FIXED INSTALLER: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/build/artifacts
I'm confused...
On Oct 28, this was fixed in the master branch
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/pull/3651
But it still does not work when installed form the main site (v4.6.1):
https://www.googleplaymusicdesktopplayer.com/#!
It works if downloaded from the latest Continuous-Integration build:
https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/build/artifacts
Why is the official site not including the fix, since it was merge in master (see #3651)?
Can we not close this thread?

4.6.1 was released last year and there hasn't been a release since.

Since this is now fixed, can you create a new release with the fix?  4.6.2?

Why on earth is there a whole year's worth of development on this app that isn't in the hands of users???

Just FYI. The ASAR file linked here just needs to be added to /Applications/Google Play Music Desktop Player/Contents/Resources and it fixes the issue on macOS. Take a backup of the old ASAR file first.
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3640#issuecomment-547554696

The problem with the solution posted here for those of us using snap packages is you can't modify them. The snap has to be updated and until that happens it's basically unusable. Please cut a release! @MarshallOfSound

Not all of your users are computer geeks. Most aren't. There's already a fixed package that doesn't rely on users copying files around and hacking zip archives...
Please cut a new official release?

For everyone who needs a fix and can't compile their own, here are links for the latest CI releases. I haven't confirmed all OSes except MacOS and Debian 64-bit, but the rest should also work.
Windows
MacOS
Debian (64-bit)
Debian
Red Hat (64-bit)
Red Hat
@jwarkentin @ramblingenzyme @GuyTechie

@rameezv Thanks for doing that! Unfortunately, that doesn't help with my snap package issue unless I want to replace it with a standard .deb package but hopefully that helps a lot of people. In the meantime, I have a difficult and painful but functional way to get it working for myself :-\

For what it's worth I believe I merged in a patch from @RAOF that should create an automatic build on launchpad for the edge channel if you want to give that a shot.

The edge channel should indeed contain a build with this fix. (Among other goodies).
I've not noticed any problems; perhaps I should also promote it to stable, although I was going to wait for a release to do that.
At least, it works for me 😀

@RAOF

The edge channel should indeed contain a build with this fix. (Among other goodies).
I've not noticed any problems; perhaps I should also promote it to stable, although I was going to wait for a release to do that.
At least, it works for me

I just updated to edge and it still doesn't work. It says edge was released on 9/13/2019 but the fix wasn't committed until 10/28/2019.

Edge channel snap package now works for me -- looks like the snap was updated today.

Thanks @rameezv for the release links. The MacOS build worked for me.

I had the 4.1 installer from when I first installed the program, so I uninstalled the newest version and installed from 4.1. That does seem to work without issue, so I think this is an issue related to 4.6+

@Rdstrmfblynch79 Thank you for that. The Version 4.1.1 works just fine for now on Windows10 v.1903

This is happening again for me, 4.6.1, Windows 10.

4.6.1 from the releases tab or website or from a link somewhere in one of these threads? If you are using the builds from the website those are still broken.

4.6.1 from the releases tab or website or from a link somewhere in one of these threads? If you are using the builds from the website those are still broken.

Tried every version I could. Website, releases tab and even chocolate, same result.

@felipezacani None of those sources are the fixed one. for Windows, try this as per my earlier comment

@rameezv Just chiming in that I experienced the reported issue and the 4.6.1 alpha resolved it for me.  Thanks for the quick resolve!

Maybe I should clarify that I mean the version you linked since it appears that 4.6.1 is ambiguous here.

Has Samuel Attard @MarshallOfSound stepped down from this project now? Is he the only one with access to update the website? I'd be happy to help with updating the download links if he doesn't get time to do so himself these days - I'm no coder but it can't be that hard, right?

Has Samuel Attard @MarshallOfSound stepped down from this project now? Is he the only one with access to update the website? I'd be happy to help with updating the download links if he doesn't get time to do so himself these days - I'm no coder but it can't be that hard, right?

I am not sure how active he still is. Might be worth pinging him on Twitter.
What we really need is a new release, the current one is not usable for a lot of people.
4.6.1 is about 18 months old now.

Just installed last version from this post and nothing changed except for now player stucks not at "Loading music library" but at this:
[url=https://i.imgur.com/bE3riMO.jpg][img]http://i.imgur.com/bE3riMOm.jpg[/img][/url]
Windows 7 x64 on work PC (now).
Will try at home on home PC.

Having the same issue as well!

@rameezv Thanks for 4.6.1 Alpha, that is working for me on Windows 10. I have not tried Mac yet - will have to compile??

@mtuma5672  Nope! Here's the link for MacOS

Been using this program for a year. Just decided to stop working today, stuck at "Loading Music Library". Uninstalled. Solved my problem. Not using app anymore.

@sydsilverwolf what a supremely unproductive comment

Just installed last version from this post and nothing changed except for now player stucks not at "Loading music library" but at this - https://i.imgur.com/bE3riMO.jpg
Windows 7 x64 on work PC (now).
Will try at home on home PC with Windows 10 x64. Upd: all is fine at home with this version.

This version still doesn't work on Windows 7 x64. Additionally checked index.js in \app.asar\build\renderer\windows\GPMWebView to ensure if window.customElements.upgrade = window.customElements.upgrade || function(){}; not present there. But this code is there.

Fix available (for Windows, at least):

Install 7zip (at your own risk)

Install Asar7z (at your own risk, it could have a large number of hairy viruses)

Make sure GDMP is closed, exited and shut down

Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)

Make a backup copy of app.asar to app.asar.backup in the same folder

Open app.asar with 7zip (open as archive)

In 7zip, navigate to build\renderer\windows\GPMWebView\

Drag index.js from there to your desktop or some folder

Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++ at your own risk)

Change
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

to
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

(If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

Save it or it's as if you did nothing

Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.

Close 7zip

Start your music player, it should work now

Clean up the straggling index.js and if you're happy, confident and brave, your app.asar.backup. Also, clean your desk.

Do this each time you want to run it.

Just kidding, it'll work from now on.

@ddsol, I've tried this on Mac (Catalina) and can happily say it works here too. So thanks a bunch!
Addendum for Mac users: follow these steps:

to unpack and repack the app.asar install npm (comes bundled with NodeJS): https://nodejs.org/dist/v12.13.1/node-v12.13.1.pkg
install asar:
npm install -g asar (-g installs it globally, so you can use it anywhere, this also helps keep the GPMDP directory structure free from additional clutter)
navigate to the proper directory:
cd /Applications/Google\ Play\ Music\ Desktop\ Player.app/Contents/Resources/
backup the original app.asar:
cp app.asar app.asar.backup
unpack the app.asar:
asar extract app.asar source_code (you can replace the source_code with whatever you like, just remember this for later)
change the above-mentioned file (again, thanks @ddsol)
repack the source code:
asar pack source_code app.asar (if chosen another name than source_code in step 5, use it here again, this will also override the existing app.asar)
verify everything works
remove the backup:
rm -rf app.asar.backup

Fix available (for Windows, at least):

Install 7zip (at your own risk)

Install Asar7z (at your own risk, it could have a large number of hairy viruses)

Make sure GDMP is closed, exited and shut down

Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)

Make a backup copy of app.asar to app.asar.backup in the same folder

Open app.asar with 7zip (open as archive)

In 7zip, navigate to build\renderer\windows\GPMWebView\

Drag index.js from there to your desktop or some folder

Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++ at your own risk)

Change
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

to
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

(If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

Save it or it's as if you did nothing

Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.

Close 7zip

Start your music player, it should work now

Clean up the straggling index.js and if you're happy, confident and brave, your app.asar.backup. Also, clean your desk.

Do this each time you want to run it.

Just kidding, it'll work from now on.

The same issue. Ubuntu 18

For everyone who needs a fix and can't compile their own, here are links for the latest CI releases. I've only been able to confirm it works on MacOS and Debian 64-bit, but the rest should also work.
Windows

This version fixed the issue for me as well, by the way - thanks @rameezv :)

@rameezv Thanks man, your comment saved me from lots of boring stuff :)

Debian (64-bit)

This package works for me on Arch Linux, for rebuilding the AUR gpmdp package.

For what it's worth, I'm running Version 4.6.1 (4.6.1) on macOS. It was working fine until I hit CMD-R. Now I'm stuck at the "Loading Music Library" screen.

@mtuma5672 Nope! Here's the link for MacOS

Thanks! Worked for me on the latest version of Catalina.

For everyone who needs a fix and can't compile their own, here are links for the latest CI releases. I've only been able to confirm it works on MacOS and Debian 64-bit, but the rest should also work.
Windows
MacOS
Debian (64-bit)
Debian
Red Hat (64-bit)
Red Hat
@jwarkentin @ramblingenzyme @GuyTechie

Windows version works fine on Windows 10, 1909. Thank you

I had the issue on windows 10 and this version worked.

For everyone who needs a fix and can't compile their own, here are links for the latest CI releases. I've only been able to confirm it works on MacOS and Debian 64-bit, but the rest should also work.
Windows
MacOS
Debian (64-bit)
Debian
Red Hat (64-bit)
Red Hat
@jwarkentin @ramblingenzyme @GuyTechie

Worked for me on Mac. Thanks!
I wonder wether will they be available on normal download channels.
Regards,

I literally created a github account so i could come in and comment, the new version fixed it and now i can get back to illustration jobs ;P can't do drawy jobs without music!!

Is there a non hacky fix for this going out anytime soon?

@hisuwh no hacks in this solution: https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3640#issuecomment-562376367 just use the installer link from here. Simple!

Thanks.  That was in the hidden items.  How come there hasn't been a proper release published since July 2018?
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/releases

@hisuwh
@MarshallOfSound seems like he's been pretty busy for the last year. He did mention that a release is coming soon but in the meantime the CI builds are available.

On Ubuntu 18.04, I was unsuccessful in getting the CI build to work. At first I just downloaded and installed, but then uninstalled and reinstalled. No joy.
Thankfully, just switching to DEV MOVE solved the problem for me. Just took a few seconds and now I'm jamming again for the first time in a while. Thanks @jostrander!

@mtuma5672 Nope! Here's the link for MacOS

Thanks Rameez! This totes fixed my issue. :D

@smelnyk-va no prob, and fancy running into you here! Hope you're well!

Windows

Working on W7Pro 64. Made a GitHub account just to say Thank You to @rameezv for this.

@rameezv Haha no kidding! Things have been great! I hope things have been well for you as well!

Thanks so much for the updated CI packages. This fixes the player for me in Fedora 31, coming from the broken Flatpak package.
Not sure if 4.6.1 is globally affected (my friend's MacOS version ran into this issue weeks before mine) but I hope maintainers can get a hotfix or new release pushed out soon.

Please, for the love of God, make a new proper release!

this is "Closed" because the solution is to download an exe from some random website? What?

@JonnoN it's not a random website, it's the automated continuous build that is generated when code is merged into the master branch. You can access it from the README.md. The issue is closed because the code to fix it has been merged.

@JonnoN it's not a random website, it's the automated continuous build that is generated when code is merged into the master branch. You can access it from the README.md. The issue is closed because the code to fix it has been merged.

Ok, and the rest of the planet who doesn't go through the Readme and the Github issues comments,  they will continue to download a broken version from the official channels. I agree, this issue should be closed, we have a solution, but please, don't ignore the need for a proper, new release.

@Bllacky I understand that, and if I had the ability to make a release, I would. But until @MarshallOfSound makes a release the CI links are the best solution.

How do we get at the latest CI builds (e.g., for mac) without having someone post magic links here?

@jgspratt On the homepage of this project, there are badges for the builds near the top of the readme.
Click the MacOS/Linux badge, then click the last successful build marked "gather artifacts".
For me at least, I don't see any "artifacts" tab, so append the URL with #artifacts/containers/0 and you should get a list of the generated artifacts, MacOS being Darwin.
For Windows, you can click the AppVeyor badge, and I do see an artifacts tab there to download.

Great thanks.  That worked.  I got https://3751-40008106-gh.circle-artifacts.com/0/home/circleci/project/dist/installers/darwin/Google Play Music Desktop Player.zip as my latest.

Fix available (for Windows, at least):
...

Change
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

to
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

Worked for me in OS X (using npx asar to extract and repack the file)
All the thank yous.


Items in GE are not locked

all items are available

Hey there, this issue has been fixed for the new release. To temporarily solve it while waiting for the update you can simply restart your client.