fix: Icons Alignment

Description
The icons are not properly vertically aligned with the text in the button,
One of the most important UI Principles is Alignment, So without that Principle it seems, it is lacking something.
Screenshots

Additional information
No response

Which browser is this happening in?

Which browser is this happening in?

I think this is in all the browsers 🤔

Which browser is this happening in?

I think this is in all the browsers 🤔

I ask because I'm not seeing it on my browser.

The icon is not centred like the text. There is no inconsistency between the icons (they all are at the bottom). I think the vertical alignment of the icons comparing with the text is inconsistent

Which browser is this happening in?

The Mozilla Web Developer Edition Browser.

The icon is not centred like the text. There is no inconsistency between the icons (they all are at the bottom). I think the vertical alignment of the icons comparing with the text is inconsistent

Exactly.

I’m not seeing this issue in either chrome or safari. I can check others later.

I’m not seeing this issue in either chrome or safari. I can check others later.

Nowadays Cross-browser compatibility is an essential part.

Of course, just trying to narrow down the problem first

I have checked in chrome, brave, firefox and edge. Doesn't seem to occur in any of these.

I have checked in chrome, brave, firefox and edge. Doesn't seem to occur in any of these.

Oh, but still for me its vertical alignment is not equal.

I have checked in chrome, brave, firefox and edge. Doesn't seem to occur in any of these.

Of course, just trying to narrow down the problem first

While I am hovering on it, the vertical alignment is really visible for me.

Firefox : -

Chrome: -

Brave:-

edge:-

Firefox : -
Chrome: -
Brave:-
edge:-

Oh, I don't why the vertical alignment is not proper for me.
Maybe It depends on the OS I am using or the Browser I am using otherwise my screen height.

Firefox : -
Chrome: -
Brave:-
edge:-

Oh, I don't why the vertical alignment is not proper for me. Maybe It depends on the OS I am using or the Browser I am using otherwise my screen height.

Might be. what browser and OS you are using?

Firefox : -
Chrome: -
Brave:-
edge:-

Oh, I don't why the vertical alignment is not proper for me. Maybe It depends on the OS I am using or the Browser I am using otherwise my screen height.

Might be. what browser and OS you are using?

OS: Ubuntu 20.04
Browser: Mozilla Firefox Developer Edition

If this is only happening on Mozilla Dev browser I don't think we should focus on it for now. The dev browser probably has some beta or experimental features which is affecting it which doesn't exist in any other browser and may not end up in production on the normal mozilla browser either.

Can this issue be closed for the same?

If this is only happening on Mozilla Dev browser I don't think we should focus on it for now. The dev browser probably has some beta or experimental features which is affecting it which doesn't exist in any other browser and may not end up in production on the normal mozilla browser either.

Totally Agree with that 💯


use AZURE_ASSERT in storage code

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage

/check-enforcer reset

/azp run cpp - storage

Use AZURE_ASSERT() instead of AZURE_ASSERT_MSG

What's the problem with AZURE_ASSERT_MSG. I think it's good

/azp run cpp - storage

Use AZURE_ASSERT() instead of AZURE_ASSERT_MSG

What's the problem with AZURE_ASSERT_MSG. I think it's good.
If it's not for internal or public use, you could've defined it in .cpp file.

I am not sure if I can move it to cpp.  It is the implementation of UNREACHABLE_CODE,


Add snappy compression to redis

This will reduce the footprint for redis by more than 50% according to benchmarks.

Thrift serializer has also been changed from Binary to Compact

love it except for the stats. if we want, we can start a microbenchmark around compression time, otherwise, I'd leave it out.

Will this break backwards-compatibility for clients that send traces that are not snappy-encoded?

Yes, it does. Same as the cassandra change a few commits ago which removed snappy compression on the client side

PS this merged after a minor version increment


Single File Component locale messages management

This would help who are waiting for SFC  translations :) Here is the link: https://f.github.io/vue-i18n-translator
A quick dirty work, if you find bugs please inform :)


Investigate automated method generation

As it stands, txwrapper methods are hardcoded and take a lot of boiler plate. This design was initially chose in order to create the easiest possible experience for library users as having the method arguments + documentation hard coded was hypothesized to make users experience easier.
An alternative to hardcoding would be having some dynamic generation.
Some ideas:

Create JSON file with necessary info for methods and read in the info at runtime
Create a script that scrapes metadata and spits out TS bindings code, something similar to polkadot-types-from-chain script that generates interfaces such as: https://github.com/AcalaNetwork/acala.js/blob/master/packages/types/src/interfaces/augment-api-tx.ts
Have a script that generates code for the methods based on metadata.

I think the main considerations is that the solution should 1) not degrade runtime performance 2) should not break the existing API and 3) it should be very easy for new users navigate
cc @TarikGul

I like this idea a lot. I think it would take some careful planning/designing but I think this could be a potential upgrade for sure.

I like this idea a lot. I think it would take some careful planning/designing but I think this could be a potential upgrade for sure.


Low FPS performance with Atomic Bomberman

I have trouble running Atomic Bomberman with cnc-ddraw (v<IP_ADDRESS> and Win7x64). I know it's not mentioned anywhere, but the game has the same type of ddraw issue as C&C, Carmaggeddon and others.
When I apply the cnc-ddraw .dll to the gamefolder and start the game it looks perfect at first. All colors are working as intended again.
But while playing the game i noticed several lags and low framerates. I checked the FPS with bandicam while running it with opengl/d3d renderer and I only got 12-18 FPS while playing. it is a fast paced game and these low-fps are breaking the gameplay. I tried all possible options in the ddraw.ini file but whatever I chose (renderer, maxfps, maxframerate etc.) there is no change in low-fps.
I also have a virtual machine running windows XP with Atomic Bomberman. When I play it there, the game performance is overwhelming good, it runs with something like >200fps (estimated), so the gameplay is lightning fast and smooth.
What causes the issues on AB? is it a general win7-10 problem or a ddraw.dll emulation problem that the perfomance is so low?

There should be no difference in performance on win 7, it probably runs even faster there than on your VM.  The only thing that can cause problems on newer versions of windows are the compatibility modes, make sure you got all of them disabled when using cnc-ddraw.

@FunkyFr3sh thanks for looking into this issue.
I just had a little time to check the new release and settings. I'm not done yet, but it looks like the maxgameticks is the key for a better performance.
on my core i7 win7x64 setup I found maxgameticks = 60 as too slow. 0 (infinite) however is working even slower. I got best result with maxgameticks from 2500 to 5000.
However these results are still not perfect. Compared to the Atomic Bomberman instance on Windows XP running on VirtualBox, it is still low-fps and lagging frequently.
If I had to choose I would still play it on the VM, because it runs lightning fast and without lags, which is a bummer in multiplayer games.
I also noticed: in the VM at the main menu of the game, the bomb-icon is pulsating at an insane speed, just like it used to be in the late 90s when the PC got more powerfull than in the mid-90s when the game was released.
when I start the game on win7 with ddraw.dll the icon at the main menu is pulsating very slowly, regardless of the maxgameticks setting.
I think it needs some further investigation to get things running perfect.

Oh, you can't actually use such high values (it will just set itself to 0 if you try that). Valid values are 1-999 for maxgameticks.
For me it works fine with anything between 60-500, above that it will start to run slow again. I actually been playing the game for 1 hour the other day (it's pretty fun!) and I didn't had any problems with 60. (Using Win10 x64 on a i5)
The bomb animates very fast for me with maxgameticks 0, I'm just having these random slow downs during the gameplay. I guess you might have another problem on top that I can't reproduce :( I could maybe try to set up a win 7 VM and hope I get the problem too since it doesn't seem to happen on win 10.
Do you happen to have a win7 vm and tested it in there?

Here is how it looks for me on win 10 x64 (1803):
With maxgameticks = 0:
https://drive.google.com/file/d/1oJbcMDbXU1z59pKQWC9Rc2xVrIGdKfX8/view
A lot of frame drops, goes down to as low as 20 FPS
With maxgameticks = 60:
https://drive.google.com/file/d/1IX8d-Xo3Ug6KPLEjwaHYKM8-a2g-u1Cj/view
Very stable, seems to have no issues from what I can see
Note: I enabled the cnc-ddraw FPS overlay, pay attention to the FPS counter in the top left

Ok, I found the reason and the final solution
The reason is Microsoft really f*cked it up with the, in MS Vista introduced, Game Explorer (GameUX.dll) which incorporates update checking and game information. Notice: This wasn't available in WinXP. and probably isn't available on win8/10 anymore (i don't know), so if it's not available the issue here probably won't even exist!
Lots of games from that time share the same issue (like the original version of Half-Life, Tomb Raider 4, etc.)
please read this thread to see the details and amount of f*ckup MS did with it's game explorer:
https://answers.microsoft.com/en-us/windows/forum/windows_other-gaming/windows-7-game-explorer-interfering-with-game/efd39c74-cfab-4c2c-b6c5-834b8849a1b3
So what happens when I start the game (bm95.exe) on Windows 7? The instant the game is launched, rundll32.exe is spawned with the GameUX.dll and constantly polls the dns, network and domain functions in the OS. rundll32.exe then constantly takes about 12%+ CPU load but the actual game is not launched. So beside huge CPU load, nothing happens, the game process is frozen.
But if you start the game a second time, the game suddenly loads - without any Win98 compatibility layers applied. However, due to the rundll32.exe cpu-load the game runs actually with really poor performance.
Now, how to run Atomic Bomberman on Windows 7 so that it runs smooth and perfect like on Windows XP back in the days?

Install Atomic Bomberman (Full installation)
copy the cnc-ddraw .dll to the game folder to fix the color problems
do not start the game directly with bm95.exe and don't use any compatibility options.
either get rid of game explorer (see link above) or my personal solution: create a batch file (.bat) which starts the game twice and then kills rundll32.exe:

bm95-start.bat
@echo off

start bm95.exe
timeout 5
start bm95.exe
timeout5
taskkill /F /IM rundll32.exe

start the game with bm95-start.bat

that way rundll32.exe doesn't steal any cpu-load and ddraw.dll fixes bombermans color problems. Works perfectly on Win7.

that's right, probably it would have worked with internet connection, but how silly is that from MS that a game won't start due to game explorer if you're offline.. i have no words for this behaviour..
I don't know, I don't even have a bm.exe.. just the bm95.exe. Maybe you've got a more recent game version, because I installed it right from the CD-ROM from the year 1996 or 1997.
next step: trying to get network game starting. It should actually work with this guide:
https://www.oldpcgaming.net/how-to-play-ipx-spx-games-over-lan/ :)
happy gaming :D


Add otelhttp handler in tracing library

Add otelhttp handler to the tracing library.
Originally posted by @ustiugov in https://github.com/ease-lab/vhive-xdt/pull/7#discussion_r669862451

closing, as we migrated tracing to the vSwarm repo


[Backend] Introduce isApproved flag under questions and answers model

Description
Currently, anyone can ask any questions and it will directly appear on the website, there should be a flag isApproved which will be set false by default with any post of questions and answers and only after admin approves, it should be set to true.
Expectation

[ ] Introduce the isApproved flag in both questions and answer model.
[ ] The getAnswers api should expect a query param of isapproved(it should be treated as false, if not provided), it its value is provided and is true it should only return the approved answers, else it should return all the answers.

https://github.com/HITK-TECH-Community/Community-Website/tree/main/backend/app/routes/Q%26A

There is status already present in the schema so this won't be required


Balance indicators unviable with multiple sessions

The on-screen indication of balances at the charts is obsolete now that there are multiple sessions and layers available at the same time.

If you use them with only one Simulation Layer on they work as expected.

They will be moved to the Designer as an improvement.


Chore: remove type conversion overhead and math lib

Too much type conversion going on.

Thanks for making this simpler..


++keep on everything

hover_doc allows ++keep to be passed to keep hover window in the top right hand corner, this would be great if I could do this for every single command that issues a popup.

I will think about this.


implement node start and stop commads

:tada: This issue has been resolved in version 0.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Questions about how to choose a suitable lambda in this paper

Hi, I use stg to solve my own problem about cell type classification. I find that the probability here are not closed to 0 or 1, like:

The prob value is very large, even if I choose very small lambda. Is choosing lambda related to the complexity of our problem? Thanks a lot.

If you increase the lambda value, the regularization for the gates becomes stronger, which leads to better results in general for feature selection.
If you decrease a lambda, the regularization for the gates becomes weak, so the gate values are less likely to converge.
Having said that, if the signal-to-noise ratio is low (e.g. real world data), feature selection becomes harder even with this method, and you might not be able to see clear separation like 0 or 1.


#42: ApplicationError.stackTrace() is now optional

@rultor merge

@rultor merge

@gilraenburland OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@gilraenburland Done! FYI, the full log is here (took me 2min)


marimo extern

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
163

Relevant Lines:
163

💛  - Coveralls


added jasmine hook for spec started, and improved start/finish/durati…

…on reporting

Any chance this will be merged soon? I'm currently seeing output like this in the testresults xml.
duration="NaN:NaN:NaN.NaN0000" startTime="2017-07-28T17:33:08.9170000-05:00" endTime="NaN-NaN-NaNTNaN:NaN:NaN.NaN0000-NaN:NaN"
It looks like this PR would fix the problem.

@afterbangx I've merged and published the latest version to npm. Feel free to create an issue if you still encounter the issue with the new version.
I'll take a look at the timing in karma-tfs-reporter. Feel free to create an issue in that repository, possibly include your TFS version. It seems like they're being reported correctly in VSTS, but I just need to look more into it.

(I increased the running times here to see if durations were indeed being reported.)
@JamesBlack001 thank you for your PR!


Expose contract errors

I had come across this problem when extending cw721 contract, ContractError is not exported.
Should export this all contracts like in cw20-base/lib.rs.

Closed by https://github.com/CosmWasm/cosmwasm-plus/pull/293


Improve cmake: make unit tests link against the brpc shared library ...

... so that we don't build a world of huge binaries that are forced to take every single piece of object files from those object library targets.
Test binaries down size from somewhat 6GB to around 600M. Linking is also vastly speeded up.

Hi, the cxxflags used in shared_lib and test are different, please make sure that UTs generated by cmake can be passed. They are broken in my local environment. Since UTs are not run in cmake environment, so travis looks fine.

Ah, I see you require that some different cxxflags be used to compile non-test code for your unit tests to properly function.
Personally I feel that this might not be a good choice since you are testing a piece of object that is different than what you actually ship with make install. Which means that you did not test what you ship.
But anyway I'll try to fix this and make it work for now.

UT may turn on additional debugging macros to check consistencies and would like the release build being unaffected. Creating different (and probably incompatible) binaries is the only solution.

If creating binaries that have different logic and behave differently for UT cannot be avoided then perhaps we should build a separate brpc shared or static library for testing instead of using object libraries directly for binaries.
And still, the unability to test release library make me a little nervious :)
Maybe we can solve this by separate tests that depend on these UT specific behaviours to different test binaries, link those against the specially built UT library, and run other normal tests against our release lib?

The logic in UT and release is not strict different but has a relation of Inclusion. It means that if UT is passed, then we can be sure that the code in release is correct. For example, in http2, in order to test the code work expectedly after stream id runs out, we start it at a very big number so that after only a short time, we can test whether the code is correct or not.

Then you need to make sure this relation of inclusion is always true by writing good tests always. Might be a burden upon ut writers? But if you guys are confident with that then maybe its OK.

So I for now give up on these tests that relies on non-test objects built with specific cxxflags and instead only change those who do not to directly link against the release library.
Test binaries downsized to 1.2G instead of 600M but its still a big improvement.
As a byproduct, ctest now works correctly and users can now make test and run various ctest commands with CMake builds.

Again travis doesn't look right. The error is about run_tests.sh not finding [[, which I did not touch.
Would anyone please take a look?

Same error after rebasing, ./run_tests.sh: 22: ./run_tests.sh: [[: not found
Took a look around and it seems that master branch is currently failing for the same reason. @jamesge

Looks good now


ci: configure semantic-release

Configure semantic-release to create new releases automatically.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Request] Distinguish between build vs language service diagnostics

This is a request to support additional squiggle colors/styles, to more clearly distinguish between build related and language-service related errors/warning. Perhaps add separate BuildError and BuildWarning values to DiagnosticSeverity?
We routinely receive feedback from users of the C/C++ extension complaining about needing to build their project in order for stale squiggles to be refreshed. The C/C++ extension does not refresh language-service diagnostics when builds occurs.  Users appear to be confusing problem-matcher results and DiagnosticCollection's from build extensions, with language service results.

We have DiagnosticTag which would be a good candidate for this

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


(GH-1997) Add tests for JSON schemas

This adds tests to ensure that the config options hashes include
:type and :description keys, which are required to correctly
generate Bolt's JSON schemas.
It also includes a workflow for generating the JSON schemas and
checking if there were any changes from the schemas that were committed.
If there are changes, the workflow fails and notifies the user that they
should run the schemas:all Rake task and commit the changes.
Closes #1997
!no-release-note

CLA signed by all contributors.


why the img tag is not closed?

the image tag in result of gethtml is

this html tag is not closed, just like
In the file 'rich_editor.js', the Insert image function looks no problem.
RE.insertImage = function(url, alt) {
    var html = '';
    RE.insertHTML(html);
}

这确实是个bug


a11y: handle left/right scrolls correctly

... with awesome code-change to test ration :)

Looks like the test failure is exposing a real bug in our semantics algorithm, which I'll have to investigate before landing this.

Should we close this PR in the meantime?

Fix for the test failure is in https://github.com/flutter/flutter/pull/11544.


adding performance optimisation: reusing comparision function

Technically this is slightly different behaviour for the comparison function. Previously isEqual was called like:
isEqual(oldArg, newArg).
However, this optimised version now calls it in the reverse order:
isEqual(newArg, oldArg).
The reversal was required in order to pull the .every function up so it could be reused.
While the order of arguments to the isEqual function is different - I do not think it is a "breaking change". The equality function was never advertised a particular order of params. The idea of it is to allow custom equality functions such as deepEqual functions to compare to values. However, some people may have been relying on the specific order of the params in their functions. I could be convinced to do a major version bump if people think that is appropriate. However, given the low usage of this library at this stage I suspect that this use case does not exist at present.
As part of this PR I have updated the type of the EqualityFn type to clearly call out the order of the params so that it is clearer.
type EqualityFn = (newArg: any, lastArg: any) => boolean

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          15     15
=====================================
  Hits           15     15

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8673269...190b460. Read the comment docs.

After some discussion I am leaning toward the opinion that equality functions should be commutative

involving the condition that a group of quantities connected by operators gives the same result whatever the order of the quantities involved, e.g. a × b = b × a.
-wikipedia

Based on this understanding I am okay to make this change without a major version bump. Additionally - i am now unsure whether calling out the order of the arguments to the equality function in the type definition is a good idea. I am leaning towards no and calling out that it is commutative.

I will merge this as a patch version change on the safe thought that equality function should be commutative.


Fix "InputElement doesn't receive PointerEntered call when created under mouse pointer"

What does the pull request do?
Previously when the element was detached from the logical tree we have captured its parent element. It will mean that all next events would be sent only for this object until MouseUp wouldn't be triggered which will cause Capture to be re-set to null and all next mouse events will try to find the correct element.
"Fixed" behaviour:

Fixed issues
Fixes #7858

You can test this PR using the following package version. 0.10.999-cibuild0019476-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

I tested and the OnPointerEntered seems to be called properly now.
Since we are here. I noticed, that on WPF OnPointerMoved is also called under similar circumstances right after OnPointerEntered, but it isn't on Avalonia. Not sure which way is correct.

I'm pretty sure that this change can break tons of existing controls, even custom-styled buttons (e. g. when button changes its template parts based on :pressed state


[WIP] Initialize all members with in-class field initializers

IMPORTANT: This is a WIP and should not be merged as is, it breaks the build and likely does some bogus initializations.
These changes are the result of applying clang-tidy's cppcoreguidelines-pro-type-member-init check to the codebase, with the aim to have all our class fields properly initialized to sane defaults (0, false, nullptr).
clang-tidy made a huge mess of the codebase so I had to fix quite a few things manually, such as:
--- a/core/variant/variant.h
+++ b/core/variant/variant.h
@@ -204,7 +204,7 @@ private:
                PackedArrayRefBase *packed_array;
                void *_ptr; //generic pointer
                uint8_t _mem[sizeof(ObjData) > (sizeof(real_t) * 4) ? sizeof(ObjData) : (sizeof(real_t) * 4)];
-       } _data alignas(8);
+       } _data{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{}{} alignas(8);

        void reference(const Variant &p_variant);

--- a/core/math/color.h
+++ b/core/math/color.h
@@ -37,10 +37,10 @@
 struct Color {
        union {
                struct {
-                       float r;
-                       float g;
-                       float b;
-                       float a;
+                       float r = 0.0F = 0.0F = 0.0F = 0.0F;
+                       float g = 0.0F = 0.0F = 0.0F = 0.0F;
+                       float b = 0.0F = 0.0F = 0.0F = 0.0F;
+                       float a = 0.0F = 0.0F;
                };
                float components[4] = { 0, 0, 0, 1.0 };
        };

It also seems to be completely clueless around unions and introduces bugs by initializing members with incompatible values... So there's a lot of post-processing work needed to make this mess actually useful, to the point that it might not be useful at all as a starting point... But let's review some of the changes and see if they can be salvaged or redone manually.

cppcoreguidelines-prefer-member-initializer - may be added also, but it will be available in llvm 13
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-prefer-member-initializer.html

I split the core changes to #47748 and did further fixes there. Let's focus on core first, decide what to do for unions, etc., and the apply the same logic to the rest of the codebase.


How do I NPM link to this built project?

This isn't explained in the project's readmes anywhere, so...
Could someone please explain how I use "npm link" to link between an angular UI I have using material2, and this project?  I have tried cloning this project, running "gulp material:build-release" in the material2 project, then cd into dist/releases/material, running "npm link", then doing "npm link @angular/material" in my UI project.  When I try to "ng serve" my UI, I get tons of errors saying that it can't find "cdk" related modules.
BTW, I am able to simply copy the content of that dist/releases/material/* into my node_modules/@angular/material folder and that works fine.  I can also explicitly point my package.json to the path like so:
"@angular/material": "file:/Users/cseibert/Workspace/flexion/material2/dist/releases/material",
but for whatever reason, npm link fails.

@codyseibert Do you mean npm install @angular/material?
Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.…


Installation can't see cert - FileNotFoundException

Hi guys,
I try to install RGBMaster but it can found the certificate :
Installing rgbmaster certificate.....
Import-Certificate : Le fichier de certificat est introuvable.
Au caractère D:\Telechargements\RGBMaster_2_4_0\RGBMasterWap_<IP_ADDRESS>_Test\SignA
ndInstallApp.ps1:7 : 1
+ Import-Certificate -FilePath "RGBMasterWap_<IP_ADDRESS>_x64.cer" -CertStor ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Import-Certificate], FileNotF
   oundException
    + FullyQualifiedErrorId : System.IO.FileNotFoundException,Microsoft.Certif
   icateServices.Commands.ImportCertificateCommand

I checked, I got RGBMasterWap_<IP_ADDRESS>_x64.cer on my D:\Telechargements\RGBMaster_2_4_0\RGBMasterWap_<IP_ADDRESS>_Test folder.
I also checked this cert and it seems expired on july.
Any clue to install it ? There is a new version maybe ?

Hey, you are correct. This is a duplicate of #47 so I'd like you to follow that issue and close this one so it's easier to track what's going on

Fixed with !53


Update no-p2 and no-p3 regions.

Issue #, if available:
Description of changes:
Make regional release tests work for the new regions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Select sheets

Tempted to make controls a param.Parameterized class.

Superseded by https://github.com/holoviz/lumen/pull/654


Change payload type of SequencerSpecific messages

from String to List Int

Sounds good to me. I'd suggest:
type alias Byte = Int
Then using List Byte instead so the intention is more clear. That's what I've been doing in my generate code.

OK - good suggestion.  and use this for SysEx, SequencerSpecific and Unspecified?

Yeah, I think we should use it anywhere where we're representing bytes with ints. If you look at my https://github.com/rhofour/elm-comidi/blob/generate/src/Midi/Types.elm you'll see I've added a bunch of other type aliases to make things more clear.

Fixed via c26e51b981a7193b2b329a1d70de398dbc1cd29b.


Transactions should be broadcasted to all knew nodes

We need to broadcast transactions to all knew nodes to got them validated faster.

Fixed in https://github.com/ucoin-io/cutecoin/commit/1de513fa8938e746df7c1b2531c77f83e2a80ac6


Trick Attack Icon dont show appropriately

image
I checked the job.js, the path of the icon and the icon himself is ok, yet I cant see whats wrong why is no showing the icon

Let me know if you are still having problems getting this working.

Sorry for late feedback.
And yes, the mentioned option was the problem. Thanks for your support!


Fix #1407

Make it clearer that a CODEOWNERS file follows most, but not all, gitignore syntax rules to fix #1407

Why:
Fix #1407

What's being changed:
see diff
Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@ajs256 Thanks so much for opening a PR! I'll get this triaged for review 🌟

bump

Thanks for the update @ajs256! I'll get this re-triaged.


Reinherit tags

DESC

flexible VS static tags

TODOs

[x] add to view generation?

resolved in meeting from 19.07 / flexible tags are not required any longer


testing/nand_sim: Adds a virtual NAND Flash device

Adds NAND Flash device in simulator
Fixes echo in terminal for Vi
Summary

Adds a NAND Flash virtual device for the simulator.
Removes echo of commands in vi (especially during movement), and double echo of characters in command line in vi due to the same reason.

Impact

NAND flash compatible file systems can test using this.
Makes vi more usable

Testing

Basic file system operations after mounting using littlefs.
checkpatch.sh (An error that nxstyle gives, which looks to be a genuine error, is /nuttxspace/apps/testing/nand_sim/nand_sim_main.c:103:44: error: Multiple data definitions which might be in this issue).

@xiaoxiang781216 @resyfer why the CI is failing? Should Saurav rebase it to force the CI to pass?

@acassis Hi! Sorry for the late reply. I've done a force push.
What I don't understand is this line from the error (and subsequent lines similar to it):
/github/workspace/sources/apps/testing/nand_sim/Kconfig:34: 'endif' in different file than 'if'

I have them:
6  | config TESTING_NAND_SIM
...
12 | if TESTING_NAND_SIM
...
34 | endif

I had tried force pushing earlier after rebasing, but it still showed this CI error.

@acassis @xiaoxiang781216 Hi, can you please approve this PR for CI testing? Thank you!

Hi @resyfer sorry I missed your message. I don't look nuttx-apps so often as I do for nuttx kernel. I hope now it works fine

Hi @acassis no worries! Thanks for the approval. It also looks like the CI tests have completed finally.

Thank you for the review!


Don't allow selection if no sample is plotted.

It doesn't really make sense to select part of the plot if there's no data plotted. We should probably just not create a selection at all if the plot has no data.

Addressed in https://github.com/damellis/sensors/commit/d4c60b1338a2c554a04eb2fafdc9cb1dfdeab797


development environment for Hub 2 generation

@msp1974 thanks in advance for our help
I am using both hub firs generation and second generation.
I want to help our community by updating the API with the new features.
So  I use my development environment like last year, and I try to install the aioWiserHeatAPI
(venv) christian@christian-VirtualBox:~/development$ git clone https://github.com/msp1974/aioWiserHeatAPI.git
Clonage dans 'aioWiserHeatAPI'...
remote: Enumerating objects: 541, done.
remote: Counting objects: 100% (189/189), done.
remote: Compressing objects: 100% (118/118), done.
remote: Total 541 (delta 131), reused 119 (delta 69), pack-reused 352
Réception d'objets: 100% (541/541), 129.15 Kio | 3.31 Mio/s, fait.
Résolution des deltas: 100% (364/364), fait.
(venv) christian@christian-VirtualBox:~/development$ cd ~/development/core
(venv) christian@christian-VirtualBox:~/development/core$ source venv/bin/activate
(venv) christian@christian-VirtualBox:~/development/core$ cd ~/development/aioWiserHeatAPI
(venv) christian@christian-VirtualBox:~/development/aioWiserHeatAPI$ pip install -e .
Obtaining file:///home/christian/development/aioWiserHeatAPI
Preparing metadata (setup.py) ... done
Collecting zeroconf>=0.47.1 (from aioWiserHeatAPI==1.3.4)
Using cached zeroconf-0.66.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.3 MB)
Requirement already satisfied: aiohttp>=3.8.1 in /home/christian/development/core/venv/lib/python3.9/site-packages (from aioWiserHeatAPI==1.3.4) (3.8.1)
Collecting aiofiles>=0.8.0 (from aioWiserHeatAPI==1.3.4)
Using cached aiofiles-23.1.0-py3-none-any.whl (14 kB)
Requirement already satisfied: pyyaml>=6.0 in /home/christian/development/core/venv/lib/python3.9/site-packages (from aioWiserHeatAPI==1.3.4) (6.0)
INFO: pip is looking at multiple versions of aiowiserheatapi to determine which version is compatible with other requirements. This could take a while.
ERROR: Package 'aiowiserheatapi' requires a different Python: 3.9.17 not in '>=3.10'
(venv) christian@christian-VirtualBox:~/development/aioWiserHeatAPI$

I Try to install python3.10 like python3.9, doing that I had to upgrade pip23.1.2 that is not compliant with my previous version of HA  so that it doesn't work anymore.so I try to downgrade to python3.9.

traces
christian@christian-VirtualBox:~$ cd ~/development/core
christian@christian-VirtualBox:~/development/core$ source venv/bin/activate
(venv) christian@christian-VirtualBox:~/development/core$ hass -c config
Traceback (most recent call last):
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 568, in _build_master
ws.require(requires)
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 886, in require
needed = self.resolve(parse_requirements(requirements))
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 777, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (pip 23.1.2 (/home/christian/development/core/venv/lib/python3.9/site-packages), Requirement.parse('pip<22.1,>=21.0'), {'homeassistant'})
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/christian/development/core/venv/bin/hass", line 33, in
sys.exit(load_entry_point('homeassistant', 'console_scripts', 'hass')())
File "/home/christian/development/core/homeassistant/main.py", line 159, in main
args = get_arguments()
File "/home/christian/development/core/homeassistant/main.py", line 69, in get_arguments
from . import config as config_util
File "/home/christian/development/core/homeassistant/config.py", line 19, in
from . import auth
File "/home/christian/development/core/homeassistant/auth/init.py", line 19, in
from .mfa_modules import MultiFactorAuthModule, auth_mfa_module_from_config
File "/home/christian/development/core/homeassistant/auth/mfa_modules/init.py", line 12, in
from homeassistant import data_entry_flow, requirements
File "/home/christian/development/core/homeassistant/requirements.py", line 14, in
from .util import package as pkg_util
File "/home/christian/development/core/homeassistant/util/package.py", line 13, in
import pkg_resources
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 3243, in
def _initialize_master_working_set():
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 3226, in _call_aside
f(*args, **kwargs)
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 3255, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 570, in _build_master
return cls._build_from_requirements(requires)
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 583, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/home/christian/development/core/venv/lib/python3.9/site-packages/pkg_resources/init.py", line 772, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pip<22.1,>=21.0' distribution was not found and is required by homeassistant

@msp1974 , thank you in advance for any advice and guideline to facilitate future validation work.

OK, you shouldn't need to upgrade pip for the api.  But it does look like you have an out of date HA install.  I would recommend updating this first.
Firstly, get python 3.10 in your venv.

In development/core delete the venv folder
Then recreate your venv with (in your development/core folder)

cd /home/christian/development/core
sudo rm -r venv
python3.10 -m venv venv

This assumes you have python 3.10 installed on your machine
Update HA to the latest version

In development/core do

source venv/bin/activate
git pull upstream master
./script/setup

Note: when doing a git pull, if it complains that it can't do it because you have uncommited changes, then stash all changes with
 git stash

And then do the pull again.
Get the aioWiserHeatAPI and get HA to use it

As you have already cloned the repo, just install into HA while in your HA venv

pip install -e /home/christina/developement/aioWiserHeatAPI

Note: this is the same as changing the directory to aioWiserHeatAPI and doing a pip install -e .

Make sure you have the integration correctly setup
When I am developing, I like to have the integration in its own folder and then symlink it into HA.  Just find easier to manage.

Clone integration repo in same way as aioWiserHeatAPI repo
Symlink it into custom_components
Note:  If you have installed via HACs, then delete the folder /home/christian/development/core/config/custom_components/wiser

cd /home/christian/development
git clone https://github.com/asantaga/wiserHomeAssistantPlatform.git
cd core/config/custom_components
ln -s /home/christian/development/wiserHomeAssistantPlatform/custom_components/wiser wiser

You should then be able to run HA with

hass -c config

This should all work as intended but let me know if you get any problems.

Thanks a lot Mark
Now I can work


Updated the rent fees documentation for clarity.

Preview is available here:http://soroban-docs-pr596.previews.kube001.services.stellar-ops.com/


PP-4819 web payments activation as digital wallets

What
functionality to enable and disable digital wallets (apple pay & google pay)
How
Note, that this functionality is only available if you have:

A username and password set
Your payment provider is 'worldpay'
In order to test this locally you can change your account in connector to meet this requirements e.g.

update gateway_accounts set payment_provider = 'worldpay' where id = 10;
update gateway_accounts set credentials = '{"username":"foo","password":"bar"}' WHERE id = 10;

Then the new functionality should be visible at /card-types/summary

(➕ I think the git history for this PR could be rebased/ cleaned up to reflect the significant changes)


Added dghe to list

Added dghe to list

Added dghe to list

@ketanrajpal Please provide us with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you!

@ketanrajpal You might miss my previous comment. Please react.

@ketanrajpal I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


A 3bot name of a failed deployment is not reusable

Description
When creating a 3bot and the deployment fails, the name chosen first is not reusable.
I suggest to initiate the identity first with a short time to live and it is confirmed by the 3bot itself.

Description
When creating a 3bot and the deployment fails, the name chosen first is not reusable.
I suggest to initiate the identity first with a short time to live and it is confirmed by the 3bot itself.

I'm not sure I'm familiar with a short-living identity, 3bot needs an identity that is used to sign the workloads e.g the network, the pools for the 3bot to own them, and there's no ownership transfer of workloads nor pools. so having that identity is definitely needed.
I think it's a different bug, the record of that solution of the USER_THREEBOT model should have been deleted if you're facing that situation and not able to use the same name for the failing deployment

'm not sure I'm familiar with a short-living identity

That does not exist yet. Of course we can delete the identity if the process fails but if something unforeseen happens we end up in the same situation.

'm not sure I'm familiar with a short-living identity

That does not exist yet. Of course we can delete the identity if the process fails but if something unforeseen happens we end up in the same situation.

We can't delete identities from the explorer https://github.com/threefoldtech/tfexplorer/blob/master/pkg/phonebook/user.go

reopening since it the problem is not solved, putting it on the later milestone

I was creating a new 3bot with name "ramez" via https://deploy3bot.testnet.grid.tf
and it failed with this screenshot

now when I try to refresh and create again
it says that there is a 3bot with name "ramez" already exists and I cant use the same name again !!

And nothing shown in 3bot list


Prevent data inheritance on sub-list creation

When I'm pressing tab the new list element inherits the parent list data, so If im having custom style like:
"list-style-type: circle" and start="10" the child list will have same data as parent!
Is there any way to prevent that behaviour?

Maybe this should come as an option. It seemed to be a safe assumption to copy the parent list's style data. But it might be wrong for other data indeed.


Add test reports

Add a test report stage to the ICI. This should get a summary of our tests to the status page and show failed tests in PRs directly. Also, with this we will get statistics about flaky tests (if there are).

This still requires some work regarding making posts into PRs and job error output possible... Will postpone this for now.


can you fix the bugs in webui?

sorry for the late reply. we will update the code of webui soon

fixed, please refer to commit f0e6e9c


 On rviz2 I can see the published pointcloud2 and laserscan topics but when I view the pointcloud2 using the defined frame_id, I got a weird 10-sided-stars-like structure. Is this normal? I cannot recignize any object from the pointcloud.

Thanks for reporting. The rviz-screenshot does not look normal. It might be related to the high data rate of a 24 layer scanner. Do you use the latest sick_scan_xd release?
A record of the lidar data would be helpful for further analyzation. Can you provide recorded TCP-data from the lidar using Wireshark? If possible, please:

start Wireshark,
select the interface with the tcp-session to the lidar,
start sick_generic_caller as before
record the tcp data, and
save it to a pcapng-file.

Please provide us with the pcapng-file for further diagnosis.

Yes. I use the actual sick_scan_xd from master branch.
I don't know if this is relevant but the 24 layers are somehow divided.
All 24 layers are supposed to be in the -60 to 60 degree angle but somehow layer 1,2,3, 6,7,8, 11,12,13, 16,17,18, 21,22 are in the correct angle but the rest are in the 120 to 240 degree angle. Which is why, it looks like a 10 sided stars.
In the google drive, you could find the rosbag recording as well as the wireshark recording
https://drive.google.com/drive/folders/1MSi96aN0wOCP-1iYc4aaskpuAasHqKp4?usp=sharing

Thank you very much for the rosbag and pcapng-file! This will help a lot. I will have a closer look on this strange behaviour.

Sorry, my fault! The elevation table has not been set correctly due to an error. The bug was introduced by version 2.7.0 (multiscan136 integration on 27 Jun 2022) and affects only MRS6124.
Thanks to your input, the bug is now fixed. I hope the following rviz-screenshot from your pcapng-file looks more familiar:

Please checkout branch https://github.com/SICKAG/sick_scan_xd/tree/feature/mrs6124-fix and rebuild sick_scan_xd. Please leave a short message about problems or sucess, so that the branch can be merged into the master trunk. Thanks again for your input!

Thank you very much for your quick response! I've tested it and it works fine now. I'll close this issue now.

@ngifary Thanks for your friendly support!


Using UserEnviromentVariables to set the folder Path

Now we can set a UserEnviromentVariable to move .config/workspacer folder.

Change looks pretty harmless to me, and I'm OK with the implementation as is.
But you may want to document it? Try to find somewhere in the docs and add it there too? :)

I'll do my best

Thanks for the patch. Consider it merged!


ir: Make the id local to the context.

@bors-servo r+

:pushpin: Commit 45cae56 has been approved by Manishearth

@bors-servo r=Manishearth

Fixed the doc build.

:pushpin: Commit 74465b7 has been approved by Manishearth

:hourglass: Testing commit 74465b7 with merge 6e78bb8...

:sunny: Test successful - status-travis


Add 'return-error-limit' option to limit the number of returned matched lines\log entries

Pull Request Checklist
Is this in reference to an existing issue?
#28
General

[x] Update Changelog following the conventions laid out on Keep A Changelog

[ ] Update README with any necessary configuration snippets

[ ] Binstubs are created if needed

[x] RuboCop passes

[x] Existing tests pass

New Plugins

[ ] Tests

[ ] Add the plugin to the README

[ ] Does it have a complete header as outlined here

Purpose
limit the number of returned matched lines\log entries.
Known Compatibility Issues

regarding testing just running the command locally and capturing the input and output in a gist is enough, something like this: https://github.com/sensu-plugins/sensu-plugins-elasticsearch/pull/16

@jhshadi any plans to pick this back up?

closing due to inactivity

@majormoses sorry for the long absent, can you reopen the pull request?

@majormoses accidentally reverted the change and then apply it back. sorry for the hustle :)
in any case run the command with the --return-error-limit feature:
Shlomis-MBP:sensu-plugins-logs shlomi$ ./bin/check-log.rb --log-file test/logs/example_01.log --state-dir ./test/logs/state --pattern error --crit 1 --return-error-limit 1 --return
CheckLog CRITICAL: 0 warnings, 2 criticals for pattern error.
this is error line

tried adding unit tests using the reference you linked above but couldn't make them run properly. will try adding those later on.
LMK if there's anything else is needed.

@majormoses any other changes needed here?

sorry thought I got back to this one. Let me review and will report back shortly.

released: https://rubygems.org/gems/sensu-plugins-logs/versions/1.3.0


Configure VLAN for host OS

[Enter feedback here]
Creating one or many VLAN enabled virtual switch/es does not seem to give host OS access to use those for network communication. The part that says "All traffic that goes through the physical network adapter connected to the virtual switch will be tagged with the VLAN ID you set." make it seem like also the host can utilize this.
Either I'm unaware of a way to connect host OS to these vNICs (is there a way?), or the text might need some clarification.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96413472-06ea-691c-23df-b3cf6160e939
Version Independent ID: daead0d8-ef43-d60d-1d55-9d97d693ed12
Content: Configure virtual local area networks for Hyper-V
Content Source: WindowsServerDocs/virtualization/hyper-v/deploy/configure-virtual-local-areal-networks-for-Hyper-V.md
Service: na
Product: windows-server-threshold
Technology: compute-hyper-v
GitHub Login: @KBDAzure
Microsoft Alias: kathydav

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Laws broken using your system

Hello,
The following site is being used for terrorism and the authorities are asking if you could kindly take it down:
output j5bin com / l i x u s o
Call with any questions:<PHONE_NUMBER>
Thank you.

You didn't include a country code with your phone number.
None the less, it's down.

Thank you.

I assume you removed the bin url? (which is fine, though it doesn't exist and it's not cached anywhere), but you left your number on the bin...do you want to remove that too?

Yes - I removed the bin url.  The URL was cached by search engines.  Eventually it will be re-crawled and cleared out.  I'll remove the phone number as well.  Thanks for the help.


Use Paper's new dependencies format

Original work to get Paper Plugins support added: #30
From PaperMC announcements:

Click here to read the announcement

2023-06-07, PaperMC discord #dev-announcements
Dependency Format Update
Dependency declaration has been update for paper plugins to better represent the different lifecycles in Paper plugins.
Note, the previous format is scheduled for removal in 1.21.
Most noteably with this new format is that specifying load order is now relative to the dependency rather than the plugin as a whole.
So for example, marking a dependency with load: BEFORE will now cause the dependency to load BEFORE your plugin.
Before
load-before:
  - name: RequiredPlugin
    bootstrap: false
load-after:
  - name: RegistryPlugin
    bootstrap: true
  - name: OtherPlugin
    bootstrap: false
dependencies:
  - name: OtherPlugin
    required: false
    bootstrap: false
  - name: RegistryPlugin
    required: true
    bootstrap: true

After
dependencies:
  bootstrap:
    # Lets say that RegistryPlugin has some registry elements that this plugin requires.
    # We don't need this during runtime, so it's not required in the server section. However
    # can be added to both if needed
    RegistryPlugin:
      load: BEFORE
      required: true
      # (this is default)
      join-classpath: true
  server:
    # Add a required "RequiredPlugin" dependency, which will load AFTER your plugin.
    RequiredPlugin:
      load: AFTER
      required: true
      # This means that this plugin won't have access to classpath
      join-classpath: false
    # Add "OtherPlugin" dependency, which will load BEFORE your plugin. WILL join classpath (by default)
    OtherPlugin:
      load: BEFORE
      required: false
      join-classpath: true
    # Load order can be omitted to cause it to be ignored... or specified by load-order: OMIT
    SpecialDependency:
      required: true
      join-classpath: true

I've implemented this new format in plugin-yml. Here is the syntax:
kotlin
paper {
    [...]
    bootstrapDependencies {
        // Required dependency during bootstrap
        register("WorldEdit")

        // During bootstrap, load BeforePlugin's bootstrap code before ours
        register("BeforePlugin") {
            required = false
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
        }
        // During bootstrap, load AfterPlugin's bootstrap code after ours
        register("AfterPlugin") {
            required = false
            load = PaperPluginDescription.RelativeLoadOrder.AFTER
        }
    }

    serverDependencies {
        // During server run time, require LuckPerms, add it to the classpath, and load it before us
        register("LuckPerms") {
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
        }

        // During server run time, require WorldEdit, add it to the classpath, and load it before us
        register("WorldEdit") {
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
        }

        // Optional dependency, add it to classpath if it is available
        register("ProtocolLib") {
            required = false
        }

        // During server run time, optionally depend on Essentials but do not add it to the classpath
        register("Essentials") {
            required = false
            joinClasspath = false
        }
    }
}

groovy
paper {
    [...]
    bootstrapDependencies {
        // Required dependency during bootstrap
        'WorldEdit' {}

        // During bootstrap, load BeforePlugin's bootstrap code before ours
        'BeforePlugin' {
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
            required = false
            joinClasspath = false
        }
        // During bootstrap, load AfterPlugin's bootstrap code after ours
        'AfterPlugin' {
            load = PaperPluginDescription.RelativeLoadOrder.AFTER
            required = false
            joinClasspath = false
        }
    }

    serverDependencies {
        // During server run time, require LuckPerms, add it to the classpath, and load it before us
        'LuckPerms' {
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
        }

        // During server run time, require WorldEdit, add it to the classpath, and load it before us
        'WorldEdit' {
            load = PaperPluginDescription.RelativeLoadOrder.BEFORE
        }

        // Optional dependency, add it to classpath if it is available
        'ProtocolLib' {
            required = false
        }

        // During server run time, optionally depend on Essentials but do not add it to the classpath
        'Essentials' {
            required = false
            joinClasspath = false
        }
    }
}

One other option is to have it nested the same way it is in the .yml file:
paper {
    dependencies {
        bootstrap {

        }
        server {

        }
    }
}

But I found the serverDependencies and bootstrapDependencies option to be nicer, less pointless indentation. Most people will never even need bootstrap dependencies, so it makes sense to keep it clean.
Anyways, I also edited the README to change the examples to specify Java as the project programming language, as this is required for these examples to actually compile.

By the way, this is what the README example actually generates:
paper-libraries.json
{
  "repositories": {
    "MavenRepo": "https://repo.maven.apache.org/maven2/",
    "maven": "https://papermc.io/repo/repository/maven-public/"
  },
  "dependencies": [
    "com.google.code.gson:gson:2.10.1"
  ]
}

paper-plugin.yml
name: TestPlugin
version: unspecified
main: com.example.testplugin.TestPlugin
bootstrapper: com.example.testplugin.bootstrap.TestPluginBootstrap
loader: com.example.testplugin.loader.TestPluginLoader
load: STARTUP
authors:
- Notch
- Notch2
prefix: TEST
provides:
- TestPluginOldName
- TestPlug
permissions:
  testplugin.*:
    children:
      testplugin.test: true
  testplugin.test:
    description: Allows you to run the test command
    default: op
api-version: 1.19
defaultPerm: op
has-open-classloader: false
folia-supported: true
dependencies:
  server:
  - name: Essentials
    load: OMIT
    required: false
    joinClasspath: false
  - name: LuckPerms
    load: BEFORE
    required: true
    joinClasspath: true
  - name: ProtocolLib
    load: OMIT
    required: false
    joinClasspath: true
  - name: WorldEdit
    load: BEFORE
    required: true
    joinClasspath: true
  bootstrap:
  - name: AfterPlugin
    load: AFTER
    required: false
    joinClasspath: true
  - name: BeforePlugin
    load: BEFORE
    required: false
    joinClasspath: true
  - name: WorldEdit
    load: OMIT
    required: true
    joinClasspath: true

The default options for dependencies matches what PaperMC currently has as the defaults

FYI the kebab is also needed on the DependencyDefinition to generate join-classpath instead of joinClasspath: https://github.com/Minecrell/plugin-yml/commit/7adac57440036948f95609fd41916c70f8159325


Add initial Travis config.

As per subject.
This is for #2.
WIP.

Ok, I believe this works as well.
For now Travis installs libpoco-dev from ppa:gezakovacs/poco, which is version 1.7.6. We could switch to building from source if we'd prefer that.

Could I bother you for a review again @jontje?

Thanks again @jontje.


Update google-cloud-core dependency to <3

resolves #22208
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@Abacn

Looks like pypi correctly picked sub-latest google-cloud-pubsub 2.13.1 with this change. However, if removing the constraint of google-cloud-bigquery-storage pypi becomes crazy again. Would not be surprise if this problem came in again if another google-cloud-* gets updated

According to the release note of google-cloud-core 2.0.0, the breaking change is only dropping support for python 2.7. And tests passed. dependency owner for this is empty in OWNERSHIP/PYTHON_DEPENDENCY_OWNERS.yaml. Should be good to go if gcp integration tests passed.

beam_PostCommit_Python38

beam_PostCommit_Python37

Run Python Dataflow ValidatesRunner

Run Python Dataflow V2 ValidatesRunner

Run Python 3.7 PostCommit

Run Python 3.8 PostCommit

Run Python 3.9 PostCommit

Run Python 3.8 PostCommit

Let's:

also bump the upper bound for:

            'google-cloud-bigquery-storage>=2.6.3,<3',

make a clone of this PR where we additionally set the following lower bounds:

google-cloud-bigquery-storage>=2.14.0
google-cloud-core>=2

we won't submit the second PRs, but just use it as a due diligence to run integration tests in an environment where we forcefully update to the newer version of these dependencies during job submission as well as in worker containers.
Once the tests pass, we'll merge this PR and close the other one.
Thanks!

Let's:

also bump the upper bound for:

            'google-cloud-bigquery-storage>=2.6.3,<3',

make a clone of this PR where we additionally set the following lower bounds:

google-cloud-bigquery-storage>=2.14.0
google-cloud-core>=2

we won't submit the second PRs, but just use it as a due diligence to run integration tests in an environment where we forcefully update to the newer version of these dependencies during job submission as well as in worker containers.
Once the tests pass, we'll merge this PR and close the other one.
Thanks!

The second one won't pass: there is another burdle, see https://github.com/apache/beam/issues/22208#issuecomment-1181820708

Ok, let's proceed with incremental changes. I also spoke with google-cloud-core maintainers who agreed that the only major change there was dropping py2 support.


Problem in local vs. global batch sizes?

My current setup consists of 4 local V100s. I wanted to be able to take the advantage of distributed training and mixed-precision. The following is my ds_report:
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires one of the following commands '['llvm-config', 'llvm-config-9']', but it does not exist!
 [WARNING]  sparse_attn requires CUDA version 10.1+, does not currently support >=11 or <10.1
sparse_attn ............ [NO] ....... [NO]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
async_io ............... [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/home/jupyter/.local/lib/python3.7/site-packages/torch']
torch version .................... 1.7.1+cu110
torch cuda version ............... 11.0
nvcc version ..................... 11.0
deepspeed install path ........... ['/opt/conda/lib/python3.7/site-packages/deepspeed']
deepspeed info ................... 0.4.0+11e94e6, 11e94e6, master
deepspeed wheel compiled w. ...... torch 1.7, cuda 11.0

Referring to the official CIFAR10 example, I set my training and configuration up. The number of total training samples in my dataset is 33405 (consists of 256x256x1 grayscale images) and I am setting a batch size of 256. With this, the number of batches in each epoch is supposed to be 66 (taking the ceiling). But my training logs show otherwise -- 8352. Why is that?
I can't share the dataset yet but I am attaching my configuration and training script. Apologies in advance for the untidy training script.
Archive.zip

@sayakpaul, how are you setting the batch size? Can you share your command line and json config?

It's there in the archive, @tjruwase.

@sayakpaul, please note that it is a lot easier if debugging clues like command line, stdout, logs are shared directly (copy-paste) into the chat. Also, can you share output of ds_report?

You can see the ds_report in the issue description itself. Not really sure which parts I missed out on.

Yes, sorry, I saw the ds_report after asking.
I took a look at the archive, it contains your script and jscon config, but this is not sufficient to understand what is going on. In particular, it is not clear which part of your log is showing the unexpected global vs local batch sizes. Sometimes the training script and deepspeed may have conflicting views of batch sizes. Sharing your command line and log will be debug further. Thanks.


Node v4 Buffer does not accept objects

Addresses https://github.com/konitter/gulp-combine-media-queries/issues/19 where this module does not work with node v4.
cssJson is an object, and therefore cannot be turned into a Buffer in v4.

@konitter
If possible, I would like to know when this will be accepted, as I need it for a current project.
Thank you.

@konitter I can confirm that this issue exists for node 4 and that the suggested fix prevents the problem - be good to get the PR into the trunk... the fact that you don't make the buffer on this line doesn't seem important as you go on to set file.contents on line 350 and create a buffer for it there


wireshark - label update

Hello!
I was using Installomator to update Wireshark and kept receiving errors with either mounting or downloading the newest version. Thanks to some help from @meschwartz we identified that wireshark uses "curl -fs" by default. However, after changing this to "curl -fsL" it started working successfully again.
I thought I'd bring this up as I'm also testing App-Auto-Patch which is pulling from Installomator, and it doesn't like my Wireshark application because of this.
Very small change, hopefully, this helps others!
Thank you!
Error Encountered:
`Executing Policy Installomator - Wireshark
Running script Installomator - 10.5...
Script exit code: 2
Script result: 2024-01-31 19:30:36 : REQ   :  : shifting arguments for Jamf
2024-01-31 19:30:36 : REQ   : wireshark : ################## Start Installomator v. 10.5, date 2023-10-15
2024-01-31 19:30:36 : INFO  : wireshark : ################## Version: 10.5
2024-01-31 19:30:36 : INFO  : wireshark : ################## Date: 2023-10-15
2024-01-31 19:30:36 : INFO  : wireshark : ################## wireshark
-:6: parser error : Opening and ending tag mismatch: hr line 5 and body
</body>
       ^
-:7: parser error : Opening and ending tag mismatch: body line 3 and html
</html>
       ^
-:8: parser error : Premature end of data in tag html line 1

^
-:6: parser error : Opening and ending tag mismatch: hr line 5 and body
</body>
       ^
-:7: parser error : Opening and ending tag mismatch: body line 3 and html
</html>
       ^
-:8: parser error : Premature end of data in tag html line 1

^
2024-01-31 19:30:36 : INFO  : wireshark : setting variable from argument NOTIFY=silent
2024-01-31 19:30:37 : INFO  : wireshark : setting variable from argument BLOCKING_PROCESS_ACTION=ignore
2024-01-31 19:30:37 : INFO  : wireshark : BLOCKING_PROCESS_ACTION=ignore
2024-01-31 19:30:37 : INFO  : wireshark : NOTIFY=silent
2024-01-31 19:30:37 : INFO  : wireshark : LOGGING=INFO
2024-01-31 19:30:37 : INFO  : wireshark : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-01-31 19:30:37 : INFO  : wireshark : Label type: dmg
2024-01-31 19:30:37 : INFO  : wireshark : archiveName: Wireshark.dmg
2024-01-31 19:30:37 : INFO  : wireshark : no blocking processes defined, using Wireshark as default
2024-01-31 19:30:37 : INFO  : wireshark : App(s) found: /Applications/Wireshark.app
2024-01-31 19:30:37 : INFO  : wireshark : found app at /Applications/Wireshark.app, version 4.0.10, on versionKey CFBundleShortVersionString
2024-01-31 19:30:37 : INFO  : wireshark : appversion: 4.0.10
2024-01-31 19:30:37 : INFO  : wireshark : Latest version not specified.
2024-01-31 19:30:37 : REQ   : wireshark : Downloading https:%20Latest%20Arm%2064.dmg to Wireshark.dmg
2024-01-31 19:30:37 : ERROR : wireshark : error downloading https:%20Latest%20Arm%2064.dmg
ls: Wireshark.dmg: No such file or directory
2024-01-31 19:30:37 : ERROR : wireshark : File list:
2024-01-31 19:30:37 : ERROR : wireshark : File type: Wireshark.dmg: cannot open `Wireshark.dmg' (No such file or directory)
2024-01-31 19:30:37 : INFO  : wireshark : Installomator did not close any apps, so no need to reopen any apps.
2024-01-31 19:30:37 : ERROR : wireshark : ERROR: Error downloading https:%20Latest%20Arm%2064.dmg error:
* URL rejected: Port number was not a decimal number between 0 and 65535
* Closing connection
curl: (3) URL rejected: Port number was not a decimal number between 0 and 65535

2024-01-31 19:30:37 : REQ   : wireshark : ################## End Installomator, exit code 2
Error running script: return code was 2.`

Installomator Default
wireshark)
    name="Wireshark"
    type="dmg"
    appNewVersion=$(curl -fs "https://www.wireshark.org/update/0/Wireshark/4.0.0/macOS/x86-64/en-US/stable.xml" | xmllint --xpath '/rss/channel/item/enclosure/@url' - | head -1 | cut -d '"' -f 2)
    urlToParse=$(curl -fs "https://www.wireshark.org/update/0/Wireshark/4.0.0/macOS/x86-64/en-US/stable.xml" | xmllint --xpath '/rss/channel/item/enclosure/@url' - | head -1 | cut -d ':' -f 2 | cut -d '%' -f 1)
    if [[ $(arch) == i386 ]]; then
      downloadURL="https:$urlToParse%20Latest%20Intel%2064.dmg"
    elif [[ $(arch) == arm64 ]]; then
      downloadURL="https:$urlToParse%20Latest%20Arm%2064.dmg"
    fi
    expectedTeamID="7Z6EMTD2C6"

Identified Fix:
wireshark)
    name="Wireshark"
    type="dmg"
    appNewVersion=$(curl -fsL "https://www.wireshark.org/update/0/Wireshark/4.0.0/macOS/x86-64/en-US/stable.xml" | xmllint --xpath '/rss/channel/item/enclosure/@url' - | head -1 | cut -d '"' -f 2)
    urlToParse=$(curl -fsL"https://www.wireshark.org/update/0/Wireshark/4.0.0/macOS/x86-64/en-US/stable.xml" | xmllint --xpath '/rss/channel/item/enclosure/@url' - | head -1 | cut -d ':' -f 2 | cut -d '%' -f 1)
    if [[ $(arch) == i386 ]]; then
      downloadURL="https:$urlToParse%20Latest%20Intel%2064.dmg"
    elif [[ $(arch) == arm64 ]]; then
      downloadURL="https:$urlToParse%20Latest%20Arm%2064.dmg"
    fi
    expectedTeamID="7Z6EMTD2C6"

#1370


Make the GitHub token optional since it's not needed for public repos

The token's always available where this is invoked, but as a best practice we can avoid passing it around unless we actually need it (and we don't need it for public repos).
Also mark wait-interval as optional since it has a default value.

Amazing contrib, thank you! Hope it will allow to get some more tractions on public repos.

I will keep the new code in master (so you can already use it from a branch), and will do a proper release probably early next year


Fix Typings

Hi Sebastien
Problem
The Typescript community (especially typings) is moving fast and we have to keep up with the latest changes. Using typings 1.5.0 (previously 0.7.9) the ambientDependencies and ambientDevDependencies don't exist anymore and hence they are not getting installed when running typings install. ambient has been renamed to global in from version 0.x.x to 1.x.x. I ran into the problem because we always referenced the global typings module (e.g. in kickstart.sh) and hence it was using my newer global typings module instead of the one referenced in package.json.
Fix

Update typings to version 1.5.0 in pacakge.json
Rename ambientDevDependencies to globalDevDependencies or even globalDependencies (I am not entirely sure, but I guess when someone imports n3-line-chart as Typescript project, it should pull these dependencies automatically - hence they are dependencies and not devDependencies
Make sure to use ./node_modules/typings/dist/bin.js instead of typings to enforce the correct version of typings
Additionally: move the kickstart.sh commands into a npm postuninstall hook to do this automatically
Update the Wiki https://github.com/n3-charts/line-chart/wiki/Contribution

References

Issue describing the problem https://github.com/typings/typings/issues/343
Typings options in source code https://github.com/typings/typings/blob/master/src/bin-install.ts#L31

A better Solution
According to this Microsoft blogpost and the Angular 2 source code (there is no typings.json file), typings can now be pulled from the corresponding packages itself via npm using the @types namespace. We should definitely look into this.
Let me know your opinion on this, so I can fix this!
Best, Christoph

lodash typings exist in both ambientDevDependencies and devDependencies in typings.json

Alright, the master branch is just far behind :dagger: I saw you fixed all this in the work branch https://github.com/n3-charts/line-chart/blob/work/package.json Amazing!


pipenv install does not throw an error when a Pipfile.lock is determined to be corrupt

Issue description
pipenv install printed Pipfile.lock is corrupted; ignoring contents. to standard and displayed a success message.
Expected result
I expected pipenv install to throw an error.
Actual result
Creating a virtualenv for this project...
Pipfile: /app/Pipfile
Using /usr/local/bin/python (3.10.14) to create virtualenv...
created virtual environment CPython3.10.14.final.0-64 in 653ms
  creator CPython3Posix(dest=/root/.local/share/virtualenvs/app-4PlAip0Q, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/root/.local/share/virtualenv)
    added seed packages: pip==24.0, setuptools==69.1.0, wheel==0.42.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
✔ Successfully created virtual environment!
Virtualenv location: /root/.local/share/virtualenvs/app-4PlAip0Q
Pipfile.lock is corrupted; ignoring contents.
Installing dependencies from Pipfile.lock (86e0a8)...
Installing dependencies from Pipfile.lock (86e0a8)...
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

The message is technically visible in the logs, but it somewhat acts as a silently passing error. This allowed me to successfully build an application only to find that none of the dependencies were installed and nothing indicating an obvious error.
Steps to replicate

initialize a Pipenv environment
corrupt the Pipfile.lock (i.e. add a line of garbage input, alter formatting, etc.)
pipenv install

$ pipenv --support
Pipenv version: '2023.10.24'
Pipenv location: '/home/evan/.local/lib/python3.11/site-packages/pipenv'
Python location: '/bin/python3.11'
OS Name: 'posix'
User pip version: '23.3.1'
user Python installations found:
PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.11.8',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '<IP_ADDRESS>-microsoft-standard-WSL2',
 'platform_system': 'Linux',
 'platform_version': '#1 SMP Thu Mar 7 03:22:57 UTC 2024',
 'python_full_version': '3.11.8',
 'python_version': '3.11',
 'sys_platform': 'linux'}

System environment variables:

SHELL
PYENV_SHELL
WSL2_GUI_APPS_ENABLED
WSL_DISTRO_NAME
WT_SESSION
NAME
PWD
PYENV_VIRTUALENV_INIT
LOGNAME
HOME
LANG
WSL_INTEROP
LS_COLORS
WAYLAND_DISPLAY
LESSCLOSE
TERM
LESSOPEN
USER
DISPLAY
SHLVL
XDG_RUNTIME_DIR
PYENV_ROOT
WSLENV
XDG_DATA_DIRS
PATH
DBUS_SESSION_BUS_ADDRESS
HOSTTYPE
PULSE_SERVER
WT_PROFILE_ID
OLDPWD
_
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PYTHONFINDER_IGNORE_UNSUPPORTED

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /home/evan/.pyenv/versions/3.8.10/bin:/home/evan/.pyenv/shims:/home/evan/.ebcli-virtual-env/executables:/mnt/c/Users/Evan/AppData/Local/Programs/Microsoft VS Code/bin:/home/evan/.local/bin:/home/evan/.pyenv/plugins/pyenv-virtualenv/shims:/home/evan/.pyenv/bin:/home/evan/.cargo/bin:/bin:/user/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/usr/local/bin:/home/evan/.local/bin
SHELL: /bin/bash
LANG: C.UTF-8
PWD: /home/evan/[redacted]

I think that @oz123 's work on plette validation may fix this issue report once its released -- thoughts Oz?

Sorry to say this, but Plette does not do validation on the pipfile.lock.

@oz123 Do you know what that status of this is now that plette is removed?  Actually, I just checked and plette isn't removed, but I thought you had done work to remove it?

I rewrote palette to use data classes instead on Cerberus. In the process I added many tests and examples of valid and invalid Pipfiles.
Plette was always a validation \ spec library for Pipenv not Pipenv.lock.
But I guess it should do both.
@evanottinger if you still have the corrupt file I would be happy to look at it order to fix the issue. You can also share it privately if you don't want to post it.


build dynamic interface name map

fix #2328

@hellt I'm trying to get rid of these Funktions that sit somewhere that now need to have a notion of all the kinds that do exist... That's bad practice... You should delegate these calls to the kinds or make them register these informations in a register... But not these central functions see e.g. #1347 where by the way the interface name stuff was moved to the kinds... Maybe consider a refresh of that pr

good reminder. Done


Modernize Python (code review fixes)

Supplement to #1434

I think I don't really like the line wrapping (commit 9b45b2ac0318041ac69007be76354183d0f6461d, comment), but let's leave it as-is because it was made automatically with the preview set of black Python formatter rules, which may become the default later, and just not to touch the files again.

Note to self: tests in ninja dist fail. This is because of git ls-files usage inside scripts, while dist target runs tests in clean non-git directories.

I'll now go and do the same for Piper.


Don't put contrib and user source in the same directory

Because files could be overridden inadvertently.
(Same applies to other images)

@rhcarvalho do you mean .bashrc? If so, then I think I agree (if you have .bashrc in your source repository, then you loose the SCL enable and you will be broken. We should set the HOME directory to one level up and add the .bashrc there maybe.
@bparees ideas?

:+1: it's a leftover from the time when we had the ONBUILD actions defined in base image.

applies to more than python.

is there a reason this would be a problem to fix post-3.0?  if not, i suggest we do that.

@bparees i think I'm OK with fixing this post-3.0, but I don't see this as too much devel work.

@mfojtik I mean all of contrib/'s content, see this, which includes src/.bashrc and now also src/passwd.template.
@bparees yes, applies to all images. I wouldn't create one issue per image, and didn't create the issue in sti-base  because the is no copying there.

Trelloed, please close.

sti-* have already been changed before moving away from contrib/src to contrib/etc.


global: fix isort CLI args

@ntarocco https://github.com/inveniosoftware/invenio-app-rdm/pull/221/files#diff-513c9b6861fc981fb2c708db477f542cR13 this should fix the tests... it's related to https://github.com/inveniosoftware/pytest-invenio/pull/55
We might want to put in place an pseudo-RFC with instructions to fix this since is gonna hit almost every repo.

Coverage remained the same at 0.0% when pulling 06afa75477f23d7b0180213c1257b6ac39b45579 on ntarocco:fix-isort into 4084c5c321d51b87bc6b5e4ee3635363fb9a180e on inveniosoftware:master.

@ntarocco I guess this can be closed? Please reopen if still relevant


Incorrect Package urls in README

Hi, if you're still experiencing this issue, please feel free to reopen it with more context or create a new issue. Closing for now since it's been a very long time after this has been created. @samsonawu


Using generic rewrite-target annotation for ingress examples (#10272)

Fix for https://github.com/kubernetes/website/issues/10272

/assign @kbarnard10

cc @bprashanth

/approve

Need different fix - closing


Created xNetAdapterRsc

Pull Request (PR) description
Created Ressource xNetAdapterRsc for enablind or disabling Recv Segment Coalescing (RSC)
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[x] Examples appropriately updated?
[x] New/changed code adheres to [Style Guidelines]
[x] [Unit and (optional) Integration tests]

This change is

@atdhe18,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@atdhe18, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Codecov Report

Merging #261 into dev will decrease coverage by 3%.
The diff coverage is 12%.

@@         Coverage Diff         @@
##            dev   #261   +/-   ##
===================================
- Coverage    97%    93%   -4%
===================================
  Files        18     19    +1
  Lines      1383   1441   +58
===================================
+ Hits       1347   1354    +7
- Misses       36     87   +51

Hi @atdhe18 - really awesome to have your contribution! It looks like your tests are failing in AppVeyor though. Any chance you could have a look at this? We'll review once these are passing, although I won't be able to get to this till after the 7th of Sept (unless @tysonjhayes gets to it first :grin: )

Reviewed 2 of 10 files at r1, 1 of 2 files at r2, 6 of 12 files at r3.
Review status: 9 of 12 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 74 at r3 (raw file):

                "IPv4"   { $result.add('State', $netAdapter.IPv4Enabled) }
                "IPv6"   { $result.add('State', $netAdapter.IPv6Enabled) }
                Default {"Should not be called."}

nit: I'd change this to a comment so we don't actually return anything to the pipe.
Default {
    # nothing to see here move along
}

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 125 at r3 (raw file):

        ) -join '')

        $netAdapter = Get-NetAdapterRsc -Name $Name -ErrorAction Stop

We seem to be making an assumption that RSC is enabled for the network adapter. yet there is an enable-netadapterrsc, is that out of scope for this dsc module?

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 134 at r3 (raw file):

            ) -join '')

            if ($Protocol -eq "IPv4" -and $State -ne $netAdapter.IPv4Enabled)

Ignorant question here.
According to the examples we can set both IPv4 and IPv6 at the same time.
    Set-NetAdapterRsc –Name "MyAdapter"-IPv4Enabled $True -IPv6Enabled $True

So wouldn't we want to be able to do the same in DSC? If we change protocal to a string array we can just set true/false in a go.

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRss/MSFT_xNetAdapterRss.psm1, line 60 at r3 (raw file):

$result.add('State', $netAdapter.Enabled)

This could just be
return @{
  Name = $name
  State = $netAdapter.Enabled
}

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRss/en-US/MSFT_xNetAdapterRss.strings.psd1, line 9 at r3 (raw file):

    NetAdapterIsInDesiredStateMessage = Network adapter {0} {1} is in desired state {2}.
    NetAdapterApplyingChangesMessage = Network adapter {0} {1} was {2}, should be {3}, applying changes.
'@

Need a new line at the end of the file here.

Comments from Reviewable

Review status: 7 of 12 files reviewed at latest revision, 5 unresolved discussions.

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 74 at r3 (raw file):
Previously, tysonjhayes (Tyson J. Hayes) wrote…
nit: I'd change this to a comment so we don't actually return anything to the pipe.
Default {
    # nothing to see here move along
}

Done.

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 125 at r3 (raw file):
Previously, tysonjhayes (Tyson J. Hayes) wrote…
We seem to be making an assumption that RSC is enabled for the network adapter. yet there is an enable-netadapterrsc, is that out of scope for this dsc module?

I'm sorry i didn't understand what you mean

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRsc/MSFT_xNetAdapterRsc.psm1, line 134 at r3 (raw file):
Previously, tysonjhayes (Tyson J. Hayes) wrote…
Ignorant question here.
According to the examples we can set both IPv4 and IPv6 at the same time.
    Set-NetAdapterRsc –Name "MyAdapter"-IPv4Enabled $True -IPv6Enabled $True

So wouldn't we want to be able to do the same in DSC? If we change protocal to a string array we can just set true/false in a go.

I went after xNetAdapterLso , i thought that changing both would be better but did it like the other. For my Company i did that we could change both. So if you want to i can change it.

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRss/MSFT_xNetAdapterRss.psm1, line 60 at r3 (raw file):
Previously, tysonjhayes (Tyson J. Hayes) wrote…

$result.add('State', $netAdapter.Enabled)

This could just be
return @{
  Name = $name
  State = $netAdapter.Enabled
}

Changed it back , i had it like this but the Test had errors

Modules/xNetworking/DSCResources/MSFT_xNetAdapterRss/en-US/MSFT_xNetAdapterRss.strings.psd1, line 9 at r3 (raw file):
Previously, tysonjhayes (Tyson J. Hayes) wrote…
Need a new line at the end of the file here.

Done.

Comments from Reviewable

Can you close this Pull Request


Fixes #100 Cannot read property 'get' of undefined in lib/router.js

Brute force fix by adding null check for methodMap

cc @jeffposnick

Thanks Aditya!
It seems a little screwy that methodMaps should ever contain a null value in the first place, but coding defensively doesn't seem like a bad idea anyway.
I think the "real" bug is on L98, as that line means that the array passed to _match will always have one entry, even if there are no matching routes. I'll change that in a follow-up.

Thanks for the quick revert @wibblymat


Add all the views

We've got a bunch of loose components but nowhere structured to add them. We should add all our different pages as "views" - pretty much a component to hold other components.
A rough outline of the views needed:

[ ] Dashboard - Filterable/sortable list of jobs to click on, button to get to settings page, overview of job timeouts
[ ] Job page - Details about the job
[ ] Group page - Graphs of groups job timeouts
[ ] Topic page - Graphs of topics job timeouts
[ ] Settings page - Widgets to control alert settings

All of these views should replace the current routes in the React Router. As most of the components to be contained within these views don't exist yet, just leave a comment like <!-- <BarChart data="..." prop2="..." /> -->.

I can start on this in a few hours, but if someone wants to start it now or anything, just assign yourself the issue.

Closed with 753a9195c08e0ccf9e3f6e05b121f4035b832e3e


large data restore miss

good tool.
when I backup a 100000 records table, then restore it. the new table has only 99563.
I tried twice, always like that.
Any idea?

I've the same issue, trying to fix the problem by myself on code.
Do you managed to achieve this in another way?
Thanks


Release

I am currently packaging various Chirpstack components in Nixpkgs (https://github.com/NixOS/nixpkgs/pull/298209).
But the FUOTA server is no released released version? Could you maybe tag a new release? Thanks :)

Okay, there are in fact some tagged versions. But only test versions like [v3.0.0-test.4](https://github.com/chirpstack/chirpstack-fuota-server/releases/tag/v3.0.0-test.4) which are from 2021.
Could we tag a more recent commit?
/cc @brocaar


[BUG]: Llama Sharp LLamaEmbedder Chunking

Description
I am using the following code to generate embeddings from very large documents, of-course each document's tokens can exceed the maximum context of selected model and therefore document's tokens should be splitted in chunks and for each chunk get an embedding, then in the end get the average embedding.
string param_model_path = Parameters.model_embedding_local_path; //USED FOR CUSTOM MODEL PATH

var parameters = new ModelParams(param_model_path)
{
    ContextSize = param_model_embedding_global_maxtokens, // The longest length of chat as memory.
    GpuLayerCount = 0, // How many layers to offload to GPU. Please adjust it according to your GPU memory.
    Embeddings = true, //Embeding Size cannot change as it is fixed due to the llm embedding layer.
    VocabOnly = false, //Needs more memory based on input tokens based on ContextSize
    PoolingType = LLama.Native.LLamaPoolingType.Mean,
    BatchSize = 1024,
    UBatchSize = 1024
};

LLamaWeights weights = LLamaWeights.LoadFromFile(parameters);
model_llama = new LLamaEmbedder(weights, parameters);

IQueryable contents_lama = _dbContext.Contents.Where(x => types.Contains(x.content_type));
foreach (Shared.Models.Database.Content content_lama in contents_lama)
{
    float[]? text_embedding = model_llama.GetEmbeddings(content_lama.content_document, cancellationToken).Result.Single();
    content_lama.content_embedding = FloatToDouble(text_embedding);
    content_lama.content_timestamp_emd = DateTime.Now;
    _dbContext.Entry(content_lama).State = EntityState.Modified;
}

_dbContext.SaveChanges();

I have tested the above with multiple settings for BatchSize and UBatchSize (like 512 or 2048) but I always get the following error:

One or more errors occurred. (Input contains more tokens than configured batch size (Parameter 'batch'))'

Then I even tried to create my own token chunking method and average calculator which works perfectly with Azure Open AI ADA model and I incoporated this also with usage of lama sharp but still the same error occured even chunk was les than 512 tokens.
I tested the following language models:

Phi-3.5-mini-instruct-Q6_K_L.gguf
Meta-Llama-3-8B-Instruct.Q3_K_L.gguf

I tested using the following LlamaSharp versions:
-0.19.0
-0.18.0
Notice in another github issue (https://github.com/SciSharp/LLamaSharp/issues/921) there is a guy (martindevans) who mentions that "embedder can't split input into multiple batches at the moment"
So LLamaEmbedder and LLama.Native.LLamaPoolingType.Mean is not supposed to do chunking and average?
Reproduction Steps
Try to simply embed a small text like "This is a test"
Then try to embed a lage test like a document using the batch and mean parameters
Environment & Configuration

Operating system: Windows and Linux
.NET runtime version: .NET 8
LLamaSharp version: 0.19.0
CUDA version (if you are using cuda backend): None
CPU & GPU device: Lenovo ThinkPad Laptop

Known Workarounds
No response

The embedder does not currently do any chunking of large documents - it simply takes all of the content you feed it and processes it in one go. It's up to you to ensure that's small enough to fit within the configured BatchSize.
LLama.Native.LLamaPoolingType.Mean will do a mean average of the embeddings within that batch.

Regarding this statement:

LLama.Native.LLamaPoolingType.Mean will do a mean average of the embeddings within that batch.

I assume that I can set the UBatchSize to the context size of the selected model, and the BatchSize to a bigger size than the UBatchSize. So if I have a custom chunkint mechanism with a fixed token count split smaller than BatchSize, it should work.
But based on this github issue (https://github.com/SciSharp/LLamaSharp/issues/921) BatchSize cannot be different than UBatchSize

@params.UBatchSize != @params.BatchSize

UBatchSize to the context size of the selected model, and the BatchSize to a bigger size than the UBatchSize

UBatchSize doesn't really have anything to do with the context size of the model, instead it is simply setting how much work the GPU will do at once. So if you have e.g. BatchSize=100, UBatchSize=20 you can't possibly submit more than 100 tokens (that's the max batch size), if you submit 100 then the GPU will internally process it in 100/20 = 5 chunks.
However, this isn't relevant to embedding models because of:
if (@params.UBatchSize != @params.BatchSize)
    throw new ArgumentException("For non-causal models, batch size must be equal to ubatch size", nameof(@params));

The UBatch mechanism doesn't support non-causal models, all the work must be processed at once. That restriction is simply copied from llama.cpp here.

So if I have a custom chunking mechanism with a fixed token count split smaller than BatchSize, it should work.

This sounds right to me.
I think you should be able to:

Tokenize document
Split into chunks <= BatchSize
Embed each chunk (this produces one vector per chunk)
Take mean average of all chunk embedding vectors (element-wise sum vectors, divide by number of chunks)

So I am curious what batch is exacly doing?
Why I have to make chunking and then then lamasharp will do another "batching"?

Batching is a fairly low-level implementation detail which makes processing large amounts of data more efficient.
For example If you want the model to process a large prompt before generating some text, it's more efficient to process that prompt in a single large batch than to process it one. token. at. a. time.
Alternatively if you're generating multiple different sequences all at once (e.g. 100 parallel conversations) rather than processing each conversation at once, you can process all 100 at simultaneously in a batch.
BatchSize sets how many tokens you can submit to the model at once, and how many results can be returned. If BatchSize is 100 you can't submit more than 100 tokens at once, and you can't generate more than 100 tokens at once. It's usually fine to make this larger (it costs some memory to hold the larger batch).
However, the GPU can't always handle a whole batch. UBatchSize sets how much work is actually submitted to the GPU at once - a batch of work is split up into small batches and processed, then all of the results are returned at the end. Normally this would be tuned to fit your GPU capability.
None of this is really relevant to embedding though! Since there's that UBatchSize == BatchSize requirement.