XFF Header Processing Change Breaks Client IP Detection When Using CustomHeaderConfig in Original IP Detection

Title: XFF Header Processing Change Breaks Client IP Detection When Using CustomHeaderConfig in Original IP Detection
Description
After implementing support for configuring trusted CIDRs in XFF original IP detection (#31831), Envoy is incorrectly appending the IPs in XFF which is causing issues while determining the original client IP.
The change was intended to add support for evaluating client IP addresses against a list of trusted CIDRs, similar to Nginx's realip module functionality. However, this has resulted in unexpected behavior where an additional value is being appended to the XFF header when forwarding requests to upstream services.
We are suspecting it's because of returning false for skip_xff_append here which gets evaluated in HCM here.
With the new version (v1.32.x), we see:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/7.68.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', '9b392a21-0499-440b-b7db-0d7dc401dd1d'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>,<IP_ADDRESS>'     <---------- SEE THIS
'x-envoy-expected-rq-timeout-ms', '120000'

With the old version (v1.30.x), we see:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/8.7.1'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'c976b755-2903-40ab-ac4d-3cd000c9f229'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'     <---------- SEE THIS
'x-envoy-expected-rq-timeout-ms', '120000'

Repro Steps
Configuration
# Make requests using the following command(s):
# curl -vvv http://localhost:80/foo
static_resources:
  clusters:
    - name: my_cluster_2
      connect_timeout: 5.0s
      type: strict_dns
      lb_policy: round_robin
      load_assignment:
        cluster_name: my_cluster_2
        endpoints:
          lb_endpoints:
            - endpoint:
                address:
                  socket_address:
                    address: <IP_ADDRESS>
                    port_value: 8443
    - name: my_cluster_3
      connect_timeout: 5.0s
      type: strict_dns
      lb_policy: round_robin
      load_assignment:
        cluster_name: my_cluster_3
        endpoints:
          lb_endpoints:
            - endpoint:
                address:
                  socket_address:
                    address: <IP_ADDRESS>
                    port_value: 8444
  listeners:
    - name: my_listener_1
      address:
        socket_address:
          protocol: TCP
          address: <IP_ADDRESS>
          port_value: 80
      listener_filters:
        - name: envoy.filters.listener.tls_inspector
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector
      filter_chains:
        - name: allow-traffic
          filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: my_listener_1_http
                use_remote_address: false
                route_config:
                  name: main_routes
                  virtual_hosts:
                    - name: main_vh
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: /
                          route:
                            cluster: my_cluster_2
                            timeout: 120s
                          request_headers_to_add:
                            - header:
                                key: x-real-ip
                                value: <IP_ADDRESS>
                            - header:
                                key: x-forwarded-for
                                value: <IP_ADDRESS>
                http_filters:
                  - name: envoy.filters.http.router
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
    - name: my_listener_2
      address:
        socket_address:
          protocol: TCP
          address: <IP_ADDRESS>
          port_value: 8443
      listener_filters:
        - name: envoy.filters.listener.tls_inspector
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector
      filter_chains:
        - name: allow-traffic
          filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: my_listener_2_http
                use_remote_address: false
                xff_num_trusted_hops: 0
                original_ip_detection_extensions:
                  - name: envoy.http.original_ip_detection.custom_header
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.http.original_ip_detection.custom_header.v3.CustomHeaderConfig
                      header_name: x-real-ip
                      allow_extension_to_set_address_as_trusted: true
                      reject_with_status:
                        code: Forbidden
                route_config:
                  name: main_routes
                  virtual_hosts:
                    - name: main_vh
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: /
                          route:
                            cluster: my_cluster_3
                            timeout: 120s
                http_filters:
                  - name: envoy.filters.http.router
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
    - name: my_listener_3
      address:
        socket_address:
          protocol: TCP
          address: <IP_ADDRESS>
          port_value: 8444
      listener_filters:
        - name: envoy.filters.listener.tls_inspector
          typed_config:
            "@type": type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector
      filter_chains:
        - name: allow-traffic
          filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: my_listener_3_http
                route_config:
                  name: main_routes
                  virtual_hosts:
                    - name: main_vh
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: /
                          direct_response:
                            body:
                              inline_string: OK
                            status: 200
                http_filters:
                  - name: envoy.filters.http.router
                    typed_config:
                      "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router

Request
Send a cURL request with v1.30 and v1.32 like this:
curl -vvv http://localhost:80/foo

Output
v1.32
[2024-11-15 09:32:29.141][12033][debug][dns] [source/extensions/network/dns_resolver/cares/dns_impl.cc:410] dns resolution for <IP_ADDRESS> started
[2024-11-15 09:32:29.141][12033][debug][dns] [source/extensions/network/dns_resolver/cares/dns_impl.cc:327] dns resolution for <IP_ADDRESS> completed with status 0
[2024-11-15 09:32:29.142][12033][debug][upstream] [source/common/upstream/upstream_impl.cc:485] transport socket match, socket default selected for host with address <IP_ADDRESS>:8443
[2024-11-15 09:32:29.142][12033][debug][upstream] [source/extensions/clusters/strict_dns/strict_dns_cluster.cc:211] DNS refresh rate reset for <IP_ADDRESS>, refresh rate 5000 ms
[2024-11-15 09:32:29.142][12033][debug][dns] [source/extensions/network/dns_resolver/cares/dns_impl.cc:410] dns resolution for <IP_ADDRESS> started
[2024-11-15 09:32:29.142][12033][debug][dns] [source/extensions/network/dns_resolver/cares/dns_impl.cc:327] dns resolution for <IP_ADDRESS> completed with status 0
[2024-11-15 09:32:29.142][12033][debug][upstream] [source/common/upstream/upstream_impl.cc:485] transport socket match, socket default selected for host with address <IP_ADDRESS>:8444
[2024-11-15 09:32:29.142][12033][debug][upstream] [source/extensions/clusters/strict_dns/strict_dns_cluster.cc:211] DNS refresh rate reset for <IP_ADDRESS>, refresh rate 5000 ms
[2024-11-15 09:32:29.201][12033][debug][main] [source/server/server.cc:238] flushing stats
[2024-11-15 09:32:30.347][12097][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"0"] new connection from <IP_ADDRESS>:53166
[2024-11-15 09:32:30.348][12097][debug][http] [source/common/http/conn_manager_impl.cc:394] [Tags: "ConnectionId":"0"] new stream
[2024-11-15 09:32:30.348][12097][debug][http] [source/common/http/conn_manager_impl.cc:1184] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/7.68.0'
'accept', '*/*'

[2024-11-15 09:32:30.348][12097][debug][http] [source/common/http/conn_manager_impl.cc:1167] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] request end stream timestamp recorded
[2024-11-15 09:32:30.348][12097][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"0"] current connecting state: false
[2024-11-15 09:32:30.349][12097][debug][router] [source/common/router/router.cc:527] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] cluster 'my_cluster_2' match for URL '/foo'
[2024-11-15 09:32:30.349][12097][debug][router] [source/common/router/router.cc:756] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] router decoding headers:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.68.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', '9b392a21-0499-440b-b7db-0d7dc401dd1d'
'x-envoy-expected-rq-timeout-ms', '120000'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'

[2024-11-15 09:32:30.349][12097][debug][pool] [source/common/http/conn_pool_base.cc:78] queueing stream due to no available connections (ready=0 busy=0 connecting=0)
[2024-11-15 09:32:30.349][12097][debug][pool] [source/common/conn_pool/conn_pool_base.cc:291] trying to create new connection
[2024-11-15 09:32:30.349][12097][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[2024-11-15 09:32:30.350][12097][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"1"] current connecting state: true
[2024-11-15 09:32:30.350][12097][debug][client] [source/common/http/codec_client.cc:57] [Tags: "ConnectionId":"1"] connecting
[2024-11-15 09:32:30.350][12097][debug][connection] [source/common/network/connection_impl.cc:1017] [Tags: "ConnectionId":"1"] connecting to <IP_ADDRESS>:8443
[2024-11-15 09:32:30.350][12097][debug][connection] [source/common/network/connection_impl.cc:1036] [Tags: "ConnectionId":"1"] connection in progress
[2024-11-15 09:32:30.350][12097][debug][connection] [source/common/network/connection_impl.cc:746] [Tags: "ConnectionId":"1"] connected
[2024-11-15 09:32:30.350][12097][debug][client] [source/common/http/codec_client.cc:88] [Tags: "ConnectionId":"1"] connected
[2024-11-15 09:32:30.350][12097][debug][pool] [source/common/conn_pool/conn_pool_base.cc:328] [Tags: "ConnectionId":"1"] attaching to next stream
[2024-11-15 09:32:30.350][12097][debug][pool] [source/common/conn_pool/conn_pool_base.cc:182] [Tags: "ConnectionId":"1"] creating stream
[2024-11-15 09:32:30.350][12097][debug][router] [source/common/router/upstream_request.cc:589] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] pool ready
[2024-11-15 09:32:30.350][12097][debug][client] [source/common/http/codec_client.cc:142] [Tags: "ConnectionId":"1"] encode complete
[2024-11-15 09:32:30.350][12074][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"2"] new connection from <IP_ADDRESS>:38274
[2024-11-15 09:32:30.351][12074][debug][http] [source/common/http/conn_manager_impl.cc:394] [Tags: "ConnectionId":"2"] new stream
[2024-11-15 09:32:30.351][12074][debug][http] [source/common/http/conn_manager_impl.cc:1184] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/7.68.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', '9b392a21-0499-440b-b7db-0d7dc401dd1d'
'x-envoy-expected-rq-timeout-ms', '120000'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'

[2024-11-15 09:32:30.351][12074][debug][http] [source/common/http/conn_manager_impl.cc:1167] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] request end stream timestamp recorded
[2024-11-15 09:32:30.351][12074][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"2"] current connecting state: false
[2024-11-15 09:32:30.351][12074][debug][router] [source/common/router/router.cc:527] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] cluster 'my_cluster_3' match for URL '/foo'
[2024-11-15 09:32:30.351][12074][debug][router] [source/common/router/router.cc:756] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] router decoding headers:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.68.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', '9b392a21-0499-440b-b7db-0d7dc401dd1d'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>,<IP_ADDRESS>'
'x-envoy-expected-rq-timeout-ms', '120000'

[2024-11-15 09:32:30.352][12074][debug][pool] [source/common/http/conn_pool_base.cc:78] queueing stream due to no available connections (ready=0 busy=0 connecting=0)
[2024-11-15 09:32:30.352][12074][debug][pool] [source/common/conn_pool/conn_pool_base.cc:291] trying to create new connection
[2024-11-15 09:32:30.352][12074][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[2024-11-15 09:32:30.352][12074][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"3"] current connecting state: true
[2024-11-15 09:32:30.352][12074][debug][client] [source/common/http/codec_client.cc:57] [Tags: "ConnectionId":"3"] connecting
[2024-11-15 09:32:30.352][12074][debug][connection] [source/common/network/connection_impl.cc:1017] [Tags: "ConnectionId":"3"] connecting to <IP_ADDRESS>:8444
[2024-11-15 09:32:30.352][12074][debug][connection] [source/common/network/connection_impl.cc:1036] [Tags: "ConnectionId":"3"] connection in progress
[2024-11-15 09:32:30.352][12074][debug][connection] [source/common/network/connection_impl.cc:746] [Tags: "ConnectionId":"3"] connected
[2024-11-15 09:32:30.352][12074][debug][client] [source/common/http/codec_client.cc:88] [Tags: "ConnectionId":"3"] connected
[2024-11-15 09:32:30.353][12074][debug][pool] [source/common/conn_pool/conn_pool_base.cc:328] [Tags: "ConnectionId":"3"] attaching to next stream
[2024-11-15 09:32:30.353][12074][debug][pool] [source/common/conn_pool/conn_pool_base.cc:182] [Tags: "ConnectionId":"3"] creating stream
[2024-11-15 09:32:30.353][12074][debug][router] [source/common/router/upstream_request.cc:589] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] pool ready
[2024-11-15 09:32:30.353][12074][debug][client] [source/common/http/codec_client.cc:142] [Tags: "ConnectionId":"3"] encode complete
[2024-11-15 09:32:30.353][12098][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"4"] new connection from <IP_ADDRESS>:60364
[2024-11-15 09:32:30.353][12098][debug][http] [source/common/http/conn_manager_impl.cc:394] [Tags: "ConnectionId":"4"] new stream
[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/conn_manager_impl.cc:1184] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/7.68.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', '9b392a21-0499-440b-b7db-0d7dc401dd1d'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>,<IP_ADDRESS>'
'x-envoy-expected-rq-timeout-ms', '120000'

[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/conn_manager_impl.cc:1167] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] request end stream timestamp recorded
[2024-11-15 09:32:30.354][12098][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"4"] current connecting state: false
[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/filter_manager.cc:1034] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] Preparing local reply with details direct_response
[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/filter_manager.cc:1076] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] Executing sending local reply.
[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/conn_manager_impl.cc:1879] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:32:30 GMT'
'server', 'envoy'

[2024-11-15 09:32:30.354][12098][debug][http] [source/common/http/conn_manager_impl.cc:1994] [Tags: "ConnectionId":"4","StreamId":"12614797142382797470"] Codec completed encoding stream.
[2024-11-15 09:32:30.354][12074][debug][router] [source/common/router/router.cc:1554] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] upstream headers complete: end_stream=false
[2024-11-15 09:32:30.355][12074][debug][http] [source/common/http/conn_manager_impl.cc:1879] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:32:30 GMT'
'server', 'envoy'
'x-envoy-upstream-service-time', '1'

[2024-11-15 09:32:30.355][12074][debug][client] [source/common/http/codec_client.cc:129] [Tags: "ConnectionId":"3"] response complete
[2024-11-15 09:32:30.356][12074][debug][http] [source/common/http/conn_manager_impl.cc:1994] [Tags: "ConnectionId":"2","StreamId":"16676946837840269223"] Codec completed encoding stream.
[2024-11-15 09:32:30.356][12074][debug][pool] [source/common/http/http1/conn_pool.cc:53] [Tags: "ConnectionId":"3"] response complete
[2024-11-15 09:32:30.356][12074][debug][pool] [source/common/conn_pool/conn_pool_base.cc:215] [Tags: "ConnectionId":"3"] destroying stream: 0 remaining
[2024-11-15 09:32:30.356][12097][debug][router] [source/common/router/router.cc:1554] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] upstream headers complete: end_stream=false
[2024-11-15 09:32:30.357][12097][debug][http] [source/common/http/conn_manager_impl.cc:1879] [Tags: "ConnectionId":"0","StreamId":"10315118978607584203"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:32:30 GMT'
'server', 'envoy'
'x-envoy-upstream-service-time', '6'

[2024-11-15 09:32:30.357][12097][debug][client] [source/common/http/codec_client.cc:129] [Tags: "ConnectionId":"1"] response complete

v1.30
[2024-11-15 15:01:05.523][31760463][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"0"] new connection from <IP_ADDRESS>:49429
[2024-11-15 15:01:05.523][31760463][debug][http] [source/common/http/conn_manager_impl.cc:385] [Tags: "ConnectionId":"0"] new stream
[2024-11-15 15:01:05.523][31760463][debug][http] [source/common/http/conn_manager_impl.cc:1135] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/8.7.1'
'accept', '*/*'

[2024-11-15 15:01:05.523][31760463][debug][http] [source/common/http/conn_manager_impl.cc:1118] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] request end stream
[2024-11-15 15:01:05.523][31760463][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"0"] current connecting state: false
[2024-11-15 15:01:05.523][31760463][debug][router] [source/common/router/router.cc:525] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] cluster 'my_cluster_2' match for URL '/foo'
[2024-11-15 15:01:05.523][31760463][debug][router] [source/common/router/router.cc:750] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] router decoding headers:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/8.7.1'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'c976b755-2903-40ab-ac4d-3cd000c9f229'
'x-envoy-expected-rq-timeout-ms', '120000'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'

[2024-11-15 15:01:05.523][31760463][debug][pool] [source/common/http/conn_pool_base.cc:78] queueing stream due to no available connections (ready=0 busy=0 connecting=0)
[2024-11-15 15:01:05.523][31760463][debug][pool] [source/common/conn_pool/conn_pool_base.cc:291] trying to create new connection
[2024-11-15 15:01:05.523][31760463][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[2024-11-15 15:01:05.523][31760463][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"1"] current connecting state: true
[2024-11-15 15:01:05.523][31760463][debug][client] [source/common/http/codec_client.cc:57] [Tags: "ConnectionId":"1"] connecting
[2024-11-15 15:01:05.523][31760463][debug][connection] [source/common/network/connection_impl.cc:1017] [Tags: "ConnectionId":"1"] connecting to <IP_ADDRESS>:8443
[2024-11-15 15:01:05.523][31760463][debug][connection] [source/common/network/connection_impl.cc:1036] [Tags: "ConnectionId":"1"] connection in progress
[2024-11-15 15:01:05.524][31760463][debug][connection] [source/common/network/connection_impl.cc:746] [Tags: "ConnectionId":"1"] connected
[2024-11-15 15:01:05.524][31760463][debug][client] [source/common/http/codec_client.cc:88] [Tags: "ConnectionId":"1"] connected
[2024-11-15 15:01:05.524][31760463][debug][pool] [source/common/conn_pool/conn_pool_base.cc:328] [Tags: "ConnectionId":"1"] attaching to next stream
[2024-11-15 15:01:05.524][31760463][debug][pool] [source/common/conn_pool/conn_pool_base.cc:182] [Tags: "ConnectionId":"1"] creating stream
[2024-11-15 15:01:05.524][31760463][debug][router] [source/common/router/upstream_request.cc:595] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] pool ready
[2024-11-15 15:01:05.524][31760463][debug][client] [source/common/http/codec_client.cc:142] [Tags: "ConnectionId":"1"] encode complete
[2024-11-15 15:01:05.524][31760472][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"2"] new connection from <IP_ADDRESS>:49430
[2024-11-15 15:01:05.524][31760472][debug][http] [source/common/http/conn_manager_impl.cc:385] [Tags: "ConnectionId":"2"] new stream
[2024-11-15 15:01:05.524][31760472][debug][http] [source/common/http/conn_manager_impl.cc:1135] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/8.7.1'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'c976b755-2903-40ab-ac4d-3cd000c9f229'
'x-envoy-expected-rq-timeout-ms', '120000'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'

[2024-11-15 15:01:05.524][31760472][debug][http] [source/common/http/conn_manager_impl.cc:1118] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] request end stream
[2024-11-15 15:01:05.524][31760472][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"2"] current connecting state: false
[2024-11-15 15:01:05.524][31760472][debug][router] [source/common/router/router.cc:525] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] cluster 'my_cluster_3' match for URL '/foo'
[2024-11-15 15:01:05.524][31760472][debug][router] [source/common/router/router.cc:750] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] router decoding headers:
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/8.7.1'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'c976b755-2903-40ab-ac4d-3cd000c9f229'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'
'x-envoy-expected-rq-timeout-ms', '120000'

[2024-11-15 15:01:05.524][31760472][debug][pool] [source/common/http/conn_pool_base.cc:78] queueing stream due to no available connections (ready=0 busy=0 connecting=0)
[2024-11-15 15:01:05.524][31760472][debug][pool] [source/common/conn_pool/conn_pool_base.cc:291] trying to create new connection
[2024-11-15 15:01:05.524][31760472][debug][pool] [source/common/conn_pool/conn_pool_base.cc:145] creating a new connection (connecting=0)
[2024-11-15 15:01:05.525][31760472][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"3"] current connecting state: true
[2024-11-15 15:01:05.525][31760472][debug][client] [source/common/http/codec_client.cc:57] [Tags: "ConnectionId":"3"] connecting
[2024-11-15 15:01:05.525][31760472][debug][connection] [source/common/network/connection_impl.cc:1017] [Tags: "ConnectionId":"3"] connecting to <IP_ADDRESS>:8444
[2024-11-15 15:01:05.525][31760472][debug][connection] [source/common/network/connection_impl.cc:1036] [Tags: "ConnectionId":"3"] connection in progress
[2024-11-15 15:01:05.525][31760472][debug][connection] [source/common/network/connection_impl.cc:746] [Tags: "ConnectionId":"3"] connected
[2024-11-15 15:01:05.525][31760472][debug][client] [source/common/http/codec_client.cc:88] [Tags: "ConnectionId":"3"] connected
[2024-11-15 15:01:05.525][31760472][debug][pool] [source/common/conn_pool/conn_pool_base.cc:328] [Tags: "ConnectionId":"3"] attaching to next stream
[2024-11-15 15:01:05.525][31760472][debug][pool] [source/common/conn_pool/conn_pool_base.cc:182] [Tags: "ConnectionId":"3"] creating stream
[2024-11-15 15:01:05.525][31760472][debug][router] [source/common/router/upstream_request.cc:595] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] pool ready
[2024-11-15 15:01:05.525][31760472][debug][client] [source/common/http/codec_client.cc:142] [Tags: "ConnectionId":"3"] encode complete
[2024-11-15 15:01:05.525][31760464][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"4"] new connection from <IP_ADDRESS>:49431
[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/conn_manager_impl.cc:385] [Tags: "ConnectionId":"4"] new stream
[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/conn_manager_impl.cc:1135] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] request headers complete (end_stream=true):
':authority', 'localhost'
':path', '/foo'
':method', 'GET'
'user-agent', 'curl/8.7.1'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'c976b755-2903-40ab-ac4d-3cd000c9f229'
'x-real-ip', '<IP_ADDRESS>'
'x-forwarded-for', '<IP_ADDRESS>'
'x-envoy-expected-rq-timeout-ms', '120000'

[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/conn_manager_impl.cc:1118] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] request end stream
[2024-11-15 15:01:05.525][31760464][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"4"] current connecting state: false
[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/filter_manager.cc:1025] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] Preparing local reply with details direct_response
[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/filter_manager.cc:1067] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] Executing sending local reply.
[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/conn_manager_impl.cc:1825] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:31:05 GMT'
'server', 'envoy'

[2024-11-15 15:01:05.525][31760464][debug][http] [source/common/http/conn_manager_impl.cc:1937] [Tags: "ConnectionId":"4","StreamId":"6422728508326757723"] Codec completed encoding stream.
[2024-11-15 15:01:05.526][31760472][debug][router] [source/common/router/router.cc:1551] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] upstream headers complete: end_stream=false
[2024-11-15 15:01:05.526][31760472][debug][http] [source/common/http/conn_manager_impl.cc:1825] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:31:05 GMT'
'server', 'envoy'
'x-envoy-upstream-service-time', '0'

[2024-11-15 15:01:05.526][31760472][debug][client] [source/common/http/codec_client.cc:129] [Tags: "ConnectionId":"3"] response complete
[2024-11-15 15:01:05.526][31760472][debug][http] [source/common/http/conn_manager_impl.cc:1937] [Tags: "ConnectionId":"2","StreamId":"11705774902034065365"] Codec completed encoding stream.
[2024-11-15 15:01:05.526][31760472][debug][pool] [source/common/http/http1/conn_pool.cc:53] [Tags: "ConnectionId":"3"] response complete
[2024-11-15 15:01:05.526][31760472][debug][pool] [source/common/conn_pool/conn_pool_base.cc:215] [Tags: "ConnectionId":"3"] destroying stream: 0 remaining
[2024-11-15 15:01:05.526][31760463][debug][router] [source/common/router/router.cc:1551] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] upstream headers complete: end_stream=false
[2024-11-15 15:01:05.526][31760463][debug][http] [source/common/http/conn_manager_impl.cc:1825] [Tags: "ConnectionId":"0","StreamId":"7639773342097111712"] encoding headers via codec (end_stream=false):
':status', '200'
'content-length', '2'
'content-type', 'text/plain'
'date', 'Fri, 15 Nov 2024 09:31:05 GMT'
'server', 'envoy'
'x-envoy-upstream-service-time', '2'

[2024-11-15 15:01:05.526][31760463][debug][client] [source/common/http/codec_client.cc:129] [Tags: "ConnectionId":"1"] response complete

yeah, I think this is an expected change and should be fixed as a bug. We never expect the custom header to append xff.


Emoji not rendered correctly on MacOs

The Babelfish Compass reports generate some lines which start with an emoji to indicate the line has a cursor pop-up with additional information. The emoji is http://www.unicode-symbol.com/u/1F6C8.html and on Windows it renders correctly in Firefox, Edge and Chrome, it looks like this:

However, there have been cases where on MacOS the emoji is rendered incorrectly in Safari and Firefox, looking like a square with hexadecimal digits inside, like this:

However, there have also been reports that the emoji is rendered correctly in MacOS Safari.
In order to get to the bottom of this, a developer with MacOS is invited to participate in this.

I am certainly not a MacOS expert, but this looks like the character is recognized correctly, but some fonts are missing.

What about using this symbol/emoji instead?
http://www.unicode-symbol.com/u/2139.html
https://unicode-table.com/en/2139/
Just did a quick test on Mac and Windows 2019 and it renders correctly on both. I can create a PR.
Note that there are other emojis/symbols that also don't render properly on Mac (haven't tried Linux yet). For example, the "book" icon 🕮 is another that we would need to find a replacement for.

This has been fixed in Compass version 2022-02, using a different emoji which appears to render OK on MacOS


RTL Support

Hi,
Does this plugin support RTL (right to left) languages  ?!

Hi. Yes, you need to set rightToLeft to true.
Cheers!

Oops, it's my mistake, i didn't notice it in the properties, i was searching for the word (RTL) :)
Anyway thanks for your quick reply.

 :)


[FLINK-5667] [state] Synchronize asynchronous checkpointing and close operation

This PR synchronizes asynchronous checkpointing and close operations of a StreamTask.
The synchronization prevents that an acknowledged checkpoint gets discarded and that
a discarded checkpoint gets acknowledged. It achieves this by introducing an atomic
state variable which guards against late close and acknowledge operations.

Thanks! +1 to merge this and #3227. Verified that tests catch both orderings.

Thanks for the review @uce. Will address @StefanRRichter comment from #3227 and then merge the PR.

Thanks @tillrohrmann ! Very good to have this fixed :-)


Test test

testtest

i got this, are you getting this reply?
On Thu, Oct 12, 2023 at 9:41 AM elpike @.***> wrote:

testtest
—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASC2GTBQ6EK2FXVV7SFFYGLX7AMVDANCNFSM6AAAAAA554VUS4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hmm I don't think so, i just forwarded you the messages I got!
On Sat, Oct 14, 2023 at 2:03 AM EdPike365 @.***> wrote:

i got this, are you getting this reply?
On Thu, Oct 12, 2023 at 9:41 AM elpike @.***> wrote:

testtest
—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ASC2GTBQ6EK2FXVV7SFFYGLX7AMVDANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1762410758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7253DESYNDNFH3OZTCGITX7HJF7ANCNFSM6AAAAAA554VUS4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Eleanor Pike
She/Hers
c. +49<PHONE_NUMBER>6

You got the reply to your message from the me at @.*** It
appears that it is going to you at "
elpike @.***>".
I wasnt sure how it would route. How are you checking this email? In github
or in your gmail?
On Sat, Oct 14, 2023 at 1:23 AM elpike @.***> wrote:

Hmm I don't think so, i just forwarded you the messages I got!
On Sat, Oct 14, 2023 at 2:03 AM EdPike365 @.***> wrote:

i got this, are you getting this reply?
On Thu, Oct 12, 2023 at 9:41 AM elpike @.***> wrote:

testtest
—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51, or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ASC2GTBQ6EK2FXVV7SFFYGLX7AMVDANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1762410758>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AB7253DESYNDNFH3OZTCGITX7HJF7ANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Eleanor Pike
She/Hers
c. +49<PHONE_NUMBER>6
—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1762730293,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASC2GTD7PENGM57RMVLFWYTX7JDZXANCNFSM6AAAAAA554VUS4
.
You are receiving this because you commented.Message ID:
@.***>

Directly via email!
On Sat, Oct 14, 2023 at 9:28 PM EdPike365 @.***> wrote:

You got the reply to your message from the me at @.*** It
appears that it is going to you at "
elpike @.***>".
I wasnt sure how it would route. How are you checking this email? In
github
or in your gmail?
On Sat, Oct 14, 2023 at 1:23 AM elpike @.***> wrote:

Hmm I don't think so, i just forwarded you the messages I got!
On Sat, Oct 14, 2023 at 2:03 AM EdPike365 @.***> wrote:

i got this, are you getting this reply?
On Thu, Oct 12, 2023 at 9:41 AM elpike @.***> wrote:

testtest
—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51, or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ASC2GTBQ6EK2FXVV7SFFYGLX7AMVDANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you are subscribed to this
thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
<

https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1762410758>,

or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AB7253DESYNDNFH3OZTCGITX7HJF7ANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Eleanor Pike
She/Hers
c. +49<PHONE_NUMBER>6
—
Reply to this email directly, view it on GitHub
<
https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1762730293>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ASC2GTD7PENGM57RMVLFWYTX7JDZXANCNFSM6AAAAAA554VUS4>

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/EdPike365-Org/edpike365-blog/issues/51#issuecomment-1763153465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7253BXIQXOZDF6GRQCZP3X7LRVLANCNFSM6AAAAAA554VUS4
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Eleanor Pike
She/Hers
c. +49<PHONE_NUMBER>6


Preview Saga is called twice when loading the editor

While using the editor in any of the step challenge, you will have different layout mobile and desktop, we are using different components for these layouts.
Pros:

the editor isn't supported for mobile, so we can have somewhat of a support for it.
the styling and layout will become easier.

Cons:

loading the same Redux actions twice. (adding console log, to preview sage here will show twice)
losing the state when camper change the layout manually, it act similar to refreshing the page (lose focus, maybe reimport components, and such)

I think it's better overall if that section is deleted.

I am not sure what you mean by deleting the mobile layout. It does seem pretty useful to me.
Do you mean that both the mobile layout and the web layout are loaded depending on the screen size while the user is already present on the site?

the preview saga is called twice whenever the preview is mounted.

Are you sure this is not just because you are in development mode? Does this happen for a production build?

I don't know how to test it in production, redux dev tools doesn't show anything on
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-basic-css-by-building-a-cafe-menu/step-4

@Sboonny one option is to build the client locally. That should enable redux dev tools. Just to be on the safe side, I'd add the console log you suggested, too.

It has the console log run three time in built environment.
Thanks to Oliver help, I was able to run it by these commands
pnpm run build
cd client
pnpm dlx serve -p 8000 public

I am not sure what you mean by deleting the mobile layout. It does seem pretty useful to me.
Do you mean that both the mobile layout and the web layout are loaded depending on the screen size while the user is already present on the site?

just seen will look into.sje.l


test GPT bot with buggy commit

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review

/reviewbot review


Issue #391 - Fixed error when saving application with missing inputs

If Job doesn't have asset or essential criteria or hiring questions, that will no longer cause errors while applying.

@tristan-orourke Please resolve conflict then merge this in.

Fixed the merge conflict


mqtt_io as a service

Hi Im using openhabian on a raspberry pi 4
Im trying to run mqtt_io as service, have created "runmqttio.py"
which is:
import os
cmd = 'python3 -m mqtt_io /home/openhabian/mqtt-io/config.MCP3008.yml'
os.system(cmd)

I can run this sucessfully from console using:
openhabian@openhabian:~ $ python3 /home/openhabian/runmqttio.py
but on starting "mqtt_io.service"
[Unit]
Description=mqtt_io
After=multi-user.target
[Service]
Type=simple
ExecStart=/usr/bin/python /home/openhabian/runmqttio.py
Restart=on-abort
[Install]
WantedBy=multi-user.target

i get the following:

openhabian@openhabian:~ $ sudo systemctl status mqtt_io.service
● mqtt_io.service - mqtt_io
Loaded: loaded (/lib/systemd/system/mqtt_io.service; enabled; vendor preset: enabled)
Active: inactive (dead) since Sun 2022-10-23 16:20:54 CEST; 3s ago
Process: 6875 ExecStart=/usr/bin/python /home/openhabian/runmqttio.py (code=exited, status=0/SUCCESS)
Main PID: 6875 (code=exited, status=0/SUCCESS)
CPU: 139ms
Oct 23 16:20:54 openhabian systemd[1]: Started mqtt_io.
Oct 23 16:20:54 openhabian python[6877]: /usr/bin/python3: No module named mqtt_io
Oct 23 16:20:54 openhabian systemd[1]: mqtt_io.service: Succeeded.

although the service starts mqtt_io is not running
I have replaced the runmqttio.py with another simple "hello_world" bit of script and that works fine!
any help much appreciated.
Matt
Config
mqtt:
  host: <IP_ADDRESS>
  port: 1883
  user: ""
  password: ""
  topic_prefix: battery

gpio_modules:
  - name: rpi
    module: raspberrypi

sensor_modules:
  - name: mcp3008
    module: mcp3008

digital_inputs:
  - name: test
    module: rpi
    pin: 1

sensor_inputs:
  - name: analog0
    module: mcp3008
    interval: 10
    channel: 0

  - name: analog1
    module: mcp3008
    interval: 10
    channel: 1

  - name: analog2
    module: mcp3008
    interval: 10
    channel: 2

  - name: analog3
    module: mcp3008
    interval: 10
    channel: 3

  - name: analog4
    module: mcp3008
    interval: 10
    channel: 4

  - name: analog5
    module: mcp3008
    interval: 10
    channel: 5

  - name: analog6
    module: mcp3008
    interval: 10
    channel: 6

  - name: analog7
    module: mcp3008
    interval: 10
    channel: 7

Hardware

Raspberry Pi,

System:

OS: Openhabian]
Python version: Python 3.9.2
User you're running as: openhabian
Using a virtualenv?: no

My guess would by that you have installed mqtt-io using pip as a regular user, but your service is running as root. (Don't try to fix this by running pip with sudo, that is not recommended.)
This is my systemd unit file (I have installed mqtt-io in a python venv in /opt/mqttio):
sudo tee /etc/systemd/system/mqttio.service << EOF
[Unit]
Description=MQTT IO
Requires=mosquitto.service
After=mosquitto.service

[Service]
User=homeassistant
ExecStart=/opt/mqttio/bin/python3 -m mqtt_io /etc/mqttio.yml
RestartSec=30
Restart=on-failure
SyslogIdentifier=mqttio

[Install]
WantedBy=multi-user.target
EOF

The important line is User=homeassistant (the user I want to run the program as).

Brilliant, thank you so much, added line User=openhabian and its up and running.


Format code, add stream

Hi,
I formatted the code using black formatter and added stream dependency injection. So that this module can be used for example with loggers.

Hi,
Could you have a look ?


fix(modules): remove libraries linked with -l from the static bundled libs

This PR removes static libraries that are linked via -l flags from the bundled libsysflow_with_deps.a library. This is to avoid name collisions when consumers have already linked these libraries on their own builds.
Signed-off-by: Frederico Araujo<EMAIL_ADDRESS>

/lgtm


Need to update the sample ~/quantum/samples/interoperability/qrng/Qrng.qs please remove the last bracket.

There is one extra bracket in the end. Please update this
    operation SampleQuantumRandomNumberGenerator() : Result {         use q = Qubit(); // Allocate a qubit.         H(q);            // Put the qubit to superposition. It now has a 50% chance of being 0 or 1.         let r = M(q);    // Measure the qubit value.         Reset(q);         return r;     } }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a7f7964-eb2b-502d-470d-91f826aea2ff
Version Independent ID: d74f059a-e3a3-29e8-ba53-cef7c831f010
Content: Develop with Q# Jupyter Notebooks - Microsoft Quantum
Content Source: articles/quickstarts/install-jupyter.md
Product: quantum
GitHub Login: @Bradben
Microsoft Alias: v-benbra

Hi, thanks for catching that! The sample is ok, but the include snippet of the markdown file is pulling incorrect lines due to recent changes in the sample file. This seems to be an issue for other files that pull the content this way. I'll work to get a general solution for this.
Also, we need to update the screenshot to show the updated version of the code.

Closing these issues since we are tracking it in #28


Postcode and age filter fixes

update postcode to use opencagedata and update age filter to use the correct logic.

@nickevansuk this has the changes from the previous pull request, but with the changes requested.
The previous pull request can be closed.

Hey @JoshuaLevett @michaellangley, I've closed the previous pull request, and also invited you to https://github.com/orgs/openactive/teams/playwaze (the team has access to this repo, so should auto-generate deployments - there seems to be a permissions issue there)
Once you are happy with a QA on your side (it still seems somewhat broken) let me know and I can review
Suggest using the Bookwhen feed for testing as the UAT environment doesn't have a CDN in front of it: https://rpde-visuali-main-h4v2ylndrdyb.herokuapp.com/?endpoint=https://bookwhen.com/api/openactive/sessionseries&execute=true

@nickevansuk some bug fixes have been committed, can you please update the test environment.

@michaellangley have just manually deployed it again
@michaellangley as above please join the team here: https://github.com/orgs/openactive/teams/playwaze/members so that it will auto-deploy for you.

@nickevansuk
I've reviewed and made (a few) changes.
The only filter I'm aware doesn't appear to be working (reliably) is the activity search, where it appears to work once, but then the list gets wiped.
The master branch appears to have the same issue, and I'm not sure whether this is something we are expected to look at.
Otherwise I believe it's in a good place.
P.S
You may want to squash merge when the time comes 😅

Hey @JoshuaLevett just did a quick smoke test and one note:

What does the "Organization" filter do? This seems to be a legacy handover from the original Open Referral code, and perhaps should be removed?

Activity search should be a facet search (i.e. the list is reduced based on the options available within the data itself, after the initial search is made). Definitely some UX improvements left to be made overall, but does this explain the behaviour you're seeing?

Sure, organizer name search would make sense to me - and perhaps organizer is removed from the keyword search scope?

@nickevansuk hope all is well. Would you be able to action this when we get a spare minute simply so we can clear it off and confirm back to EMD as the funder that work is complete?
Thanks in advance
Charlie

@nickevansuk
Appreciate you are busy, but I don't think it would take much to get this over the line now

Going to close this pull request now as we are about to push a significant update to this tool, which restores relevant filters and takes a slightly different approach to searching by location. Thanks for the contribution!


Fix some double negation typos

Thanks for the PR! It seems like I wrote this while I was half asleep.


feat: LEAP-336: Collapsible cards in Ranker

Allow to collapse and expand cards for easy interactions. With collapsed cards user can see lot of items together with makes rearrangement easier.
Collapsed/expanded states are indicated by ASCII triangles (△/▽ and ▲/▼ for hovered state) used in css to change only class names, not the content and to keep indicators in one place.
Collapse is desirable action so column is treated as expanded when at least one item is expanded. This allows to collapse all items in any state by one click.
PR fulfills these requirements

[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

What libraries were added/updated?
none
Does this change affect performance?
nope
Does this change affect security?
nope
What alternative approaches were there?
Cards can be made hidden with animation to not change the content inside, but this will require calculations of their height.
What feature flags were used to cover this change?
none yet
Does this PR introduce a breaking change?

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
Ranker

Codecov Report
Attention: 14 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

src/components/NewTaxonomy/NewTaxonomy.tsx
87.50% <100.00%> (+0.22%)
:arrow_up:

src/components/NewTaxonomy/TaxonomySearch.tsx
85.71% <100.00%> (ø)

src/components/Ranker/Column.tsx
11.11% <0.00%> (-8.89%)
:arrow_down:

src/components/Ranker/Item.tsx
7.69% <0.00%> (-3.42%)
:arrow_down:

src/components/Ranker/Ranker.tsx
5.40% <16.66%> (+2.17%)
:arrow_up:

:loudspeaker: Thoughts on this report? Let us know!


llama instead of gpt

Just a few questions about using LLMLingua.

How do I adjust the code so that I am using Llama instead of GPT?
The reason I am using Llama instead of GPT is because I don't want my data to be sent to any other company's server. Using Llama, is my prompt or data being sent to some server?

Hi @jwahnn,
Thank you for your support of LLMLingua. You can directly use the current code to compress prompts and input them into LLaMA. Experiments in LongLLMLingua have shown that even using open-source models like LongChat-13b as LLMs can effectively understand compressed prompts.
Your concern makes sense, our compression process does not send results to any server; it is processed locally only.

Hi @iofu728, thanks for the input. Just a few more follow up question, though. I am slightly confused about the description provided in the main GitHub page (https://github.com/microsoft/LLMLingua#2-using-longllmlingua-for-prompt-compression). Do I just run the file that contain those lines of code? Also, your demo says "Using the LLaMA2-7B as a small language model would result in a significant performance improvement, especially at high compression ratios." Does the current version on Github use LLaMA2, then?

Hi @jwahnn,
The link at https://github.com/microsoft/LLMLingua#2-using-longllmlingua-for-prompt-compression is just a quick start guide on how to use our library. For more detailed information and examples, please refer to our documentation and the examples section.
Regarding your second question, yes, you can use different models in LLMLingua by specifying the model_name parameter. The default model is "llama 2-7b".
llm_lingua = PromptCompressor(model_name="microsoft/phi-2")


feat fallback speech vendor

https://github.com/jambonz/jambonz-feature-server/issues/425

published in 0.0.29


MarkerCluster

Hi there,
first of all, thanks for the great library!
I'm wondering whether there is a way to use a Marker Cluster in ipyleaflet, such as is available in folium through the folium.MarkerCluster?
If not, I wouldn't mind trying to add this functionality and provide a PR, if I can get some pointers as to how to go about implementing it.
Thanks!
Omri

Definitely would be useful!   :stuck_out_tongue_closed_eyes:

Fixed by #90.

@omrihar , if you want to see how Jason did this enhancement, from conception to PR, check out this recording: https://www.youtube.com/watch?v=msJig1fr7Lw

This is released in ipyleaflet 0.5.3, which I just put up on pypi, and the conda-forge package is building at https://github.com/conda-forge/ipyleaflet-feedstock/pull/19

@rsignell-usgs thanks! this video seems very informative and will definitely help get into understanding and developing nbextensions :)
Once I have some time during the Christmas holidays I'll have a deeper look at it.


Remove references to Gondor.io in documentation.

Gondor.io has been retired by Eldarion (see http://eldarion.cloud/blog/2016/04/21/goodbye-gondor-hello-kel-and-eldarion-cloud/), so the tutorial wouldn't be helpful even if it was accessible.
I don't think this change is significant enough that it needs to be added to the CHANGELOG and release notes. I did not add my name to CONTRIBUTORS in order to avoid conflicts if someone else's first pull request is merged before mine. My preferred name is "Martey Dodoo".

Thanks @martey! Merged in 3923ee668c292ed2d1d2e76ae1a728da20b9be68.


I have some problems I think it is connected with dataset that i make myself

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
tf 2
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I got an Error with model.fit
For your information, I will also add that the table used for the dataset
consists of 2 columns, one of which contains the paths to the images on
 the disk, and the second one contains the labels for each image.
 And I’m also new to github and therefore I don’t know how to make it so
 that you can run all the code because I don’t really want to share a huge
 folder with files, I can also clarify that the training arrays consist of 800 .png images

Standalone code to reproduce the issue
https://colab.research.google.com/drive/1VsjzbjAhZru1kdY7iElxQWrsIW9rMfGA?usp=sharing

Relevant log output
UnimplementedError                        Traceback (most recent call last)
<ipython-input-27-c0002c3040bd> in <module>
----> 1 model.fit(x_train, y_train, epochs=10)

1 frames
/usr/local/lib/python3.8/dist-packages/tensorflow/python/eager/execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
     52   try:
     53     ctx.ensure_initialized()
---> 54     tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
     55                                         inputs, attrs, num_outputs)
     56   except core._NotOkStatusException as e:

UnimplementedError: Graph execution error:

Detected at node 'sparse_categorical_crossentropy/Cast' defined at (most recent call last):
    File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
      return _run_code(code, main_globals, None,
    File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
      exec(code, run_globals)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel_launcher.py", line 16, in <module>
      app.launch_new_instance()
    File "/usr/local/lib/python3.8/dist-packages/traitlets/config/application.py", line 992, in launch_instance
      app.start()
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelapp.py", line 612, in start
      self.io_loop.start()
    File "/usr/local/lib/python3.8/dist-packages/tornado/platform/asyncio.py", line 149, in start
      self.asyncio_loop.run_forever()
    File "/usr/lib/python3.8/asyncio/base_events.py", line 570, in run_forever
      self._run_once()
    File "/usr/lib/python3.8/asyncio/base_events.py", line 1859, in _run_once
      handle._run()
    File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run
      self._context.run(self._callback, *self._args)
    File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 690, in <lambda>
      lambda f: self._run_callback(functools.partial(callback, future))
    File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 743, in _run_callback
      ret = callback()
    File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 787, in inner
      self.run()
    File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 748, in run
      yielded = self.gen.send(value)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 365, in process_one
      yield gen.maybe_future(dispatch(*args))
    File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper
      yielded = next(result)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 268, in dispatch_shell
      yield gen.maybe_future(handler(stream, idents, msg))
    File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper
      yielded = next(result)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 543, in execute_request
      self.do_execute(
    File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper
      yielded = next(result)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/ipkernel.py", line 306, in do_execute
      res = shell.run_cell(code, store_history=store_history, silent=silent)
    File "/usr/local/lib/python3.8/dist-packages/ipykernel/zmqshell.py", line 536, in run_cell
      return super(ZMQInteractiveShell, self).run_cell(*args, **kwargs)
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2854, in run_cell
      result = self._run_cell(
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2881, in _run_cell
      return runner(coro)
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/async_helpers.py", line 68, in _pseudo_sync_runner
      coro.send(None)
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3057, in run_cell_async
      has_raised = await self.run_ast_nodes(code_ast.body, cell_name,
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3249, in run_ast_nodes
      if (await self.run_code(code, result,  async_=asy)):
    File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3326, in run_code
      exec(code_obj, self.user_global_ns, self.user_ns)
    File "<ipython-input-27-c0002c3040bd>", line 1, in <module>
      model.fit(x_train, y_train, epochs=10)
    File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 64, in error_handler
      return fn(*args, **kwargs)
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1409, in fit
      tmp_logs = self.train_function(iterator)
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1051, in train_function
      return step_function(self, iterator)
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1040, in step_function
      outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1030, in run_step
      outputs = model.train_step(data)
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 890, in train_step
      loss = self.compute_loss(x, y, y_pred, sample_weight)
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 948, in compute_loss
      return self.compiled_loss(
    File "/usr/local/lib/python3.8/dist-packages/keras/engine/compile_utils.py", line 201, in __call__
      loss_value = loss_obj(y_t, y_p, sample_weight=sw)
    File "/usr/local/lib/python3.8/dist-packages/keras/losses.py", line 139, in __call__
      losses = call_fn(y_true, y_pred)
    File "/usr/local/lib/python3.8/dist-packages/keras/losses.py", line 243, in call
      return ag_fn(y_true, y_pred, **self._fn_kwargs)
    File "/usr/local/lib/python3.8/dist-packages/keras/losses.py", line 1860, in sparse_categorical_crossentropy
      return backend.sparse_categorical_crossentropy(
    File "/usr/local/lib/python3.8/dist-packages/keras/backend.py", line 5223, in sparse_categorical_crossentropy
      target = cast(target, 'int64')
    File "/usr/local/lib/python3.8/dist-packages/keras/backend.py", line 2066, in cast
      return tf.cast(x, dtype)
Node: 'sparse_categorical_crossentropy/Cast'
Cast string to int64 is not supported
	 [[{{node sparse_categorical_crossentropy/Cast}}]] [Op:__inference_train_function_469]

Here are a couple of things to check that might be causing the error:

Make sure that the paths to the images in your dataset are correct and that the images are present at those locations.

Ensure that the labels in your dataset are in the correct format and are compatible with the model you are using.

Verify that the image data has been preprocessed correctly. (e.g resize, normalize)

Make sure that the data is loaded in the correct format (e.g. numpy array, tensors)

If you are using a pre-trained model, make sure that the input shape and data format match the pre-trained model

It's also important to check if you have the correct version of Tensorflow or Keras.

Also , as I can see that the data is not present in the given path on this colab link: https://colab.research.google.com/drive/1VsjzbjAhZru1kdY7iElxQWrsIW9rMfGA?usp=sharing

Yes, it's also because i don't used to use colab, before thus i used anaconda, all pathes lead to images on my drive, but now I understand, that i don't preprocessed my data, tomorrow i will try to do it, because today i already go sleep. And in adition i want to say thanks for your help and sorry for my English. My English is not so good, because it's not my first language.

Hello from all from Kyrgyzstan

No problem @naurner, If your problem solves tomorrow you can close this issue, else you may seek help anytime.

Hi, @naurner
I found articles which will help you to understand how to use customized image datasets for multi-class image classification problem please have look into these articles article-1, article-2 and if you're using any sample notebook as reference to solve your multi-class image classification problem, could you please share with us as Google colab notebook with some sample rows of your excel file which you're using as dataset so we'll try to replicate your issue from our end ? Thank you!

Oh, hello yes i will try it and share to you my notebooks, but not now, because now i am going to work and will be free only at evening

Hi, @naurner
Sure, please take your time, no hurry at all whenever you get time please share Google Colab notebook with some sample rows of your excel file which you're using as dataset. Thank you!


Nessian Warhound and Greater Hell Hound

Similar to Issue #1 except with Nessian Warhound and Greater Hell Hound.

Implemented in 1.0.3


Error When Checkout Json

I am getting this error while checking out Json versions. I made sure that I don't have any local changes in the repository, I tried checking out whole defects4j repository and initialize it from scratch, but same error. Could someone please suggest what's wrong with this?
Thanks
Neelofar
Checking out 27a52f90 to /data/scratch/projects/punim1163/software-testing/ FAIL
Executed command: git clone /home/nneelofar/defects4j/project_repos/jsoup.git /data/scratch/projects/punim1163/software-testing/fault-localization/defects4j-data-test-properties/Jsoup/data/1-Jsoup-evosuite/Jsoup-1f 2>&1 && cd /data/scratch/projects/punim1163/software-testing/fault-localization/defects4j-data-test-properties/Jsoup/data/1-Jsoup-evosuite/Jsoup-1f && git checkout 27a52f90a25699bebe23ff1ff94d6db361fdb11d 2>&1
Cloning into '/data/scratch/projects/punim1163/software-testing/fault-localization/defects4j-data-test-properties/Jsoup/data/1-Jsoup-evosuite/Jsoup-1f'...
done.
error: Your local changes to the following files would be overwritten by checkout:
src/test/java/org/jsoup/parser/TokeniserStateTest.java
Please, commit your changes or stash them before you can switch branches.
Aborting
Cannot checkout program version! at /home/nneelofar/defects4j/framework/bin/d4j/d4j-checkout line 96.
Compilation failed in require at /home/nneelofar/defects4j/framework/bin/defects4j line 195.

Hi @neelofarhassan,
Unfortunately, I cannot replicate this error.
As a simple sanity check, I would recommend clearing a directory before running a second defects4j checkout command. If you run any sort of compilation/test execution, it can introduce side effects when you perform a different checkout of the same project.

Thank you @Greg4cr for your reply,
The command I am using to checkout any of the Jsoup fixed version is
defects4j checkout -p Jsoup -v 1f -w Jsoup-1f
Sorry I couldn't understand what second checkout command you suggested?
Furthermore, exactly the same command for other projects checkout buggy/fixed versions and later generate tests and mutants successfully.

What I mean is that you should clear (rm -rf Jsoup-1f/*) the contents of the directory you checkout into (in this case Jsoup-1f) before you use defects4j checkout a second time.
Running defects4j checkout -p Jsoup -v 1f -w Jsoup-1f works for me if Jsoup-1f is an empty directory.

Thanks @Greg4cr, I am making sure that the directory is empty before checking out the project. As you can't reproduce the bug, I will try to find if this is something related to my system settings.
Thanks

Hi, @neelofarhassan.
I'm in the same trouble. Can not checkout for the 1-83 versions of Jsoup. But other projects/versions is fine.
Is my configuration wrong?

Hi @47attribute, can you share any information on how you are checking out the bug? (e.g., the commands used, scripting surrounding those commands, are you clearing the directory before checking out?, operating system used)
Are you seeing the same error as @neelofarhassan? error: Your local changes to the following files would be overwritten by checkout

My system is Ubuntu 16.04.7 LTS. The commands and error info are following ( Just Jsoup1-81)
Pic

Thanks @47attribute. I'll look at it when I get a little time and see if I can figure out a reason (and why it works for some people).

I'm also running into this problem, where checkout for Jsoup works in some environments and fails in others. It seems, in the instances it fails, a .gitattributes file is pulled that enforces LF line endings. I'm not sure why it pulls this file flakily, though.

I wasn't able to reproduce this.
@Greg4cr Have you been successful in reproducing this?
@poosomooso Do you have more information on this?
Thanks,
René

I wasn't able to reproduce this.
@Greg4cr Have you been successful in reproducing this?
@poosomooso Do you have more information on this?
Thanks,
René

@rjust Unfortunately, I have not been able to reproduce this. Just tried again on both of my laptops (Ubuntu, Mac OS).
Haven't tried yet, but we could remove this .gitattributes file on checkout and see if that breaks anything.

I have encountered the same problem on my server (ubuntu 16.04). I guess this is caused by unstaged changes in Jsoup git. My workaround is to revise the defects4j/framework/core/Vcs/Git.pm https://github.com/rjust/defects4j/blob/74b5b81ba6a3de794b16b8503b88b9f6788d93fb/framework/core/Vcs/Git.pm#L49
into:
# just to remove unstaged changed
return "git clone $self->{repo} ${work_dir} 2>&1 && cd $work_dir && git add -A && git commit -m \"workaround: enable d4j checkout by adding unstaged changes\"  && git checkout $revision_id 2>&1";

I have encountered the same problem on my server (ubuntu 16.04). I guess this is caused by unstaged changes in Jsoup git. My workaround is to revise the defects4j/framework/core/Vcs/Git.pm
https://github.com/rjust/defects4j/blob/74b5b81ba6a3de794b16b8503b88b9f6788d93fb/framework/core/Vcs/Git.pm#L49
into:
# just to remove unstaged changed
return "git clone $self->{repo} ${work_dir} 2>&1 && cd $work_dir && git add -A && git commit -m \"workaround: enable d4j checkout by adding unstaged changes\"  && git checkout $revision_id 2>&1";

Hope it helps.

Thanks Deheng,it worked.
You help me a lot! :)

Thanks for looking into this @jose.
I think we can close this issue, as it is not reproducible with an up-to-date version of Git.


Use Async (Sync) Cache Api to get cache content

One of the best things we have in Play is the interface to implement our own Cache Api.
I think we can leverage this advantage to use this Redis Module over Async/Sync Cache Api.
https://www.playframework.com/documentation/2.8.x/JavaCache
https://www.playframework.com/documentation/2.8.x/ScalaCache

Hello,
that's a good idea. I think the implementation of AsyncCacheApi can directly use the PlayRedis class itself.

@thibaultmeyer any idea how to implement AsyncCacheApi?
I didn't saw any implementation using a non-blocking process on PlayRedisImpl.

@felipebonezi Jedis does not support Async operations. You can simulate it by using CompletableFuture
public class AsyncCaheRedisImpl implements AsyncCacheApi {

    private final PlayRedis playRedis;

    /**
     * Build a new instance.
     *
     * @param playRedis The PlayRedis module instance
     * @since 05.10.20
     */
    @Inject
    public AsyncCaheRedisImpl (final PlayRedis playRedis) {
        this.playRedis = playRedis;
    }

    @Override
    public <T> CompletionStage<Optional<T>> get(final String s) {
        return CompletableFuture.supplyAsync(() ->
            Optional.ofNullable(playRedis.get(s, new TypeReference<T>() {
            }))
        );
    }
}


TC-DM-3.1- updates to be made to the chip-cert tool to run test case

The following are the requirements to complete the validation process for TC-DM-3.1

CertificateChainResponse does not show the certificate data as shown below
CertificateChainResponse: {
[1651570197.289898][3689:3694] CHIP:TOO:     certificate: Elided value too large of size 491
[1651570197.289954][3689:3694] CHIP:TOO:    }
API to know the length of the certificate
CSRResponse Command fields has to be displayed in readable format for validation

NOCSR Elements
Attestation Signature

4 Generate AddTrustedRootCertificate Command( certificate data visible)
5.Generate Generate invalid root certificate- size exceeding 400 octstr
6. Update chip-cert tool to generate different mal-formatted root certs
7. Parse the TLV data (obtained from the console log) and print certificate (root, NoC, ICAC) for the tester to compare.
TC-DM-3.3
The reference all-cluster-app implementation has all these checks

[1651570197.289898][3689:3694] CHIP:TOO: certificate: Elided value too large of size 491

You're using an old version of chip-tool, it looks like.  This was fixed in #18738 over a week ago.

CSRResponse Command fields has to be displayed in readable format for validation

I believe https://github.com/project-chip/connectedhomeip/pull/18893 addresses this, but @krypton36 should know for sure.

4 Generate AddTrustedRootCertificate Command( certificate data visible)
5.Generate Generate invalid root certificate- size exceeding 400 octstr
6. Update chip-cert tool to generate different mal-formatted root certs
7. Parse the TLV data (obtained from the console log) and print certificate (root, NoC, ICAC) for the tester to compare.

Again, @krypton36 should know the state of things here.

Cert Blocker Review: Assigning to myself to break this up into tasks.

Thanks!


add commerce url to store details

Together with https://github.com/hlxsites/sony-biotech/commit/e5b1efc3a90f545a2902d8c9d896bc10f173d858 to allow cart updates on plp

cc @arumsey


Pollnivneach Roof Removal

There are some floating roof items in Pollnivneach.
Not a big deal, but removing them would be more visually pleasing.

So this actually looks to be a vanilla bug too; these things appear on vanilla with roofs off. As I guess, it's because these things are all used in the rooftop course, though I'm not sure what's so different here that it would cause this, though it might have something to do with the course using all 3 upper planes instead of just 1. This isn't something that can be fixed with overrides.


Feature 3.4/upgrade data test

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

Closed as useless and unrelated.


Update the jupyter notebook example to use current version

See discussion in https://github.com/unconed/mathbox/pull/17

Another related update - when I tried to use the library in another AMD/require environment (ObservableHQ), the UMD bundle isn't looking usable. Public notebook here has more details - re-capturing the summary:

Attempts to import new mathbox bundles (v2.3.1) fail so far. Even the helper notebook fails for all combinations!
https://observablehq.com/@observablehq/module-require-debugger
Library needs a few fixes - possibly similar problems encountered here, and a possible webpack resolution

Thank you for digging into these issues! I am swamped with some work that uses this code, so I won't have time to get to these for a while. Hopefully that is not a blocker on anything you're doing. I think it's important to get this fixed and to get that readback example working, eventually, so thank you again.

Happy to help!
Having a cleaner webpack bundle would help but this isn't blocking my downstream experiments as I'm using (ESM) source directly. I will definitely raise issues/ pull requests for any urgent blockers. Thanks


Failing the fallback for remote connection failure leads to a unconnected REPL

Chain of events:

connected to machine 1 (working)
initiated switch to machine 2
machine 2 connection failed (with the following message):
Starting R Session has failed, please restart it manually. Restoring connection to the 'machine-1'
machine 1 connection failed.

may be connect to local if it exists?

There maybe several locals or no locals at all, so IMO we should leave a decision to the user. But we need to change messages: #2372


SSL NOT FOUND

Hello, I'm facing an SSL problem, Can you please fix it?
https://imgur.com/a/TVJJspH

Hello ?


pretrained model

Thanks for the suggestion. I will add the pretrained model ASAP.

Added pre-trained model checkpoints. Closing this issue.


include original request url in error object for web api errors

Helpful for cases of managing request state using message queues.

I will submit new PR when I fix stubbing.

Coverage increased (+0.03%) to 88.991% when pulling fd816b42702031f5be0d755323355982d4b7d114 on ryanpage42:master into 2fcd60c30368255dab658b534b4229909ace5d43 on thelinmichael:master.


Clean Changelog for 2.0.0 Release

Merges both PR #311 #295 into one PR and add some details.
Also allows deletion of this outdated wiki page : https://github.com/oauth-xx/oauth2/wiki/Changelog

@xtagon I have updated the milestone.  Now 2.0.0 retains Ruby 1.9/2.0/2.1 compatibility, but includes other breaking changes.
We will then release 3.0.0 to drop those old Ruby.

Seems very sensible to me. Tons of people use this gem and I'm sure they'll appreciate not having surprises. 👍

We need to merge this so that further PRs can modify the change log according to the localized changes in each PR.


Add a .svgoignore file to folder

Is your feature request related to a problem? Please describe.
By whatever reason, I might want to skip some directories within my project.
Describe the solution you'd like
Ideally, this could be done by adding a simple .svgoignore file, similar to .gitignore.
Describe alternatives you've considered
1 - Adding the .svgoignore in a folder would make it skippable.
2 - Adding a generic .svgoignore in the root and specifying skippable paths.

There is --exclude flag added in https://github.com/svg/svgo/releases/tag/v2.3.0 to exclude files by regexp. Can it fit your needs?

I was looking more for something not command-line specified. So at the time I simply run svgo -r . which is what I intend for the large codebase, but different components will use certain SVGs and it is rare but possible that I want to ignore its component/assets/ where the SVGs could be contained for that component.
A simple way would be to create like a component/assets/.svgoignore and svgo would skip the analysis.

If you point me to relevant code that recursively analysis folders, I think I could open a PR with the feature, by simply checking if the directory contains a .svgoignore file or something.

I would prefer to add something like ignore field to svgo.config.js.

But then there would be an exhaustive list of paths to svgs to ignore as well. It is still better than the current command-line exclude tho. If what I say is not possible, then that seems a reasonable solution too!


python3Packages.pyscf: migrate tests from nose to pytest

Description of changes
Closes #263544
The nose test framework seems to be largely dead and upstream PySCF already migrated to PyTest some time ago, so this is our adaption to these changes.
https://github.com/pyscf/pyscf/pull/1249
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.pyscf

The one failing test case on darwin is very wrong, not just a little. I see no good reason for this, as 2200 other test cases apparently pass ... :) I can just disable this one, too, but this seems fishy. However, the alternative is to disable darwin completely, also meh ...

Just disable the test.


Convert linfa-preprocessing Benchmark to Criterion

Benchmarking guidelines can be found here.

@YuhanLiin Can add "help wanted" and good first issue" labels to this?

Hi, I've changed the whitening benchs to criterion. If it looks good I could open a PR and keep going with the rest of benches. You can find the commit in my fork at this link https://github.com/rust-ml/linfa/compare/master...lucas-montes:linfa:master


Fix flakey Batch unit tests

Increase cancellation time and error threshold (for error we actually mostly just care that it was cancelled).

Hi @matthchr, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (matthchr). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


List of parameters for route filter doesn't work

I am trying to implement a filter that accepts multiple parameters, like this:
'before' => 'auth|role:admin,lp_admin,lp_main_tech,lp_tech',

But in my filter function I receive only the first value:
Route::filter('role', function($route, $request, $value) {
  var_dump($value);
});

string(5) "admin"

This is because in callRouteFilter (src/Illuminate/Routing/Router.php:1462 for v4.2) parameters, which are correctly explode into an array before by ',', get flattened with everything else by array_merge:
$data = array_merge(array($route, $request, $response), $parameters);

The resulting array is later being passed as parameters array into call_user_func, which results in all my original parameters passed as separate params to route filter function (..., $value, $value2, $value3...). Judging by the parameters handling code this is not a desired behavior.
I am working around this by using something like this:
Route::filter('role', function($route, $request, $value) {
  $roles = $value;
  if (func_num_args() > 3 && !is_array($value)) {
    $roles = array_slice(func_get_args(), 2);
  }
  if (!is_array($roles)) {
    $roles = [ $roles ];
  }
});

But this is way to brittle. Simple change in source also worked for me:
$data = [ $route, $request, $response, $parameters ];

But this could easily interfere with something somewhere I do not yet know where, so I'm reluctant to fix it this way. Also patching sources is tedious.
As far as I can see in git log, this was the original way it was written by @taylorotwell:

commit a4d8d950e49dc7d0de153513994a23e9343cfd4e
Author: Taylor Otwell
Date:   Fri Aug 23 00:44:33 2013 -0500

Maybe Aug 2013 is not that far away and he could remember and fix it? :)

I thought we were just passing the second param as a 4th param rather than as an array to the 3rd param?

Well, this is how it works now. But wouldn't it make much more sense to send it as an array?
Or this is an artefact now and we have to live with that?
Let me know and I'll add an example in docs.
Sent from my iPhone

On 28 ÿíâ. 2015 ã., at 0:28, Graham Campbell<EMAIL_ADDRESS>wrote:
I thought we were just passing the second param as a 4th param rather than as an array to the 3rd param?
—
Reply to this email directly or view it on GitHub.

https://github.com/laravel/framework/commit/9902e7d5960c6f3a2ad9a187c142ab6dbb384ed1
It should be the expected approach since taylor specifically code the tests that way.

@crynobone I still don't believe that covering inconsistent and unexpected behaviour with tests makes it more consistent and unexpected.
Anyway, since I cannot provide a pull request yet, I'll add an example of current usage to docs.