Use the standard for micropayments

I would like to show the unified QR but I don't want to fall back to onchain payment because the amount in my use case is too small.
According to bip21it isn't possible to avoid the bitcoin address, how is this use case handled?

There's been recent discussion about this in the design community Slack: https://bitcoindesign.slack.com/archives/C01TTD8Q7ST/p1659463066895689

From the discussion for lightning-only payment I think I have to use lightning: URI as defined in https://github.com/lightning/bolts/blob/master/11-payment-encoding.md
Would have been better to cover also this case in the unified QR but I understand it clash with bip21 spec...


Handle the case of new target created for the same view backend

The client can remove a target and create a new one for the same view
backend. In that case we need to unregister the current view backend in
the wayland compositor before registering the one. This patch renames
WS::Instance::createSurface as registerSurface to clarify that it's not
creating a new surface but registering a new one for the given id. Also
ViewBackend::m_id has been renamed as m_surfaceId to clarify that's not
the backend identifier, but the current surface identifier.

This is required by WebKitGTK, when leaving AC mode the renderer target is destroyed, and when entering again a new target is created.


XSS vulnerability in ng2-ckeditor

Hey there,
during a penetration test of an Angular application that uses ng2-ckeditor, I've found a XSS vulnerability that seems to be hidden in the library.
I was able to reproduce it with different versions of Angular, ng2-ckeditor and ckeditor4 – but not yet when using ckeditor4-angular instead of ng2-ckeditor, which is why I assume that the vulnerability is contained in ng2-ckeditor.
In the context of the application I've tested, this vulnerability resulted in stored cross site scripting to potentially any user that uses the affected ckeditor - even though it was exactly implemented as shown in the docs.
I've already tried to reach out to @chymz via email, but haven't received a response within a week.
I have a working demo with screenshots and some explanations on how to reproduce in a private repository. Is it alright, if I just add you (@chymz and @kzimny ) to it so that you can take a look into the demo? I'm unfortunately not very acquainted with debugging Angular libraries.

Hey @kzimny ,
I'm a bit irritated why you have closed the issue without any reaction.
Don't get me wrong: I am not seeking support from you. In the concerned application, we've already managed to fix the vulnerability using a workaround.
However, this is a serious security issue, that you should look into, since it might affect a major part of the users of ng2-ckeditor.
I'm aware that this isn't directly what Github issues are meant to be used for, yet I don't know of a different way to contact you or @chymz .


Mego: Watch crypto(/W*)wolverine

Mego requests the watch of the watch_keyword crypto(/W*)wolverine. See the Metasmoke search here and the Stack Exchange search here.

crypto(/W*)wolverine has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Should be crypto(\W*)wolverine but mobile chat is difficult

Coverage remained the same at 65.71% when pulling 59b79322619b87b739a56f4bd87e373ddb975e8d on auto-blacklist-1518368678.4868503 into a9316610cf6caead7439c8f05759fe3e5d52717f on master.

No longer needed as it is superseded by another pull req.


Routes bug

We currently have pages like so: …/en/about. But the routes located in the configuration either doesn’t work like /about or /en/about. Is there a possible fix for this?
The current homepage /en also doesn’t work with the i18n routes exampled here: routes: ['/','en','/en/','/en']

Hi @Tazi0 have you tried to setup your app like this?

Closing as stale..


Problem with mock_request() function and Context Processors

I am getting a template error when using OEmbed tags, which I believe is due to the behaviour of the mock_request() function in utils.py.
It seems that mock_request() does not add a user object to the request object when it runs the context processors, normally provided by django.contrib.auth.context_processors.auth. This means that context processors of other apps that depend on the existence of a user object throw an exception.
In my case I have django_messages installed, whose context processor requires a user object to be present on Request. When the template is rendered, I get:
Caught AttributeError while rendering: 'HttpRequest' object has no attribute 'user'

Is this addressed as yet? I am getting the same error also, what is the workaround fix for this?

I worked around this by editing the context processor so that it checked for the existence of the User object. But that is very much a workaround and not a fix - if I started using any similar context processors in the project I would have to edit those as well.
I wonder if it would be better to use some other method of passing context to the oEmbed rendering process than the mock_request() approach?

I worked around this issue by adding the context to the client.parse call of the render method in the OEmbedNode class.
in my case I had some extra context_processors being added to the render method for this particular view that needed things out of the request object.  you can look at my fork to see the change.

This is already fixed, have you taken a pull from the repository before adding your comments?

look at issue #21 and you will see the pull request was merged that fixes this issue.

Fixed

forked it today and was getting the error

I think I found the problem, if you use the tag in it's most basic form
{% oembed %}{{ blah.oembed_url }}{% endoembed %}
the height and width are set to None and the context is never added to the kwargs, which is why my patch worked adding the context explicitly to the parse call underneath.  Setting the context in the kwargs outside of the if that checks height and width solves my problem as well and there probably should be a separate if check for template_dir as well.  I created a patch in my fork that does the above.
Although I'm still confused on why you want to create a new RequestContext in the render_oembed method?  this code breaks the use of the oembed filter since you can't have a context passed through.  Our project adds things to the request in the middleware, those things are then used throughout are views and context_processors.  But from what I can tell middlewares don't get run when you create a new RequestContext using a mock_request thus during creation of the request object it tries to run the context_processors but they will fail.
I created another patch that removes those context lines in render_oembed, the parse method underneath already creates a context if one isn't passed in and I just can't find a reason for the new RequestContext but maybe there is a good reason.


Cc.EditBox incorrect positioning on Android and ALWAYS in CAPS

On Android is the normal9SpriteBg placed on expected position but the corresponding native edit control is ALWAYS placed on fixed top position regardless the required/set node position.
Also, the input text is always in CAPS with no option to switch is to lower case.
Regardless what mode/flag is set.
I've tried:
n = new cc.EditBox(cc.size(size.width*0.8, 50), new cc.Scale9Sprite("editbox_bg.png"));
n.setString(this.text);
n.setFontColor(cc.color(251, 250, 250));
n.setDelegate(this);
n.setInputMode(cc.KEYBOARD_RETURNTYPE_DEFAULT);
n.setInputFlag(cc.EDITBOX_INPUT_FLAG_INITIAL_CAPS_SENTENCE);
Env: Cocos 3.5, Samsung Galaxy tablet.
Appreciate your help!

moved to cocos2d-x


How to integrate right way in to Slim?

Hi,
I have used Slim3 now for a week and a half. My application is very simple and it has cli access through slim-cli. What I currently have noticed is that my own custom php classes are not using Slim almost at all, for example I would like to use logger/settings defined in Slim (in dependencies.php) in my own classes, but how do I do that?
Referencing this: https://github.com/slimphp/Slim/issues/1722
Since you removed Slim::getInstance(), your current slim-skeleton app does not show up any example how you get handle to your slim app in your own custom classes.
Could you provide simple examples from that in your skeleton app?
Br,
-Markku

My initial thoughts have been like "I keep handle to $app and each time I construct any of my own php classes, I pass $app in to constuctor"
$instance = new \My\Custom\Class($app);

but this does not look good....

Pass the logger into the constructor of your classes via Dependency Injection.
e.g. https://github.com/akrabat/slim-bookshelf-api/blob/master/api/src/Bookshelf/AuthorMapper.php#L11

Also, this question is best asked on discourse.slimframework.com


"fuck" seems to hang until I press CTRL+C, then it works

Whenever I use fuck, it seems to freeze indefinitely. I press CTRL+C to interrupt and then it seems to "wake up" and do whatever it was it was supposed to do.
> $ git push
fatal: The current branch mybranch has no upstream branch.
 I'm running zsh (with oh-my-zsh) on Ubuntu 15.04. I have another laptop running on the exact same configuration which does not produce this phenomenon.
How can I start debugging this?

As I suspect another rule is making it hangs, I'd suggest you placing a breakpoint in the get_matched_rule() method of main.py and see if you find out which one it is.


Merge Live changes into Master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Consume-Packages/Managing-the-NuGet-Cache.md
:white_check_mark:Succeeded

docs/Create-Packages/Creating-a-Package.md
:white_check_mark:Succeeded

docs/Schema/Target-Frameworks.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add blend mode setting to BlendSpace1D animation node, for parity with BlendSpace2D

A simple patch to bring the blend mode setting from BlendSpace2D to BlendSpace1D.
This feature is useful for animating asymmetrical characters that have different left/right sprites. It also allows sprite-based games to use a similar Idle->Walk->Run blend like you would use in a 3D game.
It's also just an obvious stumbling block, especially since the documentation implies that BlendSpace1D can be used like BlendSpace2D, however, BlendSpace2D works for sprites and BlendSpace1D doesn't.

I understand to some extent what you are intending, but please write the proposal first to explain it to others.. https://github.com/godotengine/godot-proposals

@TokageItLab Proposal filled out, with video: https://github.com/godotengine/godot-proposals/issues/5930

Thank you! Yeah, I think it makes sense to implement such a feature since the current BlendSpace1D only provides the most of same functionality as NodeBlend3.

Superseded by #72396.


ValidationError leaks password if signup fails

When singing up a user with a password, that does not meet the requirements, the error message leaks the password that was used in the signup. I don't know if this is intended. I narrowed it down to the ValidationError::new(...) function. The error message is inserted into the code and the actual message is left empty. Then in the Display implementation for ValidationError there is a check if the error message is empty, which is always the case. Then it skips printing the actual error message, and instead prints the code (which contains the error message, because it is set wrongly) and only shows "Validation error: " with the params (which is the password). I am showing these errors to my api response directly. This way the password pops up on screen, even though it is supposed to be hidden in the signup page.
i know this is actually an issue of the validator page, but i have an idea to avoid this. You could instead of using the display method to show the message, print the actual "code" field of the error. If you don't have enough time to fix this, i could create a pr

Thanks for bringing this to my attention. This is definitely not intended. I don't think that modifying the Display impl of Error will be sufficient to fix this. Since the validator::ValidationErrors is still accessible from the error and it holds the password.

I think we'd have to consider to remove the dependency on validator, though that would be a masive breaking change.

I can help you, if you want. Just notify me what to do/what you would find useful :)


Light mode in settings UI only

Description of the new feature/enhancement
Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

Okay, sure. I'll slap this into the megathread for "theming", #3327. Something like settingsUi.requestedTheme: light|dark|system. Why not.

Note
Walkthrough

[ ] Start by adding a new Theme object for the settings UI:

[ ] SettingsTheme in Theme.idl, quite similar to WindowTheme in the same file
[ ] Add a single ElementTheme RequestedTheme to that runtimeclass.
[ ] In MTSMSettings.h, define a new MTSM_THEME_SETTINGS_SETTINGS, again taking cues from the tab row version. The key for this one should just be "settings"
[ ] Add a THEME_OBJECT(SettingsTheme, MTSM_THEME_SETTINGS_SETTINGS); to Theme.h
[ ] Add the sui theme to the other places theme objects appear in Theme.cpp as well.

[ ] Actually use this new setting

[ ] MainPage::_UpdateBackgroundForMica is probably the right place for this, as it's already trying to set the RequestedTheme for the settings page.
[ ] Instead, use the settings.requestedTheme, if it is set.

I assume the isMicaAvailable check is there for a reason for backward compatibility?

That was introduced in https://github.com/microsoft/terminal/pull/14675. That might have more context
(it's almost 5pm here so I can take a look deeper in the morning)

Description of the new feature/enhancement
Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

I don't think dark and white mode had any good feature so far I use lots of app but I don't find it's better use then brightness.instead of dark and white mode what about adding overview of app so user can get must out of it .


Design an icon for the reader to skip the audio to a certain word on a given page

The current design has the headphones to toggle audio and the pause/play button appears when the audio is toggled on, but Dr. Evans wants a button that the reader can click to then select a word that the audio should start from.

Hey team! Please add your planning poker estimate with ZenHub @vstevens14 @isabellamoak


fix build issue related to nat_traversal dependency

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @Viv-Rajkumar


check_log configuration error

I'm using the check_log to check my logfiles on certain keywords, for example "error". If a new error is written to the log file, sensu gives me an error. After a couple of seconds, the critical error disappears. How should I configure my check in order to check the log file on a word like ERROR and that the error stays as long the error exists in the log file?
My check looks a bit like this:
{
"checks": {
"check_log": {
"command": "/etc/sensu/plugins/check-log.rb -f /opt/test/logs/testDocker.log -q 'ERROR'",
"interval": 10,
"subscribers": ["subscriber1"]
}
}
}

https://github.com/sensu-plugins/sensu-plugins-logs/issues/1


primitives: Move optional dependency to correct place

We keep optional deps in a separate group to non-optional deps, move the new arbitrary dependency.
Internal change only.

No stress, cheers.

I try not to be too pedantic with newer contributors :)

Thanks @tcharding :) Please feel free to be as pedantic as you want with my changes. I'll try to pick up the conventions as quickly as I can, and I don't want to create extra work for anyone

Merge please, this is trivial and has been acked for more than 48 hours.


Update .bash_aliases

Tailored for my own environment

No need to create a pr, I will not merge to master for now.


fix: cdot svm panels

Tested on 8.3.4 grafana

I see that volume.json also has one of the panel having similiar datasource line 4768 . Could you fix that as well part of this. "type": "prometheus",

done


Investigate removing Neutral Passive buildings across the board

Neutral passive buildings are a pointless drain on compute resources because they could just be doodads. Figure out what we can remove (and potentially replace with doodads).

The only thing here I was really worried about was Gilneas (as in, it might look bad with no buildings). But I actually think it's fine (see attached), so I'm going to go ahead and implement this.

Closed by https://github.com/AzerothWarsLR/WarcraftLegacies/commit/fcb256f0e66289356bef12607b2d1a3f9db94bf4


go/build: deps_test.go should check transitive dependencies?

If I add
import _ "net/smtp"

to net/http/client.go, then deps_test.go fails.
If I add the same line to net/http/internal (which is imported by net/http/transport.go), then deps_test.go doesn't complain.  It seems like deps_test.go should still catch this somehow.
Possible ideas: check a package's transitive dependencies rather than just its immediate dependencies, or check that all of its immediate dependencies are also listed in pkgDeps.

Or add net/http/internal to the table and lock down its dependencies.

That would be my second suggestion ("check that all of its immediate dependencies are also listed in pkgDeps"), but my point is that deps_test.go should have caught this.  It's also missing at least image/internal/imageutil, mime/quotedprintable, internal/singleflight, internal/mime, container/list, internal/syscall/unix, and internal/syscall/windows, so it's blind to transitive dependencies added via those packages too.

the dep test is designed before the internal package thing, a time
when adding packages to std packages is way harder.
I think the problem is that when a new internal package is introduced,
its dependency must be locked down in deps_test.go, but that was
not followed.
deps test just need to caught any package not explicitly locked down.

Yes, any package not listed in the map should be treated as having no allowed dependencies.
Good find.


ionic app doesn't render the youtube video content in iframe (iOS)

he ionic app receives it's content from an external API. The content includes HTML contents with iframe to display the youtube/vimeo videos. We have made a angular directive to render the iframe content. Everything works fine in Android, but iFrame doesn't generate any content except empty Html and body tags.
Here is the generated iframe content in iOS devices,

 #document

Hello! Thanks for opening an issue with us! Most likely, this is caused by an apple security restriction. Would you mind taking a look at this stack overflow answer http://stackoverflow.com/a/36440562 and adjusting your whitelist accordingly? Thanks!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Hi jgw96, I have a problem here. When I run the app the video shows up but it can not be played. The following is the code


Change libzip2 to libbzip2 in README.md

I am not an expert - but I expect the lib is libbzip2 and not libzip2 - a quick google seems to suggest I am right :)
Feel free to merge - or to discard!

Thanks for fixing this!


python311Packages.openai: 1.38.0 -> 1.39.0

Description of changes
Update to latest version. No changes that effect build.
Diff: https://github.com/openai/openai-python/compare/refs/tags/v1.38.0...v1.39.0
Changelog: https://github.com/openai/openai-python/releases/tag/v1.39.0
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Make skill data sources configurable

Refactor skill to simplify logic
Make API skills configurable
Handle returned icon path in idle.qml

As uncovered by @ChanceNCounter this PR prematurely moved to an API method for datetime. Should this PR wait for an update to the datetime skill, or implement the legacy import method? https://github.com/OpenVoiceOS/skill-ovos-homescreen/blob/adb9a611b144dada656b8a8990c308c97c02cae7/init.py#L62

Keep this branch, maybe, and patch it later? Just my 2 cents

Keep this branch, maybe, and patch it later? Just my 2 cents

I spoke too soon. I did incorporate the patch, just incorrectly. Should be fixed with the previous 2 commits.


Support filenames that include addressable content sha@ strings

Need to validate the deploy/push logic works with addressable content sha's and look into validating repodigests on push based on what is referenced in a sha reference.

nice - just now check after the push to actually verify.
maybe an e2e or at least enough unit if poss to cover these cases.


Raise an exception if MediaUploadFile file path is inacessible

See #893. Will need more investigation to determine if this is possible in the client.

Fixed in #1127.


UI/Backend diagram

We really need to do some planning for the design of the UI. I would like to get a UML diagram of some sort done that shows how the pages and content are managed.  Once we have a general outline of what the site design will look like we can start implementing the components. Overall this should save time as we won't be just working off the top of our heads which is difficult in a group setting. This is mainly for Richard and I but welcome any input Logan has.

[x] Draw up UML diagram with UI design.

What kind of UML diagram are you looking for? I'm not sure which kind applies the best to what you're trying to do, but I only know two off the top of my head.

A UML sequence diagram would be the most likely I think.

I ended up just more or less using a class diagram to show how the challenge sets and challenges are connected. I will update it if we make any changes.


Update desktop Homepage to include production toggle in settings

The Homepage route ('/') for large screens is updated to include the modal-opening-gear-icon rather than wallet-mode-toggle only. It's only possible to switch between environments and toggle wallet mode from Homepage on desktop.
When navigating from Homepage to /login on desktop, both environment and wallet mode parameters are preserved.
Header logo link is updated to also carry both parameters.

Something is off, see ;:


feature/maintenance_window - add argument maintenance_window  and usage in README

add argument maintenance_window, useful for the production environment.
add argument snapshot_identifier, that you specify whether or not to create this database from a snapshot.
update usage in README

Why did you close this one? To my opinion it looks good to be merged.

@antonbabenko
I need to double check if new variable snapshot_identifier works properly.  After run with variable snapshot_identifier, I have to remove the variable from the code, otherwise, the codes will keep creating a new database with that snapshot.
terraform apply -varfile=config/dev.tfvars (without variable `snapshot_identifier`)
terraform apply -varfile=config/dev-snapshot.tfvars (with variable `snapshot_identifier`)

I also need to make sure if database's username and password work with snapshot_identifier or not, if I provide all of them together.
scenario:

create a new database directly
create a new database with snapshot
exist database is running, after add variable snapshot_identifier, do the codes work to destroy old database and create a new database with snapshot properly.

I am going to remove the change snapshot_identifier, and only keep the new variable maintenance_window. Later if I have the result, will raise a separate PR for variable snapshot_identifier

@antonbabenko
You should be fine to review it now.


Teacher/Student Parameter ratio

Hey @HobbitLong, nice paper. Do you have any guidelines on the effectiveness of the approach as the number of parameters decrease in the student model vs the teacher (same architecture) and what a sensible ratio is a good starting point?

Hi, @iiSeymour ,
This is an interesting question! I haven't got chance to look into it, but my guess is somewhere between 2~10 for teacher-student ratio.

Great, thanks.


Added helper function to test for bound parameters

Adds helper function to test whether a parameter was bound, independent of the actual value bound

Ouuu SO GOOD! Need to announce to the channel


Add ability to specify physical device in Keyboard Manager

Description of the new feature / enhancement
It would be great if we had the ability to specify the input keyboard in the Keyboard Manager.  Something similar to the attached image.

Scenario when this would be used?
I have a half-keyboard which I use via LuaMacros to bind to the hardware identifier and capture keypresses on that keyboard ONLY and then perform an action (like triggering a different key combination).  Using tools like LuaMacros is much more complicated for such a basic task.  If Keyboard Manager had the ability to bind to certain physical devices that would be absolutely wonderful.
Supporting information
No response

/dup #19911


Parse query string

Parse query string and include the result to response JSON.

https://github.com/ntalbs/reflexive/commit/68b8736a084080e34c845d25c8a3f71c0e5a83a3


refactor: display sequential audit rule IDs

Replaced the existing audit rule ID display with sequential numbering to avoid gaps in the IDs when rules are deleted.
The displayed ID now reflects the rule's position in the list, starting from 1 for the first rule, 2 for the second, and so on.

No, there is a reason it should be ID as is in db


🐛 [firebase_messaging] cannot handle event when "notifications" object was null

Bug report
i can't handle message event when i tried to set notifications object to null via REST API.
I purposely made the object null, so i can replace default notifications from the plugin to flutter local notification plugin.
it works when it comes from backgrounds, but when i currently opening my app, i can't get my print inside the onMessage listener.
Steps to reproduce
Steps to reproduce the behavior:

setup fcm correctly like the documentation says.
tried to send object like the code json below. there is no object for notifications. because i do it purposely.
{  "data": {  "id": 34463,  "title": "INTERNAL ORDER",  "body": "satu transaksi internal order butuh approval segera!",  "name": "INTERNAL ORDER" }, "registration_ids": [ "_my user token here_" ] }

Expected behavior
i could see my print inside onMessage listener.

@billbull21
Based on the use case you described, ie, not sending notification object, in real time scenario, this may not occur, so I am not sure if you are verifying a valid scenario. I suggest you to ask this question on support channels like StackOverflow. Closing from here. If you disagree or think this is a bug in the plugin, write in comments and I'll reopen it.

@darshankawar this is actually real time scenario, I am using chat 3rd party messaging service which sends push notifications with null notification object and flutterfire can't handle it, onMessageOpenedApp is not called


outref<_> is not available in Mono 5.16

Using latest stable Mono distribution on macOS I cannot build a project that uses outrefs.
module ClassLibrary23

let foo (x: outref<int>) =
    ()

Library.fs(3, 13): [FS0039] The type 'outref' is not defined.

eugene@unit-937:ClassLibrary23$ mono --version
Mono JIT compiler version <IP_ADDRESS> (2018-06/6e48ad4f7b1 Wed Oct  3 14:05:19 EDT 2018)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:           normal
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	Interpreter:   yes
	LLVM:          yes(3.6.0svn-mono-master/0b3cb8ac12c)
	GC:            sgen (concurrent by default)

The update to F# 4.5 is in progress.
Just don't use outref in code to compile on Mono until then (or use .NET SDK F# compiler to compile)

See tag 10.2.3 for update to F# 4.5


05/03/2018 23:51 : Create Pull Request for branch master -> prTesting1_2018050323

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Setting an xindex causes .where to fail

What happened?
I'm trying to use more xindex rather than MultiIndex, in pursuit of the new world :)
But it seems that that causes .where to fail?
MCVE & traceback below
What did you expect to happen?
I don't see why this shouldn't work — possibly I'm misunderstanding something?
Minimal Complete Verifiable Example
import numpy as np
import xarray as xr
ds = xr.tutorial.open_dataset("air_temperature")

ds = ds.assign_coords(lat2=ds.lat + 2).set_xindex('lat2').where(lambda x: x)

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.
[X] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In[4], line 1
----> 1 ds = ds.assign_coords(lat2=ds.lat + 2).set_xindex('lat2').where(lambda x: x)

File ~/workspace/xarray/xarray/core/common.py:1233, in DataWithCoords.where(self, cond, other, drop)
   1230     self = self.isel(**indexers)
   1231     cond = cond.isel(**indexers)
-> 1233 return ops.where_method(self, cond, other)

File ~/workspace/xarray/xarray/core/ops.py:179, in where_method(self, cond, other)
    177 # alignment for three arguments is complicated, so don't support it yet
    178 join = "inner" if other is dtypes.NA else "exact"
--> 179 return apply_ufunc(
    180     duck_array_ops.where_method,
    181     self,
    182     cond,
    183     other,
    184     join=join,
    185     dataset_join=join,
    186     dask="allowed",
    187     keep_attrs=True,
    188 )

File ~/workspace/xarray/xarray/core/computation.py:1252, in apply_ufunc(func, input_core_dims, output_core_dims, exclude_dims, vectorize, join, dataset_join, dataset_fill_value,
keep_attrs, kwargs, dask, output_dtypes, output_sizes, meta, dask_gufunc_kwargs, on_missing_core_dim, *args)
   1250 # feed datasets apply_variable_ufunc through apply_dataset_vfunc
   1251 elif any(is_dict_like(a) for a in args):
-> 1252     return apply_dataset_vfunc(
   1253         variables_vfunc,
   1254         *args,
   1255         signature=signature,
   1256         join=join,
   1257         exclude_dims=exclude_dims,
   1258         dataset_join=dataset_join,
   1259         fill_value=dataset_fill_value,
   1260         keep_attrs=keep_attrs,
   1261         on_missing_core_dim=on_missing_core_dim,
   1262     )
   1263 # feed DataArray apply_variable_ufunc through apply_dataarray_vfunc
   1264 elif any(isinstance(a, DataArray) for a in args):

File ~/workspace/xarray/xarray/core/computation.py:509, in apply_dataset_vfunc(func, signature, join, dataset_join, fill_value, exclude_dims, keep_attrs, on_missing_core_dim, *ar
gs)
    505 objs = _all_of_type(args, Dataset)
    507 if len(args) > 1:
    508     args = tuple(
--> 509         deep_align(
    510             args,
    511             join=join,
    512             copy=False,
    513             exclude=exclude_dims,
    514             raise_on_invalid=False,
    515         )
    516     )
    518 list_of_coords, list_of_indexes = build_output_coords_and_indexes(
    519     args, signature, exclude_dims, combine_attrs=keep_attrs
    520 )
    521 args = tuple(getattr(arg, "data_vars", arg) for arg in args)

File ~/workspace/xarray/xarray/core/alignment.py:947, in deep_align(objects, join, copy, indexes, exclude, raise_on_invalid, fill_value)
    944     else:
    945         out.append(variables)
--> 947 aligned = align(
    948     *targets,
    949     join=join,
    950     copy=copy,
    951     indexes=indexes,
    952     exclude=exclude,
    953     fill_value=fill_value,
    954 )
    956 for position, key, aligned_obj in zip(positions, keys, aligned, strict=True):
    957     if key is no_key:

File ~/workspace/xarray/xarray/core/alignment.py:883, in align(join, copy, indexes, exclude, fill_value, *objects)
    687 """
    688 Given any number of Dataset and/or DataArray objects, returns new
    689 objects with aligned indexes and dimension sizes.
   (...)
    873
    874 """
    875 aligner = Aligner(
    876     objects,
    877     join=join,
   (...)
    881     fill_value=fill_value,
    882 )
--> 883 aligner.align()
    884 return aligner.results

File ~/workspace/xarray/xarray/core/alignment.py:574, in Aligner.align(self)
    572 self.find_matching_indexes()
    573 self.find_matching_unindexed_dims()
--> 574 self.assert_no_index_conflict()
    575 self.align_indexes()
    576 self.assert_unindexed_dim_sizes_equal()

File ~/workspace/xarray/xarray/core/alignment.py:318, in Aligner.assert_no_index_conflict(self)
    314 if dup:
    315     items_msg = ", ".join(
    316         f"{k!r} ({v} conflicting indexes)" for k, v in dup.items()
    317     )
--> 318     raise ValueError(
    319         "cannot re-index or align objects with conflicting indexes found for "
    320         f"the following {msg}: {items_msg}\n"
    321         "Conflicting indexes may occur when\n"
    322         "- they relate to different sets of coordinate and/or dimension names\n"
    323         "- they don't have the same type\n"
    324         "- they may be used to reindex data along common dimensions"
    325     )

ValueError: cannot re-index or align objects with conflicting indexes found for the following dimensions: 'lat' (2 conflicting indexes)
Conflicting indexes may occur when
- they relate to different sets of coordinate and/or dimension names
- they don't have the same type
- they may be used to reindex data along common dimensions

Anything else we need to know?
No response
Environment

INSTALLED VERSIONS
commit: 0c6cded4aa37337570ca788d1510e1063e713e10
python: 3.11.10 (main, Sep  7 2024, 01:03:31) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]
python-bits: 64
OS: Darwin
OS-release: 23.6.0
machine: arm64
processor: arm
byteorder: little
LC_ALL: en_US.UTF-8
LANG: None
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.14.3
libnetcdf: 4.9.2
xarray: 2024.9.1.dev32+gece582dd
pandas: 2.2.2
numpy: 2.0.2
scipy: 1.14.1
netCDF4: 1.7.1.post2
pydap: None
h5netcdf: 1.3.0
h5py: 3.11.0
zarr: 2.18.3
cftime: 1.6.4
nc_time_axis: 1.4.1
iris: None
bottleneck: 1.4.0
dask: 2024.8.2
distributed: 2024.8.2
matplotlib: 3.9.2
cartopy: None
seaborn: 0.13.2
numbagg: 0.8.1
fsspec: 2024.9.0
cupy: None
pint: None
sparse: None
flox: 0.9.12
numpy_groupies: 0.11.2
setuptools: 69.2.0
pip: 24.0
conda: None
pytest: 8.3.3
mypy: 1.11.2
IPython: 8.24.0
sphinx: None

#7695 is related

Ah great, I think this is a dupe of that, so I'll close.
Though this is a nice example where, IIUC, the behavior doesn't make sense — they're exactly the same indexes, they came from the same object...


[FEAT]: In case we need to create custom LEGO components...

Description
Let's collect some 3D models which may be customized and 3D-printed
Additional Information
No response

Here is the first:

MyBeam: Technic-compatible objects

Adam Mueller has designed OLLA (OAK-D-Lite LEGO Adapter) - a custom piece to attach the OAK-D-Lite to LEGO Technic pieces. OLLA design is available on https://github.com/muelleradam/OLLA under the MIT License

I have also come across (https://www.facebook.com/commerce/listing/1374649069643890/) this clever design to measuring LEGO parts:

Moving to next week until we get a better understanding whether we do need custom pieaces

At the moment we do not plan to need extra pieces for the Phase2 of the OpenCV Spatial AI Contest.
Moving issue to backlog


python3.pkgs.pyopencl: add missing build dependencies

Description of changes
I can't easily test this, because these missing dependencies only fail on staging (and now on staging-next), and I don't have a Linux machine that can build the world. However, based on the Hydra message from a previous python-updates run and perusing the pyproject.toml, these dependencies should be required.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python310Packages.pyopencl python311Packages.pyopencl

Sorry, I just merged the version bump, and it caused a conflict.

Sorry, I just merged the version bump, and it caused a conflict.

No problem! It's because I did some minor reformatting that wasn't necessary. Also, a better idea to merge the bot's PR, as I don't know if it knows how to resolve merge conflicts.

@ofborg build python310Packages.pyopencl python311Packages.pyopencl


TextField Input emoticons display abnormally

Steps to reproduce
https://github.com/flutter/flutter/assets/33706740/1f016490-0cf5-4ad2-b229-c58945da174d
1.When Input emoticons display abnormally
Expected results
Input emoticons display normally
Actual results
1.When Input emoticons display abnormally
Code sample
Code sample
TextField(
        controller: textController,
        decoration: InputDecoration(
            isCollapsed: true,
            border: InputBorder.none,
            focusedBorder: InputBorder.none,
            hintText: placeholder,
            hintMaxLines: 3,
            hintStyle: const TextStyle(fontSize: 14, color: AppColors.grey777)
        ),
        maxLines: null,
        style: const TextStyle(fontSize: 14, color: Colors.black, height: 1.5),
      )

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.4, on macOS 13.6 22G120 darwin-arm64 (Rosetta), locale zh-Hans-HK)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] Connected device (5 available)
[✓] Network resources

• No issues found!

Hi @WuChuanRong
I checked this on a simple TextField (without any properties) on iPhone 7, iOS 15.8 but can't reproduce this issue. I see the video you are providing is on a production app, can you try checking this on a simple sample code with an empty TextField?
Also, which device are you checking on? (OS, model)

Hi @huycozy If you just express your expression, the numbers will appear.

Can you please be more specific with more information? Please confirm questions above. Thanks!
Here is my demo with my device (it works fine without issue):

Demo
https://github.com/flutter/flutter/assets/104349824/8f115d0a-b5a6-498c-bd46-97352ad66d7b

Hi @huycozy flutter version 3.13.4, iphone emulator iphone 15 Pro Max - iOS 17.0

I just checked this on the same iOS version device (17.0) but the issue doesn't appear.

Demo

Does this issue only appear on your project or also on a minimal sample code? Could you try the minimal sample code below on a new Flutter project and confirm?

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
            child: TextField(
          decoration: InputDecoration(
              isCollapsed: true,
              border: InputBorder.none,
              focusedBorder: InputBorder.none,
              hintText: 'placeholder',
              hintMaxLines: 3,
              hintStyle: TextStyle(fontSize: 14)),
          maxLines: null,
          style: TextStyle(fontSize: 14, color: Colors.black, height: 1.5),
        )),
      ),
    );
  }
}


pkgs.extend for adding overlays

Motivation for this change
This is something that I have found useful in a test.
For example, you have one pkgs at your disposal and you want to make sure that it gets passed around correctly by some code. So you add an overlay and run the thing in a way that depends on the extra overlay. Now you know it gets passed around properly.
In practice I recommend that people call Nixpkgs once for performance and
simplicity. The inline documentation mentions this too.
That doesn't mean that pkgs.extend shouldn't be an option for those who need it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@Ericson2314 you added a comment in the code that indicates nixpkgsFun should be avoided. Is this a good replacement?

Would like to see it merged soon. cc @nbp

By Nixpkgs documentation, I mean the documentation which appears on https://nixos.org/ .

@Ericson2314 no problem, thanks for reviewing :)

Can we do like
stage-fixpoint // {
  extend = ...;
  appendOverlays = ...;
}

so packages in nixpkgs cannot refer to this?

I recognize your concern about this feature. However, doing this would make pkgs.extend harder to use. For example, pkgs.pkgs.extend will not exist, breaking the pkgs passed by callPackage. It will also break (pkgs.extend f).extend g, and it will break my motivating use case, which is a test in Nixpkgs that checks whether pkgs is passed around properly.
Besides, if pkgs.extend doesn't 'just work', it could steer users to solutions that are worse, like calling Nixpkgs again but forgetting to set the system or config argument.
If it really is a problem, I suggest disabling it for Hydra only. You can use extend to kill itself:
nix-repl> (pkgs.extend (self: super: { extend = abort "Don't use pkgs.extend inside Nixpkgs"; })).extend
error: evaluation aborted with the following error message: 'Don't use pkgs.extend inside Nixpkgs'

However, I do not recommend disabling it.

Only other concern is for cross compilation, this cannot be used to change build tools, but maybe that's a feature not a bug :).

Then isn't that a general characteristic of overlays?

@roberth well argued. Then instead, could you take a look at the config thing used by ofborg that makes nixpkgs tested without aliases, and try to immitate it here so ofborg can be made to do the same for extend?

@Ericson2314 I've made a PR to ofborg. Does this satisfy your request?


Get bearer token detail

Hello team,
This PR is about adding a note so that it is easier to know which documentation to check in order to get the token.
Since the token is an important header in all these calls, I have added the note here as it is a central place for all the methods listed.
Also an extra cell has been removed from a table which causing issues in PRs
Regards,
Mervyn

#ready-to-merge

#ready-for-content-review

ready for content review

Hello @Lauragra , how do I add the ready for content review tag?

Hello @Lauragra , how do I add the ready for content review tag?

@mervynmanilall , this is the external mirror of our authoring repo. This repo is available for external people to contribute to the docs. I assume that you're external, in which case, we'll manage this PR as an external PR and review accordingly. Thanks for contributing.

Hello @Lauragra
Thanks for the info.
Do you have any update please?


viewer.ready is undefined

What happened?
viewer.ready is undefined instead of a boolean as indicated in the documentation

Reproduction steps

Create a new Viewer object.
check the ready property

Reports undefined.  Expectation is true or false
Sandcastle example
https://sandcastle.cesium.com/https://sandcastle.cesium.com/#c=bY7NCsIwEIRfJeTUgmzw3LQIXgUPgqdc0nTV4DYpSdpSn97+XETd28zON4zxLiY2WBwxsJI5HNkRo+1buK5eprhZ9dG7pK3DoHheKGdmzhMC+Xu20RBQN1Ne8B2XMU2ElXJsvYNtOx8S6wNlACJh25FOGEXdmycmMDEulUtUik9UNnZgtin/bGCGdIzz59YTXewLFa+kmPM/KHndWHc/DxhIT0vssa9OmwkAUszyP5m8p1qHr+Y3
Environment
Browser: Checked Firefox 124.0.1 and Chrome 123.0.6312.58 on Linux
CesiumJS Version: 1.116
Operating System:  22.04.1-Ubuntu

It seems this was an issue of docs, not implementation. Two properties of Terrain were incorrectly attributed to the Viewer


try to add the Kotlin module

What this PR does / why we need it?
try to add the Kotlin module
Summary of your change
import com.alibaba.fastjson2.*

val referUser = reference<User>()
val user=  referUser.parseObject(
            """{"id":1,"name":"kraity"}"""
)

val referUserList = reference<List<User>>()
val list = referUserList.parseObject(
            """[{"id":1,"name":"kraity"}]"""
)

val user =  parseObject<User>(
            """{"id":1,"name":"kraity"}"""
)

val userText = use.toJSONString()

Please indicate you've done the following:

[ ] Made sure tests are passing and test coverage is added if needed.
[ ] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report

Merging #212 (1635a9a) into main (6ca7345) will decrease coverage by 1.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #212      +/-   ##
============================================
- Coverage     70.60%   69.48%   -1.13%
+ Complexity     9114     8987     -127
============================================
  Files           417      419       +2
  Lines         45722    45577     -145
  Branches       9252     9214      -38
============================================
- Hits          32282    31668     -614
- Misses         9681    10175     +494
+ Partials       3759     3734      -25

Impacted Files
Coverage Δ

...tlin/src/main/kotlin/com/alibaba/fastjson2/JSON.kt
0.00% <0.00%> (ø)

...main/kotlin/com/alibaba/fastjson2/TypeReference.kt
0.00% <0.00%> (ø)

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
30.18% <0.00%> (-49.06%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
40.25% <0.00%> (-30.07%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
65.06% <0.00%> (-15.73%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
73.41% <0.00%> (-8.87%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.04% <0.00%> (-6.23%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
55.06% <0.00%> (-5.07%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterUTF16.java
73.55% <0.00%> (-4.56%)
:arrow_down:

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca7345...1635a9a. Read the comment docs.


ignored: does not seem to have an effect

Hi @adamrtalbot
Thanks for this Action. I am using it in a custom modules repo where I am using ignored: (https://github.com/GallVp/nxf-components/actions/runs/10032138272/workflow?pr=7#L83) and it does not seem to have an effect (run: https://github.com/GallVp/nxf-components/actions/runs/10032138272/job/27723406859?pr=7). Can you kindly check if I am making some mistake?
I am trying to ignore all modules located under nf-core-modules. These modules are from upstream and are used for hybrid sub workflows.

Thank you for the reply @adamrtalbot
Yes, I explored the python code on my local machine and it worked. But it does not work with the GHA. I am at loss to understand why, though.
Now I have changed it to ignored: "./nf-core-modules/*" and it is still not working. Please see, this PR: https://github.com/GallVp/nxf-components/pull/24

I have also tried a few other glob patterns but none of them seem to work. This is the log:
DEBUG:root:Found changed files:[PosixPath('/github/workspace/nf-core-modules/modules/nf-core/gt/stat/tests/main.nf.test'), PosixPath('/github/workspace/.github/workflows/test.yml'), PosixPath('/github/workspace/nf-core-modules/modules.json')]

I'll create a fork and add additional debug statements to see if I can catch the culprit.

All the globs I tried failed: ./nf-core-modules/*, ./nf-core-modules/**, **/nf-core-modules/**, etc.
Finally decided to move away from the Path.match function and instead started using the fnmatch.fnmatch function which works with both nf-core-modules/** and nf-core-modules/*. It does not work with ./nf-core-modules/*. The reason is that the actual path that is checked is: nf-core-modules/modules/nf-core/gt/stat/tests/main.nf.test
fnmatch.fnmatch(str(filepath), ignored_path)

I have added a pull request. Thank you for your help.


Add default meta when resource is created

Right now, on create success, the resource is created, but no metadata is associated with it.

Woops, wrong repo lol


Fail snapshot if workflow version contains images specified with no tag, latest tag, or parameter

#4275

The snapshot fails and throws an error if there are any images specified with no tag, latest tag, or parameter.
I also check if a workflow version's tooltablejson in the DB contains the field specifier. If it doesn't, then a new tooltablejson is created, which will contain specifier. This new tooltablejson is saved to the DB if the workflow version isn't frozen.
Added a test to check that snapshots fail for each type of "invalid" image.

Added a new repo to dockstore-testing for this purpose: https://github.com/dockstore-testing/hello-wdl-workflow

Screenshots of the error in the UI:

Is there a separate UI ticket for this feature?

Not yet, but its a good idea.

Is there a separate UI ticket for this feature?

Not yet, but its a good idea.

Created a UI ticket for this feature: https://github.com/dockstore/dockstore/issues/4291

May want to re-run testBitbucketDirtyBit , might be transient


Finalize pydantic v2

Current docs build based on v2: here
There is still some work to do until the release for v2. Following points have to be done:

[x] Fix failing tests for python 3.7/3.8
[x] Fix failing sphinx build test
[x] Check entire documentation for pydantic v1 incompatibilities

[x] Remove obsolete config options from rst in examples
[x] Adjust to changed naming conventions like root validator -> model validator

[x] Document changed behavior from v1 -> v2 regarding autodoc_pydantic
[x] Update changelog
[x] Remove compatibility layer from v1 versions in testing modules
[x] Fix linting issues
[ ] Provide release candidate for testing
[ ] Add new contributors

@awoimbee & @PriOliveira feel free to review or to provide any other code contributions.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main-2.x@c0b011a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main-2.x    #162   +/-   ##
==========================================
  Coverage            ?   0.00%
==========================================
  Files               ?      12
  Lines               ?    1040
  Branches            ?       0
==========================================
  Hits                ?       0
  Misses              ?    1040
  Partials            ?       0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@all-contributors
please add @awoimbee for review, userTesting, code, test.
please add @PriOliveira for review, userTesting.
please add @effigies for bug.

@all-contributors please add @PriOliveira for review, userTesting

@all-contributors please add @PriOliveira for review, userTesting

@all-contributors please add @PriOliveira for review, userTesting

@all-contributors please add @PriOliveira for review, userTesting


add support for fish parser

https://github.com/quentinlintz/cmdtop/issues/6
@quentinlintz could you please review?

Sorry for the late review! Could you check off fish parser in the README Roadmap please?

No problems at all :)
Added changes in the README. Thank you !

I received this comment on Reddit about a fish parser, curious what you think about this:

just a note: statistics like these won't work (well) with the default fish, because unlike bash history, fish will just overwrite the timestamp when you use the same command again. Eg. in .bash_history you might have 50 lines with cd or ls (without arguments), so you can count them. But in fish when you've done ls 50 times, you only have 1 line with the most recent timestamp. (Of course ls dirX and ls dirY are recorded separately, but it still skews the statistics).

Probably no way around it and we'll have to deal with the way fish records command history?

Hmm I wasn't aware of this limitation, I remember testing this out on my machine
I'll check again and get back to you.

We could merge anyway since it's probably a limitation we'll have to deal with if we want to support fish.

Heyy @quentinlintz I'm so sorry Its been a busy week for me at work, I didn't get time to check on this could you give me this week to investigate and push out a PR? ( if this is something we can tackle now )

lets merge this as you earlier suggested and I'll create a separate issue to track this limitation....would that be okay @quentinlintz ?


Fix #208: Implement possession signed endpoints with using token based authentication

Both new token endpoints replace the old non-token endpoints.

I will wait for a while with merging these - we have customer playing with the original endpoints and signature based authentication (not in production) and we need to synchronize the information with the customer...

OK, another brief discussion about these changes.

We currently have a customer waiting for the push service registration to be implemented.
This customer will not be able to update to (still non-released) mobile libraries 0.17.0 in time.

Therefore, we need to keep both endpoints and we just need to clean up the naming a bit...

Suggestion: Let's move push registration related endpoints into separate controller, so that we can have some nice URI, like /api/push/device/register/token and /api/push/device/register/signature...


RPC gasPrice parsing is not longer JSON compliant

Quite a lot of JS code (as well as my golang code that uses the JSON RPC) is now broken because of this backward incompatible change that modified how gasPrice is parsed:
https://github.com/qtumproject/qtum/commit/e774728ea8644f4ec52eb01604b28df94af119be#diff-df7d84ff2f53fcb2a0dc15a3a51e55ce
Can we support gasPrice specified as a JS number, which is more natural than going back and change gasPrice to strings in libraries.

Is there a way to fix the problem a remain JSON number compliant?
Perhaps we can check that if the type is number, use JSON number from Univalue as is. If type is string, use ParseMoney.

We'll look into that

Fixed in https://github.com/qtumproject/qtum/commit/f5ddd5d741487e2d335fa2460cdf9dca45e46587


Add flag for disabling css output

It would be nice to have a flag that disables css output, something like --no-css or --disable-css. This would be helpful in cases where you have to re-subset font files and your @font-face rules are already defined elsewhere.

I’m a little confused by this. --css is opt-in (not enabled by default)? So if you don’t include it with your command, it shouldn’t output the css blocks?

When I run glyphanger in a local directory containing fonts (glyphhanger --subset=*.woff2), a css file gets generated. I wasn't aware of the --css option, but seems like it should only be created if the option is included in the command.
Really happy with glyphanger btw; thanks for your work on this!

Oh, yes I agree and can confirm this is happening. I think it’s a bug.

Will be included with the 3.1.0 release.


Sense can´t be stopped with "sc query sense"

hi,
there is a flaw in the documentation
sc query sense
only querries the service
and we can´t stop the service with stop-service sense

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef5b23fe-37ce-e3b0-ad76-55a416eaa865
Version Independent ID: 26becb70-47ff-38fe-592f-99d84f6aba12
Content: Onboard non-persistent virtual desktop infrastructure (VDI) devices
Content Source: microsoft-365/security/defender-endpoint/configure-endpoints-vdi.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

mistake


Optional log/assert hooks implemented in Zig?

I've been hanging onto these local changes for a while and figured I should offer them forward.
Setting the Sokol log macro to use a log function implemented in Zig means that if you happen to use std.log.info your formatting will look all nice and consistent.
Even more helpful is implementing the assert hook in Zig, since then Sokol validation errors will hit the Zig panic handler and show you a nice stacktrace even if you aren't attached in VS.
I saw other PRs/issues talking about adding a config/options struct for buildSokol which I imagine would interfere, so this is more of a suggestion/feature-request PR 🙂

It's better to wait with this until I got around to implement the new combined error reporting and logging from sokol_spine.h into all sokol headers (see here: https://github.com/floooh/sokol/blob/2236713b5eb247907a1a0a8c0b4c44f16e472909/util/sokol_spine.h#L827-L875)
...in debug mode, this allows to output 'clickable' and human-readable error messages with file path and line number, and in release mode, it won't contain human readable strings (only error code) to not bloat the executable with unnecessary string data.

It looks like the logging functions are in place now, so it might be a good time to return to this.
Given the logging changes, the logging part of the PR is probably no longer necessary and in my implementation I actually go in the other direction (redirecting zig logging to sokol_log), because sokol_log is better suited to various platform output functions, while std.log just goes to stderr. But the panic/assert redirect is still valuable, because Zig's @panic prints a nice stacktrace, while the current code just aborts.
Regarding the implementation, just a small nitpick about this line:
#define SOKOL_ASSERT(c) sokol_zig_assert((unsigned int)c, #c)
wouldn't it be better to do the if check right in the macro? It might be sligtly more performant/optimizable that way.


git fetch doesn't respect branch filters

Agent Version and Platform
Current agent version: '2.177.0'
OS of the machine running the agent? Ubuntu
Azure DevOps Type and Version
dev.azure.com
If dev.azure.com, what is your organization name? https://dev.azure.com/join-trine/Trine
What's not working?
Before this version git fetch locked like this:
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=50 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/6014/merge:refs/remotes/pull/6014/merge

With this version it looks like this:
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=50 origin +4d3d95f3be63fdca5a3951217aa9bf2e58dbdc2f:refs/remotes/origin/4d3d95f3be63fdca5a3951217aa9bf2e58dbdc2f

I.e. the list of branches has changed. This causes build errors for us, since we rely on some specific branches being available.

Workaround seems to be to set VSTS.DisableFetchByCommit: true.

We updated the GitHub behavior to match Azure Devops which does a checkout by commit.
Checkout by commit is more specific since the branch can change between builds.
3 options to workaround:

VSTS.DisableFetchByCommit: true gives you the old behavior
Add the specific fetch via a different step in your build
Change your downstream behavior to be commit, instead of branch specfic


cargo crev diff

Easily show a diff between:

last reviewed version and now
last trusted version and now
two arbitrary versions

Pushed, in the basic versions at least. Still requires -- for stuff like -u, but works OKish already. Waiting for help here https://github.com/TeXitoi/structopt/issues/153#issuecomment-502344845

I've pushed initial support for differential reviews:
-----BEGIN CREV PACKAGE REVIEW-----
version: -1
date: "2019-06-17T23:58:20.220399363-07:00"
from:
  id-type: crev
  id: FYlr8YoYGVvDwHQxqEIs89reKKDy-oWisoO0qXXEfHE
  url: "https://github.com/dpc/crev-proofs"
package:
  source: "https://crates.io"
  name: byteorder
  version: 1.3.1
  revision: 64c03fb383289f8e42b2892bf72297879777a238
  digest: Zh-2Tbe325ObJ51-O46m-B4hT_WUMnK2GSJJXVNKpXg
package-diff-base:
  source: "https://crates.io"
  name: byteorder
  version: 1.2.7
  revision: bdcc6bf676a1ed17eae68257bfa4726a1f0ec068
  digest: tm4tSfypGXF8-ESvMqH9Pw76GxIDm1UPVFHWF6LUZq8
review:
  thoroughness: low
  understanding: medium
  rating: strong
comment: "Good test coverage, good documentation. LGTM"
-----BEGIN CREV PACKAGE REVIEW SIGNATURE-----
EmXHW3pQ8ZN-KM1AeJZrlUfMr94Y285qhNLBJQXtfxxsc4uFZd1JqeYb_G2mn_-CccXYp6zwbrxrIj3fADEFCQ
-----END CREV PACKAGE REVIEW-----


webprefix missing in links

in authentic-lib.pm (1.802) line 2396 and line 2398 $gconfig{'webprefix'} is missing in the "a" tag
should be
a class="btn btn-default" id="edit_styles" href="'. $gconfig{'webprefix'}.'/settings-editor_read.cgi">
or
a class="btn btn-default" id="edit_logos" href="'. $gconfig{'webprefix'}.'/settings-upload.cgi">
The funktion print_category_link or its use in line 722+ seems to have the same issue

This is true. Added to the distro for the future releases. Thanks!!

in filemin the link help.cgi is missing the webprefix too.

Can you please post to the latest issue you opened, so I will not forget.

Please upgrade to 18.03, it should fix your issues.


Update and rename content/rest/reference/emojis.md to Obsah/Odpočinku…

…/Odkaz/'ZÍSKAT/emojis

Why:

What's being changed:

Check off the following:

[ ] All of the tests are passing.
[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

'GET /emojis'


Cannot access 'index' before initialization (Vite build)

Hi,
Working on using cornerstone3d in a Vite project, ran into an issue when running the project.
I think I have narrowed it down to a possibly circular dependency in packages/tools/src/tools/CrosshairsTool.ts when importing liangBarksyClip
Happy to provide an example minimal repository with the error to verify.
Console error
cornerstonejs.bd843ac7.js:18089 Uncaught ReferenceError: Cannot access 'index' before initialization
    at cornerstonejs.bd843ac7.js:18089:29

with index being
...
const { RENDERING_DEFAULTS } = CONSTANTS;
const { liangBarksyClip } = index;
function defaultReferenceLineColor() {
  return "rgb(0, 200, 0)";
}
...

wow this is incredible! I had the same issue and only just now found the same fix independently;
If only I found your PR a little earlier

I have created an example app with the failure here https://github.com/mmcardle/cornerstone-vite

wow this is incredible! I had the same issue and only just now found the same fix independently;
If only I found your PR a little earlier...
I wonder what's causing this behaviour? the import itself seems logical to me;
On a different note, how did you find this out?
I am just happy to be able to finally work with cornerstone3D in my astro build

I suspect the issue is with Vite and not with cornerstone3d.
To figure out the problem and fix  i used the Contributing Guide on Linking to build my own version of cornerstonejs/tools with the fix in this PR.
When i used this my custom build of cornerstone/tools in my Vite project I stopped getting the error.

So is this PR fixing your issue with vite?

Yes it does, although I would still like to find the underlying Vite issue as this fix feels like a superficial workaround to delay the import of liangBarksyClip.

can you try direct import in that file? import liangBarksyClip from '....../utilities/math/vec2/liangBarksyClip

can you try direct import in that file? import liangBarksyClip from '....../utilities/math/vec2/liangBarksyClip

Yes that also works, probably a better fix to do the import like that?


3.6.3 Unable to export products

We are currently attempting to upgrade to the 3.6.3 release to resolve the fatal errors.
Whilst the cron export works, and the price / stock exports work as well, the main product feed is failing.
We just get the following:
Another export is already running. Please wait for it to finish before you start a new export.
If you receive this message after another export has failed, please delete the file "ffexport.lock" within your Magento directory.

Another export is definitely not running , as us triggering the export creates the FF lock file.
We have increased timeouts / memory limits etc but just get no data sent, then finally after some time the lock message.

@Bobspadger Did I understand you correctly, at the beginning there's no lock file, then you run the export,  the lock file gets created and after some time you get this message in the browser?

@xpoback
Process =
Trigger Export
ff_lock is created
Browser / curl sits and does nothing for ages (looking like its trying to process)
at point X in the future, we get the 'there is an export running already'

@Bobspadger How long is for ages in this particular case?

@xpoback 5minutes approximately
Is there an easy way to find the current version on our production site ? (sorry, can't see a note in our git commit)

If I look in app/code/community/Flagbit/FactFinder/etc
I get a version of 3.5.5

Unfortunately, the version in config.xml is not relevent at the moment in the 3.* extension.
The only way is to check the git tag.
The issue you discribe looks like some changes have slowed down and\or broken the export in your particular case.
How many websites do you have?

@xpoback We only have 1 website.
I don't have any tags in the repo for this. :(

@xpoback The git tag that's deployed to @Bobspadger's site is 3.6.3 (same as issue name and initial description).

@xpoback judging by the release dates of the modules, 3.5.6 was released in November 2014.
We upgraded to the current latest release in June/July 2015 so would stand to reason it was this one.

@Bobspadger Sorry for the delay.
The issue is not easy to debug since we can't reproduce it.
Can you please use the solution from this commit https://github.com/Flagbit/Magento-FACTFinder/commit/30d0699c21be1ad325d49193e8e1cfc0b1ea9904 to fix the fatal errors you had in #112  instead of updating the whole module? As far as I guess that was the only reason for the update.

@Bobspadger What's the status of this?


Electron Rebuild step failing in CircleCI

Hello,
I have updated electron to 9.0.4, now almost all the CI scripts are working fine except CircleCI, which is throwing
Error output:

Error output:
error /home/circleci/repo/app/node_modules/keytar: Command failed.
Exit code: 1
Command: prebuild-install || node-gyp rebuild
Arguments:
Directory: /home/circleci/repo/app/node_modules/keytar
Output:
/home/circleci/repo/app/node_modules/node-abi/index.js:30
  throw new Error('Could not detect abi for version ' + target + ' and runtime ' + runtime + '.  Updating "node-abi" might help solve this issue if it is a new release of ' + runtime)
  ^

Error: Could not detect abi for version 9.0.4 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at getAbi (/home/circleci/repo/app/node_modules/node-abi/index.js:30:9)
    at module.exports (/home/circleci/repo/app/node_modules/prebuild-install/rc.js:73:57)
    at Object.<anonymous> (/home/circleci/repo/app/node_modules/prebuild-install/bin.js:9:25)
    at Module._compile (internal/modules/cjs/loader.js:1118:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1138:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Function.Module._load (internal/modules/cjs/loader.js:875:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47

N.B.: Here keytar is one of my native dependency(as I am using two package.json structure)
I have already seen issues regarding node-abi, where it says yarn upgrade is enough to stop these issues. I have already done all those steps. There is no error throwing in my local or any other CI (azure-pipelines, Github Actions, appveyor).
I don't know whether it is the correct place to ask it, maybe there is an issue from circleci, or maybe I'm missing something silly.
My CircleCi config:
version: 2
jobs:
  build:
    docker:
      - image: circleci/node:13

    working_directory: ~/repo

    steps:
      - checkout

      - restore_cache:
          keys:
            - v1-dependencies-{{ checksum "package.json" }}
            - v1-dependencies-

      - run: yarn --frozen-lockfile

      - save_cache:
          paths:
            - node_modules
          key: v1-dependencies-{{ checksum "package.json" }}
      - run: yarn test-except-e2e

Please help me 😥😥

Nevermind, it was an issue of Keytar, I solved it by seeing their docs.


Mobile: close menu drawer on menu item selection.

Problem
It's quite annoying to have to tap away from the menu after making a selection in the menu. It's one extra tap that isn't needed.
Proposed Solution
We should automatically close the menu when someone makes a menu selection on mobile.

We are currently aware of this issue and it has been resolved in the fix-mobile-view branch. It will be deployed soon.


Dont try to verify pending donations that has been made long time ago

We should set some value in config to don't check donations before that time, I think just checking pending donations of last 48 hours can be good, and we leave donations beore that as pending ( don't change it to failed) maybe later we we want to do something about them so it's better to have them as they are

I think it's better to talk about how to test this

@maryjaf donate with a very low gas fee that you sure it never get verified, check the donation before the configuredDate and after that, before it should show pending and after that it should be null. Am I right @mohammadranjbarz ?

Thanks @MoeNick
Are the changes deployed on the staging environment? @mohammadranjbarz

@maryjaf  @MoeNick  It would be seen in the donor's donations page, but not in project's page
It was the same before this change, all the thing that we do it's not trying to verify them and calling lots of requests to chain, so this issue is more technical, Mary can't test them ( it was part of technical debts)
@maryjaf  You can just make some donations and make sure they got verified, so if our success scenario is ok you don't need to test this issue


[Bug]: Cannot read properties of undefined (reading 'call') On Production (NUXT 3)

Impacted Library name
@ledgerhq/hw-app-btc
Impacted Library version
10.0.0
Describe the bug
On production this function
const { bitcoinAddress } = await appBtc.getWalletPublicKey("44'/0'/0'/0/0");
throws this an error.
Cannot read properties of undefined (reading 'call')
This error only appears on production locally it works fine. I am using NUXT 3 on production the commands I am using are.
yarn generate
yarn preview
Expected behavior
This function should just return the public BTC key from the ledger hardware device and not throw an error
Additional context
No response

Getting the same issue @SurhanZahid @noirbizarre. Is there any workaround?


Uncaught Error: EPERM, operation not permitted '/Users/MKadlec/Library/Caches/TemporaryItems/Outlook Temp/#3681__Fixes_and_improvements.patch'

[Enter steps to reproduce below:]

...
...

Atom Version: 0.174.0
System: Mac OS X 10.10.1
Thrown From: Atom Core
Stack Trace
Uncaught Error: EPERM, operation not permitted '/Users/MKadlec/Library/Caches/TemporaryItems/Outlook Temp/#3681__Fixes_and_improvements.patch'
At /Applications/Atom.app/Contents/Resources/app/src/workspace.js:504

Error: EPERM, operation not permitted '/Users/MKadlec/Library/Caches/TemporaryItems/Outlook Temp/#3681__Fixes_and_improvements.patch'
  at Error (native)
  at Object.fs.openSync (fs.js:455:18)
  at Object.module.(anonymous function) [as openSync] (/Applications/Atom.app/Contents/Resources/atom/common/lib/asar.js:422:20)
  at Project.module.exports.Project.open (/Applications/Atom.app/Contents/Resources/app/src/project.js:287:31)
  at Workspace.module.exports.Workspace.openURIInPane (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:492:31)
  at Workspace.module.exports.Workspace.open (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:418:19)
  at Ipc.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:45:32)
  at Ipc.emit (events.js:110:17)
  at process.<anonymous> (/Applications/Atom.app/Contents/Resources/atom/renderer/api/lib/ipc.js:22:29)
  at process.emit (events.js:118:17)

Commands

Config
{
  "core": {
    "themes": [
      "atom-dark-ui",
      "grandson-of-obsidian"
    ]
  },
  "editor": {
    "fontSize": 14,
    "invisibles": {}
  }
}

Installed Packages
# User
color-picker, v1.2.5
git-log, v0.2.0
grandson-of-obsidian, v0.1.0
linter, v0.7.3
linter-js-yaml, v0.1.3
linter-ruby, v0.1.4
vim-mode, v0.17.0

# Dev
No dev packages

Crash. :(

This isnt a crash, right? It's just a red error, I assume.

It was a crash, I clicked a doc from outlook (on OSX Yosemite) and atom is my default editor.  Not super important, just wondered the cause.

I believe this was fixed by https://github.com/atom/atom/pull/5114 and released in Atom 0.175.0


docker build error

When I run the command "docker build . -t local-package-feeds", an error occured as follows:
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
BuildKit is currently disabled; enable it by removing the DOCKER_BUILDKIT=0
environment-variable.
Sending build context to Docker daemon  603.6kB
Step 1/10 : FROM golang:1.20.5-buster@sha256:eb3f9ac805435c1b2c965d63ce460988e1000058e1f67881324746362baf9572 as builder
---> c94784fe2595
Step 2/10 : WORKDIR /app
---> Using cache
---> 0e46dc699e16
Step 3/10 : ENV CGO_ENABLED=0
---> Using cache
---> a423716eb306
Step 4/10 : COPY go.* ./
---> Using cache
---> 8d30d18e463c
Step 5/10 : RUN go mod download
---> Using cache
---> 0ccb387d027b
Step 6/10 : COPY . ./
---> Using cache
---> 9686bb44b90d
Step 7/10 : RUN go build -mod=readonly -v -o server ./cmd/scheduled-feed
---> Using cache
---> e21bd3134248
Step 8/10 : FROM gcr.io/distroless/base:nonroot
Get "https://gcr.io/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
It seems that the domain can not be connected, how to solve this problem?

Hi, I tried to reproduce the this issue and it appears to have gone away.
I suspect the gcr.io connection issue was transient.
Please try again, and let me know if the issue still persists.


Work Stealing

During @vishalgupta97 internship we observed problems with the work stealing algorithm that if all the work was generated by a single scheduler thread, then the other threads had heavy contention in the stealing code.  This is due to the stealing code only stealing a single item at a time.
There are a few papers that suggest stealing in larger units than single work items:

The Natural Work-Stealing Algorithm is Stable
Scalable Work Stealing
Hierarchical Work Stealing on Manycore Clusters

The suggestions is that stealing at most half of the work is sensible.
This PR changes the implementation of the scheduler queues to support a steal all operation.  By providing N (N=4 in the PR) queues per scheduler thread, then we are able to steal approximately 1/4 of the work on a scheduler thread.
The PR adds a very simple benchmark where a single behaviour generates all the work in the system.  Configured with 4 cores, we get
Before this PR:
Scheduled all work took:
        317 ms
Elapsed:
        606 ms

While with his PR:
Scheduled all work took:
        234 ms
Elapsed:
        251 ms

This is running on my laptop with just four cores, so bigger experiments should be undertaken.
There is also a lot of opportunity for further investigations, in terms of different strategies for stealing and scheduling work.  This PR represents a simple position that improves the state of the system.

@schrodingerzhu I thought you might be interested in this PR.  It is similar to things you have commented on for snmalloc.


Fix invalid URL being generated for URLs containing hyphens

Proposed change

Bugfix for invalid URLs being generated when domain/hostname contains a hyphen (or other non-alphanumeric or period characters).
URLs provided such as http://radarr.abc.a-bc.com:80/ were appearing as http://radarr.abc.a-:7878/bc.com:80/.
I've tried to update the regex to a format where it will look for ports before any character which "splits" the URL (e.g. / for paths, # for anchors, ? for parameters) rather than looking for valid characters.
Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass.
[ ] There is no commented out code in this PR.
[ ] The code has been formatted (make lint)
[ ] Tests have been added to verify that the new code works.

I've performed some local testing of the logic but unfortunately my environment is far from being able to run the tests or linting and the dev container is missing (see #57).
If #57 is resolved, I can look at adding some specific tests.

This PR has failed tests. Do you plan on fixing this PR?

I think I decided to wait for any news on #57 given I don't have a working local environment and have never used make before. If you have the dockerfile available to dump onto #57, I'm happy to have a look at integrating it.


spk infra scaffold support cloning/syncing functionalities

As a:
Developer
I want:
spk infra scaffold to clone the source repository
So that:
it can source the appropriate Terraform templates.
Describe the solution you'd like:
spk infra generate already has a cloning method built out that can be re-used in spk infra scaffold.
Acceptance Criteria:
When running spk infra generate:

[x] source repo should be cloned to ~/.spk/templates directory
[x] the appropriate version should be checked out
[ ] template should be copied from cloned repo

Does this require updates to documentation?:
Yes

@yradsmikham it looks like you're already working on this even though it's in the backlog. Did you consider other items on the current sprint?

@andrebriggs, that's correct. I figured this one would be an easy addition. In fact, I should have another PR out for it by tomorrow. I have also started working on https://github.com/microsoft/bedrock/issues/721, which is in the backlog as well, but it's dependent on: https://github.com/CatalystCode/spk/pull/124. So once the PR merges, I'll continue working on #721.


Size limitations

Thank you for taking the time to report an issue with react-d3-tree!
Feel free to delete any questions that do not apply.
Are you reporting a bug, or opening a feature request?
Asking a general question
What is the actual behavior/output?
Very slow performance when I try to use react-d3-tree with a JSON that has ~1500 nodes
What is the behavior/output you expect?
Less slow performance. My question is, what sizes should I expect slow performance for? 1500 nodes is large, but it's pretty small in the grand scheme of data structures (the JSON is 253 KB)
Can you consistently reproduce the issue/create a reproduction case (e.g. on https://codesandbox.io)?
Sure
What version of react-d3-tree are you using?
The newest one
If react-d3-tree crashed with a traceback, please paste the full traceback below.
It didn't

Hi @sanjanasrivastava,
Are you using the enableLegacyTransitions prop? If so I'd recommend disabling this flag, since the legacy animations don't scale well beyond small/mid-size graphs (one of a number of reasons they're considered legacy now until a usable and performant alternative is ready).
Without animations enabled, the graph should be responsive, even for large datasets.
E.g. the react repository example in the demo has 850+ nodes.
I sized that example up to 1800+ nodes in an experiment just now, and apart from the initial load - during which react-d3-tree has to parse the entire tree to assign internal properties - it seemed to be business as usual.
If you're seeing significant perf issues in your graph without transitions enabled, I'd definitely be curious as to what the structure of your tree is (only if you're able to share of course).

Hi @sanjanasrivastava,
Are you using the enableLegacyTransitions prop? If so I'd recommend disabling this flag, since the legacy animations don't scale well beyond small/mid-size graphs (one of a number of reasons they're considered legacy now until a usable and performant alternative is ready).
Without animations enabled, the graph should be responsive, even for large datasets.
E.g. the react repository example in the demo has 850+ nodes.
I sized that example up to 1800+ nodes in an experiment just now, and apart from the initial load - during which react-d3-tree has to parse the entire tree to assign internal properties - it seemed to be business as usual.
If you're seeing significant perf issues in your graph without transitions enabled, I'd definitely be curious as to what the structure of your tree is (only if you're able to share of course).

Hi, I'm not using the enableLegacyTransitions prop but the tree still animates. Is this prop recent? I installed react-d3-tree 2-3 months ago.

Hi, I'm not using the enableLegacyTransitions prop but the tree still animates. Is this prop recent? I installed react-d3-tree 2-3 months ago.

Right, yeah the component's API has gone through a major refactor for v2, which was released recently. You mentioned that you were using the newest version in the issue description, so I understood v2.
For v1 you'll need to set the transitionDuration prop to 0 (enableLegacyTransitions: boolean is v2 upwards). Once the animations are off, tree size should not significantly affect performance.
If you do find a significant performance penalty (that's also present in v2), please open a separate bug ticket 👍
The v1 branch is only receiving critical bug fixes going forward, so I'd recommend checking whether moving to v2 makes sense :)
Moving from v1 to v2 should be fairly painless for most use cases, and the API is cleaner and more flexible/customizable now.
I've added links to the v2 release notes (and to the v1 legacy docs) at the top of the readme here.

Right, yeah the component's API has gone through a major refactor for v2, which was released recently. You mentioned that you were using the newest version in the issue description, so I understood v2.
For v1 you'll need to set the transitionDuration prop to 0 (enableLegacyTransitions: boolean is v2 upwards). Once the animations are off, tree size should not significantly affect performance.
If you do find a significant performance penalty (that's also present in v2), please open a separate bug ticket 👍
The v1 branch is only receiving critical bug fixes going forward, so I'd recommend checking whether moving to v2 makes sense :)
Moving from v1 to v2 should be fairly painless for most use cases, and the API is cleaner and more flexible/customizable now.
I've added links to the v2 release notes (and to the v1 legacy docs) at the top of the readme here.

Got it! Thanks :)

Got it! Thanks :)


helm3 uninstall

Output of helm version:
Version:"v3.5.3"
Output of kubectl version:
version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.0"16.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.0", GitCommit:"cb303e613a121a29364f75cc67d3d580833a7479", GitTreeState:"clean", BuildDate:"2021-04-08T16:25:06Z", GoVersion:"go1.16.1", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): none
Good afternoon! I run a cluster on kubernetes, install my template, everything works. But when I perform an uninstall, Helm removes only the services, not all the deployments that I installed. Tell me, is this normal or am I missing something?

Hi @forestuser. Sorry to hear you're running into issues. No, it is not normal for deployments to not be removed after a helm uninstall if it was installed via helm install. However we're going to need more information before we can help determine the root cause of the issue.
Can you provide a sample chart that reproduces the same issue? That way we can help determine a root cause for the issue and determine next steps.

helm un battler -n battler --debug
uninstall.go:93: [debug] uninstall: Deleting battler
client.go:282: [debug] Starting delete for "worker" Service
client.go:282: [debug] Starting delete for "gateway" Service
client.go:282: [debug] Starting delete for "channelserver" Service
client.go:282: [debug] Starting delete for "app" Service
client.go:282: [debug] Starting delete for "register" Service
client.go:282: [debug] Starting delete for "mysql" Service
client.go:282: [debug] Starting delete for "arena" Service
client.go:282: [debug] Starting delete for "rabbitmq" Service
uninstall.go:134: [debug] purge requested for battler
release "battler" uninstalled
helm install battler battler_helm -n battler --debug
install.go:173: [debug] Original chart version: ""
install.go:190: [debug] CHART PATH: /home/data/battler_helm
client.go:282: [debug] Starting delete for "configmap-mysql" ConfigMap
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "secretuser" Secret
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "pv" PersistentVolume
client.go:311: [debug] persistentvolumes "pv" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "pvc" PersistentVolumeClaim
client.go:311: [debug] persistentvolumeclaims "pvc" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "geoipupdate" Deployment
client.go:311: [debug] deployments.apps "geoipupdate" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "mysql" Deployment
client.go:311: [debug] deployments.apps "mysql" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "app" Deployment
client.go:311: [debug] deployments.apps "app" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "register" Deployment
client.go:311: [debug] deployments.apps "register" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "channelserver" Deployment
client.go:311: [debug] deployments.apps "channelserver" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "rabbitmq" Deployment
client.go:311: [debug] deployments.apps "rabbitmq" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "gateway" Deployment
client.go:311: [debug] deployments.apps "gateway" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "worker" Deployment
client.go:311: [debug] deployments.apps "worker" not found
client.go:122: [debug] creating 1 resource(s)
client.go:282: [debug] Starting delete for "arena" Deployment
client.go:311: [debug] deployments.apps "arena" not found
client.go:122: [debug] creating 1 resource(s)
client.go:122: [debug] creating 8 resource(s)
NAME: battler
LAST DEPLOYED: Wed Apr 21 22:43:59 2021
NAMESPACE: battler
STATUS: deployed
REVISION: 1
TEST SUITE: None
USER-SUPPLIED VALUES:
{}
COMPUTED VALUES:

tree battler_helm/
battler_helm/
├── charts
├── Chart.yaml
├── templates
│   ├── app
│   │   ├── configmap-mysql.yml
│   │   ├── deploy-app.yml
│   │   ├── deploy-arena.yml
│   │   ├── deploy-channelserver.yml
│   │   ├── deploy-gateway.yml
│   │   ├── deploy-geoipupdate.yml
│   │   ├── deploy-mysql.yml
│   │   ├── deploy-rabbitmq.yml
│   │   ├── deploy-register.yml
│   │   ├── deploy-worker.yml
│   │   ├── name-battler.yml
│   │   ├── pvc.yml
│   │   ├── pv.yml
│   │   ├── secretuser.yml
│   │   ├── service-app.yml
│   │   ├── service-arena.yml
│   │   ├── service-channelserver.yml
│   │   ├── service-gateway.yml
│   │   ├── service-mysql.yml
│   │   ├── service-rabbitmq.yml
│   │   ├── service-register.yml
│   │   └── service-worker.yml
│   ├── network
│   │   └── kube-flannel.yml
│   ├── nginx
│   ├── quota
│   └── traefik
└── values.yaml

I'm sorry, but I can't give you more information

From the logs it appears that the deployments cannot be found in the cluster:

deployments.apps "geoipupdate" not found

Can you share those templates? Can you also share where those deployments are deployed.

for example
cat deploy-mysql.yml
apiVersion: apps/v1
kind: Deployment
metadata:
name: mysql
namespace: battler
labels:
tier: backend
annotations:
helm.sh/hook: pre-install
helm.sh/hook-weight: "1"
spec:
replicas: 1
selector:
matchLabels:
app: mysql
tier: backend
template:
metadata:
labels:
app: mysql
tier: backend
spec:
securityContext: {}
volumes:
- name: volumes-database
persistentVolumeClaim:
claimName: pvc
- name: config
configMap:
name: configmap-mysql
items:
- key: config
path: tf8mb4.cnf
containers:
- name: mysql
image: mysql:5.7
ports:
- containerPort: 3306
    env:
    - name: MYSQL_ROOT_PASSWORD
      value: {{ .Values.mysqlRootPassword | quote }}
    - name: MYSQL_DATABASE
      value: {{ .Values.mysqlDatabase | quote }}
    - name: MYSQL_USER
      value: {{ .Values.mysqlUser | quote }}
    - name: MYSQL_PASSWORD
      value: {{ .Values.mysqlPassword | quote }}
    securityContext:
      privileged: true
    volumeMounts:
    - name: config
      mountPath: /etc/mysql/conf.d/
    - name: volumes-database
      mountPath: /var/lib/mysql
      subPath: battler_mysql_data/_data

cat deploy-mysql.yml
apiVersion: apps/v1
kind: Deployment
metadata:
name: mysql
namespace: battler
labels:
tier: backend
annotations:
helm.sh/hook: pre-install
helm.sh/hook-weight: "1"
spec:
replicas: 1
selector:
matchLabels:
app: mysql
tier: backend
template:
metadata:
labels:
app: mysql
tier: backend
spec:
securityContext: {}
volumes:
- name: volumes-database
persistentVolumeClaim:
claimName: pvc
- name: config
configMap:
name: configmap-mysql
items:
- key: config
path: tf8mb4.cnf
containers:
- name: mysql
image: mysql:5.7
ports:
- containerPort: 3306
    env:
    - name: MYSQL_ROOT_PASSWORD
      value: {{ .Values.mysqlRootPassword | quote }}
    - name: MYSQL_DATABASE
      value: {{ .Values.mysqlDatabase | quote }}
    - name: MYSQL_USER
      value: {{ .Values.mysqlUser | quote }}
    - name: MYSQL_PASSWORD
      value: {{ .Values.mysqlPassword | quote }}
    securityContext:
      privileged: true
    volumeMounts:
    - name: config
      mountPath: /etc/mysql/conf.d/
    - name: volumes-database
      mountPath: /var/lib/mysql
      subPath: battler_mysql_data/_data

I use annotation, but it shouldn't affect it...
annotations:
helm.sh/hook: pre-install
helm.sh/hook-weight: "1"

From the logs it appears that the deployments cannot be found in the cluster:

deployments.apps "geoipupdate" not found

Can you share those templates? Can you also share where those deployments are deployed? Which namespace were they deployed to?

Matthew, why does he ask? This is an installation, not an update

Matthew, why does he ask? This is an installation, not an update

I am asking because you asked why the deployments were not being deleted during a helm uninstall. The root cause may be that the helm install is attempting to uninstall existing deployments instead of installing them. As a result, the release is not managing any deployments within the cluster, which would explain the situation.
Unfortunately, based on the information provided here I cannot help you. There is not enough information provided to reproduce a similar scenario, so all I can do here is help interpret the logs and hopefully provide you with the tools to debug this issue on your own.
Please report back to us when you determine the issue. Thanks.

I use annotation, but it shouldn't affect it...
annotations:
helm.sh/hook: pre-install
helm.sh/hook-weight: "1"

Another thing to keep in mind is that chart hooks are no longer managed by Helm after they have been invoked. So they cannot be uninstalled by helm uninstall. The documentation has more information on this subject.

I use annotation, but it shouldn't affect it...
annotations:
helm.sh/hook: pre-install
helm.sh/hook-weight: "1"

Another thing to keep in mind is that chart hooks are no longer managed by Helm after they have been invoked. So they cannot be uninstalled by helm uninstall. That could be another reason why your deployments are not being uninstalled. The documentation has more information on this subject.

Thank you for your help. I reread the helm documentation on hooks and have disabled them so far, now the install and uninstall work as needed.


Add ability to include message when approving a write_file

I find myself in the position of often wanting to include a little message or instruction when I approve something.
For example:

ClaudeDev requests to write code to a file and I like what I see
I know that after this write, it should look into a specific file next as it a complex project and easy to lose track
I would like it if i could just enter a message into the instruction text box and it get included in my response when i click "Approve"

We can already do the opposite use-case (rejecting with a message) by just ignoring the buttons and sending a new message. I use that ability quite a lot and its very useful. (mainly to say things like "edit foo.ts first", or "look at types.ts first")
PS: amazing extension. I am blown away how practically useful this way of using LLMs are.

Plus one for this. I love ClaudeDev, but I often find as I am reviewing code as it marches on, one api call after another. I can see it starting to deviate from the task at hand. Without being able to guide it as I approve saves I have to decide whether to let it finish its train of thought and make a second pass to fix it , or interrupt it and risk a house of cards collapse in the flow often resulting in throwing away the output of the task to that point (so i can get back to a stable starting codebase for the next attempt).

I am blown away how practically useful this way of using LLMs are.

Thank you for saying this ❤

I find myself in the position of often wanting to include a little message or instruction when I approve something

Although the prompt internally frames this as 'the user denied this tool', if you word your feedback in a way that tells claude to retry the edit with your suggestions in mind that should work too. I don't think adding another button here would be as simple as that honestly, although I could make the text input response to edits more neutral in the prompt sent back to claude. If you want this to be its own button and have ideas for a good UX, pls feel free to add them to the ideas board so ppl can vote on it https://github.com/saoudrizwan/claude-dev/wiki/Troubleshooting-‐-Claude-Deleting-Code-with-"rest-of-code-here"-Comments