Adding a "new constant"?!

Hi!
The new version loads just fine and most things I know seems to work. I have one problem, though.
When I choose a new item (weapon or whatever), I can't add a "new constant" under "Stats" in the "item data" menu. With existing weapons, clothing etc. which I already edited with a old version (same savegame), it works (it just doesn't shows my old edits anymore... it only shows one totally empty constant).
Any new things I have to consider or am I just too tired to remember that I have to do some steps before?
Best regards
Sona
New stuff:

Already edited stuff:

I checked a 1.5 save, and I cannot find any item with stats.. do you ?
If not then it's really deprecated now and better to search for their new way of storing stats..

Hey...
OLD Savegames (from 1.1 to 1.5 updated all the time):

on pre-edited Items I can add constants (the old changes still work ingame, but are NOT shown as you can see on the pic above)
on new Items I can't do anything
when I add new constants to pre-added items, the changes work ingame, but when I reload the too, they disappear again

NEW Savegame (1.5):

on any item I have I can add constants
these changes work ingame
thes added constants stay visible in the tool

I will edit here if I find out something new.

Can you send your save with the Preset_Dian_Yinglong that has previous changes still active but no longer visible in the editor ?
When you say the changes still work, do they after you reload the updated to 1.5 save ?

Hey... I'm currently in the train. When I'm home I'll send you everything.

Finally home.
The old Savegame (it's my test savegame) has been updated to 1.5. I used your tool before 1.3 and it worked fine. Back then it showed me a whole list of the changes I made (constants added). Now ONLY the weapons I already edited back in early 2021 can be changed with "new constant". When I add a new gun via CET console, it doesn't show me the option "new constant".
And then there is the NEW Savegame, I created a few days ago (because I want to play the game again after 8 months). Here I can choose any gun or item I want and add new constants PLUS (!) these changes are shown afterwards and I have a list of the added constants - on the old savegame, the editable items actually take over these changes in the game itself as well, but it DOESN'T show the new constants afterwards. The list stays empty (only shows them in the running session).
Old Savegame (basically my test char):
https://ufile.io/zc2t0e4k
New Savegame:
https://ufile.io/ftavzyad

Thanks ! Made some progress.
I see they now use "modifiersBuffer", it is a DataBuffer with basically looks like a serialized statModifiers array.
Probably to defer load it...
I don't know which one has precedence over the other yet, but I can find out with forged stats.

Ah, wow. That's cool! :) So it's basically all the information in one string?!
But they didn't change the file system, right?
Glad that you are able to make some progress. The tool is such a great thing. :)

Can you post when you have some Updates? If I can help you, ask me... I can see what I can do. :)

Yes I will ! It's my second day at work so I have a new coding style and workflow to get used to.
So I'll be probably be too tired to work seriously on it for a few days. This week-end should do.
If you edit a 1.5 save, then load and re-save, does the new save still has your changes visible in the editor ?
(I'd like to know if they move old stats to new stats only when converting on read, or whenever we save.)

I'll check this evening and then let you know.

Okay. Tested it - both, the old Savegame (updated to 1.5) and the 1.5 Savegame. Reloaded both and saved again.
Constants are disappearing! Looks then again like on my previously posted Screenshot named "New stuff".

Actually that's good, it means i can implement the new buffer and no longer care about the deprecated impl.

Ahhh, I'm sorry... I mean it looks like the Screenshot "Already edited stuff".
Jesus... I hope I didn't make you work on a totally false end now. I'm sorry!

Current pb on my side: I have to add a pre-serialize step just for this object kind to "commit" the edits into the buffer.
However it's hard to hook that in the current rtti implementation. I tried to work on my new rtti impl but I haven't enough free time atm, it will improve once I'm used to the codebase at work.
Seberoth started integrating cybercat in the Wolvenkit. So maybe they'll have the weapon mods editing ready sooner than me.

Okay, thanks for the update. :)

I will probably discontinue this project.
The WolvenKit is gonna do all the same (well in an interpreted language) soon as they have plenty of devs (and some now work at CDPR so they have insider info).
Feels bad to not be able to help them out directly, I hate C# too much.

Oh man, I feel sorry for you. Can't they involve you? I mean you spent so much work with this. :/ And will the WolvenKit have the exact same feature?

@PixelRick Would love to be able to access this. Is this the “entity editor” you note in the latest release?


Bump license-acceptance to 1.0.11 to resolve failures on Windows 2016

Description
Bump license-acceptance to 1.0.11 to resolve failures on Windows 2016
Related Issue
#8548
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Needs release of license-acceptance gem 1.0.11

I've kicked these jobs off again since it's up on rubygems now.


Unable to configure Webpack to allow refresh on routes

There is something I am unable to finalize with this starter boilerplate for a monorepo: I can't figure out why devServer.historyApiFallback: true does not work. I have read a few posts that explain that it is necessary to allow pages to load directly on a route (e.g. <[domain]/about>), but that does not work for me. I get an actual error, not even the 404 page that I set up.
Here is how I adapted webpack/get-app-config.js:
const fs = require('fs-extra');
const path = require('path');
const webpack = require('webpack');
const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
const TerserJSPlugin = require('terser-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const OpenBrowserPlugin = require('open-browser-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const CopyPlugin = require('copy-webpack-plugin');
const getPort = require('get-port-sync');

const loaders = require('./loaders');
const getPackageAlias = require('../scripts/utils/get-package-alias');
const getBasePaths = require('./get-base-paths');

module.exports = function getPackageConfig({
  base,
  publicPath = '/',
  mode = 'production',
  port: settingsPort,
  options
} = {}) {
  const port = process.env.PORT || settingsPort || getPort();
  const { name } = fs.readJsonSync(path.join(base, './package.json'));
  const { entry } = getBasePaths(base);
  const output = path.join(
    __dirname,
    `../public/${options.projectDirName}`
  );

  const config = {
    mode,

    devtool: mode === 'production' ? false : 'eval',

    entry:
      mode === 'production'
        ? entry
        : [
          `webpack-dev-server/client?http://localhost:${port}`,
          'webpack/hot/only-dev-server',
          entry,
        ],

    output: {
      path: output,
      filename: '[hash].bundle.js',
      publicPath,
    },

    devServer: {
      port,
      contentBase: output,
      publicPath,
      historyApiFallback: true,
      proxy: {
        '/static/*': { target: 'http://localhost:[port]/' }
      },
      compress: true,
      stats: { colors: true },
      hot: true,
    },

    optimization: {
      minimizer: [new TerserJSPlugin({}), new OptimizeCSSAssetsPlugin({})],
    },

    resolve: {
      extensions: ['.js', '.jsx'],
      alias: {
        ...getPackageAlias(name),
      },
    },

    module: {
      rules: [loaders.babel(), loaders.hot(), loaders.sass({ mode, publicPath }), loaders.file()],
    },

    plugins: [
      new webpack.DefinePlugin({ 'process.env.NODE_ENV': JSON.stringify(mode || 'development') }),
      new HtmlWebpackPlugin({
        favicon: 'src/static/favicon.ico',
        template: options.templatePath,
        templateParameters: {
          siteTitle: options.siteTitle,
          siteDescription: options.siteDescription,
          ogImage: options.ogImage,
        },
      }),
      new CopyPlugin({
        patterns: [
          { from: 'src/static', to: 'static' },
        ],
      }),
      ...(mode !== 'production'
        ? [
          new webpack.HotModuleReplacementPlugin(),
          new OpenBrowserPlugin({ url: `http://localhost:${port}` }),
        ]
        : [new MiniCssExtractPlugin()]),
    ],
  };

  return config;
};

I am using reach router. I have also tried with react router. Neither work. Any tips?

Hi Mat, I guess there must be an issue on how webpack dev server treats configuration object when used as constructor (not as cli), I've run some tests and it appears that you'll need to pass additional config object in start-app-dev-server script, here is how it worked for me – https://github.com/rtivital/react-monorepo-starter/blob/master/scripts/start-app-dev-server.js#L51

Thanks for the quick reply @rtivital ! This indeed fixed my issue in development mode/locally.
How would I apply the equivalent for the build/production environment?

Actually, disregard my question, it's unrelated to the configs, it was Netlify. I'll leave the URL here in case someone else ever has a similar issue : https://answers.netlify.com/t/netlify-toml-redirects-not-working/29742
Thanks for this starter!


Cannot get Google Fonts to work with Tailwind

I cannot get Google Fonts to work with Tailwind. I have tried multiple methods including adding the link to the HTML head, importing via my own CSS style sheet, and also via the tailwind.config.js file. I cannot get any method to work.
I think it would be very helpful if this could be added to the official documentation, perhaps with a short 1-minute video tutorial going through the whole process of adding Google Fonts.
I have attempted these solutions:
https://github.com/tailwindcss/discuss/issues/177
https://github.com/tailwindcss/discuss/issues/277
https://scottw.com/blog/google-font-tailwind/
https://tailwindcss.com/docs/font-family/
https://medium.com/@saulchelewani/how-to-setup-vue-tailwindcss-with-custom-fonts-and-hsl-color-palette-cda43bf64fea
https://laracasts.com/discuss/channels/guides/tailwindcss-adding-custom-font-family-from-google-font
How does someone go about using Google Fonts with Tailwind?

This is more of an issue for tailwindcss/discuss.
The required steps would be:

Include the google font's @font-face declarations in some way.
Either grab the css via a <link> or an @import in css.
There are some other ways too, but these would be the most straightforward ones.
Add the font to fontFamily config in tailwind.config.js.
Either in a new fontFamily or replacing an existing one.
Add the font-{family} class to the element you want to use it on.
If you want it to be the default you can add the class to the <html> itself or could also use @apply (docs).

An example using <link> and a new fontFamily (see Config tab).
https://tailwind.run/MPgJXo

Thank you for your reply. I have done exactly what you said in your reply and the link but it's still not working. I have added the link href to the HTML head, the font family in the config file, and added the class to the element in the HTML.
I have worked with Google fonts before without Tailwind and it's usually very simple.

I managed to get it to work by referencing the element ID in my own CSS file. Basically doing it the old fashioned way without using Tailwind. I'm happy that it's working however it is strange that I couldn't get it working with Tailwind no matter what I tried.

Can you create a GitHub repo that reproduces your issue? As @tlgreg demonstrated it definitely works.


Update fluentbit to v1.8.13

Current status: waiting for the formal Fluent Bit release 1.8.13 to ensure it passes additional release validation, and also waiting for the soak test result.

Failed tests
apache
The userAgent changed from curl/7.64.0 to curl/7.74.0, we shall not match exactly. Shall change it to match regex
{
  "insertId": "1fvx3cxg1rlw5sv",
  "jsonPayload": {},
  "httpRequest": {
    "requestMethod": "GET",
    "requestUrl": "/forbidden.html",
    "status": 403,
    "responseSize": "435",
    "userAgent": "curl/7.74.0",
    "remoteIp": "::1",
    "protocol": "HTTP/1.1"
  },
  "resource": {
    "type": "gce_instance",
    "labels": {
      "project_id": "stackdriver-test-143416",
      "zone": "us-central1-b",
      "instance_id": "257764733175503475"
    }
  },
  "timestamp": "2022-03-03T20:29:18Z",
  "logName": "projects/stackdriver-test-143416/logs/apache_access",
  "receiveTimestamp": "2022-03-03T20:29:19.315357676Z"
}

dff


⚠ Mobitopup has degraded performance

In 2648dfc, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 14576 ms

Resolved: Mobitopup performance has improved in a959620.


Remove dependency on CVXOPT.

Since the link to Travis has been broken, I copy the error log for commit c4d330e here.
======================================================================
ERROR: test_min (tests.unittest_neos.TestBlackbox)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/discardthree/pysdpt3glue/tests/unittest_neos.py", line 120, in test_min
    problem, sdpt3glue.NEOS, matfile_target, output_target=output_target)
  File "/home/travis/build/discardthree/pysdpt3glue/sdpt3glue/solve.py", line 56, in sdpt3_solve_problem
    problem_data = problem.get_problem_data('CVXOPT')
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/cvxpy/problems/problem.py", line 225, in get_problem_data
    SOLVERS[solver].validate_solver(constraints)
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/cvxpy/problems/solvers/solver.py", line 129, in validate_solver
    raise SolverError("The solver %s is not installed." % self.name())
SolverError: The solver CVXOPT is not installed.
---------------------------------------------------------------------

From the above log, it tries to import CVXOPT and raises an error. I checked other solvers and found SCS is the only solver which is installed with CVXPY, i.e. you don't need to add another dependency.
I switched to use SCS by modifying L56 of solve.py to
problem_data = problem.get_problem_data('SCS')

and run tests. Then, I got another error
======================================================================
ERROR: test_min (tests.unittest_neos.TestBlackbox)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/unittest_neos.py", line 121, in test_min
    problem, sdpt3glue.NEOS, matfile_target, output_target=output_target)
  File "sdpt3glue/solve.py", line 57, in sdpt3_solve_problem
    sw.write_cvxpy_to_mat(problem_data, matfile_target)
  File "sdpt3glue/sedumi_writer.py", line 35, in write_cvxpy_to_mat
    problem_data, simplify=simplify)
  File "sdpt3glue/sedumi_writer.py", line 131, in make_sedumi_format_problem
    A[0:ne, 0:nx] = problem_data['A']
ValueError: setting an array element with a sequence.
----------------------------------------------------------------------


Alternatives to peeking

Currently the only way to signal from child to parent is through peeking, which is awkward to me for a number of reasons:

It's yet another signalling mechanism. There's handlers for the HTML DSL, coroutines for third party components, and peeking for native components.
It adds another layer of overloading to the query algebra. The query algebra is currently used for internal actions, external actions, external requests, parent signalling, and memo invalidation.
It requires you to overload individual query constructors. Using something like the Ace example, you have to overload the ChangeText action for both signalling and performing updates, which requires a redundant check to only update if the text is different.
It's inefficient. If you peek at your root component, it will get invoked on every single input, even though 99% of inputs will likely be ignored.
It's unwieldy to peek at anything other than immediate children.

One idea (and you all can comment on the feasibility) is to let components opaquely reflect their current slot/address during render and eval. Essentially, this is just getting something like a this reference to the component, or kind of like how elm has addresses (except these are pure). It might look like this (with a lot of hand-waving):
type Address = ...

data Message a = ...

instance contravariantMessage :: Contravariant Message

envelope :: forall f a. (a -> f Unit) -> Address -> Message a

You could then pass around Messages to child components, and provide someway of invoking them. Since Halogen provides the opaque address, it's guaranteed to resolve to a well-formed action. And since you can only reflect your own address or take one from a parent, you can't get into a weird muddy situation where you can globally address any component in the hierarchy like you can in elm through the Mailbox to Signal mapping.
You would also want to change the HTML DSL to use this mechanism, which has some advantages:

It unifies the signalling mechanism.
You could take a Message as a parameter and give it directly to an HTML event without needing to go through some sort of proxy in your query algebra
You can contramap if you need to adapt the input
It would be more efficient in general. Right now, because we carry around i in the HTML DSL, in order to nest components we have to map and adapt the handler. This means that child components in a deep hierarchy get mapped over and over again at each level of nesting. Since all handlers would just take Messages, you could lose the type parameter.

I think we have all the information around to do something like this anyway (as we have to map over the HTML to adapt handlers), but it would be a major change. Any thoughts?

Small correction:
type Address f = ...

data Message a = ...

instance contravariantMessage :: Contravariant Message

envelope :: forall f a. (a -> f Unit) -> Address f -> Message a

Because you need to type the input algebra.

You could then pass around Messages to child components, and provide someway of invoking them. Since Halogen provides the opaque address, it's guaranteed to resolve to a well-formed action. And since you can only reflect your own address or take one from a parent, you can't get into a weird muddy situation where you can globally address any component in the hierarchy like you can in elm through the Mailbox to Signal mapping.

Doesn't this also prevent us from "driving" the app, if we have no way to construct addresses "externally"? Almost always we don't need the driver now, but there are cases where it is still useful - routing being one of them.

Doesn't this also prevent us from "driving" the app, if we have no way to construct addresses externally? Almost always we don't need the driver now, but there are cases where it is still useful - routing being one of them.

No, you could still drive the app externally. You still carry the query algrebra in the component type due to eval, its would just not be carried in the HTML type. So this should only really affect HTML event handlers, and perhaps subscriptions. The point is to prevent constructing global addresses from arbitrary points in the component stack. If all Halogen event handlers take Messages, and the only way to construct one is via an Address provided by the Halogen runtime, then you can guarantee that addresses are always correct. Because the Address type is so general, if you could construct them yourself, it would be like the issue with transform where you could build an incorrectly typed action.

I managed to get bare bones POC working https://github.com/natefaubion/purescript-halogen/commit/452dd283d7dae7f264360042a112015f21ccce56

I just made an Address f an existential Driver.
There's no need to have a Message a type because you can just use functions.
I kept the second parameter on HTML, but fixed it to Send. This lets us lose a type parameter in a few places since HTML no longer has to know about component query types.
I only touched the rendering aspect of it, not eval, so each event can only trigger one input. This just means that you can't currently invoke a callback in eval. In the todos example that means when you toggle completed, the parent has control and then sends an action to the child.
I haven't touched transform or transformChild, mainly because I've never used them so I didn't bother.

Looks pretty neat, although what do you mean by

you can't currently invoke a callback in eval

?

I just mean that I haven't added anything to HalogenF to invoke a Send within eval. It's just somewhat unclear how to go about that. For the todo example specifically, that would mean you can handle the toggle event first in the Task component and then signal the parent vs signaling the parent from the event handler and having the parent query the task.

Ah okay, I see what you mean now. Yeah, that is tricky, but it would be great to be able to do it that way.
We could stick a Free in to allow the event handlers to send multiple messages, but the current design intentionally decided not to allow that, it seems preferrable for that kind of logic to live in eval rather than having render potentially raising multiple actions.

I think the minimal thing you could do would be to provide someway to return a new action in eval along with the next variable. It gets tricky if you can invoke it anywhere in your logic.

@natefaubion Good stuff! I hope to dig in a bit around the Christmas holiday.

@natefaubion This looks pretty promising. There are some unsafe coerces, and obviously peek hasn't been replaced nor eval updated. How far is this PR away from being "merge ready"???

We're looking at something like that for the next major version - it has some downsides (you can end up with race condition like behaviours if an "event" raises long running async processes in the parent - although that's still possible now if you try), but does seem like a more consistent approach.


feat: add status tag and workflow-context

Apologies in advance: this PR contains quite a few changes that fall out of the scope of the actual JIRA issue:

I've re-arranged the component and directory structure
Extracted a few things into helper components
I've renamed a few context-related files to ensure more consistent naming there

The actual new features are the status-tag and the workflow-context. So please focus mostly on those while reviewing.
Currently this PR doesn't include any test-coverage and it would be good to add that here. However, most components that are still to be built will rely on the workflow-context. So if we keep this PR open, it will block you guys from getting started. I would like to propose that we add the unit tests in a separate PR.

Do you want to merge #14 into this PR first?

Yeah I'd like that. I've approved but also left a comment.


NWC app title should be passed in rather than hardcoded

See https://github.com/getAlby/lightning-wallet-connect/blob/26653ccf5ffa4104bcc1ef120f8129d779a8e3ed/src/connectors/lwc-alby-nwc-connector.ts#L22

Hi @rolznz , can I work on this?

Hi @Sakshi-75, sure!
It is probably easiest to support an attribute like appName in the BitcoinConnectElement class so it can be set on all components.
Then AlbyNWCConnector needs to somehow have access to this property. I don't think we should have to pass it from the button to the modal to the component list. So maybe we should use the zustand store and update it from the connectedCallback in BitcoinConnectElement.
Then in BitcoinConnectElement create another state variable for the app name and subscribe to it from the store. This way it'll be available in AlbyNWCConnector.
Finally, the react wrapper should also be updated to pass the property to the bitcoin connect components.

Hey if it is still open can i work onto this

Hi, this was already merged. Thanks!


Invalid USB state: powered after cable is disconnected

Describe the bug
Replicated with nrf_desktop on both PCA20041 and PCA10056 (here you have to enable USB support as it is not there in default configuration).
Connect to USB - observe powered event. HID reports are transmitted and everything seems fine.
Disconnect USB now - observe disconnected event (so far so good) and then powered event which clearly is wrong as USB cable is not connected. This behavior is there since Jan and it seems latest change done to USB is not fixing it.
To Reproduce
See description.
Expected behavior
When cable is disconnected driver should not inform that it is connected.
Impact
Application cannot work around this so we assume cable is connected. This is showstopper as device behavior is improper.
Screenshots or console output
[01074764] <inf> event_manager: e: usb_state_event id:0x20000195 state:POWERED
[01074764] <inf> hid_state: Subscriber 0x20000195 connected
[01074764] <inf> hid_state: Active subscriber 0x20000195
[01074795] <wrn> usb_state: USB_DC_CONNECTED when USB is not disconnected
[01084472] <inf> usb_state: USB HID enabled
[01084475] <inf> event_manager: e: usb_state_event id:0x20000195 state:ACTIVE
[01084478] <inf> event_manager: e: hid_report_subscription_event MOUSE report notification enabled by 0x20000195
[01085358] <wrn> usb_hid: len 126 doesn't match Report Descriptor size
[01414924] <inf> usb_state: USB HID disabled
[01414926] <wrn> usb_state: USB_DC_RESET when USB is disconnected
[01414930] <inf> event_manager: e: hid_report_subscription_event MOUSE report notification disabled by 0x20000195
[01414930] <inf> hid_state: Clear report data (0)
[01414932] <inf> event_manager: e: usb_state_event id:0x20000195 state:DISCONNECTED
[01414932] <inf> hid_state: Subscriber 0x20000195 disconnected
[01414932] <inf> hid_state: Active subscriber 0x20003560
[01414934] <inf> event_manager: e: usb_state_event id:0x20000195 state:POWERED
[01414934] <inf> hid_state: Subscriber 0x20000195 connected

Environment (please complete the following information):
ncs: bd591571f66c17a8693755465b1067320eeff19d
ncs zephyr: a869285d262d57c382eddce928b46e3b18daa197 (from upstream ec424b7a455cc98c36e3cab80be7e152ef2c5217)
Newest change done in https://github.com/zephyrproject-rtos/zephyr/pull/13132 does not help.
Additional context
N/A

@pdunaj I assume this is bug against nrf platform, right?

Yes but this should be fixed now. Checking


Tabs name are not visible!

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:23:26.125Z)
OS Version: Darwin x64 17.2.0
Extensions:

Extension
Author (truncated)
Version

material-icon-theme
PKi
3.1.0

gitlens
eam
6.2.0

path-autocomplete
ion
1.7.0

autoimport
ste
1.5.3

gitblame
wad
2.2.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

Just in case...there is a setting for editor tabs: "workbench.editor.showTabs": true.


failed to compile in mac os10.11, fv_cached compilation failed

When running your compile.m, I see this warning
Warning: Maybe you need to call fv_cache('unlock') first?

In fv_compile (line 52)
In compile (line 48)
which means I can not successfully compile fv_cache.cc function.
I saw your comment in this exception, but I don't know how to solve this problem.
There is one guy in stack overflow suggested that he has met the same problem, and he solve it by installing gcc48.
http://stackoverflow.com/questions/24150718/voc-release-5-demo-m-is-not-working/33789824#33789824
Is that the correct way?

Any idea on how to fix this? I tried gcc48/gcc47/gcc46 but none of them works for Mac.


Refactored AWSXRayServletFilter

Description of changes:
Refactored: not to use deprecated method in strategy creation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #386 (e404ca9) into master (f81966d) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #386   +/-   ##
=========================================
  Coverage     28.09%   28.09%
  Complexity      574      574
=========================================
  Files           138      138
  Lines          5254     5254
  Branches        634      634
=========================================
  Hits           1476     1476
  Misses         3577     3577
  Partials        201      201

Impacted Files
Coverage Δ

...aws/xray/jakarta/servlet/AWSXRayServletFilter.java
0.00% <0.00%> (ø)


how to setup?

Hi there,
first thank you for your work on this project. I have a couple of questions as i don't get the Piko BA version to work.
I have installed the kostal integrations from gieljnssns which is working fine on 6 different Kostal Piko Inverters. But there is one more, a Piko BA 10.1 inverter which i can't get to work.
If i use platform: kostal_piko , it is unknown from HA, did gieljnssns changed the platform name from kostal_piko to kostal only?
Further i do not understand how the authentication is made in your version for the Piko BA inverter.
There is no such username or password, i have also tried with following as host:
<EMAIL_ADDRESS>Also not working. I would appreciate if you could give me a hint or any reply to get the last of this inverters into HA.
Thank you in advance.
br Christoph

Hi @molelightn !
Sorry my readme still lacks a bit of detail. This integration is supposed to be published to HACS but I haven't found the time to refactor a little bit and to finally publish it.
(Note to self: Thinking about it, I should actually open a merge request to the original kostal integration)
However it is working nicely in my test setup with a PIKO 8.0 BA for quite some time now.
It was me who changed the integration name, if I remember correctly, to prevent name conflicts with the kostal integration.
As far as I understand, there are several versions of the User Interface of the Piko inverters and therefore also the APIs. If your PIKO BA 10.1 has e.g. index.fhtml in its URL, this integration will likely not work.
Could you check your UI and FW version in your inverters web interface?
The PIKO 8.0. BA I'm using is running UI version 06.41 and FW version 02.30.

Hi scheidtdav,
we upgraded BA inverter to UI version 6.41 but still had no luck with the integration.
As Kostal cancled some functions for batteries in the higher UI version the owner from the BA inverter decided to go back to the previous firmware.
Anyway thanks for your help, i guess we have to find another way.
br mole

Bummer! I am not sure how much the UI versions differ between different inverters.
There might be still some differences that I am not aware of. It is hard to develop if you only have access to a single inverter and you have to reverse engineer the API ;-)
Anyways, if you have to revert back due to some battery functionality, this integration cannot help, I guess.
I hope you can find another way :smile:
Cheers!


Balance of power not showing

BOP showing as blank on Election 2016 page

URL: http://elections.dev.passenger.bostonglobe.com/elections/2016?p1=BG_election_nav_central

closed by https://github.com/BostonGlobe/elections-2016/commit/70ae4c94afebfea19b112d0b5c39cddd75a88af7


Localize Bible Book Names

User Story
As a user, I want to see Bible book names in my UI language so that I am confident I am where I think I am and don't accidentally translate the wrong verse or put the translation of a verse in the wrong book.
Description
In the book selector (and any other reasonable places, e.g. S/R), display the localizations of Bible book names (if none exist, the localizer already tries to find a localization in a related langauge and if that doesn't work it will go the english).

Consider adding this in https://github.com/sillsdev/scripture? Pretty sure C# https://github.com/sillsdev/libpalaso/tree/master/SIL.Scripture localizes names.


SnapExporter is started on install

SnapExporter is started on install event, which is not the currently expected behavior: exporter are only started when cos_agent is related.

SmartCTL exporter is enabled by default, which means that it will start immediately after the strategy finish installing it. If we really want this to happen then we need to stop and disable all snaps after installing

I think this is also true for dcgm: https://github.com/canonical/hardware-observer-operator/blob/main/src/service.py#L391-L402. We should be consistent with the approach: either remove cos_agent check or make the snap disable on install

I am leaning towards removing cos_agent check in this charm because the if cos_agent_related check in config_changed event will silently block the config changed of exporter.

My 2c: I'd also lean towards always running the exporter, ignoring the status of cos-agent relation.  It makes the logic simpler, and avoids confusion for anyone who wants to run or test the exporter without relating cos.


It should not have been necessary for me to go to the GitHub project to make this work

I got tripped up around the issue of initializing the database with test data because the code sample provided on this tutorial doesn't include all of the necessary code. It calls BuildWebHost(args) but never indicates any necessity that this function should be added to the Program.cs file. I'm glad there was the GitHub project I could look at to find out how to write this function otherwise I'd have been completely stumped with no way to actually proceed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ad06677-5842-c1aa-153f-7993a9660dfa
Version Independent ID: 8daf79df-eac4-358b-e6f0-6def45bd54da
Content: ASP.NET Core MVC with Entity Framework Core - Tutorial 1 of 10
Content Source: aspnetcore/data/ef-mvc/intro.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: tdykstra

It's there:
public static void Main(string[] args)
{
    var host = BuildWebHost(args);

    using (var scope = host.Services.CreateScope())
    {
        var services = scope.ServiceProvider;
        try
        {
            var context = services.GetRequiredService<SchoolContext>();
            DbInitializer.Initialize(context);
        }
        catch (Exception ex)
        {
            var logger = services.GetRequiredService<ILogger<Program>>();
            logger.LogError(ex, "An error occurred while seeding the database.");
        }
    }

    host.Run();
}

BTW, what version of the SDK are you using? This tutorial is currently being updated for 2.2
The Razor Pages version is up to date if you're open to RP.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Updated to node 12.x

@btrask my similar v12 support changes for node-pcap, which this is an underlying module for, are about to be committed. Preferably, it would be good to continue for it to be based it based on this repo instead of my fork. Are you still maintaining it?

Our organization is in trouble with what installation of node_pcap and this library has been failing on node v12 environment. It seems node_pcap side is ready to support node v12, however, the current status of this library could be a blocker for that.
I really hope this patch was merged and it'll be published.

@btrask it would be really great if you can merge this PR and release a new version.

Can someone please approve this PR?

Sorry everyone I was dead for a while.
I'd like to push this patch to npm, but I don't own the package there anymore. @jonahharris do you want to either publish an update or add me as a maintainer again?

@btrask you've been added back as the maintainer - it's your baby :)

@jonahharris Thank you! I've added you as a collaborator to this repo, too.
@aalwash: I pushed 0.4.0 to npm. Let me know how it goes!

Thanks @btrask , tested with node12 and it works!
Now I need to kick someone from node-red-contrib-pcap to updated their dependencies ;)

Good to hear it @aalwash. Thanks to @jonahharris for doing all the hard work!


Add sync payouts

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2315

PR #2316

PR #2326   👈

PR #2327

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: 5hnII290vum6FkNNUUml


ci: fix collect_build_profile

Signed-off-by: Ranjith Kumar<EMAIL_ADDRESS>Commit Message: ci: fix collect_build_profile to copy gzipped file
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

cc @lizan


networks: reduce the size of the ConnectionStats structure

What does this PR do?
Second try on https://github.com/DataDog/datadog-agent/pull/30532, this time without breaking macOS. It drops the ephemeral port range commit.

The goal of this PR is to bootstrap the reduction in size of the ConnectionStats structure.
To do that this PR reduces the int-width of some of those fields that don't require such big width
I would suggest to review this PR commit by commit, each one of the commits is doing something fairly simple on its own.
Pahole output on linux arm64:
Before:
struct github.com/DataDog/datadog-agent/pkg/network.ConnectionStats {
	github.com/DataDog/datadog-agent/pkg/network.IPTranslation * IPTranslation; /*     0     8 */
	github.com/DataDog/datadog-agent/pkg/network.Via * Via; /*     8     8 */
	struct []*go4.org/intern.Value Tags;             /*    16    24 */
	struct struct { Source *go4.org/intern.Value; Dest *go4.org/intern.Value } ContainerID; /*    40    16 */
	map[*github.com/DataDog/datadog-agent/pkg/util/intern.StringValue]map[github.com/DataDog/datadog-agent/pkg/network/dns.QueryTyp DNSStats; /*    56     8 */
	/* --- cacheline 1 boundary (64 bytes) --- */
	map[uint32]uint32          TCPFailures;          /*    64     8 */
	github.com/DataDog/datadog-agent/pkg/network.ConnectionTuple ConnectionTuple; /*    72    64 */
	/* --- cacheline 2 boundary (128 bytes) was 8 bytes ago --- */
	github.com/DataDog/datadog-agent/pkg/network.StatCounters Monotonic; /*   136    48 */
	github.com/DataDog/datadog-agent/pkg/network.StatCounters Last; /*   184    48 */
	/* --- cacheline 3 boundary (192 bytes) was 40 bytes ago --- */
	uint64                     Cookie;               /*   232     8 */
	uint64                     LastUpdateEpoch;      /*   240     8 */
	time.Duration              Duration;             /*   248     8 */
	/* --- cacheline 4 boundary (256 bytes) --- */
	uint32                     RTT;                  /*   256     4 */
	uint32                     RTTVar;               /*   260     4 */
	uint64                     StaticTags;           /*   264     8 */
	github.com/DataDog/datadog-agent/pkg/network/protocols.Stack ProtocolStack; /*   272     6 */
	github.com/DataDog/datadog-agent/pkg/network.ConnectionDirection Direction; /*   278     1 */
	github.com/DataDog/datadog-agent/pkg/network.EphemeralPortType SPortIsEphemeral; /*   279     1 */
	bool                       IntraHost;            /*   280     1 */
	bool                       IsAssured;            /*   281     1 */
	bool                       IsClosed;             /*   282     1 */

	/* size: 288, cachelines: 5, members: 21 */
	/* padding: 5 */
	/* last cacheline: 32 bytes */
};

After:
struct github.com/DataDog/datadog-agent/pkg/network.ConnectionStats {
	github.com/DataDog/datadog-agent/pkg/network.IPTranslation * IPTranslation; /*     0     8 */
	github.com/DataDog/datadog-agent/pkg/network.Via * Via; /*     8     8 */
	struct []*go4.org/intern.Value Tags;             /*    16    24 */
	struct struct { Source *go4.org/intern.Value; Dest *go4.org/intern.Value } ContainerID; /*    40    16 */
	map[*github.com/DataDog/datadog-agent/pkg/util/intern.StringValue]map[github.com/DataDog/datadog-agent/pkg/network/dns.QueryTyp DNSStats; /*    56     8 */
	/* --- cacheline 1 boundary (64 bytes) --- */
	map[uint32]uint32          TCPFailures;          /*    64     8 */
	github.com/DataDog/datadog-agent/pkg/network.ConnectionTuple ConnectionTuple; /*    72    64 */
	/* --- cacheline 2 boundary (128 bytes) was 8 bytes ago --- */
	github.com/DataDog/datadog-agent/pkg/network.StatCounters Monotonic; /*   136    40 */
	github.com/DataDog/datadog-agent/pkg/network.StatCounters Last; /*   176    40 */
	/* --- cacheline 3 boundary (192 bytes) was 24 bytes ago --- */
	uint64                     Cookie;               /*   216     8 */
	uint64                     LastUpdateEpoch;      /*   224     8 */
	time.Duration              Duration;             /*   232     8 */
	uint32                     RTT;                  /*   240     4 */
	uint32                     RTTVar;               /*   244     4 */
	uint64                     StaticTags;           /*   248     8 */
	/* --- cacheline 4 boundary (256 bytes) --- */
	github.com/DataDog/datadog-agent/pkg/network/protocols.Stack ProtocolStack; /*   256     3 */
	github.com/DataDog/datadog-agent/pkg/network.ConnectionDirection Direction; /*   259     1 */
	github.com/DataDog/datadog-agent/pkg/network.EphemeralPortType SPortIsEphemeral; /*   260     1 */
	bool                       IntraHost;            /*   261     1 */
	bool                       IsAssured;            /*   262     1 */
	bool                       IsClosed;             /*   263     1 */

	/* size: 264, cachelines: 5, members: 21 */
	/* last cacheline: 8 bytes */
};

As you can see the size goes from 288 bytes to 264 (~9% reduction). This can result in a few megabytes of reduction for example when used in the closed connection stats.
This PR also paves the way for future reduction efforts, especially packing all the boolean flags
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Add support to configure mesos-consul refresh

The default refresh rate for mesos-consul is 60s. This sets it to 7s and allows it to be set via an ansible var.

@ChrisAubuchon are you ok with this pull?


Mocha does not work with typescript when compilerOptions.module set to esnext

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
When attempting to use Mocha with TypeScript that has compilerOptions.module set to esnext, mocha fails to work with the following error:
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/ryanzec/repositories/monorepo-template/packages/utils/tests/drag-drop.spec.ts
    at new NodeError (node:internal/errors:372:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:76:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:118:38)
    at defaultLoad (node:internal/modules/esm/load:21:20)
    at ESMLoader.load (node:internal/modules/esm/loader:407:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:326:22)
    at new ModuleJob (node:internal/modules/esm/module_job:66:26)
    at ESMLoader.#createModuleJob (node:internal/modules/esm/loader:345:17)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:304:34)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async formattedImport (/Users/ryanzec/repositories/monorepo-template/node_modules/mocha/lib/nodejs/esm-utils.js:7:14)
    at async Object.exports.requireOrImport (/Users/ryanzec/repositories/monorepo-template/node_modules/mocha/lib/nodejs/esm-utils.js:48:32)
    at async Object.exports.loadFilesAsync (/Users/ryanzec/repositories/monorepo-template/node_modules/mocha/lib/nodejs/esm-utils.js:103:20)
    at async singleRun (/Users/ryanzec/repositories/monorepo-template/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/Users/ryanzec/repositories/monorepo-template/node_modules/mocha/lib/cli/run.js:374:5)

The same exact code / test works fine if compilerOptions.module is set to commonjs.
Steps to Reproduce

Checkout this repo: https://github.com/ryanzec/monorepo-template
Change the tsconfig.testing.json file so that compilerOptions.module is set to esnext
Run yarn test:unit

Expected behavior: Tests should run
Actual behavior: Error as described above

Reproduces how often: Everytime
Versions
Mocha: 10.0.0
Node: v16.15.0
OS: Mac OS 11.6 (64bit)
Bash: 3.2.57(1)-release (x86_64-apple-darwin20)
ts-node: 10.9.1
typescript: 4.8.2

Same issue happen in the package.json has "type": "module"

Unfortunately this happens to me too.

me too

This is not a mocha issue. Looking at your repo I guess you have found the correct way to configure ts-node with ESModules.

No I have not found a way to get mocha to work with esmodules, I have it working by having a separate tsconfig for mocha that sets module to commonjs which is less than ideal since the production tsconfig has module set to esnext.

this issues seems to still be relevant, as just setting the module resolution to commonjs for mocha breaks code coverage that can be genreated i.e. via nyc


use NewSharedInformerFactoryWithOptions to init shared informer factory

As NewFilteredSharedInformerFactory was deprecated in 1.11, should update NewSharedInformerFactoryWithOptions .

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hzxuzhonghu
If they are not already assigned, you can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e316c4f396d663f5836a6c2600303042725da50f
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e316c4f396d663f5836a6c2600303042725da50f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

close this in favor of #9625


"break" job issue

*Detailed description of the issue:
It seems like the "break" sections for jobs does not actually work.
For instance, with farmers job (base job, no changes) any breakage of crops will not trigger money to be gained, but when i go to start placing seeds back down to farm them after they grow, the placement of said seeds will cause money to be gained.
Same with other jobs that have the "break" sections when breaking certain blocks.

Jobs version: <IP_ADDRESS>
Server Type (Spigot/Paper/etc): Purpur
Server Version (using /ver): purpur-1832 (1.19.2)

Test this without any plugin and preferably with spigot or paper server builds to make sure that this isint caused by another plugin interfering with break actions


chore(infra): improve the configuration of justfile

Summary
Related to #7516

[x] support windows shell
[x] support setup
[x] support ready
[x] support build
[x] support watch
[ ] support ci/cd
[ ] docs guide

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

excellent work!

@shulaoda let's separate this into multi pr, no need to finish  things in on PR, current justfile improvement can be landed first.

thanks!


Creating cards and tables in palettes

Use JS and HTML to create cards and tables to collect user inputted parameters and link to more information about AguaClara / plant designs

Fixed importing jinja2 issue using absolute paths


:field => Array, does not accept mongoize() classes upon save

Greetings,
Thank you for producing Mongoid!  I love it!
I am attempting to save a series of objects (with mongoized,demonogize, evolve) into an Array.  I get an error "undefined method `bson_dump'" which is at the bottom of the document.  I have reproduced the issue using the Point example from the custom fields demo.
Thank you!
-daniel
test.rb
    require 'mongoid'

    Mongoid.load!("mongoid.yml", :test)

    # this is the point example taken from the documentation
    class Point
      attr_reader :x, :y

      def initialize(x, y)
        @x, @y = x, y
      end

      # Converts an object of this instance into a database friendly value.
      def mongoize
        [ x, y ]
      end

      class << self

        # Get the object as it was stored in the database, and instantiate
        # this custom class from it.
        def demongoize(object)
          Point.new(object[0], object[1])
        end

        # Takes any possible object and converts it to how it would be
        # stored in the database.
        def mongoize(object)
          case object
          when Point then object.mongoize
          when Hash then Point.new(object[:x], object[:y]).mongoize
          else object
          end
        end

        # Converts the object that was supplied to a criteria and converts it
        # into a database friendly form.
        def evolve(object)
          case object
          when Point then object.mongoize
          else object
          end
        end
      end
    end

    # saving a class as a single field works fine
    class Single
      include Mongoid::Document
      field :location, :type => Point
    end

    s = Single.new
    s.location = Point.new(1, 2)
    s.save

    # when saving the an array of objects, there is the error given
    class Plural
      include Mongoid::Document
      field :locations, :type => Array, :default => []
    end

    p = Plural.new
    p.locations << Point.new(1, 2)
    p.locations << Point.new(3, 4)
    p.save

mongoid.yml
    test:
      sessions:
        default:
          hosts:
            - localhost:27017
          database: point_array
      options:
        allow_dynamic_fields: false
        identity_map_enabled: true
        include_root_in_json: true
        include_type_for_serialization: true
        scope_overwrite_exception: true
        raise_not_found_error: false
        skip_version_check: false
        use_activesupport_time_zone: false
        use_utc: true

error
/var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/bson/extensions/array.rb:14:in `__bson_dump__': undefined method `__bson_dump__' for #<Point:0x000000027c22a0 @x=1, @y=2> (NoMethodError)
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/bson/extensions/hash.rb:15:in `block in __bson_dump__'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/bson/extensions/hash.rb:14:in `each'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/bson/extensions/hash.rb:14:in `__bson_dump__'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/bson/document.rb:36:in `serialize'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/protocol/message.rb:129:in `block in serialize_documents'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/protocol/message.rb:128:in `each'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/protocol/message.rb:128:in `serialize_documents'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/protocol/message.rb:287:in `serialize'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/connection.rb:153:in `block in write'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/connection.rb:151:in `each'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/connection.rb:151:in `write'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:578:in `block (2 levels) in flush'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:138:in `ensure_connected'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:577:in `block in flush'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:592:in `logging'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:576:in `flush'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:565:in `process'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:253:in `insert'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/session/context.rb:63:in `block in insert'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/session/context.rb:109:in `block in with_node'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/cluster.rb:209:in `block in with_primary'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/node.rb:183:in `ensure_primary'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/cluster.rb:208:in `with_primary'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/session/context.rb:108:in `with_node'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/session/context.rb:56:in `insert'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/collection.rb:106:in `block in insert'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/session.rb:324:in `with'
  from /var/lib/gems/1.9.1/gems/moped-1.4.5/lib/moped/collection.rb:105:in `insert'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence/operations/insert.rb:27:in `block in persist'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence/insertion.rb:25:in `block (2 levels) in prepare'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:403:in `_run__4468728994625756828__create__237314211246586726__callbacks'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:405:in `__run_callback'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:385:in `_run_create_callbacks'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:81:in `run_callbacks'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/callbacks.rb:130:in `run_callbacks'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence/insertion.rb:24:in `block in prepare'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:403:in `_run__4468728994625756828__save__237314211246586726__callbacks'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:405:in `__run_callback'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:385:in `_run_save_callbacks'
  from /var/lib/gems/1.9.1/gems/activesupport-3.2.11/lib/active_support/callbacks.rb:81:in `run_callbacks'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/callbacks.rb:130:in `run_callbacks'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence/insertion.rb:23:in `prepare'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence/operations/insert.rb:26:in `persist'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence.rb:51:in `insert'
  from /var/lib/gems/1.9.1/gems/mongoid-3.1.3/lib/mongoid/persistence.rb:80:in `save'
  from test.rb:66:in `<main>'

Adding reference to https://github.com/mongoid/mongoid/issues/4031


fix links to interpage section

@ComFreek : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution. I've merged your changes and they should be live soon.


BUG? : getMeta is not a function

Is the getMeta and setMeta functionality in V3 removed?

Get meta has not been brought yet. It should be done in the next release.

It has been done, it will be available in the master repo tomorrow.


Hide quick input Icon on Quick input page

Signed-off-by: ruddi<EMAIL_ADDRESS>fixes #419

@muskankhedia  @aquibbaig kindly review


Shared disk support using enhanced backup policy

Hello team,
I have a suggestion that could be implemented in the support matrix.
According to the documentation, it states that VM backup for VMs with shared disks is currently not supported. However, we could include a line stating that it could be supported if we use an Enhanced Backup Policy and exclude the shared disk.
The backup can be configured, and it will work for the VM and the other disks as expected. I just created a lab and tested it myself. It's probably documented somewhere else, but I think it's important to have it on the support matrix.
The excluded disk (shared disk) can be backed up using Disk backup.
Please let me know if you need any other detail and thank you so much in advance!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0e2dde49-662d-fc39-a03f-c67f7f86df67
Version Independent ID: a4545bdc-298b-b440-203e-4f6f66882655
Content: Support matrix for Azure VM backups - Azure Backup
Content Source: articles/backup/backup-support-matrix-iaas.md
Service: backup
GitHub Login: @AbhishekMallick-MS
Microsoft Alias: v-abhmallick

@joleito
Thanks for your feedback! We will investigate and update as appropriate.

@joleito - we have updated the doc accordingly. This will be live soon. Closing this thread as the updates are complete. Thanks. #please-close


Plaid loads different UI on electron browser as against the chrome  browser

Issue: Plaid loads different UI on electron browser as against the chrome  browser
On Chrome browser:

On Electron browser: Previously on electron browser Plaid used to load the same UI as it is on Chrome browser. Now it has changed to below
Electron version: based on Chromium 80

Expected
Plaid should load the same UI as on Chrome browser.
For us it at least impacts our automated test suites that run on electron browser

@prashantabellad I believe you simply entered into an A/B design test in our flow. If you clear cookies/cache in Electron and try opening Link again you may see a different result. We regularly run experiments to improve conversion rate in Link, which helps your users connect their bank accounts more often.

@skylarmb the electron browser is getting used in our automation test tool (cypress.io) and it executes in fresh browser every time, so this is not a cache issue. Can you pls help here?

@prashantabellad are you still seeing this behavior now? Or did you only see ~1wk ago?

@prashantabellad are you still seeing this behavior now? Or did you only see it ~1wk ago when you filed the issue?

I am still seeing this issue

@prashantabellad thanks, ive filed a ticket for our eng team to take a look at this, thanks for flagging.

@prashantabellad you will notice that this new design is now rolled out to everyone on all platforms in Link. See our blog post here: https://blog.plaid.com/the-all-new-plaid-link/


Autorender: fix writing metadata

report; https://forum.cockos.com/showthread.php?p=2280226#post2280226 (confirmed here)
@srstclair
Appreciated If you're avasilable for taking a look. :)
As far as I understand the code (and tested) it seems to be a simple fix, I might miss something though...

I haven't looked at this code in almost 10 years, but your fix seems sane to me. Thanks!

:x: Build sws 262-master failed (commit https://github.com/reaper-oss/sws/commit/55d665679a by @nofishonfriday)


Hi, will you open source the code?

Would be great to see.

Hi @Lowlowlowlowlowlow ,
Thank you for the interest. We will release the code and the benchmark upon acceptance.
Best,
Di


After upgrade no automatic checking for updates

As the title says, after an update/upgrade there should be a reset of the counter but no new check for updates is being made until the next scheduled check (i set this to every 15 minutes). Am i missing something?

You didn't miss anything. I made it so that the upgrade process is independent of plasmashell.
The advantage is that if plasmashell crashes during upgrade, the terminal won't close, as it did before. Moreover, you might decide not to proceed with the upgrade and close the terminal, making the update search unnecessary in that case.
The disadvantage is that now it's impossible to determine when the terminal has been closed in order to start a new update search, so you need to do it manually.


Can't change videoplayer

I can't change the videoplayer, i don't want to use VLC to play videos, i changed this on preferences but it still using VLC on the GUI and the CLI youtube-viewer... I'm using Arch Linux

The video player can be changing by modifying the value of video_player_selected in the "Preferences" window.
Bellow is an example for setting the VLC player:
video_player_selected => "vlc",

For setting VLC in the CLI version as well, edit the configuration file:

~/.config/youtube-viewer/youtube-viewer.conf

it's works thanks


Hosting

How do we want to host this website?

We'll use Netlify for convenience since we're going to use NetlifyCMS


Fix #286

This PR fixes #286.

On Python 3, I think virtual environment cannot be built properly (with pip) because python3-venv is not installed. Should I change my test from using is_sane to running Python executable like current tests (assert venv.run("python", "-V", shell=True).startswith("Python"))? Or should we add apt install python3-venv to Travis CI configuration?


Does Amoro provide Java API to external users

Description
Does Amoro provide Java API to external users
Use case/motivation
No response
Describe the solution
No response
Subtasks
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Do you mean whether the Amoro server provides Java API to external users?
Currently, users can use rest API to contact the Amoro server, and after #3296 has been merged, I think we can generate the SDK if needed, @mansonliwh @czy006 could you please help to give more details here, thanks.

Does Amoro provide Java APIs that support creating tables, creating libraries, deleting databases, deleting tables, modifying table fields, and modifying partitions

@jerui @klion26 We offer two ways to use the Java API:

Specify -P generate-sdk during compilation, which will automatically generate the Java API. The generated code will be located at amoro/amoro-ams/target/generated-sources/openapi.
Use the YAML file provided at amoro/amoro-ams/src/main/resources/openapi/openapi.yaml to generate API documentation with external tools such as OpenAPI Generator and Swagger Editor.

Does Amoro provide Java APIs that support creating tables, creating libraries, deleting databases, deleting tables, modifying table fields, and modifying partitions

Do you mean whether the Amoro server provides Java API to external users? Currently, users can use rest API to contact the Amoro server, and after #3296 has been merged, I think we can generate the SDK if needed, @mansonliwh @czy006 could you please help to give more details here, thanks.

Does AMORO provide APIs that support building libraries and tables, deleting libraries and tables, modifying partitions, creating new partitions, and modifying fields, as well as creating mixed iceberg and mixed hive tables


Three node generated block cost longer time than single node

Run with 3 bp nodes, sometimes it takes longer to generate the block

issue is not repro in latest dev, closed the issue


How to deal with distribution parameters that should not be fit.

How should we handle distribution parameters, that should not be fit but set at creation of the model?
Maybe a third kind of member variable Constant ? There is also theanos data type T.constant, which could be used for that.

var should have an optional argument const that will keep it fixed during minimization.


Hooks for timing?

Are there any mechanisms for collecting the time in the server spent on a request/response?

An interesting idea, and I'll give it some thought, but this is not something that has been implemented yet.

I would like something similar, at least the time of the accept. I could calculate the rest as difference from that time.

Good point @SethHamilton I'm thinking one could store the time a request is read (before its content is read) in a variable in Server::Request, and from there one could look at differences from this time. One can also time respond sends oneself using Server::Respond::send().


[#819] ensure no side effects on SinglepartWriter exception

Motivation
Fixes #819
Checklist
Before you create the PR, please make sure you have:

[x] Picked a concise, informative and complete title
[x] Clearly explained the motivation behind the PR
[x] Linked to any existing issues that your PR will be solving
[x] Included tests for any new functionality
[x] Checked that all unit tests pass

CC @mpenkov

@mpenkov can you run CI?

@mpenkov any chance this one can make next release?

Merged. Thank you @donsokolone !


Non-merged chapter duplication issue

Hi, I'm not a code-literate person so this explanation will not be consise or technical, but I'm having a problem - after updating to version 2.3 from a prior version of Neko (not sure which one, sorry) and turning on the newly added "use cached source" option for reading, most of the manga in my library have started producing duplicates of existing and non-merged chapters that act as though they weren't the same thing (reading part of one copy will not update any other copies to reflect the same change), report themselves with the same upload date/scanlation group details as the original, and do not vanish/cannot be removed in the current version of the app. I'm not sure if this problem will magically fix itself once MangaDex goes back up, but I want to report this now just in case because it is hindering my ability to use the app. As a random and possibly related aside, when I first encountered an instance of this chapter duplication, some glitch that might or might not have been related to the one I've just described set the saved page number (read: the one that gets saved to a chapter when you stop reading it and is loaded when you next click on that chapter) of all the chapters I could check to 19, which caused several crashes when trying to load chapters with less than 19 pages.

Do you have a screen shot you can share?  Alternatively message in the neko discord channel and I can look into there.

@CarlosEsco

Do you have a screen shot you can share? Alternatively message in the neko discord channel and I can look into there.

I can indeed provide a screenshot of the duplicated chapters issue for you. The manwha in the screencap only has two unique chapters in the cached source, but my installation of the app has apparently taken those two chapters and cloned them four times for a total of 10 chapters (sadly, I can't show the whole list and the name of the story without taking two screencaps).

if the screenshot doesn't show up properly then I'll go to the discord and post it there

Discord will probably work better. I was unable to see it

Did you ever fix this? Im having the same duplicate chapter problem.

Did you ever fix this? Im having the same duplicate chapter problem.

Can you provide a screenshot

It's like this
MangaDex extension is currently having issues as users may see new/duplicate chapters popping up. This is an issue on their end and will be worked at.

Closing this as cache source doesn't even exist anymore


chore(merge-back): 1.152.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 981956bf366e1a9df3e91784aa0691243069f191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 981956bf366e1a9df3e91784aa0691243069f191
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


[deps] Rocket-contrib has been split into distinct crates

In the latest master, rocket-contrib has been split into distinct crate. See issue.
Apparently, it was split into rocket_sync_db_pools and rocket_dyn_templates.
However these contain some breaking change:

We use rocket_contrib only once here: https://github.com/diem/whackadep/blob/bae00c888ed0ba9e2179966990b203da34c14dab/web-backend/ui/src/main.rs#L11
the json wrapper seems to be removed
compile_error!("at least one of \"tera\" or \"handlebars\" features must be enabled"); as specified in the above mentioned issue.

@bmwill What should we do?

We've migrated to using warp instead of rocket so this isn't an issue now


Cant input Solana Wallet info without $99/mo birdeye api

Describe the bug
if i input a solana private and public keys - it will throw errors about solana plugin (i believe due to lack of birdeye api keys) - which are expensive.
Expected behavior
a way to bypass so i can have any functionality without fetching portfolio
Screenshots

Additional context

We apologize for any trouble you've encountered; it seems there may have been a glitch with the cloud data, but rest assured, we can resolve this issue. To expedite the process, kindly follow the link below to reach our specialized support team:
ELIZA Support Request
Use the live chat button at the bottom right to connect with a support agent for prompt assistance.
Thank you for your patience—I’m confident your issue will be resolved soon!

Hi there,
We use GitHub issues as a place to track bugs and other development-related issues.
Please see the link below to our dedicated support line:
Help Center :  Click Here
Ticket ID: WB240
Note: Click on the live chat icon at the bottom corner of the page to start a conversation.

these are scam links ^
don't click.

Same here

Same here

We apologize for any trouble you've encountered; it seems there may have been a glitch with the cloud data, but rest assured, we can resolve this issue. To expedite the process, kindly follow the link below to reach our specialized support team:
ElizaOS Support Request
Use the live chat button at the bottom right to connect with a support agent for prompt assistance.
Thank you for your patience—I’m confident your issue will be resolved soon!


Adds a hitslop to the button component, and uses it in show list items

Re: LD-471
Also adds some comments to the props of the button, and removes unused props

merge on green


version 0.0.1

This is still a very rough implementation of Spamphibian, actively being worked on and is knowingly not production ready. The purpose of this PR is for any glaring high-level issues to be noted.

There are two deviations from the initial RFC.
The first deviation is that the verification service will process all objects apart from snippets before being passed to the retrieval service. This is to reduce the amount of retrieval that need to be done.
The second deviation is that instead of storing models and preprocessing pipeline in an S3 bucket that will be downloaded and run by the classification service, a separate service will run the preprocessing pipeline and models. This change was made to allow changes to be made to the model and preprocessing pipeline without having to modify the whole classification service.

Wes I think removing the sleeps from the event processing from the queues and using the redis pub/sub functionality with asyncio is not a big change or an unreasonable thing to do. I dont feel comfortable approving this without that change.
If you disagree then I think it is best that you ask someone else to review this.

@olevski Thank you for the feedback. It isn't that I disagree. Could you clarify what is unreasonable about the current implementation or the benefit of moving to the approach you suggested besides a possible minor increase in the event processing rate, which is not a priority for this solution?
From my point of view, I'm being asked to change and increase the complexity of the solution for an outcome that I don't think has any real benefit.

@olevski Thank you for the feedback. It isn't that I disagree. Could you clarify what is unreasonable about the current implementation or the benefit of moving to the approach you suggested besides a possible minor increase in the event processing rate, which is not a priority for this solution?
From my point of view, I'm being asked to change and increase the complexity of the solution for an outcome that I don't think has any real benefit.

@wesjdj ssing asyncio and redis pubsub does not increase the complexity of the code. You can do this with minimal changes actually. You can still even use a while loop inside an async function like the one below. I copied this one straight from the redis docs here.
async def reader(channel: redis.client.PubSub):
    while True:
        message = await channel.get_message(ignore_subscribe_messages=True)
        if message is not None:
            print(f"(Reader) Message Received: {message}")
            if message["data"].decode() == STOPWORD:
                print("(Reader) STOP")
                break

You can easily adapt the above further to run in Sanic because the app in sanic allows you to add asyncio tasks in the asyncio loop Sanic uses to serve requests.
from sanic import Sanic

async def handle_event(event):
    # do something with the event
    pass

async def reader(app: Sanic, channel: redis.client.PubSub):
    while True:
        event = await channel.get_message(ignore_subscribe_messages=True)
        app.add_task(handle_event(event))
            if message["data"].decode() == STOPWORD:
                print("(Reader) STOP")
                break

if __name__ == "__main__":
    app = Sanic("MyHelloWorldApp")
    # connect to redis and get a pubsub channel
    app.add_task(reader(app, channel))
    # may need to add a before_server_stop listener on sanic to make sure the pubsub reader task is cleanly done/awaited and also that any other active event handlers tasks have all completed

I think we should just merge this so it's not a PR that lives forever. It's already deployed anyways, no?


⚠ Bofrost.de has degraded performance

In ebbb55c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1568 ms

Resolved: Bofrost.de performance has improved in 4f79e81 after 18 minutes.


Issue #4 - Should Trigger Bug report in Proxy

Should trigger Bug in backlog of Proxy Router project in Jira - ABS

Alan Sorber commented: This is one comment in Jira

Hey, what about a comment from Github?

Alan Sorber commented: This is a comment from Jira with Markdown
h1. First Level Issue

bullet 1
bullet 2
bullet 3

h2. Second level issue
This is {color:#bf2600}colored{color} text
How about a picture?
!image-20230131-212742.png|width=886,height=278!

Alan Sorber commented: Comment after “done”  “closed”


Link to "full documentation" in README.md is broken

Bug report
Following the "full documentation" link results in HTTP Error 404

closed with #54


Redirect middleware packaged in @feathersjs/authentication/lib/express is mysterious and maybe unnecessary

I had created a custom route inside my apps /middleware/index.js, and set it up as a protected route as explained in authenticating express middleware recipe:
const cookieParser = require('cookie-parser');
const { authenticate } = require('@feathersjs/authentication').express;

module.exports = function (app) {
  app.set('view engine', 'pug');
  app.get('/submit', cookieParser(), autheticate('jwt'), (req, res) => res.render('submit'));
};

I wanted to change the default behavior from authenticate() rendering the provided 401 Error page to unauthenticated users that tried to access /submit, instead to redirect them to the /login route.
The recipe briefly mentions additional failureRedirect middleware to do this, and also an inverse successRedirect middleware. Both are located with authenticate() inside @feathersjs/authentication/lib/express. However, beyond that there is little guidance of how to use them.
After, some frustration and no success trying to get the failureRedirect to work, another developer helpfully referred me to Passports authenticate() documentation. That's when the lightbulb 💡 went off that Feathers' authenticate() middleware is also Passport's, and so accepts the same options!
All I ended up having to do was add an options object with a failureRedirect property:
app.get('/submit', cookieParser(), autheticate('jwt', { failureRedirect: '/login' }), (req, res) => res.render('submit'));

Likewise, for anyone wanting to pass a successRedirect.
This has left me wondering if the failure-redirect.js and success-redirect.js middleware packaged inside @feathersjs/authentication/lib/express are even necessary… or how they were intended to work in the first place 🤔
Can anyone explain how to use those middleware, and also clarify if in fact they are superfluous?
module version: "@feathersjs/authentication": "^2.1.1"

Added a snippet to feathersjs/docs#1099 for an example that highlights this issue and how it could be used. Thanks again for creating the issue @metamas!

oAuth has been changed significantly in Feathers v4 authentication including a better and more easily customizable redirect mechanism.
Please see the migration guide for more information. Closing this issue in order to archive this repository. Related issues can be opened at the new code location in the Feathers main repository.


kfctl mirror images should not hardcode the kustomize directory

Currently the mirror code assumes there is a directory named "kustomize" and then walks that directory to identify images to be mirror'd.
https://github.com/kubeflow/kfctl/blob/e96de9d7fd614f5c78b9e19609bfb2849e8297f1/pkg/mirror/mirror_image.go#L260
This doesn't work with GCP blueprints because the actual files area layed out differently. There's really no reason for the mirror command to assume the directory is named "kustomize". Instead we should add a command line flag to specify the directory and default to the current working directory.

/assign @jlewi


[Question] Hologram::delete() vs HologramManager::removeHologram()

Hi are there differences betweeen
Hologram::delete();

and
HologramManager::removeHologram();

?
Thanks!

Hologram::delete(); just removes the display from the game, HologramManager::removeHologram(); removes the hologram from the manager and also the save file

@OakLoaf Thanks, I assume if I set storage to an empty one then I won't have to call HologramManager::removeHologram() then!


Add Vsphere Lookup API

Adding vSphere endpoints for the vSphere node template UI to call and help fill form fields with real answers from a vSphere server. This PR adds a new HttpHandler for /meta/vsphere and full documentation is in confluence.

Overall I think the logic looks fine but the organization could use some refactoring. In the ServeHTTP method build a struct that holds the required info going forward. i.e. throw in the soap client, rest client assuming it doesn't need a login, the request, and the field name. This stops from having to pass the same things everywhere and cleans up the calls to something more like newclient. processSoapFinder() since everything lives off the struct. getSoapFinder can return its own struct and hang methods off that. This will save more passing around of the same things that everything uses and also helps with separation of concerns.


In Pharo 9 - Getting 'Instance of LcLibCrypto ddi not undertand #moduleName' when using JSONWebToken

I think I remember that the name of this methods changed in recent years, but also that there is a version of LcLibCrypto which is compatible with Pharo 9.

Did you check https://github.com/noha/JSONWebToken/tree/pharo9-openssl1.1 ?

I'm using this daily in pharo9 so if you agree this can be closed.

Thank you. I did not remember to check for other branches.


Stop bot from choosing threefold repetition moves if it has advantage against opponents

Like title says, is there a way we can force the bot to choose another move in order stop it from drawing by threefold rep? i got matches where i was like +8 and above and still lose by threefold rep moves

I'll look into this today, I think I can fix this issue. I'll keep you updated.

@xHeaven thank you, nice to see you as a new contributor :D Also sometime when im in mouseless mode in the middle of the auto, the bot stops and i have to start again, i will send the log here later if it happens again

@xHeaven thank you, nice to see you as a new contributor :D Also sometime when im in mouseless mode in the middle of the auto, the bot stops and i have to start again, i will send the log here later if it happens again

Hello @segahen, I think the second issue you mentioned is a duplicate of https://github.com/PanagiotisIatrou/chess-auto-bot/issues/10. Do you also notice the illegal move errors on the console when the bot stops?

Opened a PR to solve the Threefold Repetition issue: https://github.com/PanagiotisIatrou/chess-auto-bot/pull/18
Let me know when you can update us about the logs related to the bot stopping.

the threefold problem is solved, im happy with it. About the bug, i havent got it today so i dont know yet but i will post once i see

the threefold problem is solved, im happy with it. About the bug, i havent got it today so i dont know yet but i will post once i see

Have you solved it with the PR I made or you found another approach?
As for the bug, thanks in advance.

Yes i used your PR and solve it, now it only draw with insuffi materials, which is perfect to me.

Hello @segahen. Could you maybe share a game or two when this happened? Perhaps a link or the PGN. I think it would really help to investigate more on this issue.

@PanagiotisIatrou Heaven made a 3 fold check so the problem fixed :) no worry about this

e4 e6 2. Nc3 c5 3. Nf3 a6 4. d4 cxd4 5. Nxd4 b5 6. Bd3 Bb7 7. O-O Nc6 8. Nxc6
Bxc6 9. Re1 Bc5 10. Qh5 Bd4 11. Ne2 g6 12. Qh3 Bg7 13. c3 d6 14. Nd4 Bd7 15. Qg3
Qc7 $6 16. Nf5 Bf8 17. Ne3 Be7 18. Nc2 h6 19. Be3 Nf6 20. Rad1 e5 21. f3 $6 Be6
Nb4 Kf8 23. Bc2 a5 24. Nd5 $6 Bxd5 $1 25. exd5 Nh5 26. Qf2 Bg5 $1 27. a4 Bxe3 28.
Rxe3 Qb8 29. g3 Kg7 30. f4 exf4 $2 31. Rf3 Qa7 32. Qxa7 Rxa7 33. axb5 fxg3 34.
hxg3 Re8 35. Bd3 Nf6 36. c4 Nd7 37. Bf1 Nc5 38. Ra3 $6 Raa8 39. Kf2 a4 40. Re1 $6
Rxe1 $2 41. Kxe1 f5 42. Bd3 Rc8 43. Bc2 Kf6 $1 44. Kd2 $1 g5 45. Kc3 $4 g4 $2 46. Ra1 $1
f4 $1 47. gxf4 h5 $6 48. Rg1 $2 Rg8 49. Kd2 $2 Rh8 $2 50. Rg2 $2 Nb3+ 51. Ke3 Re8+ $2 52.
Kd3 $4 Rg8 $1 53. Bd1 Nc5+ 54. Kd4 Rg7 55. Rg1 Kf5 56. Rh1 Kxf4 57. Rxh5 g3 $1 58.
Rh4+ Kf5 $1 59. Rh5+ Kf6 60. Rh6+ Ke7 61. Rh1 g2 $1 62. Rg1 Rg3 $1 63. Bc2 Kd7 64.
Bf5+ Kc7 65. Bh7 Nb3+ 66. Ke4 Rg7 67. Bf5 Nd2+ $1 68. Kf4 Nxc4 69. Bg4 Rf7+ 70.
Kg3 Ne3 71. Bf3 Kb6 72. Kf2 Nc4 73. Ke2 Re7+ 74. Kd3 Ne5+ 75. Kc3 Nxf3 76. Rxg2
Kxb5 77. Rg8 Rc7+ 78. Kd3 Ne5+ 79. Kd2 Nc4+ 80. Kc2 Nb6+ 81. Kb1 Rh7 82. Ka2 Rh2
Rb8 Kc5 84. Ka3 Rh3+ 85. Ka2 Nc4 86. Rb7 Re3 87. Rb8 Kxd5 88. Rb5+ Kd4 89.
Rb4 Re2 90. Ka1 Re1+ 91. Ka2 Re2 92. Ka1 Re1+ 93. Ka2 Re2 1/2-1/2

Here is a good example that i encounterd today, i was up 4 points and could have easily trade the rook with the enemy but the bot or stockfish decided to repeat the same moves and ended up 3fold rep.

Here is a good example that i encounterd today, i was up 4 points and could have easily trade the rook with the enemy but the bot or stockfish decided to repeat the same moves and ended up 3fold rep. @PanagiotisIatrou
3fold.txt