Some reserved keywords are not allowed as route placeholders

The following route handler fails and throws an exception:
$app->get('/{route}', function (Request $request, Response $response, array $args): Response {
    $context = RouteContext::fromRequest($request);

    return $response;
});

That is because the default invocation strategy \Slim\Handlers\Strategies\RequestResponse puts the route arguments to the request attributes. So the argument route would overwrite the attribute with the same key set in the routing middleware.
The exception thrown is even misleading: "Uncaught RuntimeException: Cannot create RouteContext before routing has been completed"
Do you have an idea, how we could avoid that or should we add a hint to the docs?
Currently I guess the following keywords are reserved:

route
routeParser
routingResults
basePath

Maybe we could check in \Slim\Handlers\Strategies\RequestResponse::__invoke whether a request attribute already exists and if so, we could throw a runtime exception "Route argument x is now allowed".

No, I don't think so. Here what I just tested after seeing your issue.
$app->get('/test/{route}', function (Slim\Psr7\Request $request, Slim\Psr7\Response $response, array $args): Response {
    $response->getBody()->write($request->getAttribute("route"));
    return $response;
});

GET /test/2

Returns 2
It's working perfectly. I think there shouldn't be any reserved word in route placeholder. Also I couldn't find anything about it in docs.
So can you please post your full trace to take a look to get any hints?

@shahariaazam Now put the following line into your route handler:
$context = RouteContext::fromRequest($request); .
You will get an error. But if you change the placeholder name, everything is working as expected.
My explanations above are not based on the docs, but on the source code.

I tried the example from @adriansuter and I get the same error:
Type: TypeError
Code: 0
Message: Argument 1 passed to Slim\Routing\RouteContext::__construct() must implement
interface Slim\Interfaces\RouteInterface or be null, string given, called in
RouteContext.php on line 34
File: RouteContext.php
Line: 63

The same error occurs for route placeholders such as: routeParser, routingResults and basePath.
It could also be any other request attribute name that comes from any middleware.

I feel like we should have underscored those:

__route
__routeParser
__routingResults
__basePath

I think we still can since all we'd need to do is to change the internals of RouteContext. This would technically be a BC but since you're suppose to use the RouteContext object it's an internal BC.

Yes.

http://www.slimframework.com/docs/v4/cookbook/retrieving-current-route.html

If you ever need to get access to the current route within your application all you have to do is call the request class’ getAttribute method with an argument of 'route' and it will return the current route, which is an instance of the Slim\Route class.
From there you can get the route’s name by using getName() or get the methods supported by this route via getMethods(), etc.Note: If you need to access the route from within your app middleware you must set 'determineRouteBeforeAppMiddleware' to true in your configuration otherwise getAttribute('route') will return null. Also getAttribute('route') will return null on non existent routes.

I'd assume "many" people will already be collecting route from the request as noted on the docs, even though it uses RouteContext in the example

@juliangut the documentation is wrong, that is still from Slim 3. We need to fix that

@adriansuter do you want to PR with the underscored attributes?


Suggestion: Indicate platform author used to publish e.g (eSteem, Dtube, Steemit)

@horpeyloaded can you give more information about issue?

It is related to #724 @mistikk

@feruzm can you check this issue

@mistikk it is not same as #724, maybe horpey updated title.
This is about from which app post was submitted. Check surfer

It should be simple lines to extract from json_metadata of post and if there is no app:, it should just ignore it, if there is app, it should cut text to maximum 15 characters (NB: it shouldn't crash if no app is defined 😄)


fix(@angular/build): generate module preloads next to script elements in index HTML

The modulepreload link elements for initial scripts are now generated next to the actual script elements that require the referenced preloaded scripts. This better represents the fetch priorities to the browser and also allows easier visual discovery of the relevant script related elements inside the index HTML.

The changes were merged into the following branches: main, 18.0.x


remove unused variable in lib/flutter_nsd.dart:83:17

unused variable causes static analysis errors and reduced pub points

Thanks for the heads up. I'll take care of it.


Feature : Timeline Feature for Program Tracking

Describe the feature
Implement a timeline feature in the OpSo App to enable contributors to view and track the timeline of each program, ensuring they are well-informed and never miss any important program updates or events.
Add ScreenShots
Na
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[ ] I want to work on this issue

Can I work on this issue? I intend to create a timeline for each project, within their existing page, that provides information regarding the important dates/deadlines(much like the GSSoC website). Along with the above, I also wish to create a separate page in the menu to show a cumulative timeline showing the last date to apply for each open-source program.

Go for it @RishavKumarSinha

@RishavKumarSinha Commit these changes, and I'll review and merge them


No ACE.SVG panel after installing plugin and restarting grafana

I've installed the plugin on my grafana server 9.3.7.
Restarted Grafana.
I see in the grafana web console that the plugin is installed.
However, I do not see an ACE.SVG panel when I want to add it to my dashboard.

Fixed by setting the plugin folder rights properly on the server


Replace dc with bc

In the readme this instruction
oc set env dc/s2i-dotnetcore-persistent-ex --from=secret/postgresql -e database-service=postgresql

needs to be replaced with this instruction
oc set env bc/s2i-dotnetcore-persistent-ex --from=secret/postgresql -e database-service=postgresql

(bc for buildconfig instead of dc of deploymentconfig)
Thank you

Thanks for opening this issue!
I just tried this out and I can't help but this it's correct as-is.
In the oc set env command, we want to set up the environment of the deployment, not the build. It's the deployment that needs access to the postgres database, including the secrets and database service.
I just tried it out and the original command works fine as written.
Can you please share more information on why you think it needs to be changed from dc to bc?
cc @tmds

I think you are right, in my notes I'm using dc as well. I don't remember in which context I needed to switch to bc. I think you can close the issue, sorry for this.


Databricks SQL Analytics endpoint does not support set statements

Describe the bug

We use set statements as part of the incremental materialization, specifically for the insert_overwrite strategy with partitioned tables:
https://github.com/fishtown-analytics/dbt-spark/blob/0e75069c3c223546ecec2c6038534d826e9a7dd8/dbt/include/spark/macros/materializations/incremental.sql#L103-L111
This is currently causing a failure in our integration tests.
Incidentally, the SQL Analytics endpoint doesn't support the merge strategy either, since it requires creating a temporary view as currently written. Databricks has promised that create temp view will eventually be supported by the new endpoint.
Steps To Reproduce
Try running any incremental model while connected to a SQL Analytics endpoint
Expected behavior
The weird thing is that set statements used to work. I only saw this crop up in the integration tests for #132; something has definitely changed in the last few weeks.

Weird stuff. Did the Databricks Runtime change?
It works with Runtime 7.5:

@Fokko That's just the problem: this works fine on interactive / all-purpose clusters running the latest Databricks runtime versions; it's not working on SQL Analytics endpoints (accessible via the new / preview Redash query editor).


JavaScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

That was bloody hard.


Anything we could do with binding energy shown in the figure?

That is just the binding energy of the structure, Its there just to let the readers know that different structures have different energy. Other than that, I don't see any point. (For the HW)

I guess we have to compare . But when we estimate binding energy per ion from the potential value we obtained it is not close enough. So there might be different way to do it.


NPM Install issue

I am on Windows 7, using Node 8.9.1.   When running "npm install, I am getting:
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\lernera\AppData\Roaming\npm\node_modules\npm\bin\
npm-cli.js" "install"
npm ERR! node v8.9.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node scripts/build.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/build.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs node-sass
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\projects\syntaxhighlighter\npm-debug.log

I've had this issue at work. It was due to an outdated version of node-sass. I would try installing nvm and pointing it your node version to 6 and see if that works.

Hi guys, to solve this kind of issue I've created a docker image to build syntaxhighlighter with a simple Docker image and you can also add custom brushes / themes : https://github.com/crazy-max/docker-syntaxhighlighter


Fixed crash when removing some shortcuts from Editor Settings

Fixes: #51794

Didn't it cause a crash on reboot ?

Sorry, i messed up. I should open new PR


Start using new token everytime entitlements are re-fetched

Everytime we 'authorize' https://github.com/almighty/almighty-core/blob/master/controller/workitem.go#L142 users ( eg, check if user is authorized to edit workitem ) , these are the following steps that happens in the background :

check if user is the space owner, then Authorized = True.

check if the token is a RPT token,

if yes , we fetch the entitlements from the token and decide.
- we check if token is outdated, if yes:
we fetch the RPT token using the keycloak entitlements' API.

if no, we fetch the RPT token using the keycloak entitlements' API.

Optimization suggestion:
Should we return the new RPT token as part of the response, and the UI should henceforth use the newly generated token for all subsequent tasks. This avoids talking to KC repeatedly and this approach may also be used to avoid refreshing RPT tokens blindly at frequent intervals.

@sbose78 what is your approach the text in bold ? The entitlement endpoint is a current bottleneck for us, so whatever limits the amount of calls to this endpoint (the better).

@hectorj2f
This is the solution I suggest ( though a bit messy with jsonapi )

if no, we fetch the RPT token using the keycloak entitlements' API.
Should we return the new RPT token as part of the response, and the UI should henceforth use the newly generated token for all subsequent tasks.

Should we return the new RPT token as part of the response, and the UI should henceforth use the newly generated token for all subsequent tasks.

I think we should limit the logic handled by the UI or any other client.
Other questions:
What is the benefit ? Do we think that can saturate KC ? Does this increase the response time in these operations ?
Maybe we shouldn't care much unless if we see this as a current problem.

This is related to https://github.com/almighty/almighty-core/issues/1300
We should stop obtaining Entitlement for all available resources (an RPT token which contains all available resources). Alternatively we could start with an "empty" access token and then each time some service calls the core API to access some resource we add this resource to the token and return the new token as a response header so the service (UI or something else) can save it and use it the next time.
So we will always keep some number of last used resources in the token.

Understood @alexeykazakov ,
So this is what we might do -
To check if the user is authorized to a space:

check whether the entitlement info for the space resource is present in the token claims.
if not, we call the entitlements API to get the info ; if yes, we don't proceed to the next steps since we already have the answer.
update the entitlement info for the space resource into the token ( unwrap the token , and then wrap it back ).
return the access token with new entitlement info in the claims in the response header.

Is this what you have in mind, @alexeykazakov ?

@sbose78 yes, this is what I was thinking about. The step #3 will be actually performed by KC. If we pass an RPT token which already has some resource listed when obtaining a new entitlement then KC will return an RPT token with all resources originally listed in the token + the resource we are asking access to. They call in Incremental Entitlement. The missing thing here is some mechanism which will allow us to limit the number of the resources in the token. Otherwise the token will be always grow (every time we obtain an entitlement we will add a new resource to the token). We discussed it with the Keycloak guys and they will add such functionality.

Thanks @alexeykazakov .

We discussed it with the Keycloak guys and they will add such functionality.

In that case, we are good.
We can start using RPT for login, and as well as for entitlements' info.

Closing this because

@hectorj2f ran performance tests which confirmed that fetching targetted resource entitlements isn't  expensive at the moment https://docs.google.com/document/d/1nXzEE_lPf6tmsJLcVu5l7O59KcOS4rNUYb8oB6KIQvI/edit

we are not fetching all entitlements anymore anywhere.


Refactor tests for compression codecs

Motivation:
Too many duplicated code of tests for different compression codecs.
Modifications:

Added abstract classes AbstractCompressionTest, AbstractDecoderTest and AbstractEncoderTest which contains common variables and tests for any compression codec.
Removed common tests which are implemented in AbstractDecoderTest and AbstractEncoderTest from current tests for compression codecs.
Implemented abstract methods of AbstractDecoderTest and AbstractEncoderTest in current tests for compression codecs.
Added additional checks for current tests.
Renamed abstract class IntegrationTest to AbstractIntegrationTest.
Used Theories to run tests with head and direct buffers.
Removed code duplicates.

Result:
Removed duplicated code of tests for compression codecs and simplified an addition of tests for new compression codecs.

@normanmaurer @trustin I've rewrote test with new Theories from jUnit 4.12 and now all tests run with head and direct buffers. Please, review.

But I think that we may encounter with problem like #2707 again.

Looks good to me. Could you make sure the build time did not increase when -Pleak option is specified?

@idelpivnitskiy Ping :-)

@trustin let me check it on weekend :)
but i think that time will increase anyway... cause we will run each test twice

@trustin The build time decreased :) because the problem was with Bzip2 codec and now we decrease the size of BYTES_LARGE array for all tests from 9 * 100000 + 256 to 256 * 1024.
Before refactoring with -Pleak:
Bzip2EncoderTest: 16.47 sec
Bzip2DecoderTest: 65.592 sec

LzfEncoderTest: 1.411 sec
LzfDecoderTest: 2.19 sec

Lz4FrameEncoderTest: 0.243 sec
Lz4FrameDecoderTest: 2.098 sec

LzmaFrameEncoderTest: 11.744 sec

Total time for netty-codec: 3:56.150s

After refactoring with -Pleak:
Bzip2EncoderTest: 13.479 sec
Bzip2DecoderTest: 43.371 sec

LzfEncoderTest: 4.001 sec
LzfDecoderTest: 5.457 sec

Lz4FrameEncoderTest: 1.395 sec
Lz4FrameDecoderTest: 5.436 sec

LzmaFrameEncoderTest: 7.581 sec

Total time for netty-codec: 3:13.856s

I used 9 * 100000   256 which was greater then the max block size for Bzip2, because we use a random block size for each test. We may change it from random to min block size, so it would be less than our new BYTES_LARGE and compressed data always will consist of few blocks. WDYT?

Sounds good to me. Is it ready to merge, then?

yes, if netkins won't mind :)

@netkins build

no tests run

ping

@netkins build

@idelpivnitskiy sorry for the delay...
Cherry-picked into 4.1 (c9adb416362cca3190eafbeaab13e6e8f6ab433c) and master (6928a2d79fd351e123851e4b14eeec28f3f8c593)


Add 1-19 main post submit

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/lgtm


C#: Fix CFG for unknown expressions

Fix the CFG for unknown expressions, which were previously excluded from the control flow graph, which could lead to an incomplete graph.
Add a test for this change, and also test the extraction of initializer-lists with unknown expressions. This test will currently fail on this branch as it tests extractor changes.

@calumgrant : Should this go into 1.18?

It should be in sync with the corresponding changes in Semmle/code (https://git.semmle.com/Semmle/code/pull/26692), so yes. I'll rebase, but it will conflict with #163.

Does this need a change note, or don't customers need to know about the change?


Standard debug Activity

Description
Added standard debug activity. The id optional and a random one is used when it is not set.
Added outputs for the activity. Added unit tests and documentation.

@symphony-soufiane should we remove this Debug activity from the nodes list endpoint? as it is for debug purpose only.

@symphony-soufiane @ystxn should we remove this Debug activity from the nodes endpoint response? as it is for debug purpose only.

no need to specially exclude. since this sets the output variable, it could be used in the monitoring endpoints to inspect an event etc, so it should be consistent with the nodes list.


Add scan and while rule for jax.experimental.callback transformation

I suggested some tweaks but since this is in jax.experimental let's just land and iterate.


Search bar moved up

Could you add a screenshot of your work?

But the Login / Sign Up is shrinked. Could you also add a screenshot in mobile view?

I have created another PR you can check the responsiveness there


Improve DropDownButton

Allow displaying nested items
Allow displaying a check mark in front of a menu item
Improve display of buttons with only an icon
Ensure only one drop down button shows its menu at the same time

Coverage remained the same at 99.095% when pulling c01db6816ba48b91578f45d2e2acbf1de84494fb on tf:drop-down-button-improvements into 349014fc4d1a911fb1beccbb3c5cad84e1e4a379 on codevise:master.


[Safe Apps] Remove app selection sidebar

Remove the sidebar which is used to select Safe Apps as the Safe App selection will move to the overview page (#1294) or the Safe App favorites, respectively (#1293).

The border around the iframe should also be removed, with Safe Apps being required to implement their own padding (most already have)

Depends on #1294
#1293 depends on this ticket.

Can this be closed / merged with #1294? Or maybe just reduced to the iframe border topic? @tschubotz

I was under the impression that #1294 would already do this. So I'llclose this one.


invalid back reference on MSYS2

Hello,
the line
https://github.com/mhinz/vim-startify/blob/81e36c352a8deea54df5ec1e2f4348685569bed2/autoload/startify.vim#L662
leads to an error message
line    4:
/c/\12
line    5:
E65: Illegal back reference

as shown by
let fname = '/c/\12'
let fname = fnamemodify(fname, ":p")
let fname = glob(fname)

if v:oldfiles contains file paths with back and forward slashes (as happens when using Vim in MSYS2 and Windows).
Maybe the slashes should be all converted to \
if exists('+shellslash') && !&shellslash

and to / otherwise?

Just experienced an issue with this same line in s:filter_oldfiles_unsafe(...). Turned on s:filter_oldfiles_unsafe = 1 and now i see: E944: Reverse range in character class when i start gvim. The same issue i think, special characters in fname cause errors.
Example of my issue with this line caused by [ ] in fname:
let fname = 'D:\test\.vimrc [automatic-backup].vimrc'
let absolute_path = glob(fnamemodify(fname, ":p"))
E944: Reverse range in character class

Doing this before fnamemodify(...) will fix my issue but more robust special-character escaping is needed for all cases:
let fname = substitute(fname, '\[', '\\\[', 'g')
let fname = substitute(fname, '\]', '\\\]', 'g')

By :help wildcards,
	?	matches one character
	*	matches anything, including nothing
	**	matches anything, including nothing, recurses into directories
	[abc]	match 'a', 'b' or 'c'

therefore something like
if exists('+shellslash') && !&shellslash
  " win32
  let fname = substitute(fname, '\([[\]*?]\)', '\\[\1]', 'g')
else
  let fname = substitute(fname, '\([[\]*?\\]\)', '\\\1', 'g')
endif

should work

The win32 section needs some changes. Its causing files like D:\[test].txt to be filtered out of the recent file list.
let fname = 'D:\test\.vimrc [automatic-backup].vimrc'
" win32
let fname = substitute(fname, '\([[\]*?]\)', '\\[\1]', 'g')
echo fname
" D:\test\.vimrc \[[]automatic-backup\[]].vimrc

I think it should be: D:\test\.vimrc [[]automatic-backup].vimrc
The following fixes the win32 side:
if exists('+shellslash') && !&shellslash
  " win32
  let fname = substitute(fname, '\[', '\[[]', 'g')

  " Don't think this line is needed. Windows paths can't contain '*' and '?' (well there are exceptions to this, like DOS device paths can contain '?', https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats but i don't think they need to be escaped? Unless vim still requires they are? Hmm.
  let fname = substitute(fname, '\([*?]\)', '\\\1', 'g')
else
  let fname = substitute(fname, '\([[\]*?\\]\)', '\\\1', 'g')
endif

Good question. I copied the let fname = substitute(fname, '\[', '\[[]', 'g') line from the s:show_sessions() function. From what i can tell let fname = substitute(fname, '\[', '[[]', 'g') works identically, i.e. \[[] and [[] both insert [[]. Not sure why '[' is escaped? Help indicates some characters have special meaning in the {sub} argument (but nothing related to '[' that i could see).
:h substitute()
:h sub-replace-special


Accessibility - Focus Management

Hi,
As per WCAG standards, a datepicker calendar is expected to work like a modal dialog and is expected to retain focus and add a backdrop which could be used to indicate that the content is disabled. Also that the arrow keys can be used to navigate between dates rather than the tab keys.Please let me know if this is something that can be planned.

@kekeh would you think this is a valid use case that can be taken up for development?


Api key Issue

when I try to access /hello/api-key
I got "Need API Key message"

I missed something. and then I fixed it


Add console output to Extending Leaflet example page

Console output is missing in one code block in Extending Leaflet example page. Would be cool to add it ;)

Source file is here: docs/examples/extending/extending-1-classes.md

I'll help :)


Bug: Help menu in plugin list

Describe the Bug
Please see screenshot.

@ms3056 , can you consistently recreate this? I have been unable to do so.
Could you try restarting Obsidian a couple times and seeing if the issue persists?
Also, how are you reproducing this issue?
This is the same as #564 which has been labeled as a fluke for now.

I reached out in the discord and found out that this may actually be a bug caused by the Linter. I will make a change and issue a patch. Hopefully it will resolve the issue, but I am not sure if it will since I am unable to reproduce this locally at this time.

I just merged in a potential fix for this and created a release. Could you update and see if the issue has been fixed @ms3056  and @Liong1976?
Thanks!

It is working well now. Thanks, @pjkaufman

I am glad to hear that. I will close this issue in a couple if days if I don't hear any new reports about it.

I am closing this as I have not heard any new reports of the issue.


Allow logging outside of setting the logging callback

Addresses Issue #102 to enable logging to stdout independent of OE SDK
Implements OE SDK ask to enable testing without on-demand registration, if desired
Moves the environment variable functionality into a header file

The logging for parameters passed in sgx_ql_get_quote_config() is only on when the target was Not found in the cache. Could you take this chance to enable logging when cache was hit as well?

@soccerGB logging for parameters happens regardless of caching or not - is there a specific parameter I am missing?
1: Azure Quote Provider: libdcap_quoteprov.so [INFO]: Fetching quote config from cache: 'https://global.acccache.azure.net/sgx/certificates/v2/e40610aa353e1bb52385aba37e8acadb/0f0f0205ff8007000000000000000000/0a00/0000?clientid=production_client&api-version=2018-10-01-preview'.


wljoywake: init at 0.3

Description of changes
https://github.com/nowrep/wljoywake
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3801

Please migrate to pkgs/by-name.

I'm not sure what this means. Are you referring to the location of the files?
I was also unable to find any documentation on this. Do you have a link?


[Barcalona] REST API replies include stack traces

Some of the REST endpoints in the core-metadata service return Java stack traces when errors occur, including NotFound and DataValidation errors.
The first can be seen by running querying the metadata service for a service which doesn't exist using curl command (note, you may need to change the hostname depending on your setup):
$ curl -w "%{http_code}" http://localhost:48081/api/v1/deviceservice/name/no-such-device-service
The second can be seen by trying to add a deviceservice which has no addressable or already exists (a service with that name is already registered), which can be seen by running the following curl command:
$ curl -w "%{http_code}" -H 'Content-Type: application/json' -d '{"id":null,"created":0,"modified":0,"origin":666,"name":"tony-ds","method":"POST","protocol":"HTTP","address":"localhost","port":51,"path":"/api/v1/callback","publisher":null,"user":null,"password":null,"topic":null}' http://localhost:48081/api/v1/deviceservice
Here's what the stack trace for the latter looks like:
Improper data:  Name is not unique: device-service-test
org.edgexfoundry.exception.controller.DataValidationException: Improper data:  Name is not unique: device-service-test at org.edgexfoundry.controller.impl.DeviceServiceControllerImpl.add(DeviceServiceControllerImpl.java:303)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:832)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:743)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:961)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:895)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:967)

Turns out the inclusion of stack traces is controlled by a service property called print.stacktrace, which is enabled by default, and turned off explicitly in the docker images.  As I was running the core services from my snap, this value was still set to it's default.  I'm closing this...


Improve usage of singleton configs

Closes #335

test this please

test this please

test this please

test this please

test this please

test this please


docs(fsengage): expand analytics docs

reordered information, expanded each section with more explanation to give a clearer idea of overall workflow, and added table of contents.

🥇


isolatedDeclarations doesn't support tsconfig options

Some tsconfig options are relevant for declaration emit, but there's currently no way to pass these.
> code = "/** @internal */ export function hello() {}"

> require("oxc-transform").isolatedDeclaration("example.ts", code)
{ errors: ['TS9007: Function must have an explicit return type annotation with --isolatedDeclarations.'] }

> require("typescript").transpileDeclaration(code, {})
{
  diagnostics: [{
    messageText: 'Function must have an explicit return type annotation with --isolatedDeclarations.',
  }]
}

> require("typescript").transpileDeclaration(code, { compilerOptions: { stripInternal: true } })
{ outputText: 'export {};\n' }

Thanks for trying it out, in addition to supporting passing tsconfig options we also need to check the jsdoc @Boshen cc

https://x.com/TitianCernicova/status/1808132493469442398

If stripInternal is specified TSC will respect the internal JSDoc tag even if ID is specified, and this is the behavior that is expected of other DTS implementations.

internal is useful as an escape hatch for functions you might export from a module, but don't actually want to export from your package so they don't need to make it into declaration files.

Close as not planned. It seems like ID shouldn't check jsdoc nor tsconfig :-/

It's my understanding that isolatedDeclarations is mostly about not running a full typechecker to emit declarations.
Are there potential perf issues with supporting this or is it simply out of scope?

I've found that most of the popular libraries use @internal directive and strip them by stripInternal. So I think we should consider supporting it.


push not working in android 8 when app is in background

Expected Behaviour
when app is in background push badge should apear
Actual Behaviour
no push when app in in background
Reproduce Scenario (including but not limited to)
Steps to Reproduce
phonegap :

<preference name="android-minSdkVersion" value="14" />
<preference name="android-targetSdkVersion" value="26"/>

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
phonegap
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3)
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
phonegap CLI version and cordova platform version
cli-6.5.0 (4.3.1 / 6.1.2 / 4.4.3)
Plugin version
<plugin name="phonegap-plugin-push" source="npm" spec="~1.8.4">

Sample Push Data Payload
$str = '123456789';
$randomid = str_shuffle($str);
$fields = array
(
'to' =>   $zone ,
'priority' => "high",
'content-available'=>"1",
'data' => array("title" =>$titlepost, "body"=> $msg,'android_channel_id' => "13", "notId" => $randomid, "msgtype" => $type, 'content-available'=>"1")
);
$headers = array('Authorization: key=' . API_ACCESS_KEY,'Content-Type: application/json');
// echo ("headers:"); print_r($headers);
$ch = curl_init();
curl_setopt( $ch,CURLOPT_URL, 'https://fcm.googleapis.com/fcm/send' );
curl_setopt( $ch,CURLOPT_POST, true );
curl_setopt( $ch,CURLOPT_HTTPHEADER, $headers );
curl_setopt( $ch,CURLOPT_RETURNTRANSFER, true );
curl_setopt( $ch,CURLOPT_SSL_VERIFYPEER, false );
curl_setopt( $ch,CURLOPT_POSTFIELDS, json_encode($fields));
$result = curl_exec($ch );
$result1=json_decode($result);
curl_close( $ch );
Sample Code that illustrates the problem
Logs taken while reproducing problem
android 8 push not working... i tried to upgrade to ver 2.1.3 of the pushplugin but having the same problem... if i try PushNotification.createChannel it dosent exists

triend again on v2 of the plugin now its working tks

@brunoalex which version have you used because my app is not update badge automatically

This PR solves the issue https://github.com/phonegap/phonegap-plugin-push/pull/2369


Update to bring in line with ILRI branding

Need to follow up with CKM team to see what is needed in the following areas:

links to other ILRI sites
logos (ILRI and CGIAR?)
footer

Check the footer on any ILRI blog, for example: http://clippings.ilri.org/
Must add a CGIAR logo
Must add basic navbar at top with links to at least ILRI homepage and others
Must add standard copyright (check footer of ILRI homepage)


Fixed dropdown filter highlight not change after select a new option

This is great! You're totally right @reindeeruz , thank you for taking the time to submit the PR.
I've merged it into master, it'll be available later today as 4.0.12 after I merge a few more non-breaking changes. Cheers! Keep 'em coming.


Style no-attributes edge case

This issue is imported from pivotal - Originaly created at Jun 2, 2021 by Koen Cornelis
When no APR attributes are released but ARP is enabled, you get a shoddily styled explanation message.
See screenshot in comments for an example.

When an SP does not get IDP-attributes (ARP-enabled but empty), there's no styling for the informative text.
The idea is to add styling where there's a similar box, but without the gray bar. (Koen Cornelis - Jun 2, 2021)


Hooks results db persist

Codecov Report

Merging #1470 (ae41c2d) into master (7d63bc5) will increase coverage by 0.07%.
The diff coverage is 75.75%.

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
+ Coverage   39.37%   39.44%   +0.07%
==========================================
  Files         161      161
  Lines       12893    12918      +25
==========================================
+ Hits         5076     5095      +19
- Misses       7086     7089       +3
- Partials      731      734       +3

Impacted Files
Coverage Δ

catalog/entry_catalog.go
12.96% <0.00%> (ø)

actions/service.go
75.75% <80.64%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d63bc5...ae41c2d. Read the comment docs.

Replaced by PR #1486


Svm pr fix

@MaAleBarr I think this PR is ready to be merged. The attack and classification notebooks run successfully.


Problem of username selection: improvements

Right now we give user exactly the same name/id, that he has in the initial system (codehub/github).
We need to support two main things on the frontend:

"Registration"-like page, where user will be able to change/update his nickname OR use one we have suggested;
Possibility to change nick-name (if it is not yet used by other people).

Important task

It's also crucial to keep the original login in the database to be able to identify future logins. If we want to support merging multiple OAuth login under the same account, this original_login column may become a list in the future


feat: Access params ActionMailer::Preview style

What are you trying to accomplish?
Make ViewComponent::Preview API more similar to ActionMailer::Preview
What approach did you choose and why?
In ActionMailer::Preview, params are accessible as params, thus it would be nice to have same API in ViewComponent::Preview
class ButtonComponentPreview < ViewComponent::Preview
  def default
    render(ButtonComponent.new(root_path, size: :standard)) { params.fetch(:text, "Button") }
  end
end

Anything you want to highlight for special attention from reviewers?
This is a topic-starter, not a real PR. If the idea is approved - I can work on specs.

@ixti this makes sense to me! ViewComponent previews are meant to mimic ActionMailer previews. Are you up for writing the PR?

@ixti this makes sense to me! ViewComponent previews are meant to mimic ActionMailer previews. Are you up for writing the PR?

Sure. Just wanted to make sure the change could be ever considered before I spent more time on it :D


Mixed gif and base64 output

The gif above :leopard:  is behaving strangely.
Has happened multiple times.
iTerm Build 2.9.20160206
Any idea why?

I guess it started outputting another gif, while previous output was still in progress, that's why it's mixed. Would you like to try submitting a PR for this fixing this issue?

I would, will try this weekend once I have some free time!

Cool, thanks, no pressure ;)

Took a stab at this today.
Tried running it through node-inspector but couldn't find the issue.
For a trivial package.json setup this never happens. Namely my random test dependencies:
  "dependencies": {
    "bootstrap": "^3.3.6",
    "jquery": "^2.2.1",
    "phantomjs": "^2.1.3",
    "polymer": "^0.5.0"
  }

On the other hand when installing these "real-world" dependencies with gifi, the third gif always seems to be spit out as base64. This is not totally reproducible an seems to happen on different times each run which makes me think specific gifs are causing this issue, maybe a problem with decoding huge gifs.


Migrate FFI to ES modules

Description of the change
Migrates FFI to ES modules

Checklist:

[ ] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation
[ ] Added a test for the contribution (if applicable)

Done in #20


Fix wrong number of args for IsSlice

The following error message is received when the hugo site is run with this module
: wrong number of args for IsSlice: want 1 got 0
In the twitter.html partial, there is an if statement that checks if .Params.authors is a slice. If it is, the code attempts to retrie the Twitter handle of the first author using index . 0. However, the if statement is not properly closed with an end statement. As a result, the subsequent with statement is being executed regardless of whether .Params.authors is a slice or not, and the reflect.IsSlice function is being called without any arguments.
To fix this error, added an end statement after the last end statement in the twitter.html partial. This properly closes the if statement and ensure that the subsequent code is only executed when .Params.authors is actually a slice:

Thanks for the PR.
I am super busy with work at the moment (24/7) so I'll trust you have done an amazing job and merge it.


Add exit hook arg to family

Added exit hook to Family class and propagation to children
Exit hooks are ordered with priority to the outer most family first

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Please don't print errors to stderr

See KW_renderdriver_sdl2.c for examples.  This is pretty icky as I'm currently writing a CHICKEN binding for KiWi and printing to stderr does interfere with CHICKEN's error reporting mechanism (throwing exceptions) and makes it impossible to do any better as there's no way of retrieving the error message.

I'm printing to stdout now, but I was not sure if this fixes your problem. Maybe we can use the SDL_SetError, if printing to stdout is a problem to you.

I consider it an error if a library prints messages.
There are a number of mechanisms to signal errors, what I've come across so far were using a different return code and a function to retrieve the error message, changing a passed reference (useful when one cannot use the status code or for out-of-band reporting) and having an error callback argument.
The first would suffice as asking SDL for the error is apparently enough. What would need updating though would be the existing documentation to point out what can error out under which conditions.

Same applies to the instances of SDL_LOG in KW_ProcessEvents.  I expect any logging to only happen if I explicitly enable it, not for things like typing letters into an editbox.

That was a debug leftover, you're right.
Em qui, 19 de mai de 2016 às 10:27, Vasilij Schneidermann <
<EMAIL_ADDRESS>escreveu:

Same applies to the instances of SDL_LOG in KW_ProcessEvents. I expect
any logging to only happen if I explicitly enable it, not for things like
typing letters into an editbox.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/mobius3/KiWi/issues/6#issuecomment-220323576

Now that I'm actually writing error handling for my bindings, I have a clearer idea what steps would be needed for handling this properly:

Remove debug printing
Offer functions for retrieving a message on an error condition, ideally by just wrapping IMG_GetError and TTF_GetError
Document how one fetches errors, add it to the examples


if restarting the homebridge server, the plugin stops working

Describe Your Problem:
After the first successful config, I generate the certificates through the UI of homebridge (not using the SSH terminal) and it works perfectly. But if I restart the server, the plugin stops working, I assume because it cannot find the certificates.
The certificates are saved in .txt format in the root directory of homebridge server, that I'm running on a Synology NAS.
If I reconfigure again the plugin with the path of the .txt files, It seems it cannot find them.
Logs:
[3/17/2024, 12:53:14 AM] [Bosch] Error during call to BSHC:  Error: write EPROTO 0058C8ADA67F0000:error:0A000412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1586:SSL alert number 42
at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:94:16) {
errno: -71,
code: 'EPROTO',
syscall: 'write'
}
[3/17/2024, 12:53:20 AM] [Bosch] Error during call to BSHC:  Error: write EPROTO 0058C8ADA67F0000:error:0A000412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1586:SSL alert number 42
Plugin Config:
{
"name": "Bosch",
"host": "<IP_ADDRESS>",
"autoPair": true,
"systemPassword": "XXXXXXXX",
"platform": "BoschAlertHomebridgePlugin"
}
tried also:
{
"name": "Bosch",
"host": "<IP_ADDRESS>",
"autoPair": false,
"clientCert": "bosch-client-cert.txt",
"clientKey": "bosch-client-key.txt",
"systemPassword": "XXXX",
"platform": "BoschAlertHomebridgePlugin"
}
and in this case I get: [3/17/2024, 12:57:43 AM] [Bosch] error:0480006C:PEM routines::no start line
[3/17/2024, 12:57:43 AM] [Bosch] error:0480006C:PEM routines::no start line
Screenshots:

Environment:

Plugin Version:  v1.0.2
Homebridge Version:
Node.js Version: Node.js v21.7.1
NPM Version:
Operating System: Synology DSM 7.2.1-69057 Update 4

@arnecls I know that you don't visit this plugin page often, but if you think about something, it would be very helpful :) thanks


failed to create containerd container: taking runtime copy of volume

I'm attempting to run Istio in my Kubernetes 1.8 cluster, but I'm getting an error when trying to run the Prometheus pod.
Environment
kubectl version

Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.0", GitCommit:"6e937839ac04a38cac63e6a7a306c5d035fe7b0a", GitTreeState:"clean", BuildDate:"2017-09-28T22:57:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.0", GitCommit:"6e937839ac04a38cac63e6a7a306c5d035fe7b0a", GitTreeState:"clean", BuildDate:"2017-09-28T22:46:41Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

cri-containerd --version

1.0.0-alpha.0

Steps to reproduce
Setup Kubernetes 1.8 and install Istio and the Istio Prometheus addon.
Logs
containerd
journalctl -u containerd --no-pager -f

-- Logs begin at Tue 2017-10-03 04:48:45 UTC. --
Oct 03 04:51:21 kube containerd[3149]: time="2017-10-03T04:51:21Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/e84cfdb8fd6ea9a48def179caf76cd762d781665563fb075e9e31c1a939ce769/shim.sock" debug=false module="containerd/tasks" pid=11288
Oct 03 05:00:33 kube containerd[3149]: time="2017-10-03T05:00:33Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/a849f85eafdf49ae6348b95fa16fe2ae692cff2c14c1fb77b6d21dd0d016cdcb/shim.sock" debug=false module="containerd/tasks" pid=24435
Oct 03 05:00:34 kube containerd[3149]: time="2017-10-03T05:00:34Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/58a4f05b3ec225c182f2ba21d81d3d9a492c0d9be58230c416ab082bdd96a816/shim.sock" debug=false module="containerd/tasks" pid=24539
Oct 03 05:00:35 kube containerd[3149]: time="2017-10-03T05:00:35Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/2b84b1a0d60d954b3691cd44be72743ad5f3632db552c0f27e97a501acaa599d/shim.sock" debug=false module="containerd/tasks" pid=24971
Oct 03 05:00:36 kube containerd[3149]: time="2017-10-03T05:00:36Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/ffa0c4b1387d1d1b25d26e02bd69224b2664fc75566605b581b92d32b3ac9260/shim.sock" debug=false module="containerd/tasks" pid=25140
Oct 03 05:00:37 kube containerd[3149]: time="2017-10-03T05:00:37Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/b103efd8d0ea944fe7c61bf6deed3e3b478c7b74de3724564195f5a19446fb63/shim.sock" debug=false module="containerd/tasks" pid=25748
Oct 03 05:00:38 kube containerd[3149]: time="2017-10-03T05:00:38Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/3d0bf55b9b9949cef4516203cc322025f5cd785cbddace2b9a7b6a0dc7d6006e/shim.sock" debug=false module="containerd/tasks" pid=25835
Oct 03 05:00:39 kube containerd[3149]: time="2017-10-03T05:00:39Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/4c7c11095a0da61a824352cf5a11c1ce3379e19c0c9dfde47f0b000dc30f7086/shim.sock" debug=false module="containerd/tasks" pid=26385
Oct 03 05:00:39 kube containerd[3149]: time="2017-10-03T05:00:39Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/91622bcddca0d67ea0aca948bcc7743c0eabd38802a2783ede00f1efb692060a/shim.sock" debug=false module="containerd/tasks" pid=26466
Oct 03 05:01:30 kube containerd[3149]: time="2017-10-03T05:01:30Z" level=info msg="shim containerd-shim started" address="/containerd-shim/k8s.io/819435d7b85d7f4557e36ba870f13d5077f4ad7110c6d1cb61bbb15143272acb/shim.sock" debug=false module="containerd/tasks" pid=5423

cri-containerd
journalctl -u cri-containerd --no-pager -f

Oct 03 05:39:49 kube cri-containerd[3164]: E1003 05:39:49.982651    3164 instrumented_service.go:112] CreateContainer within sandbox "819435d7b85d7f4557e36ba870f13d5077f4ad7110c6d1cb61bbb15143272acb" for &ContainerMetadata{Name:prometheus,Attempt:0,} failed, error: failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume448288654/prometheus: no such file or directory
Oct 03 05:40:02 kube cri-containerd[3164]: E1003 05:40:02.982637    3164 instrumented_service.go:112] CreateContainer within sandbox "819435d7b85d7f4557e36ba870f13d5077f4ad7110c6d1cb61bbb15143272acb" for &ContainerMetadata{Name:prometheus,Attempt:0,} failed, error: failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume327745008/prometheus: no such file or directory
Oct 03 05:40:14 kube cri-containerd[3164]: E1003 05:40:14.978582    3164 instrumented_service.go:112] CreateContainer within sandbox "819435d7b85d7f4557e36ba870f13d5077f4ad7110c6d1cb61bbb15143272acb" for &ContainerMetadata{Name:prometheus,Attempt:0,} failed, error: failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume223115426/prometheus: no such file or directory

kubelet
journalctl -u kubelet --no-pager -f

Oct 03 05:41:08 kube kubelet[3189]: I1003 05:41:08.917481    3189 kuberuntime_manager.go:499] Container {Name:prometheus Image:quay.io/coreos/prometheus:v1.1.1 Command:[] Args:[-storage.local.retention=6h -storage.local.memory-chunks=500000 -config.file=/etc/prometheus/prometheus.yml] WorkingDir: Ports:[{Name:web HostPort:0 ContainerPort:9090 Protocol:TCP HostIP:}] EnvFrom:[] Env:[] Resources:{Limits:map[] Requests:map[]} VolumeMounts:[{Name:config-volume ReadOnly:false MountPath:/etc/prometheus SubPath: MountPropagation:<nil>} {Name:default-token-ntt7l ReadOnly:true MountPath:/var/run/secrets/kubernetes.io/serviceaccount SubPath: MountPropagation:<nil>}] LivenessProbe:nil ReadinessProbe:nil Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:IfNotPresent SecurityContext:nil Stdin:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.
Oct 03 05:41:08 kube kubelet[3189]: E1003 05:41:08.975051    3189 remote_runtime.go:187] CreateContainer in sandbox "819435d7b85d7f4557e36ba870f13d5077f4ad7110c6d1cb61bbb15143272acb" from runtime service failed: rpc error: code = Unknown desc = failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume404319370/prometheus: no such file or directory
Oct 03 05:41:08 kube kubelet[3189]: E1003 05:41:08.975164    3189 kuberuntime_manager.go:714] container start failed: CreateContainerError: failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume404319370/prometheus: no such file or directory
Oct 03 05:41:08 kube kubelet[3189]: E1003 05:41:08.975193    3189 pod_workers.go:182] Error syncing pod ea2e245e-a7f7-11e7-85fb-42010af00002 ("prometheus-778b44d4fb-6fpx5_istio-system(ea2e245e-a7f7-11e7-85fb-42010af00002)"), skipping: failed to "StartContainer" for "prometheus" with CreateContainerError: "failed to create containerd container: taking runtime copy of volume: open /tmp/ctd-volume404319370/prometheus: no such file or directory"

For some reason cri-containerd is looking for the Prometheus config volume under /tmp/ctd-volume404319370/prometheus which does not exist. The kubelet seems to have setup the config volume where I would expect under the kubelets pods directory, but I'm not sure why cri-containerd cannot locate it:
tree /var/lib/kubelet/pods/ea2e245e-a7f7-11e7-85fb-42010af00002/volumes/

/var/lib/kubelet/pods/ea2e245e-a7f7-11e7-85fb-42010af00002/volumes/
├── kubernetes.io~configmap
│   └── config-volume
│       └── prometheus.yml -> ..data/prometheus.yml
└── kubernetes.io~secret
    └── default-token-ntt7l
        ├── ca.crt -> ..data/ca.crt
        ├── namespace -> ..data/namespace
        └── token -> ..data/token

4 directories, 4 files

I'm testing all of this using a single node Kubernetes cluster. These are the scripts I'm using to provision the cluster, containerd, and istio: https://github.com/kelseyhightower/kube

@kelseyhightower From the log, it seems to be containerd volume support related. I'll look into it tomorrow.

@kelseyhightower The error is not from Kubernetes mounted volumes. It's from the image volumes https://github.com/prometheus/prometheus/blob/master/Dockerfile#L13.
In cri-containerd, for image volume, we:

Create a host directory for the image volume;
Create a temporary to mount container rootfs
Mount the container rootfs into the temporary directory;
Copy the content from the rootfs into the host directory for the image volume;
Unmount the temporary rootfs;
Mount the host directory for the image volume into container.

The error you encountered means that we could not find /Prometheus directory inside the container rootfs. It could be a containerd bug.
I'll look into it.

I think the problem is that during docker build, Docker doesn't create directory for image volume.
So in the rootfs there may not be the corresponding directory for the image volume, /prometheus in this case.
However, when mounting the image volume, we assume that the directory should have been in the rootfs, which is wrong.
What we should do: Skip copying content from rootfs if the target directory is not found, because it's normal that a image volume specified in image spec doesn't have a corresponding directory in rootfs.

With the fix https://github.com/kubernetes-incubator/cri-containerd/pull/327, I could start Prometheus pod now:
$ cluster/kubectl.sh apply -f prometheus.yaml
configmap "prometheus" created
service "prometheus" created
deployment "prometheus" created
$ cluster/kubectl.sh get pods --all-namespaces
NAMESPACE      NAME                          READY     STATUS    RESTARTS   AGE
istio-system   prometheus-778b44d4fb-vnh8n   1/1       Running   0          11s
kube-system    kube-dns-778977457c-n5qhr     3/3       Running   0          4m


re-entrant/cooperative wasm?

Hello, apologies for asking this as an issue, but I'm not sure where else to ask questions of this nature.
Is it possible to deschedule and re-schedule running wasm tasks?  I'd like to run dozens or hundreds of wasm programs in an app server of sorts,  but running each in its own thread seems a tad excessive.
Is it possible to hand to running wasm code functions which are effectively async, and deschedule the wasm program while it is waiting on IO?

These are very similar requirements to the ones we built Lucet for (https://github.com/bytecodealliance/lucet). We run WebAssembly code on a separate stack, and we have a yield API which is only accessible to host code called by WebAssembly code and returns back to the host stack, and a resume API to switch back to a suspended instance.
Our goal with Lucet is to merge it with Wasmtime by porting in all of the features that Wasmtime currently lacks, and this is one of the big ones.
We also want to transform the wasi-common (which lives in this repo) to take advantage of this, and perform all IO in an async rust function, for integration with tokio and friends. That work is still in its infancy, we're still working out other aspects of that story.

So I'm not totally sure what exactly is wanted from this issue, but I've just published the wasmtime-async crate that probably handles this problem -- though not yet handling wasi, due to limitations in the API, though hopefully these will be fixed soon-ish with https://github.com/bytecodealliance/wasmtime/pull/1600.
If so, I've opened https://github.com/bytecodealliance/wasmtime/issues/1672 for suggesting inclusion and/or referring to it from wasmtime's docs, to see what happens :)

@Ekleog url is missing the /crates path: wasmtime-async. Also, nicely done!

@Ekleog  - This is fantastic!
I will get started with it today.

I've opened https://github.com/bytecodealliance/rfcs/pull/2 for what it might look like supporting this in wasmtime itself, curious to hear what others think!


add C API reference (#16)

add C API reference
fixes
update accessor types

Unresolved: do we need both articles: C API reference and C client for kdb+. Seems to be a lot of overlap.
Also: for constructor functions such as kz how does the numeric argument relate to the timestamp required?

Also: for constructor functions such as kz how does the numeric argument relate to the timestamp required?

Sorry, I could not help but to show off pyq:
>>> K._kz(1.5)
k('2000.01.02T12:00:00.000')

The numerical argument is the day number (with 0 corresponding to 2000.01.01) plus a fraction of the day.  So that .0 is midnight and .5 is noon.
Note that the datetime type is deprecated and if you want to document it at all – please mention that the timestamp type should be used instead.

Unresolved: do we need both articles: C API reference and C client for kdb+. Seems to be a lot of overlap.

I would say: yes.  In Python documentation, we have Extending and Embedding tutorial and Python/C API reference separately and it works well.

So should C client for kdb+ move to the Tutorials section?

I would rather see one chapter dedicated to C that will have a separate section with the API reference, two separate sections on building a client app and a server extension and maybe a tutorial with practical examples.  This seems to be the way Fusion interfaces are documented.  In any case the C client section should be next to the C API section.

Now published.


Update kamon-core, kamon-logback, ... to 2.1.12

Updates

io.kamon:kamon-core
io.kamon:kamon-logback
io.kamon:kamon-testkit

from 2.1.8 to 2.1.12.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.kamon" } ]

labels: library-update, semver-patch

Superseded by #152.


Polynomial: differentiate & print methods.

Rationale :

differentiate can be useful

printing nicely the poly as well

Will enable drop-in replacement in Garaga for the Polynomial struct.

Thank you! :)

Codecov Report
Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (e14cf2b) to head (cae0f12).

Files with missing lines
Patch %
Lines

math/src/polynomial/mod.rs
96.42%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   71.08%   71.12%   +0.04%
==========================================
  Files         144      144
  Lines       31824    31880      +56
==========================================
+ Hits        22622    22676      +54
- Misses       9202     9204       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to assign custom policy

I tried using this to assign a custom TeamsMeetingPolicy policy, but I keep receiving the error "New-CsBatchPolicyAssignmentOperation : Provided policy name is not valid". Does it not support custom policies?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d149ca60-bfb7-5077-2643-1a08ad926cca
Version Independent ID: 24754aee-bff2-fa16-e7e6-af45362fd916
Content: New-CsBatchPolicyAssignmentOperation (teams)
Content Source: teams/teams-ps/teams/New-CsBatchPolicyAssignmentOperation.md
Service: teams-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

@officedocsbot assign @yogkumgit

Hi @Bart-Hoofd, thank you for your feedback.
It's working on my lab:

I am using module 1.0.5. Please check your version. They were added in this, they were previously in the preview module.

@dariomws  Thank you very much for the contribution and updating the documentation with PR. @Bart-Hoofd Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Documentation is no reflecting any update, and issue still persist? I can also not determine any reason for closing this ticket?

@Bart-Hoofd Thank you very much for posting this issue. Considering the nature of the issue, it is advised that please open a service ticket in your tenant and follow with them for the resolution. If you wish to know how to open the service ticket, please follow this link: https://docs.microsoft.com/office365/admin/contact-support-for-business-products
We will be very happy if you can share the outcome or resolution with us. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Hi @Bart-Hoofd, I have additional information about this cmdlet.
Even though the cmdlet is in the stable version of the module, I have confirmation from the product team that it is still in preview so we will maintain the sentence at the top of the article, at least, for now. And that the Product Team is aware of this and working the matter.

Hi Dario,
Thanks!

Van: Dario Woitasen<EMAIL_ADDRESS>Verzonden: dinsdag 7 april 2020 17:44
Aan: MicrosoftDocs/office-docs-powershell<EMAIL_ADDRESS>CC: Bart-Hoofd<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Onderwerp: Re: [MicrosoftDocs/office-docs-powershell] Unable to assign custom policy (#5076)
Hi @Bart-Hoofdhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBart-Hoofd&data=02|01||1844c83e02a34a014d9b08d7db0a8e25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637218710682695500&sdata=P1i0QvAdJFPssTTsfSBURznlLr0sNY%2BSUJNnszjwO%2Fk%3D&reserved=0, I have additional information about this cmdlet.
Even though the cmdlet is in the stable version of the module, I have confirmation from the product team that it is still in preview so we will maintain the sentence at the top of the article, at least, for now. And that the Product Team is aware of this and working the matter.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Foffice-docs-powershell%2Fissues%2F5076%23issuecomment-610463550&data=02|01||1844c83e02a34a014d9b08d7db0a8e25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637218710682705482&sdata=e%2FcD6aMa8WAL4vaRxMIRPsvHvarE1Q4Ve%2BQ5bjwGFu4%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALQKDE2ZMAN3UWB2FQ5G2BTRLNC5XANCNFSM4LLBRFLQ&data=02|01||1844c83e02a34a014d9b08d7db0a8e25|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637218710682715469&sdata=yh%2FSCpYjshqVZsNTkxczbR%2FqSb%2BjZkOZ9g3rKYr0F%2FE%3D&reserved=0.


Disk Temperatures for fixed disks

HWiNFO can report the temperature of fixed disk drives using SMART. Disks Meter will show the disk temperature in place of the eject button on these disks, for fixed drives do not have an eject button to begin with.
Depends on #73 for the new HWiNFO configuration. Putting every disk into the current config tool would be a nightmare.
To-do

[x] Add measures
[x] Add meters
[x] Update gadget config script to account for temperature meters
[x] Add toggle button

Done.


drafts: Misleading text of tooltip on hovering message

Hovering on any message in drafts shows tooltip with "Restore draft (Enter)". While in actual, only the message that is in focus would be restored if Enter is pressed, so the message in tooltip is kind of misleading. "Restore draft (Enter)" could be show on tooltip of the focused message.
Another solution could be, similar to #8969 , we can change the tooltip text to "Click to restore".
Also, there is a need to use the pointer cursor here on the messages to suggest clicking function as mentioned here.
Admins can confirm what the appropriate tooltip text can be.

Agreed; I think probably just "Restore draft" is fine.

@timabbott Hello Tim! I would like to propose that a fix for this issue is to change the message from "Restore drafts (Enter)" to "Restore drafts (Click)" and to get rid of the enter hotkey. This way, the disconnect between the focused element and the element which the hotkey corresponds to is eliminated. Now a user can just click on the draft that they want to restore, the enter key does nothing when pressed, and the arrow hotkeys still function correctly. I believe this is a clear and clean solution.


[update-rke2-charts] Add rke2-charts update tool

Problem: When rke2 component image, chart or package is updated the
version references have to be manually updated. Said process is busy
work and error prone.
Solution: Simplify the update process with a Go tool as a single
interface for it.
The requirement after this tool is described on #12

The initial scope is only to update charts with url: local (e.g. canal), right?

@manuelbuil  As the tool stands right now, it simple look for the following elements that might express as version reference:

packageVersion in package.yaml
appVersion in Chart.yaml
version  in Chart.yaml
image/tag pair in values.yaml

Any other element is ignored. Do you think we should validate against url file on package.yaml file?

The initial scope is only to update charts with url: local (e.g. canal), right?

@manuelbuil As the tool stands right now, it looks for the following elements that might express a version reference:
* packageVersion in package.yaml

* appVersion in Chart.yaml

* version  in Chart.yaml

* image/tag pair in values.yaml

Any other element is ignored. Do you think we should validate against url field in the package.yaml file?

Maybe throw an error if url is not local, saying, this is not yet supported

Can we change the name from "chart-up" to "update-rke2-charts"?

The initial scope is only to update charts with url: local (e.g. canal), right?

@manuelbuil As the tool stands right now, it looks for the following elements that might express a version reference:
* packageVersion in package.yaml

* appVersion in Chart.yaml

* version  in Chart.yaml

* image/tag pair in values.yaml

Any other element is ignored. Do you think we should validate against url field in the package.yaml file?

Maybe throw an error if url is not local, saying, this is not yet supported

@manuelbuil let me push the initial iteration then I'll work on the scenario you have pointed out. The issue for it #34

The initial scope is only to update charts with url: local (e.g. canal), right?

@manuelbuil As the tool stands right now, it looks for the following elements that might express a version reference:
* packageVersion in package.yaml

* appVersion in Chart.yaml

* version  in Chart.yaml

* image/tag pair in values.yaml

Any other element is ignored. Do you think we should validate against url field in the package.yaml file?

Maybe throw an error if url is not local, saying, this is not yet supported

@manuelbuil let me push the initial iteration then I'll work on the scenario you have pointed out. I have documented it on #34

Let's include this and extend the scope so we have a single go at this.

If the purpose of the tool is simply to update rke2-charts, it feels to me we could do it in a simpler way. It seems the code is adding a lot of advanced and complex syntax that could be useful if we want to cover a more sophisticated use case (e.g. the Interface) but I don't think it is needed for our use case. I might be wrong though!

It depends on the tool's scope. If we simply want to manipulate yaml files, I think yq on a shell script would be better. The request was to enable the user to change anything that expresses a version on any given "package", including image tags. That lead us to a cli interface similar to this:
# update-rke2-charts <package name> [version field = version value]*
$ update-rke2-charts rke2-canal-1.19-1.20 appVersion=v3.13.4 rancher/hardened-calico=v3.13.5-build20220124

Where the complexity started was when I took into account the following:

The yaml elements that express a version will be on a package.yaml, Chart.yaml or value.yaml file, that may or may not follow a layout inside of a package folder.
We want the user to use the image name as a mean of "version key" followed by the tag as a "version value" rancher/hardened-calico=v3.13.5-build20220124. Although, both part are values and the image one does not have an standards key name (ie: image, calicoImage, flannelImage)
Validations mentioned on this PR that I am still working on.

I think the overall logic can be simplified by constraining a couple of requirements (like ignoring any package that does not follows an specific layout) and performing a mild refactor.

Could you briefly explain why do you need three structs: type referecedVT struct, type simpleVT struct and type versionTree struct

I almost forgot this. You caught me on the middle of a refactor there. Initially there were only two structs, and basically those were one that vanilla unmarshall/manipulate and the other that transverse for specific key pairs.

If the purpose of the tool is simply to update rke2-charts, it feels to me we could do it in a simpler way. It seems the code is adding a lot of advanced and complex syntax that could be useful if we want to cover a more sophisticated use case (e.g. the Interface) but I don't think it is needed for our use case. I might be wrong though!

It depends on the tool's scope. If we simply want to manipulate yaml files, I think yq on a shell script would do better. The request was to enable the user to change anything that expresses a version on any given "package", including image tags. That lead us to a cli interface similar to this:
# update-rke2-charts <package name> [version field = version value]*
$ update-rke2-charts rke2-canal-1.19-1.20 appVersion=v3.13.4 rancher/hardened-calico=v3.13.5-build20220124

Where the complexity started was when I took into account the following:
* The yaml elements that express a version will be on a package.yaml, Chart.yaml or value.yaml file, that may or may not follow a layout inside of a package folder.

In my experience they all follow the same layout

* We want the user to use the image name as a mean of "version key" followed by the tag as a "version value" `rancher/hardened-calico=v3.13.5-build20220124`. Although, both parts are values and the image one does not have a standard key name (ie: image, calicoImage, flannelImage). Requiring to transverse the values.yaml data structure to spot where these key pair are located.

* Validations mentioned on this PR that I am still working on.

I think the overall logic can be simplified by constraining a couple of requirements (like ignoring any package that does not follows a specific layout) and performing a mild refactor.

If the purpose of the tool is simply to update rke2-charts, it feels to me we could do it in a simpler way. It seems the code is adding a lot of advanced and complex syntax that could be useful if we want to cover a more sophisticated use case (e.g. the Interface) but I don't think it is needed for our use case. I might be wrong though!

It depends on the tool's scope. If we simply want to manipulate yaml files, I think yq on a shell script would be better. The request was to enable the user to change anything that expresses a version on any given "package", including image tags. That lead us to a cli interface similar to this:
# update-rke2-charts <package name> [version field = version value]*
$ update-rke2-charts rke2-canal-1.19-1.20 appVersion=v3.13.4 rancher/hardened-calico=v3.13.5-build20220124

Where the complexity started was when I took into account the following:
* The yaml elements that express a version will be on a package.yaml, Chart.yaml or value.yaml file, that may or may not follow a layout inside of a package folder.

The directory layout is always the same for those files

* We want the user to use the image name as a mean of "version key" followed by the tag as a "version value" `rancher/hardened-calico=v3.13.5-build20220124`. Although, both part are values and the image one does not have an standards key name (ie: image, calicoImage, flannelImage)

How are you currently solving this?

* Validations mentioned on this PR that I am still working on.

You mean modifying the packageVersion correctly?

I think the overall logic can be simplified by constraining a couple of requirements (like ignoring any package that does not follows an specific layout) and performing a mild refactor.

I think the interface is not needed, or? And I also wonder about the three structs

I almost forgot this. You caught me on the middle of a refactor there. Initially there were only two structs, and basically there was one that vanilla unmarshall/manipulate values and the other that transverse for specific key/value pairs. And the interface was to deal with both on a single way through its behavior

Wouldn't it be possible to unmarshall the three files and then:

If a appVersion or version change is requested, then modify Chart.yaml. And then packageVersion, in package.yaml (move it to 1)
If any other fields must be changed, assume they are part of values.yaml. Change them (if they don't exist error out) and then packageVersion, in package.yaml increments by 1

I think those are the possible use cases. For example, I wouldn't cover the use case where the image changes and that change is propagated into the appVersion change of Chart.yaml. For example in canal, the helm chart follows the Calico image version but not the flannel image version. How can the algorithm know that detail unless you hardcode that detail with some sort of, "if it is rke2-canal, then this", right?

* The yaml elements that express a version will be on a package.yaml, Chart.yaml or value.yaml file, that may or may not follow a layout inside of a package folder.

In my experience they all follow the same layout

Ok, then I'll refactor the code under this guideline allowing me to get rid of Walk.

* We want the user to use the image name as a mean of "version key" followed by the tag as a "version value" `rancher/hardened-calico=v3.13.5-build20220124`. Although, both parts are values and the image one does not have a standard key name (ie: image, calicoImage, flannelImage). Requiring to transverse the values.yaml data structure to spot where these key pair are located.

* Validations mentioned on this PR that I am still working on.

How are you currently solving this?

By unmarshalling values.yaml file, transverse unmarshalled map[string]interface{} structure and look for any other key relative to tag that holds a string value. After transversing said structure, the tool has a dictionary of references where it can find a given image / tag value pairs.

* Validations mentioned on this PR that I am still working on.

You mean modifying the packageVersion correctly?

Correct.

I think the interface is not needed, or? And I also wonder about the three structs

Addressed on a separate comment. My bad.

Closing for now and will reopen if this tool needs to be completed.


Fail ESP32S2 FTM test with Android Smartphone. (IDFGH-5024)

When I tested FTM on ESP32-S2(AP) with Android Smartphone(STA), I could see the FTM response message, but can NOT catch the results of RTT from ESP32-S2 AP as following link:
https://esp32.com/viewtopic.php?f=13&t=19919&sid=54c30292f4b42a7f805f9db8351182f7
Do you have a plan that updating successfully the FTM test with Android ?
ref) https://source.android.com/devices/tech/connect/wifi-rtt
BRs,
Taehyoung Shim

@TeiShim  Hi, can you use the sniffer probe to capture FTM? Can you tell me the format of the captured FTM packet?
Thank you!

@zhangyang428 Hi, Zhang Yang. Yes, we can capture FTM packets with Wireshark as you can see: https://www.wireshark.org/
And, you can also see the format of FTMs in the standard of IEEE 802.11-2016.
If you need further information. I can send you the wireshark files.

@TeiShim  Thanks! I need further information for FTM frame. Can you share how you capture these data frames? My email address:
<EMAIL_ADDRESS>

@zhangyang428 Sorry for late responding. This webpage will be help you.
https://www.wireshark.org/docs/dfref/w/wlan.html

FTM on ESP32-S2(AP) with Android Smartphone(STA)

@TeiShim , as discussed on the ESP32 Forum thread, we're planning to include support for this configuration in IDF v4.3.1. I'll provide an update when this version is released.

@nachiketkukade
Thank you for notification. Could you let me know when IDF v4.3.1 will be released?
Depending on the release date, we will make a test schedule.

@nachiketkukade
Is FTM test connecting Android phone available in IDF v4.3.1? I tested, but fail again.

I just tried this again with esp-idf master from today, an esp32-c2, and a Google Pixel 4a running Google's WifiRttScan.
Something's still not quite right, but I can't tell right now if it's the google app's fault, or ESP, or both.
Behavior: phone/app gets no measurements while disconnected, but does get measurements as soon as it's connected to any AP.
The phone doesn't have to connect to that ESP32-C2 AP. FTM sessions to the FTM-capable softAP succeed even if the phone's wifi connects to another non-FTM-capable regular ESP32 that runs a softAP.
I currently don't have FTM-capable APs at hand. I think the app managed to FTM to one of those without needing to be connected to any access point, but I might be mistaken.

@crackwitz , I guess you mean ESP32-S2. I re-tested with the Pixel with no connection, and yes, there seems to be some issue there. Protocol wise there seems to be nothing different going on with or without the connection, but the issue is not there with the Velop AP. I also tested with Mi 11X Pro, it doesn't have this issue, could be some quirky behaviour due to different implementations. Regardless, I'll investigate further and update.

Is FTM test connecting Android phone available in IDF v4.3.1? I tested, but fail again.

@TeiShim , yes, the support is there in v4.3.1. Can you pls confirm which Smartphone you tested with?
Also I must warn that the accuracy will be very low.

Just thought I should mention the phenomenon. I don't actually need Android and ESP32 to cooperate. That's just a convenient way to check a few things.

An update to anyone interested - we've done more tests with Pixel devices and fixed some issues. Changes are expected to merge in coming weeks.

Thank you @nachiketkukade, Is this FTM function able to use in 5GHz with ESP32-C5?

@TeiShim , support for FTM for C5 in 5GHz is planned

@TeiShim , support for FTM in 5GHz for C5 is planned

Off topic but perhaps related: are there plans for 802.11ba Wake-Up Radio ("Wake on WLAN") in the C5 or P4 or other series?


[main] Update community files (#162)

Update community files
Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Fix: Can't easily select cells in other sheets to reference them in formulas

Maybe this is more a future feature but at the moment it's not possible to reference cells in other sheets (eg: =SUM(Sheet1!A1,Sheet1!A2)) just by clicking. It has to be manually typed at the moment.
Another issue here is that when manually typing a reference in a different sheet, the same cells in the current sheet are highlighted.
More details in this video:
https://github.com/user-attachments/assets/4bdeccd4-8cd1-475e-bb97-a7e0a4637900

Fixed.

The second part is fixed. What about referencing other sheets? Is it more a feature than a bug?

Reopening.
But it does work for me :/

Oh, just tested it again and works as expected. Thank you! I'll close the issue now.


Consolidate Example: dataframe_output.rs into dataframe.rs

Which issue does this PR close?
Closes #13844)
Rationale for this change
Part of https://github.com/apache/datafusion/issues/11172
What changes are included in this PR?
Consolidate the contents of https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/dataframe_output.rs
Into https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/dataframe.rs
Then update the readme page:
https://github.com/apache/datafusion/blob/main/datafusion-examples/README.md
Are these changes tested?
Yes
Are there any user-facing changes?
Readme changes for example about write out data to local storage.

Thank you @alamb for review!


Updates based on code review

src/withOutline.js L10: isn't there a constant you can use for the 'docs' string, or something like isDocsMode in the Storybook API?

@ghengeveld  I couldn't find anything. I see a TS type but everywhere in the code I only see string references

Also I kind of wonder about the necessity of adding/removing the styles each time. Would it be easier to simply add the styles and turn them off and on with a body class for instance? Is that a hack?

@tmeasday  A little bit torn on this one. We probably get a bit of perf benefit but, I'm a bit hesitant to put styles in the preview pane DOM that the user is unaware of. Even if they are not used. Both the original pesticide extensions and the background addon add & remove the styles. Plus they need to be injected in the iframe so, it happens when you switch stories or docs tab anyway.

Both the original pesticide extensions and the background addon add & remove the styles.

This seems like a good reason to stick with what we have. Let's assume they had a good reason for that ;)

Plus they need to be injected in the iframe so, it happens when you switch stories or docs tab anyway.

docs + stories use the same frame so I don't think this is a problem, but I am OK with whatever you decide.


New PowerShell features

New features in this branch:

Added a new Powershell TCP shell, smaller than the other one. It is named powershell_tiny.
Added --powershell-x86 flag to generate a payload that enforces using powershell 32-bit executable.
Added --powershell-x64 flag to generate a payload that enforces using powershell 64-bit executable.
Added --powershell-random-case flag to generate randomly cased powershell payloads. This will bypass string filters.
Added a powershell_wrapper function to handle the above features.

Modifications in this branch:

Refactored the way powershell encoding is done.
Refactored the way quotes are dealt with powershell payloads. This ensures all payloads will work in cmd.exe. Most of them will NOT work when invoked from powershell.exe

Tests done:

Tested windows/reverse/tcp/powershell
Tested windows/reverse/tcp/powershell_tiny
Tested windows/reverse/tcp/powershell_shellcode_injection
Tested linux payloads to see if any changes interferred. Apparently it is working fine.

The flags --base64 and --xor were tested individually and combined. Everything seems to work.
If anyone finds a bug, please report.

man its seems good... I m checking all on my system ... ;)


[computeMatches] Crash with use_grid_sort=1

When running SIFT_CCTAG3 on the June11.01 dataset, openMVG_main_ComputeMatches crashes when --use_grid_sort is 1. This is the default in scriptMvg.
Please find attached a backtrace from the segfault.
grid-sort-bug.txt

Do you mean that with --use_grid_sort 0 it works fine?

Yes

Fixed here:
https://github.com/poparteu/openMVG/commit/9eb78d99ff448336d425e0de5369295868399c7d


[lilypond.lua]: non-trivial ly code doesn't compile; global options not effective

I just discovered lilypond.lua and it might be what I was looking for.
However, I had some trouble getting it to work.
The following works well:
---
lilypond:
  relativize: yes
---

# Some songs

```lilypond { .ly-fragment ly-resolution=300 }
\new ChordNames \with {
  \override BarLine.bar-extent = #'(-1 . 3)
  \consists "Bar_engraver"
}

\chordmode {
  f1:maj7 f:7 bes:7
  c:m d:7 fis:dim
}

However, as soon as I add the lilypond block from here (examples), I get an error:
$ pandoc -i test/lp1.md --lua-filter=$(which lilypond.lua) --pdf-engine=lualatex --standalone -o test/lp1.pdf
Error running filter /nix/store/87wba0bq2w9icj63vd7m2ipl2fn1a866-pandoc-lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:
...lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:65: attempt to index a nil value (local 'fh')
stack traceback:
	...lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:49: in upvalue 'generate_image'
	...lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:83: in upvalue 'process_lilypond'
	...lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:143: in function <...lua-filters-2021-11-05/share/pandoc/filters/lilypond.lua:138>

The same happens when I add a \break to any of the above code.
As I gleaned from the lua code, this probably means that the lilypond process errored out and dind't produce an image file. But if I put the verbatim contents of the failing code block in a separate file lptst.ly and then manually run lilypond, it generates a correct looking png file:
$ lilypond -o tst.png --png test/lptst.ly
GNU LilyPond 2.24.3 (running Guile 2.2)
Processing `test/lptst.ly'
Parsing...
test/lptst.ly:1: warning: no \version statement found, please add

\version "2.24.3"

for future compatibility
Interpreting music...[8][16]
Preprocessing graphical objects...
Finding the ideal number of pages...
Fitting music on 1 page...
Drawing systems...
Converting to PNG...
Success: compilation successfully completed

The second topic:
I want to move things like  ly-resolution=300 to the frontmatter (which should be possible according to the docs), but none of
---
lilypond:
  relativize: yes
  ly-resolution: 300
ly-resolution: 300
pandoc:
  ly-resolution: 300
---

had any effect.

Partial Solution
I discovered that if I omit .ly-fragment, I'm able to do \break and the orginal appoggiaturas example also works (which has in the original test markdown also .ly-fragment however, so why would it pass the test there?).
Ultimately this could mean, that it would be good to be able to tweak the ly-fragment behaviour, or provide another mechanism that allows us a kind of default preamble that will be injected for each block, so we can avoid repeated setup boilerplate.


Website Color Consistency

The footer form, illustration(s), underscores, title text and the scroll bar should be of the same color.
Go ahead with a shade of purple or mauve
This should be done for all the pages in the website

Can I get assigned for this issue under LGM-SOC?

@Amrutha1101 Yes, you can work on it.

Should I have to change these text colors too to purple?
But I think white text color looks good.

No text colours look great in white don't change them

https://material.io/design/color/dark-theme.html#ui-application here's a purple what say @smaranjitghose i think this will look good

This one ?

This one ?

Yep

Let me know if any changes to be made..

Please use this color palette: https://www.color-hex.com/color-palette/10715

Different shades for different elements
#4e00bb for the text
The color you have used for the illustrations is perfect.

You can make this small change and give a PR directly


DMs Off Error Handling

Update: I used black to format both files. stackexchange.py didn't have any changes but github.py was formatted.

I forgot to paste stackexchange.py's formatted code the last time. I got it this time.

It looks like stackexchange.py and github.py are interchanged somehow :sweat_smile:

I don't know how I missed that. It's done now.

Just a tiny issue, the except discord.Forbidden parts should be changed to just Forbidden and Forbidden has to be imported from discord
Make sure to run black on the changed files as well


Allow using electron-localshortcut from render process

When I try to require('electron-localshortcut'), I get an error:

Uncaught TypeError: Cannot read property 'on' of undefined

This is because it's grabbing app by a direct require, while it needs to be obtained from remote if in the render process.

Though, I'm still getting the hang of this electron thing, and it might be a terrible idea to do this kind of thing from the render process. The more I play with this, the more it looks like it. ¯\_(ツ)_/¯

if you want to register shortcuts in renderer process, you can do
var localshortcut = require("remote").require("electron-localshortcut");

But as you said, it maybe preferable to do it in main process.

Ah, of course. That works gloriously. Thanks!

I'm going to reopen this: after working with this some more, I've found some issues with this and browserify.
Module bundlers seem to look for require(x) statements, and then include x in the finished bundle. However, if a module is required through remote: require("remote").require("electron-localshortcut") then it isn't included in the final package.
Disclaimer: I haven't seen that many other people with this problem, so I'm potentially doing wrong.

You don't need to browserify you electron apps: electron platform is perfectly capable of loading modules at runtime using require.
If you want to browserify at any cost (e.g. because of module loading speed gain), then you have to search for a browserify transform that handle the remote case. Browserify only work with require calls, it does not know anything about remote calls.
I doubt that any such transform exists...

Than you have to try one of two solution explained above. Or you can also try to use webpack instead.
Anyway, I re-close this since it's not related to electron-localshortcut

:+1:, thanks for your help, it should be enough direction to continue :)

You're welcome!


Update PACKAGE_URL with correct GH repo URL

Updating PACKAGE_URL as it was pointing to the wrong location, and hence the link here), is broken as it point to https://github.com/oras-project/oras-python

Thank you! It looks like you'll need to sign the DCO - click on the details to see how that works.


d3.layout.pie order

When returning the arcs, pie() doesn´t preserve the original order. The last data.map function should use index.indexOf(i) instead of index[i] to recover original order.
You can test this problem with this data [5, 30, 15]

Fixed by #409.


Trace Results on Chaos bodies

Hello.
Any way to use a line trace to get the body index? (ie the entity index)? I can use the octree but the Fbox is a little awkward for me.
I tried to set the BodyIndex in BodyInstance so that when I use a line trace I get the body index (ie the entity index) I just get an int that = body count. That doesn't work at all obviously and I have tried a bunch of things, moving the for loop way up and poking and prodding in there.
It was mentioned that the physics here used a similar way the landscape is initialized? I'm assuming the entities are "one thing"?
I tried looking for other methods in source but I couldn't put anything together. ISM uses the BodyIndex as Instance index.

Hmm... I think the body index is for when you trace against an ISM or a skeletal mesh component's collision to map to instances of ISM instances/bones.
The physics is similar to landscapes in that it makes the new Chaos bodies on-the-spot and by mimicking using the built in Chaos physics initialization path in our own code, rather than just using the build in stuff. I think to map from chaos hit to entity ID you could change the Userdata of the body to be the entity index?

Sorry for my question in this issue, but
How i can detect collision between Chaos body and Actor? My entity have PhysicsBody and i trying to detect that projectile is hitting the entity, and im stuck on this:(

Use the Octree for now, its pretty fast but lacks accuracy if the detection box is small.. I have gotten pretty far with adding the bodies to an owning component(plus an owning actor) with the index I wanted in my question.
I can post my solution here, though I am not sure what @Megafunk plans to do with his vision on the physics bodies.

I think it's worthwhile to have actual physics collision callbacks, I think https://forums.unrealengine.com/t/chaos-contact-modification/517748 a contact modifier callback might do it? I can try something

Also im trying UChaosEventRelay and its looks like right way, but I have no idea how to get it to work


Add raw values for screen resolution

Hi, thanks for this awesome lib.
I'm asking you to report also raw values of screen resolution. I'm storing browser report to the Postgresql JSON datatype which enables querying. I want to have ability to select all users with width above 1024px for example.
Also I believe that viewport size shouldn't be reported under browser prop. What about viewport property, again with raw values as well.

I like the idea of providing raw values for width and height.
I'm not convinced making a new property for viewport is necessary. Could you expand on why you believe it is?

Thanks for prompt response. I believe that viewport should be separated from browser prop. because it is far more complicated concept that it can share same space as browser vendor & version.

Thank you for the link. I read all of A tale of two viewports. Fascinating reading, and of course quirksmode tells us what browsers are really doing.
I agree on moving the browser.size property to viewport.size and adding raw values for viewport.width and viewport.height. I believe these values should reflect the visual viewport since they correspond to how much the user can see. As for the layout viewport, I think I will use it to calculate the zoom level because it will be useful to know if the user is zoomed in or out. I will put that in viewport.zoom. Do you think the raw values of the layout viewport should be reported too?

I added support for the raw width and height of the screen, the visual viewport, and the layout viewport.

Thank you very much, your'e awesome.
Do you think the raw values of the layout viewport should be reported too?
I have no opinion for this.
Thanks again.


Dashboard success message points to wrong host

When the final ceph-dashboard role executes it uses a hosts parameter that picks up the grafana-server group.
https://github.com/ceph/ceph-ansible/blob/d0840217f3e8ffd3fe9d45fbd41b60444b70a290/site-container.yml.sample#L547
This means that instead of a link to the dashboard in the output, you get a link to the grafana server which yields this;
e.g The dashboard has been deployed! You can access your dashboard web UI at  http://nautilus-metrics.storage.lab:8234/  as an 'admin' user with 'admin' password.
In the above example nautilus-metrics is my grafana host not a mgr host that is running the dashboard

@pcuzner could you share your inventory please?

Hi @guits here's the ansible inventory
all:   children:     grafana-server:       hosts:         nautilus-metrics: null     mdss:       hosts:         nautilus-2: null     mgrs:       hosts:         nautilus-1: null         nautilus-2: null         nautilus-3: null     mons:       hosts:         nautilus-1: null         nautilus-2: null         nautilus-3: null     osds:       hosts:         nautilus-1: null         nautilus-2: null         nautilus-3: null     rgws:       hosts:         nautilus-1: null

Yes, we shouldn't use groups["grafana-server"][0]. The ceph-dashboard role is meant to be run on ceph-mgr node (or fall-back to ceph-mon if ceph-mgr nodes were not defined).

fixed by #4107


[Excel] (Custom Functions) Update call Excel JS APIs code sample

Addressing part of #2839.

Docs Build status updates of commit 1b8e6bd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Download data files

Use sunpy data manager to download the data files needed to use xrt_deconvolve and xrt_remove_lightleak

pre-commit.ci autofix


Clean up some unused channel-related code

Each commit should be fairly self-explanatory, but to provide some more context on the first two:

Fake channels are an old concept that was used to show channels in the sidebar that didn't exist yet. A very long time ago, new users would automatically have a number of DM channels appear in their sidebar to make Mattermost look more friendly to new users, but those channels weren't created in the DB until the user viewed them. That was later removed during a previous sidebar redesign, and that code was left over from before that.
Channel.ExtraUpdateAt is no longer used on the server as of https://github.com/mattermost/mattermost-server/pull/8762 (https://mattermost.atlassian.net/browse/MM-9739). It's still around and unused, and removing it from the type definition on lets us just ignore it on the client.

This is done in preparation for https://mattermost.atlassian.net/browse/MM-37021 since the rest of that is blocked by https://github.com/mattermost/mattermost-webapp/pull/8503
Release Note
NONE

Skipping QA review since this is just dead code removal.

@hmhealey Is this for v6.0?

Nope, it's not needed for it. Thanks for checking though