cargo audit failure; resolved by merging existing dependabot PR.

The master branch fails cargo audit with 1 error and 1 warning.
Meanwhile, the dependabot/cargo/zip-0.6.4 branch resolves the error, while the warning remains, so simply merging that PR will resolve the blocking error.
audit results on master
$ git remote -v
origin  https://github.com/MCOfficer/zip-extract (fetch)
origin  https://github.com/MCOfficer/zip-extract (push)

$ git log -1
bbfb1a1 2022-01-26 16:51:09 +0100 - Bump to v0.1.1<EMAIL_ADDRESS>(HEAD -> master, tag: v0.1.1, origin/master, origin/HEAD)

$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 514 security advisories (from /home/user/.cargo/advisory-db)
    Updating crates.io index
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (48 crate dependencies)
Crate:     time
Version:   0.1.45
Title:     Potential segfault in the time crate
Date:      2020-11-18
ID:        RUSTSEC-2020-0071
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
Solution:  Upgrade to >=0.2.23
Dependency tree:
time 0.1.45
└── zip 0.5.13
    └── zip-extract 0.1.1

Crate:     tempdir
Version:   0.3.7
Warning:   unmaintained
Title:     `tempdir` crate has been deprecated; use `tempfile` instead
Date:      2018-02-13
ID:        RUSTSEC-2018-0017
URL:       https://rustsec.org/advisories/RUSTSEC-2018-0017
Dependency tree:
tempdir 0.3.7
└── zip-extract 0.1.1

error: 1 vulnerability found!
warning: 1 allowed warning found

audit results on dependabot/cargo/zip-0.6.4
$ git checkout dependabot/cargo/zip-0.6.4
Branch 'dependabot/cargo/zip-0.6.4' set up to track remote branch 'dependabot/cargo/zip-0.6.4' from 'origin'.
Switched to a new branch 'dependabot/cargo/zip-0.6.4'

$ cargo check
    Updating crates.io index
  Downloaded zip v0.6.4
  Downloaded time v0.3.20
[… a bunch of output elided.]

$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 514 security advisories (from /home/user/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (73 crate dependencies)
Crate:     tempdir
Version:   0.3.7
Warning:   unmaintained
Title:     `tempdir` crate has been deprecated; use `tempfile` instead
Date:      2018-02-13
ID:        RUSTSEC-2018-0017
URL:       https://rustsec.org/advisories/RUSTSEC-2018-0017
Dependency tree:
tempdir 0.3.7
└── zip-extract 0.1.1

warning: 1 allowed warning found

I just submitted #12 which is based on top of the dependabot/cargo/zip-0.6.4 branch and resolves the remaining cargo audit warning.
Merging these two branches and publishing a new release to crates.io will ensure all projects which depend on this crate will no longer fail these cargo audit failures (at least, due to this crate).

5f86abc60d54214ca1d321c5bfe1b27a549dbbdd


Usage of debounce triggers query twice

Describe the bug
When I use the debounce for my query, it triggered twice, once directly when I call the composable and then a second time after the debounce time is over.
Expected behavior
The query should not be triggered twice. For me it should be triggered directly when I call the composable and then the debounce should be used when some update is happening.
Versions
vue: 3.2.40
@vue/apollo-composable: "^4.0.0-beta.1",
@apollo/client: ^3.6.9

I experience the same behavior, but in my case a reason a little bit different. I use debounce with enabled option.
const { result, loading } = useQuery<{ items: ItemsConnection }>(
  SEARCH_ITEMS,
  () => ({ where: { name: { contains: toValue(searchTerm) } }, first }),
  () => ({ debounce: 500, enabled: toValue(searchTerm) !== '' }),
);

The query triggers twice, the 1st time when it enables and then after the debounce period


Engineering System Improvements for iOS

This tracks the Engineering System Improvements for iOS for the Azure SDK team

@AlexGhiondea is this different from https://github.com/Azure/azure-sdk-for-ios/issues/681?


Added support for Docker Manifest and Parallel Builds

Reworked the publish experimental process.
Major Changes/Features:

Use of docker manifest command instead of the manifest-tool
Parallel Builds to speed up build/release time
Docker images build on architecture instead of using qemu
No more use of a docker token. All calls are via public urls or through docker commands
Added dedicated debian tag to make it clearer to users. LTS and Latest still point to debian
Use of .ci folder to move CI/CD build tools away from the main repo
Added support of force parameter to push tags and images no matter what
Added additional checks to make sure images and tags are always up to date
Multi-stage build of git lfs, due to no binaries for s390x and ppc64le.

Some improvements I would like to see are:

Trigger publish scripts by Jenkins releases(push model). This would benefit us since we would not need to loop through and process the last X amount of builds(currently set to get the last 30 builds).

Pull down binaries for git lfs. This PR was just merge https://github.com/git-lfs/git-lfs/pull/3989. They now produce binaries for s390x and ppc64le. Could pull in binaries rather than building them

Somehow check the contents of a manifest in order not the build manifests every time. Would save a lot of time and bandwidth.

This PR is a big change and will need feedback from you guys. Another change is building on platform and not using qemu.

Sorry that it took me so long to review this PR and I find it really clear.
And I really like the following elements:

Added dedicated debian tag to make it clearer to users. LTS and Latest still point to debian

I love this as it allows people to specifically stick to Debian if they need

Use of .ci folder to move CI/CD build tools away from the main repo

-> Like this idea a lot, as it brings a clear distinction between scripts for ci and scripts used by the docker image

Trigger publish scripts by Jenkins releases(push model). This would benefit us since we would not need to loop through and process the last X amount of builds(currently set to get the last 30 builds).
We refactored the way we release and published Jenkins releases. Currently we have one job to release and a second one to package jenkins for multiple distributions, and I definitely think we should create a third one specifically for Docker packaging.
Jenkins configuration used for futur releases is defined here and the root configuration is located here
I still need more time to test this PR before validating it

@olblak Thanks for taking an initial look at the PR. Glad to hear the changes add clarity to the build process!
In my most recent update to this PR, I add some speed improvements in particular to how git lfs was being installed. Before I was using multi-stage docker build, which added time to the overall build since it was compiling the code each time. After working with the maintainers of  git-lfs they are now building and releasing binaries for all the architectures we need. Thus cutting down on the build time since we can just curl down the binaries from GitHub releases.
One thing to note, is all Dockerfiles are pulling from the GitHub release binaries except alpine. This has to do with musl vs glibc. You can read more here on this issue, https://github.com/git-lfs/git-lfs/issues/4025. I am working with them to provide a fix.

Trigger publish scripts by Jenkins releases(push model). This would benefit us since we would not need to loop through and process the last X amount of builds(currently set to get the last 30 builds).

How I built out the files is looping over the X amount of builds we process. To get the push model working, it would be a simple update to the scripts to  remove the loop over the process and to just take in a single version. Thus enabling the push model. This would be very cool to see!

Jenkins configuration used for futur releases is defined here and the root configuration is located here

Thanks for pointing me at these files. I will try to take a look at them this week to get a better understand of how everything is set up.
Will you be on the Jenkins Infrastructure Team Sync this week? Maybe we can talk more about this infrastructure change tomorrow, as I was planning on attending.

@james-crowley I haven't read all the changes you made, also because I'm not familiar with this jenkins repo and its deployment process, I've only checked the slave/agents ones.
Did you have a look at stackbrew https://github.com/docker-library/official-images/tree/master/bashbrew? It's the code used to build / publish Docker's official images.
They use something similar here for node js https://github.com/nodejs/docker-node.
This would avoid to re-develop the logic for build / publish images using templates.
And also it was the final configuration I wanted to reach when modifying the docker slaves images.

@krufab

@james-crowley I haven't read all the changes you made, also because I'm not familiar with this jenkins repo and its deployment process, I've only checked the slave/agents ones.

It definitely takes a while to understand the whole process and understand why things are done in certain ways.

Did you have a look at stackbrew https://github.com/docker-library/official-images/tree/master/bashbrew? It's the code used to build / publish Docker's official images.

Yup! I worked with a couple open source communities to get them to build using the official image pipeline. The nice thing about the official image pipeline is they have s390x and ppc64le support!

They use something similar here for node js https://github.com/nodejs/docker-node.

I did not know about this. This is actually some super useful bash scripts about “automating” the bashbrew process.

This would avoid to re-develop the logic for build / publish images using templates.
And also it was the final configuration I wanted to reach when modifying the docker slaves images.

Using bashbrew is helpful but if we are not publishing the images to the official images repo then it comes a lot less useful. It does have some good logic that we could adapt to make it work for the Jenkins community!

And also it was the final configuration I wanted to reach when modifying the docker slaves images.

I would like to see Jenkins community pushing to the official images pipeline too, but currently I think there are other issues that need to be addressed first. Hence, this PR is looking at improving the existing build process. Once we nail down this build process, we can start looking at additional improvements.

@slide Depending on when #956 gets merged, this would need to be updated to move BASEIMAGE to adoptopenjdk not openjdk.
Also, I think with the addition of #956, this PR would be a good step forwards to get multi-arch builds running.

@james-crowley Can you resolve the conflicts on this? Also, one question:
No more use of a docker token. All calls are via public urls or through docker commands
When I ran this script locally, the login timed out during all the processing. Is this something that you have seen as well?

@slide I have not seen any timeouts. Huh, that is strange. Wonder if the Docker API is doing something weird or has changed since this PR.
Let me take a look at the PR and try it locally too.

Maybe I have something messed up in my docker config.json or something.

@slide I made the changes you requested and brought the Alpine image inline with the other images.
Let me know if you need any other changes.

GitHub is still showing merge conflicts, does it show that for you as well?

@slide I am rebased my branch to be in sync with master. There still seems to be a couple conflicts and I am not sure how to resolve them.

I am deleting publishing-experimental.sh in favor of the script being split out into publish-tags.sh, publish-images.sh and publish-manifests.sh.

I thought I resolved all the Makefile conflicts. I did modify the path of the make target publish in favor of moving the CI script to the .ci folder.

Like I mentioned above I am moving publish.sh to the .ci folder.

@slide I am rebased my branch to be in sync with master. There still seems to be a couple conflicts and I am not sure how to resolve them.

I am deleting publishing-experimental.sh in favor of the script being split out into publish-tags.sh, publish-images.sh and publish-manifests.sh.

You can git rm publishing-experimental.sh the only change since you started your PR is to disable arm32v7, we can do that differently with your makefile changes (just not build that arch).

I thought I resolved all the Makefile conflicts. I did modify the path of the make target publish in favor of moving the CI script to the .ci folder.
Like I mentioned above I am moving publish.sh to the .ci folder.

Let me look locally and see what I can see.

@slide Thanks for taking a look and resolving the issue. Was there any other changes you wanted? If not, do we need others to review the PR before merging?

It would be good to have @MarkEWaite  and @oleg-nenashev sign off on it

I feel like we can merge this now, anyone have issues with that?

I don't object, but I've not reviewed the pull request.  We're short-handed on infrastructure support currently.  So long as you're comfortable that surprises can be rolled back, I'm OK with the merge

@MarkEWaite Happy to help with any issues if they do pop up. But I think the PR is pretty solid with the changes suggested by everyone.
Getting this merged would help us get closer to getting multi-arch support. It works out well with the change of the base images from OpenJDK to AdoptOpenJDK.

Squash-merging PRs to a fork and keeping the default commit title, and then not squash-merging THAT, is a terrible idea, now our Git history is littered with misleading issue/PR references.


Add support for Ganglia

Thanks for creating flintrock and making it open source, it's really fast.
My team and I are moving from spark-ec2 to flintrock. One thing that is missing is the support for ganglia, to monitor Spark clusters.
A user should be able to specify the version and (de)activate ganglia's installation, e.g. :
services:
  spark:
    version: 1.6.0
  hdfs:
    version: 2.7.1
  ganglia:
    version: x.y.z

[...]

launch:
  num-slaves: 1
  # install-hdfs: True
  # install-spark: False
  install-ganglia: True

Hi @dm-tran and thank you for the kind words. They are appreciated.
I feel a bit hesitant to add support for other services that are not strictly Spark-related. But coming from spark-ec2 I totally understand why you want Ganglia in Flintrock too.
One thing that Flintrock offers over spark-ec2 is the ability to copy files and run commands against the cluster in parallel. This should make it relatively easy to piece together your own post-launch scripts for setting up other things you need, like Ganglia.
For example:
flintrock launch dm-tran
flintrock run-command dm-tran 'sudo yum install -y ganglia'

Or alternately:
flintrock launch dm-tran
flintrock copy-file dm-tran ganglia-setup.sh
flintrock run-command dm-tran 'chmod u+x ganglia-setup.sh'
flintrock run-command dm-tran './ganglia-setup.sh'

Would an approach like that meet your needs?
Another thing you can do is create your own custom AMIs from the default Amazon Linux AMIs that have Ganglia pre-installed, and use those to launch your Flintrock clusters.
I am open to considering "promoting" certain services into first-class Flintrock features in the future, but I think the bar will be pretty high. If something proves to be extremely valuable in conjunction with Spark and is widely used by Flintrock users, I would consider it.

Thanks @nchammas for the answer. An approach using copy-file and run-command (and optionally custom AMIs) would indeed meet our needs, we'll try that.
I'm closing the issue.

I would love to have Ganglia as additional support. Since it is so important to understand what the cluster is doing and to figure where the problem lies.


Update User Guide (again)

Add in "Navigating the User Guide"

Explain how to use the different sections
Explain the use of icons and boxes

Update the UI-screenshots with annotations
Change description of features to be more user-centric
Change introduction to be something more appropriate
Update glossary with more common terminology
Rephrase technical wordings to be more appropriate for HR (such as when talking about command format)
Fix grammar issues
Fix formatting/parsing issues
Add boxes for warnings
Standardise to text first then image after
Reorder features

For v1.4, resolved with #234.


Runaway electronForkStart processes during smoketest

We still see a lot of these processes hanging around the Linux build machines:

/vso/work/2/VSCode-linux-x64/code-insiders /vso/work/2/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/2/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc

@dbaeumer  Something else must be happening.

Note that this happens both in macOS as well as Linux. Never on Windows.

Linux build agent
monaco              2920                40958               0                   Sep25               ?                   00:01:08            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              7357                40958               0                   Oct03               ?                   00:00:08            /vso/work/2/VSCode-linux-x64/code-insiders /vso/work/2/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/2/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              16015               40958               0                   Sep26               ?                   00:01:01            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              19050               40958               0                   Sep26               ?                   00:01:01            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              20515               40958               0                   Sep25               ?                   00:01:05            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              29404               40958               0                   Sep25               ?                   00:01:07            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc
monaco              37982               40958               0                   Oct02               ?                   00:00:16            /vso/work/3/VSCode-linux-x64/code-insiders /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/node_modules/vscode-languageclient/lib/utils/electronForkStart /vso/work/3/VSCode-linux-x64/resources/app/extensions/json/server/out/jsonServerMain.js --node-ipc

@joaomoreno non of these processes were started with the new --clientProcessId command line argument I added.
@aeschli you might want to move to the latest client / server libraries which have support for passing the process id of the client process on the command line to avoid cases where the client shuts down before the server has received the initialize request and therefore the client process id.

I updated the css/json/html language servers to use the latest vscode-languageclient. I verified tat they are now all started with the --clientProcessId option.


!loot improvement

Hi
Can you add "detecting" this scenario without debugging flag?
2016-06-17 23:47:24 [!!] ERROR: UrlRequest() <XXX> Content:
{"strError":"There was an error sending your trade offer.  Please try again later.

You have logged in from a new device. In order to protect the items in your inventory, you will be unable to trade from this device for 7 days."}
2016-06-17 23:47:24 [!!] WTF: UrlPostRetry() <XXX> Request failed even after 5 tries, WTF?

Message from bot could easily tell me that eg. 23:47 - XXX: Trade offer failed due to trading restriction. Steam response: You have logged in from a new device. In order to protect the items in your inventory, you will be unable to trade from this device for 7 days.

I could, but that would potentially degrade performance and Steam is talking so much crap that I don't want to even dig inside those errors - often they're misleading, and I don't need people asking me why they're receiving error X that doesn't make sense. Generic failure is better in this case.
Besides, that case is covered in FAQ, and I assume you even read it considering you enabled Debug mode to check out the error yourself. You could simply trust my text and assume 7-days without doing that :smile:
WTF error can mean only two things - either timeout, or Steam. If Steam, then the case should be carefully evaluated considering steam fuckups and other quirks. The reason that steam states might be totally wrong, and generic error is much better than caused confusion for people who are not aware of how poorly steam network works.
But feel free to convince me if you think otherwise. Maybe you have an argument that I overlooked.


Aries Wrapper for Fabric

This is a proposal so that Aries Wrapper for Fabric can come under Hyperledger Labs.
Self - Sovereign Identity application is an application by which you are able to keep your identity secured and at the same time also prove your identity to the verifier without revealing them. These applications are built using Hyperledger Aries, which depends on Indy as a Distributed Ledger and Ursa as a cryptography library. Currently, the most used Blockchain platform is Hyperledger Fabric. And the businesses that are building solutions using Fabric want to have some sort of identity verification to be done in their platform. This is the reason, why this project has come into existence. Once done it would enable Aries to interact with Fabric as a ledger, which would then enable SSI applications to be built on top of Fabric.

I had signed off in the commits in this PR. But as there was one blank in my name in the 2 commits that I had signed off through github UI, the DCO check failed.
I am closing this PR and would raise a new one


Cancel performance scenarios when coordinator is cancelled

And here's what happened when I cancelled the coordinator build.


Arduino Serial Monitor

Is your proposal related to a problem? Please describe.
Add an Arduino setup that demonstrates how to use the serial monitor through printing a potentiometer value through it.
Add any other context or screenshots about the proposal request here.
Issue made under GSSoC'22 contributions.

@Kushal997-das can I get working on this? Same with #503 and #501


Ensure Functions have Access to Raw HTTP Requests

    > Functions should not obscure access to the raw http requests in any of the languages

@salaboy @lkingland - Honestly, I think this might be dependent on the invocation framework. For example, I'm pretty sure Quarkus does not out of the box (could be mistaken), and I'm almost certain that faas-js-runtime only supports GET and POST at the moment. If we do want to support all HTTP verbs, we should call that out - perhaps in a larger epic that applies to all builtin runtimes.
Originally posted by @lance in https://github.com/knative/func/issues/1242#issuecomment-1286929900

This issue is such that we do not loose track of the goal that an instance of a function have direct access to the inbound HTTP request and outbound response or CloudEvent from the given language's standard library.
According to the referenced issue, this is the case for the Go function presentation code, but may not be the case for the other languages, so we should verify when time permits.
This expectation does not apply in the special situation where a template is very specifically intended to present a function as implementing a handler for a specific framework, but we should at least confirm that no request mangling or obfuscation is taking place in the situation of core language templates without framework middleware.

Any requirements that we place on templates should be reflected in this document: https://github.com/knative/func/blob/main/docs/language-packs/language-pack-contract.md

/remove-lifecycle stale

/remove-lifecycle stale


Add protobuf image

Motivation
protobuf 2.5.0 is a very old version and is no longer maintained by brew.
Therefore, it is useful to have a docker image when you need it.

If protobuf is frequently updated, use variantdev/mod.
This is not required.
https://github.com/chatwork/dockerfiles/blob/master/helmfile/variant.mod
https://github.com/chatwork/dockerfiles/blob/master/helmfile/variant.lock

If protobuf is frequently updated, use variantdev/mod.
This is not required.
https://github.com/chatwork/dockerfiles/blob/master/helmfile/variant.mod
https://github.com/chatwork/dockerfiles/blob/master/helmfile/variant.lock

protobuf will probably not be updated. So I will omit the implementation of variant/mod.


rename data to properties in _Object, DataObject, and .insert()

This PR renames the data attribute within _Object and DataObject for clarity on its role in relation to the created Collection configurations. Since these map directly to the properties within the Class schema, naming it properties seems more appropriate.
Note that it also changes the API surface of the client.collection.data.insert() function since DataObject is changing from data->properties also.

Codecov Report
Patch coverage: 86.21% and project coverage change: -0.19% :warning:

Comparison is base (110cf92) 94.00% compared to head (e9c6c5f) 93.82%.
Report is 168 commits behind head on pydantic_experiment.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           pydantic_experiment     #455      +/-   ##
=======================================================
- Coverage                94.00%   93.82%   -0.19%
=======================================================
  Files                       72       84      +12
  Lines                     9593    10721    +1128
=======================================================
+ Hits                      9018    10059    +1041
- Misses                     575      662      +87

Files Changed
Coverage Δ

test/batch/test_crud_batch.py
99.11% <ø> (-0.12%)
:arrow_down:

test/gql/test_get.py
100.00% <ø> (ø)

weaviate_grpc/weaviate_pb2.py
14.28% <2.77%> (-11.30%)
:arrow_down:

weaviate/collection/collection_base.py
65.30% <43.75%> (+6.43%)
:arrow_up:

weaviate_grpc/weaviate_pb2_grpc.py
59.25% <50.00%> (-3.90%)
:arrow_down:

weaviate/batch/crud_batch.py
90.42% <57.69%> (-4.90%)
:arrow_down:

weaviate/collection/tenants.py
73.33% <73.33%> (ø)

weaviate/collection/data.py
73.42% <73.42%> (ø)

integration/test_collection_model.py
84.58% <81.06%> (-2.54%)
:arrow_down:

weaviate/collection/grpc.py
85.23% <81.30%> (-9.41%)
:arrow_down:

... and 29 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Audit reverse dependencies

As discussed in https://github.com/googlesamples/assistant-sdk-python/issues/358#issuecomment-552471651 it would be nice to audit project depending on google-assistant-grpc and google-assistant-library.
For example:

https://github.com/search?q='google-assistant-grpc'+filename%3Arequirements.txt&type=Code
https://github.com/search?q='google-assistant-library'+filename%3Arequirements.txt&type=Code

Additional processing could allow us to cluster those project by version, forks and recent activity to more effectively communicate downstream change like https://github.com/googlesamples/assistant-sdk-python/issues/359

Other popular reverse dependencies that were mentioned before:

https://github.com/google/aiyprojects-raspbian/tree/aiyprojects/src/aiy/assistant
https://github.com/shivasiddharth/GassistPi


Added rest() fix

Should be easy to merge now.

Hmm, for some reason, when I tried out the latest version from your branch, there's no enemies showing up on the Battle screen when I create a character. Is this expected?

No, but I thought I'd figure out what was wrong with it after the menu add, it's something to do with changes I made and the setUp() function (it was working before I added the cards, so I know it's something I did then).

Ahh ok, no prob, just wondering whether I accidentally deleted changes or was missing something :P.


MAPDL releasing license during testing.

As the title.
Requested here: https://github.com/ansys/pymapdl/pull/2533#issuecomment-1873799280
Working on this three issues arise:

[ ] Usage of PAUSE over the gRPC interface: https://github.com/ansys/pymapdl/issues/2595#issuecomment-1875635439
[ ] Usage of PAUSE on Student version: https://github.com/ansys/pymapdl/issues/2595#issuecomment-1875635896
[ ] ~License error showing on the student version:~ https://github.com/ansys/pymapdl/issues/2595#issuecomment-1875638392

Interestingly, it seems that the PAUSE command does not work on gRPC mode.
>> mapdl.run("pause")
CRITICAL - pymapdl_global -  logging - handle_exception - Uncaught exception
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/mapdl/pymapdl/src/ansys/mapdl/core/mapdl_core.py", line 2236, in run
    self._raise_errors(text)
  File "/home/mapdl/pymapdl/src/ansys/mapdl/core/mapdl_core.py", line 2682, in _raise_errors
    raise MapdlInvalidRoutineError(text)
ansys.mapdl.core.errors.MapdlInvalidRoutineError: *** WARNING ***                         CP =       2.088   TIME= 15:47:33
 PAUSE is not a recognized BEGIN command, abbreviation, or macro.  This
 command will be ignored.

Ignore these messages by setting 'ignore_errors'=True

However, it does work in a normal context:

I believe I'm using it wrong.... Pinging @mikerife @FredAns @koubaa

Usage of PAUSE
Additionally, it seems the command PAUSE does not work well in MAPDL student version (or maybe I'm using it wrong).
But if you start an MAPDL instance, and then issue PAUSE:
$ ansys -dir /tmp
...
...
 RUN SETUP PROCEDURE FROM FILE= /ansys_inc/v241/ansys/apdl/start.ans

 /INPUT FILE= /ansys_inc/v241/ansys/apdl/start.ans  LINE=       0

 BEGIN:
pause

 *** WARNING ***                         CP =       0.518   TIME= 16:14:02
 This application is now PAUSED, making its license available for use by
 another application in this Workbench session.  All commands to this
 application will be ignored until an UNPAUSE command is typed in the
 Command Window of this application and successfully processed.

 BEGIN:

and then start another MAPDL instance, you get a Maximum licensed number of demo users already reached error.
(.venv) root@67ca9354d958:~/pymapdl# ansys -dir /tmp/tmp

 ANSYS LICENSE MANAGER ERROR:
 Maximum licensed number of demo users already reached.

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       mech_2
 License path:  /var/tmp//616ceecb-5105-43ba-a26d-dd269757afed:
 FlexNet Licensing error:-5,357

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       mech_1
 License path:  /var/tmp//616ceecb-5105-43ba-a26d-dd269757afed:
 FlexNet Licensing error:-5,357

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       meba
 License path:  /var/tmp//616ceecb-5105-43ba-a26d-dd269757afed:
 FlexNet Licensing error:-5,357

However, if I use the -smp flag in both processes, it works. The first instance release the license, so the second one can take it.

License error showing on the student version
Also it seems that launching student version shows the Maximum licensed number of demo users already reached. error before starting successfully:
 ANSYS LICENSE MANAGER ERROR:
 Maximum licensed number of demo users already reached.

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       mech_2
 License path:  /var/tmp//56ebd4ed-9192-4bdb-beb2-34b929b03b83:
 FlexNet Licensing error:-5,357

I have made sure there are no more Ansys processes running using ps aux | grep ansys.
Details
Details

$ (.venv) root@67ca9354d958:~/pymapdl# ansys -dir /tmp/tmp

 ANSYS LICENSE MANAGER ERROR:
 Maximum licensed number of demo users already reached.

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       mech_2
 License path:  /var/tmp//56ebd4ed-9192-4bdb-beb2-34b929b03b83:
 FlexNet Licensing error:-5,357

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       mech_1
 License path:  /var/tmp//56ebd4ed-9192-4bdb-beb2-34b929b03b83:
 FlexNet Licensing error:-5,357

 ANSYS LICENSE MANAGER ERROR:
 No such feature exists.
 Feature:       meba
 License path:  /var/tmp//56ebd4ed-9192-4bdb-beb2-34b929b03b83:
 FlexNet Licensing error:-5,357

 Ansys Mechanical Enterprise Academic Student

 *------------------------------------------------------------------*
 |                                                                  |
 |   W E L C O M E   T O   T H E   A N S Y S (R)  P R O G R A M     |
 |                                                                  |
 *------------------------------------------------------------------*

 ***************************************************************
 *         ANSYS MAPDL                  LEGAL NOTICES          *
 ***************************************************************
 *                                                             *
 * Copyright 1971-2024 Ansys, Inc.  All rights reserved.       *
 * Unauthorized use, distribution or duplication is            *
 * prohibited.                                                 *
 *                                                             *
 * Ansys is a registered trademark of Ansys, Inc. or its       *
 * subsidiaries in the United States or other countries.       *
 * See the Ansys, Inc. online documentation or the Ansys, Inc. *
 * documentation CD or online help for the complete Legal      *
 * Notice.                                                     *
 *                                                             *
 ***************************************************************
 *                                                             *
 * THIS ANSYS SOFTWARE PRODUCT AND PROGRAM DOCUMENTATION       *
 * INCLUDE TRADE SECRETS AND CONFIDENTIAL AND PROPRIETARY      *
 * PRODUCTS OF ANSYS, INC., ITS SUBSIDIARIES, OR LICENSORS.    *
 * The software products and documentation are furnished by    *
 * Ansys, Inc. or its subsidiaries under a software license    *
 * agreement that contains provisions concerning               *
 * non-disclosure, copying, length and nature of use,          *
 * compliance with exporting laws, warranties, disclaimers,    *
 * limitations of liability, and remedies, and other           *
 * provisions.  The software products and documentation may be *
 * used, disclosed, transferred, or copied only in accordance  *
 * with the terms and conditions of that software license      *
 * agreement.                                                  *
 *                                                             *
 * Ansys, Inc. is a UL registered                              *
 * ISO 9001:2015 company.                                      *
 *                                                             *
 ***************************************************************
 *                                                             *
 * This product is subject to U.S. laws governing export and   *
 * re-export.                                                  *
 *                                                             *
 * For U.S. Government users, except as specifically granted   *
 * by the Ansys, Inc. software license agreement, the use,     *
 * duplication, or disclosure by the United States Government  *
 * is subject to restrictions stated in the Ansys, Inc.        *
 * software license agreement and FAR 12.212 (for non-DOD      *
 * licenses).                                                  *
 *                                                             *
 ***************************************************************

 *** WARNING ***                         CP =       0.405   TIME= 16:21:22
 MISSING DOCUMENTATION FILE
  DOCU LIST FILE = /ansys_inc/v241/ansys/gui/en-us/
  MISSING FILE NAME = /__w/mapdl-docker-image-builder/.

          *****  MAPDL COMMAND LINE ARGUMENTS  *****
  INITIAL DIRECTORY = /tmp/tmp

 RELEASE=                      BUILD= 24.1      UP20231106   VERSION=LINUX x64
 CURRENT JOBNAME=file0  16:21:22  JAN 03, 2024 CP=      0.409

 RUN SETUP PROCEDURE FROM FILE= /ansys_inc/v241/ansys/apdl/start.ans

 /INPUT FILE= /ansys_inc/v241/ansys/apdl/start.ans  LINE=       0

 BEGIN:

@germa89 you are not using pause wrong; at least that is what I think.  It is pretty strongly implied in the help that it is for mapdl interactive.  You can enter other APDL commands while paused but the UI throws an warning for all (except the unpause).  My guess is that this is built into the UI and not MAPDL per se....if that makes sense.

Wrapping PAUSE on a non_interactive context (which uses input) does not help to avoid the error message shown above.
 *** WARNING ***                         CP =       3.962   TIME= 11:51:49
 PAUSE is not a recognized PREP7 command, abbreviation, or macro.

Ignore these messages by setting 'ignore_errors'=True.


Dependent on major version of lie instead of fixed version

https://github.com/localForage/localForage/blob/711d5891dfc699705f086c2bec4c68d6c363c8ff/package.json#L71
This should be ^3.1.1 so we can get rid of es3ify in lies dependencies.
Just like https://github.com/localForage/localForage/pull/775 was, this is a step to get rid of esprima-fb.
Or is there a reason for a fixed version of the library?

No reason, I'll look into updating this soon. Sorry but I don't tend to use this library a lot myself these days so I've been a bit bad at watching the repo. I'll try to spend a weekend triaging issues soon 🙂


The order of the arguments for publish is inconsistent with the other functions

publish:
 ([^Observable ob connect?]
filter, map, etc.:
  [f ^Observable ob]

You are right.
The solution is just deprecate the convenience arity and I will do it right now in master.


Optional doesn't work with union None from 3.10

Python 3.10 allows writing this:
@inject
def optional_greeter(greeter: MissingGreeter | None = inject.me()) -> str:

...instead of:
@inject
def optional_greeter(greeter: Optional[MissingGreeter] = inject.me()) -> str:

However, this results in:
../src/antidote/core/_injection.py:110: in _build_injection_blueprint
    annotated = _build_from_annotations(arguments)
../src/antidote/core/_injection.py:138: in _build_from_annotations
    dependency = extract_annotated_arg_dependency(arg)
../src/antidote/core/_annotations.py:97: in extract_annotated_arg_dependency
    raise TypeError(f"Cannot use marker @inject.me with non class type hint: examples.injection_flavors.MissingGreeter | None

Indeed, thanks for reporting. Releasing a fix.

Fixed with the release 1.2.0.


Issue with fetching refresh token form the Microsoft Login for Azure active directory login

Hello,
I'm working on Active Directory v2 authentication in bot composer. The authentication process is proceeding properly, and the token is being received, but the refresh token is not being received.
We have one feature in that we must use the refresh token to produce several access tokens for different scopes.
We attempted to do this in a Node.js project by generating authorization-code with an authorize endpoint, as well as generating access tokens and refresh tokens using authorization-code.
Is there a method to retrieve the Active Directory v2 refresh token from the bot composer?

Hi @BhupathiK-Hexaware -- looking into this.

For clearity, please list the steps to reproduce this behavior. reference here
In composer, have you tried setting the "alwaysPrompt" to false and check if you recieve the refresh token?

Looks like there were similar issues posted previously in regards to managing token. Linking them below:

Azure Bot Service OAuth Connection String Not Maintaining Token
AAD token not refreshed by service

Hi, and thank you for your response. I looked at the resources you provided and learned a little bit, but the issue I was asking about doesn't have a precise solution in those two links. They only mentioned refreshing the token, but I need to retrieve the refresh token and use it to produce additional access tokens with different scopes, which I handled with NodeJS code but want to do with bot composer.

Hi @BhupathiK-Hexaware,
not sure you can directly do that in composer, have you tried using custom actions  to possibaly achieve this?

Hi @BhupathiK-Hexaware,
not sure you can directly do that in composer, have you tried using custom actions to possibly achieve this?

closing due to inactivity.


Disable zygote process on Linux

The zygote process has hijacked command line parameters and environment variables on Linux, making it hard to do some low level handling.
Fixes #1101.
This relies on patch https://github.com/atom/libchromiumcontent/blob/atom/patches/no_zygote.patch.

needed this badly for #1256  :)


Support for carthage --cache-builds flag

Hey,
carthage 0.20.0 introduced the --cache-builds flag, which generates .NAME.version version files for each built framework. When building a dependency carthage will use these version files to check if a corresponding build artefact is already available and skip the build. Would be great if rome could store these version files alongside the frameworks in the S3 cache and restore them during a rome download.
Thank you!

Interesting, I will take a look at that.

@t089 Maybe I ask what the use case for this is?
Usually the workflow with rome resembles the following:
rome download --platform iso && rome list --missing --platform ios | awk '{print $1}' | xargs carthage build --platform ios

Very good questing. Let me explain:
Say you have a dependency FrameworkA that itself depends on FrameworkB and FrameworkC.
Now, FramworkA needs an update. In your example Rome would fail to download  FramworkA from cache and would trigger a carthage build. Carthage would then build FrameworkA but would also build its dependencies FrameworkB and FrameworkC, although they did not change and are already present in the Build/ folder (because Rome downloaded them). With the new --cache-builds option carthage can reuse the existing FrameworkB and FrameworkC build artefacts, but only if the corresponding version file exists.
We are working a lot with internal frameworks that are included in the main app as carthage dependencies. Our frameworks also have some 3rd party dependencies and it's always painful to watch carthage build stuff that is already there waiting to be used...

@t089 I understand. Thanks for explaining, I think we have the same issue but never noticed.
Do you have any opinion on the implementation details I have made a note of to myself in the first comment?

Please try pre-release https://github.com/blender/Rome/releases/tag/v<IP_ADDRESS>
Let me know if it works as expected and I will proceed with a full release.

Awesome, that was quick, nice work. May I ask which route of implementing it you chose?  I ran a quick test rome upload and it reported Uploaded .Xy.version to: Xy/.Xy.version-3.3.1. But rome download xy did not seem to restore the version file locally.

I implemented the following:

Version Files are uploaded to <git-repo-name>/.<git-repo-name>.version-<carthage-resolved-version-hash>
Version Files are restored to Carthage/Build

Seems to work for me, I'm running:
$ rm  Carthage/Build/.KeychainAccess.version #remove the original version

$ rm ~/Library/Caches/Rome/KeychainAccess/.KeychainAccess.version-v2.4.0 #remove the local cached version

$ rome download KeychainAccess --platform iOS -v #download framework
09:07:12 2017-03-20 - Found KeychainAccess in local cache at: /Users/blender/Library/Caches/Rome/KeychainAccess/iOS/KeychainAccess.framework-v2.4.0.zip
09:07:12 2017-03-20 - Staring to unzip KeychainAccess.framework-v2.4.0.zip
09:07:12 2017-03-20 - Unzipped KeychainAccess from: KeychainAccess.framework-v2.4.0.zip
09:07:12 2017-03-20 - Found KeychainAccess.dSYM in local cache at: /Users/blender/Library/Caches/Rome/KeychainAccess/iOS/KeychainAccess.framework.dSYM-v2.4.0.zip
09:07:12 2017-03-20 - Staring to unzip KeychainAccess.framework.dSYM-v2.4.0.zip
09:07:12 2017-03-20 - Unzipped KeychainAccess from: KeychainAccess.framework.dSYM-v2.4.0.zip
09:07:12 2017-03-20 - Started downloading .KeychainAccess.version from: KeychainAccess/.KeychainAccess.version-v2.4.0
09:07:21 2017-03-20 - Downloaded 0.0 MB of 0.0 MB for .KeychainAccess.version
09:07:21 2017-03-20 - Downloaded .KeychainAccess.version from: KeychainAccess/.KeychainAccess.version-v2.4.0
09:07:21 2017-03-20 - Copying .KeychainAccess.version to: /Users/blender/Library/Caches/Rome/KeychainAccess/.KeychainAccess.version-v2.4.0

$ ls Carthage/Build/.KeychainAccess.version
-rw-r--r--  1 blender  staff   661B Mar 20 09:07 Carthage/Build/.KeychainAccess.version

Oh, boy was probably too early in the morning 💤, of course I was using the pre-release version binary only for the upload but not for the download command. Ok, seems to work for me as well. Thank you 👍

Great, I will test a little more and hopefully promote the tag to full release :)
@t089 Thanks for suggesting this feature. I look forward to hear more feedback.

Looks like it's working. Full release it is!


No more github.actions.job.duration_second?

We are using the latest version of this github action and I noticed that we stopped getting this metric github.actions.job.duration_second.
Here's our workflow file:
jobs:
  submit:
    runs-on: ubuntu-latest
    timeout-minutes: 10
    steps:
      - uses: int128/datadog-actions-metrics@v1
        with:
          datadog-api-key: ${{ secrets.DATADOG_API_TOKEN  }}
          datadog-site: us5.datadoghq.com
          collect-job-metrics: true
          collect-step-metrics: false
          disable-distribution-metrics: true

Notice that we set disable-distribution-metrics to true because we have a lot of workflows and if we turn on disable-distribution-metrics, it will increase our Datadog cost by a lot.
Is there a way to get back the old github.actions.job.duration_second metric without distribution being turned on? Thanks!

I have reverted the deletion of gauge metrics such as github.actions.job.duration_second.
Since v1.86.0, this action sends the gauge metrics instead of the distribution metrics by default.
https://github.com/int128/datadog-actions-metrics/releases/tag/v1.86.0
Thank you for bringing up the cost issue.

Nice! Thanks for getting this fixed. Much appreciated.


Pass use_container to cwltool (resolves #1200)

Resolves #1200

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, test this please.
@jeremiahsavage, see my comments on #1200.

Jenkins, test this please.

@chapmanb @mr-c can you take a look at this change? Your changes in #1340 might already take care of this.

This fix is included in #1340 so we could close this and avoid needing to rebase it and get it for free as part of that PR when it's ready to merge.

@chapmanb, if possible, mark a commit in #1340 as (resolves #1200).


Song Downloading Error

System OS
Linux
Python Version
3.7 (CPython)
Install Source
GitHub
Install version / commit hash
v4.0.7
Expected Behavior vs Actual Behavior
No response
Steps to reproduce - Ensure to include actual links!
https://open.spotify.com/track/7G4YDFnplk1Fp6LiL8UGr5
Traceback
Updating web app
INFO:     Started server process [21033]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://localhost:8800 (Press CTRL+C to quit)
[21080:21080:0111/012344.195239:ERROR:object_proxy.cc(623)] Failed to call method: org.kde.KWallet.isEnabled: object_path= /modules/kwalletd5: org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying
[21080:21080:0111/012344.195255:ERROR:kwallet_dbus.cc(100)] Error contacting kwalletd5 (isEnabled)
[21080:21080:0111/012344.195432:ERROR:object_proxy.cc(623)] Failed to call method: org.kde.KLauncher.start_service_by_desktop_name: object_path= /KLauncher: org.freedesktop.DBus.Error.ServiceUnknown: The name org.kde.klauncher was not provided by any .service files
[21080:21080:0111/012344.195435:ERROR:kwallet_dbus.cc(72)] Error contacting klauncher to start kwalletd5
[21080:21080:0111/012344.273324:ERROR:object_proxy.cc(623)] Failed to call method: org.kde.KWallet.close: object_path= /modules/kwalletd5: org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying
[21080:21080:0111/012344.273336:ERROR:kwallet_dbus.cc(418)] Error contacting kwalletd5 (close)
Opening in existing browser session.
INFO:     ::1:47066 - "GET / HTTP/1.1" 200 OK
INFO:     ::1:47066 - "GET /assets/index.d96dcc94.css HTTP/1.1" 200 OK
INFO:     ::1:47074 - "GET /assets/index.51f4422f.js HTTP/1.1" 200 OK
INFO:     ::1:47082 - "GET /assets/vendor.7698a149.js HTTP/1.1" 200 OK
INFO:     ('::1', 47098) - "WebSocket /api/ws?client_id=e83967a1-84e5-4c3a-a868-393750e85e7d" [accepted]
INFO:     Client e83967a1-84e5-4c3a-a868-393750e85e7d connected
INFO:     connection open
INFO:     ::1:47082 - "GET /api/settings HTTP/1.1" 200 OK
INFO:     ::1:47082 - "GET /assets/spotdl.5dcb64c0.svg HTTP/1.1" 200 OK
INFO:     ::1:47082 - "GET /favicon.ico HTTP/1.1" 200 OK
INFO:     ::1:47112 - "GET /favicon.ico HTTP/1.1" 304 Not Modified
INFO:     ::1:47108 - "GET /api/song/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F7G4YDFnplk1Fp6LiL8UGr5 HTTP/1.1" 200 OK
01:23:52 - INFO - 1/0 complete
01:23:52 - ERROR - LookupError: No results found for song: Yugo Kanno - Symphony No. 1 - The Border - I: Dive into Myself
ERROR:    Failure downloading Symphony No. 1 - The Border - I: Dive into Myself
ERROR:    Error downloading!
INFO:     ::1:47108 - "POST /api/download/url?url=https:%2F%2Fopen.spotify.com%2Ftrack%2F7G4YDFnplk1Fp6LiL8UGr5&client_id=e83967a1-84e5-4c3a-a868-393750e85e7d HTTP/1.1" 500 Internal Server Error

### Other details

_No response_

update fastapi pip install -U fastapi

I don't think I have pip installed. Sorry, I'm not a python developer myself. Heres's what I get:
jrm@jrm-ws:~$ pip install -U fastapi
bash: pip: command not found
jrm@jrm-ws:~$ sudo pip install -U fastapi
sudo: pip: command not found

I do have python installed, though:
jrm@jrm-ws:~$ python3 --version
Python 3.10.9

Do I need to install anything else, but the app? I thought spotdl-4.0.7-linux file contains everything it needs.

I don't think I have pip installed. Sorry, I'm not a python developer myself. Heres's what I get:
jrm@jrm-ws:~$ pip install -U fastapi
bash: pip: command not found
jrm@jrm-ws:~$ sudo pip install -U fastapi
sudo: pip: command not found

I do have python installed, though:
jrm@jrm-ws:~$ python3 --version
Python 3.10.9

Do I need to install anything else, but the app? I thought spotdl-4.0.7-linux file contains everything it needs.

Ignore my previous comment, looks like the song you are trying to download doesn't exist on youtube. Nothing we can do here.
You can specify specific YouTube videos to download with Spotify metadata, or vice versa.
To do this, use the notation spotdl download "YouTubeURL|SpotifyURL"
Note that the quote marks (") are essential.

Wait, this is actually quite surprising to me that Spotify Downloader tries to download the song from YouTube, and not from Spotify.
This is a strange architectural decision and I don't understand it, and it doesn't explain in the README as to why it should be this way, but I'm not going to question it. Just two things:

it would be great to mention it somewhere as to why it works this way;
it would be great for the app to actually report that error clearly, saying ("Because the song you're requested is not found on YouTube it cannot be downloaded"), I'm sure this will save many a headache for users, as there are plenty of songs that are on Spotify, but not on YouTube.

Wait, this is actually quite surprising to me that Spotify Downloader tries to download the song from YouTube, and not from Spotify.
This is a strange architectural decision and I don't understand it, and it isn't explained in the README as to why it should be this way, but I'm not going to question it. Just two things:

it would be great to mention it somewhere as to why it works this way;

it would be great for the app to actually report that error clearly, saying ("Because the song you're requested is not found on YouTube it cannot be downloaded"), I'm sure this will save many a headache for users, as there are plenty of songs that are on Spotify, but not on YouTube.

Thank you.

Hi,the reason why we are using youtube is to simply avoid any unnecessary legal problems. There was some spotify rippers but they are gone https://github.com/chris124567/spotrip
AFAIK this is currently the only semi-legal way of downloading the music "from spotify". Even yt-dlp (fork of youtube-dl) was taken down by a dmca strike not so long ago https://github.blog/2020-11-16-standing-up-for-developers-youtube-dl-is-back/
As to why it isn't mentioned in the readme. there is a small note in the prerequisites section of the readme and in the about section on github. but i guess you are right, in the next release I will add more info regarding the sources from which the music is actually being downloaded and our reasons for doing it this way.


Remove support for packages directory

Starting on the list

[ ] dart:io Platform.packageRoot
[ ] dart:isolate Isolate.packageRoot

Related:

[ ] Remove support from pkg:package_resolver – bug needed
[ ] Remove use from pkg:test - bug needed

Why is this P1?

@zanderso I believe its short for "Priority 1" ie Highest priority.

Why is this P1?

It's cleanup that would be ideal in v2 – since it'll be easier to get away with breaking changes.

Any updates on this, @kevmoo ?

There was discussion in email about Fuscia needing/wanting packages directories still.
@zanderso @a-siva ??

@kevmoo will follow up on this to see what users would be affected.

@MichaelRFairhurst any updates here?

Any updates on the plan here?

Strawman CL, which seems to have no issues internally: https://dart-review.googlesource.com/#/c/sdk/+/59100

Can this issue be closed at this point?

Should we leave it open to actually remove the APIs? They are just
deprecated + noop now...
On Thu, Jun 14, 2018 at 2:17 PM Dan Grove<EMAIL_ADDRESS>wrote:

Can this issue be closed at this point?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/30384#issuecomment-397441188,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCitm1Aa4WTyvBPKARI0tXk9OtRF0Hks5t8tLagaJpZM4OynGz
.

Once this CL lands, I suggest that we remove the milestone. Landing the noop version of this is enough to allow the VM team to shed the underlying code.

Agreed -- now that https://dart-review.googlesource.com/c/sdk/+/60062 is landed, the packages/ directory won't work with or without dart 2. And the deprecations have already been published.
Its now clear -- as far as I can tell -- to be cleaned up at anyone's whim!

This issue is marked closed, but nobody has ever done the work described, of actually removing the APIs. Shouldn't it be reopened until somebody does?

These are all done a long time ago!


short block times

This PR will shorten Juno's block times.
With this PR we should get block times of about three seconds and validators should not be able to adjust the commit timeout.

SDK v45 does not have this feature, only v46+ it seems to modify the tendermint config. Closing this PR and opening a patch for this into my v15 initial branch


fix(oven): treat burners as dict

Corrects syntax so burners is treated as a dictionary.
Fixes https://github.com/simbaja/gehome/issues/58 and https://github.com/simbaja/ha_gehome/issues/201

Thank you for the fix!  Seems like one other fix was needed as well, so picked the pull request that had both.  Really appreciate you looking into it though!


Avatar for homebrew spell not synced

Avatars for my homebrew spells are missing. Just getting the spell icon school replacement.
It's working for other homebrew entities like monsters and items. But not for spells...
I'm using up-to-date versions for all systems and modules, including version 5.0.0 of DDB-Importer.

The JSON that is fetched for spells does not include the images, so the importer is unable to add them.

I see. :(
DDB itself must have a link anywhere to show the image in the browser. I'm curious how the fetch mechanism work. There must be a reference anywhere to that "https://www.dndbeyond.com/avatars/thumbnails/..." image.

I see. :(
DDB itself must have a link anywhere to show the image in the browser. I'm curious how the fetch mechanism work. There must be a reference anywhere to that "https://www.dndbeyond.com/avatars/thumbnails/..." image path.

It's not the spell page that the data is fetched from, but the JSON data that is provided to characters when you select the spell, which is a slightly different subset of information.


remove env.list

The environment variables in env.list (and the bash scripts that convert them to tfvars) should become just these variables and the user should specify them directly (tfvars instead of an env.list):
// required
variable "project_id" { type = string }
variable "deployment_name" { type = string }
variable "orchestrator" { type = string } // can be one of ["gke", "mig", "ray", "slurm"]
variable "node_groups" {
  type = list(object({
    node_group_count       = number
    node_count_static      = number
    node_count_dynamic_max = number

    // per node settings
    machine_type = string
    zone = string
    disk = object({
      type = number
      size = number
    })
    image = object({
      project = string
      family  = string
      name    = string
    })
    guest_accelerator = object({
      type  = string
      count = string
    })
    startup_command = string
    labels          = map(string)
  }))
}

// optional

variable "dlvm_options" {
  type = object({
    enable_notebook = bool
  })
  default = null
}

variable "gke_options" {
  type = object({
    version = string
  })
  default = null
}

variable "local_file_copy" {
  type = list(object({
    source      = string
    destination = string
  }))
  default = []
}

// exactly one of network_new and network_existing must be null
variable "network_existing" { type = string, default = "default" }
variable "network_new" { type = string, default = null }

variable "network_storage_existing" {
  type = list(object({
    server_ip     = string
    remote_mount  = string
    remote_ip     = string
    fs_type       = string
    mount_options = string
  }))
  default = []
}
variable "network_storage_new" {
  type = list(object({
    size_gb = number
    tier    = string // can be one of ["BASIC_HDD", "BASIC_SSD", "HIGH_SCALE_SSD", "ENTERPRISE"]
  }))
  default = []
}

variable "service_account" {
  type = object({
    email = string
    scopes = set(string)
  })
  default = null
}

These environment variables can probably stay since they are involved solely in the operation of the tool itself (not the terraform module):
SHOW_PROXY_URL
MINIMIZE_TERRAFORM_LOGGING

Not sure what to do about this guy yet:
TERRAFORM_GCS_PATH

The rest of the environment variables can be deleted.

Nice!  Looking forward to eliminating the code needed to generate to the tfvars file.
BTW, I'm not seeing "node_groups" anywhere in the current tfvars that gets generated (https://github.com/GoogleCloudPlatform/ai-infra-cluster-provisioning/blob/main/scripts/_env_var_util.sh), but maybe I'm not on the right branch.
Is this meant to be the same input as what currently gets generated and saved in /usr/primary/tf.auto.vars?  Or is it different?

BTW, I'm not seeing "node_groups" anywhere in the current tfvars that gets generated (https://github.com/GoogleCloudPlatform/ai-infra-cluster-provisioning/blob/main/scripts/_env_var_util.sh), but maybe I'm not on the right branch.
Is this meant to be the same input as what currently gets generated and saved in /usr/primary/tf.auto.vars? Or is it different?

@sdlin This is not currently in the environment variables. I noticed that the list of environment variables was growing with the number of orchestrators, so this is meant to be a list of common configurations between them (so they are not repeated orchestrator_count times)

After meeting with @sdlin, one thought is that the number of variables increasing was not the issue but rather their organization. Another option to explore for the node_groups variable to make it more intuitive is to have all the variables repeated but separated clearly like this:
// required
variable "mig_options" {
  type = list(object({
    node_group_count       = number
    node_count_static      = number
    node_count_dynamic_max = number

    // per node settings
    machine_type = string
    zone = string
    disk = object({
      type = number
      size = number
    })
    image = object({
      project = string
      family  = string
      name    = string
    })
    guest_accelerator = object({
      type  = string
      count = string
    })
    startup_command = string
    labels          = map(string)
  }))
  default = null
}

variable "gke_options" {
  type = list(object({
    gke_version = string

    node_group_count       = number
    node_count_min   = number
    node_count_max   = number

    // per node settings
    machine_type = string
    zone = string
    disk = object({
      type = number
      size = number
    })
    image = object({
      project = string
      family  = string
      name    = string
    })
    guest_accelerator = object({
      type  = string
      count = string
    })
    startup_command = string
    labels          = map(string)
  }))
  default = null
}

variable "slurm_options" {
  type = list(object({
    node_count_static      = number
    node_count_dynamic_max = number

    // per node settings
    machine_type = string
    zone = string
    disk = object({
      type = number
      size = number
    })
    image = object({
      project = string
      family  = string
      name    = string
    })
    guest_accelerator = object({
      type  = string
      count = string
    })
    startup_command = string
    labels          = map(string)
  }))
  default = null
}


Rename top-level Kotlin functions and properties correctly

If we generate two top-level Kotlin functions or properties with the same names in the same file, they'd have to be named differently not to collide with one another. This PR fixes that. Closes #1658.

coverage: 88.032% (+0.002%) from 88.03%
when pulling a79cdb3b0817ac37cee11be312f434202a43b883 on close-1658
into 49ce69089af88eb2bcc351d221e7644fb9da7219 on main.


update openpilot supercombo.onnx to 0.9.4

Should fix CI.
I am not very familiar with openpilot and onnx. Attempted to fix by checking errors and source https://github.com/commaai/openpilot/blob/57ad4f02f8e693639262aa3a982be8ed6c433ee0/selfdrive/modeld/modeld.py#L65.

Oh, did they change models on their end which resulted in slight changes in model architecture and kernel counts?

yeah I think there are some model updates, the old model reference commit was about an year ago and v0.9.0 only has 198 kernels.

https://github.com/commaai/commavq/raw/master/models/gpt2m.onnx is also down I think.  :s
external_model_benchmark doesn't run on master.

eh you are right, thanks for the info. commavq does not have a release tag that we can pull the large files though. Not sure how to proceed.
Also the v0.9.4 supercombo had RuntimeError: "slow_conv2d_cpu" not implemented for 'Half' when I tried to run external_model_benchmark.py locally, and after skipping that there's some numerical errors.
PYTHONPATH=. MODEL=openpilot python3 test/external/external_model_benchmark.py
https://github.com/commaai/openpilot/raw/v0.9.4/selfdrive/modeld/models/supercombo.onnx: 100%|███████████████████████████████████████████████████████████████████████████████████| 47.5M/47.5M [00:01<00:00, 27.1MB/s]
openpilot       tinygrad_metal_jitless     119.55 ms
openpilot       tinygrad_metal_jit           5.69 ms
openpilot       tinygrad_clang_jitless     177.86 ms
openpilot       tinygrad_clang_jit         110.62 ms
openpilot       onnx2torch doesn't support this model
openpilot       onnxruntime_cpu             41.29 ms
Traceback (most recent call last):
...
AssertionError:
Not equal to tolerance rtol=0.0008, atol=0.0008
For tensor 'outputs' in dict_keys(['outputs'])
Mismatched elements: 3 / 6120 (0.049%)
Max absolute difference: 0.05912781
Max relative difference: 0.2617
 x: array([[ 0.229035,  0.001494, -0.001691, ...,  0.      ,  0.      ,
         0.      ]], dtype=float32)
 y: array([[ 0.229   ,  0.001502, -0.001691, ...,  0.      ,  0.      ,
         0.      ]], dtype=float16)

We can have the commavq change in a separate pr, cuz it'll have to target the update_benchmark branch anyways

@wozeparrot anything you want to change from this PR? I can comment out the openpilot and commavq from external_model_benchmark so that it's not breaking. Would like to get this in to have a green CI soon.

Yea, commenting out should be fine, can bring them back in another pr, do want green ci

@wozeparrot done


EasyPost will not load anymore.

www.mdius.com
Just spins on checkout again.
Was trying to delete my EasyPost USPS shipping and it crashed my shipping.
I cannot give error codes till tomorrow, but it is related to EasyPost has no index number.
You've helped me with this issue before.

It seems to be working now.
Was able to delete the problem and shipping works.


BUG : Debug exception reason: Stack canary watchpoint triggered (task_stream1073)

Describe the bug
Hi, i just creating a program using WiFi and BLE for esp32 to listen rtdb and sending command via BLE(listener) to nearby devices(node/command executor) when value on rtdb changed.
First handling stream callback run smoothly.
After handling some stream callback function the devices (listener) rebooted.
To Reproduce
Steps to reproduce the behavior:
I had decode stack trace exception via EspExceptionDecoder tools and here what i got
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d7065: NimBLEClient::getService(NimBLEUUID const&) at .pio/libdeps/esp32dev/NimBLE-Arduino/src/NimBLEClient.cpp line 605
0x400d75c6: NimBLEClient::getService(char const*) at<EMAIL_ADDRESS>line 79
0x400d3e4d: sendingCommand(String) at src/main.cpp line 236
0x400d44d6: streamCallback(FirebaseStream) at src/main.cpp line 319
0x400f1e32: FB_RTDB::sendCB(FirebaseData*) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 3406
0x400f4502: FB_RTDB::handleResponse(FirebaseData*, fb_esp_rtdb_request_info_t*) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 3162
0x400f4b3a: FB_RTDB::waitResponse(FirebaseData*, fb_esp_rtdb_request_info_t*) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 2409
0x400f4ee5: FB_RTDB::handleStreamRead(FirebaseData*) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 741
0x400f4f29: FB_RTDB::readStream(FirebaseData*) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 636
0x400f4f95: FB_RTDB:: ::_FUN(void *) at .pio/libdeps/esp32dev/Firebase Arduino Client Library for ESP8266 and ESP32/src/rtdb/FB_RTDB.cpp line 889

Using Partition for Huge app ( 3MB , 1MB spiffs)
Checking my free heap before starting firebase connection about 140KB from 254KB
After firebase connection established free heap decreased to 93KB from 254KB
Heap after doing BLE function also stable on 93KB from 254KB

IDE and its version:

PlatformIO core:6.1.4 and home:3.4.3

ESP32 Arduino Core SDK version

Version 4.4.0

Another libraries

NimBLE-Arduino version 1.3.6

Additional context
Question :
is streamcallback cannot be interrupted with some delay() function ?
because when my listener handling stream data from rtdb, it will scan to nearby device about 5 seconds (time blocking) and sending command to nearby node (about 30-100 devices nearby) and trying to filtering each devices.
Why i asking this because NimBLE connect and retrieve some BLE attributes, it take some seconds.

That is your application that based on your code which you should manage the memory usage from available memory yourself.
Most of memory used by the library is dynamic allocation which taken by mbedTLS library approx 70k per server openning session which reducing much free heap.
The stack memory in ESP32 core is limited to 4 kB.

So, you suggest to increasing ESP32 core stack memory ?

I did not see the original error message that show the error detail that related to stack or heap.
The minimum free heap for mbedTLS to work is 100k.
The FirebaseData object create the instance of TCP client that utilized the mbedTLS for SSL/TLS data encryption/decryption.
Then when you use it for stream, which the connection must be kept open, the heap memory used by this all the time is approx. 70k
And if this object used for other tasks to update and read the database which the connection will keep open by default to reduce the time for SSL/TLS handshake every time, the memory will use all the time approx. 70k.
For the stack limit by hard code changing the file in core SDK which you can search google for how to do it.

How do you think what if i connect firebase with xTaskCreatePinnedToCore to maintain connection still open ?

It's not related to the session (http connection).
The http connection is normally closed by server after returning the response and can be kept open by client by sending the "Connection: keep-alive" header with the request.


No command equivalent to occ

not sure if that will ever happen, but I want to have an issue to indicate why some core API tests are skipped.
If there will be no such thing, pleas close this issue

Note: this is a general issue about the occ command, which will not be implemented the same in oCIS.
But often the occ command in oC10 is used to set system-wide settings in oC10. Many of those things may be implemented in oCIS, but the way that the system-wide setting is done by the system administrator in oCIS will be different. The test suite will have to understand the different ways to setup the system-under-test depending on if it is testing oC10 or oCIS.
There are other issues about the system-wide settings that are currently not available in oCIS bbut might be in the future. For example, #1328 for the system-wide settings applicable to sharing. Links in expected-failures files should point to those issues.


Adding anchor-link to individual fields within the spin documentation

Fixes: #1155
Pre-Merge Content Checklist
This documentation has been checked to ensure that:

[x] The title, template, and date are all set
[x] Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
[x] File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep '^M' | wc -l and expect 0 as a result)
[x] Has passed bart check
[x] Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
[x] Headings are using Title Case
[x] Code blocks have the programming language set to properly highlight syntax and the proper copy directive
[x] Have tested with npm run test and resolved all errors
[x] Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Hi @VamshiReddy02
Is it possible for you to write some Javscript that will find the table row's closest parent heading with the class attribute of heading-anchor.
I think that combining the previous heading text and the table row text (to lower kebab case, say) will provide a unique enough value to be stable over time (as apposed to counting/incrementing number values).
What do you think?
Let me know if this makes sense and let me know if you would like a hand.
Thanks so much for your contribution 👍

Thank you @tpmccallum  for the suggestions, I'll try to implement for those suggestions.

@tpmccallum @VamshiReddy02 I noticed in a recent article that uses one of the new links that we include the description as part of the link.  That means these anchors aren't going to be stable over time - as soon as we change a description, existing references will stop working, and users will be dropped in at the top of the page.  We need a solution that works not just at a point in time but across time.  Sorry for not noticing this when folks were working on it!

Thanks @itowlson - really great point. We may be able to update these row links to be more permanent.
@VamshiReddy02 I wonder if we can trim the URL back to just the row's name?
For example,  in the case of the application manifest reference table (say where we want to link to allowed_http_hosts) we could finish generating the hyperlink just after the allowed_http_hosts part. his would produce:
https://developer.fermyon.com/spin/v2/manifest-reference#spin-application-manifest-reference-allowed_http_hosts

Instead of:
https://developer.fermyon.com/spin/v2/manifest-reference#spin-application-manifest-reference-allowed_http_hosts-optional-array-of-strings-the-host-names-or-addresses-to-which-the-wasm-component-is-allowed-to-send-http-requests-this-is-retained-to-simplify-transition-from-the-version-1-manifest-new-applications-should-use-allow_outbound_hosts-instead-examplecom-localhost8081

My worry is that the name alone is ambiguous.  E.g. variables appears in more than one section.  @karthik2804 suggested nearest parent heading plus name (e.g. manifest-reference#the-component-table-allowed_http_hosts) would be unambiguous and likely to remain so.
@tpmccallum Would you prefer if I opened a new issue for this?

Hey @tpmccallum, Yes, I can trim the URL as you suggested. Additionally, the point raised by @itowlson is also valid. I can give a try to what @karthik2804 suggested.

Thanks @itowlson,
Yes, I agree with @karthik2804's idea. This was the suggestion proposed above i.e. "write some Javscript that will find the table row's closest parent heading"

@VamshiReddy02, if you could trim the tail of the URL to be just the nearest parent heading plus that row's name, that would be greatly appreciated. You may run into a spot of bother. I tried for a few minutes and found that it was tricky to successfully parse the page's DOM and extract the elements and attributes that I wanted (namely being able to land on the closest parent heading). I hope you have great success. I have opened a new issue here with a little more detail https://github.com/fermyon/developer/issues/1235.
Of course please feel free to open a new PR and we will take a look as soon as you are ready.

Something like this might just work (Have not tested)
function findNearestHeader(element) {
    var currentElement = element.parentNode;

    // Traverse up the DOM tree until a header element is found or no parent exists
    while (currentElement) {
      if (currentElement.nodeName.startsWith('h')) {
        // If the current element is a header element, return it
        return currentElement;
      }
      currentElement = currentElement.parentNode;
    }

    // If no header element is found in the ancestor elements, return null
    return null;
  }

Thanks @karthik2804 I will take this code suggestion over to the new issue for preservation.


create binary_tree_from_inorder_and_preorder.py

Description
This pull request contains the solution to a Leetcode problem that is to construct a binary tree from a given preorder and inorder traversals. This includes the addition of a file named "binary_tree_from_inorder_and_preorder.py".
Link of the problem: Construct Binary Tree from Preorder and Inorder Traversal
Fixes #186
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Ayush7614 @Amit366 Please, review and merge my pull request.

@Ayush7614 @Amit366 Please, review and merge my pull request.


No back button to change payment method after declined invoice payment method

if customers choose Invoice as payment methode, after a declined credit check, there is no button so the customer can go back / choose a new payment methode.
Please add this to the plugin asap.
Thank you

here a screenshot from a customer after declined invoice payment.
Still the button "bezahlen" visible but no obvious way to change the payment method.
I would suggest, if declined, to offer a button back to the cart to start over.

hi @Alcpaone , we are working on this together with https://github.com/pfpayments/jtl-5/issues/7#issuecomment-1878424103

@thibault-mambour ok, thank you for your feedback.

Please consider to change the button, instead of "Bezahlen" to change the button after declined payment to for example "neue Zahlungsart wählen" or shorter "Zahlungsart wählen".

The message after a declined payment should be changed. If you read the text at the moment (see the picture above) the customers has no clue, that he was declined. I looks like the service isn't working. The text should says, that this payment method isn't available for "you" at the moment.

Whats says yout time table about the next release?

hi @Alcpaone , we released a fix to have a button for going back. Could you please confirm if it works as expected ?

@thibault-mambour
new botton is now there (Stornieren) and works. It brings the customer back so he can change the payment method.
Thank you!
Please change the message if payment is declined:

to something like:
"Rechnung mit Teilzahlung (PoerPay) ist zur Zeit für Sie nicht möglich........."
It is important, that cusomers understand, the service is up and running but he can't use this at the moment.
We got phone calls from customers, telling us the payment service is down.
btw: the errors message appear on the left, all other elements are centered.

@thibault-mambour hi, where can i change the text that customers see if payment method invoice by powerpay is declined?
We need to do that until maby you change the text in the next release.
We see at the moment a lot customers trying and trying and trying. I think if the message would be clear, the stop trying or change the payment method if possible for them.

"Stornieren" Button is now visible


Soundness of the rate() function: is division by ms.Range.Seconds() correct?

What did you do?
Set up the SNMP exporter. Monitor some switches. Run this query:
rate(sysUpTime[4h])

What did you expect to see?
As the uptime increases with one second per second, I would expect to see flat lines.
What did you see instead? Under which circumstances?
If we scrape targets that were recently added or have been down for some time, this line is not flat.

This is due to data only being partially available; not for all four hours. Though this example may seem contrived, the problem applies to any type of rate computation. We effectively under-report values during the initial time frame.
Environment

Prometheus version:
2.1.0

Details
This is something I've noticed about Prometheus for a pretty long time, but finally decided to file an issuet about. Looking at the code, i suspect this may be due to extrapolatedRate() dividing its result by ms.Range.Seconds(), as opposed to using the actual length of the window containing samples.

This behaviour is as intended, averaged over the entire 4h the rate is not 1/s as it is 0/missing for much of that time. We used to do this differently, and it led to massive over reporting in similar scenarios.

Hmmm... I can't say I fully agree with that reasoning.
I understand that dividing through the meaningful length of the window, as opposed to the requested length, may indeed cause us to over-report. But then again, isn't there a full symmetry between these two? Example from a medical context: over/under-reporting someone's heart rate or blood pressure: both are equally bad. Even in systems administration: one can create an alert for detecting that certain types of events don't occur often enough. Example: a web service receiving no HTTP requests, due to its network uplink going away.
The algorithm used for computing rate() currently tries to prevent potential over-reporting by always under-reporting, which I find odd. If we're concerned about quality of data, maybe it makes sense to simply omit any results until a certain fraction of time (>=50%) is present?

The algorithm used for computing rate() currently tries to prevent potential over-reporting by always under-reporting, which I find odd.

I don't see how this is under reporting, it is the average rate over the time period in question.

If we're concerned about quality of data, maybe it makes sense to simply omit any results until a certain fraction of time (>=50%) is present?

That would lead to under reporting when a service was started or stopped.

If we're concerned about quality of data, maybe it makes sense to simply omit any results until a certain fraction of time (>=50%) is present?

That would lead to under reporting when a service was started or stopped.

I thought about this a bit more on the way back home. Picking an arbitrary cutoff (50% as I suggested) doesn't seem wise indeed. For example, in the past I've used rate(x[1d]) to get graphs with daily peaks smoothed out. Not emitting anything during the first 12 hours seems a bit pessimistic.
Has there ever been some discussion about introducing some kind of extended range vector selection expression that allows specifying a lowerbound? For example, rate(x[1h..4h]). This would mean: compute the rate over at most four hours of data, but only if at least one hour of data is available.

There have been discussions that touched on that in the past, but our current rate function is the result. This sounds like it's getting into reporting, for which you're probably going to want to pull the raw data into a script anyway.


Changing tab bar height

Love the component! It's been great to use and easy to integrate into our project!
I was wondering if there's anything in the horizon as far as plans go to support a changing tab bar height.
For example, when the header is collapsed, I'd like to show a condensed form of the tab bar to maximize screen real estate. I'm not sure if this is possible currently, so if anyone's done it, I'd love to see an example 🙏

You can do it by listening to the scrollY value using useCurrentTabScrollY() and then update the height accordingly


Spacing & Sizing Updates (Tree, Table, Nav)

What Changed
A number of fixes for minor spacing, themes, and resizing issues.

Fix the spacing of the Tree arrow, which was misaligned when placed next to non-arrow tree elements.
Fix the font sizing in Table, make it scale properly.
Fix the font sizing in Navigation, make it scale properly.
Fix the background and text color for themes in Navigation.

Why
What might be impacted
Todo:

[ ] Add tests
[ ] Add docs

:rocket: PR was released in v1.0.2 :rocket:


Can you add Yammer as network ?

Can you add Yammer as network ?
Thanks

Hello @ChoOo7,
I do not have a Yammer account to make tests, could you confirm that the following sharing link works?
https://www.yammer.com/messages/new?login=true&trk_event=yammer_share&status=test%20vue%20social%20sharing%20https%3A%2F%2Fvuejs.org%2F
and
https://www.yammer.com/messages/new?status=test%20vue%20social%20sharing%20https%3A%2F%2Fvuejs.org%2F

Both are Ok, thanks  :)

@ChoOo7 Yammer has been included in the latest release :smiley:


Log event info changes width with each event

Effect is really bad with debug output, but even when no debug then it can still happen to much less degree depending on width of data items being displayed

The effect with debug output is now fixed in v3 - just left with minor jittering size for the data items (not sure if I'll bother fixing that?)


updated Microsoft/vscode

@<!-- Thank you for submitting a Pull Request. Please:

Read our Pull Request guidelines:
https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests
Associate an issue with the Pull Request.
Ensure that the code is up-to-date with the main branch.
Include a description of the proposed changes and how to test them.
-->

thanks guys!!!!


Issue 193

Temporally Address 193, remove background plugin if importing pyproj fails

See the Tracebook below. I still managed to get a failure from an attempted import:
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/plot_radar.py", line 307, in _UseMapToggleAction
    self._update_display()
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/plot_radar.py", line 915, in _update_display
    display = pyart.graph.RadarMapDisplay(self.Vradar.value)
  File "/Users/guy/anaconda/lib/python2.7/site-packages/pyart/graph/radarmapdisplay.py", line 83, in __init__
    "installed")
pyart.exceptions.MissingOptionalDependency: Basemap is required to use RadarMapDisplay but is not installed
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/plot_radar.py", line 547, in NewField
    self._update_plot()
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/plot_radar.py", line 979, in _update_plot
    plot_ppi = display.plot_ppi_map
AttributeError: 'RadarDisplay' object has no attribute 'plot_ppi_map'
Changed Scan types, reinitializing
2017-04-17 22:00:36.657 python[28042:1514225] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
2017-04-17 22:00:58.308 python[28042:1514225] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
Warning Discarded!
connect var VpyartDisplay of ImageBackground from Display1
disconnect var VpyartDisplay of ImageBackground from Display1
connect var VpyartDisplay of ImageBackground from Display1
2017-04-17 22:01:14.672 python[28042:1514225] modalSession has been exited prematurely - check for a reentrant call to endModalSession:
Warning Discarded!
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/plugins/background.py", line 298, in apply
    x0 = float(str(self.x0_lineEdit.text()))
ValueError: could not convert string to float:
connect var VplotAxes of ImageBackground from Display1
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/component_control.py", line 158, in linking
    self.connectVar(var)
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/components/component_control.py", line 244, in connectVar
    self.comp1.disconnectSharedVariable(var)
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/core/core.py", line 266, in disconnectSharedVariable
    self.sharedVariables[var])
TypeError: 'instancemethod' object is not connected
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/plugins/background.py", line 298, in apply
    x0 = float(str(self.x0_lineEdit.text()))
ValueError: could not convert string to float:
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/plugins/background.py", line 300, in apply
    dx = float(str(self.dx_lineEdit.text()))
ValueError: could not convert string to float:
Traceback (most recent call last):
  File "/Users/guy/anaconda/lib/python2.7/site-packages/artview/plugins/background.py", line 312, in apply
    lat_radar = float(radar.latitude['data'][0])
AttributeError: 'NoneType' object has no attribute 'latitude'

you started imagebackground from the plugins? there is no mode for using it.


Allow customizing database backup location

Release Note
Allow customizing the database backup location (defaults unchanged)

/assign @mikehelmick


save chat history

save chat history in the end of session

Long term persistent rooms or how do you think to save it?
Send to moderator in email?

Save from browser to local rooname_chat_dato.txt file


chore: format everything

Fixes https://github.com/the-codegen-project/cli/issues/20

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix readme

golang example not formatted correctly

I'm sorry. I didn't notice duplicate pull requests =(


wire express

implement a sample route in express.  The server side code can do something simple (output to server console)

completed with commit 422c01115163a9cf6581035657ec29c935672b02

This tutorial was used for guidance:
https://codeforgeek.com/2014/06/express-nodejs-tutorial/

What to do with my bike
On Monday, October 12, 2015, Jeff Groom<EMAIL_ADDRESS>wrote:

This tutorial was used for guidance:
https://codeforgeek.com/2014/06/express-nodejs-tutorial/
—
Reply to this email directly or view it on GitHub
https://github.com/jgroom33/EthUI/issues/10#issuecomment-147242906.


doSwitchOrElse with Exception

Hi there,
As part of performance script, the idea is to have a doSwitchOrElse() with each possible page under test as parameter, throwing an exception otherwise.
For example, something like this:
var page = "google"
    val load = doSwitchOrElse(page) ( "yahoo" -> exec(),
                         "google" -> exec()
                         ) (
                      throw new Exception("Hello World!")
                  )

The point is Exception seems to be thrown always, even if parameter is matching one of possible ones in doSwitchOrElse(). For code above, the console output is the next one:
Caused by: java.lang.Exception: Hello World!
at com.example.TestHandler$.(TestHandler.scala:83)
at com.example.TestHandler$.(TestHandler.scala)
... 26 more
Possible bug or not well controlled behavior? If so, please could you include in next releases?
Thanks

This is a user issue. Please use the community mailing list for questions.

Raised in Gatling mailing list.
Thanks


create framebuffer object with stencil and depth buffer on android, return GL_FRAMEBUFFER_UNSUPPORTED

when create a framebuffer object with stencil and depth buffer on android, the glCheckFramebufferStatus return GL_FRAMEBUFFER_UNSUPPORTED
actually on android, if both stencil and depth buffer will be used in framebuffer object, the renderbuffer should use stencil and depth combined renderbuffer,  such as GLES11EXT.GL_DEPTH24_STENCIL8_OES. Here is my code specific to android platform
if (hasStencil && hasDepth) {
gl.glBindRenderbuffer(GL20.GL_RENDERBUFFER, depthStencilBufferHandle);
gl.glRenderbufferStorage(GL20.GL_RENDERBUFFER, GLES11Ext.GL_DEPTH24_STENCIL8_OES, colorTexture.getWidth(), colorTexture.getHeight());
gl.glFramebufferRenderbuffer(GL20.GL_FRAMEBUFFER, GL20.GL_DEPTH_ATTACHMENT, GL20.GL_RENDERBUFFER, depthStencilBufferHandle);
gl.glFramebufferRenderbuffer(GL20.GL_FRAMEBUFFER, GL20.GL_STENCIL_ATTACHMENT, GL20.GL_RENDERBUFFER, depthStencilBufferHandle);
}

test with android 4.4 and android 5.1 on nexus5

I had problems too with this, thanks for that, we'll wait for Xoppa, he is the 3D guy !

Can you send a PR to fix it. Or, include a small sscce which I can use to verify and fix it?

PR created
https://github.com/libgdx/libgdx/pull/3460

Hello!
You have a new message, please read http://beta.lotosus.com/italian.php?fr
<EMAIL_ADDRESS>


nixos/rl-2211: remove reference to nowhere

The note this originally referred to was moved to the “Internal Changes” section and later trimmed down, so the referenced content is no longer there.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Blocked on #203952.

Please rebase.


Potential NPE in TopicPartitionWriter

This case will yield a NPE if a null record is passed in.
https://github.com/Azure/kafka-sink-azure-kusto/blob/6dbd611a0fbad324cc27430ed3a61fe5e447c8b4/src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/TopicPartitionWriter.java#L205-L207
I tried to push a PR to fix but I'm blocked, so I'll start by opening an issue.

fix on #63
2.3.0


restructuring source

Restructuring source tree to make it a little easier to follow and hopefully test

Awesome stuff :+1:


chore(rust): update rust deps

Description

Test Plan

#530  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on  Graphite


Change vcx_update API to accept connection handle

The problem with current API is described https://github.com/hyperledger/indy-sdk/issues/2211
I propose to add new update methods, deprecate old ones in 1 release, remove deprecated update methods in next release.

Were addressed by these PRs
https://github.com/AbsaOSS/libvcx/pull/84
https://github.com/AbsaOSS/libvcx/pull/92
Which add C-Callable functions:
vcx_v2_credential_update_state
vcx_v2_issuer_credential_update_state
vcx_v2_disclosed_proof_update_state
vcx_v2_proof_update_state


Fix Travis (GCE) install of SGE

Closes https://github.com/nanshe-org/nanshe/pull/319
Provides a simplified version of the work done in the aforementioned PR.

As the SGE tests times are too long, they will be disabled again by a revert commit to follow. However, the Travis CI test will be run through with the SGE tests enabled to demonstrate that they are working again.


Create change_vm_vif.py

sample for issue #103

I got this to work, under this project's rules... that's enough. I would like to see edits on this one to make it a little easier to use I got lost with the BIOS UUID and the network name. I predict a few of our less experienced users will trip on those. We'll see.