Find match color is hardcoded at multiple places

Search view and References widget re-uses the find match color rgba(234, 92, 0, 0.3) by hardcoding. After exporting the find match color as TM theme setting, these should also start using the color value from the setting.
Verification steps:

Clone the repository VS Code Extension Samples
Open VS Code on theme-sample
Open Sample_Dark.tmTheme and Sample_Light.tmTheme files and change the color for the setting findMatchHighlight
Run the extension using Launch Extension.

Verify the above color is picked by

Find matches

Search matches

Reference matches

How can this be verified? Should this be marked debt instead of bug?

@Tyriar This is not yet part of the build. I just delivered this change. I will update this item with clear verification steps. Thanks for pointing this.

@alexandrudima Can you verify this?

Works nice!


[Bug]: No debug logs after setting LOG_LEVELS=ragflow.es_conn=DEBUG

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

RAGFlow workspace code commit ID
834c4d8
RAGFlow image version
v0.14.1 slim
Other environment information
No response
Actual behavior
I have set the environment variable LOG_LEVELS=ragflow.es_conn=DEBUG for the ragflow-server, but I am not seeing any related debug logs.

Could you please help me troubleshoot this issue?
Thank you!
Expected behavior
No response
Steps to reproduce
# echo `LOG_LEVELS=ragflow.es_conn=DEBUG` > .env
# docker compose -f docker-compose.yml up -d

Additional information
No response

Not a bug. Old verison.


Asynchronously refresh OCSP

@vmamidi : scanning through things, it looks like this addresses #9160 . Is that correct? If so, can you please link the issue.

I do wonder why this isn't done on a TASK thread instead of having a special thread group for OCSP.

fixes issue #9160

I do wonder why this isn't done on a TASK thread instead of having a special thread group for OCSP.

Probably large number of certificates require a separate thread group.


Hibernate orm tests

Will be closing this PR as the desired test workflow has been integrated and merged into the wrapper's refactored test suite


osx-arm64 builds missing

Comment:
Hi - I would love to update kornia in our env but cannot because we are on mac and the kornia-rs builds are only available for mac x86, but not mac arm64. Could this arch be added or is this really hard?

what python version are you targetting ? In principle we support arm64. See: https://github.com/kornia/kornia-rs/blob/main/.github/workflows/python_release.yml

We are targeting 3.10, 3.11 soon hopefully. So in the end, this is a simple manner of enabling that architecture and triggering the bot?

Yeah, maybe we just need to follow https://conda-forge.org/blog/2020/10/29/macos-arm64/. @bschindler is there another rust-based conda-forge package you know of that has these builds? That would also help us make sure we're enabling it correctly.

I am really more of a conda user than a developer, but I know that ruff has a rust core and is installable on arm64. I guess its possible to peek there...?

Thanks, I'll take a look there when I get some free time


Segmentation fault: 11

when running the pepper_basic or any other test it loads the model and crashes..
Any ideas?
AA-MacBook-Pro:peppersim aa$ python peper_basic.py
pybullet build time: Mar 10 2020 14:41:15
Version = 4.1 INTEL-14.2.16
Vendor = Intel Inc.
Renderer = Intel(R) Iris(TM) Plus Graphics 650
b3Printf: Selected demo: Physics Server
startThreads creating 1 threads.
starting thread 0
started thread 0
MotionThreadFunc thread started
Fatal Python error: Segmentation fault
Current thread 0x000070000eccd000 (most recent call first):
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/camera.py", line 265 in _getCameraImage
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/camera.py", line 386 in _frameExtractionLoop
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 754 in run
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801 in __bootstrap_inner
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 774 in __bootstrap
Thread 0x0000000103c45dc0 (most recent call first):
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/camera.py", line 152 in getFrame
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/camera.py", line 304 in _waitForCorrectImageFormat
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/camera.py", line 365 in subscribe
File "/Users/aa/Library/Python/2.7/lib/python/site-packages/qibullet/robot_virtual.py", line 205 in subscribeCamera
File "peper_basic.py", line 23 in main
File "peper_basic.py", line 32 in
Segmentation fault: 11

Hi,
Thanks for reporting the issue. Could you specify which version of qiBullet you're currently using, and your OS version ?

Hi mbusy,
thank you very much for your fast reply

macOs Catalina 10.15.1
qibullet 1.4.0  - numpy 1.16.6  - pybullet 2.6.6

With the sample you provided it doesn't crash but it stops responding within the window; I'm able to press enter in the terminal to exit it. Without the gui = False it seems to run ok.
what are the minimum requirements to run it?  I mean could it be that my mac specs can't handle it?

You're welcome. I don't think that your specs are the problem, I believe that the OS doesn't handle OpenGL3 successfully... The way I see it you've got 2 problems:

The GUI doesn't respond
A seg fault appears when retrieving camera images

Regarding the first issue, one possible solution would be to replace that line by
pybullet.connect(pybullet.GUI, options="--opengl2")

Regarding the second issue, I'm guessing that using pybullet.ER_TINY_RENDERER instead of pybullet.ER_BULLET_HARDWARE_OPENGL (here) might fix the issue, but that's not ideal.
I'll test this as soon as possible, but I don't have a system running Mac OS at my disposal (and with the COVID situation I might have some troubles getting my hands on one). I'll eventually test that on a VM

Hi mbusy,

when adding the opengl2 option, GUI doesn't start at all.
changing it to ER_TINY_RENDERER I still get the Segmentation fault: 11
same as before :/

Alright, it was worth a shot, thanks for testing :smile:.
Another explanation for the first problem could be the simulation step thread. On Windows / Linux, running a simulation with a GUI will automatically spawn an additional thread, stepping the simulation. If I remember correctly, in Mac OS that thread might not be spawned because of OS limitations... So we would need to manually spawn such a thread. We already do that when gui is set to False, in your case doing that when gui is set to True might be relevant

This comment (issue in bullet3) seems to confirm it

Hi, I'm also experiencing crashes on MacOS and I'm pretty sure it's related to camera. Without camera use everything seems to work well. For instance this works (https://github.com/softbankrobotics-research/qibullet/blob/master/examples/robot_joint_control.py) while this doesn't (https://github.com/softbankrobotics-research/qibullet/blob/master/examples/pepper_basic.py).
The line that makes everything crash is:
handle = pepper.subscribeCamera(PepperVirtual.ID_CAMERA_TOP)
I hope it helps with investigation...

Thanks for the feedback @lubiluk, yes the camera is indeed a source of bug on macOS, even when using ER_TINY_RENDERER  over ER_BULLET_HARDWARE_OPENGL (see previous comment)...
There is also the problem of the freezing GUI: when you run the robot_joint_control example, do you manage to "nudge" (for lack of a better word) the head (or any link) of the robot, by clicking and dragging it with your mouse ?

There is also the problem of the freezing GUI: when you run the robot_joint_control example, do you manage to "nudge" (for lack of a better word) the head (or any link) of the robot, by clicking and dragging it with your mouse ?

Nudging the the robot seems alright. It doesn't freeze on my machine:
Version = 4.1 ATI-3.10.18
Vendor = ATI Technologies Inc.
Renderer = AMD Radeon R9 M370X OpenGL Engine

@elggem Thanks for the info, even though I don't have a lot of time to work on this issue it's always appreciated. The fact that either renderer causes a segfault was already known, but I wasn't aware that pybullet.getLinkState also causes a crash, thanks for reporting


store region code and map the code to the relevant region at the frontend.

Before, we store the region name (e.g. N. Virginia) in the persistent file.
After, a map is used to map the code to the relevant region name in the frontend (e.g. us-east-1 -->N. Virginia).
Also, storing the actual region code is more favorable for the code is needed for API call to the provider, leaving more space for further development. (say, redirect to the actual purchase page in a single click of the instance item).

PTAL

@LiuJi-Jim Would you help review frontend code? Thanks


reduce dropdown size

I'd really like an approval from @digital-asset/daml-product on this one.
When merged, this PR will reduce the size of the version dropdown on docs.daml.com to just the latest patch for each 2.x minor and a single 1.x version (1.18.3).
This will not delete any page, i.e. the 1.17.0 and 2.2.0 versions will still be available on, respectively, https://docs.daml.com/1.17.0 and https://docs.daml.com/2.2.0. They just won't appear in the dropdown anymore.
I'd really like to prune this more, but this seemed like a safe first step as I don't expect anyone to object. (but we'll see)

One question please: is to do with the menu not scrolling in an attempt to make it shorter?

One question please: is this to do with the menu not scrolling in an attempt to make it shorter?

Not really; the lack of scrolling is annoying, but:

we can only conveniently update the latest patch of each minor in both code and docs.
our support policy is that we only support the latest patch for each minor.
there's very little value in keeping older patches as the differences in docs are typically marginal and always strict improvements (we don't go through the effort of changing docs for an older version unless there's a strong need).
at this point we really don't want anyone on 1.x, especially other than 1.18.3, and possibly also on 2.2.x or lower, so it's not clear who those additional versions of the docs would be useful for and we may not want to advertize that they are available.

One question please: is this to do with the menu not scrolling in an attempt to make it shorter?

Not really; the lack of scrolling is annoying, but:

we can only conveniently update the latest patch of each minor in both code and docs.
our support policy is that we only support the latest patch for each minor.
there's very little value in keeping older patches as the differences in docs are typically marginal and always strict improvements (we don't go through the effort of changing docs for an older version unless there's a strong need).
at this point we really don't want anyone on 1.x, especially other than 1.18.3, and possibly also on 2.2.x or lower, so it's not clear who those additional versions of the docs would be useful for and we may not want to advertize that they are available.

Cool, makes sense. We should fix the scroll issue too if we can.

Approving on behalf of @bame-da, who verbally agreed to the change.

Approving on behalf of @bame-da, who verbally agreed to the change.

Thanks!


[move-prover] Verified the local specs of Coin1 and Coin2

Added/verified the local specs of Coin1 and Coin2
Added candiate global properties as TODOs
Fixed a bug in Roles::spec_has_register_new_currency_privilege

Motivation
To verify the local specs of Coin1 and Coin2
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

:umbrella: The latest upstream changes (presumably 01568d5e3958c3e070e2c3b854002c64a2ac1483) made this pull request unmergeable. Please resolve the merge conflicts.


Repository Explorer - blank window when clicking on node in visual graph

Install odpi-egeria-lab helm chart (--prerelease .. for version 4)
Run configuration notebook
Run 'building a data catalog'
Open up react ui & login as garygeeke
Launch REX
Click on cocoMDS2 and search for .*
Select All items found & add to graph
Click on one of the graphical nodes on the graph

At this point the web page loads a blank screen.
This occurs in safari 16.4
Not yet tested standalone.
Critical issue to address for Egeria release 4.0
cc: @dwolfson

Also tested

Locally (macOS) (multiple platforms & node server)
Chrome

Same behaviour noted

TEX seems ok

No odd messages noticed in

output from node server
platform running view servers

@davidradl Do you have any thoughts on what might cause this?
The code itself hasn't changed

@planetf1 are you using the latest code - as I merged in the check for undefined yesterday, which gave this symptom.
You could put on the developer tools on chrome and see if there is more diagnostics there - there usually is.

Thanks. I'll check again.

I have tested locally. The UI seems to work normally :-)
I see there is a new prerelease container, so I will try that also

Tested in containers - also all good, so closing.


Fix inherit_mode for arrays in extension default

See https://github.com/rubocop/rubocop-rspec/issues/1126
config/default.yml:
RSpec:
  Language:
    Examples:
      inherit_mode:
        merge:
          - Regular
      Regular:
        - it
        - specify
        - example
        - scenario
        - its

.rubocop.yml:
require:
  - rubocop-rspec

RSpec:
  Language:
    Examples:
      Regular:
        - mycustomexamplealias

Previously, locally-set inherit_mode in extension default configuration was not respected.
I'd love a preliminary review. If you're fine with the approach, I'll add a proper test coverage.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[-] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@jonas054 Your solution to merging inherit_mode of derived and base is more elegant in merge Exclude by default. Do you want me to adjust this PR to use the same approach?

Even though this is titled as a "fix", it might be considered a breaking change, too.

The proposal seems reasonable to me, but I'll defer to @jonas054 on this one. As this affects only extensions and arguably the new behaviour is better I guess we don't have to label this a breaking change.

Thanks for fixing this @pirj!
I'm good with this not being a breaking change -- even if it does break a config, it is really a bug fix and that config shouldn't have worked in the first place.
Can we add some tests for the change?

@pirj Something seems off with the Win builds. Can you restart the build?

@bbatsov All green.
Somehow it fixed itself, I didn't rebase on top of the presumable fix.

Thanks!

:+1:


Feature: Paginator for queries

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
Doctrine ORM ships with a Paginator for DQL queries. It has a very simple API and implements the SPL interfaces Countable and IteratorAggregate. We can do it manually, however when building something large an out of box solution can be very time saving. Typeorm supports this via a 3rd party package https://github.com/nestjsx/nestjs-typeorm-paginate
Describe alternatives you've considered
paginator = new Paginator(query, fetchJoinCollection = true)
Additional context
All the details can be found here : https://www.doctrine-project.org/projects/doctrine-orm/en/2.8/tutorials/pagination.html#pagination

This is already implemented as a QueryFlag.PAGINATE.

https://github.com/mikro-orm/mikro-orm/blob/master/tests/EntityManager.mysql.test.ts#L2247


can't display labels and tooltips on some charts like Treemaps

hey, thanks for the great plugin !
I have trouble displaying labels on a Treemap (similar to the Treemap-simple demo from : https://echarts.apache.org/examples/en/editor.html?c=treemap-simple )
here's the render comparison, logseq on the left, e-charts website on the right:

labels are not showing in logseq. not sure if it's a bug or the feature is not implemented yet.
the code for the Treemap, using label attributes
option = {

 backgroundColor: '#2c343c',
  title: {
    text: 'My Treemap',
    left: 'center',
    top: 20,
    textStyle: {
      color: '#ccc'
    }
  },
  legend: {
    type: "plain",
    show: true,
  },
  tooltip: {
    show: true,
   trigger: "item"
  },
  series: [
    {
      type: 'treemap',
      sort: false,
      data: [
        {
          name: 'nodeA',
          value: 10,
          children: [
            {
              name: 'nodeAa',
              value: 4
            },
            {
              name: 'nodeAb',
              value: 6
            }
          ]
        },
        {
          name: 'nodeB',
          value: 20,
          children: [
            {
              name: 'nodeBa',
              value: 20,
              children: [
                {
                  name: 'nodeBa1',
                  value: 20
                }
              ]
            }
          ]
        },
        {
          name: 'phi',
          value: 14
        },
        {
          name: 'phi2',
          value: 21
        }
      ],

      label: {
        show: true,
        distance: 2,
        padding: 5,
        position: "inside",
        formatter: '{b}:{@score}',
        color: '#fff',
        fontStyle: 'normal',
        fontWeight: 'normal',
        fontSize: 34
      },
	itemStyle: {
      borderWidth: 2,
      borderColor: "#ff0000",
    },
    tooltip: {
    show: true
   }
  }
  ]
};

Hey, @cannibalox thx for your feedback
I think it is a bug from echarts, this is a demo, and I report this bug to echarts team, need echarts team to confirm and fix
Reported issue: https://github.com/apache/echarts/issues/18205
Bug showcase: https://stackblitz.com/edit/js-pdnjm1?file=index.js

thank you for the details and for reporting the link upstream. I hope they can fix the issue :)

Hey, @cannibalox
this issue has been fixed by echarts org,
you can upgrade this plugin to the latest version(v.14.0),
thanks for your feedback again.


Correctly update filename

Fixed an issue where the filename would not be update on an array of values.

@logan-anderson when would the filename be an array?


No space between formula and text

There is no space between text and formula while pasting Unicode math

KaTeX renders LaTeX math mode.  It sounds like you want LaTeX text mode.  You can enter text mode via \text{...}.  For example:
\text{The sum to $n$ terms of the series, }1+\left(1+\frac{1}{2}+\frac{1}{2^2}\right)+\left(1+\frac{1}{2}+\frac{1}{2^2}+\frac{1}{2^3}+\frac{1}{2^4}\right)

This is the Unicode generated by Microsoft Office, I can't add \text to text only. Is there any other way to separate the formula and text in Katex while rendering?
The sum to n terms of the series, 1 + \left(1+\frac{1}{2}+\frac{1}{2^2}\right)+
\left(1+\frac{1}{2}+\frac{1}{2^2}+\frac{1}{2^3}+\frac{1}{2^4}\right)+ …… is

Two ways to think about this:
(1) Math is math (and get KaTeX to process it), and text is text (just let the browser display your text (in your default page font).
So for your example, you'd have (assuming you're using $ as your delimiter):
The sum to $n$ terms of the series, $1 + \left(1+\frac{1}{2}+\frac{1}{2^2}\right)+ \left(1+\frac{1}{2}+\frac{1}{2^2}+\frac{1}{2^3}+\frac{1}{2^4}\right)+ ...$ is
(2) If you want the whole thing to look like a LaTeX PDF (kind of) with all text looking like the example @edemaine gave above, but it's too troublesome to manipulate Word's output, you could use the same code I gave in (1), but style the ordinary HTML text on your page using KaTeX fonts via the use of class="katex".
It would be something like this:

The sum to  $n$ terms of the series,  $1 + \left(1+\frac{1}{2}+\frac{1}{2^2}\right)+ \left(1+\frac{1}{2}+\frac{1}{2^2}+\frac{1}{2^3}+\frac{1}{2^4}\right)+ ...$ is ...
The output is something like (for a different example than yours):

I'd suggest approach (1). It's easier.
Regards
Murray

Thank you, @mbourne , for your suggestion. However, my database has over 100,000 lines, which include both text and Unicode characters. It is not possible to separate them for each line. Can you please share the code as well?
The sum to n terms of the series, 1 + \left(1+\frac{1}{2}+\frac{1}{2^2}\right)+
\left(1+\frac{1}{2}+\frac{1}{2^2}+\frac{1}{2^3}+\frac{1}{2^4}\right)+ …… is

I gather your output from Word has no  tags around the math. Is this correct? Or have you saved as text only, thus losing any markup?
If so, and if Word doesn't give you an option to do so, then you may have success doing the following.
In the original Word document, do "Save as..." and choose HTML. It will probably save the math as images and if you're lucky, the math content will be included as the alt tag, or in a data tag on the img.
Then it's possible to separate out the plain text and the math (using JavaScript at run time, or better, preprocessing it with PHP or similar), then get KaTeX to process the math.
I haven't used Micro$oft products in years, so not sure what options are actually available to you.
Regards


Fix for capture block index count

Block index counter at capture was misaligned. This should fix it

CI gfxreconstruct build queued with queue ID 37309.

CI gfxreconstruct build # 3171 running.

CI gfxreconstruct build # 3171 failed.

CI gfxreconstruct build queued with queue ID 37338.

CI gfxreconstruct build # 3172 running.

CI gfxreconstruct build queued with queue ID 37483.

CI gfxreconstruct build # 3174 running.

CI gfxreconstruct build # 3174 passed.


Description missing

Title and description entry. Title shows fine, but description is no longer displayed. Both new & existing entries are affected.

Please paste your system environment and logs from About > Bug Report.
Also, please attach here a sample item with a description that does not appear.
By the way, have you double-checked the relevant settings: Settings > Viewer > Overlay > Show description?

Oops. It was the setting in the overlay options. Which is strange, because
I never touched those.
Still, at least that resolved it. Thank you for taking the time to correct
it Thibault.
Best regards, Ben
On Mon, 26 Jun 2023, 15:54 Thibault Deckers, @.***>
wrote:

Please paste your system environment and logs from About > Bug Report.
Also, please attach here a sample item with a description that does not
appear.
By the way, have you double-checked the relevant settings: Settings >
Viewer > Overlay > Show description?
—
Reply to this email directly, view it on GitHub
https://github.com/deckerst/aves/issues/672#issuecomment-1607656739, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A6M4RTJUUQVFI6E2KFGD2O3XNGPBBANCNFSM6AAAAAAZUEJ3CU
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix: improve isAimable method

if (!isAimable(weapon) || weapon.spec.trackingStr != null) caused aimable weapons with None tracking string to be treated as non-aimable. With some tag combinations it caused e.g. Reapers or Annihilators to be launched into thin air, if enemy was nearby, but not in line of attack.
Checking weapon.spec.trackingStr was moved into isAimable method, as it seems its responsibility and removes code duplication. Note: the change influences SpecificAIPluginBase:computePointToAimAt method.

Good catch, thanks for contributing the fix!
That might explain one or two instances of weird behavior!
I'll include this in the next release =)


setTrimControlStructures isn't working

Hello, I'm using JTE in my spring boot app and I'm not sure why setTrimControlStructures isn't working. I have the following JTE config:
@Configuration
public class JteConfig {

  @Bean
  public TemplateEngine templateEngine() {
    var templateEngine = TemplateEngine.createPrecompiled(Plain);
    templateEngine.setTrimControlStructures(true);
    return templateEngine;
  }
}

If you need more details, please let me know.
Thank you!

Welcome, @rjma30!
trimControlStructures has no effect when loading precompiled templates (since the trimming happens at compile time).
You probably need to remove the option here and set it when precompiling templates, probably through maven/gradle plugin.

Oh, one more question, are you rendering HTML documents with jte? If so, I would recommend ContentType.Html instead of ContentType.Plain. Besides the added security, it also offers some convenience features: https://github.com/casid/jte/blob/main/DOCUMENTATION.md#html-rendering

Hi @casid, It worked by setting it true via gradle! Thank you and apologies for my ignorance. Also, I'm not using html. I'm using jte for network device CLI configurations and it is perfectly doing its job :-)


chore(deps): update dependency semantic-release-jira to v1.2.4

This PR contains the following updates:

Package
Type
Update
Change

semantic-release-jira
devDependencies
patch
1.2.3 -> 1.2.4

Release Notes

juliangieseke/semantic-release-jira
v1.2.4
Compare Source
Bug Fixes

improve regex matching (d626868), closes #2

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Enabled.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 2.154.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


DSS-1415: Support legacy encoding of ts tokens preserving cert ordering.

Regarding the discussion in the thread https://bouncycastle.org/devmailarchive/msg15273.html , the attached patch adds a parameter that can be used to get the same behavior as before BC 1.50 for instance when it comes to the ordering of the certificate in the output.

I've managed to reproduce this. The patch suggested solves the immediate issue but does not actually fix the problem.
It turns out what is actually happening is that TimeStampResp is using a DERSequence, rather than a DLSequence and this is resulting in a DER encoding of the CMS SignedData making up the token. I've fixed TimeStampResp to use a DLSequence and also added code to produce a definite length encoding of the signed data as some people will have issues parsing indefinite length data embedded in definite length objects.
The change you are after should appear on github shortly in TimeStampResponseGenerator. It's slightly different to the old code as it is trying to avoid introducing indefinite length data. It will work with the old version of TimeStampResp as well (which is also now fixed).

Nice, that was a bit simpler.
But does that mean that the time-stamp response will not be DER encoded?
Looking in RFC#3161 for instance in section 3.4 if I understand it the response message should be DER encoded so I am a bit worried if that requirement will not be satisfied. What is your thought?

Okay, 3.4 is actually about using it with MIME. Technically this would mean the response is not properly DER encoded because the BER status of the SignedData is still being recognised (so the SET structures in it are not sorted). As far as the outside world is concerned the response will appear to be DER encoded as a definite-length sequence is the same as a DER sequence.
I think this is okay, even if used with MIME, although the standard specifies DER, I think in this case the only reason for DER is prevent indefinite-length encodings appearing, particularly in the outer layer. Thinking about it again, we should probably leave TimeStampResp as DER explicitly.

So in that case if you will be reverting to continue using DER explicitly then when might still need to have the legacy encoding option as suggested in this PR in order to not break legacy systems that are (incorrectly) relaying on the ordering of the certificates. Would that be possible to include?

Well, it's little complicated, the thing is that the re-encoding of the ContentInfo body hides the fact the object isn't DER encoded... So DER for the outer wrapper doesn't have quite the same effect as it might. I think I see what you're worried about though, leave it with me, I need to think if there is some "elegant" way out of this.

Okay, I think I now have a way out of this we can all live with.
   TimeStampResponse initResp = tsRespGen.generateGrantedResponse(request, ..., new Date());

Will now return the signedData in the response intact so that:
initResp.getEncoded(ASN1Encoding.DL);
will return the signedData in definite-length format, so without the SET objects being sorted. This is what you need to use for people looking for the legacy option.
initResp.getEncoded()
On the other hand will return the DER encoding and so be fully conformant with the stated encoding requirements for use with MIME.

My tests are passing and this looks like a more clean solution. Thanks again!
Cheers,


⚠ Bofrost.fr has degraded performance

In db66686, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1311 ms

Resolved: Bofrost.fr performance has improved in a7a7387 after 8 minutes.


Normallize drive letter to upper case when convert uri to FsPath, fix #155883

Thanks for your contribution. Unfortunately we cannot accept changes to the fsPath-property. Many extension make assumptions about its casing and both variants are correct. We have picked one, which admittedly is the less popular one. However, we aren't going to cause a stir by changing it


Quick fix for readme file bages

Is this enhancement or feature is related to a problem?
Fork and star badge styles don't match with other badges.

Describe the solution you'd like
It turns out I need to add "?style=flat" at the end of the URL.
old:
new:
old:
new:
Describe alternatives you've considered
No response
Additional context
No response

After the changes, it is fixed.


Cannot find a way to use redirect_uri param

This change suggests that it is possible to customize the redirect_uri by passing a param[:redirect_uri] at some point in the flow:
https://github.com/m0n9oose/omniauth_openid_connect/commit/5ce3b551d78ec781559f2fe5bb731c892cf42370#diff-8467ba16957a2513a82eb9fe781131df
I have tried adding this param alongwith with the initial redirect to /auth/openid_connect, for example:
http://tenant1.localhost:5000/users/auth/openid_connect?redirect_uri=tenant1.localhost
However, this results in 2 redirect_uri parameters being sent in the redirect to the auth service, the URI in the query string above, plus the URI specified in config.
The end goal is to support multi-tenant sub-domains, using a single auth endpoint.
Given the commit above, should it be possible to specify a request_uri at request time rather than in fixed config?

I agree with @dznicol. We should be able, at least, to set the client_options.redirect_uri as a proc in order to add parameters on the fly to the url or things like that.
I also think that any parameter given to the request url should be added to the fixed callback url (ex. https://host.com/path?param1=value1&param2=value2 as request url should give https://host.com/path/callback?param1=value1&param2=value2 as callback url)

+1 for this feature (if it's supported by the openid connect protocol)

@dznicol the extra query parameters you give to omniauth in the initial request will come back to you as part of the state token. I called mine "landing_url" to avoid the name collision with the oauth redirect url, and I can access it at the callback endpoint via request.env['omniauth.params']['landing_url']

Using information held in the state token to control which page the user lands on should work most of the time.
That said, it would still be pretty nice to be able to define the redirect url dynamically. In my case I have a central domain handling the oauth, after which I have to send the user to a different subdomain matching their account, and my cookies are subdomain specific, so another internal auth mechanism is needed for the subdomain redirect. With dynamic redirect uri support  in this gem (and if I can convince my provider to implement a wildcard whitelist on their side) I could have the user's subdomain manage the entire process.
One thing I thought of is iterating over all my subdomains on boot, registering a provider for each, but that seems pretty clunky.

@makeready have you ever found a way to do that? thank you

any updates on this issue?
I'd like to use dynamic callbacks uris as well, if possible.


fix: graphql-yoga updates

update all deps. 🚀
update .gitignore file 🐞
avoid generating package-lock.json ☔
use yarn.lock onlly on dev 🐙
update LICENSE 👋🏻
README.md file

fix grammar (line 13) @kumarharsh ✔
fix HttpsOption ref (line 129) @riginoommen ✔
fix Server name (line 172) @terry-ice ✔
fix Spelling Error (line 169) @MichaelNey ✔
fix Now Deploy (line 209/ line 217) @nicholasRutherford ✔

Examples dir

fix middleware example (index->line 57) @kamry-bowman @anthoniuso ✔
fix modular-resolvers example (line 2 / line 13) @gtosto @IgorChiriac ✔

fix Deploy to Now v2 by this PR #538 @lucasavila00 ✔
Solve new Node.js versions pb @sajjad-shirazy ✔

AFAIK This project is in maintenance mode.
Please see this new project https://github.com/prisma-labs/graphql-santa

Close this right now, if you are interested leave a comment 👀 ......


Yarn 1424

RMAppAttemptImpl should return the DummyApplicationResourceUsageReport for all invalid accesses
https://issues.apache.org/jira/browse/YARN-1424

Can one of the admins verify this patch?


Warns when type of reducers passed is invalid to avoid silent failure

Attempts to solve issue #1398 .
Undefined reducers are still checked for intuitive debugging.
Warnings are now given to the console if a passed reducer is not a function.
Warnings are also given to the console if a whole es module imported via the * syntax is passed to combineReducers.

(Maintainers: sorry for the impromptu review; @jekku is a colleague of mine who's asked his coworkers to review his contribution.)

Whoops, got a little cocky with those test updates. Serves me right for trying to use the web interface to edit 😄  Feel free to revert that!

One thing to note: We tried this on bindActionCreators and had to revert there as well: #2279
Unfortunately, with most people transpiling modules through Babel, there are side effects when the pattern of import * as reducers from './reducers' is used. Unless we can somehow be rock solid in protecting against this without hacks, I'm not sure this is going to be mergeable.

@timdorr would throwing out an exception when an import * is invoked to combineReducers, help?

@jekku Sorry for not responding. At least currently, there isn't a rock-solid, cross-platform way of doing that. You can check for __esModule, but that may not come across depending on how folks have their transpilation set up.
Unfortunately, fixing for this kind of issue isn't going to be possible in the current ecosystem. I had to revert a similar warning in a previous release because it caused other sorts of headaches like this.
Unless someone can think up a novel way to resolve it that covers both native and loosely transpiled environments, I'm not sure there's a solution.


RemoteCameraPairingHelper sample throws exception when new camera is plugged in

The RemoteCameraPairingHelper class in the sample code on this page throws an unhandled exception when a new camera device is plugged in after the initial enumeration is complete.
The exception is thrown in the call to MediaFrameSourceGroup.FromIdAsync(). The exception is The system cannot find the file specified. (Exception from HRESULT: 0x80070002).
This appears to be due to a race condition. If I set a breakpoint on the FromIdAsync() call and then step over it the call succeeds. In fact, if I do something gross like let the first call fail but catch the exception and then try the call again it succeeds on the second call.
It seems like you can't call MediaFrameSourceGroup.FromIdAsync() too soon after the DeviceWatcher raises the Added event (after the initial enumeration is complete) or you'll hit this apparent race condition.
I'm running Windows 10 Pro 1903 build 18362.295 and compiling a test UWP app in C# with Visual Studio 2017 build 15.9.15 and targeting Windows SDK 18382.
(Edit: I also filed a bug against the relevant Windows Universal sample here.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0acb2900-f433-7899-c86a-a2cd8aba2143
Version Independent ID: 55138f0b-e0a4-a4aa-437e-f693b2e70e3b
Content: Connect to remote cameras - Windows UWP applications
Content Source: windows-apps-src/audio-video-camera/connect-to-remote-cameras.md
Product: uwp
Technology: audio-video-and-camera
GitHub Login: @drewbatgit
Microsoft Alias: drewbat

Thanks for taking the time to let us know about this and we sincerely apologize for the delayed response. This was a known bug and the feature team has implemented a solution in newer OS versions. For earlier versions, the recommended workaround is retrying:
private async Task AddDeviceAsync(string id)
{
    for(int i = 0; i < 5; i++)
    {
        try
        {
            var group = await MediaFrameSourceGroup.FromIdAsync(id);
        }
        catch(Exception ex) when (ex.HResult == 0x80070002)
        {
            Thread.Sleep(20000);
        }
    }
    if (group != null)
    {
        await _dispatcher.RunAsync(CoreDispatcherPriority.Normal, () =>
        {
            _remoteCameraCollection.Add(group);
        });
    }
}


Update CHANGELOG and VERSION for v0.5.0 release

Set VERSION to v0.5.0
Update CHANGELOG for 0.5.0 release

/theia-test-e2e


[fix][admin] Fix NPE when get OffloadThreshold on namespace.

Fixes #18023
Motivation
If the namespace policy inits without setting managedLedgerOffloadThresholdInBytes, it will cause NPE when get OffloadThreshold.
Documentation

[x] doc-not-needed

Matching PR in forked repository
PR in forked repository: https://github.com/Technoboy-/pulsar/pull/12

Codecov Report

Merging #18061 (4829ab9) into master (6c65ca0) will decrease coverage by 8.89%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             master   #18061      +/-   ##
============================================
- Coverage     34.91%   26.02%   -8.90%
+ Complexity     5707     3390    -2317
============================================
  Files           607      393     -214
  Lines         53396    43423    -9973
  Branches       5712     4463    -1249
============================================
- Hits          18644    11299    -7345
+ Misses        32119    30361    -1758
+ Partials       2633     1763     -870

Flag
Coverage Δ

unittests
26.02% <14.28%> (-8.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pulsar/broker/admin/v2/Namespaces.java
4.77% <0.00%> (-3.26%)
:arrow_down:

...broker/delayed/InMemoryDelayedDeliveryTracker.java
0.00% <0.00%> (ø)

...rg/apache/pulsar/broker/service/BrokerService.java
44.20% <0.00%> (-3.81%)
:arrow_down:

.../service/SystemTopicBasedTopicPoliciesService.java
47.46% <0.00%> (-4.13%)
:arrow_down:

...g/apache/pulsar/compaction/CompactedTopicImpl.java
10.71% <0.00%> (ø)

...apache/pulsar/proxy/server/DirectProxyHandler.java
63.63% <50.00%> (ø)

...pulsar/broker/admin/impl/PersistentTopicsBase.java
9.12% <100.00%> (-2.28%)
:arrow_down:

.../transaction/pendingack/PendingAckHandleStats.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...naming/RangeEquallyDivideBundleSplitAlgorithm.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...on/buffer/impl/TopicTransactionBufferProvider.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 324 more


Allow for setting pool on stages

Since it's not possible to use conditions on templates or use conditional inserts on queue time variables we have to resort to splitting a job up into multiple jobs, each with the appropriate condition set. This leads to a lot of repetition as you have to specify the pool on each of the jobs.
It would be a nice quality of life if you could set the pool on the stage, or even better: on the entire pipeline, allowing for override on a per-stage or job basis.

It would be a nice quality of life if you could set the pool on the stage, or even better: on the entire pipeline, allowing for override on a per-stage or job basis.

You can set the pool at pipeline, stage and job level if you need to.
Here's a valid YAML pipeline:
trigger:
- master

pool:
  vmImage: 'windows-latest'

stages:
- stage: FirstStage
  jobs:
  - job: FromWindows
    steps:
    - script: echo "hello from Windows (pool not specified, inherited from pipeline)!"

  - job: FromLinux
    pool:
      vmImage: 'ubuntu-18.04'
    steps:
    - script: echo "hello from Ubuntu (pool specified at job level)!"

- stage: SecondStage
  pool:
    vmImage: 'macOS-10.13'
  jobs:
  - job: FromMacOS
    steps:
    - script: echo "hello from macOS (pool not specified, inherited from stage)!"

Right after the definition of the triggers and before setting stages, I've set the pool default image for the entire pipeline. This means that every job that will get executed will run on that default image (see the Windows case in FromWindows job) if pool aren't specified at other levels.
When you have to change and specify a different agent, you can change the pool at job or stage level to better refine your pipeline (see FromLinux and FromMacOS examples).
You can read more about pools here and specifically for stages here.

Oh neat! Thanks!


Refactor: SNR & SI_SNR

What does this PR do?
Unify the notation and keep more descriptive functional names
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

And, SNR: signal to noise ratio, not signal noise ratio
same to SDR: signal to distortion ratio

@PyTorchLightning/core-metrics updated and keeping abbreviations, pls check it now :rabbit:

@Borda Maybe we can consider to put sisdr and sisnr in one file, because they have very limited difference (or to say sisnr is a special alias for sisdr)

@Borda Maybe we can consider to put sisdr and sisnr in one file, because they have very limited difference (or to say sisnr is a special alias for sisdr)

I put sisnr in snr as it seems to be related, right?

waiting on #711

@Borda Maybe we can consider to put sisdr and sisnr in one file, because they have very limited difference (or to say sisnr is a special alias for sisdr)

I put sisnr in snr as it seems to be related, right?

Yes, sisnr and snr sounds more related. I'm wondering which is better: 1 put sisnr and snr together; 2 put sisnr and sisdr together; 3 put sisnr, sisdr, snr separately as before

@Borda Maybe we can consider to put sisdr and sisnr in one file, because they have very limited difference (or to say sisnr is a special alias for sisdr)

I put sisnr in snr as it seems to be related, right?

Yes, sisnr and snr sounds more related. I'm wondering which is better: 1 put sisnr and snr together; 2 put sisnr and sisdr together; 3 put sisnr, sisdr, snr separately as before

I would go with 2


Simplify runlist creation

Hi @leeyap
#38 is a great start! 🎉
I do think that the runlist-creation step can be made much simpler and (to my eyes anyway) clearer. See what you think.

Programming-wise, three key changes to understand (whether or not you want to adopt):

In line 16 of trackingC_common, using parallelism to generate SSP_files
In line 176 of trackingC_setup, using mapply to generate a vector of scenario names. This allows...
Generating just one runlist just once


Executability being overwritten

Just like Issue #2, properties should never be overwritten.
It appears that Executability is being overwritten with Partially Executable in many cases.
Instead,

Executability should only be added if it doesn't already exist as a property on the rule.
Executability should be set to Fully Executable (if it doesn't already exist as a property on the rule).

This has been fixed in v0.4.1


WebSurfer add close method

adds a close method to the websurfer to remove the websurfer instance
updates documentation
fix small issue with websurfer test

TODO:

fix websurfer in AGS

Fixes:
#4699

@victordibia might be a good idea to add the relevant close code for AGS in this PR for testing

@husseinmozannar , thanks.
Added. TeamManager will now run the .close() method of any agent if that exists in participants.
The runtime should do this at some point.


Implement table model, needed for new form inputs

Provide means to access a user's tables, and their schema (columns, types etc.)
Will be used for #6508
My initial idea is to port the minimal things necessary from old models, i.e.:
// setup root model in entry file (e.g. user)
var user = new User({…})
var tables = user.tablesCollection // => Backbone.Collection
var columns = tables.columnsCollection // => Backbone.Collection
console.log(columns.chain().pluck('name')) // => ['id', 'cartodb_id', 'homes', 'some_text', …]

cc @xavijam @javierarce makes sense? something missing that you need?

TODOs

[ ] implement User model (the root model that owns a tables collection)
[ ] implement Table model + collection
[ ] implement Column model + collection

Yep, I feel those are the minimal things we need to keep up with the widgets form :).


no flush() on PipedGzipWriter

It looks like the file-like object returned by xopen() for Gzip compressed files misses the flush() method.
AttributeError: 'PipedGzipWriter' object has no attribute 'flush'
This would be very helpful to have, as well as easy to implement, as gzip.open's file-like object supports the flush() operation.

It’s actually not that easy. xopen doesn’t use gzip.open if it can avoid it, but runs an external gzip or pigz process to get better speed. I would need a way to tell the running gzip/pigz to flush its currently processed block(s) to disk.
The only method I can think of would be to close the output file (which will flush everything implicitly) and then to re-open it in append mode. This would work since gzip files are allowed to be concatenated, but the problem is that the resulting file will not be the same as when flush() had not been called.
At the moment, I tend to just leave it as it is. I’d accept a PR, but then probably the method would need to be called reopen() instead of flush(). I’m open for discussion, though.

Thanks for the context, I wasn't aware of the details behind, and just (blindly) assumed the gzip core Python stuff was at work in the background, and xopen was just abstracting its usage.
It's obvious the files won't be the same, as compression is in the mix, and (smaller) increments won't nearly compress as well as larger batches. Own experience in the past has shown that an decompress/compress cycle on such files has yielded a significant improvement.
For my current use case I need the option to flush, but as file i/o is not the bottle neck, I won't need the benefit of the faster pigz process, so I'll go with the vanilla gzip module for me/now (the benefit over an uncompressed file output is still large enough to walk this path).
I agree under these circumstances reopen() will probably be a better label, though indicating that this may act as a flush() workaround in the documentation. As I have no (immediate) need for it (but only limited time available) I won't be able to provide a PR for this, though. Sorry ... :-(
BTW, nonetheless many thanks for providing this module in the first place. I've learned to like and use it more and more.

Thanks a lot for taking the time to write a detailed reply! I appreciate a lot learning which use cases exist.
I think one other option is to allow to specify that xopen should not use a pipe to an external program. I think this would be good to have anyway. The code already exists (as a fallback when gzip isn’t available), it would just need to be exposed. Let’s leave this issue open until someone finds the time to implement it.

I think one other option is to allow to specify that xopen should not use a pipe to an external program. I think this would be good to have anyway.

As far as I know we have solved this issue. Using threads=0 will always open in the main thread with open, gzip.open, lzma.open etc.
Furthermore the threaded option included in #131 does also allow the flush method. So eventually it will also become available for gzip threads.

Currently flush does nothing: https://github.com/pycompression/xopen/blob/d98ee235f15d33f0291fafc042b27f7b616e22b7/src/xopen/init.py#L398
What can be done for writing is that the EOF is given to the program. It will then terminate the compression block. The file can be opened again in append mode and then the writing can resume. This only works for things that support concatenated blocks though, such as gzip. I think xz, zst and bzip2 also support those? But that would need more investigation.

xz, zst and bzip2 also support mutiple compressed members in one file.


Bring Travis and AppVeyor configurations in sync with the GLib one

👍 after CI passed

Oh silly :) Fixing

👍

@GuillaumeGomez all green :)

Thanks!


Not surviving HASS restart.

Install, works great, right prices etc.
Restart results in error below
Sensor never does connect again.
Delete and reinstall, works great again.

2022-02-06 12:45:23 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry ENWIN Utilities Ltd. (RESIDENTIAL) for ontario_energy_board
Traceback (most recent call last):
  File "/config/custom_components/ontario_energy_board/api.py", line 67, in get_rates
    response = await self.websession.get(RATES_URL)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 535, in _request
    conn = await self._connector.connect(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 542, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 907, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 1154, in _create_direct_connection
    hosts = await asyncio.shield(host_resolved)
asyncio.exceptions.CancelledError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 327, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/ontario_energy_board/__init__.py", line 31, in async_setup_entry
    await ontario_energy_board.get_rates()
  File "/config/custom_components/ontario_energy_board/api.py", line 67, in get_rates
    response = await self.websession.get(RATES_URL)
  File "/usr/local/lib/python3.9/site-packages/async_timeout/__init__.py", line 129, in __aexit__
    self._do_exit(exc_type)
  File "/usr/local/lib/python3.9/site-packages/async_timeout/__init__.py", line 212, in _do_exit
    raise asyncio.TimeoutError

This issue is now solved with v0.2


When can we get HICO-DET code？

When can we get HICO-DET code？ @bobwan1995 @desenzhou

Thanx for ur great job. @bobwan1995
I'm going to cite ur work into my paper.
But befort that, I have to make more ablation results on HICO with ur project.
Could u please uadate the related HICO code and pre-trained models?
If u are too busy to update the code in github, could u please just send me<EMAIL_ADDRESS>a link (e.g., google/baidu drive link) of the HICO code and pre-trained models?
Thanx!

Thanx for ur great job. @bobwan1995
I'm going to cite ur work into my paper.
But befort that, I have to make more ablation results on HICO with ur project.
Could u please uadate the related HICO code and pre-trained models?
If u are too busy to update the code in github, could u please just send me<EMAIL_ADDRESS>a link (e.g., google/baidu drive link) of the HICO code and pre-trained models?
Thanx!

Did you get the code? @BestSongEver
If you got the HICO-DET code, can you share a link to me (872534243@qq.com)?
Thank you！

I did not.
Still waiting for reply. @suzhan-123 @bobwan1995 @desenzhou

I didn't get it either

Sorry, I'm so busy these days (going to take a Ph.D. study abroad). I will make it available as soon as possible.

Any news on this?


Setup Firebase sites

Firebase
Ready to setup the Firebase infrastructure. Thinking something as follows:

PRs are created and a Firebase preview site is created for the PR. Here we use the same site naming conventions as in the past.
PR is merged to main, this triggers a stage Firebase site update to stage-api3-docs.web.app.
A PR is created to merge main to live-site, this triggers a production Firebase site update to api3-docs.web.app.

Site names

PR previews: Same as api3-docs is using
Stage: stage-api3-docs.web.app.  This name is nice because when typing stage first (into the browser) URL bar, you will most like get the stage site as the first recommendation.
Production: api3-docs.web.app, cause it makes sense.

Notes & Concerns

There may be code in Firebase files from api3-docs that I have not moved over into vitepress-docs.
What Firebase project will this go into?
Can more than one person have access to the Firebase project?

Moving to done as we've been using the deployments successfully. @wkande feel free to reopen if you feel otherwise.


Avoid FieldVector outer constructor inference

I realized that most of the allocations in the callbacks are actually coming from inference in the FieldVector outer constructor:

This PR should (hopefully) avoid this, by calling the outer constructor where the undertype is pre-specified.

Also, I plan to update the flame allocation tests once we get numbers from CI.

Allocations in the callbacks flame in this PR:

should we just @nospecialize the constructor?

should we just @nospecialize the constructor?

Will that help? I think it's the recursive promote_type (T = promote_type(map(RecursiveArrayTools.recursive_bottom_eltype, values)...,)) that's type unstable. I think it's okay so long we avoid it in hot loops 🤷🏻

I realized that most of the allocations in the callbacks are actually coming from inference in the FieldVector outer constructor:

Correction: most of the allocations in the callbacks that Profile.allocs sees (see https://github.com/JuliaLang/julia/issues/50187)

bors r+

bors r+


Make session for TelegramDesktop from tgback

It's good idea to add function for creating tdata folder (~/.local/share/TelegramDesktop/tdata) from tgback backups. I don't have enough time to do this, so if you interested and have any examples for transfering telethon's .session into tdata - share it. I will be very thankful.

Added in tgback v3.1


mongodb reactive

I personally kind of like that they are separate to explain best practise for each

I prefer them to be separate. Shorter guides for the win.


fix(lnd): ensure graceful shutdown

Lnd doesn't currently do a graceful shutdown when a SIGTERM is issued. To ensure a graceful shutdown, call stopDaemon on the gRPC interface prior to terminating lnd.
See

https://github.com/lightningnetwork/lnd/issues/1028
https://api.lightning.community/#stopdaemon

Pull Request Test Coverage Report for Build 3833

0 of 16 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 13.32%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/lib/lnd/lightning.js
0
6
0.0%

app/lib/zap/controller.js
0
10
0.0%

Totals

Change from base Build 3822:
-0.04%

Covered Lines:
512

Relevant Lines:
3358

💛  - Coveralls


Adding search by criteria and order by

Addressing #14. This pull request implements two features that are needed for our devon4ng client:

Implements order by: Now it is possible to order your data by any property (asc or desc).
Implements search by criteria: Now it is possible to retrieve a list of items that match a search.

Hi @jdiazgon,
Although this is a different topic, could you please remove in this PR the asciidoc files from root folder as they are already in the .github folder? I mean the contributing guide, templates, etc.
Thanks!

Hello @jdiazgon,
IMHO the approach using the query instead the body is the correct. The problem is that your solution only works for typeorm. I think that our solution should work with other ORM (e.g. mongoose).
Anyway, if you need to continue with your work before we discussed it, you can use this approach or the approach that I mentioned in the issue, as you want.
Kind regards

And I miss something important: the todo-app is an old example that will be updated (probably removed) soon.

Corrected in devon4node 1.0.0. This PR is not needed


Bad link for 4.x example

The link to the 4.x example is broken in the README.md:

We are working on version 4!!...Take a look to this example and give the version 4.0.7.alpha a try

It looks like it should be linking to:

https://github.com/cloudyrock/mongock-integration-tests/tree/master/mongock-4/mongock-spring-v5/mongock-spring5-springdata3-it

but it is actually linking to:

https://github.com/cloudyrock/mongock-integration-tests/tree/master/mongock-spring-v5/mongock-spring5-springdata3-it

thanks. We'll be updating the entire README with the new documentation, but meanwhile it's there, it should be right.
We'll make it right, thanks


AssertionFailed message when hover over red underline in editor

I get a red underline in the last line of this TypeScript. When I hover over it to see what the error is in my code, it pops up a tooltip with the text 'AssertionFailed' in it. I suspect your compiler is crashing?
How do I find out what the actual error is in my code, rather than the error that your compiler seems to be getting?? More to the point, if an assertion has failed, how would I find out what the assertion is that has failed so I can give you a more meaningful bug report?!
As a wider question, despite your editor syntax highlighting the word 'map' I can't find a map class in the language implementation for the micro:bit anywhere and no reference to it in the docs. Am I missing something? This is sort of why I was writing this 'dumb' map implementation so I can port my large Python program into TypeScript on the micro:bit (as Python is running out of memory with my script so I thought I would try TypeScript instead).
However I note that looking at some of your micro:bit TypeScript modules, you use a function that has a case statement in it to effectively implement a map. I can't do that in this case, as I want my initial static structure to be extensible, so it needs to be a dynamic data structure.
class MyMap<K, V> {

    keys: K[]
    values: V[]

    constructor() {
    }

    push(key: K, value: V) {
        this.keys.push(key)
        this.values.push(value)
    }

    search_array(a: Object[], item: Object): number {
        for (let i = 0; i < a.length; i++) {
            if (a[i] == item) {
                return i
            }
        }
        return -1 // NOT FOUND
    }

    value_for(key: K): V {
        let i = this.search_array(this.keys, key)
        if (i == -1) {
            return null
        }
        return this.values[i]
    }

    key_for(value: V): K {
        let i = this.search_array(this.values, value)
        if (i == -1) {
            return null
        }
        return this.keys[i]
    }

    set(key: K, value: V): void {
        let i = this.search_array(this.keys, key)
        if (i == -1) {
            this.keys.push(key)
            this.values.push(value)
        } else {
            this.values[i] = value
        }
    }

    has_key(key: K): boolean {
        return this.search_array(this.keys, key) != -1
    }

    has_value(value: V): boolean {
        return this.search_array(this.values, value) != -1
    }
}

let z: MyMap<number, string> = new MyMap<number, string>()

I'm reading the docs here, but it's not clear if this is for the version of TypeScript that is baked into PXT for the micro:bit or not, as that URL doesn't seem to have any versioning information in it, so it could be for any arbitrary version of TypeScript (probably the latest, but that's not obvious)
https://www.typescriptlang.org/docs/handbook/generics.html
How would I get access to the specific version of TypeScript docs for the version of TypeScript that is baked into the micro:bit PXT build? The pxt docs are not complete in this respect, and in some places in the docs (already reported in another ticket), the docs link out to generic TypeScript docs rather than the docs all being in one place.
Just as a friendly observation: If I'm struggling, I think our target audience will struggle even more, without a definitive set of documentation for the language they are learning. I'm happy to be part of the process that fixes that problem, but I need to know the baseline of where you are starting from to be able to help you in this process.
Thanks

@DavidWhaleMEF - thanks for the observation. We indeed need to bring our docs up-to-date.

We do have an internal failure that I will need to debug further.  Here is an improved version of the code, still showing the bug
function search_array<T>(a: T[], item: T): number {
    for (let i = 0; i < a.length; i++) {
        if (a[i] == item) {
            return i
        }
    }
    return -1 // NOT FOUND
}

class MyMap<K, V> {

    keys: K[]
    values: V[]

    constructor() {
    }

    push(key: K, value: V) {
        this.keys.push(key)
        this.values.push(value)
    }

    value_for(key: K): V {
        let i = search_array(this.keys, key)
        if (i == -1) {
            return null
        }
        return this.values[i]
    }

    key_for(value: V): K {
        let i = search_array(this.values, value)
        if (i == -1) {
            return null
        }
        return this.keys[i]
    }

    set(key: K, value: V): void {
        let i = search_array(this.keys, key)
        if (i == -1) {
            this.keys.push(key)
            this.values.push(value)
        } else {
            this.values[i] = value
        }
    }

    has_key(key: K): boolean {
        return search_array(this.keys, key) != -1
    }

    has_value(value: V): boolean {
        return search_array(this.values, value) != -1
    }

}

let z = new MyMap<number,string>()

Fixed. Should be in beta tomorrow. Please see https://pxt.microbit.org/_PwraKdfWqg6t for debugged program.


Unable to load product and collection in vercel commerce.

I'm trying to integrate Shopify with the next commerce and add everything which is required for the env file but still unable to load data inside the pages.
Followed the documentation of vercel with Shopify still haven't found any solution yet.

Is there any error occurring or not?

I'm not facing any error still unable to load a collection and product

The reason behind is that you probably have entered incorrect name of collection or products
Can you please share ss of shopify collections?

I have 3 collection

Follow the documentation of vercel integration shopify https://vercel.com/docs/integrations/shopify#

The same here.
I received some logs:
No collection found for `hidden-homepage-featured-items`
No collection found for `hidden-homepage-carousel`

Did you guys have created web hooks for the collections?
And the most important thing is that you can see the collection by clicking on the view button inside the collection. There is a bug in the vercel. integration for the carousel collection. It is not creating with the same name.Instead for the carousel collection it is creating with 'frontpage' name.
For the featured collection, it is completely fine, if you have created the web hooks..

[nexusprime-here] I also struggled a little bit but after adding third item into featured items the widget finally appeared

The homepage featured items requires currently at least 3 items to render, not a great design overall but that's how it works. If you add more items, put them into the channel for headless, and add the items to the collection hidden-homepage-featured-items it should show up for you.

The same here.
I received some logs:
No collection found for `hidden-homepage-featured-items`
No collection found for `hidden-homepage-carousel`

resolved in: https://github.com/vercel/commerce/issues/1207

do all the functions need to be edited the same way?

^ This is resolved per https://github.com/vercel/commerce/issues/1205#issuecomment-1751818893


feat: exporting store along with reducer.

closes #9

Codecov Report

Merging #13 (4437e29) into main (d5434d7) will increase coverage by 0.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   95.23%   96.15%   +0.91%
==========================================
  Files           4        5       +1
  Lines          21       26       +5
  Branches        1        1
==========================================
+ Hits           20       25       +5
  Misses          1        1

Impacted Files
Coverage Δ

lib/services/pokemon/model.ts
100.00% <100.00%> (ø)

lib/utils.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5434d7...4437e29. Read the comment docs.


This is my ideal for combine redux form and react datepicker

i have problem combine redux form and datepicker range i found some example but they code large and i can't follow , I think this is solution so simple but i'm not sure wrong or right.

  import React from 'react';
import DatePicker from 'react-datepicker';
import moment from 'moment';
import 'react-datepicker/dist/react-datepicker.css';
import { Field, reduxForm , change } from 'redux-form';
import { connect } from 'react-redux';
class RangeState extends React.Component {
  constructor (props) {
    super(props)
    this.state = {
      startDate: moment(),
      endDate: moment()
    }
  }

  handleChange = ({ startDate, endDate }) => {
    startDate = startDate || this.state.startDate
    endDate = endDate || this.state.endDate
    if (startDate.isAfter(endDate)) {
      var temp = startDate
      startDate = endDate
      endDate = temp
    }

    this.setState({
      startDate,
      endDate
    },function functionName() {
      this.props.dispatch(change('simple', 'start', this.state.startDate.format("YYYY/MM/DD")));
      this.props.dispatch(change('simple', 'end', this.state.endDate.format("YYYY/MM/DD")));
    })

  }

  handleChangeStart = (startDate) => this.handleChange({ startDate })

  handleChangeEnd = (endDate) => this.handleChange({ endDate })
  render () {
    return

  }
}
const form = reduxForm({
  form: 'simple' // a unique identifier for this form
})(RangeState)

export default connect()(form);

I follow example libary and add some code :

I connect redux for dispatch
I callback function Setstate and set value for feild redux form ( and use class Hide boostrap hide this feild ).

who have bester solution please comment...

I think you've over-complicated it.  Let Redux Form handle the datepicker's state using its onChange method.
My datepicker field component looks something like this:
const ReduxFormDateRange = (props) => {
    return (
        <DatePicker
            selected={props.input.value || null}
            onChange={props.input.onChange}
        />
    )
}

where props.input are just the regular input props that Redux Form passes in via the Field component.  If you really need a hook into the onChange method, you could set up a function inside of this component that calls the input.onChange indirectly.

selected={props.input.value || null} onChange={props.input.onChange}

does not work with time(showTimeSelect). After selecting the date and time, the input only shows the date. Any solutions? Thanks

If I'm following the question, you need to include the dateFormat and timeFormat props.  I pass in a prop (boolean) via the <Field> component called showTimeSelect and use it like this (simplified for the example) in the Redux Form Date Range component:
const ReduxFormDateRange = (props) => {
    return (
        <DatePicker
            selected={props.input.value || null}
            onChange={props.input.onChange}
            showTimeSelect={props.showTimeSelect}
            dateFormat={props.showTimeSelect ? 'lll' : 'll'}
            timeFormat={props.showTimeSelect ? 'HH:mm' : ''}
        />
    )
}

For those still trying to figure out how to get Redux Form and ReactDatepicker to work well together try considering the change prop in Redux form passed to onChange from ReactDatepicker.
In the example below I do this to ensure startDate and endDate on my form are never more than 30-days apart:
`const StartDatePicker = ({
input: { onChange, value }, endDate, change,
}: PropsWithEndDate) => (
<ReactDatePicker
onChange={(startDateValue) => {
onChange(startDateValue);
  if (endDate.diff(startDateValue, 'days') > 60) {
    change('endDate', moment(startDateValue).add(60, 'd'));
  }
}}
dateForm="MM/DD/YYYY"
selectsStart
selected={value}
startDate={value}
endDate={endDate}
minDate={moment.utc().subtract(65, 'day')}
maxDate={moment.min(endDate, moment.utc())}
monthsShown={2}

/>
);`
Here's the link: https://redux-form.com/8.0.4/docs/api/props.md/#-code-change-field-string-value-any-function-code-
Hope this helps someone!


depth format

hi, how can I obtain the depth in 16-bit PNG format,depth in millimeters??

The depth network outputs floating point values. You can save them in whichever format you want as long as your image library supports it.


test(lazy): Update this lazy component unit test.

Checklist

[ ] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Change information
close #621

Codecov Report

Merging #622 (580aced) into dev (7e871ef) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #622      +/-   ##
==========================================
- Coverage   95.63%   95.41%   -0.23%
==========================================
  Files         217      217
  Lines        5245     5252       +7
  Branches      982      982
==========================================
- Hits         5016     5011       -5
- Misses        220      232      +12
  Partials        9        9

Impacted Files
Coverage Δ

packages/varlet-ui/src/lazy/index.ts
88.78% <0.00%> (-6.55%)
:arrow_down:

packages/varlet-ui/src/input/Input.vue
95.45% <0.00%> (-4.55%)
:arrow_down:

packages/varlet-ui/src/countdown/Countdown.vue
95.94% <0.00%> (-1.36%)
:arrow_down:

packages/varlet-ui/src/select/Select.vue
96.81% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e871ef...580aced. Read the comment docs.


Added library to wasm-bindgen-cli

This may come off as an odd PR but would be something very beneficial to bazelbuild/rules_rust::wasm_bindgen which are tools which use wasm-bindgen in the Bazel build system. The functionality currently tries to recompile of the wasm-bindgen-cli crate but in order to achieve this, a ton of complexity was added to solve for issues where binary-only crates do not show up in cargo metadata outputs (https://github.com/google/cargo-raze/issues/218 has some good details on this issue). To avoid needing to maintain this complicated behavior, it would be very helpful to have wasm-bindgen-cli also contain a library target, which would allow it to appear in cargo metadata output. My hope is that this change has no noticeable impact to existing Cargo users but would be very helpful to Bazel users.

Thanks for the PR, but I don't really understand the crate layout here so while this may work for Bazel it's a bit weird enough that at least for me I'd prefer to not maintain it. I don't understand the limitations of Bazel related to Cargo or the various other bits of tooling involved.

Thanks for the PR, but I don't really understand the crate layout here so while this may work for Bazel it's a bit weird enough that at least for me I'd prefer to not maintain it. I don't understand the limitations of Bazel related to Cargo or the various other bits of tooling involved.

The only meaningful difference is that Bazel cannot consume binary-only crates. The functionality added to lib.rs doesn't need to be added but it'd help a lot if there was a library associated with the cli crate to make it accessible. Perhaps an empty lib.rs file could be added at the very least?

Sorry but "cannot consume binary-only crates" isn't really a description which would lead me naturally to a PR like this. I don't understand the consequences of Bazel's decision here and what that means for this crate. I'd rather not have a crate-specific workaround for what seems like a deficiency in Bazel's Rust integration.

Also worth noting that including this crate as binary could lead to all sorts of confusing version conflicts. It'll be very hard to keep the versions of wasm-bindgen and wasm-bindgen-cli in sync

Thanks for taking a look!


Bot not starting in windows

$ python pokecli.py
Traceback (most recent call last):
File "pokecli.py", line 38, in
from pgoapi.exceptions import NotLoggedInException, ServerSideRequestThrottlingException, ServerBusyOrOfflineException
File "d:\hacking\bot\pokemongo-bot\src\pgoapi\pgoapi_init_.py", line 50, in
from pgoapi.pgoapi import PGoApi
File "d:\hacking\bot\pokemongo-bot\src\pgoapi\pgoapi\pgoapi.py", line 34, in
from pgoapi.rpc_api import RpcApi
File "d:\hacking\bot\pokemongo-bot\src\pgoapi\pgoapi\rpc_api.py", line 47, in
from pgoapi.utilities import to_camel_case, get_time, get_format_time_diff, Rand48, long_to_bytes, generateLocation1, generateLocation2, generateRequestHash, f2i
File "d:\hacking\bot\pokemongo-bot\src\pgoapi\pgoapi\utilities.py", line 30, in
import xxhash
ImportError: No module named xxhash
Getting this error after running start command for bot.
Please help.

This is an issue tracker for bugs, not for help.
Please see the WIKI or join the slack chat for help.

Install this
https://download.microsoft.com/download/7/9/6/796EF2E4-801B-4FC4-AB28-B59FBF6D907B/VCForPython27.msi

@agastimhatre than it wil work ?


⚠ Bofrost.at has degraded performance

In 5dcba28, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1601 ms

Resolved: Bofrost.at performance has improved in 344675a.


aws_smithy_http_server::* should be re-exported from generated crates

Many customers have reported the need to explicitly depend on the aws-smithy-http-server crate in their service handler code. When they re-generate the crate, they often encounter version mismatches between the aws-smithy-http-server crate used in the generated code and the one they use in their service handler. This version discrepancy leads to compilation errors, requiring them to manually adjust the crate versions, which adds friction to their development workflow.
To resolve this issue, we now re-export all relevant types from aws-smithy-http-server within the generated crates. By doing so, customers can use these re-exported types directly, eliminating the need to depend on aws-smithy-http-server in their handler code.

We should announce this in the changelog.


Implement block nesting functionality: Columns block

Hi!
I've prepared columns/nested blocks functionality for pull request:

cleaned code and cherry-picked only necessary changes
created needed svg icons instead of png sprite for columns icons
used icomoon to handle icons font

Here's the demo: http://demo.e1stuff.com/sir-trevor/

Any update on this feature?

Hi everyone!
Here's the new pull-request with core patch only. That will allow linking columns block as a plugin.
https://github.com/madebymany/sir-trevor-js/pull/297

Closing this because #297 was closed. Sorry people.

👎🏼


Gravity direction changes

This is based on how I intended to implement #3161, but as it's only part of that and has other uses, and other ways of doing that were discussed, it seems worth having a separate issue.
It would be interesting to have the direction of gravity change at different locations in the world. This would cause blocks to be rotated (e.g. plants could be supported by the block adjacent in the +x direction if that's locally down, and the rendering would be rotated), change physics and rotate always-upright mobile entities, like players. Use cases include:

Other world shapes, such as cubes or asteroid fields
Cavorite
I think someone mentioned a paper-mario themed mod as a possibility, although I've never actually played that so I don't know about it.

Architecturally, I am imagining this as a new interface, GravityManager or WorldRotationManager or something, which can be queried to return a rotation at any block-location, which is then applied whenever block rotation matters. If there are already block families, they are unmodified, and each member of the block family is rotated (so in some cases it may appear to be another). There would also be methods for things like finding what side of the adjacent block faces a given side of the current block, and so on, for convenience.
Although I think this would be cool to have, I've been hesitating because even when these features aren't in use, there would have to be lots of additional indirection, checking with the GravityManager trivial implementation before doing anything relating to block sides. I don't know how inefficient this would be, but it seems like it would come up a lot. Explaining this now makes me realise that much of this could be alleviated by having the trivial GravityManager override the default implementations of its methods and not actually use rotations. It's still possibly worth discussing, though.

An additional suggestion based on something @LadySerenaKitty said: make the gravitational field accessible as an arbitrary vector (for non-block things to use) in addition to a cardinal direction.

 Gravity attached to specific objects rather than just basic gravity = down


feat: Migrate Starknet : get_class_hash from "beerus_rest_api" to "beerus_rpc"

Feature Request
Describe the Feature Request
We are deprecating "beerus_rest_api" and now migrating all the api endpoints to "beerus_rpc".
Migrate get_class_hash and add tests on beerus_rpc.
Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

@danilowhk Can I take this one?

lgtm


dep item<EMAIL_ADDRESS>is a bug version and should not be used

see issue https://github.com/browserify/resolve/issues/297

eslint-plugin-import declared<EMAIL_ADDRESS>in dependencies（ commit: https://github.com/import-js/eslint-plugin-import/commit/261ee3aa7666edb0131e08db3d3d3428b013df42 ） will cause project which depend on eslint-plugin-import installed<EMAIL_ADDRESS>rather than 1.22.2 and occur error when build with Webpack or other bundle tools.

It's not buggy, to be clear, it's just that it breaks bundlers.
v1.22.4 will be published soon, which will address the problem without any change needed here.

v1.22.4 is published.


Stability enhancements for database components ADMIN and MSG.

The scheduler parts of components ADMIN (db/app/admin) and MSG (db/app/msg) have been enhanced.

Release 3.3.0


Initial mime multipart support

The mime-multipart format supports combining shell scripts and cloud
configs as well as including configurations from external sources.
This allows vendors to easily combine separate types of userdata
from different sources, such as a user shell script and cloud-config section.
Addresses coreos/bugs#912.

I'm still (slowly) reviewing this.

Terraform now enables the generation of multi-part cloud-init configuration. Support in CoreOS will make it much easier to configure Kubernetes nodes without curling scripts from elsewhere.

Yes please, multipart support for cloudinit will make bootstrapping easier/cleaner in CoreOS land.

@crawford any update on this?

@Maimer not yet. I promise I'm not ignoring this, I'm just spread a bit too thin right now.

I'm following this for updates as well. +1

I think a lot of people really needs this feature in CoreOS.

Closing due to inactivity. FYI, for those who need remote-config capabilities you can run coreos-cloudinit --from-url https://example.com/ from your top-level config or you can use Ignition.

Another FYI, @psschroeter is working on fixing this up on another fork and he'll make a PR with from there.

Did this ever make it?


Support for line and column numbers

Is support for this planned in the future?  I would like to include this information in diagnostics, both from parse errors as well as semantic analysis of the nodes.
Thanks!

I wouldn't say it's exactly planned, but adding location information to error messages is something I've been thinking about.


Deploy process for bleeding edge users

Since we have users who make PRs to this repo and then want to use the changes in their own repo, we should have a better deployment story. Ideally we want to be able for users to point to a specific Zaplib git commit and use that (both on the Javascript and on the Rust side).
We also want a good story for people who care more about stable releases, but we can worry about that later (maybe make a ticket for that once we've solved the bleeding edge use case).

It looks like this works for Rust:
[dependencies]
zaplib = { git = "https://github.com/Zaplib/zaplib", rev="0491aee1" }

Amazing! I think we can get the same for npm dependencies but we'll either have to include a build step on the user's machine (which is not great) or check the build files into git (also not great). Our best option is likely https://github.com/marketplace/actions/npm-publish-on-every-push which will result in a lot of versions, but per https://stackoverflow.com/a/34755757 that's probably okay (at least for now!)
We probably also want to add an error if the JS and Rust versions are out of sync.


Improve documents

Background
For now, README.md is big and a lot of informations within one place. I think it is hard to maintain so we need to make README.md simple like other tools and specific informations should be written in specific page like how to use the command.
Also all of samples of command is maintained manually and it will cause differences from actual command.
Work

[ ] make README.md simple, divide informations to specific page
[ ] use trycmd for all of command regard dynein in the docs

Design
The doc docs/cmd/*.md is to describe each command how to use command and samples.
.
├── CODE_OF_CONDUCT.md
├── CONTRIBUTING.md
├── Cargo.lock
├── Cargo.toml
├── LICENSE
├── NOTICE
├── README.md
├── docs
│   ├── cmd
│   │   ├── admin.md
│   │   └── use.md
│   ├── development.md
│   ├── faq.md
│   └── troubleshooting.md
├── k8s-deploy-dynamodb-local.yml
├── rust-toolchain
├── src
└── tests

Ref
https://github.com/aws/aws-cli
https://github.com/aws/aws-sam-cli
https://github.com/aws/aws-nitro-enclaves-cli
https://github.com/aws/copilot-cli

I agree that splitting the documentation is necessary. However, I have concerns about the potential impact on user experience, especially for new users. The current style of README.md provides a straightforward guide that is easy for newcomers to follow.
Considering this, I would like to suggest a step-by-step approach. First, let's create book-style documentation using mdBook specifically tailored for new users. This will provide them with a comprehensive and structured resource, enhancing their understanding and overall experience. Once we have the new user documentation in place, we can proceed with splitting the README.md. By following this approach, we can ensure that new users have a reliable and easy-to-understand resource, while still maintaining the benefits of a divided documentation structure.


Only enable caching for web process

Currently, any attempt to run the application other than via
gunicorn_start blows up because ENABLE_CACHING is set in the config file
but SOURCE_COMMIT_ID is not set (it is determined dynamically via the
gunicorn_start script).
The quick fix here is to move ENABLE_CACHING out of the config file and
into gunicorn_start. The longer term fix is to have a common entry-point
script (not gunicorn specfic) which does all the necessary environment
setup and which everything can use.

In parallel to this, are you going to remove ENABLE_CACHING from the environment file?

I am indeed

Then I approve.


RPC API Batch 1 - Acceptance Test - Improvement (#1050)

Description:
Cherry pick #1050

changed the hardcoded value of "blocksBehindLatest" from 40 to 10, since is enough for the purpose of the test and gives higher chances that even if the tests and the hardware used to run the tests improves in the future, the test will continue to work.

adding comments to change

further improve test to fetch from beginning in case currentBlock is less than 10

avoid double call of eth_blockNumber

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch and project coverage have no change.

Comparison is base (789a97d) 74.43% compared to head (6aa0994) 74.43%.

:exclamation: Current head 6aa0994 differs from pull request most recent head ab4d5d7. Consider uploading reports for the commit ab4d5d7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.21    #1075   +/-   ##
=============================================
  Coverage         74.43%   74.43%
=============================================
  Files                30       30
  Lines              2046     2046
  Branches            390      390
=============================================
  Hits               1523     1523
  Misses              417      417
  Partials            106      106

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


DataPollManager: Fix the reseting of the mNoBufferRetxMode.

Thanks to @librasungirl  for finding this...

Codecov Report

Merging #1615 into master will decrease coverage by 0.67%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
- Coverage   70.48%   69.81%   -0.68%
==========================================
  Files         156      160       +4
  Lines       19028    20271    +1243
  Branches     2321     2487     +166
==========================================
+ Hits        13412    14152     +740
- Misses       4768     5219     +451
- Partials      848      900      +52

Impacted Files
Coverage Δ

src/core/thread/data_poll_manager.cpp
67.39% <40%> (+1.95%)
:arrow_up:

src/ncp/ncp_base.cpp
34.84% <0%> (-13%)
:arrow_down:

src/ncp/hdlc.cpp
76.34% <0%> (ø)

src/ncp/ncp_uart.cpp
71.6% <0%> (ø)

examples/apps/ncp/main.c
100% <0%> (ø)

src/ncp/ncp_base.hpp
0% <0%> (ø)

examples/platforms/posix/radio.c
78.42% <0%> (+0.41%)
:arrow_up:

src/core/thread/mle.cpp
81.84% <0%> (+0.42%)
:arrow_up:

src/core/thread/network_data_leader.cpp
80.2% <0%> (+0.5%)
:arrow_up:

src/core/thread/mle_router.cpp
78.63% <0%> (+0.69%)
:arrow_up:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f10a45...416b99d. Read the comment docs.


Switch dashboards-search-relevance to pull from 2.10 branch

In preparation for the 2.10 release, the 2.10 branch has been cut and should be used.
Description
Switches the branch for dashboards-search-relevance plugin to 2.10 (from 2.x). The 2.10 branch is cut and has all commits that we plan to include.
Issues Resolved
Contributes to completing https://github.com/opensearch-project/dashboards-search-relevance/issues/253
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hey @msfroh !
See https://github.com/opensearch-project/opensearch-build/pull/3977
I am switching for everyone in above PR.

Oh -- nevermind. I see all repos were bulk-switched in https://github.com/opensearch-project/opensearch-build/pull/3977
We should update the repo release checklist for next time.

We should update the repo release checklist for next time.

Ack!


Propagate trace_id on logback produces empty value

I'm currently facing an issue while attempting to propagate the trace_id and span_id in my logback.xml file using http4s and Scala. Unfortunately, the variables appear to be empty.
To provide some context, I'm employing the OpenTelemetry auto-instrumentation (https://opentelemetry.io/docs/kubernetes/operator/automatic/) to implement tracing support over the http4s server.
Here's a snippet of my logback.xml encoding setup:
<encoder>
   <pattern>%highlight(%-5level) %-13(%d{HH:mm:ss.SSS}) %green(%logger{45}) TraceID=%X{trace_id}  SpanID=%X{span_id} - %message%n%xException{10}</pattern>
</encoder>

Despite my efforts, I've also attempted to change the variable names, such as trace.id, but the result remains unchanged.
Any suggestions on how to address this issue would be greatly appreciated.
Thanks in advance.

OpenTelemetry auto-instrumentation

Is this supported for Scala and http4s?

Any suggestions on how to address this issue would be greatly appreciated.

I encourage you to look at the following projects, which provide interop with http4s and open telemetry without relying on "auto-instrumentation".

https://github.com/typelevel/natchez/
https://github.com/davenverse/natchez-http4s-otel
https://typelevel.org/otel4s/
https://github.com/http4s/http4s-otel4s

@armanbilge Thanks for your response. I'll check out the projects you recommended.


Skip empty row groups in parquet reader

This PR fixes issue #7778
The commit makes velox parquet reader able to skip empty row groups, instead of crash. This behavior is inline with other parquet readers, e.g, presto parquet reader and parquet-format.
Additionally, this PR simplifies the code by removing the variable skippedRowGroups_

@yingsu00 could you take a look? thanks!

@qqibrow Can you please check the failed tests?

thanks for the review! Let me rebase and re-run the test.

I don't think this error message is relevant:
FAILED: velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o
/usr/bin/ccache /opt/rh/gcc-toolset-9/root/bin/g++  -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CHRONO_DYN_LINK -DBOOST_CHRONO_NO_LIB -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_EXPORT=EXPORT -DBOOST_CONTEXT_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK=1 -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_RANDOM_DYN_LINK -DBOOST_RANDOM_NO_LIB -DBOOST_SERIALIZATION_DYN_LINK -DBOOST_SERIALIZATION_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DBOOST_THREAD_USE_DLL -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DGLOG_CUSTOM_PREFIX_SUPPORT -DSIMDJSON_THREADS_ENABLED=1 -I_deps/protobuf-src/src -I../../. -I../../velox/external/xxhash -I_deps/folly-src -I_deps/folly-build -I_deps/gflags-build/include -I_deps/glog-build -I/usr/include/libdwarf -I_deps/fmt-src/include -I_deps/boost-src/libs/crc/include -I_deps/boost-src/libs/array/include -I_deps/boost-src/libs/assert/include -I_deps/boost-src/libs/config/include -I_deps/boost-src/libs/core/include -I_deps/boost-src/libs/static_assert/include -I_deps/boost-src/libs/throw_exception/include -I_deps/boost-src/libs/integer/include -I_deps/boost-src/libs/type_traits/include -I_deps/boost-src/libs/circular_buffer/include -I_deps/boost-src/libs/concept_check/include -I_deps/boost-src/libs/preprocessor/include -I_deps/boost-src/libs/move/include -I_deps/boost-src/libs/math/include -I_deps/boost-src/libs/lexical_cast/include -I_deps/boost-src/libs/container/include -I_deps/boost-src/libs/intrusive/include -I_deps/boost-src/libs/container_hash/include -I_deps/boost-src/libs/describe/include -I_deps/boost-src/libs/mp11/include -I_deps/boost-src/libs/winapi/include -I_deps/boost-src/libs/predef/include -I_deps/boost-src/libs/numeric/conversion/include -I_deps/boost-src/libs/conversion/include -I_deps/boost-src/libs/smart_ptr/include -I_deps/boost-src/libs/typeof/include -I_deps/boost-src/libs/mpl/include -I_deps/boost-src/libs/utility/include -I_deps/boost-src/libs/io/include -I_deps/boost-src/libs/range/include -I_deps/boost-src/libs/detail/include -I_deps/boost-src/libs/iterator/include -I_deps/boost-src/libs/function_types/include -I_deps/boost-src/libs/fusion/include -I_deps/boost-src/libs/tuple/include -I_deps/boost-src/libs/functional/include -I_deps/boost-src/libs/function/include -I_deps/boost-src/libs/bind/include -I_deps/boost-src/libs/type_index/include -I_deps/boost-src/libs/optional/include -I_deps/boost-src/libs/regex/include -I_deps/boost-src/libs/random/include -I_deps/boost-src/libs/dynamic_bitset/include -I_deps/boost-src/libs/system/include -I_deps/boost-src/libs/variant2/include -I_deps/boost-src/libs/multi_index/include -I_deps/boost-src/libs/foreach/include -I_deps/boost-src/libs/serialization/include -I_deps/boost-src/libs/spirit/include -I_deps/boost-src/libs/endian/include -I_deps/boost-src/libs/phoenix/include -I_deps/boost-src/libs/proto/include -I_deps/boost-src/libs/pool/include -I_deps/boost-src/libs/thread/include -I_deps/boost-src/libs/atomic/include -I_deps/boost-src/libs/chrono/include -I_deps/boost-src/libs/ratio/include -I_deps/boost-src/libs/rational/include -I_deps/boost-src/libs/date_time/include -I_deps/boost-src/libs/algorithm/include -I_deps/boost-src/libs/exception/include -I_deps/boost-src/libs/unordered/include -I_deps/boost-src/libs/tokenizer/include -I_deps/boost-src/libs/variant/include -I_deps/boost-src/libs/multiprecision/include -I_deps/boost-src/libs/uuid/include -I_deps/boost-src/libs/tti/include -I_deps/boost-src/libs/context/include -I_deps/boost-src/libs/filesystem/include -I_deps/boost-src/libs/program_options/include -I_deps/boost-src/libs/any/include -I_deps/glog-src/src -I_deps/xsimd-src/include -I_deps/re2-src -I_deps/simdjson-src/include -isystem ../../velox -isystem ../../velox/external -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wno-implicit-fallthrough          -Wno-empty-body          -Wno-class-memaccess          -Wno-comment          -Wno-int-in-bool-context          -Wno-redundant-move          -Wno-array-bounds          -Wno-maybe-uninitialized          -Wno-unused-result          -Wno-format-overflow          -Wno-strict-aliasing          -Wno-type-limits          -Wno-stringop-overflow          -Wno-stringop-overread          -Wno-return-type -Werror -g -fPIC   -fdiagnostics-color=always -Wno-deprecated-declarations -pthread -std=gnu++17 -MD -MT velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o -MF velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o.d -o velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o -c ../../velox/functions/prestosql/registration/ArithmeticFunctionsRegistration.cpp
g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

https://app.circleci.com/pipelines/github/facebookincubator/velox/41853/workflows/a6fb49b2-fd16-4c3d-8008-a19684e7c501/jobs/288533
I might have seen similar error when I use large NUM_THREAD to build. @yingsu00 WDYT?

@qqibrow Can you try changing the 16 to 8 here?
https://github.com/facebookincubator/velox/blob/7376fb29f72fa3109e9b0eb370adc9ef73a20884/.circleci/dist_compile.yml#L256C37-L256C37

@Yuhta Could you please review and merge this? Thanks!

@qqibrow Can you just squash the commits into 1?

@yingsu00 done. thanks!


Comment out fprintfs to suppress unwanted stdout

It was actually a mistake that this became a PR. Having it as a debug output seems like a good way to do it. I'll try to submit it that way.
There are a couple of other issues related to fixed-frame f0 timing from pitchmark estimation I'll submit separately.


Document how to install

In particular, need to include details for:

adding to package.json (ie npm install hubot-yubikey-invalidation --save)
adding to external-scripts.json

cc @alindeman

Isn't that covered by the Hubot plugin documentation already?