Refactor constant + tuple based choices to models.xChoices

Django 3 added special enumeration types for choices. We're not using them, as the app is old enough to have known both Django 1.6 and Python 2 :P
However, for models with multiple sets of choices it's somewhat hard to figure out which ones belong together. Using these enumeration types will make things more clear.
The refactor can be done without migrations, if done correctly. (As those enumeration types generate the same format as the old method in the end).
Not a priority, just a nice to have.

Ideally we'd convert everything; no sense using two different methods.
It's a lot of work, yes, but hunting down all references should not be that hard. Dunno how well VSCode handles it, but my IDE can give me a list of all usages of, for example, Review.SUPERVISOR. And with some regexp con-fu, refactoring can also be largely automated. However, that last one requires some skill I guess.
If your IDE cannot figure out all usages, this might be a good exercise in using grep (or ack). grep -R 'Review\.[A-Z\_]*' . should give you all usages of constants of Review.
It's a very nice CLI tool to understand, I use it daily.
However, doing this in stages is also fine imo; it's not a priority in any sense


feat: add support to export to PDF

Description
Well, it's nice to have a PDF version of the slides both as backup and also printable if needed.
Requirements

[ ] Checklist of requirements to be fulfilled

Additional Context
It's quite common to receive a PDF of slides from another system to to catch up, it's nice to have this feature.

I discussed this and I am still trying to grasp the real issue there. Having the current environment in mind, when is the printable version of slides actually needed?

I know speakers like to take notes on paper while presenting. Printable necessarily has little demand, though PDF could be a good option for offline and backup plans. However, if you can provide a print button on each slide for speakers only to print their HTML page, that would suffice, or one button for speakers so that they can download all slides into one PDF.


Add pl3xmap support

As for the dynmap-quest plugin, I suggest support for pl3xmap.

Wrong place to request. https://github.com/PikaMug/Quests/wiki/Casual-‐-Modules#want-support-for-other-plugins-or-features


Support for multiple instances per host; new state for primary time observing

We can record and process data on multiple instances per host now, needed for the new 2-instance AMD processing nodes.
We can detect when our own primary time observation is taking place, and transition to a new WAITING state until human intervention can happen.
Script for looking for directories for which no hits were detected, but for which we did save intermediate beamformer files.

Looks good to me


Fix 369 compareAtPrice

Resolves #369
Impact: minor
Type: bugfix
Issue
compareAtPrice doesn't display on the PDP page when available
Solution

Split the ProductDetailInfo info component
In the new ProductDetailPrice component, add the compareAtPrice display
Add a compact layout to the ProductDetailPrice that's used for mobile

Breaking changes
ProductDetailInfo has been split into 3 separate components

ProductDetailPrice
ProductDetailDescription
ProductDetailVendor

Testing
Run with the branch from this PR (https://github.com/reactioncommerce/reaction/pull/4731 ) or release-2.0.0-rc.5 or later if it's been merged

In Reaction, set the compareAtPrice for a variant and/or variant option
On the PDP page for that product, verify the compareAtPrice is displayed. (It's the crossed-out price)
On mobile, verify the compareAtPrice is above the price

Moved back into WIP. This is missing the compareAtPrice display for the variant option.

@mikemurray @kieckhafer what do we need to do to get this merged?

@spencern just checked it again after the reaction code was merged in. This is good to go, merging now.


⚠ Bofrost.lu has degraded performance

In 0596554, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1322 ms

Resolved: Bofrost.lu performance has improved in 74150b2 after 8 minutes.


Fix aiohttp client

Fix for broken aiohttp.client tracker.
url may be not a string:
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1083
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/typedefs.py#L45

@alxpy great catch, thanks for opening the PR! If you're up for it, could you write a test for this scenario? You could copy https://github.com/elastic/apm-agent-python/blob/6598165320d6891aa50bb6b178a6a06043efb04a/tests/instrumentation/asyncio/aiohttp_client_tests.py#L41-L59 and turn the waiting_httpserver.url into a yarl URL object before passing it to session.get(). Then, you can use this command to run the tests
./tests/scripts/docker/run_tests.sh python-3.8 aiohttp-newest

I can also add the test myself before merging if you prefer :)

I'll write test)

@beniwohli done

@alxpy Awesome, thanks!


A startup script for Anything LLM

Main Script:

The script starts by checking for required dependencies.
It then navigates to the project directory.
It sets the API base URL for the project (reverse proxy for gemini-pro).
It counts the number of services that are already running.
Based on the number of running services, it presents options to the user:
If all services are running, it asks the user if they want to restart the application or close all services.
If some services are running, it restarts all services.
If no services are running, it starts all services.
The script then starts the server, collector, and front-end services using the start_service() function.
It logs a message indicating that all services have been started and provides the location of the log files for output.

Pull Request Type

[ x] ✨ feat
[ ] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues

resolves #xxx
What is in this change?
Describe the changes in this PR that are impactful to the repo.
Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations

[ ] I ran yarn lint from the root of the repo & committed changes
[ ] Relevant documentation has been updated
[ ] I have tested my code functionality
[ ] Docker build succeeds locally

While this is an impressive script I think its particular use may be unique or niche to how you ideally want to run AnythingLLM for dev. Considering the impact of this would be only for running AnythingLLM in development mode, the recommended mode of just running each command in a terminal tab and having stdout/stderr being dumped to the terminal is sufficient for development.
Am I reading this PR correctly or is there an overt advantage to this kind of startup script? Additionally, the frontend proxies requests to an untrusted vercel application that is running a proxy around Google's API restrictions for Gemini use - which would be a ToS violation so we cannot commit that to the core repo.
Lastly, I do not think the proxy would work because the requests to gemini are sent from the backend, not the frontend so they would not even be proxied.
Closing this issue due to security concerns and will re-open if I am incorrect in my understanding of what this scripts purpose is.


Permanent error in loading 10x data

Hi
Please help me in getting to load 10x data
> immdata_10x <- repLoad(file_path)

== Step 1/3: loading repertoire files... ==

Processing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t" ...
  -- [1/9] Parsing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t/airr_rearrangement.tsv" -- airr
Error in `select()`:
! Can't subset columns that don't exist.
x Column `cdr1` doesn't exist.
Run `rlang::last_trace()` to see where the error occurred.
Warning message:
`select_()` was deprecated in dplyr 0.7.0.
ℹ Please use `select()` instead.
ℹ The deprecated feature was likely used in the dplyr package.
  Please report the issue at <https://github.com/tidyverse/dplyr/issues>.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.
> sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.6 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/openblas/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/libopenblasp-r0.2.20.so

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8
 [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] immunarch_0.9.0    patchwork_1.1.2    data.table_1.14.8  dtplyr_1.1.0       dplyr_1.0.10       ggplot2_3.4.2
[7] SeuratObject_4.0.3

Or from the other version
> immdata_10x <- repLoad(file_path)

== Step 1/3: loading repertoire files... ==

Processing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t" ...
  -- [1/9] Parsing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t/airr_rearrangement.tsv" -- airr
  -- [2/9] Parsing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t/cell_barcodes.json" --   -- [3/9] Parsing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t/clonotypes.csv" -- unsupported format, skipping
  -- [4/9] Parsing "/data/Continuum/Angel/Results/PN0340_0001/outs/per_sample_outs/PN0340_0001/vdj_t/concat_ref.bam.bai" -- Error in tolower(l) : invalid multibyte string 1
In addition: Warning message:
In readLines(f, 1) : line 1 appears to contain an embedded nul
> sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.6 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/openblas/libblas.so.3
LAPACK: /usr/lib/x86_64-linux-gnu/libopenblasp-r0.2.20.so

locale:
 [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C               LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8
 [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8    LC_PAPER=en_GB.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] immunarch_1.0.0    patchwork_1.1.2    data.table_1.14.8  dtplyr_1.1.0       dplyr_1.0.10       ggplot2_3.4.2
[7] SeuratObject_4.0.3

or
tcr_data <- repLoad("filtered_contig_annotations.csv", .mode = "single", .coding = TRUE)

== Step 1/3: loading repertoire files... ==

 Processing "<initial>" ...
-- [1/1] Parsing "filtered_contig_annotations.csv" -- 10x (filt.contigs)
Error in step_subset(parent, vars = vars, groups = groups, arrange = arrange,  :
                      is.null(j) || is_expression(j) is not TRUE
                    > tcr_data <- repLoad("filtered_contig_annotations.csv", .mode = "paired", .coding = TRUE)

                    == Step 1/3: loading repertoire files... ==

                      Processing "<initial>" ...
                    -- [1/1] Parsing "filtered_contig_annotations.csv" -- 10x (filt.contigs)
                    Error in step_subset(parent, vars = vars, groups = groups, arrange = arrange,  :
                                           is.null(j) || is_expression(j) is not TRUE
                                         >

Desperate to load the data :(

Hi, could you provide a couple of example datasets to test it?

Could you check if the latest cellranger version works please? Here: https://support.10xgenomics.com/single-cell-gene-expression/software/overview/welcome


Update Dockerfiles for consistency

What this PR does / why we need it:
Switches to a 4.12 base and adds missing label to Dockerfile.fast
Checklist

[x] Subject and description added to both, commit and PR.

/lgtm


Refit is not working in my PCL project.

I included Refit into a PCL project and I keep receiving this error when I use the RestService.For method:
System.NotImplementedException: You've somehow included the PCL version of Refit in your app. You need to use the platform-specific version!
I used the Xamarin PCL project template.  Here are my PCL setting:
.NET Framework 4.5
ASP.NET Core 1.0
Windows 8
Windows Phone 8.1
Xamarin.Android
Xamarin.iOS
Xamarin.iOS (Classic)
I have tried Refit versions 2.3, 2.4, and 2.4.1.  Any ideas why this is not working?  I'm assuming the PCL profile is incorrect but I do not know the correct profile.

Have you added refit to your platform specific application projects?

Yes, they're in the solution.  So far I've only tested Android because I'm stuck at this error.

You have to add it your test project. If you´re using PCLs then test
project could a non-platform specific project (ex a .Net 4.5).
But using android/ios test project you should add refit to them as well
Hope i made my self clear.
On Wed, 20 Jul 2016 at 09:21 Josh Wood<EMAIL_ADDRESS>wrote:

Yes, they're in the solution. So far I've only tested Android because I'm
stuck at this error.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/paulcbetts/refit/issues/250#issuecomment-233933172,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGr-6gQ1zuLQ4xPIiA7PtxdsVNlJiAKfks5qXhKqgaJpZM4JQW0A
.

I don't have a test project included.

My bad I got mislead by "I only tested on android"
Make sure you install in the P.S projects as well(you've done that?), watch
package manager console and verify that there isn't an error when
installing.
On Wed, Jul 20, 2016 at 3:11 PM Josh Wood<EMAIL_ADDRESS>wrote:

I don't have a test project included.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/paulcbetts/refit/issues/250#issuecomment-234033113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGr-6gu30hBBAFHnpUNf3aly9V3gveEyks5qXmTQgaJpZM4JQW0A
.

I have included them and ensure they installed ok.  I have used Refit in a Xamarin Shared project before with no issue.  Is my problem that I'm using a Xamarin PCL rather than a Xamarin Shared project?

Not at all. In contrast, i´ve always used it with PCLs, the only occurred
once because i didn´t install Refit in the platform specific projects
On Wed, 20 Jul 2016 at 17:24 Josh Wood<EMAIL_ADDRESS>wrote:

I have included them and ensure they installed ok. I have used Refit in a
Xamarin Shared project before with no issue. Is my problem that I'm using a
Xamarin PCL rather than a Xamarin Shared project?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/paulcbetts/refit/issues/250#issuecomment-234070709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGr-6sErtOijuh3yA_u0l8Dozsod6vkuks5qXoQAgaJpZM4JQW0A
.

Here is what I've found out.  I was using Refit in a Xamarin Forms PCL project.  I had a Droid PCL and an iOS PCL.  I confirmed that the proper platforms of Refit were installed in the 3 PCLs.  The Refit PCL breaks in the Xamarin Forms PCL because iOS and Android are rendered using the Xamarin Forms PCL.  Since the Xamarin Forms PCL is targeting .NET and the platform PCLs are targeting their respective Refit platform DLLs, I receive the error above.  So I figured I had two options, duplicate the Refit code in the Platform projects or switch to a Xamarin Forms Shared project.
As soon as I switched my code over to a Xamarin Forms Shared project, I no longer receive the error.  This makes sense, but I hate the shared project.  But, it is what it is, and everything is working now.
Amedalejo thanks for your help, I appreciate how quickly you were responding and trying to help.

just to clarify there´s no such thing as Droid/iOS PCL.
You should make sure you install Refit in the platform specific project
(Android and iOS not just the pcls) as well
Portable Class Libraries (PCLs) is a subtype of Class Libraries
Class Libraries can be portable i.e can be used in more than one
platform without recompiling - the platform coverage of PCL is define
by it´s client profile which specifies supports for all .net platforms,
.NetCore, MonoDroid, MonoTouch e.t.c or just a subset of them.
Class Libraries can also be platforms specific i.e they can be re-used
between different projects targeting the same platform without recompiling.
So don´t confuse your Android/iOS class libraries with Portable Class
Libraries, because those are not "portable"
Cheers
On Wed, 20 Jul 2016 at 21:25 Josh Wood<EMAIL_ADDRESS>wrote:

Closed #250 https://github.com/paulcbetts/refit/issues/250.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/paulcbetts/refit/issues/250#event-729764888, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGr-6iR4la3Ib4Gc9jfimUfqEsSevWGHks5qXryIgaJpZM4JQW0A
.

I have tried refit in PCLs, ensured that refit was installed on xamarin platforms aswell.
I also tried to use a shared project (completely removed connection to any PCLs).
I have also tried different versions of refit.
Nothing has worked, ai very frustrating..

Also getting the same error, i have Refit in a PCL and included the nuget in the Android project as well but i still get the same error

I am also getting this error. I am clearly referencing the MonoAndroid version in my Android project, but I still get this error at runtime.

Please, stop writing "me too comments" on a closed issue. Make a new one describing your problem with enough detail to help you. Probably linking to this issue in it too.

The highest version I could install was 2.4.1  then it worked. Unfortunately there were changes in the newer versions that don't allow it to work with PCLs.

What PCL type are you trying to use? Some PCL types may be supported, others may not be. Refit 3 supports .NET Standard 1.1+, so you need to be using a compatible PCL profile.
See https://github.com/dotnet/docs/blob/master/docs/standard/net-standard.md#pcl-compatibility for the table.

I have built a PCL project using Visual Studio for Mac. My project is using PCL 4.6 - Profile44 but i get the same error after including the library in the Android project

How to fix this? Ive already added all refit package in every platform including the PCL. It's very frustrating. Please someone

This ended up being an issue with the project file for me. Needed to manually move some stuff around.


[Pub/sub subscriptions] Fix C# example

Signed-off-by: Hannah Hunter<EMAIL_ADDRESS>Description
Use suggested change for C# example
Issue reference
PR will close: #2538

IMO this should be the same as the QS here https://github.com/dapr/quickstarts/blob/master/pub_sub/csharp/sdk/order-processor/Program.cs
using System.Text.Json.Serialization;
using Dapr;
var builder = WebApplication.CreateBuilder(args);
var app = builder.Build();
// Dapr will send serialized event object vs. being raw CloudEvent
app.UseCloudEvents();
// needed for Dapr pub/sub routing
app.MapSubscribeHandler();
if (app.Environment.IsDevelopment()) {app.UseDeveloperExceptionPage();}
// Dapr subscription in [Topic] routes orders topic to this route
app.MapPost("/orders", [Topic("pubsub", "orders")] (Order order) => {
Console.WriteLine("Subscriber received : " + order);
return Results.Ok(order);
});
await app.RunAsync();
public record Order([property: JsonPropertyName("orderId")] int OrderId);

In essence this code snippet really is showing this for .NET
// Dapr subscription in [Topic] routes orders topic to this route
app.MapPost("/checkout", [Topic("pubsub", "orders")] (Order order) => {
Console.WriteLine("Subscriber received : " + order);
return Results.Ok(order);
});
Or two other variants
// Dapr subscription in [Topic] routes orders topic to this route
app.MapPost("/checkout", Orders).WithTopic(PubsubName, "orders");
    Console.WriteLine("Subscriber received : " + order);
    return Results.Ok(order);

[Topic("pubsub", "orders")]
[HttpPost("/checkout")]
public async Task<ActionResult<Stock>> HandleCheckout(Checkout checkout, [FromServices] DaprClient daprClient)
{
    // Logic
    return stock;
}

Actually I suggest that we add both examples for .NET, like this
// Dapr subscription in [Topic] routes orders topic to this route
app.MapPost("/checkout", [Topic("pubsub", "orders")] (Order order) => {
    Console.WriteLine("Subscriber received : " + order);
    return Results.Ok(order);
});

or
[Topic("pubsub", "orders")]
[HttpPost("/checkout")]
public async Task<ActionResult<Order>>Checkout(Order order, [FromServices] DaprClient daprClient)
{
    // Logic
    return order;
}


Feature/54 validate required endpoints

Solves #54

Sorry, I've included a previous commit in the PR by mistake :man_facepalming:

No worries, I rebased your PR, it's fine now ;)

Comments fixed in b29ef05402d73183ac1907ef4bcc54eac59a6840


Use base64 instead of xxd and display the server motd if available.

This will detect if the non-coreutils version of base64 is present and use the correct decode option for it. Also displays the server motd message.

Hey red5d, I know you worked hard on this but I just don't trust base64 due to all the api changes they have made over the years. Yes, it would increase the max .sshrc.d size by 50%, but I don't think that's worth the risk of breaking things for current users.


HDFS-15817. Rename snapshots while marking them deleted.

Please see https://issues.apache.org/jira/browse/HDFS-15817 for details.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 24s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
shadedclient
15m 13s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 13s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 11s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m 10s

the patch passed

-0 :warning:
checkstyle
0m 57s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 28 unchanged - 0 fixed = 34 total (was 28)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 43s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m 16s

the patch passed

_ Other Tests _

-1 :x:
unit
192m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

279m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7544dcf31cf5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 66ecee333e0

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/testReport/

Max. process+thread count
2879 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
89m 46s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
shadedclient
19m 58s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 54s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 50s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 32s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 32s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
checkstyle
1m  5s

the patch passed

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 47s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
4m  9s

the patch passed

_ Other Tests _

-1 :x:
unit
209m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

366m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithDFSAdmin

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.server.namenode.snapshot.TestOrderedSnapshotDeletionGc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8829bc4f5317 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5f34271bb14

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/testReport/

Max. process+thread count
2940 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Appending a timestamp to the deleted snapshot name may lead to different names being generated pre and post restart of namenode during edit log replay. Therefore, the idea here is to just append the snapshot Id which will remain constant.
@szetszwo , can you have a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 12s

trunk passed

+1 :green_heart:
compile
2m  0s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
shadedclient
23m 12s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
4m 20s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 13s

trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 49s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 56s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
0m 56s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
0m 56s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

-1 :x:
javac
0m 56s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

-1 :x:
mvnsite
0m 50s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

-1 :x:
shadedclient
3m 21s

patch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

-1 :x:
findbugs
0m 43s
/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

94m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 13ebafc3a9b0 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65857ea7c07

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/testReport/

Max. process+thread count
508 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 37s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
shadedclient
17m 33s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 20s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 18s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 57s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m 27s

the patch passed

_ Other Tests _

-1 :x:
unit
195m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

288m  3s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3db44fa108f6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65857ea7c07

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/testReport/

Max. process+thread count
3240 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@bshashikant , the commit https://github.com/apache/hadoop/pull/2677/commits/99efed356c1d9181ea4991ea22b690cbff6ad022 did not fix any whitespace changes.  The changes might be done by your IDE.  I suggest to use VI or other editors to revert those changes.

The changes generally look good. However, if a user again deletes a deleted snapshot with the new name(which was given because of this rename. Can we lead into concats of the snapid ?

Yes, it will append the snap id. The behaviour will be same if user for example, creates a snapshot with the same name as snapshot format and deletes it . I guess, this should be fine as marked for deleted snapshots are user visible and can be deleted again and again until and unless it gets permanently deleted.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 22s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
shadedclient
18m 24s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m 18s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 16s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 41s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m 24s

the patch passed

_ Other Tests _

-1 :x:
unit
193m 51s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

287m 54s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 91a9de5b8392 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19ae0faacc5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/testReport/

Max. process+thread count
3039 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 27s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
shadedclient
15m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+0 :ok:
spotbugs
3m  5s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  3s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 39s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

+1 :green_heart:
findbugs
3m  7s

the patch passed

_ Other Tests _

-1 :x:
unit
200m 36s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

287m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2677

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cd5368a3c33e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19ae0faacc5

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/testReport/

Max. process+thread count
3508 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @mukul1987 and @bshashikant for the review.


Check kernel params, extend kernel test coverage

PR Type

Feature
Tests

Description

Added __init_check__'s to every kernel in scalar_valued.py.
How Has This Been Tested?

Added additional tests to expand coverage.
Does this PR introduce a breaking change?

(Write your answer here.)
Screenshots

(Write your answer here.)
Checklist before requesting a review

[x] I have made sure that my PR is not a duplicate.
[x] My code follows the style guidelines of this project.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have performed a self-review of my code.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

Looks good! Approved assuming all the CI passes.
Got there in the end!


Special symbol var decls can be created in the wrong function

When we rollback the scanner and reparse a destructured object literal containing a function and the outer funtion has a special symbol reference, it is possible we will incorrectly create a var decl for the special symbol in the nested function.

What is a “special symbol reference”?  It’s not obvious from the testcase.

@fatcerberus I agree the test case code doesn't begin to make sense but it is valid syntactically, I guess, because a fuzzer generated it.
The special symbols are ones we track specially in the parser. Think this, super, arguments, etc. We do binding for these in slightly special ways so that's why they are called special symbols. The reference to a special symbol in this case is a pidref to the special this symbol.

Thanks for the explanation, at first I thought it had something to do with ES6 Symbols but then I didn’t see any of those in the test so I got curious...


Windows zip

Windows Release v2.3.0 zip archive (didnt check others)  wont open with windows explorer. Opening it with 7z or WinRar works fine. At least should be noted in readme or compressed in compatibility.  And if you are just starting, click that download for release, and open from browser, you may not notice winrar/7z is not associated with zip files (for god knows what reason - thank you microsoft! )

I agree that Windows 11 forces many mandatory features that make the UX horrible. On the other hand, the Zip issue is already solved https://github.com/webui-dev/webui/issues/120. But @hassandraga did not update the archive files yet.
Thank you, @NegativeIQ, for bringing this out.


What are these engines ? googleGTX -- googleWeb -- googleV2

I Searched Google
For example, I search what is googlegtx or what is google gtx
But no link explains it

I'm also interested, tell me about Google 2.0


[SERVER] DHCP and DNS containers assigned names

What needs to be done?
Assign Daaukins generated names for the DHCP and DNS containers
Acceptance criteria

[ ] DHCP and DNS containers are assigned a daaukins' style name

Fixed in PR: https://github.com/andreaswachs/bachelors-project/pull/59


[FEATURE REQ] Add examples for configuring common properties

Context
The Spring Cloud Azure supports lots of common properties since the 4.0 release, but the developers may be still not know how to use them, and how to combine them, there's no samples in our reference doc, such as How to configure the retry options for KeyVault Clients when using Spring Cloud Azure Starter Key Vault Secert.
Goal
Improve the reference doc to give more sample code to demo more user scenarios, we should cover the common use cases for the HTTP-based client option, amqp-based client option, and includes the Cosmos client options, which should contain the below items:

Samples the global property options(retry, client(logging), proxy, credential, profile, resource).
Samples for each service property option (retry, client(logging), proxy, credential, profile, resource).
Maybe more special scenarios for Key Vault Secerts.

Add retry configuration samples in this PR https://github.com/microsoft/spring-cloud-azure/issues/985

close for moved to the above repo


ci: fix starkent api dependency check

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

Current dependencies on/for this PR:

main

PR #918   👈

This comment was auto-generated by Graphite.


Animated status icons

About the PR

Adds support for animated RSI states
Why / Balance

Technical details

For some reason it requires full rsi path
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

what about add sprite: [path] to JobIcon and remove it from all other

Nope, seems it require full sprite defenition
Reading Content.Shared.StatusIcon.StatusIconPrototype(JobIconBotanist) threw the following exception: Robust.Shared.Serialization.InvalidMappingException: Expected sprite-node

it looks visually jarring and annoying to look at

it looks visually jarring and annoying to look at

sad

@Morb0 you coming back to this?


Proposal: Add basic issue and PR templates

Having some basic fields to fill out for issues and PRs is something I find useful on my own projects and at work (we require PR templates on all repos, and it really helps!). These are the ones I use on my FOSS stuff as a good baseline.
Also adds an editorconfig and links to some files.

Thanks for the suggestions @varjmes, I applied those!


Separate Submit from Publish

Allow submit without publishing, so people can test against a new version but will not automatically update unless it’s published.
We might want to keep the "submit" to auto-publish, and either have a flag on submit or another command (push?) then a new publish command.

Seems that using alpha etc. actually solves this.

@back2dos are you sure ? does the server makes such exception when it comes to marking the current version ?

I'm not sure I understand the ticket in the first place. Would not installing anything that is alpha/beta/rc unless explicitly specified solve this problem?

I'm happy to look into this.  It will require a change on the server API where it chooses the "current" version.  It needs to choose based on the semver, currently it chooses based on the date of submission (See https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Repo.hx#L285).
There would be a few changes (improvements/fixes) to the semantics:

The website lists would be sorted by semver, not upload time.
The current version would be based on semver, not upload time, meaning:

You could upload a bug fix for a "2." version, when "3." is already uploaded, and "3.*" will remain current.
If there is a "stable" version (Version > 1.0, and not tagged alpha/beta/rc) then this should take precedence over a non-stable version.

haxelib install should install the latest stable version (if there is a stable version).
haxelib update should only update to the same level of release.  (If you have a stable release, only update to a stable release. If you have a beta though update to a beta).
Perhaps we can have a haxelib install project [alpha|beta|rc] style commands.

In short, if we actually draw some meaning from our semantic versioning, I think we have an adequate solution to this problem.

I agree for everything apart from haxelib update sticking to the same level of release. I think this will cause much more issues that it fixes. Maybe we could instead have an extra optional parameter such as "haxelib update mylib 3.2" that would update to the latest 3.2.x

You can always use haxelib install <libname> <version> to get a specific version. As it is, haxelib update is basically equivalent to haxelib install <libname> latest.
I also think what Jason proposes is to stick with the same level of a major release. Since major releases are meant to express a break in compatibility, that seems a sensible thing to do.

For now I have implemented this by having the client filter for the latest stable, as ProjectInfos has the whole version log anyway. Does that solve the issue @ncannasse ? If so, please close.
Regarding all the other SemVer related stuff, I'm going to move this into another ticket, as that's out of scope of this issue.

@back2dos I'm not sure that it solves it or not, could you reference the corresponding commit ?

This is basically it: https://github.com/HaxeFoundation/haxelib/commit/e8417a55d4f8bb18145389da325efb1713c96bc4
Although the current state is a little different now (sorting by semver version comparison): https://github.com/HaxeFoundation/haxelib/blob/master/src/tools/haxelib/Data.hx#L196

Looks fine to me. We still need to do a bit of SemVer sorting on the website, so assigning to @jasononeil

I'll track that in #176


ionic support Chinese problem

when I type Chinese once, the result showed below:

by the way, the demo happened
http://ionicframework.com/docs//components/#searchbar also

ion-searchbar bug on 3.1.0, 3.1.1, 3.2.0 for non-latin languages. #11566

Hello all, closing this issue as a duplicate of https://github.com/ionic-team/ionic/issues/11566


Add UnitTests (IStatementBuilder, ITrace) and IntegrationTests for InlineCount, InlineDelete, InlineDeleteAll, InlineTruncate.

This is now invalid.


Feature request: never validate not-required blank/empty/unchecked inputs

Every time an input is set to not-required, I would expect the plugin doesn't validate the field when it is blank (empty) even if it has a custom validator.
Let me make the problem clear.
Let's have a simple email input that accepts only gmail accounts (plunker):
email: {
   inputType: 'text',
   placeholder: 'please, provide a gmail account',
   required: false,
   pattern<EMAIL_ADDRESS>}

If I leave the input blank and I try to submit the form, the plugin prevents submission and shows the classic Invalid format error.

The question I made when I see that was: why? The input is not-required, so why the plugin validates it? As a normal HTML5 email input (with no required attribute) is not "processed" by the browser (or by Angular) when I leave it blank, the same I expect from this plugin.

You make a strong argument. I'll try to implement this change in the next week or so.

This will go out in the next release.

This is available in version 4.1.0

Great, this works like a charm! :+1:


Allow an empty sender id (xmpp will fail to connect but http will wor…

…k) and the fcm endpoint

meant to open this into my own fork, but you can consider these changes as well

Current coverage is 69.87% (diff: 57.14%)

Merging #14 into master will decrease coverage by 0.31%

@@             master        #14   diff @@
==========================================
  Files             6          6
  Lines           540        541     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            379        378     -1
- Misses          113        114     +1
- Partials         48         49     +1

Powered by Codecov. Last update b2e02c5...5f112ba

@froodian thanx for reminding me to switch to FCM for good. Interesting point about senderID, will have a look at it.

Sounds good @bolshoy - FYI in the end I needed to make a couple more changes to keep html functioning properly without senderID (https://github.com/rounds/go-gcm/compare/master...Appboy:master) and I also changed client creation signalling slightly to take ~150ms instead of 1s (the tests that ensure that Listen was called before NewClient returns still pass reliably, so I'm relatively confident I didn't introduce any races with that)


Article title hidden under the menu during page load

That's how every page looks when it's loading:

Title moves right as soon as page loads.

This is super sucky and I believe it's an issue with MDL's layout.
Will leave this open to see if I can diagnose and raise a helpful bug on MDL.

This is a MDL 1.0.4 issue, it went away when were running 1.0.5 in development.

Thanks for the feedback, we've got an update coming next week that should fix this.


Create an Admin Management Tool

The following tasks are done by administrators (or presenters):

[ ] Modify "Processing Time" of the shipping service
[ ] Issue a "Price Drop" for a certain product

Admin Management tool could either be a CLI or a dedicated SPA. Corresponding APIs should only be accessible through the Admin Management tool (leveraging a custom API scope)

This could be easily achieved using Rust (leveraging the clap crate) or with Go (using the cobra module)


Localize the documentation (German / Ukrainian)

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Breaking Change
[x] Documentation Update

Description
This Pull Request is a partial resolution for the issue #19, it localizes the documentation for Ukrainian and German speakers.
Related Tickets & Documents

Related Issue #19
Closes #19 if this is considered more than a partial resolution

QA Instructions, Screenshots, Recordings
Simply copied the EN directory (by the way, very nice documentation structure :D) and created similar directories (UK, DE) for respective translations, with the same files. Also added the links to the index.html file at the root of the docs/ directory so the updated documentation is actually accessible.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.

[ ] Yes
[x] No, and this is why:  I don't think documentation needs unit tests.
[ ] I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?
Don't think so, everything is readable within GitHub.
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation. (It's actually a documentation change, haha)
[x] I have updated the documentation accordingly.

Thank you for your contribution! ❤


the first image never show up even though the download image is already finished

so the first image in the array will never show up, except if I change to the page control 2 (index 1), and goes back to the page control 1 (index 0) then the image is eventually show up
here is the .gif file of my problem:
http://g.recordit.co/EdK3BzgCCj.gif
even if I use the image in the asset, the problem is still there
the pod I use
# Uncomment the next line to define a global platform for your project
 platform :ios, '9.0'

target 'AATheCorousel' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for AATheCorousel
pod 'AACarousel'
pod 'Kingfisher', '~> 4.0'

end

and here is the code I use

import UIKit
import AACarousel
import Kingfisher

class ViewController: UIViewController, AACarouselDelegate {

    @IBOutlet var corouselView: AACarousel!

    var titleArray = [String]()

    override func viewDidLoad() {
        super.viewDidLoad()

        let pathArray = ["http://www.conversion-uplift.co.uk/wp-content/uploads/2016/09/Lamborghini-Huracan-Image-672x372.jpg",
                         "https://ak.picdn.net/assets/cms/97e1dd3f8a3ecb81356fe754a1a113f31b6dbfd4-stock-photo-photo-of-a-common-kingfisher-alcedo-atthis-adult-male-perched-on-a-lichen-covered-branch-107647640.jpg",
                         "https://imgct2.aeplcdn.com/img/800x600/car-data/big/honda-amaze-image-12749.png",
                         "http://www.conversion-uplift.co.uk/wp-content/uploads/2016/09/Lamborghini-Huracan-Image-672x372.jpg",
                         "https://imgct2.aeplcdn.com/img/800x600/car-data/big/honda-amaze-image-12749.png"]
        titleArray = ["picture 1","picture 2","picture 3","picture 4","picture 5"]
        corouselView.delegate = self
        corouselView.setCarouselData(paths: pathArray,  describedTitle: titleArray, isAutoScroll: false, timer: 5.0, defaultImage: "defaultImage")

        //optional methods
        corouselView.setCarouselOpaque(layer: false, describedTitle: false, pageIndicator: false)
        corouselView.setCarouselLayout(displayStyle: 0, pageIndicatorPositon: 2, pageIndicatorColor: nil, describedTitleColor: nil, layerColor: nil)
    }

    func didSelectCarouselView(_ view: AACarousel, _ index: Int) {

    }

    func callBackFirstDisplayView(_ imageView: UIImageView, _ url: [String], _ index: Int) {

    }

    func downloadImages(_ url: String, _ index: Int) {
        //here is download images area

        let imageView = UIImageView()
        imageView.kf.setImage(with: URL(string: url)!, placeholder: nil, options: nil, progressBlock: nil) { (downloadImage, error, cache, url) in
            self.corouselView.images[index] = downloadImage!
        }

    }

}

Inside your code add:
func callBackFirstDisplayView(_ imageView:UIImageView, _ url:[String], _ index:Int) {
imageView.image = UIImage.init(named:"step1_new")
}
where step1_new in the name of your first image


It will give error msg Error 6001.why?

Error 6001 is 'REQUESTED_KEY_SYSTEMS_UNAVAILABLE', defined in lib/util/error.js and documented at http://shaka-player-demo.appspot.com/docs/api/shaka.util.Error.html.  The docs say:

None of the requested key systems are available. A license server URI is required; so this may also happen if the key systems do not have a license server URI.

I also recommend reading the DRM Configuration tutorial: http://shaka-player-demo.appspot.com/docs/api/tutorial-drm-config.html
Does that answer your question?

Yes,Thank you !!!

Umesh Kumath
Engineer, Software Development
Direct Tel: +91 22 6680 1628
Board Tel: +91 22 6680 1515
201, Tower II,  SEEPZ++, SEZ,
Andheri (East), Mumbai 400 096, INDIA.
www.geemedia.com
On Wed, May 4, 2016 at 6:02 PM, Joey Parrish<EMAIL_ADDRESS>wrote:

Error 6001 is 'REQUESTED_KEY_SYSTEMS_UNAVAILABLE', defined in
lib/util/error.js and documented at
http://shaka-player-demo.appspot.com/docs/api/shaka.util.Error.html. The
docs say:
None of the requested key systems are available. A license server URI is
required; so this may also happen if the key systems do not have a license
server URI.
I also recommend reading the DRM Configuration tutorial:
http://shaka-player-demo.appspot.com/docs/api/tutorial-drm-config.html
Does that answer your question?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/shaka-player/issues/365#issuecomment-216846427


feat(AMQP): Add Header constants for consistent AMQP header usage

We're excited to introduce a new utility class for users of the AMQP driver! With the primary goal of improving readability and ensuring consistent usage of AMQP headers, we've added a dedicated class to provide a list of available header constants.
💡 Usage Example
The new header can be used to set the ROUTING KEY header as shown:
use Spiral\RoadRunner\Jobs\Queue\AMQP\Header;

/** @var QueueInterface $queue */
$queue->push(
    JobPayload::class,
    $payload,
    (new Options())
        ->onQueue('my_amqp_pipeline')
        ->withHeader(Header::ROUTING_KEY, '...')
        ->withDelay(20)
);

https://github.com/roadrunner-server/roadrunner/issues/1555
https://github.com/roadrunner-php/issues/issues/7

Codecov Report
Patch coverage has no change and project coverage change: -0.15% :warning:

Comparison is base (9185d6c) 86.52% compared to head (9bfc228) 86.37%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##                4.x      #58      +/-   ##
============================================
- Coverage     86.52%   86.37%   -0.15%
  Complexity      191      191
============================================
  Files            29       30       +1
  Lines           579      580       +1
============================================
  Hits            501      501
- Misses           78       79       +1

Files Changed
Coverage Δ

src/Queue/AMQP/Header.php
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Version Install and Old Version Uninstall Confusion

[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] I have searched the documentation and believe that my question is not covered.

Question

I am on Mojave 10.14.1 and have 2 poetry versions. Originally I had 0.11.4 installed using the recommended method but when running poetry self:update I was getting this error:
[RuntimeError]
Unable to determine poetry's path

So I decided to try and use the new get-poetry.py installer. But now I have a 0.12.6 in my ~/.poetry folder but when I do pip freeze the old 0.11.4 version is still there. Do I delete that old version just using pip uninstall and will that properly undo and remove all the vendorized magic the previous installer did? If I pass --uninstall to the current installer it doesn't seem to delete the old version in pip.
Thanks for the time and sorry for the nuisance.

I ended up running pip uninstall poetry and it seems to have removed all the stuff in site-packages so I am guessing things went well. Closing since my problem is likely solved.

To anyone having the same issue, use Python PIP to uninstall old version of poetry. Run python3 -m pip uninstall poetry  and it'll handle the uninstalling process for you.


Calling Modifer.Addheader() doesn't work from Milter.Headers()

Not sure if this is a bug with phalaaxx/milter or just a limitation of the protocol...
I've created a simple milter here which adds a header. I tried doing that from Milter.Headers() however get this error in postfix log:
Jun 18 04:29:07 dev postfix/cleanup[107]: warning: milter unix:/tmp/pol.sock:
  unexpected filter response SMFIR_ADDHEADER after event SMFIC_EOH

For now, I'm doing it in Milter.Body() which works, however I don't need to read the body and would like to avoid that if possible.

After reading milter-protocol.txt and comparing that with code here I'm pretty sure Milter.Body() is always called, irrespective of whether NoBody is set (contrary to phallax/milter documentation)


archiveLogs: true has no effect on HTTP Template

Pre-requisites

[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
When using container templates, the output of the execution is saves fron stdout as artifact, when archiveLogs: true is enabled.
For HTTP Templates the archiveLogs: true has no effect. I am looking for ways how to save http response as an artifact, because the response can be quite big, over a megabyte.
Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: http-template-
spec:
  entrypoint: main
  templates:
    - name: main
      steps:
        - - name: get-google-homepage
            template: http
            arguments:
              parameters: [{name: url, value: "https://www.google.com"}]
    - name: http
      inputs:
        parameters:
          - name: url
      http:
        url: "{{inputs.parameters.url}}"

Logs from the workflow controller
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.787Z" level=info msg="Starting Workflow Executor" version=untagged
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.792Z" level=info msg="Starting Agent" requeueTime=10s taskWorkers=16 workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.795Z" level=info msg="Watch workflowtasksets 200"
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.797Z" level=info msg="TaskSet Event" event_type=ADDED workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.887Z" level=info msg="Processing task" nodeID=http-template-7zgtv-2137851634
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:11.148Z" level=info msg="Sending result" message= nodeID=http-template-7zgtv-2137851634 phase=Succeeded requeue=0s
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.794Z" level=info msg="Processing Patch" workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.805Z" level=info msg="Patch workflowtasksets/status 200"
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.886Z" level=info msg="Patched TaskSet"

Logs from in your workflow's wait container
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.787Z" level=info msg="Starting Workflow Executor" version=untagged
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.792Z" level=info msg="Starting Agent" requeueTime=10s taskWorkers=16 workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.795Z" level=info msg="Watch workflowtasksets 200"
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.797Z" level=info msg="TaskSet Event" event_type=ADDED workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:10.887Z" level=info msg="Processing task" nodeID=http-template-7zgtv-2137851634
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:11.148Z" level=info msg="Sending result" message= nodeID=http-template-7zgtv-2137851634 phase=Succeeded requeue=0s
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.794Z" level=info msg="Processing Patch" workflow=http-template-7zgtv
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.805Z" level=info msg="Patch workflowtasksets/status 200"
http-template-7zgtv-1340600742-agent: time="2023-04-05T18:47:20.886Z" level=info msg="Patched TaskSet"

Issue is still very relevant

@egze - would you be able to confirm this is not working on one of the newer versions of Argo Workflows, 3.4.11 or 3.5? We will investigate, but helpful to be precise which version you're seeing this issue on.


in readme.md a discord is mentionned... what discord ?

I have a few questions before migrating from DC, and I might be interested in supporting you if problems are fixed and project is active, however I can't find the discord mentionned in readme...

The discord is now added to the docs


'/' replaced with %252F in URL [Instagram]

Description:
My URL is being encoded and all the slashes ( / ) are being replaced with %252F.
Also, my colons ( : ) are being replaced with %253A. My code is just here:
https://hastebin.com/deninuloza.lua
OAuth Provider (Twitter, Github, ..):

Instagram

OAuth Version:

[ ] Version 1
[X] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[ ] CocoaPods
[X] Manually

Library version:

[ ] head
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[X] 8.0 (Swift 3.0)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other: (Please fill in the version you are using.)

[ ] objective c

I'm having a similar issue. Seems to be caused by this commit.

Managed to get it working by just deleting the .urlEncodedString
I just expanded the OAuthSwift.xcodeproj and simply deleted the line in Sources/OAuth2Swift.swift
Command+F to find the queryString and re-ran my project and it's worked!

Yeah I've reverted my project to before that commit and it's working fine. @phimage, let's get this reverted if possible. It's breaking for me specifically with GitHub and GitLab APIs. Haven't tested any more yet, but I'm assuming it's broken for others as well.

please don't close until issue fixed
yes I will revert (and put a boolean to encode)


Specifying verification key trustworthy for JSON serialization

Due to spec https://www.ietf.org/archive/id/draft-ietf-rats-eat-31.html#section-9.6, an EAT'd better have some way to specify the trustworthy of the verification key. For now the APIs to serialize EAR to JWT is

sign_jwt_pem(&self, alg: Algorithm, key: &[u8])
sign_jwk_der(&self, alg: Algorithm, key: &[u8])

I propose to add two more

sign_jwt_pem/der_with_kid(&self, alg: Algorithm, key: &[u8], kid: &str): This will do same thing with sign_jwt_pem/der, but also it will fill the JWT's kid header item, which will be used by the verifiers to look up their configured key store.
sign_jwt_pem/der_with_jwk(&self, alg: Algorithm, key: &[u8], jwk: &[u8],x5c: Option<&str>): This will do same thing with sign_jwt_pem/der with key. The jwk will be filled into the JWT's jwk header and x5c be filled into x5c extension if any. The two are used by the verifiers to verify the signature. x5c together with the TrustRoot configured on the user side would be used to verify the trustworthy of the jwk.

I've added _with_header version of the methods that take a jwt::Header as an argument. This removes the need to define different methods for each header/combination of header that might need to be added.
Please see https://github.com/veraison/rust-ear/pull/29

Resolved by https://github.com/veraison/rust-ear/pull/29


Problem to see RealID contact play zone

Hi,
All is in the title. i can't see the zone where play my realid contact in wow
Is there any issu for this problem ?

@NeOtHeNeO No issue that I know of, unless the Battle.net API bug has regressed. I will look into this ASAP.

This is a Blizzard API bug, which I will push a fix out for soon.

Fixed in release <IP_ADDRESS>-beta. Please try it out and let me know.


raw_width handling implemented

I've found your module very use full but there was on issue though. I wasn't able to alter the width of the rows. So I implemented it. There is not much change to it to be explained. Don't be frustrated by the number of lined added and removed most of it is just to make it comply with the pep-8 style guide.

Thank you for your contribution!
I will review this pull request next week.

Please check your changes again.
When testing I get an error "TypeError: 'int' object is not subscriptable" in the try block.
Thank you!

Okay @kremastra  sorry for the inconvenience

I've looked at it and there was an i variable from the past code which i was using for iterating through the data and index the data list. I was only using the button_text_mode == 1 and the variable was only in mode 2 & 3. Any ways I've fixed it i'll create a pull request.

Buddy, the program works, but in the ROW_WIDTH = 1, 2 or 4+ options the visualization of the control buttons breaks.
It is necessary that the three control buttons at the bottom (<---, m/n, --->) are always in the same row.
Need to fix this.
The only option when the visualization is correct is ROW_WIDTH = 3.

i've got a simple fix for that. so when adding navigation keyboard instead of using the add method we need to use row method.
Again sorry for the inconvenience. Just implemented it in my app and only used it with the options row_width=3 and button_text_mode=1.

Yes, using the "row" method fixed the problem for options 1 and 2, thank you!
But for options ROW_WIDTH = 4 and higher the situation is the same.
It is best to add in the README that ROW_WIDTH can take values from 1 to 3 only.
OK, I will add changes to the pull request and release new version soon.
Thank you for your contribution!

okay man thank for your time. May be we'll fix it some other time.


When set 3Dtileset clipping planes same length twice，cesium crashed.

When set 3Dtileset clipping planes same length twice，cesium crashed.
Sandcastle example:
Browser:  Chrome  105.0.5195.127
Operating System: Window

Similar problems：
#10811
#8728
@lilleyse  @j9liu


bug(chats): group chat has indicator online on sidebar when members are offline

Prerequisites:
At least 3 accounts that are friends between each other and a group chat with the same 3 users
Environment: MacOS
Steps to reproduce:

Create a group chat with the 3 accounts
Login with one user and ensure the other 2 users from the group are offline
Go to sidebar and validate the indicator online for the group (it should be offline but appears as online)
Chat screen topbar however shows the group is offline
Go to edit group to see the current status of the members of the group

Note: This one might need clarification. How can we determine if a group is offline or online?
With all members online, group would be online?
Or with at least one member online, group would be online?
Or should we remove indicator online/offline from the group?
In any case, the indicator should be consistent between sidebar and topbar
Video:
https://github.com/Satellite-im/Uplink/assets/35935591/582f6252-307d-488c-9ea3-fe402f939015

i'd say we ditch the indicator 🔨
never saw any app with ''a group online'', the users in that group may be online not the group itself 😂

I agree with sara. For group chats, there shouldnt be any online/offline indicator in the sidebar or topbar since its a chat with multiple people. The drop down list showing the indicators are more than enough


HDDS-3933. Fix memory leak because of too many Datanode State Machine Thread

What changes were proposed in this pull request?
What's problem ?
Datanode creates more than 20K Datanode State Machine Thread, then OOM happened.

What's the reason ?
20K Datanode State Machine Thread were created by newCachedThreadPool

Almost all of them were wait lock.

Only one Datanode State Machine Thread got the lock, and block when submitRequest. Because this thread was blocked and can not free the lock, newCachedThreadPool will create new thread infinitely.

How to fix ?

Avoid use newCachedThreadPool, because it will create new thread infinitely, if no thread available in pool.
Cancel future when task time out.
Besides there is bug in such following code which want to loop until timeout or returned >= count.
But timeout can not work, for example when init startTime = 0 and timeLeft = 100, if monotonicNow = 10, timeLeft = 100 - (10 - 0) = 90, and then if monotonicNow = 11, timeLeft = 90 - (11 - 0) = 79 which actually should be 89.

 while (returned < count && timeLeft > 0) {
    timeLeft = timeLeft - (Time.monotonicNow() - startTime);
 }

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3933
How was this patch tested?
Existed UT.

I will check the failed ut.

Don't find any unit tests here. Would you please add some?  @runzhiwang

Codecov Report

Merging #1185 into master will increase coverage by 2.93%.
The diff coverage is 74.96%.

@@             Coverage Diff              @@
##             master    #1185      +/-   ##
============================================
+ Coverage     70.56%   73.49%   +2.93%
- Complexity     9427    10048     +621
============================================
  Files           965      978      +13
  Lines         49063    49918     +855
  Branches       4803     4848      +45
============================================
+ Hits          34620    36689    +2069
+ Misses        12137    10925    -1212
+ Partials       2306     2304       -2

Impacted Files
Coverage Δ
Complexity Δ

.../apache/hadoop/hdds/conf/HddsPrometheusConfig.java
50.00% <ø> (ø)
2.00 <0.00> (ø)

...op/hdds/utils/LegacyHadoopConfigurationSource.java
50.00% <ø> (ø)
5.00 <0.00> (ø)

.../java/org/apache/hadoop/ozone/OzoneConfigKeys.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...main/java/org/apache/hadoop/ozone/OzoneConsts.java
85.71% <ø> (+1.50%)
1.00 <0.00> (ø)

...g/apache/hadoop/hdds/conf/ConfigurationSource.java
22.72% <ø> (ø)
7.00 <0.00> (ø)

...rg/apache/hadoop/ozone/HddsDatanodeHttpServer.java
100.00% <ø> (+28.57%)
13.00 <0.00> (+4.00)

...mon/transport/server/ratis/XceiverServerRatis.java
88.10% <0.00%> (-4.50%)
62.00 <0.00> (+5.00)
:arrow_down:

...iner/ozoneimpl/ContainerScrubberConfiguration.java
81.81% <ø> (-18.19%)
7.00 <0.00> (-1.00)

...org/apache/hadoop/hdds/server/http/HttpConfig.java
76.47% <0.00%> (ø)
1.00 <0.00> (ø)

.../hadoop/hdds/scm/container/ReplicationManager.java
87.35% <0.00%> (-0.70%)
102.00 <0.00> (ø)

... and 453 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d3e52...2c381fa. Read the comment docs.

LGTM + 1.  Thanks @runzhiwang for the contribution and @xiaoyuyao for the review.


Reduce size of nodes to 2CPU/8GB RAM for trial and free plan

Description
Reduce size of nodes to 2CPU/8GB RAM for trial and free plan.
Reasons
Cost reduction.
AC

[ ] 1) apply machine type change for free plan

[ ] 1.1) deploy to dev and test
[ ] 1.2) deploy to stage and test
[ ] 1.3) deploy to prod and test

[ ] 2) apply machine type change for trial plan

[ ] 2.1) deploy to dev and test
[ ] 2.2) deploy to stage and test
[ ] 2.3) deploy to prod and test

[ ] 3) Implement the mechanism with a feature flag

The smaller machine type has also been added to Azure lite.


Fix initialization bug

Secondary constructor did not initialize the button ID so they would increment properly.

Hey Jon, thank you for pointing out the bug and even fixing it!
I wrongly remembered that the default constructor is always called, not matter what. 🤦


Making sure that a new base layer becomes visible

When switching base layers, the new base layer may previously have been out of range, in which case setVisibility(true) would do nothing if the layer was visible already. So we check if it was previously out of range, and redraw it if necessary.

This looks good Andreas, please merge.


Github Actions: also compiles some samples for a bunch of platforms

Currently, does not include iOS, but I plan to add that later.
I also consolidated everything into a single job with the operating systems added to the matrix instead of separate jobs for each operating system, which helps avoid too much duplication.

Thank you!
Looks like there was some unrelated network trouble during the Android build.

Downloading https://services.gradle.org/distributions/gradle-5.6.3-bin.zip
##[error]Exception in thread "main" javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake

Can you re-run the job? Thanks!


Save username / password

A way to store the username & password in a config file would be great  - obviously if the password could be crypted that'd be even better.

Hello,
It's a good idea. This feature is now on 1.4.0 version.
You can set your real-debrid account as enviroment variable on your ~/.bashrc
export REALDEBRID_USERNAME=your_username
export REALDEBRID_PASSWORD=your_password

Encryption will be add later ;)

Hello @jamespo,
It's a good idea. This feature is now on 1.4.0 version.
You can set your real-debrid account as enviroment variable on your ~/.bashrc
export REALDEBRID_USERNAME=your_username
export REALDEBRID_PASSWORD=your_password

Encryption will be add later ;)


Use fromThreadId on GHC >=9.8

Making use of https://github.com/haskell/core-libraries-committee/issues/117

Thanks :slightly_smiling_face:


Backport build fixes to 3.x

https://github.com/hjdivad/ember-m3/pull/1131

Added backport PR numbers to PR title

The CI fails on release/3-0-x branch as is, seems to be a dependency issue

@hjdivad CI is green


Fix #957

This is a more radical adaption of UTFEncodedString into the collection hierarchy so that most methods work exclusively with code points rather than code units. The rule is that indices used to access into a String are always code unit indices. Sizes (with the exception of the String size itself, which is a code unit count) are expressed as the number of code points. Although this does seem a bit odd on the face of it, it generally works as long as one doesn't assume that the interval between two indices is the same as the number of characters in that interval.
This does change the behaviour of some methods that may have previously returned surrogate characters, e.g. first and last, and also means that do: and other enumerations are over complete Characters.

@fxgallego, I changed your urlEncoded method.


Implement SDL-0207 RPC message protection [WIP]

Fixes Proposal 0207
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests, manual tests
Summary
Have the proxy listens to changes in encryption requirement for any RPC, start a secured service if needed and set payload protected bit accordingly.
Tasks Remaining:

[x] [Add tests]

CLA

[ x] I have signed the CLA

Codecov Report

Merging #1103 into develop will increase coverage by 0.03%.
The diff coverage is 15.55%.

@@              Coverage Diff              @@
##             develop    #1103      +/-   ##
=============================================
+ Coverage      46.74%   46.77%   +0.03%
- Complexity      4001     4016      +15
=============================================
  Files            451      453       +2
  Lines          22119    22198      +79
  Branches        2510     2525      +15
=============================================
+ Hits           10339    10383      +44
- Misses         11171    11200      +29
- Partials         609      615       +6

Impacted Files
Coverage Δ
Complexity Δ

.../com/smartdevicelink/proxy/rpc/PermissionItem.java
75% <0%> (-13.24%)
8 <0> (ø)

...smartdevicelink/proxy/rpc/OnPermissionsChange.java
76.92% <0%> (-23.08%)
5 <0> (ø)

...va/com/smartdevicelink/proxy/rpc/enums/Result.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

...n/java/com/smartdevicelink/proxy/SdlProxyBase.java
8.71% <15.78%> (+0.28%)
29 <0> (+2)
:arrow_up:

...tdevicelink/Dispatcher/ProxyMessageDispatcher.java
67.64% <0%> (-8.83%)
4% <0%> (-1%)

...java/com/smartdevicelink/managers/ProxyBridge.java
4.06% <0%> (-0.05%)
2% <0%> (ø)

...om/smartdevicelink/transport/SdlRouterService.java
11.83% <0%> (-0.01%)
20% <0%> (ø)

...vicelink/proxy/rpc/ClimateControlCapabilities.java
100% <0%> (ø)
37% <0%> (+2%)
:arrow_up:

...devicelink/proxy/rpc/RadioControlCapabilities.java
100% <0%> (ø)
31% <0%> (+2%)
:arrow_up:

.../smartdevicelink/proxy/rpc/ClimateControlData.java
100% <0%> (ø)
32% <0%> (+2%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bcb72...6047384. Read the comment docs.

@theresalech this PR is ready for review, thanks.

@theresalech this PR is ready for review, thanks.

@Tnnnguyen @mrapitis can you please confirm that this has been reviewed, tested and approved by the Ford team?  It looks like there was some back and forth on the issue, so we just want to make sure Ford has approved before Livio begins the review.  Please also advise if PR #1098 should be closed in favor of this one.  Thanks!

It looks like unit tests for PermissionItemTest.java and ResultTests.java need to be updated with the new param as well.

@smartdevicelink/android PR is ready for review, thanks!

Fixes #978

Hi @Tnnnguyen , thanks for implementing the RPC encryption PR, I just would like to point out that there are also some differences between the iOS and Java Suite PRs.
Because JavaSuite uses the LifecycleManager in a fashion similar to iOS, the solution should be implemented in a similar way. Currently, it appears as if this logic is missing from that half of the project.
Below are some pseudo-code examples on how this could be done. However, please work with your iOS counterparts to ensure a streamlined API across the platforms.
For example, the iOS added SdlEncryptionLifecycleManager which I think it is nice cause it moves the encryption logic to its own class instead of putting everything in LifecycleManager. These are some suggestions for how the encryption can be added to the LifecycleManager to align with iOS.

The logic to keep track of whether encryption is required for a specific RPC should be added to PermissionManager instead of putting it in LifecycleManager. This means LifecycleManager may need to hold a weak reference to the PermissionManager

class BasePermissionManager{
    boolean getRequiresEncryption(){}; // for app level
    boolean getRPCRequiresEncryption(@NonNull FunctionID rpcName) // for individual RPCs
 }

SdlProxyBase though, should still monitor the OnPermissionChange on its own because it cannot access the PermissionManager

iOS adds a new EncryptionLifecycleManager in the RPC protection PR:
https://github.com/smartdevicelink/sdl_ios/blob/4421fe0febd7f83b4018bee51649238dea7a95ae/SmartDeviceLink/SDLEncryptionLifecycleManager.m

To align with iOS and to keep the new LifecycleManager clean, Java Suite needs to add a similar manager:

class BaseEncryptionLifecycleManager extends BaseSubManager {
    private ISdl internalInterface;

    // The listeners should call startEncryptedRPCService() when 1- onPermissionChanged is received with encryption required in app level 2- HmiLevel is not NONE
    private OnRPCNotificationListener onHMIStatusListener, onPermissionsChangeListener;

    private ISdlServiceListener serviceListener = new ISdlServiceListener() {
        @Override
        public void onServiceStarted(SdlSession session, SessionType type, boolean isEncrypted) {

        }

        @Override
        public void onServiceEnded(SdlSession session, SessionType type) {

        }

        @Override
        public void onServiceError(SdlSession session, SessionType type, String reason) {

        }
    };

    RPCMessage prepareEncryptedRPC(RPCMessage message){
        if (isEncryptionReady){
            rpc.setProtectedPayload(true);
            retrun rpc;
        }
            return null;
    }
    void startEncryptedRPCService(CompletionListener listener);
    void stopEncryptedRPCService(CompletionListener listener);
    boolean isEncryptionReady();

    // Implement other methods from BaseSubManager if needed
}

If the developer sets rpc.setProtectedPayload(true) to force encryption for an RPC and the encryption was not enabled for that app in the PT (Encrypted RPC service is not started), the app should get onError() with a clear error message when it sends the RPC

@Tnnnguyen can you please confirm that this is ready for Livio review?

@Tnnnguyen can you please confirm that this is ready for Livio review?

@theresalech yes

@Tnnnguyen Please see the powerpoint attached from our alignment meeting on 2019-09-10.
Livio Feedback 2019-09-10; RPC Message Protection.pdf

@Tnnnguyen I updated the comments to reflect what we discussed in the alignment meeting earlier today. I apologize for any confusion caused by the previous comments.

@Tnnnguyen please advise when this is ready for re-review.

@Tnnnguyen please advise when this is ready for re-review.

@jordynmackool the Android side is ready, not the JavaSE side.

On testing the encryption flow, I run into problems, hope I can get help.
I verified my logic for starting encryption works, the security library downloads the certificate, validates it, then notify the Sdl library.  Sdl library then tries to start a secured service with Core.
From the Core side, I confirmed Core also agrees to start a secured service.
Log from Core:
SSL handshake successfully finished
then right after, Core sends an ACK message back to the Sdl library, with encryption bit being true:
SendStartSessionAck() for connection 1 for service_type 7 session_id 1 protection ON
back in the proxy, I always receive false for the encryption bit, I put a debugger on, also log all the way from the proxy through about 8 transport steps this, confirming that somehow the bit was received as false all the way, meaning the bit was not changed by the Sdl library.
@bilal-alsharifi @joeygrover

We are currently working on the open source security library in order to get you the library with enough time to test.
I suggest going back to your last commit that worked and then do a diff with your current code. If the previous commit that worked doesn't work, double check your core setup.

@BrettyWhite thanks.  I also notice a side effect, possibly a regression issue from other parts of the code that was merged in from a few develop branch merges (these are merged on Aug/26, Sep/9, Sep/10, Sep/13).
That is, we have an ISdlServiceListener listening for RPC session in the proxy.  I would get callback from this every time there is an activity on RPC session.  With the new merges from develop, I only get a callback for the first time an RPC session is started, and nothing thereafter.
I am looking into related commits from other branches that may have caused this.

To my knowledge the only recent PR that affected proxy base was: https://github.com/smartdevicelink/sdl_java_suite/pull/1161 However, these changes were all additive, so it shouldnt affect anything else

@Tnnnguyen https://github.com/smartdevicelink/sdl_java_suite/pull/1182 should fix the issue you were describing, please pull in develop and let us know. We merged it manually to your latest commit (locally) and verified it worked.


cron not running

I'm using this code to schedule a daily task to send some alert to subscribed users. I've noticed that the task is not running
const cron = require('node-cron');
cron.schedule('01 * * * *',  () => {
    console.log('Sending alert to subscribers each minute!TEST MODE ON')
    datastore.get(['_subscribers']).then(console.log)
})

I've also tried to use tha start() command but it worked only once.
I'm using it inside a telegram bot script. can be this a problem?

Your cron 01 * * * * means that you want to run this job At 1 minute every hour. Try changing the corn to */1 * * * * and see if this console the text every minute. Also, check the placement.


Rendered chart is 1 day delayed

Bug report
Rendered chart is 1 day delayed
Explanation
I'm not sure if this is a bug but the columns are rendered with delay of 1 day even though the last timestamp is "1586793600000", it's showing as april 13 and april 13 timestamp as april 12 and so on.
This is the array of data returned with ajax, as you can see all of it are valid timestamp but apex is showing it wrong when being rendered.
[1586188800000,40],[1586102400000,26],[1586016000000,2],[1586275200000,21],[1586361600000,14],[1586448000000,4],[1586534400000,4],[1586620800000,22],[1586707200000,5],[1586793600000,7]
Am I missing any configs to fix this or is this a bug? Thanks.

What is the behavior you expect?
No delay when representing timestamp arrays
What is happening instead?
1 day delay when data are getting displayed
What error message are you getting?
None

X-Axis displays datetimes in UTC by default. Try turning off the datetimeUTC https://apexcharts.com/docs/options/xaxis/


CIV-6434 assign claim to defendant

JIRA link
https://tools.hmcts.net/jira/browse/CIV-6434
Change description

make pin and post journey public (first contact pages)
redirect after idam login to assign claim to defendant and then redirect to dashboard
amend and add unit tests

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x] No

I saw in Sonar there are some methods without coverage, please check sonar result.

@LeonardoPalmeiro yes i saw Sonar. and tried to cover everything that is possible to cover. However some logic in oidc is very difficult to cover without changing it like Maro did. I am reluctant to do so. Perhaps will ask @PaulH-HMCTS advice