The shipyard tab is now empty after updating to 2.2.0

I was previously on 2.1.0 and upgraded today to 2.1.0  After getting a new ship I wanted to name it but noticed all my ships were no longer listed in shipyard.  I tried uninstalling (including deleting the %APPDATA%/EDDI folder)/reinstalling but issue persists.  Everything else works fine.   I can still travel to systems and hear it call out which system I am heading to.

Hi Larry this happened before to me, simply relog into Companion App and reenter the code given and you will find it back as it was (least it was for me the 2nd time round after rewriting all 15 names again).  Hope that helps.

Yes, that fixed it!


[CHANGE ME] Re-generated to pick up changes from self.

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/497a326d-02dd-4f32-a55b-b24f5776f2fc/targets

[ ] To automatically regenerate this PR, check this box.

This package is already published as @google-cloud/gke-hub.


Storing raw data from qiskit backend to json

Save past sampling data for later replaying.

Now the document build has been fixed in #126, I'll merge the latest main branch and check the documentation.

Can you check and fix the docstring of QiskitSavedDataSamplingBackend?
https://deploy-preview-125--quri-parts.netlify.app/quri_parts/qiskit/quri_parts.qiskit.backend.html#quri_parts.qiskit.backend.QiskitSavedDataSamplingBackend

The example is not formatted correctly. Let me fix it.

I have fixed the docstring.


augeas: add recursive search & non-standard config locations

Work in progress on improving our augeas actor.
Run augeas actor as:
snactor_runner --actors_dir src/actors/ --schemas_dir src/schemas/ augeas <<< '{"aug_input": [{"lens": "httpd", "directives": ["Include", "IncludeOptional"], "load_files": ["/opt/some_nonstandard_config.conf"], "prefix_for_relative": "/etc/httpd"}]}'
Which now tells augeas actor that is should:

take a closer look at httpd lens
take all Include and IncludeOptional directives from configs and recursively process their arguments
load into httpd lens /opt/some_nonstandard_config.conf file
use prefix /etc/httpd for all file paths that are not absolute

If you want to only tell augeas to load some non-standard files and don't care about processing directives and stuff, use:
snactor_runner --actors_dir src/actors/ --schemas_dir src/schemas/ augeas <<< '{"aug_input": [{"lens": "httpd", "load_files": ["/opt/test_httpd.conf"]}]}'
Requirements:

augeas
augeas-libs
python-augeas

@examon ha, judging by the build log we also need to install gcc and supposedly redhat-rpm-config as well.

I had to change centos6 to centos7.
When using centos6, I get
setuptools must be installed to install from a source distribution
when installing pip packages. (setuptools pkg is installed btw)
When upgeaded pip to newer version, I get this:
setuptools requires Python '>=2.7,!=3.0.*,!=3.1.*,!=3.2.*' but the running Python is 2.6.6
Centos7 has python 2.7 and it works.


Look through AD5246 data sheet to see how it’s enabled and configured for I2C

Vincent will look at the AD5246, Fernando will look at the ST one

DS1803*


Fix: Fixed issue where "Send To" submenu was sometimes not displayed on widgets

Resolved / Related Issues

[X] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #12092

Validation
How did you test these changes?

[X] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots

@hishitetsu is there a specific scenario that I should test to verify this fix?

@hishitetsu is there a specific scenario that I should test to verify this fix?

Right-click a file that has no extension.


llvm 8.0.0

When is delta going to be updated to use llvm version 8.0.0?

There's an LLVM 8.0 update commit in the llvm8 branch.

I think https://reviews.llvm.org/D57577 will fix this.
Let's hope it lands in LLVM 8.0.1.

Delta has now been updated to LLVM 9.0.0 (1c89deb0401bac3d4db547eddae854971ba0a4de).


Incomprehensible error with dynamically built URL for getJSON

This is NOT a discussion! I'm reporting an already fixed issue I had looking for a comprehensible explanation
I've been TWO DAYS trying to figure out what could possibly be wrong with a super simple code that builds <img/> tags from paths in a Data File:
{{ $paginator := (.Paginate ( where ".Params.data" "!=" nil ) ) }}

<!-- Do something with $paginator (or not) -->

{{ range $offset, $pages }}
    {{ $data := getJSON (printf "/data/%s.%s.json" (.Params.data) ($.Site.Language.Lang | default "en") ) }}
{{ end }}

Not that matters but, in any case, this is a sample of the Data File:
{
    "name": "Anything to describe the Data File itself. Not really used in the Templates",

    "picture": {
        "path": "assets/images/somepicture.jpg"
    }
}

Since I was told Paginator is static, accordingly to the syntax from the docs, by filtering out all results that do not have a specific FrontMatter Parameter — in this example, data — all Pages within the range is assumed to have it when that constructor is used (e.g. filter out in Header Partial but use it in Listing Template).
However, this fragment was constantly yielding me countless occurrences of this incomprehensible error:

Failed to create request for getJSON: parse /data/%!s().en.json: invalid URL escape "%!s"

This error occasionally was succeeded by:

Error while rendering "section" in "videos\": template: _default/list.html:164:26: executing "_default/list.html" at <getJSON (printf "/da...>: error calling getJSON: parse /data/%!s().en.json: invalid URL escape "%!s"

Which prevented me from further debugging because I couldn't read in what printf was being translated into, even though I knew which files could be the culprits (videos directory). This cut-off was in both Windows' Prompt and Log File, with or without the verbose flag
I manually checked every single Content File that should be included in the listing using the only tip I had (the videos directory) and, later, by removing each folder/files and re-adding one-by-one, but the error persisted.
Because %s, regardless the exclamation mark between them is somewhat common to other programming languages with printf support, I suspected that .Params.data had no value or could not be set somehow, even though those without it should've been filtered out way earlier in the code while defining the Paginator.
I gave it a shot, added a "fallback" Data File and changed the getJSON to:
{{ $data := getJSON (printf "/data/%s.%s.json" (.Params.data|default "fallback") ($.Site.Language.Lang | default "en") ) }}
Being fallback the mutable part of the new Data File I've added. In case of errors, the path above would then be translated to, for example, /data/fallback.en.json, in the English version of the site.
And, as expected, the problem was fixed.
But I needed to be sure so I ran the server and, once again, checked manually every single listing page, in all available languages, looking for the <img/> tag created with the fallback image I've defined in this new Data File I've added specifically for this and there wasn't even one!
I insisted and generated all HTML files to perform a global file search for the path of this fallback image and, once again, no occurrences found.
So what the hell happened with this .Params.data? Pages without it should be filtered out and even if some slipped the where routine somehow, the defaulted value should be used but it never was!
Why was it empty/undefined then?

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.

No, I won't go to the forums to discuss something that shouldn't be discussed. This is a bug I'm reporting. Wanna fix? Fine, glad to help. Otherwise just leave it be until more people suffer from the problem.


Inspiration: USAspending.gov

Recently found about https://www.usaspending.gov which is definitely a project to look up to(it's also open source). contratospr.com aims to be pretty similar but obviously scoped to Puerto Rico.
Their advanced search is what our search should aim to be like. Great balance between filtering, searching, and visualization.
Other interesting things:
https://datalab.usaspending.gov
Spending Explorer: https://www.usaspending.gov/?#/explorer
Agency Profile: https://www.usaspending.gov/#/agency/1068

I can take the first stab at this UI if it's what we want to go forward with.

As discussed with @Jpadilla1, I'm currently taking a rough stab at this and should have something to share soon.

work in progress...


TextField in RTL with multiline

I  have a problem with TextField when RTL can't remove or access the previous lines.

Hi @MahmoudMehisen
could you provide your flutter doctor -v?
I tried with current master 1.20.0-8.0.pre.125 on iOS 13.5 simulator, but couldn't reproduce. Does it happen only with real device?
Provide a complete minimal reproducible code sample if this one works correctly
import 'package:flutter/material.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TextField(
          maxLines: 10,
          textDirection: TextDirection.rtl,
        ),
      ),
    );
  }
}

Hi @VladyslavBondarenko ,
[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.19041.329], locale en-US)
• Flutter version 1.17.5 at C:\src\flutter
• Framework revision 8af6b2f038 (2 weeks ago), 2020-06-30 12:53:55 -0700
• Engine revision ee76268252
• Dart version 2.8.4
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
• Android SDK at C:\Users\mahmo\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.0
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] VS Code (version 1.47.1)
• VS Code at C:\Users\mahmo\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.12.1
[√] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
• No issues found!

Can you try this on dev channel? This may have been fixed already by https://github.com/flutter/flutter/pull/59379 but is not yet in stable.
flutter channel dev
flutter upgrade

@GaryQian  it's work thanks.


Old licensing info

https://github.com/kivy/kivy/pull/2901/files#r23507160
He mentioned finding old licensing info in 16 places.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

16 places?
We've got 10 different packages per architecture also somewhere else then debian/control?

He probably missed something.

No, he was right:
https://github.com/kivy/kivy/blob/master/kivy/tools/packaging/linux/debian/control

@thopiekar are these files usually synced with your debian branches?
https://github.com/kivy/kivy/tree/master/kivy/tools/packaging/linux/debian

Ahh ok, needs to be synced with the upstream files..

@dessant , yes, often before release. Sometimes @tito is to fast and synced afterwards ;)
When do you plan to release 1.9.0?

@thopiekar we plan it every day :D, but i'm not sure.

There should be everything you want in #2910 and #2911 ;)
But be careful there are also other changes I made which I found very useful, e.g. https://github.com/kivy/kivy/pull/2911/files#diff-b67911656ef5d18c4ae36cb6741b7965R34
It will make doc builds in different formats faster because kivy does not need to be recompiled...

Fixed, awesome job @thopiekar. :ice_cream:

Thanks :)


Link upgrade to skewed version page

It provides the order of upgrade and shows which versions are supported.
Solves (at least partially ) #14420

/lgtm
/approve


Add serdes API

It would be useful if embedders didn't need to worry about serializing and deserializing between WASI data structures and the WASM memory. For example, Node.js currently does this:
uvwasi_fdstat_t stats;
uvwasi_errno_t err = uvwasi_fd_fdstat_get(&wasi->uvw_, fd, &stats);

if (err == UVWASI_ESUCCESS) {
  wasi->writeUInt8(memory, stats.fs_filetype, buf);
  wasi->writeUInt16(memory, stats.fs_flags, buf + 2);
  wasi->writeUInt64(memory, stats.fs_rights_base, buf + 8);
  wasi->writeUInt64(memory, stats.fs_rights_inheriting, buf + 16);
}

The wasi->write*() calls could be replaced with a uvwasi_serdes_write_fdstat_t(memory, stats, buf).
Another option could be to provide wrappers for each function (uvwasi_serdes_fd_fdstat_get(), etc.). This would take care of bounds checking, reading from memory, executing the WASI API calls, writing back to memory, and forwarding the correct return value. This would be the simplest thing for embedders, but would also require a wrapper function for every WASI API call.
Potentially useful reference: https://github.com/WebAssembly/tool-conventions/blob/master/BasicCABI.md
Any thoughts or opinions from others?

I think the first option sounds better to me, simply because we won't need an additional layer for every single call. Having uvwasi_serdes_write_* seems like a good idea!

https://github.com/cjihrig/uvwasi/pull/94 has landed, but I'm leaving this open, as there are still a few things I'd like to address in the new serdes API:

It looks like #94 didn't include support for uvwasi_ciovec_t and uvwasi_iovec_t.
It would be nice to support serializing/deserializing arrays, which ends up overlapping a lot with item 1.


[TE] Yyuen/rootcause integration branch

/!\ DO NOT MERGE.
This is an integration branch for testing purposes.
What's new:

added tabs in legacy and ember app
redirected anomaly URL to new root cause
redirected link from search page to new root cause

Closing this since this got merged https://github.com/linkedin/pinot/pull/2512


Trying to increase timeouts for the search to be successful.

Pull Request Test Coverage Report for Build 2460

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.643%

Totals

Change from base Build 2455:
0.0%

Covered Lines:
9183

Relevant Lines:
13378

💛  - Coveralls


Add ancillary data download functionality

Adds the ability to download Sentinel-1 orbits and auxiliary calibration files.
The s1_auxcal test is slow because it downloads/extracts the data from the ESA archives. Might want to consider adding a pytest marker so it is only run during integration testing.

@jhkennedy or @jtherrmann this is ready for review!


TypeError: Cannot read properties of undefined (reading 'allPermissions')

Hi @Lith ,
Do you know what happened to my media?
I'm using Strapi v4.0.5 recently
My media show blank out page

Maybe you can help me, what happened to my app?
Thanks in advance

Hi @PandhuWibowo
The error message is displayed a "permissions media error", have you enabled right with permissions plugins for your user ?
Also, this problem need to be report to Strapi team, because my plugins concern upload system but not the upload management.
Thanks ☺


keyhunt speed with different k

Hi,
About the keyhunt speed,  I tried the new version on an ubuntu with 128GB real mem.
when I use k=4096, it shows ~1 Ekey/s。
and i use k=8192, it still shows ~1 Ekey/s, I think here the number should be doubled?
thanks
-------------------k=4096--------------------------------------------
[+] Version 0.2.230519 Satoshi Quest, developed by AlbertoBSD
[+] Random mode
[+] K factor 4096
[+] Stats output every 10 seconds
[+] Threads : 28
[+] Quiet thread output
[+] Mode BSGS random
[+] Opening file tests/125.txt
[+] Added 1 points from file
[+] Bit Range 125
[+] -- from : 0x10000000000000000000000000000000
[+] -- to   : 0x20000000000000000000000000000000
[+] N = 0x100000000000
[+] Bloom filter for<PHONE_NUMBER>4 elements : 58890.60 MB
[+] Bloom filter for 536870912 elements : 1840.33 MB
[+] Bloom filter for 16777216 elements : 57.51 MB
[+] Allocating 256.00 MB for 16777216 bP Points
[+] Reading bloom filter from file keyhunt_bsgs_4_17179869184.blm .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_6_536870912.blm .... Done!
[+] Reading bP Table from file keyhunt_bsgs_2_16777216.tbl .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_7_16777216.blm .... Done!
[+] Total<PHONE_NUMBER>316722184192 keys in 2940 seconds: ~1 Ekeys/s<PHONE_NUMBER>393442919 keys/s)
-------------------k=8192--------------------------------------------
[+] Version 0.2.230519 Satoshi Quest, developed by AlbertoBSD
[+] Random mode
[+] K factor 8192
[+] Stats output every 10 seconds
[+] Threads : 28
[+] Quiet thread output
[+] Mode BSGS random
[+] Opening file tests/125.txt
[+] Added 1 points from file
[+] Bit Range 125
[+] -- from : 0x10000000000000000000000000000000
[+] -- to   : 0x20000000000000000000000000000000
[+] N = 0x100000000000
[+] Bloom filter for<PHONE_NUMBER>8 elements : 117781.20 MB
[+] Bloom filter for<PHONE_NUMBER> elements : 3680.66 MB
[+] Bloom filter for 33554432 elements : 115.02 MB
[+] Allocating 512.00 MB for 33554432 bP Points
[+] Reading bloom filter from file keyhunt_bsgs_4_34359738368.blm .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_6_1073741824.blm .... Done!
[+] Reading bP Table from file keyhunt_bsgs_2_33554432.tbl .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_7_33554432.blm .... Done!
[+] Total<PHONE_NUMBER>49049182208 keys in 420 seconds: ~1 Ekeys/s<PHONE_NUMBER>640593290 keys/s)

Check this part of the README:
https://github.com/albertobsd/keyhunt#what-values-use-according-to-my-current-ram
Basically for values for k above 4096 you need to start changing the -n value also
64 GB -n 0x100000000000 -k 4096

128 GB -n 0x400000000000 -k 4096

Hello .
Is there any difference with which parameters to note this  -n 0x1000000000000 -k 4096 or -n 0x10000000000000000 -k 32

Check this part of the README:
https://github.com/albertobsd/keyhunt#what-values-use-according-to-my-current-ram
Basically for values for k above 4096 you need to start changing the -n value also
64 GB -n 0x100000000000 -k 4096

128 GB -n 0x400000000000 -k 4096

Hello .
Is there any difference with which parameters to run the program -n 0x1000000000000 -k 4096 or -n 0x100000000000000000 -k 32?

Hello . Is there any difference with which parameters to run the program -n 0x1000000000000 -k 4096 or -n 0x100000000000000000 -k 32?

if you have doubts check the amount of size reserver for Main bloomfitler, yes they are different check, the first option use almost 256 GB and the other one use near two TeraBytes:
./keyhunt -m bsgs -f tests/125.txt -b 125 -q -s 10 -R -S -n 0x1000000000000 -k 4096 -t 8 -6
....
[+] Bloom filter for<PHONE_NUMBER>6 elements : 235562.39 MB
[+] Bloom filter for<PHONE_NUMBER> elements : 7361.33 MB
[+] Bloom filter for 67108864 elements : 230.04 MB
[+] Allocating 1024.00 MB for 67108864 bP Points

./keyhunt -m bsgs -f tests/125.txt -b 125 -q -s 10 -R -S -n 0x100000000000000000 -k 32 -t 8 -6
[+] Bloom filter for<PHONE_NUMBER>88 elements : 1884499.12 MB
[+] Bloom filter for<PHONE_NUMBER>4 elements : 58890.60 MB
[+] Bloom filter for 536870912 elements : 1840.33 MB
[+] Allocating 8192.00 MB for 536870912 bP Points

Check this part of the README:
https://github.com/albertobsd/keyhunt#what-values-use-according-to-my-current-ram
Basically for values for k above 4096 you need to start changing the -n value also
64 GB -n 0x100000000000 -k 4096

128 GB -n 0x400000000000 -k 4096

./keyhunt -m bsgs -f tests/125.txt -b 125 -R -s 10 -t 28 -S -q -n 0x400000000000  -k 4096
hi, it's 3Ekeys/s , thanks!
[+] Version 0.2.230519 Satoshi Quest, developed by AlbertoBSD
[+] Random mode
[+] Stats output every 10 seconds
[+] Threads : 28
[+] Quiet thread output
[+] K factor 4096
[+] Mode BSGS random
[+] Opening file tests/125.txt
[+] Added 1 points from file
[+] Bit Range 125
[+] -- from : 0x10000000000000000000000000000000
[+] -- to   : 0x20000000000000000000000000000000
[+] N = 0x400000000000
[+] Bloom filter for<PHONE_NUMBER>8 elements : 117781.20 MB
[+] Bloom filter for<PHONE_NUMBER> elements : 3680.66 MB
[+] Bloom filter for 33554432 elements : 115.02 MB
[+] Allocating 512.00 MB for 33554432 bP Points
[+] Reading bloom filter from file keyhunt_bsgs_4_34359738368.blm .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_6_1073741824.blm .... Done!
[+] Reading bP Table from file keyhunt_bsgs_2_33554432.tbl .... Done!
[+] Reading bloom filter from file keyhunt_bsgs_7_33554432.blm .... Done!
[+] Total<PHONE_NUMBER>9120608256 keys in 10 seconds: ~3 Ekeys/s<PHONE_NUMBER>9120608
[+] Total<PHONE_NUMBER>1361988608 keys in 20 seconds: ~3 Ekeys/s<PHONE_NUMBER>5680994
[+] Total<PHONE_NUMBER>12861714432 keys in 30 seconds: ~3 Ekeys/s<PHONE_NUMBER>428723
[+] Total<PHONE_NUMBER>83014262784 keys in 40 seconds: ~3 Ekeys/s<PHONE_NUMBER>075356569 keys/s)

Hello . Is there any difference with which parameters to run the program -n 0x1000000000000 -k 4096 or -n 0x100000000000000000 -k 32?

if you have doubts check the amount of size reserver for Main bloomfitler, yes they are different check, the first option use almost 256 GB and the other one use near two TeraBytes:
./keyhunt -m bsgs -f tests/125.txt -b 125 -q -s 10 -R -S -n 0x1000000000000 -k 4096 -t 8 -6
....
[+] Bloom filter for<PHONE_NUMBER>6 elements : 235562.39 MB
[+] Bloom filter for<PHONE_NUMBER> elements : 7361.33 MB
[+] Bloom filter for 67108864 elements : 230.04 MB
[+] Allocating 1024.00 MB for 67108864 bP Points

./keyhunt -m bsgs -f tests/125.txt -b 125 -q -s 10 -R -S -n 0x100000000000000000 -k 32 -t 8 -6
[+] Bloom filter for<PHONE_NUMBER>88 elements : 1884499.12 MB
[+] Bloom filter for<PHONE_NUMBER>4 elements : 58890.60 MB
[+] Bloom filter for 536870912 elements : 1840.33 MB
[+] Allocating 8192.00 MB for 536870912 bP Points

I apologize for the confusion, I gave these figures for clarity. I meant that I can increase the value of n, but decrease k. You can, on the contrary, increase the value of k, but decrease the value of n and get the same amount of used RAM. So if there is any difference in these options, which one is better to use?

I apologize for the confusion, I gave these figures for clarity. I meant that I can increase the value of n, but decrease k. You can, on the contrary, increase the value of k, but decrease the value of n and get the same amount of used RAM. So if there is any difference in these options, which one is better to use?

Ok, i got you point now...
There are some combinations of K and N that use the same amount of memory (same amount on each bloomfilter and table).
if the those values are the same the speed will be the same, and the result also will be the same,
The only difference is that bigger N with lower K (or not K default value 1) take a little more of time to update the speed counters, while the lower N with some big K update it more offten, but the average final speed will be the same.

I apologize for the confusion, I gave these figures for clarity. I meant that I can increase the value of n, but decrease k. You can, on the contrary, increase the value of k, but decrease the value of n and get the same amount of used RAM. So if there is any difference in these options, which one is better to use?

Ok, i got you point now...
There are some combinations of K and N that use the same amount of memory (same amount on each bloomfilter and table).
if the those values are the same the speed will be the same, and the result also will be the same,
The only difference is that bigger N with lower K (or not K default value 1) take a little more of time to update the speed counters, while the lower N with some big K update it more offten, but the average final speed will be the same.

In order not to produce new topics, I'll ask here. How are addresses loaded into RAM? For example, after your keysubtracter program, I will get, for example, 5 million keys, but they are loaded very slowly, why is that?

input file reading is single thread, also the program need internally calculate the full key, if the input is compressed publickeys it need to calculate the Y value, maybe the program will be a little faster if you only provide uncompressed publickeys. Let me think if i can add some multithread to that part but the code is already very complex.
I will think in that.


possibility with eastl container compatibility ?

it's possible to let the user choose between stl to use ? like https://github.com/electronicarts/EASTL
I didn't benchmark yet but i think for the registry etc he can be a great choice for the users with cmake may be like -DENTT_USE_EASTL_LIBRARY, it's just an idea, may be you want to avoid dependencies as your maximum and i understand this point of view !

Does EASTL offer all the stuff EnTT uses from the standard template library? I mean: vector, shared_ptr, unique_ptr, forward, move, and so on... pretty much all what you can find searching for std:: (I'm not a fan of using namespace directives). I've never used EASTL before, so I'm not sure about it, but this is the first point if we want to try it.

So, I was looking at EASTL myself a few days ago (and was actually wondering about EnTT compatibility too, so I peeked at the code). From what I can tell, EASTL is mostly a drop-in replacement for common stuff. It adds some additional methods here and there and it adds a ton of new containers, it also has its own stuff for memory management/pooling, but the core STL API's remain intact as far as I can see.
So, theoretically, it would be a matter of typedef'ing the std:: types and then using preprocessor directives to select between std:: and eastl:: containers.
I'm pretty sure that everything up to C++17 is supported, or at least, most stuff. I would guess everything EnTT needs is, anyway, but I guess we won't know until somebody tries.
I'd be happy to give a proof of concept a shot once I get around to trying out EASTL for my own project, but it may take me a few weeks depending on how busy I am with other stuff.

Ok, I just took a quick look at EASTL: it does have support for vector (and pretty much all other containers and then some, including intrusive versions of the containers), shared_ptr, unique_ptr, forward and move (and therefore presumably everything else EnTT needs). It does define its own eastl::forward and eastl::move though, which it does because EASTL is designed to work in pre-C++11 codebases too (in which case those functions are no-ops), but the C++11 and beyond implementations look to be the same as the std ones. I'm unsure if everything in std:: should be typedef'd and replaced with eastl:: or not though... (Need to check how compatible they are too, I wonder if #define std eastl would work?)

maybe i will give a try this week, and will try common things if i can get entt to compile, but if it's work the interesting part should be the benchmarking with entt/eastl vs entt/stl

I am currently doing a c++ engine based on the sfml, with the objective of performance, I planned to use eastl, entt, sfml, speedlog, sol2, box2d, I really think that eastl is something to think more and more in video games, because they have worked a lot on the performance of their containers, and combined with the intelligence of the project that is ENTT I'm sure we would arrive at something incredible.

@danielytics

I wonder if #define std eastl would work?

My two cents: it doesn't look like a good idea to abruptly replace std with eastl. :-)
@Milerius @danielytics

maybe i will give a try this week, and will try common things if i can get entt to compile, but if it's work the interesting part should be the benchmarking with entt/eastl vs entt/stl

I'd be happy to give a proof of concept a shot once I get around to trying out EASTL for my own project, but it may take me a few weeks depending on how busy I am with other stuff.

It would be great if you can try to integrate EASTL and then you came up with some benchmarks, before to start working on it my side. Help on this is appreciated, my free time isn't that much unfortunately.
Keep in mind also that I'm planning to use the pmr:: namespace from the standard template library (C++17) to introduce custom allocators within EnTT, so everything must be designed carefully not to make the maintenance of the project a hell in future.

seems to have an equivalent in eastl no ?

I don't think they are the same thing. What I want to put in a dedicated file is a container (namely a vector-like class) where keys are types instead of indexes. That is pretty much what I'm using within the registry to keep track of the pools of components.
Maybe the comment in the TODO file ins't that clear but, well... it's me writing down some notes, I didn't think users would have read it so carefully after all!! :-)

im working on something like this, i think it's a better approach than macros:
#ifdef ENTT_USE_EASTL
#include <EASTL/vector.h>
#include <EASTL/tuple.h>
namespace entt
{
    namespace stl
    {
        template<typename T>
        using vector = eastl::vector<T>;

        template<typename ...T>
        using tuple = eastl::tuple<T...>;

    }
}
#else
#include <vector>
#include <tuple>
namespace entt
{
    namespace stl
    {
        template<typename T>
        using vector = std::vector<T>;

        template<typename ...T>
        using tuple = std::tuple<T...>;
    }
}
#endif

My two cents: it doesn't look like a good idea to abruptly replace std with eastl. :-)

I meant as a proof of concept, to test compatibility.

@Milerius The sole drawback I see with this approach is that it's pretty annoying to add a third alternative in case it happens sooner or later.

You might be able to use namespace aliases (I completely forgot these things existed until now!).
#ifdef ENTT_USE_EASTL
#include <EASTL/vector.h>
#include <EASTL/tuple.h>
namespace entt
{
    namespace stl = eastl;
}
#else
#include <vector>
#include <tuple>
namespace entt
{
    namespace stl = std;
}
#endif

That way you avoid declaring everything individually. So if you wanted to add a third stl, you would just have to #include all of the required headers.

yeah you should go on something like that ! great idea i'm busy until the end of this week, will give a try next week

@Kerndog73 @Milerius
It would be great if one of you can benchmark it and see if it's worth it in terms of performance.
My only concern is that std:: and stl are really close to each other and it's easy to make a mistake while developing EnTT. Probably we should find a better name for the namespace, even though I've not a good one to propose.
What about?

@skypjack you can use a longer word like standard_library:: if you care about meaning, i mean when you ask about benchmarks we can but we have lot of benchmarks stl vs eastl free over the web right now. But in case of EnTT, which kind of benchmarks you want to try ? Iteration ? Entity Creation, etc ?

Well, out of curiosity, what's in the benchmark dir would be enough for me actually. :-)

https://rawgit.com/electronicarts/EASTL/master/doc/EASTL Benchmarks.html

It might be a good idea to do EnTT's own benchmarks with std vs eastl. That would involve integrating EASTL with EnTT in whatever way is easiest. I don't have time to do that though. I might be able to in a few days if no one else does.

Any news on this?
If someone is willing to try it, I can leave the issue open.
Otherwise, I prefer to put a note in the TODO list and close it.
Let me know. Thank you.

as i say, i did the last benchmark, but currently i'm to busy to try an implementation for EnTT, may be you can put it in note, and we will try it soon

I’d say leave it open for a little while longer. I’ll be happy to give it a try, but it may be a few more days before I have time to take a look. Maybe check again in a week and if there’s no progress made, then you can add to the TODO list and close this?

@danielytics We have a deal. :+1:

I put an eye on this. Is it mandatory to include EASTL stuff using its full path?
I mean, could we use this:
#include <vector.h>

Instead of this:
#include <EASTL/vector.h>

Well, technically it's possible, quite obvious. What I'm asking is if everything works fine if I use path_to_eastl/include/EASTL/ as an include path instead of path_to_eastl/include/.
This would drastically reduce the amount of code to maintain and the change wouldn't have a great impact. My only concern is about the fact that EASTL uses internally EASTL/ to refer to itself and therefore it wouldn't work (ok, I can check it myself, but I'm from mobile, so...).
Is this the case?

I see a problem with replacing everything and just use another namespace.
My idea was to rely on pmr:: namespace to make EnTT allocator-aware. However, I just saw that EASTL doesn't offer the same functionalities.
The risk is to end with two branches and therefore two implementations of EnTT to maintain. :-(

pmr:: is not perfect, may be we should have a discussion on the usefullness of PMR for EnTT

Sure, feel free to contact me by mail (you can find it in the profile) and let's discuss about EnTT.
It's always a pleasure for me to talk about this project!! I really love it.

@Milerius @danielytics Any news on this? I suspect it conflicts also with #93, even though I'm not that sure and I cannot check it right now (I'm from mobile).

Unfortunately I still haven’t had the time. If you want to go ahead and close this now, go ahead and I or @Milerius can reopen it when either of us finally get to trying this out.

@danielytics Unfortunately it's not only a matter of going ahead or not.
Supporting EASTL is somehow incompatible with #94 (there is nothing like std::execution::par in EASTL as far as I can see) and with pmr:: (of course, I'm not sure I'll use pmr:: but it's a fact). In general, we cannot develop EnTT in a way that just works out of the box both with the standard library and with EASTL. It requires a bunch of ifdef all around and some functionalities will be available only with the standard library, some others only with EASTL, and so on.
I'm not that sure it's worth it and a POC would help clarifying it.
To be clear, it's tempting to create a library that offers multiple backends and I'd be glad to work on it full-time, but I'm doing all of this in the free time and developing two branches would slow down everything. It's already quite a hell to make EnTT available for the three major compilers, trust me!! :-)

@skypjack Sure. Do what you gotta do! My own personal views are below, although they probably aren't too relevant to EnTT as a tool, which should probably stay generic and 3rd party library agnostic.
For my own personal use, C++17 is still too new sadly, so I'm not personally particularly interested in pmr for now.
I also like EASTL since its been designed specifically for use in games, but of course, for a general purpose library such as EnTT, it doesn't make sense to rally behind a third party lib over the language standard library, so I totally understand why you may want to stick with pmr.
As for parallelism, again, personally, I don't have much use for std::execution::par because:

I don't have much (easy, at least) control over the parallelism (technically, I can create my own executors and then tell the loop to execute on that executor, but that again complicates the EnTT API)
I either need to make sure to only modify each component from one place or I need to implement synchronisation
I want a proper task/job system rather than just parallel each function anyway and would rather tightly integrate with that

Therefore, again, personally, I don't really care for or want any special support in EnTT itself and instead want it to let me work with other task-based tools (eg Intel's TBB) so that I can build my own custom task-based execution mechanisms where I can tightly control how things are executed (and how and when components get written to).
That's how I plan to use EnTT and not really a reason not to support standard library functionality. If others find it useful to be able to loop through entities in parallel and its not hard to implement (seems its not hard!) then EnTT should absolutely support that. I'm just stating why its not something I need.
Given that I'm already on board with EASTL's memory management (and don't yet know enough about pmr to use it), that I want to use a full blown job/task system over simple parallel loops and that EASTL promises to have more performant containers than STL, I'm still interested in a proof of concept for this, even if its a fork/branch that isn't ever merged back in.

@danielytics Got your point. Thank you.

I want a proper task/job system rather than just parallel each function anyway and would rather tightly integrate with that

This sounds like something we could implement in EnTT too. If you ever find the time to talk about it, feel free to write me a mail... :-)

@danielytics I'm waiting for your mail, don't forget it!! It looks like you had a good idea about something to include in EnTT.
Meanwhile, I'm closing this issue because currently nobody can work on it and there are several problems that I'm not sure we can overcome. I added a note to the TODO file about EASTL. I'll have a try with it in future, but I cannot guarantee it will be integrated in EnTT.
Feel free to reopen this issue if you find the time to test it and you come up with a good idea on how to integrate it.
Thank you all for the interesting discussion.

@skypjack I want to experiment a little more and solidify what I want. Ideally, I'd like to implement a demo of how I want to use EnTT and then we can discuss if there's a better way or if there's something EnTT could add to make it play nicer, but I'd like to try it out properly first. I'll email you once done.


Single Manufacturer list

Create a single manufacturer list - perhaps for specific modalities, perhaps for all modalities?

I went back and forth on proposing this @saskiad. Having very specific manufacturer lists is nice for validation (e.g. you can't pick an ephys manufacturer for a camera filter). But it's also a hassle.
I think my vote is single manufacturer list.  It's really not that long of a list and will be nice to have in one place.


AQAvit meeting: Nov 17, 2021

Join via https://bluejeans.com/724807178/2833?src=calendarLink
Add the recurring bi-weekly AQAvit meeting to your calendar.
Proposed Agenda:

Outreachy contribution period summary and next steps in the Outreachy timeline
Updates on Reproducible Tests EPIC
AOB

Cancelling Nov 17th meeting, will reconvene on Dec 1st.

Meeting recording link
Minutes:

Renfei demonstrated the Dynamic compilation work that will improve our test compilation time and make our regular test runs more efficient.  It is also a simplification for developers (who no longer need to supply a BUILD_LIST variable in order to determine what needs to be compiled.
CanOSP term ending (focus on Reproducible tests, thanks to their efforts, 90% of that effort completed by our 3 CanOSP students... )
Outreachy term beginning - 2 of the 3 Outreachy projects are in AQAvit, Tether and Perforama, welcome to the interns who will be working on those projects.

Will resume regular calls in January 2022.


Create lome-bs.txt

@potchjust I have to close the request without merging. Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Add disposables to context.subscriptions

This PR adds disposables to context.subscriptions instead of a separate array that is manually disposed of in the deactivate() function.
The contents of context.subscriptions are automatically disposed of when the extension is deactivated. Source
Signed-off-by: David Kwon<EMAIL_ADDRESS>

And notably, this PR deals with the debug.onDidTerminateDebugSession disposable properly.
Instead of doing:
disposables.push(debug.onDidTerminateDebugSession(async (debugSession: DebugSession) => {}, null, disposables));
this PR does:
context.subscriptions.push(debug.onDidTerminateDebugSession(async (debugSession: DebugSession) => {}));


Backport: error "ClassName does not match" when creating PVC for existing PV using the Rancher 2.1.8 UI

Backport https://github.com/rancher/rancher/issues/19578

Can be tested with v2.2.3-rc4


rasterific-svg-0.3

Looks like we're just waiting for the rest of @Twinside's latest stuff to be released.
rasterific-svg-0.3 depended on by:

[ ] asciidiagram-<IP_ADDRESS> (>=0.2.3 && < 0.3). Vincent Berthoux<EMAIL_ADDRESS>@Twinside

svg-tree-0.3.2 depended on by:

[ ] rasterific-svg-0.3 (>=0.4.1 && < 0.5). Vincent Berthoux<EMAIL_ADDRESS>@Twinside

Yep sorry, I still need to update asciidiagram, I'll update soon


AxisValuesOverrider causes incorrect start-axis values

Describe the bug
Using AxisValuesOverrider.adaptiveYValues() with few values ( < 5) is causing the start axis to move below the bottom axis in certain cases.
Module

[X ] compose
[X ] views
[ ] compose-m2
[ ] compose-m3
[ ] core (select if none of the above apply)

To reproduce
Set GENERATOR_X_RANGE_TOP = 3 in the ShowcaseViewmodel.kt of the sample app.
Build and run the app, the visual bug can be seen in the third sample chart (second on the screenshot), for both Compose and Views.
Expected behavior
The guidelines should show up correctly i.e. they should span the full start-axis and not move below the bottom axis.
Screenshots

Android versions
Android 13
Additional context
This didn't happen in previous versions, I've upgraded from 1.6.6 to 1.9.1

Hello! Thanks for the bug report. Vico 1.9.2, which is now rolling out, resolves this issue.

You are amazing, thanks!

Thanks again for the report!


using wms sample in osm

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack
(feel free to delete whatever doesn't apply)
Issue Type
[ ] Question
[ ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation
Description and/or steps/code to reproduce the problem
Environment
If it's a bug, version(s) of android this affects:
All
Version of osmdroid the issue relates to:
5.6.5

What is the problem?

@sheeranahmedsheikh need more info


Add test entries to flash blocking lists

This commit adds the URLs to the lists that are needed for Flash blocking testing.

I configured my local lists2safebrowsing.py script to use these files and saw the expected output:
Plugin blocklist(flash-blocklist): publishing 1 items; file size 51
Plugin blocklist(flash-exceptions): publishing 1 items; file size 51
Plugin blocklist(flash-allow): publishing 1 items; file size 51
Plugin blocklist(flash-allow-exceptions): publishing 1 items; file size 51
Plugin blocklist(flash-subdoc): publishing 1 items; file size 51
Plugin blocklist(flash-subdoc-exceptions): publishing 1 items; file size 51

I will merge here and check the output of the next ShavarListCreationStage job.

ShavarListCreationStage job output looks right too ...
Plugin blocklist(flash-blocklist): publishing 1 items; file size 51
Plugin blocklist(flash-exceptions): publishing 1 items; file size 51
Plugin blocklist(flash-allow): publishing 1 items; file size 51
Plugin blocklist(flash-allow-exceptions): publishing 1 items; file size 51
Plugin blocklist(flash-subdoc): publishing 1 items; file size 51
Plugin blocklist(flash-subdoc-exceptions): publishing 1 items; file size 51


Obsolete classes

Move Visualizers.Advanced.DoubleArrow into obsolete, use Arrow or Vector(torque) instead - depending on the resolution of https://github.com/modelica/ModelicaStandardLibrary/issues/3931

This issue moved into #189


Catalog page content not updating when picking new catalog from dropdown.

Rancher versions:
rancher/server: v1.6.6
rancher/agent: v1.2.5
Docker version: (docker version,docker info preferred)
1.12.6 / 17.06-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 16 / RHEL7.3
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
vmware
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
cattle
Steps to Reproduce:
Navigate to main catalog page, choose any catalog item and click "view details".  Now, from the "Catalog" drop-down menu in the upper left, choose any catalog item.
Results:
Notice that the main info and form fields are for the previously selected catalog item, but the newly chosen catalog item logo and info is displayed.

Is this a custom catalog? If so,  is it hosted on github as a public repo or is it hosted somewhere else?

No, these are just the default public catalogs.

#6470


Install of librealsense-uvcvideo install on clean Ubuntu 16.04.03 Fails

Required Info

Camera Model
D415

Firmware Version
Out of box

Operating System & Version
Ubuntu 16.04.3 dist-upgraded on 1/18/18

Kernel Version (Linux Only)
4.13.0-26-generic #29~16.04.2-Ubuntu SMP Tue Jan 9 22:00:44 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

SDK Version
2.0

I attempted to install my new D415 onto a clean Ubuntu 16.04.03 desktop that had been dist-upgraded, and the installation failed. Here are the steps I followed, and I've attached the output from apt-get and the contents of the make.log file with the details.
I got my D415 out of the box, and followed the instructions from realsense.intel.com/develop/d400/get-started. I following the link to https://github.com/IntelRealSense/librealsense/blob/development/doc/distribution_linux.md, then configured the Realsense repository, registered the key, and ran sudo apt-get update.
I then tried to install the first Realsense package using  sudo apt-get install realsense-uvcvideo, and it failed. The output of the failure and the output of the failed compilation of uvc_driver.c are attached.
Any workarounds, fixes, or suggestions to get this running in Linux?
Jim
apt-realsense-uvcvideo-install.log
uvc_driver_make.log

Same issue using Debian 4.9 and 4.14 kernels, apt output:
DKMS make.log for realsense-uvcvideo-4.10.0 for kernel 4.14.0-3-amd64 (x86_64)
vie feb  9 00:16:56 CET 2018
make: se entra en el directorio '/usr/src/linux-headers-4.14.0-3-amd64'
AR      /var/lib/dkms/realsense-uvcvideo/4.10.0/build/drivers/media/usb/uvc/built-in.o
CC [M]  /var/lib/dkms/realsense-uvcvideo/4.10.0/build/drivers/media/usb/uvc/uvc_driver.o
CC [M]  /var/lib/dkms/realsense-uvcvideo/4.10.0/build/drivers/media/usb/uvc/uvc_queue.o
/var/lib/dkms/realsense-uvcvideo/4.10.0/build/drivers/media/usb/uvc/uvc_driver.c: In function ‘uvc_probe’:
/var/lib/dkms/realsense-uvcvideo/4.10.0/build/drivers/media/usb/uvc/uvc_driver.c:2065:12: error: ‘struct media_device’ has no member named ‘driver_version’; did you mean ‘driver_name’?
dev->mdev.driver_version = LINUX_VERSION_CODE;
^~~~~~~~~~~~~~
driver_name
driver_version member has been removed :
https://github.com/torvalds/linux/commits/master/include/media/media-device.h

[Realsense Customer Engineering Team Comment]
Hi @jallard-sr
Still need any further help for your build system?
Hi @mpperezH
With kernel 4.14 there should be no need for additional patches to stream D415. Our test configuration is Ubuntu 16.04.3 + kernel 4.14.15.

I do not require hardware timestamps on images, so I do not need the problematic uvcvideo patches. I'm successfully streaming color and depth on Ubuntu 16.04.4.

I will just jump in and report that I had no issues installing realsense-uvcvideo on kernel 4.14.13-041413-generic with Ubuntu 16.04.4
realsense-uvcvideo is already the newest version (1.1.0-0ubuntu3).

Hi, what is the difference between realsense-uvcvideo and librealsense2-dkms?
Thank you.


Remove unneeded encapsulation of Concerto / Concerto Tools

Ergo/Cicero use an uncommon idiom of packaging a dependency (composer-concerto and composer-concerto-tools) to avoid problems with multiple versions of the concerto package.
The corresponding code is at: https://github.com/accordproject/ergo/blob/66feaf68fda20fed3cc8d01ba9e5c08c1b565984/packages/ergo-compiler/index.js#L22
This can be removed whenever the corresponding issues has been resolved: https://github.com/hyperledger/composer-concerto/issues/47 and

This work can proceed now that @accordproject/concerto is out

Sorry for asking this, but is removing those requires the only thing to be done? I'm trying to understand so I can work on it.

Once it is removed, every place using the exported module.exports.ComposerConcerto will break, so should be replaced by a proper import of the composer-concerto package itself. I'm afraid this particular issue cannot be fixed on master which still uses an older version of concerto.
I'm afraid this particular issue can only be fixed on master which still uses an older version of Concerto. So I've re-labelled it for the 0.20-alpha release and removed the Hacktoberfest tag.

PRs on this are still welcome, obviously! 😃

Fixed in 0.20 branch


don't localize tag attributes values

Hi,
Since latest commits, DecimalField (and FloatField I guess) have min, max and step properties. Step property use the decimal_place attribute.
However, attribute values are rendered with the template engine. And if settings USE_L10N=True, any values would be localized by default.
As a consequence, with the French language enabled, we would got a HTML tag attribut step=0,01. With Chrome at least, this could be invalid and round the step to integer!
I think that we should do the same thing for any attributes: force them to don't be localized.
However, a special note should be throw to other users implementing their own attrs.html template because they may update it too (if using l10n and applying the default behaviour, which is to localize any values).
Thanks

Awesome! Thanks so much. Good catch.
This is part of the just released version 1.5.2: https://pypi.python.org/pypi/django-floppyforms/1.5.2


Use Atoms Docks API for our panels

Atom 1.17 introduced a new docks API (Used by the tree view, GitHub and Linter packages).
We should use it as well. This will allow us better work in conjunction with other packages and makes our panels more flexible.

[ ] Inspector
We should do this first since it's simpler to implement with less refactorings and we can get rid react-resizable-box then.
[ ] Watch Sidebar

Relevent resources:

http://blog.atom.io/2017/05/16/atom-1-17.html
http://flight-manual.atom.io/hacking-atom/sections/package-active-editor-info/
https://atom.io/docs/api/v1.17.0/Dock

Example PRs from other projects:

https://github.com/atom/tree-view/pull/1056
https://github.com/steelbrain/linter-ui-default/pull/256 and https://github.com/steelbrain/linter-ui-default/pull/302
https://github.com/atom/github/pull/664

I will start working on this issue. I think we should ship a release before we finish this due to the atom v1.17 dependency. This way holdouts can still get the new result and watch-views!

Even more information on the Atom blog: http://blog.atom.io/2017/05/23/docks-deep-dive.html

I refactored the Watch Sidebar as a react component so we can easily use it in a dock.
@BenRussert I'd happy to pair with you in the next few days and move our panels to docks.


Custom Validation for checking roles and permission

How do I use $user->can('edit-user'); in a custom validator.
I want to check if user has permission (edit-user) using validator class as I am passing validation array to my views to dump any errors if validation fails.

User permissions are usually independent of form input so a validator is not an appropriate place to check them.


Documentation link in Craft CMS backend

A nice easy one for you, the documentation link in the backend of Craft points to:
https://github.com/aelvan/imager/blob/craft3/README.md
And just needs updating to:
https://github.com/aelvan/Imager-Craft

Thanks! This has actually been updated in the latest commit, it's just not visible yet since I haven't tagged a new version. It'll be fixed when the next version is pushed.


Dropdown calendar hangs off the screen in mobile

I adjusted ul.dropdown-menu and attempted to center it - this appears to work in the browser but does not seem to adjust in mobile
I've used both Chrome and Safari to no avail, any suggestion would be well appreciated

This directive does not have any code that controls the dropdown functionality - that would be controlled by the framework that are you using.
Are you using bootstrap, AngularUI or something else for the dropdown?

No response from OP


Decoy selection algo off-by-1

wallet2 + consensus allow a user to spend an output that's in a block 9 blocks prior to the final block in the chain, since the output is eligible to be included in the next block at that point (see discussion here). The decoy selection algo should therefore apply the same criteria when selecting decoys.
The PR to change the decoy selection algo in the monero repo is still open here: https://github.com/monero-project/monero/pull/8794

This was cherry picked onto the master and release-v0.2 branches.


Bigger hover zone for sidebar?

Hi @KiKaraage,
Theme is absolutely amazing, thanks for sharing it!
Description
One thing I struggle with now is hovering over the left side to show the tab sidebar. On macOS, it seems like there's only couple of pixels worth of width to be able to show the hidden sidebar.
When I have the windows maximised (not fullscreen) and go to the left side of the screen, I get the arrow for resizing the window – the desktop environment takes over, and Firefox doesn't consider the cursor being "in the window".
The workaround is to have the sidebar on at all times, sure – but on small screens that eats into the available screen real estate a fair bit.
Any ideas on how to tackle this?
Environment:
macOS Monterey 12.7.3 (21H1015)
Firefox 124.0b8 (64-bit)
Latest ArcWTF version (git master), also happens with release v1.2-firefox
Details:

Severity: 3 - Basic function loss, with workaround
Ease of reproduction: Everytime

Repro video:
https://github.com/KiKaraage/ArcWTF/assets/123884681/d1d3da03-c33d-412f-a545-605a31d4a707

Alright, i just learned about that behaviour on MacOS. Sad because that doesn't happened on Windows and I can freely summon the sidebar by moving the cursor on the left corner.
Currently you can "solve" this by increasing sidebar size on sidebar.css line 58:
#main-window[sizemode="maximized"] #sidebar-box {
  --uc-sidebar-width: 0.3rem;

Although you will also have to increase --tabs-margin parameter in Sidebery style editor, otherwise some of the icons would be shown even on the autohidden state.
I will try to ask other people (probably the firefoxCSS community) to see if there's a DE-related fix for that, on maximized browser state.

Thanks for looking into this!
I will try that and report back.
Also, just wanted to note – this is not only on maximised window; the window can be any size on the desktop, and the issue still persists.

the window can be any size on the desktop, and the issue still persists.

For non-maximized window state, you can edit tweaks/sidebar.css line 20: --uc-sidebar-width: 6px; to 8px, 10px or something larger.

When I have the windows maximised (not fullscreen) and go to the left side of the screen, I get the arrow for resizing the window – the desktop environment takes over, and Firefox doesn't consider the cursor being "in the window".

Try adding this code on userchrome.css or global/browser.css:
#appcontent .browserStack {
  margin-left: 0 !important;
 }

Sadly, all of the above suggestions hasn't really worked on the initial issue… Tried changing some other values in the tweaks/sidebar.css too, and nothing has improved the situation. I guess this might just be a OS limitation.

Yup.
Kinda sad tho since I've reaching out to one of fellow CSS theming mate with mac and he doesn't experienced it on his Firefox (the same person that suggested the .browserStack fix)

is it possible to keep a persistent icon only tabbar in place of hover area (like the image ).. would largely be functional and wouldnt require to search for tabs when the sidebar is open

That's possible, you can just change --uc-sidebar-width in sidebar.css line 20 (for unmaximized state), line 58 for maximized, and line 61 for fullscreen mode.
But by default Arc doesn't worked that way, so I'm setting the default sidebar width as narrow as possible when not hovered/toggled.

@KiKaraage I did increase the sidebar width but it doesn't show the icons for the tabs, how do I enable those?

@spanclan If you figure out how to do that, please share your results:)


Node Driver page does not handle errors

Setup

Rancher version: v2.7 head
Rancher UI Extensions: n/a
Browser type & version: chrome 114

Describe the bug

When disabling/enabling a Node Driver if the API returns a 400/500 it does not display the error nor update the UI in anyway, which is confusing.
To Reproduce

Apply https://github.com/rancher/webhook/pull/250 to the webhook, then try and disable a node driver after creating a cluster that uses one of the node drivers. Nothing will happen in the UI after clicking disable.
Result
Nothing happens when the request is denied.
Expected Result

A notification is shown with the error so the user knows what happened in the background when trying to disable/enable the driver.
Screenshots

Additional context

path: /dashboard/c/_/manager/pages/rke-drivers
This was found when developing https://github.com/rancher/rancher/issues/41128, when adding the webhook which can deny an update on the NodeDriver resources

This is a general issue with how we handle requests related to actions that do not modify the resource state / message.
This page is currently in ember, but the pattern extends to dashboard as well.
We should look at / consider this when working on https://github.com/rancher/dashboard/issues/9274

Hi just wanted to leave my findings here from https://github.com/rancher/rancher/issues/42378
I noticed when activating both node drivers I noticed that one of the node drivers went into a Downloading state. Both are installed and active. I'm not sure if this is worth fixing for the ui since this is a very edge case, I'm ok with just having the backend working properly.

Even when uninstalling the active node driver, the downloading nodedriver stays in Downloading state in   the UI. When looking at the api I see that the status is indeed in Downloading but when I check the nodedriver using kubectl I see that the node driver is actually installed and active.

I'm ok to close this out this ticket and keep this comment here as a reference but I don't think it is worth UI team's time to fix this edge case.

@timirnich that seems to be a separate issue, where two of the same drivers are added and the state supplied getting broken. Think the key issue on this one is the request fails and the UI does not show the error message.
Needs re-testing in 2.9.0 after this page was ported to vue


Iteration issue with StaticString

I'm trying to get the following code to work:
using CodeInfoTools
using MacroTools
using StaticTools

swap(e) = e

function swap(e::Expr)
    new = MacroTools.postwalk(e) do s
        @show s
        s isa String && return StaticTools.StaticString(tuple(codeunits(s)..., 0x00))
        return s
    end
    return new
end

function transform(src)
    b = CodeInfoTools.Builder(src)
    for (v, st) in b
        b[v] = swap(st)
    end
    return CodeInfoTools.finish(b)
end

function stringfun(s1, s2)
    return s1 * s2
end

function teststring()
    return stringfun("ab", "c") == "abc"
end

ci = code_info(teststring)
cit = transform(ci)

On StaticTools v0.8.5 (latest), it gets stuck in an infinite loop. On StaticTools v0.8.3, it fails and complains about iteration. It works if I define the following. Defining that on v0.8.5 doesn't work.
String(s::StaticString) = Base.unsafe_string(pointer(s))

Any ideas?

Oh interesting.. One thing that did change between v0.8.3 and now is that we added iteration support for StaticStrings (https://github.com/brenhinkeller/StaticTools.jl/pull/36) since that is neccesary for things like startswith and endswith but not sure why that would be causing problems here.. the MacroTools stuff is approximately black magic to me though 😆
This part seems to be fine, in any case
julia> using StaticTools

julia> s = "ab"
"ab"

julia> StaticTools.StaticString(tuple(codeunits(s)..., 0x00))
c"ab"

This code works if I use StaticStrings.StaticString. That package also defines iteration and defines String.
The MacroTools stuff is also a bit deep for me.

Ah, so we did have to change the iteration interface a bit for StaticStrings vs Base.Strings, because the default iteration interface for Base.String is (!?!) explicitly type-unstable (returns nothing once you get to the end of the string), and therefore non-static-compileable. I suppose that could cause some problem is something here is expecting them to follow the same iteration protocol as base Strings, but it's also not so clear to me why they're getting iterated at all here?
No idea if it'll help, but you might try using the conversion methods here https://github.com/brenhinkeller/StaticTools.jl/commit/5fb68d71d03b700be61d27db94dd03eebf8984da
on StaticTools#main (can do just StaticString(s) instead of StaticString(tuple(codeunits(s)..., 0x00)))

I guess if it was able to find some sort of working fallback before we defined iterate, we could possibly also just rename our iteration protocol stableiterate or something?

Here's a shorter reproducer:
String(c"abc")

The nonstandard iteration protocol is the problem. It never finishes. It's trying to run this code, and the loop never finishes.
So, I think we need to define String and remove this iteration protocol.
I also wonder if the standard iteration with nothing could be compiled statically. Can Julia's small-union features take care of the type stability?

Sadly no -- we only added this type-stable iterate after finding that the Base version could not be made to compile.
There might be some cases where if it's statically knowable / constprop'd that you never hit the end of the string, then you never get the instability -- but more generally things like the union splitting AFAIU only improve performance, and don't actually eliminate the instability
Ah, so it looks like all we actually need to do here is beat Base.String(s::AbstractString) in the dispatch hierarchy, so e.g.
julia> @inline Base.String(s::StaticString{N}) where {N}  = Base.unsafe_string(pointer(s))

julia> String(c"abc")
"abc"

seems to work. But I'll rename the iteration procedure to be safe anyways.

I tried statically compiling a function using iteration with StaticStrings, and it seems to work. It uses nothing-style iteration. This seems like an example where this iteration is statically compilable.
using StaticCompiler
using StaticStrings

function teststring(s)
    res = 0
    for c in s
        res += Int(c)
    end
    return res
end

_, path = compile(teststring, (StaticString{20},))
@show load_function(path)(static"jkjk"20)

Can you compile_executable or compile_shlib with it?

If you can, then perhaps it's worth adding that here, even if we couldn't get startswith and friends to statically compile with the type-unstable iterate

I got the following to work. I'm not sure if it covers all iteration scenarios.
using StaticCompiler
using StaticStrings
using Libdl

function stringfun(i)
    for c in static"qwerty"20
        i += Int(c)
    end
    return i
end

name = repr(stringfun)
filepath = compile_shlib(stringfun, (Int,), "./", name)

# Open dylib
ptr = Libdl.dlopen(filepath, Libdl.RTLD_LOCAL)
fptr = Libdl.dlsym(ptr, "julia_$name")
ccall(fptr, Int, (Int,), 10)

Hmm, ok that might be enough of a reason to support iteration -- though unless we missed something in https://github.com/brenhinkeller/StaticTools.jl/issues/35 we weren't able to get it to compile for startswith


[ServiceBus][Test] UnpartitionedQueue: purgeMessages failing in nightly runs

Search Documents nightly test runs are failing with:

Stack trace:
Unexpected number of msgs found when peeking: expected 1 to equal +0

expected - actual
-1
+0

AssertionError: Unexpected number of msgs found when peeking: expected 1 to equal +0
at Object.should.equal (/Users/runner/work/1/s/common/temp/node_modules/.pnpm/chai@4.3.10/node_modules/chai/lib/chai/interface/should.js:98:35)
at testPeekMsgsLength (/Users/runner/work/1/s/sdk/servicebus/service-bus/test/public/utils/testutils2.ts:2:35)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at Context. (/Users/runner/work/1/s/sdk/servicebus/service-bus/test/internal/batchReceiver.spec.ts:2:35)

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3953460&view=results

likely it's because of the known service issue.

there's a more recent issue tracking purge/delete message live test failures.


User can comment even if we unselect the annotation

Describe the bug in current situation
On the redaction app when we unselect the annotation still we can give reply to that annotaion
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Users wont be able to know where the comment gone after entering it
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Test-marshal
Steps to Reproduce
Steps to reproduce the behavior:

Go to redaction app
Select one annotation to put a comment
Comment Pop up comes up, but it the user accidently unselect the annotation , still user able to comment on it and comment is disappeared
See the screenshot

Actual/ observed behaviour/ results
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

likely low-priority, need to try it in action and get more user feedback on use of comments in app

May need PDFTron ticket - for further discussion.


How to make "private" media accessible by site staff?

It works well when serving in terms of private, thanks. But I want the site staff members to access the private media uploaded by member, how should I config? Thanks.

Sorry, it's my fault.


Fix/use params not router

Realised there was no need for useRouter in the home page so removed it and replaced activeNavLink with a string.

Good catch!


jquery bower dependency version

Is there any particular reason to depend on jQuery ~1.10.2 in your bower.json?
I am using it with 2.1.0 - have no issues yet.

Is bootstrap-colorpicker incompatible with jQuery 2.0?


FASTQ read name encoding keeps spaces

FastqReadNameEncoding.getPlainName parses names in non-Casava format as a whole, letting spaces to be included in the transformed SAM read. Thus, after converting a read-name from such a FASTQ into a SAM/BAM format, the space is included in the read name, generating an invalid file (as far as I know, although neither HTSJDK/GATK complains).
We should do a non-backwards compatible bugfix to trim the read name, storing the information into a custom tag (the CO tag is for the comment, used for the quality line). We can store all the information after the white space, or just the original read name. This should be do soon, and we have to release a new version with the bugfix.

Actually this is a bug for reads without barcode/pair-end information. It will be solved soon.


Added travis config file for continuous integration testing

Creating this PR for indigo-devel right now.  Will sync up jade-devel branch after this is accepted.

Besides the allowed failures for Jade (which I think are not necessary anymore?), +1.


feat(execution): add check_done to the scheduler

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.79%. Comparing base (1e3f7a2) to head (6dc2f87).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           avi/concurrency/add-next-task    #1701   +/-   ##
==============================================================
  Coverage                          73.79%   73.79%
==============================================================
  Files                                 59       59
  Lines                               8595     8595
  Branches                            8595     8595
==============================================================
  Hits                                6343     6343
  Misses                              1834     1834
  Partials                             418      418

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate with travis CI so the tests run nice and automatic

./tools/test-all will run all the tests and takes just a few minutes to run; the tricky part will be getting all the Zulip dependencies running in the Travis CI environment.  http://docs.travis-ci.com/user/installing-dependencies/ suggests they only support Ubuntu 12.04; so it'll take a bit of work to get the packages available there.  If someone's interested in working on this I can provide some info and hackishly built packages for precise we could use for this.

Might make sense to do this as a 2-part project -- making a PPA so we can make the Zulip production setup install on precise again (which has its own value) and then putting that into Travis CI.
It should be easy to do because we used to support precise; we just moved to trusty when we did the Django 1.8 upgrade, so I expect it'll just be backporting like 5 more packages.
I may look at this this weekend.

Ubuntu 14.04 support exists and can apparently be opted into with certain directives in .travis.yml (mobile-shell/mosh@4b5389efe91230bbe0366d71a1cf6fd1d02e53c3).

oh well that sounds a lot easier :)

(Testing this out now)

Almost got this working with:
https://github.com/timabbott/zulip/commit/058bb8d8193019bba2362f605014e5c32fa11a23
backend and node tests pass; it's down to just 3/119 capser settings tests failing... https://travis-ci.org/timabbott/zulip/builds/82386842
(and obviously needs some code cleanup)

It seems to have passed with out any changes the next time.
So, the actual issue is that the casper tests are flaky.  Sigh.

Ran the tests 100x and got no flakes, so whatever flakiness issue I had seems very rare.  So, I've deployed it to master, and the first build even passed!  Yay. :)


Add "%ne" format support for forge console log

Component
Forge
Describe the feature you would like
Tokens in Solidity having varying decimals (18 for many ERC20, 8 for wBTC, etc.). This makes it difficult to recognize exactly how much of something is being printed when shown in "%d" or "%e" format. I'd like to have "%ne" supported to see these numbers as decimal.
E.g.
Someone's supply of wBTC on chain: 420000000
Formatted using "%8e": 4.2
Additional context
There was an idea to add this as part of #4464, but was not picked up. I'm reiterating the request here.

I'd like to have this feature as well and am considering an implementation.
Would a PR from my side be appreciated? Must admint i'm a total rust newbie but it seems like it shouldn't be too hard based on the %e PR

I see so exponential should take an optional number argument
we could support this by using an optional number value here:
https://github.com/foundry-rs/foundry/blob/5494c33bc7977b3537bd296e375431d938d44ca3/crates/common/src/fmt/console.rs#L16-L17
for parsing we need to make some changes to support lookahead
https://github.com/foundry-rs/foundry/blob/5494c33bc7977b3537bd296e375431d938d44ca3/crates/common/src/fmt/console.rs#L245-L246
we either need to use .peekable for the iterator or track the case when a number follows a % manually
https://github.com/foundry-rs/foundry/blob/5494c33bc7977b3537bd296e375431d938d44ca3/crates/common/src/fmt/console.rs#L237-L237
basically we need to parse
<number>e and convert this into ExponentialNumber(number)

Hi @RickVM, would be great to get this in. Let me know if you are running into any blockers - we are happy to give pointers / help out

No problem! Good luck on your project launch! I'll pick up the ticket

Hi, I would like to try impl this


 Thanks!

Mount your .vmdk / .e01images using Arsenal Image Mounter, and then run INDXRipper.
ewfmount is also a great option for .e01, if you use Linux.
I don't plan on supporting other image formats.
Is there a specific reason mounting is not an option for you?

I receive this error with the image mounted via Arsenal

Try this:
INDXRipper.exe \\.\J: outfile_1.csv

Thanks!


typeof non_webpack_require is not known during bundle

Do you want to request a feature or report a bug?
bug

What is the current behavior?
typeof __non_webpack_require__ is not resolved, resulting in webpack considering this a runtime check and breaking its usage as a guard to choose which form of the require func to use.
If the current behavior is a bug, please provide the steps to reproduce.
The code:
var requireFunc = typeof __non_webpack_require__ === "function" ? __non_webpack_require__ : require;
var targetExports = requireFunc(name);

resolves to:
var requireFunc = typeof __non_webpack_require__ === "function" ? __non_webpack_require__ : require;
var targetExports = !(function webpackMissingModule() { var e = new Error("Cannot find module \".\""); e.code = 'MODULE_NOT_FOUND'; throw e; }());

with webpack config
const LibraryScopeRegex = /^\@bl-libraries\/(.+)$/;
module.exports = {
    target: "node",
    entry: path.resolve(pkg.main),
    output: {
        path: dest(),
        filename: `./${libraryName}.js`,
        library: libraryName,
        libraryTarget: "commonjs2"
    },

    resolve: {
        extensions: [".js", ".json"]
    },

    externals: [
        function(context, request, callback) {
            // Anything with this scope will be external and scopeless in the runtime env.
            const match = LibraryScopeRegex.exec(request);
            if (match) {
                return callback(null, 'commonjs2 ' + match[1]);
            }

            // Everything else should be bundled
            callback();
        }
    ],

    plugins: [
        new webpack.NamedModulesPlugin()
    ]
}

I am attempting to make a library that will both function pre- and post- webpack with a nodejs target on both sides.
This module needs to forward a require statement to node, so it should get the top-level nodejs module require() func both from the original source and from the webpack output.
However, webpack seems not to be aware of the type of __non_webpack_require__, and tries to resolve the usage of requireFunc as a webpack-level require().

What is the expected behavior?
I expected webpack to identify __non_webpack_require__ as one of its own, resolve it in setting requireFunc, and to leave requireFunc alone after that.
I am able to get the desired results by changing REPLACEMENT_TYPES at lib/APIPlugin.js:21
const REPLACEMENT_TYPES = {
	__webpack_public_path__: "string", // eslint-disable-line camelcase
	__webpack_require__: "function", // eslint-disable-line camelcase
	__webpack_modules__: "object", // eslint-disable-line camelcase
	__webpack_chunk_load__: "function", // eslint-disable-line camelcase
	__webpack_nonce__: "string" // eslint-disable-line camelcase

        // FIX: Teach webpack about the type of  __non_webpack_require__
        __non_webpack_require__ : "function"
};

With this fix in place, the output code becomes
var requireFunc =  true ? require : require;
var targetExports = requireFunc(name);

and functions the way I expect it to.
As a workaround, I am checking the existence of webpack using typeof __webpack_require__, which results in the same code as the proposed fix.
Am I on-target here?  Is this the appropriate way to handle my use case?
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Node 8.9.0
Webpack 3.8.1
Windows 10

operations-api\node_modules\bindings\bindings.js:135
throw err;
^
Error: Could not locate the bindings file. Tried:
Getting this error someone please help


[GHI #6] Tom Select

Task
#6
Why?
Tom Select was using magic numbers and hard-coded colors. This simplifies and ensures it's using our variables.
What Changed

[X] Simplify custom tom select overrides
[X] Fix dynamic color engine to not reference undefined variables

Screenshots

Using the split view might be helpful for the custom tom select file


Smarter Dataset quantile method?

What is your issue?
Calling ds.quantile(..., dim="x") result in all data variables in ds being modified to have a quantile dimension regardless of whether they had x as a dimension to begin with.
Is this intended? Can ds.quantile(..., dim="x") be called such that only data variables in ds that had x as a dimension end up with the x dimension being replaced by quantile dimension?
In my case I have a dimensionless data variable which I want to keep dimensionless. I know workaround are to either decode_coords="all" beforehand, or to do something like ds[my_dimensionless_var].isel(quantile=-1, drop=True) afterwards... but just checking if that is expected behaviour.

Thanks, this is certainly not desired behavior. Similar to #7027.


Improve test discovery

Add local conftest plugin to avoid recursing into symlinked
directories
Moved pytest config to setup.cfg to be consistent with other test
configs

On my system the time difference for pytest -- collectonly --no-cov is about .2s with these changes. wall time when from 0.418s to 0.615s

@detiber thanks!


Update policies page in Getting Started and aperturectl docs

Description of change
Checklist

[ ] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
[x] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

This change is

LGTM!


Add a plugin to set the VBox Machine Folder before 'vagrant up'

This commit adds an inline plugin to automatically set the VBox
default machine folder to a local directory before 'up' when using
Vagrantfile.baremetal.

Would you think it prudent to remove the other place this was attempted?

Closing for cleanup. Feel free to reopen if this work gets picked up later on.


Add a pending state if the GitHub status API is used

Untested, but I thought I'd make the PR in the mean time.

[Current coverage][cc-pull] is 92.48%

Merging [#106][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.10%

@@             master       #106   diff @@
==========================================
  Files            50         50
  Lines          2764       2767     +3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2559       2559
- Misses          205        208     +3
  Partials          0          0

Powered by Codecov. Last updated by [f2e4b13...480437e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/markstory/lint-review/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/markstory/lint-review/compare/f2e4b135bfdc59c0bbcbc86a9b35b08384ce878f...480437e351d7c1d52f6bf76f207cbd3e1ad46a90
[cc-pull]: https://codecov.io/gh/markstory/lint-review/pull/106?src=pr

Looks like a great idea. It just needs some tests.

Looks like a great idea. It just needs some tests.

I actually have no idea how to test that potion of the code, can you help out?

Looks like there aren't any tests for that job entry point. I'll merge this and then sort out the tests 😊


Add compatibility with flutter 3.22.0

Summary

Adjusted package and example app to be compatible with the latest Flutter version
Updated the deprecated Flutter Gradle plugin apply as per: https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply#summary

@badjio first of all thanks a lot for the neat skeletons package! If you still actively maintain this repository it would be great if you can have a look at this PR and release a new version of skeleton to be compatible with the latest Flutter version.


Extract sequencer APIs as protobuf and implemented public interfaces in terms of these

Various types are currently exchanged between Astria Services as JSON serialized text, where they should be defined and encoded as protobufs.
The main types are (possibly in addition to some smaller ones I overlooked): SequencerBlockData, InclusionProof SequencerNamespaceData, RollupNamespaceData.
astria.sequencer.v1alpha1 actually contains protobuf definitions of these, but they were never used and are by now no longer compatible with the Rust definitions.
The Rust definitions should be extracted as Protobufs, and sequencer, sequencer-relayer, and conductor implemented in terms of them.
### Tasks
- [x] Define protobufs: https://github.com/astriaorg/astria/pull/443
- [x] Update chain ID to be 32 bytes: https://github.com/astriaorg/astria/pull/436
- [x] Implemented a rust-native API for the generated rust protobuf types: https://github.com/astriaorg/astria/pull/444
- [x] Implement services in terms of these

This has all been implement via #395


include stage1_config.json in package

I included the stage1_config.json in ctapipe/examples, so the tests can use the packaged one. However, I am not sure about the naming of the directory.
This will fix #1750

a) I would probably just add the json file into a resources directory in ctapipe/tools/tests/resources. It is in this case not really an example, but a non-code file needed for the tests.

Yes, that is what I meant. Not really an example in this case anymore. But should we keep this in the top-level examples? So that it is twice in the repo, but once in the package?

b) wee need to add importlib_resources to the required packages for python < 3.9.

Is it possible to require this only if python < 3.9 ? I just put it into tests_require for now

Is it possible to require this only if python < 3.9 ? I just put it into tests_require for now

for future reference: yes you can, with environment markers from pep 508

I can reproduce that issue, after cleaning up (rm -rf build *.egg-info)
weird, that the tests still pass ..

Maybe it would be worth to use this setup in the CI to make sure it works.
So I'd suggest to remove the  -e in the pip install and use pytest --pyargs ctapipe to run the tests.

It may be worth waiting for #1726 since that introduces several more "standard" config files that need to be used for testing.  I only haven't had time to write the tests.
Of course, we eventually need to create a configuration repo in the CTA-GitLab to keep track of real (non-testing) configurations.

Wouldn't it make sense to do it the other way around? Merge this here first and then you can just add those new config files to the ctapipe/tools/tests/resources folder in the other PR?

ouch, it seems like I need to review how to do git

sorry if anyone was notified unnecessarily.
I now added the resources for the ProcessorTool and resolved the conflicts that were shown

The only issue I have here is that these configs really are examples, that the user may want to take and modify, not just used for testing.  They are supposed to define the reference analysis. So perhaps we should keep two copies of them? One for tests, and one for examples? Otherwise they are now hard to find.
Or perhaps better yet: we could make a Tool that sets up a directory for user analysis (ctapipe-quickstart or something), that writes a copy of the standard configs to a user-specified directory with a README or something.  It could even fetch some example files.  Essentially, it would set up a working directory with templates for the configs.  For now, it could be simple, but later it could have some more options.    There is also ProcessorTool().generate_config_file (a feature from trailets.config that generates a commented config file, but only in Python format)

By the way, could we not just put these configs on the datatserver in the latest version of ctapipe-extra like we do with all other testing files? Thatt would make this PR unneeded, since you could just use get_dataset_path("stage1_config.json") ?

By the way, could we not just put these configs on the datatserver in the latest version of ctapipe-extra like we do with all other testing files?

I guess that these files will need updates more often than data files. Which makes putting them on the data server really suboptimal, since only very limited number of people have access to them and somebody preparing a PR that needs configs to be adjusted cannot do it while developing. Also, these are small text files, so are well suited for git.


Make webrtc-adapter a peer dependency

See #45.

webrtc-adapter should be a peer dependency, not a direct dependency, of this library
Update installation instructions

Browsers: need to include instascan.min.js as well as adapter.min.js
Provide a fully bundled version (webrtc-adapter included)?
npm/yarn: npm install --save instascan webrtc-adapter
...

Same thing goes for babel-polyfill.
Right now, that require-statement makes Angular applications explode, if importing Instascan from node_modules (through WebPack), Since Angular's ZoneJS monkey-patched Promise get's overriden by babel's polyfill.

Implemented changes to this in pull request: https://github.com/schmich/instascan/pull/48


[BUG] Can't test community-operators for OpenShift 4.6

There was a bug in the community-operators catalog source which got included in OpenShift 4.6.15, the version that was bundled by crc:

https://github.com/operator-framework/operator-marketplace/pull/384
https://access.redhat.com/solutions/6470961
https://bugzilla.redhat.com/show_bug.cgi?id=1937986

This leaves me with no easy way to test the cert-manager community operator on OpenShift 4.6.
Would you consider releasing a new patch version of crc 1.22 with a fixed version of OpenShift 4.6?
Or explain how to upgrade the openshift once it has been started.
General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it: Yes
Running CRC on: VM

CRC version
[crc@crc-4-6 ~]$ bin/crc-1.22.0 version
CodeReady Containers version: 1.22.0+6faff76f
OpenShift version: 4.6.15 (embedded in executable)

CRC status
[crc@crc-4-6 ~]$ bin/crc-1.22.0 status
CRC VM:          Running
OpenShift:       Degraded (v4.6.15)
Disk Usage:      15.28GB of 32.72GB (Inside the CRC VM)
Cache Usage:     14.31GB
Cache Directory: /home/crc/.crc/cache

CRC config
[crc@crc-4-6 ~]$ bin/crc-1.22.0 config view
- consent-telemetry                     : yes
- cpus                                  : 8
- disable-update-check                  : true
- memory                                : 24576
- pull-secret-file                      : build/pull-secret

Host Operating System
[crc@crc-4-6 ~]$ cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.4 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.4"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.4 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8.4:GA"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/8/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.4
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.4"

Steps to reproduce

crc setup
crc start
Browse to https://console-openshift-console.apps-crc.testing/operatorhub/ns/openshift-operators
Search for cert-manager

Expected
I expected to see the cert-manager community-operators entry
Actual
No community operators are visible
Logs
[crc@crc-4-6 ~]$ oc -n openshift-marketplace describe catalogsources community-operators
Name:         community-operators
Namespace:    openshift-marketplace
Labels:       <none>
Annotations:  operatorframework.io/managed-by: marketplace-operator
API Version:  operators.coreos.com/v1alpha1
Kind:         CatalogSource
Metadata:
  Creation Timestamp:  2021-02-02T06:21:00Z
  Generation:          5
  Managed Fields:
    API Version:  operators.coreos.com/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:operatorframework.io/managed-by:
      f:spec:
        .:
        f:displayName:
        f:icon:
          .:
          f:base64data:
          f:mediatype:
        f:image:
        f:priority:
        f:publisher:
        f:sourceType:
        f:updateStrategy:
          .:
          f:registryPoll:
            .:
            f:interval:
    Manager:      marketplace-operator
    Operation:    Update
    Time:         2021-11-04T01:19:39Z
    API Version:  operators.coreos.com/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:connectionState:
          .:
          f:address:
          f:lastConnect:
          f:lastObservedState:
        f:latestImageRegistryPoll:
        f:registryService:
          .:
          f:createdAt:
          f:port:
          f:protocol:
          f:serviceName:
          f:serviceNamespace:
    Manager:         catalog
    Operation:       Update
    Time:            2021-11-04T01:49:32Z
  Resource Version:  60676
  Self Link:         /apis/operators.coreos.com/v1alpha1/namespaces/openshift-marketplace/catalogsources/community-operators
  UID:               78c3fa40-6548-4542-870d-30e21c51786c
Spec:
  Display Name:  Community Operators
  Icon:
    base64data:
    Mediatype:
  Image:         registry.redhat.io/redhat/community-operator-index:latest
  Priority:      -400
  Publisher:     Red Hat
  Source Type:   grpc
  Update Strategy:
    Registry Poll:
      Interval:  10m0s
Status:
  Connection State:
    Address:                   community-operators.openshift-marketplace.svc:50051
    Last Connect:              2021-11-04T01:49:32Z
    Last Observed State:       TRANSIENT_FAILURE
  Latest Image Registry Poll:  2021-11-04T00:30:38Z
  Registry Service:
    Created At:         2021-02-02T06:21:02Z
    Port:               50051
    Protocol:           grpc
    Service Name:       community-operators
    Service Namespace:  openshift-marketplace
Events:                 <none>

[crc@crc-4-6 ~]$ oc -n openshift-marketplace describe pod community-operators-xpdnf
...
Events:
  Type     Reason          Age                From               Message
  ----     ------          ----               ----               -------
  Normal   Scheduled       9h                 default-scheduler  Successfully assigned openshift-marketplace/community-operators-xpdnf to crc-ctj2r-master-0
  Normal   AddedInterface  9h                 multus             Add eth0 [<IP_ADDRESS>/23]
  Normal   Pulling         9h (x4 over 9h)    kubelet            Pulling image "registry.redhat.io/redhat/community-operator-index:latest"
  Warning  Failed          9h (x4 over 9h)    kubelet            Failed to pull image "registry.redhat.io/redhat/community-operator-index:latest": rpc error: code = Unknown desc = Error reading manifest latest in registry.redhat.io/redhat/community-operator-index: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
  Warning  Failed          9h (x4 over 9h)    kubelet            Error: ErrImagePull
  Normal   BackOff         8h (x276 over 9h)  kubelet            Back-off pulling image "registry.redhat.io/redhat/community-operator-index:latest"
  Warning  Failed          8h (x341 over 9h)  kubelet            Error: ImagePullBackOff

Unfortunately we don't provide support for older OpenShift versions. Your best bet would be to regenerate your own OpenShift 4.6 bundle using https://github.com/code-ready/snc/ , but that can be an involved process.
I assume newer crc versions aren't an option for you?

Unfortunately we don't provide support for older OpenShift versions. Your best bet would be to regenerate your own OpenShift 4.6 bundle using https://github.com/code-ready/snc/ , but that can be an involved process. I assume newer crc versions aren't an option for you?

Thanks. I just need a way to quickly run OpenShift 4.6 to test that the cert-manager community operator works on that version.
I am under the impression that crc-1.22.0 is the last version that bundled OpenShift 4.6:

https://mirror.openshift.com/pub/openshift-v4/clients/crc/1.22.0/release-info.json
https://mirror.openshift.com/pub/openshift-v4/clients/crc/1.23.1/release-info.json

Is there a way to create an OpenShift 4.6 cluster using the latest version of crc?

After reading https://bugzilla.redhat.com/show_bug.cgi?id=1937986 , it seems the error you are seeing is because the latest tag was removed from registry.redhat.io/redhat/community-operator-index, but there were private comments yesterday saying they are trying to readd it. So the issue you are seeing might "fix itself" in the coming days ;)

I've verified that I can now see the community-operators on OpenShift 4.6.15 booted using crc-122.0. Thanks!


WIP updates to node,publish, and publisher.

Simply committing some work in progress. Node, publish, and publisher were worked on here, but this will not build or run yet. A LOT of
vendor-specific leftovers in here.

@neeleym I'm just getting around to checking this PR. I'm wondering which parts are still useful. I think our current plan is to comment out and leave much of the old code in for reference for those working on it now. Since you've removed large sections and replaced with TODOs, that may not be as helpful for this new effort. Any thoughts?


jsdom.env is not defined

https://github.com/bda-research/node-crawler/blob/e8a51d794c1a712bef65594556311218fdcb9fb7/lib/crawler.js#L157
reproduce code
var jsdom = require('jsdom');
var Crawler = require('crawler');

var c = new Crawler({ jQuery: jsdom, jquery: jsdom });

c.queue({
  jQuery: {
    jsdom
  },
  uri: "https://www.baidu.com",
  callback: (err, res, done) => {
    console.log(err, res, done)
  }
})

This leads to

By the way the statement about jsdom seems to be outdated. pass  { jQuery: require('jsdom') } not works

You are right, the jsdom option is outdated. I recommend you to adopt  puppeteer to get what you want instead.


Import packet generation tool

The pktgen tool is to be used to generate pcap files which contain traffic patterns modelled after those which can be found in actual networks. The generated pcap files can then be used to test the different applications using them.
The shape of the generated traffic is defined in a declarative way, using “packet spec files”, which look like the following (minimal) example:
ip { tcp { .flags "", randbytes { .size 50 } } }

The above examples generates IPv4 packets with a TCP payload, and that in turn with a payload of 50 randomly-generated bytes. The block items which content with different network encapsulation map to their Scapy equivalents, and configuration attributes (e.g. .flags) allowed are the same accepted by the constructors of the corresponding Scapy classes.
In order to allow reusing spec files, it is possible to include a spec file from another using the spec-file element. For example the following reuses the spec file for TCP packets to create spec files for encapsulating them with IPv4 and IPv6:
# file: tcp-randbytes.pktinc
tcp { .flags "", randbytes { .size 50 } }

# file: ipv4-tcp-randbytes.pktspec
ipv4 { spec-file { .name "tcp-randbytes" } }

# file: ipv6-tcp-randbytes.pktspec
ipv6 { spec-file { .name "tcp-randbytes" } }

For a better use case, check the imix* files in the examples/ subdirectory.

Overall, LGTM. It would be nice if:

it'd show a user-friendly error message if someone tries to run it without scapy installed (but this is not a blocker to merging it)
it had a README.pktgen that explained what you explained in the comment above, and which mentions that it depends on scapy.
Feel free to add a README and then hit 'merge'. :-)

I have just updated the PR description to match the current implementation of the tool.

Nifty tool; closing this PR since it doesn't match the packet generation needs of the lwaftr project, but keep it alive. :-)

As suggested, I have splitted this to its own repository


Spectrum 1.7.9

Mod Name
Spectrum
Mod Homepage
https://github.com/DaFuqs/Spectrum
Minecraft version
1.20.1
Describe the bug
Crash on startup
Steps to reproduce
No response
Logs
https://gist.github.com/fg1989/109141b425a45e0de7f75374c43d64bc
Additional context
Mod list :
cloth-config-11.1.118-forge
Connector-1.0.0-beta.43+1.20.1
ConnectorExtras-1.10.1+1.20.1
fabric-api-0.92.1+1.11.8+1.20.1 (Forgified-Fabric-API)
Patchouli-1.20.1-84-FORGE
revelationary-1.3.7+1.20.1
spectrum-deeper-down-1.7.9 (Spectrum 1.7.8 with the same other mods works correctly)
trinkets-3.7.2
All mods in the list are required dependencies of spectrum

I'm having the same issue; it seems to be due to a recent change to Additional Entity Attributes, which is JiJ'd by Spectrum.
https://gist.github.com/unilock/02cb65ae67f196924f9b1c60fbc74dab

Have same problem

This is actually now fixed if you use Additional Entity Attributes forge port, and then remove the JiJ for AEA Fabric inside the spectrum jar.

https://modrinth.com/mod/additionalentityattributes-forge
https://archive.naylahanegan.com/0:/Mods/Spectrum/1.20.1/Spectrum-1.20.1-<IP_ADDRESS>-nayla.jar

The Forge port of Additional Entity Attributes is outdated. You should instead just install the updated version of the original Additional Entity Attributes: https://modrinth.com/mod/additionalentityattributes/version/1.7.4+1.20.0

I get an error when I try Spectrum and trinkets on forge 1.20.1.  Which mods need to be installed as it seems I cannot have trinkets and Curios together?
Thanks.

The Forge port of Additional Entity Attributes is outdated. You should instead just install the updated version of the original Additional Entity Attributes: https://modrinth.com/mod/additionalentityattributes/version/1.7.4+1.20.0

It also doesn't work with the fabric port

I get an error when I try Spectrum and trinkets on forge 1.20.1. Which mods need to be installed as it seems I cannot have trinkets and Curios together?
Thanks.

Use Accessories, and the adapter addons for trinkets & curios.