Sarif Viewer VS extension does not support codeflows

Hi,
We found that Sarif Viewer VS extension does not support codeFlow property in Sarif file. We are wondering do you have a timeline to support it? Thanks!

@yongyan-gh, can you create a SARIF with CodeFlow properties, test in vscode, and see if that appears correctly in both tools?

I see. I have double checked. It seems that if drop the physicalLocation in codeflows, Sarif Viewer extension aren't able to load it? For example:
{
    "$schema": "http://json.schemastore.org/sarif-2.1.0-rtm.5",
    "version": "2.1.0",
    "runs": [
        {
            "tool": {
                "driver": {
                    "name": "Infer",
                    "informationUri": "https://github.com/facebook/infer",
                    "version": "1.1.0",
                    "rules": [
                        {
                            "id": "NULLPTR_DEREFERENCE",
                            "shortDescription": {
                                "text": "Null Dereference"
                            }
                        }
                    ]
                }
            },
            "results": [
                {
                    "message": {
                        "text": "Pulse found a potential null pointer dereference on line 41."
                    },
                    "level": "error",
                    "ruleId": "NULLPTR_DEREFERENCE",
                    "codeFlows": [
                        {
                            "threadFlows": [
                                {
                                    "locations": [
                                        {
                                            "nestingLevel": 1,
                                            "location": {
                                                "message": {
                                                    "text": "in call to `Object Program.ReturnNullReference()`"
                                                }
                                            }
                                        }
                                    ]
                                }
                            ]
                        }
                    ],
                    "locations": [
                        {
                            "physicalLocation": {
                                "artifactLocation": {
                                    "uri": "file:C:\\Users\\matjin\\source\\repos\\ConsoleApp4\\ConsoleApp4\\Program.cs",
                                    "uriBaseId": "/root/C:\\Users\\matjin\\source\\repos\\ConsoleApp4\\ConsoleApp4\\Program.cs"
                                },
                                "region": {
                                    "startLine": 41,
                                    "startColumn": 13
                                }
                            }
                        }
                    ]
                }
            ]
        }
    ]
}

The issue that SARIF viewer does not show codeflow property of above result in SARIF explorer is because the 'nestingLevel' of threadFlow.location. SARIF spec
The viewer tries to create code flows in a tree view based on threadFlow.location.nestingLevel property. It assumes nestingLevel 0, also the default value, to be the root node, and child nodes have nestingLevel greater than 0.
In above result the 'nestingLevel' of the only threadFlow.location is 1, viewer cannot find the root node to render the tree view.
You can set the nestingLevel value starting from 0, this will unblock you from the issue.
Will double check with SARIF team about the what should be expected behavior.
Thanks!

The issue that SARIF viewer does not show codeflow property of above result in SARIF explorer is because the 'nestingLevel' of threadFlow.location. SARIF spec
The viewer tries to create code flows in a tree view based on threadFlow.location.nestingLevel property. It assumes nestingLevel 0, also the default value, to be the root node, and child nodes have nestingLevel greater than 0.
In above result the 'nestingLevel' of the only threadFlow.location is 1, viewer cannot find the root node to render the tree view. You can set the nestingLevel value starting from 0, this will unblock you from the issue. Will double check with SARIF team about the what should be expected behavior.
Thanks!

I see. Thanks for looking into this. We found that level 1 is supported in Sarif Viewer VS Code extension:

Maybe these is an inconsistency here?

@xi-liu-ds the SARIF viewer VS code extension renders the threadFlowLocations as a flat list, the VS extension supports rendering threadFlowLocations to a tree view based on the nestingLevel. e.g. below screenshot shows a tree view of nested threadFlowLocations.

We would like to have better understanding about the what information do you capture in the codeflow properties and how would you like the viewer to show that information. Can you please share couple SARIF samples created by your tool include codeflows data? Does the codeflow have single or multiple threadFlowLocations in your cases? Are they captured in a hierarchical structure? Thanks!

Hi!
Here is an example SARIF file that we would like to render:
{
"$schema": "http://json.schemastore.org/sarif-2.1.0-rtm.5",
"version": "2.1.0",
"runs": [
{
"tool": {
"driver": {
"name": "Infer",
"informationUri": "https://github.com/facebook/infer",
"version": "1.1.0",
"rules": [
{
"id": "DOTNET_RESOURCE_LEAK",
"shortDescription": {
"text": "Dotnet Resource Leak"
},
"helpUri": "https://fbinfer.com/docs/next/all-issue-types#dotnet_resource_leak"
},
{
"id": "NULLPTR_DEREFERENCE",
"shortDescription": {
"text": "Null Dereference"
},
"helpUri": "https://fbinfer.com/docs/next/all-issue-types#nullptr_dereference"
},
{
"id": "THREAD_SAFETY_VIOLATION",
"shortDescription": {
"text": "Thread Safety Violation"
},
"helpUri": "https://fbinfer.com/docs/next/all-issue-types#thread_safety_violation"
}
]
}
},
"results": [
{
"message": {
"text": "Leaked { %1 -> 1, %0 -> 1 } resource(s) in method "Void Program.CreateResourceStreamLeak()" at type(s) System.IO.StreamReader, System.IO.FileStream."
},
"level": "error",
"ruleId": "DOTNET_RESOURCE_LEAK",
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 19,
"startColumn": 9
}
}
}
]
},
{
"message": {
"text": "Leaked { n$0 -> 1, %0.ConsoleApp4.ResourceOwner.streamWriter -> -1 } resource(s) in method "Void Program.ShouldNotLeak()" at type(s) System.IO.StreamWriter."
},
"level": "error",
"ruleId": "DOTNET_RESOURCE_LEAK",
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 26,
"startColumn": 9
}
}
}
]
},
{
"message": {
"text": "Pulse found a potential null pointer dereference on line 41."
},
"level": "error",
"ruleId": "NULLPTR_DEREFERENCE",
"codeFlows": [
{
"threadFlows": [
{
"locations": [
{
"nestingLevel": 1,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 40,
"startColumn": 13
}
},
"message": {
"text": "in call to Object Program.ReturnNullReference()"
}
}
},
{
"nestingLevel": 2,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 35,
"startColumn": 13
}
},
"message": {
"text": "is the null pointer"
}
}
},
{
"nestingLevel": 2,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 35,
"startColumn": 13
}
},
"message": {
"text": "assigned"
}
}
},
{
"nestingLevel": 2,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 36,
"startColumn": 9
}
},
"message": {
"text": "returned"
}
}
},
{
"nestingLevel": 1,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 40,
"startColumn": 13
}
},
"message": {
"text": "return from call to Object Program.ReturnNullReference()"
}
}
},
{
"nestingLevel": 1,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 40,
"startColumn": 13
}
},
"message": {
"text": "assigned"
}
}
},
{
"nestingLevel": 1,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 41,
"startColumn": 13
}
},
"message": {
"text": "invalid access occurs here"
}
}
}
]
}
]
}
],
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 41,
"startColumn": 13
}
}
}
]
},
{
"message": {
"text": "Read/Write race. Non-private method Program.GetIntValue() reads without synchronization from this.ConsoleApp4.Program.intValue. Potentially races with write in method Program.SetIntValue().\n Reporting because another access to the same memory occurs on a background thread, although this access may not."
},
"level": "warning",
"ruleId": "THREAD_SAFETY_VIOLATION",
"codeFlows": [
{
"threadFlows": [
{
"locations": [
{
"nestingLevel": 0,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 49,
"startColumn": 13
}
},
"message": {
"text": ""
}
}
},
{
"nestingLevel": 0,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 49,
"startColumn": 13
}
},
"message": {
"text": "access to this.ConsoleApp4.Program.intValue"
}
}
},
{
"nestingLevel": 0,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 56,
"startColumn": 17
}
},
"message": {
"text": ""
}
}
},
{
"nestingLevel": 0,
"location": {
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 56,
"startColumn": 17
}
},
"message": {
"text": "access to this.ConsoleApp4.Program.intValue"
}
}
}
]
}
]
}
],
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 49,
"startColumn": 13
}
}
}
]
},
{
"message": {
"text": "Leaked { %0 -> 1 } resource(s) in method "Void Program.ResourceLeakBad()" at type(s) System.IO.StreamWriter."
},
"level": "error",
"ruleId": "DOTNET_RESOURCE_LEAK",
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "file:C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs",
"uriBaseId": "/root/C:\Users\matjin\source\repos\ConsoleApp4\ConsoleApp4\Program.cs"
},
"region": {
"startLine": 68,
"startColumn": 9
}
}
}
]
}
]
}
]
}

thank you @matjin sharing your SARIF result. I see there are 2 kinds of threadFlows in the SARIF file.

All threadFlow locations have nestingLevel set to 0.
In this case SARIF viewer is able to render the all the locations in root node.
ThreadFlow locations nestingLevel starts from 1, there are 2nd level locations (nestingLevel is 2).
In this case SARIF viewer cannot render the codeflows since it assume the nestingLevel starts from 0. After updated the nestingLevel with starting value to 0, viewer can render the locations in tree view.
Couple questions:
Do you intend to set the start value of nestingLevel to 1? Can you set the value starts from 0?
Do you expect the viewer to render the locations in a tree view so it can have parent/child nodes?

Also have a suggestion for your SARIF result:
the "uriBaseId" property of artifactLocation should be an identifier reference to "originalUriBaseIds" dictionary under Run object.
You can define a uriBaseId points to a root location of the code base. Then in artifactLocation you can specify uriBaseId and relative path in uri property. E.g.
Have a uriBaseId "SRCROOT" defined in originalUriBaseIds, points to a repo location.
            "originalUriBaseIds": {
                "SRCROOT": {
                    "uri": "file:///C:/Users/matjin/source/repos/ConsoleApp4/"
                }
            }

in artifactLocation you can set uriBaseId to "SRCROOT" and use relative path as uri to point to a source file.
                            "physicalLocation": {
                                "artifactLocation": {
                                    "uri": "ConsoleApp4/Program.cs",
                                    "uriBaseId": "SRCROOT"
                                },

Hi @yongyan-gh!
Thank you for the suggestion. @xi-liu-ds will look into that.
To answer your questions first:
Do you intend to set the start value of nestingLevel to 1? Can you set the value starts from 0?
The fields are set by an upstream process so it wouldn't be simple for us to hack that to start from 0. However, SARIF Viewer VSCode is robust enough to render the same file, so I wonder if that same robustness can be carried into SARIF Viewer VS
Do you expect the viewer to render the locations in a tree view so it can have parent/child nodes?
The viewer does not have to render in tree mode for my scenario.
Would it be possible for this to be resolved on the extension end, as the functionality holds in VSCode SARIF Viewer?

Thanks @matjin for the information,
we are investigating the issue and will work on a proper solution.

Saw the fix! @yongyan-gh is it ready? Thanks!

@yongyan-gh I saw the fix is merged. Was it also released in extension already?

@matjin / @xi-liu-ds
Thanks for your feedbacks. We have the fix for the codeflow issue in VS extension. However, we have some bugs/items need to be addressed before publishing a new release.
If you would like to try the latest version including codeflow issue, you can enlist the repo and build the vsix following below steps:

Clone the repo in your local drive.
Open VS developer command prompt/powershell navigate to repo’s root folder.
Run command: “BuildAndTest.cmd”.
You can find the VSIX in repo root\bld\bin\ folder.

If you have issue not able to build, pls let me know I can share the latest vsix to you.

@matjin / @xi-liu-ds
Thanks for your feedbacks. We have the fix for the codeflow issue in VS extension. However, we have some bugs/items need to be addressed before publishing a new release.
If you would like to try the latest version including codeflow issue, you can enlist the repo and build the vsix following below steps:

Clone the repo in your local drive.
Open VS developer command prompt/powershell navigate to repo’s root folder.
Run command: “BuildAndTest.cmd”.
You can find the VSIX in repo root\bld\bin\ folder.

If you have issue not able to build, pls let me know I can share the latest vsix to you.

Will try. Thanks!

@matjin @xi-liu-ds FYI, this change was included in a new version of the extension that was published yesterday.

Closing as the issue is presumed fixed, @matjin @xi-liu-ds please re-open if necessary.


added schema types for duck player page messages

#950  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on  Graphite


Patch cluster with latest-<version>

Has a dependency on:

#733

/retest

/retest

/retest

/retest

/hold for reviews
Since Framework gates images, this PR patches the E2E cluster with the latest GRC images (just like we already do with the API) so that we don't have to force-merge PRs when component messages or the like change when the images are held back by the Framework.
FYI @KevinFCormier

/unhold


Fix Redis cluster

This fixes #87 by turning off clustering mode for the Redis cluster
because some apps are not compatible/configured with that feature.
We also add a security group to allow traffic to exit the Redis cluster.
Ref:

aws docs

maybe we don't need it? I was getting some connections errors, might be just the DNS changeover which was the cause.

Ha ok. Thanks for clarifying. Please do remove it if you find it's not needed after all.


Reorganize repo and add initial docker based services

Rename and move around folders
Add docker files
Edit readme

merged
Thanks @wang701 , looks like a great base


fyi.. confused on why this change keeps repeating for 2.1.2

This is repeating now for every run to every node using curator..
notice	ensure changed '2.1.1' to '2.1.2'	/Stage[main]/Curator/Package[elasticsearch-curator]/ensure	/etc/puppetlabs/puppet/environments/dev/modules/curator/manifests/init.pp	66	2015-02-13 07:36 EST
I would've expected a one time occurrence.. I know you guys staged new version number in commit? Just confused on why this keeps coming up as new change.

What provider are you using?

I am on centos 6.6, pip provider, EPEL repo, and curator was installed by puppet enterprise 3.7.1 as
~]# curator --version
curator 2.1.1

It doesn't look like this is the same as #24, but it does seem to be more a pip issue than this module's issue since all the module does is set the version but it doesn't appear the provider is actually making that version a reality.  If you run puppet agent with --debug does it give any insight about an error occurring with the upgrade of the package?

No, no debug output occurs for curator, pip, or python.

That is very odd.  If you run the pip command in the debug output does it correctly update?

pip not showing up in debug output.. ran a puppet --debug on one of my nodes employing the curator module.. also ran puppet parser validate against my manifest.. all clean.

here's actual run output:
 puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for evest-devsearch-01.evestment.local
Warning: The package type's allow_virtual parameter will be changing its default value from false to true in a future release. If you do not want to allow virtual packages, please explicitly set allow_virtual to false.
   (at /opt/puppet/lib/ruby/site_ruby/1.9.1/puppet/type/package.rb:430:in `block (3 levels) in <module:Puppet>')
Info: Applying configuration version '1424375031'
Notice: /Stage[main]/Curator/Package[elasticsearch-curator]/ensure: ensure changed '2.1.1' to '2.1.2'
Notice: Finished catalog run in 4.50 seconds


Fix wrong policy table in multi-nic

What this PR does / why we need it:
Fix wrong policy table in multi-nic
root@controller:~/cyclinder# ip rule
0:	from all lookup local
32764:	from <IP_ADDRESS> lookup 100
32765:	from all lookup 100.  ## remove this
32766:	from all lookup main
32767:	from all lookup default

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/kind bug


Cards

Cards can be added to your board to track the progress of issues and pull requests. You can also add note cards, like this one!

It's for test the issue only


Make offline release of latest fixes

The latest release is more than a year old. I would love to get a Windows release with the regex issue solved.

Hello,
I built my own MacOS release with the latest commits from master branch. I've uploaded it on my fork in case it could be useful for someone else: https://github.com/alpgarcia/ProjectABE/releases/tag/v0.8.11
@felipemanga I did some small modifications in gulpfile.js on a branch to support recent versions of some libraries. I didn't open a Pull Request with the changes because I don't know how to proceed with package.json and package-lock.json in order to not breaking anything (I don't know too much about JavaScript and node yet). Please let me know if you think my changes could be interesting for the project and what files I should include in the PR.
Best and thanks a lot for your work!
Alberto.

Hey,
Sorry I haven't been updating this project. I've been really busy lately, and the little free time I have I've been dedicating to some other projects, one of which is a from-scratch replacement for this. ProjectABE started off as a prototype and the code reflects that. At some point I had to stop working on it to make the real thing.


apps: privacy added

This commit adds two applications working together in similar way central and
peripheral did; the difference is, they are waiting until RPA timeout expires
before reconnecting.

ok, so this is not testing privacy, I think to test it properly boards should connect (by uuid), pair and get ID address of peer, disconnect, wait for RPA to rotate and then reconnect without using UUID for discovery, once reconnected verify that RPA changed but resolves to ID


OneDrive for Business Auth API problem: response misses the "refresh_token" parameter at step 4. "Redeem refresh token for an access token to call OneDrive API"

When I use a Office 365 Business Premium account to call the OneDrive for Business Auth API, the response from step 4. "Redeem refresh token for an access token to call OneDrive API" misses the parameter "refresh_token", but when I use a OneDrive for Business account to do this there is no problem. So I want to kwon why this hanppened?

Can you trying adding the offline_access scope to your list of scopes?
I believe some AAD tenants require the explicit request for offline access, where others default to granting all "secure client" apps an offline_access token.

OK, I'll have a try,  thank you.

@rgregg Can you tell me how to add a offline_access scope? I can not find this permission.

Hi @imkk : I realized you're using the "v1" authentication mechanism, which doesn't take scopes the same way the v2 mechanism does. Is it possible for you to see if you can get a refresh token when using the v2 authorization end point, as described here: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-v2-app-registration

Yeah, you are right @rgregg , I found this problem from this page: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-v2-compare. There is no way to solve this problem if I continue to use "v1" authentication mechanism, right?

Hi @rgregg , I have tried to use the v2 endpoint followed here: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-v2-protocols-oauth-code. However, this is too different to use it to replace the OAuth 2.0 authentication flows here: https://dev.onedrive.com/auth/aad_oauth.htm. I don't kown how to switch from each other, so can you tell me what should I do?

Hi @rgregg , I have solve this problem using v2 endpoint.


ImportError: cannot import name 'sd2_clip' from 'comfy' (unknown location)

help......
Traceback (most recent call last):
File "H:\ComfyUI-qiuye\ComfyUI\nodes.py", line 1982, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_ModelScopeT2V_init.py", line 1, in
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_ModelScopeT2V\nodes.py", line 10, in
from .configs.modelscope_config import MODELSCOPE_UNET_CONFIG, SD15_CONFIG
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_ModelScopeT2V\configs\modelscope_config.py", line 6, in
from comfy import sd2_clip
ImportError: cannot import name 'sd2_clip' from 'comfy' (unknown location)
Cannot import H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_ModelScopeT2V module for custom nodes: cannot import name 'sd2_clip' from 'comfy' (unknown location)
Traceback (most recent call last):
File "H:\ComfyUI-qiuye\ComfyUI\nodes.py", line 1982, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 940, in exec_module
File "", line 241, in call_with_frames_removed
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_Native_DynamiCrafter_init.py", line 1, in
from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_Native_DynamiCrafter\nodes.py", line 11, in
from .utils.model_utils import DynamiCrafterBase, DYNAMICRAFTER_CONFIG,
File "H:\ComfyUI-qiuye\ComfyUI\custom_nodes\ComfyUI_Native_DynamiCrafter\utils\model_utils.py", line 9, in
from comfy import sd2_clip
ImportError: cannot import name 'sd2_clip' from 'comfy' (unknown location)

I also found this problem, has it been solved?

I also found this problem, has it been solved?

no...

Plus+1, same question.

comfyui_native_dynamicrafter/utils/model_utils.py
# from comfy import sd2_clip
from comfy.text_encoders import sd2_clip

After modifying the import method, although it can be imported correctly, there will still be other issues that have been confirmed to be caused by Comfyui upgrade，so...


Free sports realted APIs

APIs added are -:

Free NBA
API Football

Related to #2 @TheLearneer

@TheLearneer Requested Changes have been made

@TheLearneer Logo Name is fixed


Try running the build-conflicts.php file only on master

It did run build-conflict again 🤷♀

I'm totally lost. Are you talking about the most recent build for 70c26e4 commit?
Namely we have there:

one pipeline run for "quality check" for fix/skip-build-conflicts-on-non-master-branches  branch
one pipeline run for "php build-conflicts.php" for master branch

Now when I think about it, it looks like it was working as expected except for the duplicate lines for "php build-conflicts.php" @_@

See https://travis-ci.org/Roave/SecurityAdvisoriesBuilder/builds/657945815?utm_source=github_status&utm_medium=notification - not sure why the branch name is master there, the build is still pertinent to the dev branch.
I think that's due to simulated merges.
We'll see in upcoming patches if this solved the problem :woman_shrugging:

Yes, yes it is due to simulated merge to master, but there two if conditions:

for "quality control"  there is if: branch != master so it builds for any branch except for master
for "build" there is if: branch = master so it builds only for master

Without those conditions we would have the following:

—
master branch
branch to be merged

QualityControl stage
will be executed
will be executed

Build stage
will be executed
will be executed

What we have right now:

—
master branch
branch to be merged

QualityControl stage
won't run due to if: branch != master
will be executed

Build stage
will be executed
nope, because if: branch = master kicks in

Bored myself with this last comment, sorry for being annoying :relaxed:


WANT TO ADD THE "Current Score".

In this web page we can watch only highest score.
but we should add the current score also there.

@PREM-A261  Please assign me this one .
I really want to contribute in this project


gRPC proxy: fix streaming and resiliency

Description
This PR completes the work started in #5751 addressing a variety of issues with gRPC proxying, especially when proxying streamed RPCs and/or when Resiliency is enabled.
The most relevant changes include:

Ensure that when resiliency is enabled, when proxying streamed RPCs, the policy (e.g. retries and/or timeouts) now applies to the handshake step only (see #5748 for a description of the issue)
Reworked the replay buffer so at most one message is kept in the buffer and only if there's a resiliency policy with retries enabled. This fixes an issue discovered in #5748 where the replay buffer would grow indefinitely when proxying streamed requests, potentially using a lot of memory.
Changed how proxying of streamed RPCs works, so they are not influenced by timeouts and/or retries in the resiliency policy. In case the streamed connection is dropped, the error is now immediately sent to the two apps so they can re-establish the connection. In this case, messages are not replied (by design).
Added a lot more unit tests, including those validating resiliency and/or proxying of streamed RPCs

There's one important user-facing change: When proxying streamed RPCs, users now have to set an additional metadata property in the headers: dapr-stream set to a "truthy" value (true, 1, yes, etc).
This was required, also as discussed on Discord, as we would have no other way to determine if a gRPC call is a stream or not without knowing the protos (which is not an option in this case).
PS: While working on this, I found that the resiliency package had a method that was not used anymore, and that caused some sub-optimal performance (that code was used in a very hot path). That's the primary reason for the changes in the resiliency package.
Issue reference
Fixes: #5748
Fixes the remaining issues highlighted in: #5751
Relevant for: #5732
Docs issue: dapr/docs#3065

Closed by mistake

Just to be clear: this has no impact on current proxying workloads that use streams and don't use resiliency, correct? users don't have to do anything except for setting the stream header if they are using resiliency and want to apply it.

@yaron2

Just to be clear: this has no impact on current proxying workloads that use streams and don't use resiliency, correct? users don't have to do anything except for setting the stream header if they are using resiliency with gRPC streams and want to apply it.

Yes, that should be the case.
If Resiliency is enabled, or to be precise, there’s a resiliency policy with retries, then setting the “dapr-stream: true” metadata is required. Otherwise, users actually get a runtime error. There’s a new unit test to validate that specifically.
If there’s no resiliency policy with retries, I believe it should work even without the new metadata option because the replay buffer isn’t initialized anyways. I will run some tests tomorrow to confirm that. However, I would still strongly recommend users to set the “dapr-stream” metadata if they’re proxying a streamed RPC.

@yaron2 just ran tests confirming that as long as there's no resiliency policy with retries, setting "dapr-stream=true" is not required for this to work, thus maintaining backwards-compatibility (mostly - users will notice that in case of errors, the entire stream will not be replayed anymore - but that behavior should have been considered a bug in the first place).
I also updated one of the unit tests to confirm the behavior above.
In any case, I think that even though "dapr-stream" is not strictly required, the docs should still say that when proxying streamed requests users should put "dapr-strem=true" regardless. That is: I don't think we should document this situation, when it's not strictly required, as an officially blessed situation, and we should encourage users to do the "safe" thing.

/ok-to-test

/ok-to-test

/ok-to-test


Gem is not available

Hi, I tried using your theme with gem "academic", however that gem appears to be gaalcaras/academic - not your theme. Is there another gem available?

Hi there - yes, that particular gem name was already taken, so I named this theme slightly different. You can find the gem here: https://rubygems.org/gems/academic-jekyll-theme
I noticed that my documentation is incorrect, I will fix that. Thanks for the heads up!


When converted on macOS, it exits with libprotobuf ERROR.

Hello.
I am trying to convert an h5 file to onnx on MacOS. But every time I get a libprotobuf ERROR and I can't convert it.
Is there a solution to this error?
When I ran it on Ubuntu 18.04, it worked fine and I was able to convert it.
environment

OS: MacOS Catalina version:10.15.5
Python==3.6.10
Tensorflow==2.1.0
keras2onnx == 1.7.0 (from github)
onnxconverter-common==1.7.0 (from github)

scripts and log
model:
import tensorflow as tf

def main():
    model = tf.keras.applications.MobileNetV2()
    model.save('model.h5')

if __name__ == "__main__":
    main()

convert:
import os

import keras2onnx
import tensorflow as tf

def convert():
    keras_model_path = os.path.join('original_model', 'model.h5')
    onnx_model_path = os.path.join('onnx_model', 'model.onnx')

    model = tf.keras.models.load_model(keras_model_path)
    onnx_model = keras2onnx.convert_keras(model)
    keras2onnx.save_model(onnx_model, onnx_model_path)

if __name__ == "__main__":
    convert()

execution Log:
$ python convert.py

[libprotobuf ERROR google/protobuf/descriptor_database.cc:394] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
[libprotobuf FATAL google/protobuf/descriptor.cc:1356] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
libc++abi.dylib: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
[1]    95132 abort      python convert.py

Is this bug in load_model or convert_keras?

@jiafatom
There seems to be no error with load_model. The error occurs at the time of importing keras2onnx.

I'm getting the same problem. Everything works fine when I run a script with only the following:
import onnx
import keras2onnx

But when I run a script that fits a keras model, I get this error when python tries to execute the line
import keras2onnx
Output after running above line after fitting model:
[libprotobuf ERROR google/protobuf/descriptor_database.cc:394] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().
[libprotobuf FATAL google/protobuf/descriptor.cc:1356] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
libc++abi.dylib: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
zsh: abort      python test_model.py

I'm getting the feeling this might be a memory problem related after briefly skimming over other forums... potentially something to do with CUDA and Mac OS. I was getting other errors from my Jupyter Notebook on trying to execute the same line (import keras2onnx). See https://github.com/tensorflow/tensorflow/issues/9829

Same issue here. python -c 'import keras; import keras2onnx' is enough to give the above error.
Keras 2.4.3
TensorFlow 2.3.0
Keras2Onnx 1.7.0
MacOS Catalin 10.15.6
Python 3.7.7
In my case, I gave up on MacOS and moved to Linux where things worked just fine ¯_(ツ)_/¯

This seems to be an ONNX package that the converter depends on, please check the related issue here:
https://github.com/onnx/onnx/issues/2940,

@wenbingl
Thank you. I was able to convert it well!


Feature Request: Update Readme to include the Users > Followers page

What
I would like to see the readme for the plugin to include documentation about the Followers page that is created in Settings > Users.
Why
It isn't obvious how to see who's following you, in my opinion.  I'd first looked through the Settings tab for the plugin, then ended up creating a page with the Followers block on it before someone pointed out that it was available under the Users tab.
How
No response

Are those followers of only the current user, or from the blog user, or for all users? And how to see followers of other blog users?


free version shows the changelog

It's hidden on initial load but pops back up later

To reproduce, open a new tab and close it.

Also fixed by https://github.com/Vector35/binaryninja/commit/b48902b69b3c297c38430ab4566a4817775424c9. In fact, this has the same root cause as https://github.com/Vector35/binaryninja/issues/659

Fixed in 4.0.4958-stable


Update to v4 of graceful-fs

With v4, graceful-fs is no longer monkey patched.
The old version of graceful-fs will also be deprecated when node >= 7
Still there are several, much downloaded, packages around which has to update aswell.
Lint and tests are good.
Ref v4

We've already done this on the latest vinyl-fs. You can update to gulp 4.0 (npm install gulpjs/gulp#4.0) or use the latest vinyl-fs directly.

See also https://github.com/gulpjs/gulp/issues/1571

Great.
Looks like I overlooked the issue there. My bad.


Every 10 minutes agent grpc disconnected from collector

Requirement - what kind of business use case are you trying to solve?
Tracing http calls of my microservice
Problem - what in Jaeger blocks you from solving the requirement?
I launched agent and collector 1.14 in docker.
Recently i checked agent logs with docker container logs agent and find that:
{"level":"info","ts":1578533821.070084,"caller":"base/balancer.go:140","msg":"base.baseBalancer: handle SubConn state change: 0xc0002a45b0, CONNECTING","system":"grpc","grpc_log":true} {"level":"info","ts":1578533821.07017,"caller":"roundrobin/roundrobin.go:50","msg":"roundrobinPicker: newPicker called with readySCs: map[]","system":"grpc","grpc_log":true} {"level":"info","ts":1578533821.0700924,"caller":"transport/log.go:30","msg":"transport: loopyWriter.run returning. connection error: desc = \"transport is closing\"","system":"grpc","grpc_log":true} {"level":"info","ts":1578533821.0705376,"caller":"base/balancer.go:140","msg":"base.baseBalancer: handle SubConn state change: 0xc0002a45b0, READY","system":"grpc","grpc_log":true} {"level":"info","ts":1578533821.0706186,"caller":"roundrobin/roundrobin.go:50","msg":"roundrobinPicker: newPicker called with readySCs: map[{<IP_ADDRESS>:14250 0  <nil>}:0xc0002a45b0]","system":"grpc","grpc_log":true} {"level":"info","ts":1578534001.1125383,"caller":"base/balancer.go:140","msg":"base.baseBalancer: handle SubConn state change: 0xc0002a45b0, CONNECTING","system":"grpc","grpc_log":true} {"level":"info","ts":1578534001.1126258,"caller":"roundrobin/roundrobin.go:50","msg":"roundrobinPicker: newPicker called with readySCs: map[]","system":"grpc","grpc_log":true} {"level":"info","ts":1578534001.112556,"caller":"transport/log.go:30","msg":"transport: loopyWriter.run returning. connection error: desc = \"transport is closing\"","system":"grpc","grpc_log":true} {"level":"info","ts":1578534001.1129324,"caller":"base/balancer.go:140","msg":"base.baseBalancer: handle SubConn state change: 0xc0002a45b0, READY","system":"grpc","grpc_log":true} {"level":"info","ts":1578534001.1130183,"caller":"roundrobin/roundrobin.go:50","msg":"roundrobinPicker: newPicker called with readySCs: map[{<IP_ADDRESS>:14250 0  <nil>}:0xc0002a45b0]","system":"grpc","grpc_log":true}
It seems agent disconnected from collector every 10 minutes, is it a bug or just a normal case?

This should not be happening. Are you running those images locally, or are you deploying them in some infra provider, like AWS? I remember reports about something similar happening on an AWS setup.

@jpkrohling  I deployed one agent image and two collector images locally， all in one physical machine.
Actually i have also deployed nginx between agent and collector, could it cause this problem?
Here is my nginx config:
upstream  collector_server {
    server xxx.xxx.xxx.xxx:14260 weight=1 fail_timeout=10 max_fails=1;
    server xxx.xxx.xxx.xxx:14261 weight=1 fail_timeout=10 max_fails=1;
}

server {
    listen   14250 http2;
    server_name xxx.xxx.xxx.xxx;
    access_log /nginx_log/collector_14250.access.log main;

    location / {
        grpc_pass grpc://collector_server;
        proxy_set_header X-Real-IP $remote_addr;
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header Host $http_host;
        proxy_set_header X-Forwarded-Proto $scheme;
    }

}

Does this problem has any effect of the tracing service? actually it seems works fine under my monitor:

TIL that NGINX has native options for gRPC, that sounds really cool :-) In any case, I would try to keep NGINX out of the setup for a while, to check whether that's the component closing the connections.

@jpkrohling  Ahh, i also learned it from my colleagues. I'll try deploy agent and collector without nginx later, if there are any results i'll let you know : )

@jpkrohling sorry for latter reply. recently i tried launching agent and collector images without nginx, and find that it works well, and no more complain about losting connection.
I googled for a while, guess it may caused by nginx periodically  closing connections to grpc server according to the directive [keepalive_timeout], by default it's 65s.
I set this directive to 300s to see what will happen.

May I ask you something then? Your findings might save someone else's time. Would you be open to send a PR to the "troubleshooting guide" adding this? https://github.com/jaegertracing/documentation/blob/master/content/docs/next-release/troubleshooting.md


feat(NumberTheory/AbelSummation): add more results

Add versions for when the endpoints are Nat (for convenience).
Add limit versions for when the endpoint tends to infinity.
Add summability criteria using Abel summation

Question for reviewers: some results are stated in the case c 0 = 0 but still, in this case, the statements contain terms like  ∑ k ∈ Icc 0 ⌊b⌋₊, f k * c k even though the term k = 0 does contribute to the sum.
It is better to leave it like that for consistency (and the user can remove the term k  = 0 latter on if needed) or should I changed the statements so that summations start at 1?


Lua side

The Lua side of the program appears to be done. All tests have worked to far. The test table script is able to be read correctly. I still need to test the actual 300k+ line one, but so far nothing shows signs of bugs.
I will keep this around for a day or two while I try some more stuff before deleting this branch. Next step is the database side

Merged and not deleted


DOC: integrate: document limitation of numerical integration

Reference issue
gh-5428, gh-11571, etc.
What does this implement/fix?
We have received several reports of unexpected results from quad, and quite often the root cause is that the integrator misses the nonzero part of the integrand within a large, finite interval. This adds a note to the documentation about this limitation, which other numerical integrators suffer from, too (e.g. Matlab, Mathematica).

The doc build is broken, so did not check how it renders, but the text looks good.

Not to piggy back on an already merged PR, but it'd be great to suggest checking for consistent results while adjusting error tolerances. Reducing tolerances a bit often can often lead the routine to increase the density of the initial grid enough to locate the important features in the integrand (and works for at least one of the linked issues, for example). This is usually my first (and laziest) check for robustness, especially in multiple dimensions or for unknown/expensive integrands for which it can be nontrivial to manually locate the support of the integral, e.g., by plotting.
At the moment the user guide on quadrature doesn't discuss the tolerance settings at all. I think it'd be valuable to do so, especially since quad reports error estimates and some users won't realize these can't be taken seriously in all circumstances (namely, the reference issues here).
Happy to draft a PR for this if desired.
(As a related aside, that the tolerance arguments to quad are epsabs and esprel rather than atol and rtol always trips me up. I know that, e.g., having multiple keyword args alias to the same thing isn't great design, but the inconsistency with the rest of SciPy here is unfortunate.)

@zachjweiner documentation improvement are always welcomed. Feel free to open a PR 😃


Create boundary relations for dropdown COUNTRY=cambodia

this PR modifies the rendering of the dropdown menu that lists the boundaries at different levels. The levels are created using the number and the order of the elements in the adminLevelNames parameter.
The BoundaryDropdown component enabling multiple interaction with the map, by enhancing the MapInteraction enum. This is needed for the dropdown select within the alert system

Nice start @JorgeMartinezG, I like where this is going. I do have some feedback:

The code seems a lot more complicated than it needs to be, or I might be missing something about the different functionalities?
These changes should also apply to the Alert dropdown selector so that we don't have two distinct objects and the alert selector can benefit from this update
the UI is worse than before, let's try to stick to the UI, fonts and colors we had before? You can ping Garance on Slack if you need help.
Let's have the results organized by alphabetical order (on the first admin level)

@JorgeMartinezG - a few inputs from my side:

If I double-click in the search area of the go to feature, I can no longer search and have to either close the feature or choose an area by click on it in the list of admin areas
I agree with Eric that the new look isn't as clean as what we had before. But we did talk about a way to better show that there are multiple levels now. Perhaps match what was previously there (font size and type) but use indentation and maybe a hyphen prefix to show levels? Something like:

Sorted elements, simplified logic and stored adminlevelnames in an object

@JorgeMartinezG - a few inputs from my side:

If I double-click in the search area of the go to feature, I can no longer search and have to either close the feature or choose an area by click on it in the list of admin areas
I agree with Eric that the new look isn't as clean as what we had before. But we did talk about a way to better show that there are multiple levels now. Perhaps match what was previously there (font size and type) but use indentation and maybe a hyphen prefix to show levels? Something like:

Tried including dashes. IMO it does not look good.

@JorgeMartinezG - The UI looks better to me. But the load time is a problem. I tried making a build and testing that (https://medical-inventionz.surge.sh), but also am facing very slow load times, and on many occasions, the UI never fully loads. I also tried to test with Mozambique and had the same problem. We'll likely need to revisit this when you're back unless you can advise on some quick solutions here.

You could run this once and use both adminLevelNames and adminLevelLocalNames values in your mapping so that this doesn't have to run when users switch language, wdyt?

@wadhwamatic  This could be one cause why the dropdown is taking more time to render.

@JorgeMartinezG - you can see a significant improvement in the initial page load now. Toggling to Khmer is fairly slow though. It seems that all components are loaded before the screen renders in Khmer. Are we able to make this sequential and add a loader? I believe this is how it's managed for the English version.

commit 5c35056 reduces dropdown loading time from 10 seconds to 500 ms. However, is important to mention that this loading overhead might be present when trying to make the level 2 and level 1 multipolygon boundaries from level 3 ones

commit 5c35056 reduces dropdown loading time from 10 seconds to 500 ms. However, is important to mention that this loading overhead might be present when trying to make the level 2 and level 1 multipolygon boundaries from level 3 ones

@ericboucher - the change Jorge made here made this process 20x faster but from what I understand, the approach will slow down future attempts to construct admin boundaries based on unions of lower level boundaries. Since we're not doing this yet, and this PR has been pending for a long time, I'm hoping we can go ahead and merge this. Thanks for adding your review when you can.

@JorgeMartinezG could you add a few screenshots to this PR's first comment?
This is updating the design for both the GoTo and alert functions, correct?


[New Feature]: Navigation bar more responsive and creative

🎮 feature Request
feature logic and basic description
Point down the features
feature points
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I can work on this .Please assign me to do so as i have  experience regrading the same.I have already addressed this issue on my website
https://github.com/GameSphere-MultiPlayer/Community-Page/assets/117531823/a66e8200-d3b2-4f1b-8015-adf12a8c163c

I would like to contribute to this issue. Could you please assign this issue to me?

Please assign me this issue under GSSoc'24.

I would like to contribute to this issue. Could you please assign me this issue under GSSoc'24.

Please assign me this issue under GSSoc'24.


add my first file

I have created a new branch, created a file and made a commit! <3

I finished the module


Adding '#encoding: UTF-8' comment to fix 'incompatible character encoding: /[\u0080-\uffff]/' error

I kept experiencing the following error using execjs with JRuby
SyntaxError - (RegexpError) incompatible character encoding: /[\u0080-\uffff]/:
vendor/bundle/jruby/1.9/gems/execjs-1.4.0/lib/execjs/external_runtime.rb:74:in `encode_unicode_codepoints'
The error goes away if the # encoding: UTF-8 comment is added at the top of external_runtime.rb.

This repository has been deprecated and has moved to https://github.com/rails/execjs.


Error (hspm) ERROR! Storage on class ... modified by storage compiler, developer should have run ^build to make sure all storage is updated correctly and saved to Perforce

eg
zpm:iris-test>IRIS20203>BITMAPADOPTION>install collection-index-and-query
[collection-index-and-query]    Reload START (/opt2/isc/iris20203/mgr/.modules/BITMAPADOPTION/collection-index-and-query/1.0.1/)
[collection-index-and-query]    Reload SUCCESS
[collection-index-and-query]    Module object refreshed.
[collection-index-and-query]    Validate START
[collection-index-and-query]    Validate SUCCESS
[collection-index-and-query]    Compile START
[collection-index-and-query]    Compile FAILURE
ERROR! Storage on class rcc.IC.ItemList modified by storage compiler, developer should have run ^build to make sure all storage is updated correctly and saved to Perforce
zpm:iris-test>IRIS20203>BITMAPADOPTION>install bitmap-adoption
[bitmap-adoption]       Reload START (/opt2/isc/iris20203/mgr/.modules/BITMAPADOPTION/bitmap-adoption/1.0.4/)
[bitmap-adoption]       Reload SUCCESS
[bitmap-adoption]       Module object refreshed.
[bitmap-adoption]       Validate START
[bitmap-adoption]       Validate SUCCESS
[bitmap-adoption]       Compile START
[bitmap-adoption]       Compile FAILURE
ERROR! Storage on class Bmap.Address modified by storage compiler, developer should have run ^build to make sure all storage is updated correctly and saved to Perforce
feeder, json-snapshot, native-api-objectscript, posts-and-tags, remote-server-control, sql-batch-outbound-adaptor, ...

That package has a Persistent class without any Storage defined, and the error says about it.
I agree with it and don't see any reasons to change this behavior.
The author should define Storage, and publish a new version.

Many of our samples (e.g. Samples-BI) have no storage defined, because they intentionally try to be as simple as can be. Also, the errors aren't raised with a simple $SYSTEM.OBJ.LoadDir() or similar (nor with earlier versions of zpm).
I agree this new behaviour is a safe default, but am curious if there'd be a way to be more lenient through some package setting.

This is not a bug for the new version.


Bug in FileReader

FileReader.open(x) returns fewer than x characters even though EndOfFile has not been reached.
var fileReader = new FileReader.open(...)
for x in [0..4]
do
var s = fileReader.read(4)
print "{x}: {s.length}"
end
fileReader.close
Result:
4
4
2
4
Expected:
4
4
4
4
Note that in file.nit, the buffer is initially set to 10, which is why the third call to open(4) returns only 2 characters (the number of characters left in the buffer).

Make sense. A non-full result should mean end of stream or end of current data (eg in a pipe or a tcp socket)  but not end of the internal buffer.


fix: backfill missing metronome Ids

Describe your changes

This implements backfill for missing metronome account ids
If  metronome account Id is missing, get it from metronome and save it in meta store

How best to test these changes

Unit tests

Issue ticket number and link

pushing because initial version was anyways approved except the last 1 liner change in unit tests.


Fetch Doxed Noun Images

A sub issue for #81 and #104
Goal:

Have a performant way to load a doxed wallet's actual noun images (whether a multi-sig or an EOA) into the frontend.

Step 1:

[ ] Figure out a spec / protocol (ie, is fetching directly from on-chain feasible performance wise?)

Step 2:

[ ] Implement Step 1.

on it

quick update:
two calls to the noun token contract required on-chain for each profile pic generation:

tokenOfOwnerByIndex(ADDRESS, 0) -> tokenID
seeds(tokenID)

can then use buildSVG(seeds) as @amirgamil used in his PR for random pics.
I'm going to see how painful it is to pull N = 20 profile pics using these two calls from my machine.
Want to avoid caching as we'd need to update the cache on NFT xfers...

could we also grab the images and cache them as part of the merkle cron job?
Sent from Proton Mail for iOS
El mar, 16 may., 2023 a las 7:37 p.m., Lakshman Sankar @.***(mailto:El mar, 16 may., 2023 a las 7:37 p.m., Lakshman Sankar < ha escrito:

quick update:
two calls to the noun token contract required on-chain for each profile pic generation:

tokenOfOwnerByIndex(ADDRESS, 0) -> tokenID
seeds(tokenID)

can then use buildSVG(seeds) as @.***(https://github.com/amirgamil) used in his PR for random pics.
I'm going to see how painful it is to pull N = 20 profile pics using these two calls from my machine.
Want to avoid caching as we'd need to update the cache on NFT xfers...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

quick update:
two calls to the noun token contract required on-chain for each profile pic generation:

tokenOfOwnerByIndex(ADDRESS, 0) -> tokenID
seeds(tokenID)

can then use buildSVG(seeds) as @amirgamil used in his PR for random pics.
I'm going to see how painful it is to pull N = 20 profile pics using these two calls from my machine.
Want to avoid caching as we'd need to update the cache on NFT xfers...

@lsankar4033  cc @cha0sg0d  @amirgamil
Do you think fetching the seeds from the Nouns Subgraph will be easier? Since we already have a cron job that will run every 5min, we can fetch the seeds along the list of nouns, generate the SVGs, and store the SVGs in the database as text.
And are we planning to use ENS avatars for delegates? or do you think we can use the noun image for the delegates as well, with something to indicate that the user is a delegate?  (like the purple circle around the image for nym)

fetching the seeds from the subgraph makes sense, but we'd still need to find the tokenID held by each address (1 query to chain).
But yes, no reason not to cache tokenID -> seed as this is unchanging (vs. address -> first tokenID, which may change if someone sells/trades)

@lsankar4033
I might be missing something, but to just share info I'm seeing, it seems like we can fetch the mapping (tokenId -> address -> seed) from the subgraph.

(My confusion might be coming from not understanding where ENS plays a role)

simple alternative may be to just use the ENS avatar specified on the ENS record itself (ie. as returned by https://wagmi.sh/react/hooks/useEnsAvatar)
will weigh the options and make a decision

simple alternative may be to just use the ENS avatar specified on the ENS record itself (ie. as returned by https://wagmi.sh/react/hooks/useEnsAvatar)
will weigh the options and make a decision

to clarify, this would mean not showing the user's associated noun, just their ens image (if set)? Also, we'd still probably want to cache this data somewhere, but I'm unsure if wagmi does that for us.

yes that's right. I'm leaning towards caching no matter what

most recent decision is to use getENSAvatar for this and not cache (cc @cha0sg0d )


Bug in scalar reduction?

One more! Again from CI, not sure why this case should be problematic:
function fwd(r22::AbstractArray{T}, x, r312, ax_b=axes(x,2), ax_β=axes(r312,2), ax_a=axes(r312,2), ax_c=axes(r312,1)) where T
        acc = zero(T)
        # for c in ax_c  # works fine without @avx
        @avx for c in ax_c
            for a in ax_a
                for β in ax_β
                    for b in ax_b
                        acc = acc + r22[b, β] * x[a, b, c] * r312[c, a, β]
                    end
                end
            end
        end
        acc
end
r22, x, r312 = rand(2,2), rand(1,2,3), rand(3,1,2)
fwd(r22, x, r312) # UndefVarError: ####op#568_0 not defined

fwd(rand(3,3), rand(3,3,3), rand(3,3,3)) # similar, so not about size=1 dimensions

There's the joke about cache invalidation and naming things being the two hardest things in programming.
I can't speak about the former, but LoopVectorizaiton.jl certainly thinks it is the latter...
The rewrite will handle that totally differently.

Proof that gensym() doesn't solve all naming difficulties!
But sure, no rush, this one's skipped in testing & didn't bite anyone in real life.

Fixed on master, releasing soon.
With AVX512, it is also much faster now than it was when/if it worked earlier, due to adding a workaround for a bug in LLVM where it starts spilling registers to an absurd degree (when it shouldn't be spilling at all) when there are too many phi nodes, or something of that sort.


Octane uft integration

Handling data table and defects
Update octane dependencies version (mqm & java-sdk to 1.4.4)

Jenkins issue : JENKINS-44714

:white_check_mark: Build hpe-application-automation-tools-plugin master.80-naasnyvk completed (commit https://github.com/hpsa/hp-application-automation-tools-plugin/commit/56df015fb4 by @m-seldin)

Please separate Jira tickets and add ticket only on major issues or features

@jackhpe Please approve this PR as it touched UFT Execs

Approved for test build


tests/tls: add testcases for JA3S

This PR contains testcases that @victorjulien wants for OISF/suricata#3874.

Merged, thanks Mats!


Meta cnb releases do not print out dependencies

With the change from tgz to buildpackages for referencing implementation cnbs from meta cnbs,
meta cnb draft releases do not print list of dependencies anymore.
See:
https://github.com/paketo-buildpacks/nodejs/releases/tag/untagged-4acc022b4b2bc34b8fca
https://github.com/paketo-community/python/releases/tag/untagged-44e0b4d6c3a9d287d1e7

This has been addressed by adding buildpackage support to jam summarize in https://github.com/paketo-buildpacks/packit/releases/tag/v0.2.2. We will need to update the version of jam used in our workflows to support this new functionality.

This is resolved by https://github.com/paketo-buildpacks/github-config/pull/104.


webserver config info

Short Description:
Fixes:

updated

+1

We don't accept PR on master to keep thing easy...


Feature proposal: Listen to and report securitypolicyviolation events

All major browsers support the SecurityPolicyViolationEvent:
document.addEventListener("securitypolicyviolation", (e) => {
  console.log(e.blockedURI);
  console.log(e.violatedDirective);
  console.log(e.originalPolicy);
});

The apps I'm working on are very strict and security conscious. We serve all of our requests with a strict CSP and use the report-to/report-uri feature to track violations. This is sort of annoying though, since the service we use to track this is separate from our main bug tracker (Bugsnag) and other monitoring tools.
We'll probably add our own listener to this event and pipe it to Bugsnag as an info notification, but I think it would also make sense for Bugsnag to add direct support for this. Right now I think we only get partial, less high quality, reporting of this with Bugsnag via it hooking console.error or exception handling

Hey @backus, will put this to our product team for their consideration, thanks for raising! Like you say, in the meantime it's possible to add a listener and handle the error by calling Bugsnag.notify() with the information in the object that this event throws. Will keep you posted with any updates in this thread.

Hi @Haraldson,
This is still on our backlog, higher priority items have meant we have not yet got round to this. So unfortunately we don't yet have a good idea in terms of timeframes doing this work. We will update here as soon as we do.

Hi, I am looking for this feature as well. Has there been any progress in the past 2.5 years? I see other reporting tools such as Sentry support this natively (meaning you can directly point to the reporting tool in the CSP header directly), but I don't see it in Bugsnag yet. Is this correct?

Hi @zhimdi-uab
Unfortunately we do not have any new updates to share at the moment. I've registered your interest with our product team but this is still on our backlog and we will be sure to update this thread when we have more information.


build-script: Throttle the number of parallel tests run acording to -j.

This patch propagates the number of parallel jobs from build-script to
llvm-lit. Due to the way how build-script-impl is implemented, changing this
number needs a reconfigure for the Swift tests and can be done on the fly for
LLDB tests, since build-script-impl directly invokes llvm-lit in the latter
case.
rdar://problem/52062631

@swift-ci test and merge

it still used 32 cores - 15:55:33 -- Testing: 12001 tests, 32 threads --

On which bot did you see that?
https://ci.swift.org/view/swift-5.1-branch/job/oss-swift-5.1-incremental-RA-linux-ubuntu-16_04/1287/consoleFull#console-section-7
-- Testing: 11985 tests, 16 threads --

https://ci.swift.org/view/swift-5.1-branch/job/oss-swift-5.1-incremental-RA-linux-ubuntu-18_04-long-test/819/consoleFull#console-section-1
06:34:12 -- Testing: 12003 tests, 8 threads --

Note that the change needs a --reconfigure to go into effect.


WIP,MNT: window and layout in GUI API

This PR refactors _QtWindow:

adds support for custom central layout
adds _window_create to spawn a window 'without pyvista support' (instance of _MNEMainWindow)
adds the option theme_support to opt-out from automatic theming

and _QtLayout:

adds support for grid layout

Here is a code snippet to try:
from mne.viz.backends.renderer import _get_renderer

renderer = _get_renderer()
renderer.show()

window = renderer._window_create()
window.show()

Further consideration:

With more refactoring it should be possible to use _get_renderer() to spawn _MNEMainWindow instead of using _PyVistaRenderer. This more important matter is about about having a GUI API which does not depends on pyvista.

It's an item of https://github.com/mne-tools/mne-python/pull/10565

Sounds reasonable, let me know when to look!

This is delayed until https://github.com/mne-tools/mne-python/pull/10565#issuecomment-1132687477 is resolved.

Okay, let me know what PR to review whenever one of them is ready

Assuming the CIs return green, this is ready for review @larsoner

The failure on Test Windows 3.9 pip does not seem related:
================================== FAILURES ===================================
________________ test_spatio_temporal_cluster_adjacency[Numba] ________________
mne\stats\tests\test_cluster_level.py:576: in test_spatio_temporal_cluster_adjacency
    spatio_temporal_cluster_test([data1_2d, data2_2d],
<decorator-gen-336>:12: in spatio_temporal_cluster_test
    ???
mne\stats\cluster_level.py:1357: in spatio_temporal_cluster_test
    return permutation_cluster_test(
<decorator-gen-333>:12: in permutation_cluster_test
    ???
mne\stats\cluster_level.py:1123: in permutation_cluster_test
    return _permutation_cluster_test(
mne\stats\cluster_level.py:983: in _permutation_cluster_test
    H0 = parallel(
mne\utils\progressbar.py:157: in __exit__
    os.remove(self._mmap_fname)
E   PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmp_mne_progky0ehjn_'
--------------- generated xml file: D:\a\1\s\junit-results.xml ----------------

That looks like a replication of https://github.com/mne-tools/mne-python/issues/10648 on CIs, the first time I've seen it! Agreed it's unrelated, though


Remove PSP validation

Remove PSP validation. PSP fields were removed from the Cluster resource in Rancher v2.9 in this PR, this causes the webhook to fail if the Rancher version is bumped.
The minimum k8s version that rancher v2.9 will support is 1.25 where PSP is removed from the upstream.

This should be fixed with https://github.com/rancher/webhook/pull/366/

The minimum k8s version that rancher v2.9 will support is 1.25
I was under the impression the minimum version would be 1.27. Would you mind letting me know where you've seen 1.25? Thanks!

Thanks @tomleb! superseded by https://github.com/rancher/webhook/pull/366


Add support for generating nested polymorphic models (#153)

Add support for generating nested polymorphic models
Closes (#153)

I think the best thing to do is for me to merge this next week and cut a pre-release. Then test that pre-release against a couple of more complex APIs at Zalando to make sure it doesn't break anything. If all good, we can promote to maven central


Snippets in YAML not working

    "[yaml]": {
        "editor.quickSuggestions": {
            "other": true,
            "comments": false,
            "strings": true
        }
    }

in settings.json, this fixed the issue for me - I guess intellisense doesn't work on strings in VScode & sees everything in yml as a string?

Yes - the default config for quick suggestion is to be disabled inside comments and strings


Add option to refresh Stop loss automatically

Hello,
It would be great if we can add an option to automatically refresh the stop loss value (following the stop loss in points entered in the settings)
the issue is that I have to click on the stop loss to refresh the value because entering a trade.
I would prefer the stop loss to refresh automatically.
When setting stop loss in the settings to 100 points for example. I would like it to move like the entry.
Example with SL = 100 points (Long position)

Entry price is: 1.9048
SL: 1.9038

Price is moving down to 1.9045 on the next tick

Entry price is now: 1.9045
I would like SL to be automatically: 1.9035

Suggestion:
Add an option to refresh automatically the stop loss on each tick

Did you try setting the SLDistanceInPoints input parameter to true?

That's the input that I filled for the SL

Working with SLDistanceInPoints, Stop-loss price is replaced with the distance in point. Working fine there. Thank you


Can't access fixture data when using IUseFixture

I'm new to BDD and xBehave but I'm already a convert!
I'm currently trying to write an integration test to test my code against a closed-source host application, I'm using a fixture which starts everything up and then shuts down gracefully when disposed, the fixture works fine for Facts and Theories but when I try to write a Scenario it seems to be started and stopped several times but is never actually available when a Scenario runs.
The following Fact HostExistsForFacts passes but the Scenario HostExistsForScenario fails.
using System;   //V<IP_ADDRESS>
using FluentAssertions; //V<IP_ADDRESS>
using Xbehave;  // V<IP_ADDRESS>
using Xunit;    // V<IP_ADDRESS>0

namespace MyNamespace
{
    public class FixtureXBehaveTest : IUseFixture<AnApplicationHost>
    {
        public void SetFixture(AnApplicationHost data)
        {
            this.Host = data;
        }

        private AnApplicationHost Host { get; set; }

        [Fact]
        public void HostExistsForFacts()
        {
            this.Host.Should().NotBeNull();
            this.Host.Application.Should().NotBeNull();
        }

        [Scenario]
        public void HostExistsForScenario()
        {
            AnApplicationHost fixture = null;
            "Given the Tests Fixture"
                .Given(() => fixture = this.Host);

            "Then it should exist"
                .Then(() => fixture.Should().NotBeNull());

            "and have an accessible Application"
                .And(() => fixture.Application.Should().NotBeNull());
        }
    }

    public class AnApplicationHost : IDisposable
    {
        public AnApplicationHost()
        {
            Application = new object();
        }

        public object Application { get; private set; }

        public void Dispose()
        {
        }
    }
}

I'm using the xUnitContrib 1.2 runner for ReSharper 7.1 with VS2012 U2.

IUseFixture has been removed in xunit 2 and therefore xbehave 2.0 has no need to support it.
2.0 is currently in RC (https://www.nuget.org/packages/Xbehave/2.0.0-rc002-build543).
This will remain as a bug in 1.x, unless someone can sell me a very compelling reason why they need to stick to 1.x and why they need this to be fixed :wink:.


Using jammy

Tested using dev environment

@kltm
Both PRS are ready. Let me know if you run into any issues when testing

Isolated to docker/ and provision/.

Excited about Jammy!


Added Fury

Added Fury (2014) 4K UHD with extras

Woah, I think that might have tried to commit the changes, reverting the crown, too. I thought I updated repo today before I added FURY. That's my mistake. I will fix this


Remove draft mentions on site pages

@jaysonmc @smellems @gabrielcossette @arushisharma19 @remyb2canada
Proposing we remove the DRAFT mention on page titles since we added a notice across the site.
Also, proposing we move the notice at the bottom of the page?

agreed that we could remove "DRAFT" from all pages.
But we should have an indication of the maturity level of the page/document. I.e. a category of:

work in progress
in peer review
approved

What may be challenging is that if we have an approved doc (e.g. StrategyRoadmap) but that we then start making changes to it. Would we then have an "approved" version and a "work in progress" version? I guess at that stage, if a page is "approved" that means any modifications to it must be done in a separate branch and that branch gets approved accordingly (not just by the team but also by the governance bodies)

Related to #213
Duplicate


Wrong UI in EKS cluster edit

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create EKS cluster with custom Subnets/VPC and custom Security Groups
Edit the cluster
Subnets are not editable and the UI shows the wrong subnets selection (Standard: VPC and Subnets are automatically created)

Result:

Show in the UI the previously selected subnets

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.6, 2.5.7
Installation option (single install/HA): single install and HA

Reproduced this issue on v2.5.7 and v2.5.5.
Steps:
Create EKS cluster with custom Subnets/VPC and custom Security Groups
Edit the cluster
Result:
Custom subnet is not shown: Standard: VPC and Subnet are automatically created
During cluster provisioning and before the EKS operator sync, the correct subnets are still shown on edit:

@aaronRancher After the EKS operator sync does the data in upstreamSpec on the cluster object match what is in the config? If something is happening to the data after the sync occurs this wouldn't be a UI issue.

@westlywright The upstreamSpec matches the config after EKS operator sync. Subnets are still seen in upstreamSpec.
"upstreamSpec": {
"amazonCredentialSecret": "cattle-global-data:cc-k75sv",
"displayName": "aaron-test4",
"imported": false,
"kmsKey": "",
"kubernetesVersion": "1.18",
"loggingTypes": [ ],
"nodeGroups": [
...
},
"maxSize": 2,
"minSize": 2,
"nodegroupName": "aaron-ng",
"requestSpotInstances": false,
"resourceTags": null,
"spotInstanceTypes": null,
"subnets": [ 2 items
"subnet-1ed44d64",
"subnet-6127e62d"
],
...
"region": "us-east-2",
"secretsEncryption": false,
"securityGroups": [
"sg-0aa35aee3658b0e2a"
],
"serviceRole": "",
"subnets": [ 2 items
"subnet-1ed44d64",
"subnet-6127e62d"
],
"tags": { },
"type": "/v3/schemas/eksClusterConfigSpec"
},

This bug fix is verified with v2.5-head version 41f173a and master-head version 1c3629f
Previously selected subnets are visible on cluster edit.
If the user does not use a preexisting subnet, Rancher created VPC and Subnet is seen on edit.


Feature/rewind multipart tres

Merge in isakovp's fix for multipart. This should fix our 'infinite hang on multipart post (uploading a recording)' issue
See lostisland#347 for some more.
This is a different PR so we do have a merge commit.

@sfgeorge

Thank you for all the PRs on this!  Looks great! :+1:
@ajayanty Can you merge this?

This has been merged into cloudvox:ifbyphone-develop


Close connection

Hello guys
I'm new in Elixir and I cannot close the connection in my request.
{:ok, conn} = Redix.start_link()
Redix.command(conn, ~w(INCR mykey))

# Want to close the connection here. How can I do this?

I'm sorry:
https://github.com/whatyouhide/redix/blob/master/lib/redix.ex#L174
Redix.close(conn)


fix: truncated text+no ellipsizeMode on Android rail card meta

This PR resolves []
Description
This PR addresses the artwork title and artist name truncation not happening properly on android. - Surfaced during our mobile QA Session https://www.notion.so/artsy/Android-Artwork-title-not-center-aligned-cuts-off-on-Artwork-Rails-12acab0764a08052b672dac3c0c0d79a?pvs=4
Context:
Seems like our palette-mobile text doesn't handle properly the ellipsizeMode properly although the prop is being passed correctly, I am thinking that it might have to do with styled components.
In the meantime found this workaround, using RNText (the original react native text) as a wrapper / parent for the problematic surfaces the palette-mobile texts seem to inherit correctly both numOfLines and ellipsizeMode.
See screenshots below:

Before
After

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

truncated text+no ellipsizeMode on Android rail card meta

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

recording an iOS video just to make sure nothing broke there

This PR contains the following changes:

Android user-facing changes (truncated text+no ellipsizeMode on Android rail card meta - gkartalis)

  Generated by :no_entry_sign: dangerJS against 95059c2d28dd40ae5ca6515f629803a189d7d24d

ios also looks good


Support for kernels v4.16 and USB 3.1 in PC

Required Info

Camera Model
SR300

Firmware Version
Open RealSense

Operating System & Version
Linux (Ubuntu 14)

Kernel Version (Linux Only)
(e.g. 4.16.0)

Platform
PC

SDK Version
1.12.0

Language
python}

Segment
others }

Issue Description
BlasterX Senz3D(SR300) camera won't connect.
Error message:
terminate called after throwing an instance of 'rs:: error'
what(): VIDIOC_S_CTRL error 25, Inappropriate ioctl for device
Aborted (core dumped)
Note
Since my PC doesn't have a USB 3.0 port, I am using a USB to Type C converter, since my PC has a Type C 3.1 port.

Kernel 4.16 has been supported in the SDK since version 2.16.1.
It sounds as though your PC has what is known as a USB 3 OTG (On The Go) port, which is a micro-USB port that allows the attachment of full size USB devices via an adapter.
Is your PC a device such as a small single-board computer, please?

I am using a laptop. My system configuration is:
Model: Lenovo Ideapad 320-15isk 80XH.
Processor: Intel Core i3-6006U (6th Gen).
USB 2.0:  2  Ports
USB 3.0: Not Available
Type C USB 3.1:  1 Port
I'm using a USB Type C to USB 3.0 converter to connect the the SR300 camera as I don't have any USB 3.0 port.

Your processor is compatible with SR300, so the problem is not likely to be processor-related.  I would be inclined to think it was a USB issue.  The SR300 can have problems with full USB 3.0 ports in regard to stability, so a micro-USB port may introduce even more potential for problems (since they are susceptible to not delivering enough power to the camera).
If it is a USB related issue, using a mains-powered USB 3 hub with a USB-C connector to provide USB 3 ports for your laptop, and attaching the SR300 to the hub, may increase stability.
https://www.amazon.com/s/ref=nb_sb_noss?url=search-alias%3Daps&field-keywords=usb+type-c+hub+powered

I am using a USB Type-C to USB 3.1 Gen1 Adapter to connect my camera to the laptop but it still got the same error.
https://www.amazon.com/AmazonBasics-Type-C-Gen1-Female-Adapter/dp/B01GGKYXVE/ref=sr_1_3?ie=UTF8&qid=1544783222&sr=8-3&keywords=usb+type-c+to+usb+3.1

It seems to be a 'passive' connector that draws power from the computer's USB port.  A mains-powered hub is 'active' because the power is supplied to the USB port from the mains socket supply rather than the PC's power supply unit.

Hello @sudeepbanik ,
Librealsense version 1.12.0 (SDK1) is officially supported with LTS kernel 4.4.0-xxx. De-facto, we relaxed the constrain by allowing v1.12 to work correctly with all Ubuntu Xenial LTS kernels 4.[8/10/13/15] using SDK2's patches suite.
Kernel 4.16 introduced incompatible uvcvideo change by splitting the each video device into video and metadata nodes for native metadata support. This modification is integrated exclusively into SDK 2.
Basically the options are:
-- Upgrade the library to SDK version 2  (2.17.0 is the latest), which has full support for SR300.
-- Remain the Librealsense v1.12.0 , but downgrade the kernel to one of the official Ubuntu LTS kernels


refactor [bitbucket] service

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS


Confirmator bug

:tada: This PR is included in version 9.9.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


test: all .js files include 'use strict'

Coverage remained the same at 100.0% when pulling 1b1d0d64cfceea77ff8c2207006d9ab24aaaaed5 on test/use_strict into 5eb45792bb56581e20372ec1b8e1ea613dc7552c on latest.


undefined function

I have hrl file where i have defined the records.
-compile([{parse_transform, rec2json}]).

%% For user File location

-record(filelocation,{dc_id= 5 :: integer(),
                      volume_id= -1 :: integer(),
                      local_id= -1 :: integer(),
                      secret= -1 :: integer(),
                      ext= <<"">> :: binary()}).

-type(tl_fileLocationUnavailable() :: #filelocation{dc_id  :: integer(),
                                                    volume_id :: 0,
                                                    local_id :: 0,
                                                    secret  :: 0,
                                                    ext  :: binary()}).

%% For user photos

-record(photo,{photo_id = -1 :: integer(),
               photo_big=  #filelocation{} :: tl_fileLocation() | tl_fileLocationUnavailable(),
               photo_small= #filelocation{} :: tl_fileLocation() | tl_fileLocationUnavailable()}).

-type(tl_photoEmpty() :: #photo{photo_id     :: -1,
                                       photo_big ::  tl_fileLocationUnavailable(),
                                       photo_small :: tl_fileLocationUnavailable()
                                        }).

later i have another module where i am using those structures
as
Big = #filelocation{dc_id = BDc_id,local_id = BLocal_id,ext = BExt,secret = BSecret,volume_id = BVol_id},

Small = #filelocation{dc_id = SDc_id,local_id = SLocal_id,ext = SExt,secret = SSecret,volume_id = SVol_id},

P = #photo{photo_id = BMedia_id, photo_big = Big,photo_small = Small},
?DEBUG("to json photo  ~p",[P:to_json()]),

and i get error
mod_contacts:prepare_user(<<"cinoabnt.com">>,<<"6789asd122">>).
** exception error: undefined function filelocation:to_json/1
Please help @lordnull

@lordnull  i read the issue  https://github.com/lordnull/rec2json/issues/9  however i have couple of nested records where i cannot keep the same name as the module and i wnat to keep them in one header file for the code reusablity .

Keeping your records in one header file will work; you can include the header in multiple modules, each with a name of the record. (Examples below assume the parse_transform is done on the erlc call rather than a module by module basis).
records.hrl:
-record(r1, { f1 }).
-record(r2, { f1 :: #r1{} }).

Module r1:
-module(r1).
-include("records.hrl").

Module r2
-module(r2).
-include("records.hrl").

Older versions of rec2json provided an erlscript that would scan *.hrl files and generate modules based on the records found there, but that was discarded as it introduced difficulties integrating rec2json into projects.
The second part, having the record name be different from the module name is problematic. Rec2json is coded to assume ModuleName == RecordName so that the field types can be pulled and used at run-time. Altering that part looks like it would be a pretty significant chunk of work. There's also consideration to be made about the getter/setter style of Record:field_name() (though I could be the only person who uses that).
However, if rec2json encounters a record type, those conversions are wrapped in a try/catch, so you shouldn't be getting an undef, you should be getting a 'badarg'. I'd like to see a stack trace, as you may have found a bug which must be squished.

Closing due to no feedback; I hope you resolved your problem.


Signature immutability RFC

Rendered

We have discussed this RFC on the 2023-12-11 weekly meeting. The disposition was to merge, without changes.


Basic support for notifications when parallelism configuration changes

This allows changes in the parallelism configuration to be sent out as notifications to things that care such as WorkerLeaseRegistry and BuildOperationExecutor.  This is preparatory work for pulling these services up to a higher scope to make them more long-lived.

@eskatos Just to comment on the highlighted highlighted todo above - that comment deals specifically with TaskPlanExecutor and dynamic changes to parallelism configuration.  This PR is primarily in preparation for pulling WorkerDaemonFactory and BuildOperationExecutor up to gradle user home scope, where they will need to respond to changes in parallelism when a new build starts.  TaskPlanExecutor will stay at gradle scope and will only need to respond to changes if we ever implement truly dynamic adjustments during the course of a build.  Since that's not necessary (and would not be used) at the moment, I don't think that needs to be done as part of this story.


[Bug][Module Name] WebhookDeployTaskRequest.StartedDate is not optional

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
{"code":0,"success":false,"message":"input json error (400)
Wraps: (2) Key: 'WebhookDeployTaskRequest.StartedDate' Error:Field validation for 'StartedDate' failed on the 'required' tag
Error types: (1) *hintdetail.withDetail (2) validator.ValidationErrors","causes":null,"data":null}

What do you expect to happen
Update curl command in Webhook deployment example command, to state the field is required, not optional.

How to reproduce
curl https://devlake.localhost.com/api/rest/plugins/webhook/connections/2/deployments -X 'POST' \
-H 'Authorization: Bearer XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX' \
-d '{ "deploymentCommits":[ { "commit_sha":"the sha of deployment commit1", "repo_url":"the repo URL of the deployment commit" } ] }'

Note start_time is not indicated in JSON query.
Anything else
No response
Version
1.0.0-beta5
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Fixed by https://github.com/apache/incubator-devlake/pull/7554


[RFE] Create namespaces

Is your feature request related to a problem? Please describe.
k8s-netperf should take care of creating/removing the required namespaces so we don't need to create it externally.

I have gone back and forth on this... There was once a pattern in k8s where tools would explicitly expect the user to create the namespace/service accounts to avoid someone doing something dumb in production...  I don't have a strong feeling one way or another.


Fix SS2 check

With some ss2 responses the ss2 validation check was failing.
I traced down an example of such a response and added it to the
test (sorry if you received an email from paysera, I used the credentials from this project).
CGI.unescape was unnecessarily modifying some characters in ss2, hence the failure (see the tests).

Yeah, you are right. Merged and released.

thanks :+1:


Fix wrong Stylesheet Import

The original import of Google Fonts did not return the full set of fonts required by the theme.
This pull request contains a fixed google fonts URL.

Thank you @sebwarnke


Very long audio files crash/cause OOM

We are loading the entire audio file at once (calling librosa.load) - if we switch to chunk-wise processing or librosa.stream this would be avoided. A similar issue was raised in #26

This pr solves the problem. Nice work. :)


Support for Material Symbols

The team at Google Fonts recently released Material Symbols, a new, much more customizable version of Material Icons.
It would be amazing if you could add support for them, by adding a second workflow looking for the latest version of Material Symbols and a separate material-symbols.css for them.

Thanks for letting me know. I added them to a separate package material-symbols in a separate repo marella/material-symbols.
Please see README for more info.

That's amazing, thank you so much @marella! I'll try it out asap.


bevy_mocks crate

Objective
To be able to write illustrative examples in bevy crates which do not depend on each other.
For example, to write good examples in bevy_ecs crate, we really need dependencies on crates like bevy_app or bevy_pbr.
dev-dependencies are used in doctests. Also dev-dependencies can be cyclic (e.g. bevy_ecs can dev-depend on bevy_app), but such crates cannot be published.
Solution
The proposed solution is to add bevy_mocks crate which basically contains bevy crate API with mock implementations.
So doctests won't really test much, but are useful as published code examples.

Interesting, but I'm on the idea that bevy_ecs docs should primarily cover bevy_ecs usage, not Bevy crates that depend on bevy_ecs. However, since the entire Bevy engine is strongly cohesive, I think it is fair to use items in examples that are on dependent crates (to a limited capacity).
Though honestly, I don't know if it's worth it to create a whole set of mock elements for just a couple of cases. Plus, if the original item changes, it should be manually be changed in bevy_mock, which is a significant burden. I would rather wait that the dev-dependencies issue gets resolved.

I don't know if it's worth it to create a whole set of mock elements for just a couple of cases

It has been countless times when I saw API and don't understand how to use, so had to to read the sources. Simple examples help I believe.
It is a couple cases yet, should be much more.

if the original item changes, it should be manually be changed in bevy_mock, which is a significant burden

I believe maintaining these mocks would be less trouble than writing good documentation and keeping it up to date.

I would rather wait that the dev-dependencies issue gets resolved.

The issue was created in 2017, so I don't expect it to be resolved soon.
Bottom line is: I would be happy if there was better solution.

I would rather wait that the dev-dependencies issue gets resolved.

Agreed with @stepancheg; I don't think that's a particularly viable path forward given the duration it's been open and the resourcing levels of the rust-docs team.
No strong feelings on this PR: I could see an argument for either.

Pulling bevy_app into bevy_ecs would solve this issue.
Closing this for now. Can reopen later if there's stronger opinion for this solution.


Multiple fields not passing values during a $POST

Hi,
I don't know if I am doing something wrong, but when I try using multiple fields (first-name, last-name) the values don't get passed through the $POST method in the form.  It works when I use the singular (name) field.  But I need it separated.
form action="http://somepage" method = "post"
input placeholder="Enter First Name" type="text" name="first-name"/
I am using the suggested form selectors in the java script:
formSelectors: {
nameInput: 'input[name="first-name"], input[name="last-name"]'
}
Thanks for your help!

2 days and no response? Thanks any way...

This is related to https://github.com/jessepollak/card/issues/254 I think, same problem different fields.

I don't think those two issues are related. This seems like an issue with your form rather than card, so unfortunately I can't help out here. Good luck!


TypeError com.tns.Runtime.callJSMethodNative

TypeError
com.tns.Runtime.callJSMethodNative
TypeError:
at android.app.ActivityThread.performDestroyActivity (ActivityThread.java:4710)
at android.app.ActivityThread.handleDestroyActivity (ActivityThread.java:4733)
at android.app.servertransaction.DestroyActivityItem.execute (DestroyActivityItem.java:39)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:145)
at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:70)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1955)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:214)
at android.app.ActivityThread.main (ActivityThread.java:7073)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:964)
Caused by: TypeError:
at com.tns.Runtime.callJSMethodNative (Native Method)
at com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1242)
at com.tns.Runtime.callJSMethodImpl (Runtime.java:1122)
at com.tns.Runtime.callJSMethod (Runtime.java:1109)
at com.tns.Runtime.callJSMethod (Runtime.java:1089)
at com.tns.Runtime.callJSMethod (Runtime.java:1081)
at com.tns.NativeScriptActivity.onDestroy (NativeScriptActivity.java:39)
at android.app.Activity.performDestroy (Activity.java:7681)
at android.app.Instrumentation.callActivityOnDestroy (Instrumentation.java:1310)
at android.app.ActivityThread.performDestroyActivity (ActivityThread.java:4695)
This is the app crash report by Google Play Console.
Below is the tns info command result
√ Getting NativeScript components versions information...
‼ Update available for component nativescript. Your current version is 6.1.0 and the latest available version is 6.2.0.
‼ Update available for component tns-core-modules. Your current version is 6.2.0 and the latest available version is 6.2.1.
‼ Update available for component tns-android. Your current version is 6.1.2 and the latest available version is 6.2.0.
× Component tns-ios is not installed.

and package.json
{
  "name": "nsfmobileaudit",
  "nativescript": {
    "id": "org.nsf.mobileaudit",
    "tns-android": {
      "version": "6.1.2"
    }
  },
  "version": "1.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e",
    "android": "tns build android --bundle --uglify",
    "ios": "tns run ios --bundle"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~8.2.0",
    "@angular/common": "~8.2.0",
    "@angular/compiler": "~8.2.0",
    "@angular/core": "~8.2.0",
    "@angular/forms": "~8.2.0",
    "@angular/http": "8.0.0-beta.10",
    "@angular/platform-browser": "~8.2.0",
    "@angular/platform-browser-dynamic": "~8.2.0",
    "@angular/router": "~8.2.0",
    "@ngx-translate/core": "^11.0.1",
    "@ngx-translate/http-loader": "^4.0.0",
    "@nstudio/nativescript-loading-indicator": "^1.0.0",
    "@types/crypto-js": "^3.1.43",
    "core-js": "^2.5.4",
    "crypto-js": "^3.1.9-1",
    "nativescript-angular": "^8.2.1",
    "nativescript-appversion": "^1.4.1",
    "nativescript-background-http": "^3.3.1",
    "nativescript-bitmap-factory": "^1.7.1",
    "nativescript-camera": "^4.5.0",
    "nativescript-directions": "^1.3.1",
    "nativescript-drawingpad": "^3.0.3",
    "nativescript-fingerprint-auth": "^7.0.2",
    "nativescript-geolocation": "^5.1.0",
    "nativescript-imagepicker": "^6.0.5",
    "nativescript-sqlite": "^2.3.3",
    "nativescript-sqlite-commercial": "file:nativescript-sqlite-commercial-1.3.2.tgz",
    "nativescript-sqlite-encrypted": "file:nativescript-sqlite-encrypted-1.4.0.tgz",
    "nativescript-store-update": "^1.0.2",
    "nativescript-theme-core": "^1.0.4",
    "nativescript-zip": "^3.0.0",
    "reflect-metadata": "~0.1.12",
    "rxjs": "^6.4.0",
    "rxjs-compat": "^6.3.0",
    "tns-core-modules": "^6.1.1",
    "zone.js": "^0.9.1"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "0.800.3",
    "@angular/cli": "^7.1.4",
    "@angular/compiler-cli": "~8.2.0",
    "@nativescript/schematics": "~0.5.0",
    "@types/jasmine": "2.8.9",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "~8.9.4",
    "codelyzer": "~4.2.1",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~1.7.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.0",
    "karma-jasmine": "~1.1.1",
    "karma-jasmine-html-reporter": "1.3.1",
    "nativescript-dev-webpack": "^1.3.0",
    "node-sass": "4.12.0",
    "protractor": "~5.3.0",
    "ts-node": "~5.0.1",
    "tslint": "~5.9.1",
    "typescript": "~3.5.3"
  }
}

@gyansoft786 the error log is not descriptive enough - this kind of log usually indicates that there is an issue that prevented the proper TypeScript translation or that there was a major syntax error that prevented a proper build this resulting in a total failure of the app. Double-check the last changes applied to the app and try to make a clean rebuild (with deleted platforms folder)

same on my app, a lot of this on google play crash report

Having the same problem as @Nurgunkalol - not happening for all devices, and I can only see this in play reports

Also having the same problem as @Nurgunkalol - looks like it is happening on newer devices.

Also having the same problem as @Nurgunkalol. I only see this crashes in playstore, but i cannot reproduce it

Same issue, all on android X
TypeError:
  at com.tns.Runtime.callJSMethodNative (Native Method)
  at com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1286)
  at com.tns.Runtime.callJSMethodImpl (Runtime.java:1173)
  at com.tns.Runtime.callJSMethod (Runtime.java:1160)
  at com.tns.Runtime.callJSMethod (Runtime.java:1138)
  at com.tns.Runtime.callJSMethod (Runtime.java:1134)
  at com.tns.gen.androidx.fragment.app.DialogFragment_vendor_1_6154_DialogFragmentImpl.onStart (DialogFragment_vendor_1_6154_DialogFragmentImpl.java:30)

Same issue and only occurs when the app is in the Play Store, I can't reproduce it locally.

I am getting same error in Galaxy Note 4 device

Getting similar issue on Galaxy A10e. Seems to be happening a lot on newer devices.

@FlawaCLV @GMatshwane @sureshkumar85ios Were you all able to reproduce this locally?

Any Updates on this? we getting the same crash report from our firebase analytics. Cant reproduce locally.
com.tns.Runtime.callJSMethodNative (Runtime.java)
com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1302)
com.tns.Runtime.callJSMethodImpl (Runtime.java:1188)
com.tns.Runtime.callJSMethod (Runtime.java:1175)
com.tns.Runtime.callJSMethod (Runtime.java:1153)
com.tns.Runtime.callJSMethod (Runtime.java:1149)
com.tns.NativeScriptActivity.onCreate (NativeScriptActivity.java:40)

I'm getting this error as well.

i am currently having this error when a push notification is received while app is closed. no solution found yet


Fix warnings on modern g++

These are just cosmetic changes to avoid showing warning when compiling with -Wall

add STATUS to the CMake output to avoid it breaking catkin flow
cast all implicit ints to size_t when compared to one in tests

Thanks :+1:


Uts for orgs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.mahdibenromdhane seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@ClaudeROSSI Could you check the latest Mahdi's changes?


POC for scatter-gather parallel webservice requests

@astubbs Could you share the status of this? When does eBay Korea run a test?

Closing - Stale.