Add credential fetcher in istio agent

Please provide a description for what this PR is for.
Add credential fetcher in istio agent. Credential fetcher fetches platform specific workload credential, which is used by istio agent to provisioning certificates for workloads.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
fa44d8dd9c6352bbb3607f8c044e786161dec6b9
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ  Did you actually review this PR before approving ?

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test release-notes_istio

lint_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test release-notes_istio

lint_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test lint_istio

gencheck_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test lint_istio

gencheck_istio
35654f3a807f340200a807714f5db605f4612c1c
link
/test gencheck_istio

release-notes_istio
b7d9bff18e1ddbad293e64215ec08296cc6514b5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test lint_istio

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test lint_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test lint_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f0adc7f5db1732e9edaeb9e244eb749d83bc57e2
link
/test gencheck_istio

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test lint_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

lint_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test lint_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-operator-controller-tests_istio

gencheck_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-operator-controller-tests_istio

gencheck_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test gencheck_istio

lint_istio
35f0d7eeeaad2e6af7f0aa0cc386f7cc636c7288
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-operator-controller-tests_istio

lint_istio
35f0d7eeeaad2e6af7f0aa0cc386f7cc636c7288
link
/test lint_istio

gencheck_istio
35f0d7eeeaad2e6af7f0aa0cc386f7cc636c7288
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm @howardjohn @JimmyCYJ I have addressed all your comments.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test unit-tests_istio

release-test_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-galley-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-mixer-k8s-tests_istio

integ-operator-controller-tests_istio
7f0ba76c714ee5553e42a39fe96080dd21b909b5
link
/test integ-operator-controller-tests_istio

gencheck_istio
35f0d7eeeaad2e6af7f0aa0cc386f7cc636c7288
link
/test gencheck_istio

lint_istio
0bc10b871c7d89bd5f8ab732bad59c37f402f2f7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
0bc10b871c7d89bd5f8ab732bad59c37f402f2f7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
0bc10b871c7d89bd5f8ab732bad59c37f402f2f7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Did you actually review this PR before approving ?

Yes, Oliver and I have reviewed this one already.

@costinm @howardjohn Can you approve the change? All comments are addressed and all tests are passed. I am trying to get it in to 1.7.

In terms of API and implementation: gRPC already has an interface - PerPRCCrednetials - with multiple implementations, including one for GCP. Any reason to invent our own - and duplicate the implementation ?

https://github.com/grpc/grpc-go/blob/a5a36bd3f0bbf60d6257ff57eb5749b4e58f5e94/credentials/credentials.go#L38

As @howardjohn  mentioned - Envoy has a similar mechanism to configure the google gRPC library with different plugins and options implementing gRPC interfaces.
Agent can take an option ( env variable or ProxyConfig ) to select one of the already-implemented PerRPCCredentials to use when making the call to Citadel/other CAs. And if we have additional implementations - they can also use the same interface ( with the extra benefit that the 'native gRPC' support for Istio can also use the same code )
So unless there are very strong reasons to define our own interface - and lose the existing implementations gRPC provides already, including metadata server/google with various options - I think we need to see the reasons and understand the benefits of reimplementing all that.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0bc10b871c7d89bd5f8ab732bad59c37f402f2f7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d0ce70b803dc3e63483b5d7ac849a747f26960f4
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f5f3161d45709d313a3731cfdd4dba9f699cb298
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @costinm I addressed the outstanding comments you had. Please take another look. Thanks.

We can look into the available gRPC library support and see how to align with it as a long term goal. This likely affects the existing SDS and STS flows, which is a fundamental change that affects all existing security flow.

Why can we not address the "long term" change now? Nothing in this PR seems so urgent that we need to rely on short term fixes

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test lint_istio

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
9d9f326af316890cfbe1f1144e1f9f52a10d5377
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

lint_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test lint_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test unit-tests_istio

integ-security-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-security-k8s-tests_istio

release-test_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test release-test_istio

integ-galley-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-galley-k8s-tests_istio

gencheck_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-multicluster-k8s-tests_istio

integ-operator-controller-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
34d4f193dd959f74248dcb48c546f3aa993c609c
link
/test integ-ipv6-k8s-tests_istio

lint_istio
3003e3b8bbd8a997430972e7ee1252a38f9f0e6e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn Thanks for the quick review. I have addressed all your comments. Let me know if you have more comments.

@liminw I removed my hold. Thanks for making the changes! Since Costin had strong objections originally I do not want to approve without letting him have a chance to review again

@liminw I removed my hold. Thanks for making the changes! Since Costin had strong objections originally I do not want to approve without letting him have a chance to review again

Thanks John! @costinm Can you review again?

My primary objection remains on interface - can you explain in a document if anything is wrong with the gRPC interface, which we can directly use together with their GCP integration - without all this extra code ?

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a94f08a33f25dc6ed88ea5a4d62b6a7c2da9f178
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

lint_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test lint_istio

release-notes_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-notes_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-operator-controller-tests_istio

gencheck_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-security-k8s-tests_istio

lint_istio
a528d063db5f7e41e233572f817f8eb55b74055d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-security-k8s-tests_istio

lint_istio
6978e0d3aec5f1342afaaa52ad120f9105c15e1e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
cc5f23bd8cb0572915235cecbacb44a4c835b668
link
/test integ-security-k8s-tests_istio

lint_istio
6978e0d3aec5f1342afaaa52ad120f9105c15e1e
link
/test lint_istio

unit-tests_istio
6978e0d3aec5f1342afaaa52ad120f9105c15e1e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test integ-pilot-k8s-tests_istio

lint_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5e62938c8ba7bd127be433fbe24aead4c5317b50
link
/test integ-pilot-k8s-tests_istio

lint_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test lint_istio

gencheck_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test lint_istio

gencheck_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test gencheck_istio

unit-tests_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test lint_istio

unit-tests_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test unit-tests_istio

gencheck_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
690e72fd2923ed4f4a22f8e813a6b05dc809b407
link
/test unit-tests_istio

gencheck_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test gencheck_istio

lint_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test gencheck_istio

lint_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test lint_istio

integ-pilot-k8s-tests_istio
dbeacf2ee29f6fa263b8f0f5652119f7e3d3c52d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
44aeeb697676f84af0018cb78120a5f5dd3e6a84
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@liminw: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
44aeeb697676f84af0018cb78120a5f5dd3e6a84
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #25614 failed to apply on top of branch "release-1.7":

In response to a cherrypick label: new issue created for failed cherrypick: #26034


Catch HTTPS Connect

So I can catch the HTTPS Connect, and I started looking at doing this with abourget's fork, however I cant work out how to kill the request and send a response if its over 443.
I think I need to make a custom ConnectAction
So:
		proxy.OnRequest().HandleConnectFunc(func(host string, ctx *goproxy.ProxyCtx) (*goproxy.ConnectAction, string) {
			log.Println("connecting: ", ctx.Req.URL.Host)
		return goproxy.OkConnect, host
	})

No I want to stop the connection to the server and just respond to the client with some HTML, i.e a &http.Response but that doesnt seem to be built into the HandleConnectFunc as an option.
Is this possible, or am I missing a point?
All I want to do is catch the connect, if the Host contains HTTPS/443, then stop the connect and respond with an HTTP response.
EDIT: Hmmm, I can edit the request but I think once HTTPS happens, then thats that????
If I change the request to be over 80, rather than 443, it still seems to successfully manage the TLS handshake. I expected it to get passed to my proxy.OnResponse function that handles HTTP responses...
		proxy.OnRequest().HandleConnectFunc(func(host string, ctx *goproxy.ProxyCtx) (*goproxy.ConnectAction, string) {
			log.Println("connecting: ", ctx.Req.URL.Host)
			if strings.Contains(ctx.Req.URL.Host, ":443") {
				log.Println("yup 443")
				ctx.Req.URL.Host = strings.Replace(ctx.Req.URL.Host, "443", "80", -1)
				log.Println("HOST: ", ctx.Req.URL)
			}

		return goproxy.OkConnect, host
	})

EDIT AGAIN:
Is there such thing as a CONNECT response from the server? I am forcing all properties of ctx that have :443 over to :80 which results in:

Thats almost good ;)
I can stop the HTTPS connection occuring but I cant force a new HTML page to the client. Is that even possible?

I feel sooo close:
In the browser I go to gmail.com
My code looks like:
	proxy.OnRequest().HandleConnectFunc(func(host string, ctx *goproxy.ProxyCtx) (*goproxy.ConnectAction, string) {
			log.Println("connecting: ", ctx.Req.URL.Host)
			if strings.Contains(ctx.Req.URL.Host, ":443") {
				ctx.Req.URL.Host = "www.nytimes.com"
				host = ctx.Req.URL.Host
				ctx.Req.RequestURI = host
				ctx.Req.URL.Scheme = "http"
			}
		return goproxy.OkConnect, host
	})

In the browser it hangs indefinately as I have changed all of the references off 443 and all references to the host to www.nytimes.com.
In the brower I see it hanging indefinately, but it doe NOT put the HTTPS in front of the url I went to, which makes me feel that the HSTS has not yet successfully kicked in:

This feels like I'm almost there.
All I need to understand (I think) is what the goproxy.OkConnect, is actually doing. I can see in the code it is returning some TLS configuration.
What I would like to do is just return an HTTP response - as in the browser no HTTPS handshake has begun I should be able to return that. But i cant see from the documentation how you would do that.

No, you cannot do that.
Your browser is expecting the https protocol.  You can't just talk http.
Instead, because of security rules of certificates and how TLS works, you have to act like the destination that they're trying to go to.  You have to do that from a CA that is trusted by the browser.  Then and only then will the browser accept your TLS handshake and let you then deliver your HTML through https.
See [whitelistproxy] (https://github.com/mzimmerman/whitelistproxy) for an example of how to do this using goproxy.

@mzimmerman 's answer is correct. You can do that with my fork too github.com/abourget/goproxy .. until it's merged back here. @mzimmerman I'm curious, is whitelistproxy a full alternative to goproxy? does it use it internaly ? and if so, what does it add ?

Right, it uses goproxy internally.  It manages the whitelist and adds a
user interface for adding new ones.
https://github.com/mzimmerman/whitelistproxy/blob/master/README.md
On Tue, May 26, 2015, 9:05 PM Alexandre Bourget<EMAIL_ADDRESS>wrote:

@mzimmerman https://github.com/mzimmerman 's answer is correct. You can
do that with my fork too github.com/abourget/goproxy .. until it's merged
back here. @mzimmerman https://github.com/mzimmerman I'm curious, is
whitelistproxy a full alternative to goproxy? does it use it internaly ?
and if so, what does it add ?
—
Reply to this email directly or view it on GitHub
https://github.com/elazarl/goproxy/issues/107#issuecomment-105707394.


Updating generator references

LGTM ... haven't tried any devops build with global.json (path issue etc) yet, but I'm sure this will work fine.

Both builds run as expected with the changes


Unidentified Items

Hello there.
I worked alot in the past to try getting unidetified items working. Cause i want every item to be unidentified.
But its a pain because you cannot really define the Tier a Unidetified item will have. Only the other way, but this can cause drop in areas where i dont want such high tier drop.
So please add the option to define the Tier wich a unidentified item will have. Or at least a option for that in your API. Since PhatLoot does an amazing jop with support your plugin. He allready tried it and its possible to select a tier in his GUI for the unid item. But well since every tier can have a chance to be indentified its not working the way most people needs it i think ;)
Hope you can understand what i mean. If not just tell me :)
EDIT: This is maby more clearer.
So basiclly a unidentified Item should Listen to the tier befor you identifie it. So you can define what exactly tier a item will have if it drops unid.
MFG

You can test this here. I made it so that when identifiying an item, it checks the last line of the lore of the item for a tier name. If it finds one, it uses that. If it doesn't, it picks randomly.

So that means I need to setup all tiers as unidentified item?
So I need to define it in the unidentifiedItem.yml?
I thought about a easyer way.... Like an section  in the tier.yml what said something like "AlwaysUnidOnDrop:true/false"
This would make life much easier 😉
Well I will try your build and see how yours work at.  I'm in work at.

Im now at home and i thought a little bit more about what you ment. Well so you basiclly say that i can write one line into my UnidentifiedItem.yml lore to define the Tier a unidItem will have. But isnt that only give me a option to select 1 tier only?
If so than thats not what i mean.

https://github.com/Codisimus/PhatLoots/issues/27#issuecomment-198210221

Part of it is that Unidentified Items are only checked based on the name of the item itself. You could therefore just create items that have the same name as the Unidentified Item (color and all) that have the tier in the last line of the lore.
It's a bit more complicated, but the capability is there.

Well awesome job 😆
And the development from PhatLoots will provide an extremely easy way for that. Thanks for keeping up this plug in.

I just would like to ask a last question here.
Since you sai i can make a unid Item as a Tier and let them drop. But how can i change the ItemName cause thats got alöways defined in the standard config by item-display-name-format: '&l%basematerial%' in my case.
I tryed this setup it it still shows me the Material as name.
http://pastebin.com/LuK4SBua
MFG


Activating extension 'eamodio.gitlens' failed

Just installed GitLens but extension doesn't seem to be working. The only logging I could find is attached below.
Also tried re-installing the extension removing the extensions folder under ~/.vscode-insiders/extensions.

GitLens Version: 9.5.0
VSCode Version: 1.32.0-insider (1.32.0-insider)
OS Version: MacOS Mojave 10.14.3

Add to install XCode Additional Tools and re-install extension after OS update.
Working now.


Upgrade to Cats RC-2

This is WIP. We still need:

[ ] iteratee
[ ] circe

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   80.32%   80.32%
=======================================
  Files          52       52
  Lines         788      788
  Branches       31       31
=======================================
  Hits          633      633
  Misses        155      155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af94e61...0eac5c4. Read the comment docs.

One more down, others coming shortly.

Okay, we should be all set:

https://github.com/travisbrown/iteratee-twitter/releases/tag/v0.17.0
https://github.com/circe/circe-iteratee/releases/tag/v0.9.0-M4
https://github.com/circe/circe-jackson/releases/tag/v0.9.0-M3

Thanks a lot @travisbrown! The release is coming shortly.


Crash on dedicated server

Describe the Bug
Near instant crash when trying to start a dedicated server with the latest build (and previous ones to my knowledge)
Mods: create v0.4b, fabric-API 0.45.0,
fabric loader 0.12.12
Reproduction Steps

Create dedicated server with those mods
Start
Crash
...

Expected Result
Working server
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/ndxip6Bi
Operating System
Windows 10
Mod Version
0.4.0a
Minecraft Version
1.18.1
Other Mods
None
Additional Context
No response

This issue occurs because Fabric doesn't load Flywheel due to it's environment being Client only.

Flywheel appears to be made to be included into the client. As that's what Create Forge seems to do. Changing the fabric.mod.json environment seems to work. There are also some references to FluidVariantRendering in AllFluids

Flywheel appears to be made to be included into the client. As that's what Create Forge seems to do. Changing the fabric.mod.json environment seems to work. There are also some references to FluidVariantRendering in AllFluids

this should be fixed, reopen if it is not.


Give more respect to the whitelist param

Bug
The issue https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/issues/215 pointed out that regardless of whitelist value, we always expect the suffix -apb in order for the apb to be seen by the ansible-service-broker. The relevant code is here.
I think it's worth to consider giving more power to the whitelist param.  I think it will be less error prone if the user had full control even though it's likely they will use the suffix -apb.
We can take on this issue as part of the working going into https://github.com/openshift/ansible-service-broker/issues/684

I'm still seeing images that don't have the *-apb suffix being processed when I have the whitelist set to only filter *-apb images.

https://github.com/openshift/ansible-service-broker/pull/781


Firefox - Browser does not support copy to clipboard

Error is presented when clicking the Copy button on the Namespace logs component of the dashboard page.

resolved


Push fails because of random route length

Issue
In https://github.com/cloudfoundry/cloud_controller_ng/issues/581 a limited length of the app-name was introduced.
Our app-name has 43 characters. The app uses the random-route feature.
In this way the route can become longer than the limit of 63 characters.
This results in
Server error, status code: 400, error code: 210001, message: The route is invalid: host must be no more than 63 characters
Steps to Reproduce
Push an app with >40 character app-name and use random-route.
Sometimes this will result in the described behavior.
Expected result
CF push must be reproducible.
Current result
They're not.
Possible Fix
a) Use shorter suffix names in case of longer app-names.
b) Define a max-length for app-names, so they don't conflict with random-routes. (Didn't see documentation which defines the max-length of the suffix).

@elgohr The cli is the bit that generates random routes for an app. Please raise this issue on the cli repo https://github.com/cloudfoundry/cli.

New issue at https://github.com/cloudfoundry/cli/issues/1331


Update Login test with better test description

Coverage remained the same at 80.0% when pulling ad08c52a5896bc7264b706758de67b4e171917fe on jgreben-patch-login-test into 3a1ec3f0126f42c113ad7bb1c8a2909bff5b7fa6 on master.

Thank you!


No colors in data not working

I have no colors in data enabled, but there's still colors in data. I also tried restarting the widget but it didn't help. Anyone else also has this issue?

macOS version = 12.6, macbook pro 13 m1

I'll look into it soon, this must be a bug introduced when I merged the several Übesicht widgets composing simple-bar into one.

@Jean-Tinland Pr fising the bug:

https://github.com/Jean-Tinland/simple-bar/pull/337


mixin alternatives

Hi! Thanks for this addon, it's been a great help to my projects.
I was wondering if there was any plan or idea to migrate away from the mixin implementation of the FastBoot adapter, so it could be used with native classes more easily.
https://embermap.github.io/ember-data-storefront/docs/guides/fastboot

Yup that would be great! This isn't a high priority for me now since the apps I work on don't need it, but if someone is motivated to make this happen I'll absolutely merge the PR.

Yeah, this is also very desirable for anyone working in a TypeScript-based ember app, where Ember.Mixin is the devil :D

Looking at the explanation of @chriskrycho over at:
https://discuss.emberjs.com/t/best-way-to-replace-mixins/17395/2
This will be a difficult choice, if we want to keep the same functionality as it is working now.
Our best option is class decorators, or rewrite the logic in a more service-oriented way, breaking all the implementations.

Thanks PJ!
We recently released 0.18 of storefront, which only supports Ember 3.12+. Does that help with the class decorators?
Also, I'm okay with releasing a breaking change, especially if it gets us away from mixins. What would it look like if it were service oriented?

Basically, you would inject a storefront service, instead of injecting the store with storefront methods added to it via mixins. Your storefront service would then inject and delegate to the Ember Data service in much the same way that the existing methods do. It would make for a very straightforward swap in most cases, actually.
That is exactly what I would recommend here, after thinking about it all morning. Should be a clean and easy transition and it actually makes for a pretty simple implementation as well!

Yes, I prefer a storefront service as well. it is a lot cleaner (plus I do not like class decorators for reasons described in the forum post).
If we look at the different Mixins, there are:
LoadableStore
Easy, when introducing a new Service "storefront" as described by @chriskrycho above
LoadableModel
Would these methods be best moved to that service as well?
Something like:
this.storefront.modelSideload(model: Model, includesString: string, options: object) : Promise<void> ?
FastbootAdapter
I have no experience with anything regarding Fastboot, could someone elaborate?

Perhaps it is an idea to undeprecate the functions in the storefront service for starters?
And add functionality for sideloading?


will you plan release the pretrained model of NTIRE 2022 challenge

hope the pretrained model +1

Hi，the pretrained model can be found in https://github.com/IIGROUP/MANIQA/releases

thk!!!


[FEATURE] Add Friends Model

The Way to Get all the friends of someone by their UUID and Return it with their names instead along with flags, is as follows
SELECT friends.Friend, friends.Flags, concat(useraccounts.FirstName, ' ', useraccounts.LastName) AS 'name' from friends, useraccounts WHERE friends.Friend = useraccounts.principalID AND friends.PrincipalID = "<UUID of USER HERE";

Friends Model is Added


A J: Watch wbwhite.com

A J requests the watch of the watch_keyword wbwhite.com. See the Metasmoke search here and the Stack Exchange search here.

!!/approve


Quick Commands

This introduces Quick Commands. Ironically, we're starting with the Wait command.
The wait command should fix #32, and I've implemented fixes for #33.


Added Newman–Shanks–Williams prime using dynamic programming.

Description of Change

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

review the contribution guidelines. No reviews will be done until the code is updated per the repo standards


merge main to live Tues morning 10:30

Docs Build status updates of commit 22db8cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


How to show series name like this?

That's an AnnotationSeries. Probably generated with TestLastValueAnnotationSeries().


bug on firefox - words get multiple vectors

Seems to works fine for me on Chrome, but on Firefox, it looks like this (Note George twice):

I noticed in the docs, it says there are known issues with FF. Feel free to close this if no plans to support FF.

Yes... that is the very issue I observed in FF. Do you have any idea what is causing this? Might be an easy fix.

Perhaps in this line unique() does not do what the name implies?
https://github.com/ronxin/wevi/blob/master/js/toyw2v.js#L104
See http://stackoverflow.com/a/8137873 which suggests sorting first and then calling unique().

@denik Thanks for catching this!


fix: Fix deferred Session Replay payloads

Force agent to send preload replay payloads if present

Overview

Related Issue(s)

Testing

firefox is flaky on some STN tests in GHA.  running locally cannot reproduce.


Resampling without losing events

Resampling the stim channel is a tricky business. If you are not
careful, you might lose events.
Consider the following stim data, all zeros with two event onsets:
  y = [0, 0, 1, 0, 0, 0, 0, 1, 0, 0]

If we naively downsample by a factor of 2, this becomes:
 y = [0, 1, 0, 0, 0]

whoops, event lost. In the current implementation, no warning is given whatsoever.
This commit first extracts the onsets on which the stim signal changes:
 onsets = [0, 2, 3, 6, 7]

resample those:
onsets = [0, 1, 1, 3, 3]

nudge overlapping onsets (by default by maximally 1 sample, but this can be changed):
onsets = [0, 1, 2, 3, 4]

and reconstruct the resampled stim data:
y = [0, 1, 0, 1, 0]

no events lost!
If events get delayed too much or fall out of bounds, it fails loud.

Looking at the mne_browse_raw C code may help in solving this problem. -  Matti

On Jul 14, 2015, at 9:20 PM, Marijn van Vliet<EMAIL_ADDRESS>wrote:
Resampling the stim channel is a tricky business. If you are not
careful, you might lose events.
Consider the following stim data, all zeros with two event onsets:
y = [0, 0, 1, 0, 0, 0, 0, 1, 0, 0]
If we naively downsample by a factor of 2, this becomes:
y = [0, 1, 0, 0, 0]
whoops, event lost.
This commit first extracts the onsets on which the stim signal changes:
onsets = [0, 2, 3, 6, 7]
resample those:
onsets = [0, 1, 1, 3, 3]
nudge overlapping onsets (by default by maximally 1 sample, but this can be changed):
onsets = [0, 1, 2, 3, 4]
and reconstruct the resampled stim data:
y = [0, 1, 0, 1, 0]
no events lost!
If events get delayed too much or fall out of bounds, it fails hard.
You can view, comment on, or merge this pull request online at:
https://github.com/mne-tools/mne-python/pull/2298 https://github.com/mne-tools/mne-python/pull/2298
Commit Summary
Resampling without losing events
File Changes
M mne/filter.py https://github.com/mne-tools/mne-python/pull/2298/files#diff-0 (65)
M mne/io/base.py https://github.com/mne-tools/mne-python/pull/2298/files#diff-1 (36)
M mne/tests/test_filter.py https://github.com/mne-tools/mne-python/pull/2298/files#diff-2 (52)
Patch Links:
https://github.com/mne-tools/mne-python/pull/2298.patch https://github.com/mne-tools/mne-python/pull/2298.patch
https://github.com/mne-tools/mne-python/pull/2298.diff https://github.com/mne-tools/mne-python/pull/2298.diff
—
Reply to this email directly or view it on GitHub https://github.com/mne-tools/mne-python/pull/2298.

The information in this e-mail is intended only for the person to whom it is
addressed. If you believe this e-mail was sent to you in error and the e-mail
contains patient information, please contact the Partners Compliance HelpLine at
http://www.partners.org/complianceline . If the e-mail was sent to you in error
but does not contain patient information, please contact the sender and properly
dispose of the e-mail.

This PR solves the problem completely. Now researchers can finally sleep soundly at night knowing no events are ever dropped again if it can be helped at all.

Well, it may also introduce a problem, I can think of at least one case where could be problematic:
On many Neuromag systems the trigger is not always correct on the first sample of a new trigger. This is why we have the shortest_event field on find_events (which defaults to 2). #1102
I know that @mshamalainen included some neat tricks in the C-code, which we may want to look at for taking care of these edge cases where this code might exacerbate the issue.

@wmvanvliet I've given you access to the C code so you can have a look
at the hacks of matti :)

thanks @mshamalainen and @agramfort, I will take a look at the C code

@dgwakeman so in (very) rare cases this Neuromag bug can also cause event codes to change due to naive resampling. For example:
y = [0, 0, 0, 1, 2, 2, 0, 0, 0, 0, 0, 0]

downsample with a factor of 3:
y = [0, 1, 0, 0]

The implementation in this PR would regard the 1, 2, 2 bit as two events (1 and 2) and make sure to retain them both:
y = [0, 1, 2, 0]

Arguably better... although this would be a very rare situation.
Users of Neuromag should be very careful in any case.
Alternatively, how about a resample_events function? The user could first find events on the non-resampled data, using whatever hacks and tricks necessary. Then resample the data and event matrices separately. That would make the code a little bit easier as well.

Is this the only tricky thing you found in the C-code. I don't have access myself: plus I'm a bit dense, so I don't know if I would be able to read it that well. ;)
I didn't have any strong design ideas (IMO: one sample triggers are the real problem). I just didn't want to see the code around this area getting too complex and developing strange interactions with the defaults (e.g. your code is more likely to output single sample triggers; which would be ignored by the defaults in find_events), but I'm not blocking. I just wanted to voice some concerns. A resample events option might be good to have. The usage pattern could look like:
events = raw.find_events;
raw.resample(order=2, events, synthesized_stim=True)
then the events could get resampled, and you could add a new supplemental STIM channel with that information.
I just wanted this discussion as part of the design process.

It's good to have this discussion.

LGTM but it should be compared to C code strategy

This is the approach taken in mne_browse_raw:
Say we wish to decimate the stim channel by a factor of 10.

Split the stim channel data in windows of length 10.
For each window, take the first non-zero value.

This approach is simple and covers some of the more obvious problems. However, it will still silently drop events if there are two events occurring in the same window. Also, two events can be merged as one.
`y = [0, 0, 0, 1, 0, 1, 0, 0]`

`y = [0, 0, 1, 1, 0]`

so now two events become one... whoops. (The code in this PR would throw an error on this example, which is preferable to silently messing up the events).

How about this for an API?
events = raw.find_events()
raw.resample(order=2, events)  # raw and events are modified in-place

I don't really see a point in reconstructing the stim channel if events have already been extracted.

cc @agramfort
Unfortunately, there is no straightforward way to reconstruct a stim channel based on an event matrix:

We don't know what stimulus channel the events were created from. Could be one. Could be many.
We support extracting events based on onsets/offsets/step and other variations.

Theoretically, this could be solved, but it would make the code much more complicated than it is now.

First, that was just an added feature I thought of to enhance the flexibility of the API I mentioned. The main advantage of the API is that it demands feeding events to resample, so the user can check that all of the events are caught, plus, we can issue errors then if we know they will lose events with their settings e.g. [0 1 0 2 0 1 0 2 01 ] and a decimation factor of 10 (as you mentioned above). You must lose data here, and we can issue an error.
Point 2 makes sense, in that the reconstructed stimulus channel won't be a "perfect" downsample of the stim channel, but it would contain what people were interested in in the beginning. Again, I don't think this feature is necessary.
I do see a huge advantage to making a requirement to resample be the events structure, because then at least the user has to think about what sort of events they want to get out of their resampled data instead of just assuming it worked and then getting annoyed when things break. @agramfort thoughts

I proposed a fix to @wmvanvliet
Let's see if you agree on the outcome. Hopefully soon

I'd really appreciate a fix for this, it's a hidden failure scenario I've experienced a few times. +1 for this.

Ok, this PR now aligns how stim channels are resampled with the way mne_browse_raw does it.
In addition, I've implemented a new API.
Now you can do this:
events = mne.find_events(raw)
raw.resample(100, events)
epochs = mne.Epochs(raw, events, ...)

By giving the event matrix to the resample method, the data and event onsets can be jointly resampled, bypassing the problematic resampling of the stim channel completely. In this instance the raw data and events matrix are modified in-place. I've also added a copy parameter to the resample method, so you could also do this:
events = mne.find_events(raw)
raw_res, events_res = raw.resample(100, events, copy=True)
epochs = mne.Epochs(raw_res, events_res, ...)

Giving the events to the resample function is of course optional. Backwards compatibility is preserved.
I've added some checks that warns the user if the resampling of the stim channels lead to problems.

That is a clever solution!

I'm happy with the API now. This is ready for review and hopefully merge.

Glad to see the events API added!
I'm +1/-1 on the following idea, but I'll let you think about it:
renaming/removing the stim channel (at least when events is included in the call). This way people don't forget they did it. (+1 for safety, -1 for they should know what they did to their data).
Not for this PR: Also, what do people think about the idea of adding events to info, to decrease manual book keeping?

actually, info has a field for events. I came across it while documenting the beast. It's not used though.

renaming/removing the stim channel

-1 for me. It makes things more complex and less transparent. I think the multitude of warnings in the manual, example and docstring should be enough.

-1 on adding events to info, I think it would be more confusing than helpful. If it's just going to reflect what is in the stim channel, now we have violated DRY by making us keep track in multiple places all the time. If it's supposed to be something more, I don't know if it's worth it. We can't really know what events people plan on using. In our pipelines at UW, we use multiple event lists, so having one that is part of info wouldn't really make sense... I imagine other cases are similar.

sounds good!

IMO it would be EXTREMELY useful to have a field containing per-epoch events information that is updated together with the epochs object (such as response time on the corresponding trial). So e.g. when epochs are dropped, the corresponding events are also dropped. This is done in EEGLAB, and would really simplify a bunch of stuff that's trivial in EEGLAB, such as basically all the single-trial stuff I did in my Brain & Language and Cortex papers.
But that's different from keeping the raw events array itself.

@jona-sassenhagen we could add numerical id numbers to the epochs. By default this would just be range(len(epochs)), but as epochs are dropped (bad epoch detection and whatnot) the corresponding ids are removed from the list. This allows you, for example, to easily keep a pandas dataframe aligned with the epochs object.

I'd love that, but that's really not for this PR. Finish it up first, it'd be super helpful!

Don't we basically already have that with epochs.selection?

@Eric89GXL you are right! We have it! good news @jona-sassenhagen :)

Oh, that reminds me why just having integer ids is not so cool, and some arbitrary pointer would be nicer: if you e.g. merge epoch files, you have to manually take care of things again, which can get very messy (at least the way I did it). It would be nicer if that was done automatically.

Ok, I've finished processing your comments. Are we ready for merge?

besides LGTM !

Not for this PR: Also, what do people think about the idea of adding
events to info, to decrease manual book keeping?

events is not a measurement info thing.

Oh, that reminds me why just having integer ids is not so cool, and some
arbitrary pointer would be nicer: if you e.g. merge epoch files, you have
to manually take care of things again, which can get very messy (at least
the way I did it). It would be nicer if that was done automatically.

I think epochs have all the info you need to do what you're asking.
Paste a "messy" code snippet so we can evaluate how lazy you are :)

besides +1 for merge
thanks @wmvanvliet !

Travis is finally happy!
@agramfort Can you do a final check before I merge this? The version you last checked contained a flaw where resampling wouldn't work when no status channel was present. This is solved now with an except: pass statement in one of the very rare cases I believe it is appropriate.

LGTM
please rebase, update what's new and merge.
thanks @wmvanvliet !

:beer: @wmvanvliet  !

nice