Extend Hostinfo with identity and port map

What changed?
Adding additional fields to membership.Hostinfo struct.

Why?
Currently, IP:port tuple is kept in the addr field, which is used for both: identity and addressing needs.
Added fields will be used to provide more information about peer details in a ring.
This is needed to support multi-transport RPC topologies or RPC transport to transport migrations.

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build dc61b7f0-217f-469d-9ee5-fff8ce1d9a13

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
86 unchanged lines in 14 files lost coverage.
Overall coverage decreased (-0.04%) to 56.939%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/membership/hashring.go
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

common/membership/hashring.go
1
76.83%

common/persistence/executionManager.go
2
76.94%

common/persistence/statsComputer.go
2
96.43%

common/task/fifoTaskScheduler.go
2
87.63%

common/task/weightedRoundRobinTaskScheduler.go
2
89.64%

service/history/execution/mutable_state_builder.go
2
69.66%

service/history/queue/transfer_queue_processor.go
2
56.86%

common/persistence/dataManagerInterfaces.go
3
58.49%

service/history/task/fetcher.go
3
86.67%

common/persistence/sql/sqlExecutionStore.go
5
62.91%

Totals

Change from base Build 37cef24f-8eb2-4aa0-b491-dccd706aa5cd:
-0.04%

Covered Lines:
82918

Relevant Lines:
145625

💛  - Coveralls


Add support for @improbable-eng/grpc-web

Is your feature request related to a problem? Please describe.
I would like to use @improbable-eng/grpc-web as a gRPC client to be able to use bidirectional streams
Describe the solution you'd like
Something similar to this but for @improbable-eng/grpc-web
import * as grpc from "@grpc/grpc-js";

const client = createGrpcClient(ElizaService, {
   address: "localhost",
   channelCredentials: grpc.ChannelCredentials.createInsecure()
});

client.say({ sentence: "Hello" }, (err: grpc.ServiceError | null, value?: SayResponse) => {
  //
});

@euskadi31, according to their README, @improbable-eng/grpc-web is a:

Library for making gRPC-Web requests from a browser

@bufbuild/connect-web implements the Connect protocol, but it also implements the gRPC-web protocol. To make a request with gRPC-web:
import { createGrpcWebTransport } from "@bufbuild/connect-web";

const transport = createGrpcWebTransport({
  baseUrl: "http://localhost",
});
const client = createPromiseClient(ElizaService, transport);
const res = await client.say({sentence: "Hello"});

You can find the documentation here.
If you are asking for callback-based clients, you can simply use createCallbackClient() instead of createPromiseClient(). You also have to option to create your own client. This is documented here.
Closing this, but please feel free to comment in case I missed something.


feat: allow build to be triggered from run when fn.Image is missing

Changes

:broom: A prompt will ask users if they want to build the current function when an image has not been found
:broom: Build error messages are shown to the user

/kind enhancement

Fixes #577

currently working on adding unit tests to this

An e2e test seems to be failing due to a "Temporary failure in name resolution". Is it possible to rerun the test?

@shinigambit it seems that @matejvasek and @lkingland each had PRs that conflicted with the other resulting in an e2e test that was failing. Let's let them work this out and hopefully a rebase should resolve the problem.


Adds support for SMEMBERS.WATCH command

This PR implements the feature described in the issue #1132. The new SMEMBERS.WATCH command allows subscribed clients to receive push responses whenever the data in a respective set is modified.

Changed Introduced

Modified the evalSADD function
Added command constants
Updated command watch manager
Defined metadata for SMEMBERS.WATCH
Added integration tests

Why did I modified the evalSADD function
I have had to modify this function because the subscribers were receiving double notifications for the first SADD command. The old implementation caused double notifications because it performed a store.PUT for the initial set creation and subsequent additions. The new implementation defers the store.PUT operation until all additions are complete, ensuring subscribers are notified only once.
Why Sorting the Results in Integration Tests Is Necessary
To validate the correctness of the reactive system, we care about the contents and not the order of the set. Sorting both the expected and received results allows us to

Ignore the effects of the asynchronous delivery.
Focus solely on whether the correct data was transmitted.

Screenshot

Hi @superiorsd10 , Please rebase the PR with latest master, Thanks.

@apoorvyadav1111 I've rebased it with the latest master. Thank you!


styled-component issue

import * as React from "react";
import { Flex as FlexBase } from "rebass";
import styled from "styled-components";
import {Details} from './Icons'

export const ButtonWithIconsContainer = styled(FlexBase)`
  cursor: pointer;
  border-top: 1px solid white;
  border-bottom: 1px solid white;

  &:hover {
    border-top: 1px solid lightblue;
    border-bottom: 1px solid lightblue;
  }

  ${Details} {
    visibility: hidden;
  }

  &:hover ${Details} {
    visibility: visible;
  }
`;

The ${Details}  component selector in styled-components doesn't work in fuse but does work in webpack.

@matt-erhart and what's in ./Icons

@matt-erhart could this something to do with default exports?

Just exporting const
export const DetailsBase: React.StatelessComponent<any> = props => {
  return (
    <Tooltip
      mouseLeaveDelay={0}
      placement="top"
      overlay={ <Text m={0} p={0}>hey</Text>  }
      arrowContent={<TooltipHtml m={0} p={0} className="rc-tooltip-arrow-inner"></TooltipHtml>}
    >
      <Icon size={20} icon={ic_info_outline} className={props.className} />
    </Tooltip>
  );
};
export const Details = styled(DetailsBase)``; // just to use Details as a selector

And what kind of error you got? Could you create a repository where the issue is reproduced?

FuseBox v4 Major Upgrade
As of today, the latest major version of FuseBox v4 is available in fuse-box@next. FuseBox has undergone a full re-write from scratch, learning from its mistakes in the previous versions.
There are a lot of improvements, speed and config wise.
Get started here
We are still working on the documentation and polishing before the major release. We are getting very close. And we need help testing.
npm install fuse-box@next

Most of the issues that I am closing have been resolved, however, if you find that your issue is still relevant in v4 don't hesitate to re-open or (better) create a new one with v4 configuration.


Update base.go

If resp is nil this panics without providing a good error.

lgtm (and tested offline), thanks!


FEAT: Improve subscribe links

Why the checks are not running? I want to see the netlify preview

Why the checks are not running? I want to see the netlify preview

We're trying to solve the issue. We are in the same page, we want to see the preview.


Fixed the x-axis sequence issue for top projects card

Description - The x-axis was not plotting the time in sequence if the timestamps aren't same for all namespaces for top projects card.
Before :

After fixing:

Pull Request Test Coverage Report for Build 1397

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 86.465%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/selectors/prometheus/storage.js
0
1
0.0%

src/components/StorageOverview/TopConsumers/TopConsumers.js
0
2
0.0%

Totals

Change from base Build 1396:
0.1%

Covered Lines:
3643

Relevant Lines:
4038

💛  - Coveralls

Sent the PR to branch v2.0.0-beta.0. Hence, closing this PR.

Reopening the PR as backported changes needs to send me in master too.


Added feature - creating a new independent managed object context

Added feature: Create a new independent managed object context with a concurrency type of NSPrivateQueueConcurrencyType using the
same managed object model and persistent store as the main context but a NEW persistent store coordinator. This is
useful when performing large (time consuming) updates to the database in the background. The main context
can continue to read from the store but will have to wait to perform any updates - this uses the WAL
feature of SQLite (default SQLite mode from iOS7 onwards).

@ParmeshwarBayappu this looks really good. I plan on merging it and updating CocoaPods on Sunday.

I made a minor enhancement:
Added observer to receive notification whenever any independent context (created thru this class) completes save operation and further broadcast using a predefined notification name. This is something the foreground objects (ViewControllers) would be interested in. Without this the background savers will have to post this notification explicitly whenever they complete the save operation successfully.


feat: add interactive demos

This PR creates 3 new interactive demos, as written in issue #15. I have tested the behaviour of the frontend, and everything seems to work as expected.
No tests have been written for this new feature so far, and I will get to work on them ASAP if necessary. :)

Description of change

Creates a new interactive HTML demo.

Creates demos/html/index.html, demos/html/index.css and demos/html/index.js.

The JS file uses a jsdelivr CDN to fetch a browser-friendly version of @zootools/email-spell-checker.
The HTML file uses a fontawesome CDN for icons.

Creates a new interactive React demo.
Creates a new interactive Vue.js demo.
Adds documentation for all new demos.

Pull-Request Checklist

[x] Code is up-to-date with the main branch
[x] npm run lint passes with this change
[x] npm run test passes with this change
[x] This pull request links relevant issues as Fixes #0000
[ ] There are new or updated unit tests validating the change
[x] Documentation has been updated to reflect this change
[x] The new commits follow conventions outlined in the conventional commit spec

@erayalkis wow! this is awesome, thanks for doing this. will review it in the upcoming days. mind to record a gif or screenshots and attach to this PR so we can document it?

Thanks Jorge! Absolutely, I'll set up a short gif for the PR description real quick.😄I'll also get started on setting up the example on React and Vue, it'll be more helpful this way for sure!

cool @erayalkis !

@erayalkis hey! I tried your html version and I got a CORS issue. Know what's happening and how to fix it? Also, any other way to import the JS from the CDN that will be browser-compatible? I saw you are using the import and wondering if that will break in some browsers.
https://www.loom.com/share/67dd16d0a9974032a1a25b28a2ba6abe?from_recorder=1&focus_title=1

Hi @ferreiro ! Yep, I think I know what's going on. IIRC, a CORS error like this is caused by trying to import local files, it should be quite easy to fix :) I'll open an issue and create a PR to fix it as soon as possible!


500 Error while trying to get disease treatments

2018-01-31 22:37:17,300 - root - INFO - Docs found: 61
[2018-01-31 22:38:57,211] ERROR in app: Exception on /api/bioentity/disease/MONDO:0005720/treatment/ [GET]
Traceback (most recent call last):
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask_restplus/api.py", line 557, in error_router
    return original_handler(e)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask_cors/extension.py", line 161, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask_restplus/api.py", line 313, in wrapper
    resp = resource(*args, **kwargs)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask/views.py", line 84, in view
    return self.dispatch_request(*args, **kwargs)
  File "/root/livewebsites/biolink-api/venv/lib/python3.6/site-packages/flask_restplus/resource.py", line 44, in dispatch_request
    resp = meth(*args, **kwargs)
  File "/root/livewebsites/biolink-api/biolink/api/bio/endpoints/bioentity.py", line 309, in get
    return condition_to_drug(id)
  File "/root/livewebsites/biolink-api/biowikidata/wd_sparql.py", line 121, in condition_to_drug
    wdids = resolve_to_wikidata(condition_id)
  File "/root/livewebsites/biolink-api/biowikidata/wd_sparql.py", line 94, in resolve_to_wikidata
    (_,is_curie,p) = prefix_map.dbprefix2prop()[prefix]
KeyError: 'MONDO'

@cmungall any help with this?

For wikidata queries we need to convert MONDO in the backend, although it doesn't appear cowpox has any treatments in wikidata: https://www.wikidata.org/wiki/Q18964867, https://api.monarchinitiative.org/api/bioentity/disease/DOID:8956/treatment/

FWIW, that's the wd page for the virus, the disease page is here https://www.wikidata.org/wiki/Q1066011
But yes, it still lacks a treatment, and we need to fix the API here

Apologies; I'm missing the backstory here. Why is another ID space needed?

The query doesn't work with MONDO IDs.


Please provide the dataset. no dataset found in the link

Could you please provide the dataset. I cannot access or load the dataset through the link that you provided.

Hi, I just checked the link and it seems to be working.
If you follow the instruction on the page to request the dataset from<EMAIL_ADDRESS>they will send you the dataset. I do not have a local copy at the moment.
Please let me know if you do not hear back after a couple of days and I will chase your request.


some code fragments are not highlighted

Sphinx does not highlight some of the code fragments, such as
# definition of a generic model
@inf.probmodel
def pca(k,d):
    w = inf.Normal(loc=np.zeros([k,d]), scale=1, name="w")      # shape = [k,d]
    with inf.datamodel():
        z = inf.Normal(np.ones(k),1, name="z")                # shape = [N,k]
        x = inf.Normal(z @ w , 1, name="x")                     # shape = [N,d]

# create an instance of the model
m = pca(k=1,d=2)

at https://inferpy.readthedocs.io/en/latest/notes/guidemodels.html

This happens because such code contains a python3 specific feature (i.e., operator @). For solving that, specify that the syntaxis is python3:
.. literalinclude:: ../../examples/docs/guidemodels/1.py
   :language: python3
   :lines: 4-14


A list of errors and suggestions

Introduction
This is a compilation of issues that I've noticed and had to deal with when developing siliapp and siliui. I bring this up because the text rendering for those libraries were partially based on RFont and as such, said mistakes in my libraries also exist within RFont.
Issue 1: No way of getting the correct height for text
Description
This is quite a huge issue in regards to using RFont for UIs. RFont assumes that the specified user's size is equivalent to the actual total height of the text, which is often not true for both English and especially international text. This can either result in A) some characters looking slightly awkward and too cramped or B) a very noticeable misalignment to appear when the text is suppose to be centered in a larger object.
Solution
RFont needs to do 2 things:

Update the Y advancement of a newline.
Update the return values of 'RFont_draw_textandRFont_text_width_len`

Currently RFont sets every newlines' vertical advancement to the user-specified size, which is only partially correct. The formula to calculate the actual line height is:
f32 newline = font.size * (-descent * font.scale)

descent is available when RFont is calculating font.scale, so implementing this wouldn't be difficult. Note that the newline should then be scaled down to the user-specified size for it to work properly.
To make sure that the issues of UI misalignment or cropping text doesn't appear, it is advisable to also provide the full height of the text alongside its width. It won't be too difficult to calculate it as all it would be is scaledNewline  * (numOfNewLines + 1).
PS I've provided two screenshots of how long a newline should be using the Helvetica font, which were taken from the Kate text editor as well as from my siliapp library.
Code to reproduce the bug
void drawRectangle(RGFW_rect rect, int windowWidth, int windowHeight) {
    float x1 = 2.0f * rect.x / windowWidth - 1.0f;
    float y1 = 1.0f - 2.0f * rect.y / windowHeight;
    float x2 = 2.0f * (rect.x + rect.w) / windowWidth - 1.0f;
    float y2 = 1.0f - 2.0f * (rect.y + rect.h) / windowHeight;

    rglColor4f(0, 0, 0, 1);
    rglBegin(RGL_TRIANGLES_2D);
        rglVertex2f(x1, y1);
        rglVertex2f(x1, y2);
        rglVertex2f(x2, y2);

        rglVertex2f(x1, y1);
        rglVertex2f(x2, y2);
        rglVertex2f(x2, y1);
    rglEnd();
}
...
drawRectangle(RGFW_RECT(0, 0, 300, 60), win->r.w, win->r.h);
rglRenderBatch();
RFont_set_color(0.0f, 1.0f, 0, 1.0f);
RFont_draw_text(font, "jjabcdefghijklmnopqrstuvwxyz\nŠ", 0, 0, 60);

Screenshots
Bug

Every RSGL UI image from this section

Expected behaviour

Extras (Citation)

General info about ascenders and descenders
TrueType font specification

Issue 2: Advance width for space and tab
Description
According to the TrueType font specification, the space and horizontal tabulation are required to be set to a glyph with a positive advance:

Each of the following characters must map to a glyph with no contours and positive advance width:
0x0009 HORIZONTAL TABULATION
...
0x0020 SPACE
...
The following groups of characters must have the same width
0x0009 (HORIZONTAL TABULATION) and 0x0020 (SPACE)

Currently RFont bases the space based on the user-specified size divided by four, which might not look good for every font.
Solution:
Implement the correct advance width for spaces and tabs when detected in a string.
Extras (Citation)

TrueType font specification

Suggestion 1: A small improvement for RFont_draw_text_len
Description
RFont_draw_text_len has a rather convoluted loop condition to take account the length if it isn't 0
   char* str;

   for (str = (char*)text; (len == 0 || (size_t)(str - text) < len) && *str; str++) {
         if (*str == '\n') {
         x = startX;
         y += size;
         continue;
      }

      if (*str == ' ' || *str == '\t') {
         x += (size / 4);
         continue;
      }
      ...

This works, but clearly is less than ideal. I would suggest that instead of this you would transform the start of the for loop into:
   const char* str = text;
   while ((str - text) < len) {
       char x = *str;
       str += 1;

       switch (x)  {
           case '\0': { ...; break; }
           case '\n': { ...; break; }
           case '\t':
           case ' ': { ...; break; }
       }
       ...
   }

And for the RFont_draw_text/RFont_draw_text_spacing functions, you would replace 0 with USIZE_MAX or some other equivalent that would give you the maximum value of size_t (((size_t)0 - 1) could work, but that's stingy). The ending result would be this:
size_t RFont_draw_text(RFont_font* font, const char* text, float x, float y, u32 size) {
   return RFont_draw_text_len(font, text, USIZE_MAX, x, y, size, 0.0f);
}

size_t RFont_draw_text_spacing(RFont_font* font, const char* text, float x, float y, u32 size, float spacing) {
   return RFont_draw_text_len(font, text, USIZE_MAX, x, y, size, spacing);
}

These few changes makes the code more clean and slightly more efficient, while also retaining the original intent in a different way.
PS This suggestion also applies to RFont_text_width.

Most of these should be solved with the lastest commit

Git cloning and then trying to run make results in a compilation error.
[eimamei@archlinux ~]$ git clone https://github.com/ColleagueRiley/RFont
...
[eimamei@archlinux ~]$ cd RFont/example
[eimamei@archlinux example]$ make
make gl
make[1]: Entering directory '/home/eimamei/RFont/example'
gcc -Wall -Werror -Wstrict-prototypes -Wextra main.c -I./include -lXrandr -lX11 -lm -lGL -I./ext -I../ -D RFONT_RENDER_LEGACY -Wall -O3 -o gl
In file included from main.c:21:
../RFont.h: In function ‘RFont_create_atlas’:
../RFont.h:891:34: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
  891 |    u8* data = (u8*)calloc(sizeof(u8), atlasWidth * atlasHeight * 4);
      |                                  ^~
../RFont.h:891:34: note: earlier argument should specify number of elements, later size of each element
cc1: all warnings being treated as errors
make[1]: *** [Makefile:39: gl] Error 1
make[1]: Leaving directory '/home/eimamei/RFont/example'
make: *** [Makefile:34: all] Error 2

There appears to be some kind of imposter among us.


OpenAI / Microsoft Azure accounts

Creative mint stopped working because of issues related to account management / some upgrade, didn't read the email before, found out just today. Will follow up shortly.

ignore

creative mint works again, however, both OpenAI and Azure are using my credit card with "pay as you go" model, while it's just cents at this point, I'd like to figure out a way how to make this fun AI piping somehow sustainable by itself.

this issue is too old to reproduce


Optimise find_node_tip_weights()

tsdate spends ~20% of its time in find_node_tip_weights(). We've determined that this is highly optimisable, specifically, we could use the edge diffs to update the node tip weights instead of iterating over all nodes in every tree. Perhaps we can also avoid checking if the nodes are sample nodes or not, as this is very slow too.

For info, there is a comment about this in the code at https://github.com/awohns/tsdate/blob/fb381cddf64e89505101fde346d1b9f7d7f5f3c3/tsdate/date.py#L274

Closed with #54


Hubspot Marketing

When submitting a connector, please check the following conditions for your PR.

[X] I attest that the connector works and I verified by deploying and testing all the operations.
[X] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[X] I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff.

[[certify-connector]]

[[certify-connector]]

[[certify-connector]]

[[certify-connector]]

@mamurshe Can you explain why I need to use variables and parameters like the example you gave? I don't use them elsewhere in the connector

Updated apiProperties


Restore minimal support for Gene Ontology annotations

Rationale
Automatically loading Gene Ontology data has been broken for a long time.
Changes

Switch to HTTP downloads
Clearly label as deprecated
Minor code cleanup, including closing of streams and more proactive temp file deletion

Thanks for doing this. Feel free to delete FTPUtil.java as a part of this PR.

Thanks for the reminder. I meant to do that but forgot. Now deleted in the FB.


Proposal: Go 2: Create logger interface in the standard log package, with additional levels. Optionally add it to context package, too

Logging is important, I think we can all agree that it is. The standard "log" package simply is too limited as it stands, so it's extremely common to use a third party package (logrus, zerolog, etc...). These third party packages don't necessarily share the same interface. It would be great to have a usable logger in the standard lib, and an interface so the community can adopt a standard approach to logging.
So what is the current logger missing?
Currently, only focusing on the output functions, we have 3 to choose from:

Print & co (Println, Printf)
Fatal & co (Fatalln, Fatalf) - equivalent to the Print equivalent + os.Exit(1)
Panic & co (Panicln, Panicf) - equivalent to Print equivalent + panic()

Naturally, the latter is not commonly used if you want to honour the go proverbs.
The most obvious reason for people to use a third party logger is to be able to differentiate the log output, using the standard levels. To this end, Print & co are effectively replaced with:

Debug & co
Info & co
Warn & co
Error & co

There are 2 more (fairly) common log levels that will be discussed separately further down: Trace and Custom.
Contextual fields/values (prefix &co)
Something that is commonly done, too, is adding trace id's or correlation id's in logger output. With the standard package, it's possible to write something like this:
    l := log.NewLogger(
       os.Stdout,
       fmt.Sprintf("trace ID: %v", ctx.Value(traceIDKey)),
       log.Ldate | log.Ltime | log.Lshortfile,
    )

Third party packages allow you to add any number of prefixes/fields to individual messages, by doing things like:
    zerologger.Debug().Str("trace ID", traceIDValue).Msg("this is the message")
    logrus.WithField("trace ID", traceIDValue).Debug("this is the message")

Should I want to do the same thing with the standard logger, I need to make sure the particular logger isn't used concurrently. Sure, the logger guarantees the writer is accessed sequentially, but I'm forced to write this:
    oldPrefix := stdLogger.Prefix()
    stdLogger.SetPrefix(fmt.Sprintf("%s - trace ID: %s", oldPrefix traceID)) // sets the prefix
    stdLogger.Println("this is the message")
    stdLogger.SetPrefix(oldPrefix)

Clearly, though the writer is accessed sequentially, it's not hard to imagine that there could be a second routine either calling Print after you've set the prefix, or conversely: it's equally possible that the prefix you've just set is overwritten by another routine between your setting a prefix, and actually logging the output. This is a big problem that needs to be address should we want the standard log package to be usable in real life.
What about context.Context?
That brings me to something I'd personally consider to be a nice addition to the log package in general. Those trace ID's are very commonly used, and very useful. Quite often people end up writing their own packages, or handlers to automatically get the trace ID's from request headers (or generate them, or wherever), and add them to the context. It would be nice to be able to add this to the logger API:
type Logger Interface {
    Debug(string) // all the log levels etc...
    SetCtxCallback(func(context.Context, Logger) context.Context) /// add this
    Ctx(context.Context) (Logger, context.Context) // add this
}

With these additional functions, I'd be able to create a logger and do something like this:
    logger.SetCtxCallback(func (ctx context.Context, logger log.Logger) context.Context {
        tID := ctx.Value(traceIDKey)
        if traceID, ok := tID.(string); ok {
            logger.SetPrefix(fmt.Sprintf("trace ID: ", traceID))
            return ctx// done, added the prefix
        }
        // generate new traceID
        logger.SetPrefix(fmt.Sprintf("trace ID: ", traceID))
        return context.WithValue(ctx, traceIDKey, traceID) // return context with value
    })

// use like this:

logger, ctx = logger.Ctx(ctx)
logger.Infof("There is a prefix with the trace ID %v", ctx.Value(traceIDKey))

Something that might be worth discussing is that, given the logger can be made context aware now, whether or not the log levels could be ramped up should the context be cancelled by the time the writer is reached. Maybe that could be configured. This probably doesn't add much value, and is a bit silly, but just thought I'd mention it.
Trace, custom levels, and the Print & co calls
The trace log level is debatable. There already is a Log function in the runtime/trace package, and I'd argue it's better to keep it there. The Trace(f|ln) functions can simply be omitted from the logger interface.
Personally, I'm not sure if I've ever felt the need to have a custom log level. It's possible that there might be a genuine need to support this, perhaps not. Should this be added, I think the best approach to use is to implement a Custom & co function that takes 1 additional argument allowing to specify the desired level:
logger.Custom("my-level", "this is the message")

My idea for the Printcalls is to have them dynamically log at the minimum log level that is enabled. During development (or whenever the log level is set to debug, Print will be equivalent to Debug, if the level is set to warn, then Print is equivalent to Warn etc... This is not to encourage abuse, but more to make the transition to the standard package easier. Of course, the Print calls should not ramp up to Fatal if the configured log level is Fatal. Arguably, it shouldn't go higher than Warn.
Specific changes to the log package
TL;DR, here's what this proposal boils down to:
Change the log.Logger type to an interface
Having a common denominator logger interface in the standard package would make life a lot easier, and could go a long way WRT encouraging drop-in replacement packages for logging, or at the very least: uniformity.  I'm looking forward to your feedback, comments, ideas, etc... I honestly believe the log package needs to be a bit more flexible, and I think this is a good way of going about it. Then again, that's one persons idea/opinion

Similar to #13182.  That may be a better place to discuss this.

@ianlancetaylor  Damn, I looked through some issues to see if I wouldn't be posting a duplicate. The conclusion of the proposal you linked to, however, is to indeed change the logger type to be an interface, and wait for Go2 to make that change.
I think my proposal is sufficiently different in that I'm suggesting a substantial change/expanding of the interface. Part of the reason for my suggesting this implies/requires the log.Logger type to be redefined as an interface already. Given that there seems to be little discussion about whether or not the type should be an interface, I think this issue could serve to discuss what that interface should look like.

@lpar Because of point 1 under the problems you list I'm assuming you're talking about the current implemented log package (not the proposed interface I've shared here). I completely agree with you on the log levels. We need them, we all use them, and not using them leads to much unneeded pain and wasted time sifting through logs to see where an actual error occurred vs some leftover debug logging lines.
Same goes for structured logging and performance. Couldn't agree more, hence my sharing my thoughts here. I'm looking for feedback before I start hacking away at things.

Not sure what you're referring to. I prefer setting my logger to output to os.Stdout for everything, and just scrape the output and push that to elastic (ie typical FEK/ELK stack).

The only point I'd disagree with you is on the implicit terminating calls. I see little value in forcing people to write:
if err := doStuff(); err != nil {
    log.Fatal("An error occurred, exiting (%+v)", err)
    os.Exit(1)
}

As opposed to a simple:
if err := doSomething(); err != nil {
    log.Fatalf("An error occurred - exitting: %+v", err)
}

The fact that the func is called Fatal should make it obvious that it's a terminating call. I haven't used the log.Panic call at all though, like ever... don't know if that's a particularly useful thing to keep, and given that Go2 can break backwards compatibility I'd personally have no problems whatsoever with that call to be confined to the pages of Go's history.

I use Go to write programs which are called from crontabs, run by users at the command line, and run on cloud platforms. In those circumstances, the expected behavior is that errors go to stderr and regular output (such as progress messages) goes to stdout. Sure, if I'm stuffing everything into ELK I don't need to separate errors (and I generally want the output in something like JSON), but that's not usually the case for me, and I think we should make sure that the API is suitable for things like writing Unix utility programs and daemons.
Dave Cheney has set out the problems with log.Fatal. Given that there are so few situations where it's appropriate, I don't see that it has value to leave it in the API as a pitfall for beginners just for the sake of saving one line of code. The same applies to log.Panic.

I am negative to give levels to the logging interface.
The log level required by the project varies depending on the background.
For small commands and servers Info, Error, Fatal are sufficient,
Debug, Warning, perhaps Emerg and Crit etc may be necessary.
At least Unix syslog and Windows Eventlog have different levels.
Some people say there is no need other than Debug and Info.
The Go log package does not have levels, but third party are not the only choice.
We need a little work but solution by wrapping is a good enough approach.
GoPlayground and Upspin are good examples.
GoPlayground has Print, Error, and Fatal Level interfaces, and uses the standard logger wraped.
Upspin redefines the log package itself and has a standard logger for each level.
The GoPlayground example is simple and useful for small commands and servers that require less levels.
An example of Upspin has cost, but it is worthwhile on a large scale.
Third-party log packages may not meet your needs, but keep costs down.
The current Go can choose a tradeoff.
The level defined in the standard library gives a slight sense of security,
Gives great pain to those who do not meet the needs.
And the bloated interface is ugly.
The interface of Go is Acceptable.
In many cases it is more beautiful to define things that the user needs rather than the library.

@bonpibonpi You raise a couple of valid points there, specifically around the syslog having different levels. I get the argument made for third party packages, that's why I'm using them. The reason for my posting this proposal was more to take advantage of Go's ecosystem being one that is fairly opinionated. So far, there's been a couple of times where there were several tools doing a similar job, and the community has fairly quickly adopted a single, standard tool (e.g. vendoring via glide, goop, trash, gopm, etc.. eventually resolved when dep became the official tool).
The current interface can be preserved, and even kept as a separate interface type to be embedded or whatever. That's just it: the log levels you refer to for syslog or windows eventlog don't have to be added to a single one-size-fits-all logging interface. There's nothing wrong with having a CLILog, ServerLog, and SysLog interface, is there?
This is definitely a discussion worth having, I think, if there's enough support for this proposal to gain traction, naturally.
Regards

There have been attempts in the past to produce a standard logging interface.  I think @rakyll knows something about that.

@zombiezen has run comprehensive research in the past and can provide context on the historical attempts and feedback on this proposal.

The original discussion and design proposals are documented on golang-dev. Sarah's post in particular summed up our (Sarah Adams, Peter Bourgon, Chris Hines, Cory LaNou, Herbie Ong, and myself) findings:
The overall requirements for what end-users need is bifurcated into what an application and what a library needs for logging. The variance in efficiency and format of logging backends is so large so as to make generalizations not useful to a library. The best practice here should be that libraries (either standard library or third-party) expose a structured interface where appropriate (like net/http/httptrace) and that applications map the appropriate events to the specific logging backend of their choice. Creating a logging abstraction for a particular application or company is more optimal than trying to design an abstraction that gives a false sense of being uniformly optimal.

And separately, I'll add my two cents here: I think that the places in the standard library that use a *log.Logger as a parameter are incorrect. What I think should be considered for Go 2 is replacing these with interfaces to set better precedent. AFIACT, the particular occurrences are:

net/http.Server.ErrorLog
net/http/cgi.Handler.Logger
net/http/httputil.ReverseProxy.ErrorLog

@zombiezen I'll have a read through the links you provided. Just for the avoidance of doubt: I'm not proposing a single logger to be added to the standard lib. I've since actually encountered some situations where I've realised that a single logger interface would either be inadequate, or monstrously large. What I think a good addition to Go2 would be, is exactly what you refer to with your last comment: having distinct, standardised logger interfaces is what I think would really add value. The implementation of which is still very much reliant on individual needs, and can be easily done by one of the more popular third party logger packages.
The end goal should be to have plug-'n-play style logging everywhere, so you can pass an log.ErrorLogger to *sql.DB, for example:
db, err := sql.Open(driver, dsn, somelogger.New(opts...))

With slq.Open being some func along the lines of func Open(driver, dsn string, errLog log.ErrorLog) or something.
Not sure if I ought to update this proposal to reflect the change of focus, open a new one, or abandon it all together.

I'll leave it to other folks on proposal review to weigh in on concrete next steps, but my advice would be to open up targeted proposals for specific standard library packages, starting with the ones I pointed to above. I'm not firmly convinced that there should be an overarching interface (i.e. something like http.ErrorLogger seems more correct to me), but the requirements there would be more focused than the original post and the design space simpler to iterate on.

The overall requirements for what end-users need is bifurcated into what an application and what a library needs for logging. The variance in efficiency and format of logging backends is so large so as to make generalizations not useful to a library.

I tend to feel that libraries shouldn't be logging. I was interested in having a sufficient standard application logging interface, to promote code reuse and standardize things like how to set destinations and change output formats.

Let's close this issue as a dup of #13182.  If we make Logger an interface type, then that issue is a good place to discuss the details of the interface.


Expose CLI model

app.Model()
Fixes #104

Coverage decreased (-2.9%) to 92.68% when pulling 5e525d076aa41f2dadf2df941986d4ca42bb04ec on issue-104-app-model into fbc50e90e1fb96a3ddde67f9ca6289b8054f2f7e on master.

Getting a panic.
Pulled this branch:
GO111MODULE=on go get github.com/jawher/mow.cli@issue-104-app-model

Here's a pared-down file that shows the issue:
package main

import (
	"os"

	"github.com/davecgh/go-spew/spew"
	cli "github.com/jawher/mow.cli"
)

func main() {
	app := cli.App("myapp", "Description.")
	app.Version("version", "1")

	app.Command("do", "Do the thing.", func(config *cli.Cmd) {})

	spew.Dump(app.Model())

	err = app.Run(os.Args)
	if err != nil {
		exitErrorf(err)
	}
}

And the panic.
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/jawher/mow%2ecli.(*Cmd).Model(0xc00014e200, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/path/to/gocode/pkg/mod/github.com/jawher/mow.cli@v1.1.1-0.20200703143524-5e525d076aa4/commands.go:157 +0xaec
github.com/jawher/mow%2ecli.(*Cmd).Model(0xc00014e100, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/path/to/gocode/pkg/mod/github.com/jawher/mow.cli@v1.1.1-0.20200703143524-5e525d076aa4/commands.go:167 +0x9fc
github.com/jawher/mow%2ecli.(*Cli).Model(...)
	/path/to/gocode/pkg/mod/github.com/jawher/mow.cli@v1.1.1-0.20200703143524-5e525d076aa4/cli.go:71
main.main()
	/path/to/gocode/src/github.com/skyzyx/project/src/main.go:16 +0x197

I don't see anything obvious in the code other than commands.go:157 references make() with a specific len as the second parameter. Maybe it's miscalculating?

@skyzyx Nice catch ! I just pushed a commit to fix a bug in a slice allocation len 🤦♂

Had a chance to come back to this, and I'm quite happy with the results. THANK YOU!

This is available on the master branch, but has not been cut into a release.


address some comments for 11792

#11792 is merged without @revans2 's approval because of https://github.com/NVIDIA/spark-rapids/pull/11792#issuecomment-2508034681. A few comments are received afterwards from @abellina @gerashegalov and @revans2 . This PR is to address their comments

build

build

build

@abellina could you please take another look? I debugged what was happening with the test and it is really unlikely to be a production problem, but I want to hear your opinion on it.

I'll take a look @revans2 @binmahone, it might not be today, but I'll try to at least get the gist of it from Bobby.


texsc and tesqc are not used

waiting for https://github.com/latex3/l3build/issues/245

now they are


DropDown in modal (twitterbootstrap)

Hi,
I using jspreadsheet in modal, but,  lost position of dropdown list,
thx

Do you use modal of jSuites ?

No, my project using twitter bootstrap modal.

Hi,
I have tried you reproduct this error. But for me it work.
Could you share configuration of jspreadsheet ? and version used

My version is 4.10.1 / twitter bootstrap 4

Check with your CSS your container, maybe you should use position: relative or fixed in div contain JSS

I changed code below and works, but, I think this is not correct. Another idea?

I Have other solution, I think its the better.


[RFC]: Add C implementation for @stdlib/math/base/special/acsch

Description
This RFC proposes adding native C implementation for stdlib/math/base/special/acsch.
double stdlib_base_acsch( const double x );

Related Issues
None.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Hey @Pranavchiku @kgryte , I would like to work on this issue but let me know how this is different from issue #861 ( asec) and #859 (acsc). What's make different to each of these three functions

@raunak-dev-edu They are different functions, as may be observed by examining the JS implementations of the various packages. Each of the linked issues achieves something similar; however, the implementations will be different.

To solve these i want to add all files inside @stdlib/math/base/special/acsch
update readme.md
include.gypi
binding.gyp
include/stdlib/math/base/special/
evalpoly.js
src
manifest.json
lib
examples
benchmark
test)(similar to https://github.com/stdlib-js/stdlib/pull/769) and implement acsch functionality.
and i see that already c implementation is done for @stdlib/math/base/special/acos am i correct?.
did my understand up to now is correct. Did i continue to implement same as said.

@yaswanthkosuru are you still working on this? If not, can I take this up?

I still working.but unfortunately my system crashed so I reinstall all these files so I close pr.i reopen pr in 1 day

@yaswanthkosuru are you still working on this? If not, can I take this up?

@yaswanthkosuru are you still working on this? If not, can I take this up?

I am working on it.


Bootstrap JS not executing after build

I just noticed, when i in the development mode, bootstrapjs work perfectly fine, but once I build it, paths going to extract and include in the head area, but none of the functions are working tried all possible ways, but none of them are working,
try to include like this
script(src=require('../../../node_modules/bootstrap/dist/js/bootstrap.bundle.min.js'), defer=true)
script(src=require('./onboarding.js'), defer=true)

and then this one inside onboarding.js
import "bootstrap";

also tried
require("bootstrap")

all of them are working but not after build js files going to compile and include in the head area.

I tried it nothing happened, even console not throwing any errors, that's the issue. When I run dev mode it's working fine when i run build bootstrap link there with the all the JavaScript but none of them are running or throwing any errors:
before build (yarn watch)
https://imgur.com/6jS8cGZ
after build (yarn build)
https://imgur.com/DrX1Uzj

@yashiel
can you please create small repo with reproducible issue?

try this
https://github.com/yashiel/testrepo
these are the areas with dropdown
https://i.imgur.com/amB4UTC.png
goto /onboarding_1.html

@yashiel
v3.1.1 with many bugfixes is released!
Please see my comments in the PR.
You have wrong webpack.prod.js therefore npm run build not works. I have fixed your config in PR.

I've noticed your changes, and I implement those changes to my original production ready code, everything is running smoothly without any issue, my other bug also fixed,
I have to tweak purge CSS to solve that issue like you mentioned, thanks anyway. I'll close this thread now.


Allow viewing different area on site main page

On http://leafletjs.com/ we see a sample map of London.
But there is a very big chance potential users would like to see how a different area looks before choosing leaflet,
Therefore a choice should be added there, allowing users to see instead somewhere else too, without needing to zoom all the way out, move to another continent, then zoom back in.

Also add a permalink link to a corner of that map.
Some users might want to use that map to check if a problem occurs in a certain area and report back to you.

@jidanni seems your confusing Lealfet, which is a javascript library to display maps, with the map itself.
With Leaflet, you can display many maps, OpenStreetMap based or not, and it comes with no default map.
See for example this plugin for some easy to set up choices: http://leaflet-extras.github.io/leaflet-providers/preview/

Mainly in https://www.facebook.com/groups/OpenStreetMap.TW/permalink/969547683110701/
we are trying to find out who to blame for putting village names right
on top of boundaries, on opencellid.org. We see "leaflet" there in the corner...

map data: OpenStreetMap© | ODbL 1.0, tiles: CC-BY-SA 2.0

And specifically, if you are on the rendering, you should talk here: https://github.com/gravitystorm/openstreetmap-carto/

Note that https://github.com/gravitystorm/openstreetmap-carto/ should be used only for developing openstreetmap-carto - this particular map style is either badly outdated version or some fork.

map data: OpenStreetMap©
By the way, that links to http://www.openstreetmap.org/ .
Couldn't it better link to http://www.openstreetmap.org/#map=17/24.20816/120.74495 (if that link is indeed made by leaflet.)


ci: run the release when merges to main

What does this pull request do?
Use https://test.pypi.org/ to test the Release GitHub workflow on main and skip push changes. If a release tag then it behaves as usual, publishing the release.
Related issues
Closes https://github.com/elastic/apm-agent-python/issues/1994
Implementation details
It skips anything related to pushing the docker images, lambda functions or GitHub releases.
Potentially we could use a different AWS account or docker registry, though those steps are only about pushing the changes. If needed we can do a follow-up.
Test
I created a feature branch called test/release based on this PR, and the build is now running, see here
It failed with
Notice: Attempting to perform trusted publishing exchange to retrieve a temporary short-lived API token for authentication against https://test.pypi.org/legacy/ due to __token__ username with no supplied password field
Error: Trusted publishing exchange failure:
Token request failed: the server refused the request for the following reasons:

* `invalid-publisher`: valid token, but no corresponding publisher (All lookup strategies exhausted)

This generally indicates a trusted publisher configuration error, but could
also indicate an internal error on GitHub or PyPI's part.

The claims rendered below are **for debugging purposes only**. You should **not**
use them to configure a trusted publisher unless they already match your expectations.

If a claim is not present in the claim set, then it is rendered as `MISSING`.

* `sub`: `repo:elastic/apm-agent-python:environment:release`
* `repository`: `elastic/apm-agent-python`
* `repository_owner`: `elastic`
* `repository_owner_id`: `6764390`
* `job_workflow_ref`: `elastic/apm-agent-python/.github/workflows/release.yml@refs/heads/test/release`
* `ref`: `refs/heads/test/release`

@xrmx , I might need your help with this approach:

PyPI does not allow for a filename to be reused, even once a project has been deleted and recreated.

Then, a second run failed:
https://github.com/elastic/apm-agent-python/actions/runs/8229823579/job/22501787751
What do you suggest?

@v1v can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

Nice, but I have no clue how to do it; I can try to figure out but if you know how to, would you mind contributing to this PR? 🙏

can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

Nice, but I have no clue how to do it; I can try to figure out but if you know how to, would you mind contributing to this PR? 🙏

Sure

can we postfix a +$GITHASH to the release version? See https://peps.python.org/pep-0440/#adding-local-version-identifiers, the paragraph before last.

Nice, but I have no clue how to do it; I can try to figure out but if you know how to, would you mind contributing to this PR? 🙏

Sure, will take a look later today

@v1v What do you think about somethings like this
diff --git a/setup.py b/setup.py
index 23ebec33..235bf4d8 100644
--- a/setup.py
+++ b/setup.py
@@ -100,7 +100,11 @@ def get_version():
     for line in version_file:
         if line.startswith("__version__"):
             version_tuple = ast.literal_eval(line.split(" = ")[1])
-            return ".".join(map(str, version_tuple))
+            version_str = ".".join(map(str, version_tuple))
+            local_version = os.getenv("ELASTIC_CI_LOCAL_VERSION")
+            if local_version:
+                return f"{version_str}+{local_version}"
+            return version_str
     return "unknown"

and then exposing to the packages workflow an ELASTIC_CI_LOCAL_VERSION environment variable with the value of ${{ github.run_id }}?

no single quotes, but empty instead, single quotes will be empty in this particular case, I think that's the way to set empty env variables


This is in the workflow documentation, so will have to be dealt with when that migrates here.

Fixed in #247


Cache diagnostic mode config during server start up

Purpose

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882305902

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882305902
Status: cancelled

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7883588677

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7883588677
Status: success


Tiles can be moved accidentally, specially on mobiles

Environment
Docker
Version
0.7.0
Describe the problem
ISSUE
Tiles/cards of any service can be moved from its original location just with a single tap to scroll the page, when you're on a smartphone.
EXPECTED
Tiles/cards get locked from being moved.
SOLUTION
A: Add a toggleable option somewhere, maybe under settings, that prevents the elements from being moved if long pressed. The user will need to enable such option to allow reorganizing them, then, disable it again manually.
B: Increase the time (ms) that the element "listens" for a long press, so a scrolling gesture will not interfere, where the finger could touch the screen for more than xxx milliseconds.
Additional info
Tested on Firefox and Chrome browsers (Android).
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

All good, this is in active development and you're really fast implementing new features. Thank you for your work!

Closing with #226


Istio egress connections via service entry always show response code 0

Bug Description
Egress telemetry is missing information even in successful requests made to external endpoints.
Given the following service entry that is being applied to all proxies in the mesh:
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: amazonaws.com
spec:
  hosts:
    - "sts.amazonaws.com"
  ports:
    - number: 443
      name: tls
      protocol: tls
  location: MESH_EXTERNAL

Egress logs made to sts.amazonaws.com show up like so:
{"bytes_sent":5707,"request_id":null,"user_agent":null,"response_code_details":null,"downstream_local_address":"<IP_ADDRESS>:443","authority":null,"upstream_local_address":"<IP_ADDRESS>:36452","response_flags":"-","duration":687,"upstream_service_time":null,"downstream_remote_address":"<IP_ADDRESS>:36436","upstream_transport_failure_reason":null,"path":null,"bytes_received":784,"connection_termination_details":null,"response_code":0,"x_forwarded_for":null,"requested_server_name":"sts.amazonaws.com","protocol":null,"start_time":"2022-03-03T04:52:21.898Z","upstream_host":"<IP_ADDRESS>:443","route_name":null,"method":null,"upstream_cluster":"outbound|443||sts.amazonaws.com"}

I can verify that the pod is able to connect to sts.amazonaws.com.  but it is difficult for users to know what the response of that endpoint is without doing some manual testing. Is this the expected behavior for egress requests to hosts outside of the mesh? If not, is there a specific way to enable the response code being available? Having this information would be really helpful in debugging application issues, monitoring in dashboards, etc.
Thanks!
Version
Control Plane Version: 1.11.1
kubectl version: v1.20.11-eks-f17b81

Additional Information
No response

If your app is sending TLS traffic the proxy cannot see the requests or response code. You could originate TLS in the egress gw possibly: https://istio.io/latest/docs/tasks/traffic-management/egress/egress-tls-origination/


Remove Chinese comment in flink-api pom.xml

Purpose of this pull request
Remove Chinese comment in flink-api pom.xml
Check list

[x] Code changed are covered with tests, or it does not need tests for reason: pom.xml change
[x] Change does not need document change

I find out we already have Chinese check in https://github.com/InterestingLab/seatunnel/blob/7703be091f57db918ff463a482b908b14d56d02e/tools/checkstyle/checkStyle.xml#L43-L47. and I found default file filter is java in https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#includes.
I try to add pom.xml in section in https://github.com/InterestingLab/seatunnel/blob/2455218a1433deaa8b0798d5a6c07bf1a881ba41/pom.xml#L622-L633, but ckeckstyle still skip pom.xml. Am I miss something @kezhenxu94
    <includes>
        **\/*.java,
        **/pom.xml
    <includes>

@zhongjiajie maven only checks source files in "maven" project, a.k.a src, files like .asf.yaml, .github/ are not maven project resources thus won't be checked

@zhongjiajie maven only checks source files in "maven" project, a.k.a src, files like .asf.yaml, .github/ are not maven project resources thus won't be checked

Thanks for your explanation

@zhongjiajie maven only checks source files in "maven" project, a.k.a src, files like .asf.yaml, .github/ are not maven project resources thus won't be checked

Thanks for the clarification


Optapy solution stuck

Hey community, I'm trying to setup a label assignment. A collection of polygons were grouped into a cluster initially. I apply some soft constraint, but importantly, a hard constraint such that at any point, union of polygons of a cluster should never be a multipolygon (disconnected)
I've went ahead and took ClusterLabel as a problem fact and Polygon as a planning entity.
class Polygon:
      @problem_fact
      cluster_label: ClusterLabel
      geometry: shapely.geometry

#constraints.py

def valid_polygon(constraint_factory):
     return constraint_factory.for_each(Polygon)\
             .groupby(lambda raw_polygon: raw_polygon.cluster_label.label,
                     ConstraintCollector.to_list(lambda raw_polygon: raw_polygon.geometry)\
              .filter(lambda _, geometry: unary_union(geometry) == MultiPolygon) \
              .penalize(...)

This works but scales horribly. On real life dataset the hard penalty NEVER decreases even after 1 hour. Is there a better approach?

Is it because of the ConstraintCollector.to_list which is making it "slow", I don't think that's the issue.... but neverthless it shouldn't be stuck? Or is it perhaps the moves?

I suspect the main scaling issue has to do with ConstraintCollector.to_list; when ConstraintCollector.to_list is used, OptaPy/OptaPlanner cannot perform incremental score calculation on the collected elements, which massively degrade the performance. As an example, if you use to_list on a list of numbers and then sum them, the to_list approach would be multiple times slower than ConstraintCollectors.sum since it need to readd all the number each time (whereas sum only does the difference).
The way to fix it is to use a Custom ConstraintCollector (which in your case, would implement unary_union in an incremental way), which is not currently supported in OptaPy.
Moves can also have a major performance impact, but it hard to tell without benchmarking (and OptaPy doesn't support custom moves yet).
What is the score calculation speed reported by the solver? Ideally it should be above 1000 score calculations/sec (the higher the better).

best score (-5hard/0soft), score calculation speed (7/sec) I got this

But I get score calculation speed as 5/sec even when I use a very trivial groupby => sum => penalize soft constraint.  So I doubt that's the issue?


Fixed the crash due to packet buffers running out of space in CommandHandlerImpl.

Problem

There were intermittent crashes observed in the internal automation stress tests due to packet buffer pool empty i.e running out of packet buffers here

Although the logic mentioned says that do not crash on running out of packet buffers, the application crashes
due to the  below mentioned reason:
RollbackResponse will return CHIP_ERROR_INCORRECT_STATE leading to failure of the condition mentioned above leading to a crash.
mRollbackBackupValid is not set since the function CreateBackupForResonseCallback did not get executed which executes after AllocateBuffer() function in PrepareStatus() function.i,e due to packet buffer full the allocate buffer returned early.

Change Overview:

Fixed the crash by returning the possible CHIP_ERROR_NO_MEMORY due to running out of packet buffers.

@tehampson , can you please review.


Feat/add my stories list

@Jonathansoufer is this ready to review?

@obernardovieira Not yet, I was checking https://github.com/impactMarket/api/blob/master/src/services/story.ts now to see if we have all the services related to it. Seems we have it. I'll implement and submit it to your review tomorrow (24/03)

No rush on this @Jonathansoufer it's not going to be available in the next release.


Add Code for LCS of 3 Strings

Submission Title
LCS of 3 strings
Submission Type
Algorithms
Submission Description
DP algorithm. Find LCS of 3 strings
Folder Related To
Algorithms => Dynamic_Programmin
Contributors

[x]  C++ -
[ ]  C -
[ ]  Python -
[ ] Java -
[ ] JavaScript -
[ ] TypeScript -
[ ] Golang -
[ ] Ruby -
[ ] php -
[ ] Swift -
[ ] C# -

Please Assign me for this Algo in Java

Please assign this to me for python

thanks @everyone :v:


Sidebar control header height does not match Tab control height

The sidebar control's height is more than the tab control height, as you can see from the image below. I tried playing with different sidebar heading assets (small, small@2x, heading@2x). When these asset images are used, the sidebar looks a bit skewed. I am new to Sublime Themes, so I have no idea how to increase the tab control height. Any help would be appreciated.

@equinusocio Thanks for your work. I :heart: Material Theme.

you have to update materiale theme to 2.0.1 before using app bar addon

Works great after upgrading Material Theme to 2.0.1. Thanks :+1:


Naming

cose.COSE_Mac is a little repetitive.  Do you mind if I change this to cose.Mac, and take the opportunity to move most of the code into a /lib directory?  This will obviously be a breaking API change, and require a major rev number.  But better to do it now before there's a bunch of downstream folks depending on the library.

+1 do it


How should we update the cilium-agent version used by the CLI?

Users are likely to pull the cilium-cli binary once and not update it particularly frequently.
Currently, we are embedding the "latest" version of the main Cilium components into the binary directly:
https://github.com/cilium/cilium-cli/blob/3e55a2a9c006312e63df41c4eb41baeb63a86ccc/defaults/defaults.go#L79
This means that the version will get out-of-date very easily, and even if we create a new cilium/cilium-cli release every time we do a stable branch release on cilium/cilium, if users do not update their CLI then by default they will get an older release. This is likely to include more bugs and potentially unresolved security issues.
How should we best handle pulling the latest stable release as part of cilium install?

I was considering pulling it automatically from GitHub or an API. Thoughts?

I think pulling from Github makes sense. For the Hubble CLI, we have a stable.txt file at the root that contains the version of the latest stable Hubble CLI release. It's used in the doc so that we always instruct to download the latest CLI version without having to bump it in the docs.

We now also have stable.txt on cilium/cilium, see #272 for context. Note that the 2 issues are still independent: #272 assumes we keep going with the current workflow, which is pinning each CLI release to a Cilium version.
On the other hand: #273 is related, and proposes an alternative by keeping versions pinned but notifying users of new CLI updates.


Conditional count on transitive relationship

Let's say I have these kind of models:
# integer revision
# integer state
class DocumentRevision < ActiveRecord::Base
  belongs_to :document
  enum state: [:active, :inactive, :deleted]

  counter_culture :class_type,
                  column_name: proc { |document_revision|
                    # Only count active/inactive documents if not counted
                    # before for this document
                    previous_count = document_revision.document.document_revisions.where(state: document_revision.state).count
                    if DocumentRevision.where(document: document_revision.document, state: document_revision.state).count <= 1
                      "#{document_revision.state}_count"
                    end
                  }
end

class Document < ActiveRecord::Base
  belongs_to :category
  has_many :document_revisions
  has_one :latest, class_name: "DocumentRevision"
end

class Category < ActiveRecord::Base
  has_many :products
end

What I want to do is have a count of active documents on Category, and a count of inactive documents as well. A document could have DocumentRevisions where all of them are inactive, in which case I dont want that to count. It doesnt seem like my column_name proc works here. A document should be counted as active (+1) if it has at least one active DocumentRevision, and not be counted if it doesn't have any.

Sorry—but this doesn't look like an issue with the gem and I unfortunately cannot provide support here.

It's not really an issue with the gem except the fact that if I add in a "puts" statement I can see that its being run, but nothing is actually counted. I end up with 0 counts even if I print "WILL COUNT THIS RECORD" and return a string for the column


Quash TypeError potentially raised by requests -> urllib3

Quashes an error raised by requests -> urllib3 -> stdlib:queue -> stdlib:threading where a pool may be done in a thread and therefore no object to close.
Error encountered in both Python 3.7.8 on Windows 10 and 3.7.11 on Debian 10 ( Docker: python3.7-slim).
Exception ignored in: <function RequestsAdapter.del at 0x7fd2c3fee170>
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/geopy/adapters.py", line 431, in del
File "/usr/local/lib/python3.7/site-packages/requests/sessions.py", line 747, in close
File "/usr/local/lib/python3.7/site-packages/requests/adapters.py", line 325, in close
File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 222, in clear
File "/usr/local/lib/python3.7/site-packages/urllib3/_collections.py", line 100, in clear
File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 173, in
File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 490, in close
File "/usr/local/lib/python3.7/queue.py", line 181, in get
File "/usr/local/lib/python3.7/threading.py", line 348, in notify
TypeError: 'NoneType' object is not callable

Perfect, thanks again!


V8. Don't use custom schema name in docs

Perceived Problem
It's a bit confusing to see in docs import { Pokemon } from './pokemon/__.js'
Ideas / Proposed Solution(s)
I would suggest to not use custom name  in documentation and examples in favor of default Graffle.
UPD. Seems like Graffle name already used in types, probably default name should be also changed to something.

Ok sounds good. I just need to figure out how now to break twoslash. There is already a ./graffle generated client alongside the ./pokemon one. They literally need to exist on disk for twoslash to work. But maybe I can figure something out. I had to recently disable Twoslash because of OOM issues though, so kind of doesn't matter right now...

I've got Twoslash reactivated so I'll take a stab at this soon.
https://x.com/JasonKuhrt/status/1850746262401716504


UI freeze after checking for updates of extensions

VSCode Version: 1.25
OS Version: kubuntu 18.04

Steps to Reproduce:

Open extensions view
Click check for updates

After a few seconds whole UI becomes unresponsive for 2-3 seconds. Event-thread was blocked by some network call. It would be useful to log everything that blocks main thread for more than 20 milliseconds (>16 ms feels lagging).
It seems to be a regression, appeared after 1.25

@Yanpas  Can you please get the logs (window and shared) and show me? May be enable log level to trace to get more info.

@roblourens Can you please try with 1.24v and see if you can reproduce it?

@roblourens May I also know which platform are you on?

started code with --log trace. Logs:
https://gist.github.com/Yanpas/bb04d9f7430c80767277743c2ed1ceaf
https://gist.github.com/Yanpas/ff84ffdaecb5bd0bd830521812c3da53

May I also know which platform are you on?

Kubuntu linux 18.04. Kernel 4.17.3

Do you also see the issue when you search in Market place?

Yes

When are you checking for the updates

I check manually using menu. I don't face it if I just open new window.
Here is a screencast:

@Yanpas Can you please try with out opening anything in the editor?

mac
No problem when I search
The window has been open for a while
In 1.25 I am seeing the same symptom for a very brief amount of time. The UI doesn't respond but just for less than 1s, instead of several seconds.

The trace logs after I run "check for updates":
Window:
[2018-07-12 09:43:23.522] [renderer33] [trace] RequestService#request https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery
[2018-07-12 09:43:23.523] [renderer33] [trace] RequestService#request https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery
[2018-07-12 09:43:23.591] [renderer33] [trace] RequestService#request https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery
[2018-07-12 09:43:23.685] [renderer33] [trace] RequestService#request https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery
[2018-07-12 09:43:35.242] [renderer33] [trace] CommandService#executeCommand setContext
[2018-07-12 09:43:35.244] [renderer33] [trace] CommandService#executeCommand setContext
[2018-07-12 09:43:35.244] [renderer33] [trace] CommandService#executeCommand setContext
[2018-07-12 09:43:35.244] [renderer33] [trace] CommandService#executeCommand setContext
[2018-07-12 09:43:35.244] [renderer33] [trace] CommandService#executeCommand setContext
[2018-07-12 09:43:36.979] [renderer33] [trace] CommandService#executeCommand setContext

Shared:
[2018-07-12 09:43:23.383] [sharedprocess] [trace] Started scanning user extensions
[2018-07-12 09:43:23.446] [sharedprocess] [info] Scanned user extensions: 94

Oh you asked about 1.24, I don't see it in 1.24.

@roblourens Since you are able to reproduce it, can you try it running out of dev

pointing to 1.25 extension dir
pointing to 1.25 user data dir (if possible as I am not sure this can be done)

And profile it and send me the profile?

The pause in the middle is when the UI was unresponsive. It was short this time but seems to correspond to when the network request to the gallery was happening.
Profile-20180713T090447.json.txt

Also freezes on my macos machine. vscode 1.25.1. using the reproduction steps in the initial description.

Thanks @roblourens for the profile.
Looks like extension change listeners are consuming this 1s.

This bug affects windows too

I also see this, or something similar, when I

Open the extension viewlet
Reload the window

It's really bad sometimes, here's a profile from an instance where it was blocked for 25 seconds.
Profile-20180731T141009.json.txt.zip

Other people seeing this, how many extensions do you have installed?

I have 44 (36 enabled, 8 disabled)

Looks like some of the actions are listening to changes from every extension and updating their enablement state.
Provided a fix that will let actions to listen changes from their extensions only.


The speed of the tiny model only has 35 FPS?

Hello, congratulations, nice work. I have some questions:
I use a tiny model to test an RGB tracking dataset and the final output shows only 35.04 FPS in performance.cvs
In the paper, the tiny model shows about 100 FPS.
why?
GPU:  NVIDIA TITAN RTX (24GB)

I have the same questions, and this is my testing result on RTX-A4000(16GB).

Do you have solved this problem or any ideas? Thanks advance!

我也是。。

可能是开的多线程影响，可以在单线程下进行速度测试

Hello, congratulations, nice work. I have some questions:
I use a tiny model to test an RGB tracking dataset and the final output shows only 35.04 FPS in performance.cvs In the paper, the tiny model shows about 100 FPS. why?
GPU: NVIDIA TITAN RTX (24GB)

Dear author:
I have a problem to solve,I want to use my own dataset to test the offical tiny model ,but I don't know to change code.Can you help me? Thank you very much!


--[BE] - Refactor Sensor Enum Names; Isolate Struct Templates

Motivation and Context
This small PR does a bit of cleanup on 2 fronts :

Make two sensor/scene node Enum classes' member enumeration's naming adhere to our standard practice (instead of all caps) - Note : this is in c++ only, their python bindings are unchanged.
Isolate 2 struct templates to be local to their containing file instead of in the global ESP namespace.

How Has This Been Tested
Locally tests pass

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Anonymous Namespaces are bad

Do not define an unnamed namespace in a header file. When an unnamed namespace is defined in a header file, it can lead to surprising results. Due to default internal linkage, each translation unit will define its own unique instance of members of the unnamed namespace that are ODR-used within that translation unit.

Yikes. Well, that's entertaining.


Test FinalizeKind in the new KafkaChannel

Describe the bug
KafkaChannel has no tests for FinalizeKind.
Expected behavior
Test FinalizeKind in the new KafkaChannel
Knative release version
devel
Additional context
/area control-plane
/area channel
/priority important-soon

cc @aliok

Related https://github.com/knative-sandbox/eventing-kafka-broker/issues/1798

/remove-lifecycle stale
/triage accepted
@aliok is this done?

/close
It is done.


Sink callbacks

As a new developer on SSB I learn about many workarounds as muxrpc doesn't yet support sink-callbacks. Wanting to check if the root cause could be solved rather than having multiple projects working around the limitation I only found an old issue #30 closed as stale.
Why is there less activity on this than the Stale-Bot tolerates? Is this conceptually a hard thing to implement?

I think that its mostly that no-one has tried :-)

5 buttcoins to whoever implements this! :)


Possibility to improve deletion in lru cache using swap back method?

Could you say a bit more about this? I assume it would mean to preserve the carcasses of bookkeeping data structures in an lru-with-deletion once they have been made, to avoid repeated object creation/destruction?
How big is the performance hit and is it for all use cases?

Hello @mrflip,

I assume it would mean to preserve the carcasses of bookkeeping data structures in an lru-with-deletion once they have been made, to avoid repeated object creation/destruction?

mnemonist's implementation of lru cache does not allocate nor destroy objects to work at all. But to be able to handle deletion, it relies on a stack of unused pointers as those might be unordered after a while. It has a small performance and memory impact which is why the library packs the LRUCacheWithDelete class separately so people who don't need deletions don't have to pay the cost.
This issue is a reminder to me to consider a technique I use sometimes to allow for O(1) deletion in an unordered array to see if it could replace the stack of unused pointers. The idea is that if you need to delete i.e. index 3 of an unordered array, you just need to swap its item with the one in the back, then pop it.
I have an intuition it could work for the cache's deletion but I need time to think thoroughly about it and did not find the time yet.


Handle SSBO with several types

Amber does not support more than one type. Promote bools when
feasible.

Let's close this and adapt our compute shader samples to accept Amber's limitations for now.


Could you please add S3 server access logging option to this module?

Please add logging option to this module so that users of this module can provide an s3 access logging bucket as input. It would be very useful to have since many security rules expect S3 server access logging to be setup for all S3 buckets. So anyone that has that restriction won't be able to use this module (per my understanding) and would have to manually add the server access logging through console.
So the next time, terraform plan will show this change & terraform apply it will revert the manual change back.

this module is to create such bucket. this is somewhat a chicken and egg problem, which one you create first?
if we do this we will be creating yet another bucket for logging and what will happen to that bucket, it will need a log bucket too, and so on....
CloudTrail can be used to log bucket access too so you could use that to log bucket access to the log bucket if you must


start/end_pickup_dropoff_window should be be allowed for regular stop

Is there a reason that start_pickup_dropoff_window is only allowed for locations of locations.geojson? To me it seems useful to have flexible service that have fixed stop.

+1 Would be interested in hearing the justification for this.
A current workaround, however is to use a location_group for the stop_times.stop_id entry with a single stop_id. This bypasses the limitation.

I agree. So, suggested changes:

change "Time that on-demand service becomes available in a GeoJSON location**,** location group**, or at a stop**."
instead of forbidden when there's a stop_id, maybe it should be forbidden if there is a arrival_time and departure_time.

Does that sound right?

PR open! https://github.com/MobilityData/gtfs-flex/pull/55


Support for Exoplayer 1.5.x

Updates support for ExoPlayer 1.5.x (current latest is 1.5.2 https://github.com/google/ExoPlayer/commit/97abb7abf764a745a0bdc7aef9a09a837bf1b28d)
Includes compiled ExoPlayer 1.5.2 library
Adds support for playing Ads when the overlay play button it touched
Solves https://github.com/googleads/google-media-framework-android/issues/66, https://github.com/googleads/google-media-framework-android/issues/62, and https://github.com/googleads/google-media-framework-android/issues/51

Note: Sorry I still have to include ExoPlayer 1.5.2 library or it will fail Travis. Will close the earlier pull request https://github.com/googleads/google-media-framework-android/pull/68.

Hi anggras, we know that it will fail Travis, but it will pass again once I commit the library myself, so that's OK. Unfortunately, we can't accept compiled code in pull requests. Thanks,
Yury

Alright, removed the binary ExopPlayer lib


Add freeze_with_dictionary API to MutableArrayData

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We use MutableArrayData to copy array data for certain operation. One issue we faced is for DictionaryArray on which the dictionary array value is not extended from too. Because in our usage, arrays can be reused so we cannot rely on same dictionary value array (as it is possibly modified later). We can extend dictionary value array, but  MutableArrayData lacks of an API to assign while freezing it.
Describe the solution you'd like

Add freeze_with_dictionary API to MutableArrayData.
Describe alternatives you've considered

Additional context

label_issue.py automatically added labels {'arrow'} from #2915


Drop duplicated dependencies from pom.xml

This PR addresses #362.
In particular, it does the following:

Deletes manual applying of pmd plugin, which is now applied via our pmd-settings script. It eliminates duplicated dependencies on pmd.
Pulls the latest config which contains a fix for the issue. It will hide duplicated dependencies, emitting a warning.

The library version is bumped to 2.0.0-SNAPSHOT.90.

@armiol Please, take a look.


Create ListRecordCommandTest

Codecov Report

Merging #93 (d037015) into master (ae9621c) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage     47.59%   47.72%   +0.12%
- Complexity      652      655       +3
============================================
  Files           167      167
  Lines          3183     3183
  Branches        363      363
============================================
+ Hits           1515     1519       +4
+ Misses         1579     1575       -4
  Partials         89       89

Impacted Files
Coverage Δ

...eedu/address/logic/commands/ListRecordCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9621c...d037015. Read the comment docs.


Can't change fontFamily on TextInput component

I can change the font on Text controls with a style containing the following:
{
fontFamily: "Montserrat"
},
However this same code doesn't seem to work on TextInputs.
Is this expected behaviour?

And same for centering, that doesn't seem to work either on TextInput. I'm probably doing something wrong!
Loving the rest of the framework though, it is awesome!

Could I ask how you are adding fonts?

@boyswan You need to add the font name (FileName.ttf) to the UIAppFonts key in your Info.plist.

I have the same issue with fontFamily (and fontSize for that matter) on TextInput ... They work fine on regular Text

This was an issue with RCTConvert that I fixed in c09bdebcd532bfb487763d1800aaf1f3e4d2f150 - let me know if you're still having the issue and I will reopen.

I'm having the same problem on Android.

It seems to not work for me as well on Samsung phones when you do change font style in OS settings

@gyzerok I have the same issue.

@damathryx this should be fixed in 0.42.

@gyzerok Hi, system font still overrides the app fonts in Samsung phones. I'm currently with version 0.42.

@damathryx there are to possible issues you have

You forgot to call react-native link before building your application so you simply do not have any fonts within your build.
You need to sanitise your fonts because some versions of Android are more strict about font file format.

@gyzerok
1.) I have linked my assets using rnpm link assets and on my package.json
"rnpm": {   "assets": "./assets/fonts" }
2.) Also custom fonts work but get overriden by Samsung system fonts (this is my problem)

@damathryx then I have no more solutions


build: Remove lerna and use npm workspace in build script

Summary | Résumé
Lerna has been causing an issue with build order by not building the packages in the correct order. Switch the main build script to use npm workspace build instead of Lerna to build in the proper order.

✅ Build components


Flag default switch statement condition clause as keyword

PR Summary
Flag the switch statement condition clause default token as a keyword
token to facilitate (PSReadLine) highlighting it as a keyword.  Closes #10470.
This change is to treat the default clause keyword as a full keyword token, and as such token based highlighters will see it as a keyword.
PR Context
Flagging the default condition clause token of the switch statement as a keyword will facilitate highlighting of the keyword to better contrast against other bareword string literal conditions.
A simple (partial) example:
# return simple element value (need to check for Boolean datatype, and process value accordingly)
switch ($node.Name) {
    true { $true; continue } # return a Boolean TRUE value
    false { $false; continue } # return a Boolean FALSE value
    default { $node.Value } # return the element value
}

Highlighting of the default keyword in the above example makes it easier to distinguish the special condition clause from the other bareword conditions.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

I may need guidance on tests, I have not yet ventured in to any of the tests so far.

I do not find any tests for keywords.

As for tests, it looks like, adding to test\powershell\language\parser\parsing.tests.ps1, some ParseInput expressions could be constructed to test the tokenizer results of a sample switch statement.  I am referencing the ternary operator parsing tests that @daxian-dbw added.

I rebased, and have updated the commits to reflect creating the default keyword token.  I have also included a potential test, after correcting an existing one that changed because of the error records no longer being the same.  Please provide an initial review of this approach, and if there is any other testing that should be done.

I have revised the commits again, though the bulk of changes is now in the tests.  I still have the feeling the tests are still a work in progress, though they are closer to what I was first expecting.

I'm removing the WIP prefix, as I think this is ready for review.  I am quite interested for feedback.

@daxian-dbw @JamesWTruher @adityapatwardhan Please review the PR.

@msftrncs Thanks for your contribution!


NSCA for FECG extraction

I can't separate the FECG completely from the non-invasive abdominal signals when using NSCA.Could you please provide a test demo?

Template Subtraction Methods: Investigate template subtraction-based methods which have been shown to be effective in assessing fetal heart rate through non-invasive FECG
(https://www.nature.com/articles/s41598-024-51213-5)2.
Algorithm Fine-Tuning:
Consider fine-tuning the parameters of the NSCA algorithm or exploring alternative algorithms that may offer better separation quality.
Initial marking of signals could also help in this .


Add description to Android telemetry trace events

Summary
Add description to Android telemetry trace events
Ticket Link
As requested from https://mattermost.atlassian.net/browse/MM-22107
Screenshot

@enahum is this good to merge or still blocked?

@esethna do you  see the changes applied, cause I'm not

I totally missed this PR.  I'll find time to update this PR.  Thanks for the reviews.

I totally missed this PR. I'll find time to update this PR. Thanks for the reviews.

No problem at all! Thanks for following up. LMK when it's ready for a second review. :)

Following up on this, @saturninoabril. LMK if I can help with anything. :)

ping for @saturninoabril on updating this PR ^ Thanks!

Following up on this, @saturninoabril. Let me know if I can help with anything. :)


Use of System.Drawing.Primitives ?

Hi,
What about using the System.Drawing.Primitives package ?

Hi @MaitreDede We have no plans to use the primitives within System.Drawing as we want to be able to optimize, extend and integrate the primitives within our own libraries. We've already digressed from those types.


Bug: drives missing in Files

Description
No Drives shown

Steps To Reproduce
?
Requirements
Drives should be accessible/shown?
Files Version
3.1.8
Windows Version
10.0.22621.3078
Log File
debug.log

Couple questions

When did this issue start?
Doest restarting Windows make any difference?
Is this an issue in stable?

When did this issue start?

Noticed it right after updating from 3.1.2 to 3.1.8

Doest restarting Windows make any difference?

Yes it does! They're back now 🥳

Is this an issue in stable?

Nope


Possible SpirV compilation pipeline

Ok, this is an info dump, but I think this is the ideal path forward for Fable performance and also fixes #66 .
Ideally we...

[ ] Use the @fum macro to siphon out the function bodies and create large function bodies like before the #64 update; however, we will also allow for configurable keyword arguments so we do not need to recompile the function too many times for dynamic scenes.
[ ] Compile this to SpirV using some form of compute shader (note that we want to use the graphics pipeline if possible)

Try to compile directly to a GLSL string and then compile with a GLSLangValidator.jl (or something)?
Also note that this strategy is similar to what needs to be done for oneAPI.jl: https://github.com/JuliaGPU/oneAPI.jl/blob/master/src/compiler/compilation.jl

[ ] Pass that SpirV to Vulkan(.jl)
[ ] Find a way to wrap a window library (whatever Makie / Plots use or maybe GLFW) for dynamic / realtime output.

Note that this will remove the dependencies on KernelAbstractions and any GPU vendor because we can rely on Vulkan for these steps, which would greatly reduce precompile time and hopefully speed up the process for PkgCompiler so we could make executables (games?) with this application.

Note that by switching to vulkan / spirv, we lose Enzyme AD, which could be a really important step.
Instead, it might be better to do interop for realtime visualizations:

https://github.com/ROCm/rocm-examples/tree/develop/HIP-Basic/vulkan_interop
https://github.com/NVIDIA/cuda-samples/tree/master/Samples/5_Domain_Specific/vulkanImageCUDA


Documentation does not include all SSM actions

Description
SSM API  docs and the CLI  ref include all available permissions, but the IAM  reference does not.
Affected Files
doc_source/list_awssystemsmanager.md
References
https://docs.aws.amazon.com/systems-manager/latest/APIReference/API_Operations.html
https://docs.aws.amazon.com/cli/latest/reference/ssm/index.html
Proposed Resolution
Add the following permissions to the IAM documentation:

ssm:DescribeAutomationExecutions
ssm:DescribeAutomationStepExecutions
ssm:DescribeEffectiveInstanceAssociations
ssm:DescribeInstanceAssociationsStatus
ssm:GetCommandInvocation
ssm:GetInventory
ssm:GetInventorySchema
ssm:ListDocumentVersions
ssm:ListInstanceAssociations
ssm:ListInventoryEntries
ssm:ListResourceDataSync
ssm:PutInventory
ssm:StartAssociationsOnce
ssm:UpdateAssociation
ssm:UpdateDocument
ssm:UpdateDocumentDefaultVersion
ssm:UpdateInstanceAssociationStatus

I would submit a PR but doc_source/list_awssystemsmanager.md does not contain the actions table.

The  list of actions, resources, and conditions that we publish in the IAM user guide is automated based on content from each service. Thanks for letting us know that this service includes information that is not known to IAM. I will forward this information to the service's engineering team so that they can add the missing information.


.NET Outdated

https://github.com/dotnet-outdated/dotnet-outdated
dotnet tool install --global dotnet-outdated-tool
dotnet outdated

https://github.com/marketplace/actions/dotnet-outdated-install-and-update

https://github.com/stphnwlsh/dotnet-outdated-action

    - name: Update
      id: update
      uses: stphnwlsh/dotnet-outdated-action@v2
      with:
        excludes: visualstudio


dash docs?

any luck on setting up a docset for http://kapeli.com/dash?

I don't think Emblem has enough API documentation to have a good dash setup. I might be wrong.
I'm going to close this, but obviously a way to read docs in dash would be nice.


[WIP] Revert to Alpine 3.13

I have docker 20.10.8 but still ran into a strange issue building https://github.com/forumone/RAM-Support-Wordpress-2019 where wordpress fails build because the make xdebug uses is not permitted. See https://github.com/docker-library/php/issues/1130 and https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2 though though I'm not sure the latter is totally related.
To be clear, I'm not suggesting we stick to 3.13, just want to find a better solution and hoping this isn't an omen for others. Stealing this Dockerfile fixing to PHP 7.3 and xdebug 2.9.8 allowed the build to work.

Docker snap refresh seems to have solved this.


Sheet not opening in dnd5e 3.0.0

Due to the new dnd5e 3.0.0 update the sheet doesn't render and displays an error message in the browser console:

I'm using:

Foundry v11.315
System D&D 3.0.0
MonsterBlocks 3.4.0

Same. Following and hoping someone can find the fixes. In the coming months, something like this module may become core hopefully.

Figures there would be issues in such a huge update.

CONFIG.DND5E.damageResistanceTypes just needs to be replaced with CONFIG.DND5E.damageTypes I think

Yeah, if they changed that name it would certainly explain the issue. I'll try to take a look at it after work if I get the opportunity.

Resolved via f0c7f9f2fa379b0892ccb83fb22ba0c3465e2d43. Will be included in the next update.


High CPU usage in Android app

Software Versions

Python: 3.8
OS: Android 10
Kivy: 2.0.0 (and 1.11.1)
Kivy installation method: Python for Android (p4a)

Describe the bug
I observed that my self written app uses quite a lot of CPU even if idle.  I could not find the cause in my app so I looked at the simple sample app with just one button.  Even there the cpu is used quite heavily. The problem can also be reproduced with the demo apps Kivy Showcase and KivyMD Demo in the Google App Store.
I observed the problem with top:
top -H on the showcase:
  TID USER         PR  NI VIRT  RES  SHR S[%CPU] %MEM     TIME+ THREAD          PROCESS
 4700 u0_a338      20   0 1.3G 101M  63M S 34.3   1.3   0:15.31 Thread-4        org.kivy.showcase:python

top on simple test app:
  PID USER         PR  NI VIRT  RES  SHR S[%CPU] %MEM     TIME+ ARGS
10199 u0_a163      10 -10 1.3G 102M  67M S 16.3   1.3   0:03.52 ...kivytestapp

top -H on simple test app:
  TID USER         PR  NI VIRT  RES  SHR S[%CPU] %MEM     TIME+ THREAD          PROCESS
10240 u0_a163      20   0 1.3G 102M  67M S 13.0   1.3   0:07.27 SDLThread       ...kivytestapp

I can't reproduce the problem on my Linux box.  The problem does also not exist for my service of my base app.
It seems that SDL is the culprit.  But I don't have any further insights.
Expected behavior
I would expect a CPU usage of nearly 0 if no interaction is done with the app.
To Reproduce
Download Kivy Showcase from the Google App Store and look at top.
Code and Logs and screenshots
see above
Additional context
The problem seems independent from Kivy version (2.0.0 or 1.11.1).
The Android phone used for tests is a OnePlus 6 with OxygenOS 10.3.7.
I would happily perform further tests to help analyse the situation. Any workaround is greatly appreciated.

I don't know that there's much we can do here as it seems to be specific to your system!? But I don't have device set up to test with so I'll leave open for now!?


OSC requested changes (e.g. next page) do not trigger /xremote subscribtion

Running an instance which subscribed to updates on Songbeamer changes all changes directly executed in Songbeamer - next slide are reported.
However any change triggered using an osc command do not result in replies for the change applied.
There are various issues for individual OSC endpoints not returning the response when setting a new value but this one is more general.

similar to #7


Typescript problem with types in exchange-multipart-fetch

Using
"urql": "1.10.0"
"@urql/exchange-multipart-fetch": "0.1.8"

and typescript 4.0.2 there is a compile time error when adding the multipartFetchExchange in the exchanges on `createClient':
Type 'import(/node_modules/@urql/core/dist/types/types").Exchange' is not assignable to type 'import(/node_modules/urql/node_modules/@urql/core/dist/types/types").Exchange'.
Types of parameters 'input' and 'input' are incompatible.

Type 'import(/node_modules/urql/node_modules/@urql/core/dist/types/types").ExchangeInput' is not assignable to type 'import(/node_modules/@urql/core/dist/types/types").ExchangeInput'.
Types of property 'client' are incompatible.

Type 'import(/node_modules/urql/node_modules/@urql/core/dist/types/client").Client' is not assignable to type 'import(/node_modules/@urql/core/dist/types/client").Client'.
Types have separate declarations of a private property 'createOperationContext'.

Could you try running yarn why @urql/core or list out your @urql/core versions with npm. This would imply that you have a duplicate equivalent of @urql/core floating around. The one in urql doesn't seem deduplicated judging from the error.

That was the issue.
npm ci resolved the situation.
Thanks a ultra lot @JoviDeCroock

Thank you, @JoviDeCroock ! I just ran into the same issue but with adding cacheExchange and devtoolsExchange and this saved me from a ton of req squiggles in my IDE 🎉

Hi! Can confirm this is still an issue in a yarn workspace environment.
Adding "workspaces": {     "nohoist": [       "@urql/**"     ]   }, to packages/a/package.json fixed it for now :)

@Corjen that may lead to more issues in the future 😅 I’d still instead recommend to use yarn-deduplicate or even a resolution on @urql/Core to make sure that you only have one installation of the package and one entry for it in your lock file.

Nevermind 😄 removed the nohoist property, did a reinstall and it’s working now.


Bespoke wrappers for imperative DOM APIs

Specific Demand
There's a handful of DOM properties that can only be managed imperatively. Things like the document title and the volume setting on audio elements can only be controlled imperatively, meaning you can't modify these elements in a Desktop app.
Certain things like WebGL don't make sense to provide a bespoke API over (well, maybe something like react-three-fiber), but very simple/basic things like audio tags should be easy to control declaratively.
Implement Suggestion
Audio Tags

[ ] Volume

Video Tags

[ ] Volume

cc @autarch for ideas on more DOM APIs

I'd like a way to easily call HTMLElement.focus().

I'd like a way to easily call HTMLElement.focus().

You can now do this with the onmounted event!


Dep wasmtime 20 plus printout changes

This would supersede #21. This also includes some minor changes to what can be printed out.
If they aren't to your liking, just say so. I can update this branch by rolling those commits out and just leave it with the dependency updates if that's your preference.
If you do merge something, with my or your own edits, I hope you use a squash merge.

@FrankReh would you be interested in rebasing this against the latest changes? It might be easier to close this PR and open a new one with your printout changes.

@rylev I think I'll leave this alone. Will take too long to get organized again with what's happened in the last month or two. Thanks.