Fix for vs2015. In macro CTTI_TYPE_PRETTY_FUNCTION_PREFIX was "struct…

Fix for vs2015. In macro CTTI_TYPE_PRETTY_FUNCTION_PREFIX was "struct" instead of "class", so ctti::nameof<my_class_type>() returned "lass my_class_type" instead of "class my_class_type".

The problem is that MSVC seems to use struct/class prefix depending on the type. So the only solution to this problem would be to parse the typename perfix. I've been delaying writing such parser for months...
Nice try :)


Need to GROUP BY time(...) when filtering SHOW TAG VALUES CARDINALITY by time

Bug report
System info:
InfluxDB 1.5.2 on CentOS 7
Steps to reproduce:
Try to run SHOW TAG VALUES CARDINALITY FROM "database" WITH KEY = "database" WHERE time > NOW() - 1d
Expected behavior:
The query should return the number of distinct values for tag database that have data for the last day.
Actual behavior:
The result is empty, meaning no rows are returned at all.
Additional info:
Interestingly, this works when GROUP BY time(1d):
SHOW TAG VALUES CARDINALITY FROM "database" WITH KEY = "database" WHERE time > NOW() - 1d GROUP BY time(1d)
name: database
count
-----
2
0

This is consistent with the behaviour of the rewritten query:
> SELECT count(distinct("_tagValue")) FROM "database" WHERE "_tagKey" = 'database' AND time > NOW() - 1d
> SELECT count(distinct("_tagValue")) FROM "database" WHERE "_tagKey" = 'database' AND time > NOW() - 1d GROUP BY time(1d)
name: database
time                 count
----                 -----
1970-01-01T00:00:00Z 2
2018-04-19T00:00:00Z 0

Note that GROUP BY time(1d) isn't required for SHOW TAG VALUES FROM "database" WITH KEY = "database" WHERE time > NOW() - 1d to work.

I'm also seeing some weird result with this query
`

SELECT count(distinct(_tagValue)) AS count FROM database.yearly.measurement WHERE (time > now() - 10d) AND (_tagKey = 'sometag') GROUP BY time(1d)
name: database
time                count

0                   8821
1525564800000000000 0
1525651200000000000 0
1525737600000000000 0
1525824000000000000 0
1525910400000000000 0
1525996800000000000 0
1526083200000000000 0
1526169600000000000 0
1526256000000000000 0
1526342400000000000 0

`

Facing the same issue. Any workarounds available?

This is still an issue as of Enterprise InfluxDB 1.6.4

What I did is add a field with a value of 1 to every measurement I wanted to count. Then select count(<fieldname>) from <measurement> where time > now() - 1h and <tagkey> = '<tagvalue>'. That might not work depending on what you're trying to do though.

As far as I know, this is still the case with the latest release from 1.x

Ping

Here's a workaround that might work,
https://stackoverflow.com/questions/54931888/query-tags-from-influxdb-with-respect-of-timefilter-for-grafana-variables-templa/54933003#54933003

show tag values on telegraf from vm_cpu with key = brand where time > now() - 1h.
I get  deleted values ,that mean the time filter no working .
there have some solution for the the  same  problem?

Any updates on the issue?
I'd also like to show TAG VALUES on specific time range. Query is being accepted by the Influx Server and yet I am getting an incorrect output.


Product dashboard with empty environment details

Hi,
We have configured the deploy and pipeline widgets properly. Data is coming in them as expected. But when configuring the product dashboard, the environment box are empty as per below screenshot:

The widgets view is as below:

Hygieia publish step is configured as:
hygieiaDeployPublishStep applicationName: 'hygieiaDash', artifactDirectory: '/home/jenkins/workspace/hygieia', artifactGroup: 'MY.OPS', artifactName: '*.xml', artifactVersion: '1.$BUILD_NUMBER', buildStatus: 'Success', environmentName: params.Environment
global hygieia configuration are:

Please suggest what might be missed to get the commits against the environment.

Are you publishing the artifact in the build step?

Yes @Sbrenthughes artifact is published as well
hygieiaArtifactPublishStep artifactDirectory: '/home/jenkins/workspace/hygieia', artifactGroup: 'MY.OPS', artifactName: '*.xml', artifactVersion: '1.$BUILD_NUMBER'

Let me check this and get back to you.

@neeraj2k6 , I'm having the same issue , did you find the fix?

Not yet @jjoyneriv I am still working to find the answer.
From my analysis so far, I could see the env having commits and last build artefacts under the pipelines collection in the database as soon the Jenkins plugin pushes it.
But when the API call is made to show the product dashboard from the UI, it empties the commits/last built artefact information from pipelines collection in MongoDB.
Also, the SCM information from the deployment pipeline is not getting populated for the artefact because of the below condition:
https://github.com/Hygieia/hygieia-publisher-jenkins-plugin/blob/d2b47bbd12eec2c03ad2fbab89da09fc50e41376/src/main/java/hygieia/builder/ArtifactBuilder.java#L112

@neeraj2k6 I will take a look and get back to you

Not yet @jjoyneriv I am still working to find the answer.
From my analysis so far, I could see the env having commits and last build artefacts under the pipelines collection in the database as soon the Jenkins plugin pushes it.
But when the API call is made to show the product dashboard from the UI, it empties the commits/last built artefact information from pipelines collection in MongoDB.
Also, the SCM information from the deployment pipeline is not getting populated for the artefact because of the below condition:
https://github.com/Hygieia/hygieia-publisher-jenkins-plugin/blob/d2b47bbd12eec2c03ad2fbab89da09fc50e41376/src/main/java/hygieia/builder/ArtifactBuilder.java#L112

Are you using a pipeline job in Jenkins?

@rvema , Yes we are using a pipeline job in Jenkins

`pipeline {
agent { label 'jenkins-dind-ops' }
environment {
builddocker = true
}
parameters {
choice(name: 'Environment', choices: "Dev\nSit\nCTC\nProd", description: 'Specify the environment for which hygieia need to be created/updated')
}
stages {
stage('PipelineStageBuild') {
steps {
checkout scm
            hygieiaArtifactPublishStep artifactDirectory: '/home/jenkins/workspace/hygieia', artifactGroup: 'MY.OPS', \
            artifactName: '*.yml', artifactVersion: '0.0.4'

            hygieiaDeployPublishStep applicationName: 'hygieiaDash', artifactDirectory: '/home/jenkins/workspace/hygieia', \
            artifactGroup: 'MY.OPS', artifactName: '*.yml', artifactVersion: '0.0.4', buildStatus: 'Success', \
            environmentName: "Dev"

        }
    }
}

}`
This is the jenkins file I have created for the pipeline. This does populate the pipeline widgets properly but when I create a product dashboard using this team dashboard. the deployment stages are empty as per the screenshot I posted originally.

@neeraj2k6 I will take a look and respond back.


Preparing for pushing to PyPI

Updates the setup.py with proper classifiers, url, etc.
The readme points to PyPI for installation
Added copyright and license details to all source files (still need to update examples)

Coverage remained the same at 86.508% when pulling acc23a744458823e4efb2b2f50db50bf1a3ceaf8 on cash:pypi into 8e574f3084437cc5a4dd706d147bf695c26ad9db on ACI-ESP:master.


Not using Responders::HttpCacheResponder

Hi there, I think:
include Responders::HttpCacheResponder
is to blame for the weird caching errors I'm seeing. Basically the contents of index and show views are cached (including flash messages) until I forcefully fetch the page again.
How would I go about overriding this?

We hit the same error and it surprised us, too :cry: . We removed the HttpCacheResponder in our Controllers and it worked again.

@bitboxer maybe we should just remove it from the default controller. Mind to open a PR?

Sure. PR opened.

Lol, I forgot all about this :)

@brendon sorry to bring this back to your memory :wink:

It's all good :) I abandoned the project I was inherited_resources for, but I have fond memories of using it otherwise.


optimize command line tool for speedup

The command line tool can be slow to operate for simple tasks like editing a parameter file. A task like printing a parameter using the par command may take up to a few seconds (~8s on a Chinook login node) when it should likely take less than a few tenths of a second to do the underlying tasks (scan and check a text file).
This is likely because we are importing a large chunk of the SeisFlows package (and its dependencies) each time we call SeisFlows from the command line, which is unnecessary for the simple tasks.
The proposed task here is to optimize the command line tool for speed. One potential approache would be to shuffle import statements/import on the fly rather than doing a general full-package import at the top of the file.
This should help cut down on task time for the simpler commands at the cost of slightly less formal code structure. The end result is a command line tool that is useful and fast.

Heavy package imports (ObsPy, Matplotlib) have been removed or shifted off the main command line tool script for speedup. commands like seisflows par have gone from multiple seconds to tenths of a second. Could be further optimized but for now this is much better


Nikolai/fix/tags

Merge this after my last PR
Tags work now.

Also added a tag delete button in. The XML is bad and should be redone (button overlaps text on some screens).


Custom command not working

When I try to send custom command to camera nothing seems to happen; I'm sending in the 8x xx xx xx xx xx format, tried different commands but nothing is happening. I'm especially interested in the camera on and off function since they are not yet included in the file.

I try to send custom command and it doesn't work either


Suggested readability edits to introduction

Using Hemingway I've had a go at using simpler language in the introduction. Please check if the suggested content is still accurate! If so I'll make a pull request. This is part of progressing issue #111 - I'm open to recommendations for all of these.
Current content
Introduction, definition, and history of web accessibility overlays
(Summary) Overlays are a broad term for technologies aimed at improving the accessibility of a website by applying third-party source code (typically JavaScript) to make improvements to the front-end code of the website.
Website add-on products purporting to improve accessibility go back to the late 1990s with products like Readspeaker and Browsealoud. Both of which added text-to-speech capabilities to the website(s) on which they were installed.
Later, similar products came to market that added additional tools to their software that allow user-based control of things like font-sizes and changes to the web pages colors so that contrast is improved. Products like Userway, EqualWeb, AudioEye, User1st, MaxAccess, and accessiBe fall into this category. These products are sometimes also white labelled under additional names.
Suggested content
What is an accessibility overlay?
(Summary) Overlays are a broad term for technologies which aim to improve the accessibility of a website. They apply third-party source code (usually JavaScript) to make improvements to the front-end code of the site.
Website add-on products claiming to improve accessibility go back to the late 1990s with products like Readspeaker and Browsealoud. They added text-to-speech capabilities to the website(s) on which they were installed.
Then similar products came to market that added more tools to their software. These allow user-based control of things like font-sizes and colors to improve readability.
Some newer overlay products aim to fix any problems in the site's code that are preventing assistive technology from being used easily. They apply a script to the page which scans the code and automatically attempts to repair the problem.
Products like Userway, EqualWeb, AudioEye, User1st, MaxAccess, and accessiBe are known as accessibility overlays. These products are sometimes white labelled under other names.

@stringyland I apologize for letting this rot, but can you issues a PR with the changes you propose?

@karlgroves hah, I meant to follow it up too! I'll send some PRs on the weekend for you to review at your leisure :)

With the PR merged, can this issue be closed?


Proof presentation with constraint filters not working as expected

Integer number
I tested number constraints inside the proof requests and It doesn't work as expected. In the process the verifier agent throws an error:
aries_cloudagent.protocols.present_proof.dif.pres_exch_handler.DIFPresExchError: Constraint specified for citizenship_input_1 does not apply to the enclosed credential in $.verifiableCredential[0]

The problem is that the expected credential value type in the proof presentation is number, but in reality, It is an object:
{
    "type": "xsd:integer",
    "@value": "10"
}

Reproduction steps:

Add "lprNumber": 10 property to credentialSubject object
Change path of first field contraint in the proof request to  "path":["$.credentialSubject.lprNumber"]
Set as filter:

 "filter": {
    "minimum": 3,
    "type": "number",
}

Run Alice and Faber

./run_demo faber --did-exchange --cred-type json-ld --wallet-type askar
./run_demo alice --wallet-type askar

Issue credential and create proof request
Observe the issue

Float number
There is another issue with float numbers. It is different than the integer issue because the holder can not even create a proof presentation. Error:
 TypeError: must be real number, not str

Reproduction steps:

Add "lprNumber": 10.2 property to credentialSubject object
Everything else same as reproducing Integer issue

Value Range
Range constraints are not supported since else if is used instead of ifs
An example use case of range validation is that the user needs to be between 18 and 21 years old. Can we allow range predicates?

Regarding Integer number issue, this should be fixed in PR#1430.

Regarding **Float number ** issue, this error (must be real number, not str) is triggered when deriving the credential. I tested the reveal_doc in JSON-Playground and it seems to be correct. I will raise an issue regarding this.

Regarding range validation. It works if we specify the same paths multiple times with a different filter. Is that the intended use?

This is the intended use. From your use case, so as to ensure that age is between 18 and 21, you will need to specify 2 fields on the same path, ["$.credentialSubject.age] with minimum filter as 18 and maximum filter as 21 respectively.

oneOf filter has been implemented in PR#1430 and it follows this structure (list of lists):

"schema": {
 "oneOf":[
    [
      {
          "uri": "https://example.com/passport#passport"
      }
    ],
    [
      {
          "uri": "https://example.com/drivers-license#drivers-license"
      },
      {
          "uri": "https://www.w3.org/2018/credentials#VerifiableCredential"
      }
    ]
]

Thanks, this sounds good. Yes Ideally all credentials that match one of the schemas would be returned, so that the holder has the ability to decide which one to use (the order should not matter).
What about the issue I described here. Is the validation that the credential's schema in proof presentation matches the schema defined in the proof request also added on the verifier side also by PR #1430?

What about the issue I described here. Is the validation that the credential's schema in proof presentation matches the schema defined in the proof request on the verifier side also added by PR #1430?

I wasn't able to replicate this issue, schema filtering is working as expected. For me with "uri": "https://w3id.org/test#test" the presentation includes no credential.

That's true, but if Aca-py is slightly modified on the holder side, in order to send the credential inside proof presentation even though schema doesn't match. The validator agent will not notice that. We cant assume that all agents will be harmless.
I prepared an example: https://github.com/acuderman/aries-cloudagent-python/pull/3/files
When the demo is run (Alice and Faber), the proof is still valid even thought It shouldn't be since schemas don't match.

That's true, but if Aca-py is slightly modified on the holder side, in order to send the credential inside proof presentation even though schema doesn't match. The validator agent will not notice that. We cant assume that all agents will be harmless.

This should be addressed now in PR #1430.

@shaangill025 Thanks! Went through the cases and looks good.
Would It also make sense that a problem report is created in case that the Verifier throws: DIFPresExchError?

2. Regarding **Float number ** issue, this error (must be real number, not str) is triggered when deriving the credential. I tested the reveal_doc in JSON-Playground and it seems to be correct. I will raise an issue regarding this.

Hello @shaangill025,
was this issue raised? If yes could you please provide the issue number, so we can track it.
Thank you!


feat:change favicon

if you accept this I will make a new pull request to create OG tags

the change is to small, so i cant accept it. i wil create issues for OG Tags


Bump Dependencies #11368413149

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/11368413149

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Completed Chapter 8

Hi there,
Finally, I completed the Chapter 8 (Neural Network).  It took longer than expected...
FYI. To complete this chapter, I created a small utility function to load binary word2vec files, which is now uploaded on File Exchange.
Regards,
Toru

Awesome!! Thanks for your hard work.


Fix named pipes path and use better locations for cache, config, data, and runtime directories

Summary

This PR fixes the path that's used for named pipes on Windows, which is what we use for IPC communication between the CLI and a running server. Named pipes aren't supported on file descriptors which I didn't realize until I carefully read the docs. This will address #1017.
I also took the liberty of improving the locations of the various directories we use, making them align more with their appropriate operating system location. Where possible we always use the value derived from the XDG environment variables, regardless of operating system. See inline comments for additional references and explanation.
Cache
XDG/Linux: ~/.cache/rome
Windows: ~/AppData/Local/Temp/Rome
Mac: ~/Library/Caches/Rome
Config
XDG/Linux: ~/.config/rome
Windows: ~/AppData/Local/Rome/Config
Mac: ~/Library/Preferences/Rome
Data
XDG/Linux: ~/.local/share/rome
Windows: ~/AppData/Local/Rome/Data
Mac: ~/Library/Rome
Runtime
XDG/Linux: /run/user/$(id -u)
Windows: $TEMP/rome
Mac: $TEMP/rome
Test Plan

Manually tested on different platforms.

Might be a good idea to eventually make these more abstract and unit test them with different variables but would require a significant amount of boilerplate to do so.

I'll open an issue to track this


Zheyichn/746 rake icon contrast fix

Solution

Modified Rake icon component to make it more visible (color : white) in WHCM.
Applied inline styling within the component to achieve the goal, as the styling of rake-icon is not used by anywhere else.

Screenshots:
Dark Mode

Light Mode:

Closes #746

Hi @CodeWritingCow, pls review when you get a second. Thank you.


sdm does not work if called from a symlink

$ sudo ln -s /usr/local/sdm/sdm /usr/bin/sdm
$ sudo sdm
/usr/bin/sdm: line 606: /usr/bin/sdm-cparse: No such file or directory
/usr/bin/sdm: line 607: iswsl: command not found
? No command specified (--aptmaint --burn, --customize, --explore, --mount)

This issue originates in sdm line 605: src=$(dirname $0) can be replaced by e.g. src=$(dirname "$(realpath "$0")").

Thanks for reporting this. I'll get it into the next update.

I'm nearly done with the next update and have fixed this, and I have updated EZsdmInstaller to add the link into /usr/local/bin

This edit is in V7.0. Thanks again for your suggestion!


Validate languageCode in API

We use languageCode argument in various queries and mutations. We should add some validation that will check if the provided code is supported by Saleor i.e. is present in LANGUAGES list in Django settings.
E.g. this should return an error:
mutation {
  productTranslate(id: "UHJvZHVjdDo3Mg==", languageCode: "asd", input: {}) {
    errors {
      field
      message
    }
    product {
      name
    }
  }
}

Since the list of possible languages is predetermined, wouldn't it make sense to make this an enum?

Yep, that's even better.


Basic Authentication

It doesn't seem that wiremock supports Basic Authentication. If that is true, is there any plans for support? Should I start mucking around with the code?
Currently I get a 400 from the Wiremock server when I execute:
String encoding = Base64.encodeBase64String((userName + ":" + password).getBytes());
DefaultHttpClient httpClient = new DefaultHttpClient();
HttpPost httpPost = new HttpPost(protocol + "://" + host + ":" + port + path + merchantId + "/credentials");
httpPost.setHeader("Authorization", "Basic " + encoding);
try {
    HttpResponse response = httpClient.execute(httpPost);

+1
I'm also looking for a way to test HTTP(S) Basic Authentication for a Jersey Client:
  ClientConfig clientConfig = new ClientConfig();
  clientConfig.register(HttpAuthenticationFeature.basic(someUserName, somePassword));
  Client client = ClientBuilder.newClient(clientConfig);

If all you're wanting to do is check that the client sends an appropriate basic auth header, you could just verify the header directly e.g.
verify(getRequestedFor(urlEqualTo("/your-url"))
  withHeader("Authorization", equalTo("Basic <base64 encoded user:pass>"))

It would be nice if there was a more convenient way to do the authorization header verification.

Ideally, it should support auth scheme negociation as described in §2 Basic Authentication with the API of http://www.baeldung.com/httpclient-4-basic-authentication
Even if in the end, it can only mock basic auth

I'd certainly like to make this easier, although it's possible to do pre-emptive now in the 2.0 beta (and from there, mock out the whole interaction).

I was able to add a test for basic auth using a custom transformer.
Has any thought been given to including some transformers with Wiremock?
(Or should someone start an extensions project?)

@mrdanpsmith - I presume you mean a negotiated auth handshake via a transformer?
If so, it'd be great to get that as a PR. I like the idea of having it as an extension but in the core codebase so it can be activated just when needed.

@tomakehurst - Yes, that is what I'm talking about.
It's good to know that you would consider adding that to the main project.
I'll see if I can find some time to put a PR together.

Yes, there's pre-emptive basic auth in 2.x already, but not negotiated.
And yes, 1.x is frozen now.

Closing this as it's inactive. I'd still be happy to accept an extension supporting negotiated auth.


[BUG] failed to build for wayland (gtk-layer-shell-sys)

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
build logs:
 ~/g/g/e/eww   v0.4.0    cargo --version
cargo 1.65.0-nightly (6da726708 2022-08-23)
 ~/g/g/e/eww   v0.4.0    cargo build --release --no-default-features --features=wayland
   Compiling gobject-sys v0.15.10
   Compiling cairo-sys-rs v0.15.1
   Compiling gtk-layer-shell-sys v0.4.1
   Compiling simplexpr v0.1.0 (/home/reese/git/github.com/elkowar/eww/crates/simplexpr)
   Compiling grass v0.11.2
The following warnings were emitted during compilation:

warning: `"pkg-config" "--libs" "--cflags" "gtk-layer-shell-0" "gtk-layer-shell-0 >= 0.1"` did not exit successfully: exit status: 1

error: failed to run custom build command for `gtk-layer-shell-sys v0.4.1`

Caused by:
  process didn't exit successfully: `/home/reese/git/github.com/elkowar/eww/target/release/build/gtk-layer-shell-sys-2f01a473a6c02e2b/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=GTK_LAYER_SHELL_0_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:warning=`"pkg-config" "--libs" "--cflags" "gtk-layer-shell-0" "gtk-layer-shell-0 >= 0.1"` did not exit successfully: exit status: 1
  error: could not find system library 'gtk-layer-shell-0' required by the 'gtk-layer-shell-sys' crate

  --- stderr
  Package gtk-layer-shell-0 was not found in the pkg-config search path.
  Perhaps you should add the directory containing `gtk-layer-shell-0.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'gtk-layer-shell-0', required by 'virtual:world', not found
  Package 'gtk-layer-shell-0', required by 'virtual:world', not found

warning: build failed, waiting for other jobs to finish...
 101  ~/g/g/e/eww   v0.4.0   

The same happens when I try to install eww-wayland-git from the AUR.
Reproducing the issue
No response
Expected behaviour
It should build without errors.
Additional context
I am:

on Endeavour OS (Arch-based rolling) with the latest updates
using sway 1:1.7-9
using cargo 1.65.0-nightly (6da726708 2022-08-23) to build.
building eww at tagged version v0.4.0

eww builds for X11 successfully on this same setup.
I realize this may not be an issue with eww itself, but I'd at least like some help figuring out what's going wrong here. I'm not a Rust person by any means so my debugging skills are limited here.

Oops, never mind. All I had to do was install gtk-layer-shell with pacman and it built successfully.


Allow for flavour text

Would it be possible to allow any text that comes after the die rolls to be copied into the result?
Ex.:
User: /r 1d20+7 intiative roll
Sidekick: @User: `1d20+7` = (14)+7 = 21 `initiative roll`

It's but a convenience, but a really convenient one.

I did this initially but then reconsidered. There's a lot of dice systems out there besides D&D and the syntax might be quite unpredictable for all I know. Here's an example from just a day before: https://github.com/ArtemGr/Sidekick/issues/37#issuecomment-292737618. I'd like a clear separation between the comment and the expression proper in order not to be dancing around guessing whether something is an expression or a comment.
What you might try to do instead is memorize your initiative roll with "/r $initiative = 1d20+7".
Rolling "/r $initiative" is both descriptive and faster.

What I'd rather do is the "/r $initiative all" syntax. It will get the stored initiative rolls of all the active players on the channel, roll them and print a sorted list. How does that sound?

Hmn, Roll20 has the syntax to just display any text, or even display inline dice rolls. I was just so used to that system that it took me much too long to figure out why I was getting errors all the time. (I love the error messages, though.)
The most important thing, at any rate, is to make clear what the roll was for. If I type "rolling spot check", and then two other people talk while I finish writing up "/roll 1d20 + 7" and press enter, then the GM has to process which roll was for what again. It's a little bit messy; adding what a roll was for in the bot response makes it a lot cleaner.
We can do without, obviously, but its minor inconveniences adding up all the time.
In my own simple python bot, I checked for the character | and printed out anything that came after as plain text. It's not as sexy, but it works.

In my own simple python bot, I checked for the character | and printed out anything that came after as plain text. It's not as sexy, but it works.

How is that different from "#" used by Sidekick?

It...  isn't D: sorry for the confusion, that was just to make sure I explained the 'print text'-thing correctly. I could've used # as an example too. It was more to convey that $initiative isn't quite what I'm looking for.
If it's too much effort for too little gain, don't worry about it!

It's not just the effort, it's that treating the non-parsable parts of the expression as comments will make the bot's behaviour flacky and unpredictable. I see a lot of typos in the bot. People would mistype the roll modifiers and get an error. If we treat anything we can't parse as comments, then they'll get a wrong roll instead. I think that getting a wrong roll, where we misinterpreted a part of the expression as a comment, will be much more confusing than an explicit error.
So I really don't think that treating just about anything as a comment is a right way to go for the bot's default behaviour.
On the other hand, it's possible to implement a tunable configuration that on a particular channel would switch the bot into a simpler D&D only mode or something, were the syntax is fixed and anything else can be treated as comments. I think I will consider this with enough support from the backers.
Thanks for your input. I'm glad we shed some light on the subject.


Provide the transformation as a helper function?

Hello,
One question, will it be possible to provide the transform of markdown to bbcode as a helper function? That way we can use only the code of the transform and not need the full component if not needed?
Thanks,
Jaume.

By pasting the MarkdownLabel control:
var mdlabel = get_tree().get_root().get_child(0).get_node("MarkdownLabel")

Alternatively, without pasting the control:
var mdlabel = preload("res://addons/markdownlabel/markdownlabel.gd").new()

This way, you can access the MarkdownLabel class.
It seems that you can convert a markdown string to a BBCode string by calling the mdlabel._convert_markdown method.
Thanks to the GDScript language specification.

Closing this since direct conversion is not the purpose of this addon. It can be easily achieved by instancing the class as explained in the previous comment though :)


Libraries that use Symbol properties on builtin prototypes break in Jest

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Libraries that add Symbols to builtins like Object.prototype and Array.prototype for unique, anonymous properties break using Jest.
If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.
demonstration of the problem
What is the expected behavior?
Symbol properties can be added to builtin prototypes. This works IRL in node, browser, and other testing frameworks.
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
$ node --version
v8.5.0
$ yarn test --version                                                                   ⏎
yarn test v1.0.2
$ jest "--version"
v21.2.1
✨  Done in 0.26s.
$ uname -a
Darwin 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64

Wish it would jest work! 👯👏😂👍

Jest tests run in JSDOM. JSDOM uses Node.js VM to run tests in isolation with window object. Unfortunately, modules imported by require run in original node context. So, funcadelic works as expected by the typeclass implementations are added to Node context rather than VM context.

I created a test-setup.js file and added it to jest with
  "jest": {
    "testRegex": "(/tests/.*|\\.(test|spec))\\.(js)$",
    "setupTestFrameworkScriptFile": "<rootDir>/test-setup.js"
  }

Inside of test-setup.js, I'm calling require but it's still running in original node's context not VM's context. The require inside of VM is a wrapper provided by jest-mock library. It seems that this library might be bound incorrectly to node instance rather than the VM instance.

Is there a workaround for this? I.e. to direct jest to say which modules should be run in the VM context?

good times!


confidence interval of the scipy.optim.minimize results

Hi,
I've been trying to implement a least-squares fit using 'Nelder-Mead' method for minimizing the residual. The minimization works well. But the thing is, I don't have any idea of how to extract the variance and confidence interval for the parameters optimized. The OptimizeResult of this minimization gives a variable called final_simplex, which takes the form of (array_like of shape (N + 1, N), and array_like of shape(N+1, )) which I don't have a good idea to use.
Any idea about this? This would be very helpful.
Best,
Eunjong

I found that I can use the version in
https://github.com/andsor/notebooks/blob/master/src/nelder-mead.md
to do what I want. But, I don't understand why the scipy version is implemented this way? Would there be a specific reason?

I think there are probably more accurate ways of estimating parameter uncertainties than fitting a quadratic surface around the minimum. It would be a general benefit to optimize if there was a method for estimating parameter uncertainties for a generalised f/x system.

The uncertainty calculation as written is also not generic to any problem size, and will increase the number of function evaluations. It may be worth emailing the scipy-dev mailing list to see if there is general appetite for the error estimation as outlined in the paper.

I don't know of a generic way of defining and estimating uncertainties in parameters that would work for general optimization problems.
All cases I know, are in the specific context of a statistical optimization problem, like least squares, maximum likelihood or M-estimators.
What's the uncertainty in argmin(x**2) ?
(aside: in statsmodels we use the inverse Hessian of the optimization problem for MLE which we compute separately and not during optimization with scipy optimizers.)


Add for readability: equals, eqls

This is just an itch. Helpful for lines like:
({a: 1}).should.have.property('a').which.equals(1);
Happy to add unit tests, didn't see any for .exactly() alias so skipped (no need to test that aliasing works).

:+1:


Add the missing Dockerfile.bundle

Required to build the OLM bundle image.
Signed-off-by: Tomash Sidei<EMAIL_ADDRESS>

So the end-to-end tests are not just failing in my branch 🤷

The failing test was because the Kubernetes node was not ready (container network didn't start properly) so the pod couldn't be scheduled. Not sure what caused that but an upgrade of kind action, kind itself and node images to the latest helped.
Also upgraded controller tools and regenerated the CRD.


Facilitate local unit tests

While doing some changes to go-ovn I wanted to have a quick and isolated way to run the go-ovn unit tests (instead of relying on travis or having to do a lot of preliminary setup). So I ended up reusing the travis scripts to have a container-isolated local Makefile.
The result is that, running make check will build a container (only the first time you run it) and run the unit tests using the same scripts travis.
Sending this PR as a request for comments. Is something like this considered useful?

Thanks @amorenoz .  Yes, this is looks very reasonable and useful. What's the work pending (I am asking since it is marked as RFC)?

@hzhou8 I marked as RFC because I was not sure if it would be considered useful. If it is, I think it's ready for review

LGTM

LGTM

LGTM now except the minor typo. @amorenoz let me know you want to push once again. Thanks a lot.
@vtolstov would you take a look?

LGTM now except the minor typo. @amorenoz let me know you want to push once again. Thanks a lot.
@vtolstov would you take a look?

ok for me, minor typos in wording

ok for me, minor typos in wording

@amorenoz if I wanted to execute 'go test -v ./...' or run a single test such as 'go test -run TestLogicalRouterPort' (refer https://github.com/eBay/go-ovn/blob/master/logical_router_port_test.go#L10), how would I be able to do that? Thanks

@amorenoz if I wanted to execute 'go test -v ./...' or run a single test such as 'go test -run TestLogicalRouterPort' (refer https://github.com/eBay/go-ovn/blob/master/logical_router_port_test.go#L10), how would I be able to do that? Thanks

@amorenoz if I wanted to execute 'go test -v ./...' or run a single test such as 'go test -run TestLogicalRouterPort' (refer https://github.com/eBay/go-ovn/blob/master/logical_router_port_test.go#L10), how would I be able to do that? Thanks

@vjayaramrh I think the test_run.sh script can be further improved to provide an option to run a specific test case. With this we can use "docker run ... sh" to start the container and execute the test_run.sh script for specific test cases.
I will merge this PR now since it would already provide lots of conveniences. More improvements are welcome :)

@amorenoz if I wanted to execute 'go test -v ./...' or run a single test such as 'go test -run TestLogicalRouterPort' (refer https://github.com/eBay/go-ovn/blob/master/logical_router_port_test.go#L10), how would I be able to do that? Thanks

@vjayaramrh I think the test_run.sh script can be further improved to provide an option to run a specific test case. With this we can use "docker run ... sh" to start the container and execute the test_run.sh script for specific test cases.
I will merge this PR now since it would already provide lots of conveniences. More improvements are welcome :)

@vjayaramrh, although it's possible to run your own "docker run" command, we could make it easier by adding an option, like @hzhou8 mentions, or even my documenting that process. WDYT?

@vjayaramrh, although it's possible to run your own "docker run" command, we could make it easier by adding an option, like @hzhou8 mentions, or even my documenting that process. WDYT?


Move private repo into this one

Currently all work is done on a private repo, why not move it over here @SeanHealy33

will this ever be done?

private repo migrated


Default implementation

Hey there, I think it would be beneficial to add a "Default" trait implementation for "Version" and maybe "VersionReq" structs.
Should there be any complications in the process?
Thanks!

This could be easy made I think. But whats the benefit of such?

Oh, that was a pretty long time ago. I think it is related to Version being serializable, which, as far as I remember, requires the data type to have an implementation of default. Moreover, I think it's beneficial to have Default implemented for any kind of data type to allow users to just use Default::default() on initializing complex data structures!

I think it might be a good idea to fall back to something like "0.0.0" as the default for Version and "no requirements" for the VersionReq if the last is possible.

There are multiple benefits, for example when initializing the Version struct with existing version numbers:
let major = 1;
let minor = 120;
let version = Version {
    major,
    minor,
    ..Default::default()
};

Another issue is if you have a type which requires a default implementation in order to be statically safe, then you can't use Version inside of it without using Option:
#[derive(Default)]
struct App {
    version: Version,
}

Would someone be able to point out some concrete real-world code in which this Default impl would be beneficial, and how that code is currently working around it?

I've closed the issue because my impression is this isn't needed, but anyone should feel free to follow up if they can provide a compelling use case in real-world code (with a link to real code).


"get_source_from_cvepatch.py" file has an error

In the get_source_from_cvepatch python file, there is an error.
(#line 175 to 205)
        for f in hitOldFunctionList:
            for num in range(f.lines[0], f.lines[1]+1):
                try:
                    listIndex = lnList.index(num)
                except ValueError:
                    pass
                else:
                    if lnList.count(num) > 1:
                        listIndex += 1
                    if pmList[listIndex] == '+' or pmList[listIndex] == '-':
                        flag = 0
                        for commentKeyword in ["/*", "*/", "//", "*"]:
                            if chunkLines[listIndex][1:].lstrip().startswith(commentKeyword):
                                flag = 1
                                break
                        if flag:
                            pass
                        else:
                            finalOldFunctionList.append(f)
                            break
                    else:
                        pass

diff --git a/contrib/libarchive/libarchive/archive_ppmd7.c b/contrib/libarchive/libarchive/archive_ppmd7.c
index fe0b031..1aed922 100644
--- a/contrib/libarchive/libarchive/archive_ppmd7.c
+++ b/contrib/libarchive/libarchive/archive_ppmd7.c
@@ -126,6 +126,11 @@ static Bool Ppmd7_Alloc(CPpmd7 *p, UInt32 size, ISzAlloc *alloc)
 {
   if (p->Base == 0 || p->Size != size)
   {
+    /* RestartModel() below assumes that p->Size >= UNIT_SIZE
+       (see the calculation of m->MinContext). */
+    if (size < UNIT_SIZE) {
+      return False;
+    }
     Ppmd7_Free(p, alloc);
     p->AlignOffset =
       #ifdef PPMD_32BIT

In this diff-chunk case, the first line of '+' set is started with "/*", so the flag value change to the 1,
pass, and go to the for loop.
Next, we have to check the second line of '+' set, however, we skip all the '+' lines.........
So, like this case, If the first line of '+' (or '-') set is started with Comment Line, our python code file cannot find vulnerable function.

The file has been moved to another project, and patched.
See https://github.com/squizz617/vulnDBGen


Update on IdP or SP initiated mode setting

For SP Initiated mode, the URL will be uniquely generated for each clients.
and add missing information about IdP initiated mode configuration.

@ibisworld-jp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ibisworld-jp we have pushed these changes into our private repo. The changes will be available once the PR merged.
#please-close

Hello, I can see that the updated content hasn't show up.
How long normally the merge to happen?
Thanks,
-Joel-


Upgrade ZIO HTTP to 3.0.0-RC3 accounting for the new API

With the new richer API, I was able to delete Span Namer 😸


⚠ SceneTime has degraded performance

In 2f0e7ab, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3932 ms

Resolved: SceneTime performance has improved in 151c16d.


[WIP] Measurements_from_sample transform

Before submitting
Please complete the following checklist when submitting a PR:

[ ] All new functions and code must be clearly commented and documented.

[ ] Ensure that code is properly formatted by running make format.
The latest version of black and clang-format-14 are used in CI/CD to check formatting.

[ ] All new features must include a unit test.
Integration and frontend tests should be added to frontend/test,
Quantum dialect and MLIR tests should be added to mlir/test, and
Runtime tests should be added to runtime/tests.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

[sc-60183]

The final CodeFactor issue is complaining about the test file being too long - seems like a reasonable complaint, but I didn't want to make the diff confusing in terms of which tests are being changed or added vs just moved, so I have that in a separate PR here


The select drop-down box has no options

I found that there are no options in some drop-down boxes, how to set this?

You need to create a "bean" first

thank you.Is there a detailed operating manual?


Propose go.mod

Propose go.mod and go.sum.
This is hard from a fork, but that should be OK.
In any case, examples are not separated in several directories, so that avoid the go.sum to be cleaned.
This fixes the version of dependencies.

FYI, something along these lines has been integrated into "my" fork of gg:

https://sr.ht/~sbinet/gg/


Camperbot doesn't recognize corrected bonfire's title.

I have noticed some time ago that there were changes in "Falsy bouncer" bonfire, it was named "Falsey bouncer" before.
Now people can't find these bonfire using command: bf falsy bouncer.
Changes in @camperbot code have to be made.

I think I know how to do it, so I will prepare code and make PR.


临时字典文件能修改目录吗

默认全都放在/tmp下，都爆了

The project was rewritten, and the new version can be downloaded from the release page. Please check if the issue is still there.
Please note: there are settings required to be added to module-info.java. Refer to README.MD.


Before final release: delete roundedness from diacritics

Following my remark, we need to delete the two lines here, namely those where "roundedness" is a feature. Since the symbols are the same, they are not treated anyway, and we usually do not allow that a base feature of a sound class (vowel's base features are roundedness, height, centrality) is modified, unless we put the diacritic explicitly in the vowels.tsv.

The problem here is that people use these diacritics in a confusing way, sometimes to go from unrounded to rounded when there is no base glyph for the second one (like for æ), sometimes to indicate labialization of consonants, sometimes to distinguish among plain, compressed, and protruded...
But I agree with you, using the diacritics only for what is now feature rounding makes sense. I can take of this, and while I am at it I can add that normalization we know it is missing. What are Robert's plan on releasing?

I mean: for our case, there's no problem, just a rule: the line is AMBIGUOUS now, can't be parsed, so delete it, and stick to the rule that says: diacritics can't override base features, instead put base sound + diacritic into the vowel.tsv or consonant.tsv. Full stop. Nothing to change. Keep less rounded etc. for the original usage: it means "less rounded" in ipa charts, nothing more.

Ok, that's easy. But as a side-note, as I pointed in the PR, the rule of diacritics not overriding base features clashes with IPA usage of linguo-labials (this is a stupid problem of the IPA, but unfortunately is what we have).

Examples, please, I don't know what that is, sorry.

You can see at the bottom of the official table (it is confusing as hell, because it is not a normal row/column table, there are some heavier edges) that the IPA accepts linguo-labialitiy as a primary articulation, but the only to express it is with the seagull diacritic: https://upload.wikimedia.org/wikipedia/commons/9/94/Extended_IPA_chart_2005.png
This is more clear in the Wikipedia page on the IPA: https://en.wikipedia.org/wiki/International_Phonetic_Alphabet#Pulmonic_consonants
Now, linguolabiality is indeed an unusual feature, but the point is that the IPA accepts its existence without allowing to express it with primary graphemes. This is probably due to the dispute of phoneticists on whether it is a modified coronal or a modified bilabial (as in theory you can express it with the apical diacritic too).

This is no problem, as I mentioned: if you have things that can only be expressed by a sound + diacritic, you HAVE to place them in vowels.tsv or consonantst.tsv, no deal, but you can't take the shortcut via diacritics.tsv. That's all I meant. So there should not be a diacritic in diacritics.tsv that says "linguo-labial".

Ok, but this means that we need to all the potential linguo-labials by hand. My issue was that I was adding the "accepted" ones, but I didn't want people complaining "oh, you don't allow me to express this speech disorder that is, who know, a linguolabial lateral affricate".
I'll add those which are are listed in WIkipedia, which is good enough for the time being and, of course, gives more coverage of the wikipedia set.

I don't really care how much we add, etc., but it is what I did when making the first real bulk of clts, and this is the only way to do it, and it has shown to work. In principle, using the JS tool I worte, it is not that problematic to generate all potential ones. I did that for tones, and I did that for many other features.

It is already there in the PR I just made :wink:
The linguolabials make sense because, apparently, they are a distinctive feature of a cluster of Vanuatu languages (we should actually ask the specialists at the department what is their take on that)


Azure: don't remove availability set on cleanup

do not merge until further updates.

Please add the change information in description. It looks no AvailabilitySet removal when it has different name than availabilitySets.

#66 merged which contains this PR, close it.


Edge 100 not recognized

Howdy and happy Friday :) Edge 100 has now been released as a stable version, but it's not being recognized on CanIUse. GA imports don't track it, and it doesn't show as the latest version in the stack.

Done!


lestarch: fixing incorrectly named setting

Originating Project/Creator

Affected Component

Affected Architectures(s)

Related Issue(s)

Has Unit Tests (y/n)

Builds Without Errors (y/n)

Unit Tests Pass (y/n)

Documentation Included (y/n)

Change Description
Fix an incorrectly named setting causing F´ to improperly load config directories.

Note: this PR also renames install_dest -> install_destination for consistency, as some fields use abbreviations and others did not.


[WIP] Edit long-range electrostatics section

I started editing this section, which needs lots of help, but didn't get all the way through it. I'll be offline until around 8-ish (Pacific) so if you'd like to carry on where I left off in the meantime, please have at it.  You can commit directly to this branch if you like, or if you're less certain about what you're doing you can do a PR to this branch. :)
Tagging @EfremBraun and @JIMonroe in case you have time.
There are a couple major things I'm doing so far as I go through it:

Reducing the number of equations (most don't seem to add much value)
Making it less technical
Improving grammar, etc.

Sorry, don't think I'll be able to get to this one tonight.

I have one more PR coming with some minor things, but if I get to this it won't be for another two hours or so.

OK, so I'm back online now at least for a bit and will continue where I left off. @JIMonroe - keep in touch when/if you have time to look again.

I am back as well and will be working on it for a few hours. Are the latest edits on mobley3 branch?

Yes, let me push where I am. One sec.

OK, I'm done with this, so @samarjeet or @JIMonroe please review and merge when you're OK with it.
@samarjeet - there are a couple small action items for you to deal with, flagged in to-do items. A reference needs to be added, and there's one point I don't  understand that you need to clarify. Please fix (in a separate PR if you like).
I'll likely be offline until early morning beginning shortly (early to bed/early to rise usually). I'll have very limited time in the morning, but I can do quick checks and merge things if needed.

Yes, it looks good to me. About the comment in step 3 of grid solver, I wanted to convey that the inverse-FFT that we do in step 4 is not just the inverse of what we had on the grid. (Otherwise why would one need to carry out the inverse FFT). There's also a subtle point there that we cannot actually call it the potential energy of the reciprocal-space charge distribution, although it pretty much looks like it.

@samarjeet

About the comment in step 3 of grid solver, I wanted to convey that the inverse-FFT that we do in step 4 is not just the inverse of what we had on the grid. (Otherwise why would one need to carry out the inverse FFT).

I still don't understand what you're getting at here. What exactly is changed about the grid?
(Perhaps it's because I haven't implemented this part... But still, I'm probably more educated about this material than our readers will be, so if I don't understand it, it's likely they won't either.)

OK,  I'm going to get this merged in and then separately remove or do something to clean up the part referenced above which is still unclear.


Fixed catches of redux actions when the the fetch process is reponsib…

…ility of GraphQL

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
no

License
MIT

Doc PR
no

This only solves the issue partially. We are catching all errors, not only the ones related to the API but also the ones related to code. We should find the we to identify each of the two types and act accordingly (console.error for code, dispatch for API)

@gorkalaucirica It's okay, but for now, this PR offers better solution than the master's. We can merge this PR and open an issue about your intention.


Kuchiki tests should use strict mode

This would have caught the issues in https://github.com/rust-lang/docs.rs/pull/957#discussion_r469944547 automatically.

Happy to do some work on this, I’ll probably reach out for some initial help getting started though.

Hmm, I don't remember what I was thinking of when I wrote this. @Nemo157 mentioned it originally - do you know where the kuchiki setting for this is?
I do see https://docs.rs/kuchiki/0.8.1/kuchiki/struct.ParseOpts.html#structfield.on_parse_error, maybe we could set it to panic if it sees an error?

I think it's probably TreeBuilderOpts.exact_errors and TokenizerOpts.exact_errors

No, that just reports more detailed errors, it doesn't change the behavior: https://docs.rs/html5ever/0.25.1/src/html5ever/tree_builder/mod.rs.html#474

Report all parse errors described in the spec, at some performance penalty
Sounds like it reports all the errors it encounters instead of being a browser and allowing malformed html to be silently accepted

TBH when suggesting that I had no idea whether kuchiki had such an option, it just seemed like something it would likely support.

So we want to panic on error? Or does this need to be closed.  Looking through the kuchiki docs, couldn’t anything about a “strict” mode.

Let's start by panicking on error and if that has too many false positives we can reconsider. The issues in https://github.com/rust-lang/docs.rs/pull/957#discussion_r469944547 were pretty blatant, I'd be surprised if we couldn't find some way to catch that in kuchiki.

So threw together something quick for initial testing, every parse I've tried seems to fail with "unexpected token", below being one example
            let mut opts = kuchiki::ParseOpts::default();
            opts.on_parse_error = Some(Box::new(move |err| {
                eprintln!("HTML parse error: {:?}", err);
                panic!(err.to_string());
            }));

            let full = kuchiki::parse_html_with_options(opts)
                .one(web.get("/releases/queue").send()?.text()?);

and
HTML parse error: "Unexpected token"
thread 'web::test::test_doc_coverage_for_crate_pages' panicked at 'Unexpected token', src/web/mod.rs:675:17

New to rust and not too familiar with html5ever, but should we allow "unexpected token" and only panic on other errors?  Or let me know if something seems wrong in general.

This might be because we have <script> tags after the </body>. I have a fix as part of https://github.com/rust-lang/docs.rs/pull/980 I could separate out.

Alright, sounds good. I'll wait until it lands.


VPC PIF table implementation

Done in external (currently private) repo, I'm closing this issue. To be merged into this repository at some point.


How to configure the MongoDB storage adapter of django_chatterbot

hi,
How to configure the MongoDB storage adapter of django_chatterbot ,Hoping to give me a sample

you can read chatterbot doc

Hi @xilu0, it is important to note that the ChatterBot storage adapter for Mongo DB is not designed to work with the Django ORM. If you want to use Mongo DB with ChatterBot you will need to modify your Django project to use a "Django storage backend" for MongoDB. There are a few popular ones available such as:
https://django-mongodb-engine.readthedocs.io/en/latest/topics/setup.html

Thank you for your answer!
ganthercox,You know me, I hope support MongoDB, but Django is not good for MONGO, it's ideal to separate databases.


FLOW-335: Add a counterpart to "skipped due to only_if/not_if" so users know that a  resource had a guard that allowed resource execution.

This issue came from user feedback.  Here's part of the blurb from the internal ticket on it:

As a person who writes Chef Cookbooks containing guard resources, I should be able to tell from reading the log whether an evaluated guard resource was inclusive (only_if) or exclusive (not_if), so that I can better understand the actions taken by my code.

Overall I'm not sure we should add this to the default doc formatter. It seems a little excessive on the output.

👍 on adding the callback, just needs to be cleaned up a bunch.

Recipe: Create file /var/www/html/baz.html only if foo exists
in -lwarn mode:
foo does not exist -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create (skipped due to only_if)
foo exists -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create (passed guard only_if)
  - create new file /var/www/html/baz.html
  - update content in file /var/www/html/baz.html from none to e9700a
  - suppressed sensitive resource
  - change mode from '' to '0755'
foo exists -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create (passed guard only_if)
   (up to date)
foo does not exist -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create (passed guard only_if)
   (up to date)

in -ldebug mode:
foo does not exist -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create[2016-07-11T13:19:40-07:00] INFO: Processing file[/var/www/html/baz.html] action create (remote_directory::default line 24)
 (skipped due to only_if)
foo exists -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create[2016-07-11T13:20:32-07:00] INFO: Processing file[/var/www/html/baz.html] action create (remote_directory::default line 24)
 (passed guard only_if)
foo exists -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create[2016-07-11T13:21:13-07:00] INFO: Processing file[/var/www/html/baz.html] action create (remote_directory::default line 24)
 (passed guard only_if)
foo does not exist -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create[2016-07-11T13:22:07-07:00] INFO: Processing file[/var/www/html/baz.html] action create (remote_directory::default line 24)
 (skipped due to only_if)

/cc @randomcamel @coderanger @loganmeetsworld

Very :-1: on that output. It adds nothing and clutters the screen. If you want to add the event callback for use with Insights or whatever that's cool but this doesn't belong in any human output.

Ok, I'm 👍  😄 . @coderanger, I've updated the PR description with the blurb from the internal ticket that triggered this as well as the user feedback that generated it. The ticket is asserting that multiple users are not clear on the type of guard being executed when the resource is not skipped. Users cared enough to use their votes for this feature. Assuming that need is true, do you have a suggestion on how they can figure this out without finding the particular cookbook to validate?

I guess I'm not sure what you think this will clarify. All guards are always executed, so this isn't indicating anything more than the code.

Upon further reading I don't think this addresses the user comment at all. What they are looking for is more detail in the skipped due to ... output to maybe show what actual condition caused it to be skipped.

I'm 👎 on this as it stands; I don't think this implementation matches the user request, and I agree with @coderanger that this doesn't provide any additional information to the user.

I would agree that adding some output at debug that has specifics of the mode (not vs only), type (command string vs block), and actual output of the guard clause would be a help for debugging, but that should go in log data instead of the formatter probably :)

Or maybe put a very abbreviated version of that in the formatter data.

So I'm a bit torn on this. I agree with @thommay and @coderanger that the added output has no added value and basically just spits back the guard type specified in the recipie. On the other hand, reading the comment this seems to be exactly what the user is asking for (I am NOT saying that means we should do it). So I'm a bit confused on what @coderanger and @thom think might be better output or how they interpret the comment. In my experience I have often wished I could find out which specific clause of the guard triggered the converge especially in the case of complex guards. Obviously that would be much more involved work.
I think we need to be hyper aware of log real estate and even though this adds only a few words to the output:
foo exists -> Recipe: remote_directory::default
  * file[/var/www/html/baz.html] action create (passed guard only_if)

maybe its best if we ONLY add it for debug output.
thoughts?

The problem is that formatter output doesn't have levels, that's only for logging.

I guess my problem is that I can't see what the use case is here, and I don't think we've described it adequately. I've certainly thought "why has this resource run", but the information presented here doesn't tell me that - it just tells me that the guard happens to have passed (which I know already). I still have to go back to the cookbook to find out what the guard was.

My understanding of the user case is:
"Skipped due to guard resource" is not descriptive enough, they're looking for either, "Skipped due to not_if" or "skipped due to only_if." I agree that this is a useful change, people want to know what caused the behavior.
However, if a resource proceeds because a guard didn't fire, then it's implicit in the log already that the guard didn't fire. I don't think we need to be explicit in standard output, although it'd be useful in debug.

@charlesjohnson :+1: on that change, this patch is unrelated though.

Yeeah I think we all agree with :-1:  on the change in this PR


Feature Request : add support for downloading from the "drivers and tools" section

Most iso / ovas are to be found under the "Product Downloads" section in customer connect.
But sometimes additional/alternative iso/ova are under other sections.
example with VSAN:
"Product Download" : https://customerconnect.vmware.com/downloads/info/slug/datacenter_cloud_infrastructure/vmware_vsan/8_0#product_downloads
but
"Drivers and Tools" is : https://customerconnect.vmware.com/downloads/info/slug/datacenter_cloud_infrastructure/vmware_vsan/8_0#drivers_tools
If i want to download the iso for the witness appliance, i have to go through this link : https://customerconnect.vmware.com/downloads/details?downloadGroup=WITNESS-OVA-80&productId=1356
having the possibility to also download these components through vcc would be a great feature.

@vEDW whilst I think this is technically possible, I think that it would be quite a bit of effort to implement. I'm pretty sure that the SDK is already returning the information, but the CLI would need to be re-worked for this. I'll add this to the repo backlog.

@laidbackware understood. thanks for considering it.
great project.

same issue for get also Open Virtualization Format Tool 4.5.0

@alagoutte thanks. I am working on this but having limited time only. Also the Customer Connect API is very inconsistent as you've realized, so it makes it even harder to bring it to a consistent format in the CLI.

+1 for supporting Drivers and Tools section, which includes popular utilities like OVFTool

+1 for downloads in Product Patches section

+1 for supporting "Drivers and Tools" section, for VMware Cloud Director Availability for to download the onprem appliances for example.

@vEDW @alagoutte @lamw @tsugliani
I've added this requested feature and cut a beta release. Can you please give it a test and let me know your feedback.
https://github.com/vmware-labs/vmware-customer-connect-cli/releases/tag/v1.2.0-beta

+1 for downloads in Product Patches section

@tgranlun Due to the way Customer Connect works this will require a completely new code path, which will be a lot more effort. I will close this issue requesting drivers etc. and if you still need patches, can you please open a separate issue.

thanks @laidbackware : testing beta version. will provide feedback asap.

problem running beta 1.2.0 on photonos 3.0:
vcc: /lib/libc.so.6: version `GLIBC_2.34' not found (required by vcc)
vcc: /lib/libc.so.6: version `GLIBC_2.32' not found (required by vcc)

the below script downloads desired vcc version and runs 'vcc --version'
example if using 1.1.7 (latest)
root@cpodedge [ ~/vmware-download ]# ./0_vcc_cli.sh
Select desired VCC release or CTRL-C to quit

1) v1.2.0-beta    4) v1.1.5        7) v1.1.2       10) v1.0.0
2) v1.1.7         5) v1.1.4        8) v1.1.1
3) v1.1.6         6) v1.1.3        9) v1.1.0
#? 2

you selected release : v1.1.7

vcc version 1.1.7

problem if using vcc 1.2.0-beta
root@cpodedge [ ~/vmware-download ]# ./0_vcc_cli.sh
Select desired VCC release or CTRL-C to quit

1) v1.2.0-beta    4) v1.1.5        7) v1.1.2       10) v1.0.0
2) v1.1.7         5) v1.1.4        8) v1.1.1
3) v1.1.6         6) v1.1.3        9) v1.1.0
#? 1

you selected release : v1.2.0-beta

vcc: /lib/libc.so.6: version `GLIBC_2.34' not found (required by vcc)
vcc: /lib/libc.so.6: version `GLIBC_2.32' not found (required by vcc)


Directory matching in location mode is sometimes case-insensitive

We use pragma case_sensitive_like = true to make LIKE in SQLite case-sensitive.
However, this pragma only affects one connection, and since the SQL backend will open multiple connections, when the query was made via another connection, the matching is case-insensitive.
To fix this, we can always load the entire directory table and do the filtering in Go. This can reduce the number of database queries and allow us to plug in alternative matchers more easily.

Thanks to @bpinto for uncovering this bug!


please add Politeknik Negeri Sriwijaya

See polsri diploma programs here: https://www.polsri.ac.id/programs

@msarjono First stage of verification passed, official domain is polsri.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@msarjono Thank you for your patience while waiting for a review and processing your request. Pull request merged. Thank you!


Preallocation net_pkt for net context.

What is the use case/need behind this change?
Now that socket is the unique user API, it would be more likely seeing net_context's public exposure shrinking, not the other way round.

What is the use case/need behind this change?
Now that socket is the unique user API, it would be more likely seeing net_context's public exposure shrinking, not the other way round.

The intention for extend API is to make possibility to allocate required buffer directly in module where the net_context is used. This approach allow to make some parts of code more generic. For example platform implementation of UDP for Open Thread can use net_context (but instead of static buffer the net buffer can be allocated for required space amount).

No needed anymore


codetriage just sent me a list of 473 issues

I usually get about 7 issues in the daily email (I'm subscribed to 8 repos). Today I got 473, which is definitely a bug. It is also beyond the email size that my client can display.
Message ID<EMAIL_ADDRESS>

Wow, that's...bad. 🙊 Thanks for the report!
We had a snafu where we ran out of credits for sendgrid today, it may be related. I'll have to look into it .

I'm looking into this now. For the very short term, you can set an email limit on the number of issues to get in one day. Go to https://www.codetriage.com/users/5617 and update the value. You could keep it low 7 or 10.
Actually I might just go ahead and set a default for everyone to 50 issues until I get this sorted out.  #601

Think I've mitigated this as well as I can.


No module named Brain

Hello,
Sorry if this question has already been asked, but didn't see anything on the issues or on Google.
I've tried resolving this myself, but i haven't succeed.
The cobe console command works great and i don't have any problems with it.
I used your API example from the wiki and tried to do something like that :
#!/usr/bin/env python
import sys
sys.path.insert(1,"/usr/local/lib/python2.7/dist-packages/cobe-2.1.2-py2.7.egg") #Not in the path
from cobe.brain import Brain

b = Brain("cobe.brain")
print b.reply(sys.argv[1])

But i'm getting this error :
Traceback (most recent call last):
  File "cobe.py", line 4, in <module>
    from cobe.brain import Brain
  File "/path/to/cobe.py", line 4, in <module>
    from cobe.brain import Brain
ImportError: No module named brain

Installed python-cobe and cobe-act from pip install, didn't work too.
And pydoc cobe.Brain is giving me the same error :
pydoc cobe.Brain
problem in cobe - <type 'exceptions.ImportError'>: No module named brain

Infos :
python --version
Python 2.7.9

Operating System: Debian GNU/Linux 8 (jessie)
Kernel: Linux 3.19.3-xxxx-std-ipv6-64
Architecture: x86-64

Do you have some tips/solution to help me resolve this ? (i'm not a python developer)
And sorry for my english, if there is any bizarre wordings

Cloned this repository, put the python script inside the folder cobe/ and it works.
Sorry !


[WETV] yt-dlp not downloading subtitle or video

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
[WETV] yt-dlp not downloading subtitle or video
please help me
Provide verbose output that clearly demonstrates the problem

[x] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp --all-subs --skip-download --cookies-from-browser firefox --external-downloader aria2c --sub-format srt https://wetv.vip/en/play/wu7vz4vgfi8ugan-Soul%20Land%202%3A%20The%20Peerless%20Tang%20Clan/i0048qo3zkg-EP34%3A%20Soul%20Land%202%3A%20The%20Peerless%20Tang%20Clan
[Cookies] Extracting cookies from firefox
[Cookies] Extracted 81 cookies from firefox
[wetv:episode] Extracting URL: https://wetv.vip/en/play/wu7vz4vgfi8ugan-Soul%20Land%202%3A%20The%20Peerless%20Tang%20Clan/i0048q...erless%20Tang%20Clan
[wetv:episode] i0048qo3zkg: Downloading webpage
[wetv:episode] i0048qo3zkg: Downloading webpage
ERROR: [wetv:episode] i0048qo3zkg: Tencent said: invalid ckey; please report this issue on  https://github.com/ytdl-patched/ytdl-patched/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

please add a complete verbose log

[x] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below


Pandas/yaml update and windows compatibility

Updated pandas and yaml to modern versions
Changed code where broken concerning update
Made the code compatible for Windows by removing colons from filenames
Can now be used in a Windows development cycle

Fixed cloning issue for Windows compatibility.


[Diagnostics] Using ContextTraceManager in Asp.NET

Addresses #2165

(I'll wait until you've got past the AppVeyor issue before reviewing.)

ContextInstanceManager is used for storing the root Span created on BeginRequest so it can be disposed off on EndRequest. This is necessary because althugh the tracer holds the stack of Spans, there's currently no way to either access one of the spans or close them all through the tracer.
Using ContextInstanceManager to do this is particular of us implementing the hooks for the Asp.NET pipeline, anyone implementing their own pipeline can (should) have a different way of storing the root Span for disposing of it in the end.


加载 中文名称的文件 有问题

在本地开发调试环境下 用了CopyWebpackPlugin 把 csv格式的文件复制到一个目录下 让网页可以下载该文件
但是 文件名是英文的可以下载，但是文件名称改成中文就不能下载
是 webppack 对中文不支持吗？

oks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


RTL Support

Hi
I want to set the tree to RTL
is set the themes options as follow:
"themes": {
"rtl":true,
"theme" : "default-rtl"
},
"core":{
'data': function(node,cb){
cb(require("../SearchPages/searchTreeData"));
}
}
BUT the tree still LTR

jsTree will use the direction CSS property of its container - it is not a config option. Basically - either set it anywhere in your CSS (there is no need to be inline). Here is a demo:
http://jsfiddle.net/DGAF4/1348/
Best regards,
Ivan

Thanks it's worked.


[Project change]: In order not to work with the flashc while flying, a

test is added to check whether the motors are armed or not.
This leads to the following project change:
init_success &= mavlink_communication_init(
&central_data.mavlink_communication,
&mavlink_config,
central_data.telemetry_up_stream,
central_data.telemetry_down_stream,
&central_data.state);

It seams clean for me.
I don't see anyway to get ride of this additional dependency between both mavlink_communication and onboard_parameters modules and the state module.
@jlecoeur any suggestion ?


fix(sam-spec): replace AlexaSkillEvent.Variables with AlexaSkillEvent.SkillId

The spec we use claims that AlexaSkillEvent has a Variables property, but it does not: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-alexaskill.html
This change: https://github.com/awslabs/goformation/pull/613/files made the spec match the SAM docs. The property is marked as optional, but it is the only possible property; make it required. Our codegen will now only match the strongest possible type in type unions (which the inputs to function events are) and AlexaSkillEvent will never be chosen, because it currently has no required properties. This results in the AlexaSkillEvent being ignored during synthesis, which creates templates with missing properties.
Making SkillId required makes the AlexaSkillEvent usable in CDK apps.

You need to edit
<EMAIL_ADDRESS>


Support lightningcss "resolver" option

Description
Hi their!
Hope you are doing well! At start, thanks for your work!
It will be nice to be able to specify the resolver options supported by the lightningcss compiler but that seems to be not passed and supported on the vite side...
https://github.com/vitejs/vite/blob/6a7dde54e4ac357798d7124894ff71cb36a36985/packages/vite/src/types/lightningcss.d.ts#L13
Suggested solution
Add the resolver option in the LightningCSSOptions type as well as passing it to the lightningcss compiler.
Alternative
No response
Additional context
Example of use:
// vite.config.ts
import { browserslistToTargets } from "lightningcss";
import fs from 'fs';
import path from 'path';

export default {
  css: {
    transformer: "lightningcss",
    lightningcss: {
      resolver: {
        read(filePath) {
          console.log(filePath);
          return fs.readFileSync(filePath, "utf8");
        },
        resolve(specifier, from) {
          return path.resolve(path.dirname(from), specifier);
        },
      },
      targets: browserslistToTargets(browserslist(">= 0.25%")),
    },
  },
  build: {
    cssMinify: "lightningcss",
  },
};

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

What is the usecase for accepting a resolver option? Vite has its own internal resolver too and it should use that. Similar to how postcss-import and CSS preprocessors like SCSS, Stylus, all use Vite's resolver only.

In that case, it seems like a bug (or technically a feature request) to me to make import globs work with lightningcss. There's also a corresponding postcss feature request: https://github.com/vitejs/vite/issues/12336. If we can get this working, then I don't think we have to expose the resolver option.

For @custom-media, there is a different feature request regarding additionalData https://github.com/vitejs/vite/issues/17724. OP there hasn't responded there but it looks like @custom-media seems to be a nice use case for additionalData.


investigate smarter building of rpm image

Currently the build_zfs job publishes an image containing zfs RPMs, ucore-zfs-rpm, which is turn used by later build jobs to install said RPMs.
It would likely be valuable to use the github cache instead, storing the RPMs there.
The key should be comprised of:

CoreOS stream (stable, testing)
CoreOS kernel version (provided in upstream image metadata).
ZFS version

This would reduce the number of builds required for kernel modules, not just if there are multiple builds  in a day, but for a week a more at a time since upstream CoreOS doesn't publish images daily.
Should provide a good model for nvidia modules which need to be added.

I've read about caching, and while nice, it's probably still valuable to have the RPMs stored in a scratch docker image.
However, the major goal of avoiding redundant builds and using a key of stream/kernel_version/zfs_version could still be accomplished by storing proper metadata on the ucore-zfs-rpm image and only building a new image when a match is not found.

A few changes were made to prepare for this.
#39 - no "zfs-" in the zfs version
#40 - adding metadata (eg, kernel version, coreos stream) to the ucore-zfs-rpm image


Fix RuntimeWarning

"runtimewarning: invalid value encountered in double_scalars" caused by python calculation order, for example:

-27**(1/3)
returns -3.0
but
(-27)**(1/3)
returns (1.5000000000000004+2.598076211353316j)

Coverage decreased (-0.001%) to 88.849% when pulling 059ab0af307fdd4543ea14bae632515b0dbb0454 on YifeiLu:master into 017a6b209058f1c4867c59222d30ccb172180048 on CalebBell:master.

Hi Yifei,
That's an interesting suggestion. I am not quite sure what you are suggesting - this correlation is for a sub-critical liquid; it doesn't make sense to use it when T is larger than Tc.
Changing an equation so it provides new answers in a region it was not designed for is always hard. The approach I had planned was to truncate T to Tc; avoiding the numerical issue. Do you have a plot of what the new results look like?
Sincerely,
Caleb

Hi Caleb,
First of all thanks a lot for this tool, it really helps me a lot! For this
commit I'm not suggesting anything related to the calculation method or
thermodynamics, but to fix some warning caused by python. I always get the
"runtimewarning" when I run my own code. Therefore I checked the code a
little bit and found this problem. This shouldn't affect the result at all
as I understood, it's just a reformatting of the code to avoid such
warnings. I'm actually using thermo to calculate gas properties, but I
still got these warnings. FYI, I used thermo to calculate the following gas
mixture with a temperature of 288.15K and pressure ranges from 50 to 70 bar.
gas_comp = OrderedDict([('methane', 0.96522),
('nitrogen', 0.00259),
('carbon dioxide', 0.00596),
('ethane', 0.01819),
('propane', 0.0046),
('isobutane', 0.00098),
('butane', 0.00101),
('2-methylbutane', 0.00047),
('pentane', 0.00032),
('hexane', 0.00066)])
On Thu, Jul 16, 2020 at 1:58 AM Caleb Bell<EMAIL_ADDRESS>wrote:

Hi Yifei,
That's an interesting suggestion. I am not quite sure what you are
suggesting - this correlation is for a sub-critical liquid; it doesn't make
sense to use it when T is larger than Tc.
Changing an equation so it provides new answers in a region it was not
designed for is always hard. The approach I had planned was to truncate T
to Tc; avoiding the numerical issue. Do you have a plot of what the new
results look like?
Sincerely,
Caleb
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CalebBell/thermo/pull/54#issuecomment-659075600, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5CR7EY66DLTXDAERORT53R3Y7DXANCNFSM4O3ACVJQ
.

Closing, this change made its way into the chemicals library, which thermo now uses.


Considering extra config in dotenv source

Fixes https://github.com/pydantic/pydantic-settings/issues/11

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (0ff45ea) 95.25% compared to head (2a914fa) 95.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   95.25%   95.28%   +0.03%
==========================================
  Files           5        5
  Lines         295      297       +2
  Branches       74       75       +1
==========================================
+ Hits          281      283       +2
  Misses         12       12
  Partials        2        2

Impacted Files
Coverage Δ

pydantic_settings/sources.py
95.23% <100.00%> (+0.03%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I've added a commit and changed the logic to handle case insensitive and sub-model

thanks so much.


Implement feature detection

Provide an API to detect whether the device supports a certain feature, e.g. camera.

With Cordova plugin support coming, I don't see anything to be implemented on the JS side anymore.


109 근로자수 코드 목록 API

Closes #109

Codecov Report

Merging #111 (3ea9679) into main (4124b36) will decrease coverage by 0.96%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##               main     #111      +/-   ##
============================================
- Coverage     47.01%   46.04%   -0.97%
- Complexity       80       87       +7
============================================
  Files            36       40       +4
  Lines           419      443      +24
  Branches          3        3
============================================
+ Hits            197      204       +7
- Misses          222      239      +17

Impacted Files
Coverage Δ

...se/presentation/payload/response/CodeResponse.java
0.00% <0.00%> (ø)

...main/enterprise/service/EnterpriseCodeService.java
16.66% <16.66%> (ø)

...erprise/presentation/EnterpriseCodeController.java
50.00% <50.00%> (ø)

...m/benecia/domain/enterprise/domain/Enterprise.java
19.04% <0.00%> (-4.49%)
:arrow_down:

.../benecia/domain/attatchment/domain/Attachment.java
83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4124b36...3ea9679. Read the comment docs.


Use poetry to manage backend dependencies

I think we should probably have a quick discussion with app development team leads to make sure they like the switch to poetry, but I expect they will.

I've already talked to Christine about it, you were next up on the list. We don't necessarily have to go with poetry (although I would strongly prefer it), but requirements.txt is just not a scalable solution - especially because it involves explicitly pinning our transitive dependencies.

for the record i'm happy with moving this direction and am currently working on switching doc gen and attorneys over, mark walked me through how. i think it'll be easier than any other way around the pip dependency backtracking and is just the right decision in the long run.


.enpass file should not be stored in script path

in getCards() and CardCompleter(), it's trying to open getScriptPath() + '/.enpass' for write. If pass.py were installed to /usr/bin or /usr/local/bin, this would fail to work because of permissions.
Instead it should be using either $HOME/.enpass_cli, or even better $XDG_CONFIG_HOME with default to $HOME/.config, appending enpass_cli/config to the result of the former, and of course, automatically creating the directories up as needed.
Reference: https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

Completely valid point, however I do not use this tool anymore personally. All PRs are welcome :-)

I will gladly submit a PR soon! Curious why you don't use this anymore though. Stopped using Enpass?

I like the simplicity of Enpass, but LastPass had tighter integration with my browser and mobile back when I used it. LastPass also did some things I liked in regards to password sharing, instead of just exporting the password like Enpass. The company itself was a factor aswel.

@HazCod Could you add this info on the README of the project, maybe someone else will take over the development ?

@crisp2u Sure! https://github.com/HazCod/enpass-cli/commit/db3a60d67546a6b7334761760da01c87e8c0f22b

No longer relevant with the Go rewrite, closing.


bug: marks not being saved when using via formatexpr

Neovim version (nvim -v)
v0.9.5
Operating system/version
macOS 14.4.1
Add the debug logs

[X] I have set log_level = vim.log.levels.DEBUG and pasted the log contents below.

Log file
00:03:53[DEBUG] Running formatters on /Users/dylan/.dotfiles/nvim/after/plugin/conform.lua: { "stylua" }
00:03:53[INFO] Run stylua on /Users/dylan/.dotfiles/nvim/after/plugin/conform.lua
00:03:53[DEBUG] Run command: { "stylua", "--search-parent-directories", "--stdin-filepath", "/Users/dylan/.dotfiles/nvim/after/plugin/conform.lua", "-" }
00:03:53[DEBUG] Run CWD: /Users/dylan/.dotfiles
00:03:53[DEBUG] stylua exited with code 0

Describe the bug
When using Conform via the formatexpr, folds are not kept after using gq.
What is the severity of this bug?
minor (annoyance)
Steps To Reproduce

nvim -u repro.lua sample.lua
:5 - go to line 5
mz -- mark current position as z
gg -- go back to top of the file
gqG -- format the file using formatexpr
 `z -- "Mark not set" error message

Expected Behavior
Should go back to mark z on line 5 after formatting file.
Minimal example file
local options = {
formatters_by_ft = {
lua = { "stylua" },
},
log_level = vim.log.levels.DEBUG,
}

require("conform").setup(options)

-- This should be okay to set globally, as will default back to the LSP
-- formatexpr if present and then to nothing.
vim.o.formatexpr = "v:lua.require'conform'.formatexpr()"

Minimal init.lua
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
    "stevearc/conform.nvim",
    config = function()
      require("conform").setup({
        log_level = vim.log.levels.DEBUG,
        -- add your config here
	formatters_by_ft = {
	  lua = { "stylua" },
	},
      })
    end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

vim.o.formatexpr = "v:lua.require'conform'.formatexpr()"

Additional context
No response

I believe I'm experiencing something related to clearing the marks.  When I save a file the view jumps to near the top of the buffer.  In other words, updating the buffer with the formatted buffer changes my viewed position in the buffer.
PS: This is a great plugin that solves a configuration problem that I've had for years. Thank you!


TypeError since upgrade to prisma 2.29.0

I haven't looked into it very far yet but I've ran yarn upgrade earlier today, which updated both @prisma/client and prisma from 2.28.0 to 2.29.0. Trying to login or really just visiting any site which requires a session now results in the following error:
get(): TypeError: Cannot read property 'data' of undefined
TypeError: Cannot read property 'data' of undefined
    at PrismaSessionStore.<anonymous> (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:301:74)
    at step (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:61:23)
    at Object.next (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:42:53)
    at fulfilled (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:33:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Reverting these two packages to ~2.28.0 fixes the issue again.

For reference, my database model and initialization code
model Session {
  id        String   @id
  sid       String   @unique
  data      String
  expiresAt DateTime
}

return Session({
    name: SessionCookie,
    cookie: {
      maxAge: 7 * 24 * 60 * 60 * 1000, // ms, 7 days
      sameSite: "strict",
      secure: "auto",
    },
    secret: key,
    resave: false,
    saveUninitialized: false,
    unset: "destroy",
    store: new PrismaSessionStore(prisma, {
      checkPeriod: 10 * 60 * 1000, // ms, 10 minutes
      dbRecordIdIsSessionId: true,
      dbRecordIdFunction: undefined,
    }),
  });

It appears that it is this line that throws: https://github.com/kleydon/prisma-session-store/blob/8941f85564128bfb2cb1238aebe7670ddb1a3c55/src/lib/prisma-session-store.ts#L242
Since it tries to lookup a specific sid, I tried to clear cookies but that didn't help. Running the query manually returns null, which should properly return from the function before trying to parse anything?
> prisma.session.findUnique({ where: { sid: "something" }}).then(res => console.log(res));
Promise { <pending> }
> null

I've used the high art of console.log-debugging .. and indeed the session object is somehow undefined

the diff
***<EMAIL_ADDRESS>2021-08-11 08:38:53.209000000 +0200
---<EMAIL_ADDRESS>2021-08-11 15:38:11.431780377 +0200
***************
*** 283,286 ****
--- 283,287 ----
              var session, result;
              var _a;
+             console.log("DEBUG session.get()", sid);
              return __generator(this, function (_b) {
                  switch (_b.label) {
***************
*** 289,299 ****
--- 290,303 ----
                          if (!(_b.sent()))
                              return [2 /*return*/, callback === null || callback === void 0 ? void 0 : callback()];
+                         console.log("DEBUG case1: prisma.session.findUnique({ where: { sid:", sid, "} })")
                          return [4 /*yield*/, this.prisma.session
                                  .findUnique({
                                  where: { sid: sid },
                              })
+                                 .then(res => { console.log("DEBUG prisma result:", res); return res; })
                                  .catch(function () { return null; })];
                      case 2:
                          session = _b.sent();
+                         console.log("DEBUG case2: session is", session);
                          if (session === null)
                              return [2 /*return*/, callback === null || callback === void 0 ? void 0 : callback()];

DEBUG session.get() c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc
DEBUG case1: prisma.session.findUnique({ where: { sid: c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc } })
DEBUG case2: session is undefined
app:error TypeError: Cannot read property 'data' of undefined
 TypeError: Cannot read property 'data' of undefined
    at PrismaSessionStore.<anonymous> (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:305:74)
    at step (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:61:23)
    at Object.next (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:42:53)
    at fulfilled (/path/to/project/node_modules/@quixo3/prisma-session-store/dist/lib/prisma-session-store.js:33:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
prisma:query BEGIN; [] 0 ms
prisma:query SELECT "public"."Session"."id", "public"."Session"."sid", "public"."Session"."data", "public"."Session"."expiresAt" FROM "public"."Session" WHERE "public"."Session"."sid" = $1 LIMIT $2 OFFSET $3; ["c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc",1,0] 1 ms
prisma:query ROLLBACK; [] 0 ms
GET 500 /api/login 52b 12.787ms 2021-08-11T13:33:07.384Z
Error:
Invalid `prisma.session.delete()` invocation:

  An operation failed because it depends on one or more records that were required but not found. Record to delete does not exist.
    at cb (/path/to/project/node_modules/@prisma/client/runtime/index.js:35943:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Apparently it's Schrödinger's session though. If I add a .then() after the prisma query, the session object becomes null:
DEBUG session.get() c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc
DEBUG case1: prisma.session.findUnique({ where: { sid: c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc } })
prisma:query SELECT "public"."Session"."id", "public"."Session"."sid", "public"."Session"."data", "public"."Session"."expiresAt" FROM "public"."Session" WHERE "public"."Session"."sid" = $1 LIMIT $2 OFFSET $3; ["c2BzZpIeQkWayMR-W-4BDgupk0q5uuxc",1,0] 1 ms
DEBUG prisma result: null
DEBUG case2: session is null
GET 403 /api/login 12b 10.606ms 2021-08-11T13:38:22.191Z

Logging in still does not work though because I get a different error later on:
app:auth { id: 1, name: 'Max Mustermann', pkz: null, type: 'local' }
prisma:query BEGIN; [] 0 ms
prisma:query SELECT "public"."Session"."id" FROM "public"."Session" WHERE "public"."Session"."sid" = $1; ["84zxpnfBNyp-f64tQz2EELAQBTRfu9o9"] 1 ms
prisma:query ROLLBACK; [] 0 ms
(node:456710) UnhandledPromiseRejectionWarning: Error:
Invalid `prisma.session.update()` invocation:

  An operation failed because it depends on one or more records that were required but not found. Record to update not found.
    at cb (/path/to/project/node_modules/@prisma/client/runtime/index.js:35943:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

I am a little lost .. is this possibly a prisma issue?

Not sure... Haven't seen anything like this yet.
Internally, prisma-session-store has been using an older version of Prisma; I've just updated that, and hope the PR will complete this week.
Perhaps this will improve matters?

Aye. I've subscribed to its merging and will try again then.

👍

I noticed your PR updated prisma to 2.29.1 (I've used 2.29.0 above). Looking at the release notes, there's a link to this issue: https://github.com/prisma/prisma/issues/8718. I'd say this fits my observation of a "Schrödinger's session" above.
And indeed, simply updating to @prisma/client and prisma to 2.29.1 fixes this issue for me.
Thus I'm closing this. It appears to have been a prisma issue indeed.

@ansemjo Glad to hear its resolved!


Install

I don't get it how to install this printer

go to the "code" tab, under "Releases" press the release with the latest pin on it then do what it tells you to do

Would you mind closing this bug report? You just need to go to 'releases', download the .jar file and put it in your mods folder with litematica.