HADOOP-18740. S3A prefetch cache blocks should be accessed by RW locks

Jira: HADOOP-18740

us-west-2
mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO File name too long
[ERROR]   ITestS3ABlockOutputByteBuffer>ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO
[ERROR]   ITestS3ABlockOutputDisk>ITestS3ABlockOutputArray.testDiskBlockCreate:114 » IO ...
[ERROR]   ITestS3AFileContextMainOperations>FileContextMainOperationsBaseTest.testCreateFlagCreateAppendNonExistingFile:831 » IO
[ERROR]   ITestS3AFileContextURI>FileContextURIBase.testCreateFileInNonExistingDirectory:164 » IO
[ERROR]   ITestS3AFileContextURI>FileContextURIBase.testDeleteNonExistingFileInDir:357 » IO
[INFO]
[ERROR] Tests run: 1165, Failures: 0, Errors: 6, Skipped: 148

All failures related to HADOOP-18744

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 41s

trunk passed

+1 :green_heart:
compile
17m 33s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
15m 42s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 38s

trunk passed

+1 :green_heart:
shadedclient
25m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
16m 42s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
16m 42s

the patch passed

+1 :green_heart:
compile
15m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
15m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
25m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 19s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

187m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ab2194f686fd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 912403c4bfd2b5aed1f1a7d94c39cc4b53d44c85

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/testReport/

Max. process+thread count
1235 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I want to implement a new cache replacement algorithm in hdfs but I don't know which part of module to use and modify. Can any one please help me find the modules and functions which need to override to add my own caching replacement algorithm in hdfs

@MayankSinghParmar get on the hadoop hdfs mailing list and discuss there.
@virajjasani can you rebase and retest?

us-west-2:
mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale

mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

Test results are clean

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  1s

trunk passed

+1 :green_heart:
compile
15m 37s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
14m 21s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 41s

trunk passed

+1 :green_heart:
shadedclient
22m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s

the patch passed

+1 :green_heart:
compile
14m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
14m 52s

the patch passed

+1 :green_heart:
compile
14m 19s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
14m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
22m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 32s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

174m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9432f0056538 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 710441f19ca08701a4e0f5c32fa77f3ff7ce9736

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/testReport/

Max. process+thread count
1783 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 27s

trunk passed

+1 :green_heart:
compile
17m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
15m 47s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 42s

trunk passed

+1 :green_heart:
shadedclient
25m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
16m 42s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
16m 42s

the patch passed

+1 :green_heart:
compile
15m 45s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
15m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m 33s

the patch passed

+1 :green_heart:
shadedclient
24m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 22s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

189m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5675

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ce03b807e480 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d2b9210104b1ec0e4a09f22fcfc6df7b82557017

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/testReport/

Max. process+thread count
1244 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5675/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


How to change write_fabric_verilog SRC/ path?

In https://github.com/os-fpga/FOEDAG/blob/d7785ae03e822253105538a4d887fb9a4bdc9409/src/Compiler/CompilerOpenFPGA.cpp#L2303
We instruct OpenFPGA to write the netlists necessary for bitstream verification.
In the fabric_netlists.v produced there are paths like:
/ ------ Include user-defined netlists -----
`include "./SRC/CustomModules/clock_inverter.v"
Is there a way to direct OpenFPGA to use a different prefix than SRC/?

Yes --file option does that
https://openfpga.readthedocs.io/en/master/manual/openfpga_shell/openfpga_commands/fpga_verilog_commands/#write-fabric-verilog

Check the code line I point to above, the --file is used to point to BIT_SIM/ to output the files.
My question is for the other files pointer to by SRC/, that seems to be hardcoded and yet needs to be customized.
// ------ Include defines: preproc flags -----
`include "BIT_SIM/fpga_defines.v"
// ------ Include user-defined netlists -----
include "./SRC/CustomModules/clock_inverter.v" include "./SRC/CustomModules/inverter.v"
include "./SRC/CustomModules/logic0.v" include "./SRC/CustomModules/logic1.v"
include "./SRC/sc_verilog/tcbn16ffcllbwp7d5t16p96cpd.v" include "./SRC/CustomModules/rs_ioff.v"
include "./SRC/CustomModules/rs_ff.v" include "./SRC/CustomModules/rs_xor_mux2.v"
include "./SRC/CustomModules/rs_ccff.v" include "./SRC/CustomModules/rs_preio.v"
include "./SRC/CustomModules/rs_dsp.v" include "./SRC/CustomModules/rs_bram.v"
// ------ Include primitive module netlists -----
include "BIT_SIM/sub_module/inv_buf_passgate.v" include "BIT_SIM/sub_module/arch_encoder.v"
`include "BIT_SIM/sub_module/local_encoder.v"

Those other paths are coming from the Openfpga architecture XML file, please look for verilog_netlist parameter in the circuit_model tags

I see, thanks.

You can close the issue


Bug Found, Can't Push config in database

When i try to send the config in to the database it gives me this error.
https://hastebin.com/babakebame.sql

My way of uploading the config isn't working, I will fix it tomorrow.
Sorry for the bugs.

For now, I don't have a temporary resolution to the problem.

I think I fixed it, I tried pushing and pulling and everything works.

Thanks for your work!


Update boto to 2.42.0 to fix unicode issue

The requirements.txt currently installs 2.39.0, which has a nasty utf8 bug that it is solved in 2.42.0.

updated in the the new future relase 6.1.3. The tag is ready in the docker hub.

It seems that finally the error was on botocore.
Temporary fix on:
https://github.com/APSL/botocore/tree/release_1.2.x
pip install git+https://github.com/APSL/botocore.git@b497766

Fixed again in the 6.1.3 pre-release

Fixed and merged to master in 6.1.5


Add SumoLogic Provider to pkg docs page

This now available - https://www.pulumi.com/docs/reference/pkg/sumologic/


Remove "precision" option. Time should be to 6 decimal places or an integer

Time is measured in microseconds, so it should either be represented as a fraction of a second to 6 decimal places or as an integer. This should be configurable.

Or at least it should default to 6 and there should be an option to display in micoseconds.


Failure running 'wget https://github.com/apache/incubator-pagespeed-ngx/archive/latest.zip

It looks like the zip file is not available anymore at https://github.com/apache/incubator-pagespeed-ngx/archive/latest.zip
The automated install explained here https://www.modpagespeed.com/doc/build_ngx_pagespeed_from_source won't work anymore.
Could anyone please help?

Hi
You can try https://github.com/apache/incubator-pagespeed-ngx/archive/latest-stable.zip or latest-beta.zip

sounds perfect, thanks!


add function for pos tag with transformers

What does this changes
Add function to pos tagging using transformers in pos_tag.py. The function have 3 model which can be switch base on the name on the engine. Have test all engine on test_tag.py and there is no error. Also test assertRaise error value when the engine name does not match any of the engines name.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ yes] Passed code styles and structures
[yes ] Passed code linting checks and unit test

Hello @MpolaarbearM! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/tag/__init__.py:

Line 30:27: E261 at least two spaces before inline comment
Line 34:57: E231 missing whitespace after ','

In the file pythainlp/tag/pos_tag.py:

Line 193:101: E501 line too long (108 > 100 characters)
Line 195:101: E501 line too long (108 > 100 characters)
Line 196:1: W293 blank line contains whitespace
Line 199:1: W293 blank line contains whitespace
Line 200:50: E203 whitespace before ':'
Line 201:101: E501 line too long (107 > 100 characters)
Line 204:101: E501 line too long (105 > 100 characters)
Line 215:1: W293 blank line contains whitespace
Line 225:1: W293 blank line contains whitespace
Line 228:1: W391 blank line at end of file

In the file tests/test_tag.py:

Line 14:5: E265 block comment should start with '# '
Line 369:89: E251 unexpected spaces around keyword / parameter equals
Line 369:91: E251 unexpected spaces around keyword / parameter equals
Line 369:101: E501 line too long (124 > 100 characters)
Line 370:89: E251 unexpected spaces around keyword / parameter equals
Line 370:91: E251 unexpected spaces around keyword / parameter equals
Line 370:101: E501 line too long (123 > 100 characters)
Line 371:89: E251 unexpected spaces around keyword / parameter equals
Line 371:91: E251 unexpected spaces around keyword / parameter equals
Line 371:101: E501 line too long (125 > 100 characters)
Line 374:72: E251 unexpected spaces around keyword / parameter equals
Line 374:74: E251 unexpected spaces around keyword / parameter equals
Line 375:1: W391 blank line at end of file

@MpolaarbearM  Can you fix pep8 and delete ptagger_temp4XcDf.json file?

coverage: 0.0% (-86.9%) from 86.883%
when pulling 174dfb286bd6f27e3b5bec8a74f0dcb69de21095 on MpolaarbearM:postag_transformers
into 715f70038a6308e4a70ac377fbd6d196ac9494e0 on PyThaiNLP:dev.

@wannaphong yes I'll try and fix that


Fix force commit on ingest V2

Description
Closes https://github.com/quickwit-oss/quickwit/issues/4438

[x] fix bug in the CommitType serde
[x] add mechanism to wait using EventBroker
[x] add tests at the workbench level
[x] add elasticsearch tests for refresh param
[x] disable ingest timeout when waiting for commit

How was this PR tested?
Describe how you tested this PR.

sorry, I meant to squash these commits before merging, sorry for flooding the main branch!


Cannot install from PYPI server

Describe the bug
Cannot install with python 3.8.2
To Reproduce
Steps to reproduce the behavior:

pip install qtpylib --upgrade --no-cache-dir

Desktop (please complete the following information):

OS: macOS, 11.2.1
python: 3.8.2

Additional Info
It does install locally when cloned.

@htpeter Once you did that. Instruction #1 says to create blotter.py.
The blotter script is the same one located in qtpylib/examples/blotter.py
Did you just cd examples then run blotter from there?

@datatalking I wrote my own blotter.py script but its essentially the same as the examples file.
Blotter defaults to using Interactive Broker's TWS/Gateway so you'll need that up and running first. I also believe it may require MySQL be running locally.
The Blotter class has the following arguments and default values (I just copy pasted  these below from the library's code).
I include this list so that you can make sure your IBKR TWS/Gateway is available on the expected Port and expected Client ID (you just have to make these values match between the API Settings in TWS and the Python code).
# Arguments you can include when instantiating `Blotter()` to make it work with TWS.
bport=4001,
ibclient=999,
ibserver="localhost",
# Arguments you can include when instantiating `Blotter()` to make it work with MySQL
dbhost="localhost",
dbport="3306",
dbname="qtpy",
dbuser="root",
dbpass="",

And just for reference, here is the most basic version of blotter.py with some of the details I listed above explicitly added. Once everything is running, just run python blotter.py. If you run into errors related to IBKR connection or MySQL, double check those other pieces of software are configured as expected.
# blotter.py
from qtpylib.blotter import Blotter

class MainBlotter(Blotter):
    pass # we just need the name

if __name__ == "__main__":
    blotter = MainBlotter(
              bport=4001,
              ibclient=999,
              ibserver="localhost",
              dbhost="localhost",
              dbport="3306",
              dbname="qtpy",
              dbuser="root",
              dbpass="",
    )
    blotter.run()


could we report 99.9% percentile in CSV file?

Description of issue
could we report percentile with better granularity, like 99.9? considering that tail latency is more and more critical these days.

IMHO 99% and 100% should be enough.

+1 for adding p99.9 and p99.99
I've done some load tests and statistically, 99, 99.9, and 99.99 are all different. Also its meaning depends on each use case (i.e. SLA), but it should be in reports.

+1 for adding p99.9 and p99.99

100% for this. If you are load testing a service that has human users these percentiles become very important. It's complicated why but there's a good explanation in this video

I misunderstood this, I thought you were talking about the "real time" csv output (which is per-two-second statistics, where p99.9 would make no sense at all except for extremely high throughput).
But I guess we're talking about the stats you get from /stats/distribution/csv ?
I definitely see the use of p99.9 and p99.99 there, let me see if I can add them easily... Personally I use external reporting (timescale+grafana) for everything (see https://github.com/SvenskaSpel/locust-plugins if you are interested).


Auto-backoff catchupPageSize if error matches configured regex pattern

This PR is intended to resolve FireFly issue https://github.com/hyperledger/firefly-evmconnect/pull/96.
The design is based on the assumption that different JSON/RPC providers will return slightly different errors for this scenario, so the event listener uses a (configurable) regex pattern when an error is returned from eth_getLogs to decide if it should be retried with a smaller catchupPageSize.
If eth_getLogs returns such an error, the page size is halved (the initial default being 500) until one of the following is true:

the calls are successful
the catchupPageSize reaches 1

(Reducing catchupPageSize to 1 is likely to mean the connector never catches up with main. It feels arbitrary to me however, to pick a higher value (10? 20?) that we set as a minimum to reduce the value down to so I've left the minimum as 1 for now.)
The value of catchupPageSize is only changed for the current runtime. This means that if the JSON/RPC endpoint is upgraded to support larger responses later then a restart of FireFly will return to the default catchupPageSize.
 The most likely reason for a user hitting this is they are developer with a free JSON/RPC endpoint, not a production runtime. If they switch endpoint to a different one a restart is required anyway, so it feels like a suitable trade off.

Codecov Report

Merging #96 (f7b7787) into main (73468c0) will decrease coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##              main      #96      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%
===========================================
  Files           23       23
  Lines         1493     1504      +11
===========================================
+ Hits          1493     1502       +9
- Misses           0        1       +1
- Partials         0        1       +1

Files Changed
Coverage Δ

internal/ethereum/ethereum.go
96.42% <33.33%> (-3.58%)
:arrow_down:

internal/ethereum/config.go
100.00% <100.00%> (ø)

internal/ethereum/event_listener.go
100.00% <100.00%> (ø)

@matthew1001 Sorry this one has been open for a while and hadn't been reviewed. Cheng just made a change that sounds like it might be overlapping in FireFly Common: https://github.com/hyperledger/firefly-common/pull/99
Do we still need this PR, or should this one be updated to use the new setting there?

Closing, will possibly re-open after discussion with @Chengxuan


Revert CommunityToolkit update to fix ARM settings app crash

Summary of the Pull Request
Partially revert https://github.com/microsoft/PowerToys/pull/34419 as new version of Community toolkit packages causes settings app crash on startup on ARM with following exception:
[21:32:45.9264781] [Error] App::App_UnhandledException
    Unhandled exception
Array dimensions exceeded supported range.
Inner exception:

Stack trace:
   at CommunityToolkit.WinUI.Controls.StaggeredLayout.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at Microsoft.UI.Xaml.Controls.VirtualizingLayout.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at ABI.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.Do_Abi_MeasureOverride_2(IntPtr thisPtr, IntPtr context, Size availableSize, Size* result)

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Same stacktrace reported here https://github.com/CommunityToolkit/Windows/issues/509


Error debuglog

Error downloading account name, details logged to DebugInfo.log. Please open a ticket at https://github.com/Stickymaddness/Procurement/issues and include your DebugInfo.log

Please, help me with this issue ?

Hey, thanks for the report.  Please include your DebugInfo.log file, so we can see what the issue is.

Looks like I have the same problem and it also started happening only recently, maybe my log with error will be helpful
DebugInfo.log

DebugInfo.log
same is happening to me, here more data if u guys need.

I have this same issue happening since several days ago. Any news about it?

same problem
DebugInfo.log

DebugInfo.log
same here

I have this same issue happening since several days ago. Any news about it?

did you find a solution ?

managed to solve?

Hey no i didn't
On Thu, Dec 22, 2022, 6:38 AM chrlsfrmg @.***> wrote:

managed to solve?
—
Reply to this email directly, view it on GitHub
https://github.com/Procurement-PoE/Procurement/issues/1140#issuecomment-1362440631,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2WY3XZCSLAXFAQDG2NA47DWOPSOBANCNFSM52LLV2LA
.
You are receiving this because you commented.Message ID:
@.***>

My apologies for not following up for a while.  To confirm, this is not working in the 1.29.1 version, as well? I'll take a closer look ASAP.

@thailyn @GunsnrosesHG @chrlsfrmg
I didn't think there's still demand for the program.
I've cloned this repository and (temporarily) fixed the issue. Feel free to download the new version I've created from my own repository, it should be public.
https://github.com/Omga4000/Procurement/releases/tag/1.30.0
Let me know if that works for you.

I have a pre-release of Procurement version 1.29.2 available here. Please try it out and let me know if the login issues are resolved.

DebugInfo.log
same error, crucible league

Hi, @CoutoSH , thanks for the report. Your error is different. In your case, Procurement is trying to send too many requests (beyond what GGG allows per minute).  This shouldn't happen when using Procurement alone, but things can get complicated. What were you doing in Procurement when you got the error?
Are you getting the same error each time you run Procurement? Please wait at least 2 minutes since you got your last error before trying with a new instance of Procurement.
Are you using other apps at the same time which use GGG's API? Procurement only tracks its own usage, so it will not always smoothly handle having a lower quota than expected.

Hi, @CoutoSH , thanks for the report. Your error is different. In your case, Procurement is trying to send too many requests (beyond what GGG allows per minute). This shouldn't happen when using Procurement alone, but things can get complicated. What were you doing in Procurement when you got the error?
Are you getting the same error each time you run Procurement? Please wait at least 2 minutes since you got your last error before trying with a new instance of Procurement.
Are you using other apps at the same time which use GGG's API? Procurement only tracks its own usage, so it will not always smoothly handle having a lower quota than expected.

Sorry for taking so long to reply...
it worked, I think that the problem was me and my brother trying to do stuff at the same time. the API doesn't like when we do searches and use it at the same time.
thx, and its working fine, my bad


Update getting started guide to highlight standalone clusters

What would you like to be added:
Update the production-environment (vSphere) getting started guide to highlight how to create a standalone cluster (a combined management and workload cluster).
Why is this needed:
There are customers who don't want to pay for a separate management cluster. So the idea is to update the docs to say that the initial cluster can be used for running workloads and not just as a separate management cluster.

This issue has now been addressed in PR #1267, so I'm closing this issue.


Added multiple assignment and test case

This PR adds multiple variable assignment equivalent to the Sass syntax:
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#each-multi-assign

Great job, thanks!

Released.


Error messages for Balancer Service are confusing

"sourcePort" is required = Listening Port is required
"Choose one or more targets to send traffic to" & "Service and port are required on each target" - overlap each other.  They both alway come up if I'm missing target source or port.  So there should probably just be the one, or associated each error to a specific field instead of both.

Some new fields are marked required in the API now, so they're getting double-checked.  I moved the specific checks above the generic API validation now and don't call the API validation unless there are no errors.  So you will see just the friendlier-messages, but not necessarily all the errors that are wrong all at once.

v0.27.0-rc4 - Verified Fixed that only friendly messages appear.


chore(release): cut v1.1.0

[ x] I have cherry-picked any changes labelled needs-cherry-pick-vX.Y.Z

[ x] I have made all of the following version and patch updates:

Updated the container image tag in charts/osm/values.yaml
Updated the chart and app version in charts/osm/Chart.yaml
Updated the image tags used in the automated demo
Regenerated the Helm chart README.md

[x ] I have checked that the base branch for this PR is correct as defined by the release guide

Is this a release candidate?

Codecov Report

Merging #4630 (3dae598) into release-v1.1 (30e5362) will increase coverage by 0.02%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-v1.1    #4630      +/-   ##
================================================
+ Coverage         68.97%   68.99%   +0.02%
================================================
  Files               213      213
  Lines             14861    14861
================================================
+ Hits              10250    10253       +3
+ Misses             4558     4555       -3
  Partials             53       53

Flag
Coverage Δ

unittests
68.99% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e5362...3dae598. Read the comment docs.


gbm: manually set modifier for implicit bo allocation

Ported from wlroots
Fixes https://github.com/hyprwm/Hyprland/issues/7001
GBM_BO_USE_CURSOR fails gbm_bo_create for me so I dropped it.

Found a similar patch here https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1151


doas: refactor config generation

Description of changes
According to Ted Unangst, since doas evaluates rules in a last matched manner, it is prudent to have the "permit root to do everything without a password" rule at the end of the config file.
Source: https://flak.tedunangst.com/post/doas-mastery

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Apologies, this was done in error.


Intial movement of camera when using third person follow mode

Issue description
The camera initially move when using the third person follow mode when that node is not positioned in (0,0,0).
Steps to reproduce

Use the example "3DFollowThirdPersonExampleScene" from the examples shipped with the addon.
Add 50 to X and Z in the Node3D of the PlayerCharacterBody3D node
Decrease the Damping value from 10 to 1 in the PlayerPhantomCamera3D node
Start the scene and see that the camera is moving directly. Is it wrong to expect it to be positionned directly behind the character, as that's where it's displayed in the editor.

(Optional) Minimal reproduction project
No response

Good spot! Thanks for reporting this.
Essentially the SpringArm3D node was instantiated during runtime at position (0, 0, 0). So the issue was due to it having to spawn from there and then move to its targeted location. A slow damping + a long target distance away from (0, 0, 0) made that really apparent.
Was just a matter of positioning it correctly when it instantiates.


whenever command should default to --update-crontab

Right now it's really easy to overwrite everything else in your crontab by just running then whenever command. Since the crontab entry already has delimiters (also used by the --update-crontab option) to just update the section that belongs to whenever, one would expect this to be the default behavior.
Please change the default behavior of the command and add an optional --overwrite-crontab instead.

I just did this and quite unexpectedly overwrote my crontab... :| The --help content was not helpful in guiding me away from this.
Usage: whenever [options]
    -i [identifier],                 Default: full path to schedule.rb file
        --update-crontab
    -w, --write-crontab [identifier] Default: full path to schedule.rb file
    -c, --clear-crontab [identifier]
    -s, --set [variables]            Example: --set 'environment=staging&path=/my/sweet/path'
    -f, --load-file [schedule file]  Default: config/schedule.rb
    -u, --user [user]                Default: current user
    -k, --cut [lines]                Cut lines from the top of the cronfile
    -r, --roles [role1,role2]        Comma-separated list of server roles to generate cron jobs for
    -x, --crontab-command [command]  Default: crontab
    -v, --version

The part about --update-crontab isn't obvious, as it is tied to an identifier option. I get the impression that -i actually means install instead of --identifier? This was not obvious. I looked at https://github.com/javan/whenever/blob/master/bin/whenever to see if it made more sense, and I see that identifier is an optional arg.
I think:

The default should be to update the crontab, not overwrite an existing (yikes!)
the -i command should be more obvious of the intent.


[New] Create symbol styles from web styles

Description
This PR implements Create symbol styles from web styles in Visualization category.
URL to README: ReadME
Linked Issue(s)

swift/issues/4071

How To Test

Pan the map and zoom the map to see the symbols update once they load.
Tap the "Legend" button to open the legend.

Screenshots

Discussion

Should this sample include a status message overlay for the symbols/swatches loading similar to the one in the Display content of utility network sample?
This is my first sample back, so if you see anything that you think is off, I probably just forgot something so please let me know!

Removed philium's review due to flutter work.

@CalebRas, when I run the sample the info/code view disappears immediately after I tap the info button.

@CalebRas, when I run the sample the info/code view disappears immediately after I tap the info button.

I believe is due to a separate issue, #80.


More fixes

The second commit attempts to fix all references to storage that doesn't use the new state expiration interface. This is still a WIP because the changes that are left are in-depth tutorials, and we need the state expirations docs so we can point to the different kinds of storage that developers can use.

Preview is available here:http://soroban-docs-pr489.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr489.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr489.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr489.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr489.previews.kube001.services.stellar-ops.com/


Add an IR for BTOR2 to reduce the dependencies on the C parser

Modify the BTOR2 interpreter to use a new IR that does not depend on the BTOR2 parser written in C. I also added a suite of test BTOR2 programs to ensure that the interpreter remained correct with the new IR.

Going to close this for now since there's no one to push this forward at the moment


when using a dnode, conn throws an exception

When using a dnode, create a connect like this: taos.connect(host=self.host, port=self.port, user=self.user, password=self.pwd, database=self.db, timezone=self.tz).When I use this connect object to query sql twice,it throws an exception:[0x000b]: Unable to establish connection

But, When I create a connect like this: taos.connect(user=self.user, password=self.pwd, database=self.db, timezone=self.tz), it's all ok.In addition, the passing host and port are displayed with multiple dnodes without error too.

system info:

What version of TDengine you are using? Please check if the taosd daemon is still working or had been restarted?

@sangshuduo Hi
TDengine version: <IP_ADDRESS>
taospy version: 2.2.1
I'm sure the taosd daemon didn't restart.
I try again, like this:

taospy version is pretty old. Please use latest taospy with pip install -U taospy. And please upgrade your python to 3.7 or up since the taospy 2.4.0+ requests a newer Python.

Today I tried the latest version of taos,but the problem still persists.
taospy version: 2.6.10
python version: 3.7.14

Please try use 'taos' command line to execute same SQL. I guess you encounter a TDengine bug instead of python connector.

Could you please reproduce the problem then upload the taosdlog from the machine taosd running and taoslog here? It's better to clean old log first. The default log file path is /var/log/taos. Thanks.


task 20

Read the excel (consists of Lower Letters), and type into website (Vajrang.org - Uppercase Task) and get the result and write into one excel

@samkarne94
Task -20
Code verified.


call for data

Hi,
Thanks for your exciting work! Could you provide the data ("corocta.nrrd', "cardiac.mhd", "body.mhd", "rib.mhd", "neckcta.nrrd") used in the code? The data like "corocta.tar.gz" in the data folder can not be opened.
Thanks

By the way, could you give a detailed python example of corocta to StretchedCPR ?

data have been change to the third-party, can download from there.


Image Resizing

All images and code boxes seem to adjust to however wide the window is
This can look quite odd, especially when you set the window to fullscreen
There should be something to limit images to a certain size

@brandenchan we have control over the styling for all images, lets identify a few relevant examples that allow us to test a generic solution. Implementing and testing this once we know which cases we are trying to deal with should take no longer than ~1h.
My current assumption is that we might want to limit the max-height to the view height of the screen, but I am unsure whether this would have unwanted side-effects on other images.


Support branch instructions that define their blockparams

This would allow an invoke instruction to define a virtual register representing the return value and then pass this as as blockparam to the regular return block. And similarly define a virtual register representing the landingpad argument and pass it as blockparam to the block for the landingpad.

@bjorn3 and I were discussing this just now; to add a little more background:

invoke encapsulates both the call itself, and the (virtual) branch that is implied by the potential unwinding control flow. Separating them is problematic because the regalloc is allowed to insert arbitrary moves between instructions and we can't have any between the call and the "branch": if an unwind happens, it will not execute these moves.
modeling the regular (non-exceptional) return values as blockparams for the non-exceptional continuation makes sense because semantically the results only exist/are defined in this case: on unwind, the function hasn't actually returned values.

A thought does occur to me though: if we relax the second point above, this may become a bit simpler. Working backward from what we want to happen in the "backend" of regalloc: we want to allocate new register(s) for the call results; we want their liverange to start with the underlying call instruction. This is a little different from blockparams, which logically start at the successor block, so we have a little "stub" of a liverange just over the invoke/branch instruction anyway. What if we take that further, relax the results-as-blockparams, and do something like:
v1 = invoke ..., regular block1(...), exceptional block2(...)

block1(...):  ; regular-return (fallthrough) case
  (use v1)

block2(...):  ; exceptional case, reached implicitly via unwind
  (don't use v1, it won't have been written)

basically, the idea is to construct the RA2 problem as a conservative superset of the required allocations: the invoke results are allocated at the call, and in-scope in all blocks they dominate as normal, including the normal return path and exceptional return path; the fact that the call will not have written the result on unwind is a fact at a higher semantic level that we respect (by not reading the register on that path) in the CLIF.
The remaining question is then: can branches def values? I can't think of a specific case or check that would break this, but there may be some subtle interaction. In particular I believe that edge-moves are not a problem as long as invoke has two targets: this will force edge-moves to be placed in the successor blocks' heads rather than just before the branch. (The edge-moves come logically after the def so it would be a problem otherwise.)
Others have any thoughts?

In the unwind case there are also return values. These may be of different types than for the regular-return case, but generally do occupy the same registers. These need to be supported as they are often used to pass around the exception object itself.

This actually already works in regalloc2 without any changes needed. First, we must differentiate between 2 types of branches:

branch terminators can have multiple targets but cannot have blockparams.
jump terminators can only have 1 target and cannot have operands, but can have blockparams.

Notably, it's possible for branch terminators to have def operands. Any moves associated with these would be placed in the corresponding successor blocks.
You can build an invoke as a branch terminator which also defs 2 output values in fixed registers: the normal return value and the exception pointer. The normal return value is only used in the normal successor block while the exception pointer is only used in the landing pad.
The last commit in #170 extends the fuzzer to test this case.

Neat, that's I think essentially what I describe above except two defs (exception ptr as well). Hopefully a fairly straightforward change on the producer side!

You can build an invoke as a branch terminator which also defs 2 output values in fixed registers: the normal return value and the exception pointer.

Both the normal and exception return cases can have a variable amount of return values. For exception returns it is up to two registers. I guess one way to handle this would be to look at the signature of the called function to know how many normal return values there are and treat the rest as exception return values.

You can build an invoke as a branch terminator

How can I lower the block calls on the clif ir side to something that avoids blockparams on the regalloc side?

I think a reasonable design might be:

An invoke of a function with N return types (T1, T2, ...) and M exceptional returns (Exc1, Exc2, ...) always has a result tuple of N+M values: (T1, T2, ..., Exc1, Exc2, ...). The values of the former are undefined on exception, and the latter are undefined on normal return. If we wanted to keep out undefined behavior in the CLIF semantics, we could add a verifier rule that the values are only used in blocks dominated by the appropriate edge.
(if any pass that examines the invoke needs to know which are which, it can look at the signature of the function to know N, then get M from the number of total results)

The block-calls in CLIF are still lowered to blockparams provided by this "branch" as seen by regalloc; the only thing is that the function returns and exceptional values are not additional blockparams.

So to add an example, if we have
  fn0 = %f(i32, i32) -> (i64, i64)
block0(v1: i32, v2: i32):
  v3, v4, v5, v6 = invoke %f(v1, v2), block1(v1), block2(v2)  ;; v3, v4 are normal returns; v5, v6 are exceptional returns
block1(v7: 32):  ;; v7 is a normal blockparam
  ;; use v3, v4

block2(v8: i32):  ;; v8 is a normal blockparam
  ;; use v5, v6

and the regalloc metadata for the invoke is:

v1, v2 are early-uses (constrained per ABI)
v3, v4, v5, v6 are late-defs (constrained per ABI)
is_branch = true, two successors, blockparams of [[v1], [v2]]

Cross posting https://github.com/bytecodealliance/rfcs/pull/36 here because I think both discussions should be aware of each other.
Random notes on my preferences for the clif design side of things, since it is relevant to the discussion here about how we would lower/translate this to regalloc2 input:

I know this is super nitpicky, but I pretty strongly prefer try_call to invoke as far as naming the clif instruction goes, since the latter really doesn't imply anything to do with fallibility other than it happens to be the same name that LLVM chose.

I think we want to annotate landing pad blocks in clif so that the verifier can easily check that normal control doesn't flow to them. This is the idea behind the catch prefix (similar to the cold prefix) for blocks that is described in the linked RFC. Not sure if this makes sense for regalloc input as well or not; not clear to me that regalloc would want or need to treat such blocks differently or not.

@cfallin

An invoke of a function with N return types (T1, T2, ...) and M exceptional returns (Exc1, Exc2, ...) always has a result tuple of N+M values: (T1, T2, ..., Exc1, Exc2, ...).

To be clear, this would only be done in the regalloc2 side of things, right? That is, the clif would still terminate a block with a try_call and then the successor blocks would have block params? I feel pretty strongly that we want to have that shape of clif, and not rely on the verifier to check that the undefined values are not used in successor blocks that don't match the exceptionality of the return. I don't have strong feelings about the shape of the regalloc input tho.

@bjorn3

Both the normal and exception return cases can have a variable amount of return values. For exception returns it is up to two registers.

Is there any reason we can't start by simply fixing the amount of exceptional return values to exactly one or exactly two (whatever is sufficient for both wasm exceptions and clif's panic unwinding)? I feel like variable exceptional returns is a complication that we should be able to ignore for now. Of course, if this doesn't actually make anything simpler on the regalloc side of things, no need to artificially build that constraint in.

I think we want to annotate landing pad blocks in clif so that the verifier can easily check that normal control doesn't flow to them.

There is no fundamental reason why this is necessary. In fact for wasm lowering it may be beneficial if this restriction doesn't exist sich that throwing an exception can be done by directly jumping to the cleanup block while still sharing this block with the unwind target for calls. With this restriction in place wasm lowering would need to add an extra block whose sole purpose is to be marked as landingpad and jump to the real cleanup block.


[Feature Request]: trust: certificate renew functionality

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
For the purpose of running an OpenVPN server with internal certificates, I am missing a solution in the WebGUI that would renew the expired certificates that are generated by an internal CA.
Describe the solution you like
I would like an action icon next to the "info" icon for each certificate that would allow me to renew that certificate.
This is the exact functionality present in pfSense for as long as I remember. I didn't even imagined that it wouldn't be present in OPNSense. :(
Describe alternatives you considered
Export the expired certificate and its key, ran openssl x509 -x509toreq -in old.crt -signkey private.key to get a new csr and signed that CSR with my internal CA.
The problem is I can see both certificates (the old one and he new one) in the list and the new one has no key associated with it.
After all this I do have to also go and edit the user to link the new certificate and unlink the old one.
Even then, openvpn client export will not work properly as it keeps attaching the old certificate to the config. I would remove it, but then the key is not accessible anymore.
Additional context

tried the latest development release?

tried the latest development release?

No, but I will and provide feedback.
Thank you, @AdSchellevis!

Alright, I tested the development, this looks really nice!
I am providing feedback below, as promised.
When can we expect this to be rolled out to production? I see 24.7 is scheduled for July 2024, but there is no mention about the Trust related enhancements in the road map.
Expected functionality that now works:

I am able to reissue/renew the certificate in place, which means the private key stays linked with the new certificate

It looks like OpenVPN's "Client Export" is able to pick the certificate changes immediately

Issues I've found:

cannot link / create a user certificate from the user page: I get redirected to /system_certmanager.php?act=new&userid=1 which doesn't seem to be working, but I am able to create a certificate with the same common name as the username and OpenVPN will happily use it

when I reissued the certificate I did not go through all the fields, assuming there will be no change, however, the CN changed to internal-ca, which I noticed when checking the connection status on OpenVPN after re-exporting the certificate; I'd argue that the CN field should be readonly for a certificate reissue, but I think at least it should be pre-populated with the previous certificate CN.

OpenVPN's "Connection Status" throws an error about not being able to read the description when a connection is active, but it looks like it does show the description anyway.

Alright, I tested the development, this looks really nice!

Thanks, it was quite some work

When can we expect this to be rolled out to production? I see 24.7 is scheduled for July 2024, but there is no mention about the Trust related enhancements in the road map.

There is, see (base system) https://opnsense.org/about/road-map/

cannot link / create a user certificate from the user page: I get redirected to /system_certmanager.php?act=new&userid=1 which doesn't seem to be working, but I am able to create a certificate with the same common name as the username and OpenVPN will happily use it

Can you open a ticket for this? I'll take a look when I can. It might miss some glue to be able to support linking to it.

when I reissued the certificate I did not go through all the fields, assuming there will be no change, however, the CN changed to internal-ca, which I noticed when checking the connection status on OpenVPN after re-exporting the certificate; I'd argue that the CN field should be readonly for a certificate reissue, but I think at least it should be pre-populated with the previous certificate CN.

Also a ticket please.

OpenVPN's "Connection Status" throws an error about not being able to read the description when a connection is active, but it looks like it does show the description anyway.

Weird, but a separate ticket would be helpful to track this down.

There is, see (base system) https://opnsense.org/about/road-map/

Oh, indeed it is! I was looking for Trust but missed System Trust
I created 3 bug reports as requested.
Thank you for support, I'll wait for 24.7.


Compatible 2012

We've moved on from Meltano and are no longer maintaining this repository. Therefore I'm closing this PR.


AddressBookSystemTest: Missing wait for browser to load #642

Fixes #642

v1
@Zhiyuan-Amos submitted v1 for review.

[v1 1/1] AddressBookSystemTest: Missing wait for browser to load

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/643/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

The issue that this PR is fixing, will be fixed even more thoroughly by #645. As such, I will close this PR.


Hotfix : Fix ESM exports

V7.0.0 breaks typescript because of the exports, Fix #440
So, I update them like :

all root properties are for CJS
exports are used only by ESM

I also added default for bundler that doesn't handle import or require .
( in general, I also use .cjs extension for cjs files, and .cts for cjs typing, but maybe not needed for an hotfix )

Thank you, it works fine :)

Can verify this fixes #440

Probably good advice to not release major changes which accidentally do break thing on / close to NYE 😂

it does merging & released? i have same problem T_T

ping @eXon (in case you don't get notified) . This issue is blocking typescript builds, needing to go back to old version .
Can you at least allow workflow so I can check if the tests are passing on your Ci ?

@eXon can you re-allow the workflow please ? ( I will try to run tests, but scripts are not compatible with windows, and running them in wsl is extremely slow )

@thib3113 Would it be possible to resign your commit using Windows by skipping the pre-commit hook? You can do something like this: git rebase --exec 'git commit --no-verify --amend --no-edit -n -S' -i main

@eXon not sure if it's better ... but it's signed ...

@thib3113 Thank you for your contribution! I should be able to release 7.0.1 by tomorrow.


option for setting minimum install duration?

I was wondering if it would be plausible to add an option for minimum install time, like for example if you wanted the install to take at minimum 20 seconds to complete.
In my scenario I have a loading gif that I would like to finish its animation run before it is closed, not end of the world if its not a quick thing to do.

I think you can use gif animation for that purposes. If you have an idea, how to implement it or just would like this feature to be added, please, create an issue on https://github.com/electron/windows-installer


network.py

static method should not have "self" maybe

In VGG class.

Thank you for pointing out the problem! I have just fixed the part and now the codes can work fine.

thanks!


No need to check the empty of access

What changes were proposed in this pull request?
Remove the empty check of accessID.

Why are the changes needed?
I think there is no need to check the access id empty. It's used by AccessCandidatesChecker.
But if we dont enable it, we dont need to set acessid in spark conf.

Does this PR introduce any user-facing change?
No

How was this patch tested?
No need.

Codecov Report

Merging #41 (3e46d30) into master (4a51ff3) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
- Coverage     56.87%   56.81%   -0.06%
+ Complexity     1207     1204       -3
============================================
  Files           152      152
  Lines          8429     8429
  Branches        816      816
============================================
- Hits           4794     4789       -5
- Misses         3376     3379       +3
- Partials        259      261       +2

Impacted Files
Coverage Δ

...org/apache/uniffle/server/ShuffleFlushManager.java
76.70% <0.00%> (-1.71%)
:arrow_down:

...e/uniffle/server/storage/SingleStorageManager.java
65.57% <0.00%> (-1.64%)
:arrow_down:

.../apache/uniffle/coordinator/ClientConfManager.java
91.54% <0.00%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a51ff3...3e46d30. Read the comment docs.

I think it's a meaningful check. We shouldn't assume that users always do correct things.

But if we disable the AccessCandidatesChecker, the accessid is useless. It looks the accessid is bound to this checker and is not a general param.

But if we disable the AccessCandidatesChecker, the accessid is useless. It looks the accessid is bound to this checker and is not a general param.

But it's meaningful for current implement. I think we shouldn't remove it before we have another AccessChecker. And We think accessId is a general param.

Do u have any ideas @duanmeng @jerqi. I think we should remove the check.

Currently, we shouldn't remove it first. If we add any other AccessChecker plugin, we can remove it.

Currently, we shouldn't remove it first. If we add any other AccessChecker plugin, we can remove it.

Ok. I have to add a no-meaningful value  into it to pass this check.

So should i close this PR? @jerqi @duanmeng
It looks we should reserve this check currently.


Support for certificates with expiration date

Support for certificates with an optional expiration date. A certificate is a scale-encoded combination of the node's ID and (optional) expiration time. If the expiration time is None, the certificate does not expire.
The certifier will create expiring certificates if the expiration duration is set in the config.

There is a linter warning in profiler/src/main.rs that maybe can be fixed in this PR as well?

That's already fixed on the main branch :)


Resolve generic call expression type

Issue #16
The problem is that we should resolve generic type of argument to have an availability to check it with isNullableType.
For the new valid test case:
Old behavior:
undefined is passing as a parameter of type SetStateAction<S | undefined> for which the isNullableType is false.
New behavior:
undefined is passing as a parameter of type number | undefined | (((prevState: number | undefined) => number | undefined)) for which the isNullableType is true.

LGTM, thanks for contributing 🙂


Adding missing language key for api connection issues

I'm digging into this a bit more and the language keys are there, so there's some other problem. Action.js sets it like so:
        message: 'api.connection_to_endpoint_failed',
        details: 'api.connection_to_endpoint_failed_details',

which should be fine as long as the notification display runs it through $t(). I'm having trouble finding where this should be happening and isn't. I think... maybe this is all that's needed?
diff --git a/eosdac-material/src/store/api/actions.js b/eosdac-material/src/store/api/actions.js
index c4c24ab..cb66363 100644
--- a/eosdac-material/src/store/api/actions.js
+++ b/eosdac-material/src/store/api/actions.js
@@ -40,8 +40,8 @@ function apiDown(e,c,s) {
       c('NOTIFY',{
         icon: 'error',
         color: 'warning',
-        message: 'api.connection_to_endpoint_failed',
-        details: 'api.connection_to_endpoint_failed_details',
+        message: this.$t('api.connection_to_endpoint_failed'),
+        details: this.$t('api.connection_to_endpoint_failed_details'),
         textColor: 'black',
         autoclose: 8
       })

I'm having trouble testing it though. I tried testing locally against production but wasn't able to reproduce the error. Thoughts @piecesnbits ?


Changelog for arm-compute package

Is your feature request related to a problem? Please describe.
Should there be a changelog for arm-compute? I believe I see some other packages having changelogs. As it stands I want to update from 12.0.0 to 15.0.0 but am not sure what exactly has changed. It seems lot of the code is generated so it is hard to find needles in the haystack.
Describe the solution you'd like
A changelog would be nice especially for major version updates.
Describe alternatives you've considered
Perhaps there is a changelog somewhere that I'm missing. If so, please feel free close this and direct me there!
Additional context
None that I can think of.

Thanks for reporting this, we have a plan to automatically add changelog for JS SDK. Right now I will put it into the backlog.

@qiaozha
Will that be the case for just arm-compute or also other packages.
In particular I'm just looked for the changelog for @azure/arm-mediaservices but couldn't find any.
Since there was a major version update for me I'm concerned about breaking changes.

@qiaozha
Will that be the case for just arm-compute or also other packages.
In particular I'm just looked for the changelog for @azure/arm-mediaservices but couldn't find any.
Since there was a major version update for me I'm concerned about breaking changes.

Also other packages.

@JensForstmann we have started to add some changelog for our packages https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/compute/arm-compute/CHANGELOG.md, As this is our first next generation release, we just put the quickstart guide and the migration guide here. In the next releases, we will put the changelog here that contains what exactly has been changed since last version. feel free to let me know if you have other comments.


Don't persist credentials in actions/checkout

Fixes #2267
PR Checklist

[x] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[ ] All new changes are covered by tests
[ ] If GraphQL schema is changed, make generate has been run
[ ] If GraphQL schema is changed, GraphQL client updates/additions have been made
[ ] If OpenAPI spec is changed, make generate has been run
[ ] If ent schema is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

Failure of "ci/CI for unit tests" failure doesn't appear to be related to this change.

Integration test failure is due to HTTP 502 received from ClearlyDefined

made a bug report here: https://github.com/guacsec/guac/issues/2273

rebased so the CI will pass


Enter key always selects date

On pressing enter while focussing on with the 'tab' key on next or prev month and pressing 'enter' it will still select the date that is highlighted.
Great plugin btw. Any plans to keep supporting this?

Great plugin btw. Any plans to keep supporting this?

Thanks! Yeah, I plan to continue working on this and try to reach a stable release at some point, but no clear dates yet. Regardless, my aim is that it should be usable right now - The only drawback is that there may be breaking changes between patch versions.
I make use of this here, so the development on the two are sort of connected fwiw: https://github.com/PixelBoii/time-tracker

On pressing enter while focussing on with the 'tab' key on next or prev month and pressing 'enter' it will still select the date that is highlighted.

I'll be sure to have a look into this 👍

This should've been fixed in https://github.com/PixelBoii/vue-headless-datepicker/releases/tag/v0.0.14 so I'll go ahead and close this, but please let me know if you still have issues with this.


Restructure readme

Co-Authored-By: alexstrat<EMAIL_ADDRESS>Closes #12

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add HRMP guide

This is a follow up to #1007, in order to include it in main-md.
Original author: @al3mart.

@al3mart : is there anything to add from this ? I haven't looked in much detail, but if separate guide we can do it in a separate PR.

@sacha-l the linked guide covers the steps to open channels with a common good parachain, concretely what is shown is openning channels with Statemine.
The info I provided shows how two community parachains can stablish channels between each other.
So, both documents compliment each other, yet some of the steps to follow are the same.

Ok - are we good to merge this as is then? cc @al3mart


why is the css  invalid?

I installed the react-slick and slick-carousel.
the below is my part code:
import React from 'react';
import ReactDOM from 'react-dom';
import Slider from 'react-slick';
// import 'slick-carousel/slick/slick.css'
// import 'slick-carousel/slick/slick-theme.css'
const slideConfig = {
dots: true,
infinite: true,
speed: 500,
slidesToShow: 1,
slidesToScroll: 1
}
<Slider {...slideConfig}>

1

2

3

4

5

6

             </Slider>

Are you using webpack ?

yes

can't the webpack be used?

Have you added config to handle css in webpack ?
Some thing like this
https://github.com/akiran/react-slick/blob/master/webpack.config.js#L22-L26

No,I didn't set the config,but I have added config to handle css in webpack,the demo's style is still invalid.
the below is my webpack.config.js
loaders: [
{
test: /.js$/,
exclude: /(node_modules|bower_components)/,
loader: 'babel',
query: {
presets: ['es2015', 'react']
}
        },
        { test: /\.css$/, loader: 'style-loader!css-loader' },
        {
            test: /\.scss$/,
            loader: 'style!css!sass?outputStyle=expanded&' + 'includePaths[]=' +
            (path.resolve(__dirname, './node_modules'))
        }
    ]

I have installed the slick-carousel. how to use it?is it the component's style?

@akiran
Could you help me to solve the problem?

Why have you commented out the lines
// import 'slick-carousel/slick/slick.css'
// import 'slick-carousel/slick/slick-theme.css'

These are important. Once I added these it worked for me

@davidglbr
if I added the code of css,there would be a lot of errors.
./~/slick-carousel/slick/ajax-loader.gif
Module parse failed: C:\myself\ReactjsDemos\slick_demo\node_modules\slick-carousel\slick\ajax-loader.gif Unexpected character '' (1:7)
You may need an appropriate loader to handle this file type.
@ ./~/css-loader!./~/sass-loader?outputStyle=expanded&includePaths[]=C:/myself/ReactjsDemos/slick_demo/node_modules!./~/slick-carousel/slick/slick-theme.css 6:118-146
./~/slick-carousel/slick/fonts/slick.eot
Module parse failed: C:\myself\ReactjsDemos\slick_demo\node_modules\slick-carousel\slick\fonts\slick.eot Unexpected character '' (1:0)
You may need an appropriate loader to handle this file type.

I installed file-loader and url-loader,the code can run,but its style still has some bug.
the nextButton and preButton can't be show.

I have solve the problem,The default color is white,so my style is different from the demo.sorry,it's my fault.

@codepandy I am running into this same problem. What did the default color have to do with your solution?

nevermind, I figured it out. I needed to install file-loader and url-loader in order for webpack to be able to read the font and image files

@frankolson can you provide an example of how you used file-loader or url-loader to resolve this? I have them installed, but still getting errors like "Cannot resolve module 'fonts/slick.svg'"

@frankolson
I created a .scss file, the below is the file's code.
`
@import "../node_modules/foundation-apps/scss/foundation.scss";
$primary-color: #00558B;
$slick-font-path: "/fonts/";
$slick-arrow-color: $primary-color;
@import "../node_modules/slick-carousel/slick/slick.scss";
@import "../node_modules/slick-carousel/slick/slick-theme.scss";
`
the $primary-color is the customized color.

@SlowFamily sure:
First I installed file-loader and url-loader:
npm install file-loader url-loader --save

Then in my webpack.config.js file I configured it like so:
module.exports = {
  module: {
    rules: [
      ...
      {
        test: /\.(eot|woff|woff2|ttf|svg|png|jpg|gif)$/,
        loader: 'url-loader?limit=30000&name=[name]-[hash].[ext]'
      }
    ],
  },
};

That should take care of all the font files and gifs, plus some image files.

i can't find webpack.config.js file in next.js project :(  or should i try to find it in node_modules ?

i couldn't find webpack.config.js file in next.js project :( or should i try to find it in node_modules ?

you need next.config.js in your root.
add this to your next.config.js
const withSass = require('@zeit/next-sass');
const withCSS = require('@zeit/next-css');

module.exports = withCSS(withSass({
    webpack (config, options) {
        config.module.rules.push({
            test: /\.(png|jpg|gif|svg|eot|ttf|woff|woff2)$/,
            use: {
                loader: 'url-loader',
                options: {
                    limit: 100000
                }
            }
        })
        return config
    }
}))

also install
npm i -S url-loader


Reduce tiling artifacts with normal map and foam

This adds stochastic sampling to ocean normal and foam shaders to reduce tiling. Shader functions are from: https://www.reddit.com/r/Unity3D/comments/dhr5g2/i_made_a_stochastic_texture_sampling_shader/
This is mostly useful for calmer water and lower tiling values on the normal map.
Stochastic sampling disabled

Stochastic sampling enabled

Thanks for this @skaughtx0r and apologies for the long delay getting back to you.
Very useful code!
I'm not sure about merging it in mainly from a perf perspective - i think with flow enabled we already take 8 samples of each texture, and this would make it 24 which may be a bit excessive to ship to everyone. There's probably smart strategies to reduce this a bunch. We take 2 samples to have panning normals, and then we do this at 2 different scales (to break up patterns in normal maps and to make normals work in the distance), then we do this twice to animate the texture when flow is enabled. Perhaps these different techniques coudl be combined/share samples, rather than exploding combinatorially!

Thanks for taking a look at this, yeah I was a little concerned with the amount of texture samples, but I didn't notice too much of a performance hit. Not sure if I'd be able to figure out how to optimize it myself.

Sure. I'm happy to have this open and at some point in the future my curiosity will get the better of me and i'll come back and do some tests :). Til then!

I'm ok if you want to just close this PR (to clean things up). I found that this is way too expensive on lower-end hardware, I ended up just using a larger higher resolution normal map instead. Also, the tiling isn't super noticeable in the foam anyway except around the shorelines.

I made a task on our internal list in the Long Term bucket to revisit this. I will close for now. I'll report back if/when we do experiment with this.
Thanks again for sharing this and for the info.


Add option on SDK to disable reloading dapp after disconnect

Summary

Added option on SDK to disable reloading dapp on disconnect
Added feature to disable reload of page and emit "accountsChanged" event on disconnect (if option set true)
Feature is optional due to lack of compatibility with existing dapps and aggregator libraries

How did you test your changes?
locally with the following dapps:

Uniswap
Compound
Zapper
Opensea
Curve
Sushiswap
AAVE
Balancer
Prettier-Test-Dapp

Review Error for bangtoven @ 2022-05-31 17:24:40 UTC
User failed mfa authentication, see go/mfa-help

This PR will be merged, but will require an update on the Coinbase Wallet extension in order to be full functional. Will post an update here once that change has been published.

@jeongmincho Once this is added to the Coinbase Wallet extension, can expect this option to work for all users? Or can I not assume that all wallet users will be on the latest version of the sdk at runtime?

once added to the extension, you can expect this option to work for all users with the latest version of the extension (which will have both the update and be using the latest version of the SDK)


UX: Status bar select namespace should directly show the list of available namespaces

Clicking on current namespace name in status bar should show the (second) prompt which shows the list of available namespaces.
Why show the first prompt which asks user to type the name of the namespace - which is possible to be typed in the second prompt anyway - which nicely works as a filter.
I understand the current implementation may have been done for performance reasons and for good typists.

.

Hi @sandipchitale, thanks for opening this and sorry for the really late response. We are few and also busy on other projects.
I remember that we made a similar change for another command and the original workflow (first step -> second step) can be re-enabled by a setting or viceversa. I guess we can do the same here, so users can decide the behavior they prefer.
And you're right, the current implementation was made for performance reasons. I'll propose a PR asap. Thanks for your patience!

@lstocchi Oh thanks you. Looking forward to PR getting into the extension.


Price of Crushed Slag cannot be determined

It appears that the 0.1.7 release affected the ability to price a number of things. Another example is when doing cooking, it's often easier to set a buy order of Raw Meat, which would be used to calculate all prices instead of adding carcasses, but that no longer seems to work.  Additionally, some items won't price, like crushed slag with mining.

It's actually the 0.1.6 update causing you this problem. I'll have a look at fixing it.

I would like to see your shop for the cooking example. It should not be problem.
The 0.1.6 update allows you to have something in your buy and sell orders, and then have the mod update the buy price. For slag it obviously doesn't work, because there is no recipe with slag being the main product.

I apologize, there's some behavior that isn't intuitive but makes sense mathematically (e.g. making primary products a negative value if a byproduct has a high value.)  The cooking issue was the same problem as the slag, where we had a player who was both buying and selling tomato which doesn't have an associated crafting recipe.

Yeah, I'm thinking of changing the behaviour, I'm just not sure which way to swing it. i.e. do you treat the sell price as the source of truth and update the buy price, or do you keep the buy price the same and update the sell price? I'm leaning towards keeping the buy price as the source of truth

Yeah, there's some interesting stuff with Campfire Cooking and Cooking where the price of Tallow is calculated using the scrap meat recipe (as a primary product), instead of something like Crispy Bacon (where it's a byproduct). but if you want to sell both Campfire Cooking goods and Cooking, you need to buy scrap meat.

I'm not sure how the cooking guy had an issue with the tomato price. Before my latest changes in 0.1.8 the mod only updated craftable item prices. I've changed it now though and it's updating the sell price of any item that's listed as both a buy and sell item:

The slag issue I also fixed:


Appstudio update test-component-pac-ewlu

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-ewlu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
22 seconds
sast-snyk-check

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
49 seconds
clamav-scan

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
6 seconds
sbom-json-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
4 seconds
show-sbom

Pipelines as Code CI/test-component-pac-ewlu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
39 seconds
sast-snyk-check

✅ Succeeded
1 minute
build-container

✅ Succeeded
33 seconds
inspect-image

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
7 seconds
sbom-json-check

✅ Succeeded
6 seconds
show-summary

✅ Succeeded
7 seconds
show-sbom


src folder no longer being delivered by bower

Somehow we lost the src folder with all the less files in it when pulling in the latest version with Bower. I can't identify any ignore statement in bower that would have taken it out. @jnweaver any ideas? Am I missing something?

Hmm, I'm actually seeing src when I just installed it now. And I'm seeing all the other directories that begin ./ I should have looked at that closer. I think the ignore pattern there should be just /examples etc, same as a .gitignore file. But I'm not sure why you're not seeing src.

Jared, try installing the bowerignore branch and see if that works for you. It's working as expected for me.  You should have dist, src, README and the bower.json file.
Here's a sample bower.json file to use: https://gist.github.com/jnweaver/8125067e4533d29753e8

I uninstalled and reinstalled uw-ui-toolkit on MyUW and it worked. And yep, I got all the ./ folders too, so that's not the right syntax. The updates in that branch look correct to me.

Just released 0.2.2 to fix this


Update cache-how-to-active-geo-replication.md

Explain the impact of force unlinking

@flang-msft
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@chantalolieman - this was merged in this @chantalolieman - this was merged in this https://github.com/MicrosoftDocs/azure-docs-pr/pull/290374 so that I could edit it in the private repo. Thanks

#please-close


gcpGCPSQLAllowedAuthorizedNetworksConstraintV1:22: rego_unsafe_var_error: var _ is unsafe

When running the config validator as a rpc server, the following error is observed and will block the server from starting:
2019/05/23 10:11:12 Failed to load server rpc error: code = InvalidArgument desc = 1 error occurred: templates.templates.gcpGCPSQLAllowedAuthorizedNetworksConstraintV1:22: rego_unsafe_var_error: var _ is unsafe

This issue was present in OPA 0.10.6. It's been fixed in 0.10.7. Will need to rev the config validator library and its dependencies.


Fix "TypeError: _assign_kwargs() got an unexpected keyword argument '…

…distance'"
At the moment when you try to use GeoDistanceQuery you will get:
Traceback (most recent call last):
  File "test.py", line 208, in <module>
    for city in cities:
  File "test.py", line 103, in get_by_coordinates
    GeoDistanceQuery('1km', (lon, lat)),
  File "/my-path/venv/lib/python3.6/site-packages/couchbase/fulltext.py", line 697, in __init__
    _assign_kwargs(self, **kwargs)
TypeError: _assign_kwargs() got an unexpected keyword argument 'distance'

Problem occurs on Python 3.6.4 and Python 3.4.3

Thanks for your contribution! I will look at this locally - in the meantime, please have a look at the CLA and if you are happy with it, please confirm your agreement. Feel free to know if you have any questions about this. Many thanks, Ellis.


Airframe config

@DonLakeFlyer This brings in automatic parsing of the ROMFS dir and generates the airframes.xml in the firmware file.

Reviewed, good stuff! Just some small comments.


First/Next iteration and disabled elements

The First/Next iteration mechanism skips disabled elements. A user might want to iterate over the elements and enable some disabled elements in a loop.
That is a bit unexpected for users but is simple to change. This might be because the original code has few validations and could probably return junk data for those elements.
Adding a new pair of functions Settings_Set_SkipDisabled and Settings_Get_SkipDisabled to set this behavior seems ideal, as well as environment variable to change it globally on startup.

I imagine three states will be required:

Current behavior, for compatibility with the official OpenDSS. This should be the default for a while.
Iteration including disabled elements, coupled with empty/null/NaN values in results (e.g. AllNames, All...).
Iteration excluding disabled elements, excluding also the elements from results.

The code for iteration of most elements was refactored to use two general functions for circuit elements. Only circuit elements have the enabled property and checks, to we can toggle the iteration of disabled elements using these two new functions easily:
https://github.com/dss-extensions/dss_capi/blob/e2ce3b703c76dd1d92f46dae2bd913c52112b1b1/src/CAPI/CAPI_Utils.pas#L519-L559
I'll test if there is any obvious issue or crash for disabled elements before fully exposing this in the API.


Fix: failing pipeline fixed

Fixes a pipeline issue where concurrent execution of package and example unit tests resulted in failures. The tests were passing when run independently. This commit addresses the concurrency problem by consolidating both test jobs into a single unit-testing job. The changes ensure a more stable and reliable CI pipeline.

The issue https://github.com/gofr-dev/gofr/issues/198
Should be addressed by this Merge request

I have identified few issues. Please consider this as a draft. Let me fix the issues first

Also find a way if we can run it concurrently such that the overall time is reduced.
Moving forward there will be lot more test and examples running sequentially will take more time.

Sure let me check this once


Auditing failed of request: encoding failed: no kind "Scale" is registered for version "apps/v1"

Report
I see a lot of warnings in kube-apiserver logs about 'no kind "Scale" is registered for version "apps/v1"'
Probably these warnings can lead to increased apiserver latency.
Expected Behavior
No errors/warnings
How to avoid such errors/warnings to appear?
Actual Behavior
A lot of warnings in kube-apiserver logs:
W0302 11:11:54.459345       1 request.go:161] Auditing failed of  request: encoding failed: no kind "Scale" is registered for version "apps/v1" in scheme "k8s.io/kubernetes/pkg/api/legacyscheme/scheme.go:30"

At the same time in keda-operator logs I see this event:
2021-03-02T11:11:54.467Z    INFO    scaleexecutor   Successfully updated ScaleTarget    {"scaledobject.Name": "react-worker", "scaledObject.Namespace": "iris-react", "scaleTarget.Name": "react-worker-cli", "Original Replicas Count": 0, "New Replicas Count": 1}

Steps to Reproduce the Problem

EKS cluster 1.18/1.19
deployment with apiVersion: apps.v1
ScaledObject with metrics-api scaler.

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: worker
spec:
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: worker-cli
    envSourceContainerName: worker-cli
  pollingInterval: 30
  cooldownPeriod:  120
  minReplicaCount: 0
  maxReplicaCount: 10
  advanced:
    restoreToOriginalReplicaCount: false
  triggers:
  - type: metrics-api
    metadata:
      targetValue: "50"
      url: https://api.endpoint.com/queue/
      valueLocation: "main_queue.value"

Logs from KEDA operator
2021-03-02T11:11:54.467Z    INFO    scaleexecutor   Successfully updated ScaleTarget    {"scaledobject.Name": "react-worker", "scaledObject.Namespace": "iris-react", "scaleTarget.Name": "react-worker-cli", "Original Replicas Count": 0, "New Replicas Count": 1}

KEDA Version
2.1.0
Kubernetes Version
1.19
Platform
Amazon Web Services
Scaler Details
metrics-api

Confirmed seeing this in eks/1.18 w/ keda 2.1.0 as well.

Weird, I am curious to here whether you face this issue with 2.2 as well.

I see the same errors with 2.2.0 as well.

Unfortunately I am not able to reproduce the issue (on OpenShift), but it looks to me as a problem in kubernetes apiserver. We are using kubernetes Scale kind to initiate the 0<->1 scaling, but the apiversion for this kind is autoscaling/v1 not apps/v1.

Btw you haven't seen this with KEDA 2.0.0?

IDK, didn't check the logs when KEDA 2.0.0 was installed.


Add more help text and in-app guidance so people know where to focus and what the field labels mean (5/2023 Sprint)

Need more in-app guidance, can probably wait until LWC release

The LWC wizard should have a bunch more help. I'm going to close this and if needed we can open new issues for any specific changes needed.


Add unit tests for Schema/Resolver generation

General idea is to build unit tests for schema resolver generation by inspecting output from visitor. We can also use validate function for resolver output. Compile it and see if schema has required fields etc.

CC @craicoverflow let's chat here how we see this done

I think we might simply need to start with simple test using some advanced schema like here: https://github.com/Shopify/graphql-design-tutorial/blob/master/TUTORIAL.md
Then we can extend it over time once development moves.

The validate function accepts type GraphQLSchema - something which we do not seem to use anywhere.
Do you think Graphback should be refactored a little bit to try and use this?
This will require a little bit of investigation to see how it works now/how it could work.

Deifnietly graphback needs to be refactored as we operate on strings that are very hard to deal with. See also https://github.com/aerogear/graphback/issues/298
To get GraphQLSchema from string we can simply do buildASTSchema(parse(type...)) but.
we can simply do parsc

on hold for new architecture


mavlink: increase stack 2650 -> 2848 bytes

Seems related to the NuttX upgrade.

@davids5 this appears to be another case where stack usage appears to have decreased after increasing stack. This does seem to have stopped more of the intermittent hard faults though, so I'm going to keep the increase until we figure out what's going on.


Fix DeleteCommand usage message

Fixes the erroneous message made in DeleteCommand.java line 24 from https://github.com/CS2103-AY1819S1-F10-2/main/pull/96

Pull Request Test Coverage Report for Build 261

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 92.478%

Totals

Change from base Build 257:
0.004%

Covered Lines:
1549

Relevant Lines:
1675

💛  - Coveralls


Distinguish when MinXcmFee is not registered and FeeNotEnough

Signed-off-by: Georgi Zlatarev<EMAIL_ADDRESS>A few small changes to improve debugging and readability:

Added a specific error to specify MinXcmFee is not registered, to distinguish between this case and FeeNotEnough
Refactored MinXcmFee  return an Option, so implementers don't have to use u128::Max for unregistered locations.
Adjusted existing test cases

please use cargo fmt to format

please use cargo fmt to format

please use cargo fmt to format

should be clean now.

Test is failing

Btw I have a related test case that I'm not sure if it's an issue in my setup or the xtokens code. The case is the following:
Alice has 100 of ParaB's native token on ParaA and wants to send it back to ParaB, but wants the fee to be paid with 50 of the relay chain asset. The MinXcmFee for ParaB's native token reserve is set to 40 on ParaA.
On the sender side, the fee > min_xcm_fee so we don't hit FeeNotEnough error and both xcm messages get dispatched to ParaB.
Then the first message arrives on ParaB (via the relay chain), and eventually deposits assets - min_xcm_fee ( 50 - 40 = 10 with free execution) of the relay chain asset into ParaA's sovereign account on ParaB.
Then the second message arrives on ParaB and tries to withdraw the rest of the fee (40, which is the min xcm fee) from ParaA's sovereign account on ParaB, but it only has 10, so it fails.

I don't really get it. Can you share the failing test?

I don't really get it. Can you share the failing test?

Yeah take a look at this test in our repo. It's a little long but essentially register ParaA, ParaB, and relay asset on both ParaA and and ParaB. Also min_xcm_fee for ParaB is registered on ParaA.
Then Alice sends some of ParaB asset to herself on ParaA and mints some of the relay asset to herself on ParaA.
Then Alice sends some of the ParaB tokens back, using relay chain asset as fee.
You can see from the asserts on ParaA and ParaB that things work correctly when fee_amount is 50 and min_xcm_fee is 10.
If you change min_xcm_fee to 40, the asserts on ParaA (sender chain) will be ok, but the asserts on ParaB (receiver) will fail. This is because the ParaA sovereign account received only 10 of the relay chain asset, when we encoded min_xcm_fee as fee when we sent the second to-reserve xcm message, so there's not enough to withdraw into Holding and execution stops at the withdraw_asset instruction.

I think your testcase is same as: https://github.com/open-web3-stack/open-runtime-module-library/blob/3576772a896e039abf07c57e1efa305e6c0cddb0/xtokens/src/tests.rs#L717-L778
sender should make sure have enough relaychain token as fee.

Also why do we need to subtract min-xcm-fee here https://github.com/open-web3-stack/open-runtime-module-library/blob/master/xtokens/src/lib.rs#L558
Take for example case of sending USDT back to Statemine with free execution everywhere to illustrate the point. After both messages get received, my parachain's sovereign account will receive fee_amount - 2 * min_xcm_fee and my account will receive min_xcm_fee , so 1 min_xcm_fee amount seems lost.

Also why do we need to subtract min-xcm-fee here instead of sending the full fee amout to the relay (and rerouted to parachain) https://github.com/open-web3-stack/open-runtime-module-library/blob/master/xtokens/src/lib.rs#L558 Take for example case of sending USDT back to Statemine with free execution everywhere to illustrate the point. After both messages get received, the sender's parachain sovereign account will receive fee_amount - 2 * min_xcm_fee and the receiver account will receive min_xcm_fee , so 1 min_xcm_fee amount seems lost.

If we send all fee_amount to relaychain, then there're none left relaychain token used to send direct to Statemine, But Statemine current only support relaychain token to buy execution fee, so this xcm execution will failed.
Current implementation is split into two xcm, first one is (fee_amount-min_xcm_fee) KSM to relaychain then to Statemine, second one is min_xcm_fee KSM & USDT direct to Stemine.
If we send fee_amount KSM to relaychain then to Statemine(first one), then second one is USDT direct to Statemine, it'll failed in Statemine side.

Also why do we need to subtract min-xcm-fee here instead of sending the full fee amout to the relay (and rerouted to parachain) https://github.com/open-web3-stack/open-runtime-module-library/blob/master/xtokens/src/lib.rs#L558 Take for example case of sending USDT back to Statemine with free execution everywhere to illustrate the point. After both messages get received, the sender's parachain sovereign account will receive fee_amount - 2 * min_xcm_fee and the receiver account will receive min_xcm_fee , so 1 min_xcm_fee amount seems lost.

If we send all fee_amount to relaychain, then there're none left relaychain token used to send direct to Statemine, But Statemine current only support relaychain token to buy execution fee, so this xcm execution will failed. Current implementation is split into two xcm, first one is (fee_amount-min_xcm_fee) KSM to relaychain then to Statemine, second one is min_xcm_fee KSM & USDT direct to Stemine. If we send fee_amount KSM to relaychain then to Statemine(first one), then second one is USDT direct to Statemine, it'll failed in Statemine side.

Yes, of-course, thanks for re-explaining the code. For a minute there I though that assets_to_dest did not include the fee_to_dest and that it was magically being withdrawn into the holding register of Statemine without being included in the WithdrawAsset instruction... :D


Meta-click on table entries should open the drilldown in a different split

With inline sidecars, it is not possible to have a focus+context interaction model, like we used to with a global sidecar. The suggestion here is to offer a meta+click behavior (e.g. command+click on macOS) that will open the drilldown in a new split, if the current tab is not yet split, and otherwise drilldown in that existing other split.

Here, first I meta-clicked a few times. Note these requests were sent to a different split (the first one creating that new split). The last click was a regular click.


Create Lambda that fetches collection IDs + submits to batch job

fetches collection IDs for every published and private collection in the corpus
Edge case: don’t fetch collection ID for public collections with open revisions, but do fetch the revision ID
Output collection ID list such that an AWS Batch Array Job can use it to trigger Jobs

We can use business logic to make this happen.


(MAINT) fixed broken host_prebuilt_steps spec tests

:red_circle: Test failed.
Refer to this link for build results: http://jenkins-beaker.delivery.puppetlabs.net/job/Beaker Combined Smoketest/401/

failures unrelated to change

Failures unrelated to patch.


The morphological analysis results of bareunpy and Rbareun are different.

"평가가 차가워지고 있다"
bareunpy: "평가"+"가"+"차가워지"+"고"+"있"+"다"
RBareun: "평가"+"가"+"차갑"+"어"+"지"+"고"+"있"+"다"
"15일과 16일 양일간"
bareunpy: "양"+"일간"
RBareun: "양"+"일"+"간"
"어린잎채소"
bareunpy: "어린"+"잎채소",
RBareun: "어리"+"ㄴ"+"잎"+"채소"
"창업 8년차인 젠큐릭스"
bareunpy: "8"+"년"+"차인"+"젠큐릭스",
RBareun: "8"+"년"+"차"+"이"+"ㄴ"+"젠큐릭스"
RBareun is showing better results than bareunpy.  What could be the reasons for this to happen?

@sdkparkforbi
In bareunpy, you can select the options "auto_jointing" and "auto_spacing". They are set to True by default. If you don't enable this feature, the result will be the same as RBareun, but RBareun is still only available by default. This will be patched to be selectable in the future.
Example of turning off the feature in bareunpy.
response = my_tagger.tags([text], auto_jointing=False, auto_spacing=False)
Bareun performs morphological split, then performs the spacing function, and after applying the spacing, it gives the appropriate tagging to the stem. It post-processes the tagging results by consulting several built-in dictionaries, as this can be useful for some people. If syntactic morphology results are important to you, you may want to turn that option off.
For example, 차인("cha-in (someone who enjoys drinking tea.)") and 잎채소("leafy vegetable") are listed as dictionaries in the 우리말샘(Korean Woorimalsam dictionary). (https://opendict.korean.go.kr/search/searchResult?focus_name_top=query&query=차인)

We also set the default values of auto_spacing, auto_jointing to TRUE in RBareun. Each value can now be referenced and specified as tagged$auto_spacing, tagged$auto_jointing.

@sdkparkforbi
According to your report, without auto_spacing and auto_jointing returns more reasonable results.
I've found some logical errors on handling auto_jointing option, it will be fixed at release v2.2.0.
Thanks.