forkEvery = 1

Pushing for eventual collaboration.  First, set forkEvery = 1 and fix failing tests.

Test failures are expected :-)

@heeheehee-kolmafia @BadHorseMonkey @gausie
Help?  Test passes on my machine but not here.  How do I force GitHub to run the Windows and Mac tests even if the Linux test fails?  The failure is a CustomScriptTest show_skills.txt and it looks like a whitespace issue.
Also I'd be much happier if someone else approved #183 or continued the discussion in light of what is happening here.  My intention is to have everything working with 1 fork and then try and consolidate what works to isolate tests in  ClearSharedState.

I had a different set of changes in mind:

initialize KoLmafia.lastUpdate = ""; instead of " "
set Preferences.saveSettingsToFile in milkSetup().

(as in https://github.com/heeheehee-kolmafia/kolmafia/commit/429adac32fbb4681b9b369cfad5ecacf902b2f06)
I guess you could also just change ClearSharedState to be a BeforeAllCallback instead of an AfterAllCallback.

initialize KoLmafia.lastUpdate = ""; instead of " "

Yeah.  I think I am going to introduce a NO_MESSAGE constant and use it everywhere.  The core issue is that some non-test portions of the code think no message is "" but some think it is " ".

set Preferences.saveSettingsToFile in milkSetup().

That did not change any failing tests to passing tests :-(

I guess you could also just change ClearSharedState to be a BeforeAllCallback instead of an AfterAllCallback.

I feel like we are talking past each other on ClearSharedState.  You focus on Before/After but my experience with preferences has been that All/Each is the root of the solution.  I suspect you know something I don't.  In any event Step 1 for me is to get all known tests working with numFork=1.  When that is the case then I will try and consolidate the setup and cleanup needed to make the tests work in one place, i.e. ClearSharedState.
No love for #183?  :-)

I have a solution, but it may not be a good solution.  I do not know why in one case we get a leading CR and in the other two we do not.  Or, indeed if it's consistent.

I have a solution, but it may not be a good solution. I do not know why in one case we get a leading CR and in the other two we do not. Or, indeed if it's consistent.

I think I would like to make this non-Draft, commit to main after review/discussion or time and then start a new effort to consolidate all of the state preservation and clearing in ClearSharedState.

I'm going to commit and then circle back to clarify the file utilities test and start consolidating things into CkearSharedState.  Not having this committed is an issue because the state of test\root does not clear when changing branches.


Use ncc and remove node_modules

This is a prototype of using https://www.npmjs.com/package/@zeit/ncc to bundle all of our code into a js single file per action, instead of having to ship everything. This means we can remove the lib and node_modules directories from the repository.
Ncc is essentially a wrapper around webpack, but it provides a nicer interface for node projects. Using webpack directly would also be an option, but it would require slightly more setup. If it turns out ncc doesn't offer us enough flexibility then I wouldn be opposed to that.
The diff is a bit big for GitHub to display, but here's a summary of what has changed (excluding the node_modules and lib directories).
> git diff --stat master . ':!node_modules' ':!lib'
 .github/workflows/pr-checks.yml             |   30 +-
 .gitignore                                  |    2 +
 analyze/action.yml                          |    2 +-
 analyze/lib/README.md                       |    1 +
 analyze/lib/index.js                        |    2 +
 analyze/lib/index.js.map                    |    1 +
 analyze/lib/sarif_v2.1.0_schema.json        | 3350 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 autobuild/action.yml                        |    2 +-
 autobuild/lib/README.md                     |    1 +
 autobuild/lib/index.js                      |    2 +
 autobuild/lib/index.js.map                  |    1 +
 init/action.yml                             |    2 +-
 init/lib/README.md                          |    1 +
 init/lib/index.js                           |    2 +
 init/lib/index.js.map                       |    1 +
 init/lib/inject-tracer.ps1                  |    9 +
 src/tracer-env.ts => init/lib/tracer-env.js |    9 +-
 package-lock.json                           |   12 +-
 package.json                                |   13 +-
 src/setup-tracer.ts                         |    4 +-
 src/tracer-env.js                           |   18 +
 upload-sarif/action.yml                     |    2 +-
 upload-sarif/lib/README.md                  |    1 +
 upload-sarif/lib/index.js                   |    2 +
 upload-sarif/lib/index.js.map               |    1 +
 upload-sarif/lib/sarif_v2.1.0_schema.json   | 3350 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 26 files changed, 6773 insertions(+), 48 deletions(-)

Some things to note:

The setup-tracer.js file wasn't being compiled because it isn't executed in the normal way but is instead passed to CodeQL. To get around this I've converted it to javascript manually.
Those sarif_v2.1.0_schema.json and other files have been copied from src to the output directories. I view this is a bit unnnecessary and annoying but I haven't found a nice way to stop it. We could probably change the place where we reference this file to comfuse the bundler, but that seems counterproductive. In fact for setup-tracer.js and inject-tracer.ps1 I modified the code so the builder would recognise the reference and copy the file.
There's going to be a bit of duplicate between the various index.js files, but this keeps the entrypoints separate so we can just run the file. We could probably change this if we wanted so there's only one file.
The -m arguments means the index.js files are minimised. This isn't really necessary or hugely helpful other than making our repository a bit smaller.
The -s argument means we're generating source maps, but I explicitly pass --no-source-map-register to avoid generating sourcemap-register.js files. I haven't seen these files before, and googling didn't help me find out what they are for, so I disabled them.
Unfortunately ava doesn't support running typescript files directly and you have to pre-compile them and then run ava of the js files. Therefore I've added a call to tsc when running the tests. This means the lib directory is still getting used, but only for the tests, and it is excluded from the repository. It also slows down the tests a bit but for me they take 11 seconds which is hopefully still acceptable.

Merge / deployment checklist

Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!

[ ] CodeQL using init/analyze actions
[ ] 3rd party tool using upload action

[ ] Confirm this change is backwards compatible with existing workflows.
[ ] Confirm the readme has been updated if necessary.

This is awesome @robertbrignull! I am obviously a big fan of this change 😃
Perhaps as a next step we could even compile a single "binary" which all actions could use as their runs.main and control what command to run by means of an input argument. For example:
name: 'CodeQL: Init'
description: 'Setup the CodeQL tracer'
author: 'GitHub'
inputs:
  tools:
    description: URL of CodeQL tools
    required: false
    default: https://github.com/github/codeql-action/releases/download/codeql-bundle-20200601/codeql-bundle.tar.gz
  languages:
    description: The languages to be analysed
    required: false
  token:
    default: ${{ github.token }}
  matrix:
    default: ${{ toJson(matrix) }}
  config-file:
    description: Path of the config file to use
    required: false
+ command:
+   default: "init"
runs:
  using: 'node12'
- main: '../lib/setup-tracer.js'
+ main: '../lib/main.js'

../lib/main.js would then have to multiplex the command input and call the right function from there...
Still setup-tracer.js would remain a special case I suppose.
Thoughts? Btw, I would love to help in any way I can.

Doesn't the fact that all the code gets bundled into a single minified file make conflicts much more likely?

Perhaps as a next step we could even compile a single "binary" which all actions could use as their runs.main and control what command to run by means of an input argument.

@alexkappa, I like the idea of only having one "binary" that we compile. I thought of a different way of then hooking into it by manually writing simple js files like
require('main.js').init()

and
require('main.js').analyze()

I'm not really sure which is best. I find putting the command as an input to the action a little odd as it could produce odd behaviour if a user changed it, and we might be obligated to document what it is. However introducing extra files is also a bit annoying.

Doesn't the fact that all the code gets bundled into a single minified file make conflicts much more likely?

@chrisgavin, yes, you're right it'll increase the chance of conflicts in the minified code. If we bundle all the files but don't minify them that could reduce it. I think we'd still get conflicts in the map file though almost every time. Fixing these conflicts is not hard to do but it is a pain as you'd have to do it locally and not by clicking a button in the UI. I can't think of a way around this if we want to keep the map files.

require('main.js').init()

Totally agree, this is much cleaner. It will also enable us to test with more flexibility as we won't have that pesky run() call at the end of certain files.

Changes made include:

Compile all code to a single file that contains logical entrypoints to all of the actions. The physical entrypoint to each action is then a very simple file that calls into this single compiled file.
Don't minimise the generated javascript, to avoid getting conflicts on every single change. I worry it will probably still happen because the map file is all on one line, but we could try it and see how bad it is.

I think I've addressed all comments and this is ready for a proper review and discussion again.
So far I think the only outstanding negative point is that we'll likely get conflicts on every code change that will require running commands locally to fix.

I'm going to close this issue as there isn't enough support to follow through on this and outweigh the downsides.
If we decide we want to do this in the future then this PR will still be here if we want to use it as a starting point.


Add product bid page, login page and sellers page

To ensure error free merging, I have merged main into my branch and fixed errors in App.jsx, package.json and package-lock.json

Mockserver is failing linter. Closing.

Mockserver is failing linter


Add native Array.toIndexedList implementation.

Resolve a TODO for Array.toIndexedList by creating a native implementation of the function.
No change in behavior.

This is available in Array.Hamt

Rather not add stuff to Array since the existing implementation is going to be phased out.


Integration

Is it possible to integrate and run two or more modules together at once(Tone Analyzer & TTS/STT)

Can you provide additional detail on this?
Would you like an application that uses both services? You can actually do that right now.
-V

Exactly yes,Please provide the procedures.....

@sarthak50 ..  a good example of this would be to run the  conversation recipe.
That shows how you use at least 3 modules - STT (tj.listen), TTS (tj.speak), and conversation (tj.converse). Other capabilites like vision recognition (tj.see), tone analyses (tj.analyzeTone), language translation (tj.translate) are also available.  Please see the documentation on the tjbot library to learn more about these methods.
Let me know if you need additional assistance.


Support i18n module

Describe the bug
By default nuxt-simple-sitemap generates pages components urls.
This clashes with pre-rendered routes and i18n.
We should be able to disable default urls generation (prevent generateUrls function from running) without excluding them one by one.
Reproduction
Reproduction link

yarn build
open ./.output/public/sitemap.xml

System Info
System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.37 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.2.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.3 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 109.0.5414.87
    Firefox: 103.0.2
    Safari: 16.2

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hey, thanks for the issue!
I've added the inferStaticPagesAsRoutes to escape from using generateUrls, available in 1.0.5.
export default defineNuxtConfig({
 sitemap: {
  inferStaticPagesAsRoutes: false,
 }
})

I'll be looking to support i18n properly soon, if you have any other ideas on what the integration should look like, please let me know :)

@harlan-zw
It works like a charm, thanks 👌
PS In the README.md, it is said that the include property default value is undefined.
While in reality, its default value (src/module.ts line 69) is include: ['/**'].
You should update the README properties values to reflect reality.

@harlan-zw It works like a charm, thanks ok_hand
PS In the README.md, it is said that the include property default value is undefined. While in reality, its default value (src/module.ts line 69) is include: ['/**']. You should update the README properties values to reflect reality.

Thanks, have updated the doc. Did you run into an issue with it being ['/**'*']?

Nope, no issues.
I find it weird to have include and exclude rules applied to both urls and prerendedRoutes since the challenges for those two arrays are different.
Plus, you run urlFilter two times.
The first time inside generateUrls, thus on the soon-to-be populated urls array.
The second time directly on the merged array [...urls, ...prerendedRoutes].
Consequently, you run the filter function twice on a section of the final URLs.

Nope, no issues.
I find it weird to have include and exclude rules applied to both urls and prerendedRoutes since the challenges for those two arrays are different.
Plus, you run urlFilter two times. The first time inside generateUrls, thus on the soon-to-be populated urls array. The second time directly on the merged array [...urls, ...prerendedRoutes]. Consequently, you run the filter function twice on a section of the final URLs.

Agreed, the code isn't as good as it could be, optimised for doing what it needs to do. Will refactor it at some point when I add a new feature. Always happy to receive PRs too :P


Deduplicate build-engine.sh and rebuild.sh.

These two scripts are largely the same -- rebuild.sh appears to have been copied from build-engine.sh with some initial setup then removed. This is unfortunate to maintain especially when we wish to add more build options or other infrastructure; we should only be defining these build options once.
Now rebuild.sh invokes build-engine.sh with an environment variable set that causes it to skip the initial setup section.

cc @JakeChampion or @guybedford to review? Apparently I don't have write access to this repo so I can't choose a reviewer.


[v2] Improve pull to refresh style

Improved the pull to refresh style a bit.
Here a demo of the native android ptr:

Sorry wrong branch


Changes rock bases to bare

Switching to a bare-based image will reduce the overall image size and reduces attack surface area.
The whereabouts image is supposed to install the binaries on the host it's running on. For this, it runs a bash script, which is why we still need a few stage packages. Note that the helm chart uses pgrep in a readiness / liveness probe.
We can no longer use ensure_image_contains_paths to check if files exist in the rock images, since they are now bare-based. Instead, we can use ensure_image_contains_paths_bare, which checks the image layers instead. Because of this, we need sufficient permissions to check the /var/lib/docker folder.
Adds an extra sanity check during the integration tests, making sure that there is no error reported in Pebble while starting the service.
Depends-On: https://github.com/canonical/k8s-test-harness/pull/36

Can we merge this PR as well?


v2.12.1 npm package is out of sync with v2.12.1 tag

The v2.12.0..v2.12.1 tag diff shows that a fix was added for a missing Params import. This change is missing from the v2.12.1 npm package however.
Would you mind republishing v2.12.1 as v2.12.2 with this change?

Done! Please check if it works now.


Tagged chat suggestion placeholders for translation (settings>interface)

Pull Request Checklist

[x] Description: Briefly describe the changes in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description
Tagged chat suggestion placeholders for translation (settings>interface)

Changelog Entry
Changed

Tagged chat suggestion placeholders for translation (settings>interface)

LGTM!


Hide/Show the Clear button

Is your feature request related to a problem? Please describe.
In some cases, you don't want to allow the user to clear the date
Describe the solution you'd like
Have a new property to show/hide the Clear button (why not also the others)

@LucasBrazi06 can you elaborate the usecase please? While its easy to implement it clear is there for ease of use from user experience standpoint. you can make the input box required if you want user to always select some date range. Would like to understand more from you. Thanks.

My use case is that I use the date/time picker to provide date/time filters and I don't want the user to clear the date.
Why providing the Clear button when it's not allowed, this is confusing the user.

Fair enough but apply and cancel buttons cant be shown/hidden the same way. If user wants to undo their operation cancel is still very much handy. and apply is anyways shown only if autoapply is false.
I will try to publish another version with feature to show hide clear button

@technikhil314 Thanks a lot!


Add compress option to salishsea combine

Original report by Doug Latornell (Bitbucket: douglatornell, GitHub: douglatornell).

Results from runs on salish and westgrid machines will generally be downloaded to other storage for analysis so they might as well be compressed as a part of the combine sub-command.

This feature is no longer necessary.

Results files are now written as single netCDF4 files with variable level zlib compression. So, salishsea combine is no longer applied to them.
Restart files are similarly compressed, either when the per-processor sections are written by NEMO or by REBUILD_NEMO. So, again, this compression feature is not required for them.


Fix RGBA processing on big-endian machines.

If treating the byte buffer as uint32, then the size is quartered, as is the step.

oops, thanks :)


Add | as a string delimiter

Fixes https://github.com/crystal-lang/crystal/issues/3467.
I won't be sad if this doesn't get merged but it's a tiny patch and it works through the issue backlog.

Hello, I just node that Ruby supports any character as delimiter.
See "General Delimited Input" chapter in http://ruby-doc.com/docs/ProgrammingRuby/
Typically '!', '#' are usable too.

I can add a few more bit I don't think @asterite wanted to allow any character as a delimiter. Thoughts?

I think with just | we are done. I see no reason to support other delimiters. For example Elixir supports the same as Crystal. As always, copying Ruby is not what we should always do. Having more things to write a same concept is worse that having just a few ways (less things to learn). I also never saw something like %*hello* in Ruby, even though it's possible, it will only bring confusion.


Swift 3 bools

          1 Error

  :no_entry_sign:
  Any changes to library code need a summary in the Changelog.

          1 Warning

  :warning:
  Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

  Generated by :no_entry_sign: danger

Current coverage is 85.94% (diff: 0.00%)

Merging #775 into master will not change coverage

@@             master       #775   diff @@
==========================================
  Files            30         30
  Lines          2618       2618
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2250       2250
  Misses          368        368
  Partials          0          0

Powered by Codecov. Last update f624f2c...4ebd35a

Closing this, see https://github.com/Moya/Moya/pull/774#issuecomment-261369545


Parameterized tests are run in different orders on different processes of MPI in Python 3.5.6

In Python 3.5.6, the order of execution of tests parametrized with @chainer.testing.parameterize and chainer.testing.product looks nondeterministic.
Thus, MPI tests may be run in different order on different processes, which may lead to unexpected failure of tests.
Indeed, the failure in https://travis-ci.org/chainer/chainer/jobs/556082067 seems to be caused by the inconsistent orders of tests: in one process, TestObservationAggregator_param_3 is run first, while in the other process, TestObservationAggregator_param_1 is run first.

It should be noted that, when we add new parameterized tests for ChainerMN, we should use pytest.mark.parametrize rather than chainer.testing.parameterize.


Implement a interface to show chrome notifications

Advantages are

will work when browser is closed

Example. some websites ask users to subscribe for notificaitons


Definite assignment analysis ignores destructuring assignment

There is an unexpected error in the following:
void main() {
  late String s;
  () {
    (s,) = ('',);
  }();
  print(s);
  //    ^ The late local variable 's' is definitely unassigned at this point.
}

The equivalent without using records has no diagnostic:
void main() {
  late String s;
  () {
    s = '';
  }();
  print(s);
}

This error shows up from both the analyzer and when trying to compile.

cc @stereotype441

Good find, @natebosch! I see the problem. The bug is in the first phase of flow analysis, where it "looks ahead" to see which variables are potentially assigned in each code block, so that it can properly demote variables and adjust its notion of definite assignment at the top of loops and in the presence of closures. Both the analyzer and the CFE are failing to call AssignedVariables.write when a variable is assigned inside a pattern assignment, so flow analysis is failing to see pattern assignments when "looking ahead".
In your example, correct code is rejected. It's also possible to create examples in which incorrect code is accepted, resulting in a soundness violation, e.g.:
int f(int? i) {
  if (i == null) return 0;
  int k = 0;
  // `i` is promoted to non-nullable `int` now
  for (int j = 0; j < 2; j++) {
    // `i` should be demoted at this point, because it's assigned later in the
    // loop, so this statement should be an error.
    k += i;
    // Now assign a nullable value to `i`.
    (i,) = (null,);
  }
  return k;
}

void main() {
  print(f(0));
}

I've prototyped a fix. I'll add test cases and send it out for review ASAP.

Fix is out for review (https://dart-review.googlesource.com/c/sdk/+/310502). Since this is a soundness issue, once the fix lands I'll follow up with a cherry-pick request.


🌱 Fix example manifests generation

What this PR does / why we need it:

fixes the examples/generate.sh script to successfully generate example manifests. It also pins the versions of images used in example manifests to avoid breaking compatibility with the manifests.
updates ensure-kustomize.sh to use an up-to-date URL for downloading kustomize

This allows generating examples and running make deploy, which is a step in a good direction. There is still an issue with capm3-baremetal-operator-controller-manager not receiving basic auth credentials, which will be addressed in a future PR.
I will squash the commits after review.

Overall, it looks good to me. Just a question: Why do we need to have an image version patch instead of directly fix the versions of CAPI components.

If I understand the situation correctly, moving to the newer versions in the examples would be moving to CAPM3 version v1alpha4. Which is a separate effort, and for now we also want to have working examples with v1alpha3.
I'd also argue that even if a never version should be used, it still should be pinned to specific tags rather than the master to make the examples are reliable and reproducible.


Layout/RescueEnsureAlignment continuation of #6254 #6771

This PR fix unexpected issues with Layout/RescueEnsureAlignment raised by #6771.
By implementing the solution for the related problems one pre-existing spec come to fail but I am not so sure if that has to pass as is or if that simply highlight the existence of two other possible conflicting layouts for rescue that were not being considered.

a_variable = begin
               something
             rescue
               log_some_failure
             end

a_variable = begin
  something
rescue
  log_some_failure
end

One of these 2 cases passes and the other fail after my changes but none of them fail before. I don't know if one of those styles should be selected over the other or if they should be considered equivalent and keep passing without error.
Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@Drenmi ,
Would I be correct to think that each of the styles I mentioned above would be defined by Layout/EndAlignment the same way as Layout/ElseAlignment does at https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/cop/layout/else_alignment.rb#L109 ???


improve simplify function

Explore the possibility of making R unnecessary by implementing a Ramer–Douglas–Peucker or Visvalingam algorithm directly in Python. A Python implementation done by @migurski: https://github.com/migurski/bloch
See line 223: https://github.com/NYPL/map-vectorizer/blob/master/vectorize_map.py#L223 and simplify_map.R: https://github.com/NYPL/map-vectorizer/blob/master/simplify_map.R
via @albertsun

Have you looked at https://pypi.python.org/pypi/rdp/?

had not seen it. seems pretty new. will look into it

adding contents of #21:
I originally used R because I found code that reduces the amount of corners in a geographic polygon: http://rpubs.com/geospacedman/alphasimple
The function in the vectorizer is:
https://github.com/NYPL/map-vectorizer/blob/9b9129b9d135c89b350700549794e7d0f2348af2/vectorize_map.py#L227
and the R code:
https://github.com/NYPL/map-vectorizer/blob/9b9129b9d135c89b350700549794e7d0f2348af2/simplify_map.R
Ideally, we would eliminate R and have python code that produces the same output as R (one shapefile for each polygon that was simplified that is within the area threshold).
A shapefile-per-polygon is produced (thousands!) because it was the only way I could pass data from python-to-R-and-back but was also useful to find the average color of the polygon.

http://stackoverflow.com/questions/26303878/alpha-shapes-in-3d
http://www.mrzv.org/software/dionysus/python/alphashapes.html
http://www.mrzv.org/software/dionysus/python/overview.html#python-bindings
http://doc.cgal.org/latest/Alpha_shapes_2/index.html
http://stackoverflow.com/questions/17553035/draw-a-smooth-polygon-around-data-points-in-a-scatter-plot-in-matplotlib
http://repositorium.sdum.uminho.pt/bitstream/1822/6429/1/ConcaveHull_ACM_MYS.pdf

http://stackoverflow.com/questions/83593/is-there-an-efficient-algorithm-to-generate-a-2d-concave-hull

http://www.cis.rit.edu/people/faculty/kerekes/pdfs/AIPR_2007_Gurram.pdf
https://patentscope.wipo.int/search/en/detail.jsf?docId=WO2008107859


Update requirements and remove future imports

Description:
In this PR i remove future imports from the whole code and update requirements.

Thanks for the pull request, @salman2013!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
:warning: We can't start reviewing your pull request until you've submitted a     signed contributor agreement     or indicated your institutional affiliation. Please see the CONTRIBUTING     file for more information.     If you've signed an agreement in the past, you may need to re-sign.  See     The New Home of the Open edX Codebase     for details.
Once you've signed the CLA, please allow 1 business day for it to be processed.  After this time, you can re-run the     CLA check by editing the PR title.  If the problem persists, you can tag the @openedx/cla-problems team in a     comment on your PR for further assistance.

@salman2013 in order to accept this contribution we need to have a signed CLA on file for you either as an individual contributor or an entity contributor.  You would be covered under an entity contributor agreement if this work was on behalf of your employer.
If you are doing the work on your own, please fill out this form: https://openedx.org/cla

Hi @salman2013 - Friendly reminder regarding the CLA form.

Hi @salman2013! Just following up on your CLA form. You'll need to submit one in order to get this pull request pushed through.
Please note, we had an issue with the CLAs over the last week, so if you filled one out and it didn't go through, please try again as the problem on our end has been fixed. Thank you!

This change has been done in https://github.com/openedx/codejail/pull/149 so the PR is not needed anymore.

@salman2013 Even though your pull request wasn’t merged, please take a moment  to answer a two question survey so we can improve your experience in the future.


Pull request to allow the team to inspect and discuss next steps for the initial indexer implementation.

I think the intention is that this will read records in the index schema, and the writing of them will happen elsewhere. The reason for this is that we want the flexibility of being able to roll up to all the indexed documents and index them all at some point.


Update azure-hybrid-benefit.md

Found a little typo and the column to see the Hybrid Benefit now has the name "OS licensing benefit" in the portal (-:

@thomash0815 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Corrections to the recognitionStatus example

There is no "Failure" among the possible values of "recognitionStatus".
Needed to be fixed to prevent confusion for the user.

Speech-to-text REST API：Response parameters
https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/rest-speech-to-text#response-parameters

@noueh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hello @wolfma61 ,  Could you confirm about possible values of "recognitionStatus" in the output of "batch transcription" results?
(In the public documentation, there is only a definition for "online transcriptions" "recognitionStatus".
Is it the same for "batch transcription"? Is it actually a different definition?)

unfortunately our error codes are not aligned, some report Error, some Failure, some Fault (there might be others). In many cases it is a path-through from an underlying speech micro-service, so the high-level speech service frontend isn't touching this value at all. A unification would be 'nice' or 'desired' to return a unique failure message, but this isn’t possible without breaking customers that look for the currently return failure text.
For the batch transcription we looked closed into the actual code. For phrase results you will only find a phrase result with the result code ‘success’. A phrase result with a failure code will not be generated.

Thank you for the detailed explanation.
I will close this request.

@wolfma61 , could you reply to our internal email to us?

done ;)


Deleting a Program before deleting a Stack blocks the deletion of the Stack

What happened?
If deleting both a stack and a program at the same time (e.g. they are defined in the same file, or if done manually), the program will delete fine, but the stack will enter a stalled condition as it tries to resolve a reference to a program that does not exist. This hangs the deletion of the stack (and blocks your terminal, as kubectl waits).
If the program is re-created, the stack will catch up and delete, and the program can be deleted again. Doing this, as far as I can tell, appropriately deletes and cleans up resources created by the stack.
Steps to reproduce

Define a stack and a program in the same YAML file
apiVersion: pulumi.com/v1
kind: Stack
metadata:
  name: deployment-example
spec:
  stack: deployment-example
  programRef:
    name: deployment-example
  destroyOnFinalize: true
  envRefs:
    PULUMI_ACCESS_TOKEN:
      type: Secret
      secret:
        name: pulumi-api-secret
        key: accessToken
---
apiVersion: pulumi.com/v1
kind: Program
metadata:
  name: deployment-example
program:
  resources:
    random:
      type: random:RandomInteger
      properties:
        min: 1
        max: 10
    nginx:
      type: kubernetes:apps/v1:Deployment
      properties:
        metadata:
          name: nginx2
        spec:
          selector:
            matchLabels:
              app: nginx
          replicas: ${random.result}
          template:
            metadata:
              labels:
                app: nginx
            spec:
              containers:
                - name: nginx
                  image: nginx

Create the resources with kubectl create -f <file>
Delete the resources with kubectl delete -f <file>
The delete will hang; kubectl describe-ing the stack in another terminal window will show it has stalled as it tries to find the program.
If you once again create the resources with kubectl create -f <file>, the stack fails to create (as it already exists), the Program creates (as it has already been deleted), and the Stack finds the Program and deletes finally. You can then kubectl delete -f <file> again to clean up the Program.
Expected Behavior
Stack should delete, even when it cannot find the program references.
Actual Behavior
Delete hangs when the stack is stalled looking for the referenced program.
Output of pulumi about
No response
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thanks @roothorp for the report.
I see that we have another issue covering this issue, so am closing this one as a duplicate.
https://github.com/pulumi/pulumi-kubernetes-operator/issues/441


Group and parametrize tweaks

The idea
Currently the tweaks are as individual unparametrized idempotent functions. This was generally OK in the beginning of the project as all the tweaks were just enable/disable. Then we got things like #45, #55 or #78 where there were more than two possibilities how to customize one particular control or item.
E.g. in case of
HideTaskbarSearch / ShowTaskbarSearchIcon / ShowTaskbarSearchBox

we could have something like
TaskbarSearch -Hide
TaskbarSearch -Icon
TaskbarSearch -Box

or more PowerShell-y
TaskbarSearch -Type Hide
TaskbarSearch -Type Icon
TaskbarSearch -Type Box

Furthermore, we have tweaks like
HideDesktopFromThisPC / ShowDesktopInThisPC
HideDocumentsFromThisPC / ShowDocumentsInThisPC
HideDownloadsFromThisPC / ShowDownloadsInThisPC
HideMusicFromThisPC / ShowMusicInThisPC
HidePicturesFromThisPC / ShowPicturesInThisPC
HideVideosFromThisPC / ShowVideosInThisPC
Hide3DObjectsFromThisPC / Show3DObjectsInThisPC

which could also benefit from grouping and parametrization, so we'd have something like
HideFromThisPC -Desktop -Documents
ShowInThisPC -Downloads -Music

or
ThisPCLibraries -HideDesktop -HideDocuments -ShowDownloads -ShowMusic

or
ThisPCLibraries -Desktop Hide -Documents Hide -Downloads Show -Music Show

or
ThisPCLibraries -Hide "Desktop", "Documents" -Show "Downloads", "Music"

This has been also proposed (by @r3incarnat0r in #165 and possibly by others elsewhere) for bloatware removal functions where this would enable use of -AllUsers and exclusion lists.
Lastly, proposals like #199 couldn't be even done by any other way as the complexity and repetition needed for such a tweak if it would be done in the classical way would be way too large.
Upsides:
Much lower number of individual tweak functions, as the tweaks would be grouped thematically.
Better possibilities for customization.
Hopefully more comprehensive tweaking as the user would see what options can one particular tweak have and wouldn't need to look up another tweaks just to get the overview. Also tab-completion would work in case of interactive scripting.
Downsides:
Absolutely all tweaks need to be renamed and rewritten. Basically the project would restart from scratch and it may be extremely confusing for occasional and non tech-savvy users.
Parametrization makes the tweaks more difficult to use as the user needs to know appropriate PowerShell syntax for appropriate data types.
It would be less obvious to determine what was the default value before modification and what would be the appropriate parameter to pass in order to restore the defaults. For this, Wiki proposed in #225 would help.
One of the core rules of the project would be broken, as the tweak function body couldn't be simply copy-pasted and run without any context anymore. Though this might be downside only for me. :)
Most importantly, the tweaks couldn't be passed directly from command line anymore as it would be no longer possible to properly parse all the options, not to mention correctly pass them to elevated command in case of RequireAdmin. Only preset files could be used.

I'd vote for PowerShell-y arguments. :)
ThisPCLibraries -Hide "Desktop", "Documents"

...confusing for occasional and non tech-savvy users...user needs to know appropriate PowerShell syntax...

Shouldn't the GUI described in #244 make tweaking even simplier than before in the end?

all tweaks need to be renamed and rewritten

Maybe an opportunity to change function names to more PowerShell-y paradigm?
Set-ThisPCLibraries


Fix done compiler hook type

Code reference: https://github.com/webpack/webpack/blob/v4.8.3/lib/Compiler.js#L34

Thanks!


[mobile] grpc: no transport security set

Background
I have launched LND on iOS via gomobile and all your instructions (using falafel). I am able to start LND node and see all logs. But I cannot make any gRPC requests because of the following error:
Error Domain=go Code=1 "grpc: no transport security set (use grpc.WithInsecure() explicitly or set credentials)" UserInfo={NSLocalizedDescription=grpc: no transport security set (use grpc.WithInsecure() explicitly or set credentials)}
Your environment
Also please note that I am using new nio branch of grpc-swift as they recommend.

version of lnd:  lnd v0.9.0-beta-rc1
which operating system (uname -a on *Nix): OSX
version of btcd, bitcoind, or other backend: Neutrino
any other relevant environment details

Steps to reproduce
LndmobileStart succeeds and I see all the logs. But any gRPC request (LndmobileInitWallet or LndmobileGenSeed) does fail with the error above.

I have also created related issue on grpc-swift repo:
https://github.com/grpc/grpc-swift/issues/694

Should be fixed by https://github.com/lightningnetwork/lnd/pull/3907.


Builder defaults to MediaType.TEXT_PLAIN

https://github.com/smallrye/smallrye-rest-client/blob/c81b0529d7dff0fac780296614989d65749b98d0/implementation/src/main/java/io/smallrye/restclient/RestClientBuilderImpl.java#L136
The builder defaults to MediaType.TEXT_PLAIN for consumes and produces. Now if you want the accept header to be "Accept: */*" you have to add a @Produces annotation. Like this in the interface.
    @POST
    @Path("/operation")
    @Consumes(MediaType.APPLICATION_JSON)
    @Produces
    Response operation(String request);

Would it not make more sense to default the produces to MediaType.WILDCARD ?
Just a suggestion :)

We'd welcome a PR that fixes the issue

Here it is :)
https://github.com/smallrye/smallrye-rest-client/pull/14


Add requests per second graph to the HTML report.

Closes #246.
TODO

Testing
Add additional graphs.

Screenshot

I removed the options that were added in the initial version of this pull request and now we rely on --report-file to enable/disable this.
I also changed how the data is stored. Now we are storing the number of requests for each second and the (flawed) concept of "buckets" is now gone. Let me know what you think.
Also, what do you think about using something like this for the chart style: https://echarts.apache.org/examples/en/editor.html?c=area-simple. I imagine that it could be quite useful specially for long-running load tests (ability to zoom in, etc.).

I also changed how the data is stored. Now we are storing the number of requests for each second and the (flawed) concept of "buckets" is now gone. Let me know what you think.

This is much simpler, I like it!
Note that the data is still getting cut off: I ran a load test for 1 hour (3600 seconds) but the data was cut off -- I manually added the missing bit of the report to see the data that was recorded. Likely this is a limitation of the current --report-file implementation, and a buffer or something will need to be increase to support larger file sizes.

Also, what do you think about using something like this for the chart style: https://echarts.apache.org/examples/en/editor.html?c=area-simple. I imagine that it could be quite useful specially for long-running load tests (ability to zoom in, etc.).

I like that idea very much, it would add richness to the charts being able to zoom in.
Perhaps the X axis should be actual timestamps though, instead of seconds since the test started? I wonder which is more useful? (The latter would be easier to match up against data in New Relic etc)

I am still trying to figure out the cutting off problem (I am able to reproduce it). I fell that there is something wrong with JSON serialization or maybe format! when the data series grows over certain point. Looking into it as we speak, but is quite time consuming, since I can only reproduce it if I run a load test for a while.

I improved the appearance of the graph:

Improved styling of the line
Added zoom support
Added tooltip on mouse hover
Marked starting and stopping period (I can't make the latter to appear as it completes so quickly)
Added "Save as image" function.

I noticed that there is always a spike of requests exactly at the point when the load test was started up and --no-reset-metrics. Is it possible that we are recording some requests twice in this case?
Without --no-reset-metrics

With --no-reset-metrics

I think your graphs in the PR are labeled backwards -- the first one looks like --no-reset-metrics IS enabled, the second looks like --no-reset-metrics is NOT enabled.

Any idea what this spike is at the start of the load test? It seems to show up in the graphs semi-regularly (in this case I'm using the following options: -v --report-file report.html -u10 -s10 -t10 --no-reset-metrics:

Any idea what this spike is at the start of the load test? It seems to show up in the graphs semi-regularly (in this case I'm using the following options: -v --report-file report.html -u10 -s10 -t10 --no-reset-metrics:

I played with the color scheme and aspect ratio and I think that graph looks better now. Starting phase is only displayed when --no-reset-metrics is used and stopping phase is only displayed if it lasts for long enough to actually be visible on the graph.
Screenshots
With --no-reset-metrics

Without --no-reset-metrics

This is a very nice enhancement, and only affects the HTML report generated when the load test ends. Committing as is: the rest of your TODO will make great followups -- thanks!


[ACT]:  Contact List Prep for all team leads

Description
Must prepare a contact list of all team leads for emergency reach out.
Items to Complete

[ ] Prepare a list
[ ] Publish a page wiki and link it Documentation page.

@sercanerhan burasi sokomelli.

@canerakin111 Do we have any privacy concerns about that public page? Should we store only the Discord names?

@sercanerhan shouldnt be a problem. Once you shape the list, perhaps we can share in the afetharita-product-core channel just to confirm with everyone that it is fine.

Şöyle birşey hazırladım, uygunsa lead'ler ile görüşüp paylaşabiliriz.Karar verilen alanalrı github'a eklemiş oluruz.
https://form.jotform.com/230452488302048

shared in #leads channel https://discord.com/channels/1072074800622739476/1072084578296156270/1077124526409785354


Feature request: Add ImageSharpTexture constructor that takes (uint mipmapCount)

The current implementation of ImageSharpTexture let you choose whether to use mipmaps or not, but for my project I need to specify a certain number of mipmaps levels (I'm generating an atlas and I need to prevent texture bleeding by no creating the lowest mipmaps levels where I know there will be bleeding).
I know this could be implemented in my side, but since the MipMapHelper are all marked as internal it's a shame to rewrite all and it would be so nice if an extra constructor like this is added:
public ImageSharpTexture(Image<Rgba32> image, uint mipmapCount, bool srgb);

I can submit a PR if you are ok with this :)

This seems like a fine addition to me, and should be straightforward to implement given the code that's already there.

I can submit a PR if you are ok with this :)

Definitely, feel free! Given the large number of overloads already present on this class, I'd suggest just adding 3 new ones:
public ImageSharpTexture(Image<Rgba32> image, uint mipmapCount, bool srgb);
public ImageSharpTexture(string path, uint mipmapCount, bool srgb);
public ImageSharpTexture(Stream stream, uint mipmapCount, bool srgb);

where mipmapCount == 0 is invalid, and mipmapCount == 1 is functionally the same as the overload where mipmap == false.

This seems like a fine addition to me, and should be straightforward to implement given the code that's already there.

I can submit a PR if you are ok with this :)

Definitely, feel free! Given the large number of overloads already present on this class, I'd suggest just adding 3 new ones:
public ImageSharpTexture(Image<Rgba32> image, uint mipmapCount, bool srgb);
public ImageSharpTexture(string path, uint mipmapCount, bool srgb);
public ImageSharpTexture(Stream stream, uint mipmapCount, bool srgb);

where mipmapCount == 0 is invalid, and mipmapCount == 1 is functionally the same as the overload where mipmap == false.


[BUG] Formatter turns ##< into ##

Details

Atom version: 1.44
Julia version: 1.3.1
OS: macOS
Package versions:

Atom.jl: 0.12.7
julia-client: 0.12.2
ink: 0.12.2

Steps to reproduce

Format a line with ##< or ##>
This may be intended, but it brakes my custom fold plugin.

Can't repro that:

me neither.

I can't reproduce either right now. But I can see the following, when using "Format on save"


GPT4 giving error after a long session

Getting the following error after a fairly long chat with GPT4.

If this is due to ChatGPT's limitations, then the error message should be clear about it and needs to be handled gracefully. Right now I don't know if I've overflown the context window or there is a connectivity issue etc.
Thanks,
Raghu

Sorry, I missed #26. It is the exact same issue. Closing this one.


iasl: integrate upstream patch for acpica/acpica#387

Motivation for this change
See:

https://github.com/acpica/acpica/issues/387

Probably want to wait until https://github.com/acpica/acpica/pull/389 is merged. :heavy_check_mark:
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: iasl
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313
shrinking /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313/bin/iasl
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313/bin
patching script interpreter paths in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313
checking for references to /build in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313...
/nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313

Success on aarch64-linux (full log)
Attempted: iasl
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313
shrinking /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313/bin/iasl
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313/bin
patching script interpreter paths in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313
checking for references to /build in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313...
/nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313

Failure on aarch64-linux (full log)
Attempted: iasl
Partial log (click to expand)

trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/gffsaq07p6s8rp87f0g40qsfpxr7kpn0-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv' failed

Failure on x86_64-linux (full log)
Attempted: iasl
Partial log (click to expand)

trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/d7sl9q1mk8kd5gq3dk6xp6vsbpcn2aig-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv' failed

Try this format for patch url, fetchpatch needs the full commit hash:
url = https://github.com/drkjam/netaddr/commit/2ab73f10be7069c9412e853d2d0caf29bd624012.patch;

Failure on aarch64-linux (full log)
Attempted: iasl
Partial log (click to expand)

trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/gffsaq07p6s8rp87f0g40qsfpxr7kpn0-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv' failed

Failure on x86_64-linux (full log)
Attempted: iasl
Partial log (click to expand)

trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/d7sl9q1mk8kd5gq3dk6xp6vsbpcn2aig-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv' failed

failing URL looks the same as before.

Success on x86_64-linux (full log)
Attempted: iasl
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313
shrinking /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313/bin/iasl
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313/bin
patching script interpreter paths in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313
checking for references to /build in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313...
/nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313

Success on aarch64-linux (full log)
Attempted: iasl
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313
shrinking /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313/bin/iasl
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313/bin
patching script interpreter paths in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313
checking for references to /build in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313...
/nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313


Cannot use import statement outside a module

For some reason, I am getting the error message in the title, and all my efforts to get rid of it failed. xo is a package dependency, and "type": "module" is set in my package.json.
Running this on Big Sur 11.5.2, with Atom 1.58.0.

Closing as Atom is abandoned.


Run build test on PR and Push

This addresses https://github.com/golioth/devrel-issue-tracker/issues/254. It introduces a test workflow that builds the application for a single target as a form of "does it compile" test. As requested, it defaults to not creating an Artifact.
Note: this will run on every PR and Push. We could restrict it to only run on certain branches, at least for Push.

Only merge after #67 is merged!

You might consider squashing these commits before merging.


Add DiscordNotifier Plugin

This was created in collaboration with @nodeak
Repo: https://github.com/jkufro/DiscordNotifier/

Updated commit hash is for removing the dependency on Twilio - we were using it previously but no longer need it.


[Bug] --reload tag + db.add( ) causes "db-journal.db" to be created and intermittent "Failed to Fetch" errors in localhost:any-port/docs, no error in terminal

PREREQUISITES

[x] I added a very descriptive title to this issue.

[x] I used the GitHub search to find a similar issue and didn't find it.

[x] I searched the FastAPI documentation, with the integrated search.

[x] I already searched in Google "How to X in FastAPI" and didn't find any information.

[x] I already read and followed all the tutorial in the docs and didn't find an answer.

[x] I already checked if it is not related to FastAPI but to Pydantic.

[x] I already checked if it is not related to FastAPI but to Swagger UI.

[x] I already checked if it is not related to FastAPI but to ReDoc.

[x] After submitting this, I commit to:

Get good enough to be able to help people when I can
I'm sure it'll be more than 2

Alright, so this contains a good deal of minimal code, but I can't see anything else to get rid of.
SYSTEM/VERSIONS
Windows 7 x64 64-bit
Chrome 83
FastAPI, Pydantic, SQLAlchemy, Uvicorn latest
VSCode latest
CODE | BUG
undocumented | Failed to Fetch

QUIRKS:
* works intermittently
* causes multiple refreshes in a row
* sometimes creates db-journal.db, and sometimes not
POSSIBLE REASONS GIVEN:
* CORS
* Network Failure
* URL scheme must be http or https for CORS reques
EXCEPT FOR THESE FACTS:
* HTTP protocols
* Other websites have no issues
* CORS is set
PROBLEM LINES
db.add(stock); lines 70 & 86
--reload tag in terminal

Been debugging for a week+to try and fix it before I realized it was the --reload tag.  It's annoying to have to quit and rerun uvicorn each save, but it works.
I read somewhere that it has something to do with refreshing a database connection, but I don't know why it would fail.
MINIMAL CODE
    from fastapi import BackgroundTasks, Depends, FastAPI
    from pydantic import BaseModel
    from sqlalchemy import Column, create_engine, DateTime, Integer, String
    from sqlalchemy.ext.declarative import declarative_base
    from sqlalchemy.orm import Session, sessionmaker
    from starlette.middleware.cors import CORSMiddleware

    # Standard for SQLite
    SQLALCHEMY_DATABASE_URL = "sqlite:///test.db"

    engine = create_engine(SQLALCHEMY_DATABASE_URL,
                           connect_args={"check_same_thread": False})

    SessionLocal = sessionmaker(autocommit=False,
                                autoflush=False,
                                bind=engine)

    Base = declarative_base()

    # SQLAlchemy mapped model
    class Stock(Base):
        __tablename__ = "stocks"

        id = Column(Integer(), primary_key=True, index=True)
        datetime = Column(DateTime(), index=True)
        symbol = Column(String(5), nullable=False, index=True)
        company = Column(String(50), index=True)
        price = Column(Integer())

        def __repr__(self):
            return (f"""<Stock(id={self.id},
                               datetime={self.datetime},
                               company={self.company},
                               symbol={self.symbol},
                               price={self.price})>\n""")

    # Pydantic incoming stock model
    class StockRequest(BaseModel):
        symbol: str

    # Create the app, database, and stocks table
    app = FastAPI()
    Base.metadata.create_all(bind=engine)

    app.add_middleware(
        CORSMiddleware,
        allow_origins=["*"],
        allow_credentials=True,
        allow_methods=["*"],
        allow_headers=["*"],
    )

    # Fetch a fake stock quote
    def fetch_stock(symbol: str):
        # Dummy db connection
        db = SessionLocal()

        # Fake quote
        quote = {
            "quote": {
                "companyName": "Ford Motor Co.",
                "symbol": "F",
                "price": 7.898}}

        # Submit for later query
        db.add(quote)
        db.commit()

        return quote

    @app.post("/stock/")
    async def create_stock(stock_request: StockRequest):
        # Dummy db connection
        db = SessionLocal()

        # Instantiate a Stock object and assign its symbol
        stock = Stock()
        stock.symbol = stock_request.symbol

        # Without this add/commit, the background task fails
        db.add(stock)
        db.commit()

        fetch_stock("F")

        # Query stocks table and print results
        query = db.query(Stock).all()
        for d in query:
            print(f"""{d.company}\t
                      {d.price}\t
                      {d.symbol}\t
                      {d.datetime}""")

        # If at all successful, returns query list
        return {
            "query": query
        }

I am also facing the same issue while dealing with databases. @joshb019919 Any solution found to this other than having to reload uvicorn manually?

No, I never could get it to work, so I switched back to Flask.
On Mon, Jun 21, 2021 at 9:57 AM Joshin Rexy @.***>
wrote:

I am also facing the same issue while dealing with databases. @joshb019919
https://github.com/joshb019919 Any solution found to this other than
having to reload uvicorn manually?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/2948#issuecomment-865100797,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALD4BVXXJXN5CX6SX6XXUMDTT5HMLANCNFSM4ZEJSNAA
.

Okay. @tiangolo and team please look into this issue.

I also face this issue ,I think it's happen when post or put request is called.


Make alloc dependency optional

Related issue: #366
The API has been slightly extended, in particular all operations that allocated or extended a Vec now offer an equivalent that operates in-place on a slice. I also replaced some functions that looked like they would operate in place (by taking an &mut Vec<u8> and extending it) with operations that take an &mut [u8] instead.
This definitely shouldn't get included without a version bump, since it can cause code that was relying on that functionality to break without causing a type error.
I'm actually somewhat inclined to deprecate a lot of the functions I had to alter in favor of functions more like box_::open_detached which put more of the requirements in at the type level rather than at runtime, but that would be a larger change than was easy to make.

Pull Request Test Coverage Report for Build 1123

0 of 0   changed or added relevant lines in 0 files are covered.
37 unchanged lines in 10 files lost coverage.
Overall coverage decreased (-0.4%) to 94.528%

Files with Coverage Reduction
New Missed Lines
%

crypto/aead/aead_macros.rs
1
99.38%

crypto/secretbox/xsalsa20poly1305.rs
1
99.4%

crypto/sign/ed25519.rs
1
99.67%

lib.rs
1
83.33%

randombytes.rs
1
95.83%

crypto/stream/stream_macros.rs
2
98.37%

crypto/verify.rs
3
92.86%

crypto/box_/curve25519xsalsa20poly1305.rs
4
99.03%

crypto/sealedbox/curve25519blake2bxsalsa20poly1305.rs
4
92.98%

crypto/secretstream/secretstream_macros.rs
19
87.66%

Totals

Change from base Build 1122:
-0.4%

Covered Lines:
3023

Relevant Lines:
3198

💛  - Coveralls

The question is simple: can you enable alloc feature without std and vice versa?

The question is simple: can you enable alloc feature without std and vice versa?

You can enable alloc without std, but it wouldn't really make sense to enable std without alloc, so you can't.

Sorry for the delay. Would you please rebase the branch?

@GallagherCommaJack Hello. We have changed our CI a little bit. Would you please rebase you PR onto the latest master?

I am sorry to close your PR for inactivity. I will be happy to be working on your PR when you want to continue.

I am sorry to close your PR for inactivity. I will be happy to be working on your PR when you want to continue.


Fix percona-extrabackup.sh for better monitoring

Removes unused "email team if it fails" fucntionality which didn't work with 'set -e' anyway;
Installs file using copy instead of template, which was all templated in a "raw" block;
Removes unneeded "mailutils" dependency

Very related to https://github.com/blueboxgroup/ursula-monitoring/pull/51

Please rebase on master.

retest

On an old backup....
"timestamp":"2016-01-21T21:05:56.103511+0000","level":"warn","message":"config file applied changes","file":"/etc/sensu/conf.d/checks/check-percona-xtradb-backup.json","changes":{"checks":{"check-percona-xtradb-backup":[null,{"auto_resolve":true,"interval":43200,"command":"/etc/sensu/plugins/check-percona-xtrabackup.py ","occurrences":1,"standalone":true,"handle":true,"notification":"check-percona-xtradb-backup check failed","handlers":["pagerduty"]}]}}}

Looks good to me.

One design element I forgot to mention, we don't really use the files/ directory. We run everything as if it were a template, which keeps all the content in one subdir rather than split between two. Can you undo the file move?

I like everything but the use of file vs template, so other than that, this is good to go.


Deprecate WP_Auth0_Lock10_Options class

Changes
This PR deprecates the following methods:

WP_Auth0_Lock10_Options::get_sso() - No longer used.
WP_Auth0_Lock10_Options::get_client_id() - No longer used.

Codecov Report

Merging #654 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #654      +/-   ##
============================================
+ Coverage     42.12%   42.17%   +0.04%
+ Complexity     1238     1236       -2
============================================
  Files            51       51
  Lines          3779     3775       -4
============================================
  Hits           1592     1592
+ Misses         2187     2183       -4

Impacted Files
Coverage Δ
Complexity Δ

lib/WP_Auth0_Lock10_Options.php
73.14% <ø> (+2.61%)
59 <0> (-2)
:arrow_down:

lib/WP_Auth0_Routes.php
86.61% <ø> (ø)
55 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab340...81571d9. Read the comment docs.


Multi-Threaded downloading for playlists

When downloading playlists youtube-dl could use multiple connections to download videos at the same time, right now my dl speed averages at 50k/s, and the full playlist is about 15G (defcon19).
I've been running 4 terminals with --playlist-start=N so far, and spaced them out.

I tried may options and here is the best that I came up with - use aria2.
The --external-downloader option
$ youtube-dl --external-downloader aria2c --external-downloader-args '-x <number of threads>' https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6

But this will download only one file at a time. To download many videos simultaneously, you will have to prepopulate download links.
Prepopulate download links
$ youtube-dl -g https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6 > dlinks.txt
$ aria2c -i dlinks.txt -j <number of simultaneous downloads> -x <number of threads for each download>

You will have to use >> instead of > in the first command to append more links.
The two commands may also be combined -
$ aria2c -j <number of simultaneous downloads> -x <number of threads for each download> `youtube-dl -g https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6`

But this will result in no backup of your links in case download interrupts.
Note: In case of prepopulating, you may end up in a state when your links get expired because your previous downloads would have taken a while.

Let me write some summary. Here are several levels to implement threaded downloading in youtube-dl:

User-input URLs, including command line options and batch files. (#109)
Playlists (this issue)
Segments in segmented streams (HLS, HDS, DASH) (#11044)
Chunk level in a single URL (#1498)

Only the last case works with external downloaders like aria2c or axel. For the first three kinds, more codes are necessary.

Multi-Threaded postproc for playlists
Was tempted to open another issue for it, but this is too similar. I'm fine with single threaded downloads (multi threaded downloads introduce the possibility of getting your IP banned), but I'd like to see the postproc done in separate thread(s) (up to N threads, N being the number of CPU cores). As soon as a download is finished, the postproc job should be dispatched and the next download should start immediately. But if all N cores are doing postproc, wait for one to finish before downloading another playlist item.
On my setup postproc is the bottleneck, not bandwidth. Postproc benefits much more from mult-threading, whereas downloading only benefits from multi-threading if the server is throttling you (which implies they don't want you to use multiple connections simultaneously, and might ban you if you do).

@d3fault: Thanks for writing this. Technically, postprocessing and downloading are implemented in different modules, it's better to have an separate issue.

One thing you can do is simply write a GUI that runs multiple instances of youtube-dl. That's what I do in the RainDrop downloader - it basically just wraps the youtube-dl process and calls it for as many links as you set. The playlist portion does not run multithreaded however - originally, I wrote the code to pull the links automatically, but since youtube-dl already handled it in a single thread, I left it alone. One thing I've done for personal use is inject some javascript in the youtube playlist browser that just pulls the links into a text box at the bottom (using custom javascript chrome extension). You end up with a list of links and you can just paste them in and watch the multithreaded magic go. You can see it here https://www.youtube.com/watch?v=ihEH4DuTcTg

Will this ever be put in the main program?

Hey Guys, any plans to add multithreaded HLS downloading feature?

I Need new version

@singhpratyush Is it possible to modify your command to extract audio? In particular, I want to extract audio-- I usually run youtube-dl  --extract-audio  --format bestaudio --external-downloader aria2c --external-downloader-args '--max-connection-per-server=15' --yes-playlist "<plist_url>"

@crypdick: Yes, it would work fine. You can also do postprocessing on the audio if you want, e.g. --audio-format mp3.

my sh snippet
ytall() {
	special_o='%(upload_date)s__%(title)s-%(id)s.%(ext)s'
	default_threads=3

	if [[ -z $1 ]]; then
		echo "ytall [channel_url/playlist] [threads] [special -o ${special_o}]"
		return
	fi

	if [[ -n $3 ]]; then
		youtube-dl -j --flat-playlist $1 | jq -r '.url' | parallel -j $2 --progress youtube-dl -i -o \'$special_o\' --
	elif [[ -n $2 ]]; then
		youtube-dl -j --flat-playlist $1 | jq -r '.url' | parallel -j $2 --progress youtube-dl -i --
	else
		youtube-dl -j --flat-playlist $1 | jq -r '.url' | parallel -j $default_threads --progress youtube-dl -i --
	fi
}

@oltodosel that's a good snippet, but there are 2 things I notice right away:

You're limiting the max number of channels/playlists to 1 through the order of the parameters.

You're referencing parameter 1 without quoting it.

@rautamiekka

I don't need it.
You're right, guess I got too reliant on oh-my-zsh's automatic url quotation.

I tried many options and here is the best that I came up with - use aria2.
The --external-downloader option
$ youtube-dl --external-downloader aria2c --external-downloader-args '-x <number of threads>' https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6

But this will download only one file at a time. To download many videos simultaneously, you will have to prepopulate download links.
Prepopulate download links
$ youtube-dl -g https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6 > dlinks.txt
$ aria2c -i dlinks.txt -j <number of simultaneous downloads> -x <number of threads for each download>

You will have to use >> instead of > in the first command to append more links.
The two commands may also be combined -
$ aria2c -j <number of simultaneous downloads> -x <number of threads for each download> `youtube-dl -g https://www.youtube.com/playlist?list=PLsPUh22kYmNBkabv9M4fXo6HMLKnc7iR6`

But this will result in no backup of your links in case download interrupts.
Note: In case of prepopulating links, you may end up in a state when your links get expired because your previous downloads would have taken a while.

There are playlists for which the -g option returns links that start with manifest.googlevideo.com, and if such a link is opened in a browser it will download a few hundred KB file. Is there a solution for cases like that?
Note: your playlist still returns the old links which aria2c can download

Hi, just wanted to say that you can also use GNU parallel to download videos in parallel
Thanks!

My bash function for parallel: https://github.com/amadeuszkryze/yt-functions

I created a multithreaded Rust command line wrapper: https://github.com/Vagelis-Prokopiou/youtube-dl-rs
Currently it serves my own needs, but if it helps anyone else, be my guest and use it.

The comments from 2012 regarding download speed that began this issue are out of date. yt-dl's YouTube download speeds have been fixed, broken and fixed again many times since then.


convert xml scenes to scn at compile time

I would like if the scenes were created in XML and converted to automatic scn at compile time  as gd and gdc

This could be pretty convenient. Or a way to bulk export xml/xscn to scn easily.

Yes that would be a cool feature since apparently the SCN is more performant, but XSCN or the upcoming TSCN are way better for source control and for working in teams generally speaking. So it would be very nice to be able to do the conversion at the export time directly.

:+1:

with the new renaming tool, it should be easy to modify it to do this,
specially given I really want to remove support for xml in the future
On Fri, Nov 13, 2015 at 9:30 AM, volzhs<EMAIL_ADDRESS>wrote:

[image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/2778#issuecomment-156420199.

with the new renaming tool, it should be easy to modify it to do this,
specially given I really want to remove support for xml in the future

Just to clarify, this feature request here is not just for a possibility to mass convert from XML to SCN, but to do it only when exporting the game; the source file would stay in XML, or once the TSCN and TRES format have been completed, in those formats.

yeah, one of the reasons about TSCN is that it should be easier to do this,
given it's easier to parse. Right now opening and saving a xml scene would
also open all the dependencies, when instead we just want a simple
converter. When the loader is written, I will write it so it can be used to
simply convert from .tscn to scn
On Fri, Nov 13, 2015 at 10:06 AM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

with the new renaming tool, it should be easy to modify it to do this,
specially given I really want to remove support for xml in the future
Just to clarify, this feature request here is not just for a possibility
to mass convert from XML to SCN, but to do it only when exporting the game;
the source file would stay in XML, or once the TSCN and TRES format have
been completed, in those formats.
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/2778#issuecomment-156426969.

Note that what is requested here was apparently implemented in this unmerged PR: #461.

Fixed in da113fe4. (still need to test it though, but we'll open new tickets if there are issues with the current implementation)


Feature Request for a version of quote that pulls in meaningful span locations for each token

Tokens that originate within the quote! invocation are spanned with Span::call_site().

The span of the invocation of the current procedural macro. Identifiers created with this span will be resolved as if they were written directly at the macro call location.

meaning all tokens get the same Span: bytes(0..0):LineColumn { line: 1, column: 0 }-LineColumn { line: 1, column: 0 }
let q = quote! { ! };
let t: Token![!] = syn::parse2(q).unwrap();
println!("{:?}:{:?}-{:?}", t.span, t.span.start(), t.span.end());
assert_ne!(
   t.span.start(),
   t.span.end()
)

I don't know about macro_rules, but it seems that with procedural macros it would be possible to preserve token spans from an original source file where quote! is invoked. A quote! like this would be a great boon towards testing and debugging certain types of procedural macros.

This line of thought dead-ends and Span not having a public constructor perhaps, my bad.


Plan only on changed modules

According to the docs, when the command
terragrunt run-all plan

is applied,

This will recursively search the current working directory for any folders that contain Terragrunt modules and run plan in each one, concurrently, while respecting ordering defined via dependency and dependencies blocks.
Describe alternatives you've considered

As plan on large infrastructures could be costly, Is there a way to plan only on the changed modules.

As far as I know the best way is outlined in this document.
https://terragrunt.gruntwork.io/docs/features/keep-your-terragrunt-architecture-dry/#considerations-for-cicd-pipelines
You'd use git-diff to collect all changed files in a PR, and run terragrunt plan on each one using -terragrunt-config in a CI script.

I'd love for this kind of "change detection" to be incorporated into terragrunt itself. Something based on a "git committish", e.g. git diff --name-only {{ COMMITISH }}. A commitish is something like 1.0.0...HEAD, and when passed to git diff --name-only, would list all the files changed between the branch HEAD and the 1.0.0 ref/tag. Terragrunt would then have some logic to walk the dependency tree and note which "included" working-dirs would be impacted by any of those changed files and filter in only those things impacted (or filter out and exclude, depending on perspective)...

We use Terramate in our Terragrunt repos to add change detection. E.g., instead of running terragrunt apply-all we are now using terramate run --changed terragrunt apply, which runs the apply command on changed modules only.
What I like about Terramate is that it can be onboarded to any Terragrunt repository with a single command and without introducing any changes to our code.

Bad stalebot. You're dismissed.


Update request: gegl 0.4.46 → 0.4.48

Package name: gegl
Latest released version: 0.4.48

Current version on the unstable channel: 0.4.46
Current version on the stable/release channel: 0.4.46

[x] Checked the nixpkgs pull requests

Notify maintainers

@jtojnar
I can take over the package if you wish.

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

If you are able to bump the package (and babl), feel free. I probably will not be able to get to it this week.


Update machine-learning-web-services-logging.md

Hi @raymondlaghaeian, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (raymondl). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Filer UI new features

Add more features for Filer UI

Create Folder button.
Show upload file progress.
Delete file/folder button.
Rename file/folder button.
Add placeholder for empty folder to make drag and drop works.

I noticed in a fresh installation with everything empty. The first file upload via the UI does not update the UI.


Unable to install extension on vscode/Windows 10

Issue Type: Bug
Installed the latest stable version of vscode on new Windows 10 laptop and tried to install the markdownlint extension. The installation failed with the error:

EBUSY: resource busy or locked, rename 'C:\Users\aearnshaw.vscode\extensions.davidanson.vscode-markdownlint-0.34.0' -> 'C:\Users\aearnshaw.vscode\extensions\davidanson.vscode-markdownlint-0.34.0'
Failed Installing Extensions: DavidAnson.vscode-markdownlint

I was able to install the extension manually with the extension author's help.
However, when someone from vscode looked at the issue they indicated it was a vscode bug so I am opening it here.
More details are available on this issue in markdownlint project https://github.com/DavidAnson/vscode-markdownlint/issues/104
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 4.4.0-18362-Microsoft

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.73GB (7.03GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-18.04

OS
Linux x64 4.4.0-18362-Microsoft

CPUs
Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz (12 x 2592)

Memory (System)
15.73GB (7.03GB free)

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

remote-wsl
ms-
0.41.9

vscode-markdownlint
Dav
0.34.0

markdown-shortcuts
mdi
0.12.0

code-spell-checker
str
1.7.22

errorlens
use
2.9.0

@sandy081 I've created this issue as requested

@bpasero I am using path module in common and it is not joining correctly when a folder starts with .
https://github.com/microsoft/vscode/blob/57ac3ed29dbefcd74377cca6f2df284f302a4076/src/vs/platform/extensionManagement/node/extensionManagementService.ts#L464-L465

@sandy081 please follow up with @sbatten who created this library from the node.js version. Check if you can reproduce with bare node.js and if not we might have to bring our library up to speed with latest.

@sbatten Can you please provide steps for the user to repro it using node.js.

@sandy081 can we not simply conduct a test ourselves to join a path with "." in node.js and compare that to our version?

join('C:\\Users\\sbatten\\Desktop', '.myFolder') produces the same output for our module and the node version.
Output C:\Users\sbatten\Desktop\.myFolder
Node Version v10.16.2

@sbatten Can you please provide steps to user to repeat the same on their machine?

I don't think we could ever reproduce this, I am closing as not-reproducible now. If we get more cases/info in the future we can re-open


Install page displayed after successful installation of Shopify store

I have used the plugin and followed all the steps . After successful installation and registering the Shopify domain, it should redirect to the next page but the same install page is displayed every time.

Im getting this error also, it does return the code on the url. But I cant move around even with the code on the url to any other pages Ive created. Did you resolve this?


Need OpenAPI Specification for Business Central API V2.0

Hi,
It would be great if there is an OpenAPI Specification for Business Central API V2.0 provided at the earliest.
The problem that we are facing is creating a Java SDK for Business Central API V2.0 .
Currently there does not seem to be a solution for creating a Java SDK for Business Central APIs based on the OData Metadata file.
Please expedite this requirement for an OpenAPI Spec for Business Central API ver 2.0, so that we can use swagger-codegen-cli for generating the Java SDK.
Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1baf2582-6d3b-68da-47b9-f42f81ad0f9c
Version Independent ID: 25a0b3d1-0de8-bce1-083c-974f8921acfb
Content: OpenAPI Specification - Business Central
Content Source: dev-itpro/api-reference/v2.0/dynamics-open-api.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for your feedback. This repo is used for documentation feedback. Please go to Ideas to suggest a product feature. Thanks

Added Idea in Dynamics 365 Business Central Ideas section
https://experience.dynamics.com/ideas/idea/?ideaid=1af5d907-ccdd-ed11-9139-0003ff45de26


use real references in application logic instead of id's

as discussed; most store logic becomes simpler when just passing around objects instead of id's. With mutable data structures you can safely do this, because after each mutation all references lingering around are still valid and fresh.
I tried to keep all the code as much as possible in the current code style. But some of the pre conditions in the store functions could probably removed to futher simplify stuff.
Did some minor renaming in variable names that were postfixed with  Id but actually contained an index position, to avoid confusion.

I'll do that variable name cleanup for my book as well. Thanks for pointing that out.


Feature Request : Ability to customise left and right header buttons

It would be useful to be able to further customise the left and right header buttons.
What do people think of the following suggestions...
Left (Back) header button : The ability to define a custom component (icon) to sit inside the back button whilst keeping the current functionality
Right header button : The ability to use navigation methods inside the navigationOptions static component class property to switch between screens on press (maybe this is already an option?)

The last suggestion is already implemented. You can do this:
static navigationOptions = {
  header: (navigation, header) => ({
    ...header,
    right: (
      <TouchableOpacity onPress={() => navigation.navigate('Settings')}>
        <Text>Settings</Text>
      </TouchableOpacity>
    )
  })
}

@davidskaarup your a legend, thanks for this!! :)

And if you want to link the button to your component:
    componentDidMount() {
        const params = {
            right: (
                <Button
                    onPress={() => { this.save(); }}
                    title={"Save"}
                />
            ),
        };

        this.props.navigation.setParams(params);
    }

Then in your navigation properties add:
MyScreen.navigationOptions = {
    title: 'Add',
    header: ({ state }) => {

       // we link through state.params.right
        return {
            right: (state.params && state.params.right)
        };
    }
};

@Paul-Todd this is very useful. Thanks for posting. I'm starting to wish i could star this project twice :)

@Paul-Todd  This useful, thanks!, but it seems like a strange solution for something that should be easier to do

The other tip is how to hide tabs - took me a couple of posts here to figure out how to do it.
We have:
tabnav->stacknav->view->leaf-view.
HomeScreenNavigator -> DashboardNavigator -> DashboardScreen -> SettingScreen
The leaf-view (SettingsScreen) is the one we want to display full screen so we dont want tabs here.
The most important thing to note below is the props are merged from the settings screen to the tabnav and the tabBarProps parameter in the tabBar callback is spread using ... and then the fields are updated so the tabBar declaration in the settings screen (leaf-view above) is merged with the tabBar settings here and then returned.
TabNavigator
const HomeScreenNavigator = TabNavigator({
    dashboard: {
        screen: DashboardNavigator,
        navigationOptions: {
            title: "Dashboard",

            tabBar: (navigation, tabBarProps) => {
                return {
                    ...tabBarProps,
                    label: 'Dashboard',
                    icon: ({ tintColor, focused }) => {
                        return (
                            <FontAwesome
                                name={'tachometer'}
                                size={26}
                                style={{ color: tintColor }}
                            />);
                    	}
                	};
            	}
        	}
    	}
	});

StackNavigator
This needs a stack navigator with the root view to go into the tab and a settings view that does not want to have tabs visible.
const DashboardNavigator = StackNavigator({
    root: { screen: DashboardScreen },
    settings: { screen: SettingsScreen },
});

The view to go into the tab is DashboardScreen - clicking on the settings
button in the header top right goes to the settings screen.
DashboardScreen.navigationOptions = {
    title: 'Dashboard',
    header: ({ navigate }) => {
        return {
            titleStyle: {
                color: Theme.lightText,

            },
            style: {
                backgroundColor: Theme.basis
            },
            right: (
                <Button
                    title={'Settings'}
                    onPress={() => {
                        navigate('settings');
                    }}
                />
            )
        };
    }
};

And finally the settings screen. We define here that we want to hide the tabbar.
Note the tabBar property in the navigationOptions below for the settings view but is propagated down to the HomeScreenNavigator
SettingScreen.navigationOptions = {
    title: 'Settings',
    header: {
        titleStyle: {
            color: Theme.lightText
        },
        style: {
            backgroundColor: Theme.basis
        },
    },
    tabBar: {
        visible: false
    }
};

Is it possible to hide the right button. I don't want to have the back button on some screens of my app. How do I implement this?

@Kabangi just do right: null instead of right: ''.
As per the original request, I feel like defining a custom label is a responsibility for a custom left component one should set on navigationOptions. We are working on improving built-in look & feel to make it look as native as possible and so, I believe that tintColor is the only reasonable config that should be accepted for a default button.
Feel free to re-open if I misunderstood your original request :)

I too would like to only override the onPress behaviour. Having to create an entire react component that looks like that duck but doesn't behave like it seems overkill.

@mvanroon - that seems somewhat reasonable I think you'd find that isn't sufficient. it'd work for ios if you want to prevent someone from going back in certain circumstances, but then how do you block the hardware back button on android from preventing it?


Crawl the initial URL twice

What is the current behavior?
Crawl twice the front page when the enqueued URL doesn't contain an end slash
If the current behavior is a bug, please provide the steps to reproduce
Configure a queue with a domain as https://example.com then the page has a link as Home
What is the expected behavior?
It should only crawl once the front page
What is the motivation / use case for changing the behavior?
In case we export data from the initial page, we might have twice the data.
Please tell us about your environment:

Version: 1.4.0
Platform / OS version: Ubuntu 16.04 LTS
Node.js version: 9.7.1

The current workaround is to ensure that we set a URL in the queue with the end slash.

@yvmarques Thanks for reporting a bug!


Added confirm_password feature to views generator

PR adds an ability to generate Rails view for Confirm Password feature (https://rodauth.jeremyevans.net/rdoc/files/doc/confirm_password_rdoc.html).

Good catch, thanks for the fix!


[release/1.4-stable] Update to CsWinRT 2.0.3

A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the develop branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.
For status checks on the main branch, please use microsoft.ProjectReunion
(https://dev.azure.com/ms/ProjectReunion/_build?definitionId=391&_a=summary)
and run the build against your PR branch with the default parameters.

/azp run

(assuming shiproom approval)

PR build (20230717.2) succeeded.


Update README.md

@priyansh32 this is just some minor updates to test the traffico code. Hopefully the file pointing in the app is correct.

Sure will do that, But I think a merged PR will be counted towards hacktoberfest even if it's not tagged in a participating repository 🙂.

It didn't get tracked. Their docs say - Add the 'Hacktoberfest' topic to your repository/project so that folks know you're participating in Hacktoberfest. From what I know only issues or PRs with the label seem to be tracked.

also can I contact you on twitter?

Yeah, you don't need to ask. Go for it 😄


fix typo in explanation on About CC Search page

I noticed this sentence has a typo:
Creative Commons’ “CC Search” project will develop and release an open online search and re-use tool that will allow high-quality content from the commons to surface more seamless and accessible.
Maybe "more seamlessly and accessibly" or "in a more seamless and accessible way" ?

Changed to "in a more seamless and accessible way", though this was @ryanmerkley's text so please reopen if you'd like something different.


Automatically create a secret in the default namespace that contains cluster access auth info

When a cluster is created automatically make a kubernetes-auth secret that contains the basic auth, bearer token auth and certs to allow applications running inside pods to access the apiserver etc.

@roberthbailey @zmerlynn

Will #7101 do this for us automatically? @liggitt

I see that we already have:
$ kubectl get secrets
NAME                              TYPE      DATA
token-admin                       Opaque    1
token-kube-proxy                  Opaque    1
token-kubelet                     Opaque    1
token-system-controller-manager   Opaque    1
token-system-dns                  Opaque    1
token-system-logging              Opaque    1
token-system-monitoring           Opaque    1
token-system-scheduler            Opaque    1

For GCE/GKE we do (@erictune added them to cluster/gce/configure-vm.sh).

Note that these are all just bearer tokens and they don't contain the CA root cert which we need to distribute for #7964.

#7101 will get automatically get you bearer tokens for service accounts, but that's it. There was discussion about following that with adding a kubeconfig key to the secret which bundled the ca cert and the token together

Let's not use the admin account for pods.  Secrets are for pods.  So let's
not put the admin secrets in secret resources.
On May 8, 2015 12:56 PM, "Jordan Liggitt"<EMAIL_ADDRESS>wrote:

#7101 https://github.com/GoogleCloudPlatform/kubernetes/pull/7101 will
get automatically get you bearer tokens for service accounts, but that's
it. There was discussion about following that with adding a kubeconfig key
to the secret which bundled the ca cert and the token together
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/7979#issuecomment-100340393
.

@erictune : have I done the wrong thing in PR ##7988 ?

I created token-system-logging with the hope that it would be used for elasticsearch.   So I am a little sad that #7988 used token-admin.  :crying_cat_face:

Let me look into this and see if I can switch to token-system-logging

What's the status on this?  It seems that tokens are a big issue for many people but I guess a lot of it has to do with doing upgrades.  Do we think this issue is something we want to do?  If not, let's close it out.

I can't help thinking that we will keep wanting to make system pods that want to make Kuebernetes API calls but perhaps we should wait until there is a clear demand for this scenario.

Doesn't service accounts handle this?
On Fri, Jun 5, 2015 at 12:42 AM, Satnam Singh<EMAIL_ADDRESS>wrote:

I can't help thinking that we will keep wanting to make system pods that
want to make Kuebernetes API calls but perhaps we should wait until there
is a clear demand for this scenario.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/7979#issuecomment-109192341
.

Doesn't service accounts handle this?

Yes. Room for improvement (including the CA or a kubeconfig with the token as well), but yes... that's how pods get API credentials.