Filter to export non-resource files should accept full file names instead of always requiring wildcard selectors

Godot version:

3..0.1
OS/device including version:

Windows 10
Issue description:

While exporting the game, there's a filter to list the non-resource files that you still want to get packed along with the game resources. However, this field only accepts wildcards entries. I think it would be great if it also accepted individual full names. Say I want to export error_list.txt.
This works.

This doesn't work.

This also doesn't work but it would be nice if it did just for those edge-cases.

It's generally just a small QoL improvement over the currently implemented one.

There doesn't appear to be a way to filter for folders or paths either, this doesn't work:

Does prefixing the folder with res:// work?

@neikeq Yes, it does. res://Assets/* works, this fixed some of the issues I was having with exports.

This filter works bad.
.json files are always exported, no mathers if are in this filter
.txt files are included if are in the filter
other personal extensions (EJ: .ajson, .tjson) never exports, no mathers if are in the filter.
This should be fixed for 3.2....
Related (buggy, not fully accomplished) https://github.com/godotengine/godot/issues/9860

I am testing this problem in Godot 3.2 stable and in linux mint 19.02 it does not export the folder separately, in my case I want to use a .txt file from the application but it does not export the file.txt

If I export the project by choosing only the scenes and since I am using a .txt file for reading reading to test directly, the program closes

Console
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
``ariel@ariel:~$ '/home/ariel/Escritorio/exportado yousef/index.x86_64'
Godot Engine v3.2.stable.official - https://godotengine.org
OpenGL ES 2.0 Renderer: GeForce 9800 GT/PCIe/SSE2
ERROR: load_interactive: Condition "err != OK" is true. Returned: Ref()
At: scene/resources/resource_format_text.cpp:1228.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: SceneTree: Default Environment as specified in Project Settings (Rendering -> Environment -> Default Environment) could not be loaded.
At: scene/main/scene_tree.cpp:2115.
ERROR: load_source_code: Condition "err" is true. Returned: err
At: modules/gdscript/gdscript.cpp:806.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: modules/gdscript/gdscript.cpp:2244.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: start: Condition "res.is_null()" is true. Continuing.
At: main/main.cpp:1684.
WARNING: _update_root_rect: Font oversampling only works with the resize modes 'Keep Width', 'Keep Height', and 'Expand'.
At: scene/main/scene_tree.cpp:1153.
ERROR: load_interactive: Condition "err != OK" is true. Returned: Ref()
At: core/io/resource_format_binary.cpp:986.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: Method failed. Returning: error
At: core/io/resource_format_binary.cpp:655.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/suelos/solo_suelo/roca.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas_importadas/suelos/roca.glb
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/suelos/suelos_terminados/mosaico_roca.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas/suelos/solo_suelo/roca.tscn
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/Escena_principal.tscn:6 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas/suelos/suelos_terminados/mosaico_roca.tscn
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: start: Condition "!scene" is true. Returned: false
At: main/main.cpp:1864.
ERROR: ~List: Condition "_first != __null" is true.
At: ./core/self_list.h:112.
ERROR: ~List: Condition "_first != __null" is true.
At: ./core/self_list.h:112.
WARNING: cleanup: ObjectDB Instances still exist!
At: core/object.cpp:2071.
ariel@ariel:~$

@kone9 You should include just base_de_datos/* instead of res://. We should throw an error about this :slightly_smiling_face:

@kone9 You should include just base_de_datos/* instead of res://. We should throw an error about this

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

In this case, the program closes and the console shows this.
``ariel@ariel:~$ '/home/ariel/Escritorio/exportado yousef/index.x86_64'
Godot Engine v3.2.stable.official - https://godotengine.org
OpenGL ES 2.0 Renderer: GeForce 9800 GT/PCIe/SSE2
ERROR: load_interactive: Condition "err != OK" is true. Returned: Ref()
At: scene/resources/resource_format_text.cpp:1228.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: SceneTree: Default Environment as specified in Project Settings (Rendering -> Environment -> Default Environment) could not be loaded.
At: scene/main/scene_tree.cpp:2115.
ERROR: load_source_code: Condition "err" is true. Returned: err
At: modules/gdscript/gdscript.cpp:806.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: modules/gdscript/gdscript.cpp:2244.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: start: Condition "res.is_null()" is true. Continuing.
At: main/main.cpp:1684.
WARNING: _update_root_rect: Font oversampling only works with the resize modes 'Keep Width', 'Keep Height', and 'Expand'.
At: scene/main/scene_tree.cpp:1153.
ERROR: load_interactive: Condition "err != OK" is true. Returned: Ref()
At: core/io/resource_format_binary.cpp:986.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: Method failed. Returning: error
At: core/io/resource_format_binary.cpp:655.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/suelos/solo_suelo/roca.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas_importadas/suelos/roca.glb
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/suelos/suelos_terminados/mosaico_roca.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas/suelos/solo_suelo/roca.tscn
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: poll: res://escenas/Escena_principal.tscn:6 - Parse Error: [ext_resource] referenced nonexistent resource at: res://escenas/suelos/suelos_terminados/mosaico_roca.tscn
At: scene/resources/resource_format_text.cpp:440.
ERROR: load: Condition "err != OK" is true. Returned: RES()
At: core/io/resource_loader.cpp:208.
ERROR: _load: Condition "found" is true. Returned: RES()
At: core/io/resource_loader.cpp:278.
ERROR: start: Condition "!scene" is true. Returned: false
At: main/main.cpp:1864.
ERROR: ~List: Condition "_first != __null" is true.
At: ./core/self_list.h:112.
ERROR: ~List: Condition "_first != __null" is true.
At: ./core/self_list.h:112.
WARNING: cleanup: ObjectDB Instances still exist!
At: core/object.cpp:2071.
ariel@ariel:~$

@kone9 You should include just base_de_datos/* instead of res://. We should throw an error about this

Even if the name changes, the exact same problem happens ..
Will it have to do with the file system?

I made this small project to change the numbers directly from the ".txt" and I leave it to test in my case in linux mint xfce 19.02 I could not export, I will have to install windows 10.
prueba exportar archivo godot.zip

Is this bug still a problem in Godot 4.x?

For me, in version 4.1.3, unfortunately yes... 😢

Same thing in 4.2.1... Is there a solution to this?

File filters use String.matchn() against full path, thus you can provide full file path if you don't want to use wildcards.
If that's not sufficient, open a proposal.


How can I load a "swin_large_patch4_window7_224_22k" model?

Actually, I successfully load the small type and base type model by --resume. But when I want to use large model, I get a message that:
"size mismatch for head.bias: copying a param with shape torch.Size([21841]) from checkpoint, the shape in current model is torch.Size([1000])."

Has this been resolved? Or is there currently no support for training a Swin-L model? I know we need both the pth file and the python config file.
I see config files for tiny, small, and base but none for large. Can we use a config like configs/swin/cascade_mask_rcnn_swin_base_patch4_window7_mstrain_480-800_giou_4conv1f_adamw_3x_coco.py with swin_large_patch4_window7_224_22k and have it work correctly?

Hi, friend, I have solved it. When you init the swin_transformer.SwinTransformer() ,  you need to set the num_classes as 21841 instead of 1000(it is default) ,  because it is "22k" model.  Good luck for you !

@zgj-gutou @cwq63 Perhaps my problem is same for theirs？
I'm using  my dataset & change some part which can work well in  ‘Swin-Transformer-Semantic-Segmentation
’code but show me errors in mmsegmentation swin code（with official pretrain model ‘upernet_swin_tiny_patch4_window7_512x512.pth’）：
size mismatch for stages.0.downsample.norm.weight: copying a param with shape torch.Size([384]) from checkpoint, the shape in current model is torch.Size([192]).
size mismatch for stages.0.downsample.norm.bias: copying a param with shape torch.Size([384]) from checkpoint, the shape in current model is torch.Size([192]).
Thanks for your help.


Fix for authentication

Authentication seemed to be broken on our master branch, logging in threw a strange error.
The issue was caused by the fact that merging #271 changed the way the REST response was parsed.
There were a couple of issues:

The result of the base response parsing service has changed
The list of EPersons returned by the server is not a list, just a single object
The EPerson returned by the REST in a status response, are not embedded, as would be expected
I solved these issues by updating the auth.service and the auth.response.parsing service. I made sure the EPerson is parsed and cached as expected by the RemoteDataService.

There was also an issue with logging off: The server returns an empty response, which was not accepted by the auth.interceptor. I fixed this by adding the 204 response code to the accepted response statuses.
I also added the functionality to stay on the page where you login, when it's not the login page itself.
There is still an issue with reloading the page when you're logged in. This is caused by a bug on the REST server that has a problem with the x-forwarded-for header when running the application locally: https://github.com/DSpace/dspace-angular/pull/275
There is a PR for this to fix it: https://github.com/DSpace/DSpace/pull/2207/files

Thanks for the updates & inline links to tickets, @LotteHofstede !  This looks great to me now.  Merging.


WebJobs Dashboard Management Functions Don't work

Creating this issue to track the set of WebJobs Dashboard functionality that doesn't work in Azure Functions (e.g. Replay, Abort, etc.)

Related issue: https://github.com/Azure/azure-webjobs-sdk-script/issues/1741

Other WebJobs dashboard features:

WebJobs is generally optimized at long-running (multihour) workloads. Along those lines, the dashboard provides real time updates per-parameter.  You can see things like "You've written 80,000 table rows; and spent 15 minutes in IO"


Dashboard Disconnect Uploading Imaging Level 2 Manifest

Describe the bug
DCA Dashboard disconnects when uploading Imaging Level 2 Manifest for HTAPP.
To Reproduce
Steps to reproduce the behavior:

Validate imaging level 2 manifest for HTAPP MERFISH Level 2.
Click on Submit Manifest.
Wait.
See disconnected from server error.

Validation goes as expected but app crashes when submitting.
Shows disconnected from server during submission/validation.
Manifest File:
_Imaging Level 2.csv

Apologies @PozhidayevaDarya, I only just spotted this.
Can try and debug.
FYI @aclayton555

@PozhidayevaDarya is this still an issue? If so can you open an HTAN service desk ticket and link here? Apologies if there already is one that has been dropped.

@PozhidayevaDarya is this still an issue? If so can you open an HTAN service desk ticket and link here? Apologies if there already is one that has been dropped.

Yep still happening and did it here: https://sagebionetworks.jira.com/browse/HTAN-203
Thanks!

Confirmed fixed in mtDCA.


Fix flaky test UpstreamCheckServiceTest#testScheduled

Codecov Report

Merging #1908 (c19ed6f) into master (717ac8e) will decrease coverage by 0.42%.
The diff coverage is n/a.

:exclamation: Current head c19ed6f differs from pull request most recent head 81177d9. Consider uploading reports for the commit 81177d9 to get more accurate results

@@             Coverage Diff              @@
##             master    #1908      +/-   ##
============================================
- Coverage     67.84%   67.42%   -0.43%
+ Complexity     2799     2789      -10
============================================
  Files           501      501
  Lines         11583    11580       -3
  Branches       1118     1116       -2
============================================
- Hits           7859     7808      -51
- Misses         3160     3205      +45
- Partials        564      567       +3

Impacted Files
Coverage Δ

...ache/shenyu/client/tars/common/dto/TarsRpcExt.java
0.00% <0.00%> (-30.77%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
64.70% <0.00%> (-29.42%)
:arrow_down:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
36.76% <0.00%> (-19.12%)
:arrow_down:

...che/shenyu/admin/model/vo/SelectorConditionVO.java
71.42% <0.00%> (-14.29%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
71.84% <0.00%> (-9.71%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.84% <0.00%> (-7.37%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
58.00% <0.00%> (-2.00%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

...rg/apache/shenyu/plugin/hystrix/HystrixPlugin.java
74.07% <0.00%> (-0.93%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717ac8e...81177d9. Read the comment docs.


Unpin wasm-bindgen to improve compatibility with other crates

Leptos can't be installed alongside another crate that uses a newer wasm-bindgen version. For example:
error: failed to select a version for `wasm-bindgen`.
    ... required by package `web-sys v0.3.72`
    ... which satisfies dependency `web-sys = "^0.3.72"` of package `crate-c v0.0.1`
    ... which satisfies dependency `crate-c` of package `crate-b v0.0.1`
versions that meet the requirements `^0.2.95` are: 0.2.95

all possible versions conflict with previously selected packages.

  previously selected package `wasm-bindgen v0.2.93`
    ... which satisfies dependency `wasm-bindgen = "=0.2.93"` of package `leptos v0.7.0-rc0`
    ... which satisfies dependency `leptos = "^0.7.0-rc0"` (locked to 0.7.0-rc0) of package `crate-a v0.0.1`

failed to select a version for `wasm-bindgen` which could resolve this conflict

Unpinning wasm-bindgen in Leptos should improve compatibility with other crates.

I'm aware wasm-bindgen doesn't adhere to semver, but pinning the version prevents users from even trying a newer version. There is a good chance newer versions of wasm-bindgen will work without modification. I tried my fix in a project and it works perfectly fine. In my opinion, the chance of it working with a newer version is preferable over refusing to even install. Additionally, it would allow early adopters to report bugs/incompatibilities with the newer version.

Pinning is required due to compatibility with cargo-leptos

Could you explain why this is required?

Pinning is required due to compatibility with cargo-leptos and also because breaking changes happen in wasm-bindgen in patch releases which do not follow server semantics. The whole ecosystem should adapt to the new version at once, but pinning may be required here.

Due to wasm-bindgen restrictions, the versions used for generating the binary and the file should be the same to prevent API usage violations.
You get the following error on version mismatch:
       it looks like the Rust project used to create this wasm file was linked against
       version of wasm-bindgen that uses a different bindgen format than this binary:

         rust wasm file schema version: 0.2.95 (94b266337)
            this binary schema version: 0.2.93 (94b266337)

       Currently the bindgen format is unstable enough that these two schema versions
       must exactly match. You can accomplish this by either updating this binary or
       the wasm-bindgen dependency in the Rust project.

I'm happy to let CI run on this PR. Looking at the cargo-leptos repo it looks like it has been updated to 0.2.95 but that a release has not been made. So I assume this will fail on the examples, but can make a new cargo-leptos release later and that should work.

Okay, so after publishing an updated cargo-leptos that uses 0.2.95 and letting CI run again, these (new! fun! exciting!) CI errors are unrelated. I'll merge this and rerelease as rc1.
For context and just FYI for the future, the reason I had pinned it was that, as described above, the wasm-bindgen-cli-support crate used by cargo-leptos won't allow us to compile anything with even a patch mismatch. There was a breaking change that removed needed APIs in wasm-bindgen-cli-support 0.2.94, making it impossible for us to update cargo-leptos and immediately release it, which meant every Leptos build using cargo-leptos was immediately broken unless the user manually pinned wasm-bindgen to =0.2.93. I took the expedient of pinning at the crate level.
This was a helpful nudge since all this needed was just a new c-l release from its current state.

@gbj assume that with the current state, wasm-bindgen releases a new version v0.2.96 and we suddenly try to run cargo update. Now we have mismatch versions, cargo-leptos uses v0.9.95 and the wasm-bindgen will not generate a binary. You get an error I mentioned in my previous comment. Due to restrictions of wasm-bindgen, we will get off the track without pinning this specific dependency easily and we should try to do the same in our codebase to pin wasm-bindgen until we have a new release from cargo-leptos.
IMHO, pinning is required here and we need synchronize releases for this dependency on both leptos and cargo-leptos. I know that coupling may not be a good idea, but it is required here until wasm-bindgen works on mismatch versions.
The solution to outdated dependencies is  to get notified by Dependabot by introducing Cargo.lock to act accordingly.

Thanks for merging this!
I looked into the cargo-leptos pinning issue a bit more. The only reason the version mismatch exists is because cargo-leptos is compiled with wasm-bindgen-cli-support.
I was using Trunk and didn't experience any issues. Trunk is not compiled with wasm-bindgen-cli, but instead finds the appropriate version to use from Trunk.toml/Cargo.lock/Cargo.toml. It then downloads the right binary to a cache and calls the binary to build the bindings.
Using a similar approach in cargo-leptos would solve the pinning issue. If this sounds like an interesting solution, I'd be happy to make a PR for cargo-leptos.

I am aware of both the issues and the trade-offs you describe in your comments, above. Over the course of the last couple years, the least painful way for us to manage wasm-bindgen's policy of breaking semver has been to simply update cargo-leptos and re-release as needed.
@sabify You have proposed adding Cargo.lock in #2881 and I replied, saying it was probably a good idea. Feel free to make a PR to add it.
@DanielleHuisman If you want to make a PR to change this behavior in cargo-leptos, feel free to open an issue there to discuss, or to make a PR. I know Ben is in the process of rewriting in any case, so some discussion with him before doing the work of a PR probably makes sense.
In any case I don't think more of either discussion should happen here, as conversations in the comments of closed PRs are hard to keep track of.


min_range_hours set to 0 treated as 1

I'm able to get it to function as 0 by rounding and selecting 0.01, but 0 does not work in the way I would expect.

The min_range_hours property does not expect 0 as a value, the minimum range expressed in hours can't be zero. Why should you set 0 for a range? Here's the code that handles your input:
this.min_range = ( settings.min_range_hours ) ? ( settings.min_range_hours * 60 * 60 * 1000 ) : ( 1 * 60 * 60 * 1000 );


Fix QHull port to use release version

Fix QHull port to use latest release version (2015.2), because current master/HEAD of QHull has some bugs.
Also, It is not good to always use master/HEAD. In many cases, It should be better to use release version.

@UnaNancyOwen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Yes, we should never be using master by default -- sorry this slipped through review!
Thanks for the PR!


Java tests failed on macOS x86

https://dev.azure.com/openvinoci/dldt/_build/results?buildId=532803&view=logs&jobId=6c23757f-dbf6-510b-3bd6-0534daaa0edf&j=6c23757f-dbf6-510b-3bd6-0534daaa0edf&t=c8ed29ce-b8ce-56bc-1bcc-381212a08266

Perhaps RPATH isn't set correctly when building openvino_contrib? @ilya-lavrenov how do we do this for openvino samples?

RPATHs are not needed during the build. Cmake files stores all information
During samples build we use OpenVINO_DIR env vars set by setupvars.sh

This is not a build error, it's a runtime error. More specifically Java related. Does the JVM / Java runtime pick up environment variables set by setupvars.sh on MacOS?

There is definitely one issue with TBB detection: https://github.com/openvinotoolkit/openvino_contrib/blob/a25726a04e8ff57708cd5f8a49a3977186214430/modules/java_api/build.gradle#L27
2022.3: https://storage.openvinotoolkit.org/repositories/openvino/packages/2022.3/macos/m_openvino_toolkit_macos_10_15_2<IP_ADDRESS>52.9752fafe8eb_x86_64.tgz
$ tree runtime/3rdparty/tbb/
runtime/3rdparty/tbb/
├── LICENSE
├── cmake
│   ├── TBBConfig.cmake
│   └── TBBConfigVersion.cmake
├── include
└── lib
    ├── libtbb.dylib
...

But
2023.0: https://storage.openvinotoolkit.org/repositories/openvino/packages/master/2023.0.0.dev20230407/m_openvino_toolkit_macos_10_15_2023.0.0.dev20230407_x86_64.tgz
$ tree runtime/3rdparty/tbb/
runtime/3rdparty/tbb/
├── LICENSE
├── include
└── lib
    ├── cmake
    │   └── TBB
    │       ├── TBBConfig.cmake
    │       ├── TBBConfigVersion.cmake
    │       ├── TBBTargets-debug.cmake
    │       ├── TBBTargets-release.cmake
    │       └── TBBTargets.cmake
    ├── libtbb.dylib -> libtbb.12.dylib
...

So now it should be something like
def native_resources = [
    System.getenv('INTEL_OPENVINO_DIR') + "/runtime/lib/intel64",  // UNIX
    System.getenv('INTEL_OPENVINO_DIR') + "/runtime/lib/intel64/Release",  // Mac
    System.getenv('INTEL_OPENVINO_DIR') + "/runtime/bin/intel64/Release",  // Windows
    System.getenv('TBB_DIR') + "/../lib/",
    System.getenv('TBB_DIR') + "/../../",
]

@ilya-lavrenov can we close it?

Tests are red now https://github.com/openvinotoolkit/openvino_contrib/runs/14113209799

https://github.com/openvinotoolkit/openvino_contrib/pull/650 has not been ported to master


[Automated] Update eventing-istio-eventing nightly

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads
Produced via:
for x in eventing-core.yaml eventing-crds.yaml in-memory-channel.yaml mt-channel-broker.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

/retest-required

/test integration-tests

/test integration-tests

we need https://github.com/knative-extensions/eventing-istio/pull/327 first

/retest-required


VS code crashing(Window has crashed)

Issue Type: Bug
This happens only when opening java file.
Try to open any java file from the java project it crashes every time
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.17763
Extensions (23)

Extension
Author (truncated)
Version

azds
azu
1.0.120190715

docs-yaml
doc
0.2.3

docker-explorer
for
0.1.6

shell-format
fox
6.1.1

vscode-javac
geo
0.2.21

cloudcode
goo
0.0.11

azure-pipelines
ms-
1.155.0

vscode-docker
ms-
0.7.0

python
ms-
2019.8.29288

vscode-ai
ms-
0.5.1

azure-account
ms-
0.8.4

azurecli
ms-
0.4.6

team
ms-
1.149.2

java
red
0.47.0

vscode-yaml
red
0.4.1

java-checkstyle
tho
1.1.1

vscodeintellicode
Vis
1.1.8

vscode-java-debug
vsc
0.20.0

vscode-java-debugger-azds
vsc
0.2.2

vscode-java-dependency
vsc
0.5.1

vscode-java-pack
vsc
0.7.1

vscode-java-test
vsc
0.18.2

vscode-maven
vsc
0.18.1

Can you start by opening issues for the Java extension? Thanks.


Increase maximum fixture group dimensions that UI accepts as valid.

Fixture group maximum dimensions are limited in UI. One can easily create fixture group larger than 99px by 99px by adding RGB panel, but can not enter dimensions larger than 99px by 99px in fixture group editor or create dialog.
I increased limit to 999, which should suit most of us for time being.

Thanks :+1:


Editing completed tasks crash

Editing a completed task crashes the game.

Can't reproduce on my save. Can you reproduce this ?

Cannot reproduce with current version.


Salesforce Not in Identity Providers in AAD B2C

The documentation states that there is a Salesforce Identity Provider, but that is not reflected on the site.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4feda2d5-79cd-ddea-51e5-4cf3b8b80566
Version Independent ID: 244ed0a8-5981-3ddc-7556-b9bf50243113
Content: Add an identity provider - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/add-identity-provider.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@swmolen The document actually describes the available Identity providers plus those which can be added manually by following the links.

The article shows which all IDP are possible, the portal shows the current list of all IDPs for whom the integration is done by default from Service. More IDPs can appear here in future.

Okay. You should make the documentation more clear. "After adding Salesforce as an Identity Provider (see the last step), you can then go to your user flow and select "Salesforce" or whatever name you assigned as your identity provider. @vipulsparsh

Thanks for the feedback. I'm updating the identity providers with the guidance you have suggested. The updated version will be published later today, and this GitHub issue will be closed automatically. Again, thanks for your feedback.
Yoel


DockerInstaller task permission issues on version 0.213.0

Note
It seems the PR #17131 introduced a bug
Required Information
Question, Bug, or Feature?
Type: Bug
Enter Task Name: DockerInstaller@0
list here (V# not needed):
https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/DockerInstallerV0
Environment

Azure Pipelines, hosted agent, os ubuntu-latest

Issue Description
In the PR #17131 (so from version 0.213.0) the permissions have been modified, since that moment the DockerInstaller task is not able to detect the correct downloaded version:

Later in the pipeline I tried to run a docker -v command and got the following error:

Pipeline example:
trigger: none

pool:
  vmImage: ubuntu-latest

steps:
- task: DockerInstaller@0
  inputs:
    dockerVersion: '19.03.8'

- task: PowerShell@2
  inputs:
    targetType: 'inline'
    script: 'docker -v'

Task logs
Troubleshooting
Error logs

Can confirm the issue, all our docker pipelines are broken as of today :confused:

@bluenote10 as a temp workaround you can fix the version of the task in the yml file
- task<EMAIL_ADDRESS>  inputs:
    dockerVersion: '19.03.8'

same issue with KubernetesV1

fix in progress #17442

@jedimanu-ux can you please share the pipeline logs?

Was the fix released? The docker task still fails for 0.214.0

The PR has been created and merged for this issue and mapped with 216 version.
https://github.com/microsoft/azure-pipelines-tasks/pull/17547/files


Remove monitored_conditions from netgear_lte

Breaking Change:
The netgear_lte integration has removed monitored_conditionsand now always adds all possible sensors and binary sensors, though most are disabled by default. See the PR link for more information.
Breaking Change, more information:
A (big) number of sensors are now automatically created from information provided by the Netgear modem. For convenience, here is a mapping of former monitored_conditions names to the new default entity_id names:
upstream                 => sensor.netgear_lte_failover_backhaul
connection_text          => sensor.netgear_lte_wwan_connectiontext
connection_type          => sensor.netgear_lte_wwan_connectiontype
current_nw_service_type  => sensor.netgear_lte_wwan_currentnwservicetype
current_ps_service_type  => sensor.netgear_lte_wwan_currentpsservicetype
register_network_display => sensor.netgear_lte_wwan_registernetworkdisplay
radio_quality            => sensor.netgear_lte_wwanadv_radioquality
rx_level                 => sensor.netgear_lte_wwanadv_rxlevel
tx_level                 => sensor.netgear_lte_wwanadv_txlevel
current_band             => sensor.netgear_lte_wwanadv_curband
cell_id                  => sensor.netgear_lte_wwanadv_cellid

That is just a list of those that have changed, you will get many new ones as well. The new names are a bit odd since they are built automatically from information provided by the modem.
The new sensors are disabled by default. If you want to enable one, go to the Configuration page, locate the entity in the Entity Registry and click it to be able to modify it.
Description:
This is my rework of #25979, now removing monitored_conditions and using the new entity_registry_enabled_default to add all sensors. Only the data usage sensor is enabled by default.
I have removed the explicit naming of most sensors since they are now available as generic sensors. This is a breaking change where entity_id changes.
The supporting library is updated to reveal not quite as many values (excluding, for example, the SMS inbox).
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
netgear_lte:
  - host: !secret lb2120_hostname
    password: !secret lb2120_password
    notify:
      - name: sms
        recipient:
          - !secret lb2120_phone
    # No longer any sensor: section
    # No longer any binary_sensor: section

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[X] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[X] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[X] Untested files have been added to .coveragerc.

Please add to the breaking change paragraph what the user needs to do to cope with the breaking change.

I don't see how the entity names or entity_ids change.

I added a note that subsections sensor: and binary_sensor: must be removed. I will add a documentation PR no later than tomorrow.

I am closing this until the beta is cut. I want to add a config entry and might as well ship it all at once.


Add HttpVersion parameter to Invoke-WebRequest cmdlet

PR Summary
Fix https://github.com/PowerShell/PowerShell/issues/12641

Add HttpVersionCompletionsAttribute with completions 1.0, 1.1, 2.0, 3.0
Handle input conversions from string, int and double to Version (generalize ArgumentToVersionTransformationAttribute from Set-StrictMode)
Enrich Verbose mesasge for request with http version and uri
Add pester tests for HttpVersion completions
Add xUnit tests for ArgumentToVersionTransformationAttribute

PR Context
This PR addressed to issue https://github.com/PowerShell/PowerShell/issues/12641
At the moment impossible make requests to network resources served only with HTTP/2 cause of default http version in HttpRequestMessage.Version=1.1
Changes in this PR allow to set http version during invocation Invoke-RestMethod or Invoke-WebRequest
This is my first PR to PowerShell. I have a couple of questions about tests. How and where to implement (at least point me right place please).
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

As for test, I think we have no need to do real HTTP requests with specified version since we utilize .Net Runtime features. I think it would enough if you did manual checks and shared results.
Nevertheless, we must verify that (1) the parameter accepts well-know values without throw, (2) transformation attribute works (it could be xUnit tests), (3) tab-completion works.

do you mean a pester test?
done with xunit
done with xunit

I have no idea about failed tests )
What is that? )

while we keep silence
I thought with your blessing I can update docs for this PR

You can open new issue in PowerShell-Docs repository and add reference in the PR description.

@hayhay27 Thanks you for your contribution!
A new parameter -HttpVersion is added but there is no test case to validate the use of this new parameter. Can you please add functional tests to validate if this new parameter works as expected?

@daxian-dbw Can you confirm that CI OS-s we use support HTTP3 and it is enabled by default? I think we can do only manual check today.

@daxian-dbw Can you confirm that CI OS-s we use support HTTP3 and it is enabled by default? I think we can do only manual check today.

We can do it only for 1.0, 1.1, 2.0. I think we can extrapolate results to 3.0
Could you point me same tests (right place) where I can add new one.

I don't know whether the VMs used in CI support HTTP3, but yes, at least validate the new parameter for 1.0, 1.1, and 2.0.
You can find the WebCmdlets.test.ps1 at https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1, which contains all tests for Invoke-WebRequest and Invoke-RestMethod.
I already requested the Cmdlet WG to review this PR and the corresponding issue.

@hayhay27 Please look CodeFactor issues.

@hayhay27 Please look CodeFactor issues.

Just one question. How to check code style locally?

@hayhay27 Please look CodeFactor issues.

Just one question. How to check code style locally?

You have no need to do this locally - see CofeFactor report in the PR.
(but you could temporary add the package https://github.com/DotNetAnalyzers/StyleCopAnalyzers)

@iSazonov
Hi! What can I do to complete this PR?

@hayhay27 This PR and the corresponding issue need to be reviewed by Cmdlet Working Group. I just pinged that WG again. Thank you for your patience!

The changes in this PR look good and I think the actual feature addition is great. Made some style comments

@rjmholt Thanks a lot!
I applied all your comments

@hayhay27 Thank you for your contribution!


fix: allow rule with empty schedule expression

Closes: #1984
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test all

/retest

/retest

/test all

@embano1 time to ship a new release?

@embano1 time to ship a new release?

if we need, sure. or we wait until I fix the related issue?


Add privavy disclaimers

Let the users know we will store telemetry and metadata, and they may unsubscribe

Today we don't log anything on users, tomorrow it will be the case so need to let the user now and handle consent properly


503

When I'm trying to watch live (or watch recorded streams), I get a 503 error in the wui log
]
  killed: false,
  code: 1,
  signal: null,
  cmd: '/bin/sh -c avconv -f mpegts -ss 30.5 -r 10 -i "./recorded/filename_here.m2ts" -ss 1.5 -r 10 -frames:v 1 -c:v mjpeg -an -f image2 -s 640x360 -map 0:0 -y pipe:1' }
27 Mar 14:38:16 - 200(!503) GET:/api/recorded/gr1056-hue/preview.txt?width=640&height=360&pos=32 ::ffff:<IP_ADDRESS> Firefox/37.0```

I tried changing all the chinachu permissions to 777 and that didn't work, any ideas? ( I'm using Debian Wheezy )

please back the permissions to default. 777 may not recommended.
we updated #175 and fixed few problems related to video streaming.
can you check it? please just update to latest Chinachu.

ping @fantastiic

Everything works already ^^

good :)


Clarifications

Hi, kindly seeking guidance on these commits - they're small changes just to make usage a bit more clear, as I had small misunderstandings when I first used the code.

@boseongkim32
Thanks for the RP.
We will merge them.
We will also release ver 1.0 soon.
Please wait a little.


Resource Change Notifications

AWS Perspective uses AWS Config to collect data about the AWS resources within your accounts and regions. It currently queries AWS Config at regular intervals to keep track of what is changing within discoverable accounts. We would like to move away from the pull approach and towards a push mechanism. This would involve integrating with AWS Config Events. Perspective would do an initial scan using AWS Config on deployment and importing of new accounts and regions. It will then react to AWS Config Events to ensure our data set it kept up to date with the changes you are making. We propose the following:

Implement notifications based on AWS Config Events, letting you configure when you will be notified of changes to particular resources or resource types. These will be clickable, so you can see related resources.
Remove the need to run the discovery process at regular intervals, as we will react to changes sent via AWS Config Events.
Automatically update your architecture diagrams whenever a resource within it changes.

We evaluated this request and it is not prioritized in the immediate roadmap for the solution.


12 pcb add shield template to help extension bootstraping

Added a folder called templates with a Kicad project with an empty shield inside
fixes #12

Not sure why but the empty shield 3d rendering put all pin headers pointing toward the top:
On the LH2 shield, the left/right pin headers are pointing toward the bottom:

Otherwise, looking at the repository organization, do you think it would make sense to have something like this:
├── DotBot.pcb
├── DotBot.pro
├── DotBot.sch
└── shields
    ├── lh2
    │   ├── DotBot-LH2-shield.pcb
    │   ├── DotBot-LH2-shield.pro
    │   └── DotBot-LH2-shield.sch
    └── template
        ├── DotBot-template-shield.pcb
        ├── DotBot-template-shield.pro
        └── DotBot-template-shield.sch


Software Development Questions

The uploaded file contains all my curated questions on Software Development for the 3MTT program.

Hey there @talktonok , thanks for review.
I am not sure if we are requested to curate our questions in a tabular form for software development.

Hey there @talktonok , thanks for review. I am not sure if we are requested to curate our questions in a tabular form for software development. But i will check it out.

Hi @Luckyjoseph, good work. but the observation by @talktonok is valid and i think it was stated in the ReadMe document. just go through it again. it may be a lot of work but my brother i encourage you to try. im currently working on mine

This is a great work. I ready to assist with the refactoring, should my assistant be needed

@Luckyjoseph reach out to @udofia2 if you need help revamping your questions to ensure it conforms to our template. @udofia2  is always willingly to help.

Plus, it will be great if you can add more questions to it.

Hey there @udofia2 @EmmanuelTheCoder
I just added a new commit with the updated questions following all the necessary patterns. Please, help me have a look.

This is great @Luckyjoseph. Thanks.


token usable even if expired

After the expiration time, the token is still considerate usable.
I checked the result with verifyToken method and it returns false, that is correct, but the application simply ignore it.
I read on web that I should set CACHE_DRIVER = file but where I can set it? I need step-by-step help.
Thank you!

Please provide an example token together with a key for testing.

token
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJoZWFkZXIiOnsiaWQiOiJmYWJyaXppbyIsInVzZXIiOiIkMnkkMTAka0JtSmVDWEx0SUpxRTZaUnI5U2VkLk9FNUxVOGlsUzN0OHRBSjdmOHc1UGtTOVUwN2ZWTjYifSwicGF5bG9hZCI6eyJpYXQiOiIyMDE4LTAzLTE0IDA3OjU4OjQ1IiwiZXhwIjoiMjAxOC0wMy0xNCAwOTo1ODo0NSJ9fQ.r7O6Jm1nHjvdYNeEXbhKv4hdNPyBTg1VQvrHAGwCpTM
key
Zgg5DiUW6XHADC2VCayaW91ksCwEnwQM
and here the method to create the token
public static function getToken($id, $user) {
		$secret = SECRET;
		// date: now
		$now = date('Y-m-d H:i:s');
		// date: now +2 hours
		$future = date('Y-m-d H:i:s', mktime(date('H') + 2, date('i'), date('s'), date('m'), date('d'), date('Y')));
		$token = array(
			'header' => [ // User Information
				'id' => $id, // User id
				'user' => $user // username
			],
			'payload' => [
				'iat' => $now, // Start time of the token
				'exp' => $future // Time the token expires (+2 hours)
			]
		);
		// Encode Jwt Authentication Token
		return JWT::encode($token, $secret, "HS256");
	}

The payload of your token is:
{
  "header": {
    "id": "fabrizio",
    "user": "$2y$10$kBmJeCXLtIJqE6ZRr9Sed.OE5LU8ilS3t8tAJ7f8w5PkS9U07fVN6"
  },
  "payload": {
    "iat": "2018-03-14 07:58:45",
    "exp": "2018-03-14 09:58:45"
  }
}

This is not a valid JWT token. For example there is no exp claim. Instead there is payload.exp.  Also the value of exp is not valid. It should be a unix timestamp not a string.  Correct token payload in your case would looks something like:
{
  "id": "fabrizio",
  "user": "$2y$10$kBmJeCXLtIJqE6ZRr9Sed.OE5LU8ilS3t8tAJ7f8w5PkS9U07fVN6",
  "iat":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>
}

For more info see https://github.com/tuupola/slim-jwt-auth/issues/102.

OK so I'll change the method like that?
public static function getToken($id, $user) {
		$secret = SECRET;
		// date: now
		$now = time();
		// date: now +2 hours
		$future = time()+(2*60*60);
		$token = array(
			'id' => $id, // User id
			'user' => $user // username
			'iat' => $now, // Start time of the token
			'exp' => $future, // Time the token expires (+2 hours)
		);
		// Encode Jwt Authentication Token
		return JWT::encode($token, $secret, "HS256");
	}

I'll be back soon with the result

It works like a charm, thank you!

tanks guys


Import the FindCUDA module from CMake

This addresses a problem where a generator expression for include
directories was passed to NVCC, where the generator expression itself
was prefixed by -I. As the NNPACK include directory generator
expression expands to multiple directories, the second and later ones
were not prefixed by -I, causing nvcc to return an error.
This was first fixed in CMake 3.7 (see Kitware/CMake@7ded655f).
To fix this, we can import and track FindCUDA from CMake upstream.
The most recent change to these files is Kitware/CMake@21806e6f.
This fixes #1397.

Still have to double check that this doesn't break for ex Windows.
PyTorch also uses upstream FindCUDA (see pytorch/cmake/FindCUDA) and that version was modified after the initial commit. Perhaps there are some modifications we need to port here. @Yangqing @soumith Do you recall any specifics about these mods?

This doesn't work with CMake 2.8.12. Fixing that first.

i cant recall any specific changes wrt Windows and pytorch's FindCUDA. I know a bunch of changes were made by folks over the years.

Thank you for your contribution! PyTorch and Caffe2 are now officially merged with the PyTorch 1.0 preview release. Please submit on https://github.com/pytorch/pytorch if this is still an issue over there.


Search-MispAttribute returns all attributes regardless of search body

Search-MispAttribute returns all attributes regardless of search body
Expected Behavior
When supplying a Search Request Parameter body to Search-MispAttribute, the search results should be filtered based on the criteria provided.
Current Behavior
Regardless of supplied criteria, all attributes are returned.
Possible Solution

Steps to Reproduce

Construct Search Criteria as a HashTable
Call Search-MispAttribute with -Search Parameter (Mandatory)
All attributes are returned

Context (Environment)
When attempting to search the attributes based on Creator Org, or Attribute Type, all attributes are always returned.

Version used: MISP.Tools version 1.0.1
Operating System and version: Windows Server 2016
PowerShell flavour and version: Core Version 7.3.3

The issue was caused by double-serialisation of the Search Parameter into the request to MISP.

In calling Invoke-MispRestMethod from Search-MispAttribute, the $Search value was converted to JSON.
In calling Invoke-RestMethod from Invoke-MispRestMethod, the $Body was converted to JSON a second time.

The double-serialisation resulted in the Search Criteria being accepted by MISP as being valid, but yet not being effective. This resulted in MISP returning all attributes for all time.
The solution was to not serialise the Search into a JSON String when calling Invoke-MispRestMethod.


Version bump 0.7.1

Summary
Version bump 0.7.1

After this one https://github.com/Qiskit-Extensions/quantum-serverless/pull/1060

I wonder if bumping setup-helm to v3 fixes the helm error...

actually, need to bump https://github.com/Qiskit-Extensions/quantum-serverless/blob/main/.github/actions/helm-lint/action.yaml#L20 to<EMAIL_ADDRESS>

helm issued should be fixed by #1070

we'll have to close / reopen this once the helm PR merges so this one picks up those changes

we will merge helm linter fix and update this branch from main

or merge #1071 :laughing:

:partying_face: :partying_face:


target instanceof Element fails if element is in another window

In function ResizeObserverSPI.prototype.observe, it checks to see if target is an instance of Element. If target is from another window, this fails as it would need to check against the window.Element object for that to be true. The recommended approach is to use duck typing to check if an object is an Element. Would it be possible to change this check to use duck-typing instead?

Actually, replacing the if (!(target instanceof Element)) check with the following is better...
if (target.ownerDocument) {
        const doc = target.ownerDocument
        const win = doc.defaultView || doc.parentWindow;
        if (!win || !(target instanceof win.Element)) {
            throw new TypeError('parameter 1 is not of type "Element".');
        }
    } else {
        throw new TypeError('parameter 1 is not of type "Element".');
    }

Same here, my target element is rendered in iframe.

Shouldn't it be enough to check for nodeType instead? Something like:
if (!target.nodeType || target.nodeType !== Node.ELEMENT_NODE) {
}

@deepsweet Probably a simpler solution :)

+1
Worked for me as well!

@deepsweet Would you like to create for this a PR?

still not passing on Maxthon v<IP_ADDRESS>00


updated custom-resource.py to change the way it returns the stack name.

this should mitigate truncation issues if the stack is launched with an
name with additional dashes resulting in iam policy issues.
the related CloudFormation stack will need to be updated as well to
include the stack name passed to the custom resourse:
"WafWebAclRuleControler":{
"Properties":{
"StackName":{"Ref":"AWS::StackName"}
}

this seems to be included in https://github.com/awslabs/aws-waf-security-automations/commit/3f9afeff52def452f2f6693be75a5fea725f4d10 can we close this PR?


Add hint on how to get query result as JSON

This will eventually make it easier for people to understand hot to transform the Arrow Table to JSON. As the Apache Arrow JS Docs as empty, this is not really easy to find.
It's also aligned to the main DuckDB docs at https://duckdb.org/docs/api/wasm/query#arrow-table-to-json

I'd not recommend doing this conversion unless absolutely necessary. It incurs a lot of overhead and arrow table as already behave like arrays of objects.
Thanks for pointing at the missing arrow docs. I'll look into it.

My use case (and I believe a lot of other people‘s as well) is to show the data in a React application as table. I‘m not aware of any components/libraries that can handle arrow table data directly.
I‘m happy to learn about other ways to do this.
Also, as written, this is covered in the DuckDB docs.

@domoritz Issue created
https://github.com/apache/arrow/issues/37856

And I filed https://github.com/apache/arrow/issues/37858 about the docs missing.


Inconsistent results using CASCI with localized orbitals

For a research project I want to use localized orbitals (using Pipek-Mezey from pyscf.lo) as a starting point for a CASCI calculation. For a hydrogen chain of 14 atoms, using CASCI(6,8) and basis cc-pvdz, I get the result CASCI E = -6.58068930903854  E(CI) = -5.87714998019395  S^2 = 0.0000000. If I localize the occupied orbitals starting from the scf.RHF() orbitals, and then do CASCI(6,8) I get CASCI E = -6.55914180871937  E(CI) = -6.43298787700139  S^2 = 0.0000000. If I also localize the virtual MOs I get CASCI E = -4.96307392615971  E(CI) = -6.12897546107277  S^2 = 2.0000000. Why does this happen?

CASCI results depend on precisely what orbitals are closed (or doubly
occupied) and what orbitals are in the active space. This is different than
CASSCF results which "in principle" only depend on how many orbitals are
closed and how many are in the active space.
Sandeep.
On Sun, Mar 29, 2020 at 7:51 AM Emiel Koridon<EMAIL_ADDRESS>wrote:

For a research project I want to use localized orbitals (using Pipek-Mezey
from pyscf.lo) as a starting point for a CASCI calculation. For a hydrogen
chain of 14 atoms, using CASCI(6,8) and basis cc-pvdz, I get the result
CASCI E = -6.58068930903854 E(CI) = -5.87714998019395 S^2 = 0.0000000. If I
localize the occupied orbitals starting from the scf.RHF() orbitals, and
then do CASCI(6,8) I get CASCI E = -6.55914180871937 E(CI) =
-6.43298787700139 S^2 = 0.0000000. If I also localize the virtual MOs I get
CASCI E = -4.96307392615971 E(CI) = -6.12897546107277 S^2 = 2.0000000. Why
does this happen?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/575, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABVW4DGFYQLNBCTBTRTOLTRJ5G5JANCNFSM4LV7JA7Q
.

Thanks for the quick reply! Aha, I see. How would you suggest defining a CAS such that I get consistent results? ( and such that the energy is at least lower than the HF energy) I try only to work with doubly occupied orbitals.

The simplest approach is to take hf orbitals and then perform a CASCI
calculation. This should give you lower energy than HF.
But really, this is one of the reasons why most people prefer to use
CASSCF rather than CASCI.
Sandeep.
On Sun, Mar 29, 2020 at 10:14 AM Emiel Koridon<EMAIL_ADDRESS>wrote:

Thanks for the quick reply! Aha, I see. How would you suggest defining a
CAS such that I get consistent results? ( and such that the energy is at
least lower than the HF energy) I try only to work with doubly occupied
orbitals.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/575#issuecomment-605660643, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABVW4HKMW55NL2QQLBQQU3RJ5XXJANCNFSM4LV7JA7Q
.

Ah yes, but I meant for localized orbitals.
I see what you mean, I will try CASSCF instead.
Emiel.

The use of localized orbitals with CASCI is not uncommon, typically when
the user wants to exploit some chemical intuition, for example by
correlating orbitals with significant 3d character. However one should
expect the results to depend on this selection of orbitals, as Sandeep
said.
On Sun, Mar 29, 2020 at 12:28 PM Emiel Koridon<EMAIL_ADDRESS>wrote:

Ah yes, but I meant for localized orbitals.
I see what you mean, I will try CASSCF instead.
Emiel.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/575#issuecomment-605662668, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGAJCY6ZEVBM5I47SYXGZ3RJ5ZLNANCNFSM4LV7JA7Q
.


Use extract-summary package

Work for this issue will begin begin on branch work-liquid-labs/dmd-readme-api/39.


Use Token macro instead of concrete token type names

https://docs.rs/syn/1.0.31/syn/token/index.html

The type names in this module can be difficult to keep straight, so we prefer to use the Token! macro instead. This is a type-macro that expands to the token type of the given token.

bors r+


vLLM stops all processing when CPU KV cache is used, has to be shut down and restarted.

Hi
The issue: with --swap-space X specified, as soon as CPU KV cache is used, vLLM stops all processing.  CPU and GPU usage go to 0%, and the request never returns. Any future requests are also never answered.  There is no error.
I am testing the latest vLLM code (commit  6fc2a38) in a Docker container.  I have experienced the issue since I first started using vLLM about 4 days ago, so it's not specific to the latest commits.
I am launching vLLM with the following args:
--model lmsys/vicuna-7b-v1.3 --host <IP_ADDRESS> --tokenizer hf-internal-testing/llama-tokenizer --swap-space 100

I am currently testing on a 1 x 4090 system, but I have experienced it on all GPU types I've tried, including A6000 and H100.
The following test code will quickly trigger the issue on a 1 x 4090 system:
import time
import requests

url = 'http://localhost:8000/v1/completions'
headers = {'Content-Type': 'application/json'}
data = {
    "model": "lmsys/vicuna-7b-v1.3",
    "prompt": " Write a story about a cat named George."*40,
    "max_tokens": 950,
    "temperature": 0.7,
    "n":125
}
s=time.time()
response = requests.post(url, headers=headers, json=data)
print(time.time()-s)

Here's a screenshot demonstrating the issue:

In the screenshot you can see that only 7.9% of CPU KV cache is used, but this is enough to cause all processing to stop.  The server will now never answer this request, and never answer any new requests either. It is effectively dead.
If I leave out --swap-space X then the server aborts RuntimeError: Aborted due to the lack of CPU swap space. Please increase the swap space to avoid this error., which is what I'm trying to avoid.  It would be nice to be able to use CPU RAM as an overflow buffer, in case I occasionally exceed VRAM.
Thanks in advance.

I had the same problem, did you solve it？

No, I'm not sure it's something we can solve ourselves.  Might need a code fix.

Might be related: https://github.com/vllm-project/vllm/issues/667

https://github.com/vllm-project/vllm/blob/66c54aa9c33555a6b41421d57d3ad6c1bf004ec9/vllm/engine/async_llm_engine.py#L67-L75
I comment this await asyncio.sleep(0) and it seems to temporarily solve the stuck.

Same issue.  Cache fills up and then vLLM stops working.

this issue makes vllm impossible for production use

this issue makes vllm impossible for production use

At present, we have found a workaround and set the swap space directly to 0. This way, we will not call the CPU swap space and will not report any errors. However, the CPU blocks will also become 0, which may slow down the speed a bit, but at least it will not hang and die.

@TheBloke are you still experiencing this issue?

this issue makes vllm impossible for production use

At present, we have found a workaround and set the swap space directly to 0. This way, we will not call the CPU swap space and will not report any errors. However, the CPU blocks will also become 0, which may slow down the speed a bit, but at least it will not hang and die.

Wondering how can I set the swap space directly to 0?

--swap-space 0 - docs

this issue makes vllm impossible for production use

At present, we have found a workaround and set the swap space directly to 0. This way, we will not call the CPU swap space and will not report any errors. However, the CPU blocks will also become 0, which may slow down the speed a bit, but at least it will not hang and die.

When using vllm 0.5.1, setting swap_space=0 will cause the process to terminate despite # CPU blocks being 0.
ERROR 07-11 00:49:14 async_llm_engine.py:53]     self._preempt_by_swap(seq_group, blocks_to_swap_out) ERROR 07-11 00:49:14 async_llm_engine.py:53]   File "/opt/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1145, in _preempt_by_swap ERROR 07-11 00:49:14 async_llm_engine.py:53]     self._swap_out(seq_group, blocks_to_swap_out) ERROR 07-11 00:49:14 async_llm_engine.py:53]   File "/opt/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1165, in _swap_out ERROR 07-11 00:49:14 async_llm_engine.py:53] RuntimeError: Aborted due to the lack of CPU swap space. Please increase the swap space to avoid this error.

Potentially this is a bug that's been fixed in BlockSpaceMangerV2?
You can enable it using --use-v2-block-manager

I see two workarounds being discussed for this thread:

Setting --swap-space to 0, but according to @haoxiongliu from version >= 0.5.1 setting swap_space=0 cause the process to terminate once vllm preempt a sequence group. @haoxiongliu can you confirm if you face the  _preempt_by_swap ERROR even in the latest versions?
@hmellor Were you able to verify if this bug exists after --use-v2-block-manager in the latest versions?

It still happens no matter whether --use-v2-block-manager is set in vllm 0.6.3.
INFO 10-28 11:16:34 metrics.py:349] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 7220.5 tokens/s, Running: 2 reqs, Swapped: 0 reqs, Pending: 98 reqs, GPU KV cache usage: 73.8%, CPU KV cache usage: 0.0%.
INFO 10-28 11:16:39 metrics.py:349] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 7154.5 tokens/s, Running: 2 reqs, Swapped: 0 reqs, Pending: 98 reqs, GPU KV cache usage: 86.1%, CPU KV cache usage: 0.0%.
WARNING 10-28 11:16:41 scheduler.py:1483] Sequence group chat-7e630abf1a8b4c8a88775b1e98a54cf2 is preempted by PreemptionMode.SWAP mode because there is not enough KV cache space. This can affect the end-to-end performance. Increase gpu_memory_utilization or tensor_parallel_size to provide more KV cache memory. total_num_cumulative_preemption=1
ERROR 10-28 11:16:41 engine.py:158] RuntimeError('Aborted due to the lack of CPU swap space. Please increase the swap space to avoid this error.')
ERROR 10-28 11:16:41 engine.py:158] Traceback (most recent call last):
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/engine/multiprocessing/engine.py", line 156, in start
ERROR 10-28 11:16:41 engine.py:158]     self.run_engine_loop()
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/engine/multiprocessing/engine.py", line 219, in run_engine_loop
ERROR 10-28 11:16:41 engine.py:158]     request_outputs = self.engine_step()
ERROR 10-28 11:16:41 engine.py:158]                       ^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/engine/multiprocessing/engine.py", line 237, in engine_step
ERROR 10-28 11:16:41 engine.py:158]     raise e
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/engine/multiprocessing/engine.py", line 228, in engine_step
ERROR 10-28 11:16:41 engine.py:158]     return self.engine.step()
ERROR 10-28 11:16:41 engine.py:158]            ^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/engine/llm_engine.py", line 1342, in step
ERROR 10-28 11:16:41 engine.py:158]     ) = self.scheduler[virtual_engine].schedule()
ERROR 10-28 11:16:41 engine.py:158]         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1219, in schedule
ERROR 10-28 11:16:41 engine.py:158]     scheduler_outputs: SchedulerOutputs = self._schedule()
ERROR 10-28 11:16:41 engine.py:158]                                           ^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1178, in _schedule
ERROR 10-28 11:16:41 engine.py:158]     return self._schedule_default()
ERROR 10-28 11:16:41 engine.py:158]            ^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1025, in _schedule_default
ERROR 10-28 11:16:41 engine.py:158]     running_scheduled = self._schedule_running(budget,
ERROR 10-28 11:16:41 engine.py:158]                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 604, in _schedule_running
ERROR 10-28 11:16:41 engine.py:158]     preempted_mode = self._preempt(victim_seq_group,
ERROR 10-28 11:16:41 engine.py:158]                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1495, in _preempt
ERROR 10-28 11:16:41 engine.py:158]     self._preempt_by_swap(seq_group, blocks_to_swap_out)
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1516, in _preempt_by_swap
ERROR 10-28 11:16:41 engine.py:158]     self._swap_out(seq_group, blocks_to_swap_out)
ERROR 10-28 11:16:41 engine.py:158]   File "/home/user/miniconda3/envs/working/lib/python3.11/site-packages/vllm/core/scheduler.py", line 1536, in _swap_out
ERROR 10-28 11:16:41 engine.py:158]     raise RuntimeError(
ERROR 10-28 11:16:41 engine.py:158] RuntimeError: Aborted due to the lack of CPU swap space. Please increase the swap space to avoid this error.

I don't know if it helps, but making prompt token length short solves my case.

The original maximum prompt characters: 4103 (mean=1458)
The shortened maximum prompt characters: 3483 (mean=838)

vllm version=0.5.3.post1


Updates project settings to add Test build config

Add Test build config so that our project may utilize Zip
as a submodule and build using a Test config when we run our
tests.  This allows us to define special compile time vars
for test purposes only.
Update project for Xcode 9.3 to get rid of some warnings
Check in IDEWorkspaceChecks.plist per Apple recommendation

Didn't mean to target original project.


Separate icon for empty folders similar to eza

Just noticed a very small difference between dirx and eza while comparing preview results for fzf after I just noticed you added --tree view 😄
EZA has a different icon for empty folders, whereas dirx has the same icon for all folders, empty or non-empty.
Not sure if you want to address this, it's quite a small issue but I thought I'd log it anyway.
Notice the difference for tags folder.
Eza tree view:

DirX tree view:

We can leave this open for now.  There's a good chance it will never happen.  I'm opposed to incurring that amount of performance loss for a subtle cosmetic detail, especially since (1) the effort to optimize it to infer emptiness with help from other flags and states would be fairly large and (2) it gets confusing/ambiguous when a wildcard is used (and eza currently just fails when given wildcards).
But that led me to notice that --tree is not handling wildcards properly in subdirectories (only with --tree).

v0.13 includes fixes for --tree with wildcards, --levels=1, among other things.

Wow, that was fast .. thanks !


xkeyboard_config: 2.22 -> 2.23.1

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 2.23.1 with grep in /nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1
directory tree listing: https://gist.github.com/6c094cb77d9d6e1110bc5d44144a55ba

Success on x86_64-darwin (full log)
Attempted: xkeyboard_config
Partial log (click to expand)
 /nix/store/s28xb9v7xf6axvf4a3av2mnczws2hsdg-coreutils-8.29/bin/mkdir -p '/nix/store/8s06sxcz2n8x6098a8d1mkiimv0vrqvb-xkeyboard-config-2.23.1/share/pkgconfig'
 /nix/store/s28xb9v7xf6axvf4a3av2mnczws2hsdg-coreutils-8.29/bin/install -c -m 644 xkeyboard-config.pc '/nix/store/8s06sxcz2n8x6098a8d1mkiimv0vrqvb-xkeyboard-config-2.23.1/share/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-xkeyboard-config-2.23.1.drv-0/xkeyboard-config-2.23.1'
/nix/store/8s06sxcz2n8x6098a8d1mkiimv0vrqvb-xkeyboard-config-2.23.1
make[1]: Leaving directory '/private/tmp/nix-build-xkeyboard-config-2.23.1.drv-0/xkeyboard-config-2.23.1'
propagating requisites
post-installation fixup
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8s06sxcz2n8x6098a8d1mkiimv0vrqvb-xkeyboard-config-2.23.1/lib
patching script interpreter paths in /nix/store/8s06sxcz2n8x6098a8d1mkiimv0vrqvb-xkeyboard-config-2.23.1

Success on x86_64-linux (full log)
Attempted: xkeyboard_config
Partial log (click to expand)
make[2]: Leaving directory '/build/xkeyboard-config-2.23.1'
make[1]: Leaving directory '/build/xkeyboard-config-2.23.1'
propagating requisites
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1/lib
patching script interpreter paths in /nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1
checking for references to /build in /nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1...
/nix/store/rzna96awj2li59rvgpk0ib40bj0jx8xx-xkeyboard-config-2.23.1

Success on x86_64-linux (full log)
Attempted: xkeyboard_config
Partial log (click to expand)
 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 xkeyboard-config.pc '/nix/store/z4615zjcm0acbpw2nrial9ma0cs0snx8-xkeyboard-config-2.23.1/share/pkgconfig'
make[2]: Leaving directory '/build/xkeyboard-config-2.23.1'
make[1]: Leaving directory '/build/xkeyboard-config-2.23.1'
propagating requisites
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z4615zjcm0acbpw2nrial9ma0cs0snx8-xkeyboard-config-2.23.1
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z4615zjcm0acbpw2nrial9ma0cs0snx8-xkeyboard-config-2.23.1/lib
patching script interpreter paths in /nix/store/z4615zjcm0acbpw2nrial9ma0cs0snx8-xkeyboard-config-2.23.1
checking for references to /build in /nix/store/z4615zjcm0acbpw2nrial9ma0cs0snx8-xkeyboard-config-2.23.1...

Success on aarch64-linux (full log)
Attempted: xkeyboard_config
Partial log (click to expand)
make[2]: Leaving directory '/build/xkeyboard-config-2.23.1'
make[1]: Leaving directory '/build/xkeyboard-config-2.23.1'
propagating requisites
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xcc71ch6bfxbnvxvhp4pdsqq33aaakjq-xkeyboard-config-2.23.1
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xcc71ch6bfxbnvxvhp4pdsqq33aaakjq-xkeyboard-config-2.23.1/lib
patching script interpreter paths in /nix/store/xcc71ch6bfxbnvxvhp4pdsqq33aaakjq-xkeyboard-config-2.23.1
checking for references to /build in /nix/store/xcc71ch6bfxbnvxvhp4pdsqq33aaakjq-xkeyboard-config-2.23.1...
/nix/store/xcc71ch6bfxbnvxvhp4pdsqq33aaakjq-xkeyboard-config-2.23.1

Failure on x86_64-darwin (full log)
Attempted: xkeyboard_config
Partial log (click to expand)
cannot build derivation '/nix/store/7mq5vk1ch577wx2vghdzjgrhccba0046-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/jq1y49miypgx1ag7srsa4svg7y7q94ca-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/qx40cw37jy1a0xmpl6vlxrxj11b4zm0m-python-2.7.14.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/idri609cxqipjp05vcqzbasdajcqj00b-libxml2-2.9.7.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/d5yjgsb6d1wm3v8dq6nadavj9nmgm9pz-xcb-proto-1.12.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/im7wz744yhnl3cr4al81f2vl1avz68fa-libxslt-1.1.32.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/nz4xs1ds279nmc2w4j1xi5g2ciiswbr4-libxcb-1.12.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/5sj1wi7ldanim0qwzvhmrlb7mgqakd31-libX11-1.6.5.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/0da6hvdvbg8h0f2xxcx9ysgmcgfk6jg5-xkeyboard-config-2.23.1.drv': 7 dependencies couldn't be built
error: build of '/nix/store/0da6hvdvbg8h0f2xxcx9ysgmcgfk6jg5-xkeyboard-config-2.23.1.drv' failed


guestbook bluesky name validation

my handle on bluesky is ligi.de - when trying it I get:
ascii letters + numbers only pls

Looks like it's because of the underscore in your Twitter handle. Posting a PR

done in #10! thanks 🙏 !


Cannot read property of 'length' of undefined when updating from 0.0.5 to 0.1.1

Hello,
Love the library.
Had a app running perfectly on 0.0.5. But when I updated to 0.1.1 I get
Cannot read property 'length' of undefined

(This error originated from the built-in JavaScript code that runs Dash apps. Click to see the full stack trace or open your browser's console.)
TypeError: Cannot read property 'length' of undefined

    at Function.value (webpack-internal:///./node_modules/react-cytoscapejs/dist/react-cytoscape.js:1:3406)

    at Cytoscape.render (webpack-internal:///./src/lib/components/Cytoscape.react.js:350:54)

    at ce (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:98:136)

    at qg (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:97:440)

    at hi (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:104:285)

    at Qg (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:144:293)

    at Rg (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:145:168)

    at Sc (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:158:109)

    at Z (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:156:492)

    at Kc (http://<IP_ADDRESS>:8050/hh-networks/_dash-component-suites/dash_renderer/react-dom@16.8.6.min.js?v=0.24.0&m=1559931493:155:69)

The app itself may be found here
Downgrading back to 0.0.5 allows the app to run perfectly fine.

I have simplified the example here and have found the root of the issue.
The app seems to have issue with leaving the elements parameter in cyto.Cytoscape as undefined. Before, on 0.0.5 this was fine, some process would then push data to cyto.Cytoscape, it would update and visualize the network.
Now on newer versions if I leave the elements parameter blank it will spit out the error above and refuse to update.

adding elements={} fixes the issue for me as well. This behaviour is different from dash-core-components where it is common to define something like dcc.Graph(id='errors', className='plotitem') in your layout before populating values with callbacks. The lack of any Python error or warning is frustrating as well. Even the browser console only hints that the problem is something is not defined.


Fix Python3.11 constraints

job: https://app.circleci.com/pipelines/github/astronomer/astronomer-providers/6270/workflows/9e4ee250-9b09-4512-a7a7-bb911e3b2cf9

I think with this we need to mention somewhere in our public docs that we don't support Hive provider with Python 3.11

yes, good point. shall we add a note in readme?

I think we could add this Hive provider limitation in our public doc limitations
https://astronomer-providers.readthedocs.io/en/stable/#limitations

This is README only, I have added in limitations section also and kept the note too because I feel that would be more visible

merging this one since currently main is broken but feel free to suggest any improvement


Fix for #87

It seems that's the only way I was able fo fix the issue on my side.

Coverage remained the same at 79.487% when pulling 248e0595453e0d06ca989a982486a76bf64c9f61 on meriouma:fix-87 into 66853838a7740f580274cfb91955c83a63f5210d on Wildhoney:master.


^ symbol not recognized with zsh shell.-

Hi,
I use git diff HEAD^ commands-like very often.
But since some "days" ago, I have to use git diff HEAD\^ now.
Don't know what happened exactly in these "days"; for sure, I installed bundle, ruby and jekyll.
That's the only funny thing that happened in these "days" (I checked my ~/.zsh_history).
I really don't know exactly where to report this, since I didn't find similar cases in the web (I already googled "jekyll, ruby, zsh, arrow up, etc").
This persists even if I delete my ~/.zshrc.
However in bash, git diff HEAD^ works normal.
Any pointers is very appreciated!
Thank you!!

^ (caret symbol) is a globbing character, used to indicate except (so ls ^.git would list files and directories except .git). This only works if setopt extended_glob is enabled.
I don't know what "happened" but if you want to not care about that you can alias git like so: alias git='noglob git'. That way there is no globbing enabled for the git command and you can do git diff HEAD^ however you like.

Thank you very much mcornella!


fix(hapi): set main reference for trace context

:tada: This PR is included in version 1.28.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cow: Watch fabtech

Cow requests the watch of the watch_keyword fabtech. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

fabtech has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Rejected by tripleee in Charcoal HQ. Reason: 'as requested by OP, due to FPs'


Support other browsers also

Currently when we use launchWebAuthFlow(), it gives redirect_uri_mismatch and could not figure out why. Otherwise extension loads in firefox and edge with minor changes in manifest file(for firefox only)

Found one related issue: https://www.reddit.com/r/chrome_extensions/comments/174xnui/redirect_uri_mismatch_error_for_google_auth_20/

https://extensionworkshop.com/documentation/develop/porting-a-google-chrome-extension/

https://gith ub.com/fireb ase/firebase-js-sdk/issues/4002#issuecomment-857796894


Fixes for building with community edition of VS (no MFC)

Include afxres.h
Add MFC detection and skip building Date and Shipedit utils when missing.

BTW I'm using the VS 2019 Community Edition and Orbiter builds fine for me without these changes. Do we really need to silently skip building the Date and ShipEdit utilities if the developer building Orbiter does not enable the MFC option in their VS 2019 installer? The VS 2019 installer can be re-run at any time, not just on first-time installation.

I hadn't noticed the option for MFC. It's not completed obvious in the install and in older versions you needed the professional or enterprise to get the libraries. That said, it would be nice to disable those as they are the only thing that requires MFC and they aren't necessary if you're just doing development on the core. The change isn't silent, there are warnings written to the cmake log similar to the warning that disabled XRSound when you don't have the needed library.

IF I understand correctly, than there is possibility to compile orbiter (almost) without MFC. If yes, than compiling without MFC helps to port Orbiter to linux. I like this idea while it not break existing code.


Screen content grabber not working

Hi !
Thanks for this awesome piece of software. The screen content grabbing stopped working and I have no clue why. I uninstalled all screen content grabbing apps on my computer, reinstalled .net frame 4.2.7 but nothing does it. My setup works fine, I can send random colors to my led strips.
Any tips on how I could solve my issue ?

I have extremely basic knowledge of c#
I ran the code in debug and I'm getting an "_outputDuplication is null" exception

Please make sure you're video card drivers are new. What windows version
are you using?
Did adrilight worked at some time on this device?

I'm using windows 10, it worked great during the last year and stopped working 2 weeks ago.
I'm going to try and update my video card drivers and keep you posted !

Reinstalling my video card drivers did the trick, thanks a lot !!

Great 😎


elementsSelectable Additional Options

Right now all elements are either selectable or not selectable. However, I would like to make my nodes selectable and my edges not selectable.
Can the ability be added to choose between edges vs nodes being selectable?
This could even go as far as passing in an array of all the element ids that are selectable for additional flexibility.

Hey @wdfinch
you can already do this by using the edge option selectable.

So that works with controlling which nodes are selectable. The issue is I don't want my edges to be selectable. Would it be possible to add the selectable options to edges as well as nodes?

If you set the general option elementsSelectable=false the edges should not be selectable

Got it ok that works. It might be good to clarify this in the docs as elementsSelectable=false seems like it would make nothing selectable rather than being able to be overridden.
I guess the only case this doesn't cover is if the user wanted to only be able to select edges. Not sure if that's a common enough use case to add that in.

If you only want to select edges you can set all nodes selectable=false.

There doesn't seem to be the inverse. For example, it doesn't seem possible to have elementsSelectable but some or all edges unselectable


CMake Error: Could NOT find PY_lit (missing: PY_LIT)

Ubuntu 18.04
Clang 8.0
LLVM 6.0 dev and tools
CMake 3.12
Running CMake as appropriate yields an immediate failure of
-- Could NOT find PY_lit (missing: PY_LIT)
I assume this to be some kind of python dependency but I've never seen that error before.
Python 2.7.15 and 3.6.8 are installed, so I don't know what the issue is.

Hello,
You could try installing the "lit" module using pip.
python -m pip install lit
python3 -m pip install lit
Cheers,
Juan
On Wed, 13 Nov 2019 at 15:29, Michael Burke<EMAIL_ADDRESS>wrote:

Ubuntu 18.04
Clang 8.0
LLVM 6.0 dev and tools
CMake 3.12
Running CMake as appropriate yields an immediate failure of
-- Could NOT find PY_lit (missing: PY_LIT)
I assume this to be some kind of python dependency but I've never seen
that error before.
Python 2.7.15 and 3.6.8 are installed, so I don't know what the issue is.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jmmartinez/easy-just-in-time/issues/49?email_source=notifications&email_token=AAHHTXYJPDJMGBIVJXWCT4DQTRBSNA5CNFSM4JM7TCSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZDEUIA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHHTXZCOUH2SW66NDXPYNTQTRBSNANCNFSM4JM7TCSA
.


AOT / IL2cpp issue

I'm using Scriban in Unity (2019.3) in IL2cpp mode, but it only works in the editor (which is running on Mono I assume). I know that in other libraries some AOT/il2cpp issues can be circumvented (e.g. in UniRx).
Is it possible to get Scriban runnin on AOT/IL2cpp, or if AOT/IL2cpp is a thing you plan to support in the future?
For completion's sake, this is the stacktrace when I try to render a simple template from the Start method on a script called Installer:
ArgumentNullException: Value cannot be null.
Parameter name: key
  at System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Runtime.DynamicCustomFunction..cctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Runtime.ScriptObjectExtensions.Import (Scriban.Runtime.IScriptObject script, System.Object obj, Scriban.Runtime.ScriptMemberImportFlags flags, Scriban.Runtime.MemberFilterDelegate filter, Scriban.Runtime.MemberRenamerDelegate renamer) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Runtime.ScriptObject..ctor (System.Int32 capacity) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.DateTimeFunctions..ctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.BuiltinFunctions+DefaultBuiltins..ctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.BuiltinFunctions..cctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.TemplateContext.GetDefaultBuiltinObject () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.TemplateContext..ctor (Scriban.Runtime.ScriptObject builtin) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Template.Render (System.Object model, Scriban.Runtime.MemberRenamerDelegate memberRenamer, Scriban.Runtime.MemberFilterDelegate memberFilter) [0x00000] in <00000000000000000000000000000000>:0
  at Installer.Start () [0x00000] in <00000000000000000000000000000000>:0
Rethrow as TypeInitializationException: The type initializer for 'Scriban.Runtime.DynamicCustomFunction' threw an exception.
  at Scriban.Runtime.ScriptObjectExtensions.Import (Scriban.Runtime.IScriptObject script, System.Object obj, Scriban.Runtime.ScriptMemberImportFlags flags, Scriban.Runtime.MemberFilterDelegate filter, Scriban.Runtime.MemberRenamerDelegate renamer) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Runtime.ScriptObject..ctor (System.Int32 capacity) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.DateTimeFunctions..ctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.BuiltinFunctions+DefaultBuiltins..ctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Functions.BuiltinFunctions..cctor () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.TemplateContext.GetDefaultBuiltinObject () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.TemplateContext..ctor (Scriban.Runtime.ScriptObject builtin) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Template.Render (System.Object model, Scriban.Runtime.MemberRenamerDelegate memberRenamer, Scriban.Runtime.MemberFilterDelegate memberFilter) [0x00000] in <00000000000000000000000000000000>:0
  at Installer.Start () [0x00000] in <00000000000000000000000000000000>:0
Rethrow as TypeInitializationException: The type initializer for 'Scriban.Functions.BuiltinFunctions' threw an exception.
  at Scriban.TemplateContext.GetDefaultBuiltinObject () [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.TemplateContext..ctor (Scriban.Runtime.ScriptObject builtin) [0x00000] in <00000000000000000000000000000000>:0
  at Scriban.Template.Render (System.Object model, Scriban.Runtime.MemberRenamerDelegate memberRenamer, Scriban.Runtime.MemberFilterDelegate memberFilter) [0x00000] in <00000000000000000000000000000000>:0
  at Installer.Start () [0x00000] in <00000000000000000000000000000000>:0

(Filename: currently not available on il2cpp Line: -1)

Scriban is heavily relying on System.Reflection which is really not a good fit for IL2CPP specially with generics created at runtime. So In your particular issue, I can't tell what is going wrong... but I would really not advice you to use Scriban in a standalone player and even less built with IL2CPP.

I thought the biggest (only?) issue with AOT/IL2cpp and reflection was Reflection.Emit not working. But I understand that supporting those targets is tricky and maybe not even worth it.
I guess I was thrown off by the fact that the main readme mentions Unity as a target and it seemed like a perfect fit to do localization in text-heavy games.
It works really well in the editor though, so maybe I’ll try rendering the templates offline 🤔


Add circle.yml file for CI github integration

This change isn't actually needed, I just had to change a setting to display CI results on the github page.


Why is database being queried for search?

I see that whenever I perform search, the database is still getting queried. For example, I have this -
User::search($keywords)->take(5)->get();
I see that when the search is performed, following query is executed
select * from userswhereid in ('1', '2', '3', '4', '5);
Is there any way to avoid querying database? Or this behavior is expected?

it is intended by default. Check out #116 for more info

Duplicated of #116. Closing it.


Vue template

As per all the requests in #524, here's a PR that adds a Vue.js template. This takes inspiration in various ways from @MarkPieszak's aspnetcore-Vue-starter, but also has some differences:

This one uses TypeScript for consistency with all the other templates. It also uses av-ts to coerce Vue's APIs into a more class-like shape.
This one does not use Vuex, just to keep things simple and approachable. Experienced Vue devs can of course add Vuex or anything similar if they want.

I'm putting this here as a PR in case anyone who is particularly familiar with Vue has comments on the approach or can suggest improvements.
Why there's no server-side prerendering
I did set it up with server-side prerendering. If you want that, look at commit 2067ea275812fee0a36e38c601be1c1fdebf704e. But then when trying to add a reference to node-fetch (so that API calls can occur on the server too), I realised there were some severe limitations, so I removed server-side prerendering support. See #754 for details of these issues - when people ask for server-side Vue rendering, we can point them to that issue. Hopefully, someone more involved in the Vue project might be able to suggest solutions or to fix the underlying limitations in Vue's approach to SSR.

Glad to of helped! I was originally going to go all TypeScript as well, but we stuck with ES6 just because it seems that the Vue community usually uses ES5 (sometimes 6), and I can't recommend anyone use ES5 (that's just crazy) :)
At least everyone will have both options now! I'll make sure to label mine ES6.
Do you want to link it somewhere in this Repo for others?
Also, I need to finally take the time to push my repos to dotnet template, if you have any great reference on how to do it that'd be amazing! Thanks @SteveSandersonMS 🥇

Merged.

At least everyone will have both options now! I'll make sure to label mine ES6.
Do you want to link it somewhere in this Repo for others?

Do you want to add it to the wiki? https://github.com/aspnet/JavaScriptServices/wiki

Also, I need to finally take the time to push my repos to dotnet template, if you have any great reference on how to do it that'd be amazing!

There are a few blog posts going around on this subject, e.g., http://dotnetthoughts.net/create-a-dot-net-new-project-template-in-dot-net-core/

I don't have write access to add anything in there :( @SteveSandersonMS

Sorry - I thought it was world-writable. Also I don't have permission to add permissions :( So I've added the link myself.

Yeah for some reason doesn't show you as a Member of ASPNET even though I know you are! Strange :laughing:
Going to link to this one for the TypeScript version.
Thanks again Steve, hope all is well over in the UK.

doesn't show you as a Member of ASPNET

The membership was set to 'private' for some reason. I have now changed it to 'public'.

There it is! :)


group.getUsers function always return 0

Hi,
I think code will explain everything.
Skype skype = new Skype("bot", "xxx");
skype.connect();
System.out.println("Bot is connected");
List groups = skype.getGroups();
// I have 2 groups
System.out.println(groups.size());
for (Group group : groups) {
List<Pair<User, Role>> usersWithRoles = group.getUsersWithRoles();
System.out.println(usersWithRoles.size());
List users = group.getUsers();
System.out.println(users.size());
}
System.out.println("Bot is disconnected");
output is:
Bot is connected
2
0
0
0
0
Bot is disconnected

Update: getUsers returns 0, only is group topic is not changed, once it is changed, getUsers returns correct value

Hello, thanks for the issue.
Please send me the debug logs for an example session of this happening so that I can investigate the issue. For example, run the following program:
Skype skype = new Skype("bot", "xxx");
Skype.setDebug(Paths.get("logfile.txt")); // notice the setDebug call to produce a log file
skype.connect();
System.out.println("Bot is connected");
List<Group> groups = skype.getGroups();
// I have 2 groups
System.out.println("count of groups: "+groups.size());
System.out.println("printing the groups user count...");
for (Group group : groups) {
List<Pair<User, Role>> usersWithRoles = group.getUsersWithRoles();
System.out.println(usersWithRoles.size());
List<User> users = group.getUsers();
System.out.println(users.size());
}
System.out.println("changing the groups topic...");
for (Group group : groups) {
group.changeTopic("dummy test topic");
}
System.out.println("printing the new groups user count...");
for (Group group : groups) {
List<Pair<User, Role>> usersWithRoles = group.getUsersWithRoles();
System.out.println(usersWithRoles.size());
List<User> users = group.getUsers();
System.out.println(users.size());
}
System.out.println("Bot is disconnected");

It will produce a logfile.txt file which you could then send me so that I can investigate the issue. Thanks.

@delthas
First run result:
Bot is connected
count of groups: 3
printing the groups user count...
4
4
0
0
0
0
changing the groups topic...
printing the new groups user count...
4
4
0
0
0
0
Bot is disconnected
Logs: https://pastebin.com/kFyq9rdx
Seconds run result:
Bot is connected
count of groups: 3
printing the groups user count...
4
4
3
3
3
3
changing the groups topic...
printing the new groups user count...
4
4
3
3
3
3
Bot is disconnected
Logs: https://pastebin.com/vE47HYYC


Revert "Feat/acr enhancements"

Reverts najeebvv/terraform-azurerm-caf#1

keeping the branch in line with parent


Mutate with custom updater when no useSWR seems to have wrong state

Bug report
Description / Observed Behavior
Simple case is:

a user action that will trigger a mutate on a key with a custom updater
after this action is done mount a component (or in a next js app push to router) that will use this key

-> the data that I see is not correct.
Expected Behavior
Expected behavior are:

if mutate is call and then a first useSWR is done on the same key, we should expect correct data -> request is correctly done, but data does not seems to be use / drop

Repo Steps / Code Example
if you run this example: click on the button you will see that request is done -> but only the mutate data is use.
https://codesandbox.io/s/clever-knuth-2z40o?file=/src/App.js:1128-1161
Additional Context
0.3.9

@AyWa if you display the button and DisplayData all the time, and change the last argument of mutate from true to false, you'll see:

fetched data by useSWR is rendered at first
click button
the mutated data will replace the default data

from:

(after click) to:

is this what you expected?

No this is not what I want to see. Sorry if I didnt explain well.
The behavior is:

I do not want to display the 2 component at the same time (because they could be different page) - > So the example given replicate that
I do not want to set the last argument to false (because I want to revalidate)

What I expect is:

user click button
mutate the key - > update date
mount a component that will use the key
so show fake
after api answers it should be updated

Does the flow is clear now? Let me know If my explanation is correct

I think the reason is that the when mutate is done, the revalidation is started, but the useSWR hook is not been called yet (DisplayData is not mounted). you might want to find a way to keep your hook there before displaying. like
<SWRConfig>
  <DisplayData visible={display} />
  {!display && <button /> // for mutation

const DisplayData = ({visible}) => {
   const {data} = useSWR(...)
   return visible && <div>....</div>
}

I think this is a bug which was introduced by #735
https://github.com/vercel/swr/blob/7858407a184dd273a4bc2158e270ea6a0ab5a4c7/src/use-swr.ts#L445-L463
we ignored a case like this
// case 4:
 //                                  req------------>res
 //   mutate------>end

Maybe we could reset the mutation time stamp to undefined if there is no updater in CACHE_REVALIDATORS ?
const updaters = CACHE_REVALIDATORS[key]
if (updaters) {
    const promises = []
    for (let i = 0; i < updaters.length; ++i) {
      promises.push(
        updaters[i](!!shouldRevalidate, data, error, undefined, i > 0)
      )
    }
    // return new updated value
    return Promise.all(promises).then(() => {
      if (error) throw error
      return cache.get(key)
    })
} else {
  MUTATION_TS[key] = undefined
  MUTATION_END_TS[key] = undefined
}

We can't ignore the revalidation result if it's this case (mutation ended before the revalidation starts):
// case 4:
//                     req------------>res
//   mutate------>end

It's still not clear to me why it's related to #735... I'll check which case causes that 🤔

Commented here: #833, it was indeed a bug!

Thanks a lot for the fast investigation and fix !! You Rock 🥳


PIO-61 Spark 2.3.x support

May one of PMCs please take a look?

Let us look at the result of Travis build first. :-)

Travis has all passed and I checked following things:

make-distribution.sh -Dspark.version=2.3.1 on my local PC
build, train and deploy text recommendation template with it and MLLib 2.3.1

There wasn't any problem. We can add Spark 2.3.1 support. 👍

Thank you @takezoe! Will merge soon.