black adds unnecessary lines around triple-quoted blocks

Using the rpy2 library to embed R code in a Python project, a common idiom is this:
import rpy2.robjects as robjects

robjects.r('''
loadRData <- function(fileName){
    #' Load an .rda file and return it as a r.DataFrame.
    load(fileName)
    get(ls()[ls() != "fileName"])
}
''')

Appying black -S to it, the code becomes:
robjects.r(
    '''
loadRData <- function(fileName){
    #' Load an .rda file and return it as a r.DataFrame.
    load(fileName)
    get(ls()[ls() != "fileName"])
}
'''
)

This might be an issue with other language embeddings as well.
My suggestion is that black does not change this idiom, i.e., the opening and closing parenthesis should be coalesced with the triple (single) quotes.
Operating system:
Python version: 3.6.5
Black version: 18.6b4
Does also happen on master: yes
EDIT: earlier versions did not show the whitespace correctly.

To make a code block use triple backticks
    ```python
    print('like this!')
    ```

I have run into this with the similar textwrap.dedent idiom:
textwrap.dedent("""\
    Hello, I am
    a multiline string used with
    a common idiom
""")

black will convert this to:
textwrap.dedent(
    """\
    Hello, I am
    a multiline string used with
    a common idiom
"""
)

This is particularly bad in the case of another containing function:
sqlalchemy.text(textwrap.dedent("""\
    SELECT
        *
    FROM
        sometable
"""))

becomes:
sqlalchemy.text(
    textwrap.dedent(
        """\
    SELECT
        *
    FROM
        sometable
"""
    )
)

I'll close this as a duplicate and we'll handle this use case as part of #256, too.


decouple NextLinkOperationImplementation and JsonElementExtensions

Because of the requirement of https://github.com/Azure/autorest.csharp/issues/4246 , we need to remove the shared code JsonElementExtensions.cs and Utf8JsonWriterExtensions.cs, but some methods are used in other classes.
Since LRO is an azure specific concept, and we would like to take steps when doing this, this PR removes the invocation of GetRequiredString on JsonProperty and let NextLinkOperationImplementation to have its own implemenation of it.

API change check
API changes are not detected in this pull request.


"-bash: hmwtc: command not found"

Hey!
When I try to run the command on my app in iTerm 2, it returns this:
-bash: hmwtc: command not found

Same here.

So, @williamsthing I found a solution.
You have to install it globally, then it will work.


field access generalized identifiers highlight as seperate tokens

Summary
This is minor: field access without quoted-identifiers highlight as separate tokens.
ex: The textmate scope of in in [Records in Range] is a language keyword

I wasn't sure whether this is at the extension level or microsoft/powerquery-parser I put it here because even though textmate's scope is a keyword -- the parser seems to format correctly. I tried using a strange generalized-identifier to see if I could break the formatting, but it did not.

Power BI's editor has the same behaviour

Test Query
let
    Source = ...,
    #"Total Records1" = Table.AddColumn(
        Source, "Count 1",
        each Table.RowCount( [#"Records in Range"] ),
        type number
    ),
    #"Total Records2" = Table.AddColumn(
        Source, "Count 2",
        each Table.RowCount( [Records in Range] ),
        type number
    )

in
    #"Total Records2"

I think this is the grammar involved (Expand)

.

Yeah, this is an issue with our grammar file. In theory we could resolve it by enabling semantic highlighting via the powerquery-parser, but it should be pretty straightforward to resolve.
FWIW, we do have a separate github project for the language grammar (that has fallen out of date), but it does have some built in tests. I've been meaning to get it running again, but if anyone else wants to pick that up, please feel free :)
powerquery-language
/@JordanBoltonMN as FYI

@mattmasson Which project is that?

@mattmasson Which project is that?

https://github.com/microsoft/powerquery-language


Update kyaml v0.12.0

Closing this as there are seems to be changes made to kyaml. We can address and release them in next release.


Copying https://github.com/test-kitchen/test-kitchen/pull/919 to this repo

\cc @chris-rock @arlimus
I'm guessing we didn't see this here because something else in train was including timeout, but its still the right thing to do

Thanks @tyler-ball for catching this!


cant login

cant login my account and cant sign up a new account.

login fixed by pre-release, signup is disabled on yande.re website.


[BACKLOG-40931] Unit test fixes for JDK17

:white_check_mark: Build finished in 11m 42s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
plugins/mondrianinput/impl

:ok_hand: All tests passed!
Tests run: 3, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Missing bindings on Windows 10 with 3.2.0

Hello, receive this error on installation
Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/win32-x64-45_binding.node": HTTP error 404 Not Found

Setup:
iojs 3.0.0
node-sass 3.2.0
windows 10

Duplicate of #1053


After I define a route in the api.php of the plugin, I can't find the route in route:list.

After I define a route in the api.php of the plugin, I can't find the route in route:list.
Modules/AuthorisationCentre/routes/api.php
Route::get('/user/111', function (Request $request) {
    return $request->user();
})->middleware('auth:sanctum');

Then I run the following command
php artisan route:list

I can't find this route

it's okay you just need to make sure that your plugin is active


fix Issue 14430 - [REG2.060] Null parameter is detected as non-null

This is a critical bug fix.
https://issues.dlang.org/show_bug.cgi?id=14430

What does 64 mean?

What does 64 mean?
https://github.com/D-Programming-Language/dmd/blob/master/src/backend/cod3.c#L2510

Auto-merge toggled on


Log libseccomp package version

Depends on: #4836
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

CC: @nalind

/approve

lgtm

/hold

Added commit that uses newly built iamges

/hold cancel

/lgtm

/hold

Waiting for new packages https://bugzilla.redhat.com/show_bug.cgi?id=1765314

/hold

Oops, need to wait for new libseccomp packages.

(still waiting on packages)

@cevich Can we close this one?

Can we close this one?

Naw, it's minor but handy to have the package version logged in every run.  I see we've got new libseccomp packages with the bug-fix.  Trying again with those...

sigh...waiting on me to fix the base-images...

@baude @mheon PTAL, this one is good-to-go.

LGTM

/lgtm

/hold cancel


Doesn't work in ie 10-11

Hello, thank you for work.
I found that this plugin doesn't work in Internet explorer.
If you have any ideas why it not working, please tell me.

On line 106 and 114 if we change 'toString' to 'Object.prototype.toString' all will work great.

@dzNavitski thanks for the solution! I've now updated the plugin


test for #158 (not to merge)

@mcollina
Please see my test for #158
It doesn't fail without the patch from #158 ..
Am I doing it right?

Subscriptions are cleared on connect https://github.com/cordovapolymer/aedes/blob/5a4210ad477bd2477be2748a19485a4e5f7a173b/lib/handlers/connect.js#L96-L99. You should put some assertions on the persistence itself if you want to check that they should not be stored.

@mcollina
I've added the assertion on persistence subscriptions, can you review?

Can you remove the yarn-lock file?


remove Attr and AttrLoader

These can be replaced with Attributes

Done.

Attr still needs to be removed.  The biggest issue is that UIWidget uses Attr.

fixed in https://github.com/MarkOates/allegro_flare/pull/119


🌐 Add German translation for docs/de/docs/tutorial/metadata.md

← tutorial/background-tasks.md (#10566)
→ tutorial/static-files.md (#10584)
German translation progress

📝 Docs preview for commit 11b16c27a5683e4a185460582f6932f48c5d525e at: https://7e56ee35.fastapitiangolo.pages.dev

📝 Docs preview for commit 8554e1b9ce7b4670e50cff1863aee5ea3543dcf3 at: https://9b6b1861.fastapitiangolo.pages.dev

Awesome @nilslindemann! :rocket:
As you are the champion of German translations and you have done so many, and with so much attention to detail, I'm gonna go ahead and merge this. :tada:
If others see things that could be improved later, we can check that in new PRs. :nerd_face:


inspect API is not working on workbench.colorCustomizations 's sub properties

RE: VS Code API for inspect from this page https://code.visualstudio.com/api/references/vscode-api
How can the inspect API operate on a 4 part setting like workbench.colorCustomizations.panel.background ?

When global user settings.json has the following 👇
    "workbench.colorCustomizations": {
        "panel.background": "#212121"
    }

TypeScript code
  const section = 'workbench.colorCustomizations';
  const setting = 'panel.background';
  const config1 = vscode.workspace.getConfiguration(section).inspect(setting);
  const config2 = vscode.workspace.getConfiguration().inspect(`${section}.${setting}`);

Neither config1 nor config2 above inspects the panel.background from the section listed. This inspect API works great when it looks for a single level, but perhaps since this is 4 parts (three dots) it has a problem? or maybe there is another syntax for this?

inspect api takes only the registered configuration keys. Looks like you are trying to inspect the values which is not valid.

Is there a way to know which of these values came from user settings or global settings?
Scenario:
I get a set of these and I need to remove some and add some back, then write them to workspace settings. The problem I I don;t want to touch the ones in global settings. This is for the Peacock extension.
Otherwise I can write a set to workspace , but this overwrites whatever they had and they may lose some things they wanted. Or I can get the merged set, and then write to workspace - but this takes settings from global and duplicates them to the workspace, which isnt god either.

You can do it by inspecting the setting and compare the values.

Thanks, but I think I need to provide more context.
** global user settings.json**
 "workbench.colorCustomizations": {
     // the user manually set this 👇
     "panel.background": "#212121"
    }

** workspace settings.json**
 "workbench.colorCustomizations": {
     // the user manually set this 👇
    "panel.foreground": "#ffffff",

     // peacock set these 👇
    "activityBar.background": "#174a8e",
    "activityBar.foreground": "#e7e7e7",
    "activityBar.inactiveForeground": "#e7e7e799",
    "activityBarBadge.background": "#e03f84",
    "activityBarBadge.foreground": "#e7e7e7",
    "statusBar.background": "#103362",
    "statusBarItem.hoverBackground": "#174a8e",
    "statusBar.foreground": "#e7e7e7",
    }

A user of Peacock decides they want a new color. I now need to write all of the "activityBar" and "statusBar" colors to the workspace. if I grab all colors and go through them one by one, I get the merged set of global and workspace. Then I can go thru them and overwrite the peacock colors. But when I go to write them, I would be writing the global one to the workspace. I think you are saying I have no way of knowing that      "panel.background": "#212121" came from global.
If I just overwrite the workspace colors, the user will lose their color "panel.foreground": "#ffffff",.
Do you see the dilemma?

You can call inspect on workbench.colorCustomizations and you get
global and workspace values. From that you can infer panel.background value is coming from global settings.

Thanks for the tip. Here is what I did, in case anyone else is curious
export interface ISettingsIndexer {
  [key: string]: any;
}

export function getColorCustomizationConfigFromWorkspace() {
  const inspect = workspace.getConfiguration().inspect('workbench.colorCustomizations);

  if (!inspect) {
    return {};
  }

  if (typeof inspect.workspaceValue !== 'object') {
    return {};
  }

  const colorCustomizations: ISettingsIndexer = inspect.workspaceValue as ISettingsIndexer;

  return colorCustomizations;
}


Making ts-standard easier to use

I was going through the issues of standard in the original repo, and I saw that issue : https://github.com/standard/standard/issues/1356
What problem do you want to solve?
I feel like ts-standard should follow the principles/rules as close as possible of standard.
What do you think is the correct solution to this problem?

Build in snazzy so users can do ts-standard --report=snazzy and get pretty output maybe we can add package.json options as well.
Also, in the standard issue, they're talking about standard-json and standard-tap.

Build-in prettier would be awesome, maybe if we do ts-standard --format, it automatically runs prettier + ts-standard --fix.
prettier also runs in .md, .json, .yaml, .css files etc. not only in .js or .ts
I see that this project is using this script in package.json :
"lint": "prettier --write '**/*.{ts*,js*,yml}' && bin/cmd.js --fix && tsc --noEmit"
and this prettier configuration :
"prettier": {
  "singleQuote": true,
  "semi": false
}

What if we would not need to do all these configurations ourselves and ts-standard will do it for us ?

Are you willing to submit a pull request to implement this change?
Yes of couse!

Any thoughts ? @toddbluhm

@Divlo Thanks for the feedback. Initially, my goal for this package was to mimick standard as close as possible and keep feature parity with standard. However, your right, it looks like @feross is trying to improve the ease of use of standard
I'd say go for it! It might be cool to have this package be a test-bed for new standard features.
Make sure all new features are behind some sort of flag and opt-in only. All existing standard flags should continue to perform exactly like the regular standard that way we maintain full parity/backward compatibility with it.

Alright, I will try to open a pull request to add the --format flag to the CLI. :+1:
I just cloned the repo but when I run npm run lint, I've got errors thrown by tsc --noEmit command, so I will first open a PR to update dependencies and try to fix this issue, maybe once this is fixed, we could release the v10 release (also there is no standard organization on npm).

also there is no standard organization on npm

Our organization on npm is called standardjs because standard is being used by someone with private packages.
If you're keen to work on these issues, I'd love to solve it in standard-engine (where that makes sense) so that all downstream packages like standard, semistandard, ts-standard, etc. benefit and maybe we can close https://github.com/standard/standard/issues/1356 at the same time!


[NET-4][agent] Add support for DNS over TCP without fragmentation

What does this PR do?
Adds support for snooping DNS payloads sent over TCP when there is no fragmentation.
JIRA ticket: https://datadoghq.atlassian.net/browse/NET-4
Testing
In addition to unit test, this is how it was tested on a VM -
Step 1: Ran the following script (dns_over_tcp.go) to create DNS queries over TCP
package main

import (
	"fmt"
	"net"
	mdns "github.com/miekg/dns"
)

func main() {
	// Create a DNS query message
	msg := new(mdns.Msg)
	msg.SetQuestion(mdns.Fqdn("golang.org"), mdns.TypeA)
	msg.RecursionDesired = true

	config, _ := mdns.ClientConfigFromFile("/etc/resolv.conf")
	dnsHost := net.JoinHostPort(config.Servers[0], config.Port)

	dnsClient := mdns.Client{Net: "tcp"}
	rep, _, _ := dnsClient.Exchange(msg, dnsHost)

	var destIP = ""
	for _, r := range rep.Answer {
		if aRecord, ok := r.(*mdns.A); ok {
			if mdns.NumField(aRecord) >= 1 {
				destIP = mdns.Field(aRecord, 1)
				fmt.Println(destIP)
			}
		}
	}
}

Step 2:  Used the returned IP  in a connection:
./dns_over_tcp  | xargs curl

Step 3: Checked that the domain to IP mapping has been created:
vagrant@vagrant:~$ curl -XGET --unix-socket /opt/datadog-agent/run/sysprobe.sock http://unix/connections | json_pp  | grep -A4 dns
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2258    0  2258    0     0   435k      0 --:--:-- --:--:-- --:--:--  551k
   "dns" : {
      "<IP_ADDRESS>" : {
         "names" : [
            "golang.org"
         ]

@DataDog/networks

@DataDog/agent-platform, please review.


gopass show exits with status 0 when no entry is found

Current behaviour:
$ gopass show this_does_not_exist
Entry 'this_does_not_exist' not found. Starting search...
$ echo $?
0

This behaviour seems a bit strange, especially if you trying use gopass in a script in which case you end up with an error message in the secret. It would be nice if gopass exited with a non-zero exit status in this instance, or if this is not possible a flag that would enable this behaviour.
OS: OS X 10.11.6
gopass: 1.2.0_2
go: 1.8.3

Thank you for reporting this. You're absolutely right. We'll fix that.


TextInput keyboardType='numeric' doesnt work on android if editable={false}

Is this a bug report?
yes
Have you read the Bugs section of the How to Contribute guide?
Yes
Environment

react-native -v: 0.42.3
node -v: 8.1.3
npm -v: 4.6.1
yarn --version: 0.27.5

Target Platform: Android

Development Operating System: MacOS Sierra 10.12.5

Steps to Reproduce
I was able to reproduce this by:

starting a new AwesomeProject reading through the guide here: https://facebook.github.io/react-native/docs/getting-started.html
then created a TextInput Component in app.js with the following props: autoFocus={true} keyboardType='numeric' editable={false}.

Expected Behavior
the keyboard should be numeric version, where numbers 0-9 should be the majority of the keyboard displayed, along with a few symbols. OR it should just not show the keyboard because it's not supposed to be editable. I say 'or' because I was able to show a numeric keypad on the iOS side with the same props.
Actual Behavior
it shows the default full keyboard with letters.
Reproducible Demo
https://snack.expo.io/BkkyY61v-
Other Information:
You might notice the RN version i'm using it a bit old, but I was also able to reproduce this with the latest RN version, which is React 16.0.0-alpha.12 and RN 0.46.1 currently.
if I remove editable={false}, it starts to work.

But... What the point to see a keyboard if you cannot type?

@shergin the intention was to not let the user tap on the text input, but only use the numeric keyboard to enter text in it, constraining the user to only numbers.
i do want to point out that the functionality is different with the same props across ios and android, so even if my use case isnt a big deal, i think there should be some consistency across platforms.

@TakaGoto I am sorry, I don't understand. If the TextInput is disabled, it means that user cannot enter anything into the field. So, how can he if he cannot?

@shergin , same issue here in Android w/editing=true (implicit):
    <Input
        ref="codeInput"
        autoFocus
        maxLength={PHONE_CODE_LEN}
        onChangeText={this.setCode}
        returnKeyType="next"
        onSubmitEditing={this.goProfile}
        style={styles.input}
        keyboardType="numeric"
        value={code}
    />

The default keyboard is opened.
RN 0.53.3
Tested on devices with Android 6.0 and 7.1
Meybe an issue with autoFocus?


Adding a TextBox to a page in a NavigationView crashes a WinAppSdk 1.2 app

Describe the bug
Adding a TextBox control to a page that is programmatically added via NavigationView crashes the app. This used to work in WinAppSdk 1.1.5 but now fails in WinAppSdk 1.2.221109.1.
Steps to reproduce the bug
Prerequisites:

Windows App SDK 1.2 is installed

Download the attached zip file and extract its content
Open "WinAppSdk_Issue_1.2.sln" in Visual Studio 17.4
Build and run the solution
Switch to the "Page2" tab of the NavigationView. The app crashes with an access violation exception in the LoadComponent function of file Microsoft.UI.Xaml.h

Expected behavior
TextBox elements can be used in XAML without crashing the app.
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Windows 10 (21H2): Build 19044
Additional context
At the time of this bug submission, the "Nuget package version" drop down does not list the WinAppSdk 1.2 package. The NuGet packaged used is as follows:
Microsoft.WindowsAppSDK.1.2.221109.1

Thanks for opening this. Until it's serviced, there's a workaround in this comment.

:tada:Microsoft.WindowsAppSDK.1.2.221116.1 has been released which fixes this issue.
Handy links:

Release Notes
Official Nuget Release


Help Request.

I have a link on a grid cell. On clicking on it, I need to pass the value of one of the fields in the same row, so that a modal can be viewed accordingly. Each row has a different modal depending on the value of the field. I can call the modal but passing the value as parameter is not achieved. Can you suggest anything? Thanks.

If the only problem is to get the value you can use the rowclick function:
$("#jsGrid").jsGrid({
       ...

        rowClick: function(e) {
        	clickedRow = e.item;
                var value = clickedRow.value;
        },

        fields: [...]
    });

@UjjayiniD, itemTemplate(value, item) accepts item with all fields, so you can access any field and pass to the link click handler.
Is it what you are trying to achieve?


Column rename through CHANGE COLUMN changes column order

Version
1.14.0
What happened?
After I noticed #1605 was added to 1.14 I ran the new version against our code, as I know there's a few CHANGE COLUMN statements in there. I noticed the ones that don't change the name are also impacted by this change, as they're pulled down to the last position in the column list it seems.
I only tested this with our own code against a MariaDB. In my case, column order doesn't change when CHANGE COLUMN is used to change type, change name, or both.
Relevant log output
No response
Database schema
No response
SQL queries
No response
Configuration
No response
Playground URL
No response
What operating system are you using?
Linux
What database engines are you using?
MySQL
What type of code are you generating?
Go

@Luit What impact does the ordering of the columns have on your queries?

I noticed this caused a diff on my structs even though nothing functionally changed. I'm not entirely sure whether sqlc actually maintains column order similar to how MariaDB(/MySQL) does this, but so far column order and struct order was the same for our cases. If ADD COLUMN x AFTER y doesn't have an impact on struct order either, then I'm not sure this one is important either.


Fullscreen button always says "Exit Fullscreen" on hover

The fullscreen button always shows the icon for exiting fullscreen, even if I am not in fullscreen. The tooltip always says "Exit fullscreen" as well

This seems to happen for every location I select.
Browser:

Vivaldi, Windows 10

I have also had this happen on Safari on iOS
Locations:
This happens regardless of location

a4f1035e74eed9e6012b11c0195bf49efb31c732


Roaring import

Overview
This is my attempt at pulling the "roaring import" code out of PR #1496.
I wasn't able to remove this code from #1496 without introducing conflicts in the commit replay, but I thought at least we could review this code independently.
@tgruben You should probably confirm that this PR contains all the necessary code.

I made a bunch of changes/fixes to this today, and added some tests. It still needs external docs (I added some doc strings). can you take a look @tgruben @travisturner

thanks @jaffee, I'll take a look

@jaffee @tgruben since I created this PR I can only leave comments, I can't approve or decline it. Anyway, I've left several comments.

I found some lingering issues in the client and API method around how queries were getting forwarded. We needed the remote bool to signal when a query should be processed only on the receiving node, or forwarded around.
I also fixed a data race where the roaring data was getting modified by the local node concurrently to being forwarded to remote nodes.
I think this is about ready now, but I'm going to run the race detector and do one last pass.

I think this is actually ready now. Would like one more approval since I made so many changes.


yo

Can I jump on call with you to for a code walkthrough?

Sure. Tomorrow afternoon? What timezone are you in?

I'm EST what email do you use for google hangouts?

<EMAIL_ADDRESS>

I am available now if you want to chat

@gdi2290 Yo you guys talk already, would love to jump in if possible ?
Been looking at this as well, looks pretty damn amazing @clbond

Hey @MarkPieszak. If you can make your code available to me, I would be happy to get it working with angular-ssr. That might be more efficient than going back and forth on these issues

kool I invited and created a group


Tried many times, documentation doesn't mention requirements for Networking step setting up CosmosDb

Must add Azure and local IP to networking

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5d8489d0-7ec1-59bb-053c-014af93c4095
Version Independent ID: ec72532b-c8ac-92c9-5bed-0e497660e4ea
Content: Configure customer-managed keys - Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-setup-customer-managed-keys.md
Service: cosmos-db
GitHub Login: @seesharprun
Microsoft Alias: sidandrews

@testpushhydra
Thanks for your feedback! We will investigate and update as appropriate.

@seesharprun
could you please review this and update as appropriate.

@testpushhydra
I've delegated this to @seesharprun, a content author, to review and share their valuable insights.

@testpushhydra, we're adding a note to the article to clarify that you must enable access to Azure services to use this feature. As this is the default, we didn't add this note at first. Thanks for your feedback!


Clarify: anti-affinity behavior between etcd pods and backup sidecar

ref: https://github.com/coreos/etcd-operator/pull/1128
Previously we haven't defined nor thought good enough about this behavior. Let's define it:

sidecar with anti-affinity
sidecar without anti-affinity

etcd pod with anti-affinity
cannot colocate
can colocate

etcd pod without anti-affinity
can colocate
can colocate

Then let's better put some schedule to implement it.

What's the status on this? I need to colocate the backup sidecar with the etcd nodes.

We don't have backup sidecar anymore.
Closing this.


Silent build failure

https://travis-ci.org/jbush001/NyuziProcessor/builds/360718083
Related to #161. In this case, one build of the resource file fails, but the build is successful:
[ 98%] Creating filesystem image
error reading from source file: Success
first file offset = 512
Adding resource.bin 00000200 011e2874
software/apps/sceneview/CMakeFiles/sceneview_fsimage.dir/build.make:61: recipe for target 'software/apps/sceneview/fsimage.bin' failed
make[2]: *** [software/apps/sceneview/fsimage.bin] Error 1
make[2]: *** Deleting file 'software/apps/sceneview/fsimage.bin'
CMakeFiles/Makefile2:1027: recipe for target 'software/apps/sceneview/CMakeFiles/sceneview_fsimage.dir/all' failed
make[1]: *** [software/apps/sceneview/CMakeFiles/sceneview_fsimage.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Other odd stuff going on:

printed an error from mkfs, but perror prints 'success'.
Then it seems to continue writing the file: first file offset = 512

Perhaps two instances are running concurrently.

duplicate of #161


ConnectionRefusedError Windows 7

Hi - I am trying to work with tika-python in windows 7, Anaconda, python 3.5 - And am experiencing connection errors. Is there something I missed in the example?
The code:
import tika
from tika import config
import tika
# tika.TikaClientOnly = True
tika.parser.from_file('path\\to\\8B10B_Coding.pdf')

Generates this error.
2016-11-26 18:17:04,662 [MainThread  ] [INFO ]  Starting new HTTP connection (1): localhost
---------------------------------------------------------------------------
ConnectionRefusedError                    Traceback (most recent call last)
C:\Anaconda3\lib\site-packages\requests\packages\urllib3\connection.py in _new_conn(self)
    141             conn = connection.create_connection(
--> 142                 (self.host, self.port), self.timeout, **extra_kw)
    143

C:\Anaconda3\lib\site-packages\requests\packages\urllib3\util\connection.py in create_connection(address, timeout, source_address, socket_options)
     97     if err is not None:
---> 98         raise err
     99

C:\Anaconda3\lib\site-packages\requests\packages\urllib3\util\connection.py in create_connection(address, timeout, source_address, socket_options)
     87                 sock.bind(source_address)
---> 88             sock.connect(sa)
     89             return sock

ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it

looks like a firewall issue to me. Are you not allowed to create a port (the default localhost one, bound to * on windows so it listens on all interfaces) is 9998. Can you check?

Hi @chrismattmann  - I am not sure what happened, but somehow I am no longer getting the error message.  The only difference I can think of is some updates I made to various packages.   Lovely module - A real time saver. Thanks

Thanks @gryBox please re-open if you see this in the future. Cheers!


Make a new card design

The cards for participants,mentors & projects are quite dull to be honest. Make them stylish
https://codepen.io/andytran/pen/BNjymy
https://codepen.io/szpakoli/pen/xbJjdR
https://codepen.io/choogoor/pen/YWBxAg
Here are three designs for cards. While claming the issue let us know which design you will be working on.

@ananya-agrawal is this issue still open??.. Let me know if i can work on this issue

@Rattlecode17sh @ujjwal-batra is having an open pr for this so let him respond once to the status of the issue

Okay cool.. Let him first complete his PR and if not done than @ananya-agrawal assign this to me

@ananya-agrawal mam should i change the card design for mentor cards in this??


No Control of Mars Pro Printer at Firmware 4.4.3

I'm a new user (ie Mariner3D has never worked completely for me) I get the #180 symptom, however I do not get any control of the printer which seems different from the experiences of others who get this symptom.
Looking at the serial data being sent from the Pi Zero W to the Mars Pro, I see the following
M23 /first file.ctbM4006M4006M4006M4006M23 /second file.ctbM4006M4006M4006M4006M4006M4006M4006M4006
that is, a constant stream of commands without CR LF.
In order to rule out my serial monitor, I performed the following on the Pi Zero W
cat 1.txt > /dev/ttyS0
where 1.txt contains three words separated by CR LF.
I see the following in the serial monitor

My conclusion from this is that Mariner3D / Python is not sending the CR LF even though I can see from the Mariner code that it should be sent.
Assuming my observations are reliable, then I think that the commands from Mariner cannot be digested by the printer.  I cannot escape the fact that nobody else sees this problem so it is likely to be a problem of my own making rather than Mariner.
A short description of what the bug is that the printer cannot be controlled via the UART.
Expected Behavior
I expect that the printer will be sent commands terminated with an "\r\n".  I can see in printer.py that this is the intent of what Mariner3D is doing.  I don't see why this seems not to be happening.
There is nothing of interest in the Mariner3D log.
Details:

Mariner Version:  0.2.0-1
Printer Model:  Elegoo Mars Pro V4.4.3_c1_LCDF System EL3D-3.0.1
Raspberry Pi Model: RPi Zero W with raspios_lite_armhf-2021-05-28/2021-05-07-raspios-buster-armhf-lite

Other
cmdline.txt is
root=PARTUUID=82934f69-02 rootfstype=ext4 elevator=deadline fsck.repair=yes rootwait modules-load=dwc2
[all] clause of config.txt contains
dtoverlay=dwc2
enable_uart=1

Python is 3.7.

I installed Mariner on a Pi3B and can also reproduce the same problem there.  Additionally, I run the following script, designed to mimic what Mariner's printer.py does, and with both this script and mariner communicating on the serial port, I see the \r\n in the serial monitor for my python script, but not from mariner.
'''
UART communication on Raspberry Pi to mimic Mariner comms
'''
import serial
from time import sleep

ser = serial.Serial ("/dev/serial0", 115200)                      #Open port with baud rate
while True:
    sleep(1)
    ser.write((f"M23 /W1bble.ctb").encode() + b"\r\n")                #transmit data serially 115200

I am completely at a loss to understand what I am seeing unless the mariner I am running is not the same as the code on github.
Hopefully this additional information will help someone more knowledgeable than I to point me in the right direction.
Many thanks

Answering my own question,  I've just seen commit 599f4b06a5a988cfb2b27be51bf947a88a224508 so I guess I am running a version of mariner from before this.  Is there a Debian package which includes the latest mariner code?

Hey, I'm still not sure why mariner doesn't seem to be sending line breaks for you. I'll get back to this thread once I have a bit more of time, but thanks for your investigation so far!

Is there a Debian package which includes the latest mariner code?

Yes, every commit on GitHub has an Action that runs on CI for packaging that build as a .deb file, so you can download it from the artifacts of that GitHub Action run. The current one is here: https://github.com/luizribeiro/mariner/actions/runs/1018824027
That said, I don't expect the latest commit on master to be of any help to this issue from what we have seen so far

Development build of the latest github code now shows the CR LF.  Miniterm shows that the printer can be controlled via the UART, but M4006's  always seem to be rejected with the increasing 'N:xx' response.  The Mars Pro also gives an error to M4002 (get firmware version).

Yes, every commit on GitHub has an Action that runs on CI for packaging that build as a .deb file, so you can download it from the artifacts of that GitHub Action run. The current one is here: https://github.com/luizribeiro/mariner/actions/runs/1018824027

Thanks!

Not a big surprise, but the new .deb gives the same results as the development build ie the commands correctly have a CR LF at then end of them.  Unfortunately, this does not solve the problem of not being able to print from mariner.
My test scenario is that I select a file in mariner, and press "Print".  Nothing happens.
I then stop the mariner service and fire up minicom and a shell.
In the shell, I issue
echo "M23 /File1.ctb" > /dev/serial0
and in minicom I see
SELECTED FILE
File1.ctb
SELECTED FILE
OK N:nnn

nnn is an incrementing number.
I also see plain old "OK"'s appearing regularly which I presume is some sort of heart-beating.
M20, M24, M25, M27 and M33 work as I would expect.
From what I see, OK's with an "N:" are a response to a command (as opposed to plain old "OK") so they should definitely not generate an exception.
One point I will make is that I recently updated my Mars Pro to V4.4.3_c1_LCDF System EL3D-3.0.1 which was a requirement for ChituBox 1.9.  Not sure if this is relevant, and I would rather not remove this firmware, but I thought I would highlight this.
Next stop is to look through printer.py to see if I can determine why my Mars Pro dislikes what mariner is sending.

So....
I have to presume that the code in printer.py is working for a good many printers/firmware levels, however for my Mars Pro at 4.4.3,   the way that printer.py works today is inconsistent with the results I see from my manual testing (IMHO).
If I want to print a file, I need to do the following:
M23 /File1.ctb ->
                        <- File selected
                        <- File1.ctb Size:8472210
                        <- File selected
                        <- ok N:460
M24                ->                                # Resume
                       <- ok N:461
### Printing now starts
M25                ->                                # Pause
                       <- ok N:462
M27                ->                                # Print Progress
                      <- SD N:463
                      <- byte 1363986/8472210
                      <- ok N:463
M33               ->                              # stop print
                      <- ok N:464
### Printing stops

For all of the M400x codes that I have issued, I only get "ok N:nnn" responses and nothing else.
I also think that if commands arrive at my printer too quickly, then the printer can get into a strange state and appear to become unresponsive and it can take a bit of coaxing to get the printer to action commands again.
@luizribeiro My conclusion is that for Mariner to work with my Mars Pro, printer.py would need a reasonable amount of rework.  For printer.py to work with my Mars Pro and continue to work as it does today for all of the printers currently supported, then I think there is an even bigger task ahead.  I'm interested in your thoughts.

Notes:  Mainly using https://docs.google.com/document/d/14UBMO0Vhh9Lr0V3xcdetQ2_4UDnjFnho7OnbNxLOs3o/view# gcode reference.

I've forked Mariner, and my forked Mariner is mostly working for Mars Pro firmware 4.4.3.  There are a few issues to be ironed out, but it is mostly working with a few kludges necessitated by the lack of information from M400n commands.   The code is intolerant of earlier firmware so not fit for a PR.  Several of the tests are also broken.   Finally, I've removed the need to have the #180 fix.
My conclusions from further testing is that the "new" UART code in my printer's firmware is a little buggy when it comes to output buffer management for multi-line responses.  As as example, the text response to M27 should be something like
printing byte 0/29771388
but it looks to me that they have simply put the preceding
SD N:10\r\n
into the same buffer at offset 0, with the result that what is printed is
SD N:2
ng byte 364998/8472210
ok N:2

or
SD N:10
g byte 364998/8472210
ok N:10

or
SD N:100
 byte 364998/8472210
ok N:100

I also get pretty messed up file lists from M20
If the UART is important to ChiTu, I can only imagine that they will fix these bugs with the result that any mariner code written to accommodate these bugs in the responses is likely to break in the future.
My thinking is that the newer firmware levels should be monitored for a while to see if further changes are made (or rolled back) so unless there is increasing pressure from users who install the problematic firmware levels, I'd suggest not making lots of changes as a result of my experiences.  Happy to discuss further.
My code is mostly in printer.py https://github.com/BlueFinBima/mariner/blob/master/mariner/printer.py

@BlueFinBima I'm on the same new firmware on my Mars 2 Pro and just installed your fork. Seems to be working well so far. Ran my first print entirely from the web interface for the first time, looks like it's holding up so far. Thank you @luizribeiro for creating this project And BluefinBima for the update. I'll let you know if there are any snags in the new code for me.

@BenStein1 thanks for the feedback.  I have opened a few issues on my fork describing the problems I know about.  I do not remotely suggest that the current inventory is the extent of the problems.
https://github.com/BlueFinBima/mariner/issues

Thanks for digging into this @BlueFinBima! I was looking at the changes on your repo and I think it should be possible for us to just create a separate ChiTuPrinter class which handles these more modern firmwares. Then we can expose an option on the config file to toggle between the two implementations.
It will lead to some duplicated code and I guess the fact that firmware 4.4.3 doesn't support certain commands is a bit unfortunate, but we do what we can :)
If you or anyone has interest on merging these changes in I'm happy to review a PR

@luizribeiro Thanks for taking a look at this.  I still feel that further changes by Chitu in this area are likely / possible so with my current workload, I personally won't revisit this until yet another firmware is released which is incompatible with this Mariner3D.
I'm not averse to creating a PR in future, however the technologies used in this project are all alien to me, so I am unlikely to be able to include automated tests.
I will continue to raise issues against my fork to document problems in case someone else wants to create a PR for 4.4.3.

Hello @BlueFinBima and @luizribeiro,
As I was also facing troubles with the specific firmware mentioned above (running on a mars pro 2), I finally managed to find this great explanation (and the even better solution) here!
I am extra thankful for the original mariner software as well as the additions to the printer.py file and was wondering if a link or at least a hint to problems with 4.4.3 could be added to the readme of this project? Given that more and more users are upgrading, I am relatively sure, that this would save people a lot of time :P
On top I want to ask for a couple of lines on how to get the code running by ‘git-cloning’ it (at least for Bima’s repo, there are no .deb files available).
Thanks again for all the great work! Please keep it up.
Cheers
JI

I thought this might solve the issue of encrypted .ctb files causing 500 errors. Unfortunately, not.

Hi,  I have not used my SLA printer for a while so I have not encountered
the problem you describe, however, from the outset it appeared that the
internal firmware was in a state of flux, and I guess that this continues
with the encryption.  Fundamentally, the encryption should not in itself be
a problem because the printer firmware knows how to decrypt it, but if the
information about the print being exposed on the serial port is different
or worse, non-existent, then this could spell the end of mariner.
Unfortunately, until someone more knowledgeable than I fixes the build
problems, changes on my fork are not going to happen.
On Sun, 16 Jan 2022 at 11:32, fcollingwood @.***> wrote:

I thought this might solve the issue of encrypted .ctb files causing 500
errors. Unfortunately, not.
—
Reply to this email directly, view it on GitHub
https://github.com/luizribeiro/mariner/issues/453#issuecomment-1013858822,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENLAGGD3QTRPZ7OEFFCQPTUWKUEXANCNFSM5CGK7BTQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Can anyone explain how to install this forked version over the original? The docs listed point to the original mariner & I dont know enough about this to make it install this fork instead.
I presume its fairly simple, thanks for any help.

@Blanks82 I ran into the same problem with my Mars 3. It seems there isn't much development happening on this anymore...
I tried to replace the .py files in /opt/venvs/mariner3d/lib/python3.9/site-packages and /opt/venvs/mariner3d/lib/python3.7/site-packages (don't even know at this point what directory should be used lol) with the ones from @BlueFinBima's fork. However, the behaviour stays the same for me:
Webfrontend throughs a HTTP 500 when anything file-related is happening. Unfortunately reporting the status via the (undocumented) API seems to count as file related...
Even through the serial line is still being read and there is info, because of the file read function not working, the client doesn't get the reply:
DEBUG:mariner.printer:Obtain Print Status Command Requested
DEBUG:mariner.printer:b'M4000\r\n'
DEBUG:mariner.printer:Full Response Message:
ok B:0/0 X:0.000 Y:0.000 Z:49.950 F:256/256 D:15504575/18035958/0
DEBUG:mariner.printer:Obtain the Selected File Command Requested
DEBUG:mariner.printer:b'M4006\r\n'
DEBUG:mariner.printer:Full Response Message:
ok 'Butt-notail-PLUG-PANTY_Rl.ctb'
ERROR:waitress:Exception while serving /api/print_status
Traceback (most recent call last):
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/waitress/channel.py", line 397, in service
task.service()
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/waitress/task.py", line 168, in service
self.execute()
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/waitress/task.py", line 434, in execute
app_iter = self.channel.server.application(environ, start_response)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 2464, in call
return self.wsgi_app(environ, start_response)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/whitenoise/base.py", line 85, in call
return self.application(environ, start_response)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 2450, in wsgi_app
response = self.handle_exception(e)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 1867, in handle_exception
reraise(exc_type, exc_value, tb)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 1952, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 1821, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 1950, in full_dispatch_request
rv = self.dispatch_request()
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask/app.py", line 1936, in dispatch_request
return self.view_functionsrule.endpoint
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/mariner/server/api.py", line 73, in print_status
sliced_model_file = read_cached_sliced_model_file(
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/flask_caching/init.py", line 952, in decorated_function
rv = f(*args, **kwargs)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/mariner/server/utils.py", line 23, in read_cached_sliced_model_file
return file_format.read(config.get_files_directory() / filename)
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/mariner/file_formats/ctb.py", line 154, in read
ctb_slicer = CTBSlicer.unpack(file.read(CTBSlicer.get_size()))
File "/opt/venvs/mariner3d/lib/python3.9/site-packages/typedstruct.py", line 89, in unpack
return cls(*unpack(cls.get_format(), buffer))
struct.error: unpack requires a buffer of 76 bytes
Maybe I will just delete the file handling stuff, so I can at least get a status reply...

@Blanks82 the deb got deleted from the packaging action, and I was unable to get a successful package to recreate it.   I have now finally managed to get this to work (I think) and the deb is now available here https://github.com/BlueFinBima/mariner/releases/tag/v0.2.0-1

@BlueFinBima
Have you been able to test your fork with newer firmware versions such is 4.5.1?
I would like to test this with my Saturn S. Plenty of experience with Unixes and shell, some programming experience as front end dev (however, mainly JS and React). Using Klipper on FDM printers now…
I have OTG and Samba parts working correctly, main fork of Mariner is working (had not connected it to printer yet).
Later I want to add Raspberry Pi cam module and modify React frontend to get image from RPI camera output to monitor prints.
Being able to control printer too would be absolutely perfect.

@jremen I have not used Mariner or my SLA printer for quite some time (there was a major resin spillage which dampened my enthusiasm for the technology).  Anyway, my fork is dormant, at least until I have a need to use the machine again, and from the experiences of others, I probably won't update the firmware unless there is some very compelling reason to do so.  Good luck with your project.

@BlueFinBima I merged your work with @Desterly's downstream changes to read encrypted CTB files. I had to update the build workflow too. It's now here. Happy to raise a PR back on your fork or keep it here?

@BenStein1 thanks for the feedback. I have opened a few issues on my fork describing the problems I know about. I do not remotely suggest that the current inventory is the extent of the problems. https://github.com/BlueFinBima/mariner/issues I am happy for you to raise additional issues, but my intention is that my fork is a temporary measure to help people (and myself) until the official Mariner is able to support the later Firmware levels, so no guarantees that I will fix new issues.

I had an issue that wouldn't allow me to upload files on the web and got your fork, now I can upload files and preview them but I don't have the ability to start a print on the web or view printer status while its printing (i can manually start the print that I uploaded on the web and it prints just fine).
Additionally, when I attempt to start a print from the web I get the error "The printer returned an unexpected response: 'ok N:0\r\n'". It appears that although your fork solved my original solution it has given me the issue that this thread started with. I am thankful I can now upload files but it would be awesome if I could start the print and view status too. Should be noted that I have no idea what I'm doing when it comes to this stuff and it is possible that I didn't install your fork correctly (all I did was follow the install instructions in the zip). Any help would be appreciated, thanks!


Clang 10 - Ubuntu 20

Running on Ubuntu 20 (Clang 10) it fails to compile with:
clang_10_scene_importer.txt

Whoops, looks like it's not as portable as I thought it was. Do you also happen to use Clang 10 for compiling Flutter Engine BTW?

@bdero for the engine (x86_64, arm, arm64) I use the built in toolchain, and for riscv64 an enhanced external clang 18

@jwinarske flutter_scene 0.5.0-0 and flutter_scene_importer 0.2.0-0 have some fixes to make the compilation more portable here. I also landed fixes recently for the GL backend in Flutter GPU, so I'm hoping this package can run in your setup now.
Would love it if you could give it a try. :) I'll close this issue for the moment, but let's re-open it if you still run into issues.

I'll test it out when I'm back in next week

@jwinarske Let me know if you get a chance to try this out. I'm interested in helping you get it working (and to land missing features or solve rendering bugs for your use case).
We're planning to make a lot more progress on rendering and interactivity features this package. :)

Will get to by Monday!


DOC: changelog addition concerning b76ec153bf86506ef7b577aa33594a4f1ce4a470

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.002%) to 91.502%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/core/alignment.py
1
94.38%

.nox/test-3-11/lib/python3.11/site-packages/cogent3/evolve/likelihood_function.py
1
96.3%

.nox/test-3-9/Lib/site-packages/cogent3/evolve/likelihood_function.py
1
96.45%

.nox/test-3-9/lib/python3.9/site-packages/cogent3/maths/scipy_optimize.py
3
83.88%

.nox/test-3-9/Lib/site-packages/cogent3/maths/scipy_optimize.py
3
84.87%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
235069

Relevant Lines:
256900

💛  - Coveralls


Atomic add and sub for int32, int64, float32, float64

This PR will add support for atomic_add and atomic_sub for int32, int64, float32 and float64 datatypes and will allow extension for other operations like multiply in the future as well.

Are there any changes that are required to this PR? If not, can we have this merged soon?


Micronaut Guides Test Snapshot is broken

https://github.com/micronaut-projects/micronaut-guides/actions/runs/4061122521/jobs/6990854755

Passes now, it was the issue with Release names
https://github.com/micronaut-projects/micronaut-guides/actions/workflows/snapshot.yml


Remove TODOs added for HTTP abort() change in dart sdk

The abort() change has made to flutter engine. We can remove those ignores.
https://github.com/flutter/engine/pull/20545

Why was this merged on red?

Sorry about that. I didn't notice it was red.


Extract pdf on per page basis

Hi,
Do we have support in the python-tika to extract pdf on page level? I want to deconstruct the big pdf into saparate pages and extract them saparately. Could it be done using Python-tika. In the native version, atleast they say that one can do it counting .... tags. As Tika returns each page wrapped with these tags. I was wondering if Python-tika do have support for that?
Thanks.

Hi @luhgit we typically do this by defining some "split" for the page and then just calling parsed = parser.from_file and then pages = parsed["content"].split(SOME_DELIM. Would that work?

@chrismattmann , hope this message finds you well.
Just want to get a better understanding on what you said about 'split'. To split each PDF page, what delimiter you are referring to? The texts parser returned do not have defined delimiter with pdf texts.
For instance, below returned text from parser, after bold text (31 DECEMBER 2018) is 2nd page, not sure if \n\n\n\n is the page break used by Tika by default?  I checked the rest texts, it seems \n\n\n\n appears at end of each page!

"\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\nAhli United Bank B.S.C.\n\nCONSOLIDATED FINANCIAL STATEMENTS\n\n31 DECEMBER 2018\n\n\n\nAhli United Bank B.S.C.\n\nCONTENTS OF THE CONSOLIDATED FINANCIAL STATEMENTS\n\nIndependent auditors' report to the shareholders of Ahli United Bank B.S.C………………………………..

thanks @luke4u I think one way you could do it is just to use pdftk to split the PDF into individual pages, and then use Tika-Python after that?

Thanks @chrismattmann . I was trying to find delimiter within texts parsed by Tika. Now I get to know there is no such delimiter. I decided to use what you said to split pdf and use Tika.

Hi,
I used tika-python also split the pdf as well. You can turn xmlContent parameter as True in parser.from_file() function and later you can parse the return XML with beautiful soup. Each page contents are wrapped in a  element with page attribute e.g. . See the code below I wrote for my parser which splits and extract the contents for a pdf.
from io import StringIO
from bs4 import BeautifulSoup
from tika import parser

file_data = []
_buffer = StringIO()
data = parser.from_file(file, xmlContent=True)
xhtml_data = BeautifulSoup(data['content'])
for page, content in enumerate(xhtml_data.find_all('div', attrs={'class': 'page'})):
    print('Parsing page {} of pdf file...'.format(page+1))
    _buffer.write(str(content))
    parsed_content = parser.from_buffer(_buffer.getvalue())
    _buffer.truncate()
    file_data.append({'id': 'page_'+str(page+1), 'content': parsed_content['content']})

I hope this helps. Let me know if you have questions.

Thanks @luhgit This is really helpful! more efficient than splitting pdf.

thanks a lot @luhgit ! That really helps me too. Will try to do it on doc file now.

Hi,
Thank you a lot @luhgit  for the code!
In my case, buffer.truncate() wasn't truncating the buffer so the output is being accumulated (eg.:[page1, page1+page2, page1+page2+page3,...]).  To fix it, I simply create a new buffer each time; it's faster.
pages_txt = []

# Read PDF file
data = parser.from_file(filename, xmlContent=True)
xhtml_data = BeautifulSoup(data['content'])
for i, content in enumerate(xhtml_data.find_all('div', attrs={'class': 'page'})):
    # Parse PDF data using TIKA (xml/html)
    # It's faster and safer to create a new buffer than truncating it
    # https://stackoverflow.com/questions/4330812/how-do-i-clear-a-stringio-object
    _buffer = StringIO()
    _buffer.write(str(content))
    parsed_content = parser.from_buffer(_buffer.getvalue())

    # Add pages
    text = parsed_content['content'].strip()
    pages_txt.append(text)

return pages_txt

Hi @salvacarrion,
I don't know what could have been the reason for the buffer not to be truncated. But I would agree that creating a new buffer every time is also another way to solve it. I just avoided it in order not to leave much work for garbage collector :)
But I am happy to hear that it helped you.

Thanks for the code. It works great for me.
I need to process pdf files on a  page by page basis. I started off using pypdf2 as it returns text as a concatenation of pages. But I have got burned by pypdf2 - it is unable to convert to text several pages and documents. For the pdf files that I have, tika has been more robust when it converts pdf to text.
The above soln takes care of both my needs : robust conversion to text and an ability to process individual pages.
Thank you so much !

this is  great work @mchari @salvacarrion and @luhgit ! can someone write me a unit test using that function? I'll add a new module  pdf.py in the tika/ folder, and  keep that as a key function...

@salvacarrion @luhgit hi, i am having the same text accumulation problem where the buffer isn't being truncated so i tried creating a new buffer each time as suggested but that leaves me with my parsed_content['content'] string containing None. any idea how to fix this?

update: _buffer.seek(0) is required before _buffer.truncate(), this fixed my truncation issue!

thanks @emmalaud if someone gets a chance Id appreciate someone putting together a unit test?


DropBox location error handling

The current create_folder_pathways function throws an error if there is no file to specify the Dropbox folder location. I am undecided whether this is the best method, or if the lack of a specified folder location should just result in the pathway being NULL with a warning to the user. Because of the reliance of many functions on the presence of a DropBox folder, we might want to require this, but a DropBox folder per-se is not required for the processing and analysis of data, so NULL might be the best option moving forward.

@williamschmitt21, my current thoughts are:

Expand how 'create_folder_pathways' creates default files for the 'location' text files.
For the DropBox case, provide options to either 1) create a file with NULL or 'Provide file location', or 2) create a file with a default 'placeholder' local folder (e.g., create a 'DropBox_backup' folder in the main directory). This would give greater options regarding error handling:

will cause errors downstream but provide users a template to properly add in a path.

will avoid downstream errors entirely but risks not being fixed at a later date.

Add arguments to 'create_folder_pathways' that allow us to control when and how these defaults are applied.

A good weekend project!


[Doc] Fix broken urls in gaudi-installation

Certain links on the gaudi-installation page which were pointing to docs.habana.ai are broken due to recent re-structuring of docs.habana.ai. This PR fixes those.

@michalkuligowski , Added the same changes to README_GAUDI.md in the latest commit.


Fix/max leaves

Fixes max leaves bug #32 and makes the booster pickleable.

@gravesee Adding the ability to pickle a booster, just wanted to run by you, that you didn't see any footguns with this?

The Booster object itself can't be directly pickled because it's just a reference to something in memory, so I am dumping the model, and then reloading from that dump.

Only thing I'd try different is dumping the file to bytesio (if that is supported) instead of having to write a file, but otherwise looks good to me

Good callout yeah, I don't think that's possible, just because you can only pass a string path to the rust side to use as a file path to save.

Ah yeah, I forgot about that. Can rust return bytes, though? From the serde deserialization?

Good question!
I can look at that, that would be good to have, as a save load option. And then would make dealing with python file like objects easier.

Actually, I could use the from_json and json_dump methods directly as well. Rather than the save and load methods.

The nice thing about bytes is that they're pickleable. that was my original motivation but definitely not a requirement!

OK, this seems cleaner, thanks for the suggestion!


Production ready?

Do you think this module is production ready?

Not at the moment. I think we need to get this into a proper Github Org and some so more outside help.

I can help. I wish I could use this in pro.  I think it works well and I think I understand the code well enough to fix it when it doesn't, but it's hard to convince other people that it's suitable for production unless we do what @zawachte suggests. Shall we do it?

@richardcase (works at SUSE and is very involved with ClusterAPI) and I were talking about this a few months back.
I would love to get those conversations started again.

Yes lets pick this up again.

@mkmik it is done!

@mkmik I cant seem to get this up and running (See issue #48) - do you want to get together and maybe write a Setup Guide?


Support hash in parseUrl()

Thank you. Does this fix work in IE? If not, can it (realistically) be backported to version 5?

This was a breaking change. In version 6.1.0, the following was happening (js formatted for RunKit.)
var qs = require("query-string@6.1.0");
qs.parseUrl("https://www.site.com/#/spa-resource?x=1234");
// Result:
// Object {query: Object {x: "1234"}, url: "https://www.site.com/#/spa-resource"}

With 6.2.0:
var qs = require("query-string@6.2.0");
qs.parseUrl("https://www.site.com/#/spa-resource?x=1234");
// Result:
// Object {query: Object {}, url: "https://www.site.com/"}


Kata Containers 1.11.3

actions: Add action to perform checks for pull requests

6867c8c actions: Add action to perform checks for pull requests

/test


Error in Bearing: "x must be strictly increasing"

I encountered this error while testing tables. Not only is required that the 'w' parameter is sorted, it must also be strictly increasing, meaning that a decreasing 'w' will cause that error, which is what happened during testing. Sorting parameters in init method can fix this.

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

If the issue refers to a large task, break it in smaller issues that can be solved in
less than 45 days;
Label the issue as wontfix or wontfix for now and close it.


install-package ocelot failed!

I create a asp.net core empty project with vs2017 which is based on .net core 2.0.
when I try to install the ocelot with nuget tool ,it failed with the error ' install-package : NU1108: 检测到循环。
ocelot -> ocelot (>= 7.0.6).'
why?

@zjlhope thanks for your interest in Ocelot! 😄
I do not have the same problem as you. I have created a clean Ocelot project with version 7.0.6 here using vs2017. I suggest trying to use this project as the basis for what you are doing.
Hope that helps.

@TomPallister  thanks for your reply.
I known what you say,when It‘s an .net core console project ,I can install it,but when it's an asp.net core empty project,I can't install it .All is based on .net core 2.0.

@zjlhope the project I have linked to uses the Empty ASP.NET core template in VS2017!
Could you upload the code that isn't working so I can have a look?

It's OK now!!
The project name can not be set ocelot!!
otherwise I can't work

@zjlhope that makes sense, if you call it Ocelot you will get namespace conflicts :)


continuous testing

the current tests:

execute in node on the bundled output
have to be  manually re-run after changes to the code

I'd like to set up the tests to run whenever the code changes and to run on non-bundled output (i.e. something that would actually be used in a node app). I'm thinking something along the lines of what is discussed here: https://github.com/rollup/rollup/issues/657#issuecomment-220786674

@tomwayson I think this can be closed?

yep
https://github.com/Esri/adlib/blob/3da1637158aa5e0c9f0955dcab10696daa6ab95c/package.json#L13


Add restart policy to containers

Sometimes containers crushes and servers reboots.

Hey, @zekchan, Sorry for seeing this late. Could you update the base branch

@chzyer done


improvements to the poll block

The vote options are now separated by a divider block, making it easier to distinguish between them. In addition, the question is now displayed using a markdown style in italics, and date in bold to make them stand out and improve the overall readability of the poll block.
Voting

Final Result

Time zone fix
Screencast from 2023-03-16 12-59-02.webm

@murtaza98 sir i made the type and await changes.

LGTM! Quite a good addition :clap: Congrats!

LGTM! Quite a good addition clap Congrats!

Thanks for reviewing my PR  and helping me improve this feature.


[Bug] All Anvil models needs updating

Due to a backend change on Anvil, all Anvil models, specifying mem_per_cpu option will results in following (similar) error
srun: fatal: cpus_per_task set by two different environment variables SLURM_CPUS_PER_TASK=2 != SLURM_TRES_PER_TASK=cpu:1
According to updated Anvil configurations, the memory is assigned automatically as 2GB/core, so mem_per_cpu option will be redundant and will cause issues on job submissions. Refer to following for further details https://github.com/I-GUIDE/container_images/issues/11
Possible Resolution

Identify all CyberGIS-Compute models which has an option to be executed on Anvil as HPC
Remove mem_per_cpu option from these models' manifest.json

Great, thanks. Is there a way to identify which models are configured to use Anvil on our end?

There isn't a good way, no. I guess the best approach would be to go through this page (https://cgjobsup.cigi.illinois.edu/v2/git) and control find "anvil_community" then create an issue on each repo?

The proposed solution mentioned above will only work for models using Anvil ONLY. If a model supports more than one HPC, removing mem_per_cpu option altogether may result in unexpected behavior on non-Anvil HPCs.
Is there a way to provide conditional configurations in manifest.json? If not, I think it may be easier to update cybergis-compute-core to ignore this parameter when submitting jobs to Anvil.

I don't think it's a big deal. Globus on Keeling is broken, I don't think we currently have credits on Bridges or Expanse, and ACES requires per-user approval, so Anvil is the main Hpc being used currently.
We don't currently have a way to remove configs on a per HPC basis, only to add them. If Anvil can't fix this issue and modifying the manifests won't work, I can hack together a patch tomorrow and put it on production, but a longer-term solution might take a while because the code isn't set up for it.


Canceling while adding presset bug

Go and try to add new preset. Type something in "name" or left it clear. Then press "cancel" button.

New unnamed preset was added after first preset!

100% repeatability

Indeed, it seems that a preset was added however the popup was closed, thanks! :smile:


Invalid image - onerror event not handled, promise never rejected

Hi,
thanks for this awesome lib. I have a problem though. When I try to compress a corrupted / invalid file, I never get any resolve or reject from compressFile's promise. I've looked though your code and the problem seems to be that you handle the onload event (image-compress.ts:118) on the Image object you use for the compression, but you don't handle onerror to reject the promise in case of invalid images.
Please add the .onerror callback containing a reject(error), so the app doesn't loop forever.
Thanks!

Fixed in version 13+


[BUG] Failed to load suitable IPA Library for IMX708

Describe the bug
I've been able to successfully get my pi camera 3 (IMX708) to load on Ubuntu 22.04 with the linux-raspi kernel 6.2. The cam debug tool in libcamera is able to display and save images, but the libcamera-apps are not. Apps all fail with "Failed to load suitable IPA Library for IMX708.
Bug report
bug-report.txt
Additional context
I cloned and built the "next" branch noting that several IMX708 additions had been made there but that did not resolve the issue as I had hoped.

Thank you for reporting the issue!
It looks like this may be an out-of-date libcamera library install that is causing your issue. Support for imx708 is not yet available in the upstream libcamera tree.  We have sent the patches to be reviewed, so hopefully this should not be too long now.
In the meantime, you must build the libcamera libraries from our downstream libcamera tree at https://github.com/raspberrypi/libcamera/tree/main.  This has all the support needed for the imx708 sensor.

I'm not sure if this is related, but I've been able to use the IMX708 (Camera Module 3, standard lens, NoIR) with "stock" libcamera from a fresh Raspberry Pi OS install (I think I ran a full update).
I did notice that I can't get an exposure longer than 1.72 seconds, though, which seemed odd.

EDIT: I missed that you seem to have cam working correctly, so that is a bit confusing. cam and libcamera-apps use exactly the same IPA, so if one works the other really ought to. Can you clarify how/where you built libcamera from?

Yes, this struck me as odd as well! I did first build libcamera from source with the downstream tree and that wasn't working right, which is why I tried the upstream tree. Perhaps when I wiped that initial install the IPA stuck around? Not exactly sure, but I am going to try a clean ubuntu install with a clean libcamera and libcamera-apps install to see if that works and will update you with what I find.

I did notice that I can't get an exposure longer than 1.72 seconds, though, which seemed odd.

This is because the long exposure feature did not get integrated into the kernel driver in time for the product launch.  This has since been merged https://github.com/raspberrypi/linux/pull/5306, so newer kernel builds will show a longer maximum exposure time.

Yes, this struck me as odd as well! I did first build libcamera from source with the downstream tree and that wasn't working right, which is why I tried the upstream tree. Perhaps when I wiped that initial install the IPA stuck around? Not exactly sure, but I am going to try a clean ubuntu install with a clean libcamera and libcamera-apps install to see if that works and will update you with what I find.

That would be a useful thing to try.  The upstream tree will definitely not work with the imx708 until the patches have been merged.

Is there anything more to look at here?  If not, I'll close this issue down.

I'll close this one down for now.  Please do re-open if you are still seeing issues.

Thanks!


[UPGRADE] Path for environment variables fetched via System.getenv

Is your feature request related to a problem? Please describe.
We have renamed environment variables, e.g. ES_TMPDIR has become OPENSEARCH_TMPDIR.
We have renamed ES_JAVA_OPTS to OPENSEARCH_JAVA_OPTS used in opensearch-env.
What is the path forward for those settings?
Describe the solution you'd like
Document the way this breaks for users.
Provide a migration path.
Optionally provide tooling to aid users in the migration path.
Additional context
Coming from #640.

#846 will close this. Bumping to v1.1 release

Closing with #846 done.


Option for show label of language name in Codehilite

Like image

The HTML generated by the extension is whatever output Pygments gives us. If there are any changes to be made to the HTML, then that issue should be raised upstream with Pygments. If Pygments already offers such a feature and you would like us to add a setting for it, then please point us to the Pygments documentation for the feature and/or (even better) submit a pull request.
However, if the feature can be implemented simply with some CSS rules (without any changes to the HTML), then that is outside the scope of the extension as the extension does not provide any CSS. All CSS is the responsibility of the user.


Adds some functions for visualizing spectra and labeling spectral lines

Also fixes #36

Codecov Report
Attention: Patch coverage is 16.92308% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 63.14%. Comparing base (1e45e65) to head (be9774a).

Files
Patch %
Lines

mocksipipeline/visualization.py
10.20%
44 Missing :warning:

mocksipipeline/modeling.py
0.00%
10 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   67.17%   63.14%   -4.04%
==========================================
  Files          15       16       +1
  Lines         722      776      +54
==========================================
+ Hits          485      490       +5
- Misses        237      286      +49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Mint proxy credentials

How can I set proxy credentials when using Tesla.Adapter.Mint  . According https://hexdocs.pm/tesla/Tesla.Adapter.Mint.html It should be something like {:http, "<IP_ADDRESS>", 8888, []} , but where can I pass credentials just like: {Tesla.Adapter.Hackney, [proxy: {"<IP_ADDRESS>", 1234}, proxy_auth: {"user", "pass"}]} ?

There are multiple ways you could configure it.
Please read https://hexdocs.pm/tesla/Tesla.Adapter.Mint.html and https://hexdocs.pm/tesla/Tesla.html#client/2


"Jump to factory" link in tests

I have checked that this feature is not already implemented

[X] This feature does not exist

Use case
Would be nice to have a "Jump to factory" link in test files similar to the "Jump to view" we have in controllers.
describe "#foo" do
  it "calls foo" do
    # "Jump to factory" link  would appear here, once clicked would open the Widget factory
    widget = create(:widget)
    widget.foo
  end
end

Ps:  considering one is using the factory_bot gem
Description
This would increase the productive of devs since they no longer will need to hit cmd+P to look for the factory file definition
Implementation
No response

Because this feature will require factory_bot-specific knowledge, which is not a Ruby default tool, it should be provided through an addon instead. We will not provide this feature directly from ruby-lsp.
You can either build a standalone addon gem like ruby-lsp-rspec, or convince factory_bot to have a built-in addon like standardrb does.

thank you for the references, that makes sense!


How can you pipe the output to ffplay?

Is there a way to pipe the output live to ffplay so it can be viewed immediately?

Something like this:
import ffmpeg
import subprocess

in_filename = 'in1.mp4'

probe = ffmpeg.probe(in_filename)
video_stream = next((stream for stream in probe['streams'] if stream['codec_type'] == 'video'), None)
width = int(video_stream['width'])
height = int(video_stream['height'])

process1 = (
    ffmpeg
    .input(in_filename)  # (or whatever)
    # (filters/etc. go here)
    .output('pipe:', format='rawvideo', pix_fmt='rgb24')
    .run_async(pipe_stdout=True)
)
process2 = subprocess.Popen(
    [
        'ffplay',
        '-f', 'rawvideo',
        '-pix_fmt', 'rgb24',
        '-s', '{}x{}'.format(width, height),
        '-i', 'pipe:',
    ],
    stdin=process1.stdout,
)
process1.wait()
process2.wait()

@kkroening thanks so much for this! I wanted to ask a question related to the code above:
If I implement any kind of filtering in the section you marked with:  # (filters/etc. go here) I seem to be unable to live affect the args given to the filters. So if for example blur the image by calling:
.filter('gblur', sigma=blurIndex)
and I try to increment blur index in time only the first value seems to affect the video. Do you know if it's even possible to affect the filter parameters live?

Do you know if it's even possible to affect the filter parameters live?

There is no way that I know of to change ffmpeg filter graphs dynamically.


3258 add divertor and fwblanket lifetimes to st availability model

Description
This adds the divertor and blanket lifetimes to the ST availability model. To streamline things, the divertor lifetime calculation was converted to its own function and inserted where the calculation was previously present in all availability models.
Checklist
I confirm that I have completed the following checks:

[x] My changes follow the PROCESS style guide
[x] I have justified any large differences in the regression tests caused by this pull request in the comments.
[x] I have added new tests where appropriate for the changes I have made.
[x] If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
[x] If I have made documentation changes, I have checked they render correctly.
[x] I have added documentation for my change, if appropriate.

Codecov Report
Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.57%. Comparing base (ec3c1f5) to head (9b41186).

Files with missing lines
Patch %
Lines

process/availability.py
72.72%
9 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
+ Coverage   29.51%   29.57%   +0.05%
==========================================
  Files          77       77
  Lines       19049    19078      +29
==========================================
+ Hits         5622     5642      +20
- Misses      13427    13436       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Setup instructions

Hey, are the setup instructions in the README still correct? I tried following them and couldn't get it to work.
I noticed the MS_CLIENT_ID and MS_CLIENT_SECRET and played around with creating an azure app and trying to get the /auth/redirect part working and after some trial and error I got a valid access_token, so my deployment is working now but couldn't find a refresh token so I'm unsure if it's going to remain working 😄
Any pointers on getting set up correctly would be greatly appreciated.
Otherwise, how do you feel about others using your deployment (https://xboxapi.mrmicky.workers.dev/)?

Hi, yes the setup instructions in the README should be correct (but haven't tested them since the initial release), what's the issue you had ?
About MS_CLIENT_SECRET and MS_CLIENT_ID, it's used only for Xbox OAuth (which isn't relevant for most cases), so the profiles endpoints should work fine without these client credentials


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 15:45:29 on 2023.06.07
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 23478
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=23478

Problem has been resolved in 6m 0s at 15:51:29 on 2023.06.07
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 23478


[Slack Adapters] Add Slack Functional Test

Proposed Changes
Add a new Functional test for SlackTestBot.
Details

Add the new SlackClientTest to FunctionalTests project to test sending a message to the SlackTestBot deployed in Azure with ARM Templates and check its response.
Update the template-with-new-rg.json and the template-with-preexisting-rg.json in the SlackTestBot to take the Slack credentials that will be used to deploy the bot on Azure.
Add the class SlackHistoryRetrieve to manage the retrieving of Slack Messages.

Steps to configure the Nightly Build Pipeline:
1- Define the following environment variables:
BotGroup: It's the name for the resource group.
SlackBotName: It's the name of the bot
SlackBotToken: It's the Bot User OAuth Access Token  from the Slack App ( * )
SlackClientSigningSecret: It's the Signing Secret from the Slack App ( * )
SlackVerificationToken: It's the Verification Token from the Slack App ( * )
SlackChannel: It's the channel ID from the application
( * ) Mark these variables as secret.
2- A NETCore task to publish the SlackTestBot.

The arguments are:
--output $(System.DefaultWorkingDirectory)\tests\Adapters\Microsoft.Bot.Builder.Adapters.Slack.TestBot\PublishedBot --framework netcoreapp2.1

3- An Azure CLI task to create the resources in Azure and deploy the bot.

The inline script is the following:
call az deployment create --name "$(BotGroup)" --template-file "$(System.DefaultWorkingDirectory)\tests\Adapters\Microsoft.Bot.Builder.Adapters.Slack.TestBot\DeploymentTemplates\template-with-new-rg.json" --location "westus" --parameters appId="$(AppId)" appSecret="$(AppSecret)" botId="$(SlackBotName)" botSku=F0 newAppServicePlanName="$(SlackBotName)" newWebAppName="$(SlackBotName)" groupName="$(BotGroup)" groupLocation="westus" newAppServicePlanLocation="westus" slackVerificationToken="$(SlackVerificationToken)" slackBotToken="$(SlackBotToken)" slackClientSigningSecret="$(SlackClientSigningSecret)"

call az webapp deployment source config-zip --resource-group "$(BotGroup)" --name "$(SlackBotName)" --src "$(System.DefaultWorkingDirectory)\tests\Adapters\Microsoft.Bot.Builder.Adapters.Slack.TestBot\PublishedBot\PublishedBot.zip"

4- A PowerShell task to set the environment variables needed to run the test

The script is:
echo '##vso[task.setvariable variable=SLACK_CHANNEL]$(SlackChannel)'
echo '##vso[task.setvariable variable=SLACK_BOT_TOKEN]$(SlackBotToken)'

Finally, the new test will run with the rest of the functional tests and the bot should be deleted with the other resources deployed in the pipeline.
Note: As a pre-requisite, the SlackTestBot must be previously connected with a Slack App.

Pull Request Test Coverage Report for Build 94577

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.14%

Totals

Change from base Build 94519:
0.0%

Covered Lines:
14556

Relevant Lines:
19633

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

My concerns(s) with this are all around how we manage the UserID for slack. I thinkthis PR abstracts it out and we simply add it as a secure variable via DevOps.

My concerns(s) with this are all around how we manage the UserID for slack. I thinkthis PR abstracts it out and we simply add it as a secure variable via DevOps.

@cleemullins, There's no need to set up a UserID. We post the message using the BotToken and the flag as_user to send it as a BotUser. This way, the bot deployed in Azure sees the message as it would be sent by a user and answers it.
As you mentioned, the BotToken is configured as a secure variable of the pipeline.

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3


Selectors in div

Hello,
What happens to the #id Selector which are located in the div that are included in jAlert?
Let me explain: if in a div, such as the one with id = "fromDiv" you find in the sample file test.html, insert the following lines:

test1

<form name="edit"><input type="text" name="test2" value="test2" size="5"></form>
<input type="button" onClick="document.getElementById('test1').innerHTML='ok'; document.edit['test2'].value='ok'" value="test">`
Then if I press the "test" button should appear "ok" in the div "test1" and in the textbox,  instead  seems that these elements do not exist, and I get an error in the JavaScript console.
Note that if I remove the "display: none" from "fromdiv", and so this is always visible, the test is working properly.
When the "fromdiv" is included in jalert,  the selectors "disappear" ...
Can it be solved? Thank you.

Please share more code. I fail to understand your scenario.

This is an example, but the problem always occurs with selector included in the div displayed by jalert.
Do do various tests, I put inside the "fromDiv" a div,  a text box and a button.
Pulls Content From DIV

test1

<form name="edit"><input type="text" name="test2" value="test2" size="5"></form>
<input type="button" onClick="document.getElementById('test1').innerHTML='ok'; document.edit['test2'].value='ok'" value="Click me">

click on link "Pulls Content From DIV":  appears a jalert box
click on the button: instead of "test" terms should appear "ok". Nothing happens: the javascript console display "TypeError: Cannot set property 'value' of undefined", because the page can not find the selector "test1" and textbox "test2"

if instead I put directly the "fromDiv" into the HTML page and not in jalert, everything works fine.

At least one issue here is you're defining an ID in the content (#test1) and when jAlert pops up, it doesn't remove the original element so there ends up being 2 elements with the same id.
Although I still don't recommend using inline JS like that, I think using jQuery would handle some issues for you like cross-browser compatibility and live node changes. For instance, the following is working:
Pulls Content From DIV

test1

<form name="edit"><input type="text" name="test2" value="test2" size="5"></form>
<input type="button" onClick="$('.test1').text('ok'); $('input[name=test2]').val('ok');" value="Click me">

I don't have the time to investigate further, but I assure you it's not an issue with the jAlert plugin. Good luck!


vscode keep openning with power shell integrated terminal even so gitbash as default one

We have written the needed data into your clipboard because it was too large to send. Please paste.

I think the title has provided enough information.


Add proper support for damage resistance bypasses

A few versions ago dnd5e added proper support for resistances like "bludgeoning, piercing, and slashing from nonmagical attacks", but the importer doesn't yet support them.
"dr": {
  "value": ["bludgeoning", "piercing", "slashing"],
  "bypasses": ["magical"]
}

Changing this line
https://github.com/jbhaywood/5e-statblock-importer/blob/ac12be9d5dd3ae071252ec7a6ebb33aadfb9163a/scripts/sbiParser.js#L619
To
const actorData = sbiUtils.assignToObject({}, `data.traits.dr.bypasses`, "mgc")

should do it


Space Travelers' Hub

Project Kanban Board Setup - SpaceX
In this group project, we are two people in the group i.e @SnakyMz and @As1imwe-Mark . We have successfully created the project in our repo and the link for the Group Project is below
Space Travelers' Hub

Made changes as suggested:
Removed the Team3 from issues.

Hi Team,
You can go ahead with your project

Highlights
✅ Tasks are assigned properly
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


workbench.view.alwaysShowHeaderActions for notebook cells

We have workbench.view.alwaysShowHeaderActions in the viewlet to make view actions not visible based on hover, but instead always visible. It would be nice to have this for notebook cell actions too. For some (including myself) UI elements coming in and out of visibility based on cursor movement is distracting and it would be nice to have a way to allow the actions to always be available.
Perhaps this could be rolled in with workbench.view.alwaysShowHeaderActions to a new setting, like "workbench.reduceUIFlicker" or something.

We do have settings to control the visibility of the cell toolbar now