Image issues with Link select/Location/Person

All of the hand icons have what look like artifacts at the bottom right (visible on chrome sites like Wikipedia).

Hello, thanks for reaching out, I fixed the problem now, it must've been caused by a bug in the software I used to make the cursors


Remove the SaB intervention code

This reverts c936edfe164ef074f659d43d1294c98f33c31fe7
The intervention banner experiment has now ended and this code is therefore no longer needed.

Thanks Max. Have you tested this out against integration CDN?


Converting a while loop into a Stream for Mock PA2

hello! I'd like to ask i could possibly convert this while loop to a code that uses Stream instead, i thought about using the following, but I realised orElse is banned :(
thank you!
`        if (num.isValid()) {
        return Stream.<Num>iterate(this.succ(), x -> x.succ()).limit(
                other.opt.orElse(0)).reduce(this, (x, y) -> y);
    }`

thank you! it works now :)


"Drăgoești" , "Buciumeni" , "Geamăna" are listed in the drop-dwon menu

The villages are listed in the drop-down menu alongside its corresponding county and city, according to the law
Preconditions : the  website is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Drăgoești"

Expected results
The location appears in the drop-down menu as "Sat Drăgoești, VÂLCEA (Drăgoești)"

Step 2
Write in the search bar "Buciumeni"

Expected results
The location appears in the drop-down menu as "Sat Buciumeni, VÂLCEA (Drăgoești)"

Step 3
Write in the search bar "Geamăna"

Expected results
The location appears in the drop-down menu as "Sat Geamăna, VÂLCEA (Drăgoești)"


Update CI and common code.

Update CI config and the common code of frontend and backend.

⚠ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

That's no a secret, but a example for request.


cannot set streams on Version 2.9.8

I always get an error message when creating streams as shown in the screenshot. Even a complete reinstallation of the machine has not helped. Tested under Ubuntu Server 20.04.3 and Unraid.
Installed according to the following instructions (of course with adjustment to the current version number).
https://apfelcast.com/nginx-proxy-manager-reverse-proxy-mit-grafischer-oberflaeche-gui/

I have the same problem now! :(

Same problem, installed with unraid Community Applications.

What about v2.9.9?

Thanks JC21, its solved in 2.9.9!! Great!


Local adding issue

Steps to reproduce

I downloaded sm comic externally
Then I put the comic in the given structure in the kuukiyomi folder
And then i head to kuukiyomi and i do find the entry but the chapters don't load ... It says can't load pages

Expected behavior
When i upload the file to the local folder the local manga sources in kuukiyomi should show the entry and load the pages
Actual behavior
The app just doesn't load the local manga sources' pages
Crash logs
https://github.com/LuftVerbot/kuukiyomi/assets/125366928/1dab5c03-165d-4580-9158-f4dc88b03595
https://github.com/LuftVerbot/kuukiyomi/assets/125366928/7cf3d840-bf8b-4f3a-87b6-4705af207950
Kuukiyomi version
0.3.2
Android version
Android 13
Device
Realme 8s
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.3.2.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Sorry I uploaded the same video twice


Adding a GPU model to the compatibility database in tflite

Issue type
Support
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
tf2.15
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I have a question in the "acceleration/compatibility" part in tflite.
As far as I know, Samsung mobile model "samsung_xclipse_920" (S22) information was recently added to the compatibility database to check and support the GPU delegation.
https://github.com/tensorflow/tensorflow/commit/1f3d148aba6a364fb1a271410de4e2f74e32e136
I would like to add "samsung_xclipse_940", a S24 model that was recently released officially on the market,
Are there any ways to do it? Is there anything already in progress? Or, can I upload some PRs (gpu_compatibility.bin ...) related to this manually?
Standalone code to reproduce the issue
flatc -t --raw-binary --strict-json database.fbs -- gpu_compatibility.bin
flatc -b database.fbs gpu_compatibility.json

Relevant log output
No response

Hi @rubber815, there is probably a way ... @impjdi, can you please take a look? Thanks.

Hi @impjdi ,
I would like to know how to submit GPU model information to the compatibility database in tflite? Thanks.

Hi, @hooneecho
Thanks for raising this issue. Are you aware of the migration to LiteRT? This transition is aimed at enhancing our project's capabilities and providing improved support and focus for our users. As we believe this issue is still relevant to LiteRT we are moving your issue there. Please follow progress here: https://github.com/google-ai-edge/LiteRT/issues/76
Let us know if you have any questions. Thanks.


Stopping container manually causes devc error message

Start a project with mvn liberty:devc
Run docker ps to get the container id.
Run docker stop to stop the container.
Dev mode exits but gives an error "No such container" since it still tries to issue a docker stop command itself.

Output below:
[INFO] [AUDIT   ] CWWKE0085I: The server defaultServer is stopping because the JVM is exiting.
[INFO] [AUDIT   ] CWWKE1100I: Waiting for up to 30 seconds for the server to quiesce.
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): http://55e2f4e0bade:9080/health/
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): http://55e2f4e0bade:9080/metrics/
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): http://55e2f4e0bade:9080/
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): http://55e2f4e0bade:9080/ibm/api/
[INFO] [AUDIT   ] CWWKZ0009I: The application demo-devmode-maven has stopped successfully.
[INFO] [AUDIT   ] CWWKE0036I: The server defaultServer stopped after 25.016 seconds.
[ERROR] An error occurred while starting the container: null RC=143
[INFO] The container has stopped. Exiting dev mode.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.114 s
[INFO] Finished at: 2020-09-16T16:41:02-04:00
[INFO] ------------------------------------------------------------------------
[INFO] Stopping container...
[ERROR] Error stopping container: Error response from daemon: No such container: null RC=1
Exception in thread "Thread-8" java.lang.RuntimeException: Error response from daemon: No such container: null RC=1
	at io.openliberty.tools.common.plugins.util.DevUtil.execDockerCmd(DevUtil.java:1109)
	at io.openliberty.tools.common.plugins.util.DevUtil.stopContainer(DevUtil.java:1083)
	at io.openliberty.tools.common.plugins.util.DevUtil.runShutdownHook(DevUtil.java:1471)
	at io.openliberty.tools.common.plugins.util.DevUtil.access$600(DevUtil.java:93)
	at io.openliberty.tools.common.plugins.util.DevUtil$6.run(DevUtil.java:1445)

This was fixed in a previous issue. We still see the [ERROR] An error occurred while starting the container: null RC=143 due to the manually entered docker stop command which is valid but we no longer see the error and exception No such container: null RC=1.

Consider the message:
[ERROR] An error occurred while starting the container: null RC=143
[INFO] The container has stopped. Exiting dev mode.

Since the user likely typed docker stop xxx we don't need to show the error, it would be sufficient to say that the server stopped. Another thing can happen if the user types docker kill xxx or if the container misbehaves and the O/S kills it. In this case the return code is 137. Since it is possible the user did not command it we should show an error.

If you type docker stop xxx the server exits gracefully:
[INFO] [AUDIT   ] CWWKE0085I: The server defaultServer is stopping because the JVM is exiting.
[INFO] [AUDIT   ] CWWKE1100I: Waiting for up to 30 seconds for the server to quiesce.
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): https://6522c9f50cf9:9443/metrics/
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): https://6522c9f50cf9:9443/
[INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): https://6522c9f50cf9:9443/ibm/api/
[INFO] [AUDIT   ] CWWKZ0009I: The application demo-devmode-maven has stopped successfully.
[INFO] [AUDIT   ] CWWKE0036I: The server defaultServer stopped after 38.128 seconds.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  44.068 s
[INFO] Finished at: 2020-12-07T18:07:54-05:00
[INFO] ------------------------------------------------------------------------

If you type docker kill xxx or if the container causes a crash (e.g. out of memory) the server does not shutdown, it just stops:
[ERROR] An error occurred while running the container: null RC=137
[INFO] The container has stopped. Exiting dev mode.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:17 min
[INFO] Finished at: 2020-12-07T18:03:19-05:00
[INFO] ------------------------------------------------------------------------


Autocomplete Annoyance in Version 5.2.3

Hi Serge,
The autocomplete seems to suffer from the following problem:
Say I have a table called "my_super_table" and I want to select from it.
If I type
select * from msuptab
the auto completion shows me "my_super_table" in the drop down list.
But when I select the table name from the drop down list, it completes as
select * from my_super_tablemsuptab
So it doesn't override or delete my previously entered fuzzy search string.

Same here.

+1, autocomplete is effectively unusable due to this

Bug in the 5.2.3.
Workaround: enable "replace current word" option in SQL completion prefs:

As this bug making auto-completion very inconvenient I'm thinking about hotfix version..

I've re-uploaded 5.2.3 release (build<PHONE_NUMBER>30).
The only major change is auto-completion fix

Hi Serge,
I'm still facing this issue, with the latest version (21.3.2) of community edition. Do I have to use enterprise edition for this?

The behavior you show doesn't match the initial report. I think you'll need to open a separate issue.

Added a separate issue 15135.


Issues with unit tests using pytest

I have added unit tests using pytest to my project, but I am getting some errors. I used the URL 'https://www.python.org/' as an example, and I am encountering the following errors:

FAILED sitesniffer/tests/test_sitesniffer.py::test_ip_address - AssertionError: assert '<IP_ADDRESS>' == '<IP_ADDRESS>'
The IP address '<IP_ADDRESS>' is valid according to the test_valid_ip_address() function, but it does not match the correct IP address '<IP_ADDRESS>'. Also, when I connect to the internet using mobile data, ip_address() returns '2a04:4e42:8d::223', which causes the test_valid_ip_address() function to fail.

FAILED sitesniffer/tests/test_sitesniffer.py::test_is_mobile_friendly - AssertionError: assert True == False

FAILED sitesniffer/tests/test_sitesniffer.py::test_has_cookies - AssertionError: assert False == True

FAILED sitesniffer/tests/test_sitesniffer.py::test_has_google_analytics - AssertionError: assert False == True
According to some sources on the internet, the expected boolean values in the tests are correct, but I am still getting errors.

Lastly, I am having trouble with the following error:
5. FAILED sitesniffer/tests/test_sitesniffer.py::test_page_keywords - AssertionError: assert 'Python, programming language, documentation, community' in 'Python programming language object oriente...
Perhaps 'https://www.python.org/' is not an optimal URL for this function, as it has a large number of keywords. page_keywords() does not output all of them, and the test_page_keywords function does not include all of them, causing a difference between the expected and actual values.
Could you please assist me with resolving these issues? Thank you in advance.

Fixed it, take a look at my pull request!


Array size must be nonzero

Hi, zfp -i datafile not working, the message is "array size must be nonzero", the same if i try to decompress, may you help me?

It sounds like you're not specifying the array dimensions using -1, -2, -3, or -4.  Can you please provide the complete command line you're using?

With this suggestion I tried zfp -i test.dat -d -1 2 -a 0.5 -s -o output.dat
But I'm not sure it works. The file test.dat is an array of 2 double elements saved in binary in c with fwrite.
I'm studying the topic recently, I'm still a bit confused. Thanks for your help

This is correct usage assuming you want to compress only two double-precision values, which admittedly is not a realistic use case for any compressor.  Note that -o output.dat will write an uncompressed file that is the result of (lossy) compression followed by decompression.  Use -z if you wish to write the compressed data to file.

Thank you very much, now everything works!

You're welcome.


(iOS) How to determine if remote notification (while app in background) was tapped

Hi,
I am unsure how to determine whether the user tapped the notification while the app was in background.
When I check through the Message object, I see no difference between the message coming through tapping and the message simply being received while the app is open.
Am I missing something?
On Android it appears that the Notification object within the Message is being simply consumed once I tapped on it and therefore null when I receive the Message. But on iOS this does not appear to be the same.

Excellent point!
Right now all messages received in the background on Android end up being routed to the app.  This differs to the behavior on iOS where we can't actually get at the message from the APNS notification until the user taps on it.  I've filed a bug internally where we can come up with a solution.
In the meantime, if you're willing to deal with some Java, you could customize the activity entry point (see https://firebase.google.com/docs/cloud-messaging/unity/client#note_for_android) to flag the message passed to onNewIntent() - which will be the message the user clicked on.  This would allow you to set a flag when the user clicks on a message vs. messages that were received in the background but never clicked on.

We added NotificationOpened to message in the 3.0.0 release of the SDK, see https://firebase.google.com/docs/reference/unity/class/firebase/messaging/firebase-message#class_firebase_1_1_messaging_1_1_firebase_message_1a0ed7d611a65bfbcafe254c0456bf6524


[No QA] [Reassure] Sign in base perf flow

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/33229
PROPOSAL: -
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@cubuspl42 oh yeah, we split the work to help Olimpia, #33229 is a big ticket with sub-tickets, should I comment there that we are working on this?

@gedu Yeah, let's do that to keep track of who's responsible for which tasks

Actually, as the issue is complex, as you say, could you fill the "Details" section with a (possibly short) summary of what is done in the scope of this PR?
Also, does this PR actually "fix" the issue? Will we be able to close that one after this PR is merged?

Please fill the "Tests" section. We changed both the app code and added tests. How did you check that this works? What is another engineer supposed to do to reproduce your actions?
Please fill the "QA Steps". Does this project depend on QA at all? If no, then write "No QA".
Please add at least one video, can be for the "MacOS: Chrome / Safari" platform. This serves as proof that the PR author actually did the first phase of testing, increasing our confidence that the changes are adequately tested.

I'm asking Olimpia who is in charge of the ticket what should be the expected steps, and what kind of information should I add.

@cubuspl42 I asked Olimpia, and there is no need of testing, reproduction steps and videos. Sorry for the missing information, learning the process.
@mountiny can you check this reassure test

@mountiny All good now, I changed the type to support null, given that it is being used on some parts of the project

@cubuspl42 I asked Olimpia, and there is no need of testing, reproduction steps and videos. Sorry for the missing information, learning the process.

@mountiny Do you confirm this? Does it mean that I also should just review the code?

@cubuspl42 Yes, sorry for the confusion, all the perf tests PRs did not have c+ review since there is nothing to test and the code is more about mocking correct data

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.32-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Unescape wiki filename string (Fixes #8284)

This pull request allows wiki pages with special characters in the title to be accessed. It does this by passing the wiki name through html.UnescapeString() when looking for the filename.
Fixes https://github.com/go-gitea/gitea/issues/8284

Hmm... This build on my machine. I'll have to figure out what I did wrong to make the test build fail... Sorry about that

Well, now I'm not too sure what... Maybe someone has a suggestion

It's failing the unit test TestEditWikiPost():

Are you able to run that test it in your computer?

You can test it yourself using:
cd routers/repo
go test -tags="sqlite sqlite_unlock_notify" -run TestEditWikiPost

Or even better:
TAGS="sqlite sqlite_unlock_notify" make clean generate test

(that would run all unit tests, but not the integration tests).

@guillep2k Thanks for the tip!
I think I've worked out a better solution. Basically the issue is that when WikiNameToFilename() passes the name through url.QueryEscape(), it actually no longer matches the filename in cases where there are special characters in the name. But the unit test has a fit when it's not there. So I added url.QueryUnescape() to wikiContentsByName() to correct any special characters later so that these pages can be accessed.

Codecov Report

Merging #8374 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8374      +/-   ##
==========================================
- Coverage    41.8%   41.79%   -0.01%
==========================================
  Files         496      496
  Lines       65586    65586
==========================================
- Hits        27416    27414       -2
- Misses      34654    34657       +3
+ Partials     3516     3515       -1

Impacted Files
Coverage Δ

routers/repo/wiki.go
40.88% <100%> (ø)
:arrow_up:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

routers/repo/view.go
42.53% <0%> (-1.02%)
:arrow_down:

models/repo_list.go
74.14% <0%> (+0.97%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92a0b6...1cec990. Read the comment docs.

I'm so sorry, I've kind of made a mess in this PR lol... I'm a noob. But at least I'm learning lots!
My build seems to have finished... Just waiting for the notify.

No worries.
Now your PR passes the tests, but the CI got stuck on 'notify'. Somebody will look into that.

@Tekaoh could you add a unit test?

@lunny I wouldn't know how, or even really what that means lol... I just took a try at fixing the bug I found. My commit fixes it, but I'm not entirely sure about all the correct procedures...

@Tekaoh You can find many example on https://github.com/go-gitea/gitea/blob/master/models/wiki_test.go#L33 and I think it's not complicated.

I did some deeper digging and found that this PR is not going to be a good solution. I am therefore going to just close it for now.
Maintainers: Please see my explanation at https://github.com/go-gitea/gitea/issues/8284#issuecomment-538779094 and perhaps consider weighing in on what you think should be done. Thanks!


Please consider adding the feature to support adding proxies via API, or the function to request other proxy APIs to obtain proxies through HTTP.

Thanks a lot @luchatex for the ideas.
I've got many requests in this way and will consider both.

done


Added support to be able to customize:

- content view color
    - content view border color
    - title color

This commit doesn't build on my System - did you try it?

@hibento what error do you get? It successfully compiled for me.

Hmm, that´s weird...I got the same error on two Systems. Where UIColorFromRGB defined?
 /Users/hibento/Repositories/External/SCLAlertView-Swift/SCLAlertView/SCLAlertView.swift:135:993:
 Use of instance member 'UIColorFromRGB' on type 'SCLAlertView';
 did you mean to use a value of type 'SCLAlertView' instead?

I moved the method UIColorFromRGB from the class to outside the class.... and now I just see that there must have been some weird merge conflict that reverted that part. Let me redo a PR that fixes it.

Issues will be fixed when #185 is merged


wip: Implement Go to Type Definition

Motivation

=> #1500
Commit summary
I recommend reviewing by commit.

Implement test harness for TypeDefAssertion (2b98bac6c)
It ended up growing support to assert that one
textDocument/typeDefinition request respond with multiple locs (for
cases like to go type definition on a union type).

Boilerplate for new TypeDefinition handler (cd2ba2b42)

Implement handleTextDocumentTypeDefinition (63b9b936e)
Note that we never try to add a loc for untyped, because it wiil try to
jump to T::Utils::RuntimeProfiled.

Add some tests (fafab8684)
I did some testing locally to check that adding deleting things that I
would expect to make this test fail actually made it fail.

Test plan

See included automated tests.

cc @jvilk-stripe still wip but just in case you're curious
I'll probably ping you tomorrow to see how far we should go to implement this. The bare essentials work right now.

I'm happy to back down if you have a strong opinion. The rest of the PR is super great!

Go to Type Definition in # typed: false (doesn't work for certain entities, but works on others).

Good suggestion, added a test. It uncovered a bug in DefLocSaver, fixed in 564cf3b.

What's an AppliedType? Is that typecase exercised?

That's a generic type. I forgot to add tests for generics. I added some.
Unrelated: one thing which i couldn't write a test for was this:
# typed: true

class A; end
#     ^ type-def: A

class TestClass
  a = T.let(nil, T.nilable(A))
  puts a
  #    ^ type: A
end

because the definition for NilClass is in an RBI.
I can sort of fake it: if I add
class NilClass; end

to the top of the file, it will register an addition loc to the definition of NilClass, and since this loc is not in an RBI, it takes precedence as the "canonical" loc:
https://github.com/sorbet/sorbet/blob/6b3d747e33215f093ec50e0d1a6d82486dab2f62/core/Symbols.cc#L1144-L1148
but that seems like a hack, and that's not going to be what the editor does.
How do you test jump to definition for things defined in the standard library?


Which model to install and one modal that won't install

Hello Tommi and all
I finally got some models to work by deleting a sqlite file as you suggested
I'd now like to know the difference between Tatoeba and OPUS models and one the model in the middle of the attached image fails to install every time.

I also lost all my regexes as I ended up deleting old models to make space to "start again" and later realized too late that my regexes were probably in a deleted old model and not kept somewhere else. Perhaps there needs to be a warning about this in the help pages.
As you saw in my emails, I've urged memoQ to reconsider bundling Opus like it bundles other TM engines. If you could commit to helping them, maybe they will do this finally

Hi,
Tatoeba models are newer, and should work better (but that might not always be the case). A rule of thumb you can use is to always select the newest opus+bt model, but any of those models should have fairly comparable quality. You can check some metrics of the models from here:
https://opus.nlpl.eu/dashboard/index.php?test=flores101-devtest&scoreslang=swe-eng
Unfortunately the UI of the dashboard is a bit complex (it's designed by academics for academics). There are other metrics against other test sets available as well. If you are wondering about that gmq model that is the best performing, that can be used with OPUS-CAT, but it's much slower and can't be finetuned, so stick to the other models.
I'm not sure why the middle model installation fails, could be because the download was interrupted at some point. Try deleting the model directory in %opuscat%/models/swe-eng and reinstalling.
As for your regexes, they might still exist, they are stored externally from the models in %opuscat%/editrules. Note that the edit rule collections need to have global-collection set to true in the .yml file if you want to add them to a model in the user interface.
Thanks for contacting memoQ, I appreciate it. They might not choose to bundle OPUS-CAT with memoQ (and I can understand it would require work from them, due to ensuring security etc.), but just having the plugin included as standard would be great.

Hello Tommi
After several attempts, and deletions as you recommended, it suddenly worked and I was able to install the Tatoeba modal
As for my regexes though, they are all lost as I had deleted entire folders to start afresh.


Fixed Microdata ItemList position : index starts to 1 and not 0

Questions
Answers

Description?
Fixed Microdata ItemList position : index starts to 1 and not 0, backport of https://github.com/PrestaShop/PrestaShop/pull/27814

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/28151.

How to test?
See issue

Possible impacts?
SEO JSON LD metadatas

Thanks @NeOMakinG & @AureRita


Add: class "MessageBoards", relevant migrations file and test class

In the file models.py:
add the class "MessageBoards", and add relevant fields and relevant methods.
In migrations directory:
create file "0003_messageBoards_test_data", and add test data. (see page 41; Task 5: Adding test data; in ToolIntroductionGit.pdf)
In the file tests.py
add the class "TestMessageBoards", and add relevant test methods. (see page 18 in Automated Software Test (B6).pdf for example)

Resolved #65 #64


Play notification sound on repeat for Alarm

In my app I want to setup an alarm. using Alarm Manager, but notification sound gets played only once. How can I repeat the sound until user takes action on the notification.
Code snippet
 async function onCreateTriggerNotification(sound) {
    // Create a time-based trigger
    const trigger: TimestampTrigger = {
      type: TriggerType.TIMESTAMP,
      timestamp: Date.now() + 10000,  //fires after 10 seconds of opening app
      alarmManager: {
        allowWhileIdle: true,
      },
    };

    // Create a trigger notification
    await notifee.createTriggerNotification(
      {
        title: 'Entry Daily Reminder',
        body: 'Add you entry',
        android: {
          channelId: 'Alarm',
          category: AndroidCategory.ALARM,
          importance: AndroidImportance.HIGH,
          fullScreenAction: {
            id: 'alarm',
            mainComponent: 'custom-component',
          },
          pressAction: {
            id: 'default',
            launchActivity: 'default',
            launchActivityFlags: [AndroidLaunchActivityFlag.SINGLE_TOP],
          },
          sound,
          // asForegroundService: true,
        },
      },
      trigger,
    );
  }

 React.useEffect(() => {
    NotificationSounds.getNotifications('alarm').then(async (soundList) => {
      const sound = await getDefaultSound('alarm');
     // gives default alarm sound file

      notifee
        .createChannel({
          id: 'Alarm',
          name: 'Alarm',
          importance: AndroidImportance.HIGH,
          sound,
        })
        .then(() => {
          onCreateTriggerNotification(sound);
        });
    });
  }, []);

Hi there! This is not currently possible in the library, alarm apps are actually a bit special with regards to how they work, and how sound works. Why? Because by default notifications have very restricted sounds, no longer than 30 seconds are allowed on iOS and on both platforms there are multiple reasons the sound may not be played (do-not-disturb, other things playing, vibrate mode, speaker volume low, app is killed) etc.
Reading up a bit, there are workarounds for all of these things but it's a substantial bit of extra code on both platforms in order to "loop" the sound and/or make absolutely 100% sure the sound plays, like a user would expect if it were really a "wake me up for work" level of reliability they needed vs "my friend liked my post" type notification.
On iOS you would set an trigger notification like we already do here, but if it was a special "alarm" type (which we do not currently support or have plans to support) You need to set up a full AVManager instance and configure it very carefully https://stackoverflow.com/questions/50644978/how-are-some-alarm-apps-such-as-alarmy-able-to-play-a-sound-on-iphone-when-the-a
On Android you would want to set up a foreground service type notification from here and use that to play media - a combination of activities which would be considered a "looping alarm sound" that the system should let run until the user interacts with the notification but not a package of functionality that we have under an API that makes it easy to access
There are some "alarm" type react-native packages or media player applications that are available for react-native, if you combine those with notifee for scheduling you may able to achieve the desired result of truly reliable looping alarm-type behavior, or if you investigated the link above for iOS (and similar for android if you search) and PR here we could collaborate here and see about having a true alarm type persistent notification / continuous-until-dismissed / works-even-in-DnN-or-vibrate type API

Hi @mikehardy
You suggestion can work and I agree going this way I will have to add lot more extra code coz I am not going to use all other features of that another library.
I know little bit about android development. I can somehow make repeat alarm work for notifee as well if I research. But There is one more use case of mine which notifee is not fulfilling right now.  I want to write custom notification UI using XML using notification info provided by this library.
Our design requirements for notification alarm UI are lot more different than provided by this library.
Can you please guide me if I can use use custom xml code for notification.
This video can be inspiration
https://www.youtube.com/watch?v=axcdnRAcqLw

I don't believe you can
I'm not sure this package is a good fit for your use case unfortunately, unless you make the effort to develop several sizable features to handle them. They might fit in this package, we could collaborate if you posted a rough sketch of implementation / API design / file structure needed to handle them, but the effort to produce the working code would be your responsibility I think unless others were also interested and able to contribute

I think there's a flag we can use for repeating the audio, suggested here that will make the audio loop. So closing in favor of that issue.
Regarding, the xml code can you create a new issue if needed but as Mike Hardy mentioned, it's not a good fit for this library


Add docs

Codecov Report

Merging #12 (8e9a55f) into master (04c3a76) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          257       257
=========================================
  Hits           257       257

Impacted Files
Coverage Δ

src/polynomial.jl
100.00% <ø> (ø)

src/representation.jl
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c3a76...8e9a55f. Read the comment docs.


Update setup.py

re: #4
cc @jadeshi: Does this work for you?

Adding "# coding: latin-1" to the top of the original file seems to fix it for me.


The idea is to prevent loading everything on startup.
Before, this extension would activate on VSCode startup always.
Now, it only activates:

if you open a .sql file
if you run any SQL: commands

Reproduction:

make an empty folder: mkdir ~/example
Run extension, open folder ~/example
Run Developer: Show Running Extensions
Before: vscode-database should be loaded
After: vscode-daabase should not be loaded

PS: how do you normally test this package? Starting it with "Run Extension" causes all extensions to be disabled, even on master.

A good idea! Thanks for the pull request!
What if you have saved connections?
The extension should run if you have saved connections?  Can we set the event depending on the settings?

PS: how do you normally test this package? Starting it with "Run Extension" causes all extensions to be disabled, even on master.

Unfortunately. I started creating this extension when VSCode was still in beta.
My knowledge only allowed me to write in ES5 without test. 😄 I am currently trying to fix errors from the past. I migrated to typescript and started writing tests.

A good idea! Thanks for the pull request!
What if you have saved connections?
The extension should run if you have saved connections. Can we set the event depending on the settings?

Hm, we might be out of luck then. There doesn't seem to be a way to listen on settings.json in activation events. Typically activation events are for extensions that only run on certain file types or only contribute commands; not extensions that do stuff on startup.
I'm not too familiar with this extension - when vscode-database connects, does it open a tab or do something user-visible? If not, then my above change would simply make it connect as soon as the user first tried to run a query.

PS: how do you normally test this package? Starting it with "Run Extension" causes all extensions to be disabled, even on master.

Unfortunately, it only tests manual (F5). I started creating this extension when VSCode was still in beta.
My knowledge only allowed me to write in ES5 without test.  I am currently trying to fix errors from the past. I migrated to typescript and started writing tests.

Ah yeah, I'm also fine with testing with F5, but what I meant was that when I press F5, the window that opens up has all extensions except vscode-database disabled:

I was wondering if you had the same behavior. But it's not too hard to work around.


change dir to untar cli in ansible

cc @dubeejw @houshengbo

@csantanapr @dubeejw I have already sumitted another PR and merged. now waiting for the result.

@csantanapr @dubeejw My fix in openwhisk does not resolve the issue, it still cannot find the path .

@csantanapr could you add a description on what is failing in this case?

staled PR


MultipleModal  problem, the second modal behind the first modal

when the second modal content is too long to need window scrollbar , the second modal position become behind to the first modal.

Can you please provide a test-case, you can fork the JSFiddle in the readme. This will help in debugging.

http://jsfiddle.net/suziwen/vpg04zj0/4/

i have a same problem. but not behind, it appear below the first so i need to scroll down to view it.


Add support for datastream rollover api

Implement manual datastream rollover API

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ptasz3k Thanks for taking the time to submit a PR. This API is already implemented and available under Indices.Rollover and Indices.RolloverAsync.


Can't download or view images from posts with many images (gallery) on Pixiv .

Bug description
Batch download ignores posts with many images on Pixiv.
Search can see these posts, but can't open them - clicking on preview for this post in search -> an empty tab without images opens and writes "Pixiv - No images"
Steps to reproduce

Login to pixiv with grabber (used 7.6.2)
Enter any user:user_number in search tab, find one with post with many images
try to click on post with many images or try to download it
get message "Pixiv - No images" in new tab where should be few images, batch download of posts with many images will be ignored

Expected behavior
search tab should open page with inner images from post,
batch download should download all images from all posts
Context
log output when trying to open post with many images in search tab (I replaced page id by 'xxxxxxxx'):
[18:12:10.626][Info] Loading results...
[18:12:10.626][Info] [www.pixiv.net][Json] Loading page https://public-api.secure.pixiv.net/v1/works/xxxxxxxx.json?image_sizes=large
[18:12:11.751][Warning] [Qt][qt.network.monitor] Could not find the interface for the local address.
[18:12:12.699][Info] [www.pixiv.net][Json] Receiving page https://public-api.secure.pixiv.net/v1/works/xxxxxxxx.json?image_sizes=large
[18:12:12.700][Error] [www.pixiv.net][Json] Loading error: Error transferring https://public-api.secure.pixiv.net/v1/works/xxxxxxxx.json?image_sizes=large - server replied: Not Found (203)
[18:12:12.700][Warning] [www.pixiv.net] No valid source of the site returned result.

System information

OS: [e.g. Windows 10]
Grabber version: 7.6.2

No any answer for several months about broken galleries download.
Well, it seems author drops support for pixiv.

Indeed, seems like they deprecated the "public-api" endpoint recently, which was used to fetch galleries and image details.
I'll push an update to use the "app-api" endpoint instead.

Should be fixed in Nightly by cc882aa35548f697ba0849a28b281f6912ba0bdb, seems like I put the duplicate issue in the commit message instead of this one 🤔

This fix works, thanx. I compiled this to js and replaced gallery and parse blocks in pixiv model.js

Posts with multiple images work now in 7.7.0, but the images downloaded are 1200px resizes, not the originals, this doesn't happen for individual images (the ones that are not part of a post with multiple images).


[WALLPAPERS] Add data/ folder

This PR will add data/ folder with actual data files.
These data files will be stored into %SystemRoot%\Web\Wallpaper.
The Rapps data:
[Section]
Name = ReactOS Standard Wallpapers
Version = 2
License = CC BY
Description = The standard wallpaper collection for ReactOS
Category = 16
URLSite = https://github.com/reactos/wallpapers/
URLDownload = https://github.com/reactos/wallpapers/archive/refs/heads/main.zip
Installer = Generate
; SHA1 = ???
; SizeBytes = ???

[Generate]
Files = wallpapers-main\data\*
Dir = %SystemRoot%\Web\Wallpaper
Lnk = !

OK.

@learn-more Help me?

What is the question?

Can you merge this PR?

Can you merge this PR?

You should be able to do this yourself now.

Thank you.


Change browser touch events to not be passive

This adds {prevent: false} to touchstart and touchmove events that may call e.preventDefault().  Otherwise, Chrome will throw an error.
This has to be tested with a touchscreen and I am unable to test it.
Open a monaco-editor.
Scroll through the editor as well as the minimap.
Errors should not be thrown, and scrolling should still work properly.
This PR fixes #1382.

Thank you!


Add links to official packages.

Adds links and descriptions about the official CodeIgniter packages for greater discoverability.

What about https://github.com/codeigniter4/cache ?

Cache... and DevKit, Tasks, Coding Standard?

Tasks doesn't have a release yet so I didn't include that one.
I had forgotten about Cache, honestly. I can try to squeeze some time in today to update, otherwise it won't be until late tonight, which would probably be too late to include.

https://github.com/cijagani/awesome-codeigniter4

Coding Standard and DevKit are packages for developing CI4.
It is not surprising if these are not on this page.
But it would be nice to have Cache.

I managed to steal the last few minutes of my work day to add  Cache, Devkit, and the Coding Standard.  While I'm not sure they qualify as the type of packages I was originally thinking of, they can be beneficial to users, especially the devkit.


Conditional execution of rules

I think this would be a major feature request, but it would enable htransformation to replace and supersede several other plugins.
Just the check for existence or-non-existence of a specific header alone would allow rules that replace most of the plugins that comb through the existing headers that were added by external loadbalancers, to set the real client IP.
Just this example here would consolidate the "X-Real-IP" header, no matter if it is already set, or gets its value from "X-From-CDN" or from "X-Original-IP".
- Rule:
  Name: 'first cdn'
  If:
    - 'exists x-from-cdn'
    - 'not-exists X-Real-IP'
  Type: 'Rename'
  Header: 'x-from-cdn'
  Value: 'X-Real-IP'
- Rule:
  Name: 'second cdn'
  If:
    - 'exists x-original-ip'
    - 'not-exists X-Real-IP'
  Type: 'Rename'
  Header: 'x-original-ip'
  Value: 'X-Real-IP'

Conditions in the `If:' list would have to be evaluated one after another, and only if they are all true, the header manipulation is executed.

Hello @gumbo2k,
Thanks for your interest in this Traefik Plugin!
I can see the use case for this, but I feel it would be a bad workaround (performance wise) as creating multiple middlewares on different routers. This would look something like:
- traefik.http.routers.router1.rule: Header(`x-from-cdn`) && !Header(`x-real-ip`)
- traefik.http.routers.router1.middlewares: htransformation-rename-first
- traefik.http.routers.router2.rule: Header(`x-from-cdn`) && !Header(`x-real-ip`)
- traefik.http.routers.router2.middlewares: htransformation-rename-second

But I get that this is kind of cumbersome to configure.


Revert "Implement framerate (#122)"

This reverts commit ad643cd36455dd54953f34669ed89f0eed5c7cd3.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/1063/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/31759/ started

https://jenkins.code.rdkcentral.com/job/build-component/68658/ started.

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/4555/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/4556/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/4559/

'['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [SUCCESS]
Video Accelerator Home Screen Test [SUCCESS]
Video Accelerator VOD Video Detection Test [SUCCESS]
HLS video streaming using gst-launch uri=aamp [SUCCESS]
HLS Video Streaming using aamp-cli [SUCCESS]
DASH Video Streaming using aamp-cli [SUCCESS]
Video local (H264) using gst-play-1.0 [SUCCESS]
HYB - Video Test [FAILURE]
Video Accelerator Home Screen Test [SUCCESS]
Video Accelerator VOD Video Detection Test [FAILURE]
HLS video streaming using gst-launch uri=aamp [SUCCESS]
HLS Video Streaming using aamp-cli [SUCCESS]
DASH Video Streaming using aamp-cli [SUCCESS]
Video local (H264) using gst-play-1.0 [SUCCESS]
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/1195/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/4576/


fix package versioning

Codecov Report
Patch and project coverage have no change.

Comparison is base (b9cad57) 76.82% compared to head (8df018b) 76.82%.

:exclamation: Current head 8df018b differs from pull request most recent head 24ca580. Consider uploading reports for the commit 24ca580 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   76.82%   76.82%
=======================================
  Files          11       11
  Lines        1342     1342
=======================================
  Hits         1031     1031
  Misses        311      311

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Why was the Buffer dependency added?

I hadn't seen the introduction on Buffer because it was hidden inside the JSDoc API PR #108, which I assumed was only adding documentation.
The buffer npm package is 2000 lines of JavaScript for a total of 26kB. Previously, esptool-js worked without it. @brianignacio5 can you explain why esptool-js needs this dependency?
Size and impact of bundling buffer npm package (via bundlephobia)

Hi @balloob Sorry for late reply. There is a reference to atob and btoa which is supported in browsers but not in NodeJS environments.
I'm not sure of how to handle both cases since some users want to extend this tool for more environments (#117). I figured using a separated Buffer library might offer for both cases. Any ideas of a lighter solution for this ?


Do not assert on cross-site CustomExternalObject thrown as exception objects as they don't need marshalling

If a cross-site CEO is thrown as an exception we will not marshall it as it is an external type. But in the debugEval this cause an access denied error later when the script context is validated for the same. But we never marshall CEO's, so updating the checks accordingly.

LGTM

@dotnet-bot test please

@dotnet-bot test please

@dotnet-bot test Windows x86_test please

@dotnet-bot test please

@dotnet-bot test  Windows x86_debug test please

@dotnet-bot test please

@dotnet-bot test this please

@dotnet-bot test this please

@dotnet-bot test this please

Merge please! Crawler is suffering.

@EdMaurer I am not able to merge it as Jenkin is having issues for last two days. The Pre-Merge signing page is not loading

The sign off page loaded for me so I signed off- go ahead and merge


It is a bit unclear what "registering your ASDK installation with Azure" refers to

The sentence "If you've previously registered your ASDK installation with Azure, you should remove the registration resource before redeploying the ASDK" is somewhat unclear.
Have I?
My ASDK re-installation just failed at step 60.190.197:
"Invoke-EceAction : Type 'Configure' of Role 'Gallery' raised an exception: ERROR during Directory Tenant Registration: A task was canceled."
I certainly didn't cancel anything, but that's a different story. And I never did a manual registration of my ASDK in Azure. If I didn't, is it registered? There certainly are references to Azure Stack in the portal when I log in - but that must be something the installer did - I didn't.
So - have I registered my ASDK installation with Azure? How would I know if I have?
The point is: The registration that this is referring to, is that something that the asdk-installer.ps1 (or any subscript that the script calls) will do? Or is it a registration that you will have to perform manually after the ASDK is successfully installed?
The following simple sentence would clear it all up: "If you have not performed the manual registration outlined in the next step, you have not registered your ASDK with Azure, and you may skip this step" or similar.
On the other hand, if that is a lie, it would really make a mess of things ;)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a3bed670-b412-74b4-f2ea-48023250a718
Version Independent ID: 109c728d-522d-71d1-04cf-146624e5e4e2
Content: Redeploy the ASDK - Azure Stack Development Kit (ASDK)
Content Source: azure-stack/asdk/asdk-redeploy.md
Service: azure-stack
Sub-service: azure-stack-hub-asdk
GitHub Login: @PatAltimore
Microsoft Alias: patricka

@bjoernf73  Thank you for pointing this out . We will investigate and update the thread.

#reassign @sethmanheim

Please contact Microsoft Support for ASDK issues, as we cannot verify the information currently.


spark decision tree

What algorithm is used in spark decision tree (is ID3, C4.5 or CART)?

Can one of the admins verify this patch?

hi ,could somebody help to rely this question?
thanks very much!

Could you please ask this question on the user list or on StackOverflow? Opening a PR is not an avenue for questions. Also, could you please close this PR? Thanks!

Could you pleade close this @zhuangxue ?


fix(tests): Drops flaky openresty-luajit test

#75

Urgh. Hilariously, the failing test had apparently blocked me from pushing a previous approved commit, the cache change, to master. Removed that + added the suggested comment.


add wildcard pattern again

@zain-sohail this seems now to want to do the right thing, but always times out. Ideas?

Seems to me that in the monitored dependency files, there's also docs/requirements.txt. So that could be why it takes so long and times out.
We can see if removing it helps. I think readthedocs can also work without the requirements.txt, from what I see online. Just probably needs to be configured properly.


Use clang modules in cinterop instead of headers

This PR is based on #31 and should be reviewed and merged after #31.
This change makes cinterop support usage of clang modules in Objective-C headers.
This is required to be able to use any modern apple framework (including UIKit, AVFoundation, etc).
Basically, any Objective-C header containing @import directive requires modules to be enabled.
This change seems to be backwards compatible since we are generating cinterops for our own builds which are guaranteed to be clang modules.
Also, I've added iosX64 and iosSimulatorArm64 to list of targets which are required sdk path to be provided to swift build.
Finally, I've fixed all configuration cache issues.
Also, this fixes issue https://github.com/ttypic/swift-klib-plugin/issues/25

@IlyaGulya awesome! does this fix #25?

@IlyaGulya awesome! does this fix #25?

Yes, it should be fixed. 🙂
Noted this in the description of PR, thanks!

@IlyaGulya are we able to tag this release?

@IlyaGulya are we able to tag this release?

@IlyaGulya are we able to tag this release?

Sure, I'll try to do it later this week.

@markst this is available in latest release: https://github.com/ttypic/swift-klib-plugin/releases/tag/v0.6.2


remove unused import statement in keras dir

The build started failing after merging this. It's probably unrelated, but I'm reverting until we figure it out.

Still failing. Almost certainly Travis being  broken.


Time.at(Float) is quite slow

Version of Ruby: ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]

When consuming a message from Kafka, a Time object is built using Time.at(Float):
https://github.com/zendesk/ruby-kafka/blob/6ccbb0f61ea174812814c51b6948ea3f279ffb46/lib/kafka/protocol/message.rb#L100
This seems innocuous but it's actually pretty slow, because internally Time.at will try to get an exact number for that Float to not lose any nanoseconds due to Float errors, which creates a Rational (which is not a cheap conversion) and potentially some large heap-allocated Integers, etc.
A trivial benchmark on MRI 2.6,
benchmark { Time.at(232132.123) } shows ~1.7Mips,
while benchmark { Time.at(232132, 123_000) } shows ~6Mips.
Similar difference on TruffleRuby.
Something like Time.at(timestamp / 1000, timestamp % 1000 * 1000) should work.
The Float version is also slightly inaccurate:
Time.at(232132.123).nsec # => 122999999
cc @fxn

Somewhat related: https://bugs.ruby-lang.org/issues/16470
One more reason to not use Time.at(Float) basically.

@eregon thanks! Would you be able to do a PR? I’m too busy these days for most dev work, unfortunately.

@dash Was this closed for inactivity?

@dash Was this closed for inactivity?

Yup. Feel free to open a PR.

Yup. Feel free to open a PR.


IDSYS-007

RFID Scanning
Upon Time-IN - Play Time In sound
Resource: Download
Upon Time-OUT - Play Time Out Sound
Resource: Download

no audio resource


Register package

It would be nice if you could register this package. Currently it is not possible to add it as a dependency.

Sure - I'll register it since it's getting wider usage. Might have to wait until the weekend.
In the meantime, you should be able to add it to the Project.toml via ]add https://github.com/jwscook/NelderMead.jl.git

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/70808
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.2 -m "<description of version>" 9891e66acfe54e051418ff30a35c89f801cac74c
git push origin v0.3.2

Also, note the warning: This looks like a new registration that registers version 0.3.2.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

The package has been registered :)


Offline mode for iseries or VE migration

Is your feature request related to a problem? Please describe.
Being able to use the tool to migrate configurations in the offline mode not only for VELOS or rseries but also to VE or iseries
Describe the solution you'd like
When you work with the tool and want to migrate between old TMOS versions and new versions the offline mode doesnt work for VE or iseries devices, neither its possible to choose the TMOS release you would like to go
it would be nice to be able to work in the offline mode in that way, otherwise you need the new devices connected/installed to start working on the migration tasks
Tks

@fjl80 could you give more details about the failing offline scenario?
What is the source and destination version? Normally you should be able to use the application from old version to a newer one (11.x to 14.x as an example).

Hey,
When you work in offline mode you cant choose the destination version neither platform series . You can only choose Velos or rSeries (what about VEs or iseries)
@.***
This customer I am working with needs to go from 5250V to i5800, so I cant do it in offline mode in my lab.
As far as I have checked in my lab (I don’t have a i5800) with a VE is that if I work in online mode I can migrate the config to a VE (the same config from the 5250V), so the journeys app recognize the VE and version correctly.
Is it clear my ask?
Tks
[signature_3965122646]https://f5.com/
Francisco Lahoz
M +34 687535293
From: zahajkiewicz @.>
Reply to: f5devcentral/f5-journeys @.>
Date: Friday, 1 April 2022 at 09:31
To: f5devcentral/f5-journeys @.>
Cc: Francisco Lahoz @.>, Mention @.***>
Subject: Re: [f5devcentral/f5-journeys] Offline mode for iseries or VE migration (Issue #47)
EXTERNAL MAIL: @.***
@fjl80https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffjl80&data=04|01|f.lahoz%40f5.com|2fc1335f24054631cf0608da13b1af06|dd3dfd2f6a3b40d19be0bf8327d81c50|0|0|637843951137930135|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pEB2qF0N3h2UB0p6Rj3LziOA3Sek%2Bt24kLkfLX3z%2BJM%3D&reserved=0 could you give more details about the failing offline scenario?
What is the source and destination version? Normally you should be able to use the application from old version to a newer one (11.x to 14.x as an example).
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ff5devcentral%2Ff5-journeys%2Fissues%2F47%23issuecomment-1085533313&data=04|01|f.lahoz%40f5.com|2fc1335f24054631cf0608da13b1af06|dd3dfd2f6a3b40d19be0bf8327d81c50|0|0|637843951137930135|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=RQyzNfNvyGFRNxONgBLEIhcEvy%2FS%2B08Ef1HwUepgY%2BI%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANAQMBTBRISDT3UWDJNHHL3VC2Q5ZANCNFSM5SHZOM2Q&data=04|01|f.lahoz%40f5.com|2fc1335f24054631cf0608da13b1af06|dd3dfd2f6a3b40d19be0bf8327d81c50|0|0|637843951137930135|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=WjK3jchQ4jg8KhO3A2QJq4E0BT%2BYW9AG9XS00%2BBhiUE%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Yes, that is true. Currently Journeys App does not support offline migrations other than to VELOS tenants.
There is a plan to add support for offline migrations to a different versions/platforms.

Filed internal Jira SOLUTIONS-5766.

Just adding my voice to supporting Offline mode for BIG-IP Classic.  As is, Journeys is still an excellent tool!


Morris Traversal algorithm for Binary Search Tree

💥 Proposal
I would like to add the code for the morris traversal algorithm for BST in c++ language. Please assign this issue to me[GSSOC'21].
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign

/assign

Closing this due to inactivity since last 21 days. Thank you for your valuable time.😊


No config.json available to upload for Tectonic Installer

Issue Report Template
Tectonic Version
1.5.6
Environment
Bare-Metal
What hardware/cloud provider/hypervisor is being used with Tectonic?
Dell Poweredge
Expected Behavior
config.json available in my account
Actual Behavior
No config.json available. Only Kuberenetes secrete yaml file which Tectonic installer will not accept
Reproduction Steps

...Create matchbox provisioning node and start Tectonic installer
...Load CoreOS license an config.json. No config.json available to download.

Other Information
This could be because I had a CoreOS Tectonic Starter license last year but added the Tectonic 10 node license and dont have access to the json file to upload.
Feature Request
NA
Environment
What hardware/cloud provider/hypervisor is being used with Tectonic?
NA
Desired Feature
NA
Other Information
NA

@khanattlab Do you see the dockercfg tab? This is the one you need to use:

We are working on removing the Kubernetes specific secret, as we don't end up requiring that version in the installer. I understand its name is confusing.
Let me know if that pull secret works for you.

Thanks - the dockercfg does work. I kept trying the Kubernetes Secret. thank you

Sorry for the confusion, glad it worked for you!


OUTPUT feature does not work at all.

Hello, first of all you have made a really good tool.
I'm starting a simple scan on the application and I want to view the results in a file. But this feature never really works.
When I use it as below, it doesn't save anything in the result.txt file.
scan4all -l httpx.txt -v -o result.txt
OUTPUT:
   -o, -output string  file to write output to (optional)
   -json               write output in JSON lines format
   -csv                write output in csv format

I am using the following command to display the results. Sometimes this command doesn't quite work.
scan4all -l httpx.txt -v |tee scan4all.txt

It is recommended to build an es server to receive it. It is too busy at present. This repair will take some time, or come back and try our pro version for you.

It is recommended to build an es server to receive it. =>How exactly does this happen? Can you provide some information?

download and use latest
https://github.com/hktalent/scan4all/releases

Thank you for the answer. It's like it's not working. I am using the tee command.


Prepare for release v1.1.2

Signed-off-by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

test-missed-k8s

test-upstream-k8s


Expose the attributes options in pymee's HomeeAttributes class.

An Attribute in Homee can have options.
The currently known are:

can_observe (list of attribute types)
observes (list ob attribute IDs)
observed_by (list ob attribute IDs)
history (dict {'day': ,'week': ,'month': , 'stepped': } )
automations (list of automation names)
reverse_control_ui (bool)

At least the last one is useful for other applications acessing Homee. So it is desired to expose them in pymee.
There are two possible approaches:
Option 1
Iterate over the options and convert the dict to an object:
def __init__(self, attributeOptions):
    for key, value in attributeOptions.items():
        setattr(self, key, value)

pro
con

- just a few lines of code
- using code must check for presence of options to avoid errors

- only options that are present are added
- intellisense or similiar tools are not available.

- will also add currently unknown entries

Option 2
Add getters for the known possible options and return empty values if they don't exist.
def __init__(self, attributeOptions):
    self._data = attributeOptions

@property
def can_observe(self) -> list:
    if "can_observe" in self._data:
        return self._data["can_observe"]
...

pro
con

- parsing options error handling can be done here
- longer code

- intellisense or similar tools available for applications using pymee
- unknown options will be ignored

- every attribute has all options, but with empty values

@FreshlyBrewedCode: Since it is your project, I want to get your opinion on which approach to use before I do a pull request

Example code of an Attribute with options:
{
  'id': 38,
  'node_id': 3,
  'instance': 0,
  'minimum': 0,
  'maximum': 4, // 0 = Closed; 1 = Open; 2 = Stop; 3 = Closing; 4 = Opening
  'current_value': 1.0,
  'target_value': 1.0,
  'last_value': 4.0,
  'unit': 'n%2Fa',
  'step_value': 1.0,
  'editable': 1,
  'type': 135, // UP_DOWN
  'state': 1,
  'last_changed':<PHONE_NUMBER>,
  'changed_by': 1,
  'changed_by_id': 0,
  'based_on': 1,
  'data': '',
  'name': '',
  'options': {
      'can_observe': [300],
      'observes': [75],
      'reverse_control_ui': True,
      'automations': ['toggle']
}

Thanks for the detailed explanation.
So from my point of view HomeAttribute (or really any thing in model.py) is only a convenience wrapper around the data returned by the API. It is really just used to "strong type" the data so that it is easier to work with (intelisense etc.).
Which is why I would personally go with your Option 2. I would add a new class HomeeAttributeOptions that strong types all the options and return it from HomeeAttribute:
@property
def options(self) -> HomeeAttributeOptions:
    return HomeeAttributeOptions(self._data['options'])

If an option is missing users could still access them via the raw data.

Thank you for the quick reply.
Most interestingly the last part is exaclty my approach - this is how it looks like in my draft:
@property
def options(self) -> HomeeAttributeOptions:
    """The options collection of the attribute. Optional, not on every attribute."""
    return HomeeAttributeOptions(self._data["options"])

;-)


Variable replacement not working in 'jobs' the same as 'deployment' jobs.

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: bug
Enter Task Name: Docker@2
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises? Azure Pipelines

Agent - Hosted or Private: Microsoft Hosted Agent

Issue Description
I have a simple task like this:
    - task: Docker@2
      displayName: Login to Docker Hub
      inputs:
        command: login
        containerRegistry: '$(dockerRegistry)'

If I define variable dockerRegistry within the pipeline file (inside variables block) then it works fine.
However, if I import it from Pipeline Library like this:
variables:
  - group: 'Release'

then it does not work, the error message was "There was a resource authorization issue: "The pipeline is not valid. Job Build_and_Publish: Step Docker1 input containerRegistry references service connection $(dockerRegistry) which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz."
I tried some simple echo and confirmed that echo $(containerRegistry) (and other variables in the same libary) works (i.e. the printed value is correct).
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Could you attach a snippet of your yamls?

Hi @ds-ms ,
Below is the working yaml, after workaround:
trigger:
  branches:
    include:
    - master
  paths:
    exclude:
    - docs/*

variables:
- group: 'Release'

stages:
- stage: Build
  displayName: Build and Publish Docker image
  pool:
    vmImage: 'ubuntu-latest'
  jobs:
  - job: Build
    displayName: Build and Publish Docker image
    # variables:
    # - group: 'Release'
    steps:
    - task: Docker@2
      displayName: Login to Docker Hub
      inputs:
        command: login
        containerRegistry: '$(dockerRegistry)'
    - task: Docker@2
      displayName: Build and Publish image
      inputs:
        command: buildAndPush
        dockerfile: '$(Build.SourcesDirectory)/Dockerfile'
        containerRegistry: '$(dockerRegistry)'
        repository: '$(dockerRepository)'
        tags: |
          $(Build.BuildId)

I have to move the variables to the top level to make it work. If I put variables block under stages or jobs I got the error "There was a resource authorization issue: "The pipeline is not valid. Job Build_and_Publish: Step Docker1 input containerRegistry references service connection $(dockerRegistry) which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz."
Best regards,

Overall the issue I see is, the variable being available when the replacement happens. If the dockerRegistry variable is available in context during the job orchestration, it would replace it with the value you're looking for. But in your case the value was not being parsed. So instead it was looking for a service connection named $(dockerRegistry) which didn't exist so it failed.
I'd like to understand more on what you meant by if I import it from Pipeline Library are you talking about a variable group here? If yes, then this is probably expected, replacing service connections is something which is not supported from variable groups. You'd probably notice this behaviour across all the other tasks, not just docker. I'll reconfirm this and get back to you.

@ds-ms, yes I was talking about variable group (which was created via pipelie's libary page).
If I put variables block at top level it works, if I put it inside stages or `jobs it does not.

One more thing, I have another task as the following:
- stage: Deploy
  displayName: Deploy App Service
  dependsOn: Build
  pool:
    vmImage: 'ubuntu-latest'
  jobs:
  - deployment: Deploy
    displayName: Deploy App Service from Container
    environment: dev
    variables:
    - group: Release
    strategy:
      runOnce:
        deploy:
          steps:
          - task: AzureWebAppContainer@1
            displayName: 'Azure Web App on Container Deploy'
            inputs:
              azureSubscription: '$(azureSubscription)'
              appName: '$(appName)'
              containers: '$(dockerRepository):$(Build.BuildId)'

Task AzureWebAppContainer@1 works well with the variables block at jobs level.

That is weird. The orchestrator, I believe doesn't do any biased decisions like that. If it works for one task, it's expected to work with everything else.
One difference I noticed is you're using Docker task in a regular job and AzureWebContainer task under a deployment stage. Could you validate if this is occurring for you under just job or deployment job under a stage?

Hi @ds-ms,
I think I kind of understand the error. I attached the error screenshot:

The error with Docker@2 task happens before the pipeline was able to ever run any task. I think this check is a type of pre-run check. And for some reasons at this pre-run check step, the top level variables block is evaluated while the inner variables block is not.
I did another test: I hard-code the part containerRegistry: 'actual-connector-name-here' to make it run. And inside the job, I added another step to echo variables and I can confirm that all variables are populated correctly from variable group.
So in summary, I guess is that with Docker@2 task this check happens before the pipeline runs, hence only the top-level variables block is evaluated.
Once the pre-check step passes, the variables group works as expected (hence the task AzureWebAppContainer@1 works without issue).
Hope it helps.

Like I mentioned it's probably not a task thing.
I'm guessing it's a difference in behaviour between a job and deployment job type under a stage. If you're able to repro this issue under both the cases.. I'll engage the right team to help with this issue 😄

Hi @ds-ms
Your guess is correct! I change the deployment job to normal job like this:
- stage: Deploy
  displayName: Deploy App Service
  pool:
    vmImage: 'ubuntu-latest'
  jobs:
  - job: Deploy
    displayName: Deploy App Service with Docker image
    variables:
    - group: 'Release'
    steps:
      - task: AzureWebAppContainer@1
        displayName: 'Azure Web App on Container Deploy'
        inputs:
          azureSubscription: '$(azureSubscription)'
          appName: '$(appName)'
          containers: '$(dockerRepository):$(Build.BuildId)'

And I got this error message:

So the issue now is why the variables group block is not consistently evaluated? I expect it to work without putting the variables block at top-level.

@zachariahcox there seems to be an issue with parsing variables from a variable group in job layer. Is this an expected behaviour?

@ds-ms @zachariahcox
This bug does affects other tasks as well, like AzureRmWebAppDeployment@4.
Variables don't get resolved (default is empty string) and task fails with error message:
##[error]Error: Input required: WebAppName
I'm using deployment job, trying to migrate to YAML CD.

I found the the same error, and I wish someone help to solve it. Thanks

I found a solution. You can save the acr connection as a variable in a variable group. And if you want to choose different variable groups depending on some conditions, you can do it at the top level. So the containerRegistry will treat it correctly.
For example,
trigger:
- master

variables:
  # Agent VM image name
  - name: vmImageName
    value: ubuntu-latest
  - name: imageRepository
    value: xxx
  - name: dockerfilePath
    value: xxx
  - name: buildContextPath
    value: xxx
  - ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/master') }}:
    - group: abc123
  - ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/prod') }}:
    - group: xyz456

I have a similar issue:
jobs:
- job: BuildSE${{ upper(parameters.env) }}
  variables:
    - group: myapp-ssh-key-${{ lower(parameters.env) }}
    - group: myapp-docker-${{ lower(parameters.env) }}
    - group: myapp-frontend-${{ lower(parameters.env) }}
    - group: myapp-terraform-${{ lower(parameters.env) }}
    - group: myapp-terraform-backend-${{ lower(parameters.env) }}
  steps:
  - template: container-template.yml
    parameters:
        env: ${{ upper(parameters.env) }}
        country: SE

container-template.yml
parameters:
    - name: country
      type: string
      default: ''

    - name: env
      type: string
      default: ''

steps:
- task: Docker@2
  displayName: 'Build container for ${{ upper(parameters.country) }} - ${{ upper(parameters.env) }}'
  inputs:
    containerRegistry: $(containerRegistry)
    repository: 'myapp/${{ lower(parameters.country) }}'
    command: 'build'
    Dockerfile: '**/Dockerfile'
    arguments: --build-arg APP_ENV=${{ lower(parameters.env) }} --build-arg COUNTRY_CODE=${{ lower(parameters.country) }} --build-arg BACKEND_URL=$(apim-public-api) --build-arg SUBSCRIPTION_KEY=$(apim-subscription-key) --build-arg APPLICATION_INSIGHTS_KEY=$(ApplicationInsightsKey)

- task: Docker@2
  condition: not(startswith(variables['Build.SourceBranch'], 'refs/pull'))
  displayName: Push container for ${{ upper(parameters.country) }} - ${{ upper(parameters.env) }}
  inputs:
    containerRegistry: $(containerRegistry)
    repository: 'myapp/${{ lower(parameters.country) }}'
    command: 'push'
    Dockerfile: '**/Dockerfile'

There was a resource authorization issue: "The pipeline is not valid. Job BuildSEDEV: Step Docker1 input containerRegistry references service connection $(containerRegistry) which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz.,Job BuildSEDEV: Step Docker2 input containerRegistry references service connection $(containerRegistry) which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz."

Thank you all for the investigation :)
An identical issue occurs for variables from a template in a jobs section (and works for deployment type):
jobs:
- job: build_and_push_image
  variables:
    - template: variables.yml@repo
  steps:
...
   - task: Docker@1
      displayName: 'Build Docker Image'
      inputs:
        containerregistrytype: 'Azure Container Registry'
        azureSubscriptionEndpoint: $(ACRSubscriptionEndpoint)
        azureContainerRegistry: $(ACR)
        command: 'Build an image'
        dockerFile: 'Dockerfile'
        imageName: '$(ACR)/$(ImageName):$(Build.BuildNumber)'

Inside jobs it does not resolve (but imageName does because it is outside initial validation):

Moving template: variables.yml@repo to the top level it works, as reported by @btnguyen2k.

@ds-ms: I has been a while since there was any activity here. Can you confirm if MS will fix the issue because it is a bug, or we must settle for the (top level) work-around?

Thank you all for the investigation :)
An identical issue occurs for variables from a template in a jobs section (and works for deployment type):
jobs:
- job: build_and_push_image
  variables:
    - template: variables.yml@repo
  steps:
...
   - task: Docker@1
      displayName: 'Build Docker Image'
      inputs:
        containerregistrytype: 'Azure Container Registry'
        azureSubscriptionEndpoint: $(ACRSubscriptionEndpoint)
        azureContainerRegistry: $(ACR)
        command: 'Build an image'
        dockerFile: 'Dockerfile'
        imageName: '$(ACR)/$(ImageName):$(Build.BuildNumber)'

Inside jobs it does not resolve (but imageName does because it is outside initial validation):

Moving template: variables.yml@repo to the top level it works, as reported by @btnguyen2k.

@ds-ms: I has been a while since there was any activity here. Can you confirm if MS will fix the issue because it is a bug, or we must settle for the (top level) work-around?

Same issue here: variabele ServiceConnectionK8SDEFAULT from a template file is not substituted in the pre run check
- stage: DeployTST
  condition: and(succeeded())
  displayName: Deploy TEST
  dependsOn: DeployDev
  pool:
    vmImage: $(LinuxVmImageName)
  variables:
    - template: pipelines/configurations/mfiles/for-mfiles-pipelines-tst.yml@sharedTemplatesRepository
    - template: pipelines/configurations/for-all-pipelines-tst.yml@sharedTemplatesRepository
  jobs:
  - job: Deploy_AAD_Identity_Validation_TEST
    displayName: Deploy AAD Identity Validation on TEST
    steps:
    - template: pipelines/aadpodidentity/aadpodidentity-deploy-template.yml@sharedTemplatesRepository
      parameters:
        kubernetesServiceEndpoint: $(ServiceConnectionK8SDEFAULT)
        kubernetesServiceConnection: $(ServiceConnection-K8S)
        AADPodValidationName: $(AADPodValidationName)
        namespace: $(Namespace)

and the template file:
variables:
  # Azure DevOps Service Connection
  ServiceConnectionK8SDEFAULT: BDOBE-T-AKS-bdobe-ns-default

Any workaround ?
The ${{ variables.XXX }} doesn't work in our case :/

Any workaround ?
The ${{ variables.XXX }} doesn't work in our case :/

Did you check out my above comment? You can save the variables in the group and import it.

Any workaround ?
The ${{ variables.XXX }} doesn't work in our case :/

Did you check out my above comment? You can save the variables in the group and import it.

Yes, i used this one for the moment but my stage is inside a template and i wanted it to have the variables too... Not to load the variables group from the top of the pipeline :(

    variables:
      ${{ if eq(variables['Build.SourceBranchName'], 'develop') }}:
        dockerRegistry: "Nexus-nonprod"
        dockerRegistryDomain: "docker-nonprod.url"
      ${{ if or(eq(variables['Build.SourceBranchName'], 'master'), eq(variables['Build.SourceBranchName'], 'release'), eq(variables['Build.SourceBranchName'], 'release/*')) }}:
        dockerRegistry: "Nexus-prod"
        dockerRegistryDomain: "docker.url"

This still appears to be an issue - and as per the comment from @sonnehansen it is an issue when wanting to use a (dynamically-selected) variable group in a template (or variable template etc):
release-pipeline.yml file:
stages:
- stage: UAT
  jobs:
  - template: build-template.yml@pipelineTemplates
    parameters:
      variable_group: my-uat-vg

build-template.yml file:
parameters:
- name: variable_group
  type: string

jobs:
  variables:
  - group: ${{ parameters.variable_group }}
  - name: something_else
    value: 'value here'

  strategy:
    runOnce:
      deploy:
        steps:
...

Attempting to refer to a variable in the variable group as part of the steps results in the errors posted earlier eg "references $(foo) which was not found"
@ds-ms @zachariahcox it would be good to get an update from Microsoft on this - if any fix is planned etc. Or if not, what the recommended workaround is, and official documentation around this if possible.

Did anyone find a solution or workaround for this ?

If I remember correctly it worked for me when using the syntax ${{ variables['NameOfVariable.WithDotNotation'] }}
Please see Runtime expression syntax, $(var) is processed runtime before a task executes, but the service connection is checked before that.
Good luck!

How is this still an issue? omg

So what is the solution here?

If I remember correctly it worked for me when using the syntax ${{ variables['NameOfVariable.WithDotNotation'] }}
Please see Runtime expression syntax, $(var) is processed runtime before a task executes, but the service connection is checked before that.
Sometimes moving the variable group top level is not ideal, as the connection might be different per stage.
Good luck!

Thank you . That helped

Though I was able to use the ${{ variables['NameOfVariable.WithDotNotation'] }} workaround for azureSubscription input on a AzureFunctionApp,  the same workaround doesn't work with job.environment. I can't get any of the syntaxes to work there.
The workaround syntax isn't documented on https://learn.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch

Same issue.  Variable groups listed at the job deployment level are not working.
When I look at the pipeline logs, the azure-pipelines-expanded.yaml file has those job deployment level variables deleted - so I assume that is why the variable expansion doesn't happen.
Hey Microsoft-related people, @davidstaheli @bryanmacfarlane @prawalagarwal @mvvsubbu or anyone, do you think you could kindly somehow get some engagement from Microsoft on this almost 3 year bug that contradicts the documentation on how variables work at different levels?
It is a pretty fundamental issue...
https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/variables?view=azure-pipelines#remarks

Ok this is odd... hours later I re-ran the pipeline and it worked.
Now the deployment level variables are no longer being deleted in the azure-pipelines-expanded.yaml file.
Nothing really changed on my end...

@channeladam I am not working on Azure DevOps anymore. I will let other team members help you with this issue if it is still continuing.

I figured out a way how to use different variable groups for different stages, even if the variable groups share the same variable names (with different values). I still don't understand why Microsoft hasn't fixed this...
main.yaml:
variables:
- group: VARIABLE_GROUP_A
- group: VARIABLE_GROUP_B

stages:
- stage: BUILD_DEPLOY_GROUP_A
  displayName: 'Build/Deploy A'
  variables:
  - group: VARIABLE_GROUP_A

jobs:
  - template: deploy-environment.yml
    parameters:
      environment: GROUP_A

- stage: BUILD_DEPLOY_GROUP_B
  displayName: 'Build/Deploy B'
  variables:
  - group: VARIABLE_GROUP_B

jobs:
  - template: deploy-environment.yml
    parameters:
      environment: GROUP_B

deploy-environment.yaml:
parameters:
- name: environment
  type: string
  default: ""

jobs:
- deployment: Deploy
  dependsOn: Build
  pool:
    vmImage: 'ubuntu-latest'
  environment: ${{ parameters.environment }}

  strategy:
    runOnce:
      deploy:
        steps:
...
Now you are able to use the variables from selected variable group from main.yaml.

Somehow different variable groups only work with attribute "- deployment" within jobs. Don't ask me why. As a workaround I used "- deployment" also for my build steps.
Microsoft should offer different variable groups for different stages...
Hopefully this helps somebody.


brave label appNewVersion

in appNewVersion, xpath call requires -e switch

it does not: https://github.com/Installomator/Installomator/blob/6b047bcd771780973040166e30387185eb9ea643/fragments/functions.sh#L209

oh hey, would you look at that. I'll have to dig further to see why it wasn't getting the version.