Custom hover: allow to move the mouse over it

Refs: https://github.com/microsoft/vscode/issues/112490
I noticed this behavior both on Windows and macOS

Open the Pull Request view or some other view that uses the custom hover
Use the mouse to show the custom hover by hovering over some tree item for example
Try to move the mouse over the custom hover -> it hides immediatly

We should allow the user to move the mouse over the custom hover just like the native hover allows it. The reason for this is among others using Zoom programs for accessibility. Since users want to move the mouse over the hover so the zoom would show the content of the hover.
Destilled from https://github.com/microsoft/vscode/issues/112220 fyi @purplegranite

We cannot do this by default, it would be incredibly annoying. Note that in the tree view it acts more like a title tooltip which is intentionally excluded from assistive technology. If anything a keybinding that matches the editor to show and focus the hover could work for the active tree item:

We cannot do this by default, it would be incredibly annoying. Note that in the tree view it acts more like a title tooltip which is intentionally excluded from assistive technology. If anything a keybinding that matches the editor to show and focus the hover could work for the active tree item:

@Tyriar are you seriously saying that an inconvenience for others trumps accessibility for all?  I'm utterly shocked at that!!

@Tyriar are you seriously saying that an inconvenience for others trumps accessibility for all?  I'm utterly shocked at that!!

@PurpleGranite I'm saying we've already hit this issue before, so we need to consider another way to surface the hover to users.
If we wanted to stick to purely mouse interaction to access it, I saw a pretty nifty solution to this problem in the game Crusader Kings III which allows many levels of nesting tooltips. When you hover something, a spinner shows in the top right of the hover for ~2 seconds or so and when it's done you can mouse over the hover without it disappearing.

@PurpleGranite I'm saying we've already hit this issue before, so we need to consider another way to surface the hover to users.
If we wanted to stick to purely mouse interaction to access it, I saw a pretty nifty solution to this problem in the game Crusader Kings III which allows many levels of nesting tooltips. When you hover something, a spinner shows in the top right of the hover for ~2 seconds or so and when it's done you can mouse over the hover without it disappearing.

@Tyriar I like the idea to have the Show Hover use the same shortcut for showing the custom hover.
I like the game idea, but showing the spinner might be a bit distracting. For startes can't we just do it without the spinner, so after a timeout of ~2 seconds mouse would not cause it to hide
@PurpleGranite we appreciate the feedback, however let's try to be concise and reduce the drama if possible :)

@Tyriar I like the idea to have the Show Hover use the same shortcut for showing the custom hover.
I like the game idea, but showing the spinner might be a bit distracting. For startes can't we just do it without the spinner, so after a timeout of ~2 seconds mouse would not cause it to hide
@PurpleGranite we appreciate the feedback, however let's try to be concise and reduce the drama if possible :)

@isidorn the game also changes the border of the tooltip after the time has passed, we could do this fairly subtly to give a visual indication.

@isidorn the game also changes the border of the tooltip after the time has passed, we could do this fairly subtly to give a visual indication.

@Tyriar I like that idea a lot! So the border would show that the hover has become "stable".
Alternative idea: just allow the mouse to move over it when screen reader is detected. Since I believe that some of the zoom software is detected as a screen reader.

@Tyriar I like that idea a lot! So the border would show that the hover has become "stable".
Alternative idea: just allow the mouse to move over it when screen reader is detected. Since I believe that some of the zoom software is detected as a screen reader.

@isidorn are we also targeting users that have difficulty with using a keyboard, would that be covered by the alt approach?
An extra benefit of the stable tooltip would be enabling selecting and copying text from the tooltip.

@isidorn are we also targeting users that have difficulty with using a keyboard, would that be covered by the alt approach?
An extra benefit of the stable tooltip would be enabling selecting and copying text from the tooltip.

@Tyriar I'd be much more in favour of the mechanism in the game you mention - however it would be important to ensure that any form of spinner or status indicator was not hidden by the mouse cursor - most users of magnifiers will have a cursor significantly larger than standard.  Testing with actual assistive software with real-world configurations will be key to ensure it works as expected.
If the border changes colour, that's fine too, though subtle isn't a good idea - again, many folk with sight impairments won't pick up on that change even when using assistive tools.  Colour selection would need to account for folk with various colour-differentiation issues as well, or at least be specified within the theme configuration somehow.
Overall though, that sounds like a much better approach than requiring a custom keybind to an obscure function that folk likely haven't discovered in the app.
@isidorn having consistently seen accessibility issues dismissed on this project and several others from Microsoft, I've become more than just a little distressed by the general approach ... after literally an entire lifetime of blocks being put in my way, my approach is very much a learned behaviour - I've been taught by those who don't take accessibility seriously that the only way to be heard is to shout long and loud.  I'm genuinely sorry you don't like that - but the only way to change that is in your hands, not mine!  Take an accessibility first approach to development and a significantly more positive approach towards accessibility issues across the entire team and demonstrate that openly!

@Tyriar I'd be much more in favour of the mechanism in the game you mention - however it would be important to ensure that any form of spinner or status indicator was not hidden by the mouse cursor - most users of magnifiers will have a cursor significantly larger than standard.  Testing with actual assistive software with real-world configurations will be key to ensure it works as expected.
If the border changes colour, that's fine too, though subtle isn't a good idea - again, many folk with sight impairments won't pick up on that change even when using assistive tools.  Colour selection would need to account for folk with various colour-differentiation issues as well, or at least be specified within the theme configuration somehow.
Overall though, that sounds like a much better approach than requiring a custom keybind to an obscure function that folk likely haven't discovered in the app.
@isidorn having consistently seen accessibility issues dismissed on this project and several others from Microsoft, I've become more than just a little distressed by the general approach ... after literally an entire lifetime of blocks being put in my way, my approach is very much a learned behaviour - I've been taught by those who don't take accessibility seriously that the only way to be heard is to shout long and loud.  I'm genuinely sorry you don't like that - but the only way to change that is in your hands, not mine!  Take an accessibility first approach to development and a significantly more positive approach towards accessibility issues across the entire team and demonstrate that openly!

Perhaps an additional 1px outline on the hover would work better than changing the color, so the border gets a little larger/bolder after the timeout.
Before:

After:

I think it would be great to also solve the problem of not being able to copy the text of the tooltip which can be frustrating sometimes.

Perhaps an additional 1px outline on the hover would work better than changing the color, so the border gets a little larger/bolder after the timeout.
Before:

After:

I think it would be great to also solve the problem of not being able to copy the text of the tooltip which can be frustrating sometimes.

Tentatively assigning to February, don't want to rush in for Jan so it can get some testing/discussion.

Tentatively assigning to February, don't want to rush in for Jan so it can get some testing/discussion.

@Tyriar makes sense to do this next milestone so we get feedback.
A thicker border looks great. I would just be interested in how the transition looks, from regular to thicker and if it is not distrurbing.
So far I have not heard feedback from users that use the keyboard. So for now let's go with the "stable" hover and see how it feels.
Also having the same keybinding shortcut makes sense in general so let's also do that.

@Tyriar makes sense to do this next milestone so we get feedback.
A thicker border looks great. I would just be interested in how the transition looks, from regular to thicker and if it is not distrurbing.
So far I have not heard feedback from users that use the keyboard. So for now let's go with the "stable" hover and see how it feels.
Also having the same keybinding shortcut makes sense in general so let's also do that.

@Tyriar changing the border size does look like a good approach.  Would it be possible - at some point - to make that a configurable option, including specifying the number of pixels the border increases by?
That would give people who don't like it the option to turn it off, and would give people who use magnification tools like I do the option to increase the border by a larger (and therefore more easily discernible) amount too - I'm thinking an extra 3 or 4 pixels - which would definitely be too jarring for most users, but invaluable to magnifier users.

@Tyriar changing the border size does look like a good approach.  Would it be possible - at some point - to make that a configurable option, including specifying the number of pixels the border increases by?
That would give people who don't like it the option to turn it off, and would give people who use magnification tools like I do the option to increase the border by a larger (and therefore more easily discernible) amount too - I'm thinking an extra 3 or 4 pixels - which would definitely be too jarring for most users, but invaluable to magnifier users.

@PurpleGranite seems reasonable, I'll bring this up in the UX sync next week and see what the rest of the team thinks.

@PurpleGranite seems reasonable, I'll bring this up in the UX sync next week and see what the rest of the team thinks.

It would be nice to also support holding down alt or ctrl or something, and then you can immediate hover over it with the mouse.

Notes from UX sync:

Would be nice to copy text in tooltip
Holding down a key we could do it automatically
Could also be useful for the editor hover
General favor for adding
Setting to drive this - also apply the timeout rule to hovers with links?

i have this as issue, because can't use the links provided on description tooltips/hovers (in some cases they would save a lot of time) .
1 of the best solutions would be to keep the hover if mouse is moved right to it, and hide immediately if its moved outside/{to another direction} . for example, the hover opens upside of the cursor : if you move the cursor 1-2px downside, the tooltip closes, otherwise it'll stay open until you move the cursor outside of it ;. it also may hide on click onto the background of it .

i have this as issue, because can't use the links provided on description tooltips/hovers (in some cases they would save a lot of time) .
1 of the best solutions is to make the tooltip stay if cursor is moved right to it, and hide immediately if its moved outside/{to another direction} . for example, the tooltip opens upside of the cursor : if you move the cursor 1-3px downside, the tooltip closes, otherwise it'll stay open until you move the cursor outside of it ;. it also may be made to hide on click onto the background of it .
ScreenRecorderProject2.mp4
(prepositioning the cursor and using editor.action.showHover isn't the best workaround)

I am having the same issues seen here. I can't hover over any tooltips in vscode as they just instantly disappear when my mouse moves. Even if I use the 'Show hover' feature, when I move the mouse they disappear. I have tried disabling all extensions.

I encountered this again since we now show links in the extensions view using the custom hover. And these links can not be clicked upon.
@Tyriar since we are using the custom hover in more and more places does it make sense to look into this issue?
fyi @sandy081

There is an issue already tracking it - https://github.com/microsoft/vscode/issues/128998

Hi @isidorn @Tyriar  , the accessibility team wants us to give fix date estimate on this ? Do you have an approx.. estimate when would it be fixed ?

@setaskin there is no eta as it's unplanned and on the backlog right now.

@Tyriar , I understand , but for the  scorecard snapshot they absolutely want us to submit a date before September 22nd. Even a rough estimate would work.

GitHubTags:#A11yMAS;#A11yTCS;#Win32;#DesktopApp;#A11y_VSCode;#WCAG1.4.13;#A11ySev2;#VisualStudioCode-Win32-Apr2021;#Benchmark;#Visual Studio Code Client;#Hover;#A11yWCAG2.1;

Optimistically assigning this to December just so we do not loose track of this.
@Tyriar feel free to push out to January if you do not find time. Thanks!

WIP looks great for large hovers:

It is triggered by waiting for 3 seconds currently or by hitting ctrl (or cmd for mac). Hovering shows the standard hover style, clicking will unlock it:

Doesn't look great for smaller ones right now, but I want to avoid changing the hover size when it gets locked:

Will bring to UX sync.

Next round of feedback:

The ux feels a bit cumbersome because the user has to manage the UI, would like for it to just work automatically without indications
If the hover is a single line, you might want it to go away right away, and if it’s a rich hover that may take more time you might want it to stick around
Should this locking mechanism be done in editor hovers too? otherwise it feels a bit inconsistent
Pinning might be a better metaphor than locking?

I'm going to experiment with a more temporary state where ctrl would temporary lock the hover. That way you don't need to manage the state, just release ctrl. As for the editor hover point, that would be blocked on https://github.com/microsoft/vscode/issues/138617

Also it feels weird in the terminal where you hover, then ctrl+click the link and the locked hover remains.

This doesn't look great:

@Tyriar Can you list the behavior/issues being tackled here?
Because for editor hovers, already allow the mouse to move over it and click links, etc. And for tree view hovers, the same is true if they contain links.
Now there are of course issues with both of the above. For example, the editor hover is sometime a little jumpy. It sometimes renders a little to high (or off right to left) and then moves closer to the cursor, which might be causing some of the phantom closes I see when moving the mouse into the hover.

And on tree views, the challenge is not getting in the way of the mouse pointer -- which is typically very good if the tooltip can render in the desired position (e.g. doesn't come up to an edge).
Good (arrow points to the cursor position):

Not great (arrow points to the cursor position):

The tree view hovers are tricky as there is contention between moving the mouse to a different item vs moving into the hover. It seems like if the hover were always out of the way of the mouse moving vertically, but also allowing for diagonal movement into the hover it would help. Or maybe the hovers have threshold where if they've been visible for a very short time and the mouse moves close or over them) they will still hide, but if they've been visible longer they will be stickier. A shortcut key, like ctrl / alt might help here too (to make the hover sticky), though it requires more user interaction.
Alternatively, maybe rich hovers on tree items are always positioned outside the view itself (so it doesn't cover other items), and with that there could be more affordance to getting the mouse over to the hover (without it going away). Though that might be too awkward, as the mouse naturally will be further away from the hover.

Focus has clearly been lost on the original issue, which is specifically how the existing hovers - different depending on what you’re hovering over - do not work well at all for users of magnifier-based accessibility tools.  While it’s understandable that changes need to work for everyone not using such tools, can the Microsoft guys please take the focus here back to solving the accessibility issue and clean-up for everyone else later.
It would help significantly if those commenting would also spend at least one full working day coding using VS Code with a full-screen magnifier set to at least 3.5x zoom - you simply cannot understand the magnitude nor scope of the originally reported issue until you do!

@PurpleGranite @isidorn maybe I'm missing something, but using Magnifier on Windows 11 doesn't treat the native hover any differently from the custom hover. It still doesn't allow you to hover it and doesn't guarantee it will show up in the magnifier viewport?

@eamodio the main goal is allowing the user to mouse over any hover, regardless of its content, while not annoying users and regressions on problems that we've already fixed. This includes hovers that intentionally are lightweight like status bar items, activity bar, panels, etc. The hover position is a good point but we already do this, just not on the right sidebar it seems - can you create an issue to track this as I think we just need to invert the offset in the other direction?
Improving magnifiers is the other thing which admittedly I don't completely understand the problem as mentioned above.

@Tyriar I just double checked and you are correct, the native hover on Windwos behaves the same way as our custom hover with magnifiers.
The only hover that works well is the Editor one that allows mouse to be moved over it.
I also believe that the magnifier problem will go away as soon as we have a good mechanism for moving the mouse over the hover. So I suggest we focus on that first as we have so far.

Latest plan = will not be tackled in April. We will probably look into this in May. We will know more end of April once we create the May iteration plan.

Update: I merged in the alt to lock the hover idea, the main changes that have happened recently are the removal of the lock icon and improved reliability/hiding of the hover when alt is released.

@Tyriar this is great, thanks a lot 👏
I have pushed an update to the docs to make sure this is mentioned https://github.com/microsoft/vscode-docs/commit/cf616737f1a32fb99b32483db87cbb176c72b6cd
@setaskin try it out with VS Code insiders next week and let us know what you think. Thanks

thank you very much @Tyriar and @isidorn. I will test it next week :)


Add tag with status code to http responses

I think this change fixes #45 , sending the http response to the after request function so the tag will be added here

I've replicated the substance of this PR into #61, to work around merge conflicts, and also add some code cleanup. I'm trying to work through a minimum of updates and changes before pushing out a final 2.0.0 release that will provide compatibility with recent Flask and Python releases, prior to sunsetting this project altogether.


Added 3D shape Cuboid with variable length, breadth, height and faces to include

Added 3D shape Cuboid with variable length, breadth, height and faces to include

Added 3D shape Cuboid with variable length, breadth, height and faces to include.

Motivation

A frequently used shape - Cuboid - will add to the usefulness of manim.
Just the way manim already has Rectangle and Square, having Cuboid along with the already-present Cube should be useful.
Explanation for Changes

These changes will let the user have another useful shape - Cuboid - at their disposal.

Documentation Reference

Testing Status

Successful. A cuboid was added using non-default arguments.
Further Comments

Checklist

[X] I have read the Contributing Guidelines
[X] I have written a descriptive PR title (see top of PR template for examples)
[X] I have written a changelog entry for the PR or deem it unnecessary
[X] My new functions/classes either have a docstring or are private
[X] My new functions/classes have tests added and (optional) examples in the docs
[X] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

Hi @manisar2, thank you for your PR! Actually, the unfortunately misnamed Prism already does this. However, there is consensus in the Discord to rewrite Cuboid and Cube to inherit from Polyhedron. Since Polyhedron takes in a list of vertex coordinates and face lists, I think it makes sense to make Cuboid inherit from Polyhedron and Cube to inherit from Cuboid. Can you rewrite your PR to focus on this instead?

Thanks for the info. Understood and noted.
I'll join discord and bring myself on the same page as others in this regard.
I'm not sure if it should be me closing this PR, or one of the approvers does that.
Please do as appropriate.
I'll start looking into the rewrite(s) you mentioned, and will definitely be happy to contribute in my capacity.
Thanks for maintaining this wonderful tool!

I don't think we need to close this PR since the changes are roughly in the same vein anyways, unless you want to.

No I would not 🙂.

I'll mark this PR as a draft until it is ready to be reviewed.

@behackl Sorry for the dumb question as a first time contributor, but is there an action item on me (PR author) for making this PR Ready for review?
I see this button - Ready for review - and am not sure if I should click on it.
I had already done all my checks before creating the PR, so it is ready from my side thought.

@behackl Sorry for the dumb question as a first time contributor, but is there an action item on me (PR author) for making this PR Ready for review?
I see this button - Ready for review - and am not sure if I should click on it.
I had already done all my checks before creating the PR, so it is ready from my side though.

The discussion you had with @Darylgolden above read like you were looking into changing the proposed implementation (which made sense to me given that Prism already has this functionality).
Can you and/or @Darylgolden clarify what the result of your discussion above is/was?

Yep, the result is that @manisar2 should change their implementation. From the commit history however, it doesn't seem like you've done so. Perhaps you've forgotten to commit/push?

Ok, got it.
No, I haven't changed the implementation yet.
Thanks for the clarification.

@manisar2 Hi, what's the status of this PR? Are you still interested in doing this?

Hi, I got caught up in some urgent work, and it doesn't seem I'll be off the hook for next couple of months.
I'm very much interested, but if the delay is not acceptable, please advise on what I should do of this in-draft PR.
Please accept my apologies for leaving it in limbo.

I think switching the implementation of cubes and cuboids is fairly important, and if you're not able to work on it for a "couple of months", it's pretty likely that I/someone else will make the changes before then. Therefore, I'll close this PR now; if you find the time to work on it before anyone else has, then feel free to reopen it. Thank you for your interest in contributing to Manim!

Thanks much for your time and advice, and once again for your contribution to manim!


Fix find_packages() in setup.py

Can we also require python < 3.10? pylibjpeg seems to have a problem with python 3.10, fails on execution due to a circular import.


How to preserve the original sound

Hello, I would like to ask a question.
I want to mute the audio when human voice is detected, and keep the input sound unchanged and output it as it is when no human voice is detected.
I tried modifying the example given in the readme file. I have put the code below
source.connect(vad)

Modified to
source.connect(vad).connect(audioContext.destination);

Then I tried to add the following code at the entrance of the process method in vad-audio-worklet.js
     for (let channel = 0; channel < this.outputChannelCount; channel++) {
       outputs[0][channel].set(inputs[0][channel]);
     }

However, I found that there would be a lot of noise. How to simply replace the process method with the following code so that there will be no noise
  process(inputs, outputs, parameters) {
    for (let channel = 0; channel < this.outputChannelCount; channel++) {
      outputs[0][channel].set(inputs[0][channel]);
    }
    return true
  }

I would like to ask, how can I fix this issue? I want to achieve the function of muting when detecting human voice, and outputting the original audio without noise when there is no human voice.
Thank you very much for developing this project. Looking forward to your reply.

Mh, return true at the beginning of process() will actualy disable the vad algorithm and only pass through the audio data. All code after the return statement will not be executed.
So this means the noise gets introduced by the algorithm, I guess.? I wonder how, since the values get copied over into the buffer this.buffer.push(...inputs[0][0]); to prevent that they get altered.
Can you post a minimal working example that produces the noise?

@thurti Currently, I have made modifications to the code and found that by placing the following code above if (this.buffer.length < this.frame_size) {, the noise issue is resolved. Therefore, I speculate that the noise is caused by the buffer not being full yet.
 for (let channel = 0; channel < 1; channel++) {
      outputs[0][channel].set(inputs[0][channel]);
    }

@thurti But I encountered a new problem, which is that when detecting human voice and preparing to emit the speech event, I hope to modify all outputs to 0 in order to achieve a mute effect. The code is as follows:
    if (this.is_speech_frame_counter > 4 && !this.last_command_was_speech) {
      for (let channel = 0; channel < inputs[0].length; channel++) {
        inputs[0][channel].fill(0);
      }
      if (this.debug) {
        this.post("speech", { signal: sfm_sum_ari / frequencyData.length });
      } else {
        this.post("speech");
      }

      this.last_command_was_speech = true;
    }

However, I found that it doesn't seem to work. When playing the video, I can still hear the voices inside.

@thurti  But I encountered a new problem. I want to fill all the data in the output with 0 when detecting human voice, that is, when the speech event is about to occur, in order to achieve silence effect. However, it doesn't work at all in reality and I can still hear voices.
    if (this.is_speech_frame_counter > 4 && !this.last_command_was_speech) {
      for (let channel = 0; channel < 1; channel++) {
        outputs[0][channel].fill(0);
      }
      if (this.debug) {
        this.post("speech", { signal: sfm_sum_ari / frequencyData.length });
      } else {
        this.post("speech");
      }

      this.last_command_was_speech = true;
    }

@thurti I think it may be wrong to use the vad method to remove human voices from videos in a browser, because looking at the code, the vad method seems to work like a recorder, needing to play out some of the human voice before detecting whether there is human voice in the audio. Because it's recording, that's why there's that buffer, which doesn't seem to match my needs. However, I think you have more experience in web audio and still want to ask for advice. Is there any way or idea to remove human voices from videos in a browser?

You're right. The algorithm needs some time before it can decide if the audio is voice. The buffer is 10ms (1 frame) and the algorithm needs several of these frames to decide.
Your code above doesn't work because this vad works more like a state change. The algorithm checks each 10ms frame and only if 5 consecutive frames are detected as speech the "state" switches to "speech" (until silence gets detected again). You can try to check for this.last_command_was_speech and then set your audio to zero at the top of the process() method.
 if (this.last_command_was_speech) {
      for (let channel = 0; channel < 1; channel++) {
        outputs[0][channel].fill(0);
      }
 }

But this "state" switches very often. And zero out samples may lead to audible clicks. You propably need to implement an additional buffer for your audio to smooth things out. Keep the last n samples and decide what to do when you get a "state" change from the vad. I've done smth similar here, but I'm actually not sure if this is a good solution to this :D .
Apart from that this vad algorithm isn't the best tbh. It is good enough for my use case, but in tests I often got false (speech) positives. So even if you get this to work the result may not be reliable.
Maybe have a look at https://github.com/ricky0123/vad . I've only tried the demo but it seems pretty good. And it also got a lot of options like prepend audio and you also get the detected speech as array buffer.

@thurti Thank you very much for your response. I took a look at https://github.com/ricky0123/vad and found that it is also not suitable for my use case because it uses onnx at the lower level. I briefly looked at Onnx, tensorFlow.js, and transformer.js, and found that they all require asynchronous execution, while audioworkletprocessor requires a synchronous interface.
It seems that this problem is difficult to solve, so I am considering giving up...

Yes, it's definitely more complicated than it looks at first glance.
I will add some more information in the readme about what to expect from this vad implementation.


Try checking out ci_matching_branch for gzdev

Code copied from release-tools#572 with the magic ${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}} copied from drake_vendor's CI configuration to return the current branch for both GitHub workflow Push and Pull-Request events.
Testing with https://github.com/ignitionrobotics/sdformat/pull/780 since it needs the ign-cmake2 2.10.0~pre1 prerelease and a matching gzdev branch:

https://github.com/ignition-tooling/gzdev/tree/ci_matching_branch/use-ign-cmake-10

Note that the focal workflows are failing on that PR. I'll update the focal branch once this is merged.

LGTM. Can we keep the --depth 1?

it's complicated to switch branches when you clone with --depth 1, so I removed it here and also in https://github.com/ignition-tooling/release-tools/pull/572
I don't think gzdev is particularly large, so it seems like a small cost


Fails When Client Doesn't Send Status Request

I've been recently testing making a simple server pinger in rust and found this program.
When testing it, I found a discrepancy with the Nochian server where Nochian servers allow for a status request to be omitted (see the relevent wiki section), while Honepot doesn't like it when this request is not present, causing the following error.
2024-10-14T15:35:23.368Z ERROR [mc_honeypot::server] Connection reset by peer (os error 104)
Honeypot also seems to wait until the client sends the ping request (only waiting for the status request), while Nochian servers do.
The Wiki states that:

Note that Notchian servers will for unknown reasons wait to receive the following Ping Request packet for 30 seconds before timing out and sending Response.

but Honeypot doesn't do this atm.
For viewing the packet I send out to replicate this behavior, view the code at https://gitlab.com/coolGi/mc-server-pinger/-/blob/eb13c7d8ddbedeb5e44e2989e436010fe5d875a6/src/pinger.rs#L170

First of all, thank you very much for pointing out these issue!
As for the server failing to respond when the status request is omitted, this is now fixed. The honeypot now responds with the status and pong response, regardless of whether the status request has been sent or not.
I don't really understand the second point you mention. Could you elaborate on what the expected behavior is and how the honeypots behavior differs from it? Should there be a timeout of 30 seconds if the ping request gets sent after a delay?

Thanks for the fix!
The 30-second timeout was mainly to stop people from attempting to figure out whether the server is honeypot or not. Any (sane) server scanner wouldn't be setting their timeout at 30 seconds and probably have a better way (and quicker) of checking, so it honestly doesn't really matter.
Just a suggestion in case :)
If the client sends the handshake and status request without sending the ping request, then the server will respond back with the status response after 30 seconds, rather than instantly when the ping request is sent.
Feel free to close it if you don't want to add it. And thanks again for the quick fix!

Yeah I see, I don't really feel like fixing it atm, but I'll leave this open since its a valid issue


rename 'Function env' to 'Function spec'

Describe your changes

Calling this an "environment" clashes with our Environment domain term.
We also had this dataclass in the docs

Backward/forward compatibility checks

[x] Client+Server: this change is compatible with old servers
[x] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Nice, makes sense.
Why do we have public docs for this btw? Is this something users would ever interact with directly?

Oh I see you're also making it private, so we won't going forward?

Yep, it'll be hidden

Makes sense. Sort of confusing how most of our objects look private on declaration but then become public when they get synchronicity wrapped. Different issue though :)


[Enhancement] Categories

See: https://os-link-biodotpe.vercel.app/ as an example, I think this was made using littlelink, I feel like itd be good idea for littlelink-server.

Just will put a workaround how it can be done in current config with no development
just add CUSTOM_BUTTON

CUSTOM_BUTTON_COLOR=#1C00ff00 (no color will apply)
CUSTOM_BUTTON_ICON=#
CUSTOM_BUTTON_URL=#

butten order as you want it
thay will give you what you needed

Thanks for the creative workaround!


Dispenser tests

Fixes #193
Fixes: #515
Changes proposed in this PR:

Fixing handleDeactivate dispenser
Dispenser tests:

initialize Dispenser and datatoken class
Deploying an NFT with ERC20
Test all DT Fields after deploying
Make user1 minter
Create dispenser
Deactivates dispenser
Activates exchange
User2 gets datatokens from the dispenser
Owner withdraws all of the datatokens
Updates allowed swapper

fix conflict

Done


Apply Futurize stage 1 across the repository.

This PR does the following (Apply Futurize stage 1):

Applies futurize stage 1 across the whole repository.

Definition of Done Checklist

[x] Code meets our python style guidelines?
[x] Unit tested (coded, passed, included)?
[x] Requested at least 2 reviewers?
JIRA: MT-738

PR blocked by https://github.com/ska-sa/tango-simlib/pull/105


unify http plaintext tls tests

What does this PR do?
Runs most of the HTTP tests for plaintext and TLS

Motivation
Expand the coverage of tests for go-tls

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge

/remove

/merge

/remove


Deeper exploration into error handling

From a review meeting with Website team:

Ergonomics around error handling and switching into boxValues mode not ideal as impacts your code significantly.
Should the value of sentinels with $type error always be consistent as an Error object? Or should we allow client to control the value and leave it open-ended?
If people want treatErrorAsValues, should we just suggest that they always model errors as an object so they can introspect to see that it's an error? Likely it would be better to provide a capital Error as it makes it just feel like JavaScript rather than special cased.

@DonutEspresso suggests that keeping client and server consistent in dealing with capital Error is best. Definitely feels more natural.
Needs more discussion.

I'm not sure if this is the right issue. But +1 on making error handling better.
I don't get a stracktrace anywhere. Not on the server and not on the client. Also I don't think there is a way to get it.
I want to have access to the stacktrace only on the serverside. Exposing stacktraces to clients is bad practice.
Feature request: I want to be able to register an error handling function on the Router. This should be called with an Error instance with the path, error message and the stacktrace.

@0xR We are definitely wanting to do this.  We are going to re-think our error story holistically probably at the beginning of the new year.  So please stay tuned.  We will make it much better.

hello @michaelbpaulson @ktrott
@Michael, I was in touch with your friend Gene Scheck with this topic, he told me that you are a very helpful guy.
I am writing a book for www.packtpub.com with full tech-stack as React+Node+Falcor+MongoDB.
This is will be 400 - 500 pages long book, any I need some feedback for you how to handle the errors in Falcor properly.
Regarding to this issue, my question is: how to handle auth errors for example?

How I can properly make an error in falcor-error and inform a user about it on the front-end in case when any of .set, .get, .call functions has an error (like not enough privileges for a certain route)?
@michaelbpaulson looking for your help o that topic.
Regards,
Kamil

An error use-case I'm running into is when you are using call to add multiple new records. For example, if we take the todos code example in the docs, I'm wanting to do something similar to:
// Inside Model
dataSource.
    call(
        // callPath parsed into Path array by Model
        ["todos","add"],
        // function arguments
        ["pick up some eggs", "a quart of milk", "and a stick of butter"], // <-- MULTI-ADD
        // refPaths parsed into PathSet arrays by Model
        [
            ["name"],
            ["done"]
        ])

Say one of the todos fails a validation test. There does not appear to be any way to represent that one error in the returned JSON graph amongst the successful adds (which means at least for now I'm probably limited to adding only one todo at a time).

I think a good approach would be if the result object of the call gave the raw response, and on the response you could send an error payload as a atom with $expires: 0 as a way to sinalize to not store it into cache since is just the operation metadata.
I tried but I couldn't get the atom on the response result, probably because the response comes from the already computed cache, longer expires would work but would polutte the cache.
I think that on the part of the calls it should exist an way to send non cache related data on the response payload.

@drFabio the $expires: 0 atom not showing up in the response result is a known bug (falcor merges the atom into the cache, but the followup get sees it as expired, and throws it away without putting it into the response result). This bug has been squashed in our @graphistry forks of the falcor projects.

@trxcllnt cool! Thanks. Have you submitted a PR for that or this branch is intended to diverge ?

@drFabio that's up to the Netflix team ¯_(ツ)_/¯ but I seriously doubt it. We've nearly rewrote most of the client and router for better performance, deep React integration, and streaming data.

Update: this is paused, but in progress.


Use .bash_profile instead of .bashrc for the installer

On MacOS (at least El Capitan), ~/.bash_profile runs by default but ~/.bashrc does not.
(This may not be just MacOS.  I've just had .bash_profile source my .bashrc for decades... ;) )

I source ~/.bash_rc as well from ~/.bash_profile. I think that's a pretty common best practice.

http://superuser.com/questions/244964/mac-os-x-bashrc-not-working

Comments on the above link describe the situation. From a quick skim it seems like it might not be as simple as just using bash_profile

To expand on the above, I think bash looks for both .profile and .bash_profile in some order and runs the first one it finds, which means if we aren't careful we could potentially shadow an existing users config, or end up having our config shadowed. I think we'll probably need a little logic to search for the right place to update the path, e.g. always try to find an existing dotfile to modify in some preferential order, and if that doesn't work then create a reasonable default setup, or something like that.
Also, I think if we want aliases or functions (e.g. to modify the path or switch versions), those may actually need to be in .bashrc rather than in a profile because unlike environment variables they aren't inherited.
Finally, to make things more complicated, the startup behavior of bash changes significantly depending on a lot of different factors, including what name it was invoked with and what kind of file descriptor its stdin is connected to. The INVOCATION section of the bash man page is kinda scary, but a very relevant read.


Fix generated test data cc_test data=[] in cmake

Trying to have a data dep on a generated file and it's not working.
File generator:
iree_bytecode_module(
  NAME
    add
  SRC
    "add.mlir"
  CC_NAMESPACE
    "iree::bindings::tflite::testdata"
  FLAGS
    "-iree-mlir-to-vm-bytecode-module"
    "-iree-hal-target-backends=vmla"
  PUBLIC
)

This properly yields the bindings::tflite::testdata::add.module utility target.
Consumer:
iree_cc_test(
  NAME
    smoke_test
  SRCS
    "smoke_test.cc"
  DATA
    bindings::tflite::testdata::add.module
  DEPS
    ::shim
    bindings::tflite::testdata::add_cc
    iree::testing::gtest
    iree::testing::gtest_main
)

Error:
[build] [1/1 100% :: 0.034] cmd.exe /C "cd /D D:\Dev\iree-build\bindings\tflite && D:\Tools\CMake\bin\cmake.exe -E copy D:/Dev/iree/bindings/tflite/testdata/add.module D:/Dev/iree-build/bindings/tflite/testdata/add.module"
[build] FAILED: bindings/tflite/CMakeFiles/bindings_tflite_testdata_add.module
[build] cmd.exe /C "cd /D D:\Dev\iree-build\bindings\tflite && D:\Tools\CMake\bin\cmake.exe -E copy D:/Dev/iree/bindings/tflite/testdata/add.module D:/Dev/iree-build/bindings/tflite/testdata/add.module"
[build] Error copying file "D:/Dev/iree/bindings/tflite/testdata/add.module" to "D:/Dev/iree-build/bindings/tflite/testdata/add.module".
[build] ninja: build stopped: subcommand failed.

(note that it's trying to copy from the source dir over top of the actual generated output!)

This would need some sort of change here: https://github.com/google/iree/blob/da64c93eb38fe6864b9ebeb3674e6229fa4dae1b/build_tools/cmake/iree_macros.cmake#L217-L226

I tried a few things but don't quite have this figured out.
This looks helpful: https://cmake.org/cmake/help/latest/policy/CMP0118.html

The GENERATED source file property is now visible in all directories.

, but otherwise we can at least make the copy not fail with something like
    if(NOT EXISTS ${_INPUT_PATH})
      # Not found in the source tree.
      # Assumed to (1) exist and (2) be a generated file.
      continue()
    endif()

The loose / overlapping / missing definitions of "source file", "generated file", "target", etc. in CMake (at least compared to Bazel) make this sort of "data" dependency concept tricky to map...
When I ran https://github.com/google/iree/blob/main/bindings/tflite/smoke_test.cc (after tweaking deps and enabling the disabled test cases), the underlying fopen() isn't finding the .vmfb files provided with relative paths.

I think the way iree_bytecode_module doesn't use custom_command and custom_target properly

I believe this should be fixed with https://github.com/google/iree/pull/9387


Discriminate user vs. platform errors

When an error is reported, e.g., when the build fails, it should ideally be discriminated whether this is a user or a platform error. For instance, if the user adds a dependency, but the build fails because the dependency is not found in the configured Maven repository, this can be labelled as a user error.
The error kind, should be added as a label in the context of #1267.

/cc @davidffrench @david-martin


Updates to correctly render semantic inputs with labels.

Added subtemplates for afFormGroup that allow for the input to be wrapped with the correct div if the input has labels or icons
#48

Hey @fabienb4, will this be merged?


[Feature][GitHub] Provide a time filter to limit the GitHub/GitLab data to collect

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
As an OSS project maintainer, I want to collect GitHub data with DevLake. It takes ages to finish the collection of all historical data; while I'm not going to use the data before 6 months.
The description below will be centered around GitHub, but the situation is similar for GitLab, jira, and other plugins.
Description
Similar to #3642, the core idea is to limit the data to collect by selecting a time range. As a result, the collection speed of GitHub data will be shortened evidently.
DevLake will collect the last six months of GitHub data by default. Users can modify the date range.
Affected entities
This time filter will affect the following entities by the corresponding time field:

issues: created_date. All related entities such as issue_comments will be affected as well.
PRs: created_date. All related entities such as pull_request_comments will be affected as well.
commits: authored_date. All related entities such as commit_files will be affected as well.
workflow runs: started_at
jobs: started_at

Non-affected entities:

tags: as they have no created_date
accounts: it's fine to collect the full account list

Once this approach is proven effective, this time filter could be added to other plugins such as GitLab, Jira, etc.
Prototype

Figma link: https://www.figma.com/file/Eux4Dhorxp7M0TwzOnL6Yh/Config-UI-for-V1.0?node-id=2601%3A18715
Related issues
#3642
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

closed by https://github.com/apache/incubator-devlake/pull/3916


Provide helpful information when a 'cPanel $version does not appear to be up to date' Blocker is encountered

Provide helpful information when a 'cPanel $version does not appear to be up to date' Blocker is encountered

This is the Blocker the client sees when their server is not running the most recent version of cPanel v110:

......
* 2024-01-08 21:43:45 [INFO] Successfully verified signature for cpanel (key types: release, development).
* 2024-01-08 21:43:45 [ERROR] This installation of cPanel (<IP_ADDRESS>) does not appear to be up to date.
  Please upgrade cPanel to a most recent version.
* 2024-01-08 21:43:45 [WARN] Please fix the detected issues before performing the elevation process.
  Read More: https://cpanel.github.io/elevate/blockers/

For v102 the information is the same:

......
info [elevate-cpanel] Successfully verified signature for cpanel (key types: release, development).
* 2024-01-08 22:55:59 [ERROR] This installation of cPanel (<IP_ADDRESS>) does not appear to be up to date.
  Please upgrade cPanel to a most recent version.
* 2024-01-08 22:55:59 [WARN] Please fix the detected issues before performing the elevation process.
  Read More: https://cpanel.github.io/elevate/blockers/

Maybe, we could tell them what version we are looking for, suggest they make certain updates are enabled in /etc/cpupdate.conf and provide a command to perform the upcp, like, If updates are not disabled on your server, then, you may execute the update now using /usr/local/cpanel/scripts/fix-cpanel-perl; /usr/local/cpanel/scripts/upcp --cron

@annes449 do we have a public document on this we can refer them to? No matter how detailed we are, this is a complicated thing. maybe we should refer people to support for help?

@toddr We might want to link /etc/cpupdate.conf to https://docs.cpanel.net/knowledge-base/cpanel-product/the-cpanel-update-configuration-file-cpupdate-conf/ and link /usr/local/cpanel/scripts/upcp to https://docs.cpanel.net/whm/cpanel/upgrade-to-latest-version/ and recommend that if they still have problems upgrading, they should open a support ticket.

We might consider telling them the version we are looking for, then, suggest they go to WHM: Upgrade to Latest Version to resolve the issue?

Explicitly telling them what version we think they should be on would be an improvement. Also linking to the above docs would be good!


[Event Change] Codeunit::"Item Jnl.-Post Line" - Function UpdateProdOrderLine - OnBeforeProdOrderLineModify

We like to request the following Event:
Object: Codeunit::"Item Jnl.-Post Line"
Function: UpdateProdOrderLine
Publisher Event: OnBeforeProdOrderLineModify
Reason: add an extra Parameter
Where is the event placed:
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeProdOrderLineModify(var ProdOrderLine: Record "Prod. Order Line"; ItemJournalLine: Record "Item Journal Line"; ItemLedgEntryNo: Integer)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[Add] add loading button

Details
i want to add animated loading button
Screenshots
No response
Type of Contribution

[ ] Update to an existing Animated Button
[X] Adding a new Button
[ ] Resolving a bug
[ ] Proposal to the Repository
[ ] Changes related to documentation or README.md
[ ] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

Please merge my PR, I already raised it
On Sat, 17 Jun, 2023, 6:25 pm OM GAWANDE, @.***> wrote:

Assigned #1215
https://github.com/Spyware007/Animating-Buttons/issues/1215 to
@silky-modi22 https://github.com/silky-modi22.
—
Reply to this email directly, view it on GitHub
https://github.com/Spyware007/Animating-Buttons/issues/1215#event-9558689845,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXW4BYAKYU2S5FLSCV3L4MDXLWSNTANCNFSM6AAAAAAZDD7FEA
.
You are receiving this because you were assigned.Message ID:
@.***
com>

Please check #1346

Sorry for the inconvinience, but we are closing all the issues! Please open a new issue if you want to contribute anything. Also now you can create a new button from the website itself! You will get points for those too! I will add the instructions on how to create a new button soon and create an empty pr for the same to get points!


Improve the slider in Disney Hotstar Clone [GSSOC'23]

I would like to enhance the quality of slider as it is not slide smoothly.
I will add smoothness to the slider.
So, please assign this issue to me.

Hi,I have experience with the project's tech stack.Please assign this issue to me under GSSOC'23..It would be grateful for me to contribute.

Not a required change


GetNextSequenceNumberGreaterOrEqualThan may cause problems

EventSequence GetNextSequenceNumberGreaterOrEqualThan returns EventSequenceNumber.Unavailable if the operation of getting the sequence number from the database failed for any reason. This can cause problems in the code that uses it, for instance the Observer when it needs to check whether or not to catchup on events for a partition.

We'll need to consider this together @einari

Fixed by #1579


[1.8.1] Canvas stencil instructions issue on ScrollView; possibly not discarding old stencil masks?

This took me quite a while to find the cause of, but it seems canvas stencil instructions break down when used on a widget within a ScrollView.
I created a self-contained example project[1] that demonstrates this behavior. Each PersistentImageToggleButton draws a texture within itself, as described in stencilbug.kv. The top row (Texture) loads in fully opaque images, while I assigned some partially transparent ones to the bottom row (Overlays) for extra clarity.
The "Overlay" row's textures are drawn on top of the "Texture" row's ones, despite their stencil masks having been popped. Having the main widget extend from a GridLayout rather than a ScrollView by replacing line 74 with 75 in main.py fixes this issue.
[1] https://dl.dropboxusercontent.com/u/971175/Kivy/StencilBug.zip
Is this a known/ expected behavior? I'd like to refrain from having to crop the textures beforehand and all that jazz, so any help/ solution would be much appreciated. =)
On a sidenote, I noticed the docs are on version 1.9 already, while the downloads are still on 1.8. Is 1.9 is a thusly stable state that I should upgrade yet?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5717741-1-8-1-canvas-stencil-instructions-issue-on-scrollview-possibly-not-discarding-old-stencil-masks?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

Just came across this again and would like to update:
It seems that this only happens for widgets of the same type. Replacing one of the rows with PersistentImageToggleButton2s seems to fix the issue. This can be as simple as:
class PersistentImageToggleButton2(PersistentImageToggleButton):
    pass

I'm not sure why, but the previously mentioned work-around has stopped working for me. Looking at it some more, the problem appears to be due to the nested stencil from the ScrollView (scrollview stencil -> custom stencil).
I'm not sure yet what the best workaround for this is however.

From the docs: "Changed in version 1.3.0: The stencil operation has been updated to resolve some issues that appeared when nested. You must now have a StencilUnUse and repeat the same operation as you did after StencilPush."
Your code appears to work properly if stencilbug.kv is changed as follows:
<PersistentImageToggleButton>:
    canvas:
        Color:
            rgba: (1, 1, 1, 1)

        StencilPush

        Rectangle:
            pos: [self.pos[0] + (self.size[0]*0.15)/2, self.pos[1] + (self.size[1]*0.15)/2 + 1]
            size: [self.size[0]*0.85, self.size[1]*0.85]

        StencilUse

        Rectangle:
            texture: self.tex
            pos: [self.pos[0] + (self.size[0]*0.15)/2, self.pos[1] + (self.size[1]*0.15)/2 + 1] if self.stretchTexture else [self.pos$
            size: [self.size[0]*0.85, self.size[1]*0.85] if self.stretchTexture else self.tex.size

        StencilUnUse

        # this instruction copied from StencilPush above
        Rectangle:
            pos: [self.pos[0] + (self.size[0]*0.15)/2, self.pos[1] + (self.size[1]*0.15)/2 + 1]
            size: [self.size[0]*0.85, self.size[1]*0.85]

        StencilPop


Add hybrid mode content

Based on https://github.com/okteto/docs/pull/447 I'm proposing we add the hybrid mode content in these areas and using this language.
Opening a separate PR seemed cleaner 😄

Closing this PR for now


fix: Considers strokeAlign to compute border dimensions

Fixes #155491
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

There are 3 golden tests that don't pass on my computer, but they were already not passing before my changes.

Good catch. Never thought about this scenario.

Google Testing failing 👀

Still failing 👀

Thanks for checking. The first time there was some actual errors but I failed to see the relationship with this PR. The second time there wasn't even a "test result" page. Let me try again.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-network-dnszone
Module Details
AVM Resource Module for Public DNS Zone
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

@matebarabas @PmeshramPM I'm interested to own this module

Hi @sharmilamusunuru
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Regards,
Sharmila Musunuru
Cloud Solutions Architect- Apps & Infra
Azure Infrastructure & Apps
Mobile: +65 89257145
[Microsoft]
Find a free slot and book my time @.***/bookings/>.
From: Predrag Jelesijevic @.>
Sent: Wednesday, July 17, 2024 8:21 PM
To: Azure/Azure-Verified-Modules @.>
Cc: Mention @.>; Comment @.>
Subject: Re: [Azure/Azure-Verified-Modules] [Module Proposal]: avm-res-network-dnszone (Issue #1091)
Hi @sharmilamusunuruhttps://github.com/sharmilamusunuru
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACIhttps://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
Shared Specification (Bicep & Terraform)https://azure.github.io/Azure-Verified-Modules/specs/shared
Module Supporthttps://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Verified-Modules/issues/1091#issuecomment-2232958755 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ32AGX6AJTMI7QGFUIX4ODZMZAQJBFKMF2HI4TJMJ2XIZLTTGBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TSMBXG43DSOBQGGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRVHEYDONZWHE4DOMFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWVDKOJQG43TOMBUHA4KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNKGU4TGNRVGMYTEMBTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2UNJZGUYDSNJUHAZDDJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVI3DANBZGI2TENZWGCSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44YQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJWGYYDEMJRGU3TNAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMZVGY4TQMRUGE3YFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI2TSMBXG43DSOBQGGBKI5DZOBS2K3DBMJSWZJLWMFWHKZNKGU4TANZXGY4TQNZQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHEYDONZXGA2DQOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNJZGM3DKMZRGIYDHAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDKOJVGA4TKNBYGIYYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVI3DANBZGI2TENZWGCTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@sharmilamusunuru
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

Module repo created waiting for business review to complete

PR checks passed for the release 0.1.0 https://github.com/Azure/terraform-azurerm-avm-res-network-dnszone/pull/1

@prjelesi  module is published please help to change the status
https://registry.terraform.io/modules/Azure/avm-res-network-dnszone/azurerm/latest

moving this to Review, the development is finished on this one.

@mbilalamjad  can you please help to finish the review, as its been a while that development is finished onthis


Wrong type for DiscordRoleIds in Tier model

The property DiscordRoleIds is currently of type object, but should be List<ulong> actually. Tested this and works fine :)

You're right - even though the json for Discord IDs are using strings it looks like they can be deserialized to their ulong types which is more reasonable to use. Thanks!


Add format code for less.

Not planed in the near future, but we hope someone can provide a custom extension for this.


Add SSL

Enforce SSL

@barnie995 kindly gave me a hand to get this going.
Started creating the 4096 cert. Will check back in the moin.

Donezos.  :D


support number right-aligning in table view

This is an improvement suggestion.
Superset version
15.2
Expected results
numbers should be either right-aligned or decimal places aligned, it's better that user can control this behavior.
Actual results
numbers in table view are left-aligned like normal text, which is not so convenient for comparison.
Steps to reproduce
create a table view with any metrics, number values are now left-aligned and I could not found any adjustment for it. I also tried d3-format with padding but this doesn't work.

Does it happen on latest release?


backend/drm: handle changes in the set of fixed modes for an output

Related to https://github.com/swaywm/wlroots/issues/2188
vmwgfx, qxl,  and possibly other drivers for virtualised displays emit a udev change event for outputs when the corresponding window on the host system is resized. In this case, the set of fixed modes for the virtualised output changes such that the preferred mode matches the new dimensions of the window on the host system.
This change handles this case by updating the modes in (struct wlr_output).modes, and adding a new signal available_modes which compositors may use to be notified when such a change occurs. The mode is not automatically changed, instead the compositor may change the mode as it sees fit.
Notes:

I didn't use hotplug_mode_update because I didn't see any need to refer to it. If the modes change, then it is handled, and if they don't, nothing happens.
A mode is freed when it has been removed and is no longer the current or pending mode. I assume that a compositor will not try to access a mode after this time. If the compositor does not handle the available_modes signal, then it is possible that the old/removed mode will remain active. In this case, it should work the same as before.

Marking this as a breaking change, since modes can now be removed from the list. Previously, compositors could stash a wlr_output_mode somewhere and apply it later.
This PR is causing quite some issues related to memory management. This PR tries to destroy output modes, except if they are still in use by wlr_output.mode or wlr_output.pending.mode. I'm not sure if there's a better solution.

Marking this as a breaking change, since modes can now be removed from the list. Previously, compositors could stash a wlr_output_mode somewhere and apply it later.
This PR is causing quite some issues related to memory management. This PR tries to destroy output modes, except if they are still in use by wlr_output.mode or wlr_output.pending.mode. I'm not sure if there's a better solution.

Yes I struggled with the memory management. The only alternative I can think of: don't free any modes when they are removed, and instead introduce a list of old/invalid modes to be freed when the output is destroyed.

Yes I struggled with the memory management. The only alternative I can think of: don't free any modes when they are removed, and instead introduce a list of old/invalid modes to be freed when the output is destroyed.

I think there's some overlap between this and https://github.com/swaywm/wlroots/issues/2300#issuecomment-761819673. If we go with the solution (2) mentioned there, we could just ask nicely the compositor to set the new mode.

I think there's some overlap between this and https://github.com/swaywm/wlroots/issues/2300#issuecomment-761819673. If we go with the solution (2) mentioned there, we could just ask nicely the compositor to set the new mode.

Something I'd like to fix is that these properties aren't standard right now. We should really move them in the kernel DRM core and document them so that all virtual drivers can use them.

Something I'd like to fix is that these properties aren't standard right now. We should really move them in the kernel DRM core and document them so that all virtual drivers can use them.

Thinking about this a little bit more: maybe it doesn't make sense to populate output->modes at all when a connector has the hotplug_mode_update property. The mode list is mostly populated with standard modes so that user-space which expects physical outputs isn't confused, right?
Maybe DRM outputs backed by a virtual driver can behave a bit more like the Wayland and X11 backends.

Thinking about this a little bit more: maybe it doesn't make sense to populate output->modes at all when a connector has the hotplug_mode_update property. The mode list is mostly populated with standard modes so that user-space which expects physical outputs isn't confused, right?
Maybe DRM outputs backed by a virtual driver can behave a bit more like the Wayland and X11 backends.

Closed in favour of https://github.com/swaywm/wlroots/pull/2712


[Federation] ClustersSynced(clusters [] *federationapi.Clusters) documentation doesn't seem to match the implementation

 Issue by perotinus
Wednesday Mar 15, 2017 at 21:58 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/43169

It appears that there is a bit of an impedance mismatch between how the FederatedInformer discusses ClustersSynced(clusters [] *federationapi.Clusters) and the actual implementation of that method. Conceptually, the idea of ClustersSynced(clusters [] *federationapi.Clusters) seems to be to provide an ongoing update of whether the Federated store is synchronized with the underlying clusters' stores. In practice, it does this by checking the HasSynced() method on each of the clusters' informers. HasSynced() only promises to return whether, at some point in the past, the informer was synced, and from the implementation it appears that it does this by checking that the queue has been populated with some Add/Update/Delete operations, or was populated with some Replace operations that completed. Interestingly, if there is an in-flight Add, Update or Delete operation, HasSynced() appears to return true before that operation has completed.
So, ClustersSynced(clusters [] *federationapi.Clusters) doesn't quite provide the depth of information that it implies in its name and its documentation. Note that the ClustersSynced() method on FederationView does note this in the comment.
It may be worth renaming these to HaveClustersBeenSynced() or some such to make it clear that they do not provide information about the current sync state, but only that at some point they were synced (or at some point were slated to be synced, which seems to be the promise that is provided).jk
Someone else may want to look into this code to corroborate these findings.

 Comment by kargakis
Tuesday Jun 20, 2017 at 18:03 GMT

/sig federation

cc @perotinus


Restaurant Number Github?

saw the YouTube video of using service workers to notify the user when then number is called for a restaurant. Is there a repo with that code? I'd love to see an example of using the service worker. Thanks!

@matthewsibigtroth has been working on this demo (I really like it, too!).  I'm not sure where it is hosted at the moment.

Where is the video @derekshull ? :)

https://www.youtube.com/watch?v=b0GDk-53fTo

This was the original demo that motivated us to build "Bob's Deli" example:
https://github.com/sandropaganotti/no-queue

We done here? Closing. Please reopen if needed.

Hello! Is this code still available?

@scottjenson Hello!!, Is this code still avaible?.. Greetings from Chile.


How can I use the mode pspnet?

I executed the code:
from segmentation_models import pspnet
model = pspnet(backbone_name='inceptionresnetv2', freeze_encoder=True, input_shape=(None, None, 3))

But the console returned the error as follow:
Traceback (most recent call last):
  File "/home/[UserName]/anaconda3/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 2963, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-7-4764359b8965>", line 1, in <module>
    model = pspnet(freeze_encoder=True, input_shape=(None, None, 3))
TypeError: 'module' object is not callable

What would be the problem?

@MaxKinny  try from segmentation_models import PSPNet

@MaxKinny try from segmentation_models import PSPNet

Thank You, the problem has been solved.


⚠ Bofrost.lu has degraded performance

In a3b850b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 961 ms

Resolved: Bofrost.lu performance has improved in 68263ce after 21 minutes.


Error using standard json library in dify-sandbox: Operation not permitted

Hi! I encountered an "Operation not permitted" error when running the following code in the Dify sandbox. The error appears to stem from the import json line, suggesting a lack of necessary permissions for the system call.
# just import standard json library
import json

def main() -> dict:
    return {
        "hello": "hello"
    }

print(main())

Log
{"code":0,"message":"success","data":{"error":"error: operation not permitted\n","stdout":""}}

Would it be necessary to adjust the seccomp config to enable this?
executed it as follows:
pull image
docker pull langgenius/dify-sandbox

docker run
docker run -p 8194:8194 langgenius/dify-sandbox

curl
curl -X POST http://localhost:8194/v1/sandbox/run \
-H "Content-Type: application/json" \
-H "X-Api-Key: dify-sandbox" \
-d '{
  "language": "python3",
  "code": "import json\n\ndef main() -> dict:\n    return {\n        \"hello\": \"hello\"\n    }\n\nprint(main())",
  "preload": "",
  "enable_network": false
}'

As a side note
If remove import json, it works correctly.
def main() -> dict:
    return {
        "hello": "hello"
    }

print(main())

curl
curl -X POST http://localhost:8194/v1/sandbox/run \
-H "Content-Type: application/json" \
-H "X-Api-Key: dify-sandbox" \
-d '{
  "language": "python3",
  "code": "def main() -> dict:\n    return {\n        \"hello\": \"hello\"\n    }\n\nprint(main())",
  "preload": "",
  "enable_network": false
}'

Log
{"code":0,"message":"success","data":{"error":"","stdout":"{'hello': 'hello'}\n"}}

@taisei-13046 hello, how did you solve this problem?


Update the game over message

Update the game-over message so that people can see it.

pull request merged successfully

Merge successful


enhancement: add native LinkedInAuthComponent

Is your feature request related to a problem? Please describe.
Required a LinkedInAuth Button
Describe the solution you'd like
Adding a LinkedIn authorization component which will help the user to authenticate their linkedIn account and user can post to that account from this.

closing as done

We will update the design of the LinkedIn button


not able to start deisctl platform

root@mca:/home/mca/deis# deisctl install platform
● ▴ ■
■ ● ▴ Installing Deis...
▴ ■ ●
Storage subsystem...
deis-store-daemon.service: loaded
deis-store-monitor.service: loaded
deis-store-volume.service: loaded
deis-store-metadata.service: loaded
<EMAIL_ADDRESS>loaded
Logging subsystem...
deis-logger.service: loaded
deis-logspout.service: loaded
Control plane...
deis-database.service: loaded
deis-controller.service: loaded
<EMAIL_ADDRESS>loaded
deis-builder.service: loaded
Data plane...
deis-publisher.service: loaded
Routing mesh...
<EMAIL_ADDRESS>loaded
<EMAIL_ADDRESS>loaded
<EMAIL_ADDRESS>loaded
Done.
Please run deisctl start platform to boot up Deis.
root@mca:/home/mca/deis# deisctl start platform
● ▴ ■
■ ● ▴ Starting Deis...
▴ ■ ●
Storage subsystem...
deis-store-monitor.service: activating/start-pre
"it stuck at this point"

Assuming from the other byg, you were just waiting for the docker images to get pulled which takes time :)

ya it took time but now its working


Add SQL and SQL Server trainings

What does this PR do?
Add resources
For resources
Description

In the “Uygulamalarla SQL Öğreniyorum” training, the SQL language used to query today's structured data is explained. Microsoft SQL Server is used as the database platform and SQL language is taught from scratch with real-life data sets.
Basic DML SQL commands (Select, Insert, Update, Delete) which are the basic features of SQL language.
DDL commands used to manage database objects (Create, Alter, Drop)
Commands of relational database concept (Join, Subquery)
Topics such as grouping and summarization concepts (Group By, Aggregate functions) are explained using real-life and real data sets.

In the “Her Yönüyle SQL Server” training, SQL Server, one of today's most widely used database management systems, is explained. The training covers how database management systems work, database objects on SQL Server such as Stored Proc, Trigger, Function, View, SQL Server performance management, Backup strategies, Working with real-life data, and Working with big data.

Why is this valuable (or not)?
Training courses that teach SQL and SQL Server through real-life data and real data sets.
How do we know it's really free?
The website https://www.btkakademi.gov.tr/ is a free educational platform managed by the official ministries of the Republic of Turkey. You can verify it by following the link https://www.btkakademi.gov.tr/portal/public/hakkimizda
For book lists, is it a book? For course lists, is it a course? etc.
Course
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

SQL and SQL Server are indeed two different structures. SQL is a language used across various database systems, while SQL Server is a specific database management system developed by Microsoft that uses SQL. Therefore, separating them into different categories helps clarify their distinct roles. These categories were created with this distinction in mind. However, I can also combine them under a single ‘SQL’ category if you prefer. Let me know your preference.

the course titles will do the explaining. Use a single "sql" category.

Thanks, and welcome to free-programming-books!


feat: Implemented Role Manager module and fix: errors in Assertion

I will try to add unit test for this module in few days.

@techoner

@rushitote plz fix:

@hsluoyz I added a utility function to check if two tables have same values regardless of order since it seems the Busted function to check if two tables are same compares it in different ways (orders) on different Lua versions. Now the checks run fine.

lgtm


interval label and resampling observations

Figure below illustrates that there is an issue with resampling observations depending on the interval label

The issue is not in the plotting. Here's the relevant part of the csv with processed forecasts and observations:
,University of
Arizona OASIS ghi
60m ending,University of
Arizona OASIS ghi
60m beginning
2020-12-31T17:00:00-07:00,23.8143,23.8143

I believe the issue is that this block of code resampling code uses observation.interval_label rather than  forecast.interval_label to determine the resampled label.
https://github.com/SolarArbiter/solarforecastarbiter-core/blob/e65198d0b0c6805005d0ce46bcecc993fb3f0707/solarforecastarbiter/metrics/preprocessing.py#L241-L257
So this is very similar to https://github.com/SolarArbiter/solarforecastarbiter-core/pull/702#pullrequestreview-719463826

I guess we knew about this but I didn't prioritize fixing it. Arg. I don't see another issue for it.
This PR documented the problem in the Notes section of the old resample_and_align function: https://github.com/SolarArbiter/solarforecastarbiter-core/pull/303
That text was revised here: https://github.com/SolarArbiter/solarforecastarbiter-core/pull/580/files#diff-3738afa2f44ae4378b4e0e68a3b6b14ba99bfe5965cf6f0f4e8158ce023b9c8aL275-R415


Markdown preview fails to load on any project

Version: 1.46.0-insider
Commit: 2b472d1e4aaaecdda5ca96289869f90ae82de3a1
Date: 2020-05-11T10:00:38.669Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.38-1-MANJARO
Steps to Reproduce:

Launch vs code
Open any directory that contains a .md file
Approximately 1 out of 5 times the markdown preview will fail to load until you completely close and reopen vs code

Does this issue occur when all extensions are disabled?: Yes, also happens on a clean install
Screenshot:

I was able to reproduce the issue consistently by using the version reported in the first post, as well as the version mentioned below:
Version: 1.46.0-insider
Commit: c7a37c4400bb4c1b92eeeaea1bcacc9ec3789ef3
Date: 2020-06-04T08:30:33.216Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.43-1-MANJARO
Steps to reproduce:

Close all vs code windows
Launch a new vs code window
Open any project (preferably an empty folder)
Open or create a markdown file and make sure the markdown has some contents
Open the markdown preview
Exit vs code without closing the markdown preview
Reopen vs code

Please test this gain with the latest VS Code insiders build (1.47). I'm not able to reproduce this issue following your steps, even after trying 10 times or so

Issue does not happen on latest insider 1.47 (b9d7ec9ff367a8e59fe4cc2abee605a55be180e8)
However I'm getting a different error when running latest master (9c142ea3831a60fa62ee62cbcaa6a10e4b2a614d) after following similar steps as before
Steps:

Launch code by running ./scripts/code.sh
Open any project (preferably an empty folder)
Open or create a markdown file and make sure the markdown has some contents
Open the markdown preview
Exit vs code without closing the markdown preview
Reopen vs code by running ./scripts/code.sh

Error:
[9802:0620/091201.704887:INFO:CONSOLE(144)] "%c  ERR color: #f33 Cannot read property 'onDidChange' of undefined: TypeError: Cannot read property 'onDidChange' of undefined
    at EditorPart.get onDidChange [as onDidChange] (file:///home/user/Desktop/vscode/out/vs/workbench/browser/parts/editor/editorPart.js:582:80)
    at new LeafNode (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:415:65)
    at GridView._deserializeNode (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:831:26)
    at file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:824:36
    at Array.map (<anonymous>)
    at GridView._deserializeNode (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:822:53)
    at file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:824:36
    at Array.map (<anonymous>)
    at GridView._deserializeNode (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:822:53)
    at file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:824:36
    at Array.map (<anonymous>)
    at GridView._deserializeNode (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:822:53)
    at GridView._deserialize (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:816:30)
    at Function.deserialize (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/gridview.js:812:20)
    at Function.deserialize (file:///home/user/Desktop/vscode/out/vs/base/browser/ui/grid/grid.js:424:50)
    at Workbench.createWorkbenchLayout (file:///home/user/Desktop/vscode/out/vs/workbench/browser/layout.js:985:59)
    at file:///home/user/Desktop/vscode/out/vs/workbench/browser/workbench.js:78:26
    at InstantiationService.invokeFunction (file:///home/user/Desktop/vscode/out/vs/platform/instantiation/common/instantiationService.js:43:24)
    at Workbench.startup (file:///home/user/Desktop/vscode/out/vs/workbench/browser/workbench.js:61:38)
    at DesktopMain.open (file:///home/user/Desktop/vscode/out/vs/workbench/electron-browser/desktop.main.js:61:52)", source: file:///home/user/Desktop/vscode/out/vs/platform/log/common/log.js (144)

Thanks @thejavascriptman for following up. I suspect this was fixed by 2c53ad120d952fd1ea6e23d3b8e0c3276faf529d
The new error you are seeing is #100783 which we are investigating


menubarControl.ts tracks window focus even if hidden or not showing

Steps to Reproduce:

use web and have the menubar hidden
open dev tools, put a breakpoint into menubarControl.ts#onDidChangeWindowFocus
click into page

=> 🐛 breakpoint is hit
I would neither expect the menu to do any work when not enabled nor when not visible.

I still see that this code is hit even though the menu is hidden in web:
https://github.com/microsoft/vscode/blob/0baf6bb9cca978e6f3527b96331e27573b0dfb24/src/vs/workbench/browser/parts/titlebar/menubarControl.ts#L205-L205

@sbatten I still don't understand why the menu needs to be updated when not opened. Can we not run this code when the user clicks on the "File" menu lazily?

this code is shared with the native menu bar which cannot calculate information lazily. for simplicity the 2 models are kept as similar as possible. this is now only happening when the menu is visible and the user switches workspaces/windows


Remove --linenumbers in systemd example

A tiny tiny tiny PR but it might save others who copy and paste 1 minute with journalctl. Great application btw!

Many thanks for this! I was going to just implement that feature in the next release but until then better to have the readme correctly. Have a nice day!


Getting configuration.error in authentication flow with Advanced Authentication Configuration

Describe the issue:
After configuring Advanced Authentication Configuration to use JWT Basic authenticator and Google Authentication (configured as a federated IDP) getting following error page when try to log into the sample application (Service provider).

How to reproduce:

Configure Google as an Identity provider by following https://is.docs.wso2.com/en/latest/guides/identity-federation/google/#register-an-identity-provider

Configure service provider and set authentication steps by following https://is.docs.wso2.com/en/latest/guides/identity-federation/google/#register-a-service-provider.
Authenticators - JWT Basic and Google.

Try to log into the sample application.

https://github.com/wso2/product-is/assets/25563417/575a417f-68d4-425e-88c7-be2ec57e7e58
Expected behavior:
User should be able to log into the sample application.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 6.2.0 Alpha 2
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Since it is expected to send a JWT token with the authentication request when this authenticator is engaged, this problem can be expected. With the API based authentication feature in the IS 7, this capability is no longer required. Hence we will not be fixing this concern.


[Deployment] Redirect the default port of browser to the development site

So we won't have to input port numbers in our browser. This will be "demo friendly".

@tai271828
Sounds like to change the demo site ip address mapping to ohshown.site:80 instead of  ohshown.site:8080.
But not sure how to do that?

Yes!

@tai271828 Sounds like to change the demo site ip address mapping to ohshown.site:80 instead of ohshown.site:8080. But not sure how to do that?

By using nginx with the following config, now http://ohshown.site is working.
server {
        listen 80 default_server;
        listen [::]:80 default_server;

        server_name ohshown.site;

        location / {
            root /home/dev/ohshown-frontend/dist;
            try_files $uri @rewrite;
        }

        location /api/ {
            proxy_pass  http://localhost:8888/api/;
        }

        location @rewrite {
            rewrite ^(.*)$ /index.html last;
        }
}


Use the new format of decision tables shown in Table B.3 of 2021 assessment?

In 2021 several suggested changes were made to the format of the big decision tables, resulting in Table B.3. The SRG said:
" The SRG believes that the resulting decision tables are clearer and easier to understand and recommends that the JMC review these tables along with the standard decision tables, and provide feedback to the SRG and JTC as to its preference during the March 15-17, 2021 JMC Meeting. These alternative decision tables are presented in Appendix B of the JTC Stock Assessment document." [wasn't actually in the list of recommendations though]
At JMC we asked for feedback - I don't have my meeting notes handy and forget what they said. Kelli has followed up with Jim but not heard back.
Given the SRG prefers them, and if we don't recall anyone being against them, seems we should use them. We justified and explained the differences in 2021 Appendix B (so no need to again), including Trevor's 2019 one about the catch/biomass years being offset in  #553. Code is all written.

So in Exec Summary would update:

[ ] Table g & h
[ ] Figure i add the extra projection year
[ ] Add extra Table i/j for the extra year, plus extra Figure j/k for the extra year

JTC internal meeting: agreed to do this. Decide upon exact catch streams later - maybe even non-equal from year to year if JMC get back to us. Easier to add further catch streams to big table than do a second table - okay if ends up as a long table over two pages.

Maybe on Friday we should just mention to the JMC that we're doing the new format as recommended by the SRG. If any objections we can stick with the usual.

Not sure that we actually showed an updated format for the relative fishing intensity table. Chris put a type = "spr" option into the new_decision_table() function, but it didn't work when I quickly tried it. So I haven't put that new format of table into main-tables yet (which I think would just be losing the % signs everywhere and losing the 25% and 75% columns). Have copied new format of biomass table into main-tables (but not Exec Summary yet - tweak it first as necessary in main-tables then copy over).

I didn’t write the code for that table yet

Thanks - that's what I thought. Got a bit confused because the SRG talked about showing alternative tables in App B, but we only had the biomass one.

All done except Chris to update the fishing intensity table if time (else I can do it - I can see what lines to tweak). No text updated yet.

@aaronmberger-nwfsc are you saying it should look exactly like this rel. biomass one then with the "start year" column? I thought there was some difference

I don't think we need the "Biomass year Start 2022" column. Will actually be confusing (and is the thing I figured might be a bit fiddly in the code).

@andrew-edwards I am talking about the Relative Fishing intensity table, are you also?

I thought we agreed to project 4 years, so we show 2025 relative fishing intensity for the catch stream because it is the 4th year. So we show the 2025 catch value.

Yes, we still project 4 years, but don't show 2025 (fishing intensity table only).  Right, the whole point was that previously we showed fishing intensity for a year but did not show the result of that fishing (i.e., the biomass at the start of the next year).  Does that make sense?

So the sole reason to project 4 years is so we could show the 4th year start-of-year biomass after the last year's fishing. And not show the fishing intensity for that 4th year even though we have it.  I think I have it right now

Agree with Aaron. We're always going to kind of be off by one year. Three rows for this table.

And the table will have three rows like the snippet shown above. I said remove the "Biomass year Start 2022" for this table as we're not showing biomass at all and it might be confusing. (Unless it's too fiddly to take out).

Good job with the new fishing intensity table Chris. I noticed that the numbers are proportions now rather than percentages (like in the relative spawning biomass table), which is neater. Presume everyone is good with that.
I'll fix the caption (still says %ages), plus the main-tables equivalent, plus add it to the age-1 index appendix as I think it's not there.

Thanks Andy. Note that I swapped the row that has the quantiles (5%, 50%, and 95%) and removed the "Model quantile" text.


SyntaxError: invalid syntax (with pythin-2.7)

Version 3.0.1.
byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/classes.py to classes.pyc
  File "/usr/local/lib/python2.7/site-packages/opuslib/classes.py", line 23
    def __init__(self, fs: int, channels: int) -> None:
                         ^
SyntaxError: invalid syntax

byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/constants.py to constants.pyc
byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/exceptions.py to exceptions.pyc
  File "/usr/local/lib/python2.7/site-packages/opuslib/exceptions.py", line 23
    def __init__(self, code: int) -> None:
                           ^
SyntaxError: invalid syntax

byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/api/__init__.py to __init__.pyc
byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/api/ctl.py to ctl.pyc
byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/api/decoder.py to decoder.pyc
  File "/usr/local/lib/python2.7/site-packages/opuslib/api/decoder.py", line 47
    def create_state(fs: int, channels: int) -> ctypes.Structure:
                       ^
SyntaxError: invalid syntax

byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/api/encoder.py to encoder.pyc
  File "/usr/local/lib/python2.7/site-packages/opuslib/api/encoder.py", line 38
    def get_size(channels: int) -> typing.Union[int, typing.Any]:
                         ^
SyntaxError: invalid syntax

byte-compiling /usr/ports/audio/py-opuslib/work-py27/stage/usr/local/lib/python2.7/site-packages/opuslib/api/info.py to info.pyc
writing byte-compilation script '/tmp/tmpSwJW4j.py'
/usr/local/bin/python2.7 -O /tmp/tmpSwJW4j.py
  File "/usr/local/lib/python2.7/site-packages/opuslib/classes.py", line 23
    def __init__(self, fs: int, channels: int) -> None:
                         ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python2.7/site-packages/opuslib/exceptions.py", line 23
    def __init__(self, code: int) -> None:
                           ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python2.7/site-packages/opuslib/api/decoder.py", line 47
    def create_state(fs: int, channels: int) -> ctypes.Structure:
                       ^
SyntaxError: invalid syntax

  File "/usr/local/lib/python2.7/site-packages/opuslib/api/encoder.py", line 38
    def get_size(channels: int) -> typing.Union[int, typing.Any]:
                         ^
SyntaxError: invalid syntax

@ampledata Greg, are you able to fix these two bugs? I can't update the FreeBSD port because of them.
Thanks!
Yuri

Hi Yuri, You'll need to pin to the pre 3.0.0 branch as 3.0.0 and up is Python 3.6 Only.

Hi,

Hi Yuri, You'll need to pin to the pre 3.0.0 branch as 3.0.0 and up is Python 3.6 Only.

This is ok. But setup.py still says:
        'Programming Language :: Python :: 2.5',
        'Programming Language :: Python :: 2.6',
        'Programming Language :: Python :: 2.7',

You might want to adjust it.

@katrapilho it looks like your issue is coming from the library jwt which is using python3 type hinting which is not valid python2 syntax. Per their page: https://pypi.org/project/jwt/ their library only works in Python 3.4 and up
To get opuslib working in Python 2, please install version 2.0.0 or earlier with the command:
pip install opuslib==2.0.0


WIP: Mode to update the current season.

For issue: https://github.com/mpope9/nba-sql/issues/63
This PR adds the concept of 'modes'.
The existing method of creating the database will be determined by using the --default-mode commandline flag.
The new 'mode' that is introduced is updating the current season. This is specified by the --current_season_mode commandline switch. These are mutually exclusive groups in Gooey. This takes an existing database, loads all player_game_log entries into a temp table, then uses this new temp table (which should have more games than the existing player_game_log table) then uses set logic through an EXCEPT query to determine which games are new. This is used to update tables like game, shot_chart_detail, and player_game_log.
TODOs:

If no new games are added, bail early.

Do this by evaluating the EXCEPT predicate early.

Temp table creation atm conflicts with creating a fresh DB. The dependent objects do not yet exist.

Could be fixed by checking the current mode, if it was stored in the settings object.
Confirm that this is still broken after other changes before implementing.

Expand what is stored in the Settings class.

We're passing alot of cmd line args to the different mode functions.
If they were stored in Settings it'd be easier.

Move schema create function to db_utils.
Evaluate temp table indexes

Most probably aren't needed?

Figure out debug logging flags.

Would be useful to diagnose bugs by looking at the peewee queries.

Passing the filter predicate to the shot_chart_detail finalize is...a bit messy? I'm not sure, while it seems like the most flexible way to support filtering on the temp table -> regular table insert I'm not sure if it will work in future contexts, if there are any...


Add audit logging

Since 7bbf0b5db694abe67add44d600c12edaebef77fd, all modifications of kubernetes resources should be trackable using the user ID.