ECR Published Image Cannot be Fetched for Custom Cluster

What happened: When trying to run make cluster-up deployments get stuck in an image pull backoff., this causes the latter parts of the make cluster-up to fail in that there are no CSRs. When trying to pull the image locally, the ECR repository is not able to be pulled from publicly.
e.g.
$ docker pull<PHONE_NUMBER>52.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook:latest
Error response from daemon: Get https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/eks/pod-identity-webhook/manifests/latest: no basic auth credentials

Relevant k8s events from the pod:
Events:
  Type     Reason     Age                  From                     Message
  ----     ------     ----                 ----                     -------
  Normal   Scheduled  2m45s                default-scheduler        Successfully assigned default/pod-identity-webhook-56c67dff46-c6h9h to docker-desktop
  Normal   Pulling    78s (x4 over 2m44s)  kubelet, docker-desktop  Pulling image "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook"
  Warning  Failed     78s (x4 over 2m44s)  kubelet, docker-desktop  Failed to pull image "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook": rpc error: code = Unknown desc = Error response from daemon: Get https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/eks/pod-identity-webhook/manifests/latest: no basic auth credentials
  Warning  Failed     78s (x4 over 2m44s)  kubelet, docker-desktop  Error: ErrImagePull
  Warning  Failed     65s (x6 over 2m43s)  kubelet, docker-desktop  Error: ImagePullBackOff
  Normal   BackOff    51s (x7 over 2m43s)  kubelet, docker-desktop  Back-off pulling image "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook"

What you expected to happen: The pod-identity-webhook image to be publicly pullable.
How to reproduce it (as minimally and precisely as possible):

Be on a machine with no authentication to the<PHONE_NUMBER>52.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook repo and attempt to run:

docker pull<PHONE_NUMBER>52.dkr.ecr.us-west-2.amazonaws.com/eks/pod-identity-webhook:latest

Anything else we need to know?: Obviously this can be fixed by pushing an image the cluster can be reached from and passing in the relevant env vars to make, just following the current README.md instructions does not produce an expected result.
Environment:
(N/A here since this is unrelated to k8s/EKS specific bits)

AWS Region: N/A
EKS Platform version (if using EKS, run aws eks describe-cluster --name <name> --query cluster.platformVersion): N/A
Kubernetes version (if using EKS, run aws eks describe-cluster --name <name> --query cluster.version): N/A
Webhook Version: N/A

Running into the same exact issue, building the image locally and pushing into the ecr registry in my account solved the issue for now. Would be good if this image would be publicly available

Yeah, other repo's such as aws-iam-authenticator in the same account seem to be pullable,<PHONE_NUMBER>52.dkr.ecr.us-west-2.amazonaws.com/amazon/aws-iam-authenticator:v0.4.0-scratch for instance.

Thanks for this report, we're working on getting the image publishing process automated for this repo

I've also experienced this problem. Built the image myself to solve it. Please make the images public.

I build and pushed it to Docker hub.
Feel free to use it.

Any update on official docker images being available?

I think @nckturner is going to fix this 🎉

Hi @micahhausler Can this move forward?

What is the status? :)

Hi @btalbot this is not at all abandoned and the reason there have only been few commits is the project has not needed many updates.  :)
In regard to a public image, it has not been a high priority for the EKS team, not because it isn't an issue, but because we have a lot on our plate! In EKS, the webhook is part of the managed service and not required to be run by customers. We very much do intend to make a public image for this, but have not yet built an automated infrastructure for this project to cut public release images.

In EKS, the webhook is part of the managed service and not required to be run by customers

I can definitely honour that Micah, however if AWS and the EKS team are making a commitment to open source projects like this, it should hopefully encompass the original commitment in the announcement post that this is also intended for use outside of EKS managed clusters. Especially those of us building k8s clusters in EC2 outside of EKS, it doesn't drive a bunch of trust with the OS community around k8s to not have something like a public signed image from AWS available after so many months of waiting.

I definitely agree and this is something that we want to do better at, and this is one where your feedback helps us prioritize.
On the issue of signed images, that is not something ECR supports today, but you can follow along on image signing on the aws/containers-roadmap#43 issue.

Hi - dropping into to provide an update.
The reason this is not available on ECR is as Micah said, because the automation and publishing pipeline setup is not yet complete. While this image will not be not public in the sense of being able to pull from any computer anywhere, when published it will be accessible from any EC2 host.
We are working on the timeline for making this build pipeline live and will update here when it's available.

@tabern I appreciate the update! However, is there a reason not to circumvent the manual process for now and have it published to dockerhub like @btalbot mentioned above? Automation is obviously preferred, then engineers don't have to be involved to ship the latest changes ;P but for now literally having just ANY docker image available from the EKS team in a public fashion would immediately satisfy this use case.
Additionally, why would we not be able to pull this from any computer anywhere? What about customers who would be using on-prem to tie into IAM fo this authentication, or customers who use cross cloud functionality with this? It seems reductive to only have it be able to be pulled from EC2 hosts.

@Joeskyyy of course. It's really a matter of validation and automation either way.
The reason you can't pull this from any computer anywhere is because ECR does not yet support fully public repositories. (I realize this bolsters the argument for DockerHub even more... 😊)

@tabern any word? An issue to just publish a docker image has been open for over 6 months now...

First anniversary of this ticket being opened has past, any updates here?

Docker images are now available on https://hub.docker.com/r/amazon/amazon-eks-pod-identity-webhook


Updated README usage information

What does this PR do?
Updated ReadMe to include more detailed information about client setup/configuration.
Checklists
Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[x] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation

Thanks, @telday!!  Looks great.


Improve diff comment ui

Description
Improves the UI of the diff comment that gets added

Adds a status icon by comparing % diff across different coverage metrics
Removes the strike off UI and instead shows the % change in brackets **(-20)**
Adds a nice header to the comment
Adds test for the DiffChecker class

The output would look like this now

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
file1
100 (1)
100 (1)
100 (1)
100 (1)

:red_circle:
file2
99 (-1)
99 (-1)
99 (-1)
99 (-1)

:new:
file3
100
100
100
100

:red_circle:
file4
100
100
100
100

Thank you for creating it! This action is working great for us at @appsmithorg. I'll be looking to contribute more 😋


poggers 1.16 supoort that wouod be giid

1.16 support make now do

fbafric

MCXR is now built with 1.17 in mind, backporting is no longer an option

should probably close this.

no B)

should probably close this.


submission error

I can't get past the captcha, getting: Error
Error during submission - could not execute statement; nested exception is org.hibernate.exception.GenericJDBCException: could not execute statement Caused by:ORA-01652: unable to extend temp segment by 64 in tablespace TEMP ORA-06512: at "CHEBI.PCK_CHEBI_AUDIT_LOG", line 7

UPDATE: I just found my submission would be a duplicate of CHEBI:167616. That the reason for this error?

Hi,
We are having some issues with temp tablespace which prevents users from adding any data to the database. Please try again, it should be working fine now.


2.1.1

Added roadmap to the readme.
@cliftonc @FGRibreau Does it seem good?

done :) #v2.1.1

:+1:


Filter

it is possible to filter by an object inside a Foreign Key, for example Field.Level

See
http://django-cruds-adminlte.readthedocs.io/en/latest/usage.html#filter-content


Superbuild fails on Ubuntu 20.04 - GDCM compilation?

Hello,
I am trying to follow instructions here (https://simpleelastix.readthedocs.io/GettingStarted.html) to install SimpleElastix, but I get stuck at the "make -j4" step.
The error log is printed below.
I saw some related issue here (https://github.com/SimpleITK/SimpleITK/issues/1435) for SimpleITK, but I don't understand how to solve it for simple-elastix compilation.
If anyone has any hint, it would be very appreciated!
Many thanks,
Silvia

[ 58%] Building CXX object Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/CMakeFiles/gdcmMSFF.dir/gdcmImageChangePhotometricInterpretation.cxx.o
In file included from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.cxx:14:
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h: In function ‘T gdcm::Clamp(int)’:
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:32: error: ‘numeric_limits’ is not a member of ‘std’
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                ^~~~~~~~~~~~~~
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:48: error: expected primary-expression before ‘>’ token
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                                ^
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:51: error: ‘::max’ has not been declared; did you mean ‘std::max’?
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                                   ^~~
|                                                   std::max
In file included from /usr/include/c++/11/algorithm:62,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmByteValue.h:24,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmDataElement.h:20,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmBitmap.h:19,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmBitmapToBitmapFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmPixmapToPixmapFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageToImageFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.cxx:14:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
|     ^~~
In file included from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.cxx:14:
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:64: error: ‘numeric_limits’ is not a member of ‘std’
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                                                ^~~~~~~~~~~~~~
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:80: error: expected primary-expression before ‘>’ token
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                                                                ^
/home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:67:83: error: ‘::max’ has not been declared; did you mean ‘std::max’?
67 |   return v < 0 ? 0 : (v > std::numeric_limits::max() ? std::numeric_limits::max() : v);
|                                                                                ^~~
|                                                                                std::max
In file included from /usr/include/c++/11/algorithm:62,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmByteValue.h:24,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/DataStructureAndEncodingDefinition/gdcmDataElement.h:20,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmBitmap.h:19,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmBitmapToBitmapFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmPixmapToPixmapFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageToImageFilter.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.h:17,
from /home/silvia/build/ITK/Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/gdcmImageChangePhotometricInterpretation.cxx:14:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: ‘std::max’ declared here
3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
|     ^~~
make[5]: *** [Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/CMakeFiles/gdcmMSFF.dir/build.make:482: Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/CMakeFiles/gdcmMSFF.dir/gdcmImageChangePhotometricInterpretation.cxx.o] Error 1
make[4]: *** [CMakeFiles/Makefile2:8314: Modules/ThirdParty/GDCM/src/gdcm/Source/MediaStorageAndFileFormat/CMakeFiles/gdcmMSFF.dir/all] Error 2
make[3]: *** [Makefile:156: all] Error 2
make[2]: *** [CMakeFiles/ITK.dir/build.make:86: ITK-prefix/src/ITK-stamp/ITK-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:335: CMakeFiles/ITK.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Hi Silvia,
I am also trying to build SimpleElastix and managed to fix this error by adjusting the versions of ITK and SimpleITK downloaded in the process.
As indicated in the related issue you shared, this error should be fixed in ITK v5.2.1. However, the version of SimpleITK also has to be adjusted to a release compatible with ITK v5.2.1, which should be 2.1.1 (see here).
In practical terms, this is what I did:

After cloning the repository, edit lines 11-13 of the file Version.cmake to define SimpleITK version 2.1.1.
Enter the SuperBuild folder and edit line 56 of External_ITK.cmake to v5.2.1.

After fixing this, there was still some issue with elastix so I also edited line 5 of the file External_Elastix.cmake to the Git Commit tag corresponding to the release of elastix v5.0.1: 90122eff6b37a17adc9f5bb3d7bc08608e9c14a6, which you can confirm here.
Unfortunately, these changes were not sufficient for me. The build reaches 100% but fails before completing with a linker error, which I have not been able to solve yet:
[100%] Building CXX object Wrapping/Python/CMakeFiles/SimpleITK_PYTHON.dir/sitkPyCommand.cxx.o
[100%] Building CXX object Wrapping/Python/CMakeFiles/SimpleITK_PYTHON.dir/SimpleITKPYTHON_wrap.cxx.o
[100%] Linking CXX shared module _SimpleITK.so
/usr/bin/ld.gold: error: cannot find -lelastix
/usr/bin/ld.gold: error: cannot find -ltransformix
collect2: error: ld returned 1 exit status
make[5]: *** [Wrapping/Python/CMakeFiles/SimpleITK_PYTHON.dir/build.make:656: Wrapping/Python/_SimpleITK.so] Error 1
make[4]: *** [CMakeFiles/Makefile2:1986: Wrapping/Python/CMakeFiles/SimpleITK_PYTHON.dir/all] Error 2
make[3]: *** [Makefile:156: all] Error 2
make[2]: *** [CMakeFiles/SimpleITK.dir/build.make:88: SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/SimpleITK.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Maybe this error doesn't occur in your system. I tried on macOS Big Sur v11.6 (Apple clang version 12.0.0) and Fedora release 34 (clang version 12.0.1, gcc 11.2.1, GNU ld version 2.35.2-6.fc34).
I hope it helps!


Processing older data sets + additional suggestions

Issues and suggestions based on my experience as a new user of recorder:

The new version of recorder do not support the processing of single sheet tiff files (format in which older datasets are acquired and stored). The images from the older data sets cannot be reconstructed as they lack calibration data text files. The inclusion of swing parameter on the recorder reconstruction interface might be useful.

The names 'Global' and 'local' background correction in the background reconstruction section of recorder are counterintuitive. The names 'measured' background for corrections using background images, and 'estimated' background for fitted background is more intuitive.

Reconstructed background and sample images can be displayed in hsv colormap as default as it is more intuitive than grayscale colormaps.

Hi Soorya!
I have a few followup/clarification questions (I'm building up my knowledge base here too) but many of my comments lean on @mattersoflight:

The new version of recorder do not support the processing of single sheet tiff files (format in which older datasets are acquired and stored)

Have you been trying to process these datasets via the CLI or the napari plugin? My impression is Johanna's current workflow is to use recOrder.convert to convert these files to zarr then view/process them. Have you tried this?
@mattersoflight do we have plans/goals to process or convert single sheet tiffs.

The inclusion of swing parameter on the recorder reconstruction interface might be useful.

Are you looking to see the swing parameter that the data was collected with from the reconstruction interface? I think I like this idea, but I'm wondering if this leads to showing all of the metadata. Maybe this is what we want?

The names 'Global' and 'local' background correction in the background reconstruction section of recorder are counterintuitive. The names 'measured' background for corrections using background images, and 'estimated' background for fitted background is more intuitive.

Makes sense to me!

Reconstructed background and sample images can be displayed in hsv colormap as default as it is more intuitive than grayscale colormaps.

I like it too!

Soorya and I just spoke about analyzing old data that may not have swing metadata available. I'm a bit confused about this use case: is the swing metadata lost for a large fraction of old data that needs to be analyzed?
Do this mean we need the ability to (re)analyze all data with a user-selected swing value?
Thanks!

@mattersoflight and I just spoke and concluded that in the case where old data needs to be reanalyzed with a different/new swing value we can generate a config file "by hand" (likely by modifying an example).
Re: the other issues...I'll leave them open and address them later.
Thanks Soorya and Shalin.

Closing to split into #134, #136, #137.


API: DELETE /observations/:id doesn't returns what's documented

I encountered the following issue while working on Pyinaturalist.
When deleting an observation with the rest API (DELETE /observations/:id), your documentation shows an example where a proper JSON (occurrence details) is returned. In practice, it seems iNaturalist is returning an empty response body, with an HTTP status of 200.
Both options are fine for me, I just wanted to point the inconsistency. Tell me if you prefer to fix the documentation or the code, and I'll adapt Pyinaturalist to work with it.

Sorry about that, and about the late response. I updated the docs.


hard-coded number of parallel processes in infer function

The infer() function accepts an argument for the number of parallel processes to use, but then it hard codes the number of processes in the update xis step to be 2.  See below:
xis = _update_xis(sample_features,
                      difference_matrices,
                      difference_penalty,
                      gamma=gamma,
                      n_parallel_processes=2,
                      verbosity=0)

This forces inference to be very slow.

Fixed in #21


Bad fixes with E266: multiple-leading-hashes-for-block-comment

I'm trying out --preview with ruff 0.3.4. E266 which is a pycodestyle --preview rule has some weird fixes:

Probably should try to leave headers alone if the comment ends in one or more #

-##################################### FOO #############################################
+# FOO #############################################

Why is the space after the :?

-            #:::team.foo.bar.baz
+            #: ::team.foo.bar.baz

Weird example in https://docs.astral.sh/ruff/rules/multiple-leading-hashes-for-block-comment/#example

Use instead:

# Block comments:
#  - Block comment list
# \xa0- Block comment list

I think flagging it (and the way its fixed) is in line with the intent of the rule. You might want to disable E266 if you want to keep header comments with this specific format.

Pycodestyle both allows : or ! directly after the #

#: E265:2:1
m = 42
#! This is important
mx = 42 - 42
#: E266:3:5 E266:6:5

I assume what you find weird about it is the \xa0? Or is it something else

Pycodestyle also allows this style for headers:
#####
# Foo
#####

Thanks for the clarifications!

Probably should try to leave headers alone

TIL about the pycodestyle suggested header style, thanks. IMO since PEP 8 doesn't specify a header style, tools should be more permissive (but I understand the desire for compatibility with pycodestyle)

Why is the space after the :?

Pycodestyle both allows : or ! directly after the #

TIL that #: is for sphinx documentation, but the fact that pycodestyle supports this is undocumented.
FYI for #!: pycodestyle does not allow #! comment (except for shebangs on the first line) -- these comments result in E265 block comment should start with '# '

Weird example in https://docs.astral.sh/ruff/rules/multiple-leading-hashes-for-block-comment/#example
I assume what you find weird about it is the \xa0? Or is it something else

the \xa0 is weird and
the "use instead" doesn't seem to follow from the "example"
E.g. perhaps instead it should be

Example
### Public API
def say_hi():
    ## This is a block comment.
    print("hi")

Use instead
# Public API
def say_hi():
    # This is a block comment.
    print("hi")

or
Use instead
#############
# Public API
#############
def say_hi():
    # This is a block comment.
    print("hi")


Update protobuf-java to 3.19.3

Updates com.google.protobuf:protobuf-java from 3.19.1 to 3.19.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #1161.


cURL error when sending request through Plurk API

Hi, can anyone use Plurk API ? I have some problems about this API.
I tried to use Plurk API to upload picture via Guzzle 5, but I always got 400 Bad Request.
I also got the message : 'error_text' => string '40104:incorrect signature'.
Can anyone know this problem ? Thanks.
Here is my sample code:
https://gist.github.com/peter279k/4bad7cb1a5457a1dd27f57a658956434
Plurk API reference:
https://www.plurk.com/API#/APP/Timeline/uploadPicture

Please feel free to open an issue on Guzzle if you are reporting a reproducible bug. For general usage questions and integration, I suggest posting to StackOverflow.


[Feature Request]: Option To Play Podcast/Song Video When Available

This is a great extension that I have been using on a small display below my monitors, I think it would be great to make an option where you can view the video of a song or podcast (maybe add an option where it only plays the video if it is a podcast or a song) automatically when a podcast or song is played that has a video available in fullscreen.
I think there may be a better way of implementing this but a few toggles in the settings I feel would be plenty.
Please consider this!

That would be like creating a whole youtube player inside the extension, it can be done but I don't think it will look as good as Youtube Music! There will be no point in showing album art and lyrics on a video, so it would be just a video player, or If the video occupies only a small portion then it wouldn't make any sense.
This will be out of the scope of this extension, feel free to add a comment if you meant something else, I am closing the issue currently.


Failed to handle DCEP: invalid Message Type

Your environment.

Version: master--589d67e5abbb717be775d1709ebcdc8f93e646ad
Browser: chrome
Other Information - related issue: https://github.com/pion/datachannel/issues/125

What did you do?
create and close datachannels frequently, use those datachannels for short time communications.
What did you expect?
create data channel successfully
What happened?
datachannel ERROR: 2022/06/14 07:59:50 Failed to handle DCEP: invalid Message Type &{0 0 0 [103 97 116 101 119 97 121 45 105 79 83 45 49 54 53 53 49 57 51 53 56 57 46 54 54 54 52 51 54] []}

After studying the code, I guess it is about missing implementation of reusing data channel.

After studying the code, I guess it is about missing implementation of reusing data channel.

params := &webrtc.DataChannelParameters{
	ID: &a, // set id will it working
}


caf_eslz upgrade issue

custom_landing_zones variable expects subscription map to be passed in version 2108.0, which was not the case in version 2106.0
If this is passed and the subscription key is set to null, plan errors with the message "Invalid Index"

Got the plan working in the local version , by wrapping line 24 in custom_landing_zones.tf in a try function

Apologies, this issue should have been raised in the landing zones repository and not here. closing this issue here, Will open it in the landing zones repository


[Inclusive Language][Comments][Documentation] migrate "sanity" checks to "soundness" checks

Background
From the Swift Code of Conduct^0:

Examples of behavior that contributes to creating a positive environment include […] [u]sing welcoming and inclusive language (e.g., prefer non-gendered words like “folks” to “guys”, non-ableist words like “soundness check” to “sanity check”, etc.)

Our Swift repo still contains legacy and "deprecated" language in many places. Let's migrate those to something more inclusive! We can start with migrating "sanity checks" to "soundness checks". We already have some examples for a head start.^1 Let's keep this moving forward and build off this previous work.
Searching through the repo, we see three main categories of changes:

Comments and Documentation
Constant Strings
Symbols

Ranking from "least" to "most" risky to land without causing any bugs or unintended consequences, let's start here with migrating comments and documentation.
Changes
Here are our migrations:

sanity to soundness
sane to sound
insane to unsound
sanely to soundly

Test Plan
https://gist.github.com/vanvoorden/e46bcfd2ac6eb8eb37cf64165b8624ac
--- Build Script Analyzer ---
Build Script Log: /Users/rick/Developer/swift-project/build/.build_script_log
Build Percentage 	 Build Duration (sec) 	 Build Phase
================ 	 ==================== 	 ===========
70.6%             	 534.62                	 macosx-arm64-swift-build
19.2%             	 145.13                	 Building llvm
9.4%              	 71.5                  	 Building earlyswiftdriver
0.8%              	 5.76                  	 Building cmark
0.0%              	 0.06                  	 macosx-arm64-swift-test
0.0%              	 0.05                  	 macosx-arm64-swift-install
0.0%              	 0.04                  	 merged-hosts-lipo-core
0.0%              	 0.04                  	 macosx-arm64-extractsymbols
0.0%              	 0.04                  	 macosx-arm64-package
0.0%              	 0.04                  	 merged-hosts-lipo
Total Duration: 757.28 seconds (12m 37s)

I built swift from these changes locally and saw no errors.
Open Questions
A few Swift test files seem to contain comments that look like they might be mapping to symbols:
https://github.com/apple/swift/blob/main/test/DebugInfo/test-foundation.swift
// SANITY-DAG: !DISubprogram(name: "blah",{{.*}} line: [[@LINE+2]],{{.*}} DISPFlagDefinition

https://github.com/apple/swift/blob/main/test/SILOptimizer/access_marker_verify.swift
// call _sanityCheck(_:_:file:line:)

https://github.com/apple/swift/blob/main/test/SourceKit/CursorInfo/cursor_usr.swift
// RUN: %FileCheck %s -check-prefix=CHECK_SANITY1 < %t.from_offset.txt
// RUN: %FileCheck %s -check-prefix=CHECK_SANITY1 < %t.from_usr.txt

Does anyone have more context about these? Are these actually lowkey "symbols" that are defined or referenced somewhere else?
Next Steps
In future diffs, we can begin to migrate the remaining examples of noninclusive language (constant strings and symbols).
Acknowledgments
Thank you to @twostraws, @amartini51, and @Serena748 for beginning this important work!

@swift-ci please test

Thank you for this contribution! About the open questions:

// SANITY-DAG: !DISubprogram(name: "blah",{{.*}} line: [[@LINE+2]],{{.*}} DISPFlagDefinition

I'm not sure where this check prefix comes from.

// call _sanityCheck(_:_:file:line:)

This looks like just a comment that can be removed.

// RUN: %FileCheck %s -check-prefix=CHECK_SANITY1 < %t.from_offset.txt
// RUN: %FileCheck %s -check-prefix=CHECK_SANITY1 < %t.from_usr.txt

These run lines are specifying the prefix to use in the test. These can be changed as long as all of the // CHECK_SANITY1: comments are also changed to use the new prefix!

@phausler Hmm… it looks like https://github.com/llvm/llvm-project/pull/79531 might be the reason that test build failed… would a new test run pick up that latest change from llvm?

Thank you for this contribution! About the open questions:

@hborla Hmm… this diff already has some approvals on it… maybe I can try those changes in an independent diff for us to look at and test separately? Thanks!

@swift-ci please test macOS platform

@swift-ci please test macOS platform

@phausler @ktoso @mikeash Thanks for reviewing and approving! Do you think we are safe to land these changes now… or is it better to wait for every reviewer that got tagged and added here?

I think you can go ahead and press the button. We can be pretty confident that this change won't break anything!

I think you can go ahead and press the button.

I don't have an option to land AFAIK… does anyone with permission want to merge for me?

@vanvoorden merged. Thanks!


responsive footer

#19
desktop view

mobile view

@Min-Ho-Lim
I have added FontAwesome for social media icons.  Please, do let me know if you need any change.

Is there any reason to let the middle be blank and put the elements on the both sides?

As the user's screen gets bigger, the blank space will grow which is not good.
Try to gather them into middle, not sides.

You did not meet the acceptance criteria (Add Company name, description, about, working hours, locations)

Hello @Min-Ho-Lim I am confused about these things.

Do u want me to put locations as just a link or put on a smaller google map that you did in the location section of the page ?
about is it going to be just a link ?

Hi, I was thinking something like this for the first one.

About is just an about. Some description should be enough.

You can put anything.

I think I will put about location working hour on the middle on the footer to use the empty space. Give me your thought on this.

Sure. Try to do it and we will see how it goes.

Thanks, it looks good but need some adjustments.

Tablet responsiveness is missing

2. Remove hover effect for them

[x] tablet responsive
[x] remove hover


Update Object.xml

Update documentation based on this discussion: https://github.com/godotengine/godot-docs/issues/1968
I had positive feedback on this also from the Discord channel.

Thanks @akien-mga for everything, I'll keep the suggestion in mind for the next time.
Just another question: what about the failing CI build? Is it a problem that was already on master?
The command "if [ "$STATIC_CHECKS" = "yes" ];
then sh ./misc/travis/clang-format.sh;
else scons -j2 CC=$CC CXX=$CXX platform=$PLATFORM tools=$TOOLS target=$TARGET $EXTRA_ARGS $OPTIONS; fi"
exited with 127.

That's a bug that happens on Travis randomly when it can't download scons for OSX:
/Users/travis/.travis/job_stages: line 104: scons: command not found


feat: blockquoteIconColor theme variable

Pull Request Test Coverage Report for Build 420905889

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 73.615%

Totals

Change from base Build 420860514:
0.02%

Covered Lines:
1612

Relevant Lines:
1996

💛  - Coveralls


tensorRT does not support defining OP.

Use TensorFlow package: TFRA(https://github.com/tensorflow/recommenders-addons)
After saving the model, use tensorRT for model conversion:

TFRA code:
deep_dynamic_variables = dynamic_embedding.get_variable(
        name="deep_dynamic_embeddings",
        initializer=initializer,
        dim=embedding_size,
        devices=ps_list,
        trainable=is_training,
        partitioner=addone_partition_fn,
        checkpoint=True
    )

tensorRT conversion code:
import tensorflow as tf
import tensorflow_recommenders_addons as tfra
from tensorflow.python.compiler.tensorrt import trt_convert as trt

path = 'models/de'
converter = trt.TrtGraphConverterV2(input_saved_model_dir=path)
converter.convert()

converted_model_path = 'models/c'
converter.save(converted_model_path)

Error message:
KeyError: "The name 'deep_dynamic_embeddings' refers to an Operation not in the graph."

@Mr-Nineteen ,
In order to expedite the trouble-shooting process, could you please provide the following information
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version:
Python version:
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
and the the exact sequence of commands / steps that you executed before running into the problem
Thanks!

@tilakrayal
The verification is the fusion of TFRA and TRT, without using the GPU environment.
conda env：

python version : 3
TF related installation library:

tensorflow                     2.4.1
tensorflow-datasets            4.2.0
tensorflow-estimator           2.4.0
tensorflow-metadata            0.29.0
tensorflow-recommenders-addons 0.1.0

Test model address: https://github.com/Mr-Nineteen/models/blob/main/1617949817.zip
test code：

import tensorflow as tf
import tensorflow_recommenders_addons as tfra
from tensorflow.python.compiler.tensorrt import trt_convert as trt

path = '1617949817'
converter = trt.TrtGraphConverterV2(input_saved_model_dir=path)
converter.convert()

converted_model_path = 'c'
converter.save(converted_model_path)

Error message:

Traceback (most recent call last):
  File "/Users/dxwang/repo/pycharm-repo/tensorflow-2.0-demo/com/opensource/demo/tftrt/trtconvert-yz.py", line 8, in <module>
    converter.convert()
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/compiler/tensorrt/trt_convert.py", line 1094, in convert
    self._input_saved_model_tags)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/saved_model/load.py", line 859, in load
    return load_internal(export_dir, tags, options)["root"]
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/saved_model/load.py", line 909, in load_internal
    root = load_v1_in_v2.load(export_dir, tags)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/saved_model/load_v1_in_v2.py", line 279, in load
    return loader.load(tags=tags)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/saved_model/load_v1_in_v2.py", line 225, in load
    signature=[])
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/eager/wrap_function.py", line 628, in wrap_function
    collections={}),
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/framework/func_graph.py", line 990, in func_graph_from_py_func
    func_outputs = python_func(*func_args, **func_kwargs)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/eager/wrap_function.py", line 87, in __call__
    return self.call_with_variable_creator_scope(self._fn)(*args, **kwargs)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/eager/wrap_function.py", line 93, in wrapped
    return fn(*args, **kwargs)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/saved_model/load_v1_in_v2.py", line 93, in load_graph
    meta_graph_def)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1485, in _import_meta_graph_with_return_elements
    **kwargs))
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/framework/meta_graph.py", line 886, in import_scoped_meta_graph_with_return_elements
    ops.prepend_name_scope(value, scope_to_prepend_to_names))
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3726, in as_graph_element
    return self._as_graph_element_locked(obj, allow_tensor, allow_operation)
  File "/Users/dxwang/opt/anaconda3/envs/tfra/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3786, in _as_graph_element_locked
    "graph." % repr(name))
KeyError: "The name 'deep_dynamic_embeddings' refers to an Operation not in the graph."

Thanks!

@ymodak,
I was able to reproduce the issue with TF v2.4.1, please find the gist of it here.
Whereas with TF v2.5.0rc1 and TF-nightly, the dependency tensorflow-recommenders-addons is not compatible. Thanks!

Did you try converting your model using tf.experimental.tensorrt.Converter()?

@ymodak  it's ok, thx.


Development target iOS 8 unable to install via cocoa pods

Specs satisfying the SwiftyPlistManager dependency were found, but they required a higher minimum deployment target.

Thanks for the suggestion. Just decreased to iOS8


Capnsquirrel/chemist

In this PR:

Chemist helpful vial
Chemist Flammable vial
Chemist Aggression vial (unstable)
Chemist Random vial
Implemented Structures via DamagableStructure

Underlying changes for various systems:

Refactored PlayerBehaviour, EnemyController, Damagable, DamagableEnemy, DamagablePlayer to adhere to an event/event-handler system.
Players, structures, and enemies have modifiable properties via public methods.

Tried out the scene, and there was a bug with the zombies getting slowed down too much, but the PR is still in a merge-able state.
Making a trello card for the zombie slow puddle bug.


Move from net to netip

This PR moves cidranger from using the IP address/prefix values from the "net" module in the Go standard libary to using the equivalents from the newer "net/netip" in the standard library. This allows for some code simplification:

no need to check for invalid underlying []byte lengths or nil pointers
netip.Prefix can be used directly as a map key in bruteranger as opposed to a net.IPNet's .String() value
address comparisons can be done directly with ==/!= as opposed to via bytes.Equal()

The tests were updated to use net/netip, and run successfully. TestInsertError and TestRemoveError were removed, as the error they are testing for is impossible to induce with net/netip
This is a fairly big update, and since it changes a good chunk of the API, likely warrants a version bump, though I am opening this PR to at least see if this is a change that you are interested in and if you have any changes in mind.
net/netip was introduced in 1.18, and, as 1.19 is out now, all officially supported versions of Go (the last two releases) support this, though applications and libraries making use of cidranger would need to be rewritten or at least add wrapper code to handle this, if this version is used.

It would also implicitly fix the issue outlined in PR https://github.com/yl2chen/cidranger/pull/30 and issue https://github.com/yl2chen/cidranger/issues/42, as net/netip handles IPv4-mapped IPv6 addresses far better than net.

This would be a breaking change, and thus would require a 2.x release.
If we're going to break compatibility, we might as well include other valuable changes, such as a switch from use of exposed interfaces (Ranger, RangerEntry) to using concrete types with generics. I believe the Ranger interface itself is just an anti-pattern, while RangerEntry is perhaps intended to allow associating data with a key, which generics would do in a cleaner and cheaper way since Go 1.18.

For example, https://github.com/monoidic/cidranger/pull/1 is an incomplete/WIP adjustment of the API for generics building upon this PR.

FYI to those looking for this, I’m going to try out https://github.com/gaissmai/bart as a replacement, might be useful to others


Making the social handles links open in a new tab

By making the links of social handles like LinkedIn and Insta in another tab instead of the same one, it provides the user better experience and he/she can switch between your social page and website easily without having to use the back button.

Please assign me this issue


Update create-client-certificate.md

Grammar 'recommend'.

@jbizcloud : Thanks for your contribution! The author(s) have been notified to review your proposed change.


feat: new rule no-class-inheritance

Fix #000
Proposed Changes

#890  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on  Graphite


feat: allow layer deployment for nodejs

This CL allows users to deploy lambda layer manually.
The interactive shell is missing, only nodejs support, but it should be
enough for the initial support.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #4112 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4112      +/-   ##
==========================================
+ Coverage   60.64%   60.75%   +0.11%
==========================================
  Files         327      326       -1
  Lines       14359    14332      -27
  Branches     2858     2850       -8
==========================================
  Hits         8708     8708
+ Misses       5215     5188      -27
  Partials      436      436

Impacted Files
Coverage Δ

packages/amplify-util-mock/src/mockAll.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf476e2...4aa553f. Read the comment docs.

Hi @hirochachacha, we're looking to create a more comprehensive experience with all supported runtimes and a few other features on Lambda Layer release. This would unfortunately conflict with our Lambda Layers implementation and could cause issues between CLI versions if we merged this beforehand.
I totally understand that you (and many others!) want this feature asap, but we are still diligently working on building out this feature. As a temporary work-around you could use your personal fork and run a locally built amplify-dev.

@jhockett

Hi @hirochachacha, we're looking to create a more comprehensive experience with all supported runtimes and a few other features on Lambda Layer release. This would unfortunately conflict with our Lambda Layers implementation and could cause issues between CLI versions if we merged this beforehand.

Are you worried about concrete issue or hypothetical one?
Actually I can easily create comprehensive design by myself, but I don't think you guys will accept the PR. I've been sending few PRs to this project since 4 months ago, and I learned something. You guys are unwilling to accept PRs outside of the team. right? Trivial one is OK, but influential one is always ignored. I feel like I always hit NIH.
That's why I tried to start from small one here, but it looks like I failed it again. No idea.
Could you tell how can I convince you? Or is it impossible as I predicted?

I totally understand that you (and many others!) want this feature asap, but we are still diligently working on building out this feature. As a temporary work-around you could use your personal fork and run a locally built amplify-dev.

Of course, we have been using the temporary work-around for 4 months. What's the definition of comprehensive experience? We don't see any problems so far.

@edwardfoyle Could you show me your plan? Will it conflict with this? Whether there're other ideas, I thought deployment part is almost same.

Supporting python should be trivial. dotnet needs https://github.com/aws/aws-extensions-for-dotnet-cli/issues/79. java uses gradle, so replacing 'lib' with 'java/lib' is good enough. https://github.com/aws-amplify/amplify-cli/blob/master/packages/amplify-java-function-template-provider/resources/lambda/hello-world/build.gradle.ejs#L24. go doesn't have stable implementation of shared library so far. Deployment feature and interactive shell feature are orthogonal. Where did you find the confliction?

And ruby? https://github.com/hirochachacha/amplify-cli/commit/c14ba436745104c5c3da9ab4de861a73f202e201

@hirochachacha - first off, I want to thank you for contributing to Amplify CLI and pushing the boundaries of what's possible. We are actively working on Lambda Layer support and hopefully we can share more about it soon with you.
One element that we find really valuable in all this is the Ruby support for Lambda functions that you've developed. If you're interested to upstream that into the Amplify CLI codebase, you can create a separate PR just for Ruby support. @jhockett and I can work with you to get that functionality integrated into Amplify CLI.
We love your contributions. We recommend you to create an issue before contributing large PRs though as there are many moving pieces that we need to align. Please refer to the contribution guidelines for more details: https://github.com/aws-amplify/amplify-cli/blob/master/CONTRIBUTING.md


Multi-system output in example table

This PR changes the view of Example Table for pairwise / multi-system analysis in the tasks listed below,

machine-translation
summarization
conditional_generation
text-classification
text-pair-classification

New Look for Supported Tasks
As shown in the image below, system's predictions will enumerate to the right, columns will be in the format {system name}: {prediction property}

The Look for Not-Supported Tasks
For tasks which are not supported yet, it will be in the Tab Pane format like before:

How to change tasks from not supported to supported
To display multiple system outputs in the AnalysisTable, the task needs to be defined in frontend/src/components/Analysis/AnalysisTable/supportedTasks.tsx.
For each task, we need to define

datasetColumns: columns which are dependent on the task and dataset (should be the same for different systems on the same dataset). i.e., source, text, true_label
predictionColumns: columns which are dependent on the system, e.g. columns related to predictions

For example, here are the columns for "text-classification"
taskTable.set("text-classification", {
  datasetColumns: [
    { id: "text", name: "Text", maxWidth: "400px" },
    { id: "true_label", name: "True Label" },
  ],
  predictionColumns: [{ id: "predicted_label", name: "Predicted Label" }],
});

I can either add NER in this PR or create another PR for it.

@neubig Thanks for the useful feedbacks! I have addressed all of them in the latest commits, please take a look.


Semantic UI for Angular 2

Please consider creating  Angular 2 components for amazing Semantic UI modules without Jquery dependency.

Hello, @ansarizafar
We are working to change the structure of the project and migrate to 1.4 with angular typescript. After that we already have plans to migrate to angular 2.
Thanks for the suggestion, it is a very important point.

+1

+1

@matheuspoleza Ping me when you start the on Angular2. I may be able to help.

We're going to focus on angular 1 for now, once angular 2 will get animations support we will be working on angular 2 components.


Flickering when switching themes

open some source code (e.g. of type Java)
Open the theme switcher dialog
go through the themes
note that the token colors flicker
it looks to me (from debugging at ViewLine.renderLine) that there is a moment where each line has all scopes removed from the lines, and that all text gets draws with the default foreground color (mtk1)

This is by design. Tokens from the previous theme point to color ids that make no sense in the new theme. That's why when switching a theme, we reset all tokens to the default foreground color.


[2.0-M2] regression in fetchplan when depth-level is set to 1

Hi,
I don't know if this is a bug or a feature:
I have a record that has some links to other records belonging to a class that extends ORestricted.
When I executed a statement like:
select @this.tojson("fetchPlan:visibleByFriends:1,indent:0") from _bb_user

I have different results between OrientDB 1.7.x and OrientDB 2.0-M2
If the user that is actually executing the statement does not have the right to read the visibleByFriends property, the 1.7.x version returns a JSON similar to:
{"visibleByTheUser":null}

the 2.0-M2 returns the RID of the linked record:
{"visibleByTheUser":"#14:31"}

still present in 2.0.7

@giastfader Please could you provide a test case that reproduce this problem?

The issue has been closed because no response has been received after a while. In case the issue is still valid, please reopen it or write a comment that explains why it's still valid and a way to reproduce it. Thank you.

Hi guys,
sorry, I missed the reply.
The issue is still valid, for me, against 2.1.2 GA Community Edition.
Here is the steps to reproduce the problem:
connect plocal:/databases/test_issue_2906 admin admin
create class _bb_user
create class _BB_UserAttributes extends ORestricted
create property _BB_User.visibleByAnonymousUsers link _BB_UserAttributes
insert into _BB_UserAttributes set email =<EMAIL_ADDRESS>insert into _bb_user set _author="me", visibleByAnonymousUsers = #13:0 --<-- according to the output of the previous statement

connect plocal:/databases/test_issue_2906 reader reader
select @this.tojson("fetchPlan:visibleByAnonymousUsers:1,indent:0") from _bb_user

OrientDB 1.7.9:
{"_author":"me","visibleByAnonymousUsers":null}

OrientDB 2.1.2:
{"visibleByAnonymousUsers":"#13:0","_author":"me"}


Release 0.3.0

✔ Related issues

Closes #83

📑 Description

#84

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

✅ This pull request is verified to build.


upload tests and codecov in makefile achieved 96% codecov

Codecov Report

Merging #24 (b55f7ed) into master (663ed15) will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   94.40%   95.96%   +1.56%
==========================================
  Files           5        5
  Lines         250      248       -2
==========================================
+ Hits          236      238       +2
+ Misses         14       10       -4

Impacted Files
Coverage Δ

service/model.py
100.00% <ø> (+1.28%)
:arrow_up:

service/route.py
100.00% <0.00%> (+2.94%)
:arrow_up:

service/error_handlers.py
81.25% <0.00%> (+3.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663ed15...b55f7ed. Read the comment docs.


Add back NN Assigned status - needed for proper map rendering

Turns out we need to keep track of when an install has its NN reassigned to someone else, so that we don't double-render it on the map. This PR adds it back so that we can use it in a follow up PR to fix the map

Please change the function name and change the status to REASSIGNED_AS_NN

We had a phonecall


Add mapWithAccum to FRP.Event

The Event class now exports the mapWithAccum function. There was originally concern that this would cause a huge composition chain, and thus not be performant for events over a long period. However, I've expanded the point-free folding function definition, so it's hopefully now a bit clearer that it shouldn't happen. As always, though, @paf31, do tell me if I'm being ignorant! :D

Can we call this mapAccum, to match the list libraries? Thanks.

Of course - sorry, should probably have spotted that :flushed:

Thanks!


Fixed fetch include/exclude examples, should not have '='

Doh! I just thought you used some weird alternate syntax :)


Add docs linting rule to disallow relative directory links

Proposed Changes
Per https://github.com/mkdocs/mkdocs/issues/1854, mkdocs only validates file-relative links (../installation/index.md) and by design does not validate directory-relative links (../installation/). I'm working on a PR to fix our existing documentation links to follow the validated standard. But it would be very useful to add a docs linting rule to detect and disallow directory-relative links so that they don't creep back in inadvertently.
Justification
Let's use tooling to enforce that our documentation follows best practices and avoid broken links in our docs.

I am finishing up a markdownlint Custom Rule to flag these, would you mind assigning this to me?


Use OneSignal to send web push notifications

Setup
Activate GetStream.io webhook
The kitsu server are now listening to GetStream.io realtime update via webhook we provided. Simply set notification feed group to push updates to kitsu.io/api/hooks/getstream.
The webhook controller will process and send notifications to the user who has subscribed to OneSginal.
Integrate OneSignal in client app
In order to send web notification to our kitsu users, a unique player_id is required by OneSignal.  (Implement OneSignal SDK)[https://documentation.onesignal.com/docs/web-push-sdk] to prompt the user to register and send the update to user's one_signal_id through the user update API.
Handle unsubscribe or user who haven't subscribed
Whenever the user one_signal_id is missing, means that either he has disabled the notification from the browser or haven't subscribed the web push. In this case, I think we should prompt the user to register again or we could discuss something better to handle this case.

The logic looks about right, but can you fix the conflicts and the failing spec?

Fixed spec, only the weird FactoryGirl test failed and we could ignore that for now.

@NuckChorris Please check the latest updates. Now user can subscribe to one signal with multiple devices and all devices will get notified.


Only parallelize flowgraphs with aggregations

closes #1204

After an internal discussion we decided not to do this due to the performance implications. We will instead leave these parallelizations in place, and at some point we'll do #1215 to ensure deterministic outputs.


API rate limit issue when running multiple jobs

I am running 40 jobs at the same time in action, each job runs dblock/create-a-github-issue.
And some of them will report an error:
API rate limit exceeded for installation ID xxxx:

This is the crate-a-github-issue part of the action:
    - uses: dblock/create-a-github-issue@v3
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      with:
        update_existing: true
        search_existing: all

Full info: https://github.com/microcai/gentoo-zh/runs/5345190401?check_suite_focus=true

AFAIK the limit is 5000 API calls per hour, or ~80 calls per minute, not sure how much we can do about it, other than automatic sleep/retry?

AFAIK the limit is 5000 API calls per hour, or ~80 calls per minute, not sure how much we can do about it, other than automatic sleep/retry?

AFAIK the limit is 5000 API calls per hour, or ~80 calls per minute, not sure how much we can do about it, other than automatic sleep/retry?
https://stackoverflow.com/questions/13394077/is-there-a-way-to-increase-the-api-rate-limit-or-to-bypass-it-altogether-for-git

Thank you for your reply.
The problem on my side is that there are a lot of independent jobs running at the same time, each of which fetches an existing issue.
So I'm going to try to do it manually using a script.


Clean up branches

Once things are fully tested and stable, will need to go through and clean up the old branches

This is not really an issue, can be cleaned at a later date.


Remove form from the basket line formset and bypass its validation if related model instance does not exist any more.

Fixes #2873

I think it's worth adding tests for this - to ensure that a formset containing such a form still validates properly.

Tests added.


Generate query that will return state, county, city, zipcode by country

I would like to know if I can use you library to generate a query that will return state, county, city, zipcode or any admi level by country

I got help from someone else. Thanks


Test codecov

Codecov Report

Merging #46 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   83.05%   82.64%   -0.42%
==========================================
  Files         195      194       -1
  Lines       15293    15216      -77
==========================================
- Hits        12702    12575     -127
- Misses       2591     2641      +50

Impacted Files
Coverage Δ

texar/torch/data/data/data_iterators.py
57.24% <0%> (-25%)
:arrow_down:

texar/torch/data/data/scalar_data.py
97.91% <0%> (-2.09%)
:arrow_down:

texar/torch/core/layers.py
87.7% <0%> (-0.54%)
:arrow_down:

texar/torch/data/data/data_iterators_utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17d502...7b2cd6f. Read the comment docs.


Improved speed, modified snow example, and removed resizing

Improved speed by using fputs instead of write()
Modified snow example
Removed resizing due to unfixable SIGSEGV's
Added newlines to the buffer so that the image is not slanted when the terminal is scaled up
If the terminal is made smaller then the image will not come out correctly
TGOL now has dead cell coloring and random setting
Previous text is now put in the scrollback buffer unless you save it
Improved speed by having the \e[H added to the buffer
Stopped clfps* from clearing the screen

Nice!
Removed bruh.txt isn't an ideal commit name 🤣