@Streaming with slow internet connection (for example GPRS) returns SocketTimeoutException

I have to download a file (30mb).
When I work on Emulator with internet connection sets to full or LTE, or when I work on real device with LTE SIM card everything works well, but when I change internet connection in emulator to GPRS or on real device I use GPRS then connection returns SocketTimeoutException after +- 40 seconds:
java.net.SocketTimeoutException: timeout
        at okhttp3.internal.http2.Http2Stream$StreamTimeout.newTimeoutException(Http2Stream.kt:677)
        at okhttp3.internal.http2.Http2Stream$StreamTimeout.exitAndThrowIfTimedOut(Http2Stream.kt:686)
        at okhttp3.internal.http2.Http2Stream$FramingSource.read(Http2Stream.kt:382)
        at okhttp3.internal.connection.Exchange$ResponseBodySource.read(Exchange.kt:276)
        at okio.RealBufferedSource.read(RealBufferedSource.kt:189)
        at okio.ForwardingSource.read(ForwardingSource.kt:29)
        at retrofit2.OkHttpCall$ExceptionCatchingResponseBody$1.read(OkHttpCall.java:314)
        at okio.RealBufferedSource.request(RealBufferedSource.kt:206)
        at okio.RealBufferedSource.require(RealBufferedSource.kt:199)
        at okio.RealBufferedSource.readByte(RealBufferedSource.kt:209)
        at com.examplePackage.actualizationFeature.data.repositories.ActualizationRepositoryImpl.saveFile(ActualizationRepositoryImpl.java:148)
        at com.examplePackage.actualizationFeature.data.repositories.ActualizationRepositoryImpl.save(ActualizationRepositoryImpl.java:117)
        at com.examplePackage.actualizationFeature.domain.usescases.DownloadActualizationUseCase.lambda$invoke$1$com-examplePackage-actualizationFeature-domain-usescases-DownloadActualizationUseCase(DownloadActualizationUseCase.java:43)
        at com.examplePackage.actualizationFeature.domain.usescases.DownloadActualizationUseCase$$ExternalSyntheticLambda7.call(Unknown Source:4)
        at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
        at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
        at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
        at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:644)
        at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
        at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)`

I tried to change the timeouts to much longer ones (10 min). The only difference is that the error occurs later (between 3 - 6 min).
My current settings are as follows:
new OkHttpClient.Builder()
.connectionSpecs(specList)
 .sslSocketFactory(sslSocketFactory, (X509TrustManager) trustManagers[0])
.connectTimeout(30, TimeUnit.SECONDS)
 .readTimeout(30, TimeUnit.SECONDS)
 .writeTimeout(15, TimeUnit.SECONDS)

In wireshark I see that device cant release Window buffer:

What I use (the response may come as .apk or JSON thats why I read first byte in save function):
new Retrofit.Builder()
                .baseUrl(url)
                .client(okHttpClient)
                .addConverterFactory(GsonConverterFactory.create())
                .addCallAdapterFactory(RxJava3CallAdapterFactory.createWithScheduler(Schedulers.io()))
                .build();

@GET
    @Streaming
    Single<Response<ResponseBody>> downloadFile(@Url @NonNull final String url);

repository.downloadFile(
                getFirmwareUrl())
                .concatMap(responseBody -> {
                    if (responseBody.isSuccessful())
                        return Single.fromCallable(() ->repository.save(responseBody.body())).subscribeOn(Schedulers.io());
                    else
                        return Single.error(new Throwable("Błędna odpowiedź serwera"));
                })

public Result<Void> save(ResponseBody responseBody) {
        try {
            Logs.d(TAG, "retrofitSaveFile: path: " + DOWNLOADED_PATH);
            File file = new File(DOWNLOADED_PATH);
            if (!file.exists()) {
                if (!file.mkdirs())
                    return Result.ERROR(new Throwable("Nie można utworzyć pliku"));
            }
            File outputFile = new File(file, file_name);
            if (outputFile.exists()) {
                if (!outputFile.delete())
                    return Result.ERROR(new Throwable("Nie można usunąć pliku"));
            }
            FileOutputStream ffos = new FileOutputStream(outputFile);
            DataOutputStream fos = new DataOutputStream(ffos);
            final BufferedSource source = responseBody.source();
            long lengthOfFile = responseBody.contentLength();
            final int firstByte = source.readByte();
            if (firstByte == '{') {
                saveFile(fos, source, lengthOfFile);
            } else {
                save2File(fos, source, lengthOfFile, firstByte);
            }
            fos.flush();
            fos.close();
            source.close();
            return Result.SUCCESS();
        } catch (Throwable throwable) {
            Log.e(TAG, "save: ", throwable);
            return Result.ERROR(new NetworkExceptions.DownloadingException());
        }
    }

private void save2File(DataOutputStream fos, BufferedSource is, long lengthOfFile, int firstByte) throws IOException {
        int count;
        byte[] data = new byte[1024];
        long total = 0;
        fos.write(firstByte);
        while ((count = is.read(data)) != -1) {
            total += count;
            fos.write(data, 0, count);
        }
    }

In Network Inspector it looks like:

If connection  is LTE it looks:

Im getting in Response.source() inputStream with ~8091 bytes of data but waiting for next bytes takes a lot of time (second part ~20s, third part ~40s etc)

I tried with UrlHttpConnection - the same. I think the problem might be coused by OkHttp. Can you move this issue to OkHttp?

If it's happening with UrlHttpConnection, doesn't that suggest it's not OkHttp?  UrlHttpConnection uses a very old version of OkHttp in a different package which is essentially unrelated now.

As for the actual problem, A bit more detail at the HTTP/2 frame level or with wireshark could help.
If you need to see HTTP/2 Frames https://stackoverflow.com/a/66398538/1542667
If you can reproduce on a JVM - you can enable wireshark key export https://stackoverflow.com/a/66399777/1542667

The IO bits can turn into a handful of lines with Okio, especially with okio-filesystem

UrlHttpConnection with OkHttp (I need to use self signed certificates) - thats why I think that problem is in OkHttp. But in my test (below) I dont use OkHttp and even other sever, so I dont know.

Code nits, I doubt any of it explains the problem:

Are you always closing the response or responsebody when you return Result.ERROR?

Yes

"why I read first byte in save function" -> use peekBody() or check the content type instead, should simplify the code.

You have right. Thanks

If you need to see HTTP/2 Frames https://stackoverflow.com/a/66398538/1542667

This is log from running application
retrofix_log_1.txt
I also created a test:
public class ProducerServiceTest {
    String download = "https://aclas.pimka.net/test.bin";

    @Test
    public void test() throws InterruptedException {
        Single.defer(() ->
                Single.fromCallable(() ->
                        new Retrofit.Builder()
                                .baseUrl("http://retrofit.pl")
                                .addCallAdapterFactory(RxJava3CallAdapterFactory.createWithScheduler(Schedulers.io()))
                                .addConverterFactory(GsonConverterFactory.create())
                                .build()
                                .create(ProducerService.class)))
                .flatMap(producerService -> producerService.downloadFile(download))
                .map(response -> response.body().source())
                .map(bufferedSource -> {
                    int size = 0;
                    try {
                        while (!bufferedSource.exhausted()) {
                            size += bufferedSource.readByteArray().length;
                        }
                        return size;
                    } catch (Exception e) {
                        System.out.println("size: " + size);
                        System.out.println(e);
                        throw e;
                    }
                })
                .test()
                .await()
                .assertValue(24210616)
                .assertComplete();
    }

}

PoducerService.class
public interface ProducerService {
    @Streaming
    @GET
    Single<Response<ResponseBody>> downloadFile(@Url @NonNull final String url);
}

And still works bad. When you run this code on emulator with internet full speed test will pass, but on GPRS fails.
FAIL:
test_fail.txt
SUCCESS:
test_complete.txt

Thanks for your question. This issue tracker is only for bug reports with test cases and feature requests. Please ask usage questions on Stack Overflow.
https://stackoverflow.com/questions/tagged/okhttp

This is a bug.
The library does not allow to download 20mb with a slow connection (GPRS) because it returns an exception.
This test case is written for you to show you when the error occurs.
Fails after ~8min

This is a bug.
The library does not allow to download 20mb file with a slow internet
connection (GPRS) because it returns an exception.
This test case is written for you to show you when the error occurs.
Fails after ~8min. Library doesnt release buffer and when server is trying
to send data receives TCP ZEROWINDOW
[image: image.png]
wt., 5 kwi 2022 o 13:36 Jesse Wilson @.***> napisał(a):

Closed #7215 https://github.com/square/okhttp/issues/7215.
—
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/7215#event-6370466814, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXEGXJJ3RWSERMC6ACASETVDQQTXANCNFSM5SQEIJCQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Jacek Gaweł


Difference between React Native Core's implementation?

Question
I understand this package is created in an effort to decouple React Native's core library from specific components. Is this supposed to be a mirror of React Native's PushNotificationIOS implementation or will all new commits to React Native's PushNotificationIOS be migrated here once it is deprecated?
If that's the case, should I be using this package or that from the core? I'm trying to write some TS types for this package so that I can use it in my project, but there is also a large discrepancy between @types/react-native and its actual implementation here and in the core package.

The PushNotificationIOS implementation in react-native core is indeed deprecated and should not be used.


测试

~

Why do you want to merge your website in the original repo?
I believe that you got something wrong :)

I am a novice, just contact GitHub, thank you.
English is not good,sorry.

No problem! :wink:


TransactionCost - remove allocation

Problem

TransactionCost holds an allocation to track writable accounts. This is generally not needed since we can always figure out which accounts the transaction writes since the transaction stays in scope longer than TransactionCost
Doing the allocation and free is also bad for performance

Summary of Changes

Remove writable_accounts from TransactionCost

Fixes #

cost_tracker benches:
master:
test bench_cost_tracker_contentious_transaction     ... bench:   4,341,232 ns/iter (+/- 96,382)
test bench_cost_tracker_non_contentious_transaction ... bench:   6,784,462 ns/iter (+/- 142,771)

PR:
test bench_cost_tracker_contentious_transaction     ... bench:   3,542,738 ns/iter (+/- 52,597)
test bench_cost_tracker_non_contentious_transaction ... bench:   5,616,565 ns/iter (+/- 99,960)

cost model benches (from #2168):
master:
test bench_cost_model                       ... bench:     988,185 ns/iter (+/- 33,633)
test bench_cost_model_requested_write_locks ... bench:   1,077,616 ns/iter (+/- 12,925)

PR:
test bench_cost_model                       ... bench:     818,381 ns/iter (+/- 20,589)
test bench_cost_model_requested_write_locks ... bench:     814,116 ns/iter (+/- 48,559)

More room for improvement here, this is slower than I'd like. But this PR is a step in the right direction.

Yeah I like that more than the iterator interface


perf: reduce allocations in Json.compress

Remove the need to allocate an intermediate String for literally every character in a JSON String.
Use a single String buffer in the entire Json.compress machinery.
Use toListAppend

Number 1 is doing most of the lifting in the perf diff, the rest are some minor but measurable improvements.

!bench

!bench


Some functions could be static instead of exterior to classes

I am basing a tool on pie, inheriting from most classes. My data input is somewhat different, so of course I need to change some functions.
There is a lot of places though where I think I am copying/pasting and correcting just because a function from the same module was used instead of making it a class method.
Example: in scorer, "compute_scores" is a function of the module. From what I see, this is the only place where it's used. If it were a staticmethod of Scorer, I would not need to rewrite the get_score function
https://github.com/emanjavacas/pie/blob/47be46f9d788a8f11ef559b1b23a932ec074a572/pie/models/scorer.py#L88-L123
https://github.com/emanjavacas/pie/blob/47be46f9d788a8f11ef559b1b23a932ec074a572/pie/models/scorer.py#L31-L41
If you agree, I could PR as I go along ;)

Fine by me. If you feel you can reuse this code as is, it's of course better to refactor as you suggest! Hopefully it is not too much work for you.

I am closing this but feel free to submit the PR whenever.


mode: git-local not having any impact

I'm trying to use the git sha for the commit number by changing mode: git-local, but when I call php artisan version I get APP version 1.0.0 (commit 100001) instead of the sha. What am I doing wrong?
According to the documentation, I should run php artisan version:refresh but I get a command not defined error.
mode: 'absorb' # or 'increment'
blade-directive: version
current:
  label: v
  major: 1
  minor: 0
  patch: 0
  prerelease:
  buildmetadata:
  commit: 100001
  timestamp:
    mode: absorb
    year:
    month:
    day:
    hour:
    minute:
    second:
    timezone:
commit:
  mode: git-local
  length: 6
  increment-by: 1
git:
  from: 'local' # or "remote"
  commit:
    local: 'git rev-parse --verify HEAD'
    remote: 'git ls-remote {$repository}'
  branch: refs/heads/master
  repository: '' ### you can use config() to get it here: {{ config('version.git.remote.repository') }}. Do not use env()
  version:
    local: 'git describe'
    remote: 'git ls-remote {$repository} | grep tags/ | grep -v {} | cut -d / -f 3 | sort --version-sort | tail -1'
    matcher: '/^(?P<label>[v|V]*[er]*[sion]*)[\.|\s]*(?P<major>0|[1-9]\d*)\.(?P<minor>0|[1-9]\d*)\.(?P<patch>0|[1-9]\d*)(?:-(?P<prerelease>(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+(?P<buildmetadata>[0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/'
  timestamp:
    local: 'git show -s --format=%ci'
    remote: 'git show -s --format=%ci origin/master' ## we will have to find a better way
format:
  regex:
    optional_bracket: '\[(?P<prefix>.*?)(?P<spaces>\s*)(?P<delimiter>\?\=)(?P<optional>.*?)\]'
  label: "{$label}"
  major: "{$major}"
  minor: "{$minor}"
  patch: "{$patch}"
  prerelease: "{$prerelease}"
  buildmetadata: "{$buildmetadata}"
  commit: "{$commit}"
  version: 'version {$major}.{$minor}.{$patch} (commit {$commit})'
  version-only: 'version {$major}.{$minor}.{$patch}'
  ## Bracket enclosed expressions "[.?{$variable}]" are only rendered if the ?={$variable} is filled
  full: '{$version-only}[.?={$prerelease}][+?={$buildmetadata}] (commit {$commit})'
  compact: "v{$major}.{$minor}.{$patch}-{$commit}"
  timestamp-year: '{$timestamp.year}'
  timestamp-month: '{$timestamp.month}'
  timestamp-day: '{$timestamp.day}'
  timestamp-hour: '{$timestamp.hour}'
  timestamp-minute: '{$timestamp.minute}'
  timestamp-second: '{$timestamp.second}'
  timestamp-timezone: '{$timestamp.timezone}'
  timestamp-datetime: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second}'
  timestamp-full: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second} {$timestamp.timezone}'
  ## add as many formats as you need !!!!

changing
commit:
  mode: git-local
  length: 6
  increment-by: 1

to
commit:
  mode: absorb
  length: 6
  increment-by: 1

fixed this for me

I'm having the same issue and the solution above doesn't work

I have same problem. I have no idea how can i get commit hash from local / remote git repo. I'm attaching my config code below
mode: 'absorb' # or 'increment'
blade-directive: version
current:
  label: v
  major: 1
  minor: 0
  patch: 0
  prerelease:
  buildmetadata:
  commit: 100001
  timestamp:
    mode: absorb
    year:
    month:
    day:
    hour:
    minute:
    second:
    timezone:
commit:
  mode: absorb
  length: 6
  increment-by: 1
git:
  from: 'local' # or "remote"
  commit:
    local: 'git rev-parse --verify HEAD'
    remote: 'git ls-remote {$repository}'
  branch: refs/heads/master
  repository: '' ### you can use config() to get it here: {{ config('version.git.remote.repository') }}. Do not use env()
  version:
    local: 'git describe'
    remote: 'git ls-remote {$repository} | grep tags/ | grep -v {} | cut -d / -f 3 | sort --version-sort | tail -1'
    matcher: '/^(?P<label>[v|V]*[er]*[sion]*)[\.|\s]*(?P<major>0|[1-9]\d*)\.(?P<minor>0|[1-9]\d*)\.(?P<patch>0|[1-9]\d*)(?:-(?P<prerelease>(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+(?P<buildmetadata>[0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/'
  timestamp:
    local: 'git show -s --format=%ci'
    remote: 'git show -s --format=%ci origin/master' ## we will have to find a better way
format:
  regex:
    optional_bracket: '\[(?P<prefix>.*?)(?P<spaces>\s*)(?P<delimiter>\?\=)(?P<optional>.*?)\]'
  label: "{$label}"
  major: "{$major}"
  minor: "{$minor}"
  patch: "{$patch}"
  prerelease: "{$prerelease}"
  buildmetadata: "{$buildmetadata}"
  commit: "{$commit}"
  version: 'version {$major}.{$minor}.{$patch} (commit {$commit})'
  version-only: 'version {$major}.{$minor}.{$patch}'
  ## Bracket enclosed expressions "[.?{$variable}]" are only rendered if the ?={$variable} is filled
  full: '{$version-only}[.?={$prerelease}][+?={$buildmetadata}] (commit {$commit})'
  compact: "v{$major}.{$minor}.{$patch}-{$commit}"
  timestamp-year: '{$timestamp.year}'
  timestamp-month: '{$timestamp.month}'
  timestamp-day: '{$timestamp.day}'
  timestamp-hour: '{$timestamp.hour}'
  timestamp-minute: '{$timestamp.minute}'
  timestamp-second: '{$timestamp.second}'
  timestamp-timezone: '{$timestamp.timezone}'
  timestamp-datetime: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second}'
  timestamp-full: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second} {$timestamp.timezone}'
  ## add as many formats as you need !!!!

are you using the latest version (1.2.2) of this package? there were some changes to the absorb feature recently

are you using the latest version (1.2.2) of this package? there were some changes to the absorb feature recently

Yes, i am using latest version 1.2.2. Unfortunately with no success :( Can we contact directly? I hope that we can resolve that issue and help others with same trouble here.

You should all be using git absorb. The idea is the same, it will get the commit sha from your last commit, but the main difference is that you will be referring to the previous commit version. What I usually do is to use a git post-commit hook to absorb and create a commit just for the version with the message "Updated version to x.xx.xx (sha)".
Too much people had problems running git-local directly, not only problems performance problems due to the app executing git too many times, but sometimes the result not being the expected one.
We are using this package to clear some cache every time the version changes, so the version cannot be cached and it must be very fast, because it's happening on every request to the app.
I would gladly accept any PR's that could fix things, if we really have any bugs here, because git-local was not removed from the package.

I'm using the latest version. When I run php artisan version:absorb I get Not in absorb mode, please edit your config file.
What am I doing wrong?
Here's my config file:
mode: 'absorb' # or 'increment'
blade-directive: version
current:
  label: v
  major: 1
  minor: 0
  patch: 0
  prerelease:
  buildmetadata:
  commit: 100001
  timestamp:
    mode: absorb
    year:
    month:
    day:
    hour:
    minute:
    second:
    timezone:
commit:
  mode: absorb
  length: 6
  increment-by: 1
git:
  from: 'local' # or "remote"
  commit:
    local: 'git rev-parse --verify HEAD'
    remote: 'git ls-remote {$repository}'
  branch: refs/heads/master
  repository: '' ### you can use config() to get it here: {{ config('version.git.remote.repository') }}. Do not use env()
  version:
    local: 'git describe'
    remote: 'git ls-remote {$repository} | grep tags/ | grep -v {} | cut -d / -f 3 | sort --version-sort | tail -1'
    matcher: '/^(?P<label>[v|V]*[er]*[sion]*)[\.|\s]*(?P<major>0|[1-9]\d*)\.(?P<minor>0|[1-9]\d*)\.(?P<patch>0|[1-9]\d*)(?:-(?P<prerelease>(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+(?P<buildmetadata>[0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/'
  timestamp:
    local: 'git show -s --format=%ci'
    remote: 'git show -s --format=%ci origin/master' ## we will have to find a better way
format:
  regex:
    optional_bracket: '\[(?P<prefix>.*?)(?P<spaces>\s*)(?P<delimiter>\?\=)(?P<optional>.*?)\]'
  label: "{$label}"
  major: "{$major}"
  minor: "{$minor}"
  patch: "{$patch}"
  prerelease: "{$prerelease}"
  buildmetadata: "{$buildmetadata}"
  commit: "{$commit}"
  version: 'version {$major}.{$minor}.{$patch} (commit {$commit})'
  version-only: 'version {$major}.{$minor}.{$patch}'
  ## Bracket enclosed expressions "[.?{$variable}]" are only rendered if the ?={$variable} is filled
  full: '{$version-only}[.?={$prerelease}][+?={$buildmetadata}] (commit {$commit})'
  compact: "v{$major}.{$minor}.{$patch}-{$commit}"
  timestamp-year: '{$timestamp.year}'
  timestamp-month: '{$timestamp.month}'
  timestamp-day: '{$timestamp.day}'
  timestamp-hour: '{$timestamp.hour}'
  timestamp-minute: '{$timestamp.minute}'
  timestamp-second: '{$timestamp.second}'
  timestamp-timezone: '{$timestamp.timezone}'
  timestamp-datetime: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second}'
  timestamp-full: '{$timestamp.year}-{$timestamp.month}-{$timestamp.day} {$timestamp.hour}:{$timestamp.minute}:{$timestamp.second} {$timestamp.timezone}'
  ## add as many formats as you need !!!!

I am having the same issue. Nothing seems to be working based on the default configuration to set the commit number as the version.

same problem here!


V2 -- Update tests to use inline functions

Related to: https://github.com/react-webpack-generators/generator-react-webpack/issues/275
Additions to test/.eslintrc

env

mocha (mutes warnings for missing imports in certain IDEs)

rules

prefer-arrow-callback: 0 (don't err out on inline func callbacks)
func-names: 0 (remove warning for unnamed inline funcs)
strict: 0 (older node versions may need use strict for certain keywords, e.g. let, const)

Update tests
Update existing tests to use inline functions instead of arrow functions (recommended by official Mocha docs)

Closed with #51


Tags selector should be possible to maximize by dragging up

There is a "tags selector" in resources grid. It should be possible to maximize it by dragging its edge up.
In maximized state, a user still can select tags but resources grid is not visible, hence not necessary to update previews. But the user should receive feedback about his actions, so number of resources selected should be displayed.

Implemented in #28
Previews are still get updated upon tags selection modified, but so far it doesn't look like a real problem.


MWPW-124986 - [Caas] Adding Floodgate Color & ContentId in SendToCaas individual & Bulk Publish based on Metadata

Adding Floodgate Color pink, based on the metadata.xslsx on the FG tree root
Changing ContentId for pages under FG tree, to maintain uniqueness between the same page on default tree

Resolves: MWPW-124986
Test URLs:

Before:
After:

No draft PRs: https://github.com/adobecom/milo/wiki/Submitting-PRs#drafts-prs

@arshadparwaiz : please remember to provide test URLs, otherwise the helix-psi-check will fail.


Clusterloader: Document purpose of load, density, chaosmonkey tests

It would be awesome to have a README for each of those tests in that explain what their test/benchmarking goal is

I agree with you.
'bump'


Administration

Why do I have one?

I don't understand what you mean. Please elaborate

I can't connect to any porn sites because administratior won't let me.

 This is not the place to ask that, though.


gitu: 0.23.0 -> 0.23.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/altsem/gitu/releases.
meta.description for gitu is: TUI Git client inspired by Magit
meta.homepage for gitu is: https://github.com/altsem/gitu
meta.changelog for gitu is: https://github.com/altsem/gitu/blob/v0.23.1/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.23.1 with grep in /nix/store/vyqiy8yqyid7bwgfxry342mlf22s88p5-gitu-0.23.1
found 0.23.1 in filename of file in /nix/store/vyqiy8yqyid7bwgfxry342mlf22s88p5-gitu-0.23.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gitu

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vyqiy8yqyid7bwgfxry342mlf22s88p5-gitu-0.23.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitu https://github.com/r-ryantm/nixpkgs/archive/bed7864b47c1b2c59b28fe789a2d4f0b5b902499.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/bed7864b47c1b2c59b28fe789a2d4f0b5b902499#gitu

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vyqiy8yqyid7bwgfxry342mlf22s88p5-gitu-0.23.1
ls -la /nix/store/vyqiy8yqyid7bwgfxry342mlf22s88p5-gitu-0.23.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitu

Maintainer pings
cc @evanrichter for testing.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge


Add support for TemperHUM_V3.8

The latest shipment has an updated firmware:
(venv) [13:47] server102.place10:~/temper# python temper.py -l
Bus 001 Dev 001 1d6b:0002   xHCI Host Controller ['hidraw0', 'hidraw1']
Bus 001 Dev 002 046d:0825
Bus 001 Dev 003 1b3f:2247   GENERAL WEBCAM
Bus 001 Dev 004 1a86:e025    ['hidraw0', 'hidraw1']
Bus 002 Dev 001 1d6b:0003   xHCI Host Controller
(venv) [13:47] server102.place10:~/temper# python temper.py --force 1a86:e025
Bus 001 Dev 004 1a86:e025 TEMPerHUM_V3.8 Error: Unknown firmware TEMPerHUM_V3.8: b'8020065a0c360000'

This looks exactly the same as the previous white temperhum devices

From what I can see  the following patch could already be enough for parsing:
@@ -206,7 +208,7 @@ class USBRead(object):
       self._parse_bytes('internal temperature', 2, 100.0, bytes, info)
       return info

-    if info['firmware'][:12] in [ 'TEMPerX_V3.1', 'TEMPerX_V3.3' ]:
+    if info['firmware'][:12] in [ 'TEMPerX_V3.1', 'TEMPerX_V3.3', 'TEMPerHUM_V3'  ]:
       info['firmware'] = info['firmware'][:12]
       self._parse_bytes('internal temperature', 2, 100.0, bytes, info)
       self._parse_bytes('internal humidity', 4, 100.0, bytes, info)

We could alternatively also parse for the whole TEMPerHUM_V3.8 string.
As well as adding the valid id list:
    if vendorid == 0x1a86 and productid == 0xe025:
      return True

Adding those two makes temper.py work for me:
(venv) [13:55] server102.place10:~/temper# python temper.py
Bus 001 Dev 004 1a86:e025 TEMPerHUM_V3 15.82C 60.48F 29% - - -

Can you advise which format you'd like for parsing the Firmware ID? Full string (TEMPerHUM_V3.8) or
abbreviated string (TEMPerHUM_V3)? I'll then submit a MR.

@urwen There are many PRs and issues open - would you be open for somebody else to take over the project? I can fork it, but I have seen that there is another stale fork at https://github.com/ccwienk/temper/ and I'd prefer avoiding to create another fork.

@telmich thanks, I just ran into this new updated firmware this morning, and you patch seems to be working well.
I suggest you send a PR to the fork at https://github.com/ccwienk/temper/ because that fork has more recent activity.

@telmich We're still taking PRs and issues over on ccwienk/temper.  No guaranteed turnaround time, but we do get around to handling them.
We also publish the PyPi package temper_py.


Night CI 2023-12-03: Failed

action url: https://github.com/spidernet-io/egressgateway/actions/runs/7079044019

同 #990
[FAILED] Unexpected error:
      <*errors.StatusError | 0xc00069a8c0>:
      admission webhook "egressgateway.egressgateway.spidernet.io" denied the request: Do not delete :egw-d293a0e3-a63b-48b5-8b83-73da630eaa0e because it is already referenced by EgressPolicy
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "admission webhook \"egressgateway.egressgateway.spidernet.io\" denied the request: Do not delete :egw-d293a0e3-a63b-48b5-8b83-73da630eaa0e because it is already referenced by EgressPolicy",
              Reason: "Forbidden",
              Details: nil,
              Code: 403,
          },
      }
  occurred
  In [DeferCleanup (Each)] at: /home/runner/work/egressgateway/egressgateway/test/e2e/egresspolicy/egresspolicy_test.go:426 @ 12/03/23


Add a project API key to the Products dev container

Generate a shared Products API Key from IBM Cloud
Download and rename it project_apikey.json and move it to ~/.bluemix folder
Edit .devcontainer/docker-compose.yaml file to add the project API key

IBM Cloud toolchain: Delivery Pipeline deployed products to nyu-devops-products, including commit 1776ffdade681498efd29214e130035dc554c690


Cannot Authenticate account

Been using your software for years and love it. Never had a login issue until now...
I lost access to my Tumblr account because the 2FA codes generated in any one of my authentication apps were no longer accepted by Tumblr. They were no help so I had to start a new Tumblr account. In TumblThree when I enter the new Tumblr email and password and click Authenticate the button turns light grey briefly then back to darker grey. I've found several threads from the last few years about similar issues but none of the solutions work:

cleared cache (I've tried Opera, Firefox, Edge, Chrome (shutdown TumblThree, cleared cache, restarted TumblThree)
Run TumblThree from a new download of <IP_ADDRESS>
renamed all the files at Users\Username\AppData\Local\TumblThree\Settings except Queuelist and let TumblThree rebuild
VPN and proxy are disabled
edited User agent field to have only the browser I want to test. No issues logging into my Tumblr through the browsers

The blogs I previously connected to under the old Tumblr ID are showing Online or Offline, depending on the blog so TumblThree is connecting to the internet
Verified the Blog tab has selections checked (images and videos)

You are using a quite outdated version (<IP_ADDRESS>, I assume a misspelling). Please use the newest version from here.
Some posts and reviews in the internet describe the last version from our previous GitHub page. If you came from such a post, it would be nice if you send us the link to it (either here or by email).

I found the version to be the issue. I was previously running v.<IP_ADDRESS>. Within the software I went to About>Check for Updates and <IP_ADDRESS> downloaded, so I assumed it to be the most current version.
After continuing to research the issue I ran across v.<IP_ADDRESS>, downloaded and ran it and connected to Tumblr without a problem.
I also went back to my <IP_ADDRESS> and ran Check for Updates again and it still responded that I had the most current version.

Of course, the version is the issue.
Let me try to explain it.
Last year the "home" of TumblThree changed from its old location to this one here.
As we cannot change/influence the url the TumblThree application is using for update searches of those already installed applications, they are searching and will forever search on the old location. There the most current version is and will be forever <IP_ADDRESS>.
Only if the user wonders why there are no new versions for several months, or the login no longer works due to changes on the Tumblr site, some users are checking on the (old) TumblThree location. But they either oversee that the newest version there is already several months old or more important that on the main page it states "check out its new home: TumblThreeApp", or both.
You were lucky and found out how to open an issue in the new TumblThree location. We have shown you the new location of current and future versions. Now you know where to look in the future.
Welcome back!

Not luck that I found the new support location. I found it and the new/current download by diligent searching.

The issue has been closed. You can still comment. Feel free to ask for reopening the issue if needed.


Hey, installing error.

Hello if someone could help me that would be amazing.
Error:
root@athenode:/opt/nginxproxymanager# docker-compose up -d
Starting nginxproxymanager_db_1  ... error
Starting nginxproxymanager_app_1 ...
ERROR: for nginxproxymanager_db_1  Cannot start service db: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused "rootfs_linux.go:58: mounting \"proc\\Starting nginxproxymanager_app_1 ... error
ERROR: for nginxproxymanager_app_1  Cannot start service app: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused "rootfs_linux.go:58: mounting \"proc\" to rootfs \"/var/lib/docker/overlay2/ff1cc90926b1d13a30e8b16ecdbd79b0f7e832a4fea81e4ff5c2bfa2e72df1fa/merged\" at \"/proc\" caused \"permission denied\""": unknown
ERROR: for db  Cannot start service db: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused "rootfs_linux.go:58: mounting \"proc\" to rootfs \"/var/lib/docker/overlay2/81acc15c6452969cffa3ac9342ce2a419a2d97046e78e7b7dee6b7a29f2f8a3d/merged\" at \"/proc\" caused \"permission denied\""": unknown
ERROR: for app  Cannot start service app: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused "rootfs_linux.go:58: mounting \"proc\" to rootfs \"/var/lib/docker/overlay2/ff1cc90926b1d13a30e8b16ecdbd79b0f7e832a4fea81e4ff5c2bfa2e72df1fa/merged\" at \"/proc\" caused \"permission denied\""": unknown
ERROR: Encountered errors while bringing up the project.
root@athenode:/opt/nginxproxymanager#
Thanks.

try sudo docker-compose up -d


Adding html element as a parameter to the filter call

Adding html element as a parameter to the filter call to provide more advanced filtering abilities.

Yea I thought about that. I just went this way for now so its backwards compatible for people, but if you are going to make that change I'd be cool with updating my stuff.

Now I've added a new branch called development. It would be cool if you could update the .filter() to take a item as parameter and then do a pull request to that branch instead! =)

Will do. Were you interested in me submitting this update to paging, or maybe as a separate plugin? http://www.screencast.com/users/sprynmr/folders/Jing/media/4ba44937-e0d4-4642-964e-6ad2a68e7bd6


BroacastReceiver stopped working after update

Expected behavior
Receiving notification for events as:
com.fsck.k9.intent.action.EMAIL_RECEIVED and
com.fsck.k9.intent.action.EMAIL_DELETED
Actual behavior
After updating from 5.600 to 5.710  the broadcastreceiver stopped getting notifictions for these intents.
K9 downloads the mails normally, log shows no errors or warnings.
Manual query loads the new mails into 3rd party app.
Steps to reproduce

register a broadcastreceiver with one of the intent filters above
wait until new mails arrive

Environment
K-9 Mail version: 5.710
Android version: 10
Account type (IMAP, POP3, WebDAV/Exchange): POP3, IMAP

This was removed intentionally. See #4278.
What's your use case that needed the broadcasts?

I see.
Android launcher integration. When broadcast is received it checks for the new/deleted mails.
In this case, now it will pull.
Was not essential, just did know if it is a bug or feature.

You can register a ContentObserver to listen for change notifications to the base URI of the message content provider.
K-9 Mail triggers notifications every time a folder status changes (messages added/removed or message flags change). See https://github.com/k9mail/k-9/blob/5a4a269926116a4f373699510bf868a848cdb8d8/app/k9mail/src/main/java/com/fsck/k9/external/MessageProvider.java#L102-L107

Yep, I forgot about that option, thank you for pointing it out.
And nicely working.

I'm glad it's working for you. Thanks for working on a launcher integration that supports K-9 Mail.

And now the option is removed altogether? Will there be any other the get notified when emails arrive?

Can you please open a feature request outlining what kind of app you're building and what functionality in K-9 Mail you're looking for exactly?
I'm not opposed to exposing data to third-party apps. However, the user should be asked whether or not they want to grant another app access to emails.
The old way with permissions in the manifest was never great. Switching to targetSdkVersion="31" flagged android:permissionGroup="android.permission-group.MESSAGES" as invalid. Chances are changing the permission group would have messed with permissions granted to already installed apps. So I took this as an opportunity to no longer expose MessageProvider to third-party apps.


a issue with night mode on twitter

yesturday i was going to dm someone on twitter and then this happened and i tried to disable and enable it again and it still has the same issue... please fix this because i can not stand having the white background and i can't dm on twitter with night mode

@gamernation89 this looks the same as #64. I've pushed a fix in version 0.0.17 and it should be available soon.


making a new good ui form

Describe the bug
A good UI form of mentors
To Reproduce
Steps to reproduce the behavior:

Go to mentors apply
see form

Expected behavior
a good ui form should be there
Screenshots

hey @aaryahjolia u can work on it

If This Issue Is Not Solved Can I Work On It

hey,@aaryahjolia I want to work on this issue please assign me this issue.


[Suggestion] Prioritize Higher Evolved Pokemon when Evolving

An option to prioritize higher evolved pokemon when evolving would be nice so we don't waste candies on lower evolutions. Obviously not ideal for exp grinding and evolving pidgeys/rats/etc.

I second this suggestion. Would be nice to save squirtle candies to evolve a wartortle, rather than having them all used up to evolve squirtles (for example)
I realise I can add individual pokemon to be evolved, but would like to have something like...

Do you have candies?
If yes, do you have an evolved pokemon?
If yes, and it can be evolved, then save candies to evolve it.
If no, evolve low-level pokemon

Sorry for crappy pseudocode but I'm sure you get the idea.

Please move your feature request/s to our feature hub - http://feathub.com/PokemonGoF/PokemonGo-Bot

https://github.com/PokemonGoF/PokemonGo-Bot/issues/3843#issuecomment-239708680

Done like that in pokemon optimizer. Should we close or ?


How to append a vnode segments to the current Vue Instance?

What problem does this feature solve?
In a normal Vue instance, click the button which will invoke a function that create a vnode by calling this.$createElement function.
        tryCreated() {
            let vm = this;

            let h1tag = vm.$createElement('h1', 'This is an h1 tag')

        }

How can I insert the h1tag into this?
What does the proposed API look like?
$createElement, Render Function

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.


IndexConfiguration->isIndexing() is misnamed

   public function isIndexing(): bool
    {
        return $this->config()->get('enable_indexing');
    }

When I first read the usage of this, I thought it would limit concurrency ("is indexing right now"), but that's not the case. I think we should keep some symmetry between the PHP and YAML naming, so indexingEnabled or isIndexingEnabled. We could then also rename the YAML key to indexing_enabled

Yup, poor choice of naming, here. Have renamed to just enabled and isEnabled (It's defined on a class called IndexConfiguration, so no need for index)


RO-2436 Remove rpc_conn_pool_size overrides

This patch removes the rpc_conn_pool_size overrides from RPC-O. These
overrides were necessary back in Icehouse/Kilo, but the bugs that
required these increases have long been fixed.
Upstream fix: https://review.openstack.org/#/c/132202
Upstream bug: https://bugs.launchpad.net/neutron/+bug/1372049
Issue: RO-2436

Looks good, but what about the other pool sizes?

@evrardjp See the other PR's. ;)

recheck_cit_xenial_deploy_swift

@major I have the feeling these are all going to merge conflict, so it might be better to have them all in one PR. You can do multiple commits, but a single PR.

@odyssey4me @major  How did we verify that we can boot 400-500 instances at once as our customers provision currently. None of the OPS folks have been consulted and a change of our default parameter is simply not desired unless we can prove that above requirements still work ?
Otherwise please revert immediately !


feat: add sonatype-nexus-community/nancy

sonatype-nexus-community/nancy: A tool to check for vulnerabilities in your Golang dependencies, powered by Sonatype OSS Index
$ aqua g -i sonatype-nexus-community/nancy

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ nancy help
nancy is a tool to check for vulnerabilities in your Golang dependencies,
powered by the 'Sonatype OSS Index', and as well, works with Nexus IQ Server, allowing you
a smooth experience as a Golang developer, using the best tools in the market!

Usage:
  nancy [flags]
  nancy [command]

Examples:
  Typical usage will pipe the output of 'go list -json -deps' to 'nancy':
  go list -json -deps ./... | nancy sleuth [flags]
  go list -json -deps ./... | nancy iq [flags]

  If using dep typical usage is as follows :
  nancy sleuth -p Gopkg.lock [flags]
  nancy iq -p Gopkg.lock [flags]

Available Commands:
  config      Setup credentials to use when connecting to services
  help        Help about any command
  iq          Check for vulnerabilities in your Golang dependencies using 'Sonatype's Nexus IQ IQServer'
  sleuth      Check for vulnerabilities in your Golang dependencies using Sonatype's OSS Index
  update      Check if there are any updates available

Flags:
  -v, -- count                 Set log level, multiple v's is more verbose
  -c, --clean-cache            Deletes local cache directory
  -d, --db-cache-path string   Specify an alternate path for caching responses from OSS Inde, example: /tmp
  -h, --help                   help for nancy
      --loud                   indicate output should include non-vulnerable packages
  -p, --path string            Specify a path to a dep Gopkg.lock file for scanning
  -q, --quiet                  indicate output should contain only packages with vulnerabilities (default true)
      --skip-update-check      Skip the check for updates.
  -t, --token string           Specify OSS Index API token for request
  -u, --username string        Specify OSS Index username for request
  -V, --version                Get the version

Use "nancy [command] --help" for more information about a command.

Thank you always!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.85.0


⚠ Bofrost.de has degraded performance

In 739bbea, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2017 ms

Resolved: Bofrost.de performance has improved in 8dc193d after 6 minutes.


do not show plugin in docker info if plugin is empty

Docker CLI can be used to interact with docker engine. And it can be used to interact with swarm, too.
when executing docker info via swarm, no plugins details shows in output:
root@ubuntu:~# docker -H tcp://<IP_ADDRESS>:2375 info
Containers: 6
 Running: 0
 Paused: 0
 Stopped: 6
Images: 41
Server Version: swarm/1.1.2
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 1
 ubuntu: <IP_ADDRESS>:2376
  └ Status: Healthy
  └ Containers: 6
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 2.052 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.19.0-25-generic, operatingsystem=Ubuntu 14.04.3 LTS, storagedriver=aufs
  └ Error: (none)
  └ UpdatedAt: 2016-04-19T16:38:26Z
Plugins:
 Volume:
 Network:
Kernel Version: 3.19.0-25-generic
Operating System: linux
Architecture: amd64
CPUs: 1
Total Memory: 2.052 GiB
Name: ubuntu

Plugins:
 Volume:
 Network:

Because in swarm's info api, no detail in plugins, so print empty.
Maybe Docker CLI should handle this case, if empty, don not show Plugins.

I'll close this for the reasons stated in https://github.com/docker/docker/pull/22163#issuecomment-212398714. Thanks!

w.r.t Swarm, I'm not sure what the best way would be to solve that; I can imagine "plugins" should be shown for each node individually


chore: remove e2e config and environment variables

:tada: This PR is included in version 4.15.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Expected train time on Cloud TPUv3

The README says that the model will take a couple of weeks to train on a "Cloud TPU, which has 64GB of device RAM".  I think that's referring to a TPUv2 -- is that right?  Do you have any estimates as to how long training might take / what kind of batch size + sequence length we could manage on a TPUv3?
Thanks!

Update: It seems like I can fit a batch size of 2048 on a Cloud TPUv3 w/ a max_seq_length of 128.
Also..  now I'm not totally clear on how the original model was trained -- I see 4 days on 4 TPUv2s, but in one place it says

"1M steps w/ a batch size of 256 sequences * 512 tokens = 128K tokens/batch"

but in another it says

"we pre-train the model w/ sequence length of 128 for 90% of the steps [and] the rest 10% of the steps of sequence of 512"

Can you give a little clarification on how the original BERT-base model was trained?
Thanks!


Butterfly knife animation issues

The butterfly knife will rubberband on the animation where the player's fingers move to slide across the bottom of the blade.
The randomization for the pullouts seem to be inaccurate with the second pullout occurring around 50% of the time instead of 10-15% of the time.

+1

+1

The butterfly knife will rubberband on the animation where the player's fingers move to slide across the bottom of the blade.
The randomization for the pullouts seem to be inaccurate with the second pullout occurring around 50% of the time instead of 10-15% of the time.

Same on shadow daggers. When i press left mouse button.

蝴蝶刀将在动画上橡皮筋缠住，玩家的手指在该动画上移动以滑过刀片的底部。
提取的随机性似乎不准确，因为第二次提取的发生时间约为50％，而不是10-15％。

暗影匕首也一样。当我按下鼠标左键时。

+1


Github actions spam the UI

With the introduction of Github actions, every commit and pull request generates 20+ tasks, each with javascript polling behaviors. These actions make the UI clumsy and sometimes unusable, causing frequent refreshes of the view. When mousing over a commit, the popup gets dismissed frequently due to all of the actions. And in a pull request, the status checks window is difficult to scroll when these actions are running. I'm using the latest Firefox on macOS. I haven't tested on other browsers, where the behavior could be different.
@webknjaz Can you investigate and determine if there's a way to fix these broken UI behaviors? If not, we may just want to disable these actions or limit their number.

I'll try to take a look. Mind sharing a screen recording demonstrating those glitches?

I'm not really experiencing what you describe under Gentoo Linux + Chrome. But I also use https://github.com/sindresorhus/refined-github that may affect this. I'm curious if they do something to deal w/ this. You may want to try it out.

I'll try to get a screencapture next time I encounter it. I'm using Firefox.

@jaraco see https://twitter.com/mscccc/status/1241889868747132928?s=20
@mscoutermarsh said he could take a look if you can provide some visual clue.

I managed to capture this screen recording. In this one, you can see where clicking on the status of the commit gets repeatedly cleared and the scroll bar for the checks repeatedly appears and disappears. You can also see very briefly where I try to scroll in the checks dialog and my scrolling is interrupted by an update to the UI. It only happened once, but in cases where there are lots of updates going on, especially different checks queuing up, this interruption makes scrolling in the window clumsy.

I should note that the issue seems to be worst right after a commit is pushed and seems to subside as checks are queued up and complete. Of course, right after pushing a commit is when this information is most useful.

@jaraco Thanks! We're looking into it. The web socket updates shouldn't be modifying any DOM while you're interacting with it.

I think I saw similar glitches in Chrome some time back too. But not sure if it's still reproducible.

We’re thinking it’s Firefox specific. Or we missed something on that element. Still working on it. 😎


Installing SAP HANA, express edition Server + Apps, with Docker

Tutorial URL: https://developers.sap.com/tutorials/hxe-ua-install-using-docker-xsa.html
Please specify the step you are referring to
On step docker pull store/saplabs/hanaexpressxsa:<IP_ADDRESS>.20190223.1 I am getting the error Error response from daemon: manifest for store/saplabs/hanaexpressxsa:<IP_ADDRESS>.20190223.1 not found
I'm running it on docker for desktop on windows, which is stated as not supported somewhere, but I this this step should go through anyway.

Hi there,
Looks like the pull number is incorrect. It should be <IP_ADDRESS>... A fix will be issued soon. Thank you for highlighting this mistake.


Neutron Web Client

Hello,
Few days ago I started modifying the web client of ProtonMail to give it a more "Neutron" style. I just removed some unnecessary things like payments, invoices etc., modified the UI and signup process.
If you want to add to your project you can find it here: https://github.com/vpapadopou/Neutron-WebClient
Screenshots: https://gitlab.com/vpapadopou/neutronium/wikis/home
Regards,
Vassili

Hi,
I wanted to avoid forking WebClient to be able to get updates easily. But it's still a good idea - thanks!

Shouldn't be to hard to keep it up to date against upstream - just merge instead of rebase?

For what it's worth, I tried to set up a pure @emersion Neutron server today, but the 'sign up' link that I needed to click to generate my user keys ended up taking me to the Proton mail website. I guess they aren't using relative paths any more? Using @vpapadopou's web client solved the issue. It was a super easy on-boarding process.

Hey, this isn't an issue in an of itself, but I thought I'd piggy-back on this issue to tell you both about a project I've been working on to Dockerize Neutron and the Neutron-WebClient skin. I couldn't get the Dockerfile to build because it kept failing at the 'choose Angular version' prompt. I tried a number of things, including piping 'yes | 7' and writing an expect script. In the end, I built the image interactively in an alpine container and committed that container to an image. More details are over on my Github prokect. The image is on Docker Hub under conoria/neutron-webclient.

Wow that's great news!

@ConorIA How did you end up installing the correct Angular version?
@vpapadopou The latest webclient uses a new authentication mechanism (SRP). The login password is no longer sent to the server. Most backends (IMAP) don't support SRP, so I will end up forking the webclient anyway. I'll try to patch as little as possible to make rebases easier when webclient is updated on ProtonMail's side. Would you be interested in applying your changes, at least the Register link fix?

@emersion, bower.json in public includes a line to resolve to angular 1.5.6. But the version needed is 1.5.8. I used sed -i 's/\"angular\": \"1.5.6\"/\"angular\": \"1.5.8\"/g' public/bower.json to fix it.


The props testID and accessibilityLabel are not passed to RN TextInput

I am trying extract the props testID and accessibilityLabel with Appium for automated tests, but those props aren't passed out to the low level component TextInput that appears on the screen.
May those important props could be passed through the TextInputMask to the RN TextInput, so we will be able to get it in Selenium.

Hi @cassioseffrin !
We passed all the props to the text input.
Could you provide a code sample of the component to let me analyze if something is missing?

Closing due inactivity

Hi, would like to have testId prop for testing, please take a look at the screen shot.
<TextInputMask     testId={${id}InputMask}     onFocus={() => setIsFocused(true)}     onBlur={() => setIsFocused(false)}     type="datetime"     options={{       format: 'DD / MM / YYYY'     }}     placeholder={placeholder}     value={       value instanceof Date ? UTILS.formatDate(value, 'DD / MM / YYYY') : value || ''     }     style={styles.maskedInput}     onChangeText={dateStr => {       onChangeDate(dateStr);     }}   />

@vinscloudthing testID is spelled with an uppercase D (at least in RN 0.71).


Testing build health

This is a test, don't review this
Issue #, if available:
Description of changes:
Tests:
Code coverage percentage for this patch:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Build health is back to normal


Add docs and example for multi-level cluster setup

I did it wrong, I need to redo it so I put it in the draft for a while


UUID primary key mapping

Hello,
I am experimenting with using Querydsl on a PostgreSQL database that uses time-based UUIDs for primary keys.  The problem I am having is that the generated classes from Querydsl are mapping the UUID columns to SimplePath<byte[]>. This means it is not possible to (or at least I haven't figured out how to) order query results in ascending order based on the time-based UUID key.  It seems like mapping the UUID columns to something like ComparablePath<UUID> would be more appropriate.
I am new to Querydsl, so please accept my apologies if UUID support/custom mapping is described somewhere, however I could not figure out how to change the mapping of the UUID primary key columns.  Thanks.

Okay, I can get the UUID columns to map to java.util.UUID instead of byte[] as follows:
<typeMappings>
  <typeMapping>

FOO

    <column>ID</column>
    <type>java.util.UUID</type>
  </typeMapping>
</typeMappings>

As per here, however the final mapped type is still SimplePath<UUID>.  Is there anyway to customize the mapping to force it to be ComparablePath<UUID>?

@timowest I have issued a PR against https://github.com/querydsl/codegen that addresses this problem: https://github.com/querydsl/codegen/pull/41.  Do you have any plans to do releases of codegen and querydsl in the near future?

Timo wants to distance himself from the Querydsl project, he's really busy lately, however I/we do not have all the keys, so to speak.
But I'm sure if I poke him, releases can be made.
Thanks anyway 👍


Large response bodies cause UI to hang

As reported here: https://github.com/swagger-api/swagger-ui/issues/3832
People are recommending disabling syntax highlighting. Is it possible to disable that with this library?

We have this option available in echo-swagger (https://github.com/swaggo/echo-swagger/pull/91).

this does indeed fix the problem thanks

Is there something similar for github.com/swaggo/gin-swagger?


[Feature request] Modify proxied headers

Please add support for filtering specific headers when proxying to upstream_url. The use case is running janus in development environment, where it is used to proxy requests to staging services. In this scenario, the Authorization header proxied by janus will be incorrect for the staging environment. The solution would be to add something like:
"headers": [
        "Authorization": null, //example of header removal
        "User-Agent": "Janus" //example of header modification
    ]

to the API configuration on janus. This will cover a much wider use case (not only filtering, but also adding and modifying headers). The assumption is that specifying null signals to janus to remove this header.

Solved on #150


workflow times out in between - Paramiko error: Error reading SSH protocol banner

Stackstorm workflow exits without completing the workflow in between.

Bug Report

st2 2.10.0
While executing one of the core.remote tasks in orquestra workflow, Stackstorm exits without producing any error or output. And found this message in workflow log : Paramiko error: Error reading SSH protocol banner
This is risky, as we had further steps in workflow and stackstorm did not complete it and failed it.

Can you please post an example workflow to reproduce this? On the face of it, it sounds like your workflow did not have any error handling, so it exited at the failed step (as would be expected)?

Stackstorm exits without producing any error or output

And just to clarify, are you saying that the execution exited successfully, or that ST2 processes exited?
What does st2 execution get <ID> show for the relevant execution?

Sure, I guess I am handling the failed part of the task:
ldap_check: #ldap check
action: core.remote

input:

  cmd: 'if [ "$(cat check.err | grep -i sssd | grep NOK)" ] ; then echo "issue flag still active, executing further actions"; exit 1; else echo 'passed'; fi;'

  timeout: 120

  hosts: <% ctx(hosts) %>

  private_key: <% ctx(private_key) %>

next:

  - when: <% succeeded() %>

    publish:

      - out: "<% ctx(out) %> \n\n- LDAP Check Successful: No Action Taken \nOutput: <% result().get(ctx(hosts)).stdout %>"

    do: lhc_check

  - when: <% failed() %>

    publish:

      - out: "<% ctx(out) %> \n\n- LDAP Check Failed \nOutput: <% result().get(ctx(hosts)).stdout %>"

    do: restart_sssd

Stackstorm UI

So the task is marked as failed, which seems correct. The workflow is also marked as failed. What should your workflow have done when the task failed? Without knowing the whole workflow, it's hard to say what it should do.
Try looking at the output of st2 execution get <ID> for your workflow. It's possible that you've done something like referenced a non-existent task, or something failed with rendering the out variable in your failed step. You should be able to find logs about this if you examine the execution output.

Yes, after the task failed, there was another task for it, it did not go there. Instead it just exited.
output of st2 execution get
errors:

message: Execution failed. See result for details.
result:
error: "Unable to connect to any one of the hosts: [u'hostname'].

connect_errors={
"hostname": {
"failed": true,
"traceback": "Traceback (most recent call last):  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/parallel_ssh.py", line 261, in _connect    client.connect()  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/paramiko_ssh.py", line 143, in connect    self.client = self._connect(host=self.hostname, socket=self.bastion_socket)  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/paramiko_ssh.py", line 705, in _connect    raise SSHException(msg)SSHException: Error connecting to host hostname with connection parameters {'username': 'root', 'key_filename': u'/root/.ssh/id_rsa', 'allow_agent': False, 'hostname': u'hostname', 'look_for_keys': False, 'timeout': 60, 'port': 22}.Paramiko error: Error reading SSH protocol banner.",
"timeout": false,
"succeeded": false,
"stdout": "",
"stderr": "",
"error": "Connection error. Error connecting to host hostname with connection parameters {'username': 'root', 'key_filename': u'path', 'allow_agent': False, 'hostname': u'hostname', 'look_for_keys': False, 'timeout': 60, 'port': 22}.Paramiko error: Error reading SSH protocol banner.",
"return_code": 255
}
}"
traceback: "  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2actions/container/base.py", line 113, in _do_run
runner.pre_run()
File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/paramiko_ssh_runner.py", line 186, in pre_run
self._parallel_ssh_client = ParallelSSHClient(**client_kwargs)
File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/parallel_ssh.py", line 77, in init
connect_results = self.connect(raise_on_any_error=raise_on_any_error)
File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/runners/parallel_ssh.py", line 107, in connect
raise NoHostsConnectedToException(msg)
"
task_id: ldap_check
type: error

message: 'YaqlEvaluationException: Unable to evaluate expression ''<% result().get(ctx(hosts)).stdout %>''. NoFunctionRegisteredException: Unknown function "#property#stdout"'
task_id: ldap_check
task_transition_id: restart_sssd__0
type: error
output:
result: "

Here, I guess the exception seen above needs to be handled and it is not the workflow side.

Right, that makes sense. It couldn't render <% result().get(ctx(hosts)).stdout %>, so the workflow could not continue. You'll have to figure out what error message you want, and how to safely render that.

Ok Thanks @LindsayHill :)

Good luck figuring it out - post at forum.stackstorm.com or stackstorm-community.slack.com if you're getting stuck.
(Just closing this issue for now since I don't think this is a core code bug)


Refactoring README.md, composer is the first method to install arkitect and the second using .phar. We can remove Docker usage at the moment from the documentation.

Refactoring README.md, composer is the first method to install arkitect and the second using .phar. We can remove Docker usage at the moment from the documentation.

Closed by #193


Add missing groupId inside list glossaries/projects

Hey :wave:
There was a missing groupId for 2 GET calls, It didn't match the API definition for:

projects
glossaries

@dhoko Unit tests have failed. Could you please take a look?
https://github.com/crowdin/crowdin-api-client-python/actions/runs/4799498715

@andrii-bodnar :heavy_check_mark: btw there is an issue with the coverage. When I install the deps it fails at typed_ast :/  (Fedora 37)
│Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune
│=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -O2 -fex
│ceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERT
│IONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protec
│tion -D_GNU_SOURCE -fPIC -fwrapv -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,
│-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-ta
│bles -fstack-clash-protection -fcf-protection -D_GNU_SOURCE -fPIC -fwrapv -fPIC -Iast27/Include -I/home/dhoko/.loca
│l/share/virtualenvs/crowdin-api-client-python-1Vpfnig1/include -I/usr/include/python3.11 -c ast27/Custom/typed_ast.
│c -o build/temp.linux-x86_64-cpython-311/ast27/Custom/typed_ast.o
│      ast27/Custom/typed_ast.c:1:10: fatal error: Python.h: No such file or directory
│          1 | #include "Python.h"
│            |          ^~~~~~~~~~
│      compilation terminated.
│      error: command '/usr/bin/gcc' failed with exit code 1
│      [end of output]
│
│  note: This error originates from a subprocess, and is likely not a problem with pip.
│error: legacy-install-failure
│
│× Encountered error while trying to install package.
│╰─> typed_ast

Then we can't run pytest unless we comment the coverage cf:
diff --git a/setup.cfg b/setup.cfg
index fdbb3b3..7221536 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -60,10 +60,6 @@ addopts =
     --strict-markers
     --tb=short
     --doctest-modules
-    --cov=crowdin_api
-    --cov-report=term-missing:skip-covered
-    --cov-report=xml
-    --cov-fail-under=95

Codecov Report

Merging #77 (51fa31b) into main (fa46eee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   99.34%   99.34%   +0.01%
==========================================
  Files         132      132
  Lines        4493     4496       +3
  Branches       95       95
==========================================
+ Hits         4463     4466       +3
  Misses         22       22
  Partials        8        8

Impacted Files
Coverage Δ

...esources/projects/tests/test_projects_resources.py
100.00% <ø> (ø)

crowdin_api/api_resources/glossaries/resource.py
100.00% <100.00%> (ø)

...rces/glossaries/tests/test_glossaries_resources.py
100.00% <100.00%> (ø)

crowdin_api/api_resources/projects/resource.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dhoko thank you!
Do you have any ideas regarding this coverage error? Everything seems to work well in the CI/CD pipelines

Idk ¯_(ツ)_/¯
I saw messages asking to install python3-dev... So I went with no coverage on my computer :grin: It requires no changes and we can still test everything^^

https://github.com/python/typed_ast/issues/179
tl;dr: EOL + I'm using python 3.11 -> no support


posters with title problem

Hi,
I just setup Artwork Beef and it is working great except that every poster is being downloaded without title. The "Prefer poster with no title" option is off. Would you please let me know what you need to further debug this?
Thanks!

Hi!

Kodi 17.6
Artwork Beef 0.20.3
Estuary skin
No NFOs. Removed them before starting a new clean library
Artwork Beef is downloading media files. Keyart is disable.

If I remove the downloaded poster and refresh the movie in Kodi, it shows the poster with title.
Kodi debug log: https://pastebin.com/e6Sc8pi0
artwork-report: https://pastebin.com/Z6FykhQE

Thx!

Do the movies not yet processed by Artwork Beef already have posters from the scraper? Do those posters have a title? If a poster image exists but they do not have a title then something in the scraper needs configured, Artwork Beef is just downloading the image that the scraper adds.
If you open the context menu on one of those movies and select "Manage ..." then "AB: Add missing artwork", is the poster image that Artwork Beef downloads different than the original poster from the scraper?

That's the ticket, thanks!
I can recreate this now, so a fix is inevitable.

Fixed in 0.21.0, thanks for the report.


CreateProvider is missing

after copy the folder  WalletConnect.NEthereum folder from WalletConnectSharp,  the CreateProvider is not available and get error compiling,  also i get a warning that i should use Session intead of Protocol, but Session does not contain this  CreateProvider  either,  i copied the folder next to WalletConnectSharp.Core inside Scripts\WalletConnectSharp
var wcProtocol = WalletConnect.Instance.Protocol
var web3 = new Web3(wcProtocol.CreateProvider(new Uri("https://mainnet.infura.io/v3/<infruaId>"));

Closing, after copying the  folder, and adding using WalletConnectSharp.NEthereum; to the file where a create the Web3 instance fixed it, but would worth to mention this into the README.md to make it clear
thanks


coveralls 0.6.0+2 hanging on run

Builds using coveralls are green again but unfortunately are timing out.
https://travis-ci.org/dart-lang/linter/jobs/407163523
Activated dart_coveralls 0.6.0+2.
Bad state: Failed to complete within 60s

(Confirmed locally.)

Very likely new async semantics related.

Kudos to @denniskaselow.  Thanks to the fix in #80 (and published in 0.6.0+3), we've got our first coverage runs on the linter in a month.

🎉


KAFKA-12772: Move all transaction state transition rules into their states

More detailed description of your change
Similar to KAFKA-5258 which move all partition and replica state transition rules into their states, we move the transaction state transition rules into their states, this is a good develop habit.
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

LGTM. Merged to trunk.


Add margins to form elements

Add bottom and top margins to form elements.
Also:

Add placeholder content to form elements in demo pages
Fix vertical-align of textarea to match positioning of single-line input elements

Screenshots
Chromium-based:

Before
After

Firefox:

Before
After

I'll consider this good enough to say it fixes #5. I'm uncomfortable assuming/encouraging specific layouts for forms, such as making input fields span the full width (as e.g. Bamboo.css does), and IMO the current result is already pretty serviceable. Of course, further adjustments can always be made! :D


Allow setting resource requests and limits (#4)

Tested with Docker and Kubernetes backends. Contains a refactoring for project config, and some smaller changes (incl. some unrelated improvements (parsing config option, whitespace), sorry).

As figuring out how to do the config was a bit of a challenge, I had a go at it. Seeing what you had on Friday helped me (regarding how you structured the configuration, even if it was a short glance), so thanks. Would really welcome your review, e.g. @vlerkin.

Thank you for your review!


Chap 20 Ex04 JackAndJill

Hi Chrinkus,
I've recently been working through this textbook and it's been super useful to have something to check my answers against. Thanks so much for posting all of this!
I think the big error in Exercise 4 Chapter 20 might be that there's no check as to whether the start iterator actually comes before the end iterator. If someone accidentally entered them in reverse into the function's arguments, it would lead to an infinite loop.
template<typename Iter>
Iter high(Iter first, Iter last) {
	if (first > last) throw; //Could lead to infinite iterations
	Iter high = first;
	for (Iter p = first; p != last; ++p) {
		if (*high < *p) { high = p; }
	}
	return high;
}

Not sure what it might be otherwise...
Cheers,
Josh

Thanks for the kind words. You’re probably right, Uncle Bjarne is a stickler for bounds-checking. How do you think the function should handle this error?

I thought this line should fix it.
if (first > last) throw; //Could lead to infinite iterations
However, It looks like comparison operators for iterators are more complex than I'd thought. It seems that comparison is only guaranteed to hold true if the iterator used is a Random Access Iterator (as it's the only type of iterator which provides a > operator).
I think it works for the Jack and Jill examples as they use random access iterators and pointers to an array where the data is stored contiguously in memory. Not so sure how to handle this in other cases though.
I did find something about using the std::less function for strict totally ordering of pointers that are not implemented as addresses in continuous virtual address space here but I think I could be barking up the wrong tree (ah-hem) about the relevance of that to non-random access iterators.
Pretty stumped!
(Also to make matters worse, I guess I'm only considering the case of the user mixing up the start and end iterator of the same collection. If they were even further off the mark and mixed up iterators from different collections, then it would likely lead to further issues.)

So yeah, it's probably the case that the potential for mixed up iterators isn't the issue. Come to think of it, if the iterators are range checked, it shouldn't even lead to the infinite looping issue...
The program crashes when jill.txt is empty because there's attempted access to an empty vector. So it could simply be that there should be an equality check between the start and end iterator to make sure the container isn't empty and there's actually some data to analyse.
if (first == last) throw; //Empty containers make the loudest noise.
As equality checks work for all iterators and it gets mentioned as a technique later in the chapter, I think that's more likely to be the solution.

I'm so sorry for not responding to this, its been a rough fall-return to work. Looking at this problem again, I believe you're right in your last comment. In neither get_from_ call do we check to see if we have any data. That's okay-ish but after calling high on either of our data sets we should check afterwards to see if the returned iterator, or pointer in this case, is valid.
Something like:
if (jack_high != jack_data + jack_count) // use data
Lastly, I believe that throwing from an algorithm is bad form. Instead we do as above and return the "end" iterator if there's any issue. That would cover most empty container situations since "first" would equal "last" and the loop would never execute.
for (Iterator p = first; p != last; ++p) // guards against empty container


revert: #3436

MSRV issue after merging
https://github.com/PRQL/prql/actions/runs/6005715274/job/16288962369#step:5:14

#3440 fixes that it could merge


Increment readLevel when skipping over expired tasks

TaskReader has to logic to skip over expired tasks instead of
adding it to AckManager to prevent dispatch.  This results in
taskReader to get stuck in all tasks read from the database are
expired as it results in readLevel to not move at all.
This change also increments the readLevel when skipping expired
tasks to prevent taskReader to spin on expired tasks.

Coverage decreased (-0.003%) to 67.768% when pulling b60baa066efcadcfba945df1c4dbc17622fcb0a5 on samarabbas:sql-persistence-pagination-issue into 55207c84f5f66dc3737681caffc99c707da6372d on uber:master.


RAC-6706 Redfish discovery can not work with HTTPS

Also lowers the time between requests to 3 seconds
@larry-dean @jimturnquist

Thank you for the comment I had missed the obvious tag when looking for the solution fixed now


"" is not detected as active

I have a route:
@Route(value = "", layout = AppMainLayout.class)

And add it like this to the nav:
 addNavItem(new AppNavItem(getTranslation("hello"), "", VaadinIcon.HANDSHAKE.create()));

Then this nav item never becomes active.

Any news on this?

However, if you set the Route with the "/" value, it also fails as it changes it into the empty string.

Yeah, I didn't mean to imply that you should have to change the route path to "/". Rather that the nav component doesn't take this difference in the "root path" into account.

Are there any plans to fix this annyoing bug?

I meant to push this as a PR, but accidentally pushed to main. Here’s how I would fix this: https://github.com/vaadin/vcf-nav/commit/93e3e67f3710acbeea9a4658ebe0185bf36de0aa

@Artur-, should we publish a new version and test it in start.vaadin.com?

Looks sane, go ahead

For me it works

Closing as fixed, then 👍


feature(template) add proper handling for current time + some cleanup

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>Changes

CLI option changed from --ctoFiles to --model
Add optional currentTime parameter to: draft/parse related transforms, used for Ergo formulas and default timezone when parsing dates in the contract text
Some refactoring and new tests

Coverage increased (+0.07%) to 91.476% when pulling 56f1a284f6fe1049492399c1086da11e0c0a2030 on parserv2 into 5a71ec346e9a7ad083ec85a41c31c59680d0bcb3 on master.


[Refactoring] Remove Type::tboolean and Type::tindex

Auto-merge toggled on

Thanks!

No worries.  Do you have any thoughts on #4303?


Split wallets

@stackchain protocol params (like fees, min sizes, pool and key deposits)  in not static values, seems it's better to get it from backed, but for it we need to add it to api.

in favor of #2372


test output correctness: Always wait for both threads to finish

Trying to fix why 'no-cache' runs fail some times.
Here is what the sanitizers say:
; make 'TESTS=test_threads' 'VFE=1' tests
make depend && make _tests
make[1]: Entering directory '/home/rsalz/openssl/github'
make[1]: Leaving directory '/home/rsalz/openssl/github'
make[1]: Entering directory '/home/rsalz/openssl/github'
( SRCTOP=. \
  BLDTOP=. \
  PERL="/usr/bin/perl" \
  FIPSKEY="f4556650ac31d35461610bac4ed81b1a181b2d8a43ea2854cbae22ca74560813" \
  EXE_EXT= \
  /usr/bin/perl ./test/run_tests.pl test_threads )
Using HARNESS_JOBS=4
00-prep_fipsmodule_cnf.t .. skipped: FIPS module config file only supported in a fips build
Files=1, Tests=0,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.08 cusr  0.01 csys =  0.10 CPU)
Result: NOTESTS

==21882==Processing thread 21860.
==21882==Stack at 0x7ffc17e4a000-0x7ffc1864a000 (SP = 0x7ffc18646838).
==21882==TLS at 0x7f234aea5000-0x7f234aea60c0.
=================================================================
==21860==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7f2349dc6b40 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb40)
    #1 0x7f2348ad38f7 in CRYPTO_malloc crypto/mem.c:184
    #2 0x7f2348abf285 in OPENSSL_LH_insert crypto/lhash/lhash.c:118
    #3 0x7f2348b8c277 in lh_PROPERTY_STRING_insert crypto/property/property_string.c:34
    #4 0x7f2348b8cbf3 in ossl_property_string crypto/property/property_string.c:141
    #5 0x7f2348b8d27a in ossl_property_value crypto/property/property_string.c:213
    #6 0x7f2348b86e6f in parse_unquoted crypto/property/property_parse.c:221
    #7 0x7f2348b87856 in parse_value crypto/property/property_parse.c:253
    #8 0x7f2348b88422 in ossl_parse_property crypto/property/property_parse.c:333
    #9 0x7f2348b81d2d in ossl_method_store_add crypto/property/property.c:288
    #10 0x7f2348a331f3 in put_evp_method_in_store crypto/evp/evp_fetch.c:170
    #11 0x7f2348ac84aa in ossl_method_construct_this crypto/core_fetch.c:95
    #12 0x7f2348ac7256 in algorithm_do_this crypto/core_algorithm.c:65
    #13 0x7f2348af9056 in ossl_provider_doall_activated crypto/provider_core.c:1061
    #14 0x7f2348ac784f in ossl_algorithm_do_all crypto/core_algorithm.c:109
    #15 0x7f2348ac88da in ossl_method_construct crypto/core_fetch.c:124
    #16 0x7f2348a33b04 in inner_evp_generic_fetch crypto/evp/evp_fetch.c:304
    #17 0x7f2348a33e8e in evp_generic_fetch crypto/evp/evp_fetch.c:350
    #18 0x7f23489db5a9 in EVP_MD_fetch crypto/evp/digest.c:1037
    #19 0x55d437760805 in thread_multi_simple_fetch test/threadstest.c:280
    #20 0x55d43775e4d9 in thread_run test/threadstest.h:67
    #21 0x7f2346ed46da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
Indirect leak of 23 byte(s) in 1 object(s) allocated from:
    #0 0x7f2349dc6b40 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb40)
    #1 0x7f2348ad38f7 in CRYPTO_malloc crypto/mem.c:184
    #2 0x7f2348b8c879 in new_property_string crypto/property/property_string.c:117
    #3 0x7f2348b8cbc9 in ossl_property_string crypto/property/property_string.c:140
    #4 0x7f2348b8d27a in ossl_property_value crypto/property/property_string.c:213
    #5 0x7f2348b86e6f in parse_unquoted crypto/property/property_parse.c:221
    #6 0x7f2348b87856 in parse_value crypto/property/property_parse.c:253
    #7 0x7f2348b88422 in ossl_parse_property crypto/property/property_parse.c:333
    #8 0x7f2348b81d2d in ossl_method_store_add crypto/property/property.c:288
    #9 0x7f2348a331f3 in put_evp_method_in_store crypto/evp/evp_fetch.c:170
    #10 0x7f2348ac84aa in ossl_method_construct_this crypto/core_fetch.c:95
    #11 0x7f2348ac7256 in algorithm_do_this crypto/core_algorithm.c:65
    #12 0x7f2348af9056 in ossl_provider_doall_activated crypto/provider_core.c:1061
    #13 0x7f2348ac784f in ossl_algorithm_do_all crypto/core_algorithm.c:109
    #14 0x7f2348ac88da in ossl_method_construct crypto/core_fetch.c:124
    #15 0x7f2348a33b04 in inner_evp_generic_fetch crypto/evp/evp_fetch.c:304
    #16 0x7f2348a33e8e in evp_generic_fetch crypto/evp/evp_fetch.c:350
    #17 0x7f23489db5a9 in EVP_MD_fetch crypto/evp/digest.c:1037
    #18 0x55d437760805 in thread_multi_simple_fetch test/threadstest.c:280
    #19 0x55d43775e4d9 in thread_run test/threadstest.h:67
    #20 0x7f2346ed46da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
SUMMARY: AddressSanitizer: 47 byte(s) leaked in 2 allocation(s).
../../util/wrap.pl ../../test/threadstest -config /home/rsalz/openssl/github/test/default.cnf ../../test/recipes/90-test_threads_data => 1
not ok 1 - running test_threads
90-test_threads.t .. 1/2 -------------------------------------------------------
90-test_threads.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

Test Summary Report
-------------------
90-test_threads.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=2,  0 wallclock secs ( 0.00 usr  0.00 sys +  0.43 cusr  0.05 csys =  0.48 CPU)
Result: FAIL
Makefile:3274: recipe for target 'run_tests' failed
make[1]: *** [run_tests] Error 1
make[1]: Leaving directory '/home/rsalz/openssl/github'
Makefile:3271: recipe for target 'tests' failed
make: *** [tests] Error 2
        exit 2
;

What is this actually fixing?  If any of the calls in the chain fail, won't the test fail too?
I.e. this isn't fixing anything.
It is reducing the spurious output.

What is this actually fixing? If any of the calls in the chain fail, won't the test fail too?

It ensures that we actually do wait for both threads to finish.  The previous construction wouldn't wait for the second thread if waiting for the first returns false, because || semantics.

I realise that.  However, we only don't wait for both threads if one has failed which means the test will fail won't it?

I.e. the test will be failing either way....

Yes?  I'm not sure if that was the point here...

Ummmm, I think it is the point:

Trying to fix why 'no-cache' runs fail some times.

This will make it quieter and avoid confusing the debugger, so the change is good but it's not (yet) a fix.

I didn't mean say it's a fix.  I am trying to fix it, but this is a DRAFT.   The content so far just removes one potentially misleading source of errors when a test fails.

Not a fix, but worth doing for code correctness.  It could be done during the beta period.

Ping for second review.

Ping for second review.

Yup

Any chance of this going into the beta, @mattcaswell ?

Yes. Will push once 24 hour timer is up.

Yes. Will push once 24 hour time is up.

Thank you.

Pushed. Thanks.


No Support for CSAFv2, SBOM and your President's Orders? Why play standalone

Why do you want to push your own standard in front of what is mandated for the USA????????????
Why??? Anyone who touches your standard is doomed. They certainly could not sell to the government.
What rationale do you have to go against the Executive Orders????
Frankly this repo is just depressing

I am reading from the website:
All advisories in this database use the [OpenSSF OSV format](https://ossf.github.io/osv-schema/), which was developed in collaboration with open source communities.

The OSV schema provides a human and machine readable data format to describe vulnerabilities in a way that precisely maps to open source package versions or commit hashes.

Then following that link I can see that the current OSV schema:
Version 1.3.1 (September 28, 2022)
But was announced in 2021
And that blog mentions:
Our effort also aligns with the recent [US Executive Order on Improving the Nation’s Cybersecurity](https://www.federalregister.gov/documents/2021/05/17/2021-10460/improving-the-nations-cybersecurity), which emphasized the need to remove barriers to sharing threat information in order to strengthen national infrastructure. This expanded shared vulnerability database marks an important step toward creating a more secure open-source environment for all users.

Looking back in chronological order CSAF
https://www.oasis-open.org/2022/11/28/common-security-advisory-framework-version-2-0-oasis-standard-is-now-published/
Common Security Advisory Framework Version 2.0
OASIS Standard
18 November 2022
So my guess is that Google has been working on their OSV schema in 2021 then CSAF was introduced?
This is understandable but giving the resources available to Google why not moving into CSAF now?

Hi,
The OSV schema was created as a first class format for describing vulnerabilities in open source. Please see https://security.googleblog.com/2021/06/announcing-unified-vulnerability-schema.html for the full rationale on why we created it. The summary is there is no other simple format available that actually enforces machine readability and ties it to actual open source versioning practices (such as git commits).
OSV-Scanner  provides SBOM support (with plans for automated VEX generation) to bridge the gaps with other standards.
We found the CSAF format lacking as a first class format for open source, but interoperability is still be possible -- it's completely possible to generate CSAF documents (VEX or advisories) from OSV schema entries, and something we could potentially build as part of the OSV-Scanner.
Closing this issue, but happy to discuss more.

Hi,
The OSV schema was created as a first class format for describing vulnerabilities in open source. Please see https://security.googleblog.com/2021/06/announcing-unified-vulnerability-schema.html for the full rationale on why we created it. The summary is there is no other simple format available that actually enforces machine readability and ties it to actual open source versioning practices (such as git commits).
OSV-Scanner  provides SBOM support (with plans for automated VEX generation) to bridge the gaps with other standards.
We found the CSAF format lacking as a first class format for open source, but interoperability is still be possible -- it's completely possible to generate CSAF documents (VEX or advisories) from OSV schema entries, and something we could potentially build as part of the OSV-Scanner.
Closing this issue, but happy to discuss more.


Initialize intl-tel-input-rails

Hey,
I just installed the gem, but I don't see how to get running the flags in the README, what I did:

Add the gem to my Gemfile gem 'intl-tel-input-rails'
Install it bundle
Require it in my application.js file //= require intlTelInput
Import it in my application.scss file @import "intlTelInput";
Add the phone id into my input field as well as the tel type (as indicated on the original plugin)

Nothing happens, how do I get this running? I can't see the flags or even the dropdown showing on my input field, why?
Note: I also did initialize the field with jQuery $("#phone").intlTelInput(); and nothing as well.
I'd really appreciate your help! 😃
Thank you!

Hi @bntzio
I think you have to override the image flag path as stated here.
We are actually working on integrating this into the gem, so that you might not have to worry about this any more in the next release
Hope this help
Jason


Notes for common Theme issues + Build Script instructions

Added note for the need to use absURL in the templates for generic theme assets. (this is a well known and common issue)

Added note for the need to use .RelPermalink in the templates for Hugo Pipes Resources:
See the following issues for the need to add this note:
https://github.com/gohugoio/hugoThemes/issues/419#issuecomment-419659750
https://github.com/gohugoio/hugoThemes/issues/395
https://github.com/lucperkins/hugo-fresh/issues/24

Added instructions for testing a theme with the Build Script locally.

Thanks Alexandros for your submission. This will be helpful to improve the theme submission process for both parties.


Podcast RSS feed

https://dyscribe.com/en/podcasting/podcasting-with-jekyll-in-4-steps.html
https://podba.se/validate/

https://kitchenknif.github.io/SlowChinese/podcast.rss is live, seems to be ok.
Submitted to iTunes

Discoverable on iTunes


Fix sql proj import asking for db twice if connection was to a db

This PR fixes #10982
old:

fixed:

Coverage decreased (-0.06%) to 35.28% when pulling b2834005be519237b93d0989a23a983c58eaca18 on kisantia/fixAskDbTwice into dfa87eda86e222def0bc15f3f1244ea8f17b989f on main.


(Backend) API to save article as draft & publish

Some points I came across related to this when creating the seed data:

The publication status depends on the publishedAt field. If it's set to a Date value then the article is published otherwise it'll be in Draft.
For scheduled published, the docs recommend following this guide - https://forum.strapi.io/t/schedule-publications/23184


OVERLAPBLOCK_Design_14#247

OVERLAPBLOCK (DESIGN 14) Issue https://github.com/KwickerHub/frontend/issues/247
I have created an overlap block that looks like the button in the given image.
If some changes required kindly tell I'll do it.

@jais-rishika that issues was not about creating a button but about creating that entire overlapblock design.(Design the entire image as seen in that issue. Make it responsive for desktop, mobile and tablets as you design.)
Hope you understand? and by the way, Hope you are doing great?

Yes!! Then I'll do that then.
About the images where to get the exact images or can i add any suitable one.
Thanks, I'm doing great :)

Hello 👋
Hope you are in good shape?
Please feel free to use other images. But avoid using external url images.
The different categories of modules have a section for image upload(If it
does not exist, U can create the folder inside that particular module).
Check buttons modules for insights...
Thanks...
On Fri, Jun 9, 2023, 10:29 Rishika Jaiswal @.***> wrote:

Yes!! Then I'll do that then.
About the images where to get the exact images or can i add any suitable
one.
Thanks, I'm doing great :)
—
Reply to this email directly, view it on GitHub
https://github.com/KwickerHub/frontend/pull/261#issuecomment-1584267205,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOKWIBJHUQS33RQJ4DHOUZTXKLUJDANCNFSM6AAAAAAYZVSGCU
.
You are receiving this because you commented.Message ID:
@.***>

OVERLAPBLOCK_Design_14#247 #261
I have created an overlap block like the given image.
I have added 4 images in OVERLAP_DESIGN_14_images folder in  modules\image_carousel\images_and_icons\OVERLAP_DESIGN_14_images
If some changes required kindly tell I'll do it.


little changes

get rid of warnings

Thanks @huguangju for your great ideas. I couldn't accept your pull request because too many things have changed in Petclinic but I've implemented your ideas for LogBack and our CSS content.


Conflicted with syntastic in MacVim.

After installed this plugin, syntastic no longer auto check after I executed :w, but manual call :SyntasticCheck still works fine.
I tested with the same .vimrc in terminal vim and this problem disappeared, so it only happen in MacVim.
Has there more details I should provide?

It works here.
Please make sure you are using the latest version of both plugins.


Versioning and section "Compatibility with MeiliSearch"

For the moment, MeiliSearch is not stable and uses a version tag like v0.X.Y.
Currently, the SDKs are not stable either and they use the same X than MeiliSearch for the versioning.
Problem: the MeiliSearch breakings are not the same as the SDKs ones.
Solution: after discussion, we decided to stop following the MeiliSearch versioning. Each SDK README contains a "Compatibility with MeiliSearch" section, so we should improve this section to explain the compatibilities to the user.
Here is the sentence I suggest, for the SDK python for example, once the v0.11 of MeiliSearch is out:
This package is compatible with these versions of MeiliSearch:
- `v0.11.X`
- `v0.10.X`

(The package might be compatible with the v0.9, but we are not going to mention the version of MeiliSearch before the v0.10 in this section since it was before we decided to change the versioning)
What about the previous SDK versions?
I suggest being simply because the SDKs are not stable yet. I mean do not mention the other SDK versions than the current one.
Ex: the SDK is in v0.11, the README will only mention the v0.11 (which is the current SDK version) and the MeiliSearch compatibilities. We are not going to talk about previous SDK versions like the v0.10 or the v0.9 in the README of the v0.11.

Here a PR example with the PHP SDK
https://github.com/meilisearch/meilisearch-php/pull/33

Here a PR example with the PHP SDK
meilisearch/meilisearch-php#33

Instead of writting in the SDK readme (as in the example PR):
This package is compatible with these versions of MeiliSearch:
- `v0.10.X`

I would specifically mention the current version (and former versions) as we don't know at what moment MeiliSearch core could introduce a change that breaks an SDK. So I would propose something like:
This package is compatible with these versions of MeiliSearch:
- `v0.10.1` or lower

But I know this would imply more work for every new MeiliSearch release. So what's your opinion on that?

Not sure I'm really motivated to change all the READMEs for each release of MeiliSearch 😬
Since we don't have a bot to do that, I suggest we use my first suggestion 🙂

I agree with your suggestion @curquiza but don't you think this should be mentioned sooner in the readme and with more flavor text?
Suggestion
🤖 Compatibility with MeiliSearch
This package heavily depends on the version of MeiliSearch you are using. Every version of this package is compatible up to a certain version of MeiliSearch. If you upgrade MeiliSearch, pay attention to the compatibility with this package. If the package version does not support your MeiliSearch version, it should be upgraded.
This package works for MeiliSearch >=v0.10.
This package is compatible with these versions of MeiliSearch:

v0.10.X

I like having an explication text before. What do you think @tpayet and @eskombro about the text? Could you improve it or it is clear and ok for you?

This package works for MeiliSearch >=v0.10.
This package is compatible with these versions of MeiliSearch:

v0.10.X

Why twice?

Bad copy paste from your PR sorry

The @bidoubiwa explanation lost me. I know @bidoubiwa is really into linking everything together but I do not agree on this one. I do not feel we need that much text to explain compatibility..
It would be clearer with @curquiza original suggestion imho, let's keep it simple for now!

Alright! And about putting @curquiza suggestion higher in the readme?

Yes! 👍 it should be before development workflow and after the getting started. But I do not know where compared to the examples

I put it right after the getting started. Is it "too soon"? (Reminder: there is alway a TOC in READMEs)
https://github.com/meilisearch/meilisearch-php/blob/d6c82fe5688bec9e1ee538eff3ec9a7e5a4c08fa/README.md

I've just changed to put it right after the getting started. Is it "too soon"? (Reminder: there is alway a TOC in READMEs)
https://github.com/meilisearch/meilisearch-php/blob/d6c82fe5688bec9e1ee538eff3ec9a7e5a4c08fa/README.md
(Spoiler: the Dev workflow will probably put in a CONTRIBUTING.md file in the future)

This seems perfect to me, simple, clear and in the right place.
I would change the text for:
This package is compatible with the following versions of MeiliSearch:

All READMEs have been updated.


Some time of check/time of use bugfixes

As described in bug #198 there are attack vectors in tar-rs at the moment. This patch corrects the worst of them, but doesn't go the whole way - changes to Filetime would be needed (or just not using that API at all) and I figured a discussion about that would make sense before going further.

Thanks!


Specimen assay data terms

Closes #1428.

Discussed on the OBI call 2021-10-18: Looks good. I plan to merge it, after a few other previous PRs.


docs: get rid of first-person references

Rewrote some statements that heavily rely on using first-person pronoun.

@oneminch looks great. Thanks again for taking this one!