NullPointerException fix

in com.fasterxml.jackson.databind.ext.CoreXMLSerializers the visitor is passed with a null as JavaType. Because of this a NPE could be thrown in TSJsonFormatVisotorWrapper.expectStringFormat(null)

@schurik, both Your commits contain lots of formatting changes that every other developer might want to reformat according to their preferences. Could undo the formatting changes?
I'm also wondering in which situation that NPE reveals itslef. There are lots of tests for jackson module, probably I've missed smth.

@atsu85 I will undo the formatting changes.
I am using XMLGregorianCalender in my model. Inside the CoreXMLSerialie.acceptJsonFormatVisitor method the visitor and null is passed to the delegate. And in case TSJsonFormatVisitorWrapper.expectStringFormat() the type is null. Here the NPE occurs

@schurik, thanks for undoing the formatting changes.
I tried to quickly reproduce the issue this PR should address, but i probably tried smth different, as everything seemed to work well, when I added
public XMLGregorianCalendar _XMLGregorianCalendar;

to DefinitionGeneratorTest.TestClass, the output included the field with number type that seems to be expected:

export interface TestClass {
    _XMLGregorianCalendar: number;
   // other fields and methods
}

What did You do differently? Perhaps You could even create/update the test for this issue Yourself?

In my case my model needs to be serialized as JSON and/or XML. My property has an addition @JsonFormat anntotation.
This is my setup:
@JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ss.sss'Z'", timezone = "GMT") public XMLGregorianCalendar _someDate;
and the output is:
export interface TestClass {     _XMLGregorianCalendar: string; }
and while serializing _someDate I get NPE without the null check

@schurik, thanks, I'll add the test myself.
Could You also squash the commits into single commit?

Hi @schurik, I had pretty-much forgotten this after failing to reproduce the NPE You reported and tried to fix with this PR. Please see my comments from the commit that tries to create the test for reproducing the NPE.
Please help me to figure out how to reproduce this issue, so the test could be updated and i could merge the fix.


Deduplicate "!?" and hentaigana in symbol.tsv

Description
A clear and concise description of this pull request.
There are some duplicated entries in symbols.tsv.
Warning about it sometimes appears when the build cache exists:
INFO: From Executing genrule //data_manager/oss:mozc_dataset_for_oss@symbol:
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
W0000 00:00:1730024913.429153   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: ！？
W0000 00:00:1730024913.436399   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛀁
W0000 00:00:1730024913.436467   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛀅
W0000 00:00:1730024913.436573   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛀢
W0000 00:00:1730024913.436658   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛀻
W0000 00:00:1730024913.436897   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛁭
W0000 00:00:1730024913.436956   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛁽
W0000 00:00:1730024913.437403   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛂎
W0000 00:00:1730024913.437440   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛂘
W0000 00:00:1730024913.437600   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛃖
W0000 00:00:1730024913.437640   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛃢
W0000 00:00:1730024913.437805   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄍
W0000 00:00:1730024913.437822   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄎
W0000 00:00:1730024913.437831   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄏
W0000 00:00:1730024913.437839   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄐
W0000 00:00:1730024913.437847   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄑
W0000 00:00:1730024913.437855   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄒
W0000 00:00:1730024913.437862   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄓
W0000 00:00:1730024913.437870   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄔
W0000 00:00:1730024913.437878   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄕
W0000 00:00:1730024913.437904   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄝
W0000 00:00:1730024913.437912   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄝
W0000 00:00:1730024913.437923   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄞
W0000 00:00:1730024913.437932   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄞
W0000 00:00:1730024913.437962   32852 gen_symbol_rewriter_dictionary_main.cc:185] already inserted: 𛄡

Issue IDs
Issue and/or discussion IDs related to this pull request.
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).

OS: [e.g. Windows 11, macOS 13.1, etc]
Steps:

Type "!" → Space
Confirm "!?" and "！？" labeled "[全] 疑問符" and "[半] 疑問符" appear (not only ⁉ labeled "絵文字 絵文字")

Additional context
Add any other context about the pull request here.
Looks like only first entry is adopted.

We have merged this PR.
Thank you for the contribution!


Improved validation vectors and added reach-metric

Adding two new functions for validation and monitoring:

metrics.partition_hypersphere: function for generating a predefined number of vectors which are (approximately) maximally spread-apart inside a d-dimensional hypersphere. It supports both l1 and l2 normalisation, which allows it to be used to either sample the space of stochastic or unit vectors. We now use it to generate the dataset of fixed preferences for the validation step. The previous method would generate a variable number of vectors which would grow exponentially in the number of objectives and would thus make it difficult to know how many such vectors will be generated a priori and difficult to combine with other conditioning methods such as focus_regions.

metrics.get_reach_metric: implements a new metric for evaluating the quality of a set of samples provided by a model optimizing multiple objectives. It takes averages the smallest distance ref-to-samples for a set of reference points which could be the "true" pareto-front (if known) or the limiting points of the unit-hypercube (if unknown). It thus simultaneously captures the volume of the empirical sample distribution in the objective space as well as its coverage of the true pareto front.

Converted as Draft for now. I want to:

Add some links to documentation (reach-metric actually corresponds to a known metric in the literature)
Add some derivatives of this metric including a clustering-based version that would account for how evenly populated each of the reference-points neighbourhoods are.
Add a parameter to reach_metric to dilate the range of variations for well performing empirical fronts.

Ready for review.

Find the analysis on the chosen metrics here
Find a validation experiment at the head of this branch here

Closing.


IOET's Freestyle Lite & Freestyle Freedom Lite driver

I'm creating a new PR based off #138 to be able to integrate changes faster.

LGTM, just one question about a comment I didn't quite understand @gniezen


Enhance documentation of modifyBlocks

@neilj, Squire is by far the most elegant, clean and flexible RTE I have worked with. The documentation though needs some examples and guides, especially on extending Squire. I'll be happy to open a PR for that, since I did some really heavy integration work and can provide several howtos:

One thing I am trying to figure out is how to remove entire block formats, in other words realizing "make headline" and "unmake headline". I managed to wrap the selection into a bock tag. Could you provide an example of removing a tag from a fragment:
// Triggered on click on the "Headline"-Button
function toggleHeading(editor, tagName = "h1") {
  if (editor.hasFormat(tagName)) {
    editor.modifyBlocks(frag => removeTag(editor, frag, tagName));
  } else {
    editor.modifyBlocks(frag => wrapInTag(editor, frag, tagName));
  }
}

function wrapInTag(editor, frag, tagName) {
  const output = editor._doc.createDocumentFragment();
  let block = Squire.getNextBlock(frag);

  while (block) {
    output.appendChild(editor.createElement(tagName, [Squire.empty(block)]));
    block = Squire.getNextBlock(block);
  }

  return output;
}

function removeTag(editor, frag, tag) {
  // How to remove the tag from frag?

  return frag;
}

More/better documentation would be great! Also happy to replace the demo if you want to do a better one with your integration.
Regarding your question, I would do this:
Squire.prototype.changeBlockType = function ( tag, attrs ) {
    if ( !tag ) {
        var config = this._config;
        tag = config.blockTag;
        attrs = config.blockAttributes;
    }
    return this.modifyBlocks( function ( frag ) {
        var walker = Squire.getBlockWalker( frag, this._root );
        var output = this.getDocument().createDocumentFragment();
        var node;
        while ( node = walker.nextNode() ) {
            output.appendChild( this.createElement( tag, attrs, [
                Squire.empty( node )
            ]));
        }
        return output;
    });
};

Then to "make heading", call something like editor.changeBlockType( 'h1' ) and to revert to the default block type (normal paragraph style) just call editor.changeBlockType().

That works perfectly, thanks! I'll gebt back to you regarding the docs and demo.

@neilj Your example of using modifyBlocks is really helpful. Is there any reason the changeBlockType function shouldn't be added to core, especially since toggling headers (and other block-level elements like <p> and <blockquote>) is such a common feature for RTEs?

For anyone stumbling here in some 6 years later, this seems to do the trick with Squire v2.0.2:
  function toggleBlockType(tag: string) {
    editor.modifyBlocks(function (frag): Node {
      if (frag.children.length != 1) {
        return frag;
      }
      const orig = frag.firstElementChild;
      if (orig === null) {
        return frag;
      }

      const tagName = orig.tagName == tag ? "DIV" : tag;
      const elem = frag.ownerDocument.createElement(tagName);
      while (orig.firstChild !== null) {
        elem.append(orig.firstChild);
      }
      return elem;
    });
  }

For Svelte, you do something like
    <button class="button" on:click={() => toggleBlockType("H1")}>H1</button>


update Azure cloud controller versions

This PR:

updates azure-cloud-controller-manager
updates azure-cloud-node-manager
changelog with recent renovate changes

Testing
Description on how default-apps-azure can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for default-apps-azure installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Trigger e2e tests

/run cluster-test-suites

/run cluster-test-suites


Update sample-s-float--int-uint-.md

@briannagerads : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add tracestate to exports

We're hard-coding an empty string for tracestate when we encode spans for export. Unless I'm missing something, we should pass tracestate along to the exporter (see trace proto).

Review this PR: https://github.com/yangxikun/opentelemetry-lua/pull/41

@plantfansam Please review this PR: https://github.com/yangxikun/opentelemetry-lua/pull/41

Sorry for the delay @yangxikun, I was away - PR looks good!


pod update issue

[!] CocoaPods could not find compatible versions for pod "Sentry":
In snapshot (Podfile.lock):
Sentry (= 7.11.0, ~> 7.11.0)
In Podfile:
sentry_flutter (from .symlinks/plugins/sentry_flutter/ios) was resolved to 0.0.1, which depends on
Sentry (~> 7.18.0)
You have either:

changed the constraints of dependency Sentry inside your development pod sentry_flutter.
You should run pod update Sentry to apply changes you've made.

@bawantha you have just to pod update and likely pod install again, it's not a Sentry issue.
This should be done in the ios folder of your app likely.


Refresh button doesn't refresh Integrate UX

@alrod can you add the OGF for this issue?

@soninaren. Added.


Missing merge strategy for head hook method

Version
v1.4.2
Reproduction link
https://github.com/adrienbaron/vuetify-bug-theme-nuxt-i18n
Steps to reproduce

Create a Nuxt + Vuetify project
Update to Nuxt (1.4.2) and Vuetify 1.2.2
Add nuxt-i18n (5.2.1) to the project
Run the sample app

What is expected ?

Vuetify theme and Nuxt i18n meta should be added

What is actually happening?

Only Nuxt i18n meta is added

Additional comments?
This is also broken in Nuxt Edge.
I initially thought it was a bug in Vuetify 1.2.x and opened an issue there: https://github.com/vuetifyjs/vuetify/issues/5032.
It turns out that Nuxt is missing a merge strategy for the head hook.
Nuxt should probably declare this merge strategy to avoid those kind of conflicts:
Vue.config.optionMergeStrategies.head = Vue.config.optionMergeStrategies.data

This bug report is available on Nuxt community (#c7684)

@adrienbaron Could you add a PR for that? :relaxed:

Ok, so after trying to get this to work, I noticed that my fix actually breaks some behavior of Vue Meta (thank you unit tests ^^).
I wonder if this fix should not be in Vue Meta, but I just learned about it today so I'm not sure.
From reading their doc, it seems to already deal with merging info, between parent and child components. Maybe they just don't support merging info from mixins?

I think vue-meta does not support merging from mixins indeed, I am open for any help on improving vue-meta @adrienbaron

Will be resolved with https://github.com/declandewet/vue-meta/pull/262


Problem with the Language Server: command 'roslyn.changeRazorCSharp' already exists

Environment data
dotnet --info output:
.NET SDK:
Version:   7.0.302
Commit:    990cf98a27
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22621
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\7.0.302\
VS Code version: 1.79.2
C# Extension version: v2.0.212
Steps to reproduce

Go to 'Any C# Project"
Press "CTRL+Shift+P' and select "> .NET: Restart Language Server
See error: "Command: .NET Restart Language Server resulted in an error: command 'roslyn.changeRazorCSharp' already exists"

Expected  behavior
The Language Server restarts
Actual behavior
The Language Server seems to restart but the code highlighting is incomplete, often simply wrong and in glitchy in general.
Additional context
After working on a project for a while, sometimes even from the beginning, the code highlighting, the warnings and the errors stop working properly. If I try to restart the language Server than I receive that error.
I've installed the C# dev Kit.

Duplicate of #5779

Yup - closing as duplicate of https://github.com/dotnet/vscode-csharp/issues/5779


Event Request] Table 900 "Assembly Header" – New Event “OnBeforeCalcEndDateFromStartDate”

Could we please have a new publisher “OnBeforeCalcEndDateFromStartDate” in Function “CalcEndDateFromStartDate”, Table 900 "Assembly Header"?

    local procedure CalcEndDateFromStartDate(StartingDate: Date): Date
    var
        ReqLine: Record "Requisition Line";
        LeadTimeMgt: Codeunit "Lead-Time Management";
    begin
*** Start new code ***
        OnBeforeCalcEndDateFromStartDate(Rec);
*** Stop new code ***
        exit(
          LeadTimeMgt.PlannedEndingDate(

*** Start new code ***
    [IntegrationEvent(false, false)]
    local procedure OnBeforeCalcEndDateFromStartDate(var AssemblyHeader: Record "Assembly Header")
    begin
    end;
*** Stop new code ***

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


status entities for battery calibration & balancing

This PR implements #264.
It provides two new binary sensor entities that show whether battery calibration or balancing are currently active:

I don't like the naming much, maybe there is a better alternative?
A viable alternative to having two separate entities would be to have only one entity (like Battery Operation Status) with a custom enum state consisting of Calibrating, Balancing, Normal operation.
The current ID generation logic in this integration does not cater for the situation where multiple entities rely on the same set of objects, that's why I needed to "hack" my way around this by adding an actually not used object. I don't fully understand why you didn't rely on the entity key that is defined in entities.py, but there might be good reasons for that.
Last but not least: I am aware that you tried to keep a certain level of abstraction in handling objects, entities and their relation, which gets a bit contradicted by the very explicit methods get_battery_calibration_status and get_battery_balancing_status, but I couldn't come up with a better way.

Hi @oliverrahner, thanks for opening this PR and for providing such a useful description :heart_eyes: I'll try to set some time aside for a review within the next few days.

:information_source: I took the liberty of merging main into your PR branch so it uses the most recent linting action and dependency versions

@weltenwort Is there anything I can do to have this integrated? Do you see any issues that I could solve or is it just lack of time on your end?

It's indeed just a lack of time :see_no_evil: Sorry to keep you waiting for so long. Thanks for making the changes, I'll try to prioritize looking at it this weekend :crossed_fingers:

Hey @oliverrahner, thanks for your willingness to refactor. Since I had the editor open I figured I could also give it a try. I opened https://github.com/oliverrahner/home-assistant-rct-power-integration/pull/1 against your main branch in case you haven't done any refactoring yourself. Please feel free to close it if you already have a better implementation.

Plans to merge these in the next release?

@oliverrahner thanks again for submitting this. I took the liberty of including your findings with some modifications in #349.
@V4n1X the new "Battery Status" entity has been released in https://github.com/weltenwort/home-assistant-rct-power-integration/releases/tag/v0.12.0.

@weltenwort thanks for picking this up again, I lost it out of focus… much appreciated :)


the order of one grid item is not preserved

Steps to Reproduce

Go to "https://shrek-gabe-itch.github.io/StartPage/"
Drag the imgur card anywhere on the grid
Reboot page
Imgur card position will no longer be saved
but all other cards keep their order

repo https://github.com/shrek-gabe-itch/StartPage
Version

package
version

sortablejs
v1.10.2

for some unknown reason, the problem was in the href tag ¯_(ツ)_/¯
he was like that
https://github.com/shrek-gabe-itch?tab=stars


added a basic (and buggy) on-click support

i'm having a little trouble adding mouse support since I don't know how to correctly map an on-screen x coordinate to the matching column. I think I'm missing an offset/padding and might use a wrong factor.
Any suggestions?

This is somewhat related to #4.

I am currently re-doing the text positioning. Once it's done, it should be fairly easy (and different than it is now) to compute the click's line number. We can get the column using the glium_text::get_char_pos_x(n) function. This function returns the on-screen offset of a given character. It's parameter is a position of the character, in bytes.
Best to wait for the changes with this.

Updated a comment on get_char_pos_x, so it (hopefully) describes the result accurately (cf32132).

okay, I think we should close this PR and I'll open a new one with the new implementation.

I finished a simple mouse-click implementation. Used some code from this PR.


 Instead of making making huge temporary table and make filtering on that?

I opened a similar issue long ago, no progress yet: https://github.com/yandex/ClickHouse/issues/863

I stopped using views in ClickHouse due to this problem - had to switch to long queries. And if you make a view materialized and run the last query the system becomes unresponsive for a couple of hours (depending of data volume in underlying tables)


Check shouldCreate prop before running

Previously the user input confirm step was not being checked
and the feature folder would always be created.
This change exits the process if the user does not confirm.

Closes https://github.com/Fullscreen/generator-redux-feature/issues/1


Validator added every time a step is submitted

https://github.com/UKHomeOffice/passports-form-controller/blob/master/lib/validation/index.js#L62-L67
This appears to be an issue with any step that contains a field with options (radio, typeahead etc).  An additional validator is added to the list of validators (created if empty) to check the value is in the list of options. The problem being that it doesn't check if the validator has already been added, and mutates the original array (reference to original stored, not cloned).
More worryingly is that this is persisted for the life of the instance, and across all users, each user that completes that step causes another identical validator to be added to the validators config, and this is persisted server-wide causing a potentially large memory leak.
@gxxm has been working on a fix, but probably worth pointing out to @easternbloc @JoeChapman @daniel-ac-martin and @gavboulton as will likely be affecting live systems.
This likely wasn't picked up before as the same validator is added many times, so the reduce below just calls the validator function over and over again yielding the same result (this should be replaced with _.any for efficiency), @gxxm noticed it when altering the options dynamically based on the results of a postcode lookup - multiple validators are added with different options and validation always fails

Nice catch guys!
I doubt this will be the only place where we have this bug.
In this case it is easy to fix as we can just test whether the validator already exists.
But, there is a wider question of how can we patch the validators whilst limiting the scope of the patch to a single request. Ultimately, I think we should be performing a deep copy of the fields object (which starts its life as configuration, which we tend to think of as immutable, but isn't really "because JavaScript") on every request. Then we can patch it on a pre-request basis.

yeah a deep clone would fix this case but as you said this may not be the only place the bug occurs. We should be ideally making config immutable - could use something like https://facebook.github.io/immutable-js/ or https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze. Obviously @gxxm's current method of setting options on the fly would need rethinking slightly, could perhaps unfreeze, amend the re-freeze?

actually there isn't a way to unfreeze but still think we should consider locking config down

+1 for making config immutable, unfortunately Object.freeze means that in most cases, in strict mode trying to modify a "forzen" object will throw a TypeError so we might need to change more than just how we create the config.

Nice spot! More debug around this might have made it visible earlier. It's something I'm keen to add more to our modules https://github.com/UKHomeOffice/hof/issues/90

Yes, it will need some thought but will hopefully pinpoint any other places in the code where we are directly modifying config

@joefitter: A deep copy of fields on each request should fix all the related bugs as well shouldn't it?
Obviously code should still check that a validator doesn't already exist when adding it to the list.

@daniel-ac-martin yes it would but it wouldn't stop us from unknowingly altering the fields object again somewhere further down the line, or steps, or any other config we may wish to pass. Object.freeze should be used on any config objects to ensure this doesn't happen in future, but a deep copy on each request should fix the current issue

In case it isn't obvious, I'd like to say that I think this bug should have quite a high priority (though I'm biased). - We do need to patch the validators on a per request basis and this bug can potentially allow a malicious user to render the forms un-completable for other users. (My new date-controller suffers from this but cannot really be fixed until it is fixed here.)
Of course, I also think this will be a pain to fix. Anyone feeling energetic?

You start Dan.

@JoeChapman: Well I'm sure I will at some point, but I don't really get any time in my working day to do HOF stuff. (Been mainly writing Scala recently.) So really me being able to do this all hinges on me having no life. ;-)
Just wanted to put this out there in case someone has the time to work on fixing miscellaneous bugs in the HMPO form stack.

Thanks @joefitter and @gxxm for flagging this!
The Passport renewals service has now gone public, so keen to plug the memory leak as an initial step - https://github.com/UKHomeOffice/passports-form-controller/pull/47

Cheers @daniel-ac-martin for merging.
In terms of the wider discussion, I agree about immutable config. However, not so convinced about patching validators per request (quite possibly due to not really knowing the specifics of what you are doing).
What if validators (formatters, etc...) could instead ask for the data they need: https://github.com/UKHomeOffice/passports-form-controller/commit/a1ebdecb4dc25c7e72518df1f55735766c94281e?
Is that viable, and would it give enough flexibility to satisfy the needs of, for example, the date controller?

@oli-weighell2: Yes I've been coming around to that point of view as well. It does mean that we will need something in the fields config to indicate that a field should be treated as an input-date mixin. (Support for the input-date mixin is the reason I thought we would need this.)
I'd favour introducing a new concept (processors?) rather than expanding the scope of the validators and formatters. - They are quite neat little things as thing stand.
I have a few ideas, but they will require PRs on the HMPO stack rather than simply being a controller that can sit in its own module.

Updated https://github.com/UKHomeOffice/passports-form-wizard/issues/35 to discuss.

Incidentally, deep copy is a PITA in JavaScript in any case.

@daniel-ac-martin we use https://lodash.com/docs#cloneDeep

however I dont think underscore has an equivalent

It does not. We should move all the things to lodash imho

@easternbloc I started to do just that in a branch. Stuff broke and I ran out of time. :-(
(Though I think the hmpo modules might use an old version of underscore which might be the cause of the breakage.)

fixed by deep cloning options a while back


Update Record Flow Type Definition

I added update and withMutations. The definitions for setIn, getIn, and updateIn are going to be a bit trickier.
Looking here for functions not included in the documentations: https://github.com/facebook/immutable-js/blob/master/src/Record.js#L131-L146
FYI this PR contains a commit from https://github.com/facebook/immutable-js/blob/master/dist/immutable.js.flow

@ccorcos This repo is not actively maintained as far as I can see. I created a PR in flow-typed to add flow definitions for immutable there.
My fork is here. Feel free to submit a PR with your changes there.

@leebyron do you know if ImmutableJS is being maintained?

@wokalski thanks! I'll check em out

I'd love to see this implemented as well. I just setup Flow in my project, and it is counterproductive to keep seeing warnings that withMutations is not found in Record.

@ccorcos Yeah we are maintaining this now all seriously-like. I was thinking it would be nice when we update flow types to make sure they are exercised in a test (for the withMutations part) - does that seems sane? Or is that already happening somewhere.

@lacker flow-typed seems to be the new place to maintain 3rd party lib defs -- they have test setups and everything...

OK so https://github.com/facebook/immutable-js/pull/878 is in now so we have some Flow type refactorings and also you can now test flow types. Would you mind updating to merge those changes in, and also adding a test that catches these changes? Thanks!

Here's something interesting I've been experimenting with in my own code.  It's painfully verbose, but it typechecks extremely well.
// @flow

import {Record as iRecord} from 'immutable'

declare class RecordAPI<T> {
  constructor(init?: $Shape<T>): void;
  get<A>(key: $Keys<T>): A;
  set<A>(key: $Keys<T>, value: A): Record<T>;
  hasIn(keys: Array<any>): boolean;
  update<A>(key: $Keys<T>, updater: (value: A) => A): Record<T>;
  updateIn<A>(path: Array<any>, updater: (value: A) => A): Record<T>;
  merge(values: $Shape<T>): Record<T>;
  withMutations(mutator: (mutable: Record<T>) => any): Record<T>;
  inspect(): string;
  toObject(): T;
}

export function Record<T: Object>(spec: T): Class<RecordAPI<T>> {
  return iRecord(spec)
}

type AddressInit = $Shape<{
  street: string,
  city: string,
  zip: string,
}>

class Address extends Record(({street: '', city: '', zip: ''}: {
  street: string,
  city: string,
  zip: string,
})) {
  street: string
  city: string
  zip: string
}

type UserInit = $Shape<{
  name: string,
  address: AddressInit,
}>

class User extends Record(({name: '', address: new Address()}: {
  name: string,
  address: Address
})) {
  name: string
  address: Address
  constructor({name, address}: UserInit = {}) {
    super({name, address: new Address(address)})
  }
}

const user = new User({
  name: 'Andy',
  address: {
    street: 'wherever',
    city: 'Austin',
    zip: 'TX'
  }
})

user.set('name', 2)

console.log(user)
console.log('user.address instanceof Address:', user.address instanceof Address)

const user2 = new User({name: 'Bob'})

console.log(user2)
console.log('user2.address instanceof Address:', user2.address instanceof Address)

Feel free to submit a PR if you have something working.

Should this be rebased or closed?
I'd love to see the definition for Record's constructor (and the object it returns) improved here.

I'd say closed and rewritten

@ccorcos, from conversation above, it looks like this PR should be closed. Let me know if it is not correct assumption. 😅

Thanks for responding and tagging this issue @kozlitinaelja!
It would probably help the community a lot if we could get the flow definitions that are shipped with this package moved out into flow-typed so we have a path to keep them updated together (or even to allow us to change by hand in our flow-typed directory).

@kozlitinaelja this PR is based off of https://github.com/facebook/immutable-js/pull/961 which simply defines types for the module default exports. So in fact, its only a 2 line change adding type definitions to Record for update and withMutations.
The other PR you mention does not fix these PRs and only tests the existing functionality. For example Record is a TODO: https://github.com/facebook/immutable-js/pull/878/files#diff-167148588528b5fa451dc535e9c29037R429

@ccorcos could you remove the unrelated changes of handling exports? We should tackle that in a different PR. Also, please add some tests (see type-definitions/tests) that describe the correct behavior.

@wokalski unfortunately, mystifying Flow errors occasionally occur when I use my RecordAPI type...I'm not sure if Flow object intersections still have bugs, but it sure seems like it.
The other problem with turning my suggestion into a PR is it's so verbose and I'm not sure I can make it work for both class extension and non-class extension usage of Record().  Any thoughts?

@jedwards1211 I'd say let's wait for the conclusion of this PR.
@rgbkrk I started doing it in a PR to flow-typed but dropped it in favour of defs built in here. Maybe it needs to be revisited. You get many nice things with flow-typed like versioning. My line of thinking is that it allows more people to use flow defs. They don't need to use yet another tool.

Closed by #1073

#1073 seems to be related to TS.
Records are still missing most of the definitions in flow:)

Yeah my mistake on typescript vs flow specific. I'll get equivalent changes out to flow types next :)

Lovely. :)
Just in case its needed and you are not aware of it already, there is this gist on the subject:
https://gist.github.com/glenjamin/75a96b45f4bb5c6ac221815d28c548dd


Click event does not work for "Child" when parent is using kinetic (Chrome Android)

When I attach the kinetic plugin to my photo reel, it works fine on my desktop PC, but on my Android mobile device it only allows you to slide/drag the photo reel, it does not allow you to click on the photos themselves.
The page is at http://lindseymotors.com/v if you click the default photo an expanded view pops up with a photo reel at the bottom. This is the element that has the kinetic plugin attached to it. When you click a photo, it should trigger the .click() function of viewVehiclePhoto($(this)) but does nothing on my mobile device.
This is how I'm attaching the plugin to the photo reel:
$('.vehicleDetailExpandedPhotoReel').kinetic({
    filterTarget: function(target, e){
        if (!/down|start/.test(e.type)){
            return !(/area|a|input/i.test(target.tagName));
        }
    }
});

I use iphone 6 to browse http://lindseymotors.com/v

initialization
scroll down a little
touch the photo
touch the photo again

the behavior just like first touch will focus on something, and the second touch will trigger the function you mentioned
I have no android device to test now, it's welcome to send PR for solving your problem.

See https://github.com/davetayls/jquery.kinetic/issues/93#issuecomment-262601590


Is it possible to specify Output File Object manually?

Thanks for super easy library, it's really awesome!
But after having some app built around this library we have a requirement to specify Output File Object which would be the output for recorded video. Is there a way to do this ?
I couldn't find it from existing API

Next release, available in a day or 2.

Is it available in the latest Api ? i had searched it haven't found it in this API

@ayubbaba I've added that feature when I saw it is missing 😕
So you can get it by pulling here
https://github.com/gogopop/CameraKit-Android/pull/70
Don't know exactly why, but pull request not merged ... that code working in our mobile apps now

I will pull the code but how can i intergate it can give me example like cameraview.setVideoOutputFile(Here desired folder right) ?

API is the same, I just added another function overload for File argument
void setVideoOutputFile(File outputFile)
So the API would be something like this
cameraview.setVideoOutputFile(fd) where fd is your manually created file handler with File type (or extended from it).
I've used this functionality for making Pipe Socket, but for files it will work just fine.

Ok Thanks i will try

@ayubbaba   Excuse me , i use author's API  but my outputfile  don't have the mp4 file, and i want to compress the file by h264 but when i use it the project is error,  can you help me ? thanks

@tigranbs
How can i get this method I just found 0.9.18 version but its havnt anything inside
so can u plz tell me what to do for that?

@vishalpatel1327 please take a look on a comment
https://github.com/gogopop/CameraKit-Android/issues/64#issuecomment-306577250
Don't know that match about versions, I just needed at that time this functionality, added it and asked for a pull request, but it's didn't merged to master. So you can just get files/changes from that pull request and edit the version that you have.

that means i cant use compiled lib
I have to pull whole code and change those  file
am i right @tigranbs

@vishalpatel1327 probably Yes that's the only solution for this issue, I've did the same thing ... otherwise you can just talk with this repository maintainers and understand why they don't want to add that functionality

ohk Thank you so much for Giving such quick reply  :)


tomcat: tomcat.init.erb - remove sourcing of setenv.sh

setenv.sh is already sourced by catalina.sh which is used by the init script,
which caused it to be sourced twice. This is a problem when variables are only
appended to.
I tested it on a Debian server were tomcat is installed by packages and a RedHat server where it's installed from source. I hope there's no corner cases which would break with this.

This pactch was rebased and merged. Closing pull request.


Rewrite docs for first-class AZs

The first-class AZs documentation had not been updated to the Bosh v2 wording, (lots of “VMs” instead of “instances”).
Three main goals in this rewriting:

clearer (titles) structure
updated Bosh v2 wording
improved markdown style

Ping @mvach & @ystros for your reviews 🙏

Thanks a lot for the review @ystros, and advices @beyhan & @rkoster!
I've pushed one more commit that fixes the typos, move the former header to the bottom, and introduce a new header.
Let me know what you think of it.


Improvements suggested by StevenGJ

@stevengj

It seems like you implemented every function twice, once for the complex coefficient and once for its absolute value squared. Why not have the latter simply call the former?

Done

You also calculate T_p via 1 - R_p, which may suffer catastrophic cancellation if the reflectance is close to one. Using abs2(t_p) via your t_p function avoids this.

In making the previous change, I did this. However, I noticed that T_s and T_p are now off by a factor of almost 2 (but not quite) from satisfying conservation of energy.
julia> let
           n1 = 1
           n2 = 2
           θ_i = deg2rad(10)
           @show R_s(n1, n2, θ_i)
           @show T_s(n1, n2, θ_i)
           @show R_p(n1, n2, θ_i)
           @show T_p(n1, n2, θ_i)
           nothing
       end
R_s(n1, n2, θ_i) = 0.11454557997889622
T_s(n1, n2, θ_i) = 0.43765391958146965
R_p(n1, n2, θ_i) = 0.10771599997760896
T_p(n1, n2, θ_i) = 0.44102957889162075

This of course relies on the underlying t coefficients. But they are taken straight from the wikipedia article:
function t_s(n₁, n₂, θᵢ, θₜ)
    num = 2n₁ * cos(θᵢ)
    den = n₁ * cos(θᵢ) + n₂ * cos(θₜ)
    return num / den
end

function t_p(n₁, n₂, θᵢ, θₜ)
    num = 2n₁ * cos(θᵢ)
    den = n₂ * cos(θᵢ) + n₁ * cos(θₜ)
    return num / den
end

So there is an error in the wikipedia-article, my copying of them, or your suggested abs2(t_p). Actual code below:
T_s(n₁, n₂, θᵢ, θₜ) = abs2(t_s(n₁, n₂, θᵢ, θₜ))
T_p(n₁, n₂, θᵢ, θₜ) = abs2(t_p(n₁, n₂, θᵢ, θₜ))

So do you have a suggestion as for what to do? Perhaps you have/know of a test-set that can verify the coefficients for some test-case, where all the expected outputs are known?

Sorry, I forgot that the definition of the complex t is a bit different.  As summarized in WP:

It should all be well and good now ^_^


disable assertion on card holder name in E2E tests

the E2E test is currently failing because the card holder name is being overwritten.
And we have to wait for stingray team to fix it in the backend, which might take a while.
So we'll only disable the assertion on the card holder name for name, so that the test doesn't fail everyday.
We'll enable it again, once the fix is in.

PR: https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/2652

only commented out one small assertion
grouped all my-account tests together.


Version <IP_ADDRESS> is not available on Windows Python 2 nor Linux Python 3

@ocefpaf is there a reason why the binaries did not post for these two variants. Is there a way I can re-render the feedstock?

The auto re-render has a [ci skip], that only CircleCI obeys BTW, which won't produce the new packages even though the extra matrix item was added (PY36). So a manual re-render (actually only a CI trigger) should do it.
I will investigate the PY=2 though. That should exist already.

looking here: https://anaconda.org/conda-forge/ulmo/files
we are missing win64/py27, linux64/py34 and linux64/py35 for v<IP_ADDRESS>

@ocefpaf I just made a 0.8.4 release of ulmo. Once tests have finished running I'll merge the updated recipe in. So fixing the <IP_ADDRESS> binary availabiliy issue is not really needed anymore.

I never got the time to see that happened with Python 2 package, sorry.


split up pickup event

SpongeAPI | SpongeCommon | SpongeForge

other Entities picking up items is not that easy to implement so i'll do that in another PR
(after the refactor/inventory one)


[DOC] Add the link to oneAPI samples browser

Description
Add a note to examples.rst with the link to oneAPI Samples Catalog.

/intelci: run

Hello , is the issue fixed I would like to work on it.


Drop "xml2js" for "elementtree" dependency

Cordova uses elementtree to handle config.xml and grunt-bump-cordova uses xml2js.
Both libs output config.xml differently which causes unwanted file modifications depending of which command was used last. The best would be to reimplement grunt-bump-cordova using elementtree to avoid this kind of issue.
Ex: call grunt bump then cordova plugin add <any_plugin> --save

Solution would be to rewrite this part:
https://github.com/aaccurso/grunt-bump-cordova/blob/master/tasks/bump.js#L101-L132
where parseString and xmlBuilder are being used :)

Any volunteer?

I'll do it.

Merged in version 0.1.7


FieldNameRenderer's onClick does not suppress default link behavior

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [1.6.0]
Expected / Desired Behavior / Question
As indicated in the documentation, I would expect that specifying an onClick property on a FieldNameRenderer would cause the link's default behavior to be suppressed, but it is not. There also doesn't appear to be any API for preventing the link's default behavior (e.g. something analogous to event.preventDefault()).
Observed Behavior
The function indicated in the onClick property does run, but the link's default behavior also executes.
Steps to Reproduce

Use the @microsoft/sharepoint yeoman package to create a new field customizer extension with the name FieldNameCustomizer. When prompted for a framework, select React.
Install @pnp/spfx-controls-react using npm
Open the project in VS Code or some similar editor
Make the following to changes FieldNameCustomizer.tsx:

Add the following imports:

import { FieldNameRenderer } from '@pnp/spfx-controls-react';
import { ListItemAccessor } from '@microsoft/sp-listview-extensibility';

Change the IFieldNameCustomizerProps interface to:

export interface IFieldNameCustomizerProps {
    listItem: ListItemAccessor;
    fieldValue: any;
}

Change the render() method to:

public render(): React.ReactElement<{}> {
    return (
        <FieldNameRenderer
            isLink={true}
            text={'link ' + this.props.fieldValue}
            filePath={this.props.listItem.getValueByName('FileRef')}
            onClick={() => console.log('clicked')} />
    );
}

Make the following change to FieldNameCustomizerFieldCustomizer.ts:

Change the React.createElement(...) line to:

React.createElement(FieldNameCustomizer, { fieldValue: event.fieldValue, listItem: event.listItem });

Launch the server by running gulp serve --nobrowser
Create a new document library and upload one document to it. Ensure that you are viewing it in the Modern UI.
On the library's page in your browser, append the following to the page URL, replacing the (add customizer GUID here) portion with the customizer's actual GUID.

?loadSPFX=true&debugManifestsFile=https://localhost:4321/temp/manifests.js&fieldCustomizers={"FileLeafRef":{"id":"(add customizer GUID here)","properties":{}}

Verify that the customizer is working by checking that the name of your file in the library is prepended with the text "link "
Open the browser console.
Click the filename

EXPECTED: "clicked" is logged to the console and nothing else happens
ACTUAL: "clicked" is logged to the console and then the link's default behavior takes place

Thanks @JLRishe for posting this one!
I'll take a loot at it in next few days

So, after talking to SharePoint dev team guys I will post an issue on GitHub for them.
The thing is that the default behavior of file preview/download is initiated from upper level of DOM.
And it looks like not even on onClick event because stopping the propagation and preventing default behavior doesn't help.
Basically, because of that, now both your onClick and default handler will be executed.
I will link this issue with the one for dev team as soon as I will create it.

@AJIXuMuK Thank you for looking into this so quickly!

Hi JL
I am trying to reproduce the point where you are now, since I need this feature also, but I am new to this developer environment. To start, I am having trouble finding the FieldNameCustomizer.tsx file, it is something you create from scratch? if so where, or it comes with the @pnp/spfx-controls-react install.
I had customized the FileLeafRef onclick event by means of the standard hello sample finding the same  dual clicking behavior you experienced with the oob render.  Perhaps modifying the href tag may work.
Any guide will be greatly appreciated

@ralftokada It might be better to open up a separate inquiry since your question is a bit off topic for the issue being reported here. The file I am referring to as "FieldNameCustomizer.tsx" is the boilerplate component file that's created when using yo @microsoft/sharepoint to create a field customizer with React. In step 1 of my repro steps, I indicated naming the field customizer "FieldNameCustomizer", in which situation the component file would be automatically named "FieldNameCustomizer.tsx".

@AJIXuMuK That's great! Thank you so much.

Thanks Alex and JL,
Alex, I just downloaded what I believe the latest version using npm i @pnp/spfx-controls-react
Does it have this fix?, I tried it and still have the default onClick behaivor. Also I noticed there are no changes when setting the hasPreview parameter, unless I misunderstand it (I was hopping to see the preview when I hover the name link)
Sorry for my ignorance, this tools setup are new to me.
Thanks in advance

Hi @ralftokada ,
No, it's not.
Please, see the referenced PR - it is still open and not merged to the main branch.
hasPreview parameter is needed to understand if we need to generate link for File Preview in SharePoint or link to directly download the file. It is actually a standard behavior as well. For example, SVG files don't have a preview and are downloaded directly.

Thanks @AJIXuMuK this is planned to be released with the version 1.7.0.


How do I Login into the admin area ?

I installed Saleor on my localhost and tried to login into the dashboard at URL
http://<IP_ADDRESS>:8000/account/login/
with the Login credentials<EMAIL_ADDRESS>However it gives the following errors:

How do I login into the the admin area ?

The credentials are for Heroku. If you work with your local machine start with python manage.py createsuperuser to have Django create an admin user for you.

My bad.  Thanks for the prompt reply

You're welcome! :smile:


[master][KOGITO-1597] Refactor Cucumber tests to get rid of KogitoAppDeployment

Signed-off-by: Karel Suta<EMAIL_ADDRESS>https://issues.redhat.com/browse/KOGITO-1597
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

Cucumber tests passed (apart from Jobs service which is broken now)
Ready for review.

@radtriste setupBuildImageStreams and namespace declaration moved to GetKogitoAppStub, all values in cliDeployService are taken from KogitoApp.

@sutaakar ahah about setupBuildImageStreams I was just thinking about letting it like it was :S
that will impact (for now) the travel agency and it has been moved to kogito-examples (or still in progress but soon enough) and will then follow the different versions of Kogito for now.
so better to override with the test version.

@Sgitario nil checks removed


Add option to use AWS S3 for Sentinel Hub

Summary
Describe this issue summary here.
Goal
Describe the definition by which this issue will be closed.
Todo

[ ] task1 to do
[ ] task2 to do

Deadline
xx/xx
Parent issue
None
References
None
Notes
None

https://github.com/sentinel-hub/sentinelhub-py/blob/master/examples/aws_request.ipynb


feat(elements): Add signup identifier components

Description
During the sign up flow, when moving to the phone_code or email_code verification steps, we render the provided email address or phone number. This PR introduces both <SignUp.EmailAddressIndentifier /> and <SignUp.PhoneNumberIdentifier /> components.
https://linear.app/clerk/issue/SDK-1830/add-signup-elements-for-accessing-email-address-and-phone-number
https://github.com/clerk/javascript/assets/825855/2e3b6b4c-32fd-49b4-8731-0916668fdfa8
Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

@alexcarpenter can we consolidate into a single Identifier component? Or is the distinction necessary?

@alexcarpenter can we consolidate into a single Identifier component? Or is the distinction necessary?

I was looking into it, but I wasn't able to find the state which let me know if which strategy we are within (phone or email), the state machine state only showed which step we were within e.g. verifications.

Closing in favor of just accessing these values from the useClerk hook. Since I also need to format the phone number.


API for checking server connection

Hmmm on second thought, this does feel very hacky (in particular, the sleep(1) part). Since we have added the win_exists() function, can't we use that? If it returns None, I believe there is no connection; see https://github.com/facebookresearch/visdom/blob/master/py/init.py#L309
What do you think?
Btw... the check_connection() function that is added here still needs to be exposed in Lua, akin to https://github.com/facebookresearch/visdom/blob/master/th/init.lua#L219

I second @lvdmaaten's idea - using win_exists is definitely a cleaner implementation, especially on the python end. We'd be happy to bring that version in. As far as the Lua version goes, if you're having trouble getting torch running I can add the wrapper before I merge the code in.

@JackUrb and @lvdmaaten I completely agree, using win_exists is the way to go; I will update this PR in a moment. @JackUrb that be great since I am having trouble getting torch running.


No hover effect on Create Credentials left sidebar

Type
Docs Bug Report
Feedback
There is no hover effect on the first four sidebar links of the Create Credentials sidebar under the SSI SERVICE Right side bar and the text colors are different from other sidebar links text.

I don't know if it was intentionally done but if not I would like to work on it and help make it look like the others
Screenshots
Paste relevant images or screenshots here
developer.tbd.website URL
DOCS page
Browser
Microsoft Edge
Relevant log output
No response

Please can also work on this.

@philling1 Great catch! Thank you for working on this!

Ok thank you

I have opened a PR for this changes #848. Please help me to review it and see if there is any further changes to my PR.

I don't know how I should remove this file  "site/src/util/code-snippets-map.json" from my PR could you please direct me on how to do that.

I don't know how I should remove this file "site/src/util/code-snippets-map.json" from my PR could you please direct me on how to do that.

Locate the Branch: Make sure you are on the branch associated with your pull request. Use the git checkout <branch_name> command to switch to that branch.

Use git checkout to Restore the File: Run the following command to restore the file to its previous state:
git checkout path/to/file

Replace path/to/file with the actual path to the file you want to restore.

Commit the Restoration: After running the git checkout command, the file will be restored to its previous state. You can then commit this change using git commit:
git commit -m "Restore <file_name> to previous state"

Push the Changes: Finally, push the changes to the branch on your GitHub fork or repository with:
git push origin <branch_name>

ok thank you for the quick response let me try it now.

I have done as you said but the file is still showing when I created the PR for the issue

I have created a PR where I think I have resolved this issue could help to review it and merge it

@philling1 do you have a PR open for this issue?


Tweak the script editor's line/column indicator for readability

Salvaged version of https://github.com/godotengine/godot/pull/41862.

Use a colon instead of parentheses and a comma to reduce visual clutter.
Pad the line number with 4 spaces to account for scripts longer than 999 lines.

This isn't needed for the column number as it's very unlikely to go past 999.

Preview

It still looks kinda cryptic though. It's not always obvious by the brief look what is what in there. Also in the error messages colon prepends the line number so it might be a little misleading / not consistent? Not sure. :thinking:
It seems there's a lot of unused space around (in the containing bar) so maybe something more verbose would be a good idea? For comparison how it looks in VS Code:

It seems there's a lot of unused space around (in the containing bar)

It's not completely unused, errors go there.

Thanks!

Cherry-picked for 3.4.


Suggested .NET Guidelines Updates

The following is a list of suggested updates based on making sure AppConfig complies with the .NET guidelines:

[ ] Does this need to be updated with AsyncCollection?
DO return IEnumerable<Response> or ``IAsyncEnumerable` from service methods that return a collection of items.
[ ] We no longer have ConfigurationModelFactory.SettingBatch(), which is referenced under guideline:
DO provide factory or builder for constructing model graphs returned from virtual service methods.
[ ] Guideline containing <TargetFramework>netstandard2.0</TargetFramework>is overly prescriptive.
[ ] HttpPipelineOptions has been renamed ClientOptions, should be updated in guideline:
DO name subclasses of HttpPipelineOptions by adding Client suffix to the name of the client type the options subclass is configuring.
[ ] Method implementation is out of sync with code in guidelines - as discussed, update guidelines so they don't imply it's exact code, specifically in HttpPipeline section, possibly elsewhere.
[ ] We call something Azure.ETag in the guidelines, but this isn't the precise namespace:
DO use Azure.ETag to represent ETags.
[ ] As discussed, move engineering systems guidelines (with link to them) possibly to the intro, as a reference similar to the general guidelines.
DO follow Azure SDK engineering systems guidelines for working in the azure/azure-sdk-for-net GitHub repository.

I ran across this while looking for something else. Is this still relevant? I believe this is all in our guidelines now.

After a quick at-a-glance validation, it appears that these are all included in gudelines.  Given the age of this issue, I'm going to close this out as stale.   Please feel free to reopen if further action  is needed.


Would it be possible to provide Gitea as a Nextcloud app?

Feature Description
Nextcloud is more and more common as a self hosted alternative to cloud services. Nextcloud has a number of apps that make it easy to enable additional functionalities - for example, there is "Collabora", ie making it possible to use LibreOffice from Nextcloud in the same way as GoogleDocs, etc.
At the moment there is no way to provide git hosting through an app on Nextcloud. Do you think it could be possible somehow to provide Gitea as a Nextcloud app, so that nextcloud users could deploy gitea just by installing the app? That could make it very easy to deploy gitea for many users who already are running their nextcloud instance.
Screenshots
No response

I think as an integrated app, authentication becomes difficult to implement.
But you can use nextcloud as an authentication provider for gitea: https://github.com/go-gitea/gitea/pull/10562


Any way to pass args to debug binary?

Seems delve supports this?

see https://github.com/lloiser/go-debug/issues/7#issuecomment-208521292

The exec command is for debugging a pre-compiled binary, but the debug command clearly accepts additional params which it will pass directly to the program being debugged.
I'm just looking for a way to pass from the plugin to the debug command after the --, i.e.

delve debug myapp -- -foo=bar

I wouldn't worry too much about the perfect config UI.  I'd be happy with just a simple text box that would just pass the string -foo=bar above into the executable launching of the delve debug session after the --

see newest version


LinkedInIntegrationTest fails with 2.21.0

https://issues.apache.org/jira/browse/CAMEL-12345

Depends on the Camel / WF CXF upgrade #2460.

Fixed by the upgrade to Camel 2.21.1 so there's no other work required here.


Editor layout splitting inconsistent

Description
What steps will reproduce the problem?

Sub-splitting of the windows in the editor is not uniform/symetric. One cannot achieve every combination.
Example 1) Split horizontaly the initial single editor window and then split vertically the right side one. It gives one elongated window to the left and two to the right, which split the vertical length of the one on the left hand side.
Example 2) Now we want but we cannot achieve the verticaly mirrored combiantion, 2 window to the left and one to the right. Split the initial single window horizontaly and then the left hand side one verticaly. This results in the main window splited verticaly in three windows. The first horizontal splitting dissapears.
Versions

Spyder version: 3.3.1
Python version: 3.6.6
Qt version: 5.9.3
PyQt5 version: 5.9.2
Operating System: Linux 4.15.0-36-generic

Dependencies
pyflakes >=0.6.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
sphinx >=0.6.6    :  1.6.7 (OK)
rope >=0.9.4      :  0.10.5 (OK)
jedi >=0.9.0      :  0.11.1 (OK)
psutil >=0.3      :  5.4.2 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
numpy >=1.7       :  1.15.1 (OK)
sympy >=0.7.3     :  None (NOK)
cython >=0.21     :  None (NOK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0     :  5.5.0 (OK)
matplotlib >=2.0.0:  2.2.3 (OK)
pylint >=0.25     :  1.8.3 (OK)

Hey, @ccordoba12 I am new to this community, I would like to take up this issue and workout with it.

This limitation is actually mentioned in the code:
https://github.com/spyder-ide/spyder/blob/15f1193c37a876dfaa4fa8e011f003db38cde694/spyder/plugins/editor/widgets/editor.py#L2777-L2780

I'm also quite sure that it is not possible to get a 2 x 2 editor layout right now.

Correct!


VTA cmake change to include Verilator header for building tsim library

Proposed changes to VTA require verilator include directory to build module.cc.
Background:
VTA modification is proposed to support 64/128/256/512 bit AXI data bus. (vta pull request VTA Chisel Wide memory interface. #32) DPI support for those bit widths is implemented using svOpenArrayHandle from Verilator library from svdpi.h . The original implementation of module.cc uses 8/64 bit data type match and doesn't require special handling.
Resolves problem:
module.cc is compiled into tsim library by TVM.
Code contributions to this PR were made by the following individuals (in alphabetical order): @suvadeep89, @stevenmburns, @pasqoc, @adavare, @sjain12intel, @aasorokiin, and @zhenkuny.

VTA-hardware build flow already requires VERILATOR_INC_DIR or it defines Verilator includes from those paths. Can it be accepted to have the same requirements for TVM tsim lib building?

If I understand correctly, this PR fixes the following VTA PR right?

There is a more general problem with defines. That g++ argument define  -D__STDC_FORMAT_MACROS  is redefined in verilator includes and cause compilation error  with -Werror

@aasorokiin You can probably be more selective about which warnings to consider as errors.
Here is an example:
> cat a.cpp
int main() {
   int a;
   return 0;
}

With -Werror set, you get a compilation failure:
> g++ -Wall -Werror a.cpp
a.cpp: In function ‘int main()’:
a.cpp:2:8: error: unused variable ‘a’ [-Werror=unused-variable]
    int a;
        ^
cc1plus: all warnings being treated as errors

But you can turn off that particular error:
> g++ -Wall -Werror -Wno-error=unused-variable a.cpp
a.cpp: In function ‘int main()’:
a.cpp:2:8: warning: unused variable ‘a’ [-Wunused-variable]
    int a;
        ^

This compiles. Maybe you can add the particular Verilator warnings to a -Wno-error option to clean this up.


how to query (findAll) against multiple rows?

all of the examples in the project readme seem to support only a single instance. i am trying to write a test against a set of instances. i don't see a way to fake a set of rows.  i have looked through your src code (i have 0.7.0), and don't see any way to do this.
alternatively, i have been reading your readthedocs, and i see $queueResult --which looks like a setup where i could set up a test with any result i am trying to test against (i'd like to feed it an array of objects).  this looks like what i want, but i see in #1  that this is a consideration for a future feature.  i don't  see any branches in your project... so i am really puzzled by two things -- 1) most importantly, how is anyone today using sequelize-mock to tests against sets of data, and 2) if the $queueResult is not real, why is it in the docs?
thanks!

$queueResult will certainly be the way to do that going forward, however it is not in version 0.7.0. It is the major item planned for v0.8.0, but that is not quite ready yet. I have a few more issues I need to clear up before it can be released to NPM (don't want to break everyone's tests). The reason it is in the docs is that I unfortunately had an issue (now fixed) that the documentation badge in NPM was pointing to latest instead of stable, so it is showing documentation in progress. When the next version is pushed to NPM, this issue should go away.
As for the how to use it against multiple rows, the way we use it (aka the current ugly way we're fixing) is to override function calls in our tests.
var findAll;
beforeEach(function () {
    findAll = UserMock.findAll;
});
afterEach(function () {
    UserMock.findAll = findAll;
});

// ...
UserMock.findAll = function () {
    return bluebird.resolve([
        UserMock.build(), // result 1
        UserMock.build(), // result 2
        UserMock.build(), // result 3
    ]);
};

Because this is using overrides to do it, the good thing is that it will be forward-compatible. The bad thing is it is very clunky.
Obviously this is less than ideal and what we aim to fix with v0.8.0. Hopefully I'll be getting time this week to wrap that up and publish it to NPM, but unfortunately I'm not sure I can promise that.
Hope that helps,
Andrew

thanks for that @ktsashes. because i already have my set of data in a json resource file, in place of your repeated build lines, i started by iterating my array and calling build, then i saw you have a bulkCreate() fake, which does its own iteration. so for benefit others reading this thread, here's a little shorthand that works for me:
var findAll;
beforeEach(function () {
    findAll = UserMock.findAll;
});
afterEach(function () {
    UserMock.findAll = findAll;
});

var smartUsers = JSON.parse(fs.readFileSync('../resources/users.json'));
UserMock.bulkCreate(smartUsers)
.then(function(userInstances) {
    UserMock.findAll = function () {
        return bluebird.resolve(userInstances);
    };
})
.then(function doMyTest() {
    // ... assert
    // ... assert
    done();
});

Just wanted to let you know that v0.8.0 is out with a result queuing mechanism which hopefully should address this issue. You can check out the documentation for the feature if you like under Mock Queries in our documentation.


chore(CPlusPlus): add HeapSort

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is on refer on the language README.md file
[x] My addition does not have a spelling problem
[x] My submission has a proper and user-friendly description of the algorithm
[x] My submission has the time complexity of the algorithm
[x] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[x] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

Hi @mangal-manan,
This is duplicated #226


Remote data while searching

I couldn't find such an option. Is there a way to implement that while the user is typing in the search box?

I'd like to help out with this issue. I needed this feature few days ago and as I did not find it already implemented so I created it in the fork. All I did is added:
    @Output() inputChanged = new EventEmitter<string>();
and
    @Input() disableClientFilter: boolean = false;
in select.component.ts
these changes let's me use new event emitter in my component to query server for new options each time user input any symbol in search box.

Additional to the noOptionsFound output event, I could add a search output event that simply returns the current search term if the filter input changes. This search term can then be used to load remote data and replace the list of options with the returned data. Would that help?

+1 for this please

I added an onFilterInputChanged output to enable retrieving data from remote server. I have also added an example of how to use it in the project app component.
fork
I will create a pull request for this. I would be appreciated if this can be included in the future release.

+1


Mise dumps DEBUG information when activated from $HOME/.config/zsh/.zshrc instead of $HOME/.zshrc

Describe the bug
Mise dumps DEBUG information on every single terminal command when activated from $HOME/.config/zsh directory instead of $HOME/.zshrc
To Reproduce
Place eval "$(mise activate)" inside $HOME/.config/zsh/.zshrc file.
Expected behavior
I would expect no DEBUG statements to appear on every command I input in to the terminal. This issue did not happen under rtx, it only occurred within the migration to mise
mise doctor output
sidmadala in ~ took 1m13s
❯ mise doctor
[DEBUG] ARGS: /opt/homebrew/bin/mise doctor
version: 2024.3.1 macos-arm64 (2024-03-04)
activated: yes
shims_on_path: no

build_info:
  Target: aarch64-apple-darwin
  Features: DEFAULT, NATIVE_TLS
  Built: Mon, 4 Mar 2024 22:28:40 +0000
  Rust Version: rustc 1.76.0 (07dca489a 2024-02-04) (Homebrew)
  Profile: release
[DEBUG] $ /bin/zsh --version

shell:
  /bin/zsh
  zsh 5.9 (x86_64-apple-darwin23.0)

dirs:
  data: ~/.local/share/mise
  config: ~/.config/mise
  cache: ~/.cache/mise
  state: ~/.local/state/mise
  shims: ~/.local/share/mise/shims
[DEBUG] Config {
    Config Files: [
        "~/.config/mise/config.toml",
    ],
}

config_files:
  ~/.config/mise/config.toml

plugins:
  bun     (core)
  deno    (core)
  erlang  (core)
  go      (core)
  java    (core)
  node    (core)
  python  (core)
  ruby    (core)
[DEBUG] Toolset: rust@latest, node@latest, yadm@latest, go@latest, opam@latest, <EMAIL_ADDRESS><EMAIL_ADDRESS>
toolset:
  rust@latest           (missing)
<EMAIL_ADDRESS>         (missing)
  yadm@latest           (missing)
<EMAIL_ADDRESS>           (missing)
  opam@latest           (missing)
<EMAIL_ADDRESS>(missing)
<EMAIL_ADDRESS>(missing)

env_vars:
  MISE_SHELL=zsh

settings:
  activate_aggressive = false
  all_compile = false
  always_keep_download = false
  always_keep_install = false
  asdf_compat = false
  cargo_binstall = true
  color = true
  disable_default_shorthands = false
  disable_tools = []
  experimental = true
  go_default_packages_file = "~/.default-go-packages"
  go_download_mirror = "https://dl.google.com/go"
  go_repo = "https://github.com/golang/go"
  go_set_gopath = false
  go_set_goroot = true
  go_skip_checksum = false
  jobs = 4
  legacy_version_file = true
  legacy_version_file_disable_tools = []
  node_compile = false
  not_found_auto_install = true
  paranoid = false
  plugin_autoupdate_last_check_duration = "7d"
  python_compile = false
  python_default_packages_file = "/Users/sidmadala/.default-python-packages"
  python_pyenv_repo = "https://github.com/pyenv/pyenv.git"
  raw = false
  trusted_config_paths = []
  quiet = false
  verbose = true
  yes = false
  ci = false
  debug = true
  trace = false
  log_level = "debug"
  python_venv_auto_create = false

  [status]
  missing_tools = "if_other_versions_installed"
  show_env = false
  show_tools = false

No problems found
[DEBUG] ARGS: /opt/homebrew/bin/mise hook-env -s zsh
[DEBUG] Config {
    Config Files: [
        "~/.config/mise/config.toml",
    ],
}

My own error, for some reason my config file had the logging level set to debug.


Mouse Input not detected across entire terminal

Version
Microsoft Windows [Version 10.0.19044.1706]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
This is basically a duplicate of #7101, which is completely reproducible for me. So the repro steps remain the same:

Clone and build ImTui  and the example project.
Try to drag one of the windows to the far right of the terminal or hover over the right side of the terminal with the mouse cursor

I personally can reproduce this issue with a basic ncurses application, which seems to be the library imtui uses behind the scenes.
Expected Behavior
The mouse input should be caught across the entire terminal width, even if the terminal window is maximised.
Actual Behavior
At some specific offset the click event is no longer caught correctly.
Curiously enough this issue does not happen inside the console provided by Visual Studio code (when running with WSL integration). Because of  this, my best guess is that this doesn't seem to be an issue of WSL directly, but rather how the default console (and windows terminal too) interact with WSL
Diagnostic Logs
No response

Can you please file this on the Windows Terminal repo? This is best fixed by the Windows Terminal team:
http://github.com/microsoft/terminal

As i said, the issue isn't exclusive to windows terminal. It happens on the default wsl window too. Can the terminal team do something about that too?


add tests for write functions in dual manager

What changed?
Add tests for write functions (record/update/delete) in dual manager

Why?
code coverage week

How did you test it?
unti test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018ea141-ee97-43a5-a12e-a14c885700e7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
55 unchanged lines in 12 files lost coverage.
Overall coverage increased (+0.07%) to 65.902%

Files with Coverage Reduction
New Missed Lines
%

service/history/task/transfer_standby_task_executor.go
2
87.42%

common/task/fifo_task_scheduler.go
2
87.63%

service/matching/db.go
2
73.23%

common/util.go
2
91.78%

common/membership/hashring.go
2
82.23%

common/persistence/historyManager.go
2
66.67%

common/log/tag/tags.go
3
50.18%

service/history/task/fetcher.go
4
85.05%

service/matching/taskReader.go
5
84.08%

common/persistence/nosql/nosql_task_store.go
5
61.95%

Totals

Change from base Build 018ea11d-86da-4c81-b91c-dafc755f3c7a:
0.07%

Covered Lines:
96440

Relevant Lines:
146338

💛  - Coveralls


Fix id_test and argument order in laws

related to #173 #171

It's pretty clear no one is using these at the moment. ;)

i'm using it  but just updated from v1 to v2

I wonder if maybe these should live in a separate project. Here are couple benefits:

No extra deps #168
The version number of fantasy-land package will only track changes in the spec itself.

The version number of fantasy-land package will only track changes in the spec itself.

I find this compelling. It'd be a shame to keep incrementing the spec's version in order to release fixes such as these, but it'd be unreasonable to force such fixes to wait until a new version of the spec is released. Allowing the two projects to be released independently strikes me as a good idea.

I think changes like this should bump patch version for now.

:deciduous_tree:

I still think the laws should be in this repo, but I think they should be dramatically improved (or reworked, refactored, re-written). They're very old, but are worth their gold when they did work. Personally we should go one step further and make them links in the spec, so people are more likely to know about them.

I think laws should look like this:
// `u.map(a => a)` is equivalent to `u` (identity)
const identity = (u) => {
  return {
    left: u[map](x => x),
    right: u,
  }
}

// `u.map(x => f(g(x)))` is equivalent to `u.map(g).map(f)` (composition)
const composition = (u, f, g) => {
  return {
    left: u.map(x => f(g(x))),
    right: u.map(g).map(f),
  }
}

When we're trying to make them smarter, they just end up not complete or hard to use with certain types.
Also this simple laws implementations will be easy to keep up to date because it's basically copy-paste of the snippets from spec.
I can make a PR that simplifies laws like this if this sounds like a good idea.

const identity = (u) => {
  return {
    left: u[map](x => x),
    right: u,
  }
}
{left,right} = identity(Maybe.Just(1))
maybeEquals(left,right)

i don't see a big difference with this
const identity = (eq, u) => eq( u[map](x => x), u)
identity(maybeEquals, Maybe.Just(1))

and imo the last one is better.

This refactoring will be a breaking change strictly speaking though.

yeh :/ that's true.
What if we state in readme that we might have some braking changes in laws, but still do patch releases if there is no change in actual spec.

Automated tools don't read READMEs. I think we need to stick to incrementing the major version for a breaking change

Let's move this discussion to #195

despite the #195 can we merge this PR?


Better error message on incorrect asset label

Objective
When you have no idea what to put after # when loading an asset, error message may help.
Solution
Add all labels to the error message.
Test plan
Modified anti_alias example to put incorrect label, the error is:
2024-01-08T07:41:25.462287Z ERROR bevy_asset::server: The file at 'models/FlightHelmet/FlightHelmet.gltf' does not contain the labeled asset 'Rrrr'; it contains the following 25 assets: 'Material0', 'Material1', 'Material2', 'Material3', 'Material4', 'Material5', 'Mesh0', 'Mesh0/Primitive0', 'Mesh1', 'Mesh1/Primitive0', 'Mesh2', 'Mesh2/Primitive0', 'Mesh3', 'Mesh3/Primitive0', 'Mesh4', 'Mesh4/Primitive0', 'Mesh5', 'Mesh5/Primitive0', 'Node0', 'Node1', 'Node2', 'Node3', 'Node4', 'Node5', 'Scene0'

on a realistic gltf file, that is probably going to be a very long and not that useful list of labels

on a realistic gltf file, that is probably going to be a very long and not that useful list of labels

I believe the list is always useful, at least having it is definitely more useful than not having it.
It can be long though, so it might be a good idea to cap the number of visible entries (e.g. collect at most of 32 of them).

I'd be fine limiting it to 32 with a ... At the end. But I'd also be fine printing the whole thing. I think more debug info is useful for errors vs less, even if it's extremely verbose.


Links seem to not work

For example in https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/whatisk8s.md neither which refers to document works for me.

You should be viewing our docs on the site:
https://kubernetes.github.io/docs/whatisk8s/

Works for me. Thanks for the explanation.

No prob :)
I know in the past we had browse-by-GitHub as more of a thing but that was all enforced by munging scripts that we're getting away from.


spec: supplementaryGroups or supplementaryGids?

#339 introduced supplementary GIDs in the spec.
In the schema they are called "supplementaryGids" but the app parser expects them to be called "supplementaryGroups".

Mea culpa. In this case the code reflects my intention: supplementaryGroups, not supplementaryGids.
@vbatts @philips @krobertson @mpasternacki any objection to standardising on groups?

@jonboulle groups is a string and supplementaryGroups is a int. Sort of inconsistent.

I am OK breaking the spec and saying Groups is always an int. This string or int issue is too annoying and never right so we should only put ints in the spec IMHO.

Right, I think we should just keep it as ints, but the question is what to call it. I have changed my mind on my previous comment and I think we should go with Gids.

@jonboulle GIDs it is. +1

ints are more definite. string names would be arbitrary and still needing to be resolved.
:+1: to GIDs

Action is in #516 friends


execute function does not catch errors

The execute function neatens out the output but makes catching errors a nightmare

Agreed this can happen. Any place where you're facing it in particular right now? It is supposed to print the error (which is redirected to stdout via 2>&1, and the output of stdout in turn is stored in the variable $OUTPUT)

I have been thinking about this, not exactly about the errors but about making it easier to see the progress of the installation.
Maybe the bigger downloads such as Anaconda & cloning of OpenCV can be excluded from execute
When the download speed is slow, it seems like the script is stuck.
What's your view on this @rsnk96?

That'd be a good idea for steps which take a lot of time @rajat2004

@aswinkumar1999 Is there any specific place in the scripts which is not working properly or the execute function is not showing the error?

Yeah , I had the wrong time set in my computer and the apt update command couldn't fetch packages and exited with Release File invalid error which wasn't displayed by the script.

Ohh, hadn't thought of that since the time and date are generally set by the user while installing Ubuntu itself.
I have no idea why 2&>1 isn't catching this error, something to look into
Until then, maybe we can add a line in the Readme saying to make sure that the system time is correct before running the scripts

#41 Merged , Closing this issue


[Gekidou] post list

Summary
Include post list functionality to load more posts as the user scrolls as well as displaying the "more posts above" banner to take the user to the new messages line. The channel screen header is also included in this PR as well as a few other fixes and optimizations
Ticket Link
https://mattermost.atlassian.net/browse/MM-39752
https://mattermost.atlassian.net/browse/MM-39753
Checklist

[x] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[x] Have tested against the 5 core themes to ensure consistency between them.

Release Note
NONE

@anurag6713 please review this one as is blocking @koox00 work and probably will help with yours

@anurag6713 please review this one as is blocking @koox00 work and probably will help with yours

I'm done with half. I'm on it as it is helping me with my task as well. Will complete it ASAP


#118

Removed installation guide from index.rst and copied it into a new file, installation.rst
Added installation.rst to the toctree / contents.rst

Congrats @gabriellasroman !


Dynamic Columns not working on iPhone X

Is your feature request related to a problem? Please describe.
When viewing on a mobile device the Alias column is not shown, thus not providing the name of the alias given to the capcode.
Describe the solution you'd like
Alias to be shown as a column, or as an option
Describe alternatives you've considered
An option to not show it, or shown at the end of the message for example as to not take up a column
Additional context

Correct.
The columns are dynamic based on the width of the device screen.
Try rotating your device 😉

Tried that but still doesn't change. Is there anyway else for it to show them?

Your device resolution is likely below the threshold to trigger the change.
Try "View desktop site" if your browser has it.
This disables the adaptive columns.

I've tried that as well but makes no difference unfortunately. I'm using an iPhone X. If it can't be done that's fine, just a tad annoying

I don't have an iPhone X so can only bae my tests off a test browser the supposedly emulates it and it seems to work.
Are you using some form of zoom above standard?

No, all normal views and on iOS 14. It however works fine on my iPad Pro 11"

Sounds like something screwy in iOS Safari not communicating the viewport size to the CSS renderer. Would be keen to see other iPhone observations - I'm also android.

What happens if you use chrome or another browser?

Alias doesnt show on Iphone 8 with IOS 14
Its below the viewport max-width

I just tried on Firefox. The same, and requesting desktop site made no difference.

So this one is a quirk in the iPhone X and above - the device reports a smaller screen size to browsers (because of the notch) and makes it not show.
Based on my testing fixing this and showing all columns is useless as the message is squashed.
I'm about to open a PR to remove the noSmall checks on the alias column to fix just that one.

So this one is a quirk in the iPhone X and above - the device reports a smaller screen size to browsers (because of the notch) and makes it not show.
Based on my testing fixing this and showing all columns is useless as the message is squashed.
I'm about to open a PR to remove the noSmall checks on the alias column to fix just that one.


[feature/optional-security-group-ssh-ingress-rule]

The ingress port rule for ssh is now optional. If the access_cidr_blocks is empty, the rule won't be created. This option can be used for jump hosts accessible only with SSM.

The current logic already works. We can wait for this upgrade.


update v1.0.0 release notes

This PR text corresponding to #341 and #204 which are still pending.

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   84.52%   84.52%
=======================================
  Files          22       22
  Lines        3600     3600
  Branches      627      627
=======================================
  Hits         3043     3043
+ Misses        490      489    -1
- Partials       67       68    +1

Impacted Files
Coverage Δ

pywt/_wavelet_packets.py
77.57% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4b48a...000f094. Read the comment docs.

Thanks, this reads well. Let's merge this once the other PRs are in.

Merged, thanks @grlee77


Fix center or zoom

How would I make the center or the zoom level of the map unchangeable by the user? I read through #87 about controlled components and such, so I took this demo (https://jsbin.com/yihohugoza/edit?js,console,output) and removed setState under _onChange. As I understand, because this is a controlled component, the map should no longer be able to move or zoom as it's center and zoom level are fixed. I tried a similar thing with props, but I can still move around. Am I misunderstanding how this should work?

I wrote somewhere in issues that its really hard to make this control work as any internal React uncontrollable component. As google api is not declarative etc.
You could prevent zoom change via options prop, there are few ways to do it, for example set minZoom = zoom = maxZoom
I think there should be option to prevent map moving.

Appreciate the reply. Just to clarify, the component above is a controlled component, right? I'm assuming by specifying a zoom and center that's like a normal React component's value, and because there's an onChange handler, it's a controlled component?
The other thing is props. Take this example (https://jsbin.com/xihocihigi/edit?js,console,output) which is from #87 where props are used to determined to zoom and center. You suggested that if onChange was added, this becomes a controlled component, but when I try it, it seems to have no effect.
Basically, it seems zoom and center props aren't really in sync with what you set them to. You can update it but that doesn't always update the map; you don't change them but they update internally.

Below I assume that map always used in controllable manner, so it has zoom center onChange and onChange changes the zoom and center on every call.
In most cases when you change center or zoom properties they should be changed see source https://github.com/istarkov/google-map-react/blob/master/src/google_map.js#L235-L246 but.
But calls to onChange callback is created via idle google api callback, you could see this here http://istarkov.github.io/google-map-clustering-example/ nothing will occur if you will drag map fast, on only then you stop some markers will occur.
This is because that until idle event occurred google api moves layer with React components using his internal api, and this event gives some guarantee that current google map coordinates is the real coordinates. (In other events, map coordinates could be really different than real on the screen, because of internal google api optimizations like raf and animations)
So coordinates you have in onChange callback is synchronized with real coordinates only on the moment of this callback.
About jsbin I wrote where https://github.com/istarkov/google-map-react/issues/87#issuecomment-171331940
There is also example with state https://jsbin.com/malovinare/1/edit?js,console,output
So I can't get about what your question is ;-)

Thanks again for the in-depth response.
I think this explains, in a way, why I can't fix the zoom or center in onChange or when I pass in zoom/center to the Map as a prop - because onChange is only called when idle is called. But shouldn't this mean that if I I take the JSBin example you linked and called setState like this:
this.setState({
  center: [60.938043, 30.337157],
  zoom: 9
});

Shouldn't the map always reset it's zoom and center after I pan and zoom the map and the map comes to idle?

You will get near the same issues as in React if you will set something different on value than onChange has provided.
As an example https://jsbin.com/kajufehezu/edit?js,console,output if you will try to insert character in any place except the end of input, your cursor will always move at the end of the input.
So here
  _onChange = ({center, zoom}) => {
    this.setState({
      center: [61.938043, 31.337157],
      zoom: zoom,
    });
  }

is the same issue - something will go wrong ;-)

I did some more experimenting with similar solutions and came to the same conclusion - things don't always work when you leave the React realm to make changes to DOM, or Maps in this case. Really appreciate your explanations @istarkov, I think I just need to adopt a slightly different mindset with how things work with dealing with Maps. 👌


chore(release): v0.18.0 🎉

:robot: I have created a release beep boop
0.18.0 (2024-05-16)
Features

literal: rename DomainValueObject to DomainLiteral for intuition++ (fb77ff7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/domain-objects/releases/tag/v0.18.0 :sunflower:


[VS Code] Could not connect to the server. Check that you are connected to the internet.

<!--
For Visual Studio problems/feedback, please use the Report

@theja1221 Thanks for raising the issue. However, we'll need a bit more detail to help you out here.

When did you hit this error?
Are you behind a proxy?
Could you run the command "Live Share: Export Logs" and drag-and-drop the zip here or send it to<EMAIL_ADDRESS>
Thanks

I'm getting that error too. I'm behind a proxy, how do I configure the plugin to work behind the proxy?

@hidigitech See https://github.com/MicrosoftDocs/live-share/blob/master/docs/reference/connectivity.md#proxies and let us know if that helps.

Closing issue due to inactivity.


tests: make failpoints tests more stable

CC https://github.com/pingcap/tikv/pull/2545#issuecomment-353917300

Can you explain that why do you add this?

Failpoints tests share a global lock. A failed test may cause panic before unlocking, leaves the lock poisoned, remaining tests will never acquire it successfully.

/run-all-tests

LGTM
PTAL @disksing


Detect Component Unload Event - OnUnloadAsync()?

I think there needs to be some way to detect when a component is unloaded so that any code that's running in the background can appropriately check whether the components exists.
As it is in experimenting with a background timer, I ended up creating a component that never releases due to a circular reference and there's no way to check to see whether resources should be released when the component unloads.

Dispose component
I think this is the new link:
https://docs.microsoft.com/en-us/aspnet/core/blazor/components?view=aspnetcore-3.0#component-disposal-with-idisposable


Msgpackrpc error while using Airsim with the UEP plugin

Hey there!
I'm using UE 4.18 on Windows 10, and I'm trying to implement the AirSim plugin and running it in a Python Component.
I'm getting the following error:
WARNING:tornado.general:Connect error on fd 6248: WSAECONNREFUSED
WARNING:tornado.general:Connect error on fd 6248: WSAECONNREFUSED
WARNING:tornado.general:Connect error on fd 6248: WSAECONNREFUSED
WARNING:tornado.general:Connect error on fd 6248: WSAECONNREFUSED
WARNING:tornado.general:Connect error on fd 6248: WSAECONNREFUSED
Retry connection over the limit
Traceback (most recent call last):
File "E:\Documents\Unreal Projects\PythonTrain\Content\Scripts\comm2.py", line 189, in begin_play
self.client.confirmConnection()
File "E:\Documents\Unreal Projects\PythonTrain\Content\Scripts\AirSimClient.py", line 445, in confirmConnection
home = self.getHomeGeoPoint()
File "E:\Documents\Unreal Projects\PythonTrain\Content\Scripts\AirSimClient.py", line 454, in getHomeGeoPoint
return GeoPoint.from_msgpack(self.client.call('getHomeGeoPoint'))
File "E:\Documents\Unreal Projects\PythonTrain\Plugins\UnrealEnginePython\Binaries\Win64\Lib\site-packages\msgpackrpc\session.py", line 41, in call
return self.send_request(method, args).get()
File "E:\Documents\Unreal Projects\PythonTrain\Plugins\UnrealEnginePython\Binaries\Win64\Lib\site-packages\msgpackrpc\future.py", line 43, in get
raise self._error
msgpackrpc.error.TransportError: Retry connection over the limit
When I run the same functions "outside" the UEP plugin it runs without a problem.

Hi, can you post example code ? btw the error reports "connection refused", could it be some firewall blocking ?
In addition to this is trongly suggest you to rely on python3 asyncio:
https://github.com/20tab/UnrealEnginePython/blob/master/tutorials/AsyncIOAndUnrealEngine.md
https://github.com/chuchiy/aiorpc

I tried turning off the firewall but didn't achieve any better results. I added the asyncio but I am not sure where you wanted me to use it @rdeioris.
Example code:
import unreal_engine as ue
from AirSimClient import *

ue.log('Testing Arisim')

class myServer:
def begin_play(self):
    # get a reference to the owing pawn (a character)
    self.pawn = self.uobject.get_owner()

    client = MultirotorClient()
    client.confirmConnection() #This here

The MultirotorClient and confirmConnection functions are on the next link, lines 445 and 454:
https://github.com/Microsoft/AirSim/blob/master/PythonClient/AirSimClient.py

Hi, mi doubt is that msgpack-rpc-python uses tornado, so without a tornado loop you will not be able to work with sockets/fd.
http://www.tornadoweb.org/en/stable/ioloop.html
In python3 the tornado ioloop maps to asyncio, so probably it will be enough to initialize it like described here:
https://github.com/20tab/UnrealEnginePython/blob/master/tutorials/AsyncIOAndUnrealEngine.md#adding-an-asyncio-loop-engine-in-the-ue4-core

Hey. Sorry for taking so much to answer/close the issue. I kinda solved the problem!
If I launch AirSim in the tick function, I don't get the error.
Code:
import unreal_engine as ue
from AirSimClient import *

ue.log('Testing Airsim')

class myServer:
    def begin_play(self):
        self.pawn = self.uobject.get_owner()
    def tick(self,delta_time):
        client = MultirotorClient()
        client.confirmConnection() #This here

I guess the world was not fully initialized or something?
Thank you for the attention :) and sorry for wasting your time!


Stop QuiLT display jumping around when selecting genes

When I select genes in QuiLT the display changes to move the graphic down the page to look like:

This is fixed now.  It was only happening on the Priority unstudied genes page.


Issue with parsing the coordinates in array format

The main assumption of the data is to be like:
var data = [
  { name: 'Location A', category: 'Store', street: 'Market', lat: 39.984, lng: -75.343 },
  { name: 'Location B', category: 'House', street: 'Broad', lat: 39.284, lng: -75.833 },
  { name: 'Location C', category: 'Office', street: 'South', lat: 39.123, lng: -74.534 }
];

when the coordinates are within an array as below, the generated GeoJSON is not valid:
var data = [
  { name: 'Location A', category: 'Store', street: 'Market', coordinates: [39.984, -75.343] },
  { name: 'Location B', category: 'House', street: 'Broad', coordinates: [39.284, -75.833] },
  { name: 'Location C', category: 'Office', street: 'South', coordinates: [39.123, -74.534] }
];

I tried to parse the above-mentioned dataset as below and it didn't work either:
GeoJSON.parse(data, {Point: ['coordinates']});

Same :(

Same; I ran into this trying to parse LineStrings, which have coordinate arrays.

Right, because geojson format by GeoJSON standard
follow here

@gharibi Assigned. Thanks!

Fixed in #39


[Bug] ModuleNotFoundError: No module named 'rapidfuzz'

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

Type
I'm evaluating with the officially supported tasks/models/datasets.
Environment
when run under Quick Start
python run.py configs/eval_demo.py -w outputs/demo --debug
Reproduces the problem - code/configuration sample
when run under Quick Start
python run.py configs/eval_demo.py -w outputs/demo --debug
Reproduces the problem - command or script
when run under Quick Start
python run.py configs/eval_demo.py -w outputs/demo --debug
Reproduces the problem - error message
when run under Quick Start
python run.py configs/eval_demo.py -w outputs/demo --debug
Other information
No response

Hi, you can run pip install rapidfuzz to install the missing dependency.


Use ingress hostname in Tenant Control Plane

Issue
When using tcp.spec.controlPlane.ingress.hostname, in Tenant control Plane manifest, the hostname is used in the internal communication inside Kamaji cluster instead of the tcp.status.controlPlaneEndpoint.
apiVersion: kamaji.clastix.io/v1alpha1
kind: TenantControlPlane
metadata:
  annotations:
    kamaji.clastix.io/ingress.domain: clastix.cloud
  name: tenant-00-eu-south-1
  namespace: default
spec:
  controlPlane:
    deployment:
      replicas: 2
    ingress:
     ## note the port of the ingress is different from port in the  network profile
      hostname: default-tenant-00-eu-south-1.k8s.clastix.cloud:443
    service:
      serviceType: ClusterIP
  networkProfile:
    port: 6443

the Kamaji controller logs:
2024-10-18T14:25:08Z    ERROR   soot_default_tenant-00-eu-south-1       Reconciler error        {"controller": "clusterrolebinding", "controllerGroup": "rbac.authorization.k8s.io", "controllerKind": "ClusterRoleBinding", "ClusterRoleBinding": {"name":"kubeadm:kubelet-bootstrap"}, "namespace": "", "name": "kubeadm:kubelet-bootstrap", "reconcileID": "9fc6ce0b-dbaa-496c-afd5-aebae80c53bb", "error": "unable to create ClusterRoleBinding: Post \"https://default-tenant-00-eu-south-1.k8s.clastix.cloud:6443/apis/rbac.authorization.k8s.io/v1/clusterrolebindings?timeout=10s\": context deadline exceeded",
...

Also the
Expected
The tcp.spec.controlPlane.ingress.hostname is intended for accessing the Tenant control Plane from outside the Kamaji cluster, for example by user's kubectl, node kube-proxy, and node kubeadm join.
When using tcp.spec.controlPlane.ingress.hostname, in Tenant control Plane manifest, it is necessary to have ingress  and ingress  properly set in:

on the Kamaji cluster, <tenant_name>-admin-kubeconfig secret
on the tenant cluster,

kube-system/kube-proxy config map
kube-public/cluster-info config map

If tcp.spec.controlPlane.ingress is set but hostname is not defined, then ingress's host will be: <tenant>.<namespace>.<domain>, where domain is specified under NetworkProfile.

Make sure the config maps and secrets are reconcilied upon changes in the TCP manifest.

@prometherion is there any other place where tcp.spec.controlPlane.ingress.hostname should be used when accessing the Tenant Control Plane throught an ingress?