Micronaut Plugin fails to detect Lombok Plugin

Related to: #40
MicronautApplicationPlugin does not support Lombok when it's added through the Lombok Gradle Plugin (which is recommended by the official website):
Steps to Reproduce
plugins {
    ...
    id("io.freefair.lombok") version "6.0.0-m2"
}

For example, when a bean constructor is replaced with @RequiredArgsConstructor then Micronaut fails to instantiate it.
Stacktrace
BeanInstantiationException: Error instantiating bean of type [X]: X: method 'void <init>()' not found

Possible Workaround
Replace Lombok Gradle Plugin with plain old dependencies:
dependencies {
    ...
    annotationProcessor("org.projectlombok:lombok")
    compileOnly("org.projectlombok:lombok")
}

However, it would be nice if the Lombok Gradle Plugin could be used in conjunction with Micronaut.
Environment Information

Operating System: Windows 10
Micronaut Version: 2.5.8
JDK Version: openjdk version "11.0.11" 2021-04-20

Example Application

https://github.com/guillermocalvo/micronaut-gradle-plugin-issue

Have you tested your "possible" workaround?
I have had success using the pattern you're describing with @RequiredArgsConstructor in spring, and was hoping to get it to work with micronaut too. Looking at my compiled classes, it looks like it should work.
Micronaut: 3.6.3
Lombok: 1.18.24
java: 17


[Input + Modal, mobile] Unexpected behavior when typing characters in some languages

About the bug
When I type Japanese characters at the Input component is in the Modal component, the keyboard behavior is unexpected. It does not work the feature to convert Hiragana into Kanji characters.
You can see what happens here. It seems like the enter key is pressed after you type one word.
https://user-images.githubusercontent.com/6883692/126018766-2d8da995-f863-46a1-8e45-713627644eb2.mov
My expected behavior is like the first part of the video.
Snack link
https://snack.expo.io/qyy3f4YYr
Platform

NativeBase version: 3.0.6
Device: iPhone8
OS: iOS14.6
Expo sdk version: 42.0.1

Additional information

I observe it in Chinese too. Not only Japanese.

Hi @tell-y, we are working on the fix. For now, the workaround for this problem can be moving the input component outside your main component.
import React from "react";
import { Input, Center, NativeBaseProvider, Modal, Button } from "native-base";
export const Example = () => {
  const [open, setOpen] = React.useState(false);
  const [text, setText] = React.useState("");
  return (
    <>
      <Input
        p={2}
        placeholder="Native Base"
        value={text}
        onChangeText={(value) => setText(value)}
      />
      <Button onPress={() => setOpen(true)}>open modal</Button>
      <Modal isOpen={open} onClose={() => setOpen(false)}>
        <Modal.Content maxWidth="400px">
          <Modal.Body>
            <InputComponent></InputComponent>
          </Modal.Body>
        </Modal.Content>
      </Modal>
    </>
  );
};

const  InputComponent = () => {
  const [text2, setText2] = React.useState("");
  return (
    <Input
      p={2}
      placeholder="Native Base"
      value={text2}
      onChangeText={(value) => setText2(value)}
    />
  );
};

export default () => {
  return (
    <NativeBaseProvider>
      <Center flex={1}>
        <Example />
      </Center>
    </NativeBaseProvider>
  );
};


'Dev Home needs to update' fails

Dev Home version
Don't know
Windows build number
10.0.26097
Other software
No response
Steps to reproduce the bug

Open Dev Home

Expected result
Dev Home opens as expected.
Actual result

A Window pops up saying Dev Home needs to update:

This fails

Retry and the Window looks slightly different

But it fails again.

Included System Information
No response
Included Extensions Information
No response

This is probably Store being flaky, but if you can reproduce this for Feedback Hub it might be helpful.
/feedbackhub

When trying to repro with feedback hub it seemed to finish the download and now I can't repro it.

That makes me suspect even more that it was a transient Store issue. Closing but happy to reopen if you or someone else sees an indication to the contrary.


cannot start app

I'm getting an error when using "npm run start", was the build script moved to another directory?
npm ERR! missing script: start

Nvm, I just realized it should have been "npm run serve"


Throttle persisting items

Adds a 100ms throttle to persisting to storage.
Should improve cpu-usage/latency if you get a flurry of add-query-ok messages.

Will this make things feel more laggy?

Will this make things feel more laggy?

No, this won't affect the render flow.
The data is persisted to storage in the background, and this just makes us do it less often. The only potential downside is that it extends the window where data might not be persisted to storage by 100ms. But now that I think of it, I could add a beforeunload hook to flush any pending writes to storage.


Multiple et connections

Before I start attaching any logs as if there were a bug, let me first ask if this ticket should be a feature request:
Should it currently be possible to connect from a client to a server multiple times with et?
I connect from my laptop to a desktop/VM located in my work office to do most of my work (hence things like mosh/et being so useful as I roam with my laptop) and in doing so I open a lot of shells to the remote machine. But currently if I open a second et connection my first connection exits.

That's by design.  There's no et daemon that starts when your machine boots, so it spawns an et server when you connect.  You can't have multiple servers listening on the same port, so it kicks out other servers.
If you want multiple terminals, you should be using "tmux -CC" which lets you have multiple tabs and windows using the same connection.  Unfortuntely, only iTerm (mac only) and a fork of Terminator supports tmux -CC at the moment.
It may not be hard to allow multiple et connections.  I'll look into it and report back.  The issue is what to do when a client dies.  If the client reconnects and a new connection starts, then we need some way to clean up the old connections.  Mosh does this by warning you when there's a stale connection and letting the user kill it.

Thanks for the quick response @MisterTea!
I unfortunately don't use a terminal emulator that supports tmux -CC; further to that I use a tiled window manager that does all my tabbing, window organizing and tiling already and would like to avoid introducing yet another layer on top of that with tmux -CC if I can avoid it.
So as of now the et one connection limit is kind of a deal breaker for me :(
Consider this an eager feature request for native support for multiple sessions with et :)
Even if it's as simple as mosh's support for this, which isn't great as you mentioned, but a big step forward at least.
Cheers,
Niko

Sure. I also don't like this limitation so I'll look into it and see if I
can find a simple way to make it happen
On Tue, Mar 28, 2017 at 11:18 AM NikolasOliveira<EMAIL_ADDRESS>wrote:

Thanks for the quick response @MisterTea https://github.com/MisterTea!
I unfortunately don't use a terminal emulator that supports tmux -CC;
further to that I use a tiled window manager that does all my tabbing,
window organizing and tiling already and would like to avoid introducing
yet another layer on top of that with tmux -CC if I can avoid it.
So as of now the et one connection limit is kind of a deal breaker for me
:(
Consider this an eager feature request for native support for multiple
sessions with et :)
Even if it's as simple as mosh's support for this, which isn't great as
you mentioned, but a big step forward at least.
Cheers,
Niko
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MisterTea/EternalTCP/issues/21#issuecomment-289859000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASuv99XPzcxz0yG4rjAlfDkvu6OWpTdks5rqU8FgaJpZM4Mq715
.

Dupe of #20


bump upstream to 1.5.5

Seems fine, is this tested?

Seems fine, is this tested?

I tested, and its on Alpha. no secondary testing done, but just a version bump so should be fine


Min and max aspect ratio.

Hello!
Thank you for your great plugin!
I'm using cropper.js for cover and avatar image cropping.
Users can upload cover image with fixed width(928px) and non-fixed height. But height of cropped image must be from 100px to 800px. So my question is: how can I assign to cropper min aspectratio as 928/100 and max aspectratio as 928/800.
Thank you in advance.

I'm sorry, we don't support this right now.

+1, I would really love this to be possible as well (for http://www.twitshot.com)

@romaincointepas Hi!
May be it will be heplful for you.
I solved it (for now) by adding this to cropper.js options:
done: function (data) {
    var ratio = data.width/928,
          height = data.height/ratio,
          min_height = ratio * 100,
          max_height = ratio * 800;

    if( h < 100 ) $('#my_img').cropper('setData', {height: min_height});
    if( h > 800 ) $('#my_img').cropper('setData', {height: max_height});
}

Here we simply don't allow the cropping area to be out of ratio sizes by setting it to needed value. So aspect ratio will be minimum of 928/100 and maximum of 928/800.

+1

+1

I want to upload and crop images in two different size 6040 and 130100
Please suggest anyone how to do this ..using this plugin
Thanks for any suggestion....

if i want to fix size of crop box selector area on image before cropping any idea if....suggest
Thanks

Here is a solution with cropmove event:

$(function () {
  var $image = $('#image');
  var minAspectRatio = 1;
  var maxAspectRatio = 2;

  $image.cropper({
    cropmove: function (e) {
      var cropBoxData = $image.cropper('getCropBoxData');
      var cropBoxWidth = cropBoxData.width;
      var aspectRatio = cropBoxWidth / cropBoxData.height;
      var lessThan = aspectRatio < minAspectRatio;

      if (lessThan || aspectRatio > maxAspectRatio) {

        // Stop the current move
        e.preventDefault();

        // Trim the crop box size
        $image.cropper('setCropBoxData', {
          height: cropBoxWidth / (lessThan ? minAspectRatio : maxAspectRatio)
        });
      }
    }
  });
});


chore: fix table with and without connected data have different heights

Fixes #33758
/ok-to-test<EMAIL_ADDRESS>
[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9267730971
Commit: 5305b21086cc8965be0f9159d11ebeadf2503878
Cypress dashboard url: Click here!

/build-deploy-preview skip-tests=true

@jsartisan Why do we need all these changes if we plan to add the default data into the table? All this code for an empty table should go away, right?

@KelvinOm Right but this changes also makes sense for deploy mode so that empty table is of same height. It's not just for edit mode.

@jsartisan Why do we need all these changes if we plan to add the default data into the table? All this code for an empty table should go away, right?

@KelvinOm Right but this changes also makes sense for deploy mode so that empty table is of same height. It's not just for edit mode.

So if we have default data, they will also displayed in deploy mode, we should not have a case with an empty table. Or am I missing something?

@jsartisan Why do we need all these changes if we plan to add the default data into the table? All this code for an empty table should go away, right?

@KelvinOm Right but this changes also makes sense for deploy mode so that empty table is of same height. It's not just for edit mode.

So if we have default data, they will also displayed in deploy mode, we should not have a case with an empty table. Or am I missing something?

Consider a table that is binded with a data source and and data is empty from it.


chore(scan): New Scan class

Context
We are working to decouple Prowler so we need to create some missing classes.
Description

Create a new Scan class in charge of scanning the given provider.
I've moved the following code outside the execute() function to simplify it:

# Update Audit Status
services_executed.add(service)
checks_executed.add(check_name)
global_provider.audit_metadata = update_audit_metadata(
    global_provider.audit_metadata, services_executed, checks_executed
)

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closed reason: This is a PoC


Close the gap between Terminal and Conhost ITerminalApi

There's a number of TODOs in Terminal's implementation of ITerminalApi, herein captured:
58-void Terminal::SetAutoWrapMode(const bool /*wrapAtEOL*/)
59-{
60:    // TODO: This will be needed to support DECAWM.

63-void Terminal::SetScrollingRegion(const til::inclusive_rect& /*scrollMargins*/)
64-{
65:    // TODO: This will be needed to fully support DECSTBM.

73-bool Terminal::GetLineFeedMode() const
74-{
75:    // TODO: This will be needed to support LNM.

109-bool Terminal::ResizeWindow(const til::CoordType /*width*/, const til::CoordType /*height*/)
110-{
111:    // TODO: This will be needed to support various resizing sequences. See also GH#1860.

115-void Terminal::SetConsoleOutputCP(const unsigned int /*codepage*/)
116-{
117:    // TODO: This will be needed to support 8-bit charsets and DOCS sequences.

120-unsigned int Terminal::GetConsoleOutputCP() const
121-{
122:    // TODO: See SetConsoleOutputCP above.

These were introduced in the merger of TerminalDispatch and AdaptDispatch, which unified conhost's and Terminal's output state machine engine dispatchers in and around #13024.
@j4james are there any that I've missed? I was pretty hamfisted with it. :smile:
Notes from @j4james:

That looks right from the point of view of ITerminalApi. But I think the main things outstanding are that the _WriteBuffer and _AdjustCursorPosition methods in Terminal need to be unified with the WriteCharsLegacy and AdjustCursorPosition functions from conhost, since the Terminal versions are missing a bunch of functionality.
And once those methods are merged into AdaptDispatch, we might also be able to get rid of some ITerminalApi methods like SetScrollingRegion, GetLineFeedMode, and LineFeed.

There are also things that Terminal supports which conhost does not. I am not sure whether it is right to track them here.

I didn't think anyone really cared about the conhost side, but these are the ones I'm aware of:

EnableXtermBracketedPasteMode
CopyToClipboard
SetTaskbarProgress
SetWorkingDirectory
AddMark

Although in the case of SetWorkingDirectory, I'm not sure there's anything useful conhost can do with that information. And AddMark should really be moved out of ITerminalApi and implemented directly on the TextBuffer somehow. As currently implemented, it's kind of blocking the AdjustCursorPosition unification.

Also, Build-SupportedSequenceIndex still expects to find terminalDispatch. Right now, we don't have a way to tell it that Terminal doesn't support a particular control sequence

Yeah, I was thinking we should maybe come up with a new way of tracking that info - maybe with a well-defined pattern in the AdaptDispatch doc comments. That way we would have more room to add annotations like "ConHost-only" or "Terminal-only" for operations that aren't yet supported in both.

There are also things that Terminal supports which conhost does not. I am not sure whether it is right to track them here.

Also, Build-SupportedSequenceIndex still expects to find terminalDispatch. Right now, we don't have a way to tell it that Terminal doesn't support a particular control sequence (somewhat by design, since the dispatcher is of course identical).

@j4james are there any that I've missed? I was pretty hamfisted with it. 😄

That looks right from the point of view of ITerminalApi. But I think the main things outstanding are that the _WriteBuffer and _AdjustCursorPosition methods in Terminal need to be unified with the WriteCharsLegacy and AdjustCursorPosition functions from conhost, since the Terminal versions are missing a bunch of functionality.
And once those methods are merged into AdaptDispatch, we might also be able to get rid of some ITerminalApi methods like SetScrollingRegion, GetLineFeedMode, and LineFeed.

There are also things that Terminal supports which conhost does not. I am not sure whether it is right to track them here.

I didn't think anyone really cared about the conhost side, but these are the ones I'm aware of:

EnableXtermBracketedPasteMode
CopyToClipboard
SetTaskbarProgress
SetWorkingDirectory
AddMark

Although in the case of SetWorkingDirectory, I'm not sure there's anything useful conhost can do with that information. And AddMark should really be moved out of ITerminalApi and implemented directly on the TextBuffer somehow. As currently implemented, it's kind of blocking the AdjustCursorPosition unification.

Also, Build-SupportedSequenceIndex still expects to find terminalDispatch. Right now, we don't have a way to tell it that Terminal doesn't support a particular control sequence

Yeah, I was thinking we should maybe come up with a new way of tracking that info - maybe with a well-defined pattern in the AdaptDispatch doc comments. That way we would have more room to add annotations like "ConHost-only" or "Terminal-only" for operations that aren't yet supported in both.

I've been experimenting with the WriteCharsLegacy/_WriteBuffer part of this, and I think I have a solution that could be turned into a PR if you're interested.
What it amounts to is a loop over the string that is being output, writing a line at a time with TextBuffer::WriteLine, and calling a slightly modified version of ITerminalApi::LineFeed to handle the line wrapping (the modification is because a LineFeed call usually clears the WrapForced flag, while in this case it needs to be set).
This way we don't need to touch WriteCharsLegacy, and AdjustCursorPosition is only used indirectly via the LineFeed API (hopefully that dependency will be removed in a later PR).
But with this functionality merged into AdaptDispatch, I'm assuming there's no longer a need for WriteCharsLegacy2ElectricBoogaloo (#780), which I see is now assigned to @lhecker . So I before I submit anything, I just want to make sure I'm not doing something that's going to mess with your existing plans.
I should also stress out that I haven't tried to address any performance issues, or fix bugs like the cursor droppings (#12739). I'm just trying to get the existing functionality moved into AdaptDispatch so I can progress with VT features that depends on that.

Btw, I've also got a trivial implementation of IRM (#1947) built on top of this. When that mode is enabled, it first measures how many cells the string is expected to take (using the OutputCellIterator), and then scrolls the target area right by that amount before calling TextBuffer::WriteLine.
I know it's not ideal, and I'm assuming the ultimate plan is to handle the inserting in the TextBuffer class itself, but it's only a couple of lines, and it should be easy to replace with something like a flag on the WriteLine method once that functionality is available. In the meantime, though, we'll at least have something working.

Leonard's gonna be out for a little while now, but IIRC, there's nothing too concrete in the works quite yet. Pretty sure we just bulk-assigned all the buffer writing stuff to him 😝 Getting rid of the need for that would probably just make his life easier. I'd say go for it.

I know it's not ideal,

I honestly could care less if it's ideal. I don't think IRM is gonna be used in any truly hot paths for raw throughput, so I'd rather have a less-than-ideal solution than nothing at all.

So I before I submit anything, I just want to make sure I'm not doing something that's going to mess with your existing plans.

@j4james Don't worry about me. Your work is absolutely fantastic. :)
I've been sick since the start of the year and my recovery has been slower than I had hoped, so it'll take a little bit for me to catch up anyways. Additionally I'm planning to prioritize fixing the remaining AtlasEngine issues a bit, so that we can finally release it enabled by default and delete DxEngine sooner rather than later (to reduce the maintenance burden). Also, related to the WriteCharsLegacy rewrite, I've got a very long list of other areas that I was planning to address along with it here: https://github.com/microsoft/terminal/issues/8000#issuecomment-1325410702. If you intend to continue working on WriteCharsLegacy or related code, I don't mind working on these other bits first.

I believe this issue #1765 (ConPTY sends two WINDOW_BUFFER_SIZE_EVENT messages when the window is restored from maximize)  belongs here too.


tag creation change to post

Short Description
Hotfix which changes tags creation from PUT to POST
Related to issue #90

Already done in #117


Add shouldDelayFocus for RoomNameInput

Details

https://github.com/Expensify/App/issues/15111#issuecomment-1430387427
Fixed Issues

$ https://github.com/Expensify/App/issues/15111
PROPOSAL: https://github.com/Expensify/App/issues/15111#issuecomment-1430387427
Tests

Open the App
Login with applause account
Click on FAB button -> New Room
Verify that Keyboard automatically opens for new room

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Open the App
Login with applause account
Click on FAB button -> New Room
Verify that Keyboard automatically opens for new room

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/71884990/219284171-ddbecb33-0e32-47bf-ab6e-1761837aa3c4.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/71884990/219284187-ad9a22e2-ef88-481f-b79b-b38e36206510.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/71884990/219284200-a9a785c6-86dd-4bf4-bc4b-46578e0f9145.mov

Desktop

https://user-images.githubusercontent.com/71884990/219284856-87a7e61b-b1f0-4b57-9445-abc46f527e31.mov

iOS
https://user-images.githubusercontent.com/71884990/219284221-67c16532-5576-4e86-b3fa-bac702a4474a.mov

Android
https://user-images.githubusercontent.com/71884990/219284877-2d50913b-8fe6-41b2-84aa-59648cb6cc88.mov

@francoisl @sobitneupane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

I believe the Jest test failure was fixed yesterday, do you mind pulling main into the branch and pushing again @daraksha-dk? Just so we can have all the tests passing. Thanks!

🚀 Deployed to staging by https://github.com/francoisl in version: 1.2.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Create new curation showing all unknown bitstreams and different types

As an admin, I would like to see all uknown bitstream types including the bitstream name.
If I update update known file types in our repository, I would like to have all bitstreams updated in one go (iff their type was unknown)

Functionality added to the Bitstream Items Control Panel tab.


Added link to Authoring SDK

@jaydeepn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @jaydeepn, are you sure that dotnet/api/overview/azure/ai.language.questionanswering-readme-pre?view=azure-dotnet is a valid relative link?

sign-off

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jboback

@jaydeepn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Update crash from 1.4 -> 1.5

VSCode Version: 1.4 -> 1.5
OS Version: macOS Sierra

Steps to Reproduce:

Be on mac.
Launch VSC and start coding.
Get info message: "Visual Studio Code will be updated after it restart.".
Click update now.
Either nothing happens and it just closes, or it crashes.

If you have the "Keep in dock" option enabled for VSC, it will disappear shortly, and then return as a question mark. You then have to remove it and launch it from the folder. Nothing has been updated.

Can't reproduce.
Can you look for errors in the macOS Console.app? Does it reproduce after downloading it manually?

happens for me from 1.4 to 1.5 and again to 1.6. I have to delete the app and download. I am an admin on this machine.

@steveoh Are there any errors in Console.app?

Can you provide some quick instructions on how to check?

Open Console.app (/Applications/Utilities/Console.app) and check for Code messages in there.

Thanks. I've never had to use this app before. There is nothing when I
search in devices for my machine name. There is one hit in The diagnostics
and usage data but that looks unhelpful.  A couple Code Helper.crash in the user
reports.
This looks helpful from the system.log
Oct 11 14:55:07 skinnybox ShipIt[32042]: Installation error: Error
Domain=SQRLShipItRequestErrorDomain Code=2 "Could not read update request"
UserInfo={NSLocalizedDescription=Could not read update request,
NSUnderlyingError=0x7fb3a6600e00 {Error Domain=NSCocoaErrorDomain Code=260
"The file “ShipItState.plist” couldn’t be opened because there is no such
file." UserInfo={NSFilePath=/var/root/Library/Application
Support/com.microsoft.VSCode.ShipIt/ShipItState.plist,
NSUnderlyingError=0x7fb3a6600c50 {Error Domain=NSPOSIXErrorDomain Code=2
"No such file or directory"}}}}
Oct 11 14:55:07 skinnybox com.apple.xpc.launchd[1]
(com.microsoft.VSCode.ShipIt[32042]): Service exited with abnormal code: 1
Oct 11 14:55:07 skinnybox com.apple.xpc.launchd[1]
(com.microsoft.VSCode.ShipIt): Service only ran for 0 seconds. Pushing
respawn out by 2 seconds.

Definitely #7426


Add/kitchen sink example task tracker with drag and drop

Please describe the changes this PR makes and why it should be merged:
Task-Tracker with drag and drop example added for kitchen sink. Which refers to issue #602.
Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[x] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[x]  This PR adds or edits example in kitchen sink with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Het Desai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Vagrant driver - lock file lookup error

Issue Type

Bug report

Molecule and Ansible details
ansible 2.9.10
  config file = None
  configured module search path = ['/Users/amuhammad/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.8/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.8.6 (default, Oct  8 2020, 14:06:32) [Clang 12.0.0 (clang-1<IP_ADDRESS>)]

molecule 3.1.2

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used:
Desired Behavior
Execution of molecule test to run based on the default scenario for molecule in the ansible role.
Actual Behaviour
The default scenario sequence is as the following in molecule.yml:
---
dependency:
  name: galaxy
driver:
  name: vagrant
  provider:
    name: virtualbox
  options:
    memory: 1024
    cpus: 1
lint: |
    yamllint .
    ansible-lint
    flake8
platforms:
  - name: ${BOX:-ubuntu1804}
    box: "darkwizard242/ansible${BOX:-ubuntu1804}"
provisioner:
  name: ansible
  log: true
scenario:
  name: default
  test_sequence:
    - lint
    - destroy
    - syntax
    - create
    - converge
    - idempotence
    - verify
    - destroy
verifier:
  name: testinfra
  options:
    verbose: true

Right after lint sequence, molecule test tries a destroy in that an instance already exists. However, it has been failing due to the following error:
    PLAYBOOK: destroy.yml **********************************************************
    1 plays in /usr/local/lib/python3.8/site-packages/molecule_vagrant/playbooks/destroy.yml

    PLAY [Destroy] *****************************************************************
    META: ran handlers

    TASK [Destroy molecule instance(s)] ********************************************
    task path: /usr/local/lib/python3.8/site-packages/molecule_vagrant/playbooks/destroy.yml:8
    <<IP_ADDRESS>> ESTABLISH LOCAL CONNECTION FOR USER: amuhammad
    <<IP_ADDRESS>> EXEC /bin/sh -c 'echo ~amuhammad && sleep 0'
    <<IP_ADDRESS>> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /Users/amuhammad/.ansible/tmp `"&& mkdir /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441 && echo ansible-tmp-1602928552.746901-45666-137287224933441="` echo /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441 `" ) && sleep 0'
    Using module file /usr/local/lib/python3.8/site-packages/molecule_vagrant/modules/vagrant.py
    <<IP_ADDRESS>> PUT /Users/amuhammad/.ansible/tmp/ansible-local-45662thzh_ne7/tmp939vjszx TO /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441/AnsiballZ_vagrant.py
    <<IP_ADDRESS>> EXEC /bin/sh -c 'chmod u+x /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441/ /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441/AnsiballZ_vagrant.py && sleep 0'
    <<IP_ADDRESS>> EXEC /bin/sh -c<EMAIL_ADDRESS>/Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441/AnsiballZ_vagrant.py && sleep 0'
    <<IP_ADDRESS>> EXEC /bin/sh -c 'rm -f -r /Users/amuhammad/.ansible/tmp/ansible-tmp-1602928552.746901-45666-137287224933441/ > /dev/null 2>&1 && sleep 0'
    failed: [localhost] (item=ubuntu1804) => {
        "ansible_loop_var": "item",
        "changed": false,
        "item": {
            "box": "darkwizard242/ansibleubuntu1804",
            "name": "ubuntu1804"
        },
        "module_stderr": "",
        "module_stdout": "Retrying to acquire lock on /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default, waiting for 30 seconds\nRetrying to acquire lock on /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default, waiting for 60 seconds\nRetrying to acquire lock on /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default, waiting for 90 seconds\nRetrying to acquire lock on /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default, waiting for 120 seconds\nTimedout trying to acquire lock on /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default\n",
        "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
        "rc": 3
    }

    PLAY RECAP *********************************************************************
    localhost                  : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

ERROR:

I am not sure why it is failing to acquire a lock file and I was able to confirm that a .lock file exists in /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default :
$ find /Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default -type f -name *lock*
/Users/amuhammad/.cache/molecule/ansible-role-node_exporter/default/.lock

I was able to get it to start VMs in VirtualBox 6.1.12 using Vagrant 2.2.10 but downgraded molecule to 3.0.8 per diff provided in https://github.com/Graylog2/graylog-ansible-role/pull/161
Odd behavioral note, this combo works but creates two VMs, one running the other not running in a kind of orphaned state.

@GitBytes Yeah, I've been trying to get my Molecule setup to work, too. I was able to get my Travis CI job working after downgrading to 3.0.8.
It seems there was a locking mechanism added to safeguard parallel molecule runs. It would be nice if there was a flag to disable this behavior, though. No idea why it errored out on me.

Oh, that is a good point, I do have two scenarios. I wonder if that might be the kicker here. Odd though that the expected default behavior with multiple scenarios using the vagrant driver would be to fail out with a locking error like that though rather than just executing each one sequentially. I am thinking it just means you have to specify the scenario explicitly? I'll see how that pans out.

Yeah, I don't get how the lock error occurs when only a single molecule command is being run. For me, it occured when trying to run molecule create.

@juju2112 Same here. Same stage.

Just wanted to +1 that I'm seeing the same behavior. I have a default scenario which has not been run and a second scenario that uses the vagrant driver and converging that scenario in 3.1 causes it to fail with a timeout while attempting to establish a lock.
Downgrading to 3.0.8 restores the original functionality.

same issue here as well. I can also confirm that downgrading to 3.0.8 works.

As noted in https://github.com/ansible-community/molecule-vagrant/issues/82#issuecomment-727861381, this was fixed with molecule-vagrant 0.4 but it was not released on pypi, so you'll have to use either use molecule-vagrant 0.5 and molecule 3.2 alpha or use the git tag to get it.

Molecule 3.2 and molecule-vagrant 0.6 are out. So, everything should be in order.
Is this issue still valid ?

I upgraded to those versions a couple days ago and have not seen the issue
recur.
On Wed, Dec 2, 2020, 4:32 AM Arnaud Patard<EMAIL_ADDRESS>wrote:

Molecule 3.2 and molecule-vagrant 0.6 are out. So, everything should be in
order.
Is this issue still valid ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ansible-community/molecule/issues/2895#issuecomment-737141425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHAYT6LDOO3XUHASUVELVDSSYJSHANCNFSM4SUIHYUQ
.

@apatard @juju2112  - Yup, I just tested out with the following versions and "lock file lookup" error no longer occurs.
molecule              3.2.0
molecule-vagrant      0.6
python-vagrant        0.5.15

Thanks for checking up on this. Closing the ticket as it works fine with the currently available latest versions mentioned above.

I think I have to reopen this issue.
My venv:
$ pip3 freeze
ansible==2.10.4
ansible-base==2.10.3
ansible-lint==4.3.7
arrow==0.17.0
bcrypt==3.2.0
binaryornot==0.4.4
Cerberus==1.3.2
certifi==2020.11.8
cffi==1.14.4
chardet==3.0.4
click==7.1.2
click-completion==0.5.2
click-help-colors==0.8.1
colorama==0.4.4
commonmark==0.9.1
cookiecutter==1.7.2
cryptography==3.2.1
distro==1.5.0
enrich==1.2.3
flake8==3.8.4
idna==2.10
Jinja2==2.11.2
jinja2-time==0.2.0
MarkupSafe==1.1.1
mccabe==0.6.1
molecule==3.2.0
molecule-vagrant==0.6
netaddr==0.8.0
packaging==20.7
paramiko==2.7.2
passlib==1.7.4
pathspec==0.8.1
pluggy==0.13.1
poyo==0.5.0
pycodestyle==2.6.0
pycparser==2.20
pyflakes==2.2.0
Pygments==2.7.2
PyNaCl==1.4.0
pyparsing==2.4.7
python-dateutil==2.8.1
python-slugify==4.0.1
python-vagrant==0.5.15
PyYAML==5.3.1
requests==2.25.0
rich==9.3.0
ruamel.yaml==0.16.12
selinux==0.2.1
shellingham==1.3.2
six==1.15.0
subprocess-tee==0.1.6
text-unidecode==1.3
typing-extensions==<IP_ADDRESS>
urllib3==1.26.2
yamllint==1.25.0

First thing I noticed is that molecule takes really long to figure out the machine present while I see it for a long time in virtualbox. Second thing is that if there is still a molecule task running it is locking everything else. I can't login into the machine. And if I have already a shell open on that machine I can't open another one.

I just noticed that the problem is not related to this ticket.
The lock file problem exists outside of molecule-vagrant

@dennycrane0 - What problem is not related to this ticket? The description in the your comment above was a little vague. A little more information would be more beneficial.


Update or inline anima?

I'm really interested in using yaks but the project I want to use it on uses anima 0.3. The changes are very straightforward but 0.3 also is limited to ruby 2.1. I'm happy to do the work to update this project and Attribs and I imagine you would prefer one of two options:

Simply update to Anima 0.3 and push a new release of yaks that only supports 2.1 and up. Ruby 1.9 and 2.0 are EOL so I think this is totally reasonable but I realize there is a small chance that you might still want to support these older rubies.

Inline Anima 0.2 or 0.3 into either yaks or attribs to skirt the ruby dependency issues.

Would you be open to a PR making these changes?

Hi John,
Yes, please! Dropping compatibility is fine I think in this case, I rather do that than forcing people to older versions of gems. So, pull request very welcome!
Thanks,
Arne


Fix example in gravity project settings doc

Some missed renames that a user in discord came across.

Thanks!


Review GKE & RBAC quickstarts

It looks like the instructions for https://www.spinnaker.io/setup/quickstart/halyard-gke-deploy-rbac/ have become a little muddled. This quickstart seems to be intended for users who already have a spinnaker deployment running in GKE (the prerequisites state as much) but the instructions suggest modifying deploymentEnvironment settings at the end.  This has lead to confusion (https://github.com/spinnaker/spinnaker/issues/3384).
Steps to resolve:

Run through the two GKE quickstarts start-to-finish (initial setup and rbac)
Ensure the two quickstarts can be completed "end-to-end" by simply running through the commands listed
Correct any errors / omissions

I've been able to setup with GKE using the quickstarts since this issue was opened.


Don't write response with method get

Hey,
It's not an issue, but an feature request.
Is there a possibility to skip the response in case of get Method and response code 200?
after one day I've got about 200MB of data overhead due to this.
I disabled now the logging for get requests.
Thank you in advance!

Hi @laugrean
You can log only limited methods and status code.
DRF_API_LOGGER_METHODS = ['GET', 'POST', 'DELETE', 'PUT']  #
DRF_API_LOGGER_STATUS_CODES = ['200', '400', '404', '500']  #
Please let know if you face the issue again.

Thank you for your feedback.
Is there also a plan to add additional methods like 'PATCH' ?

Closing due to inactivity.


Almost remove EditorShell.Current

The reason for this change is to avoid bugs like we had later in previous iteration when EditorShell.Current was null when it was first accessed and cached. Another reason is to allow editor tests to run concurrently.
The only two places where EditorShell.Current is still used are REditorSettings and RToolsSettings. Removing it from there require additional changes and can be done in a separate pull request.

Let's use Codeflow for this change - GitHub dies on big changes

        EditorTree tree = new EditorTree(textBuffer);

Sounds line a merge conflict, I added using with the last merge

Refers to: src/R/Editor/Test/Signatures/ComputeCurrentParameterTest.cs:43 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = False)

        using (var tree = new EditorTree(textBuffer)) {

As above

Refers to: src/R/Editor/Test/Signatures/ComputeCurrentParameterTest.cs:99 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = True)

    ITextBuffer _textBuffer;

private/readonly if you don't mind

Refers to: src/R/Editor/Impl/Validation/Tagger/EditorErrorTagger.cs:47 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = False)

        rcc?.TriggerSignatureHelp();

Merge conflict, should be the other way around

Refers to: src/R/Editor/Impl/Signatures/SignatureHelp2.cs:21 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = True)

        EditorTree.Closing += OnEditorTreeClosing;

Merge conflict

Refers to: src/R/Editor/Impl/Outline/ROutlineRegionBuilder.cs:52 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = True)

    ITextBuffer _textBuffer;

Both _textBuffer and _document are set to null in OnDocumentClosing. Do we need it?

In reply to: 229181322 [](ancestors = 229181322)

Refers to: src/R/Editor/Impl/Validation/Tagger/EditorErrorTagger.cs:47 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = False)

        EditorTree.Closing += OnEditorTreeClosing;

Sorry, don't get it. There is no change on this line

In reply to: 229183336 [](ancestors = 229183336)

Refers to: src/R/Editor/Impl/Outline/ROutlineRegionBuilder.cs:52 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = True)

        EditorTree tree = new EditorTree(textBuffer);

Fixed in all the places where EditorTree is created

In reply to: 229176727 [](ancestors = 229176727)

Refers to: src/R/Editor/Test/Signatures/ComputeCurrentParameterTest.cs:43 in 9069c6d. [](commit_id = 9069c6d7486a134450bf3b677b6c4b65a496e27b, deletion_comment = False)

👍

:shipit:


Better docker-compose compatibility

This issue is used as an umbrella to track the progress of docker-compose compatibility.

[ ] Containers are not scheduled to nodes that the image they're using was built on.
[ ] Each swarm node will build an image independently from the same docker-compose.yml. It results in a set of images with the same name, but different IDs. For example, you will get project_web image on each node, but all of them will be different. So we cannot guarantee that we're going to run exactly the same container on the cluster.
[ ] Swarm is not aware that containers described in a Compose file must be scheduled together. If constraints on CPU and MEM are applied, we can reach a broken state where only a subset of containers will be running. In this case Swarm returns an error because no more resources are available. Scheduling should be atomic for a whole Compose file.
[ ] Swarm-Compose-Mesos compatibility tests. (Partially done by #1150)
[ ] TBD (please help fill-in)

/cc @vieux @aluzzardi @abronan @jimmyxian
@aanand @bfirsh
Relates to #1150

I think some of these problems have been fixed in 0.4 - haven't done a proper test yet. :)

Thanks for creating this issue @chanwit!

Containers are not scheduled to nodes they are built on.

I presume this means that they're not scheduled to nodes that the image they're using was built on? If so, would you mind rewording it for clarity's sake?

swarm is not aware of images being built differently from the same docker-compose.yml

What does this mean?

I presume this means that they're not scheduled to nodes that the image they're using was built on? If so, would you mind rewording it for clarity's sake?

@aanand Yes. May I use yours?

swarm is not aware of images being built differently from the same docker-compose.yml
What does this mean?

Each swarm node will build images independenly, it results in a set of images with the same name, but different IDs. For example, you will get a project_web image on each node, but all of them will be different. So we cannot guarantee that we're going to run exactly the same container on the cluster.

Yes. May I use yours?

Of course!

Good idea @chanwit ! Added a box for the issue related to the scheduler. This is a good way to keep track of those ;)

@chanwit Cool!

I've made an issue on the Compose end to track too, because issues there will probably crop up. :) https://github.com/docker/compose/issues/1910

An idea: Maybe we could run the entire Compose integration test against Swarm? It's a pretty thorough test of everything Compose does.

@chanwit I would add one point, in that the Swarm 'strategies' should include a check, that if all other methods are unavailable, the container should be started on a host that actually contains the image.

@stephanbuys
In Swarm, If run a container and pull image with not found err,  Swarm will try a soft-image-affinity( try to run the container on the node which have this image) https://github.com/docker/swarm/issues/743

I have encountered a specific variant of this where I needed to pin my proxy container to a specific node (n1) in the cluster to ensure a consistent IP address assignment:
proxy:
  image: smashwilson/lets-nginx
  ports:
    - "80:80"
    - "443:443"
  environment:
    - "constraint:node==$PINNED_NODE"

The application service is also pinned to that node due to "old school container linking" (not shown above), but rather than image I was using build to build/deploy the application container.
When I performed a docker-compose build and then a docker-compose up I noticed the re-created application service was still running an old version of my code. This is a two-node cluster and since existing containers on are on n1, the spread scheduling put the build on the other node (n2) in the cluster. That left the app service on n1 running with a stale image by the same name. I attempted to upgrade to Compose 1.6.0RC1 (cool stuff @aanand in that version) since it adds build args (hence build affinity), but then I hit further issues including an API incompatibility from 1.22 client to 1.21 server and paused on that front.
So...that left me wondering: shouldn't the resulting images of a build' be propagated to the other nodes in the cluster to ensure consistent availability when scheduling a container on any one of the nodes? Similarly, shouldn't a pull` be propagated?
However, I appreciate the complexity that opens up since you now have a dilemma when adding new nodes to the cluster -- bombard that new node with all the images? Or perhaps at container creation the scheduled node first consults the other nodes if they have a newer instance of the requested image?

Closing due to lack of activity. Please reopen if you wish to continue discussing it.


improve visualisations

Apply the following changes to the visualization package:

split each trend line into own graph
add table for current weather

https://github.com/isaric/weather-app/blob/54c6b78c11f237d8c9b598eab2221eb576db3ba4/visualisation/plotter.py#L4-L18

no longer needed


Merge pull request #1 from space-wizards/master

523

Uhhhh... Did you make this by mistake? There aren't any changes.

yep. sorry.


[Feature][Manag] Batch Data Stream Management

Description
Add Scheduler for the offline data stream.
it related to https://github.com/apache/inlong/issues/4966
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

keep this issue active for roadmap

fixed in https://github.com/apache/inlong/issues/9813, close it.


First letter "white"

https://infinit.io/_/vf9xHqp
 	Route::group(['prefix' => 'clients'], function(){ 		Route::get('/', ['as' => 'clients.index', 'uses' => 'TKdeController@index']); 		Route::get('/{id}', ['as' => 'clients.show', 'uses' => 'TKdeController@show']); 		Route::post('/create', ['as' => 'clients.store', 'uses' => 'TKdeController@store']); 		Route::get('/{id}/orders', ['as' => 'clients.show.orders', 'uses' => 'TKdeController@showOrders']); 	});
a bit of weird colouring

Hey @Houbsi , it looks more like your parser might be acting strange there. This is what I have:
http://dayle.io/17OpI


[TimeLine] Fixed AreaSelect

This PR closes #185

:tada: This PR is included in version 1.29.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix queueing of historical metrics collection

Set end_time to the end of the current day before queueing historical collection to allow put match and update existing queue item
Set last_perf_capture_on to end time when no metrics were available to prevent constantly queueing the same historical range.

https://bugzilla.redhat.com/show_bug.cgi?id=1436034
/cc @Fryguy @blomquisg @kbrock @jrafanie

@gtanzillo @blomquisg Here's what I was talking about on the call, when I said that realtime captures should never be open-ended for the start_time: https://github.com/ManageIQ/manageiq/pull/14695/files#diff-98e67a56bb0805013a9953cc93e47389R138

I think we still need to make the intervals here https://github.com/gtanzillo/manageiq/blob/8b5bf7441789c5c1c829ff40edea1b3728440acf/app/models/metric/ci_mixin/capture.rb#L28 in split_capture_intervals land on day boundaries so that the queue args will match the next time we try to queue them.

The Time.now rubocops for the spec are for code that's frozen by Timecop.  If you think it's necessary, I can update based on rubocop warnings.


Generate code sample only on operations

Code samples should only be added onto operations.
This fixes issues #13 and #17

Merged, thanks for the contribution!


Update Caprine to 0.2.1

Thank you for the contribution. It was merged directly as 621c12419817604d0b356cd166ed443a285e81f2 to keep commit history cleaner. Your contribution is still credited to you.


Not able to update load_balancer.https_listener_ports_and_certs

Hi,
I am using terraform 0.12.12 and I have a load_balancer resource pointing to "gruntwork-io/couchbase/aws//modules/load-balancer" version "0.2.2".
When I try to modify the segment https_listener_ports_and_certs by removing one listener and I do a terraform plan, terraform complains with the following message:
Error: Error in function call

  on .terraform/modules/load_balancer/gruntwork-io-terraform-aws-couchbase-b2c210b/modules/load-balancer/outputs.tf line 27, in output "https_listener_arns":
  27:   value = zipmap(
  28:
  29:
  30:
    |----------------
    | aws_alb_listener.https is tuple with 4 elements
    | data.template_file.https_listener_ports is tuple with 3 elements

Call to function "zipmap" failed: number of keys (3) does not match number of
values (4).

This seems to be a terraform issue. Modifying the file gruntwork-io-terraform-aws-couchbase-b2c210b/modules/load-balancer/outputs.tf by explicitly adding a dependency on var.https_listener_ports_and_certs solves the problem:
data "template_file" "https_listener_ports" {
  count    = length(var.https_listener_ports_and_certs)
  template = var.https_listener_ports_and_certs[count.index]["port"]

  depends_on = [
    var.https_listener_ports_and_certs
  ]
}

Wow, what a strange issue. Perhaps open a bug with in the Terraform repo to ask what could be causing this? I can't understand how adding depends_on could possibly help... But if it does, I suppose a PR to add that as a temporary workaround would be welcome. Thanks!

@brikis98 Hi, sorry for the late reply. I just created a tiny PR for addressing this.

This repo is being archived, feel free to use a fork if necessary.


Add case study on phase retrieval in Stan

This adds a new case study on performing Fourier image reconstruction in Stan, specifically for holographic coherent diffraction imaging (HCDI).
It is based on the forward model in Barmherzig and Sun 2022: https://opg.optica.org/oe/fulltext.cfm?uri=oe-30-5-6886&id=469550
A rendered version can be seen here: https://brianward.dev/holoml-in-stan/HoloML in Stan.html
This relies on features in Stan 2.30

I added the attribution wikipedia recommends


1254 changes and fixes

Encompassed within the changes + fixes task, this PR just houses the Augur changes required to fix the filtering issue.

@stephensprinkle: it'd be good to distinguish between "expired" markets (i.e., markets that are past their expiration date but which are still open in the sense that they can still be traded on) and "closed" markets (i.e., markets that have been reported on and have had their winning outcomes set).
There's currently a property attached to markets (in the market selector) isOpen, which uses the isMarketDataOpen method (right above the isMarketDataExpired method you edited) to determine whether or not an outcome has been set.  If market.isOpen is false, then the market is closed and can no longer be traded on.
Right now there is a market.isExpired property, which is just set to !market.isOpen.  I think it would be more useful to set this to market.isExpired = isMarketDataExpired(marketData, currentTime) in the market selector.  IMO both "expired" and "closed" should be options in the drop-down.
Is this what was intended with the reported option?  Is market.result intended to be the same as market.reportedOutcome (the outcome of the market once it has been reported on)?  IMO it's easiest to just use the isMarketDataOpen method, which checks for this.

Coverage increased (+0.03%) to 74.168% when pulling 207f82b2bbc1ad7d2443e602b901eaaab23b257d on 1254-changes-and-fixes into ca732534a29db7aed5f05607fe6fcc90e20d0d63 on master.


[Bug Report]: paritionKey should be required by the container resource for a NoSQL database

Describe the bug
The NoSQL Container resource requires properties.resources.partitionKey but it isn't marked as required. The API rejects a container with a partition key with this error:

A Partition key definition is not specified in the request.

To reproduce
Deploy a container to a NoSQL database without specifying the partitionKey.
Code snippet
param databaseAccountName string
param databaseName string
param containerName string

resource cosmosDbAccount 'Microsoft.DocumentDB/databaseAccounts@2023-09-15' existing = {
  name: databaseAccountName
}

resource alertDatabase 'Microsoft.DocumentDB/databaseAccounts/sqlDatabases@2023-09-15' = {
  name: databaseName
  parent: cosmosDbAccount
  properties: {
    resource: {
      id: databaseName
    }
  }
}

resource alertSpecificationContainer 'Microsoft.DocumentDB/databaseAccounts/sqlDatabases/containers@2023-09-15' = {
  name: containerName
  parent: alertDatabase
  properties: {
    resource: {
      id: containerName
    }
  }
}

Relevant log output
No response

Hey @krbar, could you check this via the AVM module you're working on. To do so, I guess we should have a test cases that does not provide the partition key (which should fail as per @carlin-q-scott's bug description) and then update the module accordingly before publishing.
Thanks for raising this @carlin-q-scott and sorry for the late response. The current migration to the Public Registry binds a lot of resources and we try to get through it as fast as possible.

@AlexanderSehr I did not specify the partitionKey at all, so I'm guessing an empty array for the paths is what is not allowed by the resource provider. Their error message is a bit misleading I guess.

I will look at this issue together with @bryansan-msft
Please note that the solution will be implemented in the BRM Repo as the module has already been migrated to AVM. I will drop a comment, once the fix is finished.

@AlexanderSehr could you close this one?

I can @bryansan-msft (cc: @krbar), just before I do - was this covered in the meantime?
If not, I could also offer to migrate it to BRM instead and then handle it there :)

Yes, see the PR linked to this issue

From: Alexander Sehr @.>
Sent: Saturday, May 25, 2024 1:30 PM
To: Azure/ResourceModules @.>
Cc: Mention @.>; Comment @.>
Subject: Re: [Azure/ResourceModules] [Bug Report]: paritionKey should be required by the container resource for a NoSQL database (Issue #4278)
I can @bryansan-msfthttps://github.com/bryansan-msft (cc: @krbarhttps://github.com/krbar), just before I do - was this covered in the meantime?
If not, I could also offer to migrate it to BRM instead and then handle it there :)
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/ResourceModules/issues/4278#issuecomment-2131223903 or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4BPQLRNAOR3I3FTO6RQ5EDZEBY6PBFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZTENZRHAZDONRXGWSG4YLNMWUWQYLTL5WGCYTFNSWHG5LCNJSWG5C7OR4XAZNMJFZXG5LFINXW23LFNZ2KM5DPOBUWG44TQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTHE3TIMJRGAYTHAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMBQGUZTONZVHEYYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVIZTENZRHAZDONRXGWTXI4TJM5TWK4VGMNZGKYLUMU.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Doesn't reflect the node state from store

When tree initialized with some state(for example "expanded": true) this state doen't get applied and tree goes with default behavior.
Example https://codesandbox.io/s/41y00nvw0
See root node state expanded=true but tree is not expanded. Try clicking Test Reactivity button.

See docs. Here is an example how to use Vuex.