Value being used as label on selectcomplete

I have a JSON endpoint that's returning data in the following format:
[{
   id: 1,
   name: "Bob"
}]

And I'm using the following code:
window.addEventListener("awesomplete-selectcomplete", function(e) {
	window.location.href = '/my-path/' + e.text.value;
}, false);

var ajax = new XMLHttpRequest();
ajax.open("GET", "/data.json", true);
ajax.onload = function() {
	new Awesomplete(document.querySelector("#search"), {
		list: JSON.parse(ajax.responseText).map(function(i) { return i; }),
		data: function (item, input) {
			return { label: item.name, value: item.id };
		}
	});
}
ajax.send();

When I select an option, the value (id) is showing up in the textbox rather than the label (name). I'd still like it to use the label, just to pass the id through as the value to the listener. Is there some way to do this?

I feel like the current default behavior for this is very counter intuitive. A combobox is supposed to mimic the behavior of a select with added features. Ideally, a user who doesn't use the added features should not even realize it isn't a normal select. A select uses the value as an underlying id of sorts that you can get and send to the server. As such, the value in Awesomplete should be underlying while the label is put in the input box, just like a select.
The difficulty is Awesomplete is an autocomplete first and a combobox second, meaning there is no current functionality to track a selected index. Ideally, when you select an item in the list, or just fully type out an item so that it matches a value in the list, there should be an underlying index and possible related value stored within the Awesomplete. If the input does not match anything in the list, the index should be -1 or false. This might represent a significant change though, so maybe there's an easier way to do it.
For example, we could add an id field or maybe we allow users to attach whatever they want in each data object instead of just label and value. Then, they can use awesomplete-selectcomplete to pop it in a hidden object. The two problems with this approach though are:

If the user types an entire option without selecting it, it should still get the id on blur. This means there would need to be a function to call to see if the current value in the input matches any labels in the autocomplete list (which there probably should be anyway, for cases such as when you want to enforce that the final value matches something in the list). The function would need to return the data object so you could get the id value of the matched element.

This represents a sizeable amount of extending for what seems like it should be built in if Awesomplete is to support combobox functionality. You would have to use awesomplete-selectcomplete to store the value and attach another onBlur event to check if the typed value is in the list. As @jfi mentioned, this is behavior that is expected, which means many people might turn away from Awesomplete without even realizing this functionality could be implemented. An extended combobox example in the docs could help.


Add dependency injection doc

Make riverpod onboarding easier.
A great feature of riverpod is that we can easily implement dependency injection. But this is not described in the documentation.
The documentation should contain:
How-To  implement dependency injection using riverpod:

provider (singleton)
ProviderScope override
family (I am not sure if that is desired)
testing

If needed, I can contribute to the docs.

Can you be more specific about what you want here? Riverpod is not a DI package. And there are already docs explaining how to define a provider, override it, and test it.

Of course, using riverpod for DI is just a part of it link.
And eventually we use the same concepts (provider, override, testing) that are already defined in the documentation.
I thought about creating an exemplary use case maybe a "case study" that shows how to implement it. Dependency injection is such a frequently applied pattern. Why not promote how easy it is to implement using riverpod?

I'd rather not have a dedicated DI page. Riverpod isn't about DI. It only does DI in small amounts for testing/scoping.
The doc page you linked is out of date. I'd likely remove that mention.

That's alright. Is there a certain reason why riverpod should not be used for DI (anymore)? Because I have seen many projects that use riverpod this way and articles that specifically promote it.


Fix scrollTo for ScrollView

Fix scrollTo in ScrollView.
To support this change I had to populate the Commands property
e.g. UIManager.RCTNativeScrollView.Commands.scrollTo; via this commit https://github.com/ptmt/react-native-macos/commit/3e2557061a0beff3bdf27d7f082f2676cfa132f2.

Wow, thanks! MIssed that one (it's good to have test, but I haven't updated them for the last version, so they are useless)


Support returning multiple errors in a ErrorReponse

I propose to change the ErrorResponse Swagger spec to:
{
    "ErrorResponse": {
      "description": "An error response given by Weaviate end-points.",
      "properties": {
        "error": {
          "items": {
            "properties": {
              "message": {
                "type": "string"
              }
            },
            "type": "object"
          },
          "type": "array"
        }
      },
      "type": "object"
    }
}

This will allow is to return multiple different errors.
I would also suggest to add error categories/subcomponents; this might be used to mark that the error is due to e.g. an ungrounded schema (as described in #520).

You need help with the implementation?

If you have some time to spare, then yes please!
Most of the work will be 'fixing' the other places where this is used, and maybe even removing a few string concatenations.

Sure, what would be best, fork off tree/develop or fork off tree/feature/janusgaph?

Already implemented in gh-521.


json gem dependency is out of date.

The gemspec for this client has:
s.add_runtime_dependency 'json', '~> 1.8', '>= 1.8.3'
Running the stock swagger code gen today creates:
s.add_runtime_dependency 'json', '~> 2.1', '>= 2.1.0'.
We have another code gen library we are trying use alongside this one, and the above discrepancy is making that impossible.
Version 1.8.3 of the json gem is from 2015. I am not certain what the changes are from then until today. I am not finding a changelog that would tell us.

@jwsloan Yes that was intentional. Some other issue had the same issue as yours but with JWT dependency.
I am going to close this issue for now. Let us know if you have any other questions/issues using the SDK.


FEATURE: utilization of benchmark platforms info in the Optimizer method

This PR enhances the Optimizer capabilities to manage the information of the benchmark platforms (i.e., the cloud resources where application modules have been tested and measured).

It also adds to the pom.xml the control of licenses
It adds license to the files which lacked it
It adds the names of the benchmark platforms to the GUI.
It solves bugs that have been found in the lasts days
It contains tests of the management of the new information.
It contains example files used in the tests.

@kiuby88 @adriannieto @andreaturli @rosogon
Could you review the code and provide suggestions?
@rosogon can you check whether the changes I made in dashboard/src/main/resources/webapp/static/lib/angular-topology-editor/editor.js are OK ?
This PR looks long but differences in many of the files are just license addition and text formatting.

Current coverage is 35.64%

Merging #215 into master will increase coverage by +0.02% as of a9e3d3a

@@            master    #215   diff @@
======================================
  Files          325     326     +1
  Stmts        11917   11953    +36
  Branches      1525    1529     +4
  Methods          0       0
======================================
+ Hit           4245    4261    +16
- Partial        436     438     +2
- Missed        7236    7254    +18

Review entire Coverage Diff as of a9e3d3a

Powered by Codecov. Updated on successful CI builds.

+1 on the javascript side

Just as a suggestion, next time try to avoid to push totally unrelated things with the PR (like adding missing headers). You always can open two PR's at the same time. It's easier to review more focused PR's

It is ok for me

@adriannieto  @kiuby88 @rosogon .
Thank you for your comments. I think I've addressed all of them.
I answered most of them after your comments.
@adriannieto I've removed the class Reoptimizer because it contained no useful code at present.
@rosogon I've followed your suggestion regarding the logging feature in some other places along the code... but I've not done it comprehensively yet.
I've already squashed and pushed the changes


Invalid subreddit

The following error occurs when trying to access a non-existent sub-reddit:
Traceback (most recent call last):
  File "/usr/local/bin/rtv", line 7, in <module>
    from rtv.__main__ import main
  File "/Library/Python/2.7/site-packages/rtv/__main__.py", line 138, in <module>
    sys.exit(main())
  File "/Library/Python/2.7/site-packages/rtv/__main__.py", line 118, in main
    page.loop()
  File "/Library/Python/2.7/site-packages/rtv/subreddit.py", line 49, in loop
    self.controller.trigger(cmd)
  File "/Library/Python/2.7/site-packages/rtv/page.py", line 225, in trigger
    return func(self.instance, *args, **kwargs)
  File "/Library/Python/2.7/site-packages/rtv/subreddit.py", line 92, in prompt_subreddit
    self.refresh_content(name=name)
  File "/Library/Python/2.7/site-packages/rtv/subreddit.py", line 58, in refresh_content
    self.reddit, name, self.loader)
  File "/Library/Python/2.7/site-packages/rtv/content.py", line 313, in from_name
    return cls(display_name, submissions, loader)
  File "/Library/Python/2.7/site-packages/rtv/content.py", line 258, in __init__
    self.get(0)
  File "/Library/Python/2.7/site-packages/rtv/content.py", line 327, in get
    submission = next(self._submissions)
  File "/Library/Python/2.7/site-packages/praw/__init__.py", line 524, in get_content
    page_data = self.request_json(url, params=params)
  File "/Library/Python/2.7/site-packages/praw/decorators.py", line 173, in wrapped
    return_value = function(reddit_session, *args, **kwargs)
  File "/Library/Python/2.7/site-packages/praw/__init__.py", line 579, in request_json
    retry_on_error=retry_on_error)
  File "/Library/Python/2.7/site-packages/praw/__init__.py", line 423, in _request
    response = handle_redirect()
  File "/Library/Python/2.7/site-packages/praw/__init__.py", line 397, in handle_redirect
    url = _raise_redirect_exceptions(response)
  File "/Library/Python/2.7/site-packages/praw/internal.py", line 178, in _raise_redirect_exceptions
    .format(subreddit))
praw.errors.InvalidSubreddit: `lkjasdlfkjlsadkjf` is not a valid subreddit

See #119, same issue


CPU usage bug in MailboxProcessor.TryReceive()

ConsoleApp1.zip
Attached a repro project.
When TryReceive() is used without a timeout (i.e. -1 infinite is used). On the first invocation this causes a CPU loop issue where usage reaches >50%.
Second and further invocations of TryReceive() does not have this issue. Only the first invocation.

I workaround the bug by using Int32.MaxValue as the timeout and then effectively ignoring those particular timeouts if they were to occur. Highly specific to our code snippet & use-case, but it has deescalated the issue for us internally at least. This still seems like a urgent issue to be fixed for FSharp.Core though.
type SimpleDebounce(timeout, initialBounce, fn) =
    let debounce fn timeout = MailboxProcessor.Start(fun agent ->
        let rec loop bounceQueued = async {
            let! r = if bounceQueued then agent.TryReceive(timeout) else agent.TryReceive(Int32.MaxValue)
            match r with
            | Some Bounce -> return! loop true
            | Some Expedite when bounceQueued -> fn (); return! loop false
            | Some Expedite -> return! loop false
            | None when bounceQueued -> fn (); return! loop false
            | None -> return! loop false
        }
        loop false)

    let mailbox = debounce fn timeout
    do if initialBounce then mailbox.Post(Bounce)

    /// Calls the function, after debouncing has been applied.
    member __.Bounce() = mailbox.Post(Bounce)

    /// Expedites any outstanding bounce without waiting for the timeout.
    member __.Expedite() = mailbox.Post(Expedite)

Perfect! I did notice a lot of recent regressions being discussed on here concerning the MailboxProcessor in the last year or so. What happened to it?
When is the next FSharp.Core NuGet scheduled for release that might contain this fix?

@nbevans The bug fixes were in corner cases which are relatively rarely used, mostly due to the handling of non-default timeouts.  This bug was a side effect of those fixes.  I suppose it went unnoticed because it is primarily a perf bug, not a correctness one, and creating mailboxes that never get messages is not that common.
I presume the next FSharp.Core will be out on nuget in the usual timeframe (a month or two) so you should apply your workaround until then.

Thank you - you are The Don :-)


Require Storybook v7 in v3

The changes planned for v3, #69 and #72 requires Storybook v7. This PR upgrades the peer dependencies for that.
Same PR on the other end: https://github.com/storybookjs/storybook/pull/20280. Together they (hopefully) fix #82

📦 Published PR as canary version: 3.0.0--canary.81.9c0f315.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Version
Published prerelease version: v3.0.0-next.2

Changelog
💥 Breaking Change

Require Storybook v7 in v3 #81 (@JReinhold)
Story Indexer #77 (@JReinhold)

🐛 Bug Fix

Add vite support #72 (@IanVS)

Authors: 2

Ian VanSchooten (@IanVS)
Jeppe Reinhold (@JReinhold)

:rocket: PR was released in v3.0.0-next.2 :rocket:

:rocket: PR was released in v3.0.0 :rocket:


zlib

A patch to make use of the system library is included here: https://github.com/nicholas-rh/o3de-rpm/blob/ba85072e74feeca867ef3637e3b536cec6d14f4f/copr/o3de/SystemPackages_linux.patch#L60


qzdl: init at unstable-2023-04-04

Description of changes
ZDL is a ZDoom WAD Launcher.
https://github.com/qbasicer/qzdl

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2532


Bluetooth: host: Fix endianness error in L2CAP

Recent code change asserts on ECRED psm being consistent in
l2cap_ecred_conn_req. However, the values are compared between
endianness converted value and non-converted value, which fails on BE
archs.
Signed-off-by: Morten Priess<EMAIL_ADDRESS>

Could somebody please review? Thanks.

LGTM. Though I encourage the author of the commit message to not shorten "fails an assertion" to "asserts". I think that overloads the word "assert" in a confusing manner.

I agree. The term is used so much in our daily work that it degenerated to "asserts". Was going to update, but Carles was kind enough to merge it. Next time ;-)


Generate schema task throws kotlin.KotlinNullPointerException

This plugin just throws kotlin.KotlinNullPointerException on basically nothing with a standard bare bone java-library deployment.
plugins {
    id 'io.github.divinespear.jpa-schema-generate' version '<IP_ADDRESS>'
}

apply plugin: 'java-library'
apply plugin: 'io.github.divinespear.jpa-schema-generate'

...
generateSchema {
    targets {
        targetName {
        }
    }
}

./gradlew generateSchema -> kotlin.KotlinNullPointerException
I would expect a significant error message if any configuration is missing anywhere. I have a persistence.xml file in the right path and don't need to scan packages.
Gradle wrapper is set on 4.4.1

I have exactly the same issue.
My config is:

vendor = 'hibernate+spring'
three package to scan

Nothing more.

Okay the answer is to specify the following parameter:
databaseProductName = <your database name> (e.g. PostgreSQL)

Should be added to documentation.
By the way the documentation should be updated to reference all the possible options.

There are more details when running with --stacktrace option:
...
Caused by: kotlin.KotlinNullPointerException
        at io.github.divinespear.plugin.TaskKt.persistenceProperties(task.kt:238)
        at io.github.divinespear.plugin.TaskKt.access$persistenceProperties(task.kt:1)
        at io.github.divinespear.plugin.JpaSchemaGenerationTask.doGenerate(task.kt:123)
        at io.github.divinespear.plugin.JpaSchemaGenerationTask.doRun(task.kt:84)
        at io.github.divinespear.plugin.JpaSchemaGenerationTask.run(task.kt:50)
        at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:103)
        at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:48)
        ....

@ivarprudnikov Sorry about too late response, I've heavy work loads...
You need to set databaseProductName options if did not set hibernate.dialect on properties.

Did set properties = mapOf("hibernate.dialect" to "org.hibernate.dialect.MySQL5InnoDBDialect")` but still getting a NPE

Did set properties = mapOf("hibernate.dialect" to "org.hibernate.dialect.MySQL5InnoDBDialect")` but still getting a NPE


[improve][broker] PIP-192 updated metrics and cleanup broker selector

Master Issue: https://github.com/apache/pulsar/issues/16691
Motivation
Raising a PR to implement: https://github.com/apache/pulsar/issues/16691
Modifications
This PR

Added Override EventType metrics
Made ExtensibleLoadManager.selectAsync for cleanup broker selector.

Verifying this change

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

*Updated unit tests.

Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: https://github.com/heesung-sn/pulsar/pull/40

Raised a load-balance dashboard PR here. https://github.com/streamnative/apache-pulsar-grafana-dashboard/pull/93

@gaoran10 @Demogorgon314 PTAL by any chance.


Can't install on win64 php7.0.10

When I run: php jupyter-php-installer.phar install
it throws:
ERROR: Error while trying to download Jupyter-PHP dependencies with Composer.
when I run: php jupyter-php-installer.phar install -v
it says:
The Jupyter-PHP kernel has been successfully installed.
but there is no single trail of php kernel

Should be fixed now, see Litipk/Jupyter-PHP-Installer#14

Related with https://github.com/Litipk/Jupyter-PHP-Installer/issues/11 , supposedly fixed.


Bluemap doesn't load station indicators

Expected Behaviour
A clear and concise description of what you expected to happen.
I expect that the station icon to appear in Bluemap
Actual Behaviour
A clear and concise description of what actually happened.
It fails to load and right-clicking the not loaded image icon that the browser shows, will result in a 404.
Reproduction Steps
Steps to reproduce the behaviour:

Use Bluemap with MTR
Make a route
Go to Bluemap

Crash Report
Attach a crash report to the issue.
N/A
Screenshots
If applicable, add screenshots to help explain your problem.

Environment

Minecraft Version: Fabric 0.14.24, 1.19.4
Installed Mods:
Bluemap
Debugify
Fabric API
Fabric Language Kotlin
Ferritecore
Hold That Chunk
ImmediatelyFast
InRealTime
Lithium
MemoryLeakFix
MixinTrace
MTR
MTR London Underground (v2.0.7)
Nemo's Transit Expansion
Station Decoration
NoChatReports
Starlight
Worldedit

Additional Information
Anything else you want to add?
N/A

Bump. Anyone know anything?

Same with MTR-fabric-1.19.4-3.2.2-hotfix-1.jar and BlueMap 3.20, URL /assets/mtr/textures/block/sign/logo.png ends up 404.
Looks like I can "fix" it by putting resources/common/normal/assets/mtr/textures from the repository in bluemap/web/assets/mtr/  of my minecraft server install, but the logo ends up giant (I did resize the logo to 32x32 for now).
I guess there is some support missing somewhere or something.

@rhaamo I can't figure out what you're saying, could you give me some instructions please?

@ProbablyIdiot  there saying they can fix this by putting resources/common/normal/assets/mtr/textures into from this repo to bluemap/web/assets/mtr/  though the icon will be large
@rhaamo is this correct :/, and have you forked the project and added the changes

@rhaamo is this correct :/, and have you forked the project and added the changes

that is correct, just put the folder at the mentioned place.
No I didn't forked the project because that's probably an issue with BlueMap (perhaps on their side related to maybe not being able to specify a size), and the logo is probably used as assets in the game, so resizing it "in the mod" won't do good.


Can't Launch Server or Client

Hey Jason, great tool! I've been salivating over it all morning and have been running queries here and there.
I have collected 7 months' worth of data from 1/1/2019 CX HKG-SGN in Y, and it's all parsed, but I can't seem to launch the server and client tool (it freezes after "Success!" and there's an error when doing client). Do you have any suggestions? Running Windows 8.1 and here's my node.js command prompt:

It would be great to visualize these availabilities! Thanks!!

You need to keep the server running in the background. Run flightplan server, then open a new cmd.exe window, and run flightplan client. The error it's giving you is that it's can't find the server on port 3000, because you terminated it.

Of course! A second window! Thanks, Jason! Looking forward to v2!


[WIP] Campaign publish button

Implements the frontend UI and backend API logic for publishing campaigns. See https://projects.invisionapp.com/boards/9GX68PTXUQFH/#/1547737/71700347

Builds on https://github.com/silverstripe/silverstripe-framework/pull/5304, so needs to be rebased once that other pull request is merged.
Also reliant on https://github.com/silverstripe/silverstripe-framework/pull/5307 being merged.
No PHPUnit tests for CampaignAdmin functionality. It's pretty basic stuff, and all those API endpoints should be considered temporary - we haven't gotten around to discussing a "proper API layer" in SS4 yet.
Contains a refactor of the records state shape, from array based to object+key based. See commit for rationale. Technically it could be a separate PR, but it also changes the way campaign admin interacts with this store, which in turn is bound to https://github.com/silverstripe/silverstripe-framework/pull/5304

Here's an easy way for Page_Controller to generate a campaign with a changed page (since there's no way to do this through the UI yet). Careful, destructive action.
public function setup() {
	DB::query('TRUNCATE ChangeSet');
	DB::query('TRUNCATE ChangeSetItem');

	$page = Page::get()->byID(1);
	$page->Content = rand();
	$page->Version = $page->Version + 1;
	$page->writeToStage('Stage');

	$set = ChangeSet::get()->filter('Name', 'Test')->first();
	if(!$set) {
		$set = new ChangeSet();
	}
	$set->Name = 'Test';
	$set->write();
	foreach(Page::get()->filter('ParentID', 0) as $page) {
		$set->addObject($page);
	}
	$set->write();

}

@flashbackzoo Have squashed a bit more, fixed some react warning about array vs object prop types.

Rebased :D


Fix inputTaskDyn not working

This fixes the following error when trying to use inputTaskDyn in a build:
[error] /tmp/sbt_8316130f/input-task-dyn/build.sbt:11: error: Macro
expansion contains free type variable T defined by wrap in
InputConvert.scala:76:20. Have you forgotten to use c.WeakTypeTag
annotation for this type parameter? If you
have troubles tracking free type variables, consider using -Xlog-free-types (out-1)
[error]     runFoo := Def.inputTaskDyn { (out-1)
[error]                                ^ (out-1)
[info] [error] sbt.compiler.EvalException: Type error in expression (out-3) (out-1)

I have no idea what the error means, I just implemented the suggested fix.

I broke this: https://github.com/sbt/sbt/commit/12c2734052a2e15f1830eb21cd9fa68209270116#diff-75d794b9e580cad4347ab4a866ad8810R78
Thanks for submission @smarter, I'll take it and extend it to other similar breakages in that patch.

superseded by #3044


Midi Support has broken again. (Windows 10)

Windows 10. Latest build.
Using any kind of instrument throws the "Midi Support not Available" screen.
Error in the client console.

Can you, or someone else, still reproduce this?

Just reproduced on latest master.

Just tested on latest commit on Windows 10. Works fine.
unable to reproduce

Fixed on latest master


Issue from website page Widgets Catalog

Steps to Reproduce
Please tell us what you were doing and what went wrong. If you are running flutter tools from the command line, please try adding the -v or --verbose option to gather more information.
If the problem is with your application's rendering, please attach a screenshot and any relevant source code.
If you are getting an exception in the logs, and your code is implicated in the first few frames, then please include the source code for the functions involved.
Logs
Run your application with flutter run and attach all the log output.
Run flutter analyze and attach any output of that command also.
Flutter Doctor
Paste the output of running flutter doctor -v here.

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

This issue doesn't seem to contain any information.
I'm closing this out. If there is still a problem please create a new issue with more information.


Make query and queries both valid ways to reference the props

Per the discussion in #119. Opening this to track.

I started working on this in #123


Update readme

Readme is out of date. Should be updated.

Updated to current syntax but that's not everything. Need to add additional use cases.

#72


fix(minifront): #1391: display filled icon for the active auction

Closes #1391
Shows the green checkmark icon for all filled dutch auctions

Can you show a screenshot of the new design?

@grod220 Unfortunately can't figure out how to run the dutch auction these days...

@grod220 Unfortunately can't figure out how to run the dutch auction these days...

You can create an auction in testnet (and probably in devnet too) if you manually set the Maximum and Minimum values for the auction.
See the video from this issue (the bug is not related to this PR)
https://github.com/penumbra-zone/web/issues/1532

@Valentine1898 Thanks, I completely forgot that min and max are inputs. Hopefully will be changed soon with new designs.
Here's the screenshot that shows a green icon progressing towards the end of the auction


gpt4o完整结果

请问什么时候可以公布got4o等闭源模型在benchmark上完整的结果

Hi, we do not have a plan to test commercial models on the full E.T. Bench. To compare your own method with these models, you may set --subset when running compute_metrics.py.


Replaced Firefox login by chrome to fix permission denied bug

Replacing FirefoxDriver by ChromeDriver fixed issue #9, which seems to be an abandoned bug by Mozilla (see here)

Closing pull request after committing changes intended for personal use by mistake. Actual bug fix suggestion is here


This is PR is triggered by https://github.com/node-gradle/gradle-node-plugin/issues/130#issuecomment-766833534. Thank you, @deepy !
I will test it now on my Ubuntu ARM64!

This is PR is triggered by https://github.com/node-gradle/gradle-node-plugin/issues/130#issuecomment-766833534. Thank you, @deepy !
I will test it now on my Ubuntu ARM64!

Thanks so much for this PR @deepy - sorry it took so long to merge this. In the meantime, we're using the latest gradle-node-plugin version.


Update the Firebase storage utility functions to support both the old and new storage bucket syntax

The logic here is broken /workspaces/ergonomic-react/src/lib/storage.tsx because it only supports the old storage bucket syntax.
Previous syntax: gs://my-firebase-project.appspot.com/_test/0.txt
New syntax: gs://my-firebase-project.firebasestorage.app/_test/0.txt

No mention of gs:// in the codebase anymore


fix: improve display of table in the nbsphinx context

Fix #933
I force the table-layout to auto when the table is nested in a .html_render class
I updated the width of the pandas exampe to check to display
@JoerivanEngelen, @jesnie could you confirm that it solves the issue from you side as well ? I cheked the example you gave and the classes embedding the table were quite different than ours.

Is it possible for us to produce an example that shows the issue? In #958, I cherry-picked f24e6ee and 5a36dc5. To me both tables look fine.
With 9c74db8, the table looks like

Without 9c74db8, the table looks like

I don't think it's possible for us to use nbsphinx in our docs without disabling MyST-NB 🤔. Im +1 on merge once others confirm their bug is gone.

It may be worth merging this and releasing 0.11rc1 soon. A release candidate would make it easier for folks to test.


seq:  "got 1 midi tracks (out of 2)" when help file says it's supposed to merge all tracks into one

I'm not really sure if this is a bug or just a misunderstanding on my part, but when reading a MIDI file with two tracks, [cyclone/seq] writes a message to the console saying "got 1 midi tracks (out of 2)". The help file says that it's supposed to merge all tracks into one. This is under cyclone v0.4 and pd v0.50.0 (32-bit) and  on Windows 7 Home Premium, SP 1.
Here's a link to the MIDI file (which I downloaded from some web site, I don't remember where):
https://www.dropbox.com/s/kmb4jzmbusyk7jl/Gymnopedie1.mid?dl=0
Here are screen shots of the patch and the system console after clicking on the [read( message and selecting the MIDI file:

other issues

missing dump method, which I don't get or care for

Dump: Opens a standard Open Document dialog box, to select a saved sequence or standard MIDI file. The selected file is opened as text in a new Untitled text window, which can be edited and saved.
https://docs.cycling74.com/max7/maxobject/seq

more?

Max 7.3.2 supports MIDI Type 1 (separate information for each track). Cyclone already does this but doesn't seem to save type 1 (don't know how max saves midi files. Anyway, this seems nothing to worry...)

[seq] has extra methods/features not available in max and that were not documented even in cyclone. It's hard to know what some are supposed to do and if they work at all or not... so this not supported (yet). Seems like Czaja had plans of a super sequencer (which may have become another project [xeq]?). Anyway, there's a need to figure this out and know what to do with them.

also... Max 7.3.2 says it now supports MIDI Type 1 (separate information for each track). Cyclone already does this but doesn't seem to save type 1 (don't know how max saves midi files), see https://github.com/porres/pd-cyclone/issues/258

also... Max 7.3.2 says it now supports MIDI Type 1 (separate information for each track). Cyclone already does this but doesn't seem to save type 1 (don't know how max saves midi files).

https://www.dropbox.com/s/kmb4jzmbusyk7jl/Gymnopedie1.mid?dl=0

this item has been deleted. You should have just uploaded the midi file as a zipped attachment to this page.
I'll start a new issue


Fix race condition in connection_manager_test.go

What does this PR do?
Fix a race condition that would make a test flaky
Motivation
https://circleci.com/gh/DataDog/datadog-agent/77565?utm_campaign=chatroom-integration&utm_medium=referral&utm_source=slack

Codecov Report

Merging #2547 into master will decrease coverage by 0.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2547      +/-   ##
==========================================
- Coverage   57.08%   56.45%   -0.63%
==========================================
  Files         350      379      +29
  Lines       19388    23894    +4506
==========================================
+ Hits        11067    13490    +2423
- Misses       7491     9490    +1999
- Partials      830      914      +84

Impacted Files
Coverage Δ

pkg/util/containers/metrics/common.go
80.95% <0%> (-19.05%)
:arrow_down:

pkg/metadata/host/host.go
62.79% <0%> (-15.86%)
:arrow_down:

pkg/logs/input/file/file_provider.go
79.06% <0%> (-15.38%)
:arrow_down:

pkg/util/docker/event_types.go
85.71% <0%> (-14.29%)
:arrow_down:

pkg/logs/input/file/rotate.go
41.17% <0%> (-12.67%)
:arrow_down:

pkg/logs/sender/sender.go
52% <0%> (-11.89%)
:arrow_down:

pkg/logs/input/file/tailer.go
70.63% <0%> (-11.78%)
:arrow_down:

pkg/logs/input/file/scanner.go
49.27% <0%> (-10.91%)
:arrow_down:

pkg/metadata/v5/payload.go
42.85% <0%> (-10.09%)
:arrow_down:

pkg/collector/corechecks/system/iostats.go
36.84% <0%> (-9.83%)
:arrow_down:

... and 234 more


[4.0.3] Keyboard shortcuts no longer work

After updating to 4.0.3 I can no longer use keyboard shortcuts to control kwm. All the other rules and settings in my kwmrc file are being respected. I've tried removing kwm and reinstalling via homebrew, removing and rea-dding kwm to the list of applications that can control my computer in the settings menu and starting and stopping the kwm service, but so far nothing has worked.

use khd?

To expand on the comment above me, since version 4.0.2 the keybindings have been moved to https://github.com/koekeishiya/khd as a standalone program.
If you are coming from a version before 4.0.2 you will need to convert your keybindings to the new program and format for them to work.

Ah got it. I have khd installed and it's working fine. Thanks for the help.


Software renderer: Added support for linear-gradients.
Software renderer: Fixed artifacts when components are deleted or elements become invisible.
Fixed Infinite loop in the accessibility backend on Windows (#2195).
Skia renderer: Enable anti-aliasing for rectangles with border radius.
Fluent style: Adjust disabled scrollbar background color.
Fixed several panics in the compiler (#2312, #2274, #2319).
Winit backend: Fix rendering when moving windows between monitors with a different scale factor (#2282).

Slint Language

The old syntax that declares component with := is now deprecated
Flickable: don't forward events if the flickable is dragged in a direction that can be dragged, even if at the bounds.
The TextEdit and LineEdit elements now correctly handle double click and tripple click to select words or lines,
as well as support for the "primary" clipboard on X11 and wayland (select to copy, and middle click to paste).

Rust

Minimum Rust version is now 1.66.
Breaking: Deprecated functions and enums were removed from the API.
Breaking: PointerEventButton::None was renamed PointerEventButton::Other
Breaking: More functions now return Result, and the return value needs to be unwrap()'ed.
Breaking: A lifetime parameter was added to slint::ModelPeer.
Breaking: StandardListViewItem and TableColumn are now marked as #[non_exhaustive].
Breaking: Removed the stride() function from slint::Image - use width() instead.
Breaking: In slint::platform::WindowEvent::KeyPressed and KeyReleased, the text field is now
a slint::SharedString.
Breaking: slint::platform::WindowEvent does not derive from Copy anymore. You must clone() it
explicitly if you want to create a copy.
Breaking: The MAX_BUFFER_AGE const parameter of slint::platform::software_renderer::MinimalSoftwareWindow
has been removed and replaced by an argument to the new() function.
Breaking: The compat-0-3-0 mandatory cargo feature flag was renamed to compat-1-0.
Added a software-renderer-systemfonts feature to the Rust crate, to enable the use of fonts from the operating system
for text rendering with the software renderer.
Fixed some clippy warnings in the generated Rust code.

C++

Functions that take a functor as argument are now using C++ 20 concepts.
Breaking: In the C++ API, the type for row indexes in models was changed from int to size_t.
This includes arguments of virtual functions in slint::Model that needs to be adjusted in
derived classes.
Breaking: The order of C++ generated struct members is now preserved from the .slint source file.
Add constructors to slint::Image to create images from raw pixel data.
In C++ builds, support all image formats the Rust image-rs crate supports, not just png and jpeg.
Added the SLINT_FEATURE_RENDERER_WINIT_SOFTWARE option to enable the software renderer.

Tooling

LSP: don't add spaces when auto-completing elements or callbacks, leads to better formatting.
The online editor was renamed to SlintPad.

v0.3.5
Compare Source
Fixed

FemtoVG: Fix cursor placement at end of lines
Windows: Fix panic when minimizing windows
Fixed some panics in the software renderer when using text
Fixed panic when parsing invalid linear gradient syntax
Qt: Fixed mapping of the control key
Linux: Fix panic when using GLX
Fixed const detection when using two-way bindings
Fix run-time panic when combining forward-focus with text rendering in no_std environments
Rust: Fix compile issues when generated code clashes with user types
C++: Fix compilation with structs that have a field with the same name as the struct
Fix visible property on the root of a component
Fix compiler panic when an component's base is not inlined
C++: fix including the generated file in several translation units
C++: Fix "make install" on Windows

Added

The StandardListView provides now a set-current-item function to set the selected item and bring it into view.

v0.3.4
Compare Source
Changed

A new syntax is available that declares the components with component Xxx { ... }  instead of Xxx := ....
The old syntax continues to work in this release.
A warning is shown when calling non-pure function or callback from pure context (eg: a property binding).
Callbacks and functions can be annotated with pure.
On an Image, the default value of source-clip-width and source-clip-height is now set to
the size of the image minus the source-clip-{x,y}. The source clip size is now used to compute
the default aspect ratio of the image.
Deprecated invoke_callback functions in the slint interpreter in favor of invoke, which can also
invoke functions in addition to callbacks.
Warn if the last component or singleton in a file is implicitly marked for exporting.

Added

StandardTableView widget.
LSP: support of Slint features (auto-complete, preview, ...) in slint!{} macro in Rust files.
The software renderer can now load fonts at run-time, without the need to pre-render glyphs
at compile time.
The preview in the online editor, VS Code extension, and the VS Code web extension highlight
components while the cursor is on the component type name.

Fixed

Compiler panic for files containing no component (#2005).
Calling public functions from native code.
Fixed crash when using repeaters in C++ on 32-bit architectures.
Conversion of array literal containing struct with array literal (#2023).
Structs exported by the main file are always generated in native code (#594).

v0.3.3
Compare Source
Changed

Minimum rust version is now 1.64.

Added

Added support for declaring functions in the language.
Added support for re-exporting types from other files using export * from "./other_file.slint";.
LSP: highlight and renaming of element id.
online editor: Add zoom to the preview.
VSCode and online editor: Added UI to edit and remove property bindings.

Fixed

Fixed privacy rules in global properties. #1951
Fixed drawing of images with the software renderer.
Fixed visible property on element with drop shadow. #1460
Warn on bad use of ListView. #860
Fixed two way bindings between globals.
Fixed scrolling of preview area in online editor.
Fixed the CMake build to respect CMAKE_*_OUTPUT_DIRECTORY variables. #1979
Fixed build when using renderer-winit-skia-opengl on macOS or Windows.

v0.3.2
Compare Source
Changed

When using a two way binding foo <=> bar, the default value will always be the one of bar.
There was a warning about this change in previous versions (#1394).
Disallow overrides or duplicated declarations of callbacks. Previously they were silently overwritten,
now an error is produced.
The name init is now a reserved name in callbacks and properties.
In the interpreter, calling set_property or get_property on properties of the base returns an error.
Deprecated slint::WindowEvent and slint::PointerEventButton and moved them to the slint::platform module.
Renamed the Keys namespace for use in key-pressed/key-released callbacks to Key. The
old name continues to work.
The style or the backend now always set a value for the Window's default-font-size property.
In the Rust API, the GraphicsAPI's NativeOpenGL variant uses a function signature for get_proc_address that
takes a &std::ffi::CStr instead of a &str to match the native APIs and avoid unnecessary conversions.

Added

Added new material style based on Material Design, with material-light and material-dark as variants.
Added Window::is_visible in Rust and C++.
Added From<char> for SharedString in Rust.
Added KeyPressed and KeyReleased variants to slint::WindowEvent in Rust, along
with slint::platform::Key, for use by custom platform backends.
Added support for the implicitly declared init callback that can be used to run code when
an element or component is instantiated.
Properties can be annotated with in, out, in-out, or private.
Transitions can now be declared directly within the state.
Online editor: The property view can now edit properties.
LSP preview: When the cursor is on the name of an element, the element's location is highlighted in the preview.
LSP: Added a setting to change the style and the include paths.
VSCode extension: added the property view.
Added rem as unit that represents a relative font size and is multiplied with the Window.default-font-size when used.
Added relative-font-size as type that holds values of rem.

Fixed

Fluent style: SpinBox gets focus when buttons are clicked.
Software renderer: Fix drawing the background color.
Fix Rust code generation when comparing percentages (#1837).
Fix visible property in for and if (#1846).

v0.3.1
Compare Source
Changed

The property Window::background is now a brush instead of a color (allowing gradients).
Switch to yeslogic-fontconfig-sys from servo-fontconfig dependency. This allows for fontconfig
to be a run-time dependency via dlopen.
Skia renderer: Improvements to text input.

Added

Added slint::FilterModel, slint::MapModel to the C++ API.
Added slint::SortModel to Rust and C++ API.
Added VecModel::extend and VecModel::extend_from_slice.
Online editor: Added "Properties" and "Outline" tabs.
Added initial support for input methods with pre-edit text.
Added a dark theme for the Fluent style, which is automatically selected if the system
color scheme is dark.
Added fluent-light and fluent-dark as explicit styles to select a light/dark variant,
regardless of the system color scheme setting.

Fixed

TextInput now shows the text mouse cursor.
In Flickable, added a small delay before passing the Press pointer event to the children.
Online editor: Fixed "go to definition" across files.
Fixed a panic in the slint compiler when visiting layout properties for loop analysis (#1659).
Fixed compilation error in the generated code (#1733, #1735).

Microsoft/TypeScript
v5.0.2: TypeScript 5.0
Compare Source
For release notes, check out the release announcement.
For the complete list of fixed issues, check out the

fixed issues query for Typescript v5.0.0 (Beta).
fixed issues query for Typescript v5.0.1 (RC).
fixed issues query for Typescript v5.0.2 (Stable).

Downloads are available on:

npm
NuGet package

GillianPerard/typescript-json-serializer
v6.0.0
Compare Source
Check the new README to understand how to use typescript-json-serializer now.
BREAKING CHANGES

JsonObject: empty object {} is no longer passed to the constructor on deserialize. This list of default params must be pass to the JsonObject thanks to the new constructorParams property of the JsonObjectOptions if the class contains a constructor with params used in the constructor body.

Fixes

deps: bump json5 from 2.2.0 to 2.2.3 (#196) (63d941d)
JsonObject: JsonObjectOptions has been added to manage default constructor params values (#200) (8f9eba8)
JsonSerializer: take in account the default value of properties when it checks if the value is required (#201) (136ed86)

aaugustin/websockets
v11.0
Compare Source

Configuration
:date: Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:warning: Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
:recycle: Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: php/tests/vaas/composer.lock
Command failed: composer update phpunit/phpunit --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires phpunit/phpunit ^10, found phpunit/phpunit[10.0.0, ..., 10.0.19] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - phpspec/prophecy-phpunit is locked to version v2.0.1 and an update of this package was not requested.
    - phpspec/prophecy-phpunit v2.0.1 requires phpunit/phpunit ^9.1 -> found phpunit/phpunit[9.1.0, ..., 9.6.6] but it conflicts with your root composer.json require (^10).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.


HBASE-21721 reduce write#syncs() times

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 21s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
213m 29s
hbase-server in the patch passed.

242m  1s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2092/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2092

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 23c7ce76340e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9b02a26a1d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2092/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2092/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2092/1/testReport/

Max. process+thread count
2861 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2092/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


docs(troubleshooting): replace auto-generated index with custom overview

Add custom overview page with table-based layout
Add remote generation troubleshooting guide
Fix heading style in false-positives.md
Update category.json to use custom overview

what's the benefit of the index page - doesn't it just mean we will have to manually update every time we change troubleshooting?

what's the benefit of the index page - doesn't it just mean we will have to manually update every time we change troubleshooting?

usability  readability - this was the previous page hosted at docs/category/troubleshooting-1/

The new page has a better url, makes it clear that it’s for redteam troubleshooting, and organizes the content in a way that’s easier to navigate. While it does require manual updates, I think the improved clarity and user experience make it worth the effort. Same for the strategy, plugin, provider, etc. category pages which I would like to do soon. I can write a test to ensure this stays in sync if you’re worried about it falling out of sync.


Flutter image retains on the lists even if image is change

I have a problem with images on the lists with the same file name. Even if I change the image with the same file name, the previous image is still appearing and not the new image.

Hi @glennmichaelmejias
can you please provide the logs while adding and accessing the list
and flutter doctor logs
along with minimal reproducible code.
It would make the issue more understandable as there is not enough information about the issue.
Thank you

here is how i initialized the image lists
 List<FileSystemEntity> file = new List();
heres how i load the images
file = Directory(imagespath).listSync();
here is how i displayed the images
`
Expanded(
child: Image.file(
file[index],
                )),

`
images are displayed correctly on the first run, but when I replace the image content of the file, the previous image is still appearing and not the new one.

it's like the image is retain on the memory and does not clear it fully.

Hi @glennmichaelmejias
Thanks for providing the code snippets.
Seems like the list is not updated.
can you please provide the terminal logs.
additionally please check the index update logic and make UI refresh logic ( setState or any other UI refresh through other state Management techniques)
Thank you

Thanks, I was able to display the new image by using imageCache.clearLiveImages() but it's buggy, I don't know how to implement it correctly. have you tried imageCache?

Hi @glennmichaelmejias,
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this.
You may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Add more textfield tests

Redo of additional TextField tests. These haven't been tested in the NPM environment or anything, so I'm leaving it as a draft PR for now. I tested the logic on Neko and Wincpp and compared with Flash.

https://gist.github.com/MSGhero/848dabee2b1f210abfb252857e7fcc2a


dive build fails with Server did not provide an image ID

When I try to run dive build in the docker.io/wagoodman/dive container, I get the errors:
Error:
Server did not provide an image ID. Cannot write /tmp/dive.360495168.iid
cannot build image
Failed to write to log, invalid argument

Building the image with docker within that image works.
Step to reproduce
Create a Dockerfile:
mkdir /tmp/dive
cd /tmp/dive
echo "FROM library/busybox" >Dockerfile
RUN echo test > /tmp/test   >> Dockerfile

Then run:
 docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v "$(pwd)":"$(pwd)"   -w "$(pwd)" -ti  wagoodman/dive build -t foo/bar:latest .

The execution log:
Building image...
Sending build context to Docker daemon  2.048kB
Step 1/2 : FROM library/busybox
 ---> b534869c81f0
Step 2/2 : RUN echo test > /tmp/test
 ---> Running in a71f209bffb1

 ---> b73a73978ae0
Removing intermediate container a71f209bffb1
Successfully built b73a73978ae0
Server did not provide an image ID. Cannot write /tmp/dive.501940426.iid
cannot build image
Failed to write to log, invalid argument
exit status 1

Note that the image is created:
$ docker images foo/bar:latest
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
foo/bar             latest              b73a73978ae0        18 seconds ago      1.22 MB

versions used:
dive
$ docker run --rm -v /var/run/docker.sock:/var/run/docker.sock --entrypoint= -ti  wagoodman/dive dive -v
dive 0.9.1

docker
# docker run --rm -v /var/run/docker.sock:/var/run/docker.sock --entrypoint= -ti  wagoodman/dive docker version

Client: Docker Engine - Community
 Version:           19.03.1
 API version:       1.26 (downgraded from 1.40)
 Go version:        go1.12.5
 Git commit:        74b1e89e8a
 Built:             Thu Jul 25 21:17:37 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          1.13.1
  API version:      1.26 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       7f2769b/1.13.1
  Built:            Fri Aug  2 10:19:53 2019
  OS/Arch:          linux/amd64
  Experimental:     false

dive needs docker argument --iidfile FILE, which was introduced in v17.06.0-ce

Yeah, unfortunately the Docker version you're using is too old (1.13.1), and as you mentioned, the feature in question is just a few releases after the version you're using.
A workaround would be to run docker build <image> followed by dive <image>, which should work fine. Shout out if that does the trick!


Adding new icon breaks the font

When I add new svg file to svg-src and run get-icon-font task the font is broken. It happens because "code" property added for the new glyph in config json is not unique.

I think I have the same issue.


chore: 🔧 QA for framework wrappers

Description
Automatic updates to Framework wrappers, e.g. to Angular, Vue or React should not lead to broken releases, e.g. if Renovate does dependency updates on the repository.
Rationale
e2e tests are needed for the wrappers which should check if the functionality is still given. Especially Angular ist notorious for breaking APIs.

Blocked by:

https://github.com/synergy-design-system/design/issues/27
#124
#142
#143
#209


swc support?

Hi! This has been answered in https://github.com/Mokshit06/typewind/issues/15#issuecomment-1407744534.

Hi! We've actually added it now: https://typewind.vercel.app/docs/transpilers/swc


apply scope to delegate

http://d.puremagic.com/issues/show_bug.cgi?id=7290

Please add test case.

Escape testing is currently broken 7294.
I don't think we should require matching scope on parameters (see foo7290c) so it behaves like scope classes.


Bugfix/composer.json

Gets Github Actions testing and Github Actions building working. Please follow these steps in your account to turn on improved container support before merging! https://docs.github.com/en/packages/guides/enabling-improved-container-support

OK!  I enabled the improved container support.  Should I do the Create a merge commit? Rebase and merge?  And, then once I do this, I should pull master down to my local branch.  Correct?  (I think I'm starting to see the flow but want to verify.)

It is your choice if you want to do a merge commit or a squash commit, depending on if you care about preserving the commit history for the branch. Once committed, then you can pull your staging branch since that is what this PR is targeting.
Also, in the "Files Changed" tab there seems to be some changes made to tests/Feature/QuestionsViewTest.php but I can't tell what happened there.
Hopefully, once you merge the container should auto-build but we shall see if it encounters any errors.


Apply lora with --apply-lora

Add --apply-lora Argument for Applying LoRA Weights from Safetensors
This pull request introduces a new command-line argument, --apply-lora, which allows users to apply Low-Rank Adaptation (LoRA) weights from a safetensors file to the model. This enhancement facilitates fine-tuning or adapting existing models using pre-trained LoRA weights.
Key Files Affected:

src/flux_1/flux.py
src/flux_1/weights/weight_handler.py

Motivation:
This feature is useful for users who want to quickly adapt pre-trained models with minimal computational overhead, leveraging the flexibility of LoRA. The addition of the safetensors support ensures efficient storage and loading of these specialized weights. Here, I used the weight tensors from Fal.ai
Notes:
Ensure that the safetensors file provided is compatible with the model's architecture and that the LoRA keys correctly map to the model's layers.

I'm just a visitor to @filipstrand's repo, and I'm reviewing as an outside observer.

👏🏼  This is an obvious and must-have addition, thanks @elitexp for pursuing this todo item
✅ I ran this on a M1 Max 64GB, I can verify that the PR's main.py and the new flags works as advertised
✅ --apply-lora on a *.safetensors file that I trained with https://github.com/ostris/ai-toolkit works as advertised
:question: community playground lucataco/ai-toolkit/train's output is based on the same ostris/ai-toolkit repo, so I think safe to assume it should work
❓ safetensor files trained and distributed by fal-ai/flux-lora-fast-training needs verification (I don't have a trained lora ready to go)
🧼 the PR diff needs to be linted/formatted (ruff, black?) to conform to existing repo standards, this approval should be deferred to maintainer @filipstrand

I have the workflow doing well on my M1 Max, will report back if I find any blockers.

Sorry, I mistakenly pushed that import, I was tinkering with the safetensor file to have the proper view of the safetensor file. Thank you for pointing out.
Pushed by removing that import.

This is a great addition to the project! The introduction of the --apply-lora argument adds significant flexibility by allowing users to easily fine-tune or adapt models using LoRA weights from safetensors. This feature is especially beneficial for those looking to adapt pre-trained models with minimal computational overhead, and the safetensors integration ensures efficient handling of the weights.
Positives:
•	The implementation seems well thought out, focusing on user needs for quick adaptation of models.
•	Supporting LoRA through safetensors is a smart choice for efficient storage and loading.
•	Clear motivation and documentation on the changes, which will help other contributors and users understand the new feature.

Suggestions:
•	It might be helpful to add a few example commands in the documentation or comments showing how to use the --apply-lora argument effectively.
•	Consider including some validation checks or warnings for potential mismatches between the LoRA weights and the model architecture, as this could improve user experience and prevent errors.
•	A small section on troubleshooting common issues related to applying LoRA weights would also be beneficial.

Overall, this PR is a valuable enhancement and aligns well with the needs of the community. Great job!

Great initiative. One idea for further improvement would be to be able to apply multiple LoRA's with that argument? e.g. one style LoRA and one character LoRA.

I also am a noob on this and am willing to look into loading multiple LoRAs for adjustment.

Anyone noticed that GPU is not fully utilized during inference??

It would be great to add in the documentation what this would exactly mean?
"Notes:
Ensure that the safetensors file provided is compatible with the model's architecture and that the LoRA keys correctly map to the model's layers."
E.g. some people train on ostris, some on fal, some use dev LoRA's on schnell. Some use Rank 16,32, 64 when training ostris. So maybe we could add the exact LoRA requirements that would match here?
As I am also not so experienced with that topic, maybe someone could figure out? I am happy to test different LoRA's

For example I trained a style LoRA on Ostris with rank / linear 32 / 32 on SCHNELL Toolkit and you see the output of the prompt of the image right at step 4750.
I used the same prompt now and the same seed and sample steps like this " python main.py --model schnell --prompt "a woman holding a coffee cup, in a beanie, sitting at a cafe" --steps 4 --seed 42 --apply-lora style_4750.safetensors"
But the image on the left seem to not even incorporate the LoRA? Am I doing something wrong? Here is the full training config:

python main.py --prompt "A girl as a wonderwoman, Paper cutout Style" --apply-lora girl.safetensors paper-cutout.safetensors --lora-scales 1.0 1.0
Can skip 1.0 weights

@elitexp Thanks for the contribution! Along with actual fine-tuning, this is a very prioritised feature that @awni also recently asked about, so this is very much appreciated. Will take a look soon when I have the time, but some quick notes:
Regarding not using GPU fully, could it be memory related? : https://github.com/filipstrand/mflux/issues/25
@anthonywu @Xuzzo Thanks for the review efforts, also much appreciated :)
As @Xuzzo mentioned earlier, one important guideline I set for myself when starting this project was to mimic the output from the Diffusers reference implementation as closely as possible (the implementation itself can of course be different / more streamlined / less general etc, if it makes sense). If there are big differences in the output image between Diffusers and MFLUX with the same LoRA weights, then that is definitley worth investigating.

This is super cool!! Nice addition @elitexp, hope we can merge it soon. Let me know if there is anything I can do to help.

@elitexp Just got a chance to try it out with "The_Hound" from @TheLastBen that I randomly found on twitter:
https://huggingface.co/TheLastBen/The_Hound
With LORA:
python main.py --prompt "sandor clegane" --model schnell --steps 4 --seed 43 -q 8 --apply-lora "/Users/filipstrand/Desktop/sandor_clegane_single_layer.safetensors" --lora-scales 1.0

Without LORA:
python main.py --prompt "sandor clegane" --model schnell --steps 4 --seed 43 -q 8

With LORA (dev):
python main.py --prompt "sandor clegane" --model dev --steps 4 --seed 43 -q 8 --apply-lora "/Users/filipstrand/Desktop/sandor_clegane_single_layer.safetensors" --lora-scales 1.0

Honestly, I was not expecting it to work "out of the box" with both "schnell" and "dev", but maybe this is actually expected? Anyway really cool that it does!!
This LoRA is ~600kb and seems to perturb only one single transformer block. Just really impressive what can be done with small weight updates!

I am doing some refactoring on this branch and am looking at the interface, specifically the fact that --apply-lora and --lora-scales support loading multiple loras at one. I have personally not tried this yet, does this work well? Does anyone have any examples of a successful fuse of multiple LoRAs? Quite some time ago I remember reading about ZipLoRA, but that method was way more fancy and if I remember correctly, needed to be optimised/trained to actually get the resulting weights.
It is of course flexible to have the option to support multiple LoRAs, but if it is not commonly used or hard to get to work, we should think about if we really want to support it from the start. Once the interface is publicly available, it may be hard to remove/change if people start building upon it...

Fal.ai is supporting it (at least on dev). Therefore I could test it against our solution. Will update progress in a few hours.

@Xuzzo If I can ask you for a favour: I have made some internal refactoring, would it be possible for you to re-run your diffusers vs mflux comparison and confirm their equivalence with the latest commits on this branch when you have the time?

Fal.ai supports multiple LoRAs (at least on dev). Therefore I could test it against our solution. Will update progress in a few hours.

Thanks for testing this. Because of simplicity, I think we will go with a single LoRA to begin with. Then we might do an internal rewrite that also supports actual training as discussed above. But it is still interesting to see what use-cases for multiple loras there are and how well that works in practice, so please post any examples you find :)
Also, since I made some changes, you will have to revert back a few commits to get back the behaviour of multiple LoRAs.

Images still match for me. So everything is working well. Left a couple of minor comments

Thanks for checking! I have to setup lora on diffusers myself when I have the time :)
Then I think this is pretty much ready to be merged. I think it would be nice to add a small section to the readme about this feature also, will do that tomorrow!

Fal.ai supports multiple LoRAs (at least on dev). Therefore I could test it against our solution. Will update progress in a few hours.

Thanks for testing this. Because of simplicity, I think we will go with a single LoRA to begin with. Then we might do an internal rewrite that also supports actual training as discussed above. But it is still interesting to see what use-cases for multiple loras there are and how well that works in practice, so please post any examples you find :)
Also, since I made some changes, you will have to revert back a few commits to get back the behaviour of multiple LoRAs.

Using multiple LoRAs is pretty common. You can find many examples on civitai. Especially with different lora-scales to just add that extra effect you're looking for. For example here with SDXL:
Bildschirmfoto 2024-09-04 um 23.34.03
For our use case I compared this prompt in fal.ai with our solution:
python main.py --prompt 'sandor clegane, Paper Cutout Style' --model dev --steps 20 --seed 43 --apply-lora sandor.safetensors paper.safetensors --lora-scales 1.0 1.0

It's different, but the right direction:
MFLUX:

FAL.AI:

Second example:
python main.py --prompt 'sandor clegane in a forest, Paper Cutout Style' --model dev --steps 20 --seed 43 --apply-lora sandor.safetensors paper.safetensors --lora-scales 1.0 1.0

MFLUX:

FAL.AI:

@sandrop8 Alright, you have changed my mind :) This seems to be a common thing and especially your second example looks as one would expect. When I have the time after work today, I'll change back to support multiple adapters then we'll try to merge this to main later today. Is it OK if I use your example here of multiple LoRAs in the readme?

I have also provided thre multiple lora in the above example. Seems to work but hard to get desired. I will also try to read more on documentation of MLX .

Desired output will be easier once we add support for different lora scales like 0.4, 1.2 etc. This is supported in diffusers and fal.ai goes from 0.0 to 4.0 in 0.1 steps - I just used 1.0 because it was supported, but tried other on fal that looked promising.
However if this is not easy for this merge to implement, we could also do it afterwards.

@sandrop8 Alright, you have changed my mind :) This seems to be a common thing and especially your second example looks as one would expect. When I have the time after work today, I'll change back to support multiple adapters then we'll try to merge this to main later today. Is it OK if I use your example here of multiple LoRAs in the readme?

Sure, you can. And once implemented I would love to share diffusers versus our output instead of fal.ai so we can iterate further on if needed.

I want to thank everyone who contributed to this PR and with all the testing and provided examples. I merged this late yesterday with only one small change to the interface: I renamed --apply-lora to --lora-paths. Other than that it should look the same as earlier.
The next big feature to support is the actual training part. This will involve some internal changes, and we will have to rework how we express the LoRA layers as actual nn modules.
Also, as I wrote in one comment somewhere, I was lucky to get the mflux PyPi name from a previous owner, so during the upcoming weekend my priority will be to do a more proper release of the project.
Really great job everyone! And if you find something broken, unintuitive or something else, please reach out!

Thanks to all the reviewer and suggestions. This repo has really made me research more on the MLX library as well and extend my knowledge. Thanks @filipstrand , @anthonywu, @sandrop8 . Really appreciate the time given for the testing and reviews.


Update the game over message

Update the game over message so people know how to play again!

This works.

This works.


Show heap operation statistics on exit()

Also show number of bytes lost (not freed), etc

f6f9721 adds # malloc() and free()s but not yet bytes lost, cc @mysterywave

efed56a adds the rest of these


Break up parser library

We want to have a smaller parser API and will break up the parser API into three libraries:

HotChocolate.Language
HotChocolate.Language.Visitors
HotChocolate.Language.Core or HotChocolate.Language.Parser

The HotChocolate.Language.Core or HotChocolate.Language.Parser will contain only the new UTF8 parser API and the AST.
HotChocolate.Language.Visitors will reference HotChocolate.Language.Core and provides the visitor and rewriter APIs.
Last but nut least we will have the HotChocolate.Language library that references the HotChocolate.Language.Core and HotChocolate.Language.Visitors and includes also the legacy parser API for compatibility reasons.

This one is now done.