Cannot read properties of undefined (reading 'up')

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I updated to the latest version, I'm getting the following error message:
TypeError: Cannot read properties of undefined (reading 'breakpoints')
package.json:
    "@emotion/react": "^11.8.1",
    "@emotion/styled": "^11.8.1",
    "@mui/icons-material": "^5.4.4",
    "@mui/material": "^5.4.4",
    "@mui/styles": "^5.4.4",
    "react": "^17.0.2",
    "react-dom": "^16.13.1",

Code:
import {
    createTheme,
    useTheme,
    ThemeProvider,
} from "@mui/material";
import { makeStyles } from '@mui/styles';

....

const useStyles = makeStyles((theme) => ({
        root: {
            display: "flex"
        },
        drawer: {
            [theme.breakpoints.up("lg")]: {
                width: drawerWidth,
                flexShrink: 0
            }
        },
        appBar: {
            [theme.breakpoints.up("lg")]: {
                width: `calc(100% - ${drawerWidth}px)`,
                marginLeft: drawerWidth
            }
        },
        menuButton: {
            marginRight: theme.spacing(2),
            [theme.breakpoints.up("lg")]: {
                display: "none"
            },
            backgroundColor: darkState ? grey[900] : blue[500]
        },
        // necessary for content to be below app bar
        toolbar: theme.mixins.toolbar,
        drawerPaper: {
            width: drawerWidth,
            color: "#ffffff",
            backgroundColor: darkState ? grey[900] : blue[500]
        },
        content: {
            flexGrow: 1,
            padding: theme.spacing(3)
        }
    }));

    const classes = useStyles();
    const theme = useTheme();

   ...

    return (
        <ThemeProvider theme={darkTheme}>

             ....

        </ThemeProvider>
    );

Example: Codesandox
Expected behavior 🤔
No response
Steps to reproduce 🕹
Steps:

I am migrating from miui v4 to v5 in accordance with the article published on the official website.
Changed all the imports to the corresponding ones.

Context 🔦
No response
Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: macOS 11.5
  Binaries:
    Node: 14.15.4 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.10 - /usr/local/bin/npm
  Browsers:
    Chrome: 98.0.4758.109
    Edge: Not Found
    Firefox: 97.0.1
    Safari: 14.1.2
  npmPackages:
    @emotion/react: ^11.8.1 => 11.8.1
    @emotion/styled: ^11.8.1 => 11.8.1
    @mui/base:  5.0.0-alpha.70
    @mui/icons-material: ^5.4.4 => 5.4.4
    @mui/material: ^5.4.4 => 5.4.4
    @mui/private-theming:  5.4.4
    @mui/styled-engine:  5.4.4
    @mui/styles: ^5.4.4 => 5.4.4
    @mui/system:  5.4.4
    @mui/types:  7.1.2
    @mui/utils:  5.4.4
    @types/react:  17.0.11
    react: ^17.0.2 => 17.0.2
    react-dom: ^16.13.1 => 16.14.0
    styled-components: ^5.3.3 => 5.3.3

You are using the useStyles hook  outside of the ThemeProvider, you need to have a wrapper component that would add it at the top of the app.
const useStyles = makeStyles((theme) => ({
  root: {/* some styles */}
});

function App () {
  // Now this component is wrapped in ThemeProvider, so it's safe to call the hook
  const classes = useStyles();

  return
;
}

function AppWrapper() {
  // The difference now is that the ThemeProvider wrappes the component that calls the useStyles hook
  return <ThemeProvider theme={theme}><App /></ThemeProvider>;
}

You can find more details on it here - https://mui.com/guides/migration-v4/#themeprovider-setup

@mnajdova : In the example I posted you would show me how you would do it.
https://codesandbox.io/s/wonderful-frost-yfi24x?file=/src/App.js

I've just linked a documentation section on it, and a short code snippet, it should be enough for implementing in your use-case. If something is not working, feel free to re-open or create a new issue.


Fixed buttons misalignment issue ! #753

Fixed buttons misalignment issue - #753

Before -

📄 Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (adds or updates related documentation)

✅ Checklist

[x] I am a participant of GSSoC-ext.
[x] I have followed the contribution guidelines of this project.
[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have added documentation to explain my changes.

Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

[x] This PR is submitted under the GSSoC program.
[x] I have taken prior approval for this feature/fix.

@YadavAkhileshh

@Subhajit-2023-44 please solve the conflicts and then try to push

@Subhajit-2023-44 please solve the conflicts and then try to push

@YadavAkhileshh sir done


[BugFix] List partition support bool type and forbid decimal type.

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #17816
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/ListPartitionDesc.java
2
2
100.00%
[]

run starrocks_admit_test


Export internal utilities for use in other places

In GitLab by @cfunk1210 on Jun 23, 2020, 13:45
This includes such things as the plugin detector, etc.
Essentially, everything value-laden that the framework does should be encapsulated as a function or other piece of functionality, then invoked as needed by the framework itself. These pieces can then be remixed freely in other environments.
Additionally, make the framework able to be loaded from within a python console.
This is a necessary step for jupyter/ipython notebook.  It is also nice for certain debuggers.

In GitLab by @waxlamp on Jul 10, 2020, 11:09
changed title from {-Move to a python import-} to {+Export internal utilities for use in other places+}

In GitLab by @waxlamp on Jul 10, 2020, 11:09
changed the description


Storage: Update generated extensible enums

We're settling on a shared pattern for extensible enums and are adding it to the Guidelines.
We should follow this official pattern in the generator.

Closed with https://github.com/Azure/azure-sdk-for-net/pull/8029


Improve grafana setup

fix problem of when there are more than one nodeSelector criteria, the entries are mis-formatted
quote storageClassName to allow for empty string
allow specification of volumeName

How are things going on this?

Sorry for the inconvenience, but the prometheus-operator and kube-prometheus helm charts are currently being migrated to the upstream stable helm charts. Because of this we are currently not accepting any pull requests. We apologize for the inconvenience, but this is necessary for the migration to actually happen. We announced this here: https://github.com/coreos/prometheus-operator/tree/master/helm#warning
You can view the progress and help here and here.
Thank you for your understanding! :slightly_smiling_face:


add error message for no reactions

Hello @mattldawson! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file interactive/mechanism/reactions.py:

Line 22:80: E501 line too long (80 > 79 characters)

In the file interactive/model_driver/run_setup.py:

Line 56:80: E501 line too long (93 > 79 characters)
Line 58:80: E501 line too long (119 > 79 characters)


request is deprecated

The request package has been deprecated. A replacement such as got should be used.
Raw install output:
warning appcenter-cli ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning appcenter-cli > azure-storage ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning appcenter-cli > ms-rest ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning appcenter-cli > unzipper > fstream ><EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface
has changed to use Promises in 1.x.)

Thanks. We're working on updating our dependencies at the moment.

Has there been progress made on this?

Hi @martin-cech , we are keeping an eye on the issue and PR in the original repo. Also, there is filed issue in active fork from cypress-io: https://github.com/cypress-io/request/issues/27. Hopefully they would able to address the issue soon and we will move to their fork.
Another option is to replace request with got as it was initially proposed and I agree that it would be a good idea. However, it will require careful testing.
Also note, that the severity of the vulnerability is "Moderate".

request was removed in version 3.0.0. Closing.


[fix] replace kit.paths.base if it runs on localhost

fix: https://github.com/sveltejs/kit/issues/2230
Before submitting the PR, please make sure you do the following

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Explain What I Did
In this PR https://github.com/sveltejs/kit/pull/2189, the way of handle for kit.paths.assets in svelte.config.js was changed.
After that, the issue https://github.com/sveltejs/kit/issues/2230 comes.
I think this issue is only a problem in a dev environment like localhost.
(Please check details at here)
So I just handled this issue as like workaround code.
As an alternative way, we can modify module bunder (like Vite).
In this case, we can create a folder which is the value of  kit.paths.assets as the parent of the _app folder. (And maybe something more.)
But in my opinion, we will have a chance to handle this issue for each module bundler.
This is just a little bit troublesome.
Therefore I choose this simple way.
So could you please review this way is reasonable?
Or should I modify Vite or somewhere else?
MEMO

I don't know how to do the brawser test with npm run dev command. Please tell me how can I add a test for it.

When I execute pnpx changeset, it shows If you are unsure if this is correct, contact the package's maintainers before committing this changeset, so now I didn't create changeset. (After getting a review comment, I will create it.)

Thank you!

I realized that just using replace() has chance to mis-replacement if middle of file path has path which is same as base path.
So I will fix it but I'm happy if someone review for this fixing policy!

Another PR to fix this issue has been submitted at https://github.com/sveltejs/kit/pull/2407. I'm not that familiar with this code and haven't looked closely at either PR yet to know which makes more sense

I discussed about this PR with the author of https://github.com/sveltejs/kit/pull/2407.
And I think we should adopt https://github.com/sveltejs/kit/pull/2407 instead of this PR.
Therefore I will close this PR after merge https://github.com/sveltejs/kit/pull/2407 if nothing happens.

Ok, I'll just go ahead and close it now then


[Question] How to load base64 via ImageProperty

Hi, my crop & compression components result base64. I want to use that component before image load.
When i use
this.canvasRef.workareaHandlers.setImage('BASE64_STRING') in onChangeWokarea function
getting this error

Hi, zztrk!
I'll check it out and let you know.

Thank you, i'm waiting for your answer.

Do you want to use the cropped base64 image in your workarea?
Can you show me the code you are writing?

Yes, i want to use cropped data(base64)

Is this what you want to use?

Thank you so much, i found my mistake. I changed imageLoadType to src and it worked :)
👍 👍 👍

👍 Ask me anytime ^^


Control IPv6 on container's interface

Based on whether ipv6 is enabled on the network

Related to https://github.com/docker/docker/issues/20569
Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

@aboch since we have introduced the --ipv6 flag. it does make sense to have this patch in. But can you please clarify the backward compatibility nature of this fix ?

Will this impact the default docker0 bridge ? Meaning, if the user has not specified --ipv6 and if we have the link-local ipv6-address automatically enabled on the container eth0,... how will this change impact the user and any assumptions built on top of existing behavior ?
Will this impact any existing user-defined bridge networks (1.9+) and any built-in assumption ?

@aboch also, I would like to understand if any of the above backward compatibility question is impacted in combination with https://github.com/docker/libnetwork/pull/967 ?

@mavenugo
I don't think it would have an impact on existing docker0 and user-defined networks. Because in case no IPv6 address was configured for the container (either via --fixed-cidr-v6 or --subnet), there was no much use the container could do with a link-local address.
#967 is not related to this one, libnetwork had and has no say in setting the container interface link-local address.

what's the conclusion on this one? (just was reading up the linked docker/docker issue) :smile:

Any update?
I will take care of your comments.

Thanks @mrjana I took care of your comments. Thanks. PTAL when you get a chance.

LGTM

Currently without specifying --ipv6 one can still connect to the link-local IP of the bridge interface, for ex: to access a host local service for that network. With this change it will not work. Given that its not a  common use case I am ok with this change. But it has to be documented.
LGTM.


Transfer eth between main and sub key account

Resolves #1365

Codecov seems to be stuck again. I'm force merging this as the coverage was sufficient before syncing with master

@nephix I changed the codecov configuration to wait for a successful ci completion yesterday, please give it a couple of minutes though. Talel reported it being stuck yesterday, but when I went to merge the PR it was fine, I didn't need to force anything

It was stuck already for 10mins, from my experience it doesn't recover anymore if stuck for that long.

The comment seems to have both the SDK/dapp values updated 33 ago, but it was one of the status checks not working? did you also try refreshing? A couple of times lately I had to refresh the page to see a new status.


Cannot Right Click on icon when in taskbar

Issue Type: Bug
Have VS Code either pinned to the taskbar or showing in the taskbar.  Attempt to right click on the icon to bring up the jump list menu.  It doesn't work.  VS Proper still works, so not an issue with jump lists being disabled on my system.
VS Code version: Code 1.64.2 (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:02:28.252Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10810U CPU @ 1.10GHz (12 x 1608)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.77GB (49.96GB free)

Process Argv
--crash-reporter-id 8ee654bc-dcf4-48cb-a550-5c05f1a3fd7f

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

gitlens
eam
11.7.0

azure-pipelines
ms-
1.195.0

csharp
ms-
1.24.0

vscode-dotnet-runtime
ms-
1.5.0

azure-account
ms-
0.9.11

powershell
ms-
2021.12.0

azurerm-vscode-tools
msa
0.15.5

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30425749
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30433059
pythonvs932:30410667
wslgetstarted:30433507
vsrem710cf:30416617
vsbas813:30436447

/gifPlease

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

👍 , we ship insiders to stable next week, so until then I suggest to stick to insiders if you need this functionality.

Oh and if you just uninstall and reinstall VSCode stable, I am sure the issue also goes away.

I was just able to correct the issue by unpinning the icon from the taskbar followed by pinning it back to the taskbar.  This makes me think that there might be something wrong with the upgrade process.  We'll see if it breaks again once the next stable updates come through.


[W10] AC Origins - loss of stability

First of all, thank you very much for your work, everything you do and the help you provide is greatly appreciated.
Without this tool ACO is unplayable.
Every time I put dxvk for the first time the game works absolutely smoothly, but after a while and after traveling several distances on the map, it suddenly gets lost. What I do is close the game, I delete the text files ACOrigins_d3d11, ACOrigins_dxgi, ACOrigins_d3d10 and the file ACOrigins.dxvk-cache and when I enter the game again the fluency returns, but only for another time.
Even so, when it works "badly" it is still a thousand times better than the game without DXVK. But I would like to keep that fluidity, I don't know much about the subject but is it something related to the cache?

Sorry for the quality of the images, I couldn't take a screenshot.
The photos were taken in the same area, when it started to fail, I went back to the starting point to be able to compare.
Extra programs that I use: MSI afterburner and ISLC (help me with loading textures)
Software information
Windows 10 update daily. 12gb ram i7 3770k.
Settings of game:
Antialiasing: High
Shadows: Normal
Environment details: Very High
Textures qual: High
Tessellation: Very High
Field: High
Clutter: Normal
Fog: Normal
Water: High
Reflections of space on screen: High
Volumetric clouds: Off
Textures details: High
Character details: Very Low
Ambient occlusion: Very High
Depth of field: Off
System information

GPU: rx590
Driver: 21.8.2
Wine version: none
DXVK version: 1.9.1

Log files

d3d9.log: none, if use d3d9 crash the game.

d3d11.log:
ACOrigins_d3d11.log

dxgi.log:
ACOrigins_dxgi.log

Looks fairly normal when your frame rates drop below your monitor refresh rate. Not really sure what you want us to do here, we can't magically improve performance by 20%.

I'm sorry if something I said sounded wrong, I'm not looking for magic solutions and I really appreciate what you do here. I am also aware of what hardware I have. I only share my experience since it is curious how installing dxvk works smoothly and after a while stutter occurs.
When reinstalling dxvk it becomes smooth again, cyclically. This is why I consult, to see if there was a way to maintain that. Do not get it wrong.

Are you sure its not just the restart that fixes it?

Yes that's all I do, I close the game, open the folder, delete the ACOrigins_d3d11, ACOrigins_dxgi, ACOrigins_d3d10 text files and the ACOrigins.dxvk-cache file. Then I go into the game, I wait for everything to load correctly and I go back to playing without problems, until after a while.
Like I say, even when it stutters me, it's incredibly better than playing without dxvk, there's no question, it's just that I found curioso why I lose that smoothness.

delete the ACOrigins_d3d11, ACOrigins_dxgi, ACOrigins_d3d10 text files and the ACOrigins.dxvk-cache file.

Pretty sure, you don't need to do that.

Just restarting without deleting those files should have the exact same effect.

I did that before, in the beginning. It did not touch anything and only restarted the game, but the stutter was already just starting. Then I tried to reinstall dxvk and it worked. I uploaded two photos, they are graphics of the game, the first is when I reinstall and start playing and the second photo is when it gives me stutter.

So it's gotta be the state cache that's causing the problem.

@acorigins Friendly ping. Can you retest with latest dxvk and drivers? :slightly_smiling_face:

Stale issue.


Add config for snapshot bucket to Elastic Cloud configuration.

Awaiting deployment of ES 7.6 to Elastic Cloud in order that we can enable Snapshot Lifecycle Management https://www.elastic.co/guide/en/elasticsearch/reference/current/slm-start.html

Probably not important, I think this was so we could own (have in our AWS accounts),  S3 backups of ES indexes.


SCP-2274: Allow some slippage while calculating machine steps in the evaluator

This allows us to do slightly inaccurate, but faster costing calculations.
The effect of this is that we can overshoot our budget by some amount.
We will eventually notice that we've gone over, and so
long as this is bounded reasonably, it seems worth it.
The way we do it is to:

Assume all the machine steps cost the same.
Keep a simple counter of the machine steps.
Only when the counter exceeds a threshold (the "slippage") do we do
properly account for the steps we've taken.

This isn't quite complete, since currently it has a fixed amount of
slippage (100 steps), which would e.g. be too high for very short
programs. We should probably instead do something like calculate it
based on a proportion of the total budget. (draft until I do this)
Overall this seems to give another 15-20% in benchmarks.

Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

crowdfunding/1            1.464 ms       1.224 ms       -16.4%
crowdfunding/2            1.466 ms       1.214 ms       -17.2%
crowdfunding/3            1.465 ms       1.213 ms       -17.2%
crowdfunding/4            713.7 μs       557.2 μs       -21.9%
crowdfunding/5            713.8 μs       557.3 μs       -21.9%
future/1                  836.7 μs       643.5 μs       -23.1%
future/2                  1.718 ms       1.423 ms       -17.2%
future/3                  1.719 ms       1.432 ms       -16.7%
future/4                  2.138 ms       1.776 ms       -16.9%
future/5                  2.608 ms       2.195 ms       -15.8%
future/6                  2.185 ms       1.861 ms       -14.8%
future/7                  2.606 ms       2.189 ms       -16.0%
multisigSM/1              1.533 ms       1.304 ms       -14.9%
multisigSM/2              1.551 ms       1.343 ms       -13.4%
multisigSM/3              1.576 ms       1.354 ms       -14.1%
multisigSM/4              1.596 ms       1.376 ms       -13.8%
multisigSM/5              1.910 ms       1.601 ms       -16.2%
multisigSM/6              1.538 ms       1.301 ms       -15.4%
multisigSM/7              1.561 ms       1.338 ms       -14.3%
multisigSM/8              1.590 ms       1.348 ms       -15.2%
multisigSM/9              1.605 ms       1.372 ms       -14.5%
multisigSM/10             1.911 ms       1.604 ms       -16.1%
vesting/1                 1.481 ms       1.235 ms       -16.6%
vesting/2                 1.290 ms       1.094 ms       -15.2%
vesting/3                 1.478 ms       1.236 ms       -16.4%
marlowe/trustfund/1       4.105 ms       3.406 ms       -17.0%
marlowe/trustfund/2       3.024 ms       2.579 ms       -14.7%
marlowe/zerocoupon/1      4.193 ms       3.500 ms       -16.5%
marlowe/zerocoupon/2      2.648 ms       2.252 ms       -15.0%

Added the handling of slippage as a fraction of the overall budget.
 For now, I've just pinned a maximum amount of slippage (1000 steps), but I think the right fix is for the benchmarks to instead run things with the correct minimum budget, which we can calculate beforehand (outside the benchmark).

(But I think I'll worry about that in another PR.)

Okay, we get most of the improvement from a fixed slippage of 100 steps. 100 times the step cost
a) an order of magnitude less than the current "startup cost"
b) about 100*70000 picoseconds (if I'm reading the costs right) = 7 microseconds
so I think that's probably actually fine as a potential overshoot on every script. 50 gets us 10%, 100 gets us an extra 2%, 200 only another 1%.
So I'm at least going to rip out the proportional slippage stuff.

b) about 100*70000 picoseconds (if I'm reading the costs right) = 7 microseconds

That number's based on figures from several weeks ago, so I think it'll be signficantly smaller now.

 Code here: https://github.com/input-output-hk/plutus/commits/slippage-primarray (ignore the last commit, that was even worse).
My last hail mary is to try packing multiple counters into a single Word... we have 7 types of step, so I can use a Word8 for each and for the total and fit them all in a Word64...

7 types of step

One of which takes a fun argument, so that we know which builtin costs what, right? And then you can't fit that into a Word64. Maybe it's indeed worth duplicating the evaluator just for the purposes of calibration, since removing that fun argument would also allow us to remove it from the VBuiltin constructor, which is a small optimization.

One of which takes a fun argument, so that we know which builtin costs what, right? And then you can't fit that into a Word64.

This isn't all of ExBudgetCategory, just the part that corresponds to the steps.
Anyway, it seems to not be faster again, annoyingly.

Alternative version with word-packing: https://github.com/input-output-hk/plutus/pull/3279

The benchmark indeed shows that this PR is faster but I don't understand how this can be "algorithmically" faster than what we had before.
Before: we decrease the budget at every step. So i guess, n-times subtraction?
After: we increase a step counter at every step, so n-times addition. Then at every interval (slippage) we do one extra multiplication and subtraction.
Assuming that subtraction vs addition has the same cost cpu-wise, how can it be in principle faster? Is it something accidental and related to the implementation that makes it faster?

Actually doing the costing requires going into ST to modify a mutable array. Here we "just" apply a couple of known word operations and do a comparison.
It was more obvious when all it was doing was bumping an integer: then it seemed plausible that it would be faster. I'm somewhat surprised that this version is still faster... but it is!

Actually doing the costing requires going into ST to modify a mutable array.

Does it though? Is it conceivable that we could actually pass the budget around like we pass the slippage parameter and do comparisons with it etc? It's definitely harder to arrange for an arbitrary budgeting mode, but it would be interesting to see how much this extensibility costs us.

Yes, I think it's possible that passing the budget around just as a simple parameter (especially if we could unpack it down to two integers) would help similarly. So maybe the extensibility does hurt us. Worth trying at some point.

Closing in favour of the other one.


Spurious "more than one YAML document detected" error caused by trailing whitespace in policy

Adding trailing spaces causes an otherwise valid policy to fail to load with "more than one YAML document detected"
apiVersion: api.cerbos.dev/v1
resourcePolicy:
  resource: example
  version: default
  rules:
    - actions:
        - view
      effect: EFFECT_ALLOW
      roles:
        - user
      condition:
        match:
          expr: request.principal.attr.ip.inIPAddrRange("<IP_ADDRESS>/16")

Note the whitespace at the end of the file:
apiVersion:·api.cerbos.dev/v1⏎
resourcePolicy:⏎
··resource:·example⏎
··version:·default⏎
··rules:⏎
····-·actions:⏎
········-·view⏎
······effect:·EFFECT_ALLOW⏎
······roles:⏎
········-·user⏎
······condition:⏎
········match:⏎
··········expr:·request.principal.attr.ip.inIPAddrRange("<IP_ADDRESS>/16")⏎
············⏎
⏎

I'm not sure if this should be allowed by the YAML spec or not, but I've tried a few other parsers/validators and have yet to find one that rejects it. Either way, it's definitely not multiple YAML documents.

This looks like another bug in the upstream parser 😞. The spaces immediately following the last line makes it think that request.principal.attr.ip.inIPAddrRange("<IP_ADDRESS>/16") is a document on its own. If I remove the spaces and just leave the newlines, it's fine.

I wonder if we could work around this and https://github.com/cerbos/cerbos/issues/2019 by trimming trailing whitespace and ensuring a final newline before we parse the file?

Unfortunately, it happens even in the middle of a file if the indentation is dodgy. The parser is trying to handle cases like the following and tripping over itself.
foo:
  # comment
bar: baz

The upstream author has been unresponsive for a while so I might need to fork it and fix these bugs myself. There's another community PR for reducing memory usage that'd be quite nice to have as well.


[tests] use test container registry in WaitFor hosting tests

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist

Is this feature complete?

[ ] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[ ] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[ ] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[ ] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[ ] No

Microsoft Reviewers: Open in CodeFlow

Adding this for the hosting tests would be useful - (https://github.com/dotnet/aspire/blob/23fdf3186ea0fd28f53c1b8fcdacfaf3ff32ff2e/tests/Aspire.Playground.Tests/Infrastructure/DistributedApplicationTestFactory.cs#L57-L77


readline support for sftp

A detailed description of the proposed feature
Make readline support default for openssh installations so that sftp has autocomplete and log history.
The motivation for the feature
Navigating around filesystems with an sftp connection is incredibly tedious when you have to spell out the full names of the files/dirs. I recall wanting this support when using sftp-ing into linux ~10 years ago. I'm astonished that all these years later I still seem to be the only one suffering in silence.
How the feature would be relevant to at least 90% of Homebrew users
I havent done a poll, but just cant imagine why sftp users wouldnt want autocomplete and log-history support.
What alternatives to the feature have been considered
I googled combinations such as sftp autocomplete mac and there's very little by way of solution available in the forums. What suggestions I found were outdated/deprecated.

We'll consider a PR to add this but it's not a "feature" per-se.


test: Breaking and concatenating lines

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Refactor Person class

Removed instances of email from Person class

LGTM. Many small changes around the codebase.


Added light mode in Aspect Ratio Calculator

Fixes Issue🛠
Closes #727
Description👨💻
Added the light mode to the Aspect ratio calculator along with some major design changes.
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅

[x] All the results of calculator are verified from manual calculations
[x] Done the animation check several times

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I am an Open Source Contributor

Screenshots/GIF📷

Change the color of placeholders in both the modes to make it visible clearly @Yuvraj960

@Rakesh9100 Done updating the styles of the placeholder!

Merged 🎉 @Yuvraj960


Specify which sidekiq-cron version is available

Issue description
Stated in https://github.com/floraison/fugit?tab=readme-ov-file 「Related projects - Similar, sometimes overlapping projects」of sidekiq-cron - recent versions of Sidekiq-Cron use fugit to parse cron strings
In the above description, it says that it is available in the recent versions of Sidekiq-Corn, but from which version is it available? Not stated.
How to reproduce
version
Booted Rails 7.0.7, Running in ruby 3.2.2, Sidekiq Pro 5.5.8 / Sidekiq Enterprise 2.5.3
The simplest piece of code that reproduces the issue, for example:
cron.register('07 3,11,15 * * *', 'CreateDfplusCsvWorker', 'args' => [])
config.periodic do |cron|
  cron.register('0 5 * * mon#1', SampleWorker', 'args' => [])
end

bundle exec rails c
>  SampleWorker.perform_async()

Expected behaviour
It should be stated from which sidekiq-corn version it is available.

In Sidekiq-Cron's CHANGELOG.md, it is specified that it uses fugit since version 1.0.0. According to the list of Sidekiq-Cron versions, version 1.0.0 is available since 2018-07-09.

I consider your issue fixed. I stated in the README.md what version of Sidekiq-Cron started using fugit directly instead of rufus-scheduler. You said "not stated" as the issue, it is now stated. Issue closed.
Feel free to open a new issue if you spot anything else.
Please understand that I do not own a license of Sidekiq-pro, so I cannot test it for you.
Please also understand that I am developing this library on my spare time mostly, I cannot give you support for free for libraries that I did not develop. If you can prove that you have an issue with fugit, and you can describe it so that I can reproduce it, I will do my best to fix it.
Best regards.

And
config.periodic do |cron|
  cron.register('0 5 * * mon#1', SampleWorker', 'args' => [])
end

is not valid Ruby code, it should be
config.periodic do |cron|
  cron.register('0 5 * * mon#1', 'SampleWorker', 'args' => [])
end

or
config.periodic do |cron|
  cron.register('0 5 * * mon#1', SampleWorker, 'args' => [])
end

Thank you for your response to the correction.
The issue has been resolved. Thank you!


Connection re-use does not happen in some cf commands

Command
cf service-access -b <broker_name>

What occurred
auth request failed: Error performing request: Post https://login.cf.stagingazure.xxxxx.com/oauth/token: dial tcp 13.81.xxx.xx:443: i/o timeout
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_proxy environment variable is correctly set. Else, check your network connection.
Is it expected that the above command does not re-use existing connections. However, I did notice that something like cf orgs does. Our current setup has 542 orgs and the above commands seems to close TCP connection on every subsequent request
REQUEST: [2018-02-18T07:08:46Z]
GET /v2/service_brokers?q=name%3Aservice-fabrik-broker HTTP/1.1^M
Host: api.cf.stagingazure.hanavlab.ondemand.com^M
Accept: application/json^M
Authorization: [PRIVATE DATA HIDDEN]
Connection: close^M
Content-Type: application/json^M
User-Agent: go-cli 6.34.1+bbdf81482.2018-01-17 / linux^M
^M

RESPONSE: [2018-02-18T07:08:46Z]
HTTP/1.1 200 OK^M
Connection: close
Content-Length: 552^M
Content-Type: application/json;charset=utf-8^M

.........and so on

What you expected to occur
Command to pass without error
CLI Version
cf version 6.34.1+bbdf81482.2018-01-17
CC API Endpoint Version
api endpoint:   https://api.cf.stagingazure.xxx.com
api version:    2.101.0
CF Trace
(Please find below a trimmed down version of CF_TRACE output)
REQUEST: [2018-02-18T07:08:46Z]
POST /oauth/token HTTP/1.1
Host: login.cf.stagingazure.xxx.com
Accept: application/json
--
RESPONSE: [2018-02-18T07:08:46Z]
HTTP/1.1 200 OK
Connection: close
Transfer-Encoding: chunked
--
REQUEST: [2018-02-18T07:08:46Z]
GET /v2/service_brokers?q=name%3Aservice-fabrik-broker HTTP/1.1
Host: api.cf.stagingazure.xxx.com
Accept: application/json
--
RESPONSE: [2018-02-18T07:08:46Z]
HTTP/1.1 200 OK
Connection: close
Content-Length: 552
--
REQUEST: [2018-02-18T07:08:46Z]
GET /v2/services?q=service_broker_guid%3A73062aa6-9cd7-48fd-8d7f-5385904d0051 HTTP/1.1
Host: api.cf.stagingazure.xxx.com
Accept: application/json
--
RESPONSE: [2018-02-18T07:08:46Z]
HTTP/1.1 200 OK
Connection: close
Content-Length: 8282
--
REQUEST: [2018-02-18T07:08:46Z]
GET /v2/service_plans?q=service_guid+IN+2302e76f-4186-43d5-8a47-b8594939c9d4%2Cae3e86df-f60d-45ba-9ed9-a09d7814c493%2Cce6a0192-bf07-481d-adfb-710a1663781c%2Cfc36bcae-141c-4ed7-b8dd-b384d9b5d996%2C58ebdac0-276b-42dc-90df-711b30283f1e%2C6dd
4c56c-cb11-434f-a660-292fa78e8799 HTTP/1.1
Host: api.cf.stagingazure.xxx.com
Accept: application/json
--
RESPONSE: [2018-02-18T07:08:46Z]
HTTP/1.1 200 OK
Connection: close
Content-Length: 76692
--
REQUEST: [2018-02-18T07:08:46Z]
GET /v2/service_plans?order-direction=asc&page=2&q=service_guid%20IN%202302e76f-4186-43d5-8a47-b8594939c9d4,ae3e86df-f60d-45ba-9ed9-a09d7814c493,ce6a0192-bf07-481d-adfb-710a1663781c,fc36bcae-141c-4ed7-b8dd-b384d9b5d996,58ebdac0-276b-42dc-
90df-711b30283f1e,6dd4c56c-cb11-434f-a660-292fa78e8799&results-per-page=50 HTTP/1.1
Host: api.cf.stagingazure.xxx.com
Accept: application/json

... and so on

Platform & Shell Details
Ubuntu 16.04.3 LTS
Any other relevant information
Concourse VM from which this command is executed, is behind Azure SNAT, which by default exposes 160 ports as a soft limit. So, current understanding is that with large number of CF orgs, commands like cf service-access -b <broker_name> result in SNAT port exhaustion and the script which includes similar commands fail.

We'll refactor this command later, and that will resolve this issue. Closing.

@jbpivotal Thanks for your comments. Can you please let me know if not re-using connections was intentional for such commands?
Asking because this is currently blocking us and we might have to work on an external utility that interacts directly with the CC with connection re-use

@jbpivotal Possible for you to give a rough estimate for the availability of the refactored commands ?

@akskap Thanks for letting me know this issue is blocking you. I've moved it up higher in priority so we'll likely pick it up in the next week or two. You can view the story here: https://www.pivotaltracker.com/story/show/126256853

@akskap We spent some time investigating a refactor of the serivce-access command, as we believe that will resolve your issue. Unfortunately, it looks like a decent amount of work that would fully occupy a pair of engineers for at least 3 weeks or so. (We estimate based on complexity, not time, and we identified a 5-point story, a 3-point story, and another not-yet-pointed story.) As a result, I'm keeping this work in the backlog but moving it below some other features that we believe have wider demand relative to the development time cost.

Hi @akskap following up on @jbpivotal's message - please let us if you have any information about the impact of this work and/or timing considerations we should know about. This would help us prioritise work accordingly. Thanks again.


could not load file or assembly Microsoft.EntityFrameworkCore.Hosting.Abstractions

Describe what is not working as expected.
I have a class library project targeting .NET Core 2.1 with Entity Framework Core v2.1.4 installed. It contains all the domain logic. Whenever I use EF Core Power Tools -> Migrations Tool, I'm having this exception:
Message: System.IO.FileNotFoundException : Could not load file or assembly 'Microsoft.EntityFrameworkCore.Hosting.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

@nhn110112 This should be reported to the EF Core Power Tools--see https://github.com/ErikEJ/EFCorePowerTools


New user data

Please describe the new feature you would like to see
It would be nice to have new users enter their all workouts page with some default data to help with the UX of understanding how the app works

Create a new workout for each user on sign up called "My fist workout"
include 4 basic exercises that every person would know

I think this will leave users a little less confused on app entry about what they are supposed to do

This might have to be done at the API level to keep the client from becoming to slow on signup


ply request

hello,
Thank you for your great work.
Is it possible to capture a ply file or may be a dph (revopoint default format) file with this useful software.
Thank you.

No, this project doesn't support that.
I haven't explored it myself, but it looks like Revopoint provides some open source code now.
Some discussion here (towards the end):
https://github.com/frostworx/revopoint-pop2-linux-info/issues/1
The Revopoint repository:
https://github.com/Revopoint/3DViewer

Thank you for your response.
3Dviewer software requires a remote activate for 1 month trial
They request $2000 per device after the trial period
So their "sdk" is crap.


Fix path to default kata so new users can get started on tddbin.com

tddbin.com is showing a "// Default kata not found (status 404)" error to
first-time users (with empty local storage), most likely because the
file was moved to a different folder in this commit in tddbin/katas:
https://github.com/tddbin/katas/commit/40df1b4ee3e951b9216fcd5915cdc66ffe64bfa1
Note this is an untested change as I'm short on time and it depends on the
server from another repository which I don't know how to run.

thanks a lot

woohoo already deployed 🎉

thanks a lot for making the fix and merge easy.
thats the PRs I love
On Sun, Mar 10, 2019, 15:49 Christoph Neuroth<EMAIL_ADDRESS>wrote:

woohoo already deployed 🎉
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/tddbin/tddbin-frontend/pull/52#issuecomment-471312808,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG7E98_O5vFJPYuZC05DqxOQMSHkqjpks5vVRtngaJpZM4bnJ9B
.


use u8 for field array offset instead of usize

r? @therealprof
(rust-highfive has picked a reviewer for you, use r? to override)

cc @adamgreig

Is the idea that field arrays can never have >255 elements because registers are only 32 (or maybe 64) bits wide, so there's no point using a large usize when a u8 will always work?

I'd also like to see what the concrete benefits are. Switching from usize to something else might require a bit of casting during use which is annoying (and error prone).

Is the idea that field arrays can never have >255 elements because registers are only 32 (or maybe 64) bits wide, so there's no point using a large usize when a u8 will always work?

Yes, I forget this when implemented. As field arrays are not really arrays, I don't think someone will use big usize accessing them.

I'd also like to see what the concrete benefits are. Switching from usize to something else might require a bit of casting during use which is annoying (and error prone).

It's only used in bit shifting arithmetic, not as a slice index; this PR changes the generated code from something like:
            pub unsafe fn pin(&self, n: usize) -> PIN_R {
                PIN_R::new(((self.bits >> n) & 0x01) != 0)
            }

to something like:
            pub unsafe fn pin(&self, n: u8) -> PIN_R {
                PIN_R::new(((self.bits >> n) & 0x01) != 0)
            }

where in this case self.bits is 32-bit (or in general is the register width).
@burrbull, do any of the tests in the CI actually use field arrays?

It's only used in bit shifting arithmetic, not as a slice index; this PR changes the generated code from something like:

Fair enough, but in that case it's also unlikely to provide any benefit.

We haven't actually shipped an svd2rust since field array support was added in #400, so I see this as more cleaning up the API for it before release. But, yes, I don't know if there's any benefit to swapping to u8 for this. If anything maybe it should use the same type as the registers to make it line up with self.pins etc?

do any of the tests in the CI actually use field arrays?

risk-v k210 should use them, but I'm not sure is test contain actual version of SVD.


SourceDeployCommand return TypeError instead of Missing Metadata File

Summary
When using the last version of the cli (sfdx-cli/7.74.1-32db2396ed linux-x64 node-v12.18.3) I have the error
{
  "status": 1,
  "name": "TypeError",
  "message": "Cannot read property 'outboundFiles' of undefined",
  "exitCode": 1,
  "commandName": "SourceDeployCommand",

see sfdx_result.zip for full stack
In the previous version (rollback with sfdx plugins:install<EMAIL_ADDRESS>), I have this error:
{
  "status": 1,
  "name": "Missing Metadata File",
  "message": "Expected metadata file with '-meta.xml' extension at path: /home/runner/work/Salesforce/Salesforce/force-app/main/default/objectTranslations/Quote-en_US/Quote-en_US.objectTranslation-meta.xml",
  "exitCode": 1,
  "commandName": "SourceDeployCommand",

see sfdx_result (2).zip for full stack
the previous version was very more usefull to debug a deploy.
Steps To Reproduce:
Deploy a directory with a missing xml file
Expected result
A precise error with the path of the expected file
Actual result
An internal error is throw

Thanks for reporting.  This has been fixed with cli 7.76.1.  Apologies for the regression!


Port to event-listener v5.0.0

cc smol-rs/event-listener#105

MIRI deadlock looks like a false positive to me, but let me investigate it first.

I've noticed that the choice of -Zmiri-seed seed can affect whether some of the tests pass or fail, so it's important to try several.


(#8314) (#8319) (#8374) Fix as by the suggested patches

Was pull request #55 before, but that was not on a topic branch so i had to cancel it :-(

I cleaned up the commits and added a little testing. Merged in a52eb6ecaa8dca06639c60f05f3204eefdb4d482


Add VM-Image management containers

Signed-off-by: Chris Evich<EMAIL_ADDRESS>

@edsantiago when you have a moment PTAL, there's only a few new changes/files, the rest are a nearly identical port from the containers/podman repo.  Specifically from contrib/imgts and contrib/imgprune.  New changes/files here are:

.cirrus.yml
Makefile
ci/make_container_images.sh
one readme
other readme

P.S. I tested the imgts container in the podman PR, where I left imgprune disabled for now while I ponder a safer solution.

Thanks for taking a peek @edsantiago I'll make those few fixes and re-run the build just to make sure it passes.  Otherwise I've already got the image-suffix c6106205175152640 referenced in other PRs.  No matter though, it seems we'll be needing fresh images in podman/buildah anyway to address the fchmodat2 thing.

fixed & force-pushed.  @edsantiago if/when you're ready drop an approving review and mergify will merge this.  Thanks again.


Correct buffer size to fix memory corruption

The analysis in eclipse/openj9#5696 shows that there
is a out of bounds access that is fixed by increasing
the buffer size by 8.  Validated by having the VM
increase all unsafe allocates by 8 and the problem
no longer occurs.
fixes: #79
Signed-off-by: Dan Heidinga<EMAIL_ADDRESS>

Great catch! The VARIANT struct is different sizes for 32 bit and 64 bit builds though, so I think the buffer sized used should be dependent on whether the process is 32 or 64 bits.

I can update the PR but am having some trouble finding the definition of VARIANT to double check the size on 32 vs 64.  Any pointers would be appreciated

Here you go:
https://docs.microsoft.com/en-gb/windows/desktop/api/oaidl/ns-oaidl-tagvariant
There are two pointers in the inner struct in the union (pvRecord and pRecInfo) which I think account for the 8 bytes difference (4 bytes per pointer difference).
thanks!
Tony

Thanks @tonyroberts.  I've updated the PR to check whether the system is 32 or 64 bit.

"os.arch" is probably more portable to other JVMs than sun.arch.data.model (see https://docs.oracle.com/javase/6/docs/api/java/lang/System.html#getProperties()), but other than that looks good to me.

Would it make sense to move the variantSize call out of the constructor and into a static? In some workloads variants get created a lot, so makes sense to do as little as possible per instance, and I don't think the arch will change mid execution.

I've switched to os.arch and moved the variantSize check into a static final variable.

Is there anything I need to do to help get this merged?

@DanHeidinga I'm not sure what the current state of this repo is to be honest. It doesn't seem to have much activity, and my PRs have not been merged or commented on.
I'm maintaining another fork here https://github.com/exceljava/com4j with bug fixes that haven't yet been merged into this repo (including yours).


#1 Added integration with Swagger web console.

Two issues with this solution:

I haven't given much direction on the packaging of this initially. I just updated the issue with this extra information... In short - the servlet and its resources should be in a separate Bootique module.

Referencing resources via "jar:file:" will probably work most of the time, but looks a bit dirty.. Is there a way to refer to the resource base in a more portable way that does not assume any specific packaging?

Please take a look on changes I made according to your comment. Now resources are getting from classLoader.

The PR is applied. A few notes on the PR contents (I addressed most of them already, with code committed to master) :

bootique-swagger-console should not have a dependency on bootique-swagger. Only on bootique-jetty. It accesses swagger.json via REST, so there's no compile dependency.
The tests under bootique-swagger-console were copy/pasted from bootique-swagger. I removed those that are irrelevant in the context of the console.
Swagger-UI JS/CSS/HTML for some reason was present in src/test/resources. I removed it from there.
Removed direct references to javax.validation. While the validation jar comes as a transitive dependency from Jersey, in the Bootique code we should avoid relying on random third-party libs (each such dependency will need to be discussed and justified).

Additionally I did the following:

renamed bootique-swagger-console to bootique-swagger-ui to better match Swagger's own naming.
Wrote better docs (README.md).


how run multi saga in multi modules

I use widgets
file module.js

file index.js

file foo.js

file bar.js

run error

how fix run multi

In module.js you import rootSaga by name, but export as default.
Delete default word in index.js

thanks, worked for me


Fix README styling

The README is currently broken in some parts due to semi-recent changes to GitHub's Markdown parser. This should fix those issues (and add some code styling for improved readability).

This looks great, was meaning to update for those changes for a while, but never got around to it, thanks so much!
I'll end up merging this (and the other PRs) to the develop branch first so I can create a develop -> master PR that Travis will run against.
Since we use ENV. vars to set the API key for the e2e tests, travis won't run against those unless the PR is in the same repo, so a few extra hoops to jump through to make sure everything gets run through tests before merging to master.  This is great, you shouldn't have to do anything 👍


[WIP] Migrate from wasmi to wasmer

Fix #4.
This PR replaces wasmi by Wasmer through the wasmer-runtime-c-api, and thus we will be able to use Cranelift and soon LLVM for the backend.

Early results with the n-body benchmark.
Note: I'm testing with PHP 7.3.2.


[FEATURE] Create GSM List API

Feature Description
The Gateway Status Map (GSM) refers to the gateway_status_map table, which stores connector-specific behavior for a given flow, sub-flow, code, and message.

Currently, we have GSM CRUD APIs to create, retrieve, update, and delete GSM records. However, there's no existing method to view all GSM records. To address this, we propose implementing a new API that retrieves all GSM records based on filters such as connector and flow.
Possible Implementation
Create a new GSM List API (/gsm/list) with a GET method, which retrieves all the GSM records. Filters, such as connector and flow, can be applied.

Hi @sai-harsha-vardhan !
I want to help with this. Is it required to implement pagination for this endpoint?

Hi @nikpivkin, Thanks for your interest! Pagination isn't an immediate requirement, so we can proceed without it. I've assigned this to you; please use this thread or our Discord channel if you have any queries.

Hey @nikpivkin, If you are stuck / need some help. Please feel free to ask queries here / our discord channel. Thanks!


Add a note about gobpf in godoc

Cilium has own bpf package:

https://godoc.org/github.com/cilium/cilium/pkg/bpf

There's also gobpf library from iovisor project:

https://godoc.org/github.com/iovisor/gobpf/bcc

Both seem to be able to work with maps. The latter can also load programs, which the former cannot.
It would be nice to have a paragraph or two about relation of these two packages in Cilium's godoc.

There's also https://github.com/newtools/ebpf.


Redirect after log out doesn't work anymore

I'm trying to use IdentityServer4 in a project much like the Quickstart6_AspNetIdentity sample. I've just updated the version of "Microsoft.AspNetCore.Authentication.OpenIdConnect" from "1.0.0" to "1.1.0" in the MvcClient and now after logout the redirect to the MvcClient doesn't work anymore. As far as I can tell, the "logoutId" parameter of AccountController's Logout method is null (and is missing in the query string).

That was  a change in 1.1 of the OIDC MW from Microsoft. You must now use ~/signout-callback-oidc as the post logout redirect URI.

Thanks! It works.


suggest new default config path

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Bernhard Riegler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Bernhard Riegler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Callback not Calling

When called StartLocator the callback method aren't been called... The service logs "Locator service is already running D/plugin  ( 3487): sendLocationEvent {callback=7376271144, location={altitude=0.0, heading=0.0, latitude=-26.9883467, accuracy=3.075, speed_accuracy=0.0, time=1.617131050765E12, is_mocked=false, speed=0.0, `longitude=-48.6360767}}"`
It only happens sometimes...
I need it working because the positions is sent to my server.

Hi @marcusmvfa can you show me how did you fix this issue?

Hello @surveshoeb, I'm sorry but i didn't remember it was fixed since has passed almost an year


does not contain any version-numbered child folders

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/create
Operating System: linux
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
Fedora 37 (Workstation Edition)
Installed the .NET SDK or the .NET Runtime with a script.
While following steps from Dotnet Microsoft site, when I get to the section to run dotnet new blazorserver -o BlazorApp --no-https -f net7.0 I get a error message in terminal that states:
A fatal error occurred, the folder [/usr/lib64/dotnet/host/fxr] does not contain any version-numbered child folders

Can you dotnet--info and share the results with us or do you get the same error?
Do you have any other versions installed?

$ dotnet--info bash: dotnet--info: command not found...

Can you dotnet--info and share the results with us or do you get the same error?
Do you have any other versions installed?

$ dotnet--info bash: dotnet--info: command not found...
This is what I get.  I've never installed dotnet before. First time using the script info from the website.

@leecow can you help here? @omajid I've seen you help folks with similar issues before. Any suggestions here?

.NET is available natively through the Fedora package archives. If I'm following you explanation, .NET probably isn't installed so I would start with dnf install dotnet-sdk-7.0.
If needed, there are various troubleshooting scenarios documented here.

dnf install dotnet-sdk-7.0.

This seemed to resolve my issue.  Thank You.


SHA display touchups

CATEGORY
Choose one

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
The SHA displayed in the user menu was overhwelmingly long. This now shows only the last 8 characters for reference (1 more than github!). It also adds a colon after "Version" for consistency, and a little more line height and bottom padding on the fine print so it's less claustrophobic.
Open TODO: make the fine print act like a little menu item, and copy the full SHA on click.
Open TODO?: move the "admin user" tooltip seen in the screenshot into the menu. Not sure if we need the tooltip. Thoughts, anyone?

Is there a security issue here? Assuming we'll have a list of CVE out, it'd be pretty easy for someone to get a list of active vulnerabilities, not that it'd be much harder to test for all CVE.
I know for things like Apache (web server) or nginx, best practice is to keep that obscure to make it harder for black hats to scan the web looking for particular vulnerabilities.
Two ways to potentially mitigate: only allow for admin, or put behind a feature flag.
@craig-rueda what dyou think?

Depends on context - I'd prefer if this were configurable - i.e. have a config flag that allows end users to toggle the display of SHAs at all. I see that this change simply shortens said string, so toggling it is out of scope for this PR.

Oh right, about SHA length, 8 is a little low:
https://stackoverflow.com/questions/18134627/how-much-of-a-git-sha-is-generally-considered-necessary-to-uniquely-identify-a

Codecov Report

Merging #8614 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #8614   +/-   ##
=======================================
  Coverage   65.77%   65.77%
=======================================
  Files         482      482
  Lines       23794    23794
  Branches     2587     2587
=======================================
  Hits        15651    15651
  Misses       7974     7974
  Partials      169      169

Impacted Files
Coverage Δ

superset/config.py
89.86% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e490414...501af8c. Read the comment docs.

Oh right, about SHA length, 8 is a little low:
https://stackoverflow.com/questions/18134627/how-much-of-a-git-sha-is-generally-considered-necessary-to-uniquely-identify-a

Haha... it was exactly that article that led me to believe 8 was enough! I just upped it to 10, but let me know if you think more would be useful.


Adding NLA's regions

So far, nodes for all 6 regions and relationships for the Industrial District have been added.
Is it 🆗 like this?
TO-DO:

[x] Add nodes.

[x] Add relationships for Industrial District.

[x] Add relationships for Administrative District.

[x] Add relationships for Residential District.

[x] Add relationships for Commercial District.

[x] Add relationship for BLADE Barracks.

[x] Add relationships for Ma-non Ship.

Ready for merge :shipit:


tf.summary.FileWriter crashes with AlreadyExistsError

We have a cluster with ~20 GPUs that we often use to train multiple networks in parallel, and we use tf.summary.Filewriter to keep track of the networks' progress. However, some jobs are crashing when they attempt to create their FileWriters with the following stack trace:
[...]
  File "/ubc/cs/research/tracking-raid/julm/eyescream/tensorflow/pose_estimation/linear_model.py", line 141, in __init__
    self.train_writer = tf.summary.FileWriter( os.path.join(summaries_dir, 'train' ))
  File "/ubc/cs/research/tracking-raid/julm/anaconda/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/summary/writer/writer.py", line 308, in __init__
    event_writer = EventFileWriter(logdir, max_queue, flush_secs)
  File "/ubc/cs/research/tracking-raid/julm/anaconda/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/summary/writer/event_file_writer.py", line 69, in __init__
    gfile.MakeDirs(self._logdir)
  File "/ubc/cs/research/tracking-raid/julm/anaconda/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/lib/io/file_io.py", line 299, in recursive_create_dir
    pywrap_tensorflow.RecursivelyCreateDir(compat.as_bytes(dirname), status)
  File "/ubc/cs/research/tracking-raid/julm/anaconda/envs/tensorflow/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/ubc/cs/research/tracking-raid/julm/anaconda/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/framework/errors_impl.py", line 469, in raise_exception_on_not_ok_status
    pywrap_tensorflow.TF_GetCode(status))
tensorflow.python.framework.errors_impl.AlreadyExistsError: /global/scratch/julm/3d_experiments

I am writing the Filewriters' progress under /global/scratch/julm/3d_experiments/, and creating multiple subdirectories depending on the hyperparameters that each network is using.
The error seems to suggest that the FileWriter is trying to create the directory /global/scratch/julm/3d_experiments/ and crashing because the directory already exists. Moreover, only around 1 in 5 jobs crashes with this error.
Do you know if I could somehow ignore this error? I don't think the fact that the directory exists should trigger an error for the user.
Our cluster runs under OpenSUSE 42.2.

I think you have a race condition. If you start /global/scratch/julm/3d_experiments/ before starting any experiments, does it create any errors. What happens otherwise is the first process looks and doesn't see it and then between the time it looked somebody else looked and created it.

I also get this race condition. The cluster has Red Hat Enterprise Linux 7 and Slurm job scheduler. Using TF 0.12. Creating the directory before submitting the job fixes the problem. But, handling the race condition within FileWriter might be beneficial?

Running
os.system('mkdir -p {}'.format( summaries_directory ))

does get rid of the race condition -- or, rather, let's linux handle the race condition, and that fixes my particular problem.
I agree with @aselle that it'd be super nice to have TF handle this internally though.

@una-dinosauria, it's unlikely that this will be done by us in the short term or long term, but feel free to contribute a PR to TensorFlow. Thanks!

@aselle Thanks! I'd love to contribute to TF, and this sounds like it has a fairly straightforward fix.
It's unlikely that I'll find the time to do it before mid-March though -- I guess we should keep this open just to track the issue and as a reference for others who might run into this problem.

Closing due to lack of recent activity. Please reopen and update the issue if you submit a PR for the change. Thanks!


Retry policy: parse datetime value for Retry-After header

To be accurate, the Retry-After header is EITHER seconds, or a DateTime. So we need to write a parser for that (and handle the case when parsing int seconds fails).
More info:

Retry-After header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After
HTTP Date format: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Date
Parsing the date: https://en.cppreference.com/w/cpp/locale/time_get
Get system datetime: https://en.cppreference.com/w/cpp/chrono/system_clock/now
Subtract datetimes to get duration: https://en.cppreference.com/w/cpp/chrono/time_point/operator_arith2

Azure services do not return datetime in retry-after headers, so no need to implement that. However, if we ever need to - DateTime now does parsing pretty well, and the biggest amount of work is ready, now it ll comes down to use DateTime class to get the date instead of seconds/milliseconds.


unpin gast dependency for pip_package

Commit c762c4501ca017994c1fa5554c3c8e47b7c80b66 noted that "I also know that gast 0.5.2 breaks one of our tests" and committed "gast versions above 0.4.0 are incompatible with some of TF's tests."
In #56244, it was suggested to raise a PR to remove the cap. In view of the above-mentioned constraints, I've excluded everything after 0.4.0 up to 0.5.2; note that 0.5.0 directly followed 0.4.0, see https://github.com/serge-sans-paille/gast/tags

Fixed some missing = in !=

I will be gone for a week (due to 4th of July) but will check again when I'm back (and probably earlier on the github side)

I can't really do something about the failing linter check, the line for excluding protobuf versions is pre-existing, and probably needs to be that long anyway.
I also cannot see what's failing with the Internal CI build. Other than that, everything looks green. 🥳

This worked! 🎉
Thank you very much for pushing this through!

Thanks for merging! :)


Atoms look like strings in answers

Currently, when I post X = "abc", I get, as expected:

{
  "result": "success",
  "answer": {
    "X": "abc"
  },
  "output": ""
}

However, when I post X = abc, I also get:

{
  "result": "success",
  "answer": {
    "X": "abc"
  },
  "output": ""
}

even though "abc" and abc are not the same term.

I updated the types to disambiguate them.
?- X = foo, Y = "bar".

{
  "result": "success",
  "answer": {
    "X": {
      "functor": "foo"
    },
    "Y": "bar"
  },
  "output": ""
}

New types:
/*
	Default encoding (in order of priority):
	string(X) 	→ string
	is_list(X)	→ List
	atom(X) 	→ Atom
	compound(X)     → Compound
	number(X) 	→ number
	var(X) 		→ Variable
*/
type Term = Atom | Compound | Variable | List | string | number;

interface Atom {
	functor: string;
}

interface Compound {
	functor: string;
	args: Term[];
}

interface Variable {
	var: string;   // variable name
	attr?: Term[]; // residual goals
}

type List = Term[];

Also added an option parameter to the query methods to change how encoding works for strings and atoms, for those who want to tweak it.
// to get the previous behavior:
pl.query(`X = foo.`, {encode: {atoms: "string"}};

Closing as I think it's done, but please feel free to reopen this or any other issue in the future. I appreciate the help.


libva dependency wayland is not in the repo

Since the last update, libva tries to pull in wayland which is not in the repo and as I understand the guidestones must not be in the official repo.

Noticed this a little too late! Accidentally copied over my personal build, somehow. Fixed in 52edae262d5213cfab07a9928c502428d4be2af4


Improvement: Build runtime by first building wheels then installing them

What is this for? Is this still needed?


Rename Quit mode keymaps

Is your feature request related to a problem? Please describe.
Hi, I would like to request a feature to have different quit mapping for rename when I'm in different modes. For example, I would love to quit the rename with "" or "q" only when I'm in normal mode; but I would like to be able to quit, when in other mode with "".
Describe the solution you'd like
Maybe a table on the config would be nice solution:
{
  rename = {
    in_select = false,
    keys = {
      quit = {  -- if a string, then applies to {"n", "i", "x"}
            {"n"} = "q",
            {"i", "v"} = "<C-K>",
          },
        },
    },
}

I was able to do this with autocommands, so it's not really neccesary.


Integrate BioNLPProcessor with Odinson

This PR adds the BioNLPProcessor as one of the processor choices used for annotation. See https://github.com/clulab/reach/issues/802.
WARNING: review for changing dependencies (this only works if Reach is available as a dependency) and changing default behavior (for illustrative purposes I changed application.conf to choose the BioNLPProcessor). Further changes may be needed to mitigate any unintended consequences of these.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, @bgyori.  I suspect that we might not want to incorporate this into the main branch, but it would be very nice to have the changes around for documentation or to serve as an example.  Maybe we here can incorporate them into a branch for safe keeping.  What does @myedibleenso who knows both reach and odinson think?


[Release-1.24] - Add warning that containerd's config.toml is auto generated

Backport fix for Add warning that containerd's config.toml is auto generated

#7056

Validated on master branch using commit id
Environment Details
Infrastructure
Cloud EC2 instance
Node(s) CPU architecture, OS, and Version:
Ubuntu 20.04
Cluster Configuration:
Single node
Steps to reproduce the issue  and validate the fix

Install k3s
Check config.toml for warning on top of file

Replication Results:
ubuntu@ip-172-31-8-113:~$ k3s -v
k3s version v1.24.11+k3s1 (c14436a9)
go version go1.19.6
ubuntu@ip-172-31-8-113:~$ sudo cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml |head -5

version = 2

[plugins."io.containerd.internal.v1.opt"]
  path = "/var/lib/rancher/k3s/agent/containerd"
ubuntu@ip-172-31-8-113:~$

Validation Results:
ubuntu@ip-172-31-6-40:~$ k3s -v
k3s version v1.24.11+k3s-7fee87d9 (7fee87d9)
go version go1.19.6
ubuntu@ip-172-31-6-40:~$ sudo cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml |head -5

# File generated by k3s. DO NOT EDIT. Use config.toml.tmpl instead.
version = 2

[plugins."io.containerd.internal.v1.opt"]
ubuntu@ip-172-31-6-40:~$


Provide additonal config options

At least text field to provide additional FullCalendar options as JSON

See fcOptions at https://github.com/mbarde/volto-fullcalendar-block/blob/main/src/components/manage/Blocks/FullCalendar/View.jsx#L74


"no matching host key type found. Their offer: ssh-rsa" How do I solve this problem?

hello. I always appreciate your code.
Unfortunately the server I need to upload to via sftp is using the ssh-rsa keytype.
So, the error message "no matching host key type found. Their offer: ssh-rsa" is displayed. The same thing happens when I access it from my PC terminal.
To solve this, I need to explicitly write "-oHostKeyAlgorithms=+ssh-rsa" in the connection options. How can I write it using which item of the input parameter?
Reply please.

I checked it in the readme. I solved it with ssh-options. thank you


Implement JSON endpoint for homepage form

← #4606 — #4613 →
Todo

[x] post form to /index.spt

[x] charge card
[x] if successful, send receipt link
[x] show result in browser → #4613

[x] validate form
[ ] change base to new-homepage

From slack (edit not picked up in archive):

Alright, if we want any chance of getting this out by Sunday, then I think what we do is:

Merge and deploy https://github.com/gratipay/gratipay.com/pull/4548.
Charge immediately and mail a receipt. No verification step whatsoever.
We only allow anon to fill in the form. Auth redirects to /browse/projects(!).

Todo here simplified per above.

Okay! Ready for review here. Line ∆ is high due to fixtures.

Hmm ... interesting Travis failure in test_history.py -k iter_payday_events ... unrelated file. Not present on master.

But it does fail in isolation on this branch.

Failure seemingly introduced on bc37e3e18e39f97426a1de452ada60f466ffadd9. 🤔

Or not? 😞

Alright, I left the body in there. If this is the only test that's failing then maybe we should go back to that after all?

Referring to:
https://github.com/gratipay/gratipay.com/blob/bfa6e0ba9dc71c55cb76fef93351319c9f7d977d/gratipay/testing/vcr.py#L42

We took that out back in #2588.

Alright, didn't work instantly, so taking body back out of match and sticking with the two-class hack.

Rebased, was 982f75cb214cab1a9c227a1fdbcf7958ea7b2bc8.

Sup Travis?

lol cassettes 😆

Rerecorded, was 1f10b7be770eb5eaca43bcaaeb58cb4fe7dc31db.

Merged under #4613.

🚨  Self-merge license 🚨


Error when saving a content item (new or edit) with content permissions part

Since updating to Orchard 1.9 (and 1.9.1), whenever we create or edit a content item that contains the content permissions part, if we do not set permissions on the item, we received the following error:
System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Where[TSource](IEnumerable`1 source, Func`2 predicate)
   at Orchard.ContentPermissions.ViewModels.ContentPermissionsPartViewModel.SerializePermissions(IEnumerable`1 roleEntries)
   at Orchard.ContentPermissions.Drivers.ContentPermissionsPartDriver.Editor(ContentPermissionsPart part, IUpdateModel updater, Object shapeHelper)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute4[T0,T1,T2,T3,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3)
   at Orchard.ContentManagement.Drivers.ContentPartDriver`1.Orchard.ContentManagement.Drivers.IContentPartDriver.UpdateEditor(UpdateEditorContext context) in c:\TFS\NFLPA.com 2014\Dev-1.9\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 90
   at Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCoordinator.<>c__DisplayClass10.<UpdateEditor>b__f(IContentPartDriver driver) in c:\TFS\NFLPA.com 2014\Dev-1.9\src\Orchard\ContentManagement\Drivers\Coordinators\ContentPartDriverCoordinator.cs:line 63
   at Orchard.InvokeExtensions.Invoke[TEvents](IEnumerable`1 events, Action`1 dispatch, ILogger logger) in c:\TFS\NFLPA.com 2014\Dev-1.9\src\Orchard\InvokeExtensions.cs:line 17

Has anyone else experienced this issue?

Figured out why the error is happening (basically, we are overriding the default content permissions view in our admin theme, but after saving the item and reloading the view, it fails to load the content permissions view that we created.  Going to try to figure out why it's failing to load on commit/save (post)


Title and input alignment to be fixed on HR reporting page

Describe the task
Under the HR module, while we go to the reports section, there is a misalignment between the input fields and the Analytics heading, we want them to be on the same line.

The task is done pleas erefer screenshot


Error when start test client

hey i got the following error message: can anyone help?
Building and running client in debug mode.
Compiling prost-derive v0.5.0
Compiling which v2.0.1
Compiling protoc-grpcio v0.3.1
Compiling failure_ext v0.1.0 (/root/Desktop/test/libra/libra/common/failure_ext)
Compiling ed25519-dalek v1.0.0-pre.1
Compiling threshold_crypto v0.3.1
Compiling codespan v0.1.3
Compiling snow v0.5.2
Compiling network v0.1.0 (/root/Desktop/test/libra/libra/network)
error: failed to run custom build command for network v0.1.0 (/root/Desktop/test/libra/libra/network)
Caused by:
process didn't exit successfully: /root/Desktop/test/libra/libra/target/debug/build/network-3bce66de4ba49a2b/build-script-build (exit code: 101)
--- stdout
cargo:rerun-if-changed=src/proto/network.proto
cargo:rerun-if-changed=src/proto/mempool.proto
cargo:rerun-if-changed=src/proto/consensus.proto
--- stderr
network.proto:4:10: Unrecognized syntax identifier "proto3".  This parser only recognizes "proto2".
thread 'main' panicked at 'protoc: Custom { kind: Other, error: StringError("protoc ("protoc" "-I../types/src/proto" "-Isrc/proto" "--descriptor_set_out=/tmp/protoc-rustXMd2Vi/descriptor.pbbin" "--include_imports" "src/proto/network.proto" "src/proto/mempool.proto" "src/proto/consensus.proto") exited with non-zero exit code") }', src/libcore/result.rs:999:5
note: Run with RUST_BACKTRACE=1 environment variable to display a backtrace.
warning: build failed, waiting for other jobs to finish...
error: build failed

network.proto:4:10: Unrecognized syntax identifier "proto3". This parser only recognizes "proto2".

It seems your protoc version is too old. Could you please try to remove the old version and install the latest one?
You can double check by running protoc --version, 3.6.0 or above is required.

i tried  protoc --version  -> libprotoc 3.7.0
still the same problem.
i downloaded the protoc from github und move it to /usr/bin/protoc
is that way correct?
thanks

@yoshi721 what OS are you running?

I got the same issue with Mac OS X 10.14.5 (18F132).
It seems that I need to uninstall proto2 and re-install proto3. Reference: https://github.com/linkerd/linkerd/issues/1118
I'll post here if this can be fixed with the above reference.

The issue is that the default version of protobuf in brew is 2.x: https://github.com/libra/libra/blob/master/scripts/dev_setup.sh#L141, while we need a 3.x to make things working.
If you get the same issue, let's uninstall protobuf 2.x and install a protobuf 3.x:
brew uninstall protobuf --force # delete 2.x
brew install<EMAIL_ADDRESS># install 3.x
protoc --version # it should now show libprotoc 3.6.1

Then re-run the scripts (https://developers.libra.org/docs/my-first-transaction) to make Libra working.

@yoshi721 what OS are you running?

NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

@yoshi721 work for me https://medium.com/coinmonks/libra-digitalocean-8083326bb266

@yoshi721 Hi, I have the same problem and I found the solution. You just need to download the protoc (like protoc 3.9.0 from https://github.com/protocolbuffers/protobuf/releases), and copy the include directory to /usr/local.
Just installed protoc 3.6.1 didnt work. I guess installed protoc using brew doesnt copy the include directory to /usr/local, so protoc cannot find them.

I am using Mac OS 10.15.1 ver and do not have an issue with the execution of ./scripts/cli/start_cli_testnet.sh.
have you downloaded the latest one and execute the same?


fix: ensure extradata is 32 bytes or less

the P2P_VERSION was too long due to the triple and exceeded the max allowed length of 32 bytes.
this introduces a new constant specifically for extradata which uses the OS
geth ref: https://github.com/ethereum/go-ethereum/blob/73697529994e14996b7740730481e926d5ec3e40/eth/backend.go#L269-L272

Codecov Report

Merging #2775 (13df270) into main (71581ab) will decrease coverage by 27.89%.
The diff coverage is 54.71%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main    #2775       +/-   ##
===========================================
- Coverage   71.45%   43.56%   -27.89%
===========================================
  Files         504      505        +1
  Lines       65714    65765       +51
===========================================
- Hits        46953    28653    -18300
- Misses      18761    37112    +18351

Flag
Coverage Δ

integration-tests
13.59% <0.00%> (-3.89%)
:arrow_down:

unit-tests
39.27% <54.71%> (-27.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/args/network_args.rs
2.77% <ø> (-12.50%)
:arrow_down:

crates/consensus/beacon/src/beacon_consensus.rs
0.00% <0.00%> (ø)

crates/primitives/src/constants.rs
0.00% <ø> (-100.00%)
:arrow_down:

bin/reth/src/version.rs
30.00% <30.00%> (ø)

bin/reth/src/args/payload_builder_args.rs
40.29% <60.97%> (-28.94%)
:arrow_down:

crates/rpc/rpc-types/src/eth/engine/payload.rs
41.77% <100.00%> (-47.79%)
:arrow_down:

... and 272 files with indirect coverage changes


Remove Secrets from PubSubSource controller. Update Docs.

Updated docs.
In doing this, renamed some fields in the spec that did not need to be named this way.

OK thanks for reviewing everyone. Based on feedback, I have refactored the code to have the controller not communicate to the pub/sub service. Only the receive adapter does. I need to figure out how to delete the subscription still, but for now I would like to get feedback on that aspect and then I will fix tests.
Look at docs/pubsubsource/README.md in particular.

Ready for another look!

/lgtm
We can do the remaining issues in a followup.


mocked CloudWatch does not differentiate metrics when they share the dimension

Hey,
i didn't have the time to dig deeper, but i realized that i had to switch to an older version than 3.1.6 since the following fails with 3.1.6 but does not with 3.1.5 or older, trying to add two metrics with different metric name that share the same dimension and receiving them separately:
@mock_cloudwatch
def test_get_metric_data_for_multiple_metrics_w_same_dimensions():
    utc_now = datetime.now(tz=pytz.utc)
    cloudwatch = boto3.client("cloudwatch", "eu-west-1")
    namespace = "my_namespace/"
    cloudwatch.put_metric_data(
        Namespace=namespace,
        MetricData=[
            {
                "MetricName": "metric1",
                "Dimensions": [{"Name": "Name", "Value": "B"}],
                "Value": 50,
            },
            {
                "MetricName": "metric2",
                "Dimensions": [{"Name": "Name", "Value": "B"}],
                "Value": 25,
                "Unit": "Microseconds",
            }
        ],
    )
    # get_metric_data 1
    response1 = cloudwatch.get_metric_data(
        MetricDataQueries=[
            {
                "Id": "result1",
                "MetricStat": {
                    "Metric": {"Namespace": namespace, "MetricName": "metric1", "Dimensions": [{"Name": "Name", "Value": "B"}],},
                    "Period": 60,
                    "Stat": "Sum",
                },
            },
        ],
        StartTime=utc_now - timedelta(seconds=60),
        EndTime=utc_now + timedelta(seconds=60),
    )
    #
    len(response1["MetricDataResults"]).should.equal(1)

    res1 = response1["MetricDataResults"][0]
    res1["Values"].should.equal([50.0])

    # get_metric_data 2
    response2 = cloudwatch.get_metric_data(
        MetricDataQueries=[
            {
                "Id": "result2",
                "MetricStat": {
                    "Metric": {"Namespace": namespace, "MetricName": "metric2", "Dimensions": [{"Name": "Name", "Value": "B"}],},
                    "Period": 60,
                    "Stat": "Sum",
                },
            },
        ],
        StartTime=utc_now - timedelta(seconds=60),
        EndTime=utc_now + timedelta(seconds=60),
    )
    #
    len(response2["MetricDataResults"]).should.equal(1)

    res2 = response2["MetricDataResults"][0]
    res2["Values"].should.equal([25.0])

So, when checking out 3.1.5 and adding this test to the tests/test_cloudwatch/test_cloudwatch_boto3.py test, it passes.

        It primarily assures that the compared objects are absolute equal ``==``.

        :param what: the expected value
        :param epsilon: a delta to leverage upper-bound floating point permissiveness
        """

        try:
            comparison = DeepComparison(self.obj, what, epsilon).compare()
            error = False
        except AssertionError as e:
            error = e
            comparison = None

        if isinstance(comparison, DeepExplanation):
            error = comparison.get_assertion(self.obj, what)

        if self.negative:
            if error:
                return True

            msg = "%s should differ from %s, but is the same thing"
            raise AssertionError(msg % (safe_repr(self.obj), safe_repr(what)))

        else:
            if not error:
                return True
>           raise error
E           AssertionError: given
E           X = [75.0]
E               and
E           Y = [50.0]
E           X[0] != Y[0]

moto_venv\lib\site-packages\sure\__init__.py:729: AssertionError

During handling of the above exception, another exception occurred:

    @mock_cloudwatch
    def test_get_metric_data_for_multiple_metrics_w_same_dimensions():
        utc_now = datetime.now(tz=pytz.utc)
        cloudwatch = boto3.client("cloudwatch", "eu-west-1")
        namespace = "my_namespace/"
        cloudwatch.put_metric_data(
            Namespace=namespace,
            MetricData=[
                {
                    "MetricName": "metric1",
                    "Dimensions": [{"Name": "Name", "Value": "B"}],
                    "Value": 50,
                },
                {
                    "MetricName": "metric2",
                    "Dimensions": [{"Name": "Name", "Value": "B"}],
                    "Value": 25,
                    "Unit": "Microseconds",
                }
            ],
        )
        # get_metric_data 1
        response1 = cloudwatch.get_metric_data(
            MetricDataQueries=[
                {
                    "Id": "result1",
                    "MetricStat": {
                        "Metric": {"Namespace": namespace, "MetricName": "metric1", "Dimensions": [{"Name": "Name", "Value": "B"}],},
                        "Period": 60,
                        "Stat": "Sum",
                    },
                },
            ],
            StartTime=utc_now - timedelta(seconds=60),
            EndTime=utc_now + timedelta(seconds=60),
        )
        #
        len(response1["MetricDataResults"]).should.equal(1)

        res1 = response1["MetricDataResults"][0]
>       res1["Values"].should.equal([50.0])

tests\test_cloudwatch\test_cloudwatch_boto3.py:1167:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <sure.AssertionBuilder object at 0x000001D5CAFAEFD0>, args = ([50.0],)
kw = {}

    @wraps(func)
    def wrapper(self, *args, **kw):
        try:
            value = func(self, *args, **kw)
        except AssertionError as e:
>           raise AssertionError(e)
E           AssertionError: given
E           X = [75.0]
E               and
E           Y = [50.0]
E           X[0] != Y[0]

moto_venv\lib\site-packages\sure\__init__.py:410: AssertionError
=========================== short test summary info ===========================
FAILED tests/test_cloudwatch/test_cloudwatch_boto3.py::test_get_metric_data_for_multiple_metrics_w_same_dimensions
======================== 1 failed, 41 passed in 4.39s =========================
(moto_venv)

It seems that the mocked client does not really distinguish between different metric names when they share the same dimension and sums the values ("Stat": "Sum") to 75.0 (50.0 + 25.0 from the two pushes) as if they share the same metric name instead of providing the respective metric's value.
If i have the time i may dig deeper into the issue but at least i am able to report it for now.
Thanks in advance for all the effort and great work on moto, really appreciate it.

Cheers!

I had a quick look into the latest code changes from #5041. The PR #5068 fixes this issue according to the provided test.

Thanks again for raising this and immediately fixing it  @tzven0 - much appreciated.


RowSerializer: Safe guard against double types with Decimal schema tags

Description
Spark inferences a PARQUET double column schema type as a DecimalType column when it should be Double. The serializer didn't expect this behavior and this PR adds safeguards to avoid failures.
Testing

[x] Unit, integration tests

+1

Coverage increased (+0.01%) to 33.843% when pulling 5b264abddb5c714238fce8c7ff7899723e831368 on pfcoperez:serializationDecimaSafeguard into 8fcd5d607babbfa44b88f385e5fa3fe796ffbd67 on Stratio:master.


Feature/any

Partial implementation of std::any from C++17 standard.
http://en.cppreference.com/w/cpp/utility/any
The implementation is in the util library as util::any.
Implements a standard-compliant subset of the full interface.

Does not avoid dynamic allocation of small objects.
Does not implement the in_place_type<T> constructors from the standard.
Does not implement the emplace modifier from the standard.
Does not implement the make_any non-member function from the standard.

I have not explicitly implemented std::swap(util::any), because we get it for free with the appropriate move assignment.
However the standard explicitly states that it should be overloaded to call the any::swap member modifier as follows lhs.swap(rhs)
http://en.cppreference.com/w/cpp/utility/any/swap2
So, do I actually have to explicitly overload it?

I also prefer not to have friend functions defined inline inside a class. No strong reason, I just find it easier to read that way.


Installation error

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>preinstall: npx bin-version-check-cli python3 "> =3.7"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Pretty strange. Try with npm install --ignore-scripts=false.

Hmm not sure if that console is on windows or not. If it is @guptaji-13 try to see if python3 is a system or user env var, not sure if it maters but it might. I was able to install it fine on windows 10 with python 3.10.5
Any more details you can give?


Add array support to observableMerge

Feature Request
I would like to be able to pass to observableMerge array of observables.
Currently i have to do this
const observable1 = osevableOf(1);
const observable2 = osevableOf(2);
const observable3 = osevableOf(3);
const allObservables = [observable1, observable2, observable3];
observableMerge(...allObservables)
I would like to make it
a) either possible that way observableMerge(allObservables)
b) OR throw exception that you are not supporting that, because code is compiled but doesn't work.
Thank you.

It works as intended because an array is a valid ObservableInput.

But it misleading that if i pass an array of observables inside observableMerge, it will not work for them
See. If i do this
    const watchEvents: Observable<Event>[] = [];
        watchEvents.push(observableFromEvent(window, 'click'));
        watchEvents.push(observableFromEvent(window, 'keydown'));

    observableMerge(watchEvents)
            .pipe(throttleTime(15000))
            .subscribe(() => {
                console.log('Hi!');
            });

it won't work.
So i have to do in other way
const watchEvents: Observable[] = [];
watchEvents.push(observableFromEvent(window, 'click'));
watchEvents.push(observableFromEvent(window, 'keydown'));
    observableMerge(...watchEvents)
            .pipe(throttleTime(15000))
            .subscribe(() => {
                console.log('Hi!');
            });

That's not obvious, right?

This feature is by design.
If you want to merge an array of observables, use the spread syntax. Or, after passing an array of observables - a higher-order observable, as an array itself is an ObservableInput - use the mergeAll operator.

Thank you.


Add handlebars-express installation procedure to documentation

Referring to:
https://stackoverflow.com/questions/33752753/register-assembly-io-handlebars-helpers-with-express-handlebars/35044785#35044785
I had to give up installation with handlebars-express since the documentation did not describe the steps needed (I was a handlebars beginner at the time). Other users report similar issues and might find below snippet helpful.
var express = require('express')
    , app = express()
    , exphbs = require('express-handlebars')
    , hbsHelpers = require('handlebars-helpers');

var hbs = exphbs.create({
    //code...
});

hbsHelpers.register(hbs.handlebars, {});

Would you be able to add this snippet to the documentation?

I'm not reporting a bug, but an addition to the documentation.

Hi @ChristianRich sorry that's just a default response. We have some things in the works to make assemblebot smarter.
Also sorry for the frustration with getting this to work. We've come a long way in terms of our knowledge of node.js and best practices since this lib was created - the dev branch will be much friendlier to use for your use case.
To that end, the current docs are pretty outdated, and since the dev branch of handlebars-helpers is going to be merged any day now I'd be happy to take a pr to temporarily update the master readme, but it might not be needed much longer.
Let me know your preference. thanks

Thanks for getting back on this topic and great to hear you a closer to a merge with the dev branch. I will not bother making a PR if you are going to merge any day soon.
Can't wait to test drive the new update. This library is valuable and I use it almost daily on my Node projects.


Release / 4.2

Catalyst Ledger support
Various UI fixes and internal improvements

Release: https://github.com/Emurgo/yoroi-mobile/releases/tag/4.2.0


Design Meeting Notes, 2/1/2019

Refactor to Named Parameters
#23552

"Named parameters"? what about "parameters object"?
What about when there's a contextual type?

Doesn't currently work, so we don't make it available.

Lots of cases! Direct calls are simple, but then there's issues where you don't know if you can provide a good experience.
None of our refactorings deal with this.

Ben: not quite true, the async refactoring does have some sort of bailout case.

Have to ask where we can offer this, and whether errors after refactoring is okay.
Developers have mentioned that they don't trust refactorings that don't definitely have errors when something goes wrong.

Could do a check to see whether the first parameter has any property overlap with the produced object argument.
But that's useless in JS
Could have different behavior for JS.

Errors with things that definitely depend on positional parameters.
We need to add something to the refactor API that explains why a refactor fails.
strictBindCallApply is the only place where

Check whether or not all calls are detectable

Overloads

Not applied right now.
Is that okay?

Absolutely

Overrides - when a subtype overrides a method in its base type.

Well it's the same problem as looking for all references of subtypes

Yeah, but you can always rename parameters
class C {
    foo(a: string, b: string): void;
}

class D extends C {
    // NOTICE: `c` and `d` have different names
    foo(c: string, d: string): void;
}

The fact that users can't apply the refactoring sometimes is actually worse than providing the refactoring and explaining why it won't work.
[[5 minute bikeshed over whether or not we should provide an anonymous type for the annotation, or produce a local interface]]
JSDoc

There's an issue around renaming correctly (confirm @sanders_n)

Paramter properties

Don't provide the refactor here

Rest parameters

Doesn't work now, but could refactor the call to take an array of arguments (or tuple).
Tuple?

Yeah, just depends on the type of the rest parameter

Maybe make the property optional entirely?

That's a semantic change
Just give it an empty array as an empty initializer

this parameters

Just...just leave it alone.

Parameters with initializers

Default initializer in a binding pattern
Becomes optional in the type

All-optional parameters

Makes the entire object argument optional

What do you do in unannotated JS?

Can't be sure! You have no validation when something goes wrong. You have no explicit intent. What if something's optional?
Conclusion

es3.d.ts
#28372

Why not?
Yeah, but why not?
First off, those people are targeting ES3 environments, they need some sort of break.
Well even the compiler was restricted to ES3, and we could've made our lives easier by setting that as the lib instead of yelling at them not to use .map and .filter and .reduce

Omit in lib.d.ts
#29254
type Omit<T, U extends keyof T> = Pick<T, Exclude<keyof T, U>>;

We didn't want to conflict with other Omits that had different behavior - and it would conflict with a global.

But you might not, so why are you intentionally breaking people?

But there are at least 2 different versions of Omit that are duplicated over DefinitelyTyped
Also, this uses Exclude on a generic, so maybe you want to wait for negated types?

Loosening restriction on Array methods taking predicates
#27509

{} | null | undefined is wrong, move to unknown
filter now allows any which means you can not return

Seems like an error worth raising in the type system

Why not switch filter to
We need a bool-ish type

What does that mean
"I'm not so bool-ish on that change"

This just needs boolean or unknown, not any.
Seems like moving from any to unknown is reasonable.
find and filter being different stinks.
Decide to try it out on RWC

Handling class fields breaking changes
#27644
Interesting ideas

Add AST/checking support before we add .d.ts emit support
Add .js emit support later on.
Maybe flip the name to modernClassFieldEmit?
Can you make it depend on the target?

Feels weird?

Need a good way to evangelize the change if we do this, but the truth is that this is just slower and doesn't actually match our mental model of how the feature should work.

"I'm not so bool-ish on that change"

🤣