Method validation without raising exception

I've took a look on method validation documentation.
I've also realazed that @ValidMethod annotation has a field named throwOnParamFailure.
I'd like to know if methods like this could be resolved:
public Either<String,DummyError> dummyMethod(@NotNull String name);

Could something like above code be resolved?
I mean, when any violation is checked by method validation return according return method signature.

So in that case the method would return DummyError?. Not sure how that could be done.

Let me explain me better:
Problem Description
My code raises exceptions only in exceptional cases (database connectivity, ...). For example, validation rules have to be checked and mapped to domain error objects.
That means that service layer methods which are meant to check business rules can run with a success result or a no-success result. Here explains better what I mean.
Goal
I want to handle validation errors internally within the service layer and return a Result (or Either) object that encapsulates both success and error states without relying on exception handling mechanisms like @ControllerAdvice.
Code Example
Here is my DummyError class:
import lombok.Builder;
import lombok.Data;

import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;

import jakarta.validation.ConstraintViolation;

@Data
@Builder
public class DummyError {

    private String message;
    private List<String> violations;

    public static DummyError fromConstraintViolations(Set<ConstraintViolation<?>> violations) {
        List<String> violationMessages = violations.stream()
            .map(violation -> violation.getPropertyPath() + " " + violation.getMessage())
            .collect(Collectors.toList());

        return DummyError.builder()
            .message("Validation failed")
            .violations(violationMessages)
            .build();
    }
}

Here is my DummyService class first approach without using @ValidMethod:
@Component
@RequiredArgsConstructor
public class DummyService {

    private final Validator validator;

    public Result<String, DummyError> dummyMethod(String name) {
        // Validate the parameter 'name'
        Set<ConstraintViolation> violations = //how to check `name` here without using @ValidMethod way

        if (!violations.isEmpty()) {
            return Result.ofErr(DummyError.fromConstraintViolations(violations));
        }

        return Result.ofOK("Hello " + name);
    }
}

Using ``@ValidMethod` approach:
public class DummyService {

    private final Validator validator;

    @ValidMethod
    public Result<String, DummyError> dummyMethod(@NotNull String name) {
        return Result.ofOK("Hello " + name);
    }
}

Above code is only an approach that what I'm trying to get.
Explanation

DummyError Class:

The DummyError class includes a static method fromConstraintViolations that constructs an instance of DummyError from a set of ConstraintViolation.
This method iterates over the violations and creates a list of error messages to populate the DummyError object.

DummyService Class:

The service class uses a Validator to validate the name parameter using the validateValue method.
If there are any violations, a Result with the error (Result.ofErr) is returned, constructed using the fromConstraintViolations method.
If there are no violations, a success Result (Result.ofOK) with the greeting message is returned.
The getName method is a dummy getter to satisfy the validation requirement.

Conclusion

How to check single value parameter by code.
Could be there anyway to customize AOP interceptor result type using any kind of kustomizer in order to adapt validation constraints to desired output method?

You can use try-catch wherever you call the method validator.

public class DummyService {
    @ValidMethod
    public String dummyMethod(@NotNull String name) {
        return "Hello " + name;
    }
}

try {
  DummyService service = //...

  service.dummyMethod(null);
} catch (ConstraintViolationException ex) {
// do something
}

Otherwise, I currently can't see a way to do this. Not even spring has a function like this.


Swift 4

Is there any version for Swift 4?

@usmantarar51
I already updated it to swift 4.
try running pod update


Lombok @Data Improve your Code Coverage

On my previous project we had a problem to achieve good code coverage with Jacoco. Lombok was used extensively on the project and each time we added new domain object we were loosing those precious code coverage percentages.

lombok有两种使用方式，依赖org.projectlombok:lombok组件和使用io.freefair.lombok插件，改用插件可以解决以上问题


Go spike

Don't merge - created for review comments only

I think @necrophonic can add a 'Don't Merge' label to this

Tidying up, closing the spike PR. We'll create a new one for the real service


Unable to edit job type fields

From the chat room:
I tried to update my job with curl -X PATCH http://INSTANCE_IP/api/job-types/13 -H "Content-Type: application/json" -d @only_icon_code.json -i -L where the json was {"icon_code": "f0fc"}. I got a 200 response, but I still have the old icon.

After further investigation I discovered the root issue here is the HTTP redirect due to omitting the trailing slash. When cURL performs a request that is not a plain GET and it receives a redirect response, then it makes the follow-up request using a plain GET. So in this case that results in just returning the job-type details response, rather than actually performing the edit. Therefore, this works as designed, but we could probably add a section to the REST docs to call out the trailing slash issue.
This behavior is documented in the cURL documentation:
https://curl.haxx.se/docs/manpage.html#-L

When curl follows a redirect and the request is not a plain GET (for example POST or PUT), it will do the following request with a GET if the HTTP response was 301, 302, or 303. If the response code was any other 3xx code, curl will re-send the following request using the same unmodified method.


Add connector (api_inbounddelivery_srv) and sanitation scripts

Purpose
This pull request focuses on adding the first connector (api_inbounddelivery_srv) under the delivery and transportation module of SAP S/4 HANA.
Fixes:
Checklist

[ ] Add first connector
[ ] Sanitize the Open API  Specification
[ ] Add operation ID to the Open API Specification
[ ] Generate client using the Open API Specification
[ ] Sanitize the generated client
[ ] Generate mock server
[ ] Add test cases
[ ]  Update documentation

Closing the PR since the PR build is failing due to test cases


HV-2018 Keep the interface if it is the hierarchy root

https://hibernate.atlassian.net/browse/HV-2018
I guess we never anticipated that the validation constraints will be only defined on an interface and that interface is passed to the validateValue().
What currently happens is that beanMetaData.getClassHierarchy() is empty and once we want to validate things we never get into this loop:
https://github.com/hibernate/hibernate-validator/blob/bb6129938a096d0928f64b7d34eb844a2d682419/engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java#L458-L462
Which means we actually do not evaluate any constraints...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.

@gsmet I'll let you take a look at this one once you have time. I think the patch makes sense, but maybe I'm missing something.. and since the filtering part should only happen once when the metadata is created it shouldn't cause issues because of those additional allocations to create filter instances.


Bug: var mock may cause sync.Mutex to be copied

var lock sync.Mutex

func demo(){
     lock.Lock()
    defer lock.Unlock()
     ...
}

Will be transformed to:
var lock sync.Mutex

func demo(){
    __xgo_lock1 := lock
    __xgo_lock1.Lock()
    __xgo_lock2 := lock
     defer __xgo_lock2.Unlock()
     ...
}

Is obviously wrong.
Other types include: sync.Map.

Solution:
var lock sync.Mutex

func demo(){
    __xgo_lock1 := &lock
    __xgo_lock1.Lock()
    __xgo_lock2 := &lock
     defer __xgo_lock2.Unlock()
     ...
}

However if lock itself is a pointer, then we are wrong again.
var lock *sync.Mutex

func demo(){
    __xgo_lock1 := &lock
    __xgo_lock1.Lock()
    __xgo_lock2 := &lock
     defer __xgo_lock2.Unlock()
     ...
}

Another simple solution is to turn off rewritting selector expr. i.e. only direct references are intercepted.
var lock sync.Mutex

func demo(){
     lock1:=&lock // intercepted
     lock1.Lock()

     lock.Unock() // not intercepted
}

Another simple solution is to turn off rewritting selector expr. i.e. only direct references are intercepted.
var lock sync.Mutex

func demo(){
     lock1:=&lock // intercepted
     lock1.Lock()

     lock.Unock() // not intercepted
}

After this, some valid case may not be intercepted:
type Config struct {
     On bool
}

var cfg = &Config{}

func demo(){
    if cfg.On { // cfg is not captured
        // ...
    }
}

var lock sync.Mutex
...
Will be transformed to:
Is obviously wrong.
Other types include: sync.Map.

Actually this does not happen, because func names are always skipped:
func (ctx *BlockContext) traverseCallExpr(node *syntax.CallExpr, globaleNames map[string]*DeclInfo, imports map[string]string) *syntax.CallExpr {
	if node == nil {
		return nil
	}
	if ctx.ArgCallExprParent == nil {
		ctx.ArgCallExprParent = make(map[syntax.Node]*syntax.CallExpr, len(node.ArgList))
		for _, arg := range node.ArgList {
			ctx.ArgCallExprParent[arg] = node
		}
	}

	// NOTE: we skip capturing a name as a function
	// node.Fun = ctx.traverseExpr(node.Fun, globaleNames, imports)
	for i, arg := range node.ArgList {
		node.ArgList[i] = ctx.traverseExpr(arg, globaleNames, imports)
	}
	return node
}

However, this causes panic:
func incrLocked_Fn() {
	f := lock.Lock
	f()
	count = count + 1
	lock.Unlock()
}

fatal error: sync: unlock of unlocked mutex

After this, some valid case may not be intercepted:
type Config struct {
     On bool
}

var cfg = &Config{}

func demo(){
    if cfg.On { // cfg is not captured
        // ...
    }
}

For cases where copy is allowed, we can add a comment to the definition to tell xgo allow it:

// xgo:trap
var cfg = &Config{}

After this, some valid case may not be intercepted:
type Config struct {
     On bool
}

var cfg = &Config{}

func demo(){
    if cfg.On { // cfg is not captured
        // ...
    }
}

For cases where copy is allowed, we can add a comment to the definition to tell xgo allow it:
// xgo:trap
var cfg = &Config{}

But since current syntax does not include comments, we cannot tell what the user want to do.
So we instead of comment ,use this:
const __xgo_trap_cfg = 1
var cfg = &Config{}


Add "Queued" Column for Builds

We now show a "Queued" column for builds which displays the date/time at which the build was placed in the queue.
These changes apply to the following templates:

build/templates/build_list.html
build/templates/detail_rebuilds.html
plan/templates/detail.html
plan/templates/plan_repo_detail.html
repository/templates/repo_detail.html

Note: The "Commit" column has been removed from build/templates/build_list.html as it seemed the least useful and I wanted to reduce clutter with the addition of the new date/time field.

The build model now has a get_commit method which returns a truncated version of the commit SHA. This will help reduce clutter when displaying commits in build info tables. The full commit SHA is still visible on the build/detail_layout.html template.

BuildFactory has been updated to generate a commit(ish) string for test builds.

Closing in favor of #1741


Fix typo in nose entrypoint script

This can't have been right....?

On Mon, Jun 13, 2016 at 11:22:34AM -0700, Erik Bray wrote:

This can't have been right....?

Heh.  I think this is a sign that we aren't using nose much anymore
;).  Can you create a new PR targetting the ‘python’ branch (you'll
probably have to cherry-pick your commit over to avoid pulling in
‘master’ stuff)?  I can setup the python-targetting PR if you like.

I can do that, but what is the purpose of the 'python' branch as opposed to master (which also has Python stuff)

On Mon, Jun 13, 2016 at 01:00:12PM -0700, Erik Bray wrote:

I can do that, but what is the purpose of the 'python' branch as
opposed to master (which also has Python stuff)

There's some background in #1.

I looked at #1 and still have no idea what the need is for these separate branches or what "namespaced" refers to.

Likewise I'm going to go ahead and merge this then cherry-pick into the python branch.


BUG - Canceled msig proposals are not displayed

Describe the bug
When trying to access the msig proposal after it has been canceled, it cannot be found when its link is clicked.
To Reproduce
Steps to reproduce the behavior:

Go to https://explorer.telos.net/proposal?tab=allProposal
Click on the Proposal Name "incr.maxinln"  (https://explorer.telos.net/proposal/incr.maxinln)
See error "Proposal not found"

Expected behavior
The proposal would be found.
Additional context

Fixed by #281


libxml2: enable strictDeps and enable pythonSupport when cross

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Will this still work with v2.10.2, the Python detection is a bit in flux.

Will this still work with v2.10.2? The Python detection is a bit in flux.

no python changes in configure.ac so it should still work
diff --git a/configure.ac b/configure.ac
index 3b273654..9dedb3af 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@ AC_PREREQ([2.63])

 m4_define([MAJOR_VERSION], 2)
 m4_define([MINOR_VERSION], 10)
-m4_define([MICRO_VERSION], 0)
+m4_define([MICRO_VERSION], 2)

 AC_INIT([libxml2],[MAJOR_VERSION.MINOR_VERSION.MICRO_VERSION])
 AC_CONFIG_SRCDIR([entities.c])
@@ -39,7 +39,7 @@ AC_SUBST(LIBXML_VERSION_EXTRA)

 VERSION=${LIBXML_VERSION}

-AM_INIT_AUTOMAKE([1.15 foreign no-dist-gzip dist-xz])
+AM_INIT_AUTOMAKE([1.16.3 foreign no-dist-gzip dist-xz])
 AM_MAINTAINER_MODE([enable])
 AM_SILENT_RULES([yes])

Maybe I misremembered and it was actually libxslt that had the Python issues.

Maybe I misremembered and it was actually libxslt that had the Python issues.

Nope
https://github.com/NixOS/nixpkgs/commit/1c93ab362bc9c2a9275d7d2dd0a6268be86e495a

🤷♀ I guess it is fine then.
Compared py and out outputs of libxml2 and libxslt on non-cross before
and after with diffoscope and looks like it is a no-op.
On Fri, Oct 7 2022 at 15:04:07 -07:00:00, Artturi
@.***> wrote:

Maybe I misremembered and it was actually libxslt that had the
Python issues.

Nope
1c93ab3
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID:
@.***>


Some refactoring and added checking for data exist

I renamed start.py to bot.py to avoid confusion. Made start.bat mandatory for loading and improved it. And also added a check for the existence of the data.json file and its creation, if necessary, and slightly edited the displayed messages.

I don't know how you imagine checking the token and prefixes, but the data entry is ready, so you can merge if everything is OK


Not working on react native 0.61.2

I try swiper newest version but can not swipe on react native 0.61.2, i copied the example on this git repo but not work.

even its not working for me, i have saw some solutions related to view pager but i dont think thats related to this, as we are using scrollview in this, any help will appreciated. @ArrayZoneYour can you please look into it :)

@ursNj But it just work fine under my 0.62 project, can you provide an example like #1080 ?

Has there been any headway with this ? I'm having the same challenge. It works fine on ios but does not work on android.

Invariant Violation: ViewPagerAndroid has been removed from React Native. It can now be installed and imported from 'react-native-viewpager' instead of 'react-native'. See https://github.com/react-native-community/react-native-viewpager

Probably a better idea to upgrade to the nightly release @cxfamily . Especially ViewPager was replaced in favor of ScrollView.
I just upgraded to it, can confirm that it works on 0.61.2.

@cxfamily I have just installed the nightly release as @AugustGSP said and it resolved the Invariant Violation: ViewPagerAndroid... Issue

remove  wrapper  width and height
E.g :
wrapper: {
// width: 600,
// height: 450 ,
},


cayw window does not appear

Debug log ID
F23I56JV-refs-euc/6.7.192-6
What happened?
I can't seem to get the CAYW window to appear using BBT.  I have been using this command in the terminal:
/usr/bin/curl 'http://localhost:23119/better-bibtex/cayw?format=pandoc&brackets=True'

but no window appears. The zotero integration with MS Word is working, because I can get a CAYW window in Word.
Thanks for any and all assistance!

Can you check if the style you have configured for quickcopy (https://csl.mendeley.com/styles/6316143/thesis) is actually installed, and if not, select another style and try again?

Yes, I'm able to copy and paste with that style.
I did see the Javascript error "this.style is undefined" and tried selecting other styles (which I also know are installed.)  In both cases, I could generate a bibliography in Word, I could copy a bibliography with Edit > Copy Bibliography, and I could generate a bibliography in Preferences > Cite > Styles > Style Preview.
Thanks for your help on this!

I did some troubleshooting. After re-saving and downloading a custom style (with an old mendeley URL) that was used in my "Item Format" in Settings > Export > Quick Copy, everything is working.


Hearbeat from client can be badly forwarded

Hi,
When I connect a client to 2 (or more) brokers, and each of the broker have a worker for a current service,
from a long request, when I call 'heartbeat(req.id)' on my client, the hearbeat is not always forwarded to the good worker.
I suspect it to be because of the way the dealer socket work in ZMQ, but haven't investigated more.

If I understand correctly, if we want to keep the abilty to have multiples brokers for a client, and be able to send hearbeat for a request ( sending to a specific broker which will forward to a specific worker),
the Client to Broker link should be Router-To-Router instead of Dealer-to-Broker.
What do you think ?

You're right.
We should refactor the multi-broker stuff on the Client.
The Client should handle multiple sockets, heartbeating for each Broker, etc...
I would maintain the Dealer socket type for the Client

You are right, Router-To-Router will not work in this case.
Do you think the multi broker stuff should be part of the library ?
My opinion is that it might not be mandatory, and that implementing a fully working solution will increase Client complexity a lot. A long term solution might be to have Broker to Broker communication possible. http://zguide.zeromq.org/page:all#Federation-Versus-Peering .This will keep Client and Worker simple, which is good if we want create Client and Worker in other languages.
In the mean time, I think that somebody with a multi broker need can instantiate severals clients. ( Just as we decided for a Worker providing multiples services).
What do you think ?

I was actually going to bring up the client connection to multiple brokers in regards to #18 as ZAP requires you to define a auth server and I was unable to work a solution with multiple brokers.

Yes, let's do that.
Users can now instantiate multiple clients with different Broker.
Current multi-broker support is quite useless.


Bump version to 2.50

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin please rerender

@stuarteberg After this was merged, the azure pipelines started again from scratch. Given that the full build takes over 5 hours, this seems quite wasteful.
My understanding was that the build artifacts from the MR would be simply be copied over under normal circumstances. Did I misunderstand?

That's a lot of work... I'm not sure many other packages would benefit from this.
BTW, do you know how much RAM and how many cores the build virtual machines have? We might still be able to squeeze some more from them.

I left comments in build_base.sh, but they don't point to original references.  Perhaps the situation has changed in the past 4 years.
https://github.com/conda-forge/graph-tool-feedstock/blob/dc1058a72d50f1f304ddf78a2ca7dc21ae5b92d8/recipe/build_base.sh#L37-L40
https://github.com/conda-forge/graph-tool-feedstock/blob/dc1058a72d50f1f304ddf78a2ca7dc21ae5b92d8/recipe/build_base.sh#L66-L73

It's a bit puzzling, actually, since many of the macOS and linux builds take about the same time to build, although supposedly the macOS images use two jobs, and the linux uses only one. But this could be due to the clang vs GCC difference.
I'll try to up the job counts on both of them to see what happens.

And BTW, what's up with this CPU_COUNT=4 variable? As far as I can tell it's not doing anything at all, since the job count is controlled by the make -j2. Can this be removed?


[Core / Dev Environments] Dev Home see the same COM class Ids in separate packages as separate extensions resulting in duplicate requests to the extensions

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug

Install any two versions of Dev Home (Dev, Canary or Preview).
Launch Dev Home and attempt to query for available extensions e.g repo with environments
Enable and create a Hyper-V VM in Windows Hyper-V manager.
Then open Dev Home and navigate to the environments page.
Observe the same VM is duplicated on the page

If you already have Hyper-V VMs created you should see this repo by just doing step 1 and step 4
Note: I mention environments but this is a Dev Home CORE issue itself, as Dev Home uses COM class Ids to identify Dev Home extensions. If the same class Id is in the package.appxmanifest file of  multiple packages, Dev Home sees these two packages as separate extensions, but COM will only spin up one out of proc COM server. I'm not sure which server is selected at that point, but since Dev Home sees it as two separate extensions, any request to providers those extensions support is done once for each package. To COM, this means the extensions COM server receives one request for each package that has its class Id as a Dev Home extension. So, in the case of Environments, The Hyper-V extension's class Id is the same across Dev Home build rings and because of the above, it receives two requests for compute systems (VMs) from Dev Home when multiple Dev Home packages are installed.
This also means that if you have multiple Azure extension packages (Dev, Canary, preview) installed, you'd receive duplicated Dev Boxes for example.
Expected result
Only one package is mapped to an extension class Id. Dev Home handles allowing the user to select the extension they want to use if necessary (I don't know if that part would be a feature request). But overall, only one request per extension should be made for a single COM class Id.
In the environment's scenario, the user should receive only a single response when we query for computes systems from an extension.
Actual result
If you follow the repo steps You'll noticed you'll see the VM duplicated twice when you navigate to the environments page and it loads.
Included System Information
No response
Included Extensions Information
No response

We think this is also causing trouble with trying to launch Dev Home from an extension using protocol activation.


Understand why zombie subscriptions are running

While developing re-frame-trace we've seen subscriptions that have been disposed are then re-run later. We need to work out whether this is due to:

A bug in user code
A bug in re-frame
A bug in reagent
Elsewhere?

c.f. https://github.com/reagent-project/reagent/pull/270.

Didn't you establish that this is related to a figwheel reload?

Figwheel reloading is the trigger, but it's still not clear what the mechanism is for resurrecting the disposed subscriptions. Your speculation seems correct to me, the question we need to answer is why do they come back, and how?

Looking more at this it seems like it is only triggered by Figwheel reloads of changes to re-frame-trace. This only happens when you are developing re-frame-trace alongside your main application. It doesn't appear to happen when your main application has a figwheel reload.
The cause of the zombie resurrection we've observed is an on-click handler dereferencing a subscription (and possibly not dereferencing the subscription within the view fn). What's not clear is how that on-click handler persists through the Figwheel reloads, as the on-jsload function is running which seems like it should trigger a re-render.


Restore IsRemote() check when comparing backend

Fixes #316

Thanks for the PR! The change looks good. Do the tests pass? Unfortunately, we can't run our CI for external PRs automatically due to security concerns.

I just ran the ones for remote, but if needed I can run the full test suite...
=== RUN   TestToTerraformInitArgs
=== RUN   TestToTerraformInitArgsNoBackendConfigs
=== RUN   TestDiffersFrom
=== RUN   TestParseTerraformStateLocal
=== RUN   TestParseTerraformStateRemote
=== RUN   TestParseTerraformStateRemoteFull
=== RUN   TestParseTerraformStateEmpty
=== RUN   TestParseTerraformStateInvalid
--- PASS: TestToTerraformInitArgs (0.00s)
--- PASS: TestParseTerraformStateInvalid (0.00s)
--- PASS: TestParseTerraformStateEmpty (0.00s)
--- PASS: TestParseTerraformStateRemoteFull (0.00s)
--- PASS: TestParseTerraformStateRemote (0.00s)
--- PASS: TestParseTerraformStateLocal (0.00s)
--- PASS: TestToTerraformInitArgsNoBackendConfigs (0.00s)
[terragrunt] 2017/11/27 13:02:15 Backend  has not changed.
[terragrunt] 2017/11/27 13:02:15 Backend s3 has not changed.
[terragrunt] 2017/11/27 13:02:15 Backend type has changed from s3 to atlas
[terragrunt] 2017/11/27 13:02:15 Backend s3 has not changed.
[terragrunt] 2017/11/27 13:02:15 Backend config has changed from map[bucket:foo key:bar region:us-east-1] to map[region:us-east-1 bucket:different key:bar]
--- PASS: TestDiffersFrom (0.00s)
PASS
[terragrunt] 2017/11/27 13:02:15 Backend config has changed from map[bucket:foo key:bar region:us-east-1] to map[bucket:foo key:different region:us-east-1]
[terragrunt] 2017/11/27 13:02:15 Backend config has changed from map[bucket:foo key:bar region:us-east-1] to map[bucket:foo key:bar region:different]
ok  	github.com/gruntwork-io/terragrunt/remote	0.007s

Could you run all the tests please? It should only take a 1-2 min or so. Thank you!

Do the tests incur a cost for my AWS account? I notice they use DynomoDB and my AWS credentials...

The tests create S3 buckets and DynamoDB tables, write some data to them, and then clean them up again. If you're still eligible for the free tier, this shouldn't cost you anything. If you're not, it'll cost you some fractions of a cent for S3 usage (DynamoDB's always has a free tier, so that still shouldn't cost anything). If you're not comfortable with that, let me know.

I'm having issues running the tests. We use MFA even with AWS-CLI, and setting the environment variables doesn't seem to be enough for the tests. All calls to AWS fail.

Setting env vars correctly with MFA is tricky. We even built a tool for it :-D
Anyways, I'll merge this in and see if the tests pass. Worst case, I'll revert it.

The tests passed. New release is here: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.13.22. The binaries should show up in a few minutes. Thanks again for the fix!

Awesome! Is the MFA CLI tool publicly available?? Sounds useful!

No, it's currently only available for Gruntwork customers.


expand citability by adding CITATION file

Hello!
This is a copy your 2017 entry on https://retdec.com/publications/ incorporated into the repo as suggested in https://www.software.ac.uk/blog/2013-09-02-encouraging-citation-software-introducing-citation-files. Adding it here may make it simpler for people to cite your software. How about it?
Also, it would be possible edit this PR to:

[ ] use @software{...
[ ] add a DOI through https://guides.github.com/activities/citable-code/
[ ] include a url = {...}

Cheers!

Thank you for the idea! We definitely want to do this, but we are not yet sure what to include into the CITATION file. We will need to discuss this in our team. Let me get back to you during the first week of January.


[WIP] Fix rewrapping issue in BirFunctionWrapper

Purpose
During the BirFunction wrapping for module jar generation, the non test functions in testable package functions also get updated.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/25301
Approach
Skip re-wrapping already wrapped BIRFunctions
Samples
N/A
Remarks
N/A
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

The issue is fixed with https://github.com/ballerina-platform/ballerina-lang/pull/25408


Add skeleton to loading Accounting options

Details
If the data is not ready, we should see a skeleton loader on the Connections card in the Accounting page, not "Hmm... it's not here" page
Fixed Issues
$ https://github.com/Expensify/App/issues/41250
PROPOSAL:
Tests

Create Workspace
Go to "More Settings"
Make your connection extra slow using the dev tools
Enable "Accounting" for the first time
Quickly navigate to the new "Accounting" menu that appeared (before the request EnablePolicyConnections is resolved)
Verify that no "Hmm it's not here" page is shown
Verify that skeleton loader is shown

[x] Verify that no errors appear in the JS console

Offline tests

Create Workspace
Go to "More Settings"
Make your connection extra slow using the dev tools
Enable "Accounting" for the first time
Quickly navigate to the new "Accounting" menu that appeared (before the request EnablePolicyConnections is resolved)
Verify that no "Hmm it's not here" page is shown
Verify that skeleton loader is shown

QA Steps

Create Workspace
Go to "More Settings"
Make your connection extra slow using the dev tools
Enable "Accounting" for the first time
Quickly navigate to the new "Accounting" menu that appeared (before the request EnablePolicyConnections is resolved)
Verify that no "Hmm it's not here" page is shown
Verify that skeleton loader is shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/28352309/b0705b61-4d27-4171-b6b0-6368a64793bc

Android: mWeb Chrome
https://github.com/Expensify/App/assets/28352309/1b6ad945-2a3a-4ba0-8ac5-a4fcd138e21d

iOS: Native
https://github.com/Expensify/App/assets/28352309/9009dbd5-a0ce-4513-8f59-bef338ddcb08

iOS: mWeb Safari
https://github.com/Expensify/App/assets/28352309/c0ca0637-707e-4e08-b94c-cc44503bb22c

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/28352309/ead838de-ade6-4e6d-9295-b710807c1916

MacOS: Desktop
https://github.com/Expensify/App/assets/28352309/3f1ceda0-6ce5-4a2b-9322-cd98652bc4d8

cc @s77rt

Almost there - but the fake avatar circles should be left-aligned with the content above, the same way that the accounting rows are:

Can you check that the skeleton also has the exact same height and spacing as the real rows? Ideally there should be no "jump" from loading to real content. Thanks!

This is not fixing the root cause and we don't need a skeleton loader here. The enable accounting switch works offline and we should be able to view the accounting page immediately.

@shawnborton are we good with such skeleton? Same height for each item and same positions for all elements:
https://github.com/Expensify/App/assets/28352309/467e57ea-38de-40e8-a51a-1f082baef674

That looks pretty good to me. Do we have control over how wide these lines are?

If so, I think it might be nicer to make them match something more like the width of the top line here: +

That looks pretty good to me. Do we have control over how wide these lines are?
If so, I think it might be nicer to make them match something more like the width of the top line here: +

sure thing! let me add that

That looks good to me. I can see where it might be nice to have one of those be slightly wider than the other, to create some variance, but I can totally get down with what you have. cc @Expensify/design for viz.

I don't mind the skeleton lines being the same width I don't think, but I kinda want them to be a litttttttle bit wider, maybe like 40% instead of 20? Honestly not a huge deal. It's looking pretty good as is.

I don't mind the skeleton lines being the same width I don't think, but I kinda want them to be a litttttttle bit wider, maybe like 40% instead of 20? Honestly not a huge deal. It's looking pretty good as is.

Done deal! Added 40%

Cool, that works for me!

Code looks good to me. Testing...

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/16493223/c3c2043c-92d7-467b-bd49-60c77df13dc7

Android: mWeb Chrome

Networking issue

iOS: Native

https://github.com/Expensify/App/assets/16493223/14df6645-b7a7-44ab-825b-844b4ef75e8f

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16493223/461876da-df8f-443e-8331-3c11a4b88bf4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16493223/1bfe8c12-32e4-4968-97b3-127b05473819

MacOS: Desktop

https://github.com/Expensify/App/assets/16493223/aec0703f-6aed-4db0-93f9-2ee4b30ea158

@narefyev91 Thank you!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@narefyev91 Thank you!

Thank you too! As usual nice to work with you!

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix PydanticKnownError user context handling issues

Change Summary
Fixes error context issues with PydanticKnownError which lost user provided error context data and caused types to change from what was given to the context.
Fixing this requires passing error context data as a part of the ErrorType enum. It is not enough to add the context data as a part of the PydanticKnownError as internally this is converted into ErrorType enum. This conversion was lossy for the context data. Now this issue no longer happens. Adding the context as a part of the ErrorType happens via a macro that creates the Enum items. Also creating the utilities for using them and handling the error context data. Basic errors without any predefined fields are used via ErrorTypeDefaults::TheError constants to make it easier to use those (without having to add context: None in cases where there is no user defined context).
Related issue number
fix https://github.com/pydantic/pydantic-core/issues/824
Checklist

[x] Unit tests for the changes exist
[x] Documentation reflects the changes where applicable
[x] Pydantic tests pass with this pydantic-core (except for expected changes)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

Given the performance consequences, I'm going to defer to one of the rust/pydantic-core experts @samuelcolvin @adriangb @davidhewitt


[W6.1e][W13-A2]Gan Wei Liang

@william6364
Some comments added. Please ack & close the PR after reading comments.


Update about.css

I am marking all your PRs as spam and invalid. Do not contribute to this repository again.


Fails to load Uber::Version

Installed roar-rails today and it barfs at boot: Gem Load Error is: uninitialized constant Uber::Version

Hey @myabc didn't we fix that?

I just got the same problem after a bundle update.  The odd thing is that bundle update did this:
Installing roar-rails 1.0.1 (was 1.0.2)

So it actually downgraded?  I also notice that 1.0.2 is listed in the "releases" tab on github as happening on Jan 15, whereas 1.0.1 has a more recent date of Jan 21. Perhaps that's related? Or maybe it's just coincidence.

@contentfree @eric-simonton-sama roar-rails 1.1.0 has now been released. This should resolve this issue.


Next steps after identifying rule changes

The steps needed to actually "fix" the duplicated rules are missing.  The Synchronization Rules Editor keeps the "original" rule enabled with the warning icon, and the "revised" new rule contains any updates to the original rule but is disabled.  This allows you to see the changes between the two rules, but the process to reconcile those rules isn't listed.  For example, if the "revised" rule contains the correct settings, can you delete the "original" rule and enable the revised one?  This seems like a logical conclusion based on how the rules work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 68820b27-5fc7-cef8-156a-ea9fe37dc0b1
Version Independent ID: a779a83e-b6d6-a51c-fc95-e2fea9b3f18c
Content: How to fix modified default rules - Azure AD Connect
Content Source: articles/active-directory/hybrid/how-to-connect-fix-default-rules.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@purduegrad06 Thank you for your feedback . We will investigate and update further.

@billmath Could you please get this reviewed with the engineering if this can be updated as requested by the OP?

@purduegrad06 Thank you for the feedback.  I have created a backlog work item for this and will be working on this in the coming months.  I will send a follow-up once this has been updated.  Thanks!
#please-close


RHOAIENG-4962: Add HTTPS connection support

See RHOAIENG-4962.
Add HTTPS endpoint support for the TrustyAI service.

/test trustyai-explainability-e2e


[test, entropy_src] Add entropy_src_edn  chip level test

Test
The objective of this test is to have all the peripherals connected to the EDN requesting entropy data.
Fixes #13224

@cindychip
it looks like for alert_handler the edn request is dependent on a built-in timer which has a pretty long count (16 bits).
so you'll either need to wait out, or as the design suggests (https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip_autogen/alert_handler/rtl/alert_handler.sv#L134) force it to a smaller value.
i think you should at least see one at the beginning of time though? do you not?
@martin-lueker @mwbranstad
regarding the FIPS bit, you might need to reinitialize the entropy source. It looks like if you are routing entropy to software in entropy_src the FIPS function is automatically disabled.
@zi-v @moidx does this sound right to you? Technically for known answer tests we would also want AST in "fips" mode right? Whatever that means?

@msfschaffner do you have any advice on how to force the alert handler to request entropy to edn?

As @tjaychen mentions above, I would also suggest to statically force the wait_cyc_mask_i signal to a shorter mask (e.g. 0xF instead of 0xFFFF) to increase the rate of entropy requests.

I see a comment above with my user name tagged, but now crossed out. Is there an action required here, or does this mean it that no action is needed anymore?

I see a comment above with my user name tagged, but now crossed out. Is there an action required here, or does this mean it that no action is needed anymore?

we're good @mwbranstad. I misunderstood the design at first, but after reading it through more closely and checking with @timothytrippel and @moidx i think we are good.

thanks @tjaychen for the update.

Thanks folks for the comments, here is an update.
fips:
I've rebased to get the new dif_entropy_src and even then the fips bit never flips high. Note In the trace below that the ES_ROUTE and ES_TYPE are both disabled.

Alert handler:

can be overridden in DV and FPV to shorten the wait periods.

I've never done that before, do you have any example where I can look for reference?

Thanks folks for the comments, here is an update.
fips:
I've rebased to get the new dif_entropy_src and even then the fips bit never flips high. Note In the trace below that the ES_ROUTE and ES_TYPE are both disabled.
Alert handler:

can be overridden in DV and FPV to shorten the wait periods.

I've never done that before, do you have any example where I can look for reference?

let me pull down this PR and have a look later today

@mwbranstad
@martin-lueker
@moidx
it would be good if you guys can confirm / correct what i'm saying below.
@engdoreis I pulled down your test to have a look, as far as I can tell, here is the issue.

the edn module that is distributing to most of the blocks is talking to a csrng instance that was instantiated during boot time. Boot time instantiation is done specifically with non-fips compliance in mind in order to speed up entropy collection

so even though you turn the fips bit on later, the edn0 module still keeps the fips bit low because it was instantiated with non-fips compliant entropy.  If you look at edn1 on the other hand, it talks to a csrng instance that has been instantiated with the right kind of seed.

In terms of what you need to do, i think in the beginning in your test you actually need to disable all of entropy_src, csrng and edn (since it was turned on by test rom).  Then proceed with what you have here, THEN I think you will see the fips bit correctly set.

Thanks @tjaychen for the hints, I've enabled the fips in the rom_test just in a matter of testing and It acctually worked. However no matter what I try in the test to restart the IPs (edn, csrng and entropy_src) the fips never works in the edn0, just in the edn1. I'm running out of options, do you have any other suggestion? Thanks.

if you can add the latest changes you made (including disabling of the 3 blocks and re-enabling), please push that into this PR and i can have a look.

@tjaychen I appreciate that! I did the changes in the sw/device/tests/entropy_src_edn_reqs_test.c file. It is a little messy because I was trying different scenarios.

@tjaychen I appreciate that! I did the changes in the sw/device/tests/entropy_src_edn_reqs_test.c file. It is a little messy because I was trying different scenarios.

no worries. I'm debugging a few other things right now, but I will try to get to this afternoon my time.

@engdoreis can you have a look at #13270 ?
I noticed a few issues where I have filed separate issues.
Can you take the hacked up commit and see if it looks as you expect now?

@engdoreis the fix for edn is in.
So the test mostly should do what's expected now. The main thing is after disable/enable, you need to wait a while for the entire entropy complex to gather enough "fips compliant" randomness before it will respond to any entropy requests again.
I've added a fake delay in mine, but you can probably deal with it separately.
The last thing is i would like to speed up the random generation process for the sake of simulation, since it's just so slow otherwise.

Yes @tjaychen, it works just like it should. What would the next step now? Are you going to create a PR?

Yes @tjaychen, it works just like it should. What would the next step now? Are you going to create a PR?

i think we can just continue with this PR. You might just need to add some delay in the test.
Separately I will work with Nuvoton to see if it's okay to add a model option to speed up entropy gathering, but that can be done separately from this test.

btw @engdoreis , this PR adds the DV option to shorten the ping activation time. However this will only for DV, it won't work for verilator.

@tjaychen I tried to execute the test with dvsim but apparently all the tests are failing in the HEAD of master with the error:
Offending '(clr_i != set_i)'

@tjaychen I tried to execute the test with dvsim but apparently all the tests are failing in the HEAD of master with the error:
Offending '(clr_i != set_i)'

@engdoreis are you still seeing dv issues? I haven't seen anything at top of tree, and your CI is also passing.

@cindychip it looks like for alert_handler the edn request is dependent on a built-in timer which has a pretty long count (16 bits). so you'll either need to wait out, or as the design suggests (https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip_autogen/alert_handler/rtl/alert_handler.sv#L134) force it to a smaller value.
i think you should at least see one at the beginning of time though? do you not?
After looking at the code, and discussing a bit with @timothytrippel / @moidx, the existing fips enable / bypass controls should be fine.
Specifically for this test, if setting FIPS enable does not actually flip the bit high, it might be that both ES_ROUTE/ES_TYPE bits are set in your test. These two together actually overwrite the FIPS enable, but the current DIFs don't check for that.
~@martin-lueker @mwbranstad regarding the FIPS bit, you might need to reinitialize the entropy source. It looks like if you are routing entropy to software in entropy_src the FIPS function is automatically disabled.~
~@zi-v @moidx does this sound right to you? Technically for known answer tests we would also want AST in "fips" mode right? Whatever that means?~

Sorry for the late reply, I did add some checkings to make sure EDN requests are fetched.
https://github.com/lowRISC/opentitan/pull/13473

@tjaychen I tried to execute the test with dvsim but apparently all the tests are failing in the HEAD of master with the error:
Offending '(clr_i != set_i)'

@engdoreis are you still seeing dv issues? I haven't seen anything at top of tree, and your CI is also passing.

Yes, I just rebased and ran ./util/dvsim/dvsim.py hw/top_earlgrey/dv/chip_sim_cfg.hjson -i chip_sw_edn_entropy_reqs
and this is the output I'm seing.
|  Milestone  |      Name      | Tests                    |  Passing  |  Total  |  Pass Rate  |
|:-----------:|:--------------:|:-------------------------|:---------:|:-------:|:-----------:|
|             | Unmapped tests | chip_sw_edn_entropy_reqs |     0     |    1    |   0.00 %    |
|             |                | **TOTAL**                |     0     |    1    |   0.00 %    |

## Failure Buckets

* `Offending '(clr_i != set_i)'` has 1 failures:
    * Test chip_sw_edn_entropy_reqs has 1 failures.
        * 0.chip_sw_edn_entropy_reqs.2501922776\
          Line 370, in log /home/doreis/lowrisc/git/opentitan/scratch/entropy_src_edn_test/chip_earlg
rey_asic-sim-vcs/0.chip_sw_edn_entropy_reqs/out/run.log

                	Offending '(clr_i != set_i)'
                UVM_ERROR @ 4396.240106 us: (prim_count.sv:180) [ASSERT FAILED] SimulClrSet_A
                UVM_INFO @ 4396.240106 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
                --- UVM Report catcher Summary ---

INFO: [FlowCfg] [scratch_path]: [chip] [/home/doreis/lowrisc/git/opentitan/scratch/entropy_src_edn_te
st/chip_earlgrey_asic-sim-vcs]
INFO: [FlowCfg] [results:email]: [/home/doreis/lowrisc/git/opentitan/scratch/email.html]
ERROR: [dvsim] Errors were encountered in this run.

          [   legend    ]: [Q: queued, D: dispatched, P: passed, F: failed, K: killed, T: total]
00:01:58  [    build    ]: [Q: 0, D: 0, P: 1, F: 0, K: 0, T: 1] 100%
00:03:54  [     run     ]: [Q: 0, D: 0, P: 0, F: 1, K: 0, T: 1] 100%

The issue above has been fixed here #13520

@tjaychen and @cindychip, this test is ready, but it depends on #13270 to work.

@tjaychen and @cindychip, this test is ready, but it depends on the changes made in the rtl here #13270 to work.

hmm? why do we need #13270? that was mostly an example PR to show case changes. Isn't your original one working now too?

Maybe I'm missing something, but I tested with verilator and without the change in the RTL srate_value = 12'd30; the EDN ack never goes high and the test fails. Is it suppose to work only with dvsim?

ooo i see. hmmm...we did add an option to speed up srate_value.  See here (https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip/ast/rtl/rng.sv#L67).  Without that change it just takes a LONG time. Do you know if verilator can support that kind of construct? If not, then it's probably better to mark this dvsim only.

@tjaychen and @cindychip, this test is ready, but it depends on the changes made in the rtl here #13270 to work.

hmm? why do we need #13270? that was mostly an example PR to show case changes. Isn't your original one working now too?

Maybe I'm missing something, but I tested with verilator and without the change in the RTL srate_value = 12'd30; the EDN ack never goes high and the test fails. Is it suppose to work only with dvsim?

ooo i see. hmmm...we did add an option to speed up srate_value. See here (https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip/ast/rtl/rng.sv#L67). Without that change it just takes a LONG time. Do you know if verilator can support that kind of construct? If not, then it's probably better to mark this dvsim only.

I tested with dvsim and FPGA and the test also fails.

@tjaychen and @cindychip, this test is ready, but it depends on the changes made in the rtl here #13270 to work.

hmm? why do we need #13270? that was mostly an example PR to show case changes. Isn't your original one working now too?

Maybe I'm missing something, but I tested with verilator and without the change in the RTL srate_value = 12'd30; the EDN ack never goes high and the test fails. Is it suppose to work only with dvsim?

ooo i see. hmmm...we did add an option to speed up srate_value. See here (https://github.com/lowRISC/opentitan/blob/master/hw/top_earlgrey/ip/ast/rtl/rng.sv#L67). Without that change it just takes a LONG time. Do you know if verilator can support that kind of construct? If not, then it's probably better to mark this dvsim only.

I tested with dvsim and FPGA and the test also fails.

ah okay, let's mark this test for DV only then. The duration shortening won't work for FPGA / verilator, not unless we add a MUCH longer delay in the test themselves.

@engdoreis can you try this on fpga / verilator now? i think it might work.

@tjaychen it is passing on verilator, but failing on FPGA. But I haven't investigate.
I00000 ottf_main.c:80] Running sw/device/tests/entropy_src_edn_reqs_test.c
I00001 entropy_src_edn_reqs_test.c:209] test_initialize
I00002 entropy_src_edn_reqs_test.c:157] alert_handler_configure
I00003 entropy_src_edn_reqs_test.c:254] Entropy src test 0/5
I00004 entropy_src_edn_reqs_test.c:201] alert_handler_test
I00005 entropy_src_edn_reqs_test.c:66] aes_test
I00006 entropy_src_edn_reqs_test.c:117] otbn_test
I00007 entropy_src_edn_reqs_test.c:133] keymgr_test
I00008 entropy_src_edn_reqs_test.c:98] otp_ctrl_test
I00009 entropy_src_edn_reqs_test.c:85] kmac_test
I00010 entropy_src_edn_reqs_test.c:145] ibex_test
I00011 entropy_src_edn_reqs_test.c:254] Entropy src test 1/5
I00012 entropy_src_edn_reqs_test.c:201] alert_handler_test
I00013 entropy_src_edn_reqs_test.c:66] aes_test
I00014 entropy_src_edn_reqs_test.c:117] otbn_test
I00015 entropy_src_edn_reqs_test.c:98] otp_ctrl_test
I00016 entropy_src_edn_reqs_test.c:85] kmac_test
I00017 entropy_src_edn_reqs_test.c:145] ibex_test
E00018 entropy_src_edn_reqs_test.c:149] DIF-fail: dif_rv_core_ibex_read_rnd_data(&ctx->ibex, &rnd) returns 1
I00019 status.c:34] FAIL!

hmmmm... so the thing about the ibex test is that I feel it's a bit timing
dependent.
Because effectively we are in a race between the software and the
hardware.   What the ibex hardware is supposed to do is that after your
request entropy, it handshakes with the edn hardware to get more entropy.
That "could" end up taking some time (because it needs to go through a drbg
generate loop), and if the read happens to land right in the middle of that
it may not work.
Although having said that..the two ibex tests are pretty far from each
other, and you also have uart logging, so that should be tons of time.
This feels like maybe there's a hidden bug.  I can extend the DV one to
multiple loops also and see what happens.
On Sat, Jul 16, 2022 at 3:33 AM Douglas Reis @.***>
wrote:

@tjaychen https://github.com/tjaychen it is passing on verilator, but
failing on FPGA. But I haven't investigate.
I00000 ottf_main.c:80] Running sw/device/tests/entropy_src_edn_reqs_test.c
I00001 entropy_src_edn_reqs_test.c:209] test_initialize
I00002 entropy_src_edn_reqs_test.c:157] alert_handler_configure
I00003 entropy_src_edn_reqs_test.c:254] Entropy src test 0/5
I00004 entropy_src_edn_reqs_test.c:201] alert_handler_test
I00005 entropy_src_edn_reqs_test.c:66] aes_test
I00006 entropy_src_edn_reqs_test.c:117] otbn_test
I00007 entropy_src_edn_reqs_test.c:133] keymgr_test
I00008 entropy_src_edn_reqs_test.c:98] otp_ctrl_test
I00009 entropy_src_edn_reqs_test.c:85] kmac_test
I00010 entropy_src_edn_reqs_test.c:145] ibex_test
I00011 entropy_src_edn_reqs_test.c:254] Entropy src test 1/5
I00012 entropy_src_edn_reqs_test.c:201] alert_handler_test
I00013 entropy_src_edn_reqs_test.c:66] aes_test
I00014 entropy_src_edn_reqs_test.c:117] otbn_test
I00015 entropy_src_edn_reqs_test.c:98] otp_ctrl_test
I00016 entropy_src_edn_reqs_test.c:85] kmac_test
I00017 entropy_src_edn_reqs_test.c:145] ibex_test
E00018 entropy_src_edn_reqs_test.c:149] DIF-fail: dif_rv_core_ibex_read_rnd_data(&ctx->ibex, &rnd) returns 1
I00019 status.c:34] FAIL!
—
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/12966#issuecomment-1186147013,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSVQI7B677RJ2DFEQDLVUKFYHANCNFSM5XRQRN4A
.
You are receiving this because you were mentioned.Message ID:
@.***>

@engdoreis i had a look at this, and i think the reason fpga is failing is because the entropy complex depletes its entropy.
This is happening because we didn't place the entropy complex in auto mode. I quickly hacked in something for the purpose of this PR, so let me know if it works for FPGA.

@engdoreis i finally got around to looking at this.
I think somewhere the entropy setup was broken.  In this test, the healthtest parameters were completely wrong, and the entropy_src was actually doing very nonsensical things, which led to the polling timeout.
I'm hoping this last fix will address these issues on all platforms.

@tjaychen Thanks for working on that, I rebased and tested on verilator, vcs and FPGA. It's all working.
Are we ready to merge?

yes let's merge, thanks for sticking with this. I've approved, but not sure if you want another software person to look through.


Opening a file fails if update is ready (Mac OS X)

Description
If Atom is running and an update is downloaded and ready to be installed, opening a new file from an external application (like Finder) will fail - rather than opening that file in the existing application instance a new instance of the application starts up, without any files. Worse yet, after closing the second instance and restarting the initial one the update is not installed and has to be downloaded again.
Steps to Reproduce

Install Atom 1.8.0-beta4
Run Atom
Go to Atom menu, click "Check for Update" if that menu item is present.
Wait for the update to be downloaded (Atom menu will show something like "Restart to install Atom 1.9.0-beta0") but don't restart Atom.
Run from command line: open -a 'Atom Beta' ~/.atom/init.coffee

Expected behavior: A new tab is opened in the running Atom instance, allowing to edit the Atom init script.
Actual behavior: A second Atom instance starts up, without any tabs. Closing that instance and restarting the initial instance won't install the update, the update has to be downloaded again instead.
Versions
Atom 1.8.0-beta4 on Mac OS X 10.11.5. However, I've been seeing this issue at least since Atom 1.3, merely didn't realize what was causing it before now.

Also happens for me sometimes! Sadly, I have no idea what actually causes this bug to appear...


featureRefresh partition stats cache while analying.

While doing partition level analyzing, we need to update the partition stats cache for all FEs, so that the cache are updated after analyzing finished. This pr is to support this.

run buildall


[Bug] Font weight is not working correctly

None of the following code snippets affects the font-weight correctly.
#set text(size: 18pt)
#text(
    font: "Open Sans"
)[Open Sans]\
#text(
    font: "Open Sans Light"
)[Open Sans Light]\
#text(
    font: "Open Sans",
    weight: "light"
)[Open Sans (weight: light)]\
#text(
    font: "Open Sans",
    weight: "bold"
)[Open Sans (weight: bold)]

Version: 0.2.0
OS: Windows 11

Might seem obvious but are you sure you have open sans bold .ttf or something installed?
if so maybe typst doesn't find it maybe try calling text with fallback : false to make sure

All fonts are installed:

Result with fallback: false:

Likely related to #576

Closing in favor of https://github.com/typst/typst/issues/576

You installed Open Sans as a vairable font, this should goes to #185


Webhook-lionjudge-payloads-md.

Fyi

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

I'm closing this, but if you fill out the PR template and would like it reopened, let me know!


Update dependencies

Update dependencies and a bit of housekeeping.

There is a typo in Cancelation, but it's also like this in the app itself, so it's bigger than the sdk and most probably a breaking change!

Hello @omid
thanks for the PR
We are ok with breaking changes since the app is not stable (using version format like v0.X.Y and not vX.Y.Z), so we can accept a PR. The most important is to be clear in the communication

Also @omid you said you updated the dependencies, but which ones?

@curquiza Thanks 🙏🏼

Also @omid you said you updated the dependencies but you also changed a lot of things

I updated syn to 2, jsonwebtoken to 9, and removed env_logger, since it wasn't in use.

I don't feel comfortable accepting a PR where I have that much files to review for different reasons

If you don't mind, the update dep thingy changes are in just one commit which you can find here.

We are ok with breaking changes since the app is not stable (using version format like v0.X.Y and not vX.Y.Z), so we can accept a PR. The most important is to be clear in the communication

Sure, the only issue will be that the change should be applied everywhere! Including all SDKs I think, which I'm not familiar with their languages and it's a big chunk of work also.

If you don't mind, the update dep thingy changes are in just one commit which you can find here.

Not 100% true, this commit also change some parts of the code at the middle of the non-code related update:
https://github.com/meilisearch/meilisearch-rust/pull/542/commits/351651951e50155d4125a6df4ec23b914cfd1e0a

Sure, the only issue will be that the change should be applied everywhere! Including all SDKs I think, which I'm not familiar with their languages and it's a big chunk of work also. (github said 50 files in the meilisearch org)

Can you point which kind of change you refer and why the issue is in all the SDKs?

Can you point which kind of change you refer and why the issue is in all the SDKs?

As I said in the first post here, There is a typo in *Cancelation*. It's wrong, it's cancellation, double LL.

Not 100% true, this commit also change some parts of the code at the middle of the non-code related update:

The update deps are in one commit. Others are typos and some housekeeping. There are some changes in the macro part in other commits, but they are not about the logic. Just code style, typo and so on.

Can you fix git conflicts?


Sorting on string field

Is this supported? I get this error when trying to extract Hits from the searchResult:
Line | Method
->>  540 | parseDouble             in java.lang.Double

|    193 | getAsDouble             in com.google.gson.JsonPrimitive
|    120 | extractSort . . . . . . in io.searchbox.core.SearchResult
It seems the sorts are hardcoded to doubles in this class. Is there another way to get the hits out of a search result when sorting on string fields?

You're right, we missed that when merging #188.


GitHub and Contributing

Add GitHub templates and contributing info.

Coverage remained the same at 94.208% when pulling 4a65e318d8e07d56e574e1667142e7c81ee9bb03 on github into f8ec2fbbfc9393829e23973b2400e2ba4b052996 on master.


[Bug]: Validation fails on any amount of files

Contact Details
<EMAIL_ADDRESS>What happened?
A form with a MudExUploadEdit with the attribute Required=true will not successfully validate even with files added. Attempting to submit will just mark the field "This field is required."
Expected Behavior
The form successfully will validate with one or more files in the component.
Screenshots
No response
Reproduction link
No response
What application type are you referring to?
ServerRendered
Custom Application Type
No response
MudBlazor.Extension Version
1.7.76
MudBlazor Version
6.11.0
What browser are you using?
Chrome, Edge
Sample Solution
No response
Pull Request
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Are you using MudExUploadEdit inside of a MudForm or are you using it with MudExObjectEditForm ?

Inside a MudForm. The issue was fixed with a prior pull request in the last version but it seems to have been reverted for some reason.

Ok I will have a look. In general it's nothing changed there but I will check it


[blazor] minify dlls

Is it possible to make minified versions for blazor's common dlls, e.g. mscorlib.dll?
Decompilation shows that it contains unnecessary data, e.g. method and parameters infos

Do we really need this large summaries?
Also can we use some minification techniques to make size smaller?
For example shortening variable/method/field/class names.
We can have regular and minified versions and use them relatively regular for developing and minified for production.
If minification breaks reflection or serialization code developer will decide not to use minified versions.
Does linker do things like this?
I was playing with mono.cecil and did parameter renaming for mscorlib.dll methods with minimum lengh names and got some small improvement in size, without affecting anything and blazor continued work as expected.
I believe we can reduce dlls if implement techniques from web world which concentrates on efficient traffic.
I think dlls size was not so important before blazor and because this it never got aggressive optimization, but now because load time is critical for blazor and dlls should be downloaded each time, size needs to be optimized with all possible ways.

We already run the IL linker to do static analysis to strip out unneeded IL. To give feedback on the current behavior of the IL linker please open an issue on the https://github.com/mono/mono repo.

Opened https://github.com/mono/linker/issues/552


not found: value display?

Hello All,
I see a few issues which mention display.html (most recent: https://github.com/jupyter-scala/jupyter-scala/issues/44#issuecomment-173385480). However, in 0.4.3:
display.html("Hello World")

gives:
cmd24.sc:1: not found: value display
val res24 = display.html("Hello World")

Is this a simple fix?

The following worked for me:
publish.html("some <b>HTML</b>")

@mephi42 I don't know how I missed that... Thanks.


Making builds truly reproducible

Fixes #172

Hi just want to provide some a corner case I encounter today:

when installing ca-certificates-java package, I found the end result was /etc/ssl/certs/java/cacerts which is a binary
even using the same .deb packages I would get a different binary each time.
this may be a corner case for this PR: even we change the mtime of all files in a layer, we could end up with different sha because the timestamp is embedded in the file content itself, not the file metadata.


gatts_demo: re-enter advertising after client disconnects

In the existing tree, after a connected client disconnects the device
will never re-enter the advertising state. Additional clients will not
be able to discover or connect to the device. This patch forces the
device back into the advertising state upon disconnection.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks Mike. Sorry for the delay, I've put this fix into our internal merge queue.

Thanks!


feat(frontend): support show all (#3665)

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

SQL commands, functions, and operators
support show config like SHOW ALL.

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You can just remove show all cases Or move show related cases into a new file and only run it in local or distributed mode.
OK, I just remove show all test. It is hard to make it deterministic.


[Doc] Update STREAM LOAD  format

Signed-off-by: amber-create<EMAIL_ADDRESS>Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

@mergify backport branch-2.3 branch-2.4 branch-2.5 branch-3.0 branch-3.1

@mergify backport branch-3.0

@mergify backport branch-3.1


Some question about Cert formation

It is a question not a issue.
For Cert formation, I was a little confused by reading SPDM spec:  1.2.0
The SPDM spec isn't clear for the cert SPDM OID part. I think there are two situation in cert formation.
In the SPDM spec, it may be situation 2.
But in the spec x.509 RFC5280, it may not be allowed for other standard Extensions. It may be situation 1.

situation 2 is correct.
RFC5280 allows extensions defined outside of RFC5280.
refer to 4.2:
Conforming CAs MAY support extensions that are not identified within this specification...

Thanks.  It is very helpful for me.  I will fix other issues with this guide.


Document the configuration of relevant properties when connecting to/from existing message-broker infrastructure

@sabbyanandan commented on Fri Jan 25 2019
As a user, I'm attempting to connect to existing Rabbit infrastructure including the predefined exchange/queue resources; however, I'm unable to determine what properties to enable/disable, so the framework doesn't auto-create them differently.
More background in slack conversation here.
Notes:

@garyrussell suggested adding a new section (perhaps: Using SCSt to consume from existing infrastructure (exchange/queue) that could be useful as a reference.
It might also be helpful to define the requirement first, and follow-up with an example in this section.
Probably also clarify this in the context for both Rabbit and Kafka binders.

@garyrussell commented on Fri Jan 25 2019

Probably also clarify this in the context for both Rabbit and Kafka binders.

There's really no complexity with Kafka since the destination is simply the topic name,  but I suppose it won't hurt to mention that.

Closing this issue. Here is PR that added the Rabbit binder docs changes: https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/pull/240/


could you tag v1.2.182

Could you please tag a version v1.2.182?
I am in the middle of creation of a conan package and it will be a big help :)
https://github.com/conan-io/conan-center-index/pull/7181

Why 1.2.182 specifically? Would the latest version work?

I've created a 1.2.190 tag corresponding to the current release.

Thanks! :)

relates to https://github.com/conan-io/conan-center-index/pull/7193/files

Could you still tag 182?
We would like to have this version as well
related to https://github.com/conan-io/conan-center-index/pull/7225

Done

Thanks a lot!


Multiple inheritance? Mixins?

I'm loving the extends keyword, but in the course of developing a complex project, I really wish I could give a class functionality from multiple sources. Obviously I could do this by extending the prototype manually, but it feels like a hack to mix the extends syntax with JavaScript-style prototype manipulation.
For my purposes, it would be great to be able to say
class A extends Foo, Bar

but I realize that multiple inheritance is a huge headache, so Ruby-style mixins or Scala-style traits would probably be a better solution. The Scala syntax would be especially nice for CoffeeScript:
class A extends Foo with Bar

Obviously with is already a keyword, but its meaning in this syntax is unambiguous.
Of course, this is something that a standard library could do, but it would be much clearer to have something like the above syntax rather than something like
class A extends foo
   # properties...

lib.mixin A, bar

What does everyone else think?

hm, that link on Mixins in the last post is dead now, and this issue is closed but it comes up first in Google for "coffeescript mixins", so incase anyone else ends up here, I'll note the Spine framework has support which you can easily steal as an alternative to the @captainpete workaround.
class Module
  @include: (obj) ->
    throw('include(obj) requires obj') unless obj
    for key, value of obj when key not in moduleKeywords
      @::[key] = value

    included = obj.included
    included.apply(this) if included
    @

and then to use it
helper =
    my_helper_fn: -> 'i'm helping'

class MyClass extends Module
     @include helper

Function::use = (argv...) ->
  for cl in argv
    for key, value of cl::
      @::[key]=value
  @

class A
  a: ->
class B
  b: ->
class C
  @use A,B
  c: ->

i = new C
console.log i

try

I agree that one shouldn't mess with the inheritance chain, but I do think that coffee-script should provide the functionality that Spine does, namely including other classes. Let extends do what it does, but also let me @include EventEmitter :-)
I hope you'll consider this. Thanks

Unless you are creating lots of these objects, the benefits of delegation are not great. It saves a little bit of RAM. The use cases for multiple delegation are few if any. Crockford is recommending we never delegate these days, whatever you want to make of that.
If you're willing to copy over the methods of an object and call that inheritance, you can achieve the same thing, arbitrarily passing an object through any number of constructor functions, using simple closures.
I have a little gist if anyone's interested. The 'library' is 5 lines of code. It was written for students, so it's a bit toyish, but the example of 'super inheritance' is at Line 27.
On the whole, it seems better to wait for proxies to flesh out and revisit. Just my two pennies.

Hi!
Just wanted to bring awareness to a little module I made, which implements multiple inheritance: https://github.com/arximboldi/heterarchy
The interesting thing about this implementation is that, unlike the mixin-based approaches discussed here so far, it supports cooperative multiple inheritance, in a way similar to how Python does it. It has some drawbacks, so I'm unsure it's appropriate for the core language, but it should help pythonistas to import their beloved patterns.
Cheers!


Add support for stream API

Description
Adds support for Cloudflare Stream API
Docs found here: https://api.cloudflare.com/#stream-videos-properties
Note: This does not add support for upload using TUS. It seemed out of scope for this module.
Has your change been tested?
Unit tests have been added for all functions
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Resolves #811

Codecov Report

Merging #959 (d347679) into master (1190d57) will increase coverage by 0.05%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   48.31%   48.36%   +0.05%
==========================================
  Files          96       97       +1
  Lines        9753     9879     +126
==========================================
+ Hits         4712     4778      +66
- Misses       4000     4040      +40
- Partials     1041     1061      +20

Impacted Files
Coverage Δ

stream.go
52.38% <52.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1190d57...d347679. Read the comment docs.

really solid PR! thanks for the effort here. couple of notes added inline for you but we're super close.


Preparing a test database

I think this is done - we have the seed that we can write early models on, the rest is superseded by #9.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter smoothed for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.smoothed
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,md,lg,xl] for accordion at admin/jsonConfig.json/items/statesAccordion
[ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json/items/Information1

:thumbsup: No warnings found
:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 22 Nov 2024 05:47:04 GMT based on commit ae1d669df9b078deccf65b2f5173782b5caf7649
ioBroker.repochecker 3.2.2

@iobroker-bot recreate


Gradle Artifactory plugin fails with Ivy publications on Gradle 4.5+

In Gradle 4.5, the getDescriptorFile method in IvyNormalizedPublication class (part of internal API) was renamed to getIvyDescriptorFile. The TaskHelperPublications class of build-info-extractor-gradle calls that method directly and due to the rename, fails with NoSuchMethodError on Gradle 4.5.

@maxorator,
Thanks for reporting.
We fixed this issue in the latest Gradle Artifactory plugin version 4.7.0.
Here is a link to the commit which resolves this issue: https://github.com/JFrogDev/build-info/commit/f8fd3d32a0a32cb0437dd414cded4c9f6093413e.
We'll appreciate your feedback for that.


Group by filter doesn't work with field string keys

What's going wrong?
When running a group by query with a filter expression providing a string key for in the field returns the following error:
{"error":"executing: executing group by filter for shard 0: Row() error with arg for row: could not convert x of type string to uint64 in Call.UintArg"}
What was expected?
A normal group count response with the results filtered based on the supplied expression, similar to:
{"results":[[{"group":[{"field":"test","rowKey":"y"},{"field":"test2","rowKey":"y"}],"count":1}]]}
Steps to reproduce the behavior

Create an index with string keys
Create a couple of fields with string keys
Add some rows
Run a group by query similar to  GroupBy(Rows(field='test'),Rows(field='test2'), filter=Row(test='x'))

Information about your environment (OS/architecture, CPU, RAM, cluster/solo, configuration, etc.)
Version 1.2.0
Solo server on Docker in MacOS

looks like executor.translateGroupByCall doesn't take the filter argument into account. Should be a pretty easy fix.
Thanks for the bug report @janstenpickle !!!

No problem, thanks for all the hard work!


Error on navigating to "/" homepage route

Thank you for making this library. It's easy to set up and works great. I found one bug when navigating to the homepage shows errors in the console.
Description
In production environment, when navigating from a non-home page route to the home page route "/", the console displays:
Uncaught (in promise) RangeError: Maximum call stack size exceeded
In development environment, when navigating from a non-home page route to the home page route "/", the console displays:
[Vue warn]: Avoid app logic that relies on enumerating keys on a component instance. The keys will be empty in production mode to avoid performance overhead.
I'm not sure what the effects are in Google Analytics, because an event seems to trigger and report to Google Analytics (but I can't be certain, because I may not be receiving all the event data because of this error).
I found two issues pertaining this problem:
https://stackoverflow.com/questions/68100114/avoid-app-logic-that-relies-on-enumerating-keys-on-a-component-instance
https://github.com/vuejs/vue-next/issues/2027
Is VueGtag perhaps watching a whole route or router object to trigger events?
Expected behavior
No errors when navigating to home page, 100% reporting to Google Analytics.
Actual behavior
Errors show when navigating to home page.
This bug may prevent data being sent to Google Analytics, because the function error may crash the process.
Environment

<EMAIL_ADDRESS><EMAIL_ADDRESS>Vue 3
Chrome
macOS

Reproducible Demo

Create a Vue 3 app.
Install latest VueGtag.
Install VueRouter.
Create two routes; one to the homepage "/" and another route.
Navigate from the second route to the homepage.
View console to see error.

createApp(App)
  .use(router)
  .use(
    VueGtag,
    {
      config: { id: 'GA-ID' }
    },
    router
  )
  .mount('#app')

Sorry to hear that, but I do not watch any route changes; I listen to the built-in afterEach callback function provided by VueRouter. I've tried your simple setup with no errors anywhere.