Crash when running tensorflow.python.ops.gen_nn_ops.fused_batch_norm_grad_v3

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
2.11.0
Custom Code
Yes
OS Platform and Distribution
Ubuntu 22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
A bug happened!

Standalone code to reproduce the issue
import tensorflow as tf
import numpy as np
from tensorflow.python.ops import gen_nn_ops
try:
  try:
    with tf.device('/CPU'):
      y_backprop_tensor = tf.random.uniform([4, 10, 10, 2], dtype=tf.float32)
      y_backprop = tf.identity(y_backprop_tensor)
      x_tensor = tf.random.uniform([4, 10, 10, 2], dtype=tf.float32)
      x = tf.identity(x_tensor)
      scale_tensor = tf.random.uniform([2], dtype=tf.float32)
      scale = tf.identity(scale_tensor)
      reserve_space_1_tensor = tf.random.uniform([2], dtype=tf.float32)
      reserve_space_1 = tf.identity(reserve_space_1_tensor)
      reserve_space_2_tensor = tf.random.uniform([2], dtype=tf.float32)
      reserve_space_2 = tf.identity(reserve_space_2_tensor)
      epsilon = -43.999
      data_format = "NHWC"
      is_training = True
      reserve_space_3_tensor = tf.random.uniform([], dtype=tf.float32)
      reserve_space_3 = tf.identity(reserve_space_3_tensor)
      out = gen_nn_ops.fused_batch_norm_grad_v3(y_backprop=y_backprop,x=x,scale=scale,reserve_space_1=reserve_space_1,reserve_space_2=reserve_space_2,epsilon=epsilon,data_format=data_format,is_training=is_training,reserve_space_3=reserve_space_3,)
  except Exception as e:
    print("Error:"+str(e))
  try:
    with tf.device('/GPU:0'):
      y_backprop = tf.identity(y_backprop_tensor)
      y_backprop = tf.cast(y_backprop, tf.float32)
      x = tf.identity(x_tensor)
      x = tf.cast(x, tf.float32)
      scale = tf.identity(scale_tensor)
      scale = tf.cast(scale, tf.float32)
      reserve_space_1 = tf.identity(reserve_space_1_tensor)
      reserve_space_1 = tf.cast(reserve_space_1, tf.float32)
      reserve_space_2 = tf.identity(reserve_space_2_tensor)
      reserve_space_2 = tf.cast(reserve_space_2, tf.float32)
      reserve_space_3 = tf.identity(reserve_space_3_tensor)
      reserve_space_3 = tf.cast(reserve_space_3, tf.float32)
      gen_nn_ops.fused_batch_norm_grad_v3(y_backprop=y_backprop,x=x,scale=scale,reserve_space_1=reserve_space_1,reserve_space_2=reserve_space_2,epsilon=epsilon,data_format=data_format,is_training=is_training,reserve_space_3=reserve_space_3,)
  except Exception as e:
    print("Error:"+str(e))
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-01-22 05:52:28.151968: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-22 05:52:28.716365: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/:/home/nimashiri/anaconda3/envs/cuda11.2/lib/:/home/nimashiri/anaconda3/envs/cuda11.2/lib/
2023-01-22 05:52:28.716529: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/lib/:/home/nimashiri/anaconda3/envs/cuda11.2/lib/:/home/nimashiri/anaconda3/envs/cuda11.2/lib/
2023-01-22 05:52:28.716537: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-01-22 05:52:29.223621: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.228281: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.228421: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.228740: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-01-22 05:52:29.229170: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.229271: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.229359: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.601354: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.601502: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.601600: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:981] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-01-22 05:52:29.601697: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 3521 MB memory:  -> device: 0, name: NVIDIA GeForce GTX 1660 Ti, pci bus id: 0000:01:00.0, compute capability: 7.5
2023-01-22 05:52:30.152358: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:428] Loaded cuDNN version 8100
2023-01-22 05:52:30.154285: E tensorflow/compiler/xla/stream_executor/dnn.cc:887] CUDNN_STATUS_BAD_PARAM
in tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc(5936): 'cudnnBatchNormalizationBackward( cudnn.handle(), mode, &one, &zero, &one, &zero, x_descriptor.handle(), x.opaque(), x_descriptor.handle(), y_backprop.opaque(), x_descriptor.handle(), x_backprop->opaque(), scale_offset_descriptor.handle(), scale.opaque(), scale_backprop->opaque(), offset_backprop->opaque(), epsilon, mean.opaque(), inv_var.opaque())'
Error:{{function_node __wrapped__FusedBatchNormGradV3_device_/job:localhost/replica:0/task:0/device:GPU:0}} cuDNN launch failure : input shape ([4,10,10,2]) [Op:FusedBatchNormGradV3]

</details>

@tilakrayal, could you please check this issue?
I was able to replicate the issue with negative epsilon values(<=-1) in Colab in TF v2.11, kindly refer to this gist. The above issue is not producing errors when the epsilon values are positive or -0. Please find the gist here. Thank you!

not a vuln

Hi @dmc1778
The issue seems to be fixed in recent TensorFlow versions. I have verified the repro code with TF 2.17.1 on Colab T4 GPU, and it now correctly throws an Exception.
Error:{{function_node __wrapped__FusedBatchNormGradV3_device_/job:localhost/replica:0/task:0/device:GPU:0}} cuDNN launch failure : input shape ([4,10,10,2]) [Op:FusedBatchNormGradV3] name:

Please find the attached gist for reference.
Thank you.

Hi@comckay,
I have reviewed the code and made some changes,changed [1] to tf.constant([1]).
It is working fine for me. Please find the gist here for reference.
Thank you!


Cluster-Aware Service Routing is broken in Istio 1.1.1

Describe the bug
I was trying to follow https://istio.io/docs/examples/multicluster/split-horizon-eds/
When I got struck in below step
kubectl create --request-timeout=1m --context=$CTX_CLUSTER1 -f - <<EOF
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: cluster-aware-gateway
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 443
      name: tls
      protocol: TLS
    tls:
      mode: AUTO_PASSTHROUGH
    hosts:
    - "*.local"
EOF

Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling admission webhook "pilot.validation.istio.io": Post https://istio-galley.istio-system.svc:443/admitpilot?timeout=30s: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

I had created the cluster using kops with t2.xlarge instances for master and workers.
Istio seemed to be running perfectly fine
kubectl get pods --context=$CTX_CLUSTER1 -n istio-system
NAME                                      READY   STATUS      RESTARTS   AGE
istio-citadel-68c8d6cff8-gdrzf            1/1     Running     0          38m
istio-cleanup-secrets-1.1.1-hfwlb         0/1     Completed   0          38m
istio-galley-6db4964df6-pz8zk             1/1     Running     0          38m
istio-ingressgateway-cd5df7bc6-6kjgb      1/1     Running     0          38m
istio-pilot-597dd58685-bxgb6              2/2     Running     0          38m
istio-policy-67f66c8b5c-dvk5g             2/2     Running     3          38m
istio-security-post-install-1.1.1-7ph6r   0/1     Completed   0          38m
istio-sidecar-injector-59fc9d6f7d-7z2xs   1/1     Running     0          38m
istio-telemetry-c5bfc457f-wzhnj           2/2     Running     3          38m
prometheus-89bc5668c-d6v5l                1/1     Running     0          38m

Expected behavior
cluster-aware-gateway should have come up fine.
Steps to reproduce the bug
Use KOPS to create k8s clusters with kubernetes version set as 1.11.8.
kops version
Version 1.11.0 (git-2c2042465)
istioctl version
version.BuildInfo{Version:"1.1.1", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989", User:"root", Host:"7077232d-4c6c-11e9-813c-0a580a2c0506", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Clean", GitTag:"1.1.0-17-g2b13318"}
Version
Talked above
Installation
https://istio.io/docs/examples/multicluster/split-horizon-eds/
Environment
AWS
Cluster state
$ tools/dump_kubernetes.sh -z
Fetching debug/configz from pilot
Fetching debug/endpointz from pilot
Fetching debug/adsz from pilot
Fetching debug/authenticationz from pilot
Fetching metrics from pilot
Retrieving kubernetes resource configurations
Retrieving istio resource configurations
Retrieving logs for istio-system/istio-citadel-68c8d6cff8-gdrzf/citadel
tools/dump_kubernetes.sh: line 118: "0" + "15382": syntax error: operand expected (error token is ""0" + "15382"")

This is not working in Istio 1.1.0 either.

everything is working fine otherwise...I checked that mutatingwebhook was enabled too
/usr/local/bin/kube-apiserver
--allow-privileged=true
--anonymous-auth=false
--apiserver-count=1
--authorization-mode=RBAC
--basic-auth-file=/srv/kubernetes/basic_auth.csv
--bind-address=<IP_ADDRESS>
--client-ca-file=/srv/kubernetes/ca.crt
--cloud-config=/etc/kubernetes/cloud.config
--cloud-provider=aws
--enable-admission-plugins=
Initializers,
NamespaceLifecycle,
LimitRanger,
ServiceAccount,
PersistentVolumeLabel,
DefaultStorageClass,
DefaultTolerationSeconds,
MutatingAdmissionWebhook,
ValidatingAdmissionWebhook,
NodeRestriction,
ResourceQuota
--etcd-servers-overrides=/events#http://<IP_ADDRESS>:4002

THis is not cluster-aware private, it is common. You should check why the galley can not called.

THis is not cluster-aware private, it is common. You should check why the galley can not called.

Can you please give me some more info to be able to debug this issue?

Actually, these kinds of gateway virtualservice destinationrule, etc. should be validated by galley(as a validate admission controller) before persisted storaged.  In this procedure, kube-apiserver will call galley, so make sure your kube-apiserver can access galley.

The sample situation happens to me too, my k8s version is 1.13.1 with the istio of 1.1.5, Did you solve this problem? And the automatic sidecar injection failed too, though I have set the plugins as the Kubernetes saying. I just think  it may be the api-server can't access the pod where the galley is. Because the master node has not proxy

I had a similar issue on a GKE cluster and punching a firewall rule to grant masters GKE node access for all tcp ports solved it for me.

This appears to be an environmental issue with our kube-apiserver networking is setup. Please re-open if the problem still persists.


TEST PR to develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 52.488%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/jukebox/jukebox/version.py
4
5
80.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
791

Relevant Lines:
1507

💛  - Coveralls


vendor folder ignore on run

run option to ignore vendor folder
Example:
My software uses a package that I'm developing called X, how do I give priority to the GOPATH not for vendor folder?
This example common in software development.
What version of Go are you using (go version)?
1.8.1
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/avelino"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/y_/dp3lnjh12y9c2xt4hyds9jq80000gn/T/go-build222815123=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

How are you building your software? Can you show the command(s) you use?
There probably isn't much that can be done if the project contains a vendor
folder and that vendor folder contains copies of the packages required to
build the project. That is, apart from deleting the vendor folder after
checkout.
Can you describe the underlying problem you are trying to solve. Maybe we
can suggest a different solution.
On Thu, 18 May 2017, 15:48 Avelino<EMAIL_ADDRESS>wrote:

run option to ignore vendor folder
Example:
My software uses a package that I'm developing called X, how do I give
priority to the GOPATH not for vendor folder?
This example common in software development.
What version of Go are you using (go version)?
1.8.1
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/avelino"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8.1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/y_/dp3lnjh12y9c2xt4hyds9jq80000gn/T/go-build222815123=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/20406, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA9PIAlDL9egz9njTo0dCXtb7Cnn4ks5r69vFgaJpZM4Newo7
.

@avelino
is your main package located under GOPATH?
Vendor works for my project which is under GOPATH.

We have repeatedly made the decision not to add many options to go run, which is intended only for super basic tasks.
For any real development, we expect people to be using go install / go build and running the resulting binary.
I'm going to close this, since I don't see us adding more options. The mailing list might be the best place to discuss alternatives.


-Wall Compliant

Is this pull request associated with an issue(s)?
No
Description
Removes all warnings in compilation.

🚀 [bumpr] Bumped! New version:v0.1.26 Changes:v0.1.25...v0.1.26


[explorer-client] Search function that takes you to page on a Single Transaction

Once we have mock data, we will need a search function on all pages that the user can use to search for details on a specific transaction. Clicking search will take you to a page giving information on that specific transaction.

@Andrew47 , this seems to be done right?


Testing Prop Validator

Hello,
First, thank you for creating avoriaz. While using it, I couldn't find a way to test component prop validators. For example, let's say that I have this component:
myComponent.vue
<template>

</template>

I tried created a test that looked like this:
myComponent.spec.js
  import MyComponent from '../src/myComponent.vue';

  const sinon = require('sinon');
  const consoleWarn = sinon.stub(console, 'warn');

  describe(property', () => {
    it('should be a positive value', () => {
      var wrapper = mount(MyComponent);
      wrapper.setProps({maxValue: -1});
      expect(consoleWarn.calledOnce).to.equal(true);
   });
  });

Does avoriaz have a way to test property validators? If not, it seems like this would be a great addition to this project.

Have you tried passing the props in when you mount the component?
  describe(property', () => {
    it('should be a positive value', () => {
      var wrapper = mount(MyComponent, { propsData: {maxValue: -1}});
      expect(consoleWarn.calledOnce).to.equal(true);
   });
  });

@paranoid-android did the test I posted above pass?

It did. I just got a chance to try it. Thank you so much!


Sanity check on "Detected peer with inconsistent finalized block" warning

Haven't noticed these before. This is on mainnet with Teku 22.5.1.
May 31 21:34:05 metalalbert teku[2479]: 2022-05-31 21:34:05.613 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
May 31 21:36:35 metalalbert teku[2479]: 2022-05-31 21:36:35.994 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
May 31 22:40:05 metalalbert teku[2479]: 2022-05-31 22:40:05.786 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
May 31 22:42:26 metalalbert teku[2479]: 2022-05-31 22:42:26.278 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 01:18:05 metalalbert teku[2479]: 2022-06-01 01:18:05.945 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 01:20:35 metalalbert teku[2479]: 2022-06-01 01:20:35.533 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 03:50:06 metalalbert teku[2479]: 2022-06-01 03:50:06.393 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 04:24:45 metalalbert teku[2479]: 2022-06-01 04:24:45.700 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 04:27:05 metalalbert teku[2479]: 2022-06-01 04:27:05.686 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 04:42:36 metalalbert teku[2479]: 2022-06-01 04:42:36.442 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 04:44:45 metalalbert teku[2479]: 2022-06-01 04:44:45.383 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 04:48:36 metalalbert teku[2479]: 2022-06-01 04:48:36.468 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAkzbihk8sADuWKm3tTRx6CkUhXEFVotiSCraKsEhzVdmig.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 11:39:06 metalalbert teku[2479]: 2022-06-01 11:39:06.524 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 13:27:41 metalalbert teku[2479]: 2022-06-01 13:27:41.134 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 13:30:20 metalalbert teku[2479]: 2022-06-01 13:30:20.931 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 13:35:01 metalalbert teku[2479]: 2022-06-01 13:35:01.363 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 13:37:11 metalalbert teku[2479]: 2022-06-01 13:37:11.018 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 14:36:49 metalalbert teku[2479]: 2022-06-01 14:36:49.054 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 14:39:19 metalalbert teku[2479]: 2022-06-01 14:39:19.838 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 15:21:39 metalalbert teku[2479]: 2022-06-01 15:21:39.424 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match
Jun 01 15:24:09 metalalbert teku[2479]: 2022-06-01 15:24:09.431 WARN  - Detected peer with inconsistent finalized block at slot 31 for peer 16Uiu2HAm3BBjLnti81yEwxWBzXzBAVnZi2KgWv7VNXBCejiUyn2L.  Block roots 0x03dfea04ec332d814a75c768d53196ad3f2b938a6b3927062b35c7a15810c1a1 and 0xbacd20f09da907734434f052bd4c9503aa16bab1960e89ea20610d08d064481c do not match

As far as I understand the code this ought to be comparing my latest finalised block with my peer's. However, it seems always to be comparing the roots for the block at slot 31, which is indeed 0x03dfea04.... (Slot 32 is empty, so the block for checkpoint 1 is at slot 31 rather than 32. Weirdly, 0xbacd20f0... is the block at slot 1 - I can't explain this.)

Is this the expected behaviour?
Why don't we drop this peer? If it's syncing or something, I probably don't need to hear about it in my logs.
Why is the finalised root we are using coming from our local slot 1?

Everything is running fine and my latest finalised checkpoint is 123109 as of writing. Just curious as to whether this check is doing what it ought to be doing.

This was discussed during planning, I think it's in a good place to close now that the message is clearer, but it does appear that the peers were correctly dealt with...


services/horizon/internal/actions: Remove inappropriate use of context in ingestion endpoints

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
Commit 91619975f99a3e8ffb74da86f411c1dbb8254d7a used a request context to ensure
that all queries to the horizon database from ingestion endpoints were wrapped
in a repeatable read transaction.
This commit refactors the ingestion endpoints to acheive the same effect without
using a context to store a request scoped database session.
See https://github.com/stellar/go/pull/1847#discussion_r335975388 for more background on the motivation for this change.
Known limitations & issues
There is a some extra boilerplate compared to passing the db session via the request context

I quickly checked the PR (will do a full review later if @tamirms and @leighmcculloch feel strongly about it) and I think the use of context in 9161997 is actually correct. The DB connection/transaction is request scoped after 9161997 and I think this is exactly the use case of context. If we ever need to make an extra query in another middleware in the future we'll have to do refactoring again. And as you noticed it requires some extra factories to build actions and we wanted to avoid boilerplate code in the new design.
It would be a different story if we were passing a connection pool that's shared by all the requests (like we did before 9161997).

@bartekn I understand your point of view. I'm not certain that this PR is significantly better than the old code given the added boilerplate.
Another option would be to call historyQ, err := repeatableReadSession() and defer historyQ.Rollback()  in each of the handlers. This solution still has some boilerplate.
I can't think of a way to completely eliminate the boilerplate code.

@tamirms On first glance for someone who hasn't read this code before the changes definitely appeared quite complex. But after looking through the change this is really just moving existing logic around. I don't see a lot of new logic being added, what's the boilerplate you're referring to?

My understanding is that for each action we need an extra function that creates a transaction. The reason we decided to rewrite actions is to remove a need for duplicate code so we try to avoid it now if possible.

@bartekn The dependency (DB connection) is limited to this request, but not everything limited to this request belongs in the context. It's still a required dependency being injected. The code will break without it and we should make it explicit that it is needed either by including it in a function signature, type constructor, or as a field on the handler's type. Putting it in the context obscures it from view and it's a lot harder to keep track of what the dependencies of our code are if they aren't explicit.
There are a few good blog posts on this, my favourite probably being this one:
https://peter.bourgon.org/blog/2016/07/11/context.html
But also, this isn't a hard Go rule we're breaking. We can use context in any way we want to, it's a tradeoff. Is the convenience of passing the dependency around using context worth the tradeoff of reducing the clarity of the dependencies in our code? I don't think so, but you might disagree.

I understand the reasoning here and I'm for dependency injection, I advocated several times to use automatic dependency injection (something like facebookgo/inject) for all services in Horizon. However, I can see several problems with using injection here:

Ideally, DB transaction should span across middlewares and the handler so that all DB queries that happen along the way are using the same DB snapshot. It works here but if we move middleware that starts a transaction to the parent package and use the standard middleware API (http.Handler -> http.Handler), the only way to pass a transaction to the next middleware is by using context. In the article shared, they are passing the shared DB connection, not a per request transaction.
If we're injecting history.Q we should also inject logger but it requires some larger refactoring. We create logger using support/log.Ctx method in many places, if we remove this we'll lose information about requests where logger is not passed directly.
Again, boilerplate code. Having to remember to add some extra code per action is prone to errors. We could use go generate but it's also one thing we wanted to avoid in the new design (see internal/main_generated.go file).

Is it fine for you if we think about it more and decide what to do? I think we should really try to avoid another rewrite of actions package in the near future.

I advocated several times to use automatic dependency injection (something like facebookgo/inject)

If we are considering automatic dependency injection, we should evaluate https://github.com/google/wire which does compile time dependency injection instead of injection using reflection.

If we're injecting history.Q we should also inject logger

I don't think this is a fact. Is log.Ctx() is resilient to context not containing the logger. If something is not a required dependency, and not core to what the code is doing, then I think we can put it in the context if it relates specifically to that request. The danger arises when our requirement dependencies are hidden and implicit, rather than explicit and obvious.


Result form: Visual refinements

Suggestions for visual refinements to the Result form, plus a few details carried over from #808.
General

[x] 1. It's feeling a bit crowded -- add more padding between the edges of the form and the content?
[ ] 2. Would like to see the Evidence section set off more from the rest of the form -- the gray on gray is pretty subtle. Ideas: Make the form background white and leave the Evidence area gray, or leave the form background alone and make the Evidence area white to increase contrast.

Form field order

[x] "Submitted by" should be after Project.

Evidence section

[x] 1. Swap the order of the two fields -- first link, then Record name.
[x] 2. I'd like to see the "Browse Google Drive" link either right aligned (see below) -- or perhaps indented a bit if you prefer to keep it left-aligned -- to more clearly signify that it's a sub-option of "Link to file or folder". From original mockup:

[x] 3. View button could use a bit of horizontal padding. Here's how it looks at the moment:

My attempts as styling:

I was unsure what colors to use to increase contrast.

@KennyMonster

Can you please right-align "Browse Google Drive" as shown in my mockup snippet above? (I thought indenting might work just as well as right-aligning, but I was wrong... I think it looks awkward and unintentional.)

Let's try changing the Evidence area's background to white instead of the slightly darker gray.

Can you add more padding above "Result"?

@axoplasm Just want to check that you two are not simultaneously styling this form. I know you were changing the "Submitted by" treatment to plain text, not sure if you were doing other stuff as well?

@KennyMonster I can take a look at this tomorrow. I'm trying to establish a repeatable pattern for things like the background of nested fieldsets. So changing it here means changing it elsewhere

Regression watch: Let's make sure the validation shows up under the right field, as per #1164 -- now that we've flipped the order of the two Evidence fields.

One more thing to be mindful of with regards to the "Browse Google Drive" link -- validation weirdness:

This further strengthens my preference to right-align the link as a way to differentiate, rather than indenting...

For a variety of reasons we are limited in where that "Browse Google Drive" link should go. For example, here's how it will look when it's right-aligned (and with an error condition):

How about this? It also has the advantage of keeping the browse button in the tabfocus flow in case I'm the type who tabs between form elements.

Here's where we're at this form:

I used the btn-link style with an icon for Google drive and pushed it to the right of the "view" button. That way "view" is tied directly to the URL field (i.e. "view this URL") and hopefully the Browse Gdrive button subtly looks like "feed this URL field"
I fiddled a lot with the background for the nested evidence field. White background had the dual effect of washing out the form elements (which I like to "pop" from the background) + made that section visually too hot. But the slightly-darker gray was too much like the background gray…yet if I made it any darker it also got too visually hot!
So we have the standard border for a card element. This is straight out of Bootstrap I guess.

…and error states:

QA Verification Complete

Status: Deploy Ready

[ ] Validation is present, referenced from #1185. Validation is not real time, but on save, will display.
[ ]  Browse Google Drive is on the right, and opens drive/team drives accordingly when clicked.
[ ] Link field occurs BEFORE name field
[ ] View button padding increased

Media Verified:


Shader nodes troubles

While working on the NewShader Wizard these issues surfaced.
Am I doing something wrong?

[ ] ComputeFX:
Wrong name:

[ ] DrawFX
Wrong name:

[ ]  ShaderFX:
Node doesn't appear at all:

[ ] EmptyShader:
Node doesn't appear at all:

1 & 2 is by design I think. 3 no idea, 4 by design - there’s no factory kicking in to create a node out of it. But you can still use that shader inside your shader files.


Extensible workflow metrics definition and validation

Provide the ability to validate workflow metrics (in support of workflow transitions) via external APIs.
See data curation workflow

Essentially superseded by the new model of workflow state-transition validation using JSON schemas.


lib/options: introduce "prime" fn variants (alt API)

This PR adds new variants for all low-lever option factory funcs (mkNullable, mkNullOrOption, etc), as well as a handful of higher-level factories (mkAttributeSet, mkAttrsOf, & mkListOf).
This is done so that we have easy access to the underlying lib.mkOption attributes, such as example.
All attributes are passed through blindly, unless they are intentionally modified along the way.
Currently this PR doesn't make any effort to document required arg-attributes.
I made (more or less) every function its own commit because I needed to use git bisect.
This will also make it easier to drop/revert any specific function if we decide it's overkill to have a prime variant of it.
I'll happily squash once we're ready to merge - how would you like the history structured?
Unrelated change: combined mkDesc and mkDefaultDesc into a single function, since mkDefaultDesc was not really intended to be used directly. The same functionality can be achieved by passing an empty description to mkDesc.

I'll happily squash once we're ready to merge - how would you like the history structured?

I don't think that a squash is necessary. I am fine with one commit per function.

Unrelated change: combined mkDesc and mkDefaultDesc into a single function, since mkDefaultDesc was not really intended to be used directly. The same functionality can be achieved by passing an empty description to mkDesc.

Makes sense indeed.

My opinion on this quite mixed.
On the one hand, I find it quite appealing to get those new helpful functions.
At the same time, this "bloats" (maybe a bit too strong of a word) our already quite heavy helpers function set. I am afraid that this could "scare" even more potential new contributors. But this is just a feeling.
So,  no strong reject from my side. I would be curious to see what @traxys thinks about that.

At the same time, this "bloats" (maybe a bit too strong of a word) our already quite heavy helpers function set. I am afraid that this could "scare" even more potential new contributors. But this is just a feeling.

In principal, I don't think we should be afraid of growing helpers. Although if it does grow larger, we might consider putting less stuff at the top-level (same principal as https://github.com/NixOS/nixpkgs/issues/266103). If we avoid adding functions for this reason alone, we will end up making our lives more difficult in the long-run.
I think the helpers library becoming intimidating is best addressed via documentation, examples, and guides. In particular, it may be nice to have automated docs similar to the Nixpkgs Manual, Noogle, etc.
That said, if there are specific functions that are so simple and/or "single use" that it makes no sense to have a prime variant, we can drop them on a case-by case basis while reviewing this PR (or even revert them after it's merged).

If we avoid adding functions for this reason alone, we will end up making our lives more difficult in the long-run.

Sure.

I think the helpers library becoming intimidating is best addressed via documentation, examples, and guides. In particular, it may be nice to have automated docs similar to the Nixpkgs Manual, Noogle, etc.

Definitely true.

That said, if there are specific functions that are so simple and/or "single use" that it makes no sense to have a prime variant, we can drop them on a case-by case basis while reviewing this PR (or even revert them after it's merged).

I agree. Also, even though we export the helpers publicly, I don't think we should be too worried of breaking users' workflow when changing them. mkRaw is probably used by some people, but apart from this, I doubt many are used outside the project. Especially the option declaration stuff.

Yeah I don't really have a problem with a growing number of helpers, as long as we know which one to apply


Update installation instructions

Updated installation section.

-----------------------------------------

Wouldn't this additional/specific information be more appropriate in https://fluent.docs.pyansys.com/version/stable/getting_started/installation.html ?
I think the main GitHub readme should probably tend towards being leaner and only containing necessary or basic information
In fact, should we also remove the whole "for developers" section from the main GitHub readme, as it is rather specific? We already have a "for developers" section in the installation page I mentioned above, that is probably a more appropriate location for this information.

pip install git+https://github.com/ansys/pyfluent.git will pull the files from git repo and compile the package from them. The installed package won't have the generated files from codegen, so we should not recommend it for non-developers.
I'd avoid recommending pip install git+https://github.com/ansys/pyfluent.git in general. For developers, starting from a git clone is quite standard.


validation of strong password

currently, it accepts even weak password, considering the nature of application, users has to have strong passwords

I wish to work on this.  Will anyone assign it to me?

currently, it accepts even weak password, considering the nature of application, users has to have strong passwords

Hi @Nirbhay97 , do you want to work on this issue or I assign @Swetha-Baskaran .

@srivastavaritik Hey Ritik, I have reviewed the entire repository and I am interested in working on strengthening password authentication. Since I have prior experience in this field, I am confident that I can handle this project. I would like to showcase my potential in this area.

hey ritik
i will be working on this, thats why i created the issue
nirbhay
On Sat, 20 May, 2023, 6:31 pm Ritik Kumar, @.***> wrote:

currently, it accepts even weak password, considering the nature of
application, users has to have strong passwords
Hi @Nirbhay97 https://github.com/Nirbhay97 , do you want to work on
this issue or I assign @Swetha-Baskaran
https://github.com/Swetha-Baskaran .
—
Reply to this email directly, view it on GitHub
https://github.com/srivastavaritik/Extraspace-Cloud/issues/57#issuecomment-1555906978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT42COC5UNLLP3Y2N5JEIK3XHC6CPANCNFSM6AAAAAAYIV35P4
.
You are receiving this because you were mentioned.Message ID:
@.***>

hi @srivastavaritik , i will be working on this issue, kindly assign this to me, i created this issue for this reason only.
regards

please assign it with gssoc label itself. thanks


Can you detect when a slide is changed?

This doesn't seem to be any events for when slide is changed?

The swiper instance is available on the component https://github.com/JayChase/angular2-useful-swiper#accessing-the-swiper-instance. Please see the swiper documentation for the events available.


add: function to creating rational from string

[Current coverage][cc-pull] is 29.76%

Merging [#21][cc-pull] into [master][cc-base-branch] will increase coverage by 0.49%

File avutil/avutil.go was modified. more

Misses -2
Partials 0
Hits +2

@@             master        #21   diff @@
==========================================
  Files             4          4
  Lines          2379       2389    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            696        711    +15
+ Misses         1683       1678     -5
  Partials          0          0

Powered by Codecov. Last updated by [bcb50d4...a89fdd7][cc-compare]
[cc-base-branch]: https://codecov.io/gh/imkira/go-libav/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/imkira/go-libav/compare/bcb50d43573da62c44cb468c228654abe756b067...a89fdd791b99fbee464b4b0d423a9dccd9f9b4d4
[cc-pull]: https://codecov.io/gh/imkira/go-libav/pull/21?src=pr

Thanks!


not able to run via Jenkins pipeline

i have try to run via pipeline from external Jenkins
docker run -e project_id=1 -e galloper_url=http://carrier-mysite.com -e token=XXXXXX getcarrier/control_tower:latest --test_id=5bb0e46b-0788-406e-933b-8abc78b06ec6
is there any documentation on how to do it

is there any galloper API which I can call for to run the test

@tokarthik the command looks right. Could you share logs from control_tower container in Jenkins?

have fixed the docker permission issue using the below command , I am sharing here it will be useful for others sudo groupadd docker sudo usermod -aG docker $USER
Run the following command or Logout and login again and run (that doesn't work you may need to reboot your machine first)
`$ newgrp docker
`
@hunkom this is the error

The error occurs after test execution, when control-tower container is trying to process jUnit report. Seems like you have to mount Jenkins workspace to the container. By default, jUnit report is saved in /tmp/reports directory in the control tower container.

i am trying to mount
`
pipeline {
agent { label 'Jenkins-Slave-2' }

stages{

    stage("Env Variables") {
        steps {
            sh "printenv"
        }
    }
stage('Tests') {
		parallel {
			stage('Regression') {
				steps {
					echo "Assuming good"
				}
			}
			stage('Performance') {
				steps {
					script {
						def dockerParamsString = "--entrypoint=''"
						def params = [
							"-t",
							"-e project_id=1",
							"-e galloper_url=http://xxxx.carrier.net",
							"-e token=-ZPCMkYaBBEIiaOyyQsmKBDD1eQ3Kjy1c",
							"-v ${env.WORKSPACE}/:/tmp/reports/:rw"

						]
						for (param in params) {
							dockerParamsString += " ${param}"
						}
						echo "${env.WORKSPACE}"
                        docker.image("getcarrier/control_tower:latest").inside(dockerParamsString){
                            echo "Starting job"
                            sh """run --test_id=5bb0e46b-0788-406e-933b-8abc78b06ec6 -p ${env.WORKSPACE}/reports"""
                        }
					}
				}
			}
        }}
}

}`

Did you cancel the test from galloper? If so, did you click Cancel button on the reports page or Trigger post processing button? From the control-tower logs I can see that "Test was canceled".

Tried the below code and worked  but the JUNIT file created with no reuslt
`
pipeline {
agent { label 'Jenkins-Slave-2' }

stages{

    stage("Env Variables") {
        steps {
            sh "printenv"
        }
    }
stage('Tests') {
		parallel {
			stage('Regression') {
				steps {
					echo "Assuming good"
				}
			}
			stage('Performance') {
				steps {
					script {
						def dockerParamsString = "--entrypoint=''"
						def params = [
						    "-t",
							"-e project_id=1",
							"-e galloper_url=http://carrier.taasmeter.net",
							"-e token="XXXXXX",
							"-v ${env.WORKSPACE}/:/tmp/reports/:rw"
						]
						for (param in params) {
							dockerParamsString += " ${param}"
						}
						echo "${env.WORKSPACE}"
                        docker.image("getcarrier/control_tower:latest").inside("${dockerParamsString}"){
                            echo "Starting job"
                            sh """/usr/local/bin/run --test_id 5bb0e46b-0788-406e-933b-8abc78b06ec6"""
                        }
					}
				}
			}

        }}
}
post {
    always {
        step([$class: 'JUnitResultArchiver', testResults: '*.xml', healthScaleFactor: 1.0])
        publishHTML (target: [
                allowMissing: false,
                alwaysLinkToLastBuild: false,
                keepAll: true,
                reportDir: 'coverage',
                reportFiles: 'index.html',
                reportName: "Junit Report"
        ])
    }
}

}`
Seems like an issue with JUnit report creation

@hunkom is there any settings we need to do get the junit test report

@tokarthik jUnit report is created based on thresholds. You can set thresholds for each test in Galloper.

got it thanks

I will setup and test it
thanks @hunkom

working fine thanks @hunkom


UI Suggestions

Hope you don't mind that I'm not making separate issues for each item!

White app bar text is very hard to read over the light green background.
On my device (Galaxy S7) most text is a bit too small, since the font is harder to read than standard fonts.
Create vehicle screen slots should have left padding (and same with cost on the Add Upgrade/Weapon screens).
Dropdown button items should have increased padding so users don't tap the wrong item.
The Add Weapon/Upgrade selection items scrollbar should take up the whole screen.
Some text (points cost and weapon mount direction) don't use the custom font, and look a bit out of place.
Adding more than 2 weapons or more than 4 upgrades hides the rest behind a scrollbar that was hard to find.

Thank you for those sugestions. I will try to improve the UI as soon as I get some free time.


Supporting warning and success validation on form fields

Feature Request
Support for warning and success validation on form fields
Problem description
We have a form where we are doing validation at both the form and field levels, but I can only show warnings and successes at the form level. It would be good to be able to warn users that a field is highly suggested, but not mandatory, for example.
Proposed solution
Support warning and error props/children for Form.Input, Form.TextArea, etc... in the same way we can pass in error={content: 'an error'}
I would love to work on this, but I am a new contributor, so I'm not sure how "beginner friendly" this feature would be.

@k-vosswinkel thank you for your report!
This is likely out of the scope for this project. SUIR provides a library of form components, but we are not opinionated about the tools in which these components are used. SUIR can be used with final-form, formik, redux-form, etc. By separating implementation concerns from the form components themselves, we leave more flexibility for people to make choices about what tool best suits their needs.
In projects where my organization uses SUIR, we have reusable components that are API wrappers around SUIR form components where we can drop them in to one of the above mentioned systems. I'd recommend starting there. If you're unsure where to start, a good place to look for help is Stackoverflow.


eclipse-temurin:17-jre-alpine vulnerabilities

eclipse-temurin:17-jre-alpine image contains multiple old vulnerabilities, is there any plan to address them in the near future? when can expected to get a patched version?
vul scan taken by trivy scanner.

The base layer gets updated by DockerHub, you can also tdnf update in the mean time.

@karianna  Already did it here, I was referred to adoptium.
See - https://github.com/docker/roadmap/issues/675

@zopahima As you can see in DockerHub, the last alpine:3.19 was built 5 months ago, and the image eclipse-temurin:17-jre-alpine you're pointing to was built after that using the latest 17.0.11+9 version.
So unless there's an update to alpine 3.19 or a new openjdk version, the image is not getting updated.
Perhaps the folks at Alpine could see this and trigger a bump on 3.19, give them a try.

@karianna Already did it, I was referred to adoptium. See - docker/roadmap#675

I think that's a different place to DockerHub - but I appreciate that this is frustrating, we need a better round robin policy here.

@omni-htg Thanks!! Where can I track alpine merges into temurin? How can I track when it gets into DockerHub?


It can't be installed with Laravel 9

Laravel 9
Php 8.1
composer require output:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laravel-json-api/boolean-softdeletes[dev-develop, v1.0.1] require illuminate/support ^8.0 -> found illuminate/support[v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.
    - laravel-json-api/boolean-softdeletes v1.0.0 requires laravel-json-api/eloquent ^1.0.0 -> found laravel-json-api/eloquent[v1.0.0-alpha.1, ..., v1.0.1] but the package is fixed to v2.1.1 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - laravel-json-api/boolean-softdeletes 1.x-dev is an alias of laravel-json-api/boolean-softdeletes dev-develop and thus requires it to be installed too.
    - Root composer.json requires laravel-json-api/boolean-softdeletes ^1.0 -> satisfiable by laravel-json-api/boolean-softdeletes[v1.0.0, v1.0.1, 1.x-dev (alias of dev-develop)].

Hi! Yes that's because we're waiting for the tenantcloud package to be updated for Laravel 9. Unfortunately there's nothing I can do until they update their package.

@lindyhopchris TenantCloud has merged the PR to support Laravel 9.

Thanks. I should have time to look at this in the next day or two.

Tagged as v1.1.0


Crisis lex integration

This pull requests allows crisis lex topics to be pulled based on siteType from azure blob storage into Cassandra using datastax nodejs-driver.
See /resolvers/Settings.js: createOrReplaceSite for most of my changes.
I created a temporary TopicsSchema so that I could make graphql /get and /list queries for topics. If there is a change to the TopicsSchema, we will need to update CassandraTableStorageManager.prepareInsertTopic to account for the schema change.
One more major change was the addition of:
const Promise = require('bluebird');
const azure = Promise.promisifyAll(require('azure-storage'));
I felt that changing it from cb style to promise style made the code a little easier to read.
Another minor addition was mocha unit tests. They definitely can be improved with mocks, stubs, etc.
Another note: I was able to insert topics into my local Cassandra cluster.
I added some environment variables to my FortisEnv.sh, so you might want to as well:
BLOB_STORAGE_CONNECTION_STRING
CASSANDRA_KEYSPACE
CASSANDRA_CONTACT_POINTS
Pending:

add appinsights
use sinon in unit tests
finalizing options for Cassandra client

Questions

createOrReplaceSite takes two arguments (args, res). What is res?

added TOPIC_SEED_CONTAINER to env, so I didn't have to include container as a parameter in the /get and /list

Going forward can we please split out general refactoring effort(eslint related) and new functionality(cassandra driver) into separate PR's and GH issues. Feel free to breakout broader sprint issues into more prescritive tasks.


Can't see menu items when provide bindings for "/post_menu" location

Try to add post menu for app but can't see any new menu items on client.
When I add bindings for commands, this work as expected.
When execure /apps debug bindings <myapp>, I can got correct bindings.
Use server version 7.2.0 and apps plugin version 1.1.0.

Sorry for the noice, I found the Item in menu, but can make only top level items. When I try to add sub-bindings no submenu appear. And when I click to top level item I'vie got system message: "This binding is not properly formed. Contact the App developer.". Submenus not supported? I can't find any docs about it, only some hints about this ability.

No, submenus for post actions are not supported. They are tricky to get right on mobile and have caused CSS issues in the webapp. I don't see them being introduced in the near future.


ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints.

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.16.1
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.1
Description
I have used this msal-react library for few months already. Today I tried to logout of my application and login again. For some reason it didn't work anymore. It cannot retrieve the endpoints anymore from the .well-known/openid-configuration endpoint, even though when I browse to the same address "https://login.microsoftonline.com/{tenant_id}/v2.0/.well-known/openid-configuration" I see the endpoints...
Edit:
Logging in locally on my "npm run start" it doesn't work.
On the production website logging in works for me. This production website is hosted on a S3 bucket from AWS. But when trying to login on my mobile on the production website, it doesn't work, I have the same error. My colleague's laptop can also not login on the production website.
Error Message
ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://login.microsoftonline.com/{tenant_id}/v2.0/.well-known/openid-configuration
    at ClientAuthError.AuthError [as constructor] (vendors~main.chunk.js:13728)
    at new ClientAuthError (vendors~main.chunk.js:13962)
    at Function.ClientAuthError.createEndpointDiscoveryIncompleteError (vendors~main.chunk.js:14010)
    at Function.<anonymous> (vendors~main.chunk.js:8799)
    at step (vendors~main.chunk.js:7819)
    at Object.throw (vendors~main.chunk.js:7750)
    at rejected (vendors~main.chunk.js:7712)

Msal Logs
No response
MSAL Configuration
msalConfig = {
  auth: {
    clientId: {client_id},
    authority: "https:/login.microsoftonline.com/{tenant_id}",
    redirectUri: "http://localhost:3000",
  },
  cache: {
    cacheLocation: "sessionStorage",
    storeAuthStateInCookie: false,
  }
}

Relevant Code Snippets
const loginRequest = {
  scopes: ["{client_id}/.default"]
};
const msalInstance = new PublicClientApplication(msalConfig);
msalInstance.loginRedirect(loginRequest).catch(e => console.error(e));

Reproduction Steps

Define the msal config.
Create the code snippets inside index.js and create a button with onClick loginredirect inside the MsalProvider.
Click on the button and it logs that error.

Expected Behavior
I would expect it to give me a login screen and where I will be redirected to my application.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Firefox, Safari, Other
Regression
No response
Source
External (Customer)

Hi @maxcww, could you email me the fiddler trace of both the working and broken situations of this, to best understand the issue.

Hi Samuel,
I have downloaded Fiddler and tried to record the internet traffic. I hope it is useful, I did remove some traces that seemed to be from different internet traffic not related to my application.
I have further no idea how to read those traces so I couldn’t debug it myself.
Best,
Max Wong
On 4 Aug 2021, at 18:38, Samuel Kubai<EMAIL_ADDRESS>wrote:
Hi @maxcwwhttps://github.com/maxcww, could you email me the fiddler trace of both the working and broken situations of this, to best understand the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/AzureAD/microsoft-authentication-library-for-js/issues/3924#issuecomment-892805978, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXA5VSPCNHLOECMDE7VEKTT3FUH5ANCNFSM5BQXGLXA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

Hi Samuel, I think I found the problem. I had the login button wrapped in a  and by removing this, the login works successfully.


Receiving an attachment using Facebook Bot

I'm using NodeJS and I managed to get my Bot working with regular messages on Facebook Messenger (plain text).
However, when I send my location, picture or any sort of attachment, I don't get any messages on my listener, until it fails with :
at=error code=H12 desc="Request timeout" method=POST path="MY_PATH" host=MY_HOST request_id=XXX  fwd="XXX.XXX.XX.XXX" dyno=web.1 connect=1ms service=30002ms status=503 bytes=0
Is this some sort of bug? One of the main features of my application involves receiving the user's location.
Thanks!

Facebook Messengers API currently does not pass location or attachments to bots.

Facebook messenger API does not support LOCATION, it does support sending of attachments (image/audio/video) and random http urls

When i tested their API, I managed to send my location as an attachment tomy Bot on the Messenger app for Android and I received, on my webhook, a message which had as an attachment a latitude & longitude JSON object with my location...

can you share what the JSON for that, because their documentation doesn't say anything about it

according to me sending location from messenger --> Server is possible but reverse is not possible  and  facebook docs doesn't specify send attachment of type  location

here is the response you will get on your server when you send location from messenge
{"mid":"mid.1468518839177:f227be07c85ec7cd84",
"seq":592,
"attachments":[
{
"title":"foo's Location",
"url":"https://www.facebook.com/l.php?u=https%3A%2F%2Fwww.bing.com%2Fmaps%2Fdefault.aspx%3Fv%3D2%26pc%3DFACEBK%26mid%3D8100%26where1%3D28.474949%252C%2B77.040625%26FORM%3DFBKPL1%26mkt%3Den-US&h=iAQHsdjXF&s=1&enc=AZPhoqUogTWmjpaP3hWyoL_gDwWo_3xDBQO__6z1oPPk2ST8q3qdIQQOciFDd5cZ43SNBqn386dX7ZOg8xyeMz3wabQgOsrse32YbeZN0F1GkA",
"type":"location",
"payload":{"coordinates":{"lat":28.474949,"long":77.040625}}
}
]
}
there is a trick to handle this problem by sending generic message follow this link
How to send location from Facebook messenger platform?

I think that's right, BTW: we should be mapping the location information into the Entities[] array as a GeoCoordinate object.


Scrolling for pos_mobile (pos_mobile_restaurant) on iOS

We need someone who can resolve scrolling issue for pos_mobile (pos_mobile_restaurant) on iOS:
Actual behavior:
The scroll bar is always displayed even if we don't scroll

Expected behavior:
The scrollbar is hidden in the interface. When sliding, the scroll bar is displayed. After the slide is finished, the scroll bar is hidden again.

Actually, the same behavior on Android

Ok, the situation is as following

Desired behavior is not possible on Android
For iOS it can be done via -webkit-overflow-scrolling. But it has problem with rendering (hidden elements are not fully rendered after scrolling to them)

@ilmir-k can we pay out the bounty for @GabbasovDinar ? It is fixed?

@yelizariev yes, we can. It has been fixed.


Touch affordances

Had a quick play on an Android phone and wonder how touch affordances could work.
There's a question of when to enable them, I'm not sure if there are APIs that help find the size of the screen, which might help.
In the case of sliders for instance, having a larger UI for it that appears when you touch the screen could be one place to start.

Yeah... for small screen devices we need a completely different UI.
I implemented the "bare minimum" for now and kind of ignored all the rest until the feature set is complete.

I was surprised at how usable some of it is TBH.   It's definitely possible to press the larger icons, though maybe two columns of them isn't ideal.
You're right that piecemeal isn't ideal... this is a bit of fluffy ticket anyway :)

For reference here's a phone screenshot (smaller, in reality):

I can use it on a phone with the current UI size, what I find fustrating (and I don't know if it's a bug, that's why I'm sharing) is that I can't touch-drag to move the slider or color selector on the Color side-pane . I mean: I have to touch the exact spot where the color I want is, if I touch and drag, I drag the whole panels group.
This could be solved by adding HSB sliders below the pane, as all the other sliders I've tried work fine.

In portrait orientation it might make sense for the icons to be along the bottom (especially on a phone as that's nearer your thumbs).
Touch is definitely a bit more than button size and placement, but this might help as an incremental improvement.


Reimplement path file management system.

This rewrites the path file management system from scratch to use a mechanism that is closer to how OpenJDK Javac works under the hood.
The implementation works by storing a map of locations to container groups in the file manager.
The file manager (part of the JSR-199 compiler API in the JDK) has a one-to-many relationship with container groups. Each container group has a one-to-many relationship with containers. Each container has a 1-to-1 relationship with some form of Path-like object.
Each container group can supply a classloader, and provides some form of access to "containers". The container group implementations fall into three categories:

Package-oriented - these contain a list of containers, designed for regular packages.
Module-oriented - these contain a mapping of module locations to package-oriented container groups. The purpose of these is to store locations that contain JPMS modules. Module-oriented container groups cannot contain files outside of the nested package-oriented groups.
Output-oriented - these can contain both package-oriented containers and a mapping of modules, just like module-oriented. This implementation is designed to house output locations such as SOURCE_OUTPUT and CLASS_OUTPUT which may contain a single package tree or a collection of JPMS modules.

Each container group holds containers. Containers are wrappers around single path-like objects, and provide an interface for consistent read, write, and list operations on the file tree associated with the path. There are currently three implementations of container:

Directory container - this holds a reference to a Path that is on some file system.
RamPath container - this extends the Directory container by also holding a reference to the RamPath associated with the Path. This enables holding a strong reference to RamPath objects to prevent premature garbage collection. The mechanism is needed since RamPath objects hold an in-memory JIMFS FileSystem internally that gets closed once the enclosing RamPath is garbage collected.
JAR container - this holds a ZipFileSystem that has Multi-Release configuration enabled. The purpose here is to allow reading a JAR or WAR of files. JAR containers do not support opening files for output, and are "mounted" as read-only. A JarFileSystem is not used for this since the OpenJDK JAR filesystem provider implementation can not open more than one copy of the same ZIP-like archive at once, which prevents tests using JCT from running safely in parallel. Conversely the ZipFileSystem provider that JarFileSystem extends does not appear to have this limitation. This entire mechanism replaces the need to create temporary symbolic links in the default system FileSystem to work around the JarFileSystem constraints explained here.

A side effect of supporting Multi-Release in the MANIFEST.MF is that we have to hold the target compiler version number string, which effectively prevents this entire mechanism from being constructed until this release version is known. This means that the existing process for adding new paths to a Compiler implementation will have to store all paths and locations in a separate structure, only registering them fully once a FileManager is created in the SimpleCompilationFactory.
The majority of the "old" paths implementation will be removed entirely as part of this PR.

Codecov Report

Merging #33 (8d0d8f8) into main (8d0d8f8) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 8d0d8f8 differs from pull request most recent head 4aaf5be. Consider uploading reports for the commit 4aaf5be to get more accurate results

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   70.61%   70.61%
=======================================
  Files          42       42
  Lines        1746     1746
  Branches      108      108
=======================================
  Hits         1233     1233
  Misses        474      474
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0d8f8...4aaf5be. Read the comment docs.


[Mockup] Create Sell book

Page dedicated to register a new book and exchange

This page has some details that should be taken into account:

The user has 3 options to "exchange" the book:

Sell
Exchange
Auction

If hasn't yet the book on system the user must register first
If already have, then the user can improve the information about
And we have to think how the user can update the information without misrepresenting it

It's not up to the mockup to resolve such things as getting and improving info.


make sure extra records dont get dropped

@nlf @janeczku one more proof that we need tests :) At least for providers part. Can be done by:

implementing simulator clients for each provider
generate static dns records content for each simulator client
positive test for provider.getRecords - validate that the data returned is aligned with the static dns records content
positive/negative tests for add/remove records - add record that never existed, try to add duplicated record, remove non-existing record, remove existing record, etc

I'm open for other test design solution/suggestions.

As for the PR itself, LGTM

@alena1108 As Konfuzius said: Writing tests proofs the most valuable when you haven't done it. :hushed:
I actually did quite intensive manual testing of the methods in the Cloudflare provider by implementing them in a command line package and writing/querying to/from the live API. So i am quite confident at this point. But i still see the need for written tests while the code may evolve in the future. I think something in the line what you proposed makes a lot of sense. I may add that once we have a simulator client for one provider it should be easily adaptable for the others :wink:

@alena1108 To make testing for the providers, we either need a test with a mock MetadataClient in "github.com/rancher/external-dns/metadata" or move all providers in separate packages.

@janeczku
I prefer to test providers in isolation first, w/o metadata involved. So my vote goes to your second proposal. Thank you for helping out!


Create cleanup.sh to accompany deploy.sh

deploy.sh creates many different files, enables services and deploys GCP resources. We need a script to cleanup the resources created by deploy.sh.

Created with #22


Typo in Mobile Navbar Header

Fix this Typo from "HARI VISH" to "HARI VISHVANATH"

Assign this issuse to me .I will fix this typo


updated guternberg docs to reflect ACF Block >v6

Related:

#2916

Issue
Updates to ACF Blocks documentation to reflect the use of block.json in ACF v6
Solution
Wrote very descriptive docs on how to add blocks to a Timber theme.
Impact
No impact on code, just less frustrated devs.
Usage Changes
none
Considerations
n/a
Testing
n/a

@Levdbas thanks! I added those new suggestions in, reordered the render block step, and I updated the tutorial to include the twig template within the block structure.

Hi @ecupaio , I took the liberty to add a commit myself to your PR. I am using ACF blocks myself quite a lot so I wanted to chime in on some concepts as well. Please let me know what you think and if you see any improvements to make just let me know. We are on the right track here!

@Levdbas that is quite alright. My mission here is to have descriptive documentation for ACF blocks in timber that anyone can follow and be successful. Your contributions have been helpful in achieving that objective.


Update prime.py

Thanks for your pull request.
But according to README.md Its not allowed to change or optimize algorithm.
If I accept this pull request I should do this change on other programming languages too, and its point less for goal of this project.
Good luck.


Cannot run ng add for packages requiring bootstrap

If you run ng add SomePackage --project Project on a project that has module-federation-plugin installed it fails with following  Bootstrap call not found.
Steps to reproduce:

Create new workspace
Create a shell and mfe1 project using ng generate app
Install module-federation-plugin for both

ng add @angular-architects/module-federation@latest --project shell -port 5000
ng add @angular-architects/module-federation@latest --project mfe1 -port 3000

Try adding angular material package using ng approach

ng add @angular/material --project shell
Choose your fav theme
Choose Yes for Global Typography and Browser Animations

Installation breaks

Example output:

The problem stems from fact that bootstrap code below:
import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';

import { AppModule } from './app/app.module';
import { environment } from './environments/environment';

if (environment.production) {
  enableProdMode();
}

platformBrowserDynamic().bootstrapModule(AppModule)
  .catch(err => console.error(err));

Has been moved out of main.ts and into bootstrap.ts, so the installation then fails. I've tested it with a project that didn't have module-fed-plugin installed and it worked as bootstrap is located in main.ts.
While there is a workaround, the problem with this is you have to account for packages that potentially may need bootstrap present in the main.ts file.

Yes, this is kind of a hen/egg issue. MF needs "async bootstrapping" and we can accomplish this by a main.ts with a dynamic import pointing to another file that bootstraps Angular. On the other side, some schematics from the Angular team expect that the main already contains the bootstrap call. They use it to identify your AppModule.
In the latest version of the MF plugin, you can temporarily turn off async bootstrapping:
ng g @angular-architects/module-federation:boot-async false --project myProject
Run your schematic, e. g. ng add @angular/material
ng g @angular-architects/module-federation:boot-async true --project myProject
Don't forget to turn it on again. Otherwise, MF will very likely crash ...


cargo deb --install results in I/O error

Hi! So I've made sure all dependencies are installed but when I run cargo deb --install I get

cargo-
deb: I/O error: No such file or directory (os error 2)
because: No such file or directory (os error 2)

at the end.
Any thoughts on this? Been trying to get my Intel NUC's stats into Home Assistant for ages now.

Hmm, that's pretty vague.
Can you try running cargo deb --verbose? That might tell us what it's failing to find.
Also, could you try just running cargo build --release? That'll let us know that the issue is in cargo-deb and not in the build process itself.

Thanks for your reply, appreciated.

cargo deb --verbose

Fresh system-mqtt v0.2.1 (/home/gits/system-mqtt)
Finished release [optimized] target(s) in 0.11s
info: Stripped '/home/gits/system-mqtt/target/release/system-mqtt'
info: - -> usr/share/doc/system-mqtt/copyright (187B)
info: README.md -> usr/share/doc/system-mqtt/README.md (6KB)
info: /home/gits/system-mqtt/systemd/system-mqtt.service -> lib/systemd/system/system-mqtt.service (257B)
info: /home/gits/system-mqtt/target/debian/system-mqtt.tmp0-stripped -> usr/bin/system-mqtt (4MB)
info: compressed/original ratio 1255328/3973120 (31%)
/home/gits/system-mqtt/target/debian/system-mqtt_0.2.1_amd64.deb

cargo build --release

Finished release [optimized] target(s) in 0.10s

Sounds like only the install step failed then.
My guess is that apt-get is failing.
Try running sudo apt-get install --reinstall /home/gits/system-mqtt/target/debian/system-mqtt_0.2.1_amd64.deb and see how far that gets.

That seems to work, which is nice.
Though I'm receiving a different erorr message when I try to run system-mqtt set-password:

Fatal error: Keyring Error: Secret Service Error: Dbus error: "Unable to autolaunch a dbus-daemon without a $DISPLAY for X11"
If you have not yet set the password run system-mqtt set-password.

Hmm, that may be related to this issue: https://github.com/IamTheCarl/system-mqtt/issues/2
I didn't want to just dumbly store the password in a plain text file so it depends on dbus.
I'm thinking that with how often this seems to be an issue I should permit an alternative where it can be stored in a plain text file but with read permissions revoked for everyone but root.

I get it, thanks for taking the time to look into it. I'll guess I have to wait a little longer.

You're welcome.
Since your issue looks to be #2 at this point, I'm going to close this issue.


Fix the 32-bit build by truncating the microseconds value

The truncation may easily cause bugs though...

Hum... Yes it could since it's supposed to be 64 bits...

I think we don't need g_usleep at all and the add method could be implemented in Rust (BTW its argument should've been signed).

Another option is to implement from/to_glib for TimeVal <-> Duration.


Sort/play albums by track number

I haven't used any of the frameworks in use here, so I would appreciate comments on what I have done :)
#240

Er, it seems this doesn't work correctly yet. I'll close and fix the bugs


Change version to 5.0 to publish to store

R=@g-ortuno
Once it's merged, can you publish it to the store?

I signed it!


Rename bracket-push exercise to matching-brackets

Resolves #379
This rename was proposed in: exercism/problem-specifications#1501
The rationale for the name is:

to name the exercise by its story, not by what it potentially teaches
to avoid unnecessarily biasing the solution space

Thanks a lot for this!
Once this is approved, can we leave @ErikSchierboom to merge it please, so we can check it all goes through properly on the website end. Renaming exercises can be slightly problematic, and I believe I've fixed everything, but it would be good to hand-hold it over the line :)

@ErikSchierboom Could you double check this one for me pls.

@thomchop Thanks for doing this. Sorry it took so long to get sorted.
@angelikatyborska Thanks for the nudge to me about what needed sorting :)


Single-quote Exec command line on *nix

Triple-quotes seem to have been expanded as
{empty quoted string}{single-quoted string}{empty quoted string}
rather than special
escaping. That confused an updated version of System.Diagnostic.Process,
so simplifying the quoting.
See https://github.com/dotnet/corefx/issues/23496#issuecomment-324519381 for context.

Thanks @rainersigwald for the quick fix.
@nguerrera @dsplaisted - if we take the MSBuild build with this fix into dotnet/cli, we should be able to enable Exec on .NET Core 2.1 again.  I'm assuming it will be faster to get a new MSBuild build, than it will be to wait for the fix in CoreFX.

Works for me. Thanks!

@eerhardt @nguerrera Are y'all ok with taking an MSBuild 15.5? I asked @dsplaisted about that yesterday and wasn't sure if it was ok to do so.
(No breaking changes, but some changes that are slightly higher risk. We want to move forward but don't want to drag y'all around unnecessarily.)

This would go to master which is actually post 15.5 so no worries there.

👍 I'll build + publish a package as soon as someone else on my team gets to work and approves this.


Feature Request: Support environment variables for icon

Summary of the new feature/enhancement
Using environment variables for icon path is currently not working.
Current behavior
"icon" : "%SystemRoot%\Installer\{90CBDC15-F4FE-49D2-A245-EC066B70845F}\PowerShellExe.ico"

cause the terminal to crash.
Expected behavior
This should work and be equivalent to
"icon" : "C:\\Windows\\Installer\\{90CBDC15-F4FE-49D2-A245-EC066B70845F}\\PowerShellExe.ico"

I believe this is a subset of work that needs to be done in #1468, but it's atomic enough that someone could fix this without fixing the larger issue.

We should almost certainly genercizise the environment string expander from profile/cascadaisettings.


runtime: re-enable TestGdbPython and TestGdbBacktrace on linux/ppc64 (BE) if/when it gets cgo support

--- FAIL: TestGdbPython (0.30s)
    runtime-gdb_test.go:50: gdb version 7.7
    runtime-gdb_test.go:152: package testing source file: /tmp/workdir/go/src/testing/testing.go
    runtime-gdb_test.go:153: failed to load Go runtime support: "/tmp/go-build613978241/a.exe": not in executable format: File format not recognized
        "/tmp/go-build613978241/a.exe": not in executable format: File format not recognized
        No auto-load scripts.
        No symbol table is loaded.  Use the "file" command.
        Make breakpoint pending on future shared library load? (y or [n]) [answered N; input not from terminal]
        No executable file specified.
        Use the "file" or "exec-file" command.
        BEGIN info goroutines
        Undefined info command: "goroutines".  Try "help info".
        END
        No stack.
        BEGIN print mapvar
        No symbol table is loaded.  Use the "file" command.
        END
        BEGIN print strvar
        No symbol table is loaded.  Use the "file" command.
        END
        No stack.
        BEGIN goroutine 2 bt
        Undefined command: "goroutine".  Try "help".
        END
--- FAIL: TestGdbBacktrace (0.15s)
    runtime-gdb_test.go:50: gdb version 7.7
    runtime-gdb_test.go:264: could not find '#0.*main\.eee' in backtrace
    runtime-gdb_test.go:265: gdb output:
        "/tmp/go-build806889452/a.exe": not in executable format: File format not recognized
        No symbol table is loaded.  Use the "file" command.
        Make breakpoint pending on future shared library load? (y or [n]) [answered N; input not from terminal]
        No executable file specified.
        Use the "file" or "exec-file" command.
        No stack.
        The program is not being run.
FAIL
FAIL    runtime 14.687s

I propose we skip these tests there for now so we can see what else is failing. (These tests already skip if gdb is absent anyway)
/cc @dr2chase

I believe ppc64 (big endian) is essentially unsupported.
Unless the problem also manifests on ppc64le, I think this is unplanned work.

Unless the problem also manifests on ppc64le, I think this is unplanned work.

Here's a flake observed on linux/ppc64le. Same test, but a different failure mode.
https://build.golang.org/log/0c0a8553ebc6c605bd20ed1fd8ec44b81e2575e1.

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
--- FAIL: TestGdbPython (0.57s)
    runtime-gdb_test.go:66: gdb version 7.7
    runtime-gdb_test.go:213: gdb output: Loading Go Runtime support.
        Loaded  Script
        Yes     /tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/runtime-gdb.py
        Breakpoint 1 at 0x9333c: file /tmp/go-build160953289/main.go, line 15.
        hi

        Breakpoint 1, main.main () at /tmp/go-build160953289/main.go:17
        17		gslice = slicevar
        BEGIN info goroutines
        * 1 running  syscall.Syscall
          2 runnable runtime.forcegchelper
          17 waiting  runtime.gopark
          18 runnable runtime.runfinq
        END
        BEGIN print mapvar
        $1 = map[string]string = {["abc"] = "def", ["ghi"] = "jkl"}
        END
        BEGIN print strvar
        $2 = "abc"
        END
        BEGIN info locals
        mapvar = map[string]string = {["abc"] = "def", ["ghi"] = "jkl"}
        strvar = "abc"
        slicevar =  []string
        END
        BEGIN goroutine 1 bt
        #0  main.main () at /tmp/go-build160953289/main.go:17
        END
        BEGIN goroutine 2 bt
        #0  runtime.forcegchelper () at /tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/proc.go:242
        #1  0x000000000009333c in fmt.Println (a=..., n=<optimized out>, err=...) at /tmp/workdir-host-linux-ppc64le-osu/go/src/fmt/print.go:275
        #2  main.main () at /tmp/go-build160953289/main.go:14
        Traceback (most recent call last):
          File "/tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/runtime-gdb.py", line 536, in invoke
            gdb.parse_and_eval('$sp = $save_sp')
        gdb.error: Attempt to assign to an unmodifiable value.
        Error occurred in Python command: Attempt to assign to an unmodifiable value.
        END
        Breakpoint 2 at 0x93370: file /tmp/go-build160953289/main.go, line 18.
        runtime: newstack sp=0xc000032fc0 stack=[0xc000064000, 0xc000065000]
        	morebuf={pc:0x9333c sp:0xc000032fc0 lr:0x0}
        	sched={pc:0x39424 sp:0xc000032fc0 lr:0x9333c ctxt:0x0}
        runtime: gp=0xc000000180, goid=1, gp->status=0x2
         runtime: split stack overflow: 0xc000032fc0 < 0xc000064000
        fatal error: runtime: split stack overflow

        runtime stack:
        runtime.throw(0xd4daa, 0x1d)
        	/tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/panic.go:608 +0x5c
        runtime.newstack()
        	/tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/stack.go:995 +0x7a4
        runtime.morestack()
        	/tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/asm_ppc64x.s:339 +0x60

        goroutine 1 [running]:
        runtime.forcegchelper()
        	/tmp/workdir-host-linux-ppc64le-osu/go/src/runtime/proc.go:242 +0x14 fp=0xc000032fc0 sp=0xc000032fc0 pc=0x39424
        runtime: unexpected return pc for main.main called from 0x0
        stack: frame={sp:0xc000032fc0, fp:0xc000033080} stack=[0xc000064000,0xc000065000)

        fmt.Println(...)
        	/tmp/workdir-host-linux-ppc64le-osu/go/src/fmt/print.go:275
        main.main()
        	/tmp/go-build160953289/main.go:14 +0x1ec fp=0xc000033080 sp=0xc000032fc0 pc=0x9333c
        [Inferior 1 (process 12962) exited with code 02]
        BEGIN goroutine 1 bt at the end
        No such goroutine:  1
        END

    runtime-gdb_test.go:286: goroutine 1 bt at the end failed: No such goroutine:  1
FAIL
FAIL	runtime	34.375s

Never mind, that one seems to be #28679.

linux/ppc64 does not support cgo. The reason this test fails on linux/ppc64 is that it tries to build a program to be debugged with gdb, but the program uses cgo so cannot be built. The failure has nothing to do with gdb.
If you use a program that can be built with linux/ppc64, gdb and the gdb python scripts should work on linux/ppc64 as well as linux/ppc64le. Everything that gdb looks at (the stack, register usage, threads and goroutines) should be the same between linux/ppc64 and linux/ppc64le.
I tried gdb on a simple hello.go test and things worked fine:
Breakpoint 1 at 0x94680: file /home/boger/gotests/hello.go, line 8.
(gdb) run
Starting program: /home/boger/gotests/hello
[New LWP 5583]
[New LWP 5584]
[New LWP 5585]
[New LWP 5586]
[New LWP 5587]

Thread 1 "hello" hit Breakpoint 1, fmt.Printf (format=..., a=..., n=<optimized out>, err=...)
    at /home/boger/golang/go/src/fmt/print.go:208
208		return Fprintf(os.Stdout, format, a...)
(gdb) info goroutines
* 1 running  runtime.systemstack_switch
  2 waiting  runtime.gopark
  17 waiting  runtime.gopark
  18 waiting  runtime.gopark
(gdb) goroutine 1 bt
#0  fmt.Printf (format=..., a=..., n=<optimized out>, err=...) at /home/boger/golang/go/src/fmt/print.go:208
#1  main.main () at /home/boger/gotests/hello.go:8
(gdb) goroutine 2 bt
#0  runtime.gopark (unlockf=<optimized out>, lock=0x173b50 <runtime.forcegc>, reason=16 '\020', traceEv=20 '\024',
    traceskip=1) at /home/boger/golang/go/src/runtime/proc.go:302
#1  0x00000000000392d4 in runtime.goparkunlock (reason=<optimized out>, traceEv=<optimized out>,
    traceskip=<optimized out>, lock=<optimized out>) at /home/boger/golang/go/src/runtime/proc.go:307
#2  runtime.forcegchelper () at /home/boger/golang/go/src/runtime/proc.go:250
#3  0x0000000000060bc4 in runtime.goexit () at /home/boger/golang/go/src/runtime/asm_ppc64x.s:857
Backtrace stopped: frame did not save the PC

Actually I just got on a system where gdb was at a high enough level and removed the check to skip tests on linux/ppc64, and found that those tests that need cgo are skipped if cgo is not enabled. And those that don't need it pass. I can submit the change if you want it now.

Oh, the builder has to have at least gdb 7.7 or the tests in question are skipped.


Improvements to image coloring

Description
Brief description of what this PR is about

Added random color array to remove need for specifying specific id's for objects
Improved efficiency of coloring algorithm
Resize array in translator to original image dimensions

Codecov Report

Merging #1784 (ac1ca3f) into master (bb5073f) will decrease coverage by 2.52%.
The diff coverage is 65.03%.

@@             Coverage Diff              @@
##             master    #1784      +/-   ##
============================================
- Coverage     72.08%   69.56%   -2.53%
- Complexity     5126     5489     +363
============================================
  Files           473      524      +51
  Lines         21970    24317    +2347
  Branches       2351     2644     +293
============================================
+ Hits          15838    16916    +1078
- Misses         4925     6090    +1165
- Partials       1207     1311     +104

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../cv/translator/SemanticSegmentationTranslator.java
0.00% <0.00%> (ø)

.../cv/translator/StyleTransferTranslatorFactory.java
40.00% <ø> (ø)

... and 414 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd835c...ac1ca3f. Read the comment docs.


Follow chapel naming conventions for function names

I regenerated two fer with the proper naming conventions.
If you decide you would rather have snake case for the test names let me know and I'll tweak the generator back. (It will just take a few seconds, so there's no bother either way).

I think we can stick with the chapel guidelines for now. If in the future someone complains, we can review this

That sounds very reasonable!


Update button xpath to work with latest ODH

Optionally we could put some comment that the latter value should be required once the odh code is pulled downstream.

@jstourac done


Add jaxsim.api.references with functional resources to handle model references

This PR introduces helpers to manipulate the following inputs of a simulated model:

Joint force references: these are the torques (or linear forces) references synthesized by a joint controller from the user. They are not guaranteed to be the same as those actuated since there might be friction or other contributions e.g. for enforcing joint limits.
Link forces: these are the 6D forces applied to the origin ${}^W \mathbf{o}_{L_i}$ of each link frame $L_i$. The coordinates of the 6D forces are expressed in the active JaxSimModelReferences.velocity_representation.

📚 Documentation preview 📚: https://jaxsim--96.org.readthedocs.build//96/

Right now I'm just creating the storage. You can try the following for the moment:
import jaxsim.api as js
from jaxsim import integrators

model: js.model.JaxSimModel = ...
data: js.data.JaxSimModelData = ...

ref = js.references.JaxSimModelReferences.zero(
    model=model, velocity_representation=data.velocity_representation
)

ref = ref.set_joint_force_references(
    forces=jnp.ones(model.number_of_joints())[0:5],
    model=model,
    joint_names=model.joint_names()[0:5],
)

integrator: integrators.Integrator = ...
d = integrator.init(x0=data.state, t0=0.0, dt=0.001)

_ = js.model.step(
    model=model,
    data=data,
    integrator=integrator,
    integrator_state=d,
    joint_forces=ref.joint_force_references(),
    external_forces=ref.link_forces(),
)

Alright, thanks a lot for the explanation!


Page scrolls down after document load on Firefox

This issue only happens on FF.
I rolled back to using wysihtml5 by xing for now which I didn't have the issue with.
Tested on:
MacOS 10.12.6
FF 55.0.x

Confirmed, having the same issue here!

Same problem here please resolve!

I have the same issue. Does anyone have a workaround they have found (besides changing to a different project)?

Having the same problem with the current firefox.
My dirty workaround (because I did not found where wysihtml scrolls down to the page bottom):
Just added the line window.scrollTop(0); at the bottom of wysihtml.js

@Stryker93 Only downside of that is when you are scrolling down ASAP and once that is triggered you are back at the top of the page again.
I tried something similar and ended up removing the scroll to action because it also caused unwanted behavior.
Might swap to Quill if this issue sticks around 👎

This issue does not exist in Firefox 54.

@Nyholm true, when I used this, I hadn't noticed the error until a team member told me about it. After some testing, It turned out to be the new versions of FF only.
So the question, was there something FF deprecated? Or perhaps added that caused it?

What could be the reason for this behavior? What hotfix do you suggest?

Still seeing this. Does anyone have a workaround?

I added this js script after all the js scripts
if typeof navigator != 'undefined' or !navigator   usrAgent = navigator.userAgent   if usrAgent.toLowerCase().indexOf('firefox') > -1     match = usrAgent.match(/Firefox\/([0-9]+)\./)     if match and parseInt(match[1]) > 54       window.scrollTo 0, 0 return

Doesn't that scroll to the top of the page? We are using version 0.5.5, and I've tracked down the two places that are causing this. I will checkin a PR, but in the time being, the two places are:

the top method in polyfills.js (this could be more specific about Quantum, but since this is a workaround for 'Safary'...

   // Safary has a bug of not restoring selection after node.normalize correctly.
   // Detects the misbegaviour and patches it
   var normalizeHasCaretError = function() {
+     // in the new Firefox Quantum, the code below causes the page to jump/scroll. Therefore, just return false.
+    if (window.navigator.userAgent.indexOf('Firefox/') > -1) {
+        return false;
+    }
     if ("createRange" in document && "getSelection" in window) {

We have a workaround https://github.com/timdown/rangy/issues/292 that also was causing scrolling issues, and we had to tweak it too. See that ticket for more info.

@francis Took me a while to find the bugger, only had minified version. Added the change and it stopped scrolling FF :)
Cheers for the fix 👍


fix: keep legacy repo verison for backwards compatibility

closes #4428
closes #4473

New error message when 1.4 opens a 1.5 repo:
$ bacalhau serve --node-type=compute,requester
Error: failed to reconcile repo:
Unsupported repository version 4.
Bacalhau does not know how to read this configuration format and
you will need to upgrade to a newer version to upgrade this repository.

Do we explain how to upgrade?


Simple ingest statistics in the forms of graphs and other charts

There's benefit to understand a breakdown of how much information is being processed, who the top sources are and other summary details. These should be contained within a simple dashboard and provide a quick-view of platform activity.


Where can get Sonnet 1.x doc?

Navigate to the doc folder. On the left side of the directory path, there is a button. If you click on it, you can choose 1.x tags.


[DXCDT-110] Refactor client, client grant, resource server tests

Description

In this PR we refactor the client, client grant and resource server tests so we can run any of them in any order and properly clean up after each test.
References

Testing

[x] This change adds test coverage for new/changed/fixed functionality

Checklist

[x] I have read and agreed to the terms within the Auth0 Code of Conduct.
[x] I have read the Auth0 General Contribution Guidelines.
[x] I have reviewed my own code beforehand.
[x] I have added documentation for new/changed functionality in this PR.
[x] All active GitHub checks for tests, formatting, and security are passing.
[x] The correct base branch is being used, if not main.

Codecov Report

Merging #42 (50f7eca) into main (a8638b3) will increase coverage by 49.72%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   31.20%   80.92%   +49.72%
===========================================
  Files          34       33        -1
  Lines        5532     1735     -3797
===========================================
- Hits         1726     1404      -322
+ Misses       3652      268     -3384
+ Partials      154       63       -91

Impacted Files
Coverage Δ

management/connection.go
62.20% <0.00%> (-1.17%)
:arrow_down:

management/management.gen.go

management/management.go
82.08% <0.00%> (+0.83%)
:arrow_up:

management/resource_server.go
50.00% <0.00%> (+10.71%)
:arrow_up:

management/client_grant.go
86.66% <0.00%> (+23.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8638b3...50f7eca. Read the comment docs.