Script to find the number shared sites between pairs

This script accepts an arg for the number of non-ref samples per site and filter a VDS to only those sites. It then calculates the number of those sites that are shared between pairs. For example, if the passed arg non_ref_samples is equal to 3, the script will filter the VDS to sites where hail's n_non_ref calculates to 3. It then grabs the samples found at that site, creates a list of sample pairs, and tallies the number of sites where n_non_ref=3 per pair. The script has an additional het_only filter if you just want to consider sites where no hom_var exists.

I decided to move the write after going through your suggestions. I like it better where it is now but no strong feeling on it. Back to you @ch-kr !


Why ImagePullPolicy is default as Always

Hi,
I am seeing ImagePullPolicy is configured as Always for nats, sns and pubsub
https://github.com/falcosecurity/charts/blob/master/falco/templates/daemonset.yaml#L145
https://github.com/falcosecurity/charts/blob/master/falco/templates/daemonset.yaml#L154
https://github.com/falcosecurity/charts/blob/master/falco/templates/daemonset.yaml#L179
Could you please elaborate if there is any specific reason for it? If not, can we use param instead?

I guess because of :latest.
Anyway, I agree to parameterize those values. Feel free to open a PR, if you'd like.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

This issue does not apply anymore, since those integrations have been removed by #123

This issue does not apply anymore, since those integrations have been removed by #123


Master branch is broken in Travis

See https://github.com/pouchdb/upsert/pull/32 and https://github.com/pouchdb/upsert/pull/31
Apparently some dependency broke because this was green the last time the build ran. I've enabled GreenKeeper and we'll see if we can hunt this down.

fixed in #33

Nope, master is still broken. Apparently npm run test-browser passes on MacOS but fails on Travis Linux. Something different about Linux PhantomJS vs Mac PhanatomJS?

@nolanlawson I don't think so, looks like more CouchDB is not running on Travis. Check the result on: https://travis-ci.org/pouchdb/upsert/jobs/207654791

Thanks for the tip, I believe the issue turned out to be that CORS wasn't enabled on the CouchDB, which would explain why it failed in the browser but worked in Node. I wonder why it ever worked in the first place; maybe a bug in old PhantomJS?
In any case #44 appears to fix it, so I'll close this.


Update tests to catch tar error

Ah, wrong test - this was being caught by GHA (actually running obuilder), but #82 was never rebased after #84 was merged


Web Suport

I use your package for an website app. If I build for Android and windows is working, for the web it`s a simple text.
Can you check your package for web-support?
Thank you for your work!

flutter issue

It seems flutter/engine#34085 PR did fix the issue it is available in Flutter 3.7.0 stable release.

Closing it, since the problem is not present in current version.


Bug Report: Index Out of Range Panic for Empty String in text.go

Description:
When the length of the string s is 0 at text.go#L340, it leads to a panic at text.go#L700 with the error:
panic: runtime error: index out of range [0] with length 0

Steps to Reproduce:

Call the relevant function with s as an empty string.
Observe the panic at the aforementioned line.

Expected Behavior:
The code should handle the case of an empty string without panicking, perhaps by skipping processing or providing a relevant error message.
Actual Behavior:
The code panics with an index out of range error when given an empty string.
Possible Solution:
Add a check for the length of the string s and handle it gracefully, either by skipping further processing or returning an error.
Additional Information:
None.

Thanks, this should be fixed now!


chore: Update examples to use latest ALB module

Description

Update examples to use latest ALB module
Fix variable description for default number of tasks

Motivation and Context

Resolves #129

Breaking Changes

No

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 5.6.0 :tada:


Basic SECURITY.md

It is good to have at least some rudimentary security policy set up for SpeechBrain. The GitHub template suggests two sections: Supported versions and Reporting a vulnerability.

I have made the security updates paragraph a bit clearer.


ShaderMask makes sibling widgets transparent(?)

Steps to Reproduce

...
...
...

Logs

This looks like an accidentally posted issue.
If this is a real report please create a new one with the issue template filled out. Thanks!


lib can be init'ed using an object instead of arguments if desired

country code param is now supported, but only via the options param

All tests passed for me locally with this. Thanks for the contribution!

<EMAIL_ADDRESS>


The serverless landscape should reflect it being v0.1 rather than v0.9.5

Looks like it carried over the main Cloud Native Landscape number.

Main is at 1.1. We're going to leave serverless at 0.95, but we may accelerate it to 2.0 to match the cloud native landscape going forward, and the interactive version they'll both be synced with.


bug: couldn't build examples/foo.rs

setup (the OS is Debian 12):
$ tree .
.
├── Cargo.lock
├── Cargo.toml
├── rust-toolchain.toml
└── src
    └── main.rs   --> https://github.com/zesterer/chumsky/blob/main/examples/foo.rs

$ cat Cargo.toml
[package]
name = "chumsky-test"
version = "0.1.0"
edition = "2021"

[dependencies]
chumsky = "0.9.3"

$ cargo --version
cargo 1.71.1 (7f1d04c00 2023-07-29)

reproduce building error:
$ cargo build --release
error[E0433]: failed to resolve: could not find `ascii` in `text`
  --> src/main.rs:32:23
   |
32 |     let ident = text::ascii::ident().padded();
   |                       ^^^^^ could not find `ascii` in `text`

error[E0433]: failed to resolve: could not find `ascii` in `text`
  --> src/main.rs:83:27
   |
83 |         let r#let = text::ascii::keyword("let")
   |                           ^^^^^ could not find `ascii` in `text`

error[E0433]: failed to resolve: could not find `ascii` in `text`
  --> src/main.rs:95:26
   |
95 |         let r#fn = text::ascii::keyword("fn")
   |                          ^^^^^ could not find `ascii` in `text`

error[E0107]: trait takes 0 lifetime arguments but 1 lifetime argument was supplied
   --> src/main.rs:31:25
    |
31  | fn parser<'a>() -> impl Parser<'a, &'a str, Expr<'a>> {
    |                         ^^^^^^ -- help: remove this lifetime argument
    |                         |
    |                         expected 0 lifetime arguments
    |
note: trait defined here, with 0 lifetime parameters
   --> /home/blahblah/.cargo/registry/src/index.crates.io-6f17d22bba15001f/chumsky-0.9.3/src/lib.rs:141:11
    |
141 | pub trait Parser<I: Clone, O> {
    |           ^^^^^^

Some errors have detailed explanations: E0107, E0433.
For more information about an error, try `rustc --explain E0107`.
error: could not compile `chumsky-test` (bin "chumsky-test") due to 4 previous errors

See #456.


[WIP] flow-to-ts post setup

👋    @danielbartsch
so here is how I imagine this post to go down:

[ ] intro, yada yada (don't know yet, something about "the race is decided" or so)
[ ] flashback to 2016 (I think)
can you help me establish a timeline? when did we exactly start with this? I imagine:

we were a small team, app was medium sized
we decided to try flow because made by FB, integrated well with React, incremental migration possible, TS wasn't mature either ...

[ ] fast forward, 2019
typescript has clearly won, by all metrics (npm download stats maybe?). Better community support (no flow types for nothing now), works superb with react, eslint got a boost when tslint deprecated itself
we have a couple of other products with TS
suprising how often we said: wow, flow is bad, this wouldn't have happened with TS (maybe we can dig up an easy example). "Thanks for nothing, flow" was kinda said every other day.
[ ] the final nail in the coffin

we hadn't upgraded in a while (0.87 was our last version I believe), optional chaining was here, but flow couldn't narrow the types with it (example needed), which sucked.
design-system decides to deliver TS types, but not flow.
try to upgrade flow by 15 versions or try TS upgrade. flow seemed harder + dead + unified dev-exp === TS

[ ] the upgrade itself

how did we start (which tool did we use), maybe you can describe what we needed to do.
how long did it take

so long that we had to base features on it :)

we kept implicit any on (turned out not so well)

[ ] metrics

the burndown chart please :)

[ ] conclusion

something, don't know yet 😅

I'd appreciate any help I can get. You can create a fork of this repo if you like and create a PR to this PR, or just comment here and I will integrate it.

Brain dump + some code archeology

We started with version 0.39 in February 2017.
we were a small team (< 10 people, maybe fulltime equivalents of 5?)
flows pros for us:

able to integrate it gradually as opposed to typescript at the time (to our knowledge)
it was the emerging cool kid around the block, promising a type system that works (you won't believe what happened next..)

we began gradually adding flow to our existing es6 codebase without any typesystem. This is of course always hard, as a lot of investigation work needs to be done initially to find out what values each parameters, variables, functions can have
as time went on, flow also released new versions. As the flow share in our code was small, upgrading wasn't very tedious, but all the time required work of course, as almost all the time, some new type errors were uncovered.
we went as far as to version 0.109. At which point we had worked with flow for around 2 years and integrated it to around 70% of our codebase
a turning point was reached in March 2020, when we wanted to upgrade to flow version 0.119, or, as this was a looot of work (a lot of errors, and every upgrade got harder and harder to fix, as our flow codebase grew and grew), we could migrate to typescript once and for all, and alleviate all the confusion we a lof of the time had with flow.

I'd say the most common discussion between developers when something didn't work was flow. Eg. "Flow doesn't get this right". "I thought I understood flow, but this doesn't make any sense"

as a team, as well as individual team members already had experience with typescript, and it basically sold what flow advertised. A type system that just works. Sure, sometimes there are still discussions about why typescript wants it the way it wants it, but it was significantly less. Also we noticed that typescript began turning into the cool kid around the block, but not without reason. It's getting convenient features a lot faster than flow, and in general just works better. Also, since it's the cool kid now, third party packages began more have typescript type support, rather than flow type support (so that's a Plus)
we decided to migrate to typescript version 3.9.6

there's this automatic tool that promises to convert from flow to typescript: flow-to-ts
unfortunately it didn't really work that well

in its most basic use cases, it worked, but once eg. Flow internal, or react internal types were used, it couldn't fix that
also typescript has this requirement for files that contain jsx syntax to be called tsx. It also didn't do that.

but once semi manually converting all files that contain jsx syntax to .tsx, it couldn't convert it correctly either, because typescript doesn't like the generics syntax combined with jsx syntax.
eg.

type Props<T> = {
    item: T
    ...
}

Typescript would think that T is a react component, and then had a syntax error happening. The "official" way of fixing this would betype Props<T,> = {

also flow has a lot of built in types, typescript has too, mostly they can be replaced with one another, but sometimes they cannot. All of this had to be done semi manually as well, as the flow-to-ts tool didn't do it.
Most of the work was done via sophisticated (regex) search and replace in vscode

the whole migration took roughly 4 months, done by 1 person at the beginning, and 2 persons when fixing typescript type errors (from around 3200 to 0)

@danielbartsch I finally made a first draft of this post, sorry that it took so long (I know I wrote some other things in between 😁 🙈 ).
I haven't proof-read it yet, but I would like to publish it this year (so, in the next couple of days). Do you by any chance still have the burn-down chart? I only have this picture you sent me once:

It would make for a good visual :)


Path db

In short, moves the currentPath structure in consensus to disk, and fixes associated bugs.
Proposal for error handling: panic on read, and error catch on writes. We do a fair amount of verification when modifying the structures, so it makes sense to use this existing structure. Ideally, database inconsistencies would be caught on write where they can be handled more elegantly (e.g. rejecting a call to acceptBlock).
Also worth noting that this is on top of the Set db pull request.

The BulkUpdate and associated types were not removed from a previous PR. Could you remove them here?

Good idea. Also removed InsertIntoDatabase, as that is not used either.

Looks like the rebase got screwed up somewhere.
When this happens to me, I find it's easiest to just make a new branch from master, and then cherry-pick all the commits that I want to keep. Luke I think frowns upon this method, but it gets the job done.

Is there a test that creates a new consensus set, saves a bunch of blocks, then closes the consensus set and opens it again (which means that everything will load from the database) and checks that the consensus set hash is still correct?

A test like that should be added to persist_test.go
Ideally, the test would include every type of transaction (mining blocks, sending coins, creating + revising file contrcts, storage proofs, and siafunds). Block builders for all these types already exist in accept_test.go, but I'm not sure how easy it would be to adapt them to the persist_test.go stuff.


Unable to find peloton-client

While following the run instructions for minicluster I am able to get all components installed except for a python library called 'peloton-client' which is not found in the pypi repository and I was unable to find the code to it for a local build.
Where can I find this library?

It looks like this used to be on Pypi but has since been removed. I've created an internal ticket to get this added back in. Will respond when it's been added.


[pdb] Provide PDB for libGLESv2.dll

PDB for libGLESv2.dll needed. To view callstacks like this:
Here was an AccessViolation somewhere

Here are the symbols:
gl_symbols_32.zip

Ok, thanks. Will try..


(#809) removed the suppressing of PR builds

from local repository
fixes #809

@nils-a thanks for getting this added!


Add agreement menu with archive agreement button

Add also a "delete" button.

@consenz are you sure? usually the archive serves as a recycle bin, and we don't really want to delete information


Ensure selection indicator moves correctly in minimal mode

Description
In NavigationView minimal mode the selection indicator position was not updated properly in some edge cases.
Motivation and Context

Fixes #6837
How Has This Been Tested?
Manually
Screenshots (if appropriate):

@ojhad any chance to get this merged?

Hi everyone, it would be nice to have this bugfix included 😊

Thanks for this fix! However, I think it's best to close this PR. The reason being is that I ported over some existing fixes from WinUI3 which resolves this and other issues.


Update manage-mobile-devices-with-exchange-activesync.md

Requested per CSS Content Idea Request 64537:Need to update Docs SCCM page CMDlets list for To install and configure an Exchange Server connector to include 'Get-Mailbox'

#sign-off
I confirmed with Nathan Kim

Thanks @JarrettRenshaw for the contribution. We've merged your change and should be live soon!


Add tutorial and dict guide

Hi
I've added the following to the user's guide.

document classification
keyphrases extraction
replay feature

Please look and share those with everyone.
Thank you

Great work! Thanks!


Need update. It broke today.

Just a heads up. It was fine 2 days ago and today it doesnt worked. I think they update something on their end. I was on Firefox btw.

I checked again its fine now.


Inconsistent dem parameter and soil file in Weill et al

When downloading the src file from the CATHY gitbucket:
Soil file contains 20 layers while the dem parameters is set to nstr =15.

The issue is solved, since now the src and inputs files are fetched from the Github directly (where the soil file has been corrected) https://github.com/CATHY-Org/weill_dataset
Precautions: need to make sure that the Github branch is up to date with the GitBucket one.


Game crashes

Game freezes and crashes when I inject ingame in practice tool
I tried injecting before starting up a practice game to test
I tried injecting during loading screen
All 3 ended with same result, any clues what I do wrong? I run with Admin rights for the injector

having the same issue as well.

Server: EUW


Fix highlight errors when lsp crash or stop

It adds a check wether the client is still available before highlighting.
If the client is not there anymore it returns true to unregister the autocommand
This fix the
method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer errors when doing a LspRestart or the server crashes

Please forgive my ignorance here but will this fix negatively affect people with different LSP configurations etc?

How do you test or reproduce this error?
I tested :LspRestart and :LspStop and :LspStart and have not seen any errors and the behaviour worked as expected. My observed behaviour:

on LspRestart the highlights blinked for a moment and came back
on LspStop the highlights disappear on cursor move
on LspStart the highlights came back

These cases seem to work normally.
But I only tested with lua, perhaps some other LSP behaves differently.
I don't know what happens in case of LSP crash or how to reproduce it, but I suspect in such a case the highlights will not be the only issue? Perhaps if LSP crashes the best is to just restart nvim, since it will not behave as expected?
In any case I think we need to understand more details about this.

I have a pretty unstable LSP (tsserver) on a couple projects. That requires me to frequently restart it. When the server crash I receive a load of errors method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer
Theses errors are probably not an issue by themselves because they are silent, but I'm using Noice and nvim-notify so they are pretty noisy.
The issue is that the more I restart the LSP the more errors notifications I get, I get, tsserver sometimes require 3 restart in a row.
They only go away if a use the :e command or close nvim.
This led me to believe that there might be a small memory leak as the more you restart the lsp the more autocmds are created.
This might be an edge case but doing this trick completely resolved my issues and I can restart the LSP and continue working. I thought I'd share through this pull request.

Hmm I wonder if a more proper approach would be to listen to the LspDetach event and then call vim.lsp.buf.clear_references and unregister all Cursor* autocmds?
Does the LspDetach event get triggered when the LSP crashes?
Also, have you submitted a bug report on tsserver crash or perhaps it's already a known issue?

@sudo-tee It's looking much better now.
I think it can be simplified further by using nvim_clear_autocmds like this:
diff --git a/init.lua b/init.lua
index f587aec..50e56d5 100644
--- a/init.lua
+++ b/init.lua
@@ -544,10 +544,7 @@ require('lazy').setup({
         group = vim.api.nvim_create_augroup('kickstart-lsp-detach', { clear = true }),
         callback = function(event)
           vim.lsp.buf.clear_references()
-          local cmds = vim.api.nvim_get_autocmds { group = 'kickstart-lsp-highlight', buffer = event.buf }
-          for _, cmd in ipairs(cmds) do
-            vim.api.nvim_del_autocmd(cmd.id)
-          end
+          vim.api.nvim_clear_autocmds { group = 'kickstart-lsp-highlight', buffer = event.buf }
         end,
       })

If you agree that this works and is cleaner go ahead and integrate it and I think we have a final solution.

@dam9000
I confirm that it works with the vim.api.nvim_clear_autocmds. Thanks a lot
I updated the PR to use this method instead.
Thanks  lot for your help on the issue :)

Thanks for working towards the best solution on this everyone!


[BUG] ModHub List is inaccurate

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I have a folder that is only Modhub mods but many are registering as non-Modhub.   It's not a high priority,  just wanted you to be aware.

Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Mod Assistant Version:
- OS:
- Virtualized:

Anything else?
No response

At this point, I'm not sure if my list-maker fell off the rails or something else went wrong, but I too have noticed this.  Thanks, I will investigate.

I finally remembered to do this, should be sorted now.  You will need to fully exit / re-enter Mod Assistant to update the list (it does it once on open)
The only possible downside is I did prune those things that were on modhub and have been recalled/removed for whatever reason.


Error is not clear when be disk is full and create table.

Steps to reproduce the behavior (Required)

be disk is full.
create table.
no error in ErrMsg but create table failed.

mysql> CREATE TABLE IF NOT EXISTS metrics_detail(`tags_id` INT, `timestamp` DATETIME, `value` DOUBLE SUM) ENGINE=olap AGGREGATE KEY(`tags_id`, `timestamp`) DISTRIBUTED BY HASH(`tags_id`) BUCKETS 1 PROPERTIES("replication_num" = "1");
ERROR 1064 (HY000): Unexpected exception: Table replication num should be less than of equal to the number of available BE nodes. You can change this default by setting the replication_num table properties. Current alive backend is [10002]. , table=metrics_detail, default_replication_num=3

mysql> show backends\G
*************************** 1. row ***************************
            BackendId: 10002
                   IP: <IP_ADDRESS>
        HeartbeatPort: 9959
               BePort: 9965
             HttpPort: 8943
             BrpcPort: 8965
        LastStartTime: 2024-01-25 10:39:51
        LastHeartbeat: 2024-01-25 13:05:46
                Alive: true
 SystemDecommissioned: false
ClusterDecommissioned: false
            TabletNum: 37
     DataUsedCapacity: 207.431 KB
        AvailCapacity: 196.538 GB
        TotalCapacity: 1.968 TB
              UsedPct: 90.25 %
       MaxDiskUsedPct: 90.25 %
               ErrMsg:
              Version: 2.5.18-2b1a2c2
               Status: {"lastSuccessReportTabletsTime":"2024-01-25 13:04:51"}
    DataTotalCapacity: 196.538 GB
          DataUsedPct: 0.00 %
             CpuCores: 104
    NumRunningQueries: 0
           MemUsedPct: 0.11 %
           CpuUsedPct: 0.0 %
1 row in set (0.00 sec)

Expected behavior (Required)
Real behavior (Required)
reach capacity limit. used pct: 0.989291, left bytes:<PHONE_NUMBER>2, path: /home/disk1/wangyongbing/starrocks-20240124/be-50b83594-bb71-4f4c-b012-0795146feaa9/storage

ERROR 1064 (HY000): Unexpected exception: Table replication num should be less than of equal to the number of available BE nodes. You can change this default by setting the replication_num table properties. Current alive backend is [10002]. , table=metrics_detail, default_replication_num=3

StarRocks version (Required)

You can get the StarRocks version by executing SQL select current_version()
all

https://github.com/StarRocks/StarRocksTest/issues/5869


Posting to multiple channels

It would be helpful if events could be posted to multiple channels. I tried specifying a space-separated list in the repo settings, but it didn't work properly.

Thanks for your input. Going to schedule this for the next release.

implemented in 1.4


ValidationBinding better error reporting

If your view does not initialize the BindingContext before the call to InitializeComponent(), then you will get a null reference exception.
This is due to the ValidationBinding not being able to find the Source.
Need some better error messaging around this, had to debug using the project to track it down

Hi, thanks for the detailed explanation. I don't like ValidationBinding logic but still I haven't found a better way to read property attributes.
In the end, it does exactly the same as regular binding but you're right, there is no good error reporting right now:
https://github.com/enisn/UraniumUI/blob/7164805bcd325b0e1d96f42e1cff6cc2d8415ef6/src/UraniumUI.Validations.DataAnnotations/Validations/ValidationBinding.cs#L53
I'll try to refactor it, but I am thinking about changing it to something better soon


Unburnable frozen NFT scams

Hello,
I'm the dev for https://www.sol-incinerator.com, which allows you to burn tokens, and is often used to burn scam NFTs users are sent.
Recently, I've had a few users report they have been sent a token which they cannot burn, and on investigation, it appears that they have been sent these scam NFTs and had the token account frozen in the same transaction.
Since the account is frozen, they cannot burn, close, or transfer the scam NFTs elsewhere.
Surely this is not desired behavior? In this token-2022 pull request, it's mentioned that untransferable scam NFTs should be burnable: https://github.com/solana-labs/solana-program-library/pull/2912
Transaction link where NFT was transferred and frozen: https://explorer.solana.com/tx/TXVSZgYaAcVFo3dsuMUtcnBU6z9gsXE1Dsr1xGfo9r8kAkEKbXDvPkxgtcmmRyBTY7EzDReDKvDR8BJWSaZw44S
Is there any way for me to let my users unfreeze or burn these tokens?

Unfortunately it's not really possible. Looks like it's finally time for wallets to support the ability to hide scam tokens. A good starting point would be for wallets to simply hide all frozen tokens

we should open a door for option to burning tbh, most uses i can imagine with this combo are totally harmful

gonna cite someone else here but:
"With SOL , need to treat wallets like email boxes, need spam filters."
low fee coming in as a disadvantage here

plus, we love to think this just affects wallets, really affects every dapp that loads meta

Cmon, these scam nft's  NEED to be transferable to a burn wallet. Re-enable send on these? Or have a seperate send button that you can pick nfts that cant be clicked on, like in the coin section of the wallet. I want these OUT of my wallet. Every scam story I have read has resulted in Phantom/Solana saying that there is nothing that can be done. I betcha if someone transferred millions of solana out of the developers main wallet to another Solana wallet that they would do something. I understand being decentralized, but scam nfts just sitting in your wallet are unacceptable. I would like to be able to get rid of them. I'm not asking to get any stolen funds back, although reported thieves and rugs should be pursued. Just to be able to send a scam nft away. So correct me if I am wrong, but the developers indifference to these scammers and their victims means that this is not a crime, its a job.

Cmon, these scam nft's NEED to be transferable to a burn wallet. Re-enable send on these? Or have a seperate send button that you can pick nfts that cant be clicked on, like in the coin section of the wallet. I want these OUT of my wallet. Every scam story I have read has resulted in Phantom/Solana saying that there is nothing that can be done. I betcha if someone transferred millions of solana out of the developers main wallet to another Solana wallet that they would do something. I understand being decentralized, but scam nfts just sitting in your wallet are unacceptable. I would like to be able to get rid of them. I'm not asking to get any stolen funds back, although reported thieves and rugs should be pursued. Just to be able to send a scam nft away. So correct me if I am wrong, but the developers indifference to these scammers and their victims means that this is not a crime, its a job.

If i may suggest a solution it will be talking to a customer agent through live chat https://direct.lc.chat/14390013/ they got the best, straightforward and  transparent solution to most programming blockchain related issues

any updates on this issue?

we need this feature, frozen scam tokens are very harmful for the ecosystem

Updating the existing SPL Token program for a non-loss-of-funds issue is going to be very difficult to build support for.
Instead if the major wallets can just each take the simple and low-risk step I suggested last June and that'd likely cover the majority of the problem here: https://github.com/solana-labs/solana-program-library/issues/3295#issuecomment-1169485892

@joncinque - just to double check, token-22 has a way to deal with this?

@mvines no, not this specific issue. If someone sends you a token then freezes it, you still can't do anything with it. You can't burn frozen tokens, and you can't close a frozen account.

@joncinque Hmm, would that make legitimate uses of freezing tokens very expensive?
I do want to point out that there's nothing SPL Token-specific about this issue though. It's easy to create an ERC20 token that can't be burnt or transfered at all, including to address(0).
To me, this underlines that this is a problem for wallets and indexers to solve. Not displaying links from unrecognized tokens would go a long way toward avoiding scams.

@joncinque Hmm, would that make legitimate uses of freezing tokens very expensive?

It definitely could, which is why we would need to tune that number carefully. 1 SOL is probably way too much, but it's an example amount.

To me, this underlines that this is a problem for wallets and indexers to solve. Not displaying links from unrecognized tokens would go a long way toward avoiding scams.

Yeah, that would be amazing!

So if iread through the lines, what al the developers basically want is we all only use a burner wallet so if scam get send there (since that  is only wallet we use then with connecting to for example lmnft ) if it get filled with frozen crap we just delete the wallet and make a new . So we have to keep making wallets and keep sending good nft's around ??
Just give the option to BURN a FROZEN NFT    if there Frozen cause of being staked etc Fine.. But we all want to be able to BURN Crap .... But of course that is my own personal opinion!

So if iread through the lines, what al the developers basically want is we all only use a burner wallet so if scam get send there (since that is only wallet we use then with connecting to for example lmnft ) if it get filled with frozen crap we just delete the wallet and make a new . So we have to keep making wallets and keep sending good nft's around ??
Just give the option to BURN a FROZEN NFT if there Frozen cause of being staked etc Fine.. But we all want to be able to BURN Crap .... But of course that is my own personal opinion!

How do you know, programmatically, on-chain, if it's frozen because of staking or because it's a scam?

no-one would burn a NFT that is staked at-least not if they good in there mind
We all want to be able to BURN if it is crap  So make Frozen still able to be Burned
I assume Since it is programmatically possible to see what payed royalty  and it can see if it is staked , then it should be possible  programmatically able as well to set it that it can be burned  ... perhaps time to make special Burn address so it can be written in it .. making a exception on the frozen to be able to send it specific to that special address

no-one would burn a NFT that is staked at-least not if they good in there mind We all want to be able to BURN if it is crap So make Frozen still able to be Burned
I assume Since it is programmatically possible to see what payed royalty and it can see if it is staked , then it should be possible programmatically able as well to set it that it can be burned ... perhaps time to make special Burn address so it can be written in it .. making a exception on the frozen to be able to send it specific to that special address . eth got a burn address As we all know (burn is not really burn it just be send to a address that only has a in not a out)

Staking isn't the only use-case for freezing. Escrowless lending, for example, would not work at all if an angry user could burn their frozen token when they defaulted on a debt. The whole point of freezing is to prevent a user from being able to perform certain actions, burn being one of them. I get that it's frustrating, but trying to get consensus to change the non-updateable Token Program via a validator runtime update isn't the way to go, IMO.
I'll refrain from further comment here on the Github thread but invite you to ping me on Twitter if you want to discuss the issue and ideas to solve it as it's definitely a major annoyance in the ecosystem. @samvwaal

can I burn freeze-delegated NFT if I have an update authority of collection?

Any update how to burn this trash i have nft and token that i can't burn it on my lovely wallet ?

still no update?

At this point I think it's clear that we aren't going to change SPL Token (legacy) or SPL Token-2022 to support burning frozen NFTs/tokens. The drawbacks of such a change far outweigh the benefits, considering most wallets now support custom "hide" lists.
I'm going to close this issue unless any other maintainers feel differently.


Include has_many through: relationship fails

With the following set of models:
class User < ActiveRecord::Base
    ...
    has_many :participations
    has_many :attempts, through: :participations
    has_many :completed_attempts, -> { completed }, through: :participations, source: :attempts
    ...
end

class Participation < ActiveRecord::Base
    ...
    belongs_to :user
    has_many :attempts
    ...
end

class Attempt < ActiveRecord::Base
    ...
    belongs_to :participation
    ...
end

the request GET /users/1?include=completed-attempts fails. completed-attempts.txt.
Likewise, GET /users/1?include=completed-attempts,attempts fails. completed-attempts_attempts.txt
However, as expected, GET /users/1?include=attempts works. attempts.txt
Changing the order, GET /users/1?include=attempts,completed-attempts, doesn't fail with a 500, however it returns the full list of Attempts for both the attempts and completed-attempts relationships. attempts_completed-attempts.txt
Querying the relations directly from the AR object works correctly for both attempts and completed_attempts.

What do your resources look like? Do you have a relationship defined for completed_attempts? For example:
class UserResource < JSONAPI::Resource
  has_many :attempts
  has_many :completed_attempts, class_name: 'Attempt'
end

Ah yes, forgot to add that.
I have both those has_many relations, however I hadn't added the class_name param, thinking it was sourced from the AR relation.
I'll check that out and see whether specifying that helps in this case.

I can't even get the rails server to start with "belongs_to":
method_missing: undefined method 'belongs_to' for OrderitemResource:Class
Here are my "shopping cart" models:
class ItemResource < JSONAPI::Resource
  attributes :label, :price
  has_many :orderitems
  has_many :orders, through: :orderitems

  filter :order
end

class OrderResource < JSONAPI::Resource
  attributes :payment_fname, :payment_lname, :payment_email
  has_many :orderitems
  has_many :items, through: :orderitems
end

class OrderitemResource < JSONAPI::Resource
  attributes :qty
  belongs_to :order
  belongs_to :item
end

I'm new to this gem and just testing it out to see if it's going to work for my project. Are many-to-many relationships supported?

@sdellis: in your situation you need to add belongs_to etc to the ActiveRecord model that is associated with the JSONAPI::Resource. Some of that logic is replicated in the resource layer, but most of it is defined in the model.

@msbit Thank you! That worked. (But it seems that the use of underscores in properties/columns is problematic? For example, I'm getting a "param not allowed" for "payment_fname". Don't want to hijack this issue, so perhaps I should start a new one?)

@sdellis: Yep, there is an implicit renaming of params for the JSON API spec, so payment_fname becomes payment-fname for submissions and responses.

The default key formatter is dasherized, which is why the params are being renamed. To use underscores set the config.json_key_format to :underscored_key

@lgebhardt adding class_name didn't change anything, and it looks like that is automatically determined from the association:
lib/jsonapi/resource.rb:778:   options[:class_name] ||= model_association.class_name
I've discovered that I can work around it via:
has_many :completed_attempts, relation_name: ->(options) {
  if options[:include_directives]
    [:participations, :completed_attempts]
  else
    :completed_attempts
  end
}

but this seems a little brittle for my liking.


Testing, please ignore. (jhcqjc)

This is a bug bounty test.. Please DO NOT APPROVE THIS! (jhcqjc)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jhcqjc lbhpm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


image_client.py due to message type error

Hi,
I ran inference servers (using nvcr.io/nvidia/tensorrtserver:19.01-py3) and sent http request using image_client.py without modification (building Dockerfile).
Sent one request
$  python3 src/clients/python/image_client.py -m plan_model -s INCEPTION -u <IP_ADDRESS>:8000 /opt/tensorrtserver/qa/images/mug.jpg
This is part of outputs
Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8000 (#0)
POST /api/infer/plan_model?format=binary HTTP/1.1
Host: <IP_ADDRESS>:8000
User-Agent: libcurl-agent/1.0
Accept: /
Content-Type: application/octet-stream
NV-InferRequest:batch_size: 1 input { name: "input" dims: 3 dims: 299 dims: 299 } output { name: "InceptionV3/Logits/SpatialSqueeze" cls { count: 1 } }
Content-Length: 1072812
We are completely uploaded and fine
HTTP/1.1 400 Bad Request
NV-Status: code: INVALID_ARG msg: "unable to parse request for model 'plan_model'" server_id: "inference:0"
Content-Type: application/octet-stream
Date: Thu, 14 Feb 2019 01:50:56 GMT
Content-Length: 0
Connection #0 to host <IP_ADDRESS> left intact
Traceback (most recent call last):
File "src/clients/python/image_client.py", line 304, in
FLAGS.batch_size))
File "/usr/local/lib/python3.5/dist-packages/tensorrtserver/api/init.py", line 844, in run
self._last_request_id = _raise_if_error(c_void_p(_crequest_infer_ctx_run(self._ctx)))
File "/usr/local/lib/python3.5/dist-packages/tensorrtserver/api/init.py", line 183, in _raise_if_error
raise ex
tensorrtserver.api.InferenceServerException: [inference:0 0] unable to parse request for model 'plan_model'
In inference server side, it showed
[libprotobuf ERROR external/protobuf_archive/src/google/protobuf/text_format.cc:307] Error parsing text-format nvidia.inferenceserver.InferRequestHeader: 1:41: Message type "nvidia.inferenceserver.InferRequestHeader.Input" has no field named "dims".
E0214 01:29:37.093842 7363 server_status.cc:374] Unable to collect inference metrics for nullptr servable
Based on this file (https://github.com/NVIDIA/tensorrt-inference-server/blob/master/src/core/api.proto), there is dims field in Input.
This is my "config.pbtxt" file.
name: "plan_model"
platform: "tensorrt_plan"
max_batch_size: 1
input [
{
name: "input"
data_type: TYPE_FP32
format: FORMAT_NCHW
dims: [3, 299, 299]
}
]
output [
{
name: "InceptionV3/Logits/SpatialSqueeze"
data_type: TYPE_FP32
dims: [1, 1, 1001]
label_filename: "imagenet_labels_1001.txt"
}
]
I guess request format has some issues related to dims part.
However, I am not clear.
Do you have any insight of this problem?
Thanks,

Can you try to check out branch r19.01 and modify your "config.pbtxt" file based on that branch? Field "dim" is newly added and it is not in the 19.01 release.

Hi, GuanLuo
Thank you for a fast response.
In r19.01 examples, they still used "dim" Field in *.pbtxt.
So, I tried with branch r19.01 in a client side and it worked without modifying a inference server side (i.e., do not modify config.pbtxt) file.
However, I am not sure whether the output is correct or not.
When I ran,
./image_client -m plan_model -s INCEPTION -u <IP_ADDRESS>:8000 -v -c 5 ../qa/images/mug.jpg
This is part of outputs
HTTP/1.1 200 OK
NV-Status: code: SUCCESS server_id: "inference:0" request_id: 4
Content-Type: application/octet-stream
Date: Thu, 14 Feb 2019 04:41:43 GMT
Content-Length: 159
Connection #0 to host <IP_ADDRESS> left intact
Request 0, batch size 1
Image '../qa/images/mug.jpg':
505 (coffee mug) = 9.27169
969 (cup) = 7.70286
968 (espresso) = 3.70387
726 (pitcher, ewer) = 3.70011
900 (water jug) = 3.52816
I expects below results (i.e., each output is less than 1), but they are over 1 in my output.
Output probabilities:
batch 0: 504 (COFFEE MUG) = 0.777365267277
batch 0: 968 (CUP) = 0.213909029961
batch 0: 967 (ESPRESSO) = 0.00294389552437
Prediction totals:
cnt=1        (504) COFFEE MUG
Do you have any insight of this problem?

It seems that softmax layer is missing, InceptionV3/Logits/SpatialSqueeze layer output must be passed to a softmax.

@JungukCho as @SlipknotTN notes is seems you are taking the wrong output from the model. The inception model TRTIS provides as an example uses InceptionV3/Predictions/Softmax as an output (https://github.com/NVIDIA/tensorrt-inference-server/blob/f64cf7dda0ecdae2e2c0396ca6f85ee5c65eb0e3/docs/examples/model_repository/inception_graphdef/config.pbtxt#L14)

Hi,
Thank you for response.
After changing the output in config.pbtxt and updated plan file correctly based on the output,
I got
Image '../qa/images/mug.jpg':
505 (coffee mug) = 0.75413
969 (cup) = 0.157077
968 (espresso) = 0.00287988
726 (pitcher, ewer) = 0.00286906
900 (water jug) = 0.0024158
Thanks.


KOGITO-5735: Stunner - Provide an improved JS API to interact with nodes and connectors

Hey @romartin, Please could you review this PR?
JIRA: KOGITO-5735
Referenced Pull Requests:
https://github.com/kiegroup/kogito-editors-java/pull/117

@handreyrc Is this testable at this point? If yes could you please provide some steps to work with the API?

@domhanak Hi Dominik! To test this PR, you need to use the browser console and directly call the provided methods. This PR is a preliminary work before we actually start to consume this API. Most important thing is that this PR doesn't break anything and enables us to develop on top of the new APIs in the future.

Hey @domhanak,
You can test it using the online-editor as @tiagobento suggested. By selecting the editor frame in the browser console and calling the methods directly. However, it won't go through the envelope.
In the browser conslole you can call the following methods directly:

window.jsLienzo.getNodeIds()
window.jsLienzo.getBackgroundColor("some node UUID")
window.jsLienzo.setBackgroundColor("some node UUID", "some color e.g. red")
window.jsLienzo.getBorderColor("some node UUID")
window.jsLienzo.setBorderColor("some node UUID", "some color e.g. green")
window.jsLienzo.getLocation("some node UUID")
window.jsLienzo.getAbsoluteLocation("some node UUID")
window.jsLienzo.getDimensions("some node UUID")

Alternatively, I generated a war file with the online-editor embedded and the envelopeServer exposed through an object you can access from the browser console. However, it is only for testing purposes so it is not in the PR.
Online editor: online-editor
Once the war is deployed just go to the browser console and you can call the following methods:

await jsLienzoTest.envelopeApi.requests.jsLienzo_getNodeIds()
await jsLienzoTest.envelopeApi.requests.jsLienzo_getBackgroundColor("some node UUID")
await jsLienzoTest.envelopeApi.requests.jsLienzo_setBackgroundColor("some node UUID", "some color e.g. red")
await jsLienzoTest.envelopeApi.requests.jsLienzo_getBorderColor("some node UUID")
await jsLienzoTest.envelopeApi.requests.jsLienzo_setBorderColor("some node UUID", "some color e.g. green")
await jsLienzoTest.envelopeApi.requests.jsLienzo_getLocation("some node UUID")
await jsLienzoTest.envelopeApi.requests.jsLienzo_getAbsoluteLocation("some node UUID")
await jsLienzoTest.envelopeApi.requests.jsLienzo_getDimensions("some node UUID")

Thanks!

@tiagobento @handreyrc cool, I tried that in VSCode and it did not work. Will check in online editor then.

@handreyrc Is this new API already present on 8.4.0? Or do we need a new release?

@tiagobento All works now for me, sending a PR with JSDoc to clarify a few things, but so far it works well.

@handreyrc  @tiagobento check here please https://github.com/handreyrc/kogito-tooling/pull/1/files

@jesuino can you please check if this is enough for heatmaps use cases?

@paulovmr can you please check if this is enough for your needs on runtimes?

Sorry I duplicated usernames on the comment above. See ^ @handreyrc

Hi @romartin canvas sounds suitable in my opinion

:+1: @romartin sound good, we should also provide suitable docs. My proposal is PRed on @handreyrc fork

Please let me know when this PR is good for reviewing again.

Hey @tiagobento  @domhanak @romartin,
@tiagobento , the error threatment you asked was implemented.
We are good for one round more!
Online editor: online_editor
Thanks guys!

@romartin @domhanak Hi! Can you please review?


Improve article 1805.00212

Exact location of issue
Section 1.2 Algorithm 1.
Section 5.1 Figure 2.
Problem details

the latex constructs of "the Algorithm environment" and the "Figure" are supported inaccurately.
The text and fomulae of the Algorithm and the Figure are strange.

@toxdd could you provide more specific details about the inaccuracies that you are noticing?
For example, here is the current PDF for Algorithm 1:

And this is the rendered HTML on a wide screen, using Firefox:

Is the issue the vertical bars after the line numbers that are only visible in HTML? Or something else? Feel free to provide as long of a list as needed.

Thank you, this feedback is very helpful! I'll let you know when we revise the details.


feat: add toaster

:tada: This PR is included in version 1.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


it not connect to vscode

I am get this pop up for an while and i am get this Sign in failed: ConnectError: [deadline_exceeded] the op
i might me miss something ..

This repo is not the VS Code one.


Makefile enhancements

Make the build more configurable.
Follow the commonly-accepted meaning of DESTDIR and prefix variables in the Makefile.

Uh, davvid?

Hello.  It looks like this branch has gone stale.  It's been a while since I've taken a look at this PR.
Would you like me to take a stab at rebasing and updating this series to the latest "master" branch?  I guess a better question is whether these changes are desired.
I'd like to kick these changes upstream because so that we don't have to tweak openvdb at $dayjob for build-related stuff.  If this is desirable then I can take another stab.
The only caveat is that this will change the semantics of the existing build setup.  IMO that is okay because the existing semantics are ad-hoc and non-standard, so using the "standard" GNU makefile variables, etc. will only help packagers in the future.
Let me know if I should rebase this branch.  If so I'll take a stab at it again when I get a chance.

I'm going to close this one out now this is pretty old and the focus is now on improving the CMake build. Thanks for the contribution nonetheless.

Sweet, I'll have a few updates coming for the cmake build instead.  Namely, start using GNUInstallDirs so that we can do install(.... DESTINATION ${CMAKE_INSTALL_LIBDIR}) etc. in the various install() places.  cheers


Added MIT License

The MIT license is already specified in the package.json: https://github.com/webmodules/dom-serialize/blob/master/package.json#L21. This PR adds an explict LICENSE file.

The test failures because there are no saucelabs credentials.
Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided


ClosestPointToPointParameter in src/Line3.js

This function returns another function that takes in a point and a 'clampToLine' parameter. However, within this inner function, the line's start and end are called but the function, at this point, has lost scope of the the start and end of line, and we get the error:
undefined is not an object (evaluating 'this.start')
I am trying to write test for this function, and I suggest that instead of returning a function, why not just run the internal function directly? Once again, this might be a non-issue, but I find the issues page to be the most effective resource at resolving confusions such as this.

I think we aren't actually using closestPointToPoint whatsoever in Cornerstone Tools, so maybe we should just remove it.


Add Skiff - privacy-first, E2EE email

Data added in data.yml
Tested via yarn dev

Let me know if other tests are needed.

I have been using Skiff products for a while now. It has great UI/UX. In this case, you don't have to compromise on convenience to use a privacy-respecting tool. Features that make them stand out - completely opensource, Brave Wallet/Metamask login etc.

Thanks @amilich for the contribution
Skiff looks awesome, I will verify everything here and then (if all checks out) get it merged this weekend.
In the meantime, (I should have added this to the PR template), but could you confirm if your associated with the project in any way, just for transparency.
Thanks very much!

Thank you!
And yes, certainly - I'm one of the creators of Skiff. I received a couple Twitter DMs/mentions in the last week to submit a PR.

Merged!
I think Skiff would also be a good fit for Awesome-Privacy, and that repo gets considerably more traffic than this one. Feel free to open a PR over there, and I can drop it a review :)

Merged! I think Skiff would also be a good fit for Awesome-Privacy, and that repo gets considerably more traffic than this one. Feel free to open a PR over there, and I can drop it a review :)

Great idea! Thanks for the suggestion. I'll open up a PR now :)

Just created https://github.com/Lissy93/awesome-privacy/pull/101


syntax error in activation script for zsh

https://github.com/conda-forge/openjdk-feedstock/blob/01efaec1ac9eea803011181e588796cf412cd308/recipe/scripts/activate.sh#L7
weirdly, this if statement line does not seem to be valid code for zsh:
getting
/home/croth1/miniconda2/envs/PARpipe/etc/conda/activate.d/java_home.sh:7: = not found

ah, it's this one: https://unix.stackexchange.com/questions/255480/why-does-behave-differently-inside-in-zsh-and-bash


Edit EditApplicant

Bug was found, the parser did not read any input if editapplicant
was used with only nric field.
Realized that it was missed out in isAnyFieldEdited() method in
EditApplicant class

Codecov Report

Merging #140 (7b19d1f) into master (68a1339) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     71.49%   71.05%   -0.44%
- Complexity      639      642       +3
============================================
  Files           105      107       +2
  Lines          2168     2187      +19
  Branches        267      269       +2
============================================
+ Hits           1550     1554       +4
- Misses          524      539      +15
  Partials         94       94

Impacted Files
Coverage Δ

...ddress/logic/commands/applicant/EditApplicant.java
98.01% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
69.56% <0.00%> (-6.63%)
:arrow_down:

...va/seedu/address/logic/commands/CommandResult.java
82.60% <0.00%> (-5.63%)
:arrow_down:

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
66.66% <0.00%> (ø)

...java/seedu/address/logic/commands/job/ListJob.java
0.00% <0.00%> (ø)

...ddress/logic/commands/applicant/ListApplicant.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a1339...7b19d1f. Read the comment docs.


Eloquent pagination method ignoring columns for the query count

Laravel Version: 5.2.45
PHP Version: 5.5.9
Database Driver & Version: MySQL v5.5.55

Description:
I'm using the model paginate method, and it doesn't pass in the $columns parameter into the $query->getCountForPagination() line, where I reckon that it should, seeing that I want to pass a single value as the $columns (an id) and it's just ignored :) (Sorry for my poor explanation, I'll paste the code below, might be easier to understand!)
Note: This is in \Illuminate\Database\Eloquent\Builder
/**
 * Paginate the given query.
 *
 * @param  int  $perPage
 * @param  array  $columns
 * @param  string  $pageName
 * @param  int|null  $page
 * @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
 *
 * @throws \InvalidArgumentException
 */
public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
{
    $page = $page ?: Paginator::resolveCurrentPage($pageName);

    $perPage = $perPage ?: $this->model->getPerPage();

    $query = $this->toBase();

    // This line should be $total = $query->getCountForPagination($columns);
    $total = $query->getCountForPagination();

    $results = $total ? $this->forPage($page, $perPage)->get($columns) : new Collection;

    return new LengthAwarePaginator($results, $total, $perPage, $page, [
        'path' => Paginator::resolveCurrentPath(),
        'pageName' => $pageName,
    ]);
}

Steps To Reproduce:
DB::enableQueryLog();
$query = \App\Models\Jobs::paginate(15, ['jobs.id']);

dd(DB::getQueryLog());

Result:
array:2 [▼
  0 => array:3 [▼
    "query" => "select count(*) as aggregate from `jobs` where `jobs`.`deleted_at` is null"
    "bindings" => []
    "time" => 0.16
  ]
  1 => array:3 [▼
    "query" => "select `jobs`.`id` from `jobs` where `jobs`.`deleted_at` is null limit 15 offset 0"
    "bindings" => []
    "time" => 0.25
  ]
]

Suggested Fix
Add the $columns variable into the getCountForPagination function for the model pagination, and/or make it a string instead of an array
Current Workaround
My current workaround is almost a copy paste of the actual paginate method inside my own paginate method, with the $columns variable added in, but this seems like so much overkill!

5.2 is not supported anymore, please upgrade to the latest release.


[showModalBottomSheet] fix: showModalBottomSheet does not move along keyboard

Description
This issue was found in release 1.22, 1.23, 1.24 that the showModelBottomSheet was not moving along the keyboard, the bottom sheet contains a TextField which open up the keyboard on focus, so if the height of bottom sheet is less then the height of keyboard then the bottom sheet was hidden behind the keyboard.
showModelBottomSheet with TextField unfocused:

When we Focus on TextField - Before Changes:
Bottom Sheet is hidden behind the keyboard.

When we Focus on TextField - After Changes:

Related Issues
https://github.com/flutter/flutter/issues/71418
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

Kindly review my pull request.

I'm writing a test for this PR.

Suggested changes done.

Suggested changes done.

@dkwingsmt Updated my branch to the latest master. That should resolve the failing customer tests.

@dkwingsmt Updated my branch to the latest master. That should resolve the failing customer tests.

?

?

@dkwingsmt Could we have a way to make this change opt out? I currently have some modal bottom sheets where I place the textfields (usually for filtering results) at the top of a quite large bottomSheet, so the keyboard will not hide it. With this PR everything will be pushed above the keyboard which may be considered somewhat breaking. What are your thoughts?

@dkwingsmt Could we have a way to make this change opt out? I currently have some modal bottom sheets where I place the textfields (usually for filtering results) at the top of a quite large bottomSheet, so the keyboard will not hide it. With this PR everything will be pushed above the keyboard which may be considered somewhat breaking. What are your thoughts?

@davidmartos96 You are right. Although to make a modal bottom sheet hidden by the on-screen keyboard does not really sound correct to me. When a displayed modal bottom sheet is supposed to prevent the user from interacting with the rest of the app. Will normal showBottomSheet suit your needs?

@davidmartos96 You are right. Although to make a modal bottom sheet hidden by the on-screen keyboard does not really sound correct to me. When a displayed modal bottom sheet is supposed to prevent the user from interacting with the rest of the app. Will normal showBottomSheet suit your needs?

@dkwingsmt I may have not expressed myself correctly. Sorry about that.
The usecase I'm referring to is a TextField inside the modal bottom sheet, but where the bottom sheet will be about 70% tall of the screen height. I have some of those modal sheets in my app, but I display the text field at the top knowing that up to now the keyboard would hide the lower portion of the bottom sheet (and I'm fine with that in my usecase).
With the PR I worry that all the bottom sheet will be pushed too much overflowing the screen height. I agree with the changes made in the PR but I would suggest including an option similar to resizeToAvoidBottomInset in the Scaffold so that this behavior can be opted out (https://api.flutter.dev/flutter/material/Scaffold/resizeToAvoidBottomInset.html)
If the Flutter team agrees to such new option I could open a PR with it.

@dkwingsmt I may have not expressed myself correctly. Sorry about that.
The usecase I'm referring to is a TextField inside the modal bottom sheet, but where the bottom sheet will be about 70% tall of the screen height. I have some of those modal sheets in my app, but I display the text field at the top knowing that up to now the keyboard would hide the lower portion of the bottom sheet (and I'm fine with that in my usecase).
With the PR I worry that all the bottom sheet will be pushed too much overflowing the screen height. I agree with the changes made in the PR but I would suggest including an option similar to resizeToAvoidBottomInset in the Scaffold so that this behavior can be opted out (https://api.flutter.dev/flutter/material/Scaffold/resizeToAvoidBottomInset.html)
If the Flutter team agrees to such new option I could open a PR with it.

Can you achieve the same result by manually applying a negative bottom padding? Actually, you can get the height of your sheet and the screen height to calculate the exact amount of underflow for you to avoid overflowing.

Can you achieve the same result by manually applying a negative bottom padding? Actually, you can get the height of your sheet and the screen height to calculate the exact amount of underflow for you to avoid overflowing.

@dkwingsmt I'm not sure I follow you with the negative padding. Does Flutter support negative padding?

@dkwingsmt I'm not sure I follow you with the negative padding. Does Flutter support negative padding?

Personally, I think this is a bad idea to force ModalBottomSheet to resize itself. I am experiencing the same issue as @davidmartos96 says.
At least we need a parameter to control if the ModalBottomSheet should resize or not (). And why padding should wrap BottomSheet to force resize to avoid keyboard? (we can just add padding inside ModalBottomSheet to achieve the same effect.)

@HansMuller Are you more familiar with how Material Design defines ModelBottomSheet? Can you take a look at the requests above?

Thanks for your quick response!
Please imagine ModalBottomSheet takes 5/6 of full-screen height and it used to pick a country(e.g. New Zealand), so it will be a scrollable list and contains many items, and on the top of this list, there is a search bar that contains a TextField.
If the ModalBottonSheet forcibly resizes as the keyboard shows, It will push the search bar to the very top of the screen, it not only breaks the UI looking but also break the feature. Because the phone notification bar will overlay on it.
Moreover, padding when the keyboard shows is a brutal way to avoid keyboard overlay. Please check out this https://pub.dev/packages/keyboard_avoider package. I don't think flutter should limit us on how to design the Application.

We're reverting this PR in https://github.com/flutter/flutter/pull/77286. Various sources have reported that the previous behavior is the desired one. /cc @ZainUrRehmanKhan


Deserialize error

    #[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
    #[serde(untagged)]
    pub enum TestValue {
        String(String),
        Number(u64),
        Bool(bool),
    }

    #[test]
    fn test_value() {
        let serialized = serialize_little(&TestValue::String(String::from("124")), Infinite).unwrap();
        let _: TestValue = deserialize_little(&mut &serialized[..]).unwrap();
    }

Error message:
---- types::rpc_request::tests::test_value stdout ----
	thread 'types::rpc_request::tests::test_value' panicked at 'called `Result::unwrap()` on an `Err` value: Custom("bincode does not support Deserializer::deserialize")', src/libcore/result.rs:860
note: Run with `RUST_BACKTRACE=1` for a backtrace.

It will pass if I remove #[serde(untagged)].

Bincode does not support untagged enums. Staring at some bytes, there is no way to tell whether those bytes came from a string or number or boolean. If you need to use bincode then use tagged enums.

Thank you.

Staring at some bytes, there is no way to tell whether those bytes came from a string or number or boolean.

Would it not be possible to devote one byte to select the right variant for an enum and then read it?
I know it wouldn't work for very long untagged enums, but for common cases like 2 variants, that should be enough, no?

That's not an untagged enum anymore...
If you mean a byte for type information, not for the variant tag: that's not Bincode anymore...

No, I meant for the variant thing.
I have a use case where the same struct is deserialized from JSON (out of my control) and I want to be able to serialize/deserialize it using bincode for performance.
In result, since in JSON we have to deserialize based on "shape", I need to use untagged, but then I can serialize/deserialize bincode however I want, so adding a byte that says basically "variant 0" or "variant 1" and the proceeding bytes store the value, feel like it should be doable, but I'm not very familiar with intrinsics of bincode.

I am running in the same issue here, deserialization from JSON, and sterilization into bincode.

@zbraniecki if you use a byte to store the variant though, then its not an untagged enum anymore. Serde just tells us to serialize a struct, we get no information that this is an enum at all, so we couldn't put a variant on it anyways.

I see. Maybe there's some information we could get out of serde? If you knew you're looking at an untagged enum, you could take the first byte as a variant selection?

I looked at serde and there doesn't seem to be a way to get extra info out of it. You should probably open an issue on serde.


linfa.models is not included in built packages

Hi @daneschi, I've started my JOSS review and encountered the following issue:
python3 -m venv venv
. venv/bin/activate
pip install linfa-vi
python -m unittest linfa.linfa_test_suite.trivial_example
# ModuleNotFoundError: No module named 'linfa.models'

I can see that linfa.models exists in the repository itself, and the tests run successfully on GitHub CI. The cause appears to be that linfa.models isn't being included in the wheel or sdist. However, because the repository has a "flat layout", linfa.models can be imported from the source directory when running the CI tests.
The packages can be fixed by making the following changes to pyproject.toml:
[tool.setuptools]
packages = ["linfa", "linfa.models", "linfa.tests"]

or. to avoid having to manually list each sub-package:
[tool.setuptools]
packages.find.include = ["linfa*"]

If you would like to ensure that the CI tests are being run against the built package, you could switch to a "src layout" (move linfa to src/linfa), and install the built package before running the tests. It's a little fiddlier, and a tool such as tox or nox can be helpful for this kind of thing. This is just a thought, I'm not suggesting you should do this as part of the JOSS review.

Hi, just checking in and wondering if you've had a look at this issue?

Thank you for your comments, I have fixed this issue as you suggested by adding "linfa.models" to the list of packages.  Thank you also for the interesting suggestion to change the layout and use additional tools. I'll take a look at tox/nox.


fixed #1656 checking for empty string

Fix for #1656. if config is empty string, it should be ignored.

Overceded by https://github.com/selenide/selenide/pull/1663


Huge changes

Refacto
Replace emojis list with gitmoji
Add --init option

Wow! This looks amazing! Thanks! I will have a look and get back to you BUT this PR will be accepted!

Looking good. I just have a few question.

@tjoskar I just fix things after your feedback, thank you for it!

@welcoMattic, great but I still thinks we need to check if the file exists before we override the content, see https://github.com/tjoskar/emoji-commit-hook/pull/2#discussion_r89191596
Something like this:
if (process.argv[2] === '--init') {
  if (!pathExists.sync('.git')) {
    errorHandler('The directory is not a git repository.');
  }
  if (fileExists(${path}/prepare-commit-msg)) {
    errorHandler(`A prepare-commit hook already exists, please remove the hook (rm .git/hooks/prepare-commit-msg) or install gitmoji-commit-hook manually by adding the following content info ${${path}/prepare-commit-msg}: \nexec < /dev/tty\ngitmoji-commit-hook $1`);
  }

  fs.writeFile(${path}/prepare-commit-msg, `#!/bin/sh\nexec < /dev/tty\ngitmoji-commit-hook $1`, (err) => {
    if (err) {
      errorHandler(err);
    } else {
      fs.chmod(${path}/prepare-commit-msg, '755', (err) => {
        if (err) {
          errorHandler(err);
        } else {
          console.log(`${chalk.green('🎉  SUCCESS 🎉')}  gitmoji-commit-hook initialized with success.`);
        }
      });
    }
  });
} else {
  axios.get(gitmojis)
  ...

Or what do you think?

@tjoskar Done ;)


SASS Adding a prefix with @forward

Hi,
I've came across some weird behaviour when I try to compile this:
In this sample I want to 'forward' variables from the variables file to the main one using a prefix 'vars-*'. After this I'm getting:

File: _variables.scss
$bg-main-color: rgb(231, 177, 27);
$width: 100px;
$value: 1;
$primary: #b86f26;
$accent: #eb1680;
$warn: #791ba5;

_File: styles.scss
@forward "variables" as vars-*;
$varStyles: #437812;

h1 {
  background-color: $varStyles;
}

File3: main.scss
@use "styles";

h2 {
  background-color: styles.$varStyles;
}

h3 {
  background-color: styles.vars-$accent;
}

Is this an issue or I am doing something wrong?
Reference https://sass-lang.com/documentation/at-rules/forward#adding-a-prefix

@forward "variables" as vars-*;
$varStyles: #437812;
h1 {
background-color: $varStyles;
}

This grammar should not be supported yet, so this error was reported https://github.com/sass/dart-sass/issues/1042.


cargo-binstall: 1.10.4 -> 1.10.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cargo-bins/cargo-binstall/releases.
meta.description for cargo-binstall is: Tool for installing rust binaries as an alternative to building from source
meta.homepage for cargo-binstall is: https://github.com/cargo-bins/cargo-binstall
meta.changelog for cargo-binstall is: https://github.com/cargo-bins/cargo-binstall/releases/tag/v1.10.5
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.10.5 with grep in /nix/store/h9k38hkaq47rwm0bz6v0kim1szn6wkai-cargo-binstall-1.10.5
found 1.10.5 in filename of file in /nix/store/h9k38hkaq47rwm0bz6v0kim1szn6wkai-cargo-binstall-1.10.5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

cargo-binstall

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h9k38hkaq47rwm0bz6v0kim1szn6wkai-cargo-binstall-1.10.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-binstall https://github.com/r-ryantm/nixpkgs/archive/da0bdd3ea2a6604c9111262f0b877e569902ebb2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/da0bdd3ea2a6604c9111262f0b877e569902ebb2#cargo-binstall

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h9k38hkaq47rwm0bz6v0kim1szn6wkai-cargo-binstall-1.10.5
ls -la /nix/store/h9k38hkaq47rwm0bz6v0kim1szn6wkai-cargo-binstall-1.10.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-binstall

Maintainer pings
cc @figsoda for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 342737 run on x86_64-linux 1

1 package built:

cargo-binstall


no silent rescue

Comparable#== no longer silently rescues any Exception.
[ruby-core:51389] [Bug #7688]

Travis CI's "ruby-trunk" is out of date.

@nobu I did PR #23 to solve this but it was not merged yet.
I'm sad to duplicate efforts but unfortunately I could not merge #23 myself, I guess I should have ping'ed you.


Release for specs2 3.1

Would it be possible to get a release for the latest version of specs2?

can we also bump scalacheck? I think the latest version is 1.12.2

Yes, will do, probably on Saturday.

Thank you @larsrh

Just uploaded 0.4.0 to Sonatype.

@larsrh could you cross build it? 0.4.0 doesn't exist for scala 2.10

I just realised that I bumped to specs2 3.2, which apparently doesn't exist for 2.10. /cc @etorreborre

Done. Sorry about that.

@larsrh would you mind to release a version for 2.10?

Sure thing, will do.

awesome, thanks

Done


Add EmberJS reference to README.md

Your library sparked much interest.  Great work! 💪  It's super nice to use!
Following your React example, we made an implementation for EmberJS at ember-lax.  It supports use by a component (a wrapping tag indicating useage of Lax) and by an element modifier (automatically triggering lax for a single element) based on the readme.
Can we add a reference to the readme?

Looks good - nice one!


cmd/cue: executing the import command twice does not give the same result

What version of CUE are you using (cue version)?
It can be reproduced with cue-v0.2.2 and cue-v0.3.0beta.7.
Does this issue reproduce with the latest release?
Yes
What did you do?
We have found a strange behavior in the command cue import.
Suppose this directory structure:
├── dir1
│   ├── dir2
│   │   └── file3.json
│   └── file2.json
└── file1.json

The first time cue import is executed, only file3.json is converted:
$ cue import -f -p mypackage ./dir1/dir2
$ tree
.
├── dir1
│   ├── dir2
│   │   ├── file3.cue
│   │   └── file3.json
│   └── file2.json
└── file1.json

But, if the same command is executed again, file1.json and file2.json are converted !!
$ cue import -f -p mypackage ./dir1/dir2
$ tree
.
├── dir1
│   ├── dir2
│   │   ├── file3.cue
│   │   └── file3.json
│   ├── file2.cue
│   └── file2.json
├── file1.cue
└── file1.json

The workaround to avoid this behaviour is specify "files" instead of "directory" as source for cue import:
$ cue import -f -p mypackage ./dir1/dir2/*
$ cue import -f -p mypackage ./dir1/dir2/*  # twice
$ tree
.
├── dir1
│   ├── dir2
│   │   ├── file3.cue  # only file3.json has been converted
│   │   └── file3.json
│   └── file2.json
└── file1.json

What did you expect to see?
The same result in both executions (it is not clear to me which is expected)

Hi @juanjoku - thanks for raising your first issue in the CUE project!
Just as an FYI, there are some tips on how to create clean reproducers in https://github.com/cuelang/cue/wiki/Creating-test-or-performance-reproducers. The txtar format is particularly good when it comes to multi-file repros, as is the case here.
For example, here is my reproducer based on the above:
# Run 1
exec cue import -f -p mypackage ./dir1/dir2
! exists file1.cue
! exists dir1/file2.cue
exists dir1/dir2/file3.cue

# Run 2
exec cue import -f -p mypackage ./dir1/dir2
! exists file1.cue
! exists dir1/file2.cue
exists dir1/dir2/file3.cue

-- cue.mod/module.cue --
module: "mod.com"
-- dir1/dir2/file3.json --
{
	"File3": true
}
-- dir1/file2.json --
{
	"File2": true
}
-- file1.json --
{
	"File1": true
}

What's interesting to note is this requires the -p flag, because the following "succeeds" (but is generally useless because the .cue files do not have package clauses):
# Run 1
exec cue import -f ./dir1/dir2
! exists file1.cue
! exists dir1/file2.cue
exists dir1/dir2/file3.cue

# Run 2
exec cue import -f ./dir1/dir2
! exists file1.cue
! exists dir1/file2.cue
exists dir1/dir2/file3.cue

-- cue.mod/module.cue --
module: "mod.com"
-- dir1/dir2/file3.json --
{
	"File3": true
}
-- dir1/file2.json --
{
	"File2": true
}
-- file1.json --
{
	"File1": true
}

So what you have observed is indeed a bug.

OK! (thx)

Note this also failed in v0.2.2 - so we will fix this after the release of v0.3.0 (so as not to delay that any longer)

This issue has been migrated to https://github.com/cue-lang/cue/issues/850.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Port it to telegram

Is your feature request related to a problem? Please describe.
The discord servers and account keep getting banned its just not stable
Describe the solution you'd like
Porting the bot to telegram would allow it so the channels and accounts won't get banned
Additional context
Just seems like a better option I know its very possible

do you get permanent banned or for a certain time. I wanna try this on my vms and other pc


Bug Fix: try to convert mistral hf model into mg gpt2 architecture

Original code use GPT2 config when convert mistral model from HF to MG.
Now it can successfully do the conversion.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add the container name to the log message when uploading files to one blob container

Storage Explorer Version: 1.9.0
Branch: master
Build: 20190725.2
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Make sure 'Use AzCopy for Improved Blob Upload and Download' is unchecked.
Expand a Non-ADLS Gen2 account -> Blob Containers.
Create a new blob container -> Upload a file to it.
Check the Activities.

Expect Experience:
Show "Uploaded 'file_name' to 'conatiner_name/file_name'"
Actual Experience:
Show "Uploaded 'file_name' to 'file_name'

Won't fix. AzCopy will become default upload/download path in the near feature.


Make colortbl parsing more robust

This PR fixes #81.
@MooDySmiles could you please test whether this change fixes your problem?

Pull Request Test Coverage Report for Build 228

8 of 11 (72.73%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 68.079%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/rtfjs/parser/destinations/ColortblDestinations.ts
8
11
72.73%

Totals

Change from base Build 223:
-0.01%

Covered Lines:
3227

Relevant Lines:
4470

💛  - Coveralls

Works like a charm! Thanks you! When are you planning on release this?

I'll merge the PR now and then create a new release


Rill Developer: Fix Welcome workflow

Upon selecting an example project, the user is now directed to the dashboard YAML, rather than to the dashboard Preview. This both gives the user context for what a Rill project is and it buys time for the chosen data to load. The "Preview" button is now disabled until the resource is ready (notably until all dependent sources have been ingested).
In its implementation, this PR simplifies (viz)/dashboard/[name]/+page.svelte and mirrors the +page.ts data loading approach taken in (viz)/custom/[name]/+page.svelte.
Addresses this UXQA bug report.

This is great. Couple things that this brings up, though they may not need to be addressed now.

We should probably get some better error pages at this point. I know Janet's been working on one. Not sure of the status.
There used to be some functionality that would redirect you to the /edit page in certain conditions. Not sure that it's strictly necessary, but this PR doesn't necessarily cover the case where you have a successful resource query, but the resource has an error (see below). Again, not strictly an issue, but we should either redirect or have a Dashboard error message in a case like this.
It's probably time to add a call to $app/navigation's invalidate function in the watch request clients so that these load functions run again when necessary. Though, we do have to resolve this issue with extraneous events first (see: https://rilldata.slack.com/archives/CTCJ58H3M/p1712333249276039).

We should probably get some better local error pages at this point. I know Janet's been working on one. Not sure of the status. Are the cloud ones generic enough to reuse?

Yeah, agreed, we can move the Cloud pages to web-common and re-use those.

There used to be some functionality that would redirect you to the /edit page in certain conditions. Not sure that it's strictly necessary, but this PR doesn't cover the case where you have a successful resource query, but the resource has an error (see below). Again, not a dealbreaker, but we should either redirect or have a Dashboard error message in a case like this.

Yeah, I removed that redirect because, if you're editing the dashboard YAML in an external IDE, that redirect would be quite annoying. I have an improvement in error handling that uses the Cloud error page – I'll submit that in a follow-on PR.

It's probably time to add a call to $app/navigation's invalidate function in the watch request clients so that these load functions run again when necessary. Though, we do have to resolve this issue with extraneous events first (see: https://rilldata.slack.com/archives/CTCJ58H3M/p1712333249276039).

I agree. In general our resource invalidation code could use some cleanup, so I'll leave that project out of this PR.


Enabling "Native Tabs" option breaks "Native Full Screen" option when disabled

Issue Type: Bug
On macOS when "Native tabs" is enabled and "Native Full Screen" is disabled, going full screen still creates a new space.

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.
Happy Coding!

Thank you for the extra details 👌🏽
It's not very clear from reading both options that they are mutually exclusive

I was sent into a wild chase trying to understand which setting was preventing the Native full screen disabling from doing what it advertises.


Type hint based CLI using Typer

Typer is the new hotness in the CLI world, made by the same people that made FaspAPI

$ fmskill --help
Usage: fmskill [OPTIONS] CONFIG_FILE OUTPUT_FOLDER [OUTPUT_FORMAT]

  fmskill: Automatic model skill assessment

Arguments:
  CONFIG_FILE      [required]
  OUTPUT_FOLDER    [required]
  [OUTPUT_FORMAT]  Choose: html or md  [default: html]

Options:
  --help  Show this message and exit.

Let fmskill remain a library for now to be used in a CLI app, notebook, web app etc..


Update pom.xml

👋 if you want to do some poking at this repo or fork for your own testing, please feel free 👍 happy to stamp whatever if it's helpful, sorry I didn't see this one before you closed it out


ci: build and publish image with sbom attestation

Which issue(s) this PR fixes:

Issue https://github.com/longhorn/longhorn/issues/5099
What this PR does / why we need it:
build and publish image with sbom attestation
Special notes for your reviewer:
Additional documentation or context

@mergify backport v1.6.x

@mergify backport v1.6.x


Add more tests

This an an issue to be motivation to myself to add more tests!!

I have added more tests! more to come!


Slider width does not get updated when container width is

@jebenois please add some details to the bug :) You can refer to ISSUE_TEMPLATE.md. Cheers!


redux: init at 1.2.2

Motivation for this change
I messed up the previous PR, sorry!
@IvarWithoutBones I implemented your suggestions, except for requireFile, unfortunately I cannot use it since builds are different for each individual, I added a note to reflect this.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

When running nixpkgs-review on this (so the default trail version), no binaries got installed. Only vst2/RenoiseRedux.vst2 is there. Is that expected? I'm not that familair with the project, but from what i can tell from screenshots it looks like a gui program.
Also, it'd be great if you could put the commit of the maintainer list addition before the redux: init  commit, and then just add the meta.maintainers attribute in straight away. Then you could have something like:
* maintainers: add mihnea-s # First
* redux: init at 1.2.2 # Second

Apologies for being a bit pedantic about this :sweat_smile:

When running nixpkgs-review on this (so the default trail version), no binaries got installed. Only vst2/RenoiseRedux.vst2 is there. Is that expected? I'm not that familair with the project, but from what i can tell from screenshots it looks like a gui program.

Yes, that is expected. VST Instruments aren't (usually) meant to be played on their own, instead they are packaged as shared objects (in this case vst2/RenoiseRedux.vst2/renoise_redux.so) which are loaded by DAWs to produce sound.

Apologies for being a bit pedantic about this sweat_smile

No problem. Hope everything is good now :)


Allow to specify end app page in the signature making

Changes required to make successful signature with the new bootloader. Made the end application page argument variable, so both new and old bootloader could work.
Related:
https://github.com/solokeys/solo/pull/238

Thanks!


the tags file is updated for the whole project, not just the saved file

I have a project, I have generated a tags file manually with this command:
ctags --exclude='app/public/components/*' app/
now, even if the readme says:
it will partially re-generate the tag file. Every time you save, it will silently, in the background, update the tags for that file.
every time I save a file, the tags file is updated to include every file in the project. since this plugin is supposed to work out of the box I'm not sure what I've done wrong...

Hi, sorry for the late reply.
The generated tag file is always for the whole project. What I meant in the README is that if you save one file, it will only parse that one file and update the tag file, instead of parsing the whole project (which most Vim plugins do).
So if you have a project with 3000 files in it, the initial cost of creating the tag file will be the cost of running ctags on 3000 files. But then if you edit app/public/foo.js and add a new function bar(), the tag file will contain all the symbols from the 3000 files, plus the new bar(), and it did this at the cost of only re-parsing app/public/foo.js.
Does that make sense?

yes, it makes sense, but the problem is that the plugin doesn't act that way. i'll try to rephrase my problem:
I have a project with 3000 files.
I generate a tag file with 1000 files (since the other 2000 are excluded)
I edit foo.js and add bar()
now the tag file includes 3000 files plus bar()
the 2000 files which were excluded are added even if they are not supposed to...

Ah ok.
How did you generate the project the first time? Did you run ctags yourself? If so, did you use some command line arguments to exclude the 2000 files, or used a custom options file? If so, Gutentags needs to know about it, so it excludes the files correctly. With the very latest version of the plugin, place a .gutctags options file at the root of your project and write the exclude rules in it (see the ctags documentation for more details about options files). Gutentags will use this options file when generating tags.
If however you had your rules defined globally with the user options file (I believe it's the ~/.ctags file?), it should be picked up automatically.

i generated the tag manually as explained in the first message. the command was:
ctags --exclude='app/public/components/*' app/
I have a .ctags file but it doesn't define the excluded file, I'll try the .gutctags file, thanks

Oh wow, sorry, I must have been drunk when I read your first message!
So yeah, add that exclude clause to the .gutctags file and it should work. Reopen this bug if it doesn't!

thanks :) i'll do some tests as soon as I've some time :)


Open a pop-out widget causes an error when the browser block the pop-up

Here are the browser console logs:
com.ponysdk.core.terminal.socket.WebSocketClient SEVERE: Error while processing the Buffer 248 ; position = 564 ; size = 566 com.google.gwt.core.client.JavaScriptException: (TypeError) : Cannot set property 'onunload' of null

Fix in https://github.com/Nciaravola/PonySDK/commit/6643bce9fb14c488b7463dec0bebfd2c86448bbe


Automated cherry pick of #11097: fix(region): allow update sku status

Cherry pick of #11097 on release/3.5.
#11097: fix(region): allow update sku status

Codecov Report

Merging #11100 (fa901e3) into release/3.5 (6a15e02) will increase coverage by 1.76%.
The diff coverage is 0.93%.

@@               Coverage Diff               @@
##           release/3.5   #11100      +/-   ##
===============================================
+ Coverage         5.98%    7.74%   +1.76%
===============================================
  Files              796      249     -547
  Lines           125693    34246   -91447
===============================================
- Hits              7522     2654    -4868
+ Misses          117504    31328   -86176
+ Partials           667      264     -403

Flag
Coverage Δ

aFlag
7.74% <0.93%> (+1.76%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/baremetal/cronjobs.go
0.00% <0.00%> (ø)

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/utils/ipmitool/ipmitool.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/cloudcommon/db/metadata.go
4.96% <0.00%> (-0.08%)
:arrow_down:

pkg/cloudcommon/db/opslog.go
1.36% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/rbac.go
0.75% <0.00%> (-0.03%)
:arrow_down:

pkg/cloudcommon/db/sharablebase.go
6.01% <0.00%> (-0.06%)
:arrow_down:

... and 492 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d9c22...fa901e3. Read the comment docs.


Facebook sign-in window doesn't allow users to sign in

Describe the bug
When a user tries to log in with Facebook, the popup window which should redirect them to an external Facebook sign-in page doesn't work, and simply says that 'something went wrong'.
Test cases
N/A - identified when reviewing PR #93
To Reproduce
Try and sign in using your Facebook login
Expected behavior
A popup appears which directs you to an external Facebook sign-in page, where you can then enter your Facebook credentials to sign in to your Facebook account.
Stack Traces
The following is a screenshot from the Console of the website in the browser, when Inspect Element is selected

Error Reports
N/A
Screenshots
This is the popup window which should allow the users to sign in with their Facebook credentials, but is instead in an error state.

The Facebook button in the screenshot below is the one which was clicked to cause the popup sign-in window to appear.

Device the bug was found on (please complete the following information):

Device: Surface Book 3
OS: Windows 10
Browser: Opera One
Version: 102.0.4880.78

Additional context
The Facebook server is throwing a 500 Internal Server Error.

I can confirm I have encountered this issue as well. After research it appears that Facebook have updated the version of their API to v18.0 and deprecated all other versions. Currently all react libraries use previous versions of the API that are only available if you created the Facebook developer app when that version was non-deprecated. Unfortunately this looks like it might be a bit of work to implement Facebook login - possibly could hold off implementing this feature until react components are updated to support v18.0 of Facebook's API?

I also trawled through a fair few Facebook blog posts, Github discussions and StackOverflow response to try and find the root cause of this issue, and it seems like the API update made by Facebook is the cause of this to me as well. I've only seen a couple of solutions, and they required the creation of React components from scratch and coordinating with Facebook developers to sync with them - this definitely doesn't seem like a plausible option given the scope of our upcoming release. It's a little unfortunate that Facebook won't extend their backwards compatibility to projects made after their API upgrade. Overall, I agree that the best course of action at this stage is to push the Facebook sign in implementation to a later release and close this issue, as there's little we can feasibly do from our end at this stage to make the sign-in work.


Adapt to e-h 1.0.0-alpha.10

I had to remove the e-h 0.2 implementations for the i2c::WriteIter and i2c::WriteIterRead traits, as we have no way of collecting outputs into a buffer.
Let me know if you would prefer to keep a best-effort implementation using a fixed size array (or configurable through a const parameter) or so.
Since the reason we removed them was that nobody was using them, this seems fair to me.
It should be noted that alpha.9 has been skipped. You may want to bump the version by 2?
Fixes #15

Ok, I fixed the tests now.

It should be noted that alpha.9 has been skipped. You may want to bump the version by 2?

hmm, yeah probably a good idea. thanks for the PR!


support references view as option for editor.gotoLocation.alternativeDeclarationCommand

Currently, the editor.gotoLocation.alternativeDeclarationCommand (and alternativeDefinitionCommand, and the other related settings) do not support specifying the references-view.findReferences action as the alternative command.
I prefer always using the references view when finding all references to a symbol, and I prefer to use a single keybinding for jump-to-definition and jump-to-references, so I'd like the flexibility to specify using the references view when jumping to references from a symbol definition.
Please add references-view.findReferences to the list of allowable options to the editor.gotoLocation.alternative* settings.
Thank you!

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Update prometheus/prometheus

This commit updates prometheus/prometheus to latest main (60b6266e).

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

Will need to check if test failures are legit.


Permission directive do not take permission-only/permisssion-except

Hey,
I'm a bit new to Angular and been using "angular-permission" for a personal project, while working with it I have recently updated to 2.3.8, I'm close to feature complete and I would not like to break something because of going to latest 3.0.x version. Although I found something funny with the permission directive, it was working perfectly fine on 2.2.4 and I see it not working on 2.3.8. I did a small change on it and I get it back to work, is this intentional or is it a bug, the line I moved was.
angular     .module('permission')     .directive('permission', ['$log', 'Authorization', 'PermissionMap', 'PermissionStrategies', function ($log, Authorization, PermissionMap, PermissionStrategies) {       return {         restrict: 'A',         bindToController: {
I just added scope:true, after restrict and it is now working.
Cheers
Ignacio

After a quick look on the JSFiddle I'm not sure I can reproduce the issue there. Although what I'm doing, is very similar to what is at this example, the difference is that I'm doing an async/http request to get the permission from the server, although I'm not using the .value() approach. Maybe trying to use that will get different result.