IncludeOptimized support for inheritance/HasDiscriminator

Description
It seems like the library doesn't work when using a model configured with inheritance (which should be the case for many complex include cases requiring this library).
Full reproducible project (except you should change the ToTable/HasForeignKey/HasColumnName to match a real database schema):
using Microsoft.EntityFrameworkCore;
using System.Collections.Generic;
using System.Linq;
using Z.EntityFramework.Plus;

namespace IncludeOptimized
{
    // Model
    public enum EntityTypes
    {
        Unknown = 0,
        Type1,
        Type2
    }

    public class Entity
    {
        public int Id { get; set; }
        public EntityTypes Type { get; set; }
    }

    public class Derived : Entity
    {
        public List<DerivedInclude> Includes { get; set; }
    }

    public class Derived2 : Entity
    {
    }

    public class DerivedInclude
    {
        public int Id { get; set; }
        public string SomeProp { get; set; }
    }

    // Context
    public class DatabaseContext : DbContext
    {
        public virtual DbSet<Entity> Entities { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
#if DEBUG
            optionsBuilder.EnableSensitiveDataLogging();
#endif

            optionsBuilder.UseSqlServer(@"Data Source=(local)\SQLEXPRESS;Initial Catalog=Jamlogic;Integrated Security=True", providerOptions =>
            {
                providerOptions.CommandTimeout(600);
            });
        }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Entity>(entity =>
            {
                entity.ToTable("Container");
                entity.HasKey(e => e.Id);
                entity.HasDiscriminator<EntityTypes>("Type")
                    .HasValue<Entity>(EntityTypes.Unknown)
                    .HasValue<Derived>(EntityTypes.Type1)
                    .HasValue<Derived2>(EntityTypes.Type2);
            });

            modelBuilder.Entity<Derived>(entity =>
            {
                entity.HasBaseType<Entity>();
                entity.HasMany(e => e.Includes).WithOne().HasForeignKey("Device_FK").OnDelete(DeleteBehavior.Cascade);
            });

            modelBuilder.Entity<Derived2>(entity =>
            {
                entity.HasBaseType<Entity>();
            });

            modelBuilder.Entity<DerivedInclude>(entity =>
            {
                entity.ToTable("Module");
                entity.HasKey(e => e.Id);
                entity.Property(e => e.SomeProp).HasColumnName("Model");
            });
        }
    }

    class Program
    {
        static void Main(string[] args)
        {
            using (var context = new DatabaseContext())
            {
                var resultOk = context.Entities.Include("Includes").ToList();
                var resultOk2 = context.Entities.Include(e => (e as Derived).Includes).ToList();

                var resultException = context.Entities.IncludeOptimizedByPath("Includes").ToList();
                var resultNullRef = context.Entities.IncludeOptimized(e => (e as Derived).Includes).ToList();
            }
        }
    }
}

Results:
Using built-in EFCore Includes(), both with a string and the expression tree version, the "Includes" list loads correctly on the derived entity.
Using IncludeOptimizedByPath() I receive this exception:

System.Exception : 'Oops! the following type 'IncludeOptimized.Entity' doesn't contains the specified property 'Includes'. For more information, contact us<EMAIL_ADDRESS>
Using IncludeOptimized with an expression tree, I receive a NullReferenceException:
System.NullReferenceException :
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.MoveNext()
   at Z.EntityFramework.Plus.QueryFutureEnumerable`1.SetResult(IEnumerator`1 enumerator)
   at Z.EntityFramework.Plus.QueryFutureEnumerable`1.SetResult(DbDataReader reader)
   at Z.EntityFramework.Plus.QueryFutureBatch.ExecuteQueries()
   at Z.EntityFramework.Plus.QueryFutureEnumerable`1.GetEnumerator()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Z.EntityFramework.Plus.QueryIncludeOptimizedParentQueryable`1.CreateEnumerable()
   at Z.EntityFramework.Plus.QueryIncludeOptimizedParentQueryable`1.GetEnumerator()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at IncludeOptimized.Program.Main(String[] args) in ..\source\repos\IncludeOptimized\IncludeOptimized\Program.cs :line 97

This is a shame. I have a very big model with multiple level inheritance and included entities lists only at some level.
Using EFCore 2.2 I was having a 2.5x performance boost compared to EF6, and updating to 3.1 I lost it all (queries now takes minutes to load). I found about this library from this thread and believed it would be my savior, but it doesn't work.
Further technical details

EF version: Microsoft.EntityFrameworkCore.SqlServer 3.1.3
EF Plus version: Z.EntityFramework.Plus.EFCore 3.0.49
Database Provider: Microsoft SQL Server Express (64-bit) 14.0.2027.2

Hello @Dunge ,
Thank you for reporting, we will look at it and see if there is something we can do ;)
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hello @Dunge ,
A new version has been released.
Could you try it and let us know if it's now working with your scenario.
Best Regards,
Jon

Hello,
Unfortunately not.
Using the sample above, the IncludeOptimizedByPath() does not throw an exception anymore, but the relations don't seems to be loaded. the IncludeOptimized() with a cast still throw a null reference exception.
Using my more complete project I just did a quick test with IncludeOptimizedByPath() and it crash with a more complex exception (sorry it's in French):
System.ArgumentException
  HResult=0x80070057
  Message=Le champ '_queryCompiler' défini dans le type 'Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryProvider' n'est pas un champ de l'objet cible de type 'Z.EntityFramework.Plus.QueryIncludeOptimizedProvider`1[VerMac.JamLogic.Model.Containers.ContainerBase]'.
  Source=mscorlib
  Arborescence des appels de procédure :
   à System.Reflection.RtFieldInfo.CheckConsistency(Object target)
   à System.Reflection.RtFieldInfo.InternalGetValue(Object obj, StackCrawlMark& stackMark)
   à System.Reflection.RtFieldInfo.GetValue(Object obj)
   à Z.EntityFramework.Plus.InternalExtensions.IsInMemoryQueryContext[T](IQueryable`1 query)
   à Z.EntityFramework.Plus.QueryIncludeOptimizedByPath.IncludeOptimizedByPath[T](IQueryable`1 query, String navigationPath)
   à Z.EntityFramework.Plus.QueryIncludeOptimizedExtensions.IncludeOptimizedByPath[T](IQueryable`1 query, String navigationProperties)
   à LogPerformanceTest.Program.<Main>d__1.MoveNext() dans \source\repos\LogPerformanceTest\LogPerformanceTest\Program.cs :ligne 180

In any case, I followed the guide in the thread I originally linked to use SelectMany()/Load() to load collections relations and managed to get it working, and even cutting time by 2x from my EFCore2.2 version. So I don't really need your library anymore.

Thank, I will let my developer know about it. Don’t worry with French, we are from Quebec, alors nous parlons français ;)

@JonathanMagnan - Any plans on resolving this? I noticed it was closed with no fixed release tagged.
My project relies heavily on IncludeOptimized and has a few large inheritance/HasDiscriminator queries that are really dragging down the performance. We'd love to find a way to get this cast working with IncludeOptimized, if possible.
Thanks

@kwoolley Personally I ended up not using this library and rewriting my queries using the method explained here:
https://gist.github.com/smitpatel/d4cb3619e5b33e8d9ea24d3f2a88333a
With ThenInclude().SelectMany().Load() in multiple instructions to build the query.
But now that EFCore5 is released, I think they added an option to use split queries natively, I haven't followed up but that was in their plans.


July Closeout

Removed 5 old Kbs, replaced with new ones.  Update Saratoga.  This
includes the July Bitnami KBs.  Ping me on Slack if there's any issues.  Thanks for the help.

Closing, will re-open a new PR.


CertManager's 10s TLS handshake error EOF

Version: 0.22.1
Usage: Kubernetes
When using the LetsEncrypt auto certificate provisioning. There is a constant error in the logs.
Seems to be related to this issue: https://github.com/cert-manager/cert-manager/issues/4594

Is it expected or there is a way around it?

Is the connection with <IP_ADDRESS> working well ? Have you tried that (https://github.com/cert-manager/cert-manager/issues/4594#issuecomment-997164924) ?

@loprima-l There is no such pod in the cluster. Isn't in headscale the certmanager server started internally in the same process?
As for the <IP_ADDRESS> connectivity. That is the default gateway and all our things work as expected.
I forgot to mention an important detail.. The logs above don't break any functionality. The SSL certificate is provisioned successfully and connections from tailscale clients work as expected. All is working, except it constantly logs this EOF error.

Thanks for your reply I'm just starting on Headscale so TLS wasn't the first thing I checked. I will look at it when I've got the time as it's not a major outage.

@ventsislav-georgiev Hi, have you created your instance based on the example directory ?

The version of cert-manager in this file is responsible for the bug you've described I think, I'm not familiar with Kubernetes but maybe updating it would fix your issue, can you try it ?

Hmm.. I haven't deployed cert manager at all and I don't think it is part of the helm chart as I don't see any deployment in the cluster related to cert manager. That is why I think it is used internally by headscale.

I can't find it in the dependencies ...
@juanfont any idea ?

@loprima-l it seems autocert is used. Here is the code: https://github.com/juanfont/headscale/blob/main/app.go#L843
The ref to certmanager issue I provided is matching the error message. I'm not sure if autocert and certmanager are related.


[new locale] (kz) Added Chinese Kazakh language

There are two Kazakh scripts in the world. Currently, there are Kazakh language packs in Kazakhstan. This time, the Chinese Kazakh language pack is added.

Coverage remained the same at 88.496% when pulling 6e30e954db0c498fb551b112964ee1cf4db044fa on Musa920:develop into 82d6c1ac43125ec6cf5640a440d72c8b83e09f6b on moment:develop.

Guys, where is the problem？

Coverage remained the same at 88.496% when pulling 6e30e95 on Musa920:develop into 82d6c1a on moment:develop.
where is the problem？

Hi @Musa920 thanks for the contribution. Please edit src/locale/kz.js. Please do not edit locale/kz.js.
Thanks again.

@Musa920 please don't use kz.js as language, use kk-ch.js (chinese kazakh)

@Musa920 any updates?

Closing this for inactivity. Re-open if you add the code to the right place (under src/).


Not found links from the right sidebar

Hi there,
Following your installation instructions this is what I get once the plugin is installed from the settins panel.
Would you mind check please?

The generated links are pointing to this:
https://www.facebook.com/sharer/sharer.php?u=<!DOCTYPE HTML PUBLIC

@dvago Can you confirm with is still happening? I believe this was resolved in #3 and our v1.1.4 release and was due to a route error in the newer CraftCMS versions under certain build configs


The file size of parsed json has become huge since Xcode 12.

Hi XCLogParser developers.
Thank you for providing a awesome parser library. 🙇
Let me report a new issue as titled.
I'm currently using xclogparser to parse the xactivitylog file to collect the build time for each module, and I report them to my team members.
For Xcode 11, it worked fine and the file size of the parsed json wasn't so huge.
However, for Xcode 12, the file size of the parsed json becomes so huge (approximately 7.6GB) by executing xclogparser parse --file <file_name> --reporter flatJson command.
I got this json when I parse the xactivitylog whose file size is 3.7MB.
It so huge that I can't parse it on CI (with fastlane's custom lane)
here's the example code of parsing: (Some of filepath are replaced with meaningless paths)
lane :parse_xactivitylog do
  activity_file = "path/to/log.xactivitylog"
  output_path = "path/to/output/activity.json"
  sh("#{xclogparser} parse --file #{activity_file} --reporter flatJson --output #{output_path}")
  json_string = File.read(output_path) // <==== Failed to read json file due to a large file
  activity_json = JSON.parse(json_string)
  ....
end

Since I've been faced with this problem, I tried to parse with other reporter styles then I was able to get some information that led me to identify the problem.
Here's the result that I executed parse command with --reporter summaryJson: (Some of information are masked)
{
  "parentIdentifier" : "",
  "fetchedFromCache" : false,
  "title" : "Building workspace XXXX with scheme YYYY and configuration Debug",
  "warningCount" : 2526,
  "duration" : xxxxxxx.xxxxx,
  "startTimestamp" : xxxxxxx.xxxxx,
  "signature" : "Building workspace XXXX with scheme YYYY and configuration Debug",
  "errors" : [
    ...
  ],
  "compilationEndTimestamp" : xxxxxxx.xxxxx,
  "compilationDuration" : xxxxxxx.xxxxx,
  "endDate" : "xxxxxxxxxxxxxxxxxx",
  "errorCount" : 81,
  "domain" : "Xcode.IDEActivityLogDomainType.BuildLog",
  "type" : "main",
  "identifier" : "xxxxxxxxxxxxxxxxxx",
  "buildStatus" : "succeeded",
  "schema" : "YYYY and configuration Debug",
  "subSteps" : [

  ],
  "endTimestamp" : xxxxxxx.xxxxx,
  "architecture" : "",
  "machineName" : "ABC",
  "buildIdentifier" : "xxxx-xxxx-xxxx-xxxx",
  "startDate" : "xxxxxxxxxxxxxxxxxx",
  "warnings" : [
    {
      ... there are so many warning details
    }
  ],
  "documentURL" : "",
  "detailStepType" : "none"
}

According to this result, I seem to have over 2500 warnings... 😨.
Also, I think that since Xcode12, the number of warnings has increased and the parsed json now contains a large number of detail characters for those warnings, so the file size has become bloated.
However, I don't know why I get so many warnings and bloated file sizes in Xcode 12 and later.
What I actually want to do
Actually, I just want to get the build time for each module and each module's name by referring to the steps that are "type": "target" only.
So in my case, I don't need any error details.
BTW, with --reporter summaryJson, I can get the total build time, but not for each module.(I mean, --reporter summaryJson can't do what I want to do.)
Based on the above, I have some questions for you.

Are there any good ideas(or options) I can only get the steps of "type" : "target" so that I can analyze the build time of each module without creating a huge json file?
Or, is it possible to create some options like being able to reduce(or redact/ignore) the output of the error details?
Or, could you tell me how Spotify is able to parse and use the xactivitylog generated from a huge project like your service with a reasonable file size?

I hope you can see this issue. Thanks 🙇

Hi! Thank you for reporting this. Do you know if it's true that you have 1200 warnings showing in Xcode? I just want to discard that the tool is duplicating them. We recently fixed an issue that generating duplicated errors in the JSON that is part of release 0.2.21.
I'm leaning towards adding an option to don't output the errors and warnings details. I will do some tests about it.
At Spotify we use XCLogParser as a Dependency of other Swift command line application, so we call it as a library and get the result as a Swift Array that we manipulate before storing its content in a database.

@ecamacho Thank you for replying.

Do you know if it's true that you have 1200 warnings showing in Xcode?

In my project, there are over 1500 warnings if I execute build on Xcode. (Xcode always displays 999+ warnings on the top of the window)

I'm leaning towards adding an option to don't output the errors and warnings details. I will do some tests about it.

Oh, really? I just want that option! I'm waiting for it.
And thank you for sharing a use case at Spotify 🙇

Xcode 12, same problem here, the xclogparser tool used too much memory when run parse command.

dump command works fine, but the output file size by  parse command is huge
-rw-r--r--  1 username  staff     2016413 12 24 10:13 6022E237-8749-4E8A-AC76-DC3A0C047D2F.xcactivitylog
-rw-r--r--  1 username  staff   101193415 12 24 10:27 dump.json
-rw-r--r--  1 username  staff<PHONE_NUMBER> 12 24 10:17 parse_flat.json
-rw-r--r--  1 username  staff<PHONE_NUMBER> 12 24 10:36 parse_json.json
-rw-r--r--@ 1 username  staff         929 12 24 11:19 parse_summaryJson.json

I inhibit all warnings in Xcode, the summaryJson like this:
{
    "parentIdentifier" : "",
    "fetchedFromCache" : false,
    "title" : "Build xxxxxx",
    "warningCount" : 541,
    "duration" :<PHONE_NUMBER>7702789,
    "startTimestamp" :<PHONE_NUMBER>.55636,
    "signature" : "Build xxxxxx",
    "errors" : [

    ],
    "compilationEndTimestamp" :<PHONE_NUMBER>.3474889,
    "compilationDuration" :<PHONE_NUMBER>7382507,
    "endDate" : "2020-12-24T02:13:17.357000Z",
    "errorCount" : 0,
    "domain" : "Xcode.IDEActivityLogDomainType.BuildLog",
    "type" : "main",
    "identifier" : "admin_6022E237-8749-4E8A-AC76-DC3A0C047D2F_1",
    "buildStatus" : "succeeded",
    "schema" : "xxxxxx",
    "subSteps" : [

    ],
    "endTimestamp" :<PHONE_NUMBER>.3570981,
    "architecture" : "",
    "machineName" : "admin",
    "buildIdentifier" : "admin_6022E237-8749-4E8A-AC76-DC3A0C047D2F",
    "startDate" : "2020-12-24T02:02:16.556000Z",
    "warnings" : [

    ],
    "notes" : [

    ],
    "documentURL" : "",
    "detailStepType" : "none"
  }

@sgr-ksmt @jiaxw32 Can you try the latest release ?
You can pass --omit_warnings flag to the parse command:
xclogparser parse --reporter json --output report.json --omit_warnings

@sgr-ksmt @jiaxw32 Can you try the latest release ?
You can pass --omit_warnings flag to the parse command:
xclogparser parse --reporter json --output report.json --omit_warnings

Hi, @sgr-ksmt , thanks for your work, I try the latest release version, but it doesn't work for me!
$ data3 % ./xclogparser version
XCLogParser 0.2.23
$ ./xclogparser parse --file 11A25E79-04FB-47D6-B79E-AB39AA95CAD1.xcactivitylog --reporter json --output report.json --omit_warnings

parse result like that
-rw-r--r--    1 username  staff     2007818 12 31 09:48 11A25E79-04FB-47D6-B79E-AB39AA95CAD1.xcactivitylog
-rw-r--r--    1 username  staff<PHONE_NUMBER> 12 31 09:52 report.json
-rwxr-xr-x@   1 username  staff     3976928 12 30 18:29 xclogparser

when I run the xclogparser tool, it used too much memory again.

I open the report.json file with vim, found the notes have too much data.
"notes" : [
{
    "characterRangeStart" : 0,
    "startingColumnNumber" : 9,
    "endingColumnNumber" : 9,
    "characterRangeEnd" : 8,
    "detail" : "<module-includes>:1:9: note: in file included from <module-includes>:1:\r#import \"xxx.h\"\r        ^\rxxx.h:17:9: note: in file included from xxx:17:\r#import \"***.h\"\r        ^\r***.h:113:17: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)\r+ (NSDictionary *)functioname;\r                ^\r***.h:113:17: note: insert '_Nullable' if the pointer may be null\r+ (NSDictionary *)functionname;\r                ^\r***.h:113:17: note: insert '_Nonnull' if the pointer should never be null\r+ (NSDictionary *)funcationname;\r

I try edit the getNotes function in the ArrayExtension.swift file ignore the notess data, then work for me.
original the code
    func getNotes() -> [Notice] {
        return filter {
            $0.type == .note
        }
    }

the code after I edit
    func getNotes() -> [Notice] {
        return []
//        return filter {
//            $0.type == .note
//        }
    }

Does the notes data important, Can you add another params to ignore that?
Thanks again!

@ecamacho Thanks for your work.
I tried to parser with the latest version, but I got the same issue as @jiaxw32.
Here's my result:
...
    "notes" : [
      {
        "characterRangeStart" : 0,
        "startingColumnNumber" : 0,
        "endingColumnNumber" : 0,
        "characterRangeEnd" : 0,
        "detail" : "note: Using new build system\rnote: Building targets in parallel\rnote: Planning build\rnote: Constructing build description\rwarning: The iOS Simulator deployment target ...(too long text)
      },
...

I hope I can ignore notes.detail field by setting another flag like --omit_notes.

@ecamacho Thanks for your work.
I tried to parser with the latest version, but I got the same issue as @jiaxw32.
Here's my result:
...
    "notes" : [
      {
        "characterRangeStart" : 0,
        "startingColumnNumber" : 0,
        "endingColumnNumber" : 0,
        "characterRangeEnd" : 0,
        "detail" : "note: Using new build system\rnote: Building targets in parallel\rnote: Planning build\rnote: Constructing build description\rwarning: The iOS Simulator deployment target ...(too long text)
      },
...

I hope I can ignore notes.detail field by setting another flag like --omit_notes.

@ecamacho How is it going?

I will take a look this weekend

@sgr-ksmt @jiaxw32 Can you try the latest release ?
You can pass --omit_warnings flag to the parse command:
xclogparser parse --reporter json --output report.json --omit_warnings

Hello. I'm having similar problems as others here (too much memory usage, too big of file outputs). Trying the --omit_warnings flag did not work for me, it doesn't seem to be packaged with v0.2.22:
~/Documents/XCLogParserTest xclogparser version
XCLogParser 0.2.22
~/Documents/XCLogParserTest xclogparser parse --file DCF3A17D-1D94-4D61-A065-E8F0A0BE1EFF.xcactivitylog --reporter html --rootOutput HTML_1 --without_build_specific_information --omit_warnings
Error: Unknown option '--omit_warnings'
Usage: xclogparser parse [--file <file>] [--derived_data <derived_data>] [--project <project>] [--workspace <workspace>] [--xcodeproj <xcodeproj>] [--reporter <reporter>] [--machine_name <machine_name>] [--redacted] [--without_build_specific_information] [--strictProjectName] [--output <output>] [--rootOutput <rootOutput>]
  See 'xclogparser parse --help' for more information.

@emish I just released v0.2.25. Can you try that one? It should have the --omit_warnings option and it also adds an --omit_notes option.
@sgr-ksmt can you try v0.2.25? It adds an --omit_notes option

@ecamacho Thank you for your effort.
I tried to use v0.2.25 but it didn't still work...
I checked your PR and I left a comment to solve --omit_notes option.
Could you please check https://github.com/spotify/XCLogParser/pull/126/files#r585419594? 🙇

@ecamacho Thank you for quick fixing.
I confirmed that --omit_notes worked fine.
If @jiaxw32 can get the same good result, I think we can close this issue. 🙏 How about you?

@ecamacho Thank you for quick fixing.
I confirmed that --omit_notes worked fine.
If @jiaxw32 can get the same good result, I think we can close this issue. 🙏 How about you?

work fine for me now, nice work! @sgr-ksmt  @ecamacho
test log as follows:
# xclogparser version
% ./xclogparser version
XCLogParser 0.2.26

# parse with containing the notes
% ./xclogparser parse --reporter json --output report.json --file  C5A4CC00-2064-4733-BC2C-AF6A599917CF.xcactivitylog
File written to ~/XCBuildLogParser/tools/report.json

# parse with ignoring the nodes
% ./xclogparser parse --reporter json --output report_without_notes.json --file  C5A4CC00-2064-4733-BC2C-AF6A599917CF.xcactivitylog --omit_notes
File written to ~/XCBuildLogParser/tools/report_omit_notes.json

# list the report file size
% ls -lh *.json
-rw-r--r--  1 user  staff   2.1G  3  3 16:22 report.json
-rw-r--r--  1 user  staff   236M  3  3 16:24 report_omit_notes.json


Fix infinite query of simulation status

This PR fixed the infinite query of the simulation status after finishing setting up a simulation project.

Great!


aria-label property for views gets removed when selecting a view in the sidebar

When selecting a view in the view sidebar, the aria-label property will get removed (or set to an empty string).
To print out the aria-label properties you can use the below in dev tools, it will print all the aria-label properties.
let [view] =  $x('.//ul[@aria-label=\'Active View Switcher\']');
for (const el of view.getElementsByClassName('action-item') ) {
	console.log(el.ariaLabel);
}

Does this issue occur when all extensions are disabled?: Yes

Version: 1.57.0-insider
Commit: 4f3d865a6b46a4ead49cf83fe1c30d95d0a34220
Date: 2021-05-31T05:12:28.387Z (8 hrs ago)
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.4.0
Steps to Reproduce:

Open the Developer Tools (Help -> Open Developer Tools)
Paste the above JS in the Developer Tools and run it - it should log the names of the view
Click a view
Run the JS again - This time the view you clicked will not have the name logged, it instead will be an empty string

Notes:
vscode-extension-tester uses this to get the names of the view (although I understand the VS Code team doesn't own this)

@ewanharris what is the accessibility use case when you face this?

@isidorn, my use case isn't accessibility but automation via vscode-extension-tester for testing. I think the aria-label is persisted for the element underneath the action-item (not at my laptop so can't verify) but given that the test package has pulled aria-label from action-item since VS Code 1.37 I wasn't sure if this was an intended change, or a regression that would impact accessibility.

As you said aria-label does not live on the action-item HTML element but on it's children.
This was an intended change and does not have any accessibility impact.
Thus closing as designed and thanks for letting us know


Use anaconda version of bld.bat

This is just bld.bat from: https://github.com/AnacondaRecipes/blosc-feedstock/
Instead of fidling with CMake this just del/move some files.
The tests seem to pass: https://ci.appveyor.com/project/tomkooij/blosc-feedstock/build/1.0.5/job/tn0kb2ph92dnfgsy

Thanks @tomkooij. Much appreciated. Sorry for the long delay.


Betterdiscord no longer working

After Discord updated the app on 11th of December BetterDiscord stopped working, I tried reinstalling it, restarting discord, even restarting my PC but nothing worked...
(Windows 10)

Same, With the new update that rolled out yesterday I've been getting JavaScript errors and can't use BetterDiscord. Discord works fine without it.

I just noticed it keeps saying "BetterDiscord" is updating in the bottom right

I am getting the same thing... just a betterdiscord flashing logo.

If it's keeps blinking, remove the plugins to the desktop and reload

I tried that, removed all the plugins and themes but there's no difference.. still just says loading

Thanks a lot DevilsLynAvenged! I removed all the plugins and themes to desktop, restarted discord and it worked just fine, moved them back one by one until one the themes said it needs to update... I updated it and now it works again!


Pinned to an earlier version of lodash, Fixes #31

@stopyoukid,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


GoDoc -> pkg.go.dev

Relates to pion/webrtc#1009

Codecov Report

Merging #192 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   75.36%   75.05%   -0.32%
==========================================
  Files          63       63
  Lines        3540     3540
==========================================
- Hits         2668     2657      -11
- Misses        586      597      +11
  Partials      286      286

Flag
Coverage Δ

#go
74.91% <ø> (-0.34%)
:arrow_down:

#wasm
69.8% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

config.go
95.23% <0%> (-4.77%)
:arrow_down:

pkg/crypto/selfsign/selfsign.go
76.74% <0%> (-4.66%)
:arrow_down:

crypto.go
53.84% <0%> (-3.08%)
:arrow_down:

internal/net/dpipe/dpipe.go
94.11% <0%> (-2.36%)
:arrow_down:

conn.go
81.41% <0%> (-0.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34883a7...1ef9504. Read the comment docs.

You two are fast :) updated!


fix: merge generated config into runtime config

Fixes #3558

This maps to https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime/Extensions/ConfigurationBuilderExtensions.cs#L107 which was omitted initially.

Pull Request Test Coverage Report for Build 742504506

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 84.909%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/node.ts
8
91.7%

Totals

Change from base Build 734412837:
-0.04%

Covered Lines:
18965

Relevant Lines:
21277

💛  - Coveralls

@stevengum added


pypy3Packages.greenlet: Set null for pypi; pypy3Packages.six: Disable failing test

Some pypy3 package set fixes, that were previously discussed on the python matrix room.
cc @exarkun
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build pypy3Packages.six


[KYUUBI #3848] [Improvement] Return sorted map in getAll method of KyuubiConf

Why are the changes needed?

to close #3848 .
Sort the config map returned in KyuubiConf.getAll to improve readability of engine launching configs in output.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @pan3793

Thanks, merging to master


Not found

Plugin [id: 'io.github.leavesczy.trace'] was not found in any of the following sources.

Exception is:
org.gradle.api.plugins.UnknownPluginException: Plugin [id: 'io.github.leavesczy.trace'] was not found in any of the following sources:

Gradle Core Plugins (plugin is not in 'org.gradle' namespace)

你是如何声明 plugin 的呢？repositories 确定有包含 gradlePluginPortal() 吗


fix for assigning positive/negative labels during evaluation

np.where(unique_targets >= 0) returns a tuple: The length of np.where(unique_targets >= 0)  will always be 1 for a 1D array, as it is a tuple containing one array of indices. This condition will not behave as expected because len(np.where(...)) is not comparable to len(unique_targets) even when the targets are 0 and 1 only.

@D3STRON Thanks, we just modified some of the evaluate function today and must've overlooked it! 🚀


Prepare code comments

What does this mean?

ping @churkin

Check comments with the correctors

Progress: https://docs.google.com/document/d/1x2a0qhRIZyEKFMo2MwaueNYoqvWwrSKf1olsyJQPHsY/edit

Completed (disregard notes in the document - I swear it's completed)

@MargaritaLoseva, could you pls grant Andrew the right to accept changes. I think this way it would be more convenient for him to apply our corrections

Oh, it's not your document, it's Andrew's... sorry


Questions about the training data

Excellent work!
I’m surprised that it animates both real and cartoon characters very well. Does the training dataset contain cartoon characters? And how to ensure the pose sequences are applicable to both real and cartoon?

I feel excited about this work, and share same question!

Introduction
Objective: Addressing the challenge of character animation in image-to-video synthesis using diffusion models.
Significance: Traditional methods struggle with temporal consistency and detailed feature preservation in character animations. This research aims to overcome these limitations.
Methodology
ReferenceNet: A feature extraction network designed to capture detailed features from a reference image using spatial attention.
Pose Guider: Ensures controllability of the character's movements by integrating motion control signals into the denoising process.
Temporal Modeling: A temporal layer is introduced to model relationships across multiple frames, preserving high-resolution details and simulating continuous, smooth motion.
Network Architecture: An extension of the Stable Diffusion model, integrating ReferenceNet, Pose Guider, and a temporal layer into the denoising UNet.
Experiments and Results
Data and Training: Model trained on an internal dataset of 5K character video clips.
Performance: Demonstrated superior results in character animation compared to existing methods in fashion video and human dance synthesis benchmarks.
Comparative Analysis: Compared to methods like DreamPose and DisCo, this approach showed notable advantages in maintaining spatial and temporal consistency, detail preservation, and avoiding issues like temporal jitter.
Limitations
Challenges with Hand Movements: Some issues in generating stable results for hand movements.
Generating Unseen Parts: Difficulty in generating unseen parts of a character due to the inherent limitations of the single-perspective images.
Operational Efficiency: Lower operational efficiency compared to non-diffusion-model-based methods due to the utilization of DDPM.
Conclusion
Summary: The paper introduces a novel framework, "Animate Anyone", which significantly advances the field of character animation in image-to-video synthesis, providing a potential foundational solution for future applications in this area.
Presentation Tips
Visuals: Use figures and diagrams from the paper to illustrate the architecture and results.
Audience Engagement: Tailor the technical depth of the presentation according to the audience's background.
Interactive Elements: If possible, include video demonstrations of the animation results.
Q&A Session: Reserve time for questions to engage with the audience and clarify complex concepts.

Introduction
Objective: Addressing the challenge of character animation in image-to-video synthesis using diffusion models.
Significance: Traditional methods struggle with temporal consistency and detailed feature preservation in character animations. This research aims to overcome these limitations.
Methodology
ReferenceNet: A feature extraction network designed to capture detailed features from a reference image using spatial attention.
Pose Guider: Ensures controllability of the character's movements by integrating motion control signals into the denoising process.
Temporal Modeling: A temporal layer is introduced to model relationships across multiple frames, preserving high-resolution details and simulating continuous, smooth motion.
Network Architecture: An extension of the Stable Diffusion model, integrating ReferenceNet, Pose Guider, and a temporal layer into the denoising UNet.
Experiments and Results
Data and Training: Model trained on an internal dataset of 5K character video clips.
Performance: Demonstrated superior results in character animation compared to existing methods in fashion video and human dance synthesis benchmarks.
Comparative Analysis: Compared to methods like DreamPose and DisCo, this approach showed notable advantages in maintaining spatial and temporal consistency, detail preservation, and avoiding issues like temporal jitter.
Limitations
Challenges with Hand Movements: Some issues in generating stable results for hand movements.
Generating Unseen Parts: Difficulty in generating unseen parts of a character due to the inherent limitations of the single-perspective images.
Operational Efficiency: Lower operational efficiency compared to non-diffusion-model-based methods due to the utilization of DDPM.
Conclusion
The paper introduces a novel framework, "Animate Anyone", which significantly advances the field of character animation in image-to-video synthesis, providing a potential foundational solution for future applications in this area.

Introduction
Objective: Addressing the challenge of character animation in image-to-video synthesis using diffusion models.
Significance: Traditional methods struggle with temporal consistency and detailed feature preservation in character animations. This research aims to overcome these limitations.
Methodology
ReferenceNet: A feature extraction network designed to capture detailed features from a reference image using spatial attention.
Pose Guider: Ensures controllability of the character's movements by integrating motion control signals into the denoising process.
Temporal Modeling: A temporal layer is introduced to model relationships across multiple frames, preserving high-resolution details and simulating continuous, smooth motion.
Network Architecture: An extension of the Stable Diffusion model, integrating ReferenceNet, Pose Guider, and a temporal layer into the denoising UNet.
Experiments and Results
Data and Training: Model trained on an internal dataset of 5K character video clips.
Performance: Demonstrated superior results in character animation compared to existing methods in fashion video and human dance synthesis benchmarks.
Comparative Analysis: Compared to methods like DreamPose and DisCo, this approach showed notable advantages in maintaining spatial and temporal consistency, detail preservation, and avoiding issues like temporal jitter.
Limitations
Challenges with Hand Movements: Some issues in generating stable results for hand movements.
Generating Unseen Parts: Difficulty in generating unseen parts of a character due to the inherent limitations of the single-perspective images.
Operational Efficiency: Lower operational efficiency compared to non-diffusion-model-based methods due to the utilization of DDPM.
Conclusion
The paper introduces a novel framework, "Animate Anyone", which significantly advances the field of character animation in image-to-video synthesis, providing a potential foundational solution for future applications in this area.

@jdawge Nice Ai summery

Is the spatial attention here exactly the same as self-attention?
A module that outputs a hxw weight map is also called spatial attention.


Implementation JavaScript?

Is there an implementation for Client JavaScript?

I am not sure what you asking for honestly... netty is just a network framework

Can be used in js or web page?
send request socket to server?


[WIP] Fix st2 login and st2 whoami commands to work

Randomly noticed it's not working while testing it - https://gist.github.com/Kami/f03360208e2e8599f42d3152df054842
It looks like the problem is that code tries to work with the ConfigParser object as a dictionary, but ConfigParser object doesn't behave and support dictionary-like access notation.
Edit: Looked at the tests and it looks like they didn't catch this issue because the hide it because they mock ConfigParser instance. I know that's not always possible, but we should try to avoid mocking as much as possible because many times we end up mocking too much and we actually end up testing mocks and not the actual code...
TODO

[ ] Tests (and figure out why existing tests passed, maybe they mock too much. Imo, better and safer approach would be to use actual config file fixtures from disk - this way we don't need to mock stuff.)

@Mierdin I'm a bit confused about this - it seems like it should have never worked, or am I missing something?

Edit: So it seems like the problem is that only ConfigParser instance in Python 3 works like a dict (https://docs.python.org/3/library/configparser.html#module-configparser), but not one available in Python 2 (https://docs.python.org/2/library/configparser.html).
Did you happen to test it with Python 3 locally (I used Python 2.7 which is the version we officially support)?
We don't fully support Python 3 yet and if anything, we should use the approach which works on both versions where possible :)

Hrm, this is all very strange. FWIW I was not using Python 3 - my dev box runs 2.7.6.
I'll dig into this today and see if I can't get it straightened out. Apologies if I'm over-relying on mock - I was always told to use mock to avoid testing things you weren't trying to test. In this case, I don't want to test ConfigParser, I want to test the code that's using it. However, I can see your perspective and will try to find some middle ground.

Apologies if I'm over-relying on mock - I was always told to use mock to avoid testing things I wasn't trying to test. In this case, I don't want to test ConfigParser, I want to test the code that's using it. However, I can see your perspective and will try to find some middle ground.

No problem, sometimes it's hard to find the balance what to mock and what to not in the unit tests.

Hrm, this is all very strange. FWIW I was not using Python 3 - my dev box runs 2.7.6.

It looks like this could also happen if you have configparser package installed locally - https://pypi.python.org/pypi/configparser
Afaik, none of our packages and components rely and use that package, but having this package installed locally would cause this behavior.

@Kami figured it out. This is the culprit - https://github.com/StackStorm/st2/pull/3194
I was 99% sure I sufficiently tested everything manually after that change, but the only possible explanation is, no I did not. :-/
Anyways - this one's on me - I'll fix it.

Codecov Report

Merging #3211 into master will decrease coverage by -0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3211      +/-   ##
==========================================
- Coverage   77.85%   77.72%   -0.13%
==========================================
  Files         433      433
  Lines       22398    22397       -1
==========================================
- Hits        17437    17407      -30
- Misses       4961     4990      +29

Impacted Files
Coverage Δ

st2client/st2client/commands/auth.py
67.4% <100%> (-0.73%)
:x:

st2client/st2client/utils/logging.py
32% <ø> (-48%)
:x:

st2client/st2client/base.py
62.63% <ø> (-9.6%)
:x:

st2actions/st2actions/scheduler.py
83.67% <ø> (-4.08%)
:x:

st2common/st2common/bootstrap/sensorsregistrar.py
84.47% <ø> (-1.94%)
:x:

st2api/st2api/controllers/v1/actionexecutions.py
87.83% <ø> (-1.74%)
:x:

st2client/st2client/shell.py
85.37% <ø> (-1.63%)
:x:

st2common/st2common/rbac/decorators.py
84.38% <ø> (-1.56%)
:x:

st2common/st2common/transport/consumers.py
86.32% <ø> (-1.05%)
:x:

st2api/st2api/controllers/v1/triggers.py
77.34% <ø> (-0.99%)
:x:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61800d8...ea4c121. Read the comment docs.

So....after looking into this a bit more, here's my working theory. It's true that the built-in ConfigParser doesn't allow dict-like references in until Python 3. However, it appears that you can install this package and get this functionality when running Python 2.7.
Looks like this does get installed in the virtualenv when running make requirements, as it is a dependency of flake8:
~$ pipdeptree
....
flake8==3.0.4
  - configparser [required: Any, installed: 3.5.0]
  - enum34 [required: Any, installed: 1.1.6]
  - mccabe [required: >=0.5.0,<0.6.0, installed: 0.5.3]
  - pycodestyle [required: >=2.0.0,<2.1.0, installed: 2.0.0]
  - pyflakes [required: <1.3.0,!=1.2.1,!=1.2.2,>=0.8.1,!=1.2.0, installed: 1.2.3]
....

So, this explains why it was working before the move to using the ConfigParser in six. Before that, the commands worked just fine, because they were using this third-party library that acted like the built-in Python3 ConfigParser.
Now, regarding the errors that came up once #3194 was merged, I'm guessing this is because six's ConfigParser is designed to act like the built-in version for Python 2, which doesn't have getitem access either.
All that said, the changes you made to auth.py are definitely better, and my mocks were clearly wrong as they were built to mimic the wrong ConfigParser version. I re-did all of the unit tests for this in https://github.com/StackStorm/st2/pull/3211/commits/ea4c1212d64beadb720a5339c59db84c9f922e7c; hopefully they'll help protect from this a bit better.

Yes, I also agree with your assessment :)
And yeah, it's a bit nasty that dev dependencies can interfere with things in suck a sneaky manner...

It appears e2e tests failed because this branch doesn't contain packs.download fix / changes (the tests are passing on master).
I've merged latest master into this branch, this should fix it.

I pushed some changes (41090ab3719beb8f564729980dd5586323e88eec, c1923f64dbae13f318a6aab5aa9dc1eac71ba754, ba85739bbb964ceb01653670f0cd7319ee9b5660, 339af8950e799ae97c946675126c84391c1a628b, 2602577b2935a587e79744db01eec0f347365e0b).
I think we might also be able to re-use stdout capturing from base class (no need to create and use CaptureStdout), but I would need to dig in to confirm and something we can simplify in the future (if possible).

I pushed some changes (41090ab3719beb8f564729980dd5586323e88eec, c1923f64dbae13f318a6aab5aa9dc1eac71ba754, ba85739bbb964ceb01653670f0cd7319ee9b5660, 339af8950e799ae97c946675126c84391c1a628b, 2602577b2935a587e79744db01eec0f347365e0b).
I think we might also be able to re-use stdout capturing from base class (no need to create and use CaptureStdout), but I would need to dig in to confirm and something we can simplify in the future (if possible).

@Mierdin when you get a chance can you please have a look and approve it (I forgot I opened it and the PR hasn't been approved yet so I can't merge it :))?

It looks like I was also able to replace CaptureStdout with existing stdout capture mechanism in the base test class - 072bd3ddcaa4e4e4368346902b7d74b75542a940. It just required a small fix to the base test class otherwise it wouldn't work when multiple classes inherited from the same bass class - 380b958dd52bb10934e8cc43e9fb19d585262b34 (internal state was not reset for each test run).

Some of the e2e tests failure appear to be related to intermediate upstream / networking issues.

@kami I re-ran the e2e test and it passed. Not sure why Codecov is throwing a fit though.


Add Domain Universidad de Pamplona

Universidad de Pamplona
https://www.unipamplona.edu.co
unipamplona.txt

@ANDERSON-OSORIO I am sorry, the domain unipamplona.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Support installing libraries

Current Behavior
When attempting to use a Rust library my_lib in a C++ application my_app, using Corrosion, the linker reports an error during the linking phase.
Error Output:
[ 59%] Linking CXX executable my_app
ld: cannot find -lmy_lib-static

Relevant issue: https://github.com/corrosion-rs/corrosion/issues/261#issuecomment-1307223603
Expected Behavior
The my_app application should successfully link with the my_lib Rust library without the need for renaming the output static library file.
I was able to temporarily resolve this issue by renaming the output static library as follows:
install(
  FILES
    ${CMAKE_CURRENT_BINARY_DIR}/libmy_lib.a
  DESTINATION
    ${lib_dest}
  RENAME
    libmy_lib-static.a
)

Steps To Reproduce
Here is a snippet of the CMakeLists.txt file which reproduces the issue:
corrosion_import_crate(
  MANIFEST_PATH ${CARGO_MANIFEST_DIR}/Cargo.toml
  CRATES my_lib
)

target_link_libraries(my_app my_lib)

install(
  TARGETS
    my_lib
  EXPORT
    MyTargets
  DESTINATION
    ${lib_dest}/
)

cmake -S. -Bbuild -DRust_CARGO_TARGET=mips-unknown-linux-gnu ...
Environment
- OS: Docker, debian:buster-slim
- CMake: 3.25.0
- CMake Generator: Unix Makefiles
- Cross Compilation Toolchain: mips-unknown-linux-gnu

CMake configure log with Debug log-level
No response
CMake Build step log
No response

To clarify: the install step is essential to reproduce this issue, correct?

Yes, the install step is essential to reproduce this issue. It seems that Corrosion is appending a -static suffix to the target name for static libraries, which is causing a mismatch during the linking phase because the library with the -static suffix is not being installed.
https://github.com/corrosion-rs/corrosion/blob/fc8dd409ba168c6a24572c72cf076154b913ebaa/cmake/Corrosion.cmake#L456C10-L456C10
if(has_staticlib)
    add_library(${target_name}-static STATIC IMPORTED GLOBAL)
    add_dependencies(${target_name}-static cargo-build_${target_name})
...
target_link_libraries(${target_name} INTERFACE ${target_name}-static)

Using an installed library is curenntly not supported, but it would make sense to add support.
I don't have much experience with install, so it would immensely help if you could provide a minimal example of a project, that imports a Rust project, installs and then uses the installed static library to link. This would allow me to test out different solutions on that demo project.

It seems that Corrosion is appending a -static suffix

Corrosion creates an INTERFACE target that links to either the -static or -shared library . Changing this in any way would likely break lots of existing users code.

INTERFACE libraries basically cannot be installed as far as I can tell, but IMPORTED'ed libraries have some minor support. And in-fact with the existing code you can sort of kinda install to the degree cmake allows installing prebuilt binaries.
get_target_property(myrustlib_import_target myrustlib INTERFACE_LINK_LIBRARIES)
install(IMPORTED_RUNTIME_ARTIFACTS ${myrustlib_import_target}
LIBRARY DESTINATION ...
)

This is pretty limited and actually doesnt even support headers either, but is documented https://cmake.org/cmake/help/latest/command/install.html#imported-runtime-artifacts
Hilariously INTERFACE libraries supposedly to support installing public headers per https://discourse.cmake.org/t/interface-library-not-getting-installed-and-no-error-reported/2185/22 (See the 3.19 test cases and the newer FILE_SET features)
Hopefully these workarounds help someone else, but it does not look very good for being able to treat corrosion targets like real first-class cmake targets as it stands. Beyond simple installs both INTERFACE and IMPORTED targets have many other limitations you might experience in a large cmake build.

Thanks.
I was looking for a way to install a bin crate executable (converted from C to rust) and install(IMPORTED_RUNTIME_ARTIFACTS target_name) was enough to replace the original install_executable(target_name).
Mentioning how to do this in the docs would be helpful. :wink:

I created a repo for a library that works both with install and add_subdirectory. It takes an annoying amount of effort, but it shouldn't be impossible to upstream into the library.
Headline is that
if(BUILD_SHARED_LIBS)
    install(FILES $<TARGET_PROPERTY:is_odd-shared,IMPORTED_LOCATION> DESTINATION lib)
else()
    install(FILES $<TARGET_PROPERTY:is_odd-static,IMPORTED_LOCATION> DESTINATION lib)
endif()

will copy the library.
It seems this issue is tightly coupled to https://github.com/corrosion-rs/corrosion/issues/64, https://github.com/corrosion-rs/corrosion/issues/117, and https://github.com/corrosion-rs/corrosion/issues/63.
Ideally I think getting corrosion_install working would be the solution to this issue. I wouldn't mind taking a shot at it, although I don't think I'm familiar enough with the particulars of how the base install works to get it right for all platforms.

@gtker I am unable to reproduce your solution.
With a cdylib crate:
corrosion_import_crate(MANIFEST_PATH Cargo.toml CRATES mycrate)

I am not able to get to the generated .so through any of the properties IMPORTED_LOCATION, LOCATION, INTERFACE_LINK_LIBRARIES, etc. and their respective generator expressions in the "install" command.

EDIT: in my case (not sure why), there is an intermediate target generated called mycrate-shared.
get_target_property(SHARED_TARGET mycrate INTERFACE_LINK_LIBRARIES) yields mycrate-shared,
then the install command can be done with the generator expression FILES $<TARGET_PROPERTY:mycrate-shared,IMPORTED_LOCATION

I believe this is always the case as mentioned in https://github.com/corrosion-rs/corrosion/issues/415#issuecomment-1623087997 although it would probably be considered an implementation detail and would be subject to change at some point, which is why it would be great to have a working corrosion_install that could do all this.

Pull requests improving corrosion_install are definitely welcome! I haven't really touched that part myself, so I'm also not very familiar with that code.

if(BUILD_SHARED_LIBS)
    install(FILES $<TARGET_PROPERTY:is_odd-shared,IMPORTED_LOCATION> DESTINATION ${shared_lib_dest})
else()
    install(FILES $<TARGET_PROPERTY:is_odd-static,IMPORTED_LOCATION> DESTINATION ${static_lib_dest})
endif()

Some comments about this:

BUILD_SHARED_LIBS only controls which library type is linked to the main INTERFACE target if both the static and shared library are built. Instead of testing this variable, you probably should instead test if the target exists. Example below.
the -shared and -static suffixes for the real IMPORTED libraries are considered an implementation detail. However, I do know that people rely on this implementation detail, so it's very unlikely to change. And if it does change, I would definitely document it in the changelog and tie it to a major version increase.
I would also recommend taking a look at recent additions to the install() command. Perhaps something like install(IMPORTED_RUNTIME_ARTIFACTS could be useful when installing shared libraries
On Windows there are also import libraries that you perhaps also need to install along with the dll.

Example (for the first comment about testing if a target exists):
if(TARGET ${target_name}-shared)
    install(FILES $<TARGET_PROPERTY:is_odd-shared,IMPORTED_LOCATION> DESTINATION lib)
endif()
if(TARGET ${target_name}-static)
    install(FILES $<TARGET_PROPERTY:is_odd-static,IMPORTED_LOCATION> DESTINATION lib)
endif()

Pull requests improving corrosion_install are definitely welcome!

Is it OK if I don't create tests for the current corrosion_install and new functionality? I've looked at the test harness and it looks pretty complicated, and as far as I can see there isn't something testing install that I can copy from.

BUILD_SHARED_LIBS only controls which library type is linked to the main INTERFACE target if both the static and shared library are built.

BUILD_SHARED_LIBS is (supposed to be) the standardized Cmake way of building shared libraries, so I just used that. Currently in my Cargo.toml I build both a static and shared lib, what is the intended Corrosion way of selecting static/shared for example in the use case of building a library and installing it? (I'll use your example for the actual implementation since it's way better)

Perhaps something like install(IMPORTED_RUNTIME_ARTIFACTS could be useful when installing shared libraries

On Windows there are also import libraries that you perhaps also need to install along with the dll.

I'll take a look. In the snippet I just used the same format for both shared and static to make it easier to understand what was going on.
Ideally I would want people to be able to add headers to the "top level" corrosion target and have that also be installed correctly to make add_subdirectory/find_package behave the same way.
Would it be OK if I submitted PRs of partial features? Like having it install the library files, then the headers, then configs, and so on.

The way I see it there's a few things that need to be done for this be complete (which would also fix https://github.com/corrosion-rs/corrosion/issues/64, and possibly also https://github.com/corrosion-rs/corrosion/issues/117):

[ ] Make corrosion_install export the actual library. (https://github.com/corrosion-rs/corrosion/pull/543)
[ ] Make corrosion_install install header files attached to the target (should also work with https://github.com/corrosion-rs/corrosion/issues/261)
[ ] Make corrosion_install create CMake Config files with minimal ceremony.
[ ] Either set the soname automatically (https://github.com/corrosion-rs/corrosion/issues/333) or make it more obvious in the docs that this is a requirement.
[ ] Document it (https://github.com/corrosion-rs/corrosion/issues/63)

I will try to get through all of these, although I'm not sure when it will be done.

soname documentation was added in this commit so this issue can be closed now.


bug: switching networks

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.3.2
Current Behavior
Chain doesn't change in mobile metamask
I try to change chain using switchNetwork which coming from hook useSwitchNetwork(). Some time it just makes wagmi think that network has been changed ( useNetwork() returns new chainId, but in metamask still the previous one), some time it redirect to metamask and nothing happens.
If it is the correct behaviour, then how can I handle this, because when user tries to send a transaction using chain, that is not selected in metamask mobile - there is no approve transaction pop up.
Expected Behavior
Pop-up request to change the chain in mobile metamask or pop-up to approve tx
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://fpcmd7.csb.app/
Anything else?
In addition I use rainbowkit 1.0.4, viem 1.2.1

Also it is switching, but metamask doesn’t have selected chain at all :)
https://github.com/wagmi-dev/wagmi/assets/119004906/19c8b83f-381d-4188-af2e-743fa5d57b32

Let's track here: https://github.com/wagmi-dev/wagmi/issues/2639


supabase.auth.api.setAuthCookie(req, res) not working in nextjs API route. Invalid JWT.

I am trying to fetch image from storage through nextjs API.
I am using -
"next": "^12.1.6",
"@supabase/supabase-js": "1.35.2",
"react": "^18.1.0",

If RLS is not set then I am able to fetch Image.
If RLS is set I am not able to fetch image. With following error -

{"statusCode":"401","error":"Invalid JWT","message":"new row violates row-level security policy for table \"objects\""}
I have already set auth cookies by calling following code inside auth route
import { NextApiRequest, NextApiResponse } from "next";
import { supabase } from "../../lib/supabaseClient";
export default function handler(req: NextApiRequest, res: NextApiResponse) {

 supabase.auth.api.setAuthCookie(req, res);
}

Code for calling my auth api is inside _app.tsx
supabase.auth.onAuthStateChange((event, session) => {

    fetch("/api/auth", {
      method: "POST",
      headers: new Headers({ "Content-Type": "application/json" }),
      credentials: "same-origin",
      body: JSON.stringify({ event, session }),
    })
  });

Hey @roker15 this sounds like a problem with your RLS policies. Please open a support ticket if you need assistance.


Bumped dcos-test-utils to include new test helpers.

High-level description
This PR bumps dcos-test-utils to include new test helpers which are needed for a flaky test fix in the Enterprise build.
Corresponding DC/OS tickets (required)

DCOS-57093 test_secret_leakage.test_pod_secret_leakage looks flaky

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): dcos-test-utils diff
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot changelog-not-required Minor test utils bump only

@mesosphere-mergebot label Ship It

Thanks for catching this @janisz .
The change has been fixed here: https://github.com/dcos/dcos/pull/6383 by @cprovencher
cc: @greggomann .


[Bug]: Always keep the camera dimensions intact on resize.

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Drag and drop new camera widget onto canvas
Change the camera Mode to Video and Deploy the application
Start recording the video
Stop the video and observe the video preview gets change in appearance and feels like video is running in full screen mode even if widget is in other resolution

Environment
Release
Version
Cloud

The fix to this is to keep the camera dimensions contained within the width and the height of the bounding box like css object-fit contain property.
 This was not linked to any PR and hence the auto labelling did not happen, If we have fixed this we need to make sure we link all such issue to a PR, if its missed after closing we make sure to add the QA label to the issue

@somangshu ,
It has already been fixed by PR #10943 .
I've linked to the PR


Default AggregateProcessor behavior compares full Events

Is your feature request related to a problem? Please describe.
Currently, the AggregateProcessor requires a non-empty list of identificationKeys to decide which AggregateGroup an Event is placed in. As a user that wants to simply remove any duplicate Events, this is a pain to configure.
Describe the solution you'd like
If no identificationKeys are configured for an aggregate processor, the default behavior could be to put all Events in the same group.
Concerns
A concern with this approach is that the Peer Forwarder (#700) may be difficult to integrate with this behavior, since it would have to choose a random AggregateProcessor to send to.
Another concern is that a single group may result in unintended performance issues for the user, as there would be a lot more locking
Alternatives

Instead of throwing a configuration error, simply have the default identificationKey of message
Have the default behavior be to compare all keys of an Event and put them into a group. This would also be difficult to integrate with the Peer Forwarder, and could potentially result in high memory usage as many groups would be made.

Combining all events into one group would be problematic in clusters since peer forwarding would not be available.
As I understand it, duplicates are detected only on a subset of fields. Thus the identificationKeys would determine that subset. I'm not sure if there are any default values that Data Prepper could provide here. It might be possible with a strict OTel model and that is something we could consider.

Thanks for the response @dlvenable. Yes the Peer forwarder integration is the main concern here. However, if the Peer forwarder were able to hash an entire Event if it notices that there are no identificationKeys, it could work. However, the effort may not be worth the result, and it may make sense to require identificationKeys at least until there is a request for such a feature.

I am closing this issue as there is no reason to change the requiring of identification_keys at this time.


Feature Request: Adaptive cards Action.ShowCard toggle text and default expansion state

Hi,
I would like to request the following features for Adaptive cards -> Action ShowCard button for MS teams.

Option to show card in an expanded state.
Reason: We are updating the card when the user clicks on show more details which leads to the user having to click the card twice, to see the details.
Known workaround: Render an expanded card with another Hide details button and do a call to the backend to update the card to collapsed state.

Option to set toggle text for ShowCard button
Reason: Say a user clicks on show details then the button should change to hide details itself. Especially helpful if you want to avoid backend calls.
Known workaround: Same as above.

Kindly consider these features for implementation.
Thanks

All feature requests for Adaptive Cards are handled centrally here: https://github.com/Microsoft/AdaptiveCards/issues. Please add 1 and 2 above as separate issues.
The first one you're asking may be contentious but I'm not sure what you are asking for is the same thing -- but they are pretty responsive and you'll probably find out fairly quickly.
FYI here's the Adaptive Cards vNext feature list.


Find and remove hyperlinks from PDF

Is there any way to search and remove any hyperlinks from a PDF file?

Closing as this question was addressed in our Discord server


makefile

happy to get your nice work!when i make ,error shows:

and i have try to add  -ldl -lm,error not solve.

try another gcc version ?


Enforce administrator's region belongs to the administrators's project

Describe the bug
It is possible to create an administrator in a region which does not belong to the administrators's project. We should not allow to create such administrators. The region should always be part of the project.
To Reproduce
Execute: ./gradlew run --args="create-admin nuernberg.sozialpass.app PROJECT_ADMIN<EMAIL_ADDRESS>Administrator!" 9
9 is Augsburg in Bavaria.
Expected behavior
An error should be shown

I think this was fixed some time ago. Running
./gradlew run --args="create-admin nuernberg.sozialpass.app PROJECT_ADMIN<EMAIL_ADDRESS>yields
`Exception in thread "main" java.lang.IllegalArgumentException: Specified region is not part of specified project.


Display "email" for verified user information.

To be able to cross reference the user search, we like to include "email" field (other than first name and last name) on search result at "Verified user information".

Acceptance Criteria

[ ] "email" included at FAM backend search result return.
[ ] Recreate api-client for frontend if necessary.
[ ] Add "email" to frontend "Verified user information" searched result (IDIR/BCeID).
[ ] Adjust tests if necessary.

Additional Context

enter text here

Done in #1650


All the code inside is open

VSCode Version:
OS Version:

Steps to Reproduce:
1.Hold down the CMD key point code when the code is expanded
2.All the code inside is open

Does this issue occur when all extensions are disabled?: Yes/No

Can you use https://www.cockos.com/licecap/ or something to capture a gif so we can understand what's your problem?


Update README.md

Added my fetch script link

can you follow conventional commits like i do for adding other fetches thanks

Like? I have added rxfetch below R letter only.

606ed144c1547972e5f7ae925bd52b05f46e65b5


SW-1729 Don't allow editing viability test types

Since different kinds of viability tests can have wildly varying behavior,
it doesn't make sense to update the type of an existing test. Turn test type
into a create-only field.

Current dependencies on/for this PR:

main

PR #643   👈

This comment was auto-generated by Graphite.


iBug: Watch sexual

iBug requests the watch of the watch_keyword sexual. See the Metasmoke search here and the Stack Exchange search here.

sexual has been seen in 2388 true positives, 70 false positives, and 6 NAAs.

Coverage remained the same at 65.133% when pulling 84897cdf7b825ca511d3f9cd955f18d3b256c275 on auto-blacklist-1514360773.9382527 into f017c72cd1ace9b0e7583d5caee8c47ff200b3e8 on master.

This is going to cause a huge number of FPs. Rejected.


Add a ReminderCancelled event

Right now a reminder can only be cancelled by Core internally. This would allow cancelling an event from a custom action.

@Ghostvv we merged  this right?

yes


adding coingeckoId #16910

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[x] question about how to use this project

Summary
i,m trying to adding coingeckoId and update some information to my token. it said eligible to merge and branch has no conflicts, but automerge-error.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

failed to normalize: failed to parse JSON: json: unknown field "discord"
https://github.com/solana-labs/token-list/pull/16910

squashed and merged


Remove unuse options introduced from last feature implementation.

Remove unuse options introduced from last feature implementation.

API change check for @azure/storage-blob
API changes have been detected in @azure/storage-blob. You can review API changes here
API changes
- export interface PageBlobGetPageRangesDiffForManagedDisksInPagesOptions extends CommonOptions {
-     abortSignal?: AbortSignalLike;
-     conditions?: BlobRequestConditions;
-     count: number;
-     offset: number;
-     prevSnapshotUrl: string;
- }


[YUNIKORN-1802] Add node events

What is this PR for?
Create wrapper type for node events and integrate it with the existing codebase.
What type of PR is it?

[ ] - Bug Fix
[ ] - Improvement
[x] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1802
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

cc @FrankYang0529 you might need some stuff from this PR, like MockEventSystem. If this gets merged, you can rebase your PR on this.

PR needs a rebase after other event changes have been committed.


CAMEL-15928: TimeoutException does not trigger Resilience4j circuit breaker

Fix not invoking fallback for resilience4j circuit breaker and not triggering circuit breaker for timeout exceptions
Detailed explanation of fix and test cases can be found in ticket itself - https://issues.apache.org/jira/browse/CAMEL-15928
You can start reading from - https://issues.apache.org/jira/browse/CAMEL-15928?focusedCommentId=17251773&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17251773

PR for master https://github.com/apache/camel/pull/4810


Activation of ABAP DCLS objects via ADT approach

We have encountered various situations, when the activation process of DCLS objects (ABAP Data Control Language Sources) behaves abnormally:

the DCLS object remains inactive in the system after the PULL operation in ABAP Git

the DCLS object is activated after the PULL operation in ABAP Git, however it is not included in any transport request

We would like to try a different approach:

we analyzed, how the DCLS objects are activated from ADT (ABAP development tools -- eclipse). Any operation called from eclipse (lock, unlock, activation, ...) calls the RFC FM SADT_REST_RFC_ENDPOINT. We would like to reuse the functionality behind this function module in order to enhance the activation process of DCLS objects.

ok
sounds good, pull requests welcome 😄

Sounds good. I agree with your proposal. We will need to analyze FM: SADT_REST_RFC_ENDPOINT in more detail, in order to extract the corresponding handler class.

The point 2 is addressed in #1466

Point 1 seems to be also a problem of the new experimental DDIC activation. Is this your scenario? I don't have the problem with experimental features deactivated.
When experimental features are activated I get this error. And the DCLS isn't activated nor created.

LT_GENTAB is cleared inside the FM.

Maybe we should just ignore the
no_objects     = 2
case?
#1055

@misik-sap can you help reproducing this in a public repository?

closing, no reply


PeeringDB looking glass URL support

It would be great to be able to add a looking glass URL in peeringdb that points to a specific peer on the NLNOG looking glass interface.

This has been implemented, you can now use URLs like this:
https://lg.ring.nlnog.net/?peer=BIT1-v4&peer=BIT1-v6


Add better handling for file not exists while in REQ_COV

Summary:

Add KeyError exception when a file is in required coverage while it doesn't exist.

Test Plan:

Add a unit test for this specific case.

Issue: #51

@cooperlees Any idea why travis is failing?

Yes, it is failing as the code no longer raises KeyError. You need to mock (via patch) ptr.LOG.error() and expect None returned when we don’t find a file now.
I guess the only bummer with this LOG usage is it will be buried in logs output. It might be better to return a failed test object and then we will get an easy to find error at the end. If you don’t have fine, just fix the unittests and then I’ll do this refactor I discuss. (Sorry I didn’t think about this before)

I've fixed the issue with test with the first approach you've mentioned but the build seems to be failing in python 3.8 with error :
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/16.04/x86_64/python-3.8.tar.bz2
131.15s$ curl -sSf -o python-3.8.tar.bz2 ${archive_url}
curl: (7) Failed to connect to storage.googleapis.com port 443: Connection timed out
Unable to download 3.8 archive. The archive may not exist. Please consider a different version.

I've fixed the issue with test with the first approach you've mentioned but the build seems to be failing in python 3.8 with error :
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/16.04/x86_64/python-3.8.tar.bz2
131.15s$ curl -sSf -o python-3.8.tar.bz2 ${archive_url}
curl: (7) Failed to connect to storage.googleapis.com port 443: Connection timed out
Unable to download 3.8 archive. The archive may not exist. Please consider a different version.

I retried and it worked! Many thanks. Merging.


Pickle error: ModuleNotFoundError: No module named 'download_pipeline.config'

Error message from worker: Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/apache_beam/internal/dill_pickler.py", line 285, in loads
    return dill.loads(s)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 275, in loads
    return load(file, ignore, **kwds)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 270, in load
    return Unpickler(file, ignore=ignore, **kwds).load()
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 472, in load
    obj = StockUnpickler.load(self)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 462, in find_class
    return StockUnpickler.find_class(self, module, name)
ModuleNotFoundError: No module named 'download_pipeline.config'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py", line 267, in _execute
    response = task()
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py", line 340, in <lambda>
    lambda: self.create_worker().do_instruction(request), request)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py", line 580, in do_instruction
    return getattr(self, request_type)(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py", line 611, in process_bundle
    bundle_processor = self.bundle_processor_cache.get(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/sdk_worker.py", line 441, in get
    processor = bundle_processor.BundleProcessor(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 863, in __init__
    self.ops = self.create_execution_tree(self.process_bundle_descriptor)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 916, in create_execution_tree
    return collections.OrderedDict([(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 919, in <listcomp>
    get_operation(transform_id))) for transform_id in sorted(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 898, in get_operation
    transform_consumers = {
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <dictcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 899, in <listcomp>
    tag: [get_operation(op) for op in pcoll_consumers[pcoll_id]]
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 806, in wrapper
    result = cache[args] = func(*args)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 903, in get_operation
    return transform_factory.create_operation(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 1198, in create_operation
    return creator(self, transform_id, transform_proto, payload, consumers)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 1545, in create_par_do
    return _create_pardo_operation(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/runners/worker/bundle_processor.py", line 1588, in _create_pardo_operation
    dofn_data = pickler.loads(serialized_fn)
  File "/usr/local/lib/python3.9/site-packages/apache_beam/internal/pickler.py", line 51, in loads
    return desired_pickle_lib.loads(
  File "/usr/local/lib/python3.9/site-packages/apache_beam/internal/dill_pickler.py", line 289, in loads
    return dill.loads(s)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 275, in loads
    return load(file, ignore, **kwds)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 270, in load
    return Unpickler(file, ignore=ignore, **kwds).load()
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 472, in load
    obj = StockUnpickler.load(self)
  File "/usr/local/lib/python3.9/site-packages/dill/_dill.py", line 462, in find_class
    return StockUnpickler.find_class(self, module, name)
ModuleNotFoundError: No module named 'download_pipeline.config'

@pbattaglia: Can you add steps to reproduce this bug? That would be really helpful to my team.

In Peter's case, the downloader was invoked as follows:
python3 weather_dl/weather-dl ...

It didn't use our pip pathway. I'm going to mark this issue as "Won't fix: Can't reproduce", since @mahrsee1997 has tested the documented pathway for install and use, and found no issues.


[Bug] content-type is shadowed by outer scope

Fix https://github.com/Azure/autorest.python/issues/1408
depends on https://github.com/Azure/autorest.testserver/pull/402

Hi @iscai-msft autorest.testserver=3.3.38 is released but CI failure shows that the regeneration is not with latest testserver. Is there anything I forget to update?

Hi @iscai-msft autorest.testserver=3.3.38 is released but CI failure shows that the regeneration is not with latest testserver. I guess the error is related with :
https://github.com/Azure/autorest.python/blob/ba0cb0eb6dd76f5004042b187d769cc530fe34cb/pnpm-lock.yaml#L31
?

I went ahead and updated the min version of the testserver in the package.json for autorest.python then ran pnpm install. This udpated the pnpm-lock file, and hopefully that fixes the issue

thanks @msyyc!


Bump version to 0.10.0-beta

In preparation for doing the next dev release add a changelog entry and bump the version number to 0.10.0-beta.
We need to release the bug fix in #130 because fuzzing is hitting it in rust-bitcoin. This release would be better to use in rust-miniscript as well gearing up for the real 0.10.0 release.

Is this the nomenclature you had in mind @apoelstra or should it have been a numbered alpha (eg. 0.10.0-alpha-1)?

@tcharding I had in mind alpha-1. But beta is fine :)

Tagged and published.


Fix magento2 cron

Fix magento2 cron by having the full path to the command being executed in supervisor's config.

Tested and (naughtily) already in the stable version after being tested.


Angular 8 upgrade note: Lazy loading via string is deprecated

Description
See https://angular.io/guide/deprecations#loadchildren-string-syntax
This string syntax is used by the JSS lazy component loading code generator here:
https://github.com/Sitecore/jss/blob/08c380610ef92fa4dab9d6c941f49750fd677a6a/samples/angular/scripts/generate-component-factory.ts#L98
And in the documentation around JSS Angular lazy loading. When #241 occurs, this updated function syntax needs to be tested and verified working, and the docs updated so they do not recommend deprecated syntax.

Angular has been updated in #271.


[#3244] refactor(core, catalogs): decouple CatalogOperations and HasPropertyMetadata

What changes were proposed in this pull request?

move HasPropertyMetadata from interface to initialize method in CatalogOperations

Why are the changes needed?
the CatalogOperations initialize may take a long time when getHiddenPropertyNames
Fix: #3244
Does this PR introduce any user-facing change?
no
How was this patch tested?
modified tests

@mchades there's build issue here.


Using BCP Desktop unable to Create Organization

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Banana Cake Pop
Describe the bug
I have a personal account in BCP which I have been using.  I would like to create an Organization for my company (presumably this will facilitate me sharing my queries and mutations). But I am unable to create the Organization.
Steps to reproduce

In BCP desktop if I click my profile icon and then Manage Organizations followed by Add organization.

I am take to a screen where I can Create an organization.

I input a 'Display Name' and 'Name' (ensuring I follow the regex) but when I click Create I get an error 'The IdentityProvider field is required.' This field does not exist so I am unable to proceed.

Relevant log output
No response
Additional Context?
Version info:

Version
4.0.1

One more note, I use GitHub as my identity provider and had previously authenticated against this using MFA.

Thanks a lot for reporting this @RichardWhitfield !
This is fixed and should work now :)


can't add comments

v1.0.0

click save no response and no log.
How to resolve this? Thanks

The problem is due to invalid token value. The form is not getting any token so it is not able to make any post request. So instead of toke just substitute ''(empty string) in dataset-comments.js.
Go to dataset-comments.js near line 218 there is create function. In that replace the token assignment to-
var token = $("#csrfToken").val()?$("#csrfToken").val().replace('/', ''):'';

it works!
@Ash-Mishra thanks!


Show version of the release in the admin

This is something Open Zaak has and is quite useful when reviewing issues in order to determine (using a screenshot of the environment) which version a customer has installed. Showing the version number in the admin (after being logged in) can avoid a bit of back-and-forth.

[x] Open Zaak
[ ] Open Notificaties
[ ] Objects API
[ ] Objecttypes API
[ ] Open Klant
[ ] Referentielijsten API

@SonnyBA I merged your PR to add this in OAF and added it to 0.5.0, so the git dependencies can be replaced with 0.5.0 in your PRs

Thanks @stevenbal, all PR's should be pinned correctly now