TestHelmDeployPipelineRun is Flakey

Expected Behavior
End to end tests should not ideally only fail due to bugs, or more realistically, < 0.1% of the time (once we have testgrid working we'll know the exact % we are at).
Actual Behavior
The test TestHelmDeployPipelineRun (which is basically our most complex end to end test) has been flakey in some recent PRs:
#284 link to failure details had this errror:
I1128 21:53:58.815] 	helm_task_test.go:141: Error from pinging service IP <IP_ADDRESS> : timed out waiting for the condition

#276 link to failure details had this two errors not sure if one is a symptom of the other:
I1130 19:25:53.296] Error: a release named gohelloworld already exists.
I1130 19:25:53.296] Run: helm ls --all gohelloworld; to check the status of the release
I1130 19:25:53.296] Or run: helm del --purge gohelloworld; to delete it
I1130 19:25:53.296] {"component":"entrypoint","error":"wrapped process failed: exit status 1","level":"error","msg":"Error executing test process","time":"2018-11-30T19:14:36Z"}

I1130 19:25:53.292] 2018-11-30T19:15:32.445Z	info	TestHelmDeployPipelineRun	test/build_logs.go:43	build logs {"level":"warn","ts":1543605254.9143634,"logger":"fallback-logger","caller":"logging/config.go:65","msg":"Fetch GitHub commit ID from kodata failed: \"ref: refs/heads/test\" is not a valid GitHub commit ID"}

This one kind of looks cleanup related :thinking:
Steps to Reproduce the Problem
Flakey so hard to say for sure!
Additional Info
Some possible causes:

Maybe the timeout to wait for the service itself to come up (via helm) is just too short? (would be good to understand why this is slow)
An actual bug in the Pipeline
Some logic which needs to be more open to retrying
Some kind of test infrastructure issue (seems unlikely since it's always this same test and the rest of our tests are fine, but who knows!)

A bunch more instances on #288 logs (or maybe something new has gone wrong??)
Also looks like this error message could use some love:
I1130 22:01:56.342] 	helm_task_test.go:106: Error waiting for PipelineRun helm-deploy-pipeline-run to finish: %!s(<nil>)

I don't think we've seen this particular flake in a while, closing this issue.


Create list_user_policies.py

Adding python script to list out users and any attached IAM policies.
This is a part of a project testing technical ability.

Hi, I am Omero from Turbot.
Do you mind if I review your PR next year as I am about to go on leave?

There is no rush for this at all. This is part of a technical evaluation
for a role with turbot. Part of the process was to create a pull request
for my fork. Please enjoy your break and I will work with David on if it
actually even needs to be approved/reviewed.
All the best,
Shane Vertner

Message ID: @.***>


albert: 0.11.1 -> 0.11.3

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Applied in edaf76a99db739a04fb043678b2fcde422e2da71, thank you!

Thanks for merging!


Using Azure Policy to verify the presence of Calico apiserver in arc cluster

First Jumpstart scenario
Calico #818

I will close this pr and create a new one with eks arc and gke arc.


DuckDuckGo jumps to far back after swiping backwards

Steps to reproduce:

Search something
Open the site
Swip to get backwards
App jumps back to start page, clear the search field and you have to start again.

Can't reproduce this on 6.5.0 (518).


Changing the depth quality of camera.

I am running the depth sensing tutorial. What parameters should I use to change depth quality of the camera. Because I am just capturing a flat wall and even at different distances the wall looks too curvy with descent amount of depth error easily visible on the point cloud. I don't know if its the right platform to ask but I would appreciate if anyone can answer this?

Hello @ashish2091, the ZED is a stereo camera and works via finding stereo correspondences between the left and right images. I assume you have a white wall (a homogeneous texture), which will make even flat surfaces noisy because it is hard to match a pure white pixel region with a pure white pixel region.


🚧Update NVorbis NuGet package

Complete The Item Below

[X] I have updated the title without removing the 🚧 emoji.

Description
Update the NVorbis NuGet package from version v0.10.3 to v0.10.5+.
If the version of the package is greater than v0.10.5, only update the package if it is a minor or path update.
History:
This update was intended in issue #293, but somehow it got downgraded from version v0.10.4 to version v0.10.3.  The intention was researched but no answer could be found and the intention or reasoning for the downgrade is unclear.
You can view the downgrade change here.  Look at the Velaptor.csproj file for the change.
If there is a major update available when this issue is being worked on, please notify @CalvinWilkinson about the higher package update available before updating the package.
Acceptance Criteria

[x] ~NVorbis NuGet package updated from version v0.10.3 to version v0.10.5+~
[ ] Remove the commented package reference for NVorbis that is set for version v0.10.5

ToDo Items

[X] Change type labels added to this issue.  Refer to the Change Type Labels section below.
[X] Priority label added to this issue.  Refer to the Priority Type Labels section below.
[X] Issue linked to the correct project (if applicable).
[ ] Issue linked to the correct milestone (if applicable).
[ ] Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels

Change Type
Label

Bug Fixes
🐛bug

Breaking Changes
🧨breaking changes

New Feature
✨new feature

Workflow Changes
workflow

Code Doc Changes
🗒documentation/code

Product Doc Changes
📝documentation/product

Priority Type Labels

Priority Type
Label

Low Priority
low priority

Medium Priority
medium priority

High Priority
high priority

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

do you want an update of all dependencies ?

@x0rld Hello!!
I actually have already updated all the dependencies just recently.
NVorbis is all I need right now.  But if you want to check for other updates and let me know whats up, that would be awesome.!!

do you want an update of all dependencies ?

I also apologize about the late response.  I work on this full time and yesterday it did not show me a notification.  But this morning it did.  I don't know what is up with that.  I am usually quite responsive.
If you are interested, I have a discord channel as well if you want to chat or have questions or anything. :)

Reassigned issue to @CalvinWilkinson.  Original assignee did not respond to the the linked pr #397

No nuget package to update.  The only thing to do is remove the comment from the csproj file.
The commented NVorbis nuget package reference was before all the sound functionality was converted into the CASL project.


Added AdminTest to try phone connectivity

As mentioned in https://github.com/Rhymen/go-whatsapp/issues/85, it's possible to verify phone connectivity via ["admin", "test"] command which returns ["Pong", true] when everything is ok.
This PR adds a new method called AdminTest() to be used any moment in any implementation.
At the WppWeb, this verification is only called when phone is unreachable in a way that I couldn't understand yet. So I suggest only call that in weird behaviours on your connectivity for a while.

Close due branch migration


authorid token does not exist

Cant put %authorid% on filenaming
it says %authorid% token does not exist

OS: Windows 10
Grabber version: 5.15.2

Hello
It shows as not existing but it does. You can ignore the warning as long as you're using one of the sources that support it (Danbooru 2.0 sources, E621, Pixiv, Philomena).
I will push a fix to not trigger this warning for this token.


Add checking number of Ready pods

I have added one more step in the wait-for-deployment script - checking number of pods that are in Ready state, in most cases this step is available right away after "Available replicas" is OK, but there might be other cases (which I don't know yet).
I have also improved log messages that should help with debugging.
It expects at least X pods to be Ready, there might be more pods that are in different state, for example Terminating, etc

@wlk Thanks for the PR! Checking the pod state definitely sounds worthwhile doing.
I'll try to review your PR until tomorrow.

@wlk Looking at my original implementation again, I realize that I check the deployment's status on the total number of available replicas which is defined as the

Total number of available pods (ready for at least minReadySeconds) targeted by this deployment.

To my understanding, that's equal to the info you'd get from parsing the pod's status conditions. Or am I missing something?

I think we might be checking the same thing but from 2 different angles.
It's hard for me to say exactly but I think there might be cases where those 2 things are not equal.
We use readinessProbe and livenessProbe (with initialDelaySeconds) not minReadySeconds when staring pods.
I think it's fine to remove the check I added  (until more information is available)  but keep improved log messages, wdyt?

I have moved improved logging as part of https://github.com/timoreimann/kubernetes-scripts/pull/4 closing this one


Make icons on snake toolbar change

Currently the icons on the toolbar are fixed. They should change:

have one single play/pause button. When game is finished, the icon shows a "play" button, this will start a new game; when game is ongoing, show a "pause" button, that will pause the game if clicked; when game is paused, show a "play" button, which will continue the game (e.g. not start a new game).

mute button: if sound is on, icon should be "sound_on"; when clicked, change icon to "sound_mute", and mute the sounds; when clicked again, change the icon back to "sound_on" and activate sounds.

Algo do t'he same for all games

Already done for budcaminas.

Done for ahorcado.

Done for 15puzzle, mute button.

Done for 2048, mute button.

Done for memory, mute button.

Done for pong with pause button, and snake with pause and mute buttons. I keep pause button separated from new game button for simplicity, although they could be the same button. But this would require additional logic to detect if the game has to start from 0, or just activate motion. And would not allow a game to restart without being finished. So I prefer having two separate buttons.

All buttons implemented, issue can be closed.


Add renderer.nim and dynamicRenderer.nim

Break up parser.nim into the parser and renderer part, also add the dynamic renderer

dynamic renderer is not needed any more, since we do hot code reloading now.


Consider valid the incomplete forms.

if I have a FormGroup like this:
final form = FormGroup({
  'name': FormControl<String>(),
  'address': FormControl<String>(),
});

but in my form I add only one ReactiveTextField:
body: ReactiveForm(
  formGroup: form,
  child: Column(
    children: [
      ReactiveTextField<String>(
        formControlName: 'name',
      ),
    ],
  )),
)

the form will never be valid.
Should be valid because if I don't need to edit a field I should be able to validate the rest of fields.
Many thanks.
Claudio

Also try to use this package
It simplifies reactive_forms development
https://github.com/artflutter/reactive_forms_generator


Crafting is broken

Current GitHub and normal download versions of the crafting system are broken. Server gets the error
[Clockwork:Command]
The 'CraftBlueprint' command has failed to run.
gamemodes/clockwork/framework/sh_kernel.lua:4112: attempt to index local 'player' (a nil value)

Same thing.

This issue has been fixed.


style: add category property to commands

Context
The display of the commands was not standardized: some commands were not prepended by GitGuardian, and the others were using gitguardian instead of GitGuardian.

What has been done
Update package.json to group GitGuardian commands into the GitGuardian category.
Validation
Open the command palette and verify that GitGuardian commands are prepended by GitGuardian:

So you've added "category": "GitGuardian" for all commands, but in your screenshot, where is the GitGuardian: prefix coming from? Isn't going to be doubled? (or is it already coming from this PR?)

It's coming from the views property: the VS Code automatically adds commands to open the views and prepend the command by the name of the extension, GitGuardian in this case.
I've added a commit to fix some case issues in the views names.


Please update std/archive package to latest (0.213.0) version

Hello, I upgrade deno to 1.4.0 and found deno is complaining about this library.
And I found, in Deno 1.4.0 Deno.FsFile.rid and Deno.close are marked as deprecated, but this library is still using it.
And that come from<EMAIL_ADDRESS>list in deps.ts, please upgrade the version.

#17 I opened a pr, only modify std/archive version.

Landed in v0.4.6


$HOME as workspace

I work in NodeJS a lot,
I usually use the nodejs docker image which contains the node user.
I usually set my projects repo pointed to the home directory of node e.g. /home/node
this allows me to forward my own .ssh credentials that I store locally in the repo directly to the home folder.
Is there a way to do this? Because I'm currently running into a ton of issues around getting a dev container setup.

Closing given it's been a few weeks and I answered above.  Please reopen if required.

@Chuxel could you provide some example code? I'm not familiar with the terms you're describing. I've tried setting the workspaceFolder and workspaceMount and can't seem to figure it out.

ping @Chuxel

@lifeiscontent The docs above cover setting the properties -- that's really all there is to it. To get more specific, I'd need to know more like what directory structure looks like in more detail and your devcontainer.json.

@lifeiscontent Also, posting any errors you are seeing would be helpful along with the OS you are on.  There are some "gotchas" for Windows with SSH keys due to how permissions work, for example.


[INFRA-3533] Add an env for target link length where nessecary

Here we make the length of the target URLs definable via an environment variable.
There is another requirement to edit the table in Postgres and remove the hardcoded 5000 char limitation on the target field. I'm currently testing a solution to this locally.

Prerequisites:

Locate the secrets, make ready the username and password for the command below

kubectl get secrets kutt-secrets -o yaml -n kutt --context=gke_bugsnag-155907_us-east1_bugsnag-monitoring

Plan:

Take snapshot of the Postgres volume:

gcloud compute snapshots create kutt-postgres-0-pv-db-migration --source-disk=kutt-postgres-0-pv --source-disk-zone=us-east1-b

Exec onto the Postgres pod into psql, replacing [USERNAME] and the interactive password prompt with the appropriate secrets discovered earlier:

kubectl exec -it postgres-0 -n kutt -- psql -U [USERNAME] -W kutt

Change the relevant column:

ALTER TABLE links ALTER COLUMN target TYPE VARCHAR;

Ensure the output of \d+ links line beginning target matches the following output precisely:

 target       | character varying        |           | not null |                                   | extended |              |

Test the change using a target URL under 5000 characters and one over 5000 characters

Seems reasonable. Assume this is destined for a separate upstream PR as well.

Because of the DB migration on the side I'm not sure it would be welcome.

Seems reasonable. Assume this is destined for a separate upstream PR as well.

Because of the DB migration on the side I'm not sure it would be welcome.

It would be nice not to have to maintain it. You could just add an extra migration a la https://github.com/thedevs-network/kutt/blob/041aed5ad6d9c049aaefa9f150e93bf8835f2203/server/models/link.ts#L44 now that you know what is required.

It would be nice not to have to maintain it. You could just add an extra migration a la https://github.com/thedevs-network/kutt/blob/041aed5ad6d9c049aaefa9f150e93bf8835f2203/server/models/link.ts#L44 now that you know what is required.

You've convinced me it's a good idea! I'll out something together.

@trvrnrth I added the DB change as a migration, this will hopefully make it nicer to push upstream.

I tested this by tearing down docker and pruning, bringing it up and check:
❯ docker exec -it kutt-postgres-1 /bin/sh
/ # psql -U user -W kutt
Password:
psql (12.15)
Type "help" for help.

kutt=# \d+ links
                                                            Table "public.links"
    Column    |           Type           | Collation | Nullable |              Default              | Storage  | Stats target | Description
--------------+--------------------------+-----------+----------+-----------------------------------+----------+--------------+-------------
...
 target       | character varying        |           | not null |                                   | extended |              |

All appears well.


Add confirmation bubbletea example

Adds another concrete bubbletea widget example on how to use the confirmation prompt with custom keyMap.
Feel free to "not" merge and close this PR since the example is so similar to the existing selection bubbletea example. It might not be needed/useful. I'll leave it to you.

Thank you for your contribution. I think I'll keep the examples as they are, because I'd like to have minimal examples for the basic use-cases that can easily be found. I think that the docs should be the primary way to learn about customization.
That said, I like your example and I think I'll leave this PR open for a while such that it an be easily found when someone is looking for this use-case.


Feature/allow multiple debug files issue 430

A tiny improvement in logging setup, which allows convenient use of multiple log files that are logged into the correct data directory. Note that names of these targets have to start with debug prefix.
This change has been documented in using-logging.md documentation file and some new examples of configuration files were also added.
Fix #430

lovely, i needed that :-)


Grid layout does not have autoprefix

Problem description
I inspected the docs of material-next and I saw that Grid layout does not have autoprefix. Because some browsers does not support full with flex layout. It is really important to have autoprefix.
Versions

Material-UI: next
React: 15.6.0
Browser: Chrome

It comes down to the question: what browser do we want to support? Right now, we use the default options of jss-vendor-prefixer that use css-vendor internally.

Hi @oliviertassinari !
Currently I use the config of bootstrap: https://github.com/twbs/bootstrap/blob/v4-dev/build/postcss.config.js
Please consider it!!!

After more digging, @kof raised some very interesting point regarding how the autoprefixing tools is working. It's using feature detection:

Feature detection means it tests if browser really supports a particular property, so agent string is not used. For the server we can use any static prefixer including original autoprefixer.

https://github.com/cssinjs/jss/issues/518#issuecomment-308377117
So your observation is expected. Here are the prefixes with Chrome v28


Feature assignable container

Assignable container feature via $(".container").scrollify(), still backwards compatible to use $.scrollify()

Worked in my test case but I'd be happy if people could test some more and give feedback

This is not working for my test case: www.ashwebdev.com/buchanan
Trying to recreate http://www.hugeinc.com/ where there is additional content at the bottom which has normal scroll

This update changes the syntax for all of Scrollify's public methods. Introducing the fn property makes it non-backwards compatible with any existing Scrollify project.

+1 for this options

It does not align the sectons in the container correct when body already scrolled down.

maybe this PR is not working as expected, but this plugin really need this feature


Files uploaded to Data Extract are not appearing in collection

https://github.ibm.com/ecosystem-engineering/watsonx-planning/issues/27

Issue was caused by a proxy configuration error in the UI


sst_service: add get mode rpc for import_sstpb

What is changed and how it works?

Issue Number: Close #14249
What's Changed:

add get mode rpc for import_sstpb

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Manual test (add detailed scripts or steps below)
A new client function to call this rpc, and check the response.

Release note
None

/review default

unused rpc yet


shader: Implement missing builtin functions

dFdx
dFdy
fwidth
noise1
noise2
noise3
noise4

Are there counterparts in Metal and HLSL?

Confirmed there are counterparts for dFdx, dFdy and fwidth in Metal and HLSL, but not for the others.
CC @kyeett


Implementation of CodableDictionaryKey induces ambiguity errors.

import CodableDictionary
print(Int(0).description) // ⛔ Ambiguous use of 'description'

Wait for https://github.com/YOCKOW/SwiftCodableDictionary/pull/3

#3 is merged.


Exiting the app when on full screen will leave a black screen

Description
When the app is running on full screen mode, on OSX, exiting the app will bring a black screen and the app will continue to run.
Expected Behavior
The app should close.
Actual Behavior
The app won't close, instead a black screen is shown
Possible Fix
I'm not a JS dev, so I really don't know how it's possible to fix it.
Steps to Reproduce

Open the app

Switch to full screen

Exit the app

Your Environment

Zap version: v.0.4
Operating System and version: Mac OSX Mojave 10.14.3

Hi @otaviobps - I've been unable to reproduce this issue. Does it reliably reproduce for you?
If so, please can you provide exact steps to reproduce (have you created a wallet? are you connecting to your own node or using the built in neutrino client? are you logged into a wallet when you quit? is the app in the middle of syncing when you quit? etc etc). I want to understand exactly what state your app is in when this happens.
Perhaps you could provide a video that shows exactly what you do to make this happen?
Thanks!

Hi @mrfelton, I've noticed this bug is not exclusively to your app, a few others have the same behavior. It doesn't mind the state the app is, if maximize it and close it, the bug happens.
I'm attaching the video

Thanks @otaviobps . I can reproduce this and will look into it. I guess it's probably an Electron issue rather than anything Zap specific.
One thing to note is that clicking the red close button does not exit the app, it only closes the window. The app in only minimised and continues to run. It will still be in your dock, and can be maximised again by clicking on the app in the dock.
To actually exit the app you should choose Quit from the Zap menu, or press cmd+q

To actually exit the app you should choose Quit from the Zap menu, or press cmd+q

Yes, I noticed this. However the behavior of the app is strange when you click on the red close button if it's maximized. When you open again the app, it looks very small, like it's in the video. Yes, probably is something with Electron


feat(user-settings): Search for user avatar also in the entities

Hey, I just made a Pull Request!
If the identity system doesn't provide an avatar, but the existing user entity does have the correct annotation use that as the profile avatar.
Fixes #26838
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] ~Added or updated documentation~
[x] Tests for new functionality and regression tests for bug fixes
[ ] ~Screenshots attached (for UI changes)~
[x] All your commits have a Signed-off-by line in the message. (more info)

Argh, seems like other things break with these changes, will take a look later, going back to draft

@freben hmm, the node 18 ci failed again :/

@vinzscam @freben ok, build passed this time. Ready to merge


allow setting ignoreDirectories in workbox-cli first run

Or maybe multiple globDirectories
Library Affected:
workbox-cli
Issue or Feature Request Description:
My usual setup for gh-pages apps is:
src/
dist/
node_modules/
index.html
favicon.png

And I want end up with the following config:
module.exports = {
  'globDirectory': './',
  'globPatterns': [
    '**/*.{js,svg,png,html}'
  ],
  'swDest': 'sw.js',
  'globIgnores': [
    'workbox-cli-config.js',
    'node_modules/**/*',
    'src/**/*'
  ]
}

So is the problem that the globdirectory isn't dist?
Sorry I don't know what the end result is in terms of files being cached.

@psimyn did the CLI not allow you to select dist as the main directory?

Setting dist works, but I also wanted to add index.html (in parent folder). I instead use dist and have html files copied there by build, so can close this


Add a new setting to download the dev version

Hi please add support for a new setting that will download the dev version instead of the stable one if the user wanted too.

Unless I am mistaken, it does use the getcomposer.org/installer, which by default installs the latest dev version (no stable version exists at the moment, only tagged alpha's).

Yes but I mean download straight of the master branch please.

The getcomposer.org/installer downloads the latest snapshot (which can also be found on https://getcomposer.org/download/). This equals the latest commit of master.

Yup, it uses the getcomposer.org/installer, which downloads whatever is considered the version. It has a flag for downloading a different version, but we don't use that (and I am not sure that it would be applicable to an easy-use, generic setup program)


"<" seems to break something?

Hello Tolentino, love your work!
I'm new to this, so I might be doing something wrong and apologise if so.
While tinkering, I've found that by adding "<" to an outgoing message the bot doesn't send the message. I've tried using the example codes you've provided but none of them get sent if the message includes "<".
I also tried the "echoBot" example provided. It works flawlessly but if the message includes "<" the bot will not echo the message.

This was done using the echoBot sketch. Other symbols don't seem to cause any problems.
I hope I explained well enough, please let me know if you need anymore information.
Thank you for your time.

See
https://stackoverflow.com/questions/40626896/telegram-does-not-escape-some-markdown-characters
where it is mentioned that
"<" will be read as tag start and probably unrecognized.
Op ma 1 mei 2023 20:35 schreef wardom @.***>:

Hello Tolentino, love your work!
I'm new to this, so I might be doing something wrong and apologise if so.
While tinkering, I've found that by adding "<" to an outgoing message the
bot doesn't send the message. I've tried using the example codes you've
provided but none of them get sent if the message includes "<".
I also tried the "echoBot" example provided. It works flawlessly but if
the message includes "<" the bot will not echo the message.
[image: image]
https://user-images.githubusercontent.com/16410764/235505710-80152450-473e-4c3c-a2c3-d436c204d72f.png
This was done using the echoBot sketch. Other symbols don't seem to cause
any problems.
I hope I explained well enough, please let me know if you need anymore
information.
Thank you for your time.
—
Reply to this email directly, view it on GitHub
https://github.com/cotestatnt/AsyncTelegram2/issues/108, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIL5KVBMG37UJZN5B77MQNLXD77APANCNFSM6AAAAAAXSBPLZI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi @sanderkob
The default formatting options used by AsyncTelegram2 library is HTML
The char '<' it's an HTML start TAG so probally the server parser expect the remaining code and this cause error.
Try switching to the MarkdownV2 formatting style.
Check the example or simply add this line:
myBot.setFormattingStyle(AsyncTelegram2::FormatStyle::HTML /* MARKDOWN */);
You can try also to encode your message text using entity name or entity number:

Result
Description
Entity Name
Entity Number

non-breaking space

<
less than
<
<

>
greater than
>
>

&
ampersand
&
&

"
double quotation mark
"
"

'
single quotation mark (apostrophe)
'
'

¢
cent
¢
¢

£
pound
£
£

¥
yen
¥
¥

€
euro
€
€

©
copyright
©
©

®
registered trademark
®
®

Hello, thank you for the replies
Added the line:
myBot.setFormattingStyle(AsyncTelegram2::FormatStyle::HTML /* MARKDOWN */);
Now the bot is able to display the char "<" when using entity names or entity numbers.
Appreciate the help and looking forward to more of your work!


DB migrations deployment is stuck after new deployment

What is the bug?
It seems like when there are no more migrations to run, the db-migrations deployment is getting stuck for some reason:
❯ stern airflow-v2-db-migrations-5bcd44b54c-n9j8k
+ airflow-v2-db-migrations-5bcd44b54c-n9j8k › dags-git-sync
+ airflow-v2-db-migrations-5bcd44b54c-n9j8k › db-migrations
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/configuration.py:357 DeprecationWarning: The dag_concurrency option in [core] has been renamed to max_active_tasks_per_dag - the old setting has been used, but please update your config.
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-microsoft-mssql uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-ssh uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-tableau uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations [2021-11-03 01:08:25,563] {providers_manager.py:152} WARNING - Exception when importing 'airflow.providers.google.leveldb.hooks.leveldb.LevelDBHook' from 'apache-airflow-providers-google' package: No module named 'plyvel'
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/azure/cosmos/session.py:186 SyntaxWarning: "is not" with a literal. Did you mean "!="?
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/azure/storage/common/_connection.py:82 SyntaxWarning: "is" with a literal. Did you mean "=="?
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-microsoft-mssql uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-ssh uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations /home/airflow/.local/lib/python3.8/site-packages/airflow/providers_manager.py:517 DeprecationWarning: The provider apache-airflow-providers-tableau uses `hook-class-names` property in provider-info and has no `connection-types` one. The 'hook-class-names' property has been deprecated in favour of 'connection-types' in Airflow 2.2. Use **both** in case you want to have backwards compatibility with Airflow < 2.2
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations [2021-11-03 01:08:27,202] {providers_manager.py:152} WARNING - Exception when importing 'airflow.providers.google.leveldb.hooks.leveldb.LevelDBHook' from 'apache-airflow-providers-google' package: No module named 'plyvel'
airflow-v2-db-migrations-5bcd44b54c-n9j8k db-migrations [2021-11-03 01:08:27,297] {db_migrations.py:56} INFO - there are no unapplied db migrations, continuing...
airflow-v2-db-migrations-5bcd44b54c-n9j8k dags-git-sync INFO: detected pid 1, running init handler
airflow-v2-db-migrations-5bcd44b54c-n9j8k dags-git-sync I1103 01:08:15.696503      13 main.go:430]  "level"=0 "msg"="starting up"  "args"=["/git-sync"] "pid"=13

What version of the chart are you using?:
I am using version 8.5.2
What is your Kubernetes Version?:
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:10:45Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:04:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

What is your Helm version?:
❯ helm version
version.BuildInfo{Version:"v3.4.1", GitCommit:"c4e74854886b2efe3321e185578e6db9be0a6e29", GitTreeState:"dirty", GoVersion:"go1.15.5"}

Please copy your custom Helm values file:
airflow:
    fernetKey: "some-key"
    executor: KubernetesExecutor
    users: []
    image:
        repository: some-host
        tag: latest
        pullSecret: gitlab-pull-secret

    config:
        ## Security
        AIRFLOW__API__AUTH_BACKEND: "airflow.api.auth.backend.deny_all"
        AIRFLOW__WEBSERVER__EXPOSE_CONFIG: "False"
        AIRFLOW__WEBSERVER__RBAC: "True"
        AIRFLOW__WEBSERVER__SECRET_KEY: "some-secret"

        AIRFLOW__KUBERNETES__LOGS_VOLUME_CLAIM: "airflow-logs"
        AIRFLOW__KUBERNETES__DAGS_VOLUME_SUBPATH: "repo"
        AIRFLOW__KUBERNETES__DELETE_WORKER_PODS: "True"

        ## DAGS
        AIRFLOW__SCHEDULER__DAG_DIR_LIST_INTERVAL: "30"

        ## Core
        AIRFLOW__CORE__SECURE_MODE: "True"
        AIRFLOW__CORE__LOAD_EXAMPLES: "False"
        AIRFLOW__CORE__PARALLELISM: "10"
        AIRFLOW__CORE__DAG_CONCURRENCY: "5"
        AIRFLOW__CORE__MAX_ACTIVE_RUNS_PER_DAG: "1"

        ## Email (SMTP)
        AIRFLOW__EMAIL__EMAIL_BACKEND: "airflow.utils.email.send_email_smtp"
        AIRFLOW__SMTP__SMTP_HOST: "smtpmail.example.com"
        AIRFLOW__SMTP__SMTP_STARTTLS: "False"
        AIRFLOW__SMTP__SMTP_SSL: "False"
        AIRFLOW__SMTP__SMTP_PORT: "25"
        AIRFLOW__SMTP__SMTP_MAIL_FROM<EMAIL_ADDRESS>
        ## Disable noisy "Handling signal: ttou" Gunicorn log messages
        GUNICORN_CMD_ARGS: "--log-level WARNING"

    kubernetesPodTemplate:
        resources:
            requests:
                cpu: "200m"
                memory: "250Mi"
            limits:
                cpu: "400m"
                memory: "500Mi"

logs:
    path: /opt/airflow/logs
    persistence:
        enabled: true
        storageClass: nfs

workers:
    enabled: false

flower:
    enabled: false

redis:
    enabled: false

dags:
    path: /opt/airflow/dags
    gitSync:
        enabled: true
        repo: "some-repo-url"
        sshSecret: "some-secret-name"
        sshSecretKey: "some-key-name"
        depth: 0

web:
    replicas: 1

ingress:
    enabled: true
    web:
        host: "example.com"
        annotations:
            nginx.ingress.kubernetes.io/affinity: cookie

postgresql:
    enabled: false

externalDatabase:
    type: postgres
    host: some-host
    port: some-port
    database: some-db
    user: some-user
    passwordSecret: some-secret
    passwordSecretKey: some-key
    properties: some-properties

serviceMonitor:
  enabled: false

prometheusRule:
  enabled: false

pgbouncer:
  enabled: false

I have obfuscated some bits of the values file, but it is pretty generic.

Same issue here with the latest version of the chart. I thought it was a problem with my external database. I'm using a Postgres CRD for spinning up an instance. It works fine for other services but configured with Airflow the "db-migrations" pod errors after a certain amount of time in our cluster with the exact same logs as yours.

In my case, I am using a managed Postgres DB from DigitalOcean btw and the version is Postgres 12, I don't know if that matters.

@ChiemJanssen @karakanb can you explain what you mean by "getting stuck", if there are no migrations to apply what are you wanting it to do?

The pod is literally stuck in "Running" state, nothing is happening, the pod is not going away, it is just sitting there and doing nothing with no logs. I guess it is waiting on a lock or something, I don't know what exactly it is doing, but normally it'd run the migrations and be done with it, but it is not going away.
NAME                                                                   READY   STATUS             RESTARTS   AGE
airflow-v2-db-migrations-6979f8db67-wvllj                              2/2     Running            0          13h
airflow-v2-scheduler-55cfc856bd-xpm9v                                  2/2     Running            0          13h
airflow-v2-web-6487cc9464-w4d45                                        2/2     Running            0          13h

The latest log is there are no unapplied db migrations, continuing....

ah, I think it is because of the sync_forever flag, right? although I don't understand why would the migration be looping forever. when a new deployment runs, there'll be a new pod being created with the never image, which would have the latest migrations anyway, and running the migrations once should be enough there to kill the pod. I understand why running it as a post-install hook might not work with --wait, but in this approach I don't understand why do we have to have an infinite loop.

@karakanb this is the intended behaviour, it loops forever because Pods in a Deployment must have restartPolicy =  Always, so they cannot "finish", as this looks like crashing Kubernetes.
If you are not using the helm --wait flag, and want to use a post-install job, set airflow.dbMigrations.runAsJob = true, and it will only run once per helm update.


[NFC] Change guidelines to be invisible in PR template so they don't have t…

…o be deleted
Summary
Pssst...you... yes you! Did you run make lint and perhaps make format? If not, go away, run those commands, and then come back (if you are using VS Code... then you shouldn't need to do make lint
Please provide a summary of the change. What does this PR do? What does it solve?
Additional Information
Auxiliary information and additional context for the change goes here.
Test Plan
Add information on how you tested your changes.

solving the problems you created hehe

Plsss Jaafar wrote it not me


Add slide panel

see #67
Note that I added a way to check the changes in dev mode:
npm run dev

See the demo folder.

Also minor but the demo flashes a zero 0 on loading

Should we re-open #23, and pass CSS modules with the components?

Yea it's annoying copying CSS everywhere, I just don't know how to properly publish and incorporate into the downstream apps. I am in favor of re-opening #23 and let me know if you have ideas how to implement.


Added Java and JS Courses

What does this PR do?
Add resource(s)
Description
Added Java and JS Course
How do we know it's really free?
It's from YouTube, It gives knowledge on Programming Fundamentals for Beginners.

Thanks, and welcome to free-programming-books!


Introduces jest v24

This introduces jest in v24.
Jest 24 uses babel 7 which supports TypeScript. Therefore we can remove ts-jest and use some babel presets and plugins instead.
@terrestris/devs please review
closes #810
closes #814

Coverage calculation seems to be different. :disappointed:
Seems like we need to put some effort into tests again.


Add JIRA Link

Signed-off-by: danintel<EMAIL_ADDRESS>

the rocket chat link does not open
the workload tutorial and example apps links return a 404

All the links work for me. See below.


Implement the RequestPreview component and update the IOUPreview

Details
Introduces a new ReportPreview component which shows the state of the report:

When outstanding: the outstanding balance, and name of person who owes will be displayed
When paid: the name of the payer, with a 'settled up' message, and a checkmark icon

Outstanding

Settled

NOTES:

This is pending a new reportAction. Today it is contained within the IOUPreview component. This means that no Avatar/Timestamp is shown to the left side of the component
Until we deprecate the IOUAction of type 'pay', there will be an additional IOUPreview shown beneath the ReportPreview once it is settled

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/278890
Tests

Test creating IOUS

Create Request from userA to userB
Both users should see 'UserB owes £1.23' beneath the IOUPreview
Create another request from userA to userB
The 'User owes £1.23' message should only display beneath the most recent IOUPreview
UserB should see a pay button beneath the reportPreview message
When userB taps the payButton, it should take them to the IOUDetailsPage (this is still relevant ATM)
UserB should settle the IOU
The pay button should disappear
A new message should display in the ReportPreview: 'User B settled up £1.23'

Offline tests

Being handled separately for urgency
QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Generating builds here... will add screenshots after

The CI builds are failing due to this. I submitted a PR here and once that is merged, I'll merge it into this PR and re0generate the builds.

I pushed fixes for that last thing so @luacmartins @Julesssss or anyone else following please review.
Since 3 of us now have pushed commits here I think as long as the last person to commit doesn't review AND self-merge we're okay.

Also I don't see it mentioned but this isn't supposed to address the Manual Request from a Workspace condition is it?
Testing that locally it's not rendering the same:

Thanks for the reviews and fixes. This is the first of two PRs, we're fixing the remaining issues here in the follow up to prevent further conflicts with the branched PR. It's in this PR that we switch to the new reportaction data source.

Also I don't see it mentioned but this isn't supposed to address the Manual Request from a Workspace condition is it?

@bondydaa would you mind explaining this? Are you saying we should show the Workspace instead of the admin user who sent it? If yes I'll create a follow up issue.

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.13-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Modifying owner-name and repository-name to be dynamic in README

Description
It would be cool if we can make the README instructions to use the action to have a dynamic name.
It was a little bit confusing for me to see that it is referring to the same repository that we are in.
I think that changing the owner name and the repository name to be dynamic will be helpful.
Screenshot

Before Changing
         owner-name: 'EddieHubCommunity'
         repository-name: 'gh-action-open-source-labels'

After Changing
          owner-name: ${{ github.repository_owner }}
          repository-name: ${{ github.event.repository.name }}

Oh nice 👍  great idea 💥


add install target to CMakeLists.txt

Codecov Report

Merging #23 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop    #23   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files            6      6
  Lines          495    495
======================================
  Hits           495    495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407bbf6...936b36d. Read the comment docs.


device:vacuum:0000A006:roborock-a01 cant get status

entity_class: MiotRoborockVacuumEntity
miot_type: urn:miot-spec-v2:device:vacuum:0000A006:roborock-a01:1
vacuum.status.error: '-704010000 Unknown'
vacuum.mode.error: '-704030013 Property is not readable'
state_updater: cloud

I can send the commands, but yhe status is empty.

Fixed for roborock.vacuum.a01 in commit: https://github.com/al-one/hass-xiaomi-miot/commit/f38a659fee22a1b6811c3240d4a2deca7e5ab7c7

yeap fixed! thanks!
almost ok, just not showing the battery state

Try https://github.com/al-one/hass-xiaomi-miot/commit/e256ee7e7ee37f7e2586479888e76aa560b5753d

Ok, ill try, just found


postinstall script : use /etc/debian_version for debian/ubuntu detection

currently we use /etc/lsb-release to detect debian,
but this file is only present on ubuntu.
/etc/debian_version is installed by default by debian and ubuntu
This fix
https://github.com/influxdata/influxdb/issues/5356

@aderumier Good catch. Have you signed the CLA?

@rossmcdonald I have signed the CLA just now.

@aderumier Perfect. Thanks for your help!


Fix for Rollbar-less setups

Just a hotfix :wrench: :ok_hand:

Coverage remained the same at 87.597% when pulling b35261fa388b728cf9621cf62dcef230c1b6b3e4 on RickCarlino:rendering_stuff into 64e109f82f3565ceb75d813b4736d007731a36d5 on FarmBot:staging.


Urlencoding of $defs

We use the Parser to bundle a JSON Schema. In this process references to definitions in $defs get encoded to %24defs.
Example: before bundling
        "signature": {
          "$ref": "#/$defs/signature"
        },

after bundling
              "signature": {
                "$ref": "#/properties/contentStructure/%24defs/signature"
              },

Unfortunately, the code generator won't eat the %24, so we have to uneconde it manually.
Is there a chance to avoid the encoding?

Note the notice in the readme file. https://github.com/APIDevTools/json-schema-ref-parser/issues/285

I dont believe this is happening anymore on latest - let me know with an example if it is


Get monthly records with needing to specify day number.

If we want to parse only a certain time-frame from DATE a to DATE b, we can do:
# sed -n '/5\/Nov\/2010/,/5\/Dec\/2010/ p' access.log | goaccess -a -
How can I do something similar to this, but just get the records for a month?
Example: everything in Feb 2010, so I don't need to calculate whether it is a leap year or how many days are in the month etc etc.

You could simply do:
grep 'Mar\/2018' /var/log/apache2/access.log | goaccess --log-format=COMBINED

or you can play also with date, e.g. to get only today's entries,
grep `date +"%d/%b"` /var/log/apache2/access.log | goaccess --log-format=COMBINED

Perfect thank you :)
Could I please ask if you have an example for getting data for a single hour as well?

Glad to hear that worked:)
You can do something like (assuming you have a COMBINED log)
awk -F'[: ]' '$5~/06/' /var/log/apache2/access.log | goaccess --log-format=COMBINED -

That will match the hour field (fifth) to 06 (6am).
And you can always combine multiple pipes, e.g.,
grep 'Mar\/2018' /var/log/apache2/access.log | awk -F'[: ]' '$5~/06/'  | goaccess --log-format=COMBINED -

This should get much easier when #117 is implemented :)

Thank you for your help :)
Is there a way to do it for multiple files at the same time, like in cPanel it has 2 files one for ssl and one for non ssl. So if the domain has been changed it is spread over multiple log files.

Is there a way to do it for multiple files at the same time, like in cPanel it has 2 files one for ssl and one for non ssl. So if the domain has been changed it is spread over multiple log files.

For multiple files you can simply cat those files and then grep as above. e.g.,
cat /var/log/apache2/access.log /var/log/apache2/access-ssl.log | grep 'Mar\/2018' | awk -F'[: ]' '$5~/06/'  | goaccess --log-format=COMBINED -

Closing this. Feel free to reopen if needed.


Only read .env when not running on netlify

This should fix the search box in netlify so because I think dotenv was overriding the variables.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixed bug

From was sending the from number in an array which cannot be handled by the ClickSend system and causes a 500 error. Changed from to "hass" as from number/name can only be up to 11 characters with no special characters or spaces.
Bug was introduced 6 months ago when support for multiple recipients was added.
Description:
Single line change removing a bug so that the From number in the sms sent is set to "hass" to correct sender array 500 error issue.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
notify:
  - platform: clicksend
    name: ClickSend
    username: xxxx
    api_key: xxxxx
    recipient: +61451111111

Checklist:

[✓] The code change is tested and works locally.
[✓] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[✓] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[✓] New dependencies have been added to the REQUIREMENTS variable (example).
[✓] New dependencies are only imported inside functions that use them (example).
[✓] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[✓] New files were added to .coveragerc.

If the code does not interact with devices:

[✓] Tests have been added to verify that the new code works.

Hi @JaxomCS,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I am a developer at ClickSend and am trying to fix the code after another contributed added a bug that prevents the integration working. Is there a way to get this fixed into production as continuous-integration/travis-ci/pr is rejecting my merge and is failing for an unrelated reason.

You should use to the dev branch

#17713


Remove write_jpeg and write_png in favor of encode + write_file

Follow-up from https://github.com/pytorch/vision/pull/2765
We don't need to have those functions be in C++ as they are just a combination of encode + write_file

The write_png and write_jpeg are still present in the codebase, I've just removed the C++ equivalents. But if we remove them in a follow-up PR we do need to change the documentation, yes


Game play/animation state machine fix

Modified the state machine to have better syncro with the gameplay states.

This branch should be merged into develop, not into main


chore: forward-port mathlib#18856

DO NOT MERGE YET

https://github.com/leanprover-community/mathlib/pull/18856 & https://github.com/leanprover-community/mathlib/pull/18858 for reviewer reference

@ericrbg, you've written "DO NOT MERGE YET", yet it is marked for review. I'll leave it as awaiting-author for now.

I was waiting for the SHA from the second alphabetising PR - all good! thanks scott :)


All question-answer pairs of S10 QA and Smart TV/remote QA?

Hi,
It seems that the data only contains 50 QA samples for S10 QA and 684 samples for Smart TV/remote QA. Is the full dataset available?

Thank you for interest in our paper. Sorry for the late reply.
The link to the entire corpus can be found here - https://drive.google.com/drive/folders/1-gX1DlmVodP6OVRJC3WBRZoGgxPuJvvt
The project website is - https://sites.google.com/view/emanualqa/home
Also, since this project was in collaboration with Samsung, we are unable to provide with the full S10 QA Dataset at this time. However, the questions follow the format of data/smart_remote_QA.zip, and I would request you to use that for the time being. Also, if you would like to use our code/data, we request you to cite our paper.

Hi @abhi1nandy2 , for the released 50 QA samples for S10 QA and 684 samples for Smart TV/remote QA, I could not locate a clear indication of any sort of license terms. Can you please put a license for that? Thanks!


Add domain layer documentation

closes #52

Codecov Report

Merging #61 (9f3a32a) into main (1aa2b6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   98.72%   98.72%
=======================================
  Files          47       47
  Lines         705      705
=======================================
  Hits          696      696
  Misses          9        9

Impacted Files
Coverage Δ

lib/domain/client/client_entity.dart
100.00% <ø> (ø)

lib/domain/client/client_values.dart
100.00% <ø> (ø)

lib/domain/common/common_errors.dart
100.00% <ø> (ø)

lib/domain/common/common_validators.dart
100.00% <ø> (ø)

lib/domain/common/common_values.dart
100.00% <ø> (ø)

lib/domain/common/entity_mixin.dart
100.00% <ø> (ø)

lib/domain/common/value_object.dart
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Webpack complaining about missing loader for .prisma/client/index.d.ts - Migrating from nexus-prisma-framework to @nexus/schema

So I'm in the process of migrating a project I created based off this example a few months ago (https://github.com/prisma/prisma-examples/tree/latest/typescript/graphql-nextjs) to @nexus/schema.
I've got it almost finished I think, but I'm stuck at a point where webpack seems to be complaining about missing loaders for the .prisma/client/index.d.ts file being referenced in makeSchema's typegenAutoConfig sources.
My entire pages/api/index.ts file looks like this:

import { makeSchema } from '@nexus/schema'
import { nexusPrisma } from 'nexus-plugin-prisma'
import { ApolloServer } from 'apollo-server-micro'
import { Item, Company, Warehouse, Image, Location, Status, Shipment, Mutations, Crud } from '../../graphql/schema'

const schema = makeSchema({
  typegenAutoConfig: {
    sources: [
      {
        source: require.resolve('../../../node_modules/.prisma/client/index.d.ts'),
        alias: 'prisma',
      },
      {
        source: require.resolve('../../graphql/context.ts'),
        alias: 'ContextModule'
      }
    ],
    contextType: 'ContextModule.Context'
  },
  types: [Item, Company, Warehouse, Image, Location, Status, Shipment, Mutations, Crud],
  plugins: [
    nexusPrisma({
      experimentalCRUD: true,
    }),
  ],
})

export const config = {
  api: {
    bodyParser: false,
  },
}

export default new ApolloServer({ schema }).createHandler({
  path: '/api',
});

Am I missing something?

Full Error Output

❯ npm run build

<EMAIL_ADDRESS>build /opt/newtelco/katalog
next build

Loaded env from /opt/newtelco/katalog/.env
Warning: Built-in CSS support is being disabled due to custom CSS configuration being detected.
See here for more info: https://err.sh/next.js/built-in-css-disabled
info  - Using external babel configuration from /opt/newtelco/katalog/.babelrc
info  - Creating an optimized production build
Failed to compile.
./node_modules/.prisma/client/index.d.ts 34:7
Module parse failed: Unexpected token (34:7)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|  * Query Engine version: af1ae11a423edfb5d24092a85be11fa77c5e499c
|  */

export declare type PrismaVersion = {
|   client: string
| }

Build error occurred
Error: > Build failed because of webpack errors
at build (/opt/newtelco/katalog/node_modules/next/dist/build/index.js:15:918)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: next build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ndo/.npm/_logs/2020-10-29T18_18_27_651Z-debug.log

All my errors were basically because the ctx didn't have a valid prisma object on it.
For future searchers, I fixed it by adding the following to my makeSchema call:
const prisma = new PrismaClient()

...

const schema = makeSchema({
...
  plugins: [
    nexusPrisma({
      prismaClient: ctx => ctx.prisma = prisma,
      experimentalCRUD: true,
    }),
  ],
...
})


Fix IUknown typos in documentation

Just a couple of typos - although the whole trait doesn't exist anyway, so not sure how important these are. The only get_interface I saw implemented was on InterfaceRc.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Rantanen sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Looks good! Thanks for catching these!


Transaction not automatically executing

The transaction already had 1 confirmation and the checkbox to execute transaction was set, but the transaction was only approved

Maybe related to #563
TODO: Add steps to reproduce

Same here, and It seems like @francovenica is experimenting that too https://github.com/gnosis/safe-react/pull/601#issuecomment-589723037

this could be the fix, @nicosampler found a similar bug last week
https://github.com/gnosis/safe-react/pull/576/files#diff-15165b30ad944d226ee235ded94d4c72R61

@rmeissner, I think this can be considered as resolved as part of #576

Actually tried to look at the code ... I cannot see anything that fixes this based on the changes of https://github.com/gnosis/safe-react/pull/576/files#diff-8c434bb5f585f97d1baee4d4b5028ee1R28 (since the changes in PR were mainly for threshold == 1) but hard to say if we cannot reproduce this.

@rmeissner did you execute transactions in a sequence?
e.g execute one first, then straight execute another without waiting for previous one to update

I did not encounter the issue, but as far as I know the interface showed that there was already one confirmation and that a second one is required to execute the transaction. But it did not perform the execute when approving (even so the checkmark was set).

This is not fixed. Here is my safe on rinkeby where I got this issue: 0x4d83B3728850FDaEFe65360ae1B99665186a5866
Steps I did:

Created 1-oo-1 safe
Sent 0.01 ETH to the safe
Tried to send 0.01 ETH to my wallet back
TX got approved but not executed.

This was done using PR deployment there: https://github.com/gnosis/safe-react/pull/456
I assume it should be applicable for all current ENVs, since the approve/execute logic was not touched in this PR

@francovenica @fernandomg

Ok, I just tested it locally, on developlment branch, and it's working fine.
Not only for the first tx in a safe but for any and for any type (I mean, cancel or execution).
That condition for the threshold === 1 is only for those safes that have a threshold of one and don't need a flag like approveAndExecute (https://github.com/gnosis/safe-react/blob/2a8ec9d4db39edd055c36e3e51dcd5e315203ae7/src/routes/safe/store/actions/processTransaction.js#L48)

NOTE: Also, tested on #456 PR deployment, and got the same error that @mikheevm.
When I say locally I mean, yarn start. I'm not building the dapp

@mikheevm I've seen this issue in the 601 earlier this morning, but in the 576 is working fine.
As a note, in a safe with 1 owner it works fine, is when you have 2 or more owners that the execution won't go through

@mikheevm I've seen this issue in the 601 earlier this morning, but in the 576 is working fine.
As a note, in a safe with 1 owner it works fine, is when you have 2 or more owners that the execution won't go through

I don't get it, I have tested with more than two owners, with a threshold of 2 and it executed immediately. See the gif

@fernandomg

I don't get it, I have tested with more than two owners, with a threshold of 2 and it executed immediately. See the gif

I was talking about the 601. Safes with 1 owner execute the Tx, safes with 2 or more won't

with a threshold of 2 and it executed immediately.

how come that it would execute transaction immediately for safe with threshold 2?

with a threshold of 2 and it executed immediately.

how come that it would execute transaction immediately for safe with threshold 2?

I meant, with the 2nd approve (with the execute checkbox)

Well, I just re-tested both scenarios in the PR #624 build:

with 1 user/1 threshold: https://pr624--safereact.review.gnosisdev.com/app/safes/0x01b5e2F684A1a1c007B62878e19cbe3B9Df3CA6B/transactions

with 2 users/2 threshold: https://pr624--safereact.review.gnosisdev.com/app/safes/0x1A8FdCAb4741D533f461416844E5b3b7114AA464/transactions

and both worked as expected.
@rmeissner, @mikheevm, @francovenica

@fernandomg @rmeissner shall we close this one then?

Maybe @francovenica can do a final check? It worked well for me, as I said in the last message.

This is not fixed just experienced this issue multiple times on mainnet. First transaction ich trigger is ok, but if I stay in the transactions tab and a new transaction to confirm appears it doesn't work. I have to switch to the balance or settings tab to reload the transactions and then it works

Ok, finally found the root of the problem. Reproducing what Richard said.
Same safe open in two different browsers.

Open safe in two browsers (A and B)
Browser A: Create a tx + execute it.
Browser A: Create a tx
Browser B: Confirm (no execution checkbox as the Safe's nonce in the store wasn't updated)


No v0.8.0 Helm chart

It seems the v0.8.0 container image was published, but not the accompanying Helm chart version. This is important because RBAC has changed and is missing from v0.7.1 of the Helm chart.
❯ helm repo add jetstack https://charts.jetstack.io --force-update
"jetstack" has been added to your repositories

❯ helm search repo cert-manager-google-cas-issuer
NAME                                   	CHART VERSION	APP VERSION	DESCRIPTION
jetstack/cert-manager-google-cas-issuer	v0.7.1       	v0.7.1     	A Helm chart for jetstack/google-cas-issuer

Sorry @mgoodness will get this fixed ASAP.

@mgoodness the Helm chart should be available now.

@mgoodness the Helm chart should be available now.

Thank you!!


Adding support to run ACA unit test inside build container

Adding support to run ACA unit tests inside build container without the need for host OVS kernel support

Eric, please have this one assigned to me as well


Hash array lengths

This will include a hash of the array length of arrays being hashed. This is to prevent equivalent hash values for records with adjacent arrays creating unwanted hash collisions. See issue #1331 in Agora.

All 🟢

Rebased.

Still 🟢

🟢


Cannot set "for" attribute from labelProps

Passing "htmlFor" in labelProps to any input component does not work, the attribute "for" on the label is not set on the effective output lable

@Giuseppe7887 use the example below to add the for attribute for the label element on the input component
<Input
  label="Username"
  labelProps={{
    htmlFor: "Username",
  }}
/>

it doesn't work on Textarea


[ISV-1820] Update publish-bundle to return list of references and manifest digests

The references and manifest digests returned from IIB results are
required for signing on the release pipeline.

I've tested this to the extend that I can, but IIB wasn't actually run because it doesn't run on dev/qa and it's broken in stage right now.


Can't find variable: Reflect, using karma and React

I can't use es6ify as a browserify transform in karma, because every time I var React = require('react') I get the following error:

PhantomJS 1.9.8 (Linux) ERROR
ReferenceError: Can't find variable: Reflect
at /tmp/1645300b04d0678d0d53075229712f4fbfb3fed6.browserify:2265:0 <- /vagrant
/node_modules/react/lib/React.js:185:0

Upon inspection, React.js, line 185 is the final newline of the file, after the module.exports = React. In fact, I can't find Reflect anywhere in React.js.
Has anybody successfully paired es6ify with karma and React?

I ran into a similar issue running reactify and es6ify on chrome. Somethig about using this.state inside a function that I write using the fat arrow syntax just causes my code to shit the bed and throw up the Reflect is undefined error.
for instance,

var React = require('react');

var Pixel = React.createClass({

  getInitialState: function() {
    return {
      red:  this.props.red || 0,
      green: this.props.green || 0,
      blue:  this.props.blue || 0,
      alpha:  this.props.alpha || 1,
      size: this.props.size || 5
    };
  },

  computeColor: function() {
    return 'rgba(' + [ this.state.red, this.state.green, this.state.blue, this.state.alpha ].join(', ') + ')';
  },

  render: function() {
    var colorVal = this.computeColor();
    console.log(((x) => {return "hello"})())

    //var colorVal =  'rgba(255, 0, 0, 1)';
    console.log(colorVal, this.state)
    var divstyle = {
      backgroundColor: colorVal,
      width: '' + this.state.size + 'px',
      height: '' + this.state.size + 'px'
    }
    return

  }

});

module.exports = Pixel;

works, but replace the function() { ... } with () => { ... }

var React = require('react');

var Pixel = React.createClass({

  getInitialState: () => {
    return {
      red:  this.props.red || 0,
      green: this.props.green || 0,
      blue:  this.props.blue || 0,
      alpha:  this.props.alpha || 1,
      size: this.props.size || 5
    };
  },

  computeColor: () => {
    return 'rgba(' + [ this.state.red, this.state.green, this.state.blue, this.state.alpha ].join(', ') + ')';
  },

  render: () => {
    var colorVal = this.computeColor();
    console.log(((x) => {return "hello"})())

    //var colorVal =  'rgba(255, 0, 0, 1)';
    console.log(colorVal, this.state)
    var divstyle = {
      backgroundColor: colorVal,
      width: '' + this.state.size + 'px',
      height: '' + this.state.size + 'px'
    }
    return

  }

});

module.exports = Pixel;

and I get that very same error!

Not sure this has anything to do with your problem, but I had the same problem ReferenceError: Can't find variable: Reflect when using browserify + es6ify + karma.
It now works after changing (the deprecated) karma-plugin "karma-bro" to "karma-browserify".

Getting this using typescript+react+browserify+es6ify, without karma-bro or karma-browserify. Was there aver ever a resolution to the problem?


Cannot find module '@stryker-mutator/api/core' or its corresponding type declarations with v7

Summary
The config setup as described in https://stryker-mutator.io/docs/stryker-js/config-file/#setup for e.g. stryker.conf.js doesn't work anymore.
It worked fine with v6.
Stryker config

/** @type {import('@stryker-mutator/api/core').PartialStrykerOptions} */
const config = {}

Stryker environment

"@stryker-mutator/api": "^7.0.1",
"@stryker-mutator/core": "^7.0.1",
"@stryker-mutator/jest-runner": "^7.0.1",
"@stryker-mutator/typescript-checker": "^7.0.1"

Probably an issue with the new exports definition in package.json. Should be an easy fix.


Add support for xz-compressed WireGuard kernel module

which is the default since Linux 5.15.
Solves: #1548 #1549

Optional: We use the following check to check for a kernel module provided by the kernel package, and additionally support "really" builtin WireGuard modules:
dpkg-query -S '/lib/modules/*/wireguard.ko*' &> /dev/null || modinfo wireguard 2> /dev/null | grep -q '^filename:[[:blank:]]*(builtin)$'

It performs better than the recursive globbing/globstar, as far as I tested.

well its fine by me, care to open another PR or want me to just update that line and push it?

I just opened a PR: #1551


Need to merge Multiple cards (front end branch) with editable cards (Editable-cards branch)

title says it all

Fixed in editing-cards and merged


TODO

To Do
Completed

[x] Migrate to Java

[x] #226

[x] Find a new way to get the verse from the html, current solution doesn't even work 😭🤦♂ -> Jonathan

[x] Make endpoint to get all verses in a single chapter #99

[x] Fix tests

[x] Create React app for the front end... -> Jonathan

[x] Create route for getting the verse, and exporting previously made function into its own module in a controllers folder -> Jonathan

[x] Create route generator -> Jude

[x] #15

[x] Test other http request packages -> Jonathan/Jude

[x] Frontend from TS -> JS

Closing this due to inactivity


Streamlabs IOS app cannot connect RTMP

Which version are you using?
v1.0.3
Which operating system are you using?

[X] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Using the IOS StreamLabs app to send RTMP to the server, the connection will never connect. It initiates, hangs and times out.
The behavior is similar to this resolved issue with the StreamLabs Android app. https://github.com/bluenviron/mediamtx/issues/1244. I have confirmed the current Android app connects fine, the issue is only with the IOS app.
Describe how to replicate the issue

Download StreamLabs app for Iphone
Create Custom RTMP stream to MediaMTX
Observe stream never connects

Did you attach the server logs?
yes
2023/09/15 14:12:10 INF [RTMP] [conn <IP_ADDRESS>:65316] opened
2023/09/15 14:12:11 DEB [path asdf] created
2023/09/15 14:12:20 DEB [path asdf] destroyed (not in use)
2023/09/15 14:12:20 INF [RTMP] [conn <IP_ADDRESS>:65316] closed (read tcp <IP_ADDRESS>:1936-><IP_ADDRESS>:65316: i/o timeout)

Did you attach a network dump?
no

Hello, first of all, the RTMP implementation was recently improved, please try the nightly release attached in this thread, it may fix this issue:
https://github.com/bluenviron/mediamtx/issues/2289#issuecomment-1705702518
If it doesn't work, attach a network dump.

Hello, first of all, the RTMP implementation was recently improved, please try the nightly release attached in this thread, it may fix this issue: #2289 (comment)
If it doesn't work, attach a network dump.

The nightly build did fix camera streaming with the StreamLabs app, so that's positive. The screen sharing feature of StreamLabs still did not work however. I've attached a pcap of the screen-sharing connection attempt.
streamlabs.zip

Thanks for reporting the screen sharing issue, this is fixed by #2611


open(..., 'w') ... flush() fails to write data to the file

Repro:
with open('test.txt', 'w') as test:
  test.write('hi')
  test.flush()
  r = open('test.txt', 'r')
  print(r.read(1))
  r.close()

Expected: 'h' printed
Actual: '' printed
This seems to be a regression from IronPython 2.
Side note: what surprises me is that in both 3 and 2 BufferedWriter.flush() does not call .flush() on the underlying _raw/_rawIO, but somehow it works in IronPython 2. I'd appreciate an explanation. Does IP2 create the underlying stream with buffering off?

IP3 is not ready for prime time at all, please do not use it.

@slide , no worries, I am not "using" it in a conventional sense :)

Ok, that's good :)

open with ipy3 is actually the io.open of ipy2. If you use io.open in ipy2 does the same issue occur?

@slozier looks like it does.

It looks like the issue here is that io.FileIO should be writing directly to disk and not buffering. If you look at the flush method on the CPython io.FileIO it's actually the flush method of _IOBase (so basically a noop). I think the solution would be to open the FileStream with FileOptions.WriteThrough.

Hm, would not it be better to fix flush?

That would be an incompatibility with CPython. For example:
import io
b = io.BytesIO()
f = io.BufferedWriter(io.BufferedWriter(b))
f.write(b"a")
f.flush()
assert bytes(b) == b""

@slozier I am not sure what do you mean here. BufferedWriter should be calling the underlying IO object's flush, so if flush is fixed to behave correctly, this would pass.

My example is a counter-example to the statement that BufferedWriter should call the underlying IO object's flush. If it did call flush, then the sample above would fail. You can manually flush the raw and see the difference:
import io
b = io.BytesIO()
f = io.BufferedWriter(io.BufferedWriter(b))
f.write(b"a")
f.flush()
assert b.getvalue() == b""
f.raw.flush()
assert b.getvalue() == b"a"


Synchronization

fixes #76
Adds a subscription method for data API. This shall be used by synchronizers for copying the data from source HDS to the corresponding copies
Problem messages for HTTP requests

Note that changing error response schema is a breaking change. At least need to check the Grafana plugin.
Also, the OpenAPI specs should be updated. I suggest defining schema of HTTP Problems in a separate file (maybe someone has already done so) and referencing it: https://swagger.io/docs/specification/using-ref/


Ignore sample_data created by tests

Description
What was changed in this pull request?

gitignore test/sample_data

Why is it necessary?

Tests create this and clean it up, but if I hit ctrl-c, it is left in place. We wouldn't want junk to be committed.

Checklist

[ ] Unit tests added or updated
[ ] Updated CHANGELOG.md

Never mind... sample data definitely belongs, and the changes I saw may be an issue, but there isn't a blanket solution.


Create pipeline skeleton on pipeline config

If a user runs pipeline config and there is no pipeline definition available, it'd be nice if we could at least pop the standard one we add to the todo templates into their project (with consent).
on:
  workflow_dispatch:
  push:
    # Run when commits are pushed to mainline branch (main or master)
    # Set this to the mainline branch you are using
    branches:
      - main
      - master

# GitHub Actions workflow to deploy to Azure using azd
# To configure required secrets for connecting to Azure, simply run `azd pipeline config`

# Set up permissions for deploying with secretless Azure federated credentials
# https://learn.microsoft.com/en-us/azure/developer/github/connect-from-azure?tabs=azure-portal%2Clinux#set-up-azure-login-with-openid-connect-authentication
permissions:
  id-token: write
  contents: read

jobs:
  build:
    runs-on: ubuntu-latest
    env:
      AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
      AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
      AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
      AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Install azd
        uses<EMAIL_ADDRESS>
      - name: Log in with Azure (Federated Credentials)
        if: ${{ env.AZURE_CLIENT_ID != '' }}
        run: |
          azd auth login `
            --client-id "$Env:AZURE_CLIENT_ID" `
            --federated-credential-provider "github" `
            --tenant-id "$Env:AZURE_TENANT_ID"
        shell: pwsh

      - name: Log in with Azure (Client Credentials)
        if: ${{ env.AZURE_CREDENTIALS != '' }}
        run: |
          $info = $Env:AZURE_CREDENTIALS | ConvertFrom-Json -AsHashtable;
          Write-Host "::add-mask::$($info.clientSecret)"

          azd auth login `
            --client-id "$($info.clientId)" `
            --client-secret "$($info.clientSecret)" `
            --tenant-id "$($info.tenantId)"
        shell: pwsh
        env:
          AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}

      - name: Provision Infrastructure
        run: azd provision --no-prompt
        env:
          AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
          AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
          AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}

      - name: Deploy Application
        run: azd deploy --no-prompt
        env:
          AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
          AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
          AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
          ```

I saw some Demos in the past (during build ) about folks using azd init -t foo/bar to pull/re-use code as components.
Can we use that here?
We would create some git-repos containing the pipeline definition in different flavors (one repo per configuration)
Then folks can run azd init -t repo/flavor  and get the pipeline definition they want.
Then azd pipeline config can internally call azd init -t repo/default-azdo/github to pull a default generic stuff.
I would even propose having an azd import and azd export as festures for purely pulling and pushing git-repo-code

Dupe of #2343?

Moving this to Dilithium given its P3 for Aspire 8.0 - Azd's Scope and Work Items
@bradygaster @ellismg @davidfowl


Determine message origin

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (ea819b6) to head (9484632).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #13      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%
===========================================
  Files           84       84
  Lines         2316     2386      +70
===========================================
+ Hits          2316     2385      +69
- Misses           0        1       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Do not bind "[index]" in CollectionModelBinder subsetting feature

#7091
add IKeyRewriterValueProvider to remove rewritten keys or value providers containing such keys

similar to IBindingSourceValueProvider except CompositeValueProvider keeps non-implementers around

nits:

remove Linq use in CompositeValueProvider
do not create an unnecessary dictionary in CompositeValueProvider.Filter(...) methods

Value providers are like collections, and null collections are usually asking for trouble.

Agreed though it's now enshrined. How about I file an issue for a future release about cleaning up this behaviour?
Without changing the API, it'll be difficult for CompositeValueProvider and the rest to behave consistently. One option might be a TryFilter(...) pattern that sets the out parameter to a static CompositeValueProvider when returning false.

@pranavkm or @kichalla please have a look at this. @rynowak asked (offline) for a second opinion.

:up::date: including rebase on release/2.1 and new commit to address comments

390ebbb258


read_csv with Ray engine with 'lineterminator' parameter outputs incorrect result

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Modin version : ce2bea8867739ea792cdda0dce8ad50e366ebae1
Python version: 3.8.6
Code we can use to reproduce:

import os

os.environ["MODIN_ENGINE"] = "ray"

import pandas
import modin.pandas as pd
from modin.pandas.test.utils import df_equals

test_filename = "test.csv"
kwargs = {
    "filepath_or_buffer": test_filename,
    "lineterminator": "x",
}
str_two_cols = "col1,col2x1,2x3,4x"

try:
    with open(test_filename, "w") as f:
        f.write(str_two_cols)

    df_pandas = pandas.read_csv(**kwargs)
    print("pandas.read_csv output:\n", df_pandas)
    df_pd = pd.read_csv(**kwargs)
    print("pd.read_csv output:\n", df_pd)
    df_equals(df_pandas, df_pd)
finally:
    os.remove(test_filename)

Describe the problem

Source code / logs

pandas.read_csv output:
    col1  col2
0     1     2
1     3     4
pd.read_csv output:
 Empty DataFrame
Columns: [col1, col2]
Index: []
Traceback (most recent call last):
  File "test.py", line 125, in <module>
    df_equals(df_pandas, df_pd)
  File "/modin/pandas/test/utils.py", line 511, in df_equals
    assert False, "One of the passed frames is empty, when other isn't"
AssertionError: One of the passed frames is empty, when other isn't

I am still able to reproduce this bug on the latest master.

Do I see it right that it was fixed by removing support for lineterminator and defaulting to pandas?

Do I see it right that it was fixed by removing support for lineterminator and defaulting to pandas?

Hi @brunovh , unfortunately yes. Do you need an optimized version for lineterminator?

Hi @anmyachev I had been using this in 0.18.0 and was hoping to benefit from bug fixes with update to newest version. Would be great to see this coming back in future updates

lineterminator

Thanks for the feedback

@brunovh I suppose it's easy to add support for standard cases like: "\n", "\r", "\r\n", but difficult for more specific ones. Will partial support for standard parameters help you?

@anmyachev Partial support for standard parameters would be very helpful!


Develop - Fixed travis CI

This "should" fix Travis CI, and build using cache.

I forget to create a separate branch when I created this pull request. I hope this don't create any merging/pull problems later on.

Please don't delete stevenhwu:develop lol


Docker container options conflict

The winery docker image can't be used with volumes and WINERY_REPOSITORY_URL at the same time.
I used the latest https://github.com/OpenTOSCA/opentosca-docker master branch and added the following to the override file:
 winery:
    environment:
      WINERY_REPOSITORY_URL: https://github.com/OpenTOSCA/tosca-definitions-public.git
    volumes:
      - /var/opentosca/winery/repository:/var/opentosca/repository

This should enable the tosca-definitions-public repository and store it on the host path /var/opentosca/winery/repository so it can be modified.
But winery (docker CMD) fails: rm: cannot remove '/var/opentosca/repository': Device or resource busy, because it tries to delete the mounted directory.
Solutions:

don't allow both options at the same time and print a hint if someone tries to use both
don't try to delete the mounted directory, only delete the content in the directory

Works with the latest master.


Some basic API examples for Curl or Postman

Hi,
Trying to use the API to update a slide is bringing some issues.
The API docs are not that clear and missing a few basic examples.
For example I guess I need to sign in first (get a cookie) with a HTTP POST:
curl -X POST -Hame":"display", "password":"display", "who":"displayuser", "permanent":"TRUE"}' http://localhost/api/endpoint/auth/auth_login.php
This nicely gives a, what I suppose, succesful login:
  "user": {
    "user": "display",
    "groups": [
      "display"
    ],
    "sessions": [
      {
        "id": "display_1563821460",
        "who": "displayuser",
        "from": "<IP_ADDRESS>",
        "created":<PHONE_NUMBER>,
        "max_age": 600,
        "permanent": true
      },
      {
        "id": "display_1563821488",
        "who": "displayuser",
        "from": "<IP_ADDRESS>",
        "created":<PHONE_NUMBER>,
        "max_age": 600,
        "permanent": true
      }
    ],
    "quota": {
      "limits": {
        "slides": {
          "limit": 10,
          "description": "Slides"
        },
        "api_rate": {
          "limit": 200,
          "description": "API quota (calls/60s)"
        }
      },
      "used": {
        "slides": 0,
        "api_rate": 2
      }
    }
  },
  "session": {
    "id": "display_1563821488",
    "who": "displayuser",
    "from": "<IP_ADDRESS>",
    "created":<PHONE_NUMBER>,
    "max_age": 600,
    "permanent": true,
    "token": "9f359b791dda36ecd9e7e0c7200d0e"
  },
  "error": 0
}

But how to move from here?
I have been trying to do a get

http://localhost/api/endpoint/slide/slide_list.php

To find the correct slide ID and then do a slide_get.php and a slide_save.php.
Could someone point me a bit more in the right direction?
Thanks,
Maarten

Okay, so you have the login part figured out already. That's a successful login.
To use endpoints that require authentication, you need to pass the session token from response.session.token in the Auth-Token header. Here response is the response JSON object you got from auth_login.php.
In general, when a call to an endpoint is successful, theerror field in the response is 0 and some data might be returned. Not all endpoints return data though. In the current version of LibreSignage, the error value is guaranteed to exist. In upcoming versions there's some changes to how API errors are indicated but this is all you need to know for now.
When trying out the API, I recommend you to build LibreSignage with debugging enabled. Debugging enables verbose error messages through the API to give a hint about what might have gone wrong. There can sometimes be errors due to things you might not expect like values being out of the accepted range etc.
You can call slides_list.php to get an array of all slide IDs in all queues. You just need to do a GET to api/endpoint/slide/slides_list.php.
You can then POST to slide_get.php. You must pass the ID of the slide you want to fetch in the request body as JSON like so: {"id": "ID HERE"}. This should then return the slide data for the requested slide.
slide_save.php is a bit more complicated. First of all, you can only call it if you're logged in with a user who's in the editor or admin groups. Also, if you want to modify an existing slide, you either need to be the owner of that slide or a collaborator. This means that you can't edit slides with the display user.
So, once you're logged in with a proper user, you can call the slide_save.php endpoint. You can pass all the slide data parameters you got from slide_get.php back into this one, although some of them are not actually used. Check out the documentation for slide_get.php in the web interface docs. There's some more info on what parameters you can/must pass to the endpoint. If everything goes as expected, the data is saved on the server and an error code set to 0 is returned along with all the saved data.

Excellent!
This clears my questions, thanks!
Maarten


Add option to export data to an open file format like .gpx

The internal data format of Fog of World is like a black-white picture indicating where you've been and there is no time ordering between the pixels.
Considering GPX is a format for storing waypoints (with ordering), it is a fundamentally different format from FoW's.
In short, you may consider FoW as a bitmap image, while GPX is a vector image. Therefore GPX to FoW will only be a one-way transform.
If you still prefer GPX, I'd recommend using other tools (without FoW support).
If you have any other suggestions, please reopen the ticket.

I feel like if the use case is getting gpx data out of existing fow data, that's still something worth considering (again one shouldn't use fog of world to record gpx data in the first place).
It's possible to guess and reconsturct a close enough vector graph from a bitmap image.