The feature have issue --- Longhorn Pod Deletion Policy When Node is Down

I created a k8s cluster(30 nodes) on openstack, and then install longhorn on it.
I had tested the feature "Longhorn Pod Deletion Policy When Node is Down" in Longhorn helm chart v1.6.0 / v1.6.1
I used the example for testing "kubectl create -f https://raw.githubusercontent.com/longhorn/longhorn/master/examples/statefulset.yaml",
NodeDownPodDeletionPolicy is set to do-nothing
#kubectl -n longhorn-system get setting node-down-pod-deletion-policy
NAME                                                 VALUE            AGE
node-down-pod-deletion-policy     do-nothing    17d

I powered off a node, it will create a new pod on another nodes.
The result is different from  document, please help to check.
[root@haiouc longhorn]# k get pod -o wide | grep web
web-0      1/1     Running     0   3m26s   <IP_ADDRESS>   k8s-med-worker-6    <none>           <none>
web-1      1/1     Running     0   3m13s   <IP_ADDRESS>    k8s-med-worker-2    <none>           <none>

[root@haiouc longhorn]# k get pod -o wide | grep web
web-0      1/1     Running       0     19m     <IP_ADDRESS>   k8s-med-worker-6    <none>           <none>
web-1      1/1     Running       0     7m47s   <IP_ADDRESS>     k8s-med-worker-3    <none>           <none>

#document
if NodeDownPodDeletionPolicy is set to do-nothing | delete-deployment-pod
#wait till the pod.deletionTimestamp has passed
#verify no replacement pod generated, the pod is stuck at terminating forever.

@mantissahz  Which one to close, 8275? (close as not planned )

I prefer to close this one and update the status on #8275
duplicated.


Add GUI

I'm request adding gui appearance of this awesome app.
I'm suggest you to do:

Separated branch called dev for pushing development commits (holding release commits in master branch only)
Add the label "Enchancement" to this issue via github interface
After you finish working for next release in dev branch, you can create PR to master and merge it (via github interface)

contact me if you have questions.
Happy hacking!

Thanks for your ideas, a gui was added in the last commit, but I forgot to use PR. Also was added new branch dev


Dark background on Inputfield MultiLine Content Config

Hi,
Thnks for the great pluging.
Im testing on iOS an multiple entry on inputfield. but when get the focus on inputfield, the background turns "dark" color (black). But  when unfocus the field, the background turns previous color. (white)
On the NativeEditBox config, the checkbox "Switch Between Native and Unity " is actived
This issues not happens on Single Line config.

thanks.

That is odd, the native text view has a transparent background..
And the unity text field isnt set up with a white background ?

That is odd, the native text view has a transparent background.. And the unity text field isnt set up with a white background ?

yes.. is really weird..
I tested on "none" background (solid color white) and with different sprites. The result still the same.

Basically, you can reproduce it creating a new project and only adding the Native plugin to Inputfield and setting the Multi Line Type.
My version is: Unity 2020.2.2f1 (also tested on 2021.2.7f1) iOS

After check NativeEditBox.mm, i added the property
[text setBackgroundColor:UIColor.whiteColor];
to avoid the black background.

Hi! Thanks for looking in to this ⭐
Could you try with using clear color ? And if that works a pull request would be lovely :)
Thanks!


[zh]: update concept workload pods

Update zh translations of concept workload pods to latest version.
 content/zh/docs/concepts/workloads/pods/_index.md                          |  65 +++++++++++++++------
 content/zh/docs/concepts/workloads/pods/disruptions.md                     |   8 +--
 content/zh/docs/concepts/workloads/pods/ephemeral-containers.md            | 163 +++-------------------------------------------------
 content/zh/docs/concepts/workloads/pods/init-containers.md                 |  30 ++++++----
 content/zh/docs/concepts/workloads/pods/pod-lifecycle.md                   |  30 +++++++---
 content/zh/docs/concepts/workloads/pods/pod-topology-spread-constraints.md | 122 +++++++++++++++++++++------------------
 6 files changed, 170 insertions(+), 248 deletions(-)

doc: https://kubernetes.io/zh/docs/concepts/workloads/pods/
ref: https://github.com/kubernetes/website/issues/29325

Thank you for contribution！
/lgtm


Comment mysteriousely disappearing

Expected Behavior
Comments in 2.0 should be there in 3.0
Actual Behavior
Sometimes they aren't

(Some comments are tho!)
Steps to Reproduce
Can't reproduce. I tried creating comments, moving them to other blocks with and without deleting the original block, moving them to the scripts area and attaching it to a block again. Comments are always still there.
Found in
212388708
Operating System and Browser
MacOS, Chrome

In that particular project, it looks like the comment in question is getting imported, but it's getting added to the wrong block (it's on a block in the middle of a custom procedure definition stack) on the same sprite:
Scroll far off to the workspace of the UserScripts sprite and you will see:

The comment on that if then else block should be on the set MapsTotal block in the screenshots in the issue description above.
-- Needs more investigation to figure out what's actually going on here.


Sensics home russ merge

Thanks for the careful review.  I think I handled all of the requests above.


Add vulkan support

Flutter embedder has supported vulkan graphics.

Is there any plan for vulkan support?

Sorry for no updates, but I'm going to add impeller support first as it will improve graphics performance significantly.


Can't set the name of a new Azure Function App in VS Code Extension

I was also experiencing this last night. It seemed to work for me today, though 😬

Looks similar to https://github.com/Microsoft/vscode-cosmosdb/issues/494. We're trying to validate the account name through Azure (to see if it's globally available) and it's probably just taking a really long time. We can add a timeout like we did in the Cosmos extension


Error during the install.sh script

Hi, I'm trying to execute the install.sh script but I'm struggeling with the error
Unable to init server: Could not connect: Connection refused
# Failed to parse arguments: Cannot open display:

And none of the containers are running after the script.
I'm pretty sure that the error is caused by the gnome-terminal command but I can't find a way to fix this.
Am I missing something in the set up?
Thanks in advance!

Perhaps error is caused by running install script without GUI (X11 environment). Gnome-terminal commands launch docker (and docker-compose) for broker. Quick workaround for that is to remove gnome-terminal wrapper from docker calls and run docker and docker-compose in detached mode with -d switch.

Thanks that works for me!

Gnome-terminal is no longer used in the install script. Please, refer to PR 41


Snippets  to FormTypes with full class names  Sf 2.8+

I use  sffuse...typing an extra f ( of form)  to keep short sfuse completion list shot  and clean.
Right now there are ~32  symfony form types  and  its better see them only after type sffuse

Merged! Thanks for the contribution, @cerobit!

Thanks to you for your awesome work..@voronkovich, about namespaces   i'm using  vim-php-namespace  and  vim-gutentags  but  vim-guttentags its not parsing vendor/  ....   so vim-php-namespace wont complete vendor classes.
Talking about awesome plugins, i'm really pleased with https://github.com/phpvim/phpcd.vim  its amazing blazing fast php code completion (using Php reflection Mechanism).

@cerobit, for updating tags it's better to use tools that listen file system events like Guard. I use this: https://github.com/everzet/guard-ctags-composer and https://github.com/universal-ctags/ctags


[RFE] Add Unit Tests to the auth Package

Is your feature request related to a problem? Please describe.
Currently the auth package has several small files that do not have comprehensive unit tests. This leaves the code vulnerable to regressions and hard to modify.
Describe the solution you'd like
Add unit test coverage to the following files:

https://github.com/rancher/rancher/blob/release/v2.9/pkg/controllers/management/auth/setting.go
https://github.com/rancher/rancher/blob/release/v2.9/pkg/controllers/management/auth/legacy_rt_cleaner.go
https://github.com/rancher/rancher/blob/release/v2.9/pkg/controllers/management/auth/legacy_grb_cleaner.go
https://github.com/rancher/rancher/blob/release/v2.9/pkg/controllers/management/auth/indexes.go

At assignee's discretion:

Adding comments to any functions that are currently undocumented or under-documented.
Minor refactors to make code more testable.

If any bugs are found, or the assignee believes major refactoring is necessary, create a new GitHub issue to track the work. This issue is not for potential functionality changes.
Additional context
This is a bit of a catchall for any gaps in the unit test coverage of the auth package. Any added coverage to files not specifically mentioned in this issue would be appreciated.

QA none. @samjustus - is this still blocked? I think the merged PR adds the needed tests. Can we close?


feat(protocol): Batch Reader

Description
Introduces the batch reader type.
Fixes broken batch decoding.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#234 👈
main

This comment was automatically generated by st.

Will come back to this once more batch type cleaning is done

Closing this for now - batch reading will strictly be used in the derivation pipeline so it shouldn't need to be used in other op stack components.


Add specs to cover grammar

Don't have anything at the moment, too easily broken.

on going but now present in 0.1.4, shall raise new issues as they arise.


Cards stay in deck after removing their chapter/exp from Sets

If you add a card from a certain pack/exp to your deck, and then unselect that pack/exp from the "Sets" option, the cards remain in the deck. That means that you are unable to get rid of them until you reselect that pack/exp specifically to set the number of copies to zero.

That's on purpose. And you can remove them: just click on the card and select 0 in the dialog header.


vertex color node visualizer disconnect when assign texture

Current Behavior
Clean Standard material without textures

When texture assign to base color dissconnect Vertec Base Color Multiply node

Automatically adds Col vertex color but if select any color in Vertex Paint you can't see it in EEVEE

This opion is checked

And

if this option is changed despite forcing connect node with vertex color if texture is added will disconnect node and back to previous pic2 from pic1
Expected Behavior
as in the first picture in Current Behavior
Vertex color connect to BaseColor PrinciplesBSDF to visualize

And a small request if it is possible to automatically add "Face Corner Color" instead of "Face Corner Byte Color". This change eliminates rainbow object bug if more than 1 material is assigned to an object.
Tested on multiple sceneries and works fine

Steps To Reproduce

Add plane object
Assign Standard MSFS Material
Assign BAse Color texture
Go to Vertex Paint
Add any color
Enable Viewport Shading. | you will not see vertex color
connect the Vertex Color Mul node back up to Base color in the shading tab | Texture object changes color with vertex color

Environment
- OS: Windows 10
- Blender: 3.6.9 LTS
- glTF-Blender-IO-MSFS: 3.6-Update | 08.04.2024 | f283a95 - Synch to ASOBO 1.3.3 and add my changes

Anything else?
If the object does not have any textures again add a button to assign vertex color attribute.
it was in some older versions of this add-on

If you can could you test this update?
io_scene_gltf2_msfs_for36.zip

Newer update - Please test
added base color - button to apply vertex color
<IP_ADDRESS>
io_scene_gltf2_msfs_for36.zip

If you can could you test this update?

is slightly bugged at the moment because if i doesn't manually assign vertex color himself before select standard material in addon
Then it does not plug in vertex color multiply node at all either without texture or with texture.
and it does not add col vertex color attribute in both cases
But if I go into preferences uncheck and check again this option

node works correctly and also adds vertex color after assigning a texture
then even after restarting blender and reopen project it works
but if even without reopen blender but open / create new Blend File. New, General project again does not work
so I think it's strongly related to the newly added button in preferences and for some reason it doesn't load it correctly until you uncheck it and select it and save the state in the blend file

Newer update - Please test
added base color - button to apply vertex color bug fixes
<IP_ADDRESS>
io_scene_gltf2_msfs_for36.zip

same problem everything works if you uncheck and select the button and save the blend file. for some reason when you open a clean project it doesn't automatically take into account that the checkbox is selected

If I saved the startup project after this action the same works correctly

ah ok, thanks for reporting.

works. thank you for the quick fix
one more small note by default metallic is on 1 instead of 0 with models without pbr it theoretically matters but you can change it manually

Default metallic for what material - Standard only?

Default metallic for what material - Standard only? Not sure I understand. "without PBR" they are all PBR materials

Not very significant because if the material has textures then this slider does not affect anything and should be on 1
but if the material of any kind, such as standard under the LOD of the model without textures then 1 for metallic means metal and so it displays in msfs and blender viewport so theoretically for 99% of cases it should default to 0 and only after adding a texture set to 1

Ok I understand now.  However,  I will not be able to do that because I would like to keep the exporter as close as possible to ASOBO, I don't like it, where code changes an unrelated value, if you change a texture the metallic factor changes.
You could modify your own version to set the default metallic_factor to 0.0

should be fixed


Don't mention runtests.py in documentation.

Since the ./runtests.py incantation to run tests only works in the source tree but not from an installed Numba, this patch promotes python -m numba.testing instead, which otherwise is exactly identical.

This looks good to me.


Adds Engine Version to Tailwind Starter Repo

Resolves #299
Deploying the Tailwind Starter repo on Vercel fails when using node version 18.x. This will override the Vercel projects node version setting to use 16.x, fixing the build failures.

can you add this to every starter?

@nandorojo sure just added!


minor: update versions and paths in changelog scripts

Which issue does this PR close?

N/A
Rationale for this change

Prep work for 8.0.0 release
What changes are included in this PR?

Update version numbers in changelog scripts
Update README to add all crates and instructions for publishing crates in the correct order
Added dependency diagram:

Are there any user-facing changes?

No

Thanks @andygrove


Support writer customization using --storage-config-file

The MCAP plugin should support customizing MCAP writer options using the --storage-config-file argument, which allows input of an arbitrary file that is passed to the storage implementation, for ros2 bag play and ros2 bag record
In code this can be accessed via StorageOptions::storage_config_uri.
Example from SQLite plugin which parses the file as YAML:
https://github.com/ros2/rosbag2/blob/e385df81408090609ee628a54d315b8e898f3215/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp#L75

Also worth considering whether we should add a more structured way for rosbag2 plugins to implement options? Can't do this for Humble, but we could change it in Rolling.

Just rewrote the title/description to match current state of things more accurately.
Allowing plugins to register commandline arguments could be a cool feature, but I don't have a strong sense of how it would look in practice. I have repurposed https://github.com/ros2/rosbag2/issues/276 for this enhancement, but it's more questions than statements at the moment.

The initial description wasn't intended to be custom handling of command line arguments per se. I just saw that there was already a --output-options flag (https://github.com/ros2/rosbag2#converting-bags) and it seemed like the appropriate place to put mcap options. But I guess --storage-config-file also sounds relevant. 👍


fix delete parsing for memcache

I think we should support memcache delete argument. because memcached delete spec allow arguments.
See process_delete_command in https://github.com/memcached/memcached/blame/master/memcached.c
    if (ntokens > 3) {
        bool hold_is_zero = strcmp(tokens[KEY_TOKEN+1].value, "0") == 0;
        bool sets_noreply = set_noreply_maybe(c, tokens, ntokens);
        bool valid = (ntokens == 4 && (hold_is_zero || sets_noreply))
            || (ntokens == 5 && hold_is_zero && sets_noreply);
        if (!valid) {
            out_string(c, "CLIENT_ERROR bad command line format.   I just follow current memecached behavior. :)

Note: The usage in python-memcached was fixed in https://github.com/linsomniac/python-memcached/pull/27


Deprecate /v2/events heavy event format

Also, the deprecated features description was showing the wrong
text; fix this, also.

JIRA Issues: MARATHON-8259

I added a test. It's a bit cheesy, but it is a test :)


🎉 New Project: Ceramic Slate

Ceramic Slate
A Next.js journal app.
Field
Web Development
Difficulty
Intermediate
Creator
Kelvin Praises (kelvinpraises#5918)

LGTM @kelvinpraises! I'll merge this when your Workbook is also ready 😄. Good work!

Thanks! I'm done with the workbook 👍

Thanks @kelvinpraises! It's been merged :D


[Languages]How to Perform Countdown Timer in Python

Topic Suggestion
[Languages]How to Perform Countdown Timer in Python
Proposal Submission
Proposed article introduction
What should you do if you need to run a specific piece of code after a certain amount of time? Assume you need to update a file every 30 minutes. Will, you submit the same thing every time. Isn't that correct? This is where the Python Countdown Timer comes in, as it can be used to wait for a certain amount of time in the idle state before reiterating the same piece of code in the loop as needed.
Key takeaways
Importing the time library
creating an alias for the library
Examples of Python Countdown Timer
Article quality
The article is intended to be precise and clear to the point, illustrated by codes making it more practical and interesting, to increase time spent on the page.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

This is a very simple concept. It can't be a tutorial. Please feel free to suggest an alternate topic to explore. 🚀 @HEking2


Can't bring up menu for sidecar

Rancher versions: 2.0 master 4/11
Steps to Reproduce:

Create a workload
Add a sidecar
Hover over the sidecar circle

Results:  It only shows the menu for the pod, no menu for sidecar

@vincent99 I guess it is by design.

There's no detail page for the containers of the pod but we still need a way to be able to see logs/exec into them and such..

We need to change something in norman first. Please see the comment https://github.com/rancher/ui/pull/2073#discussion_r204128908

Backend still not in. Not sure if anyone is working on the backend stuff.

@alena1108 this seems like something in the API needs to be updated so that @loganhz can implement it.

In pod detail page, added exec and logs actions in each tab of the container.

Version - 2.1 master 9/4
Verified fixed


Find all downsides of using traits over components

Right now accessing trait property has been done using declared method, not property itself (trait properties as private for trait not for implementing class and this creates set of non elegant solutions due i can't hide them from the class).

Basically i need traits which provides "virtual getters" for some of their functionality.

See ideas as in translator trait

Seems ok after covering shared container with tests


UCLA Richard C. Rudolph East Asian Library (repository #231)

Step 2: Generate reports

[x] Generate validation reports (run validate_by_mapper DAG): https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/validate_by_mapper_type/grid?dag_run_id=manual__2024-01-31T20%3A52%3A38%2B00%3A00
[x] Add a comment (in this issue) to the output URLs
[x] Download the validation reports locally; prepend the collection registry number to the filename
[x] Upload validation reports to the Rikolti Data Validation folder

Step 3: Review reports

[x] Review sample collections validation reports; leave notes in the spreadsheet
[x] Quickly (and not very deeply) scan through other validation reports (to identify if any new metadata fields surface)
[x] Synthesize notes at the mapper level
[x] Share an update (and surface any anomalies) during a weekly check-in (Mondays at 3:00pm)

Step 4: Have data validation issues? Address & resolve validation issues (synthesized mapper-level):

[ ] Create a new issue (“Validation results: Rikolti mapper name“) and report/request fixes & investigations. Add to current sprint.
[ ] Add a comment to link to the new “validation results” issue.
[ ] Add a “blocked/paused” label to this issue. Include a status note in this issue title (e,g., HOLD for fixes; HOLD for code review; etc.)
[ ] Move this issue back to the “To Do” pile.
[ ] Reset tasks listed in steps 2-3 above; re-generate & re-review (repeat steps 2-3 above, as needed.)

Step 5: Have acceptable validation reports?

[x] Move the valid (accepted) reports to the “VALID” folder in google drive.

[2024-01-31, 20:54:31 UTC] {{logging_mixin.py:150}} INFO - Download validation report at: https://rikolti-data.s3.amazonaws.com/26888/vernacular_metadata_2024-01-31T20:53:03/mapped_metadata_2024-01-31T20:53:54/validation_2024-01-31T20:54:30.csv
[2024-01-31, 20:54:31 UTC] {{logging_mixin.py:150}} INFO - Review collection data at: https://rikolti-data.s3.us-west-2.amazonaws.com/index.html#26888/vernacular_metadata_2024-01-31T20:53:03/mapped_metadata_2024-01-31T20:53:54/data/

Accepted on 2024-02-05!


build(deps): bump ws from 7.5.3 to 8.2.1

Codecov Report

Merging #408 (c8dc42d) into master (ef2f0dd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   45.60%   45.58%   -0.02%
==========================================
  Files          56       56
  Lines        3250     3251       +1
  Branches      563      564       +1
==========================================
  Hits         1482     1482
- Misses       1599     1600       +1
  Partials      169      169

Impacted Files
Coverage Δ

src/WebSocketListener.ts
29.62% <0.00%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef2f0dd...c8dc42d. Read the comment docs.


View button on a BitBucket repo doesn't work

It opens https://bitbucket.org/*org*/*repo*/commit/*hash* which returns 404. It should open https://bitbucket.org/*org*/*repo*/commits/*hash*

Hey Dimitar!
Sadly BitBucket has chosen to use a URL format that no one else is using. Supporting both will move this feature from trivial to quite advanced and to have a negative impact on performance.
I started building the feature with a detection system for what git platform was hosting the repository but I removed it as it added a few moments for the dialog to open as well as a need for caching what URL was found for each specific file (as we still support sub-repos). It got too much.

Alright, not a big deal. If we figure out #27 then I wouldn't care about this at all and close it.


First track Audio file is fetched and played momentarily when multiple tracks add()ed

Describe the Bug
CONTEXT: In our App (using RNTP), a User can browse a Playlist and tap on any Song in that Playlist to begin playing the Song (from that position in the Playlist). In our code when a User taps Play on a Song we first reset() the player, then we add() all the Songs from the Playlist into the Queue, then we skip(index) to the Index of the Song they have chosen (eg they might want to start at Song 3 of 10), then we play().
We found a bug on iOS where some users were hearing a momentary playback of the first Song in the Queue, BEFORE the skip(index) and play() had been called.
Upon further investigation, by monitoring my local file server, I can see that when adding Tracks into the Queue, there is a network request to fetch the first track in the queue, and then it is momentarily played audibly, even before the play() method is triggered.
Steps To Reproduce
Note: This appears to only happen on faster/newer devices. Reproduced on a physical iPhone 13 Pro running iOS 16, and on the simulator.

Add multiple tracks to queue
Observe network request to first track's audio file

Code To Reproduce
await TrackPlayer.add([validDemoTrack1, validDemoTrack2]);

Observe HTTP logs..
[2022-10-06T10:27:57.911Z] <IP_ADDRESS> "GET /demo-story.mp3" "AppleCoreMedia/<IP_ADDRESS>F70 (iPhone; U; CPU OS 15_5 like Mac OS X; en_us)"
[2022-10-06T10:27:57.915Z] <IP_ADDRESS> "GET /demo-story.mp3" "AppleCoreMedia/<IP_ADDRESS>F70 (iPhone; U; CPU OS 15_5 like Mac OS X; en_us)"
[2022-10-06T10:27:57.926Z] <IP_ADDRESS> "GET /demo-story.mp3" "AppleCoreMedia/<IP_ADDRESS>F70 (iPhone; U; CPU OS 15_5 like Mac OS X; en_us)"

Replicable on Example App?
Can you replicate this bug in the React Native Track Player Example App?
Yes.
Environment Info:

main branch of react-native-track-player as of today.
iOS - device and simulator

How I can Help
I'm wondering if this "fetch" and short "play" is triggered by the  resolveImportedPath() method in add() being called here https://github.com/doublesymmetry/react-native-track-player/blob/main/src/trackPlayer.ts#L97 (which also explains why the first artwork is fetched too). However, looking at that code I would expect a request for all tracks, because that code loops through them all, but I only ever see a network request for the First track (during the add() step).
Regardless, there should not be any audio played until play() is fired, so there seems to be an issue somewhere.
Thoughts?

Yes, I have the same issue. When skipping to a next live stream, I can hear the previous livestream for a second. Also, it seems TrackPlayer.play(); is first resuming the previous track and then skips and plays the next track. This is the behavior you mentioned, right?

Yes

I have the same problem，if only use skip can work  just the pre stream playing state

My workaround is adding the upcoming tracks, and then adding the previous tracks afterwards. Like so...
const currentTrackOnwards = tracksToAdd.slice(skipToIndex);
const earlierTracks = tracksToAdd.slice(0, skipToIndex);
await TrackPlayer.add(currentTrackOnwards);
await TrackPlayer.play();
await TrackPlayer.add(earlierTracks, 0); // Insert "previous" tracks in front of index 0

@bradleyflood the approach is good, but that would not make the songs play as they appear on the UI,
if the library plays the next song automatically it would not be the next song to the last played song on the UI
if this issue is not fixed, I might be forced to write my own library for RN audio from scratch 😃

@Amusa-Paulos My solutions plays exactly as shown in the UI, that's the whole point of it :)

okay @bradleyflood I will give it a try

another workaround could be to reset player and add all items and skip to that index
`let list  // List of Audio File in this format [{
"artwork": ,
"id":
"title": ,
"url":
"artist":
}]
await TrackPlayer.pause()
await TrackPlayer.seekTo(0) //just in case
await TrackPlayer.reset()
                    await TrackPlayer.add(list)
                    await TrackPlayer.skip(skipToIndex)
                    await TrackPlayer.play()`

I experienced the same while trying to play one song out of queue, here is my solution maybe it will help you:

@puckey any chance that your #1713 PR addresses this iOS bug? I ask because I see:

Implement TrackPlayer.load(track): replaces the current track with the supplied track or creates a track when the queue is empty. This feature would mainly be used by simple single track apps – for example a radio station app

in your PR, which makes me wonder if TrackPlayer.load would handle playing a new track better than using TrackPlayer.add followed by TrackPlayer.skipToNext.
I see some people are using reset to work around the issue, but I really don't want to do that because I think it triggers playback-track-changed and playback-queue-ended which could lead to unintended weird race conditions before loading the correct new track.

Hi, please somebody can look in to this issue? it was there from 2022 Oct :(

@bradleyflood thanks for sharing your workaround!
Were you able to figure out why adding a track to the queue results in multiple network requests? I've been running into an issue where playing a track is delayed by 1-3 seconds because TrackPlayer.add() seems to hit the supplied url up to four times and doesn't start playing until the final response.

Hey @tjkyner nah I never got to the bottom of it. But it sounds like work by Puckey and others will fix it in upcoming versions.

Hi @ninacoder-info you could look into it ;) We are all just as busy. Cheers :)

@bradleyflood could you verify if this issue has been fixed in nightly?

Yo :) Tried reverting my code to test this today, but couldn't simulate it! hah. I think it only happens in TestFlight and Production versions. So I'll test it in an upcoming TestFlight build.

@bradleyflood are you ok if we consider this resolved?
Additionally for anyone else looking to bypass RNTP's native Queue/Playlist functionality please use the newly introduced load(track) method.

@jspizziri happy to close if this is confirmed fixed. I haven't got capacity at the moment to test it sorry.

In my scenario, when I add a new track and skip to it, or when I skip forward/backward and play, the track player will first play for some seconds then skip and play the right song. If anyone doesn't want to use reset() as a workaround to avoid the race condition, here's my solution:
import { selectLoadChangeTrack, setLoadChangeTrack } from '../../store/slices/playerSlice'

const loadChangeTrack = useSelector(selectLoadChangeTrack)

// skip to a new track will cause playerState change, so we can use useEffect to check when it change to State.Ready and then call play()
useEffect(() => {
  const checkReadyAndPlay = async () => {
    if (!loadChangeTrack) return

    if (playerState === State.Ready) {
      await TrackPlayer.play()
      dispatch(setLoadChangeTrack(false))
    }
  }
  checkReadyAndPlay()
}, [loadChangeTrack, playerState])

const onPressSkipForward = async () => {
  ...
  await TrackPlayer.pause()
  await TrackPlayer.seekTo(0)
  await TrackPlayer.skipToNext()
  dispatch(setLoadChangeTrack(true))
  ...
}

@ianniu does this still happen for you in the nightly release of react-native-track-player?

@ianniu does this still happen for you in the nightly release of react-native-track-player?

I haven't upgraded it. I'm using 3.2.

@ianniu are you able to try the nightly and see if this issue is fixed?

@ianniu are you able to try the nightly and see if this issue is fixed?

Sorry, I'm not able to do that for now.

@bradleyflood @ianniu as far as I have been able to tell, the issue no longer happens for me with the nightly branch. I no longer hear the first episode in the queue play briefly after a later episode is added to the queue.
So I think it is fixed, but I also made this patch change around the same time (add iosInitialTime handling) and I'm not sure if that overlaps with the issue. https://github.com/podverse/podverse-rn/blob/develop/patches/react-native-track-player%2B3.2.0-bb749e5d286737681ba8907dfd287480eb1cec45.patch#L5389

Considering this fixed.


fix(TransitionablePortal): fix onClose call

Fixes #4056.

Codecov Report

Merging #4334 (1fe1aac) into master (bb2db59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4334   +/-   ##
=======================================
  Coverage   99.75%   99.75%
=======================================
  Files         180      180
  Lines        3241     3243    +2
=======================================
+ Hits         3233     3235    +2
  Misses          8        8

Impacted Files
Coverage Δ

...ddons/TransitionablePortal/TransitionablePortal.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff70355...1fe1aac. Read the comment docs.


"make confidence" on Linux asks for password after switching users

"make confidence" uses gpg-agent so that the password doesn't have to be entered over and over.
However, it does ask for Alice's password once after switching Bob->Alice and vice-versa.  It isn't clear to me what about become_alice and become_bob is broken that makes that happen.
It would be great if it only asked for Alice's password exactly once, and Bob's password exactly once.

Fixed in 48cc17ac0a7622c3bacc109e34ed8d5ff58a3690


#235: upgrade rusoto and force http1 for rustls

Why
close https://github.com/roapi/roapi/issues/235
What
disable http2 and use http1 only for S3 like API
For reviewers
tested locally, but sorry, didn't add an integration test with mock S3/GCS container yet, seems more effort required

Thank you @jychen7 !

welcome :D


Calculate train-test gap

metric 1 = train acc - test acc
metric 2 = train acc / test acc
Acceptance criteria
calculated correctly
output in a programatically extractable format

Hey @fraboeni, just to make things clear. For this task to be accepted, we do not need to calculate the test and train accuracy by our own (they are given). We only have to take the accuracies and return the wanted measures, right?


Update GUICreator.java

Removed look and feel setup from here, because it was setup on main class.

This is Redundant, look at my latest pull request.


Angle

This causes openfl's Application.hx to call its superclass' processArgs() function and thus process command line arguments for setting configs.
It also fixes BitmapData by selectively choosing the right internal pixel format based on whether the system is using ANGLE or not.

Obsolete, see this branch for continuing efforts towards ANGLE support everywhere on windows:
https://github.com/larsiusprime/lime/tree/angle2

Whenever ANGLE support is added to lime:
https://github.com/larsiusprime/lime/tree/angle2
This PR will become necessary for OpenFL

Okay this should be ready now.
Lime pull:
https://github.com/openfl/lime/pull/641

@jgranick I assume this is obsolete now given the latest work you've done?


Add a test suite

This is a test suite that runs osp_scraper_spider on a local test server and then checks the contents of the WARC files that are generated.
I don't think it's ready to be merged yet, but I think it's far enough along to start discussing it here.

Not sure if this will hit all paths to files_url / DownloadPipeline?
VERY EXCITING


Add configuration to MasterSlaveServersConfig to manually set syncSlaves

Hello,
I'm using a MasterSlaveServersConfig with readMode=”SLAVE” and Redis Enterprise. While this configuration works with Redis OSS, it is not always applicable to Redis Enterprise since read-replicas are scaled-out at the database-level; not shard.
Redis Enterprise can guarantee HA with a single replica shard however the throughput requires multiple read-replicas. This mismatch between the total slaveAddresses registered in the configuration and total shards used for HA causes a timeout in the WAIT command issued by Redisson Transactions.
I checked Redisson’s code and found that the MasterSlaveServersConfig is passed to the MasterSlaveEntry which is used by BatchOptions to set syncSlaves based on the amount of slaveAddresses configured. When a Redisson Transaction is executed, the amount of syncSlaves determines how many HA replica shards are needed to respond before the WAIT command releases its lock. With the mismatch, this means that they will always timeout.
As a workaround, I'm using a single slaveAddress in MasterSlaveServersConfig which points to a reverse-proxy for load-balancing of reads between two separate Redis Enterprise database endpoints. Those databases are kept in-synch using Redis Enterprise's replica-of and it worked. However, this is not an optimal solution since it adds an extra network-hop and deployment complexity.
So, my feature request is to add a new optional field in the MasterSlaveServersConfig to set syncSlaves manually which will allow users to pass multiple slaveAddresses without impacting the use of the WAIT command on the master database/shard. Since the freeze logic is run in other connection related methods, there would still be protection to handle unavailable read-replicas.
Thanks, Allen

Hello Allen,
I'll add syncSlaves field to TransactionOptions object. Default value 0 which means availableSlaves and -1 means no sync at all.
Code example:
TransactionOptions.defaults().syncSlaves(1);

Thanks @mrniko. Would this change be exposed through configuration so we don't need to ask HCL to change the way they are using the API?

@aterleto
Yes.
@avcad
BatchOptions already has syncSlaves setting

Done

Thanks @mrniko however I don't see a change to either base config. Can you explain how this new option can be set from the config?
I was expecting something like -
masterSlaveServersConfig:
  idleConnectionTimeout: 10000
  connectTimeout: 10000
  timeout: 3000
  retryAttempts: 3
  retryInterval: 1500
  failedSlaveReconnectionInterval: 3000
  failedSlaveCheckInterval: 60000
  **syncSlaves: 1**

This setting is applied only to Transaction object. masterSlaveServersConfig has settings applied to Redis client itself. I don't think it's a good API design to put some object settings to masterSlaveServersConfig.

But the setting is related to deployment options, therefore is configuration specific, since one environment might have 1 syncSlaves (production) and a different environment might have 0 (development). It would be an anti-pattern to hard-code anything specific to environment config.

the same settings is also present in BatchOptions. I'm afraid I can't add the same setting per object.

Hi @mrniko, Thanks!
I meant this option TransactionOptions.syncSlaves: "Default slaves value is 0 which means available slaves"
For BatchOptions , 0 means no sync, while in TransactionOptions it is available slaves.
Could BatchOptions  be changed for 0 to mean all available slaves as well?
(although that might break backward compatibility)

@avcad
It's a breaking change. I think to introduce it in next major version.

This setting is applied only to Transaction object. masterSlaveServersConfig has settings applied to Redis client itself. I don't think it's a good API design to put some object settings to masterSlaveServersConfig.

@mrniko MasterSlaveServersConfig is passed to the MasterSlaveEntry which is used by BatchOptions to set syncSlaves based on the amount of slaveAddresses configured. So there is already precedent for client settings to impact the use of the WAIT Command. If we cannot set syncSlaves through configuration then it does not solve our scenario where the use of the Redisson API is encapsulated within 3rd party code and only the config is exposed to the user.
If MasterSlaveServersConfig can set BatchOptions then why can't it also ensure the current encapsulated code does not force timeouts when using the WAIT command?

@aterleto
MasterSlaveEntry.getAvailableSlaves() - is not a config setting, but a calculated value.

@mrniko Correct. But getAvailableSlaves() is calculated using slaveAddresses in MasterSlaveServersConfig alone. If I am not mistaken these slaveAddresses are not used in this configuration type for HA/failover. So when there is a mismatch between HA shards and read-replica shards you will always have a timeout. Since the #HA shards can vary per environment it makes sense to configure this instead of hard-coding it at the API level. Based on that logic, shouldn't it factor into the calculated value of BatchOptions since its setting the parameters for the WAIT command?

@aterleto

So when there is a mismatch between HA shards and read-replica shards you will always have a timeout

I think in this case it's a misconfiguration. This configuration assumes that all slaves should be defined. In this case getAvailableSlaves() calculated correctly.


Change offered course option column type to BIGINT

Context
Some columns referring to the same tables are defined interchangeably as integer and BIGINT, this is due to us referencing the same table under different ids.
Changes proposed in this pull request
Course option ids are defined as BIGINT in our schema, make sure the offered course option id is also of type BIGINT as well, as it also refers to the same course_options table.
Guidance to review
Making sure that running the migration and rolling back works.
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

I just realised we have multiple inconsistent IDs past this which need fixing, I'll raise a separate PR for those


Test smaller QR codes in desktop

Test 200px by 200px in JS (if scanning gets harder). If scanning is not harder reduce the size.

qr code width: 13.5em (outside div)
change margin of ride side panel (where connection is made) from 3.75 to 2.5
.connect-guide[data-v-573d2f0f]


Getting BufferChunkOverflowError from non-buffered copy plugin!

Describe the bug
In my Fluentd config, I use the copy plugin to send the same logs to two Kafka clusters (each using the kafka2 plugin). In each kafka2 section, I set the max buffer chunk size (i.e. chunk_limit_size) to 600 KB (600,000 bytes).
(See Fluentd config below)
I am seeing multiple error messages like this:
{"time":"2020-04-02 09:54:14.883 -0400","level":"error","message":"[publish_logs_to_outputs] ignore emit error error_class=Fluent::Plugin::Buffer::BufferChunkOverflowError error=\"a 465698bytes record is larger than buffer chunk limit size\"","worker_id":5}

{"time":"2020-04-02 11:11:31.630 -0400","level":"error","message":"[publish_logs_to_outputs] ignore emit error error_class=Fluent::Plugin::Buffer::BufferChunkOverflowError error=\"a 35711bytes record is larger than buffer chunk limit size\"","worker_id":5}

There are two problems with these error messages:

The BufferChunkOverflowError is being generated from the copy plugin which, as far as I know, is non-buffered!
According to the error messages, the BufferChunkOverflowError is being triggered by log sizes (eg. ~466 KB, ~36 KB) that are all much lesser than the actual chunk_limit_size set in my kafka2 sections: 600 KB!

Expected behavior
What I expect is:

Any BufferChunkOverflowError should only be generated by output plugins that actually have buffers, like the kafka2 plugin -- NOT the copy plugin!
The BufferChunkOverflowError should only be triggered when the log size is greater than the configured chunk_limit_size!

Your Environment

td-agent version: 1.9.2
fluent-plugin-kafka version: 0.12.3
Operating system: Ubuntu 18.04.4 LTS (Bionic Beaver)
Kernel version: 4.15.0-88-generic

Your Configuration
...
<match **>

  @type copy
  @id publish_logs_to_outputs

  # Kafka cluster 1
  <store ignore_error>

    @type kafka2
    @id kafka_cluster_1

    default_topic xxx

    brokers xxx

    sasl_over_ssl true
    username xxx
    password xxx
    ssl_ca_cert xxx
    ssl_verify_hostname false

    <format>
      @type json
    </format>

    <buffer>
      @type file

      chunk_limit_size 600000
      total_limit_size 500g

      flush_mode interval
      flush_interval 10s
      flush_thread_count 12
    </buffer>

  </store>

  # Kafka cluster 2
  <store ignore_error>

    @type kafka2
    @id kafka_cluster_2

    default_topic xxx

    brokers xxx

    sasl_over_ssl true
    username xxx
    password xxx
    ssl_ca_cert xxx
    ssl_verify_hostname false

    <format>
      @type json
    </format>

    <buffer>
      @type file

      chunk_limit_size 600000
      total_limit_size 500g

      flush_mode interval
      flush_interval 10s
      flush_thread_count 12
    </buffer>

  </store>

</match>
...

Your Error Log
(copied from above)
I am seeing multiple error messages like this:
{"time":"2020-04-02 09:54:14.883 -0400","level":"error","message":"[publish_logs_to_outputs] ignore emit error error_class=Fluent::Plugin::Buffer::BufferChunkOverflowError error=\"a 465698bytes record is larger than buffer chunk limit size\"","worker_id":5}

{"time":"2020-04-02 11:11:31.630 -0400","level":"error","message":"[publish_logs_to_outputs] ignore emit error error_class=Fluent::Plugin::Buffer::BufferChunkOverflowError error=\"a 35711bytes record is larger than buffer chunk limit size\"","worker_id":5}

Additional context
To clarify, most of the error messages are what I expect, and indicate that the kafka2 config (and chunk_limit_size config) are working as expected.
For example, most of the error messages look like this:
{"time":"2020-04-02 11:37:29.573 -0400","level":"warn","message":"[kafka_cluster_2] chunk bytes limit exceeds for an emitted event stream: 8293577bytes","worker_id":4}

There is no problem with these error messages, because the error is coming from the buffered kafka2 plugin, and the error is being generated by a log > chunk_limit_size (600 KB) -- i.e. these error messages are expected, because I expect logs > 600 KB to be ignored by the kafka2 plugin.
My problem is that I ALSO sometimes see the weird error messages at the top, which come from the non-buffered copy plugin, and complain about logs that are < chunk_limit_size (600 KB)

The BufferChunkOverflowError is being generated from the copy plugin which, as far as I know, is non-buffered!

This error is kafka2's error which copy plugin emits. This error is a bit confusing. How about adding class name where the error occurs to the error log like "ignore emit error from #{output}", error: e?  In design, Errors which is occured in output plugins are handled outside of them.
https://github.com/fluent/fluentd/blob/cc97aa414f918e0ae7a596cc5ccca8e5fa080ee2/lib/fluent/plugin/out_copy.rb#L64

According to the error messages, the BufferChunkOverflowError is being triggered by log sizes (eg. ~466 KB, ~36 KB) that are all much lesser than the actual chunk_limit_size set in my kafka2 sections: 600 KB!

it's wired... The error can only happen when a chunk is over chunk_limit_size.
https://github.com/fluent/fluentd/blob/cc97aa414f918e0ae7a596cc5ccca8e5fa080ee2/lib/fluent/plugin/buffer.rb#L565
https://github.com/fluent/fluentd/blob/cc97aa414f918e0ae7a596cc5ccca8e5fa080ee2/lib/fluent/plugin/buffer.rb#L711

@ganmacs Interesting ... So you're saying that, even though the error message comes from the copy plugin -- which we know because the error message has the copy plugin's ID: [publish_logs_to_outputs] -- the actual error was generated by the kafka2 plugin?

Yes. Handling such errors outside of plugins is the design of fluentd.

How about adding class name where the error occurs to the error log like "ignore emit error from #{output}"

output.plugin_id?

@ganmacs Thank you for explaining how the error handling works -- that answers my first question.
Do you have any ideas regarding my second question: Why is BufferChunkOverflowError being triggered by logs that are < chunk_limit_size (600 KB)?

Do you have any ideas regarding my second question: Why is BufferChunkOverflowError being triggered by logs that are < chunk_limit_size (600 KB)?

I'm not sure. I can't reproduce it. Do you have a reproduction config and input data?

Thank you. I just checked my records -- it is still happening, but not frequently. Over 24 hours, it happened about ~116 times. Our current config is fairly complex though -- let me see if I can get a simpler config that reproduces the same issue, and I will upload here. Might take a few days before that's ready.

Note: This might be the same as #3072, which was apparently fixed in v1.11.2


multipart/form-data UploadRequest body is nil

What did you do?
Using AF to POST a multipart/form-data
What did you expect to happen?
Wanted to inspect the body being sent to the server, but the UploadRequest.body is always nil.
Body is being sent, but I cannot see how it is generated to confirm it is correct.
What happened instead?
UploadRequest.body is always nil.
Alamofire Environment
Alamofire version: 4.7.2
Xcode version: 9.4
Swift version: 4.1
Platform(s) running Alamofire: macOS, iOS
macOS version running Xcode: 10.13.5

When making a MultipartFormData request, or an UploadRequest in general, URLSession's underlying uploadTask(with:) API is being used, which means that the task will modify your request when it's issued to include the proper body, which could be a fixed amount of data or streamed from disk or memory. Unfortunately Alamofire has very little visibility into this process, so using an HTTP proxy tool like Charles Proxy can be used to verify what you're sending is correct, if you can't do that from the server side.

Thanks for these suggestions.
I was avoiding using a proxy as it’s a pita to setup with tvOS.

I've never done it myself, but instead of setting up a proxy at a system level, you could trying setting it up at a URLSession level, though the URLSessionConfiguration's connectionProxyDictionary. I found this documentation for the constants and this thread on the Apple Developer forums.


refactor: nest the editor route inside space

Summary

Working toward https://github.com/snapshot-labs/workflow/issues/142
Following https://github.com/snapshot-labs/sx-monorepo/pull/768
Continuation of the routes refactoring, this PR will move the editor route as a child of space.
Changes

Nest editor route inside space
Rename editor route to space-editor
Since the Editor view is now a child of Space, get the space object as props from Space, and avoid duplication related to space initialization and monitoring
hasAppNav state has been moved and centralized in Layout/App
Refactor the navigation guard creating new draft inside a watch inside the main <script setup>, to make use of the passed props.space

How to test

Visit the editor page
It should work as before

Next
Next and last step of this route refactoring will be to nest the proposal routes inside space

@wa0x6e conflicts


Nested derived predicates support

Allow derived predicates that are dependent on other derived predicates

I'm not yet able to reproduce @Oufattole's original issue that made me think this might be wrong. In branch 109_nested_predicates (see linked branch) I add a config test with a 2-layer setup and it doesn't have any issue, but it may be an insufficient test.


[paho-mqttpp3] Build using HIGH_PERFORMANCE

Is your feature request related to a problem? Please describe.
By default, Paho MQTT C++ should be built with the PAHO_HIGH_PERFORMANCE=ON setting. As specified in here:

It also uses the "high performance" option of the C library to disable more extensive internal memory checks. Remove the PAHO_HIGH_PERFORMANCE option (i.e. turn it off) to debug memory issues, but for most production systems, leave it on for better performance.`

Every malloc/free call is burdened with extra debug operations that the end-user does not expect on a production environment.
Proposed solution
Build with PAHO_HIGH_PERFORMANCE=ON, such as described in their docs:
cmake -Bbuild -H. -DPAHO_ENABLE_TESTING=OFF -DPAHO_BUILD_STATIC=ON \     -DPAHO_WITH_SSL=ON -DPAHO_HIGH_PERFORMANCE=ON
Describe alternatives you've considered
N/A
Additional context
N/A

My understanding from the readme and the corresponding CMakeLists.txts is that this option must be set for the underlying c library paho-mqtt, not for paho-mqttpp3. I can prepare a pull request shortly adding this option to paho-mqtt.
Once that is merged, you would need to remove paho-mqtt with --recurse and then reinstall paho-mqttpp3 to benefit from the change.


Adding two loss from actor will lead to an error " gradient computed twice for this partition"

When training the ppo model, I turned on the gradient_checkpointing_enable. If you want to calculate ptx loss, then actor will forward twice. In your code, these two loss are executed backward once separately, which will not be any problem. However, if I add these two loss and then use the engine's backward, then the error "gradient computed twice for this partition" will appear. If I don't use the option of gradient_checkpointing_enable, this error will not occur. This error seems to only appear in the zero mode of deepspeed, and I don't know why.

same issue in the training of Reward model

Has this issue fixed?This will significantly affect the training efficiency of RLHF.

Same issue, is there any progress?

same issue, any progress here?


add undo/redo history

Closes #53 .
Closes #52 .
Closes #15 .

This will be merged as part of https://github.com/openscd/open-scd-core/pull/67 .


Add ESLint to JSBin

I want to add ESLint to JSBin when it's using the Babel transpiler. Currently the hinter/linter messages are very broken when using the 'ES6 / Babel' option. I'm using ESLint with Atom, and it really saves me so much time. I expect it will truly help students not to get bogged down by syntax issues too.
I'm creating this ticket mainly to track my fork's progress. To get familiar with your codebase I'm going to refactor addons.js a bit, hopefully I can fix some other bugs too.

[ ] See if I can use angelozerr/codemirror-lint-eslint
[ ] Fix editor-settings.js's call to reloadAddons, so it actually reloads without a refresh

Is there any update on this?

Any update on this?


link should not have role=button unless it

Sorry @mdo Mark...Duplicate o #13371 should be reopened
Link

If this is a link then don't add the role="button" because a screen reader user will think it DOES someTHING instead of going someWHERE
Check out the aria spec for role=button
https://www.w3.org/TR/wai-aria-1.1/#button

that issue from 2014 refers to an old version of bootstrap, where in the documentation there was a lot of rubbish.
the original issue #13371 also seems to refer specifically to the "active state" section. here, they're not links per se, but toggles that can be turned on or off. so not actual links, and in that case (all other things being equal, i.e. the keyboard activation etc) role="button" is in fact appropriate (if it's not possible to directly use a <button>)
the latest equivalent documentation is here https://getbootstrap.com/docs/4.3/components/buttons/ and you'll note that, for the first section on button tags for instance, it contains the following:

When using button classes on  elements that are used to trigger in-page functionality (like collapsing content), rather than linking to new pages or sections within the current page, these links should be given a role="button" to appropriately convey their purpose to assistive technologies such as screen readers.

though, on third reading, that section is a bit...confused, as it's not quite clear to me how, outside of using it in combination with the toggle plugin, the active state in isolation would be needed, let alone then forced and semantically reinforced by using aria-pressed as well...might be worth rethinking in the long run.

btw @DavidMacDonald ... use backticks in github comments around markup otherwise your comment appears all munged...

I think the strange thing is there are present href="" and role="button" at the same time, for a screen reader is clearly a button but it could follow a link..

the example assumes that there's javascript in place that prevents the link from acting as a link (as is common practice when doing those sorts of faked buttons)

@patrickhlauke Thoughts on next steps here?

i think this can be closed, as we're making it clear enough in the docs that even though these controls say "Link", it refers to the underlying element used, but that they're acting as buttons.
and we have this already in the page as well

When using button classes on  elements that are used to trigger in-page functionality (like collapsing content), rather than linking to new pages or sections within the current page, these links should be given a role="button" to appropriately convey their purpose to assistive technologies such as screen readers.

i don't believe there's a big risk of authors misunderstanding this / not understanding the opposite ... that you shouldn't add role="button" unless it acts as a button. not seen much evidence of authors cargo-culting code from here and marking links that act as links up as being role="button"


Fix WithReference extension return type

Not caught in PR, but just discovered in use, the WithReference changed the shape of the type from ProjectResource to IResourceWithEnvironment -- not making it compatible with other components.
Microsoft Reviewers: Open in CodeFlow

This should be a generic method with a constraint IResourceWithEnviroment. See https://github.com/dotnet/aspire/blob/c4ef238b04ccacf5278f884a5e6e047ac954e5cb/src/Aspire.Hosting/ResourceBuilderExtensions.cs#L257


Fix/alignment of devops arsenal

fixed #548
fixed the alignment of the dev ops arsenal and increase the size of cloud icon .
work to do :

after :

@mdazfar2 created the new pr .

looks good to me
thanks @mdazfar2

https://github.com/mdazfar2/HelpOps-Hub/assets/159682348/1fd9899d-05d2-48cf-82fd-9defcb491cc9
@mdazfar2 ""start now"" button is not working as you can see it in above video if you want me to fix it i will surely do it tomorrow
thank you really enjoying working on your wonderful project .

@ANKeshri Yes, I know that, but we are creating another page for it. After the completion of this page, I will let you know to add this in the future.

sure


[bazel] use bazelisk to invoke buildifier from CI

Signed-off-by: Drew Macrae<EMAIL_ADDRESS>

Can you do quick-bazel too?

Miles got to it first here: https://github.com/lowRISC/opentitan/pull/12165/commits

This change got merged in with a separate PR


Docs.MS Release Updates for azure-template

Update docs metadata and targeting for release of azure-template

Docs Build status updates of commit d4680fa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/template-readme.md
:warning:Warning
View (azure-node-preview)
Details

ci-configs/packages-preview.json
:white_check_mark:Succeeded

docs-ref-services/preview/template-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Bug fix revert

Revert back the change you implemented in the previous task using the git revert command. The file should now read:
1
2022 XYZ, Inc.

Revert back the change you implemented in the previous task using the git revert command. The file should now read:
1
2022 XYZ, Inc.


use PCHIP interpolator

Cubic Spline is a pretty standard interpolation method.  It has continuous first and second derivatives, and the scipy implementation can handle periodic boundary conditions.  The draw back is that it can "overshoot" data.  Even though the data profile is strictly non-negative, the spline can dip below zero.
Piecewise Cubic Hermite Interpolating Polynomial (PCHIP) is another method.  It only has continuous first derivatives, and the scipy implementation doesn't allow you to specify the boundary conditions.  It is monotonic between all specified points, so it never overshoots.
The interpolated J1713 profile differs on the 0.1% level relative to the maximum:

If a profile wraps around the 0/1 phase boundary, the derivative of the profile won't necessarily be continuous across the wrap.  We give up the periodic boundary condition, but I don't think it really matters.

This fixes a warnings stemming from sqrt of negative numbers when using DataProfiles with BasebandSignals, related to #157 and #158 of the JOSS review.


Fix custom notification object

[x] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

closes #9268
when recreating the notification object from array, Notification class resolved the correct CustomNotification but the CustomNotification::fromArray is not called again. this PR fixes that by checking if the notification object resolved from container is custom and its called from Notification class to ensure its only called once and prevent infinite loop
another approach would be in livewire\Notifications to resolved the notification object but that would have multiple useless instance created and more code changes that I not able to test

Duplicate of #9299?

Duplicate of #9299?

Fixed the same issue without exposing unnecessary info

I don't think I understand how it works?

Thanks!


Librispeech Models

Ready to merge; PR is composed of two additions- Librispeech YAML file and download script. Both have been tested and are fully functional.
I deleted the included Estonian/Voxforge models locally, and just noticed that the model deletions were not reverted. Still getting used to git.
However, I do think this PR is a better form to distribute and maintain. I would argue that the models themselves are not a good inclusion for the repository due to their size, which is considerable for the very particular use case that they serve. It would be optimal to just include download scripts for the estonian and voxforge models instead.
Finally... this is my first ever open source pull request! Excited to make revisions and get it pulled :smile:

Thanks for the PR.
However, it seems that you are using absolute paths in your yaml file. It's better to use relative paths in our case (I added a comment).
Also, please don't delete other models with this PR. Even when this might be a good idea, it should be done using a separate PR.

I fixed the yaml file, and returned the models. Is this now ready to merge?

The PR is still polluted with files not related to Librispeech, so I cherrypicked the download script and the conf file and just added them to the master branch. Thanks a lot for your efforts.


Updating to ADAL 5.2, VS token provider bug fix

AppAuthentication 1.4 release

@AlexGhiondea is there any additional action to get this PR closed? Thanks!


vimPlugins.nvim-bqf: add plugin dependencies

Description of changes
nvim-bqf need fzfWrapper

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The readme says fzf is optional, does it work without fzf?
https://github.com/kevinhwang91/nvim-bqf#requirements

But, it dosen't have an option to disable fzf.
And, if not have fzf, when use hotkey zf, it will show:

I think the part that's optional is that the zf mapping is an optional feature? I think it makes sense to keep the fzf dependency optional, since it is pretty simple to enable the feature (by adding fzfWrapper to configure.packages.*.start)

Ok, I will close this.

I don't think there is a way to specify optional dependencies, but you can maybe add it to the description


elastix::TransformBase itk::Object casting

Building on the work of @ViktorvdValk to address the macOS ITKElastix Python package, using
https://github.com/ViktorvdValk/elastix/tree/ITK_TEMPLATE_EXPORT
https://github.com/ViktorvdValk/ITKElastix/tree/UseForkITK
with the script:
import itk
import faulthandler

faulthandler.enable()
fixed_image = itk.imread('data/CT_2D_head_fixed.mha', itk.F)
moving_image = itk.imread('data/CT_2D_head_moving.mha', itk.F)

parameter_object = itk.ParameterObject.New()
default_rigid_parameter_map = parameter_object.GetDefaultParameterMap('rigid')
parameter_object.AddParameterMap(default_rigid_parameter_map)

result_image, result_transform_parameters = itk.elastix_registration_method(
    fixed_image, moving_image,
    parameter_object=parameter_object,
    log_to_console=False)

a debug build with lldb, identifies the issue:
Process 40949 stopped
* thread #2, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x00000001616575f1 _ElastixPython.so`elastix::TransformBase<elastix::ElastixTemplate<itk::Image<float, 2u>, itk::Image<float, 2u> > >::SetTransformParametersFileName(this=0x000000016ccacfd0, filename="output_path_not_set/TransformParameters.0.txt") at elxTransformBase.hxx:1694:17
   1691	    this->m_TransformParametersFileName = "";
   1692	  }
   1693	  ObjectType * thisAsObject = dynamic_cast<ObjectType *>(this);
-> 1694	  thisAsObject->Modified();
   1695
   1696	} // end SetTransformParametersFileName()
   1697
Target 0: (Python) stopped.
(lldb) p this
(elastix::TransformBase<elastix::ElastixTemplate<itk::Image<float, 2>, itk::Image<float, 2> > > *) $0 = 0x000000016ccacfd0
(lldb) p thisAsObject
(ObjectType *) $1 = 0x0000000000000000

https://github.com/ViktorvdValk/elastix/blob/8ef128fedc26023df0799ff2d4fe965c184b2151/Core/ComponentBaseClasses/elxTransformBase.hxx#L1676-L1696
where ObjectType is itk::Object. But elastix::TransformBase does not inherit from itk::Object, but elastix::BaseComponent:
https://github.com/SuperElastix/elastix/blob/9d971ef82c7d34cbc53f544d9a276fd7daf32bf8/Core/Install/elxBaseComponent.h#L53
@N-Dekker @mstaring @stefanklein passing to you for the elastix architecture-appropriate change to address this.

ObjectType is itk::Object. But elastix::TransformBase does not inherit from itk::Object

Thanks for investigating this issue, @thewtex!
Honestly it took me a while to understand this part of the architecture, but in practice it appears that every elastix::TransformBase derived object is also derived from itk::Transform, via another inheritance branch (using multiple inheritance). So I think this particular dynamic_cast<ObjectType *> should have worked!
Of course, that does not explain the crash. Sorry!

@N-Dekker thanks for the pointers. In liu of better solutions, this branch prevents the crash on macOS:
https://github.com/SuperElastix/elastix/pull/412


finish semi ring and complete split empty str proof

Review, but DO NOT MERGE This requires https://github.com/awalterschulze/regex-reexamined-coq/pull/159 to merge this. Let me worry about doing it in the right order.
Here I finish the semi ring proof for or_lang and and_lang and use it to finish the proof for split empty string that we could use to finish the commute square proof.

Discussed offline: merging now and will post review

Discussed offline: merging now and will post review