Bug: Added support for triggers in docker-build module when hash changes

Description
Even if triggers parameters is set, docker image is always rebuild.
Terraform plan result :
  # module.docker_image_lambda_actiflo_effluent_predict.docker_image.this will be created
  + resource "docker_image" "this" {
      + force_remove = false
      + id           = (known after apply)
      + image_id     = (known after apply)
      + keep_locally = false
      + name         = "423671310539.dkr.ecr.eu-west-1.amazonaws.com/vwt-insight-actiflo-effluent-predict-dev:1.0"
      + repo_digest  = (known after apply)
      + triggers     = {
          + "dir_lambda" = "304b10ee4074f39e8fb3ccc5eca832dadca25bea"
          + "dir_layer"  = "ffc5d2f69b1723ffb97a743f9632e922c31f9b59"
        }
      + build {
          + cache_from   = []
          + context      = "./.."
          + dockerfile   = "lambdas/actiflo_effluent/effluent/Dockerfile"
          + extra_hosts  = []
          + remove       = true
          + security_opt = []
          + tag          = []
        }
    }
  # module.docker_image_lambda_actiflo_effluent_predict.docker_registry_image.this must be replaced
-/+ resource "docker_registry_image" "this" {
      ~ id                   = "sha256:00b4edb112e88997f64c2d440ca76aa6d9ca27e3d0ef39117aa12877be17797e" -> (known after apply)
        name                 = "423671310539.dkr.ecr.eu-west-1.amazonaws.com/vwt-insight-actiflo-effluent-predict-dev:1.0"
      ~ sha256_digest        = "sha256:00b4edb112e88997f64c2d440ca76aa6d9ca27e3d0ef39117aa12877be17797e" -> (known after apply)
      ~ triggers             = { # forces replacement
          - "image_id" = "sha256:adab56e502a001ca849997c22bcbd8b2a656457ca208aedd2d3e052d3f4aab7d"
        } -> (known after apply) # forces replacement
        # (2 unchanged attributes hidden)
    }

[x] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]: 6.5.0

Terraform v1.5.2
on darwin_amd64

provider registry.terraform.io/bdwyertech/json2dynamodb v0.1.11
provider registry.terraform.io/hashicorp/archive v2.4.0
provider registry.terraform.io/hashicorp/aws v5.22.0
provider registry.terraform.io/hashicorp/external v2.3.2
provider registry.terraform.io/hashicorp/local v2.4.0
provider registry.terraform.io/hashicorp/null v3.2.2
provider registry.terraform.io/kreuzwerker/docker v3.0.2

Reproduction Code
module "docker_image_lambda_actiflo_effluent_predict" {
  source  = "terraform-aws-modules/lambda/aws//modules/docker-build"
  version = "6.5.0"

  create_ecr_repo  = true
  ecr_repo         = "${local.project_name_actiflo_effluent}-predict-${var.env_name}"
  image_tag        = "1.0"
  docker_file_path = "lambdas/actiflo_effluent/effluent/Dockerfile"
  source_path      = "${path.module}/.."
  scan_on_push     = true
  triggers = { # rebuild only when one of this files changes
    dir_lambda = sha1(join("", [for f in fileset("${path.module}/..", "lambdas/actiflo_effluent/effluent/*") : filesha1("${path.module}/../${f}")])),
    dir_layer  = sha1(join("", [for f in fileset("${path.module}/..", "layers/utils_actiflo/*") : filesha1("${path.module}/../${f}")]))
  }
}

Steps to reproduce the behavior:

Expected behavior
No rebuild if files no changes
Actual behavior
Docker image is always rebuild
Terminal Output Screenshot(s)

Additional context

https://github.com/terraform-aws-modules/terraform-aws-lambda/pull/510


Responsiveness issue

Text of second paragraph is bigger than text of first paragraph in mobile view which looks wierd.

Please assign me this issue under gssoc'23.

assigned @stuti-09 📌


Fix mutation pattern

Fix mutation pattern from entity<operation> to <operation><entity>

#sign-off

#sign-off

#sign-off

@seesharprun what are these "#sign-off" messages?

@seesharprun what are these "#sign-off" messages?

We have comments we leave to indicate that someone should review your pull request and merge it to main. The automations weren't working, but it should be working now and this pull request should be merged now.


Focus does not go to close cross when details dialog opened

Open the Readium Chrome App to the library view.  Open the Add to Library dialog.  Focus should be set into the dialog. The general Readium behavior is to set focus on the close button in the upper right when the dialog is opened.
This issue is a Bug
Expected Behavior
Focus should go to the Close button in the upper right corner of the dialog when the dialog is opened.
Observed behavior
Focus does not go into the dialog until the user presses tab (or clicks into the dialog)
Steps to reproduce

Open the Readium Chrome App
From the library view, select the Add to Library button on the toolbar
The Add to Library dialog opens.
Note that focus is not visible within the dialog, press tab to focus the close button in the upper right corner - this button should have been focused immediately when the dialog opened.

Test file(s)
Product
latest official version available from the Chrome Web Store - 2.23.0
Version of the Chrome browser - Version 51.0.2704.103 (64-bit)
OS and version - OS X 10.11.5
Happens in the cloud reader as well.
Additional information
Will look into fixing this for the managed dialog and About dialog as well.

Fixed by https://github.com/readium/readium-js-viewer/pull/554


Bundle of patches for 1.5.4_wmagent - patch1

1.5.4_wmagent branch version of:

Skip ErrorHandler cycle if agent configuration fails to be retrieved - take2 #10852
Set request_GPUs classad according to RequiresGPU #10849

 Fix #10857 - Bundle of patches for WMAgent 1.5.4.patch1


White window when running on Windows 10

First of all, thanks for creating and sharing this tool :-)
I got the binary running on my Mac just fine, but when I try to run it on Windows via npm start it just opens a white program window without anything inside it.
If I open the console I get this error:
Uncaught Error: The specified module could not be found.
<EMAIL_ADDRESS>    at process.func (electron/js2c/asar.js:140)
    at process.func [as dlopen] (electron/js2c/asar.js:140)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:922)
    at Object.func (electron/js2c/asar.js:140)
    at Object.func [as .node] (electron/js2c/asar.js:140)
    at Module.load (internal/modules/cjs/loader.js:735)
    at Module._load (internal/modules/cjs/loader.js:648)
    at Module._load (electron/js2c/asar.js:717)
    at Function.Module._load (electron/js2c/asar.js:717)
    at Module.require (internal/modules/cjs/loader.js:775)

Any idea what might be causing this?

Hi @AndreasRef ,
Thank you for reporting this issue! Looks like the problem is with node and tensorflow versions. Unfortunately I don't have access to a windows 10 computer at the moment. However, this issue raised in tfjs repo seems to be very similar to yours:
https://github.com/tensorflow/tfjs/issues/2341
They seem to have solved it by upgrading node and/or tfjs, maybe give that a try?
Thanks!

Finally I have been able to have it working thanks to this solution (manually adding the .dll file).
https://github.com/tensorflow/tfjs/issues/2003#issuecomment-695795797

I was having this blank window problem and was also able to fix it with the above fix.
I build a binary out of it with electron-packager. If you like I can send it to put it next to the Mac binaries ?

@ichingxs4all
Sure! If you send me the file I'll be more than happy to upload it to the releases. Thanks a lot!

I uploaded it to Google Drive.
https://drive.google.com/file/d/1LnORtfcH92BFE6AVqd4N2bOqmZ4yyxBf/view?usp=sharing
Please give it a try :-)

Hi @ichingxs4all , sorry for the delay, I've been busy lately.
I just added a new release with your binary: https://github.com/LingDong-/PoseOSC/releases/tag/0.0.3
Thank you very much!


Added gpm-imerg-hhr

Yeah - this is catching some kind of actual bug, I think in the tiler service or maybe the frontend (but not this branch). I'm looking into it now.

@TomAugspurger  I think you maybe branched off of main instead of develop to add this PR so it's missing some commits related to the new titiler url params, which are causing preview images not to load, and the tests to fail.

🤦yeah, I did, sorry. I'll rebase and force-push.

The missing image due to a typo in the thumbnail in the collection. I've fixed that upstream and will re-ingest the collection.


missing support for image/heif if feature with-gpl-data is used

I created a a small test at a fork: https://github.com/mbrubeck/tree_magic/commit/a27b46a3c43d22ad2d9bd8903def56cb06ed5906
$ cargo test works fine
$ cargo test -F with-gpl-data fails:
---- from_u8::image_heic stdout ----
thread 'from_u8::image_heic' panicked at tests/from_u8.rs:13:9:
assertion `left == right` failed
  left: "application/octet-stream"
 right: "image/heif"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Do you have to update magic_db? How is it possible?
Thanks in advance
Best regards
Jonas

Thanks for the report and test case!  Fixed in version 3.1.6 by updating the XDG mime data files.


[Doc Improvement] [Icon update] [2475758]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema-dev-preview.md
90
26
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
92
25
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Issue #364 - dangling tooltips

Fixes #364
Seems like this is a knows issue of ant-design when there is a Tooltip on a disabled Button, as explained here: ant-design/ant-design#9581
I've tried to replace the Tooltip with the Bootstrap one, but it doesn't work on elements that are not buttons, like a DropDown for example.
As a solution, i've hidden the tooltip if a disabled prop is passed to the render component.

Actually, i'm not so happy about this workaround as well.
I will investigate on the Bootstrap behaviour in order to find a different and more consistent solution.

I've found what was the issue with Bootstrap, so i've brought it back to the implementation of Tooltips.
Additionally, i've changed the button property to more understandable children.
Of course this means that instead of passing a button prop to the component, it will render any kind of child of himself.

@storrisi I am getting an error in ButtonWithTooltip when loading the defintiions page. It seems that children is coming in undefined. Was this working for you? Note that I did merge in the latest of master here. I'll continue to look but wanted to check. Perhaps my merge was bad

React.Children.only expected to receive a single React element child.

It's probably because of the merge of the #375 , i'm gonna update this one since something has changed

@jeffmcaffer fixed, now it should be fine, thanks for catching up


Copying pages does not update overwrite-URL

When a page is copied, the overwrite-URL is copied as well. This causes the page to stop working as there are multiple matches for the URL:
MultipleObjectsReturned: get() returned more than one Page -- it returned 2!
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "cms/views.py", line 43, in details
    page = get_page_from_request(request, use_path=slug)
  File "cms/utils/page_resolver.py", line 118, in get_page_from_request
    page = get_page_from_path(path, preview, draft)
  File "cms/utils/page_resolver.py", line 74, in get_page_from_path
    return get_page_queryset_from_path(path, preview, draft).get()
  File "django/db/models/query.py", line 338, in get
    (self.model._meta.object_name, num)

More info
Changing the overwrite URL to something different fixes the issue, however, it is very counter-intuitive for our users.
I have also seen errors in the slug generation for the same page - maybe there is an edge case connected to the overwrite URL as well?
RuntimeError: maximum recursion depth exceeded
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/utils/decorators.py", line 110, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "django/views/decorators/cache.py", line 57, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "django/contrib/admin/sites.py", line 233, in inner
    return view(request, *args, **kwargs)
  File "django/utils/decorators.py", line 34, in _wrapper
    return bound_func(*args, **kwargs)
  File "django/views/decorators/http.py", line 45, in inner
    return func(request, *args, **kwargs)
  File "django/utils/decorators.py", line 30, in bound_func
    return func.__get__(self, type(self))(*args2, **kwargs2)
  File "django/utils/decorators.py", line 145, in inner
    return func(*args, **kwargs)
  File "cms/admin/pageadmin.py", line 1030, in move_page
    page.move_page(tb_target, tb_position)
  File "cms/models/pagemodel.py", line 228, in move_page
    page_utils.check_title_slugs(moved_page)
  File "cms/utils/page.py", line 95, in check_title_slugs
    title.slug = get_available_slug(title)
  File "cms/utils/page.py", line 84, in get_available_slug
    return get_available_slug(title, slug)
  File "cms/utils/page.py", line 84, in get_available_slug
    return get_available_slug(title, slug)
...repeated

More info

The path check probably needs to be added here:
https://github.com/divio/django-cms/blob/develop/cms/models/pagemodel.py#L518
Thoughts @czpython ?

@czpython  - proposed fix: https://github.com/cnk-digital-solutions/django-cms/commit/c35ab4459dc1a20a27db029053d0de1eacbdfb92
(not thoroughly tested)

Could you guys please confirm if this is indeed a recognised issue?

@petrklus
Hey, I can confirm the maximum recursion issue.
It's preventing me from copying a page with overwrite url.
Did you use the admin UI to copy the page?

@czpython that's correct - I've used the copy function in the admin UI. Does my fix make sense? I have not had a chance to test it out properly but I do not see a reason to copy overwrite URLs, feels safe to remove to me. From the user's perspective, they copy pages to get the content, not the URL structure/settings (our users at least).

@petrklus
The proposed fix looks ok however I'd like to confirm with the others if removing the url override is the way to go. Honestly I'd like to keep the url override and treat the path the same as a slug where we add -x to the end. /cc @divio/django-cms-core

Just following up on this, is this still unresolved issue?

@czpython Any progress on this? I am getting a bit tired of explaining to our clients that they cannot simply copy any page but they need to check into overwrite URLs first.

Hello @petrklus,
I'll put this on the agenda for next week's board meeting.
Thanks for the follow-up

Thank you very much @czpython, much appreciated!

Hello @petrklus,
We had a long discussion about this.
The conclusion was to go with your suggestion (setting the override to false), there were many other suggestions but each brought on more complications.
Would you be able to contribute this with tests?

Hello,
sorry for the delay in replying @czpython - is there any quick-start guide to get me set up with Django CMS test environment? I am afraid I've not been exposed to this side much.

Hello @petrklus,
We can land this on 3.3.x and 3.4.x.
So your PR should use 3.4.x as a base.
Here's a quick guide to setting up the tests:

Fork the repo
Create a virtualenv
Activate virtualenv
Clone your cms fork
Install test dependencies (pip install -r django-cms/test_requirements/django-1.8.txt)
Go into the django-cms folder and run python manage.py test

You can find more information in our docs.

@czpython on branch develop, I am getting this when installing reqs:
You are using pip version 7.0.3, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting https://github.com/fladi/django-treebeard/archive/django-1.10.zip (from -r test_requirements/requirements_base.txt (line 5))
  HTTP error 404 while getting https://github.com/fladi/django-treebeard/archive/django-1.10.zip
  Could not install requirement https://github.com/fladi/django-treebeard/archive/django-1.10.zip (from -r test_requirements/requirements_base.txt (line 5)) because of error 404 Client Error: Not Found
Could not install requirement https://github.com/fladi/django-treebeard/archive/django-1.10.zip (from -r test_requirements/requirements_base.txt (line 5)) because of HTTP error 404 Client Error: Not Found for URL https://github.com/fladi/django-treebeard/archive/django-1.10.zip

Any tips?

@petrklus Please use release/3.4.x as the base branch.

Hello @petrklus
Thank you very much for your contribution to the django CMS project. The django CMS project has recently joined forces under the banner of the newly founded django CMS Association to revive the development of django CMS. For this reason we have analyzed all pull requests and issues in detail and decided which ones fit the product vision we want to go with django CMS.
Due to the age of this issue we are unable to safely accept the contribution. If you feel this issue is still required please inform a member of our technical committee<EMAIL_ADDRESS>Nevertheless we thank you for your participation and would like to emphasize that we do not want to discourage you in your contribution to the django CMS project. On the contrary, we encourage everyone who is interested in the success of django CMS to join us!
If you want to learn more about the work of the technical committee, our product vision and how you can become a member of the dCA, you can find all information here:

The Technical Committee of the django CMS Association
Technical Roadmap and Product Vision for django CMS
How to become a member of the django CMS Association

We are looking forward to every companion who would like to shape the future of django CMS together with us!
If you have any questions, feel free to reach out to Nicolai, our Community Manager<EMAIL_ADDRESS>Sign up for the Association now!


184409668 Mark Solution Button

PT Story: https://www.pivotaltracker.com/story/show/184409668

Adds infrastructure to add toolbar buttons that only appear the document editor and CMS CLUE widget.
Adds a mark solution button to document editor toolbars.

The button makes selected tiles switch between display: "teacher" and display: undefined. Teacher display tiles are only visible to teachers when solutions are toggled visible.

Allows document editor and CMS authors see teacher display tiles.
Adds a basic cypress test for the document editor.

I'm surprised by how bad the code coverage is for this PR. I added a new cypress test that I think should cover most of the patch, including all of the changes in src/components/toolbar.tsx, but Codecov is saying many of these lines aren't being covered. The test is in a new directory (cypress/e2e/clue/branch/author_tests), could this have anything to do with it? This test also loads the doc editor via /doc-editor.html, which might bring the doc editor to Codecov's attention and reduce the overall project coverage? But that doesn't explain the poor patch coverage.


feat(pubsub): publish with retrySettings

Addresses https://github.com/googleapis/google-cloud-php/issues/5616
Samples for other languages are published here on this doc and are present for Java, Python, DotNet.

Avro Binary tests are failing, it seems unrelated to this PR.


Off-chain changes broke offline payment Accept

Before the off-chain changes, if an order was made with the offline payment method, the merchant would have the option to Accept or Reject the order from the admin order details page.
This is currently broken, the payment is immediately marked as Paid after the order is placed.
Here are the payment statuses and actions we should support:

Payment starts as "Pending", merchant sees the option to either "Accept" or "Reject" it
If the merchant Accepts it, the order becomes "Paid". Merchant has the option to "Refund".
If the merchant Rejects it, the order becomes "Rejected"
If the merchant Refunds, the order becomes "Refunded"

@gullible1 Can you please confirm the payment status above make sense for offline payments? Thanks!

@franckc yes they make sense! For shops that have integrated Printful and have enabled manual transactions, we should probably make sure that the order is only pushed to Printful after the merchant marks an order as paid.

Thanks @gullible1 - ah yes, great point about making sure the printful order for offline payment only gets processed once the payment gets accepted by the merchant. CC @shahthepro

Sure, will make that change. @franckc


Warn about deprecated configurations like compile

Have a build script that contains compile configuration
// ...
dependencies {
    compile "com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider"
    compile "org.springframework:spring-webmvc"
    compile "com.google.protobuf:protobuf-java"

    // ...

    testCompile "com.squareup.okhttp3:mockwebserver:$okhttpVersion"

Expected Behavior

The console output warns about compile configuration, eventually linking to a guide explaining how to migrate (not just replacing compile by either api or implementation, but what to do with shared scripts, plugins, which one to migrate first if needed, etc...)
Current Behavior

There's nothing.
Context

While trying to add integration test, there's various recipes on the internet I don't know which one is the better or the future proof way. So I had to look at stackoverflow over here: https://stackoverflow.com/a/44493379/48136
Your Environment
not needed

@bric3 you nail the expected behavior here. I hope you find this new docs subsection (coming in Gradle 4.8) helpful right now: https://docs.gradle.org/nightly/userguide/building_java_projects.html#sec:java_dependency_management_overview — if not, please let us know how it could be more helpful.
@gradle/dependency-management if you intend to work on ways improve the UX as you are building so many new things, I hope you'll consider how to help users use the correct configurations in cases like this, and I would be happy for you to link to and improve this doc I linked above.

Addressed in: #9353


Update to reputation algorithm to include data quality measures.

Is your feature request related to a problem? Please describe.
The current iteration of the reputation algorithm is fairly simple and limited. It updates only Recording Oracles, not workers and does not account for the quality of the Job's results (i.e. data).
Describe the solution you'd like
Design an updated algorithm / algorithms that takes data quality into account and updates workers and recording oracles alike.
Describe alternatives you've considered
Additional context

ACCEPTANCE CRITERIA:

The algorithm's data quality metric should align with the platform's standards and user expectations.
The algorithm should efficiently handle a growing number of workers and recording oracles without compromising system performance.
Define and document the rationale behind the algorithm strategy and implementation.


Initial import

Imports common serialization logic from the main repository.
@lstrojny I need some feedback for a few things:

I removed (aka. didn't import) Base64Interface, but I am not sure about that.
What is the type of this parameter?

I am also curious about your overall feedback: package architecture, licensing, etc.

I also wonder of the exceptions are fine this way.
(For the record: my plan is to have a general interface which should be implemented on all exceptions in fXmlRpc)
I mean, not all of them are used both Parser/Serializer. I am thinking about moving them to the package where it is used and renaming from Parser/Serializer exception to InvalidType and UnexpectedTag exceptions.
@lstrojny What do you think?

Can we reintroduce the Base64Interface? It’s there so that I can implement it if I have a Base64 type already in my system

We can, but does it really make sense? I mean, why is it any better to have a custom Base64 implementation which have to implement an interface anyway than using the provided value object?

@sagikazarmark all kinds of reasons. Let’s say you have an Image object that reads from the disk and does that in streaming fashion or a binary type that already comes in a different representation that you don’t want to manually convert and so on.

Okay, I got it. Will add it back.


modulize

Modulize main function, pls recommend suggested changes.

Separating the code in main which specifies the exact -patches branch can be moved to a method.
https://github.com/red-hat-storage/rdopkg-tar/blob/main/rdopkg_tar/tar_changes.py#L185


Compare password functionality

@DerPizzaBoi, thanks for your contributions. Before I merge this though, do you agree with the license?

yes, everything is fine. Your changes also make more sense


Reduce the size of PrimitiveTypesBitMapIterator

Now it is 3 bytes, but can be two bytes if instead of range there will be u8 as an index. The iterator is only used in validators' Display and in ValidationError display, so the impact is quite small

Hi, I tried to fix this in #292. Please do share your views.
Thanks!

Closed via #292
Thanks @plaxi0s


Print

VSCode Version: 1.8.1
OS Version: Win10 14393

Please consider adding the functionality to print code

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


[Bug] OSX 11.5.1 Default Terminal Opens Multiple Windows

On Big Sur whenever you open a termina and Terminal.app is closed it opens two windows, the default one and the requested one.
On catalina it was OK.
Sublime Text 4

I experienced the same issue on Monterey.
Modifying the line 17 in file Packages/Terminal/Terminal.sh solved the issue for me.
do script "$CD_CMD" $IN_WINDOW => do script "$CD_CMD" in window 1

Same for me on Monterey.

@jefflai0101 's solution solved the problem for me on Monterey


merging analysis files when workflow name, version, sample match

Please test out the updated generate_metadata.py for correct functionality... especially with regard to merging file data that share worflow name, version, and sample.

Thanks @chkw , I'll take a look this weekend

I'm going to close this one. It will be superceded by issue #17.


UITOOL-401/make search work from results page

Proposed Changes
https://coveord.atlassian.net/browse/UITOOL-401
The search is now working from anywhere in Plasma!!
I've also added a focus and blur to hide the listbox when the input is not in focus.

/*

To toggle the feature flag, copy and paste those commands in the dev tool console:
sessionStorage.setItem('ff_plasma-search-bar', true) to show the bar
sessionStorage.setItem('ff_plasma-search-bar', false) to hide the bar
You need to reload the page for it to take effect.
*/

Potential Breaking Changes
should be none!
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Look really good! However, I have two comments/questions (of course):

Why we don't see a list that includes all the component swhen no query is send with the search bar? (it is a list of the most popular components?)

I've noticed that if I click on the X icon to clear my search filter, the results are not refreshed at the moment (I have to click on the search icon to refresh). Is it something to be implemented in the future?

https://user-images.githubusercontent.com/58052881/151038223-6ff837e0-c290-453c-aa1e-65d1ca0efe03.mp4

Look really good! However, I have two comments/questions (of course):

Why we don't see a list that includes all the component swhen no query is send with the search bar? (it is a list of the most popular components?)
I've noticed that if I click on the X icon to clear my search filter, the results are not refreshed at the moment (I have to click on the search icon to refresh). Is it something to be implemented in the future?

demo_not_refreshed_results_if_x_is_clicked.mp4

Question 1 - > https://coveord.atlassian.net/browse/UITOOL-399 :trollface:
Question 2 -> No Jira yet, this is a side effect of the onBlur() / onFocus() on the input, the X button z-index is below the input so I need to change it to be above. Sound simple but I need to tweak the css :grimacing:
The button is partially hidden below the search button see :laughing: If I put z-index=2 then the white take over the blue button XD


Add filename at Error and Warn level in logs

Description of change
Added filename (object where filename was not available) at the error level and warn level logs since these are shown by default.

Used span to add the filename on the first occurence of filename in the callstack of the method. This results in logging like -
getattr{req=3 ino=34 name=“hello_new1.txt”}: mountpoint_s3::fuse: getattr failed: inode error: inode 34 (full key “hello_new1.txt”) for remote key “hello_new1.txt” is stale, replaced by inode 35 (full key “hello_new1.txt”)

In the PR #634 , it was getting logged as -
getattr{req=7 ino=2}: mountpoint_s3::fuse: getattr failed: inode error: inode 2 (full key “hello_new.txt”) for remote key “hello_new.txt” is stale, replaced by inode 3 (full key “hello_new.txt”)

Keeping both the PRs for now, in case we dont need the way it is done in this PR.
Also, added filename in all cases of InodeError as it was getting multiple times.
Relevant issues:
#555
Does this change impact existing behavior?
No, it does not change existing behaviour of any functionalities. Only change the error logs.

No breaking changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Closing this PR as have another PR #6

I like the log entries with the field added to the span. Just a little concerned it may be difficult to enforce that we always fill it consistently.

Yes, I am filling it at the first occurence of the filename in its call stack. So, any error logged before that wont have filename filled for it.


Fix potential nullref when selecting null tabs

Any information on when/where/how this happens?

We allow selecting null tabs per https://github.com/ppy/osu-framework/blob/027f91e0a20e47680df816bebf89fc86736723b8/osu.Framework/Graphics/UserInterface/TabControl.cs#L150
I've only hit this code through testing, but from a code quality standpoint either this should exist or we should probably be allowing the above line to throw KeyNotFoundException. The below check at /blob/027f91e0a20e47680df816bebf89fc86736723b8/osu.Framework/Graphics/UserInterface/TabControl.cs#L281 would also have to go.


SampleGen: use File.binwrite for Ruby writing bytes to file

Currently:
  response = library_client.publish_series(shelf, books, series_uuid, edition: edition)

  # testing writing bytes field.
  File.open("uuid_of_series_with_book_#{response.book_names[0]}.raw", "wb") do |file|
    file.write(response.series_uuid.series_bytes)
  end

  # testing writing string field.
  File.write "series_uuid_in_plain_text.txt", response.series_uuid.series_string

Let's do this:
  # testing writing bytes field.
  File.binwrite "uuid_of_series_with_book_#{response.book_names[0]}.raw", response.series_uuid.series_bytes

  # testing writing string field.
  File.write "series_uuid_in_plain_text.txt", response.series_uuid.series_string

Maps really nicely to what we did in C# as well
File.ReadAllText / File.ReadAllBytes / File.WriteAllText / File.WriteAllBytes
@googleapis/samplegen

Moved to backlog: https://github.com/googleapis/gapic-generator/wiki/feature-backlog/


Introduce Electron 11, updates for Electron 8 and 9

Motivation for this change
Introduce Electron 11
Updates for Electron 8, 9 and 10
https://www.electronjs.org/releases/stable?version=8
https://www.electronjs.org/releases/stable?version=9
https://www.electronjs.org/releases/stable?version=10
https://www.electronjs.org/releases/stable?version=11
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Backported as 37ad3b264137d5f3bbde96a035b89d6b883b2cd5 and 9ca98ac4a119265f36ab649f9ad27bac2d98c8a0 and ef2031c419d694cf18ca135198b496ff6f9568c8.


rgb_to_cie gamma

Shouldn't it be pow(color,2.2) for sRGB data?

Thanks for the feedback.
I'm by no means an expert with sRGB color correction. But from what I understand there's no right or wrong. It depends on the viewing environments when to choose 2.2 or 2.4.
I find this article really helpful in understanding the different gamma correction values:
https://mixinglight.com/color-tutorial/gamma-2-2-vs-gamma-2-4-davinci-resolve/
For example when you have a darker room with a tablet on your wall where the colors are displayed then 2.4 is properly the better value. In a light office environment 2.2 would be better.
So I'm not quite sure what the default should be since it really depends on the use case :).


allReady called multiple times

I'm using allReady in a splash page, to then navigate to the next screen. Using a simple print while I was implementing this, I found that the print was called multiple times. I'm using injectable for convenience. Here is the generated code from injectable:
extension GetItInjectableX on _i1.GetIt {
// initializes the registration of main-scope dependencies inside of GetIt
  _i1.GetIt init({
    String? environment,
    _i2.EnvironmentFilter? environmentFilter,
  }) {
    final gh = _i2.GetItHelper(
      this,
      environment,
      environmentFilter,
    );
    final externalDependencies = _$ExternalDependencies();
    gh.singleton<_i3.AppRouter>(_i3.AppRouter());
    gh.singletonAsync<_i4.SharedPreferences>(
        () => externalDependencies.sharedPreferences);
    gh.singletonAsync<_i5.AuthModel>(() async =>
        _i5.AuthModel(await getAsync<_i4.SharedPreferences>())..init());
    return this;
  }
}

class _$ExternalDependencies extends _i6.ExternalDependencies {}

Splash page:
class SplashPage extends StatelessWidget with WatchItMixin {
  const SplashPage({super.key});

  @override
  Widget build(BuildContext context) {
    allReady(
      onReady: (context) {
        // TODO: Navigate
        print('Ready'); // Being called 3 times
      },
    );

    return const Scaffold(
      body: Center(
        child: Text('Splash'),
      ),
    );
  }
}

Logs:
flutter: Not yet ready objects:
flutter: [Object __environments__filter__ has not completed, Object __environments__ has not completed, Registered object of Type SharedPreferences has not completed, Registered object of Type AuthModel has not completed]
flutter: Ready
flutter: Ready
flutter: Ready

Let me know if there is any other information you need

For anyone wanting a workaround, you can try something like this:
import 'package:flutter/material.dart';
import 'package:watch_it/watch_it.dart';

bool _navigating = false;

class SplashPage extends WatchingStatefulWidget {
  const SplashPage({super.key});

  @override
  State<SplashPage> createState() => _SplashPageState();
}

class _SplashPageState extends State<SplashPage> {
  @override
  void initState() {
    super.initState();
    _navigating = false;
  }

  @override
  Widget build(BuildContext context) {
    allReady(
      onReady: (context) {
        if (_navigating) return;
        _navigating = true;
        print('Ready');
      },
    );

    return const Scaffold(
      body: Center(
        child: Text('Splash'),
      ),
    );
  }
}

Actually you don't use allReady() the right way It returns a Future and is meant to be used with a FutureBuilder

I want to run a side effect like Navigating. Don't think it's ideal to run it in the builder function of FutureBuilder.
The way I did it is documented here

Ah, now I understand but in your example you did do the navigation in that handler
Am 12. Jan. 2024, 12:08 +0100 schrieb Nabeel Parkar @.***>:

I want to run a side effect like Navigating. Don't think it's ideal to run it in the builder function of FutureBuilder.
The way I did it is documented here
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Yes, I did. I added a print to easily see the 2 prints in the console

Please take the following as constructive criticism / suggestions:
I do not think this is good DX. I think the point of most state management solutions is to avoid writing boilerplate-y StatefulWidgets in the first place. I would be okay with watch_it not having life-cycle hooks if it was compatible with flutter_hooks for example but it doesn't seem like the case, even when using the mixins with HookWidget.
While watch_it does technically have most if not all features you need from a state management solution, for larger apps, that boilerplate for StatefulWidgets count a lot. My ideal setup uses flutter_bloc for ease of state management, get_it and injectable for DI, and flutter_hooks for convenience on local widget state and lifecycle hooks. I think watch_it has potential. It already can be a replacement for flutter_bloc, it already uses get_it, and by extension, injectable is compatible out of the box, and with a (possible) future addition of lifecycle hooks, can be a replacement for flutter_hooks. Local widget state can also be an area where watch_it could have something similar to useState, eliminating the need for StatefulWidgets in most situations altogether. If these are addressed, watch_it can become an all-in-one state management solution.
Maybe some of these make more sense to be in separate packages to not bloat watch_it with extra stuff.
Now that said, the original issue still persists where print is being called twice, forcing a workaround as I mentioned in https://github.com/escamoteur/watch_it/issues/23#issuecomment-1877696783. What we are currently discussing doesn't really relate to the original issue. Maybe a new discussion can be spawned from this in a separate issue.

Ah, I finally think I understand your problem. it's not that allReady is called twice but that the handler function that you use is called on every build. Indeed this should be changed. It shouldn't be called again unless allReady was false (after a new registerAsync) again.

allReady now has an optional new parameter callHandlerOnlyOnce.
also the latest version as a callOnce and ondispose function


commands: require change for self-send

This adds a new LowestFeeChangeCondition metric for use in coin selection. It's the same as LowestFee with the option to only find solutions with change.
This option is then used for self-sends to ensure only a solution with change will be returned.

A sanity check failure instead? It should never happen now: we would always fail the coin selection above before.

Ah yes, that's true. I think in that case the sanity check would already catch it, as it checks for tx.output.is_empty(). So it should be enough just to remove the else if is_self_send { ... } check in the snippet above.

I've made the suggested changes and also fixed, in a separate commit, an unrelated part of documentation for select_coins_for_spend.

ACK 6123b87a024c04906338aa68c6afbcf57d57fc0b


Add new image extensions and json

Fixes #58

Log entries with some failures to use as test candidates: link
Selected 4 HARs, copied two mobile and two desktop HARs to a testing area: link
Successful batch job, without warnings for Unexpected type, found format:avif: link

So I'm good to merge? Or wait for one of you to do this?


Missing cancel button in progress monitor dialog during opening of traces

The cancel button of the open progress monitor is missing with the version in master of today (SHA 31dac5d9b39360b3fe8e52df227d5d1d9fabb5e8):

It seems to happen due to the upgrade from Theia 1.6.0 to 1.10.0 done as part of pull request #205. See trace-viewer.tsx where the progress monitor is created. @marechal-p any ideas on how to fix it?

The fix was accidentally removed by a later patch #248


Compatibility With MacOs Big Sur

Hi !
I used to work with S2L on Mac and it's awesome !
But when i updated my Mac to Big Sur OS, It doesn't work anymore... Do you think that you'll update it ?
Thank You

When I say It doesn't work anymore, I mean that the Software doesn't open...
Thank You !

When I say It doesn't work anymore, I mean that the Software doesn't open...
Thank You !

Any news about?

I have a new M1 Mac, so I have to use Big Sur. Is there any chance that it will work anytime soon? I get the "splash screen" (the app icon) then the app asks to allow mic acces. After that step it freezes.

Unfortunately I'm not working on or maintaining Sound2Light anymore. Either someone from ETC creates a new build or you could use Luminosus instead, it provides very similar functionality but in a totally different user interface. Fortunately someone made it working for Big Sur: https://github.com/ETCLabs/LuminosusEosEdition/issues/34#issuecomment-840472065

Hi Tim,
The problem is the same like Luminosus, it doesn't work on newer macOS versions. Hans Leiter told me that a further development will only happen if they found a student employee who want's to restart the project.

Hi @sstaub, Luminosus actually works on Big Sur and even M1 Macs, thanks to @xhpohanka. See the comment that I linked above for where to download it. Maybe @xhpohanka can do the same for Sound2Light.

Hi @luminosuslight,
I indeed sometimes play with Luminosus and I'm able to provide actual builds (without installers, but I also think if someone is not able to use sw without installer, then Luminosus is not a right tool for him).
It would be nice to put a link to my github to luminosus.org with a notice that new builds can be occasionally found there :-). People are confused now and think that the project is dead.
I don't know nothing about Sound2Light now.

Thanks @xhpohanka for this suggestion, I just put a link to your GitHub releases page on the webpage!
For now, it still says its not maintained anymore because I guess you don't want to offer actual support for it regularly. Although of course I would be happy to hand this over to you completely if you like 💁♂

As an advice, the macOS version from @xhpohanka works also on macOS Monterey, great.

Hi, great news to hear that Luminosus was revived despite previous posts on the website that development was halted. I will give it a try and hope you all feel how much your work is appreciated by the lighting community. Thanks a lot!

I was trying if my bigsur virtual PC still works and it does. If @fganzevoort or any other want to try, this was built there https://drive.google.com/file/d/19hFBovc_clhk3aZAD5e2As3b4HukfRu9/view?usp=sharing. No testing on my side, thouhg.

@xhpohanka thank's for your experience

It is possible to start the app
there is no access to the Microphone, that is the main problem because of right management, the same problem with luminosus
luminosus ask for network communication, S2L not
missing icon

@xhpohanka, thanks a lot for trying to keep these programs alive !
Nothing else to say than @sstaub.
If it can help, the microphone detection works well on the <IP_ADDRESS>.0.9's version of S2L (Actually on Monterrey)

@MrDjeep thank's for the advice, it seems v<IP_ADDRESS>.0.2 is wrong compiled for macOS.


Matching!

Carrying this over from this conversation: https://github.com/ppact/processing/issues/1
The overview of the problem is as follows. We are looking to match two datasets that have time-series data that require exclusivity. Below are a few examples:

A record in dataset 1 with a date of 2016 cannot match to a record in dataset 2 with a date of 2017 if the record in dataset 1 also has dates in 2017 and 2018. The record in dataset 1 is considered exclusive to that dataset from 2016 through 2018
A record in dataset 1 with a date of 2016 can only match to a record in dataset 2 if the record in dataset 2 has no known history before 2016. We say the record in dataset 1 transferred to dataset 2 in 2016 or later.

We have outlined two possible approaches. They are listed in order of simplicity/priority:

We add a filtering step between indexing and matching. The filter step removes items that cannot be matched before matching takes place
We extend the indexing to create a multi-index that includes a matching date logic of some sort, as described in the examples above

@pckhoi, One question. There is a directionality to all of this based on time and I think we should make this uni-directional, correct? That is to say that in our case possible match constitutes that a record in dataset 1 transferred to dataset 2 (going forwards) but we shouldn't also get a possible match from a record in dataset 2 having come from dataset 1 (going backwards).
I think that's  everything from our convo, let me know if I missed anything.

Wrote a simple test using the event data to see how impactful this could. Here are the steps:

Split the event table into an agency and all other agencies
Created a time censored dataset, where a time censored match is when the max date from the first dataset is less than the min date from the second
Compared the total number of possible matches vs the number of time censored matches

The time censoring  reduced the number of possible matches by over 80% on average, which makes me think that we should definitely see some benefit from this even if the median officer only has 3 events to their name.

Do you want to make the first stab at writing a new index for this?
Either way we should wait, I'm making some breaking changes to add deduplicating functionality (#2). Index should be significantly simplified after this.


Why?

Why would you want to do this as part of Solid? Why not rely on an existing certified OIDC Node library/client e.g. https://github.com/panva/node-openid-client  and spend resources to develop/maintain this code on the core project instead?

@zandbelt - always a good question! Don’t worry, the Solid devs are always careful to do prior art research and use available components whenever possible.
At the time when we were implementing Webid-OIDC, there were no other libraries that worked both on the server (in Node.js) and in the browser (using the Web Crypto API). (Plus we were under a requirement to also use and embeddable OP library in the server.)
This RP library could be OIDC certified, we just never got around to it.
Since that time, at least one other library has been developed that might meet our criteria. We’re actually currently investigating which of those libs we can just use, so that we can maintain the least number of libs possible just like you said.

Closing this issue. (https://github.com/panva/node-openid-client is for Node only, not for browsers.)


Add deferred weight reader pointer when initializing the graph

To add offline tensor support.

@gcatron

I'm sorry, but wouldn't this commit(as well as 8015abb7) cause conflict between header declaration and source file definition conflict for onnxInitGraph? FYI both difinitions of onnxifi_dummy.c#L99 and onnxifi_wrapper.c#L757 are conflict with this modified function signature declaration


Remove add1 usage

The add1 function takes an integer and returns the value + 1. This is currently used in 6 places in _helpers.tpl, including here:
https://github.com/redpanda-data/helm-charts/blob/899400cd9fdbed3ea398d7db6d1ff78856c2bcc0/redpanda/templates/_helpers.tpl#L175
The issue is that this isn't explained to the user, and it assumes that port will be available in the user's cluster. Instead, this port should be defined in values.yaml and the user can then have more control over their environment's used ports.

fixed in #122


Add quoting to README

The initial impression that loop --num 3 -- echo $COUNT gives is that it must work some kind of shell magic to get $COUNT to work. This change quotes the examples in README.md to make loop's behaviour more clear.

Nice to see this project get traction again. :)

The biggest issue was that I didn't have a computer capable of running it any more because of Rust/OSX version compatibility.. I got a new computer. Expect a release soon once all these outstanding PRs get merged. Also looking for maintainers, if anybody else wants to volunteer!


DOC: linalg: tweak the docstring example of svd

Too fast merge --- refguide_check seems to complain now that it works again:
https://travis-ci.org/scipy/scipy/jobs/228089360#L3160

Aargh. Fix in #7370


Functions are not visible

When I try to execute given example under the "Parametrize a mesh and export it" section I encountered with following error:
line 12, in
vmapping, indices, uvs = xatlas.parametrize(mesh.vertices, mesh.faces)
AttributeError: module 'xatlas' has no attribute 'parametrize'
I both tried to install directly from pip and also clone the repo.

Hi,
can you provide more details like OS, Compiler and Python version?


Spevacus: Watch webcontentonline.com

Spevacus requests the watch of the watch_keyword webcontentonline\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

webcontentonline\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by NobodyNada in Charcoal HQ


Edit: ABS-CBN Sports+Action Global batang Quiapo

Channel ID (required)
ABSCBNSportsPlusActionGlobal.ph
Channel Name
ABS-CBN kapamilya channel
Alternative Names
Tagalog
Network
50
Owners
No response
Country
No response
Subdivision
No response
City
Isulan
Broadcast Area
No response
Languages
No response
Categories
No response
NSFW
None
Launched
No response
Closed
No response
Replaced By
No response
Website
No response
Logo
No response
Notes
No response

May 5, 2020; 4 years ago (legislative franchise lapsed) December 2, 2020; 3 years ago (international)
OK, channel is closed. But this isn't Kapamilya Channel. Closest encounter I have is this : https://en.wikipedia.org/wiki/Aliw_Channel_23. No digital channel replacement (all channels have closed), though the spot S+A had is now taken by ALIW Ch. 23

May 5, 2020; 4 years ago (legislative franchise lapsed) December 2, 2020; 3 years ago (international)
OK, channel is closed. But this isn't Kapamilya Channel. Closest encounter I have is this : https://en.wikipedia.org/wiki/Aliw_Channel_23. No digital channel replacement (all channels have closed), though the analogic channel number S+A had is now taken by ALIW Ch. 23

Can be closed due to invalid data?


Is lfs_dir_read/seek/rewind useable if there is changes to the content of the dir?

So I have need to implement recursive delete of files and directories in path. It would be quite helpful if the functions that operate on directories told if the lfs_dir_t and struct lfs_info data from them are still useable if you make changes inside the directory. Say if I remove a file from directory, can I still continue iterating over the directory with lfs_dir_read? Do I need to close the directory before opening a child directory?

Seems to have worked fine for me, although I've not used the function heavily. My code calls it through the universal 'readdir()' function, so there may be a few other bits of code in the way

Yes. There is actually an explicit test for this, see [here]. And I know that some rather critical software depends on this.
It's a fascinating requirement from a design standpoint, a CS purist would argue it should be undefined behavior, but then how the heck are users supposed to delete stuff in directories.
This works because keeps track of all open lfs_dir_t/lfs_file_ts in a linked-list and updates their state when lfs_remove or other metadata changing operations are called.


Replace all occurrences of MusicNotationKit with MusicNotationCore

Simple search and replace from issue #112

Happy to have you helping out! Feel free to reach out if you’d like to join the Slack or discuss anything.


Added Markdown formatting to examples/mnist_acgan.py

Summary
This PR adds Markdown formatting to examples/mnist_acgan.py.
Result:

Related Issues
#12219
PR Overview

[ ] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Thanks!


Consume .NET nightly builds

Update to the latest nightly build of .NET 9.

@costellobot rebase

@costellobot rebase

@costellobot rebase


ERROR in AppModule is not an NgModule

The following error when trying to build with yarn.
[INFO] ERROR in AppModule is not an NgModule
[INFO]
[INFO] ERROR in ./src/main.ts
[INFO] Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in 'C:\Users\vepatti\IdeaProjects\wom-docflow\src\main\frontend\src'
[INFO] @ ./src/main.ts 4:0-74
[INFO] @ multi ./src/main.ts
yarn version: 1.6
node version: v8.9.1
pom

package.json
"dependencies": {
"@angular/animations": "4.3.1",
"@angular/common": "4.3.1",
"@angular/compiler": "4.3.1",
"@angular/compiler-cli": "4.3.1",
"@angular/core": "4.3.1",
"@angular/forms": "4.3.1",
"@angular/http": "4.3.1",
"@angular/platform-browser": "4.3.1",
"@angular/platform-browser-dynamic": "4.3.1",
"@angular/platform-server": "4.3.1",
"@angular/router": "4.3.1",
"intl": "^1.2.5",
"ng2-translate": "5.0.0",
"node-sass": "4.10.0",
"primeng": "4.2.2",
"rxjs": "5.1.0",
"typescript": "2.2.2",
"underscore": "1.8.3",
"zone.js": "0.8.5",
"file-saver": "^1.3.3",
"jspdf": "1.4.1",
"html2canvas": "1.0.0-alpha.12"
},
Even If I do yarn install and then ran yarn run build on the command line directly, instead of via this plugin, I got following error

Note: Doesn't get this error if i use npm.

Closing as it doesn't follow the issue template.


Fix rtl display issues

https://uktrade.atlassian.net/browse/CMS-61
the copyright warning in the footer does not have translations afaik so direction is set to ltr to avoid symbols/punctuations being misplaced. if we get an arabic translation for this in future it will need updating
bug:

fixed:

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   94.12%   94.12%
=======================================
  Files          23       23
  Lines         528      528
=======================================
  Hits          497      497
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 787823e...60c216d. Read the comment docs.


Create basic Memers controller & model

Read through the course textbook and work slowly through the examples for creating basic routes, controllers and views for the Memers model. Do this instead of just generating a scaffold so that you can learn how to do the basics and pick up all the things you may have missed.
This will lead into creating the OAuth

New memer functionaility via: 19c2bcc0e98d5f406baa620d697d32deade4ca3a


Memory leak

Here you have instances array, and actually instances are only pushed to it and not removed on dispose. The element is still referenced from instance, and this leads to memory leak.
In my app, I've noticed that subsequent inits and disposes don't free consumed resources and resolved it with removing from baron._instances.
Please consider removing from instances on dispose call.

Thanks! It seems reasonable.


Savoir TypeError: 'module' object is not callable

Hi,
I would like to experiment with multichain in Python, but I just cannot figure it out. It always raises the TypeError: 'module' object is not callable error, I checked on stackoverflow, where the solution is the "from Savoir import Savoir" statement, but it doesn't have any effect. I use Python in the Anaconda environment, version 3.5. I saw that you recently updated the code to Python 3 version. When I try to run the example:
from Savoir import Savoir

rpcuser = 'multichainrpc'
rpcpasswd = password from the config file
rpchost = ip address
rpcport = '2765'
chainname = 'chain1'
api = Savoir(rpcuser, rpcpasswd, rpchost, rpcport, chainname)
print(api)
api.getinfo()

Traceback (most recent call last):
File "", line 1, in
runfile('O:/blockchain/savoirtest.py', wdir='O:/blockchain')
File "C:\Users\pk\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\site\sitecustomize.py", line 880, in runfile
execfile(filename, namespace)
File "C:\Users\pk\AppData\Local\Continuum\Anaconda3\lib\site-packages\spyder\utils\site\sitecustomize.py", line 102, in execfile
exec(compile(f.read(), filename, 'exec'), namespace)
File "O:/blockchain/savoirtest.py", line 24, in
api = Savoir(rpcuser, rpcpasswd, rpchost, rpcport, chainname)
TypeError: 'module' object is not callable
Thanks in advance!

Hi @Fulcrum11 try to remove the following line
print(api)

and just use the api.getinfo() call
How did you install the package? cloning the repo from github or with pip?
FYI i've personally never tested in windows environment

Hi @reiven , I have installed it via pip.
The problem is at the Savoir(rpcuser, rpcpasswd, rpchost, rpcport, chainname) line, removing the print() doesn't change the result.
Now I tried in Python2.7, and it works, so it must be an issue of Python3.

Just adding a note, this is same issue as issue #4
Workaround as suggested there works for me:
Change import line to:
from Savoir.Savoir import Savoir

Thanks for the suggestions, i'll check it

has anyone resolved this issue?


Allow react element as column name

...without having to manually declare header cells.
Description

See JENKINS-41833.

Submitter checklist

[X] Link to JIRA ticket in description, if appropriate.
[ ] Change is code complete and matches issue description
[ ] Appropriate unit or acceptance tests or explanation to why this change has no tests

Reviewer checklist

[ ] Run the changes and verified the change matches the issue description
[ ] Reviewed the code
[ ] Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

:bee: if you trust my judgement


Fix for multiple spirals on map

This PR fixes #177 , where Markers of spirals (markers with the exact same position) are duplicated to every other Spiral on the map. Currently, the only way to update a certain spiral is by pressing the cluster.
This also leads to the problem, that markers are displayed on the wrong position if there are multiple potential spiral clusters in the currently viewed area of the map.
With the fixes in this PR, it is possible to show the right markers on the spiral without having to press the cluster before.
Let me know if you need more information on the changes. :)

I implemented those changes in 3.4.0 version of library.
Thank you so much for contributing 💕

I implemented those changes in 3.4.0 version of library.
Thank you so much for contributing 💕


无法保存文件，unocss似乎阻塞了

UnoCSS version
0.62.3
Describe the bug
正在保存“uno.config.ts”: 从 "'JavaScript 和 TypeScript 的语言功能'" (configure)中获取代码操作。
长时间卡在此状态
Reproduction
antfu.unocss-unresponsive.cpuprofile.txt
System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

似乎是其他进程的阻塞


Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Mac OS
pake https://xxx.com --name xxx --transparent --icon static/img/bleve.png
up to date, audited 235 packages in 1s
76 packages are looking for funding
run npm fund for details
found 0 vulnerabilities

<EMAIL_ADDRESS>build
npm run tauri build --release

<EMAIL_ADDRESS>tauri
tauri "build"

Updating crates.io index

error: Unable to update registry crates-io
Caused by:
failed to fetch https://github.com/rust-lang/crates.io-index
Caused by:
failed to authenticate when downloading repository<EMAIL_ADDRESS>
attempted ssh-agent authentication, but no usernames succeeded: git

if the git CLI succeeds then net.git-fetch-with-cli may help here
https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli
Caused by:
no authentication available
Error failed to build app: failed to build app
file:///usr/local/lib/node_modules/pake-cli/dist/cli.js:1793
reject(new Error(${code}));
^
Error: 1
at file:///usr/local/lib/node_modules/pake-cli/dist/cli.js:1793:24
at /usr/local/lib/node_modules/pake-cli/node_modules/shelljs/src/exec.js:145:9
at ChildProcess.exithandler (node:child_process:406:5)
at ChildProcess.emit (node:events:526:28)
at maybeClose (node:internal/child_process:1092:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

错误在这里failed to fetch https://github.com/rust-lang/crates.io-index
谷歌搜索设置国内 rust 镜像即可

   Compiling app v0.1.0 (/usr/local/lib/node_modules/pake-cli/src-tauri)
    Finished release [optimized] target(s) in 14.50s
    Bundling 51pwn.app (/usr/local/lib/node_modules/pake-cli/src-tauri/target/release/bundle/macos/51pwn.app)
    Bundling 51pwn_1.0.0_x64.dmg (/usr/local/lib/node_modules/pake-cli/src-tauri/target/release/bundle/dmg/51pwn_1.0.0_x64.dmg)
     Running bundle_dmg.sh
       Error failed to bundle project: error running bundle_dmg.sh: error running bundle_dmg.sh: `failed to run /usr/local/lib/node_modules/pake-cli/src-tauri/target/release/bundle/dmg/bundle_dmg.sh`
file:///usr/local/lib/node_modules/pake-cli/dist/cli.js:1794
                reject(new Error(`${code}`));
                       ^

Error: 1
    at file:///usr/local/lib/node_modules/pake-cli/dist/cli.js:1794:24
    at /usr/local/lib/node_modules/pake-cli/node_modules/shelljs/src/exec.js:146:9
    at ChildProcess.exithandler (node:child_process:406:5)
    at ChildProcess.emit (node:events:526:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Socket.<anonymous> (node:internal/child_process:451:11)
    at Socket.emit (node:events:526:28)
    at Pipe.<anonymous> (node:net:687:12)


Unable to reserve an epoch entry

Hi,
This might be related to the question asked by some other user about where data is stored. I don't see the log files getting created.
But the program runs and it was processing my computation. I am doing some analysis that generated a million records in a tree form. I am using FASTER to both store the records and the index (additional records added to overcome the fact that faster doesn't have build in indexing).
But I see the below exception after some time.
Unhandled Exception: System.AggregateException: One or more errors occurred. (Unable to reserve an epoch entry, try increasing the epoch table size (kTableSize)) ---> System.Exception: Unable to reserve an epoch entry, try increasing the epoch table size (kTableSize)
   at FASTER.core.LightEpoch.ReserveEntry(Int32 startIndex, Int32 threadId) in D:\a\1\s\cs\src\core\Epochs\LightEpoch.cs:line 325
   at FASTER.core.LightEpoch.ReserveEntryForThread() in D:\a\1\s\cs\src\core\Epochs\LightEpoch.cs:line 346
   at FASTER.core.FasterKV`6.InternalRefresh() in D:\a\1\s\cs\src\core\Index\FASTER\FASTERThread.cs:line 49
   at FASTER.core.FasterKV`6.InternalAcquire() in D:\a\1\s\cs\src\core\Index\FASTER\FASTERThread.cs:line 29

Please refer to the response here for help with log creation.
How many threads are you using with FASTER? The code assumes an upper limit, defined here.
I would try to make sure you are not creating too many threads to use with FASTER. If you are sure you need more than the number of threads specified in the limit above, you may increase the limit (in powers of two).

Thanks Badrish.
I am not creating threads. I am using task parallel library. Parallel.Foreach on an IEnumerable. Then I process each record which creates multiple entries and in turn processes each of them an so on. Think of doing graph search on a graph of unknown size.
Based on your explanation, I think TPL is creating more threads than the upper limit of FASTER.
I will do a work around and see if this error goes away.


Fix line counting

Instead of skipping every other char (and thus possibly newlines), skip only immediately after a newline.

Also cr needs to be an int not a char if you want to reliably store EOF (notice that getchar() returns an int and not a char specifically due to this reason). More detailed info: https://c-faq.com/stdio/getcharc.html


[Clarification] Issue Field History restarted to To Do status after resolved

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
Since I could not find the Fivetran community forum, I posted this issue here.
Why does the issue_field_history table continue recording "changes" if the issue has already been closed?
It seems like the status was reset to To Do status.

Relevant error log or model output
n/a

Expected behavior
I expect the issue_field_history to stop recording the issue since the ticket status has not changed.
dbt Project configurations
  jira:
    +schema: fivetran_jira

Package versions
packages:
  - package: dbt-labs/dbt_utils
    version: 1.0.0
  - package: brooklyn-data/dbt_artifacts
    version: 2.2.2
  - package: data-mie/dbt_profiler
    version: 0.8.1
  - package: fivetran/zendesk
    version: 0.12.0
  - package: dbt-labs/audit_helper
    version: 0.7.0
  - package: get-select/dbt_snowflake_monitoring
    version: 5.0.3
  - package: fivetran/jira_source
    version: [">=0.7.0", "<0.8.0"]
  - package: fivetran/jira
    version: [">=0.17.0", "<0.18.0"]

What database are you using dbt with?
snowflake
dbt Version
root@82b6a9e763a1:/app/data_marts# dbt --version
Core:
  - installed: 1.6.9

Additional Context
We are running  DBT CLI in AWS ECS
Are you willing to open a PR to help address this issue?

[ ] Yes.
[ ] Yes, but I will need assistance and will schedule time during our office hours for guidance
[X] No.

Hey @dennysrega1ado thanks for opening this question. This issue is a great place to ask the clarification question!
I have seen this behavior in other environments when some tickets are prematurely resolved and then moved back into an active ticket. For example, at the end of the day someone accidentally marks the ticket resolved, but then switches the status back to TO DO. This will update the status, but the resolved date will be unchanged.
For this ticket, are you able to confirm if a similar behavior is seen within your Jira application? Alternatively, you may be able to see this in the underlying source issue_field_history table for this ticket; however, you will only see status IDs and whatnot.

🤔  Hi @fivetran-joemarkiewicz
Thanks for the quick response.
The underlying table doesn't seem to describe that behavior.

I ran the full-refresh on jira__daily_issue_field_history and the issues have gone.

Checking the underlying table ISSUE_FIELD_HISTORY, the latest change occurred when the ticket was closed on July 5th.
As far as I know, I can't check historical changes over this ticket using JQL in Jira UI.
Is there an easy way to check log changes?
select
    issue_id, time,
    field_id,
    value,
    IS_ACTIVE
    from pangea.jira.ISSUE_FIELD_HISTORY
where
 ISSUE_ID= 68470
order by time desc;

Thanks for sharing @dennysrega1ado and I would agree that this does seem to be an incremental issue as it was able to be accurately resolved following a full refresh.
I still am not exactly sure where the issue may be originating. However, I am going to try and setup a test scenario on my end to try and recreate the issue you saw previously. From there I should be able to see if I can recreate the issue and then triage further from there to see what possible updates we need to apply to the underlying model code.
I'll be sure to report back once I am able to recreate the issue and if I find any leads. Feel free to share any other insights in the meantime or if you start to see this issue on another ticket.

@dennysrega1ado I attempted to recreate the issue locally, but was unable to obtain the same results you shared. I know these issues have resolved following the full refresh, but are you seeing any others since then?
Additionally, was this a widespread issue or was this only impacting a few issues in your Jira instance?

Hi @dennysrega1ado ! It seemed that the full refresh resolved this issue, but wondering if you've seen it pop up since then as well.

Marking as stale since we've been unable to recreate the issue. If anyone else comes across this issue feel free to post in this thread and we will reopen.

Hey @fivetran-reneeli, @fivetran-joemarkiewicz
It happened again and the full-refresh fixed it.
I'll troubleshoot it and let you know my findings.

Thanks @dennysrega1ado for reaching back out and informing! Keep us updated!

do you think upgrading to 0.18.0 will fix this issue or is unrelated?

Hi @dennysrega1ado, the v0.18.0 release definitely may help, due to the lookback window now spanning 1 week vs a few days. But we'd have to know more about the specific root cause of the issue before suggesting any other solutions.


Provide "Deploy to Azure" capability

Provide "Deploy to Azure" capability to provision all required Azure resources

Given there is no more development this is no longer required and I'm closing it.


Do something with primary_assembly vs toplevel

Top-level assembly sequence should be OK.
https://www.ncbi.nlm.nih.gov/genome/doc/ftpfaq/

The genomic.fna.gz file includes all top-level sequences in the assembly (chromosomes, plasmids, organelles, unlocalized scaffolds, unplaced scaffolds, and any alternate loci or patch scaffolds).


Replace PicardToolsMarkDuplicates for whole genomes

Often failing due to time limits

PicardToolsMarkduplicates has been replaced by Sambamba.
PicardToolsMarkDuplicatesForQCMetrics has been removed.


Add a "licence" filter on the search page

Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
On the search page, we would like to able to filter courses by the licence of their content.
Describe the solution you'd like

[ ] Add a "short_name" field to the Licence model for use on the filter. (we could set it to values of the form CC-BY, CC-BY-NC, etc.)
[ ] Add license field on the course search index using "short_name" as a token
[ ] Add a licence filter to the search page

Done in #1728

As it turns out, we might really need to add a short name just for use as a human name instead of the actual title. As for the token, we can keep using the ID.


Petition share links for redesign

On the thanks page, share links should be carried over from the legacy implementation.  Note that share links on that version are calculated partially from data gotten from the signature POST.
On the petition page itself, the new design includes four links:

[ ] Facebook share - if there is a sharebandit url, upon clicking the link it should get getSharebanditShareLink the same way the thanks page does (ideally not before).  If there is no sharebandit link, it should be the standard facebook petition link, but with source=n.fb.p where n is for "non-signer" and .p is for the petition page.  Note that if the client 'knows' that the user is the creator or has signed the petition, then you can/should replace n. with either c. or s. appropriately
[ ] Twitter share - This should use the lib petitionShortCode url, with mode=n.  Note that if the user is logged in or has guest credentials (e.g. akid, etc), then you can/should pass in the userId
[ ] Email share - This will be the same thing as the thanks page except the link will be source= n.mt.p (unless it's meant to be copy-pasted, in which case n.cp.p)
[ ] Copy Link share should be the same think as rawShareLink but with mode=m for a non-signer (keep the other two, if they are known creator/signers, but don't hit an additional api to find out).

See this PR and the full shortcodes file for short-code related questions.
Also update docs/EXPLANATION-share-links.md

For the sign page we might want a slight rephrasing of the mail message, it currently says

That's why I signed a petition to President Donald Trump, The United States House of Representatives, and The United States Senate, which says:

For email share on the thanks page we have something like source=s.em.mt. Did you drop "em" on purpose above for the petition page? If I kept it, it would be like n.em.mt.p

that was a mistake.  do n.em.mt.p

Thanks! Last question I think: should we also recordShareClick() for the sign page?


Add license information

Hello!
I found link to this project from https://hackaday.com/2021/07/11/digital-audio-for-microcontrollers-doesnt-come-much-simpler-than-a-wart/
Could you please add information about license of this repository — is it allowed to copy, change and use the code and images in any purpose?
It would be great to see any popular open source license.

Good catch -- I added an MIT License to the repository and to the Hackaday
project page.  So: have fun with it!
Thank you.

R. D. Poor

On Mon, Jul 12, 2021 at 1:09 AM Alexey Vazhnov @.***>
wrote:

Hello!
I found link to this project from
https://hackaday.com/2021/07/11/digital-audio-for-microcontrollers-doesnt-come-much-simpler-than-a-wart/
Could you please add information about license of this repository — is it
allowed to copy, change and use the code and images in any purpose?
It would be great to see any popular open source license.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rdpoor/WART/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANWQQOBN6SRT7X6GXOXH2LTXKPNFANCNFSM5AGKDRYQ
.

MIT — great!
@rdpoor, thank you very much!


Godot crashing upon startup

Godot version:3.0.2
**Windows 10 **
**NVIDIA 1070 on driver version:  391.01 (and previous versions)
Godot crashing upon startup
Upon starting up Godot with a fresh new download everything will work properly. Once I create a project, close Godot and try to launch Godot again, it will crash upon initializing graphical settings/ hardware information.
I am aware this isn't a common issue but it has been frequent with some users.

I have also found a solution. Once Geforce overlays are disabled AND Discord is closed and doesn't have a process anymore, Godot will running properly. Something about Discord hooking into the Godot process is causing it to crash.

Probably related to #17157 and #17575 (amd but who knows).

@girng
No, no third party anti-chat program.
@eon-s
There is no error log for this as it's an instant crash.

I'm often running Discord along with Godot with no problems (but I have game integration/overlays disabled)

Strange, now it’s crashing again even with discord closed. I don’t know what’s causing the issue anymore.

Upon further research I have found some dump files. The exception is 0xE0464645, and in dissasembly RaiseFailFastException is being thrown and stops at a compare pointer BaseIsSecureProcess.

Alright, I found solution finally. This issue is a pushed updated from Intel about spectre. There were a lot of reports that their update corrupted a lot of files and this includes even system files. To see what files are corrupt you will need to run an SFC scan and fix your corrupted files. (If you're lucky like me you will have had corrupted graphics drivers causing the issue with Godot not starting properly.) I have ran Godot 15 times now and it hasn't crashed again since then.

Welp, that's great to hear! I have seen audio drivers crash thanks to all these "proper" spectre patches, but it's the first time I heard about graphics drivers getting corrupted. Good to know.

SFC scan didn't find any errors her, and Godot still crashed ramdomly.
Then I updated my gfx drivers (gtx1070) from 391.24 to 391.35,
and my sound drivers just for good measure.
And something there seem to have fixed the crashing here also.

Same thing for me. Sometimes I got past the launcher, but most of the time Godot just crashes right away. Downloaded and run Godot via Steam.
System Specs:

Intel i7-7700HQ
Nvidia GeForce GTX 1070 (Notebook)
8 GB RAM
Windows 10x64  Build 10.0.16299.309

It's impressive how broken Windows 10 can get each time they push an update..

Getting crashes (about 80%+ of the time) at launch with 3.0.2 on windows 10.0.16299.371, sometimes it will crash after hitting play also (around 50%). System has 32 GB ram and a nvidia 1070, i7 6820HK proc.

And update from me:
Today after installing yet another big update from Microsoft, version 1803 build 17134.1
and updating nvidia drivers to 397.31.
The crash problem have fixed itself.

None of the above solutions worked for me. the only thing working is switching to linux :)

Sadly I don't see anything that we could debug further/try to fix in Godot here, it seems to be official Windows 10 updates breaking the system and causing Godot to crash.
As such I'll close the issue as there's nothing we can do to solve it. Godot 3.1 might alleviate the issue with OpenGL 2.1 support, as I suspect issues arise with bogus OpenGL 3+ support in many Windows drivers.


Add .NET templating alpha library

Adds a .NET templating library. It's simply a wrapper on top of the JS library.
Added to the experimental folder so it doesn't impact anything else.
Note that it required updating the JS library webconfig to use this for it's umd configuration (so that it's usable both by browsers and node.js and native JS clients like .NET)
AdaptiveTransformer transformer = new AdaptiveTransformer();

string jsonTemplate = @"{
	""type"": ""AdaptiveCard"",
	""version"": ""1.0"",
	""body"": [
		{
			""type"": ""TextBlock"",
			""text"": ""Hello, {person.firstName}!""
		}
	]
}";

string jsonData = @"{
	""person"": {
		""firstName"": ""Andrew"",
		""lastName"": ""Leader""
	}
}";

// The final JSON, it'll have "text": "Hello, Andrew!" in it!
string cardJson = transformer.Transform(jsonTemplate, jsonData);

Microsoft Reviewers: Open in CodeFlow

@matthidinger @dclaux this is ready to go! With this, we'll have a .NET NuGet version of the templating library (using the JS library under the scenes), fully identical to what the JS library supports!

Checking this out now... I'd like to learn more about the umd issue before merging it in. We've got some many webpack configs and if at all possible I'd like to keep them consistent. Can you link to details or explain more about the issue it was hitting?

I think we can merge this PR in but I'd like to request some small changes:
For API consistency across the Templating SDKs

Rename AdaptiveTransformer to AdaptiveTemplate
Rename the method Transform to Expand
Add the ability to register custom functions. This is crucial during the early phases where we are still determining the baseline set of functions across the SDKs.

Here's the custom function syntax in JS. The C# API should call into this;
// Register a custom "add" function that adds two numbers
context.registerFunction(
    "add",
    (a, b) => {
        if (typeof a === "number" && typeof b === "number") {
            return a + b
        }
        else {
            return undefined;
        }
    }
)

@nesalang working on porting this and will open a separate PR for this. closing this one for now. @nesalang / @andrewleader / @matthidinger  FYI


[FEATURE] consider to relax Python 3.9 requirement.

Is your feature request related to a problem? Please describe.
Let's make it Python >=3.8

Even better to mark it as Python >= 3.7


[Request]: Detect control files and automatically check for correspondence

Describe the request
Hello,
Would it be possible to implement a function that automatically detects the checksum file associated with a given file, opens it, extracts the string corresponding to the checksum and automatically compares it to the checksum file?
Let me explain:
Suppose I open a "linux.iso" file to calculate its checksum.
Let's imagine that next to it is the file "linux.iso.sha256" or "linux.iso.sha256sum", which is not uncommon, since the two files are often downloaded from the same web page, with the two links next to each other.
It would be very useful to automatically detect whether such a file exists next to the open file. Open it, extract the result (often files contain [result sha256]\t[filename, here it would be "linux.iso"] or the reverse order [linux.iso]\t[result sha256].
In short, adding a condition of this style to the opening of a :
input_file = "linux.iso"
control_file = ""
if input_file+".sha256" exists :
    control_file = input_file+".sha256"
if input_file+".sha256sum" exists :
    control_file = input_file+".sha256sum"
if control_file != "" :
    content = read(control_file).split("\t")
    if content[0] == input_file :
        digest = content[1]
    else :
        digest = content[0]
    #when calcul input_file digest, verify if corresponding to readed digest, without others manipulations users.

Thank you for everything you can do!
Implementation Details

[X] This follows the GNOME HIG.

Thanks for the suggestion!
The main blocker for this is flatpak / portals. Collision can't access the whole folder but only the selected file.
I believe there was a work-in-progress portal to open neighboring files but it's not done yet.
In the meantime, if you select the text file with the hashes in the "Verify" tab, Collision will actually look inside of it and check if any hashes match:

(notice that the open file is a .iso while the one in the verify tab is a .sha256)


Update LDAP TLS certificate

keyword_TIWG resolution_fixed   |    by<EMAIL_ADDRESS>
Via Chris: NCI's LDAP certificate expires 2015-06-05

Issue migrated from trac:186 at 2024-01-31 18:12:39 +1100

<EMAIL_ADDRESS>commented

No issues with certificate on dev-test, will apply to production

<EMAIL_ADDRESS>commented

Branch: [/log/puppet?rev=saw562/ldap-cert saw562/ldap-cert]

Scott Wales<EMAIL_ADDRESS>changed owner from `` to Scott Wales<EMAIL_ADDRESS>

Scott Wales<EMAIL_ADDRESS>changed resolution from `` to fixed

Scott Wales<EMAIL_ADDRESS>commented

In [changeset:"a688bc1d578d56758281cf48e45aed0c9018c5b5/puppet"]:
#CommitTicketReference repository="puppet" revision="a688bc1d578d56758281cf48e45aed0c9018c5b5"
Fixes #186 Update LDAP TLS cert

Merge branch 'ldap'

Scott Wales<EMAIL_ADDRESS>changed status from new to closed


Add demo gif to README

Description
Added demo GIF to the Readme
Motivation and Context

[ ] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issu
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s

Thanks for working on this. We'd also need the .demo file and instructions in the contribution/dev markdown file explaining how to regenerate it.


Small updates

Purpose
Resolves #
Describe your changes
PR checklist

[ ] Add link to the issue
[ ] Choose Project
[ ] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
Provide test details

/ci
operator_branch=master


[QUESTION] How to store cpu_adam and utils precompiled

Hello,
Every time I run the training on a fresh machine there's a step when libraries are compiling. Is there any way to properly move the compiled files from machine to machine without recompiling, taking into account that the environment is the same.
Compiling at the first run:
Building extension module utils...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] c++ -MMD -MF flatten_unflatten.o.d -DTORCH_EXTENSION_NAME=utils -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1013\" -isystem /opt/conda/envs/backend-new/lib/python3.7/site-packages/torch/include -isystem /opt/conda/envs/backend-new/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/envs/backend-new/lib/python3.7/site-packages/torch/include/TH -isystem /opt/conda/envs/backend-new/lib/python3.7/site-packages/torch/include/THC -isystem /opt/conda/envs/backend-new/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++14 -c /opt/conda/envs/backend-new/lib/python3.7/site-packages/deepspeed/ops/csrc/utils/flatten_unflatten.cpp -o flatten_unflatten.o
[2/2] c++ flatten_unflatten.o -shared -L/opt/conda/envs/backend-new/lib/python3.7/site-packages/torch/lib -lc10 -ltorch_cpu -ltorch -ltorch_python -o utils.so
Loading extension module utils...
Time to load utils op: 15.432841777801514 seconds```

On the second run files is found by the script in directory e.g. `/home/jupyter/.cache/torch_extensions/py37_cu113/`

But if I take this folder and move to other using the same path, it rebuilds it anyways. Highly likely I don't understand how ninja build works, but is there any way to specify to a deepspeed installed with pip where to look for cpu_adam.so and utils.so?

@loadams you're right, saving the time.
System specs:

Tesla T4 (16gb) + 30gb RAM + 8 thread CPU
Docker base image pytorch/pytorch:1.12.0-cuda11.3-cudnn8-devel
installing deepspeed using pip, version 0.7.7

Using deepspeed on par with accelerate. Training on a single device.
import deepspeed
optimizer_class = deepspeed.ops.adam.DeepSpeedCPUAdam
optimizer = optimizer_class(
        params_to_optimize,
        lr=learning_rate,
        betas=(adam_beta1, adam_beta2),
        weight_decay=adam_weight_decay,
        eps=adam_epsilon,
    )

First call does the compiling automatically, I would like to know how to invoke JIT in that place. And wouldn't it  result in a slow first run too?

will try the first option, thank you! could you please give some entry points how to invoke JIT?

The log I posted in the first message of this thread, isn't it a JIT compilation?

Time to load utils op: 15.432841777801514 seconds
Not dramatically slow, no errors. But I think of optimizing this. Now I know that it is a JIT compilation. And it seems that I cannot just copy paste the .so from machine to another machine.
Highly likely will make a wheel and pre-install it the docker container


#21 Removed hardcoded postgres user from initialization script

Can this happen?

Hi @am17torres. What do you mean?

Hi @am17torres. What do you mean?

I would just love to see this PR merged :)


Localized validation implementation issue

Hello Jeremy,
I am trying to implement localized in my project, followed below steps -
ValidatorOptions.ResourceProviderType = typeof(ValidationResources); -- added this in Global.asax
public class ValidationResources
{
public static string notempty_error
{
get
{
return "{PropertyName} is required!";
}
}
public static string notnull_error
{
get
{
return "{PropertyName} is not null!";
}
}
public static string inclusivebetween_error
{
get
{
return "{PropertyName} Should be in range!";
}
}
public static string length_error
{
get
{
return "{PropertyName} length is wrong!";
}
}
}
View contains below code --
**
         Id: @Html.TextBoxFor(x => x.Id)
        @*@(this.Localizer.Get(Html.ValidationMessageFor(x => x.Id).ToString()))*@
        @Html.ValidationMessageFor(x => x.Id)

        User Name: @Html.TextBoxFor(x => x.Name)
        @Html.ValidationMessageFor(x => x.Name)

        Email: @Html.TextBoxFor(x => x.Email)
        @Html.ValidationMessageFor(x => x.Email).

        Age: @Html.TextBoxFor(x => x.Age)
        @Html.ValidationMessageFor(x => x.Age)

        Enter Company URL: @Html.TextBoxFor(x => x.Url)
        @Html.ValidationMessageFor(x => x.Url)

        <input type="submit" value="submit" onclick="Page.JS.SubmitForm()" />
    </form>

But unable to localized, please explain in depth.
Thank you

Could you put together a test or a small example project that reproduces the issue? Thanks.

This is my model class & all validation rules ,
[Validator(typeof(EmployeeValidator))]
public class Employee
{
public int Id { get; set; }
public string Name { get; set; }
public int Age { get; set; }
public string Email { get; set; }
public string Url { get; set; }
}
public class EmployeeValidator : FluentValidation.AbstractValidator<Employee>
{
    public EmployeeValidator()
    {
        CascadeMode = CascadeMode.StopOnFirstFailure;

        //RuleFor(x => x.Id).NotNull().WithMessage("Please Enter {PropertyName} ");
        //RuleFor(x => x.Id).NotNull().WithLocalizedMessage(;
        RuleFor(x => x.Id).NotEmpty().WithMessage("Please Enter {PropertyName}").Must(IdstartingFromThreeDigitNumber).WithMessage("Id should be starting from 100.");
        //RuleFor(x => x.Name).CreditCard();
        //RuleFor(x => x.Id).NotNull().WithLocalizedMessage(() => ); // ("Please Enter {PropertyName} ");
        RuleFor(x => x.Name).NotEmpty().WithMessage("Please Enter {PropertyName} ").Length(0, 10).WithMessage("Length of {PropertyName} does not exceed 10 char's.");
        RuleFor(x => x.Age).InclusiveBetween(18, 55).WithMessage("Age Limit should be between 18 to 55. ");
        RuleFor(x => x.Email).NotEmpty().EmailAddress().WithMessage("Invalid {PropertyName} Id. ");
        RuleFor(x => x.Url).NotEmpty().SetValidator(new WebsiteUrlValidator());

        Custom(y =>
        {
            if (y.Name == "yogesh")
                return new FluentValidation.Results.ValidationFailure("Name", "This user name has already been taken.");
            return null;
        });
    }

    public bool IdstartingFromThreeDigitNumber(int Id)
    {
        return Id >= 100;
    }
}

public class WebsiteUrlValidator : PropertyValidator
{
    public WebsiteUrlValidator() : base("{PropertyName} is not does not start with http://") { }

    protected override bool IsValid(PropertyValidatorContext context)
    {
        var propValue = context.PropertyValue as string;

        if (string.IsNullOrEmpty(propValue) || !propValue.StartsWith("http://", StringComparison.InvariantCultureIgnoreCase))
        {
            return false;
        }

        return true;
    }

}

Little bit confused that what should i use in place of "?"
RuleFor(x => x.Id).NotNull().WithLocalizedMessage(() => ?)

You can use it to specify a resource type and resource name from a resource file. See: https://github.com/JeremySkinner/FluentValidation/wiki/f.-Localization

How can we set various DataType in FluentValidation for particular propert, just like in DataAnnotations as
[StringLength(100), DataType(DataType.Text)]
public string City { get; set; }
Where DataType types in MVC are 		Custom,DateTime,Date,Time,Duration,PhoneNumber,Currency,Text,Html,MultilineText,EmailAddress,Password,Url,ImageUrl,CreditCard ,PostalCode,Upload.

You can't do that with FluentValidation.
This is a metadata attribute, used by MVC and is nothing to do with validation.
FluentValidation works by validating the properties of objects after they've been set, so it already knows their types, so something similar to this isn't required.

Thank you so much for your suggestion.


[FEAT] : Redesign Project Cards for Enhanced Visual Appeal and Attractiveness

Is your feature request related to a problem? Please describe.
The current design of the project cards is not visually appealing and fails to attract user attention. These cards need a redesign to improve aesthetics, engagement, and user experience.
Describe the solution you'd like.
Project cards should have a modern, attractive design that captures user attention and enhances the overall visual appeal of the page.
Describe alternatives you've considered.

Ensure the new design is responsive and looks good on all devices (desktop, tablet, mobile).
Maintain consistency with the overall website design and branding.
Test the new design with users to gather feedback and make necessary adjustments.

Add any other context or screenshots about the feature request here.

@dhruv389 Thank you for providing your insight but it is not required as of now


chore(examples): update with-docker lock

Fixes https://github.com/vercel/turbo/issues/3419
Updates Next.js to latest so we get support for experimental transpilePackages

transpilePackages is great!

Hi @tknickman , can you make this example work with PNPM Workspace? That would be very helpful.


Allow None inputs to gradient check and generating None gradients in FunctionTestCase

Allow None in gradient check inputs and None gradients to be generated by FunctionTestCase.
This is needed if we want to allow generating None "gy" and still test double backward (in this case, the inputs to gradient check for double backward will include None) or generate None "ggx". This applies to functions with multiple outputs e.g. https://github.com/chainer/chainer/pull/7805.

Ready to be reviewed.

Thanks for the comments, PTAL.

PTAL.

Jenkins, test this please

Jenkins CI test (for commit da7347b70beabd9b44c4d84862f0961198f700fd, target branch master) failed with status FAILURE.

Test failures does not seem relevant.


GH-1046 Convert Collection Elements to Target Type

This fixes an issue where the element type information for an entity's target property was being lost before the conversion takes place.
Closes #1046

Thanks for the fix. Nice solution and good finding that broken test.
This is merged.


Serve configuration url not shown in the console

Hi,
This #59 solution is working as expected, but a small issue remains:
The console doesn't show the actual url. It's still show ?debug=true&noredir=true&debugManifestsFile=https://localhost:4321/temp/manifests.js.
This make more difficult to open the page in non default browser. Maybe it should show the actual url ?
Site note : maybe --config parameter of fast-serve should be set to default as default. This would follow any serve.json configuration bootstrapped by the yeoman generator by default.
Thanks

Moved to https://github.com/s-KaiNet/spfx-fast-serve-helpers/issues/2


Test the battery reading on MM49 (Teensy A8/D22)

See if this is really 1/3 of the battery voltage.

It should be from the schematics, but I can test this once the board gets produced


feat: Open mini-cart on add to cart

Resolves #255
Impact: minor
Type: feature
Issue
Open the mini-cart when the add to cart button is clicked
Solution

Move cart state management to the uiStore
Open the cart using the uiStore, close it on a delay

Breaking changes
none
Testing
Desktop

Hover over the cart icon, it should open
Move the mouse away from the cart, it should close in 500ms (quickly)
Add an item to the cart, see the mini-cart open
Mini-cart should close after 3 seconds (so... not so quickly)
Add another item to the cart
Mouse over the mini-cart before it closes
The mini-cart should not close after 3 seconds
Mouse off of the mini-cart
The mini-cart should close in 500ms

Mobile

Resize the window to a mobile size
Add an item to the cart
You should still see the mobile add to cart slide-out and no mini-cart

Testing with the latest updates to the GraphQL API on reaction branch: feat-4577-aldeed-graphql-order-creation
And getting the following error when clicking on the "Add to cart" button:
[GraphQL error]: Message: Cannot query field "payments" on type "Checkout"., Location: [{"line":136,"column":5}], Path: undefined

You'll need to update your docker network name as seen in .env.example

@willopez Does this PR work with the current 1.17.0 branch? It was not built to be tested with feat-4577-aldeed-graphql-order-creation. No changes were made to the how items were added to the cart so any bugs related to that branch in reaction should be addressed by another ticket and PR.

@mikemurray OK, I'll test it with release 1.17.0

@mikemurray Tested with release 1.17.0, it looks good  👍