HADOOP-18596. Distcp -update to use modification time while checking for file skip.

Description of PR
Using modification time as a way to add more checks to determine if distcp -update should skip a file or not.
In specific cases like the same file name, and size but different content we used to incorrectly skip files in update since there is no checksum comparison between object stores with different algorithm for it, to mitigate this we introduce comparing modification time between the target file and the source.
How was this patch tested?
Manually tested on an environment after reproducing the scenario where we might incorrectly skip a file.
Added a test in AbstractContractDistCpTest.java to test by changing the target file's modification time to emulate the scenario.
Tested on S3A(ap-south-1), ABFS(us-west-2), and LocalFS, and the test was successful.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

CC: @steveloughran @mukund-thakur

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 21s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 57s

trunk passed

+1 :green_heart:
shadedclient
25m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-tools_hadoop-distcp.txt
hadoop-tools/hadoop-distcp: The patch generated 4 new + 9 unchanged - 0 fixed = 13 total (was 9)

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 49s

the patch passed

+1 :green_heart:
shadedclient
26m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
44m 54s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

153m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d9de88482ed7 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5d5228db519f0cc615c4955ba36b9f3ee0572788

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/1/testReport/

Max. process+thread count
636 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 28s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 57s

trunk passed

+1 :green_heart:
shadedclient
26m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 48s

the patch passed

+1 :green_heart:
shadedclient
25m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
45m 26s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

154m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 96f6b364be34 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ee9a8568ae9e97cb94a05bbe1b2191811e0d45ee

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/2/testReport/

Max. process+thread count
616 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 19s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 31s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
26m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
shadedclient
26m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
46m  3s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

154m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 33f023938bd4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d23f13be729f0fe0770ce856b4f676f6782d83b9

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/3/testReport/

Max. process+thread count
540 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 51s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 31s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 55s

trunk passed

+1 :green_heart:
shadedclient
25m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 14s
/results-checkstyle-hadoop-tools_hadoop-distcp.txt
hadoop-tools/hadoop-distcp: The patch generated 4 new + 14 unchanged - 0 fixed = 18 total (was 14)

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 49s

the patch passed

+1 :green_heart:
shadedclient
26m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
46m  9s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

173m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e05c0db28e77 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f094248e19b615310d4791e31d293b88ed6bde37

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/4/testReport/

Max. process+thread count
538 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 38s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 31s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 55s

trunk passed

+1 :green_heart:
shadedclient
25m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 48s

the patch passed

+1 :green_heart:
shadedclient
26m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
46m 10s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

154m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2a9835850fa1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8c427bd8a37f76e61bf6c8d0d0e7cb364d3a9344

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/5/testReport/

Max. process+thread count
596 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 17s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  0s

trunk passed

+1 :green_heart:
shadedclient
23m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 27s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
shadedclient
22m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
38m 41s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

139m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 32cba67aa5ec 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d64e6b66d4851b711c40dfaf0b9ffc2a8e5a24ac

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/7/testReport/

Max. process+thread count
630 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 47s

trunk passed

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 32s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 53s

trunk passed

+1 :green_heart:
shadedclient
26m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 48s

the patch passed

+1 :green_heart:
shadedclient
25m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
45m 52s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

153m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 84304b0f676c 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4ff7f36138039a8ed90a0fd20af0d7b32f5a752e

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/6/testReport/

Max. process+thread count
607 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Have made the changes @steveloughran suggested including changing ">" to ">=".
Feel like we can have both strictly greater or greater equals for the check, the latter we would be taking a slight risk that the source file may have changed at the same time the last sync took place and we would be skipping the copy in that case, and the former in which we can have an additional copy even if there's no content changed but the mod time is same for both source and target. Shouldn't we prioritize accuracy here?
Any more thoughts on if we should change this or keep ">="?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 23s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 59s

trunk passed

+1 :green_heart:
shadedclient
23m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
shadedclient
23m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
15m 17s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

115m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 51f2095ec10e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0f63b45b01ad69d7ccc810a52b22dbcfbab4c0cc

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/8/testReport/

Max. process+thread count
768 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 24s

trunk passed

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 59s

trunk passed

+1 :green_heart:
shadedclient
23m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 51s

the patch passed

+1 :green_heart:
shadedclient
23m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
14m 57s

hadoop-distcp in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

115m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5308

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5f6ce632d6e0 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 58d8f84aa532f953da99ab8fe5bed9c28ea442f9

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/9/testReport/

Max. process+thread count
568 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5308/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ok, you can backport to 3.3, but not to the 3.3.5 branch


Wrath: incorrect tracking of which card to apply to

Both the tooltip and the effect seem to have some issues. Tooltip: see https://www.twitch.tv/videos/520578501 around 2:50

See also https://clips.twitch.tv/UgliestEncouragingBearFutureMan where it doesn't upgrade death throes correctly

Turns out it was just the tooltip with the problem (the second clip is actually upgrading the right card, the tooltip was just misleading)


Add Claude

Once granted access to Anthropic Claude, add an endpoint that queries and returns a response from Claude.

Hi @knjk04 I'm the maintainer of https://github.com/BerriAI/litellm/, which should help add the claude integration. Happy to help with the integration if ur interested.

Thanks, @ishaan-jaff!


Add Polish language

I can translate the application into Polish

I will most likely send the translation tomorrow

I will most likely send the translation tomorrow

Please do not close an issue that has a pull request linked, because the issue is intended to be solved when the pull request is merged.


[State Sync] Support ledger info targets for data streams.

Motivation
This PR extends the data streaming service to support syncing to specified targets (ledger infos). This is required by state sync to support synchronization requests from consensus (i.e., syncing to a target). To achieve this, the PR extends the continuous transaction stream engine to take in an optional target and sync towards this target. The stream will terminate once it hits the target.
The PR offers the following commits:

Reshuffle the data stream client interface methods to be alphabetical -- nothing changes here logically 😄
Support target synchronization.
Add some unit tests to verify the behaviour.

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
New unit tests have been added.
Related PRs
None, but this PR relates to: https://github.com/diem/diem/issues/8906

Thanks @gregnazario!
/land


Memory issues

Hi,
Having a lot of memory issues with sentry lately. Every time I try a composer update in a project I have to try it multiple times. Always hit memory limits. If I remove sentry it works 100%.
Today even composer require sentry/sentry-laravel hits my memory limit. I set my php.ini memory limit to 1G and install doesn't even work, that seems crazy.

Talked to a colleague and it seems that everybody has having these issues since macOS Catalina, so maybe that is related.

There can be many reasons why this is happening but I cannot imagine Sentry causes this (I've never encountered this yet), it might be Sentry with some other dependencies in your project where composer need to do some advanced conflict resolution to figure out what versions to install for certain packages.
Are you able to share your composer.json to see if I can reproduce it on my end and see if I can track down the error?

Closing this since you already openen an issue on the main SDK repo: getsentry/sentry-php#999.


Invalid default deploy source for java app service deployment

App service extension will use current project folder as the default deploy source in deployment, which will package the project folder and run zip deploy. However, this did not fit java applications, which only need the built artifact(jar/war).

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


fix(query): throw error instead of return rejected Promise.

fix issue that callbacks not get called in some conditions.

Current coverage is 62.06%

Merging #220 into master will decrease coverage by -0.39% as of eb20a5f

@@            master    #220   diff @@
======================================
  Files           24      24
  Stmts         2653    2660     +7
  Branches         0       0
  Methods          0       0
======================================
- Hit           1657    1651     -6
  Partial          0       0
- Missed         996    1009    +13

Review entire Coverage Diff as of eb20a5f

Powered by Codecov. Updated on successful CI builds.


fix(infinite-scroll): properly updates scrollTop of ion-content

Changes proposed in this pull request:

add class property _prevDim which stores dimensions at time of firing ionInfinite event
add fix for iOS motion and scrollTop conflict, just disable and reenable motion after some time

Ionic Version:  3.x
Fixes: #11587

As a temporary solution, I just copy pasted InfiniteScroll class in my project with such configuration:
import { InfiniteScroll as IonicInfiniteScroll } from 'ionic-angular'

@Directive({
  selector: 'my-infinite-scroll',
  providers: [
    { provide: IonicInfiniteScroll, useExisting: forwardRef(() => InfiniteScroll) }
  ]
})
export class InfiniteScroll {

@brandyscarney Any ETA when this will be integrated to ionic?

@stalniy I've tried to use your InfiniteScroll class in my project, but it didn't work for me. This is what I did:

Create a file called my-infininite-scroll.ts
Copy your changed file
Correct the import paths
Change the directive settings like you mentioned above
use <my-infinite-scroll>instead of <ion-infinite-scroll>

On iOS the lazy loading stopped working completely without any error.
Could you please provide the file you've added to your project? Maybe I did something wrong somewhere...
Ionic 3.6.1
WKWebView

@tobiasmuecksch here is the snippet https://gist.github.com/stalniy/bea9a080387ddaef65d6e04628f744cb Don't forget to import module with your custom infinite scroll

@stalniy I 've tried your snippet and it works most of time.
but sometimes the infinite-scroll would scrollTo the new data 's scrollTop and it would back to the right scrollTop position after a little ms.
this seems your new infinite-scroll could not prevent the scroll-content 's default motion sometimes

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


ActionSheetAsync cancel by touch not desired

Please check all of the platforms you are having the issue on

[] iOS
[x] Android
[] UWP
[] PCL

The dialog displayed using ActionSheetAsync() can now be canceled by touching outside of the dialog in version 6.2.0.  Please provide a way to disable this new behavior.  I'm passing null to the cancel argument but it makes no difference.

This is by design.  There must be a cancel option for actionsheetasync and touching outside runs cancel actions now.
If you want to have an action sheet that cannot be cancelled, use the sync version which is more appropriate in any case

There must be a cancel option for actionsheetasync

There are already two ways to close the dialog: the user can touch the cancel button, or the user can press the Android back button.  None of the other dialogs in this library are forcing me to implement cancel on touch.  I'm not using the bottom sheet mode.

Having the same problem, did you find any solution?


Handle annotations and locations better

See comment in first commit.

I'm not sure if I'm looking at a human or computer generated PR here.
I can understand wanting to rename the internal variable from Line to Pos, especially given that it's meaning is changing. I believe the only thing I'm doing with the value from erl_syntax:get_pos is passing it into merl, however. A glance at the docs show merl already expecting an annotation value. This makes me suspicious that the transformation added here to extract a line number from the annotation is actually losing information, when instead the annotation should just be passed along as is.
As it's been quite a while since I last looked at the erl_syntax/merl documentation it's quite possible I'm missing something. Can you explain why this PR shouldn't just be a global rename from Line to Pos?

I'm not sure if I'm looking at a human or computer generated PR here.
I can understand wanting to rename the internal variable from Line to Pos, especially given that it's meaning is changing. I believe the only thing I'm doing with the value from erl_syntax:get_pos is passing it into merl, however. A glance at the docs show merl already expecting an annotation value. This makes me suspicious that the transformation added here to extract a line number from the annotation is actually losing information, when instead the annotation should just be passed along as is.
As it's been quite a while since I last looked at the erl_syntax/merl documentation it's quite possible I'm missing something. Can you explain why this PR shouldn't just be a global rename from Line to Pos?

I'm not sure if I'm looking at a human or computer generated PR here.

Could you explain why you think so? It's an honest question; I'm
really curious.

I believe the only thing I'm doing with the value from
erl_syntax:get_pos is passing it into merl, however. A glance at the
docs show merl already expecting an annotation value.

According to merl(3), the type of the first argument of qquote() is
erl_anno:location(). The docs of erl_syntax:get_pos() says it returns
an integer, but the description is outdated (it'll be updated in
Erlang/OTP 24.0). It has always returned the second element of
abstract code tuples, the type of which is erl_anno:anno() since a
couple of releases.
As I wrote in the commit message, locations will be {Line, Column} by
default in Erlang/OTP 24.0. I don't think it affects the 'partial'
parse transform very much; the only thing I saw that is wrong is that
the return value of get_pos() is used in the error information.
Since the representation of erl_anno:anno() and erl_anno:location() is
the same almost always, the mix-up of the two opaque data types is
rather benign, but it should be corrected, I think.
To sum it up: you don't have to merge this PR; the code will not stop
working. But if someone calls, for example, the qlc parse transform
before 'partial', there is a very slight risk a list will be placed in
the error information instead of a location.
And I see now that I could (should) have used erl_anno:get_location()
in get_line/1 (which then of course should be named "get_location").

I'm not sure if I'm looking at a human or computer generated PR here.

Could you explain why you think so? It's an honest question; I'm
really curious.

I believe the only thing I'm doing with the value from
erl_syntax:get_pos is passing it into merl, however. A glance at the
docs show merl already expecting an annotation value.

According to merl(3), the type of the first argument of qquote() is
erl_anno:location(). The docs of erl_syntax:get_pos() says it returns
an integer, but the description is outdated (it'll be updated in
Erlang/OTP 24.0). It has always returned the second element of
abstract code tuples, the type of which is erl_anno:anno() since a
couple of releases.
As I wrote in the commit message, locations will be {Line, Column} by
default in Erlang/OTP 24.0. I don't think it affects the 'partial'
parse transform very much; the only thing I saw that is wrong is that
the return value of get_pos() is used in the error information.
Since the representation of erl_anno:anno() and erl_anno:location() is
the same almost always, the mix-up of the two opaque data types is
rather benign, but it should be corrected, I think.
To sum it up: you don't have to merge this PR; the code will not stop
working. But if someone calls, for example, the qlc parse transform
before 'partial', there is a very slight risk a list will be placed in
the error information instead of a location.
And I see now that I could (should) have used erl_anno:get_location()
in get_line/1 (which then of course should be named "get_location").


The GIT add on suddenly got disappeared

Hey,
I did all the necessary step to install the add on on Gmail, but when i change the client secret and client id of the git hub account in my script properties, suddenly my add on got disappeared.
If i go to the setting I can still see that the add on is installed , but its not showing in my side pane.
PS I am new to creating add on, any leads will be appreciated.

Not sure what the cause would be, perhaps try reverting the change and see if that fixes it?


Gitea 2 Gitea migration

[x] Wiki
[x] Milestones
[x] Lables
[x] Releases
[x] Reactions
[x] Issues
[x] Pulls

[x] fix create pulls with 500 (if it was a pull from a fork)
[x] fix creat not all existing pulls
[x] reviews

[x] Tests
[x] Adopt  #12697,  #12790

close #8380
close #11698

Codecov Report

Merging #12657 into master will decrease coverage by 0.21%.
The diff coverage is 0.97%.

@@            Coverage Diff             @@
##           master   #12657      +/-   ##
==========================================
- Coverage   43.29%   43.07%   -0.22%
==========================================
  Files         646      647       +1
  Lines       71592    71994     +402
==========================================
+ Hits        30993    31012      +19
- Misses      35583    35968     +385
+ Partials     5016     5014       -2

Impacted Files
Coverage Δ

modules/migrations/base/downloader.go
23.36% <ø> (ø)

modules/migrations/base/pullrequest.go
0.00% <ø> (ø)

modules/migrations/git.go
46.66% <0.00%> (ø)

modules/migrations/gitea_uploader.go
6.93% <0.00%> (ø)

modules/migrations/github.go
83.77% <0.00%> (ø)

modules/migrations/gitlab.go
1.14% <0.00%> (ø)

modules/structs/repo.go
79.31% <ø> (+13.79%)
:arrow_up:

modules/migrations/gitea_downloader.go
1.02% <1.02%> (ø)

modules/sync/unique_queue.go
38.77% <0.00%> (-6.13%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.54%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66843f2...a7db7df. Read the comment docs.

@zeripath now it is ready

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e0b7727). Click here to learn what that means.
The diff coverage is 1.29%.

@@            Coverage Diff            @@
##             master   #12657   +/-   ##
=========================================
  Coverage          ?   42.28%
=========================================
  Files             ?      673
  Lines             ?    74223
  Branches          ?        0
=========================================
  Hits              ?    31383
  Misses            ?    37768
  Partials          ?     5072

Impacted Files
Coverage Δ

modules/migrations/base/downloader.go
17.51% <0.00%> (ø)

modules/migrations/base/pullrequest.go
0.00% <ø> (ø)

modules/migrations/git.go
43.33% <0.00%> (ø)

modules/migrations/gitea_uploader.go
6.73% <0.00%> (ø)

modules/migrations/gitlab.go
1.04% <0.00%> (ø)

modules/migrations/migrate.go
21.55% <0.00%> (ø)

modules/structs/repo.go
60.00% <ø> (ø)

routers/api/v1/settings/settings.go
100.00% <ø> (ø)

modules/migrations/gitea_downloader.go
0.93% <0.93%> (ø)

modules/migrations/github.go
80.80% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b7727...b40ff14. Read the comment docs.

@lunny do you have time to look at it?
I think you are one of few how are familiar in this code region


PUT /policy_groups/GROUP/policies/NAME does not check if policy is the same

If you do the following:
PUT /policy_groups/a/policies/p
{
  "name": "p",
  "revision_id": "1.0.0",
  "cookbook_locks": {},
  "run_list": []
}

And then do this:
PUT /policy_groups/b/policies/p
{
  "name": "p",
  "revision_id": "1.0.0",
  "cookbook_locks": {},
  "run_list": [ "mycookbook" ]
}

The policy endpoint silently ignores the input to the second PUT. It should 409 and let me know that the policy will not be exactly what I thought it would.

cc @danielsdeleo

Hrm... right now, this behavior of the whole system is correct as long as you're creating policies with ChefDK. Contrary to the examples here, the revision_id is typically generated from a SHA 256 of the content of the policy itself. (Code is here: https://github.com/chef/chef-dk/blob/44b6ace69daf7b7f9e6a645d845b37d4e086ca0f/lib/chef-dk/policyfile_lock.rb#L147-L188 ). So any two policies with the same revision_id should be functionally identical unless you're creating them by hand.
So you can only hit this bug if you're generating policies in some way other than ChefDK and not "correctly" generating the revision_id. Based on conversations I've had, it seems like most folks would want the server to check that the revision id is "correct," i.e., that it is the correct SHA 256 of the canonicalized content. I avoided doing that so far because a) I didn't want to create compatibility issues if I had to change the canonicalized format and b) there wasn't any demand from customers. I should point out that not all fields are included in the canonical format, so there can be slight non-functional differences between policies that have the same revision_id.
In end-user terms, suppose you have a Policyfile in a Ci pipeline. If you make a change to some content that's not relevant to the policy (like a readme update or change to the build cookbook), your build pipeline will create a policy lock with the same revision_id, but it can run chef push POLICY_GROUP and not get an error (and the behavior of the system will be correct).
In any case, it would be okay to change the internals of how this case works, as long as the end-to-end behavior remains the same. Though I'm not sure this case should be a 409, it might be better to actually update the policy, or behave the same as it does now, but have the server verify the revision_id, which would prevent you from attempting to make substantive changes to a policy in this way.


bug: a reasonable SQL can't be ran due to NLJ

Describe the bug
-- create table
CREATE TABLE address_balances (
    address TEXT,
    balance BIGINT
);

-- insert sample data
INSERT INTO address_balances (address, balance)
VALUES
    ('a1', 100),
    ('a2', 10000),
    ('a3', 100000),
    ('a4', 1000000);

-- run query
SELECT
    balance_range,
    COUNT(*) AS num_addresses,
    SUM(balance) AS total_balance,
    (SUM(balance) / (SELECT SUM(balance) FROM address_balances)) * 100 AS percentage_of_total_supply
FROM (
    SELECT
        address,
        balance,
        CASE
            WHEN balance >= 1000000 THEN 'whales'
            WHEN balance >= 10000 AND balance < 1000000 THEN 'dolphins'
            ELSE 'shrimps'
        END AS balance_range
    FROM
        address_balances
) AS balance_ranges
GROUP BY
    balance_range;

To Reproduce
Explain the SQL, then
 BatchProject { exprs: [$expr1, count, sum(address_balances.balance), ((sum(address_balances.balance) / sum(sum(address_balances.balance))) * 100:Decimal) as $expr2] }
 └─BatchNestedLoopJoin { type: LeftOuter, predicate: true }
   ├─BatchExchange { order: [], dist: Single }
   | └─BatchHashAgg { group_key: [$expr1], aggs: [count, sum(address_balances.balance)] }
   |   └─BatchExchange { order: [], dist: HashShard($expr1) }
   |     └─BatchProject { exprs: [Case((address_balances.balance >= 1000000:Int32), 'whales':Varchar, ((address_balances.balance >= 10000:Int32) AND (address_balances.balance < 1000000:Int32)), 'dolphins':Varchar, 'shrimps':Varchar) as $expr1, address_balances.balance] }
   |       └─BatchScan { table: address_balances, columns: [balance] }
   └─BatchSimpleAgg { aggs: [sum(sum(address_balances.balance))] }
     └─BatchExchange { order: [], dist: Single }
       └─BatchSimpleAgg { aggs: [sum(address_balances.balance)] }
         └─BatchScan { table: address_balances, columns: [balance] }
(11 rows)

Here is a NLJ while the two tables are really small (3 rows and 1 rows), is there some solution so that we can run it in streaming mode?
Expected behavior
No response
Additional context
No response


Create deployment script

Create deployment script.
It needs to cover many versions of Spark and Scala.
The best option for starters would be based on:
https://github.com/holdenk/spark-testing-base/blob/master/mini-cross-build.pl

Redefined build.sbt, added mini-cross-build.pl.
#6 to continue work on publishing artifacts to artifactories.


Release notes for v3.0.0-beta.2

It would be great to have some release notes for v3.0.0-beta.2 - it introduced some breaking changes that took a while to piece together from commits - specifically needing to pass Currencies to the IntlMoneyFormatter.
I would add them myself, but I'm not sure I can :)

You are right! Will do that asap!

Thanks for mentioning!


ltfs_ordered_copy support for freebsd

When trying to run ltfs_ordered_copy on my FreeBSD 12.2 it says unsupported platform 'FreeBSD'..
I would love that tool to work here, as python is well supported and has been forever.
Thanks for all the hard work, hope this will be possible in the future.

Sorry, I can't have enough time to confirm the code on other platforms. But it shall work fine if the platform supports extended attribute correctly.
Please try to change the block below
https://github.com/LinearTapeFileSystem/ltfs/blob/b2a5b50666213dcf7b91750b7da9a2e19d9c370a/src/utils/ltfs_ordered_copy#L251-L258
to
plat = platform.system()
if plat == 'Linux':
    VEA_PREFIX='user.'
elif plat == 'Darwin':
    VEA_PREFIX=''
elif plat == 'FreeBSD'
    VEA_PREFIX=''
else:
    sys.stderr.write("unsupported platform '{0}'\n".format(plat))
    exit(1)

You might need to modify VEA_PREFIX if FreeBSD has it. (But I assume it is as same as Darwin ay this time.)

no more errors, when i run the tool on freebsd.. due to other issues with freebsd 12.2 and ltfs i cant really try using it with a tapedrive.

finally got to get on with this... seems freebsd also have some issues with xattr even so i even tried with this project https://github.com/xattr vs py39-xattr same errors:
/usr/local/bin/ltfs_ordered_copy /tmp/ltfs/A* /tmp/test/
Tape order aware copy for LTFS
Check destination:module 'xattr' has no attribute 'get'
same with 'set'

i can get the attributes with these commands from commandline:
xattr -p ltfs.volumeUUID /ltfs/mydir/myfile.rar
0eff3704-7089-4c2b-8fa7-a5a1203cc7b0
xattr -p ltfs.partition /ltfs/mydir/myfile.rar
b
xattr -p ltfs.startblock /ltfs/mydir/myfile.rar
6120
but not with anything else i tried, from python the getxattr( and listxattr( doent give any results aka empty. got no clue how im going to fix this to work on freebsd 13.2 where ive been trying to see what i could do with this. latest python 3.9 and xattr from pip install. latest git ltfs pull

xattr -l /ltfs/mydir/myfile.rar empty same with
xattr -l /ltfs/mydir
its mounted /ltfs tape lto6 tapedrive hp 6250 .. anything else is working perfectly


[Bug]: Incorrect file name in the music recognition tutorial

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
In this page: https://docs.towhee.io/tutorials/music-recognition-system
Run the commands:
$ pip3 install gdown
$ gdown 'https://drive.google.com/uc?id=1SSwEXOnG6c_F2NjcqYTsIM65zVCLpbOr'
$ unzip -q music_dataset.zip

Get error from unzip:  cannot find or open music_dataset.zip, music_dataset.zip.zip or music_dataset.zip.ZIP.
Because the URL "https://drive.google.com/uc?id=1SSwEXOnG6c_F2NjcqYTsIM65zVCLpbOr" point to a file named "data.zip",. not "music_dataset.zip".
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

/close fixed in https://github.com/towhee-io/towhee-docs/pull/125


Components in scope for this gem

For visibility, @peteryates, @tvararu and I had a discussion on the DfE Slack about the scope for this library.
The consensus (I think) is that this library lives along side other projects that enable developers to build applications using the GOV.UK Design System. For forms, there's govuk_design_system_formbuilder, which means that form elements are out of scope for this gem. We suspect that some GOV.UK Design System components like tables might be too complex to be built nicely using ViewComponent, and would benefit from a custom DSL.
This is a quick list of components and whether or not they're in scope. Feel free to edit & comment.

Component
In scope?

Accordion
Too complex? Maybe in 2 components

Back link
Yes, in scope for this gem

Breadcrumbs
Yes, in scope for this gem

Button
No, part of form builder

Character count
No, part of form builder

Checkboxes
No, part of form builder

Date input
No, part of form builder

Details
Yes, in scope for this gem

Error message
No, part of form builder

Error summary
No, part of form builder

Fieldset
No, part of form builder

File upload
No, part of form builder

Footer
Yes, in scope for this gem

Header
Yes, in scope for this gem

Inset text
Yes, in scope for this gem

Panel
Yes, in scope for this gem

Phase banner
Yes, in scope for this gem

Radios
No, part of form builder

Select
No, part of form builder

Skip link
Yes, in scope for this gem

Summary list
Yes, in scope for this gem

Table
No - too complex. We may create a different gem.

Tabs
Yes, in scope for this gem

Tag
Yes, in scope for this gem

Text input
No, part of form builder

Textarea
No, part of form builder

Warning text
Yes, in scope for this gem

I agree, and:
Perhaps if only accordions and tables are the "one-offs", they should still live under this gem, but can be implemented without ViewComponent (to make them easier/ergonomical to use) and could have different semantics / a separate section in the docs.
I like the idea of minimising the number of "micro-dependencies" that each have their own Gem publishing pipeline etc. It would be harder to keep everything in sync when govuk-frontend releases breaking changes.

Also, there's a discussion on the ViewComponent issues about extending content areas to be more useful. It sounds like the push is to allow #with to be called multiple times, which could make things like the Accordion achievable in a nice way, perhaps something like this (in slim for brevity):
= render GovukComponent::Accordion.new do |accordion|

  = accordion.with(:item, title: "The first tab") do
    h1 First tab content
    p lorem ipsum sit ....

  = accordion.with(:item, title: "The second tab") do
    h1 Secondtab content
    p lorem ipsum sit ....

Clearly, it's not ready yet but worth considering when (if) the functionality lands

I think Button should be part of this gem. If you look at design system implementation you can have a link styled as a button eg. Start now "button" which is really just a link. We might also want to style that "button" in various states. If you look at govuk-frontend nunjucks api (see macro), the developer can just pass in isStartButton: true and the component will output a start button link rather than a button.  Under the hood you could use link_to etc.

I'm closing this one now. The listed components are present and have been incrementally improved.


Normals are Y flipped in Clustered Lighting example between WebGPU / WebGL renderers

I've noticed that normal map is Y flipped when changing between WebGL and WebGPU renderers in clustered lighting example.

likely related to https://github.com/playcanvas/engine/issues/5735


Anchor link for headers with "and"

Steps to Reproduce:

Create a markdown file with:## Mention people and teams
## Reference issues and pull requests

View it on GitHub.

Expected:
#mention-people-and-teams
#reference-issues-and-pull-requests
Actual:
#mention-people-andteams
#reference-issues-and-pullrequests
Impact:
Broken navigation links.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes#auto-generated-table-of-contents-for-readme-files

curl -L \
  -X POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/markdown \
  -d '{"text":"# Reference issues and pull requests \n # Mention people and teams", "mode": "markdown"}'

Reference issues and pull requests

Mention people and teams

markdown api

Looks to be a non-issue it was caused by the introduction of the ASCII character code 160 the non-breaking space. When generating the anchor navigation links, GitHub's markdown parser converts spaces to hyphens. In this particular case it was not happening due to the space character not being the standard ASCII space character code 30

DEC
OCT
HEX
BIN
Symbol
HTML Number
HTML Name
Description

32
040
20
00100000
SP

Space

160
240
A0
10100000
NBSP

Non-breaking space

Other spaces characters to look out for but in the Unicode space are:

Code
HTML Entity
UTF-8 Encoding
UTF-16 Encoding
UTF-32 Encoding

U+2003

0xE2 0x80 0x83
0x2003
0x00002003

U+2002

0xE2 0x80 0x82
0x2002
0x00002002

A list of other possible spaces in Unicode can be found at the below link:
https://www.compart.com/en/unicode/category/Zs

@MajorKeen many thanks for your detailed explanation, it make sense now. I will try to handle these special cases in the TOC generator.

curl -L \
  -X POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/markdown \
  -d '{"text":"# Reference issues and pull requests \n # Mention people and teams", "mode": "markdown"}'

Reference issues and pull requests

Mention people and teams


[REEF-329]  Improve Injection in Communication Group

This PR is to improve injection in Communication Group
*Use Fork Injector in creating CommunicationGroupClient
*Use Fork Injector in Creating GroupCommOperators
*Use configuration data bound at driver side to inject GroupCommOperators at task side instead of letting clients to decide what operator instance to inject
*Resolved race condition issue caused by delayed message handler registration
JIRA: REEF-329(https://issues.apache.org/jira/browse/REEF-329)
This closes #
Author: Julia Wang  Email<EMAIL_ADDRESS>

All review comments are addressed and pushed in.

@jwang98052 I've done another pass. My main feedback is:

TestInjectionWithT can be simplified and made more readable.
I am not convinced that Initialize() is needed.

Lots of small stuff as usual as well :-)

Cleaned up test cases in TestInjection
Allow to set a named parameter to control if Initialize should be called. Call it in constructor of Operators by default. Unit test case can set it to be false.
Addressed other review comments.
Changes are pushed in.

I'll have a look.


[proposal] feat: provider's create param should allow asynchronous functions

Description
As a developer, I would like to inject dependencies like so:
return handler.use(
    provider<SecretManagerApi>((context) async {
        final client = await clientViaApplicationDefaultCredentials(scopes: []);
        return SecretManagerApi(client);
    }),
);

However, this will result in a complier error as the create function passed to provider must be synchronous.
I propose we change the create function's definition from
T Function(RequestContext context) create

to
FutureOr<T> Function(RequestContext context) create

Pros and Cons
The upside would be that you can write code like the example above. The downside is that it would required the read<T> function to return FutureOr<T>, which would be a breaking change and required you to await every call to read.
example:
Future<Response> onRequest(RequestContext context) async {
  final secretManagerApi = await context.read<SecretManagerApi>();
  return Response();
}

I argue that's not a major breaking change because

dart_frog is still very young and experimental
I would be willing to bet 90% of all Handlers are async anyway (for reading from a database or calling an external API, for example). Thus, this would just mean adding a few more awaits in your code.

Other Workarounds
There are a few workarounds that we've tried that work today:
1. Inject a Future that returns the dependency
return handler.use(
    provider<Future<SecretManagerApi>>((context) async {
        final client = await clientViaApplicationDefaultCredentials(scopes: []);
        return SecretManagerApi(client);
    }),
);

and to read
Future<Response> onRequest(RequestContext context) async {
  final secretManagerApi = await context.read<Future<SecretManagerApi>>();
  return Response();
}

This works, but I think the syntax of reading a Future of a dependency is pretty clunky imo.
2. A readAsync extension on RequestContext
extension RequestContextAsync on RequestContext {
  Future<T> readAsync<T>() => read<Future<T>>();
}

to inject:
return handler.use(
    provider<Future<SecretManagerApi>>((context) async {
        final client = await clientViaApplicationDefaultCredentials(scopes: []);
        return SecretManagerApi(client);
    }),
);

and to read:
Future<Response> onRequest(RequestContext context) async {
  final secretManagerApi = await context.readAsync<SecretManagerApi>();
  return Response();
}

This also works, but imo it would be confusing for new developers to decide when to use read and when to use readAsync, and it wouldn't be in official documentation.

Finally, I have a branch that displays this functionality here: https://github.com/mtwichel/dart_frog/tree/feat/async-create-functions (not PR ready because of testing, but could become so fairly quickly I believe)
I'm curious what everyone thinks! Thanks for everything VGV 💙

@mtwichel I'd love your thoughts on #259

Closing for now see #259


tests: guard variable used only with CONFIG_TRACE_SCHED_IPI

Change to prevent build failure when CONFIG_SCHED_IPI_SUPPORTED is defined and CONFIG_TRACE_SCHED_IPI is not.

I think that it would be better to encapsulate the body of test_smp_ipi() within a #if/#else/#endif so that it becomes something like ...
#ifndef CONFIG_TRACE_SCHED_IPI
    ztest_test_skip();
#else
   ...
#endif

agree; thank you; fixed in latest push

Any idea why this change is not merging ?


evm: only store log signatures for parsed events

Log signatures are now stored only for parsed events. This is because only in case of parsed events, we can be sure that the thing in topic[0] is actually the event signature (otherwise it could be random data inserted by an anonymous event).
This makes the field a bit less useful until more EVM events will be parsed (once contract verification is supported). If the use-case for filtering arbitrary EVM events by topic is needed (regardless if verified or not), support for filtering by topic[0] value directly could be added to API.
Side-note:
In old code, the evm_log_signature was actually stored base64 encoded in the DB, which was probably unexpected. The API filtering by evm_log_signature did not work as described in the API docs (where hex string is used in the example).
Testing:
select distinct(evm_log_signature) from chain.runtime_events where evm_log_signature != '';
                         evm_log_signature
--------------------------------------------------------------------
 0x8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b925  # ERC-20 Approval
 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef # ERC-20 Transfer
(2 rows)

API test:
curl "localhost:8008/v1/emerald/events?evm_log_signature=0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef&limit=1"
{"events":[{"body":{"address":"I4OW1NAbpWIeZolKAij2s2UfFWY=","data":"AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=","topics":["3fJSrRviyJtpwrBo/DeNqpUrp/FjxKEWKPVaTfUjs+8=","AAAAAAAAAAAAAAAAjZzJ7hGq+GWRPe7JOe6y3Hg4q3s=","AAAAAAAAAAAAAAAARUyUgag32PmIFkKUTpoi1aP3kl0="]},"eth_tx_hash":"5cb3deb32fd4e3ca66c7af4dbb0b986e9b516b8ed06e4bbced34cc1b7911ca5e","evm_log_name":"Transfer","evm_log_params":[{"evm_type":"address","name":"from","value":"0x8d9cc9ee11aaf865913deec939eeb2dc7838ab7b"},{"evm_type":"address","name":"to","value":"0x454c9481a837d8f9881642944e9a22d5a3f7925d"},{"evm_type":"uint256","name":"value","value":"0"}],"round":1019379,"tx_hash":"dea14048b683bca15863465aafbecdfdd09c4aed8910635643ad9c7f4278311e","tx_index":0,"type":"evm.log"}],"is_total_count_clipped":true,"total_count":1000}

are these changes desired for something?

otherwise it could be random data inserted by an anonymous event

we've generally not done much to filter out unusual smart contract behavior. do we especially want it here rather than to mark those events as unpraseable when we later query it?

This makes the field a bit less useful until more EVM events will be parsed (once contract verification is supported).

it'll also make it more complex to fill in the field for existing events when we add support for new event signatures, which I'm against

In old code, the evm_log_signature was actually stored base64 encoded in the DB, which was probably unexpected.

with this change, there's now some inconsistency with evm_log_signature being a formatted ethereum hash, fully with the 0x prefix in my understanding. meanwhile, the body is full of un-'typed' byte arrays shoehorned into JSON, which as a rule means base64 strings. this kind of discussion seems to come up a lot, about what we want to store in the database, whether it's data or what I'm calling "rendered" stuff.


added allowUnfree back to xnode-common.nix

This doesn't modify allowUnfree? It appears to update the xnode_uuid and token for testing and modify the openssh enable flag (needs to be make lib.mkForce for the iso build, and lib.mkDefault for the post-boot configuration file load. It also updates the flake.lock file, which modifies dependencies - these things should each be done in a separate PR.

I changed these for testing the changes with valid creds and the mkForce disabling of openssh causes a rebuild error when trying to use that feature, but sure I can do it as 3 separate PRs.

This doesn't modify allowUnfree? It appears to update the xnode_uuid and token for testing and modify the openssh enable flag (needs to be make lib.mkForce for the iso build, and lib.mkDefault for the post-boot configuration file load. It also updates the flake.lock file, which modifies dependencies - these things should each be done in a separate PR.

I changed these for testing the changes with valid creds and the mkForce disabling of openssh causes a rebuild error when trying to use that feature, but sure I can do it as 3 separate PRs.

If it needs to be changed all at once, I'll leave that up to you - esp. now, it's fine.


Confusing links to OpenTracing and OpenCensus

https://opentelemetry.io/about/ includes links under the FAQ: What is Observability section labeled Tracing and Metrics that lead to OpenTracing and OpenCensus documentation, respectively.  This has led to confusion regarding whether the information provided at those pages is relevant to OpenTelemetry implementations.  Can we replace those links with links to the relevant portions of the specification or other OpenTelemetry-specific documentation?

sure


Teams Rooms Deprecated

Create and manage team rooms

Should there be a note that Team Rooms are deprecated?  Reference

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 16350d80-8e4d-9416-8deb-dac44a65a9b7
Version Independent ID: 1ce522f1-c50c-909f-6044-2b03d4bbb64c
Content: Team administrator permissions
Content Source: docs/work/scale/team-administrator-permissions.md
Service: unspecified
GitHub Login: @erickson-doug
Microsoft Alias: kaelli

@spottedmahn - Thank you for your comment. I've updated the topic and changes will be live later today.


BluelightSpecial(GravityOnly).zip

Also added, thanks.


test: add a new test for DA using existing resources

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

Update the test to auto pick a region from BestRegionYAMLPath: "../common-dev-assets/common-go-assets/cloudinfo-region-secmgr-prefs.yaml"
Also please make sure to use trial plan when calling the DA in the test.

/run pipeline

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

GitHub release
v1.12.0

Your semantic-release bot :package::rocket:


Add a User route

Should probably include info about the current account plus access to a recovery kit download link.
UI question from @bgins - does this justify putting the hamburger menu back in?

Tracking in Trello

Hey - just about to start on the designs for this. What should go on this page? Do we still have a recovery kit, or is that now deferred along with the improved account recovery flows in general?

Hey - just about to start on the designs for this. What should go on this page? Do we still have a recovery kit, or is that now deferred along with the improved account recovery flows in general?

@depatchedmode it looks like the recovery flow work is part of the Alpha 0.3 release now, so maybe we should hold off on adding the recovery kit download until that work has been done https://github.com/webnative-examples/webnative-app-template/issues/55

@depatchedmode agreed with @avivash that we could hold off on the recovery kit download for now. We will eventually want it for both filesystem-only recovery and full account recovery (the latter with email or social recovery in the loop).
Aside from the recovery kit, this page could include username and the current backup status (has the account been linked on another device).

@bgins What info can we show the user about the other devices that have been linked? Is it just a binary "no other devices vs some other devices"? Or can we show some type of identifying information that would help the user recognize their linked devices?

@depatchedmode in the current implementation, it's a binary "no other devices vs some other devices".
In a future iteration, we could store some information about which devices the user has linked. Most likely the easiest path would be each device writes an entry for itself to WNFS. Likely a discussion for somewhere else, but what kind of information would help users to identify their connected devices?

Here's the initial iteration. Added a username and avatar field (which we can remove for now).


Try using the  full path with constructor syntax.

FileNotFoundError: Could not find module 'C:\Python39\lib\site-packages\pyzbar\libzbar-64.dll' (or one of its dependencies). Try using the
full path with constructor syntax.

Try installing the module with reference to the folder which has all modules in the program files path.


Folly uses hard coded path in its build and this port has serious problems. Remove it or Fix it!

First of all, this line does not work correctly in Linux. After building folly it gets translated to ($VCPKG_PATH/installed/x64-linux/share/folly/folly-config.cmake:38):
set_and_check(FOLLY_CMAKE_DIR "${PACKAGE_PREFIX_DIR}/lib/cmake/folly")
Which is not correct in Linux and will generate an error when you are using folly in your applications.
For fixing this error I have to change this line to:
set_and_check(FOLLY_CMAKE_DIR "${PACKAGE_PREFIX_DIR}/share/folly")
But again. After fixing this error too, the CMake generates an error because somehow, in somewhere we have used hardcoded path in folly's build (please keep in mind you have to clean buildtree to see this error happening):
Configuring done
CMake Error in CMakeLists.txt:
  Imported target "Folly::folly" includes non-existent path

    "/opt/vcpkg/buildtrees/folly/src/<IP_ADDRESS>-e96738be27/"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

CMake Error in CMakeLists.txt:
  Imported target "Folly::folly" includes non-existent path

    "/opt/vcpkg/buildtrees/folly/src/<IP_ADDRESS>-e96738be27/"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

CMake Error in CMakeLists.txt:
  Imported target "Folly::folly" includes non-existent path

    "/opt/vcpkg/buildtrees/folly/src/<IP_ADDRESS>-e96738be27/"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Generating done
CMake Project parsing failed.
Starting to parse CMake project, using: "-DCMAKE_CXX_CLANG_TIDY:INTERNAL=/usr/bin/clang-tidy-6.0;-checks=-*,clang-analyzer-*,performance-*,cppcoreguidelines-*,cert-*,readability-*,cert-*,bugrpone-*,misc-*,modernize-*,google-*;-header-filter=${workspaceRoot}", "-DCMAKE_CXX_COMPILER:STRING=/usr/bin/clang++", "-DCMAKE_C_COMPILER:STRING=/usr/bin/clang", "-DCMAKE_MAKE_PROGRAM:STRING=/usr/bin/ninja", "-DCMAKE_PREFIX_PATH:STRING=/opt/qt/5.11.0/gcc_64", "-DCMAKE_TOOLCHAIN_FILE:INTERNAL=/opt/vcpkg/scripts/buildsystems/vcpkg.cmake", "-DQT_QMAKE_EXECUTABLE:STRING=/opt/qt/5.11.0/gcc_64/bin/qmake".
CMake Error at /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:247 (_find_package):
  Could not find a package configuration file provided by "folly" with any of
  the following names:

    follyConfig.cmake
    folly-config.cmake

  Add the installation prefix of "folly" to CMAKE_PREFIX_PATH or set
  "folly_DIR" to a directory containing one of the above files.  If "folly"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:8 (find_package)

Configuring incomplete, errors occurred!
See also "/tmp/QtCreator-nkDaeD/qtc-cmake-HygEoHzn/CMakeFiles/CMakeOutput.log".
CMake Project parsing failed.

This clearly shows the amount of testing for vcpkg is not anywhere near enough and vcpkg project should focus a substantial amount of time on the quality of packages rather than quantity of packages.

After a little investigation, I believe this line is the reason why this fails. Folly does add source directory to its interface.

As temporary fix I wrote this (incase anyone had simliar problem) :
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e5703b0..2bc834b 100755
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -206,7 +206,6 @@ source_group("folly\\build" FILES

 target_include_directories(folly_deps
   INTERFACE
-    $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
     $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
     $<INSTALL_INTERFACE:include>
 )

This is due to an upstream change. I ran into it as well. This PR just landed, I would update and see if it fixes your issue: https://github.com/Microsoft/vcpkg/pull/3747

Thanks for your feedback! This issue should be fixed in https://github.com/Microsoft/vcpkg/pull/3747, please try again and open a new issue if it is still a problem for you!


[TRACKING] Holocene Hardfork Changes

Description

[!WARNING]
It is highly encouraged to read the specs prior to working on this implementation.

This is a tracking issue for Holocene Hardfork changes to kona and its dependency set.

Complete! 🎉


use docs.microsoft.com in company

Is docs.microsoft.com software available or can you buy it for use in a company?
sorry for asking here but I don't know where to do it

docs.microsoft.com is based on DocFX. So you can also build your docs site using it.

Great! Thak you!!!!
Armin Díaz
El jue., 4 de jun. de 2020 a la(s) 10:56, Zhiliang Xu (
<EMAIL_ADDRESS>escribió:

docs.microsoft.com is based on DocFX https://dotnet.github.io/docfx/.
So you can also build your docs site using it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/feedback/issues/2802#issuecomment-638904046,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7PYCDHWF7O4EU7Q7TZR3DRU6Y23ANCNFSM4NOJBQFQ
.


super and previous_def ignore block arguments

The following:
class Foo
  def foo
    yield
  end
end

class Bar < Foo
  def foo
    super
    super { puts 2 }
    super { puts 3 }
  end
end

Bar.new.foo { puts 1 }

only prints 1, whereas the same code prints also 2 and 3 in Ruby. Passing the wrong arguments to Bar#foo shows that these two overloads are defined:

Bar#foo()
Foo#foo(&block)

On the other hand, Bar.new.foo produces an undefined method 'foo' for Object error on the super call without a block. Similar errors also happen for previous_def. The current workaround is to declare a block and forward it manually, but now any other method parameters must also be manually forwarded in super:
class Bar < Foo
  def foo(&block)
    super(&block)
# ...

Ideally we should detect that Bar#foo in fact accepts a block, but is this possible? Or should super require a block argument if and only if the enclosing def uses a block elsewhere? (Note that both cases imply the block must be captured.)

I don't think this is a bug? In the end there's one overload with a block and one without one.
In reality I think we might need to change the language so that if a method exists in a type then methods are looked up in just the type. If ko overload matches it's an error. Parent methods are only looked up if no method with that name exist in the child.
I'll later send examples with code. But with the current semantics this isn't a bug.

I do consider this an error, as the actual behavior isn't consistent.
What I would expect is to Bar#foo be considered as not taking a block (as now), but then error because there's no Foo#foo() to call with super. I think this goes in line with what you're saying.

Since the first call to super in Bar#foo only forwards the block, shouldn't the whole method be defined as Bar#foo(&) only?

Since the first call to super in Bar#foo only forwards the block

How do you know that? What if Bar defines a foo() method? To me, in such cases one needs to be explicit about the block.

I know that because the super call requires it. Also, I don't follow - Bar defines foo...

@beta

but then error because there's no Foo#foo() to call with super

Isn't that exactly what's happening right now?
class Foo
  def foo
    yield
  end
end

class Bar < Foo
  def foo
    super # Error: undefined method 'foo' for Object
  end
end

Bar.new.foo

I don't think I have a preference about the behavior but it would certainly help to improve the error message, though perhaps that's tracked somewhere else. Run this code on Crystal 1.6.2:
require "colorize"

class Foo
  def only_if_coordinator : Nil
    yield
  end
end

class Bar < Foo
  def only_if_coordinator : Nil
    if false
      yield
    else
      super
    end
  end
end

b = Bar.new

b.only_if_coordinator do
  pp "blah"
end

The error message is:
Error: undefined method 'only_if_coordinator' for Colorize::ObjectExtensions

Which doesn't provide any helpful guidance on why it can't find a method, or why it's looking at Colorize::ObjectExtensions. The source of that name is certainly some bubbling up behavior where it's looking for the appropriate super candidate, but it's pretty confusing.


taskk1

@PerteGeorge this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2020-12-27T20:17:15.553077.
Estimation here is 100 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@PerteGeorge please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@PerteGeorge Don't forget to close this ticket before the deadline (2020-12-27T20:17:15). You are past the first half of the allowed period.

@PerteGeorge Looks like you've missed the task deadline (2020-12-27T20:17:15). You are now resigned from this task.
Please stop working on it, you will not be paid. I will assign it to someone else soon.

@MihaiDejeu this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-01-06T20:21:07.004604.
Estimation here is 100 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@MihaiDejeu Don't forget to close this ticket before the deadline (2021-01-06T20:21:07). You are past the first half of the allowed period.

@MihaiDejeu Looks like you've missed the task deadline (2021-01-06T20:21:07). You are now resigned from this task.
Please stop working on it, you will not be paid. I will assign it to someone else soon.

@MihaiDejeu Looks like you've missed the task deadline (2021-01-06T20:21:07). You are now resigned from this task.
Please stop working on it, you will not be paid. I will assign it to someone else soon.

@PerteGeorge I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@PerteGeorge I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.
Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.


Debugger step within block and then select block context has bad behavior

Same example code and breakpoint as in #134.
If I edit the code but don't save it, and do a step over (the () with the down arrow), then I see am empty source pane.  The top context updates its step point and source line number, but doesn't show anything.

I believe that the blank source got fixed recently as a side effect to another fix. Please verify as I cannot reproduce.
fyi - I opened a new issue with all the interesting variants of leaving the source pane in an unsaved state. https://github.com/GemTalk/Jadeite/issues/176

This doesn't seem to be related to edits and saves at all... the same scenario in 3.0.35 results in an error "An unknown RowanDebuggerStepPointError has occurred", and happens when I don't have edits.

With breakpoint on test in the interesting loop method, execute; breakpoint leaves you with the top context being the block context.
Step into (do not copy to clipboard). This brings you into the Cabbage > test method.
Select the frame below, which is the block context frame.
See error.

I get another error with the breakpoint in, which is a bit annoying but not technically a bug.

In 3.2.17, stepping and breakpoints have some problems - See kermit bug #45553.
There was a workaround in when displaying the process frame. If the frame couldn't find it's step point, it would throw an error which was caught and handled when stepping. However, that same code was used when simply selecting another frame.
When selecting another frame the fix, which I hope is temporary, was to make the error thrown resumable then only resume it if we aren't stepping. Then the resumed code avoids touching the step point and displays the source code.
While one won't see the step point in this scenario  showing the method source is better than a walkback or a dialog error.
Fixed in 3.0.36.

The behavior in 3.0.38 is still the same, if I do a step into within a block and then click on the block context frame below, I see an error dialog
Error while processing error: An unknown RowanDebuggerStepPointError has occurred
If I click okay on that and the next breakpoint dialog, I can then click on all the frames in the stack and it displays, but the first time into block context is a bear.

I was able to reproduce the error. The server returns a nil step point from GsNMethod>>_stepPointForMeth:ip: Work done in kermit bug # #45553 fixes this problem in later server versions.  (See GsNMethod>>_debugInfoAccess:at: for a little more on the fix)
RowanDebuggerStepPointError>>isNested was added to workaround the problem and gets rid of the unhelpful dialog box walkback.
I believe that original problem reported in #224 may be fixed with this check in, too.

Looks good.  I might note that with the the block context selected, code has a red border around the select as well as a highlight on the step point... the border implying a breakpoint, which is a little inexplicable. But I think there's a separate bug on highlighting in debugger.