How to get a hold of you Rocky

Rocky,
My apologies for putting this in the issues. Ive tried to find a way to reach your contact information but have been unable to. I have a small python project to use your wifi package Id like to hire you for. Please contact me at your earliest convenience.
Thanks
Mike
<EMAIL_ADDRESS>

I have sent you an email.


Cleanup of various functions regarding strings

Trying to improve the lifetime management of string objects. Use string_view where ownership doesn't need to transfer, using std::move() where it does.

Thank you for updating!


Global config to disable font controlled on all component

HI, when I use this plugin, it automatically includes the nuxt-icon class in the SVG with default styling. If I want to avoid that class, I can disable it by setting :font-controlled="false", but having to do this for every component is tedious. It'd be great to have a global option for this.

well, you already can replace the component that is being used very easily by using the customComponent option
I understand the default settings is not for everyone but what you are asking is way easier to achieve by copying the component this package provides and editing it to suit your needs, then use it in customComponent option

Thanks for the response. Okay no problem, I will use the custom component for now.


how to generate and preview?

How can I generate the _post into _site? I do not find any hint in readme.
The command line octopress is much slower than before. I need to wait at least 20+ seconds to get result for octopress --help

You should use the Jekyll commands, jekyll build or jekyll build --watch. jekyll server boots up a server at localhost:4000 where you can preview your site. Use jekyll --help to learn more.
Regarding speed:
This is probably because of the number of gems you have installed. It takes ruby gems a while to boot up. If you're using bundler in your site, running bundle exec octopress --help will execute much faster. If not, you can run gem cleanup which will remove all but the latest versions of your gems and then your system won't take as long looking through your many gems.


del should only stop consumer if it is running

Ran into this error when attempting to gracefully shutdown my application.  What happens is when __del__ gets called (I believe when the GC is cleaning up) and the consumer has already been stopped then your application hangs (using python 3.5.1).  Here is an example of what you see when the consumer hangs (notice how the consumer's stop method is called twice - expectation is once):
DEBUG [2016-02-24 15:41:20,334] stop: Stopping <pykafka.balancedconsumer.BalancedConsumer at 0x7f7762b25710 (consumer_group=b'nathanhale')>
DEBUG [2016-02-24 15:41:20,335] commit_offsets: Committing offsets for 3 partitions to broker id 0
DEBUG [2016-02-24 15:41:20,337] _submit: Sending request(xid=13): Close()
DEBUG [2016-02-24 15:41:20,339] _read_watch_event: Received EVENT: Watch(type=4, state=3, path="/consumers/b'nathanhale'/ids")
INFO [2016-02-24 15:41:20,340] _connect_attempt: Closing connection to localhost:2181
INFO [2016-02-24 15:41:20,340] _session_callback: Zookeeper session lost, state: CLOSED
DEBUG [2016-02-24 15:41:20,341] __del__: Finalising <pykafka.balancedconsumer.BalancedConsumer at 0x7f7762b25710 (consumer_group=b'nathanhale')>
DEBUG [2016-02-24 15:41:20,341] stop: Stopping <pykafka.balancedconsumer.BalancedConsumer at 0x7f7762b25710 (consumer_group=b'nathanhale')>
DEBUG [2016-02-24 15:41:20,341] commit_offsets: Committing offsets for 3 partitions to broker id 0
*** this is where it hangs...

And this is what you get with the fix (stop is now called once):
DEBUG [2016-02-24 15:52:05,508] stop: Stopping <pykafka.balancedconsumer.BalancedConsumer at 0x7f29634697f0 (consumer_group=b'nathanhale')>
DEBUG [2016-02-24 15:52:05,508] commit_offsets: Committing offsets for 3 partitions to broker id 0
DEBUG [2016-02-24 15:52:05,511] _submit: Sending request(xid=13): Close()
DEBUG [2016-02-24 15:52:05,513] _read_watch_event: Received EVENT: Watch(type=4, state=3, path="/consumers/b'nathanhale'/ids")
INFO [2016-02-24 15:52:05,514] _connect_attempt: Closing connection to localhost:2181
INFO [2016-02-24 15:52:05,514] _session_callback: Zookeeper session lost, state: CLOSED

Note that calling the consumer's stop method twice does not seem the hang consumer so the change to __del__ should be sufficient to address this bug I think.
I'm not 100% sure this is the best solution so let me know if there would be a better way to solve this issue and I can make those changes.  Since this is a minor change I am submitting to master (I did read the guidelines ;P).

That second commit is just the same fix for balanced consumer added to simple consumer.

Thanks for filing this @suicidejack. It looks useful and should be mergeable once the tests pass.

No problem.  Is there something I need to do for the tests?

@suicidejack: It looks like codecov failed for some reason. You could try rebasing your patch on the master branch and force push it up. That might get the tests to run again.

@erickt @suicidejack I'm mainly concerned with the Travis tests, which now are passing after a few retries. Thanks for the contribution!


Const qualifications and cooked expressiveness

The register_rpc_functions class makes awkward assumptions about what sort of methods we will register for RPC in the first place.  In particular, they cannot be reference-returning or const-qualified.  These restrictions will bite us.

By "register_rpc_functions class," do you mean the RemoteInvocableClass class and its associated tag() and bind_to_instance() function templates? register_rpc_functions is the name of a header file that contains a bunch of auto-generated macros, not a class.
Assuming I guessed right about the code you're referring to, what is the right solution here? Can we require that registered RPC functions are not reference-returning or const-qualified by putting some restrictions on the template parameters for partial_wrapped, wrapped, tag(), or bind_to_instance()? As far as I know, there's nothing in the C++ template system that allows you to partially restrict a template type to only match non-const or non-reference types. But then again, you're the expert on the C++ type system, so maybe there is a way to do that.

The fundamental problem is that partial_wrapped explicitly has its function as a Ret (Class::*)(Arguments...);, which doesn't allow const-qualified functions.  It should instead be either a Ret (Class::*)(Arguments...); or a Ret (Class::*)(Arguments...) const;.  That needs to change, and everything that interacts with it (creates it, consumes it, passes it along) needs to be checked and changed if necessary.

Oh, so you're saying that the assumption that the wrapped function is not const-qualified is an unnecessary restriction and should be lifted by providing both const and non-const versions of the tag() function. I can do that. On the other hand, was I correct in guessing that the restriction against reference-returning functions is intentional and just needs to be enforced? An RPC-invoked function really shouldn't return a reference, because the result will be copied across the network, and a reference or pointer to local memory on the executing node will become invalid.

I'm not sure about that one; these functions can technically still be called locally too.  We definitely would copy the return value across the network in either case.  Either way, we should give a much better error message for things like this.  We should also enforce that the arguments to RPC-able functions are taken by reference.  Putting a static_assert to test is_lvalue_reference (or !is_lvalue_reference) in the right places is probably the right call.


[move-prover] Invariant refactoring: Eliminate TypeLocal - (71)

Motivation
This PR eliminates the redundant type variant of TypeLocal. This type variant was needed for type quantification, but as we embrace full monomorphization, we remove this feature, and instead replace it with generic invariants. (As in invariant P.) Before this PR, we had used TypeLocal as a convenience to distinguish type parameters of invariants from type parameters of functions, but this created boilerplate and made the code mor complicated. In this PR, we exclusively use the existing concept of TypeParameter.
This PR aims to maintain the current design of global invariant injection as much as possible; changes to this are subject of future PRs.
In detail:
Both local_mono and local_mono_compat processors have been removed. The computation of the instantiations of invariants is now happening at the time the invariant is injected/instrumented. This is necessary because once an invariant is injected into bytecode, we can't distinguish it's type parameters from that of the enclosing function. Therefore we need to fully instantiate invariants at injection time.
Instantiation of invariant expressions is now handled by SpecTranslator. This module was already able to instantiate expressions during translation; the entrypoints for invariant translation have been modified accordingly.
A lot of code has been removed besides TypeLocal. The quantifier elimination in mono_analysis is not longer needed. The axiom instantiation in the same place was likely erroneous and needs to be redone. The v1 of global_invariant_instrumentation and usage_analysis has been removed to avoid refactoring them.
The diem framework and move stdlib has been updated to use the new generic invariant semantics.
As a side effect, also adding a new script to validate a PR locally in ./tools/check_pr.sh.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Existing tests.
Related PRs
NA

/canary

/land


Tiny modify for finding more useful gadgets

BARFgadget is awesome tool, should find out more useful gadgets than ROPgadget and other gadget find tools.
But in fact it doesn't.

Scenario One
Gadget pop rbx ; pop rbp ; ret shoud be three gadgets, not just one.
pop rbx; pop rbp; ret
pop rbp; ret
ret

Scenario Two
00000000004005E9 41 FF 14 DC                             call    qword ptr [r12+rbx*8]
Not all call instructions start with "\xff", considering instruction above.
REX.W + FF /3 CALL m16:64
Complete info for x86 ISA at: ()[http://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-2a-manual.html]

So I modify the codes in gadgetfinder.py, it can find out more gadgets than ROPgadget now.

Great that you find it awesome :)
Regarding your changes to gadgetfinder.py:

Scenario One:

This was originally made on purpose (in order to avoid potentially similar
gadgets) but I was thinking about modifying it for a while. The reason is the
following.
In your example, the gadget pop rbx ; pop rbp ; ret will be classified as
two different typed gadgets:

rbp <- mem[rsp + 0x8] (with clobbered regs: rbx, rsp) and
rbx <- mem[rsp] (with clobbered regs: rbp, rsp).

So, at first sight, not returning intermediate gadgets shouldn't be a problem.
However, in the first classification (rbp <- mem[rsp + 0x8]) there is one
clobbered register that could be avoided (rbx) if you process the
intermediate gadgets and this, sometimes, can be very helpful/necessary.
So, considering this, I will include the change.

 I missed that opcode combination!
Thanks for contributing!


Python libs and PYTHONPATH cleanup

I had first reordered the deps so that the user could override the runtime deps.
But in the end, I think it's better to keep it as-is. So the order is:

/app/python_libs (langstream and langstream_runtime)
/app/app-code-/python (user deps)
python deps (installed by pip when building the docker image)

So the user can override the python deps but not the langstream ones.


WaitNamedPipe API not work inside windows docker container

Hi, team,
currently WaitNamedPipeis API not supported from inside of Windows Containers. It always fail with ERROR_FILE_NOT_FOUND error, are there some plans to support this?
Related issues:
https://github.com/docker/compose/issues/5934
https://github.com/docker/for-win/issues/4012
https://github.com/docker/docker-py/issues/2018

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


[PE-D][Tester D] The view command is not behaving as expected

I have a pdf entry for the first patient, but when I type in "view 1 1", I am unable to view and got the error message "The File index provided is invalid". Perhaps there is an indexing error occurring here. Although I could still view the pdf document by clicking on "view" in the GUI, this may still hinder users, especially since the app revolves around a CLI.

Labels: type.FunctionalityBug severity.High
original: Jun-How/ped#7

Similar issues noted


fix(config): Update lzw31-sn parameter 16 to match documentation.

This updates the LED effect parameter per docs and the OZW file.
@AlCalzone A related question,  my read of #1411 is that single params like this are less helpful than splitting each out like lzw30-sn. If that's the case, would it be better for me to update this to match that instead of updating this single parameter?

@mattsch yes in the end we want to have partial parameters for these complicated params so users don't need an external calculator to determine the value. If you're willing to do that here it would be perfect. Otherwise, a correct value is better than what we have now.

Sounds good, I'll work that up and do a separate PR for it. One inconsistency I noticed was in the naming of the params in lzw30-sn vs lzw36. The former uses LED Strip Effect (Color) while the latter uses LED Strip Effect Color. Personally, I think I prefer the second but curious if you have a preference so I can clean that up as well while I'm in here.

Closing in favor of #2069


Update undefined behavior note about float-to-float cast.

operator-expr.md mentions issue https://github.com/rust-lang/rust/issues/15536 as undefined behavior. I believe this is now fixed, and no longer undefined? Or something, someone should investigate and update the note.

cc https://github.com/rust-lang/rust/issues/10184


sock-shop data

Hi,
I would like to inquire about the sock-shop-data folder.
Are the names of each subfolder representative of root causes?
Thank you!

Yes! The name of the folders are [failed-service]-[failure] where [failed-service] is the name of service and [failure] is the type of the failure (either memory leak or cpu hog).

In the paper, there are a F-node that indicates the trigger point and the descendants of the F-node that indicates the root cause.
Is the failed-serivce the root cause or the trigger point? Thanks!

For example:
If the CPU hog is the root cause, and what is the F-node?
Is F-node also CPU hog?
Thanks!

Trigger point is that if there is an anomaly in a metric, and the anomalous metric is the so-called trigger point.
For example,
If we see the metric "logging system is alive" is anomalous, this metric is a trigger point.
Then we wanna to find what makes the system malfunction, if the problem is "CPU utilization", we can say that "CPU utilization" is the root cause.
Thanks for you explanation, I have known what is F-node here.

It is still not clear what the trigger point is. You said if there is an anomaly in a metric then that metric is the trigger point. If we are assuming that the anomaly is only on the root cause node then actual root cause is the trigger point. But from your example, it seems that you already have an anomaly detection system in place that detects changes in metrics. When it detects a change in one of the metric, it calls that metric the trigger point. Its possible that the detected metric (trigger point) is not the root cause but just a node in the anomaly propagation chain. If this is the case then F-node will not output the trigger point but the actual root cause. So following your example, RCD will output "CPU Utilization" as the root cause of the failure.
On a side note, it is not clear what kind of metric is "logging system is alive". We use a general set of metrics (such as CPU utilization, memory usage, or latency etc (numerical values)) but I believe an application specific metric can also be use as long as it provides some insights about the underlying system.

Yes, there is already an anomaly detection system so that we have a trigger point.
Thank you very much for patiently explaining.


Use trial ports by default and add new virt proxy-type

virt proxy-type seems to be only available for brazil and japan (unknown use but it doesn't hurt to add this incase a user needs it)
gofmt all the code
use trial port by default, just like extension
now hola-proxy can be run like this ./bin/hola-proxy -bind-address 8081 and it will listen to <IP_ADDRESS>:8081

Edit: sorry for all the PRs

Thank you for the contribution!


Create a separate DB for ITL

Make a separate db for the ITL project. The current db/tables are being updated by Sabda UI. Hence the change.

@beniza
Can you confirm which ITL you are talking about?
SABDA UI or AutographaMT?


Glossary page only shows "loading.."

I have integrated this plugin and the tooltip part works well (shows information and links to term). However, on the glossary page, I only see "loading..". What could be the reason for that?
Since I don't see anything in the logs, how would I start investigating such an issue?

This should be fixed in the latest version. Can you upgrade and check?

Thanks, @tsironis
Here's my glossary:
---
id: glossary
title: Glossary
---

This is a glossary

This is how it renders:

In case it's relevant, I'm not using the live-reload feature. I first built the documentation using npm run build and then I use npm run serve.
This is a snippet from my docusaurus config:
  plugins: [
    [require.resolve("docusaurus-lunr-search"), { indexBlog: false }],
    ['drawio', {}],
    ['@grnet/docusaurus-terminology', { termsDir: './docs/01-meta/terms', docsDir: './docs/', glossaryFilepath: './docs/01-meta/02-glossary.md' }],
  ],

Versions used:

npm 8.11.0
node v16.15.1
macos 12.6.5
browser brave
docusaurus 2.4.0

@rethab I think that the rc.3 version solves this bug.

Reopening, I accounted for the folder index, but not for the file index, as seen in your example from your last comment.

Hi, thanks for working on this. I now see a list of terms on the glossary page, however, the link that should point to the term page there doesn't work.
Also I noticed that when using this plugin, the link on the regular page (where the tooltip is shown) is no longer generated correctly.
Without the plugin, the link
[CNP](../01-meta/terms/cnp.mdx)

points to
http://localhost:3000/wiki/meta/terms/CNP
however with the plugin, it points to:
http://localhost:3000/wiki/docs/01-meta/terms/cnp
Note how 01-meta is my folder name, but not the name I want in my URL path :)

@rethab I just released 1.0.0-rc.4 version. It should be working now.

It now links to http://localhost:3000/wiki/docs/meta/terms/cnp
So two problems:

docs prefix
cnp is lowercase (not sure if that's a problem)

Alright, I guess I have a slighlty different example than your installation. Could you provide a repo that reproduces the issue in your latest comment?

@rethab do you have a different for the plugin-content-docs plugin? Will you be able to provide me the contents of docusaurus.config.js?

@rethab I'm closing this one since it is stale, go ahead and reopen it if the issue still persists.


Segmentation fault when Receive SIP Event [nua_i_ack] Status 200 OK

When I use FreeSwitch and unimrcp , it happened a "Segmentation fault" error.
The sever log is:
2019-04-28 11:41:32:502787 [INFO]   Receive SIP Event [nua_i_invite] Status 100 Trying [SIP-Agent-1]
2019-04-28 11:41:32:502798 [INFO]   Receive SIP Event [nua_i_state] Status 100 Trying [SIP-Agent-1]
2019-04-28 11:41:32:502803 [NOTICE] SIP Call State  [received]
2019-04-28 11:41:32:502816 [INFO]   Create Session 0x7f86ac001b68  [uni2]
2019-04-28 11:41:32:502821 [INFO]   Remote SDP 0x7f86ac001b68
v=0
o=FreeSWITCH<PHONE_NUMBER>458623237<PHONE_NUMBER>139164615 IN IP4 <IP_ADDRESS>
s=-
c=IN IP4 <IP_ADDRESS>
t=0 0
m=application 9 TCP/MRCPv2 1
a=setup:active
a=connection:new
a=resource:speechrecog
a=cmid:1
m=audio 4090 RTP/AVP 0 8 96
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:96 L16/8000
a=sendonly
a=mid:1
2019-04-28 11:41:32:502894 [NOTICE] Add Session
2019-04-28 11:41:32:502901 [INFO]   Receive Offer 0x7f86ac001b68  [c:1 a:1 v:0]
2019-04-28 11:41:32:502907 [INFO]   Found MRCP Engine [Aliyun-Recog-1] for Resource [speechrecog] 0x7f86ac001b68
2019-04-28 11:41:32:502956 [INFO]   Add Pending Control Channel ed15866bb09549ea@speechrecog [1]
2019-04-28 11:41:32:511870 [INFO]   Enable RTP Session <IP_ADDRESS>:5002
2019-04-28 11:41:32:511939 [INFO]   Open RTP Receiver <IP_ADDRESS>:5002 <- <IP_ADDRESS>:4090 playout [50 ms] bounds [0 - 600 ms] adaptive [1] skew detection [1]
2019-04-28 11:41:32:511945 [INFO]   Media Path 0x7f86ac001b68 Source->[PCMU/8000/1]->Decoder->[LPCM/8000/1]->Bridge->[LPCM/8000/1]->Sink
2019-04-28 11:41:32:511958 [INFO]   [Luckyai] start recog.
2019-04-28 11:41:32:512021 [INFO]   Send Answer 0x7f86ac001b68  [c:1 a:1 v:0] Status OK
2019-04-28 11:41:32:512034 [INFO]   Local SDP 0x7f86ac001b68
v=0
o=UniMRCPServer 0 0 IN IP4 <IP_ADDRESS>
s=-
c=IN IP4 <IP_ADDRESS>
t=0 0
m=application 1544 TCP/MRCPv2 1
a=setup:passive
a=connection:new
a=channel:ed15866bb09549ea@speechrecog
a=cmid:1
m=audio 5002 RTP/AVP 0
a=rtpmap:0 PCMU/8000
a=recvonly
a=mid:1
2019-04-28 11:41:32:512267 [INFO]   Receive SIP Event [nua_i_state] Status 200 OK [SIP-Agent-1]
2019-04-28 11:41:32:512274 [NOTICE] SIP Call State 0x7f86ac001b68 [completed]
2019-04-28 11:41:32:512684 [NOTICE] Accepted TCP/MRCPv2 Connection <IP_ADDRESS>:1544 <-> <IP_ADDRESS>:41208
2019-04-28 11:41:32:512866 [INFO]   Receive SIP Event [nua_i_ack] Status 200 OK [SIP-Agent-1]
2019-04-28 11:41:32:512873 [INFO]
Segmentation fault
This error did not occurred every time. So how do I avoid to it?
unimrcp version : 1.6.0
FreeSwitch version : 1.6.20~64bit
system : CentOS Linux release 7.4.1708

I would assume the problem is encountered only when a 3-rd party plugin is used such as Aliyun-Recog-1. Try to run unimrcpserver under valgrind or collect a coredump and analyze backtrace.
Otherwise, there is nothing wrong in the provided logs and the same scenario has been used millions of times with other plugins without any problems.


Questions about redefining defining spaces

There are a few questions we have about being explicit with these spaces. How should we design quantities that are defined in Data.Drasil.Quanities? For example,
stffness :: UnitalChunk
stffness = uc CSM.stffness cK stiffnessU

Since uc implies Rational and my example uses a Float I would need to change this type. The issue with this is that any other future examples would be forced into coding with stffness being a Float when they might want it to be Rational or Int.
Secondly, what should we say for quantities that are Float in some equations but Vector in others?

do spaces relate to mathematical spaces? do we differentiate between Natural Numbers vs Integers? should we define an R^1 R^2 ... R^n space? Bool^N etc?

Yes, spaces are mathematical spaces.  The space of a variable is its type.  All of the examples @hmadej listed could come up.  Our approach should be to add new types as required.  As for the original question from @njericha, we don't want Float to be a type that appears in our requirements documentation.  In the implementation we will use Float to approximate a real number.  We could use another choice to approximate the real number, so we don't want to constrain the design too early.  With respect to stiffness, it should be a real number, because that's what physics tells us.  If in some future application the stiffness should happen to have an integer value, it is still a value from the set of reals.
Quantities are vectors if that is there type.  The type of a vector might be R^n, where n is the length of the vector.  A position vector in 3D space would have type R^3, while each position coordinate would have type R.

And to be precise: we need a Real Space -- and most uses of Rational should be Real.  We might not be able to use Real as the word, since that may conflict with Haskell, but something like it.

So the Space of these quantities defined in Data.hs should reflect physical reality rather than how they would be measured or how they might be modeled in software? If some example might only take Int values, we would just consider that example to still take Real inputs?

I believe the answer to your question is yes.  We are interested in the "natural" type of the quantity.  If it is something that we count, then the type would be a natural number.  For instance, the number of slices in your ssp program is an integer.  There is no notion of half a slice.  The number of panes of glass in GlassBR ( @niazim3 ) is also a natural number.  If negative "counts" make sense, then we have an integer type.  An example doesn't immediately come to mind from our 5 projects, but I'm sure there is one in there.  If something is measured on a continuum, with negative and positive values, we have a real (R) value.  Many of the quantities in our 5 projects should have the type Real.
In the implementation natural numbers might be implemented using integers and reals might be implemented using floats or doubles, but in the  SRS we shouldn't be making these implementation decisions.

@hmadej defaulted everything to Real 68e328f705b872dfc3c2e0cf5c4a31bf5a5f55b8 and I've made my necessary changes 106257b0e07a1ede8e03de4666884e6112b364a4


Why generate a new hash/filename based on runtime?

https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/2f89c5d42f746abf1b9d9a1543f03354957db2f9/package.py#L1054
This line makes it so that the content_hash changes on every rerun, regardless of whether or not the source code has changed. This causes issues with our drift detection. Is there a reason I am not thinking of to have runtime factored into the filename, and as a result whether or not terraform tries to deploy new artifacts?
Would it not be better to leave this out and only redeploy if the underlying source or dependencies change?

@jorwoods The package.py script uses a same python version as specified in the runtime to install its dependencies, this is need in case of dependencies that contain binary python modules to be sure that they were compiled with correct python version. So in case of the runtime parameter changing such binary modules need to be recompiled to be sure that they will work correctly on the lambda environment. This peculiarity relevant for Python runtimes and I'm not completely sure about all other runtimes supported by AWS Lambda.


Allow javascript (or typescript) config file

Suggestion
I suggest allowing a tsconfig.js or tsconfig.ts as an optional alternative to tsconfig.json.
Use Cases
What do you want to use this for? Primarily to add comments to the tsconfig file.
What shortcomings exist with current approaches? JSON does not allow comments. You can't even hack in comments by adding fake fields like "_explanationOfTypeRoots", as the build complains about unknown compiler options and stops.
Examples
Many tools and frameworks allow javascript config files. Jest, for example. jest --init produces a heavily commented config file, which is very useful for beginners.

What do you want to use this for? Primarily to add comments to the tsconfig file.
Did you know that you can add comments to tsconfig.json?

Try it with tsc --init, that produces a heavily commented tsconfig.json file.

Oh, nice! I was under the impression that comments were not allowed in JSON, but it makes sense that someone would write a parser that allows them. Thank you for your response, I am closing the issue because I no longer think this feature is necessary.

@alexmiddeleer No, YOU are right -- JavaScript style comments aren't allowed in JSON; tsc --init produces an invalid JSON file. The parser, of course, is permissive.
@msftgits should consider an alternative format for autogenerated config files. This could be solved easily by allowing tsconfig.yaml, tsconfig.js, or tsconfig.ts while continuing to support tsconfig.json in perpetuity.

I agree that more config options would be ideal. But I’m guessing the core team needs to focus on higher priority items. Maybe this would be a good first contribution for someone new.

This format is known as JSON5

EDIT: I'm guessing the parser just interprets the content of tsconfig.json as JavaScript

JSON is a different top-level production because the initial { indicates an object, not a statement block.
We are not accepting PRs to turn config into an executable thing. This opens up an enormous can of worms (is it safe to run this? what dependencies does the config file have? what does the config file assume about its environment?) that we'd prefer remain closed.

@RyanCavanaugh you said

We are not accepting PRs to turn config into an executable thing.

Would you accept a PR to support only yaml? Or for that matter, other non-executable formats (e.g. toml, ini, etc, but I'm only interested in yaml).

We are not accepting PRs to turn config into an executable thing. This opens up an enormous can of worms (is it safe to run this? what dependencies does the config file have? what does the config file assume about its environment?) that we'd prefer remain closed.

This makes little sense to me when so many other JS libraries support them.
#39441 names a few but there are plenty more that all allow this behaviour. If every one of them had a discussion on the same security concerns, then wouldn't looking through their discussions yield the information needed to implement it in a safe and responsible fashion?

One could always generate the config dynamically. It just makes it harder to get the job done when this is forbidden. So yeah, it’d be REALLY nice to have this feature.

What needs to be done to convince developers? For them to add support tsconfig.js? @RyanCavanaugh

This is a pretty basic feature which would be really nice to have.

Oh, nice! I was under the impression that comments were not allowed in JSON, but it makes sense that someone would write a parser that allows them. Thank you for your response, I am closing the issue because I no longer think this feature is necessary.

I think at lease the developer could have the chooise, not just be accept the " I no longer think this feature is necessary" , as far as I can see, I am trying to use git-submodule for my project, it means at lease I have tow or more projects to be located in one root folder,  I just want to dynamicly modifiy the "compilerOptions.path", but it is impossible, it makes me feel bad

@RyanCavanaugh, can you give any solution or comment?

@RyanCavanaugh please, don't ignore us

Should @alexmiddeleer reopen the issue and we focus this on the JS config to dynamically edit properties within the tsconfig at compile time, or do we leave this closed as it was specifically about comments within the JSON and open a new issue to focus on the dynamic aspect?

Please leave an explanation about why the issue was closed. If this can't be achieved for some reason, at least explain so we can drop it.
This is a big thorn in decal projects.

I am reopening since this has so much interest. I closed it initially out of respect for the maintainer’s statements that they didn’t want to support it.

Though I have some misgivings about issue resurrection and think a fresh issue might be better to make the history less muddy. This one’s initial use case turned out to be solved already.

So in one of the other issues #30751, there is a reference to an npm package that implements some of this behavior already: tsconfig.js. As good as it is that there exists an alternative, it essentially functions as a generator that you feed a js file into and a JSON file comes out.
In the readme for that project is also mentioned an excerpt from the Design Meeting Notes, 9/28/2018

What about tsconfig.js?

Nooooooooooooooooooooooooooooo

Which I feel sums up the attitude towards this suggestion. With very vague hard waving we are assured that it would be too complicated or too big of a security concern.
If any concrete concerns exist then those can be addressed, If it's just feeling uncomfortable with the idea of a js config, then the existence of webpack.config.js, vite.config.js, .eslintrc.js and many other config files should help reassure that this is a common and safe practice. I mean even the Gulpfile.js in this very project shows that having your configuration as an interpreted js file is sometimes necessary.
Most other build tools use executable configurations since they allow for more reuse and flexibility, so I am having a hard time justifying how TypeScript is different from any of the other build tools that all support js configurations.

Somehow the npm package mentioned above didn't work for me.
Add the above step into your build process.
Optionally add tsconfig.json to your .gitignore.

See the gist for code examples. I hope this helps.

Somehow the npm package mentioned above didn't work for me.
Add the above step into your build process.
Optionally add tsconfig.json to your .gitignore.

See the gist for code examples. I hope this helps.

Thanks @simonpai that helped a lot!

@qhantom @simonpai but anyway it is a workaround 😞
I don't understand. How many people should highlight the problem? No any comment from Microsoft developers, they just ignore the current topic

for anyone wondering the best way to ensure that these topics get seen & taken seriously is to upvote the original comment that started the issue. Doing so bumps the issue further up the list of things for the TS team to tackle. So anyone wanting to see this added should upvote & encourage others that want the same functionality to do the same.

Seeing that babel, eslint, tailwind, vite and so many more libs allow .js config files as well as .json, it would make sense to allow it as well, because though it allows a project with a malware ts config file to run code when running tsc , first you are running a build command already which has so many more options to execute code than the tsconfig so you should already never do that in an untrusted project, it's even possible on running npm install on the project already so it's a non issue
The real benefit would allow for much more flexible configuration, comments is just one small added benefit
Mainly it would allow the config to contain functions, which could be very useful for plugins, it would also allow export and import, as well as a more flexible composable approach than what currently exists

How does a bot make a judgment call? Especially for a feature that is not especially complex and has indeed had recent activity? I say reopen the ticket, there's design work to do by humans.

@RyanCavanaugh: @typescript-bot is misbehaving, please reopen this issue.

JavaScript tsconfig file is useful more than ever, due to the relatively new change in the behavior of ESLint + TypeScript parser.
To avoid a bug related to ESLint & tsconfig included files, a developer might want to reuse included & excluded directives, instead of hardcoding them.

one workaround is to import a tsconfig.json into ESLint config and reuse the directives, but since tsconfig is json5 (json w/ comments), the import involves an extra json5 library

This really needs to be re-assessed, we have large monorepo's, a hundred or so tsconfig.json with repeated content due to merging strategies when using extends which don't satisfy all the needs of how merging should happen. tsconfig.json is a thorn in our side for maintenance.

https://github.com/microsoft/TypeScript/issues/57486 highlights the need for this. It tries to invent complex syntax for merging/extending when it could just be done by the user in a code config file.

Please make this happen, other tools are using dynamic configs too so I can't be that big of a problem.

I don't see a good argument against this.  Simple json configs are nice (I'd prefer it if it works for my use case), but your simple configs doesn't allow for merging which is a pain in a world where monorepos are only gaining popularity.  Why not let users with more complex setups handle these ambiguities (which can often harbor on opinions)?  Then you'll make everyone happy.  You can still steer towards the simple json config in your docs, but if you have no plan on making tsconfig.json easier to use with monorepos (which might only make them more convoluted), then I hope you reconsider allowing js for more advanced use cases.  Just my 2c - thanks!


Loss test  - Learning the two-moons distribution with a normalizing flow

Tests to combine the two losses :  log likelihood and score.

Notebook : https://colab.research.google.com/drive/1t4DaL02o31OCOFifDaQS2B1f_QN5-iRq?usp=sharing

1000 updates
loss = - log(p(x))

1000 updates
loss = norm(score_hat - score)**2

1000 updates
loss = -log(p(x)) + mu* norm(score_hat - score)**2

10 000 updates
loss = -log(p(x)) + mu* norm(score_hat - score)**2

10 000 updates
loss = -nulog(p(x)) + mu norm(score_hat - score)**2


Add a subscribe to all button

Describe the problem
This app is awesome!
I found it on F-Droid today.
Could you add a button so can in one click subscribe to all the accounts one twitter account is subscribed to?
This is for me to not have to click hundreds or hundreds of times on subscribe using my Twitter account as a list of accounts to follow
Describe the solution
Add a button or feature to subscribe to all subscriptions of an account

There is already the Import from Twitter/X link when the subscription list is empty.
Do you mean a use case when there is already some existing subscriptions and then you want to add all subscriptions from a Twitter/X account?

There is already the Import from Twitter/X link when the subscription list is empty. Do you mean a use case when there is already some existing subscriptions and then you want to add all subscriptions from a Twitter/X account?

Where is it?
Maybe it should always be available
One scenario is you want to import a friend's twitter account subscriptions or if you have multiple accounts you will want to subscribe to all the stuff from all accounts

Where is it?
In the subscription list screen (second screen after the Feed screen), only when there are no subscription.

Maybe it should always be available
So I understand this is the feature requested: That the functionality to import from Twitter/X account always be available, not only when there are no subscription.

So I understand this is the feature requested: That the functionality to import from Twitter/X account always be available, not only when there are no subscription.

yes

It's kinda embarrassing for me to admit, but after some analysis to add a button for this functionality, I discovered that there is already one.
You see, I never use this functionality.
Here it is in the Subscriptions screen, the first icon with arrows:

Wow..
this icon (https://api.flutter.dev/flutter/material/Icons/import_export-constant.htmlmakes not sense to me, and probably other users.
Suggestions:

the merge arrow: https://api.flutter.dev/flutter/material/Icons/call_merge-constant.html
the cloud download icon: https://api.flutter.dev/flutter/material/Icons/cloud_download-constant.html (this one is self explicit)

Yes maybe the cloud download would be more intuitive indeed.

The version v3.5.4 has the new icon, so the import from the subscription list screen should be more intuitive.

The new icon to import is intuitive and works great, thank you all for your work!


Use correct eos id when masking out

By the way, why is keep_eos hardcoded as False in some places here? I searched through the blame and it used to use include_eos_in_output but it seems like there was something about maybe the hierarchical part here

@LWprogramming thank you! 🙏
so i used to keep the eos, and then taught the subsequent transformers to ignore the eos token. but it got to be too complicated, as i had to make sure the eos id is consistent across all wrappers, and do a bunch of self attention masking. so i redesigned it to simply remove the eos altogether


Feature Request: Offer More Flexible Websocket Pong Failure Policy

Right now, OkHttp's websocket pong rule is: it must receive a pong for every ping, and that pong must be received before the time comes for the next ping (see #3227 and this code). I'm sure that works in many cases, but it is a fairly rigid policy. For example, right now I am dealing with an IoT device where I have to ping frequently, but I might not get pongs all the time.
At the moment, I am trying to work around this by:

Identify a websocket failure due to a missed pong, by the icky approach of examining the exception handed to onFailure() and seeing if it is a SocketTimeoutException and has didn't receive pong in the message

Open a fresh websocket and hope the IoT device can deal (spoiler alert: it can't deal all that well...)

The current implementation is fine as a default, but it would be useful if we could have an asymmetric policy, with the ping interval at least somewhat independent of the pong timeout period. In my case, it would be something like:

Send pings every 2 seconds
Fail only if we do not receive a pong within 40 seconds

(or something like that)
Right now, we are using another websocket library. We are able to implement what we need there because all the guts are exposed, so we can send extra ping frames. We have configured the library's automatic ping logic to have a long period (e.g., 40 seconds) to prevent an early websocket failure due to a missed pong, with the extra ping frames satisfying the IoT device's need for more frequent pings. I am trying to switch over to OkHttp, because we're going to need some of what it offers (particularly in the SSL/TLS area) eventually.

Hm. My aspirations here are to make the pings + pongs dynamic and based on the other activity on the web socket.
Perhaps something like “send a ping after 10 seconds of inactivity” instead of “send a ping every 10 seconds”, and backing off from 10 seconds to 30 to 60 to 120, so that a web socket that doesn’t get much use also doesn’t need many pings. In such cases we could probably adjust the pong timeout to be based on a fixed deadline (say 30 seconds in high-latency environments, and 2 seconds in low-latency ones) rather than on the transmission time of the next ping.

Perhaps the ping delivery/pong requirement rules could be driven by a pluggable strategy implementation. The current strategy (pingInterval + pong received by the time of the next ping) would be one supplied configurable implementation. What you describe could be another. The project that I'm helping could develop a custom strategy that works with this IoT device. And so on.

@swankjesse on Android we could benefit from being able to control this.  e.g. in the background we probably favour losing the connection instead of trying (and depending on Android version failing) to keep a connection and radio alive in the background.

In addition to the original request, if there's an incoming traffic then we might be interested in considering the connection as not stale even besides no pong is received on time.

In addition to the original request, if there's an incoming traffic then we might be interested in considering the connection as not stale even besides no pong is received on time.

@swankjesse, re adding ping max failures. I think what we ultimately need here is a way of adding custom logic for the ping/pong handling failure scenarios. What is currently implemented is too limiting.

I would highly suggest to expose lower level ping/pong functions to the user:

Add onPing and onPong callbacks that are triggered when receiving a ping or pong message. Those callbacks should also provide the ping/pong data if any.
Add a sendPing and sendPong methods to the WebSocket class to allow the user to manually send a ping request or pong reply, along with some custom data if desired.
Add an autoPongReply option that indicates if the library should automatically reply to ping requests received or not, in case the user wants to handle the replies himself in the onPing callback (ex: with custom data). Another way without adding an option is to assume the user wants to handle the pong replies if he overrides the onPing function.

Having access to those methods and callbacks would allow the user full flexibility to implement any desired ping-pong logic at the application level if the default behavior isn't enough.

Browsers don't expose pings and pongs and I'd prefer we not either.
I suspect there's a good general purpose strategy we could pack in rather than requiring each user to learn the API and configure. (We might need very high level tuning parameters, so you could tell OkHttp if the device is a phone or a server inside a data center).

Browsers don't expose pings and pongs and I'd prefer we not either.

Why not ? Websocket libraries often do expose them.

I suspect there's a good general purpose strategy we could pack in rather than requiring each user to learn the API and configure.

Yes, you're right. A good general purpose strategy would answer most use cases and should be implemented. But one does not prevent the other. I think you should do both: expose the functions and provide a general purpose strategy you can turn on or off.

Why not ?

It's just our approach to building an API. There's lots of low-level libraries for users who want exact control over every byte. OkHttp works closer to the application layer: you tell OkHttp what request to make and it mostly just figures out the rest. We similarly don't offer knobs to select how our HTTP/2 flow control works, or how much data we buffer when streaming a request body.
You might argue that this is inefficient, but I think in aggregate it’s quite efficient. We can automatically make good decisions even as the context changes. For example, when we support web sockets over HTTP/2 it'll make very little sense to do pings the websocket layer and not the connection layer.
So if you’re with me, even just a bit, I'd love your best ideas on what our built-in ping policy should be.

Closing as low priority. OkHttp avoids knobs, there are other frameworks that allow infinite configurability, but it's not OkHttp.


ipcRenderer passes an event object as first argument since electron 0.35.0

Awesome project you've created here.
I wanted to do some development on it so I pulled it down and started poking at stuff; however, I quickly ran into a problem when attempting to add a file to the playlist.  I dug into the devTools and found out that links was actually an event object, so I took a look at the electron changelog.  It seems that they changed the API signature to ipcRenderer.on()'s callback in 0.35.0 (see https://github.com/electron/electron/releases/tag/v0.35.0) and playback uses ^0.35.4.  I made the change and the "Add Media" is working again.
I'm not sure why the bundled version doesn't exhibit this behavior.

@freeall thanks for merging my "repeat" PRs, could you also merge this due to the API being changed and the application not working off master?

thanks!

Thank you for all the PR's. Super good to see!

My pleasure.  This is a really fun project to work on.  I'll probably be sending some more incremental changes/features soon.


Create Right Function For Strings

Create a Right() function similar to the the Left() function.

Deployed to Production.


R SDK don't seem to have the look() method and can't find another way to run a look with a different filter

R SDK don't seem to have the look() method and can't find another way to run a look with a different filter
In Python and Ruby we ca do that using:
Python:
look = sdk.look(16)

request = create_query_request(
    query=look.query,
    filters={'track_motivations.track_id':'256'})

sdk.run_inline_query(
    'csv',
    request,
    cache=False)

Ruby
look = sdk.look(16)
output = sdk.run_inline_query(
    "png",
    {
        "model" => look.query.model,
        "view" => look.query.view,
        "fields" => look.query.fields,
        "pivots" => look.query.pivots,
        "fill_fields" => look.query.fill_fields,
        "filters" => {
            'track_motivations.track_id' => '255'},
        "sorts" => look.query.sorts,
        "limit" => look.query.limit,
        "column_limit" => look.query.column_limit,
        "total" => look.query.total,
        "row_total" => look.query.row_total,
        "subtotals" => look.query.subtotals,
        "dynamic_fields" => look.query.dynamic_fields,
        "query_timezone" => look.query.query_timezone,
        "vis_confif" => look.query.vis_config
    })

but we need a way to do the same using the R SDK. Is it possible?
Thanks

This package is not maintained (see issue 38). I suggest trying over at the official Looker SDK project: https://github.com/looker-open-source/sdk-codegen


input widgets not synchronized between clients

start examples/widgets_overview_app.py
open a second tab to the same UI
adjust any input widget (the SpinBox, the Slider)

While remi detects the input change, it does not update the position of the widget so other clients also see it.

@nzjrs I can't reproduce this. Is this already solved?

Up to you to decide. In my branch I reverted your commit which disabled input widget synchronization
https://github.com/loopbio/remi/commit/d930b214a0e26fc14744bf88089a952c5323dac0
You then reverted my revert here
https://github.com/dddomodossola/remi/commit/033cc770c54a4bdd2f4ab8839b4fa8c33baf7582
And then again here
https://github.com/dddomodossola/remi/commit/f42cc5eda8890507bf30d759e183064985bd19c2

You are right, I made a little bit of confusion about this, this because I was searching for the best solution.  The actual implementation seems to be fine with the additional javascript code that restores the focus.


Rebuild indices for all languages on preview

This updates the Makefile to rebuild indices of all languages so that translated articles and links to other languages show up in previews.
Note that I have never worked with Makefiles before, so I'm just taking a stab in the dark here—although it did seem to achieve the desired effect.

Untested ACK.  Thanks!


File does not save as .BIM

In the save dialog, "Save as type" does not seem to do anything.  For example, I started a new project, saved as "Project1" with Save as type = *.bim.  It should automatically attach .bim so that I end up with Project1.bim.  Instead I get Project1 with no extension.

Confirmed bug. .bim should be the default extension, when you don't explicitly specify that in the Save File dialog.

Fixed in 2.8.3.


Add install_demo_configuration Batch script for Windows

Description
As part of the effort to support windows distribution in 2.4.0 (https://github.com/opensearch-project/opensearch-build/issues/33) the security plugin needs a script to install the demo configuration on windows.
This PR introduces install_demo_configuration.bat with the same functionality as the bash script and installs the demo certificates and adds default config lines to opensearch.yml

Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement
Issues Resolved
https://github.com/opensearch-project/security/issues/2148
Testing
Tested by going through the steps outlined on https://github.com/opensearch-project/opensearch-build/issues/33.
Replace step 6 with cd plugins/opensearch-security/tools & ./install_demo_configuration.bat
Screenshot below shows using https and logging in with admin account credentials:

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @cwperks adding this to backport 2.x.

Codecov Report

Merging #2161 (465a117) into main (e5ab646) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2161      +/-   ##
============================================
+ Coverage     61.02%   61.14%   +0.11%
- Complexity     3233     3238       +5
============================================
  Files           257      258       +1
  Lines         18110    18109       -1
  Branches       3229     3224       -5
============================================
+ Hits          11052    11073      +21
+ Misses         5476     5457      -19
+ Partials       1582     1579       -3

Impacted Files
Coverage Δ

...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java
84.78% <0.00%> (-0.33%)
:arrow_down:

...ch/security/privileges/PitPrivilegesEvaluator.java
96.42% <0.00%> (ø)

.../opensearch/security/OpenSearchSecurityPlugin.java
79.95% <0.00%> (+0.08%)
:arrow_up:

...earch/security/dlic/rest/api/MigrateApiAction.java
4.34% <0.00%> (+0.18%)
:arrow_up:

...earch/security/privileges/PrivilegesEvaluator.java
72.38% <0.00%> (+0.35%)
:arrow_up:

...arch/security/configuration/ClusterInfoHolder.java
66.66% <0.00%> (+0.81%)
:arrow_up:

...ty/configuration/ConfigurationLoaderSecurity7.java
70.43% <0.00%> (+4.04%)
:arrow_up:

...nsearch/security/dlic/rest/api/AuditApiAction.java
68.08% <0.00%> (+4.25%)
:arrow_up:

...ecurity/configuration/StaticResourceException.java
25.00% <0.00%> (+25.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Lets update the plugin_install.yml to deploy OpenSearch windows and test this new script.

Good idea - I will see what it takes to add this to the github workflow.

Lets update the plugin_install.yml to deploy OpenSearch windows and test this new script.

Good idea - I will see what it takes to add this to the github workflow.

Plugin install currently runs on Ubuntu. In that case we will have to add a new workflow for windows.

@opensearch-project/security This PR is now ready for further review. Thank you @scrawfor99 for figuring out how to automate the validation of this change by adding a new job in plugin_install to install this on a windows running and verify the node is brought up successfully.
Note: For the merge into main we are disabling this job because the distribution for 3.0.0 is not stable and the node does not get brought up successfully. This job will be enabled in 2.x when this change is backported.

@peterzhuamazon Tagging in case you know someone who can help answer a problem we are facing. As part of this PR to add the batch script for install_demo_configuration.bat this PR adds a new job in the plugin_install.yml Github Action to verify the installation on windows - as we also do with linux. This runs on the windows-latest github runner.
We are currently facing a problem where the opensearch node does not startup (the command .\bin\opensearch.bat because the windows-latest runner is invoking the command as admin and opensearch does not allow the node to run as admin.
In the linux install we add a user and run with the newly created user. It looks like the corresponding windows commands would be:
net user "username" "<password>" /add
runas /user:username ".\bin\program.bat"

but runas prompts for user input and both passwordless and piping in a password are unsupported.
The github action we created works on 2.x, but not on 3.0. It only works on 2.x because this PR (https://github.com/opensearch-project/OpenSearch/pull/4656) has not yet been backported to 2.x.

@dbwiddis Tagging to see if you have any ideas. See the comment above.
The gist of the problem is that the commands inside of the windows-latest Github Action runner run as admin and its not possible to bring up an OpenSearch node using admin in windows.

@cwperks looks like you can use runas with a trust level:
runas /trustlevel:0x20000 "YourCommandHere"

I don't have a windows machine to test, but runas /showtrustlevels should tell you what the numbers mean.

Another idea is using Powershell:
powershell "Start-Process -Verb Runas '<command here>' -Wait"

There's this compiled program you could wrap around your program:  https://github.com/wez/EleDo

@dbwiddis Thank you for the quick reply! Trying these ideas out now.

@cwperks and @scrawfor99 poking back in as I see some activity trying the trustlevel. Some thoughts:

I think it requires a full path, won't work with the relative link
another option I saw is to invoke via explorer.exe. It always starts with least privileges. But I'm not sure the syntax for that.
I saw the following batch file that claims to work:

Set ApplicationPath="C:\Program Files\SomeApp\testapp.exe"
cmd /min /C "set __COMPAT_LAYER=RUNASINVOKER && start "" %ApplicationPath%"

I am going to jot down a running list of the things I tried so that if we run into this problem again in the future we have an idea what is worthwhile:
~trustlevel 2000 with relative path~
~trustlevel 2000 with absolute path~

Command-line switch to disable the running as root check for tests ... 😉

Haha that is certainly an option and may be what I end up doing. I do greatly appreciate all your suggestions and help with this. I think GitHub Actions is still a little finicky and I am not the Windows expert others may be.

At one point in time there may have been something similar to:
if (Boolean.parseBoolean(System.getProperty("os.insecure.allow.root"))) {
      logger.warn("running as ROOT user. this is a bad idea!");
}

in Bootstrap.java, but there is no such option.
I'm not sure if it helps, but github's documentation says UAC is disabled on the runners. See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#administrative-privileges
Ideally, the workflow creates a user opensearch and uses this user account to bring up a node.

@opensearch-project/security The new plugin-install job on windows is working now after the revert from core and new snapshot distribution. This is ready to be reviewed again - there is a link to a snapshot distribution that will need to be updated when an official distro is published.

Removing the old Plugin Install task from required checks and replace it with linux-install and windows-install to unblock the merge.

I am going to jot down a running list of the things I tried so that if we run into this problem again in the future we have an idea what is worthwhile:
~trustlevel 2000 with relative path~ ~trustlevel 2000 with absolute path~ ~Start-process runas~ ~Normdo -- lacks enough documentation for me to debug running errors~ ~explorer.exe does not start~

Tried a few more things, documented here

See https://github.com/opensearch-project/OpenSearch/issues/4942#issuecomment-1301733503

Thank you @dbwiddis. I saw your comment this morning and was trying to apply it on this branch https://github.com/cwperks/security/tree/windows-paexec but have still been unsuccessful in bringing up the node. I am able to use both psexec and paexec on a windows computer, but still struggling within the github runner.

I found that having the .cmd extension on the "batch file" seemed to do something magical that I can't explain..

Specifically: cmd /c xyz only works with built in commands.  But it worked calling xyz.cmd directly.  And did not work with some other extensions.

https://stackoverflow.com/questions/148968/windows-batch-files-bat-vs-cmd
Seems like not that much differences?
I am also wondering as I indeed see more .cmd back in the day than it is now.
Thanks.

Seems like not that much differences?

I suspect it was the error value difference that I saw...


Migrate to ethers v6

Umbrella issue just to remind us that we are doing that :)

Assigned that to you @sealer3 .
Feel free to link any child PRs/discussions here, also to push smaller PRs that you think will make it easier to deal with given this is a big migration.

Discussion related to the JSON-RPC formatter: https://github.com/ethers-io/ethers.js/discussions/4324

I couldn't find a similar JSON-RPC formatter class in ethers v6, so one is included in the PR. I added full typing to it, so it should be easy to adapt to other ethers types and verify compatibility with them.

Feel free to take a look into viem.sh too ;)


adding trigger info to schema info

adding trigger information from public schema that can be used by LLMs.

LGTM;


Hi, I just found out when open halfRes with true, the ao in map also have some same problem....

        this.n8ao = new N8AOPass(this.scene, this.camera, this.width, this.height);
        this.n8ao.configuration.gammaCorrection = true;
        this.n8ao.configuration.halfRes = true;
        this.composer.addPass(this.n8ao);

I'm not sure what you mean from that one image...

I'm not sure what you mean from that one image...

The old problem  on https://github.com/N8python/n8ao/issues/14, But this time it happened when i set "halfRes" with TRUE

Try version 1.6.8.

That should work.


How could to use MaterialSkin in VS2010?

Hi ,
My IDE is vs2010. Could I use the library? or regretful to give up?

I have solved this problem. change the project file "MaterialSkin.csproj" to the current version. and change some property of controls which is only supported in VS2015


[REQ] Video Background Support

I would like to set a video file as a background. Apple has a similar feature on MacOS devices. SDDM login screen does support this feature too: https://github.com/3ximus/aerial-sddm-theme . It would be cool to have this on a lock-screen.

As a workaround, you could set hyprlock's background color to something transparent (e.g. 0x00000000) and write a script that plays a looped video in fullscreen, runs hyprlock, and then closes the video player afterwards. Then you just run the script instead of directly running hyprlock.

+1


Add Description for Deploying to Nomad

this adds a bit of documentation to the readme which should help anyone trying to deploy valheim-server to nomad. I'm having good success with the resource limits so far.

@Subito thank you for the PR!
Just add the file valheim.nomad to the repo and then have user's curl it. Like the systemd example essentially.


[NWS-919][NWS-1569] Remove ng2-smart-table from package.json and replace use of components

Invoices:
Contracts:

Contractors:

Users:

Teams:

Promotions:

Courses:


How to Build regular Version of traccar client?

I wants to build regular version of traccar client.when i build hidden version is running and  showing error like "Error Type 3".
I wants to know how to build regular  version of traccar client?and give me the link to download link for regular version.

To build select "regular" flavor and build it. It's a standard Android gradle project. There is a lot of information on internet on how to build it.
If you want to download binaries:
https://github.com/tananaev/traccar-client-android/releases


Fix indentation (tabs -> spaces) + enable checkstyle

from now on the build will fail in case the source
files use tabs for indentation

The diff is huge, but it is only whitespace changes.
Depends on https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/251

+1 :)

+1, definitely useful

Replaced by https://github.com/droolsjbpm/droolsjbpm-knowledge/pull/155


【API-DOC】2 warning in generated API document

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

What happened:

missingProperty: description
additionalProperty: title

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

missingProperty: description

This is actually you did not fill in the description in Definition.Results. eg: Results: def.DataErrorResults(""),

additionalProperty: title

I'll take a look at this.


Add link to slides for  improving-code-without-losing-your-mind

Added a link to the slides of Chris May's talk at PyTexas 2023.

Thanks!

Thanks! Sorry for not paying enough attention. JSON is such a demanding thing. :D


Use BatchSpanProcessor in examples instead of SimpleSpanProcessor

Related to #36219

API change check
API changes are not detected in this pull request.

Closing in favor of #36230


{"error":"json: cannot unmarshal number into Go struct field resultStory.hits.children of type hackernews.Children"}

Can you share a reproduction?

Fixed!


yt-dlp-(nightly|master): Add manifests

(the unofficial build) yt-dlp-daily has long been deprecated, either the nightly manifest should be reusing it's name, or it should be removed. At this point, it's been so long, I'd assume everyone who used the daily package has likely moved onto a different package, it's much older than stable now, so a fresh start (especially considering the different repos) seemed like the way to go.
Closes #1666
Closes #1667
Relates to #1047, #1101

[x] I have read the Contributing Guide.

/verify


"warning: 'substring(from:)' is deprecated" when build with swift4.0

warning: 'substring(from:)' is deprecated: Please use String slicing subscript with a 'partial range from' operato

Fixed


[BUG] CI: switch GHA workflow runner to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04

Describe the bug
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see https://github.com/actions/virtual-environments/issues/6002

Done with ubuntu-latest. Testing ...


fix: fix dry run for base reporter

Fixed dry run mode for base reporter
fixes https://github.com/elastic/synthetics/issues/745

LGTM, although I added a comment, let me know your thoughts.
btw, I tested it and works well 🎉


Support wildcards in probe path

Fixes #688. One case that remains tricky is usdt:/my/app/* because path includes leading and trailing colons in the lexer. It works if you provide a probe name, though. Maybe this is fine for now.
I'm not sure whether all the tests are needed or wanted, but they were helpful for testing, so I left them in.

Looking at the current parser tests, I see there's a one for "wildcard_attach_points" at the moment, so I think it'd be better to put your new ones in a new "wildcard_path" test case.
Would also be good to add some semantic analyser tests to catch the bug I mentioned in the last comment. Would need to mock out resolve_binary_path() (or similar) to avoid depending on a user's filesystem layout.

Okay, sounds good. I was able to attach to copies of the usdt_test binary in testprogs with this change, but I want to verify that my test was actually matching more than one binary. The same bug may exist for all providers.
Thanks for the feedback.

I cleaned up the tests and fixed a couple of issues that turned up in my usage testing.
@ajor For the scenario you mentioned, this is the output:
# ls /tmp
a.out      b.out

# bpftrace -e 'uprobe:/tmp/*.out:main { printf("hello %s\n", comm) }'
path '/tmp/*.out' must refer to a unique binary but matched 2

Listing probes will now display the expanded path, i.e. without wildcards:
# bpftrace -l 'uprobe:/tmp/a.*:main'
uprobe:/tmp/a.out:main
uprobe:/tmp/a.out:main

@danobi Fixed and rebased. Nice catch on the indentation.
The test cases that I removed in the final commit apparently only work when /bin/sh is bash. CI must have been upgraded to a newer Linux that uses a different shell (dash?) after I opened this. Using dash as my shell locally, I see that its behavior for command -v ... is different from bash's in that dash will only return a single result even if there are several matches. Bash's version will return all matches.
I'd like to work on removing our dependency on command in a followup PR if that sounds good to you.

@acj Ah got it. Yeah, that would be great if you could remove command -v shellout. Seems like that was a bad idea after all.
Thanks for the patch!


code for community tutorial

Sample code at https://github.com/GoogleCloudPlatform/community/pull/538

@wisdal Yes, good observation. I created a new one because if we have a community article based on code, we want have control over the code.
The README is now updated to reflect this!


end of v2 Owner API in August 2024

See; https://developers.hubspot.com/changelog/sunset-v2-owners-api?utm_campaign=customer-marketing&utm_medium=email&utm_content=295220657&utm_source=hs_email
Upcoming Sunset: v2 Owners API
Announced: February 20, 2024
Live: August 30, 2024
On August 30, 2024, we will be sunsetting the v2 of the Owners API.
We encourage users to migrate to the v3 of the Owners API because all endpoints from https://api.hubapi.com/owners/v2 will be sunset and return a 404 error response message.

Does this repo support the v3 version of the API


PrivateNet Integration

Hi,
Is this code only worked in Ropsten? I just want to integrate this code to my private Net.
I saw one command : npm run migrate -- --network Ropsten ( works in Ropsten) instead of this I used
npm run migrate -- --network localhost:8545. But it's not connecting. How will I resolved my issue?
My network id : 54 ( That i gave to truffle.js).

Please follow the instructions in the README.


Legend colors not appearing in Internet Explorer 11.09

From SB/5015222, example here

IE seems to drop the first style definition (so style="background:red" won't display the color but style="some_css_property:value; background:red" will do).
I'm still trying to figure out what's going on here :|

Also SB/5281007

Also happening for S/B 5480615

Also S/B 6023862

Also S/B 6719946

Also http://lingroadshow.com/resources/englishes-in-australia/vocabulary/mapping-words-around-australia/

hi @voltagex could you let me know how do yo create the legend? Is it a custom one made using HTML code? If so could you attach the exact code?
Thanks.

Hi @voltagex
could you let me know the kind of legend you apply to the maps? Are they custom maps using HTML template? If so could you attach the exact code?
Thanks.

That example is not mine. If you go into the UI, create any map with multiple colours and use the share link in IE11 you should see it.

After many tries I finally reproduce the problem. It happens when you create a category legend through the wizard and later go to the legend HTML editor and use it as the legend code.
This is the code generated for an IE working legend:

Next, is a non working code generated after going to the HTML legend editor:

The issue is really weird. It happens on the editor and the public map, but it doesn't happens (it works on IE too) if your visualize the vizjson with cartodb.js.

It's broken for me with an older version of cartodb.js (3.14.5)

@acanimal could the editor/public map be using an older version of cartodb.js?

This happens with every legend style in the wizard. You just need to go to Custom style side and press apply. Even if you don't change anything. It doesn't matter do you make a map with Chrome, FF or IE11. After pressed apply in custom legend colors are gone in IE11 legend.
Hope you find solution or workaround.

Looks like the styles aren't applied to the bullets. The legend comes across as a custom template with each bullet having a style="...", but in IE10+ that attribute is missing. So it must be somewhere in the legend generation.

Seeing some weird behavior. At one point I thought the issue was fixed: https://stocktonca.beta.mapgeo.io/?latlng=37.973764%2C-121.388449&panel=themes&themes=["zoning"]&zoom=11
hence it working here, but when I deployed to production (the only difference is minified assets) here: https://stocktonca.mapgeo.io/?latlng=37.973764%2C-121.388449&panel=themes&themes=["zoning"]&zoom=11 it no longer works.

Similar issue. Maybe realted: https://github.com/CartoDB/cartodb.js/issues/1072

FYI the above related issue's fix did not fix this issue. So I don't think it's related.

This is not an issue in Edge.

S/B 10067067 - User is also reporting for Firefox 45.0.1 on Windows 10 Home.

I think I've fixed this in my map by adding a fake style to each .bullet div: so something like

 in the custom HTML.
As @javierarce suggests IE seems to drop the first style. Strange!

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Duplicate labels on the same text, highlights more than the selected text

Describe the bug
Duplicate labels on the same text, highlights more than the selected text
To Reproduce
Steps to reproduce the behavior:

Create a "Named Entity Recognition" project
Add a task
Select a label and highlight a text
Select another label and highlight the same text
Press submit button
For one of the labels the highlight will appear from beginning of line till the end of selected block

Expected behavior
Submitting two labels to one block of text should highlight selected text only.
Screenshots
Before clicking submit/update button

After clicking submit/update button

Environment:

OS: macOS, ubuntu
Browser: chrome, firefox
Labelstudio Version: 0.5.0

Not in the latest version. Thank you!

https://github.com/heartexlabs/label-studio-frontend/issues/117

@hlomzik Can you please check this and open this issue?


[3.7.0][sort-comp] Error during linting

This new version introduces an error during linting
eslint-plugin-react/lib/rules/sort-comp.js:307
    var propertiesNames = properties.map(getPropertyName);
                                    ^
TypeError: Cannot read property 'map' of undefined

My settings are:
"react/sort-comp": [2, {
            "order": [
                "constructor",
                "lifecycle",
                "everything-else",
                "render"
            ]
        }],

Strangely, I'm seeing this on 3.2.0 as of a few hours ago. Any idea how that could be possible?

Thanks for being so fast @yannickcr ;)

No more issues... thank you for the speed @yannickcr !


Refactor Ontolia as a separate service

Create a new repository for Ontolia and refactor it as a standalone service.
Key features:
Command line interface
Customizable output directory

This is done now. Documentation and code at: https://github.com/PDCMFinder/ontolia


Updates to the contribution guide

Some small suggestions to the contribution guide to improve usability.

Thanks for the review @evaline-ju. Ready for review again.


Failing installation on Docker with node 12.14-slim

Node Version: node:12.14-slim
Platform: Linux 022e35934fe2 5.4.39-linuxkit #1 SMP Fri May 8 23:03:06 UTC 2020 x86_64 GNU/Linux
Compiler: gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
Module: pg-native / libpq

I am doing an apt-get update && apt-get install with the following dependencies, some of which were suggested by the pg-native module, but am still getting this error.

build-essentials
make
g++
gcc
python
libpq-dev
postgresql
postgresql-client
postgres-server-dev

It is installing fine on macOS Big Sur with node 12.18.3. Any help would be appreciated, thanks!
Verbose output (from npm or node-gyp):
error /app/node_modules/libpq: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: /app/node_modules/libpq
Output:
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp info find Python using Python version 2.7.13 found at "/usr/bin/python"
gyp http GET https://nodejs.org/download/release/v12.14.1/node-v12.14.1-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v12.14.1/node-v12.14.1-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v12.14.1/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v12.14.1/SHASUMS256.txt
gyp info spawn /usr/bin/python
gyp info spawn args [
gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/app/node_modules/libpq/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/root/.cache/node-gyp/12.14.1/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/root/.cache/node-gyp/12.14.1',
gyp info spawn args   '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/root/.cache/node-gyp/12.14.1/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/app/node_modules/libpq',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
find: '/usr/pg*': No such file or directory
gyp: Call to 'which pg_config || find /usr/bin /usr/local/bin /usr/pg* /opt -executable -name pg_config -print -quit' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:223:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 5.4.39-linuxkit
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /app/node_modules/libpq
gyp ERR! node -v v12.14.1
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok

gyp ERR! node-gyp -v v5.0.5

Time to upgrade node-gyp using #2272

find: '/usr/pg*': No such file or directory
gyp: Call to 'which pg_config || find /usr/bin /usr/local/bin /usr/pg* /opt -executable -name pg_config -print -quit' returned exit status 1 while in binding.gyp. while trying to load binding.gyp

these are all related to dependencies of the addon you're compiling, you should head over to https://github.com/brianc/node-libpq and find out what dependencies you should have installed and where. These are not related to node-gyp which is only handling the compile step outlined by libpq.

I tried upgrading the global node-gyp version and am still getting the error on<EMAIL_ADDRESS>-- I went ahead and opened an issue on libpq.

Turns out I had messed up some config in my Dockerfile, apt-get update && apt-get install -y libpq-dev g++ make was sufficient.

Thanks @betsy-fu! Your solution worked for me too. But I am using node 16.14.2-slim.


Swift 4 linux compat

This fixes a couple of minor compatibility issues:

Exposes defaultAnyTypeURLPrefix for compatibility with Swift 4
Uses an explicit NSData-to-Data conversion for compatibility with Swift Linux
Comments out the body of one test that won't work at all with Swift Linux < 3.1

There are still some warnings with the latest dev snapshots I need to sort through.  But I think this fixes the last of the actual build errors and test failures.

I included a fix for a potential bug that was being flagged by the latest compiler snapshots.


Update Travis

Move to new travis "trusty tahr" environement and update dependencies

It looks like using the phantomJS version that comes with with trusty is still a bit old, it will probably still work better if we use 2.1.1 directly.

Are we still getting that weird Mongo JS loading failure?

Yeah unfortunately those errors are still popping up. Do you know what version of mongo the trusty beta is running? I believe we are planning to target 3.4 for the next release, is that the version they are running or do we need to add the 3.4 apt sources?

I don't. The old travis image used 3.2, which necessitated us downgrading to 3.0. It look like this passed so I would assume it's using 3.4?

It looks like it is running on 3.2 still, I actually had a PR in before to bump to 3.4 #800 and it got merged and somehow reverted.

#800 was merged into cypress_3_2, not master, so we're still building on master with 3.0

Oh in that case this is gonna cause a bit of merge conflict for the person merging 3.2, perhaps this should be put against cypress_3.2?

Changed base to 3.2. I mostly did this as an experiment, but if you want this merged this into 3.2, go ahead and deconflict.

Scenario: Can Multi Upload to the Same Task on a Measure Test Multiple Times is having intermittent failures again as a result of this PR, it could be the new container infrastructure is a lot slower to run than the old travis which is causing it to timeout. If we merge this in I worry we will start to get a lot of intermittent test failures again. There will probably need to be some investigation into why exactly this has popped back up.

Small followup on the previous error, it seems that the random failures may be happening due to the trusty container infrastructure running significantly slower, the old jobs seem to take between 17-20 minutes on precise but take 33-36 minutes on trusty. I'm going to look into bumping the timeout to see if that helps. Also going to look into whether the page still has a pending refresh based on the html output of this failing test.

Sorry for hijacking this PR, unfortunately the issue is made much worse by this version of travis so testing on this branch is the most convenient place to do so. I have tried a few changes and I hope they help improve the reliability.

No problem, I just wanted to do a few experiments (some of which failed, like switching from poltergeist to webkit). If it's being useful, I'm glad it's living on!

I believe the multi upload is stable at this point. Unfortunately other tests are still intermittently failing, perhaps simply due to how slow it seems our tests our running on the trusty beta. I would suggest we hold off on merging this until we have more information about why they are running so badly, I have sent an email to travis support to see if they have any input.

I have moved all of the fixes for this PR in to a new pull request specific to those fixes instead of them being tied in with the travis update.


Include Timescale as adopter

Just saw @jpkrohling LinkedIn post an decided to include us in the list,
as we have been using OpenTelemetry for a while already.
Thanks!

Hi! Could you sign the CLA?

Hi @theletterf , I have tried to sign it already and it's awaiting for my employer authorization.
Thanks

Thanks @jpkrohling , I believe it's in the appropriate section. Timescale is now just focused on offering the best cloud timeseries/vector/analytics database, built on PostgreSQL.

Your blog post indicates otherwise, it's not about how timescale uses OpenTelemetry internally to monitor their own infrastructure. Especally the last sentence indicates that this is better suited in the vendors list: "If you're looking for a time-series database to store your metrics, check out Timescale."

Thanks @jpkrohling , I believe it's in the appropriate section. Timescale is now just focused on offering the best cloud timeseries/vector/analytics database, built on PostgreSQL.

Your blog post indicates otherwise, it's not about how timescale uses OpenTelemetry internally to monitor their own infrastructure. Especally the last sentence indicates that this is better suited in the vendors list: "If you're looking for a time-series database to store your metrics, check out Timescale."

Thanks for your response @svrnm , that's accurate.
Maybe we should not include that blog post, as it's from times when we were actively promoting Promscale, which has been already discontinued.

@adolsalamanca any updates?

Closing old PR


chore(deps): update dependency gitlab-org/ci-cd/docker-machine to v0.16.2-gitlab.15-rc2

This PR contains the following updates:

Package
Update
Change

gitlab-org/ci-cd/docker-machine
patch
v0.16.2-gitlab.26 -> v0.16.2-gitlab.15-rc2

Release Notes

gitlab-org/ci-cd/docker-machine (gitlab-org/ci-cd/docker-machine)
v0.16.2-gitlab.15-rc2
Compare Source
New release of GitLab's fork of Docker Machine is out!
v0.16.2-gitlab.15-rc1
Compare Source
v0.16.2-gitlab.1-rc1
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update (v0.16.2-gitlab.15-rc2). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Any way to show two months view through options?

I need to show two months view in my page to select the date. I also checked in options but didn't find anything regarding this requirement.

What do you mean by two months view? Which data should be displayed and when? Maybe you could provide a mock-up.


[BUG] FirebaseApp.allApps returns only apps configured within the same module

[READ] Step 1: Are you in the right place?
Yes.
[REQUIRED] Step 2: Describe your environment

Xcode version: 11.1
Firebase SDK version: 6.1.0
Firebase Component: Core
Component version: 6.1.0

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
FirebaseApp.allApps returns only apps configured within the same module. So if there are multiple modules (moduleMain, moduleNetwork, moduleAuth) and the FIR instance is created in moduleMain, calling FirebaseApp.allApps returns nil when called from moduleNetwork or moduleAuth.
Expected behaviour:
FirebaseApp.allApps should return all apps instantiated within the project, not a module.

What exactly do you mean by "module"?

@paulb777 module as in a separate framework within the project which incapsulates some app's logic (in the example above all network related code is stored in a moduleNetwork, which was created as File -> New -> Target... -> Framework and is getting imported by other modules whenever I need to make a network call).

@valzevul Firebase is a linked statically and can only be linked once into an app. It cannot be linked into multiple dynamic frameworks.

@paulb777 I see, thanks for the clarification.
It also seems that the answer in #4080 contradicts with yours, as there the comment mentions that using the same FIR instance from different frameworks actually works:

I tried reproducing it with a separate library module, instead of a unit test module, and still cannot reproduce what you saw.

I have tried with both different ID and same ID, the callback is called as expected though.

Would you have any advice on working around that issue?

Having multiple copies of Firebase linked can lead to non-deterministic behavior.
To use Firebase in multiple modules, they should be statically linked so that Firebase only gets included once in the app.

@paulb777 thank you for the explanation. I think this issue is resolved then.


docs-bug(Drag&Drop): Drag Events with typos

Documentation Feedback
A series of events on the Drag & Drop documentation are mispelled.
It indicates like:
cdkDragStart, cdkDragEnd or cdkDragMove
and the correct are:
cdkDragStarted, cdkDragEnded or cdkDragMoved
Don't know how many may be wrong. But I'm positive sure that you were already alerted on this issue.
So its just a reminder
Affected documentation page: https://material.angular.io/cdk/drag-drop/api#CdkDragMove

I don't think that they're typos. One is the name of the event and the other is its interface, they don't necessarily have to be the same. Furthermore, renaming them now would be a breaking change.