--fstab not being run on burn

And I know it doesn't list --fstab as something that occurs in --burn, but I sure wish it did - I have specific, not general, fstab lines that I would like to do only when burning specific pi's.

As I mentioned in https://github.com/gitbls/sdm/discussions/98, fstab will be included in the system plugin with the upcoming release. I didn't go into detail, but here's the scoop:
When fstab is provided as an argument to the system plugin, it will accept a comma-separated list of files on the host system, each of which will be appended to /etc/fstab per below.
Each file will be copied into the IMG, and a deferred action will be added to /etc/sdm/auto-1piboot.conf for each file. auto-1piboot.conf is processed as part of the first system boot, and each of the fstab files will be appended to /etc/fstab as part of the first boot in the order in which they are specified.
The reason I do it this way is that other actions (fstab dependencies) may also be deferred until the first system boot . If the dependencies aren't in place, that could cause fstab to fail, thus causing the first boot to fail.
Deferring the fstab modifications to the first system boot reduces the likelihood that will happen, but of course that's ultimately up to you.
Since fstab will be part of the system plugin, you can use it during customization or burning.
Hope this will provide you with the fstab flexibility you want. Other arguments to the system plugin will also accept multiple files. This of course will all be documented when the release is published sometime during the week of 9/11.

I missed that part, sorry. (sheepish face...) That will completely take care of fstab for me.

No worries! 20-some command switches are changing all at once.  JFYI exports will work the same way, except the append won't be deferred to the first system boot. modprobe, sysctl, and all the cron-* arguments also work the same, but copy new files into the prescribed target directory, rather than appending to a single file.
I'm looking forward to the release, b/c it will clean up a LOT of things I wasn't totally happy with. But there's testing and documentation yet to be done.

Would you please email me at gitbls @ outlook.com ? I'd like to enlist your assistance with something, if possible.
Thx

This is fully corrected in V9.1.1 which is now released. The system plugin can be applied during a burn and supports your use case. Please verify and close. Thx!

My customise command line is :-
sudo sdm --customize 2024-07-04-raspios-bookworm-arm64-lite.img
--extend --xmb 1024
--showapt
--apt-dist-upgrade
--plugin-debug
--plugin @./customize.plugin
--restart
--batch
customize.plugin contains :-
user:"deluser=pi"
user:"addgroup=docker,2000"
user:"adduser=carl|uid=1000|password=letmein123|groupadd=docker"
apt-file
chrony
apps:"name=removal1|remove=fake-hwclock"
apps:"name=baseapps|apps=git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-static,rsync,systemd-container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget,xz-utils,file,zram-tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables,firewalld,fail2ban,btrfs-progs,python3-icmplib,sg3-utils,lsscsi"
disables:"piwiz|triggerhappy"
system:"name=1stcall|service-disable=apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd|eeprom=beta"
quietness:"consoleblank|noquiet=keep|nosplash=keep|noplymouth"
copyfile:"from=/home/carl/dev/mysdm/override.conf|to=/lib/systemd/system/nfs-blkmap.service.d/|mkdirif"
My burn command line is :-
sudo sdm --burn /dev/mmcblk0
--host rpicm4-1.1stcall.uk
--convert-root btrfs
--expand-root
--regen-ssh-host-keys
--gpt
--showapt
--plugin-debug
--plugin @./burn_rpicm4-1.plugin
2024-07-04-raspios-bookworm-arm64-lite.img
and burn_rpicm4-1.plugin contains :-
apt-addrepo:"repo=deb https://download.docker.com/linux/debian bookworm stable|gpgkey=/home/carl/dev/mysdm/docker.asc"
apps:"name=docker|apps=docker-ce,docker-ce-cli,containerd.io,docker-buildx-plugin,docker-compose-plugin"
#apps:"name=mate|apps=task-mate-desktop,mate-desktop-environment-extras"
#apps:"name=guiapps|apps=gparted,firefox,code"
bootconfig:"section=[cm4]|dtparam=i2c_vc=on|dtoverlay=i2c-rtc,pcf85063a,i2c_csi_dsi"
L10n:"host"
system:"name=myfstab|fstab=/home/carl/dev/mysdm/myfstab"
trim-enable:"disks=all"
imon
The resulting history file is :-
2024-08-20 00:41:59 * Start Configuration
2024-08-20 00:41:59 > Command Line: /usr/local/bin/sdm --customize 2024-07-04-raspios-bookworm-arm64-lite.img
2024-08-20 00:41:59   --extend --xmb 1024 --showapt --apt-dist-upgrade --plugin-debug --plugin @./customize.plugin
2024-08-20 00:41:59   --restart --batch
2024-08-20 00:41:59 * Host Information
2024-08-20 00:41:59    Hostname:  rescue.1stcall.uk
2024-08-20 00:41:59    Memory:    7996444 kB
2024-08-20 00:41:59    uname:     Linux rescue.1stcall.uk 6.6.31+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/Linux
2024-08-20 00:41:59    Raspberry Pi Model: Raspberry Pi Compute Module 4 Rev 1.0
2024-08-20 00:41:59    os-release Name: Debian GNU/Linux 12 (bookworm)
2024-08-20 00:41:59    Version: 12 (bookworm)
2024-08-20 00:41:59    sdm Version: V12.6
2024-08-20 00:41:59 * IMG Information
2024-08-20 00:41:59    Name: 2024-07-04-raspios-bookworm-arm64-lite.img
2024-08-20 00:41:59    Date: 2024-07-04
2024-08-20 00:41:59    RasPiOS Version: 12
2024-08-20 00:41:59    RasPiOS Architecture: 64-bit aarch64
2024-08-20 00:41:59    os-release Version: 12 (bookworm)
2024-08-20 00:41:59 * Plugins selected:
2024-08-20 00:41:59    * user
2024-08-20 00:41:59        Args: deluser=pi
2024-08-20 00:41:59    * user
2024-08-20 00:41:59        Args: addgroup=docker,2000
2024-08-20 00:41:59    * user
2024-08-20 00:41:59        Args: adduser=carl|uid=1000|password=letmein123|groupadd=docker
2024-08-20 00:41:59    * apt-file
2024-08-20 00:41:59    * chrony
2024-08-20 00:41:59    * apps
2024-08-20 00:41:59        Args: name=removal1|remove=fake-hwclock
2024-08-20 00:41:59    * apps
2024-08-20 00:41:59        Args: name=baseapps|apps=git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-static,rsync,systemd-container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget,xz-utils,file,zram-tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables,firewalld,fail2ban,btrfs-progs,python3-icmplib,sg3-utils,lsscsi
2024-08-20 00:41:59    * disables
2024-08-20 00:41:59        Args: piwiz|triggerhappy
2024-08-20 00:41:59    * system
2024-08-20 00:41:59        Args: name=1stcall|service-disable=apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd|eeprom=beta
2024-08-20 00:41:59    * quietness
2024-08-20 00:41:59        Args: consoleblank|noquiet=keep|nosplash=keep|noplymouth
2024-08-20 00:41:59    * copyfile
2024-08-20 00:41:59        Args: from=/home/carl/dev/mysdm/override.conf|to=/lib/systemd/system/nfs-blkmap.service.d/|mkdirif
2024-08-20 00:41:59 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1338140 1K-blocks (1.4GB, 1.3GiB) free
2024-08-20 00:41:59 > Copy sdm to /usr/local/sdm in the IMG
2024-08-20 00:41:59 > Copy --plugin @file(s) to /mnt/sdm/etc/sdm/assets/pluglist
2024-08-20 00:41:59   ./customize.plugin
2024-08-20 00:41:59 * Start Phase 0 image customization
2024-08-20 00:41:59 > Run Plugins Phase '0'
2024-08-20 00:41:59 > Run Plugin 'user' (/mnt/sdm/usr/local/sdm/plugins/user) Phase 0 with arguments: 'deluser=pi'
2024-08-20 00:41:59 * Plugin user: Start Phase 0
2024-08-20 00:41:59 > Plugin user: Keys/values found:
2024-08-20 00:41:59    deluser: pi
2024-08-20 00:41:59 * Plugin user: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'user' (/mnt/sdm/usr/local/sdm/plugins/user) Phase 0 with arguments:
2024-08-20 00:41:59   'addgroup=docker,2000'
2024-08-20 00:41:59 * Plugin user: Start Phase 0
2024-08-20 00:41:59 > Plugin user: Keys/values found:
2024-08-20 00:41:59    addgroup: docker,2000
2024-08-20 00:41:59 * Plugin user: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'user' (/mnt/sdm/usr/local/sdm/plugins/user) Phase 0 with arguments:
2024-08-20 00:41:59   'adduser=carl|uid=1000|password=letmein123|groupadd=docker'
2024-08-20 00:41:59 * Plugin user: Start Phase 0
2024-08-20 00:41:59 > Plugin user: Keys/values found:
2024-08-20 00:41:59    adduser: carl
2024-08-20 00:41:59    uid: 1000
2024-08-20 00:41:59    password: letmein123
2024-08-20 00:41:59    groupadd: docker
2024-08-20 00:41:59 > Plugin user: Create user 'carl' home directory '/home/carl' so available for other plugins
2024-08-20 00:41:59 * Plugin user: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'apt-file' (/mnt/sdm/usr/local/sdm/plugins/apt-file) Phase 0 with no arguments
2024-08-20 00:41:59 * Plugin apt-file: Start Phase 0
2024-08-20 00:41:59 * Plugin apt-file: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'chrony' (/mnt/sdm/usr/local/sdm/plugins/chrony) Phase 0 with no arguments
2024-08-20 00:41:59 * Plugin chrony: Start Phase 0
2024-08-20 00:41:59 * Plugin chrony: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'apps' (/mnt/sdm/usr/local/sdm/plugins/apps) Phase 0 with arguments:
2024-08-20 00:41:59   'name=removal1|remove=fake-hwclock'
2024-08-20 00:41:59 * Plugin apps: Start Phase 0
2024-08-20 00:41:59 > Plugin apps: Keys/values found:
2024-08-20 00:41:59    name: removal1
2024-08-20 00:41:59    remove: fake-hwclock
2024-08-20 00:41:59 > Plugin apps [removal1]: Saved 'remove' list: fake-hwclock
2024-08-20 00:41:59 * Plugin apps: Complete Phase 0
2024-08-20 00:41:59 > Run Plugin 'apps' (/mnt/sdm/usr/local/sdm/plugins/apps) Phase 0 with arguments:
2024-08-20 00:41:59   'name=baseapps|apps=git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-
2024-08-20 00:41:59   static,rsync,systemd-container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget
2024-08-20 00:41:59   ,xz-utils,file,zram-tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables
2024-08-20 00:41:59   ,firewalld,fail2ban,btrfs-progs,python3-icmplib,sg3-utils,lsscsi'
2024-08-20 00:41:59 * Plugin apps: Start Phase 0
2024-08-20 00:41:59 > Plugin apps: Keys/values found:
2024-08-20 00:41:59    name: baseapps
2024-08-20 00:41:59    apps:
2024-08-20 00:41:59   git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-static,rsync,systemd
2024-08-20 00:41:59   -container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget,xz-utils,file,zram-
2024-08-20 00:41:59   tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables,firewalld,fail2ban,
2024-08-20 00:41:59   btrfs-progs,python3-icmplib,sg3-utils,lsscsi
2024-08-20 00:42:00 > Plugin apps [baseapps]: Saved apps list: git command-not-found dnsutils kpartx binfmt-support
2024-08-20 00:42:00   gdisk parted qemu-user-static rsync systemd-container uuid jq usbutils dnsutils
2024-08-20 00:42:00   networkd-dispatcher nmap tmux curl wget xz-utils file zram-tools i2c-tools qemu-utils parted
2024-08-20 00:42:00   nfs-kernel-server python3-systemd iptables firewalld fail2ban btrfs-progs python3-icmplib
2024-08-20 00:42:00   sg3-utils lsscsi
2024-08-20 00:42:00 * Plugin apps: Complete Phase 0
2024-08-20 00:42:00 > Run Plugin 'disables' (/mnt/sdm/usr/local/sdm/plugins/disables) Phase 0 with arguments:
2024-08-20 00:42:00   'piwiz|triggerhappy'
2024-08-20 00:42:00 * Plugin disables: Start Phase 0
2024-08-20 00:42:00 > Plugin disables: Keys/values found:
2024-08-20 00:42:00    piwiz:
2024-08-20 00:42:00    triggerhappy:
2024-08-20 00:42:00 * Plugin disables: Complete Phase 0
2024-08-20 00:42:00 > Run Plugin 'system' (/mnt/sdm/usr/local/sdm/plugins/system) Phase 0 with arguments:
2024-08-20 00:42:00   'name=1stcall|service-disable=apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd|eeprom=b
2024-08-20 00:42:00   eta'
2024-08-20 00:42:00 * Plugin system: Start Phase 0
2024-08-20 00:42:00 > Plugin system: Keys/values found:
2024-08-20 00:42:00    name: 1stcall
2024-08-20 00:42:00    service-disable: apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd
2024-08-20 00:42:00    eeprom: beta
2024-08-20 00:42:00 > Plugin system: Create directory /mnt/sdm/etc/sdm/assets/system-1stcall
2024-08-20 00:42:00 * Plugin system: Complete Phase 0
2024-08-20 00:42:00 > Run Plugin 'quietness' (/mnt/sdm/usr/local/sdm/plugins/quietness) Phase 0 with arguments:
2024-08-20 00:42:00   'consoleblank|noquiet=keep|nosplash=keep|noplymouth'
2024-08-20 00:42:00 * Plugin quietness: Start Phase 0
2024-08-20 00:42:00 > Plugin quietness: Keys/values found:
2024-08-20 00:42:00    consoleblank:
2024-08-20 00:42:00    noquiet: keep
2024-08-20 00:42:00    nosplash: keep
2024-08-20 00:42:00    noplymouth:
2024-08-20 00:42:00 D!Plugin quietness: This is how to do a Plugin Debug printout
2024-08-20 00:42:00 * Plugin quietness: Complete Phase 0
2024-08-20 00:42:00 > Run Plugin 'copyfile' (/mnt/sdm/usr/local/sdm/plugins/copyfile) Phase 0 with arguments:
2024-08-20 00:42:00   'from=/home/carl/dev/mysdm/override.conf|to=/lib/systemd/system/nfs-blkmap.service.d/|mkdirif'
2024-08-20 00:42:00 * Plugin copyfile: Start Phase 0
2024-08-20 00:42:00 > Plugin copyfile: Keys/values found:
2024-08-20 00:42:00    from: /home/carl/dev/mysdm/override.conf
2024-08-20 00:42:00    to: /lib/systemd/system/nfs-blkmap.service.d/
2024-08-20 00:42:00    mkdirif:
2024-08-20 00:42:00 > Plugin copyfile: Add '/home/carl/dev/mysdm/override.conf' to files to copy
2024-08-20 00:42:00 > Plugin copyfile: Copy '/home/carl/dev/mysdm/override.conf' to
2024-08-20 00:42:00   '/mnt/sdm/etc/sdm/assets/copyfile/homecarldevmysdm'
2024-08-20 00:42:00 * Plugin copyfile: Complete Phase 0
2024-08-20 00:42:00 * Phase 0 Completed
2024-08-20 00:42:01 * Start Phase 1 image customization
2024-08-20 00:42:01 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1338064 1K-blocks (1.4GB, 1.3GiB) free at start of Phase 1 image customization
2024-08-20 00:42:01 > Configure and enable sdm FirstBoot service (sdm-firstboot)
2024-08-20 00:42:02 > Start 'apt update'
2024-08-20 00:42:02 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1338060 1K-blocks (1.4GB, 1.3GiB) free at start of 'apt update'
2024-08-20 00:42:10 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1222752 1K-blocks (1.3GB, 1.2GiB) free at end of 'apt update'
2024-08-20 00:42:10 > Run Plugins Phase '1'
2024-08-20 00:42:10 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase 1 with arguments: 'deluser=pi'
2024-08-20 00:42:10 * Plugin user: Start Phase 1
2024-08-20 00:42:10 > Plugin user: Delete user 'pi'
2024-08-20 00:42:11 * Plugin user: Complete Phase 1
2024-08-20 00:42:11 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase 1 with arguments: 'addgroup=docker,2000'
2024-08-20 00:42:11 * Plugin user: Start Phase 1
2024-08-20 00:42:11 * Plugin user: Complete Phase 1
2024-08-20 00:42:11 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase 1 with arguments:
2024-08-20 00:42:11   'adduser=carl|uid=1000|password=letmein123|groupadd=docker'
2024-08-20 00:42:11 * Plugin user: Start Phase 1
2024-08-20 00:42:11 > Plugin user: Add user 'carl'
2024-08-20 00:42:11 > Plugin user: Add groups to user 'carl':
2024-08-20 00:42:11   dialout,cdrom,floppy,audio,video,plugdev,users,adm,sudo,users,input,netdev,spi,i2c,gpio,docker
2024-08-20 00:42:11 > Plugin user: Enable sudo for user 'carl'
2024-08-20 00:42:11 > Plugin user: Copy skel files for user 'carl'
2024-08-20 00:42:11 > Plugin user: Set user 'carl' home directory '/home/carl' owner to 'carl:carl'
2024-08-20 00:42:11 > Plugin user: Set password for user 'carl'
2024-08-20 00:42:12 * Plugin user: Complete Phase 1
2024-08-20 00:42:12 > Run Plugin 'apt-file' (/usr/local/sdm/plugins/apt-file) Phase 1 with no arguments
2024-08-20 00:42:12 * Plugin apt-file: Start Phase 1
2024-08-20 00:42:12 > Plugin apt-file: Install apt-file
2024-08-20 00:42:28 * Plugin apt-file: Complete Phase 1
2024-08-20 00:42:28 > Run Plugin 'chrony' (/usr/local/sdm/plugins/chrony) Phase 1 with no arguments
2024-08-20 00:42:28 * Plugin chrony: Start Phase 1
2024-08-20 00:42:28 > Plugin chrony: Install chrony
2024-08-20 00:42:38 * Plugin chrony: Complete Phase 1
2024-08-20 00:42:38 > Run Plugin 'apps' (/usr/local/sdm/plugins/apps) Phase 1 with arguments:
2024-08-20 00:42:38   'name=removal1|remove=fake-hwclock'
2024-08-20 00:42:38 * Plugin apps: Start Phase 1
2024-08-20 00:42:38 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1218328 1K-blocks (1.2GB, 1.2GiB) free at start of [removal1] Application Removes
2024-08-20 00:42:38 > Plugin apps: Remove application(s)
2024-08-20 00:42:38   -- fake-hwclock
2024-08-20 00:42:43 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1218368 1K-blocks (1.2GB, 1.2GiB) free at start of [removal1] Application Installs
2024-08-20 00:42:43 > Skip [removal1] Application Installs per empty package list
2024-08-20 00:42:43 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1218364 1K-blocks (1.2GB, 1.2GiB) free at end of apps [removal1] Phase 1
2024-08-20 00:42:43 * Plugin apps: Complete Phase 1
2024-08-20 00:42:43 > Run Plugin 'apps' (/usr/local/sdm/plugins/apps) Phase 1 with arguments:
2024-08-20 00:42:43   'name=baseapps|apps=git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-
2024-08-20 00:42:43   static,rsync,systemd-container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget
2024-08-20 00:42:43   ,xz-utils,file,zram-tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables
2024-08-20 00:42:43   ,firewalld,fail2ban,btrfs-progs,python3-icmplib,sg3-utils,lsscsi'
2024-08-20 00:42:44 * Plugin apps: Start Phase 1
2024-08-20 00:42:44 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 1218364 1K-blocks (1.2GB, 1.2GiB) free at start of [baseapps] Application Installs
2024-08-20 00:42:44 * Start [baseapps] Application Installs
2024-08-20 00:42:44 > [baseapps] Application Installs: git command-not-found dnsutils kpartx binfmt-support gdisk
2024-08-20 00:42:44   parted qemu-user-static rsync systemd-container uuid jq usbutils dnsutils networkd-dispatcher
2024-08-20 00:42:44   nmap tmux curl wget xz-utils file zram-tools i2c-tools qemu-utils parted nfs-kernel-server
2024-08-20 00:42:44   python3-systemd iptables firewalld fail2ban btrfs-progs python3-icmplib sg3-utils lsscsi
2024-08-20 00:44:41 * [baseapps] Application Installs Completed
2024-08-20 00:44:41 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 719424 1K-blocks (0.7GB, 0.7GiB) free at end of apps [baseapps] Phase 1
2024-08-20 00:44:41 * Plugin apps: Complete Phase 1
2024-08-20 00:44:41 > Run Plugin 'disables' (/usr/local/sdm/plugins/disables) Phase 1 with arguments:
2024-08-20 00:44:41   'piwiz|triggerhappy'
2024-08-20 00:44:41 * Plugin disables: Start Phase 1
2024-08-20 00:44:41 * Plugin disables: Complete Phase 1
2024-08-20 00:44:41 > Run Plugin 'system' (/usr/local/sdm/plugins/system) Phase 1 with arguments:
2024-08-20 00:44:41   'name=1stcall|service-disable=apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd|eeprom=b
2024-08-20 00:44:41   eta'
2024-08-20 00:44:41 * Plugin system: Start Phase 1
2024-08-20 00:44:41 * Plugin system: Complete Phase 1
2024-08-20 00:44:41 > Run Plugin 'quietness' (/usr/local/sdm/plugins/quietness) Phase 1 with arguments:
2024-08-20 00:44:41   'consoleblank|noquiet=keep|nosplash=keep|noplymouth'
2024-08-20 00:44:41 * Plugin quietness: Start Phase 1
2024-08-20 00:44:41 > Plugin quietness: Set console blank timeout to 300 seconds
2024-08-20 00:44:41 > Plugin quietness: Disable quiet in /boot/firmware/cmdline.txt
2024-08-20 00:44:41 > Plugin quietness: Final cmdline.txt: console=serial0,115200 console=tty1 consoleblank=300
2024-08-20 00:44:41   root=PARTUUID=a3f161f3-02 rootfstype=ext4 fsck.repair=yes rootwait
2024-08-20 00:44:41   init=/usr/lib/raspberrypi-sys-mods/firstboot
2024-08-20 00:44:41 * Plugin quietness: Complete Phase 1
2024-08-20 00:44:41 > Run Plugin 'copyfile' (/usr/local/sdm/plugins/copyfile) Phase 1 with arguments:
2024-08-20 00:44:41   'from=/home/carl/dev/mysdm/override.conf|to=/lib/systemd/system/nfs-blkmap.service.d/|mkdirif'
2024-08-20 00:44:41 * Plugin copyfile: Start Phase 1
2024-08-20 00:44:41 > Plugin copyfile: Run
2024-08-20 00:44:41   /etc/sdm/assets/copyfile/run-phase1-homecarldevmysdmoverride.conf-libsystemdsystemnfs-blkmap.ser
2024-08-20 00:44:41   vice.d
2024-08-20 00:44:41 > Plugin copyfile: Process file '/home/carl/dev/mysdm/override.conf'
2024-08-20 00:44:42 > Plugin copyfile: Create destination directory '/lib/systemd/system/nfs-blkmap.service.d/'
2024-08-20 00:44:42 > Plugin copyfile: Copy 'override.conf' from /etc/sdm/assets/copyfile/homecarldevmysdm to
2024-08-20 00:44:42   '/lib/systemd/system/nfs-blkmap.service.d/'
2024-08-20 00:44:42 * Plugin copyfile: Complete Phase 1
2024-08-20 00:44:42 * Phase 1 post-app installation/configuration
2024-08-20 00:44:42 > Start 'apt dist-upgrade'
2024-08-20 00:44:42 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 719408 1K-blocks (0.7GB, 0.7GiB) free at start of 'apt dist-upgrade'
2024-08-20 00:46:05 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 569836 1K-blocks (0.6GB, 0.5GiB) free at end of 'apt dist-upgrade'
2024-08-20 00:46:05 > Start 'apt autoremove'
2024-08-20 00:46:05 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 569836 1K-blocks (0.6GB, 0.5GiB) free at start of 'apt autoremove'
2024-08-20 00:46:07 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 569836 1K-blocks (0.6GB, 0.5GiB) free at end of 'apt autoremove'
2024-08-20 00:46:08 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 569836 1K-blocks (0.6GB, 0.5GiB) free at end of Phase 1 image customization
2024-08-20 00:46:08 * Phase 1 Completed
2024-08-20 00:46:08 > Run Plugins Phase 'post-install'
2024-08-20 00:46:08 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase post-install with arguments:
2024-08-20 00:46:08   'deluser=pi'
2024-08-20 00:46:08 * Plugin user: Start Phase post-install
2024-08-20 00:46:08 * Plugin user: Complete Phase post-install
2024-08-20 00:46:08 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase post-install with arguments:
2024-08-20 00:46:08   'addgroup=docker,2000'
2024-08-20 00:46:08 * Plugin user: Start Phase post-install
2024-08-20 00:46:08 * Plugin user: Complete Phase post-install
2024-08-20 00:46:08 > Run Plugin 'user' (/usr/local/sdm/plugins/user) Phase post-install with arguments:
2024-08-20 00:46:08   'adduser=carl|uid=1000|password=letmein123|groupadd=docker'
2024-08-20 00:46:08 * Plugin user: Start Phase post-install
2024-08-20 00:46:08 * Plugin user: Complete Phase post-install
2024-08-20 00:46:08 > Run Plugin 'apt-file' (/usr/local/sdm/plugins/apt-file) Phase post-install with no arguments
2024-08-20 00:46:08 * Plugin apt-file: Start Phase post-install
2024-08-20 00:46:08 > Plugin apt-file: Generate apt-file database
2024-08-20 00:46:54 * Plugin apt-file: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'chrony' (/usr/local/sdm/plugins/chrony) Phase post-install with no arguments
2024-08-20 00:46:54 * Plugin chrony: Start Phase post-install
2024-08-20 00:46:54 * Plugin chrony: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'apps' (/usr/local/sdm/plugins/apps) Phase post-install with arguments:
2024-08-20 00:46:54   'name=removal1|remove=fake-hwclock'
2024-08-20 00:46:54 * Plugin apps: Start Phase post-install
2024-08-20 00:46:54 * Plugin apps: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'apps' (/usr/local/sdm/plugins/apps) Phase post-install with arguments:
2024-08-20 00:46:54   'name=baseapps|apps=git,command-not-found,dnsutils,kpartx,binfmt-support,gdisk,parted,qemu-user-
2024-08-20 00:46:54   static,rsync,systemd-container,uuid,jq,usbutils,dnsutils,networkd-dispatcher,nmap,tmux,curl,wget
2024-08-20 00:46:54   ,xz-utils,file,zram-tools,i2c-tools,qemu-utils,parted,nfs-kernel-server,python3-systemd,iptables
2024-08-20 00:46:54   ,firewalld,fail2ban,btrfs-progs,python3-icmplib,sg3-utils,lsscsi'
2024-08-20 00:46:54 * Plugin apps: Start Phase post-install
2024-08-20 00:46:54 * Plugin apps: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'disables' (/usr/local/sdm/plugins/disables) Phase post-install with arguments:
2024-08-20 00:46:54   'piwiz|triggerhappy'
2024-08-20 00:46:54 * Plugin disables: Start Phase post-install
2024-08-20 00:46:54 > Plugin disables: Disable running piwiz and userconfig on first system boot
2024-08-20 00:46:54 > Plugin disables: Disable triggerhappy service
2024-08-20 00:46:54 * Plugin disables: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'system' (/usr/local/sdm/plugins/system) Phase post-install with arguments:
2024-08-20 00:46:54   'name=1stcall|service-disable=apt-daily.timer,apt-daily-upgrade.timer,systemd-timesyncd|eeprom=b
2024-08-20 00:46:54   eta'
2024-08-20 00:46:54 * Plugin system: Start Phase post-install
2024-08-20 00:46:54 > Plugin system: Disable service 'apt-daily.timer'
2024-08-20 00:46:54 > Plugin system: Disable service 'apt-daily-upgrade.timer'
2024-08-20 00:46:54 > Plugin system: Disable service 'systemd-timesyncd'
2024-08-20 00:46:54 % Plugin system: Error disabling service 'systemd-timesyncd' (1)
2024-08-20 00:46:54 > Plugin system: Set rpi-eeprom to 'beta' during sdm FirstBoot
2024-08-20 00:46:54 * Plugin system: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'quietness' (/usr/local/sdm/plugins/quietness) Phase post-install with arguments:
2024-08-20 00:46:54   'consoleblank|noquiet=keep|nosplash=keep|noplymouth'
2024-08-20 00:46:54 * Plugin quietness: Start Phase post-install
2024-08-20 00:46:54 * Plugin quietness: Complete Phase post-install
2024-08-20 00:46:54 > Run Plugin 'copyfile' (/usr/local/sdm/plugins/copyfile) Phase post-install with arguments:
2024-08-20 00:46:54   'from=/home/carl/dev/mysdm/override.conf|to=/lib/systemd/system/nfs-blkmap.service.d/|mkdirif'
2024-08-20 00:46:54 * Plugin copyfile: Start Phase post-install
2024-08-20 00:46:54 * Plugin copyfile: Complete Phase post-install
2024-08-20 00:46:54 > Run graphics post-install configuration
2024-08-20 00:46:55 > Plugin sdm-phase1: No sdm-configurable Display Manager found
2024-08-20 00:46:55 > Plugin sdm-phase1: Set RasPiOS to B1:'console no login' for sdm FirstBoot
2024-08-20 00:46:55 > Enable SSH
2024-08-20 00:46:55 > Plugin phase1: Enable SSH service
2024-08-20 00:46:55 > IMG '2024-07-04-raspios-bookworm-arm64-lite.img' has 464244 1K-blocks (0.5GB, 0.4GiB) free at end of image customization
2024-08-20 00:46:55 > Customize elapsed time: 00:05:08
2024-08-20 00:46:55 * Customization complete
2024-08-20 00:46:55 * Batch Mode exit
2024-08-20 00:49:38 > Flush accumulated burn log messages
2024-08-20 00:47:20 * Start Burn
2024-08-20 00:47:21 > Burn '2024-07-04-raspios-bookworm-arm64-lite.img' (3.9GB, 3.6GiB) to '/dev/mmcblk0'...
2024-08-20 00:47:23 * Remove partitions on /dev/mmcblk0
2024-08-20 00:47:34 > Create GPT partitions on /dev/mmcblk0
2024-08-20 00:48:11 > Create bootfs file system on /dev/mmcblk0
2024-08-20 00:48:11 > Create 'btrfs' rootfs file system on /dev/mmcblk0p2
2024-08-20 00:48:12 > Copy bootfs to /dev/mmcblk0
2024-08-20 00:48:13 > Copy rootfs to /dev/mmcblk0
2024-08-20 00:49:15 > rootfs copy complete
2024-08-20 00:49:48 * Resize the btrfs root file system
2024-08-20 00:49:48 % (Ignore 'on-line resizing required' message)
2024-08-20 00:49:48 > Set GPT rootfs partition GUID 'b3541d38-07cd-41d0-97b6-a40910971cd5' in cmdline.txt
2024-08-20 00:49:48 > Set GPT partition GUIDs in fstab
2024-08-20 00:49:48 > Disable unneeded RasPiOS firstboot service and /etc/init.d/resize2fs_once
2024-08-20 00:49:48 > Set file system type 'btrfs' in cmdline.txt and /etc/fstab
2024-08-20 00:49:48 > Disable regenerate_ssh_host_keys service; sdm FirstBoot will run it instead
2024-08-20 00:49:49 > Set hostname 'rpicm4-1.1stcall.uk'
2024-08-20 00:49:49 > First System Boot Custom Boot Scripts disabled
2024-08-20 00:49:49 > First System Boot automatic restart enabled
2024-08-20 00:49:49 * Plugins selected:
2024-08-20 00:49:49    * apt-addrepo
2024-08-20 00:49:49        Args: repo=deb https://download.docker.com/linux/debian bookworm stable|gpgkey=/home/carl/dev/mysdm/docker.asc
2024-08-20 00:49:49    * apps
2024-08-20 00:49:49        Args: name=docker|apps=docker-ce,docker-ce-cli,containerd.io,docker-buildx-plugin,docker-compose-plugin
2024-08-20 00:49:49    * bootconfig
2024-08-20 00:49:49        Args: section=[cm4]|dtparam=i2c_vc=on|dtoverlay=i2c-rtc,pcf85063a,i2c_csi_dsi
2024-08-20 00:49:49    * L10n
2024-08-20 00:49:49        Args: host
2024-08-20 00:49:49    * system
2024-08-20 00:49:49        Args: name=myfstab|fstab=/home/carl/dev/mysdm/myfstab
2024-08-20 00:49:49    * trim-enable
2024-08-20 00:49:49        Args: disks=all
2024-08-20 00:49:49    * imon
2024-08-20 00:49:49 > Run Plugins Phase '0'
2024-08-20 00:49:49 > Run Plugin 'apt-addrepo' (/mnt/sdm/usr/local/sdm/plugins/apt-addrepo) Phase 0 with arguments:
2024-08-20 00:49:49   'repo=deb https://download.docker.com/linux/debian bookworm
2024-08-20 00:49:49   stable|gpgkey=/home/carl/dev/mysdm/docker.asc'
2024-08-20 00:49:49 * Plugin apt-addrepo: Start Phase 0
2024-08-20 00:49:49 > Plugin apt-addrepo: Keys/values found:
2024-08-20 00:49:49    repo: deb https://download.docker.com/linux/debian bookworm stable
2024-08-20 00:49:49    gpgkey: /home/carl/dev/mysdm/docker.asc
2024-08-20 00:49:49 > Plugin apt-addrepo: Add repo 'deb https://download.docker.com/linux/debian bookworm stable'
2024-08-20 00:49:49   to apt sources
2024-08-20 00:49:49 > Plugin apt-addrepo: Copy gpg key '/home/carl/dev/mysdm/docker.asc' to
2024-08-20 00:49:49   /mnt/sdm/etc/apt/trusted.gpg.d/docker.gpg
2024-08-20 00:49:49 * Plugin apt-addrepo: Complete Phase 0
2024-08-20 00:49:49 > Run Plugin 'apps' (/mnt/sdm/usr/local/sdm/plugins/apps) Phase 0 with arguments:
2024-08-20 00:49:49   'name=docker|apps=docker-ce,docker-ce-cli,containerd.io,docker-buildx-plugin,docker-compose-plug
2024-08-20 00:49:49   in'
2024-08-20 00:49:49 * Plugin apps: Start Phase 0
2024-08-20 00:49:49 > Plugin apps: Keys/values found:
2024-08-20 00:49:49    name: docker
2024-08-20 00:49:49    apps: docker-ce,docker-ce-cli,containerd.io,docker-buildx-plugin,docker-compose-plugin
2024-08-20 00:49:49 > Plugin apps [docker]: Saved apps list: docker-ce docker-ce-cli containerd.io
2024-08-20 00:49:49   docker-buildx-plugin docker-compose-plugin
2024-08-20 00:49:49 * Plugin apps: Complete Phase 0
2024-08-20 00:49:49 > Run Plugin 'bootconfig' (/mnt/sdm/usr/local/sdm/plugins/bootconfig) Phase 0 with arguments:
2024-08-20 00:49:49   'section=[cm4]|dtparam=i2c_vc=on|dtoverlay=i2c-rtc,pcf85063a,i2c_csi_dsi'
2024-08-20 00:49:49 * Plugin bootconfig: Start Phase 0
2024-08-20 00:49:49 > Plugin bootconfig: Keys/values found:
2024-08-20 00:49:49    section: [cm4]
2024-08-20 00:49:49    dtparam: i2c_vc=on
2024-08-20 00:49:49    dtoverlay: i2c-rtc,pcf85063a,i2c_csi_dsi
2024-08-20 00:49:49 > Plugin bootconfig: Processing keys...
2024-08-20 00:49:49 > Plugin bootconfig: Append section '[cm4]' to /mnt/sdm/boot/firmware/config.txt
2024-08-20 00:49:49 > Plugin bootconfig: Append 'dtparam=i2c_vc=on' to /mnt/sdm/boot/firmware/config.txt
2024-08-20 00:49:49 > Plugin bootconfig: Append 'dtoverlay=i2c-rtc,pcf85063a,i2c_csi_dsi' to
2024-08-20 00:49:49   /mnt/sdm/boot/firmware/config.txt
2024-08-20 00:49:49 * Plugin bootconfig: Complete Phase 0
2024-08-20 00:49:49 > Run Plugin 'L10n' (/mnt/sdm/usr/local/sdm/plugins/L10n) Phase 0 with arguments: 'host'
2024-08-20 00:49:49 * Plugin L10n: Start Phase 0
2024-08-20 00:49:49 > Plugin L10n: Keys/values found:
2024-08-20 00:49:49    host:
2024-08-20 00:49:49 > Plugin L10n: Read L10n configuration from host system
2024-08-20 00:49:49 > Plugin L10n: Load Localization (L10N) settings from running system
2024-08-20 00:49:49 > Plugin L10n:   Keymap:       gb
2024-08-20 00:49:49 > Plugin L10n:   Locale:       en_GB.UTF-8
2024-08-20 00:49:49 > Plugin L10n:   Timezone:     Europe/London
2024-08-20 00:49:49 > Plugin L10n:   WiFi Country:
2024-08-20 00:49:50 > Plugin L10n: Save L10n configuration
2024-08-20 00:49:50 * Plugin L10n: Complete Phase 0
2024-08-20 00:49:50 > Run Plugin 'system' (/mnt/sdm/usr/local/sdm/plugins/system) Phase 0 with arguments:
2024-08-20 00:49:50   'name=myfstab|fstab=/home/carl/dev/mysdm/myfstab'
2024-08-20 00:49:50 * Plugin system: Start Phase 0
2024-08-20 00:49:50 > Plugin system: Keys/values found:
2024-08-20 00:49:50    name: myfstab
2024-08-20 00:49:50    fstab: /home/carl/dev/mysdm/myfstab
2024-08-20 00:49:50 > Plugin system: Create directory /mnt/sdm/etc/sdm/assets/system-myfstab
2024-08-20 00:49:50 > Plugin system: Create directory /mnt/sdm/etc/sdm/assets/system-myfstab/fstab
2024-08-20 00:49:50 > Plugin system: Copy '/home/carl/dev/mysdm/myfstab' to
2024-08-20 00:49:50   /mnt/sdm/etc/sdm/assets/system-myfstab/fstab
2024-08-20 00:49:50 * Plugin system: Complete Phase 0
2024-08-20 00:49:50 > Run Plugin 'trim-enable' (/mnt/sdm/usr/local/sdm/plugins/trim-enable) Phase 0 with arguments:
2024-08-20 00:49:50   'disks=all'
2024-08-20 00:49:50 * Plugin trim-enable: Start Phase 0
2024-08-20 00:49:50 > Plugin trim-enable: Keys/values found:
2024-08-20 00:49:50    disks: all
2024-08-20 00:49:50 * Plugin trim-enable: Complete Phase 0
2024-08-20 00:49:50 > Run Plugin 'imon' (/mnt/sdm/usr/local/sdm/plugins/imon) Phase 0 with no arguments
2024-08-20 00:49:50 * Plugin imon: Start Phase 0
2024-08-20 00:49:50 > Plugin imon: download imon from GitHub to /usr/local/bin/imon and set protection
2024-08-20 00:49:51 * Plugin imon: Complete Phase 0
2024-08-20 00:49:51 > Run Plugins Phase '1'
2024-08-20 00:49:51 > Run Plugin 'apt-addrepo' (/usr/local/sdm/plugins/apt-addrepo) Phase 1 with arguments:
2024-08-20 00:49:51   'repo=deb'
2024-08-20 00:49:52 * Plugin apt-addrepo: Start Phase 1
2024-08-20 00:49:52 * Plugin apt-addrepo: Complete Phase 1
2024-08-20 00:49:52 > Run Plugins Phase 'post-install'
2024-08-20 00:49:52 > Run Plugin 'apt-addrepo' (/usr/local/sdm/plugins/apt-addrepo) Phase post-install with
2024-08-20 00:49:52   arguments: 'repo=deb'
2024-08-20 00:49:52 * Plugin apt-addrepo: Start Phase post-install
2024-08-20 00:49:52 * Plugin apt-addrepo: Complete Phase post-install
2024-08-20 00:49:52 > Enable btrfs in initramfs
2024-08-20 00:50:22 * Burn Completed
2024-08-20 00:50:22 > Burn elapsed time: 00:03:02
2024-08-20 00:54:44 > sdm FirstBoot: Start sdm FirstBoot Service
2024-08-20 00:54:44 > sdm FirstBoot: Start Configuration with configuration file '/etc/sdm/auto-1piboot.conf'
2024-08-20 00:54:44 > sdm FirstBoot: Configuration with configuration file '/etc/sdm/auto-1piboot.conf' Completed
2024-08-20 00:54:44 > sdm FirstBoot: Set WiFi Country to 'US'
2024-08-20 00:54:53 > sdm FirstBoot: System time synchronization achieved
2024-08-20 00:54:53 > sdm FirstBoot: Run Generated sdm FirstBoot Script '/etc/sdm/0piboot/030-rpi-eeprom.sh'
2024-08-20 00:54:53 > sdm FirstBoot: Run Generated sdm FirstBoot Script '/etc/sdm/0piboot/090-reset-quietness.sh'
2024-08-20 00:54:53 > sdm FirstBoot: Skip Custom sdm FirstBoot Scripts
2024-08-20 00:54:53 > sdm FirstBoot: Disable sdm-firstboot service
2024-08-20 00:54:54 > sdm FirstBoot: Regenerate SSH Host Keys
2024-08-20 00:55:00 > sdm FirstBoot: set boot behaviour to B1
2024-08-20 00:55:03 > sdm FirstBoot: Re-enable getty@tty1
2024-08-20 00:55:05 > sdm FirstBoot: System will restart in 20 seconds
2024-08-20 00:55:27 > sdm FirstBoot: System restarting now

My customise command line is :- sudo sdm --customize 2024-07-04-raspios-bookworm-arm64-lite.img --extend --xmb 1024 --showapt --apt-dist-upgrade --plugin-debug --plugin @./customize.plugin --restart --batch

Thx for all that. Could you also do the following:

On the burned output disk, what is the contents of /etc/sdm/auto-1piboot.conf?
After booting the disk:

Identify the first boot (where sdm-firstboot service runs) and do journalctl -b -N | grep fstab Replace -N with the number to get the journal for that boot. On a freshly booted system this will be -1

With what you've provided (which all looks fine) plus the above, I'll have sufficient info to sort out what's happening. Thx

/etc/sdm/auto-1piboot.conf contains
sdm added these settings from the command line (see /etc/sdm/history)
journalctl -b -1 | grep fstab yeilds no results.
journalctl -b -1 --unit sdm-firstboot.service :-
Aug 20 00:54:44 rpicm4-1.1stcall.uk systemd[1]: Starting sdm-firstboot.service - sdm FirstBoot System Configuration...
Aug 20 00:54:44 rpicm4-1.1stcall.uk systemd[1]: Started sdm-firstboot.service - sdm FirstBoot System Configuration.

Aug 20 00:55:27 rpicm4-1.1stcall.uk root[1375]: sdm FirstBoot: System restarting now
Aug 20 00:55:27 rpicm4-1.1stcall.uk systemd[1]: sdm-firstboot.service: Deactivated successfully.
Aug 20 00:55:27 rpicm4-1.1stcall.uk systemd[1]: Stopped sdm-firstboot.service - sdm FirstBoot System Configuration.
Aug 20 00:55:27 rpicm4-1.1stcall.uk systemd[1]: sdm-firstboot.service: Consumed 1.402s CPU time.

 Could you also do the following:

On the burned output disk, what is the contents of /etc/sdm/auto-1piboot.conf?
After booting the disk:
*   Identify the first boot (where sdm-firstboot service runs) and do journalctl -b -N | grep fstab Replace -N with the number to get the journal for that boot. On a freshly booted system this will be -1

With what you've provided (which all looks fine) plus the above, I'll have sufficient info to sort out what's happening. Thx
—
Reply to this email directly, view it on GitHubhttps://github.com/gitbls/sdm/issues/104#issuecomment-2297740299, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCHHLIRO7AI3QB4OEJVJPDZSKEAJAVCNFSM6AAAAABMXLUXAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXG42DAMRZHE.
You are receiving this because you commented.Message ID: @.***>

Thx! Will read through this and see what's duffed up.

Well, very strange. After the burn is done, phase 0 for all the plugins specified on the burn command line are run. However, not all of them are run for phase 1 or the post-install phase. Something is borking the plugin list. Not nice! Will sort it tomorrow. Thx for reporting, this looks like a good one!

I have a very simple (remove double quotes from a  single line) fix, which should work in all cases.
I can't yet explain why the original code works correctly in Phase 0, but failed in Phase 1 and post-install phases, and I've been unable to simplify a repro case outside of sdm that fails in any scenario.
Will do some more testing here, then push the fix and update this issue so you can test it in your environment.

OK, I pushed an updated sdm-cparse for you to try.
In case you're interested, both of these commands are supposed to be equivalent:
	IFS="~" read -r -a plugs <<< "$theseplugs"  # what it used to be

and
	IFS="~" read -r -a plugs <<< $theseplugs   # what it is now

I learned here that as of bash 4.4 (a while ago, I presume) you no longer need to quote the string. Which I was doing, and it generally worked. Except for some reason it doesn't work when plugins run during phase 1 and post-install. In that scenario, it for some reason drops most of the plugins string, like it is having IFS confusion of some sort.
Removing the double quotes fixes it. Not what I would have expected.

BTW, when you're using pluglist files you don't need the quotes around a plugin argument list.
For example:
system:name=myfstab|fstab=/rpi/etc/fstab.lan

Much easier on the eyes IMHO

Damn. Ignore the above. Test set failure.
It's not working with the apt-addrepo plugin, because of the spaces. Still mystified.

Remove the apt-addrepo plugin and fstab should work fine.
I'm a bit mystified at the moment how that plugin ever worked, so after fixing the plugin parsing problem the plugin needs some work as well.

No probs.  I should be able to achieve the same result using the copyfile plugin.

From: Benn @.>
Sent: 21 August 2024 2:28 AM
To: gitbls/sdm @.>
Cc: Carl McAlwane @.>; Comment @.>
Subject: Re: [gitbls/sdm] --fstab not being run on burn (Issue #104)
Remove the apt-addrepo plugin and fstab should work fine.
I'm a bit mystified at the moment how that plugin ever worked, so after fixing the plugin parsing problem the plugin needs some work as well.
—
Reply to this email directly, view it on GitHubhttps://github.com/gitbls/sdm/issues/104#issuecomment-2300042166, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADCHHLLAY3CU47YZKXKPEGLZSPUM3AVCNFSM6AAAAABMXLUXAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBQGA2DEMJWGY.
You are receiving this because you commented.Message ID: @.***>

OK, fixed in V12.8. apt-addrepo plugin works better now, as well as any arg values with spaces in them. Thanks for pointing this out, it was a fairly fundamental bug.


Migrate hiring GDPR workflow

Currently hiring candidates have to sign GDPR conditions under https://www.netcentric.biz/legal/gdpr/confirmation.html which is still pointing to AEM and triggers a JIRA workflow when submitted. The exact workflow needs to be investigated and it should be moved to a different mechanism.

If the JIRA workflow is the desired way to keep it we can keep it. To answer how exactly we going to solve it we need to do some deep dive into the current workflow and come up with a new setup to trigger it.

Hi, I started by creating a wiki page where we can document how we do the migration: https://projects.netcentric.biz/wiki/display/NCWEB/Migration+-+NC+Recruiting+Web+GDPR

@pedrogbot https://projects.netcentric.biz/wiki/display/NCWEB/NC+API+GDPR


Add exactn cpp binding

Context:
Adding the backend Exact Tensor Network from lightning.tensor to the Python layer
Description of the Change:

Add pybind layer for the ExaTNCuda class
Update the python layer unit tests.
Python layer refactoring to allow runtime selection of MPS and ExaTN
Python layer unit tests update (gates, analytical measurement)

Benefits:

Refactor MPSTNCuda class to TNCuda class

Both MPS and Exact TensorNetwork backends will be handled by the TNCuda class
User can select either MPS or Exact TensorNetwork at runtime by passing str (mps or exatn) to the constructor of theTNCuda class.

Measurement class

expval() support can be get without changing current code base for the MPS backend.

Possible Drawbacks:

qml.StatePrep() won't be supported for 'exatn'

Related GitHub Issues:
[sc-77837][sc-77840]

Thanks @LuisAlfredoNu! I've added some comments/questions :)

I will update UI stuff later in a following PR defined in [sc-80075]. CC @maliasadi


AWS updates

Title: [Component/Feature] Short Description of the Change
Summary:
Add execute on delegate capability to the AWS connector
Details:
To be able to toggle on and off the ability to select a harness platform delegate

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck
gitleaks: trigger gitleaks

PR raised for Harness GO SDK to add required fields

https://github.com/harness/harness-go-sdk/pull/606

Hey @gregkroon,
Thanks for contributing to terraform-provider! Could you also add tests for the new field execute_on_delegate in both aws_test.go and aws_data_source_test.go?
Appreciate your efforts!


fixup readme wording, as there are 64bit binaries

Thanks thorduri!
I notice that part of that is out of date still (re unreleased, waiting for 3.3.0 which is long since released...) hm, I should probably take a look at that at some point...


Add "log" prefix to log backups in examples on Piecemeal Restore docs

To follow the backup naming convention used in the similar example page here: https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/example-online-restore-of-a-read-write-file-full-recovery-model?view=sql-server-2017
and to make it less confusing between the many different backup files/types being referenced in the examples.

@LowlyDBA : Thanks for your contribution! The author, @MikeRayMSFT, has been notified to review your proposed change.

@LowlyDBA - thank you for this submission!
#sign-off


refactor: remove dead code part 1 #FF

This PR resolves []
Description
remove dead code with the use of ts-prune
ts-prune --project tsconfig.json | grep -v '(used in module)'

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Very nice 👍 (heads over to force 👀 )


Wrong argument error stringp 45 whenever i open a cpp file

Sorry for the unwieldy backtrace below
Debugger entered--Lisp error: (wrong-type-argument stringp 45)
string-match("^-m32$" 45)
#257 "\300\301\302:\203!�@\262\303\304\305""?\211\262\203!�A\262\202�\211\205&�\302\207" [("-m32" "-Werror" "-c" "-fPIC" "-pipe" "-g" "-ggdb") nil t string-match format "^%s$"] 8 "\n\n(fn X)"
#257 "\300!\205�\211\207" [#[257 "\300\301\302:\203!�@\262\303\304\305""?\211\262\203!�A\262\202�\211\205&�\302\207" [("-m32" "-Werror" "-c" "-fPIC" "-pipe" "-g" "-ggdb") nil t string-match format "^%s$"] 8 "\n\n(fn X)"]] 3 "\n\n(fn X)"
mapcar(#[257 "\300!\205�\211\207" [#[257 "\300\301\302:\203!�@\262\303\304\305""?\211\262\203!�A\262\202�\211\205&�\302\207" [("-m32" "-Werror" "-c" "-fPIC" "-pipe" "-g" "-ggdb") nil t string-match format "^%s$"] 8 "\n\n(fn X)"]] 3 "\n\n(fn X)"] (45 73 47 117 115 114 47 105 110 99 108 117 100 101 47 99 43 43 47 118 49 47 55 46 49 46 49 47 "-O3" "-DNDEBUG" "-o" "CMakeFiles/Hello.dir/hello.cpp.o" "-c"))
cmake-ide--filter(#[257 "\300\301\302:\203!�@\262\303\304\305""?\211\262\203!�A\262\202�\211\205&�\302\207" [("-m32" "-Werror" "-c" "-fPIC" "-pipe" "-g" "-ggdb") nil t string-match format "^%s$"] 8 "\n\n(fn X)"] (45 73 47 117 115 114 47 105 110 99 108 117 100 101 47 99 43 43 47 118 49 47 55 46 49 46 49 47 "-O3" "-DNDEBUG" "-o" "CMakeFiles/Hello.dir/hello.cpp.o" "-c"))
cmake-ide--filter-ac-flags((45 73 47 117 115 114 47 105 110 99 108 117 100 101 47 99 43 43 47 118 49 47 55 46 49 46 49 47 "-O3" "-DNDEBUG" "-o" "CMakeFiles/Hello.dir/hello.cpp.o" "-c"))
cmake-ide-set-compiler-flags(# ("-O3" "-DNDEBUG" "-o" "CMakeFiles/Hello.dir/hello.cpp.o" "-c") nil nil)
cmake-ide--set-flags-for-src-file(((directory . "/home/nerq/Projects/Hello_World") (command . "/usr/bin/c++    -O3 -DNDEBUG   -o CMakeFiles/Hello.dir/hello.cpp.o -c /home/nerq/Projects/Hello_World/hello.cpp") (file . "/home/nerq/Projects/Hello_World/hello.cpp")) # nil)
cmake-ide--set-flags-for-file(#s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("/home/nerq/Projects/Hello_World/hello.cpp" (((directory . "/home/nerq/Projects/Hello_World") (command . "/usr/bin/c++    -O3 -DNDEBUG   -o CMakeFiles/Hello.dir/hello.cpp.o -c /home/nerq/Projects/Hello_World/hello.cpp") (file . "/home/nerq/Projects/Hello_World/hello.cpp"))) ...)) #)
#[257 "\301\300"\207" [#s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("/home/nerq/Projects/Hello_World/hello.cpp" (((directory . "/home/nerq/Projects/Hello_World") (command . "/usr/bin/c++    -O3 -DNDEBUG   -o CMakeFiles/Hello.dir/hello.cpp.o -c /home/nerq/Projects/Hello_World/hello.cpp") (file . "/home/nerq/Projects/Hello_World/hello.cpp"))) ...)) cmake-ide--set-flags-for-file] 4 "\n\n(fn X)"](#)
mapc(#[257 "\301\300"\207" [#s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("/home/nerq/Projects/Hello_World/hello.cpp" (((directory . "/home/nerq/Projects/Hello_World") (command . "/usr/bin/c++    -O3 -DNDEBUG   -o CMakeFiles/Hello.dir/hello.cpp.o -c /home/nerq/Projects/Hello_World/hello.cpp") (file . "/home/nerq/Projects/Hello_World/hello.cpp"))) ...)) cmake-ide--set-flags-for-file] 4 "\n\n(fn X)"] (#))
cmake-ide--on-cmake-finished()
cmake-ide-maybe-run-cmake()
run-hooks(find-file-hook)
after-find-file(nil t)
find-file-noselect-1(# "~/Projects/Hello_World/hello.cpp" nil nil "~/Projects/Hello_World/hello.cpp" (4983042 2057))
find-file-noselect("~/Projects/Hello_World/hello.cpp" nil nil t)
find-file("~/Projects/Hello_World/hello.cpp" t)
funcall-interactively(find-file "~/Projects/Hello_World/hello.cpp" t)
call-interactively(find-file nil nil)
command-execute(find-file)

Can you point me to a reduced project that reproduces this issue? Thanks.

I'm not getting you but if u mean a simple project... this is a hello world project with an in build

I can't reproduce this, I just opened a C++ file with the latest version of cmake-ide.

sorry... then it must be my bad configurations... i'll uninstall cmake-ide and the other tools and reconfigure to see if i'll get the same error

I have the same issue, I think it is caused by some layer conflict.
@Sean-Nerq, please reply if you find solution.

@gavrushkin If you can provide a test project that reproduces this I can look into it.

@atilaneves I can't do it, sorry. It is a closed-source project.

@gavrushkin I see. In that case there's not much I can do - you'd have to debug it yourself.

@atilaneves  I commented cmake--ide-filter function body and it works now. Sorry, I'm new to lisp/emacs so I don't get into it deep.

@atilaneves
I'm getting this as well.
rdm/rc compiled myself according to github
rtags 20180130.942 emacs package installed
cmake-ide 20180205.903 emacs package installed
Here are a snippet of Messages ( ~/.emacs loads everything )
cmake-ide [Sat Feb 10 16:36:08 2018]: Starting rdm server
cmake-ide [Sat Feb 10 16:36:09 2018]: Converting JSON CDB /blitzq-build-release/compile_commands.json to IDB
cmake-ide [Sat Feb 10 16:36:09 2018]: Setting flags for file /blitzq/callables/backtest_strategy.hpp
Working...
Finding buffer src1.cpp...
Finding ./src1.cpp...
./src1.cpp found
cmake-ide [Sat Feb 10 16:36:09 2018]: Found src file ...cpp for ....hpp, using its flags
Wrong type argument: stringp, 45
How do I turn on debug to get more Messages to see what's going?

@finjulhich Any chance I could get access to that compile_commands.json?

@finjulhich
This issue was fixed for me after I updated all emacs packages to the latest version. Later it appeared again in a quite random way.

I encountered this error just now with the most recent version, even with a "hello" project:
hello-cpp/CMakeLists.txt:
cmake_minimum_required(VERSION 3.10)
project(hello-cpp)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_FLAGS "-g")
add_executable(hello hello.cpp)

(find-file "hello.cpp") gives the same error as the previous commenters.
After a bit of debugging, it seems that the variable cmake-ide-flags-c++ is documented as a string (and I set it as such in my init file), but is treated by cide--get-compiler-flags as if it were a list of strings.  The latter function reads:
(defun cide--get-compiler-flags (flags)
  "Use FLAGS to return all compiler flags including existing ones."
  (append (cide--get-existing-compiler-flags) flags))

Modifying it as follows seems to fix the issue:
(defun cide--get-compiler-flags (flags)
  "Use FLAGS to return all compiler flags including existing ones."
  (append (split-string (cide--get-existing-compiler-flags)) flags))


Marketplace deployment using public IP has wrong NSGs

Version
1.0.35
Description
When deploying with the marketplace application using Public IP, the NSGs rule to allow SSH on the deployer VM is set to 22 while it should be on the port configured in the config file.

closed by https://github.com/Azure/az-hop/commit/334e179fc0ef756a14cbdc89045f7d1c1ca8f184


DCE and unused files/wordings

This pr needs a bit of special treatment when it comes to testing because I can have inadvertently deleted some components, some wording, or some icon that seems to not be used but in reality, it might be, due to some dynamic import/concat/whatever.
Apart from the cleanup it introduces some new config for webpack that will run when we launch the app and warn us of potentially unused code. If it's not really unused we can add an exception to the appropriate config file (renderer.webpack.config.js or main.webpack.config.js), it also adds a very hacky python script I wrote in 2018 that attempts to locate unused literals, it can be launched from the root of the project via py scripts/i18next-unused.py or python i18next-unused.py 1 if we only want the unused keys in the output.
Also note that it's not bulletproof due to time where we construct the key with an expression dynamically, so triple-check before you delete. Once again I might have deleted some that I shouldn't have so a thorough pass of the flows is needed.

This pr needs a bit of special treatment when it comes to testing because I can have inadvertently deleted some components, some wording, or some icon that seems to not be used but in reality, it might be, due to some dynamic import/concat/whatever.

I don't understand why. deleting a component would break webpack.
for wording i agree and that's why i tend to think we need to split the two concerns (removing the unused code VS removing the wording)

Can we close this? I dislike zombie prs 😖

Closed in favor of https://github.com/LedgerHQ/lld-v2/pull/233 and https://github.com/LedgerHQ/lld-v2/pull/234 where the commits are separated into components and wordings as per @gre request


missing dependency for example: descartes

it was easy to find and fix on my end, but you might want to add it to setup.py extra_require

Good idea, Thanks! Add this in https://github.com/holoviz/spatialpandas/pull/18

Thanks.  Closing


Nature's Aura trees fails to load since main DynTree update

Hey - I'm trying to use this since the Dynamic Trees Beta18 update and with versions 1.2.3 and 1.2.2 i get the attached load error.  LMK if you need more info.

Pasted Log

Fixed by 112e272c595d8df664e6b7499cb141b63c99c489. New release 1.2.4 uploading now.

thank you!


Similarity to Racker?

Per https://github.com/mitchellh/packer/pull/3860/files I'm wondering how different packer-config is to https://github.com/aspring/racker. Any thoughts?
Thanks,
Martin.

Similar but different. One big thing that stands out is I didn't write Racker. :)
packer-config has a standard Ruby object interface for working with Packer. It doesn't have a strongly-opinionated DSL. That seems to be the big difference. Otherwise they aim to solve the same problem: working with Packer configuration files on a large scale can be unwieldy because it's not a fully-formed programming language.

Doesn't Packer use Go? While the {{ syntax makes my eyes hurt (and Packer seems to have no means to DRY our repeated constant definitions), it is fair to call it (Go) not a fully-formed language?

While Packer the program is written in Go, it's template file format is its own DSL which is a custom extension of the JSON format.
See: https://github.com/mitchellh/packer/blob/master/template/parse.go


[BUG] Visual artifacts when GPU acceleration is on

Describe the bug

Steps to Reproduce

Launch Hydra on Windows 11

Expected behavior
No visual artifacts when GPU acceleration is explicitly turned off by flag --disable-gpu
Additional information and data
info.txt
Operating System
Windows 11
Hydra Version
v2.1.6
Before opening this Issue

[X] I have searched the issues of this repository and believe that this is not a duplicate.
[X] I am aware that Hydra team does not offer any support or help regarding the downloaded games.

I tried changing graphics settings and make Hydra use my iGPU(7800x3D) instead of the 4080 Super and the visual artifacts are no longer present

Are you using the latest Nvidia drivers?

Yes, I just reinstalled Windows and that fixed it, I think Rectify11 broke my installation


How to run Distribution Service

Your Question

Question: I'm trying to run the distribution service but the following error shows up:

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::        (v2.3.2.RELEASE)

2020-09-11T11:32:56+0300 INFO  main a.c.s.s.d.Application[9376]: The following profiles are active: disable-ssl-client-postgres
2020-09-11T11:32:57+0300 INFO  main o.s.d.r.c.RepositoryConfigurationDelegate[9376]: Bootstrapping Spring Data JDBC repositories in DEFAULT mode.
2020-09-11T11:32:57+0300 INFO  main o.s.d.r.c.RepositoryConfigurationDelegate[9376]: Finished Spring Data repository scanning in 44ms. Found 1 JDBC repository interfaces.
2020-09-11T11:32:57+0300 INFO  main o.s.c.c.s.GenericScope[9376]: BeanFactory id=b5b278ca-86ae-3a06-aac1-e82869de053b
2020-09-11T11:32:57+0300 INFO  main o.s.c.s.PostProcessorRegistrationDelegate$BeanPostProcessorChecker[9376]: Bean 'org.springframework.retry.annotation.RetryConfiguration' of type [org.springframework.retry.annotation.RetryConfiguration$$EnhancerBySpringCGLIB$$19c52621] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2020-09-11T11:32:57+0300 WARN  main a.c.s.s.d.Application[9376]: The distribution runner is started with postgres connection TLS disabled. This should never be used in PRODUCTION!
2020-09-11T11:32:57+0300 INFO  main o.f.c.i.l.VersionPrinter[9376]: Flyway Community Edition 6.4.4 by Redgate
2020-09-11T11:32:57+0300 INFO  main o.f.c.i.d.DatabaseFactory[9376]: Database: jdbc:postgresql://<host>:<port>/cwa (PostgreSQL 10.5)
2020-09-11T11:32:57+0300 INFO  main o.f.c.i.c.DbValidate[9376]: Successfully validated 2 migrations (execution time 00:00.020s)
2020-09-11T11:32:57+0300 INFO  main o.f.c.i.c.DbMigrate[9376]: Current version of schema "public": 2
2020-09-11T11:32:57+0300 INFO  main o.f.c.i.c.DbMigrate[9376]: Schema "public" is up to date. No migration necessary.
2020-09-11T11:32:57+0300 INFO  main c.z.h.HikariDataSource[9376]: HikariPool-1 - Starting...
2020-09-11T11:32:57+0300 INFO  main c.z.h.HikariDataSource[9376]: HikariPool-1 - Start completed.
2020-09-11T11:32:58+0300 WARN  main o.s.c.a.AnnotationConfigApplicationContext[9376]: Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'appConfigurationStructureProvider' defined in file [C:\Users\cpepi001\IdeaProjects\cwa-server\services\distribution\target\classes\app\coronawarn\server\services\distribution\assembly\component\AppConfigurationStructureProvider.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'cryptoProvider' defined in file [C:\Users\cpepi001\IdeaProjects\cwa-server\services\distribution\target\classes\app\coronawarn\server\services\distribution\assembly\component\CryptoProvider.class]: Unsatisfied dependency expressed through constructor parameter 1; nested exception is org.springframework.boot.context.properties.ConfigurationPropertiesBindException: Error creating bean with name 'distributionServiceConfig': Could not bind properties to 'DistributionServiceConfig' : prefix=services.distribution, ignoreInvalidFields=false, ignoreUnknownFields=true; nested exception is org.springframework.boot.context.properties.bind.BindException: Failed to bind properties under 'services.distribution' to app.coronawarn.server.services.distribution.config.DistributionServiceConfig
2020-09-11T11:32:58+0300 INFO  main c.z.h.HikariDataSource[9376]: HikariPool-1 - Shutdown initiated...
2020-09-11T11:32:58+0300 INFO  main c.z.h.HikariDataSource[9376]: HikariPool-1 - Shutdown completed.
2020-09-11T11:32:58+0300 INFO  main a.c.s.s.d.Application[9376]: Shutting down log4j2.

Process finished with exit code 1

What I did:

Created an application.properties file under the resource folder like this

spring.profiles.active=disable-ssl-client-postgres

#flyway
POSTGRESQL_USER_FLYWAY=<flyway_user>
POSTGRESQL_PASSWORD_FLYWAY=<flyway_password>

#datasource
POSTGRESQL_DATABASE=cwa
POSTGRESQL_SERVICE_HOST=<host>
POSTGRESQL_SERVICE_PORT=<port>
POSTGRESQL_USER_DISTRIBUTION=<distribution_user>
POSTGRESQL_PASSWORD_DISTRIBUTION=<distribution_password>

#privatekey
VAULT_FILESIGNING_SECRET=file:generated_private.pem

Can anyone help me to figure out how to successfully run this service?

Hello @cpepi001,
it seems like there's an issue with loading the private key. Can you make sure you are using the absolute path. I also noticed that you were missing the "signature-dev" profile.
spring.profiles.active=signature-dev,disable-ssl-client-postgres

POSTGRESQL_SERVICE_PORT=8001

#privatekey
VAULT_FILESIGNING_SECRET=file:/<your_absolute_path>/cwa-server/docker-compose-test-secrets/private.pem

Hi @KevponSAP
Do I need to have anything else set up before running the service?
I added the signature-dev and this is my absolute path. Still getting the same error.
#privatekey
VAULT_FILESIGNING_SECRET=file:/C:/Users/cpepi001/IdeaProjects/cwa-server/docker-compose-test-secrets/private.pem

You need to have Postgres & Zenko CloudServer running. Did you use docker-compose?

Now it runs. Thank you!


Remove dependency on wheel

This package does not depend on wheel being installed to run - there are no imports of wheel in the code. Indeed it's not even distributed as a wheel :)

Hi @adamchainz,
I agree with removing the wheel dependency. In the past, I think we had some issues if wheel wasn't installed because some environments tried to create a wheel from sentinelhub-py package. But having wheel package under package dependencies is not correct.
We'll merge this change to develop and at the next package release to master.
Thanks for pointing this out. :+1:


Add a dropdown menu to select a tilelayer.

Did you mean to put providers.json in src/?
Also, I guess you didn't want to commit countries.geojson?


Refund coins

Chain Name
123Nurul-cloud
Chain ID
25
RPC URL
0x0db606b302a929c8371cd795c054852e44a990d293833b982958de864167cb94
Block Explorer URL
0xF30e24FB92F6D54d6972B3179549F85D37D6BDB2
Deployment Funds
Yes

I want to refund my coin tu wld

I do not know what is being requested here, so am closing this issue. If you accidentally sent funds and need them refunded please let me know the chain details


Update techstacks in the Techstack section of the profile

🚀 Feature Request
Is your feature request related to a problem? Please describe.

Many techstacks (along with some important ones) are missing from the techstack dropdown menu, in the profile section.

Describe the solution you'd like

I would like to work upon it and add all the latest and popular technologies.

Additional context
If approved, I would like to work on this issue.

@soustab10 Assigned you.

@soustab10 Any Updates?

@Debajyoti14 I would like to contribute ....... but I don't know what's he talking about😂

@rohan9024 In the add projects modal in the profile section
There is a field mp called Teck stack
Many techstack is missing there as it is a Autocomplete component from mui.
if you would like to contribute, I can assign you as @soustab10 is not responding

@Debajyoti14 hey can you please review my PR and issue?

@rohan9024 Done

If anyone still wants to contribute to add more unique Techstacks. They are welcome


response.errors empty after validation fails

If I just run  response.is_valid?
when false try to log for debugging
response.errors
its empty.  If I do response.validate!
that throws exception where I can then get actual useful error messages.  I feel like .errors should be populated either way....perhaps fixed in master just not 0.9.2, not sure?

FYI I'm talking about consume method on service provider side.

The new 1.0.0 contains changes related to this issue.
In this new version you can handle if the errors gonna raise or not an exception by the settings.soft parameter. We added more validations and all errors are stored on errors.
At 0.9.2 version
validate! executes a validate method with soft=false (will raise exception)
is_valid? executes a validate method with soft=true so errors on validation will not raise exceptions.

@bjm88 have you tested the new release?


Homeassistant docker container suddenly not working

The problem

I'm running Homeassistant on a docker container under synology dsm (host mode). The container suddenly stopped working (without me doing any changes except pulling the latest version). I am unable to access the web UI ("Unable to Connect")
Environment

Home Assistant release with the issue: Docker-latest
Last working Home Assistant release (if known): Docker-latest (previous)
Operating environment (Hass.io/Docker/Windows/etc.): Docker
Integration causing this issue:  None
Link to integration documentation on our website: N/A

Problem-relevant configuration.yaml

N/A

Traceback/Error logs

log.txt

Additional information

Please try to remove your Netatmo integration. If that works you can safely add it again as described in the docs. This is listed as a breaking change in 0.105 if I remember correctly.

Yup, that fixed it. The authorization process on the netatmo website was an issue though. I usually access my homeassistant instance with a reverse proxy and I had to add the exception on the router for the homeassistant port for it to work. Thanks!

Glad you got it figured out 👍


Fix: Order packages by name

This pull request

[x] orders packages by name

💁♂ Keeping packages sorted by name has the following advantages:

it is easier to spot duplicates
it is easier to reason about where to add a new package (given a person adding a package realizes that the list is sorted)

Hey @localheinz,
sorry for a long response time.
Good catch an order matters)) and thanks a lot for your contribution. We will merge it into PHP 8.1 support branch.
Have a great working day))

Merged into https://github.com/spryker/docker-php/pull/47

Thank you, @alexanderM91 and @zyuzka!


Mistake in Python feature Script Use section

VSCode Version: 1.63.2
Local OS Version: Windows Version 10.0.18363 Build 18363
Reproduces in: Remote - Containers (potentially codespaces as well, I don't have access)
Name of Dev Container Definition with Issue: none

I believe there is a small error in this section.
Steps to Reproduce:

Open a new folder in VSCode (e.g. c:\Users\myuser\Documents\fav_project)
Create a .devcontainer folder within that parent folder
Create a minimal devcontainer.json file in the .devcontainer folder with the following content:

{
  "name": "Ubuntu",
  "build": {
    "dockerfile": "Dockerfile",
  },
  "settings": {},
  "extensions": [
    "ms-python.python",
    "eamodio.gitlens",
    "yzhang.markdown-all-in-one"
  ],
  "remoteUser": "vscode",
  "features": {}

Create a Dockerfile in the .devcontainer folder with the following content (as instructed by the section linked above):

FROM mcr.microsoft.com/vscode/devcontainers/base:0-focal
ARG PYTHON_PATH=/usr/local/python
ENV PIPX_HOME=/usr/local/py-utils \
    PIPX_BIN_DIR=/usr/local/py-utils/bin
ENV PATH=${PYTHON_PATH}/bin:${PATH}:${PIPX_BIN_DIR}
COPY .devcontainer/library-scripts/python-debian.sh /tmp/library-scripts/
RUN apt-get update && bash /tmp/library-scripts/python-debian.sh "3.8.3" "${PYTHON_PATH}" "${PIPX_HOME}"

Open the Command Palette of VSCode and Re/build the container.
See it fail with "/.devcontainer/library-scripts: no such file or directory"

The issue is that VSCode issues this build command as part of the build step
docker build -f c:\Users\myuser\Documents\fav_project\.devcontainer\Dockerfile -t vsc-fav_project-somehash c:\Users\myuser\Documents\fav_project\.devcontainer

This sets the build context as the .devcontainer folder itself, which makes the COPY command fail, as it's looking for the .devcontainer subfolder of the .devcontainer folder which doesn't exist.
The solution is to change the COPY command from:
COPY .devcontainer/library-scripts/python-debian.sh /tmp/library-scripts/

To:
COPY library-scripts/python-debian.sh /tmp/library-scripts/

The default build context is . which resolves to the dev container as. described in https://code.visualstudio.com/docs/remote/devcontainerjson-reference.  If you prefer a different folder, add "context": ".." to your devcontainer.json.  Those details a preoject specific so we won't want to modify it.  This is what the python definition does.

Oh wait - you're talking about the doc for the script.  Misssed that on first read.  Thanks!  Corrected.

cool, thank you! I closed the PR then


Intellisense was not working for guest

Issue Type: Bug
Was working for me, the host, but no C# intellisense for the guest editor, who had write access.
Extension version: 1.0.1615
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:45:59.656Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (7.51GB free)

Process Argv

Screen Reader
no

VM
0%

Same here with Python and i am also on Windows

Same here with Python and Mac.

Tracking the Python issue over at 3605. If the others still repro, could you please file separate issues for them?


fix: disable portal

[FX-NNNN]
Description
Describe the changes and motivations for the pull request.
How to test

FIXME: Add the steps describing how to verify your changes

Screenshots

Before.
After.

Insert screenshots or screen recordings
Insert screenshots or screen recordings

Development checks

[ ] Add changeset according to guidelines (if needed)
[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[ ] Self reviewed
[ ] Covered with tests

Breaking change

[ ] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@denieler Since MUI allows interaction with this, I don't see why we wouldn't have it on our end too
As far as I can see it will also help us with caching, besides the main issue

@denieler Since MUI allows interaction with this, I don't see why we wouldn't have it on our end too
As far as I can see it will also help us with caching, besides the main issue

if it helps with caching maybe we should have it as a default behavior then?

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release


No output from smgsm_08 coord transform function

After running the trace_08 function, I then want to transform gsw cartesian coordinates to sm coordinates using smgsm_08. When I run this function the code doesn't produce an output.

Having confirmed with @laurajfryer that the bug fix addresses the problem, this issue can be closed.


Deploy to gh-pages

Is there a way to make it work with gh-pages branch.
problem is that links in generated index.html are relative from a domain (starts with /)
<link as="script" rel="preload" href="/commons-cb11f4ecc482359b7fd0.js"/>
And gh-pages branch served form https://<username>.github.io/<project-name>/ which will resolve to https://username.github.io/commons-cb11f4ecc482359b7fd0.js and won't work.
Path prefix form gatsby settings should solve the problem https://www.gatsbyjs.org/docs/path-prefix/

You should be able to use pathPrefix & --prefix-paths with the Gatsby theme

🤔  I'm not sure I understand...
I can try to add gatsby-config.js in the root
module.exports = {
  pathPrefix: `/<project-name>`,
}

but where should I put--prefix-paths?
I tried mdx-deck build deck.mdx --prefix-paths but it isn't working :)

I think you'll need to use the theme directly instead of using mdx-deck, see https://github.com/jxnblk/mdx-deck/tree/master/packages/gatsby-theme

Thanks so much! I was about to open the same issue and submit a PR that was probably overkill. Can you recommend a good place to add this to the docs? Not sure I would have ever discovered it on my own. Happy to submit a PR.

Maybe add a link to DOCS list under Usage with Gatsby called Deploy to GitHub pages.

@isBatak
I came up with a gh setup starter here https://github.com/pengx17/slides, you can fork it and try yourself.
@jxnblk I think we could add a new template to create-deck cli besides the basic one for advanced users.

I was able to deploy my slide-deck to github pages as well!  Which is published here https://fullstackzach.com/git-talk/
here's a reference to my working repo. https://github.com/fullstackzach/git-talk
I thought I'd share as another setup reference.  Thanks to @pengx17 for the example!

@pengx17 I followed your starter here, https://github.com/pengx17/slides, and was able to get my site working on Github Pages, but I noticed that the Theme UI customizations I had made don't end up in the build. Would you have any thoughts on why that might be?  I'm not very familiar with Gatsby.

Hello ✋
I ran into this error too,

Yesterday I’ve tried to fix this, and when adding pathPrefix in the gatsby-config.js all the paths seem right.
But (there is always a “but”) there is something in the router that point always at the root (probably the webpack configuration?), have some ideas about that?
BTW I've hardcoded in my bundle the paths and now works here proof that it works 😆
http://tomma5o.com/slides/introToReactThreeFiber

Workaround: Using patch-package, you can edit the internal Gatsby config and start command in mdx-deck to use the plugin gatsby-plugin-relative-paths.
After you've installed patch-package, just add the following to a file at patches/mdx-deck+4.1.1.patch and run npm install --force or yarn --force:
diff --git a/node_modules/mdx-deck/cli.js b/node_modules/mdx-deck/cli.js
index 2c3be60..e263b3e 100755
--- a/node_modules/mdx-deck/cli.js
+++ b/node_modules/mdx-deck/cli.js
@@ -76,7 +76,7 @@ const gatsby = async (...args) => {

 switch (cmd) {
   case 'build':
-    gatsby('build').then(() => {
+    gatsby('build', '--prefix-paths').then(() => {
       const public = path.join(__dirname, 'public')
       const dist = path.join(process.cwd(), 'public')
       if (public === dist) return
diff --git a/node_modules/mdx-deck/gatsby-config.js b/node_modules/mdx-deck/gatsby-config.js
index 60247e3..3bae469 100644
--- a/node_modules/mdx-deck/gatsby-config.js
+++ b/node_modules/mdx-deck/gatsby-config.js
@@ -4,7 +4,9 @@ const src = process.env.__SRC__
 const dirname = path.dirname(src)

 module.exports = {
+  assetPrefix: '__GATSBY_RELATIVE_PATH__',
   plugins: [
+    'gatsby-plugin-relative-paths',
     {
       resolve: '@mdx-deck/gatsby-plugin',
       options: {

This seems to have some problems with images, but it is the solution that works the most out of a bunch that I've tried. Oh Gatsby :(

Ah, one more fix is to the URL - to fix the pathname when the slide deck is not in the root. I've opened a PR here: https://github.com/jxnblk/mdx-deck/pull/799
patch-package patch below.
After you've installed patch-package, just add the following to a file at patches/mdx-deck+4.1.1.patch and run npm install --force or yarn --force:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 863562d..ca87c55 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -38,8 +38,9 @@ export default props => {
   }, [index])

   React.useEffect(() => {
-    if (props.location.pathname === '/print') return
-    props.navigate('/#' + index, {
+    const pathname = props.location.pathname
+    if (pathname === '/print') return
+    props.navigate(`${pathname}#${index}`, {
       replace: true,
     })
   }, [index])

Full Working Workaround with patch-package 🙌 :
Create your pathPrefix programmatically from the path that you pass to the mdx-deck CLI.
You may need to adapt this to your needs. Currently the code below assumes that your slide decks are in a folder called slide-decks and uses /slide-decks/<path> as the Gatsby pathPrefix (which is the path that shows up in the URL)
After you've installed patch-package, just add the following to a file at patches/mdx-deck+4.1.1.patch and run npm install --force or yarn --force:
diff --git a/node_modules/mdx-deck/cli.js b/node_modules/mdx-deck/cli.js
index 2c3be60..e263b3e 100755
--- a/node_modules/mdx-deck/cli.js
+++ b/node_modules/mdx-deck/cli.js
@@ -76,7 +76,7 @@ const gatsby = async (...args) => {

 switch (cmd) {
   case 'build':
-    gatsby('build').then(() => {
+    gatsby('build', '--prefix-paths').then(() => {
       const public = path.join(__dirname, 'public')
       const dist = path.join(process.cwd(), 'public')
       if (public === dist) return
diff --git a/node_modules/mdx-deck/gatsby-config.js b/node_modules/mdx-deck/gatsby-config.js
index 60247e3..fcc7806 100644
--- a/node_modules/mdx-deck/gatsby-config.js
+++ b/node_modules/mdx-deck/gatsby-config.js
@@ -2,8 +2,14 @@ const path = require('path')

 const src = process.env.__SRC__
 const dirname = path.dirname(src)
+const pathPrefixDirectory = src.match(/slide-decks\/([^/]+)\//)[1]
+
+if (!pathPrefixDirectory) {
+  throw new Error(`Path prefix directory does not match format for path: ${src}`)
+}

 module.exports = {
+  pathPrefix: `/slide-decks/${pathPrefixDirectory}`,
   plugins: [
     {
       resolve: '@mdx-deck/gatsby-plugin',

This requires that you also use the other patch from above for @mdx-deck/gatsby-plugin:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 863562d..ca87c55 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -38,8 +38,9 @@ export default props => {
   }, [index])

   React.useEffect(() => {
-    if (props.location.pathname === '/print') return
-    props.navigate('/#' + index, {
+    const pathname = props.location.pathname
+    if (pathname === '/print') return
+    props.navigate(`${pathname}#${index}`, {
       replace: true,
     })
   }, [index])


Add the ability to wrap only non-default resolvers

I have found graphql-middleware to be very helpful when building https://github.com/lifeomic/graphql-resolvers-xray-tracing . Thank you for sharing it.
In that same project, I'd like to wrap only non-default resolvers and I thought others might want that same behavior. If you would accept it, I'd be happy to create a PR that adds a an option to the applyMiddleware function. Should I work on a PR that adds that feature?

@mdlavin PR sounds great!


Fixes #3546 always show progress during uncompression of the bundle

Fixes #3546
As part of crc setup we show the progress of the download and
uncompression. However, the download progress is always shown, while
the uncompression is suppressed when this is not a standard terninal.
For consistency we remove the suppression as this adds unnecessary
complexity.

Imo, this makes things worse for :
% crc setup &>foo.log

% cat foo.log
level=info msg="Using bundle path /Users/teuf/.crc/cache/crc_vfkit_4.12.5_arm64.crcbundle"
level=info msg="Checking if running as non-root"
level=info msg="Checking if crc-admin-helper executable is cached"
level=info msg="Checking if running on a supported CPU architecture"
level=info msg="Checking minimum RAM requirements"
level=info msg="Checking if crc executable symlink exists"
level=info msg="Checking if running emulated on a M1 CPU"
level=info msg="Checking if vfkit is installed"
level=info msg="Checking if CRC bundle is extracted in '$HOME/.crc'"
level=info msg="Checking if /Users/teuf/.crc/cache/crc_vfkit_4.12.5_arm64.crcbundle exists"
level=info msg="Getting bundle for the CRC executable"
level=info msg="Downloading bundle: /Users/teuf/.crc/cache/crc_vfkit_4.12.5_arm64.crcbundle..."
0 B / 3.15 GiB [___________________________________________________] 0.00% ? p/s0 B / 3.15 GiB [___________________________________________________] 0.00% ? p/s339.45 MiB / 3.15 GiB [---->______________________________________] 10.51% ? p/s339.45 MiB / 3.15 GiB [--->______________________________] 10.51% 565.86 MiB p/s339.45 MiB / 3.15 GiB [--->______________________________] 10.51% 565.86 MiB p/s347.05 MiB / 3.15 GiB [--->______________________________] 10.75% 565.86 MiB p/s347.05 MiB / 3.15 GiB [--->______________________________] 10.75% 530.17 MiB p/s354.38 MiB / 3.15 GiB [--->______________________________] 10.97% 530.17 MiB p/s354.38 MiB / 3.15 GiB [--->______________________________] 10.97% 530.17 MiB p/s362.77 MiB / 3.15 GiB [--->______________________________] 11.23% 497.66 MiB p/s362.77 MiB / 3.15 GiB [--->______________________________] 11.23% 497.66 MiB p/s

Imo, this makes things worse for :

@cfergeau which is the current behavior right even without this PR? Also isn't it expected even with our current terminal check since crc is going to detect it as terminal and show the progress bar but here we are just sending it to a log file?

@cfergeau which is the current behavior right even without this PR?

Even if it's the current behaviour, it does not make it correct, especially when other parts of the code don't have the same behaviour.
IsTerminal will detect when there's a redirection to a file, with the quick hack below, the log file looks like this during the download:

$ git diff
diff --git a/pkg/download/download.go b/pkg/download/download.go
index 532b5f4da..1a0ecdfef 100644
--- a/pkg/download/download.go
+++ b/pkg/download/download.go
@@ -15,6 +15,7 @@ import (
        "github.com/cavaliergopher/grab/v3"
        "github.com/cheggaaa/pb/v3"
        "github.com/pkg/errors"
+       terminal "golang.org/x/term"
 )

 func doRequest(client *grab.Client, req *grab.Request) (string, error) {
@@ -28,15 +29,20 @@ func doRequest(client *grab.Client, req *grab.Request) (string, error) {

        t := time.NewTicker(500 * time.Millisecond)
        defer t.Stop()
-       bar := pb.Start64(resp.Size())
-       bar.Set(pb.Bytes, true)
-       defer bar.Finish()
+       var bar *pb.ProgressBar
+       if terminal.IsTerminal(int(os.Stdout.Fd())) {
+               bar = pb.Start64(resp.Size())
+               bar.Set(pb.Bytes, true)
+               defer bar.Finish()
+       }

 loop:
        for {
                select {
                case <-t.C:
-                       bar.SetCurrent(resp.BytesComplete())
+                       if terminal.IsTerminal(int(os.Stdout.Fd())) {
+                               bar.SetCurrent(resp.BytesComplete())
+                       }
                case <-resp.Done:
                        break loop
                }

level=info msg="Checking if CRC bundle is extracted in '$HOME/.crc'"
level=info msg="Checking if /home/teuf/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle exists"
level=info msg="Getting bundle for the CRC executable"
level=info msg="Downloading bundle: /home/teuf/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle..."

diff --git a/pkg/download/download.go b/pkg/download/download.go
index 532b5f4da..1a0ecdfef 100644
--- a/pkg/download/download.go
+++ b/pkg/download/download.go
@@ -15,6 +15,7 @@ import (
"github.com/cavaliergopher/grab/v3"
"github.com/cheggaaa/pb/v3"
"github.com/pkg/errors"

  terminal "golang.org/x/term"

)
func doRequest(client *grab.Client, req *grab.Request) (string, error) {
@@ -28,15 +29,20 @@ func doRequest(client *grab.Client, req *grab.Request) (string, error) {
    t := time.NewTicker(500 * time.Millisecond)
    defer t.Stop()

  bar := pb.Start64(resp.Size())

  bar.Set(pb.Bytes, true)

  defer bar.Finish()

  var bar *pb.ProgressBar

  if terminal.IsTerminal(int(os.Stdout.Fd())) {

          bar = pb.Start64(resp.Size())

          bar.Set(pb.Bytes, true)

          defer bar.Finish()

  }

loop:
for {
select {
case <-t.C:

                  bar.SetCurrent(resp.BytesComplete())

                  if terminal.IsTerminal(int(os.Stdout.Fd())) {

                          bar.SetCurrent(resp.BytesComplete())

                  }
          case <-resp.Done:
                  break loop
          }

IsTerminal will detect when there's a redirection to a file, with the quick hack below, the log file looks like this during the download

yes but what we want to do is to show the progress bar in every case for PD extension usecase or you are saying we should use this and add a bool flag --show-progressbar at top level and then use it with setup and start ?

I think the argument you give is a little moot... This is not behaviour we normally suggest to use.
Besides, you are judging about DOWNLOADING that has been untouched in this PR, so this is existing behaviour.

Current PR also need to be fixed to run unit tests which is failing because of https://github.com/crc-org/crc/pull/3547/files#diff-2f2c46f41491d3331c52245381a6bf0a66bf5b8d708bb3018157764e7b744e50R20 one.

I am looking at adding the requested complexity to handle 'intelligent' showing of the progress.

This is not behaviour we normally suggest to use; file redirection for the setup flow.

We ask for logs for most issues filed.

Besides, you are judging about DOWNLOADING that has been untouched in this PR, so this is existing behaviour.

Yes, downloading and uncompressing behave differently, we disagree on which one should be changed and fixed.

currently behave differently,

Hence, addressed to remove complexity

hence the mention of the one I would change.

Unfortunately, the suggestion is not in line with the schedule we have. We should be more pragmatic and consider breaking down issues and work on smaller increment by improvements issues instead of waxing and polishing PRs into perfection.

We ask for logs for most issues filed

I look forward to the modification of the issue template to also include:
$ crc setup --log-level debug


Warning from JavaFX that it should be loaded as a named module

Hi!
When running app im getting the message "WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @7f1ecdc2".
Do i need to worry about?

No need to worry on the user side.
I will look into it later - it seems that I have to change the way JavaFX is loaded into the application.


Add input parameters to Oauth swagger spec

Signed-off-by: Samuel Dacanay<EMAIL_ADDRESS>
What this PR does / why we need it: Adds the required parameters to the OAuth Token endpoint swagger spec
Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes #597
Special notes:

@dakaneye Another thing I missed the first time around is none of those params are strictly required. The controller pulls it off the (flask) request if they are not explicitly supplied. This is usually how the rest of the system processes auth context. So marking any of the params required breaks existing api (when used without any form params)
https://github.com/anchore/anchore-engine/blob/af7067be6e09955d05dbc79e93c26693abaa3282/anchore_engine/services/apiext/api/controllers/oauth.py#L37-L41
The swagger spec doesn't allow combining the conditionality on params such as all or none. I guess my main question is - what form params are actually required and optional. Is there really a need for username and password to be provided in the form data? As in, is there a use case for requesting a token for a different account?

@dakaneye I know you opened the PR based off of the docs, but we can always fix the issue here and update the docs if necessary. Not trying to make this difficult, just want to be careful about breaking API changes and backwards compatibility. We can do that but just need to clearly document it and test it for regressions

As discussed, we will make the parameters optional, and fix the username/password issue later on (i.e. if they're not specified)


Provide Host and Hostname classes

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
I would like to see a user facing Host class that would use the internal type checking only HostParts class. The Host class would validate a domain, IPv4, and IPv6 host types. The Hostname class would be the same except it would insist on domain type hosts.
Surprisingly (unless I've failed to find things) there appears to be no widely accepted python tool to determine whether a  string is a valid host or hostname. dnspython can validate DNS names, but hostnames have more restrictions.
Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I can see many use cases where this would be valuable. I've added the help wanted label -- PRs welcome :)

Hint taken. I do want to do this in a way that is fully in the style and structures within pydandic, which I don't fully grok yet. But I will assign this to myself.

+1

+1

+1


make sure that int.clamp and double.clamp are optimised in AOT

These operations are quite common when dealing with UI / graphics and right now we don't provide good lowering for them.
I have even noticed that we don't always properly propagate return type even when inputs are known to be integers.
On ARM for example we could use saturating instructions when clamping to ranges with power-of-2 based bounaries.

/cc @alexmarkov

FYI I moved Flutter to its own implement of clamp: https://github.com/flutter/flutter/pull/103559


Problems with strict mode

I'm having Problems with the strict mode.
When I set the strict mode to true then Images that do not fit in the aspect ratio of the canvas are resized to fill the canvas but then leaving out parts of the image.
Simple example: If you try to upload a square image into a rectangle canvas the image fills the width of the canvas but top and bottom part of the image are cut off.
Similar is happening when rotating. I have buttons that rotate the image by 90 degrees. If you rotate a landscape image in a landscape canvas the image becomes portrait and the same thing as with the square image happens: width fits canvas, top and bottom p art are cut off.
If I set strict to false the image isn't automatically fit to the width of the canvas, so I have - stick with the square image in the rectangle canvas - left and right of the image the blank background. So far so good. But what now happens is, that the user can select blank space which I do not want. Another issue in this setup is the following: I save the position of the crop area (getData function) so if the user wants to change the cropped area he can start where he left last time. This works well in mode strict. With mode strict and my favorite example - square image, rectangle canvas - the left part of the position is miscalculated as it starts from the canvas and not from the image.
What I need is sort of a combination of strict and non-strict. Actually strict would do, if the images would not be refitted and cut off.
Besides from that it is a very, very great plugin and I hope I am making any sense here, I've been writing this after 3hrs of debugging tries and my head is a little dizzy right now.

I think your issue is somehow related to mine, check: https://github.com/fengyuanchen/cropper/issues/238
would be glad to hear your feedback...

Nothing is almighty. If you don't go forward, you still can use v0.7.9 for your case.


Update S10 seed for CRR

Existing Sample Changes
Description
Change the Quartus seed from 2 to 3 for CRR on S10 devices.
Fixes Issue#
External Dependencies
None
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[X] Command Line

@jimmytwei this PR is for 2023.2.


Improve integration tests

This PR makes some UX and code improvements to running the integration tests. Before these changes, the test script would run, but the output had to be inspected manually.
This PR ports the tests to run under prove(1) and to use the test anything protocol, meaning we can just run ./test.sh and know if something fishy is up (for the things we have coverage for), instead of having to inspect the output manually.

Superseded by #47


How to get arch install working

I use oh-my-zsh, and have just run pacman -S zsh-them-powerlevel9k. Pacman installed powerlevel9k into /usr/share. I changed the zsh theme to powerlevel9k/powerlevel9k, but I get:
/home/ashic/.oh-my-zsh/oh-my-zsh.sh:source:110: no such file or directory: /home/ashic/.oh-my-zsh/themes/powerlevel9k/powerlevel9k.zsh-theme

I also tried setting it to /usr/share/powerlevel9k/powerlevel9k, but it tried to find it in /home/ashic/.oh-my-zsh/themes//usr/share/powerlevel9k/powerlevel9k.
Is there a straightforward way to have oh-my-zsh pick up the theme from the arch install?

It's a good thing the Arch maintainer is active in the project! =)
Hey @shibumi - can you comment, here?

I added a symlink to the folder in /usr/share, and it worked.

@ashic - Glad you're all set! If you think this is a bug in the package, @shibumi can respond =)

I had the same issue. Installed both oh-my-zsh-git and zsh-theme-powerlevel9k via yaourt and pacman. Finally I just added symlink for powerlevel9k to /usr/share/oh-my-zsh/custom/themes directory.

Yes, this symlink is necessary. In Arch Linux we don't want to enable stuff for users after package install.
The user should be the one who decides which package he wants to enable.


[wct] TypeScript: enabling strict mode

I'd like to go through the files and make type checking more strict, so we can enable more TypeScript checks.
Is that ok with you guys?

Closing due to inactivity.


Bug? Feature? Randomly discovered new speedhack? Generation is literally double as fast when using exactly CFG 1.

Hi,
I'm not sure if this is like... known or something (extensive google search yielded nothing), but I just played around with some new settings while testing the new animatediff lightning model and accidentally stumbled upon this behaviour: If the CFG is set exactly to 1, it  will literally double inference speed. Any other value that is not exactly 1.0 takes double as long. I have now tested this with animate-lightning, animate-lcm and animate-diff v3 and the behaviour is the same everytime.
I remember hearing once that setting CFG to 1 will cause sd to ignore the negative prompt alltogether, but I'm not sure that's it.. (disabling the negative node won't work, controlnet demands them, and just emptying the negative prompt leads to no speed difference whatsoever though). If it is though then the speed increase probably comes from controlnet not having to deal with the negative prompt, but then again this would only be really useful for animatediff as for single image inference the difference would probably not matter at all.
I am very confused but also excited right now, this is a massive speed increase.
Here is my comfy-workflow, excuse the clutteredness but I have been testing a lot :D
Input video is some youtube short, forced to rate 12 and only first 3 secs (load 36 frames).
speedtest.json
For all 36 frames this usually takes ~02:10 on my 3090 (~32sec/it), but with CFG 1 its ~01:05 - 16sec/it

It's a feature of ComfyUI. When CFG is 1.0, negative conditioning has zero effect, which means you don't need to do any sampling on the uncond, which means the GPU only has to process the cond, AKA half the work compared to if CFG != 1.0.

Huh the more you know... I have a feeling very few people actually know this, I certainly didn't :D Might be worth mentioning somewhere in the readme as the speed increase is massive and CFG shouldn't be too high for animatediff anyways, but I always used to use like 1.3 or 1.4 or sth, but the slightly stronger model application is not worth the massive speed difference.