[Event Request] codeunit 80 "Sales-Post" OnPostUpdateOrderLine

Hello is it possible to get the following event. Or a modification on OnBeforePostUpdateOrderLineModifyTempLine
                SetDefaultQuantity;
                OnBeforePostUpdateOrderLineModifyTempLine(TempSalesLine, WhseShip, WhseReceive, SuppressCommit);
                // DINNL <<
                DINIsHandled := false;
                DINOnPostUpdateOrderLine(TempSalesLine, SalesHeader, WhseHandlingRequired(TempSalesLine), DINIsHandled);
                if not DINIsHandled then
                    // DINNL >>
                ModifyTempLine(TempSalesLine);
                OnAfterPostUpdateOrderLineModifyTempLine(TempSalesLine, WhseShip, WhseReceive, SuppressCommit, SalesHeader);

[IntegrationEvent(false, false)]
local procedure DINOnPostUpdateOrderLine(var TempSalesLine: Record "Sales Line" temporary; SalesHeader: Record "Sales Header"; WhseHandlingRequired: Boolean; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Reduce version specification duplication by using workspace inheritance

Having the same version written two or three times is a binary size hazard and
just a tech debt pitfall in general. Using workspace inheritance we can specify
versions only once and reuse them.

@cjpatton if the version matches 100% then cargo will not compile the crate twice, but if for some reason it deviates then the dependency is compiled twice. Currently this was not the case for any dependency but this way it we are sure it's never the case


Only use rule regex/path if rule.Description is empty

sarif description output should prioritize rule.Description.
Description:
The current sarif output creates a description based on the rule's regex instead of the rule's description, which makes very little sense when interpreted by tools that process sarif, such as GitHub Code Scanning. See image for illustration.

This change will improve upon that by using the rule's description, and use regex or path as the fallback instead.
Checklist:

[x] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you lint your code locally prior to submission?

view of the updated results


The icons show up as a crossed out box on some devices

Environment
react-native-vector-icons: 7.1.0
react native: 0.63.4
Android

Description
I'm using react-native-vector-icons in my app. Today a user reported that the icons show up as a crossed out box and shared a screenshot. The problem occurs on Samsung Galaxy Note 20 Ultra. I've tested over 2000 devices, and none had such a problem.
I have the following code at the end of my android/app/build.gradle file:
apply from: "../../node_modules/react-native-vector-icons/fonts.gradle"
Code:
import Icon from 'react-native-vector-icons/FontAwesome5';
.
.
.
<View style={{flexDirection:"row"}}>
<Icon
            name={"cog"}
            color={"black"}
            size={screen_width / 15}
/>
<Icon
            name={"history"}
            color={"black"}
            size={screen_width / 15}
/>
<Icon
            name={"award"}
            color={"black"}
            size={screen_width / 15}
/>
<Icon
            name={"trophy"}
            color={"black"}
            size={screen_width / 15}
/>
</View>

And the result:

The same issue also appears on a Galaxy s10 after the One Ui 3.0 update

The same issue also appears on a Galaxy s10 after the One Ui 3.0 update

I have exactly same issue on my device (Samsung Galaxy Note10+, Android11, OneUI 3.0).
They were show up rightly on other devices like iOS devices or Android Device(Android10, AOSP)
Here's my Environment.

React-native-vector-icons : 7.1.0
React Native : 0.63.3

Like the picture attached above, I found that only FontAwesome5 icons show up with empty box or weird Chinese character. (second and fourth button).
On the other hand, The other buttons that I used with IonIcon shows up rightly.

I have exactly same issue on my device (Samsung Galaxy Note10+, Android11, OneUI 3.0).
They were show up rightly on other devices like iOS devices or Android Device(Android10, AOSP)
Here's my Environment.

React-native-vector-icons : 7.1.0
React Native : 0.63.3

Like the picture attached above, I found that only FontAwesome5 icons show up with empty box or weird Chinese character. (second and fourth button).
On the other hand, The other buttons that I used with IonIcon shows up rightly.

Would you like to build by adding fonts.gradle to android/app/build.gradle like this? (not android/build.gradle.)
Code:
/android/app/build.gradle
...
*   // supply additional arguments to the packager
*   extraPackagerArgs: []
* ]
*/
project.ext.react = [
        enableHermes: false,  // clean and rebuild if changing
]

project.ext.vectoricons = [
        iconFontNames: [ 'FontAwesome.ttf', 'FontAwesome5_Regular.ttf', 'FontAwesome5_Solid.ttf', 'FontAwesome5_Brands.ttf'] // <-- add this line (1/2)
]

apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" <- add this line (2/2)
apply from: "../../node_modules/react-native/react.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 ...

/src/App.js
import React from 'react';
import {SafeAreaView, StyleSheet, View, Text} from 'react-native';
import Icon from 'react-native-vector-icons/FontAwesome5';

const App: () => React$Node = () => {
  return (
    <SafeAreaView
      style={{
        justifyContent: 'center',
        alignItems: 'center',
        flexGrow: 1,
      }}>
      <Text style={styles.Header}>RNVC TEST</Text>
      <View style={{flexDirection: 'row'}}>
        <Icon name={'cog'} color={'black'} size={24} />
        <Icon name={'history'} color={'black'} size={24} />
        <Icon name={'award'} color={'black'} size={24} />
        <Icon name={'trophy'} color={'black'} size={24} />
      </View>
    </SafeAreaView>
  );
};

const styles = StyleSheet.create({
  Header: {
    fontSize: 24,
  },
});

export default App;

I created an RN project to reproduce the issue, installed react-native-vector-icons, and added Font Awesome 5 icons after setting,
but the problem is not occurring.
My env:

react-native: 0.63.4
react-native-vector-icons: 7.1.0

And I tested Samsung Galaxy Note 20 Ultra 5G(SM-N986N / Android 11(One UI 3.0)).

Would you like to build by adding fonts.gradle to android/app/build.gradle like this? (not android/build.gradle.)
Code:
/android/app/build.gradle
...
*   // supply additional arguments to the packager
*   extraPackagerArgs: []
* ]
*/
project.ext.react = [
        enableHermes: false,  // clean and rebuild if changing
]

project.ext.vectoricons = [
        iconFontNames: [ 'FontAwesome.ttf', 'FontAwesome5_Regular.ttf', 'FontAwesome5_Solid.ttf', 'FontAwesome5_Brands.ttf'] // <-- add this line (1/2)
]

apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" <- add this line (2/2)
apply from: "../../node_modules/react-native/react.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 ...

/src/App.js
import React from 'react';
import {SafeAreaView, StyleSheet, View, Text} from 'react-native';
import Icon from 'react-native-vector-icons/FontAwesome5';

const App: () => React$Node = () => {
  return (
    <SafeAreaView
      style={{
        justifyContent: 'center',
        alignItems: 'center',
        flexGrow: 1,
      }}>
      <Text style={styles.Header}>RNVC TEST</Text>
      <View style={{flexDirection: 'row'}}>
        <Icon name={'cog'} color={'black'} size={24} />
        <Icon name={'history'} color={'black'} size={24} />
        <Icon name={'award'} color={'black'} size={24} />
        <Icon name={'trophy'} color={'black'} size={24} />
      </View>
    </SafeAreaView>
  );
};

const styles = StyleSheet.create({
  Header: {
    fontSize: 24,
  },
});

export default App;

I created an RN project to reproduce the issue, installed react-native-vector-icons, and added Font Awesome 5 icons after setting,
but the problem is not occurring.
My env:

react-native: 0.63.4
react-native-vector-icons: 7.1.0

And I tested Samsung Galaxy Note 20 Ultra 5G(SM-N986N / Android 11(One UI 3.0)).

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@CXZ7720 Copying font files is a necessary action when manually configuring native settings.
Are you having the same problem if you add the above two lines to android/app/build.gradle
above apply from: "../../node_modules/react-native/react.gradle"?
(When the react-native link command is not executed and the font directory is not copied)
And how are your device's resolution, system font/language set?
I think that I see the two people having problems, it's a problem with Samsung's One UI 3.0.
However, it is difficult to debug because it does not occur on my device with the same One UI 3.0.
I'm sorry for not being able to help you much 😢

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@CXZ7720 Copying font files is a necessary action when manually configuring native settings.
Are you having the same problem if you add the above two lines to android/app/build.gradle
above apply from: "../../node_modules/react-native/react.gradle"?
(When the react-native link command is not executed and the font directory is not copied)
And how are your device's resolution, system font/language set?
I think that I see the two people having problems, it's a problem with Samsung's One UI 3.0.
However, it is difficult to debug because it does not occur on my device with the same One UI 3.0.
I'm sorry for not being able to help you much 😢

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@CXZ7720 Copying font files is a necessary action when manually configuring native settings.
Are you having the same problem if you add the above two lines to android/app/build.gradle
above apply from: "../../node_modules/react-native/react.gradle"?
(When the react-native link command is not executed and the font directory is not copied)
And how are your device's resolution, system font/language set?
I think that I see the two people having problems, it's a problem with Samsung's One UI 3.0.
However, it is difficult to debug because it does not occur on my device with the same One UI 3.0.
I'm sorry for not being able to help you much 😢

Hello again @edoko .
Following your tips, I just removed copy of font files, added only two lines in my build.gradle and then,  re-building application. Then, all icons changed to empty box or Chinese character!! 😭
I think some copy process while running ../../node_modules/react-native-vector-icons/fonts.gradle in auto linking doesn't work properly and only manual linking works somehow. But, it works except fontAwsome icons.
My device's resolution is WQHD+(3040 x 1440) and system font is Samsung Sans . My language set is Korean. (I changed system font to default and 나눔바른고딕, nothing was changed.)

@edoko
Thanks for your reply and testing. I already added those two lines in my build.gradle(I double checked that it is android/app/build.gradle) and copied all fonts files in node_modules/react-native-vector-icons/fonts.
Unfortunately, the magic didn't happened to me. I re-inastalled the package and re-linking files, but it doesn't work.

@CXZ7720 Copying font files is a necessary action when manually configuring native settings.
Are you having the same problem if you add the above two lines to android/app/build.gradle
above apply from: "../../node_modules/react-native/react.gradle"?
(When the react-native link command is not executed and the font directory is not copied)
And how are your device's resolution, system font/language set?
I think that I see the two people having problems, it's a problem with Samsung's One UI 3.0.
However, it is difficult to debug because it does not occur on my device with the same One UI 3.0.
I'm sorry for not being able to help you much 😢

Hello again @edoko .
Following your tips, I just removed copy of font files, added only two lines in my build.gradle and then,  re-building application. Then, all icons changed to empty box or Chinese character!! 😭
I think some copy process while running ../../node_modules/react-native-vector-icons/fonts.gradle in auto linking doesn't work properly and only manual linking works somehow. But, it works except fontAwsome icons.
My device's resolution is WQHD+(3040 x 1440) and system font is Samsung Sans . My language set is Korean. (I changed system font to default and 나눔바른고딕, nothing was changed.)

@CXZ7720 Then, when you click the icon with the developer tool, does the font family appear normally?

@CXZ7720 Then, when you click the icon with the developer tool, does the font family appear normally?

@edoko I already have react-native-vector-icons/fonts.gradle in my app/build.gradle file.
The user who reported the issue is using a Samsung Galaxy Note20 Ultra 5G and the device language is English.
Could you test the app on your Note 20 Ultra device if I send you the Google Play Store link via email?

@edoko I already have react-native-vector-icons/fonts.gradle in my app/build.gradle file.
The user who reported the issue is using a Samsung Galaxy Note20 Ultra 5G and the device language is English.
Could you test the app on your Note 20 Ultra device if I send you the Google Play Store link via email?

@edoko I already have react-native-vector-icons/fonts.gradle in my app/build.gradle file.
The user who reported the issue is using a Samsung Galaxy Note20 Ultra 5G and the device language is English.
Could you test the app on your Note 20 Ultra device if I send you the Google Play Store link via email?

Sure! If I can be of your help, I'll be happy to test.
Email is written on my Github Profile,
so please forward it here.
It's too late for now, so I'll test it during the day and leave a comment on the issue.
Thank you

@edoko I already have react-native-vector-icons/fonts.gradle in my app/build.gradle file.
The user who reported the issue is using a Samsung Galaxy Note20 Ultra 5G and the device language is English.
Could you test the app on your Note 20 Ultra device if I send you the Google Play Store link via email?

Sure! If I can be of your help, I'll be happy to test.
Email is written on my Github Profile,
so please forward it here.
It's too late for now, so I'll test it during the day and leave a comment on the issue.
Thank you

@edoko
In developer tool, fonts are loaded successfully. I can find FontAwesome5_Solid in inspector.

@edoko
In developer tool, fonts are loaded successfully. I can find FontAwesome5_Solid in inspector.

@trizin I installed and run your app.
The icons are displayed normally.
I will give you a screenshot of the icon area and software information for the device I am using.!
Screenshot_20210105-064923_Cryptogram.jpg

@trizin I installed and run your app.
The icons are displayed normally.
I will give you a screenshot of the icon area and software information for the device I am using.!
Screenshot_20210105-064923_Cryptogram.jpg

@trizin @CXZ7720
In addition to Samsung One, I changed to Samsung Sans, Nanum Barun Gothic, Bold Font, etc.
I had a problem when I changed the system font.
This is presumed to be a problem occurring in everything other than the default font.

@trizin @CXZ7720
In addition to Samsung One, I changed to Samsung Sans, Nanum Barun Gothic, Bold Font, etc.
I had a problem when I changed the system font.
This is presumed to be a problem occurring in everything other than the default font.

@edoko
Thanks for your test and attention!
I checked that FontAwesome5 icons are loaded very well in Default font.
I agree with your opinion, it seems that there are some problem with rendering icons if system font was changed.

@edoko
Thanks for your test and attention!
I checked that FontAwesome5 icons are loaded very well in Default font.
I agree with your opinion, it seems that there are some problem with rendering icons if system font was changed.

I'm having this issue as well (default system font on Samsung Galaxy S10e)
The issue has persisted with every icon font component I've tried: MaterialCommunityIcons, Ionicons, etc.
Weirdly enough, the "about" icon seems to work, but I couldn't get any others to show anything more than a crossed-out box. The example in the photo is the "home".

I'm having this issue as well (default system font on Samsung Galaxy S10e)
The issue has persisted with every icon font component I've tried: MaterialCommunityIcons, Ionicons, etc.
Weirdly enough, the "about" icon seems to work, but I couldn't get any others to show anything more than a crossed-out box. The example in the photo is the "home".

This problem was due to the firmware of the device, and Samsung replied that it will be resolved through an OS update later.
The attached screenshot is Samsung's response written in Korean.
Thank you.

This problem was due to the firmware of the device, and Samsung replied that it will be resolved through an OS update later.
The attached screenshot is Samsung's response written in Korean.
Thank you.

Still using (for a test device) a Samsung Galaxy S6 from 2015. I have a feeling this firmware update won't be available for my device since I tried to do a system update and it said that the last update (which is the current one) for my device was in 2018.

Still using (for a test device) a Samsung Galaxy S6 from 2015. I have a feeling this firmware update won't be available for my device since I tried to do a system update and it said that the last update (which is the current one) for my device was in 2018.

@KjellConnelly That's pretty weird.
Could you make sure if you have apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" in your app level build.gradle? https://github.com/oblador/react-native-vector-icons/issues/1294#issuecomment-753985142

@KjellConnelly That's pretty weird.
Could you make sure if you have apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" in your app level build.gradle? https://github.com/oblador/react-native-vector-icons/issues/1294#issuecomment-753985142

@trizin Yep. I got that there. I tried the manual way, but there was some sort of conflict saying I was importing the vector-icons module twice (probably some caching issues). Characters on 2 virtual devices (Pixel 3 API 28, and Pixel 4 API 30) have all boxes with X's in them. On the physical device, I'm getting Chinese-ish looking characters with the boxes with X's as well. Just updated to the latest Android Studio version. Using this module via react-native-paper:
package.json
{...
"react": "^17.0.1",
"react-native": "0.63.4",
"react-native-paper": "^4.7.0",
"react-native-svg": "^12.1.0",
"react-native-vector-icons": "^8.0.0"
...}

Works perfectly on iOS.

@trizin Yep. I got that there. I tried the manual way, but there was some sort of conflict saying I was importing the vector-icons module twice (probably some caching issues). Characters on 2 virtual devices (Pixel 3 API 28, and Pixel 4 API 30) have all boxes with X's in them. On the physical device, I'm getting Chinese-ish looking characters with the boxes with X's as well. Just updated to the latest Android Studio version. Using this module via react-native-paper:
package.json
{...
"react": "^17.0.1",
"react-native": "0.63.4",
"react-native-paper": "^4.7.0",
"react-native-svg": "^12.1.0",
"react-native-vector-icons": "^8.0.0"
...}

Works perfectly on iOS.

@trizin Here is an index component that just should show the button with the icon. I'm getting the text for the button, but not the icon via react-native-paper.
// index.js
import React, {Component} from 'react'
import {StyleSheet,View,AppRegistry} from 'react-native'
import {Provider as PaperProvider, Button as PaperButton } from 'react-native-paper'
import Ionicons from 'react-native-vector-icons/Ionicons'

class Index extends Component {
render() {
    return (
      <View style={styles.container}>
        <PaperProvider
          settings={{
            icon: props => <Ionicons {...props} />,
        }}>
          <PaperButton style={{marginTop:40}} icon='add-circle' onPress={()=>console.log('Pressed')}>
            {"Press Me"}
          </PaperButton>

        </PaperProvider>
      </View>
    )
  }
}

const styles = StyleSheet.create({
  container: {
    backgroundColor:'rgb(233,233,233)',
    flex: 1,
    alignSelf:"stretch",
    alignItems: 'center',
  }
})

AppRegistry.registerComponent('MyApp', () => Index)

@trizin Here is an index component that just should show the button with the icon. I'm getting the text for the button, but not the icon via react-native-paper.
// index.js
import React, {Component} from 'react'
import {StyleSheet,View,AppRegistry} from 'react-native'
import {Provider as PaperProvider, Button as PaperButton } from 'react-native-paper'
import Ionicons from 'react-native-vector-icons/Ionicons'

class Index extends Component {
render() {
    return (
      <View style={styles.container}>
        <PaperProvider
          settings={{
            icon: props => <Ionicons {...props} />,
        }}>
          <PaperButton style={{marginTop:40}} icon='add-circle' onPress={()=>console.log('Pressed')}>
            {"Press Me"}
          </PaperButton>

        </PaperProvider>
      </View>
    )
  }
}

const styles = StyleSheet.create({
  container: {
    backgroundColor:'rgb(233,233,233)',
    flex: 1,
    alignSelf:"stretch",
    alignItems: 'center',
  }
})

AppRegistry.registerComponent('MyApp', () => Index)

@KjellConnelly Hey there
The code looks ok.
I've tested it on my Pixel 3 device with react native 0.63.4. At first, the icons seemed like crossed outed boxes. After running react-native link the icons became visible.
Not sure what exactly is causing the problem. You may try running react-native link, checking here again, or create a fresh project and build it up.

@KjellConnelly Hey there
The code looks ok.
I've tested it on my Pixel 3 device with react native 0.63.4. At first, the icons seemed like crossed outed boxes. After running react-native link the icons became visible.
Not sure what exactly is causing the problem. You may try running react-native link, checking here again, or create a fresh project and build it up.

@trizin I thought react-native link wasn't needed anymore after autolinking? I'm not quite sure how this command works vs autolinking, and I don't want it to mess with my other modules I've installed. Do you know why that works for you? I can try tomorrow (not at my computer now).

@trizin I thought react-native link wasn't needed anymore after autolinking? I'm not quite sure how this command works vs autolinking, and I don't want it to mess with my other modules I've installed. Do you know why that works for you? I can try tomorrow (not at my computer now).

@KjellConnelly I guess it's still needed to link assets such as font files. Since this package relies on font files, this works. I don't think that it will mess other modules, anyway, you can take a backup before you try.

@KjellConnelly I guess it's still needed to link assets such as font files. Since this package relies on font files, this works. I don't think that it will mess other modules, anyway, you can take a backup before you try.

@trizin Dang, I tried react-native link and nothing changed. Also tried a few more solutions hoping it would work:
npm uninstall react-native-vector-icons && npm i react-native-vector-icons
react-native link react-native-vector-icons
cd android && ./gradlew clean
npm start -- --reset-cache
Anymore ideas other than this?

@trizin Dang, I tried react-native link and nothing changed. Also tried a few more solutions hoping it would work:
npm uninstall react-native-vector-icons && npm i react-native-vector-icons
react-native link react-native-vector-icons
cd android && ./gradlew clean
npm start -- --reset-cache
Anymore ideas other than this?

@KjellConnelly no ideas :/  perhaps you can create a new react project, make sure that vector icons work, and rebuild your old project there.

@KjellConnelly no ideas :/  perhaps you can create a new react project, make sure that vector icons work, and rebuild your old project there.

We're running into this as well on Android 11 when a font is changed away from default system app (Samsung)

We're running into this as well on Android 11 when a font is changed away from default system app (Samsung)

Some follow up on this issue.
Samsung had deployed an update (AUB2) to Korean Version of S21 Series (S21/S21+/S21Ultra) and this FA5 issue is solved.
It is expected that updates will be provided to other models soon, but the firmware delivery schedule may vary depending on the manufacturer or carrier FW inspection schedule.

any one got an answer for this
i am working on a brand new app brand new install of react native and brand new install of this modual and i am getting a crossed box i have read and tried everything in this post buti am still getting the same issues i am using the android emulator for testing as well as the xoami note 8 pro i am trying to use the ion icon set

Same issue here only in new created project
Device:
Redmi Note 9S
Android: 10
MIUI: 12.0.3
App created on december 2020:
"react-native-elements": "^3.1.0",
"react-native-vector-icons": "^7.1.0",
works well
New project february 2021:
"react-native-elements": "^3.1.0",
"react-native-vector-icons": "^8.0.0",
icons not showing
I thought it was because the version, so I removed react-native-vector-icons 8.0.0 from my project, and added the 7.1.0 version, but it sill not showing, how it can be??

So I'm not really sure when this problem will be fixed, so I decided to create a solution via adding unicode symbols instead of vector icons. I'm also using react-native-paper buttons. If anyone else wants to customize my solution, here it is below... Basically you create a wrapper component instead of importing from react-native-paper. Then you need to customize the icons you want it to ignore, and the unicode you want to replace the icons with. Not all of mine are perfect, but they do the job well enough. Btw, I also am using ionicons. Here is my wrapper component which will use the unicode symbols on android, and the vector icons on ios:
import React from 'react'
import {Button as PaperButton} from 'react-native-paper'

const useIconsOnAndroid = false
const iconsToRemove = [
  'ios-menu',
  'help-circle-outline',
  'help-circle',
  'arrow-back',
  'arrow-forward',
  'ios-add-circle-outline',
  'ios-add-circle',
  'lock-closed',
  'ios-create',
  'ios-arrow-up',
  'ios-arrow-down',
  'ios-save',
  'ios-arrow-forward',
  'ios-star',
  'ios-mail',
  'ios-close-circle',
  'ios-alert',
  'ios-checkmark-circle',
  'close-circle-outline',
  'ios-checkmark-circle-outline',
  'ios-checkmark',
  'return-up-back',
  'ellipsis-horizontal-sharp',
  'ios-thumbs-up',
  'ios-thumbs-down',
  'logo-apple',
  'logo-google',
  'ios-refresh',
  'ios-information-circle-outline',
  'ios-open',
  'ios-send',
  'ios-trash',
  'ios-share',
  'pie-chart',
  'ios-play',
  'ios-folder-open',
  'ios-checkbox-outline',
  'play-skip-forward',
  'ios-body',
  'ios-flame',
  'ios-snow',
  'ios-tv',
  'ios-volume-off',
  'ios-eye',
  'logo-youtube',
  'arrow-up-circle',
  'arrow-down-circle-outline',
  'ios-pause',
  'camera',
  'image',
  'close-outline',
  'md-school',
  'radio-button-off-outline',
  'ios-list',
  'md-camera',

]

export default class PaperButtonWrapper extends React.Component {
  render() {
    let icon = this.props.icon
    let iconText = {
      left:"",
      right:""
    }
    if (!useIconsOnAndroid && Platform.OS == 'android') {
      if (iconsToRemove.includes(icon)) {
        icon={}
      }
      if (this.props.icon == 'arrow-back') {
        iconText.left="❮  "
      } else if ((this.props.icon == 'arrow-forward') || (this.props.icon == 'ios-arrow-forward')) {
        iconText.right="  ❯"
      } else if ((this.props.icon == 'ios-add-circle-outline') || (this.props.icon == 'ios-add-circle')) {
        iconText.left = "⊕  "
      } else if (this.props.icon == 'lock-closed') {
        iconText.left = "🔒  "
      } else if (this.props.icon == 'ios-create') {
        iconText.left = "✎   "
      } else if (this.props.icon == 'ios-arrow-up') {
        iconText.left = "▲  "
      } else if (this.props.icon == 'ios-arrow-down') {
        iconText.left = "▼  "
      } else if (this.props.icon == 'ios-save') {
        iconText.left = "💾  "
      } else if (this.props.icon == 'ios-star') {
        iconText.left = "☆  "
      } else if (this.props.icon == 'ios-mail') {
        iconText.left = "✉  "
      } else if ((this.props.icon == 'ios-close-circle') || (this.props.icon == 'close-circle-outline') || (this.props.icon == 'close-outline')){
        iconText.left = "ⓧ  "
      } else if (this.props.icon == 'ios-alert') {
        iconText.left = "⚠"
      } else if (this.props.icon == 'ios-checkmark-circle') {
        iconText.left = "☑"
      } else if ((this.props.icon == 'help-circle') || (this.props.icon == 'help-circle-outline')){
        iconText.left = "⍰  "
      } else if (this.props.icon == 'ios-menu') {
        iconText.left = "≡  "
      } else if (this.props.icon == 'return-up-back') {
        iconText.left = "↰  "
      } else if (this.props.icon == 'ellipsis-horizontal-sharp') {
        iconText.left = "…  "
      } else if (this.props.icon == 'ios-thumbs-up') {
        iconText.left = "👍  "
      } else if (this.props.icon == 'ios-thumbs-down') {
        iconText.left = "👎  "
      } else if (this.props.icon == 'logo-apple') {
        iconText.left = "  "
      } else if (this.props.icon == 'logo-google') {
        iconText.left = "🇬  "
      } else if (this.props.icon == 'ios-refresh') {
        iconText.left = "⟳  "
      } else if (this.props.icon == 'ios-information-circle-outline') {
        iconText.left = "ⓘ  "
      } else if ((this.props.icon == 'ios-open') || (this.props.icon == 'ios-folder-open')) {
        iconText.left = "📂  "
      } else if (this.props.icon == 'ios-send') {
        iconText.left = "✉  "
      } else if (this.props.icon == 'ios-trash') {
        iconText.left = "🗑  "
      } else if (this.props.icon == 'ios-share') {
        iconText.left = "⠪  "
      } else if (this.props.icon == 'pie-chart') {
        iconText.left = "📈  "
      } else if ((this.props.icon == 'ios-checkmark-circle-outline') || (this.props.icon == 'ios-checkmark') || (this.props.icon == 'ios-checkbox-outline')){
        iconText.left = "☑  "
      } else if (this.props.icon == 'ios-play') {
        iconText.left = "▶  "
      } else if (this.props.icon == 'play-skip-forward') {
        iconText.right = "  ⏭"
      } else if (this.props.icon == 'ios-body') {
        iconText.left = "💪  "
      } else if (this.props.icon == 'ios-flame') {
        iconText.left = "🔥  "
      } else if (this.props.icon == 'ios-snow') {
        iconText.left = "❄  "
      } else if (this.props.icon == 'ios-tv') {
        iconText.left = "📺  "
      } else if (this.props.icon == 'ios-volume-off') {
        iconText.left = "🔇  "
      } else if (this.props.icon == 'ios-eye') {
        iconText.left = "👁  "
      } else if (this.props.icon == 'logo-youtube') {
        iconText.left = "▶  "
      } else if (this.props.icon == 'arrow-up-circle') {
        iconText.left = "⬆  "
      } else if (this.props.icon == 'arrow-down-circle-outline') {
        iconText.left = "⬇  "
      } else if (this.props.icon == 'ios-pause') {
        iconText.left = "⏸  "
      } else if ((this.props.icon == 'camera') || (this.props.icon == 'md-camera')) {
        iconText.left = "📷  "
      } else if (this.props.icon == 'image') {
        iconText.left = "🖼  "
      } else if (this.props.icon == 'md-school') {
        iconText.left = "🏫  "
      } else if (this.props.icon == 'radio-button-off-outline') {
        iconText.left = "☐  "
      } else if (this.props.icon == 'ios-list') {
        iconText.left = "≡  "
      }
    }

    return (
      <PaperButton {...this.props} icon={icon} >
        {iconText.left + (this.props.children || "") + iconText.right}
      </PaperButton>
    )
  }
}

As you can see, I added a boolean near the top of the file to switch back to vectors when I am ready.

Experienced the same issue on a Samsung Galaxy S10 (Android 11/One UI 3.0) with FontAwesome 5 Pro. In my case only the Solid icons were affected, while Regular and Light worked flawlessly.
I imported the Solid style OTF file into FontForge, changed the Weight Class (Element -> Font Info... -> OS/2) to "400 Regular" and exported it as OTF again.* That fixed the issue completely.
*Actually, I didn't try a simple reexport without changing any settings, maybe that would have been sufficient, too.

A user reported this happening to my app today.  He just updated to Android 11. One UI version 3.0 update

I am experiencing the same issue with a Xiaomi Redmi Note 8 Pro device running android 9

Had the same issue here, Android 11, Samsung S10  One UI Version 3.0.
Font changed to 'Samsung Sans' seen to be the problem.
Changed back to 'Default' and all icons are shown properly.

Similar issue for me too when using the android studio emulator Pixel_3a_API_30_x86:
https://stackoverflow.com/questions/63894531/incorrect-icons-showing-in-android-using-react-native-elements

Same issue here, both on Android and iOS

Any alternatives to avoid the issue?

@TeoMM The problem we're all having is on android only to my knowledge. If you're having this issue on iOS, you may be having a different issue.

We still have users experiencing this same issue, with Samsung users who aren't using the default font seeing crossed out boxes and Han characters instead of the correct symbols

I managed to solve my issue by publishing the app through managed workflow(expo publish --target managed).
Can anyone else test that?
Don't forget to use react-native link!

I managed to solve my rectangle/square X box problem by removing metro.config.js as was required by a module (react-native-svg-transformer) that I was using before. I documented it here for the team in case someone there cares to review the instructions for SDK40+.
https://github.com/kristerkari/react-native-svg-transformer/issues/128
If you're using this module, maybe try removing the metro.config.js modifications to see if this fixes you too and move forward as appropriate!

@AtmasApps didn' worked sadly ^^

I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>on 0.64.0 and I have this exact problem. It works fine on iOS but showing as a box with an X on Android. I have tried running react-native link and adding the two lines of code in my app/build.gradle Any ideas on how to fix this?

I managed to solve my rectangle/square X box problem by removing metro.config.js as was required by a module (react-native-svg-transformer) that I was using before. I documented it here for the team in case someone there cares to review the instructions for SDK40+.
kristerkari/react-native-svg-transformer#128
If you're using this module, maybe try removing the metro.config.js modifications to see if this fixes you too and move forward as appropriate!

This worked perfectly, thanks!

I'm closing the issue since it has been resolved with the new One U.I update.

I'm closing the issue since it has been resolved with the new One U.I update.

@trizin what version of One UI did you update to? We're still seeing it on 3.1.

same issue on version 9.1.0.
I use react native 0.68.1 and apply this recommend apply from: "../../node_modules/react-native-vector-icons/fonts.gradle" but still not showing icon.

Me also. Since I am trying but it's not working

Looks like we've run into this issue too 😓. Though it feels like it's something we introduced since it only occurs for our release build (as opposed to our other build variants). On v7.0.0 with RN 0.66.4

Hey there!
I already saw all of your thread talking about the issue, but I keep having it.
I tried modifying both app/build.gradle and app/src/build.gradle but an error appears.
This error is ---> > Task :app:mergeDebugAssets FAILED
Can someone help me?


Location/setup presets that are easily switchable

Primarily streamers but also other players might want to quickly change their Dashboard setup depending on game modes/warmup and other factors. The suggestion is to introduce several configurable preset slots that can be easily switched to (maybe at the press of a button or at least through a few clicks in the UI).
Currently you'd have to manually adjust each window's position, which is not consistent and can be time-consuming if you need precise layouts.
Background
Especially for streamers it's important Openplanet doesn't get hidden by their own stream overlays/cameras, so being able to set up two or three different presets ahead of time would make it very easy to prepare layouts that they can just switch to as needed.
Implementation suggestions
If Dashboard is able to serialize all the settings to export them, it could maybe use the same mechanism to save/load presets internally for easy switching. Somewhat related: https://github.com/codecat/tm-dashboard/issues/22

I'm currently working on a project to serialize settings to binary and the return a base64 string. Once I had something working I was planning propose it as an addition here or possibly as a standalone plugin

There is this plugin now. However I still think some "default presets" could be nice to have. Or perhaps new defaults for first-time users.


[CET-8100] [Peloton] Backstage plugin rendering Markdown as plain text

Change description
TODO: bump version before merge
[CET-8100] [Peloton] Backstage plugin rendering Markdown as plain text
Screenshots
Before:

After:

Type of change

[x] Bug fix (fixes an issue)
[ ] New feature (adds functionality)
[ ] Improvement (improves codebase without changing functionality)

Checklists
Development

[x] The changelog has been updated as appropriate
[x] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

What if markdown text is long? Can we apply some max-line constraint or something like that?

Ah I approved before seeing Igor's PR. I didn't notice us truncating anywhere else in the codebase so I assumed it wouldn't be an issue, but I don't see an option for truncating in their component itself... 🤔
Storybook, for reference

@FoodProduct There's one place in the Scorecard card in the list (src/components/ListCard/ListCard.tsx). But there's now multiple places where this description is not truncated (like the scorecard detail and scorecard entity detail)

ListCard/ListCard.tsx)

Ah it's a simple text-length truncation (which isn't great but sorta works). Probably worth creating a component out of that pattern.

@FoodProduct planned to create some component for that. I'll try to create line based trincate if possible.

Yeah I recommend taking a stab at height-based truncation but if it's a PITA then char-based can suffice for a quick fix.

I did some tests, looks fine for me: 👍


Remove duplicated line in OpenMetadata-service pom.xml

Remove duplicated line in OpenMetadata-service pom.xml.<sonar.tests>${project.basedir}/src/test/java</sonar.tests>

Describe your changes:
Fixes

I worked on ... because ...

Type of change:

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Thanks for the fix @EsmaeilChitgar


Create blob transfer manager

Create a transfer manager for blob storage. This includes significant architecture work to determine what functionality needs to be provided.

Stories we can break this Epic into on a high level:

[ ] Determine the range of the operations TransferManager will support: track transfer progress, pause transfer, resume transfer, cancel transfer, etc.
[ ] Define how TransferManager will interface with the Storage Blob APIs.
[ ] Define if TransferManager will be responsible of some retrying/autorization tasks and how much, e.g. refreshing a SAS token once it has expired if a transfer is not complete and retrying/resuming the operation.
[ ] Come up with public API proposal
[ ] Implement proposed API including underlying private and protected models and classes
[ ] Create unit and integration tests

Updated description and expanded upon some of the tasks, thanks!


Use proper content scripts

In an effort to help get firefox a working plugin again, I took a stab at resolving some of the "injecting 3rd party libraries" problems.
I removed the content scope runner hack, but content scripts run in a sandbox so I also had to add some dependencies as part of the extension:

jQuery 1.4.4 - Using an old version since drupal.org uses it and I don't want to break anything
jQuery.once.js
Drupal.js - Needs the Drupal global object and the attachBehaviors function. This is a temporary stop gap until it can be refactored in #155

I was able to build extensions for Firefox, Chrome and Safari. I tested them very minimally but it appears to be working correctly.
I think the check on https://dreditor.org/ to see if the extension is installed already or not is broken now though. I verified that the

 element gets added but the button still says it's not installed.
This would fix #215 and #156.

This is a good start, for sure. Thanks!!
My only hesitation is the comment @sun made here https://github.com/unicorn-fail/dreditor/issues/155#issuecomment-44039906
The reason we're currently using Drupal.behaviors is because it's actually tying into's d.o's native Drupal.behaviors system (because the script was actually injected into d.o's DOM and was allowed to interactive with d.o's JS.
I'm not sure if we actually need that or not (my memory on the existing plugins is absent ATM since I haven't worked on the code in a while). If not... we might as well create a proper Dreditor namespace with event handling (#155) with this PR too.
I know that extensions are sandboxed, but this issue about "injecting 3rd party libraries" doesn't mean we cannot still inject something into the DOM (which is allowed). The reason why the current content script injection is a hack is because it's dumping the entire extension script into the DOM (which is generally frowned upon, especially by a.m.o).
If we do need Drupal.behaviors, then we can still inject a small script that only binds to Drupal.behaviors and then triggers a custom event to the sandboxed extension script. This allows us to control exactly what's happening and "convert" it to whatever Dreditor namespaced event API that's created.
See: http://stackoverflow.com/questions/21731635

I agree with all that. Copying Drupal.behaviors was the smallest/quickest change to get it working again.
I'm even less familiar with the plugins than you. I could "fix" the Drupal.behaviors so that it's functionally the same (reloading on ajax, etc) and ties in with d.o. That wouldn't require intimate knowledge of everything, puts stuff back in a working state, and is one step closer to a firefox release. But it's not the ideal code.
Or skip all that and go for #155. I don't know what a new plugin API looks like, or how long it'd take to refactor everything.
If the first option is acceptable, that's something I could do.

I'd rather not "copy" any portion of drupal.js into Dreditor (even if it's for a temporary workaround). It just leads to additional technical debt and ultimately doesn't really solve the problem mentioned above about tying into d.o's behavior events.

In all reality this PR kind of has to work in tandem with #155 or, essentially, replace it trying to achieve the same goal. I don't think doing one before the other in separate PRs will work. We have to keep the code fully functional in case a release needs to be made. Any PR regarding this stuff will, unfortunately, likely be a massive rewrite.

I can confirm that the plugins rely on at least one part of Drupal.behaviors, and that's rerunning them when some content has been changed via AJAX. The easiest way to test is to change the project on an issue and it will reload the entire new comment section. Many of the plugins (patch.name.suggestion, form.sticky, issue.summary.template) need to be rerun to work correctly.
The docs for all three browsers said to use the postMessage() API to communicate between the content script and the page. I created a small library that injects a script and sends a message back to dreditor when Drupal.attachBehaviors() gets called. Then I was able to rerun the plugins.
Again, I did the smallest change to get re-running plugins, which was keeping the copied Drupal behaviors. But this is a lot closer to being functionally equivalent to the old content scope runner method.

I followed the observer pattern to create a small plugin manager. I also converted one plugin as an example.
All plugins register themselves, so the execution order can be set alphabetically the way it is now, or a new file just for registrations can be used to set the order.
The notify() functionality makes it easy to add new plugin calls as they're needed, but if a rigid API is preferable it can be changed after all the plugins get converted (since right now, I'm not sure the init/bind is enough).
If this is the right track, I can convert all the plugins and remove the Drupal.* namespace (I don't think there's a need to switch to Dreditor.* since content scrips are sandboxed).

I will have to take a look at this next weekend (swamped with client work right now).

Cool, thanks for being responsive

Performance regression on long issues (this one has 119 comments https://www.drupal.org/node/2301317), this is just a reminder for me.

I'm still interested in continuing, if I'm on the right track.

Yes, the comments above need to be addressed.
Also, is it possible for you to [re-]base this off of the newly created 2.x branch?

Rebased on 2.x over at https://github.com/unicorn-fail/dreditor/pull/287


How to update an existing project ?

I runned npm update and after your refactoring with ES6 the app crash.
╰─$ node app.js                                                                                1 ↵
/Users/thibz/Documents/github/dashboard/node_modules/mozaik/src/Mozaik.js:6
class Mozaik {
^^^^^
SyntaxError: Unexpected reserved word
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/thibz/Documents/github/dashboard/app.js:1:81)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

Is there a recommended way to update mozaik for an existing project ?

@tlenclos you should take your actual config and move it to an updated demo repo clone or use the yeoman generator. I hope it'll solve your problem, let me know if it doesn't.

@tlenclos did it worked ?

Partially, there is some custom widgets that are broken but I just changed theses files from the mozaik-demo repository and it works.
app.js
src/App.jsx
package.json


Autogen clients deprecation (rebased onto dev_5_0)

This is the same as gh-1098 but rebased onto dev_5_0.

In preparation of the deprecation of the OMERO.clients bundle on 5.1.0, this PR removes their need for the auto-generated documentation. Instead, it uses the --java-help option of the CLI import plugin which dumps the content of importer-cli.
To test this PR, check the outcome of the the auto-generated importer help is the same with and without this PR (e.g. by comparing the develop/latest/autogen and develop/merge/autogen branches of https://github.com/snoopycrimecop/ome-documentation).
--no-rebase

--rebased-from #1098

Motivated by https://github.com/ome/omego/pull/63 to prevent auto-generation errors if we need to release 5.0.9.

See https://ci.openmicroscopy.org/job/OMERO-5.0-merge-docs-autogen/151/ (modified configuration to use the server exclusively)

:+1:


Pikmin stuck on Assurance"s

Hope this image embed works. But, if you go on assurance's fire exit, get some pikmin to carry things back to the ship, they try to go through the pipes, and are stuck forever.
I suppose I could whistle them but my workaround is to get every item down and then get the pikmin to carry stuff. I would prefer getting them to carry things from the fire exit door directly, as to not lose time.

I've seen this issue before and It has to do with Assureance's NavMeshes not having a way for entities to get down from it. There might be a way for me to fix this but I'm going to put it on the back burner for now


certificate files

I'm trying to get certs installed via ignition and this provider, since the regular ignition provider doesn't support etcd configs.
However, when I try and template the multiline certificates,they don't render appropriately.
Anyone have a suggestion for how to get those done? I can use the templating to create the files with certificates in the core ignition, but not sure how to create those contents via the yaml config....

figured out one really hacky way, which is to preserve the spaces inthe tfvars file using heredocs.
Ew.

You may find this related multiline example useful. Template those contents in with Terraform's template_file, before passing the content as a ct_config.

https://github.com/poseidon/typhoon/blob/master/aws/container-linux/kubernetes/cl/controller.yaml.tmpl#L118
https://github.com/poseidon/typhoon/blob/master/aws/container-linux/kubernetes/controllers.tf#L59

Oh, interesting. Perfect. Thanks!


Kapacitor post event handler alert templating with skipSSLVerify

it is impossible to have both alert templating and skipSSLVerify when using post
The alert template can be defined only as part of the config file that does not accept the option skipSSLVerify as part of the endpoint configuration
and when trying to define the endpoint inline inside the post or the handler you cannot provide alert template configuration

@dima100 thanks for the issue. Could you share your configuration so that we can better understand what you are trying to accomplish here?

i want to use post() in my tick script
as in
.....
|alert()
.id('{{ .Name }}:{{ .Group }}')
.crit(crit)
.message(message)
.post()
.endpoint('pt_connector')
the endpoint 'pt_connector' defined in the kapacitor conf file where i cannot  set skipSSLVerify
as an alternative i can do inline post() or via event handler
stream
|from()
.measurement('cpu')
|alert()
.crit(lambda: "usage_idle" < 10)
.message('Hey, check your CPU')
.post('https://example.com/path')
.header('Example1', 'example1')
.captureResponse()
.timeout(10s)
.skipSSLVerification()
but in this case i cannot specify alert template as i do in conf file
[[httppost]]
endpoint = "example"
url = "http://example.com/path"
alert-template = "{{.Message}}:{{range .Data.Series}}{{.Tags}},{{range .Values}}{{.}}{{end}}{{end}}"
i want to have both alert template and skipSSLverify

I am in exactly the same position and just about to embark on replacing a legacy monitoring stack with TICK, this is not great. I don't understand why the skipSSLVerification option wasn't incorporated into the endpoint config at the same time as the inline option was implemented.
I don't want to have to update 500 scripts/tasks when an endpoint changes.


Add Escape Char for Special Char(s)

I added escapedId in the query to replace only the ' character. I’m not sure if there are any other special characters, but this fixed issue #10.
I also added GetData("client_Browser"); to the ErrorItem because, in some Android versions, OperatingSystemVersion does not contain the value, but client_Browser does.
Let me know if you need further revisions!

How does client_browser data look for you? I can see "Android 14" for example. To make the data the same as OperatingSystemVersion it should return only "14". What do you think about splitting it?
Do you have an idea why OperatingSystemVersion is empty?
It is added like this in the library:
 client.Context.GlobalProperties.TryAdd("OperatingSystemVersion", DeviceInfo.VersionString);

I have no idea why it is happening but I will check it up on the client library and let you know.

If you can update it to just get "14" of "Android 14" it is good. If we have the data even if it is in another property it is good. But I prefer to have it in the same format. I guess it can be solved with a split and double.TryParse or similar.
I also like the escape thing.

@se @dhindrik any chance for the escape fix being merged first and the OperatingSystemVersion being look at separately?
Also running into the escape issue looking at a crash report

I fixed it now. Thank you @se for your contribution.


Update tokens

Update of tokens; I seem to have messed up the default file in the previous export.

Closed for a more recent version


Fix modal size

Assigned you @Nikomus as I assume you meant to take this on, or close it. I'm not sure what it means.

@katjam I've only seen this on your screen in meetings - not sure how to replicate it.

Let's close it then,


Link directive

We need a link directive.
eg:
#link "m"
#link "curses"

Remember to label your issues...

yeah yeah

Looks good, syntax looks good yadayada go for it

I've partially implemented the ast node for this so far, haven't gotten around to parsing it.

Cool, I imagine we could use this syntax for something else too?

Yes.
For #link, there is something important to note:
When creating the linker command, the linked libraries for each module must be passed before each module. This means that if two modules link against two different libraries each with a function with the same signature, each module will link against the right function.
eg: cc -lm thing.s -lother_m stuff.s, as opposed to cc -lm -lother_m thing.s stuff.s. The first example gives the right behaviour.

@ark-lang/owners
Thinking about it, we should probably think of other use cases for a directive to implement, otherwise we're introducing this feature just for the "link" directive, and future directives that we have no idea about. So it may be better off revising how we link things, i.e. a flag for it?

Come to think of it, we could probably use it for loading modules too instead of the UseDecl?
#use module_name, or #use "module_name"?


Can't get more FPS

Do you know why i can't get more then 80/90 fps? i'm running the game in 4k
my specs are RTX 4080, 48GB Ram 3000mhz, i7-10700k. Nothing is fully utilized... not even a single core

Maybe it's just the game? because when i used to play in 1080p i was able to get 120fps with 2080 super.

Genshin Impact is a game demanding a powerful CPU. I replaced my 10700K with 13600K, resulting in a big improvement in FPS.

but it doesn't make much sense since is not fully utilizing the CPU or a single core.. my assumption is that this is a limition of DIrectx 11 which has a limited amount of draw calls available compared to Directx 12....

No, actually it is because the trash optimization of Genshin Impact which cannot utilize multicore of CPU.

0

yeah but what you says doesn't make much sense considering that not a single one of my cores is fully utilized.. as i said i suspect is limited by the draw calls

There's also Core parking, have you unparked your cores yet?
Update Motherboard Bios
Overclock CPU/Undervolt CPU
Overclock Graphics Card/Undervolt Graphics Card
Enable XMP/Expo
Debloat Windows (TechYesCity has a good tutorial for 2023)

Genshin Impact is a game demanding a powerful CPU. I replaced my 10700K with 13600K, resulting in a big improvement in FPS. If you want to run smoothly, I suggest you replace your CPU with Intel 13th or wait for the 14th. (I am not from the marketing team of Intel)

I've been looking at the 7800X3D it seems like the best option atm since Intel is going to change platforms soon and it's specifically designed for games, yet Genshin we don't know what runs better because nobody benchmarks it (because they'd have to use this mod to do so).

With a 9700k at 4.9Ghz, 3200Mhz Ram and a 4090 with a +200 Core + 1000 Memory OC I get 100-120 @4k.
I have Afterburner up to maintain OC on graphics and I'm using Resolution timer .5 not sure how much that changes things.

I have a 11700F(all core 4.4)/3080 10gb/4x8 3200 cl16/game installed on gen 4 nvme/ I play Genshin maxed @1440p and 720p and I know in Sumeru both that stairs area at the adventurers guild and at the crafting bench a little further ahead drop the fps for me to even like 80s, gpu usage around 55% and rivatuner OSD showing my highest cpu core in high 80s, maybe a mix of cpu bottleneck and some other limitation.
I believe the cpu usage shown is overall though as if im doing something else to max my cpu out while playing the osd will show all my cores at about 98-100% so maybe some areas have some other limitation/bad optimization.

Inside the water in Fontaine I've had no issues also the fps is smooth in the main city.

you need a better cpu with more power.

0

yeah but what you says doesn't make much sense considering that not a single one of my cores is fully utilized.. as i said i suspect is limited by the draw calls

None of my core are being maxed either playing on 5800x3d but I got 120+ FPS in the same area. Just because you slot on a more powerful GPU doesn't mean the game can utilise it properly hence the lower usage. You can see this kind of behaviour on game with heavy ray tracing being run on AMD GPU. It will show low GPU usage but it is being maxed out, just in a way that isn't utilizing every part of the GPU(RT core obviously arnt being use here on genshin)

I upgraded to a 7800X3D and most of the places in the game give a solid 200 fps, I have a 4090 and it used to be 120-140 Max and it was heavily dependent on direction.

I upgraded to a 7800X3D and most of the places in the game give a solid 200 fps, I have a 4090 and it used to be 120-140 Max and it was heavily dependent on direction.

What other specs do you have? I have a 3080 with a 5900x and mainly play only genshin right now and I only get 125 in abyss and etc.

I upgraded to a 7800X3D and most of the places in the game give a solid 200 fps, I have a 4090 and it used to be 120-140 Max and it was heavily dependent on direction.

What other specs do you have? I have a 3080 with a 5900x and mainly play only genshin right now and I only get 125 in abyss and etc.

4k and I use MIGOTO with Nvidia Freestyle Filters, I get 290fps in Abyss. Although I was getting low fps with a bad CPU, it's now good with the CPU upgrade.

I upgraded to a 7800X3D and most of the places in the game give a solid 200 fps, I have a 4090 and it used to be 120-140 Max and it was heavily dependent on direction.

What other specs do you have? I have a 3080 with a 5900x and mainly play only genshin right now and I only get 125 in abyss and etc.

4k and I use MIGOTO with Nvidia Freestyle Filters, I get 290fps in Abyss. Although I was getting low fps with a bad CPU, it's now good with the CPU upgrade.

Thanks for the reply! I'll probably upgrade too then, I play in 1440 and I feel like my fps is so low


Cow: Watch activeavenues.com

Cow requests the watch of the watch_keyword activeavenues\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

activeavenues\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Ollie in Charcoal HQ


Unhandled GraphQL subscription error Error: Error during subscription handshake

Hi folks!
Just trying this project out for the first time and running it in localhost and i get this error:
index.js:1446 Unhandled GraphQL subscription error Error: Error during subscription handshake
    at new ApolloError (ApolloError.js:58)
    at subscription-handshake-link.js:288
    at new Subscription (Observable.js:212)
    at Observable.subscribe (Observable.js:290)

Not sure what the actual real cause of the error is, but figured I would report it.
I debugged and logged out the operation in question:

Update - when i created a second account - the app was usable (the accounts can chat with each other), but the error still occurs.


[auto continue as new ] also need to check the signal processing is done in a different thread

https://github.com/indeedeng/iwf/blob/374d02f5635bf951c7a71cae2968f83a1593b5e8/service/interpreter/signalReceiver.go#L101
This will only work for current thread. The skip timer is applied in a different thread (exec state) and fail wf is executed in main thread. Need to wait for them as well.
In case fail wf signal , then no continue as new is needed.
In case of skip timer, wait for the waitTimer method is done for the timer
using thread count for safety check for all threads. Add warning for stuck ?

https://github.com/indeedeng/iwf/pull/224


Typing Speed Calculator

Description 📜
Added Typing Speed Calculator
Fixes #1339

Type of change 📝
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Add a new project
[x] Modified or enhanced the existing projects

Domain of Contribution 📊
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸

https://user-images.githubusercontent.com/82721772/167334009-b3f1070a-24e3-45bf-a055-4b405ba5653e.mp4

@gurjeetsinghvirdee Done


Replace truetime with networktime

Doesn't lend itself to much of a split I'm afraid.

I see that it's a draft but when it will be ready for review could you please elaborate a bit more about this change? I see some changes to the event producer and I don’t know where it came from.

I see that it's a draft but when it will be ready for review could you please elaborate a bit more about this change? I see some changes to the event producer and I don’t know where it came from.

You may consider this ready for code review now. The reason it's a draft is to prevent it from being merged before we've released dropping MQA, but no code changes are planned.
The changes you see in EventProducer are replacing truetime with networktime. The sleep block is to ensure initialization of the time before it gets queried. TrueTime also had this issue (it's more of a design thing really), which caused crashes. What I've done is prevent queries until they're not null in all sdks to avoid the problem, so you can see the same in Player, which makes us no longer need the custom application class that we used to get around the problem when we used truetime. This guarantees that even if an app uses either Player or EventProducer directly without having done the fencing themselves, we are not an issue for them. So there should be nothing to worry about when it comes to that.


v0.9.0 Regression test checklist

[x] Polkadot JS test

[x] we can send transaction and status is updated
[x] Explorer shows correct information about best and finalized blocks

[x] Sync using fast sync and common sync

[x] Fast sync from some existing snapshot works (snapshots available here)
[x] Sync by smoldot works

[ ] Pruning

[ ] Offline pruning
[ ] Dynamic pruning

[ ] Consensus

[ ] KAGOME-KAGOME
[x] Substrate supermajority
[x] KAGOME supermajority substrate minority
[ ] possible to do in one run

[x] if node is shutdown and recovered it can run
[x] Parachains

[x] adding new parachain to network with KAGOME
[x] network is healthy: blocks are being produced every 6 seconds and gap between best and finalized blocks is not larger than 5 blocks during entire period of running network
[x] parachains runtime is updated and KAGOME handles it with not issues

Other tasks that should resolved before release:

[ ] Make sure when KAGOME is added as validator it won't not slashed for unresponsiveness
[ ] Stopping KAGOME with Ctrl+C does not corrupt database
[ ] Readme is up to date

It would also be good to check that the documentation does not become obsolete.

Not new known issues
Known issues(need to compare substrate validator vs kagome validator using Polkadot JS): Explorer(recent blocks), Era/epoch(+best/finalized in this case), Staking (next session, wait validator's list) - commonly found in the network of kagome validators


webpack 2 support?

I gave webpack 2 a try and things exploded... didn't work :(
Does this support webpack 2?

Of course.
Be more specific
On Friday, May 6, 2016, Mohamed El Mahallawy<EMAIL_ADDRESS>wrote:

I gave webpack 2 a try and things exploded... didn't work :(
Does this support webpack 2?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/halt-hammerzeit/webpack-isomorphic-tools/issues/75

I am getting style errors where css-modules is not working on the server. It is not loading the stylesheet.

Being specific assumes the corresponding logs at least.

FYI
I'm posting this in every issue and PR to notify whoever may be interested:
today I've released an alternative helper library called universal-webpack.
It takes a different approach than webpack-ismorphic-tools and instead of hacking Node.js require() calls it just compiles all code with target: 'node' webpack configuration option.
As a result, all Webpack plugins and features are supported.
If you think you might need that here's an example project:
https://github.com/halt-hammerzeit/webpack-react-redux-isomorphic-render-example

@halt-hammerzeit this is awesome! I am excited to give it a try very soon!


Update Article “astral-realm”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
7178193fbe2ab57436128886b98a65cdc403deea

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/633452ea6860a80009d350a5


--resume decreases training speed by 4-10x

Reliably goes from 10s/it when training to 40s-100s/it on this configuration, and if I remember correctly it was even adding over 200s/it on others.
I'm spilling over into shared vram a lot, so I'm guessing this is because it's holding on to the previous state in memory after load. Literally the only parameter changed is ''--resume".
accelerate launch  --mixed_precision bf16 --num_cpu_threads_per_process 1 flux_train_network.py --pretrained_model_name_or_path "consolidated_s6700.safetensors" --clip_l "clip_l.safetensors" --t5xxl "t5xxl_fp16.safetensors" --ae "ae.safetensors" --cache_latents_to_disk --save_model_as safetensors --sdpa --persistent_data_loader_workers --max_data_loader_n_workers 2 --seed 42 --gradient_checkpointing --mixed_precision bf16 --save_precision bf16 --network_module networks.lora_flux --network_dim 16 --optimizer_type bitsandbytes.optim.AdEMAMix8bit --learning_rate 1e-4 --fp8_base --max_train_epochs 400 --save_every_n_epochs 1 --model.toml --output_dir outputs --output_name model --timestep_sampling shift --discrete_flow_shift 3.1582 --model_prediction_type raw --guidance_scale 1.0 --resume "outputs/model-000001-state" --save_state --network_args "loraplus_unet_lr_ratio=4" "train_t5xxl=True" "split_qkv=True"

If this is fixed I'll close #1700 since I'm able to train for a while before OOM, and whatever the recent memory changes are have increased my regular speed from ~70s/it to ~10s/it so if I can resume after crash, it works out faster anyway

I think I'm encountering the same issue with a different optimizer (schedulefree): training works fine initially, but resuming an existing run uses just enough extra memory to cause OOM during sample generation. Sounds like a memory leak involving the resume state

Maybe Accelerate's resuming or the optimizer's load_state doesn't fully restore the optimizer state.

"Not restoring the optimizer state" does sound a lot like what's happening. I trained 8 epochs at 10s/it and resumed up to 17 epochs at ~40s/it, resumed from 17 to 24 and it shot down to ~21s/it, then resumed from 24 and it went back down to ~10s/it.
But the weirdest part is when I resumed at 8, it said I was at epoch 0, then after 1 iteration jumped up to 9 and continued as normal. When I resumed at 17, it said epoch 7 (..or 9 i forget, def one of those), then at 24 It said I was at 17.
At 24 it's now saying "epoch is incremented. current_epoch: 0, epoch: 9". When it's loading the training state it does say "train_state.json: {'current_epoch': 24, 'current_step': 2608}", but then it says 9 after and starts at 0/127792. There are 130400 steps in total and 326 steps / epoch, so<PHONE_NUMBER>92/326=8 epochs.
Is this expected behaviour? Is the step count just an arbitrary number after resuming or is it actually starting again at an earlier epoch, possibly retraining over the same weights? Cos that would explain some of the outputs I'm getting.


How to Apply N level child?

Any one know to how achieve below scenario, Feature 1 & 2 will auto generate with defined User Story
EPIC
- Feature 1
- User Story 1
- User Story 2
- Feature 2
- User Story 3
- User Story 4

I think you'd need to do that as a 2 step process. Trigger the extension on the Epic to create the two features and then highlight both of the new Features and trigger it again to create their user stories.


Update azure.md

Description
Fixed wrong configuration example for azure OpenAI. If you set the  "apiType": "openai" then the URL is not correct prepared and you are not able to use Azure OpenAI endpoint.
Checklist

[X] The base branch of this PR is dev, rather than main
[X] The relevant docs, if any, have been updated or created

Screenshots
[ For visual changes, include screenshots. ]
N/A
Testing
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change. ]
N/A - not needed as this is just a config flag in the docs.

Thanks for the catch here @immae1 !


Make mark/unmark/cancel take in only 1 index using the appointment list

Closes #116, Closes #117
Before
mark 2 1 -> Select the 1st appointment from the 2nd person in the person list.
After
mark 5 -> Select the 5rd appointment in the appointment list.
Notes

Edit user guide as well
Change createEditedPerson method in EditPatientCommand to public.
Might want to pay extra attention to my implementation of CancelCommand::execute() method when reviewing; There may be more efficient implementations.

Codecov Report

Merging #118 (1ede0b5) into master (c8dd3b5) will decrease coverage by 0.05%.
The diff coverage is 72.88%.

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
- Coverage     76.50%   76.44%   -0.06%
+ Complexity      661      657       -4
============================================
  Files            92       92
  Lines          2000     1991       -9
  Branches        245      240       -5
============================================
- Hits           1530     1522       -8
- Misses          384      390       +6
+ Partials         86       79       -7

Impacted Files
Coverage Δ

...edu/address/logic/commands/EditPatientCommand.java
93.05% <ø> (ø)

...n/java/seedu/address/model/person/Appointment.java
91.58% <ø> (-1.87%)
:arrow_down:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
81.42% <8.33%> (-9.05%)
:arrow_down:

...eedu/address/logic/parser/CancelCommandParser.java
75.00% <66.66%> (-2.78%)
:arrow_down:

...dress/logic/commands/SelectAppointmentCommand.java
68.42% <85.71%> (-9.36%)
:arrow_down:

...address/logic/commands/EditAppointmentCommand.java
69.49% <87.50%> (+2.82%)
:arrow_up:

...va/seedu/address/logic/commands/CancelCommand.java
77.77% <100.00%> (+16.90%)
:arrow_up:

...java/seedu/address/logic/commands/MarkCommand.java
86.20% <100.00%> (+3.44%)
:arrow_up:

...va/seedu/address/logic/commands/UnmarkCommand.java
73.33% <100.00%> (+6.66%)
:arrow_up:

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Shadow / dark area across terrain when using Lumen and UE5

Overview

UE Version: 5.0.0-16433597+++UE5+Release-5.0-EarlyAccess
While experimenting with Cesium in UE5 I noticed that a shadow / dark area appears on the terrain when using Lumen
This shadow doesn't appear when Lumen is disabled (which is default when opening the Cesium examples project in UE5)
The dark area is most obvious when zoomed out and when the lighting is set to dawn / dusk
The dark area is aligned with and rotates with the camera
One setting I've found that impacts the dark area is disabling Real Time Capture on the SkyLight inside CesiumSunSky
Disabling Real Time Capture on the SkyLight seems to make the bottom (previously lighter) part of the image the same darkness as the top area
Alternatively, setting the SkyLight to Static seems to remove the dark area but I think this also removes the Real Time Capture goodness
I'm new to UE so unsure what to try for further debugging

Global illumination method set to Lumen

Global illumination method set to None

Lumen enabled but Real Time Capture disabled on SkyLight

Steps to reproduce

Build Cesium plugin for UE5
Open UE5 and load Cesium For Unreal Examples project
UE5 will ask to copy project or open in place, select copy
UE5 will ask to disable Cesium as it cannot be found, say no and exit
Copy built files for Cesium UE5 plugin and paste within a Plugins direction inside the copied example project directory
Open the project in UE5 and it should recognise Cesium and load the scene without issue
Change Solar Time to 10.0 (shadow is more obvious at dawn / dusk)
Notice everything looks OK so far
Open Project Settings and look for Dymanic Global Illumination Method
Set the method to Lumen
UE5 will ask to enable some other stuff automatically
Restart UE5 and open project
Check Lumen is selected in Dymanic Global Illumination Method
Zoom out and you should see the shadow / dark area on the terrain
Set Dymanic Global Illumination Method to None again and notice shadow disappears

I just confirmed that this still happens in the final release of UE 5.0. It also happens with the stock Unreal "SunSky", so it isn't something we're doing wrong in the CesiumSunSky. It may just be a limitation of Lumen with the huge view distances, or perhaps there's some setting that can be tweaked, but I don't know enough about Lumen to say. As far as I can tell it's not something we can fix in the plugin, though. Best thing to do is probably raise it on UDN or the Unreal forum.

Here is my workaround: I have an unbound post-process volume in my scene that disable Lumen. This post-process volume is enabled when some conditions are met, ie. when the camera reach a certain altitude from the ground and when the sun is below a certain angle. Otherwise the issue is not much visible.


id.startsWith is not a function error with vite-ssg build

I have been running into this issue while trying to setup vite-ssg with vite-plugin-vue-layouts. I have setup every according to the vite-ssg spec to use with the layouts and pages plugins but have been unable to get a build to work. I am able to run fine in dev but haven't been able to build for production.
vite-plugin-vue-layouts version: 0.6.0
Error on vite-ssg build

// app.js
import generatedRoutes from 'virtual:generated-pages'
import { setupLayouts } from 'virtual:generated-layouts'
import { ViteSSG } from 'vite-ssg'
import App from './App.vue'

const routes = setupLayouts(generatedRoutes)

export const createApp = ViteSSG(
  // the root component
  App,
  // vue-router options
  { routes },
  // function to have custom setups
  () => {
    // install plugins etc.
  }
)

Any help with this would be much appreciated.

I actually figured out the issue, it was related to a build option I had configured in my vite.config.js


Modified Dashboard Dropwizard configuration in order to use just one port

@rosogon could you review it?

Just to know, why do you want to change this?

I think it's better to reduce the port usage to avoid collisions.

+1. Merging


Expecting Object (while executing) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:320)

My Environment

ArangoDB Version:        3.7.8
Storage Engine:             RocksDB
Deployment Mode:       Single Server
Deployment Strategy:   Manual Start in Docker
Configuration:               N/A
Infrastructure:               own
Operating System:        RHEL 7.9
Total RAM in your machine:        16GB
Disks in use:        SAN
Used Package:              Docker - official Docker library

Component, Query & Data
Affected feature:
AQL query using web interface & arangosh
AQL query (if applicable):
LET Assignment = (
FOR st IN PM_special_teams
	FILTER st.assignment_type == "vuln_title_lowpriority"
	AND st.cve_criteria != NULL
		RETURN {
		    "team_assignment": st.team_assignment,
		    "cve_criteria": st.cve_criteria,
		    "prime_contact": st.prime_contact,
		    "comment": st.comment
		}
)
FOR st IN Assignment
    FOR vuln IN PM_vulnerabilities
        FILTER REGEX_TEST(vuln.title, st.cve_criteria, true)
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

AQL explain and/or profile (if applicable):
Profile
Query String (659 chars, cacheable: false):
 LET Assignment = (
 FOR st IN PM_special_teams
 	FILTER st.assignment_type == "vuln_title_lowpriority"
 	AND st.cve_criteria != NULL
 		RETURN {
 		    "team_assignment": st.team_assignment,
 		    "cve_criteria": st.cve_criteria,
 		    "prime_contact": st.prime_contact,
 		    "comment": st.comment
 		}
 )
 FOR st IN Assignment
     FOR vuln IN PM_vulnerabilities
         FILTER REGEX_TEST(vuln.title, st.cve_criteria, true)
             UPDATE vuln WITH {
                 "special_team_title": st.team_assignment,
                 "prime_contact": st.prime_contact,
                 "comment": st.comment
             } IN PM_vulnerabilities

Execution plan:
 Id   NodeType                       Est.   Comment
  1   SingletonNode                     1   * ROOT
 15   IndexNode                      1021     - FOR #18 IN PM_special_teams   /* hash index scan, projections: `comment`, `prime_contact`, `cve_criteria`, `team_assignment` */    FILTER (#18.`cve_criteria` != null)   /* early pruning */
 13   CalculationNode                1021       - LET #14 = { "special_team_title" : #18.`team_assignment`, "prime_contact" : #18.`prime_contact`, "comment" : #18.`comment` }   /* simple expression */
 10   EnumerateCollectionNode   183804504       - FOR vuln IN PM_vulnerabilities   /* full collection scan, projections: `_key`, `title` */
 11   CalculationNode           183804504         - LET #12 = REGEX_TEST(vuln.`title`, #18.`cve_criteria`, true)   /* simple expression */   /* collections used: vuln : PM_vulnerabilities */
 12   FilterNode                183804504         - FILTER #12
 14   UpdateNode                        0         - UPDATE vuln WITH #14 IN PM_vulnerabilities

Indexes used:
 By   Name              Type      Collection           Unique   Sparse   Selectivity   Fields                                                     Ranges
 15   idx_12910479509   hash      PM_special_teams     false    false        98.29 %   [ `assignment_type`, `server_criteria`, `cve_criteria` ]   (#18.`assignment_type` == "vuln_title_lowpriority")
 14   primary           primary   PM_vulnerabilities   true     false       100.00 %   [ `_key` ]                                                 vuln

Functions used:
 Name         Deterministic   Cacheable   Uses V8
 REGEX_TEST   true            true        false

Optimization rules applied:
 Id   RuleName
  1   inline-subqueries
  2   move-calculations-up
  3   move-filters-up
  4   remove-unnecessary-calculations
  5   move-calculations-up-2
  6   move-filters-up-2
  7   remove-data-modification-out-variables
  8   use-indexes
  9   remove-filter-covered-by-index
 10   patch-update-statements
 11   reduce-extraction-to-projection
 12   move-filters-into-enumerate

Write query options:
 Option                   Value
 waitForSync              false
 skipDocumentValidation   false
 keepNull                 true
 mergeObjects             true
 ignoreRevs               true
 isRestore                false
 ignoreErrors             false
 ignoreDocumentNotFound   false
 readCompleteInput        false
 consultAqlWriteFilter    false
 exclusive                false
 nullMeansRemove          false

Dataset:
PM_vulnerabilities
{
    "_key": "22534546472",
    "_id": "PM_vulnerabilities/22534546472",
    "_rev": "_b5Whp5y--g",
    "vulnerability_id": 170070,
    "nexpose_id": "oracle_linux-cve-2017-16644",
    "title": "Oracle Linux: (CVE-2017-16644) ELSA-2020-5837: Unbreakable Enterprise kernel security update",
    "date_published": "2017-11-07",
    "severity_score": 7,
    "severity": "Severe",
    "riskscore":<PHONE_NUMBER>4492188,
    "cvss_score": 7.19999981,
    "exploits": 0,
    "exploitable": 0,
    "malware_kits": 0,
    "cvss_vector": "AV:L/AC:L/Au:N/C:C/I:C/A:C",
    "cvss_v3_vector": "CVSS:3.0/AV:P/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
    "cvss_v3_score": 6.6,
    "description": "The hdpvr_probe function in drivers/media/usb/hdpvr/hdpvr-core.c in the Linux kernel through 4.13.11 allows local users to cause a denial of service (improper error handling and system crash) or possibly have unspecified other impact via a crafted USB device.",
    "special_team_title": "UNIX",
    "comment": "2018-12-05 QA",
    "prime_contact": "John Doe"
  },
  {
    "_key": "22534546475",
    "_id": "PM_vulnerabilities/22534546475",
    "_rev": "_b5Whp5y--i",
    "vulnerability_id": 170073,
    "nexpose_id": "oracle_linux-cve-2020-12674",
    "title": "Oracle Linux: (CVE-2020-12674) (Multiple Advisories): dovecot security update",
    "date_published": "2020-08-12",
    "severity_score": 5,
    "severity": "Severe",
    "riskscore": 82.48636627197266,
    "cvss_score": 5,
    "exploits": 0,
    "exploitable": 0,
    "malware_kits": 0,
    "cvss_vector": "AV:N/AC:L/Au:N/C:N/I:N/A:P",
    "cvss_v3_vector": "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H",
    "cvss_v3_score": 7.5,
    "description": "In Dovecot before <IP_ADDRESS>, sending a specially formatted RPA request will crash the auth service because a length of zero is mishandled.",
    "special_team_title": "UNIX",
    "comment": "2018-12-05 QA",
    "prime_contact": "John Doe"
  },

PM_special_teams
  {
    "_key": "22528758186",
    "_id": "PM_special_teams/22528758186",
    "_rev": "_b5Q7Ovu---",
    "assignment_type": "vuln_title_lowpriority",
    "cve_criteria": "database",
    "team_assignment": "Database",
    "prime_contact": "Jane Smith",
    "date": "7/17/2018",
    "QA": "Success",
    "server_criteria": ""
  },
  {
    "_key": "22528759579",
    "_id": "PM_special_teams/22528759579",
    "_rev": "_b5Q7OxW--Q",
    "assignment_type": "vuln_title_lowpriority",
    "cve_criteria": "Oracle Linux",
    "team_assignment": "UNIX",
    "prime_contact": "John Doe",
    "comment": "2018-12-05 QA",
    "date": "11/29/2018",
    "QA": "Success",
    "server_criteria": ""
  },

Size of your Dataset on disk:
[docker@server engine-rocksdb]$ pwd
/arangodb/arangodb3/engine-rocksdb
[docker@server engine-rocksdb]$ du -h
0       ./journals/archive
94M     ./journals
3.9G    .
Replication Factor & Number of Shards (Cluster only):
N/A
Steps to reproduce

Execute Query in web console or in arangosh

Problem:
2021-02-18T11:02:42Z [1] ERROR JavaScript exception in file<EMAIL_ADDRESS>at 99,7:
ArangoError 4: Expecting Object (while executing) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:32
0). Please report this error to arangodb.com\n!      throw error;\n!      ^\nstacktrace: ArangoError: Expecting Object (while execu
ting) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:320). Please report this error to arangodb.com\
n    at Object.exports.checkRequestResult (/usr/share/arangodb3/js/client/modules/@arangodb/arangosh.js:97:21)\n    at ArangoStatem
ent.execute (/usr/share/arangodb3/js/client/modules/@arangodb/arango-statement.js:171:12)\n    at Proxy.ArangoDatabase._query (/usr
/share/arangodb3/js/client/modules/@arangodb/arango-database.js:931:45)\n    at (command-line):1:4\n
Expected result:
Im not expecting this to run quickly but I would expecting it to be able to run and update 7878 documents in the PM_vulnerabilities collection.
It executes without issues on 3.6.11 on the MMFiles storage engine
If I Return a result instead of trying to Update, the query will run successfully.
Here's the Profile of the query when I do a Return instead of Update
Profiling information
A    0.001 ms initializingstartup time for query engine
B    0.090 ms parsingquery parsing
C    0.012 ms optimizing astabstract syntax tree optimizations
D    0.009 ms loading collectionsloading collections
E    0.035 ms instantiating planinstanciation of initial execution plan
F    0.205 ms optimizing planexecution plan optimization and permutation
G    2.270 s executingquery execution
H    0.016 ms finalizingquery finalization

Hi @spirit-team,
I had no success reproducing the error with a 3.7.8 single server. It seems that the given two documents for both collections are not sufficient. Does the error show on your side when you run the query on the shared 4 documents?
If not, would it be possible to a create a dump (using arangodump) which includes collections PM_special_teams and PM_vulnerabilities?.
You can send us a message to<EMAIL_ADDRESS>(this ML is not public) and attach the dump in that email. This way we can try to reproduce and find the root cause. Please reference the number of this issue in your email.

Hi @maxkernbach, thanks for the follow-up. I will try to run the query on version 3.7.10 just in case and I will see what I can do about those dumps, There is sensitive data in there so I cant just dump the collections as-is.

Not sure if related or not, but I just created a PR that fixes velocypack (vpack) errors that could be returned by the cursor API in case of an internal exception. In this case, the velocypack error could be somewhat unrelated and mask the original exception message. The original exception message was clobbered by the velocypack error message, which was triggered by trying to write the "error" and "code" attributes to the cursor result after the exception occurred. If the exception had happened during cursor result buildup, then the result could have been in a state that would not allow adding further attributes to it, and try to do so anyway could have led to follow-up errors.
Anyway, I can't say for sure if this is what has happened here, but it is not completely unlikely.
The PR in question for 3.7 is https://github.com/arangodb/arangodb/pull/13871

@spirit-team v3.7.11 is available. Can you please try this version and see if it resolves the issue or at least provides a better error message now?

@Simran-B
Yep, already downloaded the new docker image yesterday, I'll test as as soon time allows and give an update on the error message or let you know if somehow it suddenly starts working

@Simran-B unfortunately the error is very similar with 3.7.11. This is what I am getting now.
2021-05-06T18:57:45Z [155] ERROR [979b9] JavaScript exception in file<EMAIL_ADDRESS>at 99,7: ArangoError 4: Expecting Object (while executing) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:333). Please report this error to arangodb.com\n!      throw error;\n!      ^\nstacktrace: ArangoError: Expecting Object (while executing) (exception location: /work/ArangoDB/arangod/RestHandler/RestCursorHandler.cpp:333). Please report this error to arangodb.com\n    at Object.exports.checkRequestResult (/usr/share/arangodb3/js/client/modules/@arangodb/arangosh.js:97:21)\n    at ArangoStatement.execute (/usr/share/arangodb3/js/client/modules/@arangodb/arango-statement.js:172:12)\n    at Proxy.ArangoDatabase._query (/usr/share/arangodb3/js/client/modules/@arangodb/arango-database.js:957:45)\n    at (command-line):1:4\n
Any ideas on what else we can try here?

@spirit-team : ah, that's unfortunate.
If there is no way to share dataset in question, one way to make progress is to determine if the problem is cause by the selection or the update part of the query.
If you could run the query
LET Assignment = (
FOR st IN PM_special_teams
	FILTER st.assignment_type == "vuln_title_lowpriority"
	AND st.cve_criteria != NULL
		RETURN {
		    "team_assignment": st.team_assignment,
		    "cve_criteria": st.cve_criteria,
		    "prime_contact": st.prime_contact,
		    "comment": st.comment
		}
)
FOR st IN Assignment
    FOR vuln IN PM_vulnerabilities
        FILTER REGEX_TEST(vuln.title, st.cve_criteria, true)
        RETURN vuln

and it completes successfully, then the problem is likely in the update part of the query.
But if the selection-only query fails, the problem can hopefully be further narrowed down to a specific document, by adding LIMIT(s) to the query and then adjusting the LIMIT value(s) to find the offset for/after which the query begins to fail. Hopefully that allows pin-pointing the problematic document.
Thanks!

@jsteemann Yep, that query works. Returns 7878 documents in 4.411
A  0.005 ms  initializing  startup time for query engine
B  0.293 ms  parsing  query parsing
C  0.018 ms  optimizing ast  abstract syntax tree optimizations
D  0.014 ms  loading collections  loading collections
E  0.039 ms  instantiating plan  instanciation of initial execution plan
F  128.119 ms  optimizing plan  execution plan optimization and permutation
G  4.283 s  executing  query execution
H  0.019 ms  finalizing  query finalization

I tried sending the result of the LET Assignment = (...) in a temporary table with cve_criteria already in lowercase and with an index on that field.  And I also added another field in PM_vulnerabilities named lower_title, which is the content of title but already lowercased and I added an Index on that aswell. And then tried both of the following queries, but neither work in the end.
Query 1
FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER vuln.lower_title LIKE st.cve_criteria
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

Query 2
FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER REGEX_TEST(vuln.lower_title, st.cve_criteria, false)
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

I also ran this query
LET Assignment = (
FOR st IN PM_special_teams
	FILTER st.assignment_type == "vuln_title_lowpriority"
	AND st.cve_criteria != NULL
		RETURN {
		    "team_assignment": st.team_assignment,
		    "cve_criteria": st.cve_criteria,
		    "prime_contact": st.prime_contact,
		    "comment": st.comment
		}
)
FOR st IN Assignment
    FOR vuln IN PM_vulnerabilities
        FILTER REGEX_TEST(vuln.title, st.cve_criteria, true)
        COLLECT item = st.cve_criteria WITH COUNT INTO Count
        RETURN {
            "cve_criteria": item,
            "count": Count
        }

This is the result of that query
cve_criteria | count
-- | --
database | 610
Domino | 251
IBM AIX | 840
jboss | 319
Jenkins | 461
Lotus Notes | 242
Oracle Linux | 4904
SharePoint | 246
tuxedo | 5

And finally I ran 2 seperate update query again but in the first I excluded "Oracle Linux" which as by far the biggest hit count, and in the second I only update the ones that match "Oracle Linux" and both upddate actually works. So individually they both work but together they dont =(
FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER st.cve_criteria != "oracle linux" && REGEX_TEST(vuln.lower_title, st.cve_criteria, false)
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER st.cve_criteria == "oracle linux" && REGEX_TEST(vuln.lower_title, st.cve_criteria, false)
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

They respectively updated this:
6.156 s  3493 writes  0 writes ignored
1.217 s  4904 writes  0 writes ignored
I really dont get it. halp!

@spirit-team : ok, so the following query still fails with the original error?
FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER vuln.lower_title LIKE st.cve_criteria
            UPDATE vuln WITH {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            } IN PM_vulnerabilities

If so, can you try checking if it still fails when turning it into a selection-only query, i.e.
FOR st IN PM_low_priority_assign
    FOR vuln IN PM_vulnerabilities
        FILTER vuln.lower_title LIKE st.cve_criteria
            RETURN {
                "special_team_title": st.team_assignment,
                "prime_contact": st.prime_contact,
                "comment": st.comment
            }

If this fails, then the LIMIT approach could be tried, by adding a LIMIT clause in front of RETURN and seeing if it fails for a specific document (or for a certain result set size).
Thanks.

@jsteemann Finally found time to setup a 3.8.2 environment and test it. It is indeed FIXED in 3.8.2!!
Thanks alot.
Marking this issue as closed.

@spirit-team : nice, and good to read! Thanks for getting back!


Logo_added

GG

ill take someday to complete it??

okay

should i add name under
@anushbhatia

@anushbhatia


[stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver<EMAIL_ADDRESS>What this PR does / why we need it:
Add the Thanos gRPC port to the headless service when deploying Prometheus Server using StatefulSet
Which issue this PR fixes

fixes #22783

Special notes for your reviewer:
@gianrubio @zanhsieh
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign
/ok-to-test

/test pull-charts-e2e

/test pull-charts-e2e

this error doesn't seem to be related to my PR
...
I0614 20:31:21.922] ------------------------------------------------------------------------------------------------------------------------
I0614 20:31:21.922] ==> Logs of container prometheus-j2ggsksfxv-server-67585ff856-psqwx
I0614 20:31:21.923] ------------------------------------------------------------------------------------------------------------------------
I0614 20:31:22.284] Error from server (BadRequest): container "prometheus-server-configmap-reload" in pod "prometheus-j2ggsksfxv-server-67585ff856-psqwx" is waiting to start: ContainerCreating
I0614 20:31:22.284] Error printing details: Error waiting for process: exit status 1
...