Hook up time range message downloads

Ready for review.

Okay, maybe ready for review now. ;)

I'm not sure how https://github.com/praekelt/vumi-go/pull/1340/files#diff-8b9eacc3cdf12b6761950e2895d5cd66R795 passed in #1340. I don't find the "unique people" in the conversation templates anymore?

I'm not sure how https://github.com/praekelt/vumi-go/pull/1340/files#diff-8b9eacc3cdf12b6761950e2895d5cd66R795 passed in #1340. I don't find the "unique people" in the conversation templates anymore?

Hrm, that is weird. I remember changing those tests to match the new way we are displaying the uniques, maybe I'm remembering wrong.

Hrm, that is weird. I remember changing those tests to match the new way we are displaying the
uniques, maybe I'm remembering wrong.

There is a new test -- it looks like the merging just got confused by the deletion of the old test and the creation of a new test above it.

Ready for re-review.
Still need to:

Open the modal if the form is bound.
Restore the old data if the form is bound.

Hopefully all done now.

Other than the non-input-validation error handling stuff that we discussed over slack and the filenames comment, just a few minor things. Looks good.

:+1:! (when travis is happy)

Oops. Missed a file in the last commit.


Event Emitter

Description of the Change
A pretty way to create events and subscribe to them is implemented in this PR.
Benefits
EventEmitter will be heavily used in Libp2p.
Possible Drawbacks
None.
Usage Examples or Tests [optional]
/test/core/libp2p/event/emitter_test.cpp

Codecov Report

Merging #111 into master will increase coverage by 0.03%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage    72.4%   72.43%   +0.03%
==========================================
  Files         236      238       +2
  Lines        7335     7351      +16
  Branches     3801     3812      +11
==========================================
+ Hits         5311     5325      +14
  Misses       1089     1089
- Partials      935      937       +2

Impacted Files
Coverage Δ

.../libp2p/transport/impl/transport_listener_impl.hpp
100% <ø> (ø)
:arrow_up:

core/libp2p/event/emitter.hpp
100% <100%> (ø)

test/core/libp2p/event/event_emitter_test.cpp
83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e441921...3db7d43. Read the comment docs.


Tag for package management

I'm considering this for use in a production application. We use Glide for package management, and it would be very helpful if this repository had a semantic version tag so that our builds are reproducible. Without that, I'm hesitant.

Need semvar on tags +1


chore(jest): update jest config and setup-related files

Pulled out from #258 so that PR wasn't a monster 😄
Changelog
New

config/jest/**Transform.js: custom file transformers
config/jest/setup.js: setup hook that pulls in polyfills
config/polyfills: generic polyfills used for products. Pulled from CRA

Changed

package.json now has more details Jest config and includes enzyme-to-json for snapshots

Removed

setup-jest.js

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit 1553ead9e7d2d2b57318f5d490ba2ada8fef2fd8


Add .travis.yml file

Closes #14

This change is

Welcome aboard, travis!

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


SecurityGroup Crossplane Composite Wrapper Resource

What: SecurityGroup resource is in v1beta1 in the aws-crossplane provider. In order to allow our multi-tenancy users to deploy and manage this resource type we need to create a composition wrapper around it (resource and rbac) and add it to our DFDS Configuration Package
Why: This will allow cluster users to deploy and manage AWS SecurityGroup resources using Crossplane in Hellman with appropriate RBAC permissions

[x] Create XRD
[x] Create Composition
[x] Test in Sandbox
[ ] Create Release

Raised PR: https://github.com/dfds/crossplane-configuration-dfds/pull/12

https://github.com/dfds/crossplane-configuration-dfds/tree/v0.0.1-alpha.13 created and built


Run environment variable validation before tests

Description
Because Jest has its own output rendering/buffering and envalid reporter sends an exit signal before Jest manages to render and output console.errors generated by reporter, if environment variables validation failed it just terminated with no error messages - i have made changes which will do environment variable validation before we even start Jest, which will bypass Jests buffering/rendering and output errors as expected.
Relevant issue
Resolves #26

@trioletas thank you for the feedback - i totally agree, with it and i did a little refactor - now we use TypeScript and proper ES6 modules, as it already was - i just modified the validation task so it compiles the env.ts and then uses node to execute it - no more mixing of ES5 and 6 modules and JS and TypeScript.

Cool, thanks!
I am testing this build on VSTS now and there are some new errors during the test phase that I don't quite understand yet.
It could be related to the fact that we call raw 'node' executable from the path in 'validate:env' task.
Keep it unnmerged for now please.

all good


BitDatePicker full page UI in mobile

we need BitDatePicker to be a full page in mobile size.

Thanks for contacting us. We're investigating this issue.
We'll let you know if it's possible to work on this issue or not.

Thanks for contacting us. We're investigating this issue.
We'll let you know if it's possible to work on this issue or not.

The issue is accepted and planned. Resolving it will start ASAP.

Resolving this issue has started. It will be announced when this issue is resolved.

This issue has been resolved and it will be available in the next pre-release version. It will be announced when the pre-release becomes ready.

The pre-release has been published. Please give it a try and give feedback.


IgnoreErrors not filtering certain events.

Trying to filter the following errors on the SDK side:
*mysql.MySQLError
Error 188 (HY000): FTS query exceeds result cache limit
For that, we are using the ignoreErrors configuration with value: Error 188 (HY000): FTS query exceeds result cache limit, however it does not filter the events. Changing the filter to only FTS query exceeds result cache limit serves as a workaround.
opts := sentry.ClientOptions{
    Dsn: config.Sentry.Dsn,
    Debug: true,
    Integrations: func(i []sentry.Integration) []sentry.Integration {
            return i
    },
    IgnoreErrors: []string{
            "FTS query exceeds result cache limit",
    },
}

SDK version: 0.25.0.

Since the values in IgnoreErrors are converted to regex patterns, characters ( and ) need to be escaped for this to  work.
This is how you can add it:
IgnoreErrors: []string{`Error 188 \(HY000\): FTS query exceeds result cache limit`},

Could we change IgnoreErrors to take both regex and strings into account? Same for IgnoreTransactions.

Yep, e.g. in JS https://docs.sentry.io/platforms/javascript/configuration/options/#ignore-errors


[AutoPR cognitiveservices/data-plane/ContentModerator] [Cognitive Services] Update endpoint URL template for Content Moderator.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3505

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/2438


Release NHS.UK frontend v4.1.0

What
Release NHS.UK frontend v4.1.0
Depends on
https://github.com/nhsuk/nhsuk-frontend/milestone/2

To be released tomorrow (Thursday 21st January)

To be released tomorrow (Thursday 21st January)

Done

Done


Login sometimes locks up

getting can't call componentWillUnmount of null

can't duplicate. maybe staff account issue?

@jbaxleyiii staff account is working fine for me too

@johnthepink I can't duplicate in the newer build. Will keep this issue open for another day just to make sure

@johnthepink found the source. The refactoring of the Error template was missed here.  Fixed in #292


More dark mode improvements

                                                                                Not sure what you mean; it's just css. I can't quite remember what this rule is fixing, though. Something quite specific.                                                                                From: sunyaSent: Sunday, March 18, 2018 8:18 AMTo: sunya9/betaReply To: sunya9/betaCc: 33MHz; AuthorSubject: Re: [sunya9/beta] More dark mode improvements (#99)@sunya9 commented on this pull request.

In assets/css/main.scss:

background-color: #252525;

}

.dropdown-menu {
background-color: #252525;
color: #d5d5d5;
}

.dropdown-item {
color: #d5d5d5;
}
.dropdown-item:hover, .dropdown-item:focus {
background-color: #1a1a1a;
}

.list-group-item[data-v-1084c69e]:hover:not(.active):not(.h5) {

Umm... I don't understand this class that which components. Can you write as scoped css in a vue component?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sunya9/beta","title":"sunya9/beta","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/sunya9/beta"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sunya9 commented on #99"}],"action":{"name":"View Pull Request","url":"https://github.com/sunya9/beta/pull/99#pullrequestreview-104797022"}}}

Or did you mean something else?


Fix issue when keytab contains old and new versions of keys

Fix for https://github.com/dotnet/Kerberos.NET/issues/165 issue

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Zubastic sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This looks really good. Would it be possible to add a unit test to verify the behavior?

And accepted!

Why this PR was reversed in https://github.com/dotnet/Kerberos.NET/commit/0b83e6b2e4183e17daece5b3cf12187a929b1771#diff-d01ee0fe161d0959bb2cef60df8352c6f36e348b6518da40e9a9e75350105552?
it doesn't work again :(

Fixed. Next nuget package will have this fix. Should be available in ~20 minutes.


Refactor in memory state reader

I am currently creating a draft as I had some questions when refactoring "inMemoryStateReader".

This PR was closed because the task of refactoring the InMemoryStateReader has been completed in PR #183


Doesn't affect channel list

Yea, the channel list doesn't get themed.

Resolved with a bit of custom CSS on top (using BetterDiscord's normalized tags)
.theme-dark {
    --background-secondary: var(--nox-level2);
}
.da-header {
    background-color: var(--nox-level3);
}


OpenTelemetry support does not work  properly

Basic information

Axon Framework version: 4.7.1
JDK version:  N/A
Complete executable reproducer if available (e.g. GitHub Repo):

Steps to reproduce

Add axon-tracing-opentelemetry as module to a project
Add the Google Cloud Tracer
Run project without the OTEL agent

Expected behaviour
Traces are correlated to eachoter. When using nesting, they should become part of the same trace.
Actual behaviour
They are no correlated and do not become part of the same trace.
Unclear whether this also happens for Spring Boot 2

After experimentation together with @maverick1601, we found that traces are not propagated if the JVM is not run with a JVM agent.
We should check whether we can run without it, so that these use cases are covered. For now, people should run with the OpenTelemetry agent, using the agent downloadable here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v1.23.0 and passing it to the JVM as agent during boot -javaagent:otel-agent.jar.
It is safe to assume that this is the case both on 4.6 and 4.7.
This was tested with the following configuration:
@Bean
fun gcpSpanExporter(credentialsProvider: CredentialsProvider): SpanExporter =
    TraceExporter
        .createWithConfiguration(
            TraceConfiguration
                .builder()
                .setCredentials(credentialsProvider.credentials)
                .build()
        )
@Bean
fun spanFactory(tracer: Tracer): SpanFactory {
    return NestingSpanFactory
        .builder()
        .delegate(
            OpenTelemetrySpanFactory
                .builder()
                .tracer(tracer)
                .build()
        )
        .timeLimit(Duration.ofSeconds(60))
        .build()
}

And the following dependencies:
<dependency>
    <groupId>com.google.cloud.opentelemetry</groupId>
    <artifactId>exporter-trace</artifactId>
    <version>0.15.0</version>
</dependency>
<dependency>
    <groupId>com.google.cloud</groupId>
    <artifactId>spring-cloud-gcp-starter</artifactId>
    <scope>compile</scope>
</dependency>
<dependency>
    <groupId>io.micrometer</groupId>
    <artifactId>micrometer-tracing-bridge-otel</artifactId>
</dependency>
<dependency>
    <groupId>org.axonframework</groupId>
    <artifactId>axon-tracing-opentelemetry</artifactId>
</dependency>

I am changing this issue to be a collection of all OpenTelemetry issues I have found to be happening in the framework. For all OpenTelemetry issues, comments can be added to this issue. I will notify of updates when I have a release with the fixes.

Closing this issue as it's resolved in PR #2612


OAuth error

"Error HRESULT E_FAIL has been returned from a call to a COM component."
The error comes from GoogleWebAuthorizationBroker.AuthorizeAsync()
Visual Studio 2015 Update 3
Universal Windows App

Google.Apis.Auth.OAuth2

Google.Apis.Blogger
   try
      {

        credential = await GoogleWebAuthorizationBroker.AuthorizeAsync(
            new Uri("ms-appx://Assets/client_secret.json"),
            new[] { Uri.EscapeUriString(BloggerService.Scope.Blogger) },
            "user",
            CancellationToken.None
            );

        bloggerService = new BloggerService(new Google.Apis.Services.BaseClientService.Initializer
        {
            HttpClientInitializer = credential,
            ApplicationName = "Google"
        });
        var listSource = await bloggerService.Users.Get(credential.UserId).ExecuteAsync();
    }
    catch (Exception ex)
    {
       // here is the exception
        var ez = ex.Message.ToString();
    }
}`

P.S. Sorry if it's the wrong spot to submit this issue.

Remove the line with user.Get    does it work then?

I suspect this is a UWP-specific issue. We don't currently support UWP, so closing.


Fix blobs with timestamp seconds fragment of .000 not loading

here is an example of the bug: https://trains.jo-m.ch/#/trains/75159

Thanks!


feat/add steps cas

feat: add steps env test cases
chore: run formatter

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.48%. Comparing base (1141299) to head (5e6a5ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   65.97%   73.48%   +7.51%
==========================================
  Files           5        5
  Lines         479      479
  Branches       70       79       +9
==========================================
+ Hits          316      352      +36
+ Misses        160      125      -35
+ Partials        3        2       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tavily keeps getting back to me by saying "there are no search results for your question"

It's been a couple of days I am not getting any correct response back no matter how simple the input query is. Here are some examples:
self.tavily_client.qna_search('when did russia war start?')
Response: 'Based on the data provided, there are no results available regarding the start date of a war involving Russia.'

self.tavily_client.qna_search('usa president')
Response: 'Based on the information available, there is no specific data provided regarding the current USA president.'

Any idea?

Maybe try a different retriever? SerpAPI seems to work well for most use cases

Ahh I see. I've installed Tavily through pip. Is there a way to change the config to use other retrievers in this case?

You can add the SEARCH_RETRIEVER key in your env and point it to serp....and you also need to specify your SERP_API_KEY in that case.
(Please double check the proper env keys and values)
Looking at the config.py file and the retriever files  should give you an idea!

Tavily search should be back to normal


Added OrderBy Feature in xql

Added orderby support in xql.
Removed unnecessary methods and relevant code.

LGTM


Added validation of signed F5 header for jwt bearer grant

Signed-off-by: Sanjeev<EMAIL_ADDRESS>

Made some minor updates (see commit)
More changes needed for this story:

If 2way tls enforcement is enabled, JwtBearerAssertionTokenAuthenticator needs to use the tenant and sub claim from the proxy header to lookup the device public key, for verifying the jwt-bearer assertion token
Given this, I suggest we push the header enforcement into JwtBearerAssertionTokenAuthenticator class.  It can still delegate to ClientAssertionHeaderAuthenticator


python3Packages.ipwhl: 1.0.0 -> 1.1.0

Description of changes
Release note: depsck now lets you know the packages whose dependencies are not met
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 172278 run on x86_64-linux 1

2 packages built:

python310Packages.ipwhl
python39Packages.ipwhl


[cleanup] Remove eslint-plugin-material-ui

[x] I have followed (at least) the PR section of the contributing guide.

Bundle size will be reported once CircleCI build #1128 finishes.

  Generated by :no_entry_sign: dangerJS against f9cd068e72f8644c14ff60f4204e554c78981ce3

Bundle size will be reported once CircleCI build #1132 finishes.

  Generated by :no_entry_sign: dangerJS against 9ac498eb4e2439cdf2d65873f6173bead9f5826c


Fix typo in README

I'm pretty sure "tree tree" should have been "test tree"?

Good catch -- thanks 🙂!


Cannot override Nunjucks configuration

The 11ty docs suggest overriding the default Nunjucks configuration with a stanza like
eleventyConfig.setNunjucksEnvironmentOptions({
  dev: true
});

in eleventy.config.js. (This example was to set a flag which I was hoping would tell me what was wrong with my template, ho hum.)
However, the way that the plugin configures Nunjucks in https://github.com/x-govuk/govuk-eleventy-plugin/blob/main/lib/nunjucks.js#L36 this doesn't seem to be possible. A default configuration is obviously essential, but it would be nice if this just worked.

Now possible in v6.3.0 of the plugin. Thanks for reporting this issue!


Windows build: string_view is only available with C++17

When building/compiling with windows I get the following error:

For a week or so it runs smoothly.
Thanks for your help,
Helmut

Can you verify that if the following patch works? Tested with clang and g++ on mac and linux.
diff --git a/third_party/string_view.hpp b/third_party/string_view.hpp
index 564aace..f8d3703 100644
--- a/third_party/string_view.hpp
+++ b/third_party/string_view.hpp
@@ -30,7 +30,7 @@
 #endif
 #if defined(__has_include) && !defined(STX_NO_STD_STRING_VIEW)
-#if __has_include(<string_view>)
+#if __has_include(<string_view>) && ((__cplusplus > 201402) || defined(_LIBCPP_VERSION))
         #include <string_view>
         #define STX_HAVE_STD_STRING_VIEW 1
         namespace STX_NAMESPACE_NAME {

I'll care about it in the evening.
Best regards,
Helmut
On Mon, Feb 5, 2018 at 1:33 PM, scturtle<EMAIL_ADDRESS>wrote:

Can you verify that if the following patch works? Tested with clang and
g++ on mac and linux.
diff --git a/third_party/string_view.hpp b/third_party/string_view.hpp
index 564aace..f8d3703 100644--- a/third_party/string_view.hpp+++ b/third_party/string_view.hpp@@ -30,7 +30,7 @@
#endif
#if defined(__has_include) && !defined(STX_NO_STD_STRING_VIEW)-#if __has_include(<string_view>)+#if __has_include(<string_view>) && ((__cplusplus > 201402) || defined(_LIBCPP_VERSION))
#include <string_view>
#define STX_HAVE_STD_STRING_VIEW 1
namespace STX_NAMESPACE_NAME {
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cquery-project/cquery/issues/415#issuecomment-363071700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNjLHJdrbz79nx6XHHZH_q08tA07sVyks5tRvUBgaJpZM4R5Upq
.

It compiles on Windows without error.
Best regards,
Helmut
On Mon, Feb 5, 2018 at 1:33 PM, scturtle<EMAIL_ADDRESS>wrote:

Can you verify that if the following patch works? Tested with clang and
g++ on mac and linux.
diff --git a/third_party/string_view.hpp b/third_party/string_view.hpp
index 564aace..f8d3703 100644--- a/third_party/string_view.hpp+++ b/third_party/string_view.hpp@@ -30,7 +30,7 @@
#endif
#if defined(__has_include) && !defined(STX_NO_STD_STRING_VIEW)-#if __has_include(<string_view>)+#if __has_include(<string_view>) && ((__cplusplus > 201402) || defined(_LIBCPP_VERSION))
#include <string_view>
#define STX_HAVE_STD_STRING_VIEW 1
namespace STX_NAMESPACE_NAME {
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cquery-project/cquery/issues/415#issuecomment-363071700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNjLHJdrbz79nx6XHHZH_q08tA07sVyks5tRvUBgaJpZM4R5Upq
.


Hotspot online, sending beacons but not receiving witnesses.

Issue as the title says (and it also has a Bluetooth connection interruption around 1 minute after reboot, also the button is not functional) with my Nebra Rock Pi 4 Indoor Miner: Firmware Version | 2<IP_ADDRESS> (8465d62)

Please reach out to<EMAIL_ADDRESS>


Implement account logic

Coverage decreased (-1.1%) to 76.66% when pulling ffa472be96ec895381bd2926a62f2eabc6bcbc28 on dev into 1ec97d8125bae357f72be574cb850f0310ad10cd on master.


Add support button to documentation and plugin description

Add a buymecoffee link to documentation and plugin description.

f00267833dbbf92436a04186fcd7931aa5d94f39 description and documentation updated and support button added.


Setup build state and code coverage in readme

[x] Build state
[ ] Code Coverage

Due to the difficulty of setting up code coverage for electron and typescript in conjunction, abandoning code coverage


[CH]Murmurhash3 returns different results in spark and ck when unaligned length of buffer is input

finish the first todo in https://github.com/oap-project/gluten/pull/2317


Refs: #AR-5583-license updated to MIT for the public repo to be class…

…ified as opensource by GitHub

@SauravKanchan can u also merge this to main branch?


Prepare v2.0.0

add fillPanel method
add clearAllKeys method
return the StreamDeck constructor instead of automatically instantiating it
allow providing a devicePath to the constructor

if no device path is provided, will attempt to use the first found Stream Deck. Errors if no Stream Decks are connected.

fix center-cropping in fillImageFromFile
update all examples
add fillPanel example
refactor StreamDeck class to move as much as possible to static methods and static getters
update this.keyState before emitting down and up events

this is technically a breaking change, but is very unlikely to affect any production code

refactor code to use async/await

this is a breaking change, because we now only support Node.js v7.6 or newer

fix sharp only being a devDependency, and not a production dependency

I tried to get JIMP fully working, but I found JIMP to be very unpleasant to work with. Its codebase also does not seem to be particularly high quality. Because of this, I feel strongly that we should stick to using sharp. The only downside of sharp is that it currently doesn't have pre-built binaries, but this is being worked on.
Due to the lifecycle of this release, the commit history is pretty much non-existent and this is going to get merged as one huge squashed commit. This isn't ideal and we'll want to work to avoid this happening again the future, but it is what it is.

Coverage remained the same at 100.0% when pulling 13985c2e0b332603423bbf0f09dcdd7fabd4599b on next into c6a599a60f90e319e42476bf2c39f43ab8e33c96 on master.

I concur with Lange's assessments. I also agree with squash merging.


team 5 searchproducts

Burst repair sqlinjection
mysqli_real_escape_string — Escapes special characters in a string for use in an SQL statement, taking into account the current charset of the connection

Great work.


Correctly choose index type

When users specify "$text" in the selector, json indexes should not be
used satisfy the query. We check the list of fields and look for
"$default". This implies that "$text" was used in the selector and
filter out all json indexes.
Fogbugzid: 46498

I'd rather see the is_usable test in mango_idx_view have a new self contained function. The amount of change to indexable_fields seems rather extensive and removes some assertions about the shape of those terms which worries me a bit.

I'm going to create a new self contained function for mango_idx_view. The additions to indexable_fields and also convert was due to problems discovered playing with various selectors. I'd like to keep some of these changes. Should I put them in a separate branch?

Yes, anything that's not related to the branch topic should be in a different branch topic.

Will remove those extraneous items and open a different PR for them.

+1


Add obsoletion notice to region id

Region ids are not used anymore but are still needed for older seasons. Not sure what direction to take but either an obsoletion notice or xmldoc comment would be useful to tell users not to bother setting it unless needed

Forgot to mention that this would be addressed alongside #117

Closed by #160


fix: role_edit_position and emoji::format didn't return animated emojis

I've tested the added role_edit_positions method for functionality


Determining merged references?

I have a need to determine branches that are merged into the currently checked out reference. Right now, I'm doing something that I consider a little hacky:
//determine current ref name
fullRef, err := r.Head()
checkIfError(err, removePath)

// determine which branches are merged
os.Chdir(path)
p := pipe.Line(
    pipe.Exec("git", "branch", "--all", "--merged"),
    pipe.Exec("grep", "-v", fmt.Sprintf("master|develop|%s", fullRef.Name().Short())),
    pipe.Exec("sed", "-E", "s/^\\s*\\*?\\s*//"),
)

output, err := pipe.CombinedOutput(p)
checkIfError(err, removePath)

mergedBranches := strings.Fields(fmt.Sprintf("%s", output))
fmt.Print(mergedBranches, "\n")

As far as I can tell, there's not really a cleaner way to do this using your package. Is there a recommended approach for this?

Thanks for the pointers!

@sudoforge If you happen to implement this in an open source project, we'll be glad to hear about it ;-)

If I end up implementing a solution for this in your library (and I will, eventually), it will definitely end back upstream. Currently, however, I'm just using a similar solution to the semi-psuedo code in my original comment, and implementing this natively is not a priority for that particular project.

I wrote some logic to do this: https://github.com/petems/git-merged-master
In fact it was for basically the same usecase: a gitsweeper for deleting old branhces 😄

The logic is basically iterate through every head of remote branches, compare with the commits from the master branch, if they match then it's been merged:
err = masterCommits.ForEach(func(commit *object.Commit) error {
		for branchName, branchHead := range remoteBranchHeads {
			if branchHead.String() == commit.Hash.String() {
				log.Infof("Branch %s head (%s) was found in master, so has been merged!\n", branchName, branchHead)
				mergedBranches = append(mergedBranches, branchName)
			}
		}
		return nil
	})


Add a new function in Block

Im really waiting for you zhuowei to add a Block method named Block.defineLiquidBlock(id, opaque, blah blah); something like that and 'blah blah' change it into any feature like you can drown or u can be burned alive like lava that would be really appreciated @zhuowei and BTW please change the BlockLauncher's user interface theme to LIGHT not DARK

The way BlockLauncher is would look atrotious with light theme

Liquid blocks will take up TWO block IDs - I'll add it in, but I'm not sure if most mods could find two empty block IDs

Add ' Block.defineChest() ' too

And why didn't anyone think of this method before?

What is the value of material: water??????

Close the issue


Not implemented function in paddle.audio.functional

The resample function is not implemented in paddle.audio.functional.py , but it is called in:
https://github.com/PaddlePaddle/PaddleMIX/blob/598b8c94ac92036bf1d94334685ae9f7f44be348/paddlemix/processors/imagebind_processing.py#L122-L123

Hello, thank you for your reminder. The paddle API call here is incorrect. You can use librosa.resample function to replace it. We will correct it later.


[Refactor] remove JsonValue from datum

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

JsonValue in Datum makes it a huge header, so remove it.

@Mergifyio rebase

run starrocks_be_unittest

run starrocks_be_unittest

@Mergifyio backport branch-2.3

it seems get_if and move_in is also unused

it seems get_if and move_in is also unused

done


Convert tf2 to coreml without " minimum_ios_deployment_target='13' "

❓Question
Hi, I want to convert my tf model to coreml, using tf 2.2.
Is there a way to convert it without using the "minimum_ios_deployment_target="13"? because I would like it to work for older ios versions as well.
If not - is there some workaround that?
Thanks!
Shira

Any update on this issue ?

You can change it to "minimum_ios_deployment_target=12", so you can run in older devices.


fixed window screenshots

also removed unneeded(?) dependencies

pos_x and pos_y could now be removed too

Nice! If it isn't needed, feel free to remove it.
Once you do, I'll take a look at the branch, test it and merged it if it works for me as well.

Very nice. It works perfectly now. Thanks!


Question regarding mix() helper

Laravel Version: 5.4.22
PHP Version: 7.1

Description:
mix() helper currently sets the url to the root directory rather than the full path as seen in asset(), url(). For projects that are deployed in subdirectories, this results in broken links.
May I know if there is a special reason for this?
In addition to that, is url(mix()) recommended as a good practice to set the full path should the project be deployed in subdirectories?

This repo is for bug tracking. Use the forums or slack channel for solving your issue

@Dylan-DPC If you get the nature of my question, this is intended here. This is not a personal question. In fact, as per you stated, this could potentially be a bug.
Just look into asset() and url() and the difference in mix(). There is clearly full paths for asset() and url() but not in mix().

maybe then you should write your title in a better way. Anyway this isn't a bug but a proposal and can be made in laravel/internals repo :)

can be made in laravel/internals repo :)

How do I go about doing that. Sorry I am not sure where to propose such stuff other than an issue in Github which I know is actually kind of wrong place to do so.

Just create an issue as a proposal on the Laravel Internal repository.
By the way, this issue/proposal is somewhat related to this, maybe it can be discussed there.

Created a proposal request for this issue in https://github.com/laravel/internals/issues/581


Create hasUserSeen() for tracking comparison

Would be lovely to provide a way to ask has this user seen something. This will invariably we used for different types of things: taxonomy, nodes, urls, so it should accept a type param.
Easy
hasUserSeen('node', nid)
hasUserSeen('term', tid)

Maybe?
thing = { entity: { 'type': 'node', 'bundle': 'article' } };
hasUserSeen(thing, id);

@doublejosh what is the status of this item? Are you still working on this or can it be closed?


Updated README.md to include additional setup instructions needed pri…

…or to stellargraph install on mac osx
Suggest useful to add section on Mac OSX Setup prior to installation instructions, as users need xcode command line tools and a ~/.matplotlib/matplotlibrc. The command line tools are required by pip to install packages from wheels, e.g. for igraph. The backend setting in matplotlibrc was needed to use matplotlib in python interpreter installed with Anaconda.
Please review changes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jess Moore seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 84.253% when pulling b2b80839d6142268eff8e793eb136540f7c242de on macosx_issues into da453463aaf6d455f166fbb10d94596b8c71684b on develop.

Thanks for this PR @jessclmoore! Although the instructions for Mac OS installation might be useful for some users, I feel they have little to do with the library, rather with making python work on Mac OS, and hence I tend to think these details are excessive. What do you think @adocherty @PantelisElinas?

Thanks for this PR @jessclmoore! Although the instructions for Mac OS installation might be useful for some users, I feel they have little to do with our library, but rather with making python work on Mac OS, and hence I tend to think these details are excessive. What do you think @adocherty @PantelisElinas?

I think that these instructions could be very useful for our partners in installing the library, but I tend to agree with @youph that it is not really about our library.
Perhaps, we can put this detail in the main docs (say docs/quickstart.txt) so they are available but we can keep the front-page readme cleaner?

@youph I suggest we close this?


Shorthand for section?

Can we have a shorthand for section?  Perhaps ><.

(>< tally-value (file->string "stuff.txt") <>)

Or, for things that are hard to type, § (option-6 on the Mac keyboard.)

Or maybe we should move it to cut

How about <tally-value (file->string "stuff.txt") <>>?  Nope.  Students should understand that tally-value is a parameter.  Plus, too many angle brackets.


CalendarView not updated when orientation changes-with navigation controller

[x] I have verified that I am using the latest version of CVCalendar.
[x] I have given my issue a non-generic title.

Expected Behavior
Bug: CalendarView should resize automatically when orientation is changed.
Current Behavior

I am developing an app with a side menu controller for navigation change. One of the options is Calendar. I have set the auto layout constraints as it covers the full view controller.
Currently when the calendar is open in portrait mode the distance between two rows is pretty good. But, when I change to landscape mode the distance should reduce between two rows. Currently, it's not resizing the view it remains the same size as the portrait.
Possible Solution
Not sure it will work or not, but we need to resize the calendarView.contentController when orientation changes.
Steps to Reproduce (for bugs)

The gray view is the CVCalendarMenuView
The green view is the CVCalendarView
Give top, bottom, leading and trailing constraint as 0 for green view.
Portrait view screenshot:

Landscape view screenshot:

Your Environment

Version used (Cocoapods spec): 1.6.1
Device used i.e. iPhone 6S: iPhone Xs Max
Physical device (y/n): Yes
Link to your project (if available):

I was facing same issue @darshanPatel16. I updated the following answer of issue #159 and It was working for me.
(https://github.com/CVCalendar/CVCalendar/issues/159#issuecomment-462932469)
extension CVCalendarView {

    public func redrawViewIfNecessarry() {
        let contentViewSize = contentController.bounds.size
        let selfSize = bounds.size
        let screenSize = UIScreen.main.bounds.size
        let allowed = selfSize.width <= screenSize.width && selfSize.height <= screenSize.height
        setNeedsLayout()
        layoutIfNeeded()
        if !allowed {
            return
        }
        let width = selfSize.width
        let height: CGFloat
        let countOfWeeks = CGFloat(6)
        guard let mode = calendarMode,
            let vSpace = appearance.spaceBetweenWeekViews,
            let hSpace = appearance.spaceBetweenDayViews else {
            return
        }
        switch mode {
        case .weekView:
            height = selfSize.height
        case .monthView:
            height = (selfSize.height / countOfWeeks) - (vSpace * countOfWeeks)
        }
        var found = false
        for constraint in constraints {
            if constraint.firstAttribute == .height {
                found = true
            }
        }
        if !found {
            addConstraint(NSLayoutConstraint(item: self,
                                             attribute: .height,
                                             relatedBy: .equal,
                                             toItem: nil,
                                             attribute: .height,
                                             multiplier: 1,
                                             constant: frame.height))
        }
        weekViewSize = CGSize(width: width, height: height)
        dayViewSize = CGSize(width: (width / 7.0) - hSpace, height: height)
        contentController.updateFrames(selfSize != contentViewSize ? bounds : CGRect.zero)
    }

}

override func viewDidLayoutSubviews() {
        super.viewDidLayoutSubviews()
        menuView.commitMenuViewUpdate()
        calendarView.redrawViewIfNecessarry()
    }

@kevalvadoliya, thanks for the help 👍🏻


Removes wrong return type documentation

The documentation previously stated that createStreamChannel returns an "EventLoopFuture that completes with the new channel", where in reality the method returns Void and you instead supply an EventLoopPromise that is succeeded with the new activated channel. This PR removes the returns: line from the documentation comment.

@swift-nio-bot test this please

thanks @t089 !


Update examples

I deleted the example file as it was out of date. We can add one later if we want to.


AWS host: Return the right status

Fixing a small issue, STATUS_MAP was defined but not used.
Issue described at https://github.com/pvoborni/aiohabit/pull/8#issuecomment-663308754.

@pvoborni  let us merge this! thanks for the fix!


Suggestion : remove unnecessary use of runtime polymorphism

I've found a lot of places in the API where virtual inheritance is used without an apparent reason.
I propose to remove them in order to :

improve performance
simplify the design
encourage better coding practices for beginners
All uses that i have seen can be rewritten without virtual inheritance without breaking existing code (at least without breaking the code that doesn't store objects with base classes pointers, but all of these base classes weren't really designed for that anyway)

Here is a non-exhaustive list, followed by proposed solutions :
1/ RenderTarget : use inheritance as a way to reuse the common code in the RenderTarget base class.
2/ Drawable : use a virtual function draw() for no particular reason. Used by RenderTarget interface
3/ Shape : use a virtual function for accessing the points
4/ Socket : has a virtual destructor but no virtual functions
5/ SoundSource : has play/pause/stop virtual functions
6/ Window : has onCreate() and onResize() virtual functions
Propositions :
1/ remove the base class, stick the reusable code in a CRTP or mixin class, make all the functions taking a RenderTarget a template, and forward the needed data of Target type to the implementation in the .cpp file (e.g instead of querying getSize() through the vtable, take a template type and pass the result of getSize() to the implementation)
2/ remove the base class, and transform the draw(Drawable) methods for "RenderTargetable" types into a template, since there is zero logic inside of it already
3/ same as 1/, remove the base class, make template functions, assume that any ShapeType has a points() methods returning a range of points
4/ remove virtual destructor and the enum, have SocketSelector store a std::variant
5/ it's not clear to me why does this class needs virtual functions? code reuse? if so, replace by a mixin or CRTP class
6/ i don't understand why these functions exists : if i want some code to run after i called create() in my program, i can just shadow the create() function in my class, and resize has a dedicated event already. remove virtual inheritance, stick common code somewhere else
There might be a few more. If these changes are approved, i can work on it.

Just to be clear: this is about public inheritance, not virtual inheritance; these are two different (but non-exclusive) concepts in C++.
I strongly disagree with your proposed changes 😉
Templates
Converting half of SFML and user code to templated code, just to avoid indirections (v-table calls), is just insane.

Templates increase compilation times, make you expose unecessary code, and create more dependencies between files.
Templates don't enforce any design -- how do I know the contract to implement to make my class compatible with the template functions? With a base class, everything is clear.
How do users know what template type "T" is supposed to be for such functions? The API would become such a mess.

In my opinion, templates are a very bad choice in this context.
std::variant
That would make things more complicated, and performances would not even be better.
onCreate and onResize
These functions exist for internal needs, and as far as I remember, they were the only way to solve specific problems. But I'll be happy to reconsider this part of the code if a better solution to these problems is found.
I don't understand why you fight so strongly public inheritance. It's a very common/useful/powerful concept in OO programming and in C++; not something that should be avoided at all costs.
I also fail to see how your proposed solutions satisfy your 3 "improvements" (performances, design, coding practice).
But that's just my opinion, let's see what others think about it.

Just to be clear: this is about public inheritance, not virtual inheritance; these are two different (but non-exclusive) concepts in C++.
I strongly disagree with your proposed changes 😉
Templates
Converting half of SFML and user code to templated code, just to avoid indirections (v-table calls), is just insane.

Templates increase compilation times, make you expose unecessary code, and create more dependencies between files.
Templates don't enforce any design -- how do I know the contract to implement to make my class compatible with the template functions? With a base class, everything is clear.
How do users know what template type "T" is supposed to be for such functions? The API would become such a mess.

In my opinion, templates are a very bad choice in this context.
std::variant
That would make things more complicated, and performances would not even be better.
onCreate and onResize
These functions exist for internal needs, and as far as I remember, they were the only way to solve specific problems. But I'll be happy to reconsider this part of the code if a better solution to these problems is found.
I don't understand why you fight so strongly public inheritance. It's a very common/useful/powerful concept in OO programming and in C++; not something that should be avoided at all costs.
I also fail to see how your proposed solutions satisfy your 3 "improvements" (performances, design, coding practice).
But that's just my opinion, let's see what others think about it.

Totally agree with Laurent here. The "S" in SFML stands for "simple", and I think your proposal would work against this idea. For example, look at some Boost libraries to see what the results of template-based overengineering are: a hard-to-understand API with implicit constraints, compiling for eternities, and resulting in pages of unintuitive compiler errors at the slightest user mistake.
Regarding performance, you only pay for virtual function calls when they are done indirectly (dynamic). If the compiler can determine at compile time which type to call the method on, the indirection can be optimized away. The memory overhead of the VTable is most often negligible. There are entire game engines written in C# or Java, where every single object is heap-allocated and contains dozens of bytes of book-keeping and reflection metadata overhead. This shouldn't be a justification; the point is that the overhead in C++ is extremely small (most often pay-what-you-use), and to show that virtual functions in SFML are a real-world performance problem, we would need some benchmarks.
Also, what people often forget is that runtime polymorphism solves a real problem: deciding what to do, based on information only available at runtime. You cannot simply replace that with templates in all scenarios and still have the flexibility -- at some point you need to do dynamic dispatch, if it's through a VTable or by hand-writing it (if-else/switch/map + type ID).

Totally agree with Laurent here. The "S" in SFML stands for "simple", and I think your proposal would work against this idea. For example, look at some Boost libraries to see what the results of template-based overengineering are: a hard-to-understand API with implicit constraints, compiling for eternities, and resulting in pages of unintuitive compiler errors at the slightest user mistake.
Regarding performance, you only pay for virtual function calls when they are done indirectly (dynamic). If the compiler can determine at compile time which type to call the method on, the indirection can be optimized away. The memory overhead of the VTable is most often negligible. There are entire game engines written in C# or Java, where every single object is heap-allocated and contains dozens of bytes of book-keeping and reflection metadata overhead. This shouldn't be a justification; the point is that the overhead in C++ is extremely small (most often pay-what-you-use), and to show that virtual functions in SFML are a real-world performance problem, we would need some benchmarks.
Also, what people often forget is that runtime polymorphism solves a real problem: deciding what to do, based on information only available at runtime. You cannot simply replace that with templates in all scenarios and still have the flexibility -- at some point you need to do dynamic dispatch, if it's through a VTable or by hand-writing it (if-else/switch/map + type ID).

Just to be clear: this is about public inheritance, not virtual inheritance; these are two different (but non-exclusive) concepts in C++.
I've said virtual inheritance when what i really meant was "runtime polymorphic inheritance". Public inheritance does not imply runtime polymorphism.

Converting half of SFML and user code to templated code, just to avoid indirections (v-table calls), is just insane.
Templates increase compilation times, make you expose unecessary code, and create more dependencies between files.

To clarify : i'm not proposing to make everything a template, just transform the functions that takes virtual base classes references into an overload set and/or template functions, and avoid trying to reuse code with polymorphism by sticking common code elsewhere. A lot of these changes would in fact be very small. Look at the RenderTarget draw() method : it's just drawable.draw(*this, states), why is runtime polymorphism needed here?

Templates don't enforce any design -- how do I know the contract to implement to make my class compatible with the template functions? With a base class, everything is clear.
Fair point , but :
1/ Since templates functions are in the header anyway, you can see immediately what is being expected
2/ Pre C++20, it's pretty easy to write custom type traits and use static_assert to provide helpful error messages
3/ C++20 concepts entirely solve this issue
4/ i'm all for self-documenting code, but at the end of the day, code is code and not documentation, things can be tacitly agreed upon/commented/documented fully elsewhere (the C++ STL is a great example of this)

How do users know what template type "T" is supposed to be for such functions? The API would become such a mess.
i don't understand your point here. if we know that some functions must works for a given set of types, then we can just provides overload for this set.

std::variant
That would make things more complicated, and performances would not even be better.
This is admittedly a minor issue, but I shudder when I see C++ code using enumeration + type erasure. std::variant is fully type safe, and std::visit is easy to use

Bromeon :

Regarding performance, you only pay for virtual function calls when they are done indirectly (dynamic). If the compiler can determine at compile time which type to call the method on, the indirection can be optimized away.
Every functions using these types in the SFML API use them through their base classes, and these functions cannot be analyzed by the compilers because they are not inline. Even with full link time optimization, i'd be surprised to see them being optimized away.

Also, what people often forget is that runtime polymorphism solves a real problem: deciding what to do, based on information only available at runtime.
Yes, but my point was that SFML use polymorphic base classes without actually using them anywhere.

You cannot simply replace that with templates in all scenarios and still have the flexibility -- at some point you need to do dynamic dispatch, if it's through a VTable or by hand-writing it (if-else/switch/map + type ID).
Yes, but when you really need runtime polymorphism it's good practice to "hide" it from the rest of the codebase, because a runtime polymorphic interface depends from the context in which it is used. As in, if i really need a polymorphic RenderTarget somewhere, I can privately define an interface and a wrapper for any types passed in, (as is described in the talk linked).

Just to be clear: this is about public inheritance, not virtual inheritance; these are two different (but non-exclusive) concepts in C++.
I've said virtual inheritance when what i really meant was "runtime polymorphic inheritance". Public inheritance does not imply runtime polymorphism.

Converting half of SFML and user code to templated code, just to avoid indirections (v-table calls), is just insane.
Templates increase compilation times, make you expose unecessary code, and create more dependencies between files.

To clarify : i'm not proposing to make everything a template, just transform the functions that takes virtual base classes references into an overload set and/or template functions, and avoid trying to reuse code with polymorphism by sticking common code elsewhere. A lot of these changes would in fact be very small. Look at the RenderTarget draw() method : it's just drawable.draw(*this, states), why is runtime polymorphism needed here?

Templates don't enforce any design -- how do I know the contract to implement to make my class compatible with the template functions? With a base class, everything is clear.
Fair point , but :
1/ Since templates functions are in the header anyway, you can see immediately what is being expected
2/ Pre C++20, it's pretty easy to write custom type traits and use static_assert to provide helpful error messages
3/ C++20 concepts entirely solve this issue
4/ i'm all for self-documenting code, but at the end of the day, code is code and not documentation, things can be tacitly agreed upon/commented/documented fully elsewhere (the C++ STL is a great example of this)

How do users know what template type "T" is supposed to be for such functions? The API would become such a mess.
i don't understand your point here. if we know that some functions must works for a given set of types, then we can just provides overload for this set.

std::variant
That would make things more complicated, and performances would not even be better.
This is admittedly a minor issue, but I shudder when I see C++ code using enumeration + type erasure. std::variant is fully type safe, and std::visit is easy to use

Bromeon :

Regarding performance, you only pay for virtual function calls when they are done indirectly (dynamic). If the compiler can determine at compile time which type to call the method on, the indirection can be optimized away.
Every functions using these types in the SFML API use them through their base classes, and these functions cannot be analyzed by the compilers because they are not inline. Even with full link time optimization, i'd be surprised to see them being optimized away.

Also, what people often forget is that runtime polymorphism solves a real problem: deciding what to do, based on information only available at runtime.
Yes, but my point was that SFML use polymorphic base classes without actually using them anywhere.

You cannot simply replace that with templates in all scenarios and still have the flexibility -- at some point you need to do dynamic dispatch, if it's through a VTable or by hand-writing it (if-else/switch/map + type ID).
Yes, but when you really need runtime polymorphism it's good practice to "hide" it from the rest of the codebase, because a runtime polymorphic interface depends from the context in which it is used. As in, if i really need a polymorphic RenderTarget somewhere, I can privately define an interface and a wrapper for any types passed in, (as is described in the talk linked).

I've said virtual inheritance when what i really meant was "runtime polymorphic inheritance". Public inheritance does not imply runtime polymorphism.

True, but it has become good practice in C++ to make destructors of public base classes virtual, in the event that someone uses a base class polymorphically. The price to pay is very little compared to the potential UB havoc, especially for classes whose objects are already big.

Fair point , but :
1/ Since templates functions are in the header anyway, you can see immediately what is being expected
2/ Pre C++20, it's pretty easy to write custom type traits and use static_assert to provide helpful error messages
3/ C++20 concepts entirely solve this issue
4/ i'm all for self-documenting code, but at the end of the day, code is code and not documentation, things can be tacitly agreed upon/commented/documented fully elsewhere (the C++ STL is a great example of this)

You're basically saying: "we can almost achieve the existing behavior, if we add type traits, static_assert, concepts and extra documentation". This makes both API and implementation less simple.

Every functions using these types in the SFML API use them through their base classes, and these functions cannot be analyzed by the compilers because they are not inline. Even with full link time optimization, i'd be surprised to see them being optimized away.

If it calls virtual functions through base classes, it does so either for abstraction purposes (caller doesn't need to have the dependency of the implementation) or for dynamic polymorphism (allowing different implementations).
However, if a user has a sf::CircleShape and calls methods on it, the compiler has a very easy job of making the call static. Plus, the user is free to use a sf::Shape when he needs the abstraction.

Yes, but when you really need runtime polymorphism it's good practice to "hide" it from the rest of the codebase, because a runtime polymorphic interface depends on the context in which it is used. As in, if i really need a polymorphic RenderTarget somewhere, I can privately define an interface and a wrapper for any types passed in, (as is described in the talk linked).

But wouldn't that rather advocate a non-polymorphic adapter in the front, which calls then to a polymorphic "back-end"? This is an option, but comes with a lot of code duplication (C++ doesn't have a proper language feature to abstract delegation), and would disallow valid polymorphic use cases.

TLDR: While there's definitely room for discussing different API designs with their pros and cons, I think you overstate the problems of SFML's current API. I'm not convinced that getting rid of runtime polymorphism is a categoric improvement in the way you describe it.

I've said virtual inheritance when what i really meant was "runtime polymorphic inheritance". Public inheritance does not imply runtime polymorphism.

True, but it has become good practice in C++ to make destructors of public base classes virtual, in the event that someone uses a base class polymorphically. The price to pay is very little compared to the potential UB havoc, especially for classes whose objects are already big.

Fair point , but :
1/ Since templates functions are in the header anyway, you can see immediately what is being expected
2/ Pre C++20, it's pretty easy to write custom type traits and use static_assert to provide helpful error messages
3/ C++20 concepts entirely solve this issue
4/ i'm all for self-documenting code, but at the end of the day, code is code and not documentation, things can be tacitly agreed upon/commented/documented fully elsewhere (the C++ STL is a great example of this)

You're basically saying: "we can almost achieve the existing behavior, if we add type traits, static_assert, concepts and extra documentation". This makes both API and implementation less simple.

Every functions using these types in the SFML API use them through their base classes, and these functions cannot be analyzed by the compilers because they are not inline. Even with full link time optimization, i'd be surprised to see them being optimized away.

If it calls virtual functions through base classes, it does so either for abstraction purposes (caller doesn't need to have the dependency of the implementation) or for dynamic polymorphism (allowing different implementations).
However, if a user has a sf::CircleShape and calls methods on it, the compiler has a very easy job of making the call static. Plus, the user is free to use a sf::Shape when he needs the abstraction.

Yes, but when you really need runtime polymorphism it's good practice to "hide" it from the rest of the codebase, because a runtime polymorphic interface depends on the context in which it is used. As in, if i really need a polymorphic RenderTarget somewhere, I can privately define an interface and a wrapper for any types passed in, (as is described in the talk linked).

But wouldn't that rather advocate a non-polymorphic adapter in the front, which calls then to a polymorphic "back-end"? This is an option, but comes with a lot of code duplication (C++ doesn't have a proper language feature to abstract delegation), and would disallow valid polymorphic use cases.

TLDR: While there's definitely room for discussing different API designs with their pros and cons, I think you overstate the problems of SFML's current API. I'm not convinced that getting rid of runtime polymorphism is a categoric improvement in the way you describe it.

Off-topic: I personally don't consider std::variant and in particular std::visit() great attempts at algebraic sum types. They are OK given C++'s nature and being library-only, but they make code verbose, non-local and less expressive without named fields.
A nice solution to sum types would be Kotlin sealed classes, or even better, Rust enums + pattern matching.
Might be interesting to try an alternative type-safe approach in C++, even if it probably needs to be macro-based 🙂

Off-topic: I personally don't consider std::variant and in particular std::visit() great attempts at algebraic sum types. They are OK given C++'s nature and being library-only, but they make code verbose, non-local and less expressive without named fields.
A nice solution to sum types would be Kotlin sealed classes, or even better, Rust enums + pattern matching.
Might be interesting to try an alternative type-safe approach in C++, even if it probably needs to be macro-based 🙂

True, but it has become good practice in C++ to make destructors of public base classes virtual, in the event that someone uses a base class polymorphically.

Said who? You can't use a non polymorphic base class polymorphically. Why would anyone store a pointer to a non polymorphic base class?

You're basically saying: "we can almost achieve the existing behavior, if we add type traits, static_assert, concepts and extra documentation". This makes both API and implementation less simple.

No, I'm saying we can actually do better with littles changes, using language mechanisms that any competent C++ developer is familiar with. Functions overloading is not hard to understand. Templates are not hard to document. Even less so in C++20, where they are not even hard to constrain (and i know it's too early to migrate to C++20). That doesn't make the API harder : if you have some requirements on a type in a function template, put that in the documentation, it's not any harder to read than seeking the base class definition.

If it calls virtual functions through base classes, it does so either for abstraction purposes (caller doesn't need to have the dependency of the implementation)
dependency of the implementation

What does this means?

However, if a user has a sf::CircleShape and calls methods on it, the compiler has a very easy job of making the call static. Plus, the user is free to use a sf::Shape when he needs the abstraction.

And how is the compiler going to do that, given that the implementation of the function is in another translation unit?

TLDR: While there's definitely room for discussing different API designs with their pros and cons, I think you overstate the problems of SFML's current API. I'm not convinced that getting rid of runtime polymorphism is a categoric improvement in the way you describe it.

Don't get me wrong : I'm not saying this is a huge problem, but it's a low hanging fruit, and I've used enough API where the indiscriminate use of runtime polymorphism made them a chore to work with (if you think making everything a template is bad, try using an API where everything is a virtual function/callback) to try to push SFML in the opposite direction.
On a side note, I think there's a good amount of beginners learning C++ with SFML, and you don't want a novice programmer to think that proper generic programming and runtime polymorphism are equivalent.

True, but it has become good practice in C++ to make destructors of public base classes virtual, in the event that someone uses a base class polymorphically.

Said who? You can't use a non polymorphic base class polymorphically. Why would anyone store a pointer to a non polymorphic base class?

You're basically saying: "we can almost achieve the existing behavior, if we add type traits, static_assert, concepts and extra documentation". This makes both API and implementation less simple.

No, I'm saying we can actually do better with littles changes, using language mechanisms that any competent C++ developer is familiar with. Functions overloading is not hard to understand. Templates are not hard to document. Even less so in C++20, where they are not even hard to constrain (and i know it's too early to migrate to C++20). That doesn't make the API harder : if you have some requirements on a type in a function template, put that in the documentation, it's not any harder to read than seeking the base class definition.

If it calls virtual functions through base classes, it does so either for abstraction purposes (caller doesn't need to have the dependency of the implementation)
dependency of the implementation

What does this means?

However, if a user has a sf::CircleShape and calls methods on it, the compiler has a very easy job of making the call static. Plus, the user is free to use a sf::Shape when he needs the abstraction.

And how is the compiler going to do that, given that the implementation of the function is in another translation unit?

TLDR: While there's definitely room for discussing different API designs with their pros and cons, I think you overstate the problems of SFML's current API. I'm not convinced that getting rid of runtime polymorphism is a categoric improvement in the way you describe it.

Don't get me wrong : I'm not saying this is a huge problem, but it's a low hanging fruit, and I've used enough API where the indiscriminate use of runtime polymorphism made them a chore to work with (if you think making everything a template is bad, try using an API where everything is a virtual function/callback) to try to push SFML in the opposite direction.
On a side note, I think there's a good amount of beginners learning C++ with SFML, and you don't want a novice programmer to think that proper generic programming and runtime polymorphism are equivalent.

PS :

Off-topic: I personally don't consider std::variant and in particular std::visit() great attempts at algebraic sum types. They are OK given C++'s nature and being library-only, but they make code verbose, non-local and less expressive without named fields.

The big advantage of variant and visit is that you can work with open set of functions very easily. For example, if I have an variant V containing a window event, dispatching it onto an object O is simply std::visit( V, [&o] (auto e) { on_event(o, e); } );
Whenever O wants another event, the implementor can simply write the needed overload without having access to the calling code. This is a very powerful mechanism.

PS :

Off-topic: I personally don't consider std::variant and in particular std::visit() great attempts at algebraic sum types. They are OK given C++'s nature and being library-only, but they make code verbose, non-local and less expressive without named fields.

The big advantage of variant and visit is that you can work with open set of functions very easily. For example, if I have an variant V containing a window event, dispatching it onto an object O is simply std::visit( V, [&o] (auto e) { on_event(o, e); } );
Whenever O wants another event, the implementor can simply write the needed overload without having access to the calling code. This is a very powerful mechanism.

I think the discussion is drifting off from the original API design, the main points have been made. But to approach it from a different angle:
Do you have a C++ library in mind, which has an great API in your opinion? The C++ ecosystem is so diverse, you see everything from C with Classes to TMP insanity, thus it might be interesting to see what concretely you're thinking of 🙂
Thanks for the explanation of this std::visit() usage! It looks like Rust's if let; also this pattern seems quite cool. Those are definitely nice approaches given the state of C++, but sometimes I wonder why such an incredible amount of effort is put into language features for library writers, while ergonomics of daily usage falls short. Might just be an oversight on the other hand.

I think the discussion is drifting off from the original API design, the main points have been made. But to approach it from a different angle:
Do you have a C++ library in mind, which has an great API in your opinion? The C++ ecosystem is so diverse, you see everything from C with Classes to TMP insanity, thus it might be interesting to see what concretely you're thinking of 🙂
Thanks for the explanation of this std::visit() usage! It looks like Rust's if let; also this pattern seems quite cool. Those are definitely nice approaches given the state of C++, but sometimes I wonder why such an incredible amount of effort is put into language features for library writers, while ergonomics of daily usage falls short. Might just be an oversight on the other hand.

Do you have a C++ library in mind, which has an great API in your opinion?
I have yet to come across a library for interactive applications which takes advantage of C++ expressive power, and after trying to use more complete libraries I'm coming back to SFML/SDL because at least I can get the manual control I need (and without dependencies hell). It's a hard and open problem (providing useful abstractions over the soup that's OpenGL is alone a difficult task), but it can be done.

Do you have a C++ library in mind, which has an great API in your opinion?
I have yet to come across a library for interactive applications which takes advantage of C++ expressive power, and after trying to use more complete libraries I'm coming back to SFML/SDL because at least I can get the manual control I need (and without dependencies hell). It's a hard and open problem (providing useful abstractions over the soup that's OpenGL is alone a difficult task), but it can be done.

I believe most points have been addressed and I don't exactly see us change any of the mentioned API. In my opinion polymorphic APIs (is-a) can be easier grasp and simpler to use, than CRTP based APIs (can-use-a).
Given that this issue then faded into std::visit and std::variant discussion, I want to point to the new event API (#2668 / #2766) and extended discussions (#3014 / #3015).
Feel free to open new issues if you have specific suggestions for API changes.


how about benchmark or performance?

It's got bad performance. If measurements are important to you I encourage you to do some and share your results :)


Anti Virus detection

Hey, i made a few adjustments for post request the pw and now its great. My problem is the antivirus detection. Every time i download the exe file from a webserver or something like this, my Avira Antivirus detects it as TR/Lockscreen and locks the execution. Is there any workaround or bypass? or does anyone facing the same problem?
Greetings

Hey chikko,
I've got a few questions for you:

Does this only happen when you download the application as .exe or .zip file from the internet?
-> If you clone and build the application and then start it without download, will the same problem occur as well?

Does only your anti virus software block the application or is windows blocking it as well?
-> Try turning Avira off and then execute it.

Did you try the same procedure on different PCs, if yes what did happen?

There is a thing called Windows Defender SmartScreen.
If you download a file fromthe internet, mail, etc. or unzipping a file with the windows zip-tool will cause the application to be marked as "Unknown" using a Zone-Identifier.
Avira might do a similar thing.
In that case you need to find a way to distribute the software using a different way.
Like a bad usb
Another possible way to solve this problem could be to put the .exe-file into a different archive then .zip, like .rar or .7zip and unpacking these zip files with a different compressing tool then the windows .zip-Tool.

Hey Noctus, I've now played around a bit, adjusted a few things and recompiled several times. Somehow that solved the problem. I can now easily download the script via powershell via rubber ducky command and run it without a problem with virus protection. Now another question: I already had the original SharpLocker script from Pickfordmatt. The old lockscreen (exe) started within a second of clicking. Your version, however, takes 8-10 seconds on my systems until the lockscreen appears. Is this normal or do I still have a mistake somewhere? I compile / build the app as normal with visual studio or directly via the msbuild command line. The waiting time occurs with DEBUG as well as with RELEASE build.

Which version are you using?
We had some performance issues before this commit:

https://github.com/Lokk-In/SharpLocker-2.0/commit/a0856d1e73ca69772f3177bd9836e7eb8608b05a in the master branch
https://github.com/Lokk-In/SharpLocker-2.0/commit/f419caf1bd19b305c2679bddedaf6722bee15045 in the develope branch

Make sure you are using a version that is higher or even then these commits.
On the systems I have tested the software on, it took no longer then 1 - 2 seconds to load.
If the problem still exitsts set a break point into the Intialize() function and check, using the F10 key, which step(s) is causing the problem. InitializeUserLabel() is known for taking some time.
        private void Initialize()
        {
            InitializeConfiguration();
            InitializeLanguage();
            InitializeMisc();
            InitializePasswordTextbox();
            InitializeKeyCombinations();
            InitializeUserLabel();
            InitializeUserIcon();
            InitializeBackground();
            InitializeBadStuff();
            InitializeOtherScreens();
            InitializeOtherUsers();
            InitializePasswordErrors();
        }

Original issue was resolved. Moving startup speed issue to new issue


Update GitKraken to v7.0.0

Update to latest version 7.0.0 with new exe hash.
Microsoft Reviewers: Open in CodeFlow

You should submit a new manifest for a new version so users can install a specific version.

You should submit a new manifest for a new version so users can install a specific version.

@VIKTORVAV99 that would be cool but all the download links point to the exe of the latest version. Is there a suggested work around for this?

That's a tricky one, I'm worried that updating the manifest could break scripts that pin a specific version.
This probably isn't the case yet since winget is pretty new but I think submitting a new manifest might be the best way even if they point to the same end version.

Yeah, it is a tricky one. I have another PR(#501) with the same situation where I asked these questions with possible solutions. Waiting on a reply from the reviewers for the best approach.

I just realized I commented the same thing on that one... Hehe...
But yeah let's wait for the reviewers.


ucum-essence.xml

@brynrhodes
We are incorporating the UCUM validation code into our installation of the CQL-to-ELM translator. During incorporation of the UCUM validation code, we noted that the ucum-essence.xml file is not available. To compile correctly, the CQLTranslator class is requiring the usum-essence.xml to be available:
ucumService = new UcumEssenceService("/ucum-essence.xml");
Should this file be physically part of the code, or is it intended to have users of this code periodically download the ucum-essence.xml from UCUM - http://unitsofmeasure.org/ucum-essence.xml?

The UCUM package should include the ucum-essence.xml content as a resource, so that code should just work (it does in our usage). Is there a specific error you are seeing when you try this? Are you referencing the same UCUM package that we do in the translator?

There is a comment from Grahame Grieve at the top of the UcumEssenceService class in the UCUM package:
/**
 * implements UCUM services. Applications must provide a copy of
 * ucum-essence.xml as either a stream or a file name to create
 * the services.
 *
 * the provided ucum-essence.xml must be released on 25 Apr 2008
 * or more recent. Note that if the ucum-essence.xml file does not
 * contain a release date on an attribute of the root element, it
 * is not more recent than this date (Gunther added it on this date for
 * this usage, thanks)
 *
 * See UcumService for documentation concerning the services this class provides
 *
 * @author Grahame Grieve
 *
 */

In looking through the code on github, the ucum-essence.xml cannot be found.
Is this resource getting added on the fly through Gradle?

The ucum-essence.xml file is included as a resource here, so it gets built into the Ucum-java package directly.
To confirm, I tried this again and sure enough, I'm seeing the same thing you are now. Not sure how that happened, this was validated prior to the release. I'm marking this as a defect and correcting now.

Release 1.2.20 should address this issue, please let me know if it's still occurring.


sample_text.txt is broken (404 ERROR)

❓ Questions & Help
When I try to access the sample_text,txt file at this link, I find an nginx 404 server error.
https://huggingface.co/pytorch-transformers/samples/sample_text.txt

This one is now in the tests at: https://github.com/huggingface/pytorch-transformers/blob/master/pytorch_transformers/tests/fixtures/sample_text.txt
We'll fix the doc, thanks!


Error blank space in command

Hi team,
I found an error blank space in command,
Could you please check here:
https://learn.microsoft.com/en-us/azure/automation/troubleshoot/update-agent-issues-linux#hybrid-runbook-worker
To fix the issue, run the following command:
sudo su omsagent -c 'python /opt/microsoft/omsconfig/Scripts/ PerformRequiredConfigurationChecks.py
it should be:
sudo su omsagent -c 'python /opt/microsoft/omsconfig/Scripts/PerformRequiredConfigurationChecks.py
Thank you so much!
Phina

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 045e6cd9-fcd2-1d75-0852-5177ec7d0197
Version Independent ID: 897d553a-8005-a755-316e-87dbe957a4bd
Content: Troubleshooting Linux update agent issues in Azure Automation
Content Source: articles/automation/troubleshoot/update-agent-issues-linux.md
Service: automation
Sub-service: update-management
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@phinawang We have verified and updated the document as required. The change would go live in less than 24 hours. Thanks again!


Update manifest for v11 support

Foundry and the PF2e system flashes a warning saying your module is unsupported. I believe this is just because the verified version needs changing:
  "compatibility": {
    "minimum": 10,
    "verified": "10.120"
  },

to:
  "compatibility": {
    "minimum": 10,
    "verified": "11"
  },

Update to v12


Error occured when run script "npm i" in example of "create-react-app"❌

Describe the bug
Error occured when run script "npm i" in example of "create-react-app"❌
To Reproduce
just CD into "examples\create-react-app" and run "npm i"┭┮﹏┭┮
Expected behavior
packages installed smoothly, then I can run the example.😄
Screenshots

Environment (please complete the following information)

OS: Windows 11
Browser: chrome

Additional context
other examples may exist this problem(〃＞目＜)

@cainull Oh man, likely this issue is related to your folder name containing non-ASCII characters. Let me try to reproduce it.
In the meantime, you can work around by running:
npm install --ignore-scripts
# or
yarn install --ignore-scripts

Thanks for replied! I'm careless🤭, I try to move the project to other folder with full ASCII path, then it works.
but if containing non-ASCII characters, error still occured when I run npm install --ignore-scripts .
so, the temporary solution is clone the project to the full-ASCII characters path, then yarn intsall

@cainull Oh, interesting. It’s definitely an issue with Jest Preview. I will try to reproduce on a Windows (unluckily I don’t have one with me right now). I tried on macOS but it works fine.
Can you copy the full path name? I will try with yours.
Please keep this issue open. After fixing it, can you help to verify it?
Thank you very much.

it works when I run scripts npm install in the root path(./jest-preview), but when I cd into exmaples/create-react-app then run this scripts, it still won't work.

Oh, it's my present! I will verify it if bug fixed. 😄

Hi @cainull. Can you try to verify if the issue is resolved after running:
npm install<EMAIL_ADDRESS>--save-dev
# or
yarn add<EMAIL_ADDRESS>-D

Thanks.

OK. I'll do it right now. 👍

Thank you @cainull. Please let us know if the issue has been resolved.

yeah. This problem has been solved😄.

but I'm curious about its reason

@cainull Thank you very much for your confirmation.
The issue is this line of code
// pacakge.json
"postinstall": "bash -c \"[[ '$INIT_CWD' == '$PWD' ]] && echo Inside Jest Preview. Do not clear Cache. || jest --clearCache || echo\"",

Since in some cases, we need to clear the Jest cache to avoid  CSS and images getting cached by the old code transformers. So we have a postinstall script to automatically clear Jest cache after installing jest-preview. The script is written in bash. However, this script is not stable in some circumstances (e.g: folder name is non-ASCII on windows).
I resolve it by moving this logic into a separate javascript file. You can read more in this commit https://github.com/nvh95/jest-preview/commit/7cf6c22971fd051eeac2d2b3c3fe28c0ac18f3fc#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R52

@cainull I'm closing this issue since it has been resolved. Feel free to keep discussing more if you want to know anything else.

@all-contributors please add @cainull for bug

Thanks for explanation! I would keep focus on this project. 😄

@cainull Thank you. Share me your project if you integrate jest-preview. Let me know if you have any issues when doing it.


Improve commenting feature

:tada: This PR is included in version 0.3.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


False Positive at *http.Request.URL.Query().Get('foo')

This issue belongs to the following build:
go version -m C:\src\go\bin\nilaway.exe

C:\src\go\bin\nilaway.exe: go1.21.3
        path    go.uber.org/nilaway/cmd/nilaway
        mod     go.uber.org/nilaway     v0.0.0-20231117175943-a267567c6fff      h1:MSLkMoDm4RpwG6QRJPaiNK4dAnFMX81SmEaRBSs/zws=

NilAway will report the following output:
-> C:\go\src\net\url\url.go:1116:9: result 0 of `ParseQuery()` lacking guarding; returned from `Query()` in position 0
-> C:\src\go\src\some_package\server.go:129:16: result 0 of `Query()` called `Get()`

on the following line (r is type *http.Request):
foo.Bar = r.URL.Query().Get("baz")

This is the runtime callstack:
// Query parses RawQuery and returns the corresponding values.
// It silently discards malformed value pairs.
// To check errors use ParseQuery.
func (u *URL) Query() Values {
	v, _ := ParseQuery(u.RawQuery)
	return v
}

However ParseQuery() will return a make(Values) non-pointer value.
// Values maps a string key to a list of values.
// It is typically used for query parameters and form values.
// Unlike in the http.Header map, the keys in a Values map
// are case-sensitive.
type Values map[string][]string

// Get gets the first value associated with the given key.
// If there are no values associated with the key, Get returns
// the empty string. To access multiple values, use the map
// directly.
func (v Values) Get(key string) string {
	vs := v[key]
	if len(vs) == 0 {
		return ""
	}
	return vs[0]
}

// ParseQuery parses the URL-encoded query string and returns
// a map listing the values specified for each key.
// ParseQuery always returns a non-nil map containing all the
// valid query parameters found; err describes the first decoding error
// encountered, if any.
//
// Query is expected to be a list of key=value settings separated by ampersands.
// A setting without an equals sign is interpreted as a key set to an empty
// value.
// Settings containing a non-URL-encoded semicolon are considered invalid.
func ParseQuery(query string) (Values, error) {
	m := make(Values)
	err := parseQuery(m, query)
	return m, err
}

It seems expected. It's a GuardMissing report and I found the comment.

// For example, from a read to map without the v, ok := m[k] form, thus always resulting in nilable
// regardless of m's deep nilability

@xwjdsh This isn't related to m[k] but earlier: nilaway thinks that r.URL.Query() might be nil (which is never the case as documented in the ParseQuery doc) but it is anyway totally correct to call a method on a Values(nil) and the Get method would work anyway.
Also v := m[k] never returns nil for v when m is of type map[T]string: the zero value if k is not found is "".

BTW this is a duplicate of #111, so I'm closing this. Let's continue the discussion there!

Oops, meant to close another issue as duplicate. Sorry for the noise!


Improve search box

Update JSUI to V2
Move to Coveo Cloud V2
Fix FieldSuggestions on titles
Add ML query suggestions
Implement same suggestion styling as docs.coveo.com

Somewhere we can see the result?

View the result: https://amoreaucoveo.github.io/source.coveo.com/


[test-framework] Remove tagging/label support.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: nmittler, sebastienvas
Assign the PR to them by writing /assign @nmittler @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Strictly speaking, no. I think, in general it is a useful pattern, but mostly I was being sentimental. :)
Removed.


read_halocat

In doc strings read_halocat is not used properly in e.g. RockstarHlistReader.  I think this is because it now expects columns_to_convert_from_kpc_to_mpc to be set.

This is resolved by #411


fix: type of disabled trigger and beforeSeconds field

try to catch up upstream change in my user config files.
Find some problems:
  timelineTriggers: [
    {
      id: 'T8 timeline example',
      regex: /11/,
      infoText: () => 'hello',
    },
   {
      id: "A Trigger I don't want",
      disabled: true,
    }
  ],
  triggers: [
    {
      id: 'E12S Double Aero Finder',
      disabled: true,
    },
]

first one can't compile because tsc says it missing beforeSeconds property.
Don't know why it's required in timelineTrigger.
the second and third can't compile because tsc says it missing regex or netRegex property.
This PR set beforeSeconds optional and add a union on trigger type which make it can be disabled.
I'm not sure how do you think about this union.
I think built-in triggers won't have any disabled trigger, but it could be in user triggers, so I'm not sure it's ok to put this union here.
But it's not likely to have another trigger set type called something like UserTriggerSet
{
  triggers?: (NetRegexTrigger<Data> | { id: string; disabled: true })[];
  timelineTriggers?: (TimelineTrigger<Data> | { id: string; disabled: true })[];
}

I think built-in triggers won't have any disabled trigger, but it could be in user triggers, so I'm not sure it's ok to put this union here.

This is the difference I am trying to express with NetRegexTrigger (a built-in cactbot trigger, with stricter type defintiions) and LooseTrigger (a user trigger, which has everything optional).   So, I think LooseTriggerSet already covers what you're proposing in UserTriggerSet, unless I'm misunderstanding?
I'm not sure I understand what you're trying to do with this:
    {
      id: 'E12S Double Aero Finder',
      disabled: true,
    },

...is this a common pattern for you?

So, I think LooseTriggerSet already covers what you're proposing in UserTriggerSet, unless I'm misunderstanding?

LooseTriggerSet is not a generic type, data didn't have any type information except RaidbossData

So, I think LooseTriggerSet already covers what you're proposing in UserTriggerSet, unless I'm misunderstanding?

LooseTriggerSet is not a generic type, data paramater didn't have any type information except RaidbossData

LooseTriggerSet is meant to be used by PopupText which doesn't know anything about the typing of data other than RaidbossData.  It's not intended to be used in trigger files itself, if that makes sense.
My thought is that if you are writing triggers in TypeScript, you should use the stricter NetRegexTrigger and TriggerSet types.  If cactbot is handling user triggers in PopupText, it should use the LooseTriggerSet which makes fewer assumptions.

My thought is that if you are writing triggers in TypeScript, you should use the stricter NetRegexTrigger and TriggerSet types.

Yes, that's what I want to do.
And met this problem when disabling triggers.
Maybe I should maintain my own copy of TriggerSet?

I'm not sure I understand what you're trying to do with this:
...is this a common pattern for you?

This is what I'm trying to ask above.  What is the goal of disabling a trigger that isn't doing anything?  What are you trying to do?

Here is another example:
I have a TEA trigger for limit-cut.
This limit-cut trigger overwrite built-in limit-cut trigger, and with some other solution different with built-in trigger.
Then there is a new trigger TEA Wormhole Puddle, which I have implemented in my limit-cut trigger, so there is no need to enable the built-in version.

Oh!  Thank you for the explanation; I just couldn't understand why you wanted this.  I think I had imagined that most people would disable triggers through the config UI, but it is more clean to disable them in the trigger file in some ways.
That seems reasonable to me.  My one suggestion is can you make a DisabledTrigger type and use that instead of repeating {id, disabled}?

Yes, you just remaid me that the most important reason: these triggers didn't need to be disabled if this trigger file is not loaded, so they should be disabled in the trigger file not config UI.
I'll add that.

(Sorry for my confusion! Thanks for patiently explaining it to me!)

re: beforeSeconds, I'm working on a PR to convert the 00-misc/test.js file to typescript and there are timeline triggers there that just flat out don't have beforeSeconds, and there's code in place to default to 0 if not specified, so that seems correct.


Is it possible to get an updated & optimized JAVA implementation ?

Hi,
I'm using bountycastle lib which purpose an implementation of Blake3, but after doing some benchmarking
it's not optimized (2 x slower than SHA3 -256)  (https://www.bouncycastle.org/releasenotes.html)
Any suggestions of other java library ? thanks a lot.
King regards,
Robert.

The magic term to google here is "JNI", which is when Java code calls into C code or similar. When I google "blake3 jni", this project shows up: https://github.com/alephium/blake3-jni. It doesn't look like it's been maintained since 2020, so I'd be careful about depending on it in any important codebase, but if you want to experiment with it there's a chance it still works... (Our underlying C API hasn't had any backwards-incompatible changes, so you might want to start by updating the vendored copy.)


feat: gene info api endpoint

#TICKET_NUMBER

Reviewers
Functional:
@MDunitz
Readability:
@seve
Changes

add
remove
modify

QA steps (optional)
Notes for Reviewer

Will this be its own flask APP or are we adding it to the existing?

@Bento007 Thank you for looking at this Trent. Currently in the process of making the changes you suggested and writing unit tests. I believe that this will be its own API endpoint added to the existing flask APP, similar to the WMG and curation APIs. Please let me know if there's anything else you notice I should fix or change in the PR!


Security PIN is not asked every time when a user turns ON the “Data Saver” toggle.

Frequency: 100%
App version:  Android internal Celo staging v1.5.2 (104794304)
Repro on: Samsung Galaxy A5 (7.0), Samsung Galaxy A8+ (8.0.0)
Testing Account:<PHONE_NUMBER>/backup Key
Repro Steps:

Launch the app and login with testing account.
Tap on Cog icon.
Tap on Data Saver option
Turn ON the data saver toggle
Tap on “I understand” button on “Beware of restart” pop up.
Observe.

Investigation:

Sometime it will ask a security PIN after turning on the toggle.

Current Behavior: Security PIN is not asked every time
Expected Behavior: Security PIN should ask every time when user turn ON toggle.
Impact: User  is able to data saver toogle ON without Security PIN
Attachment: Android_Random_DataServar_SecurityPINIssue.mp4 (Bug observed at 06 sec)

@nityas do we want to prompt for the pin when toggling between data saver and pin on app start? Right now I don't think we require the user to the enter their pin for either action.

I don't think we need to... I wonder if this happens intermittently bc of geth access and the intermittence (rather than absence) of the prompt is the issue?

Gotcha. I don't think Geth access requires the pin code. Probably safe to close this for now as I haven't been able to repro.


[FAQ] Why 'pytorch3d' instead of 'pyrender'?

I am new to PyTorch and ROMP works fine with 'pyrender' for me on Windows 10 and Python 3.9.7.
So why should i use ROMP with 'pytorch3d' instead?

pyrender can't run on server where we train ROMP. For running ROMP on remote server, I replace pyrender with pytorch3d.Get Outlook for Android

Thank you!
Let's add an note to https://github.com/Arthur151/ROMP/blob/48d599e2993e79dccb3323a833b3a24c9e633100/docs/installation.md

Thanks for the great suggestions. I have added it at here