Improve find all references (for tree shaking)

TypeScript Version:  2.9.2

Search Terms: references, rename, incorrect, duck-typing
Code
class A {
    dispose(): void {
        console.log(`disposed!`);
    }
}

interface IDisposable {
    dispose(): void;
}

var a: IDisposable;
a = new A();
a.dispose();

Expected behavior:
Finding all references of dispose on the last line should return the method called dispose in class A, even if there is no explicit implements IDisposable heritage clause.
Actual behavior:
Finding all references of dispose returns only two results.
Related Issues:
Renaming the dispose on the last line (via F2 in VSCode) suffers from the same issue and ends up introducing a compilation error.

If you believe the user-facing find all references should not be changed, can we at least have a good working find all references in the typescriptServices.ts? I'm asking because I wrote a tree shaker for the Monaco Editor (the editor is extracted from VSCode's sources and a lot of utility methods or members of classes are not used -- running the tree shaker results in a 14% size reduction of the minified editor). The tree shaker is here and it is a shame that I need to maintain a file with fake references partly because find all references does not return all the references.
Since I have your attention, I wanted to bring up that fixing the above issue allows one to pretty-easily build a tree shaker. It would be great if you would consider adding tree shaking inside the compiler, it doesn't seem that difficult to implement and perhaps other projects besides the Monaco Editor would benefit from it.

It seems like you would need to do an analysis of every pair of types to determine what's assignable to what. We wouldn't be able to do that performantly in an editor, but we could expose that ability in the API -- see #9879.
By the way, if you are doing an anlysis on the entire program, doing find-all-references at every location is probably not what you want -- it would probably be faster to just walk over the tree, get the symbol at every location, and add an entry to the result.

The fact that an interface IDisposable has a property called dispose that is structurally equivalent to a another property on another type A is not sufficient to deem it a reference. you also need to know if an instance of type A has ever been assigned to or passed as an argument to call that expects a type IDisposable.
That analysis is not cheep. to do this correctly, the compiler first needs to find all types that have 1. a property with the same name, and 2. are structurally compatible to the one we are searching for, then 3. find all references of that type, and see if ever an instance of the type being searched for was ever compared/assigned/extended to the other type.
I am not saying this is not doable, i am saying find-all-refs is not the place for it.
If you are interested in optimization, property renames, and/or tree shaking, i suggests you talk to @rbuckton and @DanielRosenwasser offline, they would have more info for you.
The find all refs suggestion is already tracked by https://github.com/Microsoft/TypeScript/issues/6388.

@andy-ms

It seems like you would need to do an analysis of every pair of types to determine what's assignable to what.

I'm not exactly asking for that. Note that I included the statement a = new A();. I am not asking for find all references to find the A.dispose() method if that assignment statement is missing.
I am a compiler noob, but IMHO as part of type checking you must be checking if the type A is assignable to IDisposable using the rules of duck-typing. When this happens, you could mark the type A and add an "implicit heritage clause" to IDisposable.
In other words, once the type checker sees a = new A();, where a is IDisposable, it could treat the entire code-base as if the heritage clause were explicit:
class A implements IDisposable { // note the explicit heritage clause
    dispose(): void {
        console.log(`disposed!`);
    }
}

interface IDisposable {
    dispose(): void;
}

var a: IDisposable;
a = new A();
a.dispose();

By the way, if you are doing an anlysis on the entire program, doing find-all-references at every location is probably not what you want -- it would probably be faster to just walk over the tree, get the symbol at every location, and add an entry to the result.

I'm happy you bring it up. The tree shaker I wrote has two variants: shaking only of top level class declarations, interfaces, functions, enums or exported variables, or also shaking of unused members.
In the simpler case of shaking only top level class declarations, the algorithm uses a simple queue of nodes. Each visited node is marked, and its children are also walked. For each child node that points to a symbol, the declaration of that symbol is added to the queue, etc. It is surprisingly simple and works well, and does not need find all references. I had to borrow -- :) -- some of the go to definition code from you, as the symbol sometimes points to the local import (which I need to mark and then jump to the actual definition), or the symbol is weird in the case of literals with properties with the same name (e.g. { foo: foo } vs { foo }, etc).
In the more complex case of shaking also members, the algorithm uses two queues, one queue is black and another queue is gray. The problem here like in the above code-base is that no symbol will end up pointing to A.dispose, as the invocation in the statement a.dispose will have a symbol which points to IDisposable.dispose. The trick here is whenever hitting a symbol which is an interface or class member, to mark the name node (and the heritage clause) of the interface/class as black and the member as black, and then run find all references on the member. All the references are added to a gray queue. The reason is: simply because a class implements IDisposable does not mean its dispose method should survive tree-shaking, as the class could never be instantiated. When the black queue becomes empty, gray nodes that appear in classes/interfaces which have a black node (most likely the name) are moved over to the black queue.
In other words, it covers the case:
interface IDisposable { dispose(): void }
class A implements IDisposable { dispose:() {} }
class B implements IDisposable { dispose:() {} }
var a: IDisposable = new A();
a.dispose();

where the class B should be removed when tree-shaking, even if B.dispose is found while searching for references of IDisposable.dispose via a.dispose().
Here is the current implementation which pretty much works (I use it to ship the Monaco Editor) -- https://github.com/Microsoft/vscode/blob/master/build/lib/treeshaking.ts
The reason I was reaching out is because I found it so surprisingly easy to build a top level declaration tree shaker and it would be also pretty easy to tree shake members if find all references could find cases like this. One possible solution is for type-checking to record via "implicit heritage clauses" duck-typing assignments.

@mhegazy
:+1: to close this bug in favor of #6388 .
I am a compiler noob, so take my suggestions lightly :). But from an implementation point of view the fact that one type T1 was checked and found "duck-typing compatible" with another type T2 could be something the checker records in the "primary type-checking inner loop". Perhaps you already do this as an optimisation today? i.e. if the type checker needs to check the same situation again, will you spend CPU cycles to do so or is this cached. e.g.
class A { dispose() { } }
interface IDisposable { dispose(): void; }

var a: IDisposable;
var b: IDisposable;
a = new A();
b = new A();

When checking a = new A() it seems reasonable to mark somehow the class A as being "duck-typing" assignable to IDisposable. When checking b = new A(), this cache can be used and the previous result can be trusted. Finally, this cache is something that could be used by find all references.

I just wanted to bring up how fixing this issue can IMHO give you a pretty easy implementation of tree shaking... I've also only tried this tree-shaking code on VSCode's codebase so perhaps the algorithm has flaws and is not correct over other cases.

@andy-ms @mhegazy Did you get any chance to read through my previous comment. Specifically this part:

[...] from an implementation point of view the fact that one type T1 was checked and found "duck-typing compatible" with another type T2 could be something the checker records in the "primary type-checking inner loop". Perhaps you already do this as an optimisation today? i.e. if the type checker needs to check the same situation again, will you spend CPU cycles to do so or is this cached [...]

Is there a straight-forward way in the type checker to remember when a certain type is checked for "duck-typing compatibility" with another type? I could then attempt to access this information in the tree shaker.
Thanks!


S5: Remove address requirement for purchase and authorize

@duff quick fix for the S5 gateway. Add the customer info if it's passed in the options hash via billing_address or just address. Otherwise, don't add it to the XML.

@davidsantoso I'm thinking we'd still want the email and ip to get sent, no?

Wouldn't you want this a few lines up instead? Or do you really want to omit everything

Oh hai @duff, haha.

@davidsantoso Can you add a remote test that confirms the lack of address is acceptable?

@duff @j-mutter good call. Should there be a guard statement on Phone as well since that's part of the address hash?
@j-mutter yep I'll add one now.

Good timing @j-mutter !
It is interesting that the generator includes billing_address by default in the @options in the setup method of the remote tests.  I do wonder if the default set of options ought to be more minimalist and then have separate remote tests where options like billing_address are included.

@davidsantoso :+1: on guards where needed there.

We've been trying to move from the generic address key to billing_address for a while now, and it should probably stay. I would imagine most gateways will want it, and the ones where it's optional are the outliers.

It is helpful when testing for adding addresses to a transaction :wink: This was probably more my issue in not having robust enough of tests.

@duff @j-mutter added two additional tests for transactions without addresses and refactored the guard clause on the customer info XML generation.
Let me know if you guys have anymore thoughts/concerns!


Issue 186

Closes #645

Still some work left on the body of the newsletter. 4 TODOs. :)

@jeroenleenarts sorry forgot to push my changes :)

Thank you, everyone, for your help! :)


Spool the result to disk instead of memory

Hi,
An issue came when I tried to sync 6 months of zabbix historical data.
The sql query for history_uint give several billions rows.
I think that it could be a good option to be able to spool the result to a file instead of memory.
In my case it's not working and OOM Killer kill the process.

Or limit to a number of records and keep the last record timestamp in the json file could be an option.
In that case it would not consume all the memory and it will synchronize by bucket

@menardorama, could you please check if it's working like needed.
You have now the possibility to configure the rows per batch for each table (input/output).

The issue with the proposal fix you provide is that it won't reduce the DB footprint of those queries.
I would ssuggest that instead of defining a limit, it would be great to define a range of time .
In that case if you are using partitionning of the historical tables, you would benefit of the partition prunning mechanism.
Is this is something you would accept ?
Instead having a limit, it's just that you fetch the data with ##ENDDATE## = ##STARTDATE## +

Have you created the indexes as specified in the readme file ?
For sure it reduces the DB footprint as you scan only a subset of the tables.
Also, I'm using partitioning (not real partitioning with postgresql like it is done in MS SQL Server) and it works as it has to work in my side.
The solution is designated like an ETL. With SSIS from Microsoft, you can define the input/output rows per batch and data are extracted and loaded like this.


Make WrapToObject optional

Java doesn't need it, as all declarations should end up as static members of their outer class.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Codecov Report

Merging #493 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   80.63%   80.74%   +0.10%
==========================================
  Files          78       78
  Lines        5035     5047      +12
  Branches      130      147      +17
==========================================
+ Hits         4060     4075      +15
+ Misses        975      972       -3

Impacted Files
Coverage Δ

...ala/com/twilio/guardrail/terms/LanguageTerms.scala
0.00% <ø> (ø)

...scala/com/twilio/guardrail/ProtocolGenerator.scala
98.18% <100.00%> (ø)

...o/guardrail/generators/Java/JacksonGenerator.scala
91.52% <100.00%> (+0.01%)
:arrow_up:

...om/twilio/guardrail/generators/JavaGenerator.scala
74.47% <100.00%> (+1.75%)
:arrow_up:

...m/twilio/guardrail/generators/ScalaGenerator.scala
87.05% <100.00%> (ø)

...io/guardrail/generators/Scala/AkkaHttpHelper.scala
66.66% <0.00%> (ø)

...il/generators/Java/DropwizardServerGenerator.scala
98.07% <0.00%> (ø)

...ail/generators/Scala/AkkaHttpClientGenerator.scala
94.32% <0.00%> (+0.08%)
:arrow_up:

...ail/generators/Scala/AkkaHttpServerGenerator.scala
92.10% <0.00%> (+0.08%)
:arrow_up:

...main/scala/com/twilio/guardrail/core/Tracker.scala
93.18% <0.00%> (+0.15%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2c199...a3d3e65. Read the comment docs.

Added a test.  It's a little lame as it just makes sure the final object is constructable and the nested classes are in the right place, but it'll do the job for now.

Ok nevermind I made the test a little less lame and a little more useful.

Not sure what's up with the tests.  They did finish and did complete successfully, but GH seems to not know about that.


tensorflow 2.0 got following messages

tensorflow 2.0
2.2.0
2020-06-26 12:33:16.881206: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcuda.so.1
2020-06-26 12:33:16.915893: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1561] Found device 0 with properties:
pciBusID: 0000:0b:00.0 name: TITAN Xp computeCapability: 6.1
coreClock: 1.582GHz coreCount: 30 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 510.07GiB/s
2020-06-26 12:33:16.916635: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1561] Found device 1 with properties:
pciBusID: 0000:42:00.0 name: TITAN Xp computeCapability: 6.1
coreClock: 1.582GHz coreCount: 30 deviceMemorySize: 11.91GiB deviceMemoryBandwidth: 510.07GiB/s
2020-06-26 12:33:16.916743: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.916777: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcublas.so.10'; dlerror: libcublas.so.10: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.916811: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcufft.so.10'; dlerror: libcufft.so.10: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.916842: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcurand.so.10'; dlerror: libcurand.so.10: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.916874: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcusolver.so.10'; dlerror: libcusolver.so.10: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.916904: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcusparse.so.10'; dlerror: libcusparse.so.10: cannot open shared object file: No such file or directory
2020-06-26 12:33:16.918834: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudnn.so.7
2020-06-26 12:33:16.918850: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1598] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2020-06-26 12:33:16.919060: I tensorflow/core/platform/cpu_feature_guard.cc:143] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-06-26 12:33:16.942414: I tensorflow/core/platform/profile_utils/cpu_utils.cc:102] CPU Frequency:<PHONE_NUMBER> Hz
2020-06-26 12:33:16.943646: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fdf28000b60 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-06-26 12:33:16.943667: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
2020-06-26 12:33:16.945443: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1102] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-06-26 12:33:16.945458: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1108]
Found 2000 images belonging to 2 classes.
Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

@SlowMonk,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here.
Also if you are using TensorFlow 2.0, please upgrade to the latest version of TensorFlow v2.2 and check if you are facing the same issue. Thanks!

Also, please take a look at this comment from a similar issue and let us know if it helps. Thanks!

@SlowMonk the segmentation fault is not caused by the warnings you offered. Please provide fully filled issue template and minimal code to reproduce.


Add dataset: mps_manuscript_handwriting_dating

A URL for this dataset
https://doi.org/10.5281/zenodo.1194357
Dataset description
This is a dataset

with images of medieval charters for handwriting-style based dating of manuscripts.

There are other similar datasets for this task so this might also be useful in combination with other datasets.
Dataset modality
Image
Dataset licence
Creative Commons Attribution 4.0 International
Other licence
No response
How can you access this data
As a download from a repository/website
Confirm the dataset has an open licence

[X] To the best of my knowledge, this dataset is accessible via an open licence

Contact details for data custodian
<EMAIL_ADDRESS>

#self-assign


add traefik proxy and frankenphp service as alternative to fpm

Pull Request
What changed?
The combination of nginx and php-fpm containers has been can be replaced by FrankenPHP.  Additionally, an optional local proxy service is included in docker/traefik.
Why did it change?
It's much easier to maintain and work with in the long run.  The traefik proxy makes things super convenient and provides ssl termination in local dev (albeit with self-signed certs).
Did you fix any specific issues?
none
CERTIFICATION
By opening this pull request, I do agree to abide by the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity.
Finally, I agree that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.
(Please check a box below)
[X ] I agree
[ ] I do not agree

Hey @chuckadams can you resolve the conflicts?
Also, want to ask how this looks in respect to the document I wrote this morning. https://governance.aspirepress.org/guidelines/doors

Conflicts are fixed, and as for the Doors, Jim will always live on in my h--oh, those doors: this PR is all about web servers, and the fact that we're nimbly switching between two different servers should illustrate that it's not an inescapable island by any means.
The traefik proxy is a little more "proprietary", but only in needing to add a few labels to a container to make it work.  If you're not running traefik, those labels are harmless.  One also needs an internal network for the proxy to talk to its backend, but that will be the case with any proxy.  Traefik is used all over the place as an ingress controller in many k8s setups, so it's widespread.
So I think we're still good as far as platform agility goes.


Added campaign types entity to swagger

Added campaign types entity to swagger.

@PepiPetrov I've cherry-picked the commit https://github.com/podkrepi-bg/api/commit/7cfa04acd7f5d80c0f1067b506ca981fb0b4ab4c to master. Consider this PR merged


boards->info always return false

i call $bot->boards->info(username, boardname) using correct params, however it always returns false.

@rabintang , can you give a code snippet? I have just checked and it works:
print_r($bot->boards->info('familyfinder', 'national-parks-in-the-usa'));

$info = $bot->boards->info("rabintang", "Oakley Sunglasses");

@rabintang fixed in version 5.3.8, please update

@seregazhuk yes, it works when i update. however, i maybe has a bug:
protected function getProvider($provider) in ProvidersContainer.php should be public?

@rabintang oh, sorry about that. Now fixed in 5.3.9


CB-11868 Create DistroX internal API for COD usecase

See detailed description in the commit message.

@lnardai I would solve it in this ticket so that we don't need to think about it later which can be a nightmare.


task 27

task 27

@hblife1234
Task -4
Code verified.  Add annotations
Task -5
Code verified.  Add annotations
Task -6
Code verified.  Add annotations
Task -7
Code verified.  Add annotations
Task -8
Code verified.  Add annotations
Task -9
Code verified.  Add annotations
Task -10
Code verified.

@hblife1234
Task -11
Code verified.  Add annotations
Task -12
Code verified.  Add annotations
Task -13
Code verified.  Add annotations
Task -14
Code verified.  Add annotations
Task -15
Code verified.  Add annotations
Task -16
Code verified.  Add annotations
Task -17
Code verified. Add annotations
Task -18
Code verified.  Add annotations
Task -19
Code verified.  Add annotations
Task -20
Code verified.  Add annotations

@hblife1234
Task -21
Code verified.  Add annotations
Task -22
Code verified.  Add annotations
Task -23
Code verified.
Task -24
Code verified.
Task -25
Code verified.  Add annotations
Task -26
Code verified. Provide a correct  guess message to users
Task -27
Code verified.  Add annotations


The requested module '/_nuxt/node_modules/drawflow/dist/drawflow.min.css?t=1706078236271' does not provide an export named 'default'

@jerosoler
I am using the Drawflow library in my Nuxt 3 application with composition API but for some reason, I get the following error:
The requested module '/_nuxt/node_modules/drawflow/dist/drawflow.min.css?t=1706078236271' does not provide an export named 'default'

This is because I am importing the styles from the Drawflow library Node modules:
<script setup>
import styleDrawflow from "drawflow/dist/drawflow.min.css";
</script>

if I remove this then everything works fine but some of the Node styles get messed up, how to fix this?

The css files not include export method.
View documentation to import css in nuxt.
Try or add in nuxt.config file
https://nuxt.com/docs/getting-started/styling


Is it possible to use it with multiple pages?

Like this
   .pipe(uncss({
            html: ['index.html'],['contact.html'],
        }))

Please read the documentation. https://github.com/ben-eb/gulp-uncss#example


Add cache for CNAME mappings resolved during lookup of DNS entries.

Motivation:
If the CNAMEd hostname is backed by load balancing component, typically the final A or AAAA DNS records have small TTL. However, the CNAME record itself is setup with longer TTL.
For example:

x.netty.io could be CNAMEd to y.netty.io with TTL of 5 min
A / AAAA records for y.netty.io has a TTL of 0.5 min

In current Netty implementation, original hostname is saved in resolved cached with the TTL of final A / AAAA records. When that cache entry expires, Netty recursive resolver sends at least two queries — 1st one to be resolved as CNAME record and the 2nd one to resolve the hostname in CNAME record.
If CNAME record was cached, only the 2nd query would be needed most of the time. 1st query would be needed less frequently.
Modifications:
Add a new CnameCache that will be used to cache CNAMEs and so may reduce queries.
Result:
Less queries needed when CNAME is used.

@trustin addressed.


[Bug] The released SDK version does not match the documentation

Search before asking

[X] I had searched in the issues and found no similar issues.

Environment
Windows
EventMesh version
master
What happened

The project can not load EventMesh Java SDK. Then i find the released SDK version does not match the documentation.
Q1:
From 1.0.0-1.9.0, versions in cn and english docs is always 1.4.0:

Q2:

In MvnRepo, versions all end with ‘release’ exclude 1.4.0. Is it a issue or has an ulterior motive?
How to reproduce
docs address: https://eventmesh.apache.org/docs/v1.9.0/sdk-java/intro
mvn address: https://mvnrepository.com/artifact/org.apache.eventmesh/eventmesh-sdk-java
Debug logs
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct *

1.4.0 is the version determined when it was released before. It is not a bug. The currently officially released versions all have the release suffix.


Add fills tab to Market layout

It would be useful to be able to see fills whilst on the market view.
Suggest putting it in-between the Orders and Collateral tabs.

Note the fills table will need to be updated in both places (if it hasn't been done already) https://github.com/vegaprotocol/frontend-monorepo/issues/845


Issue #62: Default formatter to be exposed as a next() call

Proposed addition with README.md updated.

Sorry this has taken a while. I'm changing jobs and been on holidays and stuff.
Your initial issue makes me think that the default exporter should just be available as an import.
But this PR doesn't stop me from adding that in the future.

This doesn't really work like next, it's really just the default formatter primed and ready to return a value. You still have to return what nextFormatter returns.
I would rather have defaultFormatter exported so I can use it directly.
Personally, nextFormatter is very convenient, but I do not like the bind as mentioned in the inline comment. I would rather it be exposed to be used explicitly and externally. It would also be interesting to have it default to to the defaultFormatter if the custom formatter doesn't return anything.
{ this.props.formatter(value, unit, suffix, then) || defaultFormatter(value, unit, suffix, then) }

defaultformatter only runs if this.props.formatter returns a falsey value (such as null, undefined, false, '', 0 and such)


Adding global css documentation

Adding global css documentation per https://github.com/mxstbr/react-boilerplate/issues/741

Coverage remained the same at 98.234% when pulling d1454c09dbdd656b5b5569856b0b65f7797e321c on bobkocisko:master into 236fb3f36c17563c265e69159a9d05d00871f98e on mxstbr:master.

Coverage remained the same at 98.234% when pulling d1454c09dbdd656b5b5569856b0b65f7797e321c on bobkocisko:master into 236fb3f36c17563c265e69159a9d05d00871f98e on mxstbr:master.

The documentation itself looks awesome, thanks so much @bobkocisko! Would you mind moving that to css-modules.md as another heading? Thanks!

Coverage increased (+0.1%) to 98.346% when pulling b09b191e732759a4aa83d85ea82d12ca6a9c57f1 on bobkocisko:master into 236fb3f36c17563c265e69159a9d05d00871f98e on mxstbr:master.

Ok done and rebased.  But for some reason now it says there are conflicts and it doesn't give me the option to Update branch.  Did my rebase mess up the history?

@bobkocisko Yeah, something is wrong, I don't think rebase was the right thing to do (but I'm no Git wizard). You might consider looking into GitUp. It has learning curve to be sure, but it makes things alot clearer IMO.
The changes to internals/webpack/webpack.prod.babel.js and package.json have already been committed to the project, your docs/css/css-modules.md does not seem to have the original content.
The simplest fix is probably:

Save your docs/css/css-modules.md in a safe location
Clone a new copy of react-boilerplate
Edit docs/css/css-modules.md to include your changes to the new clone
Open a new PR
Close this one

Git can be like that 😦

Closing this per @gihrig's request

@gihrig, I opened up a new request (https://github.com/mxstbr/react-boilerplate/pull/802) and then I realized that the problem with my fork was that somehow two commits from you landed in my fork!??  I removed them via rebase and then the merge succeeded in the context of the new pull request.  I'm not sure how those two commits landed in my fork...please review and make sure that those are unnecessary now because if not then I think you'll need to commit them again.
https://github.com/mxstbr/react-boilerplate/pull/777/commits/eb6e31892a1e102e52230212af3968d6e0db5ae2
https://github.com/mxstbr/react-boilerplate/pull/777/commits/529551e4b949500acf9707fc139ff12021d0cff6

@bobkocisko I did confirm the two commits you refer to are in project master. Thanks for the heads up.


Chore: Update runtimes library

Update runtimes lib to auto-pull new images (flutter)
QA fails only on CI/CD, works locally:

Ignoring CI/CD failure, plan to fix in future as this is urgent

Aware of CodeQL failing, it passes locally, so unrelated to changes made in this PR.
I will solve CI/CD issues with CodeQL in separate PR.


update readme

Codecov Report

Merging #4 (802e3a7) into master (6dc35b6) will increase coverage by 13.44%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   44.46%   57.91%   +13.44%
===========================================
  Files          20       21        +1
  Lines         650      651        +1
===========================================
+ Hits          289      377       +88
+ Misses        352      263       -89
- Partials        9       11        +2

Flag
Coverage Δ

unittests
57.91% <83.33%> (+13.44%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

app/cmd/cmd_server.go
16.66% <0.00%> (-3.34%)
:arrow_down:

app/api/bwlist.go
100.00% <100.00%> (+21.05%)
:arrow_up:

app/api/health.go
100.00% <100.00%> (ø)

app/api/route.go
100.00% <100.00%> (+100.00%)
:arrow_up:

app/api/server.go
73.03% <100.00%> (+39.32%)
:arrow_up:

app/iptable/iptable.go
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc35b6...802e3a7. Read the comment docs.


Substitution error

Hi,
first of all, thanks a lot, this package is pretty cool.
I found something that is, apparently, an error.
on the docs, it is saying that:
ex = '' +
        'lorem ipsum dolor sit amet' +
    ''
"lorem ipsum dolor sit amet"
stripTags(ex, [], '\n');

would yield:
lorem ipsum
dolor
 sit amet

The result, though, is this:
lorem ipsum
dolor

sit
 amet

basically, if I'm not seeing anything weirdly, the problem is that striptags is substituting both the opening and the closing tag...

You are correct! That is expected, although the documentation being wrong is not :)
I'll update the README. Thanks!


HBASE-23594 Procedure stuck due to region happen to recorded on two s…

…ervers.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

+0 :ok:
spotbugs
4m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 57s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed

+1 :green_heart:
findbugs
4m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
164m 36s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

222m  6s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/953

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a0c9ee3cd95e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-953/out/precommit/personality/provided.sh

git revision
master / 270eb9886e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/1/testReport/

Max. process+thread count
4425 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 32s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
checkstyle
1m 18s
master passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

+0 :ok:
spotbugs
4m 19s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 17s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 55s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 40s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 37s
the patch passed

+1 :green_heart:
findbugs
4m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
172m 58s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

230m 17s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/953

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 27d459764f32 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-953/out/precommit/personality/provided.sh

git revision
master / 270eb9886e

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/2/testReport/

Max. process+thread count
4468 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-953/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Resource exhausted on Cardano node socket

Why
The aggregator of the release-mainnet network stopped producing certificates and missed in particular the production of the Cardano db snapshot for immutable file number 5917. After investigation, it appears that the aggregator stopped operating properly as it was unable to retrieve critical information (Tip of the chain) with the local state query mini-protocol: a problem occurred during the connection to the mini-protocol with the error message Resource temporarily unavailable (os error 11). We were able to reproduce the problem with the Cardano cli and received the same error: <socket: 11>: resource exhausted (Resource temporarily unavailable)
A restart of the Cardano node was sufficient to reactive the local socket and the aggregator resumed its operations swiftly after the restart.
The Cardano node (8.9.0) was up and running for 3 months, and we have never noticed that problem earlier.
What
Investigate possible cause for the resource exhaustion on the socket.
How

[x] Investigate the cause of the error
[ ] Fix the cause of the error

Hi @falcucci @scarmuega is this a known issue with Pallas?

@jpraynaud no, it isn't.
For what I read in the issue, if the error was reproducable through the cardano-cli, this is likely to be an issue with the node instance.

@jpraynaud no, it isn't.
For what I read in the issue, if the error was reproducable through the cardano-cli, this is likely to be an issue with the node instance.

Thanks for your answer @scarmuega!
I guess the problem is occurring in one of the routes of the REST API of the aggregator instead.

Closed with #1804


Analyzers for AuthorizationPolicies

Approaching https://github.com/istio/istio/issues/19076
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[x] Developer Infrastructure

Hi @xeviknal. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@xeviknal: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
fd22519437c69542011d5c9819b2417197639a66
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu comments approached. Let me know what you think, thanks.

@yangminzhu comments approached! Thanks for the accuracy!

@xeviknal: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
0a606edd039e33816c07e2c2d3fd29db97e30402
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@yangminzhu do you think I should approach anything else from here? thx

@xeviknal: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0a606edd039e33816c07e2c2d3fd29db97e30402
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xeviknal: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0a606edd039e33816c07e2c2d3fd29db97e30402
link
/test analyze-tests_istio

lint_istio
b469a5ba1b16d1a15d5f23ba068d03afb0435667
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xeviknal: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0a606edd039e33816c07e2c2d3fd29db97e30402
link
/test analyze-tests_istio

lint_istio
b469a5ba1b16d1a15d5f23ba068d03afb0435667
link
/test lint_istio

gencheck_istio
b469a5ba1b16d1a15d5f23ba068d03afb0435667
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[HIGH PRIORITY] Discordeno Main Branch Broken

Currently the Discordeno Main branch is broken. You can't even start the bot. Still investigating.

when has this been fixed


M3U file empty

Streamtest.in changed something, so, m3u file is empty.

Problem still exist. Might be due to login restriction.


Controller Function Issues

Expected Behavior
Pressing the links to delete or edit projects will follow with a controller action.
Actual Behavior
Pressing the links to delete or edit projects and a few other elements resolves with the view for that page being rendered. This is new behavior and is likely occurring due to the bootstrap 4 or ERB~>HAML upgrade.
Steps to Reproduce
Attempt to delete an artifact, or add/remove users from projects.

It's spreading...definitely due to B4 upgrade


Service dates are wrong on the invoice

This should be July 23 - 26.

It would also be good to list the EPS VAT ID somewhere:

The services dates are taken from the database. Fixed them there.


[FSDP2] set vocab_size=32 to avoid must be divisible by 16 error

Stack from ghstack (oldest at bottom):

-> #264

E             File "/home/weif/local/pytorch-official/pytorch/torch/testing/_internal/distributed/_tensor/common_dtensor.py", line 205, in forward
E               output = self.output(h).float()
E             File "/home/weif/local/pytorch-official/pytorch/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
E               return self._call_impl(*args, **kwargs)
E             File "/home/weif/local/pytorch-official/pytorch/torch/nn/modules/module.py", line 1541, in _call_impl
E               return forward_call(*args, **kwargs)
E             File "/data/users/weif/float8_experimental/float8_experimental/float8_dynamic_linear.py", line 71, in forward
E               y = torch.nn.functional.linear(x_fp8, w_fp8, self.bias)
E             File "/data/users/weif/float8_experimental/float8_experimental/float8_tensor.py", line 297, in __torch_dispatch__
E               return FLOAT8_OPS_TABLE[func](func, args, kwargs)
E             File "/data/users/weif/float8_experimental/float8_experimental/float8_ops.py", line 151, in float8_mm
E               tensor_out, amax = addmm_float8_unwrapped(
E             File "/data/users/weif/float8_experimental/float8_experimental/float8_python_api.py", line 55, in addmm_float8_unwrapped
E               output, output_amax = torch._scaled_mm(
E           RuntimeError: mat2 shape (768x8 must be divisible by 16
E           Exception raised from _scaled_mm_out_cuda at /data/users/weif/pytorch-official/pytorch/aten/src/ATen/native/cuda/Blas.cpp:874 (most recent call first):

Check lint before landing :)

@weifengpy I think you merged it into your base branch, not the actual main branch.
I think for float8_experimental, you need to import to diff in fbcode and land from fbcode.

@weifengpy I think you merged it into your base branch, not the actual main branch.
I think for float8_experimental, you need to import to diff in fbcode and land from fbcode.

no wonder everyone is importing to fbcode. good to learn it. will open another PR

@weifengpy I think you merged it into your base branch, not the actual main branch.
I think for float8_experimental, you need to import to diff in fbcode and land from fbcode.

no wonder everyone is importing to fbcode. good to learn it. will open another PR

opened https://github.com/pytorch-labs/float8_experimental/pull/265 for review and imported it into fbcode


Revamp subgraph creation/deploy/removal logic

So far, important operations like deploying a subgraph were handled in a layer above the store; that makes it impossible for the store to understand what is actually being done. To support storage in multiple databases, the store needs to be in charge of the logic behind these operations so it can split them up safely across multiple databases.
These changes do that: all metadata manipulation that touches things that might live in multiple databases is now done inside the store. There are still a few operations that send opaque metadata operations to the store, but those will all always happen in one database. It's desirable that they also become explicit store operations, but not strictly necessary.
This PR also adds a few tests that exercise some basic behavior, like deploying in instant and synced version switching mode.

Only minor comments, this is a nice refactor! This gets us very close to being able to remove the MetadataOperation::AbortUnless variant, which to me was always smelled of over abstracting the store. Maybe we could do it with just a bit more of refactoring?

Yes, I would like to get rid of apply_metadata_operations altogether - I think the only things that use it that are left are places storing errors; I didn't touch those because I didn't want to cause merge conflicts for you (though that fear might be overblown) Oh, and we use MetadataOperation to store a SubgraphDeployment and the long list of entities hanging off of it. I'd love to get rid of these, but since they are all about a specific deployment, they aren't an issue for multi-database. They are a footgun waiting to go off though, and I'd like to refactor further once multi-database is done.

@lutter sounds like a plan, feel free to merge.

@lutter sounds like a plan, feel free to merge.

I'll hold off on merging until what's already on master is rolled out to hosted; since it touches some fear-inspiring logic, I think it's better to roll this out in isolation. Until then, I'll just keep piling PR's on top of this one ;)


feat(glib): add transaction related connection bindings

Fixes #553.
New APIs:

gadbc_connection_set_auto_commit()
gadbc_connection_commit()
gadbc_connection_rollback()

Is the linked issue correct? Isolation level isn't present here

Oh... I referred wrong issue...
I've fixed it.


Introduce ExhaustiveRefasterTypeMigration check

Suggested commit message:
Introduce `ExhaustiveRefasterTypeMigration` check

The new `@TypeMigration` annotation can be placed on Refaster rule
collections to indicate that they migrate most or all public methods of
an indicated type. The new check validates the claim made by the
annotation.

This will help flag new to-be-migrated methods any time the JUnit or TestNG dependency is upgraded. (This PR also flags that TestNGToAssertJRules is no longer nearly as exhaustive as it once was. Resolving that will be deferred to a separate PR. I started a TestNG and JUnit branch. That said, given the repetition involved, perhaps introducing a bug checker or two is in order.)

I'll rebase this branch and move the check to the new guidelines module.


Enhancement request: Excluded processes selection improvement

Expected behavior:

It'd be really great to be able to either "Browse" to an .exe to select it to be an excluded process, or the drop-down list be sorted to alphabetical order. Another option could be to add a profile in the same manner you add a game, but have a the "Allow Aurora to provide lighting effects for" checkbox exclude the process instead if the box isn't checked.
Actual behavior:

Select arrow next to dropdown box, try to locate the process
How often does this problem occur?

This problem occurs... (Fill in here) N/A
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Launch process/application to be excluded
Alt-Tab back to Aurora
Try to locate process from the unsorted list

What is the version of Aurora you are experiencing this issue with?

My version is... b.466
Does the previous version of Aurora have this issue?
The previous version, (Fill in the version here), did/did not have this issue.
Unknown
Please include any logs, screenshots, or files that are related to this issue:

@Minotaur1975 Thanks for your suggestion. It has been added with PR #1260. If you use GHUB you'll want to grab this.

New interface looks great. Thanks!


Feature request: For The Badge Style

See https://forthebadge.com/
shields.io does support custom generation (not complete though) of those, what do you think ?

The style looks cool but I (personally) rarely see people using it 🤔


Address edge cases in cloud sampling

When comparing random number with 1 - cloud fraction, we change the condition > to >= to address the edge case that cloud fraction is 1 but random number is 0.

bors r+


Solved #254  Added Jewels & Stones Solution (Java)

#254 Added Jewels & Stones Solution (Java)
I have added the solution along with full problem statement & sample test cases.

They are not considering dsa,cp,algorithm repository :(
all the pr will not be considered in hacktoberfest but your contribution will be for lifetime, this will help many students to practice dsa .
Thank you for your contribution :)
you can contribute to other repo


Zone 0.7.x breaks compatibility with Raven-js

I upgraded to our Angular app to 2.4.1 and Zone.js to 0.7.4 (from 0.6.x) and it seems to have broken compatibility with Raven-js.
I've been digging a bit and it seems that this commit 20b5a5dc1cdd119e2b6ef62eedb271f6daec0e56 introduced the error I'm experiencing.
The magic of Zone.js and Raven-js is a bit over my knowledge level and I'm unsure if this is considered a bug in either Zone.js or Raven-js.
I've created a plnkr her: https://plnkr.co/edit/C1706h9xyfNHivsxtH6l?p=preview that shows the error.
Stacktrace:
this.removeAttribute is not a function
    at XMLHttpRequest.desc.get [as onreadystatechange] (https://unpkg.com/zone.js@0.7.4/dist/zone.js:916:26)
    at XMLHttpRequest.send (https://cdn.ravenjs.com/3.7.0/raven.min.js:2:10320)
    at Observable.eval [as _subscribe] (https://unpkg.com/@angular/http@2.4.1/bundles/http.umd.js:1217:22)
    at Observable.subscribe (https://unpkg.com/rxjs/Observable.js:45:27)
    at App.ngOnInit (https://run.plnkr.co/Yk33wUvMk7m5zD4o/src/app.ts!transpiled:33:26)
    at Wrapper_App.ngDoCheck (/AppModule/App/wrapper.ngfactory.js:22:53)
    at CompiledTemplate.proxyViewClass.View_App_Host0.detectChangesInternal (/AppModule/App/host.ngfactory.js:28:17)
    at CompiledTemplate.proxyViewClass.AppView.detectChanges (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:12592:18)
    at CompiledTemplate.proxyViewClass.DebugAppView.detectChanges (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:12739:48)
    at ViewRef_.detectChanges (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:9819:24)
    at eval (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8721:71)
    at Array.forEach (native)
    at ApplicationRef_.tick (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8721:29)
    at ApplicationRef_._loadComponent (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8696:18)
    at ApplicationRef_.bootstrap (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8684:18)
    at eval (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8506:93)
    at Array.forEach (native)
    at PlatformRef_._moduleDoBootstrap (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8506:46)
    at eval (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:8458:31)
    at ZoneDelegate.invoke (https://unpkg.com/zone.js@0.7.4/dist/zone.js:242:26)
    at Object.onInvoke (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:4410:41)
    at ZoneDelegate.invoke (https://unpkg.com/zone.js@0.7.4/dist/zone.js:241:32)
    at Zone.run (https://unpkg.com/zone.js@0.7.4/dist/zone.js:113:43)
    at https://unpkg.com/zone.js@0.7.4/dist/zone.js:520:57
    at ZoneDelegate.invokeTask (https://unpkg.com/zone.js@0.7.4/dist/zone.js:275:35)
    at Object.onInvokeTask (https://unpkg.com/@angular/core@2.4.1/bundles/core.umd.js:4401:41)
    at ZoneDelegate.invokeTask (https://unpkg.com/zone.js@0.7.4/dist/zone.js:274:40)
    at Zone.runTask (https://unpkg.com/zone.js@0.7.4/dist/zone.js:151:47)
    at drainMicroTaskQueue (https://unpkg.com/zone.js@0.7.4/dist/zone.js:418:35)
    at XMLHttpRequest.ZoneTask.invoke (https://unpkg.com/zone.js@0.7.4/dist/zone.js:349:25)

Thank you for reporting the issue, I'll look into it.


Could you please add a comment containing the name of the iobroker state behind the Auto completion (IntelliSense) of ioBroker state ids?

Is your feature request related to a problem? Please describe.
If I use Intellisense to add an ioBroker state id, it looks like:
setState('hm-rpc.1.00089B4092E667.2.STATE', true, false);
For Homematic adapter and many others, these IDs are not very "user-friendly" and the devices cannot be easily identified by looking at the id.
Describe the solution you'd like
Do not only auto complete the ID, but also the name as a comment behind the ID (this is done by the internal ioBroker Javascript editor). It looks like e.g.:
setState('hm-rpc.1.00089B4092E667.2.STATE' /* WZ.Mainlight:Actor 1.STATE */, true, false);
Describe alternatives you've considered
Currently, the info box shown when hovering over the ID shows also the name. This is already a very helpful improvement.
Additional context
I documented some ideas on how to do that already here, but as the issue was already closed, I assume, this was overlooked. And maybe it is not useful at all.

I thought about this and i don't want to add the comment every time a ID is auto completed. Instead I thought about adding a Code Action on an ioBroker ID. Code Actions are the little light bulb, which appear some times. [More info here}(https://code.visualstudio.com/docs/editor/refactoring).
So you would press the light bulb (or the corresponding key binding) and would get the option add the name as comment to the id.
Would this be viable solution for you?

After thinking about it: yes, sounds lika a viable solution. Did not think about that before

Solved with #150.
See documentation on how to use it.

Awesome! Thanks a lot!


atom-text-editor.Object.defineProperty.get is deprecated.

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.
atom-text-editor.Object.defineProperty.get (C:\Users\My_Lenovo\AppData\Local\atom\app-1.13.0\resources\app.asar\src\text-editor-element.js:68:18)
Object.compile (C:\Users\My_Lenovo\.atom\packages\webbox-color\lib\color.coffee:85:25)
<unknown> (C:\Users\My_Lenovo\.atom\packages\webbox-color\node_modules\underscore\underscore.js:666:47)

The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead.
atom-text-editor.Object.defineProperty.get - /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:68:18
Object.compile - /Users/Marco/.atom/packages/webbox-color/lib/color.coffee:85:25
<unknown> - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/underscore/underscore.js:666:47

Same for me

Same here

Same here...
The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead.

atom-text-editor.Object.defineProperty.get - C:\Users\MY_USER\AppData\Local\atom\app-1.13.0\resources\app.asar\src\text-editor-element.js:68:18
Object.compile - C:\Users\MY_USER\.atom\packages\webbox-color\lib\color.coffee:85:25
<unknown> - C:\Users\MY_USER\.atom\packages\webbox-color\node_modules\underscore\underscore.js:666:47

Same

Same

Same

same shit

same

Same!

same

same

Same

Same here!

+1

Same

Rather than saying "same", instead try clicking the thumbs up button on the bottom of the issue box at the top of the page instead.

same by me

a month ago, Look at this issue please

Same

@Akumetsu-Dev @DakotaWolfi Click the thumbs up reaction button on my issue instead of commenting "same" :-)

Is there any way to find out if this is actively being addressed? The repo shows no updates in the last year--is this even being supported anymore? This package is a huge help to my (and many others' I'm sure) workflow.

Has anyone been able to fix this? Pull #46 does not fix the deprecated calls issue. (The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead.)

I switched to using Pigments. You can change the settings to make it display the color as a circle or square at the end (or beginning/gutter) of the line (this was important for me). If the color format conversion is important to you, Pigments has that as well. Hope this helps.

Same

Same here


ESLint Configuration

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.885%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2778

Relevant Lines:
10732

💛  - Coveralls

Codecov Report

Merging #693 (4916564) into master (80769f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   23.33%   23.33%
=======================================
  Files          71       71
  Lines       10330    10330
=======================================
  Hits         2410     2410
  Misses       7594     7594
  Partials      326      326

Flag
Coverage Δ

unittests
23.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80769f7...4916564. Read the comment docs.

I guess I've already reviewed this, but it is still in draft mode. More to be added to it?


Datepicker positioning in same place for all datepickers

I clicked on the bottom datepicker and the top datepicker and they all appear in the wrong place.

Same issue.

hey guys i got the same error but I think if you would like to know then the following line
 offset.top = 20;
at line 357 of the distribution code (not the minified) should be
 offset.top -= 20;
Also same thing at line 352, hope that helps you

I'm experiencing the same issue. Is there a PR for this fix?

@kylelamse @codechimera  the fix is referenced in #137... There's no need to change the lines @mackram mentioned.
Fix:

Putting style={{positon:relative}} on the wrapping div in DateTimeField.js seems to fix things.

It's a css position inheritance issue. Putting the position:relative fixed all the issues I was having with placement.
Nonetheless, there is still an outstanding fix needed for this that will close the following issues: #155 #137 #131 #104 #48 #36


Add pug and style linters

Resolves #3544

I've just added pug and style linters for tikui style only at the moment because there is a lot of thing to adapt on existing scss code to have it everywhere.
But cause the style will only be in the style directory (except for the generated glyphs), I think we will no longer need to care about this.

Thanks a lot for your work here @Gnuk !


Fingerprints: add additional values for 2024 Ram 1500

Adding new 2024 Ram 1500 firmware versions to fingerprints.py

Dongle ID: e8dac44d3a3458a5

Closing since your car fuzzy matches already. If you were to drive on release3 to gather enough data your fingerprints will automatically be added by our bot: https://github.com/commaai/openpilot/pull/32357


Support source data from query string

Hi! I think it would be useful if one could send data through the URL, e.g. https://dasel.tomwright.me/?src={
  "name"%3A "Tom"
}

Are you looking to use this as some form of API? Or as a helper to pre-load some details into the form?
I'm happy to support some kind of in and cmd query parameters.

Yeah, for populating the form. I was thinking it would be a great visualization tool for some automated flows

Great point! I'll add this to the to-do list 👍

Cool, I am not a big fan of JavaScript building tools, but I will give it a try and let you know how it goes :smile:

If you want to, feel free! If not I can work on it in the next couple of days 🙂

@ntrrg This has been released with v0.3.10.
I can't push it to production yet because there are ongoing issues with github actions. I will deploy this tomorrow

That is fine :) thanks for your work!

It's released now 🙂


PieChart hides label when data is unevenly distributed

Hi,
I am seeing what looks to be an error when the data used for a pie chart is heavy/skewed towards one particular category. The error is that the label for categories with fewer items in them are hidden. Example, a chart with categories containing [{ x: "example label", y: 1}, { x: "example label 2", y: 1 }, { x: "example label 3", y: 20 }, {...} ] will hide the labels for those with a y of 1. Increasing the size of the SVG does not seem to affect this in any way; only the relative distribution of the y values makes any difference to the labels appearing or not.
Ex,

vs

The way the data appears when the error is occurring looks like this:

A fix or some guidance would be greatly appreciated.

This seems related to https://github.com/codesuki/react-d3-components/issues/131 but I don't see why the label should be hidden since there is clearly enough room for it.

So the decision point is here
https://github.com/codesuki/react-d3-components/blob/master/src/PieChart.jsx#L119
Maybe this needs some tweaking. In case you have time would you play around with that a bit to see if you can improve it?

I'll take a look at it!

Also thanks for reporting and sharing a way to reproduce the issue!
It seems I was in a hurry the last time I commented.


Regression in platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary average CPU/GPU usage

The SkiaPerf dashboard reported a regression in the average_cpu_usage and average_gpu_usage metrics of the platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary benchmark
See https://flutter-flutter-perf.skia.org/e/?begin=1677084908&end=1677120377&keys=X504324cfea1ed70f17cf1a91c0bcccd1&num_commits=50&request_type=1&xbaroffset=33474
Traced this to a recent change related to platform views on iOS: https://github.com/flutter/engine/pull/39527

To share a few update

i was able to verify it's indeed https://github.com/flutter/engine/pull/39527 that caused the regression using A/B testing metrics
I also found a clue which is quite promising - the BringLayersIntoView function is call every frame, even if there's no change to the view hierarchy of the platform views. It used to be fine since we are just setting the zPosition to the same value, but after my PR it performs a bringSubviewToFront for every subview (e.g. [1, 2, 3, 4] -> [4, 1, 2, 3] -> [3, 4, 1, 2] -> [2, 3, 4, 1] -> [1, 2, 3, 4] (back to the same!).
So we want to check for this no-op scenario and avoid doing unnecessary manipulation (WIP). This should address the regression (or at least to some degree, if not the whole regression). Will post here when I get the numbers.


fastht.ml is down says internal server error.

Tried to raise a bug on https://github.com/AnswerDotAI/home-fasthtml, but bugs are locked there.
So raising it here.

Happened on August 6th 10 PM IST (+05:30)

@jph00  FYI

Thanks - my bad; the dynamic weather widget didn't have an exception handler for issues with weather.gov!


feat: detect an unresponsive stick and reset it

This PR makes use of the previously-added Unresponsive controller status by adding a detection for an unresponsive controller (not ACKing serial API commands). When this situation happens, we soft-reset the controller in an attempt to recover. If that does not help either, the driver instance gets destroyed.
This should trigger a restart in most applications, which effectively closes and re-opens the serial port.
fixes: #2723

Hello,
It seems that with this change, I've started seeing the following failure:
06:41:46.117 DRIVER   Controller is still timing out. Restarting the driver...
Error in driver ZWaveError: Controller is still timing out. Restarting the driver... (ZW0100)
    at Driver.destroyWithMessage (/home/homeassistant/zwave-js-server/node_modules/zwave-js/src/lib/driver/Driver.ts:2769:17)
    at fail (/home/homeassistant/zwave-js-server/node_modules/zwave-js/src/lib/driver/Driver.ts:3484:14)
    at Driver.handleUnresponsiveController (/home/homeassistant/zwave-js-server/node_modules/zwave-js/src/lib/driver/Driver.ts:3493:4)
    at Driver.handleFailedTransaction (/home/homeassistant/zwave-js-server/node_modules/zwave-js/src/lib/driver/Driver.ts:5521:13)
    at Driver.drainTransactionQueue (/home/homeassistant/zwave-js-server/node_modules/zwave-js/src/lib/driver/Driver.ts:4613:10) {
  code: 100,
  context: undefined,
  transactionSource: undefined
}
Shutting down
Closing server...
06:41:46.142 DRIVER   destroying driver instance...
06:41:46.154 CNTRLR   [Node 041] Interview attempt 1/5 failed, retrying in 5000 ms...
06:41:46.159 CNTRLR » [Node 041] Assigning SUC return route...
06:41:46.161 CNTRLR » [Node 041] Deleting SUC return route...
06:41:46.167 CNTRLR   [Node 041] Deleting SUC return route failed: The driver is not ready or has be
                      en destroyed (ZW0103)
06:41:46.171 CNTRLR   [Node 041] Assigning SUC return route failed: The driver is not ready or has b
                      een destroyed (ZW0103)
06:41:46.184 DRIVER   all queues idle
Client disconnected
Code 1000:
Server closed
06:41:46.321 DRIVER   driver instance destroyed

I have a zst10 stick and the issue happens without running home assistant at all (just starting using zwave-js-server is enough).

See https://github.com/zwave-js/node-zwave-js/issues/6341

Hm, that's interesting: is it normal for the driver to be reloading every few minutes or so? It makes home assistant unusable.
I tried using zwave-js-ui to disable soft resets, but it didn't seem to help with the issue.

Ack, attached.
zwavejs_2023-10-05.log

Looks like whenever Z-Wave JS tries to interview node 41, requesting the node's info causes the controller to time out and not send the expected callback, triggering the new "unresponsive controller" detection.
That first restarts the stick, which doesn't resolve the issue, then it restarts Z-Wave JS.
I'll track that problem in https://github.com/zwave-js/node-zwave-js/issues/6371

@AlCalzone , does an MQTT event get raised when an unresponsive controller is detected?

That's a question for https://github.com/zwave-js/zwave-js-ui


Fix tests with line comments

Nice! I merged it without new version number because this doesn't need a release, right?


Exporter: Save Settings Broken

Fix for T58830 (#146) Exporter Save Settings Broken. Im not into python really so Im not sure this is the right way, but it works for me.

@EJTH Thanks so much for this!
Is there an easy way to make this tolerant of the malformed saved export settings from the last few days?  Or should we just tell people to manually delete them?
If needed we could even pull in @willstott101's abandoned patch from #149, which would discard the bad export settings, and allow a fresh export to begin.


Suggestion: API Blog and Rename Language

Hi, I added a Blog API and renamed some language pack according to ISO-639 (https://en.wikipedia.org/wiki/ISO_639).

Fixed in v4.2.3
I didn't add the blog api yet since that is more of a user-specific option. If someone wants to extend the default controller then they are free to do that.
Thanks for the update on the language!


PERF: Reduce memory usage during risk metric calculations.

Instead of using pd.Series calculations, pass the underlying
numpy array which have already been sliced to the exact dt, to prevent
calculation like beta creating some temporary copies of the Series with
an unneeded call to dropna.
The creation of the temporary Series was consuming more memory than
needed, with the index being the high penalty.

See #572

Tested this with same memory profiling as #572 and the same memory profile as using the views holds.

Coverage decreased (-0.0%) to 87.55% when pulling ca6338665c393c78f7d629c867a5b5e2ca00f4a2 on pass-arrays-directly-to-risk-calcs into e5a93b6f7e2ffea731595942b81044af2e5415b0 on master.


expectRevert(customError.selector) not matching the error selector emitted by the contract

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (72bc4f4 2024-04-08T00:17:17.438514000Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
I have a custom error defined in my contract:
error Issuance__ProtocolInvariantBroken(uint256, uint256);
When getting the error selector by running forge inspect contractName errors
"Issuance__ProtocolInvariantBroken(uint256,uint256)": "eb4a71b0"
Now I have a test which expectRevert(Issuance__ProtocolInvariantBroken.selector) but on running the test, the error selectors don't seem to match, even though the log shows the same selector as above eb4a71b0
Logs:
[Revert] Issuance__ProtocolInvariantBroken(5120, 5020)
    └─ ← [Revert] Error != expected error:  != 0xeb4a71b0

Ideally, since the error selectors are same eb4a71b0, the test should pass.

To use expectRevert with a custom error type with parameters, ABI encode the error type.

Hey @kamuik16 I want to just check the error type and not the parameter values, hence was using vm.expectRevert(customError.selector); as suggested in the docs here.

Same problem here.
In forge-std/Vm.sol documentation says:
    /// Expects an error on next call that starts with the revert data.
    function expectRevert(bytes4 revertData) external;

which would indicate that selectors only need to match, but instead I error that there's no full match (wrong):
[FAIL. Reason: Error != expected error: 0x1deca43800000000000000000000000000000000000000000000000098a7d9b8314c0000 != 0x1deca438]

It should pass.

@DanL0 do you have a repro for this?
fyi @klkvr

https://github.com/foundry-rs/forge-std/blob/master/src/Vm.sol#L1735 - here it says if you use bytes4 it will match selector only, but actually in test cases of ExpectRevert in this repository I haven't found a test case that would document such behavior.
Also this feature request: https://github.com/foundry-rs/foundry/issues/3725 isn't closed - therefore it seems it's not implemented?
It seems documentation of Vm.sol is misleading.

Reproducing is super easy. Please confront this repository:
https://github.com/DanL0/forge-expect-revert-error
With this documentation:
https://github.com/foundry-rs/forge-std/blob/master/src/Vm.sol#L1734
cc @mattsse @alfheimrShiven


ISPN-11115 Infinispan BOM should only have dependency management for …

…its own artifacts
https://issues.redhat.com/browse/ISPN-11115

Merged, thanks


Question about event-level rate attribution limit

Recently, we sometimes get this error message when doing testing with chrome webdriver:
Attributable: reached event-level attribution limit
I see the doc on rate limit says:
Strawman rate limit: 100 attributions per {source site, destination, reporting origin, 30 days}
However, our test case is creating a new webdriver session each time, and is run in a hermetic environment, and the cases are way lower than 100 pairs for each target.
So just wonder:

Is there a way to bypass the limit when starting chrome (with launch param)
Is there a way to reset the limit count during test run time?
How is the limit is collected, does it persist across webdriver sessions

Thanks ahead.

Do you know what User Data Dir selenium is using in your environment? It seems likely that the tests are re-using the same state across runs (i.e. are not actually hermetic)

Hi Charlie,
I followed your instruction to clear the use data for every test case. The flakes reduced a lot. However, I got some failed tests: the first registration has the status of attributable:event-level rate attribution limit, and the registrations after that are fine (status is "attributable").
Is there any other factor that can lead to this flakes?
Thanks.

Closing this issue after a period of inactivity, but please re-open if it's still relevant!


Lazily create socket in SegmentEmitter

This addresses issue #142. While that issue points to other open handles, segment_emitter is currently opening a UDP handle as soon as it's required in a file.
This initializes the socket only on first send which should prevent the false positive errors mentioned in #142.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @timtrinidad,
Thank you for your contribution. I would like to request that you make this PR against the 2.x branch instead of master. See #192 for more details.
Once you move this PR over I'll be happy take a look at it.

@willarmiros done. Thanks!

Actually, you'll have to close this PR and make a new one against aws:2.x. This PR is still being made against aws:master.
For reference, see how #190 was migrated to #193.

Ah yes. WIll do.

Reopened as #200


feat: trade pk based only on the order pk it relates to

Further changes to remove direct link from the trade to the opposite order (since cross trades will have more than one of them). The opposite order public key was used to generate trade's public key. The idea is to redefine trade's public key to be made of order's public key and a random seed. Seed will be represented similarly to one used for order and order request creation: [u8; 16] which is able to hold 16 bytes of generated UUID giving us low probability of collision when processing matching queue in parallel.

closing as instead of many will make one big pr for crossmatching


🧑💻 : Duplication of Footer

:red_circle: Title : Duplication of footer
:red_circle: Enhancement Aim : Removal of Duplicated Footers
:red_circle: Changes :

Removal of Duplicated Footer
Enhancement of Footer

Screenshots 📷

✅ Details to Include When Taking the Issue:
Name : Vansh Garg(Github Username: @VanshGarg06 )
Participant Role: GSSOC-EXT, Hacktoberfest

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

someone already working on it


[NO-TICKET] OneLogin auth provider refresh method fixing scope as start method

Hey, I just made a Pull Request!
Fixes issue described here
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Just renamed the branch. Open with better naming


added changePassword feature

Related Issue
added changePassword feature
Closes: #316
Describe the changes you've made
Give a clear description what modifications you have made
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Additional Info (optional)
Any additional information you want to give
Checklist:

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly whereever it was hard to understand.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

login to website
You will find a option of change password in drop down

This will help
https://user-images.githubusercontent.com/55352601/120017515-97d9cb80-c003-11eb-9a23-0180a3fbe781.mp4

@ankitapuri good to be merged


System.Text.Json

You plan remove Newtonsoft.Json and use only System.Text.Json ?

Not at the moment, Newtonsoft is only used for updates at the moment, since System.Text.Json is missing some feature-parity that allows for easy diffing between JSON structures. When I see that feature-parity I'll revisit it.


Error closing multiples opened modals

🐛 Bug Report
When a Modal A, opens a Modal B, if we close the Modal A, the Modal B is gonna be closed, but the Modal A still there, frozen. (live examples added).
This issue is only happening on iOS. Android is working well.
This issue was reported on Expo repo: https://github.com/expo/expo/issues/3473
To Reproduce

Open https://snack.expo.io/HJQ_fn34N
Open the app in Android (we are gonna see it working well at first)
The App is gonna to open a Red Modal, automatically.
Quickly, Tap on "Show Modal Blue" (so, the Red Modal is gonna open a Blue Modal).
Wait for 10 seconds.
The parent "App" is gonna close the Red Modal. So, Blue modal is gonna be closed as well, due to the Blue Modal is a Red Modal children.

Now, let's see the error on iOS

Open the same Snack
Open the app in iOS
The App is gonna to open a Red Modal, automatically.
Quickly, Tap on "Show Modal Blue" (so, the Red Modal is gonna open a Blue Modal).
Wait for 10 seconds.
The parent "App" is gonna close the Red Modal. But, the Blue Modal is gonna be closed but the Red Modal still there, broken. Kind of froze.

Expected Behavior
The Android behavior (both modals should be closed).
Current Behavior
iOS only close the Blue Modal (the second one) and keeps the Red Modal (the first one) opened.
Code Example
https://snack.expo.io/HJQ_fn34N
Environment
Expo environment
Expo CLI 2.7.0 environment info:
    System:
      OS: macOS 10.14.2
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 9.10.1 - ~/.nvm/versions/node/v9.10.1/bin/node
      Yarn: 1.13.0 - ~/.yarn/bin/yarn
      npm: 6.7.0 - ~/.nvm/versions/node/v9.10.1/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      expo: ^32.0.0 => 32.0.0
      react: 16.5.0 => 16.5.0
      react-native: https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz => 0.57.1
    npmGlobalPackages:
      expo-cli: 2.7.0

** React Native Environment**
  React Native Environment Info:
    System:
      OS: macOS 10.14.3
      CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
      Memory: 81.80 MB / 8.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 9.10.1 - ~/.nvm/versions/node/v9.10.1/bin/node
      Yarn: 1.13.0 - ~/.yarn/bin/yarn
      npm: 6.7.0 - ~/.nvm/versions/node/v9.10.1/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        Build Tools: 23.0.1, 23.0.3, 25.0.3, 26.0.1, 27.0.3, 28.0.3
        API Levels: 23, 25, 26, 27, 28
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.5.0 => 16.5.0
      react-native: https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz => 0.57.1

This maaaay be related to https://github.com/facebook/react-native/issues/16037


Bonsai task management: GitHub Issues

The various suggested Bonsai tasks are currently described primarily in the Wiki (plus here and here). The GitHub wiki interface is not designed for task management: it lacks discussion, deadlines, dependencies, workflows, task completion, archiving etc. So there is room for improvement here.
GitHub Issues are designed for this. @romainsacchi and I have discussed and researched this topic. We also considered GitHub project boards, but they mostly build upon and extend issues. We think that the tasks listed in the Wiki should be converted into Issues. This should make the Bonsai requirements, status, management, and development speed more visible, integrated and consistent, and help with decision making, provenance, and getting new users started with contributions.
Requirements:

[x]  copy some example tasks from here
[x]  create Bonsai-specific Labels for Issues
[ ]  communicate this suggestion to the mailing list

If general agreement on this approach is reached:

[ ] copy across the remaining tasks from other locations
[ ] delete the duplicated tasks from the Wiki
[ ] update the getting started Wiki page to refer to high-priority tasks

Aside: I considered starting a BEP for this but thought the administrational overhead was too high. So I instead opted to make the changes as a proof-of-concept, then gather feedback after.

I would like to suggest using the Projects features, since we have the Issues and Labels defined. I mean, have a look at it. I think it actually looks nice.

As for the Milestones created, namely "pre-hackathon" and "alpha release", maybe they belong more to the Issues we would define within Hackathon repo, if we choose to do so there too. Because I was thinking that since the issues defined here are long-term tasks (as in "the tasks needed to have a working version of BONSAI"), the milestones should reflect a longer term vision of the development process. Or not?

Maybe possible milestones could be the priority level of the tasks. In the Wiki, some tasks seem to be more urgent than others. Hence, filtering out priority-wise would give a good overview to the contributors as to where their help is needed first. What do you think?

I also think that projects from github is better than filing issues.
From:	romainsacchi<EMAIL_ADDRESS>To:	BONSAMURAIS/bonsai<EMAIL_ADDRESS>Cc:	Subscribed<EMAIL_ADDRESS>Date:	03/13/2019 08:57 AM
Subject:	Re: [BONSAMURAIS/bonsai] Bonsai task management: GitHub Issues
(#10)
I would like to suggest using the Projects features, since we have the
Issues and Labels defined. I mean, have a look at it. I think it actually
looks nice.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

So, following Tom's third requirement, I suggest we communicate this idea of managing tasks to the mailing list to see if people like that, agree on labels, etc., and how it can be improved. What do you think ? @MicDr @tngTUDOR @cmutel @tmillross

We shouldn't make a broader decision for the community, we should propose changes that can enhance people's experience, and indeed we have a formal structure for doing so :)

But the BEP process requires a testing phase, so please set something up. Just do it, it won't be perfect the first time in any case. I would not wait on the mailing list too much, as not everyone is as active as you are (sorry if this contradicts what I said before, but in this case we are talking about a trial phase, not the answer).

I think project boards (like https://github.com/orgs/BONSAMURAIS/projects/2) provide a great overview of how the overall project is progressing, and can be used in concert with issues quite nicely.

Agree. No problem. In fact, in my view "Issues" are more related to issues of the defined Project's tasks rather than stand-alone objects.

+1 for project boards, seems to me the most appropriate feature

Two points that might help clarify things:

Most cards in the project board will refer to whole projects/working groups/long term efforts, and they will do their own task management. The overview/dashboard doesn't need to have details, but rather the general state of each project.

Let's think about how many cards we realistically want to show. I guess not more than 15. This already gives us some ideas of functionality we do or do not need.


Implement service-level payload

What is the purpose of the change
Implement service-level payload.  Issue #10773
Brief changelog
Verifying this change

Checklist

[ yes] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.

[ yes] Each commit in the pull request should have a meaningful subject line and body.

[ yes] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7

[ yes] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.

[ ] Add some description to dubbo-website project if you are requesting to add a feature.

[ ] GitHub Actions works fine on your own branch.

[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11517 (188bc86) into 3.2 (a11e639) will decrease coverage by 4.92%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##                3.2   #11517      +/-   ##
============================================
- Coverage     69.77%   64.85%   -4.92%
+ Complexity      105       14      -91
============================================
  Files          1560     1511      -49
  Lines         83643    62866   -20777
  Branches      14867     9173    -5694
============================================
- Hits          58361    40773   -17588
+ Misses        20402    17857    -2545
+ Partials       4880     4236     -644

Impacted Files
Coverage Δ

...apache/dubbo/common/constants/CommonConstants.java
100.00% <ø> (ø)

...org/apache/dubbo/config/AbstractServiceConfig.java
94.25% <33.33%> (-3.46%)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
50.00% <62.50%> (+2.17%)
:arrow_up:

.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
72.72% <80.00%> (-6.23%)
:arrow_down:

...va/org/apache/dubbo/remoting/exchange/Request.java
93.22% <83.33%> (-1.23%)
:arrow_down:

...e/dubbo/remoting/exchange/codec/ExchangeCodec.java
71.83% <100.00%> (-9.83%)
:arrow_down:

...exchange/support/header/HeaderExchangeChannel.java
81.13% <100.00%> (-4.68%)
:arrow_down:

...apache/dubbo/remoting/transport/AbstractCodec.java
87.80% <100.00%> (+0.30%)
:arrow_up:

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 503 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Adding a payload to the request at the communication layer is unnecessary and risky. The verification of the payload is in the following fragment. The payload itself is obtained through the url. We may modify the corresponding value in the current url through filter or other interception.
protected static int getPayload(Channel channel) {
    if (channel != null && channel.getUrl() != null) {
        return channel.getUrl().getParameter(Constants.PAYLOAD_KEY, Constants.DEFAULT_PAYLOAD);
    }
    return Constants.DEFAULT_PAYLOAD;
}

I am thinking about the following:

Channel is shared, so modifying it is complicated and risky
Channel's URL payload is a protocol payload
The payload property of Request is not passed over the network , so it will not increase network overhead and affect the packaging and unpacking of messages

channel.getUrl() The attributes here come from app-config, service-config and other external configurations, so at least they are shared at the service level.
Since the parameters are obtained from the url, maybe we can achieve the payload configuration at the service level without doing anything. As the following example:
@DubboService(parameters = {"payload", "3000"})
public class GameServiceImpl2 implements GameService {
    public String play(String name) {
        return "hello 2181:" + name;
    }
}

The configuration of parameters parameters may not be obvious to users, so it should be necessary to add attributes to @DubboService

Thank you very much for your suggestion. It is true that the solution you suggested is the best implementation when the channel is not shared. Consumers share channels through provider address (host + port), each channel holds the url of the service that created it. Therefore, in the sharing mode, it cannot be guaranteed that the payload obtained through the channel is accurate.

/**
 * Get dubbo channel by netty channel through channel cache.
 * Put netty channel into it if dubbo channel don't exist in the cache.
 *
 * @param ch      netty channel
 * @param url
 * @param handler dubbo handler that contain netty's handler
 * @return
 */
static NettyChannel getOrAddChannel(Channel ch, URL url, ChannelHandler handler) {
    if (ch == null) {
        return null;
    }
    NettyChannel ret = CHANNEL_MAP.get(ch);
    if (ret == null) {
        NettyChannel nettyChannel = new NettyChannel(ch, url, handler);
        if (ch.isActive()) {
            nettyChannel.markActive(true);
            ret = CHANNEL_MAP.putIfAbsent(ch, nettyChannel);
        }
        if (ret == null) {
            ret = nettyChannel;
        }
    } else {
        ret.markActive(true);
    }
    return ret;
}

@AlbumenJ    NettyChannel seems to have a bug here. The key of CHANNEL_MAP is indeed the original channel of netty, and the url is not included, which means that when calling service2, the channel(created by first service) obtained contains the url of service1. The same goes for actual testing. Maybe we can solve it like this: the key of CHANNEL_MAP uses Channel+url instead of Channel

`private List getSharedClient(URL url, int connectNum) {
String key = url.getAddress();
    Object clients = referenceClientMap.get(key);
    if (clients instanceof List) {
        List<ReferenceCountExchangeClient> typedClients = (List<ReferenceCountExchangeClient>) clients;
        if (checkClientCanUse(typedClients)) {
            batchClientRefIncr(typedClients);
            return typedClients;
        }
    }

......
}
`
In this place, cause the url may already be inaccurate.  I think Url is used as a property container, and the remoting layer mainly transmits the configuration properties of the remoting layer.  Therefore, when dealing with sharing, Url seems to be less important.

/**
 * Get dubbo channel by netty channel through channel cache.
 * Put netty channel into it if dubbo channel don't exist in the cache.
 *
 * @param ch      netty channel
 * @param url
 * @param handler dubbo handler that contain netty's handler
 * @return
 */
static NettyChannel getOrAddChannel(Channel ch, URL url, ChannelHandler handler) {
    if (ch == null) {
        return null;
    }
    NettyChannel ret = CHANNEL_MAP.get(ch);
    if (ret == null) {
        NettyChannel nettyChannel = new NettyChannel(ch, url, handler);
        if (ch.isActive()) {
            nettyChannel.markActive(true);
            ret = CHANNEL_MAP.putIfAbsent(ch, nettyChannel);
        }
        if (ret == null) {
            ret = nettyChannel;
        }
    } else {
        ret.markActive(true);
    }
    return ret;
}

@AlbumenJ NettyChannel seems to have a bug here. The key of CHANNEL_MAP is indeed the original channel of netty, and the url is not included, which means that when calling service2, the channel(created by first service) obtained contains the url of service1. The same goes for actual testing. Maybe we can solve it like this: the key of CHANNEL_MAP uses Channel+url instead of Channel

We should prevent to get parameters from channel url. Channel should be shared among services.

@mytang0 Regarding the payload configuration of this service level, is it possible to bind different services to different protocol configs to achieve the purpose?

@mytang0 Regarding the payload configuration of this service level, is it possible to bind different services to different protocol configs to achieve the purpose?

Yes, it can be achieved by adding channels, but there is a little violation of channel sharing.

PTAL @chickenlj


Fixed formatting of examples and removed JSON-P section

I intended just to fix the formatting of this section

but one thing led to another, see notes lines.

Much easier to read! 🎉


Rocketmod not working for windows 8.1

I tried downloading it, I tried extracting it to my server folder, but it just isnt working. It wont work in servers, the error doesnt appear and I don't know what to do.

We use github to track repeatable bugs, and feature requests.
The scenario you've described seem to not be caused by a bug in Rocket itself.
Please consult this guide to figure a solution for your problem.
You can also create a new topic in the support section on our forum.
If you can reproduce the bug in Unturned without Rocket being installed you may report it directly to the Unturned developers.
Feel free to reopen this issue if you can bring up new details on the topic.


RefinementList widget shows dups when case type differs b/w facet and record

Describe the bug 🐛
The RefinementList widget shows duplicate listings in edge cases where the case type of a selected facet differs from the case type of the related record item (e.g. TitleCase vs UPPERCASE).
The bug appears when the facet is selected outside the normal InstantSearch flow (e.g. manually via the helper instead of directly in the refinementList widget).
To Reproduce 🔍

Using the default "basic routing" template, select Samsung:
https://lyw7mov3ql.csb.app/?refinementList[brand][0]=Samsung

Mimic a manual facet selection by changing the url from TitleCase Samsung to UPPERCASE SAMSUNG
https://lyw7mov3ql.csb.app/?refinementList[brand][0]=SAMSUNG

Refresh the page

Observe the correct results appear, but the refinementList shows duplicates (one for each case type)

Expected behavior 💭
RefinementList should only show one listing.
Screenshots 🖥

Environment:
All
Additional context
Most definitely an edge case. Everything works as expected if the facet is selected via the refinementList widget itself. It's only when the facet is changed manually elsewhere AND the records contain multiple case types that the bug appears.
I believe this stems from the Algolia engine using the case type of the first record indexed when defining each facet. So if record 1 shows TitleCase key: Value and record 2 shows UPPERCASE key: VALUE, the facet will be recorded as TitleCase for all records containing any version of key: value.
In my scenario, visitors can refine facets by clicking directly on the results item (see screenshot below). InstantSearch produces the correct results, but now the UPPERCASE version of the facet starts polluting the client producing the unintended results.
The upstream fix for most folks is to ensure records are normalized prior to indexing, but in my scenario the records need to be presented as-is.

Unfortunately, InstantSearch can't do anything about that. The engine treats facet in as case-insensitive. Indeed like you said the fix for this is to ensure that the data sent to Algolia always share the same case.
Since it's not an InstantSearch related problem, I'll close the issue. You can write a message to Algolia support. It's always interesting for us to have feedback on the product, especially on corner case like this one.