Fix test_salvage_auto_crash_all_replicas test case

It is hard to capture the pending state of the workload pod. Moreover, we only need to make sure that the pod is in running state and wait_for_pod_remount() returns true. That is enough to conclude that the pod was restarted and the volume was remount. Therefore, we removed the wait_for_pod_phase(core_api, pod_name, pod_phase="Pending")
After this PR is merged, this test case sometimes still fails because of the issue https://github.com/longhorn/longhorn/issues/1942
longhorn/longhorn#1914

cc @c3y1huang

@PhanLe1010 sorry about the late review, I'm a little concerned about this change since removing this means there is no checking for the intermediate state of pod restart. By the look, it takes at least 5 seconds until K8s get the pod termination request and I think the test could potentially miss the restart, checked for the pod before terminate and pass. I suggest to try-except this instead.

@c3y1huang Thank you for your review! I am sorry that I missed your comment.

By the look, it takes at least 5 seconds until K8s get the pod termination request and I think the test could potentially miss the restart, checked for the pod before terminate and pass

I think that is impossible that the test passed but the pod has never restarted. In fact, I think that we can skip both checking for the pod to be in Running state as well as Pending state.
Following the follow of the e2e test, we can see that the e2e test fist crash all replicas:
https://github.com/longhorn/longhorn-tests/blob/f8d1cebba1102a2bab365b784cfe8b5ba43b0e04/manager/integration/tests/test_ha.py#L531
This makes the volume faulty and Longhorn does auto reattachment. The e2e test then check this
https://github.com/longhorn/longhorn-tests/blob/f8d1cebba1102a2bab365b784cfe8b5ba43b0e04/manager/integration/tests/test_ha.py#L497
Because we removed all the auto-remount logic, the only way to pass this check is that the workload pod has to restart (either manually by user or automatically by Longhorn).
However, adding the  Running state as well as Pending state checking for the workload pod is nicer because it makes the e2e test clearer, easier to read  and follow. Therefore, I agree that we should try-except for checking the  Pending state.
Please correct me if I miss something :)


feat(*): implement Link modal

Signed-off-by: Diana Lease<EMAIL_ADDRESS>Issue #297

Nice. Note that I added this feature request today:
https://github.com/accordproject/cicero-ui/issues/379
Because images are just specialised links in Markdown, perhaps we can also use for to edit images?


Fix name_with_middle field for en-AU

The name_with_middle should be under the name field.

This isn’t right... name_with_middle is a sibling to name, not a child.

@stympy That's not the case with other files. Example files I found it opposite:

en-PAK.yml
ee.yml
en/name.yml

to name a few..

Are we looking at the same thing?
$ irb -ryaml
> YAML.load_file('lib/locales/en/name.yml')['en']['faker']['name'].keys

@stympy Let's take the ee.yml file: https://github.com/stympy/faker/blob/master/lib/locales/ee.yml#L42
You can see that name_with_middle is child of name there.

Ah, looking at it again, I see I misunderstood the context of the change. Yes, line 10 should be changed as in the patch, but line 11 should not be.

@stympy Reg line 11, yeah you're right. But according to YAML specification - that should also work. But I can change that if you would prefer not changing that.

Yeah, it would work, but it doesn't match the existing style. Please revert line 11 and this will be good to go. Thanks!

@stympy Pushed a new commit. I hope that works.

Perfect, thanks!


Secure Headers' config.hsts overriden by Rails' config.force_ssl

I have added Secure Headers to my webapp (for CSP), and so far it has worked great.
Now I am trying to implement HSTS preloading, and added config.hsts = "max-age=#{20.years.to_i}; includeSubdomains; preload", but noticed that Rails still sends a different "Strict-Transport-Security" header, which misses the "preload" keyword.
Upon investigating, it appears that because my Rails environment includes config.force_ssl = true (in order to redirect http->https, mark cookies as secure, etc.), Rails overwrites the "Strict-Transport-Security" header. The relevant code (for Rails 4.2) is here:
https://github.com/rails/rails/blob/4-2-stable/actionpack/lib/action_dispatch/middleware/ssl.rb#L48
Is it possible for Secure Headers to take priority over that other middleware?

Looks like https://github.com/twitter/secureheaders/blob/master/lib/secure_headers/railtie.rb#L13 is setting it to be the first in line but should this be after the ActionDispatch::SSL to ensure it doesn't get overridden?
@encoder to get around your issue you could always look to pop something like this in your config/application.rb.
config.middleware.insert_after(ActionDispatch::SSL, SecureHeaders::Middleware)

(Syntax may be slightly off so check it before just dropping it in)

To maintain backwards compatibility with Rails 3 and non-ActionDispatch::SSL applications we might need to the middleware to look something like this:
initializer "secure_headers.middleware" do
  if defined?(ActionDispatch::SSL)
    Rails.application.config.middleware.insert_after ActionDispatch::SSL, SecureHeaders::Middleware
  else
    Rails.application.config.middleware.insert_before 0, SecureHeaders::Middleware
  end
end

That looks great @jacobbednarz.

Pull request to follow shortly.

See discussion in #241; looks fixed in versions >= 3.1.0

🎊


Compatible to newer vim.

[ ] vim.inspect
[ ] vim.tbl_extend
[ ] vim.g
[ ] vim.schedule
[ ] vim.schedule_wrap
[ ] vim.regex
[ ] vim.NIL
[ ] vim.loop.new_timer

rg "vim.\w+" . | grep -v vim.call | grep -v vim.fn

rg "vim.\w+" . | grep -v vim.call | grep -v vim.fn | grep -v compat.lua

Vim's Lua integration needs vim.dict, vim.list, and boolean is treated as a number.
It is big difference for neovim's one. I'm giving up to make compatibility for a moment.


added vidstream as a proper provider

Better to just get from the source

Bruh, I'm quite baffled that vidstream is an actual anime site😭😭😭😭. I thought it was a hosting site or something, how naive I was.


Customizing the extract steps of SURF31.2.0 for NCI/BoM environment.

keyword_FCM keyword_SURF   |    by<EMAIL_ADDRESS>
Ticket history until now can be viewed at:
https://access-svn.nci.org.au/trac/surf/ticket/8

Issue migrated from trac:211 at 2024-01-31 18:15:20 +1100

<EMAIL_ADDRESS>changed keywords from `` to SURF, FCM

<EMAIL_ADDRESS>commented

Also see the following tickets which is relevant to the SURF build.
https://access-svn.nci.org.au/trac/nwp/ticket/1
https://access-svn.nci.org.au/trac/nwp/ticket/2

<EMAIL_ADDRESS>commented

Is it possible to use a similar approach with SURF as we do for the UM code - have a separate build config for Raijjin, e.g.:

https://code.metoffice.gov.uk/trac/um/browser/main/trunk/fcm-make/nci-x86-ifort
https://code.metoffice.gov.uk/trac/um/browser/main/trunk/rose-stem/site/nci

<EMAIL_ADDRESS>commented

Met Office conducts all the steps involved in SURF build on a single (target) machine. However, following a similar strategy to extract and build SURF in Raijin (target machine) haven't been successful.
There seems to be an issue with setting-up a password-less access to Met Office shared repository from Raijin. On my conversation with Ben Fitzpatrick of Met Office, it seems that the problem is arising from me using an older version of subversion (1.6.11)than the recommended svn version 1.8.
This is probably verified by the fact that I could cache the MOSRS password from Accessdev, which uses subversion 1.8.13. Raijin got a subversion/1.8.13 installed, but currently doesn't support "https" servers. I am in touch with Ben Menadue of NCI who said that he will try to rebuild it (email dated 11/08/2015). I am yet to hear from Ben.
I understand that we are encouraged at NCI to extract the sources in Accessdev and mirror it to Raijin. I could successfully do an extract and mirroring using FCM from Accessdev. However I think there are two important issues that needed to be addressed before we could go ahead with tour own procedure.
First, having a remote host involved means that that our version will differ from the Met Office version. This may require us to maintain our own version, increasing overhead.
Second, the SURF configuration is designed in a way that it is required to specify all the compilation environment from the beginning (i.e., before extracting). This means that the remote host environments will be written on to the FCM make configuration file during extract and mirroring and if there is a mismatch in the environments of local and remote hosts, per-process and build steps could potentially fail.
Sure, this can be overcome by modifying the FCM configuration files, but I guess this would be an extensive change and again requires substantial overhead in maintaining a code just for Accessdev/Raijin.
The easiest solution, as it appears to me, is to get the subversion/1.8.13 fixed.


Reduce repo size? Now stands at 114 MiB

Would it be possible to drastically reduce the repo size? (For instance, removing objects which are no longer being referenced.)
Upon cloning the repository I was surprised to find it's over 114 MiB in size:
$ git count-objects -vH
count: 0
size: 0 bytes
in-pack: 3724
packs: 1
size-pack: 114.09 MiB
prune-packable: 0
garbage: 0
size-garbage: 0 bytes

Note that the bulk of this is in .git/objects.
Considering that the repo appears to mostly be a collection of scripts and config files, is there a need or reason for it to be any more than a few megabytes?

If you download the ZIP from GitHub, you'll find it is only 3.2M. You only have to adjust the build instructions slightly to use this, rather than using the clone function.


feat: add size to index-stats API response

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
https://github.com/marqo-ai/marqo/issues/374

What is the new behavior (if this is a feature change)?
Index size will be returned as a field named size in the index-stats API response

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes

Related Python client changes (link commit/PR here)
There is no index/stats client method exposed in py-marqo. Do you want it to be added as part of this change?

Related documentation changes (link commit/PR here)

Other information:

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

Hi @hmacr ! Thanks for the PR!

Is it possible to rework this using the OpenSearch stats endpoint?

GET /{index}/_stats

indices.{index}.total.store.size_in_bytes

Can you add some a unit test for this please?
See here for the existing get_stats tests
https://github.com/marqo-ai/marqo/blob/mainline/tests/tensor_search/test_get_stats.py

Can you run please run tests.
Read here for how to do that: https://github.com/marqo-ai/marqo/blob/d39f2312e9e289b0c54f49e14cddd49095808ad4/CONTRIBUTING.md#unit-tests
You can run just the tensor_search tests, which are faster and use less resources, with the following:
tox -- tests/tensor_search
If you are having a lot of trouble running tests, I can create branch in our repo from your fork and run our pipelines against it, and pass you the feedback

@pandu-k Apologies, I understand it's been a long time since I created the pull request; I'm trying to be more active on open source these days.
About the review comments, I've addressed them and ran the unit-tests as well (attaching the screenshots; there was one failure due to an unavailable remote repo). Please let me know your feedback.


fixed BertForMultipleChoice model init and forward pass

the number of choices is not respected because you've hardcoded '1' into the classifier layer.  also token_type_ids and attention_mask will cause an error if None because None does not have a view method.

Indeed, it looks better.
Do you want to have a look and confirm @rodgzilla?

@thomwolf any word on this?

Oh yes sorry. Looking at it and reading Alec Radford's paper on GPT (section 3.3) again, I think @rodgzilla was actually right in the original implementation.
So I guess we should close this PR.
I still would have been happy to get @rodgzilla input on that.

Oh sorry, we should still keep the token_type_ids and attention_mask NoneType fixes.
These ones are correct!


removing unnecessary best fit condition.

The condition I'm removing actually stopped the logic from running when setting a best fit value since we no longer use true / false. Parsing and layout updates should happen whenever the value is changed anyway.
sorry for not catching this before we merged the previous PR.

Made a second fix after realizing I moved some of the interLine set logic inside the if by mistake.


Failure building Docker container using Dockerfile

Describe the bug
Get the following error when trying to build a docker container use the file 'Dockerfile' from the repo
#26 [docbuilder 8/8] RUN make docs
#26 0.186 npx --package=@stoplight/spectral-cli spectral --ruleset openapi/.spectral.json lint openapi/openapi.yaml
#26 1.392 (node:21) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
#26 1.392 (Use node --trace-deprecation ... to show where the warning was created)
#26 1.998
#26 1.998 /tmp/openapi/openapi.yaml
#26 1.998  4:11  error  oas3-schema  "version" property must be string.  info.version
#26 1.998
#26 1.998 ✖ 1 problem (1 error, 0 warnings, 0 infos, 0 hints)
#26 2.031 make: *** [Makefile:48: static/docs/index.html] Error 1
#26 ERROR: process "/bin/sh -c make docs" did not complete successfully: exit code: 2
Describe your setup
gitlab ci platform
How to reproduce
trigger build
Expected behavior
No errors....  Successfully built container

used gitlab to 'mirror' the repo on githup.    gitlab, in their infinite wisdom, chose a different branch as the 'default'.   setting default as the main branch resolved the problem.    sorry for the distraction.


Disable NPM error in the runs by passing --silent to CMD.

Can we test this on beta on the platform?

Yeah, once this is merged to master, it will be automatically deployed as beta. If okay we can manually deploy it as prod

I tested all the Beta images and everything looks fine. The error now looks like this
https://my.apify.com/view/runs/bjj3RxQCRpzJH9PyZ


Convert RuCLIP model to ONNX

I spent some time and adapted RuCLIP to onnx format. Add inference example.
Github link

@Lednik7, thank you a lot. It is advantageous! Could you create a pull request in main? I can do it by myself, but It is your contribution. appreciate it

@Lednik7 if you don't have enough time, I can do it myself - let me know

Hello @shonenkov! Thanks for your feedback. I have a pull request at https://github.com/sberbank-ai/ru-clip/pull/16


HV-1365 Creating common classes of property path example;

Adding examples for containerClass and getTypeArgumentIndex()
@gsmet This adds executable examples for the newly added cases. I suggest to open a follow up issue to add the missing ones for the existing cases, too.
https://hibernate.atlassian.net/browse/HV-1365
Btw. one should be careful when taking the output from the RI because it could be erroneous or not what's intended in the spec actually. So what I did was to add the expected output manually and then verified by replacing it with the actual output from the RI.

Merged, thanks!


Please merge revision #TBD into dev channel

@whesse @mit-mit @kasperl @dgrove
<Fill in the labels for Milestone and Area to indicate what the merge applies to. E.g. if you're requesting a merge to fix an issue in Dart2JS, set the area to Area-Dart2JS. If this is a request to merge to stable please change the MergeToDev label to MergeToStable>
<Describe the problem this merge is fixing - include issue numbers if applicable>
Works around a Dartium crash from isolates being shutdown without being properly started.
Fixes a test expectation that was broken by the re-inclusion of dart:profiler.
<What revision(s) needs to be merged - please annotate revisions with reason if more than one>
Note: These are Webkit revisions
svn://svn.chromium.org/blink/branches/dart/dartium@202696 - https://codereview.chromium.org/1428333002
svn://svn.chromium.org/blink/branches/dart/dartium@202696 - https://codereview.chromium.org/1421553011
And then the corresponding update to tools/deps/dartium.deps/DEPS

I'm quite sure this will merge cleanly :-)

Merged in 1.13.0-dev.7.10


No triples with xmlns in XML source

Using XML input for the RML mapper gives unexplained behaviour, at least to me.
No triples are created when in the xml input a namespace is defined like
xmlns="http://graphml.graphdrawing.org/xmlns"
rdfizer has the same behaviour, see issue
Can this be explained?
yedmapping1.rml.zip

XML namespaces are now well supported in RML, there's a proposal in the Knowledge Graph Construction Community Group to properly support it: https://github.com/kg-construct/rml-target-source-spec
However, there's some support for namespaces in the RMLMapper, I tried your mappings and could reproduce it.

I had a similar issue with some XML mappings. They were working well until the changes to fix #144 were introduced.
However, I found that since then, XPath expressions MUST include prefix declarations, if these are defined in the source XML.
This means that wxpressions referring to nodes of the default namespace need to include : for them to work. @RichDijk I tested this mapping on your example and it worked:
@prefix rr: <http://www.w3.org/ns/r2rml#>.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>.
@prefix rml: <http://semweb.mmlab.be/ns/rml#>.
@prefix ql: <http://semweb.mmlab.be/ns/ql#>.
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>.
@prefix data: <http://data.zorgaanbiederX.nl/data/>.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>.
@prefix wlz: <http://purl.org/ozo/wlz#>.
@prefix skos: <http://www.w3.org/2004/02/skos/core#>.
@prefix yedd: <http://www.yed.com/yedd#>.
@base <http://data.zorgaanbiederX.nl/data/>.

<#IdNode>
    a rr:TriplesMap;
    rml:logicalSource [
    	rml:source "skos1a.graphml";
    	rml:referenceFormulation ql:XPath;
        rml:iterator "/:graphml/:graph"];
    rr:subjectMap [
    	a rr:Subject;
    	rr:termType rr:IRI;
    	rr:template "http://www.yed.com/yedd#node_{@id}";
    	rr:class yedd:Node;
    ];
.


15 refactor

Code refactor
Replaced standard log in with hclog
Added unit test for some function and files

Code refactor
Replaced standard log in with hclog
Added unit test for some function and files


SAK-48234 do not modify default JVM locale

Thanks @ottenhoff and sorry if this caused problems, you can always ping us in the Jiras to fix this.

@josecebe I remember you fixing this for UPV, could you also double check this fix? It looks good to me.

I dont mind fixing if it's easy and straightforward!


Expanded PublicKeyCredentialCreationOptions

Hey folks,
This might be a change that brings changes to clients using the library, so please review carefully. Maybe this one requires a version-change? We could opt to maintin existing behaviour, although I would be careful with that option as well, as effectively clients are currently using an incomplete implementation of the spec? Open to hearing what direction to take and adjust as necessary.
I added some code so the options returned from beginRegistration now contain more fields from the spec.
Without these changes, I noticed that on Android, passkey-authentication could be used, however, after signup, the passkey did not seem to be stored anywhere. And so if a user was logged out, they could not sign in again with the created passkey.
With these changes, that issue is now resolved.

Just checking in on this one, as I'm getting closer to going live using this package.
Any (rough) e.t.a. on when this will be merged in? Any pending adjustments maybe?

@dimitribouniol @Joride are they any particular reasons why this PR can't be merged? I wanted to build on this PR to expose aaguid, aaid so that relying party can filter passkey authenticators based on the fido metadata blob

From my perspective this is Ok from a functionality perspective. I've been using this change now for a few months, haven't run into any issues.
I think I addressed the various comments and suggestions, so I would be happy to see it merged.

I'll take a closer look reviewing it tomorrow morning when I get some time.


Adding two animations at once results in error at time of remove (addAnimation is not async)

I'm using Custom Token Animations with DAE firing and ItemMacro. I can get the animations on the token great. When the removeAnimByName fires I get an error for id being undefined. I have a console log in the script and have confirmed that a token object is being passed into the functions. Here is what I have for the snippet
if(args[0]==="off"){
console.log(myToken);
await CTA.removeAnimByName(myToken, "extraFire", false, true);
await CTA.removeAnimByName(myToken, "auraFire", false, true);
}
this is what the add function looks like to show that the names match
if(args[0]==="on"){
await CTA.addAnimation(myToken,extraFireData,false,"extraFire", false);
await CTA.addAnimation(myToken,auraData,false,"auraFire", false);
}

Ive strengthened the logic behind adding/removing multiple animations. the textureData and name paths can now accept arrays to create/delete multiple at once


Tile Size Issue

In this line of code,
gt.generate_tiles(r'/path/to/output/folder', tile_x=256, tile_y=256, stride_x=256, stride_y=256)
i am not able to change the tile size to 64 . It takes 256 only...What can be the reason?
Thank you,

Hi @protestToViolence, this is actually a bug I just corrected it. Thank you very much for reporting it. Please try to install the 0.2.4 version and it will solve the issue.


Can't load eBPF probe in GKE

We are migrating our Falco deployment to version 0.24.0 in GKE running v1.15.11-gke.15 with Ubuntu nodes running the standard kernel for that Kubelet version (5.0.0-1032-gke). Since there's no pre-compiled eBPF probe as it used to be in the earlier version we're running, we are compiling it on the fly when the container starts. The eBPF probe seems to be built correctly by falco-driver-loader but Falco errors out and states it can't load the module when it starts up.

How to reproduce it

Create Daemonset with official Falco image (mounting all recommended volumes, according to the documentation).
Containers should fail with the message below.

Expected behaviour
To have the eBPF probe be compiled and loaded correctly.

Screenshots
# falco-driver-loader
* Running falco-driver-loader with: driver=bpf, compile=yes, download=yes
* Mounting debugfs
* Found kernel config at /host/boot/config-5.0.0-1032-gke
* Skipping compile, eBPF probe is already present in /root/.falco/falco_ubuntu-generic_5.0.0-1032-gke_33.o
* Skipping download, eBPF probe is already present in /root/.falco/falco_ubuntu-generic_5.0.0-1032-gke_33.o
* eBPF probe located in /root/.falco/falco_ubuntu-generic_5.0.0-1032-gke_33.o
* Success: eBPF probe symlinked to /root/.falco/falco-bpf.o

/# FALCO_BPF_PROBE="" falco
2020-07-28T15:23:57+0000: Falco initialized with configuration file /etc/falco/falco.yaml
2020-07-28T15:23:57+0000: Loading rules from file /etc/falco/falco_rules.yaml:
2020-07-28T15:23:57+0000: Loading rules from file /etc/falco/falco_rules.local.yaml:
2020-07-28T15:23:57+0000: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
2020-07-28T15:23:57+0000: Unable to load the driver. Exiting.
2020-07-28T15:23:57+0000: Runtime error: can't create map: Errno 1. Exiting.

Environment

Falco version: 0.24.0

System info:

{
  "machine": "x86_64",
  "nodename": "xyz",
  "release": "5.0.0-1032-gke",
  "sysname": "Linux",
  "version": "#33-Ubuntu SMP Tue Mar 3 05:23:54 UTC 2020"
}

Cloud provider or hardware configuration: GKE
OS: Container: Debian GNU/Linux 10 (buster) // Node: Ubuntu 18.04.04 LTS (GKE version, so different kernel)

Kernel: Linux gke-nodename-5-4c22c87d-zk53 5.0.0-1032-gke #33-Ubuntu SMP Tue Mar 3 05:23:54 UTC 2020 x86_64 GNU/Linux

Installation method: Official Falco Docker image with custom entrypoint script.

Additional context

Unfortunately busy with something else now. But a first pointer for me and other maintainers: https://github.com/draios/sysdig/blob/4790332c24c5c81e168663f9852c5bb738d7d9ae/userspace/libscap/scap_bpf.c#L313
The problem seems to be caused by the BPF_MAP_CREATE not returning a FD referring to the map (EPERM errno?).

I've made some more tests and found that this only happens when we have Secure Boot/Shielded Nodes enabled in our K8s cluster running Ubuntu - this issue doesn't happen when we have Shielded Nodes/Secure Boot in COS. When I try to deploy Falco 0.24.0 to a cluster with those two features disabled, things work just fine - the probe is compiled and loaded without a problem.
So, I believe the updated steps to reproduce are:

Create a cluster in GKE with Secure Boot and Shielded Nodes enabled. Nodes are Ubuntu (COS don't have this problem).
Try to deploy the official Falco 0.24.0 image to the cluster.
Make sure env vars FALCO_BPF_PROBE and SKIP_DRIVER_LOADER are set to "".
You should see the Runtime error: can't create map: Errno 1. Exiting.

Let me know if you have trouble reproducing.

@pogao: There is not a label identifying the kind of this issue.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@wyardley: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pogao did you ever find a workaround?
Can this issue be reopened?

@wyardley sorry - i don't keep up with my gh notifications lol. It looks like this doesn't happen anymore on the latest version using Shielded Nodes. I don't really know why, though - it just worked on my recent tests.


Fix downloader queues & tests

What's the reason for changing heap based to set based prio-q?
My heap based queue implementation was flawed for 2 reasons: 1) it accessed an internal member of the container, 2) the underling heap are not assured to be in order if you iterate over it. And I need to iterate over it to count expired timers (to compute how many requests can I make to peers)


Additional guidance for creating Durable Functions in Azure Portal

I think it will be better if we guide the users to the template. I was a bit confused when I did not see the template in the default template page when Core is pre-selected for Scenario.

@gled4er : Thanks for your contribution to the Azure documentation! The author, @cgillum, has been notified to review your proposed change.

@gled4er Thanks for the clarification!

#sign-off


setTextColor() doesn't set the color to spinner items.

Hello.
setTextColor() method works only before items are assigned.
So, when I want to change spinner with the inflated list of items - I can't. It just changes the color of main spinner item.
Currently, I solve this by resetting the item list.
Please, take a look at this issue.

use   app:ms_text_color property to set text color.

I needed to change colors dynamically. I used something else at that time when I needed it.

i can confirm. This is very annoying bug


ZEVA - Cannot remove the 0 value in Quantity of Credits and Value per Credit boxes

Describe the Bug
When initiating a credit transfer the user cannot remove the zero in front of Quantity of Credits and Value per Credit. Even if you add a number to the other side of the 0 it does not delete the 0; therefore it inputs an incorrect value (ex. entering 50 will enter as 500 because of the extra 0)
Expected Behaviour
The user should be able to delete the initial 0 in the box when trying to enter the value for Quantity of Credits and Value per Credit.
Actual Behaviour
Currently the user cannot delete the 0 from the Quantity of Credits and Value per Credit.
Implications
Can potentially cause the user to input an incorrect value.
Steps To Reproduce
Steps to reproduce the behaviour:
User/Role:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Notes
We use the  component to display the "Quantity of Credits" and "Value per Credit". The defaultValue prop passed to it is {rows[rowId].value || 0}; this means that you cannot delete the initial zero, so we should modify this.

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @tim738745


coredns: 1.9.1 -> 1.9.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/coredns/versions.
meta.description for coredns is: "A DNS server that runs middleware"
meta.homepage for coredns is: "https://coredns.io"
meta.changelog for coredns is: ""
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.2 with grep in /nix/store/qw6n9kqikgaqfj3xi9vs1vwzxj8nfmpa-coredns-1.9.2
found 1.9.2 in filename of file in /nix/store/qw6n9kqikgaqfj3xi9vs1vwzxj8nfmpa-coredns-1.9.2

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
coredns
kuma
kuma-experimental

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qw6n9kqikgaqfj3xi9vs1vwzxj8nfmpa-coredns-1.9.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A coredns https://github.com/r-ryantm/nixpkgs/archive/ff7d60fdcfc64347d1d512b3d5efb820ca095121.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qw6n9kqikgaqfj3xi9vs1vwzxj8nfmpa-coredns-1.9.2
ls -la /nix/store/qw6n9kqikgaqfj3xi9vs1vwzxj8nfmpa-coredns-1.9.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

coredns
kuma
kuma-experimental

Maintainer pings
cc @rushmorem @rtreffer @DeltaEvo @superherointj @kalbasit for testing.

Result of nixpkgs-review pr 174524 run on x86_64-linux 1

3 packages built:

coredns
kuma
kuma-experimental


grpcio 1.62.2

Problem
Sometimes gprofilter hangs
Causes

grcp hangs (broken threading control) when multiple CRI clients are trying to query newly created container with (thd.cc:160  pthread_create failed: Invalid argument source )

sometimes start_process (Popen) hangs because of preexec_fn

[!CAUTION]
The preexec_fn parameter is NOT SAFE to use in the presence of threads in your application. The child process could deadlock before exec is called. https://docs.python.org/3/library/subprocess.html#popen-constructor

Solution

use single CRI client
replace preexec_fn with start_new_session flag.

start_new_session covers os.setpgrp, it's not possible to set PR_SET_PDEATHSIG without preexec_fn

But we needed the PR_SET_PDEATHSIG :/ If we give up on it, we need to verify that all existing uses of start_process are safe even w/o PR_SET_PDEATHSIG.

start_new_session covers os.setpgrp, it's not possible to set PR_SET_PDEATHSIG without preexec_fn

But we needed the PR_SET_PDEATHSIG :/ If we give up on it, we need to verify that all existing uses of start_process are safe even w/o PR_SET_PDEATHSIG.

Added manual process clean up. SIGKILL is not supported though.

That's a bummer - the SIGKILL use case is not uncommon (e.g: gProfiler getting OOM). I'd like us to think of something that handles SIGKILLs as well.

@slicklash - @d3dave had a cool idea to allow us to continue using PDEATHSIG - we can create a tiny shim program to handle that. For example, instead of:
p = subprocess.Popen(["/path/to/py-spy", "arg1", "arg2"], ....)

we'll build (as part of gProfiler's CI) a tiny program written in C/C++/Golang (or even bash if bash supports it) that only sets PDEATHSIG on its own PID, and immediately execves its following arguments:
p = subprocess.Popen(["/path/to/pdeathsigger", "/path/to/py-spy", "arg1", "arg2"], ....)

this way we can get rid of preexec_fn.
As for this tiny program - I'm not sure if bash/sh support this prctl call; if shells support it, since gProfiler already assumes a shell exists, we can use a wrapper shell script for our subprocess calls.
If no shell support, then add a build script and call it from the Dockerfile - a script that'll build this tiny program (whose code should be in this repo as well). You can choose the language but I think C makes sense to make it slim and lean. Build it on the same layer where we build the Python itself (so it's build against same glibc version, etc).
Then update the branch and ping us for re-CR :)

@slicklash please ping @d3dave and me when it's ready for re-review?

@slicklash I'm unsure what this PR solves now. gProfiler already creates only a single ContainersClient object, only during tests we create more than one (and in diagnostics.py mode).
Inside the single ContainersClient, we do create several CriClients but only upon startup (as we try v1 and v1alpha2 and check containerd and crio).

Tests show the problem with implementation of ContainerNamesClient itself. There should be only one live CRI instance in multi-threaded context otherwise gRPC hangs. Tests are part of code base and need to be maintained with same care as production code.

I see, so this fixes the ContainerNamesClient code and effectively fixes the tests.


Error: Could not set 'present' on ensure: Failed to install plugin

Puppet config:
# Elastic
    class { 'elasticsearch':
        package_url => 'https://download.elasticsearch.org/elasticsearch/elasticsearch/elasticsearch-1.0.1.deb',
    }

    elasticsearch::instance { '9200':
    }

    elasticsearch::plugin{'mobz/elasticsearch-head':
        module_dir => 'head',
        instances  => '9200'
    }

Error: Could not set 'present' on ensure: Failed to install plugin. Received error: #<Puppet::ExecutionFailure: Execution of '/usr/share/elasticsearch/bin/plugin -Des.path.conf=/usr/share/elasticsearch install mobz/elasticsearch-head' returned 74: -> Installing mobz/elasticsearch-head...
Failed to install mobz/elasticsearch-head, reason: plugin directory /usr/share/elasticsearch/plugins/head already exists. To update the plugin, uninstall it first using -remove mobz/elasticsearch-head command> at 141:/etc/puppet/modules/elasticsearch/manifests/plugin.pp

It throws this error every time, plugin is active and working

Thanks for the report - we just merged #660, which should permit the use of the module_dir parameter again (the current state is deprecated and doesn't actually do anything). The fix is in master and should be a part of the next release.


Towny Options

This is not a bug, but a feature request. Please forgive me if this has a solution that i have not yet found. In Towny, currently you have to have a plot set to Shop in order to create a shop, which is fine; however you cannot have a plot set as an embassy and a shop plot at the same time, which keeps anyone from building a mall area and selling "shops" to players outside their towns. Could you please make a way for players to place shops on embassy plots while still maintaining the towny protections?

I know this isn't quite the answer you're looking for, but it should be possible to have a player from another town claim an embassy and then set the plot to a shop.

I'll try creating a configurable list of plot types that should allow shop creation.

I will play around with colorfulchew's suggestion, but a list of plot types would be fantastic!

That does work! Thanks! I do think having different plot types as options might be helpful though.


Testing client CI

Description:
This PR adds a CI  pipeline to test the client side of BastionLab. The pipeline includes the following steps:

Build and installation of the client
Wait for the build of the server, download the artifact and launch the server through Docker
Install the necessary dependencies for the testing of the client
Testing with flake8
Testing with mypy
Testing with pytest-cov
Upload of the report made by pytest-cov

The benefits will be to no longer regress in the developpement of BastionLab client and automate the testing.

Is the testing with Mypy necessary? Can't flake8 do what Mypy is doing?

Is the testing with Mypy necessary? Can't flake8 do what Mypy is doing?

As I have understood, flake8 does more of a static analysis and mypy does more of a hybrid analysis. This CI was based on what has been done on BastionAI previously. But i can totally remove one of the tests if it is not necessary.

Is the testing with Mypy necessary? Can't flake8 do what Mypy is doing?

As I have understood, flake8 does more of a static analysis and mypy does more of a hybrid analysis. This CI was based on what has been done on BastionAI previously. But i can totally remove one of the tests if it is not necessary.

Leave it as it is, it has its usefulness.
I was mostly curious about the approach of this test.

Please resolve the conflicts with the documentation notebooks
The code MUST be the same as in master


Load autosave data on open

Issue:
The app should load from IndexedDB or some permanent local storage.
When the user is loading autosaved data upon opening a file, the app should detect & warn me if my file changed on DCS and my local autosave data is stale.  In this case, user should have the options Save / Discard / Cancel.  SAVE: will overwrite DCS with my current autosave content.  DISCARD: delete my stale autosaved data.  CANCEL: abandon the current action (e.g., switching files, opening file).
DoD:
When opening a file, the user is prompted to save or discard autosave data if it is older than the user's file on DCS.
Also includes Styleguidist demo for the RCL. Provide proper documentation.
Issue:
See notes in spike:
https://app.zenhub.com/workspaces/tc-create-workspace-5f049cdbfa88090016bf043e/issues/unfoldingword/tc-create-app/867

@mandolyte
For now, I have left a lot of console.log().
I can remove these after review, please.  Thanks.

testing notes from issue:
https://app.zenhub.com/workspaces/tc-create-workspace-5f049cdbfa88090016bf043e/issues/unfoldingword/tc-create-app/867

open TSV or MD file
edit the file
onblur: mouse out of current edit block (?not necessary?)
disable Internet (use FIDDLER2 or turn off wifi?)
try to save (--> verify friendly error message)
close browser
ENABLE Internet
open tC Create; open same file you were editing before
verify: autosaved content is displayed
save file
close browser / open file: verify saved content is correct

Autosave Case #1:

open TSV or MD file
edit the file
onblur: mouse out of current edit block (?not necessary?)
close browser (and/or close tab?); verify friendly error message
open browser & visit same file as before: verify auto-saved content is available
(alternate #5: open a DIFFERENT file & edit.  THEN open the original file in step #1. Verify autosaved content for file #1 is correct)

Scenario 2:
DCS USER BRANCH CHANGED (IN "ANOTHER SESSION" - simulated by deleting branch)
⚠ NOTE: this test also simulates an important scenario:
If MASTER was updated in DCS, the GL team should DELETE user branches... (gatewayAdmin?)
(or they could merge into --> user branches, for example...
But the point is that the USER BRANCH changed outside the app and we need to notify the user.)
using DEVELOP url:
logged in with org unfoldingWord and resource tN and language English
selected book of Jude
made an edit and saved it
In QA DCS ⚠😊 DELETE the user branch.
Close tCC and OPEN to the AutoSaved file.
selected Jude again
VERIFY: the user is prompted to KEEP/DISCARD.

translationCore Create - v1.4.0-rc.5 build 111-7f5491d. Sometimes not seeing the Modal prompting for Keep/Discard changes. I saw this prompt once as shown in the screenshot below:

Please see the error in the console when I am not seeing the Prompt, after I delete me user branch in DCS.

translationCore Create - v1.4.0-rc.5 build 111-7f5491d.
When there is a newer version on DCS i.e the user branch is stale/old data, I am seeing the prompt message with the options to Discard/keep the autosaved file.
If Discard is chosen, I see a fresh file opened from the DCS. If Keep is chosen, I see that the autosave data is preserved and upon saving the file again, the current changes are saved in the DCS user branch.


Use JSON Pointer syntax for column names in the JSON importer

Is your feature request related to a problem or area of OpenRefine? Please describe.
The column names created by the JSON importer are always a bit annoying, full of _ and -.
This is meant to reflect the original structure of the JSON blob, but as far as I know it is not possible to reuse these names to automatically export back the project to the same JSON format after cleanup. So in a sense we are hurting usability (weird column names) without improving machine-readability (no JSON reconstruction feature).
It would be much nicer if the format of these column names followed an existing standard. I discovered JSON pointer (https://www.npmjs.com/package/json-pointer, also RFC 6901) which does that.
Example: the JSON blob { foo: 1, bar: { baz: 2}, qux: [3, 4, 5]} can be flattened as:
/foo -> 1
/bar/baz -> 2
/qux/0 -> 3
/qux/1 -> 4
/qux/2 -> 5

Describe the solution you'd like
Make it possible to import a JSON file using JSON Pointer to derive the column names.
The resulting table would not use the records structure, it would be a flat tabular file.
Describe alternatives you've considered
We could also have an option in the JSON importer to just get simpler column names without the ability to restore the full JSON structure out of them (for other use cases).
Additional context
Pointed out by @literarymachine

Yeah, this looks good.  I did have to double check RFC 6901 to ensure JSON string values can be processed with Json Pointer syntax.  They can:

JSON String Representation
A JSON Pointer can be represented in a JSON string value.  Per
[RFC4627], Section 2.5, all instances of quotation mark '"' (%x22),
reverse solidus '' (%x5C), and control (%x00-1F) characters MUST be
escaped.
Note that before processing a JSON string as a JSON Pointer,
backslash escape sequences must be unescaped.

@wetneb I am interested to work on this. However, I may not have the full context on this.
Does replace "-" with "/" resolve the issue?
And what do you mean by "The resulting table would not use the records structure, it would be a flat tabular file."?

Does replace "-" with "/" resolve the issue?

I think you might need to tweak it a bit further to conform to the JSON Pointer specs.

And what do you mean by "The resulting table would not use the records structure, it would be a flat tabular file."?

You could try importing my JSON example above and compare the current behaviour of the JSON importer to the behaviour described above.

And what do you mean by "The resulting table would not use the records structure, it would be a flat tabular file."?

In OpenRefine, when you work the data, there is 2 mode: row or record. Records exists to enable ONE level of hierarchy. But, in a JSON file, you have many branches, any number actually. So OR cannot exactly represent the hierarchical nature of a JSON.
I think that @wetneb meant that you should not try to use the record mode, but rather stay in a pure tabular mode (the row one).

I see, thanks @wetneb  and @antoine2711  for your reply! I can start to look into it now :)

I'm not especially familiar with the full hierarchical structures of JSON, but the tables I've been importing lately are a straightforward key:singleValue style (with every record having the same set of keys) so I expected them to come into an OpenRefine project just as if I'd imported a CSV. So this is just to say that I support whatever option might need to be added to have this work without adding the "_ - " at the start of all the column names.


Active Idle Service Stops Fetching after 30mins - 45 mins

Describe the bug
Active Idle Service running from CLI or Running Service stops Fetching after 30mins - 45 mins
Code used.
public function handle() {

    if (is_array($this->account)) {
        $client = Client::make($this->account);
    }else{

        $oClient = Client::account('default');
    }

    try {

        $client = $oClient->connect();

    } catch (ConnectionFailed $e) {

        Log::error($e->getMessage());
        return 1;
    }
    $message_mask = \Webklex\PHPIMAP\Support\Masks\MessageMask::class;
    $client->setDefaultMessageMask($message_mask);
    /** @var Folder $folder */
    try {
        $folder = $client->getFolder("INBOX");

    } catch (ConnectionFailedException $e) {
        Log::error($e->getMessage());
        return 1;
    } catch (FolderFetchingException $e) {
        Log::error($e->getMessage());
        return 1;
    }

    try {
        $folder->idle(function($message){
            $this->info($message->getSubject());
            // dump("new message", $message->subject);
        });

    } catch (\Exception $e) {
        Log::error($e->getMessage());
        return 1;
    }

}
Desktop / Server (please complete the following information):

OS: WIndows 10 / Ubuntu 20.04
PHP: 7.2,5
Version 2.2.3

Hi @narguelles ,
I assume it fails? Or how are you determining the state? If it fails indeed, please take a look at you logs and look for the related stack trace.
Best regards,

Thanks, it stops on client->connect if it has reconnected for 3-5 times.

Hi @narguelles ,
I don't fully understand how to reproduce it. You mean in your above mentioned code sample, the program stops on line 12 ($client = $oClient->connect();) if the command has run multiple times and wont throw an error just "halt" there?
Best regards,

catch (\Webklex\PHPIMAP\Exceptions\RuntimeException $e) {
if(strpos($e->getMessage(), "connection closed") === false) {
throw $e;
}else{
$this->info('Reconnect');
$client->connect();
$client->openFolder($folder->path);
$connection = $client->getConnection();
$connection->idle();
$this->info('idle');
}
}
It reconnects to 4-5 times, after that it just stops at the $client->connect

Hi @narguelles  ,
thanks again for your report :+1:
Please update your php-imap dependency to v2.2.5.
Best regards,

Thanks


[Feature] Add extra difficulty mode?

Perhaps this is too ambitious to be possible but could there at some point in the future be an added difficulty level to the game? After all, Ironman mode simply adjusts how the save function works. It would be much better to also have a mode where the enemies have more hitpoints and deal more damage more often.

Yeah I do have some plans for that... gotta finish the Prestige Classes first ;)


Add methods to create ArrayBuffers from byte arrays

Summary
This PR adds a factory method to the ArrayBuffer class, so that JSI methods can return them as results.
Changelog
[General] [Added] - Factory method for ArrayBuffer in the JavaScriptCore implementation of JSI
Test Plan
I have a test app where I can directly return data from LevelDB and see ArrayBuffers on the JS side! Let me know if I should add a test case to rn-tester.

This change is

FYI - this quite similar to https://github.com/facebook/react-native/pull/28961 from @ryantrem
I'm CCing the same people here in hopes of getting it merged in! :-)
@mhorowitz, @tmikov @bghgary @ @shergin

You are adding new method to the base JSI interface but only implemented it for JSC. It seems like If we merge it, it will break the Hermes JSI implementation.

I believe everything under ReactCommon/jsi/jsi is automatically merged from https://github.com/facebook/hermes/tree/master/API/jsi/jsi, so I think you need to make API changes there first and wait for them to be migrated to the react-native repo before adding a JSC specific implementation of createArrayBufferFromBytes.

This PR adds a factory method to the ArrayBuffer class, so that JSI methods can return them as results.

It would be great to see this change make it in. This would be really helpful when dealing with large blocks of data managed by native code but accessible by JavaScript. We would definitely use it in BabylonReactNative.

As per the discussion on https://github.com/facebook/hermes/pull/419 this can be done by getting the ArrayBuffer constructor: https://gist.github.com/mhorowitz/4915d43b8d82ae0eb98a157e689ba23e
So I'm closing this PR.

@savv this does still copy the "byte array". In my case I receive a buffer (void *) from an API and I would like to create an ArrayBuffer from that given void * buffer, that is currently not possible using JSI and your PR would solve this (afaik) - so why close it?

Capturing our discussion for posterity:
The implementation in this PR was still copying bytes around. You’d have to change Hermes in a few places to use std::move instead of copying strings, may be difficult (I don't understand Hermes's memory ownership model enough to comment)


Can you write the command for SWE Bench, I could not understant about below statement

Describe the issue
This is the command I have been using to run a single instance!!
python run.py --model_name gpt4 \
  --instance_filter marshmallow-code__marshmallow-1359

More context is available on #711 issue.
What changes it require according to the below statement? Can you write one?
The above examples use the default value of --data_path (Princeton-nlp/SWE-bench_Lite, which will be looked up from huggingface). You can specify any other huggingface datasets as well, or supply the path to a pre-downloaded dataset. By default, the SWE agent evaluates the dev split of that dataset. You can change that by supplying the --split argument to the above commands (obviously you shouldn't tune your model on the test dataset).

Create an example command to run swebench.
For Single Instance:
For Full SWE Bench Lite:
Thanks.
Optional: Relevant documentation page
No response

It means that you need to be careful about which split of the dataset you're using (dev or test), because the default settings are different.


sugg

hey, can I add here that the player still sees the prop after logging in? because currently it works in such a way that if a player leaves and enters, he is the only one who does not see the prop, but everyone else sees what is bothersome.

Thank for the feedback first of all, i will work on a fix for this :)

This is solved in last commit :)


upload of files do not work

I have this code in one server that uploads a file as a formdata to another server:
                const fd = new FormData();
                let en;
                fd.append('i', FS.createReadStream("/tmp/trash.jpg"));
                try {
                    en = await FETCH("https://destiny.com", {
                        method: 'POST', body: fd, headers: fd.getHeaders()
                    }).then(r => {
                        return r.json();
                    });
                } catch (e) {
                    console.log(e);
                }

On the destiny, i use node HTTP and Formidable to receive the file but it gives error:
Error: Request aborted
    at IncomingMessage.<anonymous> (.../node_modules/formidable/lib/incoming_form.js:122:19)
    at IncomingMessage.emit (events.js:315:20)
    at abortIncoming (_http_server.js:536:9)
    at socketOnClose (_http_server.js:529:3)
    at Socket.emit (events.js:327:22)
    at TCP.<anonymous> (net.js:674:12)

But if i use the curl to make a upload from server 1 to server 2 it works perfectly:
curl -F<EMAIL_ADDRESS>https://destiny.com
I was using the package require but is obsolete. With require it was also working. Also, i have a developing computer in which the node-fetch works well. I do not understand what is the problem. All the nodes and npm packages are on the same versions.
Any suggestions? Thank you.

I gave up and stop using node-fetch.

I'm struggling too and I'd not be surprised to learn that there is a big node-fetch regression somewhere that breaks FormData + readFileSync

@Kaspanoombro
I had same issue today and found https://www.npmjs.com/package/isomorphic-form-data that solved it.
Example:
async function sendFile() {
    return new Promise(async (resolve, reject) => {
        try {
            const formData = new FormData();  // requires isomorphic-form-data npm
            formData.append('file', fs.createReadStream("./yourfile"));
            let response = await fetch('https://yourwebsite.com/endpoint', {
                method: 'POST',
                body: formData
            });
            let res = await response.json(); //if server replied with json
            resolve(res);
        } catch (error) {
            reject(error);
        }
    });
}


Update Finagle to 22.12.0

See https://github.com/twitter/finagle/releases

Codecov Report

Merging #521 (bf563b7) into main (78cd0ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   90.60%   90.60%
=======================================
  Files          18       18
  Lines         298      298
  Branches        2        2
=======================================
  Hits          270      270
  Misses         28       28

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I'm kind of surprised there were no breaking changes in this release. Can we double-check that the MiMa "extra projects" are being checked correctly? If so, this lgtm.

@bpholt Indeed, the MiMa isnt set up correctly and doest run on the rootFinagle project. Will check :)

sbt:rootFinagle> mimaReportBinaryIssues
[info] rootFinagle: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[error] finagle-core: Failed binary compatibility check against com.twitter:finagle-core_2.13:22.7.0! Found 28 potential problems
[error]  * method totalPending()Int in interface com.twitter.finagle.loadbalancer.Balancer does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.Balancer.totalPending")
[error]  * method pending()Int in interface com.twitter.finagle.loadbalancer.LeastLoaded#LeastLoadedNode does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.LeastLoaded#LeastLoadedNode.pending")
[error]  * method totalPending()Int in class com.twitter.finagle.loadbalancer.Metadata does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.Metadata.totalPending")
[error]  * abstract method pending()Int in interface com.twitter.finagle.loadbalancer.NodeT does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.NodeT.pending")
[error]  * class com.twitter.finagle.loadbalancer.PanicMode#ToggledPanicMode does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.loadbalancer.PanicMode$ToggledPanicMode")
[error]  * class com.twitter.finagle.loadbalancer.PanicModeToggle does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.loadbalancer.PanicModeToggle")
[error]  * object com.twitter.finagle.loadbalancer.PanicModeToggle does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.loadbalancer.PanicModeToggle$")
[error]  * method rate()Int in class com.twitter.finagle.loadbalancer.PeakEwma#Metric does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.PeakEwma#Metric.rate")
[error]  * method pending()Int in interface com.twitter.finagle.loadbalancer.PeakEwma#PeakEwmaNode does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.PeakEwma#PeakEwmaNode.pending")
[error]  * method pending()Int in class com.twitter.finagle.loadbalancer.aperture.ApertureLeastLoaded#Node does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.aperture.ApertureLeastLoaded#Node.pending")
[error]  * method pending()Int in class com.twitter.finagle.loadbalancer.aperture.AperturePeakEwma#Node does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.aperture.AperturePeakEwma#Node.pending")
[error]  * static method pick(com.twitter.finagle.loadbalancer.aperture.ProbabilityDistribution,com.twitter.logging.Logger)com.twitter.finagle.loadbalancer.NodeT in class com.twitter.finagle.loadbalancer.aperture.WeightedP2CPick does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.aperture.WeightedP2CPick.pick")
[error]  * method pick(com.twitter.finagle.loadbalancer.aperture.ProbabilityDistribution,com.twitter.logging.Logger)com.twitter.finagle.loadbalancer.NodeT in object com.twitter.finagle.loadbalancer.aperture.WeightedP2CPick does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.aperture.WeightedP2CPick.pick")
[error]  * method pending()Int in class com.twitter.finagle.loadbalancer.p2c.P2CLeastLoaded#Node does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.p2c.P2CLeastLoaded#Node.pending")
[error]  * method pending()Int in class com.twitter.finagle.loadbalancer.p2c.P2CPeakEwma#Node does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.p2c.P2CPeakEwma#Node.pending")
[error]  * method pending()Int in class com.twitter.finagle.loadbalancer.roundrobin.RoundRobinBalancer#Node does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.loadbalancer.roundrobin.RoundRobinBalancer#Node.pending")
[error]  * static method apply(Int,Int,com.twitter.finagle.stats.StatsReceiver)java.util.concurrent.ExecutorService in class com.twitter.finagle.offload.OffloadThreadPool does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.offload.OffloadThreadPool.apply")
[error]  * method apply(Int,Int,com.twitter.finagle.stats.StatsReceiver)java.util.concurrent.ExecutorService in object com.twitter.finagle.offload.OffloadThreadPool does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.offload.OffloadThreadPool.apply")
[error]  * class com.twitter.finagle.offload.OffloadThreadPool#RunsOnNettyThread does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.offload.OffloadThreadPool$RunsOnNettyThread")
[error]  * class com.twitter.finagle.offload.queueSize does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.offload.queueSize")
[error]  * object com.twitter.finagle.offload.queueSize does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("com.twitter.finagle.offload.queueSize$")
[error]  * static method module()com.twitter.finagle.Stackable in class com.twitter.finagle.service.DeadlineFilter does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.service.DeadlineFilter.module")
[error]  * method this(com.twitter.util.Duration,Double,com.twitter.finagle.stats.StatsReceiver,scala.Function0,scala.Option,Boolean)Unit in class com.twitter.finagle.service.DeadlineFilter does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.service.DeadlineFilter.this")
[error]  * method module()com.twitter.finagle.Stackable in object com.twitter.finagle.service.DeadlineFilter does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.service.DeadlineFilter.module")
[error]  * abstract method getLocalIdentity()scala.Option in class com.twitter.finagle.ssl.session.SslSessionInfo is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("com.twitter.finagle.ssl.session.SslSessionInfo.getLocalIdentity")
[error]  * abstract method getPeerIdentity()scala.Option in class com.twitter.finagle.ssl.session.SslSessionInfo is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("com.twitter.finagle.ssl.session.SslSessionInfo.getPeerIdentity")
[error]  * method this(com.twitter.finagle.tracing.Tracer,Boolean)Unit in class com.twitter.finagle.tracing.TraceInitializerFilter does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.twitter.finagle.tracing.TraceInitializerFilter.this")
[error]  * abstract method getSampleRate()Float in interface com.twitter.finagle.tracing.Tracer is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("com.twitter.finagle.tracing.Tracer.getSampleRate")
[error] stack trace is suppressed; run last finagle-core / mimaReportBinaryIssues for the full output
[error] (finagle-core / mimaReportBinaryIssues) Failed binary compatibility check against com.twitter:finagle-core_2.13:22.7.0! Found 28 potential problems
[error] Total time: 2 s, completed 02 Mar 2023, 09:04:18

@bpholt Im a bit confused on why we run a MiMa on Finagle itself though? Just an extra manual check when bumping versions?

I'm kind of surprised there were no breaking changes in this release. Can we double-check that the MiMa "extra projects" are being checked correctly? If so, this lgtm.

My bad, either I forgot when I set it up, or for some reason decided that it would be invoked manually during upgrade PRs like this (presumably because it would be too annoying to add filters). In any case we can change this if you want.

Im a bit confused on why we run a MiMa on Finagle itself though? Just an extra manual check when bumping versions?

Our team has run into a lot of bincompat issues with Finagle/Twitter Utils over the years, so it's helpful information to have when deciding when to pull in updates. (If there are bincompat issues then you need to update everything using Finagle, including support libraries like this one, etc)
Since it looks like this does pull in binary-breaking changes, we need to make sure the artifact is published with the right version scheme metadata so that e.g. Scala Steward sees this as a major version bump.

@bpholt Two things then :)

Should I add the MiMa check to the root project so that it runs on every PR?
Not sure how to set the metadata for the release. Do you have any pointer on how to do this or how it was done in the past?

I'd lean towards adding it to the build. If it turns out to be too annoying, we can adjust it later.
I think we need ThisBuild / versionScheme := Some("pvp"). (I suggested adding this upstream but I haven't gotten a response: https://github.com/twitter/util/pull/311.)

https://github.com/typelevel/catbird/blob/78cd0eccf3e8ffb4a55cf8b27a799bd9c24f694d/build.sbt#L31-L32

Looks good! Once this is merged, we'll release v22.12.0, right?

@bpholt Normally yes: ThisBuild / tlBaseVersion := BaseVersion(finagleVersion)


Bug: App crashes when opening a lot of tabs

Steps to reproduce

Open many tabs very quickly by holding CTRL + T.

Requirements
Fix crash when opening many tabs
debug_fulltrust.txt
debug.txt

This issue appears to be resolved in main.

Reopening to track potential regressions here after #4209

@duke7553 Everything looks good with your latest changes.

Is this still an issue in <IP_ADDRESS> or above?

Yes

The crash seems to only happen when using the keyboard accelerator. Tried to open 40 tabs at the same time using another path of call. Reducing the accelerator to "one press = one use" should do the trick.

Seems like a reasonable solution, I think we do something similar with the back/forward buttons.

Are you talking about those accelerators?

It might have actually been the refresh button but similar idea.

@gave92 the work done in #10648 doesn't seem to fix that issue for me. Is there some work left to do on the basis of it?

Could be, as I could never reproduce the issue in the first place.
But I expected #10648 to have the same effect as #10385 (wait until a tab has been opened before adding the next tab). Does #10385 fix the issue if applied on current main?

#10385 does not seem to solve the crash entirely anymore. If anything, it makes the issue a lot less worse.
Instead of crashing after 1 tab on main when holding the shortcut, it crashes after ~70 tabs for me. Better, but still not a fix.
I'm closing #10385 to investigate a better solution.

@QuaintMako I opened an issue to track your idea for solving this #11737.


repair _pad for newest pytorch version

Signed-off-by: ChengZi<EMAIL_ADDRESS>

/lgtm
/approve

Codecov Report

Merging #1487 (0f6b8f1) into main (aae30e9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1487   +/-   ##
=======================================
  Coverage   68.46%   68.46%
=======================================
  Files         316      316
  Lines       18187    18187
  Branches     2980     2980
=======================================
  Hits        12452    12452
  Misses       4896     4896
  Partials      839      839

Impacted Files
Coverage Δ

towhee/models/clip/auxilary.py
35.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae30e9...0f6b8f1. Read the comment docs.


Modified carousel to display proper tiles

Related Issue
Modified the carousel on the home page to show the correct number of tiles.
Fixes:  #1491
Description
Earlier uneven number of carousel was shown , but now within each slider only 3 carousel tiles are shown.

Type of PR

[x] Bug fix

Screenshots / videos (if applicable)
Before Change

After Change

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please merge my PR

@shreya2k3 Please see the conflicts .

@PriyaGhosal I have Resolved the conflicts

@shreya2k3 There are still some conflicts .Please resolve them


logstalgia: 1.0.7 -> 1.1.1

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin/logstalgia -h got 0 exit code
ran /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin/logstalgia --help got 0 exit code
ran /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin/logstalgia -h and found version 1.1.1
ran /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin/logstalgia --help and found version 1.1.1
found 1.1.1 with grep in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1
found 1.1.1 in filename of file in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1

cc "@pSub"

Success on x86_64-linux (full log)
Partial log (click to expand)
make[1]: Leaving directory '/tmp/nix-build-logstalgia-1.1.1.drv-0/logstalgia-1.1.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1
shrinking /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin/logstalgia
gzipping man pages under /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1/bin
patching script interpreter paths in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1
checking for references to /tmp/nix-build-logstalgia-1.1.1.drv-0 in /nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1...
/nix/store/qj5igicvkqbsmy0zs5qxzkj91dx01cl1-logstalgia-1.1.1

Success on aarch64-linux (full log)
Partial log (click to expand)
make[1]: Leaving directory '/build/logstalgia-1.1.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1
shrinking /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1/bin/logstalgia
gzipping man pages under /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1/bin
patching script interpreter paths in /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1
checking for references to /build in /nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1...
/nix/store/lnqhw37xv77vpfj4cw2zx590rr5pb6wk-logstalgia-1.1.1


(PUP-5938) Fix localized_domain test mocks

A new method localized_domains was introduced in 05d1ca2 to
Puppet::Util::Windows::ADSI::Shared to handle properly generating
URIs when the names BUILTIN and NT AUTHORITY are localized on
non-English versions of Windows.
At that time, the calls should have been mocked in:

provider/group/windows_adsi_spec.rb
provider/user/windows_adsi_spec.rb

The calls actually touch the system, and depending on test
ordering and how calls to name_to_sid_object are mocked, the code
execution path could produce failures.
Fix this oversight by simply mocking the return values for
localized_domains as they are not needed for these tests.

Paired-with: Daniel Lu<EMAIL_ADDRESS>

@glennsarti this should be good to merge once the tests pass

CLA signed by all contributors.

Closed in favor of #5171 which targets stable instead of master


Always set timestamp on kill, provide spent time in str()

Pull Request Test Coverage Report for Build 410

11 of 12 (91.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 99.149%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

exec_helpers/exec_result.py
7
8
87.5%

Totals

Change from base Build 409:
-0.07%

Covered Lines:
1281

Relevant Lines:
1292

💛  - Coveralls

Pull Request Test Coverage Report for Build 410

11 of 12 (91.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 99.149%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

exec_helpers/exec_result.py
7
8
87.5%

Totals

Change from base Build 409:
-0.07%

Covered Lines:
1281

Relevant Lines:
1292

💛  - Coveralls


ADR Template should be expanded

As written, the current ADRs serve chiefly as useful documentation for the existing configuration. This is useful, but to non-DevOps eyes their status is almost more of a changelog than a set of decision records: it is easy to get a sense of state, but not its rationale.
The problem IMHO is that the template is too simple. Looking at other widely-used templates indicates a considerably fuller list of headings than that currently adopted for our ADRs.
While it is obviously possible to go overkill on headings, I suggest at a minimum that Assumptions, Constraints, and Positions as defined in the linked template should be added to the rsd-azure-waf ADR template. If these headings cannot readily be usefully filled in, it could be that the decision adopted does not merit a full ADR.
It's probably not worth backfilling these sections into the current ADRs. But in future we should probably use an expanded template.

Thanks for the suggestion @thill-dxw. I will add this to our backlog!


⚠ CIOOS Pacific Dev CKAN has degraded performance

In bf7f858, CIOOS Pacific Dev CKAN (https://catalogue.pac-dev1.cioos.org/) experienced degraded performance:

HTTP code: 200
Response time: 7640 ms

Resolved: CIOOS Pacific Dev CKAN performance has improved in 20736d2.


Title for choiceset is not wrapped

Platform
Bot Framework

Web chat
What platform is your issue or question related to? (Delete other platforms).

.NET HTML
.NET WPF
Android
iOS
JavaScript
UWP

Author or host
Are you an author (like sending something to Outlook), or a host that is rendering your own cards?
If you're an author, who are you sending cards to?
Version of SDK
What version are you using? Ex: NuGet 1.0.2, or latest master, etc...
Issue
Explain your issue. If you just have a question, please post on StackOverflow instead.

@dclaux are you able to look into this? If we make changes here should we also consider using <label for="X" /> to improve the user experience and allow the user to tap on the text itself as opposed to just the radio and checkbox?

I can look into this, and agreed about the label.

@matthidinger Not sure we've ever addressed this, but should those long strings wrap in Input.Toggle and Input.ChoiceSet, or just be truncated?

Hmm yeah I don't recall explicitly addressing that. My gut feeling is we should reserve the right to interpret this on each renderer as the experience dictates, so maybe just truncate in most of them, but update our docs with guidance that the choice title should be <30 characters for optimal presentation?

My requirement is to make it wrapped. Could you please fix for wrapping?

If I do it here it needs to be done in all other renderers, so it needs to a concerted decision. We will discuss and come up with a plan.

Fix for properly truncating is here: https://github.com/Microsoft/AdaptiveCards/pull/1801

Thanks kmkaliraj and David! We can use this thread to track the HTML issue where the text doesn't get clipped correctly.
I've opened a new issue #1821 on the topic of whether we should wrap (which would have to be applied to all renderers)

Closing since the issue has been merged.


JUnit report XML output?

Some of the larger CI systems such as GitLab and Jenkins support the JUnit report XML format.
Is there an easy way to generate that or convert it from the standard XML output like is done for Cobertura?
For more on the format, see also: https://stackoverflow.com/a/4925847
This feature would nicely supplement already supported CI systems such as Travis/GitHub, Circle CI etc.

So that format doesn't seem to store any coverage information at all? You possibly want to look towards another tool to do this. A quick search on crates.io turned up this https://github.com/CWood1/cargo-junit

Well, indeed. I think I got misled by the GitLab CI docs. It does support Cobertura and just matching a plain regex against the cargo-tarpaulin output, so I'll go with that. Thanks.


Removing form-horizontal so labels don't overlay inputs

Fixes #250

Once merged, will need a catalog release cut and https://github.com/openshift/origin-web-console/pull/1593 so the bug is resolved in console.


Setup Otel exporter for FerretDB

What should be done?
We have some code that setups Otel exporter for integration tests and in envtool. We should refactor it and use it for setting Otel exporter in the FerretDB process itself. It should be configurable with --test-XXX flags.
We should not "fix" traces in this issue.
Where?
TBD
Definition of Done
TBD

handler updated;
all backends updated;
unit tests added/updated;
integration/compatibility tests added/updated;
spot refactorings done;
user documentation updated or an issue to create documentation created;
something else?

Something to take a look at: https://github.com/FerretDB/FerretDB/actions/runs/9755345749/job/26923979624?pr=4380

We should fix "traces export: string field contains invalid UTF-8" error


NUnit 3 Support

Hey,
We've recently upgraded our test framework to NUnit v3.2 and needed to make some changes to support the breaking changes in the framework.
I've opened a PR on our fork (https://github.com/LiberisLabs/coypu/pull/1/files) but would be happy to open a PR to your repo if you were interested in merging the changes? If there's anything you think should be changed too I'm happy to receive comments.
We have added the Ignore attribute to some tests that we couldn't get to run (8 of them) and have followed the previous convention of moving the NUnit v2.6.3 integration to its own project. We have also upgraded the NUnit version in tests where possible but some are restricted due to the target framework of the projects.
Thanks
Lee

Sure think, make a PR. What you've done looks like the right approach to me. Might take me a little while to review it, but thanks!

done

Any ideas when the Nuget package will be updated to contain the new Nunit3 support?


WebStyle: improved HTTP error code

Improves reporting of HTTP error codes in ways that can help
crawlers correctly analyzing the available pages.

Signed-off-by: Samuele Kaplun<EMAIL_ADDRESS>

Is it really enhancement or just bugfix? Does it worth it backporting it for maint-1.2?

Eh. It's a bugfix but an important one from a service POW: without it Google would happily index all deleted records and cluttering the index with "this record has been deleted" or similar.

@kaplun I have changed the labels. Can you then re-submit the patch for maint-1.2 (or at least rebase on top of it)?

I have rebased against maint-1.2

@kaplun can you also add BETTER in commit message so it is easier to generate release notes? Thanks

Sure! Done.

@kaplun the regression tests are failing :(

Weird! They were not failing before rebasing, but they failures seem to make sense (I mean like the tests should simply need to be amended).
Mmh, given that, maybe it's simply better to restore the original branch against legacy and no longer try to have them against maint-1.2.

@kaplun or try to submit new PR for maint-1.2 directly.

This patch against maint-1.2 is what is not passing the tests, and I don't have resources to fix them. I restored this PR against legacy as it was originally intended. Let's see if regression tests now pass (as before). Otherwise we shall blame it on yesterday Travis's blackout.

I confirm the tests are still failing when run locally. Postponing for v1.2.3 then. If you'll find time to fix the tests, then this will come into the next-next bug fix release. If you don't find time to fix the tests, and if the tests for legacy branch are passing, then we should postpone for v1.3.0. (Please amend the milestone accordingly.)