Add auto convert option to set-state and Regex commands

... to control if state should be auto converted to numeric Type
Calls to State.set() will automatically attempt to convert the type of value to an Integer or Double.  If value can be converted, it will be stored as a numeric type in the State tree.
When we have a string that represents a time stamp, or another similarly large number, the timestamp will be stored as a double, e.g. for a pattern;
file: /tmp/(?<framework>.*)-(?<timestamp>\\d*)/index.html
and the input file: /tmp/quarkussimulation-20210307110018725/index.html
References to ${{timestamp}} in the script substitute the value 2.0210307110018724E16.  References to invoke js toString() on the state value result in rounding errors, e.g. ${{= ${{timestamp}}.toString() }} resolves to<PHONE_NUMBER>0018724
@willr3  In order to mitigate these rounding errors, I have added an autoConvert ro regex and set-state to force State.set() to store the value as a String in the state map.
There may be (will be) other areas that need to be configurable to store numeric values as Strings, but wanted to run this past you before going any further with changes

@johnaohara I agree, we should have a way to prevent qDup from automatically converting strings for cases like yours.

Does this approach look reasonable?

@willr3 please can you review? thanks

There are some tests failing, I will fix what is causing the failures

@willr3 , I spent some time looking through the differences between set-state: and with: to see if we can retain the same syntax for with:
At the moment it is possible to define a with: using this syntax;
 with:
   FOO: '{ "some": "object"}'

But it is not possible to express the following for set-state:, it will not parse;
  - set-state: RUN.FOO '{ "some": "object"}'

The is no "implicit" expression for with: as there is for set-state:, i.e. the key-value pairs for with: can only be expressed explicitly.
My PR broke tests that were setting a JSON state object in with: because I was assuming a specific structure of that JSON object.  This is also what set-state: does. i.e. when set-state: is parsed, the parser assumes specific JSON fields are defined.  If users want to use set-state: to store a JSON object, they need to express this as;
 - set-state:
     key: FOO
     value:  `{  "key": "foo",  "value": "bar"}`

The JSON object value needs to be explicitly defined in the value field of the Json object defined for set-state:.
In order to keep the same syntax between set-state: and with:,  we can keep my PR as it is, but this would mean the syntax for with: would change to ;
with:
  FOO:
    value: "0024"
    autoConvert: false

and if users want to set the value to a JSON object, they would need to write this explcitly as;
with:
  FOO:
     value: '{ "some": "object"}'

This would be a breaking change and the failing tests would need updating to the new syntax.

The other option is what I proposed earlier, which is to encode autoConvert in the key, e.g.
with:
  ?  key: RUN.FOO
      autoConvert: false
  : "0001"

But this will have different semantics to set-state:.
Having thought about it, I think that the most syntax below would be more consistent, and is probably better, although this could break some scripts.
with:
  FOO:                                      #This would NOT autoconvert the FOO value
    value: "0024"
    autoConvert: false
  BAR:                                      #This would now be mandatory for setting json objects in state
    value: '{ "some": "object"}'
  BIZ:  "0024"                           #This would autoconvert the BIZ value

Or another option could be to search for particular fields in the with: JSON object, i.e. value: and autoConvert:  and if they are present, apply the autoConvert option to value:, otherwise just store the JSON object as-is in the cmd.withDef

- set-state: RUN.FOO '{ "some": "object"}' Should work so that is probably a bug in how Parser creates a SetState from the input string, I will take a look at that part.
Thinking more about autoConvert:
- set-state: count 10
- set-state:
    key: foo
    value: "001"
   autoConvert: false
 - script: doSomething
   with:
     input: ${{foo}} #does this need to preserve autoConvert?

I think we do not need to add autoConvert to with but we need to change how with converts. We need autoConvert when capturing data from the ssh buffer because everything from the remote ssh connection is string encoded but if we capture a number or some json we want to be able to interact with it correctly. The set-state and regex commands are the only way to capture data from the ssh buffer so I think those are the only places we need to convert.
There is a convert in with because Cmd.populateStateVariables returns a string which means ${{count}} would become a string instead of the integer. I think we can remove the autoConvert from with and instead just convert when we detect the value is populed from a pattern, otherwise we trust the yaml parser to correctly assign the type?


Table checkboxes support

Somebody knows if this is posible. How can I do this?

Closing this due to inactivity. please feel free to re-open if issue still persist.


Updated service name

Changed in more recent versions

@billmath

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


H6125 Support

Please explain your feature request in a one or two sentences.

Hello, I've just tried to add a device but it seems Govee H6125 is not currently supported. Would it be possible to add please?
Thanks.
device: 'redacted',
deviceName: 'RBIC Light strip',
model: 'H6125',
httpInfo: {
device: 'redacted',
sku: 'H6125',
spec: '',
versionHard: '1.00.04',
versionSoft: '1.07.01',
deviceName: 'RBIC Light strip',
deviceExt: {
deviceSettings: '{"address":"redacted","bleName":"ihoment_H6125_FAF3","pactType":1,"pactCode":1,"ic":50,"sku":"H6125","device":"BD:redacted","deviceName":"RBIC Light strip","versionHard":"1.00.04","versionSoft":"1.07.01"}',
lastDeviceData: '{"online":false}',
extResources: '{"skuUrl":"","headOnImg":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/7497e9e37fb1d7461581173195ffcf3e-new_light_title_home_on.png","headOffImg":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/871d58cc47b99af39dead92abd2acd01-new_light_title_home_off.png","ext":"","ic":50}'
},
pactType: 1,
pactCode: 1,
goodsType: 0
},
isAPIDevice: false
}

Hi @nealbuff
As this is a bluetooth only device, are you running homebridge on a platform that has a bluetooth capabilities? like a raspberry pi?

I'm running Homebridge on a raspberry pi

ok, should be okay.
can you update to beta version 4.0.3-beta.0, you'll also need an entry for this light into the config (if you haven't already) and enable bluetooth control.
The light should then be added to homebridge. try controlling it, if it doesn't work, turn on debug logging to see if that helps identify any problems.
You may need to install some extra packages on your pi, see
https://github.com/bwp91/homebridge-govee/wiki/Bluetooth-Control#homebridge-rpi-image


Add Settings

This PR will add a hideable settings wheel where you can choose your theme.
Will close #27
I added new settings strings that need to be translated. It should be really easy now to add language settings now.
I also didn't implement the local storage save yet.

Last commits are especially useful because this library will be used in other websites and users should not bother about including the CSS file

This PR will add a hideable settings wheel where you can choose your theme.
Will close #27
I added new settings strings that need to be translated. It should be really easy now to add language settings now.
I also didn't implement the local storage save yet.

Very good! Worked perfectly. It will be easy to add new features. :grin:


Using HTTP-Server together with Nexe and Browser-Sync

Hello there!
Being very new to node, I wonder if I could use HTTP-Server programatically as node app (node server.js) with manual require and createServer()
Unfortunately, that doesn't work, is there a way to start the server as node app?
https://github.com/jaredallard/nexe Nexe works together with apps that run as node apps.
Additionally, I want to use Browser-Sync with http-server if that is possible. For that I need to run the server as node app too. (see https://github.com/Browsersync/recipes/tree/master/recipes/server )
Thank you in advance.

Not sure if I understood, but http-server is built in on top of ecstatic, which supports scripted usage.

Thank you a lot @derhuerst.
So, if I understand that right, http-server is just an executable, that is not meant for node app usage? so there is no package that I can require and run?
Again: thank you a lot for clearing that up.

The package.json specifies which file will be required if you require http-server.
The executables are defined in the package.json as well.

For usage in Node.js you could use ecstatic, express, hapi or the builtin http module.

Thanks a lot @derhuerst  This is a great starting point :)


Add Warning for poly(A) libraries

Description of feature
Hi there,
Many RNAseq accessions do not make explicit whether the RNA prep was total or polyA. I think TrimGalore and cutadapt require  -a "A{10}" to trim poly-A tails. My concern is the implications on expression and splicing analyses of not removing polyA tails in oligo(dt) selected libraries?
Like RSeQC infer_experiment.py is used to generate a warning for strandedness fail, I wondered if a similar warning could be created with Qualimap:Genomic Origin or RSeqQC read distribution when intronic reads are < 10% indicative of polyA selection? And suggest to re-run the pipeline with  -a "A{10}" ?
Many thanks,
Oliver

Hi @ojziff would there be any harm in always trimming poly(A) tails? Just added fastp support in https://github.com/nf-core/rnaseq/pull/970 where you can use --trimmer fastp --extra_fastp_args '--trim_poly_x' which should trim the polyA tails by default along with any adapter sequences.

Thanks @drpatelh. I can't envisage any harm from trimming polyA tails together with the adapter as default.

Sweet! Will close this then!


Allow windows to opened in reverse

It would be nice if there was an option to reverse the tree. For example when opening a new window it would appear on the left instead of right. Or if the screen is more tall than it is narrow to open the new window above instead of bellow.

Implemented on master.
New config window_placement, e.g:
# spawns to the left if vertical split, or top if horizontal split
yabai -m config window_placement first_child

# spawns to the right if vertical split, or bottom if horizontal split
yabai -m config window_placement second_child

Works great!


[docs] Improve styles basics.md section

[X] I have followed (at least) the PR section of the contributing guide.

^ Kind of? This just PR just addresses a small typo.

Sorry, I don't see the typo. The meaning we intend to communicate is that we first started with LESS, then we have used inline-style.

@bxie Thanks, happy to have clear doubt :)


Release versioning

From the discussion in the Python channel, we are recommended two ways of managing pre-release versions:

Publish pre-releases to the same name in pypi.
Publish to a weekly package and dynamically change the pyproject name before build

(1) seems reasonable to me because we can always yank a package in pypi.
@abock @liqunfu @gramalingam

Thread in https://teams.microsoft.com/l/message/19:b1620cabfa8049329cee7ba42b06abe6@thread.skype/1680036271980?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=68ae9c56-b648-45f2-b7d3-c65feb9b3d20&parentMessageId=1680036271980&teamName=Python&channelName=General&createdTime=1680036271980

Post by Brett from the thread:

The one concern we had was if we did something wrong in our GitHub action it will mess up the official package.

The way we do it is use the .dev suffix in the git repo and then strip it only when we publish the stable version. See https://peps.python.org/pep-0440/#developmental-releases for details on the suffix (and Python version number support in general, which is quite flexible).

The other way is to verify the version before you let the publication occur if you're that concerned about accidentally pushing a stable release (i.e. have an approval step before anything hits PyPI itself). Both AzDO and GHA support requiring manual approval before something occurs.

I also wonder if it will make version discovery harder for users browsing pypi?

No. See https://pypi.org/project/Django/ where you don't see the 4.2rc1 release unless you look at https://pypi.org/project/Django/#history .  PyPI and Python packaging in general has been around long enough to have solved this exact problem. 😁

For versioning we can use setuptools_scm and provide a custom version scheme https://github.com/pypa/setuptools_scm#customizing-version-scheme-with-pyprojecttoml
So we can eliminate setup.py entirely.

Done


8 fetch preprocess sic

Closes #8

All addressed now. Re: instructions I now refer the user to the industrial_taxonomy/pipeline/README.md if they want to reproduce the pipeline.

All addressed now. Re: instructions I now refer the user to the industrial_taxonomy/pipeline/README.md if they want to reproduce the pipeline.

:+1: Once #1 has approval we can merge that and then merge this PR into dev


Corrected "search_subfolder" instructions

The option to search for csvs within Subfolders seems to have changed from "search_subfolders" to "search_subdirectories". I have updated the documentation to match.

Thank you!


My old computers and my experience of daily driving Linux and self-hosting | Ulysses’ trip

https://ulysseszh.github.io/misc/2023/09/17/year-using-linux.html
I have been using Linux and self-hosting for over a year now. Overall, I would like to say that it is rather satisfactory and that I will continue to use Linux as my daily driver in future. Thinking of that, I felt a little bit nostalgic about my old computers. So I decided to write an article about my old computers and my experience of daily driving Linux now.

Regarding the vsync issue, it appears that you are using Xorg? I also had this problem on my 165Hz monitor, but everything worked fine after I switched to Wayland, you might want to give it a try as well. Although some apps don't support Wayland well yet.
As for fractional scaling, you can check out HiDPI.
Btw, R7000 seems to be the Chinese version of Legion 5. You can find more specific information about it at Laptop/Lenovo#Legion_series.

@Misaka13514
Regarding the vsync issue, it appears that you are using Xorg? I also had this problem on my 165Hz monitor, but everything worked fine after I switched to Wayland, you might want to give it a try as well. Although some apps don't support Wayland well yet.
As for fractional scaling, you can check out HiDPI.
Btw, R7000 seems to be the Chinese version of Legion 5. You can find more specific information about it at Laptop/Lenovo#Legion_series.

Yes, the vsync issue is a bug of Xorg.
I tried Wayland immediately after I installed Linux, but too many apps do not support it.
Thank you for show me that ArchWiki page.
It is useful.


should parenthesized expressions be allowed as l-values in polymer_expressions?

From Tomasz:
<select  value="{{(document.currencyId) | asInteger}}">  <= works only in Dartium
<select  value="{{document.currencyId | asInteger}}"> <= works in Dartium and dart2js
This happens because in our codegen transformation we disallow parenthesized expressions as l-values. However the polymer_expression evaluator allows it.
We should be consistent, but I'm not sure what's the right call here. I'm currently inclined to make the assignment to "(x.y)" invalid in eval.dart.
Thoughts?

This issue has been moved to dart-lang/polymer-dart#492.


Better example for version alignment done in consumer other than Jackson

Since Jackson now publishes proper GMM with version alignment information, it is a bad example for the docs.
It is more confusing why you should use manual version alignment while it simply works with Jackson.
This confused me a few days ago and also another community member I've seen in the last days being confused by this.
Imho a better example should be chosen that does not have the version alignment in the GMM already.

Sorry for the late reply.
This is a valid documentation issue.
We welcome documentation contributions. See our contributing documentation guide for more information.

@reinsch82  Kafka is still not providing BOM, so I think it can be a nice example of version alignment.
If it sounds interesting, I'll be glad to help here with re-writing the example.


git subcommand doesn't allow for interactive actions on stores

For some reason I'm unable to do anything meaningful with the git subcommand, I'm only getting the command output from gopass, but not from the command itself I have run. For example, I would expect gopass git --store some-store log -p to give me a itemized list of commits on the relevant store along with the changes, but instead the output is just:
$ gopass git --store some-store log -p
[some-store] Running 'git log -p'
$

It would be good to be able to make use of the built-in git functionality in other ways than just push or pull, and to receive output feedback from the command itself.

Thank you for reporting this issue. I was also curious about the missing output but didn't raise an issue so far. The output redirection seems to be wrong. Will investigate.


Fix datastore data type for instance var

Also reverts part of #458 which causes tasks to disappear (by default) after they are started.

FYI @berggren


Settings

Auto-reload image mode.
Remember last window state (maximised/normal).

I agree with adding those settings. Another one I would like added is the ability to choose to assign it to image files (with the ability to associate all or specific image extensions).

With 509cca7 you can toggle the status bar with Ctrl+B.

Do you still plan to implement window position saving? This setting is greatly missed.


Convert.py Error

I get below error during the conversion of log using the script convert.py
Traceback (most recent call last):
File "C:\Temp\FW Logs\convert.py", line 20, in
for line in log_data:
File "C:\Users\akamburvenk2\AppData\Local\Programs\Python\Python38-32\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 191: character maps to

What version firmware are you on?

Its 5.6.3

Just committed a change to read files in UTF-8 which should resolve this


Why the result is better than that in the papers? #87

Hi,
I run the code on the conll2003 dataset, however, the result of the code is better than that reported in the paper. I am curious about where to get the basic version code of the paper, and how to improve the result?
Thank you

Probably because paper is using Senna embeddings while this repository is using GloVe embeddings


Bumps github.com/aws/aws-sdk-go-v2/config from 1.26.5 to 1.26.6

Bumps the test group in /modules/persistence/test with 1 update: github.com/aws/aws-sdk-go-v2/config.
Updates github.com/aws/aws-sdk-go-v2/config from 1.26.5 to 1.26.6

Release notes
Commits

updated-dependencies:

dependency-name: github.com/aws/aws-sdk-go-v2/config
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: test
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>
Bumps the test group in /modules/dns-record/test with 1 update: github.com/aws/aws-sdk-go-v2/config.
Updates github.com/aws/aws-sdk-go-v2/config from 1.26.5 to 1.26.6

Release notes
Commits

updated-dependencies:

dependency-name: github.com/aws/aws-sdk-go-v2/config
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: test
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>
Bumps the test group in /modules/notice-discord/test with 1 update: github.com/aws/aws-sdk-go-v2/config.
Updates github.com/aws/aws-sdk-go-v2/config from 1.26.5 to 1.26.6

Release notes
Commits

updated-dependencies:

dependency-name: github.com/aws/aws-sdk-go-v2/config
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: test
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

@dependabot rebase


Spring Boot Database: MSSQL

Need to do this, first: https://github.com/jhipster/jhipster-lite/issues/419
The stats with MSSQL is not low, so I think the support is easy and can be added

Hi Pascal,
May I take care of this ticket ?

@seraphinandrieux : I need this for my current customer, but my team didn't have time to start it, so you're really really welcome!

Increasing the bounty as it was more work than expected, specially for integration tests


[QUERY]

Query/Question
How can we help?
Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.2.0]
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
IDE and version : [e.g. Visual Studio 16.3]

Hi @jhw7227.  Thank you for reaching out.  Unfortunately, this issue is blank and, therefore, we're not able to understand how we can assist.   I'm going to close this out, but please feel free to reopen with context and details or open a new issue if you still require assistance.


Is it possible to deploy tkinter with tensorflow with Pyinstaller or Cx freeze?

I've been trying to develop a Tkinter application with TensorFlow for two weeks now, But I'm having issues converting the application from .py to .exe file with both pyinstaller cx_freeze.
I always get errors. Is it possible to develop a model built with keras without going through TensorFlow? If I move the TensorFlow library, can I then achieve what I am trying?

Can you please provide description of your error?

Here is the error I get

Can you please provide a description of your error?

What I don't understand is that it searches for tensorflow in sites-application while I deposit it in the application folder

Can you please provide a description of your error?

What I don't understand is that it searches for tensorflow in sites-application while I deposit it in the application folder

Have you used os.path.join in your codebase instead of a file path?

Can you please provide a description of your error?
What I don't understand is that it searches for tensorflow in sites-application while I deposit it in the application folder
Have you used os.path.join in your codebase instead of a file path?

Yes, my code :
from os import path
import sys
if getattr(sys, 'frozen', False):
MODEL_DIRECTORY = path.join(path.dirname(sys.executable), 'model')
else:
MODEL_DIRECTORY = path.dirname(file)
mymodel = path.join(MODEL_DIRECTORY, 'mymodel.h5')

Can you please provide a description of your error?
What I don't understand is that it searches for tensorflow in sites-application while I deposit it in the application folder
Have you used os.path.join in your codebase instead of a file path?

The problem may be in my setup? Because even without the code I sent, I still have the same problem. The problem can be found in this code?
PYTHON_DIR = os.path.dirname (os.path.dirname (os .__ file__))
os.environ ['TCL_LIBRARY'] = os.path.join (PYTHON_DIR, 'tcl', 'tcl8.6')
os.environ ['TK_LIBRARY'] = os.path.join (PYTHON_DIR, 'tcl', 'tk8.6')
include_files + = [
    (os.path.join (PYTHON_DIR, 'DLLs', 'tcl86t.dll'), ''),
    (os.path.join (PYTHON_DIR, 'DLLs', 'tk86t.dll'), '')
]

Can you please provide a description of your error?

What I don't understand is that it searches for tensorflow in sites-application while I deposit it in the application folder

Yes, if you make an installer of any application it searches in sites-application. You can try Hidden-import parameter to explicitly link tensorflow to your build.

Yes, if you make an installer of any application it searches in sites-application. You can try Hidden-import parameter to explicitly link tensorflow to your build.

How can I do this?
In my setup, I import tensorflow.
options={
    'build_exe': {
        'packages': ['google', 'scipy', 'tensorflow'],

Can you share your approach using Pyinstaller? I have a better understanding of making the installer in it.

Can you share your error when you tried using Pyinstaller? I have a better understanding of making the installer in it.

@Lucysmith8,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here and the TensorFlow version you are using.
Also, please take a look at this similar issue and let us know if it works. Thanks!

@Lucysmith8,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here and the TensorFlow version you are using.
Also, please take a look at this similar issue and let us know if it works. Thanks!

@amahendrakar I changed the question to add world code.

Can you share your error when you tried using Pyinstaller? I have a better understanding of making the installer in it.

@ratansingh98 I changed the question to add world code.

@Lucysmith8,
Please take a look at this comment from a similar issue and this issue thread, which seem to work.
Also, looks like this issue is a duplicate of #40458. If it is could you please close one of them. Thanks!

Can you share your error when you tried using Pyinstaller? I have a better understanding of making the installer in it.

@ratansingh98 I changed the question to add world code.

Thank you @Lucysmith8 , i will look into it.

He found the solution. But instead of sharing, he closed his question and he didn't answer anyone. https://github.com/anthony-tuininga/cx_Freeze/issues/514

Can you share your error when you tried using Pyinstaller? I have a better understanding of making the installer in it.

@ratansingh98 I changed the question to add world code.

y
In the case of Pyinstaller, use TensorFlow 1.14 and add 'pkg_resources.py2_warn' as a hidden import.


Default to OpenSSL hash function implementations

Use OpenSSL implementations of SHA256, SHA512 and RIPEMD160 by default and add a simple (manual) benchmark unit test.

Suggested: Use OpenSSL for digests

Merged as 0e7c8ce5548705342c62941511f7877f9ca08a46


JobRepository plugin mechanism

Hi everybody !
https://github.com/quarkiverse/quarkus-jberet/issues/172
This is what I had in mind.
On top of this, if this is ok for you, I can build an optional extension to plugin in the JpaJobRepository
Is this ok ?

@radcortez what do you think ?

Thank you for the PR. Highly appreciated it :)
Left a couple of comments for you to consider.

@radcortez what do you think ?

Thank you for the PR. Highly appreciated it :)
Left a couple of comments for you to consider.

Hi again !
Thank you for your comments.
Please let me know how to proceed.
Thank in advance.

@radcortez I followed all of your advices.
It should be smooth as silk now !
Please let me know

@radcortez I also removed unnecessary factories.
What do you think ?

Yes, it looks good now. Thank you :)
We still need to decide how to handle the enum Type better. If we can have different Repository types coming from another extension (which I think is the original idea), we can probably drop it and replace it with String.
The external extension can do precisely what you are doing with the registration, and the core extension only needs to verify that we have one Repository producer available for the specified type. We can either fail the build or fall back to the in-memory. But I think we should fail the build in that case, because the user is expecting a repository of a particular type and we were not able to register it.
Does that make sense?

@radcortez I inserted a new enum value : OTHER
By doing so we can keep the enum.
The external extension will precisely do what we are already doing with registration, as you said, when the repository type is OTHER.
For example :
    @BuildStep
    public void additionalBeans(
            JBeretConfig config,
            BuildProducer<AdditionalBeanBuildItem> additionalBeans) {
        if (OTHER.equals(config.repository().type())) {
            additionalBeans.produce(AdditionalBeanBuildItem.unremovableOf(JBeretJpaJobRepositoryProducer.class));
        }
    }

the core extension only needs to verify that we have one Repository producer available for the specified type

I agree that the build should fail if repository type is OTHER and there is no repository producer available.
But, how can this be done ?
Maybe we can consume List in an additional BuildStep and check among them ?

@radcortez I think I managed to do it, the check and fail mechanism.
Can we consider this done and merge ?

Ok, let's wait for the CI.
Yes, please, on a separate PR.
Also, this approach is fine if you want to eliminate the enum. Each implementation can define its type string, like the jdbc driver, and then they provide a way to validate it.

Sorry, what do you mean by CI in this case ?
I am missing something 😄

Continuous Integration (which passed).
So we are good to go. We can still make the enum change if you are up for it.

@radcortez I'd say to keep the enum, I think it's fine just like this.
It feels the right choice, using the OTHER value I mean.

Please merge and I am going to make a pull request for the Jpa part, you'll see ...


Matchlowercase slightly off when used through unicode-math

Description
I issue \setmathfont and \setmathfontface\mathit with [Scale = MatchLowercase], but the resulting characters are slightly bigger with \mathit. It shows more with beamer.
Add info or delete as appropriate:

Relevant for XeTeX, Version 3.141592653-2.6-0.999995 (TeX Live 2023)
Relevant for LuaHBTeX, Version 1.17.0 (TeX Live 2023)

Minimal example demonstrating the issue
\documentclass[border=5pt]{standalone}

\RequirePackage{fontspec}
\setmainfont{Gentium}

\RequirePackage{unicode-math}
\setmathfont{texgyrepagella-math.otf}[Scale = MatchLowercase]

\AtBeginDocument{%
\setmathfontface\mathit{texgyrepagella-italic.otf}[Scale = MatchLowercase]}

\begin{document}
a$a$$\mathit{a}$
\end{document}

The a produced by \mathit is slightly taller than the other (and also a bit to tall w.r.t. the main font). As said above, this is very slight, but is distinctively more visible in a beamer presentation.

Further details
Log shows that fontspec is cycling through multiple scale calculations for texgyrepagella-math (with different values), and that another, different value is computed for texgyrepagella-italic.
document2.log

IIRC, this option does not measure the glyphs, it uses the xHeight set in the font, and fonts might allow for an overshot when setting xHeight for glyphs with a rounded top. You should try glyphs with flat top to rule-out that, and may be also check the xHeight of the involved fonts.

@khaledhosny is correct (as always -- thanks!). From the perspective of the font designer this behaviour is intended, as the x-height may be set to look optically correct even if geometrically there are small overshoots. (Or it could be a font bug.)


[AutoPR hdinsight/resource-manager] [HDInsight] Fake PR to test suppressions (please ignore)

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3587

(message created by the CI based on PR content)


Solo/mute button implementation part 1

Adds new custom PartsList and PartsListItem classes for the parts list, with buttons for solo/mute (we can extend this class in the future with other things, such as pan sliders, etc.)
TODO in the next PR:

Fix scaling for left panel so buttons aren't cut off in scroll pane
Remove track coloring changing due to solo/mute state
Make right-click solo override solo/mute button state
(Possibly) add ctrl-click functionality to solo/mute only the clicked track

Be aware that on MacOS it needs more space for the delete button to show.
That why I did that partsList.setPrototypeCellValue(new ProtoClass());
Then I could afterwards set the width from partsList.getFixedCellWidth() which would then reflect the size of the component with the prototypeclass inside (which again would have the longest instrument name, LM bassoon).
That way the component would per default be wide enough for delete button to show on both MacOS and Win, plus enough space to show instrument names.


datasets.make_regression as Dask dataframe and series

Added return_dataframes wrapper to repackage Xs and ys
Create make_regression_df using wrapper
Refactored make_classification_df to reuse wrapper

cc @dhavide

cc @TomAugspurger I promised this a while back. Do you think I should do anything fancy for the docstrings? This just specifies the new return values.


issue113: Fix TckCancelOnTests#cancelFromRemoteCall invalid behavior

fixes #113
Signed-off-by: xstefank<EMAIL_ADDRESS>

-1
This test looks over engineered/complex for the task in hand which I assume is:

client invokes a participant in a LRA context which invokes a second participant
cancel the LRA
check that both participants were asked to compensate

@mmusgrov what would you suggest then? I don't see other way how to enlist two participants

+1 from me
Tests adds two new classes - new participant that could be enlisted and a class to gather information about invocations. That's a minimum number of editions that we need to add this kind of test I think.

The changes I made in PR 115 for the LRAClient deprecation added a basic participant resource. I used that to implement what I think is the intent of the new test:
https://github.com/mmusgrov/microprofile-lra/commit/dee8d901eb529601910dd3cbed2cb420cb5e1d52
I think going forward this version is going to be the easier one to maintain.

I created a PR for the https://github.com/eclipse/microprofile-lra/pull/118 as discussed in the meeting. Changes which are part of this PR would be nice to be part of a new issue on testing TCK.

superseded by #118


State management

Do we need smth like MobX and how Is It better then Redux for example.
As I notice we still able to manage state with integrated into react features.
For example as I noticed there is a context to solve this. Mb we don't need additional dependencies and keep our app small-medium size and lightweight
some articles:
https://blog.openreplay.com/redux-alternatives-in-2021
https://blog.bitsrc.io/redux-react-alternatives-c1733793a339

At the moment we have already imported MobX into our project.


Update Readme

Changed some phrasing: typos, grammar, unclear sentences, less commas, added headings.
Changed full paths in the suggested example configuration to Windows environment path variables.

Thank you for this!


Support for experimental Linux build

Is there a chance, that we can get support for the experimental linux build? I just tried kissmp there (Had to rename the mod to all lowercase because of reasons), but the gui is not interactible.
I would be very happy if this could be added!
Thanks!

The main problem currently seems to be to be that the gui is not interactible, and that appears to be a problem of the experimental build in general


Wrong results returned from bulk operations

We're using mongodb 2.6.x and recently upgraded from mongojs 0.18.2 to 2.3.0.
If you run bulk operations, the results returned in 2.3.0 seems wrong and doesn't match what we saw in the previous version we were using.  For example, if you make two calls, the first of which results in an upsert, and the second which does only a modify, you get the same result, even though they should be different.  Here's the sample code with two calls to Bulk.updateOne():
var url = 'mongodb://localhost:27017/scratch';
var mongojs = require('mongojs');
var db = mongojs(url, null, { loggerLevel: 'debug' });
db.dropDatabase();
var coll = db.collection('dumpsters');
var bulk = coll.initializeUnorderedBulkOp();
bulk.find({ color: 'red' }).upsert().updateOne({ $set: { size: 'small' }});
bulk.execute(function(err, res) {
	console.log('find(red).upsert().updateOne() red small err ' + JSON.stringify(err, null, 2));
	console.log('find(red).upsert().updateOne() red small res ' + JSON.stringify(res, null, 2));
	var bulk2 = coll.initializeUnorderedBulkOp();
	bulk2.find({ color: 'red' }).upsert().updateOne({ $set: { size: 'medium' }});
	bulk2.execute(function(err, res) {
		console.log('find(red).updateOne() medium err ' + JSON.stringify(err, null, 2));
		console.log('find(red).updateOne() medium res ' + JSON.stringify(res, null, 2));
		db.close();
	});
});

Here's the 2.3.0 results:
find(red).upsert().updateOne() red small res {
  "writeErrors": [],
  "writeConcernErrors": [],
  "nInserted": 0,
  "nUpserted": 1,
  "nMatched": 0,
  "nModified": 0,
  "nRemoved": 0,
  "upserted": [],
  "ok": 1

and
find(red).updateOne() medium res {
  "writeErrors": [],
  "writeConcernErrors": [],
  "nInserted": 0,
  "nUpserted": 1,
  "nMatched": 0,
  "nModified": 0,
  "nRemoved": 0,
  "upserted": [],
  "ok": 1
}

As you can see, they're identical even though the operation result is different if you look in the server logs.  For the record, even though the results returned are wrong, the database is updated correctly.
Here's the result from 0.18.2, which matches what I would expect and matches what the server logs show (and matches the REPL if you do the commands there):
find(red).upsert().updateOne() red small res {
  "ok": 1,
  "writeErrors": [],
  "writeConcernErrors": [],
  "nInserted": 0,
  "nUpserted": 1,
  "nMatched": 0,
  "nModified": 0,
  "nRemoved": 0,
  "upserted": [
    {
      "index": 0,
      "_id": "57764873f765d5de9d30ceae"
    }
  ]
}

and
find(red).updateOne() medium res {
  "ok": 1,
  "writeErrors": [],
  "writeConcernErrors": [],
  "nInserted": 0,
  "nUpserted": 0,
  "nMatched": 1,
  "nModified": 1,
  "nRemoved": 0,
  "upserted": []
}

I noticed that in 0.18.2, after a result is returned from the server, mongojs processes that result with a call to mergeBatchResults(), but does not make a similar call in 2.3.0.  Perhaps this needs to happen?
mergeBatchResults can be found in mongojs/node_modules/mongodb/lib/mongodb/collection/batch/common.js

There also seems to be problem with error handling in bulk updates, for example if I have a field called uid which I have defined as an index with unique values and I do something like
`
// add an entry with uid 1
db.collection('airspring.DataDictionary').insert({ id: '1', val: 'anything', uid: '1' }, function(err, status) {
console.log('complete, error: ' + JSON.stringify(err) + ', status: ' + JSON.stringify(status));
});
// try to insert a second entry with same uid
var bulk = db.collection('airspring.DataDictionary').initializeUnorderedBulkOp();
bulk.find({ id: '2' }).upsert().updateOne({ id: '2', val: 'anything else', uid: '1' });
bulk.execute(function(err, status) { console.log('complete, error: ' + JSON.stringify( err) + ', status: ' + JSON.stringify(status) ); });
`
The bulk update callback will not return anything under error and writeErrors and writeConcernErrors are both null, but of course nothing was added because uid 1 violates the unique key constraint.
If I were to do
db.collection('airspring.DataDictionary').update({ id: '2' }, { id: '2', val: 'anything else', uid: '1' }, { upsert: true }, function(err, status) { console.log('complete, error: ' + JSON.stringify( err) + ', status: ' + JSON.stringify(status) ); });
I will correctly get an error message

Note if I try the above direct against my mongo cli I get an error message in the writeErrors array under the status object in the callback which is what I would expect the mongojs callback to return

I no longer have need of this fix.


ASSERTION_FAILED message result

Currently, message sent to a server can either be handled successfully or wait for state change.
Another option should be possible: terminate the program with error.
Example: reading from a buffer when it's empty, putting value into it when it's full.
Proposed syntax:
{ message | cond } -> ASSERTION_FAILED

Or maybe change this to be aligned with the new syntax more (#5, #7) -- could look like this:
... -> { fail; }


Accessibility: Language switcher needs to be completely usable with keyboard

The language switcher in the footer needs to be completely usable with the keyboard.
Preferably, it should even be "delightfully usable" with the keyboard. :)
Here's a little scenario to show what a "delightful experience" might be like, if it was problem-free.
Steps (note: do all steps in the footer without touching your mouse or trackpad):

Go to: https://ibmdotcom-react.mybluemix.net/iframe.html?id=components-footer--default
Start typing the tab key all the way until the language switcher has focus.
Type space or enter to open the dialog.
Problem 1: Where is the focus? There should be a clear focus indicator.
Oops, didn't mean to open that - type Esc to close it...
Problem 2: Esc key should close dialog no matter which part of dialog has focus
Type tab to move focus to the close (X) button.
Type space or enter to activate the close button and close the dialog.
Oops, didn't mean to close that - type space or enter to open it again...
Problem 3: Focus should return to the trigger element when a dialog is closed
Type shift+tab to move focus back to the switcher button, and then space or enter to open again.
Type tab to focus the close button, and then type tab again.
Problem 4: Where are you? What has the focus? There should be a clear focus indicator.
Type Enter to try to figure out where you are. Oh! It switched to the Americas page...
Problem 5: But there's no focus indicator to show where the focus is.
Type tab and note that focus moves to the Search field. Type aru and note that there's only one item (Aruba English) in the list.
Problem 6: Wouldn't it be really nice to be able to just type enter here to select Aruba English (instead of tab, tab, enter), since there's only one item in the list?
Oops, decided not to switch to Aruba, so type Esc to clear the aru from the search field...
Problem 7: The dialog closes. When Esc is typed in a search field, the text should be cleared, and you need to call event.preventDefault() and event.stopPropagation() so that the dialog doesn't close. If the user types Esc in the search field when the search field is empty, then you can close the dialog.
So (remember to use only the keyboard!), open the dialog again, navigate to the Americas, and type aru in the search field.
This time, type tab to move focus to the clear (X) button, and type space or enter to clear the search field.
Type ar. There are 5 items in the list. Type down arrow to select an item in the list...
Problem 8: Down arrow should navigate to the first item in the list, and when in the list, down and up arrow should be used to navigate through the items, and NOT the tab key, i.e. the list itself is a single tab stop control.
Now imagine that you really wanted to select a language in Europe. You are currently in the Americas. How do you get to Europe using only your keyboard?
Problem 9: You can't focus the "<- Select region" button using only the keyboard. The only way to go back and select another region with the keyboard is to close the dialog and start again.

Also, if you type the tab key past the end of the dialog, the user might want to type shift+tab to go back into the dialog, but it doesn't work. To get out of that situation the user has to type tab again to wrap focus to the top of the dialog.

Thanks Carolyn!

Linda creating an issue to get Ram's feedback on the accessibility issues.

New issue created for Accessibility team to run tests on https://github.com/carbon-design-system/ibm-dotcom-library/issues/1726

Accessibility testing was finished.  Bugs were opened based on that testing.  The bugs are being prioritized and scheduled in the future sprints.  Closing this issue.


[QualUI] Support UI in Qualification Report

fixes #5176
The code changes generate html/js static content which the user can load into their browser.
How it works:

static HTML/JS files are added to the repo in tools/src/main/resources/ui
After analyzing all the application in the eventLogs, the Qualification.qualifyApps qould launch the UI report generator.
First, the static files are going to be copied to the report output folder
Second, the case classes will be serialized to JSON and written as JS variables.
When the user loads the HTML/index.html file, the JS will be read and rendered in the viewer.

How to use the feature

There is no requirement to enable the feature since it is enabled by default.
Run the qualificationTool in the CLI, then load output-folder/ui-report/html/index.html in your folder

Tools used:

Bootstrap4
Datatables plugin
JQuery and Mustache.

Changes done to the scala code to support this feature:

added new flag UIEnabled set to true by default to enable/disable UI reporting.

Added new fields to the QualificationSummaryInfo
longestSqlDuration: Long,
nonSqlTaskDurationAndOverhead: Long,
estimatedDuration: Double,
unsupportedDuration: Long,
speedupDuration: Long,
speedupFactor: Double,
totalSpeedup: Double,
speedupBucket: String)

Modified QualOutputWriter to the CSV files

Added methods in QualificationAppInfo to calculate more information for each app.

Modified unit tests.

Things Left on purpose:

Unit test for the added fields in QualificationSummaryInfo. Those fields are mocks for now and it would be useless to write unit tests for unstable code. (some of those fields are randomly generated)
Updating the docs: The feature is not stable. Field names, and description is likely going to change over the next couple of weeks.

Known issues to be improved later

separate provider of the information so that it will be feasible to test the UI-report without the need to run the entire tool.
Create unit tests for stable parts of the feature. Currently, it won't be feasible to do that as the requirements change frequently.
refactor JS/HTML code
Maybe move the static code out of the repo and add it as a build dependency. UI code has more tendency to change and it will cause lots of overhead to do PRs on the main repo.

replaced by #5407


add getNodeAttrs in menu's scope slot

Is your feature request related to a problem? Please describe.
when I create a node with attrs, I cant edit it
Describe the solution you'd like
getNodeAttrs API in menu's scope slot
Describe alternatives you've considered
I'm not very familiar with source code
Just like getMarkAttrs

Hey @philippkuehn, I'm missing this slot property as well. For now I'm getting the attributes of the currently selected node via a computed property. But it's being recalculated every time the selection changes of course :/
  computed: {
    selectedNodeAttrs () {
      const { node } = this.editor.state.selection
      if (node && node.type.name === 'my_node_name') {
        return node.attrs
      }
      return null
    }
  },

Or is there a better solution for this already?

Is there an example how to use this? I cant figure it out... must be trivial I suppose ))

This was indeed simple, needed to upgrade tiptap to latest version and then this works:
<template v-if="isActive.image()">
        Your image info:
        alt={{ getImageAttr.alt }}
        src= {{ getImageAttr.src }}
        title ={{ getImageAttr.title }}
      </template>

Except that I also need updateAttrs .. :-(
Created new issue for that #676


@conda-forge-admin, please rerender

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/perspective-feedstock#81.


Linux version doesn't link to libm for math.odin

I solved it by directly inserting -lm to this line: https://github.com/gingerBill/Odin/blob/a80872b/src/main.c#L433

Why does it need to?
What functions in use are a part of libm?
If you can list what needs libm in compilation, then the this will be a quick fix, as the proper way to solve this is to have something like this in the offending file:
#foreign_system_library libm "m";
my_libm_proc :: proc() #foreign libm;

What functions in use are a part of libm?
sin, cos, tan

I'm adding it to the next commit. However, I hope to remove the explicit need for it later.

@gingerBill thanks!


How to add '; ' after each style

https://github.com/sass/sass/issues/3517
thanks for your plugin, i am using it.
and i meet this question, can you help me?

Hehe, it's probably not going to solve your actual problem, but you could try this:
plugins: [{ sass({ processor:(css)=>css.replaceAll("}", ";}") }) }]


[AUTO-CHERRYPICK] Merged October 2.0 release to the fast-track branch - branch main

This is an auto-generated pull request to cherry-pick commit 2343f6b3c400307a501c0c832280bf557053152f to main. Original PR: #10701

Already part of main.


[FEATURE] Horizontal Timeline

Is your feature request related to a problem? Please describe.
The vertical layout of the timeline makes it a bit difficult to fully understand the relationship of event ranges to other event ranges. This difficulty comes primarily from the fact that, the within this vertical layout, the event is the priority, not the range of time it takes up.
Describe the solution you'd like
An option to render the timeline horizontally would help alleviate the aforementioned issue. In my mind, this layout would feature a sort of "axis" or meter on the bottom that show reference dates. Above this "axis" would be the event ranges. Along with that, the event cards would be hidden until their respective range is hovered over in order to promote readability. Attached is an example layout from another plugin that I believe would work well.
Describe alternatives you've considered

An option to hide event cards and/or reduce their size
An ability to add an "axis" that would run alongside the events and their ranges

Additional context
Example from Darakah's obsidian-timelines plugin

Hi!
I knew the day would come when someone would request this.
I think before any major update like the addition  of horizontal timelines there would definitely need to be an update of the range system
It's very inaccurate right now and doesn't provide any numerical information, so your suggestion of adding an axis makes a lot of sense.
I'm very much inclined to develop this feature but this will take a whole bunch of time and I got a few other things I would like done before tackling this behemoth
Again, I really appreciate the time you took to write this. In the meantime I hope you'll still find some use out of aat

Alright, I hope to see this feature one day, but I understand why it can't be implemented yet. Thank you for developing this plugin, I'm excited to see how it will grow!


Inconsistent plymouth change

I've seen that you have new logo now! It's very good and I can only congratulate you for it.
I've also seen that boot animation and bazzite portal looks is different. Previously instead of "Bazzite" and your logo, there was Fedora logo and "Fedora".
Unfortunately changed logo appears only when turning off. Old boot is still there when turning on.
It's not a big issue at all but just makes the os feel inconsistent

Definitely want to fix this, looking into where that's coming from on first boot vs any other state.

@EyeCantCU Looks like to fix this we need to rebuild initramfs
Good news is we needed to do that anyway to get an OSK working for encrypted disks on deck, so this could be a nice intro to that.


[Question]InternalError: Check failed: (lib_handle_ != nullptr) is false: Failed to load dynamic shared library dist\prebuilt\lib\Llama-2-7b-chat-hf\Llama-2-7b-chat-hf-q4f16_1-metal.so Stack trace not available when DMLC_LOG_STACK_TRACE is disabled at compile time.

❓ General Questions

How should I solve the following problem when I am running  Llama-2-7b-chat-hf-q4f16_1-MLC.
My GPU memory size is 7.9GB.

the vulkan issue should have been fixed in latest update, please try to remove model_lib_path


FRO-129 Fix Redirects

upgrade next and react
audit fix deps
furthur updates
Ran codemod: npx @next/codemod new-link .
Ran codemod: npx @next/codemod next-image-to-legacy-image .
manually fix issues
add semicolon
wip
wip
tidy up

Opened by accident see #910


Add Visual Studio version required for RoslynCodeTaskFactory

Update the docs for MSBuild RoslynCodeTaskFactory with the full name of Visual Studio 2017 15.8 as per discussion via #4319

@augustoproiete : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fitting Photometric API empty

The Fitting Photometric API page, in the documentation, seems to be empty for the latest version.  The previous version looks okay.

Oh yeah, I just noticed that the other day. Will have a look.

This is apparently due to a bug in Sphinx 1.3, now widely reported: sphinx-doc/sphinx#1822. There's a fix already proposed in sphinx, so hopefully the fix will be in the next released sphinx version (presumably 1.3.3). Unfortunately I think we'll just have to wait for that release, and then for readthedocs to update to it.
The work-around seems to be hand-writing the table of functions, which doesn't seem worth it at this point (assuming the fix will be released soonish).

Found a much easier work-around in 9c629b6a0c. Seems to be fixed.


12 Add support for ignoreAreas

Resolves #12

@dcrowe I faced an issue when server response has  diffName as None
added test case for it, but I'm not able to fix it :(
Traceback (most recent call last):
  File "example.py", line 21, in <module>
    vrt.track(TestRun(
  File "/Users/pashidlos/work/vrt/sdk-python/visual_regression_tracker/visualRegressionTracker.py", line 91, in track
    result = self._submitTestResult(test)
  File "/Users/pashidlos/work/vrt/sdk-python/visual_regression_tracker/visualRegressionTracker.py", line 86, in _submitTestResult
    testRunResult = _from_dict(result, TestRunResponse)
  File "/Users/pashidlos/work/vrt/sdk-python/visual_regression_tracker/types.py", line 91, in _from_dict
    obj = dacite.from_dict(clazz, data)
  File "/Users/pashidlos/.conda/envs/sdk-python/lib/python3.8/site-packages/dacite/core.py", line 65, in from_dict
    raise WrongTypeError(field_path=field.name, field_type=field.type, value=value)
dacite.exceptions.WrongTypeError: wrong value type for field "diffName" - should be "str" instead of value "None" of type "NoneType"

works as expected!
@dcrowe thank you for support!

https://twitter.com/VisualReTracker/status/1326073973742964738


Upper/lowercase are causing the places plugin to fail

Giving the following base string: "tourism trends in the Philippines".
tourism trends in the Philippines
knwl.get('places') outputs:
[ { place: 'Philippines',
    preview: 'tourism trends in the Philippines',
    found: 2 } ]

but
tourism trends in the philippines
Tourism Trends In The Philippines
TOURISMG TRENDS IN THE PHILIPPINES
knwl.get('places') outputs: nothing (empty array)

Hi, @edravis! The places.js plugin has been updated to recognize a wider range of inputs.


Fix namespaces

Breaking change

All namespaces are corrected and unified. What was previously present in JoySoftware.HomeAssistant.* now lies in NetDaemon.*
Proposed change

The namespaces in the project are a bit of a mess. We should unify them so that they correspond to the file structure and are more easy to use. As discussed with @helto4real on the Discord channel, we changed the root namespace of every project to NetDaemon.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[X] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

Link to documentation pull request:

Checklist

[X] The code change is tested and works locally.
[X] Local tests pass. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the [development checklist][dev-checklist]
[X] The code compiles without warnings (code quality chek)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

That looks way better. But we need to be very communicative about this breaking change since it will break all existing apps for people (just a namespace change) but will benefit development in long term. I like where the change is headed


could this support deterministic random values?

could I specify the randomness source and get deterministic random values?

Right now, we use a global var for the randomness source. @wolf-joe please chime in, is it possible to support this?

Maybe we can pass a seed number to those generate functions by options, but making the seed number work everywhere is difficult.

How about letting these generators share the same seed number?
this should be helpful for detecting determinism issues


Textfield allow 0 value

For textfields we were only showing 'truthy values'. Allow when type is number, to have value 0.

@constanzauanini just one thing.. we don't want to default to showing '0' in some cases (PM preference) .. as long as we can show undefined as empty we should be ok.. i think maybe that's why we had this mixed/strange behavior

@constanzauanini just one thing.. we don't want to default to showing '0' in some cases (PM preference) .. as long as we can show undefined as empty we should be ok.. i think maybe that's why we had this mixed/strange behavior

Oh, you are right. This behavior was for showing empty values. Undefined will work, but I think we have some cases where we need to initialize type "numbers" as zero (not undefined values allowed), and this change, will affect that behavior.
But without this change the seedling details for example are not showing the 0 values where it should.

@constanzauanini just one thing.. we don't want to default to showing '0' in some cases (PM preference) .. as long as we can show undefined as empty we should be ok.. i think maybe that's why we had this mixed/strange behavior

Oh, you are right. This behavior was for showing empty values. Undefined will work, but I think we have some cases where we need to initialize type "numbers" as zero (not undefined values allowed), and this change, will affect that behavior.
But without this change the seedling details for example are not showing the 0 values where it should.

Got it, we can iterate as needed for sure. Thanks for fixing this now.

@constanzauanini just one thing.. we don't want to default to showing '0' in some cases (PM preference) .. as long as we can show undefined as empty we should be ok.. i think maybe that's why we had this mixed/strange behavior

Oh, you are right. This behavior was for showing empty values. Undefined will work, but I think we have some cases where we need to initialize type "numbers" as zero (not undefined values allowed), and this change, will affect that behavior.
But without this change the seedling details for example are not showing the 0 values where it should.

For example when adding a new observation test we don't allow undefined for seedsGerminated, now the textfield type is text so it will not affect the current behavior, but when we update it to type number it will show the zeros. We could create a new type that allows undefined maybe for that case.
Ok, I will merge this since I think is correct behavior


agent.setConfiguration() and agent.setState() / agent.setStatus() are not working in latest versions(1.7.5,1.7.0) which is working fine in lower versions(1.6.1, 1.6.3)

Below are the issues which was identified
Version 1.7.5, 1.7.0
agent.setConfiguration()
var config = agent.getConfiguration();
config.extension = "+18005550100";
config.softphoneEnabled = false;
agent.setConfiguration(config {
success: function() { /* ... / },
failure: function(err) { / ... */ }
});
Issue: InvalidLocale
agent.setState() / agent.setStatus()
var state = agent.getAgentStates()[0];
agent.setState(state, {
success: function() { /* ... / },
failure: function(err) { / ... */ },
},
{enqueueNextState: false}
});
Issue: {"type":"UnexpectedParameter","message":"Unexpected key 'enqueueNextState' found in params","stack":["UnexpectedParameter: Unexpected key 'enqueueNextState' found in params","    at ParamValidator.fail (https://connect-config-dev.my.connect.aws/static/connect-stream.js:6514:37)","    at ParamValidator.validateStructure (https://connect-config-dev.my.connect.aws/static/connect-stream.js:6541:14)","    at ParamValidator.validateMember (https://connect-config-dev.my.connect.aws/static/connect-stream.js:6552:21)","    at ParamValidator.validate (https://connect-config-dev.my.connect.aws/static/connect-stream.js:6498:10)","    at Request.VALIDATE_PARAMETERS (https://connect-config-dev.my.connect.aws/static/connect-stream.js:4957:42)","    at Request.callListeners (https://connect-config-dev.my.connect.aws/static/connect-stream.js:8768:20)","    at callNextListener (https://connect-config-dev.my.connect.aws/static/connect-stream.js:8758:12)","    at Request.VALIDATE_CREDENTIALS (https://connect-config-dev.my.connect.aws/static/connect-stream.js:4911:53)","    at Request.callListeners (https://connect-config-dev.my.connect.aws/static/connect-stream.js:8764:18)","    at Request.emit (https://connect-config-dev.my.connect.aws/static/connect-stream.js:8740:10)"]}
Version 1.6.8
agent.setConfiguration()
var config = agent.getConfiguration();
config.extension = "+18005550100";
config.softphoneEnabled = false;
agent.setConfiguration(config {
success: function() { /* ... / },
failure: function(err) { / ... */ }
});
Issue: ERROR ReferenceError: AgentErrorStates is not defined
at Agent.push.3168.Agent.setConfiguration (connect-streams.js:24158)
Version 1.6.3
loginPopup: true,               // optional, defaults to true
loginPopupAutoClose: true,      // optional, defaults to false
loginOptions: {                 // optional, if provided opens login in new window
autoClose: true,              // optional, defaults to false
height: 600,                  // optional, defaults to 578
width: 400,                   // optional, defaults to 433
top: 0,                       // optional, defaults to 0
left: 0                       // optional, defaults to 0
},
Issue: Login popup is not opening for specified height and weight Rather it's opening in new tab
Please help on this

Hi tamilmani-m, I'm checking the snippets you provided:
for the issue: InvalidLocale you will need to set a locale in config as well like this config.agentPreferences.locale='en_US' (or another valid locale string)
Regarding this one:
agent.setState() / agent.setStatus()
var state = agent.getAgentStates()[0];
agent.setState(state, {
success: function() { /* ... / },
failure: function(err) { / ... */ },
},
{enqueueNextState: false}
});

You have extra } at the end, it should be just );

Hi @tamilmani-m, for the setConfiguration issue, this is apparently a bug. Please see the workaround posted to another issue #460


connectionPool.http.idleTimeout not workiing

According to https://istio.io/docs/reference/config/networking/v1alpha3/destination-rule I should be able to use the above setting however i'm getting the following error in pilot:
2019-04-12T18:45:34.079616Z	error	Failed to convert destination-rule object, ignoring: sourcing-recommendation-service/sourcing-recommendation-service YAML decoding error: host: app
trafficPolicy:
  connectionPool:
    http:
      idleTimeout: 30s
  loadBalancer:
    simple: LEAST_CONN
  tls:
    mode: ISTIO_MUTUAL
 unknown field "idleTimeout" in v1alpha3.ConnectionPoolSettings_HTTPSettings map[trafficPolicy:map[connectionPool:map[http:map[idleTimeout:30s]] loadBalancer:map[simple:LEAST_CONN] tls:map[mode:ISTIO_MUTUAL]] host:app]

Istio 1.1.2

@Stono I think this feature went in 2 days ago https://github.com/istio/istio/pull/13146/files
are you using a daily build or the official 1.1.2 release?

Ahhh official, I could grab the latest daily and use that instead.

Yup works with the latest daily, thanks.
Probably want to keep the docs inline with the current official release - it's confusing! :)


it showing black color on top of tabbar

hello
your  developed good control for tabbar
i have implemented in  objective c project  but is showing black color on tababr
attached  screenshot here
how to resolve this problem

Sorry I didn't sure that I understood you correctly!
You are working on an Objective-C Project and try to use that Lib there?
Or are you trying to reimplement this control in Objective-C?
It looks like the background have a black color.
Without a look at your code it is not possible for me to say what that (black) background is. To be sure simply set all views in your StoreyBuilder to a transparent image or provide me your code!?

thanks for your reply
i dropped your swift file in objective c project
and given  tabbar child class to RollingPitTabBar in Storyboard
i have not did  any code  for this
thanks

I see!
But is there a view behind the TabBar?
It looks like there is much more on your scene than only the TabBar.
Could you create a complete new and empty ViewController with only a TabBar and change there the base class?

thanks for quick reply
i checked as per your suggestion and it working fine in only empty ViewController
but what if ViewController has tableview or another controller in it showing black
i have given bottom side minus padding and it working fine
but if ViewController's view   has white color then it not showing tabbar  i would it you help me to give shadow of  uitabba here is attache screenhot

Pls help me if possible
i want to implement like this screenshot
viewcontroller view color is white but tabbar show perfectly

Hi,
sounds good that it works now.
I don't know why the tableviewcontroller has a black background. Maybe there are some "black" layers that should be configured correctly.
You could also align the tableviewcontroller above the tabbar and not "below" it.
Regarding the shadow: your welcome to create a contribution on this lib and implement the shadow by yourself.
Otherwise, create a separate Issue and tag it as an enhancement.
If I find the time I will have a look at it.


How to know if the html file added to assets in angular.json file is picked by ng serve?

We have added a.html file to the assets section in angular.json file and ran "ng serve" command
How do I access this a.html file in web browser? How do I know if "ng serve" command recognized that file? How do I know if I used the correct url to access a.html in web browser?
It is better to provide debug feature for the end users for easy debugging instead of asking angular team  for help

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


Some minor fixes to BufferedStreams

@mmalecki So the problem here was two fold. The req objects that come in to middleware handlers are buffered by default. So no data or end events will be emitted. I added a feature to our BufferedStream implementation which can disable buffering:
  req.buffer = false;

But this feature should be used with extreme caution

@mmalecki Also worth nothing that this pull-request requires this change in director for all tests to pass: https://github.com/flatiron/director/pull/75


chore: Add elaborator to CI

Description
Problem*
Resolves
Summary*
Adds the elaborator to our CI test_programs tests and frontend tests. At the time of writing this is expected to still be failing a couple tests.
After https://github.com/noir-lang/noir/pull/5169 is merged, there should only be two failing tests related to globals with function calls in their RHS. We can wait to merge this PR until all tests are fixed, this PR is mostly to help track progress on CI.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher Shall we just add #[ignore] attribute for these so we can merge this PR? We can enable those tests when we're ready but will avoid people having to explicitly remember to add elaborator versions of any code they change.

These bugs are fixed in https://github.com/noir-lang/noir/pull/5172 (which also includes this PR) so we can just wait for that to merge. Closing this.


[Tables] Multi tenant authentication

Adds a challenge policy for clients created with an azidentity credential
#17332

/azp run go - aztables

/azp run go - aztables


example template override path is added to the location of the svg-sprite module

I am using gulp-svg-sprite v1.1.0 and trying to do some overrides to the example html output. I have something similar to this in my configuration:
...
example: {
  template: 'src/templates/css/sprite.html'
},
...

This is also the same type of configuration given by the online generator.
When I run the build, svg-sprite prefixes it's own path to the override path I have given it and fails the load since it does not exist. I tested an override of the css output for the css mode and that worked without fail, so it looks to be isolated to the example markup implementation.

Hey Al,
thanks for reporting this! When I try this (with the exact same setup as you do), svg-sprite just behaves fine. So it seems to be something specific to the Gulp wrapper. I'll investigate this further.
Cheers,
Joschi

Should work now. Please let me know if you've still got problems overriding the template path. :)

I will give it a try and let you know if there is still an issue. Thank you for the promptness.

@Zarabadoo Any luck with this? I'm having the same issue.

@mcraiganthony Do you use the latest release? Which platform are you on? Could you please post your complete config? Thanks.

@jkphl I tried the latest release which broke the build. I'm on a Mac.
Fortunately I had another repo using gulp-svg-sprite v1.1.0 so I copied it over. This fixed my issue. Must be a dependency problem within v1.1.0.

@mcraiganthony I updated and it works fine for me. My configuration is super complex and I am hesitant to post it all as most of it is not relevant to this problem. The example portion is pretty straight forward, though.
...
example: {
    template: 'src/templates/sprite/sprite.html'
},
...

@Zarabadoo Glad to hear that it works for you!
@mcraiganthony Please be aware that I fixed the template path issue for v1.1.1, so v1.1.0 won't give you the results you are looking for. Can you specify "broke the build" any further?

@Zarabadoo @jkphl
I updated to v1.1.1 again.
The config below no longer works and throws this error:
Error: ENOENT, no such file or directory '/Users/craig/Git Repos/boomstrap/tmpl/symbol/sprite.html
Let's forget about template overrides for now. Why does this config no longer work? It used to generate "sprite.symbol.html".
gulp.task(Tasks.BoomstrapSvgIconsDev, function () {
  return gulp.src('icons/**/*.svg')
    .pipe(imagemin())
    .pipe(gulp.dest('docs/icons'))
    .pipe(svgSprite({
      'svg': {
        'xmlDeclaration': false,
        'doctypeDeclaration': false,
        'dimensionAttributes': false
      },
      'mode': {
        'symbol': {
          'dest': '',
          'example': true,
          'sprite': 'sprite.svg'
        }
      }
    }))
    .pipe(gulp.dest('docs/icons'));
});

This Gulp task no longer works

@mcraiganthony Thanks for posting this. Sounds like I introduced some kind of regression bug — sorry for that. I'll test your config asap and get back to you.

@jkphl Thanks man! I appreciate it. Sorry for being unclear initially.

@mcraiganthony You're welcome. Just need to get my daughter to bed before ... ;)

@mcraiganthony This has definitely been a regression bug — I'm very sorry for the inconvenience. I just  committed a fix. I'll try to fix some other bugs as well and push out a new release later tonight. Please let me know if this works for you then!

@jkphl Oh man, no worries at all! Thanks for your responsiveness and for authoring this project. It's been a huge help!
I'll check for the release tomorrow morning and give it another go. Thanks again!

@jkphl v1.1.2 works like a charm! Thanks so much!

@mcraiganthony Thanks for letting me know! You're welcome :)


Add credits section

Would be nice to have a section or modal somewhere with some contact information and links about the project somewhere. This could be in a (i) on the very right of the navbar.

Addendum to this, but the citation within the package (for use with cite()) should also be included

Citation has been added and a link to the github repository has been added to the top left corner by the title. I'll need to update the citation once the DOI for the proceedings is figured out.


BucketsAclScanner not working

Reported by Antoine.
BucketsAclScanner not working due to "Commands out of sync; you can't run this command now" error.
Error:
File "build/bdist.linux-x86_64/egg/MySQLdb/connections.py", line 36, in defaulterrorhandler raise errorclass, errorvalue ProgrammingError: (_mysql_exceptions.ProgrammingError) (2014, "Commands out of sync; you can't run this command now") [SQL: u'SELECT `86b68fabef8f4387ab709b6f639cf271_resources`.cai_resource_name AS `86b68fabef8f4387ab709b6f639cf271_resources_cai_resource_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.cai_resource_type AS `86b68fabef8f4387ab709b6f639cf271_resources_cai_resource_type`, `86b68fabef8f4387ab709b6f639cf271_resources`.full_name AS `86b68fabef8f4387ab709b6f639cf271_resources_full_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.type_name AS `86b68fabef8f4387ab709b6f639cf271_resources_type_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.parent_type_name AS `86b68fabef8f4387ab709b6f639cf271_resources_parent_type_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.name AS `86b68fabef8f4387ab709b6f639cf271_resources_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.type AS `86b68fabef8f4387ab709b6f639cf271_resources_type`, `86b68fabef8f4387ab709b6f639cf271_resources`.policy_update_counter AS `86b68fabef8f4387ab709b6f639cf271_resources_policy_update_counter`, `86b68fabef8f4387ab709b6f639cf271_resources`.display_name AS `86b68fabef8f4387ab709b6f639cf271_resources_display_name`, `86b68fabef8f4387ab709b6f639cf271_resources`.email AS `86b68fabef8f4387ab709b6f639cf271_resources_email`, `86b68fabef8f4387ab709b6f639cf271_resources`.data AS `86b68fabef8f4387ab709b6f639cf271_resources_data` \nFROM `86b68fabef8f4387ab709b6f639cf271_resources` \nWHERE `86b68fabef8f4387ab709b6f639cf271_resources`.type_name = %s'] [parameters: (u'project/gbl-imt-ve-datalake-prod',)] (Background on this error at: http://sqlalche.me/e/f405)

@hshin-g can this be closed?


vala updates

Motivation for this change
https://github.com/NixOS/nixpkgs/pull/57027
I feel like we have maybe one too many compiler versions here, so I'd like to know which one would be acceptable for removal.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Upstream usually supports three most recent branches so ideally, we would not keep more than these. Personally, I would just keep the latest branch but elementary probably depends on the ancient version in Ubuntu LTS and we also have a lot of Vala abandonware, so we might not afford to drop that much yet.

Upstream usually supports three most recent branches so ideally, we would not keep more than these.

Exactly, hence my confusion in us keeping more than these

Personally, I would just keep the latest branch but elementary probably depends on the ancient version in Ubuntu LTS

They actually, at least recently, push fixes for any breakage that they notice will happen with the latest vala. Ubuntu LTS is at 0.40  but we should be able to use 0.44 for Pantheon.
Only thing that could be a large annoyance is the "third party apps" are tested against 0.40 so they'll slowly break as the LTS goes by.

I've corrected the patches and added a patch so libhttpseverywhere can build with latest vala.

@jtojnar I should merge this into the gnome branch?

I would just merge it to staging. And rebase gnome-3.32 onto that (since we already want that for gdk-pixbuf).

Should this use callPackages at the top-level?

Possibly, I am not sure what the difference is though.
Also, it would be nice if we could make updateScript work.


fix: [Held requests] Approval popup for a report with hold expense has X Close option it.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/41252
PROPOSAL: https://github.com/Expensify/App/issues/41252#issuecomment-2083661978
Tests

Create a couple of expenses (e.g. Submit expense)
Once your report has more than one expense, click on the report
Choose one of the expenses on the report
In the transaction thread, tap the three vertical dots and hold an expense
In the report, click approve or pay
Verify X close btn is not shown in the modal

[x] Verify that no errors appear in the JS console

Offline tests

Create a couple of expenses (e.g. Submit expense)
Once your report has more than one expense, click on the report
Choose one of the expenses on the report
In the transaction thread, tap the three vertical dots and hold an expense
In the report, click approve or pay
Verify X close btn is not shown in the modal

QA Steps

Create a couple of expenses (e.g. Submit expense)
Once your report has more than one expense, click on the report
Choose one of the expenses on the report
In the transaction thread, tap the three vertical dots and hold an expense
In the report, click approve or pay
Verify X close btn is not shown in the modal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/c38789bd-b881-4618-90f0-2274c24d6a7c

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/06ae5cfd-596c-4ba9-86ad-1f1b4bf6ed52

iOS: Native
https://github.com/Expensify/App/assets/85894871/3421c653-eab3-4383-8fc1-b570502372ac

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/c51e298c-e65d-43b2-842e-77e13a801606

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/f5b1e012-7b9a-42d8-8ad1-713aa6015c84

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/913fe257-6423-4f81-8e0b-32f8348d84e1

@Krishna2323 All platforms pass the test, except Android and iOS: Native where the header title of the DecisionModal is not visible, most likely some styling issue specific to the native platforms. Here's a before / after (after showcasing the PR):

iOS: Native (before / after)

Before
After

[!note]
I noticed that the issue is visible in your Android: Native video too, and on iOS: Native you added the same video as for iOS: mWeb where the issue is not present.

Let me know when you fix the issue and I'll re-test and complete the reviewer checklist.

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Bump up OpenSSL versions

https://www.openssl.org/news/secadv/20230731.txt

I'm not sure why https://github.com/rbenv/ruby-build/actions/runs/5719870214/job/15517987944#step:4:18 is broken. It's not related with this.


Unknown license vulnerability

Snyk was not able to detect a license for this package. This could occur from a package file that lacks a license definition.

Snyk didn't try too hard then. There is both a mention in package.json and in a file called LICENSE.

Any reason why the license section in npm is displaying 'none' ?


[fix] improper initialization if parts are used multiply

Coverage increased (+0.07%) to 84.647% when pulling 977b3e85ece50c535c45e8573f659c2bb8c7623d on fix-site-search-part into 10e4d10ba4daf7ce184e0faf706f29efb9a58cd8 on master.


WIP - Use built-in FAQ functionality

Use built-in FAQ functionality - https://about.okkur.org/syna/fragments/faq/

Only need to fix the expanding/collapsing per question.

Anyway to preview the changes - other than look at the changed files ?

The netlify check at has a details link that links to it staged. Says deploy-preview. Note that there is a bug in this and the FAQ isn’t expanding.

Closing in favor of new website

What were the specific reasons to move away from Syna? Happy to learn from your experience and at least improve Syna retrospectively.

We went with a custom theme, for the rest Syna was working fine - Thanks!

Great and unfortunate to see you move to a custom theme even if it looks great :)
Also welcome in the CNCF community.


[QUESTION] <Why are icons and favicons not displaying correctly?>

Question
I am using Docker.
/usr/local/emhttp/plugins/dynamix.docker.manager/scripts/docker run -d \
  --name='Mafl' \
  --net='bridge' \
  -e TZ="Asia/Shanghai" \
  -e HOST_OS="Unraid" \
  -e HOST_HOSTNAME="Home-NAS" \
  -e HOST_CONTAINERNAME="Mafl" \
  -l net.unraid.docker.managed=dockerman \
  -l net.unraid.docker.webui='http://[IP]:[PORT:30000]' \
  -l net.unraid.docker.icon='https://raw.githubusercontent.com/selfhosters/unRAID-CA-templates/master/templates/img/mafl.png' \
  -p '30000:3000/tcp' \
  -v '/mnt/user/appdata/mafl/data/config.yml':'/app/data/config.yml':'ro' \
  -v '/mnt/user/appdata/mafl/favicons':'/app/public/favicons':'rw' \
  -v '/mnt/user/appdata/mafl/icons':'/app/public/icons':'rw' \
  'ghcr.io/hywax/mafl'

Here is the directory structure of my host machine.
root@Home-NAS:/mnt/user/appdata/mafl# tree
.
├── data
│   └── config.yml
├── favicons
│   ├── apple-touch-icon.png
│   ├── favicon.ico
│   ├── pwa-192x192.png
│   └── pwa-512x512.png
└── icons
    ├── Unraid_A.png
    └── Unraid_logo.svg

Here is my configuration file.
title: My NAS
lang: zh
theme: system
checkUpdates: true
behaviour:
  target: _blank
tags:
  - name: Home
    color: green
  - name: Work
    color: blue
services:
  常用:
    - title: unRAID
      icon:
        url: icons/Unraid_logo.svg
      description: unRAID 控制台
      link: http://<IP_ADDRESS>/
      tags:
        - Home
  工具:
    - type: ip-api

But when I access the site, the icons and favicons do not display correctly.

Category
Using Icons

👋 @AemonCao
Thanks for opening your first issue here!
To help make it easier for us to investigate your issue, please follow the contributing guidelines.
If you like this project, please ⭐ star our repo.

As of now, this issue has not been resolved. I am currently using the image URLs to replace the original relative paths of the images, and it is working fine.

As of now, this issue has not been resolved. I am currently using the image URLs to replace the original relative paths of the images, and it is working fine.

I cloned the project and tried to run it locally. I created a data folder under the .output path and placed the config.yml file in it, but it still prompts that the configuration file cannot be retrieved. I haven't found a good solution yet. Could you please confirm if the path where I stored the configuration file is correct?

Hi, sorry for the long reply.
Here are all the possible file paths:

src/public/favicons - initially, everything is stored here
.output/public/favicons - when build is copied to this folder
/app/public/favicons - docker image

Example
tree app
.example
├── config.yml
├── docker-compose.yml
└── favicons
    ├── apple-touch-icon.png
    ├── favicon.ico
    ├── pwa-192x192.png
    └── pwa-512x512.png

docker-compose.yml
version: '3.8'

services:
  mafl:
    image: hywax/mafl
    restart: unless-stopped
    ports:
      - '3000:3000'
    volumes:
      - ./config.yml:/app/data/config.yml
      - ./favicons:/app/public/favicons

If you can't do it, reopen the issue. I'll try to help in any way I can!


Repo Maintenance: unable to resolve types on VSCode editor and dev task loop

I'm setting up the project to work on #84.
I cloned the repository and I have run pnpm install.
After that I have encountered 2 problems:
1. apps/documentation types not resolved on VSCode
on apps/documentation files I'm not able to have import resolved correctly in the editor:

[!NOTE]
When running lint or types task from the CLI no error is present.
I can work by running CLI commands but I found out a little strange that the editor is not behaving the same.
It might be a VSCode issue, but I'm just wondering if you have a local setup or something else I might missed that can solve the issue.

2. dev task loop
Running pnpm dev  causes a loop:
tuono-fs-router-vite-plugin:dev:
tuono-fs-router-vite-plugin:build: cache miss, executing 552cb6325ef9d96f
tuono-fs-router-vite-plugin:dev: cache miss, executing 4361ae84ef2c11b2
tuono-fs-router-vite-plugin:build:
tuono-fs-router-vite-plugin:dev:
tuono-fs-router-vite-plugin:dev:
tuono-fs-router-vite-plugin:dev: ><EMAIL_ADDRESS>dev /Users/marcalexiei/development/tuono/packages/fs-router-vite-plugin
tuono-fs-router-vite-plugin:dev: > vite build --watch
tuono-fs-router-vite-plugin:dev:
tuono-fs-router-vite-plugin:build:
tuono-fs-router-vite-plugin:build: ><EMAIL_ADDRESS>build /Users/marcalexiei/development/tuono/packages/fs-router-vite-plugin
tuono-fs-router-vite-plugin:build: > vite build
tuono-fs-router-vite-plugin:build:
tuono-fs-router-vite-plugin:dev: cache miss, executing 87911e2c75a3e2d2
tuono-fs-router-vite-plugin:build: cache miss, executing 383aa3afd2063cef

Logs screenshot

System information
  System:
    OS: macOS 15.1
    CPU: (8) arm64 Apple M3
    Memory: 88.48 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.nvm/versions/node/v22.11.0/bin/node
    npm: 10.9.0 - ~/.nvm/versions/node/v22.11.0/bin/npm
    pnpm: 9.12.3 - ~/.nvm/versions/node/v22.11.0/bin/pnpm

It might be worth to create a step by step setup guide on the contributing page of the documentation site with the list of the commands to setup all dependencies, build and run tests to check that everything in the project is working properly?
Since you have told me you are working on the server implementation when we resolve these issues I can take care of it.

Thanks for sharing.

Did you run pnpm install inside the apps/documentation folder (optionally pnpm install --ignore-workspace)? This might be the issue, since the documentation doesn't use the workspace dependencies.
That's interesting. I'll take a look and, I'll let you know.
Agree on extending the contributing page!

Note: I'm working on the server side but that doesn't impact the typescript build. The server implementation is mostly made using Rust.

This should fix the pnpm dev loop. Could you please check it on you end?

With the resolution of #92 I should have everything I need to write the setup guide in the contributing page.
If you wish you can assign this issue to me and I'll link it to the PR with the contribution page update (and I won't forget about it).
I'll try to make it and #84 in the upcoming days.
Thanks again for the quick turnaround.

That's great! Done.
Thanks for the help! Really appreciated!

Something that might be useful to mention in the contribution page:
In my setup, I put the following alias in my .bashrc config:
alias t="/path-to-folder/tuono/target/debug/tuono"

In this way, it is easier testing the Tuono's CLI outside the project folder.


Konga not able to connect to kong admin API in kind kubernetes cluster

Hi,
I have installed kong using kind in my windows. Deployment some application to check kong gateway and everything looks fine.
I tried to integrate konga in my local kubernetes cluster and I faced issues while establishing admin api connection from konga.
Kong admin API has been exposed through 8001 and 8444 port and I am able to access it from my browser/postman.
       - name: KONG_ADMIN_LISTEN           value: <IP_ADDRESS>:8001, <IP_ADDRESS>:8444 ssl
NAME                                READY   STATUS      RESTARTS   AGE
pod/ingress-kong-7d8888d845-gcbcw   2/2     Running     2          15m
pod/kong-migrations-22vm5           0/1     Completed   0          15m
pod/konga-7ccb4dfb8f-2lrqp          1/1     Running     0          15m
pod/postgres-0                      1/1     Running     0          15m
NAME                                             TYPE                   CLUSTER-IP      EXTERNAL-IP    PORT(S)                      AGE
service/kong-proxy                         LoadBalancer   <IP_ADDRESS>    <IP_ADDRESS>   80:30311/TCP,443:31846/TCP   15m
service/kong-validation-webhook  ClusterIP          <IP_ADDRESS>            443/TCP                      15m
service/konga-svc                           ClusterIP          <IP_ADDRESS>            443/TCP                      15m
service/postgres                              ClusterIP          <IP_ADDRESS>             5432/TCP                     15m
I tried to connect using below IP:port

<IP_ADDRESS>:8444 (ssl)
<IP_ADDRESS>:8001
kong-proxy.svc:8444 (ssl)
kong-proxy.svc:8001
localhost:8444
localhost:8001

I got ECONNREFUSED kong-proxy.svc and localhost whereas TIMEDOUT for external ip exposed through metal-lb.
Any ideas what might be happening?
Regards,
Razak

Closing this issue. Exposed admin ports based on below documents.
https://github.com/Kong/kubernetes-ingress-controller/issues/59
Thanks


feat(exporter-collector): implement concurrencyLimit option

This adds an option to the collector exporters concurrencyLimit.  If this is set and
the number of export operations is equal to the limit, additional export operations
will fail immediately.
This should be set in combination with the batch span processor be set such that the
concurrency limit would not be reached under "normal" circumstances - only if there
is an issue would spans start to be dropped.
This helps us cap the amount of memory & sockets used by the exporter if it is not
able to keep up with the data it is being provided.
This could happen if the local network (e.g. in a browser) or the remote collector
are too slow to handle all the activity.
If we do not have this cap, and the exporter cannot keep up, resources such as
memory and network sockets can be consumed without limit, causing crashes and
other undesirable outcomes far worse than losing some telemetry data.
This also updates the examples to use BatchSpanProcessor as I couldn't really
think of any reason why you would want to use SimpleSpanProcessor in combination
with the collector exporter.
Fixes https://github.com/open-telemetry/opentelemetry-js/issues/1707

Note: I considered setting some non-infinite default value for concurrentLimit but left it as it is now to avoid changing the behavior of the library.

I don't know why it thinks the changes are not covered by the unit tests, they seem to be covered to my eye.

@dobesv pls do not force push after 1st review is done, it is impossible to see changes then

@obecny Thanks for the review.  I have pushed changes that I hope addressed your comments.  Let me know if there's anything more I can do to help.

@obecny Ah sorry about the force push, it's a habit from other places that want a single commit.

We squash it when we merge anyways. No need to worry about it during the PR process.