Wrong type is accepted

VSCode Version: 1.9.1
OS Version: Windows 7 Enterprise

Steps to Reproduce:

By creating a service, then try to send a post method i.e. :
http.post('/the_url', parameters, options)
I set wrong options parameter like this:
const headers = new Headers();
headers.append('Content-Type', 'application/x-www-form-urlencoded');
http.post('the_url', parameters, headers) instead of sending new RequestOptions({ headers: headers }) there.

The post method when uses just headers as option does not work and it does not complain about wrong type and this is really hard to detect because there is no errors or warning at compilation time or runtime. I guess the IDE must show a warning otherwise the goal of why it was created (script typed) stop making sense I guess. It is really helpful to have that kind of support at compilation time.
When I replaced headers by RequestOptions({ headers: headers }) it worked properly.
It would be great if could consider it.
Thanks in advance,
Luis.

Are you working in JavaScript or TypeScript? Also, can you please provide a complete code example that demonstrates the problem

Closing as we need more info to investigate this.
@luisbirchenz Please provide a complete code example that shows this problem so that we can investigate this


Input inside Dialog doesn't drop focus as expected

Current Behavior
Pressing enter-key on a Input inside a Dialog will select all the text content inside the Input.
Expected Behavior
Pressing enter should drop the focus of the Input.
Tamagui Version
1.89.11

Platform (Web, iOS, Android)
Web

Reproduction
https://codesandbox.io/p/sandbox/long-butterfly-2zxj54?file=%2Fpackages%2Fapp%2Ffeatures%2Fhome%2Fscreen.tsx%3A37%2C32

System Info
No response

I don't think that is an expected behaviour!
for changing focus you can use Tab or you can implement your own logic by using onKeyDown prop on Input!

If you look in the example you can see that it works exactly as I mentioned outside of the Dialog, but when the input is inside the dialog, if you either press enter or use blur() on the ref, it highlights the text inside the input instead of dropping the focus.

ah sorry maybe I didn't understand the problem correctly here


renv R package

Hi renv devs! Is this the same as the renv from https://github.com/rstudio/renv ?

👋 @ekernf01 No this predates rsutio/renv.  We developed this in our spare time, and at the hackseq2018/2019 competition.  It works similar to python's virtual environments.

The most up to date branch includes windows support:
https://github.com/datasnakes/renv/tree/windows

You can also check out the renv cli for installing R.
https://github.com/datasnakes/rinse/tree/windows


Add trigger validation example

…my favourite code example too. It's a nice memorable one to have in multiple places in the documentation.

I like this example too. I ripped it off directly from @msullivan. 😁


Use configured protocol for API requests

@mdeuser commented on Tue Oct 17 2017
See Chttps://github.com/apache/incubator-openwhisk-cli/blob/master/commands/api.go#L916
Instead of hardcoding the protocol to https use the protocol configured in the apihost

@jsanda commented on Fri Oct 27 2017
I submitted PR 2909 for this.

I just got bit by this today when trying to use wsk api create with a .wskprops that was "misconfigured" to have APIHOST=https://MY_HOST instead of APIHOST=MY_HOST.  The symptom was that invoking the resulting APIs gave a 502 (bad gateway) because the created actions were given the url https://https://MY_HOST/


Manufacturing client does not work in Fedora IoT Simplified Provisioner 40.

Describe the bug
Manufacturing client does not work in Fedora IoT Simplified Provisioner 40
To Reproduce

Boot the simplified provisioner and enter the corresponding FDO manufacturing cmdline arguments also add coreos.inst.skip_reboot to skip the poweroff once the installation has finished.
Once the image has been installed enter the emergency shell and check the status of the manufacturing client

Expected behavior
The manufacturing client started the DIUN process.
Screenshots

OS version:
Fedora 40
Additional context
It looks like the systemd generator is unable to write to /etc

Has that fix landed?

@nullr0ute I believe we'll still need to do another release and package it for Fedora/CentOS/RHEL

For ref the upstream merge for FDO was actually https://github.com/fdo-rs/fido-device-onboard-rs/pull/677


Idaho Tech Council Events iCal source states UTC zone, but then states incorrect times given UTC zone

Relevant snips from "Idaho Tech Council Events" feed (currently http://www.idahotechcouncil.org/our-events/?ical=1&tribe_display=list):
BEGIN:VTIMEZONE
TZID:"UTC"
BEGIN:STANDARD
TZOFFSETFROM:+0000
TZOFFSETTO:+0000
TZNAME:UTC
DTSTART:20190101T000000
END:STANDARD
END:VTIMEZONE
DTSTART;TZID="UTC":20190919T083000
The problem with this is the event is not at 8:30AM UTC. It's at 8:30AM Mountain. The feed is not specifying times correctly. I suspect the WP-site/WP-calendar-plugin is set to UTC but the site rendering they're using isn't including zone, so they don't notice it's wrong. (If) anyone is using the Google Caldendar or iCal export links on their site, though, they're getting an event on calendar 6-8 hours back from when it should be. That same issue causes gemstate.io to also show these events 6-8 hours back from when they actually start, develop.idaho 2019 being one example as of 9/17/2019.
This issue is to track resolution. I've messaged ITC a couple different ways over the past few days but I have not got a responsive contact there.
There isn't a great procedural software solution at gemstate.io because ITC does events across Idaho. Aside from getting into the details of the location/address of the event, gemstate.io doesn't really know what zone to use for each of these events. The "locality" of this group is "Idaho".

Difficult to tell if this is still an issue for ITC, since as of Oct 13 2020 this URL lists no events. The URL now appears to be http://www.idahotechcouncil.org/events/?ical=1&tribe_display=list, and events listed there have TZID:America/Boise which is corrected.

I'll update the URL and we'll see how things go going forward.


Silently fails if some training or validate examples are too large

In my experiments 32000 characters are too large while 2000 is ok.
An API probably should fail immediately at least warn user if too large strings are used in samples.

Thanks for the bug report.
We have improved our learning process, now there is no limit on the length of the input data and on the length of the target.
So you don't have to worry about it.
And I'm closing this issue.


Doesn't work unless user interacts with the app, throws a LocaleDataException

Even with the most simple app, or the example app. I´m using Flutter 2.0.6 and calendar_timeline 1.0.0-null-safety.0.

Thanks @dvpuchades for reporting this issue. We will try to solve it as soon as possible, although we are also open to PR to collaborate with this package.


this command not work: php artisan lrd:generate

Describe the bug
when run this command: php artisan lrd:generate, see error: There are no commands defined in the "lrd" namespace.
My Versions:

Laravel Version: 10
PHP Version: 8.1
Laravel Request Docs Version: 2

please help me how generate static html for my api docs


IORef this binding problems solved

I made all attributes readonly and solved a problem that occurs when you try to pipe the functions of an IORef instance. The problem is that the this context gets lost when using the methods directly.
const ref = new IORef('hello')

pipe('world', ref.write)() // This would throw: Uncaught TypeError: Cannot set property 'value' of undefined

What do you mean with remove? There are still there with the same signature just written in another way?

@mlegenhausen They are moved from the prototype to the instance. ES6/TS classes execute parent constructors while extending so that these new class properties get available on child instance. But technically it's a breaking change because the methods are missing on the prototype: IORef.prorotype.write is not available anymore.

Ok thats correct. I will change to the bind solution. But just for curiosity are you using IORef by extending it or modifying the prototype in any way?

@mlegenhausen Personally no. But who knows what's happening out there?
Maybe we could add a test with pipe to avoid regressions.

Done


respond_to? dynamic field writer returning false

Both accessors work but respond_to? returns false for writer. Here is an example:
class Person
  include Mongoid::Document
end

me = Person.new
me.respond_to?(:gender)   # => false
me.respond_to?(:gender=)  # => false
me[:gender] = "Male"
me.respond_to?(:gender)   # => true
me.respond_to?(:gender=)  # => false # why?
me.gender = "Unspecified" # works

Thanks for reporting this. I've confirmed it in 2.4.0 .

This bug was present in 2.3.4 too.


OpenAPV - defining 6 month milestones

Please share any additional details on this topic
As discussed during the previous TAC meeting, there was a request to have specific 6-month guidelines for the OpenAPV project.
Detail what actions or feedback you would like from the TAC
Defining who will put this together
How much time do you need for this topic?
None

Erik and Sam are working on this - will share the doc shortly


feat: implement keccak builtin

Description
Builtins constrain certain memory cells in the area of memory shared between the CPU and the builtins.
For inspiration see Rust and python implementations.

Will work on that!


Retain the queue between restarts.

I would like the bot to retain whats in the queue between the newly introduced restarts.

Implemented.


nginx: command not found after updating to v1.6.2

From https://t.me/raspiblitz/45313

getting this when checking electrs from the menu, tried uninstall, re-install already
$ sudo nginx -t
sudo: nginx: command not found
perhaps nginx wasn't installed during the update process

Running:
sudo apt install nginx
and
restart
fixed the issue.

Maybe check for important services being uninstalled with the background.sh script and then installing them again.

this has been probably an uncomplete recovery, nginx  is not uninstalled during any setup step.
Also no further reports of this so closing.


Scrollspy directive

Hi!
In materialize css there is a functionallity called scrollspy. It's pretty. Are there any way to implement it for angular 2?
Link: http://materializecss.com/scrollspy.html

https://github.com/InfomediaLtd/angular2-materialize/issues/344

@rubyboy a new about this issue ?


[Popover] event handlers issue (mouseEnter and mouseLeave)

Problem description
I'm trying implement popover which shows on mouseEnter and hides on mouseLeave - using popover example template from http://www.material-ui.com/#/components/popover
The issue occurs onMouseEnter event, when I hover over then Button both mouseEnter and mouseLeave handlers are being called in sequence. That prevents Popover template to show up.
mouseEnter event -> mouseEnter handler + mouseLeave handler
When I move mouse off the button then just mouseLeave handler is called - as expected.
mouseLeave event -> mouseLeave handler
Link to minimal working code that reproduces the issue
Reproducable link https://codesandbox.io/s/66nj8qRBR
Versions

Material-UI: 0.18.7
React: 15.15.3
Browser: Chrome

This behavior is expected. The popover is showing a backdrop over the page. There is an option to disable that behavior.

@oliviertassinari can you confirm that this is actually the expected behavior. The @imornar said this, which doesn't make sense to me as an expected behavior.

mouseEnter event -> mouseEnter handler + mouseLeave handler

I'm seeing this as well. I would have expected the mouseEnter event to only call the mouseEnter handler, not the leave handler also.

@oliviertassinari how to we disable the popover backdrop over the page?

@resson-ntranquilla We will work on that in the future: #11243.

Still its a problem

@Iflserg
there is workaround to fix it:
<Popover
style={{ pointerEvents: 'none'}}
...

Thank You @konradwww.


Collapse code on small screens

Hi!
This is an awesome idea and is working really well using my mouse on a laptop.
However, I really want to try this out on my mobile devices with pen support to see how it feels.
If I try loading it on a phone the view gets messed up because it's trying to fit the code along side the drawing area.
It'd be nice if the code view could be toggled so that you could have more space for writing, and to have it auto-hide on small screens.
Thanks for making this! I think it'd be a great way to teach artistically-minded people how to code. :D

Thank you for your suggestion!
I'm also thinking to let the app work on mobile devices -- I came to wonder it would be great if I could use it with iPad Pro.
I have to focus on my paid works so far, yet I'd really like to support iOS.
Thanks for the feedback!

Yeah I get whatcha mean. This seems like it'd be ideal for an iPad pro and the such.
I might have some time to play around with the source eventually and see if I can get it to work. 😁


add Firebase backend

WIP

[x] File named ./src/backends/<backend_type>.ts
[x] Backend source includes comments with functional example
[x] Tests specific to backend type
[x] Config parser wired up + tested src/config/backends.ts

deploy a single-page web app, a mobile app landing page, or a progressive web app without all the hassle.

More info: https://firebase.google.com/products/hosting/
My understanding is that I set it up for basic hosting, but with the firebaseapp.com domain, I'm not quite sure anymore... Looking into it.. not super familiar with modern Firebase either.


FIxed order of execution

Adjust the execution sequence of the CWL workflows in the folder to follow the alphabetical order of their file names.

Repo is in the early stages of development and the changes are minor, therefore a code review is not obligatory.


Add missing unit test for #40165

Signed-off-by: Jacek Ewertowski<EMAIL_ADDRESS>Please provide a description of this PR:
This is a follow-up to the PR #40165 and a comment about tests.
To make sure that this test verifies implementation from #40165, I reverted that commit and then got the error below.
traffic.go:261: Full Diff:   simulation.Result{
          	Error:              nil,
        - 	ListenerMatched:    "<IP_ADDRESS>_443",
        + 	ListenerMatched:    "virtualOutbound",
          	FilterChainMatched: "virtualOutbound-catchall-tcp",
          	RouteMatched:       "",
          	RouteConfigMatched: "",
          	VirtualHostMatched: "",
        - 	ClusterMatched:     "outbound|443||istio.io",
        + 	ClusterMatched:     "PassthroughCluster",
          	StrictMatch:        false,
          	Skip:               "",
          	... // 1 ignored field
          }

thanks!

In response to a cherrypick label: new pull request created: #41372

In response to a cherrypick label: new pull request created: #41373

In response to a cherrypick label: new pull request created: #41374


Refactor for Beamer

The preamble_base.tex should be split into an article_base.tex containing all the stuff, which is only used in an article. With this as much as possible can be reused for a beamer_base.tex preamble.

#19 Will be a first major step in this direction.

Almost all but the geometry package can just be reused as it is now. All that is needed is to move the paper relevant things into a p0 and create a p0 and p3 for beamer


Fixed ssm activation error #205

what

Added depends_on = [aws_elastic_beanstalk_environment.default] to aws_ssm_activation.ec2

why

As stated in this comment on the issue #205 it does actually solve the problem.

references

Closes #205

/test all

/rebuild-readme

/test readme

/test all


Content before Sticky component inside StickyContainer ignored

Hi guys
I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request

If you're reporting a bug, please provide a minimal demonstration of the problem
https://codesandbox.io/s/xvnxy4lmjq
What is the current behavior?
The red div becomes sticky too early.
What is the expected or desired behavior?
The red div should become sticky only when we scroll to its top
What is your environment?

Version: macOS High Sierra
Browser: Chrome 67

Hi @shunxing can you please follow the issue template? It asks for a lot of information that I can't really help you without.

@vcarl Hi ! done !

TY for the excellent bug report! I'm flying today, I'll try to poke this while I'm in the air.

I should probably capture some of my findings. I did spend a bit of time on this, but this is the first time I've debugged the core of the logic for the library. This seems like a pretty strong assumption of the library, it's going to take a good bit longer before I can find something that I'm positive won't break compatibility.


KIP-978: Allow dynamic reloading of certificates with different DN / SANs

This PR implements KIP-978: Allow dynamic reloading of certificates with different DN / SANs. It adds two new options ssl.allow.dn.changes and ssl.allow.san.changes that can be used to enable dynamic reloading of certificates even if their DN / SANs change. They both default to false to maintain the current behavior by default.

@viktorsomogyi @omkreddy You also voted on the KIP. Do you want to take a look?

Thanks for the review comments @viktorsomogyi. They should be now fixed.

@viktorsomogyi Do you have any further comments?

There were failing unit tests but rerunning them locally from the PR they all passed, therefore they're likely unrelated flakies. Merging the PR, thanks @scholzj for the contribution!

Thanks a lot for your help with this @mimaison and @viktorsomogyi


[Bug]: Mentions keyboard controls not working

What happened?
When using the mentions & tags when I begin writing and get a suggestion hitting "Enter" should select the first suggestion on the list.
This is not happening, instead the editor it's just printing a new line.
Version
v12.2.2
What browsers are you seeing the problem on?
No response
Link to reproduce
https://stackblitz.com/edit/ngx-editor-mentions
Potential workaround
A workaround I found was not including the plugin in the constructor, but adding it afterwards as the first plugin. Which is the same the author of the plugin does in his demo. https://github.com/joelewis/prosemirror-mentions/tree/master#usage
I modified the original stackblitz
https://stackblitz.com/edit/ngx-editor-mentions-tkxusj
Willing to submit a PR?
Yes

Sure. Yeah. Prosemirror bindings happens in the order which it got registered. What would be the fix for this?

I've run into this issue recently, the issue is with the plugin orders in Editor.ts
And specifically with the KeyboardShortcut plugin, as it inserts a new line and returns true before the Mention plugin can run.

flipping the order the default and passed in plugins are added to the list resolves the issue.

Yeah. Since the order defines how the bindings are registered, We could do that.
PR welcome.
And note, this is a breaking change. though it may not break much. Still the nature of changes calls for a new major.

Closing this as the issue is quite old. PR's welcome.
Thank you.


App Stuck on Home Page Loading Spinner Forever on Restart

Sometimes when we re-launch the app it seems to hang there forever. Unclear.

Duped in https://github.com/stevekuznetsov/avalanche-forecast/issues/265


Question: What is the idea behind the encapsulation principles when it comes to declaredComponents?

Hello,
I am not sure where I should go for intershop-pwa related questions so I'm sorry in advance if this is the wrong place. But I have one question regarding encapsulation principles.
There are exportedComponents and declaredComponents in ShellModule/SharedModule (obvious).
I'm trying to understand what rule/idea is behind those. Would be nice if all of the declared components would be exported since they can be accessed from the outside.
For example, if you wish to have access to them from a completely customized ShellModule which wants to use some of the declared components - with the current setup it will not work.
What are the chances to exposing/exporting all declared components? I don't see any reason why they're private since it is just a limitation when it comes to customization.
Best regards,
Michal
AB#88083

Hello @kepek,
we export only the components that are used by other modules or components, because this can help to reduce the size of the application and improve performance.
Exporting all components in the pwa could lead to performance issues and that's why we are not going to do this.
If you have proposals for the export of some single specific components we can discuss it in our team and export them nevertheless.
And yes, feel free to use this place here to ask question. :-)

@SGrueber, an example use case is when you want to have full control of your app. We have a customer who forces us to do a huge amount of customizations, but a the same time we would love to use a lot of OOTB components that you've created.
We have a custom shell module that brings some new things but a the same time client uses cms includes which are handled via lazy components ( LazyContentIncludeComponent,  LazyMiniBasketContentComponent, LazySearchBoxComponent) and they're tightly coupled with ShellModule and can't be used outside of it.

Hi @kepek,
after further discussion of your use case we decided not to export the lazy ShellModule components so they can be used elsewhere.
If you need for example the LazyContentIncludeComponent anywhere else than in the ShellModule you should import the SharedModule and use the ContentIncludeComponent.
If you need the LazyContentIncludeComponent in a CustomShellModule then our intended way would be to completely override the ShellModule with the standard override mechanism and import everything you need in that overridden custom ShellModule. It is not our intention to import the ShellModule in any other module to use its components.


About the newsletter section

Describe the bug
There is "send" written on the option for user to submit their email.
Expected behavior
It should be either "submit" or "subscribe" in place of "send" as it is the right practice to use them.
Screenshots (Mandatory)

Additional Context (Mandatory )
I will like to work on this issue so please assign this issue to me under GSSOC'24.
Are you contributing under any open-source program ?
GSSOC'24

"Send" option is written instead of subscribe.
I will like to work on this issue so please assign this issue to me under GSSOC'24.@apu52

Hi ,
This is a good issue, please start working on this.
Regards
Project Mentor (GSSoC' 24)


concurrency model question

Hello. I'm using the Ratchet I/O demo used on this page: http://socketo.me/docs/hello-world
I am using the full example that includes:
$server = IoServer::factory(
        new HttpServer(
            new WsServer(
                new Chat()
            )
        ),
        8080
    );

My question is: is this setup single threaded? I'd like for my class to maintain the same member variable as state and the sole reason for using Ratchet is that I do not have multiple requests being processed at the same time.
To elaborate further, all I'm doing is storing an array of integers. A web socket client can reserve an int. Once it's reserved, no other client can reserve that int until it's released.

Yes, if you only start one instance of it, it will be single threaded. When you need to scale up you could Redis or Memcached as state store.

Yes, if you only start one instance of it, it will be single threaded. When you need to scale up you could Redis or Memcached as state store.

what a prompt response! thank you so much! :)


Issue a message when a package is not need anymore by any other installed package.

Version
pacaur -v
pacaur 4.6.10

Description
Sometimes, a package foo has dependency bar removed. Then, it can happens that no other installed packaged depends on bar. At this point, bar is a locally orphaned package, returned by e.g. pacaur -Qdtq. At this point, I’d like to have pacaur issue me a message like “Dependency bar isn’t required anymore by any installed package” or something like that.
Bonus point: do a similar thing for packages that moves from being depended on to just optdepended on.
Output
pacaur -Syu
<upgrading foo to x.y.z>
Dependency `bar` isn’t required anymore by any installed package

Thanks!

Are you sure that isn't already implemented? There is a check done before the update/install here, and another one done at the end here. If both results differ, then it means new orphaned dependencies are detected and a warning is issued (but only once).
I might indeed try to do something similar for optdepends.

Well it didn’t worked apparently. libxfont wasn’t detected as such some days ago (I could have missed it though), and I can reproduce it on removing packages also, but I suppose this one is expected (I know about -Rs): I installed a package with only one dependency not already present on my system, then removed the package, no warning.

Pacaur only warns about new AUR orphan after updating/installing a package. It doesn't handle binary packages as it merely passes the job to pacman. And I am not sure it should do it for binary package either.

Why so? Or do you mean it should be pacman job?

Yes, or the user job. Checking pacman -Qdt should be part of regular user maintenance. Pacaur only aims at extending pacman to the AUR, not adding feature to pacman itself.

New optional package check implemented in de94669623039068900458fd0117230c25f3b6bc.

Yes, and I do run this command quite often, however I keep a certain number of packages appearing in this list for several reasons so that I need to look for new apparitions, and I see no point in having to make the diff myself if pac{man,aur} can do it for me. ;)
However I understand your point, and will eventually try to get this feature added in pacman, but as long as pacaur is concerned I just thank you for having implemented the optdep check. :) I’m just adding a comment on the commit regarding the wording.


Add ability to generate a label for first time PR

Would be cool if one could also have the option of tagging a PR w/a config defined label

I think that is a good idea,


API maps all analysis functions correctly

Default function parameter values get respected now, when executing an API call. If a parameter (e.g. remove_stopwords) is not present in the query, the default value is used instead of None previously.

everything is looking good


MTDSA-19629: Create Amend ITSA Status Connector and Service

possible to update the pesky sbt-auto-build dependency?


Submit stable Voyager chart

cc: @sadlil @TamalSaha

Hi @saumanbiswas, thanks for your contribution! Can you provide some background on what Voyager is and why it might be relevant in the charts repo?

@saumanbiswas your Chart isn't structured correctly. Chart.yaml etc. should live under stable/voyager, not stable/voyager/voyager. Can you just move them over?

Marking as stale. @saumanbiswas please update in the next week if you'd like this to be merged.

@k8s-bot ok to test

@seanknox FWIK, voyager is an ingress controller, much like the nginx ingress controller.

@unguiculus , I have addressed your comments.


Integrations

I was searching for random stuff and came across this taskwarrior, timewarrior & gnome-pomodoro integration post
Taskwarrior uses hooks, is there something similar with unfog?
I can think of a way to just make a custom script or something that acts as an intermediary to unfog, but it would really be nice if we could have some sort of integration, maybe? :)
What do you think?

I think it is a very good idea. I will think about how to implement this. Thanks!


screenkey: 0.9 -> 1.2

Motivation for this change
Fix https://github.com/NixOS/nixpkgs/issues/89300 , cc @andys8 .
Things done

Use Python 3.
Switch to gobject-introspection and other more maintained libraries
(vs PyGTK).
Use fetchFromGitLab.
Replace the non absolute paths fix in xlib.py with
substituteInPlace.

cc @rasendubi .

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Forgot to hit the "Comment" button yesterday when writing my comments to your review @jtojnar.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/301


Feat: Enhanced Tour

Describe your changes :

I worked on the enhancement of Tour feature, with appropriate and verified messaged to guide through

Type of change :

[x] Improvement

Frontend Preview (Screenshots) :

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
@shahsank3t @Sachin-chaurasiya

This is amazing...


When will pyleus support storm 0.10.0

Hi:
is there a schedule to support storm 0.10?In my company,we are using storm 0.10,while it seems that  pyleus 0.3.0 doesn't support it.
Thanks

Hi @dearli,
There is an open PR (#170) for this.


Dataset preparation

Thank you for your great work!
There are many subsets of scene flow and KITTI dataset. Which should I download and how should I organize them? There will be an error even if I set dataset and datapath:
FileNotFoundError: [Errno 2] No such file or directory: '/home/xgw/data/KITTI_2012/frames_finalpass/TRAIN/C/0297/left/0006.png'

Because in kitti_dataset_1215.py:
def __init__(self, datapath, list_filename, training):
        self.datapath_15 = '/home/xgw/data/KITTI_2015/'
        self.datapath_12 = '/home/xgw/data/KITTI_2012/'
        self.left_filenames, self.right_filenames, self.disp_filenames = self.load_path(list_filename)
        self.training = training
        if self.training:
            assert self.disp_filenames is not None

Could you please specify the steps about how to organize data to meet the requirement? Thank you for your time!

see filenames/sceneflow_train.txt

I have seen it, thank you. There are many subsets of scene flow and KITTI datasets and the structure of these files differ from the path in your txt. Could you please specify the set that we download and the expected file structure? Thank you for your time!

If you use the scene flow datasets, refer to the txt file under the filenames folder that contains the path to the dataset, as well as the KITTI dataset.

I have seen it, thank you. There are many subsets of scene flow and KITTI datasets and the structure of these files differ from the path in your txt. Could you please specify the set that we download and the expected file structure? Thank you for your time!

so for example filenames/sceneflow_test.txt, in this the sceneflow_test,txt file it is referring to '/data/sceneflow/frames_finalpass/TEST/C/0134/left/0008.png'. my question is which dataset of sceneflow (https://lmb.informatik.uni-freiburg.de/resources/datasets/SceneFlowDatasets.en.html) we should download since there are 3 types flyingthingsd3, driving and monkaa? and i downloaded the driving subdataset, the path is not TEST/C/0134/....png but something like this /frames_finalpass/15mm_focallength/scene_backwards/fast/, so where can we find these images as mentioned in sceneflow_test.txt ? Thanks.

@YuhsiHu Hope this is not too late. Download the flyingthings3d subdataset of scene flow dataset, if you are using sceneflow_test.txt as provided in the code. To be exact, you have to separately download 2 files:-

flyingthings3d__frames_finalpass.tar and
its disparity flyingthings3d__disparity.tar.bz2.


Compilation Error in a commented sentence.

I get this error:
Compilation Error
Error: Undefined variable.
   ╷
89 │   * -- The [#{$i}] part is the syntax to combine a variable (i) with text to make a string.--.
   │               ^^
   ╵

and should be ok, but the fact is that this line of code is commented

You're using the wrong type of comment - please see https://sass-lang.com/documentation/syntax/comments


[New] nvm ls for nightly builds

Without this patch, how the nvm ls looks like (the display format is not correct):

With this patch, now we have correct nvm ls, and the nightly builds with have their own color:

cc #1053 #1507

Thanks, but this is not how I have already begun to implement this feature.

@ljharb so how should it be? Can we just make it work before the new implementation?

No, if you look at the road map, RC support needs to come before nightly support (since RCs are way way more important for people to use than nightlies), and I've already mostly implemented that.
The only people who should be installing nightlies are node core developers, and they don't need nvm to be easy to use for that use case. It's not urgent.

So you are working on both RC and nightly support?

Yes, they will follow a similar implementation pattern.

okay ...

@ljharb is it possible to reveal the progress as transparency so that we can prevent to work on the same thing? IMO RC support vs nightly needs only few tweaks.

There's a number of bugs in the issues list, some filed by yourself, that should all be worked on before trying to implement a new feature - no matter how small you believe the changes will be.

I think it's ... not the same thing we are talking about.

I'm suggesting that you not work on new features until we're out of bugs, if you want to be able to work on things, without asking first, without fear of overlapping with what I'm working on.

I can understand what do you mean but this didn't explain the possibility if we can have transparency of the new features, no matter what the decision is, it's fine to respect it.

https://github.com/creationix/nvm/blob/master/ROADMAP.md has been there since September.

Oh yes, I saw the issues, I mean the code level progress in branches or PRs, is that possible?
The reality to me about the other issues is that I'm still working on them, I didn't drop them, and to be honest, I also really hope you can help solve the tests running locally issue first because testing on Travis CI is not that efficient and sometimes wasting resources, even makes it hard to debug sometimes, and that's the part very hard for me, which also slows down my progress on the other PRs, IMO you may be the best one to work on the testing issue.


Implement Implicit casting between Date and Text

Is your feature request related to a problem? Please describe.
Add the ability to compare between Date type and Text type with date format
Describe the solution you'd like
Implicit convert Text type if it match date format to date object in the parse
Related issue:
Issue #41

Time, Date and DateTime are Implemented now


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!
Sent from my iPhone

On Feb 21, 2021, at 9:35 AM, google-cla[bot]<EMAIL_ADDRESS>wrote:
@googlebot I signed it!


Each Namespace Holds a Connection

First, we love this package and the opportunities that it opens up for us. Great job :).
We have an app that started having database connection problems after adding socket.io. After doing some digging it appears that the issue is that the postgres adapter holds a connection for each namespace. That would be fine for many apps but our design is based on custom namespaces. It appears that every namespace that is accessed by some user will then hold a connection indefinitely. Is that the expected behavior? Are there any patterns that could free up these connections when the last user disconnects from the namespace?

It appears that every namespace that is accessed by some user will then hold a connection indefinitely.

Yes, that's indeed the current behavior, but I think we could change it.
As a temporary workaround, you can close the connection when the last user disconnects:
const namespace = io.of("/the-namespace");

namespace.on("connection", (socket) => {
  socket.on("disconnect", () => {
    const isLast = namespace.sockets.size === 0;
    if (isLast) {
      namespace.adapter.close();
    }
  });
});

Thanks makes a lot of sense. In the meantime, we have moved from Namespaces to Rooms and that is working fine for us.

This should be fixed in version 0.3.0, implemented in https://github.com/socketio/socket.io-postgres-adapter/commit/651e28169185d91c7a1a86152d21aa265d5500f2.


Binding an interface to an existing binding that contains arguments fails.

If you try to bind an interface, lets say IInitializable it will fail, if the previous binding contains arguments.
For example:
Container.Bind<ICache>().WithId(CacheType.Memory).To<MemoryCache>().AsSingle()
    .WithArguments("MY KEY");

Container.Bind<ICache>().WithId(CacheType.Disk).To<DiskCache>().AsSingle()
    .WithArguments("MY KEY");

Container.Bind<IInitializable>().To<DiskCache>().AsSingle();

Both MemoryCache and DiskCache have constructors with a single String argument. Aditionally, DiskCache implements IInitializable.
The last bind here will fail with ZenjectException: Assert hit! Invalid use of binding 'FromNew'.  Ambiguous set of creation properties found (argument length mismatch).
This can be fixed by adding .WithArguments("MY KEY") to the last line. I'm not sure if this is a bug, or if I'm doing something wrong, but adding arguments to both binds definitely seems incorrect.
Any ideas?

When you use AsSingle, there needs to be on definitive way to construct the object.  So for example, take the following code:
Container.Bind<IBar>().To<Foo>().FromInstance(foo1).AsSingle()
Container.Bind<IFoo>().To<Foo>().FromInstance(foo2).AsSingle()

When you use AsSingle, you are saying that there should be one definitive instance of Foo in the container.  But you've described two different ways of creating Foo.  So Zenject throws an error in this case since it doesn't know which one to use.  Your example with WithArguments is similar - the two bindings for DiskCache have different ways of creating the singleton instance.
Here's a workaround though:
Container.Bind<ICache>().WithId(CacheType.Disk).To<DiskCache>().AsSingle()
    .WithArguments("MY KEY");

Container.Bind<IInitializable>().To<DiskCache>().FromResolve(CacheType.Disk);

Or, if you weren't using IDs, you could do:
Container.Bind(typeof(ICache), typeof(IInitializable)).To<DiskCache>().AsSingle()
    .WithArguments("MY KEY");

Perfect! Thanks for the lightning fast response :)

Hmm, actually, that still doesn't work. The second Bind fails, since it tries to resolve DiskCache, which itself is not bound (but gets bound through ICache with an ID).
The error is: ZenjectException: Could not find required dependency with type 'DiskCache'
Binding it to ICache also isn't an option, since ICache itself does not inherit from IInitializable and it produces a compile time error. Likewise, doing Container.Bind(typeof(IInitializable)).To<ICache>().FromResolve(CacheType.Disk); wont work, and will produce a runtime / validation error.
Not sure where to go from here, any ideas?

Oh yeah good point, missed that issue.
This is the most elegant way I can think of right now:
            Container.Bind<ICache>().WithId(CacheType.Disk).To<DiskCache>().AsSingle()
            Container.Bind<IInitializable>().To<DiskCache>().AsSingle();
            Container.BindInstance("MY KEY").WhenInjectedInto<DiskCache>();

Here's another pattern I sometimes use for these cases.  This pattern is actually needed in zenject 6 since it is no longer supported to use AsSingle across bind statements like the previous workaround.
var diskCacheId = Guid.NewGuid();
Container.Bind<DiskCache>().WithId(diskCacheId).To<DiskCache>().AsSingle().WithArguments("asvasdfasdf");

Container.Bind<ICache>().WithId("foo").To<DiskCache>().FromResolve(diskCacheId);
Container.Bind<IInitializable>().To<DiskCache>().FromResolve(diskCacheId);

This worked, thanks to both of you for asking the question and answering.


Update Lithuania from Lithuanian Litas to Euro (since 2015-01-01)

I have rebased the PR so the commit is on the latest master.

You missed a unit test. It is not an important one, I'll fix it during the merge.

Thanks


Toggling docstring style linting in preferences doesn't work

Problem Description
Unchecking "enable docstring style linting" in settings doesn't seem to have any effect
What steps reproduce the problem?

Open spyder with docstring style linting enabled
Uncheck enable docstring style linting radio box
Click Apply and/or OK

What is the expected output? What do you see instead?
I expect the warning icons for docstrings to disappear. Instead they remain and opening the preference again shows the radio box still clicked. Can disable by closing spyder and manually changing pydocstyle = True to False in spyder.ini file.
Versions

Spyder version: 4.0.0b2
Python version: 3.7.0 64-bit
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: Darwin 18.6.0

Dependencies
pygments >=2.0     :  2.4.0 (OK)
qdarkstyle >=2.6.4 :  2.6.8 (OK)
sphinx >=0.6.6     :  2.0.1 (OK)
psutil >=0.3       :  5.6.2 (OK)
pyls >=0.19.0;<0.25:  0.24.0 (OK)
nbconvert >=4.0    :  5.5.0 (OK)
pandas >=0.13.1    :  0.24.2 (OK)
numpy >=1.7        :  1.16.4 (OK)
sympy >=0.7.3      :  1.4 (OK)
cython >=0.21      :  0.29.8 (OK)
qtconsole >=4.2.0  :  4.5.1 (OK)
IPython >=4.0      :  7.5.0 (OK)
matplotlib >=2.0.0 :  3.1.0 (OK)
pylint >=0.25      :  2.3.1 (OK)

It doesn't work immediately, but it does after a little while (2 or 3 secs). Could you confirm?

Nope, behaviour is completely consistent. Checking or unchecking the radio box in the docstring style tab of completion and linting settings does nothing. Behaviour doesn't change, and spyder.ini doesn't change.
Selecting "Show docstring style warnings" in the source menu toggles the behaviour and changes spyder.ini. As I said before, manually changing spyder.ini and restarting also works.
If I toggle the behaviour using the file or the menu, the state of the radio box in settings will change, but clicking the box in settings won't change anything.

Sorry I should be saying "preferences" window, not settings. but I think you know what I mean.

Do you have an external configuration file for pydocstyle?

nope. I've never used it till I turned it on in beta 2

Ok, thanks a lot for your patience. Final question: does this happen on Linux too or only on macOS?

I will test when I get back into the office next week.

Great, thanks!

Works fine on my Linux machine.
I'm testing using this command to check settings:
grep pydocstyle ~/.config/spyder-py3-dev/spyder.ini

On Linux, the initial output is
pydocstyle = False
pydocstyle/convention = numpy
pydocstyle/select =
pydocstyle/ignore =
pydocstyle/match = (?!test_).*\.py
pydocstyle/match_dir = [^\.].*

If I open the preferences window, click the radio box and hit apply, I now get
pydocstyle = True
pydocstyle/convention = numpy
pydocstyle/select =
pydocstyle/ignore =
pydocstyle/match = (?!test_).*\.py
pydocstyle/match_dir = [^\.].*

Uncheck and hit apply and it goes back to False.
On my mac, The pydocstyle = True/False value would change if I chose "show docstring style warnings" from the source menu, but not when clicking the box in preferences. So it's not a permissions error in the config file or anything like that.
I do note that on Linux, the spyder.ini is found at ~/.config/spyder-py3-dev/spyder.ini while on mac it's at ~/.spyder-py3-dev/spyder.ini so there is at least some difference in the handling of preferences between the versions.

Ok, thanks for the confirmation. I was asking about it because on Linux things are working fine for me.
@juanis2112, are you able to reproduce this problem on macOS?

I've managed to reproduce on two different macs now.

@ccordoba12 yes, I reproduced the problem in macOS.

Want to give it a go at fixing it @juanis2112 ?

I have no idea what could be causing this problem, but @steff456 has more experience with the PyLS and she also work in macOS.

@steff456, please notice Docstring linting is working from the Source menu. It's only when it's activated in Preferences that it fails.

@steff456 please see https://github.com/spyder-ide/spyder/blob/master/spyder/preferences/configdialog.py#L313
            if not API == 'pyside':
                checkbox.clicked.connect(lambda _foo, opt=option:
                                         self.has_been_modified(opt))
            else:
                checkbox.clicked.connect(lambda opt=option:
                                         self.has_been_modified(opt))

It seems that on PyQt 5.9 for OSX (need to check with 5.12 and pip) this distiction is no longer needed
If I change to
            if not API == 'pyside':
                checkbox.clicked.connect(lambda opt=option:
                                         self.has_been_modified(opt))
            else:
                checkbox.clicked.connect(lambda opt=option:
                                         self.has_been_modified(opt))

It works as expected. Maybe we now need to add another if to check if it is Darwin. I am not sure whye PyQt5 would work differently on this case.
Thoughts @ccordoba12 ?

I found that some of the checkboxes on the preferences were working fine, but there were more than the one reported in the issue that wasn't working as expected. For example, the checkbox for ´Python Interpreter -> Enable UMR´ is working fine on OSX.

Those checks can be safely removed, I think. I added them for several years ago for PyQt4, so I'm not surprised they are not working anymore for PyQt5.


"error: addwstr() returned ERR" when data frame view exceeds screen boundaries

The data frame printout should be limited to the size of the pane in tmux, if possible.

Addressed in Pull Request 11


[Windows] import tensorflow error messages are uninformative.

When a user runs import tensorflow, we attempt to dynamically load the DLL _pywrap_tensorflow.pyd. If this fails, the user gets an uninformative (perhaps downright misleading) message:
Traceback (most recent call last):
File "C:\...\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 18, in swig_import_helper
    fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)])
File "C:\...\lib\imp.py", line 296, in find_module
    raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named '_pywrap_tensorflow'

This error can happen for several reasons:

(Rare) The package has not been installed correctly, and the file _pywrap_tensorflow.pyd is not present in the expected location.
The package has been installed for an incompatible version of Python (e.g. installed on Python 3.6, but built for 3.5, as in #9167). I suspect this is because it fails to load python35.dll.
The library has been installed correctly, but one or more of its native dependencies is missing. Common examples include:

MSVCP140.dll (the Microsoft Visual C++ redistributable library). The compiled C++ code depends on this library being present, but it is not installed as standard, unless you use Anaconda. (See this Stack Overflow question, for example.)
CUDA libraries. The user's %PATH% may not include the directory that contains the CUDA DLLs.
cudnn64_5.dll. This is typically installed in a different directory from the CUDA libraries, and must be added to the user's %PATH% explicitly.

It would be helpful if we could provide more information about the cause of an ImportError, and in particular we would like to show the name of the missing DLL to aid the user in diagnosing the problem. It's less clear to me how we achieve this, since the error is reported by LoadLibrary() of our compiled code before we have the chance to execute anything.
A couple of thoughts spring to mind:

Can we use /DELAYLOAD during the build process so that (at least) we have the chance to probe the CUDA-related libraries before using them? Are there any performance consequences to doing this?
Alternatively, can we implement a sanity check in Python before we import _pywrap_tensorflow.pyd to ensure that the relevant files will be found?

/cc @guschmue @vit-stepanovs in case they have any smart ideas!

we could add a couple of checks that run during pip install and check cuda dlls, python dll ... that would let us print a good error message for the most common problems.

(As a temporary workaround...) I've created a script for diagnosing common TensorFlow on Windows installation issues. Please download the script from https://gist.github.com/mrry/ee5dbcfdd045fa48a27d56664411d41c and run python tensorflow_self_check.py. It will print suggestions for how to fix your installation.

hi @mrry,
how to solve it, if the error is

The package has not been installed correctly, and the file _pywrap_tensorflow.pyd is not present in the expected location.