Remove push trigger for non-precommit workflows

Part of the effort of reducing the concurrent Dataflow jobs in precommit stage to reasonable level
Found that several postcommit jobs have "Push" trigger, while most does not. This PR then removes all push trigger except for precommit workflows. It also removes issue_comment trigger for remaining loadtest/performance test. Also in current practice we barely monitor push triggers.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damccorm  @volatilemolotov


Errors on Blender 2.91

This is a continuation of https://github.com/allista/WakatimeBlender/issues/28.

[Wakatime] [ERROR] Error
[Wakatime] [ERROR] wakatime-core exited with status: 2
[Wakatime] [ERROR] wakatime-core output: Unknown option: -P

Replies:
comment by snick-m -

@jbmorris289 Seems to be a problem with running the core with -P option? That's what it looks like from the errors.

That’s what it looks like to me as well. If I remember correctly (it’s been a while - I ended up just running out of time), either that came with the install, or it was something I modified per these instructions, which means I probably installed the older version last. I’m not at my computer to look but will do when I get the chance.
comment by alanhamlett -

Let's move this issue to the new repo and also make sure you're installing blender-wakatime from that new repo and not this old one.

I’ll need to try again, but I believe this was also unsuccessful due to that or a similar error, with and without modifications to the scripts. Tried multiple times with the different versions while making sure to remove any remnants.
I’ll need to investigate further to see where I left off.

Okay, sorry for thee delay - I've been backed up with stuff.
So here's the one that was installed at the time of creating this comment. This was what was giving me the argument error.

It doesn't look like I modified any of the files, but I'm not sure.
I tried downloading this repo as a zip file and importing. Attempting to enable the plugin resulted in this error.

I also tried renaming to WakatimeBlender-2 (unknown origin of suggestion) with no success.


adds blue border to three dot on closing delete workspace context menu using ESC

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to workspace
click three dots to open delete menu
Press ESC to close the menu

Expected results:
should close the menu without any blue border
Actual results:
adds blue border to three dots
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.13
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/9f686c7b-1b00-4d6f-af00-5b2bf31245f6
https://github.com/Expensify/App/assets/43996225/eb6ebbc5-912b-4c26-ba67-9470ae49a0a6
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683802759431379
View all open jobs on GitHub

I am going OOO so re-assigning a new coach to oversee this

Proposal
Please re-state the problem that we are trying to solve in this issue.
On the web, if you click on three dot on closing delete workspace and then press Esc, the three dot button is highlighted with a blue border.
What is the root cause of that problem?
The default behavior when pressing Esc after open model delete workspace. In this case, when button ESC is pressed this Pressable gets focused and the blue outlines are shown by using the :focus-visible CSS styling.
  :focus-visible {
     outline: 0;
     box-shadow: inset 0px 0px 0px 1px #5AB0FF;
  }

What changes do you think we should make in order to solve the problem?

Remove focus styles in Pressable component by adding already styles styles.noOutline
What alternative solutions did you explore? (Optional)
NA
Result
https://github.com/Expensify/App/assets/129500732/0e25c3ae-9cf9-44d9-8158-46e0d9e088ac

I can reproduce and I'm not seeing a duplicate issue - moving to external

@dukenv0307 now that this issue has moved to external we'll consider your proposal

Do we really want to fix this? This is generally the behavior of the focused button.
I am going to ask @Expensify/design @shawnborton to confirm if we think this is necessary? wdyt @flodnv ?

Yeah, I feel like this is fine and we can close this out.


Clean up collector configuration doc

Fixes https://github.com/open-telemetry/opentelemetry.io/issues/1899 and makes the opening statement more clear.

Would this lead to a merge conflict for https://github.com/open-telemetry/opentelemetry.io/pull/1813/ ?

Yep, let's just wait for #1813


MWPW-136598 make ax-gnav-x gnav appear for uk pages

Loads ax-gnav-x gnav for uk pages
Resolves: MWPW-136598
Test URLs:

Before: https://main--express--adobecom.hlx.page/uk/express/?martech=off
After: https://mwpw-136598-uk-gnav--express--adobecom.hlx.page/uk/express/?martech=off

Codecov Report

Merging #268 (9f0160e) into stage (7dc3c77) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #268      +/-   ##
==========================================
- Coverage   47.16%   47.00%   -0.16%
==========================================
  Files          29       29
  Lines        8840     8840
==========================================
- Hits         4169     4155      -14
- Misses       4671     4685      +14

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Expose RepoCard at top level + few qol improvements

Resolve https://github.com/huggingface/huggingface_hub/issues/1348.
No need to add a SpaceCard class, it wouldn't have any additional features.
I took the opportunity to add a few QOL improvement to the CardData object (.get, __getitem__, __setitem__, __contains__, .pop). More of these could be added but honestly not worth the hassle (those 5 cover 99% of the use cases). Could have been simpler to just inherit from dict but this way we can explicitly add an "export" step when serializing the metadata.
Added some tests and completed a docstring.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks for the reviews and feedback @merveenoyan @nateraw
I'm merging this PR :)


No data in share intent when eas-updates is enabled (iOS)

Describe the bug
When eas updates is enabled the share intent returns null on production configuration builds on iOS. Setting eas-updates enabled to false. Everything works fine
I've set up expo-share-intent to handle sharing files from the Files app, and images from the Photos app
updates: {
    enabled: true,
    url: 'https://u.expo.dev/update-key....'
}

To Reproduce

Follow installation and setup guides for expo-share-intent
Follow installation and setup guides for expo-updates
Enable updates in the expo config
bun ios --configuration release

Environment
System:
  OS: macOS 14.4
  CPU: (12) arm64 Apple M3 Pro
  Memory: 117.64 MB / 36.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.11.0
    path: ~/.nvm/versions/node/v20.11.0/bin/node
  Yarn:
    version: 1.22.21
    path: ~/.nvm/versions/node/v20.11.0/bin/yarn
  npm:
    version: 10.2.4
    path: ~/.nvm/versions/node/v20.11.0/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.15.2
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10811636
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /opt/homebrew/opt/openjdk@17/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.5
    wanted: 0.73.5
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Additional context
        [
            'expo-share-intent',
            {
                iosActivationRules: {
                    NSExtensionActivationSupportsImageWithMaxCount: 1,
                    NSExtensionActivationSupportsFileWithMaxCount: 1,
                }
            },
        ],

expo version (ex: 49) : 50
using firebase : no
using static build : no
routing : react-navigation
package version (ex: 1.2.0) : 1.3.0
platform target :  iOS
device : real device
type: release builds in general, both built local and through EAS

Thank you for your feedback.
I was able to reproduce the issue on the basic example using yarn ios --configuration release 🔥
On app launch we got some expoUpdate error :
[ExpoShareIntentExample] 🟡 {"timestamp":1712601269000,"message":"EXUpdates: Could not emit event: name = Expo.nativeUpdatesStateChangeEvent,
type = check. Event will be emitted when the bridge is available","code":"JSRuntimeError","level":"warn"}
[ExpoShareIntentExample] 🟠 {"level":"error","timestamp":1712601269000,"stacktrace":["ExpoShareIntentExample              0x000000010bfa678b
$s9EXUpdates14FileDownloaderC12downloadData33_75774A0A231786B0DCB0D3DA50F03832LL11withRequest12successBlock05errorP0y10Foundation10URLRequestV_yAI0E0VSg_So13NSURLResponseCtcys5Error_pctFyAN_APSgsAQ_pSgtYbcfU_
+ 875","ExpoShareIntentExample              0x000000010bfa8297
$s9EXUpdates14FileDownloaderC12downloadData33_75774A0A231786B0DCB0D3DA50F03832LL11withRequest12successBlock05errorP0y10Foundation10URLRequestV_yAI0E0VSg_So13NSURLResponseCtcys5Error_pctFyAN_APSgsAQ_pSgtYbcfU_TATm
+ 39","ExpoShareIntentExample              0x000000010bfa6916
$s10Foundation4DataVSgSo13NSURLResponseCSgs5Error_pSgIeghggg_So6NSDataCSgAGSo7NSErrorCSgIeyBhyyy_TR + 182","CFNetwork
0x00007ff8047b74d2 CFNetwork + 38098","CFNetwork                           0x00007ff8047d50b5 _CFHTTPMessageSetResponseProxyURL +
16955","libdispatch.dylib                   0x00007ff8001783ec _dispatch_cal<…>
[ExpoShareIntentExample] 🟠 {"stacktrace":["ExpoShareIntentExample              0x000000010bfc1a2f
$s9EXUpdates16StartupProcedureC13appLoaderTask_35didFinishBackgroundUpdateWithStatus6update5erroryAA03AppeF0C_AA0ijL0OAA0J0CSgs5Error_pSgtFTf4dnnnn_n
+ 1551","ExpoShareIntentExample              0x000000010bfbf528
$s9EXUpdates16StartupProcedureC13appLoaderTask_35didFinishBackgroundUpdateWithStatus6update5erroryAA03AppeF0C_AA0ijL0OAA0J0CSgs5Error_pSgtFTo +
88","ExpoShareIntentExample              0x000000010bf779ca
$s9EXUpdates13AppLoaderTaskC25didFinishBackgroundUpdate019_3339434A583F8B1F65J12D05F1E075305LL10withStatus6update5erroryAA0ghQ0O_AA0H0CSgs5Error_pSgtFytSgAA0bcD8Delegate_pXEfU_yyYbcfU_
+ 74","ExpoShareIntentExample              0x000000010bf63319 $sIegh_IeyBh_TR + 25","libdispatch.dylib                   0x00007ff8001783ec
_dispatch_call_block_and_release + 12","libdispatch.dylib                   0x00007ff8001796d8 _dispatch_client_callout + 8","libdispatch.dylib
0x00007ff80018127d _dispatch_lane_<…>

Will get a closer on this.

ok the problem comes from missing expo config value at runtime : Constants.expoConfig?.scheme is empty ...
we need to give manually the information :
    useShareIntent({
      scheme: "exposhareintentexample", // needed only when using expo-updates
    });

PR is coming for next release

fixed in v1.4.0


More comprehensive docs and examples

I'm happy to write these docs but right now it isn't super clear how to set keylisteners for stuff like "period".
Ideally there would be exhaustive docs for every key code.
This module is great! Thank you!!!

I can second this issue, I had a hard time figuring out how to handle the "." character (the period, as OP mentioned).
Here is how I ended up with, in the template:
    <GlobalEvents
        @keyup.prevent="handleKeyUp"
    />

and in the code (TypeScript):
    methods: {
        //....
        /** Generally handle all keyUp events, by checking for recognisable events
         */
        handleKeyUp(event: KeyboardEvent) {
            //Is the dot?
            if (event.code === 'NumpadDecimal' || event.code === 'Period') {
                //.... do my stuff
            }
        },

I suggest adding this to the docs.
@shentao Would you do that, or should I submit a pull request?


Nat gateway cannot be created due to depends on subnet creation.

│ Error: Invalid for_each argument
│
│   on terraform-azurerm-nat-gateway/r-nat-gateway.tf line 42, in resource "azurerm_subnet_nat_gateway_association" "subnet_assoc":
│   42:   for_each       = toset(var.subnet_ids)
│     ├────────────────
│     │ var.subnet_ids is list of string with 1 element
│
│ The "for_each" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many
│ instances will be created. To work around this, use the -target argument to first apply only the resources that the for_each
│ depends on.

Hello @djcldcvr,
This issue is a common one and is due to a Terraform limitation, see https://github.com/hashicorp/terraform/issues/4149.
Can you please provide your code that leads to this issue ? We may be able to provide a workaround.

Hi @BzSpi

Hi @BzSpi

Hi @BzSpi

Hi @BzSpi
Thanks for your prompt response. Please refer to the below given code that leads to reported issue.
`########################
Location
########################
module "azure-region" {
source  = "claranet/regions/azurerm"
azure_region = var.location
}
########################
Resouce Group
########################
module "rg" {
source  = "claranet/rg/azurerm"
location    = module.azure-region.location
client_name = var.client_name
environment = var.environment
stack       = var.stack
}
########################
Vnet
########################
module "azure-virtual-network" {
source  = "claranet/vnet/azurerm"
environment         = var.environment
location            = var.location
resource_group_name = module.rg.resource_group_name
client_name         = var.client_name
location_short      = module.azure-region.location_short
stack               = var.stack
custom_vnet_name = "${var.environment}-${var.alias}-vnet"
vnet_cidr        = [var.vnet_cidr]
dns_servers      = ["<IP_ADDRESS>", "<IP_ADDRESS>"] # Can be empty if not used
}
###################################
Subnet
###################################
locals {
network_security_group_names = ["nsg1", "nsg2", "nsg3"]
vnet_cidr = "<IP_ADDRESS>/24"
subnets = [
{
name              = "subnet1"
cidr              = ["<IP_ADDRESS>/20"]
service_endpoints = ["Microsoft.Storage", "Microsoft.KeyVault", "Microsoft.ServiceBus", "Microsoft.Web"]
nsg_name          = local.network_security_group_names[0]
vnet_name         = module.azure-virtual-network.virtual_network_name
},
{
  name              = "subnet2"
  cidr              = ["<IP_ADDRESS>/20"]
  service_endpoints = ["Microsoft.Storage", "Microsoft.KeyVault", "Microsoft.ServiceBus", "Microsoft.Web"]
  nsg_name          = local.network_security_group_names[2]
  vnet_name         = module.azure-virtual-network.virtual_network_name
}

]
}
module "azure-network-route-table" {
source  = "claranet/route-table/azurerm"
client_name         = var.client_name
environment         = var.environment
stack               = var.stack
resource_group_name = module.rg.resource_group_name
location            = module.azure-region.location
location_short      = module.azure-region.location_short
}
module "azure-network-security-group" {
for_each = toset(local.network_security_group_names)
source   = "claranet/nsg/azurerm"
client_name         = var.client_name
environment         = var.environment
location            = module.azure-region.location
location_short      = module.azure-region.location_short
resource_group_name = module.rg.resource_group_name
stack               = var.stack
custom_network_security_group_name = each.key
}
module "azure-network-subnet" {
source  = "claranet/subnet/azurerm"
for_each = { for subnet in local.subnets : subnet.name => subnet }
environment         = var.environment
location_short      = module.azure-region.location_short
client_name         = var.client_name
stack               = var.stack
custom_subnet_name  = each.key
resource_group_name  = module.rg.resource_group_name
virtual_network_name = each.value.vnet_name
subnet_cidr_list     = each.value.cidr
subnet_delegation    = {
app-service-plan = [
{
name    = "Microsoft.Web/serverFarms"
actions = ["Microsoft.Network/virtualNetworks/subnets/action"]
}
]
}
route_table_name = module.azure-network-route-table.route_table_name
network_security_group_name = each.value.nsg_name
service_endpoints = each.value.service_endpoints
}
module "nat-gateway" {
source  = "claranet/nat-gateway/azurerm"
client_name         = var.client_name
environment         = var.environment
location            = module.azure-region.location
location_short      = module.azure-region.location_short
resource_group_name = module.rg.resource_group_name
stack               = var.stack
subnet_ids          = [module.azure-network-subnet["subnet2"].subnet_id]
}`

Hi @djcldcvr, like @BzSpi said, that's a Terraform bug.
The only way to pass the issue is by setting first
subnet_ids          = []
apply your code to create all the resources
and then, update the code with
subnet_ids          = [module.azure-network-subnet["subnet2"].subnet_id]
and apply again to update subnets associated to the NAT GW.

Hello !
Original issue https://github.com/hashicorp/terraform/issues/4149 has been closed and replaced by a new one https://github.com/hashicorp/terraform/issues/30937.
No answers since november 2021, i'll close this issue.
Don't hesitate to reply here and we'll re-open it if needed.
Thanks for your issue !


⚠ T:Riza Docs has degraded performance

In 460bc75, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 5569 ms

Resolved: T:Riza Docs performance has improved in 3f105bc.


SylvainRougeaux.Metatogger version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

/AzurePipelines run

Validation fails with label Validation-Shell-Execute.
The validation pipeline logs give no details about the error encountered:
****************************************************************************************
Installation Verification
****************************************************************************************

-----------------------------------------------------
Result: Failed
-----------------------------------------------------
Status: Completed

Providing the MSI log would be helpful.
winget install --manifest <path> correctly installs the application, although Windows SmartScreen validation was required.
Can anyone tell me what is blocking the validation of my PR?
Thanks!

Automatic Validation ended with:

Installation failed with exit code -1978335226 2024-02-04 02:40:52.113 [FAIL] WindowsPackageManager.dll!00007FFA6AFEBDD2: ReturnHr(1) tid(6a8) 80190193 Forbidden (403).     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\HttpStream\HttpClientWrapper.cpp(50)\WindowsPackageManager.dll!00007FFA6AFD203A: (caller: 00007FFA6AEB7669) Exception(1) tid(6a8) 80190193 Forbidden (403). 2024-02-04 02:40:52.113 [FAIL] WindowsPackageManager.dll!00007FFA6AE73AF1: LogHr(1) tid(6a8) 80190193 Forbidden (403). 2024-02-04 02:40:52.113 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(53)\WindowsPackageManager.dll!00007FFA6AFF7301: (caller: 00007FFA6AEC04FE) LogHr(2) tid(6a8) 80190193 Forbidden (403).     Msg:[winrt::hresult_error: Forbidden (403).]  2024-02-04 02:40:52.113 [REPO] Source add/update failed, waiting a bit and retrying: winget 2024-02-04 02:40:54.131 [FAIL] WindowsPackageManager.dll!00007FFA6AFEBDD2: ReturnHr(2) tid(6a8) 80190193 Forbidden (403).     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\HttpStream\HttpClientWrapper.cpp(50)\WindowsPackageManager.dll!00007FFA6AFD203A: (caller: 00007FFA6AEB7669) Exception(2) tid(6a8) 80190193 Forbidden (403). 2024-02-04 02:40:54.131 [FAIL] WindowsPackageManager.dll!00007FFA6AE73AF1: LogHr(3) tid(6a8) 80190193 Forbidden (403). 2024-02-04 02:40:54.131 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(540)\WindowsPackageManager.dll!00007FFA6AFF68E3: (caller: 00007FFA6ADB8B8D) LogHr(4) tid(6a8) 80190193 Forbidden (403). 2024-02-04 02:40:54.131 [REPO] Failed to update source: winget 2024-02-04 02:40:54.319 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(564)\WindowsPackageManager.dll!00007FFA6AFF6B53: (caller: 00007FFA6ADB8B8D) LogHr(5) tid(6a8) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFA6AF09298: (caller: 00007FFA6AFC24F9) Exception(3) tid(6a8) 8A15005E ]  2024-02-04 02:40:54.319 [REPO] Failed to open available source: msstore 2024-02-04 02:40:54.329 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Microsoft\PreIndexedPackageSourceFactory.cpp(205)\WindowsPackageManager.dll!00007FFA6AED453A: (caller: 00007FFA6AEC0B9E) Exception(4) tid(6a8) 8A15000F  2024-02-04 02:40:54.329 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(564)\WindowsPackageManager.dll!00007FFA6AFF6B53: (caller: 00007FFA6ADB8B8D) LogHr(6) tid(6a8) 8A15000F     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Microsoft\PreIndexedPackageSourceFactory.cpp(205)\WindowsPackageManager.dll!00007FFA6AED453A: (caller: 00007FFA6AEC0B9E) Exception(4) tid(6a8) 8A15000F ]  2024-02-04 02:40:54.329 [REPO] Failed to open available source: winget 2024-02-04 02:40:54.329 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(571)\WindowsPackageManager.dll!00007FFA6AEC10DB: (caller: 00007FFA6ADB8B8D) Exception(5) tid(6a8) 8A15004B  2024-02-04 02:42:07.214 [CLI ] ShellExecute installer failed: 1603 Property(S): ErrorDialog = ErrorDlg MSI (s) (BC:3C) [02:42:06:961]: Product: Metatogger 7.5 -- Installation failed. MSI (s) (BC:3C) [02:42:06:961]: Windows Installer installed the product. Product Name: Metatogger 7.5. Product Version: <IP_ADDRESS>. Product Language: 1033. Manufacturer: Sylvain Rougeaux. Installation success or error status: 1603.

(Automated response - build 703.)

@wingetbot waivers Add Validation-Shell-Execute

Automatic Validation ended with:

Installation failed with exit code -1978335226 2024-02-04 02:40:52.113 [FAIL]
ShellExecute installer failed: 1603 Property(S): ErrorDialog = ErrorDlg MSI (s) (BC:3C) [02:42:06:961]: Product: Metatogger 7.5 -- Installation failed. MSI (s) (BC:3C) [02:42:06:961]: Windows Installer installed the product. Product Name: Metatogger 7.5. Product Version: <IP_ADDRESS>. Product Language: 1033. Manufacturer: Sylvain Rougeaux. Installation success or error status: 1603.

(Automated response - build 703.)

Status 1603 frequently means a missing dependency. This is not the first time that the pipeline has encountered difficulties in correctly managing software dependencies. Is a definitive fix planned? Thanks!

Again a pipeline issue about URL validation: https://github.com/microsoft/winget-pkgs/pull/127314#issuecomment-1823719692
What I don't understand is that Echosync, distributed on the same site/domain as Metatogger, poses no problems at all when it comes to validation.
Between the intolerances of the pipeline to software dependencies, and then of the domain, updating Metatogger via winget is anything but smooth and fast.

@wingetbot waivers Add Validation-Domain

Hi @CyberSinh,
Thanks for your patience with our automation, pipelines, and bots. Apparently I was incorrect about 1603 before, and here it wasn't an issue so I added a waiver for that earlier. For the domain, I'm unsure, but if this persists I have an auto-waiver system to mitigate.

Hi @stephengillie,
I can see a Needs-Author-Feedback tag.
Do you expect anything from me?
Thanks.


Improvement: Make the language selection options uniform

What feature or improvement do you think would benefit Files?
Currently, the options in the language selection menu have different styles, some are preceded by their country in English, some by their country in the language itself, some start with a capital letter, some don't.

Requirements
The different options need to have one style
Files Version
<IP_ADDRESS>
Windows Version
10.0.26100.1
Comments
No response

Ok, thanks for explaining, weird cause they show up uniform in Windows settings.


Request for support for Intel Metrics Framework SDK..

Hi,
now seeing preliminary NV Perfkit integration (sad new perfworks SDK is not released openly at least)
I thought I had asked that before but I can't seemd to find it so as seems now Intel iGPU are the only ones missing some counters integration asking for integration..
seems freely downloadable from:
https://software.intel.com/en-us/form/intel-platform-analysis-library-request
and selecting Intel Metrics..

As I try to reinforce, RenderDoc is still primarily designed as a debugger, not a profiler. The integration of IHV counter libraries has come from others so this is not something I will address myself directly. It may be something that someone else contributes.
On another note, I've noticed that you request a lot of widely disparate features, and I'd like to understand which of these are critical for what you're working on. Requesting features is of course welcome, but having a lot of feature requests does add a burden on myself and anyone else looking to contribute. It also makes it harder to prioritise against features that others are directly wanting.

News!
"We just open sourced our GPU metrics discovery API (used by GPA/Vtune) :) Soon Intel metrics in @RenderDoc too !"
https://twitter.com/acohade1/status/986985251959377920


Invalid client error attempting to login with Google

Navigate to the Login page and select the Google button (while not logged into Google). You will be presented with a 401 Invalid Client error Oauth client nor found.

This is not yet implemented


Trouble finetuning wav2vec 2.0

Many thanks for all your hard work on this repository.
I am trying to finetune wav2vec 2.0 XLRS-53 with Librispeech before moving on to other languages.   Here are my steps

python wav2vec_manifest.py /LibriSpeech/dev-clean/ --dest /data_local/wav2vec2/ --ext flac --valid-percent 0.05
wget https://dl.fbaipublicfiles.com/fairseq/wav2vec/dict.ltr.txt
python libri_labels.py /workdir/train.tsv --output-dir /workdir/ --output-name train
python libri_labels.py /workdir/valid.tsv --output-dir /workdir/ --output-name valid
fairseq-hydra-train     task.data=/workdir     model.w2v_path=/data_local/wav2vec2/xlsr_53_56k.pt     --config-dir /workdir/fairseq/examples/wav2vec/config/finetuning     --config-name base_100h

I get
Traceback (most recent call last):
  File "/opt/conda/bin/fairseq-hydra-train", line 33, in <module>
    sys.exit(load_entry_point('fairseq', 'console_scripts', 'fairseq-hydra-train')())
  File "/workdir/fairseq/fairseq_cli/hydra_train.py", line 66, in cli_main
    hydra_main()
  File "/opt/conda/lib/python3.6/site-packages/hydra/main.py", line 37, in decorated_main
    strict=strict,
  File "/opt/conda/lib/python3.6/site-packages/hydra/_internal/utils.py", line 347, in _run_hydra
    lambda: hydra.run(
  File "/opt/conda/lib/python3.6/site-packages/hydra/_internal/utils.py", line 201, in run_and_report
    raise ex
  File "/opt/conda/lib/python3.6/site-packages/hydra/_internal/utils.py", line 198, in run_and_report
    return func()
  File "/opt/conda/lib/python3.6/site-packages/hydra/_internal/utils.py", line 350, in <lambda>
   overrides=args.overrides,
  File "/opt/conda/lib/python3.6/site-packages/hydra/_internal/hydra.py", line 112, in run
    configure_logging=with_log_configuration,
  File "/opt/conda/lib/python3.6/site-packages/hydra/core/utils.py", line 128, in run_job
    ret.return_value = task_function(task_cfg)
  File "/workdir/fairseq/fairseq_cli/hydra_train.py", line 38, in hydra_main
    distributed_utils.call_main(cfg, pre_main)
  File "/workdir/fairseq/fairseq/distributed_utils.py", line 336, in call_main
    main(cfg, **kwargs)
  File "/workdir/fairseq/fairseq_cli/train.py", line 74, in main
    model = task.build_model(cfg.model)
  File "/workdir/fairseq/fairseq/tasks/audio_pretraining.py", line 201, in build_model
    model = super().build_model(model_cfg)
  File "/workdir/fairseq/fairseq/tasks/fairseq_task.py", line 282, in build_model
    model = models.build_model(cfg, self)
  File "/workdir/fairseq/fairseq/models/__init__.py", line 96, in build_model
    return model.build_model(cfg, task)
  File "/workdir/fairseq/fairseq/models/wav2vec/wav2vec2_asr.py", line 147, in build_model
    w2v_encoder = Wav2VecEncoder(cfg, task.target_dictionary)
  File "/workdir/fairseq/fairseq/models/wav2vec/wav2vec2_asr.py", line 298, in __init__
    task = tasks.setup_task(w2v_args.task)
  File "/workdir/fairseq/fairseq/tasks/__init__.py", line 39, in setup_task
    cfg = merge_with_parent(dc(), cfg)
  File "/workdir/fairseq/fairseq/dataclass/utils.py", line 449, in merge_with_parent
    merged_cfg = OmegaConf.merge(dc, cfg)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/omegaconf.py", line 321, in merge
    target.merge_with(*others[1:])
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 331, in merge_with
    self._format_and_raise(key=None, value=None, cause=e)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/base.py", line 101, in _format_and_raise
    type_override=type_override,
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/_utils.py", line 629, in format_and_raise
    _raise(ex, cause)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/_utils.py", line 610, in _raise
    raise ex  # set end OC_CAUSE=1 for full backtrace
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 329, in merge_with
    self._merge_with(*others)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 347, in _merge_with
    BaseContainer._map_merge(self, other)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 294, in _map_merge
    dest_node._merge_with(src_value)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 347, in _merge_with
    BaseContainer._map_merge(self, other)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/basecontainer.py", line 305, in _map_merge
    dest._format_and_raise(key=key, value=src_value, cause=e)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/base.py", line 101, in _format_and_raise
    type_override=type_override,
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/_utils.py", line 694, in format_and_raise
    _raise(ex, cause)
  File "/opt/conda/lib/python3.6/site-packages/omegaconf/_utils.py", line 610, in _raise
    raise ex  # set end OC_CAUSE=1 for full backtrace
omegaconf.errors.ValidationError: Invalid value 'False', expected one of [hard, soft]
        full_key: eval_wer_config.print_alignment
        reference_type=GenerationConfig
        object_type=GenerationConfig

This seems similar to this issue: #3042 . The model was reuploaded and fixed 7 days ago, consider re-downloading the model and trying again.
If that doesn't work for you, can you comment in the mentioned issue?

This seems similar to this issue: #3042 . The model was reuploaded and fixed 7 days ago, consider re-downloading the model and trying again.
If that doesn't work for you, can you comment in the mentioned issue?

Many thanks @assafmu . I am just re-downloading the model and will revert in the mentioned issue if the problem isn't fixed

Many thanks @assafmu . I am just re-downloading the model and will revert in the mentioned issue if the problem isn't fixed


Setup the DataCite harvester

Need to update the old DataCite harvester code so that it:

Is scheduled to run weekly
Scans for DMPS that:

Have a funder with a ROR id
Whose project end date is approaching (within the next year) or has already passed OR who have no project end date defined but the DMP was created over 1 year ago

Extract all of the important metadata from those DMPs (e.g. grant ids, ORCIDs, Funder, title, etc.)
Group the high level metadata by date ranges
Scan DataCite for each date range grouping

Compare the results to the DMPs we are hoping to find matches for
Update the DMPHub JSON with any items found

We should make a pass to find the DMP ID itself in the DataCite system and check if it has relatedIdentifiers. No need for an admin to verify those connections

Had to switch to use the DataCite REST API because we are working with older data so we do not have useful entry points in the GraphQL API (e.g. we have a ROR but the records we are after do not).
We found some success with the REST API. It found related works for about half of the uploaded DMPs. The solution is problematic though and we will need to keep working at it to find a balance.
What's wrong?

Minimal info from admin entered

only one PI
no ORCID
not selecting an Org due to issues with the widget (means no ROR)

Lack of useful metadata in DataCite records

no affiliation info
no funding info
no ORCIDs
work titles and abstracts rarely similar enough to the DMP title and abstract

This all means that we are stuck with matching on a single PI name. It worked for this first round of testing but what about when we have a "Jane Smith"? We will end up with too many matches.


Update to use new syntax for ::save-state and ::set-output commands

Hi @jbrunton, first thank you for this helpful library.
Github is deprecating ::save-state and ::set-output commands, and from Jun-2023, they will completly disable those commands. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Could you please help update gflows to use new syntax? Thank you in advanced.
BR.

Thanks for raising, I will look into this.
That said, since I wrote this library, GitHub has introduced features which I think provide easier alternatives to sharing workflows. See for example https://docs.github.com/en/actions/using-workflows/reusing-workflows. I'm curious if there are any use cases you have which can't be solved by GitHub reusable workflows and GitHub actions in their present state?


Add Title to attachments

This adds a title field to attachments as described in slack by @malgorithms.  If no title is provided by caller, it uses the filename for the title.  The original filename is (still) in the attachment data, this just adds a title.
r? @mmaxim
cc @malgorithms

hey @mmaxim  and @patrickxb  - sweet... quick q:

If no title is provided by caller, it uses the filename for the title.

Without reading through the code: am I correct in assuming you meant for display, not for posting? I don't think we'd want to lose the information that the user didn't choose a title, and this idea of using the filename for the title can just be used at display time.
I'm thinking there's a likely scenario:  if the attachment (1) is an image, and (2) doesn't have a title (likely because the user sent from their camera), we wouldn't want to display it with a title or filename, we would just show the image inline, like most chats. And generally, I think it's safer to retain user intentions so we're more flexible later
(I know I'm writing this after the merge...apologies for getting to it now)

I'll fix. Currently CLI will display like you say, with title = file name if title missing.
But it also sets the title to the file name on the way in if title empty. I'll remove that.

On Nov 4, 2016, at 4:25 PM, Chris Coyne<EMAIL_ADDRESS>wrote:
hey @mmaxim and @patrickxb - sweet... quick q:
If no title is provided by caller, it uses the filename for the title.
Without reading through the code: am I correct in assuming you meant for display, not for posting? I don't think we'd want to lose the information that the user didn't choose a title, and this idea of using the filename for the title can just be used at display time.
I'm thinking there's a likely scenario: if the attachment (1) is an image, and (2) doesn't have a title (likely because the user sent from their camera), we wouldn't want to display it with a title or filename, we would just show the image inline, like most chats. And generally, I think it's safer to retain user intentions so we're more flexible later
(I know I'm writing this after the merge...apologies for getting to it now)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add readiness check to porchctl propose/approve

Check readiness conditions of packag revision during:
porchctl propose
porchctl approve
Add e2e cli test case.

/retest

/approve looks good

/lgtm


Refine: Geofile reading errors

https://github.com/v2fly/v2ray-core/issues/231#issuecomment-699776408

Test and build pass. Merge.


pushing query params

What problem does this feature solve?
As we can push router with query like router.push({query: {a: 1, b: 2}})
but it's not convenient while I just want to add a condition.
I do this as the followed code to get query string ?a=1&b=2&c=3:
import _ from 'lodash'
let query = _.cloneDeep(router.currentRoute.query)
query.c = 3
router.push(query)

What does the proposed API look like?
router.pushQueryParams({c: 3})

I'm not sure why you would need to deep-clone the query?
this.$router.push({ query: { ...this.$route.query, c: 3 }})
Frankly, since one of our goals is to keep API surface small, I don't think the small convenience of a few less characters to type warrants a new API.

I agree with @LinusBorg
On top of that, always replacing the query also allows to remove other query parameters

Yes. Maybe I'm using this in a wrong way.
Thank you anyway.

This can also be solved with adding something like this to your root component. For removing query parameters you can simply set a parameter to undefined
export default {
  name: 'App',
  watch: {
    '$route'(to, from) {
      if (from.name == to.name) {
        this.$router.replace({
          query: {
            ...from.query,
            ...to.query
          }
        })
      }
    }
  }
}

In Vue Router 3.3.4 intensive use of $router.replace fires Error: Avoided redundant navigation to current location

I'm currently using vue-router to store search filters in the query string of the url. This is so that a user can bookmark the page to reload their search filters or just share the page. I know I can get rid of the Error: Avoided redundant navigation to current location error by catching it and just ignoring it, but I feel that's bad practice and I'd like the code to fail on any other errors as well.
Is there a workaround or another approach that would allow me to update the query string using vue-router that would prevent navigation and thus prevent the error?

This can also be solved with adding something like this to your root component. For removing query parameters you can simply set a parameter to undefined
export default {
  name: 'App',
  watch: {
    '$route'(to, from) {
      if (from.name == to.name) {
        this.$router.replace({
          query: {
            ...from.query,
            ...to.query
          }
        })
      }
    }
  }
}

it did't work

I'm currently using vue-router to store search filters in the query string of the url. This is so that a user can bookmark the page to reload their search filters or just share the page. I know I can get rid of the Error: Avoided redundant navigation to current location error by catching it and just ignoring it, but I feel that's bad practice and I'd like the code to fail on any other errors as well.
Is there a workaround or another approach that would allow me to update the query string using vue-router that would prevent navigation and thus prevent the error?

Did you find a resolution to this?

I'm currently using vue-router to store search filters in the query string of the url. This is so that a user can bookmark the page to reload their search filters or just share the page. I know I can get rid of the Error: Avoided redundant navigation to current location error by catching it and just ignoring it, but I feel that's bad practice and I'd like the code to fail on any other errors as well.
Is there a workaround or another approach that would allow me to update the query string using vue-router that would prevent navigation and thus prevent the error?

Did you find a resolution to this?

If your concern is catching only that exception, for now you can always test for it in the catch and throw everything else:
router.replace({ route }).catch(error => {    if (error.name !== 'NavigationDuplicated') {     throw error   } });


Support on premise Active Directory

I'm not sure whether you want to support on premise Active Directory with this gem, but these changes allow the gem to be used for authentication against an on premise Active Directory system.

Let me know if you want me to update the CHANGELOG.md and README.md as well.

Thanks for the feature!
Is it possible to please add in a small test just to verify the behaviour works as expected?
Please do add an explanation of what the client code should configure for on-prem  into an appropriate part of README.md; the change log doesn't get updated until I collate things into a new gem release though, so there's no need to add anything there.

Great, thank you. I've added documentation and tests!

This is now released as v2.3.0.

Great, thank you!


Fix PPU tests so they can be run locally

Sorry, I explained in the commit but should have copied to the PR description:

Under Python 3.6 json.loads accepts bytes, but under 3.5 it only
accepts strings. We haven't noticed this because our tests run under
Python 3.6 but it prevents us running tests locally.


Use SPI Bus for multiple Devices

I wanna use the Spi Bus for multiple Spi Devices Problem here is that the config for one device is a bit different.
(It is taking data on raising Edge the other on falling.)
So is there any way to change config on runtime of a SpiDeviceDriver or to create two different one so I can pass one to each devices?

SpiDeviceDriver? Did you mean to open this in https://github.com/esp-rs/esp-idf-hal ?

You can close this now 🙂


Create Queues and Queue Subscriptions for SAP Event Mesh

Tutorials: https://developers.sap.com/tutorials/cp-enterprisemessaging-queue-queuesubscription.html
From the Trial account, I do not see this screen. I only see the following.

Hi @jmalla,
There seems to be some confusion.
Sorry, if we have provided some information which is creating some kind of confusion in the tutorial.
Please note that, the tutorial to work with the default plan holds good only if you are using a productive environment.
Default version is not available in the trial environment.
And the management screen you have provided here is for dev plan.  How did you get that screen? Can you please let me know the steps you followed to get that screen?
regards
pradeep

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Style Webpage

Style each page to be user-friendly and professional. We want this to be incredibly pretty.

This should include animations for things such as the signup modal, entering the homepage etc.


question

Hi alumae,
thank you for sharing this code. i was able to work through your examples.
i am new to kaldi and the gstreamer plugin.
I have a question though. what is the reason behind choosing gstreamer to pass the audio to kaldi for decoding?
could a simple server be sufficient to pass the audio to kaldi for decoding? are there any limitations to such an approach that made you choose the gstreamer to act as an intermediary(pardon my ignorance if my thought process is wrong)?
thanks in advance

The reason behind choosing GStreamer was to make Kaldi-based ASR easily usable through Python, using a standard API. Kaldi GStreamer plugin allows it to be also used in other types of Python applications, for example in desktop dictation. Also, GStreamer provides support for basically all audio encodings, thus kaldi-gstreamer-server supports all audio file types basically for free.
Also, as I used CMU Sphinx before Kaldi, and CMU Sphinx has a similar GStreamer plugin for Pocketsphinx that I used in an early prototype of the server, I already had some experience with it and knew that it would be relatively easy to use.
The negative side effect of using GStreamer is that it's very difficult to support memory-efficient parallel decoding: we cannot share the static model files between multiple instances of GStreamer plugins.

alumae,
thanks for the quick response. this helps me a lot.


Example links use kubernetes/examples

Fix #5203
Previously, many of the Kubernetes links used
https://github.com/kubernetes/kubernetes/examples. This directory was
deprecated through
https://github.com/kubernetes/kubernetes/commit/cb712e41d435dbb42519bded680fef4043dd23b3,
in favor of the new examples repo hosted at
https://github.com/kubernetes/examples. This commit updates all links
accordingly.

This change is

Re the initial issue report, with this commit, both ag "{{page.githubbranch}}/examples" ./docs -l and ag "git.k8s.io.*/kubernetes/examples" ./docs -l return 0 files.


PHP 7.2.5 gives  Cannot use Object as class name

Getting this error with PHP 7.2.5
Fatal error: Cannot use 'Object' as class name as it is reserved in /home/git/public_html/gitlist/vendor/klaussilveira/gitter/lib/Gitter/Model/Object.php on line 14

These files belong to Gitter, which has its own repository. Also a duplicate of #765.

Nope, I'm just involved in this project yet. However, there's an issue filled.
If v1.0.0 isn't working for you, it'll be nice to file issues for the related bugs, if they haven't been filed yet. v4.0.0 isn't supported anymore as it's way to old.

Thanks for your answer. The main issue, for me, is really the lack of PHP 7 support from Gitter.
(it doesn't matter finally: I fixed this issue, and rolled my own version... https://git.belin.io)
GitList is a great product. I hope that its development will carry on.


Create home.html

Updated some not functioning links of page in HTML also added link of college in home page address section

Please share the screenshots

these are some small changes
I am working on dark mode right now
It needs a major change in code


support for controlling cron mode with an init_style attribute

Description
Currently I am able to control the way I run chef-client as a service with "init_style" attribute, while having only "default" recipe in the run_list. I would like to achieve the same, consistent style of control for running chef-client using cron, with "init_style" set to "cron" (although naming... technically cron does not have to do with init).
Example use case: Imagine one is switching from running chef-client as a service to running it as cron job and he would like to experiment in one of environments first without having to manipulate run lists.
Issues Resolved
none
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@prein
@acasimirosmart

Please sign the CLA here.

@prein did you want us to be able to merge this PR? It seems reasonable, but we can't if you don't legally permit us to by signing the CLA.

@josephholsten I have signed the CLA, twice actually, some years ago, does it expire? I never was an active contributor, which is a shame, but have the agreement signed. On a sentimental note I am proud for my name to be found on approved contributors list back in 2010 (https://web.archive.org/web/20100825175929/http://wiki.opscode.com/display/chef/Approved+Contributors) :)

@prein Please check ^

Now that we have a cron resource I'm going to close this out since users can add any number of cron jobs for chef-client to their recipes.


Allow users to receive notifications about Approval events

We want to build a notification feature where users can receive transactional emails about new allowances that are being made.
Right now we want to keep this system as simple as possible. So we only send an email when an Approval is made.
Subscribe user

Sign in with Ethereum

Prompt the user for their mail address.

We create an Alchemy webhook for the user's address

GraphQL query will look something like this
{
    block {
      logs(filter: {topics: ["0x8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b925", ${USER_ADDRESS}]}) {
        account {
          address
        }
        topics
        transaction{
          hash
          index
          to{
            address
          }
          from {
            address
          }
          status
        }
      }
    }
  }

When an Approval event is sent by the webhook we need to process this.

Optional, run some filters
send an email to the user.

Unsubscribe user

Sign in with Ethereum
Users clicks on Unsubscribe
We need to remove the alchemy webhook.
Optionally we could delete the user's email address from our DB

We just talked about this, and it probably makes more sense to have 1 global webhook that listens to all global Approval events. Then on our service we can check if any of the involved addresses belongs to our subscribers. If so we'll have to send an email.
Besides using an Alchemy webhook, we could also look into using a "regular" RPC to listen for events, but Alchemy webhooks are probably easiest to start with.


merge: latest from master

Fix conflicts in asset package by merging latest from master and regenerating yarn.lock


[meta] decoupling from ipfs-webui

Just writing down some thoughts and concerns, needs more analysis, probably can be split into 2-3 phases.

Right now ipfs-desktop is tightly coupled with ipfs-webui:

ships with a bundled version of ipfs-webui
opens bundled webui in Electron's webview
injects own settings into Settings screen of ipfs-webui

I believe it comes at significant maintenance cost and user confustion:

requires ipfs-webui to support Electron "browser" and things such as drag&drop broke in Electron before (#1287)
every time new setting is added, ipfs-desktop release is blocked by ipfs-webui, and same for bugfixes (eg. https://github.com/ipfs-shipyard/ipfs-desktop/issues/1290)
running Electron webview in the background  wastes CPU and memory (not as much since it is now "paused" by switching to a blank subpage - https://github.com/ipfs-shipyard/ipfs-desktop/pull/1198 - but still wasteful)
when user opens webui from commandline or via browser extension they see the same ipfs-webui, but when they go to Settings ipfs-desktop options  are not there (they are there only if webui is opened via ipfs-desktop menubar)

I suspect we could consider:

remove Desktop-specific items from Settings screen in webui, and put them in menubar submenu instead
opening webui from http://<IP_ADDRESS>:8080/webui instead of webui://- pseudoprotocol

to ensure webui is present in repo and works out of the box, bundle webui as a TAR archive with ipfs-desktop and import it if it is not not in local repo already
(we have prior art of doing just that in Brave)

opening in real web browser instead of Electron

Is there any reason for the Electron standalone app to exist other than the fact that it comes as part of a convenient package that also installs the daemon and CLI tools?

I believe _raison d'être` is to provide GUI for starting/stopping IPFS node and opening webui for everything else:

Right. All of which could stand on their own and send the user to webUI as needed ...

Hey y'all!

remove Desktop-specific items from Settings screen in webui, and put them in menubar submenu instead

Personally, I agree. Most of the options (if not all), are just checkboxes and Electron's menus have support for check-boxes type of things.
Also, by removing Web UI screen, we would simplify the code a lot and just need to open Web UI on user's default browser.

opening in real web browser instead of Electron

I also agree with this. It simplifies a ton of things. There are a few things that'd need to be changed in order for all of this to work, but it would be quite simple.

However, I want to mention that this was discussed before (although I can't find any issue about it). I remember we keeping the Electron's window for browser support purposes, i.e., since we ensured that Web UI worked on Electron, anyone could use it.
But I have to say that most modern browsers work well (Firefox, Chrome and Chromium-based browsers). Electron introduces changes to Chromium that often break things.
If this gets decided to be as a to-do thing, I can allocate a bit of time to do this myself on the ipfs-desktop side.

Linking here to a lengthy round of design discussion that involved talking through what functionality should be included where:
https://github.com/ipfs/ipfs-gui/issues/12
Not suggesting anything in here be acted upon yet, just referencing it here for when the time comes.

Also, looks like we had a version of a similar discussion a while back:
https://github.com/ipfs/ipfs-gui/issues/41
Linking to it here to facilitate discussion, and for historical context.

Added a quick note from my end: ensure offline use case works
If we stop bundling webui with ipfs-desktop and open webui in a web browser, then we need to ensure the proper CID is already in the repo.
We have prior art of doing just that in Brave: ipfs-companion is bundling TAR archive for webui CID and during the startup in Brave checks if it is present in the repo, in not, it imports data from the TAR. Code in precache.js . This ensures webui is always present and fast, even if initial load happens in "airplane mode".

(Love the idea @lidel!)

Update: We're doing initial user surveying in https://forms.gle/c6gHP1pVtwtRpzdP7 about how folks feel about the decoupling idea in general. The survey will go out in the 12 May 2020 edition of the weekly IPFS newsletter, and I'll follow up with a link to it in the forums once the newsletter goes out. Will link to artifacts/summaries/etc in this meta-issue rather than opening an issue exclusively for the survey. Watch this space ...

Survey analysis here: https://docs.google.com/document/d/1V5sDSxMqhhplpcB8u8CffiGWHUvw-t4p_sn5vigdR90/edit#heading=h.9bdsxkml3rtd
TL;dr: While justification may exist for decoupling the standalone Web UI and re-envisioning Desktop as a tray/menubar tool (backed by daemon launch at launch), we have bigger opportunities for improvement right now.

For the record, we successfully decoupled codebases :partying_face:

Desktop settings were removed from WebUI and are now in tray icon's menu (https://github.com/ipfs-shipyard/ipfs-desktop/pull/1640, https://github.com/ipfs-shipyard/ipfs-webui/pull/1628)
Also removed special-casing for  folder import  Electron (https://github.com/ipfs-shipyard/ipfs-webui/pull/1628), regular Web API is used now.

Remaining question:
is this level opf decoupling enough, or do we want ditch Electron's BrowserWindow and start opening webui in real web browser instead of Electron window?
Analysis below. Would appreciate your thoughts @rafaelramalho19 @jessicaschilling @Gozala
TLDR at the end ;)

I thought the main challenge with opening webui in regular browser is Origin isolation, but the longer I think about it, the more UX issues I see. Below is my brain dump with :green_heart: upsides, :broken_heart: downsides, :stop_sign: deal-breakers, and :wrench: additional work.
If we use WebUI version bundled with go-ipfs (:5001/webui)

:green_heart: This removes the need for testing webui in Desktop, as this version is already tested before go-ipfs release
:green_heart: does not require localhost subdomain for security isolation

it will work on every platform without the need for installing IPFS Companion or manually setting HTTP proxy

:broken_heart: the URL in address bar will be fugly
:broken_heart: we are unable to ship new webui without waiting for new go-ipfs

If we use different version..

:green_heart: This gives us the same control over webui version as we have right now
:broken_heart: requires localhost subdomain for security isolation

:stop_sign: subdomains on localhost are not supported on some platforms and require IPFS Companion or manually setting HTTP proxy (https://github.com/ipfs/go-ipfs/issues/7527). we expect this to get better (there are ongoing issues/discussions for better localhost support in Firefox and Safari), but ETA is unknown.

:wrench: Desktop needs to safelist specific origin by setting proper CORS headers in go-ipfs' config
:wrench: Desktop needs a way of passing API port address to WebUI via #hash (API port could be different than :5001)

..specified by CID (<cid>.ipfs.localhost:8080)

:broken_heart: the URL in address bar will be fugly
:green_heart: works in offline environment, no dependency on DNS

..specified by DNSLink (webui.ipfs.io.ipns.localhost:8080)

:green_heart: the URL in address bar looks okay-ish (starts with webui.ipfs..)
:stop_sign: breaks in offline environment or when ipfs.io is censored at DNS level

TLDR I think we should keep bundling webui and opening in Electron for now, as it is the least painful option right now.
Opening in regular browser will break for some users if we do it by default, unless we stick with version behind /webui on API port, which in turn forbids us from shipping new webui independently of go-ipfs, slowing down our release cycle.
What we could do is to introduce opt-in experiment that "opens the latest webui (DNSLink) in default browser".

💚 This removes the need for testing webui in Desktop, as this version is already tested before go-ipfs release

Not quite true, it could still impact something "taskbar related" and still needs tests in desktop, but for the most part I agree with that.
I really don't like losing control of the release cycle and waiting for go-ipfs to ship the version, I think it will lead to go-ipfs being overwhelmed with our work.
Personally, I like your last option specified by DNSLink (webui.ipfs.io.ipns.localhost:8080) and if ipfs.io is blocked at DNS level, I guess that's alright, since that's the user option to do so?
Do you have any alternative solutions of taskbar frameworks or should we stick with electron?

if ipfs.io is blocked at DNS level, I guess that's alright, since that's the user option to do so?

Not always. Users in specific countries may have ipfs.io blocked at DNS level against their will, which will produce error page.
However, in those cases, :wrench:  we could detect lack of subdomain support and/or lack of DNSLink and use :5001/webui as a fallback.

Do you have any alternative solutions of taskbar frameworks or should we stick with electron?

Nothing comes to mind, need additional research. Mind that removal of Electron is a nuclear option at this point: it means we need to design new build and release pipeline and create contingency for migrating users to the new system.

Agree with @rafaelramalho19's 💭  bubbles above, but might prefer the solution to use a different version specified by CID. The address bar URL might be awful, but in our world of CIDs we're consistently throwing users long ugly strings. The DNS/offline benefits seem more important than beauty in this case.
That said, agree with your TLDR, @lidel: also remember that the surveys we did earlier indicated far less of a user-driven demand to decouple.

My general sentiment is electron window wrapper just hides ugly url, and I would much rather try to address that core problem instead of hiding it with dedicated window.
Here is where I wish and hope we can end up one day:

webui.ipfs.io (or some other address) is a canonical place to access your IPFS node.
webui.ipfs.io uses service worker so that it continues to work after first load even if

Domain got blocked.
Even if user is offline.

webui.ipfs.io detects if ipfs-desktop isn't running (by pinging localhost) and offers you to install it to enhance experience.

It communicates really clearly what the benefits are for user personally and network overall

webui.ipfs.io isn't special, you can deploy same page on other domain and it will function just the same.

In fact it is deployed across all IPFS nodes that have domain name
Local IPFS node can discover more deployments from peers it connects to.

webui.ipfs.io (and other deployments) can overcome CORS restrictions imposed by HTTP API by requesting a permission via HTTP request. IPFS desktop grants or denies permission by consulting user via system prompt.
Other deployments of webui.ipfs.io could ask ipfs-desktop to be a default UI so that:

I could make webui.gozala.io be my default instead.
I could switch to beta or nightly channels of webui's or even stick to some pinned CID version.

IPFS Desktop can pass communication address to webui.* (via #hash link or such) so that non-standard port or hosts would work as well.

IPFS Desktop can detect when opening a webui has failed (because no callback has occured) and provides troubleshooting system UI.

If for whatever reason webui.alt.io is no longer accessible troubleshooting UI can offer to try different alternatives (form the list e.g. https://webui.ipfs.io, https://webui.pinata.cloud/, https://webui.ipfs.io.ipns.localhost:8080` etc) and helps user report the problem in some ways. (in fact troubleshooting could probably be automated by loading diff options in hidden browser window etc...)

That way we can have deliver experience that is:

Most familiar from the conventional web. Almost like dropbox.
In browsers that don't support IPFS natively experience is enhanced via IPFS Desktop (e.g. in brave we may not even offer installing IPFS desktop, and on mobile we may look for some alternative way e.g. delagate to desktop ??)
It is resilient to censorship because there can be many deployments that troubleshooting process can help you discover.
It works offline because service workers rock!
If all fails we do still have a localhost based fallback assuming IPFS desktop is there.
We and the wider community are enabled to experiment with alternative UIs and empower user with choice.


allow to add custom context into query trace

Allow custom context to be added into query trace and returned as part of the TraceInfo field in query response.

Codecov Report

Merging #10977 (2f82064) into master (8170d43) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10977      +/-   ##
==========================================
- Coverage    0.11%    0.00%   -0.12%
==========================================
  Files        2189     1655     -534
  Lines      118056    86750   -31306
  Branches    17872    13682    -4190
==========================================
- Hits          137        0     -137
+ Misses     117899    86750   -31149
+ Partials       20        0      -20

Flag
Coverage Δ

integration1temurin11
?

integration1temurin17
?

integration2temurin11
?

integration2temurin17
?

integration2temurin20
?

unittests1temurin11
0.00% <0.00%> (ø)

unittests1temurin17
0.00% <0.00%> (ø)

unittests1temurin20
?

unittests2temurin11
?

unittests2temurin20
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rg/apache/pinot/core/util/trace/BuiltInTracer.java
0.00% <0.00%> (ø)

...rc/main/java/org/apache/pinot/spi/trace/Scope.java
0.00% <0.00%> (ø)

... and 535 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


v0.13.1 available

https://github.com/JohnnyMorganz/StyLua/releases/tag/v0.13.1
It seems to fix some significant issues.

Thank you!
Closed by baf5674b6a0dd062c49b2f75ba6845b8e21551a6

Awesome. Thank you.


"make" toasts the m1k!

The Makefile will attempt to flash the m1k if it is connected via USB.
However, on my system (Debian testing), using the latest master branch, the flash will fail and result in a non-booting device, that makes a clicking noise, and don't appear on lsusb.
This is fully reproductible and I already bricked two units.
The last few lines of my make log:
LN      m1000.elf
SIZE    m1000.elf
m1000.elf  :
section              size         addr
.text              0x354c      0x80000
.relocate           0x670   0x2007e000
.bss               0x1ac0   0x2007e670
.stack              0x800   0x20080130
.ARM.attributes      0x29          0x0
.comment             0x58          0x0
.debug_info       0x14837          0x0
.debug_abbrev      0x3a65          0x0
.debug_loc         0x7a15          0x0
.debug_aranges      0xe40          0x0
.debug_ranges      0x1c08          0x0
.debug_macro      0x1629c          0x0
.debug_line       0x10348          0x0
.debug_str        0x5a1a1          0x0
.debug_frame       0x1e60          0x0
Total             0xaabdb

   text	   data	    bss	    dec	    hex	filename
 0x3bbc	    0x0	 0x22c0	  24188	   5e7c	m1000.elf
OBJDUMP m1000.lss
NM      m1000.sym
OBJCOPY m1000.hex
OBJCOPY m1000.bin
/bin/sh: 1: [: -a: unexpected operator
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: 'NoneType' object has no attribute 'ctrl_transfer'
Makefile:2: recipe for target 'flash' failed
make: [flash] Error 1 (ignorée)
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/usb/core.py", line 971, in ctrl_transfer
    self.__get_timeout(timeout))
  File "/usr/lib/python2.7/dist-packages/usb/backend/libusb1.py", line 819, in ctrl_transfer
    timeout))
  File "/usr/lib/python2.7/dist-packages/usb/backend/libusb1.py", line 552, in _check
    raise USBError(_strerror(ret), ret, _libusb_errno[ret])
usb.core.USBError: [Errno 5] Input/Output Error
Makefile:2: recipe for target 'flash' failed
make: [flash] Error 1 (ignorée)
python ./scripts/sam-ba.py
please wait...
Traceback (most recent call last):
  File "./scripts/sam-ba.py", line 26, in <module>
    dev.set_configuration(1)
AttributeError: 'NoneType' object has no attribute 'set_configuration'
Makefile:2: recipe for target 'flash' failed
make: [flash] Error 1 (ignorée)

That bites! Good news is it's easy to unbrick a unit - short out the small jumper on the top of the board as per the m1k-fw README and use bossac. I'll look into this.

Ok, I could fix them all.
Thanks!

Should be 'if [-e ...]' instead of 'if [ -a ...'. Bash seems to ignore -a with just one expression, but dash throws an error.
Also which jumper exactly? There are 4 pads next to the PIO header.

Short the smallest jumper. http://imgur.com/tOdcnSb

Can we add these instructions/pictures to the wiki?
http://wiki.analog.com/university/tools/m1k/firmware
should exist, but currently does not.
-Robin

@pcercuei I suspect this is related to https://github.com/analogdevicesinc/m1k-cad/issues/4. The script at master works perfectly on the test jig. I'll modify sam-ba.py to disable PB17, disabling all the power-hungry bits.
"Input/Output Error" isn't especially helpful, but sounds like the device is dropping off the USB bus for some reason.
Short term, I'll drop the call to sam-ba.py in the 'all' Make target.

I am hit be a similar error. After calling "make" with pixelpulse running, the device was lost. After much searching and finally finding this thread and the picture  http://imgur.com/tOdcnSb, at least I can make the device enumerate as samba. But calling "python ./scripts/sam-ba.py" gives
please wait...
Traceback (most recent call last):
File "./scripts/sam-ba.py", line 26, in
dev.set_configuration(1)
File "/usr/lib/python2.7/site-packages/usb/core.py", line 559, in set_configuration
self._ctx.managed_set_configuration(self, configuration)
File "/usr/lib/python2.7/site-packages/usb/core.py", line 92, in managed_set_configuration
self.backend.set_configuration(self.handle, cfg.bConfigurationValue)
File "/usr/lib/python2.7/site-packages/usb/backend/libusb1.py", line 741, in set_configuration
_check(self.lib.libusb_set_configuration(dev_handle.handle, config_value))
File "/usr/lib/python2.7/site-packages/usb/backend/libusb1.py", line 571, in _check
raise USBError(_str_error[ret], ret, _libusb_errno[ret])
usb.core.USBError: [Errno None] Unknown error
Only after the sequence: Short jumper, apply poser to the board, unplug and reapplu power, samba finally succeeded.

Sorry, didn't reread the last sentence. It should read:
Only after the sequence: Short jumper, apply power to the board, unplug and reapply power, samba finally succeeded.

At 1dbc371, 'make' will no longer run 'make flash' by default.
I have not taken the time to debug this.
sam-ba.py works flawlessly with

Linux debian-1638b 3.4.104-bananian #1 SMP PREEMPT Mon Apr 6 18:25:40 UTC 2015 armv7l GNU/Linux
pyusb '1.0.0rc1'

Part of my problem was an "Powered USB Hub", where actual the power supply for the hub was broken and so the ADALM was only powered with 4 Volt. With that unpowered hub, also the negative rail didn't come up.

@UweBonnes Youch, that would definitely cause problems. Can you run uname -a and let me know what kernel version you're running? Trying to gather information about what works / what doesn't work.

On Debian testing, the python-usb package seems to be very old (0.4.3-1, probably using the old libusb API). By installing a more recent package from the "experimental" repository, flashing works fine.

@pcercuei Glad to hear it.

"Ian" == Ian Daniher<EMAIL_ADDRESS>writes:

Ian> @UweBonnes Youch, that would definitely cause problems. Can you run
Ian> uname -a and let me know what kernel version you're running? Trying
Ian> to gather information about what works / what doesn't work.

uname -a
Linux hertz 4.0.0-rc6-1.g3062c5b-desktop #1 SMP PREEMPT Tue Mar 31 01:37:19 UTC 2015 (3062c5b) x86_64 x86_64 x86_64 GNU/Linux
--
Uwe Bonnes<EMAIL_ADDRESS>
Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

The makefile's been patched to not automatically try and dump FW. The sam-ba.py script has been confirmed to work by multiple individuals. It should be modified to check for pyusb version, but closing this issue.


Feature request:Provide event handler for Lexv2 lambda integration

Use case
LexV2 can integrate with Lambda to process events. An event handler that can parse and generate the necessary output format would be extremely useful
Solution/User Experience
Similar to Bedrock Agents
Alternative solutions
No response
Acknowledgment

[X] This feature request meets Powertools for AWS Lambda (Python) Tenets
[X] Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

hey @massi-ang thank you for opening that feature request! While we need more customer feedback for Lex specific one, we would like to create a generic one to unblock customers -- more popular ones will become dedicated Event Handlers like REST, GraphQL, etc.: #3267

We're closing this issue because it wasn't planned for now.
For now, we'll focus on creating a more generic event handler to work with EventBridge, S3, and other types of events.
Please feel free to reopen or perhaps write an RFC to implement this.
Thanks


Add the option to hide alt text on images

Is your feature request related to a problem? Please describe.
Alt text is useful, but frequently covers the entire lower portion of tall images, making their lower portions unreadable.
Describe the solution you'd like
A button or swipe gesture to close the alt text panel, and perhaps a small corner button or reversed gesture to bring it back. The option to display or not display alt text by default in settings would also be nice.
Describe alternatives you've considered
Users can kind of get around the issue now by zooming and swiping, but this is not ideal and does not work 100% of the time.
Additional context
None.

+1 to this or some similar solution


KeyError: 'unexpected key "base.0.weight" in state_dict'

(virtualenv) [charan@cuda-server ssd.pytorch]$ python eval.py
Traceback (most recent call last):
  File "eval.py", line 423, in <module>
    net.load_state_dict(torch.load(args.trained_model))
  File "/home/charan/anaconda2/envs/virtualenv/lib/python3.6/site-packages/torch/nn/modules/module.py", line 522, in load_state_dict
    .format(name))
KeyError: 'unexpected key "base.0.weight" in state_dict'

Got this error when tried to evaluate on trained VOC 2007 model (ssd_300_voc07.pkl)

I'll look into it, but I was just about to deprecate the v1 version (older version of the model) which is what that weight file is based on.  Is there a specific reason you were trying to use the v1 model weights or will the other weights listed in the README work for your use case?
SSD300 v2 trained on VOC0712 (newest PyTorch version)
https://s3.amazonaws.com/amdegroot-models/ssd300_mAP_77.43_v2.pth
SSD300 v2 trained on VOC0712 (original Caffe version)
https://s3.amazonaws.com/amdegroot-models/ssd_300_VOC0712.pth

I am working on a project connected to ssd using only VOC 2007, so I need weights file trained on VOC2007.

Ah okay.  Try replacing ssd.py with this older version.

that ssd.py is not working....getting below error...
in ssd.py, In line 5, data folder doesnt have c9_2, pool6

have you finally solved the issue?


Make PinDriver no longer reset pin on drop.  Add public reset_pin function to PinDriver

This makes PinDriver no longer reset and disable a pin on drop, solving issue #217.
A public function to provide the reset functionality is added as well.

Whoops, this is the wrong version - hold on a second.

This should be correct now


Label tab Dark theme visibility

[x] some of the input boxes are white, they should match dark theme input boxes

(currently)

(they should all match the dark theme style)

[x] Symbol Attributes table is white, it should match the regular dark them Attributes table

(currently)

(should match this style)

[x] Add to Map button is white should match the other dark theme buttons

(Add to Map should match Add to Favorite)

Issues noted above addressed in #206 , #207

There is an additional issue not noted - with the 3rd party WPF Toolkit Date/Time Control (calendar) and spin buttons (up/down arrows) not being in dark theme - I don't think I will be able to address these without removing the Date/Time Control because this is the only compelling open source Date/Time Control available.


Fix GH-100 : Cannot have 2 models with ELMo embeddings of 2 different languages at the same time

Define a language based scope to isolate variables for ELMo TF graphs

thanks a lot Olivier


Rename Scss.scss to SCSS.scss

It's SCSS, not Scss.

The readme needs to be updated.

I made a minor (small) change to address the request: Tyler887@7c851cc


Add definitions on hover for terms and abbreviations used in the documentation

Problem

Documentation site uses some terms that would benefit from a glossary on hover, just like in WordPress P2.
We could use the definitions on hover for abbreviations (such as IP for Implementation Plan), terms that might not be familiar, or technologies.
Description

Implement "Definition on hover" using sphinx-hoverxref.
Alternatives

A solution that we create from scratch. Would require a lot of time and effort.
Additional context

This is a really good idea!
Although the default tooltips do not look like they will integrate with our current Furo theme, the fact that they support styling it is great. I tried it out on the setuptools docs and the tooltip is unusable in the dark theme.

Also, I can't find it now but I remember @sarayourfriend pointing out that the glossary in the API docs was weirdly arbitrary. This feels like a logical successor to that discussion.

The API glossary has been removed now, the next deploy will remove it from the prod API v1 docs.


HHVM:  Call to undefined method …TemplateLocator::isFresh

I have open an issue in facebook/hhvm#2215 because I have an error when I want execute Symfony with HHVM.
This is my error :
Fatal error: Call to undefined method Symfony\\Bundle\\FrameworkBundle\\Templating\\Loader\\TemplateLocator::isFresh from context Symfony\\Bundle\\AsseticBundle\\Factory\\Resource\\FileResource in /home/baptiste/Projet/cren/vendor/symfony/assetic-bundle/Symfony/Bundle/AsseticBundle/Factory/Resource/FileResource.php on line 49

After search in the code, I have  found the code. Symfony\Bundle\AsseticBundle\Factory\Resource\FileResource take in its constructor, a first argument which implements Symfony\Component\Templating\Loader\LoaderInterface but I didn't understand why I have this error.

Any idea on that? I'm getting the same error too. Seems pretty weird because the loader provided to the FileResource class is not a LoaderInterface object but a FileLocatorInterface instead. Does that have to do with AsseticBundle itself or should I look for the cause of the problem somewhere else?

it would be great to look for the cause of the problem, to understand where it comes from.

@stof I'm not sure about the exact steps that can lead to this error.
I'm not even using HHVM, I'm using Travis CI with PHP 5.5.9.
I stumbled upon this while trying to access my web app from CasperJS testing framework. Functional tests with PHPUnit don't have this issue.

I have the same Problem. I am using Nginx 1.4.6 with HHVM 3.12.1
I can confirm this Problem doesnt bother PHPunit (run with HHVM).
I habe the problem when i just want to access the app_dev.php or app.php
Is there any progress on this one?


--timings: show crate version in the graph?

When different dependencies pull in multiple versions of the same crate, it would help to see the version of the crate that was compiled. (See syn when building rustfmt

)

I would like to take a crack at this. I understand the team doesn't accept new features without the S-accpeted label, but I thought I'd ask in case. Is it okay to work on this?

Hi, @m-bal. Thank you for being interested in this. I feel like it would be good to have that option off by default, and have a toggle button for that. Some pointers:

The units table is serialized here https://github.com/rust-lang/cargo/blob/27a41d67899dfc84e6f859a9fe938e93fcca564a/src/cargo/core/compiler/timings.rs#L564-L568
The drawing of the SVG of an unit lives in https://github.com/rust-lang/cargo/blob/27a41d67899dfc84e6f859a9fe938e93fcca564a/src/cargo/core/compiler/timings.js#L114
The unit data passed into JavaScript is here https://github.com/rust-lang/cargo/blob/27a41d67899dfc84e6f859a9fe938e93fcca564a/src/cargo/core/compiler/timings.rs#L496

... when they need to disambiguate.

@weihanglo Do you mean only add the crate version if we see a duplicate crate (same crate name) with a different version in the list of crates (units)? If so, would creating a list of duplicate crates with a different version, then checking that list when creating the label and adding the version be a sufficient implementation?

I don't see any progress on this. Would it be okay if I picked this up?

@remkop22, not sure whether @m-bal already started or not. Since it was a month ago, it's probably fine for you to take over I guess.
Feel free to ask questions here!

@weihanglo Pardon my intrusion as I believe there's two people that said they'd fix this issue, but I took a quick look at the code you linked and I do believe the solution is as simple as this patch:
diff --git a/src/cargo/core/compiler/timings.js b/src/cargo/core/compiler/timings.js
index 986070ab0..92f57fb9a 100644
--- a/src/cargo/core/compiler/timings.js
+++ b/src/cargo/core/compiler/timings.js
@@ -111,7 +111,7 @@ function render_pipeline_graph() {
     ctx.textAlign = 'start';
     ctx.textBaseline = 'middle';
     ctx.font = '14px sans-serif';
-    const label = `${unit.name}${unit.target} ${unit.duration}s`;
+    const label = `${unit.name}${unit.target} (v${unit.version}) ${unit.duration}s`;
     const text_info = ctx.measureText(label);
     const label_x = Math.min(x + 5.0, canvas_width - text_info.width - X_LINE);
     ctx.fillText(label, label_x, y + BOX_HEIGHT / 2);

Which gives this result:

It doesn't only mark the version when there are duplicate crates, but in my opinion this is more "honest" as the version is shown.
Is this acceptable?

Hey @Angelin01, thanks for being interested in this!
My original idea is that duplicate crates are minority, so it may be worth showing versions only when there are really duplicates to reduce visual noise. I don't really have a strong opinion, and it is easy to revert if people feel too noisy then.
So, go ahead!
(BTW I may display it as syn v2.0.18 since the table below uses this format. Having the same format make it easy to do text search)


update install docs

Closes: #666
May not directly address:

Conclusion: the simplest route should probably be emphasized in the doc. Install Docker Desktop, create a Python venv, pip install warnet, warnet setup, done. Installing the deps globally can still be discussed but it should probably not be the default route when following the docs?

But I think the re-ordering should help significantly.
If we really want to address this comment, perhaps we should re-introduce warnet quickstart or something?

LGTM - but considering the experience weve had thus far i think the very top of the page should look something like this:

TLDR

pip install warnet

warnet setup

I can add this section at the top if you're serious? I do agree it would be pretty nice myself...

Hmmm as I sketch it out, I'm not sure a TLDR section is necessary with the new structure. And once we include a python venv, and a k8s cluster, we just end up repeating what is already in this change?


Maintain Linux Page

Linux Page should contain the complete Linux Essentials course.
Pinging @CYBERDEVILZ for this task

@CYBERDEVILZ,  Merged #15
Now, next time, when you create a PR, kindly refer to this issue (#16)
Pro-Tip: Whenever you are referring to an issue, put it as a bullet list item. This would prompt the Github to provide the complete name of the issue.
For instance:
#16  (normal way that we used to do earlier)

#16   (look what happened when I addressed the issue as a bullet list item)

Consider it done


Remove prints from image dataset from directory

I added a verbose arg to index_directory function in utils/dataset_utils.py and to image_dataset_from_directory function  in utils/image_dataset_utils.py to control/remove prints when using image_dataset_from_directory.

Codecov Report
Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.15%. Comparing base (c8700f4) to head (0817213).
Report is 67 commits behind head on master.

Files
Patch %
Lines

keras/utils/dataset_utils.py
75.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19228       +/-   ##
===========================================
- Coverage   80.14%   54.15%   -25.99%
===========================================
  Files         341      363       +22
  Lines       36163    39232     +3069
  Branches     7116     7586      +470
===========================================
- Hits        28982    21247     -7735
- Misses       5578    16438    +10860
+ Partials     1603     1547       -56

Flag
Coverage Δ

keras
54.15% <75.00%> (-25.84%)
:arrow_down:

keras-jax
?

keras-numpy
54.15% <75.00%> (-2.93%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: add elevation component

Description
This PR is adding an Elevation component as well as adding default and customizable elevation on:

[x] Card
[x] Dialog
[x] DropdownMenu
[x] Popover

Fix https://github.com/traefik/faency/issues/153

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use assert and require in a more idiomatic way in our tests

This PR changes the way we use assert and require to the more idiomatic way of using the test suite directly.
For example, this
assert.Equal(s.T(), expected, actual)

becomes
s.Equal(expected, actual)

Part of the work for #561.


pub-build is not printing errors logged by transformers

Seems that pub-build is not printing errors logged in transformers. I noticed this when debugging issue #15083.

This issue has been moved to dart-lang/pub#733.


Allow to configure using Environment variables instead of flags

At the moment we only allow to configure the exporter using flags.
But in some environments it is easier to configure using environment variables.
Suggested variable prefix: FORTIGATE_EXPORTER_*
This is a framework which would allow this without much overhead and allows additional config files: https://github.com/peterbourgon/ff

Sure, sounds useful!


urls.py update for new Django format

Update urls.py to support new urlpatterns format.
Copy code from Mezzanine to make sure it's align to it.

@stephenmcd I saw you updated this project to support Django 1.9 and Mezzanine also use new url.py format. Can you review this PR?
FYI, Mezzanine url format

Looks good, just need to remove the patterns import.

@stephenmcd I just updated my PR with removing the patterns import

Awesome, thanks a lot.


COPY failed: no source files were specified

What happened:
/fluent-plugin-splunk-hec$ docker build docker
Sending build context to Docker daemon  10.24kB
Step 1/14 : FROM registry.access.redhat.com/ubi8/ruby-25
---> 50cf9051f2fe
Step 2/14 : ARG VERSION
---> Using cache
---> 064c73285e39
Step 3/14 : LABEL name="Splunk Connect for Kubernetes Logging container"<EMAIL_ADDRESS>     vendor="Splunk Inc."       version=${VERSION}       release=${VERSION}       summary="Splunk Connect for Kubernetes Logging container"       description="Splunk Connect for Kubernetes Logging container"
---> Using cache
---> b401ed36c194
Step 4/14 : ENV VERSION=${VERSION}
---> Using cache
---> 7898c9dc111f
Step 5/14 : ENV FLUENT_USER fluent
---> Using cache
---> 4560d160bb67
Step 6/14 : USER root
---> Using cache
---> 72658eff7189
Step 7/14 : COPY *.gem /tmp/
COPY failed: no source files were specified
What you expected to happen:
Successful build!
How to reproduce it (as minimally and precisely as possible):
git pull the origin/release/1.2.4 branch
docker build docker
Anything else we need to know?:
Anything I'm missing?
Environment:

local docker environment : docker build docker
Docker version 18.06
OS macOS

Ha. used the build.sh and that worked out way better


Progress bar support for Context.map and Context.run

Support in Context.map is straight-forward, same for Context.run with UDF-based analyses; I think adding progress bar support for the deprecated job-based analyses is not important, even if it is possible.

Can you provide some more details. Do we use any library for progress bar?

Yes, we are using tqdm. But in this case, you don't even need to know this, as Context.run_udf already has a progress parameter, and both map and run call run_udf under the hood.


Rush JS monorepo support

At our workplace we're using a monorepo management tool called Rush.
https://rushjs.io/pages/intro/welcome/
It's semi-popular at >600k weekly downloads on npm, specializes on industiral scale monorepo management, and is used at Microsoft, HBO and TikTok.
It uses pnpm workspaces underneath, so I believe I can make knip work for our repo with some effort anyway using manual workspace definition, however it could be nice if the experience was improved.
There are 2 main differences from the vanilla pnpm workspaces:

No root package.json
Package manager files (lockfile, pnpm-workspaces.yaml, npmrc, etc) isn't at the root of the repo (pnpm-workspaces is a generated temp file not commited to git).

A setting to give custom path to the workspaces file could be a solution?

I was in a Rush project too, trying to integrate Knip, so I understand the situation. I also understand the value of not having a node_modules folder at the root. Still, for various reasons, we ended up migrating to pnpm + Turborepo, as it's less "magic". Obviously I'm not asking you to do the same, but this RFC is currently not in scope as there's a lot more to it than a custom path to the workspaces file.
Would still be great to have some kind of workaround for Rush users if that makes sense and/or if you could share it if/when you would have any.

Would still be great to have some kind of workaround for Rush users if that makes sense and/or if you could share it if/when you would have any.

I will one day, Knip looks great and I want it, but dunno when I'll get the time to do setup. But it will probably just be a manual enumeration of projects in knip.json#workspaces. Not perfect, but my startup aint Microsoft, we don't have 600 packages that need settings, should be manageable

Maybe the "." could be configured as usual, while symlinking the relevant things (package.json, node_modulesandpnpm-workspace.yaml`) to the root. Perhaps naive, but that's basically what Rush does as well to trick pnpm?

Maybe the "." could be configured as usual

Oh, I must configure .? I thought I could just leave it out.
Another thing that could help in the meantime, is if knip searched for .gitignore recursively. Right now if I run knip without config in an app it's already helpful, but it's highlighting dist folder because .gitignore is 2 folders up in the hierarchy.

Oh, I must configure .? I thought I could just leave it out.

No, you don't have to, I was just making the connection with the symlinked package.json etc.

Another thing that could help in the meantime, is if knip searched for .gitignore recursively. Right now if I run knip without config in an app it's already helpful, but it's highlighting dist folder because .gitignore is 2 folders up in the hierarchy.

Knip should run from the root, it won't look upwards of it the cwd for .gitignore files. Even using --directory has the same restriction. You can lint separate workspaces using --workspace which does take those files into account (https://knip.dev/features/monorepos-and-workspaces#lint-a-single-workspace).

echo '{"name":"bliep"}` > package.json && pnpx knip --workspace apps/admin && rm package.json

Runs, but considers all dependencies as unlisted and config files (.eslintrc etc) as unused, lol

I guess that's were the symlinking comes in. Or knip --production --strict for isolation.

I feel like the result is better if I just run it in a project folder. Sure, it picks up gitignored files, but it detects all dependencies etc correctly then.
I've also tried simply running it in common/temp where all pnpm files that are normally in the root are stored, but knip hung up (been showing this for hours now). Tried running it in rush's own repo to see if that's something wrong with ours, but there it fails  while reading .pnpmfile.cjs

That error looks like either name is not present in a package.json file or syntax like this is used:
{
  "devDependencies": {
    "//": [
      "a comment"
    ]
  }
}

As we're deviating from the original topic, I'm going to close this issue (reason: https://github.com/webpro/knip/issues/457#issuecomment-1896984925).


[c++] Placeholder for batch_size and partitions

Needing implementation in C++; then Python and R.

Along with Behnam -- ?


Injection Module Err: Angular 1.5.8 and Satellizer 0.15.4

Maybe related to #200, but that was marked as closed and the issue appears ongoing.
Using

jQuery 3.1.0
Angular 1.5.8
Satellizer 0.15.4

Getting
Error: $injector:modulerr
Module Error
Failed to instantiate module app due to:
Error: [$injector:unpr] http://errors.angularjs.org/1.5.8/$injector/unpr?p0=a

in Chrome.
App Module
angular
	.module("app", ["satellizer"])

	.config(function($authProvider) {

		$authProvider.live({
			clientId: 'Microsoft Client ID'
		});

	});

Contoller
angular
	.module('app')

	.controller("oneDriveCtrl",function($scope, $auth) {

		function logr (msg) {
			console.log(['sampleController', msg]);
		}

		logr('Loaded.');

	});

Immediately throws Uncaught Error: [$injector:modulerr]
Works fine if I don't include Satellizer. Are there any additional angular dependencies?

Sorry, this was due to an uglification error.