[BACKLOG-15105] Extending PluginRegistry to allow additional Plugin m…

…appings after plugin construction.

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/plugins/PluginRegistry.java
  core/src/org/pentaho/di/core/plugins/SupplementalPlugin.java
  core/test-src/org/pentaho/di/core/plugins/PluginRegistryUnitTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.Const

Branch Change:  + .20%
Complexity Change:  + .27%

org.pentaho.di.core.plugins.Plugin

Branch Change:  + 8.33%
Complexity Change:  + 6.67%
Instruction Change:  + 8.39%
Line Change:  + 4.76%
Method Change:  + 5.13%

org.pentaho.di.core.plugins.PluginRegistry

Branch Change:  + 2.79%
Complexity Change:  + 3.78%
Instruction Change:  + 6.83%
Line Change:  + 5.13%
Method Change:  + 7.50%

org.pentaho.di.core.plugins.SupplementalPlugin

Branch New Coverage: 50.00%
Complexity New Coverage: 60.00%
Instruction New Coverage: 76.12%
Line New Coverage: 71.43%
Method New Coverage: 75.00%

org.pentaho.di.core.row.RowBuffer

Complexity Change:  + 16.67%
Instruction Change:  + 10.00%
Line Change:  + 8.33%
Method Change:  + 16.67%


create riddle plugin

brief description of changes
I have added a riddle plugin which is like the joke and trivia plugin in structure. I have added the answers in case anyone wants to extend this plugin to allow guesses. I have also added the flag of the UK to the contributing countries list.

join us on discord!


email and/or shipping address is lost from state after cart-item qty change

If the qty of cart items are changed (obviously, in the checkout), the email address and shipping address are cleared from the state.

All input seems to be removed from the state when cart-item qty is updated. Email, shipping address/method, payment method.


Dsl2

More updates based on PR comments from @ggabernet . Mostly very minor

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/bactmap branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint .).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

@ggabernet good to merge now I think


UnicodeDecodeError in python2

googleimagesdownload -k 'สวัสดีครับ' -l 5
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/2.7/bin/googleimagesdownload", line 10, in <module>
    sys.exit(main())
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 998, in main
    paths,errors = response.download(arguments)  #wrapping response in a variable just for consistency
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 825, in download
    paths, errors = self.download_executor(arguments)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/google_images_download/google_images_download.py", line 922, in download_executor
    print(iteration.encode('raw_unicode_escape').decode('utf-8'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe0 in position 29: ordinal not in range(128)

+1 to this issue. Being able to pull images for languages other than english would be really, really useful.
If there's any work around in the meanwhile, please do share!

Same issue on python3.7.
Replacing non ascii characters by their unicode representation should fix the problem.
def transliterate(string):
    """Transliterates string into his closest representation.
    Ex: 1. àé => ae,
        2. สวัสดีครับ => swasdiikhrab.
    :param string: string
    :return: closest string.
    """
    from unidecode import unidecode

    if not isinstance(string, bytes):
        string = u''.join(string)

    return unidecode(string)

Same issue in python3.7.
A workaround is to replace non-ascii characters with their unicode representation.
def transliterate(string):
    """Transliterates string into his closest representation.
    Ex: 1. àé => ae,
        2. สวัสดีครับ => swasdiikhrab.
    :param string: string
    :return: closest string.
    """
    from unidecode import unidecode

    if not isinstance(string, bytes):
        string = u''.join(string)

    return unidecode(string)

Same issue in python3.7.
A workaround is to replace non-ascii characters by their unicode representation.
Python 3:
def transliterate(string):
    """Transliterates string into his closest representation.
    Ex: 1. àé => ae,
        2. สวัสดีครับ => swasdiikhrab.
    :param string: string
    :return: closest string.
    """
    from unidecode import unidecode

    if not isinstance(string, bytes):
        string = u''.join(string)

    return unidecode(string)

Python 2:
Replace if not isinstance(string, bytes): by if not isinstance(string, unicode):

@jose-t : Thank you! I was trying to solve the issue and found Translation (vs. Transliteration) to work the best in Google Image search results. Depending on the query, either might give better results, but it's hard to predict before comparing the results for n queries.
Posting translate function in case someone wants to use it (note: you'll need Google Cloud account and follow authentication steps: https://cloud.google.com/translate/docs/reference/libraries)
def translate_text_to_en(query):
	translate_client = translate.Client()
	translation = translate_client.translate(query.encode('utf8'), target_language='en')
	print(u'Translation: {}'.format(translation['translatedText']))
	return translation['translatedText']

It's a bug while trying to print the exactly name in the utf-8 encoding. if you were using python3,  you can just git clone the project and remove the decode in google_images_download/google_images_download.py like this:
print(iteration.encode('raw_unicode_escape').decode('utf-8'))
into
print(iteration.encode('raw_unicode_escape'))
then uninstall the origin one and python setup.py install the modified one. Althought it print bad on screen but it works fine.
Using python2 will have another problem....
ps. still dont know why the example in website using Chinese that pass but another language decode have problem ...

Have you ever tried export PYTHONIOENCODING=utf-8?

@DuckSoft That doesn't fix it for me.


Update build.gradle

Fix forge mixin config calling for jobsplus instead of correct mixins

Changes has been published to CurseForge.


Implement Filecoin.ChainGetEvents

Blocked by https://github.com/ChainSafe/forest/issues/4740

Blocked by #4780

Should be unblocked.
However, we will still need to create a mapping { event_cid => tsk } similar to what we have for EthAPI ({ tx_hash => msg_id }).


Update Extraction class and add valid data examples for review

PR for extraction class updates.
From 12/1 meeting
New slots added and some slots moved up to planned process

extractant slot needs to be able to be able to handle multiple solvents (and solutes) and specify the ratio in which they are supplied.  A possible solution would be the range of the extractant be a Solution class that could be reused for other processes rather than the existing enum. A Solution class will be essential for liquid chromatography related processes down the line.

propose to rename sample_volume slot on Extraction class to input_volume to be consistent with input_mass

propose to rename volume slot on Extraction class to extractant_volume for readability and to differentiate from sample/input_volume

Thanks for the feedback @kheal
One goal for the schema is to keep the number of classes and slots small. Another is to clearly expose in the documentation which elements have similarities without requiring a text search.
I'm inclined to agree with your suggested slot name changes (which increases the number of slots), but then they should either be asserted as is_a children of a upper volume slot, or they should be put into a volume_slots subset.
I think we already discussed the idea of parent slots in some prior Metabolink meeting, but I don't think anything ever got merged.

I don't think we need the concentration slot on Extraction class since this is a simple combination of input_mass or sample_volume and volume and adds no additional information but creates the opportunity for inconsistency.

In the context of what we need for NMDC to 1) correctly classify NOM data in the data portal and 2) enable the metadata-informed workflows, which aim to predict the molecular search space, the fundamental slots we need for the Extraction class are extraction_method, extraction_target, extractants, concentration. We should focus on these slots and consider the others mentioned later.


xmir-to-eo

Let's make a printer from XMIR to EO.

@rultor release, tag is 0.5.0

@rultor release, tag is 0.5.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.5.0

@yegor256 Done! FYI, the full log is here (took me 14min)

Job gh:cqfn/eo#335 is not assigned, can't get performer


Rebase multi-tenancy

This pull request rebases all multi-tenancy and no-cluster-rbac changes. Additionally, I implemented multi-tenancy integration tests and improved* existing tests.
*these tests may seem more complicated, but now they are more similar to istiod installed by our operator.
I will squash some commits when I will have approvals and after applying potential suggestions from reviewers.
@jwendell @yxun do you know, which label do I need to not squash commits?

/test all

/test all

/test all

/test all

/test all

/test integ-security-2-5

All comments addressed. Please review once again.


Separate Login and Signup to individual pages

Deconstruct the Form page to make the login and signup forms have there own page and route. Very little restyling should be needed. This will mostly be file structuring and copy and paste.

[ ] Create login and signup routes in App.js
[ ] Create login and signup pages
[ ] Inject forms into there respective pages
[ ] Add logout to Navigation (conditionally)
[ ] Remove remaining Forms page/components

Created branch
git fetch origin
git checkout 28-refactor/login-signup

Closed by #29


AST Audioset Training Time and Hardware

Hi,
I hope this message finds you well. I am currently working on my thesis and have found your work on AST invaluable.
I am using your pretrained model (Full AudioSet, 10 tstride, 10 fstride, with Weight Averaging) as a baseline for comparison.
Would you be able to provide some details on the hardware used to train this model, as well as the approximate training time? This information would be incredibly helpful for the context of my research.
Thank you very much for your time and assistance.

hi there,
We also released the training log of that experiment at https://github.com/YuanGongND/ast/blob/master/egs/audioset/exp/test-full-f10-t10-pTrue-b12-lr1e-5/log_2090852.txt
All information can be found in the log.
Specifically, the GPU is 4 x NVIDIA TITAN X (12GB each GPU), an old GPU.
Training time per epoch = 118072 seconds, we trained 5 epochs, which is about 7 days. With modern GPUs, it will be faster.
I recommend checking the mAP immediately after the 1st epoch and seeing if it matches our log.
-Yuan

Thank you!


focus problem with jquery 3.4.1 and select2 4.0.8

Howto

Simple select2 box
select value from the box
focus "disappears"
press arrow key down
=> plain html select dropdown is shown in web page

This should have been fixed in the 4.0.9 release that just happened.

Just tested with select2-4.0.9 and it does not fix problem


Be-raheem2

Description
Wrote tests with commented notes for Story.js page.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

Tests for Story look great, Sush. Will try to implement that fake fire store on the Report. Thank you again for helping with the frontend testing.


E2e test for conformance plugin

What this PR does / why we need it

This PR adds a E2E test for conformance Plugin.

The flow of test is

Installing Unmanaged cluster.
Running conformance plugin.
Fetching the tar ball file which have the result of tarball.
Retrieve the result and print it.
Doing the cleanup of cluster, conformance and file.

Small correction in path fields of Unmanaged and Diagnostic E2E test workflows.

Which issue(s) this PR fixes

Fixes: #3694
Describe testing done for PR

Run in Fork branch whose logs are https://github.com/aman556/community-edition/runs/6796153722?check_suite_focus=true
Run make conformance-e2e-test in local.

Hey @jpmcb can we please merge this if nothing major left. I will figure out that printing the log thing once other priority tasks get pop from stack.
Thanks!

Hey @stmcginnis can I please have your eyes on this one too. I think we are good to merge this one.
Thanks!

@stmcginnis I see that this PR is approved. Do we merge this already? As I see the "Squash and merge" button. Are we waiting for more approvals?


java.lang.UnsatisfiedLinkError: no chrome_elf in java.library.path: D:\softWare\pycharm\PyCharm 2023

who can help me,i dont know whats happened

Well, I don't know either, but I would think these kind of dependencies would be distributed together with IntelliJ. Do you have any kind of nonstandard installation? You could try to reinstall.
What version of IntelliJ and what version of the pdf viewer are you using?


Service integration of new version

When we create a new version all the metadata are copied. This includes the service integrations (eg. links to kontext), technically the link is to the old version. Is this OK?

@natalink opinions?

do not copy them; services should recognise underlying data versions


plyql not supporting FROM_UNIXTIME

Hi there!
I'm trying to do a WHERE __time BETWEEN FROM_UNIXTIME() AND FROM_UNIXTIME() query, but plyql is complaining.
Are you planning to add it? Is there a workaround to work with UNIX timestamps?
Thanks!

It will be added.

Added as part of plyql 0.8.8
try:
plyql -h <IP_ADDRESS> -o json -q 'SELECT FROM_UNIXTIME(1447430881) AS T'


Add missing values

This PR adds a few values and properties that were missing.

[x]  word-break: break-word
[x]  calc(100px * 3)
[x]  overflow-x: clip
[x]  transform-box
[x]  transition-property
[x]  transition-timing-function 'jump-start' | 'jump-end' | 'jump-none' | 'jump-both’

@davesnx everything’s ok except for 'word-break: break-word'.
according to mdn, it is deprecated and I really don't want to add deprecated values because it's very hard to remove after that.  I can merge the PR if word-break is removed.
If people really want to use it, is still possible to use it with an 'unsafe' operation.

I fixed a few build issues that weren't related with my PR and removed the word-break.

Thanks


Implement RFC #5

This PR implements  https://github.com/ponylang/rfcs/blob/master/text/0005-file-naming-guidelines.md
It should also be noted that an Int type has been created as type Int is (Signed | Unsigned) to match the Float type.

Looks great, thanks for taking care of this!
However, I wonder if Integer might be better than Int for the new type...  I don't feel super strongly about it so I will see what others from @ponylang/core @ponylang/committer say.

@jemc Integer exists as a trait, just like FloatingPoint is a trait and Float is a type declaration.

@Theodus - you're right - makes sense to me.  I'm going to merge this - I don't think it has any breaking changes.

I think there are some problems here
test.pony was renamed to main.pony, I'm not sure that is what we would want here.

@SeanTAllen what would you suggest?

test.pony is in my mind better. it captures "what this is" far better than "main.pony".
i think this is one case where the naming convention falls apart a bit. in any other case I think it works, however, not in the case of tests.

I think this is a good conversation for the sync call.

I understand the general idea of why it was done, but I think that test.pony is a better name because it is the tests and that better represents the intent.

test.pony is in my mind better. it captures "what this is" far better than "main.pony".

i think this is one case where the naming convention falls apart a bit. in any other case I think it works, however, not in the case of tests.

I'd argue that this is not a failure of the naming convention, but yet another case where applying rules consistently highlights a tension with the fact that tests in the standard library are compiled in the same package as the code they test. For another example of this, see #588.  For another example of this, see the builtin_test package, where including the tests in the same package builtin was seen as not only impractical, but impossible. For another example, see the fact that every single Pony application that uses a standard library package also has a dependency on ponytest, even applications that are not tests.
That is, the complaint here that foo/main.pony isn't a good conceptual description of the file that contains tests is the direct result of the fact that the Main of a given package is not the conceptual "main" executable actor for that package.  Most packages (those that are reusable libraries) should not really have a "main" conceptual actor, because a library is generally not executable, but those that do have a conceptual "main" (like top-level applications, or libraries that come with an accompanying command line tool) need their Main reserved for the actual application - forcing yet another special case where the tests must be in a subpackage.
All these tensions are not incidental, but the result of a real consistency problem in our test conventions.
See #625 for more discussion.

We strongly disagree. I think it's a good conversation for sync call.


Updates to examples

Thanks for putting this up... I've been playing with it to do quick kotlin prototyping.
Spent the morning getting it working, ended up being two small bugs:

using the github URL for resolving dependencies didn't seem to work on OSX; kept getting error: could not find or load main class Main_Scriptarg_cache_3335d424be6c36f7 when using anything with //DEPS. Putting resdeps.kts in my ~/bin solved the problem.

bug: in the example for Docopt, there's a line of doArgs.joinToString(). Should just be doArgs.

Fun stuff regardless, thanks!

Concerning 1.
Sorry for inconvenience, but I can't reproduce it yet. I've tried the following on Macos sierra with kotlin 1.1.3-2 (JRE 1.8.0_131-b11):
[brandl]$ which kscript
/Users/brandl/.sdkman/candidates/kscript/current/bin/kscript
[brandl]$ kscript --version
kscript - Enhanced scripting support for Kotlin on *nix-based systems.

Usage     : kscript <scriptfile, script-url, - for stdin, some kotlin code> [<script_args>]*
Usage     : kscript --clear-cache     # wipe cached script jars and urls
Usage     : kscript -i                # interactive shell with DEPS as declared in script

Copyright : 2017 Holger Brandl
License   : MIT
Version   : v1.5.3
Website   : https://github.com/holgerbrandl/kscript
[brandl]$ which resdeps.kts
[brandl]$ kscript --clear-cache
Cleaning up cache...
[brandl]$ kscript https://git.io/v1cG6 my argu ments
Hello kscript-user
The arguments were my, argu, ments

So it seems that dependency resolutions works fine with kscript even for URLs. Could you provide more details/example how it failed for you?
Concerning 2.
Indeed, I've fixed the docopt example. Actually I've also written a more convenient wrapper in https://github.com/holgerbrandl/kscript-support-api/blob/master/src/main/kotlin/kscript/util/DocOpt.kt. See https://gist.github.com/holgerbrandl/a712112c392400ad503a46bcefe706a6 for an example.

feel welcome to still comment. Just closed due to inactivity.


Add back/forward features for the current tab

Tested environment: Windows 10 and OS X 10.11.6
Added two shortcuts to implement browser's back/forward features. And the menu items are located under History menu.

Alt+Left (Command+[ on OS X): Go back to previous web page in the current tab.
Alt+Right (Command+] on OS X): Go forward to previous web page in the current tab.

The functionality is almost not related to OS, so I think we need a tester regardless of OS. Testable artifacts are available at https://circleci.com/gh/yuya-oc/desktop/2#artifacts

Seems to work fine, as long as you stay in one team. Doesn't work over team borders.

What is the point? The back/forward history is managed by each tabs, so the shortcut should not affect inactivated tabs as same as web browsers.

Just wanted to mention it.

I see, thanks.
The behavior I wrote is typical in tab-based applications, and the changelog mentions "in the current tab". So I feel we don't have to specially mention about that. Any thoughts?

Yep, we should be fine.

Thanks @yuya-oc, @Razzeee!
That's correct, going back/forward in history in the current tab is more consistent with other apps (including the Mattermost web app).
@yangchen1, would you like to test this on OS X? You can download the artifact from this link.

Tested successfully on OS X. :) Great work @yuya-oc and @Razzeee.

Thanks @yangchen1 ! @yuya-oc ready to merge

Thanks! Rebased due to conflicts.


Correct wrong default value

Proposed changes
I think the default value for v4auth is actually true, not false.
Unreleased project version (optional)

Related issues (optional)

@dmcgowan can you comment on this? I looked through the code but couldn't figure it out. I think the file is https://github.com/docker/distribution/blob/96f63cbe7f9d06f213289df97b6bd3102cf65903/registry/storage/driver/s3-aws/s3.go.

This change looks correct. LGTM


[core] Batch small changes

Close the developer survey 42c32dc: The survey has been running for 22 days, we had 1,450 answers, x2 more than last year. It's probably time to close it. We have to analyze the results now 😅.

[l10n] Improve fr-FR value 16bdb64: Thanks @raduchiriac for the report in https://github.com/mui-org/material-ui/commit/9c053f85f0353cfc5ede1ce8cc0a87a618675277#r38650085.

[docs] Automatically redirect pt to pt-BR 611a655: as discussed with @jaironalves, the /pt/ locale is the most used one. It's also the most translated, at almost 100%. It seems safe to enable auto redirection for this locale, as we have for the Chinese one.

Legend

Language => the primary configured language of the browser
userLanguage => the language of the docs

[Autocomplete] Improve the heading structure cea1d62775a6edce94740ac104c5177098ab8ccb: freeSolo has two main use cases, make it explicit.

[core] Most of the time, we use aria-hidden as a boolean a4ec727: a nitpick.

[l10n] Fix dark mode support of the demo a638ef8: reported by @dtassone on

https://material-ui.com/guides/localization/#example

[docs] Add a new introduction series of videos ee96096: New up-to-date quality content is always appreciated, thanks @AtotheY.

[docs] Warn about the a11y implication of changing HTML font size bee571e: ♿

[Autocomplete] Use useControlled instead of custom logic 3f0bed0: I believe there is another case to migrate: the Rating, for another time.

[docs] Fix centering of code on mobile 7e64043: a small display bug, it's not centered.

[docs] Display a loading state for notifications 18bee68: display a loader instead of an empty state.

[docs] Display a loading state for notifications 18bee68: display a loader instead of an empty state.

So notifications are an important part of the landing page? More important than the search? Do you have some numbers how much more often notifications are clicked compared to searchß

@eps1lon There is another issue with the notification I didn't mention: it throws when clicking before the notifications are loaded (It's a regression I have introduced).


Request to publish a new tag for PR#61

Hi @paulfantom - We're wanting to take on the improvement in https://github.com/paulfantom/ansible-restic/pull/61 (check if a repo needs initialization) but this hasn't been released in a tag. We'd very much appreciate it, if you would please make new tag/release so we can refer to that in our deployments?

Done with https://github.com/paulfantom/ansible-restic/releases/tag/0.15.0

:1st_place_medal:


c7n: print resource id as output on consoloe logs

Would it be possible to print out a list of resources that matches the policies for c7n?
Use case:
detect public IP on ec2 resources. By having a policy to detect the running ec2 instances with public ips, it is not visible which instance is violating the policy unless i check the resources log in the output folder. This is even more not visible when i send the logs to cloudwatch.

custodian report is intended to give formatted output, for cli output it can be voluminous for a given policy to cli print every resource. we put out summary information to stderr, metrics (-m) to cloud provider logs, and Json outputs to blobs output location with full resource details.


Resource without content files should not be made public

It is possible to create resources without content that are public.  Ways to do this seem to be
As reported by @horsburgh . I used the EnviroDIY website to create this resource:
https://www.hydroshare.org/resource/6e97cc54c6ce448ab32367388a12b793/
Something went wrong in copying the data file over, so there are no content files in this resource. However, the resource is public!
Also I created a new composite resource, and gave it a title, abstract and keywords, without adding any files.  I get the message that it can be made public.
I was able to do the same with a generic resource.

According to Craig (@darksinge), he found the error in EnviroDIY that prevented the data file from being copied into the HydroShare resource, but the ability to create a public resource with no content is something that needs to be fixed on the HydroShare side.

@dtarb @horsburgh This is a regression since content file was indeed required before a resource could be made public. I have just taken a quick look at the code and this line does not look right to me: https://github.com/hydroshare/hydroshare/blob/e1a11fe20b7a3514e366f66095af9056e158bd10/hs_core/models.py#L2183 Specifically, when a resource does not have supported_upload_file_types defined, like generic resource and possibly composite resource, this has_required_content_files() just returns true which is not right. I believe it should check it at least has files. @aphelionz I can make a fix to this and create a PR against develop which I assume will make its way to release 1.16 if approved and merged. Let me know.

@aphelionz I have fixed this issue. I keep that line I indicated above since it is about file types in composite resource and I don't want to remove them without being 100% sure about it. Those lines are not culprit for this issue according to my testing, but the bug was caused by calling a property to check whether there is content file, but that "property" is not defined as property but instead a method. I fixed it by adding property decorator to make it a property. Apparently, this is not captured by tests, so I am going to look into tests to have this test case covered. Since it is a regression, I think it should make into 1.16 release, or even as a hotfix depending on when 1.16 will be released. Let me know which release tag I should create a PR against to have this bug fix along with augmented/added tests included. Looping in @dtarb and @horsburgh to keep them posted as well.

@aphelionz I found this is indeed covered by tests. The reason the test did not fail is that the test called this method has_required_content_files() as a method which is currently being implemented, but can_be_public_or_discoverable property calls that method has_required_content_files as a property, hence the issues with UI. I decided to keep this has_required_content_files() as a method, and fix the bug in can_be_public_or_discoverable to call it as a method rather than a property. I decided not to add additional unit tests to cover this specific bug, as I believe Selenium UI test will be sure to catch this bug if it props up again in the future. I'll create a PR against 1.16 tag to include this bug fix as part of 1.16 release.

Hong, where is the testing site I can verify your fix.


UWP Windows Support

A lot of libraries are now supporting react-native-windows - https://github.com/Microsoft/react-native-windows - is there plans for UWP support with react-native-audio?

No plans for you're welcome to add a PR!


Please merge revision f9d05b6e299f96b67bcac32dc37ec6c28e937f55 into dev channel

@ricowind @whesse @mit-mit @kasperl
This fixes the names of source-maps for the fast-startup emitter.
Revision to merge: f9d05b6e299f96b67bcac32dc37ec6c28e937f55
This merged cleanly.
This CL has a very low probability of breaking anything since the --fast-startup flag is currently only used inside Google. (It hasn't that high of a priority either).

Merged to 1.12.0-dev.5.5.


Upload package

Can we use some type of upload package for faculty to have a much simpler interface to provide files. We may also be able to leverage this for Globus.

We're closing this issue because it's stale or incomplete. If you need to reopen it, let us know.

We're closing this issue because it's stale or incomplete. If you need to reopen it, let us know.


Update rendering-elements.md

Hello @aKshayKadam03!
I think that the actual sentence is correct as written, however, I can no longer find it in the latest of react.dev sources.
I will close this PR as outdated, but you are welcome to create new PRs for other open issues.
Thank you!


enhancement: clear everything and restore DOM structure on destroy graph

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Pull Request Test Coverage Report for Build 369409656

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 367831652:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


fixed installation errors

@mergify backport foxy humble

thanks to @mertsaadet https://github.com/linorobot/linorobot2/issues/47


lnchannels with tor nodes

Hi,
When I do lnchannels, I get a lot of
 > No response from Addr:Port i5geerzdqwowg2ooxxg6vexegol4rbbz2hhyippj2b2yqesz3pepcvyd.onion:9735
⚡Rocky&TheFatCat[L        5050000   2563       701064      4346373     0      1
i7mqndi2zihvj6ltwvlarmwsmai74hfxxwtyxc4dkrvrupwawzjwnnad.onion: forward host lookup failed: Unknown host
NodeYouDidnt                190000   4002       120995        65003     0      1
 > No response from Addr:Port i7mqndi2zihvj6ltwvlarmwsmai74hfxxwtyxc4dkrvrupwawzjwnnad.onion:9735

Any idea why? how can I further test those channels?
Thanks

Which command are you running to get this output?

Closing this issue due to inactivity. Feel free to reopen it if further assistance is required.


Typo in the Readme.md

Thanks for the great plugin.
In the Readme.md of event_sync Dokumentation is an copy/past issue which propably can confuse a little bit. :)
{
"event_name": "muc-room-created", must be muc-room-destroyed
"room_name": "catchup",
"room_jid"<EMAIL_ADDRESS>"created_at":<PHONE_NUMBER>,
"destroyed_at":<PHONE_NUMBER>,
"all_occupants": [
{
"name": "James Barrow",
"email"<EMAIL_ADDRESS>"id": "00380324-a840-400d-880f-7ee0933b7556",
"occupant_jid"<EMAIL_ADDRESS>"joined_at":<PHONE_NUMBER>,
"left_at":<PHONE_NUMBER>
}
]
}

Thanks for spotting that. I've raised a PR to get that fixed.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/48960

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/49785

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/60147

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/61408


Allow various non-array tracking_ids, fixing roString unit test

Addresses https://github.com/veeta-tv/roku-gamp/issues/13


docs(sdk): Removed less than, greater than characters from dosctrings…

…. Re: It breaks the new doc engine Docusuarus.
Fixes WB-NNNN
Fixes #NNNN
Description
Removed less than, greater than characters from dosctrings. Re: It breaks the new doc engine Docusuarus.
Testing
No test. Docstring changes only.
Checklist

[ ] Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
[X] Ensure PR title compliance with the conventional commits standards

Thank you @dmitryduev!


add donbosco.edu.ec

https://www.donbosco.edu.ec/

@swxldlxxns I am sorry, the domain donbosco.edu.ec is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


add matching on string value containing/not containing a substring with/without case matching to matchCriteria

Add testing for a string value containing/not containing a substring with/without case matching to satisfy matchCriteria

Resolved in v1.4.395


Stuck after promting "[INFO] Skipping NVD check since last check was within 4 hours."

I installed the certificates and the update when smoothly but its always stopping after the org.owasp.dependencycheck.data.update.EngineVersionCheck:143.
logs.txt

@ebraheem95 From the symptoms I suspect that you have a (proxied) network connectivity issue. It appears you can connect (otherwise you should get a connectTimeout after ten seconds), but never receive data when trying to obtain the 'latest version' information from https://jeremylong.github.io/DependencyCheck/current.txt.

While the root cause appears to be in your network connectivity it also classifies as a bug, as there should be a (configurable) timeout on the reads in addition to the timeout on the connect. DependencyCheck should not wait indefinitely for data that never shows up.

Thanks a lot, its true that was the issue. I changed the network and everything worked fine.


Custom file link

Rework links shape :

https://example.com/i/abcdefghij : File code
https://example.com/c/my-custom-slug : Custom link
https://example.com/g/gallery-name : Gallery link


use AbstractMessage: super of GeneratedMessage

To be compatible with proto 2 and 3 compiled message classes.  Upgrade compiler to v3.3.0
Suggested solution to https://github.com/spotify/ratatool/issues/31.  Maybe it would be better to include implementation for builders and instead change this to GeneratedMessageV3 for .asInstanceOf[] calls?
@idreeskhan

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   72.19%   72.19%
=======================================
  Files          26       26
  Lines         917      917
  Branches      119      119
=======================================
  Hits          662      662
  Misses        255      255

Impacted Files
Coverage Δ

...in/scala/com/spotify/ratatool/diffy/BigDiffy.scala
50.45% <ø> (ø)
:arrow_up:

...potify/ratatool/generators/ProtoBufGenerator.scala
90.24% <ø> (ø)
:arrow_up:

.../com/spotify/ratatool/scalacheck/ProtoBufGen.scala
100% <ø> (ø)
:arrow_up:

...ala/com/spotify/ratatool/diffy/ProtoBufDiffy.scala
96.29% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d1961...018037d. Read the comment docs.

I think this looks good. Probably better to maintain resemblance with other Diffy, and the asInstanceOf should still invoke subclass method here. 👍


suggestion: generate document automatically?

I found I can use typedoc to generate 'JSDOC style comment' into document .

If I can use ng doc to generate document automatically.
I think it must be better!

Related #102

@dtesta is right, this one is a dupe of https://github.com/angular/angular-cli/issues/102.


Support L2TP/IPsec

Wow, this is a really nice, useful tool for easy automated connection setup -- but the OpenVPN protocol is very compute-intensive, and CPU overload becomes a data throughput bottleneck on ARM platforms.  Can you add support for L2TP/IPsec to increase performance ?

This project has been designed around OpenVPN. Support for alternative protocols / tools would be very hard to add without increasing the complexity of the codebase. And from what I could gather, L2TP/IPsec is not the easiest thing to setup on a Linux system.
Unfortunately, I'm not actively working on this project any more. I don't really have the time to look into implementing additional features to a tool which works well enough already. However, I'm willing to accept pull requests that implement L2TP/IPsec support in a clean fashion. But I cannot really provide any support with the actual implementation.


[wip] Remove objectAllocator concept

@typescript-bot perf test

That's quite good. Barely a change to the tsc benchmarks, but some nice improvements in the lsp benchmarks. I have a few other changes to try before taking this out of draft.

@typescript-bot perf test

@typescript-bot perf test

This perf test is to establish a baseline with the latest changes before I switch back from setting kind on the prototype to see if that makes a difference.
@typescript-bot perf test

I'm not expecting huge perf wins, since what would have been big wins ended up in #58045

@typescript-bot perf test

More memory overhead isn't good, though it isn't as bad as expected after moving most of the methods from services to compiler.

@typescript-bot perf test

Not happy with the memory overhead this incurs in some cases:

@typescript-bot perf test

@typescript-bot perf test

@typescript-bot perf test

@typescript-bot perf test

@typescript-bot perf test

@typescript-bot perf test

I still have a bit more investigating to do into the memory overhead in self-build-src-public-api, but this is close enough to turn it into an actual PR.

this is close enough to turn it into an actual PR.

The title is still [WIP]; just making sure that I should definitely review this 😄


Minor clean up

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          93     93
  Branches       22     22
=====================================
  Hits           93     93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80562b3...fac80ef. Read the comment docs.


core: backport missing disabled styles

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

Backport of https://github.com/vmware/clarity/pull/4957
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Closing in favor of https://github.com/vmware/clarity/pull/4974


ShapeShift Native Wallet - Only prompt password entry if necessary

Overview
Currently on app.shapeshift.com, native wallet users are prompted to enter their password every time they visit or refresh the app. Ideally, users should have to enter their password minimally, like the first time they are signing a transaction per session. Further, if a user has already unlocked their wallet to sign a tx and then refreshes the page, ideally they don't have to unlock their wallet again to sign another tx.
Q for engineering and security:

Are the AC below reasonable to implement?
Any better ideas for how to improve this UX?

References and additional details
n/a
Acceptance Criteria
AC:

Users are only prompted to enter their native wallet password when they are connecting their wallet for the first time on a browser or signing a tx
Users can see their native wallet's data and interact with the web app while their wallet is 'locked'
If a user's native wallet is 'unlocked' and they refresh the page, their native wallet is still unlocked

Need By Date
I know there are ongoing discussions about native wallet's future, so no rush on this, esp. if it is one of those things that's easier said than done. I defer to engineering on whether it makes sense to prioritize this rn.
Screenshots/Mockups
No response
Estimated effort
needs engineering

marking as low priority due to complexity and potential for deprecation of native wallet.

I have to write the spec for this but i have the scope.


关系图，能否给连线添加一种类型，使之不受力引导的影响

What problem does this feature solve?
当在关系图中标明一种额外关系的时候，而且不希望原关系图重绘
尝试使用graphic实现时，关系图会无意义的乱动 https://gallery.echartsjs.com/editor.html?c=xSxErcPoB
What does the proposed API look like?
line增加可选参数，使之不受力引导的影响

@TYzzt Do you mind making a pull request about this?

Similar to https://github.com/apache/incubator-echarts/issues/11024

@TYzzt Do you mind making a pull request about this?

https://github.com/apache/incubator-echarts/pull/11445

Similar to #11024

it can solve some problems, but not what I want

@TYzzt Thanks for your contribution! We will review it soon.


OCPBUGS-13763: dont log jwt tokens

What
Bump library-go to https://github.com/openshift/library-go/pull/1523.
Why
It removes token from the logging.

Waiting for https://github.com/openshift/library-go/pull/1533

/retest-required

@ibihim the bug attached to this PR seems to be closed. Should we perhaps also close this PR?

@dgrisonnet, I think the jira got closed and another got re-opened. I changed the target Jira.

/label backport-risk-assessed

/label cherry-pick-approved


[IR] Missing check for dependency passes in SequentialNode::operator()

Problem
In SequentialNode::operator(), before executing each passes, we do not check if their own dependency passes are all enabled:
IRModule SequentialNode::operator()(IRModule mod, const PassContext& pass_ctx) const {
  for (const Pass& pass : passes) {
    CHECK(pass.defined()) << "Found undefined pass for optimization.";
    const PassInfo& pass_info = pass->Info();
    if (!PassEnabled(pass_info)) continue; // THE PROBLEM: only check pass itself
    // resolve dependencies
    for (const auto& it : pass_info->required) {
      mod = GetPass(it)(std::move(mod), pass_ctx);
    }
    mod = pass(std::move(mod), pass_ctx);
  }
  return mod;
}

Suggestion
In the loop shown above, add PassEnabled() call for all dependency passes.

In this particular case, I think the behavior is expected. Because the dependency itself might be required in order to run the pass


[BUG] Chapter 17 Colab notebook is missing the solutions to q's 10 and 11

Thanks for helping us improve this project!
Before you create this issue
Please make sure you are using the latest updated code and libraries: see https://github.com/ageron/handson-ml2/blob/master/INSTALL.md#update-this-project-and-its-libraries
Also please make sure to read the FAQ (https://github.com/ageron/handson-ml2#faq) and search for existing issues (both open and closed), as your question may already have been answered: https://github.com/ageron/handson-ml2/issues
Describe the bug
Please provide a clear and concise description of what the bug is, and specify the notebook name and the cell number at which the problem occurs (or the chapter and page in the book).
To Reproduce
Please copy the code that fails here, using code blocks like this:
def inverse(x):
    return 1 / x

result = inverse(0)

And if you got an exception, please copy the full stacktrace here:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 2, in inverse
ZeroDivisionError: division by zero

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information):

OS: [e.g. MacOSX 10.15.7]
Python: [e.g. 3.7]
TensorFlow: [e.g., 2.4.1]
Scikit-Learn: [e.g., 0.24.1]
Other libraries that may be connected with the issue: [e.g., gym 0.18.0]

Additional context
Add any other context about the problem here.

Chapter 17 Colab notebook is missing the solutions to q's 10 and 11. Each just has 3 blank cells. Is this on purpose or just missed?


kfp charms fail with unknown container reason "ContainerStatusUnknown": The container could not be located when the pod was terminated

Testrun https://solutions.qa.canonical.com/testruns/testRun/71ccb76a-4c34-4293-9c2d-cc139a9898c6 fails with the following status:
Model     Controller       Cloud/Region                Version  SLA          Timestamp
kubeflow  foundations-k8s  kubernetes_cloud/us-east-1  2.9.34   unsupported  14:45:38Z

App                        Version                    Status   Scale  Charm                    Channel         Rev  Address         Exposed  Message
admission-webhook          res:oci-image@84a4d7d      active       1  admission-webhook        1.6/stable       50  <IP_ADDRESS>   no
argo-controller            res:oci-image@669ebd5      active       1  argo-controller          3.3/stable       99                  no
dex-auth                                              active       1  dex-auth                 2.31/stable     129  <IP_ADDRESS>   no
istio-ingressgateway                                  active       1  istio-gateway            1.11/stable     114  <IP_ADDRESS>  no
istio-pilot                                           waiting      1  istio-pilot              1.11/stable     131  <IP_ADDRESS>   no       installing agent
jupyter-controller         res:oci-image@8f4ec33      active       1  jupyter-controller       1.6/stable      138                  no
jupyter-ui                 res:oci-image@cde6632      active       1  jupyter-ui               1.6/stable       99  <IP_ADDRESS>   no
kfp-api                    res:oci-image@1b44753      active       1  kfp-api                  2.0/stable       81  <IP_ADDRESS>   no
kfp-db                     mariadb/server:10.3        active       1  charmed-osm-mariadb-k8s  latest/stable    35  <IP_ADDRESS>    no       ready
kfp-persistence            res:oci-image@31f08ad      waiting    2/1  kfp-persistence          2.0/stable       76                  no
kfp-profile-controller     res:oci-image@d86ecff      active       1  kfp-profile-controller   2.0/stable       61  <IP_ADDRESS>   no
kfp-schedwf                res:oci-image@51ffc60      active       1  kfp-schedwf              2.0/stable       80                  no
kfp-ui                     res:oci-image@55148fd      active       1  kfp-ui                   2.0/stable       80  <IP_ADDRESS>  no
kfp-viewer                 res:oci-image@7190aa3      active       1  kfp-viewer               2.0/stable       79                  no
kfp-viz                    res:oci-image@67e8b09      waiting    2/1  kfp-viz                  2.0/stable       74  <IP_ADDRESS>   no
kubeflow-dashboard         res:oci-image@6fe6eec      active       1  kubeflow-dashboard       1.6/stable      154  <IP_ADDRESS>  no
kubeflow-profiles          res:profile-image@0a46ffc  active       1  kubeflow-profiles        1.6/stable       82  <IP_ADDRESS>  no
kubeflow-roles                                        active       1  kubeflow-roles           1.6/stable       31  <IP_ADDRESS>  no
kubeflow-volumes           res:oci-image@cc5177a      active       1  kubeflow-volumes         1.6/stable       64  <IP_ADDRESS>  no
metacontroller-operator                               active       1  metacontroller-operator  2.0/stable       48  <IP_ADDRESS>  no
minio                      res:oci-image@1755999      active       1  minio                    ckf-1.6/stable   99  <IP_ADDRESS>   no
oidc-gatekeeper            res:oci-image@32de216      active       1  oidc-gatekeeper          ckf-1.6/stable   76  <IP_ADDRESS>  no
seldon-controller-manager  res:oci-image@eb811b6      active       1  seldon-core              1.14/stable      92  <IP_ADDRESS>  no
training-operator                                     active       1  training-operator        1.5/stable       65  <IP_ADDRESS>   no

Unit                          Workload  Agent      Address          Ports              Message
admission-webhook/0*          active    idle       <IP_ADDRESS>   4443/TCP
argo-controller/0*            active    idle       <IP_ADDRESS>
dex-auth/0*                   active    idle       <IP_ADDRESS>
istio-ingressgateway/0*       active    idle       <IP_ADDRESS>
istio-pilot/0*                waiting   idle       <IP_ADDRESS>                     Waiting for gateway address
jupyter-controller/0*         active    idle       <IP_ADDRESS>
jupyter-ui/0*                 active    idle       <IP_ADDRESS>  5000/TCP
kfp-api/0*                    active    executing  <IP_ADDRESS>  8888/TCP,8887/TCP
kfp-db/0*                     active    idle       <IP_ADDRESS>  3306/TCP           ready
kfp-persistence/0*            error     idle       <IP_ADDRESS>                      unknown container reason "ContainerStatusUnknown": The container could not be located when the pod was terminated
kfp-persistence/1             waiting   executing  <IP_ADDRESS>                     Waiting for leadership
kfp-profile-controller/0*     active    idle       <IP_ADDRESS>  80/TCP
kfp-schedwf/0*                active    idle       <IP_ADDRESS>
kfp-ui/0*                     active    idle       <IP_ADDRESS>  3000/TCP
kfp-viewer/0*                 active    idle       <IP_ADDRESS>
kfp-viz/0*                    error     idle       <IP_ADDRESS>   8888/TCP           unknown container reason "ContainerStatusUnknown": The container could not be located when the pod was terminated
kfp-viz/1                     waiting   executing  <IP_ADDRESS>  8888/TCP           Waiting for leadership
kubeflow-dashboard/0*         active    idle       <IP_ADDRESS>   8082/TCP
kubeflow-profiles/0*          active    idle       <IP_ADDRESS>  8080/TCP,8081/TCP
kubeflow-roles/0*             active    idle       <IP_ADDRESS>
kubeflow-volumes/0*           active    idle       <IP_ADDRESS>  5000/TCP
metacontroller-operator/0*    active    idle       <IP_ADDRESS>
minio/0*                      active    idle       <IP_ADDRESS>  9000/TCP,9001/TCP
oidc-gatekeeper/0*            active    idle       <IP_ADDRESS>   8080/TCP
seldon-controller-manager/0*  active    idle       <IP_ADDRESS>  8080/TCP,4443/TCP
training-operator/0*          active    idle       <IP_ADDRESS>

So kfp-viz and kfp-persistence are in an error state. It seems like juju tried to spin up a new instance of both of them, but failed with the message: unknown container reason "ContainerStatusUnknown": The container could not be located when the pod was terminated.
I can't find why this is happening. This could very well be a kubernetes or juju issue, so feel free to move this bug to one of those projects.
Logs and configs can be found here:
https://oil-jenkins.canonical.com/artifacts/71ccb76a-4c34-4293-9c2d-cc139a9898c6/index.html

Hello @Basdbruijne, this definitely seem like a Kubernetes issue, can you please open it in their project? I will close it here for now.

Bug is moved to LP: #1991326


Verify Signature example that works in Objective-C project.

We have been struggling on this issue with no luck. It works fine in your Swift example, but cant get it to work in the Obj-C project.

Please post more information. Are you verifying the signature on server or in app?

Im trying in app, by SecKeyRawSign:
SecKeyRef publicKey = [self lookupECCPublicKeyRef];
uint8_t digest[CC_SHA256_DIGEST_LENGTH];
CC_SHA256([inputData bytes], (CC_LONG)[inputData length], digest);
OSStatus status = SecKeyRawVerify(publicKey,
                                  kSecPaddingPKCS1SHA256,
                                  digest,
                                  CC_SHA256_DIGEST_LENGTH,
                                  (uint8_t*)[sig bytes],
                                  [sig length]);

From skimming the code it seems like they are casting wrongly in lookupPublicKey. You can try with this (haven't tested it myself):
+ (CFDictionaryRef) lookupPublicKey // <------- changed this
{
  CFMutableDictionaryRef getPublicKeyQuery = newCFDict;
  CFDictionarySetValue(getPublicKeyQuery, kSecClass,                kSecClassKey);
  CFDictionarySetValue(getPublicKeyQuery, kSecAttrKeyType,          kSecAttrKeyTypeEC);
  CFDictionarySetValue(getPublicKeyQuery, kSecAttrApplicationTag,   kPublicKeyName);
  CFDictionarySetValue(getPublicKeyQuery, kSecAttrKeyClass,         kSecAttrKeyClassPublic);
  CFDictionarySetValue(getPublicKeyQuery, kSecReturnData,           kCFBooleanTrue);
  CFDictionarySetValue(getPublicKeyQuery, kSecReturnRef,  kCFBooleanTrue); // <--------- added this
  CFDictionarySetValue(getPublicKeyQuery, kSecReturnPersistentRef,  kCFBooleanTrue);

  OSStatus status = SecItemCopyMatching(getPublicKeyQuery, (CFTypeRef *)&publicKeyRef);
  if (status == errSecSuccess)
    return (CFDictionaryRef)publicKeyRef; // <------- changed this
  else if (status == errSecItemNotFound)
    return nil;
  else
    [NSException raise:@"Unexpected OSStatus" format:@"Status: %i", status];
  return false;
}

Then you can
CFDictionaryRef publicKeyDict = [self lookupPublicKey];
SecKeyRef publicKey = (SecKeyRef) CFDictionaryGetValue((CFDictionaryRef)publicKeyDict, kSecValueRef);

@kragekjaer when adressing issues here on github it is much easier if you can provide as much info as possible.

Perfect. It works. Thank you very much.

Cool. Glad I could help. See ya

I was a bit quick to say it works. The returned public key:
CFDictionaryRef publicKeyDict = [self lookupPublicKey];
SecKeyRef publicKey = (SecKeyRef) CFDictionaryGetValue((CFDictionaryRef)publicKeyDict, kSecValueRef);
is (null)

Please post more code. Did you use my new implementation of lookup public key?

Hi again, here si s the code Im using

(CFDictionaryRef) lookupECCPublicKeyRef
{
CFMutableDictionaryRef getPublicKeyQuery = newCFDict;
CFDictionarySetValue(getPublicKeyQuery, kSecClass,                kSecClassKey);
CFDictionarySetValue(getPublicKeyQuery, kSecAttrKeyType,          kSecAttrKeyTypeEC);
CFDictionarySetValue(getPublicKeyQuery, kSecAttrApplicationTag,   kPublicKeyName);
CFDictionarySetValue(getPublicKeyQuery, kSecAttrKeyClass,         kSecAttrKeyClassPublic);
CFDictionarySetValue(getPublicKeyQuery, kSecReturnData,           kCFBooleanTrue);
CFDictionarySetValue(getPublicKeyQuery, kSecReturnPersistentRef,  kCFBooleanTrue);
CFDictionarySetValue(getPublicKeyQuery, kSecAttrCanVerify,        kCFBooleanTrue);
OSStatus status = SecItemCopyMatching(getPublicKeyQuery, (CFTypeRef *)&publicECCKeyRef);
if (status == errSecSuccess)
{
return (CFDictionaryRef)publicECCKeyRef;
}
else if (status == errSecItemNotFound)
{
return nil;
}
else
[NSException raise:@"Unexpected OSStatus" format:@"Status: %i", (int)status];
return false;
}

+(void) verifyECCSignature:(NSData *) inputData signature:(NSData *) sig{
CFDictionaryRef publicKeyDict = [self lookupECCPublicKeyRef];
CFDictionaryRef publicKey = CFDictionaryGetValue((CFDictionaryRef)publicKeyDict, kSecValueRef);

NSLog(@"public key: %@", publicKey );

uint8_t digest[CC_SHA256_DIGEST_LENGTH];
CC_SHA256([inputData bytes], (CC_LONG)[inputData length], digest);
OSStatus status = SecKeyRawVerify((SecKeyRef)publicKey,
                                  kSecPaddingPKCS1SHA256,
                                  digest,
                                  CC_SHA256_DIGEST_LENGTH,
                                  (uint8_t*)[sig bytes],
                                  [sig length]);

NSLog(@"SUCCESS? Verifying %d", (int)status);

}

Awesome. Thanks. Seems like you didn't copy the whole method. This part is missing from lookupECCPublicKeyRef
  CFDictionarySetValue(getPublicKeyQuery, kSecReturnRef,  kCFBooleanTrue); // <--------- added this

Please verify that SecKeyRef publicKey = (SecKeyRef) CFDictionaryGetValue((CFDictionaryRef)publicKeyDict, kSecValueRef); is not null

Its working, sorry for not being observant. Thanks again

Glad to hear that


Improving the formatting on the Testing custom queries (CodeQL) page

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/code-security/codeql-cli/using-the-codeql-cli/testing-custom-queries
What part(s) of the article would you like to see updated?
I would like to see the Java code block updated and the formatting below it fixed, they appear in pre / code-blocks when they shouldn't.
Additional information

@nicholas-keers Thank you for opening an issue and linking it to your PR! ✨


Clone xgboost  failed & pip3 install xgboost failed.

For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System:
MacOS Sierra 10.12.4 (16E195)
Compiler:
MacBook-Pro% gcc --version
gcc (Homebrew gcc 6.1.0 --without-multilib) 6.1.0
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Package used (python/R/jvm/C++):
NaN
xgboost version used:
NaN
If you are using python package, please provide
python version : Python 3.6.1 (v3.6.1:69c0db5050, Mar 21 2017, 01:21:04)
Steps to reproduce
1.First Try : Follow the official instruction : (1) upstate the compiler gcc by brew gcc 6.1.0 --without-     multilib (2) install xgboost by pip : pip3 install xgboost
error : Command "python setup.py egg_info" failed with error code 1 in...
log.pdf
2.Second Try : Follow the instruction link
but in the first step : clone the xgboost by git clone --recursive https://github.com/dmlc/xgboost. It was stuck into the line : Cloning into '/Users/wzj/xgboost/cub'... .When I force the git process to stop,
it shows : ^Cwarning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'
Thanks in advance !

I got this error too but this workaround seemed to fix it (from #1501 ).

I suggest using Docker for this purposes. You can install it on windows 10 as given in description here.
You can work using xgboost library along with other essential data science libraries using Docker.  This Dockerfile can be used for the process. Else, you can also try using datmo in order setup environment and track machine learning projects for making it reproducible.

@shabazpatel I have taken your advice. @Marto32 Also thanks for your participation, thank you!

@shabazpatel I have taken your advice , @Marto32 Also thanks for your suggestion , thank you!

@shabazpatel I have taken your advice , @Marto32 Also thanks for your suggestion , thank you!  :)


Add Instance type option to the brkt-cli

Any suggestions on how to add the instance type validation?
Also, should the entered instance type be used for the volume encryptor instance as well?

This looks good.  My only concern is whether we think that this option really is useful to customers.  If it's for internal testing, we shouldn't expose it.  Fewer knobs to turn is generally a good thing.

Krishnan and I agreed to close this pull request because there's no short-term need.


Port to Eto.Forms

As discussed here https://github.com/Mapsui/Mapsui/discussions/1524
Please have a look and let me know if anything missing
(nuspec and CI is missing and should probably be done seperatly?)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Had to approve the full build run.

A nuspec file would be great. You can look into the Nuspec folder to see how it should be made. (Copy an existing one for example)

For CI integration should I make a pull request on your branch or change it in this pull request?

Either way is fine for CI - just updating directly is probably easiest for you (?)

I'll merge this if the LangVersion and the Dispose (DeRegister Events is handled)

I think I adressed the things you pointed out (except the eventhandler deregistering which I am not sure is needed)
Also added nuspec (not tested) ; hopefully I got it right, please double-check that it looks OK

Merging this now

path to eto nuget package
https://github.com/Mapsui/Mapsui/suites/5479049914/artifacts/174767453

Thanks for the support ;-)


2.4.1 update issue

After 2.4.1 update you bumped Kotlin version to 2.1 and it's mandatory for project to use it have that version. Would it be possible to go back to old version?

2.4.2 is out, lowered it back down


Don't close the class loader that is going to be used in functions

Otherwise it can't load any more classes at runtime, which is
obviously a bad thing.

Nice catch! Thanks Dave.


tests for perl library DBIx-Class fail (which causes hydra-unstable to not be able to be built)

Describe the bug
It appears that the tests for the Perl library DBIx-Class are failing on master.  I noticed this when trying to use hydra-unstable:
$ nix repl ./.
nix-repl> hydra-unstable
«derivation /nix/store/hzp3bpdxvh9srz8yxx46sp3kwyqayrll-hydra-2021-08-11.drv»
nix-repl> :b hydra-unstable
error: builder for '/nix/store/2hk7n3zl8fa57d1li0hjgdmmcci57g8m-perl5.34.0-DBIx-Class-0.082842.drv' failed with exit code 2;
       last 10 log lines:
       >   Non-zero exit status: 2
       > t/64db.t                                          (Wstat: 256 Tests: 4 Failed: 1)
       >   Failed test:  4
       >   Non-zero exit status: 1
       > t/sqlmaker/limit_dialects/generic_subq.t          (Wstat: 0 Tests: 19 Failed: 0)
       >   TODO passed:   9, 11, 13, 15, 17
       > Files=325, Tests=42256, 103 wallclock secs ( 2.07 usr  0.78 sys + 73.24 cusr 27.71 csys = 103.80 CPU)
       > Result: FAIL
       > Failed 2/325 test programs. 3/42256 subtests failed.
       > make: *** [Makefile:1370: test_dynamic] Error 255
       For full logs, run 'nix log /nix/store/2hk7n3zl8fa57d1li0hjgdmmcci57g8m-perl5.34.0-DBIx-Class-0.082842.drv'.
error: 1 dependencies of derivation '/nix/store/vq6g113lj0mz1g8cqy8xckli3a0z545c-hydra-perl-deps.drv' failed to build
error: 1 dependencies of derivation '/nix/store/hzp3bpdxvh9srz8yxx46sp3kwyqayrll-hydra-2021-08-11.drv' failed to build

This is on commit c7be038ad1da4196f0 (which is master as of 2021-12-27).
I can give the full build output if necessary.
Notify maintainers
Unfortunately it doesn't look like DBIxClass itself has any maintainers.  I'm not sure who the main Perl maintainers are.
hydra-unstable also doesn't have any maintainers, but the NixOS Hydra tests do have some maintainers: @pstn @nlewo @Ma27
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.81, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5pre20211126_55275fc`
 - channels(root): `"nixos-21.11.334247.573095944e7"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Huh. First Time I've heard about being a maintainer of anything hydra. Seems like I was added in the first iteration of that test. I have no idea why and I'm going to go ahead and remove myself.
@nlewo Do you know what happened here? https://github.com/NixOS/nixpkgs/commit/47fc27b4562042bc309ff369c0369f001adb9ef0

Should be fixed by #152207

Thanks, looks like this is fixed by #152207.


[Apiserver-Proxy] Readiness probe fails

How to categorize this issue?

/area networking
/kind bug
What happened:
We've regularly seen issues with at least one apiserver-proxy pod in shoot clusters that does not get ready and remains in this state until the pod is deleted/restarted.
Events:
  Type     Reason     Age                      From     Message
  ----     ------     ----                     ----     -------
  Warning  Unhealthy  105s (x9659 over 5h25m)  kubelet  Readiness probe failed: Get "http://<IP_ADDRESS>:16910/ready": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

What you expected to happen:
The apiserver-proxy pod  to get ready.
How to reproduce it (as minimally and precisely as possible):
Not certain at the moment.
Anything else we need to know?:
The container is heavily throttled and the /ready is probably not able to respond.

Interestingly, after the pod is deleted the new one is not throttled.
Environment:

Gardener version: v1.41.2
Kubernetes version (use kubectl version): v1.21.7

/cc @DockToFuture @ScheererJ

Envoy proxy from the proxy container does not seem to have come up correctly, i.e. neither the port for forwarding to the kube-apiserver nor the metrics port are open.

It looks like the envoy proxy hangs in some kind of busy loop as it continuously consumes cpu time.

strace shows that the envoy proxy container is repeatedly calling sched_setaffinity.
sched_setaffinity(0, 128, [12])         = 0
 > /usr/glibc-compat/lib/libc.so.6() [0xe5af9]
 > /usr/local/bin/envoy() [0x3a9470a]
 > /usr/local/bin/envoy() [0x3a6fb96]
 > /usr/local/bin/envoy() [0x3a6fa00]
 > /usr/local/bin/envoy() [0x3a6e89d]
 > /usr/local/bin/envoy() [0x3a6e426]
 > /usr/local/bin/envoy() [0x3a6bc7a]
 > /usr/local/bin/envoy() [0x3b075ae]
 > /usr/local/bin/envoy() [0x3a6f534]
 > /usr/local/bin/envoy() [0x3b04e7d]

gdb paints a similar picture.
(gdb) bt
#0  0x00007f9c81b7daf9 in sched_setaffinity () from target:/usr/glibc-compat/lib/libc.so.6
#1  0x000055f5f9c422b5 in ?? ()
#2  0x000055f5f9c4270a in ?? ()
#3  0x000055f5f9c1db96 in ?? ()
#4  0x000055f5f9c1da00 in ?? ()
#5  0x000055f5f9c1c89d in ?? ()
#6  0x000055f5f9c1c426 in ?? ()
#7  0x000055f5f9c19c7a in ?? ()
#8  0x000055f5f9cb55ae in ?? ()
#9  0x000055f5f9c1d534 in ?? ()
#10 0x000055f5f9cb2e7d in ?? ()
#11 0x00007f9c81abec1c in __libc_start_main () from target:/usr/glibc-compat/lib/libc.so.6
#12 0x000055f5f765ae6a in ?? ()

The envoy code base does not seem to have a direct call to sched_setaffinity.
We will address the issue with a liveness probe and restart the container if it does not come up in 30 seconds (#5544).


Fix api reverse proxy

Steps to test:

check out PR branch.
build and run the project.
$ docker-compose up -d --build
view the api docs.
$ open http://localhost:8080/api
down the project.
$ docker-compose down -v


cmd/statediff: temporarily cease commenting until UX resolution on co…

…mmenting
Temporarily turns off processing and commenting until we've resolved the user experience (UX) for how to notify on state changes and the respective lines.
Updates #3

Just a kind FYI to @elias-orijtech @tac0turtle


Support for VectorCoefficient and MatrixCoefficient with VectorDiffusionIntegrator [wcdawn/nonscalar-VectorDiffusionCoeficient]

Add support for nonscalar coefficients (VectorCoefficient and MatrixCoefficient) for use with class VectorDiffusionCoefficient.
This was needed to model multigroup neutron diffusion related to #1637.
Resolves #1637

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1727
@wcdawn
@tzanio
@stefanozampini + @rw-anderson
08/30/20
⌛due 01/08/21
⌛due 01/15/21

@stefanozampini and @rw-anderson -- your reviews on this PR are overdue

Second reminder: @stefanozampini and @rw-anderson -- your reviews on this PR are overdue

Can you please merge master and resolve the conflicts?

I agree this seems pretty broken.
I tried to fix it and broke it more...
Do you have a recommendation or should I create a new PR?

I've created a new branch nonscalar-VectorDiffusionIntegrator (without my username) that only has one commit on it as it should. If this is acceptable, I can create a new PR for that branch.

We can use the new branch to overwrite this branch by force pushing -- that way the PR history here will be preserved. @tzanio, do you want to do that?

Ok, I force-pushed from nonscalar-VectorDiffusionIntegrator.
@wcdawn, can you double-check that everything looks ok?

You can update your local copy of this branch with:
> git fetch origin wcdawn/nonscalar-VectorDiffusionIntegrator
> git checkout -B wcdawn/nonscalar-VectorDiffusionIntegrator origin/wcdawn/nonscalar-VectorDiffusionIntegrator

By the way, the branch https://github.com/mfem/mfem/tree/nonscalar-VectorDiffusionIntegrator can now be deleted -- at the moment it points to the same commit as https://github.com/mfem/mfem/tree/wcdawn/nonscalar-VectorDiffusionIntegrator (this PR's branch).

Looks good to me! I've also deleted the other branch per @v-dobrev comment.
Thanks!

@stefanozampini and @rw-anderson -- can you please take another look?

ping: @stefanozampini, @rw-anderson

ping: @stefanozampini, @rw-anderson

Is there any update on this? I need this for my work and having everything in master would make my work much easier. Thanks!

Is there any update on this? I need this for my work and having everything in master would make my work much easier. Thanks!

Merged in next for testing...

Merged in next for testing...


Case-sensitive Name and List Separators in BibTeX Plugin

The name list separator and list separator of plugin-bibtex seem to be case sensitive (see packages/plugin-bibtex/src/input/value.js#L35) whereas the implementation used by bibtex and biber is case insensitive. This leads to names being incorrectly parsed when separated by an uppercase AND as shown in the example code below.
This behavior may be intended, as the biblatex spec is a bit vague on this matter, but it might be better to share the behavior of biber and bibtex. To fix this behavior it might be as simple as changing adding the i modifier to the and regex, but I haven't tested this.

What version of Citation.js are you using?
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>How are you running Citation.js (npm package, browser bundle, self-rolled bundle, webpack)?
npm package
Where are you running Citation.js? * The OS usually will not matter much, but the browser really does.
node v19.4.0
What is your input data and code?

const { Cite, plugins } = require('@citation-js/core');
require('@citation-js/plugin-bibtex');

const bibtex = `
@inproceedings{10.1145/1499402.1499562,
author = {Lesk, M. E. AND Kernighan, B. W.},
title = {Computer Typesetting of Technical Journals on UNIX},
year = {1977},
isbn = {9781450379144},
publisher = {Association for Computing Machinery},
address = {New York, NY, USA},
url = {https://doi.org/10.1145/1499402.1499562},
doi = {10.1145/1499402.1499562},
booktitle = {Proceedings of the June 13-16, 1977, National Computer Conference},
pages = {879–888},
numpages = {10},
location = {Dallas, Texas},
series = {AFIPS '77}
}`;

const citation = new Cite(bibtex);
console.log(citation.data[0].author);

What did you expect to happen, and what actually happened?
expected output:

[
  { given: 'M. E.', family: 'Lesk' },
  { given: 'B. W.', family: 'Kernighan' }
]

actual output:
[ { given: 'B. W.', family: 'Lesk', suffix: 'M. E. AND Kernighan' } ]

I think it's slightly more difficult because moo, the lexer library, probably can't handle that.


[ar] Probabilities and Statistics

I'm working on translating Probability file to Arabic

@moun3imy Thanks for helping us out!
I noticed that a PR about this cheatsheet is already open at #26. I propose that we focus our efforts there to avoid any overlap.

@shervinea  yeah it's dated to 16 Sep it's been a while now

Let's first wait for a day to see what @slashtea thinks about it. It is important not to discard valuable previous work and their contributors.

Hi @moun3imy, what is the status of this PR?

Closing this PR as the translation continues in #182.


Maintain total opacity

This is a work-in-progress - it breaks SVG support, and probably some other stuff!
In order to maintain the correct total opacity throughout a transition (i.e. if both start and end are at 100%, it should be 100% in the middle - currently, at the halfway point both are at 50% opacity, resulting in a total opacity of 75%), we have to make some fairly fundamental changes to how ramjet works.
Rather than creating siblings of the two elements, the clones are placed in a container of their own and placed at the end of the document. Then, the from element maintains an opacity of 100% while the to element fades in, while the container transitions from the from opacity to the to opacity.
So we get this...

...instead of this:

(Kudos to @williammalo for figuring out how to make this work.)
Because the clones are now well and truly detached from their parent elements, we have to jump through some hoops to correctly position them - we have to find the cumulative transform and opacity for both. This aspect isn't currently well tested, but in theory it provides a foundation for more sophisticated effects, such as transitions between already-transformed elements.
Still to do:

[ ] Reinstate SVG support
[ ] Use matrix transformations all the way down, rather than concatenating strings. We may be able to unify the SVG and HTML approaches here. It might even be possible to do stuff like transitioning between rotated elements, via matrix decomposition
[ ] This technique requires an element to be overlaid over the rest of the DOM, meaning mouse events are intercepted. In most browsers that's not a problem, because of pointer-events: none, but in IE that's not supported, so we need to forward those events using document.elementFromPoint.

YAY!

This works for me, any chance of getting it merged?
One question, should the from/to elements be hidden whilst the animation runs?


Fix the broken test

$ go test google.golang.org/api/...
# google.golang.org/api/transport/bytestream
transport/bytestream/client_test.go:148: Errorf format %s has arg n2 of wrong type int

I haven't been able to reproduce this error. Is this something a go get -u would fix?
I don't know much about go gotten packages. I break my tests all the time when I make edits in $GOPATH.


Add frxETH / WETH polygon to allowlist

frxETH / WETH polygon whitelist

Closing in favour of #2652, had to bump version again and lock file needs to be updated too.


Running control-service for the first time without any modifications is broken

Describe the bug
When you check out control-service for the first time and try to run it, it does not work unless you have a local k8s running.
Steps To Reproduce
Steps to reproduce the behavior:

Open versatile-data-kit/projects/control-service in IntelliJ
Remove all currently running k8s clusters from your system
Make sure you have no changes in control-service/projects/pipelines_control_service/src/main/resources/application.properties
Try to run control-service/projects/pipelines_control_service/src/main/java/com/vmware/taurus/ServiceApp.java
See error:
Caused by: java.lang.NullPointerException: null
at io.kubernetes.client.util.ClientBuilder.kubeconfig(ClientBuilder.java:225)
at com.vmware.taurus.service.KubernetesService.afterPropertiesSet(KubernetesService.java:231)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1845)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1782)
... 71 common frames omitted

Expected behavior
The service should run without the need to set up a k8s cluster. If this is not possible, setting up the local k8s should be mentioned in the documentation as a prerequisite.

Triaged. Closed as stale.


Track bans and ban reasons on top of audit table

Have sweetiebot keep a record of all banned users and reasons associated with those users. She will alert the mods if someone is banned without a reason, but a reason can be added after the ban is made. the !ban command can be used to ban someone with a reason immediately.

Won't be implemented because discord itself is implementing this feature soon.


[Do Not Merge] Added module_version attribute for dsc_resource.

In-progress.
Adding module_version attribute support for dsc_resource resource to allow users to specify which version of a module (out of the multiple versions of a module installed) to use.

Done.


Configuring apps from the host (HostBuilder)

At this point we don't want to expand on this topic.


Context menu for many selected bytes in "Linear Disassembly" view

In the "Hex Editor" view, it is possible to select many bytes then right-click for a context menu for options on said bytes. In the "Linear Disassembly" view, you may select many bytes but a right-click acts as a left-click and deselects all the bytes (single bytes have a context menu). It should instead open a context menu to allow for operations on the selected bytes, such as "Copy As", etc. (i.e.: same functionality as the "Hex Editor" view)

Fixed in 1.1.1843

Thank you, works great. Is there a reason "Copy As" and friends are not available in the menu?

No its just something we didn't add to that view yet. Its something we should create an issue for.

Also several items should be hidden in the multiple-bytes context menu. They just work for a single byte and its confusing what it actually does when activated on a range of bytes.


Plugin tooltips API change - was this intentional?

Hi,
Recently, the tooltips for types in both the atom-typescript and omnisharp-atom plugins broke simultaneously.  In recent versions of atom, regardless of where the scroll position was in the file, the tooltips displayed by these plugins would be appropriate for what appeared at the top and leftmost "screenfull" of the file based on the mouse position.
For example:

The ICompilePromise tooltip was appropriate for that x position on line 17 of the file - not line 207.
We reported it here: https://github.com/TypeStrong/atom-typescript/issues/381 and came up with this fix: https://github.com/TypeStrong/atom-typescript/pull/384 which was adding these two lines in the code that determines the mouse position:
pixelPt.top += editor.displayBuffer.getScrollTop();
pixelPt.left += editor.displayBuffer.getScrollLeft();

These tooltips had been working correctly up until perhaps a week or two ago.  I suspect this was due to some sort of change in Atom to the output of getBoundingClientRect(), or editor.screenPositionForPixelPosition(), or editor.bufferPositionForScreenPosition().
My questions are - do you believe that this is correct, and if so, was this intentional?  Do you think this new behavior will stand or is it a bug?  To my knowledge atom-typescript didn't have any calls that were marked as deprecated prior to this bug emerging.
I looked through the recent patch notes and didn't see anything that sounds like it should have caused this problem.  Thanks.

Hello,
Same story for atom-fsharp plugin I create. From what I've seen I believe that editor.bufferPositionForScreenPosition() returns exactly same coordinates as it gets no matter how much editor is scrolled.

screenPositionForBufferPosition and vice-versa are referring to a different concept of "screen position" than you're thinking. They refer to "logical" screen position, meaning the row, column position after taking into account folds and soft wraps.
The actual position on screen is related to TextEditorElement::pixelPositionForScreenPosition. That did change recently due to a change in our rendering strategy. Previously we used one massive GPU texture that we translated up and down. Now we break the lines into tiles and shift the tiles around instead, so we don't have to have a massive, mostly empty GPU texture.
I'd suggest looking into overlay decorations. They seem like the could solve your problem. Absolute positioning over the content isn't going to work with this new scheme, but it was critical that we switched for performance and loading large files, since Chrome just gave up rendering anything beyond about 600k lines. If overlay decorations don't work, please articulate your use case and we'll see what we can do. Thanks!

I'm running into the same issue with this.
Use-case:
ide-haskell has a feature that it shows type of expression under mouse cursor. For that, I need to get buffer position for a given mousemove event position to pass to backend. I have used some math, screenPositionForPixelPosition and bufferPositionForScreenPosition to achieve this, but now it doesn't seem possible. Any suggestions?

Okay, after some research, TextEditorComponent.screenPositionForMouseEvent with TextEditor.bufferPositionForScreenPosition seems to work. Any caveats/downsides I should be aware of?

@lierdakil That should work. Our lines are now broken into tiles which are shifted on the GPU for performance reasons. We previously had one huge div that we translated on the GPU, now we have several small divs. This leads to faster scrolling but an unfortunate side effect is we lose the ability to work in absolute pixel positions relative to all of the lines. The screenPositionForMouseEvent method should account for scroll position correctly and therefore is a good way to go.

Great, thanks.


Update main.go easypki repository on import

Fix non-existing repository on import.

CILA signed.

Good catch, thank you :)


Test file content based recommendations

Refs: https://github.com/microsoft/vscode/issues/176768

[ ] win @alexr00
[ ] mac @DonJayamanne
[ ] linux @TylerLeonhardt

Complexity: 4
Create Issue

Note: Use fresh user data dir and extensions dir - Start from CLI using args --user-data-dir and --extensions-dir.
File based recommendations
Test following recommendations when a file is opened. Make sure following recommendations are shown only when the recommended extension is not installed.

Python extension is recommended for sample.py file
Docker extension is recommended for Dockerfile
Java extension pack is recommended for sample.java file

File content based recommendations
Test following recommendation is shown based on the content of the file

Install Python extension and Uninstall Jupyter Extension because it is included in Python extension.
Open a python file with following contents

print("HI")
#%%
print("cell")
#%%
print("something else")

Make sure Jupyter extension is recommended.
Make sure Jupyter extension is not recommended when

Python extension is not installed or
Python file does not contain text #%%
Jypyter extension is already installed

Workspace config based recommendations
Test following recommendations when a folder is opened

Open a repo from GitHub (make sure it does not has the file in the repo - .vscode/extensions.json.

Make sure workspace recommendation prompt is shown and the workspace recommendations has GitHub.vscode-pull-request-github and eamodio.gitlens extensions.

Open a folder that has .devcontainer/devcontainer.json file
Make sure workspace recommendation prompt is shown and the workspace recommendations has ms-vscode-remote.remote-containers extension

I'm blocked on testing "File content based recommendations" on https://github.com/microsoft/vscode/issues/177781.

@alexr00 Thanks for filing the bug, if you use fresh user data directory or a different profile and install python extension before opening the python file, you can verify file content based recommendations.

Tested, works well except with remote repos


Migrate GitHub Pages site to Material for MkDocs

Started on branch mkdocs.
Instructions here: https://squidfunk.github.io/mkdocs-material/getting-started/

once installed, serve locally by first activating the right Python environment and then mkdocs serve.

TODO:

[ ] Add a friendly (non-techie) video of the mobile app demo to the intro page

This is ready to deploy. I've added a CI workflow as per these instructions.

Deployment didn't work (with the theme correctly displayed) until I followed this advice.
In particular, this bit:

With the settings above, I'm not sure whether the CI for docs deployment is working. I doubt it because I'm using the alternative "manual" deployment method with the built site landing on the gh-pages branch.
In that case, to update the deployed site it's just:
mkdocs gh-deploy --force

Closing this and opening a new ticket for the demo video idea.


Array stride in uniform address space

Today I was trying to write this struct to a uniform buffer:
#[derive(ShaderType)]
pub struct MortonUniforms {
    lut: [u32; 4608],
    size_lut: [u32; 1 << (extended_morton_coder::SIZE_LUT_NUMBER_OF_BITS + 1)],
    morton_index_scale: f32,
    offset: Vec3,
    size_multiplier: f32,
    multiplier: Vec3,
}

This doesn't work because of lut and size_lut, with this error:
thread 'main' panicked at 'array stride must be a multiple of 16 (current stride: 4)', C:\Users\andre\.cargo\registry\src\index.crates.io-6f17d22bba15001f\encase-0.6.1\src\types\array.rs:47:17
I saw issue #40 , and that the solution is to "create your own newtype around an array and [...] derive them" using the impl_vector macro, but I was confused on how to use that macro or if it made sense in my situation considering I have a lot more than 4 elements.

In issue #40 they were trying to write a vec4 but in your case you do want to write an array. The issue is that the spec requires elements of arrays (in the uniform address space) to be at least 16 bytes. Based on the amount of elements you want to write, I'd pack them in vec4s (ex. lut: [UVec4; 1152],).


simplified instructions for creating a Safe

@Uxio0 bump to merge PR please.

@Uxio0 bump to merge PR please.

I've already approved, is it anything else left for me to do?


Do simple, working examples for draft.js methods exist anywhere?

Hi,
I've spent the past 4 days reading draft.js documentation, playing with code samples, etc. and by this stage, all I can really do is echo the sentiments of another user:

"Everything looks like a rocket-science. It's so crazy, tricky and hard to understand. Please, simplify it somehow.
Some code even doesn't work itself.
...I tried to console.log(editorState), but it shows some crazy, messy, unreadable and huge structure."

I understand web-based RTE is extremely complex and it's amazing what has already been accomplished with draft.js... but at the same time I thought the point of libraries/frameworks + open-source was to make it simple for others to build abstraction layers.
E.g I made my first goal to create a replace text function the "draft.js way" using Modifier.replaceText. Not only have I failed at this, but my search for examples returned only one semi-relevant post from 2016 (whose solution also didn't work). I can't tell if my code is wrong, the methods I'm using are outdated, or if there's a bug in draft.js itself... simply because up-to-date examples don't exist anywhere
Surely I am missing something? How can working examples for a project this big be almost non-existent? 😕 Many thanks if someone can point me in the right direction!

@jkhaui: Have you looked at https://github.com/nikgraf/awesome-draft-js? Some of the standalone editors, plugins and utilities appear pretty much up to date.

How can working examples for a project this big be almost non-existent?

I think that Draft.js suffers from the fact that Facebook allocates almost no resources to maintaining this project, since they consider it to be "very stable" (https://github.com/facebook/draft-js/issues/1193#issuecomment-408123192), while at the same time they don't allow anyone from outside Facebook to become a maintainer. It appears that @claudiopro is the current maintainer, so he might be able to elaborate on my outsider perspective.
But don't despair! Even though it takes some time to get used to the way things work with Draft.js, it is very flexible, and the goal you have set for yourself is certainly possible to achieve.

@robbertbrak thanks a lot for the response — makes me realise I'm not going crazy!
Yeah, I've been through awesome-draft-js. There's some great projects like Draftail and scholar-draft and I actually got helpful examples from their codebase. It's strange Facebook barely makes an effort on maintenance, especially for simple things like fixing sloppy grammar in the draft.js documentation. This project deserves a more professional image.
I agree. I need to invest more time to learn draft.js properly, I underestimated its learning curve :)

A tip-- Draft is based on a library named Immutable.js, as mentioned in the docs.  It's worth learning how to use that library (just the basics are necessary, like Maps, Sets), since most of the methods are derived from that library.
For example, if you want to see the EditorState's currentContent, you can't type editorState.currentContent like standard JS allows, but you need to type editorState.getCurrentContent().

Thank you @jf97! I'm embarrassed to say I did not even know that. Will definitely look into it.

@jkhaui I share your general sentiment but I think you should be careful not to underestimate the  complexity of something seemingly simple like replaceString. For example, if you’re replacing text as the user types, you most likely don’t want the user to be able to undo the replacement – and the replacement should happen right after they type something to be replaced (I think yours might be lagging a few character behind since you’re not using chars from handleBeforeInput). You might also want to do this when people paste as well as type. Or have both operations work slightly differently – e.g. be undo-able by typing but not by copy-pasting. Then you also need to think of what happens to styles / links if replacing text these are be applied on.
Generally the Draft.js API is quite low-level, which makes it possible to build pretty arbitrary rich text interactions, but that flexibility also comes at the cost of having to know quite a lot to build seemingly simple interactions.
It also doesn’t help that the project has very poor documentation beyond the API reference. As @robbertbrak mentions there is very little maintenance happening on the project from Facebook, and no maintainers from outside Facebook, so the documentation hasn’t been getting much love.
Anyway, if you’re wanting to learn more Draft.js by examples I would recommend looking through everything on https://github.com/nikgraf/awesome-draft-js. In particular I learned a lot from https://github.com/jpuri/draftjs-utils, because of its "single-purpose utility" nature. I have a similar "DraftUtils" file in my project that might also be interesting for the same purpose: https://github.com/springload/draftail/blob/master/lib/api/DraftUtils.js.

Thanks for your great work on Draftail, @thibaudcolas and I do find those utils files very helpful. Actually, I was going to make a request/proposal for you, but I see you're taking a break from Patreon. It's probably appropriate I close this issue and contact you elsewhere


Can VSIFILE or GDAL merge requests?

in https://github.com/vincentsarago/vsifile/blob/main/vsifile_logs.ipynb I'm printing the logs to see the behaviour that GDAL has when opening/reading the file using VSIOpener.
Header Cache
DEBUG:vsifile:Using /tmp/visfile-cache Cache directory
DEBUG:vsifile:Opening: tests/fixtures/cog.tif (mode: rb)
DEBUG:vsifile:Reading 0->32768 from Header cache
DEBUG:vsifile:Reading 0->8 from Header cache
DEBUG:vsifile:Reading 8->10 from Header cache
DEBUG:vsifile:Reading 10->226 from Header cache
DEBUG:vsifile:Reading 226->230 from Header cache
DEBUG:vsifile:Reading 1280->1304 from Header cache
DEBUG:vsifile:Reading 1304->1352 from Header cache
DEBUG:vsifile:Reading 1352->1416 from Header cache
DEBUG:vsifile:Reading 1416->1446 from Header cache
DEBUG:vsifile:Reading 1198->1279 from Header cache
DEBUG:vsifile:Reading 1446->1448 from Header cache
DEBUG:vsifile:Reading 1448->1616 from Header cache
DEBUG:vsifile:Reading 1616->1620 from Header cache

as we can see in ☝, GDAL has 0 caching method and will request bytes without reusing the one it already fetched 😭
DEBUG:vsifile:Reading 0->32768 from Header cache
DEBUG:vsifile:Reading 0->8 from Header cache

This seems really weird, once GDAL ask for open, the first thing it does is fetch the first 32768 bytes (GDAL_INGESTED_BYTES_AT_OPEN=32768) but doesn't make use of the bytes afterward. In vsifile we store this header in diskcache and in the python Object after opening, so no direct file request is necessary but the <> between GDAL and Python  is just not necessary.
Block cache
DEBUG:vsifile:Fetching 86991->87046
DEBUG:vsifile:Fetching 87046->87101
DEBUG:vsifile:Fetching 87101->87156
DEBUG:vsifile:Fetching 87156->88480
DEBUG:vsifile:Fetching 88480->90780
DEBUG:vsifile:Fetching 90780->91309
DEBUG:vsifile:Fetching 91309->91364
DEBUG:vsifile:Fetching 91364->91419
DEBUG:vsifile:Fetching 91419->91474
DEBUG:vsifile:Fetching 91474->91529
DEBUG:vsifile:Fetching 91529->91688
DEBUG:vsifile:Fetching 91688->91743
DEBUG:vsifile:Fetching 91743->91798
DEBUG:vsifile:Fetching 91798->92160
DEBUG:vsifile:Fetching 92160->93792
DEBUG:vsifile:Fetching 93792->96827
DEBUG:vsifile:Fetching 96827->101030

GDAL does not merge request with will then results in a LOT of requests, making vsiopener (or this implementation) useless 😭

It can
#4
But this is not yet implemented in rasterio
https://github.com/rasterio/rasterio/pull/2898#issuecomment-1800416351


Demo picture of carousel view in use

Hi,
Nice project! I thought it would be nice if you could add a demo picture in the README.md file of the carouselview in use, so that we can see how it looks like and functions.
Thanks.

Here's a preview GIF:
http://i.imgur.com/ALPu8ns.gif

Thanks a lot @ThimoKl, I have added banner and gif for that.

Thanks guys


starting a recipe for NAS on micromind's networks

Not ready to merge yet; still verifying results and code status.
Opening this to make proper comments @mariam-jamal

@fpaissan Can you please review it for the merge?