Cannot read property 'commands' of undefined

I get a lot of Cannot read property 'commands' of undefined errors during a run.

Is this during rebases

No, I wasn't rebasing. This was a fresh setup of Strider in combination with GitLab.

Do you have a callstack? Would like to know which phase is triggering the error.

@knownasilya I don't seem to be able to repro right now. It happened in a fresh installation.
I'm only seeing this right now, but it's probably a different issue:

Seems like ensureCommand is missing semicolons btw.

@oliversalzburg most of the code is not following a specific style guide. I've been slowly following the airbnb guide as I make changes. Eventually I want to setup eslint and fix all the code O.O

Yeah, sorry for not collecting more useful information when the error happens.
Whenever I set up a fresh Strider instance, I seem to be running into all kinds of weird issues that resolve themselves shortly after. In those situations I'm usually under a lot of time pressure and am battling with multiple issues.
If it happens again, I'll make sure to capture more useful information.

@oliversalzburg can you walk me through how you setup gitlab with Strider (I don't use gitlab and the plugin is a little raw - adds to huge todo list)?

@knownasilya I can try and reproduce this later at home, but it was a process involving a lot of trial-and-error. I'm not sure if I'll remember making the same mistakes again ;D

@knownasilya So, I'm trying to reproduce this, but I'm running into https://github.com/Strider-CD/strider-gitlab/issues/8 for now. I'll see if I can find the root of that one.

Alright, I got two more call stacks for the same error after setting up a fresh strider instance on my Windows desktop.
The git clone failed here, because I neglected to add the strider SSH key to GitLab though. But maybe this is already helping:

So, this is what I did (originally, I used our on-premise GitLab, but I would assume the public gitlab.com works just as well):

Clone strider git clone git@github.com:Strider-CD/strider.git
npm install
bower install
Set SERVER_NAME environment variable (http://localhost:3000)
Add initial user node .bin/strider addUser
Start strider node .bin/strider
Log into strider
Add GitLab account to my strider account

API URL is http://gitlab.com/api/v3
The private token can be retrieved from your gitlab.com user profile

Add a project from Gitlab to strider

Set it as a nodejs project

Configure the project

Set node_modules caching to strict

Deploy project

@oliversalzburg awesome! Thanks for hanging in there. This will make it much easier to debug.

I'm experiencing a similar issue right now that feels related.
I have set up all our projects fresh. When there are no builds running, I go to the project configuration and click Retest & Deploy, which sends me to the build page.
I have placed a breakpoint in the command.done handler of JobDataMonitor.prototype.statuses. Here, this.phase is undefined:

The full async stack trace is:
JobDataMonitor.statuses._.extend.command.done (app.js:2729)
JobMonitor.update (app.js:2822)
Emitter.emit (app.js:46010)
Socket.onevent (app.js:45554)
Socket.onpacket (app.js:45512)
module.exports (app.js:45872)
Emitter.emit (app.js:46010)
Manager.ondecoded (app.js:45070)
module.exports (app.js:45872)
Emitter.emit (app.js:46010)
Decoder.add (app.js:50621)
Manager.ondata (app.js:45060)
module.exports (app.js:45872)
Emitter.emit (app.js:46010)
Socket.onPacket (app.js:46628)
(anonymous function) (app.js:46446)
Emitter.emit (app.js:46010)
Transport.onPacket (app.js:47053)
Polling.onData.callback (app.js:47893)
(anonymous function) (app.js:49336)
exports.decodePayloadAsBinary (app.js:49335)
exports.decodePayload (app.js:49103)
Polling.onData (app.js:47897)
(anonymous function) (app.js:47481)
Emitter.emit (app.js:46010)
Request.onData (app.js:47629)
Request.onLoad (app.js:47700)
Request.create.xhr.onreadystatechange (app.js:47582)
XMLHttpRequest.send (async)
Request.create (app.js:47594)
Request (app.js:47517)
XHR.request (app.js:47448)
XHR.doPoll (app.js:47478)
Polling.poll (app.js:47867)
Polling.onData (app.js:47906)
(anonymous function) (app.js:47481)
Emitter.emit (app.js:46010)
Request.onData (app.js:47629)
Request.onLoad (app.js:47700)
Request.create.xhr.onreadystatechange (app.js:47582)
XMLHttpRequest.send (async)
Request.create (app.js:47594)
Request (app.js:47517)
XHR.request (app.js:47448)
XHR.doPoll (app.js:47478)
Polling.poll (app.js:47867)
Polling.doOpen (app.js:47811)
Transport.open (app.js:46988)
Socket.open (app.js:46418)
Socket (app.js:46300)
Socket (app.js:46235)
Manager.open.Manager.connect (app.js:44974)
Manager (app.js:44832)
Manager (app.js:44802)
lookup (app.js:44735)
module.exports (app.js:1817)
invoke (app.js:8253)
instantiate (app.js:8264)
$get (app.js:11561)
link (app.js:4266)
nodeLinkFn (app.js:10991)
compositeLinkFn (app.js:10385)
publicLinkFn (app.js:10281)
$get.boundTranscludeFn (app.js:10405)
controllersBoundTransclude (app.js:11012)
update (app.js:4224)
$get.Scope.$broadcast (app.js:17239)
(anonymous function) (app.js:3905)
deferred.promise.then.wrappedCallback (app.js:15848)
deferred.promise.then.wrappedCallback (app.js:15848)
(anonymous function) (app.js:15934)
$get.Scope.$eval (app.js:16960)
$get.Scope.$digest (app.js:16772)
$get.Scope.$apply (app.js:17064)
(anonymous function) (app.js:5734)
invoke (app.js:8253)
doBootstrap (app.js:5732)
bootstrap (app.js:5746)
angularInit (app.js:5655)
(anonymous function) (app.js:26236)
jQuery.Callbacks.fire (app.js:30682)
jQuery.Callbacks.self.fireWith (app.js:30794)
jQuery.extend.ready (app.js:31006)
completed (app.js:31037)

I can, however, not repro this issue at will. Partly due to #785

If I wait long enough I get a ton of these though. Here's more:

These all seem related and look like race conditions to me. I can't even tell where std is set on the job monitor.


fixup for #21

Attempt fixing #21.

@SamYuan1990 Please check the (remaining ) error message: There seems to be something fishy with the build-image instruction added in #20: https://github.com/open-quantum-safe/liboqs-go/actions/runs/4685702520/jobs/8303055705?pr=22

@SamYuan1990 Please check the (remaining ) error message: There seems to be something fishy with the build-image instruction added in #20: https://github.com/open-quantum-safe/liboqs-go/actions/runs/4685702520/jobs/8303055705?pr=22

you know as I said
@baentsch , please ask who has maintainer role to fix it as https://github.com/open-quantum-safe/liboqs-go/blob/main/.github/workflows/PRcheck.yml#L29 in this PR it requires environment vars.
and share with my fork settings.

@baentsch ，any feedback?

hi/hello @baentsch ，any feedback?

@vsoftco , do you have such maintainer rights (See comment above)?

If I understand correctly, this PR was merged in without the corresponding secrets and environment variables being added to the main repository correct?

vars.DOCKERIMAGE needs to be a variable.

for this, @xvzcf , for contributor. as he/she if not maintainer for this repo. which means he/she can't push package to this repo but to he/she own fork.
and when the PR been merged, the upstream action can't not push to fork repo's package either. or in opposite direction from personal fork to upstream main, which will be a breaking change as general case for any CI related changes.
Hence here, by a variable, we can targeting the repo to either fork or upstream by just setting up in settings without a breaking change. (Same for secret to access docker repo or github docker registration)
Obviously, if PR's contributor without maintain role to contribute CI related PR, this things may happen.

Understood, but with a variable, the name of the Docker image is being obscured in the push step, and I'm not convinced that fixing the mismatch between upstream and forks is worth this.
That being said, I won't block on this.

as I don't have permission to edit CI related env or secret for this repo, I try to provide a fix as #23 for reference. @baentsch , @xvzcf sorry for replay late.

Understood, but with a variable, the name of the Docker image is being obscured in the push step, and I'm not convinced that fixing the mismatch between upstream and forks is worth this.

This is not the problem, @xvzcf but rather that the location of the docker image changed in #20; in addition, CircleCI doesn't seem to offer docker buildx support, which is why this build-and-push test got moved to github CI. Thus, removal of the CCI code to build the docker image using "buildx" is sensible (as quickly done in this pre-vacation hotfix) and addition of the required secrets to github CI (as requested by @SamYuan1990 ).

the image building and pushing should only occur in the main branch, when (presumably) all the other checks have passed.

I do think it does as shown by this code, no?:
https://github.com/open-quantum-safe/liboqs-go/blob/28be2ce91ace968370f3f04b38d2128b160396c0/.github/workflows/build.yml#L44-L48
One may argue that it would be more sensible to set the value of the push argument below not to "true" but to "github.ref == 'refs/heads/main'" thus allowing build but no push on a branch other than "main".

Decided to drop support for this, as it introduce additional dependencies that are difficult to maintain in the long term.


Fix Go-Report-Card

Get it to 100% across the checking if #3068 was acceptable.

As per #3068 , closing.


Install flow enhancements poc 1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: sanderblue:white_check_mark: Julien4218:x: NRhzhaoYou have signed the CLA already but the status is still pending? Let us recheck it.


Update page since app is on F-Droid

This page could benefit from having a link button to F-Droid near the Play Store button:
https://github.com/kaliturin/BlackList
Thank you so much for getting this in fdroid. And the app is amazing.
Do you have a donate option anywhere?  I couldn't find a donate link.

Thanks!
I accepted the pull request with a link button to F-Droid. I don't accept donation for this project nor sure I will support is as it is. But I consider to rewrite it in Kotlin with new features someday.


Not Support Xamarin.iOS

Not enough detail, closing. (And also we announced in the past that we will no longer support Xamarin).


Content URL showing "Untitled" for titled articles

@zanemountcastle I was testing a classifier on the Gazelle and happened to notice some articles that have "Untitled" in the URL.
Dunno if the issue is from the Editors not adding a needed value or what.
Examples of issue
www.thegazelle.org/issue/117/opinion/untitled-4
www.thegazelle.org/issue/117/media/untitled-3

Yeah I think it's probably a Ghost default behavior thing when the editors forgot to specify a slug, new editors and they're still new to the admin/publishing process, thanks for pointing it out though, I'll bring that on to them!


Bootstrap.js was not included so the 'responsive' menu didn't work.

Added inclusion of bootstrap.min.js so that the responsive menu opens when clicked on.
(also removed protocol from jquery cdn include so that the https version is used when deployed)
Fixes HTBox/crisischeckin#188

The initial // is valid. I believe it uses whatever scheme it thinks is being used at the time. If you copied and pasted that link into a browser window, it loads that .js file.


.ssh/authorizedkeys gets deleted when I deactivate "allow user/pwd" in ssh web-ui dialog

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
.ssh/autorized_keys file gets wiped by UI when "allow user/pwd" is toggled
To Reproduce
Logon to Opnsense (22.7.9) via ssh root/pwd
create a file .ssh/autorized_keys which contains a public key
deactivate "allow user/pwd" in web ui to restrict it to key only
try to logon ... it fails
To get it done you need to logon with user/pwd, toggle UI while logged on in ssh, add the key after password is switched off.
This is crazy if you have more than one key and all get wiped.
Expected behavior
A clear and concise description of what you expected to happen.
Describe alternatives you considered
A clear and concise description of any alternative solutions or workaround you considered.
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 19.1.1 (amd64, OpenSSL).
Intel® Xeon™ E3-1225V5 3.3Ghz Quad Core
Network Intel® I210-AT

use the gui (System: Access: Users --> [select user] --> Authorized keys)


Enhance test for pdb records

Enhancement to the performance db validity test.
Modifications to any_solver class to include IsValidPerformanceConfig in the call to testSysDbRecord. Records will now be tested for serialization and param validity.
Fin version bumped up to Fin develop tip.
This will now enforce the pdb validity on the ci.

@cderb issue with cmake:
CMake Error at fin/tests/CMakeLists.txt:6 (add_custom_target):

[2022-08-03T19:47:00.791Z]   add_custom_target cannot create target "tests" because another target with

[2022-08-03T19:47:00.791Z]   the same name already exists.  The existing target is a custom target

[2022-08-03T19:47:00.791Z]   created in source directory

[2022-08-03T19:47:00.791Z]   "/var/jenkins/workspace/LLibs_MIOpen_cderb_enhc_pdb_test/test".


Redirect Center on Synology DNS server

Hi, can you explain how to use redirect center on a synology DNS server to reroute all traffic on internal network from www.mydomain.com to www.myotherdomain.com/abc ?

Not sure if I get your issue. It still a normal configuration.


release: release a patch for 0.12.1 allowing v0.0.1 intoto entries

Description
Currently 0.12.0 does not allow v0.0.1 intoto entries. However, clients still need to verify rekor entries (and sometimes upload) v0.0.1 entries: we should have a small patch release including this change
https://github.com/sigstore/rekor/commit/a6d36b8028ecdb4c047dde52b29a76b51b058b2f

cc @cpanato

I'd also like to get f27af357e6831225507ed97524dec78e034fe63f into the release as well so we can accurately measure SLO for GA. Can we cut 0.12.1 from HEAD (or 0.13.0)?

this https://github.com/sigstore/rekor/commit/a6d36b8028ecdb4c047dde52b29a76b51b058b2f is already in 0.12.0
but i do agree we can make a 0.12.1 release

Closed, thanks!
https://github.com/sigstore/rekor/releases/tag/v0.12.1


[General] Experimental Audio System Rework

As Chris (from the cube)
I want to rework the audio system
so that the options menu will work
Acceptance Criteria

[x] Mute Music and Mute SFX toggles work

Tasks

[x] Create separate dedicated SFXAudio Source
[x] Route all audio sources through a main mixer
[x] Reassign all sfx to fit new system
[x] make script to control mixer from options page
[x] make sure everything still works

Made decent progress, but need to stop for the night.  Pushed changes to give-it-a-name.
@Prot0ast @cfines could you take a look at this in the morning?  I think I'll need about 30min to re-link all sfx, but I'm not sure about fixing the toggles.
Summary of changes:
Implemented Audio Mixer

Audio now split into two separate sources, one for Music, one for SFX.
Both audio sources are then routed to the mixer.
Toggles on options menu control the volume of the channels on the audio mixer, which persist between scenes.

Bugs:
-Toggles always default to show on when loading options screen and do not read current value of relevant bool.
-Most sfx are broken and need to be relinked using the updated scripts.

Toggles work, so I will close this.  Will make fixing the toggle states a new request.


Signature Verification: Support Unwrapped Signatures in addtion to  Wrapped

Summary
The account_ownership_proof parameter in PasskeyCall signifies the signature of <Bytes>PASSKEY_PUBLIC_KEY</Bytes>. This means that the wallet client or browser must use this format during registration.
Issue details
Currently, the polkadot-js-extension wraps all raw signed bytes inside the <Bytes> tag, and the Frequency protocol follows the same approach during passkey registration. Specifically, it signs the payload <Bytes>PASSKEY_PUBLIC_KEY</Bytes> using the private key of the user's Substrate Account. During the transaction process, it wraps the passkey_public_key inside <Bytes>.
However, since any entity can develop an infrastructure for passkey registration and transaction submission, there is a risk that others might not wrap the PASSKEY_PUBLIC_KEY in <Bytes>, potentially causing confusion.
Risk
The current method could lead to interoperability issues if different implementations do not use the <Bytes> wrapping for the PASSKEY_PUBLIC_KEY. This inconsistency could result in failed signature verification and transaction errors.
Mitigation
The check_account_signature function should verify signatures for both the raw signed_data and <Bytes>signed_data</Bytes>. This dual-check approach, as implemented in pallet-nfts, would ensure compatibility across different implementations and reduce the risk of verification failures.
Suggestion
This should be fixed everywhere

[x] Fix for passkey
[x] Fix for handles
[x] Fix for MSA Pallet: Delegation, Add Key, etc...
[x] Fix for Stateful Storage: Signature Requried

What is the benefit of applying this outside passkeys? Isn't applying this everywhere going to weaken the following claim?

As a convention the polkadot-js-extension always wraps raw data in  tags to prevent
malicious apps from tricking users into signing unintended transactions.


Create iitchennai.txt

@vineeshvk I am sorry, I have to close this request without merging, because you requested to add a non-existent domain to this repository:
$ host iitchennai.edu.in
Host iitchennai.edu.in not found: 3(NXDOMAIN)

Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Update text_output.py

Added additional abilities to export as a CSV file, as well as Json files for sentences. I'm currently using stable-ts to create a conversational AI dataset, and these additions could be useful if one wants to parse the timestamps/text!
Also, I might be making a separate pull request for the ability to split audio based on the timestamps generated by stable-ts, although thought that could be too far removed from the intent of the original repo.

Hi @rioharper
Quite interested by the ability to split audio based on the timestamps ! Do you have it working on your fork ?
Thank in advance ! :)

I am still cleaning up my code for that, but Id be happy to reply to you again once its committed to my fork!

Hi @rioharper Quite interested by the ability to split audio based on the timestamps ! Do you have it working on your fork ?
Thank in advance ! :)

Since we have exact timestamp for each sentence, It's easy to split the audio stream into audio segments with jiaaro/pydub: Manipulate audio with a simple and easy high level interface.

Ah, thats what I thought too, but the problem is the length of each
"sentence" is extremely similar. This lack of diversity is bad for a lot of
ML applications. For instance, im using whisper for a dataset for a TTS
model. If I were to use the same length, any sentence I want it to say that
is shorter or longer would have a significant quality impact.
Right now Im working on an end to end voice refinement library, so this
thread is taking me a little longer than expected, but once it is done ill
let you all know.
P.S NEMO by nvidia has an excellent segmenation tool, which I plan to use
in conjunction with Whisper.
On Mon, Jan 9, 2023, 12:14 AM Known Rabbit @.***> wrote:

Hi @rioharper https://github.com/rioharper Quite interested by the
ability to split audio based on the timestamps ! Do you have it working on
your fork ?
Thank in advance ! :)
Since we have exact timestamp for each sentence, It's easy to split the
audio stream into audio segments with jiaaro/pydub: Manipulate audio with
a simple and easy high level interface https://github.com/jiaaro/pydub.
—
Reply to this email directly, view it on GitHub
https://github.com/jianfch/stable-ts/pull/52#issuecomment-1375117869,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMBWV7ECUVW4NBKTCOTFB7LWRONCVANCNFSM6AAAAAAS3HO42U
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add .query to PoolNamespace.

Refactor PoolNamespace#_getClusterNode but still backward-compatible
original issue: https://github.com/mysqljs/mysql/issues/1505

now we can use cluster this way:
 var pool = cluster.of('SLAVE*', 'ORDER');

  pool.query('SELECT 1', function (err, rows) {}) // works fine!!

travis ci fails, but seems a old test result in that.

Nice, thanks, @alsotang! Don't worry about that failing test; I'll get it fixed today :)

Sorry for the long delay, @alsotang ! I was able to fix the flaky tests, and so the PR is now passing the tests. I do see that the PR is marked failing as well because it caused the coverage percentage to decrease. Looking at the report, it looks like it's because in the new PoolNamespace.prototype.query, both of the if (err) code paths are not tested.

lol @alsotang I just popped into this PR to see if I could just add the tests & merge to help out :) I see you just put more more commits. Please ping me when you're ready for me to take a look :)

I already add tests for the error handler. Seems now the PoolNamespace.js is 100% cover.


padding above status bar (or below if positioned at the top)

Is there an existing issue outlining your improvement?

[X] I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?
I'd like to have some padding or a blank line above the status bar when at the bottom to stop the terminal being right on top of it, or below if the status bar is set to the top.

#192


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:27: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:27: patch_must_be_in_build: patch must be in build when source/patches is set.
ERROR: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:30: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:50: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:58: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_e6sma_iiaa/clone/recipe/meta.yaml:58: missing_description: The recipe is missing a description
Errors were found


Test Case 'SniHandlerTest.testSafariBlast' started at 2018-05-24 17:17:56.824
Test Case 'SniHandlerTest.testSafariBlast' passed (0.0 seconds)
Test Case 'SniHandlerTest.testChromeBlast' started at 2018-05-24 17:17:56.825
Test Case 'SniHandlerTest.testChromeBlast' passed (0.0 seconds)
Test Case 'SniHandlerTest.testFirefoxBlast' started at 2018-05-24 17:17:56.825
Test Case 'SniHandlerTest.testFirefoxBlast' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresUnknownRecordTypes' started at 2018-05-24 17:17:56.825
Test Case 'SniHandlerTest.testIgnoresUnknownRecordTypes' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresUnknownTlsVersions' started at 2018-05-24 17:17:56.826
Test Case 'SniHandlerTest.testIgnoresUnknownTlsVersions' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresNonClientHelloHandshakeMessages' started at 2018-05-24 17:17:56.826
Test Case 'SniHandlerTest.testIgnoresNonClientHelloHandshakeMessages' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidHandshakeLength' started at 2018-05-24 17:17:56.827
Test Case 'SniHandlerTest.testIgnoresInvalidHandshakeLength' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidCipherSuiteLength' started at 2018-05-24 17:17:56.827
Test Case 'SniHandlerTest.testIgnoresInvalidCipherSuiteLength' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidCompressionLength' started at 2018-05-24 17:17:56.828
Test Case 'SniHandlerTest.testIgnoresInvalidCompressionLength' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidExtensionLength' started at 2018-05-24 17:17:56.828
Test Case 'SniHandlerTest.testIgnoresInvalidExtensionLength' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidIndividualExtensionLength' started at 2018-05-24 17:17:56.829
Test Case 'SniHandlerTest.testIgnoresInvalidIndividualExtensionLength' passed (0.001 seconds)
Test Case 'SniHandlerTest.testIgnoresUnknownNameType' started at 2018-05-24 17:17:56.829
Test Case 'SniHandlerTest.testIgnoresUnknownNameType' passed (0.0 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidNameLength' started at 2018-05-24 17:17:56.830
Test Case 'SniHandlerTest.testIgnoresInvalidNameLength' passed (0.001 seconds)
Test Case 'SniHandlerTest.testIgnoresInvalidNameExtensionLength' started at 2018-05-24 17:17:56.830
Test Case 'SniHandlerTest.testIgnoresInvalidNameExtensionLength' passed (0.001 seconds)
Test Case 'SniHandlerTest.testLudicrouslyTruncatedPacket' started at 2018-05-24 17:17:56.831
Test Case 'SniHandlerTest.testLudicrouslyTruncatedPacket' passed (0.0 seconds)
Test Case 'SniHandlerTest.testFuzzingInputOne' started at 2018-05-24 17:17:56.832
Test Case 'SniHandlerTest.testFuzzingInputOne' passed (0.0 seconds)
Test Suite 'SniHandlerTest' passed at 2018-05-24 17:17:56.832
	 Executed 29 tests, with 0 failures (0 unexpected) in 0.07 (0.07) seconds
Test Suite 'SocketAddressTest' started at 2018-05-24 17:17:56.832
Test Case 'SocketAddressTest.testDescriptionWorks' started at 2018-05-24 17:17:56.832
Test Case 'SocketAddressTest.testDescriptionWorks' passed (0.0 seconds)
Test Case 'SocketAddressTest.testIn6AddrDescriptionWorks' started at 2018-05-24 17:17:56.832
Test Case 'SocketAddressTest.testIn6AddrDescriptionWorks' passed (0.0 seconds)
Test Case 'SocketAddressTest.testCanCreateIPv4AddressFromString' started at 2018-05-24 17:17:56.833
Test Case 'SocketAddressTest.testCanCreateIPv4AddressFromString' passed (0.0 seconds)
Test Case 'SocketAddressTest.testCanCreateIPv6AddressFromString' started at 2018-05-24 17:17:56.833
Test Case 'SocketAddressTest.testCanCreateIPv6AddressFromString' passed (0.0 seconds)
Test Case 'SocketAddressTest.testRejectsNonIPStrings' started at 2018-05-24 17:17:56.833
Test Case 'SocketAddressTest.testRejectsNonIPStrings' passed (0.0 seconds)
Test Case 'SocketAddressTest.testWithMutableAddressCopiesFaithfully' started at 2018-05-24 17:17:56.833
Test Case 'SocketAddressTest.testWithMutableAddressCopiesFaithfully' passed (0.0 seconds)
Test Case 'SocketAddressTest.testWithMutableAddressAllowsMutationWithoutPersistence' started at 2018-05-24 17:17:56.833
Test Case 'SocketAddressTest.testWithMutableAddressAllowsMutationWithoutPersistence' passed (0.0 seconds)
Test Case 'SocketAddressTest.testConvertingStorage' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testConvertingStorage' passed (0.0 seconds)
Test Case 'SocketAddressTest.testComparingSockaddrs' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testComparingSockaddrs' passed (0.0 seconds)
Test Case 'SocketAddressTest.testEqualSocketAddresses' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testEqualSocketAddresses' passed (0.0 seconds)
Test Case 'SocketAddressTest.testUnequalAddressesOnPort' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testUnequalAddressesOnPort' passed (0.0 seconds)
Test Case 'SocketAddressTest.testUnequalOnAddress' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testUnequalOnAddress' passed (0.0 seconds)
Test Case 'SocketAddressTest.testUnequalAcrossFamilies' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testUnequalAcrossFamilies' passed (0.0 seconds)
Test Case 'SocketAddressTest.testPortAccessor' started at 2018-05-24 17:17:56.834
Test Case 'SocketAddressTest.testPortAccessor' passed (0.0 seconds)
Test Case 'SocketAddressTest.testCanMutateSockaddrStorage' started at 2018-05-24 17:17:56.835
Test Case 'SocketAddressTest.testCanMutateSockaddrStorage' passed (0.0 seconds)
Test Suite 'SocketAddressTest' passed at 2018-05-24 17:17:56.835
	 Executed 15 tests, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'SocketChannelTest' started at 2018-05-24 17:17:56.835
Test Case 'SocketChannelTest.testAsyncSetOption' started at 2018-05-24 17:17:56.835
Test Case 'SocketChannelTest.testAsyncSetOption' passed (0.003 seconds)
Test Case 'SocketChannelTest.testDelayedConnectSetsUpRemotePeerAddress' started at 2018-05-24 17:17:56.837
Test Case 'SocketChannelTest.testDelayedConnectSetsUpRemotePeerAddress' passed (0.048 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithECONNABORTED' started at 2018-05-24 17:17:56.885
Test Case 'SocketChannelTest.testAcceptFailsWithECONNABORTED' passed (0.002 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithEMFILE' started at 2018-05-24 17:17:56.888
Test Case 'SocketChannelTest.testAcceptFailsWithEMFILE' passed (0.002 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithENFILE' started at 2018-05-24 17:17:56.889
Test Case 'SocketChannelTest.testAcceptFailsWithENFILE' passed (0.002 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithENOBUFS' started at 2018-05-24 17:17:56.891
Test Case 'SocketChannelTest.testAcceptFailsWithENOBUFS' passed (0.001 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithENOMEM' started at 2018-05-24 17:17:56.892
Test Case 'SocketChannelTest.testAcceptFailsWithENOMEM' passed (0.002 seconds)
Test Case 'SocketChannelTest.testAcceptFailsWithEFAULT' started at 2018-05-24 17:17:56.894
Test Case 'SocketChannelTest.testAcceptFailsWithEFAULT' passed (0.001 seconds)
Test Case 'SocketChannelTest.testSetGetOptionClosedServerSocketChannel' started at 2018-05-24 17:17:56.895
Test Case 'SocketChannelTest.testSetGetOptionClosedServerSocketChannel' passed (0.003 seconds)
Test Case 'SocketChannelTest.testConnect' started at 2018-05-24 17:17:56.899
Test Case 'SocketChannelTest.testConnect' passed (0.001 seconds)
Test Case 'SocketChannelTest.testWriteServerSocketChannel' started at 2018-05-24 17:17:56.900
Test Case 'SocketChannelTest.testWriteServerSocketChannel' passed (0.001 seconds)
Test Case 'SocketChannelTest.testWriteAndFlushServerSocketChannel' started at 2018-05-24 17:17:56.902
Test Case 'SocketChannelTest.testWriteAndFlushServerSocketChannel' passed (0.001 seconds)
Test Case 'SocketChannelTest.testConnectServerSocketChannel' started at 2018-05-24 17:17:56.903
Test Case 'SocketChannelTest.testConnectServerSocketChannel' passed (0.001 seconds)
Test Case 'SocketChannelTest.testCloseDuringWriteFailure' started at 2018-05-24 17:17:56.904
Test Case 'SocketChannelTest.testCloseDuringWriteFailure' passed (0.002 seconds)
Test Case 'SocketChannelTest.testWithConfiguredStreamSocket' started at 2018-05-24 17:17:56.907
Test Case 'SocketChannelTest.testWithConfiguredStreamSocket' passed (0.002 seconds)
Test Case 'SocketChannelTest.testWithConfiguredDatagramSocket' started at 2018-05-24 17:17:56.908
Test Case 'SocketChannelTest.testWithConfiguredDatagramSocket' passed (0.001 seconds)
Test Case 'SocketChannelTest.testPendingConnectNotificationOrder' started at 2018-05-24 17:17:56.910
Test Case 'SocketChannelTest.testPendingConnectNotificationOrder' passed (0.003 seconds)
Test Case 'SocketChannelTest.testLocalAndRemoteAddressNotNilInChannelInactiveAndHandlerRemoved' started at 2018-05-24 17:17:56.913
Test Case 'SocketChannelTest.testLocalAndRemoteAddressNotNilInChannelInactiveAndHandlerRemoved' passed (0.003 seconds)
Test Suite 'SocketChannelTest' passed at 2018-05-24 17:17:56.916
	 Executed 18 tests, with 0 failures (0 unexpected) in 0.08 (0.08) seconds
Test Suite 'SystemTest' started at 2018-05-24 17:17:56.916
Test Case 'SystemTest.testSystemCallWrapperPerformance' started at 2018-05-24 17:17:56.916
WARNING: Syscall wrapper test: Over 100% overhead allowed. Running in debug assert configuration which allows 1000% overhead :(. Consider running in Release mode.
Test Case 'SystemTest.testSystemCallWrapperPerformance' passed (0.86 seconds)
Test Case 'SystemTest.testErrorsWorkCorrectly' started at 2018-05-24 17:17:57.776
Test Case 'SystemTest.testErrorsWorkCorrectly' passed (0.0 seconds)
Test Suite 'SystemTest' passed at 2018-05-24 17:17:57.777
	 Executed 2 tests, with 0 failures (0 unexpected) in 0.86 (0.86) seconds
Test Suite 'ThreadTest' started at 2018-05-24 17:17:57.777
Test Case 'ThreadTest.testCurrentThreadWorks' started at 2018-05-24 17:17:57.777
Test Case 'ThreadTest.testCurrentThreadWorks' passed (0.0 seconds)
Test Case 'ThreadTest.testCurrentThreadIsNotTrueOnOtherThread' started at 2018-05-24 17:17:57.777
Test Case 'ThreadTest.testCurrentThreadIsNotTrueOnOtherThread' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificsAreNilWhenNotPresent' started at 2018-05-24 17:17:57.778
Test Case 'ThreadTest.testThreadSpecificsAreNilWhenNotPresent' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificsWorks' started at 2018-05-24 17:17:57.778
Test Case 'ThreadTest.testThreadSpecificsWorks' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificsAreNotAvailableOnADifferentThread' started at 2018-05-24 17:17:57.778
Test Case 'ThreadTest.testThreadSpecificsAreNotAvailableOnADifferentThread' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfThreadExitsWhilstSet' started at 2018-05-24 17:17:57.779
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfThreadExitsWhilstSet' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfThreadExitsAfterUnset' started at 2018-05-24 17:17:57.779
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfThreadExitsAfterUnset' passed (0.0 seconds)
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfReplacedWithNewValue' started at 2018-05-24 17:17:57.779
Test Case 'ThreadTest.testThreadSpecificDoesNotLeakIfReplacedWithNewValue' passed (0.0 seconds)
Test Case 'ThreadTest.testSharingThreadSpecificVariableWorks' started at 2018-05-24 17:17:57.780
Test Case 'ThreadTest.testSharingThreadSpecificVariableWorks' passed (0.001 seconds)
Test Case 'ThreadTest.testThreadSpecificInitWithValueWorks' started at 2018-05-24 17:17:57.781
Test Case 'ThreadTest.testThreadSpecificInitWithValueWorks' passed (0.0 seconds)
Test Suite 'ThreadTest' passed at 2018-05-24 17:17:57.781
	 Executed 10 tests, with 0 failures (0 unexpected) in 0.003 (0.003) seconds
Test Suite 'TypeAssistedChannelHandlerTest' started at 2018-05-24 17:17:57.781
Test Case 'TypeAssistedChannelHandlerTest.testCanDefineBothInboundAndOutbound' started at 2018-05-24 17:17:57.781
Test Case 'TypeAssistedChannelHandlerTest.testCanDefineBothInboundAndOutbound' passed (0.0 seconds)
Test Suite 'TypeAssistedChannelHandlerTest' passed at 2018-05-24 17:17:57.781
	 Executed 1 test, with 0 failures (0 unexpected) in 0.0 (0.0) seconds
Test Suite 'UtilitiesTest' started at 2018-05-24 17:17:57.781
Test Case 'UtilitiesTest.testCoreCountWorks' started at 2018-05-24 17:17:57.781
Test Case 'UtilitiesTest.testCoreCountWorks' passed (0.0 seconds)
Test Case 'UtilitiesTest.testEnumeratingInterfaces' started at 2018-05-24 17:17:57.781
Test Case 'UtilitiesTest.testEnumeratingInterfaces' passed (0.0 seconds)
Test Suite 'UtilitiesTest' passed at 2018-05-24 17:17:57.781
	 Executed 2 tests, with 0 failures (0 unexpected) in 0.0 (0.0) seconds
Test Suite 'WebSocketFrameDecoderTest' started at 2018-05-24 17:17:57.781
Test Case 'WebSocketFrameDecoderTest.testFramesWithoutBodies' started at 2018-05-24 17:17:57.781
Test Case 'WebSocketFrameDecoderTest.testFramesWithoutBodies' passed (0.0 seconds)
Test Case 'WebSocketFrameDecoderTest.testFramesWithExtensionDataDontRoundTrip' started at 2018-05-24 17:17:57.782
Test Case 'WebSocketFrameDecoderTest.testFramesWithExtensionDataDontRoundTrip' passed (0.0 seconds)
Test Case 'WebSocketFrameDecoderTest.testFramesWithExtensionDataCanBeRecovered' started at 2018-05-24 17:17:57.782
Test Case 'WebSocketFrameDecoderTest.testFramesWithExtensionDataCanBeRecovered' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testFramesWithReservedBitsSetRoundTrip' started at 2018-05-24 17:17:57.783
Test Case 'WebSocketFrameDecoderTest.testFramesWithReservedBitsSetRoundTrip' passed (0.0 seconds)
Test Case 'WebSocketFrameDecoderTest.testFramesWith16BitLengthsRoundTrip' started at 2018-05-24 17:17:57.784
Test Case 'WebSocketFrameDecoderTest.testFramesWith16BitLengthsRoundTrip' passed (0.0 seconds)
Test Case 'WebSocketFrameDecoderTest.testFramesWith64BitLengthsRoundTrip' started at 2018-05-24 17:17:57.784
Test Case 'WebSocketFrameDecoderTest.testFramesWith64BitLengthsRoundTrip' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testMaskedFramesRoundTripWithMaskingIntact' started at 2018-05-24 17:17:57.785
Test Case 'WebSocketFrameDecoderTest.testMaskedFramesRoundTripWithMaskingIntact' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testMaskedFramesRoundTripWithMaskingIntactEvenWithExtensions' started at 2018-05-24 17:17:57.785
Test Case 'WebSocketFrameDecoderTest.testMaskedFramesRoundTripWithMaskingIntactEvenWithExtensions' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsOverlongFrames' started at 2018-05-24 17:17:57.786
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsOverlongFrames' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsFragmentedControlFrames' started at 2018-05-24 17:17:57.787
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsFragmentedControlFrames' passed (0.0 seconds)
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsMultibyteControlFrameLengths' started at 2018-05-24 17:17:57.787
Test Case 'WebSocketFrameDecoderTest.testDecoderRejectsMultibyteControlFrameLengths' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testIgnoresFurtherDataAfterRejectedFrame' started at 2018-05-24 17:17:57.788
Test Case 'WebSocketFrameDecoderTest.testIgnoresFurtherDataAfterRejectedFrame' passed (0.001 seconds)
Test Case 'WebSocketFrameDecoderTest.testClosingSynchronouslyOnChannelRead' started at 2018-05-24 17:17:57.789
Test Case 'WebSocketFrameDecoderTest.testClosingSynchronouslyOnChannelRead' passed (0.0 seconds)
Test Suite 'WebSocketFrameDecoderTest' passed at 2018-05-24 17:17:57.789
	 Executed 13 tests, with 0 failures (0 unexpected) in 0.007 (0.007) seconds
Test Suite 'WebSocketFrameEncoderTest' started at 2018-05-24 17:17:57.789
Test Case 'WebSocketFrameEncoderTest.testBasicFrameEncoding' started at 2018-05-24 17:17:57.789
Test Case 'WebSocketFrameEncoderTest.testBasicFrameEncoding' passed (0.0 seconds)
Test Case 'WebSocketFrameEncoderTest.test16BitFrameLength' started at 2018-05-24 17:17:57.789
Test Case 'WebSocketFrameEncoderTest.test16BitFrameLength' passed (0.0 seconds)
Test Case 'WebSocketFrameEncoderTest.test64BitFrameLength' started at 2018-05-24 17:17:57.790
Test Case 'WebSocketFrameEncoderTest.test64BitFrameLength' passed (0.002 seconds)
Test Case 'WebSocketFrameEncoderTest.testEncodesEachReservedBitProperly' started at 2018-05-24 17:17:57.792
Test Case 'WebSocketFrameEncoderTest.testEncodesEachReservedBitProperly' passed (0.0 seconds)
Test Case 'WebSocketFrameEncoderTest.testEncodesExtensionDataCorrectly' started at 2018-05-24 17:17:57.792
Test Case 'WebSocketFrameEncoderTest.testEncodesExtensionDataCorrectly' passed (0.0 seconds)
Test Case 'WebSocketFrameEncoderTest.testMasksDataCorrectly' started at 2018-05-24 17:17:57.793
Test Case 'WebSocketFrameEncoderTest.testMasksDataCorrectly' passed (0.0 seconds)
Test Suite 'WebSocketFrameEncoderTest' passed at 2018-05-24 17:17:57.793
	 Executed 6 tests, with 0 failures (0 unexpected) in 0.004 (0.004) seconds
Test Suite 'debug.xctest' passed at 2018-05-24 17:17:57.793
	 Executed 700 tests, with 0 failures (0 unexpected) in 77.61 (77.61) seconds
Test Suite 'All tests' passed at 2018-05-24 17:17:57.793
	 Executed 700 tests, with 0 failures (0 unexpected) in 77.61 (77.61) seconds
[...]

marking as flaky test

CC @normanmaurer , this is the new test, right?

@normanmaurer ok, let me fix this test it's actually not acurate as the two bytes could come in one channel read.


bloxstrap is not starting but in task manager

Acknowledgement of preliminary instructions

[ ] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
when i start bloxtrap it shows starting roblox and nothing happens i opened the task manager and bloxtrap is open but its not starting pls help

someone didnt read it

when i start bloxtrap it shows starting roblox and nothing happens i opened the task manager and bloxtrap is open but its not starting pls help

Read https://github.com/pizzaboxer/bloxstrap/wiki/Roblox-crashes-or-does-not-launch first before you ask for any more help.


Markdown formatting rendering

Bullets (and sub-bullets), indentation and spacing are not being picked up as well

Can you link to the comment or post an example?

Sure @rnystrom photos reference comments in this post https://github.com/RoyaleAPI/cr-api-ux/issues/315

Specifically this post.

The markdown isn’t correct. Check it out on GotHub, looks the same.
https://github.com/RoyaleAPI/cr-api-ux/issues/315#issuecomment-428951319
List items require speakers between dashes and words.
Sent with GitHawk

@rnystrom
Not following are you saying the app so doing it right or acknowledging it’s incorrect
My original part of this post did compare githawk rendering to github mobile site.
Some differences
*spacing between billeted lists

indentation of “-“ items below bulleted top line list items
wip adding on...

*test
*test

@Rnystrom do u agree that there are render inconstancies? Should this ticket be reopened?

@rnystrom that is not true. Look at the two images I upload in the op them and x-ref them vs my bulleted list 3 comments up

@Huddie mind taking a look at this maybe can confirm if I’m crazy or accurate before I continue pushing harder with ryan

Personally, even if this was an issue, I'd classify at as low-pri if I had that ability just because I think the markdown is rendering fine atm. I say this just because I'm suggesting it's not worth pushing Ryan in either case.
I don't think the markdown needs to be 1-1 with GitHub. Certain features I agree should be 1-1 but the spacing between bullets is not something I feel needs to be 1-1 with Github
I do see what you mean about the "-" not being indented after an, "*", unordered list bullet. But, sub-lists, from my limited knowledge, are supposed to be written as I wrote below. Not really sure what the "-" is. See how the sub-list below renders properly.

Win % seems inconsistent:

On analytics page, a war miss counts as a loss.
On the new addition, a war miss is just factored out. (I lean towards the latter, since you already have misses in red. Ultimately your call but should be consistent, no?)

Agree and im not asking for priority I’m stating the ticket should be reopened as it’s still something that should be attended to at some point whenever that is. Yes some of these are minor but if you combine all 3 listed issues and compare he images I feel one loooks signicabtly more clean

there is a line space between each bullet
bulleted items should be indented slightly in by default but more importantly, align by text block and not the bullet
based off this second item, the indentation of “-“ items should align with the text block for the bullet it’s contained in and not the bullet mark

My coding knowledge is very limited, it’s something I’m starting to learn now so For now there’s the answer to your first paragraph

@rnystrom sorry for the tag, last one. Did my last comment shed any additional light. I think my second bullet in last comment at the very least is legitimate

Ya makes sense, but i don’t think chasing these nit picky spacing issues adds a ton of value over how it works today tbh. I’d rather us all spend time on impactful features/fixes.
But that’s why the project is open source. Everyone has the power to make changes they feel strongly about!
Sent with GitHawk

@rnystrom more markdown formatting weirdness. I know you considered the earlier reports insignificant, but not sure where you draw the line as this new item is def incorrect rendering.
https://github.com/RoyaleAPI/cr-api-ux/issues/357#issuecomment-5
^in githawk it renders the numbers as 1 and 1, while on github it renders as 1 and 2 (intended)
I actually just stumbled upon #2129 which coincidentally references my two biggest issues here. Surprisingly, you actually had kept this ticket open :)

in githawk it renders the numbers as 1 and 1, while on github it renders as 1 and 2 (intended)

Can you elaborate? The only thing I see missing is the (comment). Is that what you mean?

In githawk, second bullet incorrectly renders markdown as a 1
In github, second bullet correctly renders markdown as a 2
#2129, basically nailed my same pinpoints here:

Markdown lists don’t always number cowb correctly
Indentarion for subbulleys is off when they are more than one line in length
I also added a third item that github (but not githawk) adds a slight space between 1st level- bullet items

I know you didn’t consider these priory but they make a major difference in markdown looking cleaner and was recognizing that I was not the only one to ticket this (found later)
Lastly, never noticed the (comment) at the end of a comment link.
Here’s another example of a post that looks WAYY worse formatted in the app than on native GitHub
https://github.com/RoyaleAPI/cr-api-ux/issues/376
I’ve seen a ton of small changes to spacing and such that you continually make so I feel it’s moreso I’m doing a poor job relating what is not rendering great as opposed to focusing on a nothing issue. My previous comment summarized the top items for it.

Sorry I was not asking you to work on it at all. I was just asking that the issue be reopened. It is a legit issue. I appreciate the work everyone tries to do and think I’ve contributed as well. I just did not understand why this is considered closed; I am not arguing it’s priority. Will not ping you again on this issue

https://github.com/tripleee/sloshy renders incorrectly; the README.md contains newlines for internal formatting which should not be displayed when rendering the file.
Compare the screenshot against the fluid rendering you get when you visit the page with a regular web browser. The second line is an example; it should not be split with a newline between "chat bot" and "which".


Fcb erase value support

Adds support to non-0xff erasable flash devices to FCB.
Resolves #28693

@nvlsianpu please review

sure

@erwango This might be used now on some STM32L1 SoCs which has 0x00 as flash erased state.

@erwango This might be used now on some STM32L1 SoCs which has 0x00 as flash erased state.

I was gonna try it a few weeks ago but seems like the stm32 flash driver does not support L1 as of yet.

I was gonna try it a few weeks ago but seems like the stm32 flash driver does not support L1 as of yet.

Thanks @utzig !

@erwango @utzig ping

Thanks for pinging me. Though, I don't have ways to test this right now and I'm not sure my review has much added value.
What I would suggest though, is to move erase-value prop value definition from zephyr,sim-flash.yaml to flash-controller.yaml so that it could be used widely. Not sure this is the topic of this PR though.

@erwango ^^ PR is no related to where erase-value property is defined.

cc @carlescufi This is ready.

@de-nordic can you rebase this? seems like the doc build error was solved in master


Print instead of error

Here the code prints a "warning" to the user. However, this may go unnoticed.
The effect is an empty phantom. IMO the code should raise an exception, or possibly return None

thanks, yes I'm currently adding a couple of other things and will fix that as well.


Invoking external command lines (utilities) is broken with respect to quoting on Unix

Related: #3733
Steps to reproduce
/bin/sh -c "echo 'hi, mom'"
/bin/sh -c 'echo "hi, mom"'

Expected behavior
hi, mom
hi, mom

Actual behavior
hi, mom
hi,

The following literals should be passed through to sh (there's nothing for PowerShell to interpret here):
echo 'hi, mom'
echo "hi, mom"

To a POSIX-like shell, these two commands are equivalent (not generally, but with the given strings).
Unexpectedly, in the case of the 2nd command, 2 arguments are passed ($<n> represents the n-th positional parameter):
$1=[echo hi,]
$2=[mom]

Environment data
PowerShell Core v6.0.0-alpha (v6.0.0-alpha.18) on macOS 10.12.4
PowerShell Core v6.0.0-alpha (v6.0.0-alpha.18) on Ubuntu 16.04.1 LTS

Am I wrong, or is this a duplicate of https://github.com/PowerShell/PowerShell/issues/1995 and https://github.com/PowerShell/PowerShell/issues/3049 ?
I hope that this will be solved, RFC:
https://github.com/PowerShell/PowerShell-RFC/pull/90

@TSlivede you're right, resolving as dupe and making the original higher priority


cosmetic change to CameraDisplay

Just a small visual update:

put Frame name in small text in lower-righthand corner
use correct axes labels from frame

Maybe we want to make the frame name optional? Or just add as a method?


json-server and ie caching

Hi!
I usually add Date.now() to query for preventing caching ajax request in IE.
But this not working for json-server. Example. json-server returns empty answer.
What is the best way to do this with json-server?

Hi @Semigradsky!
I've added no cache headers based on this https://support.microsoft.com/en-us/kb/234067 in v0.7.14.
Could you tell me if that solves the problem?

Great! That should helped. :+1:


fn rav1d_create_lf_mask_inter: Hoist assert out of loop

I did, I'll re-open later if there's anything to gain here.


Update d2sqlite and use our fork

We will temporarily use our fork until
the ownership of d2sqlite is transferred
to another owner (probably dlang-community).
This update includes setting up proper SQL error
codes so we can check them in Agora.

If it annoys you

I would be fine with it if it was a script I could run. :P

It looks like dockercloud fails. Is it because the fork is not an allowed repository? CC @Geod24

No it's because the submodules aren't synced. But it's not worth adding to the hook given how frequently we need it.


Adds SignatureHelpHandler

This pull request adds SignatureHelpHandler to #968

don't forget to integrate it into LanguageServerHost similar to https://github.com/OmniSharp/omnisharp-roslyn/blob/da2075c99e964918041b3ccf84b2926c694d50ef/src/OmniSharp.LanguageServerProtocol/LanguageServerHost.cs#L139

👍 👏


Vehicle falls apart

@harryzhang1018 title. Vehicle seems to fall apart in the main branch (after #49 gets resolved and #51 gets merged), when using the python sim. @AaronYoung5 thinks this has to do with the control node, any ideas?

@StefanCaldararu  @AaronYoung5
Hey guys, I am able to reproduce the bug in chrono main branch by setting up alternative steering command of -1 and 1, for example, at each time step, steering respectively equals to (1, 1, 1, 1, -1, 1, 1, 1,..). So I think this is a bug regarding Chrono::Vehicle::ARTcar.

Is the solution then to have a layer between control commands and the vehicle? I believe this should be the case anyways.

Is the solution then to have a layer between control commands and the vehicle? I believe this should be the case anyways.

@AaronYoung5 I agree the solution should be the "clip" layer of steering command changing rate between vehicle and command, something like:
if (d_steering < max_d_steering) {steering = steering} else {steering = steering +\- max_d_steering}
But I would say it should be inside chrono, cuz ART may not be the only place the Chrono::Vehicle::ARTcar get used.
Thoughts?

Is the solution then to have a layer between control commands and the vehicle? I believe this should be the case anyways.

@AaronYoung5 I agree the solution should be the "clip" layer of steering command changing rate between vehicle and command, something like: if (d_steering < max_d_steering) {steering = steering} else {steering = steering +\- max_d_steering}
But I would say it should be inside chrono, cuz ART may not be the only place the Chrono::Vehicle::ARTcar get used. Thoughts?

Other chrono vehicles can "achieve" any steering input that's passed to it, we should keep this the same. So I think the clipping should happen on the control side or maybe some intermediate node.

Is the solution then to have a layer between control commands and the vehicle? I believe this should be the case anyways.

@AaronYoung5 I agree the solution should be the "clip" layer of steering command changing rate between vehicle and command, something like: if (d_steering < max_d_steering) {steering = steering} else {steering = steering +\- max_d_steering}
But I would say it should be inside chrono, cuz ART may not be the only place the Chrono::Vehicle::ARTcar get used. Thoughts?

Other chrono vehicles can "achieve" any steering input that's passed to it, we should keep this the same. So I think the clipping should happen on the control side or maybe some intermediate node.

Ummm I see what you mean here. It's prob hard to set up clipping constraint on the driver input for all other vehicles in chrono.
Then we should write this clipping constraint in control node probably.

Fixed by #62


Lack of simplicity.

Nice code which is easy to understand, but just lack of some simplicity. For example, if the number of values more than 2, it's hard for us to expand it in dimension.

hh


Trying to understand clang-format

CI_BRANCHES:NEURON_BRANCH=master,

Fix already merge #471

Fix already merge #471


MiniPerfTest: no subclassing, inject lambda instead

Let's see if this could fix #2056.
(Not sure about the name MeasurementUnit. Maybe just Unit or UnderMeasurement?)

Unfortunately this does not seem to fix the perf problem :/

Not sure about the name

Task?

Ok. I just tried with the latest JDK16 build where it is supposed to be fixed but it even got worse: instead of +7% I now see 15% ...

Did you try
MiniPerfTest miniPerf = new MiniPerfTest().setIterations(count).start(this::myTask);

// ...

private int myTask(boolean warmup, int run) {
            double lat = rand.nextDouble() * latDelta + bbox.minLat;
            double lon = rand.nextDouble() * lonDelta + bbox.minLon;
            int val = idx.findClosest(lat, lon, EdgeFilter.ALL_EDGES).getClosestNode();
            return val;
}

instead of
MiniPerfTest miniPerf = new MiniPerfTest().setIterations(count).start((warmup, run) -> {
            double lat = rand.nextDouble() * latDelta + bbox.minLat;
            double lon = rand.nextDouble() * lonDelta + bbox.minLon;
            int val = idx.findClosest(lat, lon, EdgeFilter.ALL_EDGES).getClosestNode();
            return val;
        });

No idea if this makes a difference, but the second case with the lamdba might be just another syntax for an anonymous class while the first is actually referencing a method.. (just having a guess here)

the second case with the lamdba might be just another syntax for an anonymous class while the first is actually referencing a method.. (just having a guess here)

I stumbled over contradicting statements, but it seems to be implementation specific. I.e. a lambda can be an anonymous class or a method handle or similar. Still it is likely a private static method created at runtime for recent JDKs.
E.g. When I try to print getClass() inside the method I only get the special class name ala "Test$1" for the anonymous class not for the lambda or for the method reference.
I think we should try to migrate to JMH somehow to avoid non-standard surprises and/or wait that this is fixed in the JVM instead of investing more time here.

I think we should try to migrate to JMH somehow

Ok, I think this PR is a good step into this direction. The methods we now pass into MiniPerfTest will be the annotated benchmark methods in JMH later.


fix/node env session parse

fixes issue parsing DAGGER_SESSION_PORT and DAGGER_SESSION_TOKEN

Hola @marcosnils 👋. Quick question, why the yarn.lock did change ?

Hola @marcosnils wave. Quick question, why the yarn.lock did change ?

Because I did a yarn install in my workspace and yarn bumped automatically all the PATCH versions given how dependencies are defined. I'd assume this is very common?

Hola @marcosnils wave. Quick question, why the yarn.lock did change ?

Because I did a yarn install in my workspace and yarn bumped automatically all the PATCH versions given how dependencies are defined. I'd assume this is very common?

Ok make sense, not a big deal.

@marcosnils Do we need to ship a hotfix release or can this wait until next week for regular releases?


Creating new array results in internal error.

Creating an Array with new results in an error 99999.
./slangc file.slang -o file.cpp
void test()
{
    var arr = new Array<float>(12);
}

or something like
float* test()
{
    return new Array<float>(12);
}

Slang version: v2024.1.12

Using reference types for C++ features is not currently supported or planned. This was part of an unfinished prototype that we don't plan to productize in the near or medium future. Closing this issue for now. Please reopen if there are concerns.

But how would one create a dynamically sized array for host side use?


Mistakes in legend for fillbetween

Hi,
I'm using the following code to plot my figure:
`import matplotlib as mpl
import matplotlib.pyplot as plt
import numpy as np
mpl.style.use('seaborn-colorblind')
from matplotlib2tikz import save as tikz_save
fig = plt.figure(figsize=(7,4))
ax = fig.add_subplot(111)
ax.fill_between([1, 2],[2, 2],[3, 3],color = 'red',alpha=0.2, label ='roh')
ax.fill_between([1, 2],[4, 4],[5, 5],color = 'blue',alpha=0.2, label ='kal')
ax.plot([1, 2],[2, 5],'k',label='ref')
ax.grid()
plt.legend()
tikz_save('minimalbeispiel.pgf', figureheight='4in', figurewidth='5in')`
The python export of the figure looks fine:

But unfortunately the generated code in Tex looks like that:

I don't know how to deal with it.
Best regards,
Axel

I think #243 comes a little closer to what you want.


Update zh-CN.json | Improve translations

[x] I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[x] 🔥 Performance Improvements
[ ] ✅ Test
[x] 🤖 Build
[ ] 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 tech-docs
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

I have read the CLA Document and I hereby sign the CLA

@any contributor @holton-jiang l10n

@holton-jiang can you please contribute your future suggestions via https://crowdin.com/project/anytype-desktop, so that other translators can verify them?


Handle empty reply separately from non-empty reply that is empty once parsed by Agent.clean_reply

Have had an issue where the llm returns a poorly formatted function, e.g. MyFunction (without the brackets), and then Agent.clean_reply parses this and returns an empty string. The feedback the llm gets in this case (Error: empty reply, retrying here) isn't very informative, so it ends up repeating the same mistake until it aborts after max_retries are exceeded.
A suggestion is to give informative feedback to the LLM if the reply is not empty, but is empty once parsed by clean_reply.
Will put a PR up myself over the coming days if nobody else takes it 😄

We faced the exact same problem recently :sweat_smile:
Yes passing something more informative to the LLM would be great!
Probably something like
            original_reply = self.llm(self.history + transient_history + temp_messages, stop=self.stop_list)
            reply = self.clean_reply(original_reply)

            if len(reply) < 2:
                print(colored("Error: empty reply, retrying", "red"))
                temp_messages.append(dict(
                    role="assistant",
                    content=original_reply
                ))
                temp_messages.append(dict(
                    role="user",
                    content="Error: please provide a valid function call"
                ))
                continue

            print(colored(f">> {reply}", "yellow"))

could mitigate the problem but we have to try it to be sure

Solved in  #15

Hey @galatolofederico I'm not sure if this should be closed. I think https://github.com/galatolofederico/microchain/pull/15 solves a separate issue.

Sorry, I spaced out :sweat:  I blame it on the Italian summer heat :hot_face: :laughing:


Option to ignore certificate errors

Hi again!
In puppeteer you can pass ignoreHTTPSErrors: true to the launch config which sends the command
'Security.setIgnoreCertificateErrors', {ignore: true}.
It would be great to have this option in chromic_pdf too.

🤔  why exactly is this useful? sounds like a security issue to me, if your certificates don't validate?

🤔  why exactly is this useful? sounds like a security issue to me, if your certificates don't validate?

Yes, it's a security issue, so it should definitely not be true by default.
But in a specific setting you may have internal ip:s and/or not access to the proper infrastructure to set up certificates. It could be a dev environment or some integration testing platform.

Yes, it's a security issue, so it should definitely not be true by default.
But in a specific setting you may have internal ip:s and/or not access to the proper infrastructure to set up certificates. It could be a dev environment or some integration testing platform.

FYI: Looking at the docs it seems this is a Page-level option, so you'll need to set it in SpawnSession, not PrintToPDF.

FYI: Looking at the docs it seems this is a Page-level option, so you'll need to set it in SpawnSession, not PrintToPDF.

@norpan went ahead and implemented it, as I also wanted to improve error handling for SSL errors. Hope that's ok.

@norpan went ahead and implemented it, as I also wanted to improve error handling for SSL errors. Hope that's ok.

Thank you, I'll try it out!

Thank you, I'll try it out!


Download file from remote FTP server does not work (downloads empty file)

Expected Behavior
Download file from remote FTP server
Actual Behavior
The file is downloaded but the content is empty,
rewriting local file with empty content.
Steps to Reproduce the Problem

Openn local file with some content, the same file is on FTP server, with the same or different content
Right click -> Download file

Requisites (important to diagnose the problem!)
Until the latest update everything worked fine, but now after [0.8.10] update, uploading and downloading files with FTP config does not work, and uploadOnSave does not work either.
When downloading file, the content of the remote file is empty, even if the file actually has content.
So if I want to download file from server, my local file is overwritten with empty content.
Permissions on the remote file are 0777.
I am using user credentials that have rights to read/write to that file.
Extension Logs
On downloading i get:
[debug]: task: download

[debug]: download /path/to/remote/file.php at Mon Nov 20 2017 16:19:17 GMT+0100 (CET)

Specifications

Version: 0.8.10
Platform: Linux x86_64

VS Code info:

Version 1.18.1
Commit 929bacba01ef658b873545e26034d1a8067445e9
Date 2017-11-16T18:34:22.110Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Nevermind, I've got wrong path in config, sorry.


Prioritize transactions by gas price

This is a rough sketch of an Idea I had about prioritizing transactions according to gas price in runtimes that pallet ethereum as well as other FRAME pallets.
This code doesn't compile, it is just meant to share an idea. It's a slightly different approach to the one from #375

I'm closing this because it hasn't gotten review and it is too hard to update the Substrate dependency here. I'll do this directly in Moonbeam instead. See https://github.com/PureStake/moonbeam/pull/581


Live

test PR

Docs Build status updates of commit 3b8a0e7:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

test PR


how to reuse OSQPWorkspace *work ?

It seems difficult to reuse OSQPWorkspace,  because there is mem alloc in each call of
int ret = osqp_setup(&work, &data, &settings_);

If I call osqp_clean after each osqp_solve,  will it create memory fragment ?

How are you planning on reusing the OSQPWorkspace structure?
The osqp_cleanup function will go through and free all memory that OSQP allocated in the workspace, but that is usually only needed after you are finished with your problems.

Also, questions like these are more suited to the OSQP discourse forum here: https://osqp.discourse.group/ rather than as GitHub issues.


Fix a test in runnable/test42.d failing for 64-bit reals

Seems like the original author thought about ulong.max being 2^64.
How should 2^64-1 be representable in a double with 53 mantissa bits?

LGTM.

Auto-merge toggled on


LoadWorldEvent & UnloadWorldEvent is not fired at startup

I am currently running

SpongeVanilla version: e0ecf137
Java version: OpenJDK "16.0.1" 2021-04-20
Operating System: KDE neon 5.23

Issue Description
The LoadWorldEvent and UnloadWorldEvent is not fired at startup. Judging by the code these events are only fired when worlds manually loaded/unloaded via WorldManager.

Loading at startup is handled by us in SpongeWorldManager so that works now.
As for unload I am not sure...
We fire it on manual unload before saving and closing the world. (Note that we also have a SaveWorldEvent.Pre/Post)
We could fire an unload event for all active worlds before saving when shutting down the server.
Opinions?

Seems reasonable to me, the worlds are being unloaded after all.

Yes that is fine to fire the unload then.


Switch to Mimic release of Ceph for testing.

Fixes https://github.com/rusoto/rusoto/issues/1158 on my machine. 😉
Per http://docs.ceph.com/docs/master/releases/schedule/ the Mimic release is the latest release, from June 2018.
I did a lot of digging around the Ceph bug tracker and scouring the internet but couldn't figure out why the latest Luminous release kept trying to bind on a port twice. 🤷♀

I think a temporary change to only use the latest version of Ceph, Mimic, is a good way to fix the Semaphore build. We can revisit getting the Luminous version working later. Thoughts?


Incorporate a changelog.md

We should start describing the changes we make for each version.

Yes please, at the moment I'm reading commit notes to find out...

@OliverM We write pretty comprehensive release notes that cover all changes. It just hasn't been made to a changeling.md.

Good to know @mrmrs thanks

The release notes at https://github.com/tachyons-css/tachyons/releases are fantastic. I wouldn't both adding a CHANGELOG.md as well. What's the use-case?

@camwest changelog is downloaded with project. Release notes are fairly invisible and easy to miss. But glad you like the release notes :) I've tried to make them not the worst to read.

@mrmrs Since we've already got release notes hosted on GitHub, what if I just wrote a little script that downloads them into a file?

@mrmrs I used to only use Release notes, but if you decide to move this project away from GH, you will lose that information

For now we'll continue with GitHub release notes.

@mrmrs & @johno, first thanks for Tachyons!
Tachyons is currently at v4.12 but it seems (?) like release notes stopped at v4.9.1?
Is there somewhere I can find descriptions of releases after v4.9.1?


How to use Vizad tool

I run comments and clicked
http://localhost:5006/Vizard
I got "Unable to connect" message. I used Firefox Browser
Thank you

Probably some error when you start the server. When you run the run.sh script you should get some output in your terminal where any errors should be reported. Could be some library version mismatch etc.


Google Sceneform Tools (Beta) plugin crashes Android Studio 3.6

Hello
I tried the "Introduction to Sceneform" codelab here  but whenever I install the "Google Sceneform Tools (Beta)" plugin and restart the IDE, Android Studio crashes with the following error:
Start Failed: Internal error. Please refer to https://code.google.com/p/android/issues

java.lang.IllegalStateException: Couldn't create Engine
	at com.google.android.filament.Engine.create(Engine.java:46)
	at com.google.ar.sceneform.plugin.viewer.Filamentor$3.run(Filamentor.java:103)

I also tested older versions of the Google Sceneform Tools (Beta) plugin from the official website but Android Studio 3.6 still crashes.
I use Android Studio 3.6. Can someone provide a solution for this problem?

(duplicate of several issues including https://github.com/google-ar/sceneform-android-sdk/issues/989)
Things are in a transitional state right now, the plugin is deprecated but v1.16.0
still has some breakage and incomplete features and documentation (also
not AndroidX ready and no maven dep) so not a drop-in replacement yet; but
no new fixes on the plugin would be expected either.
So you may need to run two versions of Android Studio,
one for converting assets using the plugin and the other (3.6) for main development;
fortunately the .sfb doesn't depend on the plugin once it's converted so you can
just copy to res/raw and everything should work.


chore: Ignore docs folder for codeclimate

Proposed Changes

Ignore the ./docs/* folder for codeclimate
Update rollup to 0.53.0

Changes Unknown when pulling 1c5eb37fa8545683679fbb5b0f92c79fb2ad5d2d on chore/codeclimate into ** on master**.


Add documentation for Stone Parameters

closes https://github.com/dipdup-io/stone-packaging/issues/28 I have added the documentation page on how to create a parameter file for the Stone prover

Unfortunately, the PR seems to be created by ChatGPT without testing. For instance, cpu_air_prover doesn't support YAML, and there're no optional fields.

My bad @dmirgaleev I should have asked you before doing the PR, I thought it was correct but you are right I supported myself too heavily with AI. Is there any chance I can redeem myself by fixing it, and sorry for wasting your time with this last PR.


Message from verifier complains about "Quantifiying over variable that is a method parameter"

Here is the command:
pandaPIparser -V domain.hddl p01.hddl shop-plans/p01.hddl

(I will make all the files available)
Here's the output:
 Matching Task 36 Curpos=0 #sources=1
 Task is: ship-an-order o5
 Attempting matching with source __t_id_8
  Setting ?o = o5
   Unassigned variable ?p
      Quantifiying over variable that is a method parameter: ?p

Task 36 is as follows:
36 (ship-an-order o5) -> ship-an-order-1 8

Here is the task definition:
 (:task ship-an-order :parameters (?o - order))

Here's the definition of ship-an-order-1:
  (:method ship-an-order-1
    :parameters (?order - order ?avail ?new - count)
    :task (ship-an-order ?order)
    :precondition
    (and (goal-shipped ?order)
         (not (shipped ?order))
         (forall (?p - product) (imply (includes ?order ?p) (made ?p)))
         (stacks-avail ?avail)
         (next-count ?avail ?new))
    :ordered-subtasks
    (ship-order ?order ?avail ?new))

This seems to be related to the verifier not liking the quantified precondition.  In the source, obviously, there is no method here, but I believe there's something in the transformation performed by pandaPIparser and/or pandaPIgrounder that is expanding this precondition into a method?
Gist with all the input files

I found another issue that is strange: when I run the verifier without verbose output (with -v instead of -V), it produces a different result and notably does not stop.
pandaPIparser is configured as follows
  Colors in output: true
  Mode: plan verification
  Verbosity: 0
  Lenient mode: false
  Ignore given order: false

Checking the given plan ...
IDs of subtasks used in the plan exist: true
Tasks declared in plan actually exist and can be instantiated as given: true
Methods don't contain duplicate subtasks: true
Methods don't contain orphaned tasks: true
Task with id=35 is decomposed with method "make-product-1", but there is no such method.
Task with id=49 is decomposed with method "make-product-1", but there is no such method.
Task with id=54 is decomposed with method "make-product-1", but there is no such method.
Task with id=69 is decomposed with method "make-product-1", but there is no such method.
Task with id=74 is decomposed with method "make-product-1", but there is no such method.
Methods can be instantiated: false
Order of applied methods is under no matching compatible with given primitive plan.
Order induced by methods is present in plan: false
Plan is executable: unknown
Plan verification result: false

This error message also makes sense, as there is no such method and the mentioned IDs decompose different tasks (make-product-complex, make-a-product), which is impossible.
As for the error that you got: The id of the matching task is the ID of the subtask and not of the decomposition that we are currently evaluating. The number of the decomposition we are looking at is given one line before:
Generating Matchings for task with id=31
 Matching Task 36 Curpos=0 #sources=1
 Task is: ship-an-order o5
 Attempting matching with source __t_id_8
  Setting ?o = o5
   Unassigned variable ?p
      Quantifiying over variable that is a method parameter: ?p

The problem lies in the decomposition that is applied to task id=31, which is this method.
  (:method one-step-ship-order
    :parameters (?o - order ?p - product)
    :task (one-step)
    :precondition
    ;; prefer to ship an order, if possible...
    (and (goal-shipped ?o)
         (not (shipped ?o))
         ;; if we must, we could maintain this predicate
         ;; to avoid use of FORALL.
         ;; (ready-to-ship ?o)
         (forall (?p - product) (imply (includes ?o ?p) (made ?p)))
         (started ?o))
    :ordered-subtasks
    (ship-an-order ?o))

The problem here is the variable ?p that is quantified over in the precondition - the variable has already been defined as a parameter of the method - which is not allowed. The variables used in quantification are always local variables.
I've also just fixed the mismatch in error between -v and -V.

The problem here is the variable ?p that is quantified over in the precondition - the variable has already been defined as a parameter of the method - which is not allowed. The variables used in quantification are always local variables.

I think I just expected that normal scoping rules -- in which the inner variable shadows the parameter variable -- would apply.  Is there a specification of scoping rules anywhere in the PDDL or HDDL specs? I have a vague memory of having seen it somewhere, but can't recall where.


Feat: to improve customer retention and drive more traffic to the website by offering incentives like discounts, deals, and special offers.

Overview
The aim is to improve customer retention and drive more traffic to the website by offering incentives like discounts, deals, and special offers. These marketing tactics are designed to increase user interaction and sales.
The tech to be used for this is alerts, popups and notifications.
Key Features

Discounts and Offers: Provide customers with regular discounts, such as "Product of the Day," "Deal of the Day," special offers, or combo deals. These promotions can help incentivize repeat purchases.
Email Subscription for Discounts: Add an email subscription option in the website's footer ad also a small notification, allowing users to sign up for exclusive offers, discounts, and updates. This can help build customer loyalty and keep users informed about upcoming deals.
For Senior Citizen Customers, We can give the link for the WhatsApp community group where the offers shall be regularly updated, since they do not use social media apps like Instagram, discord, telegram etc.

Additional Information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this project proposal
[X] It is not duplicate

@dev129 this one sounds good , but where did you going to implement that
Discounts and Offers: Provide customers with regular discounts, such as "Product of the Day," "Deal of the Day," special offers, or combo deals. These promotions can help incentivize repeat purchases.

This can be done as a small popu in bottom left of screen, or at the landing page in the form of a card with close button of course.

So I have added a small custom modal for displaying the offers and this can be closed only by clicking the Close button

Hi @RamakrushnaBiswal , here is my issue


Add error-handlings of multi-casting

This issue had been already fixed with POST https://api.line.me/v2/bot/message/push, and its iterations.
Since there's duplications between index.js, where it will POST the LINE API for push messages, and multicast.js, where it will using Node.js linebot-sdk, the multicast.js had been removed in PR #16.


Fixes #9 support opensource.org and spdx.org license urls

Added support for opensource.org and spdx.org license urls for fixing #9 .
Unknown licenses are specified as "unknown" instead of throwing error.

This PR reminds me that I need to add standard.js eslint to this project. :-)
If it's convenient, can you try to match the codestyle of the existing code? (It should be pretty close to standard.js style—I'll have to do a migration soon.)

Sorry for my bad coding style.
I have simplified and modified my code to match with existing code style. Please review my changes.

Nice, thanks!


Remove references in arithmetic operation arguments for Weights

Simple PR that removes references to some function arguments in Weight v2.
This is because the Weight struct itself is already Copy, thus it doesn't really need to take references for the sake of performance.
polkadot companion: paritytech/polkadot#6132

But being Copy doesn't make it fast to copy. It is just a marker. It is still larger than a pointer. Not saying that passing by reference will be quicker, though.

Not sure it was a good idea to make it Copy. If we ever want to add another field this struct gets bigger :P
There are also other functions that are taking Self by reference. I mean here it makes sense, as the struct is bigger than the pointer type. However, "smart" tools like clippy will probably start to complain :P


Fix #1821, Group MSG APIs documentation by header type

Describe the contribution
Fix #1821
Improves MSG API grouping in documentation
Testing performed
CI - documentation change only
Expected behavior changes
None
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2021-08-18 APPROVED


Visibility Add-in holding on to previous data frame settings

-----------------------------
# Comment
@tag
Feature: Changing the data frame setting in an ArcMap instance

  Changing the data frame settings based on projected data after un projected has been set

  Scenario: As a user I should be able to reset my data frame properties in the middle of an ArcMap session and Visibility should still work.
    Given a unprojected dataset is added to a map and then removed
    When we add a new projected elevation dataset
    Then we should be able to use the Visibility add-in as expected.
-----------------------------

Adding the bug label.
@topowright Please add additional information to this issue - what version did you find this on. Was it an issue with previous releases?


Use "," or ":" as separator in sed instead of "/" to reduce use of ""

For example, in this line
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/03865f2522f8c00d1438e30237bb82d74d7388c9/perfkitbenchmarker/linux_packages/hpcc.py#L307
instead of writing:
s/\$(HOME)\/netlib\/ARCHIVES\/Linux_PII/%s/
we can simply write:
s,\$(HOME)/netlib/ARCHIVES/Linux_PII,%s,
less backslashes less complexity.

Sounds reasonable. If you have a patch we are happy to review and merge

I think @bvliu fixed this in https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/commit/2c87ffa0847411c5a993cf152526458b65a906f2#diff-9e21eb72c0e7f225b253b5de4e538964  Feel free to reopen if that's incorrect.


Add a KVO to-many notification test for aggregate functions.

This was written with/for the KVO to-many collection feature, but it didn't make it in because we did not, at the time, support aggregate functions.

@msft-Jeyaram is added to the review. #Closed

@MSFTFox is added to the review. #Closed

:shipit:

:shipit:

:shipit:

Thanks everyone; in CI build now.


nest everything in folder in supplement zip

addresses #731

@gregcaporaso the replay supplement tests are in q2cli because qiime2 can't depend on q2cli so changes might be needed over there


Fix multilingual

Some issues related on #1751.
Will fix Multilingual on view Browse and Posts edit-add.

Thanks


Create "Core Reading and Writing" Tutorial

At the end of this task we will have a tutorial page describing the basic reading and writing from Bigtable APIs.  The page will be linked from the top-level Bigtable documentation here:
https://googlecloudplatform.github.io/google-cloud-cpp/latest/bigtable/index.html
It is enough to create a document in bigtable/doc, like the existing bigtable-hello-world.dox.
The tutorial should cover (each one of these tasks should become its own GitHub issue):

[ ] Create a data client.
[ ] Create a data client with an explicit number of connections in the connection pool (e.g. use 2 times the number of CPUs).
[ ] Create a table object (assuming the table exists).
[ ] Read one row.
[ ] Read an open range of rows.
[ ] Read a closed range of rows.
[ ] Read a row but only get the latest cell.
[ ] Read a range of rows (open or closed, does not matter) but only get the latest cell.
[ ] Read a range of rows (open or closed, does not matter) but only get the row keys (use the bigtable::Filter::StripValueTransformer).
[ ] Call MutateRow() with a single cell, using an explicit timestamp.
[ ] Call MutateRow() and use the C++ clock to populate the row with "current time".
[ ] Call DeleteRow() to delete one row.
[ ] Use MutateRows() to write 10 rows in one request.

This is subsumed by #615


Can't override id field when declaring a (MySQL) service

As the docs states, I should be able to change my id field name.

I'm trying without any success to do the following:
app.use('/cities', MySQLservice({
    Model: Cities,
    id: 'id_city'
}));

That has no effect, sequelize is still querying by id instead of id_city. Any help?
Thanks in advance!

That seems odd because it is definitely being tested successfully in https://github.com/feathersjs/feathers-sequelize/blob/master/test/index.test.js#L79 and https://github.com/feathersjs/feathers-sequelize/blob/master/test/index.test.js#L146.
How does the model look like?

Ok, my fault, I do have to specify it on my model declaration. (sequelize newbie here)


In French, add task button's text overflows

The button's text should be "Ajouter une tâche"

Fixed it!


Game crashes on exit if using CanvasItem string drawing functions

Tested versions

Reproducible in 4.3-stable, C# enabled

System information
Godot v4.3.stable.mono - macOS 15.0.1 - Vulkan (Forward+) - integrated Apple M2 Pro - Apple M2 Pro (12 Threads)
Issue description
When running the scene with the attached script, it works fine while its running, however when closing the game it hangs indefinitely. In the editor, there is nothing indicating an error. In VSCode, it shows the following backtrace:
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.3.stable.mono.official (77dcf97d82cbfe4e4615475fa52ca03da645dbd8)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] invoke_previous_action(sigaction*, int, __siginfo*, void*, bool)
[2] 2   libsystem_platform.dylib            0x000000018d890184 _sigtramp + 56
[3] 3   libc++abi.dylib                     0x000000018d811fec __dynamic_cast + 56
[4] RefCounted::unreference() (in Godot) + 196
[5] Theme::~Theme() (in Godot) + 764
[6] ThemeDB::~ThemeDB() (in Godot) + 84
[7] Main::cleanup(bool) (in Godot) + 776
[8] main (in Godot) + 408
[9] 9   dyld                                0x000000018d4d8274 start + 2840
-- END OF BACKTRACE --
================================================================

The script in question is as follows:
using Godot;
using System;

public partial class DrawingBug : Node2D
{
    public override void _Draw() {
        var screenPos = new Vector2I(100, 100);
        var text = "Hello";
        DrawString(ThemeDB.FallbackFont, screenPos, text,
            HorizontalAlignment.Left, -1, 14, Colors.White);
    }
}

This happens with all of the string drawing functions (DrawStringOutline, DrawMultilineString, DrawMultilineStringOutline) I suspect this has something to do with the order of font usage and cleanup.
Steps to reproduce

Open the attached project
Run bug.tscn (contains just a Node2D with the above script attached)
Click the "x" to close the window

Minimal reproduction project (MRP)
drawbug.zip

This issue actually has a bit larger scope than I thought, as the crash happens even if the object has been long destroyed:
    public override void _Draw() {
        var screenPos = new Vector2I(100, 100);
        var text = "Hello";
        DrawString(ThemeDB.FallbackFont, screenPos, text,
            HorizontalAlignment.Left, -1, 14, Colors.White);
        // Crash still happens despite draw call not running at quit time
        this.QueueFree();
    }

A workaround for this issue is to use a custom font instead of the ThemeDB.FallbackFont

Not reproducible with current master.


feat: add lua getstarted at /docs/GetStarted.md

@techoner @ErikQQY plz reivew.

Good job!

@Edmond-J-A plz sign off with your meaningful email, but not something like<EMAIL_ADDRESS>

@hsluoyz plz review.


Error in SUPPA: Clustergroups are assigned incorrectly

Description of the bug
Hi,
For one of my contrasts (pdx_41-control_don) the group parameter for CLUSTEREVENTS_IOI (suppa_clusterevents.nf) is assigned incorrectly, so that ERROR:lib.cluster_tools:Invalid index. Index 6 is smaller than the number of columns in the file (7). occurs. For all other contrasts, the clustergroup assignment works fine.
The related pdx_41-control_don_transcript_diffsplice.psivec file contains seven columns, the correct grouping would be --groups 1-4,5-7:
transcript_pdx_41_1     transcript_pdx_41_2     transcript_pdx_41_3     transcript_pdx_41_4     transcript_control_don_1        transcript_control_don_2        transcript_control_don_3
ENSG00000290825.1;ENST00000456328.2     1.0     1.0     1.0     1.0     nan     nan     nan

It seems that the derivation of the clustergroups for this contrast was never started. The related work directory 0d/4f97644516640eda4e35d88e4dab59 is empty.
(base) -bash-4.2$ grep pdx_41-control_don .nextflow.log | grep CLUSTERGROUPS
~> TaskHandler[jobId: null; id: 164; name: NFCORE_RNASPLICE:RNASPLICE:SUPPA_SALMON:CLUSTERGROUPS_IOI (pdx_41-control_don); status: NEW; exit: -; error: -; workDir: XXX/rnasplice_pdx/work/0d/4f97644516640eda4e35d88e4dab59 started: -; exited: -; ]
activation/XXX/rnasplice_pdx/work/0d/4f97644516640eda4e35d88e4dab59 started: -; exited: -; ]

However, CLUSTEREVENTS_IOI is executed with --groups 1-3,4-6 which causes the error to occur. Could you please help me to understand why and at which point the assignment --groups 1-3,4-6 is made, as CLUSTERGROUPS does not seem to run? Thank you in advance!
 Index 6 is smaller than the number of columns in the file (7).

Work dir:
 XXX/rnasplice_pdx/work/df/888c5d2dcf001bf157d5ddbaffafbb

Relevant files
contrastsheet_pdx_group.csv
samplesheet_pdx_group.csv
System information
CentOS Linux release 7.9.2009 (Core), LSF Cluster
Nextflow version 23.10.1
$(RNASPLICE_DIR) in the pipeline call refers to a fork of nf-core/rnasplice v1.0.2 that increases alignment resources (https://github.com/dkoppstein/rnasplice/tree/increase_sam)

Hey @spraeger
Thanks for reporting your issue. The error arises because the channel which contains the groups parameter is out of sync with the channels which feed the dpsi and psivec parameters. This occurs because Nextflow processes are not guaranteed to return results in the order they arrive from the input channel. This is easily overlooked, and I can only apologise. I've prototyped a solution and will try and get it posted tomorrow as a hot fix for you to test with your data.
James

Hello @spraeger,
I've submitted a pull request with the proposed fix. Could you please test it and let me know if it resolves the issue for you? I'll need to hold off on merging and releasing it until it undergoes a second code review. Thanks!

Hi @jma1991,
Thanks a lot for clarification and the prompt action! I have tested your patch and it resolves the issue for my data.

Hey @spraeger
We have just released 1.0.4 which has this issued fixed. Thanks for bringing it to our attention.


Fixes Issue #122

clementparizot proposed part of solution for #122 by inserting dataTableToSet.put(dataTable, dataset); at line 290 of TopsoilMainWindow.ijmportFromFIle.  However, this only handles case of imported file.  The second  case is when trying to chart pasted data.  The solution here is to confirm dataTableToSet contains table entry inside the initializeAndShow method with:
getCurrentTable().ifPresent(table -> {
    dataTableToSet.put(table, table.getDataset());
});

There may be a more elegant solution, but this works.  I am incoporating both changes in this pull request.

I'm sure I'm responsible for both, but can anyone see the benefit of having both dataTableToSet and TSVTable#getDataset?
If not, isn't
private void initializeAndShow(JavaScriptChart javaScriptChart) {
    getCurrentTable().map(TSVTable::getDataset).ifPresent(dataset -> {
        initializeAndShow(javaScriptChart, dataset);
    });
}

along with removing dataTableToSet altogether the best solution here?

Yes, plus killing a global variable.
On Sat, May 9, 2015 at 2:15 PM, John Zeringue<EMAIL_ADDRESS>wrote:

I'm sure I'm responsible for both, but can anyone see the benefit of
having both dataTableToSet and TSVTable#getDataset?
If not, isn't
private void initializeAndShow(JavaScriptChart javaScriptChart) {
getCurrentTable().map(TSVTable::getDataset).ifPresent(dataset -> {
initializeAndShow(javaScriptChart, dataset);
});
}
along with removing dataTableToSet altogether the best solution here?
—
Reply to this email directly or view it on GitHub
https://github.com/CIRDLES/Topsoil/pull/134#issuecomment-100526038.

--
Jim Bowring
C. Richard Crosby Distinguished Teaching Co-Chair
Principal Investigator, www.CIRDLES.org http://www.CIRDLES.org
Computer Science
College of Charleston
66 George Street
Charleston, SC 29424
Google Voice:<PHONE_NUMBER> (preferred)
Google Email<EMAIL_ADDRESS>Office:
Harbor Walk East (360 Concord Street) Room 308
843.953.0805
http://stono.cs.cofc.edu/~bowring/
<EMAIL_ADDRESS>R. Buckminster Fuller (1972):
If humanity is to survive aboard our planet, it must become universally
literate and preoccupied with inherently cooperative Comprehensive
Anticipatory Design Science in which every human is concerned with
accomplishing the comfortably sustainable well-faring of all other humans.

I closed and replaced with #135.


Dahua video station - lock

Description:
Dahua video station - lock component
It's really useful to unlock video stations of Dahua, I tested it with: VTO2000A and seems to work really good. This is my first component so... I'll really appreciate help you can offer here. If you consider it does not really add much value, I would only need your help to convert it into a custom_component and run it locally. thanks
Related issue (if applicable):
n/a
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
lock:
  - platform: dahua
    name:     'Front door fence'
    user:     'admin'
    password: '0E0C40522588AB4'
    host:      videostation.local

Checklist:

[x] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

This branch is polluted with not related old commits. Please rebase your branch or open a new PR where you've added your commit on top of a freshly synced dev branch.


tour: [REPLACE WITH SHORT DESCRIPTION]

Context: https://go.dev/tour/methods/9
On line 22, a = v should be a = &v
Change the title above to describe your issue and add your feedback here, including code if necessary

Yes, the text explains there's an error that you need to fix. Closing here.