[help wanted] wic tool

Hi @graugans , @drewmoseley  i need your help for another point on secoA62. I have created a rocko image for the secoA62 but i have some problems to create a bootable sdcard with wic ... I have created a file, seco-sdcards.wks :
_part u-boot --source rawcopy --sourceparams="file=u-boot-secosbca62.imx" --ondisk mmcblk --no-table --align 1
part /boot --source bootimg-partition --ondisk mmcblk --fstype=vfat --label boot --active --align 4096 --size 8
part / --source rootfs --ondisk mmcblk --fstype=ext4 --label root --align 4096
bootloader --ptable msdos_
After the build of an image i can create an sdcard that have 2 partitions (boot and FS).
The first problem is that u-boot don't start (can't boot. If i don't use my wks file the card boot and work fine, just need to copy bootscript manually)
The second is that i need to copy a bootscript to the boot partition and i don't know how to do this in wks file ! this is the content of tmp/deploy/images :
├── bootscript
├── dts
│   └── imx6q-seco_SBC_A62.dtb
├── imx6q-seco_SBC_A62.dtb -> zImage--4.1.15-r0-imx6q-seco_SBC_A62-20180321122840.dtb
├── modules--4.1.15-r0-secosbca62-20180321122840.tgz
├── modules-secosbca62.tgz -> modules--4.1.15-r0-secosbca62-20180321122840.tgz
├── sa62_rocko_qt5.9-secosbca62.manifest -> secosbca62-sa62_rocko_qt5.9-v1.0.rootfs.manifest
├── sa62_rocko_qt5.9-secosbca62.testdata.json -> secosbca62-sa62_rocko_qt5.9-v1.0.testdata.json
├── sa62_rocko_qt5.9-secosbca62.wic.bz2 -> secosbca62-sa62_rocko_qt5.9-v1.0.rootfs.wic.bz2
├── secosbca62-sa62_rocko_qt5.9-v1.0.rootfs.manifest
├── secosbca62-sa62_rocko_qt5.9-v1.0.rootfs.wic.bz2
├── secosbca62-sa62_rocko_qt5.9-v1.0.testdata.json
├── u-boot.imx -> u-boot-sd-2015.04-r0.imx
├── u-boot.imx-sd -> u-boot-sd-2015.04-r0.imx
├── u-boot-sd-2015.04-r0.imx
├── u-boot-secosbca62.imx -> u-boot-sd-2015.04-r0.imx
├── u-boot-secosbca62.imx-sd -> u-boot-sd-2015.04-r0.imx
├── uEnv_b08.txt
├── zImage -> zImage--4.1.15-r0-secosbca62-20180321122840.bin
├── zImage--4.1.15-r0-imx6q-seco_SBC_A62-20180321122840.dtb
├── zImage--4.1.15-r0-secosbca62-20180321122840.bin
├── zImage-imx6q-seco_SBC_A62.dtb -> zImage--4.1.15-r0-imx6q-seco_SBC_A62-20180321122840.dtb
└── zImage-secosbca62.bin -> zImage--4.1.15-r0-secosbca62-20180321122840.bin
Can you help on this please ?

Not sure how much I can help here.  Looking at the udoo wks file I do see some differences.  The udoo file specifies "bootloader" on a separate line as well as including the SPL binary.  I don't know if the secoA62 will need something similar or not.

Thanks @drewmoseley , if i use u-boot from seco i don't need SPL binary (i think). I'm not an expert on u-boot and process around that ! Perhaps @graugans can help on this !

They have made some major fault in A62 in my opinion. They do provide different RAM configurations but there is no EEPROM or other way to detect the memory configuration. This means SPL is not needed. It depends on the u-boot you are using if it does provide SPL or not.

Hi, this is the version of u-boot that i use. I don't know if they use SPL (i suppose this is for use uEnv file ?). For the moment, at boot they have a bootscript that send data to kernel for config. Otherwise, if i use sdcard image in IMAGE_FSTYPES i can boot on the card but i have this warning :
The 'secosbca62' is using the i.MX 'sdcard' image format which is deprecated. This image type is going to be removed in next release so please convert this machine to use the wic tool
For the moment i didn't have a good wic config.

Nope, SPL is completely unrelated to Boot scripts and uEnv. For different RAM configurations you need different set-ups. SPL is a small bootloader running before u-boot. This can detect h/w and set-up the RAM controller. When its done it can start either the big u-boot or directly linux (falcon mode)

Ok thanks for your clear explanation !

Hi, with this script the card boot fine, just bootscript file is missing !
_part u-boot --source rawcopy --sourceparams="file=u-boot.imx" --ondisk mmcblk --no-table --align 1
part /boot --source bootimg-partition --ondisk mmcblk --fstype=vfat --label boot --active --align 4096 --size 8
part / --source rootfs --ondisk mmcblk --fstype=ext4 --label root --align 4096
bootloader --ptable msdos_
Need t find how to implement the copy of this file to boot partition

You'll have to decide weather you want to have this script installed to a VFAT partion or in the rootfs. I solved this in the meta-udoo by creating a recipe which installs the script into the rootfs. I personally dislike vfat and do prefere a filesystem which can handle power losses. When I remember correctly it was not simple to have the vfat partion fit in the wic approach.

Ok, i will try to remove the boot partition. To do this how i can proceed  ? perhaps like this in meta-udoo

Yes, maybe checking the git logs arround this commit will help you to understand

With this commit  i have add bootscript to boot partition. For the moment i kept dual partition (for single partition need to change u-boot seco config)


Update azure-monitor-agent-data-collection-endpoint.md

Learn Build status updates of commit 48e090f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-monitor/agents/azure-monitor-agent-data-collection-endpoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


scripts,owner(ticdc): correct line width limit

What problem does this PR solve?
Issue Number: ref #4780
Cc #4847
What is changed and how it works?
Correct line width limit.
Check List
Tests

No code

Release note
None

Codecov Report

Merging #4950 (4d9f2ea) into master (687e248) will decrease coverage by 0.3962%.
The diff coverage is 59.9485%.

Flag
Coverage Δ

cdc
60.8951% <52.9850%> (+0.2964%)
:arrow_up:

dm
51.5990% <63.6125%> (-0.8705%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4950        +/-   ##
================================================
- Coverage   56.1240%   55.7277%   -0.3963%
================================================
  Files           522        523         +1
  Lines         65325      66658      +1333
================================================
+ Hits          36663      37147       +484
- Misses        25094      25845       +751
- Partials       3568       3666        +98

/merge

/merge


is not working

root@2-ubuntu-s-8vcpu-16gb-nyc1-01:~/glaucoma-detector# streamlit run glaucoma_app.py
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
2021-06-17 03:15:44.775025: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2021-06-17 03:15:44.775070: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.

  You can now view your Streamlit app in your browser.

  Network URL: http://<IP_ADDRESS>:8501
  External URL: http://<IP_ADDRESS>:8501

2021-06-17 03:15:45.824426: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2021-06-17 03:15:45.824465: W tensorflow/stream_executor/cuda/cuda_driver.cc:312] failed call to cuInit: UNKNOWN ERROR (303)
2021-06-17 03:15:45.824491: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (2-ubuntu-s-8vcpu-16gb-nyc1-01): /proc/driver/nvidia/version does not exist
2021-06-17 03:15:45.824715: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN)to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-06-17 03:15:45.831907: I tensorflow/core/platform/profile_utils/cpu_utils.cc:104] CPU Frequency:<PHONE_NUMBER> Hz
2021-06-17 03:15:45.832359: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7f13e67b3190 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2021-06-17 03:15:45.832395: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version

how can solve?

Mate if above text is showed then app is working. Just go to any browser and type one of the two URLs. And another thing I want to mention is that.......this application does not work with images of eye (taken from normal camera). We need to give a fundus image of the eye (retina).

Can u share images for test?


docs: Update Readme and generated jazzy documentation

quick fixes to the README
jazzy tag on PR to generated docs

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   70.61%   70.61%
=======================================
  Files           6        6
  Lines         786      786
=======================================
  Hits          555      555
  Misses        231      231

Flag
Coverage Δ

#KituraContracts
70.61% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8d4fd...2dfeeea. Read the comment docs.

@EnriqueL8 I've enabled the Jazzy generation and we've got a docs commit - if you're happy with the result I will merge.


Using upstream lifecycle image that has multi-arch support

Changes

:broom: Update lifecycle image, to use proper upstream, instead of custom

/kind

Fixes #

Release Note

Docs

/approve
/lgtm


[FLINK-27936][tests] Migrate flink-connector-cassandra to JUnit5

What is the purpose of the change
Migrate WriteAheadSinkTestBase and flink-connector-cassandra module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide
Brief change log
Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
Verifying this change
This change is a code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
The S3 file system connector: (no )

Documentation

Does this pull request introduce a new feature? (no )
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

I also rebased to the latest master to avoid FLINK-29161

The CI test failure is most likely connected to FLINK-29093

@flinkbot run azure


[BUG] 4.2.0 doesn't work with styled-components

Hi everyone,
I have read this very recent article claiming styled-components is the future so I decided to give a try.
I want to to customize my reactstrap app. (React equivalent of Bootstrap 4)
I don't wan't to import the bootstrap css stylesheet. I rather make my own styling based on the class used in bootstrap. This is where styled-components come from! I Hoped...
For some reason, the custom theme passed to the <ThemeProvider theme={theme} /> disappear for the one I've configured in my component Button.defaultProps right after a re-rending due to state change.
I've looked into the Button components and I still wonder why. Components look fairly simple.
I have created a webpackbin to demonstrate the issue.
Version
styled-components 2.0.0-7
reactstrap 4.2.0
Reproduction
https://www.webpackbin.com/bins/-KetejqQhRZrV5MyzPpr
Steps to reproduce
Click on the button within the reproduction and see.
Expected Behavior
Custom theme to be applied
Actual Behavior
Default theme is applied

I've opened an equivalent issue here https://github.com/styled-components/styled-components/issues/574

Yeah, definitely looks like an issue on styled-components side. The button, and other reactstrap components just renders the classes which it is told to render. Looking at the example you gave, the Styled(*) component has an internal state generatedClassName which matches what the button is getting/using.
Also, it appears that the theme is making it's way to the props which are passed to the Button... "Warning: Unknown prop theme on  tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop"... Seems like Styled(*) shouldn't be passing down the props it uses.
IDK, but looking at this line in styled-components it looks like it only subscribes and doesn't set the initial state based on the [default] props.

Yeah, definitely looks like an issue on styled-components side.

This is what I am trying to determinate. Why does this issue now appear that I use reactstrap components.

Looking at the example you gave, the Styled(*) component has an internal state generatedClassName which matches what the button is getting/using.

This part work fine, reactstrap doesn't exclude the passed className this is why you can still have the [default] props.theme at every moment.

Also, it appears that the theme is making it's way to the props which are passed to the Button... "Warning: Unknown prop theme on tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop"...

This is because the props.theme should be omitted before passing to the <Button /> component. This can be ignored and is not related to the issue.

Seems like Styled(*) shouldn't be passing down the props it uses.

There is two options:

Add [default] props.theme to your Component
Use a <ThemeProvider theme={{ green: 'green' }}>that will follow the theme to it's children nodes through their props.

IDK, but looking at this line in styled-components it looks like it only subscribes and doesn't set the initial state based on the [default] props

Yes, I have the feeling this subscription is especially for the user theme passed to the ThemeProvider.
It get broken and restored If I switch to another page.
styled-components doesn't have a function that return a <ThemeProvider /> with a user theme in it's props.
I haven't though about that Idea but it might work don't you think?

I only looked at their codebase for 60 seconds so it's hard for me to tell. As far as reactstrap is concerned, reactstrap is being passed a className and using it reactstrap using it.

I have managed to fix the issue but I am not certain on how to behave for my future code.
Version
styled-components 2.0.0-7
reactstrap 4.2.0
Steps to reproduce
I have created 3 cases:

A: Component created with styled.button
B: Component created with class Button2 extends React.Component {} with external [default] props
C: Component created with class Button3 extends React.Component {} with internal static [default] props

Case B use the official recommended syntax for writing props
Case C use static keyword within the class from the proposition of babel, Webpackbin does not support the static keyword so I couldn't reproduce it in the bin.
Copy Paste example and uncomment lines 11 and 13.

In case A: within styles
In case B and C: within render and within styles

https://www.webpackbin.com/bins/-Kf5Tdg7bfj2oWZzIb1V
Problematic Case:
const defaultProps = {
  theme: themeBs,
};

class ButtonClass extends React.Component {
...
}

ButtonClass.defaultProps = defaultProps;
export default ButtonClass;

Fixed Case (Case C):
const defaultProps = {
  theme: themeBs,
};

class ButtonBetter extends React.Component {
  static defaultProps = defaultProps;
...
}

export default ButtonBetter;

Moving the defaultProps inside the component using static keyword solve the issue.
Expected Behavior
Custom theme to be applied
Actual Behavior
Default theme is applied
Questions

Is there any way to use  static keyword in Webpackbin? Or is there any work around to produce an equivalent results? In other words, what does the static keyword exactly do and how to reproduce it without him?

It seems the class doesn't contain publicly  Component.defaultProps or Component.staticProps anymore. Should we support the react way or the babel way ?

What will happen to stateless components and styled if we are obliged to define defaultProps within the component? (As it seems that you cannot define static in non class component (styled.button, stateless components, ...))

We actually figured out the answer which was unrelated to the ReactStrap code. However we did post the question here as it may have had incidence on the reactstrap code.
Answers are as follows:

You can deactivate eslint on webpackbin in settings, ther eis no other support at this time for this issue.

Both different codes are equivalent, that is Problematic Case = to Fixed Case (as described above), [see proof] (https://babeljs.io/repl/#?babili=false&evaluate=true&lineWrap=false&presets=es2015%2Creact%2Cstage-2&targets=&browsers=&builtIns=false&code=class A {
	static a %3D 'hi'
}

console.log(A.a)

class B {
}

B.b %3D 'hi'

console.log(B.b)).

Our issue was related to the sequence of code, where the attaching default props before using styled would apply default props after styling therefor creating issues with final result.

Are these questions best suited for an issue in styled-components library?

I believe the question was asked here as originally we were not sure where the issue was coming from and if it was coming from ReacStrap then it was worth asking here as well (as we posted the question on the other library).
I did not close the topic, because I am unable to, but I answered, in the same line as you, that the issue does not lay within this library.
But thanks for your concern! :)

This was resolved on styled-components side, @L3ARNING2B or @eddywashere you can close it.


Considering main branch as a default one for bundler

Package ecosystem
Bundler.
Package manager version
2.2.29
Language version
Ruby 3.0.2
Dependabot config
version: 2
registries:
  toptal-github:
    type: "git"
    url: "https://github.com"
    username: "x-access-token"
    password: "${{ secret }}"
updates:
  - package-ecosystem: "bundler"
    directory: "/"
    insecure-external-code-execution: allow
    registries:
      - toptal-github
    schedule:
      interval: "daily"
    labels:
      - "no-jira"
    allow:
      - dependency-type: "all"
  - package-ecosystem: "docker"
    directory: "/"
    schedule:
      interval: "daily"
    labels:
      - "no-jira"
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "daily"
    labels:
      - "no-jira"

Updated dependency
yard
gem 'yard', github: 'lsegal/yard'
What you expected to see, versus what you actually saw
I'm getting this message:

The issue is that yard is using main branch instead of master and dependbot is not considering main branch as default.
I've fixed it by adding branch: 'main'. But I think that since main is a default branch name better to update dependabot.

I think this may affect git sources for more ecosystems than bundler, I've labelled this for further triage. Just to confirm my read, when you say:

I've fixed it by adding branch: 'main'

You are referring to the Gemfile, i.e.

gem 'yard', github: 'lsegal/yard', branch: 'main'

You are referring to the Gemfile, i.e.
gem 'yard', github: 'lsegal/yard', branch: 'main'

correct

Related part of dependabot logs

  proxy | 2021/11/23 12:46:20 [049] GET https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
  proxy | 2021/11/23 12:46:20 [049] * authenticating git server request (host: github.com)
  proxy | 2021/11/23 12:46:20 [049] 200 https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
  proxy | 2021/11/23 12:46:21 [051] POST https://github.com:443/lsegal/yard.git/git-upload-pack
  proxy | 2021/11/23 12:46:21 [051] * authenticating git server request (host: github.com)
  proxy | 2021/11/23 12:46:21 [051] 200 https://github.com:443/lsegal/yard.git/git-upload-pack
updater | INFO <job_235978487> Checking if yard 258add90663957b1af3a3fc636d4f50e9c2e2a31 needs updating
  proxy | 2021/11/23 12:46:31 [070] GET https://rubygems.org:443/api/v1/versions/yard.json
  proxy | 2021/11/23 12:46:32 [070] 200 https://rubygems.org:443/api/v1/versions/yard.json
  proxy | 2021/11/23 12:46:32 [072] GET https://rubygems.org:443/api/v1/gems/yard.json
  proxy | 2021/11/23 12:46:32 [072] 200 https://rubygems.org:443/api/v1/gems/yard.json
  proxy | 2021/11/23 12:46:32 [074] GET https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
  proxy | 2021/11/23 12:46:32 [074] * authenticating git server request (host: github.com)
  proxy | 2021/11/23 12:46:32 [074] 200 https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
  proxy | 2021/11/23 12:46:32 [076] GET https://api.github.com:443/repos/lsegal/yard/compare/v0.9.26...master
  proxy | 2021/11/23 12:46:32 [076] * authenticating github api request
  proxy | 2021/11/23 12:46:32 [076] 404 https://api.github.com:443/repos/lsegal/yard/compare/v0.9.26...master
  proxy | 2021/11/23 12:46:32 [078] GET https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
  proxy | 2021/11/23 12:46:32 [078] * authenticating git server request (host: github.com)
  proxy | 2021/11/23 12:46:32 [078] 200 https://github.com:443/lsegal/yard.git/info/refs?service=git-upload-pack
updater | INFO <job_235978487> Handled error whilst updating yard: git_dependency_reference_not_found {:dependency=>"yard"}

Interesting, I thought this was fixed upstream in bundler 🤔

Yes, this was fixed upstream by https://github.com/rubygems/rubygems/pull/4224, released with Bundler 2.2.5. So not sure what's going on here, I guess a way to reproduce would be needed, at least the contents of Gemfile and Gemfile.lock. Maybe the lockfile was locked to an old bundler and that's why things were not working.

✖ Doesn't work:
# Gemfile
...
gem 'dartsass-rails', github: "rails/dartsass-rails"
...

# Gemfile.lock
GIT
  remote: https://github.com/rails/dartsass-rails.git
  revision: d0bf21ba98aab34159525dbd6c7d71a5e295cbf9
  specs:
    dartsass-rails (0.3.0)
      railties (>= 6.0.0)

updater | INFO <job_361095399> Checking if dartsass-rails d0bf21ba98aab34159525dbd6c7d71a5e295cbf9 needs updating
  proxy | 2022/05/05 19:26:18 [026] GET https://rubygems.org:443/api/v1/versions/dartsass-rails.json
  proxy | 2022/05/05 19:26:18 [026] 200 https://rubygems.org:443/api/v1/versions/dartsass-rails.json
  proxy | 2022/05/05 19:26:18 [028] GET https://rubygems.org:443/api/v1/gems/dartsass-rails.json
  proxy | 2022/05/05 19:26:18 [028] 200 https://rubygems.org:443/api/v1/gems/dartsass-rails.json
  proxy | 2022/05/05 19:26:18 [030] GET https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:26:18 [030] * authenticating git server request (host: github.com)
  proxy | 2022/05/05 19:26:18 [030] 200 https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:26:18 [032] GET https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...master
  proxy | 2022/05/05 19:26:18 [032] * authenticating github api request
  proxy | 2022/05/05 19:26:18 [032] 404 https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...master
  proxy | 2022/05/05 19:26:18 [034] GET https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:26:18 [034] * authenticating git server request (host: github.com)
  proxy | 2022/05/05 19:26:18 [034] 200 https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
updater | INFO <job_361095399> Handled error whilst updating dartsass-rails: git_dependency_reference_not_found {:dependency=>"dartsass-rails"}

:heavy_check_mark: works
# Gemfile
...
gem 'dartsass-rails', github: "rails/dartsass-rails", branch: "main"
...

# Gemfile.lock
GIT
  remote: https://github.com/rails/dartsass-rails.git
  revision: d0bf21ba98aab34159525dbd6c7d71a5e295cbf9
  branch: main
  specs:
    dartsass-rails (0.3.0)
      railties (>= 6.0.0)

updater | INFO <job_361101228> Checking if dartsass-rails d0bf21ba98aab34159525dbd6c7d71a5e295cbf9 needs updating
  proxy | 2022/05/05 19:43:50 [252] GET https://rubygems.org:443/api/v1/versions/dartsass-rails.json
  proxy | 2022/05/05 19:43:50 [252] 200 https://rubygems.org:443/api/v1/versions/dartsass-rails.json
  proxy | 2022/05/05 19:43:50 [254] GET https://rubygems.org:443/api/v1/gems/dartsass-rails.json
  proxy | 2022/05/05 19:43:51 [254] 200 https://rubygems.org:443/api/v1/gems/dartsass-rails.json
  proxy | 2022/05/05 19:43:51 [000] GET https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:43:51 [000] * authenticating git server request (host: github.com)
  proxy | 2022/05/05 19:43:51 [000] 200 https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:43:51 [002] GET https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...main
  proxy | 2022/05/05 19:43:51 [002] * authenticating github api request
  proxy | 2022/05/05 19:43:51 [002] 200 https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...main
  proxy | 2022/05/05 19:43:51 [004] GET https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
  proxy | 2022/05/05 19:43:51 [004] * authenticating git server request (host: github.com)
  proxy | 2022/05/05 19:43:51 [004] 200 https://github.com:443/rails/dartsass-rails.git/info/refs?service=git-upload-pack
updater | INFO <job_361101228> Latest version is d0bf21ba98aab34159525dbd6c7d71a5e295cbf9
  proxy | 2022/05/05 19:43:51 [006] GET https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...main
  proxy | 2022/05/05 19:43:51 [006] * authenticating github api request
  proxy | 2022/05/05 19:43:51 [006] 200 https://api.github.com:443/repos/rails/dartsass-rails/compare/v0.3.0...main
updater | INFO <job_361101228> No update needed for dartsass-rails d0bf21ba98aab34159525dbd6c7d71a5e295cbf9

Pretty sure I figured this out. Even if Bundler removed any "master" hardcodes upstream, dependabot was hardcoding "master" in a few places too. #6149 should fix this!


Replace url state with canonical url

I often see urls being shared with the various flags (saved, created) in them.
I also often see them while browsing the history.
Those ideally would not exists, but since we do a redirection on save, we need a way to still display the messages to the user.
The idea behind this commit is to hack the url usign javascript: if the page includes a link rel="canonical" tag in the head section, the javascript will replace the current state with the canonical url. It's also done only on full page load, to let extension read the value before replacing it.
This would not break the existing behaviour and could be removed when the redirection will be removed.

Maybe I should create function dedicated to adding the link tag...

Great!


Elaborate the args validation logic

Add cliOptions flags to control what to accept.

Added to CliOptions:
    this.hasNoCustomOptions = false
    this.hasNoCustomArgs = false

    this.hasMandatoryArgs = false
    this.hasForwardableArgs = false

Fixed on 2019-11-25.


GoAccess: Failure to launch (ERR: 1475, 2150, 2195)

I'm currently trying to run GoAccess on Termux and everytime i try to launch it, this error is what it returns
GoAccess - version 1.7.2 - Apr 18 2023 10:02:21
Config file: /data/data/com.termux/files/usr/etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/goaccess.c - initializer - 1475
No input data was provided nor there's data to restore.

i don't have any clue as to what this is nor do logs even work.
$ goaccess access.log --log-format='%d %t %^: %^: %^: %h, %^: %v, %^: "%r" %^: %^: "%R"' --date-format=%Y/%m/%d --time-format=%T

GoAccess - version 1.7.2 - Apr 18 2023 10:02:22
Config file: /data/data/com.termux/files/usr/etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/parser.c - read_log - 2150
Unable to open the specified log file 'access.log'. No such file or directory

 goaccess access.log -o report.html --real-time-html --addr=<IP_ADDRESS>
 [SETTING UP STORAGE access.log] {0} @ {0/s}
GoAccess - version 1.7.2 - Apr 18 2023 10:02:22
Config file: /data/data/com.termux/files/usr/etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/parser.c - parse_log - 2195
No time format was found on your conf file.

what seems to be the issue?

Based on the error messages you provided, it appears that the access log is missing and your /data/data/com.termux/files/usr/etc/goaccess/goaccess.conf file doesn't have the date/time/log format specified. Additionally, it seems like you are encountering different errors. Could you please clarify which specific error you are currently experiencing?

The main issue that im currently i experiencing is the error code 1475. every time i want to host a http server to monitor the system perf it just throws this error
GoAccess - version 1.7.2 - Apr 18 2023 10:02:21
Config file: /data/data/com.termux/files/usr/etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/goaccess.c - initializer - 1475
No input data was provided nor there's data to restore.

Note: This is running on termux (ARM)

The error message indicates that you haven't provided a log file or any data that GoAccess can read. Make sure to specify a valid log file for GoAccess to process.

Same issue here.
If i want to set the format with terminal
goaccess access.log -c
it ends up with
GoAccess - version 1.7 - Jan  4 2023 18:36:47
Config file: /etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/parser.c - read_log - 2071
Unable to open the specified log file 'access.log'. No such file or directory

Where is the file access.log located and is it recommendable to create a new one manually?

I am also encountering this error, but only when running from cron. I have a shell script that runs and works on the command line, but throws this exact error under version 1.8:

GoAccess - version 1.8 - Sep 30 2023 21:41:52
Config file: /etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/goaccess.c - initializer - 1475
No input data was provided nor there's data to restore.

I am running the same command 4 times pointing to different log names and different output files. It’s just zcat piping the files to goaccess with the combined log output format.  Any help would be appreciated.

@jemaleddin, could you please share the precise commands you've been executing? The error message is pretty much indicating that no log was provided. Thanks

The command is:
zcat -f /var/log/nginx/jemal.co.access.log* | goaccess -o /var/www/html/jemal.co/site/stat-report.html --log-format=COMBINED
And to be super clear, the command runs perfectly fine in.a terminal as my user, as root, etc. - as seen here.

Please be sure to use the hyphen (-) when piping data into goaccess. This will enable it to read from stdin. For example:
zcat -f /var/log/nginx/jemal.co.access.log* | goaccess - -o /var/www/html/jemal.co/site/stat-report.html --log-format=COMBINED

Oh wow - that totally fixed it. I read through the help info on the command line and totally missed that. Thanks so much for much for your assistance -  I really appreciate it!

@jemaleddin Glad that did the job :) Let me know if you have any other questions!


Crash when attempting to compare selection endpoints with UIA

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 21H1 (19603.1000)
Windows Terminal version (if applicable): inbox console

Any other software? NVDA 2020.2

Steps to reproduce

Start the latest NVDA alpha snapshot.
In NVDA advanced settings, enable "use UI Automation to access the Windows Console when available".
Open cmd.
Ssh to an Ubuntu 18.04 system.
Run sudo do-release-upgrade -d.

Expected behavior
NVDA reads the output, and the console remains functional.

Actual behavior
Windows Console crashes, and the following is written to the NVDA log:
ERROR - eventHandler.executeEvent (04:42:19.980) - MainThread (21752):
error executing event: caret on <NVDAObjects.Dynamic_WinConsoleUIAEditableTextWithAutoSelectDetectionUIA object at 0x070733B0> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.pyc", line 155, in executeEvent
  File "eventHandler.pyc", line 92, in __init__
  File "eventHandler.pyc", line 100, in next
  File "NVDAObjects\behaviors.pyc", line 191, in event_caret
  File "editableText.pyc", line 333, in detectPossibleSelectionChange
  File "editableText.pyc", line 340, in _updateSelectionAnchor
  File "NVDAObjects\UIA\__init__.pyc", line 776, in compareEndPoints
  File "comtypesMonkeyPatches.pyc", line 26, in __call__
_ctypes.COMError: (-2147418113, 'Catastrophic failure', (None, None, None, 0, None))

Context
NVDA uses cursor changed events to detect and report selection changes to the user. It receives a cursor change event and compares the previous and current selection endpoints, which causes console to crash in this case. Is there anything I can do to help trace this on the console side?
Please push the fix for this issue to 21H1 as we'd really like to use UIA in console (especially after the excellent work in #4018 and #4495)!

Cc @carlos-zamora @DHowett-MSFT.

For whatever it's worth, this doesn't crash Windows Terminal.

(tentatively throwing this in the 21H1 milestone, but that's totally arbitrary. I figured this is a conhost bug, not a Terminal bug, so that's where it belongs. The team can overrule me ☺ )

Thanks! Marking it triaged. @carlos-zamora ACK if you've seen it.

Yep! I was taking a look at it a bit today. This one is kind of surprising.

Running nano also causes the crash.

Took a closer look at this today. It looks like the root cause is that when we switch over to the alt buffer, we are now in a state where the buffer size may have changed. So when you compare a COORD 'A' from the main buffer to another COORD 'B' from the alt buffer, 'A' may not fit in the alt buffer. This makes the comparison invalid, but a crash on our end is definitely not right.
@DHowett-MSFT suggested that we track which buffer the UiaTextRange came from. Then, when two UiaTextRanges are compared, we first ensure that they came from the same buffer.
We could probably return a relevant HRESULT instead. @codeofdusk is there anything you've seen in other apps that you can expect here?

What do you mean by the alt buffer? If the console is switching buffers, this also might explain some issues I've been seeing with GetVisibleRanges that I haven't been able to consistently reproduce.

To ask more succinctly: how do we respond to say "this comparison is simply invalid. it takes place in two different coordinate systems."?
The alt buffer is a different "screen mode" for terminal applications. It hides whatever was on the screen prior and lets the application have its own sandbox. Once the application is done, it will turn off the alt buffer, permanently destroying its contents.

To ask more succinctly: how do we respond to say "this comparison is simply invalid. it takes place in two different coordinate systems."?
The alt buffer is a different "screen mode" for terminal applications. It hides whatever was on the screen prior and lets the application have its own sandbox. Once the application is done, it will turn off the alt buffer, permanently destroying its contents.

Cc @michaelDCurran.

Also cc @leonardder (author of nvaccess/nvda#9660). Could you please provide advice here?

Sorry, I'm not familiar enough with UIA to answer. Generally, applications I've seen don't have text ranges that behave like this (i.e. two text ranges from the same text where comparison is incompatible).

For whatever it's worth, it does seem that, when I open a word document, get the text range for the document, open a second document, get that text range, and compare endpoints of the two ranges (from separate documents) it returns null:
>>> ti=nav.makeTextInfo("all") # First document
>>> ti2=nav.makeTextInfo("all") # Second document
>>> ti.compareEndPoints(ti2,"endToStart")
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "NVDAObjects\UIA\__init__.pyc", line 776, in compareEndPoints
  File "comtypesMonkeyPatches.pyc", line 26, in __call__
_ctypes.COMError: (-2146233079, None, (None, None, None, 0, None))

Interesting. If that won’t throw off the works, that might be good for us. Ideally, in the long term, we would have different UIA parent objects for the different text buffers.


framac: 21.1 -> 22.0

Notes
I am not 100% sure why, but if apron package is kept as is, frama-c will fail at startup with this:
[kernel] User Error: [findlib] package 'apron.octMPQ' not found (required by `frama-c-eva')

However, when changed to apron.dev, it starts fine and works.
Motivation for this change
New release
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I am not 100% sure why, but if apron package is kept as is, frama-c will fail at startup with this:
[kernel] User Error: [findlib] package 'apron.octMPQ' not found (required by `frama-c-eva')

However, when changed to apron.dev, it starts fine and works.

If you look at https://github.com/NixOS/nixpkgs/commit/63aa105b1c1759029e229ea5d1fda08950956216, you will see that apron's outputs have been split. That means that there is now a specific output for the actual package (bin) and an output for the library (dev). In this case, you want the library, so you have to specify which output you want.

Result of nixpkgs-review pr 104403 1

1 package built:

framac


Site down

https://rtbyte.xyz/ -> Timeout

We're working on a dashboard for the site, but haven't bothered getting a landing page up until that's actually finished. Will get a temporary page up in the meantime. Thanks for filing this, much appreciated!

A landing page has now been put up, sorry it took so long :)
https://rtbyte.xyz/


Add missing python-dateutil from setup.py.

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   69.15%   69.15%
=======================================
  Files          18       18
  Lines         483      483
=======================================
  Hits          334      334
  Misses        149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45760c6...d9b1872. Read the comment docs.

Looks like this was (silently) fixed in https://github.com/jjkester/django-auditlog/commit/f45fb55c8124a944be5d3b7b05fa1457baba1126#diff-2eeaed663bd0d25b7e608891384b7298 ?

yep, thanks for the PR though!


Use most supported flex-end for justify-content in pagination

I got warning from a linter with the current end value.
This should render the same thing.
cf:
https://caniuse.com/#search=justify-content

I know this is a bit old, but I see that @tmerlier changed the justify-content for .pagination from end to space-between in #137 .
Do we keep flex-end or space-between for select.pagination__display ?

@SebastienTouze I think this PR must be merged regardless of #137 , since it causes warnings for everyone.
If it is removed by #137 it's fine but this is not this PR's concern imho

@SebastienTouze I misunderstood your statement since I thought #137 was not merged yet.
I'm fixing this PR according to the modifications from #137 and merging it.


[BUG] RequestResponseSerializer DateTime serialization is inconsistent

NEST/Elasticsearch.Net version:
7.16.0
Elasticsearch version:
7.16.3
.NET runtime version:
NET6.0
Operating system version:
Windows 10
Description of the problem including expected versus actual behavior:
DateRange queries of the form:
Query(q => q.Bool(b => b.Must(m => m.DateRange(...))))
produce inconsistently serialized DateTime values and server errors. RequestResponseSerializer appears to produce unparseable DateTime strings in some use cases.
Steps to reproduce:
public class FacilityModelV2
{
    ... snipped ...

    [Keyword(Index = true)]
    public string Key { get; set; }

    // stored in format: yyyy'-'MM'-'dd'T'HH':'mm':'ss'.'fffzzz
    [Date(Format = "date_time")]
    public DateTime RepositoryTimeStamp { get; set; }
}

var results = await _client.SearchAsync<FacilityModelV2>(s => s
    .Index("some_index")
    .TrackTotalHits(true)
    .Size(1000)
    .From(0)
    .Sort(x => x.Ascending(z => z.Key))
    .Query(q => q.Bool(b => b.Must(m => m.DateRange(r => r.Field(f => f.RepositoryTimeStamp).GreaterThanOrEquals(new DateTime(2022, 11, 18, 11, 6, 55, 0, DateTimeKind.Local))))))
    );

// Additionally, one can observe the incorrect serialization behavior without talking to the server at all.
Console.WriteLine(_client.RequestResponseSerializer.SerializeToString(new DateTime(2022, 11, 18, 11, 6, 55, 0, DateTimeKind.Local)));
Console.WriteLine(_client.RequestResponseSerializer.SerializeToString(new DateTime(2022, 11, 18, 11, 6, 55, 1, DateTimeKind.Local)));

Outputs the datetime value as 2022-11-18T11:06:55-08:00 and the call fails with the following exception:
Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 400 from: POST /some_index/_search?typed_keys=true. ServerError: Type: search_phase_execution_exception Reason: "all shards failed"
at Elasticsearch.Net.Transport1.HandleElasticsearchClientException(RequestData data, Exception clientException, IElasticsearchResponse response)    at Elasticsearch.Net.Transport1.FinalizeResponse[TResponse](RequestData requestData, IRequestPipeline pipeline, List1 seenExceptions, TResponse response)    at Elasticsearch.Net.Transport1.RequestAsync[TResponse](HttpMethod method, String path, CancellationToken cancellationToken, PostData data, IRequestParameters requestParameters)
at Nest.ElasticClient.SearchAsync[TDocument](ISearchRequest request, CancellationToken ct)
at Nest.ElasticClient.SearchAsync[TDocument](Func`2 selector, CancellationToken ct)
Expected behavior
The RequestResponseSerializer should always output values in a format that the server can parse and understand, a DateTime with a 0 millisecond value is valid and expected in the real world.
Provide ConnectionSettings (if relevant):
Provide DebugInformation (if relevant):
More Context:
The mapping for RepositoryTimeStamp is:
{
  "type" : "date",
  "format" : "date_time"
}

when we change the mapping to:
{
  "type" : "date",
  "format" : "date_time || date_time_no_millis"
}

it works, but date_time should work on its own.
We observe this behavior in Kibana as well:
GET some_index/_search
{
  "query": {
    "bool": {
      "must": [
        {
          "range": {
            "RepositoryTimeStamp": {
              "gte": "2022-11-18T11:06:55-08:00"
            }
          }
        }
      ]
    }
  }
}

This fails with the following server error:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "parse_exception",
        "reason" : "failed to parse date field [2022-11-18T11:06:55-08:00] with format [date_time]: [failed to parse date field [2022-11-18T11:06:55-08:00] with format [date_time]]"
      }
    ],
    "type" : "search_phase_execution_exception",
    "reason" : "all shards failed",
    "phase" : "query",
    "grouped" : true,
    "failed_shards" : [
      {
        "shard" : 0,
        "index" : "some_index",
        "node" : "kP_Qc_DJRE6jlrMzSacNlw",
        "reason" : {
          "type" : "parse_exception",
          "reason" : "failed to parse date field [2022-11-18T11:06:55-08:00] with format [date_time]: [failed to parse date field [2022-11-18T11:06:55-08:00] with format [date_time]]",
          "caused_by" : {
            "type" : "illegal_argument_exception",
            "reason" : "failed to parse date field [2022-11-18T11:06:55-08:00] with format [date_time]",
            "caused_by" : {
              "type" : "date_time_parse_exception",
              "reason" : "Failed to parse with all enclosed parsers"
            }
          }
        }
      }
    ]
  },
  "status" : 400
}

And this succeeds:
GET some_index/_search
{
  "query": {
    "bool": {
      "must": [
        {
          "range": {
            "RepositoryTimeStamp": {
              "gte": "2022-11-18T11:06:55.0-08:00"
            }
          }
        }
      ]
    }
  }
}

Thanks for raising this, @cspital. I'll close this as it's a duplicate of #6444, which does need some review. We need to take care with any changes to the serialization behaviour as it may introduce a break for behaviour some users depend on.


Revert "fix: to_string in command macro clashes with lint clippy::str_to_string"

Reverts kangalioo/poise#104

I didn't investigate enough, it also can happen in the parameters name.

I've added a #[allow(clippy::str_to_string)] attribute to the command macro generation


Added Oceania countries with associated frequency plan and exclusive …

…economic zones.
This is the initial add for Oceania using AU915 as the default as used by TTN.
There is a meeting with the LoRa Alliance mid January to confirm this choice.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the contribution @leogaggl
Could you please also add the channel-plan at:
https://github.com/ThingsIXFoundation/frequency-plan/blob/main/go/frequency_plan/band.go#L178

Hey @timcooijmans - have added the band plan as per https://github.com/chirpstack/chirpstack/blob/master/chirpstack/configuration/region_au915_1.toml - hope that is correct.


unique_with Validation does not work for arrays

I am using Laravel 5.3 and the following code doesn't work
$validator = Validator::make($request->all(), [
    'person.*.email' => 'email|unique_with:users,person.*.email=email',
    'person.*.first_name' => 'required_with:person.*.last_name',
]);

It keeps showing and error message saying:
Unknown column 'person.0.email' in 'where clause'

@rishi-ramawat Please help test out #73 and give feedback if possible. It is based on version 3.0.0, so you need to upgrade (Usually only thing necessary is to update the service provider class in your config/app.php, which has been renamed)

hi
how can fix this problem:
'questions.*.question' => 'required|string|unique_with:questions,questions.*.question=question,topic_id,section_id,deleted_at',

exception: "Illuminate\Database\QueryException"
file: "D:\laragon\www\fastmotarjem\vendor\laravel\framework\src\Illuminate\Database\Connection.php"
line: 669
message: "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'questions.0.question' in 'where clause' (SQL: select count(*) as aggregate from questions where questions.0.question = ewfew and topic_id = 1 and section_id = 4)"
trace: [,…]

@asadghazanfary looks correct, which version of the package and laravel are you using?

"laravel": "6.X"
"uniquewith-validator": "^3.4"


Golint complains about not commented functions in test

If I have a file called whatever_test.go and have a function in it like this:
package whatever

func TestWhatever(t *testing.T) {
}

Code Climate complains about lack of comment for "exported" function TestWhatever. This doesn't happen in standard command line version of golint, which ignores tests.

Hey @xfix! Thanks for reaching out about that issue.
I think you bring up a good point, and we can action work to fix this issue.
In the meantime, you have a couple of good workaround options for excluding those files in your .codeclimate.yml like so:

Option 1 - exclude from all engines

---
engines:
  golint:
    enabled: true
ratings:
  paths:
    - "**.go"
exclude_paths:
- "**_test.go"

Option 2 - only exclude from codeclimate-golint

---
engines:
  golint:
    enabled: true
    exclude_paths:
    - "**_test.go"
ratings:
  paths:
    - "**.go"
exclude_paths: []

Is there a reason why not to use the golint command-line tool, which is what people would run locally?
Using the golint library directly introduces inconsistencies between codeclimate and local execution of golint, and makes it possible to have cases in which the users fail to reproduce issues locally.
If the library is used for performance reasons, it will need to be tracking closely the behavior of the golint CLI, which may take time and effort.

I started this on Twitter and was sent here and asked to provide some information: in my case the issue is also reported for function names inside test files: https://codeclimate.com/github/cristim/autospotting/code?sort=smell_count&sort_direction=desc
Executing the golint tool locally doesn't report those.

@cristim I believe I've identified your issue (see #13). Just working on fixing up our build process and should have a fix out soon. Thanks for your patience

@cristim this is live now. Let me know if there's anything else we can do to help


Vehicle group duration regression

I've updated my version of ortools from v6.5 to v6.8.
I'm using the routing library.
What I do is putting a constraint on the maximum duration of a vehicle group. It previously worked, but didn't work on the version v6.8.
Here is constraint working under v6.5
            std::vector<IntVar*> same_vehicle_vars;
            for (int link_index = 0 ; link_index < relation->linked_vehicle_ids->size(); ++link_index) {
              current_index = data.IdIndex(relation->linked_vehicle_ids->at(link_index));
              int64 start_index = routing.Start(current_index);
              int64 end_index = routing.End(current_index);
              IntVar *const cumul_var = routing.CumulVar(start_index, "time");
              IntVar *const end_cumul_var = routing.CumulVar(end_index, "time");
              IntVar *const vehicle_time = solver->MakeDifference(end_cumul_var, cumul_var)->Var();
              same_vehicle_vars.push_back(vehicle_time);
            }
            solver->AddConstraint(solver->MakeLessOrEqual(solver->MakeSum(same_vehicle_vars), relation->lapse));

https://github.com/Mapotempo/optimizer-ortools/blob/master/tsp_simple.cc#L402
relation->linked_vehicle_ids gives us the vehicle id considered within the relation.
data.IdIndex gives us the associated vehicle index of the current vehicle id.

To go a bit deeper in the problem, the issue is the same with v6.9
It returns most of the time a first solution, but goes to a segfault in the next few iterations :
Here is the backtrace obtained with gdb

#0  0x00007ffff795b002 in operations_research::PathOperator::SetNext(long long, long long, long long) () from ../or-tools6_8/lib/libortools.so
#1  0x00007ffff794d4ff in operations_research::PathOperator::MoveChain(long long, long long, long long) () from ../or-tools6_8/lib/libortools.so
#2  0x00007ffff7944058 in operations_research::PathOperator::MakeOneNeighbor() () from ../or-tools6_8/lib/libortools.so
#3  0x00007ffff7942268 in operations_research::IntVarLocalSearchOperator::MakeNextNeighbor(operations_research::Assignment*, operations_research::Assignment*) () from ../or-tools6_8/lib/libortools.so
#4  0x00007ffff7941b72 in operations_research::(anonymous namespace)::CompoundOperator::MakeNextNeighbor(operations_research::Assignment*, operations_research::Assignment*) () from ../or-tools6_8/lib/libortools.so
#5  0x00007ffff7953425 in operations_research::FindOneNeighbor::Next(operations_research::Solver*) () from ../or-tools6_8/lib/libortools.so
#6  0x00007ffff786bb55 in operations_research::Solver::NextSolution() () from ../or-tools6_8/lib/libortools.so
#7  0x00007ffff786cdff in operations_research::Solver::SolveAndCommit(operations_research::DecisionBuilder*, std::vector<operations_research::SearchMonitor*, std::allocator<operations_research::SearchMonitor*> > const&) () from ../or-tools6_8/lib/libortools.so
#8  0x00007ffff794145b in operations_research::(anonymous namespace)::NestedSolveDecision::Apply(operations_research::Solver*) ()
from ../or-tools6_8/lib/libortools.so
#9  0x00007ffff786bcce in operations_research::Solver::NextSolution() () from ../or-tools6_8/lib/libortools.so
#10 0x00007ffff786c208 in operations_research::Solver::Solve(operations_research::DecisionBuilder*, std::vector<operations_research::SearchMonitor*, std::allocator<operations_research::SearchMonitor*> > const&) () from ../or-tools6_8/lib/libortools.so
#11 0x00007ffff79b9218 in operations_research::RoutingModel::SolveFromAssignmentWithParameters(operations_research::Assignment const*, operations_research::RoutingSearchParameters const&) () from ../or-tools6_8/lib/libortools.so
#12 0x000000000041f103 in operations_research::TSPTWSolver(operations_research::TSPTWDataDT const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator >) ()
#13 0x000000000040f760 in main ()

Got a little progress by my side.
It appears that we provide an initial Assigment with partial routes, which didn't breaks the problem constraints, here the total duration a vehicle group. Things which previously didn't end into a segfault.
By not providing an Initial solution, the solve finish correctly, but the result is far from the expectation, and actually pretty bad.

A subpart of the problem :
If a first solution is provided with an assignment the first solution strategy must not be called. From this assessment, I can suppose that providing empty routes should force the search to start the solve or returning an error.
In such case, the solve just never ends.
https://gist.github.com/braktar/c93d6424ba88e9986fee4103ac3f42d2
Here is an illustration using the CVRPTW.cc example. The interesting part is from lines 137 to 147.
This is not generating my SegFault, but the behavior is unexpected.

obsolete version. CLosing the issue.


Edit right click context menu's

Provide an easy interface to edit context menu's of diffrent kinds.
Several context menu's come to mind:

Desktop.
My computer (This PC).
Folders.
And of course files.

Some expantion on file context menu's:
I think the best way is to have a default menu for all file extension.
And then allow the user to change specific file type's menu's.
Examples:

i want "edit with clion/intellij/pycharm to only show on their specific files types.
"edit with notepad++" only on c/py/sh(...) files.
i want no share option on any file xD.
remove "nvidia control panel" from the desktop context menu's
add common (specific to user) control panel section to My computer context menu.

I'm sure there's lots more.
In adition the shift+right click will always show the windows default extended context menu's.
All this functionality in its entirety can be found in afew very outdated programs with very lousy design and ever expending bug list, and can be done through registry editing to some extent.
I think this will be very useful to have, and reduce clutter.
Thank you for the time and effort.

@sagy101
add your comments to https://github.com/microsoft/PowerToys/issues/33

@sagy101
add your comments to https://github.com/microsoft/PowerToys/issues/33


Service Dependency Injection doesn't work always with version 0.0.39

Short description of the problem:
Service dependency injection doesn't work always with version 0.0.39 (default is webpack with this version), however same code without any changes works fine for version 0.0.36 (default is roll-up with this version).
I am using Angular 2 barrels to organise my imports. Upon digging up the problem found that the  service getting failed worked fine if I import it as direct file reference.
What behaviour are you expecting?
Service dependency injection should work regardless of webpack, rollup or barrels being used or not.
Steps to reproduce:

Privately Emailed @danbucholtz the sample code.
run npm install on the project and doing ionic serve should give this error in the console
Uncaught Error: Can't resolve all parameters for LoginComponent: (App, NavController, MenuController, ?, Events, LocalStorageService, ErrorParserService).(…)
May be a Barrel related issue:  Error will go away if you change the import statement in LoginComponent
import { LoginService } from '../../account';
TO
import { LoginService } from '../../account/login/login.service';
OR
import { LoginService } from './login.service';
May be a webpack related issue: Error on Step 2 will also go away if you downgrade ionic-app-scripts version to 0.0.36. To verify theory undo the code changes on Step-3 and downgrade the version to 0.0.36.

Sample Code
import { NavController, MenuController, App, Events } from 'ionic-angular';
import { Component } from '@angular/core';

import { LoginService } from '../../account';
import { UserRegistrationComponent } from '../../account/user-registration';
import { DevicesTabComponent } from '../../shared/navigation';
import { LocalStorageService } from '../../shared/storage';
import { LoginResponse } from '../../shared/contracts';
import { ErrorType } from '../../shared/constants';
import { ErrorParserService } from '../../shared/services';

@Component({
    templateUrl: 'login.component.html'
})
export class LoginComponent {

    public email: string;
    public passWord: string;

    public loginResponse: LoginResponse;

    constructor(public app: App, public nav: NavController, public menu: MenuController,
        public loginService: LoginService, public events: Events,
        public localStorageService: LocalStorageService,
        public errorParserService: ErrorParserService) {

        this.loginResponse = new LoginResponse();
    }

Which @ionic/app-scripts version are you using?
Your system information:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.4
Ionic App Lib Version: 2.1.2
Ionic App Scripts Version: 0.0.39
OS: Windows 7 SP1
Node Version: v6.9.1

I have a problem force bundler rollup

@savanvadalia,
If you run ionic serve does it work correctly? It only errors out on device, right? This seems to be an ngc error. Please let me know so we can address the situation.
Thanks,
Dan

@danbucholtz
No, if fails on ionic serve itself.
Thanks
Savan

@danbucholtz Also I updated to latest ionic-app-scripts to latest version 0.0.42 and the same issue still persists.
On a side note new build error reporting looks great  :clap: :clap: :clap:
First of all I was expecting my error to be reported and for sec thought why its not working.
But realised this particular error is a run-time error and not compile time and hence it doesn't show up,
Thanks
Savan

@danbucholtz  Any updates on this?
Problem still persist in 0.0.44 with webpack.
Switching back to rollup
OR
importing the file with complete path still works fine with webpack.
I hope we some sort of fix for this as  I have used barrels heavily in my project.

Hello all! I am going to close this issue as a duplicate of https://github.com/driftyco/ionic-app-scripts/issues/315. Thanks!


VACMS-15122: Fetches all resources by gluing pages together.

Overcomes previous limit of 2000. The previous limit was made possible by a mechanism provided by next-drupal that overrides the limit of 50. This PR uses the individual page limit of 50, but fetches all pages (in parallel, other than the first, which is fetched before all others to determine the total number of pages to be fetched) and glues them together.
Description
Closes https://github.com/department-of-veterans-affairs/va.gov-cms/issues/15122
Testing done
Built on Tugboat. Resources that were previously missing are now present. Built page count increases by ~1000.
Screenshots
Before

After

QA steps
The successful build on this PR is really the QA. We can spot check that some pages exist. Notably, this page exists and it doesn't exist on the main build as of this writing (before this PR): https://pr171-g7n6873xmk17g4fitznzmw89ondeln9k.tugboat.vfs.va.gov/minneapolis-health-care/stories/challenging-advanced-dementia-patients-often-need-a-bro/

@jtmst

I see that we are deserializing the first page and not the rest, is the end result an array where the first page has a different structure than the rest? Is that a potential issue?

The first page needs to be deserialized initially to include the count, so we know how many pages to fetch overall. Later pages can return serialized already because we don't need to re-find that info.

Is the number of simultaneous requests that could possibly come through a concern? Should we look at rate limiting?
yes.


Fix release pipeline to checkout before performing release

Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
In this PR, we again continue our endeavor to fix the pipeline to release in one click. I was missing a few actions in the release step to create a new branch to perform the release from there.
Special notes for reviewers:
Additional information (if needed):

The old maven release plugin was making a mess in our git history, hopefully now we got this fixed.


Intellisense (type script) sorting not alphabetical

Issue Type: Feature Request
Either the sorting or the selection of the available options is not working well. I expected sorting in the intellisense to be alphabetical. For some reason imports are sorted above matches that do not match the typed string. This I can understand but what is anoying about this behaviour is that when you start typing intellisense (what feels like randomly) selects the closest entry from the already imported list or the non-imported list. This happens even if alphabetically a beter match is available in the other list.
I have been working with intellisense long enough that I generally know the relative position of a function and key (up/down) to it, but because of the switching start position I either have to key through more lines or type more (both of which break the flow).
The biggest issue with this is as follows

you need to import something new
so you start typing
the selection is in the currently imported section so you have to go down to the non-imported matches
you select the entry, it is inserted and auto imported (good)
I want to use the same entry again
Start typing and now it is in the non-imported section. So you have to go back up again.

I can understand the use for this but at least the option to go back to a simple alphabetical sort would be great.
Neither VS Code nor the (built-in) typescript plugin seem to have settings to control this behaviour.
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:35:15.005Z)
OS version: Windows_NT x64 10.0.18362

Can you please provide an example that shows this behavior


Helm charts for 4.x not available

Seeking Helm charts for 4.x fabric8-platform - not seeing them on https://fabric8.io/helm/
May be related to commenting out of helm goal in https://github.com/fabric8io/fabric8-platform/blob/master/packages/distro/pom.xml
Recognizing this may be related to rename to fabric8-system, but fabric8-system also does not have a published helm chart.

Does helm charts available for the 4.x version? as I can see the last version available in charts in 2.4.24.
thanks in advance


url_whitelist breaking specs

Environment: Rails 3.2.13, Ruby 2.1.2, Capybara 2.4.3, Poltergeist 1.11.0
url_whitelist causes my specs to run without loading anything. url_blacklist on the other hand works. I'd like to do a whitelist strategy so that we don't need to remember to block any new external dependencies.

require 'capybara/poltergeist'

Capybara.register_driver :poltergeist do |app|
  options = {
    js_errors: true,
    window_size: [1200, 1000],
    url_whitelist: [
      "http://cdn.jsdelivr.net/lodash/4.12.0/lodash.min.js",
      ...
    ]
  }
  Capybara::Poltergeist::Driver.new(app, options)
end

Capybara.javascript_driver = :poltergeist

If you could create a reproducible test that was what would really help

Have you whitelisted your actual apps pages?  Assuming normal setup it would be something like
url_whitelist: [
  "http://<IP_ADDRESS>:*,
  "http://cdn.jsdelivr.net/lodash/4.12.0/lodash.min.js",
  ...
]

That was it, thanks! I had tried something similar but without widecarding the port


Customizable e2e tests

Description of the change:
This PR adds the support of customizing the e2e tests by providing various inputs via environment variables. The behavior of the tests remains the same with the default values.
Following are the details of the changes:

RBAC permissions were missing for operations related to project.openshift.io. Added them so that when the e2e test for memcached-molecule-operator is run on an OCP cluster the test passes successfully.
An environment variable, SKIP_SECRET_GENERATION, is used to skip the generation of secret related testdata for memcached-molecule-operator. This variable can be used to generate the testdata when running the e2e test with memcached-molecule-operator on an OCP cluster. If not not skipped, the controller tries to reconcile all secrets from all namespaces which results in heavy load on the controller and the e2e test fails.
Security context is added to the curl pod so that the creation of the pod doesn't fail on an OCP cluster.
MEMCACHED_MOLECULE_OPERATOR_IMAGE environment variable is introduced which will hold the container image registry path for memcached-molecule-operator, if set. Local image will not be built when this variable is set.
SKIP_LOCAL_TEST environment variable is introduced to skip the local test when it is set.
The step which undeploys the memcached-molecule-operator is made optional to complete successfully rather than mandatory. If there's an error, then a warning message will be shown. This step often fails in an OCP cluster as it involves deleting the resources created in the deploy process in the same order. Because of this reason namespace is deleted first and more often than not it gets deleted even before the resources created in it are deleted by the undeploy process, which results in a "not found" error and the whole e2e test fails.
ADVANCED_MOLECULE_OPERATOR_IMAGE environment variable is introduced which will hold the container image registry path for advanced-molecule-operator, if set. Local image will not be built when this variable is set. In addition to that, the Kind test for memcached-molecule-operator will be skipped.
More granular Makefile targets are created so that only those can be called while skipping the targets which are related to Kind cluster creation.

Motivation for the change:
The e2e tests for ansible-operator-plugins are tightly coupled with Kind cluster. We want to use the same test cases that are used in the e2e tests on an OCP cluster. To enable us to do so, the e2e tests are needed to be made customizable so that they work on an OCP cluster, in addition to a Kind cluster.

It seems like all of these changes are OCP specific, they should probably go in the downstream project.

I mentioned in the description that the changes are added for running the e2e test on an OCP cluster. However, the changes are actually platform agnostic and nothing is added which is specific for OCP. As the changes are platform agnostic we thought of adding them upstream. The actual OCP specific changes we'll add downstream. PLMK if you still feel that there are changes which are specific for OCP.


Create Registration Page and Process

💡 Summary
A registration page needs to be added for users self register using AWS Cognito.
Motivation and context
This functionality allows the scalability of services and is accessible via GovCloud.
Implementation notes

Use Crossfeed look and feel with current design libraries
Fields should be: email address, First Name, Last Name
Incorporate MFA token (use existing)
email: limited to .gov, .state, .us domains only; if not --> "General enrollment is not available at this time.. "

Acceptance criteria

[ ] New users are able to register with new registration process
[ ] Pass user acceptance testing

@schmelz21 - to confirm no elections customers will be excluded due to domain. Also need to define scale.

@nickviola, @ameliav
Do we have a mock-up, wireframe, example of the design that is in development?
cc @schmelz21, @stewartl97

@dmfezzareed - Tracked here, but very fluid right now based on my updates in stand-up today. Our pivot did not take place until yesterday afternoon, and my not be fully reflected in this yet:
https://github.com/cisagov/crossfeed/issues/2362

@nickviola, @ameliav, @JCantu248 - marking complete as it has been deployed and working in the DMZ


fix: remove duplicate import keyword in Kotlin generator example

Description
When using showTypeMappingExample in the Kotlin generator, the example code includes a import keyword in the dependency string which causes the generated code to have an invalid double import statement.
Related Issue
fixes https://github.com/asyncapi/modelina/issues/2107
Checklist

[✅] The code follows the project's coding standards and is properly linted (npm run lint).
[✅] All tests pass successfully locally.(npm run test).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.314%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
6002

Relevant Lines:
6333

💛  - Coveralls

/rtm


Add missing version bound on streaming-bytestring

In #2018, a <0.2 bound was added on streaming-bytestring because the code was
not compatible with the new 0.2 release.
In #2020, the index state was updated to pick up the new 0.2 release, the code
was made compatible with 0.2, and the bound was removed.
Instead of removing the bound, it should have been changed to >= 0.2, since
the code is no longer compatible with versions older than 0.2. I suppose the
idea behind #2020 was to rely on the newer index state to pick up the new 0.2
version. But this is rather brittle and will cause confusion for people that
don't have the updated index state or that are still using a version older than
0.2 for some reason. It is much better to present these users a cabal version
conflict than non-compiling code.
For good measure, add an upper bound too, which may protect us against future
releases breaking backwards compatibility.

Hydra fails with:
    total amount of Ada is preserved (Chain):                                                           FAIL (16.51s)
      *** Failed! (after 10 tests):
      Exception while generating shrink-list:
        LEDGERS sigGen: [[UtxowFailure (UtxoFailure (OutputTooSmallUTxO [(Addr Testnet (KeyHashObj (KeyHash "b7eb78c451a04a78")) (StakeRefPtr (Ptr (SlotNo 422) 7 0)),Coin 2),(Addr Testnet (ScriptHashObj (ScriptHash "44a627bd4738779b")) (StakeRefBase (ScriptHashObj (ScriptHash "b5bb62c7178fa141"))),Coin 2)]))]]
        CallStack (from HasCallStack):
          error, called at src/Test/Shelley/Spec/Ledger/Generator/Trace/Ledger.hs:133:15 in shelley-spec-ledger-test-<IP_ADDRESS>-BeibgubTyUcBMfHEuI3px4:Test.Shelley.Spec.Ledger.Generator.Trace.Ledger
      Use --quickcheck-replay=835637 to reproduce.

This is unrelated to this PR. I remember @dnadales also running into a similar failure in #2021. Best to investigate and fix it, because it slows down PRs.

bors merge

Can't say I'm a fan of the upper bound, but fair enough :-)

Build failed:
* [ci/hydra:Cardano:cardano-ledger-specs:required](https://hydra.iohk.io/build/4975882)

Can you restart the failed build? Or what do I need to do to get this merged?

Build failed:
* [ci/hydra:Cardano:cardano-ledger-specs:required](https://hydra.iohk.io/build/4975882)

Can you restart the failed build? Or what do I need to do to get this merged?

Restarted. I'll keep an eye on this and try to merge it

Can't say I'm a fan of the upper bound, but fair enough :-)

That is now how our build process works anyway, so we will come knocking with a patch again 🤣


handle missing POST in options

Connect https://github.com/ansible/tower-cli/issues/533

Coverage remained the same at 63.969% when pulling e37681cd94cdd85df10627ef825ee8888e0b0886 on AlanCoding:fix_org_dep into a3bad1e117e35a056d36c9f8f3a6bad40781b900 on ansible:master.


Trunk Doesn't Build in Release

I updated to trunk just now, debug builds compile (JO_DEBUG = 1) but release builds (JO_DEBUG = 1) fail to compile.
Here is the compiler error:
../jo_engine/vdp2_malloc.o ../../jo_engine/vdp2_malloc.c: In function 'jo_vdp2_malloc': ../../jo_engine/vdp2_malloc.c:164:13: warning: implicit declaration of function 'jo_core_error'; did you mean 'jo_core_tv_on'? [-Wimplicit-function-declaration]              jo_core_error("Out of VDP2 memory");              ^~~~~~~~~~~~~              jo_core_tv_on

Damn


Add websocket new head subscriptions that fall back to polling on error

Given a blockchain adapter
When it receives N websocket disconnections for new head subscriptions in a period P
Then it should try the alternate websocket RPC providers or fallback to polling according to the configured strategy
The venue configuration DSL will need an additional option
config :slurp,
  blockchains: %{
    "ethereum-mainnet" => %{
      start_on_boot: false,
      name: "Ethereum Mainnet",
      adapter: Slurp.Adapters.Evm,
      network_id: 1,
      chain_id: 1,
      chain: "ETH",
      testnet: false,
      timeout: 5000,
      new_head_initial_history: 128,
      poll_interval_ms: 2_500,
      rpc: [
        "wss://main-light.eth.linkpool.io/ws"
      ]
      # Select strategy websocket connection disconnect
      websocket_fallback_strategy: {Slurp.RpcStrategies.WebsocketFallback, :next, [[count: 5, per: 1, unit: :minute]]},
    }
  }

@AwaitFuture ^


KAFKA-5623: ducktape kafka service: do not assume Service contains nu…

…m_nodes

Yes, I tested with ducktape 0.6.0 as well as ducktape master

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6229/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6213/
Test PASSed (JDK 8 and Scala 2.12).


Reorganize CLI flags for build web

Group them into sections with headers

Flutter web options
    --base-href                                         Overrides the href attribute of the <base> tag in web/index.html. No change is done to web/index.html file if this flag is not provided. The value has to start and end with a slash
                                                        "/". For more information: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base
    --pwa-strategy                                      The caching strategy to be used by the PWA service worker.

          [none]                                        Generate a service worker with no body. This is useful for local testing or in cases where the service worker caching functionality is not desirable
          [offline-first] (default)                     Attempt to cache the application shell eagerly and then lazily cache all subsequent assets as they are loaded. When making a network request for an asset, the offline cache will be
                                                        preferred.

    --web-renderer                                      The renderer implementation to use when building for the web.

          [auto] (default)                              Use the HTML renderer on mobile devices, and CanvasKit on desktop devices.
          [canvaskit]                                   Always use the CanvasKit renderer. This renderer uses WebGL and WebAssembly to render graphics.
          [html]                                        Always use the HTML renderer. This renderer uses a combination of HTML, CSS, SVG, 2D Canvas, and WebGL.

JavaScript compilation options
    --csp                                               Disable dynamic generation of code in the generated output. This is necessary to satisfy CSP restrictions (see http://www.w3.org/TR/CSP/).
    --[no-]source-maps                                  Generate a sourcemap file. These can be used by browsers to view and debug the original source code of a compiled and minified Dart application.
    --dart2js-optimization                              Sets the optimization level used for Dart compilation to JavaScript. Valid values range from O0 to O4.
                                                        (defaults to "O4")
    --dump-info                                         Passes "--dump-info" to the Javascript compiler which generates information about the generated code is a .js.info.json file.
    --no-frequency-based-minification                   Disables the frequency based minifier. Useful for comparing the output between builds.

Experimental options
    --wasm                                              Compile to WebAssembly rather than JavaScript.


Installing requirements has typo

it is like pip -r requirments.txtit should be pip install -r requirements.txt

Thanks, resolved!


Force shopts

Some shells simply don't have habitual globbing activated e.g **/*.log should find all the files ending with .log in the sub-dirs.
# Fix the damn globs
shopt -s globstar

From http://unix.stackexchange.com/a/4270
shopt -s autocd


Have configs stored in a separate config file?

This would allow for shared import-sort configs
something like import-sort.config.js?

Hi @magicmark
for the next major release I intend to replace the current config system with https://github.com/davidtheclark/cosmiconfig which supports JavaScript-based configuration. I hope that will solve your use case.
Thanks for your support!

Hi @magicmark
this is now part of major version 4.


Determine changes needed for DiT

https://wiki.earthdata.nasa.gov/pages/viewpage.action?spaceKey=ENS&title=PI+24.1+Tenant+Action+Items

We will need to update the SWODLR load balancer to use HTTPS with a certificate issues by PrivateCA. There are details and a Terraform example shown here: https://wiki.earthdata.nasa.gov/pages/viewpage.action?pageId=335709250#tab-Terraform


Mapbox: Setup initial mapbox db classes

This is a fairly small change. Just trying to stick with the trunk based model.
Counts toward #10
This change introduces the scaffolding for a room database that
implements the mbtiles schema. Eventually, we'll read downloaded mbtiles
files and load them into the application by spinning up a room db based
on their contents.
This change also modifies the gradle build file to add room and
room:rx-java as dependencies.

I should mention that mapbox provides an offline support android plugin. The license is BSD, so that's fine.
Just wanted to point it out in case we think we should use it. I don't mind either way. A room based approach keeps our number of dependencies from proliferating, and I don't think it should be too difficult to use in comparison. Plus, it interops with RX nicely.

The naming of the PR and classes may be off, since we're not actually using Mapbox API atm, we're using Google Maps API. We are however using mbtiles as a file storage format, but that's orthogonal to using the Mapbox API to display.

I should mention that mapbox provides an offline support android plugin

Does this just wrap download and storage? Why do we need a Room db if the API is meant as a datastore for the mbtiles?
In the demo app were we using https://github.com/antoniocarlon/MapUtils to display the mbtiles in Maps API, or something else?
Lastly, in my recent work on issue-57 I already set up Room and local datastore, so we should probably use that. But it would be beneficial to see a working demo of the offline imagery working just to understand what's needed.

Ah that clarifies things, thanks! I’ll rename everything so that it makes
more sense—since mapbox owns the mbtiles spec I was unclear about the
terminology—thought mapbox/mbtiles were somewhat interchangeable, but I see
now they aren’t and the naming here is confusing.
I’ll rename this to be more specific—I can double check what you were using
for rendering in your demo today—I believe we can just render using the G
Maps api directly.
I can look into the mapbox plugin to see if it makes more sense to use that.
Agreed re: local data store—let’s plan on implementing the feature and then
switching over to the local DS after?
On Thu, Jun 13, 2019 at 5:46 PM Gino Miceli<EMAIL_ADDRESS>wrote:

The naming of the PR and classes may be off, since we're not actually
using Mapbox API atm, we're using Google Maps API. We are however using
mbtiles as a file storage format, but that's orthogonal to using the Mapbox
API to display.
I should mention that mapbox provides an offline support android plugin
Does this just wrap download and storage? Why do we need a Room db if the
API is meant as a datastore for the mbtiles?
In the demo app were we using https://github.com/antoniocarlon/MapUtils
to display the mbtiles in Maps API, or something else?
Lastly, in my recent work on issue-57 I already set up Room and local
datastore, so we should probably use that. But it would be beneficial to
see a working demo of the offline imagery working just to understand what's
needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/ground-android/pull/106?email_source=notifications&email_token=ACVXRYGRMFKKTM7K3UFGWN3P2K52PA5CNFSM4HX6ZKUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXVD52I#issuecomment-501890793,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACVXRYDT6MLRRU64ADVOAODP2K52PANCNFSM4HX6ZKUA
.

--
http://olsen.works http://olsen.works

I should mention that mapbox provides an offline support android plugin

Does this just wrap download and storage? Why do we need a Room db if the API is meant as a datastore for the mbtiles?

So it turns out it's built on top of the mapbox SDK, which we aren't using, so we can't adopt this.

Alright...so github doesn't handle commit amendments well once a PR is open...either that or I'm doing it wrong.
The history for this branch is now:
cbbf15061f73dd4ecd98e74423faa81db6052fbb (HEAD -> mapbox-db-init, origin/mapbox-db-init) Merge branch 'mapbox-db-init' of https://github.com/google/ground-android into mapbox-db-init
aa848ed683de67d71578db20614d1431365d60fe Mbtiles: Set up initial mbtiles db classes
bb07e8ce477826589dc36b87daf489231adccd49 Mapbox: Setup initial mapbox db classes

Which is decidedly wonky. I'll fix this and open a new, clean PR.

I believe we can just render using the G Maps api directly.

So it turns out it's built on top of the mapbox SDK, which we aren't using, so we can't adopt this.

In the original demo I used an open source project that exposes mbtiles as a Maps API tile source. This worked pretty well; may be worth reusing that approach?

Agreed re: local data store—let’s plan on implementing the feature and then
switching over to the local DS after?

Sgtm! Files on the file system work as well. Note that we may not want to put the mbtiles files themselves in the db, only a reference to them (or a reference to which ones are downloaded).

I believe we can just render using the G Maps api directly.

So it turns out it's built on top of the mapbox SDK, which we aren't using, so we can't adopt this.

In the original demo I used an open source project that exposes mbtiles as a Maps API tile source. This worked pretty well; may be worth reusing that approach?

Ah really? In the copy I have, it looks like you just implemented your own TileProvider for the mbtiles...though using MapUtils is probably easier. (the tile provider you implemented does pretty much do exactly what MapUtils does though, with some slight differences).
Actually, if we use MapUtils it looks like reading the mbtiles file into a DB isn't even necessary--MapUtils handles fireing up an SQL DB and reading the file for you...but! we will have to roll our own if we want to do anything with the other data potentially provided in an mbtiles file (meteadata etc.). MapUtils  is very
minimalist and only reads off the tile data.
Presumably we may want to read off mbtile metadata at some point, and possibly support mbtiles files that have grid tables too.
If you want to get something up and running ASAP though, I suppose MapUtils is the fastest way to do it.

Sgtm! Files on the file system work as well. Note that we may not want to put the mbtiles files themselves in the db, only a reference to them (or a reference to which ones are downloaded).

Great! Sorry, wasn't being clear. What I meant was, since mbtiles is an SQL DB, we need to spin up some kind of SQLLite DB to load in the data and pass it off to a tile provider and what not.
I wanted to do this using Room since it's far prettier and more user-friendly than using the SQLLite API directly, and thus less error-prone. It also allows us to use RX to read off the data, which is very nice! I do think there's possibly a slight resource usage/performance difference between the two approaches? If we use room, we'll effectively build a small DB in the app that reflects the contents of the downloaded mbtiles, but I'm not sure if this results in us doing more work, computationally speaking, than using SQLLite.openDatabase?

Do we need to access to mbtiles SQLite dbs ourselves at all? Iiuc MapUtils
handles that for us; you just need to point to the files. Please cmiiw.
On Fri, Jun 14, 2019 at 11:39 AM Scott Olsen<EMAIL_ADDRESS>wrote:

Sgtm! Files on the file system work as well. Note that we may not want to
put the mbtiles files themselves in the db, only a reference to them (or a
reference to which ones are downloaded).
Great! Sorry, wasn't being clear. What I meant was, since mbtiles is an
SQL DB, we need to spin up some kind of SQLLite DB to load in the data and
pass it off to a tile provider and what not.
I wanted to do this using Room since it's far prettier and more
user-friendly than using the SQLLite API directly, and thus less
error-prone. It also allows us to use RX to read off the data, which is
very nice! I do think there's possibly a slight resource usage/performance
difference between the two approaches? If we use room, we'll effectively
build a small DB in the app that reflects the contents of the downloaded
mbtiles, but I'm not sure if this results in us doing more work,
computationally speaking, than using SQLLite.openDatabase?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/google/ground-android/pull/106?email_source=notifications&email_token=AABXVUS44HJIXNPU2R7WWK3P2O3RLA5CNFSM4HX6ZKUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXFD3Y#issuecomment-502157807,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABXVUVSCT42EPQW6IPGGITP2O3RLANCNFSM4HX6ZKUA
.

--
Gino Miceli |  Developer Programs Engineer |<EMAIL_ADDRESS>|  Google
Earth Outreach Developer Relations

You are correct! I touched on that in the comment prior to my previous comment.
It seems like MapUtils is the fastest way to get off the ground (heh). It does handle reading the mbtiles for us, but only the tile data--if we want to support grids, read off metadata, or utilize other mbtiles info in the future we'll have to roll our own DB.
So I guess for a first pass we can use maputils, and go from there?

That sounds like a plan! More specifically, it could go something like this:

Manually store mbtiles and GeoJSON tile extents onto device, visualize
on Maps API
Branch issue-57/master
https://github.com/google/ground-android/tree/issue-57/master and augment
LocalDatastore to hold config and status of downloaded tiles.
Create UI to visualize/toggle state of downloaded tiles.
3a) Add request to download tiles to queue in local db.
3b) Allow tiles to be removed from device.
Augment background sync engine (WIP by Navin) to download tiles.

..or some combination thereof. Wdyt?
On Fri, Jun 14, 2019 at 12:41 PM Scott Olsen<EMAIL_ADDRESS>wrote:

You are correct! I touched on that in the comment prior to my previous
comment.
It seems like MapUtils is the fastest way to get off the ground (heh). It
does handle reading the mbtiles for us, but only the tile data--if we want
to support grids, read off metadata, or utilize other mbtiles info in the
future we'll have to roll our own DB.
So I guess for a first pass we can use maputils, and go from there?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/google/ground-android/pull/106?email_source=notifications&email_token=AABXVUWSW2FN3PIXCPO5B7LP2PC3RA5CNFSM4HX6ZKUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXK56Y#issuecomment-502181627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABXVUWIPDEVYE2N2YQX2GLP2PC3RANCNFSM4HX6ZKUA
.

--
Gino Miceli |  Developer Programs Engineer |<EMAIL_ADDRESS>|  Google
Earth Outreach Developer Relations


silicon: patch Cargo.lock for Rust 1.80

See: https://github.com/NixOS/nixpkgs/issues/332957
Description of changes
Updates time dependency of silicon.
As the project doesn’t seem very active, patch it on our side until we have an upstream solution. Upstream issue: https://github.com/Aloxaf/silicon/issues/255
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cc @evanjs @0x4A6F as maintainers


✨ [Feature]: Supports the global display of the loading progress bar of page loading, asynchronous request, and file upload

What problem does this feature solve
The loading progress bar of page loading, asynchronous request, and file upload is displayed globally.
What does the proposed API look like
please see https://www.iviewui.com/view-ui-plus/component/navigation/loading-bar

您好，感谢你的意见，我们内部评估下~~

你好，我们有提供全局弹窗和loading组件，您提的需求感觉有点偏业务了


De-serialization errors if using definitions-like object

e.g.
{
  "foo": {
    "a": {"type": "string" },
    "b": {"type": "string" }
  }
}

causes the Reads to fail.

My mistake, there was a typo in a type field, I will create follow-up issues to improve readability of deserialization errors.


Bug fix email tool

Description

\n bug in email tool

Related Issues

Solution and Design

Test Plan

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update

Checklist

[ ] My pull request is atomic and focuses on a single change.
[ ] I have read the contributing guide and my code conforms to the guidelines.
[ ] I have documented my changes clearly and comprehensively.
[ ] I have added the required tests.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 9 committers have signed the CLA.:white_check_mark: luciferlinx101:white_check_mark: TransformerOptimus:white_check_mark: Fluder-Paradyne:white_check_mark: Maverick-F35:white_check_mark: rounak610:white_check_mark: jedan2506:white_check_mark: sayan1101:white_check_mark: AdityaSharma13064:x: TarraannTarraann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Hide Menu Bar Icon

Would it be possible to add an option to hide menu bar item?

See wiki for detail


Enable changing IP address

There should be a way to change the IP address of an existing device, like a preference page. It is probably also a good idea to change the ID to something like a MAC address in stead of the device's IP address.

Fixed in 0.0.6


integrated abstract message bus

this PR addresses issue #1148

recheck

@tsconn23 do the new changes look good?