Multiple Line Charts doesn't work since 1.3.1

How to reproduce the bug

Go to Charts
Click on any Multiple Line Charts
See error.
Actually after a little loading nothing is displayed except whole gray screen, and developer console shows a whole lot of errors, including, but not limiting to Uncaught TypeError: colnames is undefined", "The above error occurred in the <DataTablesPane> component:, Warning: Each child in a list should have a unique "key" prop., Warning: Failed prop type: The prop standalone is marked as required in ExploreViewContainer, but its value is null.

All of that happens with the latest dev version (https://github.com/apache/superset/commit/0b7704a2693dd4883020779b7cdeb8557d9de991)
Latest release (1.3.1) is also bug-prone, but dev console is much less descriptive and shows only TypeError: e is undefined

Expected results
I expect to see Multiple Line Chart
Actual results
Superset shows Chart page which tries to load requested chart but instantly fails, resulting in gray screen

Screenshots
If applicable, add screenshots to help explain your problem.
Environment
(please complete the following information):
I have got the environment using default docker-compose provided by repo (https://github.com/apache/superset/commit/0b7704a2693dd4883020779b7cdeb8557d9de991)

browser type and version: Firefox 93
superset version tested: latest dev AND 1.3.1 release

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[+] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[+] I have reproduced the issue with at least the latest released version of superset.
[+] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

gotcha. I agree, it will be removed soon.
@zhaoyongjie @villebro can we easily migrate the old multi-line chart to mixed time series chart?

This issue seems to have gone cold, and doesn't seem to be corroborated by others. Also, it's true that we prefer the modern ECharts replacement these days and will work to deprecate the old version soon-ish. Closing this in hopes that all is well, but holler if this needs a revisit/reopening.

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


Use embedded resources make ignore other URL parameters

Context
I'm just trying to implement resource embedding with the following basic example:
CREATE TABLE security_data.t_role (
    id serial PRIMARY KEY,
    name text not null,
    tstamp date NULL DEFAULT now()
);

insert into security_data.t_role(name) values ('admin'), ('user'), ('guest');

CREATE TABLE security_data.t_user (
    id serial PRIMARY KEY,
    name text not null,
    role_id integer references security_data.t_role(id),
    tstamp date NULL DEFAULT now()
);

insert into security_data.t_user(name, role_id) values ('markus', 1), ('svitlana', 2), ('gerardo', 3), ('afan', 3), ('isaias', 1);

The PostgREST schema is another one and I'm just using wrapper views to expose data.
And the following are some working queries:
query:
curl -H "Authorization: Bearer ..." http://localhost:4000/view/t_user?id=eq.1
delivers:
[{"id":1,"name":"markus","role_id":1,"tstamp":"2022-11-02"}]
query:
http://localhost:4000/view/t_user?and=(or("name".ilike."af**"))
delivers:
[{"id":4,"name":"afan","role_id":3,"tstamp":"2022-11-02"}]
The following query includes a join:
http://localhost:4000/view/t_user?select=*,t_role!role_id!inner(*)
and works perfectly:
[
  {
    "id": 1,
    "name": "markus",
    "role_id": 1,
    "tstamp": "2022-11-02",
    "t_role": {
      "id": 1,
      "name": "admin",
      "tstamp": "2022-11-02"
    }
  },
  {
    "id": 2,
    "name": "svitlana",
    "role_id": 2,
    "tstamp": "2022-11-02",
    "t_role": {
      "id": 2,
      "name": "user",
      "tstamp": "2022-11-02"
    }
  },
  {
    "id": 3,
    "name": "gerardo",
    "role_id": 3,
    "tstamp": "2022-11-02",
    "t_role": {
      "id": 3,
      "name": "guest",
      "tstamp": "2022-11-02"
    }
  },
  {
    "id": 4,
    "name": "afan",
    "role_id": 3,
    "tstamp": "2022-11-02",
    "t_role": {
      "id": 3,
      "name": "guest",
      "tstamp": "2022-11-02"
    }
  },
  {
    "id": 5,
    "name": "isaias",
    "role_id": 1,
    "tstamp": "2022-11-02",
    "t_role": {
      "id": 1,
      "name": "admin",
      "tstamp": "2022-11-02"
    }
  }
]

My issue starts when I try to use filters with embedded resources. In general, when I start to use "select", any other parameter seems to be ignored:
http://localhost:4000/view/t_user?select=*,t_role!role_id!inner(*)&id=eq.1
or
http://localhost:4000/view/t_user?select=*,t_role!role_id!inner(*)&limit=2
or
http://localhost:4000/view/t_user?select=*,t_role!role_id!inner(*)&t_role.or=("name".ilike."*adm**")
Same result. All the records are retrieved.
Do you see guys what's wrong with my queries?
And thank you very much for your time. I really appreciate it.

Ah, thank you very much for the hint! you're so fast. I just closed the issue because realized I wrote it in the wrong place.


How do I run?

I fell like i'm being dumb, but i don't know what to do. I have python installed. I'm using windows btw

Have you looked at the quickstart in the Readme.md?
import requests
from html_to_etree import parse_html_bytes
res = requests.get('https://techcrunch.com/contact/')
tree = parse_html_bytes(res.content, res.headers.get('content-type'))

set(find_links_tree(tree))

The library is still in early development despite its age, but I'd be happy to get your feedback on it.

Hi @codinguncut. It is not working for the example https://www.lufthansa.com.
Any idea?

https://idownvotedbecau.se/itsnotworking/

Have you looked at the quickstart in the Readme.md?
import requests
from html_to_etree import parse_html_bytes
res = requests.get('https://techcrunch.com/contact/')
tree = parse_html_bytes(res.content, res.headers.get('content-type'))

set(find_links_tree(tree))

The library is still in early development despite its age, but I'd be happy to get your feedback on it.

I think people are referring to the following error when running quickstart code in the README.md:
NameError: name 'find_links_tree' is not defined

This issue was resolved in #1 pull request but was never merged 😥
@SCR33M, add the following line of code to the quickstart code:
from extract_social_media import find_links_tree


[Deque Analysis] Browse by Author "serious" issues

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Deque Analysis Summary
Browse by Author pages have a total of 4 serious issues (not including color contrast which are handled in other tickets):

(ID 469380) "Selected/Active state of the element is missing" (in the gear dropdown where "Results per page" and "Sort options" are visible).  In the dropdown, the selected RPP and Sort by options are shown with a visible checkmark, but that is NOT displayed to screen readers.

HOW TO FIX: Use the aria-current attribute to indicate the element that represents the currently selected item within a container or set of related elements, such as the currently selected page, step, location, date, or time. https://www.w3.org/TR/wai-aria-1.1/#aria-current
ALSO occurs on Community Homepage, so this should be fixed in a general location. See also ID 469634
FIXED BY #2717

(IDs 469483, 469487, 469491) Issues with placeholder text "Type the first few letters and click on the Browse button"

First, it is cut off when text spacing is adjusted
Second, it is also cut off when you zoom 200% (No longer reproducible in 7.6.1)
Third, it is also cut off when you set the screen at 320px width.
In all three scenarios that placeholder text is too long to display.  I wonder if we should simply move it to a label or hint (below the textbox) so that it can more easily wrap...instead of using placeholder text.

Full list of issues is viewable at (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=50&sortField=ordinal&sortDir=asc&row=9&filter[severity]=3&filter[type]=issue&filter[page_number]=2
More Information / Tools

Consider using Deque's free Chrome plugin to check your work

Hello, my name is Andrea Guevara and I work at Neki-it. We've analyzed the issue, reproduced the problem, following the suggestions proposed, and implemented the solution. I would like to request this issue for us.

Hello, my name is Andrea Guevara and I work at Neki-it. We've analyzed the issue, reproduced the problem, following the suggestions proposed, and implemented the solution. I would like to request this issue for us.

Good evening @tdonohue!
The correction for the issue follows this PR https://github.com/DSpace/dspace-angular/pull/3067.
Waiting feedback!


Fix storage-calculator so it can be used for kubernetes and openshift projects

Checklist

[x] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[x] PR title is ready for changelog and subsystem label(s) applied

The storage-calculator service relied on openshift specific resources so it wouldn't work for kubernetes based projects. This PR changes to use Deployment resources instead of DeploymentConfig.

Closing issues
n/a

@rocketeerbkw can you also do a cherry-pick against master? thank you


Add post built checks about the crt used

is the internal PE parser mature enough to use for this? Also I don't know how static libs declare dependencies (beyond just unresolved symbols).

At this point, the PE parser reads very specific data from the binaries, namely architecture used.
Therefore, it would require a bit of modification.
The crt checks that were added around bf7978dcf962c8ff37b3319121e60eb1629be684 are currently calling dumpbin.

Also, static libs are not linked, so there aren't any dependencies besides the unresolved symbols.

Closing resolved issue.


Footer and Sidebar: increase customization of links

On Footer and Sidebar, the © 1999 - 2022 Infineon Technologies AG text, as well as the Terms, Imprint, Privacy policy, Glossary links must be customizable. Users must be able to remove any of those links, as well as edit their text.
Related Issues: https://github.com/Infineon/infineon-design-system-stencil/issues/963 and https://github.com/Infineon/infineon-design-system-stencil/issues/961

Resolved in another PR.


Feat(web): FloatingUI integration to Tooltip #DS-1086

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Follow the PR Title/Commit Message Convention.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Nice work! So many calculations :-) But it is looking good and it works fine. We should finalize this tomorrow :-)

coverage: 96.491% (+16.8%) from 79.697%
when pulling 1c2a531eb3c447a316e045bbdc80cb36997ffd65 on feat/DS-1086-fui-integration
into 299d19b1f46b3d18af4a8a15b625346b483f1e02 on main.


Guidelines of excel sheet input

Lucas uploaded a new version of the Excel template that includes comments for every input field:
https://github.com/smart-grid-use-cases/excel2xml-input/blob/master/IEC62559-2_TEMPLATE.xlsx


parser: fix CHARACTER VARYING syntax

What problem does this PR solve?
Fix compatibility problem about CHARACTER VARYING syntax
Issue: pingcap/parser#410
MySQL Syntax:
type:
...
  | CHAR_SYM field_length opt_charset_with_opt_binary
  | CHAR_SYM opt_charset_with_opt_binary
  | nchar field_length opt_bin_mod
  | nchar opt_bin_mod
  | varchar field_length opt_charset_with_opt_binary
  | nvarchar field_length opt_bin_mod

Bad SQL Case:
create table t (a character varying(1));
create table t (a character varying(255));
create table t (a char varying(255));
create table t (a character);

create table t (a nchar);
create table t (a nchar varchar(50));
create table t (a nchar varying(50));

create table t (a national character varying(50));
create table t (a national char varying(50));

Check List
Tests

Unit test

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

@tangenta
PTAL


Add the option of manually specifying paths to SSL certificates

I needed to directly specify the paths to my SSL certificates to solve getting this running within a Kubernetes cluster where my SSL certificates are managed by kube-lego.
Kubernetes will let me mount the secret volume (which is where the ssl keys are stored) into the container, but the "self signed" and "custom" options really work with that.
This will let you define two additional env variables
SSL_CERT_PATH
SSL_KEY_PATH
Honestly just being able to manually tell what SSL certificates is very handy since obviously not everyone fits in a specific structure.
Let me know what you think or if there is anything I can improve!

Hi @keslerm, could you add a functional test on this part?
Thank you.

Sure can, wanted to get some feedback before I tried to figure out the tests.

Thanks.


raise ValueError(f"Expected {name} for bbox {bbox} to be in the range [0.0, 1.0], got {value}.")

I trained on my private dataset using the same format as VOC2007 but encountered this error. I can run on VOC2007 successfully
Traceback (most recent call last):
File "/datashare3/charis/code/recaps/fasterRcnn/fasterrcnn-pytorch-training-pipeline-main/train.py", line 571, in
main(args)
File "/datashare3/charis/code/recaps/fasterRcnn/fasterrcnn-pytorch-training-pipeline-main/train.py", line 420, in main
scaler=SCALER
File "/datashare3/charis/code/recaps/fasterRcnn/fasterrcnn-pytorch-training-pipeline-main/torch_utils/engine.py", line 45, in train_one_epoch
for images, targets in metric_logger.log_every(data_loader, print_freq, header):
File "/datashare3/charis/code/recaps/fasterRcnn/fasterrcnn-pytorch-training-pipeline-main/torch_utils/utils.py", line 173, in log_every
for obj in iterable:
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 628, in next
data = self._next_data()
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 1333, in _next_data
return self._process_data(data)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 1359, in _process_data
data.reraise()
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/_utils.py", line 543, in reraise
raise exception
ValueError: Caught ValueError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
data = fetcher.fetch(index)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 58, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 58, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/datashare3/charis/code/recaps/fasterRcnn/fasterrcnn-pytorch-training-pipeline-main/datasets.py", line 316, in getitem
labels=labels)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/composition.py", line 207, in call
p.preprocess(data)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/utils.py", line 83, in preprocess
data[data_name] = self.check_and_convert(data[data_name], rows, cols, direction="to")
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/utils.py", line 91, in check_and_convert
return self.convert_to_albumentations(data, rows, cols)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/bbox_utils.py", line 142, in convert_to_albumentations
return convert_bboxes_to_albumentations(data, self.params.format, rows, cols, check_validity=True)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/bbox_utils.py", line 408, in convert_bboxes_to_albumentations
return [convert_bbox_to_albumentations(bbox, source_format, rows, cols, check_validity) for bbox in bboxes]
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/bbox_utils.py", line 408, in
return [convert_bbox_to_albumentations(bbox, source_format, rows, cols, check_validity) for bbox in bboxes]
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/bbox_utils.py", line 352, in convert_bbox_to_albumentations
check_bbox(bbox)
File "/datashare3/charis/anaconda/envs/simp/lib/python3.7/site-packages/albumentations/core/bbox_utils.py", line 435, in check_bbox
raise ValueError(f"Expected {name} for bbox {bbox} to be in the range [0.0, 1.0], got {value}.")
ValueError: Expected y_min for bbox (tensor(0.5800), tensor(1.0111), tensor(0.7067), tensor(1.), tensor(1)) to be in the range [0.0, 1.0], got 1.0110957622528076.

It looks like, for some images, the coordinate for y_min has been annotated out of the image border. You may need to check which images have that issue.

Hello, I have just pushed an update to datasets.py that removes all files with invalid bounding boxes before training. Please check. I am closing the issue for now. Please re-open if needed.


Timeout is not working as expected

Hi,
I'm currently using request version 2.34.0 and its working as expected with respect to timeout.
But when I upgraded the package to 2.83, it never respects the timeout period mentioned. Then I upgraded the package to the latest version, 2.85.0 and in this sometimes it's getting timed out stipulated time (desired behaviour) but sometimes it's not.
Can anybody help me?
I'm setting timeout period to be 1 sec, if the API doesn't respond under 1 sec, I need to trigger the timeout flow

There are some other posts about this same issue. Additionally, there are issues with timeouts involving HTTP proxies as well. In one instance the sockets timed out but never got killed and the app was not able open anymore sockets. People have submitted pull reports, but they've never been merged. I would recommend look at a different HTTP client library at this point.

Any recommendations or forks @osxpinot ?

I would try JCMais/node-libcurl

@khanna91 I have a similar issue when I'm trying to set the timeout with a string.
I was setting the options with:
{
  timeout: '1000'
}

And timeout not work properly.
When I change to a Integer (in my case this configuration came from process.env) the timeout was respected.

Hi,
Any update on this issue ?
Timeout option is still not taken into account on post requests.


Uncaught TypeError: Cannot read properties of null reading 'appendChild'

sharegpt does not work on my chrome.
The "Export" button is not display.
Error:

I'm not sure what other information I need to provide, please let me know.

It is true. On Version 108.0.5359.95 (Official Build) (64-bit) it fails.


Run at 15:21 when the Dashboard is update with vaccination numbers

The dashboard lags just a few minutes behind data.rivm.nl, which means the webscraper got yesterdays vaccination data. Yesterday it was 163.931, today it's 173.638.

@mzelst Don't forget to check if the dashboard is updated before running the scripts today :)

@mzelst Don't forget to check if the dashboard is updated before running the scripts today :)

Hi Ewout,
Luckily, the dashboard got updated and the source data for vaccines seems to be updated earlier than the actual dashboard is updated :) So we're now using the actual numbers of today that are also displayed on the dashboard (around 15:20) in the daily update. Thanks for your note!

Hi Ewout,
Luckily, the dashboard got updated and the source data for vaccines seems to be updated earlier than the actual dashboard is updated :) So we're now using the actual numbers of today that are also displayed on the dashboard (around 15:20) in the daily update. Thanks for your note!

The current value still is yesterdays value (185.356, on January 27th), it will update again today around 15:20. So by running the scripts at 15:16 you will miss the updated value again and keep lagging a day behind.

The current value still is yesterdays value (185.356, on January 27th), it will update again today around 15:20. So by running the scripts at 15:16 you will miss the updated value again and keep lagging a day behind.

Hi Ewout,
Yeah, I've misread the documentation for the source code and read vaccines delivery expected as vaccines used. Rewriting the code again so it fully works.
The quick update is finding a balance between accuracy and being the first. Perhaps good to move the scheduled update until 15:20 (instead of 15:15) until they properly fix the open data (it's the worst here). Thanks for being sharp!

Hi Ewout,
Yeah, I've misread the documentation for the source code and read vaccines delivery expected as vaccines used. Rewriting the code again so it fully works.
The quick update is finding a balance between accuracy and being the first. Perhaps good to move the scheduled update until 15:20 (instead of 15:15) until they properly fix the open data (it's the worst here). Thanks for being sharp!

Let's hope the vaccination data will soon be updated at data.rivm.nl.
Thanks for the amazing reports every day!

Let's hope the vaccination data will soon be updated at data.rivm.nl.
Thanks for the amazing reports every day!


Volumes are suddenly empty

Hi,
In our test environment we detected that suddenly the content of volumes are empty. A recreation of the pod make the files reappear. This often happens after the pod is running for multiple hours. We are using containerd with default configuration. I assume this has something to do with the garbage collection of the underlying node. The volumes are mounted es ephemeral csi volumes in readOnly mode. So a deletion of the files by accident can be excluded as a root cause.
Did someone had a similar experience? Any ideas how to troubleshoot that further?

I'm not yet deep into the individual technology internals, could it be that we miss lease handling in the containerd case? Otherwise resources are automatically garbage collected after 24h?
See: https://github.com/containerd/containerd/blob/main/docs%2Fgarbage-collection.md#L19-L93

We heavily use this driver in our production environment and haven't noticed this issue before. Our environment also uses containerd version v1.7.2 on EKS 1.26 nodes.

@mugdha-adhav I see, maybe our usage pattern is different. We are spinning up and tear down pods very frequently often the churn is less then 5 seconds.
I have the assumption that there is a problem with the metadata update in that scenario. In combination with sudden kills because of the failing livenessProbe which results deleting the snapshot even though it is still in use by the last pod, resulting in an empty dir.
Additionally to that, the gc of kubelet kicks in regular on our nodes.
That's why I have created to linked PR to try using leases instead of metadata. I'm still trying to find a reliable reproducable example.

@mugdha-adhav I could now reproduce this error multiple times with the latest version 1.1.0 under very high load (starting/stopping hundres of pods with a mix of shared/non-shared volumes). I'm currently preparing a PR to make the driver handle high load scenarios more graceful. The PR is meant as a discussion basis, of what you want to include in this project.

@mugdha-adhav When testing our service at large scale with bigger images and different images, I can see an exhaustion of containerd bringing all the pods on a node to a halt. While my changes are fixing the exhaustion of containerd when all images are available, there is a needed modification necessary on the pulling side (to fix the case of scheduling many pods on a fresh node). The PR #137 looks quite promising to fix the exhaustion of containerd, that means I'm waiting on that to get merged first.

@woehrl01 we mostly use read-write volumes on our clusters, so this issue might be limited to read-only volumes.
I tried reproducing the issue by deleting the image and snapshot from containerD, but I could still see the files mounted in the pod. Hence I doubt if the issue is related to garbage-collection in containerD.

@mugdha-adhav Yes, I think this is only related to read-only volumes. During my migration to leases as a GC mechanism, I could verify that DeleteSnapshot has been called, even though there were still leases attached to it.

another thought occurred to me: we should verify that mounting the pulled image as writeable does indeed create a new writeable layer (UFS, the way Dockerfile steps represent changes as add/modify/delete ON TOP of previous fs layer) such that two pods mounting in read/write mode cannot change each other's version of that image.
#137 (which should merge tomorrow, btw) reduces parallel pulls to a single request so the resulting on-disk representation would be from a single pull-and-unpack. i'm not sure if the mounting activity (this CSI provider calling into containerd/crio) starts from this unpacked content and creates that new writeable layer to maintain immutability.

we should verify that mounting the pulled image as writeable does indeed create a new writeable layer

I have already verified this manually by checking the snapshots created by containerD for every new writable volume.

@mugdha-adhav I could reverify that and the problem is happing if there are timeouts happing causing some operations to fail, during rollback of those changes the snapshots are deleted.

@woehrl01 are we good to close this issue based on reasoning mentioned in this comment?

@mugdha-adhav no this issue can still happen. I didn't had time to push my changes upstream yet and create a pr to fix this eventually. I still have this in my todo list.


ADR001 - Folder / File Organization - Accounts

Lots of files changed here, but it's all just imports being changed.
So far I've tested that a yarn typecheck works:
technoplato@Michaels-MacBook-Pro converse-app % yarn typecheck
yarn run v1.22.22
$ echo "➜ Typechecking project..." && tsc --noEmit
➜ Typechecking project...
✨  Done in 4.74s.


Compatibility issues

The models we report in the preprints were trained with different versions of the codebase:

VSCyto3D and the model used in the Mantis preprint was trained with v0.1.0a0.

Old config files are not compatible with the current HEAD of main (https://github.com/mehta-lab/VisCy/commit/d7d1200d5ff1ae19eae5bc4c5a6578230ecfd648)
Weights can be loaded through Python API.

VSNeuromast was trained with the current HEAD of main (after v0.1.0a1?)
VSCyto2D was trained with #71.

Weights are not compatible with main due to architectural changes.

The VSCyto3D weights can be provided with an updated config file, while #71 will need to add API changes to separate 2D model building and also change config files accordingly before merging.

@edyoshikun can you confirm the details for the neuromast model and comment on compatibility requirements of the mantis revision?

Correct! Neuromast model was trained with the current HEAD of the main. I confirm.

Hi @ziw-liu  We'd fine-tune the VSCyto3D model with data acquired on Mantis as we discussed. Please start a PR with changes that enable training of both VSCyto3D and VSNeuromast models with the main. This PR should be a priority since we need it to iterate on the models for mantis Fig. 1 next.
It seems like 2D FCMAE branch will require development such that the weights are compatible with the main. I don't follow this point, can you point to a few lines of code to illustrate? This can be the second PR.
Thanks for iterating quickly on these.
Let's iterate over them quickly. Thanks!

We'd fine-tune the VSCyto3D model with data acquired on Mantis as we discussed at the lab meeting yesterday.

I think @edyoshikun is already training these models without needing code changes. (Recall that VSCyto3D and VSNeuromast are the same architecture trained on different data.) The incompatibility I mentioned in OP for VSCyto3D is between the old config files we published (e.g. on zenodo for the mantis preprint) and the current code base. This is a minor issue since that zenodo record points to a pinned version of VisCy that works properly with the files.

It seems like 2D FCMAE branch will require development such that the weights are compatible with the main. I don't follow this point, can you point to a few lines of code to illustrate?

The network module changed, among other things. For example:
https://github.com/mehta-lab/VisCy/pull/71/files#diff-9af609b0fdd9a3358d7099a616e29f1fefdab379a92388bca856ab99944fc67c

@ziw-liu How about the following order of operation?

Release candidate 0.2.0 that works with current weights of VSCyto3D, VSNeuromast, and VSCyto2D models. Call this model UNeXt2 to match the nomenclature in the preprint.
Update FullyConvolutionalMAE model such that the weights can be transferred from FCAMAE to VSCyto2D models.

My reading of the code suggests that all of these can be instantiated by passing parameters to UNet21d.

The VSCyto2D models are made from the FCMAE class for both pre-training and fine-tuning.
My suggestion is:

Merge #71
Merge #84
Merge #69
Tag v0.1.0rc0
Prepare v0.1.0 release artifacts (weights and config files) based on the new code base

@ziw-liu. This order of operation makes sense to me. Are you renaming what we thought of release 0.2.0 as 0.1.0? Totally fine to call the next release 0.1.0. Please update the milestone for clarity if you mean something else.

Let's also update the Readme.md and add the preprint link here as well.

Let's also update the Readme.md and add the preprint link here as well.

#85


Proc macros not expanded warning

Problem
Some proc macros are throwing weird warnings. Without compile-time error it shows unresolved-proc-macro warning. But if the expanded code is faulted, it shows the actual error. See this file for example:
correct usage:

incorrect usage:

Another related problem is that the autocompletion relating to the expanded code is broken.
rust-analyzer version: (eg. output of "Rust Analyzer: Show RA Version" command)
db2a7087b 2021-12-13 stable
rustc version: (eg. output of rustc -V)
rustc 1.59.0 (9d1b2106e 2022-02-23)
relevant settings: (eg. client settings, or environment variables like CARGO, RUSTUP_HOME or CARGO_HOME)
procMacro: { enable: true, server: null }

This works for me:

I'm not sure whether we fixed anything in the meanwhile, but you could try a newer version from https://github.com/rust-analyzer/rust-analyzer/releases/tag/2022-03-14.

Yeah, I can confirm the problem on the 2021-12-13 release:

Good to know that the error is reproducible and already fixed in the latest release.Will the latest release be synced to vscode's ra extension soon? I installed ra through the latest extension so I assume many people will be bugged if they naively follow the same path.

I assume you're using VSCodium, where RA no longer updates because of https://github.com/rust-analyzer/rust-analyzer/issues/11080.

Ah indeed. I am using code-server actually. It also downloads extensions from OpenVSX. So for now the issue is when the extension can be brought up to date. Thx @lnicola

You could still give the new version a try, just to make sure it works.
Updates depend on an OpenVSX fix, which I expect to be merged in the next 1-3 weeks: https://github.com/eclipse/openvsx/pull/406.

For anyone using vscode below v1.65(which the latest RA requires), the second latest release is compatible with vscode ^1.63 and also has the fix.


feat(tutorial): complete step 5

Closes #
feat(tutorial): complete step 5
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Hi I have dropped that app instance from my bluemix account as this review took longer time.  Please give me sometime to recreate the step 5 deployment if it is okay. Do let me know.


Failed to parse recipe

Versions
Minecraft: 1.16.5
Forge: 36.2.4
Growable Cells:
growablecells-1.16.5-1.3.0.jar
Applied Energistics(If Applicable):
Refined Storage(If Applicable):
Extra Disks(If Applicable):
Extra Storage(If Applicable):
Describe the bug
A clear and concise description of what the bug is.
[13.09 19:34:59] [Server] [Worker-Main-9/WARN] [KubeJS Server/]: Failed to parse recipe 'botanypots:qio_drive_supermassive_botanypot[botanypots:crop]'! Falling back to vanilla: com.google.gson.JsonParseException: Could not find minecraft:block with ID growablecells:crop_mek_qio_drive_super_drive
[13.09 19:34:59] [Server] [Worker-Main-9/WARN] [KubeJS Server/]: Failed to parse recipe botanypots:qio_drive_supermassive_botanypot[botanypots:crop]: com.google.gson.JsonParseException: Could not find minecraft:block with ID growablecells:crop_mek_qio_drive_super_drive
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Considering you dont have mekanism installed it wont be an issue, but thanks for letting me know.


Styling of listView

I can't seem to remove the border bottom of each address options in the  drop down.

never mind solved it.
it's a view component called seperator(not a border).
can change the style by passing the "seperator" as the key in styles

any idea on how to wrap the listview text if it extends further than the width of the screen?


Install cocoapods-user-defined-build-types via Homebrew

Installing CocoaPods via gem has many issues.
Fortunately CocoaPods can be installed via Homebrew:
brew install cocoapods

Will cocoapods-user-defined-build-types support Homebrew?

have same problem


Versioning

Figure out a way to get a version from a git commit hash or maybe using git describe

https://gist.github.com/pwithnall/7bc5f320b3bdf418265a
http://stackoverflow.com/questions/5581722/how-can-i-rewrite-python-version-with-git
https://github.com/warner/python-versioneer


Add " -D__STDC_FORMAT_MACRO" to CXXFLAGS to fix compiling bedtools.

Add " -D__STDC_FORMAT_MACRO" to CXXFLAGS to fix compiling bedtools.
This fixes the following problems during compilation:
  * compiling chromsweep.cpp
In file included from bedFile.cpp:12:0:
bedFile.h: In member function ‘void BedFile::reportBedTab(const T&)’:
bedFile.h:47:21: error: expected ‘)’ before ‘PRId64’
 #define PRId_CHRPOS PRId64
                     ^
bedFile.h:942:33: note: in expansion of macro ‘PRId_CHRPOS’
                 printf ("%s\t%" PRId_CHRPOS "\t%" PRId_CHRPOS "\t", bed.chrom.c_str(), start, end);
                                 ^~~~~~~~~~~
bedFile.h:47:21: error: expected ‘)’ before ‘PRId64’
 #define PRId_CHRPOS PRId64
                     ^
bedFile.h:945:33: note: in expansion of macro ‘PRId_CHRPOS’
                 printf ("%s\t%" PRId_CHRPOS "\t%" PRId_CHRPOS "\t%s\t",
                                 ^~~~~~~~~~~
bedFile.h:47:21: error: expected ‘)’ before ‘PRId64’
 #define PRId_CHRPOS PRId64
                     ^
bedFile.h:949:33: note: in expansion of macro ‘PRId_CHRPOS’
                 printf ("%s\t%" PRId_CHRPOS "\t%" PRId_CHRPOS "\t%s\t%s\t",
                                 ^~~~~~~~~~~

D'oh.
What compiler are you using? I would have thought this mess was sorted out years ago and that implementations would have long since caught up by now.

GCC 4.8.2 (easybuild foss/2014a toolchain) (CentOS 6).
One user claimed to have problems with foss/2018b toolchain (GCC 7.3.0), which is a bit weird as the foss/2018a toolchain worked fine for me (GCC 6.4.0):
https://github.com/easybuilders/easybuild-easyconfigs/issues/7951

Maybe I found the issue. CentOS6 still uses glibc-2.12, so it does not have the fix from glibc-2.28. The cluster with CentOS6 will disappear in a few months so it is not a big problem if this patch is not merged.

+1 for it being a glibc issue. I just had to add this flag myself for compilation using GCC 7.2.0, but still using glibc-2.12.

The problem's limited to elderly implementations, but it's easy for bedtools to work around so it might as well do so. Either this way or via #define at the top of the few files that #include <inttypes.h>.
Thanks for spotting my oversight :smile:

An alternative solution is to use <cinttypes> rather than <inttypes.h>.
Xref: https://github.com/bioconda/bioconda-recipes/pull/14282

Indeed it is; that'll work for compiler versions with a <cinttypes> that works around the problem in the C library's <inttypes.h>. This or #715 is a slightly larger sledgehammer that also works for earlier compiler versions that don't have that extra logic in their <cinttypes> files. If there are any…

I merged #715 which seems to address this issue.


ERROR import {sync as globSync} from 'fast-glob';

After installing in my project ESLint is now throwing this error.
I haven't ever had anything like this with plugins.
How do I troubleshoot? Thanks.
Uncaught exception received.
file:///Users/jeremy/dev/__active/eslint-plugin-awesome-labs/node_modules/eslint-import-resolver-typescript/lib/index.js:6
import { sync as globSync } from 'fast-glob';
         ^^^^
SyntaxError: Named export 'sync' not found. The requested module 'fast-glob' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'fast-glob';
const { sync: globSync } = pkg;

This is likely due to your project being ESM, and this project is also ESM, but is importing an CJS package here:
import { sync as globSync } from 'fast-glob';

which doesn't work.
It would probably work if they changed it to
import FastGlob from 'fast-glob';
const { sync: globSync } = FastGlob;

This is usually the workaround needed for ESM to interop with CJS packages.

PR welcome.

Ok, np.
Only problem is CI isn't running... Package.json says
"packageManager"<EMAIL_ADDRESS>
And I am running on latest:
> eslint-import-resolver-typescript % pnpm -v
8.6.1

And I have committed the latest changes to pnpm-lock as per https://pnpm.io/errors#err_pnpm_outdated_lockfile
So something is weird in this repo? Or you need to specify how contributors are supposed to get the "correct" version of pnpm.


fix/test(CL Fees): swap out given in fee growth tests; clean up swap tests

Closes: #XXX
What is the purpose of the change
Due to a merge conflict between https://github.com/osmosis-labs/osmosis/pull/4021 and https://github.com/osmosis-labs/osmosis/pull/4097, the fee growth validations were not added.
This PR adds the validations for the fee growth accumulator.
The changes from  https://github.com/osmosis-labs/osmosis/pull/4021 interfere with the assertions since they also relate to updating the fee growth accumulator. As a result, they were moved into a separate test fixture called TestSwapOutAmtGivenIn_TickUpdates to enable the expected fee growth validations in the original test.
Lastly, it cleans up the swap test suite. See changelog for details. This clean up is necessary for https://github.com/osmosis-labs/osmosis/pull/4131 and is separated here for ease of review.
Brief Changelog

move tick update tests into a separate fixture TestSwapOutAmtGivenIn_TickUpdates
enable validation of the fee growth accumulator in TestCalcAndSwapOutAmtGivenIn
do the first two steps for swap in given out in preparation for https://github.com/osmosis-labs/osmosis/pull/4131
group fee-specific tests in swapOutGivenInFeeCases global variable

this separation stems from the need to avoid running fee tests in tick updates or inverse tests

group all test case fields in struct SwapTest and reuse it where applicable

Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented? not applicable

merging since this is a simple test refactor


Part of the Chinese character cannot be rendered

Attach (recommended) or Link to PDF file here:  pdf link
Configuration:

Web browser and its version: chrome 86.0.4240.193
Operating system and its version: macOS 10.13.6
PDF.js version: 2.5.207
Is a browser extension: -

Steps to reproduce the problem:

use the getDocument api to render the pdf
getDocument options:

{
    url: 'https://zhihu-live.zhimg.com/pdf/20201112/origin/ac8b5907e1cf5ee7cada8650bbf1082d.pdf'
    cMapUrl<EMAIL_ADDRESS>    cMapPacked: true
}

What is the expected behavior? (add screenshot)
expect render normal

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
no

Attach (recommended) or Link to PDF file here: pdf link

WFM, using PDF.js 2.7.262 in Firefox Nightly 84.

getDocument options: {url: 'https://zhihu-live.zhimg.com/pdf/20201112/origin/ac8b5907e1cf5ee7cada8650bbf1082d.pdf' : 'https://unpkg.com/browse/pdfjs-dist@2.6.347/cmaps/',cMapPacked: true}

Huh, that is definitely not a valid JavaScript object and trying to run that is guaranteed to result in an Error.
More generally though, please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

Warning: Unknown type 1 charstring command of "0"
As a user, how do I know this situation? I want to set some fallback...

Attach (recommended) or Link to PDF file here: pdf link

WFM, using PDF.js 2.7.262 in Firefox Nightly 84.

But... it isn't work on my browser(82.0.3)

getDocument options: {url: 'https://zhihu-live.zhimg.com/pdf/20201112/origin/ac8b5907e1cf5ee7cada8650bbf1082d.pdf' : 'https://unpkg.com/browse/pdfjs-dist@2.6.347/cmaps/',cMapPacked: true}

Huh, that is definitely not a valid JavaScript object and trying to run that is guaranteed to result in an Error.
More generally though, please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

sorry... I have corrected it..
Warning: Unknown type 1 charstring command of "0"
how do I know this situation? I want to set some fallback...

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.

But... it isn't work on my browser(82.0.3)

The screen-shot suggests a completely different set of errors, since it appears that invalid PDF data was loaded (possibly a server issue).

Warning: Unknown type 1 charstring command of "0"
how do I know this situation? I want to set some fallback...

That warning is not relevant to the errors you're seeing.
Once more: Without a runnable example no additional help can/will be provided here!

But... it isn't work on my browser(82.0.3)

The screen-shot suggests a completely different set of errors, since it appears that invalid PDF data was loaded (possibly a server issue).

Warning: Unknown type 1 charstring command of "0"
how do I know this situation? I want to set some fallback...

That warning is not relevant to the errors you're seeing.
Once more: Without a runnable example no additional help can/will be provided here!

sorry, we are choosing a plan, so there is not yet an accessible link...  we only tested locally.
I found a strange phenomenon:  when cMapUrl is a CDN address, there will be problems, like this:
{
      cMapPacked: true,
      cMapUrl<EMAIL_ADDRESS>      disableAutoFetch: false,
      disableFontFace: false,
      disableRange: false,
      disableStream: false,
      docBaseUrl: "http://localhost:8888/web/viewer.html?file=%2Fweb%2Fac8b5907e1cf5ee7cada8650bbf1082d.pdf",
      fontExtraProperties: false,
      isEvalSupported: true,
      maxImageSize: -1,
      pdfBug: false,
      url: "https://zhihu-live.zhimg.com/pdf/20201112/origin/ac8b5907e1cf5ee7cada8650bbf1082d.pdf",
      verbosity: 1
 }

If you use the above options, the console will output this log.

When I replace cMapUrl with the local address, it can render normally...
{
      cMapPacked: true,
      cMapUrl: "../external/bcmaps/",
      disableAutoFetch: false,
      disableFontFace: false,
      disableRange: false,
      disableStream: false,
      docBaseUrl: "http://localhost:8888/web/viewer.html?file=%2Fweb%2Fac8b5907e1cf5ee7cada8650bbf1082d.pdf",
      fontExtraProperties: false,
      isEvalSupported: true,
      maxImageSize: -1,
      pdfBug: false,
      url: "https://zhihu-live.zhimg.com/pdf/20201112/origin/ac8b5907e1cf5ee7cada8650bbf1082d.pdf",
      verbosity: 1
 }

Thank you for your reply. In my understanding, using CDN address is the same as local address
But the facts are different
so... why🤔

I found a strange phenomenon: when cMapUrl is a CDN address, there will be problems, like this:

That suggests that the issue could be that the CDN is returning incorrect/malformed data, which we unfortunately cannot do anything about here since the CDN is provided by a third-party.
Another possible explanation could be that you're using a CORS policy which somehow breaks the CMap-requests, and in that case you could maybe try using a custom CMapReaderFactory to work-around that.

I found a strange phenomenon: when cMapUrl is a CDN address, there will be problems, like this:

That suggests that the issue could be that the CDN is returning incorrect/malformed data, which we unfortunately cannot do anything about here since the CDN is provided by a third-party.
Another possible explanation could be that you're using a CORS policy which somehow breaks the CMap-requests, and in that case you could maybe try using a custom CMapReaderFactory to work-around that.

yep, I noticed that too
<EMAIL_ADDRESS>This url actually returned an HTML, not a bCmap resource... : )💥
So the solution is to replace cMapUrl with<EMAIL_ADDRESS>Thank you very much for your help！！😁 😬


Suggestion - Missing of a declarationFile option

TypeScript Version:  2.2.1 / nightly (2.2.0-dev.201xxxxx)
Code
tsc app.ts --declarationFile app-test.d.ts --declaration

Expected behavior:
Compiling the TypeScript and generating a declaration file with the name app-test.d.ts in the current folder.
Actual behavior:
error TS5023: Unknown compiler option 'declarationFile'.

Duplicate of https://github.com/Microsoft/TypeScript/issues/8372

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


student_interface crashes with a "ActiveRecord::RecordNotUnique in AssignmentsController#student_interface" error

Steps to reproduce ( currently tested on our sandbox ):

create a new assignment with a minimum and maximum group members of 1
login to a student account and select the created assignment, which should take you to the student_interface view and automatically create a group for you
login as the admin again and remove the student from their newly created group ( assignments -> groups )
login as the student again and select the same assignment
view error page for "ActiveRecord::RecordNotUnique in AssignmentsController#student_interface"

View error by loging as c5anthei and going to: http://sandbox.markusproject.org/en/assignments/8/student_interface

I will work on this.

I get this on PostgreSQL, reopening:
  1) Error:
test: A Student with an assignment should allow the student to join an existing empty grouping when working alone. (StudentTest):
ActiveRecord::StatementInvalid: PGError: ERROR:  current transaction is aborted, commands ignored until end of transaction block
: SELECT  "groupings".* FROM "groupings" WHERE "groupings"."group_id" = 219 AND "groupings"."assignment_id" = 255 LIMIT 1
    app/models/student.rb:147:in `create_group_for_working_alone_student'
    app/models/student.rb:111:in `create_group_for_working_alone_student'
    test/unit/student_test.rb:377:in `__bind_1329230146_561783'
    test/unit/student_test.rb:376:in `__bind_1329230146_561783'


Translate programmatically

translate programmatically mlforkids-api/public/languages/cs.json

ChatGPT, Auto-GPT didn't worked
preparing script for DeepL API (500K characters for free, around 200K to translate)

https://github.com/Michal-Miky-Jankovsky/taxinomitis/pull/4

need to find someone to check each record


FaultType: HardFault

Description of defect
Hello,
I am still fairly new to the ARMmbed and lorawan world. When I finished adjusting the EUIs and build the program, I receive a FaultType: HardFault. I have looked over previous closed issues, but none of the changes seemed to resolve my issue.
I am using SX1276 as the lora-radio with loraphy being US915.
Here is the serial communication messages that I receive from the terminal:
++ MbedOS Fault Handler ++
FaultType: HardFault
Context:
R0   : 00000000
R1   : 20005000
R2   : 00000000
R3   : 00000000
R4   : 20003010
R5   : 20003E98
R6   : 2000208C
R7   : 200004BC
R8   : 00000000
R9   : 00000000
R10  : 00000000
R11  : 00000000
R12  : 00000000
SP   : 20002058
LR   : 08011B03
PC   : 08005516
xPSR : 21000000
PSP  : 20002038
MSP  : 20004FC8
CPUID: 410CC601
Mode : Thread
Priv : Privileged
Stack: PSP
-- MbedOS Fault Handler --
++ MbedOS Error Info ++
Error Status: 0x80FF013D Code: 317 Module: 255
Error Message: Fault exception
Location: 0x8012C01
Error Value: 0x8005516
Current Thread: main  Id: 0x20002830 Entry: 0x8012E8D StackSize: 0x1000 StackMem                                     : 0x20001118 SP: 0x20004F70
For more info, visit: https://mbed.com/s/error?error=0x80FF013D&tgt=NUCLEO_L073R                                     Z
-- MbedOS Error Info --

Target(s) affected by this defect ?
Not really clear what targets are.
Toolchain(s) (name and version) displaying this defect ?
I am using mbed studio as my toolchain.
What version of Mbed-os are you using (tag or sha) ?
I am using mbed-os 5.14.0.
sha: b6e5a0a8afa34dec9dae8963778aebce0c82a54b

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)
Mbed Studio 1.3.1
How is this defect reproduced ?
Following the instructions.

@JchenEng thank you for raising this issue.Please take a look at the following comments:
We cannot automatically identify a release based on the version of Mbed OS that you have provided.
Please provide either a single valid sha of the form #abcde12 or #3b8265d70af32261311a06e423ca33434d8d80de
or a single valid release tag of the form mbed-os-x.y.z .
E.g. '5.14.0.' has not been matched as a valid tag or sha.
NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirroredto our internal defect tracking system or investigated until this has been fully resolved.

@ciarmcom
Hi, I think the sha is #b6e5a0a8afa34dec9dae8963778aebce0c82a54b

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2850

@JchenEng We do not support Mbed OS 5.14, have you tried with the latest version of Mbed OS (6.14) ?
It would help if you provide more information about the application you try to execute and how to reproduce your issue.

@pan-  I updated the mbed-os version to 5.15.6 sha: b114a9c878519d6489ac3426697196bbea34c8ea

However, I am encountering issues with the fsl_sha.h file, it says fsl_devie_registers.h file is not found and unknown type name: SHA_TYPE.
fsl_sha.h
mbed-os-example-mbed5-lorawan/mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MCU_LPC546XX/drivers
4
In included file: 'fsl_device_registers.h' file not foundclang(pp_file_not_found)[37, 10]
Unknown type name 'SHA_Type'clang(unknown_typename)[104, 19]
Unknown type name 'SHA_Type'clang(unknown_typename)[118, 21]
Unknown type name 'SHA_Type'clang(unknown_typename)[133, 21]


Not work

I'm using discord.js v13 but a package doesn't work. Could any developer help me?

I'm still working on v13 version, right now it's only compatible with v12 version. You can check progress on 2.0.0 branch. I'll publish new version on npm as soon as it's ready.

I'm still working on v13 version, right now it's only compatible with v12 version. You can check progress on 2.0.0 branch. I'll publish new version on npm as soon as it's ready.

ah ok.


[BUG] porn-cli is actually a mandatory dependecy

I think that defeats the whole point in separating them.

it is not a mandatory dependecy anymore.


Add inert to the boolean attributes list

Description
Adds the inert global boolean attribute, which was added to the HTML Standard in 2022.
Checklist

[x] I have reviewed my own code
[ ] I have added tests

error: associated function `lint` is never used
  --> packages/yew-macro/src/html_tree/lint/mod.rs:15:8
   |
14 | pub trait Lint {
   |           ---- associated function in this trait
15 |     fn lint(element: &HtmlElement);
   |        ^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

The CI failure is unrelated to the change made by the PR. It's probably caused by more precise dead_code linting in recent toolchains.


rename box to t3

Hi there,
I have been using very similar boilerplate for past couple years now, t3 has some really nice features and event handling is much better I must say, I see you guys have a default namespace Box is it possible to rename it T3 so I don't have to change and recompile every time.
Thank you

The requested change would be a breaking change and would require a major release. While I can understand where you come from (we also change the box namespace), I don't know that it's worth the breaking change.
Just my 2 cents.

Yes, we will not be changing the namespace to T3, sorry! We use the Box namespace heavily (such as DOMEventDelegate) and there isn't enough value in changing it.
I recommend just having a separate JS file that contains var T3 = Box;


Walkthrough bug: unable to find suggested 'cafe' feature type during point editing tutorial

URL
https://www.openstreetmap.org/edit
How to reproduce the issue?

Open the 'Help' menu (shortcut: 'H')
Begin the editing walkthrough
Select the 'Points' walkthrough section
Click the 'Point' icon to create a new point
Click on the border of the building that appears in the middle of the transparent area
Search for the word 'Cafe' as instructed by the tutorial

Bug: 'Cafe' does not appear in the feature type selection dropdown (the top result is 'Cape')
Screenshot(s) or anything else?

Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid
What version numbers does this issue effect?
2.23.2 (iD), 2.24.0-dev (iD), 1.1.9 (RapiD)
Which browsers are you seeing this problem on?
Firefox

Click on the border of the building that appears in the middle of the transparent area

It seems like this was the problem here.  Creating a point within an unfilled region of the transparent area (where no border or other feature exists) results in a point being created, and Cafe can, as expected, be found and selected as the type for that feature.
If a bug remains here, then it is that the tutorial continues following a click on a border segment (way?).

I'm able to reproduce this issue. Adding the point to a way renders "Cafe" unfindable in the presets and the tutorial can't proceed, but adding it elsewhere makes it findable.
This issue should be a quick fix by changing tutorial text to tell people not to click on an existing line (maybe more complex if we want it to detect that the point is on a line). I'm going to mark this as a good first-time contribution issue.

Is it open? I want to contribute. @jayaddison

@tyrasd this can be closed, right? It wasn't closed automatically as the PR wasn't linked properly.


Sheva is mostly not visible :D

Version
3.1.3 (cbe02d7)
Seed
R730-9XRX-XX0J4QNZ9YJ10LNJ4U3XXZ1PYGPZTQVZZXZZ0RYZZZZZ
Scenario
RE 3 (Jill)
Player Character
Sheva
What happened?
I started a game choosing Sheva. Just letting you know

Duplicate of #541


Bug: hierarchical columns and the .select method

Description
If the name of a top level colum which contains some subcolumns is the same as a level of a 1-level colum, the .select method seems to only select the multilevel column.
Example:
If I have meta.id and meta.doc and then also another column called meta , then .select("meta") only seems to select the former two.
Version Info
0.5.1
Python 3.12.6

I'm not sure it should be allowed at all - to have a nested column meta and a regular field meta at the same time. Would it be a deal breaker for the scenario if we put a limitation like that @tibor-mach ?

Closing this in favor of for now https://github.com/iterative/datachain/issues/519


Could not translate host name "postgres" to address: Name or service not known

I tried to deploy kube-airflow on a kubernetes cluster running ubnuntu 14.04. When I run the example airflow command "airflow backfill tutorial -s ---", I get the following error:
File "/usr/local/lib/python2.7/dist-packages/psycopg2/init.py", line 130, in connect
conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) could not translate host name "postgres" to address: Name or service not known.
I checked the pods and postgres-2280134284-e2j1r pod seems to be running. Not sure whats wrong, any help is much appreciated
Note that I did not install kubernetes using minkube, I installed the kubernetes manually on ubuntu using this guide

It looks like you don't have a Service properly set up, which explains why it couldn't make a lookup for postgres on the DNS. You should create a Service for the Postgres pod in order to other applications find it

Thank you very much!

I am also encountering this error occasionally, but it's after the getting all the pods up and running for some time.
I am running a kube-airflow setup inside of GKE on Google. I'm wondering if it could be caused by flakinesss with the KubeAPI server?


Re-enable branch and commit-specific now.sh deploy preview URLs on Github

Jira
http://vjira2:8080/browse/BDS-2037 (Related But Doesn't 100% Resolve)
Summary
Re-enables the our ability to easily find the commit-specific and branch-specific deployment URLs in Github -- a core piece of functionality that we unfortunately lost recently (when we added a temp workaround to the check run bad credentials error on Travis).
Details
This PR adds inline "View Deployment" buttons next to specific commits that are pushed up in addition to providing a super helpful box at the bottom of the PR screen with the latest branch and commit-specific URLs:

NOTE: I renamed the labels for these branch-preview and commit-preview deployments mid-way through the work on this, hence why this PR has 4 links but this bugfix test PR only has the two expected links.
How to test
Does it work? No Travis CI errors? Then ship it! 🚀
There's zero code in this PR that gets published to NPM so there's very little risk merging this in ASAP so everyone can start to take advantage of this.

PR was released with v2.21.0


Fix/various fixes and refactoring

This fixes #33
Problems were

A2 got clobbered before it got saved (which totally explains https://github.com/esp-rs/esp32-hal/issues/77 )
some other registers got clobbered before spilling the registers to the stack

Additionally, this contains some refactoring

align the code more to what is found in ESP-IDF to make it easier to compare them
separate handling of double-exception from usual interrupt handling (reduces the .ifc usage and makes it easier to understand IMHO)
get PS into a defined state before calling into the user's interrupt handling code

Also, this prepares some things we'll need to get preemtive task-switching to work (to start working on using the WiFi drivers, that will also need some minor changes to the HAL - will come when this is available on crates.io)
Finally, I bumped the version of this and core-isa-parser (and updated some versions of dependencies)

Yes SPILL_REGISTERS uses WOE for spilling the registers. We use the same approach as IDF here - there is another way to do it without WOE used by NuttX I think - that code is huge and slower
Spilling the registers doesn't clobber A0-A3 but the code to prepare and restore PS and EPC1 does
The thing about  XT_STK_FRMSZ : I'm unsure .... our original code had a comment that up to 64 registers could be spilled (which would be 256 bytes) but IDF etc. just reserve 0x20 bytes. I wasn't able to find the ultimate answer and I think that was one of the first changes I did and I didn't re-check it. I somehow remember it crashed with 256 but better to check on that again.
Will look into that - probably won't get to it today anymore

A stack frame size of 256 seems to be totally fine - thanks for pointing this out. Seems I got very confused about that original code comment ... and the windowed ABI is still a bit confusing to me at least when interrupts and exceptions come into play
So, my understanding is: In extreme it will spill up to 8 registers at the "top" of the stack frame (32 bytes which matches the extra space of 0x20 reserved by IDF and NuttX).
I copied some more comments from IDF (and added some more) to hopefully make things a bit less confusing for future readers of the code - including me

@MabezDev would you mind checking the newly added comments - if they make sense and make the code more understandable?
If everyone is fine with this I'll merge and publish the changes


Teaser-list auto-populate from /products/

When the teaser-list is authored with a single link to /products, content does not seem to auto-populate:

However, if I then add the manual information after this solitary link, it does auto-populate:

as seen here https://main--merative2--hlxsites.hlx.page/employers
Word doc author page:
https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc={B7C0517A-648C-4A71-83A1-5DCED3A0B822}&file=employers.docx&action=default&mobileredirect=true

I published the target page, it got indexed in the query-index.json which is what is powering the automation. Removed the manually curated link added in the block since it was a duplicate.
If you want to change the description / title that shows up here, it can be updated in the metadata of the target page and published for the index to be updated.

Thanks for the explanation, looks fixed.


Feature/new picnic view

BIG UPDATE

create picnic functionality - user input is saved, and user becomes creator_role
join picnic functionality - user enters picnic code and picnic password, user is assigned to specified picnic
refactoring: myPicnics.handlebars and htmlRoutes.js router.get('/my-picnics'). now renders picnics hosted in green and picnics attending in pink

fixed: should work as intended with testing


Sync tagged annotations/notes to specific database properties

I'm working with the notero advanced database template. As I read through papers in Zotero, in addition to my own typed notes, I annotate the papers by highlighting a section of text and noting which column of the literature review tab they fit into (Relevance, Problem or Purpose, etc..). When I finish reading, I go through and cut and paste the highlighted text into the appropriate column in notion. I was wondering if it would be possible to automate this- my thought was to add a tag to the highlighted text in Zotero that specifies the column in notion where the text should be copied.
Originally posted by @SofiCourtney in https://github.com/dvanoni/notero/issues/4#issuecomment-1523858277

Thought: need a way to specify which Zotero tags should map to which Notero properties so that folks can customize as needed.


Implement iOS Settings Feeds Section

Main part is done on #2204
Pending stuff

[ ] Test out multiple accounts import/export
[ ] Show errors when things go wrong

We can close this as pending items on my plate is done. @vincode-io


Build an Android Application for RealSense SDK  question

Required   Info
``

Camera Model
D415

Firmware Version

Operating System & Version
ubuntu

Platform
andriod

Issue Description
I followed the android case,But here's the problem
Build command failed.
Error while executing process /home/yingzm/Android/Sdk/cmake/3.6.4111459/bin/cmake with arguments {-H/home/yingzm/AndroidStudioProjects/realsense_app/app -B/home/yingzm/AndroidStudioProjects/realsense_app/app/.externalNativeBuild/cmake/debug/armeabi-v7a -DANDROID_ABI=armeabi-v7a -DANDROID_PLATFORM=android-19 -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/yingzm/AndroidStudioProjects/realsense_app/app/build/intermediates/cmake/debug/obj/armeabi-v7a -DCMAKE_BUILD_TYPE=Debug -DANDROID_NDK=/home/yingzm/Android/Sdk/ndk-bundle -DCMAKE_CXX_FLAGS=-std=c++11 -fexceptions -DCMAKE_TOOLCHAIN_FILE=/home/yingzm/Android/Sdk/ndk-bundle/build/cmake/android.toolchain.cmake -DCMAKE_MAKE_PROGRAM=/home/yingzm/Android/Sdk/cmake/3.6.4111459/bin/ninja -GAndroid Gradle - Ninja}
CMake Error at CMakeLists.txt:14 (add_subdirectory):
/home/yingzm/AndroidStudioProjects/realsense_app/app/src/main/cpp/librealsense
does not contain a CMakeLists.txt file.
-- Configuring incomplete, errors occurred!

[Realsense Customer Engineering Team Comment]
@yingthink Seems to be the similar issue with https://intel.zendesk.com/agent/tickets/2759
Please use the CMakeLists.txt in the link below.
https://github.com/IntelRealSense/librealsense/blob/v2.13.0/doc/android/CMakeLists.txt_

[Realsense Customer Engineering Team Comment]
@yingthink Is the issue resolved?

[Realsense Customer Engineering Team Comment]
@yingthink  Is the issue resolved? If so, we'll close the ticket accordingly.

[Realsense Customer Engineering Team Comment]
@yingthink Any update about the issue? Can you build successfully now?

@RealSense-Customer-Engineering
issue was settled


bump v1.2.x branch version to 1.2.1-pre2

woops done.
fyi first commit edited build.yaml version an ran generate_projects.sh, second commit updated BUILD

test failures:

interop test failure is https://github.com/grpc/grpc-go/issues/1146
performance pr failure is https://grpc-testing.appspot.com/job/gRPC_performance_pull_requests/10428/testReport/junit/(root)/benchmarks/qps_json_driver_cpp_protobuf_sync_streaming_qps_unconstrained_secure_500kib_resource_quota/ (but streaming instead of unary config)


fixed typo for class StorageLocationDoesNotMatch

Checklist:

I have performed a self-review of my own code,
I have commented my code, particularly in hard-to-understand areas,
I have made corresponding changes to the documentation,
I have added tests that prove my fix is effective or that my feature works,
New and existing unit tests pass locally with my changes ("bundle exec rake"),
Title include "WIP" if work is in progress.

Resolves #1927
Description
Fixed class name typo
Type of change

Class name change

Thanks!


batch-edit: adding new keywords causes deletion of existing keywords

osxphotos: 0.58.1, installed using pipx
OS: Ventura 13.2.1 (M1 Mac)
If I add some new keyword(s) to an image using osxphotos batch-edit --keyword xxx, all original/existing keywords (say "yyy" and "zzz") are deleted. Is this the intended behaviour?
Thanks

This is by design but it may not be the best design. The --keyword option means "set keywords to this value" which as you noted overwrites existing keywords.  I did this because the --title and --description options overwrite the existing values and felt it was more consistent for keywords to do the same. I'm open to changing this behavior if it's not obvious.  Maybe add a --overwrite-keywords flag that, if not present, causes keywords to be appended.
In the meantime, you can add --keyword "{keyword}" (which is shown in the help text for batch-edit) which means "also add any existing keywords"

@all-contributors please add @pekingduck for ideas

@pekingduck I changed the batch-edit behavior in v0.58.2 so that it no longer overwrites the existing keywords and instead merges new keywords with the existing keywords. I also added a --replace-keywords option that causes existing keywords to be overwritten if specified.


Better logging around creating correspondence

Ticket: https://trello.com/c/XQGnlDyl
Description
This problem was caused by the date_received being blank in old Enquiries (it's now mandatory). But it was difficult to diagnose. Better log messages have been put in so that this kind of problem will be easier to diagnose in the future.
Checklist:

[ ] Automated checks are passing locally.
[ ] CHANGELOG updated if change is worth telling users about.

General testing

[ ] Test without javascript
[ ] Test on small screen

Accessibility testing

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable css - does content make sense and appear in a logical order?
[ ] Passes automated checker (automated in build or manual)

Closing as moved to https://github.com/UKGovernmentBEIS/beis-opss-psd/pull/14.


Should functions accept $closed to indicate closed paths?

It might simplify code if we used $closed as an option for specifying that paths are closed.  This would allow things like:
let($closed=true) stroke(smooth_path(offset(path_tangent(path))))

rather than having to specify closed=true on every single call.

To be honest, this feels like something that will come back to bite us if implemented.

So you're saying you're nebulously concerned, but not sure why?

This is relying on the bizarre side effects of $specialvars in a way that will hide bugs where calls inside nested functions get a $closed value that is not apparent at its call level.

ie: the $closed variable can affect calls that are INSIDE the functions that the $closed is meant to be passed to.

function pathlen(x) = path_length(x);
...
let($closed=true) stroke(smooth_path(offset(path,r=pathlen(openpath))));

I'm no longer nebulously concerned.  Not I'm concretely concerned.

I do see the point.  This could be addressed by doing
function pathlen(x) = path_length(x,closed=false);

but yeah, in general I think you're right that it's asking for trouble.

I'll mark this one as "will not implement", then.


Check table rendering

Table rendering does not seem to be working, following the syntax given in writing-text.md. The raw ASCII characters just go in the output.

Your table syntax appears to be correct (it renders correctly on GitHub here) so I will look into why it's not working in the output. Thanks, Heidi!


No module named 'urllib2' in python3+

╰─$ ansible-galaxy install -r requirements.yml
ERROR! Unexpected Exception: 'ImportError' object has no attribute 'message'
the full traceback was:

Traceback (most recent call last):
  File "/usr/local/bin/ansible-galaxy", line 79, in <module>
    mycli = getattr(__import__("ansible.cli.%s" % sub, fromlist=[myclass]), myclass)
  File "/usr/local/lib/python3.5/dist-packages/ansible/cli/galaxy.py", line 37, in <module>
    from ansible.galaxy.api import GalaxyAPI
  File "/usr/local/lib/python3.5/dist-packages/ansible/galaxy/api.py", line 30, in <module>
    from urllib2 import quote as urlquote, HTTPError
ImportError: No module named 'urllib2'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/ansible-galaxy", line 85, in <module>
    if e.message.endswith(' %s' % sub):
AttributeError: 'ImportError' object has no attribute 'message'

I will put a link to "How to install ansible" in the README.md


feat: add cli for health status

This pr provides a status check of various system components, allowing administrators to quickly assess the overall health and operational status of the Harbor registry system.
Command:
harbor health : Get the health status of Harbor components

@mahbub570 Have a look at #81. which does the same with colors.

I see, @bupd like this?

Adjust the boudaries of the box

@mahbub570  Make these changes in pkg/views/health/view.go
package health

import (
	"fmt"
	"os"

	"github.com/charmbracelet/bubbles/table"
	"github.com/charmbracelet/bubbletea"
	"github.com/goharbor/go-client/pkg/sdk/v2.0/client/health"
	"github.com/goharbor/harbor-cli/pkg/views"
	"github.com/goharbor/harbor-cli/pkg/views/base/tablelist"
)

var columns = []table.Column{
	{Title: "Component", Width: 18},
	{Title: "Status", Width: 26},
}

func PrintHealthStatus(status *health.GetHealthOK) {
	var rows []table.Row
	fmt.Printf("Harbor Health Status:: %s\n", styleStatus(status.Payload.Status))
	for _, component := range status.Payload.Components {
		rows = append(rows, table.Row{
			component.Name,
			styleStatus(component.Status),
		})
	}

	m := tablelist.NewModel(columns, rows, len(rows))

	if _, err := tea.NewProgram(m).Run(); err != nil {
		fmt.Println("Error running program:", err)
		os.Exit(1)
	}
}

func styleStatus(status string) string {
	if status == "healthy" {
		return views.GreenStyle.Render(status)
	}
	return views.RedStyle.Render(status)
}

pkg/api/health_handler.go
package api

import (
	"fmt"

	"github.com/goharbor/go-client/pkg/sdk/v2.0/client/health"
	"github.com/goharbor/harbor-cli/pkg/utils"
)

func GetHealth() (*health.GetHealthOK, error) {
	ctx, client, err := utils.ContextWithClient()
	if err != nil {
		return nil, err
	}

	response, err := client.Health.GetHealth(ctx,&health.GetHealthParams{})
	if err != nil {
		return nil, fmt.Errorf("error getting health status: %w", err)
	}

	return response, nil
}

thanks @Althaf66 for your suggestions.

ready for review


sqlalchemy tests fail due to non existing management keyword argument

geoalchemy removed the management argument from the intialization of a geoalchemy2.types._GISType earlier this year:
https://github.com/geoalchemy/geoalchemy2/pull/415
As a result of this change, subsequent geoalchemy releases are not compatible with pygeofilter's sqlalchemy tests, which are still using the management keyword argument:
https://github.com/geopython/pygeofilter/blob/a08c5a50af48816e460a2746891584bc5a4bc294/tests/backends/sqlalchemy/test_evaluate.py#L26-L36
This means the tests are currently failing.
Possible solutions:

Follow suite with geoalchemy2 and simply remove the management argument
Pin geoalchemy2 to a known version

I guess the first option is better, since the fix is really small - I'll prepare a PR with the change

@ricardogsilva what is the version of geoalchemy which introduces this change?

@tomkralidis
I believe it was version 0.14.0, which got released back in the beginning of July 2023


No. of Epochs for Training

Hi,
Can you please mention that for how many epochs you have trained the model from scratch?

16 epochs, it is visible in Python Notebook in the repo.


Deploy resources to location when different from Resource Group

When a location other than ResourceGroup is passed, deploy resources to this location and not the Resource Group location

Removed the hardcoded locations from the template, accepting either ResourceGroup to deploy to the same location as the resource group or to deploy to the location specified by the passed value.
Whilst this means the template no longer validates Azure locations, it does mean that the template will automatically work for newly introduced locations without requiring an update.


Canada

My apologies if this is a rather large PR. It enables the following:

Adds locals for Canada.
Adds gender ~“X”~ "Other" to represent LGBTQ2 community and to follow Canadian law.
Changes the postal code pattern to be compatible with Canadian postal code format.
Adds maximum zoom for the map as a config parameter. The reason is depending on the size of areas that represent postal codes you may want to limit the zoom so that the map does not mislead users with allowing to zoom in too much.
~Adds custom attribution as a config parameter.~ The base map uses data from OpenStreetMap so it has to be part of the attribution. ~Plus, you may get the postal code data from different sources so there should be a place to set the relevant info.~

I added an extra comma when resolving the conflicts, I will fix it after merge


[stable/traefik] No placeholder in Traefix chart "Values.yaml" file to apply 3rd party CA signed TLS certs

Is your feature request related to a problem? Please describe.
I don't see any placeholder in Values.yaml file for Traefik chart to apply custom TLS cert
Describe the solution you'd like
Placeholder to specify the custom public cert, internediate CA and root cert.

Certs should be managed by secret objects in your k8s cluster. Not sure what you are wanting to add?

@dtomcej , Thanks for your response.
My question is - The way Traefik (acting as Ingress controller) lets you generate the self-signed certs for applications sitting behind traefik app on k8s cluster, I didn't see any placeholder to provide 3rd party CA signed custom certs in values.yaml file for Traefik Helm chart. And if that's not the purpose of traefik, then why does it provide capability to leverage self-signed cert ?

@sunnygoel8 the usual way of doing certs with ingress is that you make a secret that has the cert in it and then the ingress resource references that secret. Refer directly to k8s documentation for this. Traefik can auto-provision secrets using ACME (Let's Encrypt) for those who are not using that usual approach.


reflect: handle blank fields in IsZero

I believe that the newly added reflect.IsZero (https://go-review.googlesource.com/c/go/+/171337) might need to skip struct fields named “_”. It is not possible without unsafe (or maybe reflect?) to construct a struct value with a non-zero value for a _ field. Nevertheless, I think that IsZero should skip such fields; cmd/compile’s generated equality and hash functions do.
cc @elwinar @ianlancetaylor @bradfitz

It seems that reflect allows accessing an _ field for read-only purposes (i.e., can't call the Interface method, but can call Int, String, etc.). Thus, it seems that IsZero probably does not need any special handling for _ fields.
https://play.golang.org/p/6SQjEHzHyrI

I don't think we need do to anything about this. If the said field doesn't have a zero value, then the struct itself doesn't either. And equality with a zero value doesn't guarantee being a zero value, as you can see for floats: a -0.0 == 0.0, but IsZero(-0.0) == false.

And equality with a zero value doesn't guarantee being a zero value, as you can see for floats

This is the thing that strikes me as uncomfortable. And floats are generally pretty weird, so that doesn't seem very exculpatory.
I guess I can see the argument either way. It is just unfortunate that being the zero value is not the same as being equal to the zero value. I guess the relevant question is what people are more likely to actually want, in practice.
At a minimum we should have a sentence of documentation about this, because the distinction is subtle. And if we do decide for the "equal to" interpretation of what this function should do, then we should change floats to match (i.e. remove the math.Float64bits from the implementation).

cc @rsc since x/s/owners lists him as an owner for reflect

I would say that not skipping _ fields does follow to the letter the definition of a zero value, and this is the actual reason why we check the sign bit for float and complex kinds.
The main use case I had to write a function like this was for not overriding user-defined fields in unmarshal-like methods. In which case, both ways are fine.
I would say that not adding an exception like this is always better if not strictly necessary.

I would say that not adding an exception like this is always better if not strictly necessary.

This is not about adding an exception. It is about asking whether the function should be about "is the zero value" or "is equal to the zero value", and then adjusting the implementation to match.

Well, the function is named IsZero, and being a strict equality rather than a loose one is a conscious choice: my first implementation was loose, and a pair of comments  asked me to do a stricter check (namely checking the sign of floats and complexes).
Furthermore, checking for a loose equality is easy enough to do without this function, one can just take a real zero value and use to it to check equality.

I looked at the equivalent usages of reflect.IsZero that I was aware of and they either didn't care about the exact definition, or did want IsZero to be the strict definition.

I think we should rather have more guidance in the doc than no method for that.
The fact that multiple people ended up writing such a function suggest that there isn't a simple and reliable way to do it and that there is a need for it.
I doubt that people able to write such a function wouldn't know if one existed. But I can very well imagine one forgetting about negative zero floats.

I think we should continue to check _ fields in struct types, and we should document IsZero to make clear that we are testing exactly whether the value is the zero value of the type, not whether it is equal to the result of reflect.Zero.  We can already test whether a reflect.Value is equal to the zero value of the type by writing v.Interface() == reflect.Zero(v.Type()).Interface().
Though perhaps the subtlety of this discussion would be a reason to not add IsZero in the first place.

I was curious about the history here so dig some digging. A bit but not much here...
https://github.com/golang/go/issues/3031
That's the bug that led to the current spec wording.
I also found that this (https://play.golang.org/p/L3vQvIhncwZ):
package main

import (
	"fmt"
)

type T struct{ a, _, c int }

func main() {
	t := T{1, 2, 3}
	fmt.Println(t)
}

... prints {1 0 3}, which was news to me at least.

I've tried setting the value of a blank field field, and only an unsafe.Pointer works (https://play.golang.org/p/sawqZxZz0SN).
I've also added tests in my branch to check IsZero's behavior:
diff --git a/src/reflect/all_test.go b/src/reflect/all_test.go
index 964d8c6e95..2e5d3e7519 100644
--- a/src/reflect/all_test.go
+++ b/src/reflect/all_test.go
@@ -1136,6 +1136,10 @@ func TestIsZero(t *testing.T) {
                // Structs
                {T{}, true},
                {T{123, 456.75, "hello", &_i}, false},
+               {struct{ _ int }{}, true},
+               {struct{ _ int }{0}, true},
+               {struct{ _ int }{2}, true},
+               {*(*struct{ _ int })(unsafe.Pointer(&struct{ i int }{2})), false},
                // UnsafePointer
                {(unsafe.Pointer)(nil), true},
                {(unsafe.Pointer)(new(int)), false},

Here, the case that don't seems obvious to me is the third one rather that the fourth. Ignoring the blank field would change the fourth behavior only, but the actual implementation conforms to IsZero
In light of this, I'm still in favor of checking the blank field and adding a comment. Or even a blog post detailing the issue and the choices made. (If you don't, I'll do it :P I've discovered plenty of things while doing this, and if this can encourage more people to start contributing, all the better.)

So, anyone to take a decision here? I can add the said documentation if we reach a consensus. @ianlancetaylor @josharian @dsnet @bradfitz

Related: #31546

@elwinar these kinds of decisions take time, research, and thought.

In light of #31546, I understand :P .

Discussed at proposal review.
Now that #31546 is fixed, nothing should be able to tell whether we look at blank fields or not: the blank fields are never written. The only way this comes up is if package unsafe is involved, whether from C or doing other shenanigans. If you explicitly go out of your way to scribble a non-zero value into a blank field, it does seem like reflect.IsZero should say "that's not the zero value". It isn't, just like float64 negative zero is not the zero value.
The compiler-generated hash/eq functions are implementing the == operation. IsZero is not "== zero value". It is "is the zero value" (cf float negative zero again).
Let's leave IsZero as is.

Not to object after closing, but consider this code:
type T struct {
	x int16
	_ int16
	y int32
}

func f() {
	t := T{x: 12, y: 7}
	g(&t)
}

//go:noescape
func g(t *T)

t is allocated on the stack. Does f need to clear the _ field? I don't think we ever had to before, but now we do, in case g calls reflect.IsZero.
It's kind of a moot point at the moment, because we currently do zero _ fields of objects allocated on the stack.  So perhaps my objection is just "if we implement a compiler optimization removing zeroing _ fields, then we would also need to modify reflect.IsZero to ignore _ fields".
The situation described above already happens for padding. The compiler does not initialize alignment padding bytes in structs, and thus reflect.IsZero needs to not check that the padding bytes are zero. (Same example as above, but remove the _ field.)


Bugfix: UDPTransportInterface::select_locators [7147]

In UDPTransportInterface::select_locators, IsLocatorSupported() is called with unicast[j].kind instead of unicast[j]. This is an error because IsLocatorSupported() receives a Locator_t as parameter, so when passing unicast[i].kind an instance of a Locator_t with kind UDP and port_number (unicast[i].kind) is created and passed to IsLocatorSupported().
This bug can cause problems when a Participant registers a Transport UDP and an additional transport like, for example, TCP. In that case UDPTransportInterface::IsLocatorSupported over TCP locators will return true because TCP locators will be converted to Locator_t (kind = UDP, port = TCP.Kind) in the call to IsLocatorSupported.

Build status:

Linux
Mac
Windows


[Feature request] Persist and load the same graph

Thanks for the great project!
Though it's possible to set a random seed for the process, graphs can get large and it creates a couple of problems:

The physics algorithms are hard to tweak to find a good final result (a lot of overlap on nodes)
It takes a while to get into something you can read after opening it

The suggestion is to have a "save graph" button to persist notes positions and then use this when opening org-roam-server again.
One additional advantage would be that people could exclude the "physics" and drag and drop the nodes to create the plot the way they want and then hit "save". The graph should become familiar to the person and then it's possible to concentrate on the new links created over time.

It should already be doing that. The node positions are saved in to the local storage when the graph is stabilized. It might be not working. I will look into it.

Oh, I didn't know that. Is it a new feature?
Is it possible a graph takes too long to stabilize or it doesn't and then it's not persisted?

Oh, I didn't know that. Is it a new feature?

I think I implemented long time ago but not sure :D
Hmm I think I found the problem. The position storage is emptied at the start so It basicly calculates it from scratch. Fixed it https://github.com/org-roam/org-roam-server/commit/93b673209d141953547fc0732506bb0efa68f804. It should be better now. Though it still does some wiggle wiggle at the start. It might be how the library works. Can you also test it to see if it is better now.

Thanks a lot for the fast solution!
I've waited for a while for my graph to get stable, but when I reloaded it restarted.
The default value for stabilization iterations is 1000. There's a 0.5 timestep I don't know if it means half a second and if I should wait 500 seconds, it is ~8 minutes, with the window active to trigger the saving function.
Then I've added a button "Save network" to execute the function "onStabilized" and it persisted the network, so the function itself works perfectly.
What I'm planning is to trigger it with physics, modify, save it, and disable physics.
Do I lose the network position when I update the package? I couldn't get where it's stored.

Hm. In fact, what happens is that, though the nodes' positions are saved, the shape of their edges are different when I reload and it causes them to interact again.
For example, here's my graph after a while. I save it this way.

When I reload, that's how it starts:

Then, after a while:

This is slightly different, but maybe defining the seed for the physical engine could solve it.
It's possible to see the positions are equal to the previous one, but the edges are not. And then the strategy of disabling physics fails because it starts with these long edges, which are not the ones I had when I saved it. I'm going to play around with the parameters to check if I can get the behavior I want. Thanks again!

I don't know if all these options are needed, but with them I can persist without physics and the edges look the same:
org-roam-server-network-vis-options "{\"physics\": {\"enabled\": false, \"stabilization\": {\"enabled\": false, \"iterations\": 100}}, \"edges\": {\"physics\": false, \"length\": 5, \"hidden\": false, \"smooth\": {\"enabled\": true, \"type\": \"continuous\"}}}"


Add V2 Application API endpoints

Added a V2 API for application with minor tweaks & cleanup.
@ajordens

There was also GET /v2/applications/{name}/history for all the history.
You cannot retrieve a particular version but I think that's ok for how it is used.

These changes look good to me.
+1 to transitioning from 202 to 204 as well.

@ajordens See the updated PR

LGTM


Support Xcode 11 / Swift 5.1

I get this error message when trying to fetch using Carthage:
A shell task (/usr/bin/env git fetch --prune --quiet https://github.com/mxcl/PromiseKit.git refs/tags/*:refs/tags/* +refs/heads/*:refs/heads/* (launched in /Users/my_user/Library/Caches/org.carthage.CarthageKit/dependencies/PromiseKit)) failed with exit code 1
I can reproduce it with both Xcode 11 betas 3 & 4


Add link between swiftBasic and swiftAST

swiftBasic uses InFlightDiagnostic::flush, which is defined in swiftAST. The build graph did not contain that link edge, so it failed to link on Windows. No idea how it's working on macOS ¯_(ツ)_/¯.

@swift-ci please test windows

@swift-ci please test macOS

@swift-ci please test linux

🤮 if it builds, it ships?
I certainly feel nauseous about this patch too. 🤢
Eventually, we should probably push the diagnostic pieces up into swiftBasic and break the cycle.

macOS failure:
/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/stdlib/public/Cxx/std/String.swift:30:34: error: value of type 'std.string' (aka 'std.__1.__CxxTemplateInstNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE') has no member '__c_strUnsafe'
    self.init(cString: cxxString.__c_strUnsafe())
                       ~~~~~~~~~ ^~~~~~~~~~~~~

@swift-ci please smoke test macOS

I think I can sink the version parsing out of Basic. This is... quite the layering violation.

@swift-ci please smoke test macOS
(testing to try to see if this can be merged to fix windows PR testing)


Plugin 'com.headwire.aem.tooling.intellij' failed to initialize

Hi,
try to install the plugin in Intellij 2016.1.3 failed
Plugin 'com.headwire.aem.tooling.intellij' failed to initialize and will be disabled.  Please restart IntelliJ IDEA.
java.lang.ClassNotFoundException: com.headwire.aem.tooling.intellij.console.ConsoleLog PluginClassLoader[com.headwire.aem.tooling.intellij, 0.7.1]
at com.intellij.ide.plugins.cl.PluginClassLoader.loadClass(PluginClassLoader.java:64)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:348)
at com.intellij.openapi.components.impl.ComponentManagerImpl.a(ComponentManagerImpl.java:412)
at com.intellij.openapi.components.impl.ComponentManagerImpl.init(ComponentManagerImpl.java:96)
at com.intellij.openapi.application.impl.ApplicationImpl.load(ApplicationImpl.java:458)
at com.intellij.openapi.application.impl.ApplicationImpl.load(ApplicationImpl.java:450)
at com.intellij.idea.IdeaApplication.run(IdeaApplication.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.idea.MainImpl$1$1$1.run(MainImpl.java:61)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:756)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:726)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:366)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

updated to
IntelliJ IDEA 2016.1.4
Build #IU-145.2070, built on August 2, 2016
JRE: 1.8.0_92-b14 amd64
JVM: Java HotSpot(TM) 64-Bit Server VM by Oracle Corporation
same problem

Hi
Lately there are some issues popping up with the plugin that are hard to track down. I checked the 0.7.1 zip file and the class is there in the right location but it could be that the static initializer fail causing this issues. Can you do me a favor and do the following to narrow it down:

In IntelliJ go to Help -> Show Log in Explorer (or something alike: https://intellij-support.jetbrains.com/hc/en-us/articles/207241085-Locating-IDE-log-files)
Remove our plugin from IntelliJ
Shut down IntelliJ
Copy away the idea.log file or delete it
Start IntelliJ
Install the plugin
Restart IntelliJ
Attach the log file here

I am sorry for the drag but I am working on a Mac and I do not have that issue.
Thanks - Andy Schaefer

I am having the same issue and I am on a Mac. Attached is the log per your request.
Thanks - Shaun English
idea.log.txt

@gittergoing I tried the Plugin in Mac OS X 10.12 and the latest IntelliJ CE and it works fine for me.
I will do some more testing and if nothing comes up I will create a version without the Console Log for you to test.
Could you open the Plugin ZIP file and make sure the class is there (just to be on the save side).

I still cannot reproduce the issue but it might be a race condition. I did add some NPE guards and avoided class member initialization to see if an exception might cause the issue. I also guarded some of the classes that uses the Console Log from NPEs.
I will soon issue an beta release of 0.7.2. Please give it a try and let me know if that works for you. The plugin might be working but you might have no log statements in the AEM Log. It would be appreciated if you could post an updated idea.log if you see any error statements from the Plugin.

Here is the 0.7.2-beta version of the Plugin. It contains guards and adjustments to the ConsoleLog but because I cannot reproduce it this is a shot into the dark. Let me know if that fixes your issues:
https://db.tt/CaZfB5mj

I was finally able to reproduce the issue where the automatic start of a Run / Debug Connection is ending up in a deadlock. For now I disabled that feature to make the plugin usable again until we have a fix for it. Please download 0.7.2-beta2 from here: https://db.tt/Q7a1KSlE

The plugin release 1.0 has some changes to the way it imports libraries.
As I did not hear anything since November last year I close this. Re-open it if you encounter this issues with release 1.0.

Cannot find 1.0 release anywhere and facing this problem.