Angular compiler implementation for named arguments anywhere

See #47451 for the meta issue and dart-lang/language#1072 for the language issue.

What's the timeline for this work?

We're trying to figure it out now. We're just setting up the tracking mechanisms (meta issue, github project, ...). Once we have those and have very rough estimates for the impl. costs for the various tools we could figure out when it might ship.
The tldr is that it's available to be implemented but that we don't know when it might ship.

Internal issue: b/209865431
cc @leonsenft

FYI, the flag has been flipped so these can be used without a flag internally now.

Is this actually done?  The internal issue is still open.

The internal bug has just been wrapped up. All set to close this issue now.

Thanks!


Bugfixes in labs

Handle  elements not preceded by other tokens correctly; in these cases, currently_open will be an empty array
Handle URLs not containing a / after the domain
s/self/this/ in runtime9.js
Output "comment9.js" instead of "comment.js" in server9.js
Output the id=errors div in server9.js, which is expected by the script
Wrong order of arguments to ElementNode constructor in lab6.py

The comparison script for lab4 seems to have gone rogue. It is recording diffs that aren't in my CL...any suggestion or idea?

Yeah the differ could stand a rework now that I've built all this other infra for compiling and outlining. Anyway, fixed it by reminding it that these lines should be indented. I don't understand why it doesn't do that automatically but it helps sometimes.

For the "URLs not containing a slash" I would write that code like this:
if (url.find("/") >= 0):
    host, path = url.split("/", 1)
else:
    host, path = url, ""

Is there a comparable part of Chapter 1 that we should update?

The "elements not preceded by other ..." that doesn't happen in Ch4, right? The code for labs 6 onward aren't up to date with the changes so far in the book. (Sometimes the changes would be large which is why I don't want to do it before we get to those chapters.)

Other things look good.

For the "URLs not containing a slash" I would write that code like this:
if (url.find("/") >= 0):
    host, path = url.split("/", 1)
else:
    host, path = url, ""

Doesn't this have a scoping problem for the variables host and path?

Is there a comparable part of Chapter 1 that we should update?

I already fixed it in a previous PR.

There's not a scoping problem in Python—"if" and "for" and so on don't introduce scopes. (I just implemented this in the compiler, since JS semantics are different!)

The "elements not preceded by other ..." that doesn't happen in Ch4, right? The code for labs 6 onward aren't up to date with the changes so far in the book. (Sometimes the changes would be large which is why I don't want to do it before we get to those chapters.)

Right. It was only broken for the later labs.
I came across this because I'm working on a lab for my new chapter 13, which needs to riff on chapter 9's code.

Ok sounds good happy to merge this. If you'd like I can bring Ch9 up to date.

I upda

There's not a scoping problem in Python—"if" and "for" and so on don't introduce scopes. (I just implemented this in the compiler, since JS semantics are different!)

Got it. I fixed the code then.


fix(events getting deselcted)

related to  #223
image:

will update page jump issue after getting reply for this comment

@PixeledCode


After updating the CLI to the latest when amplify push api it's doesn't ask me anymore to update the api.service.ts

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
15.0.0
Amplify CLI Version
4.461
What operating system are you using?
Windows
Amplify Categories
api
Amplify Commands
push
Describe the bug
After updating the CLI to the latest when amplify push API it's doesn't ask me anymore to update the api.service.ts.
We using some of the auto-generated API service queries. and it's stopped to ask if to update it and to update it.
Expected behavior
To ask if you want to update the API.service.ts. or to automatic update and on my side i will choose if to push the files.
or a flag so i will be able to add.
Reproduction steps

Change your amplify graphql schema
Amplify push
will not ask you if to update the API.service.ts

I am not able to reproduce this issue. Could you provide more contents so that I could have a better picture of the issue:

Which schema file did you change?(path is supposed to be amplify/backend/api/${api_name}/schema.graphql
If you do the first one, could you run amplify status before the push to check if the API category get the UPDATE status?
If the two above have no problem, could you provide your .graphqlconfig.yml file which should be under your project root.

Since the push does not update your schema, I suggest a temporary solution to run amplify codegen manually to update your API.service.ts

For the 2 above configured good ( 1,2 ) there is a location and it's on the right path.
About the graphql config I am sending it now :

Amplify Codegen did the magic for now :)
and generated the API.service.ts
much thanks!


[DO-NOT-MERGE] Test if PR 26800 really fixes the issue

What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

Test build #115006 has started for PR 26802 at commit ed5a089.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19826/
Test PASSed.

Test build #115006 has finished for PR 26802 at commit ed5a089.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115006/
Test FAILed.


Added support for the user data multiLineShort

Adds support for the user data "multiLineShort" which works in conjunction with the user data "multiLine" that makes the StringParameterValueWidget to have a fixed short size which is used for brief descriptions.
Changed Log:

GafferCortexUI: Added support for the user data multiLineShort in the StringParameterValueWidget

Hi Paulo, thanks for this. It seems like a really handy feature, but I think we could implement it in a way which is more useful elsewhere. I'm trying to get the UI to the point where everything is controlled by metadata on the plugs, so that every UI feature will be controllable from the UIEditor in the end. The aim is to have custom Boxes be first class citizens alongside real nodes.
Do you think we could implement it this way?

Add methods to MultiLineTextWidget to specify a fixed height (in number of lines, rather than pixels). This would be a bit like TextWidget.setFixedCharacterWidth().
Add support for a metadata entry in MultiLineStringPlugValueWidget, using it to control the size of the text widget.
Map your parameter user data to the metadata entry. Maybe just allowing the user to specify the number of lines explicitly, rather than just "short".

That way we get useful functionality at every layer of the framework, rather than just something very specific to GafferCortex. What do you think?

Hi John,
Sounds great for me to get it for the base multiline text widget,I'll try to get back to this pull request as soon as possible.

Hi John,
I've made the changes we have discussed, I'm not super sure about that "fixedLines" name (maybe there is a better name for it, any thoughts ?). Also, noticed that you have to defined that  'QWIDGETSIZE_MAX' macro in the "PlugLayout" class and I had to do that as well, maybe we should centralize it, what do you think about it ?
Cheers,
Paulo

Hi Paulo, I've added a few comments which hopefully you think are reasonable. Do you think you could address them and then rebase everything to have a nice clean history with one commit for the MultiLineTextWidget, one for the MultiLineStringPlugValueWidget, and one for the parameter UI? Then I think we'll have a nice tidy implementation of some very handy functionality...
Thanks...
John

Thanks for the comments John, I'm gonna address this pull request following your suggestions.
Cheers,
Paulo

Hi John,
I've addressed the changes and rebased it, thanks for the suggestions!
Could you take a look into it ?
Cheers

Hi John,
I've addressed the changes and rebased it, thanks for the suggestions!
Could you take a look into it ?
Cheers

Thanks Paulo - looks great apart from the two minor comments I made. Maybe you could address those and then we can merge?

Hi John,
I was not aware about widget.bound and widget.size where those added recently in gaffer ? they are quite handy :)
I've added tests for the TextWidget.fixedCharacterWidth and MultiLineTextWidget.fixedLineHeight. Also, fixed that plug metadata check which was happening outside of the plug test.
Cheers

Nice one - thanks Paulo. Looks like the size() and bound() methods have been around since 2011 and 2012 respectively, so not particularly new. As a general rule, if you find yourself needing direct access to the underlying QWidget, it's good to look for an alternative in the public API - the aim with GafferUI is to entirely shield the user from the underlying (Qt, but was once GTK) implementation. I'm sure there's the odd hole still, but I'd like to get them all patched up.


Markbind default.md: Change ref attribute of github link

Thanks for editing the destination link to our repository!


UR10 Should MoveP be used instead of MoveL?

Hi all, first of all thanks for the fantastic components. Has made working with the UR10 a real joy. I had a question in regards to the type of moves that are generated. I am debugging some non-planar printing definitions and noticed that the speed of movement at TCP is not constant during the largest vertical axis changes. I have a few theories why that may be, angle speed limits, TCP that should be configured within the extruded bead instead of tip of the nozzle. But then I noticed that the generated programs use MoveL which as far as I can read, doesn't provide continuous speed. MoveP should be used for that?
from this article:
"MoveP will move the tool in linear motion at constant speed with circular blends, and is intended for process operations, like sealing or dispensing."
Any thoughts on this?

Thanks @KonradJuenger I’ll first try just editing the text before forking and see if that makes a difference. First going to solve extruder control before heading back to debugging non-planar code.
Ps. Came across your work last year on Instagram, really nice. We made a film with a Franka arm but that was just using the teaching mode. Never been able to do something more than simple joint or Cartesian motion with manual waypoints and the occasional build in lissajous. What method did you use for more elaborate tool paths? Did you connect it to Grasshopper too?

@visose you closed this issue but I'm curious if the use of MoveL is as intended or should it be changed to MoveP?

Hi, you can use @KonradJuenger's fork if you prefer to use MoveP over MoveL.
Which one to use will depend on your requirements. MoveP seems useful if you prefer constant speed at the expense of the speed being lower and not match as closely to the programmed speed.
When we developed UR support we had only access to first generation UR10s which predate the MoveP instruction. At least I don't remember seeing it in the docs then.

For example, you might still prefer MoveL if:

You are cutting something, as you might want sharper corners in the path and don't mind the slow down when turning the corner, then speed up on other places to finish the cut quicker.

You are extruding something, and the extruder motor is coupled to the robot controller in such way that the flow can be synched to the speed of the robot, so you can have consistent flow on speed changes. This is specially useful in extrusion since its such a sloow process.

You might prefer MoveP if:

You are extruding something, but the extruder is not coupled to the robot and is constantly extruding material at the same rate, no mater the robot speed. For extrusion I discourage this approach, as robot speed ends up changing. To not change at all, it has to limit itself to the worst case scenario of the whole path, like the sharpest corner, where everywhere else it could go faster, but its not doing it, just because of that one corner.

@visose Thanks, once I get back to the machine next month I'll try the fork to see if it solves my non-planar speed issues.


Polymer unresolved to prevent FOUC doesn't work when a second attribute exists

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

In your Polymer app's body, set "unresolved" to prevent FOUC.
Also add a second attribute, touch-action="auto".
BUILD and run your app in Chrome, and note FOUC exists.
Remove the second attribute and note FOUC gone.

What version of the product are you using?
SDK 1.6, Polymer 0.13.
Please provide any additional information below.

This issue has been moved to dart-lang/polymer-dart#289.


Launcher should snap the newly launched app if the current app is maximized in desktop mode

Proposal: Launcher should snap the newly launched app if the current app is maximized in desktop mode
In tablet mode, the launcher will snap the newly launched app however it doesn't in desktop mode. While if the current window that requested launch is not maximized yes it should not snap the newly launched app since there's free windowing. But if the current window is maximized I expect the newly launched window to be snapped if it supports resizing and snapping.
Rationale

Improved user experience for end users

Scope

Capability
Priority

This proposal will allow developers to disable this behaviour and let the target app use it's defaut size
Must

This proposal will allow end users to see launched app snapped if current app is maximized
Should

If the original app is floating then it doesn't matter but when both are maximized it makes much more sense to snap instead of leaving them maximized

If the original app is floating then it doesn't matter but when both are maximized it makes much more sense to snap instead of leaving them maximized

I read this as a windows window management UX request, and not a windowing API feature as it is currently written. It is basically asking for "parts of TabletMode" to be moved into the Desktop environment. I.e. this is not a Reunion feature and should instead be logged as a suggestion using Feedback Hub.

Almost a year has passed since last comment, and I see no comment about actually having filed a FeedbackHub issue/feature request. Closing the issue since it is not a Windows App SDK feature but a Windows UX one.

I finally created a Feedback Hub feature requested: https://aka.ms/AAgrsgl.


Aventertainments scraper broken

Using 2.5.11 (but this was busted earlier I think..)
Scraping titles from Aventertainments will result in properly named folders and images, but the .nfo file will be blank.  I bet it's because Aventertainment updated their page layout or something
Javinizer -Find 010623-001 -aventertainment                                   Source        : aventertainmentja Url           : https://www.aventertainments.com/ppv/72455/1/1/new_detail Id            : DLcarib_010623-001 Title         :  ReleaseDate   : 2023-01-06 ReleaseYear   : 2023 Runtime       : 55 Maker         : Caribbeancom Actress       :  Genre         :  CoverUrl      :  ScreenshotUrl :
error message when sorting
Javinizer -settingsPath "/home/org0ne/.local/share/powershell/Modules/Javinizer/2.5.11/jvSettings-carib.json" -recurse  Write-Error: /home/scott/.local/share/powershell/Modules/Javinizer/2.5.11/Public/Invoke-JVParallel.ps1:568                                  Line |                                                                                568 |              Get-RunspaceData -Wait                                                                                |              ~~~~~~~~~~~~~~~~~~~~~~                                                                                | Cannot process argument transformation on parameter 'String'. Cannot convert value to type System.String.
attaching my jvSettings-carib.json as a txt file for reference
jvSettings-carib.txt

Should be fixed in the upcoming version 2.5.14.


Allow layers to hold a range of segments

We will need to have layers that cover a range of segments, to deal with small relations efficiently. The requires changes to the Layer structs, to hold a range of SegmentTags instead of just one SegmentTag. That affects the way they store the page versions, as well as the interface functions like get_page_reconstruct_data.
We will need logic to partition the key space in a smart way. But as a very first step, let's smash together all system catalogs into one partition, and continue with the 1:1 mapping between relation and segment for everything else. That requires all the changes to Layer structs, and allows us to implement a smarter partitioning scheme later.
I'm thinking that we still divide the key-space into segments, with SegmentTag representing each segment, but allow a layer to cover a range of SegmentTags. An alternative would be to drop the SegmentTag notion altogether, and allow each layer to cover a range of (RelishTag, BlockNumber) directly. But I think the notion of SegmentTag is still useful.

@patins, since you've worked on Image/DeltaLayers, VecMap and PageVersions and all that before, I think this is right up your alley.

As I thought about before; we could potentially apply the concepts of consistent hashing here as well; where we consider the bitspace of [nspid (* ?), datid, relid, forknum, blocknum] as the hash, so that blocks of a relation are still generally located in the same segment / layer. Consistent hashing being chosen because that it is a well-understood sharding algorithm with N shard descriptors for N shards, instead of O(d) for d proportional to data.
It would probably be also useful to use a different ordering of these attributes (forknum between datid and relid) to put all visibility maps / free space maps / data relations together.

I don't think we use / support meaningful different namespaces.

Looks done to me.


Unsafe associated functions aren't highlighted like unsafe free functions

First off, thank you for creating such an awesome piece of software. I'm amazed by how much works out of the box.
I've configured VSCode to highlight unsafe functions and operators in red.
"editor.semanticTokenColorCustomizations": {
        "[My Theme Name]": {
            "rules": {
                "operator.unsafe": "#ff6600",
                "function.unsafe": "#ff6600"
            }
        }
    },

If I input the following code it is incorrectly highlighted.
fn foo() {
    unsafe { unsafe_fn() };
    unsafe { Foo::unsafe_assoc_fn() };
}

unsafe fn unsafe_fn() {}

pub struct Foo;

impl Foo {
    unsafe fn unsafe_assoc_fn() {}
}

Actual:

Expected: Associated functions and methods are highlighted as unsafe.
If this is a bug, and you think it's suitable for a beginner, I'd be interested in contributing a PR.

This works fine for me, I believe you might have a bad highlighting rule that isnt applicable here. Can you check the semantic tokens of unsafe_assoc_fn? You can do that by pressing ctrl + shift + p/f1 and running Developer: Inspect Editor Tokens and Scopes. That will show you a special hover for the token your cursor is on like here

I assume your semantic highlighting rules are something like:
"method.static:rs": ...,
"method.unsafe:rs": ...,

those collide, probably causing static to take priority for you here. You'd need an extra rule
"method.static.unsafe:rs": ...

set to the unsafe color in that case.

Thank you. I didn't know I needed a separate highlighting rule for methods. I had copied the example I saw in the changelog because I didn't see any docs anywhere else when googling for this feature.
My semantic highlighting modifications to the theme I use were previously only what I included above
"editor.semanticTokenColorCustomizations": {
        "[My Theme Name]": {
            "rules": {
                "operator.unsafe": "#ff6600",
                "function.unsafe": "#ff6600"
            }
        }
    },
}

Based on your advice I fixed it to look like
"editor.semanticTokenColorCustomizations": {
        "[My Theme Name]": {
            "rules": {
                "operator.unsafe": "#ff6600",
                "function.unsafe": "#ff6600"
                "method.unsafe": "#ff6600"
            }
        }
    },
}

Adding :rs as you suggested didn't work, the rules didn't apply to any code.

Right it should be :rust but that doesn't matter, that makes it only apply to rust specifically then.
I take it the problem is resolved then?
And yes semantic highlighting isnt well documented in vscode at least from what I remember, we might want to improve our docs on this just because.

Yep, my problem is resolved. I've made a PR that adds this to the docs: https://github.com/rust-analyzer/rust-analyzer.github.io/pull/100


Simulator Video Playback - Xcode 12 beta 5

Hi there. This may be Xcode beta issue but I think you should be aware of the feedback. When running the sample "Basic Playback" project in the simulator there is no video just audio on the simulated device. This is present in Xcode 12 beta 5, iPhone 11. The video for the sample project works on a real device.

Hi, thanks for the report. I've seen this behavior as well. Simulator A/V has improved dramatically over the last few betas, but unfortunately this particular issue persists.
Would you mind sharing your macOS version as well? I plan to file a radar with Apple for the underlying issue. I'll provide a link here and we can keep this issue open.

Thanks very much. I am working off Mac Catalina version 10.15.6. I can confirm that this behaviour persists on Xcode 12 beta 6.

We've since tweaked the decoder settings for better compatibility of decoded frames, and this resolves the beta simulator black frame issue. This will be part of the next SDK release.


size of options to display

select2 doesn't use the size= in the select. How can I show more choices? By default it shows about 7.

Late response, but if someone stumbles upon this thread with the same issue, I just wrote a plugin to expand Select2 dropdowns vertically where possible: https://github.com/panorama-ed/maximize-select2-height

This also worked for me:
$('#selectField').on('select2:open', function (e) {
  var container = $(this).select('select2-container');
  var position = container.offset().top;
  var availableHeight = $(window).height() - position - container.outerHeight();
  var bottomPadding = 50; // Set as needed
  $('ul.select2-results__options').css('max-height', (availableHeight - bottomPadding) + 'px');
});


"Avbildningsdata" -> "Bilddata"

The title of the section "Avbildningsdata" (Swedish version of "Imaging data") should be "Bilddata".

Are you sure about that one? I don't have any specific standard for "Imaging data", but the official translations in MESH usually use "avbildning", e.g.:

Molecular Imaging -> Molekylär avbildning link
Optical Imaging -> Optisk avbildning link
Perfusion Imaging -> Perfusionsavbildning link
Radionuclide Imaging -> Radionuklidavbildning link

The only exceptions I could find are where the methods have specific names in Swedish and Diagnostic Imaging (Bilddiagnostik link)

Yes I am sure. I don't think those terms are well established by people in the field. We talk about "bildanalys", "bildverktyg", "bildbehandling" etc.
Google fight: "bilddata" -> 72,600 hits. "Avbildningsdata" -> 987 hits.

Ok. I also thing "bilddata" sounds better, but I became a bit doubtful when I saw that the majority of the translated MESH terms used "avbildning". Will fix it.


QUESTION: route based package chunking

hi,
The project is great, and I want to thank you first.
I'm working on a performance-focused project, and I want to chunk and separate route-based packages.
vendor: {
          test: /[\\/]node_modules[\\/]/,
          enforce: true,
          chunks: 'all',
          name(module: any) {
            const packageName = module.context.match(/[\\/]node_modules[\\/](.*?)([\\/]|$)/)[1];

            switch (packageName) {
              case 'react':
              case 'react-dom':
              case 'scheduler':
              case 'object-assign':
                return 'react';
              case 'path-to-regexp':
              case 'uuid':
                return 'rarely';
              default:
                return 'vendor';
            }
          },
        },

I want to separate them like the structure here, such as homeVendor, usersVendor, etc., and load only that vendor on the relevant page. Separating them is not a problem, but how can I decide which vendor to load on which route? Is it possible to do something like this?

Hi)
You have to understand, that there is no way back if you'll start to work with code splitting in a such way) I mean such manual control.

how can I decide which vendor to load on which route
In my opinion, it's better to delegate this job to webpack or something. Cause it's highly possible, that you can break something or forget to load something important in such manual way.

In that project there is a webpack plugin: https://github.com/artem-malko/react-ssr-template/blob/main/webpack/plugins/dependencyManager/plugin.ts But this plugin can help you to have control over dynamic imports only. And it has some bugs) I'll try to fix it asap) But who knows, may be you will find something useful from it)
By the way, you said, that

Separating them is not a problem
How did you do that?)

@ahmetkuslular my plugin is ok, no bugs) I've fixed it already =)


[BEAM-8575] Windows idempotency: Applying the same window fn (or wind…

…ow fn + GBK) to the input multiple times will have the same effect as applying it once

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

beam_PostCommit_Py_VR_Dataflow

R: @lcwik
Hi Luke, I suppose I will spend longer time on the custom Window fn test, so I separate the other two more trivial tests on window idempotency (from https://github.com/apache/beam/pull/9957) into this PR to get them in faster. Thanks!
I will later update the original PR of the custom Window Fn test.

Run Python PreCommit

Thanks Luke for the quick review! Updated test names. Good to merge:)

Run Portable_Python PreCommit

6 tests started failing consistently in https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/ after this merge?
apache_beam.transforms.window_test.WindowTest.test_window_assignment_idempotency
apache_beam.transforms.window_test.WindowTest.test_window_assignment_idempotency
apache_beam.transforms.window_test.WindowTest.test_window_assignment_through_multiple_gbk_idempotency
apache_beam.transforms.window_test.WindowTest.test_window_assignment_through_multiple_gbk_idempotency
apache_beam.transforms.window_test.WindowTest.test_window_assignment_idempotency
apache_beam.transforms.window_test.WindowTest.test_window_assignment_through_multiple_gbk_idempotency
@liumomo315 does this seem related?

Yeah... having another PR to fix it https://github.com/apache/beam/pull/10111/files @alanmyrvold PTAL. Thanks!


Add tmux fallback in case output of last cmd is not available

If running in tmux, use the text currently visible on screen (or more precisely in the currently active tmux-pane) if command output is not available.
For tmux users this gives the benefits of:
*) Circumventing having to set  $XONSH_CAPTURE_ALWAYS = True, which breaks commands like "git commit",
*) Circumventing the known issue "cat file is not captured".

Hi @dev2718! Very nice! Thanks!

Hi @dev2718! Very nice! Thanks!


fix small spelling mistake in fonts.el

There is a small spelling mistake in fonts.el. This is just a small PR to fix it.

This looks good to me, but would you mind retargeting/rebasing this PR onto the straight branch? It will be merged into develop soon and it'd be a big help if PRs between now and then targeted it instead.

Sounds good. I think I have changed it accordingly.

Great. Thanks for the help!


Can't reorder tabs when opened as administrator

Windows Terminal version (or Windows build number)
10.0.22000.0
Other Software
No response
Steps to reproduce
Open Windows Terminal as admistrator and create a new tab (so you have at least 2). Try to reorder the tabs (click + drag).
Expected Behavior
Ability to reorder tabs (works when Windows Terminal is launched without admin privileges).
Actual Behavior
Can't reorder tabs.

This is by design. Please make sure to search for duplicates when filing new issues.  This is something that we can't support right now due to some platform limitations. Turns out, even if we tried to support reordering tabs while elevated, the application would actually just crash 😨. See #4874, #5564 and others for more details.
/dup #6893


adding a guard for the critical section of the destroy function

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use system colors (dark/light mode compatible)

Use system-defined colors for text/background/caret - this makes it work nicely in light/dark mode

Oh another beautiful contribution, thanks for this!   It is a great touch!


Worldcharts 1-8 & 9-15 missing

Maybe they are trackloaders? Must investigate 😊

Adding issues 1-5. Issue 6 isn’t NDOS, but there’s no regular file table either. Checking the rest as I go...

7 is a regular binary. 8 uses the same scheme as 6.

Added all issues with regular filesystems in de056262fbefa0806c293c8309948796997e8f8e


fix: split query service current_pa calculation

This PR fixes the calculation of total_area and current_pa made in split query service. The idea is to have the same logic in both, copy and split query services for these columns as they should be independent from the operation kind
Link to the related task manager tickets
Strange gap analysis values with split features

If we compare the made to current_pa calculation in  SplitQuery to the current_pa calculation made in CopyQuery  there is still a difference. In CopyQuery we intersect protected areas with project.bbox, this check has not been made in SplitQuery but can be added if it is considered necessary


No connection to FC

Hi,
I don't have connection to FC with the KISS_OSD but I do have a connection with the KISS_OSD_CONFIG tool, so RX and TX wires are correctly installed.
What should I change or is this a bug?
Best Regards, Nils

Does your KISS FC have V1.2 installed?
KISS OSD V2.3 requires KISS FC V.1.2.

Thanks a lot! I didn't notice that I was still on V1.1.


External vault support

Purpose

Version bump of ConfigMapper from 1.0.2 to 1.0.13

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 7 committers have signed the CLA.:white_check_mark: DimalChandrasiri:white_check_mark: sanduniNagahage:white_check_mark: tharindu-bandara:white_check_mark: somindatommy:white_check_mark: DinikaSen:white_check_mark: emswbandara:x: wso2-jenkins-botYou have signed the CLA already but the status is still pending? Let us recheck it.


Implement compare view

The compare view should be based on the PoC. This means:

Selection of versions to compare
A dedicated view
Dynamic paging
Colorized and highlighted diff
Overview of added, removed and modified resources

Hey team! Please add your planning poker estimate with ZenHub @bartv @andraskvr @Stijnkool

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @bartv @Stijnkool


[New] add optional mapper function to uniqueArrayOf

Added new propType uniqueArrayWithMapper: uniqueArray, with an additional function parameter that allows for a non-standard unique calculation (Object.is). The function is applied to each element in the array, and the resulting values are compared using the standard unique calculation.

Released in v2.8.0. Thanks!!


[Docs][Prebuilt] Add new prebuilt page

Change the prebuilt page to SLM models; still include the previous prebuilt page but deprecated. Will follow up with runtime documentation.

cc @tqchen


Remove obsolete link in benchmarks

Pull request information

Status: ready to merge
Kind of changes: remove link
Related PR or issue: -

Description

The link links to old Flow website and doesn't contain any contribution anyway.

Pull Request Test Coverage Report for Build 3819

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.289%

Totals

Change from base Build 3811:
0.0%

Covered Lines:
8268

Relevant Lines:
9057

💛  - Coveralls


  This is the expected behavior of the build system.

OPS Build status updates of commit dd10889:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/speech-service.md
:warning:Warning
View (azure-node-latest) View (azure-node-preview)
Details

docs-ref-services/speech-service.md

[Warning] Uid(microsoft-cognitiveservices-speech-sdk) has already been defined in docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@MicrosoftDocs/ops_admin, @MicrosoftDocs/pubdesk  - could somebody have a look at this PR, please?
Thanks, Mark


Lucas Week 3 Review Ticket

AppLab Quiz Planning Blog
AppLab Quiz Link
Early Planning for Create Performance Task

Great Job Lucas! I love how you have a very  looking quiz and have many gifs throughout it. It ran very smoothly and you had many ways to answer the questions including images that you can click. I also loved how you detailed your experiences coding this week in your blog post.

Lucas good job! Your quiz ran very smoothly and really like how well you decorated it with many gifs. I like how yo also went through the planning process on how you made your quiz. Also talking about how you can improve it and including how you overcame the challenges that you met.


SectionFormat::Rust is not implemented

Currently, SectionFormat::Rust behaves just like SectionFormat::Tabs, nothing in the code seems to even look at this option.

Yes, I was only using tabs in my docs, so I left the enum variant to prevent breaking changes, but did not develop the variant by lack of interest. Would you like it to be implemented ? The idea was to display sections in a single page instead of splitting them in tabs.

I think I'd prefer using them with the Rust-style format, but of course I'm unsure. However, for me the Tabs variant also didn't quite seem to work, although that might be user-error -- either way, adding at least a "This is not yet implemented" comment would likely be a good idea.
Currently I just wrote my own, super minimal renderer for rhai docs based on the datastructures exposed here -- so absolutely no hurry!


*resuid improvements

This change allows one to pass an Option, where None denotes no change. This should be the equivalent of passing a value of -1 in C setresuid.
To test that setresuid(-1, ...) is equivalent to setresuid(UINT_MAX, ...) (i.e. setresuid(4294967295, ...)), I did the following:
I tested this on Fedora 28, on an x86_64 system (Thinkpad T450) with 4.17.5-200 kernel. First, I changed UID_MAX in /etc/login.defs to UINT_MAX I wanted to confirm that the actual UINT_MAX value is reserved:
sevagh:nix $ grep '^UID_MAX' /etc/login.defs
UID_MAX<PHONE_NUMBER>
sevagh:nix $ useradd fakeuser -u<PHONE_NUMBER>
useradd: invalid user ID '4294967295'
sevagh:nix $ useradd fakeuser -u<PHONE_NUMBER>
useradd: cannot open /etc/passwd
useradd: failed to unlock /etc/passwd

Also wrote up a little C file to make sure:
#define _GNU_SOURCE
#include <unistd.h>
#include <stdio.h>
#include <limits.h>

void main() {
    printf("Hello world\n");

    uid_t x = -1;
    uid_t y = UINT_MAX;
    if (x == y) {
        printf("(uid_t x = -1) == (uid_t UINT_MAX)\n");
    } else {
        printf("(uid_t x = -1) != (uid_t UINT_MAX)\n");
    }
    printf("printf uid_t -1 with %%u: %u\n", x);
    printf("printf UINT_MAX with %%u: %u\n", UINT_MAX);
    static uid_t euid, ruid, suid;
    setresuid(-1, -1, -1);
    getresuid(&ruid, &euid, &suid);
    printf("Result of setresuid(-1, -1, -1):\n\t%u %u %u\n", euid, ruid, suid);
    setresuid(UINT_MAX, UINT_MAX, UINT_MAX);
    getresuid(&ruid, &euid, &suid);
    printf("Result of setresuid(UINT_MAX, UINT_MAX, UINT_MAX):\n\t%u %u %u\n", euid, ruid, suid);
}

Output:
(uid_t x = -1) == (uid_t UINT_MAX)
printf uid_t -1 with %u:<PHONE_NUMBER>
printf UINT_MAX with %u:<PHONE_NUMBER>
Result of setresuid(-1, -1, -1):
        1000 1000 1000
Result of setresuid(UINT_MAX, UINT_MAX, UINT_MAX):
        1000 1000 1000

I'm out of my element w.r.t. platform-specific behavior and whether this cause problems on different architecture, so I'd appreciate help/feedback in that regard.
Solves https://github.com/nix-rust/nix/issues/931

Is this better?

Better, but not there yet. Also, have you figured out how to write a test?

Does it sound like a bad idea to combine my getresuid/getresgid PR here and have a combined test like:
orig_values = getresuid()
setresuid(None, None, None)
new_values = getresuid()
assert_eq(orig_values, new_values)

To me this seems like a safe way to test both functions without making assumptions on the running user's uid/etc.

I generalized the PR to "*resuid improvements" and closed the other one. I will work on the docs.

I'm wondering if we can't do a better API than this, but I'm not certain how this API is used in practice. Is it actually common to actually work with all 3 uid/gid value? Or is it more common to change just 1 or 2 of them? I'm thinking that breaking up these functions to separate getters and setters might be more ergonomic.
The main reason I'm thinking about this is because I don't like the signature of getres*id(). C returns things through pointers, but in Rust it's preferably to return things by value. But if you do that, you have a 3-tuple. Which I'm not a big fan of either. It almost seems like were should have some methods on a Process struct where you can get and set these values as they apply to the calling process. I'm not certain it makes sense to go that far, but I'm sure other APIs could work within that framework.

I definitely agree that this is painful to type:
let mut rgid2 = Gid::from_raw(0);
let mut egid2 = Gid::from_raw(0);
let mut sgid2 = Gid::from_raw(0);

let _r3 = getresgid(&mut rgid2, &mut egid2, &mut sgid2);

I don't know if the nix-rust philosophy is to replicate C function signatures, or that if things deserve to be changed then they should be changed - I'll leave it up to the maintainers to decide.

It will need to be changed to returning a 3-tuple at a minimum. I'm just wondering if going a little bit further with the abstraction would be worth it. @asomers any opinion here?

The documentation strings for setresuid and setresgid have been incorrect since 2016  (https://github.com/nix-rust/nix/commit/6c85f437c1df07a27e9e60c25c1322e9effc3a04); my corrections being scrutinized is interesting. I'd rather just drop my doc commits in that case.

I think a 3-tuple would be ok, or it would be ok to return a struct RESuid with ruid, euid, and suid getters.  I don't think we should return a Process that has more interfaces than just setresuid and setresgid.  I like to keep Nix as close as possible to libc, while still being Rusty.

I'll work on that.

I think in practise I am preferring the 3-tuple. Introducing a struct RESuid somehow compels me to include that into setres*id which ends up being ugly with the Option<Uid>.

On second thought, since you two want to talk past me and to each other, go ahead and implement it yourselves.


Mod path access through Mod Organizer 2

Bug
Some CET mods accessing files from other mods do not always work with MO2.
Probable causes

PR #877 introduced a fix/workaround for MO2, which handles path resolution differently when MOs USVFS is detected: code for overwrite path.
The issue is that MO overlays multiple mod paths, which cannot always be identified just by the path directly.

as seen in the CET/CyberScript log below with the related code lines: dir("datapack") works, but io.open("datapack/.../desc.json")does not.

Game version: Cyberpunk v2.01
CET version: 1.27.1
Suggested solution

Use relative paths (instead of resolving to absolute) as long as they are within the mods sub folders.
(Or at least add handle also mods/*/bin/x64 as a "special" MO path, although these paths can be configured differently in MO)
Patch also io.open etc. (similar to dir) to handle file access correctly

Reproduction

MO 2 beta 13 (with optional cyberpunk plugin update v2+)
CET v1.27+ installed directly into game dir

Mods (clear overwrite before each mod test):

mod Citizen Voices and NCPD Radio Chatter + dependencies (except for CET) installed via MO[12236] CyberScript Assets Loaded
[12236] No DESC FOR ..\..\..\..\..\..\..\..\Citizen Voices and NCPD Radio Chatter\bin\x64\plugins\cyber_engine_tweaks\mods\cyberscript\datapack\Citizen Voices
[12236] Can't load ..\..\..\..\..\..\..\..\Citizen Voices and NCPD Radio Chatter\bin\x64\plugins\cyber_engine_tweaks\mods\cyberscript\datapack\Citizen Voices from the cache :
| jsondesc is not null : false
| datapack have required flag: false
| datapack is null : true

Appearance Menu Mod + V's Original ApartmentPLUS (preset):

with AMM in load order before preset (AMM prio < preset): preset does not show up
preset before AMM (preset prio > AMM): preset does show up
expected: preset should always be shown

All mods in overwrite: work

Can confirm that Appearance Change Unlocker seems to also be affected by this with loading its preset files from anywhere but the overwrite. Accessing the presets from overwrite works.

on it

@Drakonas I can't reproduce the problem with ACU. I have a new preset in a new mod in MO2 (and the same preset not in overwrite) and it loads it fine

@ZashIn and regarding "Citizen Voices and NCPD Radio Chatter" - this mod is outdated and doesn't seem to work anymore? It (together with cyberscript) tries to call really weird paths like user/cache/..\..\..\..\..\..\..\..\Citizen Voices and NCPD Radio Chatter\bin\x64\plugins\cyber_engine_tweaks\mods\cyberscript\datapack\Citizen Voices.lua

a) that file doesn't exist anywhere
and b) this would resolve to F:\games\Cyberpunk 2077\Citizen Voices and NCPD Radio Chatter\bin\x64\plugins\cyber_engine_tweaks\mods\cyberscript\datapack\Citizen Voices.lua which is all kinds of wrong.

I don't think there is an issue here (the mod is just broken)

I found the issue: the sbRootpath under usvf can have 3 locations:

the game
overwrite
the mod install path

With mods that add to other mods the root path is the initial mod's root . An AMM pose pack mod for example adds files to /amm/poses but /amm/poses resolves to overwrite/amm/poses and should resolve to mod/amm/poses instead (since we're interested in the mod's additions and not AMM).
Specifically, the problem arises if the mod uses dir() in lua which returns an iterator for files. e.g.:
local files = dir(inDir)
for _, file in ipairs(files) do
    local dir2 = dir(file.name)
end

under uvfs file.name is a relative path to the mod's install dir (e.g. ..\..\..\..\..\..\..\..\..\Pose Pack\bin\x64\plugins\cyber_engine_tweaks\mods\AppearanceMenuMod\Collabs\Custom Poses\posepack) and not a simple filename (posepack).
There is no good and easy solution for that from the CET side but it can be easily resolved from the mod's lua side:
function extractFileName(path)
    local parts = {}
    for part in string.gmatch(path, "([^\\]+)") do
        table.insert(parts, part)
    end
    return parts[#parts]
end

local files = dir(inDir)
for _, file in ipairs(files) do
    local dir2 = dir(extractFileName(file.name))
end

I suggest closing this issue and fix it in the mods themselves for now.

https://github.com/MaximiliumM/appearancemenumod/pull/38

It seems that the following line causes the file.name issue:
https://github.com/maximegmd/CyberEngineTweaks/blob/fbfe95b073d69c96f108b933c8543cba6b242095/src/scripting/LuaSandbox.cpp#L510
I do not know what the intended API is here, but file.name does not return the name, but the relative path here, which not always the same (VFS, probably symlinks etc). A file.path vs file.name would make the distinction clear.
So my suggestion (with limited C++ knowledge) is to change the above line to
item["name"] = UTF16ToUTF8(entry.path().filename);

And optional add something like
item["relativePath"] = UTF16ToUTF8(relative(entry.path(), path).native());

Although the latter would have the same issues as before.

That change was there for a long time, basically from the beginning of the sandbox so nearly 2 years... It is sort of custom replacement of an existing dir() lua command, it should return a table with name and a type.
I believe that when I originally made it, original Lua command was returning absolute paths, but cannot find anything on the internet now about this and cannot test it...
Our version was returning "absolute" paths also, just relative to mod folder due to sandbox limitations.
If this changes, it may have consequences elsewhere where someone counts on this behavior.
We agreed with @rfuzzo to make this breaking change, but as part of separate fix. Shouldnt be mixed together, they are two separate issues Id say.

Im unsure if this is even an error, it may well be  mod error in this case.

I would rather double-check exact behavior of unmodified dir command again and do the change then based on that if it is required. Either in the mod or in the CET.
We do not return iterators etc. like original did but the resulting table you'll get from the array in for loop should be about the same.


preSignUp trigger is failing with default code

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v15.5.1
Amplify CLI Version
6.3.0
What operating system are you using?
Mac
Amplify Categories
auth
Amplify Commands
update
Describe the bug
I added a lambda trigger for preSignUp through amplify update auth. All the boiler plate was generated correctly, I wen't ahead and did a amplify push and all changes wen't through as expected, however when I try to add a user I get an invocation error:
PreSignUp failed with error callback is not a function. (Service: AWSCognitoIdentityProviderService; Status Code: 400; Error Code: UserLambdaValidationException; Request ID: cce25d95-1cce-4541-b674-5ab08e6b0f5f; Proxy: null)
Expected behavior
That the trigger would work out-of-the-box.
Reproduction steps

Add auth
Add lambda trigger for preSignUp through wizard
Push

GraphQL schema(s)

# Put schemas below this line

Log output

2021-10-20T18:11:39.063Z	b0145221-ba5d-4d31-b631-331e7447621c	ERROR	Invoke Error
{
    "errorType": "TypeError",
    "errorMessage": "callback is not a function",
    "stack": [
        "TypeError: callback is not a function",
        "    at Object.exports.handler (/var/task/custom.js:5:3)",
        "    at /var/task/index.js:37:50",
        "    at Array.map (<anonymous>)",
        "    at Runtime.exports.handler (/var/task/index.js:37:29)",
        "    at Runtime.handleOnce (/var/runtime/Runtime.js:66:25)"
    ]
}

Additional information
No response

I was able to narrow it down the module code which was generated automatically in index.js. If I replace the source in index.js with the source from custom.js the problem is solved.

@josefaidt I'm sorry, it's not clear to me how the issue was documented or resolved in the linked bug report. What is ultimately the fix here? I'm running into precisely the same issue.


how to sort CSV Input by some columns ?

I have browsed through docs and did not find it, any link please ?

There isn't a sorting task, but there's a ton of ways you could do it.
You could do it via one of the scripting components in the language of your choice.  Groovy, Ruby, Python, Javascript, etc...
Or by far, the easiest way would be to drop in the "Create Jdbc Database" component.  Take it's defaults.  It'll default to an in-memory, hyperSQL database.  It'll call the table CSV by default.
Then drop in a "Query Jdbc Database" component and do a
SELECT * FROM CSV ORDER BY <COLUMN_NAME> DESC;
or ascending, depending on what you want.
The in-memory db really comes in handy when it comes to some quick and dirty data manipulation.

Pat


Added play and download button on hovering over the movie image

Issue Number
ISSUE #10
fixes #
Describe the changes you've made
I have added the Play and Download button When hovering over the movie card. The buttons only show when visitors hover over the movie card image. I have also decreased some opacity of the image so that it looks more attractive. The changes are done on the kids and web series page also.
Describe if there is any unusual behavior of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)

Checklist

[x] I have added my name to the contributor's list at the end of the README.md file.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.
[x] Open Source Program names-LGM-SOC

Resolve conflicts.
And too many additions and deletions in your PR.
First, update your repo then make PR.

@QAZIMAAZARSHAD There is no conflict when I created that pull request. It also shows "able to merge".
And too many addition and deletion are because I have to add the same 4 lines of code on every page and on every movie card for that effect. That's why it happens.
What should I do now?

@QAZIMAAZARSHAD There is no conflict when I created that pull request. It also shows "able to merge".
And too many addition and deletion are because I have to add the same 4 lines of code on every page and on every movie card for that effect. That's why it happens.
What should I do now?

Your PR had conflicts. Create a new PR.
Also, I was talking about unnecessary additions and deletions that may be due to indentation, but it becomes very difficult to review so try to resolve that as well. Update your repo. Then make a new PR.


[libyaml] Fix linkage in non-Windows systems

Fixes issue #10789.

@Cheney-W Fixed!

Thanks for the PR!


How to use webpack-dev-middleware with express, koa, hapi

After speaking with @pdjota at ngVikings, it turns out we don't have any documentation for using webpack-dev-middleware with express.
@SpaceK33z Do you have any docs hidden anywhere already? Otherwise, we can leave this as low hanging fruit for a first time contributor.

There are docs on the repo, https://github.com/webpack/webpack-dev-middleware/

I could get my hands on it. Usually, I am using it like this: https://github.com/kbariotis/gityeller/blob/master/server.js#L26. Would that be a good example?

Closing for a few reasons...

Inactive for a while now.
Hasn't seen too much activity/popularity.
Keep the focus on #1258 and review other top-level sections before jumping into more guides.
Another instance of third-party docs before our core docs our fully ironed out.

With all that said...

I'm marking this with a new Reconsider label, so in the event that someone wants to dig this back up they (or anything else marked Reconsider), we can.
If someone wants to pick this up and has the time to really follow through with a PR, please feel free to re-open.

I think a better start for this may be adding some examples to the webpack-dev-middleware README if they don't already exist. At some point maybe we can create a Utilities section similar to Loaders and Plugins that contains packages like this that don't really fit into the latter two. For example:

webpack-dev-server
webpack-dev-middleware
enhanced-resolve
and there's definitely a whole bunch of others I've seen...


Service worker tweaks

Hi @hankchizljaw,
I've been testing out the service worker implementation in Hylia and noticed some opportunity for minor improvements, if you're interested:

Serve an 'offline' page (from the pre-cache) if the user attempts to navigate while offline.
Rebuild 11ty when src/_includes/partials/global/service-worker.js is updated.
Exclude browser sync requests from the runtime cache (removes 'noise' from if you are testing on http://localhost / ngrok).

I've created a service-worker branch in my fork of Hylia with commits that address each of the above bullet points:
https://github.com/zplume/hylia/commits/service-worker
Would you be interested in a PR containing the above?
Thanks!

Yes please, that would be great!


feat: 🎸 add emojione v2.2.7 icon set

:tada: This PR is included in version 2.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Input & output node names

Hi, thank you for the great work!
I intend to modify the code and run it using the tf.Session equivalent in Tensorflow C++ API.
From the function compute_local in model.py, I see that the pointcloud input for the input dict is points, which is derived from
points = tf.concat(pcdset, 0, name='pointclouds')

in the function build_graph.
However, when I import the meta graph and list the nodes, I am unable to find any node named pointclouds.
May I know how I can access it and similarly the output node names when I run my session? Apologies if my description sounds confusing as I am quite new to this.

Hi, what's your output of the node list specifically?

The link to the text file containing the node list is here (not posting directly as it's quite long)
This is the code I'm running to generate the node list:
with tf.Session(graph=tf.Graph()) as sess:
        # Restore local model
        loader = tf.compat.v1.train.import_meta_graph(
            trained_checkpoint_prefix + ".meta"
        )
        loader.restore(sess, trained_checkpoint_prefix)

        graph_def = tf.get_default_graph().as_graph_def()

        # All nodes to list
        node_list = [n.name for n in graph_def.node]

Then "pointcloud" exists as a tensor instead of a node in the graph. That's why it does not appear in your node list.
It is not obvious to me what you are going to do with tf.Session, but it's not a proper way to run inference with a model restored from the metagraph as said in this link.
In our evaluation scripts, we use OfflinePreditor from tensorpack to do offline inference: https://github.com/JuanDuGit/DH3D/blob/b1ec580a8f24697559ea497d875f657387d0f112/evaluate/local_eval/localdesc_extract.py#L81
You can refer to its docs for details on how it builds a graph and creates a session, etc .


R.curry slows down resulting function way too much

Altering @niloy's test on #1500, I found out that R.curry has a dramatic influence on performance, even when the result curried function is called with all of the arguments at once:
var arr = R.times(Math.random, 20000);

console.time("Object.is");
R.uniqWith(Object.is, arr);
console.timeEnd("Object.is");

console.time("R.curry(Object.is)");
R.uniqWith(R.curry(Object.is), arr);
console.timeEnd("R.curry(Object.is)");

results in latest Firefox nightlty:
Object.is: timer started repl.js line 123 > eval:2
Object.is: 276.76ms repl.js line 123 > eval:4
R.curry(Object.is): timer started repl.js line 123 > eval:5
R.curry(Object.is): 68341.41ms

REPL link (remove throw 1 and get some coffee): http://bit.ly/1MPu10K

Why you curry it every time before calling? Try to save result function before :)

I don't curry it each time... the expression is evaluated right away, i.e. before it's passed to R.uniqWith. It makes no difference if you set in on a variable.

I see. just deleted the comment.

Sigh, I just realized the same benchmark was done independently on #1449

Yeah, that issue is a starting point to think about (maybe) some compromises between reference and value equity. Looks, like sometimes it isn't necessary to compare values. But I'm going to deeply learn that thread.

Some improvements to the currying functions when dealing with primitive arguments in #1512 have just landed in master which will give this a slight improvement.
Using an arr size of 5000 in the example above results in:
Object.is: timer started
Object.is: 140.62ms
R.curry(Object.is): timer started
R.curry(Object.is): 1081.84ms

Unfortunately, while support for placeholders exist in the currying functions there will continue to be a slight hit in performance. On a positive note, using R.uniq from the current HEAD of master for the above example now results in:
R.uniq: timer started
R.uniq: 2.54ms

we could probably get a further boost by setting properties on the function returned from curry* and doing the bookkeeping there (i.e. what args have we seen so far, placeholder (yuk), current arity). the problem with that approach is it blows away the returned function's length property, which would be handled by the function's metadata. in case external consumers are looking for length, i think as long as we provide a way to set arity on a function on the way out of ramda-world, this approach is acceptable.

I think that setting some sort of meta-data on curried functions is necessary anyway (see #1483). How does it affect the function arity though?

How does it affect the function arity

i'm suggesting that instead of returning a new function as arguments are applied, we keep returning the same function with its metadata updated.
incidentally, metadata would be a good place to keep typing information.

@asaf-romano:
I don't think #1483 is really soluble, except by adding an additional composition function.  Breaking this:
> R.compose(R.map, R.add)(10)([1, 2, 3])
[ 11, 12, 13 ]

is just too painful.  But if we automatically curry the result of compose, then this is broken, and unrecoverable.  As it stands, the user can simply call curryN on the output as necessary.

@buzzdecafe:

i'm suggesting that instead of returning a new function as arguments are applied, we keep returning the same function with its metadata updated.

Mutation of the function object?  I can't see that.  How could a user then use both the before and after versions of such a function or partially apply two different values to it?
But needing to return different functions might give a way to retain the arity at the same time.  It's worth considering.  But perhaps I'm the only one that has that concern.


feat!: move to ESM first with dual ESM/CJS subpackage exports

Related Issues or Discussions
Talk with Kato and Moha in discord.
Summary
Move to ESM first and include subpackage exports.
This PR also includes:

now using rollup-plugin-dts  instead typescript to generate dts files
remove useProxy from src/macro.ts module and patch the d.ts and d.cts files
change build to run build:all: now we can generate multiples outputs (d.mts, d.cts and d.ts) and also the ts3.4 version, we need to play with the target and maybe lib to fix ts3.4
ts3.4 now inside dist folder: we should include only dist in files (package.json)
postbuildnow includes only yarn copy, I've left old xpostbuild, we should remove it later
copy script now copy src and esm from root, I've left old xcopy, we should remove it later: why copying src folder to remove it in the next script?

Check List

[x] yarn run prettier for formatting code and docs

I can send another pr using commonjs to v2 branch (this PR should be closed)

Sounds good. This PR introduces too many changes and can't even see if there are breaking changes or not. I'm pretty sure it breaks some old environments.
I would appreciate if you can send small PRs. For example: #882 (well, it's exceptionally small.)

small PRs

At least, we should separate for different issues: a) fix the result in dist and b) fix for tests, which may depend on a).


EPIX 2 East

Source
https://www.tvpassport.com/tv-listings/stations/epix2-east/11485
Notes
No response

Is it on iptv-org.github.io/epg/guides/us/directv.com.epg.xml.gz ? It didnt show on my tv guide.

"Epix 2 East" renamed to "Epix 2" (#1264)
https://iptv-org.github.io/epg/guides/us/directv.com.epg.xml.gz

Please check it again and this link is correct:
https://www.tvpassport.com/tv-listings/stations/epix2-east/11485
My guide said The Amazing Spider Man 2 and its wrong because this tv showing is actually:
Sky Captain and the World of Tomorrow (2004)

Great. It works. Thanks!

Please fix it. Its not working properly.

At the moment, everything is working fine:
https://iptv-org.github.io/epg/guides/us/tvpassport.com.epg.xml.gz


Site Logo and Cards

Wanted: A logo design that can help create an identify for the website. Something that fits with the color scheme is preferred.
I'd also want to see if generic cards can be designed for social media platforms. So sharing the Alpine Linux page gets you a social card with the alpine logo alongside endoflife.date logo.
Do these cards support SVG format that we can generate using Jekyll?

yes please :pray:

For the twitter card the jekyll-seo-tag plugin may already handle it (https://maxchadwick.xyz/blog/twitter-cards-for-jekyll-with-jekyll-seo-tag).
As you can see at the end of the documentation, only one image can be added on a given page. Having two images does not seem possible, but that's something that can be tested anyway.
If I read the doc correctly the SVG format is not supported : see https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image.

Reopened: automatically closed by #1900 .

A preview with the new logo can be seen on https://renderform.io/tools/twitter-card-preview-tool/ :

Still not perfect, but better than what it was before:

I'd also want to see if generic cards can be designed for social media platforms. So sharing the Alpine Linux page gets you a social card with the alpine logo alongside endoflife.date logo. Do these cards support SVG format that we can generate using Jekyll?

SVG is not supported on twitter cards, but it should be possible to generate a cover with both endoflife logo and the product logo similar to what you shared on https://github.com/endoflife-date/endoflife.date/issues/978#issuecomment-1331855002 :

https://github.com/endoflife-date/endoflife.date/issues/2007 provide some information about Open Graph, worth a look for anybody wanting to work on this.

Should we close this issue ?

yeah, this is partially solved. I'll create a new issue for just the opengraph card images with some clear context.


Release 0.1.13 is not on pypi

Release 0.1.13 is not on pypi: https://pypi.org/project/petab-select/#history

And there aren't any releases/tags on GitHub

With 0.2.0 now as a proper github/zenodo/pypi release, it's fine for me to close this.


Fix for #448

The method kAudioUnitProperty_AudioChannelLayout used to retrieve the channel layout wasn't introduced until 10.12. So we use kAudioDevicePropertyPreferredChannelLayout instead should it fails.
Fixes #448

Indeed, oops...
thanks for spotting that dumb mistake


Logout previous sessions

Related Issues
https://github.com/descope/etc/issues/8242
Description
Logout previous sessions
Must

[x] Tests
[ ] Documentation (if applicable)

@omercnet can you check why the CodeQL fails? Do we need it?


Page transitions

How best to add animations between pages using Backbone Marionette.
See here for details: https://github.com/jmeas/marionette.transition-region
See also:

https://github.com/marcinkrysiak1979/marionette.showAnimated
http://stackoverflow.com/questions/15603141/backbone-marionette-ios-style-page-transitions
http://marionettejs.com/docs/marionette.region.html

Added page transitions using: https://github.com/marcinkrysiak1979/marionette.showAnimated
Problems with Tweenmax overriding inline styles, cleared up in most cases using clearProps:"all":
http://stackoverflow.com/questions/21978416/clear-an-inline-style-which-is-set-by-a-gsap-animation
except for the connect posts - which I haven't animated in.
Also posting this animation visualiser for reference: http://greensock.com/ease-visualizer
Closing this issue.


styling the selectText prop

how do we style the selectText prop? currently, mine is cutoff and the padding or height of the select dropdown is too short.

me too

There is a property for that: styleTextDropdown and styleTextDropdownSelected. Test those properties.


Introduced VerticalGridAdapter

Lots of code was able to be eliminated.
Next step is to see if make_extension can be lifted out of
StateItemSpec classes entirely.

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[x] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description
Introduced a new Adapter to eliminate the last vestiges of old logic for creating extensions.  Even more code was then deleted.
Related Issue

Skipping CI after rebase.


Add Top 100 contribor on readme.md file

Is your feature request related to a problem? Please describe.
No, It will just look good for contributor
Describe the solution you'd like
I will use like for contributor link
Describe alternatives you've considered
NA
Additional context
No response

I don't see a need to do this. Such a list would become frequently out of date, and its already viewable here:
https://github.com/freeCodeCamp/freeCodeCamp/graphs/contributors

I know that but it's look nice in contributor section like I have added this idea in this repo
https://github.com/spotDL/spotify-downloader/tree/dev

ok then I should close this issue


Add HeightMapShape mesh in CollisionShape gizmo

Closes #28951.

Thanks!

Cherry-picked for 3.1.2.

Cherrypick undone as it depends on some other PR which is not cherry-picked (#27219).


Cannot read property 'exclude' of undefined

I use react-app-rewire-less with following error:
  fileLoader.exclude.push(lessExtension);
            ^
TypeError: Cannot read property 'exclude' of undefined

I try to downgrade the version of react-scripts from 1.0.15 to 1.0.14,  And it works well.
"react-app-rewired": "^1.3.4"
"react-app-rewire-less": "^2.0.7"
"react-app-rewire-typescript": "^1.0.4"

There was a PR not for this issue but,  if can you update to the latest and see if that fixes the problem<EMAIL_ADDRESS>that would be great.

Might fix it but there is some other issue with new react-scripts version and react-app-rewire-less, the override config is not passed correctly to the less loader anymore
function createRewireLess(lessLoaderOptions = {}) {
  return function(config, env) {
  }
}
const rewireLess = createRewireLess();

rewireLess.withLoaderOptions = createRewireLess;

module.exports = rewireLess;

can be replaced with (or?)
function rewireLess(config, env, lessLoaderOptions = {}) {
}
module.exports = rewireLess;

@varHarrie FYI - version is now @ 2.1.0 is this still an issue or can we close it?

There was no error any more after upgraded to latest version, thanks.


Formatter fails to format named tuple with a string key and a extra whitespace

$ cat test.cr
p typeof({"a" : 1}) # notice a whitespace between string literal and a semicolon

$ crystal test.cr
NamedTuple(a: Int32)

$ crystal tool format test.cr
Error:, couldn't format './test.cr', please report a bug including the contents of it: https://github.com/crystal-lang/crystal/issues

Formatter works ok on {"a": 1} (no whitespace)

Hm, I'm not sure the first one should parse OK. The space there isn't supposed to be optional.

So is it a bug (need fix) ? Or does it stays like that (close issue) ?


Added DDI valdiation suport

Added DDI validation support requested in the following issue: https://github.com/muriloalvesdev/thehero-backend/issues/49

:rocket:

:rocket:


Do libaco coroutines run on different CPUs at the same time. i.e. does the program performance benefit from having multiple CPUs

Do libaco coroutines run on different CPUs at the same time. i.e. does the program performance benefit from having multiple CPUs? Or do coroutines run on only one CPU at any given point of time. In that case, libaco could used in conjunction to a standard threading library I guess...

Do libaco coroutines run on different CPUs at the same time. i.e. does the program performance benefit from having multiple CPUs?

Nope. At least not yet.

Or do coroutines run on only one CPU at any given point of time. In that case, libaco could used in conjunction to a standard threading library I guess...

Yes.
libaco currently is only a C coroutine library and has no feature-rich scheduler yet.

Hi there! I just wish to extend on @hnes answer and elaborate a bit, coroutines are not thread or parallel processes. They allow "routines" to be executed concurrently for example, say you have two coroutines, the programmer can have the freedom to run some parts of the first one followed by some parts of the second one then finish the first one later etc. I recommand the following readings for more information: https://stackoverflow.com/questions/1934715/difference-between-a-coroutine-and-a-thread and https://stackoverflow.com/questions/7224625/what-are-the-benefits-of-coroutines.


No Error message o user notification for Duplicate append test case to TDML file

TDML Append Functionality - if you are trying to add a duplicate, there is no error message letting the user know that's why nothing happened

Code exists in tdmlXmlUtlis.tx to detect this error. It throws an exception, but this only shows up in the debug window when debugging the extension itself.
Note that the same method is used for other errors which will probably need to be fixed as well:
throw No test suite found in source XML buffer
throw More than one test suite found in source XML buffer
throw No test case found in source XML buffer
throw More than one test case found in source XML buffer
throw No test suites found in destination XML buffer
throw More than one test suite found in destination XML buffer
throw Duplicate Test Case Name Found

Pop-up window appears in bottom right corner of VSCode window


NoUnusedImportsFixer - remove SF exception

This should be handled in the configuration of the SF project itself, not at this location anymore.

Thank you @SpacePossum.


Update domain-driven-design.md

typo fix

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


metadata lib internal methods are excluded from docs

To add to this. I know it would be a breaking change but this is still pre-release so;
Would it make sense to re-name internal to something more self-documenting? Like maybe just MedadataEditor?
I personally find 'Internal' to be ironic for the name of an externally exposed Api, but that's obviously just an opinion, no negativity meant! I'm just hoping to avoid the confusion I had in the future!
Thanks for reading!

Internal holds methods that the API uses internally. The methods that we expect a plugin to use are within https://github.com/OPD-libs/OPD-libs/blob/main/libs/OPD-metadata-lib/src/API.ts

Oh! Interesting, thanks so much for clarifying!
Just to share what I assumed; It looked like internal was coded more like an API i'd use but was named property for me to avoid it, and the function list felt a bit like the hidden internals.
I definitely get it now, I think a small comment somewhere in the Internal file or in the docs to say what that's for would definitely be enough to clear similar issues up just like you suggested earlier. Thanks again!


Add OpenDNS to internet check

Won't do.

OpenDNS makes no bones about the fact that it collects and saves DNS logs -- you're able to access your own logs as a feature of setting up a (paid) account

https://www.infoworld.com/article/2608352/internet-privacy-another-privacy-threat-dns-logging-and-how-to-avoid-it.html


netutils/usrsock_rpmsg:  Fix build failures

Summary
Not all files were correctly modified when usrsock_rpmsg was moved from apps/system to apps/netutils.  Changes were overlooked in the Makefile and Make.defs file.
Impact
Should correct the PR check system which is failing on this problem.
Testing

@patacongo thannks to fix my fault.


Enhance the token filter with "pass through" semantics

The token filter provided by this plugin is super useful on fields which only contain an URL. It would be even more useful if we could use it to analyze fields containing arbitrary text possibly with URLs in them (think user comments).
I suggest to add another option called pass_through to the URL Token Filter. If this option is set to true, the token filter would just pass the token through without any modifications instead of just rejecting the document. And allow_malformed would need to be true, I guess.
This would allow to use the url token filter and analyze a free-text user comment with URLs in them. For instance: the text bla bla http://www.google.com bla bla would be tokenized into (using whitespace tokenizer):

bla (not a URL, just pass through)
bla (not a URL, just pass through)
www.google.com
bla (not a URL, just pass through)
bla (not a URL, just pass through)

Even better, would be to also have the option to set tokenize_host on the token filter, so that the host would be further tokenized into:

www.google.com
google.com
com

Currently, if the url token filter is set up with part: whole and allow_malformed: true, it will stop tokenizing after the first token bla in my example above. The new option I'm suggesting would just tell the token filter to keep going with the other tokens.

Great suggestion.  I should have some time to work on it this weekend.

Awesome! Thank you for this great and promising plugin, I'm eager to leverage it on many use cases as soon as this is implemented! Thanks again.

I've released [v2.2.0|https://github.com/jlinn/elasticsearch-analysis-url/releases/tag/v2.2.0], which includes the passthrough option.  Let me know if you encounter any issues with it.

You rock!! It works very well. Thanks a lot!!

Awesome.  Glad to hear it.


updates to compile on latest nightly

There are still various deprecation warnings, but it compiles.
Also, once/if this gets merged I'll rebase and update #8

Hi!
Thanks, I had some local changes and did an update to master myself in parallel with this, so this may not be needed now.
I gave up on trying to upgrade to stable this time around, as some of the APIs we use still seem to be unstable. Seems that this project hits a lot of API surface after all :-) Maybe next time.
Please rebase, and see if the current master suffice.

I'm closing this pull request. I did eventually get up to nightly, but not on stable.
Thanks for the effort anyway, and sorry it did not merge well (which wasn't your fault).


EDIT comment not working

This may be due to newer versions of Visual Studio, but it appears that the "EDIT" comment support isn't working anymore. In Visual Studio 2022 (running community edition, and haven't tested this in any other versions or editions), comments are stored in the regex XML as all lowercase, so the Contains("EDIT") calls always return false.
This affects the following call sites:
https://github.com/stevencohn/ResxTranslator/blob/725492d1c7b75cca136c37ec1d64ff53f9169947/Translator.cs#L358
https://github.com/stevencohn/ResxTranslator/blob/725492d1c7b75cca136c37ec1d64ff53f9169947/Translator.cs#L481
and may also affect the REGEX at https://github.com/stevencohn/ResxTranslator/blob/725492d1c7b75cca136c37ec1d64ff53f9169947/Translator.cs#L468
If you retarget this to .NET 5.0+, you can use an overload on Contains that takes a StringComparison parameter.

Sorry I just saw this. I keep VS updated and haven't seen this but I'll take a look. Thanks


Voice: explore voice command activation (such as Hey Code)

We can explore to optionally enable voice activation, such as Hey Code or Hey <Agent> to turn into transcription mode.

A new setting accessibility.voice.keywordActivation via https://github.com/microsoft/vscode/pull/202643


Add header description to e2doc

Very minor change to e2doc and e2descriptions that makes it so you can have more text than just function descriptions in the generated documentation. An example output is provided in the wiki.
Part of my plans to improve the documentation.
I was unsure how to store the description so I figured reserving identifiers starting with _doc_ surely couldn't be the worst way.
This can, of course, be changed if it causes problems.

I don't think it should be stored like this, E2Helper.Descriptions is meant to be used for functions, and seen in game.
I think the better way to go about reworking the documentation is this way:

Delete these autogenerated wiki pages. They just bloat actual handwritten pages.
Make a website similar to StarfallEx's to display documentation better: https://thegrb93.github.io/StarfallEx/
Rework documentation of e2functions to be from e2function attributes

e.g.
[doc = "This function does xyz"]
e2function test()

end

Also, extensions already have descriptions, given by E2Lib.registerExtension. You could make datasignals an extension (enabled by default) and have the description in there, and then use these descriptions for the doc generator for now.


[11.0-stable] Bump Eden to 0.9.6

We already bumped Eden tests to 0.9.6 in 11.8, this commit bumps it in 11.0 stable branch

@uncleDecart eden tests do not seem to get triggered (the workflow does not even seem to appear in the list).

@milan-zededa merging magic went wrong, fixed it

Eden tests appear to be failing with
eclient lfedge/eden-eclient:b1c1de6 2cbd4a79-1c33-4ede-97f3-53c9f58c0b6c -:22 <IP_ADDRESS>:2223 0 B/0 B IN_CONFIG INSTALLED: [description:"failed to parse environment variable from cloud-init userdata: Variable "#cloud-config" not defined properly\nKey value pair should be delimited by "="" timestamp:{seconds:1709737368 nanos:66690152} severity:SEVERITY_ERROR]

Ah, I guess cloud-init wasn't ported into 11.0-stable, am I right @europaul ?

@eriknordmark shouldn't 11-stable be ahead of 11.3.0? If not we can bump eden to 0.9.3 instead of 0.9.6

@eriknordmark shouldn't 11-stable be ahead of 11.3.0? If not we can bump eden to 0.9.3 instead of 0.9.6

11.0-stable is 11.0, not 11.3+.


Solve trajectory projections using base year data

The current trajectory projection code looks at corp disclosures of typically recent era and projects the trends of up to five years of data.  For some companies, we only have 3 or 4 good years of data.  For many companies, the past 5 years produce trajectory projections that head up, not down, creating nonsense scores (as there's no way a company is going to be increasing projections at that rate for the next 30 years and the cumulative overshoot is just massive).
Many of those same companies with marginal gains over the past 5 years have made great progress since their "baseline" years (which go back much further: 2012, 2005, etc).  If we do a linear interpolation of the ancient base year to the first year of "real" report data, the historic intensity projections might make a lot more sense.
We have the base year data due to targets, and it should be straightforward to project into 2016, 2017, 2018, or wherever our data picks up.  It is a way to "fill the data gaps" given how difficult it is to find good disclosure data from 2014, 2015, etc.
Comments @LeylaJavadova @ImkeHorten @hmorgan29 @kmarinushkin

Hi Michael, sounds like a very good idea to me. Is this complex to implement?

I am a SW engineer, i am not the right person to ask.
I think, that methodologies should be specified by climate-change experts


[FEAT]: Add Function Calling Functionality to anything-llm

What would you like to see?
Description:
I am requesting the addition of function calling functionality within the anything-llm project. This feature will enable users to dynamically execute predefined functions or custom scripts based on specific triggers or commands processed by the language model.
Rationale:
Integrating function calling capabilities will significantly enhance the versatility and practical utility of the anything-llm project by allowing it to:

Automate Tasks: Execute automated workflows and repetitive tasks based on natural language commands.
Extend Capabilities: Interface with external systems, databases, or APIs to retrieve and manipulate data in real-time.
Interactive Applications: Develop more interactive applications where the language model can directly interact with the underlying system to perform complex operations.
Customization: Allow users to define custom functions that can be triggered by specific phrases or commands, enabling a highly personalized and powerful user experience.

Thank you for considering this feature request. I am eager to see how this functionality can further elevate the capabilities of the anything-llm project and am willing to contribute to the development and testing process.

Handled by custom agent skills
https://docs.anythingllm.com/agent/custom/introduction


No ES6 Map support?

If I run the following test program with msgpack-javascript 2.1.0:
import { encode, decode } from "@msgpack/msgpack"
const map = new Map()
map.set("a", 1)
map.set("b", 2)
map.set("c", 3)
const encoded = encode(map,{initialBufferSize:128})
const decoded = decode(encoded)
console.log({map, encoded, decoded})

The output is:

Conclusion: Asking msgpack-javascript to encode a Map causes it to encode it as if it were an empty object.
Supporting Maps in some capacity would be good because if anything it is better to store Maps in msgpack than to store objects. Sometimes deserializing in JavaScript can cause problems or even security flaws if keys overwrite "special" javascript objects like hasOwnProperty or __proto__. Here is an example of such a problem. I suspect msgpack-javascript itself will not have any such security flaws, but it is easy for client code to have such security flaws and the security issues can be sidestepped by using Maps instead of objects.

Thank you for your report.
This is the specification and won't be fixed because MessagePack is designed to communicate in multi-languages. I won't add any flavors by default.
However, any JavaScript programs use lots of non-primitive objects, so the MessagePack spec has extensions.
See extension types for details.
Also, I'd like to add extensions to handle non-primitive objects like ES2015's Map, just like as browsers do.

To concur with what @joshyrobot is saying, what we're looking for is not so much a way to encode maps in addition to objects, we're looking for a way to encode maps instead of objects— something like an alternate mode in which maps are always created and consumed and vanilla javascript objects are never created or consumed.


#355 Fix typos and rephrase Getting Started docs

Related issue
#355 Fix typos and rephrase Getting Started docs
Scope of work
This closes #355

Fixed typos,
rephrased some paragraphs,
minor formatting changes

Checklist

[X] I followed composition rules for my component (doesn't apply)
[X] I tested the component in most common device sizes (can be tested in Storybook from viewport addon in top menu)

Thank you very much! I would highly appreciate if you'd like to take a look at other docs and paraphrase them the same way. It's much better now!


Garbled characters when exporting to PNG format

Chinese fonts are displayed normally in HTML format. Garbled characters when exporting to PNG format.

Since Altair 5.2, the functionality of Altair Saver is now available in Altair via the vl-convert package. Most of the functionality has been available since 5.0, and the main addition in 5.2 was PDF export. See the docs on how to save charts for more details
We are going to archive this repo, so I'm closing all the open issues and PRs before doing so. Try out the new options for saving charts mentioned above and if you run into issues, please open an issue directly in the altair or vl-convert repo.


ServerSocket

Without an open network port our key value database can't accept connections from clients.

Should we use java ServerSocket or should we go with a library like netty?
What do you say about that @RobertMili

If your project requires advanced network communication features, it might be better to use Netty, but if it is a simple use case, you can use Java Server Sockets. @kappsegla :)


: Error allocating TSD

OS: OSX
Arch: arm/m2
Compiles successfully but I get this error when executing the binary: <jemalloc>: Error allocating TSD

I'm on an M2 macbook, and I don't see this error when running.  Perhaps this was fixed during a dependency upgrade in the past few months?


Minecraft Purpur version download 404 error

Enhancement Type
Improve an existing feature
Describe the enhancement
Hi, the Purpur version is giving the following error when downloading
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 2 1000 1000 4096 Jun 13 19:02 /data'
[init] Resolved version given LATEST into 1.20.1 and major version 1.20
[init] Resolving type given PURPUR
[mc-image-helper] 20:24:00.596 ERROR : 'get' command failed. Version is 1.30.1
me.itzg.helpers.get.RequestFailedException: Failed to download https://api.purpurmc.org/v2/purpur/1.20.1: status code: 404, reason phrase: Not Found
	at me.itzg.helpers.get.GetCommand.processSingleUri(GetCommand.java:442)
	at me.itzg.helpers.get.GetCommand.call(GetCommand.java:188)
	at me.itzg.helpers.get.GetCommand.call(GetCommand.java:55)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at me.itzg.helpers.McImageHelper.main(McImageHelper.java:145)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at me.itzg.helpers.McImageHelper.main(McImageHelper.java:145)
Caused by: org.apache.hc.client5.http.HttpResponseException: status code: 404, reason phrase: Not Found
	at org.apache.hc.client5.http.impl.classic.AbstractHttpClientResponseHandler.handleResponse(AbstractHttpClientResponseHandler.java:68)
	at me.itzg.helpers.http.LoggingResponseHandler.handleResponse(LoggingResponseHandler.java:20)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:247)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:188)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:162)
	at me.itzg.helpers.get.GetCommand.processSingleUri(GetCommand.java:440)
	... 11 common frames omitted
[init] ERROR: Failed to locate a Purpur build for 1.20.1.
[init]        Please check if a download is available at https://purpur.pl3x.net/downloads/

My docker compose file:
version: "3"

services:
  mc:
    image: itzg/minecraft-server
    container_name: "minecraftJS"
    ports:
      - 25565:25565
    environment:
      USE_AIKAR_FLAGS: true
      EULA: "TRUE"
      VERSION: LATEST
      TYPE: PURPUR
      ONLINE_MODE: false
      MEMORY: 2G
    tty: true
    stdin_open: true
    restart: unless-stopped
    volumes:
      # attach a directory relative to the directory containing this compose file
      - ./minecraft-data:/data

Not surprisingly, Purpur is running a little behind on their versions. They seem to have 1.20 out, but not yet 1.20.1.  For now you can set VERSION: "1.20".
I'll work on rewriting the download logic like I just did for Paper. In fact, it looks like Purpur's download API is compatible with PaperMC.

Thank you, setting the environment variable worked!


Script for manually running perf tests against DC/OS

This commit introduces the manual_run_dcos.sh that can be used to run
the performance tests against an already deployed DC/OS cluster.
Part of JIRA: DCOS-20295

@wavesoft, what is the state of this diff?

Key @jeschkies , for some reason your comments slipped through my e-mail filters 😄 I addressed your comments so it should be ready to merge.
I have used this script to run the tests on my local infrastructure, so the actual PR is not needed. I just thought it would be nice to have it on our toolbox.


[BUG] Linux crc dev preview unable to determine group membership

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Desktop

CRC version
CodeReady Containers version: 1.99.0+c9e2be01
OpenShift version: 4.9.10 (not embedded in executable)

CRC status
level=debug msg="CodeReady Containers version: 1.99.0+c9e2be01\n"
level=debug msg="OpenShift version: 4.9.10 (not embedded in executable)\n"
level=debug msg="Running 'crc status'"
level=debug msg="Checking file: /home/lars/.crc/machines/crc/.crc-exist"
level=debug msg="Checking file: /home/lars/.crc/machines/crc/.crc-exist"
level=debug msg="Found binary path at /home/lars/.crc/bin/crc-driver-libvirt"
level=debug msg="Launching plugin server for driver libvirt"
level=debug msg="Plugin server listening at address <IP_ADDRESS>:42257"
level=debug msg="() Calling .GetVersion"
level=debug msg="Using API Version 1"
level=debug msg="() Calling .SetConfigRaw"
level=debug msg="() Calling .GetMachineName"
level=debug msg="(crc) Calling .GetBundleName"
level=debug msg="(crc) Calling .GetState"
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"Getting current state...\""
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"Fetching VM...\""
level=debug msg="(crc) Calling .GetIP"
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"GetIP called for crc\""
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"Getting current state...\""
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"IP address: <IP_ADDRESS>\""
level=debug msg="(crc) Calling .GetIP"
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"GetIP called for crc\""
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"Getting current state...\""
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"IP address: <IP_ADDRESS>\""
level=debug msg="Running SSH command: df -B1 --output=size,used,target /sysroot | tail -1"
level=debug msg="Using ssh private keys: [/home/lars/.crc/machines/crc/id_ecdsa /home/lars/.crc/cache/crc_libvirt_4.9.10/id_ecdsa_crc]"
level=debug msg="SSH command results: err: <nil>, output:<PHONE_NUMBER>6<PHONE_NUMBER>0 /sysroot\n"
level=debug msg="Unexpected operator status for etcd: RecentBackup"
level=debug msg="Making call to close driver server"
level=debug msg="(crc) Calling .Close"
level=debug msg="Successfully made call to close driver server"
level=debug msg="Making call to close connection to plugin binary"
level=debug msg="(crc) DBG | time=\"2022-01-05T14:49:20-05:00\" level=debug msg=\"Closing plugin on server side\""
CRC VM:          Running
OpenShift:       Running (v4.9.10)
Podman:
Disk Usage:      25.75GB of 32.74GB (Inside the CRC VM)
Cache Usage:     15.65GB
Cache Directory: /home/lars/.crc/cache

CRC config
- consent-telemetry                     : yes
- pull-secret-file                      : /home/lars/.config/crc/pull-secret.txt
- skip-check-user-in-libvirt-group      : true

Host Operating System
NAME="Fedora Linux"
VERSION="35 (Workstation Edition)"
ID=fedora
VERSION_ID=35
VERSION_CODENAME=""
PLATFORM_ID="platform:f35"
PRETTY_NAME="Fedora Linux 35 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:35"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f35/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=35
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=35
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Steps to reproduce

Successfully run crc setup

Attempt to start crc with crc start

Watch crc fail with:
INFO Checking if user is part of libvirt group
WARN Preflight checks failed during `crc start`, please try to run `crc setup` first in case you haven't done so yet
Failed to get the groups user 'lars' belongs to

This appears to be caused by building crc with CGO_ENABLED=0. You
can reproduce the problem yourself with this code:
package main

import (
	"fmt"
	"log"
	"os/user"
)

func main() {
	currentUser, err := user.Current()
	if err != nil {
		log.Printf("user.Current() failed: %v", err)
		return
	}

	gids, err := currentUser.GroupIds()
	if err != nil {
		log.Printf("Failed to get the groups user '%s' belongs to", currentUser.Username)
		return
	}

	fmt.Printf("gids: %s\n", gids)
}

With CGO enabled:
$ CGO_ENABLED=1 go build
$ ./example
gids: [1000 10 18 999 983 135]

With CGO disabled:
$ CGO_ENABLED=0 go build
$ ./example
2022/01/05 15:15:59 Failed to get the groups user 'lars' belongs to

Logs
With --log-level debug, the relevant logs are:
INFO Checking if user is part of libvirt group
DEBU Checking if current user is part of the libvirt group
DEBU Failed to get the groups user 'lars' belongs to
WARN Preflight checks failed during `crc start`, please try to run `crc setup` first in case you haven't done so yet
Failed to get the groups user 'lars' belongs to

Awkward; we do this exact check:
https://github.com/code-ready/crc/blob/4c866b133cf77e5d4a85f9b390540b60e7998634/pkg/crc/preflight/preflight_checks_linux.go#L197-L222
as this exists since quite long on master. We do not specifically use CGO_ENABLED as we know the implications of this also. We compile as:
go install -ldflags="-X github.com/code-ready/crc/pkg/crc/version.crcVersion=1.37.0 -X github.com/code-ready/crc/pkg/crc/version.bundleVersion=4.9.11 -X github.com/code-ready/crc/pkg/crc/version.commitSha=23a4aaf1 "  ./cmd/crc

and this is the first time we see this report. We will have to investigate this a little more.

@larsks I have updated the release artifacts looks like the linux artifact on the release page was from a cross-build on non linux platform and which might caused this issue. https://cs.opensource.google/go/go/+/refs/tags/go1.17.5:src/os/user/lookup_stubs.go might be case which @cfergeau pointed out internal slack discussion.

I am closing this one since it happened because uploaded build done on non-linux platform and https://github.com/code-ready/crc/issues/2922#issuecomment-1006293418 explains.


Precreate handles on providers

This is part of my work to merge providers and handles.
Step 1 is fairly silly which is that each provider just creates a handle in advance and returns it during load, hydrating the handle rather than constructing a new object on the fly.

@prbot approve