Breaking change from 21.05 to 21.11: filesystem topology requirements

Describe the bug
I am running NixOS on a Digital Ocean droplet, which used nixos-in-place to turn a Debian machine into a NixOS machine. DO requires that the root of the filesystem still be a "normal" Debian distro, since it injects files in there for things like configuring network interfaces. To work around this, nixos-in-place installs NixOS to /nixos and then creates a bind mount on boot such that / becomes /nixos. This has worked for 5 years and 21.11 breaks it.
Note, this breakage was not noted in the release notes for 21.11. It may be unintentional.
Steps To Reproduce
This is the config which nixos-in-place creates:
{ config, pkgs, ... }:
{
  boot.kernelParams = ["boot.shell_on_fail"];
  boot.loader.grub.device = "/dev/vda";
  boot.loader.grub.storePath = "/nixos/nix/store";
  boot.initrd.supportedFilesystems = [ "ext4" ];
  boot.initrd.postDeviceCommands = ''
    mkdir -p /mnt-root/old-root ;
    mount -t ext4 /dev/vda1 /mnt-root/old-root ;
  '';
  fileSystems = {
    "/" = {
      device = "/old-root/nixos";
      fsType = "none";
      "options" = [ "bind" ];
    };
    "/old-root" = {
      device = "/dev/vda1";
      fsType = "ext4";
    };
  };

  ## Digital Ocean networking setup; manage interfaces manually
  networking.useDHCP = false;

  systemd.services.setup-network = {
    wantedBy = [ "multi-user.target" ];
    after = [ "network-pre.target" ];
    path = [ pkgs.gawk pkgs.iproute pkgs.openresolv ];
    serviceConfig = {
      ExecStart = "${pkgs.bash}/bin/bash /etc/nixos-in-place/setup-network";
    };
  };
}

When I try to upgrade to 21.11, I see this:
[root@nixums:/etc/nixos]# nix-channel --add https://nixos.org/channels/nixos-21.11-small nixos
[root@nixums:/etc/nixos]# nixos-rebuild switch --upgrade
...
building Nix...
building the system configuration...
error:
Failed assertions:
- The ‘fileSystems’ option can't be topologically sorted: mountpoint dependency path / -> /old-root loops to /

Depends
Note that I've found a recent change to add a depends attribute: https://github.com/NixOS/nixpkgs/pull/86967
I've tried adding that to the / mount, like so:
  fileSystems = {
    "/" = {
      device = "/old-root/nixos";
      fsType = "none";
      "options" = [ "bind" ];
      depends = [ "/old-root" ];
    };
    "/old-root" = {
      device = "/dev/vda1";
      fsType = "ext4";
    };
  };

It had no effect.
Expected behavior
I would expect this behavior to remain as it has for all previous versions.
Notify maintainers

Hard to say. The blame on this error shows it, and the surrounding code, is quite old: https://github.com/NixOS/nixpkgs/blame/0699530f08290f34c532beedd66046825d9756fa/nixos/modules/tasks/filesystems.nix#L230
Perhaps @dotlambda
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[root@nixums:/etc/nixos]# nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (49.20 MiB download, 227.57 MiB unpacked):
  /nix/store/12z1nc5fmif2z7wian28n55j61acbmny-glibc-2.33-59-dev
  /nix/store/1mhhdzc1x7z8xm0jqmgi0fisc9ibx9q8-bash-interactive-5.1-p8-info
  /nix/store/2ah5bynj7yb45vzqlga3dhvpi1lrawg4-glibc-2.33-59-bin
  /nix/store/79zvzq15mga6bgk5phnmw0fd2pnpim9v-bash-interactive-5.1-p8
  /nix/store/dzlbars3xgx3jh2hkldwavy0crkg328h-readline-8.1p0
  /nix/store/fh3cdchz3x43znd5sahi2fy0fz3pwqj9-expand-response-params
  /nix/store/gd7ihraqqpginv5cmhgk347nfn2iiqkj-bash-interactive-5.1-p8-dev
  /nix/store/gkzmfpb04ddb7phzj8g9sl6saxzprssg-gcc-wrapper-10.3.0
  /nix/store/jjv2lgwg9a5wg88xaa195fa47r6skfiz-ncurses-6.2
  /nix/store/k8qjik2a44ljdx48lmin2byz77ssrngk-stdenv-linux
  /nix/store/kb6iwp7acy1wibygx7phvpd24z2nqn03-bash-interactive-5.1-p8-man
  /nix/store/mrqrvina0lfgrvdzfyri7sw9vxy6pyms-gcc-10.3.0
  /nix/store/qypk3gzaf4p5bhzmyzjmlycs8v2sdw2h-nix-info
  /nix/store/rbqplhv2s539liymkvm3zbjj9lvgzpd5-binutils-2.35.2
  /nix/store/vafyy0lx82py8403bvkaki34i5bpin2n-linux-headers-5.14
  /nix/store/xa3xdjy1pifx8nwcxd75jmsx9n6jch97-bash-interactive-5.1-p8-doc
  /nix/store/z3fj7lv606mcdllhg0q7d98lpgc7b21z-binutils-wrapper-2.35.2
copying path '/nix/store/xa3xdjy1pifx8nwcxd75jmsx9n6jch97-bash-interactive-5.1-p8-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/1mhhdzc1x7z8xm0jqmgi0fisc9ibx9q8-bash-interactive-5.1-p8-info' from 'https://cache.nixos.org'...
copying path '/nix/store/kb6iwp7acy1wibygx7phvpd24z2nqn03-bash-interactive-5.1-p8-man' from 'https://cache.nixos.org'...
copying path '/nix/store/rbqplhv2s539liymkvm3zbjj9lvgzpd5-binutils-2.35.2' from 'https://cache.nixos.org'...
copying path '/nix/store/fh3cdchz3x43znd5sahi2fy0fz3pwqj9-expand-response-params' from 'https://cache.nixos.org'...
copying path '/nix/store/2ah5bynj7yb45vzqlga3dhvpi1lrawg4-glibc-2.33-59-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/vafyy0lx82py8403bvkaki34i5bpin2n-linux-headers-5.14' from 'https://cache.nixos.org'...
copying path '/nix/store/jjv2lgwg9a5wg88xaa195fa47r6skfiz-ncurses-6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/12z1nc5fmif2z7wian28n55j61acbmny-glibc-2.33-59-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/qypk3gzaf4p5bhzmyzjmlycs8v2sdw2h-nix-info' from 'https://cache.nixos.org'...
copying path '/nix/store/z3fj7lv606mcdllhg0q7d98lpgc7b21z-binutils-wrapper-2.35.2' from 'https://cache.nixos.org'...
copying path '/nix/store/mrqrvina0lfgrvdzfyri7sw9vxy6pyms-gcc-10.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/dzlbars3xgx3jh2hkldwavy0crkg328h-readline-8.1p0' from 'https://cache.nixos.org'...
copying path '/nix/store/gkzmfpb04ddb7phzj8g9sl6saxzprssg-gcc-wrapper-10.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/79zvzq15mga6bgk5phnmw0fd2pnpim9v-bash-interactive-5.1-p8' from 'https://cache.nixos.org'...
copying path '/nix/store/k8qjik2a44ljdx48lmin2byz77ssrngk-stdenv-linux' from 'https://cache.nixos.org'...
copying path '/nix/store/gd7ihraqqpginv5cmhgk347nfn2iiqkj-bash-interactive-5.1-p8-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.87, NixOS, 21.05.4666.7bca80140fc (Okapi)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.11.334917.e101dc111ac, unstable-21.11pre295280.fa0326ce523"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

perhaps this could be done with a postMountCommand in initrd?

This doesn't "fix" the breakage, but I think you'd be much better off making your / a tmpfs. This should also solve your core issue.

Update for you all here. Previously, @ztzg's solution was working for me, using 21.11. Now that I'm upgrading to 22.11, that snippet fails to build:
error: anonymous function at /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/../lib/utils.nix:1:1 called with unexpected argument 'system'

       at /etc/nixos/server/configuration.nix:23:12:

           22|
           23|   utils = (import (modulesPath + "/../lib/utils.nix") pkgs)
             |            ^
           24|     // { inherit fsBefore; };

       … while evaluating the attribute 'value.content'

I'm open to good long-term suggestions. Spinning up a new droplet is not going to be feasible, though. Any support would be much appreciated.

I have this working now. I'm using the following:
{ config, pkgs, ... }:
{
  ## Everything below is generated from nixos-in-place; modify with caution!
  boot.kernelParams = ["boot.shell_on_fail"];
  boot.loader.grub.device = "/dev/vda";
  boot.loader.grub.storePath = "/nixos/nix/store";
  boot.initrd.supportedFilesystems = [ "ext4" ];
  boot.initrd.postDeviceCommands = ''
    mkdir -p /mnt-root/old-root ;
    mount -t ext4 /dev/vda1 /mnt-root/old-root ;
  '';
  boot.initrd.postMountCommands = ''
    mount -t ext4 /dev/vda1 /old-root ;
  '';
  fileSystems = {
    "/" = {
      device = "/old-root/nixos";
      fsType = "none";
      "options" = [ "bind" ];
    };
  };
}

So, / still is a bind mount to /nixos. Then I manually mount in /old-root after that. Similar thing that was happening declaratively, but I can avoid that assertion. Thanks for the suggestion to use postMountCommands!
Still leaving this open, since it's an issue I think needs fixing.


Prettier error messages

Might already be done, should confirm with a variety of failure types:

[ ] Variable not declared
[ ] Parse error
[ ] Trying to recurse, when not in LetRec (same as Variable not declared?)
[ ] Trying to call value provided by tests (" xxx is not a function")

... and others?

First three are already done I think; fourth can't be done.


Added pipes graphic to 'for' documentation

I found the pipes graphics from Pipes.Tutorial really helpful. Do you think it would be overkill to add them to the documentation for pipes combinators as well? This patch includes just one example but I'll gladly make the rest if you think it's a good idea.

Yeah, definitely!  Only one minor nitpick: could you connect the b and b' in the first two like the examples from Pipes.Core (such as this one)?

Oh yeah! I forgot about those. How about the "simplified" functions ('for' vs. (//>)) are coupled with simplified diagrams, and a hyperlink to the more general one? I've updated the PR to show you what I mean.

That sounds like a good idea.  The only thing I'd suggest is omitting the x from the simplified diagram for for.

Even though it's part of the downstream flow? Just above the diagram are aliases to 'for' which include Pipe x b m r -> (b -> Pipe x c m ()) -> Pipe x c m r and others.

Never mind.  Keep it the way it is.  I realized that you were aiming for the most general unidirectional version.


fix show grants throw NullPointerException

Proposed changes
Issue Number: close #22940

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.86 seconds
stream load tsv:          513 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.21 seconds
stream load tsv:          541 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          97.0 seconds inserted 10000000 Rows, about 103K ops/s
storage size:<PHONE_NUMBER>9 Bytes

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.67 seconds
stream load tsv:          541 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          99.3 seconds inserted 10000000 Rows, about 100K ops/s
storage size:<PHONE_NUMBER>9 Bytes

Please add regression test to cover this case

done

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.5 seconds
stream load tsv:          541 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          98.9 seconds inserted 10000000 Rows, about 101K ops/s
storage size:<PHONE_NUMBER>0 Bytes


Delete bridge after powering daemon down

Closes https://github.com/docker/machine/issues/1455
cc @docker/machine-maintainers
@dave-tucker @mavenugo @mrjana Can you please take a look at this and tell me if you think it seems safe / sane?  I've tested on boot2docker and it works swimmingly, but not on other distros.
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

No objections so far, so I'm going to merge this and revert if it seems problematic.

@nathanleclaire getting an LGTM from another maintainer is mandatory.
Please do not merge your own code yourself.
If something is lingering for too long, just ask during the standup.


chefdk error while loading shared libraries in fedora 30

Description
Since upgrading to fedora 30 I am getting the following error when trying to run anything with chef. The example I have provided is as below:
[umbreon@NOT-001417 sensu_cookbook]$ chef exec rspec -I ./
/opt/chefdk/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.1: cannot open shared object file: No such file or directory
[umbreon@NOT-001417 sensu_cookbook]$
I have tired this in a brand new install of fedora 30 in a VM to confirm this issue.
ChefDK Version
Unable to run chef version due to error but I have provided the rpm version below:
[umbreon@NOT-001417 sensu_cookbook]$ chef --version
/opt/chefdk/embedded/bin/ruby: error while loading shared libraries: libcrypt.so.1: cannot open shared object file: No such file or directory
[umbreon@NOT-001417 sensu_cookbook]$ rpm -qi chefdk
Name        : chefdk
Version     : 4.0.1
Release     : 1.el7
Architecture: x86_64
Install Date: Thu 02 May 2019 15:44:50 BST
Group       : default
Size        : 504075739
License     : Apache-2.0
Signature   : DSA/SHA1, Thu 28 Feb 2019 20:52:50 GMT, Key ID 2940aba983ef826a
Source RPM  : chefdk-4.0.1-1.el7.src.rpm
Build Date  : Thu 28 Feb 2019 20:52:15 GMT
Build Host  : chefdk-rhel-7-builder-9b2226.cd.chef.co
Relocations : /
Packager    : Chef Software, Inc<EMAIL_ADDRESS>Vendor      : Omnibus<EMAIL_ADDRESS>URL         : https://www.chef.io
Summary     : The full stack of chefdk
Description :
The full stack of chefdk
[umbreon@NOT-001417 sensu_cookbook]$
I have also tired this with the latest chefdk from the stable channel and the error is the same on both my machine and a brand new clean VM
Platform Version
Fedora 30
[umbreon@NOT-001417 sensu_cookbook]$ cat /etc/os-release
NAME=Fedora
VERSION="30 (Workstation Edition)"
ID=fedora
VERSION_ID=30
VERSION_CODENAME=""
PLATFORM_ID="platform:f30"
PRETTY_NAME="Fedora 30 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:30"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f30/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=30
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=30
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation
[umbreon@NOT-001417 sensu_cookbook]$
Replication Case
To replicate this simply do the following:

fedora 30 VM or machine

install the latest chef dk from either the stable or current channel

then try to run chef exec rspec against some spec tests or any chef command

Stacktrace
N/A
NOTE: CHEFDK BUGS ONLY
This issue tracker is for the code contained within this repo -- chefdk.

Server issues
Chef-client issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

Managed to sort this in fedora 30 by installing libxcrypt-compat. Closing this now

looks like Fedora 30 ships with libcrypt version 2 which the above package mentions provides. maybe something which could be improved in the rpm SPEC file for chefdk but otherwise easy to fix for the end user either way :D


Template: Magazine Article - Next Article

Business Value
As a content author, I want to implement a 'Next Article' feature at the bottom of each article to enhance user retention and encourage continued engagement, thereby increasing page views and overall site usability.
Description
A block that shows the title of the next article and links to it will be developed to be used in the #211 - Template: Magazine Article.

Acceptance Criteria

[ ] The block follows the design shown on Magazine Article - Figma.
[ ] The block can be added to the #211 - Template: Magazine Article.

Kamino cloned this issue to hlxsites/vg-volvotrucks-us


Diamond Mining Arrow Block Breaking

Hi there,
I have run into an issue on the 1.16.5 version of the mod, 4.8.99C. The Mining Arrows are capable of breaking blocks which are not intended to be breakable, such as the Waystone from Waystones, when the configuration with that mod is set to prevent them from being broken. This has worked on all tools except the mining arrows from this mod. I did not see a configuration to disable them, so I am only able to remove the recipe - they still show up as loot.
Can a configuration be added to allow full removal of mining arrows?
Thank you!

Full removal of content is not a supported configuration feature.
However, these arrows are not added to any loot pools, so I'm not sure where you would be getting them aside from the recipe.

Hmm, something on my side must be adding them as loot - will dig into this further to confirm something on my side isn't messing with it. Thanks for the info!


Add an example of multiple child usage in the React reference

PR: https://github.com/patternfly/patternfly-next/pull/42

PR: https://github.com/patternfly/patternfly-next/pull/42

PR: https://github.com/patternfly/patternfly-next/pull/42


Update nodeenv compatibility

nodeenv now supports leading v in https://github.com/ekalinin/nodeenv/pull/359.

Thanks, I had not seen that.


Remove deprecation warnings

Use method prepend_before_action instead prepend_before_filter and
request.env instead env.
DEPRECATION WARNING: prepend_before_filter is deprecated and will be removed in Rails 5.1. Use prepend_before_action instead. (called from block in <module:ControllerHelpers> at /Users/mgrachev/peek/lib/peek/controller_helpers.rb:6)
DEPRECATION WARNING: env is deprecated and will be removed from Rails 5.0. (called from set_peek_request_id at /Users/mgrachev/peek/lib/peek/controller_helpers.rb:13)

Use method prepend_before_action instead prepend_before_filter and
request.env instead env.

I don't have any data on the number of installs for 3.x, but I like the idea of merging these :+1:

Released this in v0.2.0 and pushed to Rubygems.

Good news! :tada:


Possible bug in ScaledAdam optimizer

this line asserts that key "named_params" must be in group, but this holds only for case 4, not case 2.
Possible fix:
for cur_group in iterable_or_groups:
    if "named_params" in cur_group:
        name_list = [x[0] for x in cur_group["named_params"]]
        p_list = [x[1] for x in cur_group["named_params"]]
        del cur_group["named_params"]
        cur_group["params"] = p_list
    else:
        assert "params" in cur_group
        name_list = ["foo" for _ in cur_group["params"]]
    param_groups.append(cur_group)
    param_groups_names.append(name_list)

Yes. Thanks a lot! Will fix it.


chore(apps/libs/caches): extract semaphore cache from whale

What this PR does / why we need it:
As SemaphoreCache is used by multiple nestjs apps, extract it from whale and make it a shared library.
Which issue(s) does this PR fixes?:

Fixes #1358
Additional comments?:

hmm... should point all the semaphore cache to app/libs/caches, then rm the ori semaphore from whale?? :thinking:

hmm... should point all the semaphore cache to app/libs/caches, then rm the ori semaphore from whale?? 🤔

I think I did point all the semaphore cache to it already, but I haven't remove the ori sempahore yet.


MIS: main()

Some variables are not defined in SRS or MIS like P_x or P_y.

That doesn't seem like proper notation for an or statement nor am I sure what the "or" is for.

Equations can be created either from X-axis or Y-axis. So for creating all possible equations we need both formulas. Each element a_{ij} can be calculated from the first equation or the second equation. Thank you!


Implement refresh token caching to prevent race conditions

Introduced database connection pooling to enhance reliability and prevent issues from a single connection failure.
Refactored token validation by splitting it into several functions for improved readability and maintainability.
Implemented caching to handle concurrent refresh token requests, thereby preventing race conditions.
Added diskcache to the requirements.
Created new test cases to cover the refresh token changes and ensure functionality.

Could you please review the pull request, especially the caching logic?

I appreciate your thoughts on this. I wanted to clarify my reasoning for exploring a caching solution like diskcache.
The primary goal is to manage concurrent refresh token requests effectively:

Block concurrent refresh token requests from the same user, while still being able to handle concurrent requests from other users.
Invalidate the old refresh token, but allow a grace period for concurrent requests.

While our existing database abstractions are robust, they might not provide the level of atomicity and concurrency control I'm looking for in this specific case. Caching solutions are designed to handle such scenarios more efficiently.
That being said, I understand the value of reusing the tools and systems we already have in place. If diskcache ends up adding complexity or issues to our Heroku hosting environment, I'm open to considering other options. Ideally, I'd like a solution that covers both aspects (1 & 2) out of the box, without the need for me to do any additional implementation.
In my search, I found dogpile.cache, which seems to be a good fit as it can use PostgreSQL as a backend. The transition to it shouldn't be too time-consuming, as the core logic is in place and I'd just be swapping out APIs.
What are your thoughts on this? Should I stick with diskcache or make the move to dogpile.cache?

Let's ship it as is and then if there are issues we can switch to dogpile
On Fri, May 24, 2024 at 6:09 PM Abdullah Al Nahas @.***>
wrote:

I appreciate your thoughts on this. I wanted to clarify my reasoning for
exploring a caching solution like diskcache.
The primary goal is to manage concurrent refresh token requests
effectively:

Block concurrent refresh token requests from the same user, while
still being able to handle concurrent requests from other users.
Invalidate the old refresh token, but allow a grace period for
concurrent requests.

While our existing database abstractions are robust, they might not
provide the level of atomicity and concurrency control I'm looking for in
this specific case. Caching solutions are designed to handle such scenarios
more efficiently.
That being said, I understand the value of reusing the tools and systems
we already have in place. If diskcache ends up adding complexity or
issues to our Heroku hosting environment, I'm open to considering other
options. Ideally, I'd like a solution that covers both aspects (1 & 2) out
of the box, without the need for me to do any additional implementation.
In my search, I found dogpile.cache
https://github.com/sqlalchemy/dogpile.cache, which seems to be a good
fit as it can use PostgreSQL as a backend. The transition to it shouldn't
be too time-consuming, as the core logic is in place and I'd just be
swapping out APIs.
What are your thoughts on this? Should I stick with diskcache or make the
move to dogpile.cache?
—
Reply to this email directly, view it on GitHub
https://github.com/waleedkadous/ansari-backend/pull/40#issuecomment-2130635077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUXGUHB6URJUXT3IM35N2DZD7QE5AVCNFSM6AAAAABIG3MNEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZQGYZTKMBXG4
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


clang++ is supported as compiler for seed projects

In src/Makefile clang++ is already allowed as compiler, but not in seed projects.
This change would be nice for arch linux users.

Can one of the admins verify this patch with one of the following commands:

"test please" for a one time test run
"ok to test" to accept latest and future commits on this pull request for testing
"add to whitelist" to add the author to the whitelist

Hi @spjoe thanks! I'll get this merged with the next update - we just found and solved some more issues


adding a turkish book link

Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Added a book link to  free-programming-books-tr.md
Why is this valuable (or not)?
This is a good book for java beginners.
How do we know it's really free?
Link is directly from the author's website.
For book lists, is it a book? For course lists, is it a course? etc.
Yes, it is a book.
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

added here: #5079
Thanks, and welcome to free-programming-books!


HADOOP-16548 : Disable Flush() over config

This PR renders OutputStream Flush() API to no-op in AbfsOutputStream over a config control.
Hflush() being the only documented API that can provide persistent data transfer, Flush() also executing actions to persist buffered data was causing perf issues.
OutputStreams of WASB and ADLS drivers already have the Flush() as a no-op too.
Option to enable OutputStream Flush() over config is provided incase there are any customers who have taken a dependency on this.

code LGTM; just tuning the text

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1163
trunk passed

+1
compile
27
trunk passed

+1
checkstyle
19
trunk passed

+1
mvnsite
29
trunk passed

+1
shadedclient
826
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
46
trunk passed

_ Patch Compile Tests _

+1
mvninstall
26
the patch passed

+1
compile
22
the patch passed

+1
javac
22
the patch passed

+1
checkstyle
14
the patch passed

+1
mvnsite
25
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
847
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
52
the patch passed

_ Other Tests _

+1
unit
80
hadoop-azure in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3382

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1508

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 624b6bb64e3a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c30e495

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/1/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
90
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1102
trunk passed

+1
compile
32
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
36
trunk passed

+1
shadedclient
818
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
55
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
54
trunk passed

_ Patch Compile Tests _

+1
mvninstall
28
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
18
the patch passed

+1
mvnsite
27
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
805
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
54
the patch passed

_ Other Tests _

+1
unit
82
hadoop-azure in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

3390

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1508

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e8b159affc6c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8a9ede5

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/2/testReport/

Max. process+thread count
464 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Patch LGTM. @DadanielZ -any final comments?

@steveloughran  Nope, LGTM, +1

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1085
trunk passed

+1
compile
31
trunk passed

+1
checkstyle
24
trunk passed

+1
mvnsite
34
trunk passed

+1
shadedclient
748
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
52
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
49
trunk passed

_ Patch Compile Tests _

+1
mvninstall
30
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
28
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
759
patch has no errors when building and testing our client artifacts.

+1
javadoc
22
the patch passed

+1
findbugs
56
the patch passed

_ Other Tests _

+1
unit
82
hadoop-azure in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

3211

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1508

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux da67e8f166e4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ce58c05

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/3/testReport/

Max. process+thread count
437 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1508/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

committed


Soduku game project

Describe the project
A clear and concise description of the project you are going to add to this repository.
Issue Type:

[it is an soduku game made with html css and javascript ] New Project

Additional context
Add any other context or screenshots about the project here.
Screenshots

If applicable, add screenshots to help explain your problem.

Assign me this issue

@NaMiKA0305 Games are not allowed


Not working in Windows

I have actionlint installed via Scoop on Windows. However, the lint messages do not appear.
See example below. Running actionlint from the command line works just fine but they do not appear from the file itself (the other error is from the yaml extension):

@sitiom Could you tell me which version of actionlint you are using?

Here is the output from actionlint --version
> actionlint --version
1.6.15
installed by downloading from release page
built with go1.18.3 compiler for windows/amd64

This extension requires actionlint >= v1.6.14 and files must be placed under .github/workflows/. It seems your environment satisfied both requirements 🤔 .  Currently, I have no idea why it is not working, but I have not tested my extension in Windows.

This software checks the path to determine whether this file is a GitHub Actions Workflow file or not. I suspect these line of codes might not work in Windows.
https://github.com/arahatashun/vscode-actionlint/blob/dcc081c6a4e1fb235095b45ea3dbb4c325f0dc8e/src/extension.ts#L13

Even after the regex change in https://github.com/arahatashun/vscode-actionlint/commit/836896552da02fbf8066c3d3281065191f84821f, it still doesn't work.

Thank you for reporting the problem. Actually,  I do not have access to Windows computers now 😭 .

@arahatashun Can you bring back the .github/workflows regex? The Github docs clearly specify that .github/workflows is the default folder for all workflows.
I have encountered a similar error in a Neovim plugin (https://github.com/jose-elias-alvarez/null-ls.nvim/pull/986), which is also about actionlint as well. Turns out backward slashes are required for Windows. Maybe that helps.

@sitiom
I know all GitHub actions files are located under .github/workflows. However, I am using a multi-root workspace which has ,github/ as a root. Because of this, I change the regex. Do you have any problems caused by this change?

Can you bring back the .github/workflows regex? The Github docs clearly specify that .github/workflows is the default folder for all workflows

@sitiom
What change of regex are you suggesting here?

I have encountered a similar error in a Neovim plugin (https://github.com/jose-elias-alvarez/null-ls.nvim/pull/986), which is also about actionlint as well. Turns out backward slashes are required for Windows. Maybe that helps.

I know all GitHub actions files are located under .github/workflows. However, I am using a multi-root workspace which has ,github/ as a root. Because of this, I change the regex.

Oh ok, that makes sense. Keep it as is, then.

@sitiom What change of regex are you suggesting here?

It looks like the current regex already accounts for backward slashes, so I'm not sure what's the problem.

Maybe this is the cause.
https://github.com/fnando/vscode-linter/issues/17

It seems to be working now that the upstream issue has been fixed.


GDCR2018 Lodz, Harman added

Welcome @jackqrr , nice to see so many events for Poland! Have a great one and our greetings to Lodz! 🎉


Unexpected end of json input when sending too many requests

Problem
When sending like 50 transactions in parallel, we got an error from fcl which says "Unexpected end of JSON input". In fact, we are receiving a 429 status code due to the rate limit. It would be better if fcl can return a readable error, it can be hard to understand what is the issue in such cases.
Steps to Reproduce
Send more than 50 transactions in parallel
Context
Tested with fcl 1.0.2 and 1.1.0 on Node.js

This will be fixed by #1278.  res.json() was being called with an empty response body prior to throwing HTTPRequestError

Thanks for the reply. I checked a bit the code of the PR, indeed I guess we will not have the "Unexpected end of JSON input" but we will not have a proper error for 429. Or did I miss something?

If res.json() doesn't throw an error then the code will reach the point where it throws an HTTPRequestError https://github.com/onflow/fcl-js/pull/1278/files#diff-26ec45396ff3d6022d9d704b764737eeea127ed3d98c9a238bb5a98dc5f9e0b0R124-R135.  It was previously a bug that res.json() would throw an error prior to the code reaching this point.
Now there would be an error thrown with error.statusCode == 429

ok indeed, perfect thanks :)


added dev tools

Fixes Issue
Added new sub-category "Dev Tools" for adding dev related resources like Vim commands
Made changes to >types>index.ts , >database>index.ts , >database>data.ts , created devtools.json

Added resources like VSCodium and Postman

Closes : #347
Screenshots

@rupali-codes @CBID2 done !!

@CBID2 it would be great if you review my PR so we can merge it :)

thank you @ujjawaltyagii & @CBID2 :)


html tags incorrectly applied in notice

Also remove the comma after Please in the second sentence.

Fix was released with version 3.2.5
Closing the ticket.


Update README.md

The original README.md is not well organized.
This PR is to update it:

Add a section to list all parameters
Group all workflow samples into one section
Add steps to prepare service principal and managed identities before using them for login
Add examples for login with managed identities

This PR will not be merged till the next release because the workflow of login with managed identities will only work in the new release.

Hi @MS-jeremy , @MoChilia , @jiasli , @isra-fel , @msJinLei , please help to review the update. Thanks.

Hi @MS-jeremy , @MoChilia , @jiasli , @isra-fel , @msJinLei , please help to review the update. Thanks.

@YanaXu I'm not quite sure why I'm not the reviewer of this article, can you check if you @ the wrong person?

Hi @MS-jeremy
        Jeremy Li
        FTE , @MoChilia

        Shiying Chen
        FTE , @jiasli

        Jiashuo Li
        FTE , @isra-fel

        Yeming Liu
        FTE , @msJinLei

        Lei Jin
        FTE , please help to review the update. Thanks.

@YanaXu Yan Xu FTE I'm not quite sure why I'm the reviewer of this article, can you check if you @ the wrong person?

@MS-jeremy, sorry for this. I mistook you for the other Jeremy Li.

ble of content (toc) would be useful to navigate through such a long

Updated.

The Comments are submerged. Here are the links. Other comments are resolved.

Yeming's comment

Updated.

Shiying's comments

about MI warning

Added.

about output warning


Wait for async expand-function

Hi,
a needed feature is to wait for a node to be expanded. When I load my children asynchronously then I want to be informed when the node finally got it's data and is expanded, so that I can continue to expand a node from the next hierarchy level for example.
Or is there another way and I missed it in the documentation?
If I get a promise back from the expand - function, it'd be perfect. Thanks!
P.S.: If I find the time I could also try to implement this on make a pull request.

Hi,
This is a known problem. If you can make a PR for this it would be greatly appreciated!

+1

I just created a PR #106 where the expand - function returns a promise. It works for my scenario.
We could also add a new function now that automatically expands a whole path. For this I could add another PR that adds the implementation of the following signature:
expandPath(path: string[]): Promise<any>;
Let me know if it's needed or better should be implemented on their own.
P.S.: Are there any tests?

I'm still thinking about the PR, I understand the need but I'm thinking if there's a better way to do it.
Tests - on the list.
Version 2.4.0 fixes isExpanded on async children. Notice that this version has some breaking changes.

I think this is still an issue, isn't it? I'm trying to find a way to do expandPath() with async children. Is there a way to do so, which I can't see at the moment?

I will merge it hopefully ASAP
--

Adam Klein http://il.linkedin.com/in/adamklein500
CTO @ 500Tech.com http://500tech.com/
AngularJS, ReactJS, NodeJS
Development, consulting, training and public speaking
(+972) 52 747 5633

On Wed, Jan 4, 2017 at 4:40 PM, Ivo Senner<EMAIL_ADDRESS>wrote:

I think this is still an issue, isn't it? I'm trying to find a way to do
expandPath() with async children. Is there a way to do so, which I can't
see at the moment?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/500tech/angular2-tree-component/issues/96#issuecomment-270385915,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2SSlJruvCEdk11N3N9ST6QGlllXnkHks5rO692gaJpZM4Knaj1
.


Add Kirinyaga University

@Evecandy First stage of verification passed, official domain is kyu.ac.ke as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Evecandy Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Add float16 support for scatter_add

This pull request adds float16 support for scatter_add by implementing float16 version of atomicAdd() (atomicCAS with 32bit memory alignment) and works with CUDA 9.0 and later.
In CUDA 10, 16bit __half floating point version of atomicAdd() is introduced, and maybe its faster than this implementation, but this works on more devices for now.

What is the reason that this feature is restricted to CUDA 9.0 and later only? (Because CuPy officially support CUDA 7.0 and later now)

In https://github.com/cupy/cupy/blob/master/cupy/core/include/cupy/carray.cuh#L9, cuda_fp16.h is included only __CUDACC_VER_MAJOR__ >= 9, so I thought cuda_fp16.h is available only in CUDA 9.0 and later, but in fact, cuda_fp16.h was introduced on CUDA 7.5.
Supporting CUDA 7.5 and later seems possible, I'll try it.
Thank you for pointing out!

supports for CUDA 7.0 and later is added

Thanks! I'll look into it.

Jenkins, test this please.

Jenkins CI test (for commit 7f2f6927c1966aa6614dc515e76f1fb618f2957f, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Remove duplicate calculation on old_as_us and pushed some fixes.

Jenkins, test this please.

Jenkins CI test (for commit 18b6e08f06416230deaa0b9de9e01d4f651ed8a4, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Even in CUDA 9.0 and later, arithmetic operation in fp16 is not supported on compute capability 5.2 or earlier, I've pushed fix for it.

Jenkins, test this please.

LGTM!


Can you add on to this PowerPoint add-in tutorial how to insert a pptx slide to an already open presentation?

In an already opened presentation how can we Insert a pptx slide as a base64 encoded string to work on all platforms of powerpoint?  Is it even possible to insert a pptx slide with this project setup from this tutorial via  base64 encoded string?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18abb533-5be7-d533-8106-c52d458ddc1d
Version Independent ID: 6af81176-d832-d3d5-5060-5218b2ba75ac
Content: PowerPoint add-in tutorial - Office Add-ins
Content Source: docs/tutorials/powerpoint-tutorial.md
Product: powerpoint
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

Yes. Your add-in inserts slides from another PowerPoint presentation into the current presentation with the Presentation.insertSlidesFromBase64 method.  This method is supported on any platform that supports the PowerPointApi 1.2 requirement set. This requirement set is not supported on the one-time purchase versions of Office or PowerPoint. Please see PowerPointApi requirement sets for more information.


person.jobDescriptor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0088c20) to head (6da1ab1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          105       107    +2
  Branches        14        14
=========================================
+ Hits           105       107    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


network: support hashable address for ConnectionHandlerImpl

Commit Message: network: support hashable address for ConnectionHandlerImpl
Additional Description:
The string output of Network::Address::Instance doesn't guarantee it should be the correct output for the void hash key. For example, the envoy internal address' string output is envoy://{address_id}/{endpoint_id}. But actually, we only use the address_id as the hash key on the listener side.
This PR adds a wrapper Network::Address::AddressKey for InstanceConstSharedPtr, enabling to use Network::Address::InstanceConstSharedPtr as a hash key for absl::Hash. Then we can remove the usage of address string as hash key.
This PR changes the hash maps in ConnectionHandlerImpl to use the Network::Address::AddressKey as the hash key. the parameter of ConnectionHandlerImpl::getBalancedHandlerByAddress is changed for enabling query based on Network::Address::InstanceConstSharedPtr.
There are more places that need to replace the address string hash key, those will be done in the separated PRs.
Risk Level: high
Testing: unittests
Docs Changes: n/a
Release Notes: n/a

/retest

@kyessenov can you take a pass? I think this is worth having @mattklein123 do a senior maintainer pass eventually.
@soulxu can you talk, in the description, about the motivation for this? Is this to make things faster by not having to hash the string? Do you have a microbenchmark showing what we'll eventually get after the last phase of this?

@kyessenov can you take a pass? I think this is worth having @mattklein123 do a senior maintainer pass eventually.
@soulxu can you talk, in the description, about the motivation for this? Is this to make things faster by not having to hash the string? Do you have a microbenchmark showing what we'll eventually get after the last phase of this?

@jmarantz thanks for the review! that is a good question. Actually, there are several times we mentioned should make the Address object hashable instead of using the string. The most recent one is https://github.com/envoyproxy/envoy/pull/23760#discussion_r1014155485
I think the major reason is the string output of the address object isn't a guarantee of the hash key for the address object. One of example is the internal address' string output is 'evnoy://{address_id}/{endpoint_id}', but actually, we only use the address_id as the hash key. https://github.com/envoyproxy/envoy/pull/24198/files#diff-fe538327af200510b78cadc759f2c3af989c822a370d3f8a005b92bc59568aa5L134
I will update this in the description.

I think the major reason is the string output of the address object isn't a guarantee of the hash key for the address object.(The string output is major for human readable I think) One example is the envoy internal address' string output is envoy://{address_id}/{endpoint_id}, but actually, we only use the address_id as the hash key. https://github.com/envoyproxy/envoy/pull/24198/files#diff-fe538327af200510b78cadc759f2c3af989c822a370d3f8a005b92bc59568aa5L134

@kyessenov do we use address_id + endpoint_id for hash the host in the upstream? if yes, that is confusing too, that seems like we can't have a single interface to hash the object since downstream and upstream hash with a different keys.

@soulxu Sorry I think I messed up something in your comment. Was on a flaky internet and hit refresh at a wrong time.

@soulxu Sorry I think I messed up something in your comment. Was on a flaky internet and hit refresh at a wrong time.

no worries, thanks for the feedback!
Seems it should be fine, since listener is the only place using address to hash today. Even if other places need a different ways to hash the address in the future, we can define another AddressKey.

/wait

Apologies for dropping the ball on this review. I think this is a good idea but this is a really core code so would definitely want some senior reviewer as well.
cc @envoyproxy/senior-maintainers

thanks for the review again!

/wait
according to https://github.com/envoyproxy/envoy/pull/24198#discussion_r1040147664, this PR https://github.com/envoyproxy/envoy/pull/24438 is added.
In theory, we should wait for that PR merge first.

Generally, LGTM, apart from minor address_length_ comment. I think this needs a second set of eyes though.

thanks for the review, sorry for reply the comment partially previously. Since I got covoid19, I will slow down work few days.

@soulxu Sorry to hear, hope it's nothing serious. I'll be on and off in the next couple of weeks, too.

@soulxu Sorry to hear, hope it's nothing serious. I'll be on and off in the next couple of weeks, too.

It is all good here, thanks!
I change ConnectionHandleImpl::findByAddres to generate a temp address without endpoint id. Also change the pipe address hash method to use the actual path size. Would you like to review  again, then I can catch the senior maintainer for next review.
Thanks
Alex

/retest

/retest

/retest

/wait-any

/wait-any

Is this PR still in progress?

@zuercher, sorry, I recently focus on IoUring support and other internal things. Plan to continue this next quarter, also https://github.com/envoyproxy/envoy/pull/23882 since this PR is ahead refactor for it.
Are you looking for this change? or just cleanup stall PR?

Just checking in since it seemed stalled.

/wait


⚠ Bofrost.at has degraded performance

In 45b8cfd, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1717 ms

Resolved: Bofrost.at performance has improved in 8a274e4 after 6 minutes.


Make all to wait for element index

Now
all("li")[1]

Fails Indexofbound because not loaded
To be:
all("li")[1]

waits for timeout for collections to have at least 1 element and only then fails

https://github.com/SergeyPirogov/kirk/pull/49


fix: ParserError EOF inside string (#470)

Do not interpret quotes at the start of text read by tesseract as TSV cell quoting otherwise an error is raised if the tesseract TSV output contains rows like this:
5	1	45	1	24	1	1557	1119	104	43	79.578239	"Example
5	1	45	1	24	2	1675	1119	76	43	93.807220	rows”

Issue resolved by this Pull Request:
Resolves #470
Checklist:

[X] Documentation has been updated, if necessary.
[X] Examples have been added, if necessary.
[X] Tests have been added, if necessary.

@nikos-livathinos Can you quickly review: I would like your approval before we merge this.

@nikos-livathinos I cannot share the original confidential document, but let me generate one for you:
quote-test.pdf


Adding support for Extension Create Components [environment settings and add setting update consumers]

Description
Adds support for extensions to request environment setting values from opensearch, to add setting update consumers to cluster settings, and to receive update setting requests from Opensearch whenever a setting is updated.
Companion PR : https://github.com/opensearch-project/opensearch-sdk-java/pull/138
Issues Resolved
[List any issues this PR will resolve]
Check List

[X] New functionality includes testing.

[ ] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4517 (097b239) into feature/extensions (7e2af69) will increase coverage by 0.05%.
The diff coverage is 12.12%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4517      +/-   ##
========================================================
+ Coverage                 70.64%   70.69%   +0.05%
- Complexity                57428    57512      +84
========================================================
  Files                      4641     4646       +5
  Lines                    276257   276388     +131
  Branches                  40386    40401      +15
========================================================
+ Hits                     195166   195401     +235
+ Misses                    64789    64650     -139
- Partials                  16302    16337      +35

Impacted Files
Coverage Δ

...h/extensions/AddSettingsUpdateConsumerRequest.java
0.00% <0.00%> (ø)

...g/opensearch/extensions/UpdateSettingsRequest.java
0.00% <0.00%> (ø)

...arch/extensions/UpdateSettingsResponseHandler.java
0.00% <0.00%> (ø)

...rg/opensearch/env/EnvironmentSettingsResponse.java
12.90% <12.90%> (ø)

...nsearch/extensions/EnvironmentSettingsRequest.java
20.83% <20.83%> (ø)

.../opensearch/extensions/ExtensionsOrchestrator.java
62.56% <27.77%> (-3.89%)
:arrow_down:

server/src/main/java/org/opensearch/node/Node.java
85.03% <100.00%> (+0.02%)
:arrow_up:

...adonly/AddIndexBlockClusterStateUpdateRequest.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...readonly/TransportVerifyShardIndexBlockAction.java
9.75% <0.00%> (-58.54%)
:arrow_down:

...n/admin/indices/readonly/AddIndexBlockRequest.java
17.85% <0.00%> (-53.58%)
:arrow_down:

... and 469 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Custom theme not working as advertised

//config/log-viewer.php
/* -----------------------------------------------------------------
     |  Theme
     | -----------------------------------------------------------------
     |  Make your own theme by adding a folder to the views directory and specifying it here.
     */

    'theme'         => 'log-viewer',

Results in
local.ERROR: View [log-viewer.dashboard] not found.
As shown the files appear to be in the right(?) place:

Hey @promanapeople
Log Viewer does not have a configurable team. Where did you find it?

Our mistake! It looks like there's been another log viewer package installed. Thanks for your time.


Create SECURITY.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @JefriReynaldi, could you provide some context about what this security.md file is for or what it refers to?


Add snowbridge support

@nohaapav ,
Is it possible to transfer WETH bridged from SnowBridge to AHP?
If so, could you please provide us extrinsic that is capable of that?
Thanks!

@nohaapav ,
Is it possible to transfer WETH bridged from SnowBridge to AHP? If so, could you please provide us extrinsic that is capable of that?
Thanks!

Yes, it's. I'll once tested and configured.

Done

@nohaapav can you point us to extrinsics that are capable of this? Thanks!


fix match usage

Summary
I was solving a similar problem in the formidable.com rewrite, taking inspiration from this slick implementation and noticed that the value returned from match was not being treated as an array here.
Set of changes

add parsePathname function and handle returned value like an array

Awesome! Nice catch 🙌


Daily quests that fail cause the server to error

failQuest() is not correctly looking for the associated repeatable quest and the logic is assuming all quests are not repeatable.

Originally written by chomp

Fixed with: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/d362e17e1b4cd31794968afa5502022b2c578ed4

Originally written by chomp


Add ANU to supported institutions

Works great with ANU (which uses echo360.org.au), didn't have to change a thing.
You saved me a couple of hours worth of coding. Thanks 👍

Hi @harrisony
Thanks for the update! No problems!
ANU has been added to supported insitutions in the Wiki, as well as the README file in commit 8d690218


feathers-error dep

The dependency for feathers-errors needs to be updated as the package has changed https://github.com/canjs/can-connect-feathers/blob/master/package.json#L62
It should now be @feathersjs/errors as the package

@Mattchewone and @chasenlehara Is it possible to update this package to Can v5.x+ and Feathers v4+ ?Is there anything I can do to help?

I'm going to do a spike today to see what it would take to upgrade this.

@matthewp Much appreciated.

I have my progress here: https://github.com/canjs/can-connect-feathers/tree/feathers4
I was able to get a little over half of the tests passing. The biggest difference seems to be that authentication stopped using passport and can-connect-feathers did some stuff using passport and that part needs to change. There's also some timing issues where if a test runs by itself it passes but when run with all of them it fails. I'm not sure what that is about.
My guess is that it's probably another couple of days of work to get the upgrade done.

@matthewp Much appreciated. Once I am caught up with my work, I will see if I can help.


test: Debug IPsec test

Related: https://github.com/cilium/cilium/issues/16699.

test-1.19-5.4

test-1.19-5.4

test-only --kernel_version=5.4 --k8s_version=1.19 --focus="K8sDatapathConfig Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing"

test-1.19-5.4

test-only --kernel_version=5.4 --k8s_version=1.19 --focus="K8sDatapathConfig Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing"

test-only --kernel_version=5.4 --k8s_version=1.19 --focus="K8sDatapathConfig Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing"

test-1.19-5.4

test-1.19-5.4

test-only --kernel_version=5.4 --k8s_version=1.19 --focus="K8sDatapathConfig Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing"

test-1.19-5.4

test-only --kernel_version=5.4 --k8s_version=1.19 --focus="K8sDatapathConfig Transparent encryption DirectRouting Check connectivity with transparent encryption and direct routing"

test-1.19-5.4

test-1.19-5.4

Why can't the bugtool retrieve this output?

Because the Cilium agent is fataling, so by the time we get the bugtool reports, the Cilium pods are crashlooping and we can't run anything on them. See https://jenkins.cilium.io/job/cilium-master-k8s-1.19-kernel-5.4/367/testReport/junit/Suite-k8s-1/19/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/ from https://github.com/cilium/cilium/issues/16699.

test-1.19-5.4

The changes here are not specific to IPsec or the datapath so skipping that review. Tests are passing. Merging.


Simplify creating new ListingTable

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
I think that we can simplify creating a ListingTable by using some simple inference and reasonable defaults for ListingOptions and Schema
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like to update the signature to go from:
ListingTable::new(object_store: Arc<dyn ObjectStore>, table_path: String, file_schema: SchemaRef, options: ListingOptions)

to
ListingTable::new(object_store: Arc<dyn ObjectStore>, table_path: String, file_schema: Option<SchemaRef>, options: Option<ListingOptions>)

Then, we can look at the suffix of the table_path to infer a file type and use that for the format and file_extension parameters of ListingOptions.  We could use the below as defaults for the other parameters:
let listing_options = ListingOptions {
            format: Arc::new(ParquetFormat::default()), // derived from ListingTable::new(table_path, ..)
            collect_stat: true,
            file_extension: "parquet".to_owned(), // derived from ListingTable::new(table_path, ..)
            target_partitions: num_cpus::get(),
            table_partition_cols: vec![],
        };

We could then use listing_options to create a Schema
// object_store from ListingTable::new(object_store, table_path, ..)
let resolved_schema = listing_options.infer_schema(object_store.clone(), filename).await?;

The end result is a much simpler interface for creating tables.
Old
let filename = "data/alltypes_plain.snappy.parquet";

let listing_options = ListingOptions {
    format: Arc::new(ParquetFormat::default()),
    collect_stat: true,
    file_extension: "parquet".to_owned(),
    target_partitions: num_cpus::get(),
    table_partition_cols: vec![],
};

let resolved_schema = listing_options
    .infer_schema(object_store.clone(), filename)
    .await?;

let table = ListingTable::new(
    object_store,
    filename.to_owned(),
    resolved_schema,
    listing_options,
);

New
let filename = "data/alltypes_plain.snappy.parquet";

let table = ListingTable::new(
    object_store,
    filename.to_owned(),
    None,
    None,
);

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@alamb @houqp @seddonm1 what do you think about this proposal?

@alamb @houqp @seddonm1 what do you think about this proposal?

I think the usecase of defaulting schema and format makes a lot of sense
If you are going to change the signature of ListingTable perhaps it would be worth using a builder / config (so that future changes don't require another signature change):
Something like
struct ListingTableConfig {
  object_store: Arc<dyn ObjectStore>,
  table_path: String,
  file_schema: Option<SchemaRef>,
  options: Option<ListingOptions>
}

impl LIstingTableConfig {
  fn new(object_store: Arc<dyn ObjectStore>, table_path: impl Into<String>) -> Self {
    ..
  }

  fn with_schema(mut self, schema: SchemaRef) -> Self {
  ...
  }

  fn with_options(mut self, listing_options: ListingOptions) -> Self {
  ..
  }
}

And then your example could look like
let config = ListingTableConfig::new(
  object_store,
  "data/alltypes_plain.snappy.parquet"
);

let table = ListingTable::new(config);

@alamb  great idea. Will do that.

Both of your idea and @alamb's suggestions of builder pattern sounds like a good plan to me :+1: Thank you for bring this up.


[CWS] do not handle pid 0 in process resolver

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


inconsistency in handling of environment variables defined within features

First of all thanks for this project! It's a great tool and I'm currently working on integrating it more tightly into our workflows. That said, I'm not sure the issue I'm having is appropriate for this repo or if it would be better suited for the spec or features repos - feel free to move it if needed.
The problem I'm seeing is an inconsistency in the container environment depending on how I end up running the devcontainer. My devcontainer.json uses a feature that itself installs another feature via the nanolayer tool - this is a pattern that many of the contributed features use. This dependency feature sets some environment variables, notably it changes the PATH; if used directly (i.e. as part of the features set in devcontainer.json) the variables are set via the ENV directive in the generated Dockerfile. However, if the feature is used indirectly, the variables do not propagate to the Dockerfile, meaning that if I just run the generated image, the environment is wrong. If running the image via the devcontainer tooling, the CLI seems to inspect all the features (even the indirectly used ones) and "corrects" the environment at runtime, so when running via VSCode it's correct.
Here's a sketch of the situation:
devcontainer.json
...
    "features": {
      "<high-level-feature>: {}"
    }

Inside high-level-feature:
install.sh:
nanolayer install devcontainer-feature <dependency-feature>

Inside dependency-feature:
devcontainer-feature.json:
...
    "containerEnv": {
      "PATH": "/some/path:${PATH}"
    }

I'm wondering if this discrepancy is intentional? If the tool can inspect the environment of the dependency feature, why not inject it into the Dockerfile instead of reconciling at runtime? If this is intentional, what is the recommended best-practice in this case? I've seen that some features resort to injecting the environment variables into shell init scripts, but this is not generally a robust solution. As it stands, the generated images are in such cases only usable (without modification) through devcontainer tooling. Of course the high-level feature can also set those environment variables, but if multiple features are involved (or if the configuration changes) this becomes difficult to manage.

Hi 👋
Thanks for opening the issue!

I'm wondering if this discrepancy is intentional? If the tool can inspect the environment of the dependency feature, why not inject it into the Dockerfile instead of reconciling at runtime?

Looping in @chrmarti @joshspicer to help provide their insights on this question.

what is the recommended best-practice in this case?

. My devcontainer.json uses a feature that itself installs another feature via the nanolayer tool - this is a pattern that many of the contributed features use.

@rokroskar Have you looked at the proposal for Feature dependencies, which adds the new dependsOn property?

A new property dependsOn can be optionally added to the devcontainer-feature.json. This property mirrors the features object in devcontainer.json. Adding Feature(s) to this property tells the orchestrating tool to install the Feature(s) (with the associated options, if provided) before installing the Feature that declares the dependency.

In the meanwhile, I wonder if the nanolayer tool can be replaced by the dependsOn property - which should ideally resolve the inconsistencies with the environment variables.
**Note: This new dependsOn property is added to the CLI with https://github.com/devcontainers/cli/pull/530 which is currently in preview.

Thanks for the quick follow up @samruddhikhandale, I missed this proposal and it's exactly what I was looking for. That will make feature writing much cleaner! I will close this now and test the preview version. Thanks!


Update Kolibri to 0.15.7

Unfortunately, the release doesn't seem to be on PyPI yet, so I used the released wheel directly from github. We can wait a couple days to see if it gets there.

The PyPI release was done after a prod, so I updated the PR to use that.


Made user selected course names override original course names when available

Closes #88
It looks like the canvas API will add an original_name field to courses that have a custom nickname assigned, so I modified getCourseNames to check for the existence of that field and return the user's preferred course name instead. Let me know if you would prefer a different approach.

Thanks, everything should have been addressed now after some wrangling with git.

done


Title doesn't support apostrophe

Add a link
Edit the link
Add an apostrophe in the title (e.g. Bob's link)
Click 'Save' (it doesn't work)
Remove the apostrophe (e.g. Bobs link) and click 'Save' (now it works)

Is there a technical reason why apostrophes aren't supported in the title?  If no, can we please add support?  I think it will allow the titles to be more descriptive.

I am using the latest version, and did not find this problem

Fixed in 1.8


Azure Site Recovery - SDK changes for replicationEligibilityResults, test failover settings, and resource rename.

Swagger PRs (both approved and merged)
AzureSiteRecovery - Adding new properties for test failover and resource rename.
Adding swagger changes for GET and LIST replicationEligibilityResults API

Hi @punit1396 please write tests to cover new operations, thanks.
And please check in the .txt file generated when you run generate.ps1(details)

Hi @isra-fel I have pushed changes for the tests and generated txt file. Could you review this once again?


More complex headers can cause export style exceptions.

Our company requires some information to be added to the header of the exported table. After I add it, the echo in layui is normal, but it is messed up when exporting excel.

How is the HTML table being generated?  Can you make that available somewhere?


Warn before Generator is invoked and might override uncommited changes

What problem does this feature solve?
If you want to add a plugin after you have done some work, some plugins may change files of the project. I just lost my whole day's work. I believe a lot of people ran into this kind of disaster. PLEASE show some alert if the current project is not empty.
What does the proposed API look like?
Prompt some BIG alert when adding plugins.

We have this BIG warning in our docs:

WARNING
It is recommended to commit your project's current state before running vue add, since the command will invoke the plugin's file generator and potentially make changes to your existing files.

And I don't think users will apprechiate a BIG warning in their console everytime they add plugin, don't you think?

I just lost my whole day's work

I'm not trying to be a smartass, but don't you use version control or something?

@LinusBorg Yes. I have seen that warning before. And it's my carelessness that led myself to this. But I'm wondering is it safe to give third-party plugins permission to modify user's local files, especially their codes? If we can detect that the project has been modified a lot and give the user an alert (maybe a small one), we can save many lives? After all running vue add might be dangerous.

Maybe we should detect if we are in a git repository which will be the case most of the time since vue cli creates one by default, and then automatically commit everything before invoking the plugin?

Good idea. Alternatively we could bail if we detect any uncommitted changes, ask the user to commit their work and run the command again.
That way we don't force a commit on anyone that they might not want (or that could fail if they have commitizen or something similar checking  commit message format.
And for projects without git ( an edge case) we could always display a warning and ask for confirmation.

Unassigned myself as I don't have the capacity to work on this right now.

saved by a previous build...
If someone run into this... how to call it..., well, check if you have a fresh /dist folder
just serve the dist folder and open it on browser
if you ran the build script and you had sourcemap on, then you'll find your code in the browser (source tab)

Implemented in #4275
Released as v4.0.0-alpha.5


Headings

If headings (and subheadings) are internally defined in the PDF file, these headings can be very easily distinguished and extracted from the generated JSON file when calling Burdoc. If there are no such internally headings (and subheadings), all the headings can be seen in the JSON file mixed together with the describing text, tables etc. etc.
How is it possible to distinguish and extract (for instance by using Regex) from the generated JSON file ONLY all the headings (and subheadings), if there are no internally headings (and subheadings) internally in the PDF file and defined in the "toc" section?
Investigation.pdf
Investigation.txt

Sorry for the delayed reply! Burdoc actually already makes a best effort attempt to do this! If you look in the produced JSON file there is a top-level entry called 'page_hierarchy', which contains all headings detected in the text. Unfortunately Burdoc currently doesn't handle maths so in your example a lot of formulas are extracted as 'h6' headings but it looks like it correctly identifies all other headings aside from the document title as 'h5' entries.
The following code shows how to get the page headings and then get all content between the first heading found and the 2nd.
Hope this helps!
import json

#Load data
with open("investigation.txt") as f:
    extract = json.load(f)

headings = []
#Get all 'h5' headings from document
for page,headings in extract['page_hierarchy].items():
    for h in headings:
        if h['assigned_heading'] == 'h5':
            headings.append(h)

first_content = []
page = heading[0]['page']
index = heading[0]['index'][0]

#Iterate over all items until we reach the next heading
while page < heading[1]['page'] or index < heading[1]['index'][0]:
  if index >= len(extract['content'][page]):
    page  += 1
    index = 0
    continue

  first_content.append(extract['content'][page][index]
  index += 1


Add Kitty port to other versions list.

Just looking through some of my open PRs. Are we able to get this merged? Should be good to go as-is! :)

Thanks!


feat(dynamicPostBody): dynamically pass the post body in run function

Create the ability for dynamically passing the request body in the “run()” function while using fetchye
Description
Currently the “run” function allows no argument . It simply invokes the API call by using the keys and options cached during the hooks initialization. The change proposed here is to modify the run function to pass the request body. If the request body is not null or empty append the body with options to trigger the API call. If it is empty , follow the current behavior of triggering the API using the cached key and options
Motivation and Context
While working on uplifting all the One-App modules of Customer Value Portal to V5, I encountered the scenario where the body of the POST request must be passed during the initial rendering of the components since useFetchye hooks expects all the options of the POST request during the initial load itself to create cache key. However, some of the scenarios requires the post request body to be generated dynamically according to certain events or some channel specific business uses cases hence the body cannot be generated upfront. I have gone through slack threads in the fetchy channel and have seen several people posted the similar constraints where fetchey doesn’t allow the body to be generated dynamically and pass it to the place where the POST request is triggered. The only solution suggested in the channel thread was defining a state for the attributes which needs to be generated dynamically. Using the state for each and every attribute that need to be dynamically passed to the POST body, causing unnecessary re-rendering of the modules and also requires significant efforts to refactor the whole components /modules leads to a major blocker for the migration of modules to One-App V5.
How Has This Been Tested?
Tested in a simple demo application. The gif demo is mentioned here
Example of POST request by passing body in "run" function

Example of POST request without passing body in "run" function

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (adding or updating documentation)
[ ] Dependency update

Checklist:

[ ] My change requires a change to the documentation and I have updated the documentation accordingly.
[ ] My changes are in sync with the code style of this project.
[ ] There aren't any other open Pull Requests for the same issue/update.
[ ] These changes should be applied to a maintenance branch.
[ ] I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?
No impact to developers using Fetchye. The implementation works for both the scenarios where the request body can be initialized during the call to useFetchye call or dynamically pass it when calling the run function to trigger the API call.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Binilkks do you mind sharing what you have in the animated gifs as text? I get dizzy by looking at them and they are low res

Hi @Binilkks, thank you for putting the time and effort in raising this PR, for the example and scenario provided we suggest that you use native fetch instead of fetchye. Fetchye is a react hooks based caching fetching library and the given example does not line up with its intended use case and I don't believe its providing you any value.
If you are really keen on using Fetchye for this take a close look at the deferred execution example which manages form data and passes to useFetchye.
Please provide more details if you disagree

Hi @Binilkks, thank you for putting the time and effort in raising this PR, for the example and scenario provided we suggest that you use native fetch instead of fetchye. Fetchye is a react hooks based caching fetching library and the given example does not line up with its intended use case and I don't believe its providing you any value.
If you are really keen on using Fetchye for this take a close look at the deferred execution example which manages form data and passes to useFetchye.
Please provide more details if you disagree

Hi @JAdshead Thanks for sharing the review comments.
As i mentioned the PR description , Even if I use the deferred execution , I still have to define the request body upfront. Passing the request body dynamically to a POST request is a common scenario and can you please suggest how it can be implemented with the current version of fetchey without using state variable.

This is my scenario where the post body can be generated only after certain events occurs and it won’t be available upfront.

const { run } = useFetchye(' http://example.com/api/payment', {
   defer: true,
    method: 'POST',
    headers: {
      'Content-Type': 'application/json',
    },
    body:{…postBody},
  });

@giulianok Please find the code block mentioned in GIF.
const { run } = useFetchye(' http://example.com/posts', {
  defer: true,
   method: 'POST',
   headers: {
     'Content-Type': 'application/json',
   }
 });

const handleClick = async () => {
const { data, error } = await run({
body: {
title: 'foo',
userID: 1,
body: "bar"
}
});
}

I am struggling to see why this is required, please can you provide a different example ? For what you have posted you can achieve a basic example of whats required leveraging useState. If i am missing something please can you provide a more thorough example
Here is a rough example using useFetch:
export default function App() {
  const [someValue, setSomeValue] = React.useState("");
  const { isLoading, run } = useFetchye(
    "https://bulyq.sse.codesandbox.io/profile",
    {
      defer: true,
      method: "POST",
      headers: {
        "Content-Type": "application/json"
      },
      body: JSON.stringify({ someValue })
    }
  );

  const handleInputChange = (e) => {
    setSomeValue(e.target.value);
  };

  const onSubmit = async (e) => {
    e.preventDefault();
    const { data } = await run();
    if (data.ok) {
      // success!!
    }
  };

  return (
    <form>

        Name:
        <input
          name="name"
          type="text"
          value={someValue}
          onChange={handleInputChange}
          disabled={!!isLoading}
        />

      {isLoading ? (

 Loading..

      ) : (
        <button type="button" onClick={onSubmit}>
          Submit
        </button>
      )}
    </form>
  );
}

Here is a very rough and quick example without fetchye:
export default function Poster() {
  const [someValue, setSomeValue] = React.useState("");
  const [isLoading, setIsLoading] = React.useState(false);

  const submit = async (event) => {
    event.preventDefault();
    setIsLoading(true);
    await fetch("https://bulyq.sse.codesandbox.io/profile", {
      method: "POST",
      headers: {
        "Content-Type": "application/json"
      },
      body: JSON.stringify({ someValue })
    });
    setIsLoading(false);
  };

  const handleInputChange = (e) => {
    setSomeValue(e.target.value);
  };

  return (
    <form>

        Name:
        <input
          name="name"
          type="text"
          value={someValue}
          onChange={handleInputChange}
          disabled={!!isLoading}
        />

      {isLoading ? (

 Loading..

      ) : (
        <button type="button" onClick={submit}>
          Submit
        </button>
      )}
    </form>
  );
}


Enable using hipcc as the CXX compiler

If we're using HIP-Clang to compile, we can allow the hipcc as CXX compiler.

Did you try building rocRAND using hipcc on ROCm platform?

Yes, it builds with CXX=/opt/rocm/hip/bin/hipcc option added to cmake command. It builds fine, but running into a 19 of 26 test failures on HIP-Clang. We are working on a fix, and will make a PR for that

Yes, it builds with CXX=/opt/rocm/hip/bin/hipcc option added to cmake command.

ok, in that case: LGTM, I'll merge in 10 minutes.

PR for that

This PR will be for rocRAND or for HIP-Clang?

Still investigating root cause, but more likely for HIP-Clang


Plugging an iPhone into a Mac causes ideviceinfo error

Plugging an iPhone into a Mac caused the following error to occur when running 'flutter doctor'. This went away after the phone was unplugged.
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.5.4-hotfix.1, on Mac OS X 10.14.4 18E226, locale en-US)
⣻Unhandled exception:
Exception: ideviceinfo returned an error:
ERROR: Could not connect to lockdownd, error code -2

#0      IMobileDevice.getInfoForDevice (package:flutter_tools/src/ios/mac.dart:141:9)
<asynchronous suspension>
#1      IOSDevice.getAttachedDevices (package:flutter_tools/src/ios/devices.dart:156:55)
<asynchronous suspension>
#2      IOSDevices.pollingGetDevices (package:flutter_tools/src/ios/devices.dart:110:57)
#3      PollingDeviceDiscovery.devices (package:flutter_tools/src/device.dart:186:52)
<asynchronous suspension>
#4      DeviceManager.getAllConnectedDevices (package:flutter_tools/src/device.dart:114:46)
<asynchronous suspension>
#5      DeviceValidator.validate (package:flutter_tools/src/doctor.dart:705:54)
<asynchronous suspension>
...

    ✗ libimobiledevice and ideviceinstaller are not installed or require updating. To update, run:
        brew uninstall --ignore-dependencies libimobiledevice
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller

https://github.com/flutter/flutter/issues/12628

I just ran into the same issue, while the ideviceinfo issue resolved itself somehow, flutter doctor shouldn't crash when it happens, my crashing flutter doctor output:
 flutter doctor -v
[✓] Flutter (Channel master, v1.5.9-pre.244, on Mac OS X 10.14.4 18E227, locale en-US)
    • Flutter version 1.5.9-pre.244 at /Users/amirha/git/flutter/flutter
    • Framework revision bcae3563d4 (65 minutes ago), 2019-05-14 11:04:16 -0700
    • Engine revision a89cf80d4d
    • Dart version 2.3.1 (build 2.3.1-dev.0.0 a0290f823c)

⣻Unhandled exception:
Exception: ideviceinfo returned an error:
ERROR: Could not connect to lockdownd, error code -8

#0      IMobileDevice.getInfoForDevice (package:flutter_tools/src/ios/mac.dart:141:9)
<asynchronous suspension>
#1      IOSDevice.getAttachedDevices (package:flutter_tools/src/ios/devices.dart:157:55)
<asynchronous suspension>
#2      IOSDevices.pollingGetDevices (package:flutter_tools/src/ios/devices.dart:111:57)
#3      PollingDeviceDiscovery.devices (package:flutter_tools/src/device.dart:188:52)
<asynchronous suspension>
#4      DeviceManager.getAllConnectedDevices (package:flutter_tools/src/device.dart:116:46)
<asynchronous suspension>
#5      DeviceValidator.validate (package:flutter_tools/src/doctor.dart:705:54)
<asynchronous suspension>
#6      Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:129:52)
#7      Doctor.diagnose (package:flutter_tools/src/doctor.dart:200:41)
#8      _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:49:6)
#9      Doctor.diagnose (package:flutter_tools/src/doctor.dart:190:24)
#10     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:48:39)
#11     _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:49:6)
#12     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:34:42)
#13     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:488:18)
#14     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:77:64)
#15     _rootRunUnary (dart:async/zone.dart:1132:38)
#16     _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#17     _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#18     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:639:45)
#19     Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#20     Future._complete (dart:async/future_impl.dart:473:7)
#21     _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#22     _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async-patch/async_patch.dart:33:20)
#23     _rootRun (dart:async/zone.dart:1124:13)
#24     _CustomZone.run (dart:async/zone.dart:1021:19)
#25     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#26     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#27     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#28     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:115:13)
#29     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:5)

Duple of: https://github.com/flutter/flutter/issues/24600


Include NR Browser agent via CDN

Add init block above everything

window.NREUM||(NREUM={});
NREUM.init={distributed_tracing:{enabled:true},privacy:{cookies_enabled:true}};

Include nr-loader for the specific agent type, replacing spa with the config option

https://js-agent.newrelic.com/nr-loader-spa-current.min.js

Include aggregator code

https://js-agent.newrelic.com/nr-spa-current.min.js

(Optional) Allow for customization of which version to include, augmenting the config

https://js-agent.newrelic.com/nr-loader-spa-<version number>.min.js
Most recent version is currently 1169 but there's no reason we can't load an arbitrary version.

Remove agent code from this repository

Rough reqs above. We still need to figure out the dynamic part of the url for lite vs. pro vs. pro+spa

Lite - http://js-agent.newrelic.com/nr-loader-rum-current.min.js
Pro - https://js-agent.newrelic.com/nr-loader-full-current.min.js
SPA (pro + spa) - https://js-agent.newrelic.com/nr-loader-spa-current.min.js

#10 Needs some additional testing.
To install:
npm install gatsby-plugin-newrelic@alpha


Insert values into the table currently fails with TableNotFoundException

Under section 7, "Insert values in the table", the SQL script referencing table dbo.Company fails with the following error:
org.apache.phoenix.schema.TableNotFoundException: ERROR 1012 (42M03): Table undefined. tableName=DBO.COMPANY
Changing the SQL script as follows fixes the error (changes in bold):
%jdbc(phoenix)
UPSERT INTO COMPANY VALUES(1, 'Microsoft');
UPSERT INTO COMPANY (name, company_id) VALUES('Apache', 2);

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bd02e3d6-ac34-2cd5-de30-e1cfe8df9bfc
Version Independent ID: 42ad6815-d0bf-5dbb-bcab-f1c21bdfa20e
Content: Run Apache Base queries in Azure HDInsight with Apache Phoenix
Content Source: articles/hdinsight/hbase/apache-hbase-phoenix-zeppelin.md
Service: hdinsight
GitHub Login: @sreekzz
Microsoft Alias: v-sreiyer

@cap273
Thanks for your feedback! We will investigate and update as appropriate.

@cap273
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


startDatePlaceholderText & endDatePlaceholderText not updating after props get update

I am using DateRangePicker in Child component. start date and end date getting as a props. After getting the props I can see the placeholder text for start date and end date are perfect. onDatesChange the placeholder update successfully with new dates which I have selected. But if I changed the dates in parent component, we are getting the updated dates as props, but placeholders are not updated. Can you please look into this.

@lamashree could you please provide small bug representation?

@lamashree  is the startDatePlaceholderText prop rendering at least once ( or the first time ) Beacuse I am using the  Component and when I add startDatePlaceholderText and set it its not being set.
I am just seeing the dates that I want to select. Let me know if you have similar issue.

@lamashree  is the startDatePlaceholderText prop rendering at least once ( or the first time ) Beacuse I am using the  Component and when I add startDatePlaceholderText and set it its not being set.
I am just seeing the dates that I want to select. Let me know if you have similar issue.


improve performance by removing use_tensor_core dependency

Motivation
According to the discussion of this PR
Modifications

flasinfer<=0.1.6

kv_cache_dtype
gqa_group_size
before
after

torch.float16, torch.half, torch.bfloat16
8
use_tensor_cores=False
use_tensor_cores=True

torch.float8_e4m3fn, torch.float8_e5m2
[1,2,4,8]
use_tensor_cores=False
use_tensor_cores=True

E2E Test

A100(40GB)

python -m sglang.launch_server --model-path {Yi-1.5-9B-Chat}

python -m sglang.bench_serving --backend sglang --model {Yi-1.5-9B-Chat} --dataset-name random --random-output-len 4096 --num-prompts 32

Throughput: 931 toks/s -> 1171 toks/s
Median ITL: 20.56 ms -> 18.97  ms

# before
============ Serving Benchmark Result ============
Backend:                                 sglang
Traffic request rate:                    inf
Max reqeuest concurrency:                not set
Successful requests:                     32
Benchmark duration (s):                  87.96
Total input tokens:                      17108
Total generated tokens:                  64826
Total generated tokens (retokenized):    54217
Request throughput (req/s):              0.36
Input token throughput (tok/s):          194.49
Output token throughput (tok/s):         736.98
Total token throughput (tok/s):          931.47
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   46408.83
Median E2E Latency (ms):                 39137.18
---------------Time to First Token----------------
Mean TTFT (ms):                          1150.39
Median TTFT (ms):                        1517.29
P99 TTFT (ms):                           1581.45
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          21.67
Median TPOT (ms):                        20.82
P99 TPOT (ms):                           24.65
---------------Inter-token Latency----------------
Mean ITL (ms):                           22.70
Median ITL (ms):                         20.56
P99 ITL (ms):                            39.10
==================================================

# after
============ Serving Benchmark Result ============
Backend:                                 sglang
Traffic request rate:                    inf
Max reqeuest concurrency:                not set
Successful requests:                     32
Benchmark duration (s):                  69.94
Total input tokens:                      17108
Total generated tokens:                  64826
Total generated tokens (retokenized):    57593
Request throughput (req/s):              0.46
Input token throughput (tok/s):          244.62
Output token throughput (tok/s):         926.93
Total token throughput (tok/s):          1171.56
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   39461.97
Median E2E Latency (ms):                 37171.11
---------------Time to First Token----------------
Mean TTFT (ms):                          1157.81
Median TTFT (ms):                        1529.05
P99 TTFT (ms):                           1592.79
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          19.20
Median TPOT (ms):                        19.14
P99 TPOT (ms):                           21.97
---------------Inter-token Latency----------------
Mean ITL (ms):                           19.21
Median ITL (ms):                         18.97
P99 ITL (ms):                            22.05
==================================================

python -m sglang.launch_server --model-path {Meta-Llama-3.1-8B-Instruct-FP8} --kv-cache-dtype fp8_e5m2

python -m sglang.bench_serving --backend sglang --model {Meta-Llama-3.1-8B-Instruct-FP8} --dataset-name random --random-output-len 4096 --num-prompts 32

Throughput: 1410 toks/s -> 1735 toks/s
Median ITL: 14.79 ms -> 11.89  ms

# before
============ Serving Benchmark Result ============
Backend:                                 sglang
Traffic request rate:                    inf
Max reqeuest concurrency:                not set
Successful requests:                     32
Benchmark duration (s):                  58.09
Total input tokens:                      17108
Total generated tokens:                  64826
Total generated tokens (retokenized):    64747
Request throughput (req/s):              0.55
Input token throughput (tok/s):          294.51
Output token throughput (tok/s):         1115.97
Total token throughput (tok/s):          1410.49
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   31550.18
Median E2E Latency (ms):                 30155.63
---------------Time to First Token----------------
Mean TTFT (ms):                          1366.20
Median TTFT (ms):                        1652.97
P99 TTFT (ms):                           1671.34
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          14.98
Median TPOT (ms):                        15.06
P99 TPOT (ms):                           15.91
---------------Inter-token Latency----------------
Mean ITL (ms):                           14.91
Median ITL (ms):                         14.79
P99 ITL (ms):                            17.01
==================================================

# after
============ Serving Benchmark Result ============
Backend:                                 sglang
Traffic request rate:                    inf
Max reqeuest concurrency:                not set
Successful requests:                     32
Benchmark duration (s):                  47.21
Total input tokens:                      17108
Total generated tokens:                  64826
Total generated tokens (retokenized):    64799
Request throughput (req/s):              0.68
Input token throughput (tok/s):          362.41
Output token throughput (tok/s):         1373.26
Total token throughput (tok/s):          1735.67
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   25458.49
Median E2E Latency (ms):                 24172.10
---------------Time to First Token----------------
Mean TTFT (ms):                          1374.96
Median TTFT (ms):                        1651.89
P99 TTFT (ms):                           1669.89
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          12.07
Median TPOT (ms):                        12.01
P99 TPOT (ms):                           13.47
---------------Inter-token Latency----------------
Mean ITL (ms):                           11.89
Median ITL (ms):                         11.89
P99 ITL (ms):                            13.27
==================================================

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

Previously, we found an accuracy regression if we remove this. Did you test the accuracy of all models?

result of test_eval_accuracy_large.py

Model
kv-cache-dtype
eval_name
Before
After

Yi-1.5-9B-Chat
auto
mmlu
0.641
0.645

humaneval
0.616
0.615

mgsm_en
0.868
0.880

Meta-Llama-3.1-8B-Instruct-FP8
fp8_e5m2
mmlu
0.708
0.707

humaneval
0.661
0.660

mgsm_en
0.860
0.852

What is your hardware?

A100(40GB)

Can you test the command in this PR https://github.com/sgl-project/sglang/pull/1511?
If it passes, we can merge this.

python -m sglang.launch_server --model meta-llama/Meta-Llama-3.1-70B-Instruct --tp 4 --enable-p2p-check

python python/sglang/test/run_eval.py --host <IP_ADDRESS> --port 30000 --model meta-llama/Meta-Llama-3.1-70B-Instruct --eval-name humaneval

Run the test on L20*4 twice, here's the result:

Round
Before
After

First
0.751
0.750

Second
0.748
0.750

Thanks for testing this! The previous bug only happens on certain hardware. We reproduced it once on 8xA100 40GB. That is why I am asking which hardware you are using. Is it possible for you to run it again on 8xA100 40GB with the exact command?
Especially @yzh119 also acknowledged it is a bug so we need to very careful here.

Run the test on 8xA100 40GB, here's the result:

Round
Before
After

First
0.752
0.750

Second
0.750
0.749

Third
0.750
0.751

python -m sglang.launch_server --model meta-llama/Meta-Llama-3.1-70B-Instruct --tp 8 --enable-p2p-check --mem-fraction-static 0.8

python python/sglang/test/run_eval.py --host <IP_ADDRESS> --port 30000 --model meta-llama/Meta-Llama-3.1-70B-Instruct --eval-name humaneval