Mesh Quality Discrepancy Using Scannet++

Hi~Thanks for sharing the code!
I am using scene 8b5caf3398 from the Scannet++ dataset for training but the mesh extraction has not yielded the expected results.
First, I processed data into COLMAP format, and generated omnidata normals and mono-depth estimates.
Then, I trained the model for 30k iterations:
ns-train dn-splatter --pipeline.model.use-depth-loss True --pipeline.model.mono-depth-lambda 0.2 --pipeline.model.use-depth-smooth-loss True --pipeline.model.use-normal-loss True --pipeline.model.normal-supervision mono coolermap --data [DATASET_PATH] --load_normals True
Finally, I attempted mesh extraction following your suggestions:
gs-mesh dn --load-config [PATH] --output-dir [PATH]
But the results were very unsatisfactory:
https://github.com/maturk/dn-splatter/assets/65186462/6a3dc84d-c54e-450e-b9d3-4264f1c11295
I tried other methods and found the sugar-coarse method performs better:
gs-mesh sugar-coarse --load-config [PATH] --output-dir [PATH]
https://github.com/maturk/dn-splatter/assets/65186462/c5579dfb-a246-4c9e-bcad-25ca309f4b38
However, it still falls short of the quality shown in your paper. I am not sure if I followed the same settings as your paper.
Could you provide some guidance or suggestions to improve the quality of the mesh to more closely resemble the results in your paper?
Thanks!

Hi @Valentina-Zhang, can you use the dedicated scannetpp dataparser (instead of coolermap) when using scannett data? We use the iPhone depth sequences "b20a261fdf" and "8b5caf3398" from ScanNet++. In the paper all results, except table 5 in the ablations, use real sensor depths for supervision. The performance of monocular supervision is unfortunately not on par with sensor supervision on difficult and larger indoor scenes.
Can you try the command:
ns-train dn-splatter
                 --pipeline.model.use-depth-loss True \
                 --pipeline.model.sensor-depth-lambda 0.2 \
                 --pipeline.model.use-depth-smooth-loss True \
                 --pipeline.model.use-normal-loss True \
                 --pipeline.model.normal-supervision (mono/depth) \
                 scannetpp --data PATH_SCANNET_DATA_ROOT --sequence 8b5caf3398

More options specific to the scannet++ dataset can be found in the configs here

Hi @Valentina-Zhang, can you use the dedicated scannetpp dataparser (instead of coolermap) when using scannett data? We use the iPhone depth sequences "b20a261fdf" and "8b5caf3398" from ScanNet++. In the paper all results, except table 5 in the ablations, use real sensor depths for supervision. The performance of monocular supervision is unfortunately not on par with sensor supervision on difficult and larger indoor scenes.
Can you try the command:
ns-train dn-splatter
                 --pipeline.model.use-depth-loss True \
                 --pipeline.model.sensor-depth-lambda 0.2 \
                 --pipeline.model.use-depth-smooth-loss True \
                 --pipeline.model.use-normal-loss True \
                 --pipeline.model.normal-supervision (mono/depth) \
                 scannetpp --data PATH_SCANNET_DATA_ROOT --sequence 8b5caf3398

More options specific to the scannet++ dataset can be found in the configs here
@maturk
Hello, I used the above command to train the 8b5caf3398 sequence in the scan++dataset. But during testing, it was found that the generated Gaussian points were quite messy, and the rendered depth map and normal map surfaces were not very smooth. Is this normal?

And the rgb_psnr is only 12.11 in the json file.

I change the version of nerfstudio and gsplat to 1.1.0 and 0.1.11. And the calculation of PNSR is normal.

I change the version of nerfstudio and gsplat to 1.1.0 and 0.1.11. And the calculation of PNSR is normal.

@Sugar55888, what version of pytorch are you using? There are known issues with pytorch 2.0.1 (I recommend installing pytorch 2.1.2+ if you have an older version).
I have just tested on the b20a261fdf scene from scannet++ with the following command:
ns-train dn-splatter --pipeline.model.use-depth-loss True --pipeline.model.sensor-depth-lambda 0.2 --pipeline.model.use-depth-smooth-loss True --pipeline.model.use-normal-loss True  scannetpp --data ../gstream/datasets/scannetpp/

Here are the metrics from ns-eval:
{
  "experiment_name": "unnamed",
  "method_name": "dn-splatter",
  "checkpoint": "outputs/unnamed/dn-splatter/2024-06-26_101439/nerfstudio_models/step-000029999.ckpt",
  "results": {
    "rgb_psnr": 21.39521598815918,
    "rgb_psnr_std": 3.4141998291015625,
    "rgb_ssim": 0.8932474851608276,
    "rgb_ssim_std": 0.037611667066812515,
    "rgb_lpips": 0.16607534885406494,
    "rgb_lpips_std": 0.0638774186372757,
    "depth_abs_rel": 0.036066967993974686,
    "depth_abs_rel_std": 0.019739612936973572,
    "depth_sq_rel": 0.02396574430167675,
    "depth_sq_rel_std": 0.022433273494243622,
    "depth_rmse": 0.24497883021831512,
    "depth_rmse_std": 0.10275601595640182,
    "depth_rmse_log": 0.036185991019010544,
    "depth_rmse_log_std": 0.024228833615779877,
    "depth_a1": 0.9641259908676147,
    "depth_a1_std": 0.038147591054439545,
    "depth_a2": 0.986823558807373,
    "depth_a2_std": 0.024890735745429993,
    "depth_a3": 0.9960512518882751,
    "depth_a3_std": 0.009821201674640179,
    "num_rays_per_sec": 128616520.0,
    "num_rays_per_sec_std": 23672480.0,
    "fps": 46.575870513916016,
    "fps_std": 8.572510719299316
  }
}

@maturk Hi, I used pytorch 2.0.1 because the readme mentioned that pytorch 2.1.2 may have TypeError: expected size to be one of int or Tuple [int] or Tuple [int, int] or Tuple [int, int, int], but got size with types [<class' numpy. int64 '>,<class' numpy. int64'>] I will upgrade my PyTorch version for testing. Thank you!

I see, yes this is a bit tricky because zoe-depth also has known issues with higher pytorch versions XD But that is only if you want to use zoe-depth. I found these issues also in Nerfstudio, and right now the requirement for Nerfstudio should be torch>=2.1.2. I have noted this in a few issues here and  here. I think its due to @torch_compile(), although, I have not looked too deeply into it.

I compared the performance of two different PyTorch versions of dn-splatter on the 8b5caf3398 sequence in scannet++. I found that their training speed and PNSR are similar, but in PyTorch 2.0.1, the predicted normal vector map is smoother.

The right figure shows the prediction results in the dn-splatter with pytorch 2.0.1.

I compared the performance of two different PyTorch versions of dn-splatter on the 8b5caf3398 sequence in scannet++. I found that their training speed and PNSR are similar, but in PyTorch 2.0.1, the predicted normal vector map is smoother.  The right figure shows the prediction results in the dn-splatter with pytorch 2.0.1.

And what is the left figure? pytorch 2.1.2 and gsplat v1.0.0 and nerfstudio v1.1.3? What is the gsplat and nerfstudio version for the right figure?

The left figure is pytorch 2.1.2 and gsplat v1.0.0 and nerfstudio v1.1.3.  And the right figure is pytorch 2.0.1 and gsplat v0.1.11 and nerfstudio v1.1.0.  I use the command as follows:
ns-train dn-splatter
--pipeline.model.use-depth-loss True
--pipeline.model.sensor-depth-lambda 0.2
--pipeline.model.use-depth-smooth-loss True
--pipeline.model.use-normal-loss True
--pipeline.model.normal-supervision mono
scannetpp --data PATH_SCANNET_DATA_ROOT --sequence 8b5caf3398

The left figure is pytorch 2.1.2 and gsplat v1.0.0 and nerfstudio v1.1.3. And the right figure is pytorch 2.0.1 and gsplat v0.1.11 and nerfstudio v1.1.0. I use the command as follows: ns-train dn-splatter --pipeline.model.use-depth-loss True --pipeline.model.sensor-depth-lambda 0.2 --pipeline.model.use-depth-smooth-loss True --pipeline.model.use-normal-loss True --pipeline.model.normal-supervision mono scannetpp --data PATH_SCANNET_DATA_ROOT --sequence 8b5caf3398

Thank you @Sugar55888, I will look into this more closely.

@maturk Thanks for your reply!

Hi @Sugar55888. I have fixed the issue now in #49. I was able to replicate your results.
before the fix in the above PR:  "rgb_psnr": 22.428760528564453

after fix in the above PR: "rgb_psnr": 22.47365951538086

There is very marginal difference in PSNR results, however, the normal smoothness is significantly better. Here I also evaluated on a scene from Replica:
Before the fix in the above PR:

After fix in the above PR:

Thanks for your interest and helping me debug the code! :)

@maturk Thank you for your excellent work!

Here is a comparison of expected results using either monocular depth supervision with scale alignment, vs pearson correlation loss, vs sensor depth regularization on mesh reconstruction metrics.


Any chance for this to work with Stability Matrix/ComfyUI?

Looks mighty impressive, but as I've transitioned to Stability Matrix as well as ComfyUI, I can't help but wonder :)

ComfyUI has an API, so in theory Dream Factory could be made to work with it, but it'd be a fair amount of work. At the moment, my understanding is that Auto1111 and Comfy basically support roughly the same feature set, and the difference between them is mostly UI/workflow - so I don't see a super compelling reason to support it at this time.
Dream Factory should work alongside whatever tool(s) you currently use just fine, though, assuming you're willing to re-install Auto1111.


Review the use of const and @constCast throughout the library

The use of @constCast is generally discouraged, but it's used throughout the library in the Command, Option, and Value types. There two main reasons for this:

A desire to use const as a sort of equivalent to val in Kotlin, wherein the data can be made immutable to external users but still be mutated internally.
A lack of understanding of how const works. Namely, the fact that it applies to memory directly instead of the data or Type. Because of this, the compiler can make assumptions about const data and even choose to move it to the rodata section of a program.

While the library ostensibly works fine in its current state, this is an item that's worth reviewing for completeness down the line.

Upon initial inspection, the current usage of const is required to share the same Type between comptime and runtime. With the runtime instances being allocated, the usage of const and @constCast might be ok. That said, it should still be looked at further.


/tierlist API - Review

This is purely to get some discussion going as the basic API is working for /tierlist/:id
Current implementation:
tierlist.GET("/", getAllTierlists)
// fetches all tier lists.

tierlist.GET("/:id", getTierlistById)
// fetches a specific tierlist (/tierlist/1)

tierlist.POST("/", createTierlist)
// posts a tier list with the below body:

tierlist.PUT("/:id", updateTierlist)
// updates a tier list by adding either tiers or items (to be discussed and expanded on)

tierlist.DELETE("/:id", deleteTierList)
// deletes a tier list

Discussion for the PUT method.
At the moment, the API can only update the tier list by adding tiers/items. We cannot update or delete tiers/items already in the database.
We may have to create endpoints for these operations moving forward like so:
    tierlist := r.Group("/tierlist")
    ...

    // tier routes
    tierlist.POST("/:id/tier", addTier)
    tierlist.PUT("/:id/tier/:tierId", updateTier)
    tierlist.DELETE("/:id/tier/:tierId", deleteTier)

    // item routes
    tierlist.POST("/:id/item", addItem)
    tierlist.PUT("/:id/item/:itemId", updateItem)
    tierlist.DELETE("/:id/item/:itemId", deleteItem)

This should keep things cleaner (?) and working how we intend.

For now, I have setup endpoints for adding, updating and deleting tiers and items. GORM was having issue with associations when trying to save the full tierlist object through the main update tierlist.
Currently, the payload for each is:
Tier
{
	"tierlist_id": 1,
	"text": "Tier1",
	"colour": "#000000",
}

Item
{
	"tierlist_id": 1,
	"text": "SUPER",
	"image": "HTTP://COOLIMAGE.com",
	"tier_text": "S"
}

At the moment, the tierlist is currently within the payload body, but this can be changed to accept the params from the endpoint.


I using Pdf-node-creator for generating pdf in my node application, It was working fine in local environment , But in production I get the below Error

[Error: ENOENT: no such file or directory, open 'C:\tmp\html-pdf-11516.pdf'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\tmp\html-pdf-11516.pdf'
}

is your production environment also windows?
If so, maybe permissions issues on c:\tmp.
If this is a docker image, you need to make sure you have write access and a volume attached to it.

yes my production environment is also windows, no there is no temp file in c:/ .
Actually I found the answer that in virtual machines we don't have permission to use temp memory so we got this error.

i got the same problem on production using heroku. The solution for me was creating a new env var OPENSSL_CONF with value /dev/null.
https://prnt.sc/VaOabzLAXFlO
i added to heroku env vars and it worked for me.

@scush989898 Thank you very much. I struggled with this problem for close to 5 days now. Your solution worked for me

@scush989898 please will you mind to share why this solution fixed the problem?


feat: better hook for handling auth errors

Helps us fix a bug where symbol-upload retries after auth failure.

:tada: This PR is included in version 8.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[blog] Introducing Vue 3 & Web Components in Hue Query Editor

What changes were proposed in this pull request?
Blogpost on Introducing Vue 3 & Web Components in Hue Query Editor
How was this patch tested?
Using hugo serve

Big nice one!
It is live now https://gethue.com//posts/


chore: update formatting for generated code

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:a40ca4dd4ef031c0ded4df4909ffdf7b3f20d29b23e682ef991eb60ba0ca6025
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/vision/artman_vision_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p1beta1.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p2beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p2beta1.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p3beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p3beta1.
synthtool > Running generator for google/cloud/vision/artman_vision_v1p4beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/vision-v1p4beta1.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test-grpcjs.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test-grpcjs.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
Skipping: README.md
codecov.yaml
renovate.json
Skipping: samples/README.md
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1p3beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1p4beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > No replacements made in **/doc/google/protobuf/doc_timestamp.js for pattern toISOString\], maybe replacement is not longer needed?

><EMAIL_ADDRESS>install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

><EMAIL_ADDRESS>postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1190 packages from 1331 contributors and audited 6232 packages in 23.757s
found 5 vulnerabilities (1 low, 2 moderate, 2 high)
  run `npm audit fix` to fix them, or `npm audit` for details

><EMAIL_ADDRESS>fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'

synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@callmehiphop can you dig into the flailing tests here? Maybe another brittle endpoint?


Possibility of multiple restraints acting on single atom for automatic restraints.

At present, automatically generated extremity restraints may have overlapping spheres of influence, meaning that a single atom can be part of multiple ligand restraint groups. That way it is acted upon by different restraints at the same time.
Having talked with Stefan about this, this may cause issues in more complex systems and should thus be flagged as an issue. I'm currently writing a patch for this which should be along shortly.

Resolved by #104 - closing.


[HOLD for payment 2024-11-20] [$250] mweb - Per diem - View your subscription link opens Subscription page then back to Workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Create a new workspace
Go to More features
Enable Per diem
Tap Upgrade
On upgrade success screen, tap View your subscription

Expected Result:
App will open subscription page
Actual Result:
App opens subscription page and then opens workspace editor page quickly.
This issue only happens when upgrading workspace to Control from Per diem feature
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[x] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/bcdd8673-64a7-46ba-af35-d9ce8c50b4b1
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021854641998677095618
Upwork Job ID:<PHONE_NUMBER>677095618
Last Price Increase: 2024-11-07
Automatic offers:

truph01 | Contributor | 104804112

Issue OwnerCurrent Issue Owner: @sakluger

Wouldn't block deployment because it's a small issue that can be solved quickly.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App opens subscription page and then opens workspace editor page quickly.
This issue only happens when upgrading workspace to Control from Per diem feature
What is the root cause of that problem?

Here we enable company cards, after enabling we are navigating the user to Workspace initial page

What changes do you think we should make in order to solve the problem?

We can pass a third parameter here disableRedirect = false:
https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/libs/actions/Policy/PerDiem.ts#L54
and update:
https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/libs/actions/Policy/PerDiem.ts#L107

    if (enabled && getIsNarrowLayout()  && !disableRedirect) {
        navigateWhenEnableFeature(policyID);
    }

and then we can pass true here as third param in:
https://github.com/Expensify/App/blob/daf0addf17040ae0b0ad76e9705d20a7143b9a39/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx#L84
What alternative solutions did you explore? (Optional)

PR is ready

@ntdiary payment is due tomorrow, please complete the BZ checklist by tomorrow. Thanks!

Thanks everyone!
Summarizing payment on this issue:
Contributor: @truph01 $250, paid via Upwork
Contributor+: @ntdiary $250, please request on Newdot

$250 approved for @ntdiary


encryption: split into RevisionLabelPodDeployer and StaticPodNodeProvider

The static pod controllers are only one way of deploying pods with revisioned resources. This PR split the StaticPodDeployer into a RevisionLabelPodDeployer and separates the static pod part into a StaticPodNodeProvider which returns the status.nodeStatus master node names.

/lgtm


How to add blacklist for random shortcut key displayed after Recent Projects and Most Recent Files

I want press 'q' to quit dashboard but sometimes 'q' is used by list file so I must enter a file then quit.How to fix it.

duplicate #297


[Feature Request]: Set a custom expiration time on request

Description
I would like to be able to set a longer expiry time on a session based on the device a user is signing in from.
It seems like getNewSessionExpiration can take arbitrary times, but createSession always calls getNewSessionExpiration with no parameters.
Is it possible to allow createSession to pass those follows through to allow for custom expiry times when creating a session?

Unfortunately no since we need to know how how long sessions lasts for when extending them. It has to be known global


Refactoring opportunity, maybe? 🤷🏾♂

Hey I was thinking that on this piece of the code on the prompt.ts we can refactor it. The value property on each option could be an anonymous function that do the actions specified on the if sequence. That way we can get rid of the "const x = answer === y" part and the different IF calculations.  Then you will only need to call answer() to execute the action.
Unless I'm not picking up something it seems to me like a good idea, and I could implement it if you want. Please let me know if Im wrong or if you want me to do it. 😄
const answer = await p.select({
    message: nonEmptyScript ? 'Run this script?' : 'Revise this script?',
    options: [
      ...(nonEmptyScript
        ? [
            { label: '✅ Yes', value: 'yes', hint: 'Lets go!' },
            {
              label: '📝 Edit',
              value: 'edit',
              hint: 'Make some adjustments before running',
            },
          ]
        : []),
      {
        label: '🔁 Revise',
        value: 'revise',
        hint: 'Give feedback via prompt and get a new result',
      },
      {
        label: '📋 Copy',
        value: 'copy',
        hint: 'Copy the generated script to your clipboard',
      },
      { label: '❌ Cancel', value: 'cancel', hint: 'Exit the program' },
    ],
  });

  const confirmed = answer === 'yes';
  const cancel = answer === 'cancel';
  const revisePrompt = answer === 'revise';
  const copy = answer === 'copy';
  const edit = answer === 'edit';

  if (revisePrompt) {
    await revisionFlow(script, key, apiEndpoint, silentMode);
  } else if (confirmed) {
    await runScript(script);
  } else if (cancel) {
    p.cancel('Goodbye!');
    process.exit(0);
  } else if (copy) {
    await clipboardy.write(script);
    p.outro('Copied to clipboard!');
  } else if (edit) {
    const newScript = await p.text({
      message: 'you can edit script here:',
      initialValue: script,
    });
    if (!p.isCancel(newScript)) {
      await runScript(newScript);
    }
  }

Works for me! Bonus point if you can add a unit test to verify the behavior is the same before and after

Somewhat related - I'm curious if it's possible add in the ability to select an option using a letter? So instead of hitting the down arrow to get to "Cancel," for example, one could just hit "X" and it would immediately select the cancel option.

Works for me! Bonus point if you can add a unit test to verify the behavior is the same before and after

Nice! I would then implement it on this next week is possible for me. I would try to set the Unit tests too.

Somewhat related - I'm curious if it's possible add in the ability to select an option using a letter? So instead of hitting the down arrow to get to "Cancel," for example, one could just hit "X" and it would immediately select the cancel option.

Mmm, this is interesting, although I like arrow keys as navigation on the terminal menus. I would see if their is a good way to implement a relation of keyboard letters to each command also.

Mmm, this is interesting, although I like arrow keys as navigation on the terminal menus. I would see if their is a good way to implement a relation of keyboard letters to each command also.

Oh for sure, keep the arrow key navigation because I think that's the natural thing most people will reach for. But if possible, I think having the option to set a letter as a shortcut for the options might be nice/convenient. :)

Closing Issue because a Pull Request has already been merged addressing this issue.
PR: #63


Complete the Agent Process for Generating New Code

General agent approach:

[x] - Get task from issues
[x] - Generate single safe name for task using GPT - github_management/issue_management.py - GitHubIssues class has a generate_branch_name(issue) method
[x] - Checkout new branch with safe name - use git_management/git_handler.py
[x] - Run the run_task method in agent/core.py with the body of the issue as the task_description
[ ] - Write test(s) for generated code
[ ] - Get test results (for individual test)
[ ] - Edit function and/or test code until until test passes
[ ] - Get test results (all)
[ ] - Try to fix any additional failing tests
[ ] - Once everything passes generate pull request for development branch
[ ] - Return to previous branch

This is the Code Writer agent.

And functionality now in code_management.test_writer - to be put in agent form.


Assign issues to milestones for release planning

Could you perhaps please assign open issues to milestones and (if possible) set a due date for the milestone. I'd like to get an idea what still needs to get done until the next version can be released.
A release of what is in master currently, would work for me as well.
cheers
-- thomas

I work on this for free in my spare time so it mainly depends when I can find time. I'm happy to do a release now as there several important changes.


Build panics when specify a glibc version

zig-sqlite commit
3d8e617c43d04
Zig version
0.12.0-dev.1800+559e216f3
Steps to reproduce
I am run an x86_64  linux and want to target to a diffirent glibc version.
╰─➤  uname -m -s -r
Linux 6.1.64-1-MANJARO x86_64

╰─➤zig build -Doptimize=ReleaseSafe -Dtarget=native-linux-gnu.2.28

thread 119243 panic: invalid enum value
/usr/lib/zig/lib/std/zig/CrossTarget.zig:616:46: 0x2dbd80 in zigTriple (build)
        try result.writer().print("-{s}.", .{@tagName(self.getAbi())});
                                             ^
/home/hequn/router/zig/zig-sqlite/build.zig:330:39: 0x2d6ccf in build (build)
            try cross_target.zigTriple(b.allocator),
                                      ^
/usr/lib/zig/lib/std/Build.zig:1883:43: 0x2c2b84 in runBuild__anon_6856 (build)
        .ErrorUnion => try build_zig.build(b),
                                          ^
/usr/lib/zig/lib/build_runner.zig:313:29: 0x2be702 in main (build)
        try builder.runBuild(root);
                            ^
/usr/lib/zig/lib/std/start.zig:585:37: 0x2a9a55 in posixCallMainAndExit (build)
            const result = root.main() catch |err| {
                                    ^
/usr/lib/zig/lib/std/start.zig:253:5: 0x2a9541 in _start (build)
    asm volatile (switch (native_arch) {
    ^
???:?:?: 0x8 in ??? (???)
Unwind information for `???:0x8` was not available, trace may be incomplete

Expected behaviour
This cross compile can compile successful.

This was fixed with #150. Please let me know if it didn't fix it for you.


[CSS] Remove off-screen nodes from the DOM

    {{#momentum plugin='css'}}
    {{#if toggle}}

...

    {{/if}}
    {{/momentum}}

When toggle goes back and forth between true and false often, I get a long list of
. I think it would be good if they were removed from the DOM?

My transition was 500s instead of 500ms, so the animation hadn't ended.

Reopening – the title still applies, but in a different situation. I'm guessing the CSS plugin uses an animation end hook to remove .in.offscreen or .out.offscreen, and in the latter case, remove the node. In situations where the animation does not complete, a potentially-long list of nodes are left behind in the DOM. In the above situation, that was due to a long duration, but in the below situation, I want an animation when it comes in but immediate disappearance when it goes out, and it looks like the display none prevents the animation from happening, and thus the node never gets removed:

Hi @lorensr - we have a timeout option to the CSS plugin to deal with exactly these kind of edge cases. Give it a go, let me know if you think the docs need updating.

Thanks, looks like this works:
{{#momentum plugin='css' timeout=1000}}

Would be nice to just add that as an example – shows where the argument
goes and the fact that it's an integer in ms versus '1s' string, etc.
On Wed, Apr 22, 2015 at 11:42 PM, Tom Coleman<EMAIL_ADDRESS>wrote:

Hi @lorensr https://github.com/lorensr - we have a timeout option to
the CSS plugin to deal with exactly these kind of edge cases. Give it a go,
let me know if you think the docs need updating.
—
Reply to this email directly or view it on GitHub
https://github.com/percolatestudio/meteor-momentum/issues/26#issuecomment-95462961
.


Controller stick moves focus in ItemList by multiple items

Godot version
3.5.1.stable, 4.0 (cf859db)
System information
Linux
Issue description
When moving up or down in an ItemList using a controller stick as ui_up and ui_down input, the focus is moved up or down every time there's a new input event with a slightly updated value of the stick up/down-axis, so it moves multiple items when moving the stick up or down one time.
Expected: the focus is moved by one item every time the stick leaves the inner deadzone
Steps to reproduce

Add a controller stick as input for ui_up and ui_down in the input map
Create an ItemList and fill it with items (via script)
Let the ItemList grab focus and preselect one item (via script)
Try to move up and down in the list with the controller stick

Minimal reproduction project
TEST.zip

Related to https://github.com/godotengine/godot/issues/35751 (same cause, same potential fix).

Can confirm it still happens in 4.3-dev4
Here's a quick and dirty fix instead anyone needs it. It can probably be solved in a better way, though
https://github.com/noidexe/godot/tree/itemlist-stick-navigation-quick-fix

This issue in Godot_v3.5.3-stable caused my steam build to fail review process. Maybe something should be added to the documentation to warn others?
From steam:
Your build failed because "Full Controller Support" category appears on the store page, but the game does not appear to fully support the controller. The user is not able to access all of the game's functions using only the controller. Keyboard/Mouse must not be required to use or quit the game.

Maybe something should be added to the documentation to warn others?

I feel adding a warning in the documentation would only be relevant if there's a suitable workaround we can document, such as using another Control node that would achieve similar functionality.
Also, it's entirely feasible to fix this issue (and is probably not that difficult). It's just that someone needs to be able to set enough time aside to implement and test the feature.


Test 2 2 failed

daxa_test_2_daxa_api_2_device.exe :
[FAILURE]: terminator_CreateDevice: Failed in ICD C:\Windows\system32\.\nvoglv64.dll vkCreateDevicecall
[[DAXA ASSERT FAILURE]]: validation error
msvc2019 (no clang), win8, VulkanSDK\<IP_ADDRESS>, Geforce 1060 6gb
I tried to fix it like here, there are errors along the chain, https://github.com/zeux/niagara/issues/18
Vulkan info : https://pastebin.com/wMUDUbmk

ICD stands for "Installable Client Driver". This sounds like an out-of-date driver issue. What driver version do you have? We require that your driver is Vulkan 1.3 compatible. I thought this would be checked in some way, but maybe not.

VkPhysicalDeviceDriverProperties:
driverID        = DRIVER_ID_NVIDIA_PROPRIETARY
driverName      = NVIDIA
driverInfo      = 473.81

Downloaded yesterday, vk api also yesterday;


Create a new logo in svg [searching for contributions]

I'm not a designer and I'm not able to do it alone.
Be creative and help me creating a cool svg to represent with a logo "angular-modal-gallery".
👍

I createad an icon, but if you want to make a better one, feel free to share it.


Improve shell not found error message

The current error message is sadly lacking:
: just --shell foo
error: Backtick could not be run because just could not find `sh`:
No such file or directory (os error 2)   |
39 | version = `sed -En 's/version[[:space:]]*=[[:space:]]*"([^"]+)"/v\1/p' Cargo.toml | head -1`
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The same error is also printed when a backtick fails with a not-found error, like ```bar := `not-a-command````. This should be improved as well.

The errors seem to be fine at the moment, don't they?

The problem with the error is that it says "just could not find sh", when really the problem is that just couldn't find the custom shell the user set, in this case foo, so it's a bit misleading.

I think that "subcommand" is probably confusing, since that usually refers to subcommands of multi-command programs, like cargo run and cargo build. "the shell" is probably better, i.e. "Recipe {} could not be run because just could not run the shell:".

I am sorry but I do not understand this error.
I am running
just

on Windows and getting back
error: Recipe `XXX` could not be run because just could not find the shell: program not found

I believe I do not have a shell installed in Windows? (for some reason)
The documentation on shell does not give an example on how to set the shell to cmd for example. I tried --shell cmd but this does not work.
Thanks in advance!

Is further work needed here?

@starthal Nice catch! I guess someone fixed this a while ago and the issue was never closed. I added tests for the error message in #2145.


Optimize commit_has_blob and commit_has_tree

Find a way to optimize this Function, using cache or another kind of index.

To improve the performance of this, we can add two LRU caches to store the most used blobs and trees info on memory. We can use this implementation from hashicorp: https://github.com/hashicorp/golang-lru
When a repo is already iterated, the cache should be purged.

All repos are iterated every time the function is executed (because we don't know where the targets are) and there is no repeated access to any commit, tree or blob during an execution, so an LRU cache that gets purged every time the repo is iterated is useless.


ARROW-2415: [Rust] Fix clippy ref-match-pats warnings.

It isn't necessary to use a reference in each pattern in a pattern
match and it is more readable to just dereference the match value.

I'd planned to do subsequent things separately ... there's already a separate issue + PR for the format! calls for example. That way, each set of changes is independent and handled separately if people disagree on the usefulness of a particular check.
Note that when is_empty is implemented for Bitmap, it should be self.bits.is_empty() hopefully rather than self.len != 0 ... but I had that queued up for a subsequent issue + PR.

it should be self.bits.is_empty() hopefully rather than self.len != 0

👍

I'd planned to do subsequent things separately

That's fine IMO. For the immediate fixes I don't think there's much ambiguity / need for discussion, but feel free to split up regardless.
Should we add a check in CI?

Should we add a check in CI?

Until clippy is part of rustup, I'm not sure. Since it is nightly only and sometimes it doesn't build for a day or two after compiler changes, it might introduce inconvenience.
We could mention it somewhere though and encourage people to check?

Yes, I tend to agree. Potentially we could pin to a specific nightly, but maybe more trouble than it's worth. Any idea what other Rust projects do?
CC @andygrove

I will look into that this week and add it to my list of PRs to submit if necessary.

LGTM. I haven't been using clippy but will take a look.

@pitrou :+1: yes please go ahead and merge

Ok, thanks!


SUBMARINE-700. [WEB] Refactor notebook page of Workbench

What is this PR for?
Refactor the architecture of notebook component in workbench. The new architecture is as below :

What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-700
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/755191807
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Thanks for your contribution! I have some suggestions. The form style now is not consistent with the experiment page (in the experiment, the form is floated above the list as we click "create experiment"). I think that form and list should be at the same routing path, just like what we do on the experiment page.

Thanks for your contribution! I have some suggestions. The form style now is not consistent with the experiment page (in the experiment, the form is floated above the list as we click "create experiment"). I think that form and list should be at the same routing path, just like what we do on the experiment page.

@ByronHsu  Thanks your review and suggestions. I will refactor page's style and component's routing with an unified architecture as soon as possible. Thanks a lot !

@ByronHsu  Thanks your review and suggestions. I will refactor page's style and component's routing with an unified architecture as soon as possible. Thanks a lot !

@ByronHsu Hi, I have readjusted the notebook form as the style in experiment page.
@pingsutw SUBMARINE-716 I modified in this PR.

@ByronHsu Hi, I have readjusted the notebook form as the style in experiment page.
@pingsutw SUBMARINE-716 I modified in this PR.

@xunliu  Thanks your review, I added confirmation dialog box in latest commit.

@xunliu  Thanks your review, I added confirmation dialog box in latest commit.

@ByronHsu Thanks your review. In the previous PR, I referred to kubeflow's approach. Indeed, the polling method seems too complicated, so I simplified it.

@ByronHsu Thanks your review. In the previous PR, I referred to kubeflow's approach. Indeed, the polling method seems too complicated, so I simplified it.

LGTM

LGTM

@pingsutw  I will fix test failure and update doc's image !

@pingsutw  I will fix test failure and update doc's image !


changelog for release - [merged]

Merges changelog -> master

In GitLab by @codecov on Oct 27, 2021, 06:44
Codecov Report

Merging #121 (6cbc28f) into master (d46fd96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files          16       16
  Lines         545      545
=======================================
  Hits          531      531
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46fd96...6cbc28f. Read the comment docs.

In GitLab by @wtbarnes on Oct 27, 2021, 06:56
approved this merge request

In GitLab by @wtbarnes on Oct 27, 2021, 06:56
mentioned in commit a248c7a54f330f5549073053cf3b22c828feeb6b


[MWPW-128737-E] Bug fixes and enhancements on Create Marquee

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix https://jira.corp.adobe.com/browse/MWPW-128737
Fixing the following issues

The bottom spacing is now halved if there is no background.
Images will now properly resize within the allowed space in the app.
The block without variant will no longer break, and will now default to Image.
The left-side editor is now also animated.

Test URLs:

Before:

Full Screen Marquee (previous version)

After:

Full Screen Marquee (Image variant)
Full Screen Marquee (Image variant without background)
Full Screen Marquee (Video variant)

getting this weird bug

The issue is technically fixed but for some reason I can't get the preview links to load the updated css...

Looks like we already have a lot of approvals and the issue @vhargrave pointed out is fixed. I'm merging it to stage now.


pdn: Improve the tool to handle obstructions

Describe the bug
Follow up of discussion at https://github.com/The-OpenROAD-Project/OpenROAD/discussions/5963.
This is an enhancement request.
There is an obstruction in the floorplan that needs the vertical straps to change layer.
In the picture from Innovus, there are M3 horizontal straps (green) and M4 vertical straps (yellow).
Due to M4 obstructions (yellow), the vertical straps switch layer to M2 (red).

This is achieved by using the -area argument of add_stripes. 2 calls with different M2 and M4 with overlapping areas so the straps can connect together.
Cells won't be placed under M2 straps as they cannot be routed as shown below but is handled during PNR:

Suggestion of solutions:

Define 2 grids that overlaps and with different vertical layer as described above
Add a secondary vertical layer so when M4 is not available it switch to M2

Expected Behavior
See in description
Environment
Latest OR

To Reproduce
Test case:
m4_blk.zip
Relevant log output
No response
Screenshots
No response
Additional Context
No response

Cells won't be placed under M2 straps as they cannot be routed as shown below but is handled during PNR

That would also be an enhancement.  We don't normally put in blocking straps like this.


Feature Request: Ability to Switch AI Providers

Currently, Avante.nvim requires users to specify a single AI provider in the configuration, which necessitates updating the configuration and reloading Neovim to switch providers. This process can be cumbersome, especially for users who wish to experiment with different AI models or need to switch providers frequently based on their tasks.
Proposed Feature:
Dynamic Provider Switching: Implement a command that allows users to switch between configured providers without needing to reload the entire configuration.
Benefits:
Flexibility: Users can easily switch between different AI models based on their current needs or preferences.
Efficiency: Reduces the downtime associated with reloading Neovim and reconfiguring the plugin.
Personally, I'm cost conscious and utilize gpt-4o-mini for tedious non-complex tasks which is considerably cheaper than claude 3.5 sonnet. I would use claude for more complex tasks, like refactoring.

:AvanteSwitch

:AvanteSwitch

Awesome, already exists :AvanteSwitchProvider


Python 2.6 compatibility

Currently, 2.6 explodes due to the usage of a dict comprehension.
This commit replaces it with a 2.6 compatible comprehension.

Sure, we can support this as long as we support Django 1.6.  Can you also add Python 2.6 to the lists in .travis.yml, tox.ini, and README.md?

Apologies for making a bit of a mess there.
Incidentally, you may want to change those versions in tox.ini, as >=1.7 pulls in 1.8.2 currently.

No problem, thanks for putting this together.  I'm fine with the commits as-is.  Yes, I just noticed the tox versions were off - I'll fix that once I merge (probably tomorrow).


[Tabs][Carousel] Merge changes to master branch

Staging the merge

Codecov Report

Merging #329 into master will decrease coverage by 0.22%.
The diff coverage is 78.78%.

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
- Coverage      82.5%   82.27%   -0.23%
- Complexity      813      879      +66
============================================
  Files            74       84      +10
  Lines          2640     2804     +164
  Branches        482      518      +36
============================================
+ Hits           2178     2307     +129
- Misses          190      205      +15
- Partials        272      292      +20

Impacted Files
Coverage Δ
Complexity Δ

...adobe/cq/wcm/core/components/models/Container.java
100% <100%> (ø)
4 <4> (?)

.../adobe/cq/wcm/core/components/models/Carousel.java
100% <100%> (ø)
2 <2> (?)

.../com/adobe/cq/wcm/core/components/models/Tabs.java
100% <100%> (ø)
1 <1> (?)

.../core/components/internal/models/CarouselImpl.java
100% <100%> (ø)
5 <5> (?)

...l/jackson/DefaultMethodSkippingModuleProvider.java
76.47% <25%> (-16.39%)
2 <0> (ø)

...components/internal/servlets/ContainerServlet.java
68.75% <68.75%> (ø)
11 <11> (?)

...nts/commons/editor/dialog/childreneditor/Item.java
68.96% <68.96%> (ø)
15 <15> (?)

.../wcm/core/components/internal/models/TabsImpl.java
85.71% <85.71%> (ø)
4 <4> (?)

...ponents/internal/models/AbstractContainerImpl.java
92.85% <92.85%> (ø)
7 <7> (?)

...mponents/internal/models/ResourceListItemImpl.java
93.33% <93.33%> (ø)
7 <7> (?)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2bb6b...472fcb8. Read the comment docs.


Version 1.7.0 update

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

itables==1.7.0 requires Python 3.6
Added the license for datatables-net

@conda-forge-admin, please rerender


remove execshield sysctl-parameter on rhel7

We're having code-duplicates here, but I still think its the cleanest solution, as I don't want to include more conditionals to check for than necessary.
Fixes #118

Travis fails because of the errors that are fixed in https://github.com/dev-sec/ansible-os-hardening/pull/138.


Order by Clause is Not mentioned in Query provided but mentioned in the description

In the content 'The next query returns all the given names of children in the family whose ID matches WakefieldFamily ordered by their grade.' ordered by grade is provided but not present in Query. If we add a new children with grade '4' at first , it will not be ordered on  Please correct the description.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a28b534-831b-bc5c-9074-7c770bfd044c
Version Independent ID: 1b751231-2593-f82d-4651-3d4f87979cd7
Content: Tutorial: How to query with SQL in Azure Cosmos DB?
Content Source: articles/cosmos-db/tutorial-query-sql-api.md
Service: cosmos-db
GitHub Login: @markjbrown
Microsoft Alias: mjbrown

@Nilesh-tech Thank you for the feedback. We are actively investigating and will get back to you soon.

@Nilesh-tech Thanks for letting us know, we have updated the document content accordingly.
The changes should be live once the PR is approved.

@Nilesh-tech We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


WMCore-04-2017-issues

Bug fixes high priority:
#7781 ACDC for ReReco with Parents broken - at GQ level (A) (done)
#6187 ACDC for TaskChain wfs creating more jobs than expected (A)
#7115 Files are not injected to PhEDEx but DBS is updated. (S) (possibly fixed - need to test)
#7439 Files missing in DBS and PhEDEx (S) -  (possibly fixed - need to test)
#7600 Investigate ReqMon memory footprint
#7768  fix campaign filter from reqmgr2 (V) - done
#7758 validate MC site whitelist (A) - done
#7467 Merge jobs skipping ALL input files (A)
Show-stoppers from doing certain type of operations (listed by Jean-Roch during Fall O&C 2016):
#6972 Job-Data binding
#7307 Update ACDC location
Time evolution of errors on workflows
High Priority:
#6787 Stepchain: sort out duplicate outputModules (A)
#6881 ReqMgr2: filter out some keys before persisting them in the reqmgr2 couch doc
#7745 Separate creation and assignment spec parameters (A) (done)
#7728 Read new FWJR XML and store in WMAgent JobReport (EV) - done
#7748 Generate WMArchive report with new key eventsPerLumi (EV) - done
#7712 add events number on filerun_lumi table and modify DAO (S) - done
#7724 Access to condor logs (S)
#7759 Usage of reqmgr_auxiliary couch db and docs in there (S)
Bug fixes medium priority:
#7118 Combine threshold for Processing and Production job type (S)
#6952 Create outputmodule validate function based on its length (A)
#6845 getChunkInfo doesn't assumes all the files in that chunk has the same location (A)
#7133 Make a list of accepted parameters for creation and another for assignment
#7119 Changing pendingSlotsSitePercent takes no effect in ASW (A)
#7577 Automatically set the agent to Drain when diskUseThreshold is reached (Ax)
Bugs that are making operation more tedious than needed (listed by Jean-Roch during Fall O&C 2016):
#7713 Prevent component crash on Oracle connection error (S)
#7773 Fetch proxy validity in AgentStatusPoller and send this info to wmstats (A) - done
#7334 #7200 #7199 #7194 #7180 Agent Crashes
#7371 Duplicated Lumisection (it's a mystery)
#7224 Access to condor logs
#7134 #7091 Error reporting to wmstats
#5945 Data injected without owner
#7280 Inconsistent error report
#7260 Failure to create jobs on recovery
#7063 #7172 Agent Draining
#6857 Prevent small lumi section in simulation

New issue created for May #7827


Alarmo side panel 'stuck' on "Loading..."

Alarmo Version
v1.9.7
HA Version
2023.4.0b2
Bug description
Alarmo installed and working, device and entity showing properly, side panel when clicked just shows "Loading..." in upper left corner of main HA screen indefinitely.
Uninstalling and reinstalling with a reboot with same results.
No errors in logs.
Steps to reproduce
Alarmo installed and working, device and entity showing properly, side panel when clicked just shows "Loading..." in upper left corner of main HA screen indefinitely.
Relevant log output
No messages in logs for Alarmo.

yea something broke it coming from b1 to b2, I checked the changelog though and can't find a breaking change that would cause it.

I can confirm this problem.
It seems to be caused by some changes made in HA for the upcoming 2023.5 release.

On new install its an issue as well.

This is fixed in https://github.com/nielsfaber/alarmo/commit/09199653e067eeb6d5b3128949a44740a6164835.
I will make sure to publish a release soon, since the next HA release is probably next Wednesday.

I released v1.9.8 which contains the fix.
Hope this solves the problem for everyone.

Running 2023.4.0b7 and the latest Alarmo update I still have the bug. Any suggestions?

@mploetner are you on v1.9.8?
Is this version also displayed in the top right corner when opening the alarmo panel?

What panel do you refer to? I can't open the settings. That's the problem. I updated to the 1.98 this morning via HACS

Ok now I know what you asked for

It works for me!

Tried it on multiple devices. Same error

@nielsfaber after update to HA 2023.4 I have same when trying to open settings on mobile app, then I also gete the loading in left corner, if I open HA in web browser using nabucasa external link then it opens setting panel. I am on 1.9.8

same problem here v1.9.8 but alarmo stuck at loading. HA up to date on v2023.04.0 (supervisor and HA)

At me started working when I did switch from mobile to local internet while already have the settings page open forcing HA mobile app to reconnect automatically to local link.... also did do same while connected on web browser and now also on web browser it works on local and nabucase link.... maybe is/was a cache problem for me

cache problem I think yes it works with my android app ! thx !

I had the same issue. Clearing cache in my browser seemed to help.

Ok clearing cache worked for me in browser. But for mobile app I had to reinstall the app to get it work (or I missed a way to clear cache there)
Thx all for the help

@mploetner for me normal total closing app and restart phone does work

@mploetner for me normal total closing app and restart phone does work

Didn't work here but meanwhile I found the clear cache option in the app. So I'm prepared for next time. Thx :)

@mploetner is there a clear cache option within app? Or you refer to the option to clear cache data from apps within phone settings?

@smarthomefamilyverrips its in the app settings under "Debugging"

I’ve just updated to Alarmo v1.9.8 and still getting the same issue of the side panel screen just saying ‘loading…’

I’ve just updated to Alarmo v1.9.8 and still getting the same issue of the side panel screen just saying ‘loading…’

@YewTreeWeb did you try clearing cache in app and/or browser? This did solve it for most of us.

I’ve just updated to Alarmo v1.9.8 and still getting the same issue of the side panel screen just saying ‘loading…’

@YewTreeWeb did you try clearing cache in app and/or browser? This did solve it for most of us.

Thanks for the reply. I had to clear frontend cache and restart the app to get it working 🙂

I’ve just updated to Alarmo v1.9.8 and still getting the same issue of the side panel screen just saying ‘loading…’

@YewTreeWeb did you try clearing cache in app and/or browser? This did solve it for most of us.

Thanks for the reply. I had to clear frontend cache and restart the app to get it working 🙂

@YewTreeWeb with pleasure! 👍🏻

It's 8th of April 2023, I have the same problem when clicking on the Alarmo side panel, it just says loading and nothing happens?

i have also updated to the latest and also have the problem - locally on the browser. on the phone it works. cache in the browser i have already deleted

I had the same problem. Working on the mobile and not working at home
Deleting the cache on the browser (chrome) now its working on both.
I am updated on Alarmo 1.9.8 and HA 2023.4.2

Recently Updated Home Assistant, and the Alarmo Update. Still having this issue too.

Home Assistant 2023.4.2
Alarmo Firmware: 1.9.8
Before updating to 1.9.8, I got the "Loading...".
Now everything is working properly.
Thank you.

Hi guys!
Facing same issue here.
Home Assistant 2023.4.2
Supervisor 2023.04.0
Operating System 9.5
Frontend 20230406.1 - latest
Alarmo
by @nielsfaber
Firmware: 1.9.8

fixed after upgrading to 1.9.8 and cleaning cache in Firefox (settings => search for "cache" => click on Clear Data => tick only cached web content => clear) and for the Android app (settings => Applications => HomeAssistant => Storage and Cache => Clean Cache)

when I clean cache It works on firefox and edge but not in chrome

For Chrome users, who dont want to delete their cache and ctrl + F5 not working:
Open Dev Tools (ctrl+shift+I) and refresh again.
if that does not work: ctrl+shift+I > F1 > under "Network" make sure the "disable cache (while DevTools is open)" is checked


lepton: add CVE-2022-4104 to knownVulnerabilities

Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2022-4104
Upstream appear to be abandoning the project, so this is probably the first step towards removal.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@babbaj (meta.maintainers): this also drops the gb-backup package.


Mismatched token names between light and dark

Description
standard-panel/gripper-drag in "light" to standard-panel/gripper-color-drag in "dark".

WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum2/component/Component/standard-panel/gripper-drag: ["light"]
WARNING - STUDIO MISSING MODE DEFINITION FOR spectrum2/component/Component/standard-panel/gripper-color-drag: ["dark"]

Types of changes

 [x] Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
 [ ] Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
 [ ] Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
Checklist:

 [x] I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
 [x] I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

TESTING spectrum2
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/dark [31d5b502-6266-4309-8f8a-3892e6e158da]
WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/light [26b9803c-577f-4a29-badd-dfc459e8b73e]

STUDIO SYNC SUMMARY
UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.standard-panel.gripper-drag

SPECTRUM SYNC SUMMARY
MODIFIED TOKENS: (1) standard-panel-gripper-color-drag
DEPRECATED TOKENS: (1) standard-panel-gripper-color-drag/dark

TEST COMPLETE

This was a duplicate of https://github.com/adobe/spectrum-tokens-studio-data/pull/169


UX: Some Game setup buttons hard to notice on desktop

The biggest issue is the "next" button after deck selection.

The lack of contrast in the room code also makes it hard to read

This is for room code entry on the iPad mini--the directions are impossible to read

I think this has more to do with the way the mobile device is appearing on desktops. This is something we will need to address, but after next week.


syntax highlighting adds a lot of latency when 'cursorline' is set

Describe the bug
When 'cursorline' is set, sometimes, the syntax highlighting takes a lot of time, which adds a lot of latency.
To Reproduce

Run this shell command:
vim -Nu NONE +'setl cul' +'set ft=vim|syn enable|/readline#yank' +'setl noro|pu=\"th\"|startinsert!' <(curl -s https://raw.githubusercontent.com/lacygoill/vim-readline/master/autoload/readline.vim)

Press C-n to complete the text th, and maintain the key pressed for a few seconds.

Stop pressing C-n.

Vim keeps scrolling the pum for several seconds.
Expected behavior
Vim stops scrolling the pum immediately.
Screenshots

In the gif, C-n is pressed 210 times for about 5 seconds.
After being released, Vim keeps scrolling the menu for about 6 seconds.
Environment

Vim version: 8.1  Included patches: 1-2168
OS: Ubuntu 16.04.6 LTS
Terminal: XTerm(322)

Additional context
I bisected the issue to the commit https://github.com/vim/vim/commit/c2b97643a82bb9fbd202312dac4aa995f92e9e5b.
There was no increased latency just before.

I can also reproduce the issue when 'cursorline' is not set, and 'cursorlineopt' is set to screenline:
vim -Nu NONE +'setl culopt=screenline' +'set ft=vim|syn enable|/readline#yank' +'setl noro|pu=\"th\"|startinsert!' <(curl -s https://raw.githubusercontent.com/lacygoill/vim-readline/master/autoload/readline.vim)
               ^^^^^^^^^^^^^^^^^^^^^^

So, even if the cursor line is not visible, the latency can increase a lot.

The issue disappears if the syntax highlighting is disabled:
vim -Nu NONE +'setl cul' +'set ft=vim|syn off|/readline#yank' +'setl noro|pu=\"th\"|startinsert!' <(curl -s https://raw.githubusercontent.com/lacygoill/vim-readline/master/autoload/readline.vim)
                                      ^^^^^^^

Here are two reports obtained with :syntime, after maintaining C-n pressed for 5 seconds:

report while 'cursorline' is set
report while 'cursorline' is NOT set

For some reason, when 'cursorline' is set, the regexes are used and match several dozens of times more often.

I can not reproduce if – prior to the compilation – I configure Vim with just --with-features=huge.
I can reproduce if I configure with just --enable-rubyinterp=dynamic:
make clean ; make distclean ; ./configure --enable-rubyinterp=dynamic ; make

Although, if I compile with just --enable-rubyinterp, the latency is not as high as before; it decreases by about 30%, but still remains very high.

There should be no cursorline when pum is visible right?

On my machine, the cursorline is still visible even when the pum is open (before and after https://github.com/vim/vim/commit/c2b97643a82bb9fbd202312dac4aa995f92e9e5b).
I used the pum to illustrate the issue, because it provides an easy way to convey that the latency has increased; but the issue is really about the latency which in some part of a buffer can become very noticeable.
In practice, I rarely use the cursorline (only in a few special buffers such as a quickfix one). However, in my vimrc I was setting by default 'cursorlineopt' to the value screenline (set culopt=screenline), and because of that, I've noticed a bigger latency than usual, even in regular buffers.
So now, I've stopped tweaking 'cursorlineopt', and I only set it (via custom mappings or filetype plugins) when I also set 'cursorline' (which I guess makes more sense); I don't think I will experience the issue as frequently anymore; but I still thought it was worth being reported, in case other people – who use the cursorline frequently – face this issue.

I suspected something similar because I could not reproduce the bug in #3893 anymore. The test added from there, should start to fail then.


Retweets do not work in scrape mode

Clicking the retweet button when using scrape mode does not have the retweeted tweet posted into discord, CMD window does not even output that it has seen said tweet.

Here's the big hurdle with retweets: I can only scrape the ID of the tweet that was retweeted, and not the retweet itself. This kind of makes life hell.
The best solution I could come up with is creating a synthetic ID for retweets based on their distance from the next non-retweet in the timeline. This allows tweets to be sorted properly, which is necessary for determining what's new, what's deleted, and how much to scrape.
This works fairly well, but things might get messy if tweets are removed from the timeline. I don't think I care enough to try to solve that problem if it comes up.
I've tested a small amount myself, but I'm leaving the issue open until you report back.

Having only tested a small amount as well it seems to be working. However i would also leave this issue open just a little longer in case more information comes forward in terms of errors with the new method.


AWQ Marlin Quantization

Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
2024-06-19 14:51:42,049 - qllm - INFO - loading model from Weyaxi/Einstein-v6.1-Llama3-8B
Loading checkpoint shards: 100%|██████████████████| 4/4 [00:08<00:00,  2.06s/it]
2024-06-19 14:51:50,575 - qllm - INFO - loading dataset from pileval
2024-06-19 14:51:50,576 - qllm - INFO - found cached dataloader in /tmp/qllm_vroot/_WeyaxiEinstein-v61-Llama3-8B_pileval_16_2048_0_dataloader.pt
Starting ...
Ready.
Running AWQ...: 100%|███████████████████████████| 32/32 [06:47<00:00, 12.73s/it]
2024-06-19 14:58:38,872 - qllm - WARNING - Failed to import qllm.ort_ops
2024-06-19 14:58:38,873 - qllm - WARNING - Failed to import qllm.awq_inference_engine
awq_inference_engine not found, will skip it.
ort_ops is not installed. Will fallback to Torch Backend
marlin_cuda is not installed. marlin_cuda is not use
Replacing linear layers...: 100%|█████████████| 454/454 [00:06<00:00, 66.76it/s]
Packing weights....:   0%|                              | 0/224 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.8/dist-packages/qllm/main.py", line 6, in
main()
File "/usr/local/lib/python3.8/dist-packages/qllm/run.py", line 78, in main
model_quanter.run(args)
File "/usr/local/lib/python3.8/dist-packages/qllm/auto_model_quantization.py", line 217, in run
model = self.pack_model(model, quantizers, args.pack_mode)
File "/usr/local/lib/python3.8/dist-packages/qllm/auto_model_quantization.py", line 94, in pack_model
qlayers[name].pack(attention_layers[name], scale, zero, g_idx)
File "/usr/local/lib/python3.8/dist-packages/qllm/modeling/q_layers/quant_linear_marlin.py", line 99, in pack
assert zeros is None or torch.all(zeros == 8)
AssertionError

Hi.
Thanks for filing the issue.
Marlin only support symmetry quantization, so add --sym after the cli command will work for you.


add caching for embeddings

Adds caching for embeddings using the following cache providers:

InMemory
Redis

Issue: https://github.com/hwchase17/langchain/issues/851
I wasn't sure exactly how this should be added so I chose to modify the Embeddings interface to include an optional embeddings cache since the current llm_cache implementation couldn't be used. I thought about trying to refactor the llm_cache to serve as a more general caching layer but didn't want to make a monster PR for my first contribution.
Any input is welcome from maintainers, I am happy to refactor this if it needs to be implemented differently, like llm_cache or something else.

I followed the contributing guide but for some reason I couldn't get the docs to build locally (or there was no diff?).

So, I am not too familiar with databases (so might be missing something), but I have been looking through the cache system because I need it, and I don't think it's being done properly in general...
Specifically, because hashes may collide you need to always provide hash, key, value, which does not seem to be being done.
In python terms the data base structure is:
{
    'hashkey' : [(key1,value),(key2,value2)]
}

when you do:
hash(key1)
hash(key2)
They may return the same value, so the hash table needs to original key to make sure when you lookup you get the correct key (a lookup for key2 does not return key1)
With your changes specifically:
        self.redis.hset(
            key,
            mapping={
                "embeddings_vector": np.array(
                    embeddings, dtype=np.float32
                ).tobytes(),
            },
        )

should be:
        self.redis.hset(
            hash(key),
            key,
            mapping={
                "embeddings_vector": np.array(
                    embeddings, dtype=np.float32
                ).tobytes(),
            },
        )

Aside from that the embedded caching does not take into account what model is being used as part of the key.
I think that
embed_query(self, text: str) -> List[float]:
Should be more like the llm_cache, and have a reference to the model being used to embed so that you do not run into issues if you have multiple embedding models at the same time.

Thank you both for the feedback! I'll work on those changes.

Thank you both for the feedback! I'll work on those changes.

see a related pr! https://github.com/hwchase17/langchain/pull/2103

Just noticed, it applies to this but also the current LLM cache implementation:
The hash() function in python is (by default) not repeatable between runs.
see:
https://stackoverflow.com/questions/27522626/hash-function-in-python-3-3-returns-different-results-between-sessions
This only seems to be used in for the redis database, but I noticed your implementation is using the same hash logic...
I am not sure what the best replacement is.

Just noticed, it applies to this but also the current LLM cache implementation: The hash() function in python is (by default) not repeatable between runs. see: https://stackoverflow.com/questions/27522626/hash-function-in-python-3-3-returns-different-results-between-sessions
This only seems to be used in for the redis database, but I noticed your implementation is using the same hash logic...
I am not sure what the best replacement is.

I was going to use hashlib and sha but I saw hash being used in the llm cache, I had no real reason for choosing it other than that. Didn't realize that it had that behavior, I think sha would be a better choice here then.

Just noticed, it applies to this but also the current LLM cache implementation: The hash() function in python is (by default) not repeatable between runs. see: https://stackoverflow.com/questions/27522626/hash-function-in-python-3-3-returns-different-results-between-sessions
This only seems to be used in for the redis database, but I noticed your implementation is using the same hash logic...
I am not sure what the best replacement is.

I was going to use hashlib and sha but I saw hash being used in the llm cache, I had no real reason for choosing it other than that. Didn't realize that it had that behavior, I think sha would be a better choice here then.

We fixed the non-deterministic hash issue -- should be up to date on master and in the latest release!
Also -- interested in the caching approach for embeddings. I will take a look here and see what we might be able to do.

Any updates on this?

Embedding caches are now available in langchain: https://python.langchain.com/docs/modules/data_connection/text_embedding/caching_embeddings


benchmark nested json sub-object updates

Hi.
This is a great project. Thanks for putting it together.
MongoDB is performing pretty poorly on most of the benchmark tests provided. Despite this we're still considering it as the right solution, partly due to this one killer feature, which is perfect for our use case:
https://docs.mongodb.com/v3.0/reference/operator/update/set/#set-fields-in-embedded-documents
All of the other datastores that are being benchmarked would require the client to retrieve the document, update it and reinsert it, which I estimate would be will be much slower than the single 'update' operation provided by MongoDB above. This would be particular true for large, highly nested documents.
It would be really interesting and useful to add a benchmark test for this!

Agreed. Would love to see some benchmarks on this.


Viomi v2/v6 - tested working!

Tested working with my Viomi v2 (v6).
Thanks for this plugin - it works great!

How do you go about testing an unsupported vacuum? I want to see if my v10 can be controlled even to a limited extent


All devcontainers fail to open

Starting this morning, VS Code is no longer able to open any dev container. The only error I get is: "An error occurred setting up the container" immediately after triggering the window to reopen in container.

There are no other error logs anywhere I can find. It doesn't matter what the dev container definition is, this is the result. I have tried restarting my machine, uninstalling and reinstalling the devcontainer extension, and uninstalling and reinstalling VS Code entirely without any change in this behavior. Additionally, I do not get that popup if I try to "Reopen in Container" or "Rebuild and Reopen in Container" again after the failure. It just silently does nothing. Reload the window and trying one of those options results in the same popup error.
I tried installing the devcontainer CLI and using that, hoping to at least get a useful error message, but the only message I can seem to get is "Segmentation Fault".

Please let me know if there are logs somewhere I can grab that might be more helpful, but there are no terminal logs that I can see. I would appreciate any help anyone can provide.
Version: 1.78.2 (user setup)
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

Hi 👋
Thanks for reporting this issue, and apologies for your inconvenience.

Starting this morning, VS Code is no longer able to open any dev container. The only error I get is: "An error occurred setting up the container" immediately after triggering the window to reopen in container.

@ianblitz  Opening an issue in https://github.com/microsoft/vscode-remote-release/issues should help with the errors related to the "Dev Containers" extension.

I tried installing the devcontainer CLI and using that, hoping to at least get a useful error message, but the only message I can seem to get is "Segmentation Fault".

This is something we can help with, @alexander-smolyakov can you help investigate the issue here?
Wondering, if both the issues could have the same root cause.


Cannot import log files anymore

LiteDB ENSURE: transaction must be active to rollback (current state: Disposed)

Solved by using singleton and shared connection


Add TemplateHaskell pragma to generated module

Before submitting your PR, check that you've:

[-] Documented new APIs with Haddock markup
[-] Added @since declarations to the Haddock
[x] Ran stylish-haskell on any changed files.
[x] Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

[x] Update the Changelog.md file with a link to your PR
[x] Bumped the version number if there isn't an (unreleased) on the Changelog
[x] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

tested in work codebase, all good


[gem/Ubuntu16.04] Installation failed: mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h

Hi,
First of all i like to thank you for this project that make things easier - especially on win.
I got an error while installing ascidoctor-jekyll:
When installing asciidoctor / asciidoctor-jekyll on a fresh created ubuntu-16.04 server installation failed because of missing headers for ruby:
mkmf.rb can't find header files for ruby at /usr/lib/ruby/include/ruby.h ....
After doing sudo apt-get install ruby-dev it works.
Maybe it would be nice to put this into README.md.
Greetz,
xusdom

I've added a note to the README. The Ruby development headers are required to install many gems (on MRI) and thus a standard part of gem installation. Instructions for how to install the Ruby development headers, so I just left it as a note in the in the README that this is a prerequisite.

The command that worked for me:
apt-get --reinstall install ruby

That did not work for me. I needed apt-get install ruby-dev.

It's going to depend on the distribution and how it packages Ruby. One way or another, you need the header / development files available.

try it for ubuntu 16.04      sudo apt-get --reinstall install ruby


log the name of the state

The int value of the state is not super helpful to end users. Logging the name of the state instead.

Welcome back @codeboten!


Support for Vision OS

Description
Required Vision OS Support
API Proposal
Support for All Firebase Products in Vision Platform
Firebase Product(s)
Firestore

Thanks for the feature request. There is currently community support for many of the Firebase products and have no near term plans to support all of Firebase products.  Please open a specific feature request for each product that you would like supported. I can leave this open to track updating our docs at https://firebase.google.com/docs/ios/learn-more#firebase_library_support_by_platform for visionOS

Docs are now updated https://firebase.google.com/docs/ios/learn-more#firebase_library_support_by_platform.


Rework using leaflet plugin

We should drop most of the control code in favor of using:
https://github.com/perliedman/leaflet-routing-machine
Todo:

[x] Check feature difference
[x] Determine what of the missing features we really need
[x] Include as submodule
[x] Implement missing features

@DennisOSRM

This shipped.

Wow, this is great news! Nice work by everyone involved. :confetti_ball:


[Misc clean-up] Don't attach custom event functions to window namespace

Description
A piece of tech clean-up I wanted to do for a long time.
We declare functions to fire/listen to custom events, but they are declared as globals, attached to the window object.
There is no need to do that. This pollutes the global namespace and requires special ESLint config, whereas JS modules provide the right way to import that as needed.
Also, if we need to do server side rendering with our React components, any use of window will break.

A minor conflict needs to be resolved on this PR.


setup.py keywords could be removed

Setup.py currently repeats the project name as a single-element list for "keywords".
As this is an optional field, and that value isn't all that helpful to package indexes, it might as well be removed.

I use it because it does affect search on PyPI and not having it makes it unknown to package authors.

I use it because it does affect search on PyPI and not having it makes it unknown to package authors.


Cannot escape backtick(`) in fenced code block

I am tryping to show a code example in my slide using github-style fenced blocks:
 ```bash
 echo "message" > log-`date --iso-8601`.txt
 ```

I am aware that the backtick(`) is used to highlight part of the code example in Remark. I tried to escape the backticks like this:
 ```bash
 echo "message" > log-\`date --iso-8601\`.txt
 ```

But the code block is rendered like this:
echo "message" > log-\`date --iso-8601\`.txt

Is there a way to write the code example so that it will be rendered as
echo "message" > log-`date --iso-8601`.txt

Thank you.

It's also hit me as well.
Any way to escape those ```?

You can use this as a temporary workaround: https://gist.github.com/VadimPushtaev/2e123b16798a0a815caf

@VadimPushtaev thanks, it was helpful.

#220 fixed this and was included in version 0.11.0. You can now escape backtics with a backslash.


List on json-schema.org

Hello!  One of our community members let us know about this JSON Schema implementation, and I noticed that it's not listed on our implementations page, but we'd love it to be.
If you'd like to add this implementation to that page, please feel free to create a pull request!  Have a look through some previous PRs to see how to add yourself.  (It's pretty easy.)
Thanks for enhancing the JSON Schema ecosystem!

Hi, thanks for reaching out!
I think this would fit in the "Schema generators" section, I'll create a pull request :)


Continue on parseJSON error

In some instances (where an ingress redirects 4xx errors for instance), the response by the server on error will not necessarily be neatly JSON formatted.
This causes pgweb to halt loading the page on a jQuery error.
This PR adds a try catch statement to catch parseJSON errors and resume code execution on a failed API call.

Thanks for the improvement!


Implement B-tree

https://en.wikipedia.org/wiki/B-tree

https://github.com/vinta/fuck-coding-interviews/blob/master/data_structures/b_trees/b_tree.py


Share a roadmap for vcpkg

I would like to see a roadmap to get a picture of the future topics that drive vcpkg. What is your opinion on that?

It took a while but we finally have a roadmap publicly available.
Here is the original announcement via blog post and the roadmap page in our wiki.

Commnents to https://github.com/microsoft/vcpkg/issues/11177 if you like.


[Feature]: Create an editable file for config settings

Description
Create a config file editable in IPC :rocket:
Expected behaviour

Think about it:

[ ] How to display it?
[ ] Which format will be used,?
[ ] How will you store it on Aleph? :wink:

Create the corresponding UI editor :rocket:

Environment
/
Proposed solution
No response

Description
Create a config file editable in IPC rocket
Expected behaviour

Think about it:

[ ]  How to display it?
[ ]  Which format will be used,?
[ ]  How will you store it on Aleph? wink

Create the corresponding UI editor rocket

Environment
/
Proposed solution
No response

How to display it: A new tab just after 'My profile' named 'Configuration' with a lot of inputs to edit the config
Which format will be used: I think JSON. Basic, universal, clean :ok_hand:
How will you store it on Aleph: In aggregates we will store it like any files. However, not in the files array but in a new property named 'configuration'


[Mode][GitHub] Add initial implementation of the triggers.

Split the model namespace in two:

AzDO
GitHub

And provide the initial work for the GitHub actions model. At the moment
we have just the Workflow (is a pipeline in the AzDO world) triggers.
GitHub actions provides triggers for all its webhooks and a few manual
ones as well as a cron job. Tests have been added monstly to show the
API and make sure we are not doing anything stupid.
Reference: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#configuring-workflow-events

I have named the namespace AzureDevOps in my git branch

@premun merged with main, so it should be everything ready to land :)


CP-140: add version.txt to share/doc

It looks like @cotedm hasn't signed our Contributor License Agreement, yet.
Appreciation of efforts,
clabot

Test PASSed.

CLABot is totally trolling @cotedm.

[clabot:check]

It looks like @cotedm hasn't signed our Contributor License Agreement, yet.
Appreciation of efforts,
clabot

[clabot:check]

@confluentinc It looks like @cotedm just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

Ok I signed it.  @hachikuji that should keep CLABot down.  Can't be feeding the trolls.

LGTM (since I saw @ewencp already approve a similar patch). Just for my own knowledge, is the idea for the packaging scripts to overwrite this file?

Yep that's the plan.  You'll see similar patches ending up in most of the repos and then packaging will make updates (CP-140).


feat: add intro video in about page

From: https://github.com/cofacts/rumors-site/issues/462
Add the introdeuction video in the about page.
Before

After

Coverage remained the same at 76.249% when pulling d2d8f50f75cee736cdd7453b04087b24a11c0072 on Lauviah0622:about-page-video into b5c6830e3794827f0fdb298254d0b8dfdc04361f on cofacts:master.


feat(sortable-wrapper): new component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

86 of 103 (83.5%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 79.858%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/sortable-wrapper/src/utils.ts
15
19
78.95%

packages/sortable-wrapper/src/components/sortable-wrapper/Component.tsx
45
58
77.59%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
7492

Relevant Lines:
8535

💛  - Coveralls


Remove dead code in macros backend

Thank you for contributing to PyO3!

Is https://github.com/PyO3/pyo3/actions/runs/8480976804/job/23237630151 a known flake? Don't see how it could be caused by this PR

It makes sense to me why that's flaky, #4014 should resolve.

I'm going to let the merge queue clear out before I re-add this.

Yeah, need to think if there's anything else we can do to help CI run a little more efficiently...

I filed a seperate bug as a place to ideate/track improvements.


Automated cherry pick of #1561: Fix the borrowing while preemption when no borrowingLimit

Cherry pick of #1561 on release-0.5.
#1561: Fix the borrowing while preemption when no borrowingLimit
For details on the cherry pick process, see the cherry pick requests page.

/assign @alculquicondor

BTW, we want to cherry-pick #1496 to release-0.5 to avoid conflicts in the future before we merge this PR into release-0.5.

I'm fine either way.

/lgtm
/approve


Build error in Manjaro linux latest

R-Type/systems/Friction2DSystem.cpp:37:22: error: ‘expf’ was not declared in this scope    37 |   return (oldSpeed * expf(-friction * delta));       |                      ^~~~ make[3]: *** [CMakeFiles/RType_Server.dir/build.make:626: CMakeFiles/RType_Server.dir/systems/Friction2DSystem.cpp.o] Error 1

We wrote this code years ago and it is not currently maintained. I guess expf is (was ?) part of the stl but is no longer exposed from the same headers since some version of the compiler ? I don't even remember if we were using g++ or clang, that tells you something 😆
Anyways, I have absolutely no time to dedicate to this project anymore, so beside this hint you are on your own  ¯_(ツ)_/¯


Incorrect Page Title

Summary
The page title for https://www.ibm.com/plex/specs/ is incorrect.  Specs is the 6th section on the site progress bar but the title says "05 Specs"
Also, nice IBM Plex logo in the <head>
Relevant information
<title>05 Specs | IBM Plex</title>
should be
<title>06 Specs | IBM Plex</title>


Issue with interval?

Hello,
how is this supposed to work?
max percentOverDue your code can calculate is 2
max difficultyWeight  your code can calculate is 3
which means max interval your code can calculate when answers are correct is 5
Am I missing something here?

I see where is the problem, it shouldn't be
interval = 1 + Math.round((difficultyWeight - 1) * percentOverDue)
but
interval = interval * ( 1 + Math.round((difficultyWeight - 1) * percentOverDue))
and the same for incorrect answer


Holonomic angle seems to have no effect

My team has been using Pathplanner to create swerve drive autonomous modes, and it seems like the Holonomic angle field is doing nothing. We created a path with a changing Holonomic angle throughout the path, and our robot remains facing the same direction throughout the path. I can provide our code and paths along with a few videos during our meeting tomorrow.

Feel free to post code here if you want, but we can just continue the discussion on CD if you'd prefer as this likely isn't a PP bug. I'll leave the issue open just in case though.


File stream pointer of FD

Some functions of a C-library I'm writing a binding for take a *FILE argument pointing to a file stream. Crystal's File class has #fd which can be associated with a file stream using fdopen(). I checked the LibC binding in Crystal but couldn't find this function.
The following line would be enough, I suppose:
  fun fdopen(fd : Int, mode : Char*) : Void*

As to where to put it, there are six stdio.cr files for different platforms. According to the Open Group standard it has been standardized since Issue 1, so should be well supported on various platforms. So where's the best place to put this? Or are there any opinions against having this function binding in Crystal's LibC?

If we want to support this, I think it should be File#to_libc_file or something like that, hiding the fdopen call.

I'd rather not have it in the stdlib at all if at all possible.

No hurries. That project is on ice.


Fishhooking boolean operators to cover extreme cases

elated to issues #198 #152 #210.
Based on the discussion of issue #152, and in order to cover both #152 and #198 (and #210 which is a duplicate), I introduced boolean operators for both our variables classes, and for int/bool objects. For the later, I used fishhooking.
The main changes are in variables.py (introducing the new functions for our variable classes, overloading logical operators) and in python_builtins.py, where I introduced the overloaded (hooked) logical operators for int and bool.
I also introduced a new "is_bool" function for ints. That is because we use it in many cases for expressions and their arguments (e.g. lines 64-72 of linearize.py). This was leading to errors if an argument was an integer, because of no built in function.
The above cover all cases that have appeared in the mentioned issues, providing the appropriate CPMpyException messages in each case.

This is a nice start, but does not cover the full potential of the fishook library I think.
For example, we can also hook into the __getitem__ of list and np.ndarray to eliminate the need of the cpm_array and create Element constraints very cleanly. Although we need to be really carefull in how we implement this as we want to make sure we do not screw up the efficiency of getitem of these classes...

Yes, we can still do many more with fishhook library. This was just intended as a start, solving some specific issues. E.g., we can hook the value() functions in basic types (as suggested in #158) etc.

After discussion in-person, we retract from introducing fishhooks in CPMpy


Fix merging of main

What is the change?
This undoes #1480 and redoes it in such a way as to preserve the commit history.
Why is the change being made?
#1480 did a squash/merge, but we don't want that in this particular instance.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[x] The documentation is still up-to-date in the doc folder.
[x] No requirements were altered.
[x] The dependencies are still up-to-date in pyproject.toml.

This PR has no diff?

We fixed this PRs goal in another way.
Chris and Tony agreed.


Add npmignore

To limit what goes over the wire for when it's published
to npm.

You're too fast for me @knownasilya :grin: Thanks for all the PRs!


OpenJDK8 getting pulled as dependency.

openjdk8 gets pulled as an implicit dependency for some reason when I try to build from source.
This however doesn't happen when I build it with openjdk8 uninstalled.
Is it supposed to do that?

Wow! No, it is not supposed to do this, lite-xl has nothing to do with java or openjdk. It needs the SDL2 and freetype2 libraries, a working C/C++ compiler and Meson to build.

I thought  it was odd as well.
For context I am using a source based distro KISS Linux so during build the package manager pulls in all the dependencies that are called during the build process.

I don't know the KISS distribution but it is probably a problem in the package recipe or a problem in the kiss package manager itself. I don't see anything I can do on my side.

I checked, it’s neither of those but I understand.


GearVR viewer params

I've been trying to get the boilerplate-based project to run on the latest GearVR with S7 edge, and ran into issues with eye distance being off by a lot. Using a normal browser outside of gear app it seems like a polyfill issue.
After a brief research, I ended up tweaking the CardboardViewer parameters by trial and error, so that it sorta works. Here is my result:
label: 'GearVR 2',
fov: 35,
interLensDistance: 0.052,
baselineLensDistance: 0.035,
screenLensDistance: 0.043,
distortionCoefficients: [0.441, 0.156],
inverseCoefficients: [-0.4410035, 0.42756155, -0.4804439, 0.5460139,
      -0.58821183, 0.5733938, -0.48303202, 0.33299083, -0.17573841,
      0.0651772, -0.01488963, 0.001559834]

Is there a way to know the actual parameters for GearVR? Would it make sense to add gear as another viewer to polyfill?

Duplicate of https://github.com/borismus/webvr-polyfill/issues/60?

Yes, thanks.


Updated the course & book resources w AI additions

check_urls=free-courses-en.md free-programming-books-en.md
What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Free courses and free programming books in the emergent and very popular field of artificial intelligence and graph neural networks.
Why is this valuable (or not)?
I believe this is one of the new blossoming topics in AI and finding resources for this is still difficult though becoming easier as the field exapnds. A lot of these books are still currently pre-published due to how new the knowledge is.
How do we know it's really free?
It is shared in the open commons of McGill and Standford univeristy
For book lists, is it a book? For course lists, is it a course? etc.
It is a book and a course the book is a series of PDFs, and for the course all of the pdf slides and collab docs are open to all.
Checklist:
Read our contributing guidelines.
Search for duplicates.
Include author(s) and platform where appropriate.
Put lists in alphabetical order, correct spacing.
Add needed indications (PDF, access notes, under construction).
Used an informative name for this pull request.

please resolve conflicts.

@eshellman resolved

Thanks, and welcome to free-programming-books!


Enable GitHub actions

GitHub actions are currently disabled due to broken links, integrations, incomplete packaging etc.
Enable them once the packaging is done and integrations (like sonarcloud, zenodo etc) are done.

all actions are working and enabled now.


Removed closing tag from input elements

Input is a void element which can only have a start tag, end tags must not be specified.
http://www.w3.org/TR/html5/syntax.html#void-elements

Hello,
Input elements and multiple others such as img and link allow for an optional "/" to indicate end of tag. If I merge your request, the code would be inconsistent since you didn't change img, link, br and other tags. Also, I am working on the premium collection which uses this syntax. Thanks for the work though!

I appreciate your effort to keep the code consistent, but you sholud be aware that there are quite a few places where the input element is used without a closing tag:

I'll take a look at that when I get a chance. Thank you for your contributions.


No link found?

https://labs.w3.org/normative-references/check?url=http://www.w3.org/TR/websub/

... because all of the references are pointing to the references section.


Simplify 'group_by_accuracy' function.

This change reduces repeated code.  I'm not sure what the accuracy parameter is for, but as it looks like it wasn't being used in the original function I left it in the new signature as well for API compatibility.

cool, it's just the way I want to improve this function. thanks and I will merge this PR and upload the new package to PYPI.


take increasingly bigger steps

After some time, bisect will always check 2 rust versions per month as it goes back in time, but when bisecting stable-to-stable regressions, this still takes a lot of time. It would be nice if could perhaps try to go back by one month at a time a year after the first checked commit and maybe 1.5 months after 2 years? (or just increase the number of days skipped linearly with the further back we go?)

we could also just go back exponentially by default and then do a normal bisection when we hit a change

The choice here was intentional, in my experience the farther back you go the more likely it is that you stop building for different reasons (typically dropping back before the relevant feature is supported), meaning that the "did it build" function is not monotonic, which means you can't bisect: you have bad commits both at the beginning and the end of your curve, which prevents the typical binary search from working.
We can tweak the exact constant, but I would avoid trying anything exponential - that goes too quickly, in my experience.

Could be behind an extra cmdline flag.
From doing a couple bisections today i already got around 100 bisector toolchains installed which seems like quite a lot  .


Cannot find SourceMap 'cropper.js.map'

When I am using wabpack with typescript, there is a warning:
WARNING in ./~/react-cropper/~/cropperjs/dist/cropper.js
Cannot find SourceMap 'cropper.js.map': Error: Cannot resolve 'file' or 'directory' ./cropper.js.map in C:\Users\liliu\Desktop\Demo\webapp\node_modules\react-cropper\node_modules\cropperjs\dist

The source map file of cropperjs is unnecessary.  There's no sourceMappingURL in node_modules\cropperjs\dist\cropper.min.js

@roadmanfong
Maybe you could recompile it with sourcemaps, please? That's very annoying to see this error in webpack on every rebuild..
Thanks for the work anyways