All policies skipped - no checks perfomed

Community Note

Please vote on this issue by adding a 👍 reaction
to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Debug Output
https://gist.github.com/lukpep/61f5d104e28186466a35cb532ea3033b
Steps to Reproduce
clone the newest repo, build it and try to use gke policy automation with basic command:
./gke-policy check best-practices --project my-project-id --location europe-west1 --name my-cluster-name

The same thing happens (meaning nothing is checked) when used with config file and discovery options - clusters are found but no checks are performed - only logs about skipping policy test files from https://github.com/google/gke-policy-automation/blob/main/internal/policy/policy.go#L133
Expected Behavior
checks are performed
Actual Behavior
no checks are performed

Hello @lukpep, thanks for reporting this one. Could you please tell me which version are you using? the main branch or a release? can you please test also the latest release?

Hi @danielmarzini (small world by the way :D - thx for the anthos help)
Main branch at this commit: https://github.com/google/gke-policy-automation/commit/a2f8c69f8e9bcaa6ee8c0ffe3b83f15e1a57628d

Hey @lukpep, indeed very small ;)
It should be ok now, could you please sync up with the main branch and tell me if everything is ok?

yes - now it works - thanks :)


Rider calender

@CE201710 looks like you made a new component called CreateTripPage that's separate from RiderAddTrip? Do these pages have the same functionality?


build_visit hdf5 build issue on macos arm (m1)

Describe the bug
new error on macos when building hdf5:
../../test/cache.c:25754:23: error: call to undeclared function 'resize_configs_are_equal'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        } else if ( ! resize_configs_are_equal(&test_auto_size_ctl, \

Desktop

OS and version: macOS 13.6
VisIt Version: 3.4RC

I am missing:
-fsigned-char -D_FILE_OFFSET_BITS=64

I though these were committed, so I will try to figure out where they went.

red herring, turns out my compilers were update via a system update.
new clang is strict about implicit function declaration, solution is to use:
-Wno-error=implicit-function-declaration

I ran into same and wound up just adding the missing function declaration which I think had something to do with comparing cache configs in testing sources. Another option...why are we building testing sources...we could just opt to not build tests. We don't use them.

Ok, I ran into an issue with the config for parallel where the -Wno-error=implicit-function-declaration approach also fixes it. Thats the better route then.
BTW...we're running into now really, really old issues due to age of HDF5 version we are using. We should move to 1.14 as soon as practical. We'd get rid of a ton of patching code and our HDF5 builds would be more relaiable out of the box.

resolved in #19298


Feature request: ability to substitute dates other than the current one

Often, I find that I would benefit from the ability to specify things like "tomorrow" or "next week" via templates. For example, if I'm planning the next week, I want the template to substitute something like this for me:
<next week's number>: <first day of next week> -- <last day of next week>

Similarly for the next day. Is it possible to have Joplin substitute a date that is not the current date into a template?

Seconding this. In particular I want {{yesterday}} and {{tomorrow}} to work. This isn't possible currently.

{{date-2}} sort of like the search. Or supporting: How do I insert relative date/time in notes? - Support - Joplin Forum But that might be joplin core. It would also solve my formatting issue.

Implemented in #79. This feature will go out in the next release.


QuantumCircuit qasm2 dumps generates wrong OpenQASM code

Environment

Qiskit Terra version:
Python version:
Operating system:

What is happening?
When exporting QuantumCircuit to OpenQASM U gate exported as 'u' instead of 'U' this leads to error when importing generated OpenQASM code using qasm2.loads()
Step to reproduce:
Run program:
from qiskit import qasm2
from qiskit import QuantumRegister, QuantumCircuit
q = QuantumRegister(1, "q")
qc = QuantumCircuit(q)
qc.u(0.3, 0.2, 0.1, q[0])
qq =  qasm2.dumps(qc);
print(qq);
circuit = qasm2.loads( qq );

Output:
OPENQASM 2.0;
include "qelib1.inc";
qreg q[1];
u(0.3,0.2,0.1) q[0];
Traceback (most recent call last):
File "C:\work\1\python\tele2.py", line 12, in
circuit = qasm2.loads( qq );
File "C:\work\quantum\qiskit\lib\site-packages\qiskit\qasm2_init_.py", line 604, in loads
return _parse.from_bytecode(
File "C:\work\quantum\qiskit\lib\site-packages\qiskit\qasm2\parse.py", line 214, in from_bytecode
for op in bc:
qiskit.qasm2.exceptions.QASM2ParseError: ":4,0: 'u' is not defined in this scope"
But if replace in generated code last line to "U(0.3,0.2,0.1) q[0];" then code imported correctly
How can we reproduce the issue?
Run program
from qiskit import qasm2
from qiskit import QuantumRegister, QuantumCircuit
q = QuantumRegister(1, "q")
qc = QuantumCircuit(q)
qc.u(0.3, 0.2, 0.1, q[0])
qq =  qasm2.dumps(qc);
print(qq);
circuit = qasm2.loads( qq );

What should happen?
There should be no error when import just exported OpenQASM code
Any suggestions?
replace in generated code last line to "U(0.3,0.2,0.1) q[0];" then code imported correctly

Thanks - this is (unfortunately) a known current issue, where the OpenQASM 2 export hallucinates some additional non-standard gates in qelib1.inc; you can see some discussion in #4312 (nearly four years ago! ...) and our general plan for how we're going to fix it in #10737.
For the time being as a workaround, you can tell Qiskit's OpenQASM 2 loader about all the extra gates like this:
from qiskit import qasm2
from qiskit import QuantumRegister, QuantumCircuit
q = QuantumRegister(1, "q")
qc = QuantumCircuit(q)
qc.u(0.3, 0.2, 0.1, q[0])
qq =  qasm2.dumps(qc)

# ... just your code so far.  Now:

qasm2.loads(qq, custom_instructions=qasm2.LEGACY_CUSTOM_INSTRUCTIONS)

The extra custom_instructions=qasm2.LEGACY_CUSTOM_INSTRUCTIONS tells the parser about all the extra gates that the exporter used without properly defining.  The real fix from our side will be to make the exporter do the correct thing in the first place.


Error

python3 gridtrader/gridtrader.py --init myAccount.ini
ic| self.configo: ConfigObj({})
Traceback (most recent call last):
File "gridtrader/gridtrader.py", line 626, in
dispatch_command(main)
File "/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py", line 306, in dispatch_command
dispatch(parser, *args, **kwargs)
File "/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py", line 174, in dispatch
for line in lines:
File "/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py", line 277, in _execute_command
for line in result:
File "/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py", line 260, in _call
result = function(*positional, **keywords)
File "gridtrader/gridtrader.py", line 577, in main
exchange = user_configo.make_exchangeo()
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 103, in make_exchangeo
_ = exchange.abstract.Abstract.factory(self)
File "/home/d9635776/gridtrader/gridtrader/exchange/abstract.py", line 26, in factory
exchange_label = configo.exchange_label
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 116, in exchange_label
_ = self.exchange('label')
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 111, in exchange
_ = self.configo['exchange'][param]
File "/home/d9635776/TEST2/lib/python3.7/site-packages/configobj.py", line 554, in getitem
val = dict.getitem(self, key)
KeyError: 'exchange'
Exchange - deribit

It appears you are missing an "exchange" section in your config file.
Here's an example:
https://github.com/metaperl/gridtrader/blob/master/accounts/sample.ini.sample#L8
On Sun, May 19, 2019 at 7:43 AM Tezeug<EMAIL_ADDRESS>wrote:

python3 gridtrader/gridtrader.py --init myAccount.ini
ic| self.configo: ConfigObj({})
Traceback (most recent call last):
File "gridtrader/gridtrader.py", line 626, in
dispatch_command(main)
File
"/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py",
line 306, in dispatch_command
dispatch(parser, *args, **kwargs)
File
"/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py",
line 174, in dispatch
for line in lines:
File
"/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py",
line 277, in _execute_command
for line in result:
File
"/home/d9635776/TEST2/lib/python3.7/site-packages/argh/dispatching.py",
line 260, in _call
result = function(*positional, **keywords)
File "gridtrader/gridtrader.py", line 577, in main
exchange = user_configo.make_exchangeo()
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 103, in
make_exchangeo
_ = exchange.abstract.Abstract.factory(self)
File "/home/d9635776/gridtrader/gridtrader/exchange/abstract.py", line 26,
in factory
exchange_label = configo.exchange_label
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 116, in
exchange_label
_ = self.exchange('label')
File "/home/d9635776/gridtrader/gridtrader/configo.py", line 111, in
exchange
_ = self.configo['exchange'][param]
File "/home/d9635776/TEST2/lib/python3.7/site-packages/configobj.py", line
554, in getitem
val = dict.getitem(self, key)
KeyError: 'exchange'
Exchange - deribit
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/metaperl/gridtrader/issues/2?email_source=notifications&email_token=AAAFGLNRCPJY6TCXHUTBPU3PWE4PLA5CNFSM4HN4I44KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUSQXSA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAFGLN5LIJNZZO5OCG4IU3PWE4PLANCNFSM4HN4I44A
.

--
Terrence Brannon
http://www.metalevel.link

Does the GridTrader support BitMEX TESTNET? If so, how should I input the name of the such exchange (testnet)?

Not at the moment. It uses ccxt to interact with exchanges, so I suppose it
could be extended for that, but I have not looked into it.
On Sun, May 26, 2019 at 7:25 AM Tezeug<EMAIL_ADDRESS>wrote:

Does the GridTrader support BitMEX TESTNET? If so, how should I input the
name of the such exchange (testnet)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/metaperl/gridtrader/issues/2?email_source=notifications&email_token=AAAFGLNGIANKJCAGO3BL34TPXJXQ3A5CNFSM4HN4I44KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIDWYQ#issuecomment-495991650,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAFGLNFIMG7BSNVLRPQ35TPXJXQ3ANCNFSM4HN4I44A
.

--
Terrence Brannon
http://www.metalevel.link


Remove Maintenance access from visitor

About the PR

title
Why / Balance

weird that NOT crew has access to station maintenance rooms
passangers also shouldnt has that access but  once access work is completed
so i think we can remove this from visitor for now
and even if the specific visitor should has that access, hop can easily give it
Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl no fun

no

i don't really see this as necessary, even in some future where we have better access controls.


Simple Magic Spellbook System

About the PR
This PR uses code mostly from this currently closed PR #6879 so the credit goes to @ElectroJr for the code supplied in this PR.
And another huge thanks to @ShadowCommander for helping me with a lot and writing the code for Force Walls!
Here's a design doc for magic I slapped together: https://hackmd.io/JJrWmEL-RJWb8waOXQY6zw
The current system lets you learn magic through spellbooks. The spells added are relatively simple, with one complexish spell (Force Wall). And it opens up the opportunity to add more. It also adds a system for rune magic, which can be activated through a variety of ways (also it makes it easier for cults to implement them in the future).
Things like projectile spells and actually teaching the mind magic might have to wait for some reworks to happen, but this should be good for now.
Screenshots

Changelog

:cl:

add: Adds Magic! Learn spells with spellbooks. Spells including: Blink - a teleport spell. Knock - a spell that unlocks and opens doors.  And Runes - magic drawings on the ground.

What I would like is a more generic way of doing stuff like "spawn entity on cursor". Like right now if I wanted a spell that spawns some puppies in a radius like the force wall spell I'd have to copy half of it and then change it. Ideally it'd be possible to make a spell that says "spawn entities in radius around cursor" and then the prototype would handle its deletion timer.
Runes are pretty good about this but if I wanted to spawn many runes in a radius you'd need to add code for a new spell rather than just making a new prototype. DND is pretty decent about this flexibility if you need ideas.

I can definitely try to take a shot at this. One issue I actually ran into was that I wanted to make a spell like "The Traps" from SS13 but I wasn't sure how to go about spawning X amount of prototypes in Y area (that's not a wall, not space, not on top of another rune, etc) and I thought this was getting a bit lengthy with some of the spells added currently.
What's DND? I'll take a look at that but I'm not sure what it stands for.

What's DND? I'll take a look at that but I'm not sure what it stands for.

Dungeons 'n Dragons

but I wasn't sure how to go about spawning X amount of prototypes in Y area (that's not a wall, not space, not on top of another rune, etc) and I thought this was getting a bit lengthy with some of the spells added currently.

So you can use something like GetTilesInIntersecting, then if you want to ensure no overlaps just do bounds checks using entitylookupsystem.

but I wasn't sure how to go about spawning X amount of prototypes in Y area (that's not a wall, not space, not on top of another rune, etc) and I thought this was getting a bit lengthy with some of the spells added currently.

So you can use something like GetTilesInIntersecting, then if you want to ensure no overlaps just do bounds checks using entitylookupsystem.

I think this should be good for now. Seems like the spawning methods used and world target accounts for a lot of this stuff already.
I'm going to save an instant action spawn spell for another PR, but now I have the basis for a generic world target spawning spell in this one. I have a few more spell ideas but I don't want to bloat up the PR anymore.
Speaking of bloat, I'm noticing the MagicSystem is starting to get a bit bloated now. Should I split these up into partial classes or should I make separate systems? Or is whatever in there fine?

File length should be fine. The main thing is readability though, so if you feel like breaking it up would be easier to read, then feel free to.

File length should be fine. The main thing is readability though, so if you feel like breaking it up would be easier to read, then feel free to.

I think I'll leave it for now. It's separated by a couple of regions. In a future PR where I add more spells I might mull it over then.

Adding the PreventCollideComponent and System for Force walls, @metalgearsloth said they'd check it out.

Need licenses for audio as well.

How do I add audio licensees?

Need licenses for audio as well.

How do I add audio licensees?

Include i license.txt in the folder then add a link attributing where the audio is from as well as the specific copyright on the audio

Need licenses for audio as well.

How do I add audio licensees?

Include i license.txt in the folder then add a link attributing where the audio is from as well as the specific copyright on the audio

Thank you!


[Chore] Investigate why controller tests hang under high load

Background
We've recently noticed that running check-verything.sh sometimes causes the controller integration (env) tests to hang. We've traced the issue to a orphaned etcd process left over from the envtests. Since the the process is orphaned and ginkgo is waiting on a pipe containing stdout output, the test completes, but hangs and cannot continue to the next suite of tests.
By debugging with dlv, we noticed that the envtest cleanup is supposed to send a SIGTERM to the etcd process, however, either the signal is not sent or it is ignored by etcd. Manually sending the SIGTERM to etcd after the fact kills the process and unblocks the ginkgo process.
Reproducing
To reproduce this we ran one of the env tests in controllers with --until-it-fails and at the same time ran check-verything. This gave us the highest chance of reproducing it in a reasonable amount of time. We suspect that it is because the system is under very high load when all the tests are running at the same time.
To help with debugging we also had to compile etcd ourselves and put it in testbin/bin/etcd as well as disable this line when running tests. This is because the etcd binary we use isn't compiled with the right flags and we cannot attach to process.
In order to change things in the env tests we also locally ran go mod vendor and added a -mod=vendor flag when running ginkgo, so we can add debugging info in envtest.

#1242 might solve this by sharing the envtest instance and therefore reducing the load. If it fails we could have another go debugging envtest.


merge from arlac77/npm-package-template-esm-only

.gitignore

chore(git): update .gitignore from template

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   91.39%   91.39%
=======================================
  Files           6        6
  Lines         302      302
  Branches       44       48    +4
=======================================
  Hits          276      276
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b626ad8...54a0175. Read the comment docs.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Question: does this library support Universal?

If so is there a sample available?
Thanks.

It should. It has been written with server side scenarios in mind. You could write a custom Storage (simple 4 methods or sth.) which saves the tokens within cookies. You can register it with setStore(...).
If you want, you can contribute a demo for this, when you go this way.

@manfredsteyer I went so far and have given up.
I started by implementing a custom OAuthStorage as you suggested (cookie based) and this went well enough.  Some issues I ran into after that:

UrlHelperService references "window" to get the hash.  This was blowing up in Node for obvious reasons.  I did create a custom provider to replace this service but it could never function properly anyways since the server will never be aware of the fragment.

OAuthService has a function called debug.  This does not work either, results in: 'Cannot read property 'apply' of undefined'.

Thanks for pointing this out. I will deal with 1) and 2) for the next release and I will adopt the docs w/ your findings.

@manfredsteyer Thanks for the great library!!
@k-schneider  I was able to get server-side rendering and AoT working by implementing OAuthStorage interface. I'm working on a detailed blog post and will update readme once it's done.
Working sample: https://github.com/lankaapura/Angular-AspNetCore-Idsvr
Points of interest:

All OAuth related method calls except getToken are set to execute only in client side.
OAuthStorage interface has two implementations. Server version only has 'get' method implemented.
It seems we don't need to call setStorage method since Angular inject OAuthStorage implementation.

This is a great sample. Thanks for this. Can I create a documentation page that points to your sample and/ or article?

@manfredsteyer Yes you can 👍

Thx in adv. It's now part of the docu and the new version will land soon.


Permission Denied on 2nd build

Hey guys could use some help here.. got everything working properly.. I'm also exposing mariadb to a mounted volume so data is persistent.
The problem is I can set everything up... run docker-compose build, then docker-compose up, I see the db folder gets built by mariadb (those files are restricted to osx root only user) and things are running fine.
However when I run another docker-compose build command I run into issues from my php container complaining about access to the db folder which is setup from mariadb container... I'm not sure if this has something to do with /etc/exports and permissions of that folder but I can't build anything else unless I delete the db folder in the root...
I'm not sure if any of the options for docker-machine-nfs will help with this issue...

`#docker-machine ip default

web:
    build: .
    container_name: web
    ports:
        - "9090:80"
    volumes:
        - /Users/bartdabek/Sites/hgv/hgv_data/sites/:/code
        - ./site.conf:/etc/nginx/conf.d/site.conf
        - ./nginx.conf:/etc/nginx/nginx.conf
        - ./sites-enabled:/etc/nginx/sites-enabled
    links:
        - php
        #- mariadb
        - memcached
php:
    container_name: php
    build: .
    dockerfile: Dockerfile-php
    volumes:
        - /Users/bartdabek/Sites/hgv/hgv_data/sites/:/code
        - ./Tideways.php:/usr/local/lib/php/extensions/no-debug-non-zts-20151012/Tideways.php
    links:
        #- mariadb
        - memcached
memcached:
  container_name: memcached
  image: sameersbn/memcached:latest
  ports:
    - "11211:11211"
  restart: always
mariadb:
  container_name: mariadb
  image: mariadb
  volumes:
    - /Users/bartdabek/Sites/docker/db/:/var/lib/mysql
  environment:
    DB_ADMIN_PASS: pass
    MYSQL_ROOT_PASSWORD: root
  ports:
    - "3306:3306"
`

Basically I need to change permissions back on the db folder to get things to build again

drwxr-xr-x  11 bartdabek  staff    374 19 May 00:02 .
drwxr-xr-x  13 bartdabek  staff    442 16 May 15:36 ..
-rw-r--r--   1 bartdabek  staff    365 18 May 22:58 Dockerfile
-rw-r--r--   1 bartdabek  staff    267 18 May 22:26 Dockerfile-data
-rw-r--r--   1 bartdabek  staff   1642 18 May 23:06 Dockerfile-php
-rw-r--r--@  1 bartdabek  staff  43748 17 May 21:44 Tideways.php
drwxr-xr-x  11 999        999      374 19 May 00:02 db
-rw-r--r--   1 bartdabek  staff   1006 19 May 00:02 docker-compose.yml
-rw-r--r--   1 bartdabek  staff    743 18 May 23:09 nginx.conf
-rw-r--r--   1 bartdabek  staff    508 16 May 15:38 site.conf
drwxr-xr-x   3 bartdabek  staff    102 18 May 23:13 sites-enabled

@raptor235 ,
What if you mount NFS with this option-
docker-machine-nfs <machine_name> --nfs-config="-alldirs -maproot=0"

@raptor235 Do you still have issues?


django.core.urlresolvers.NoReverseMatch:

Hi.
I have been testing django-fm in my project.  Creation and deletion of objects work fine, but I am having a problem with update.  When I click on 'OK' to submit the modal form after editing the update form, the changes are saved to the database.  But there is a problem with the callback:
Request URL:    http://<IP_ADDRESS>:8000/establishment/subspecialities/update/15/
Error:
django.core.urlresolvers.NoReverseMatch: Reverse for 'subspeciality_update' with arguments '()'  and keyword arguments '{'pk': ''}' not found. 1 pattern(s) tried: ['establishment/subspecialities/update/(?P<pk>\\d+)/$']
Edit and delete buttons :
Edit
`Delete`

As you can see, in the case of update, reverse is not finding the url because the pk kwargs is empty.  If I go up the call stack, I can see kwargs = {pk:'15'}, but I can't work out where of why it is being 'lost'
The only substantial differences between this and you demo example is that the subspeciality model has  a foreign key, and the CRUD urls are not defined in the root urls, but included.
Can you suggest any areas that I should check for mistakes?
Rgds

@FZambia Thanks for help. I had the same error :+1:


Fixed #32460 -- Allowed "label"/"do_not_call_in_templates" members in model choice enums.

An alternate solution to #14020, fixing ticket-32460. See my comment.

@pope1ni Thanks :+1: I pushed minor edits.
@shaib Do you want to take a look?

Test failure is not related with this patch.

Sorry I could not get to this sooner; for what it's worth, I approve.


[prod-beta] Merge main to prod-beta

Codecov Report

Merging #51 (6e0f1fc) into prod-beta (a8a2f56) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           prod-beta      #51   +/-   ##
==========================================
  Coverage      26.47%   26.47%
==========================================
  Files             55       55
  Lines            642      642
  Branches         136      136
==========================================
  Hits             170      170
  Misses           420      420
  Partials          52       52

Impacted Files
Coverage Δ

src/components/automation-hub/hub-card.js
5.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a2f56...6e0f1fc. Read the comment docs.


Automated Package Upgrade

:tada: This PR is included in version 7.7.81 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


change duration specification

 Start+Inf als Option für den Vektor-Upload

Pull Request Test Coverage Report for Build 963790597

10 of 12 (83.33%)  changed or added relevant lines in 1 file are covered.
14 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 80.355%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

operators/src/source/ogr_source.rs
10
12
83.33%

Files with Coverage Reduction
New Missed Lines
%

operators/src/util/input/string_or_number.rs
1
80.0%

datatypes/src/primitives/time_instance.rs
2
65.0%

operators/src/concurrency/thread_pool.rs
11
91.93%

Totals

Change from base Build 957405564:
-0.03%

Covered Lines:
17294

Relevant Lines:
21522

💛  - Coveralls


transpiler bug encountered

Information

Qiskit Terra version: 0.18.1
Python version: 3.7.6
Operating system: Linux

What is the current behavior?
Got following errors while using crx and rx gates:

/gpfs/software/Anaconda/envs/psifour/lib/python3.7/site-packages/ipykernel_launcher.py:72: RuntimeWarning: invalid value encountered in double_scalars
/gpfs/home/yuluwang/.local/lib/python3.7/site-packages/qiskit/transpiler/runningpassmanager.py:166: UserWarning: Resynthesized [<qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba5022b40>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba5022280>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba5022910>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba72f9d70>] and got global phase: π
┌───────┐┌────┐┌─────────────┐┌────┐┌──────────┐
qr_0: ┤ Rz(π) ├┤ √X ├┤ Rz(-3.1415) ├┤ √X ├┤ Rz(-π/2) ├
└───────┘└────┘└─────────────┘└────┘└──────────┘, but the original was native and the new value is longer.  This indicates an efficiency bug in synthesis.  Please report it by opening an issue here: https://github.com/Qiskit/qiskit-terra/issues/new/choose
new_dag = pass_.run(dag)
Steps to reproduce the problem
Using Rx and Crx gates. I applied parameter binding and noise model at the same time.
transpiled_circ = transpile(circ, backend=backend,optimization_level=3)
circ = transpiled_circ.bind_parameters(para_dict)
job = execute(circ, backend=backend, shots=shots,coupling_map=coupling_map, basis_gates=basis_gates,  noise_model=noise_model)
What is the expected behavior?
Suggested solutions

It seems duplicated with #7033.

You mean the warnings? or is there an error?

@1ucian0  Hi Luciano, sorry it's a warning. It kept shows up and asks me to report this issue.

I don't think I can reproduce this without an example value of circ, and I mis-wrote the warning — the relevant information should be printed where all those DAGNodeOp strings are appearing instead. #7048 contains a better warning string. Could I ask you to supply an example circ or, if that's sensitive information, to re-run with the warning string from #7048 and paste its output?

It's hard to reproduce it because I think it connects to the value I assigned to theta. Once I changed the value the warning disappears. Unfortunately in my algorithm where thousands circuits submitted and ran has such warnings for several times.
Here is the one example for you:
backend = Aer.get_backend('qasm_simulator')

real_backend = provider.get_backend("ibmq_santiago")
noise_model = NoiseModel.from_backend(real_backend)
# Get coupling map from backend
coupling_map = backend.configuration().coupling_map
# Get basis gates from noise model
basis_gates = noise_model.basis_gates

from qiskit.circuit import Parameter
theta0 = Parameter("θ_0")

cc=QuantumCircuit(2,1)
cc.h(0)
cc.crx(theta0,0,1)
cc.cx(0,1)
cc.cx(0,1)
cc.crx(-theta0,0,1)
cc.h(0)
cc.measure(0,0)
transpiled_circ = transpile(cc, backend=backend,optimization_level=3)

para_dict = {theta0: 9.723602566887436e-05}
shots = 8192

qc = transpiled_circ.bind_parameters(para_dict)
job = execute(qc,backend=backend, shots=shots,coupling_map=coupling_map, basis_gates=basis_gates,  noise_model=noise_model)
counts = job.result().get_counts()

The warning I got:
/gpfs/home/yuluwang/.local/lib/python3.7/site-packages/qiskit/transpiler/runningpassmanager.py:166: UserWarning: Resynthesized [<qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0f30>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0ec0>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0c90>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0e50>] and got       ┌────────────────┐┌────┐┌─────────────┐┌────┐┌───────┐ qr_0: ┤ Rz(2.2835e-12) ├┤ √X ├┤ Rz(-3.1415) ├┤ √X ├┤ Rz(π) ├       └────────────────┘└────┘└─────────────┘└────┘└───────┘, but the original was native and the new value is longer.  This indicates an efficiency bug in synthesis.  Please report it by opening an issue here: https://github.com/Qiskit/qiskit-terra/issues/new/choose   new_dag = pass_.run(dag) /gpfs/home/yuluwang/.local/lib/python3.7/site-packages/qiskit/transpiler/runningpassmanager.py:166: UserWarning: Resynthesized [<qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e6670>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0520>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0130>, <qiskit.dagcircuit.dagnode.DAGNode object at 0x2aaba73e0d70>] and got       ┌────────────────┐┌────┐┌─────────────┐┌────┐┌───────┐ qr_0: ┤ Rz(2.2835e-12) ├┤ √X ├┤ Rz(-3.1415) ├┤ √X ├┤ Rz(π) ├       └────────────────┘└────┘└─────────────┘└────┘└───────┘, but the original was native and the new value is longer.  This indicates an efficiency bug in synthesis.  Please report it by opening an issue here: https://github.com/Qiskit/qiskit-terra/issues/new/choose   new_dag = pass_.run(dag)

Thanks so much! I can reproduce that.

I understand the issue and like you I also lean away from simply raising the tolerance without thinking through carefully.
Let me ponder this for a little.

It's not yet clear if it's a related issue, but the first line in the log from #7041 shows a single gate (supposedly belonging to ['p', 'sx', 'x']) being mis-synthesized into a pair of sxes. That could well turn out to be a symptom of the theta error I was worried about above.

I had a start at doing this based on estimated infidelity. Here's where I got to before I had to switch to other things.
    @staticmethod
    def _circuit_psx_gen_fid(tgt, theta, phi, lam, phase, infid, pfun, xfun, xpifun=None):
        """
        Generic X90, phase decomposition

        NOTE: `pfun` is responsible for eliding gates where appropriate (e.g., at angle value 0).
        """
        qr = QuantumRegister(1, "qr")
        circuit = QuantumCircuit(qr, global_phase=phase)
        mintr2 = 4 - 6 * infid  # Minimum acceptable |Tr(Ud.Uapprox)|^2

        # Shift theta and phi to turn the decomposition from
        # RZ(phi).RY(theta).RZ(lam) = RZ(phi).RX(-pi/2).RZ(theta).RX(pi/2).RZ(lam)
        # into RZ(phi+pi).SX.RZ(theta+pi).SX.RZ(lam) .
        theta, phi = theta + np.pi, phi + np.pi
        phase -= np.pi / 2

        tr2_none = 4 * math.sin(theta / 2) ** 2 * math.sin((lam + phi) / 2) ** 2
        if tr2_none > mintr2:
            return circuit

        tr2_p = 2 - 2 * math.cos(theta)
        if tr2_p > mintr2:
            pfun(circuit, qr, lam + phi + np.pi)
            return circuit

        tr2_x = (
            1
            + math.cos(theta) * math.cos(phi) * math.cos(lam)
            + math.sin(phi) * math.sin(lam)
            - math.sin(theta) * (math.sin(phi) + math.sin(lam))
        )
        if tr2_x > mintr2:
            xfun(circuit, qr)
            return circuit

        angle_px = (
            math.atan2(math.sin(theta) - math.sin(phi), math.cos(theta) * math.cos(phi)) + lam
        )
        tr2_px = (
            math.cos((-theta - phi + lam - angle_px) / 2)
            + math.cos((theta - phi + lam - angle_px) / 2)
            - 2 * math.sin(theta / 2) * math.sin((phi + lam - angle_px) / 2)
        ) ** 2 / 2
        angle_xp = (
            math.atan2(math.sin(theta) - math.sin(lam), math.cos(theta) * math.cos(lam)) + phi
        )
        tr2_xp = (
            math.cos((-theta - phi + lam + angle_xp) / 2)
            + math.cos((theta - phi + lam + angle_xp) / 2)
            - 2 * math.sin(theta / 2) * math.sin((phi + lam - angle_xp) / 2)
        ) ** 2 / 2
        if max(tr2_px, tr2_xp) > mintr2:
            if tr2_px > tr2_xp:
                pfun(circuit, qr, angle_px)
                xfun(circuit, qr)
            else:
                xfun(circuit, qr)
                pfun(circuit, qr, angle_xp)
            return circuit

        tr2_pxp = 2 * (1 + abs(math.sin(theta)))
        if tr2_pxp > mintr2:
            offset = np.pi / 2 if theta < 0 else -np.pi / 2
            pfun(circuit, qr, lam + offset)
            xfun(circuit, qr)
            pfun(circuit, qr, phi + offset)
            return circuit

        tr2_xx = 4 * math.cos(theta / 2) ** 2 * math.cos((lam - phi) / 2) ** 2
        if tr2_xx > mintr2:
            if xpifun:
                xpifun(circuit, qr)
            else:
                xfun(circuit, qr)
                xfun(circuit, qr)
            return circuit

        tr2_xxp = 2 + 2 * math.cos(theta)
        if tr2_xxp > mintr2:
            if xpifun:
                xpifun(circuit, qr)
            else:
                xfun(circuit, qr)
                xfun(circuit, qr)
            pfun(circuit, qr, -lam + phi)
            return circuit

        angle_xpx = math.atan2(
            math.sin(theta) * (math.cos(phi) + math.cos(lam)),
            math.cos(theta) * (1 + math.cos(phi) * math.cos(lam)) + math.sin(phi) * math.sin(lam),
        )
        tr2_xpx = (
            4
            * (
                math.cos(theta / 2) * math.cos(angle_xpx / 2) * math.cos((phi - lam) / 2)
                + math.cos((phi + lam) / 2) * math.sin(theta / 2) * math.sin(angle_xpx / 2)
            )
            ** 2
        )
        if tr2_xpx > mintr2:
            xfun(circuit, qr)
            pfun(circuit, qr, angle_xpx)
            xfun(circuit, qr)
            return circuit

        # FIXME: figure out angles and traces for this case
        angle1_xpxp = 0
        angle2_xpxp = 0
        tr2_xpxp = 0
        angle1_pxpx = 0
        angle2_pxpx = 0
        tr2_pxpx = 0
        if max(tr2_pxpx, tr2_xpxp) > mintr2:
            if tr2_pxpx > tr2_xpxp:
                pfun(circuit, qr, angle1_pxpx)
                xfun(circuit, qr)
                pfun(circuit, qr, angle2_pxpx)
                xfun(circuit, qr)
            else:
                xfun(circuit, qr)
                pfun(circuit, qr, angle2_xpxp)
                xfun(circuit, qr)
                pfun(circuit, qr, angle1_xpxp)
            return circuit

        # No special case applies, use the generic pxpxp decomposition
        pfun(circuit, qr, lam)
        xfun(circuit, qr)
        pfun(circuit, qr, theta)
        xfun(circuit, qr)
        pfun(circuit, qr, phi)
        return circuit

It gives optimal approximations for nearly all special cases.
Open issues:

I didn't make any effort to get the global phase right for the approximations. That should be doable but needs care.
I didn't get optimal approximations for the xpxp and pxpx cases, and I'm guessing we'd need to do some power series or other approximation to the best choice for the angles. Even if we can't do much it should be better than the status quo of choosing angle1=theta, angle2=phi.
I didn't do profiling to see if all the trig calculations end up adding a meaningful performance hit (we could plausibly use cython etc to claw much of that back if needed)

Anyone want to pick this up? otherwise I'll try to find time but not likely in time for 0.19

I'm happy to pick this up. I think coupling fidelity estimation and approximation dodges my worry about theta in option #2.
Similarly no guarantees about 0.19, but it could conceivably happen.


Extension change logs don't render markdown tables

VSCode Version: 1.12.2
OS Version: Windows 10

Just published the newest version of my extension and the markdown tables in the change log aren't rendering, leaving changes unreadable.
Steps to Reproduce:

But when previewing the source from the source project vscode does render tables

The markdown preview uses our builtin markdown extension for rendering, which targets commonmark and does support tables.
Extension readmes use marked from the core vscode for rendering, which does not support tables. It looks like the marketplace also does not render tables: https://marketplace.visualstudio.com/items/pflannery.vscode-versionlens/changelog
@joaomoreno I believe we should probably bring the extension readme markdown rendering more in line with github. Do you know who we need to contact on the marketplace team to get this updated as well?

The marketplace does support different Markdown engines. It seems that GitHub flavoured is their default, so it just seems to be an additional issue for them. cc @divais

It turns out that we do support markdown tables, but the marked render we are using doesn't support tables in list items: https://github.com/chjj/marked/issues/811

I just picked up a new version of marked which seems to fix this issue:

Let me know if there are cases where this is still not working as expected


Api implementation 0.1

This adds the functionality currently present on https://github.com/RafaDdS/OpenCVGodot.
Implementation of:

Full Video Capture module
Some core methods for mat manipulation
Basic functionality on Mat, with conversion to Godot image
Imread from ImgCodecs
File of CVConsts

Great work! The only suggestion I have is to implement clang-format in your editor so that the code is consistently formatted.

It looks like your clang-format is working correctly, it's just the rules don't always make the code look very elegant if new lines aren't applied in a good place. I added new lines where I think they improve readability. Some of the changes look better than others, particularly the longer signatures - however the shorter signatures have less of a readability issue.


Add DART-FISH and seqFISH as new dataset types

Select the target metadata schema name (can be multiple), or choose 'Other' if not listed.
Other
If 'Other' is selected, please enter the schema name below.
No schema just new categorical values
Describe the change request (use a numbered list if many).
PSC requires new dataset types, DART-FISH and seqFISH, to be added into HRAVS.

Added to HRAVS v2.6.5


export a range of few tasks

My actions before raising this issue

[ ] Searched simialr ussues

Expected Behaviour
i want to export a range of few tasks by one click
Current Behaviour
now, i can export single task or single project
Possible Solution
possiblity of select wanted tasks for exporting and then click "export dataset tasks"

Why the project exporting is not working in this case?

I will close the issue, since there is not response.
Do not hesitate to reopen if you have any more thoughts about it.


Pretrained model on KITTI-360

Hi @anhquancao ,
Thanks so much and congratulate you on the acceptance of your paper at CVPR2022. Do you try to train your model on the KITTI-360 dataset? I want to evaluate the result on KITTI-360, have you ever tried to generate the SSC groundtruth of KITTI-360?
Thanks.

Hi @ngoductuanlhp
Thank you for your kind words! We didn't train MonoScene on the KITTI-360 dataset since there is no SSC ground-truth available.
We didn't want to generate the SSC ground truth by ourselves since it might be inconsistent with the official dataset.

Hi @anhquancao , I have tried to generate the SSC ground truth for KITTI-360 to train your model on this dataset. However, the loss is very weird. Do you have any suggestions for training on KITTI-360, which config do I need to modify? And could you provide the log train of your model on semantic-KITTI?
Thansks

You can take a look at this data loader for the kitti_360 dataset
https://github.com/anhquancao/xmuda-extend/blob/master/xmuda/data/kitti_360/kitti_360_dataset.py
For the log, I uploaded them to this link
https://tensorboard.dev/experiment/NFmpSQQRREub4wVwRyQMKw/#scalars&_smoothingWeight=0


[CP] Don't re-initialize the default RenderSurface when returning from hybrid composition mode

Issue Link
https://github.com/flutter/flutter/issues/141565
Target
stable
PR Link
https://github.com/flutter/engine/pull/50464
Changelog Description
App crashes after upgrading to 3.16.x if app uses native webview
Impacted Users
Android users
Impact Description
App crash
Workaround
Donwgrad to Flutter 3.13.9
Risk
low
Test Coverage
no
Validation Steps
No response

We're also facing this crash, a CP would be more than welcome.

@agacemi before we can go ahead with this, we'll need a PR opened to the stable branch. Can you update your PR description with a PR pointing to flutter-3.16-candidate.0? Thanks!

@CaseyHillers https://github.com/flutter/engine/pull/50464 by my colleage (thank you Emmanuel). I updated PR description with PR link.

For context, the 3.16 stable is near end of life, and we're getting ready to promote a new stable.
Is this issue reproducing on the 3.19 beta? If so, we should CP it there first.

I see. As we blocked Android publication due to 2000 crashs/days we look for an hot fix with minimal impact.
New flutter sable version integration, like 3.19, needs a couple of weeks because we a make a large non-regression across our application. Also, we usually waits mutliple flutter patch to use flutter stable version  in production

Stable is now 3.19 which includes the requested fix. We don't plan to ship any new hotfixes to 3.16, so please upgrade to get the requested fix.


Is there any requirement on the input graph?

Can the input graph contain multi edges between single pair of nodes? Can the graph be non-bidirected? (Directed graph that some edges don't have reverse edges) Can the graph have self-loop?
Also is the answer here also applied to mt-Kahip?
Thanks!

Hi,
please have a look into the manual.

Multiple (parallel) edges are not allowed
non-bidirected is not allowed
self-loops are not allowed.

Best
Christian


WSO2 EI 7 documentation  - UX bugs

When the 'Integrator' drop down is selected opened, it does not close.

duplicate of https://github.com/wso2/docs-ei/issues/412


TypeError: config is null

I created a new Vue.js app and added vue-apollo via vue add apollo
After starting my app I'm getting a white screen of death and there is a error in the console
TypeError: config is null
  InMemoryCache bundle.esm.js:863
  createApolloClient index.js:76
  createProvider vue-apollo.js:60
  <anonymous> main.js:28
  js app.js:5385
  __webpack_require__ app.js:767
  fn app.js:130
  0 app.js:5471
  __webpack_require__ app.js:767
  <anonymous> app.js:902
  <anonymous> app.js:905

If I remove apolloProvider: createProvider(), from the new Vue() instance the app works.
It's all a base install with no modifications to the code and I can't find anything in the docs about a config
Am I missing some type of configuration that's not documented in the docs?
Update
The TypeError: config is null was the error I got while using Firefox. I opened my app in Chrome and got this error.
Cannot read property 'freezeResults' of null
I searched the issues and found this issue https://github.com/Akryum/vue-apollo/issues/631
It has a solution that got my app working, but it doesn't feel ideal. It seems like there is a bug in apollo-cache-inmemory or Vue Apollo needs to update the default vue-apollo.js config file.

I just ran into this error as well. As my first attempt of using vue-apollo it doesn't feel convenient .
vue-cli: v3.8.4
vue: v2.6.10
vue-apollo: v3.0.0-beta.11
To reproduce just create a new Vue project with the cli, add vue-apollo and start both apollo and the app.

Duplicate of #630


Abort via escape key not working for Text Extractor when Win+Shift+S Snip & Sketch is open

Microsoft PowerToys version
0.68.1
Installation method
GitHub, PowerToys auto-update
Running as admin
No
Area(s) with issue?
TextExtractor
Steps to reproduce
It's hard to call this a bug. It's rather a minor inconvenience/oddity. Letting you know about this regardless:

Press Win+Shift+S to bring up the windows screenshot snipping tool thing (not sure what it's officially called. is it Snip & Sketch?)
While Snip & Sketch is open and wants you to select something for a screenshot, open the Text Extractor as well via the assigned keyboard shortcut
Press escape to close Snip & Sketch (which should be on top)
Snip & Sketch seems to close and Text Extractor opens now
Pressing Escape will not close Text Extractor (Text Extractor won't close unless you select something)

✔ Expected Behavior
The escape key should close Text Extractor.
❌ Actual Behavior
The escape key does not close Text Extractor.
Other Software
Snip & Sketch not sure which version. Windows is:
Edition	Windows 10 Pro
Version	22H2
Installed on	04/12/2022
OS build	19045.2604
Experience	Windows Feature Experience Pack 120.2212.4190.0

When opening Text Extractor first and then opening Win+Shift+S Snip & Sketch, both overlays close as expected when pressing escape twice

Thanks for the report. This is easily reproducible. We'll take a look. Looks like TextExtractor loses focus, as when I right-click after closing Snipping tool, Escape works and closes TextExtractor

This appears to be fixed! Going to close :)


Removed now unnecessary array fix

Removed some changes from #147 that are no longer neccessary and gets rid of a warning that Unreal spams in console when using RPCs with arrays.

Thank you ⭐


EARLIEST_AVAILABLE_DATE handling changes (and more)

Evan:
The 2020 historical ingest is in progress (December and November complete, and adding a month every two days), so I looked at updating EARLIEST_AVAILABLE_DATE, and thought "I love Unix TS as much or more than the next person, but this isn't a friendly place to use them!"
I'm not at ALL sure the min/maxDJS variables will be correct at all times (or if they are, I'm not sure I understand why), so PLEASE look at it carefully before assuming I knew what I was doing, and don't be shy about asking me questions or suggesting changes!!!!!!

accept Unix TS or ISO date (YYYY-MM-DD) [for now]
document.settings.earliestAvailableDate is now string
update dev config for 2020 historical ingest

As usual, much more, semi-related changes:
SearchDatePicker tweaks:

remove "We are still working with the Wayback Machine" message
centralize dateFormat (add comment about localization)
remove direct access to settings.earliestAvailableDate
keep min/max dates in dayjs format (avoid reparsing)
parse newValue once in change handlers
Only display "Reingest of historical data in progress" for MC
(was displaying MC start date for Wayback Machine?)

More date-related simplification:

removed mcweb/frontend/src/features/search/util/dateHelpers.js
use dayjs.unix() to simplify validateDate function

The reason I originally used unix was when using ISO I was running into the problem of JS dividing the dates 😅 , which looks to have been solvable by making it a string when adding to the document 🧠 . I think all looks good and I am good with theses changes. As for the question about minDJS and maxDJS getting re-executed, they should every time the platform changes, useSelector is a listener and should refetch anytime anything it is listening to changes 🙏


Basic auth accepts wrong password as a correct one!

Privileged issue

[X] I'm @tiangolo or he asked me directly to create an issue here.

Issue Content
from fastapi import Depends, FastAPI, HTTPException
from fastapi.security import HTTPBasic, HTTPBasicCredentials
from starlette.status import HTTP_401_UNAUTHORIZED

app = FastAPI()

security = HTTPBasic()

def get_current_username(credentials: HTTPBasicCredentials = Depends(security)):
    if credentials.username != "foo" or credentials.password != "password":
        raise HTTPException(
            status_code=HTTP_401_UNAUTHORIZED,
            detail="Incorrect email or password",
            headers={"WWW-Authenticate": "Basic"},
        )
    return credentials.username

@app.get("/users/me")
def read_current_user(username: str = Depends(get_current_username)):
    return {"username": username}

import uvicorn

uvicorn.run(app, host="<IP_ADDRESS>", port=8000)

Hi I'm struggling to place a basic auth, and using the latest fastapi version but still the app is working with any random string

That's not an issue.
On the other side, your code is working as expected, I'm going to assume, that when you said that is working with any random string, you're referring to the swagger green button for "Authorize". Remember, that button has no verification after you enter your credentials. If you run your code without putting anything in Authorize beforehand, you're going to see something like:

And that input has the verification of your code to check username and password.
Check this for more info: https://fastapi.tiangolo.com/advanced/security/http-basic-auth/


another two byte the dust

I should probably stop at some point but keep getting ideas...
use XOR to make snake and food handling smaller
changes food and snake characters but still looks good I think
as a bonus you can see the food being digested by the snake ;)

I'm not near my computer to check it but at this point I trust you... Thanks!

I'm not near my computer to check it but at this point I trust you... Thanks!

No rush, but thanks for the confidence


WIP: Bump API level in docs for the podFailurePolicy field

Update the docs as podFailurePolicy is now Beta, see: https://kubernetes.io/docs/concepts/workloads/controllers/job/#pod-failure-policy
We may need to cherry-pick it as it is Beta since 1.26.

/close
The generator pipeline should be updated rather than a manual fix. Issue opened for now: https://github.com/kubernetes/website/issues/42112

/reopen

This might actually be ready for review. Informally, LGTM.

FYI @alculquicondor
Can you lgtm from the technical POV?

@sftim the PR is now LGTMed, can you please approve?
FYI @AryanSharma9917 who assigned to the generic Issue.

Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

You might be asking the wrong person. However, good news - this week I'm also on the PR wrangling rota.
/approve


Add SaplingHack

#MakeBGHappyAgain

Note worthy: Default config values are entirely just random, no thought behind them at all

Perhaps the default value for allow_fortune could be added to the default config?
Because people won't know about the existence of this feature.

Woops forgot to include it


"sharing" the rkt data directory across a shared bindmount breaks rkt rm

This was uncovered while @pbx0 was working on kubelet-wrapper + rktnetes.
I'm reviving the discussion since I'd like to have a definitive answer as to whether creating shared bindmounts of the rkt data-directory should be supported or not in light of containerized-kubelet + rktlet.
I think that this is something we should try to support for the sort of "rkt in rkt, but with a shared data directory" cases (e.g. one pod which wants to get information about other pods).
This issue is related to #1922 and #1856
The issue can be easily reproduced by doing the following:
# mkdir -p /var/lib/rkt2
# mount --rbind --make-shared /var/lib/rkt /var/lib/rkt2
# rkt run --uuid-file-save=/tmp/uuid --insecure-options=image docker://busybox
...
# rkt rm --uuid-file=/tmp/uuid
networking: teardown - executing net-plugin ptp
rm: unable to remove pod "d45d7728-b3d6-44e5-a95f-92fe34111b3f": remove /var/lib/rkt/pods/exited-garbage/d45d7728-b3d6-44e5-a95f-92fe34111b3f/stage1/rootfs: device or resource busy
# mount | grep $(cat /tmp/uuid)
overlay on /var/lib/rkt2/pods/exited-garbage/d45d7728-b3d6-44e5-a95f-92fe34111b3f/stage1/rootfs type overlay .....

The reason this breaks as such is that rkt rm and rkt gc explicitly do a remount unshare of each mount under a pod. I think this was added because of some issue with systmed-udevd holding mounts, but I forget the details, sorry!
This working could be useful for containerized-kubelet / kubelet-wrapper and will impact some design choices.
@pbx0 and @yifan-gu have some context on this as well.
cc @lucab @s-urbaniak, this relates to rktlet since depending on whether this could or should be supported, we might have to break out of any container we're in for all rkt cli calls.

The "remount unshare" (MS_PRIVATE) is done in MountGC. It was done initially for rkt fly.
I can reproduce the error "device or resource busy" without rkt with the following:
mkdir /var/lib/foo /var/lib/foo2
mount --rbind --make-shared /var/lib/foo /var/lib/foo2
cd /var/lib/foo

mkdir -p rootfs
mount -t tmpfs none rootfs
mkdir -p rootfs/rootfs
mount -t tmpfs none rootfs/rootfs

mount --make-private rootfs/rootfs
mount --make-private rootfs
umount rootfs/rootfs
umount rootfs
mountpoint rootfs # rootfs is not a mountpoint

rmdir rootfs/ # Device or resource busy

/cc @steveeJ

@euank You're right, it is the same issue as the thing with systemd-udevd again:
$ cat /proc/self/mountinfo |grep /var/lib/foo/
$ cat /proc/$(pidof systemd-udevd)/mountinfo |grep /var/lib/foo/
242 45 0:49 / /var/lib/foo/rootfs rw,relatime master:87 - tmpfs none rw,seclabel
265 242 0:62 / /var/lib/foo/rootfs/rootfs rw,relatime master:94 - tmpfs none rw,seclabel

Not only systemd-udevd, but any services that is started with MountFlags=slave or equivalent:
$ for i in $(grep /var/lib/foo/ /proc/*/mountinfo|cut -d/ -f3) ; do cat /proc/$i/comm ; done|uniq
bluetoothd
NetworkManager
dhclient
colord
systemd-udevd

Just to add, this is the current work around we add to our rktnetes configuration in coreos-kuberetes: https://github.com/coreos/coreos-kubernetes/pull/551/commits/78acfe9c99822cf369fe9a12addd514a1331c719
Any extra configuration steps required just make rktnetes more fragile to install by people not using that repo's install scripts.

My previous comment was wrong: this is not related to systemd-udevd, bluetoothd or others. I tested again without services like systemd-udevd that "captures" the mount and the same issue still happens.
This is caused by the way vfs_rmdir() and __is_local_mountpoint() are implemented: rmdir is allowed only when the dentry is not used as a mountpoint in the same mount namespace.

the mountpoints in the systemd-udevd mount namespace are not relevant because only the mounts in the same mount namespace are checked (after Linux v3.18 with commit https://github.com/torvalds/linux/commit/8ed936b and others).
__is_local_mountpoint() checks the dentry and not the struct path. This means the mount where the path being deleted is not checked. So we cannot delete the path /var/lib/foo/rootfs because although it is not used as a mount point at this path, the same dentry is used as a mount point under /var/lib/foo2/rootfs.

It might be possible to fix this in the kernel by checking the path in addition to the dentry, but it's not easy because __is_local_mountpoint() does not have access to the struct path, and it would involve lots of changes in vfs (rmdir, unlink, rename), p9, nfsd...

@alban what's the reason we needed to remount with MS_PRIVATE bit in MountGC?
If we can get away without that, it seems like the simplest fix, and if it was only needed for some specific case in rkt fly maybe we could detect needsRemount better and fix this that way.

Pinging this issue since I was reminded of it over here https://github.com/coreos/coreos-kubernetes/pull/768#discussion_r91809201 and it still has real impact.
I think we should definitely make non-fly stage1s not unshare mounts during rm (and that's an easy / not very scary fix).

is there an update on this one? I still see it happening even with the nsenter workaround. My kubelet log is full off
Jan 03 16:58:42 c1 kubelet-wrapper[1569]: stderr: rm: unable to remove pod "97a1eab5-0822-475b-a06e-32d47a4c3bc9": remove /var/lib/rkt/pods/exited-garbage/97a1eab5-0822-475b-a06e-32d47a4c3bc9/stage1/rootfs: device or resource busy
Jan 03 16:58:42 c1 kubelet-wrapper[1569]: , rkt: Failed to clean up rkt pod "b6d875ab-bd04-40c5-8080-eae43b09b50e": rkt: Failed to remove pod "b6d875ab-bd04-40c5-8080-eae43b09b50e": failed to run [rm b6d875ab-bd04-40c5-8080-eae43b09b50e]: exit status 254
Jan 03 16:58:42 c1 kubelet-wrapper[1569]: stdout:

and rkt list is unhappy:
core@c1 ~ $ rkt list
UUID		APP			IMAGE NAME									STATE	CREATED		STARTED		NETWORKS
022c32e8	kube-controller-manager	quay.io/coreos/hyperkube:v1.5.1_coreos.0					running	9 minutes ago	9 minutes ago
11be175f	checkpoint		quay.io/coreos/pod-checkpointer:b4f0353cc12d95737628b8815625cc8e5cedb6fc	running	9 minutes ago	9 minutes ago
313cd2f0	checkpoint-installer	quay.io/coreos/pod-checkpointer:b4f0353cc12d95737628b8815625cc8e5cedb6fc	running	9 minutes ago	9 minutes ago
44e32c00	hyperkube		quay.io/coreos/hyperkube:v1.5.1_coreos.0					running	10 minutes ago	10 minutes ago
499433c7	flannel			quay.io/coreos/flannel:v0.6.2							exited	11 minutes ago	11 minutes ago
7b3afaa9	kube-apiserver		quay.io/coreos/hyperkube:v1.5.1_coreos.0					running	9 minutes ago	9 minutes ago
87b0a719	kube-proxy		quay.io/coreos/hyperkube:v1.5.1_coreos.0					running	10 minutes ago	10 minutes ago
bd5b28d7	kube-scheduler		quay.io/coreos/hyperkube:v1.5.1_coreos.0					running	9 minutes ago	9 minutes ago
ed867da4	flannel			quay.io/coreos/flannel:v0.6.2							running	11 minutes ago	11 minutes ago
list: 15 error(s) encountered when listing pods:
list: ----------------------------------------
list: Unable to read pod 02186a27-ae1d-47f2-b42f-446a9d68facd manifest:
  error reading pod manifest
list: ----------------------------------------
list: Unable to read pod 35d69a29-eaec-41da-9ff1-c4d0990c3082 manifest:
  error reading pod manifest
list: ----------------------------------------
list: Unable to read pod 3fcd45aa-cd40-44ad-9f85-5cc5986abc40 manifest:
  error reading pod manifest

same problem. http://stackoverflow.com/questions/41648460/error-reading-pod-manifest-on-exited-garbage-pods

@kfirufk Do you mind to recheck with rkt v1.22.0? We landed https://github.com/coreos/rkt/pull/3486 and it should resolve this issue.

@s-urbaniak unfortunately the base issue here (shared bindmounts + unsharing before umount in gc) isn't fixed by v1.22.0. It's possible some of the related problems are fixed, but if it's from kubelet wrapper / rkt fly / shared bindmounts, it's less likely to be resolved.

Comments above are on spot, the cleaning part should be much improved after #3486 (barring the mounts that are allowed to escape due to back-propagation). The remaining part/mess due to shared propagation is probably better tracked at https://github.com/coreos/rkt/issues/3465.

Still seeing this problem while trying to use the work-around listed above together with:
$ rkt version
rkt Version: 1.25.0
appc Version: 0.8.10
Go Version: go1.7.5
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL

Any updates?


mrb_bug() may raise an exception

mrb_bug() calls exit(), which is not caught by mruby.
However, it calls mrb_vformat() before that, which may raise an exception NoMemoryError or RuntimeError.
It may be desirable to replace mrb_vforamt() with a structure that directly outputs a compatible format to stderr, or some other mechanism.
# :thinking:

Compatible format specifiers should not output inspect results (?)
Should not use mrb_any_to_s() to get the class name of an instance internally (?)
Should not call mruby_vm_exec(), create objects, etc (?)
How should parameter compatibility with mrb_warn() (?)

Addressed by 82a48bd


[Question] Why wrapping the backends in Boxes?

Hi! I've got a little question about the code. Why do you need the Box::new for the backend variable? Can't we just write
let backend: Box<&mut dyn Backend> = match backend_config {
    #[cfg(feature = "imap-backend")]
    BackendConfig::Imap(ref imap_config) => ImapBackend::new(&account_config, imap_config),
    // and so on
}

?

Hi! I've got a little question about the code. Why do you need the
Box::new for the backend variable?

If I remember well, the rust compiler was not so happy about passing a
&mut dyn Backend directly. But I may have mistaken sth, I will give
another try. Thanks for pointing it out!

It looks like I cannot remove the Box, otherwise the compiler complains about the trait "Sized" is not implemented for "dyn Backend" :disappointed:


bug: HttpRequestError, AbiFunctionSignatureNotFoundError and TimeoutError when launching yarn chain as a forked endivonment

Is there an existing issue for this?

[X] I have looked through the existing issues

Current Behavior
When executing a local anvil as a forked environment, the blockexplorer page raises the following error:
Cannot connect to local provider
- Did you forget to run yarn chain ?
- Or you can change targetNetwork in scaffold.config.ts

The chainId remains 31337 even if it's a forked environment (just like when running yarn chain). After further inspection, my browser's console also throws (many consecutive times until the app freezes and crashes) the following exceptions:

AbiFunctionSignatureNotFoundError

Parsing failed: AbiFunctionSignatureNotFoundError: Encoded function signature "0xe797ec1b" not found on ABI.
Make sure you are using the correct ABI and that the function exists on it.
You can look up the signature here: https://openchain.xyz/signatures?query=0xe797ec1b.

URL: http://<IP_ADDRESS>:8545
Request body: {"method":"eth_getBlockByNumber","params":["0x933d44",true]}

Details: The request timed out.
Version<EMAIL_ADDRESS>    at Object.http (rpc.js:28:1)
    at fn (http.js:39:30)
    at request (http.js:40:41)
    at delay.count.count (buildRequest.js:26:1)
    at attemptRetry (withRetry.js:12:1)
    at eval (withRetry.js:22:1)
    at new Promise (<anonymous>)
    at withRetry (withRetry.js:3:1)
    at Object.eval [as request] (buildRequest.js:24:38)
    at fetch (fallback.js:16:1)
    at request (fallback.js:48:1)
    at delay.count.count (buildRequest.js:26:1)
    at attemptRetry (withRetry.js:12:1)
    at retry (withRetry.js:9:1)

HttpRequestError

URL: http://<IP_ADDRESS>:8545
Request body: {"method":"eth_getTransactionReceipt","params":["0x047bd5d6dca285e48878e8f6b85f95361c0c5a18bdb323dc24d99bf9dd6bb598"]}

Details: Failed to fetch
Version<EMAIL_ADDRESS>    at Object.http (rpc.js:55:1)
    at async fn (http.js:39:1)
    at async request (http.js:40:41)
    at async delay.count.count (buildRequest.js:26:1)
    at async attemptRetry (withRetry.js:12:1)

On a side note, if I kill the app (and chain) before it completely freezes, it ends up showing the 20 most recent transactions, which is part of the normal behavior.
Expected Behavior
The expected behavior is that the blockexplorer page shows the latest 20 transactions while no errors are being thrown nor freezes/crashes occurred, even if the local chain results from a forked environment
Steps To Reproduce
Install a scaffold-eth project:
npx create-eth@latest

choose foundry as the backend and install all packages.
Next, define a local .env file where we are storing the rpc url used to fork. I am forking goerli so:
echo "GOERLI_RPC_URL=<rpc-url-with-key>" > .env

Load this environmental variable
source .env

launch the forked chain
yarn chain --fork-url $GOERLI_RPC_URL

and launch the frontend on another terminal
yarn start

Finally open localhost:3000/blockexplorer on the browser.
(performing all these steps but without the --fork-url $GOERLI_RPC_URL parameter results in a working app, just as intended)
Anything else?
Screenshots
During the crash, it looks like this:

After killing the app in the terminal, it loads everything into the frontend:

System Information
uname -a:
Linux be79f216f043 <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

yarn --version:
3.2.3

Why are you doing this though?
I have a foundry project which I heavily tested locally through a local fork of the Goerli testnet (because my contracts interact with deployed contracts such as WETH and AAVE's lendingPool contract).
Now I've come to the point of building a front-end for my dApp, and since scaffold-eth supports foundry, I created a scaffold-eth project and migrated my whole foundry project into it (adapting the deployment scripts accordingly etc...), and then I started encountering this bug.
At first, I thought that the issue lied in my migration, but I ended up hunting down the bug to the forked chain (as you can see in the above issue, I haven't modified/deployed a smart contract at all).

UPDATE
It seems that, for some reason, these exceptions are all thrown by the useFetchBlocks() hook.

Hey @luksgrin thanks for raising the issue and detailed explanation, really appreciate it !!
It seems that when you fork a chain the chain id is changed in this case to 5 but you need to point to localhost RPC url
Because of this inconsistency and the way how Scaffold-ETH2 is configured, it fails to work nicely
I tried tinkering with it a bit, you can have look at this PR and make changes to your own repo :
https://github.com/technophile-04/foundry-goerli-fork-524/pull/1/files
https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/fb0774b7-9427-4282-b76b-19759be4e24c
NOTE: After loading is complete, there is slight blank screen with no data but its internally fetching all transactionReceipt so you have to wait a bit to see all the data (This needs to be handle)
Also, few things to note :

The logic for blockexplorer is naive and not optimised (which is fine since it was written keeping in mind to power local chain)
So the way logic works : It iteratively fetch each block data and also iteratively travels through each Txn Recipet for each block
Since we have forked the chain, by using blockexplorer page you are gonna exhaust your Alchemy RPC by making lot of eth_getBlockByIndex , eth_getTransactionReceipt

Nevertheless, this issue is free to grab if anyone wants to tackle it 🙌

Thank you @technophile-04 for your kind answer. I was able to make the blockexplorer work thanks to the modifications you did on your PR . Nonetheless, it perplexes me that while loading, I still get errors:

I believe these errors are silent due to the removal of the error return.
Also, would it be a way to bypass manually writing the settings for the GoerliFork? Initially I believed I could bypass the chainId issue by launching anvil as:
yarn chain --fork-url $GOERLI_RPC_URL --chain-id 31337

this way I would force it to continue being chainId 31337 instead of Goerli's chainId 5.

But this didn't help...
I will keep messing around with it. Maybe I can find something out. I would truly appreciate further comments/hints 😄

UPDATE
So, I wanted to tackle first the apparent issue of the chainId. Indeed, one can control its value with the --chain-id flag.  Given that within wagmi/chains (which calls viem/chains) the settings for hardhat and Goerli only changed on the chainId value, I reverted all modifications on the PR except the removal of the error return. This way, I reached the same results as previously, i.e.
POST http://<IP_ADDRESS>:8545/ net::ERR_INSUFFICIENT_RESOURCES

which after freezing for a bit, renders a fully functional block explorer. I do believe the issue may be in the way transactions are queried as mentioned here. I will try to optimize it so that my app does not crash under my specific conditions. I believe we are close! 😄

FINAL UPDATE

The long story
I did not optimize the transaction querying. To retrieve massive data, providers such as Alchemy should be preferred. Nonetheless, I found that reducing the number of blocks to query (from 20 to 10) substantially lowers the requests (duh!) and my app does not die. The errors are still present, but at least it renders in a reasonable amount of time. There's still the option of removing the error return so that the front end is not polluted, you know, for a clean demo video 😉
I am satisfied with this fix, and will remember it in case I find myself in a similar scenario in the future.

Thank you so much @technophile-04 for your response.
TLDR;
The cause of this issue is that the useFetchBlocks.ts is not optimized, so when forking a blockchain, it performs a huge amount of requests that may kill the server.
One can safely fork a blockchain and the app will work properly **as long as the chainId is 31337, which anvil allows to manually set via the --chain-id setting.

Tysm @luksgrin for the great research and comments, really appreciate it !!

So, I wanted to tackle first the apparent issue of the chainId. Indeed, one can control its value with the --chain-id flag. Because executing

This was a great finding !! Added it as todo in #470, so that when people use fork script from pacakge.json script we by default append --chaind-id 31337
Also noticed that this problem does not occur when you choose hardhat as solidity framework because forking chain on hardhat keeps the chaind as 31337 🙌
But thanks again !!

Just saying thanks to @luksgrin detailed research/explanation <3

Closing this for now, I think its recommended that you only use local block explorer when using a simple local chain.
Using forked chain / visiting local blockexplorer when on chains other than local chain will burn the SE-2 Alchmey RPC / your RPC node if updated  a lot.
Maybe on SE-2 side we should just return empty page / redirect / show warning message without making any request when you vising blockexplorer and chain is forked( this will be hard to figure out) / other chain.


WARN: scrollTo was called before RecyclerListView was measured, please wait for the mount to finish

Current behavior
I am simply trying to render a list of message objects which are fetched and updated from Firebase for a realtime chat. The problem is caused by using the onContentSizeChange property which works on FlatList. Is there a way to auto scroll to the bottom that I'm unaware of?
Expected behavior
No warnings. Flatlist scrolls to bottom when content size changes.
To Reproduce
 <FlashList
          ref={flatListRef}
          onContentSizeChange={() => flatListRef.current.scrollToEnd({ animated: true })}
          data={chats}
          estimatedItemSize={100}
          renderItem={({ item }) => <ChatMessage key={item.id} userId={item.owner} text={item.text} />}
        />

Platform:

[ ] iOS
[x] Android

Environment
v 1.4.3

Might not work for everyone, but setting the inverted prop to true made sure the flashlist kept in the bottom position when new items were added.

Might not work for everyone, but setting the inverted prop to true made sure the flashlist kept in the bottom position when new items were added.

Facing the same issue here.

It seems you can get around this warning by checking to see if the data variable is populated with a few items before calling scrollToEnd
const tryScroll = () => {
    if (myDataVariable.length >= 5) flashListRef.current.scrollToEnd()
}

<FlashList
    // ...
    data={myDataVariable}
    onContentSizeChange={tryScroll}
    // ...
/>

Same issue experienced

I found some sort of a workaround for my specific case, you just delay the function for 10ms:
`
onContentSizeChange={async () => {
await this.SomeMilliSecondsTimeout();
this.flatList.scrollToEnd({animated: false});
}}
....
.....
.....
 async SomeMilliSecondsTimeout  () {
    let valueTimeout = {key: false, value: "Timeout Error"};
    await new Promise((res, rej) => {
        setTimeout(res, 10, valueTimeout);
    });

}`

In my example i have got 60 items in my list. You can play around with the timer. This all happens inside a React.Component class, so dont wonder about my function notation. After doing this, the warning disappears

I'd suggest you can look into the onLoad callback on FlashList to do the same.

@naqvitalha thank you so much!


Added json parser

Customized parser for pebbel json data. matoka!!!! @rabimba @gaurabde please review.

@rabimba @gaurabde I see several problems with this kind of data:
a) This is scanned and summarized data over a period of time.
That period of time is 1 day.
This means, these fitbit/pebble applications have already run ML algorithms to extract patterns and have already populated the key:index tables for each feature.
b) If we get dumps from applications like google fit, garmin etc. those all would do the exact same work of already classifying the data to give you the end products.
What I would prefer is raw accelerometer/gyroscopic dumps so that

We can look at how our body performs on each of these activities like running, walking, sleeping etc. and then
We can develop our own classification schemes to draw conclusions to be utilized in other works.
Having said that, we can still use the summary data we just got to develop confusion matrices and stuffs like that.

Let me know if this makes sense.

Hence the data I gave, is raw.

Let's see how does that look like (from Ushree di)...


Proposed adjustments to the project lifecycle

Signed-off-by: John Mertic<EMAIL_ADDRESS>

I believe this should be discussed at the next TAC meeting since it represents fairly significant policy changes.

Hey @jfpanisset - yes the plan is to present these proposed changes and the motivations at the next TAC meeting. I left this as draft while I work with @kdt3rd on this.

LGTM overall. I really like the idea of sandbox projects.

I've broken this out into...
#267
#268
#269
#270
Will close this PR and manage through those 4.


Small tiny bare docu on /core

I've managed to make fortune-sheet work for core without react, in CDN is there any barebones documentation on how to create a worksheet there, I don't mind not having react, example:
https://observablehq.com/d/37ef873372b7f3e4
Being able to be used this way makes it easy to embed fortune sheet easily as a widget on any website

hi, sorry this does not exist now.  would you be willing to contribute this?

hi, sorry this does not exist now. would you be willing to contribute this?

after some analysis it seems that a big part of implementation is done on react like the toolbar, so there is no way to have the complete spreadsheet without react, that was what I didn't understand before, I thought react was a wrapper of a library that was already there, but I was wrong


Remove drawables for ic_launcher don't abort the build on lint errors.

Removes the unnecessary drawables that aren't used by the library.  This prevents compilation issues when other AARs are accidently including them as well.
Also set the build not to abort on lint errors.

Thank you for the pull request. I'd just like some clarification on why you want to set AbortOnError to false.

It was just so I can get a clean compile.  You can leave it as default if you want.

Merged by patch in c5ada44.

No problem all is well. Thanks for the quick merge.

:)


SqlTileWriter.createIndex - SQLiteDatabaseCorruptException - SQLITE_NOTADB

Issue Type
Crash
Description and/or steps/code to reproduce the problem
Stacktrace:
Fatal Exception: android.database.sqlite.SQLiteDatabaseCorruptException
file is not a database (code 26 SQLITE_NOTADB[26])
  android.database.sqlite.SQLiteConnection.nativeExecuteForChangedRowCount (SQLiteConnection.java)
  android.database.sqlite.SQLiteConnection.executeForChangedRowCount (SQLiteConnection.java:1074)
  android.database.sqlite.SQLiteSession.executeForChangedRowCount (SQLiteSession.java:756)
  android.database.sqlite.SQLiteStatement.executeUpdateDelete (SQLiteStatement.java:66)
  android.database.sqlite.SQLiteDatabase.executeSql (SQLiteDatabase.java:2330)
  android.database.sqlite.SQLiteDatabase.execSQL (SQLiteDatabase.java:2257)
  org.osmdroid.tileprovider.modules.SqlTileWriter.createIndex (SqlTileWriter.java:814)
  org.osmdroid.tileprovider.modules.SqlTileWriter.runCleanupOperation (SqlTileWriter.java:113)
  org.osmdroid.tileprovider.modules.SqlTileWriter$1.run (SqlTileWriter.java:77)
  org.osmdroid.util.GarbageCollector$1.run (GarbageCollector.java:32)
  java.lang.Thread.run (Thread.java:919)

Environment
Version of android this affects:
At this time, only reproduced 2 times on a customer device, a Galaxy Note 9 under Android 10 with enough free RAM (2GB) and space (18GB)
Version of osmdroid the issue relates to:
6.1.13 or 6.1.14, not 100% sure between both...
I've upgraded recently from one to the other because of this crash, maybe it is related?
If you need more info, feel free to ask :)

that's strange. maybe there's a way to detect it and maybe use an alternate file name if there's a problem? i'm hesitant to just delete the file. what do you want?

Hello @spyhunter99 and thank you for your answer :)
Indeed that's strange... Since I opened the issue for this crash, only this specific device got it 6 times.
I don't know if this is specific to this device or even this user (maybe a setting set by the user).
A clean fix would be to just delete/recreate the db I suppose, it should not increase that much API usage, but as only one of our users reproduces it, I don't know if this worth it to osmdroid...


Add mocktail

Hi! Adding mocktails to the app sounds great. Could you please provide some more information on how you(as a user) would like it in the app, filter options? some other mocktail features?
Also is there some specific mocktails that you like to be included?

Mocktail or Cocktail should be the first filter a user is asked to apply.

Mocktails will be avaliable in the next version of the app (v1.17.0). So probably on Google Play Store and F-droid in a couple of days


Error in using filtering conditions - MatchAny, MatchExcept

I'm facing an error when running the following code Python client and local storage. I'm using qdrant-client 1.3.1; python3.9.16
qdrant_client.upsert(
    collection_name="document_class",
    points=[
        PointStruct(
            id=idx,
            payload={"keywords": ["a", "b"]},
            vector={
                "image": np.random.rand(512).tolist(),
                "text": np.random.rand(256).tolist(),
            },
        )
        for idx in range(10)
    ]
)

Then later:
scroll_filter = models.Filter(must=[models.FieldCondition(key="keywords", match=models.MatchAny(any=["a", "b"]))])
qdrant_client.scroll(collection_name="document_class", scroll_filter=scroll_filter)

The error is:
 File "/root/anaconda3/envs/debug-env/lib/python3.9/site-packages/qdrant_client/http/api_client.py", line 91, in send
    raise UnexpectedResponse.for_response(response)
qdrant_client.http.exceptions.UnexpectedResponse: Unexpected Response: 422 (Unprocessable Entity)
Raw response content:
b'{"result":null,"status":{"error":"Json deserialize error: data did not match any variant of untagged enum Condition at line 1 column 199"},"time":0.0}'

Did I do it the right way or do we have some issues with Qdrant?
I also face the same issue when trying the MatchExcept condition, only the MatchValue works for me.

Do you mean the OS version on my server?

No, I mean qdrant server.

It's v1.3.0

@hoangthanh283
I am trying to reproduce your problem with this script, but it seems to work fine for me:
from qdrant_client import QdrantClient, models
import numpy as np

qdrant_client = QdrantClient("http://localhost:6333")

# Create collection

qdrant_client.recreate_collection(
    collection_name="document_class",
    vectors_config={
        "image": models.VectorParams(
            size=512,
            distance=models.Distance.COSINE,
        ),
        "text": models.VectorParams(
            size=256,
            distance=models.Distance.COSINE,
        ),
    }
)

# Insert documents

qdrant_client.upsert(
    collection_name="document_class",
    points=[
        models.PointStruct(
            id=idx,
            payload={"keywords": ["a", "b"]},
            vector={
                "image": np.random.rand(512).tolist(),
                "text": np.random.rand(256).tolist(),
            },
        )
        for idx in range(10)
    ]
)

# Scroll through all documents

scroll_filter = models.Filter(must=[
    models.FieldCondition(
        key="keywords",
        match=models.MatchAny(any=["a", "b"])
        )
    ]
)
result, next_page = qdrant_client.scroll(collection_name="document_class", scroll_filter=scroll_filter)

for point in result:
    print(point.id, point.payload)

Could you please try it on your side and maybe spot any differences with what you are trying to do.

Oh, after refreshing my env, and qdrant server, it works well now. Thank you a lot for your support!


[sram_ctrl] Error out upon SRAM accesses during a key request.

Currently, SRAM stalls all bus accesses while a key request is in progress.
This can be problematic, since if EDN is not initialized, such a key request may stall the processor forever, even preventing it from entering an NMI (see the corresponding OTBN discussion https://github.com/lowRISC/opentitan/issues/7021).
A solution currently discussed for OTBN scrambling would be to make the bus access error out instead of stalling it.

these two situations felt a bit different to me. For the otbn, that's always programmed by ibex to go.
For the main sram scramble, I was originally imagining a scenario where live software is running and we need to "rotate" keys.
My original thinking is that we should stall, because of the situation is kind of like a cache invalidate.  We are waiting for the operation to finish before we can safely use it again.  This waiting could involve code that uses the stack / checking variables etc, hence why i thought maybe stalling would be better.
@cfrantz
You are right however stalling in general can be dangerous, but this kind of stall would not prevent for example the watchdog from eventually triggering.  I'm not against explicit erroring however, since most likely the software code around this area will have to be written in assembly anyways.

i should mention also because of this issue, we explicitly need to setup entropy inside rom, and ensuring the entropy complex can support this is something that's important.

I'm ok with SRAM returning aborts before the scrambling configuration is ready.
I assume that if I request a new scrambling key, I can let that happen "in the background" and execution will be fine as long as I don't touch SRAM before its ready?
Is there a status bit in the SRAM controller that I could spin on if I need to wait for SRAM:
Pseudocode:
abs_mmio_write32(SRAM_CTRL_REG, SCRAMBLING_GET_NEW_KEY_RIGHT_NOW);
while(abs_mmio_read32(SRAM_STATUS_REG) & REKEY_IN_PROGRESS)
  /* do nothing (or optionally: watchdog_pet())*/
  ;

You should be able to spin on sram_ctrl.STATUS.SCR_KEY_SEED_VALID to achieve this.
See also description of sram_ctrl.CTRL.RENEW_SCR_KEY in https://docs.opentitan.org/hw/ip/sram_ctrl/doc/index.html.

Can we always safely ignore sram_ctrl.STATUS.SCR_KEY_VALID if we are checking sram_ctrl.STATUS.SCR_KEY_SEED_VALID?

Sorry, I believe I have a copy paste error in what I have said in my previous comment.
You can poll on sram_ctrl.STATUS.SCR_KEY_VALID and safely ignore sram_ctrl.STATUS.SCR_KEY_SEED_VALID while polling.

Thanks. Once sram_ctrl.STATUS.SCR_KEY_VALID is set what behavior do we want when sram_ctrl.STATUS.SCR_KEY_SEED_VALID is 0? Should we ignore it or should we trigger a shutdown?

So it depends a bit how much knowledge of the provisioning and life cycle state ROM firmware has (or should have).
ROM needs to be able to run in both cases - especially during the test life cycle states where the key seeds have not been provisioned yet.
We could technically double check the seed valid status with the provisioning status of the corresponding OTP partition, and trigger a shutdown if a discrepancy is detected. This can be achieved by checking the digest value of the SECRET1 partition in the OTP CSRs. If that one has a non-zero value, the sram_ctrl.STATUS.SCR_KEY_SEED_VALID bit should be set to 1.
@cfrantz @tjaychen @cdgori
WDYT? Or is that too much complexity to add at this point in ROM code?
Note: The scrambling keys are in all cases ephemeral - the only difference is that the keyed KDF is using an all-zero value if the key seeds have not been provisioned yet.

i think it's probably not worth the complexity. As @msfschaffner said the keys are always ephemeral, and entropy information is always pulled to further enhance its creation.   If ROM arms the memory scrambling, we should just go with whatever we have.
The checking of whether the seed was valid IMO is fine to leave to later pieces of software if they care about it.

Ok, in that case let's just ignore the value of sram_ctrl.STATUS.SCR_KEY_SEED_VALID in ROM code.

Thanks, that's useful info, sorry for sidetracking the issue. The original proposal (access exceptions for SRAM accesses during scrambling) SGTM.


Dependency Update for ASP.NET Core and OData

New version 6.0.1 of ASP.NET Core - update dependencies.

Fixed in #293


Tracking issues of OpenDAL Rust Examples

https://github.com/apache/incubator-opendal/pull/2456 introduces an example framework of opendal rust examples. This tracking issue is used to track on going tasks of thoes examples.
Tasks

[x] 00-setup: https://github.com/apache/incubator-opendal/pull/2456
[x] 01-init-operator: https://github.com/apache/incubator-opendal/pull/2464
[x] 02-async-operations: https://github.com/apache/incubator-opendal/pull/2541

All tasks have been done, let's close. Feel free to request for more examples.


Use large IOBufferBlock only on sending DATA frame

Prior to the change, when HTTP/2 connection is created, the write_buffer is allocated with http2.write_buffer_block_size (default value is 256KB). However, only DATA frame needs such large buffer.

[approve ci autest]

[approve ci autest]

"AuTest 1of4" needs https://github.com/apache/trafficserver/pull/11230

[approve ci autest]

"AuTest 1of4" needs #11230

Does the change from this patch make that more likely? I don't recall seeing that issue from the ja3_fingerprint test before.

Right, I ran the AuTest several times locally, it looks like this change made the flipping the debug order of threads frequently. Allocating 256KB and 4KB might have big difference.

[approve ci autest]

[approve ci osx]

[approve ci]

The ja_fingerprint test needs #11254 too. It passed 10 times in local docker env.

[approve ci autest]

All green, ja_fingerprint fix worked!

[approve ci autest]

Rebased on the latest master. Please take another look.

Cherry-picked to v10.0.x


Cleanup build should reset pipeline state

the clean command also calls resetPipelineState after repoDir is deleted

Does the output terminal get shown when the cleanup build command was ran? I'm suspecting that it is returning earlier before actually doing anything

Does the output terminal get shown when the cleanup build command was ran? I'm suspecting that the command is returning earlier before actually doing anything.

No it doesn't show the command

The output terminal is not shown?

It was already shown because i tried to init a build, i will try to reproduce later

You could also put a breakpoint there instead of determining if the output terminal was shown. I was just suspecting because of the check:
 if (!this.workspaceState.getInitialized()) {
    return
}

it was skipped

Oh that is possible, because we didn't had the migration in place yet. Let us see once that PR lands first, maybe there is nothing to be done here

This is no longer an issue here


Repackage as simple-http.com

Need to be done as a precursor to #12 https://issues.sonatype.org/browse/OSSRH-40600

Java recommends "simple_http". I think I prefer "simplehttp" or just "http" what do you think @tobyweston?

I vote for...

[ ] com.simple.http
[ ] simple.http
[ ] http
[ ] simplehttp
[ ] simple_http

I choose to keep my vote anonymous.

The votes have been counted and it is a landslide victory for simplehttp.


merge tabs title with swiper slider for slider on more count item

Hi, great job
But I need to have a lot of tab titles for my design, so to handle this design on desktop and mobile (with dynamic tabs ) I need to have the titles as sliders as well.
After 1 hour I was able to combine the title of the tabs with the swiper slider, but the problem is that by changing the content the swiper tabs slider does not move and the active item is not specified, which confuses the user. Do you suggest a solution?

Hi @farshidpg!
Сould you please provide a sandbox link (codepen or codesandbox) with an example of the problem?

I was able to solve the explained challenge using this code
document.querySelector('.tabs').addEventListener('tabChange', function(evt) {
window.swiper_sl[1].slideTo( evt.detail.currentIndex,1000,false );
});
With these two lines, I was able to change the content, position of the tab title (created with swiper slider) ;)
tnx for this method and callback data

Yes, that's right, tabslider events are just for such cases.
In that case, I'll close issue.


Expanded Button Group margin missing - foundation-rails (<IP_ADDRESS>) gem

I'm using Foundation for Sites via ruby gem (foundation-rails (<IP_ADDRESS>))
After latest ugrade to 6.2.1 I noticed that Buttons Group margin calculation doesn't include -1px margin part.
Attached is a screenshot comparing my local file downloaded via gem and the one from Foundation sites website.
Any ideas how to solve that? I tried reinstalling gem, doesn't help.

This was fixed in https://github.com/zurb/foundation-sites/commit/0a4f4ca7514ec8abfae07838ecab9b0a9d0c1a71. Should be included in the next patch.

Actually, I'm reopening this 'cause this wasn't a specific bug that was fixed. However, I cannot replicate it locally. @KiraBialczynska, are you maybe using $global-flexbox: true; locally?

Hi Andy,
No I'm not. Actually I cannot find this setting in my _settings.scss. The case might be that although ruby gem updates the version of Foundation the locally linked files like _settings.scss and foundation_and_overrides.scss stay unchanged. After last update I added $foundation-palette manually. How should I approach this? Should I always get the latest _settings when updating Foundation? How to keep track of local changes and make sure I have all the latest settings?

@andycochran adding $global-flexbox: true; fixed the problem. Please let me know how to approach changing settings and updating it to latest version? What would the best practice be?
Thanks!

When you upgrade, there are sometimes crucial variables in the settings file. Not including those won't always break everything, but you can get undesired results. Part of upgrading Foundation is combing through your settings file. But you should note that setting flexbox to true drops support of certain browsers. Check the docs for more on that.


jsoup:HtmlFuzzer: Uncaught exception in org.jsoup.parser.HtmlTreeBuilder.resetInsertionMode

New issue 34231 by ClusterFuzz-External: jsoup:HtmlFuzzer: Uncaught exception in org.jsoup.parser.HtmlTreeBuilder.resetInsertionMode
Project: jsoup
Fuzzing Engine: libFuzzer
Fuzz Target: HtmlFuzzer
Job Type: libfuzzer_asan_jsoup
Platform Id: linux
Crash Type: Uncaught exception
Crash Address:
Crash State:
  org.jsoup.parser.HtmlTreeBuilder.resetInsertionMode
  org.jsoup.parser.HtmlTreeBuilderState$9.process
  org.jsoup.parser.HtmlTreeBuilder.process

Sanitizer: address (ASAN)

This crash occurs very frequently on linux platform and is likely preventing the fuzzer HtmlFuzzer from making much progress. Fixing this will allow more bugs to be found.

That's all we have? I mean, no stacktrace with line numbers? No input data to reproduce?

There's more information (detailed report, reproducer test case) linked in the email. Since none of them is a severe security issue (highest prio is low), I guess I can make them public here!?

@krystiangorecki I have added all details; other issues follow.

Yes, please. People report exceptions with such details all the time. They often stay unfixed for few months until the next release and no one ever complained. Now it's just not enough info.

I have updated all issues; #1537 tracks all related issues in this project now.


references #1689 add in tox.ini all extras defined in setup.cfg

Signed-off-by: Fabrice Flore-Thebault<EMAIL_ADDRESS>closes #1689 add in tox.ini all extras defined in setup.cfg
PR Type

Bugfix Pull Request

Can we merge this?

Sorry i failed a rebase again, hence the push --force. But it is just the exact same commit rebased on master to relaunch the build which failed on a weird error.

Unfortunately, with this PR the  linode modules get installed, linode tests that were skipped get activated, and they fail.

Riiighhhhht, OK, we can't merge this until we have a strategy for these functional tests that talk across the network.

@themr0c right, that's what I thought...
You can modify https://github.com/ansible/molecule/blob/6502649/test/functional/conftest.py#L268-L274 to ignore travis as a workaround.

If i didn't make any enormous mistake in last commit, linode functional tests should be now skipped in travis.

@themr0c, I think https://github.com/ansible/molecule/pull/1691#discussion_r258524200 is relevant in that, importorskip won't actually throw an exception. Let's make sure about that.

@lwm while it's relevant to the initial code, it's just copy-pasted without changes so I suggest to address it separately in order to not overload PR with extra changes

:rocket:


Fix accounts selection scroll issue at bottom of the list

I can't seem to scroll all the way down to reveal the last account fully:

@markmhx seems it is not actual


Revert "feat(interfaces): Update interfaces for export"

Reverts CS3-Marketing/zoominfo-node-sdk#15

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Lazy load single HTML not many bootgrid tables, replace bootgrid tables with simple tables.

Completed


handle a region param in snowflake connector

Do you think it always happens with us-west specifically, or is it because the instance you're trying to connect to is in us-west?

Do you think it always happens with us-west specifically, or is it because the instance you're trying to connect to is in us-west?

Tbh, do not know whether it depends on the cluster location or not. But in our in-app product we process this case the same way because it leads to errors when connecting if us-west is set as a region.

According to this page, the region parameter is deprecated: https://docs.snowflake.com/en/user-guide/python-connector-api.html
Anyway, it sounds like if the region is "us-west", then you just shouldn't specify it? It doesn't look like something we should add to data-diff.

Anyway, it sounds like if the region is "us-west", then you just shouldn't specify it?

That's right.

It doesn't look like something we should add to data-diff.

Ok, you may close the PR then.


Default stack with no services, but I have a stack with services cause applications page to re-direct to  "Add first service"

v0.49.0-rc1
Steps to Reproduce:

Have a fresh setup with no services
Add a service using rancher-compose in a different stack
Go to applications page

Result: Greeted with "Adding your first service" because there are no services in my stack. I can get to the stacks page by clicking on stack.
Expected Result: Go directly to stacks page as I have a stack (that is not the default).

This is old, Seems to work for me now

Verified no longer an issue in v1.1.0-rc2


Use quarter rate DDR phy on Atlys

This will increase DDR bandwidth.

@enjoy-digital This is finished right?
https://github.com/timvideos/HDMI2USB-misoc-firmware/commit/0077916b43c995ef8a480d3641f8b4603866a0f1

@enjoy-digital If so, please close the issue.

I believe this is dependent on the work on litedram @ https://github.com/enjoy-digital/litedram ?

This can be done with the actual controller. Settings are different from opsis so we need some time to test it and get it working.


Create hiuman.txt

Hiuman School Added

@lucks-hl Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@lucks-hl You might miss my previous comment. Please react.

1.- school official website URL: https://www.hiuman.edu.mx/
2.- the school street address, including city and country:
Calle 15, No. 122 por 24 y 26.
Col. México CP. 97125
Mérida, Yucatán , México
3.- https://admin.imparta.khorflix.com/security/auth/login
4.-<EMAIL_ADDRESS>