Pretty Printing

This PR adds pretty printing, much like NumPy -- aligning floating point numbers on the . etc.
E.g.
	xt::xarray<double> rn = xt::random::rand<double>({3, 3}, 0, 1000);
	xt::xarray<double> brn = xt::random::rand<double>({3, 3}, 0, 10000);
	xt::xarray<double> z({3, 3}, 0);
	z(1, 1) = 0.1;
	rn(1, 1) = 0;
	// rn(1, 2) = 10e10;
	rn(1, 2) = -10e5;
	xt::xarray<bool> rb = xt::random::randint<int>({3, 3}, 0, 2);
	xt::xarray<uint> ri = xt::random::randint<int>({3, 3}, 0, 50);
	ri(1, 2) = 10e7;
	pretty_print(rn);
	pretty_print(brn);
	pretty_print(rb);
	pretty_print(ri);
	pretty_print(z);

{{  1.35477004e+02,   8.35008590e+02,   9.68867771e+02},
 {  2.21034043e+02,   0.00000000e+00,  -1.00000000e+06},
 {  1.88381976e+02,   9.92881302e+02,   9.96461326e+02}}
{{ 9676.9494  ,  7258.3896  ,  9811.0969  },
 { 1098.6175  ,  7981.0586  ,  2970.2945  },
 {   47.834844,  1124.6452  ,  6397.6336  }}
{{ true,  true,  true},
 { true,  true,  true},
 {false, false,  true}}
{{       10,        46,        34},
 {       33,        19, 100000000},
 {       37,        37,        23}}
{{ 0. ,  0. ,  0. },
 { 0. ,  0.1,  0. },
 { 0. ,  0. ,  0. }}

@wolfv is on 🔥

Hehe, yeah, now I have to stop, don't wanna burn out :)

It looks like the build has timed out (everything was ok except GCC 4.9 build which didn't start), I've restarted it.

Is there a reason you reverted the changes made to operator<< and let the pretty_print uncalled ?
I think pretty_print should be the default mode for outputting xexpression objects (see #94), whatever the output stream is. In order to do so:

it should take an additional output stream argument, and return it.
operator<< should call pretty_print. Maybe a recursion depth limit should be added, just as in the current implementation of operator<<. @SylvainCorlay any thought on this ?
current precision of the stream should be checked; if it is greater than the default one used by pretty_print, then use it.

I would really like to have this feature in the next release, it's a huge added value !

printing complex numbers depends on #97 now :)

The error on OSX is due to a Travis problem, I'm restarting it.

There are 2 behaviors of numpy that are currently not implemented but might be nice to have:

Limiting the line length to 75 chars
Limiting the amount of output (putting some ...) for arrays with more than 1000 elements i think. Or actually, the heuristic might be different, need to compare source code.

I think both are a bit harder to achieve. Should we postpone them?

Ok, I'll have to refactor this function a bit to make it lazy enough to be worthy as part of xtensor :)
Ie. I don't want to evaluate the entire array/tensor every time for printing, if only a subset is actually given out on screen.

[ ] Large exponent handling (e+100, e-100 ... )
[ ] inf/nan handling

I think we can postpone the 2 behaviors you mentioned. The build issue on OsX seems legitimate, however a rebase on master should fix it (I hope !)

Okay, I have more or less rewritten it another time. Now everything should work (or at least potentially).
Still need to fix the tests ...
Let me know if you have doubts about this approach!

For me the approach is good and the code is really cool ! Just a few minor remarks in my review, but that's really minor.
The third commit reverts a lot of things done in the second one, I think that would make sens to squash them in a single one, what do you think ?

Hey @JohanMabille, I think it's best I squash when everything is done.
I have added some test, and for the tests I've added some text files to compare against.
Windows doesn't seem to be able to read them ... maybe it's because the relative path is "wrong" (have to use \ instead of /)?
Otherwise, I think I have implemented my wishlist of features now :)
Do you think it's necessary to have a "fast printing" option (basically restoring the old behavior)?

Is there some way I can check wether I'm on windows or unix to adjust the file paths? Or should I try a different approach?

There is http://en.cppreference.com/w/cpp/experimental/fs/path/append
Also regarding "fast printing", I am not sure this is really something meant to be fast.
We are going to tackle serialization in a different package. (probably to npy files first).

But are you okay with having the expected output in seperate files?
I think on linux it would work, if the command was
make xtest
or the test was executed by ./test/test_xtensor instead of changing the directory first.

another option might be to copy the files into the test/ directory with CMake?

Ok this shall build now :) Let me know if you have an issue with the way I added the tests. Otherwise I'll add some more in time, and then I hope this thing is ready!

Ok, so unfortunately the custom formatter functionality was segfaulting with clang and MSVC. Maybe one of you has an idea why.
Otherwise, I think functionalitywise it looks good. I'll try to document the print_options a bit.
Cheers!

I have rebased once more :) I consider this pretty much done, but let me know if you want to change something!
One thing that could reduce the code size a bit would to have a base class base_printer that defines the (often unnecessary) constructor ...  i might add that later.

I think that we all want this in 0.4.0 but I have not taken the time to read this thoroughly.
I trust @JohanMabille on merging this if he wants to do it now otherwise, I am AFK this afternoon, so this will probably go in tomorrow.

I think we can merge this PR, the code is really good, the feature is really cool and there's a lot of work involved in this patch to have the cleaner code possible.


Feature/1364/284 clock

What this PR changes/adds
Use a mockable Clock to get the time.
Removes calls to Instant.now(), new Date(), System.currentTimeMillis() from production code.
Why it does that

Make access to system time consistent in code base.
Make time mockable for testing.
Make tests simple and reliable (avoid approximate time comparisons, etc.).

Further notes

Moved convenience method implementations from DefaultServiceExtensionContext to the interface
Changed DataPlaneInstance contract to return null instead of 0 for empty lastActive time.
nbf: in discussion with Ben
Removed rollbackState method in ContractNegotiation and TransferProcess, as it's unused and violates state machine contract.

Linked Issue(s)
#284
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #286 (05e2f6c) into feature/1364-clock (a2d169f) will decrease coverage by 56.22%.
The diff coverage is 14.15%.

@@                    Coverage Diff                    @@
##             feature/1364-clock     #286       +/-   ##
=========================================================
- Coverage                 67.65%   11.42%   -56.23%
- Complexity                    0      488      +488
=========================================================
  Files                       716      716
  Lines                     15880    15903       +23
  Branches                   1041     1042        +1
=========================================================
- Hits                      10743     1817     -8926
- Misses                     4663    13981     +9318
+ Partials                    474      105      -369

Impacted Files
Coverage Δ

...dataspaceconnector/core/CoreServicesExtension.java
0.00% <ø> (-91.49%)
:arrow_down:

...or/boot/system/DefaultServiceExtensionContext.java
0.00% <0.00%> (-82.50%)
:arrow_down:

...ceconnector/contract/ContractServiceExtension.java
0.00% <0.00%> (-95.09%)
:arrow_down:

...iation/ConsumerContractNegotiationManagerImpl.java
42.79% <0.00%> (-45.05%)
:arrow_down:

...ract/validation/ContractValidationServiceImpl.java
0.00% <0.00%> (-60.79%)
:arrow_down:

...connector/transfer/core/CoreTransferExtension.java
0.00% <0.00%> (ø)

...core/transfer/TransferProcessSendRetryManager.java
0.00% <0.00%> (-89.48%)
:arrow_down:

...onnector/azure/cosmos/LeaseableCosmosDocument.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...atafactory/DataPlaneAzureDataFactoryExtension.java
0.00% <ø> (ø)

...plane/selector/instance/DataPlaneInstanceImpl.java
0.00% <ø> (-90.00%)
:arrow_down:

... and 508 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d169f...05e2f6c. Read the comment docs.


Items and fluids not rendering in casting tables or basins or smelter, REI won't auto-move recipes or move GUI out of the way in Tinker's Station/Anvil—Quilt mod loader seems to be the cause

Minecraft Version
1.20.1
Fabric Version
0.14.24
Fabric API Version
0.90.4
Hephaestus Version
<IP_ADDRESS>
Describe your issue
With the Quilt mod loader active—not Fabric, as Fabric seems to work just fine—any items put into a casting table or basin do not render; neither do fluids being poured or when they are in the smelter itself. Everything still works—I can still pour liquid and advance into Hephaestus/TC. I've built a smelter and it works just fine, no crashes or even errors.
Following the advice given at the top, I've switched back to Fabric for the time being since none of my mods seem to suffer for it. I don't know why Quilt is causing the issue, but I figured I'd note it since I did not see any closed or open issues with this specific one. I have seen others, but those involve Sodium, and mine did not.
Also of note:

Roughly Enough Items won't auto-move Hephaestus/TC recipes into both the vanilla crafting table or Crafting Station. It says something like "It cannot move at this time" and something about an incompatibility.
REI also overlaps the right-side GUI when looking at a tool's modifiers and parts in the Anvil and Tinker's Station; it does not auto-move around it like REI usually does with other GUI mods, but that is as easy as using CTRL+O to hide the GUI.

Both of the above only happen on Quilt as well. If you'd rather I make two separate issues about it I definitely can but they're so minor that I thought I'd just tack them on here.
Crash Report
No response
Other mods
Apart from Sodium I'm using the whole suite of Sodium, Sodium Extras, Indium, Iris Shaders (with a shader enabled—MakeUp Ultra Fast to be specific) and LazyDFU. They all work with Hephaestus/TC swimmingly!
I have many other mods too, but none of them interact and cause this specific issue except Quilt itself, and perhaps Quilted Fabric API. However, some of the mods do cause very minor issues unrelated to the one I'm making a ticket on:

Continuity causes all-white fluids for all fluids (except water and lava). Removing it fixes it
Diggus Maximus also doesn't fully work—using the grave key only minds a 3x3 area instead of what it usually does (mine an area for as much durability as a tool has), but that could be a feature of Hephaestus/TC that I didn't know about.
Not sure what mod is causing it, if any, since it happened with only Hephaestus/TC, but I can't open chests in the 1.20.1 version. 1.18.2 I could just fine; don't know what caused that but I did see someone else having the same issue.

If any of these warrant a separate ticket please let me know and I'll make them. I just figured because none of them really "break" anything (I have workarounds for all of these issues including the last one, which is. just using regular chests to store things) they aren't worth it since nothing is causing crashes.
Tried reproducing with just Tinkers?
Yes
Performance Enchancers
Sodium, Other (specify under other mods)
Searched for known issues?
Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ

Have you made a issue report on quilted fabric api? I've had similar issues with it before.
Can you also provide your log file? I'd be able to see if there any internal errors in the log.

 Disabled QFAPI and the mods it used, re-enabled one-by-one, no issue. Saw Continuity was disabled and thought, 'well it's causing the white-fluid, so maybe it's causing the rendering issue too', re-enabled it on a whim, and popped into the world: white copper fluid when I smelted it down, and items in the basin and casting table are invisible. I feel so dumb now, I'm so sorry.
As for the log file, I apologize since it only said crash log, and since the game didn't crash... Here it is, I think—I do use MultiMC but that's never been an issue. This version is with Continuity enabled. A couple of the mods (Croptopia, Tiered, and WWOO) I do not use but keep them so I can update my mod list as new Minecraft versions release. You can ignore them since I know they still show up in the mod list at the top.

This should be fixed in latest


nixos/tmate-ssh-server: fix tmate-client-config script

Description of changes
Replace usage of sd command in tmate-client-config script with sed. sd
was printing color code escape sequences with replaced string
which was breaking the script.
#ZurichZHF

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

@ofborg build tmate-ssh-server.tests

Could you also remove sd from runtimeInputs?

Done, thank you !


Add node 18 support.

Tests don't show as much coverage on 18 due to timing
differences, I think.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.92%. Comparing base (42ad712) to head (733b740).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   98.80%   98.92%   +0.12%
==========================================
  Files          15       15
  Lines        1585     1588       +3
  Branches      149      149
==========================================
+ Hits         1566     1571       +5
+ Misses         19       17       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Introducing System.IO.Pipelines

Golang took the name channels so now we have pipelines

@KrzysztofCwalina

So what if Golang named it first, why can't 2 languages have the same named concept?
 What is now called Pipelines in .NET is an optimized specialization of streams. In Go, "Channels are a typed conduit through which you can send and receive values with the channel operator, <-."

The project at https://github.com/dotnet/corefxlab/tree/master/src/System.Threading.Tasks.Channels maps much more closely in concept to Go's channel.

I like it!

Does it matter that golang might introduce something called pipelines later which is again completely different to this?

@adamralph golang already has a concept called pipelines, which is a series of stages (goroutines running the same function) connected by channels. Since there is only a limited set of words in the English vocabulary that are suitable for software purposes, chances are that the good ones are already taken.

@davidfowl
What is the allocation profile of such approach compared to the traditional streams?

using System.Buffers;

All the files should have the standard copyright/license notice

Refers to: src/System.IO.Pipelines/ArrayBufferPool.cs:1 in 56ee6e7. [](commit_id = 56ee6e7d1015c64d8b5cdc517da632391870ae56, deletion_comment = False)

:clock1:

With reference to @stephentoub's comment, is the implication that System.IO.Pipelines aligns more closely with golang pipelines (referenced by @nzall)?

With reference to @stephentoub's comment, is the implication that System.IO.Pipelines aligns more closely with golang pipelines (referenced by @nzall)?

A "pipeline" is a general pattern, a series of processing elements (often called stages) with data handed from one stage to the next.  A pipeline can be implemented in many languages/frameworks; in Go, it's typically implemented using a goroutine for each stage and using a channel as the mechanism for handed data between stages.  But the concept is in no way specific to Go.

@stephentoub thanks for the explanation. I'm trying to rationalise the rename from "channels" to "pipelines". I can see how the rename probably makes sense in this case, but basing the decision on another platform having "taken" the generic noun you intended to use feels a bit off somehow.

@adamralph Look at the repository @stephentoub linked to - they're not changing the name of this thing "because we can't use names taken in other languages", but because they already are testing something which would be closer to channels and want to name that thing channels instead.

@JesperTreetop that sounds like a good reason. It's a very different reason to that given by the OP.

Couldn't resist commenting.. I have literally no idea what this is.. but I love it +1. Look forward to working it out through experimentation :-)

I'm excited about this, it looks like a potentially fresher and better tool than Streams, especially for in-process / short-hop data movement


Static sound feedback from keyboard and touchpad

Hi @the-Quert, First thank you for your work on this git.
I installed 10.15.4 on my XPS 9360 with BIOS 2.13. For the most part everything was working fine for me up until I put the two i7-8550 cpufriend kexts in /library/extensions and ran the rebuild cache. I then ran the combo-jack command and then rebuilt the cache. I then rebooted. Now I’m hearing a static feedback every time I click the touchpad or some keys on the keyboard. I’ve tried to use the uninstall script I got from the combo jack git and removed the kext file from clover/kexts, rebuilt the cache and restarted but that didn’t help. I then removed the cpufriend kexts and rebuilt the kexts, but that didn’t help either.
Do you know how I can get back to normal here? Have you ever experienced a problem like this?

Since this condition never happened in my installation experience, reinstall the whole system would be recommended.

Problem is not traced anymore, case closed.


[DO NOT CLOSE OR MERGE] Rti 12596 compress to file

You can build some NIF functions that do the actual compression and then do the rest using erlang in the same module if you do not feel comfortable with C.

You also forgot to have options for the compression level and the "long distance matching with given window log" or --long option.

You can build some NIF functions that do the actual compression and then do the rest using erlang in the same module if you do not feel comfortable with C.

I was trying to do the compression and writing in C in order to be able to release memory as soon as possible. It also should be more efficient.

You also forgot to have options for the compression level and the "long distance matching with given window log" or --long option.

The --long option is missing but the compression level is there.

@raz-adroll I suggest merging this change as it is now and work on the improvements whenever the net ticket is prioritized.

@raz-adroll I suggest merging this change as it is now and work on the improvements whenever the next ticket is prioritized.

This shouldn't be merged as it is.

@raz-adroll I suggest merging this change as it is now and work on the improvements whenever the next ticket is prioritized.

This shouldn't be merged as it is.

What do you propose to do as the minimum for merging? I believe adding the fsync should be enough

The minimum would be not breaking trino querying

@raz-adroll I suggest merging this change as it is now and work on the improvements whenever the next ticket is prioritized.

This shouldn't be merged as it is.

What do you propose to do as the minimum for merging? I believe adding the fsync should be enough

The minimum would be not breaking trino querying

Sure, then this PR will be kept unmerged until the next ticket is prioritized.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Deprecate the test teardown function

See https://pkg.go.dev/testing#T.Cleanup

Cleanup registers a function to be called when the test (or subtest) and all its subtests complete. Cleanup functions will be called in last added, first called order.

Reasonable. I didn't want to "fix" the whole project unless you were okay with the change first. I may do it then.

Check... Additionally I'm not sure if having one cleanup function that will teardown once is going to work for all tests, but I guess that is something we should, uuh test (no pun intended)...

Updated. It was a very simple find-and-replace with no corner cases. Every time setup() was called was at the start of a test and immediately followed by defer teardown().


Using PopStatusItem without Storyboard

Hello Adam,
Thank you for the nice class, I would like to ask you how can I use it without storyboard. I want to use it in a normal MainMenu.xib, if it is possible how to set the window controller of popstatusItem and connect it to a view.
It will be great if you provide an example of using it without Storyboard.
Thanks alot

I found a way. By creating my custom window controller and initiating it in app delegate.
and in that window controller I set the content view to my custom view controller.


About CUSTOM dataset

It's an excellent job. I really appreciate it.
I observed when getting LPIPS distance, it has a denoising step which makes use of pre-trained diffusion models.
If my data domain makes a great difference from the pre-trained dataset, should I pretrain the diffusion model on my dataset first?

Yes, you need a pre-trained model for that domain to effectively edit the generated image. (the model has to be able to create that image domain.)
But you don't have to measure the LPIPS distance simply to test whether it works in a specific other domain.
You can use the "--user_defined_t_edit #" and "--user_defined_t_addnoise #" options to tweak the image generation without measuring the LPIPS distance.
A recommended range for "--user_defined_t_edit #" is 400 to 700 and for "--user_defined_t_addnoise #" is 100 to 400.

OK. Thanks for your kind advice. I will have a try.


1.1.0: tweak Pixel Perfect default settings for performance stability on Deck

Performance issues unrelated to shader pack. Not fixing as preset performs as anticipated.


Is Pinch to zoom or zoom feature supported in agora flutter?

Hello @jacob-hutchings @LichKing-2234 @PRWrl @plutoless @Matrixbirds
I've been trying live stream broadcast demo and I'm not able to find out any way to set configs or parameters for zoom or pinch to zoom video while broadcasting video.
Also I'm getting "_engine?.isCameraZoomSupported()" to false every time in 3 different devices.
So, can anyone please tell me if there are any particular list of params or properties available for settings zoom feature in agora streaming?
Thank You

have you called enableVideo and startPreview?

@LichKing-2234
I've applied gesture recognizers to my RTCLocalView Property,
Set<Factory>? gestureRecognizers = Set()
..add(Factory(() => PanGestureRecognizer()))
..add(Factory(() => ScaleGestureRecognizer()))
..add(Factory(() => TapGestureRecognizer()))
..add(Factory(
() => VerticalDragGestureRecognizer()));
    But, it's not working for pinch to zoom property,

    Let me know if there is anything else to perform?

@fldvlpr  have you found the solution?

android or ios?

In both
On Sat, Jan 29, 2022, 12:43 Arthas @.***> wrote:

android or ios?
—
Reply to this email directly, view it on GitHub
https://github.com/AgoraIO/Agora-Flutter-SDK/issues/448#issuecomment-1024854142,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4VZVPZUH46KO5XU5ERFEDUYOHQZANCNFSM5FIYXNKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

pls provide our sdk log

@LichKing-2234  It solved now after I refer example again with Container wrapper.


Microsoft Office for MAC Autoupdate enable for all users

Hi,
Is there a way to enable MAU for all users (change permissions) so that users do not have to manually do it or ask for.

Just so I understand, you have multiple users sharing the same device and you wan't MAU to automatically run under each users login and update files for everyone?

Yes correct.

I don't have time to test, but have a go with this https://github.com/microsoft/shell-intune-samples/blob/master/Apps/Cisco AMP/Cisco AMP Config 11.x.mobileconfig

We think that this should work anyway. Just need to set AcknowledgedDataCollectionPolicy to 'RequiredDataOnly' in the plist and the end users shouldn't get prompted.

We think that this should work anyway. Just need to set AcknowledgedDataCollectionPolicy to 'RequiredDataOnly' in the plist and the end users shouldn't get prompted.


Passing Original INPUT ID through node

Hi, i use your node for streaming webcams and it works great. Thank you for that!
I only had one issue. The original msg ID (_msgid) is not passed through. So i cant merge this node output with other splitted messages . When a node dont passes al previous info and dont pass the original ID it is hard to keep parts of flows together and keep flow information complete
See: https://nodered.org/docs/creating-nodes/
Nodes should document what properties they ADD to messages, and they should be consistent and predictable in their behaviour.

You're in the wrong repo. You wanted https://github.com/i8beef/node-red-contrib-castv2...
But just FYI with 3.x of that node, released this week, the functionality has completely changed, and there is no expectation of msg continuity on the output anymore. It is a purely asynchronous flow now, so you probably need to rethink how you are using it. Feel free to open a ticket there for more help when you upgrade.


Using dtmin in PIDController to control the number of steps.

Hey Patrick!
While solving an ODE I bumped into the error "The maximum number of solver steps was reached. Try increasing max_steps." As a quick fix, I tried setting dtmin in PIDController to control the number of steps, i.e.
solution = diffrax.diffeqsolve(
            diffrax.ODETerm(func),
            diffrax.Tsit5(),
            t0=ts[0],
            t1=ts[-1],
            dt0=None,
            y0=y0,
            stepsize_controller=diffrax.PIDController(
                rtol=1e-3, atol=1e-6, dtmin=(ts[-1] - ts[0]) / (16 ** 3 - 1)
            ),
            saveat=saveat,
        )

The above solution doesn't work, but the strategy does seem to, if I set dtmin to be much larger than I would expect to be necessary, such as dtmin=(ts[-1] - ts[0]) / 200.
I think this may be a misunderstanding on my end of what max_steps is referring to. Is it the maximum number of vector field evaluations and not the number of times the solution is updated?
Thank you very much for your help with this!

Ah I see, thank you for the clarification!


[Typescript] Class properties doesn't inherit types from interface

Moved to Microsoft/TypeScript#7011


Stylesheet paths

Hello,
I'm using Rails 5.1.4 and I can't get the stylesheet to work due to the path produced by Princely.
As the app is not in production yet, the stylesheet doesn't exist (in public) and even with rails assets:precompile the path has a MD5 hash in it so it's doesn't work either. I can't give Princely an absolute path to a stylesheet.
Do you have a good way to work around that?
For now, i just inlined the style in a style tag of the layout.

It would be really helpful to know why this code exists:
https://github.com/mbleigh/princely/blob/master/lib/princely/rails.rb#L8-L12
If we go back to just include Princely::PdfHelper (instead of prepending it), then we will get the version of #asset_file_path defined in Princely::AssetSupport at runtime. But with this prepend, we end up getting the #asset_file_path from PdfHelper, which is not aware of the asset pipeline, and causes the problem described by this issue.
It appears that the switch from include to prepend was done intentionally for Rails 5 support, but there is no explanation as to why.


fix TS1479

i tested it locally(needed fix in compute-scroll-into-view too)

finally fix continue #1163


Stops working after some time: chromium PDF: open /dev/null: operation not permitted

Hi again :)
After upgrading from Gotenberg 6 to 7 we encounter some strange issues after some time of usage. PDF conversions fail with error code 500. Here is an exemplary log output from startup to crash:
systemd[1]: Started Gotenberg Docker Container.
docker[840]:   _____     __           __
docker[840]:  / ___/__  / /____ ___  / /  ___ _______ _
docker[840]: / (_ / _ \/ __/ -_) _ \/ _ \/ -_) __/ _ '/
docker[840]: \___/\___/\__/\__/_//_/_.__/\__/_/  \_, /
docker[840]:                                    /___/
docker[840]: A Docker-powered stateless API for PDF files.
docker[840]: Version: 7.7.0
docker[840]: -------------------------------------------------------
docker[840]: [SYSTEM] modules: api chromium gc libreoffice logging pdfcpu pdfengines pdftk prometheus qpdf uno uno-pdfengine webhook
docker[840]: [SYSTEM] prometheus: collecting metrics
docker[840]: [SYSTEM] gc: application started
docker[840]: [SYSTEM] uno: long-running LibreOffice listener ready to start
docker[840]: [SYSTEM] pdfengines: pdfcpu pdftk qpdf uno-pdfengine
docker[840]: [SYSTEM] api: server listening on port 3000
docker[840]: {"level":"info","ts":1666686579.4911427,"logger":"api","msg":"request handled","trace":"daab87c2-dfe5-494f-af71-951c387975fd","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1270986904,"latency_human":"1.270986904s","bytes_in":1790,"bytes_out":34919}
docker[840]: {"level":"info","ts":1666688548.226961,"logger":"api","msg":"request handled","trace":"405be2fc-7ce4-496b-ba8c-cce6ffa47bd1","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1131054014,"latency_human":"1.131054014s","bytes_in":1802,"bytes_out":35969}
docker[840]: {"level":"info","ts":1666688752.2871194,"logger":"api","msg":"request handled","trace":"21fba09e-a773-4e83-a007-608be00ae173","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1134210318,"latency_human":"1.134210318s","bytes_in":1790,"bytes_out":34919}
docker[840]: {"level":"info","ts":1666689149.7710235,"logger":"api","msg":"request handled","trace":"82f8a5ff-ea02-45ad-9bd5-e47241084098","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1132823742,"latency_human":"1.132823742s","bytes_in":1808,"bytes_out":35284}
docker[840]: {"level":"info","ts":1666692553.9598756,"logger":"api","msg":"request handled","trace":"82f7bd54-204a-4ba7-8ddd-c50c161556cc","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1195621210,"latency_human":"1.19562121s","bytes_in":452514,"bytes_out":547700}
docker[840]: {"level":"info","ts":1666692555.591845,"logger":"api","msg":"request handled","trace":"dbe4a2f2-adaf-41e0-a4ae-250df23d0599","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1185292633,"latency_human":"1.185292633s","bytes_in":452514,"bytes_out":547700}
docker[840]: {"level":"info","ts":1666697973.3925002,"logger":"api","msg":"request handled","trace":"eb4a6447-3b3b-4a41-81b1-eb4cb1ef4caf","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":200,"latency":1233069243,"latency_human":"1.233069243s","bytes_in":1499924,"bytes_out":1601036}
docker[840]: {"level":"error","ts":1666705022.8740525,"logger":"api","msg":"convert HTML to PDF: convert to PDF: chromium PDF: open /dev/null: operation not permitted","trace":"54ce819e-49d4-4e80-9343-661542bf0844","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":500,"latency":626796,"latency_human":"626.796µs","bytes_in":1786,"bytes_out":21}
docker[840]: {"level":"error","ts":1666705392.322931,"logger":"api","msg":"convert HTML to PDF: convert to PDF: chromium PDF: open /dev/null: operation not permitted","trace":"99530dda-8edc-49c8-9e52-418892a43014","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":500,"latency":674545,"latency_human":"674.545µs","bytes_in":1786,"bytes_out":21}
docker[840]: {"level":"error","ts":1666705890.9719374,"logger":"api","msg":"convert HTML to PDF: convert to PDF: chromium PDF: open /dev/null: operation not permitted","trace":"624f878c-0261-4c69-a78f-ff3112ac35ad","remote_ip":"<IP_ADDRESS>","host":"localhost:3000","uri":"/forms/chromium/convert/html","method":"POST","path":"/forms/chromium/convert/html","referer":"","user_agent":"","status":500,"latency":788019,"latency_human":"788.019µs","bytes_in":1786,"bytes_out":21}

/dev/null/ within the container looks fine, though:
ls -l /dev/null
crw-rw-rw- 1 gotenberg root 1, 3 Oct 25 08:29 /dev/null

After restarting the container it works again for some time until it crashes again.

I just ran a loop with continuous pdf generation for about an hour on my dev machine and could not trigger the error. Really strange...

Hello @roben,
Weird, I think it’s the first time I see this issue.

It's running in a stock docker-ce 5:20.10.20~3-0~debian-bullseye started within a lxc container which we use as virtualization for our servers. That was never a problem with Gotenberg 6, but good point. I will start the image on a bare metal machine, just to rule out lxc.


Wrong backingType for DataTypes

I think some DataType owns the wrong backingType.
IFCDateTime -> xs:string IFCDate -> xs:string IFCTime -> xs:string IFCDuration -> xs:string
they should be changed:
IFCDateTime -> xs:dateTime IFCDate -> xs:date IFCTime -> xs:time IFCDuration -> xs:duration
I will provide you some references to understand better what I mean:
https://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/IfcDate.htm
https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/datatypes.html#date

One more wrong DataType is "IFCDuration". "xs:duration" is its right backingType


Fix unavailable instances issues for StrictReplicaGroup

Clone of #10350

Codecov Report

Merging #10466 (00471c3) into master (f3c2c0d) will decrease coverage by 56.30%.
The diff coverage is 83.94%.

@@              Coverage Diff              @@
##             master   #10466       +/-   ##
=============================================
- Coverage     70.26%   13.97%   -56.30%
+ Complexity     6112      237     -5875
=============================================
  Files          2067     2016       -51
  Lines        111930   109563     -2367
  Branches      17027    16758      -269
=============================================
- Hits          78648    15308    -63340
- Misses        27756    93006    +65250
+ Partials       5526     1249     -4277

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.97% <83.94%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...instanceselector/ReplicaGroupInstanceSelector.java
33.33% <41.02%> (-1.67%)
:arrow_down:

...ing/instanceselector/BalancedInstanceSelector.java
50.00% <42.85%> (-34.62%)
:arrow_down:

...ting/instanceselector/InstanceSelectorFactory.java
76.19% <80.00%> (+1.19%)
:arrow_up:

...stanceselector/MultiStageReplicaGroupSelector.java
66.66% <92.30%> (-5.89%)
:arrow_down:

...routing/instanceselector/BaseInstanceSelector.java
94.82% <94.59%> (-4.28%)
:arrow_down:

...ceselector/StrictReplicaGroupInstanceSelector.java
95.16% <95.83%> (-0.30%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <100.00%> (ø)

...oker/routing/instanceselector/NewSegmentState.java
100.00% <100.00%> (ø)

...ing/instanceselector/SegmentInstanceCandidate.java
100.00% <100.00%> (ø)

...broker/routing/instanceselector/SegmentStates.java
100.00% <100.00%> (ø)

... and 1612 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Exactly once transactions request types

@guozhangwang down to 1443! It's not my fault our request types are so verbose 😝 .

Merging for now. Let me know if there are follow-up items that should be addressed.


HW: Folder restructuring

This PR restructures the folder in hardware subpackage.  The proposed structure is not necessarily final, can be subject to change in the future. Also, this PR creates the first abstract class for camera subpackage (whose content can be populated in another PR). @keithchev  and @ieivanov please let me know what do you think on the subfolder structure I introduced here.

I think this kind of organization makes a lot of sense. One question that it raises is whether to include the subpackage names (cameras, daqs, filters, etc) in the module names (e.g. orca_camera vs orca, ni_daq vs ni, etc). I don't have strong opinion but would generally favor not including the subpackage names, since I think the directory structure and import statements are sufficiently unambiguous. The one thing I feel strongly about is to pick a convention and enforce it (which would potentially mean, in this PR, renaming orca_camera to orca and asi_stage to asi).

I totally agree with you. I will make updates accordingly(like renaming orca_camera to orca). I am wondering how @ieivanov feels about this convention we are choosing.

A related issue is the specificity of the device subpackage names. It may be wise to include some model number or version in the interest of avoiding future namespace collisions. For example, this could mean using something more specific than asi for the ASI stage. But I can imagine the trade-off between specificity and verbosity is device-dependent, so it's hard to define conventions for this.

Specificity won't be easy to clarify with subpackage names as you pointed out. I am more inclined to being less verbose and more generic(given what I saw from vendor drivers). Possibly this issue deserves a bigger independent discussion. I am also open to evaluate subpackages case-by-case.

I totally agree with you. I will make updates accordingly(like renaming orca_camera to orca). I am wondering how @ieivanov feels about this convention we are choosing.

I do like this naming convention.
I would further add that the subpackage names should match the names of the abstract classes we implement, as we discussed in #136. This may mean renaming daqs to io_devices (DAQ stands for Data Acquisition, which is not exactly how we're using these cards) and filters to state_devices, depending on the convention we pick and how we implement the abstract classes. In this case the types of abstract classes we support would dictate the folder structure.
I'm not sure how to deal with things like pumps - maybe we should have a other category, which would not have to inherit an abstract class? I think this becomes a question of how many subpackages copylot would support and if we can seamlessly extend them.

I would further add that the subpackage names should match the names of the abstract classes we implement, as we discussed in #136. This may mean renaming daqs to io_devices (DAQ stands for Data Acquisition, which is not exactly how we're using these cards) and filters to state_devices, depending on the convention we pick and how we implement the abstract classes. In this case the types of abstract classes we support would dictate the folder structure.

I am open to rename subpackages @ieivanov. Also, the names chosen in this PR doesn't need to be final.  As we have implementations and abstract classes, we can refactor subpackage names as needed.
For the daqs, I went with it, since many vendors call them DAQ devices (despite these devices usually also have analog and digital voltage output capabilities). I would suggest voltage_io maybe? So it won't be confused with file IO or other sorts of IO operations.
For the state_devices, what are the other types of devices do you think fall into the same category with filters @ieivanov ?

I'm not sure how to deal with things like pumps - maybe we should have a other category, which would not have to inherit an abstract class? I think this becomes a question of how many subpackages copylot would support and if we can seamlessly extend them.

I would like to avoid other or misc device subpackage for as long as possible(I know it is not easy). With more software development around microfluidic devices and so, I feel pumps might have more implementations and their own abstract class eventually, or potentially we can merge with motor controller adapters like the ones in PyMotors.

I would suggest voltage_io maybe? So it won't be confused with file IO or other sorts of IO operations.

I didn't think of that. Let's stick with daqs then.

For the state_devices, what are the other types of devices do you think fall into the same category with filters

It's true that filters would cover most of the devices in this category. Another example of a state device would be a flip mirror, which is not exactly a filter. But maybe it's better to stick with a more descriptive name like filters rather than a more general name like state_devices.

With more software development around microfluidic devices and so, I feel pumps might have more implementations and their own abstract class eventually, or potentially we can merge with motor controller adapters like the ones in PyMotors.

Good point!

I would suggest voltage_io maybe? So it won't be confused with file IO or other sorts of IO operations.

I didn't think of that. Let's stick with daqs then.

I will merge this PR with daqs then but I later we can still rename it. voltage_io, signal_io or something else? we can keep this in the back of our minds.

For the state_devices, what are the other types of devices do you think fall into the same category with filters

It's true that filters would cover most of the devices in this category. Another example of a state device would be a flip mirror, which is not exactly a filter. But maybe it's better to stick with a more descriptive name like filters rather than a more general name like state_devices.

I didn't think of that. Do you have a flip mirror that we can write an adapter for? If so let's make an issue on it and add it. After we see device adapter implementations for filterwheels and flip mirrors it might be easier to merge everything together into  a single subpackage.


fix: fixed uninitialized config error on config init

:tada: This PR is included in version 2.5.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Job Training (Lalonde 1986) is missing

Hello,
Thank you for this rich review!
Job Training (Lalonde 1986) is missing (dead link)
We can found it in the R package 'qte'
(https://rdrr.io/cran/qte/man/lalonde.html#heading-0)

Hello,
Thank you for this rich review!
Job Training (Lalonde 1986) is missing (dead link)
We can found it in the R package 'qte'
(https://rdrr.io/cran/qte/man/lalonde.html#heading-0)

Great suggestion! I will add the link you provided!

I will close the issue as the link to Lalonde 1986 is added.


Fix Pod Disruption Budget exception

Fix null pointer exception while comparing Pod Disruption Budgets

👍

Coverage decreased (-0.009%) to 7.889% when pulling b959cc3f7f9109eddfa74d64979d9aaca7489ccf on fix-pdb-comparison into a98c712a52cfc81225c68e3298a84917d88c2235 on master.

👍

👍

Coverage decreased (-0.009%) to 7.887% when pulling 82835aaffcbf8195e288f96b31ba33ffbd142e9d on fix-pdb-comparison into a1deae198bf02e22c9344ac39729062acaa617c2 on master.

Coverage decreased (-0.009%) to 7.887% when pulling 82835aaffcbf8195e288f96b31ba33ffbd142e9d on fix-pdb-comparison into a1deae198bf02e22c9344ac39729062acaa617c2 on master.


Link to next release docs

I've added a link to the Netlify preview of the release-next branch so that contributors can more easily see the results of merging their next release documentation.
The process will be that we get all release notes, upgrade notes, installation links etc updated in the release-next branch  before we do the final release and then merge that branch into master after we have done the final release.
We might even update the release-next branch with installation versions for each beta release, so that users can more easily do pre-release testing.
I assume (hope) that the netlify preview site will not appear search engine listings.

I really like the idea of linking to the Netlify preview! Simple solution to the problem. Traffic levels to next docs should presumably be low in any case and it should be easy to keep up to date, in theory.

I assume (hope) that the netlify preview site will not appear search engine listings.

This is the only real blocker I might have with this PR - I'm not sure if this is true. I'm not really familiar enough with SEO to say confidently, but I think that the site will appear in search engine listings if we link to it like this.
Looking at https://release-next--cert-manager-website.netlify.app/robots.txt it looks like the site would be indexed.
Also, the HTML on the index page + docs page of the preview explicitly asks to be indexed:
<head>
...
<meta name="robots" content="index,follow"/>
...
</head>

The response headers indicate that the page should not be cached, though:

cache-control: public, max-age=0, must-revalidate

(I also wonder if this would be a case for rel=nofollow, but again I don't really know how to be confident about that)
I feel like if we're going to rely on a preview in "production" like this, then it would be good to be sure that it's not crawled. But I imagine it'll be a pain to get a different robots.txt / meta tag served on a preview.
Long story short: I'm concerned that this will be indexed unless I'm missing something that'll stop that. I don't think we'd want it to be indexed. I'm happy to merge anyway I think, but I'll add a hold in case you want to investigate further.
/approve
/lgtm
/hold

The deploy-preview sites already have the noindex header, but branch builds do not, so I'll try and add it according to these instructions:

https://docs.netlify.com/routing/headers/#custom-headers-for-different-branch-or-deploy-contexts

deploy-preview

$ curl --head -i https://deploy-preview-1135--cert-manager-website.netlify.app/
HTTP/2 200
age: 0
cache-control: public, max-age=0, must-revalidate
content-type: text/html; charset=UTF-8
date: Fri, 06 Jan 2023 15:11:05 GMT
etag: "9768dd9514ea9f1665c3ea8ac7127bd7-ssl"
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-nf-request-id: 01GP3T5CRCGCDV30JHB5SZPCNM
x-robots-tag: noindex
content-length: 90955

vs

branch-deploy

$ curl --head -i https://release-next--cert-manager-website.netlify.app
HTTP/2 200
age: 52
cache-control: public, max-age=0, must-revalidate
content-type: text/html; charset=UTF-8
date: Fri, 06 Jan 2023 15:09:49 GMT
etag: "0183a3a8da5a1b1c8658bedb256a6597-ssl"
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-nf-request-id: 01GP3T4P29Q622KMH7CFR8634Q
content-length: 90955

Thanks for reviewing that branch. The noindex headers are now appearing, so I think it's safe to merge this PR now.
$ curl --head -i https://release-next--cert-manager-website.netlify.app
HTTP/2 200
age: 0
cache-control: public, max-age=0, must-revalidate
content-type: text/html; charset=UTF-8
date: Fri, 06 Jan 2023 16:04:41 GMT
etag: "3db0e5296370dec005cb3901ac3ba678-ssl"
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-nf-request-id: 01GP3X7HTFCFRZDTK2H4VXZ1PQ
x-robots-tag: noindex
content-length: 90955

/hold cancel


1bit run good

from transformers import pipeline
messages = [
{"role": "user", "content": "Who are you?"},
]
pipe = pipeline("text-generation", model="ISTA-DASLab/Qwen2-72B-AQLM-PV-1bit-1x16", trust_remote_code=True, device_map="auto")
pipe(messages)
/usr/local/lib/python3.10/dist-packages/huggingface_hub/utils/_auth.py:94: UserWarning:
The secret HF_TOKEN does not exist in your Colab secrets.
To authenticate with the Hugging Face Hub, create a token in your settings tab (https://huggingface.co/settings/tokens), set it as secret in your Google Colab and restart your session.
You will be able to reuse this secret in all of your notebooks.
Please note that authentication is recommended but still optional to access public models or datasets.
warnings.warn(
config.json: 100%
 959/959 [00:00<00:00, 24.6kB/s]
model.safetensors.index.json: 100%
 171k/171k [00:00<00:00, 2.36MB/s]
Downloading shards: 100%
 5/5 [09:16<00:00, 104.07s/it]
model-00001-of-00005.safetensors: 100%
 4.99G/4.99G [01:59<00:00, 42.2MB/s]
model-00002-of-00005.safetensors: 100%
 4.99G/4.99G [01:59<00:00, 41.2MB/s]
model-00003-of-00005.safetensors: 100%
 4.99G/4.99G [02:00<00:00, 42.7MB/s]
model-00004-of-00005.safetensors: 100%
 4.99G/4.99G [01:58<00:00, 42.4MB/s]
model-00005-of-00005.safetensors: 100%
 3.17G/3.17G [01:15<00:00, 42.2MB/s]
Loading checkpoint shards: 100%
 5/5 [00:52<00:00,  6.42s/it]
generation_config.json: 100%
 242/242 [00:00<00:00, 13.7kB/s]
WARNING:accelerate.big_modeling:Some parameters are on the meta device because they were offloaded to the disk and cpu.
tokenizer_config.json: 100%
 1.29k/1.29k [00:00<00:00, 74.3kB/s]
vocab.json: 100%
 2.78M/2.78M [00:00<00:00, 8.50MB/s]
merges.txt: 100%
 1.67M/1.67M [00:00<00:00, 12.5MB/s]
tokenizer.json: 100%
 7.03M/7.03M [00:00<00:00, 21.2MB/s]
Device set to use cuda:0
/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py:1965: UserWarning: TORCH_CUDA_ARCH_LIST is not set, all archs for visible cards are included for compilation.
If this is not desired, please set os.environ['TORCH_CUDA_ARCH_LIST'].
warnings.warn(
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:20: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code1x16_matmat")
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:33: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code1x16_matmat_dequant")
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:48: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code1x16_matmat_dequant_transposed")
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:62: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code2x8_matmat")
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:75: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code2x8_matmat_dequant")
/usr/local/lib/python3.10/dist-packages/aqlm/inference_kernels/cuda_kernel.py:88: FutureWarning: torch.library.impl_abstract was renamed to torch.library.register_fake. Please use that instead; we will remove torch.library.impl_abstract in a future version of PyTorch.
@torch.library.impl_abstract("aqlm::code2x8_matmat_dequant_transposed")
[{'generated_text': [{'role': 'user', 'content': 'Who are you?'},
{'role': 'assistant',
'content': 'I am Qwen, a large language model created by Alibaba Cloud. I am here to assist you'}]}]

ISTA-DASLab/Qwen2-72B-AQLM-PV-1bit-1x16
content': 'I am Qwen, a large language model created by Alibaba Cloud. I am here to assist you'}]}]

!pip uninstall torch torchvision torchaudio -y
!pip install torch==2.4.0 torchvision==0.19.0 torchaudio==2.4.0 --index-url https://download.pytorch.org/whl/cu121
!pip install aqlm[gpu,cpu]


Fix issue with NVIDIA and axis mapping for joysticks.

The NVIDIA SHIELD TV platform reports non-joystick axis values for the left stick in addition to the normal axis values. Probably related to the "virtual mouse" left stick function.
See ticket #45712.
This pull request is separate from the one for master because of member name changes which were applied in master in the Java shim files.
Bugsquad edit: 3.2 version of https://github.com/godotengine/godot/pull/45771.

@michael-conrad Can you address the reported static checks issues, thanks.

@michael-conrad Can you address the reported static checks issues, thanks.

Is there a way to set the automatic formatting in Android Studio to match these requirements?

iOS Build failed. Please re-run.

While reviewing this code, I see a scenario that will cause it to fail. Working on a fix.

@michael-conrad Can you address the reported static checks issues, thanks.

Is there a way to set the automatic formatting in Android Studio to match these requirements?

@michael-conrad Android Studio has a clang-format plugin which can read Godot's clang setup and update formatting accordingly.
It's a manual action unfortunately, so I usually run it once before submitting code for review.

While reviewing this code, I see a scenario that will cause it to fail. Working on a fix.

@michael-conrad Let us know when the PR is ready for review.

Pull request description updated. Code is ready for review.

Thanks!


Booleanize language filtering by feed

Currently, language filtering (as far as i can tell) applies to every feed indiscriminately.
The issue with this is that for some feeds (such as fan-art feeds) I would like to see content by users even if its in a language I do not speak, whereas for others (such as what's hot) I'd only like to see content in my languages.
My proposed solution is to have every feed send a boolean which if set to true will tell the client to override language filtering. The default value should be false.

This isn't my ideal solution but it would probably be sufficient so I want to second it.
I run a feed that you would expect any language in but specifies English/Japanese/Korean in the title and description. I try to write pinned posts to the feed reminding people to turn off their language filtering, particularly Japanese and Korean users who are most often the ones unaware of the setting. Even if I write an explanation posts that covers all 3 languages and pick all 3 languages in the post options, it almost never gets picked up by all 3. Meaning the people who need to see it the most aren't going to unless I write 3 different posts that I have to clog my feed up with.
Personally, I don't really see what the content language options are really accomplishing to begin with but an option for a feed to opt-out would be at least preferable. Nobody is going into my feed not expecting multiple languages.

Personally, I don't really see what the content language options are really accomplishing to begin with but an option for a feed to opt-out would be at least preferable. Nobody is going into my feed not expecting multiple languages.

I think language filtering can be useful for some feeds (most people probably only wanna see languages they understand in what's hot for example) but it's currently far, far too restrictive to the point it's causing more harm than good.
I also keep seeing bilingual artists posting in english but having their posts get hidden because the ML model thinks its their other language for some reason. Not ideal.

I'm +1 to this, we'll also want it for moderation settings.

I'm getting complaints from SkyFeed users all the time that their published custom feeds are missing some posts. In almost all cases, this is caused by the content language filter settings in the official Bluesky app. In addition to letting custom feeds specify if they should be language-filtered, I would suggest these improvements:

When posts are hidden from a feed due to content language filter settings, show a little banner at the top of the feed and an option to show them
When setting up a new account, ask users if their content language settings are correct

So overall users should be made more aware that the language filter system exists and how it works

With the deluge of new users from non-English speaking parts of the world, this is about 10-fold more frustrating than it already was. Requesting escalation.

When I first saw the section on "Language handling" in the Starter Guide, my hope was the Content-Language response header would serve that purpose.

If language filtering is applied, the feed generator should use the the Content-Language response header indicating the parsed language codes.

In my mind, since the presence of the Content-Language response header tells the client that the server had handled the filtering as appropriate for that feed, then the client should not do additional filtering if it is compatible with the request. If it was missing or didn't fit the request, then the client would do it's own filtering. As it is now, I am not sure that the response header serves a purpose. I think this would be fairly backwards-compatible.


Connecting CLAP's context-menu extension to JUCEs AudioProcessorEditorHostContext

We shouldn't merge this until an upstream PR in clap-helpers is merged (see free-audio/clap-helpers#18). But I figured I'd open the PR in case folks want to test it out and/or review the code.
Update: Upstream changes have been merged so this PR should be good to go!

This looks spot on to me. Let me just see if I can test a surge build with it in bws 5.

So it works great
But either we don't have that glyph in our menu or we aren't getting a UTF-8 string
I propose we merge this then bug abide about that
Agree?


Time is not displayed for the Romanian language

Describe the Bug
Time is not displayed for the Romanian language for books and shelves.

Steps to Reproduce
Set the Romanian language in preferences
Expected Behaviour
Display the correct time
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v23.05.2
PHP Version
8.1
Hosting Environment
Ubuntu 20.04 VPS installed using official installer script

Thanks for reporting @TheRazvy, Looks like the variable placeholders were accidentally translated.
Have addressed via the BookStack Crowdin project, Fixed translations should come through and get merged during as part of all translation updates for the next feature release.


ci: stop using node0 at the first node name

Description
This pull request changes the following:

Changing all unit test and e2e test to use node1 as the first node name

Related Issues

Closes #526

:tada: This PR is included in version 0.29.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to connect to the eventhub

Followed the instructions on this document, unable to build or start the application. Getting the below error,
Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'azureAdmin' defined in class path resource [com/microsoft/azure/spring/cloud/autoconfigure/context/AzureContextAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.microsoft.azure.spring.cloud.context.core.impl.AzureAdmin]: Factory method 'azureAdmin' threw exception; nested exception is java.lang.IllegalArgumentException: Parameter this.client.subscriptionId() is required and cannot be null.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7bb8bc1e-65b0-f895-942c-cb3aec127f85
Version Independent ID: 9f3d829e-8288-5a80-fd9f-ba51fbb52590
Content: How to use the Spring Boot Starter for Apache Kafka with Azure Event Hubs
Content Source: docs-ref-conceptual/spring-framework/configure-spring-cloud-stream-binder-java-app-kafka-azure-event-hub.md
Service: event-hubs
GitHub Login: @rmcmurray
Microsoft Alias: robmcm

I used the same dependency versions in the document. Also, tried with the 2.1.0-RELEASE version as there is some known Incompatibility issues, nothing worked. This seems to be within  the Azure classes.
https://github.com/spring-cloud/spring-cloud-stream/issues/1521

Hi Selva
Were you able to find a solution to the above issue?
I am facing the same and haven't been able to get over it. I have already specified the intended subscription id via "az account set -s " and also "az account list" shows the intended subscription to be the default. Still when we run, it can not pick the subscription id :(

@shshekhar - I tried everything all I can and put some debug points inside the code. Looks like something is broken in the code and unable to get the subscription ID. I did not get response from Azure team yet. Will wait for their confirmation.


Fix font kerning in container

There is a known (1)issue in Debian distros around subpixel
hinting & font smoothing. Link below provides a description
& an example font configuration for fixing it.
This was highlighted in (2)below the wkhtmltopdf issue.
The font configuration(according to the Readme found in
fonts/config.d/) relies on ordering hence the 10- prefix.

https://wiki.debian.org/Fonts#Subpixel-hinting_and_Font-smoothing

https://github.com/wkhtmltopdf/wkhtmltopdf/issues/45

:haircut: hax0r :neckbeard:
@gtvj


Md-tab scroll tabs

feature request:
Mdtab doesn't scroll tab if there's not enough space. It doesn in material1
What is the expected
Scroll tab
What is the current behavior?
Not scrolling
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
Small screen with multiple tabs

#1243


bump ggcr & k8schain module versions

I manually bumped the version of github.com/google/go-containerregistry & it's k8schain module.
k8schain was bumped to use the latest version (v1.19.7) of github.com/vdemeester/k8s-pkg-credentialprovider.
This should drop any transient k8s.io v1.18 deps - see https://github.com/tektoncd/triggers/pull/934#discussion_r566391743
NONE

/ok-to-test

/kind cleanup

/approve
/cc @tektoncd/core-maintainers

/retest

/retest


Add explicit links and add real names

@socadk and me joined forces to create MADR. @boceckts was the head of eadlsync

Cool, thank you for the fix!


Get row count

It's nice lib.but I want to know there is a way to show only two row with show more.
For this i need row count but i am always getting row count 1.

There is a setMaxRows() method which limits the number of displayed rows.
flowLayout.setMaxRows(2);

So how can i check that number of rows is more than 2,because in my case i have to set show more button if rows is more then two.

final FlowLayout flowLayout = findViewById(R.id.flow);
String[] dummyTexts = getResources().getStringArray(R.array.lorem_ipsum);

for (String text : dummyTexts) {
    TextView textView = buildLabel(text);
    flowLayout.addView(textView);
}

// flowLayout.getRowsCount() returns 0 here since item positions are only calucated
// when FlowLayout's onMeasure() is triggered.

// Use flowLayout.post() to ensure that the flowLayout.getRowsCount() is called after
// FlowLayout's onMeasure()
flowLayout.post(new Runnable() {
    @Override
    public void run() {
        if (flowLayout.getRowsCount() >= 2) {
            flowLayout.setMaxRows(2);
        }
    }
});


Something wrong with 'TS_data'

Thank you for sharing your excellent work. I downloaded the TS_data three times but I couldn't extract it. The error message is "An error occurred while loading the archive.", but the "OS_data" opened successfully. I wonder if it's me or the dataset?

Thank you for sharing your excellent work. I downloaded the TS_data three times but I couldn't extract it. The error message is "An error occurred while loading the archive.", but the "OS_data" opened successfully. I wonder if it's me or the dataset?

Same with me .   It  means  somthing wrong with the download link

Thank you for sharing your excellent work. I downloaded the TS_data three times but I couldn't extract it. The error message is "An error occurred while loading the archive.", but the "OS_data" opened successfully. I wonder if it's me or the dataset?

Please refer to my answer in #4

Thank you for sharing your excellent work. I downloaded the TS_data three times but I couldn't extract it. The error message is "An error occurred while loading the archive.", but the "OS_data" opened successfully. I wonder if it's me or the dataset?

Please refer to my answer in #Issue4 .

Received, thanks.

I have re-upload TS_data.zip, and please try to download it again.


When using the bottom sheet, if you jump to a new page on the bottom sheet, you can jump normally for the first time. After getting. Back () on the new page, click get. To () on the bottom sheet, and the page will not jump

When using the bottom sheet, if you jump to a new page on the bottom sheet, you can jump normally for the first time. After get.Back () on the new page, click get. To () on the bottom sheet, and the page will not jump

IOS is normal and Android is abnormal

me too, i’ve provid a demo for you to implement.
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:get/get.dart';

void main() {
  runApp(MyApp());
  SystemUiOverlayStyle style = SystemUiOverlayStyle(
    statusBarColor: Colors.transparent,
  );
  SystemChrome.setSystemUIOverlayStyle(style);
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GetMaterialApp(
      home: MyAppHome(),
    );
  }
}

class MyAppHome extends StatelessWidget {
  void jump() {}

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Builder(
        builder: (ctx) => Center(
          child: ElevatedButton(
            onPressed: () {
              Get.bottomSheet(
                Container(
                  color: Colors.green,
                  height: 200,
                  child: Center(
                    child: ElevatedButton(
                      onPressed: () {
                        print(Get.currentRoute);
                        Get.to(
                          () => ContainerPage(),
                        );
                      },
                      child: Text('jump'),
                    ),
                  ),
                ),
              );
            },
            child: Text('bottom'),
          ),
        ),
      ),
    );
  }
}

class ContainerPage extends StatelessWidget {
  const ContainerPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        leading: IconButton(
          onPressed: () {
            Get.back();
          },
          icon: Icon(Icons.backpack),
        ),
      ),
      body: Center(child: Text('123')),
    );
  }
}

when i close bottomsheet and open it again, i can to new page

I reproduced too.
It can be solved temporarily by setting preventDuplicates option to false.
But, I think it's not prefect solution.
At the bottom sheet, go to new page(/new) and return to bottom sheet through Get.back();
GetX.currentRoute is still /new although i closed page "/new"
It should be fixed on route observer.

"dialog" same to issue .

get: ^4.3.8
same issue

This problem persists in version ^4.6.1


Testing vh

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts
[ ] I have checked that no one else is on staging and deployed this feature branch

Might have found the trick. Adding --coverage to the test command gives me local access to the tests. Adding "Mocks" is a great way to test more code.


Successfully Removed Bug regarding labels and placeholders

Fixes Issue #530

My PR closes #issue_number_here
Changes proposed
Made the create event page responsive to screen size or width to add or remove placeholders and adding labels for desktop view.
What were you told to do ?

What did you do ?

Check List (Check all the applicable boxes)

[] My code follows the code style of this project.
[] This PR does not contain plagiarized content.
[] The title and description of the PR is clear and explains the approach.

Screenshots

@IAmTamal please merge this pull request. You will see 1 test which is a deployment error but I have correctly modified the code to work as you wish. There will be no problem after merging I assure you from my side.

Please help I cannot see the logs
@IAmTamal

At least Approve the review so that it counts in my Hacktoberfest contribution. I would lose the opportunity to get the last badge.

make sure you do the changes by then. This is a VERY UNETHICAL WAY.

Ok I will give the best @IAmTamal

Ok, I will give the best @IAmTamal Thank you sir for approving and getting me the last badge of hacktoberfest.

Do make the changes and push it

ok sir.


JavaScript build optimizations

From:
585M	metadoc-js/target/scala-2.12/scalajs-bundler/main/node_modules/
 11M	target/metadoc/

To:
208M	metadoc-js/target/scala-2.12/scalajs-bundler/main/node_modules/
6.5M	target/metadoc

I still assume it's because it parses the +1Mb Scala.js output. I can look into whether we can skip that it even looks at it when the output changes.

It's a lot. It could be we are using scalajs-bundler wrong, as in overriding something in the webpack config which causes the slow down.

The two solutions I’m aware of to reduce webpack processing time are 1) use the LibraryOnly bundling mode, and 2) use Webpack 4.

That's good to know. I looked into updating to webpack 4 yesterday.


Add breadcrumb navigation labels

Description
This PR addresses Issue #24 and some few UI tweaks.

It introduces the breadcrumb navigation system. With node navigation, users can display the current path of nodes and have a clear overview of their progress within the visualizer. Whether traversing back or forward, their navigation is recorded in a viewable state.

Several minor code improvements have been introduced. The changes enhance code readability, remove unused variables, and resolve type compatibility issues.

Add a nav menu with links to repo, docs, and community site. Hamburger menu for smaller screen sizes.

Example
Breadcrumb labels

Responsive menu

Winning the MVP for PR Comment quality!


docker/runc: emit warnings (not error) in case does not exist

Mute logs (warning instead of errors) when docker or runC probes are created back capabilities are missing from host.
To test create a system which is missing either runc or docker and then run:
export SKYDIVE_AGENT_TOPOLOGY_PROBES="runc docker"
sudo -E $(which skydive) allinone

And verify that repeated log messages are a warning every 1s

run skydive-k8s-tests

@hunchback I'm not sure about this. The usual scenario (Kubernetes, ...) is that docker is started before Skydive. If the operator specified it wants the docker probe enabled, and if for some reason docker is not running or not reachable due to a wrong configuration in the Skydive configuration file, I think it makes sense to display an error. What probably doesn't make much sense is to display the error message every second though

Just to recap our discussion during the community meeting:
If Skydive is started when docker/runc is not started yet, we should display an "ERROR" message like "failed to connect to docker. We'll retry in the background every n seconds". When Docker is later available, we should display an "INFO" message like "successfully connected to Docker". If the connection to Docker is lost, we should do the same than above : print an error message and retry in the background.

@lebauce - I will close this for now - and create a new PR if/when handled


zm static function is used in roki-fd

I have got bellow error because _zQPSolveASM is static function although roki-fd is using _zQPSolveASM.
agcc -ansi -Wall -O3 `roki-config -L` `roki-gl-config -L` `roki-fd-config -L` `roki-config -I` `roki-gl-config -I` `roki-fd-config -I` -funroll-loops -g -o main main.c `roki-config -l` `roki-gl-config -l` `roki-fd-config -l`
/usr/bin/ld: /usr/lib/libroki-fd.so: undefined reference to `_zQPSolveASM'
collect2: error: ld returned 1 exit status
make: *** [makefile:12: main] Error 1

Let me close this issue because _zQPSolveASM() has been successfully reimplemented in RoKi-FD https://github.com/mi-lib/roki-fd/commit/b960edebd903d026addb65b01265585a868b8259


Tests - Video encoder test

Added amd_media_tests directory with encoder.gdf into MIVisionX/tests/

@kiritigowda @rrawther I got rid of the full path for the input as I found it is not needed with the encoder.


Internal Jar files in Maven based projects using amazon-redshift-jdbc-driver

Driver version
<IP_ADDRESS>
Redshift version
Redshift version does not matter.
Client Operating System
OS should not matter here. Issue is about Maven builds.
JAVA/JVM version
JVM version should not matter, anything supported by this project is fine.
Table schema
N/A
Problem description
The 2.1.x versions of this project depend on some internal Amazon Jar files.

aws-java-sdk-redshift-internal-1.12.x.jar
aws-java-sdk-redshift-arcadia-internal-1.0.jar

These files are not available in Maven. It is unclear how to include these files. They do not have licenses, and extra steps are needed to download them in a Maven build.
What is the recommended approach for using a 2.1 release and including these Jar files in a Maven project?

Expected behaviour:
Can include amazon-redshift-jdbc-driver as a Maven dependency and it works at runtime without any ClassNotFoundExceptions.
Actual behaviour:
Classes from the internal Jars are missing, and can throw ClassNotFoundExceptions at runtime.
Error message/stack trace:
java.lang.NoClassDefFoundError: com/amazonaws/services/redshiftinternal/AmazonRedshiftInternalClientBuilder  at com.amazon.redshift.jdbc.RedshiftConnectionImpl.<init>(RedshiftConnectionImpl.java:262)  at com.amazon.redshift.Driver.makeConnection(Driver.java:492)  at com.amazon.redshift.Driver.connect(Driver.java:305)  at org.apache.commons.dbcp2.DriverConnectionFactory.createConnection(DriverConnectionFactory.java:38)  at org.apache.commons.dbcp2.PoolableConnectionFactory.makeObject(PoolableConnectionFactory.java:260)  at org.apache.commons.dbcp2.BasicDataSource.validateConnectionFactory(BasicDataSource.java:2337)  at org.apache.commons.dbcp2.BasicDataSource.createPoolableConnectionFactory(BasicDataSource.java:2323)  at org.apache.commons.dbcp2.BasicDataSource.createDataSource(BasicDataSource.java:2056)  at org.apache.commons.dbcp2.BasicDataSource.getConnection(BasicDataSource.java:1533)  ...
Any other details that can be helpful:

JDBC trace logs
N/A
Reproduction code
N/A

Yes , we are aware of this issue. These two jars are right now internals and not publish in Maven. We are pursing in AWS to make it available in Maven. But in the mean time, please get two jars from source "lib" directory and install it in Maven, if you can. Sorry for any inconvenience.

Thank you for the response. Do you know the license for the internal Jar files? Can they be distributed in a commercial product?

Let me check on it. Mostly it should not be an issue.

Assuming that the license of the internal jars allow it, would it be possible to shade their content into the main jar (like it is being done with the onscram libraries)?
Actually when checking the pom.xml file in Maven Central (https://repo1.maven.org/maven2/com/amazon/redshift/redshift-jdbc42/<IP_ADDRESS>/redshift-jdbc42-<IP_ADDRESS>.pom), it doesn't mention any dependency to the internal jars, but when building the driver locally, the reduced pom generated by maven-shade-plugin keeps those dependencies.

Please check build.gradle file. It has dependencies. We recommend to use Gradle for building. For question about internal jar deployments, we are working to get rid of it. So keep that in mind and not recommend to deploy the stuff which is going away. We keep dependencies out of the main jar because that way it's clear what's in use if any CVE found.

@iggarish We might need to upgrade to the 2.1.x release before you have phased out the internal Jars. Can we include the internal Jar files in a commercial product?

Sure, you can. But keep in mind we stop distributing internal jar anytime soon.

We are working on get rid of internal jars. Mostly next release <IP_ADDRESS> won't have it. I will update here when it happens. Plan the release for first week of July.

Thank you for the update.

<IP_ADDRESS> released.


Publish builds to gh-pages again

We now publish builds of Catalog to gh-pages again.
make dist also got a bit smarter. It now determines a prerelease on the version number in package.json (if it contains a dash, it's a prerelease). Use it to bump the version, publish to npm, and to publish to gh-pages.
Every version gets its own directory on gh-pages including the full documentation for this version and the built files. Additionally, stable releases get published to the top level and prereleases to next/.

As it is now, make dist only works interactively. There's potential to automate and do publishing to npm and gh-pages with Codeship, as @naehrstoff suggested in #90. Proposal:

For version bumps just use npm version manually, then push to the repo. We can't automate this step because we don't have full test coverage.
make publish determines if prerelease or not based on the - heuristic in the current package.json (i.e. 2.2.0 is a stable, 2.3.0-alpha.1 is a prerelease version)

stable versions get published to npm using the latest tag, UMD build and docs get published to the GH Pages root and the version directory (e.g. 2.2.0/)
prerelease versions get published to npm using the next tag, UMD build and docs get published to GH Pages next/ and the version directory (e.g. 2.3.0-alpha.1/)

When you push without changing the version, make publish should just do nothing (or maybe publish the docs anyway but we wouldn't want to rebuild the UMD builds).

Look good and 👍  for migrating back to github.io.


Illuminate\Routing\Middleware\ThrottleRequests::addHeaders() don't support PSR-7 Response 📧

Laravel Version: 5.6.26
PHP Version: 7.1.17

Error:
Argument 1 passed to Illuminate\Routing\Middleware\ThrottleRequests::addHeaders() must be an instance of Symfony\Component\HttpFoundation\Response, instance of Zend\Diactoros\Response given, called in /app/vendor/laravel/framework/src/Illuminate/Routing/Middleware/ThrottleRequests.php on line 61
Description:
When ThrottleRequests middleware is used with PSR-7 and PHP 7.1 with strict_mode enabled, addHeaders method cant be used because has type Response on first param:
protected function addHeaders(Response $response, $maxAttempts, $remainingAttempts, $retryAfter = null)

PSR-7 use Zend\Diactoros\Response, and ThrottleRequests uses Symfony\Component\HttpFoundation\Response
Possible solutions

Is not possible extends ThrottleRequests because we can't rewrite original addHeadersp function.
Add an if on addHeaders() and chick if we are using PSR-7 response ($response->headers->add to $response->withAddedHeader
Replacing original addHeadersp with GrahamCampbell/Laravel-Throttle

If the option 2 is right, I would be happy to do a PR.

I found the problem. Laravel, automatically converts PSR-7 responses to Synfony responses.
⚠ But PSR-7 instance IS CONVERTED ONLY WHEN RESPONSE COMES FROM A ROUTE OR CONTROLLER ⚠
Then, in my case, response comes from an Error Handler. The problem also occurs if PSR-7 RESPONSE is generated in a middleware.
Solution
// some middleware or error handler
use Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory;

$http_foundation_factory = new HttpFoundationFactory();
$laravel_esponse = $http_foundation_factory->createResponse($psr_response);

Solution 2
Check your middlewares: return a response is required on every handle() methods .

Hi I am very new to Laravel Where I need to add this

Hi!
Search on your code some use of Symfony\Component\HttpFoundation\Response. If you return some $response with this type, replace with solution.

Just for future readers.... I had this issue and it was due to my middleware not catering for an else.
Changed this:
  if (($request->get('tenant_identifier') === $request->user(
                    )->tenant_identifier) && ($request->get(
                        'enterprise_identifier'
                    ) === $request->user()->enterprise_identifier)
            ) {
                return $next($request);

To this:
            if (($request->get('tenant_identifier') === $request->user(
                    )->tenant_identifier) && ($request->get(
                        'enterprise_identifier'
                    ) === $request->user()->enterprise_identifier)
            ) {
                return $next($request);
            } else {
                abort(403);
            }

My code is also causing such an issue. Can anyone help me to solve this?
Thanks in advance.
Code is here:
public function store(Request $request , User $seller)
{
$rules =[
'name'=>'required',
'description'=>'required',
'quantity'=>'required|integer|min:1',
'image'=>'required|image'
];
$this->validate($request,$rules);
$data = $request->all();
$data['status'] = Product::PRODUCT_UNAVAILABLE;
$data['image'] = 'images/1.jpg';
$data['seller_id'] = $seller->id;
    $product = Product::create($data);
    $product->save();
    return $this->showOne($product);
}

Ali did you find the solution. I think we are watching same tutorial on Udemy and got same error. I am still looking for the solution. If you find it please let me know.

If you get this error while using an API, try to return JSON response in the failedValidation method inside the FormRequest you use to validate the request as follwoing:

    protected function failedValidation(Validator $validator)
    {
        $errors = $validator->errors()->toArray();

        $info = [
            'success' => false,
            'message' => 'The given data was invalid.',
            'status_code' => 422,
            'status_description' => 'The given data was invalid.',
            'errors' => $errors
        ];

        $response = new JsonResponse($info, 422);

        throw new ValidationException($validator, $response);
    }

this approach is working for me

I did the jwt handle on laravel, and the same problem occurred, please help
`<?php
namespace App\Http\Middleware;
use Firebase\JWT\JWT;
use Firebase\JWT\ExpiredException;
use Closure;
use Exception;
class JWTAuth {
public function handle($request, Closure $next, $guard = null)
{
	$token = $request->header('Authorization');
	$verify = explode(" ", $token);

	if ($verify[0] !== "petani") {

		return [
			'code' => 401,
			'error' => 'Token not provided.'
		];
	}

	if (!$token) {

		return [
            'code' => 400,
            'error' => 'Provided token is expired.'
        ];
	}

	try {
		$credentials = JWT::decode($verify[1], env('JWT_SECRET'), ['HS256']);
	} catch(ExpiredException $e) {

		return [
			'code' => 400,
			'error' => 'Token is expired. '
		];
	} catch(Exception $e) {

		return [
			'code' => 400,
			'error' => 'An error while decoding token.'
		];
	}

	return $next($request);
}

}
?>`

Hi @iqbalnur32 ... Change your return statement to abort functions and you won't get the PSR-7 error.
Therefore instead of returning an array, just abort:
abort(400, 'Token expired') etc..

oke sir iam add method reponse is work
Pada tanggal Sen, 31 Agt 2020 12:46, Keith Mifsud<EMAIL_ADDRESS>menulis:

Hi @iqbalnur32 https://github.com/iqbalnur32 ... Change your return
statement to abort functions and you won't get the PSR-7 error.
Therefore instead of returning an array, just abort:
abort(400, 'Token expired') etc..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/24730#issuecomment-683562886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJNX7ISPYFRKZNHBITADBDDSDM2MZANCNFSM4FIABJMA
.

If you get this error while using an API, try to return JSON response in the failedValidation method inside the FormRequest you use to validate the request as follwoing:
    protected function failedValidation(Validator $validator)
    {
        $errors = $validator->errors()->toArray();

        $info = [
            'success' => false,
            'message' => 'The given data was invalid.',
            'status_code' => 422,
            'status_description' => 'The given data was invalid.',
            'errors' => $errors
        ];

        $response = new JsonResponse($info, 422);

        throw new ValidationException($validator, $response);
    }

this approach is working for me

this worked for me as well, and thank you a thousand times 👍


Auto deployments are now zonal not regional so update the tests.

/assign @Bobgy
/assign @IronPan

/lgtm

/approve


Updated links in set-up-communications-credits-for-your-organization.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/7930.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Upgrade to Mono 5.4.1

Everything required for upgrading Mono from 4.4.2 to 5.4.1.
This PR contains:

[ ] Changelog - not really feature related, do we still put this in the changelog?
[x] Documentation - changed the mono version pointed to from README.md
[x] Tests - covered by same tests as before

Hmm.. the build on travis is failing. Seems to be due to something related to libgdiplus in the stripped down Mono zip. I'll try to find out why.

Now the problem on Travis is fixed, but now there's a failing AppVeyor build. I'm guessing that has nothing to do with the changes in this PR.

I consider this ready to merge now, after going through quite a bit of testing by me plus a round of external tools testing.


Compilation error with XCode 9.0

I'm trying to compile an app that uses sol on macOS Sierra with XCode 9.0, but I get the following error:
../dolmen/extra/sol.hpp:7197:58: error: expected unqualified-id
                        if (t == type::table || t == type::none || t == type::nil) {
                                                                              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:92:19: note: expanded from macro 'nil'
      #define nil nullptr
                  ^

Wow, that's some non-hygenic macro defined by Apple. Shame! Generally once a macro collision occurs, everyone loses.
In case you don't actually use nil in the meaning defined by Objective-C, you can work around it by doing #undef nil before including any of the Sol2 headers.

No longer a problem: https://github.com/ThePhD/sol2/releases/tag/v2.18.3

Thanks to both of you. I tried downloading the latest version but the problem is still there. Applying the fix suggested by @milleniumbug does work though.

Are you aware that changing it from nil to lua_nil is effectively a breaking change? lol

@jeychenne What's the errors you're getting (perhaps you have a full build log you can paste directly here, in a pastebin, or a gist)?
@Rapptz: There's still an alias to nil = lua_nil in the enum definition, if we detect we're not on Objective-C/C++ (where nil is a keyword). I'll also add the macro guards to be extra safe.

Ah alright. I missed the alias.

@ThePhD Here is the error:
../dolmen/extra/sol.hpp:4521:14: error: expected unqualified-id
        const nil_t nil{};
                    ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:92:19: note: expanded from macro 'nil'
      #define nil nullptr
                  ^
In file included from ../dolmen/main.cpp:11:
In file included from ../dolmen/DolmenApp.h:43:
In file included from ../dolmen/lib/Project.h:46:
In file included from ../dolmen/runtime/scripting.h:8:
../dolmen/extra/sol.hpp:4925:3: error: expected identifier
                nil = lua_nil,
                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:92:19: note: expanded from macro 'nil'
      #define nil nullptr
                  ^

This might be fixed now, but I don't have a Mac with an OSX SDK on it to test for sure. Still, I vetted the entire framework for uses of nil and it should be all cleared now.
Try latest or get it from here again: https://github.com/ThePhD/sol2/releases/tag/v2.18.3

Thanks again. I don't have my mac handy but I'll try on Monday and will let you know...

I was able to take a look at it and I can confirm that the latest version works without any problem. Thanks again for the quick fix!

Great! Good luck out there.


Ethan: Watch dev.to/ankushppie

Ethan requests the watch of the watch_keyword dev\.to/ankushppie. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

dev\.to/ankushppie has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ