KAFKA-1893: Allow regex subscriptions in the new consumer

Good comments from Grant. Other than that this change looks good.

@hachikuji @granthenke I have addressed your review comments. Let me know if I am still missing something. Thanks!

LGTM
@guozhangwang Do you want to have a look?

@SinghAsDev Another problem that @guozhangwang and I briefly talked about was whether we should augment the Metadata object to support getting metadata for all topics (with a hook to get a notification when there is a change)*. Your approach is exactly the one I had in mind, but it does result in a little more overhead since metadata refreshes are done both in KafkaConsumer and in NetworkClient. The nice thing about separating them is that it lets you refresh the full metadata list less frequently. If your regex only covers a small set of the topics, then that makes "normal" metadata refreshes cheaper and they can be done more often. However, it seems a little questionable whether this capability is actually useful in practice, so reducing the metadata overhead might be the bigger win. What do you think?
*Note that it's still useful to be able to bypass NetworkClient to support the listTopics API (which doesn't affect subscriptions).

@hachikuji that makes sense and I actually suggested the same even for listTopics patch. Is my understanding correct that what you are suggesting is similar to my suggestion on listTopics JIRA?

@SinghAsDev I think the listTopics approach is still fine and doesn't need to be changed. The key difference is that listTopics doesn't affect subscriptions, so it should not have any impact on the Metadata shared throughout the consumer.

@SinghAsDev Sorry for being late on this, regarding the subscribe semantics I am convinced 1) we do not need to have an extra blacklist pattern in the API but just let users specify that in the regex, and 2) we do not need to do incremental subscription and replacing subscription should just be fine.
Regarding the metadata refresh, what I was thinking is that the current patch took a different scheduled task with different topic sets outside Metadata for regex subscription, while if we can piggy-back it with metadata refresh we can potentially reduce the code complexity while the cost of having metadata refresh always asking for all topics seems OK to me since in practice users would probably want to set the "regex refreshing interval" to be the same as "metadata refreshing interval" the same anyways. What do you think?
On the other hand, we do not necessarily need to make ListTopics API also changing the Metadata states object as @hachikuji suggested since I feel it is in many cases a one-time thing.
I could review this PR again and check it in once it gets rebased / updated.

@guozhangwang @hachikuji makes sense. Will update. However, for this to happen we need to somehow make networkClient aware of the fact that if pattern subscription is being used get metadata for all topics. There are a few ways I could think of for doing this.

Have Metadata object maintain a flag that indicates wether we need metadata for all topics or just for the ones maintained in metadata.
Have NetworkClient maintain a flag which is set by KafkaConsumer during subscribe(pattern) and unsubscribed during unsubscribe(pattern). This will require changing the KafkaClient interface though.

I am more inclined towards Option 1. What do you guys suggest?

@SinghAsDev Option 1 definitely sounds nicer to me.

@SinghAsDev Btw, I was planning to use a MetadataListener in KAFKA-2464 to hook into metadata updates: https://github.com/apache/kafka/pull/165/files#diff-62bba39339405475f71241a182ef9819R229. Seems like that might be sufficient for this case too.

@hachikuji yea, it will be needed. Should I wait for your patch to go in?

 I'll rebase accordingly.

+1 on option 1 also.

@hachikuji @guozhangwang I have updated the PR with the discussed approach. Let me know how it looks. I will add some unit tests for the new methods added to metadata tonight.

Ahh.. looks like I will again have to rebase. Will do that along with adding unit tests for Metadata.

@hachikuji @guozhangwang could you guys take a look. Thanks!

I notice you rebased against trunk, but did you try to build it after that? There is now a MetadataUpdater interface and all metadata operations go via that interface now in order to support cases in the broker where we don't need metadata updates to happen while using NetworkClient.

@ijuma looks like build failed during checkstyle, I did build jars before pushing that apparently does not execute checkstyle. Pushing the fix now.
I did not get your reference to MetadataUpdater, am I doing something wrong in my patch?

@SinghAsDev, oh I see. Seems like a bug that we don't run checkstyle then. Would you mind filing a JIRA?
Ignore my other comment, I had a second look and your change is actually within DefaultMetadataUpdater, so it's fine.

@ijuma created KAFKA-2513.

Unrelated test failure. @hachikuji could you take a look. Thanks!

@SinghAsDev Looks good for the most part. We just need to figure out what to do with unsubscribe. We could have unsubscribe(Pattern) or unsubscribe(), or no unsubscribe at all. If the latter, then we could  have either subscribe(topic) or subscribe(pattern) always override the previous subscription, which would make subscribe(Collections.emptyList) always have the same effect as unsubscribe(). @guozhangwang Do you have any thoughts?

LGTM.
About unsubscribing, I think it is useful to keep the unsubscribe() to unsubscribe any topic / partition / pattern instead of keeping a unsubscribe(Pattern) since we will only have one pattern subscribed at the same time.

@hachikuji @guozhangwang changed the behavior of unsubscribe. Up for your reviews again :)

@SinghAsDev I just created a ticket for removing the consumer instance from the callback. You can create a ticket for the other issue if you want.

@hachikuji I have created KAFKA-2533, will create PR shortly.


Recording

I've had telly running with Plex for the last few days, but most of the time when I record something I get only a few minutes to 40 mins of a 1 hour program. I'm not sure if this is a Plex issue or an issue with telly. I'm guessing the signal gets cut and telly or Plex doesn't recover and simply ends the recording.

Could also be related to #44 maybe?

Indeed, I think it’s because of #44. You can try building from the feat-ssdp branch and see if that fixes your issue.

Closing since no feedback.


add client key from env or file

add client key from env or file

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Consider changing db cleanup stdout text to something less heart-attacky

Not to be too picky but it gave me a bit of a jolt. Perhaps:
 [*] Deleting existing <orgname> organization from database...

Haha! I see what you mean. I'm actually thinking about removing the automatic deletion of old organization checks completely, as it is really slow at the moment if the org is big.

:+1: Sounds good, thanks.


externally tagged enums not correctly parsed in 0.9.25

Hi,
I hope I'm not missing something obvious, since I'm still new to Rust, but I've found the current version of serde_yaml to not behave as per the docs for untagged enums parsing, whereas reverting to 0.8 does comply to the docs.
Here is some code:
#![allow(dead_code)]
use serde::Deserialize;

#[derive(Deserialize,Debug)]
#[serde(rename_all ="snake_case")]
enum Message {
    Request { id: String, method: String },
    Response { id: String, result: String },
}
fn main() {
    let yaml = r#"
    - request:
       id: abc
       method: abc
    - response:
       id: abc
       result: abc
        "#;

    dbg!(serde_yaml::from_str::<Vec<Message>>(yaml).unwrap());
}

According to the Serde docs, this complies with the default way of tagging enums, the externally tagged way. With serde_yaml 0.8, this works fine. With 0.9.25, the current published version, this fails with:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(".[0]: invalid type: map, expected a YAML tag starting with '!'", line: 2, column: 7)', src/main.rs:21:53

This is the dependencies section in Cargo.toml:
[dependencies]
serde = { version = "1.0.186", features = ["derive"] }
serde_yaml =  "0.9.25"

Switching from external tagging to internally tagged removes the error, however the style of the resulting Yaml is less ideal for my use case.
Again, if this is not a bug but a me-issue, I apologize, and will be thankful for a quick clarification! I've been assuming that the serde docs are up to date and therefore my example should work.
Pierric.

Externally tagged enums use YAML's tag syntax. See:

https://docs.rs/serde_yaml/latest/serde_yaml/#using-serde-derive
https://github.com/dtolnay/serde-yaml/releases/tag/0.9.0

This should work:
- !Request
  id: abc
  method: abc
- !Response
  id: abc
  result: abc

Hi,
Thank you for your reply. I understand the YAML specs might have led to that decision, and it makes sense to implement what the specs say.
However, I wonder if this is the best move given how Yaml is used in many places in real life. Many projects rely on the "JSON-style singleton maps" rather than the !Tag format:

significantly, this is how Ansible files work, e.g.:

- copy:
    src: /here
    dest: /there
    mode: 0644
- docker_container:
    name: mycontainer
    status: started
...

many, many projects, from small to big, use Yaml for configuration files. A reason for that is likely to be that it's a rather human-friendly way of managing deep data structures. The !Tag approach is, in my opinion, less intuitive and less human-friendly than the singleton maps.

It seems to me that there is lost potential for future projects with this strict adherence to the !Tag concept. I wonder if those things could co-exist, with at least the ability to still deserialize from the singleton maps, even if serialization then defaults back to the official way. Or, if the style (!Tag or singleton map) could be an option in the structs with something like #[serde(tagged_as_map)] (or whichever wording is more fitting). Could that be considered? Otherwise I'm worried we'll need an extra library for deserializing this (albeit informal) style of Yaml.
Thanks,
Pierric.

@Pierric82 these things can co-exist. If using serde derive, you can tag the relevant field with #[serde(with = "serde_yaml::with::singleton_map")]. See https://docs.rs/serde_yaml/0.9.25/serde_yaml/with/singleton_map/index.html for an example.

Hi @astraw ,
Thanks for making that clear, I was not aware of it. I've looked it up a bit and for my needs, singleton_map_recursive did the job!
Regards,
Pierric.

I feel this needs more documentation...
I was trying to parse a vector of singleton maps like this:
- enumVarientA: some text
- enumVarientB: some other text
...

The solution didn't seem obvious, so here is how I resolved it, in case someone needs it in the future:
#[derive(Serialize, Deserialize)]
#[serde(transparent, bound = "F: Serialize + DeserializeOwned")]
pub struct Wrapper<F>(
    #[serde(with = "serde_yaml::with::singleton_map")]
    pub F,
);
pub type ItemList = Vec<Wrapper<Item>>;


Markov Chain Monte Carlo.

#1559

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request

@pankaj-bind please merged this pull request


Get-AtpPolicyForO365 no longer returns this output

Get-AtpPolicyForO365 no longer returns this output. It only returns BlockUrls settings. Some can be found in Get-SafelinksPolicy, but parameter "EnableSafeLinksForO365Clients" is no longer existing I think

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5f078ade-1f5b-ca3f-190a-8182a4f3d155
Version Independent ID: 2556b079-c975-79f7-bad0-44ba3fc18ed5
Content: Configure global settings for Safe Links settings in Defender for Office 365 - Office 365
Content Source: microsoft-365/security/office-365-security/configure-global-settings-for-safe-links.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@itrdahan, fixed.
Thanks for the feedback.
Closing


Setting an initial zoom level on instantiation

Hello!
Thanks so much for the wonderful plugin. I was wondering what the recommended way to set the initial zoom level when creating the cropper?
I have tried the following with no luck:
      var element = $('div.image-container > img');
      element.cropper({
          checkImageOrigin: false,
          background: false,
          center: false,
          movable: false,
          rotatable: false,
          zoomable: true,
          mouseWheelZoom: false,
          touchDragZoom: false,
          autoCropArea: .90,
          dragCrop: false,
          scalable: false,
          minContainerWidth: 50,
          minContainerHeight: 50,
          autoCrop: false,
          built: function() {
              console.log('built cropper');
              $(this).cropper('crop');
          }
      });
      element.on('built.cropper', function(e) {
          console.log('cropper built - event fired');
          $(this).cropper('zoom', .45);
      });

I see the events firing in succession, but the zoom doesn't seem to take effect. Is there something I'm missing?

you no need check the event built.
try it:
element.cropper('zoom', .45);

You can try the zoomTo method with v2.0.0 now:
$().cropper({
  built: function () {
    $(this).cropper('zoomTo', 1); // 100%
  }
});


Rules for enabling create with map but not update

I'm trying to create rules that allow an admin to write multiple entries to a map on different occasions. These entries should never be updated. I want the user to be able to read them and then delete them individually.
With the rules below admin can write once to the map but further writes I get permission denied.
It makes sense that the additional writes get permission denied. I guess what I'm asking is what is the appropriate data type/path that allows wildcarded $uid and wildcarded $requestID.
path /user/responses/{$uid} is Map<RequestID, QueueResponse> {
  read()     { isCurrentUser($uid) }
  create()    { isAdmin()}
  delete()    { isCurrentUser($uid) }
}

Should I be doing something like this?
path /user/responses/{$uid}
    /{$requestID} is QueueResponse {
     read()     { isCurrentUser($uid) }
     create()    { isAdmin()}
     delete()    { isCurrentUser($uid) }
  }
}

Since version 3.0 debugging this is further complicated because there is no way to encode a debug flag into the admin token, we are now using service accounts. I have seen a few posts on SO and the like suggesting firebase.database.enableLogging(true) but this is not the same. It does not print failure reason.

Both of your examples look equivalent to me.  The only reason to use the Map<> form would be to ensure some type checking on the key string (RequestID) - if it's just any String, there is no need.
I think you said you don't want to allow the data to change once written (only deleted).  That's what your rules are doing.  If you want the adminto be able to update a value as well you can add
  update() { isAdmin() }

to your rules.
FYI - you can evaluate these two in Bolt:
path /user/responses/{$uid} is Map<String, Number> {
  read()     { isCurrentUser($uid) }
  create()    { isAdmin()}
  delete()    { isCurrentUser($uid) }
}

path /user/responses2/{$uid}/{$requestID} is Number {
     read()     { isCurrentUser($uid) }
     create()    { isAdmin()}
     delete()    { isCurrentUser($uid) }
  }

isCurrentUser(uid) { auth.uid == uid }
isAdmin() { auth.admin }

which produces rules which have the same effect:
{
  "rules": {
    "user": {
      "responses": {
        "$uid": {
          "$key1": {
            ".validate": "newData.isNumber()"
          },
          ".write": "data.val() == null && auth.admin || data.val() != null && newData.val() == null && auth.uid == $uid",
          ".read": "auth.uid == $uid"
        }
      },
      "responses2": {
        "$uid": {
          "$requestID": {
            ".validate": "newData.isNumber()",
            ".write": "data.val() == null && auth.admin || data.val() != null && newData.val() == null && auth.uid == $uid",
            ".read": "auth.uid == $uid"
          }
        }
      }
    }
  }
}


Is autolocks groups working?

Hey hey.
Is the autoLockGroups settings work for you? I tried to clone your project and test it and it doesn't seem to work. Am I missing something? Can you please help me?

Yeah, when I release this, things need a documentation since the configuration is a bit tricky.

"workbench.editor.autoLockGroups": {
    "mainThreadWebview-MarkdownNote": true,

    "default": false,
    "workbench.editorinputs.searchEditorInput": false,
    "jupyter-notebook": false,
    "imagePreview.previewEditor": false,
    "vscode.audioPreview": false,
    "vscode.videoPreview": false,
    "jsProfileVisualizer.cpuprofile.table": false,
    "jsProfileVisualizer.heapprofile.table": false,
    "terminalEditor": true,
    "workbench.input.interactive": false,
    "mainThreadWebview-markdown.preview": false
},

You need to add
 "mainThreadWebview-MarkdownNote": true,
manually because there is no way to do this programatically from the extensions.
I observe you have joined the issue
https://github.com/microsoft/vscode/issues/125791
and yes, it works but I have changed the ID from showNote to MarkdownNote because the old ID is too common.

Thanks, That's what I'am missing then. I thought it will automatically add it. Thanks for your help

NP, by the way, I will "reload" this repository soon, for publishing as ver. 1.0.0


Consumes and produces media-types defined on Docket are incorrectly merged together with consumes/produces media-types that are defined on a resource level

Springfox version: 2.7.0
Issue type: Bug report.
Repo that reproduces the bug: https://github.com/mzeijen/springfox-mediatype-override-bug
See the README.md for more info on how to reproduce it.
Description:
When you define the produces and/or consumes media-types on a Docket level then these media-types aren't overwritten by media-types defined on a resource level but they are merged together.
The demo app demonstrates this behaviour, but below you can see the Swagger specification I get and what I expect when defining the produces and consumes on a Docket level and try to override them by setting the produces and consumes on the @RequestMapping annotation of the controller method.
actual-swagger-spec.json
expected-swagger-spec.json
Possible problem location:
The springfox.documentation.spi.service.contexts.OperationContext contains the methods consumes and produces. These use a Sets.union to merge the requestContext and documentationContext produces/consumes together. I believe this should not merge these together and only use the produces or consumes from the requestContext.
The MediaTypeReader then needs to be fixed that it doesn't add the default values if document global consumes and produces are defined.
I will try this myself and will try to create a pull request for this.

thank you for the detailed bug report! @mzeijen

@mzeijen thank you for helping out with this issue! 🙇

Awesome that you merged the pull request. Thx.
When do you expect a new release?

So how does one now use a 'merging' produces option? (global + method level)? This seems like a valid use case when using the content negotiating view resolver. Also when using 'application content types' ie:
@GetRequest(value = "test", produces = "application/vnd.ns.test.v1+json"}
Test getTest() throws Exception {
  throw new Exception("not an 'application/vnd.ns.test.v1'");
}

In this case spring correctly the produces and error payload in json with the content type "application/json" it would be good to have this recognized in the docs via the use of the 'merging global produces' docket builder.

Dont think its related to this library as much as it is how spring handles the example usecae

Dont think its related to this library as much as it is how spring handles the example usecae

This is all regarding the swagger ui interface dropdown for requested 'accept-types'. (it should allow for merging a globally registered response type registered in the docket ie for a spring boot app:
    // Spring webs default exception handlers
    // @see org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler
    var globalResponses = Stream.of(
        HttpStatus.METHOD_NOT_ALLOWED,
        HttpStatus.UNSUPPORTED_MEDIA_TYPE,
        HttpStatus.NOT_ACCEPTABLE,
        HttpStatus.INTERNAL_SERVER_ERROR,
        HttpStatus.BAD_REQUEST,
        HttpStatus.NOT_FOUND,
        HttpStatus.SERVICE_UNAVAILABLE)
        .map(httpStatus -> new ResponseMessageBuilder()
            .code(httpStatus.value())
            .message(httpStatus.getReasonPhrase())
            .responseModel(errorResponse)
            .build())
        .collect(Collectors.toList());

    // TODO register global producer for 'application/json' instead of having them explicitly declared on all handlers
    //      https://github.com/springfox/springfox/issues/1916
    return new Docket(DocumentationType.SWAGGER_2)
        // Include global result types (@ControllerAdvice changes need to be propagated here).
        .additionalModels(typeResolver.resolve(ErrorResponse.class))
        .genericModelSubstitutes(Mono.class, Flux.class)
        .globalResponseMessage(RequestMethod.HEAD, globalResponses)
        .globalResponseMessage(RequestMethod.GET, globalResponses)
        .globalResponseMessage(RequestMethod.PUT, globalResponses)
        .globalResponseMessage(RequestMethod.POST, globalResponses)
        .globalResponseMessage(RequestMethod.PATCH, globalResponses)
        .globalResponseMessage(RequestMethod.DELETE, globalResponses)
...

This should merge both globally registered and locally specified 'produce' types (or provide the option to explicitly merge or override)

@bjconlan-fc I don't follow your example. There is no media type specified to influence produces. The docket allows for you to specify a global set via docket.produces and individual APIs can specify specific media types and it will be merged

@dilipkrish the .produces(Sets.newHashSet("application/json")) was ommited from the example because it does nothing (ie doesn't merge just becomes overwritten since said bug was 'fixed'). So if I were to introduce it an annotated the appropriate controller method with a produces this 'global' produces isn't merged it gets overwritten (so the workaround is to explicitly specify both on the handler method which isn't exactly the correct place to handle random side effects that happen at a global level.
Basically the use case Identified by this ticket isn't the use case used in my case. And perhaps a strategy for merging over overwriting globally registered 'produces' should be facilitated.


Adding support for tf.sigmoid_cross_entropy_with_logits and tf.where

Addressing #127.

Hopefully fixed. I did a mistake in not realizing that this PR needed MathTests.cs which was originally included in #118 and therefore should had been based on top of that commit and not on TF# master.

Sync'ed with master, sorry for the mishap.


Add detailed mod info view

Closes #83.

Nice! Couple things:

Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

Nice! Couple things:

Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

It's just that the current logic to handle the details window only correctly supports showing one mod detail at a time.

There is a major issue when resizing the details window as demonstrated in the video below:
https://github.com/trumank/drg-mod-integration/assets/84156063/2b7a438e-04a7-4824-a343-7a0710b02b03
There is also a fair bit of lag when moving the window around, though it's quite a minor thing and I wouldn't at all be bothered if it cannot be fixed easily.
Furthermore, basic markdown support would be nice. I know it's not in egui but I found this extension crate for it that kind of does it.

That looks like egui issue which I have no clue how to fix.


[FEATURE] Support session token in OpenSearch SQL CLI

Is your feature request related to a problem?
Currently, OpenSearch SQL CLI only support access_key and secret_key. https://github.com/opensearch-project/sql/blob/main/sql-cli/src/opensearch_sql_cli/opensearch_connection.py#L61
What solution would you like?
OpenSearch SQL CLI should support session token. https://pypi.org/project/requests-aws4auth/

this is a cli release, not part of the distribution


Correct silly space

:trollface:

Coverage remained the same at 99.48% when pulling a0673f2c84ccb2f71b0a66b58eb7e27535987b60 on fix/silly-space into 9418acb5333d70acf7482c67211fbf1a97a371fa on master.

Coverage remained the same at 99.48% when pulling a0673f2c84ccb2f71b0a66b58eb7e27535987b60 on fix/silly-space into 9418acb5333d70acf7482c67211fbf1a97a371fa on master.

:trophy:

No test case for a change? :trollface:

I suppose test coverage kinda improved in this case.

Although test coverage is line-based (or rather; statement-based), but whatever.

Test coverage remained the same since it's a code sample in the README, not a source file :wink:

Oh! Right. LOL.

:dancers:


Idea: Use Rollup instead of Parcel?

What is wrong?

Where does it happen?

How do we replicate the issue?

How important is this (1-5)?

Expected behavior (i.e. solution)

Other Comments
Rollup is a bundler not unlike Parcel, but much more powerful (IMO). It can generate ES6 Modules (for webpack & environments that support them) and UMD files (which work in browsers and Node.js require()) with a single command.
So let's say we generate brain.mjs and brain.js. After that, use the following in package.json:
"main": "./dist/brain.js",
"browser": "./dist/brain.min.js",
"module": "./dist/brain.mjs"

Webpack, Rollup, and Parcel will automatically use brain.mjs. Node.js will automatically use brain.js (unless experimental modules is active). Web browsers can keep using brain.min.js.
Rollup almost always produces smaller bundles than Webpack or Parcel. And bower could be removed.
I'm willing to work on porting to Rollup by myself; I just want to know if the maintainers are willing to use it.

I do use. Rollup.js and I like it. Currently we so support all npm fields except esm support.  Imho, configuring rollup builds are also easier.
So yeah, go ahead.

It might be a good idea to asses gpu.js as well, so that we get as small of a build as possible.

I do want to use some caution with regard to building node files.  We are currently developing with node and there is something beautiful about changing tons of stuff, and clicking a play button and it just work.
There are, however, caution(s) to be had when working with transpilers such as GPU.js, or transpiler outputs, via babel, which are disgusting (yes, Babel guys, I hope you are reading), to other transpilers, like GPU.js, which are beautiful, (shameless plug...
###...but I've got the unit tests to prove it!
!()[https://media3.giphy.com/media/3o6UBdd79rm7vxtOSs/giphy.gif]
But, in their defense, we're working with a subset of javascript rather than... ALL of it, but I will not take back the rant!)
...that turn javascript into GPU code.  There are side effects at times, many of which are handled in GPU.js, BUT we can only go so far, as the garbage that most transpilers output simply violate the laws of all things sacred... and that can be detected and ran on the GPU.
That being said, although es6 is nice (specifically imports and exports) if that is all we're (and we just removed them) working towards, I'm not sold, as it just waists time.
Our current build system needs to be evaluated as well, as there may be side effects with it, it is just that transpilers specifically, and specifically the ones in babel, are the ones that have given me the most trouble.

Also, I do want to clarify, the people who work on Babel do some amazing stuff, and I'm in no way saying their work is bad, I'm just saying that their transpilation output generally violates beautiful code, and rules of what will run on a GPU from javascript.

You have raised very good point indeed. We can take some very good points from current build scripts of gpu.js. (Like that how it build for browser skipping the gl dependency)
On the other hand, I am in favor of babel as it is a good tool to make your code compatible with all of the current generation browsers. The issue is with the configuration, we have to skip or avoid gpu.js parsing through babel and all our problems should solve. (I think so?)
So all in all this is how things should work in my humble opinion:

don't parse gpu.js code through babel to avoid code conversion issues
maybe: upgrade gpu.js build scripts to roll.js as well for similar configuration between brain.js and gpu.js
skip gl dependency from both build scripts
for node.js target we have to choices that will effect how we develop current code
4.1. develop the script using latest technologies, which will aid in development and off-course could help in better code management. Then we build it for node.js using gl as external dependency and skipping gpu.js from babel transpiling. This will give much better node.js versions support and better development support but will require building for each release, not much hassle since we can use github actions for that. (we are also building for browsers though)
4.2. Develop the script using features fully supported in node.js LTS release. This will require us to make sure code we are developing is tested in same node.js as expected and does not use any latest feature not supported by LTS.
Add github actions for build release to make sure we have  build scripts updated to github repo and npm with tags.

@Symbitic for information please

I'll see what I can do. And I'll try to make it as incremental as possible, so as to avoid breaking things.
Not sure Babel really needs to come into the picture at this point. That can be added later, AFTER Rollup is working. Rollups only job is to bundle multiple input files into an output file, in one of several formats (ESM, CJS, UMD, etc).
I'm not sure how long this will take me. I'll need to take a look at GPU.js first before I can really get started on this. But I've got several ideas. I'm fairly confident I can get this working.

Please check this config as a starting point: https://github.com/mubaidr/Javascript-Barcode-Reader/blob/master/rollup.config.js

I got started working on GPU.js first.
First version is working! Check out my work at https://github.com/Symbitic/gpu.js
I want several people to review it before I actually create a merge request.
Some of my changes:

I had to HEAVILY refactor almost every file to use ES6 Modules instead of CommonJS. Speaking of which:
Circular dependencies are an abomination from Hell! I had to refactor a lot of files to remove it. I also had to remove the two functions in utils.js that used the GPU class. IT JUST COULDNT BE DONE! Besides, it didn't look like anyone or anything was actually using them. Plenty of other refactors were necessary.
HeadlessGL is not included in browser builds. It was just too much effort, it resulted in big bloaty files, and it can't be used anyway. I might add a stub class for the browser build though.
I wasn't able to get js-beautify working yet. Will you please consider using prettier or something else instead?

Not all tests are working yet. I think most of the errors have to do with Array1D, Array2D and so forth. Feel free to run the tests and make suggestions.

@Symbitic Any progress here?

I actually made quite a bit a little while ago, but all the commits since then make it a little difficult to update and merge. I will try soon, if I have time.


eloquent query for datatable not working

Hello,
I am using laravel 5.4 and yajra/datatable 7. When i writing code as below to get data:
public function datatablecountry(){
	$query = Country::select(['countryname','countrystatus']);

	return Datatables::of($query)->make(true);

}`

than it throws
Unknown column 'Country' in 'order clause' (SQL: select `countryname`, `countrystatus` from country order by `Country` asc limit 10 offset 0)

But i am not using Country column in my table so from where it will be loaded?

How did you declare your js columns? Make sure the correct column name was used.
columns: [
  {data: 'countryname'},
  {data: 'countrystatus'},
]


[Bug]: Make the privacy policy page responsive for mobile screen

Description
I would like to work on this

I want to make this responsive. Please assign this to me under gssoc'23 @Vaishnavi-Patil2211
Expected Behavior

Show us the trouble with screenshots

Which browsers are affected?
No response
Which OS are affected?
No response
Enter the version of your web browser

Device?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Even on correcting the address the vs code directs to right place and on your website too.. But I can't understand what's the error here that it is showing cannot get path. Can you please help me in this out @Vaishnavi-Patil2211 ?

@Vaishnavi-Patil2211 please check #1207


[ENG-61] change to flavor option format

before this change, the flavor option provides a --flavor key value format.
but the source option in the record build command provides a --source repo=name format.
IOW, the source option already supports a key=value style.
so I changed to keep the key=value format

nargs=-1 is only supported custom attribute so I can't use it to a custom type.
so I defined KeyValueType for the click option and use it.
https://github.com/launchableinc/cli/pull/191/files#diff-739a2fcee2511af52af764b3a3bf8dcc9f26ff0dfc754f4996c8867092797634R51

@ninjinkun I fixed so, could you review again?

Basically, it's awesome! I left one comment.


Replace inspect.getargspec()

A new inspection was created.

The inspection completed: No new issues

A new inspection was created.

The inspection completed: No new issues

A new inspection was created.

The inspection completed: No new issues

A new inspection was created.

The inspection completed: No new issues


Error on indexDB first startup

Hello guys,
I'am having the same problem as this guy:
http://stackoverflow.com/questions/26843311/after-clearing-cache-and-localforage-indexeddb-getting-an-error-on-loading-the
But I found no answer.
After clearing the indexedDB storage, and starting the app normally, it fails with the following:

The line referenced is:

My code is only opening the instance and trying to get an item:

And then...

After a refresh, it runs normally.
I am using localforage 1.3.1 no promises.
Thanks!!

Anyone else experiencing this issue?
Thanks!

@TCMiranda I can reproduce this error too with Chrome.
In FF, the error message is a bit different:
InvalidStateError: A mutation operation was attempted on a database that did not allow mutations.

But the reason is the same, and I think I have figured out it.
I will commit a PR very soon to expose the problem and fix it.

I am getting the same error in FF. Whats the status of this issue?
InvalidStateError: A mutation operation was attempted on a database that did not allow mutations.
var transaction = dbInfo.db.transaction(dbInfo.storeName, 'readwrite');
localforage.js (line 1608)

line 1608:
	                return value;
	            }).then(function (value) {
	                var transaction = dbInfo.db.transaction(dbInfo.storeName, 'readwrite');  //1608
	                var store = transaction.objectStore(dbInfo.storeName);

The PR has been merged but I need to release a new version of localForage. I'll do that today and report back when it's available.

Fixed and released in 7ca5b0bb64c2f07b109779622e2a018842c43aa0 and on npm. Cheers!

Hi @tofumatt,
The problem at start up appears to be solved, but the rest stopped working for me, getItem and setItem not resolving.
I read some of the tests used and tried to solve my problem setting the driver and waiting for ready callback, but nothing happened.. The problem is that I am not getting any errors or warnings..
Nobody is experiencing this issue?
Thanks for your support!

All the tests pass—do you mean getItem/setItem aren’t EVER resolving or just in this specific error case?

Yes, they are never resolving... Chome 48 with IndexedDB and Webpack

I have created a new PR which should do the trick this time (with a dedicated test).

I think, I've hit the same problem as TCMiranda.
When are you releasing the next version (incl patch above)?

I should be able to release it today, probably in a few hours :)

Only to close this subject... 1.3.3 release fixed the issue for me!
Thanks for the support!

hi, i've been used localForage for almost one year. but its happen one time and its not working until  clearing local db.
we are using 1.4.0 version.


Change secp256k1 and test library

Closes #696

futoin-hkdf can also be replaced with @noble/hashes/hkdf


[WIP, don't merge] Option refurbish

Names I'm unsure about:

flatMap vs andThen
and_ vs then_
flatten vs join
zip vs both
make vs return (it's really just an alias for Some _ and make seems too general for monads like result with multiple type vars)
get as an alias for getOr without argument label
maybe as alias for mapOr without argument label
getOrRaise vs getExn or similar
okOr vs toResult
reduce vs fold. Some libraries seem to have both, where fold does not take an initial value but instead raises an exception on None. So reduce seems slightly more correct, and is of course much more familiar to js devs.

I'm still unsure about the naming convention used, there are no tests yet, and the docs are pretty half-baked. But feedback on what's there is appreciated nonetheless :)

@bordoley Isn't that just map2?

Ah i didn't realized you had both.

@dorafmon I've now added tests, so this should be good to merge if you approve. I'm still unsure about the naming though.
I've also tweaked the test setup to be a bit more convenient to use.

Cool, I use tmux myself but I never tried screen.

I couldn't figure out how to get tmux to do what I wanted, but with screen it was easy, just needed the .screenrc


Significant slowdown in Keras model.fit() on simple problem when using validation data

System information.

Have I written custom code:  No
OS Platform and Distribution:  Ubuntu 18.04
TensorFlow installed from:  Binary
TensorFlow version:  2.11.0
Python version:  3.10.8
Bazel version:  N/A
GPU model and memory:  NVIDIA Quadro GV100 (32 GB)
Exact command to reproduce:  See below.

Describe the problem.
Per instructions I received from @mohantym, this is a cross-post to this
repository of the issue tensorflow/tensorflow#58828, which I opened yesterday.
The issue documents a significant slowdown in training speed when using Keras
model.fit() with the validation_data parameter set.  On my hardware, I see a
slowdown of approximately 10x.  On Colab, @mohantym sees a slowdown of only
3.5x, but this still seems excessive to me given that the validation data is
only 1/8 the size of the training data.  I would not expect it to take 3.5x
time to process 12.5% more data per epoch.
(In fact, I see the same slowdown even if I reduce the validation set size to a
single example, so it's a 3.5x to 10x speed penalty for an 0.05% increase in
the amount of data to be processed.)
For further details, including code that can be used to reproduce the problem,
please see the aforementioned issue.
Describe the current behavior.
A 3.5x-10x slowdown during training using model.fit() with validation_data set.
Describe the expected behavior.
Some slowdown (validation isn't free)---but a whole lot less than 3.5x-10x.
Standalone code to reproduce the issue.
See the aforementioned issue.
Source code / logs.
See the aforementioned issue.

@aaustin141 Could you refer to this thread and let us know if it helps?
Thank you!

Hi @aaustin141 ,
Since Evaluation happens at the end of each epoch when we provide validation_split to model.fit() there will be some extra time overhead for this operation.Since the model you tested is very small and time consumption also very little the difference seems huge.However this difference in time will reduce with larger models.The same model mentioned by you in #58828 I tried with 1000 epochs and time taken with and without validation is 40.87 to 20.52 Seconds respectively which is 2X compared to 3.75X earlier .Same model if Eager mode disabled by using tf.compat.v1.disable_eager_execution() then time taken is 17.67 and 12.62 Sec respectively where the difference is very less.I believe this difference may come down with larger models with large training time. but AFAIK there is no such metrics to confirm whether validation_split should take only this much time.  Please refer to attached gist.
Could you please confirm whether you are facing this issue with any of your specific model and if so can you confirm the training time details for it ?
Thank you!


DRILL-7111: Fix table function execution for directories

Jira - DRILL-7111.

@vvysotskyi please review.


Added link for YouTube version

Added additional resource section and link to youtube version.
Fixes #13467

@Rick-Anderson ,  how do you want little ones like this to work for review?  Should I always assign someone such as you, or just squash and merge after I verify in review build?  Not sure what the flow should be for these.

For trivial changes like this, just S&M

Got it!  Thanks!


r2.4-rc1 cherry-pick request: [Intel MKL] Prevent unnecessary copies of oneDNN in .so files.

Original PR: #44629
oneDNN was getting statically linked to all the .so created by TF, thereby increasing the installation significantly. Removed redundant dependencies of oneDNN. Also, in a few places the dependency was only with libiomp.so and not oneDNN, made appropriate changes to address it.

Manually setting CLA to yes because this PR is cherry-picking an already merged PR #44629.

Thanks a lot @penpornk for quick response.


Bundle gcloud

Not happening anytime soon, but I would like to remove the dependency on a locally installed gcloud SDK. I.e. we should bundle gcloud directly into the plug-in and use that if a more recent one is not available locally.

Will it be downloaded on demand? Like users can install GWT and App Engine SDK from an update site for GPE.

https://github.com/GoogleCloudPlatform/appengine-plugins-core/issues/246


Request support for Meaco Arete Two 10L

Log message
This error originated from a custom integration.

Logger: custom_components.tuya_local.config_flow
Source: custom_components/tuya_local/config_flow.py:483
integration: Tuya Local (documentation, issues)
First occurred: 19:29:03 (1 occurrences)
Last logged: 19:29:03

Device matches eeese_carl_dehumidifier with quality of 88%. DPS: {"updated_at":<PHONE_NUMBER>.685964, "1": false, "2": 50, "4": "manual", "14": false, "16": 73, "17": "cancel", "19": 128, "101": "Cancel"}

DPS information
[
    {
        "name": "Arete\u00ae Two 10L Dehumidifier/Air Purifier",
        "id": "xxx",
        "key": "xxx",
        "mac": "xxx",
        "uuid": "xxx",
        "sn": "xxx",
        "category": "cs",
        "product_name": "Arete\u00ae Two 10L Dehumidifier/Air Purifier",
        "product_id": "hrqj115cek0tuddi",
        "biz_type": 18,
        "model": "MeacoDryArete2-10L",
        "sub": false,
        "icon": "https://images.tuyaeu.com/smart/icon/bay1607951018151O5oo/94326fea782fb94b3fba3e819397a794.jpg",
        "mapping": {
            "1": {
                "code": "switch",
                "type": "Boolean",
                "values": {}
            },
            "2": {
                "code": "dehumidify_set_value",
                "type": "Integer",
                "values": {
                    "unit": "%",
                    "min": 35,
                    "max": 70,
                    "scale": 0,
                    "step": 5
                }
            },
            "4": {
                "code": "mode",
                "type": "Enum",
                "values": {
                    "range": [
                        "manual",
                        "laundry",
                        "sleep",
                        "purify"
                    ]
                }
            },
            "14": {
                "code": "child_lock",
                "type": "Boolean",
                "values": {}
            },
            "16": {
                "code": "humidity_indoor",
                "type": "Integer",
                "values": {
                    "unit": "%",
                    "min": 0,
                    "max": 100,
                    "scale": 0,
                    "step": 1
                }
            },
            "17": {
                "code": "countdown_set",
                "type": "Enum",
                "values": {
                    "range": [
                        "cancel",
                        "1h",
                        "2h",
                        "3h",
                        "4h",
                        "5h",
                        "6h",
                        "7h",
                        "8h",
                        "9h",
                        "10h",
                        "11h",
                        "12h",
                        "13h",
                        "14h",
                        "15h",
                        "16h",
                        "17h",
                        "18h",
                        "19h",
                        "20h",
                        "21h",
                        "22h",
                        "23h",
                        "24h"
                    ]
                }
            },
            "18": {
                "code": "countdown_left",
                "type": "Integer",
                "values": {
                    "unit": "h",
                    "min": 0,
                    "max": 24,
                    "scale": 0,
                    "step": 1
                }
            },
            "19": {
                "code": "fault",
                "type": "Bitmap",
                "values": {
                    "label": [
                        "tankfull",
                        "defrost",
                        "E1",
                        "E2",
                        "L2",
                        "L3",
                        "L4",
                        "wet"
                    ],
                    "maxlen": 8
                }
            },
            "101": {
                "code": "ontimer",
                "type": "Enum",
                "values": {
                    "range": [
                        "Cancel",
                        "1h",
                        "2h",
                        "3h",
                        "4h",
                        "5h",
                        "6h",
                        "7h",
                        "8h",
                        "9h",
                        "10h",
                        "11h",
                        "12h",
                        "13h",
                        "14h",
                        "15h",
                        "16h",
                        "17h",
                        "18h",
                        "19h",
                        "20h",
                        "21h",
                        "22h",
                        "23h",
                        "24h"
                    ]
                }
            }
        },
        "ip": "xxx",
        "version": "3.3"
    }
]

Product ID
hrqj115cek0tuddi
Product Name
Meaco Arete Two 10L
Information about how the device functions
The device is a dehumidifier: https://www.meaco.de/luftentfeuchter-meaco-arete-two-10-l/
I tried to add the device on my own: https://github.com/flocke/tuya-local/blob/main/custom_components/tuya_local/devices/meaco_arete_two_dehumidifier.yaml
But it does not work, it is not included in the list of suggested configurations for my device.

Feel free to send me any yaml file for testing. I can just drop it in my custom_components folder to test it.

Can confirm it works with my Meaco Arete Two 25L.
thx for adding!

Can confirm it works with my Meaco Arete Two 25L. thx for adding!

@dn-hx i just tried mine i get Missing device configuration what did you do to make it work?

Can confirm, it also works with my 10L model.
@electricfire I did not need to do anything special to make it work. I added it locally, using the ID and key, not via the cloud setup.

Can confirm, it also works with my 10L model.
@electricfire I did not need to do anything special to make it work. I added it locally, using the ID and key, not via the cloud setup.

Thakns for confirming but i am doing the same but i get the following:
This error originated from a custom integration.
Logger: custom_components.localtuya.common
Source: custom_components/localtuya/common.py:130
integration: LocalTuya (documentation, issues)
First occurred: 7:00:16 PM (55 occurrences)
Last logged: 7:04:46 PM
Missing device configuration for device_id bfa66a1e115edc27

This repository is for a different integration. It is not appropriate to discuss problems with localtuya here.

This repository is for a different integration. It is not appropriate to discuss problems with localtuya here.

Apologies, I had not noticed that, however I have now used your integration and can also confirm that it works now many thanks

@flocke apologies to ping on a semi unrelated thing. But when you say

I added it locally, using the ID and key, not via the cloud setup.

What does this mean? Can you add it without having to go through the Tuya dev platform setup etc. How do you get the local key without the Cloud setup?

The cloud assisted setup does not require a dev account.

@cdloh Since I already had the device ID and local key from my research, I used the manual setup when adding the device in Home Assistant:


Pairing Kana game allows the same script to be picked twice

Hello!
I have found this project via Hacktoberfest. I'm a Japanese language learner and I really like the idea of learning by games.
Regarding the issue, it is possible to pick romaji and romaji (or hiragana and hiragana, or katakana and katakana) in the Pairing Kana game.
Doing it results in this:

I think that the easiest solution is to simply prevent the user from starting the game in this situation. Can I have this issue assigned to me? :)

Hello, im happy meet another japanese learner too.
sure. i will assign this issue to you.


Regex does not work with snapshot testing

Jest is amazing, thanks for all the work. I've started using snapshot testing with more than just React components and in most instances everything works perfectly.
Running version 15.1.1 with babel-jest & jest-cli. I am reporting a bug.
Steps to reproduce:

Create a test file

it('should be the same regex', () => {
  const regex = /\s+ \w \d \[ \. blah.* [xyz]+/
  expect(regex).toMatchSnapshot()
  const objectContainingRegex = {regex}
  expect(objectContainingRegex).toMatchSnapshot()
})

Run Jest (2 snapshots written in 1 test file.)
Run Jest (2 snapshot tests failed in 1 test file.)

What was expected:
Running Jest the second time should match the snapshot.
CLI output:

Snapshots:
exports[`test should be the same regex 1`] = `/\s+ \w \d \[ \. blah.* [xyz]+/`;

exports[`test should be the same regex 2`] = `
Object {
  "regex": /\s+ \w \d \[ \. blah.* [xyz]+/
}
`;

It seems like we aren't escaping regex properly. We can fix this by introducing an option to pretty-format that will escape regex.

@cpojer pretty-format already escapes regex:
pretty-format(/\s/) === '/\\s/';
pretty-format({r: /\s/}) === 'Object {\n  "r": /\\s/,\n}';

So the problem is that unescape undoes all the escaping from pretty-format:
unescape('/\\s/') === '/\s/';

// and in javascript:
'\s' === 's' === true;

@anilanar hm, are you sure? Is the original issue report not valid any more? If it is, would you mind sending a PR to fix it?

I am experiencing the same issue. What gets written to the snapshot file has backslashes. However when it is read back Jest doesn't see the backspaces anymore.

@cpojer I've just sent a PR with an option to escape regex with pretty-format. After fair amount of research on this issue (tried to fix this on a Jest level, but didn't succeed) it seems to be the sanest solution.
@anilanar so, pretty-format does not escape regex, it just transforms them to string (with RegEx.prototype.toString). While this is great for strings, when reading from a file all regex's backslashes must be escaped. Otherwise require call to this file will "swallow" them or escape the character after.

This will be fixed in the next Jest release this week.


Add files via upload

https://sortavala-school1.ru/upload/iblock/063/5rapotuyxipsz6hivu3ijxkhh5i7wuqt.pdf

@ngrgrv First stage of verification passed, official domain is sortavala-school1.ru as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Fix package dir path to support project reference from other solutions

When I open and build each samples, I faced the package restoring error in depending Libraries/ projects. The error occurred because the Libraries/ projects restore packages in their package directory, but they are not same as each sample solutions' package directory.
This PR modifies ..\packages to $(SolutionDir)\packages to fix package restoring error of each chapters.

Thanks for the PR @yfakariya
Looks like it isn't required anymore, as the projects concerned have undergone big modifications since then.


How to Stop ArangoDB server from commandline or from C# application

Killing the arangoDb process is leading to corrupt DB .. so i do not want to use windows process.Kill()
I am starting arangodb with using following code :
Process arangoDBProcess = null;
       string arangoDBPath = System.IO.Path.Combine(ApplicationArangoPath, @"usr\bin\arangod.exe");
        if (System.IO.File.Exists(arangoDBPath))
        {
            try
            {
                // Start the ng serve process using npm start
                arangoDBProcess = new Process
                {
                    StartInfo = new ProcessStartInfo
                    {
                        FileName = arangoDBPath,
                        UseShellExecute = false,
                        CreateNoWindow = true
                    }
                };
                // Start process

                arangoDBProcess.Start();

On Linux you usually send SIGTERM to the process; on Windows this is roughly equivalent to terminating a process with Ctrl-C. However, sending Ctrl-C to another process programmatically is unfortunately a bit more complex. See this blog post for an example: https://blog.codetitans.pl/post/sending-ctrl-c-signal-to-another-application-on-windows/

please note that you also can use HTTP with DELETE /_admin/shutdown to trigger a proper shutdown.
We should have it documented in the admin section, However, its only noted in the release notes


#3407 add the logic of annotation on the splicing class for all rpc shenyu client

#3407 add the logic of annotation on the splicing class for motan client;

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3408 (83d9e48) into master (80b7966) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3408      +/-   ##
============================================
- Coverage     63.55%   62.95%   -0.61%
+ Complexity     5443     5408      -35
============================================
  Files           803      803
  Lines         22524    22518       -6
  Branches       2035     2034       -1
============================================
- Hits          14316    14176     -140
- Misses         6899     7037     +138
+ Partials       1309     1305       -4

Impacted Files
Coverage Δ

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java
47.12% <0.00%> (-28.74%)
:arrow_down:

...gin/apache/dubbo/cache/ApacheDubboConfigCache.java
48.31% <0.00%> (-25.85%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
69.10% <0.00%> (-14.64%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...ng/rocketmq/rocketmq/RocketMQLogCollectClient.java
68.00% <0.00%> (-8.00%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.38% <0.00%> (-7.45%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe1018...83d9e48. Read the comment docs.

Please pull the latest code and resolve the conflict.


[bug] Hyperlinks of "Contributors" and "about us" in nav bar are not working.

Screen recording
https://github.com/OpenCodeEra/first-contribution/assets/100958893/4862f496-f6a1-4cce-8a78-9df3c1c96dc2
solution

updating the hyperlinks should fix this bug.

I want to work on this

I want to work on this

I want to work on this

@Kopal05 Go ahead!!
Mention this issue in your PR.

@Kopal05 are you still working on this ?


[Feature] add possibility to add picker to second field

Hi.
It's been a long time. I've just added as a collaborator to this library.
Why do you need this? Could you elaborate?
Thanks.


Suggestion: Show line number

Would it be possible for each token to have associated a line number from the file ?
I know that the line number is more or less impossible to keep up-to-date during the fixing, but being able to be shown the original line number of tokens fixed in the most verbose cases would be very useful.
Perhaps something like:

Lines changed: 40,41,129

you can use --diff to generate a diff, use --diff-format=udiff for the line numbers

Closing as "easy" answer was provided. Hard one would be #3601 .
Don't hesitate to continue discussion, even if thread is closed now ;)


add "monitor" option to train + learncurve

that lets user specify which metric should be monitored on validation step, e.g. accuracy, segment error rate
we want the best segment error rate possible but we only save maximum validation accuracy.
This is an issue since a model may have low segment error rate but relatively high frame error at the same time

Perhaps it is possible to add this as a hyper parameter?
Something like:
loss_weight_param = alpha [in 0-->1, default=?]
that sets the loss to be:
Loss = alpha*FrameErrorRate + (1-alpha)*SegmentErrorRate

yes, I agree that it might be useful to provide a combined / compound loss with hyperparameters that weight each of the loss terms.
You mean something like this?
https://github.com/NickleDave/vak/blob/f99ffe17ebd915b43e7f235ba5ecb127f634619e/src/vak/nn/modules/loss.py#L41
let's discuss when we meet later
but here I'm just talking about the metric that gets monitored on the validation step.
Literally the same thing as the monitor parameter for the keras.EarlyStopping callback:
https://keras.io/api/callbacks/early_stopping/

We would need to change the name of the checkpoint saved on the validation step to something more generic, e.g. checkpoint.best.pt, which would be a breaking change


Replace all doesn't replace everything

Currently when we do a replace all, it only replaces content among the currently displayed buffer and not throughout the file.
I had a file with 20000 lines and I had to change the table name, so I had to click on replace all 1000 times to make that happen

@thewhitetulip
The find widget only highlights the first 1K hits, but I am confident Replace All replaces all occurences. It is something I changed rather recently. Can you please help with additional steps -- and are you seeing this in 0.10.1 ?

yes, 0.10.1
I have a huge file, 50MB they were sql statements and i had to change the database name, i had to hit replace all 100times before it was done

Just checked again, Replace All on master replaces all find matches, regardless of the 1k decorations limit.
See https://github.com/Microsoft/vscode/blob/587854a5bcae72950da0e9412ab773933a350e6b/src/vs/editor/contrib/find/common/findModel.ts#L321

I knew some case of this issue. If you open a large file or text, you do some replacement, it needs time to finish(in my case, latest version of vs code , 200,000 cases for 20s or more, depends on the file size and your computer). Sometimes, we don't realize it‘s still running and not finished. So I think, a clear remind in  status bar is very much necessary.


bugfix: correct chart dir name in CI config

this pr:

corrects the chart dir name in the CI config
add giantswarm helper funcs and apply common labels to all resources

Changes are fine, just the title doesn't reflect them

yeah, this turned into me appeasing the CI gods so i can get the chart published - i'll update that before i close it


Peer Grading Review Ticket

What I showed my partner Jeffrey:
CPT Outline
Frontend:

Backend:
We have the data of all the videos in our code, we don't have it connected to front end yet or working with the search bar.

Jeffrey Lee's Pair Grading: .1 / .3

[x] .1 - CPT outline and relation to FE/BE code.
Derek has an established CPT plan alongside how he plans to implement both the frontend and backend code to fulfill objectives.

[ ] .1 - Frontend UI demo.   UI takes inputs and validates for garbage, data cleans and is read by JavaScript.
Derek's group has a frontend site that has frontend elements, but when presented today does not perfectly receive inputs and display outputs. Derek has told me that this is a frontend issue that can easily be fixed, therefore it should be looked at during review on Friday.

[ ] .1 - Postman API Demo.  JSON Raw/Body formatted API passes inputs to backend and receives data from database.
Derek does not have evidence of a database or API being interacted with and sent through backend/frontend yet.

[ ] .1 - UI and API work together and data is returned, displayed, and formatted in Browser.
This aspect is not shown in Derek's current project.

Extra for now, required at end of project

[ ] .1 - Class Demo - Object Creation.  Tester method that shows creation of Objects and outputs to Terminal, illustrating the ability to test change without using Full Stack.
Derek does not have evidence of object or variable creation in his backend yet.

[ ] .1 - Python Demo - Model Init.  Show the creation and population of tables with database.   This requires you to delete sqlite.db file and see if it is regenerated with all tables and test data.
While Derek has worked with sqlite tables, but there is no evidence of him creating and populating tables for his project yet.


TypeScript example

Does anyone know if there is there an example of using TypeScript with Electron and Next.js anywhere?

Nevermind, I think I found one at https://github.com/saltyshiomix/nextron


Add support for LifeCycle Event  Hooks

https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#define-poststart-and-prestop-handlers
Specifically preStop and postStart. Some of our products have in-memory state (PF), and others need some work to be done for a graceful shutdown (PA,PD).
As a start, could we just add these hooks as empty objects {} to the appropriate location for sts and deploy type workloads.

Adding following to values.yaml

    ############################################################
    # container life handlers, allowing for lifecycle events such
    # as postStart and preStop events
    #
    # https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event
    ############################################################
    lifecyle: {}
    # Example
    # lifecyle:
    #   postStart:
    #     exec:
    #       command: ["/bin/sh", "-c", "echo Start Complete > /tmp/message"]

Will push this out in Release 0.6.2


[0.20] React Native - Upgrade, Error

When trying to upgrade from 0.19 to 0.20 using react-native upgrade while I am using Node 5.6.0 I am getting this error:
~/Projects/my-app> react-native upgrade
/Users/Manos/Projects/my-app/node_modules/react-native/local-cli/bundle/buildBundle.js:17
function buildBundle(args, config, output = outputBundle) {
                                         ^
SyntaxError: Unexpected token =
   at exports.runInThisContext (vm.js:53:16)
   at Module._compile (module.js:387:25)
   at loader (/Users/Manos/Projects/my-app/node_modules/babel-register/lib/node.js:130:5)
   at Object.require.extensions.(anonymous function) [as .js] (/Users/Manos/Projects/my-app/node_modules/babel-register/lib/node.js:140:7)
   at Module.load (module.js:357:32)
   at Function.Module._load (module.js:314:12)
   at Module.require (module.js:367:17)
   at require (internal/module.js:16:19)
   at Object.<anonymous> (bundle.js:11:21)
   at Module._compile (module.js:413:34)

I double-checked and it works fine with Node 4.3.0 so I am wondering if Node 5 is supported.
Earlier today I was able to upgrade a project from 0.18.1 to 0.19 using Node 5.6.0 successfully.

Seems to be caused by 32fa0b7fa196ae83e7f65bf1836d672b58f2213c. Node 5 doesn't support default function arguments, and this code is not run through babel.
cc @davidaurelio

In the meantime you can edit your node_modules/react-native/local-cli/bundle/buildBundle.js and and replace this at line 17
function buildBundle(args, config, output = outputBundle) {

by that
function buildBundle(args, config, output) {
  output = output || outputBundle;

This code seems to be run through Babel, as the error is coming from babel-register. Probably a Babel version issue?

@satya164 Oh yes you are right I didn't think about that. This is weird it effectively looks a a problem with the babel config. The local-cli is using the react-native babel preset. Do you have a .babelrc file in your project? Also maybe try reinstalling your node_modules.

Getting the same error.
/node_modules/react-native/local-cli/bundle/buildBundle.js:17
function buildBundle(args, config, output = outputBundle) {
                                          ^

SyntaxError: Unexpected token =
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:414:25)
    at loader (/Users/qasimalbaqali/Documents/ReactJS/vloomarkt/node_modules/babel-register/lib/node.js:130:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/qasimalbaqali/Documents/ReactJS/vloomarkt/node_modules/babel-register/lib/node.js:140:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (bundle.js:11:21)
    at Module._compile (module.js:435:26)

@janicduplessis Even if I change what you suggested then the scripts crashes again a couple of lines later:
/Users/Manos/Projects/my-app/node_modules/react-native/local- cli/bundle/buildBundle.js:57
    Promise.all([clientPromise, bundlePromise]).then(([client]) => {
                                                      ^

@ekonstantinidis Try deleting the node_modules folder and running npm install again.

@satya164 Just tried again but got the same error. Were you able to upgrade using Node 5 (particularly 5.6.0)?

Is that me or this version 0.20 creates a lot of issues (horrible transitions user experience, bugs not only due to deprecated props or stuffs...) ?
Upgrading seems like not worth right now.
I will try creating from scratch to see if it goes better...

@skevy Could this be related to the babel/react-native-preset changes? The packager code is using the same babel config as the transforms, this is probably wrong as we don't want users to be able to change that and we could also optimise what transforms are run since we have a node env there vs jsc.

The thing that worked for me was deleting the node_modules folder and using npm install to install my dependencies.

@MacKentoch @ekonstantinidis Do you have a .babelrc file in the project that fails to upgrade?

@janicduplessis I event started from scratch a new project.
I got these 2 last issues in fact :

#6027
and navigator transition has now a ugly dark background for few seconds (before it was smooth staying grey - as I defined -)

///////////////////////////////////////////////////////////////
// navigator : my scene transition effect
///////////////////////////////////////////////////////////////
 configureScene={()=>Navigator.SceneConfigs.FadeAndroid}

///////////////////////////////////////////////////////////////
//each Views : before 0.20 it was a smooth fadeIn effect when component mounted
///////////////////////////////////////////////////////////////
// I wait all is ok to render my view (I set this.state.isReady)
  componentDidMount() {
    // to delay display heavy content and display a loading
    InteractionManager.runAfterInteractions(() => {
      this.setState({isReady: true});
    });

// in render
  render() {
    // test if loading
    if (!this.state.isReady) {
      return this.renderPlaceholder(); //this just render an empty grey back background with a loading icon
    }

   // real view when ready will appear in a fadeIn effect (thanks to react-native-animatable)
    const viewInfos = InfosModel.map((info, index) => {
      if (index === this.state.currentSavoirId) {
        return (
          <Animatable.View
            key={index}
            animation="fadeIn"
            duration={1500}

  }

Now I have a drawer react-native-drawer with black background.
So maybe it is something related...
I have to dig more.

Ok I changed drawer side content color to the opposite (white).

Now I clearly see that the ugly dark effect is related to side content drawer background color.
So I guess I have to open an issue in react-native-drawer for that.

Migration to 0.20 just had this problem for me : 6027.
So it is already better :smile:

At least #6027 doesn't do anything bad, it is just annoying -_-

Any update/solution to the issue with Node 5? Node 4 is not an option for me because I also have tests and need react as a dependency.

Fully agree. This warning won't break my application (just go production mode and it is gone :+1:). I'm glad this new version like previous seems like good.

Ok I fixed my react-native-drawer transition issue.
It has nothing related to react native but a mix with react-native-drawer I guess.

Fixing is easy and not a hack at all.

To avoid ugly blink on navigation just specify a background color style to your navigator (to avoid it from being transparent and showing drawer content color on navigation).

In my application my views backgrounds are in grey and my drawer content is black.
So I just added prop sceneStyle={{ backgroundColor: '#ECECEC' }} to navigator and I have same nice looking application as before migration.

      <Drawer
        ref="drawer"
        onOpen={()=>this.handlesDrawerOpen()}
        onClose={()=>this.handlesDrawerClose()}
        type={'static'}
        panCloseMask={0.2}
        tapToClose={true}
        negotiatePan={true}
        panStartCompensation
        openDrawerOffset={0.2}
        closedDrawerOffset={-3}
        content={DrawerContent}
      >
        <Navigator
          ref="navigator"
          initialRoute={{ id: 1, refView : 'RootView' }}
          sceneStyle={{ backgroundColor: '#ECECEC' }}
          renderScene={(route, navigator)=>this.renderScene(route, navigator)}
          configureScene={()=>Navigator.SceneConfigs.FadeAndroid}
          navigationBar={
            <Navigator.NavigationBar
              routeMapper={navigationBarRouteMapper}
              style={styles.navBar}
            />
          }
        />
      </Drawer>

@janicduplessis no .babelrc in standard build, only when running tests (same project with @ekonstantinidis )

I just had to update babel-register to 6.6.0 and it fixed this issue.

Installing babel-register 6.6.0 (which I have no idea what it is for) solved it
:+1: @morochena

This seems fairly critical given the upgrade paths for most users have been blocked now and the upgrade instructions for v0.21.0 call for a mandatory react-native upgrade.

@fxhereng The more dependencies you install the harder your app becomes to maintain. If you're not sure what something does, or if it seems like magic, good practice calls for further research before affecting change.

@MacKentoch The general comments in this issue regarding RN made it difficult for me to follow this thread. Do you know if there' s a chatroom for general upgrade chat?

/cc @brentvatne

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/020-react-native-upgrade-error
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Store is gone again sometimes

Window.Store disappeared so we've used document.querySelector("#app")._reactRootContainer.current.child.child.child.child.child.child.sibling.sibling.sibling.sibling.sibling.child.child.child.child.child.sibling.sibling.sibling.sibling.sibling.child.child.child.child.memoizedState for the last 2 months.
It appears to be gone again
EDIT 16 MINUTES LATER: it sometimes seems to work again - to me it looks like they are messing around with it again and do A/B testing. So yeah, brace yourself for a new wave of issues in the next couple of days. It is probably somewhat related to #343 who reported this 9 hours prior to my post.

it does not work anymore

https://github.com/mukulhase/WebWhatsapp-Wrapper/blob/master/webwhatsapi/js/wapi.js
Just check new code...

@bobaoapae
Where exactly is it

the solution : #343


Local Development for React Wallet v2 has been Broken

Description
Looks like this update https://github.com/WalletConnect/web-examples/pull/286 of the Next.js version has broken the local development of wallets/react-wallet-v2

OS: Windows 11, WSL
yarn version: 1.22.19
node version: 18.12.1
To confirm this you can checkout to any previous commit before the next.js update (https://github.com/WalletConnect/web-examples/pull/286) one e.g: https://github.com/WalletConnect/web-examples/commit/65f353ffd74b517b1adc6f373c305fb08d753d1b
git checkout 65f353ffd74b517b1adc6f373c305fb08d753d1b

cd wallets/react-wallet-v2

yarn && yarn dev
# The app will run just fine.

Thanks for making us aware @kujtimprenkuSQA 🙏
Looks like an issue on the next.js side with specific versions of v12/v13. We've reverted for now since this is a nice to have.
Unclear why it passed on the renovatebot preview and then failed immediately on main.

Thanks for making us aware @kujtimprenkuSQA 🙏
Looks like an issue on the next.js side with specific versions of v12/v13. We've reverted for now since this is a nice to have.
Unclear why it passed on the renovatebot preview and then failed immediately on main.

Thanks for the quick fix 👍
This is unrelated to this issue but would you mind merging this one as it's just a line of code: https://github.com/WalletConnect/web-examples/pull/301 and maybe finding a reviewer for this other PR: https://github.com/WalletConnect/web-examples/pull/270
Thanks.


feat(core): Add revalidation routes for store status and routes

What/Why?
Adds api routes to revalidate the route and store status caches in the KV store. The middlewares now behave in an SWR fashion (once hydrated), firing off a revalidation request when fetching a stale cache value (determined by a new expiryTime field in the cached value), but using that cached value for the current request. We also no longer await when setting the cache values in the middleware when there is a cache miss.
I've also consolidated the middleware, such that the maintenance mode check now happens in with-custom-urls. This allows us to do a single mget request to the KV store, which is very significant as the vercel KV store can take >100ms for a single request.
NOTE: Currently the dev adapter is not handling this well, as the KV store in memory for the middleware is a different object than the one the api routes have. Not sure what the solution is here. It doesn't actually break, but effectively the cache persists forever.
Testing
Tested locally, both with the dev adapter and the vercel development adapter, as well as in a vercel deploy

♻


[DISQ-148] Update htsjdk dependency version to 2.23.0

Fixes #148
While testing other dependency updates, I found that kryo-serializers (#146), google-cloud-nio (#145), fmt-maven-plugin (#149), and maven-failsafe-plugin (#150) cannot be updated without further changes.

Thank you, @lbergelson!  I'll try to resolve the other upgrade issues in a later pull request

Thanks for the update!  We're actually doing a new htsjdk release really soon, so we might have to bump it again.  I want to do a disq release too, but I've been saying that for a while now. I've been increasingly going insane due to the ongoing pandemic so I'm sorry if I'm slow responding.

Thanks for the update! We're actually doing a new htsjdk release really soon, so we might have to bump it again. I want to do a disq release too, but I've been saying that for a while now.

Perhaps it would be good to get a disq release out now then, I don't remember if I've done one yet, I will give it a shot.

I've been increasingly going insane due to the ongoing pandemic so I'm sorry if I'm slow responding.

No worries, insanity is the new normal 😉


Can't install via PyPi.

Looks like the PyPi version is installing optional dependencies (like spacy), and I can't build it.
The solution is installing from github (pip install<EMAIL_ADDRESS>It would be great if I could install from PyPi.

nvm it's working now. I probably did something wrong before.


#39: Add CodeCov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3eb1f49). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #40   +/-   ##
=======================================
  Coverage          ?   100%
  Complexity        ?     98
=======================================
  Files             ?     16
  Lines             ?    200
  Branches          ?      1
=======================================
  Hits              ?    200
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb1f49...59afe02. Read the comment docs.


Switched to Alpine, used multistage Dockerfile, added docker-compose.yml

Switching from Alpine, and using a multistage Dockerfile, dropped the container image size from 500mb to 98MB (32MB compressed).
The docker-compose.yml lets users start up by running "docker-compose up", instead of full docker syntax on the CLI.

Very cool and I have been wanting to use builder image for this, but haven't found the time for this. Only concern i have is by using scratch is that it is not possible for account management with netatalk then like PAM? I use PAM/LDAP myself with my image but it would stop working here.
I'll prioritize checking up on your contributions.
Thank you.

Closing this for now. After further testing I found a few issues, and fixed them in another commit.
I'll issue another PR shortly.
Using scratch shouldn't affect account management or anything; as you're copying / to / as root, you'd have to subsequently ensure ownership is set properly on anything not owned by root.


OpenVPN HMAC authentication failed

Prerequisites

[x] Can you reproduce?
[x] Are you running the latest version of SoftEtherVPN?

SoftEther version: Build from master commit https://github.com/SoftEtherVPN/SoftEtherVPN/commit/06c06f1db885f70e585aaeef0df5a26de8b953e4
Component: Server
Operating system: Docker container with base image centos:7
Architecture: 64 bit
Description
I've build softethervpn server and configured it with the appropriate certificates that are relevant to my test case. When I try to connect with an openvpn client  with a certificate (Signed by a CA), I get an HMAC error after the initialization sequence completed.
I've had no issues with this when I ran a SoftEtherVPN server build from source when using commit https://github.com/SoftEtherVPN/SoftEtherVPN/commit/8fdd224ba7f5676f99d74c7c63f60e046d07ec97.
Error:
Thu Sep 27 12:07:49 2018 Attempting to establish TCP connection with [AF_INET]<IP_ADDRESS>:1194 [nonblock]
Thu Sep 27 12:07:49 2018 TCP connection established with [AF_INET]<IP_ADDRESS>:1194
Thu Sep 27 12:07:49 2018 TCPv4_CLIENT link local: [undef]
Thu Sep 27 12:07:49 2018 TCPv4_CLIENT link remote: [AF_INET]<IP_ADDRESS>:1194
Thu Sep 27 12:07:49 2018 [openvpn.rsc.ixdev.net] Peer Connection Initiated with [AF_INET]<IP_ADDRESS>:1194
Thu Sep 27 12:07:51 2018 Preserving previous TUN/TAP instance: tun0
Thu Sep 27 12:07:51 2018 Initialization Sequence Completed
Thu Sep 27 12:07:54 2018 Authenticate/Decrypt packet error: packet HMAC authentication failed
Thu Sep 27 12:07:54 2018 Fatal decryption error (process_incoming_link), restarting
Thu Sep 27 12:07:54 2018 SIGUSR1[soft,decryption-error] received, process restarting

Expected behavior:
An openvpn connection
Actual behavior:
HMAC authentication failed
Steps to reproduce

Build softethervpn from commit https://github.com/SoftEtherVPN/SoftEtherVPN/commit/06c06f1db885f70e585aaeef0df5a26de8b953e4
Run SoftEtherVPN server with certificates
Create an account with as username the common name of the certificate.
Connect with openvpn and and the appropriate certificates in the openvpn.ovpn file

Thank you very much for your report!
I opened #721 to fix the issue, please test and review it.

I will test this after the weekend.

No problem.


Encryption: fix read encryption key from page storage & add unit tests

What problem does this PR solve?
Issue Number: close #8351
Problem Summary:
What is changed and how it works?

fix read encryption key from page storage
add unit tests for KeyspacesKeyManager
add bool contains(const Key & key) for LRUCache
DBMS_PUBLIC_GTEST should only link to tests related

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-build-release comment=true

/run-all-tests

/run-all-tests

/build

/run-all-tests

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/run-unit-test

/hold

/run-unit-test

/run-unit-test

/run-integration-test

/run-unit-test

/run-unit-test

/unhold


Open Source?

Where to see source of this project???? @MouriNaruto

for some reason, please check #548

Archived by #719.


inference time is longer than 5-6ms produced by author.And different size input, but the inference time is same.

When I run the detect.py which the default image size is 624x1024,the inference time is 14ms.And I resize the image size to 256x256,the inference time is also 14ms.So I have two questions: first is why the inference time is longer than 5-6ms produced by author？Second is why different size input but the inference time is same? And And I test in Tesla p100, pytorch=1.2.0, torchvision=0.4.0. I hope to get a reply，thanks！

the same problem as you . have you worked it out??

the same problem as you . have you worked it out??

mobilenet-0.25在i7 cpu前传时间60ms左右，与作者给出的VGA图片CPU-1的时间17.2ms相差很多，请问您那边遇到这种情况了么？


[ompl] Fix patch apply error

Describe the pull request

What does your PR fix? Fixes issue #10753
Fix patch apply error.

Cool, LGTM! Thanks @LilyWangL :)


Indicate content eligible for Hot Right Now reward (WIP)

Fixes #211. Functionally complete, using a placeholder design for now.

https://github.com/lbryio/lbry-app/commit/cd7e78046517628638239c260ef4ed327a106ff4


simple korean translation

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines.
[ ] Tests for the changes have been added (for bug fixes / features).

[ ] Muse | Mist have been tested.
[ ] Pisces | Gemini have been tested.

[ ] Docs have been added / updated (for bug fixes / features).

PR Type
What kind of change does this PR introduce?

[ ] Bugfix.
[ ] Feature.
[ ] Code style update (formatting, local variables).
[ ] Refactoring (no functional changes, no api changes).
[ ] Build related changes.
[ ] CI related changes.
[ ] Documentation content changes.
[x] Other... Please describe: simple translation

What is the current behavior?

translate some english word in language/kr.yml
Issue Number(s): N/A
What is the new behavior?
Description about this pull, in several words...

Screens with this changes: N/A
Link to demo site with this changes: N/A

How to use?
In NexT _config.yml:
...

Does this PR introduce a breaking change?

[ ] Yes.
[ ] No.

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。


Support for nightwatch.config.js instead of .json

Currently i house my nightwatch config in a js file nightwatch.conf.js so I am able to pass env's into it.
It would be great to have support in magellan
Error
hutber@hutber-blade /var/www/frontend $ npm run nightwatch

><EMAIL_ADDRESS>nightwatch /var/www/frontend
> DPRO=local ./node_modules/.bin/magellan --local_browser chrome -e

[INFO] [Magellan] Will try to load configuration from default of ./magellan.json
Loaded configuration from:  /var/www/frontend/magellan.json
[INFO] [Magellan] Magellan is creating temporary files at: /var/www/frontend/temp
[INFO] [Magellan] Magellan 10.1.1
[INFO] [Magellan] Loaded test framework:
[INFO] [Magellan]   testarmada-magellan-nightwatch-plugin
[INFO] [Magellan] Loaded test executors:
[INFO] [Magellan]   testarmada-magellan-local-executor
[INFO] [Magellan] Enabled bail strategy:
[INFO] [Magellan]   testarmada-magellan-never-bail-strategy: Magellan never bails, all tests will be executed at least once
/var/www/frontend/node_modules/testarmada-magellan-nightwatch-plugin/lib/get_tests.js:24
    throw new Error("Magellan-nightwatch test iterator cannot read nightwatch configuration: " + err.toString());
    ^

Error: Magellan-nightwatch test iterator cannot read nightwatch configuration: Error: Cannot find module '/var/www/frontend/conf/nightwatch.json'
    at module.exports (/var/www/frontend/node_modules/testarmada-magellan-nightwatch-plugin/lib/get_tests.js:24:11)
    at Object.module.exports [as getTests] (/var/www/frontend/node_modules/testarmada-magellan/src/get_tests.js:14:20)
    at module.exports (/var/www/frontend/node_modules/testarmada-magellan/src/cli.js:372:25)
    at Object.<anonymous> (/var/www/frontend/node_modules/testarmada-magellan/bin/magellan:23:22)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>nightwatch: `DPRO=local ./node_modules/.bin/magellan --local_browser chrome -e`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>nightwatch script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/hutber/.npm/_logs/2018-02-08T16_17_30_480Z-debug.log

Sorry for the late reply @hutber. Good news is we're working on it. Release ETA will be next week. Related ticket https://github.com/TestArmada/magellan-nightwatch-plugin/issues/17. PR https://github.com/TestArmada/magellan-nightwatch-plugin/pull/29

<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are out to support this. Please follow https://github.com/TestArmada/magellan-nightwatch-plugin#800


[$500] IOU-User able to create distance request with vague location

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.93-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app
Tap profile icon --- Preferences
Toggle on forced offline
Navigate back to LHN
Tap on a Workspace chat
Tap plus icon-- Request money
Tap distance request
Enter start "Dh" and save
Enter Finish "Cb" and save
Tap next
Tap Request
Navigate back to LHN
Tap profile icon---- Preferences
Toggle off forced offline
Open the Workspace chat
Tap on distance request created to open distance request detail page
Tap on receipt

Expected Result:
For vague location, if user creates distance request, it must show error.
Actual Result:
User able to create distance request with vague location
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/115492554/1d56b051-7578-4231-b71f-1f7cc5f0757d

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01425f6ffb0736addd
Upwork Job ID:<PHONE_NUMBER>541983232
Last Price Increase: 2023-10-31

Dupe of https://github.com/Expensify/App/issues/29783

Dupe of https://github.com/Expensify/App/issues/29783

Agreed, closing


cargo test no suppress of stdout for multi thread case

Problem

If I execute the below testcases with cargo test, the output of one_thread_test will be suppressed as stated in the documentation.
However the output from multi_thread_test will appear on stdout.
#[test]
fn one_thread_test() {
    println!("A");
    println!("B");
}

#[test]
fn multi_thread_test() {
    use std::thread;

    let mut threads = vec![];
    for _ in 0..5 {
        let t = thread::spawn(move || {
            println!("from thread");
        });
        threads.push(t);
    }
    for thread in threads {
        thread.join().unwrap();
    }
}

Steps

Run cargo test

Output of cargo version:

cargo 1.30.0 (a1a4ad372 2018-11-02)
rustc 1.30.1 (1433507eb 2018-11-07)
Linux/amd64

cargo new --lib crate with code above:
suppress_stdout.zip
Expected output:

running 2 tests
test tests::one_thread_test ... ok
test tests::multi_thread_test ... ok
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Actual output:

running 2 tests
test tests::one_thread_test ... ok
from thread
from thread
from thread
from thread
from thread
test tests::multi_thread_test ... ok
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out


Support Static Websites + Serverless Backend Scenario

This is a feature request to better support local testing of static websites that are backed by Serverless Backends (API+Lambda). Customers would like to use SAM CLI to serve their static website locally, so they can run and test it on a Web Browser. During the process, they want SAM CLI to also start a serverless backend locally (using sam local start-api). Their local website will connect to the local backend so they can have a fully integrated development solution.
Currently, SAM CLI has a --static-dir property that kind of supports this scenario. But this is not sufficient as discussed in #512, #200 etc.

@sanathkr When I start sam using sam local start-api --static-dir public  and browse to http://localhost:3000/ I get {"message":"Missing Authentication Token"}.  When I browse to http://localhost:3000/index.html it works as expected.  Is there anyway to make the default index.html?

FWIW, I've had success doing this the other way around: having a frontend server which proxies the local APIG. I'm using angular cli, which has support for this built in.


Create Typescript definition file and host on DefinitelyTyped

This would allow us to use Prism in a Typescript project and get auto-complete goodness.
https://github.com/DefinitelyTyped/DefinitelyTyped

If someone wants to submit a PR for this, I wouldn't be opposed :)

Created a PR on the DefinitelyTyped repo https://github.com/DefinitelyTyped/DefinitelyTyped/pull/8674


require_api_key import needs to be separate, this should all not be o…

…rder sensitive but it is for now

Fix already merged


[µTVM] Add support for mps2_an521 board

Hi,
Could the following patchset be reviewed please?
It enables the Arm MPS2-AN521 board to be used on microTVM:
TARGET = tvm.target.target.micro("mps2_an521")
BOARD = "mps2_an521-qemu"
It also adds to micro_tflite.py an example on how to run Zephyr demo in apps/  using that new target.
To use the MPS2-AN521 target it's necessary the newest Zephyr 2.5.0 branch [0] that contains the following fixes:
drivers: uart: uart_cmsdk_apb: fix interrupt handling
https://github.com/zephyrproject-rtos/zephyr/commit/ec0aa8331a652b7e7ed5d9c5653d6d70c3789dc6
drivers: uart: uart_cmsdk_apb: Fix uart_irq_is_pending
https://github.com/zephyrproject-rtos/zephyr/commit/bd0fe17fa0161e28405ec49d8da0f4ca9db90723
boards: arm: mps2-an521: Fix DT memory regions
https://github.com/zephyrproject-rtos/zephyr/commit/fe3f71bdad8b92ff3f559f843dc43cb45373f0a4
It's also necessary to have qemu-system-arm available in the environment (reachable from $PATH).
Thanks,
Gustavo
[0] https://github.com/zephyrproject-rtos/zephyr/commits/v2.5-branch

@areusch @mehrdadh @tom-gall @leandron

@gromero Thanks for this PR!
For clarification, is Zephyr 2.5.0 branch [0] different than 2.5.0?

@gromero there is a lint issue. You can run make format in the main directory and it will fix it assuming you have clang-format-10.

@maheshambule @areusch Thanks a lot for the hint on how to check lint locally. I was not aware of them : ) make format actually suggested more than 200 changes, which really seemed too picky and not necessary, so I ended up using just docker/bash.sh tlcpack/ci-lint:v0.62 ./tests/scripts/task_lint.s and it made the magic.

@gromero Thanks for this PR!
For clarification, is Zephyr 2.5.0 branch [0] different than 2.5.0?

Hi @mehrdadh ! Yes, they are different. The v2.5.0 is a tag and so a cut of master when the release happened. The v2.5-branch is a maintenance branch where the backports land (the great majority are fixes) for 2.5.0 and, afaik, it's considered stable at any time. I pointed out that this PR requires the v2.5-branch because the fixes I've listed (that are necessary for the MPS2-AN521) landed in master after the "cut" for the v2.5.0 release, so I had to backport them to Zephyr 2.5.0, hence they are present in v2.5-branch only.

@maheshambule @areusch Thanks a lot for the hint on how to check lint locally. I was not aware of them : ) make format actually suggested more than 200 changes, which really seemed too picky and not necessary, so I ended up using just docker/bash.sh tlcpack/ci-lint:v0.62 ./tests/scripts/task_lint.s and it made the magic.

yeah so this is why you should prefer docker/lint.sh (or equivalent docker/bash.sh) for linting operations--the output of the lint tool is extremely sensitive to the version of e.g. cpplint, pylint, etc that you are using. the docker container removes that issue from consideration.

thanks @gromero , the PR is now merged!

thanks @gromero , the PR is now merged!

@areusch Thanks a lot for the reviews and for merging it!


Add support for graph zooming by mouse wheel or touchpad

https://developer.android.com/develop/ui/compose/touch-input/pointer-input/multi-touch