Is the blob upload secure?

Since a file is temporarily stored on the server, is this a secure, HIPAA-compliant way to upload files?

The last commit was over 1 year ago.  I don't believe this is being actively maintained so I wouldn't count on it providing a solid basis for HIPAA compliant messaging.  I am not the maintainer but I don't think it is likely to get attention in the future.

Any advice? I am rails developer struggling with dealing with upload/download TrueVault blobs. Upload I can do with carrierwave (though I can't save the blob_id if I do that). Download I'm useless on.

You could try to look at the fork network.  It appears that drewbaumann/truevault.rb has a recent commit from March of this year.  Might indicate maintained status.  You could also look at forking and maintaining your own version.

Original creator here. Happy to accept PRs or add someone as a contributor. I unfortunately don't have any advice on the download to server idea other than putting in place controls to mitigate the risk such as storing on an encrypted disk and regularly wiping caches.

@admande my team had similar concerns regarding HIPAA compliance and server pass-through.  When we integrated with TrueVault, we decided to err on the side of caution and use the File Upload & Download API.  With this integration, we send access_key  and signature to the client, allowing our users to upload and download directly from TrueVault.  No PHI passes through our servers.
I recently had a conversion with a technical contact at TrueVault, and they confirmed our thoughts that PHI cannot pass through non-HIPAA servers.  My understanding is it's because there are no BAA contracts in place with said service providers.


feat: Added testIDs to ToastContainer

Automated test runs were unable to select various elements within a Native Base Toast. New optional testIDs have been added to support this requirement.

#2878

Is this fixed ?

@WolfyUK Can you resolve the conflicts here for us to take it forward

@WolfyUK Can you resolve the conflicts here for us to take it forward

@shivrajkumar I'm not in a position right now to resolve this but I'll aim to do so by the end of the week

@shivrajkumar I'm not in a position right now to resolve this but I'll aim to do so by the end of the week


TP.CLI drop usage of Microsoft.Internal.TestPlatform.Remote

Description
Replace usage of Microsoft.Internal.TestPlatform.Remote with System.ComponentModel.Composition package as we are only relying on this dll. This should help fix the source build issue.
Related issue
Fixes #4403

@MichaelSimons I am not sure if I still need some prebuilt definition after this change.

Sorry about that - I totally forgot to check this setting. Thanks @MichaelSimons <3

/azp run


Update packages

Ref: https://github.com/niteoweb/operations/issues/620

This package needs Travis set up so we know we are not breaking things when upgrading packages.


Patching freezes game

I got the reloader to build by updating it to .NET 4.7.2 to match the Rimworld version, which fixes an missing reference caused by attempting to build against 3.5.
The reloader loads correctly (I see the logs in-game). When I try to reload my method, the game freezes and has to be killed.
I went back into the Reloader code and tried to fix the patching method by changing the Memory.cs class to the newer Harmony 2 Memory.cs, taking out all methods apart from WriteJump and GetMethodStart which are the only ones used in this project. I then had to add a reference to Mono.Ceil because that's what Harmony uses.
I compiled again, and exact same result. It imports and loads correctly into Rimworld, but patching freezes the game when calling WriteJump.
Do you know how I can fix this, or what is happening? I'm sure this project is not your focus, but if you could point me in the right direction I could try to fix this and create a pull request.
Edit:
More specifically, the entire game freezes permanently after the line
DetourHelper.Native.Apply(data);
in WriteJump in Memory.cs (taken from Harmony, here)

Due to the changes in Unity RimWorld loads assemblies different. So I guess Reloader is broken. I don’t have the time/priority for finding a fix for it right now but your welcome to do it.
Like any other mod, it should depend on the Harmony mod instead of packing its own harmony lib. Why the game freezes, I have no idea.


⚠ RPC server - xDai has degraded performance

In b1eb16b, RPC server - xDai ($XDAI_RPC_URL) experienced degraded performance:

HTTP code: 200
Response time: 392 ms

Resolved: RPC server - xDai performance has improved in 2f7c68e after 2 hours, 32 minutes.


Receiving error when trying to use geoip in NextJS app.

package.json
{
  "name": "astropathshala-app",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "lint": "next lint"
  },
  "dependencies": {
    "@types/crypto-js": "^4.1.1",
    "@types/geolite2": "^2.0.0",
    "@types/node": "20.1.1",
    "@types/react": "18.2.6",
    "@types/react-dom": "18.2.4",
    "@types/uuid": "^9.0.1",
    "axios": "^1.4.0",
    "axios-retry": "^3.4.0",
    "check-password-strength": "^2.0.7",
    "crypto-js": "^4.1.1",
    "email-validator": "^2.0.4",
    "eslint": "8.40.0",
    "eslint-config-next": "13.4.1",
    "geolite2": "^3.5.1",
    "is-ip": "^5.0.0",
    "maxmind": "^4.3.11",
    "mysql2": "^3.3.0",
    "next": "13.4.1",
    "nodemailer": "^6.9.1",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "typescript": "5.0.4",
    "universal-cookie": "^4.0.4",
    "uuid": "^9.0.0"
  },
  "geolite2": {
    "license-key": "my-licesnse-key",
    "selected-dbs": [
      "City",
      "Country",
      "ASN"
    ]
  }
}

Error-
Import trace for requested module:
./node_modules/geolite2/utils.js
./node_modules/geolite2/index.js
./src/modules/server/fetchIPData.ts
./src/modules/server/isValidIP.ts
./src/app/api/accounts/account/is-registered/route.ts
WARN: geolite2 cannot find project's package.json file, using default configuration.
WARN: geolite2 expects to have maxmind licence key to be present in `MAXMIND_LICENSE_KEY` env variable when package.json is unavailable.
WARN: geolite2 expected package.json to be preset at:
/home/shreshthtiwari/Desktop/Prrojects/astropathshala-app/package.json
WARN: geolite2 cannot find project's package.json file, using default configuration.
WARN: geolite2 expects to have maxmind licence key to be present in `MAXMIND_LICENSE_KEY` env variable when package.json is unavailable.
WARN: geolite2 expected package.json to be preset at:
/home/shreshthtiwari/Desktop/Prrojects/astropathshala-app/package.json
[Error: ENOENT: no such file or directory, open '/home/shreshthtiwari/Desktop/Prrojects/astropathshala-app/.next/server/app/api/accounts/account/is-registered/dbs/GeoLite2-City.mmdb'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/shreshthtiwari/Desktop/Prrojects/astropathshala-app/.next/server/app/api/accounts/account/is-registered/dbs/GeoLite2-City.mmdb'
}

I assume it's due to that

WARN: geolite2 cannot find project's package.json file, using default configuration.

Here's a hint

WARN: geolite2 expected package.json to be preset at:
/home/shreshthtiwari/Desktop/Prrojects/astropathshala-app/package.json

but it is there

i have even defined the .env file, still the module is unable to find it.

@runk Please help. :(

Do you have a repo on github with reproducable error?


Add 'Understanding the Reports' section to README

Reports of tern provides a lot of information, and the types and format
of the items provided varies depending on the report format. Thus,
users might not understand what kind information they can get from
the reports and where to look at to get the information on the report.
This commit adds information about the specific type of information
available in each report format to the README.
Resolves #960
Signed-off-by: Rose Judge<EMAIL_ADDRESS>

@JustinWonjaePark could you take a look at these changes and see if they help clarify anything? We can't provide a description for every property in every report format as that would just be too long, but I hope that this summary will help and also point users to where in the code they can find the property description they are looking for. Would love to hear your feedback, thanks!

I'll wait another day for review from @JustinWonjaePark and if I haven't heard anything by then, I will merge this PR :)

@rnjudge I was out of office for a while. Sorry for late response.
I do understand that it would be difficult to provide every single items on the report.
The change looks good for me and I think it would be helpful for new comers.


Threads are created anew for each MT rendering operation

The current MT harness creates new worker threads for each MT job, which is incredibly inefficient.  This should be considered the highest priority performance issue.

After thinking about this for a while, here are my current thoughts:
Having a thread pool for a server makes a lot of sense.  However, having thread pools for workers that will go off and carry out many different types of rendering operation does not fit so well.  In general, attempting to use thread pools will vastly complicate the code for currently indeterminate performance benefit.
Rayon works nicely for divide and conquer approaches.  It produces very succinct parellelised code.   However, it does mean that the application completely defers to Rayon to decide when to actually spawn another thread based on the dynamic load, and gives up on reuse of threads.  Using a recursive method to split the patches to be rendered works well, and with the Vulkan renderer, the code is extremely pleasing to the eye.  However, with the GL renderer the necessity of transferring the data to the master thread for flushing makes re-architecting the code a bit of a nightmare.
Rayon's parallel iterators are not such a good fit for Wyvern/Aeolius as wrangling the Renderer and ThreadData references to appease the borrow checker becomes a nightmare.  They work better with functions than with methods.
TL;DR: Moving to thread reuse should be an experimental task to investigate the potential performance benefit.  Doing so would make the code more complex and therefore less maintainable.  In future, if the Vulkan renderer became the sole target, a switch to Rayon or similar could result in very terse code.
Closing this for now.


fixes #331, include -dbgsym packages

dbgsym are the new automatic debug packages.
This is an extremely simple change to let these packages in

ok It actually seems that pkg-create-dbgsym adds it to binary field, i created simple package to test it, and the basic aptly filter works
Checksums-Sha1:
 41eed58a4c4815c3902ffcda1bee4f4d9dbe1b02 5223882 aptly_0.9.7_amd64.deb
 d2288bb923cf0dbcac365b21a3f7c7bc1b8ded0a 1591372 aptly-dbgsym_0.9.7_amd64.ddeb
Checksums-Sha256:
 9a795048b5033d0a4df08cba9804608df7a0ad14fddb81b8f6fff9339198451b 5223882 aptly_0.9.7_amd64.deb
<PHONE_NUMBER>0b8f3fb8015b77b389d1ed0d9b5bed7d50f8c7db9c02aca829b4d4 1591372 aptly-dbgsym_0.9.7_amd64.ddeb
Files:
 0a07649ad9a617bcb63ff841b488980b 5223882 patched/utils optional aptly_0.9.7_amd64.deb
 1c277394fad62459f2480b5d9b7f0ff6 1591372 patched/utils extra aptly-dbgsym_0.9.7_amd64.ddeb

and the control:
Package: aptly-dbgsym
Source: aptly
Version: 0.9.7
Depends: aptly (= 0.9.7)
Architecture: amd64
Maintainer: xxxx
Installed-Size: 12981
Section: patched/utils
Priority: extra
Description: debug symbols for package aptly

so we don't need this change?

ok, bad compilation on my side, I'm not an experienced go dev.
I thought binary contains all checksummed blobs.
I'll need to redo the whole code.
I think the best would be to swap Value: c.Binary[0] for Value: c.Files[0].Filename and comparing checksummed filenames.
dbgsym should be only persent when at least one Binary is there.
Another approach is to add separate code blocks for processing ddeb

Why CollectPackageFiles is called then when there is already a list of acceptable & verified files in the Changes structure?
Thus almost completely negating the need for PackageQuery

I think the only reason is to do cross-check on package files and contents of .changes file. Should we include -dbgsym packages based on some other condition which is unique? Like built from the same source package?

But you copy the files to a tmp dir anyway (Changes.TempDir), so they're the only the files from the changes. There's no point in walking the filesystem 2nd time and then filtering. Maybe only filter out source tar.* packages, as it's in the .dsc. It's pretty much impossible to have different files at that point. (assuming no malicious user swapping them in mid processing, but if that happens the whole repo is compromised anyway)
The only thing I'd change in .changes processing is to add temp dir to aptly config, so it can be on the same filesystem as the rest of the repo. (swap os.TempDir() for some user setting, or default to os.TempDir())
Then copy with reference/hardlink is possible, and verify the checksums after copy to temp dir. That way all files in temp dir could be safely processed.
As a side point , I think I should close this PR, as it's badly done.
Dhould we move this discussion to issue #331?

Let's move to #331


Add track_set_key_time() to Animation

Closes #29295
Closes #20858
Resolves #28482
So much duplicate code happening in this class :/

Thanks!


Parametrize IPA benchmark with match key bits

The goal is to allow more flexibility comparing MP-SPDZ and Rust implementation. This change does not make match key size dynamic as it is significantly more work, but rather instructs the IPA protocol (specifically modulus conversion) to ignore higher bits.
Testing
Using 20 bits from each match key
RUST_LOG=debug cargo bench --bench oneshot_ipa --no-default-features --features="enable-benches debug-trace" -- --match-key-bits 20 | grep match_key_shares | cut -d'/' -f7 | cut -d',' -f1 | sed -e "s/elem//g" | sort -nr | uniq | head -n1
19

Omit --match-key-bits argument and IPA uses all 40 bits
RUST_LOG=debug cargo bench --bench oneshot_ipa --no-default-features --features="enable-benches debug-trace" | grep match_key_shares | cut -d'/' -f7 | cut -d',' -f1 | sed -e "s/elem//g" | sort -nr | uniq | head -n1
39

covered by #569


Implement several CRF architectures

This repo here: https://github.com/guillaumegenthial/tf_ner
has a few improvements with the CRF implementation. Could this be something that could be implemented into the Rasa pipeline?

Thanks for the suggestion! We've been thinking of using tf for NER for a while now. @Ghostvv can you take a look into this repo and see if it would be worth it?

thank you for the link. Unfortunately, we cannot use this library directly because we have custom featurizers, but as mentioned we have a plan to evaluate TensorFlow crf.
I'll close this issue for now, please feel free to reopen it


Window is gone on lost focus on Windows

On Windows 10, whenever the let g:neovide_fullscreen=v:true is set, when I press alt-tab (change focus to another window) the original window is killed. Built from the repository, commit 63845ca with cargo build --release

This is fixed by https://github.com/Kethku/neovide/pull/248. Thanks @R-Michelsen


[FEATURE REQ] Pemanent delete Blob (include blob version)

Library name
Azure.Storage.Blobs
Please describe the feature.
For soft deleted blob, user can set deletetype = permanent to permanent delete the blob, see https://docs.microsoft.com/en-us/rest/api/storageservices/delete-blob
V12 SDK doesn't have an API to support this function (v11 SDK has the API.)
Sometimes user would like to permanent delete the blobs for some reason, like billing.
We have already get customer ask for this like Incident 311972550.
If .net sdk support it, PSH can also easily to support it.

//cc: @kasobol-msft

+1 This would be really useful for Blob management, I don't have a way via the SDK to do this and am incurring additional costs. My specific scenario is I need to convert Append Blobs to Block Blobs to utilize Block Block lifecycle management. I still have the file so I am not concerned with keeping the original.

@blueww, the Azure Arch board choice not to include Permanant Delete in the SDKs several years ago.  A very common call customers make to customer support is to undelete accidently-deleted blobs.  The Arch Board was really concerned that customers would call permanent delete by accident, and then have no way to recover their blobs.


Correct way to clean framebuffer?

I was wondering what is the correct way to clean bgfx framebuffers. In my nanovg app, after I created a framebuffer, I use gl functions to get a clean framebuffer like this.
NVGLUframebuffer* fb = nvgluCreateFramebuffer(c, w, h, 0);
nvgluBindFramebuffer(fb);
glViewport(0, 0, kWidth, kHeight);
glClearColor(0, 0, 0, 0);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
nvgBeginFrame(ctx);
...
nvgEndFrame(ctx);
nvgluBindFramebuffer(NULL);

And this is how I clean the framebuffer when using bgfx backend:
NVGLUframebuffer* fb = nvgluCreateFramebuffer(c, w, h, 0);
nvgluBindFramebuffer(fb);
bgfx::setViewRect(fb->viewId, 0, 0, w, h);
bgfx::setViewClear(fb->viewId, BGFX_CLEAR_COLOR | BGFX_CLEAR_DEPTH | BGFX_CLEAR_STENCIL, 0x00000000, 1.0f, 0);
nvgBeginFrame(ctx);
...
nvgEndFrame(ctx);
nvgluBindFramebuffer(NULL);

However, the displayed result when using bgfx is often broken and not consistent frame by frame. How should I do something like the gl functions in bgfx way? Thanks.

You can't clear bgfx view multiple times per frame. You need to change view id if you gonna clear it again.

Thanks for reply. Is it possible to flush rendering of a specific view (framebuffer) without swapping the presented buffer?

Views get submitted when you call bgfx::frame. Just think about flush as view++, that forces ordering to be correct, and allows you to reuse framebuffer.

But bgfx::frame() swap presented buffer explicitly. There are times I just need to flush without swapping. For example, to create a offscreen image then save to the disk, or I may create a framebuffer with a photo image, then applies some effect filter, then applies a mask generated in another framebuffer, and finally displays the result.

Yeah you can do all that view views (something like this):

I may create a framebuffer with a photo image

bgfx::setViewFrameBuffer(0, fb0);
bgfx::submit(0);

then applies some effect filter

bgfx::setViewFrameBuffer(1, fb1);
bgfx::setTexture(1, fb0);
bgfx::submit(1);

then applies a mask generated in another framebuffer

bgfx::setViewFrameBuffer(2, fb2);
bgfx::setTexture(2, fb2);
bgfx::submit(2);

and finally displays the result.

bgfx::setViewFrameBuffer(3, invalid);
bgfx::setTexture(3, fb2);
bgfx::submit(3);

Actually check bgfx examples, see HDR example: https://github.com/bkaradzic/bgfx/blob/master/examples/09-hdr/hdr.cpp#L363

Thanks for your tips. I will try it out. 👍


Expose JSDoc documentation on the website

We're writing it, we should show it.

Pull Request Test Coverage Report for Build 1811

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 66.858%

Files with Coverage Reduction
New Missed Lines
%

util/thingpedia-client.js
1
76.33%

Totals

Change from base Build 1798:
-0.01%

Covered Lines:
6842

Relevant Lines:
9624

💛  - Coveralls


Lang attribute

Hi! :)
I added the possibility set the lang attribute on the webpage itself + individual paragraphs. The lang attribute on the webpage (Frontend element) is automatically set to "en" for English, but can be set to the desired language. For example .lang("no") for Norwegian. The lang attribute on paragraphs is optional and is not set to any language by default.
I edited the paragraph example project to include lang attribute on the Frontend element and the top Paragraph element.
I made these changes because I need my project to comply with WCAG. More about that:
In some countries it is required by law to follow the guidelines of the Web Accessibility Directive. According to the European Commission these standards are the same as Web Content Accessibility Guidelines 2.1.
Two of the criteria in WCAG are the following:

3.1.1 Language of Page
The default human language of each Web page can be programmatically determined.

3.1.2 Language of Parts
The human language of each passage or phrase in the content can be programmatically determined except for proper names, technical terms, words of indeterminate language, and words or phrases that have become part of the vernacular of the immediately surrounding text.

Using a lang attribute is listed as a sufficient technique to solve this for both the web page and passages of text.

Thank you for all the feedback on the commits btw! :D


Cannot Serialize Simple Bevy World Into a Scene

Bevy version
0.10.1
What you did

Created fresh bevy project
Made this main.rs file:

use bevy::prelude::*;

fn main() {
    App::new()
        .add_startup_system(start_up)
        .add_system(serialize_scene_system)
        .add_plugins(DefaultPlugins)
        .run();
}

fn start_up(mut commands: Commands) {
    // comment out this line to fix issue
    commands.spawn(Camera2dBundle::default());
}

fn serialize_scene_system(world: &mut World) {
    let type_registry = world.resource::<AppTypeRegistry>();
    let scene = DynamicScene::from_world(world, type_registry);

    let serialized_scene = scene.serialize_ron(type_registry).unwrap();

    info!("{}", serialized_scene);
}

Executed "cargo run"

What went wrong
I was expecting it to just serialize the world, as I have not really added any new code (i.e components/resources).
Instead, I got this error: thread 'main' panicked at 'called Result::unwrap() on an Err value: Message("no registration found for dynamic type with name bevy_math::rect::Rect")', src\main.rs:19:63
Additional information
It feels like something wasn't registered by bevy. If you comment out the line of code inside of start_up, which spawns the Camera bundle, the error disappears and program runs as expected.
My thoughts moving forward
I understand that in the examples, you usually create an empty world and throw in the things you want to save in the scene, or use the DynamicSceneBuilder. This may or may not be a common practice in the bevy community. But I think if you want to serialize the entire world, then you should be able to without bevy holding you back.
If we're in agreement, then we should make a unit test that ensures that a basic bevy setup always registers what is needed so that the entire World can be serialized. I would make a PR of this myself, and I would actually like to in order to have a contribution under my belt  (perhaps the first of many), but I'm not familiar enough with Bevy to make a comprehensive unit test. So if someone could help me out with that, or if you just wanna leave suggestions here on what I should include in the unit test, I'd appreciate it!

When I migrated the code to v0.11, a different error came up:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("Type 'std::time::Instant' did not register ReflectSerialize")', src\main.rs:20:63

I apologize, but I'm having the same issue with ComputedVisibilityFlags.

This reply is going to be a ramble, apologies for that, but...
Experiencing all the same stuff with Bevy 0.11.0 right now. Moreso, I tried excluding all components and resources that aren't truly serializable (the only way I found to do this was to actually just serialize each one, which is wildly inefficient, but it works and that's what I wanted lol).

Sample system for serializing and deserializing only serializable components and resources
use bevy::{
    ecs::entity::EntityMap,
    prelude::*,
    reflect::{serde::TypedReflectSerializer, TypeRegistryInternal},
    scene::serde::SceneDeserializer,
};

use serde::de::DeserializeSeed;

fn serializable(reflect: &dyn Reflect, registry: &TypeRegistryInternal) -> bool {
    let serializer = TypedReflectSerializer::new(reflect, registry);
    ron::to_string(&serializer).is_ok()
}

pub fn rescene(world: &mut World) {
    let input = world.get_resource::<Input<KeyCode>>().unwrap();
    if input.just_pressed(KeyCode::C) {
        let mut scene = DynamicScene::from_world(world);
        let registry = world.get_resource::<AppTypeRegistry>().unwrap().read();

        scene
            .resources
            .retain(|res| serializable(res.as_ref(), &registry));

        scene.entities.retain_mut(|ent| {
            ent.components
                .retain(|x| serializable(x.as_ref(), &registry));
            !ent.components.is_empty()
        });

        drop(registry);
        let registry = world.get_resource_mut::<AppTypeRegistry>().unwrap();
        let serialized = scene.serialize_ron(&registry.0).unwrap();

        //std::fs::write("/tmp/test", &serialized).ok();

        let registry = world.get_resource::<AppTypeRegistry>().unwrap().read();

        let deserializer = SceneDeserializer {
            type_registry: &registry,
        };

        let mut ronde = ron::de::Deserializer::from_bytes(serialized.as_bytes()).unwrap();
        // panics here
        let deserialized = deserializer.deserialize(&mut ronde).unwrap();

        //drop(registry);

        //deserialized
        //    .write_to_world(world, &mut EntityMap::default())
        //    .unwrap();
    }
}

This panics on actually deserializing the scene I got from serializing everything that could be. In particular:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("no registration found for type `core::option::Option<bevy_window::window::WindowTheme>`")', src/serialize_mess.rs:45:65

This seems to be the window_theme field on Window component. The fact that just serializing everything serializes window entities suggests that maybe serializing the entire world might not be the best path forward.
Funnily enough, excluding that via string comparisons in serializable function I made up causes it to then crash on Camera3dDepthTextureUsage, and excluding that on HashMap<Entity, Cascade>. It will likely keep crashing on various random stuff if I keep doing this.

...It doesn't seem like serializing the entire world and every single thing is very practical. It could probably be a cool feature to cause deserializing spawn a new window on the user's desktop, but usually that's not what you'd want.
This does raise a question of how does one de/serialize "meaningful" parts of a world. Serializing Transform but not GlobalTransform because the later is automatically computed anyways. Camera3d's transform and settings, but not depth texture metadata and other technical gooblydook. Not the window itself, maybe.
Thinking about it, this sounds like a very subjective thing, as different parts of different components can be meaningless to some users but very important to other. I guess deciding on this should be user's responsibility, and DynamicSceneBuilder type allows for granular filtering like this.
You could make a marker component, slap it on every meaningful entity and then before exporting make a query and use it as a filter in DynamicSceneBuilder
Though, the caveat of "this is likely meaningless to serialize" should probably be mentioned in docs of DynamicScene::from_world(…).

I understand that in the examples, you usually create an empty world and throw in the things you want to save in the scene, or use the DynamicSceneBuilder. [...] But I think if you want to serialize the entire world, then you should be able to without bevy holding you back. [...] we should make a unit test that ensures that a basic bevy setup always registers what is needed so that the entire World can be serialized.

Completely agreed! I'm new to Bevy (and Rust for that matter) so I can't be much help beyond this small contribution:
I can reproduce in Bevy 0.11.2 with the following main.rs updated from the original poster to remove some errors and deprecation warnings:
use bevy::prelude::*;

fn main() {
    App::new()
        .add_systems(Startup, start_up)
        .add_systems(Update, serialize_scene_system)
        .add_plugins(DefaultPlugins)
        .run();
}

fn start_up(mut commands: Commands) {
    // comment out this line to fix issue
    commands.spawn(Camera2dBundle::default());
}

fn serialize_scene_system(world: &mut World) {
    let type_registry = world.resource::<AppTypeRegistry>();
    let scene = DynamicScene::from_world(world);

    let serialized_scene = scene.serialize_ron(type_registry).unwrap();

    info!("{}", serialized_scene);
}

The error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Message("Type 'std::time::Instant' did not register ReflectSerialize")', src/main.rs:20:63

Related to this issue, there I noticed that PlaybackSettings do not serialize/deserialize. There are no errors, but that component is not included in DynamicScene exports.
I think the root of the issue is that a number of components and resources do not reflect out of the box, resulting in inconsistent and surprising behavior. Reflection is still fairly new (mentioned a lot in the latest release notes) and stabilizing -- so rough edges like this are to be expected.
My workaround (for those blocked by this issue) is to use the DynamicSceneBuilder allow, allow_resource and deny/deny_resource methods to exclude these panic-causing bugs w/ Instant and ComputedVisibility. Then I have a system which detects added entities with correlated components and "re-hydrates" said entities to include the correct components.
For example, here is a system that exports a scene with none of the resources and a bunch of entities, sans the ComputedVisibility component:
fn export(
    root: Query<Entity, With<LevelRoot>>,
    children:Query<&Children>,
    world: &World,
) {
    let app_type_registry = world.resource::<AppTypeRegistry>().clone();
    let mut builder = DynamicSceneBuilder::from_world(world.clone());

    builder.deny_all_resources();

    builder.allow_all();
    builder.deny::<ComputedVisibility>();

    // Here we are extracting a `LevelRoot` node and it's children, for example sake.
    // Extract the level root
    builder.extract_entity(root.single());

    // Extract all level root descendants
    builder.extract_entities(
        children.iter_descendants(root.single())
    );

    // Build the scene
    let scene = builder.build();

    let scene_ron = scene
        .serialize_ron(&app_type_registry)
        .expect("Serialize scene");
}

And here is a system that re-hydrates entities missing the ComputedVisibility component:
fn rehydrate(
    events: Query<Entity, (Added<Visibility>, Without<ComputedVisibility>)>,
    mut commands: Commands,
) {
    for entity in events.iter() {
        commands
            .entity(entity)
            .insert(ComputedVisibility::default());
    }
}

This is not an ideal UX and I would much rather have all out-of-the-box resources and components reflect by default.

Just to chime in, I've made Mooshine Save as a generic solution to exactly the problems @pop described.

Note that this should be significantly easier with #4154 resolved and the currently experimental #12332. The latter should resolve almost all cases where registration is currently missing.


[ADD] THORChain deposit feature

Is your feature request related to a problem? Please describe.
THORChain deposit feature

closing , as deposit is done


Dai+schema 2009/05

The new schema has these features 𝑛𝑒𝑒𝑑𝑒𝑑 in supporting DAI

introduces <string> element in order to handle complex l10n situations like gender and plural.
introduces name="xxx" attribute for <contract> to allow more than 1 contracts.
introduces <origins> element to contain origins of tokens and attribute-types.
introduce <user-entry> element to contain attribute value sourced from user's entry.
replace <origin function="xxx"> with <etherem function="xx"
replace <origin bitmask="xxx"> with <token-id bitmask="xxx"
introduce <transaction> in <action>
allow <attribute-type> in <action>

@hboon

I thought of using name for attributes and use id for contracts and selections. Reason being that old time HTML developers know in <form> an element with name="xx" is used as a variable, just like attribute-type's name is used as a variable when constructing transactions. But I didn't do so, because I feel such code would be confusing because the word name is used twice:

Street
 …

although <contract> can safely use name attribute because contracts don't have a display name, I preferred label attribute because I am afraid we will give <contract> a display name one day in the future. On second thought, maybe we will not do so, so I made a new commit changing label back to name.


Atom Samples

Create samples of these things before wiring all of these up with the language service:
Depend on atom packages
see : https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#depending-upon-other-atom-packages

[x] For now ensure linter gets installed.

Errors in view
Use Atom Linter : https://atom.io/packages/linter : blocked by : https://github.com/AtomLinter/Linter/issues/337

[x] Really dodgy API. But done.

See ATOM discuss : https://discuss.atom.io/t/canonical-way-to-show-errors-in-the-editor/14339
Note: we might just use the decorators API directly : http://blog.atom.io/2014/07/24/decorations.html and just use errors in project pane.
Errors in project
Potentially need a place to list all the error messages in the project
Use Atom Message Panel: https://github.com/tcarlsen/atom-message-panel used by e.g. https://github.com/tcarlsen/atom-csslint/blob/master/lib/linter.js

[x] Errors show up for each file

Autocomplete
Look at integration with autocompleteplus

There is already a great sample for autocomplete here : https://github.com/park9140/atom-typescript-tools/tree/master/lib specifically : https://github.com/park9140/atom-typescript-tools/blob/master/lib/autocomplete-provider.ts


Separate entity::set_component and entity::add_component

At present, set_component implicitly adds a component if it does not exist. This should be changed so that you can't accidentally add components that you did not intend to add.

Duplicate of #63


Npm start open 2 windows

I don't know if it's an error or it's done that way, but I'd like to know why two windows come out and I can't close one of them have to be open, if I create new components they all start when I run the application?

I don't know if it's an error or it's done that way, but I'd like to know why two windows come out and I can't close one of them have to be open, if I create new components they all start when I run the application?

Yeah its design that way so you can have a better idea on how to handle multiple windows. You can remove it by commenting the createSecondWindow() function inside createWindows().
Please refer to the image below.


fix padding on child pages in docs

fixes #755

Lemme have a few minutes this morning with this. Looking at the preview, this looks like it pulls the nav left and out of alignment with the logo, which is not what we want:
Compare:

With:

github will not let me approve but looks good. thanks.


Allow to replace an element instead of append to body for web rendering

In case you want to have the application at the start of the page and some other content after it just appending to the body won't work
With this change you can add a

 and it will be replaced by the canvas

How cool would it be to have an Elm lang package that allows for Iced embeds using this!
Elm could handle all the SEO, pages, general web stuff, and Iced could be for the parts that don't need SEO and/or rendering of more complicated processes.


Dependency package chalk has a new version available

We have identified a dependency on version 4.1.2 of chalk. A new version (5.0.1) is available for upgrade.
Following are the steps to upgrade package dependency.

Understand the breaking changes between the version being used and the version you want to upgrade to.

Identify all packages that take a dependency on this package.

Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

Run rush update to ensure the new version is pulled in.

Make relevant changes to absorb the breaking changes.

Repeat steps 3 to 5 for each of the packages that have a dependency on this package.

[ ] common/tools/dev-tool/package.json:44

chalk v5 is now pure ESM


proposal: API change: export normal functions instead of methods

Memguard currently exports a lot of methods, almost none of which are associated with interfaces. It would thus probably be good to replace the methods in Memguard with the usual functions, because of the performance overhead of methods.
Note that this does not conflict with https://github.com/awnumar/memguard/issues/68 , as additional methods to implement io interfaces can be added later.

Can you give an example?
Do you mean, for example, replacing func (*LockedBuffer) Bytes() []byte with func Bytes(*LockedBuffer) []byte?

Yes.

I have serious doubts that would impact performance in a significant way, especially relative to the heavy lifting being done within the methods themselves. I am happy to be proven wrong, but the benefits would have to outweigh the loss of ergonomics and the breaking change to facilitate them.

almost none of which are associated with interfaces

Why is this of note?

I might be misremembering that whole "methods have performance overhead relative to non-receiver functions" thing, sorry. I thought that there is additional run time indirection associated with method calls, but after searching the web I can not find any mention of that and I can not be bothered to check the assembly currently, so I am closing the issue, at least for now.

BTW, what I am sure of is that interfaces have a run-time cost, but that does not matter for Memguard.


misc fix for discovery server

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


App Is Unstable

After the build is completed .
My app is getting crashed on the first click and its throwing error Unable to connect

What's your host machine?
If using Ubuntu, check my comment in #24 and retry to see if it helps...

@KeshavReddy08 -  I have 1) updated the code and readme 3) pulled down to my local version and was successfully able to build and deploy the application. So I would suggest that you  - start fresh : 1) pull the latest code 2) clear out all your images using a docker stop and docker rmi commands 3) make sure you have the right version of node by installing nvm and pointing to the node version 8.11.3, docker 1.8 and npm 5.6.0. 3) Then dependent on your platform- run the right build command and everything should work.


Method comparison by description

Rationale: if one create a Method.other(method: "GET"), it will not be equal to .get, and I suppose it should be. == are all about comparing values, and does it matter how that value is described?

This makes sense. Methods are case insensitive so they should be compared that way.


Profiles view

Signed-off-by: Liam Barry Allan<EMAIL_ADDRESS>Changes

Removes profile buttons from User Library List view

Only shows add button when user doesn't have any profiles in this view

When user has one or more profiles, the profile view is active
Clicking on the profile will change it
Right click options for profiles to save/overwrite and delete.

Implements #758.
Checklist

[x] have tested my change
[ ] updated relevant documentation
[x] Remove any/all console.logs I added
[x] eslint is not complaining
[ ] have added myself to the contributors' list in CONTRIBUTING.md
[x] for feature PRs: PR only includes one feature enhancement.

@chrjorgensen Are you interested in leaving a review on this for me?

@worksofliam Sure - I'll be back! 😃

@chrjorgensen I have made all the changes and fixed all labels. Please review whenever you can. Thanks!!

@chrjorgensen Spelling corrected.

Thanks for your reviews here @chrjorgensen!


Update FOSSA Readme Badge

I've updated the FOSSA badge to the one that uses our project data:
https://app.fossa.com/projects/custom%2B25591%2Fgithub.com%2Fdetekt%2Fdetekt?ref=badge_small

Clicking the FOSSA link in the readme results in an empty page.

Clicking the FOSSA link in the readme results in an empty page.

My bad, I forgot to update the visibility from private to public. Now it should be visible.

It works now 🎉


[No merge] Debug llama for to_static and prim

PR types

PR changes

Description
Debug llama for to_static and prim.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jeff41404:x: cyber-pioneerYou have signed the CLA already but the status is still pending? Let us recheck it.


Can I add a condition for result dependency operation

class SyncData: GroupOperation {

     init() {

          let fetch = FetchDataOperation()
          let store = StoreDataOperation()

          store.injectResultFromDependency(fetch)
          let gop = GatedOperation(store) { () -> Bool in

                 return true
          }

          super.init(operations : [fetchCities, gop])
     }
}

In the above code,
fetch is fetching data from the remote
store is to save the fetched data in certain conditions only
so, I need to add a condition for store operation and the result is from the fetch operation.

Well, the .injectResultFromDependency() does this for you. It sets up the dependency relationship and observers which will inject the result into the receiver as its requirement.
You will also want to add a condition to ensure that all dependencies must succeed to perform the store:
store.addCondition(NoFailedDependenciesCondition())

I want to check the success result data manually and decide whether to store data or not.

Okay then, you can use a block
store.injectResultFromDependency(fetch) { op, dep, errors in
    // Here we have access to both operations, plus any errors
    // from the dependency.
}

See Injecting Results in the programming guide.


Syncing notes and extracted annotations to Notion database

Hi,
I'd really like to thank you for providing such an amazing plugin. I am really grateful since this simplifies my workflow by a significant extent and saves me a huge effort.
However, as part of my workflow, I do annotate and comment in the pdf files attached to every item in my zotero collection. I use the zotfile extension to extract those annotations out as a separate item. Is it possible to sync these extracted annotations to notion as well?

I think notes generated by user should be sync to notion database too.

Hello! @dvanoni , I just set up this plugin and I am so happy with it!
I am here to offer my +1 to exporting both annotations and notes generated. My 2 cents toward making this scalable are : each annotation goes under the heading "annotation" and each note's content goes under the heading {note name} in the body of the page.
Thank you for making this for us. You deserve an honorary PhD for helping out us academics.

@jigarp12892, thank you for the kind feedback! 😊
I think your suggestion sounds like a great approach!

@jigarp12892, thank you for the kind feedback! 😊
I think your suggestion sounds like a great approach!

I understand you have other commitments would like to help with anything that can make it easier for you.

This would be the exact functionality I've been looking for! Less for writing papers, but would allow my co-surgical residents and I to generate a more organized, communal annotated bibliography of key papers that guide clinical practice. Currently nothing is out there makes it easy to navigate notes linked to a bibliography and the paper itself. Thank you for the already awesome tool you've created!

This would be a super nice feature, and can let people get main idea or valueble part of articles with a glance, as a PhD or researcher, this save lives when facing tens of hundreds PDF files!🤗

I'm totally agree it's very useful features. I want to try to implement it.  @dvanoni What do you think about it?

hi @dvanoni，notero is an ideal plugin for me!! thank for your great job!
i think it's a way to sync the annotations as “Toggle Headings”. First, add the annotations as a “page” in the main body through API. Second, change the “page” to “Toggle Headings” in notion by users themselves. when there is a new update in zotero, just sync a new page and deleted the old toggle headings. it may be not a directly way, but i think it' s a way.

Hi,
I am also adding my +1 to this idea! But, I wonder if it could be an option whether to do this syncing or not? I worry that having hundreds of annotated PDFs in a Notion page will drastically reduce the load speed. Is that a real concern?

@mtillman14 to be honest, I have no idea what the impact would be on Notion load speed, but I think it's a good point to bring up! Either way, I think making this feature configurable is a great idea. I imagine that some folks might not want to sync annotations as part of their workflow, so providing the flexibility to choose whether to enable this feature sounds smart to me.

+1 to sync annotations! TBH, I thought that Notero already did that, and it was a big part of why I just installed it.
I liked @dvanoni 's structure for how to include annotations, at least conceptually. I have no idea about implementation issues.
One additional possibility: It would be nice if the color of the annotation was also preserved in the Notion page - this might help when visually scanning through them, so it's not just a wall of text?
Would image/area annotations also be synced?

I like all of the ideas proposed here, and if I may add another suggestion for an option, I would like to embed the PDFs that I have stored in Zotero's storage in the Notion page so that I have my marked up PDF within the Notion database. It is possible to manually do this right now, so if Notero could have an option to add an embedded URL as a page block that would be awesome! Echoing everyone here, thank you for making this plugin!!

@advaitathreya thanks for the feedback!
I'd love to be able to automatically embed PDFs, but unfortunately it's currently not possible due to limitations with Notion. See the How to sync attached files into Notion section of the readme for more details.

Looks like uploading local files automatically is not possible, but how about embedding PDFs of Zotero Storage files?
It looks like embedding PDF URLs is possible through the Notion API.
Retrieving the PDF view URL for the zotero item should be possible through the getBestAttachment method, and then modifying the URL to be of the form expected (Zotero file view URLs are of the form https://api.zotero.org/users//items//file/view?key=).
I've been trying to do this and I think I have parts of it that are working, but I've never worked with JavaScript or APIs before, so I'm struggling with a few aspects. I will see if I can get a rudimentary working script to share, but maybe this would be faster for you? Or maybe I am completely off and it isn't possible, in which case apologies 😬

I think it would make sense that the notes sync can be configured to be either (1) Text in the body of a notion page or (2) An actual item field of the note called "Annotations"
(2) is convenient for short notes, but can affect load time. Anecdotally, from using Notion as a bibliography tool: If you put a large amount of text in the body of the page, this will not affect load time.  However, a large amount of text as an item field will affect load time.

i think it's a way to sync the annotations as “Toggle Headings”.

In regards to the suggestion from @mai-m-ai above, the Notion team just added support for toggle headings to the API!

i think it's a way to sync the annotations as “Toggle Headings”.

In regards to the suggestion from @mai-m-ai above, the Notion team just added support for toggle headings to the API!

How can this be used to transfer annotations?

@advaitathreya thanks for the feedback!
I'd love to be able to automatically embed PDFs, but unfortunately it's currently not possible due to limitations with Notion. See the How to sync attached files into Notion section of the readme for more details.

I wonder if the PDF itself truly has to be embedded... I feel like the goal is to have everything in the same place, minimizing the number of different apps. Now that Zotero has a more robust PDF reader/annotation tool (with associated iPad app), I wonder if the PDF truly needs to be embedded into Notion (particularly if the PDF annotations become tough to sync).
I tried to create a simple workaround that failed (just appending "/reader") to the Zotero URI in a notion table formula. Unfortunately Notion formulas can't output a URL. The web-based reader also doesn't allow annotations (yet). Would be nice if a Zotero URI link could just open the PDF in the desktop app.

Hello,
Thank you so much for the plugin,
+1 for this ideas  "sync annotation"

I am looking forward to it. Currently, I have to take notes in zotero, export the markdown note, and paste it in Notion. However, the zetoro link is missing, so it cannot get back to zotero. Could you please also consider this in the future? THANKS!

+1 for  "sync annotation"

Hi, @dvanoni ,
Let me first tell you how much do I appreciate your work on zotero-notion bridge. I see that there have been quite quiet here in the past 3 months.. I understand that this have been more of a passion protect for you to help your partner with research. Notero has indeed become so much bigger!
Thank you for great work and hope you keep it up!
/+1 for notes sync from me ;)/

I like the idea of having the some short notes in the properties column.
I'm using a variation of the Advanced Database example, in the literature review view:

A possible idea for a workflow:

Define the names of your Notion database properties in Notero.  For this example, it would be, Relevance, Problem or Purpose, etc.

(A) Notero creates a new note in Zotero with those properties as subheadings
( I would prefer this one but maybe it's harder to split the text and send it to Notion?)

(B)  Notero creates separate notes for each of those properties

the text that you add under those notes gets pushed to the Notion database in that item property.

Absolute +1! This would complete the workflow! I think a simple text addition to the notion page under a defined heading like "Annotations" would suffice.

Hello, thank you so much for the plugin! Here to +1 for this ideas "sync annotation"

+1

I'd also like the +1 this as this would be the most useful feature of Notero for me. It would be important that the Zotero links to pdf ie (example, 2017, p. 152) (pdf) were copied as links to Notion to. I currently can't find a way to do this, but I don't want tp use Obsidian which supports this.

Absolute +1!

Hi everyone! I wanted to share a quick update to let you know I'm still working on this!
It turns out that converting HTML into Notion blocks is no small feat, but I've been able to make progress. I'm now able to sync most of the formatting supported by Zotero.
Once I have this in a state that's more usable, I'd love to know if anyone wants to try a test build to help me find any bugs. In the meantime, please enjoy this short video I recorded demonstrating various note formatting being synced into Notion.
Cheers!
https://user-images.githubusercontent.com/299357/232381123-40eb28a2-edcb-4354-9536-6b9efb1f1385.mp4

I am super stoked for this, that looks great also happy to help with testing.

Thanks for all your amazing work, this will be a super helpful addition! I found this thread because I was looking for a similar functionality, that I'm not sure is included in this update (or maybe it is and i'm not catching that.) I'm working with the notero advanced database template. As I read through papers in Zotero, in addition to my own typed notes, I annotate the papers by highlighting a section of text and noting which column of the literature review tab they fit into (Relevance, Problem or Purpose, etc..). When I finish reading, I go through and cut and paste the highlighted text into the appropriate column in notion. I was wondering if it would be possible to automate this- my thought was to add a tag to the highlighted text in Zotero that specifies the column in notion where the text should be copied. I have no idea if something like this is complicated, or possibly you have already addressed it here?

Hey @SofiCourtney, thanks for the suggestion! I think this is a really interesting idea and something I'd like to explore.
I've pulled it out into its own issue (#256) because I do think it's a separate scope from this one. This issue is focused on syncing notes and annotations content into the body of the Notion database page so that it can support most of the formatting available in Zotero notes. Syncing content into specific database properties would work slightly differently because properties don't support as much formatting. I think we'd also need a way to specify which Zotero tags should map to which Notero properties so that folks can customize as needed.

It’s finally (almost) here, thanks for your great work dvanoni! Happy to help with testing.

Hey everyone! I've just released version 0.4.8 which includes initial support for syncing notes!
I'd love to get feedback from y'all on how it works for you. Please see the release notes for details on how to use it.
Please note: this first release requires you to opt in to this new functionality by enabling it within Notero Preferences, and it does not sync notes automatically. Automatic syncing is planned for a future release.

Thanks so much for working on this update (and this plugin overall, which is a lifesaver). One quick note from playing around with the experimental feature for syncing notes is that the highlight colors, even when turned on in Zotero, don't appear to sync over to Notion at the moment. I'm not sure if that's a feature that's yet to be released, but I saw it seemed to be supported in the release notes, so I thought it would be worth mentioning.

Hi @dmshapiro, thanks so much for testing this!
The current release does include support for syncing highlight colors, but it does have a limitation right now. It currently only syncs the highlight colors if they're exactly the same colors used by Zotero (defined here).
I believe this should work if you've performed highlighting within Zotero's built-in PDF reader. But, if you've highlighted in a different PDF tool, I think the colors can end up being slightly different than Zotero's colors.
Can I ask how you highlighted your PDFs?

Ah, that makes total sense. I’m using what is almost certainly a different set of colors in Adobe Acrobat, using ZotFile to sync the files between Zotero and my Google Drive. If you’re able to include support for custom-defined colors that would be super helpful, but I understand that because Notion has a limited set of highlight colors that might be difficult to delineate between which colors should correspond with which in Notion.
On Jul 30, 2023 at 5:31 PM -0400, David Hoff-Vanoni @.***>, wrote:

Hi @dmshapiro, thanks so much for testing this!
The current release does include support for syncing highlight colors, but it does have a limitation right now. It currently only syncs the highlight colors if they're exactly the same colors used by Zotero (defined here).
I believe this should work if you've performed highlighting within Zotero's built-in PDF reader. But, if you've highlighted in a different PDF tool, I think the colors can end up being slightly different than Zotero's colors.
Can I ask how you highlighted your PDFs?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@dmshapiro, would you be willing to share one of your highlighted PDFs with me? I'd like to see an example of the colors coming from Acrobat. If you're up for it, feel free to share to my email<EMAIL_ADDRESS>I'm hoping I can come up with a more flexible solution so that, if a color is "close enough" to one of the known highlight colors, then it will be correctly reflected in Notion.
Thanks!

For sure, I’ll send that over.
On Aug 2, 2023 at 2:21 AM -0400, David Hoff-Vanoni @.***>, wrote:

@dmshapiro, would you be willing to share one of your highlighted PDFs with me? I'd like to see an example of the colors coming from Acrobat. If you're up for it, feel free to share to my email: @.***
I'm hoping I can come up with a more flexible solution so that, if a color is "close enough" to one of the known highlight colors, then it will be correctly reflected in Notion.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hi, thanks for developing this brilliant plugin. I tried out the new annotations and notes integrations feature (thanks for adding that too). I was able to sync my notes but not the annotations. Am I missing something here?
Also, the images in the notes didn't sync, but I am guessing that it is due to the lack of support for multimedia in the Notion API.

Hi, thanks for developing this syncing functionality! I am using it right now and it works very nice. The only feedback I have is that I would like to change toggle heading 1 to be toggle heading 3 and stay the same while syncing.

@asimukaye, I'm glad you found that workaround for extracting annotations to a note. Currently, that's the only method supported for syncing annotations. And you're correct about the limitation regarding images—that's currently not supported by the Notion API.
@ThomasDeLange, could you clarify which toggle heading you're referring to? In the below screenshot, are you referring to A or B? Perhaps I can make this a configurable option so that users can customize to their liking.

Hi @dmshapiro, I just released v0.4.10 which contains support for highlight colors other than Zotero's. Can you give it a try and let me know if it's working for you? Thanks!

@dvanoni To make it a little complicated: I would love A to be dropdown heading 2 and B to be dropdown heading 3. This fits my notion page the best. Finally the text in B is also referenced again below. Would it be possible to remove that part?
But, this is all cosmetic and the functionality works great anyhow.

@dvanoni thanks for adding this great import of notes and annotations feature! In my tsting, it works flawlessly, it even imports notes made within the PDF, but in that case, the author of the note, which is part of the zotero note:

is not synced. It would be great if this could be added, as it is important esp for collaborative work

Hi @menelic, thanks for the kind words. 😊
I think your request makes sense, though I think it will be a bit tricky to implement since the annotation authors don't appear to be present in the notes that are created via the "Add Note from Annotations" feature. I've pulled this out into #332 so that we can keep track of it separately.

Thanks so much for your work on this plugin. Can I ask about functionality?
At the moment, Notero automatically adds a Zotero entry to my Notion database as soon as I added it to a monitored collection. However, it doesn't automatically extract annotations from Zotero. I have to manually right click and 'sync to Notion' for this to happen. Is this the intended functionality or have I missed something in the setup?
Thanks!

Hi @cappuccinomonkey, thanks for your question!
This is indeed the current functionality, but I'm working on adding automatic syncing of notes. Once I have it working, any notes you have for synced items should automatically sync along with the item.
I'll be sure to post in this discussion once this is released!

Hey everyone, I'm super excited to share that automatic syncing of notes is finally available in v0.5.0! 🎉
Please give it a try and let me know what you think!

Awesome Dave, thank you so much !
Would it be possible to not have a few levels of indentation ?

Hi @Pierre-Debraux, thanks for the feedback already! I'm going to follow up with you in #316 so that we can keep that related discussion together.


How best to autogenerate (or not) our add_[layer] methods and view_[layer] functions

We've gone back and forth a few times with our add_{image,labels,points,...} methods, which are shortcuts for add_layer(layer_instance) for the appropriate layer time, and view_{image,labels,...}. My summary of the pros/cons:
For autogeneration:

when the code is not autogenerated, the various docstrings, argument lists, etc. need to be kept in sync in many places in the code. You can see in e.g. #1616 that 12 docstrings needed to be updated when adding affine/rotate/shear to the layer transformations. If the docstring needs updating based on review, that's another 12 edits for one comment. This is a significant burden on development.
synchronisation of all the docstrings, parameter lists, etc. is trivially correct.

Against:

Some IDEs such as VSCode/PyCharm work on static analysis, so perfectly valid and common code such as viewer.add_labels(segmentation) gets flagged as incorrect — no such method.
The autogeneration logic can be complicated to follow. When it breaks (e.g. if a new layer gets added that requires special handling), it can be hard for a newcomer to see what's wrong or where to make edits. @Carreau in particular reminded me in a video conversation of the importance of having simple code and simple processes for a project to be friendly to newcomers. Actually the other day I was perusing our so-called "good first issues" and there was not a single one I thought was actually easy 😂

Some proposals:

do automatic docstring generation/harmonization, but have the actual functions written down.
use .pyi stub files to indicate that these things will be generated. (doesn't solve the code complexity issue, but solves the IDE issue)
"statically" generate code once, e.g. at install time, with import-time checks for staleness for editable installs.
something else?

CC @Carreau @sofroniewn @tlambert03 @kne42 @Czaki

Did we need docstring synchronization for something else than generating documentation?
maybe something like:
def add_image(.. list of args ..):
	"""
    For documentation see :py:meth:`Viewer.add_image`
    """
    some stuff

if os.path.basename(sys.argv[0]) in ["sphinx-build", "sphinx-build.exe"]:  # pragma: no cover
    add_image.__doc__ = "long doc from `Viewer.add_image`"

use .pyi stub files to indicate that these things will be generated. (doesn't solve the code complexity issue, but solves the IDE issue)

this is something I'm 100% in favor of... have been meaning to submit this PR for a while (due to autocompletion stuff in IDE)

"statically" generate code once, e.g. at install time

I'm luke warm on this: doesn't seem to be all that much easier for a newcomer to understand.

do automatic docstring generation/harmonization, but have the actual functions written down.

wouldn't be that opposed to this.  in fact, perhaps we could even have a static generation script for convenience of regeneration/testing, and check the result into source?


initialize zp, scale loaded from HF quantizer, applying quant_config

When base models are loaded using HF quantizer, weights are frozen.
ZP and scale attributes do not exist. If not quantized, set it to Initialize.
Tests in HF quantizer:
https://github.com/neuralmagic/transformers/pull/102

@dsikka can you confirm that this will be handled by your observer refactor and we'll be able to close this out?

Is this for a dense model? Why are zero-points and scales missing?
Please expand in the PR description + provide an example model with this issue @horheynm


Update ps_wirepayment according to validator

Hello @PrestaEdit, thanks for your contribution, would you mind to rebase your pull request for fixing conflicting files ? Thanks

Hi everyone, it seems this PR was not updated since 5 years and @Progi1984 got no answer since 1 year. This Pull Request is stale it seems.
I guess the author did not want to continue this PR after waiting for years 😞 sorry about that.
I close this PR, following our review guidelines "Pull Requests may be closed after 30 days of inactivity".
If however you are still interested in it, please ping us 😊  we can reopen.


'Workspace "default" already exists' error when making a change to a project configured with digger.yml

Reproduced with https://github.com/diggerhq/francios-tests/pull/9
https://github.com/diggerhq/francios-tests/actions/runs/4798029175

https://github.com/diggerhq/digger/pull/167/


Speed up the WCGI path

Some ideas to test out:

[x] Add a mapping of file extension to special handlers using dynamic dispatch in order to have an instance of a handler that can cache state and reuse the engine.
[x] Maintain a cached copy of a pre instantiated module based on the last modified time stamp in the file metadata.
[ ] Make the module cache optional and configured via a CLI flag.
[ ] Add a preload flag to serve so the server will pre-compile all WCGI scripts.
[ ] Watch the cgi bin directory for any file changes related to wcgi files.

I updated the server to generate the wasm and process scripts. Now wasm and process have a single instance per server stored on the server context.

Re-using the engine had no discernible difference in performance yet.

The notify crate could be used to listen for deletes.
Alternatively, I could use glob to list all of the paths that still exist and then delete any paths that no longer exist. Also, could list the cache keys and check if the file it points to still exists; deleting the entry if not.

Instead of watching the directory, I will just scan periodically.


add: Support root.schematicDisabled to skip schematic rendering #371

Description:

added schematicDisabled prop to Circuit class to automatically apply to its instance root.

Reference Issue:
Fixes #371
/claim #371

@imrishabh18 in this case i recommended it be implemented on the root circuit instead of as a subcircuit prop, although a subcircuit prop is acceptable too. My reason for this is it's more of a platform parameter than a circuit parameter, e.g. if someone selects a schematic or pcb view, the platform (snippets) should be able to say "only render schematics"
that said, @Anshgrover23 this is sort of a a low quality PR, you didn't include any testing. I'm closing this PR. Please don't re-attempt because based on the code here you didn't understand the issue and we've spent a lot of time helping you on PRs, be more careful in future issues. When you open a PR, make sure you understand the code and create tests that demonstrate you completed the issue.


Reinitialize PK ctx in mbedtls_pk_parse_key() before reuse are free

Context: This commit makes a change to mbedtls_pk_parse_key() which
is responsible for parsing of private keys. The function doesn't know
the key format in advance (PEM vs. DER, encrypted vs. unencrypted) and
tries them one by one, resetting the PK context in between.
Issue: The previous code resets the PK context through a call to
mbedtls_pk_free() along, lacking the accompanying mbedtls_pk_init()
call. Practically, this is not an issue because functionally
mbedtls_pk_free() + mbedtls_pk_init() is equivalent to mbedtls_pk_free()
with the current implementation of these functions, but strictly
speaking it's nonetheless a violation of the API semantics according
to which xxx_free() functions leave a context in uninitialized state.
(yet not entirely random, because xxx_free() functions must be idempotent,
so they cannot just fill the context they operate on with garbage).
Change: The commit adds calls to mbedtls_pk_init() after those calls
to mbedtls_pk_free() within mbedtls_pk_parse_key() after which the
PK context might still be used.
Internal Reference: IOTSSL-1706.

@mpg Amended the commit. Could you please re-review?

Do we need backports for this?

retest

Marking as 'needs backports' until someone tells me why it doesn't need backports.

Backports opened: https://github.com/ARMmbed/mbedtls/pull/2136 and https://github.com/ARMmbed/mbedtls/pull/2135.


Add version to client instance

TODO:

[ ] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
[ ] Make sure all of the significant new logic is covered by tests
[ ] Rebase your changes on master so that they can be merged easily
[ ] Make sure all tests and linter rules pass
[ ] Update CHANGELOG.md with your change
[ ] Add your name and email to the AUTHORS file (optional)
[ ] If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

It looks like you released this. Don't forget to merge.

Gosh, thanks.


Control fragment edition by command line

As an user I want to be warn which policies are going to be afected when updating a fragment so I can know which policies I am afecting
As an user I want to be warn that I cannot modify a fragment of a policy running so I cannot brean anything

Issue migrated to JIRA.


Separate DB context needed to add custom user data?

Why is a separate database context is required to have a custom user model when scaffolding identity? This seems to lead to conflicts that need to be manually resolved if one creates a WebApp with identity enabled since the start and then decides to customize, or am I missing something and it is possible to re-use the same DB context and add a custom user model?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 431df4fc-4168-cc8f-d053-9b264d2971c1
Version Independent ID: cd157d04-d596-83fa-6edb-24d52193eb34
Content: Add, download, and delete custom user data to Identity in an ASP.NET Core project
Content Source: aspnetcore/security/authentication/add-user-data.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

My apologies: I found this blog post https://blogs.msdn.microsoft.com/webdev/2018/03/02/aspnetcore-2-1-identity-ui/ which answers my question.

@AlbertoPa  as you found out, it's not required. The article doesn't say it's required.


How to attach payload?

Can you provide any examples on how to attach payload?

@besciualex spectacular.  Thanks for your guidance.  Much appreciated!


Is there a way to insert a line break

Hi @AgeevAndrew @Kirillvs,
I wonder if this is possible,
I tried \ n and <w: br />
It shows that the document as a string has a way to manipulate it?
Thanks

Hi @itayariely, I've just seen your issue.
If it is still actual for you - yes, the way is to use "\n".
"\n" will be converted to "<w:br/>".
However, sometimes, this tag is not appropriate for the context. And there are no linebreaks at the document.
I will think about that

Hi @AgeevAndrew ,
Again I try to make it work,
I would love to convert html to openXML into the docx template but in the first step we will start by breaking a line..
if only pass "foo\nbar" the output is: "foobar"
when useing gsub: "foo\nbar".gsub(/(?:\n\r?|\r\n?)/, '<w:br/>') the output will be: "foo<w:br/>bar"
how do I make him consider the string as xml tag?


Model loading from other sources.

Super satisfied with the speed, thanks for such an amazing tool.
for TensorRT engine building:
Is it possible to get a feature, that its possible to load the model from HDD instead of huggingface?
Or if its already possible, how?
Also, if the feature is being planned, is .safetensors extension support possible in the future?
Thank you for your consideration.

You can load your local diffusers model. For Docker, the folder must be mounted in advance.

Any info how to actual do it?

Gets me this error:

I am using Local version ( not docker ).

@knot2006 it needs to be converted into diffusers format first. As far as my understanding goes, this is not possible yet.

I really hope this can be done. I want to use my custom trained models directly from SSD without uploading to hugging face.


Tests

I found this https://github.com/data-apis/array-api-tests. Wonder if it’s any useful?

It should. I'll try if I have time.

The framework is too difficult to use.


Use NULL to indicate uninitialized VLOG_IS_ON site.

This PR eliminates the kLogSiteUninitialized variable and use NULL to indicate uninitilized VLOG_IS_ON site.

@googlebot I signed it!
On Apr 26 2020, at 11:02 pm, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/0?redirect=https%3A%2F%2Fcla.developers.google.com%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLAIndividual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/1?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/2?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (http://go/cla#troubleshoot) (Public version (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/3?redirect=https%3A%2F%2Fopensource.google%2Fdocs%2Fcla%2F%23troubleshoot&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D)).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/4?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/5?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
The email used to register you as an authorized contributor must also be attached to your GitHub account (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/6?redirect=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
ℹ Googlers: Go here (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/7?redirect=https%3A%2F%2Fgoto.google.com%2Fprinfo%2Fhttps%253A%252F%252Fgithub.com%252Fgoogle%252Fglog%252Fpull%252F542&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/8?redirect=https%3A%2F%2Fgithub.com%2Fgoogle%2Fglog%2Fpull%2F542%23issuecomment-619684063&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/CE6B1041-F12C-49E6-A2D7-8E5CFAABA1A3@getmailspring.com/9?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEA4EHVGCDE3N3IIPAWTJHDROTYUVANCNFSM4MRRGQPQ&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).


Automated backport of #2897: Workaround for ROKS datapath configuration

Backport of #2897 on release-0.17.
#2897: Workaround for ROKS datapath configuration
For details on the backport process, see the backport requests page.

cc @vthapar @aswinsuryan


Why $attachment->getAttributes()  always contain "type" => "text"

When i get message "jpg" attachments attributes
$attachment->getAttributes()  always contain "type" => "text"

Hi @jazz-max ,
many thanks for your report. Unfortunately this is the wrong repository.
Please head over to https://github.com/Webklex/php-imap/issues/new?assignees=&labels=&template=bug_report.md and try to be as precise as possible. Also consider to add some example date which would be required to replicate the issue.
Best regards,


Use configure to detect the right make command

The initial discussion started in #157 and #159. At the moment we have makeCommand in Settings/User.hs which has to be set manually.
We should instead add the following to system.config.in:
make = @MakeCmd@

And ask configure to set @MakeCmd@ to make or gmake using the approach outlined by @kgardas here: https://github.com/snowleopard/shaking-up-ghc/issues/159#issuecomment-171243085.
This is similar to what happens with many other Builders. I'd appreciate if someone familiar with configure picks this up.
What needs to be done:

[ ] Submit a patch to GHC's configure.
[ ] Remove makeCommand.
[ ] Add make as a Builder.
[ ] Fix runMake function in Rules/Actions.hs.

configure machinery done here: https://phabricator.haskell.org/D1775

@kgardas Awesome! Once this is in GHC HEAD I can take care of the rest.


Conscrypt 2.2.1 release

https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/conscrypt/05b7227B9to/QxWewCTMCgAJ

We're pleased to announce that we've released Conscrypt 2.2.1.  This release includes the following notable changes:
== AES-GCM-SIV ==
We've added support for the AES-GCM-SIV AEAD construction, a nonce-misuse resistant AEAD, under the identifier AES/GCM-SIV/NoPadding.  For more information on what it is and when you might want to use it, we recommend you read Adam Langley's discussion at https://www.imperialviolet.org/2017/05/14/aesgcmsiv.html.
== Other Changes ==

Added an implementation of available() for SSLSocket's InputStream and fixed the existing implementation in the engine-based socket
Improved compatibility with Android Keystore keys
Fixed some issues in the SSLEngine implementation where API methods weren't implemented as documented

Thanks!
Weird that they added a big feature in a patch release.

3 hours difference between .0 and .1. So bad release?


Product Page not working

Hello,
I installed uwebshop <IP_ADDRESS> on umbraco latest version , after successful installation..
The website homepage , basket , profile page working fine ,
But product page is not displaying, its keep on saying too many redirection. Please help...

Same issue even in the previous version of the Umbraco too...


Recommend notification for Mac OS X

notify-send doesn't work on OS X. As best as I can tell, there's no command installed by default to trigger a notification. We should probably recommend one, and perhaps, if we're feeling generous, provide an easy way to install it (perhaps make undistract-me a brew package?)

6 years later, finally: Just use osascript -e display notification "is done" with title "Job"


Generate wave resource JPD file from multiple years of time series data

Description
New feature that takes a folder of downloaded wave resource time series files and generates a joint probability distribution of wave height and wave period from the time range to then be used in Frequency of Occurence resource definition within SAM. Feature can be used from SAM menu or user is prompted after downloading wave resource data from the API.
May require a beta version from patch once merged (operating system to be determined).
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

@mjprilliman,

Why are there so many CSP file changes in this pull request?
What exactly should we be testing? Do you have a SAM file or steps to test?

@mjprilliman,

Why are there so many CSP file changes in this pull request?
What exactly should we be testing? Do you have a SAM file or steps to test?

I built SAM_api in the build process so those api updates must be from previous work that was not updated in the SAM_api
I will add detailed test instructions and files here

Test instructions:
-Download weather files in attached zip file to dedicated folder (nothing else in folder)
-Open a Marine Wave - LCOE Calculator case
-On Wave Resource page, select Time Series option
-Click 'Create JPD from time series file(s) button'
-Follow prompts to select folder containing only downloaded wave files, then file for output JPD file
-Check that file is saved correctly and appears in 'Frequency of Occurence' library with naming convention 'latX_lonX_startyear_endyear'
Additional test:
-Run wave download tool from button
-Download file(s) (must have API calls set up to work from built version)
-Ensure that yesno prompts user to run JPD file generator, same steps as previous test
ME_humboldt_bay.zip

The functionality here is generally good. A couple of comments to improve the user experience:

When I try to download files for all years, if the API call fails, I get a "Weather file not available" message for each file, so I have to click OK a bunch of times. I would expect the download to stop if the API call fails instead of trying for each file. For example, if the API returns "API_KEY_MISSING" the download process should stop after displaying the first "Weather file not available" message.

I think SAM is creating a "SAM Downloaded Device Files" folder in my user folder. Should that be "SAM Downloaded Wave Resource Files" instead?

The "Choose folder" dialog title might be more informative as "Choose folder containing single-year wave resource files."

Please change the "Save MultiYear JPD File as" dialog title to "Save multi-year JPD file as" and the save as type from "JPD files" to "JPD File".

Please change the message text "A JPD file of the time series wave resource data has been generated and can be found on the Frequency of Occurence tab" to "Multi-year JPD file saved.\nTo use the file, switch from the Frequency of Occurrence option to Time Series, and choose " + jpd_name_parameter + " from the library.", where jpd_name_parameter is the name listed in the library. Because the library does not list the file name, it was hard for me to figure out what to choose to get the multi-year JPD.

The Average Power Flux column for the multi-year JPD file shows "nan" in the library list.

@cpaulgilman Can you re-review for user experience when you get the chance? I tried to address all your points in your first review.

Hi Matt,
I tested running the make JPD file feature by following the prompt after downloading single year files, and get this error:

I get a similar error after clicking Creaste JPD from time series weather file(s) as a separate step.

Hi Matt,
I tested running the make JPD file feature by following the prompt after downloading single year files, and get this error:

I get a similar error after clicking Creaste JPD from time series weather file(s) as a separate step.

@cpaulgilman did you rebuild with the latest commits pulled into the branch? I'm not able to replicate that error. Every other branch (ssc, lk, wex) should be patch.


Add team members to PCF Apps Manager

Add team members Héctor, George, and Cristhian to PCF Apps Manager

@Gerg could you merge this PR as well? thanks!


spriteFilename naming pattern

Hi, when using file-loader, I use [sha1:hash:base36:10].[ext] naming pattern for extracted files, but I am unable to use the same configuration for svg-sprite-loader (@3.1.5). Pattern [hash:base36:10] somehow works, but I am unable to define hashType. Setting spriteFilename to [sha1:hash:base36:10].svg creates a file named [sha1:hash:base36:10].svg :-).
Is there a way out? Thank you.

Use spritehash instead of hash - [sha1:spritehash:base36:10]

Is that supposed to work? For me spriteFilename: "assets/[sha1:spritehash:base36:10].svg" creates a file named [sha1:spritehash:base36:10].svg.

@vchrm ah sorry, now I get it. It's a bug.

@vchrm fixed in<EMAIL_ADDRESS>

@kisenka Thank you for your work :).


feat: add initial travis-ci integration

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

GitHub release
Atom package

Your semantic-release bot :package::rocket:


Refactoring

Trying to get this package working

Made minor fixes today. The issues I'll work on the first of all are:

See if we need ReservableJobInterface
Redesign events

@samdark, @xepozz, any more high-priority themes to explore?

@viktorprogger do you want this PR merged first?

Merged 👍 . Let's continue in separate pull requests.


newdoc(concepts): intro to webpack

This PR is a WIP, for review and edits, but represents the first rough draft of the Introduction page. This corresponds to #38

Maybe it would make sense to move this as content/get-started.md given the level? content/concepts can dig deeper into loaders, plugins, whatnot.

Overall the article could use some subtitles (## is the deepest level you need).

Nice breakdown of the high level concepts.  It would be nice to add a similar high level description of the plugin concept: when I was new to webpack I wasn't clear on the separation of concerns between plugins and loaders.

Thanks the target for this doc is first time users, so I didn't want to put to much overflow in the users face. So this document will most likely segue into a core concepts document containing more detail about entry output loaders plugins. Thanks for the comment @sethdavenport

Makes sense

I'm not sure I like starting with an explanation of modular programming. It kind of feels like one has to want to be a "modular programmer" to get use from webpack, where modular programming isn't like functional programming something you have to have learned and internalised. Kind of made me want to stop reading since I don't consider myself a "modular programmer".
Don't really know how we could circumvent that at the moment, just wanted to throw it out there! Maybe somebody has a better idea?

I'm not sure I like starting with an explanation of modular programming. It kind of feels like one has to want to be a "modular programmer" to get use from webpack, where modular programming isn't like functional programming something you have to have learned and internalized. Kind of made me want to stop reading since I don't consider myself a "modular programmer".

@mxstbr I agree, I think needs some followup. I will make a todo to find better alternatives for the second revision to this page.


Data can not download.

Hello!
When I tried to download the data from the following links (https://tinyurl.com/ycnn7cd6, https://tinyurl.com/ybj776xe, https://tinyurl.com/y9dwkuwo), I found that all these links were unable to reach. Could you please share your data using google drive or re-upload the data and update the links ?
Or could anyone who has downloaded the data share their own links?
Thank you very much!!

Haha I solved this problem. Wget from tinyurl.com is not work, however, directly download from dropbox using Lantern VPN can work well.


Disable indexing jobs on Google on non-prod envs

Review app deployed to https://teaching-vacancies-review-pr-2929.london.cloudapps.digital


[IT-607] Setup Security Hub

Setup security hub with notifications sent to endpoints.
Multiple protocols and endpoints can be configured.
This template is based on templates provided by
https://asecure.cloud/p/config_securityhub

this PR generates the following templates:

us-east-1-security-central-account.yaml
    AWSTemplateFormatVersion: '2010-09-09'
    Description: SecurityHub notifications
    Parameters: {}
    Resources:
      SecurityHub:
        Type: AWS::SecurityHub::Hub
    Outputs:
      SecurityHubArn:
        Description: The security hub ARN
        Value:
          Ref: SecurityHub
        Export:
          Name:
            Fn::Sub: ${AWS::Region}-${AWS::StackName}-SecurityHubArn

us-east-1-security-central-account.yaml
    AWSTemplateFormatVersion: '2010-09-09'
    Description: SecurityHub notifications
    Parameters: {}
    Resources:
      SecurityHubTopic:
        Type: AWS::SNS::Topic
        Properties:
          Subscription:
            - Protocol: email
              Endpoint<EMAIL_ADDRESS>            - Protocol: email
              Endpoint<EMAIL_ADDRESS>          TopicName: security-hub-topic
      CloudwatchEvent:
        Type: AWS::Events::Rule
        Properties:
          Name: detect-securityhub-finding
          Description: >-
            A CloudWatch Event Rule that triggers on AWS Security Hub findings. The
            Event Rule can be used to trigger notifications or remediative actions
            using AWS Lambda."
          State: ENABLED
          Targets:
            - Arn:
                Ref: SecurityHubTopic
              Id: target-id1
          EventPattern:
            detail-type:
              - Security Hub Findings - Imported
            source:
              - aws.securityhub
      SnsTopicPolicy:
        Type: AWS::SNS::TopicPolicy
        Properties:
          PolicyDocument:
            Statement:
              - Sid: __default_statement_ID
                Effect: Allow
                Principal:
                  AWS: '*'
                Action:
                  - SNS:GetTopicAttributes
                  - SNS:SetTopicAttributes
                  - SNS:AddPermission
                  - SNS:RemovePermission
                  - SNS:DeleteTopic
                  - SNS:Subscribe
                  - SNS:ListSubscriptionsByTopic
                  - SNS:Publish
                  - SNS:Receive
                Resource:
                  Ref: SecurityHubTopic
                Condition:
                  StringEquals:
                    AWS:SourceOwner:
                      Ref: AWS::AccountId
              - Sid: TrustCWEToPublishEventsToMyTopic
                Effect: Allow
                Principal:
                  Service: events.amazonaws.com
                Action: sns:Publish
                Resource:
                  Ref: SecurityHubTopic
          Topics:
            - Ref: SecurityHubTopic
    Outputs:
      SecurityHubTopicArn:
        Description: The security hub topic ARN
        Value:
          Ref: SecurityHubTopic
        Export:
          Name:
            Fn::Sub: ${AWS::Region}-${AWS::StackName}-SecurityHubTopicArn


New release(s)

Hi there - this seems like a very useful tool, can I ask if you have plans to make any updated releases - I see that the code is actively maintained but the last release was in early 2019?!
Thanks in advance

Yes, please make a release of the current code as, say, v0.2.1, to facilitate packaging by Linux distributions.
Many thanks in advance!

Joining the other persons to request a release, they are a fair number of commits and fixes that should have a higher chance to get tested.
Best

v0.3.0 was released on 2021-10-20 (see https://github.com/kumina/postfix_exporter/releases/tag/0.3.0), thanks for that!

@BartVerc close?


[red-knot] Diagnostic for possibly unbound imports

Summary
This adds a new diagnostic when possibly unbound symbols are imported. The TODO comment had a question mark, do I'm not sure if this is really something that we want.
This does not touch the undeclared case, yet.
relates to: #14022
Test Plan
Updated already existing tests with new diagnostics

"The member might be unbound" does feel to me like a distinct thing to "the module just doesn't have this member", so I guess I agree with this being a separate error code... but I also absolutely see @MichaReiser's point about this leading to the number of error codes exploding a bit :/

I understood something different from Micha's question. I didn't understand it to be about unbound-x vs possibly-unbound-x (I think these must be different error codes, and 2x for unbound error codes is a manageable level of "explosion"), but rather about how finely we divide the many different possible x. With this PR, we now have unresolved-reference and possibly-unbound-reference and now unresolved-import and possibly-unbound-import.
I think this is an area where it's worth looking at what other type checkers do. I lean towards separate error codes, and my understanding from mypy is that users seem to demand rather finely-grained error codes. It's also not clear to me what is the concrete cost of finer-grained error codes. It clearly provides more functionality, and the cost of "longer reference docs", while real, doesn't seem to outweigh the user flexibility.
Imports are different in that an unbound-import error may often come from code you don't control. I think another useful guide may be "which things raise different errors at runtime", which would suggest separate codes: unbound name references, nonexistent attributes, missing imports, and missing mapping keys all raise different exception types at runtime.

I think this is an area where it's worth looking at what other type checkers do. I lean towards separate error codes, and my understanding from mypy is that users seem to demand rather finely-grained error codes. It's also not clear to me what is the concrete cost of finer-grained error codes. It clearly provides more functionality, and the cost of "longer reference docs", while real, doesn't seem to outweigh the user flexibility.

The cost here is mainly:

Each rule will come with some boilerplate and needs documenting. This is a one off cost but also leads to more code.
Users ideally don't toggle rules at such a fine granular level and instead use e.g. a rule selector. But every rule adds some cognitive overhead (e.g. the list of rules becomes longer and more difficult to search, it's harder for users to find the rules they care about).

Thanks for the discussion about rule names. I'll leave the fine-grained rule name for now, assuming that we will do a overhaul at some point to enforce consistency across all rules. But let me know if you think something should be changed for this specific rule.


Option remaining selected

Hi,
When I select any option, the other options remain selected.

Also some values appear as [object Object].

Thanks for reporting this. I'll have a look today.

I wasn't able to reproduce this.
Can you update this project file with your code sample so we figure out why ?
https://playcode.io/1799958
Also note I tested with the latest version. But feel free to update the package.json to your version and we can go from there.

Hello, also i am using latest verision, here is my code sample
https://playcode.io/1800213

Hello, also i am using latest verision, here is my code sample
https://playcode.io/1800213

Quickly had a look. The issue is your id field is not unique for each node.
In way older versions you had to explicitly specify one. Now, you don't. If an id field exist we will use that else we generate a unique one. I removed all id fields and it worked as expected.
I'll leave this open for a day if you have any further feedback on the same issue, after which I will close.

Thank you, it's my misunderstanding 👍


Proposal for Mini Social Networking Project

The objective of this project is to create a simplified social networking platform that allows users to register, log in, and interact through posts, comments, and likes. This project will help us understand the intricacies of web development and user interface design while applying our knowledge of HTML, CSS, and JavaScript.
Key Features:
Post Creation: Users can create, view, and delete their posts.
Interaction: Users can like and comment on posts, fostering engagement.

Hey I am the mentor of this project
@ArpitaAgrahari  Hello Thank you for opening the pull issue and you can opening new issue by creating the new concept those are not exist in the project !!
@Kushal997-das kindly close the issue since it already exist in our project.

Hello @ArpitaAgrahari ,
Mentor @SakiraAli1115 is inquiring about something. If you’re not serious about addressing it, this issue will be closed by the end of the day today. @SakiraAli1115, please go ahead and close it if he does not respond by then.

Hello @ArpitaAgrahari ,
Mentor @SakiraAli1115 is inquiring about something. If you’re not serious about addressing it, this issue will be closed by the end of the day today. @SakiraAli1115, please go ahead and close it if he does not respond by then.

Okay