Room name not showing in desktop notification

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in with user A in desktop
Receive a notification from any room

Expected Result:
Room name to show in notification
Actual Result:
Room name not shown
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.90-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679913165835669
View all open jobs on GitHub

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reproduced on desktop!

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

@jules, assuming you want to keep this one internal?

Yeah, for now.

Sounds good!

@Julesssss @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Julesssss @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Going to finish reproducing on the other platforms today.

Defer to @Julesssss on whether we're close to a solution here.

This is held on other notification issues. Reducing the priority, but I can pick up soon.

@Julesssss @joekaufmanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

This is actually a new feature, so I'm removing the label. I don't this this breaks WAQ personally, but will get this done.

Sounds good! Added new feature label to reflect that.

Sounds good!

I believe this is still pending implementation after manual requests

I probably should have realized this earlier, but now I'm thinking we could just open this up for external contributors... What do you think @joekaufmanexpensify?

It's a small enough fix that it shouldn't be blocked by any manual request stuff.

Sure, sounds good to me!

Re-adding weekly as my understanding is that is default for new feature label.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room name not shown in desktop notification.
What is the root cause of that problem?
This is a new feature, currently we only show the name of the person sending the message as the notification title as can be seen in https://github.com/Expensify/App/blob/9eccde14cd8a0b5ce7fa1f53cce71fad9ef46807/src/libs/Notification/LocalNotification/BrowserNotifications.js#L107
What changes do you think we should make in order to solve the problem?

In https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/libs/actions/Report.js#L1369, we need to get the full report from allReports: const report = allReports[reportID];
If the report.chatType is one of the 5 room types here https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/CONST.js#L490, we'll pass the report.displayName into  showCommentNotification here https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/libs/actions/Report.js#L1371 as roomName.

If we only do for policyRoom, other room types like #admins, #announce won't work.

the roomName will be passed through to the pushReportCommentNotification in https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/libs/Notification/LocalNotification/index.desktop.js#L4 and https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/libs/Notification/LocalNotification/index.website.js#L4

In https://github.com/Expensify/App/blob/3deeed90687b1008f8cb585a97b2ed156b441f29/src/libs/Notification/LocalNotification/BrowserNotifications.js#L99, we define the notification title as

let title = roomName ? `${plainTextPerson} in ${roomName}` : plainTextPerson;

The "[person] in [room]" notification title format is the correct one to use, it's currently like that on Android & iOS as well.
What alternative solutions did you explore? (Optional)
Another way to check for 2 is !_.isEmpty(report.chatType) (only PMs have chatType empty).

@hoangzinh Thanks for the proposal. Your RCA is correct and the suggested implementation makes sense. But I think we should just pass the report as is to pushReportCommentNotification and do the title construction logic there.
:ribbon: :eyes: :ribbon: C+ reviewed
cc @Julesssss

@dukenv0307 Thanks for the proposal. I think it shares the same idea as the previous one. It's a little detailed but I don't think it's adding much value.

@s77rt I see the previous proposal:

Only works for 1 out of 5 cases (policyRoom)
Suggested incorrect format of the notification (replacing by roomName), which is not consistent with other platforms

So I'm not sure why it's considered complete.

For more correctly, I think we can reuse this isChatRoom util

@hoangzinh that util is also checking 4 out of 5 types I mentioned so it's basically the same idea as mine, the policyExpenseChat was likely missed out in the util.

@dukenv0307 I understand your concern. But the idea is basically the same: Get report. Determine if it's a room. Adjust title in pushReportCommentNotification.

We will still determine if the chat report is a room based on chatType.
The title is mostly a preference, we can ask on Slack which format to go with. It makes sense to include both the room name and person name but this is not a critical factor for proposals selection.

Do you still think we should go with your proposal instead?

Thanks all. Typically I go with the first sufficient that points out the high-level solution. For simple-ish bugs like this one, we don't need necessarily need to see the entire solution.
For that reason, I'm going to assign @hoangzinh.

PR is WIP.

No BZ checklist here as this is a new feature. Further, we don't currently pay speed bonuses for new feature issues. So we need to make the following payments here:

@hoangzinh $1,000 for PR.
@s77rt $1,000 for C+ review.

@s77rt offer sent for $1,000!

@hoangzinh offer sent for $1,000!

Adding additional assignee as I'm OOO next week (until June 5th). All that's left here is to issue the two above payments on 2023-05-29!

Thanks for the bump @hoangzinh , paying now.

Paid, and job closed in Upworks!


Adding images of all the contributors in this project

How was this generated? Is this something we can try to keep up to date on a monthly basis? New contributors may wonder why their image isn't included. A last-updated timestamp at least may help with that.

Codecov Report

Merging #944 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
- Coverage   94.94%   94.73%   -0.22%
==========================================
  Files         247      222      -25
  Lines       11142    10253     -889
  Branches     1065     1016      -49
==========================================
- Hits        10579     9713     -866
+ Misses        563      540      -23

Impacted Files
Coverage Δ

...ackages/opentelemetry-metrics/src/MeterProvider.ts

...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts

...ges/opentelemetry-metrics/src/export/Aggregator.ts

...emetry-metrics/src/export/ConsoleMetricExporter.ts

...ges/opentelemetry-exporter-zipkin/src/transform.ts

packages/opentelemetry-metrics/src/Metric.ts

...ackages/opentelemetry-exporter-zipkin/src/utils.ts

...ges/opentelemetry-exporter-zipkin/test/e2e.test.ts

...s/opentelemetry-metrics/test/MeterProvider.test.ts

...kages/opentelemetry-metrics/src/BoundInstrument.ts

... and 15 more

How was this generated? Is this something we can try to keep up to date on a monthly basis? New contributors may wonder why their image isn't included. A last-updated timestamp at least may help with that.

I used https://contributors-img.web.app/preview tool to generate the url. I think it will keep list up-to-date (not sure how).

Oh I didn't even notice the image was a webapp like that. Very cool


fix: adds debounce to search api call

Type:
The following has been addressed in the PR:

There is a related issue #385

Description:

adds debounce to avoid excessive api calls to search endpoint.
fixes laggy UX on searching packages.

@ayusharma it does not fix the issue, just helps. Your patch just helps to be less annoying but for what he is asking for is something we cannot provide right now.


merge questions 2.1 and 2.8

fixes issue #97
Since 2.8 and 2.1 cover a lot of the same subject matter, this PR moves the implied-enumeration from 2.8 into 2.1

Preview | Diff

You are intending to drop the BEACON example, right?
In any case: mark the sub-questions as questions using the familiar "?".

re https://github.com/w3ctag/security-questionnaire/issues/97#issuecomment-698624428, i will rework this PR to see if we need either section

Okie dokie, how do things look now.  Cleaned up an additional typo too. Good to merge?


ld.exe: cannot find -lgcc_eh: No such file or directory

The other MinGW-w64 release have a libgcc_eh.a in lib folder but w64devkit has no it.

I only enable static libstdc++, so libgcc_eh is rolled into libgcc. If a
build system uses -lgcc_eh then it's probably unaware libstdc++ is being
statically linked and you should request a static build. If it still tries
to link libgcc_eh in a static build, then the build is subtly broken and
you'll need to find some way to override the "LDLIBS" flags.
Static libstdc++ is not without cost, though the costs are undocumented by
GCC, and doubly so on Windows where dynamic linking fundamentally differs
from ELF. An obvious cost is that every module (DLL, EXE) contains a copy
of at least part of libstdc++, typically ~100k to ~1M depending on what
you're using. (Don't forget that when it comes to license compliance.)
A less obvious cost is that sharing standard library objects across module
boundaries is unsupported — e.g. passing a std::string through an exported
function. Or at least that's my understanding. Unlike on Linux, on Windows
it's perfectly sound to have multiple, incompatible libstdc++ linked into
a single process. Modules will link to the correct functions even if they
have a common name (e.g. operator new). But if you share standard library
objects, even between DLLs statically linked with the same libstdc++, the
receiver will use its own copy of these functions on the objects. In most
cases this is harmless, but in a few cases it won't work correctly, such
as when there are global variables involved. They each use their own copy
of these variables. One such instance is winpthreads (which, to be honest,
is not implemented so well), affecting all threading objects.
The prohibition on sharing standard library objects extends (with lower
confidence on my part) to throwing exceptions across module boundaries,
which is why you don't need libgcc_eh when static linking libstdc++. I
could potentially supply an empty, dummy libgcc_eh — like Mingw-w64 does
with -lm — to smooth over linking hiccups, but that would cover up subtle
compatibility problems. If a build wants to use -lgcc_eh in w64dk, that's
a sign something may be wrong with the build.
Why only supply static libstdc++? For simplicity in the typical case, and
especially because dynamic libstdc++ is less useful on Windows, which has
no common, system C++ standard library. There's no C++ ABI compatibility
except within a project where all modules are compiled together at the
same time. Instead the official solution to this problem is COM.
Note: C++ prohibitions are strictly about libstd++ objects, and (again,
lower confidence) maybe exceptions. You can still use the C++ ABI across
DLL boundaries, without extern C, within a project so long as it does not
expose libstdc++ objects. That's trivial if you do not link libstdc++, for
instance. Though in practice, for typical C++, this doesn't mean much.

Thanks for your reply. I use w64devkit for rust with gnu toolchain on Windows. When I run cargo build, It display an error ld.exe: cannot find -lgcc_eh: No such file or directory.
According to your reply  I know the reason,thanks!

I believe #52 covers your same issue with rust. This is a dup of that.

Yes. Thanks!


feat: add ValidationButton & DeleteButton

Closes: https://github.com/zakodium-oss/analysis-ui-components/issues/135

Please rename the stories

First is 'Cancel button'
Second is 'Validate button'

This should wait for https://github.com/zakodium-oss/analysis-ui-components/pull/128


Docker container dies on startup when passing CTF_KEY

Launching a docker container while passing a CTF_KEY results in the container dying immediately. Without the CTF_KEY environment variable it works fine. Reproducable on master (5.x) and develop (6.x) branch, so it cannot be related to recent Dockerfile changes from #404.
Suspectedly problematic code is in utils.js:
let ctfKey
if (process.env.CTF_KEY !== undefined && process.env.CTF_KEY !== '') {
  ctfKey = process.env.CTF_KEY
} else {
  fs.readFile('ctf.key', 'utf8', (err, data) => {
    if (err) {
      throw err
    }
    ctfKey = data
  })
}

Just verified that passing in a CTF_KEY during local execution on node.js works as it should. So, this only happens in Docker as it seems.

It works, for me at least, if you pass the -e option before calling the docker container:
$ docker run -d -e "NODE_ENV=ctf" -p 3000:3000 arclight/juice-shop_x64_test
99694073c34c7d89aa8d2138612d7684452aa28ecf5b98c687222604bf57e903
$

With the latest repo from dockerhub (note that sometimes it works and sometimes it doesnt!)
docker run -p 3000:3000 -e "NODE_ENV=ctf" -e "CTF_KEY=123456789" bkimminich/juice-shop

<EMAIL_ADDRESS>start /juice-shop
node app

Segmentation fault (core dumped)
npm ERR! Linux 4.4.14-200.fc22.x86_64
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v6.12.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: node app
npm ERR! Exit status 139
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node app'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the juice-shop package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node app
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs juice-shop
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls juice-shop
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /juice-shop/npm-debug.log

@battletux, that failing snapshot seems unrelated to the CTF_KEY. Occasionally the SQLite package does not properly install. Happens on all OS but luckily very rarely.

Sidenote: I just realized that @battletux's Dockerfile optimization was only in the (generated) file, not in the template. This has been changed.
But: Could the #405 change actually be the culprit for this undeterministic behavior of the container when passing in environment variables?

I've found the SQLite-🐛 that @battletux experienced:
# OWASP Juice Shop - An intentionally insecure JavaScript Web Application
FROM            node:8-alpine
MAINTAINER      Bjoern Kimminich<EMAIL_ADDRESS>LABEL version = "6.0.0-SNAPSHOT"

RUN apk update && apk add git

COPY . /juice-shop
WORKDIR /juice-shop
RUN npm install --production --unsafe-perm

FROM    node:6-alpine
WORKDIR /juice-shop
COPY --from=0 /juice-shop .
EXPOSE  3000
CMD ["npm", "start"]

The app ist built on a node:8-alpine but later run on node:6-alpine. SQLite's binaries do not like that.

D'oh! Scratch that one up to the dyslexia.

For me everything worked just fine in several tries. I'll close this issue for now.

Looks good on the snapshot :)


Options page

What does this PR do?
Adds an options page to view all saved urls
Any background context you want to provide?
See issue #3
Screenshots and/or Live Demo

LGTM ✨ Thanks for contributing @N7Layla.

@all-contributors please add N7Layla for code


Create PSUADE MOAT method

This PR addresses issue #60 by creating a dakotathon implementation of the PSUADE MOAT method.
@mdpiper I've done my best to follow your prior work in developing tests. If there are standard method tests that I've missed, please let me know and I'll write them.

Coverage increased (+0.03%) to 97.84% when pulling 4e27f093bff030adddbc52f11ca127457bdf2488 on kbarnhart:barnhark/create_psuade_moat_method into 6b240a4fd0ee07ad041dd580ab508861c315dd83 on csdms:master.

Coverage increased (+0.03%) to 97.84% when pulling 278cf801cfb281f920582f1159c40280ff2c4fdd on kbarnhart:barnhark/create_psuade_moat_method into 6b240a4fd0ee07ad041dd580ab508861c315dd83 on csdms:master.

@mdpiper I'm getting close to doing some additional work on Dakotathon (adding a calibration method).
Before I start I'd appreciate any feedback on how I implemented this method. Should I do the new method in a vastly different way?

@kbarnhart I'll start reviewing this PR this week. (I'm in the midst of writing a report for NSF due Friday.) I'm sorry I've taken so long in getting to this.

@mdpiper no worries. good luck with report!

@kbarnhart This PR looks great! I'll merge it. Thank you so much for contributing to this project!


Add link to the test website in the README in this repo

Hi! The general plan is to make this website main since next week (in fact, as soon as possible given people's time to do a setup, configure the domain etc), so the "test" address will be no more soon.
This website is in dev for a couple of years already, so it was enough time for people to try it out this way.


fix: session.GetServiceURL: No such service compute

这个 PR 实现什么功能/修复什么问题:
目前compute service已经更名为compute_v2, 使用modulebase.GetModule(session *mcclient.ClientSession, name string) 会出现 No such service compute错误。
是否需要 backport 到之前的 release 分支:

release/2.12

/area region
/cc @yunionio/maintainer

Codecov Report

Merging #3393 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3393   +/-   ##
======================================
  Coverage    7.17%   7.17%
======================================
  Files         492     492
  Lines       80826   80826
======================================
  Hits         5796    5796
  Misses      74542   74542
  Partials      488     488

Flag
Coverage Δ

#aFlag
7.17% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f8150...53fe55f. Read the comment docs.


Remove color property

Just let the color be defined by the background-color property. This mean the plugin will be as simple as this:
.circle {
    circle: 100px;
    background-color: red;
}

Fixed in https://github.com/jedmao/postcss-circle/commit/c9532391affcc872f15ab849514b53e4fbe4b141


Dependency parser looks slow with Jane Austin letter as input

When running Brandies dependency parser (brandeis_eldrad_grid_1:stanfordnlp.dependencyparser_2.0.4) with the sample input (Jane Austin letter), it looks to me the parser is slow.
The sample input has 40 sentences. I assume it will not be fast normally. But it looks to me the parser is a bit slower than the usual case.

Do you have some timings comparing the Brandeis service to other, faster services?  What kind of time are you expecting?  What times are you seeing?


Carthage support

Adds support to Carthage.
Carthage Documentation
Carthage
Supporting Carthage for your framework
Description
Added a pre-build action to LibWally scheme that runs carthage-build-libwally.sh.
carthage-build-libwally.sh checks if CLibWally/libwally-core/src/.libs/libwallycore.a exists and has the necessary archs, if not it runs build-libwally.sh -csd.
How to use

add github "blockchain/libwally-swift" "paulo/IOS-2462/carthage" to your Cartfile.
run carthage update

Next steps
Tag libwally-swift releases so we can reference that on the Cartfile instead of using branch name/commit.

I've never used Carthage, but it looks good to me. I can still run the tests on my machine.
The "script to not rebuild if .a already contains necessary archs" doesn't have to be Carthage specific?
Now might be a good time ti release v0.0.1, but I suggest marking it as a pre-release in the Github release page.

Hey @Sjors,
I modified it it only runs if CARTHAGE or BUILD_LIB_WALLY_CORE are defined YES.


[Desktop pairing] QR code broken on disconnecting MM wallet during the safe creation flow

Description
[Desktop pairing] QR code broken on disconnecting MM wallet during the safe creation flow
Environment

Browser: Chrome
Wallet: MetaMask
Chain: Rinkeby/Gnosis chain

Steps to reproduce

Connect to MM
start create safe flow ( the first step - connect wallet step)
disconnect MM
check QR code for the mobile app
Current result: The QR code is broken

Expected result
Make sure that the QR code is updated
Screenshots

According to @francovenica, the fix above didn't help.

Tried again in the https://github.com/safe-global/safe-react/pull/3680 Starting the Safe creation connected to the MM extension, advancing a few steps, disconnecting, reloading the QR code for the Safe mobile app and trying to connect again.
I used both, the code in the 1st step and the code in the dropdown and both worked fine.
I was able finish the safe creation process with the Safe mobile app just fine.


Add cronjob syntax support

e.g. * * * * *, perhaps via a direct method fromCron to make parsing easier

It’s very nice to see somebody still cares about this package, however, this package was primarily created for the SFN framework, which now has a built-in schedule service, so this package is no longer needed and will not be maintained anymore.

@hyurl 😄
I just released https://jobscheduler.net (https://github.com/breejs/bree) - check it out!


Empowering Biomedical Discovery with AI Agents

Description
Where are the other figures?
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
f4f83f19-fbd4-43c4-a7fb-deae3edc0b36
Paper URL
https://arxiv.org/html/2404.02831v1
Browser
Firefox/129.0
Device Type
Desktop

Download
https://www.mediafire.com/file/7ybpxn8lil1av70/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Support for baseUrl

Hi,
It would be nice to have the property configuration 'baseUrl' as we already have in the webdriverio runner. Is it possible to add it?
Do you know any other alternative to configure it?
Thanks,
Viko

+1

so I have managed to fudge something, in the grunt-webdriver package file I bumped up the version to 3.1.0 (uninstalled the old version with npm install)
Then in the grunt-webdriver node_modules folder under tasks/webdriver.js I added a baseUrl option:
options = this.options({
                reporter: 'spec',
                ui: 'bdd',
                slow: 75,
                bail: false,
                grep: null,
                timeout: 1000000,
                updateSauceJob: false,
                output: null,
                quiet: false,
                nospawn: false,
                seleniumOptions: {},
                seleniumInstallOptions: {},
                baseUrl: null
            }),

and added the option in my app gruntfile:
webdriver: {
            options: {
                desiredCapabilities: {
                    browserName: 'chrome'
                },
                baseUrl: 'http://www.thisisthebest.com'
            },

Working to get grunt-webdriver ported to v3. This will be fixed then.


mc_module

We have changed the module

Looks great, can we add a test for this in the /tests folder? You can get reproducible random results by using the np.random.seed(0) command.

@yohanna123 Will you be available to add a small test?

Going to merge this in and fix up the other MC parts.

Hi @dgasmith , yes, I plan to. I'm still working on making the function work though.


“Show or Hide” option at the top of Google search results disappeared after blocking the Google search location track by ip and cleaning the browser cookie

Expected Behavior
“Show or Hide”  option works at the top of Google search results.
Actual Behavior
“Show or Hide” option at the top of Google search results disappeared. But this option works in Bing search.
I have closed the Chrome extension option (not show “Show or Hide” option at the top of search results）below.

Steps to Reproduce the Problem

search 线性无关和可逆之间的关系 in Google. link

search 线性无关和可逆之间的关系 in Bing. link

Google search results【“Show or Hide” option disappeared】

Bing search results【“Show or Hide” option works】

Specifications

OS:
版本	Windows 11 专业版
版本	22H2
安装日期	2022/5/14
操作系统版本	22622.601
序列号	PF1ALSV6
体验	Windows Feature Experience Pack 1000.22634.1000.0

Browser:
版本 105.0.5195.127（正式版本） （64 位）
Now, I have updated my browser to the latest version, 版本 106.0.5249.62（正式版本） （64 位）
But this option still failed.

Other extensions that might interfere:
None. I have closed all other chrome extensions except ublacklist. But “Show or Hide” option still doesn't show at the top of Google search results.

Looking forward to your reply.❤❤❤❤❤

Oh, sorry. It works in Edge browser. But not work in my Chrome Browser. I'm trying to figure out the reason.

I find an interesting phenomenon. Let me share with you.
I'm from China. So I need to use a proxy to access the Google search.
When I block the Google search location track by ip and clean the browser cookie, just like the below picture. the “Show or Hide” option at the top of Google search results will disappear. I think it is a bug. My bro, You can check it out when you have free time.

You can find more about how to turn off the Google search location track by ip in this document and clean the browser to reproduce the process.

给中国的小伙伴提供一个思路。谷歌搜索的ip追踪可以关闭，但是搜索的语言设置不要设置成en，改回中文简体，ublacklist这个展示按钮就恢复过来了。具体的原因我也不清楚。仅供参考。

前段时间安装的一个chrome插件，会默认将谷歌搜索的语言设置成en，所以如果此插件不关闭，你修改设置语言，会发现提示修改成功，但是还是en。所以在修改语言之前，记得将这个插件关闭或者卸载掉。

To date, I have not been able to reproduce this issue.
Google occasionally tests new layouts on a limited number of users. Problems with such new layouts are often difficult to reproduce.

I see it ublacklist momentarily flash. I just noticed it today... maybe they released an update
https://user-images.githubusercontent.com/7908073/213581110-f2426081-6745-4022-8626-a370a8bef720.mp4

给中国的小伙伴提供一个思路。谷歌搜索的ip追踪可以关闭，但是搜索的语言设置不要设置成en，改回中文简体，ublacklist这个展示按钮就恢复过来了。具体的原因我也不清楚。仅供参考。

The same problem happend, and changing the language setting doesn't seem to work for me.


How to set alternative IP ranges ?

How to set alternative IP ranges ? I added ip_prefix: <IP_ADDRESS>/16 to config.yaml, not work.

I have the same question

ip_prefixes introduced in 0.13.0 seem to do the job.


Clicking on the View Details link in the Program card doesn't go anywhere

Clicking on the View Details link in the Program card doesn't go anyhere. The href is _blank so it looks like it's just opening a new tab redirecting to the homepage
Slack Message
Reported by Jay

Open question: If the program admin did not set a link for "View details", what should the button do?

Open question: If the program admin did not set a link for "View details", what should the button do? Should we hide the button?

With the North Star flag off, it looks like the expected behavior in that case is to open a new tab with the program details page.  For example, the path for a program with an id of 134 would be /programs/134.  That page currently looks something like this:


Fix bss-related compile error in inthandler.S with newer GAS versions

Without this fix, newer versions of GAS will abort the compilation with the message .../src/inthandler.S:238: Error: attempt to store non-zero value in section `.bss'

Are there any issues with this and my other pull request? I have tried the changes with most of the example programs, and they work just like before.


replicate the results

I am unable to replicate the results in the paper.
I tested prompts 1, 2, and 3 but the average QWK for all folds differs from the reported QWK in the paper.
I understand there might be a slight difference since the examples are random. However, my results are a little bit far ever.

I have found that different graphics cards may also cause differences in the overall experimental results, can you tell me in detail the equipment and experimental results of your replication?

I am using NVIDIA RTX A6000.
As mentioned in the paper, I trained each fold for 80 epochs, then took the best QWK for each fold. Finally, calculated the average.
I have not really changed anything in the code, except that I noticed that the batch size was set to 6, however, it was 5 in the paper so I set it to 5 as well.


feat: Add SafeArea

#__
Checklist

[ ] I didn't over-scope my PR
[ ] My PR title matches the commit convention
[ ] I did not include breaking changes
[ ] I included unit tests that cover my changes
[ ] I added/updated the documentation about my changes
[ ] I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

:tada: This PR is included in version 1.0.0-beta.37 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Transfer Question

Was wondering about system versions and transferring. Say I've got a 10.7 cfw Ds and an 11.1 stock Ds. If I transferred that 10.7 to the 11.1 Ds, would that stock Ds retain its 11.1 or will it get the 10.7? What if I did the opposite, and transferred 11.1 to the 10.7?

no transferring doesn't downgrade/upgrade the firmware, nor will transferring also wont transfer cfw. both systems need to be on the newest fw to do a system transfer or use ctr-httpwn


Multiple Cursors - New Line Issue

When using the Multiple Cursors feature, if you write out in 3 separate places

 and pressed enter, the first cursor would correctly create a new line within the opening and closing tag, but it seems the multiple cursors feature works off line number than where the element actually is. Small issue, but if can be resolved would be useful :)

@banny94 I am unable to understand the issue. Can you please attach the screenshot to make it clear?

@banny94 Pressing enter while in between the tags in all selections does create new lines within the opening and closing tags as you expect.
Please retry once making sure that your multiple selections are still selected while you press enter.
If not, please share the screenshot steps.

Also, could you make sure this is not a problem caused by an extension by selecting Debug > Reload without extensions. After doing so, see if you can still reproduce the issue.


C# and Java client negotiateVersion cleanup

negotiateVersion is not included after negotiation occurs
negotiateVersion is not added if it is already present
connectionToken is not stored anywhere

Yes they should

From: Andrew Stanton-Nurse<EMAIL_ADDRESS>Sent: Wednesday, September 25, 2019 1:56:59 PM
To: aspnet/AspNetCore<EMAIL_ADDRESS>Cc: Barry Dorrans<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/AspNetCore] C# and Java client negotiateVersion cleanup (#14196)
@anurse commented on this pull request.

In src/SignalR/clients/csharp/Http.Connections.Client/src/HttpConnection.cshttps://github.com/aspnet/AspNetCore/pull/14196#discussion_r328336970:

@@ -343,7 +342,7 @@ private async Task SelectAndStartTransport(TransferFormat transferFormat, Cancel
}

             // This should only need to happen once

           var connectUrl = CreateConnectUrl(uri, _connectionToken);

           var connectUrl = CreateConnectUrl(uri, negotiationResponse.ConnectionToken);

Well, I think it is. We could also redact it from the logs.
@blowdarthttps://github.com/blowdart @GrabYourPitchforkshttps://github.com/GrabYourPitchforks do you have any thoughts here on if the connection token value should be suppressed from Debug level logs on the Client.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/AspNetCore/pull/14196?email_source=notifications&email_token=AAGCNCWNOGYP2VLRMMK2TM3QLPGBXA5CNFSM4IYZKOE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF6E7OQ#discussion_r328336970, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAGCNCX4HEHUOWO3WIETA5TQLPGBXANCNFSM4IYZKOEQ.

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=366242&view=logs


Added pre-commit hook configuration

This allows pyproject-flake8 to be used as a pre-commit hook.

Thank you @agronholm for the contribution!

Thanks!

This still needs a new tag before it's usable with pre-commit.

I cleared my pre-commit cache and did not run into this issue; sorry; I've created a new tag v0.0.1a2.post1 .

What's with the conservative versioning? It works, right? Maybe this should follow flake8 versioning with .postX added to it?

But yeah, thanks for adding the tag. Pre-commit complains (rightfully) unless a specific version is used.

The point is, that currently pyproject-flake8 does not specify any specific flake8 version, it will just depend on the most recent one.
Theoretically, flake8 versions could be fixed in pyproject-flake8 …


An error occurs after executing the command "SSH into Web App" for a Linux web app

OS: Win10
Azure App Service Extension Build Version: 20230604.1
Azure Resources Extension Version: v0.7.5
Repro Steps:

Right click a Linux web app -> Click "SSH into Web App".
Check whether succeeds to execute the command "SSH into Web App".

Expect:
Succeed to execute the command "SSH into Web App".
Actual:
An error occurs.

More Info:
This issue also reproduces when executing the command "Start Remote debugging".

I was able to repro this. Works as expected on the portal.

Verified this issue on the main branch build 20230719.1, another error pops up after executing "SSH into Web App" and "Start Remote debugging" actions.

I'm getting the same 401 error when I try to use az webapp ssh from the Azure CLI v2.47.0, but on v2.50.0 it works. Something with the service must have changed.

Looks like we need to apply the same fix that the Azure CLI did here https://github.com/Azure/azure-cli/pull/26229

This issue has been fixed on the latest build 20230719.13.


fixes issue #98

():

<Added a splashScreen in the app by making using of https://github.com/jonbhanson/flutter_native_splash
Right now , the splash screen consists of the logo of the app on a balck background.
https://github.com/dart-lightning/lndart.clnapp/assets/119595975/5ff89947-c10c-43d3-8024-694790e17d28

@Harshit933
greetings sir.
Sir , please go through it

we can add the icon of the app as spleshscreen?

Yes I added the main logo of the repo as splash screen on black background.
Do you want to add this ⚡ icon instead of this?

we can add the icon of the app as spleshscreen?

Yes I added the main logo of the repo as splash screen on black background. Do you want to add this ⚡ icon instead of this?

See the video around 0:12

@vincenzopalazzo for those deprecations I guess either we need to wait for the native flutter speech to give updates or we can even built the splash screen from the scratch itself sir m all we need is to change the home to that splash screen and push. Navigator. Of(context). Pushreplacement() to homepage in splashscreen.Dart

@vincenzopalazzo
seems so that the error is basically beacuse I didnt integrated with core-lightning

it is now showing all checks passed .
furthermore ,I am setting the project on Linux as well . Let me know if it works , else i will raise the PR again once it runs on my linux
@Harshit933

Tested on my mobile. Works good. But one question I have is why can't we just build a splashscreen from scratch? It would reduce the number of dependencies.

Tested on my mobile. Works good. But one question I have is why can't we just build a splashscreen from scratch? It would reduce the number of dependencies.

In fact building a splash screen from the scratch will look more beautiful and lovely than this. Here in this we can't even change the layout. If we build from the scratch we will have full freedom to add the image, tag line and animations as well.
I already have made one. Let me modify a bit and we can merge that one rather than of this.
Between can you please provide me some more clear picture of the logo .

I already have made one. Let me modify a bit and we can merge that one rather than of this.

That would be nice but please wait for @vincenzopalazzo's review.

Between can you please provide me some more clear picture of the logo .

I don't have it.

I already have made one. Let me modify a bit and we can merge that one rather than of this.

That would be nice but please wait for @vincenzopalazzo's review.

Between can you please provide me some more clear picture of the logo .

I don't have it.

Sure 👍

Closing because look inactive


Add The Lord of the Rings

Not sure if party is the best category but didn't see an adventure or role-playing one. 🤷♂
Submitting this PR means you have:

[x] searched the readme file and searched the open pull requests (no duplicates please)
[x] and will follow the desired format
[x] used image links that resolve correctly, are appropriately sized, and are served over HTTPS

Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.
Do you have further questions? Check the contribution guidelines or open an issue.
When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!
https://github.com/edm00se/awesome-board-games/issues/269

Sadly I think the categorization of this project is in need of a tidy up

Yeah, as I said in the PR I think the party category doesn't really match this but I didn't wanna overstep and add a new category and add just one game in it. 🤷♂


fix: Admission-webhook is using the wrong container registry, org and tag for CoreDNS

Signed-off-by: Denis Tingajkin<EMAIL_ADDRESS>
Description

Motivation and Context
https://github.com/networkservicemesh/networkservicemesh/issues/2212
How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Using this version, I am now able to change the registry and the repository but I am still not able to change the tag.
Also, I am able to set the registry and the repository only if I put them together in the environment variable REPO of the admission-webhook pod.

@LionelJouin Note: we are using CoreDNS with the master version from a separate repo by default. So we cannot set for CoreDNS image some specific version. As a solution I see a variant to add some additional env for CoreDNS image but it looks not good for me.
What are the problems you see with using a custom repo and master version?

For the version (tag) of nsm-dns-init, nsm-monitor and other containers injected in the NSCs, it is possible to change the version. The issue I see is that it is not possible for the CoreDNS container.

@LionelJouin Yes, and it looks correct for me because of CoreDNS container is not part of this repository.

Here failing build because on CI we are using networkservicemeshci repository that has not CoreDNS image. So it looks like this direction is invalid.


fix: Remove stackblitz example

Motivation
Running this example in stackblitz is broken https://github.com/stackblitz/webcontainer-core/issues/1045
Change Summary
Removed the stackblitz example from the docs (requested by @varunsrin)
Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] PR title adheres to the conventional commits standard
[ ] PR has a changeset
[x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
[x] PR does not require changes to the protocol
[ ] All commits have been signed

PR-Codex overview
This PR updates the README.md file for the chron-feed example in the hub-nodejs package. It adds instructions for running the example locally.
Detailed summary

Added instructions for running the example locally.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@stephancill you'll have to configure gpg signing for github to accept the pr: https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits

Updated @varunsrin


[tf] tf change to properly configure lambda functions SA can invoke

to @austinbyers , @jacknagz
cc @airbnb/streamalert-maintainers
size: small
bug fix

With some updates to properly invoke a lambda function with a designated qualifier, we broke terraform's configuration of said function.

Previously, tf was creating a policy using the function name combined with the qualifier.
This prevented proper invocation with a specific qualifier using boto3
The change is to strip off the qualifier, and only use the function name when creating the policy.

If a qualifier is not provided in the outputs.json configuration for this lambda, it does not break this logic. The interpolation will still extract the proper function name.
Updating the example outputs.json configuration to include a qualifier along with the function name.

Other change

Updating the message the lambda output configuration prompts with when asking for a function name. It previously requested an ARN, which should not be used now. It is clarified as requiring a function name and optional qualifier (function_name:qualifier)

Coverage remained the same at 79.307% when pulling 43bd3793b80cdeef282c809b633d01ad8c4c510c on ryandeivert-lambda-tf-fix into ebdda9c2e5ca55a585212d190abff965a84faa3e on master.

Coverage remained the same at 79.307% when pulling f3c71ba1db10e89ccf896935dbeeecdcdb4e23f9 on ryandeivert-lambda-tf-fix into ebdda9c2e5ca55a585212d190abff965a84faa3e on master.

Coverage remained the same at 79.307% when pulling ffbb118ccde8febe02d3680f09960d925666958a on ryandeivert-lambda-tf-fix into ebdda9c2e5ca55a585212d190abff965a84faa3e on master.


Multiple font style support

Description of the new feature/enhancement

TUI editors like vim have support for alternate font highlighting using CSI SGR 10-20. Few terminal emulators in linux currently support this, and it would be great to have it in Windows Terminal because Windows really doesn't have many emulator options
Sources, references and discussions:
https://github.com/kovidgoyal/kitty/issues/6804
https://github.com/vim/vim/pull/13537

Proposed technical implementation details (optional)
https://github.com/vim/vim/commit/a606f3ac036e5f3dc313f620e6b4bc00812314f9

This is already tracked in issue #6779. But thanks for the vim reference. It's helpful to know that there is actually someone making use of this functionality.

While not having this feature integrated wouldn't be catastrophic, it would be slick to have some extras in terminal emulators, especially for people who use terminal editors. However, I don't foresee it coming to windows terminal anytime soon, as it may not be widely used by many people.

Thanks for closing this out as a dupe! Feel free to subscribe or comment over on #6779 to help us prioritize!


add attributes to indices that return 'dayofyear'

Pull Request Checklist:

[X] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #688  -  addtionally adds attributes to help recognize doy variables in WPS ensemble statistics processes

[X] Tests for the changes have been added (for bug fixes / features)
[X] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (major / minor / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?

Does this PR introduce a breaking change?
no

Other information:

Test fails are my fault. Will fix today.
@huard @Zeitsperre  to keep you in the loop: as the CF standard do not provide a way to mark a doy variable as such (units are "", which is uninformative, and there is no standard_name for it), we decided to add a is_dayofyear custom attribute. At least inside xclim and family we'll be able to use it. Additionally, a  calendar  attribute so that if the dataset's calendar gets converted, there is a way to notice that the doys were computed with another calendar.

Test fails are my fault. Will fix today.

ok thx


Remove redundant doc material.

Some of this content was moved from the contrib doc.
Also covers the considerations of changing release branches.
Replacement PR for https://github.com/advancedtelematic/aktualizr/pull/1330.
Still not connected to the navigation system; I wasn't sure how to make that work.

@patrickvacek Good idea to have a separate page for the supported yocto branch.
Having this information in the contributing section was difficult to find

Ok, so the thing is...
The nav lives in the aktualizr repo.
https://github.com/advancedtelematic/aktualizr/blob/master/docs/ota-client-guide/modules/ROOT/nav.adoc
You could add a 'xref' in the "For contributors" section down the bottom, but you'd need to do a "cross-repo xref" (which is another argument for keeping meta-update doc also in the aktualizr repo)
In antora, a cross repo xref looks like this * xref:dev@ota-client::yocto-release-branches.adoc[Yocto release branches]
But this wont work in GitHub (if you happen to use the TOC).
To make it work you could:

Put this topic in the aktualizr repo where you originally had it (where relative links are possible)
Keep this topic in meta-updater and add a conditional statement in the nav that points to "https://github.com/advancedtelematic/meta-updater/tree/master/docs/modules/ROOT/pages/yocto-release-branches.adoc"

Put this topic in the aktualizr repo where you originally had it (where relative links are possible)

To summarize our conversation: we're going down this road. I've reopened https://github.com/advancedtelematic/aktualizr/pull/1330 and updated it with changes from here.
This PR will stay open for now just with the change to remove the redundant part. It should actually get updated to point at the right place in the docs portal once it is there, so don't merge this until it is ready.

Ok removed all redundant content and fixed some xrefs to point to future locations in the aktualizr repo

I'm kind of approving my own changes here...but LGTM

That's fine -- although I did just correct a typo. We should wait to merge until https://github.com/advancedtelematic/aktualizr/pull/1332 is merged and we can clean up and/or reorganize the README a bit more.

RE: the latest commit
I don't think the heading "== Table of Contents" makes much sense now that there's content sandwiched between it and the actual TOC (now with the header "Further Documentation). I would move that "== Table of Contents" block to where it now says "Further Documentation" (replace it)

I don't think the heading "== Table of Contents" makes much sense now that there's content sandwiched between it and the actual TOC (now with the header "Further Documentation). I would move that "== Table of Contents" block to where it now says "Further Documentation" (replace it)

Oops, that did look bad. Fixed, I think. See what you think now.

thanks. I approve!


Inconsistent License notices

The license notification text in index.js is inconsistent with the Apache license in LICENSE

Updated. Thank you for reporting this issue.


[Web][Beta] flutter run -d canary

Hi,
I know flutter web is beta, however selecting a chromium browser when enabling web support via the flutter config would allow for added benefits. Such as running on Canary.
The main motivation for canary support is the new graphics layer WebGPU 3, amongst others.
Use case
Running flutter config --enable-web -canary would enable canary. Such that flutter run -d canary works.
Proposal
Building nextgen, turnkey browser based tools with flutter is a joy. Current testing with a deployed app on canary is trivial but takes some time due to the ci/cd process.
Proposed that flutter config --enable-web -canary will enable flutter run -d canary

Rather than enable another device type, we could make the chromium executable location more configurable. Right now you can change it by setting the environment variable CHROME_EXECUTABLE to a different path.

Cool, so theres export CHROME_EXECUTABLE="/Users/bin/canary"!
flutter run -d chrome -a canary or  flutter run -d chrome -p "/User/bin/canary"  would be neat, and to future proof a fuchisa vm with flutter run -d fuchisa -a chrome :)

Duplicate of https://github.com/flutter/flutter/issues/63720


Add a custom error message for values without attributes in a record

This implements part of the feature request in #436. It adds a slightly friendlier error message that appears when a value without an attribute in a record. For example, this code
search
  twenty = [-20]
bind
  [#ui/text text: twenty]

will generate the error message "-20" needs to be labeled with an attribute.
After this, the attribute rule could be modified to take another argument specifying whether the record that is being parsed is part of a functionRecord. If so, the message could mention that function syntax requires arguments to be labeled, and include parameter names if it is a standard library function. I can work on that next, if this looks good to you.

I'm working on the other part of this, but how do I test it out? Is there a way to get the eve-starter to run my modified code?

Hey @christopherdumas,
You should be able to build eve from source code by running npm install && npm run build within the eve repository assuming you have a relatively recent version of NodeJS and NPM installed.
You can then start this locally build version using npm start.

Awesome, thanks.
On Mon, Aug 28, 2017 at 5:41 PM Joshua Cole<EMAIL_ADDRESS>wrote:

Hey @christopherdumas https://github.com/christopherdumas,
You should be able to build eve from source code by running npm install
&& npm run build within the eve repository assuming you have a relatively
recent version of NodeJS and NPM installed.
You can then start this locally build version using npm start.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/witheve/Eve/pull/845#issuecomment-325521299, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1Ml1602Nn5rvB2-wJ5XDJVv45ww_v0ks5sc14dgaJpZM4N69qZ
.

--
Regards,
Christopher


testing doc-builder

testing huggingface/doc-builder#408

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Required props for injectSpeedInsights

Hey,
Wanted to enable vercel speed insights with an Angular app.
I'm using<EMAIL_ADDRESS>with Angular@17, <EMAIL_ADDRESS>The injectSpeedInsights function require a props argument.
To work well, and see vercel speed insight result and http calls in console, i set a empty object {} as props argument.
Without this argument, vercel speed insights don't work (Can't see http calls for insight inside network tab)

Also had to do something like this, not sure what's the big deal. Now may I ask, @benoitrongeard do you receive any VERCEL_ANALYTICS_ID not found errors in your console?

Hello and thank you for the bug report.
The function needs an argument indeed, because it may needs to know the framework. The team is currently checking if we could make it optional or not.


HDDS-9082. OMKeySetTimesRequestWithFSO should not prepend key prefix to keys in fileTable

What changes were proposed in this pull request?
OMFileRequest.getOMKeyInfoIfExists sets the keyname to complete keyname with prefix.
OMKeySetTimesRequestWithFSO calls this function and uses OmKeyInfo & doesn't revert keyName param back to leaf node name.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9082
How was this patch tested?
Manual Testing on cluster while debugging.

Thanks @swamirishi for working on this. It is a good catch.
Thanks @hemantk-12, @jojochuang, @sadanand48 for the reviews


Show line count for scan results in web app reporter

The scan-report-web-app.html shows detected licenses with start and end line:

However, for a package configuration a start line and the line count is required. To lower the possibilities for errors when writing a package configuration, I would like to have a column with the line count.

@hanna-modica Propose not to fix this in the UI but show needed package configuration in the how to fix text - do not want to add UI element for each subpart of package configuration or curation as this would bloat the UX.

Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this.


dwarf: include inlined function calls in stack traces

pretty much wip

note: https://github.com/go-delve/delve/blob/master/pkg/proc/bininfo.go#L2391-L2452


P0. SQL Lab UI / UX improvements

[ ] Less icons, more textual descriptions to simplify localization
[ ] highlight next steps in the workflow, dehighlight other buttons
[ ] provide ability to resize query and results windows
[ ] implement split view to work with multiple tabs

This issue seems to be related.


Congratulations on your AWESOME script!

Beautiful work! Hope I can implement them in the near future and share some extra ideas!
Take care!
Hugo

您的邮件我已收到，谢谢！


Batch runner

Implemented batch processing for directory.generate_report()

Before: Read all files > Process file metadata > Write to report
Now: Read batch of files > Process batch > Write batch > Read next batch > ...

The progress bar now tracks both files processed and batches processed. We no longer compute the total files, so there is no 'denominator' in the progress bar. The intent is to show that the program is indeed running (and not stuck on any file)

WIP: Documentation


Change HTTPReader to use requests module and enable streaming, minor change to test case

Stack from ghstack:

-> #51

Fixes #42. I plan to add more test in #40 that will test online readers in connection to the various archive readers.
Differential Revision: D31515974

BTW, could you please also add a corresponding PR to PyTorch Core?

BTW, could you please also add a corresponding PR to PyTorch Core?

Sure. In general, do we still intend to keep the duplicate code within PyTorch Core up-to-date even though they are deprecated?


Nuxt cannot initialize

Node version: v6.9.5
NPM version: 3.10.10
Nuxt version: latest
▶ nuxt
/Users/hsacramento/.nvm/versions/node/v6.9.5/lib/node_modules/nuxt/lib/core/module.js:14
  async ready() {
        ^^^^^
SyntaxError: Unexpected identifier
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/hsacramento/.nvm/versions/node/v6.9.5/lib/node_modules/nuxt/lib/core/index.js:2:16)
    at Module._compile (module.js:570:32)

This question is available on Nuxt.js community (#c2358)

@Duzbee I guess this is the issue of HTTPS socket server then, not Nuxt.js. Or you could roll back to 0.x, which is most probably less favourable :confused:

Update node to version 8 helped. Thanks for the help.

firebase functions is node 6-only

I am also getting this issue while trying to run firebase deploy on my nuxt project. Firebase functions are only compatible with node 6 while nuxt is compatible with node 8+, so downgrading to node 6 is not an option for me.
Anyone else having this problem?

+1

facing the same issue, is there a workaround??

I solve this problem by using last version nuxt in firebase function deploy
here package.json
{
"name": "functions",
"description": "Nuxt-SSR",
"dependencies": {
"babel-plugin-transform-runtime": "^6.23.0",
"babel-preset-stage-0": "^6.24.1",
"babel-runtime": "^6.26.0",
"clone": "^2.1.1",
"debug": "^3.1.0",
"es6-promise": "^4.2.4",
"express": "^4.16.3",
"firebase-admin": "^5.11.0",
"firebase-functions": "^0.9.1",
"lodash": "^4.17.5",
"nuxt": "1.0.0-rc11",
"vue": "~2.5.16",
"vue-meta": "^1.5.0",
"vue-router": "^3.0.1",
"vuex": "^3.0.1"
},
"private": true
}

Hi, I am also getting this issue.
/usr/local/bin/node /usr/local/lib/node_modules/npm/bin/npm-cli.js run dev --scripts-prepend-node-path=auto

><EMAIL_ADDRESS>dev /Users/marine/Documents/HETIC/OYSTR/dev/oystrapp
> nuxt

/Users/marine/Documents/HETIC/OYSTR/dev/oystrapp/node_modules/nuxt/lib/core/module.js:14
  async ready() {
        ^^^^^

SyntaxError: Unexpected identifier
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/marine/Documents/HETIC/OYSTR/dev/oystrapp/node_modules/nuxt/lib/core/index.js:2:16)

node version : v8.0.0

npm version : 5.0.0

nuxt version : 1.4.0

I'm getting this issue as well, but only when I attempt to build in a non-public dir. Everything works great when I build at ~/ however it fails at /var/task.

@MarineLB try to upgrade your node.js version to the latest 8 LTS (currently v8.11)

I have the same issue with firebase deploy on my nuxt project.
Firebase functions are only compatible with node 6
Nuxt is compatible with node 8+...
What a dilemma...... What should I choose? My project uses both Nuxt and Firebase, so I can't choose one of two...

solve it by using node v8.11.2

@clarkdo Unfortunately Google Cloud Functions, which Firebase Functions run upon only support Node 6.11.5. It fails to run the async/await code used in the Nuxt module.
Is there maybe a way to compile Nuxt itself to es6 code using Babel or something? This is really kinda my last resort here.

@meta7x
In current dev branch, we have a nuxt-legacy which is transpiled from Babel, maybe we’ll consider to add cli support on it for  supporting  the legacy node versions.

The latest build of nuxt-edge supports Node 6.x again by automatically falling back to the legacy build.

PS: Don't forget to add babel-polyfill dependency to your project if you need legacy build.

Make sure to check your Node and Nuxt version. For Nuxt 1.4.0 you need at least Node 8.0.0.

@pi0 I deployed a project using nuxt-edge and the firebase function log telling me there is a problem with babel-polyfill. This is the error
2018-06-14T12:43:26.094Z D jefrydcossr: Code in file index.js can't be loaded.
Is there a syntax error in your code?
Detailed stack trace: Error: only one instance of babel-polyfill is allowed
    at Object.<anonymous> (/user_code/node_modules/nuxt-edge/node_modules/babel-polyfill/lib/index.js:10:9)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/user_code/node_modules/nuxt-edge/dist/nuxt-legacy.js:50:1)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
2018-06-14T12:43:26.206Z E jefrydcossr: undefined
2018-06-14T12:51:04.440Z N jefrydcossr: undefined
2018-06-14T12:53:28.052Z N jefrydcossr: undefined

@meta7x node 8 worked, thanks for the help! Was using the starter template.
This page: https://nuxtjs.org/guide/installation really needs to specify that nuxt only runs on node 8 though, as not running the right version of node is breaking. Tha
As a side note, it's unfortunate how much of a pain it is to switch or upgrade node on the Mac. (and how nvm is its own little nightmare to install and use)

@janzheng I'm using n on a Mac and the version switching works like a breeze. Just $npm install -g n and then eg. n 6.11.5 should install and activate node 6.11.5 or whatever version you need.

Hmm just purely using npm doesn't work for me (throws a ton of errors), so had to go down the nvm route, but nvm was throwing other errors, so I had to go fix those. But all is well and nuxt is up and running (and it's awesome, I think it's easier to use than Middleman, which I've been running for a while)

Error: Could not compile template /home/dipesh/nuxt/nuxt1/node_modul  es/nuxt/lib/app/App.js: Cannot resolve "~assests/app.styl" from "/ho  me/dipesh/nuxt/nuxt1/assests/app.styl"
how to solve this please...

I was on node v10.8.0 when I got this, switched to v8.6.0 (using nvm) and did a redeploy and it worked.

Hey, for those having the issue on Firebase, I found the solution.
Firebase Cloud Functions now supports node 8:
https://firebase.googleblog.com/2018/08/cloud-functions-for-firebase-config-node-8-timeout-memory-region.html
What I did:

Add "engines": {"node": "8"}, in functions/package.json
Add babel-polyfill in nuxt.config.js's vendor.

+++ b/src/nuxt.config.js
   buildDir: '../functions/nuxt',
   build: {
     publicPath: '/',
-    vendor: ['isomorphic-fetch'],
+    vendor: ['isomorphic-fetch', 'babel-polyfill'],
     extractCSS: true,
     babel: {

And it worked!


Dataclasses with Dataclass-Dict-Keys fail in asdict

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.7.3
            pydantic compiled: True
                 install path: /Users/dan/miniconda3/envs/py38/lib/python3.8/site-packages/pydantic
               python version: 3.8.5 (default, Aug  5 2020, 03:39:04)  [Clang 10.0.0 ]
                     platform: macOS-10.16-x86_64-i386-64bit
     optional deps. installed: ['typing-extensions']

Thanks for all of your work on pydantic - it has been immensely valuable.
Bug report for dataclasses including Dict with other dataclasses as keys, failing to run dataclasses.asdict.
from pydantic.dataclasses import dataclass
from dataclasses import asdict
from typing import Dict

@dataclass(eq=True, frozen=True)
class A:
  a: str

@dataclass(eq=True, frozen=True)
class B:
  b: Dict[A, str]

asdict(B({A("x"):"y"}))

Yields:
Traceback (most recent call last):
  File "pydantic_asdict_demo.py", line 14, in <module>
    asdict(B({A("x"):"y"}))
  File "/Users/dan/miniconda3/envs/py38/lib/python3.8/dataclasses.py", line 1073, in asdict
    return _asdict_inner(obj, dict_factory)
  File "/Users/dan/miniconda3/envs/py38/lib/python3.8/dataclasses.py", line 1080, in _asdict_inner
    value = _asdict_inner(getattr(obj, f.name), dict_factory)
  File "/Users/dan/miniconda3/envs/py38/lib/python3.8/dataclasses.py", line 1110, in _asdict_inner
    return type(obj)((_asdict_inner(k, dict_factory),
TypeError: unhashable type: 'dict'

Looking some more, standard-library dataclasses fail the same way.
I can close if the expectation is that pydantic.dataclasses have parity with those.

Looking some more, standard-library dataclasses fail the same way.
I can close if the expectation is that pydantic.dataclasses have parity with those.

Hi @dan-fritchman
Indeed the behaviour is the same as stdlib dataclass and the error is actually "expected"
Happy new year!

Hi @dan-fritchman
Indeed the behaviour is the same as stdlib dataclass and the error is actually "expected"
Happy new year!


Compiler incorrectly rounds float32(1e-45) to 0

What version of Go are you using (go version)?
1.6

What operating system and processor architecture are you using (go env)?
linux amd64

What did you do?
https://play.golang.org/p/1zJjQLBlMK

What did you expect to see?
I want float32(1e-45) == float32(math.SmallestNonzeroFloat32) to be true

What did you see instead?
I got float32(1e-45) == 0 to be true, which is unexpected.
However float32(1.1e-45) == float32(math.SmallestNonzeroFloat32) is true, as expected.
I don't know whether there are other values that may be affected as well.  I have not tried to find the faulty code.

I think that fmt.{Print,Scan} and strconv.{Append,Format,Parse}Float are correct; at least my manual testing showed that I could perform roundtrips from math.SmallestNonzeroFloat32, and some other manually-tested values.
But I believe that the compiler is doing the wrong thing, since 1e-45 is closer to math.SmallestNonzeroFloat32 than it is to 0.  The spec says that we should "round to the nearest representable constant" and "rounding using IEEE 754 round-to-even rules" in the sections on constants and conversions, respectively.
https://golang.org/ref/spec#Constants
https://golang.org/ref/spec#Conversions
FYI the reason this is affecting me is because I have written a Go code generator, for an IDL language similar to protobufs.  My language supports generating Go constants and values.  When I generate a constant representing math.SmallestNonzeroFloat32, I end up with float32(1e-45) in my generated code, but that is broken since it is interpreted as float32(0) by the Go compiler.
Note that this is a different problem from https://github.com/golang/go/issues/12576, which has examples where very small non-zero floating-point exact constants should be rounded to 0, and the question is whether to pick -0 or 0, and we've (now) picked 0.

I guess this is related or a duplicate of #14651 ?

Yes, this is a duplicate of that bug, thank you.


Trim early analysis: faster writes/reads, less disk+memory

To validate this pull request against other sbt modules, please visit this link.


Added contributing.md file.

Added a first draft of a contributing file. Please have a look for types and other improvements.

I left some changes, mostly grammatical. Otherwise, this is a great addition, thanks once again!

Should hopefully all be addressed now. This has never been my strong suit. Neither in german nor in english.


Hi, how to generate for conditional ??

if I want to generate a special label image,  how to add condition??

You can add a custom dataset import in the datasets dataset. For details, you can refer to the way the torch is imported into the database. @Johnson-yue


Setting MESSAGE_TAGS makes messages in Wagtail loose their styles

I've set MESSAGE_TAGS in my project to use the relevant CSS classes for my project, following a BEM naming scheme:
MESSAGE_TAGS = {
    messages.DEBUG: 'messages__debug',
    messages.INFO: 'messages__info',
    messages.SUCCESS: 'messages__success',
    messages.WARNING: 'messages__warning',
    messages.ERROR: 'messages__error',
}

Unfortunately, Wagtail implicitly relies on this setting not being changed. If it is changed, the flash messages loose their colours.
Wagtail should either document that this setting is required to be set to its defaults, or it should work regardless of how this setting is set.

What is MESSAGE_TAGS? In the documentation there isn't information about it.

MESSAGE_TAGS is a Django setting. You can read more about it in the Django docs: https://docs.djangoproject.com/en/1.9/ref/settings/#std:setting-MESSAGE_TAGS


Adding support for S3-compatible Storage for Repository part

This PR is related to issue #228. I tried to keep it simple and contained, but there were too many places where it the local filesystem was taken as a guarantee. So there was a lot of refactoring involved.
I tried to follow the conventions you used in the code, but if I failed to respect some convention please let me know and I will fix it.
Apart from the strong test suite of yours, I also tested the application inside a private hosted server with the ansible setup and it worked well for both the local and for the new S3 storage. The only problem that I could find is when migrating from local to S3, but I think in a later PR someone (or me) can provide a proper command to migrate files from local to S3 storage.
Once again, if you see any problems on the PR, let me know and I will fix in a manageable time, I spend almost a month working on this, so I would like to see it merged :smile_cat: .
Thanks for the awesome tool you guys are providing for the community.

I must admit that you create very elegant commit descriptions. I appreciate :clap:

After initial testing I found two small bugs, I push a fix.
However, the scanning of packages still does not work. Look like Storage::filename return wrong path, before this PR it looks like this:
public function filename(Dist $dist): string
    {
        return sprintf(
            '%s/%s/dist/%s/%s_%s.%s',
            $this->distsDir,
            $dist->repo(),
            $dist->package(),
            $dist->version(),
            $dist->ref(),
            $dist->format()
        );
    }

As you can see, full relative path from content root is returned.

After initial testing I found two small bugs, I push a fix.
However, the scanning of packages still does not work. Look like Storage::filename return wrong path, before this PR it looks like this:
public function filename(Dist $dist): string
    {
        return sprintf(
            '%s/%s/dist/%s/%s_%s.%s',
            $this->distsDir,
            $dist->repo(),
            $dist->package(),
            $dist->version(),
            $dist->ref(),
            $dist->format()
        );
    }

As you can see, full relative path from content root is returned.

Now we are passing the $this->distDir as base for the filesystem so we shouldn't need this part anymore. I will take a look this afternoon and add more tests if needed. Same for the  Filesystem::put() problem.

Regarding: https://github.com/repman-io/repman/pull/332#issuecomment-739747234
How did you manage to reproduce the bug? Can you help me by pointing a class or giving me the exception stack trace so I can try to write a test case?

Regarding: #332 (comment)
How did you manage to reproduce the bug? Can you help me by pointing a class or giving me the exception stack trace so I can try to write a test case?

I have a package added earlier and I run security scanner for it. I think there will be the same problem for the newly added package. Security scanner probably wasn't tested externally, only as a separate service and that's why this problem.

Hi @akondas sorry for the immense delay in my response. I tried to test locally and now I am getting one error while doing the security check, is this by any chance the same error as you are getting?

If so, can you tell me why it does not get logged neither reported to sentry?

AH! I think I got it. I will fix it ASAP. 😃 I found one place where I didnt change how we are reading the Zip files. But still, I was hoping this exception was going to be reported to Sentry.

AH! I think I got it. I will fix it ASAP.  I found one place where I didnt change how we are reading the Zip files. But still, I was hoping this exception was going to be reported to Sentry.

Yes, in prod env it will be reported to sentry :wink:

Okay, I think I managed to solve this SecurityScanner problem. I will use the application a bit more locally to be sure I dont find any other problems, but I guess it is fine.

@akondas now I only have a problem with this conflict, if you could help me resolve it would be nice. I tried to resolve locally by doing a rebase, but had to run composer update --lock -W which upgraded many dependencies and ended up totally breaking the tests (and I suppose the application itself).

Yes, I can help you with this. I will correct it immediately when testing this branch

We tested everything (for the local filesystem) and it looks like it works, we still have s3 configuration to check. Due to the fact that holidays are coming, we will probably merge this branch in the first week of January. Forgive me for taking so long, but I would like to supervise this myself. Thanks for the work and Merry Christmas.

Wishing you a late Merry Christmas and all good for the new year!!! I
actually deployed this branch to production at my company to do a test run
before the holidays, if I face some problem I will also provide a patch
here. Until next year! 🖖
Pedro Tanaka
On Wed, Dec 23, 2020 at 3:18 PM Arkadiusz Kondas<EMAIL_ADDRESS>wrote:

We tested everything (for the local filesystem) and it looks like it
works, we still have s3 configuration to check. Due to the fact that
holidays are coming, we will probably merge this branch in the first week
of January. Forgive me for taking so long, but I would like to supervise
this myself. Thanks for the work and Merry Christmas.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/repman-io/repman/pull/332#issuecomment-750319653, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT5EQ2BAVFOKKQ6DPGZFDDSWH3Z5ANCNFSM4UNHXM3A
.

Hello @pedro-stanaka, I hope all is well in the new year. Tests showed that managing the private packages works flawlessly, but we had a small problem with the proxy on s3. I am attaching an error dump:

Hello @pedro-stanaka, I hope all is well in the new year. Tests showed that managing the private packages works flawlessly, but we had a small problem with the proxy on s3. I am attaching an error dump:

Okay, I will fix this ASAP. I already know the problem, the file is on remote location and fstat requires local file system file.
@akondas would it be okay if we pass the file size inside the constructor for src/Service/Proxy/Metadata.php?

Okay, I will fix this ASAP. I already know the problem, the file is on remote location and fstat requires local file system file.
@akondas would it be okay if we pass the file size inside the constructor for src/Service/Proxy/Metadata.php?

I guess that should be ok 👍. Too bad I thought fstat worked for stream data as well.

I guess that should be ok 👍. Too bad I thought fstat worked for stream data as well.

@akondas I think it should be fine now. I introduced a class for the Dist File for the proxy, because there we really only had the stream, so I added class to have information about the file size we are proxying. Hope solution is fine enough.

@akondas I think it should be fine now. I introduced a class for the Dist File for the proxy, because there we really only had the stream, so I added class to have information about the file size we are proxying. Hope solution is fine enough.

Everything seems to be working properly now. Thanks for a great job. Please delete this one comment and we are ready to merge it :tada:

Everything seems to be working properly now. Thanks for a great job. Please delete this one comment and we are ready to merge it :tada:

I will work on solution for the cli command. The symfony filesystem component is a really nice helper, but wont work with the new Flysystem adapter. I will have devise a "by-hand" solution, by iterating the contents of the distDir. Luckily this is cronjob, so no problem taking a bit more of time.

I will work on solution for the cli command. The symfony filesystem component is a really nice helper, but wont work with the new Flysystem adapter. I will have devise a "by-hand" solution, by iterating the contents of the distDir. Luckily this is cronjob, so no problem taking a bit more of time.

@akondas I managed to find a solution for the file finding. I took " inspiration" from symfony filesystem lib. Please take a look and see if this is adequate. 👍

@akondas I managed to find a solution for the file finding. I took " inspiration" from symfony filesystem lib. Please take a look and see if this is adequate. 👍

@pedro-stanaka Thank you for all your hard work on this functionality :pray: :clap: :medal_military:

@pedro-stanaka Thank you for all your hard work on this functionality :pray: :clap: :medal_military:


The Unofficial Hollow Knight RPG - Beta Test #4 - New Pages and Fixes

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: < The Unofficial Hollow Knight RPG >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: < The HKRPG Team > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: < The Unofficial Hollow Knight RPG > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[x] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[x] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < https://hkrpg-team.itch.io/hollow-knight-rpg >
[x] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
< This is a beta test for the Unofficial Hollow Knight TTRPG. More pages will be developed in the future. But as of now, I wish to give players access to what I have completed so far, as to see how affective the character sheet is at simplifying gameplay. >

Character Sheet Info Roll20 Internal Use only.

Hi @Ccmaci! It looks like your branch has conflicts with master. Please resolve them so we can merge it!

Hi NBrooks, I'm not sure what the issue with my branch, its should only be making changes to Hollow_Knight_Unofficial_TTRPG

Hi @NBrooks-Roll20 , I'm not sure what the issue with my branch is, its should only be making changes to Hollow_Knight_Unofficial_TTRPG


9.1.0 and 9.1.x crashes with ts.http.skip_remapping_set(1) and dead origin

Here "dead origin" means no origin server process running at localhost:80.
The expected result is that trafficserver returns 502.
However it crashes at 9.1.0 https://github.com/apache/trafficserver/commit/682f899871b5af5252d1c1105bf998239a2a8eb8 and the current latest commit in 9.1.x https://github.com/apache/trafficserver/commit/b8c9267caaef5ea0a71ff44ba2abacb0e8e7d656.
The current master https://github.com/apache/trafficserver/commit/40843a975fb7f76da91e8c2f9287ce841232e38a works as expected.
Also the common ancestor of master and 9.1.x https://github.com/apache/trafficserver/commit/57a1854100bc515c7ae4c2fe772cb55c936ab2bf works as expected.
# git merge-base master 9.1.x
57a1854100bc515c7ae4c2fe772cb55c936ab2bf

I tried git bisect using the following script to build and test trafficserver.
build-and-test.sh
#!/bin/bash

build() {
  autoreconf -if
  ./configure
  make -j
  make install
}

stop_trafficserver() {
  pids="$(jobs -p)"
  [ -n "$pids" ] && kill $pids
}

run_test() {
  trap 'stop_trafficserver' exit
  cat <<'EOF' > /usr/local/etc/trafficserver/proxy.lua
function do_global_read_request()
    ts.http.skip_remapping_set(1)
    ts.client_request.set_url_scheme('http')
    ts.client_request.set_url_host('localhost')
    ts.client_request.set_url_port(80)
    return 0
end
EOF

  echo 'tslua.so /usr/local/etc/trafficserver/proxy.lua' > /usr/local/etc/trafficserver/plugin.config

  /usr/local/bin/traffic_server &
  sleep 2

  curl -v localhost:8080
}

build
run_test

git bisect start 682f899871b5af5252d1c1105bf998239a2a8eb8 57a1854100bc515c7ae4c2fe772cb55c936ab2bf
git bisect run /path/to/build-and-test.sh

The first bad commit reported by git bisect is
Add dead server policy control and metric.  Improve messages. (#8213)

    (cherry picked from commit 01b91f348a919fa69ccd9727e39aae11bfca2a38)

    Co-authored-by: Susan Hinrichs<EMAIL_ADDRESS>
 doc/admin-guide/files/records.config.en.rst        | 11 +++++-
 .../statistics/core/http-connection.en.rst         |  4 ++
 include/ts/apidefs.h.in                            |  1 +
 mgmt/RecordsConfig.cc                              |  2 +
 plugins/lua/ts_lua_http_config.c                   |  2 +
 proxy/http/HttpConfig.cc                           |  6 +++
 proxy/http/HttpConfig.h                            |  4 ++
 proxy/http/HttpSM.cc                               | 24 ++++++++++--
 proxy/http/HttpSM.h                                |  5 +++
 proxy/http/HttpTransact.cc                         | 45 ++++++++++++++++------
 src/shared/overridable_txn_vars.cc                 |  2 +
 src/traffic_server/InkAPI.cc                       |  3 ++
 src/traffic_server/InkAPITest.cc                   |  3 +-
 src/tscore/BufferWriterFormat.cc                   |  8 +++-
 14 files changed, 100 insertions(+), 20 deletions(-)
bisect run success

Thank you @hnakamur . I've reproduced the issue locally on 9.1.x (b8c9267) and also verified that master (40843a975fb7f76da91e8c2f9287ce841232e38a and the latest commit which reverts incompatible changes 4208ecb8719add76aa46ab2005ff9424531e2e73) does not have the issue. I'll search for the commit on master that fixes the crash.
Re-running in gdb, here is more state information about the 9.1.x crash:
(gdb) bt
#0  0x00007fa09196337f in raise () from /lib64/libc.so.6
#1  0x00007fa09194ddb5 in abort () from /lib64/libc.so.6
#2  0x00007fa093e2d384 in ink_abort (message_format=0x7fa093e93ed0 "%s:%d: failed assertion `%s`") at ink_error.cc:99
#3  0x00007fa093e2a3b2 in _ink_assert (expression=0xb7247f "valid()", file=0xb72410 "/home/bneradt/src/ts_asf_master_fix_dead_origin_crash_on_91x/proxy/hdrs/URL.h", line=588) at ink_assert.cc:37
#4  0x00000000007c6501 in URL::host_get (this=0x7fa08ca22010, length=0x7fa08f4c32a4) at /home/bneradt/src/ts_asf_master_fix_dead_origin_crash_on_91x/proxy/hdrs/URL.h:588
#5  0x00000000008786f8 in HttpTransact::error_log_connection_failure (s=0x7fa08ca214b8, conn_state=HttpTransact::CONNECTION_ERROR) at HttpTransact.cc:3860
#6  0x0000000000878c29 in HttpTransact::retry_server_connection_not_open (s=0x7fa08ca214b8, conn_state=HttpTransact::CONNECTION_ERROR, max_retries=3) at HttpTransact.cc:3898
#7  0x0000000000877b12 in HttpTransact::handle_response_from_server (s=0x7fa08ca214b8) at HttpTransact.cc:3784
#8  0x000000000087627a in HttpTransact::HandleResponse (s=0x7fa08ca214b8) at HttpTransact.cc:3465
#9  0x000000000084d950 in HttpSM::call_transact_and_set_next_state (this=0x7fa08ca213b0, f=0x875ab4 <HttpTransact::HandleResponse(HttpTransact::State*)>) at HttpSM.cc:7391
#10 0x00000000008361df in HttpSM::state_http_server_open (this=0x7fa08ca213b0, event=3, data=0x7fa05001fa60) at HttpSM.cc:1957
#11 0x0000000000839c23 in HttpSM::main_handler (this=0x7fa08ca213b0, event=3, data=0x7fa05001fa60) at HttpSM.cc:2718
#12 0x000000000079dc57 in Continuation::handleEvent (this=0x7fa08ca213b0, event=3, data=0x7fa05001fa60) at /home/bneradt/src/ts_asf_master_fix_dead_origin_crash_on_91x/iocore/eventsystem/I_Continuation.h:219
#13 0x0000000000a7cd04 in write_signal_and_update (event=3, vc=0x7fa05001f800) at UnixNetVConnection.cc:117
#14 0x0000000000a7db4b in write_to_net_io (nh=0x7fa08f7e71a0, vc=0x7fa05001f800, thread=0x7fa08f7e3010) at UnixNetVConnection.cc:374
#15 0x0000000000a7da11 in write_to_net (nh=0x7fa08f7e71a0, vc=0x7fa05001f800, thread=0x7fa08f7e3010) at UnixNetVConnection.cc:356
#16 0x0000000000a7fcf9 in UnixNetVConnection::net_write_io (this=0x7fa05001f800, nh=0x7fa08f7e71a0, lthread=0x7fa08f7e3010) at UnixNetVConnection.cc:927
#17 0x0000000000a7374e in NetHandler::process_ready_list (this=0x7fa08f7e71a0) at UnixNet.cc:432
#18 0x0000000000a73cc3 in NetHandler::waitForActivity (this=0x7fa08f7e71a0, timeout=10000000) at UnixNet.cc:552
#19 0x0000000000ad7bb5 in EThread::execute_regular (this=0x7fa08f7e3010) at UnixEThread.cc:303
#20 0x0000000000ad7db7 in EThread::execute (this=0x7fa08f7e3010) at UnixEThread.cc:364
#21 0x0000000000ad66d0 in spawn_thread_internal (a=0x15a2f30) at Thread.cc:92
#22 0x00007fa09282c14a in start_thread () from /lib64/libpthread.so.0
#23 0x00007fa091a28dc3 in clone () from /lib64/libc.so.6
(gdb) f 4
#4  0x00000000007c6501 in URL::host_get (this=0x7fa08ca22010, length=0x7fa08f4c32a4) at /home/bneradt/src/ts_asf_master_fix_dead_origin_crash_on_91x/proxy/hdrs/URL.h:588
588       ink_assert(valid());
(gdb) l
583       -------------------------------------------------------------------------*/
584
585     inline const char *
586     URL::host_get(int *length)
587     {
588       ink_assert(valid());
589       *length = m_url_impl->m_len_host;
590       return m_url_impl->m_ptr_host;
591     }

Found the fix:
https://github.com/apache/trafficserver/pull/8191
If I cherry-pick that commit locally on my local 9.1.x branch, the crash goes away. And the description makes sense that it would match this.

Note that #8191 is marked for 9.2.x. It will be in the upcoming 9.2.0 release which we're planning to release soon.

Thank you, @hnakamur, for documenting your reproduction steps well. It helped me find the commit that fixed this.


Fix close pr action bug

This is PR for error handling in the close PR github action.
Thanks,
Henil
CC @awvwgk

@henilp105 Do you think we could rebase and merge this or is there something else preventing the merge?

yes, @gnikit we could surely merge this, I have rebased it, Thanks.

Great, thanks @henilp105


allow Request class to be provided in options (#1563)

Changes
What does this PR change? Link to any related issue(s).
Allows you to provide the Request class to use.
see: https://github.com/drwpow/openapi-typescript/issues/1563
Caused issues for us using node 20's fetch, unidici's fetch, and node-fetch in different places.
Providing back as a base for someone else to continue, I may not have time soon.
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist

[ ] Unit tests updated
[ ] docs/ updated (if necessary)
[ ] pnpm run update:examples run (only applicable for openapi-typescript)

Yup this is looking great, and what I was thinking. This will need 2 things:

A simple test (which proves the types and runtime work as-expected)
A patch changeset (see comment). Patch is sufficient because pre 1.0, minor means “breaking change” which this shouldn’t be.

I had issues with the Request & the fetch on Vercel's environment.
The fix we used was in two steps:

Provide a custom fetch for the client

export const OpenAPI = createClient<paths>({
  baseUrl: env.API_URL,
  fetch(request) {
    return fetch(request.url, request);
  },
});

Make middleware return a new Request with two arguments instead of just returning the received request

const authMiddleware: Middleware = {
  onRequest(req) {
    if (UNPROTECTED_ROUTES.some((pathname) => req.url.startsWith(pathname))) {
      return undefined;
    }

    req.headers.set("Authorization", `Bearer ${accessToken}`);

    return new Request(req.url, req);
  },
};

We lost a few hours debugging this and I'm still unsure what was the cause but it was related to the fetch + Request

Still open to this landing if this PR gets updated resolving the conflicts and passing CI! (the last commit still wasn’t mergeable).

Hey, I would really like that change. Is there any way I can help to get this merged? Seems like it's only about some linting error that unfortunately I cannot see in the logs.

Hey, I would really like that change. Is there any way I can help to get this merged? Seems like it's only about some linting error that unfortunately I cannot see in the logs.

@jscheffner it seems that it is only about linting and some conflicts, feel free to open a new PR so we can merge this.

I just ran into this requirement as well - here is the PR to implement it

I believe this PR can be closed now that https://github.com/openapi-ts/openapi-typescript/pull/1907 has been merged.

I believe this PR can be closed now that #1907 has been merged.

I agree. I think #1907 implemented this essentially as this PR did but please open a PR if we’ve missed anything!


[#4259] feat(core): support custom rest api

What changes were proposed in this pull request?

add static method fromString for Catalog.Type and Namespace
make GravitinoEnv extensional
make GravitinoServer use passed in GravitinoEnv
support custom rest api

Why are the changes needed?
Fix: #4259
Does this PR introduce any user-facing change?
yes, users now can use custom REST API packages
How was this patch tested?
test locally

@yuqi1129 @jerqi Could you please review this when you have time? Thank you!

LGTM，except minor comments

CI failure seems unrelated to the changes, do you have any other comments? @jerryshao @FANNG1

I don't have further comments, just waiting for CI to pass.


Want to work on the TODO task under Girlscript Summer of Code

Admin, I would like to work on the project.

Sure. you can look around the code-base and for queries, you can message me on Gitter

I have been working on the todo list and fixed the issues such as -

Added Subscribe Button.

Added Social Links such as Facebook, LinkedIn, Twitter, GitHub.

The subscribe and social buttons are working. Are the changes fine? @0x48piraj
Fixing more issues!

Apart from Twitter, Facebook, GitHub, LinkedIn which other social links should I add?

Thanks @NirmalKumarJoshi !
Closing the issue as the respective PRs have been merged/resolved.


Add file manifest to ASP.NET runtime packs

The runtime packs should have a manifest listing the assets, what type the assets are (managed or native), and the file and assembly versions.
Suggested format is in the following issue: https://github.com/dotnet/core-setup/issues/6409
@natemcmaster @pranavkm

Acceptance checklist (check one item)

[ ] We decided not to take this fix.
[ ] The fix is tests-only.
[x] The fix contains product changes (check all items below).

[ ] Relevant XML documentation comments for new public APIs are present.
[ ] Narrative docs (docs.microsoft.com) are updated. (check one item below)

[ ] The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
[ ] The change requires a change to an existing article. A docs PR with these changes is linked here: [PR LINK]
[ ] The change requires no docs changes.

[x] Verification has been completed. (check one item below)

[x] Verified by partner team


[nextcloud] run.sh not coping config.php back to /config when container is stopped/removed

When you stop the container, all the database, admin and data location information in config.php is lost.
By stopping or halting/deleting the container you lose the config.php file, thus having to redo the initial setup installation in nextcloud.
Mounting /config to a volume isn't good enough because the 'live' config.php file isn't copied back from /nextcloud/config/config.php :stuck_out_tongue:
Maybe a symbolic/hard link to the /config folder would be better?

The 'live' config.php is copied when the container start. But you shouldn't have an existing /config/config.php before the setup installation, this can lead to the problem you described.
Anyway I'm planning to change this to something better.

Ah ok, I must have set it up incorrectly then.

Anyway I'm planning to change this to something better.

Cool :) Managed to get it working now anyway, so if you are changing it no need to worry about this problem.


Continuous normalizing flows via flow matching

It would be great to have FMPE implemented in sbi.
There are implementations available that we could depend on, e.g.,

dingo: https://github.com/dingo-gw/dingo/blob/FMPE/dingo/core/posterior_models/flow_matching.py
lampe via zuko: https://lampe.readthedocs.io/en/stable/tutorials/fmpe.html

To Do:

check how we could integrate existing implementations into sbi
or implement from scratch
add CNF via flow matching as density estimator
add FMPE as inference method

I'd like to have a look at this.

I am also up for it, but happy to work on something else if it's better as a one person job.

This is heavily related to #962! So it would probably be good to coordinate some aspects :)


Update info on how to use paragraphs per language

Added info on how to mark blocks of text for different programming languages.

While the mage obviously should also be polyglot (duh!), I fixed the typo ;)


Building a release is manual

We need to automate release of new build with Github actions

@spuyet BTW, can you test the functionality of the resulting one-file build?
As mentioned in https://github.com/Five-Nines-io/fivenines_agent/pull/9#issuecomment-2519726445 , I couldn't test it, only you can 😅
If there's any missing dependency, we need to add it to the pyinstaller command with a --hidden-xxx (forgot the exact name) parameter to include it.

@bluet sorry didn't give you the result, it's working perfectly fine on a ubuntu 24.04 server I tested that's why I merged your PR.
Anyway I will do a complete "manual" testing on different distro when the automatic release management will be in place. If everything is good, we will be able to update the install and update bash accordingly.

@spuyet ah I see. Cool. 🚀
And I guess I misunderstood this ticket and created a duplicated issue #13 ? Are we talking about the same thing in #13 and #12?
If they are identical issues, I'll close my duplicated ticket. 😂

@bluet yup, same goal :)


Lazy.filter() should not access Lazy.value member directly

The current implementation is wrong in case the Lazy value has not yet been evaluated.

Current coverage is 94.97%

Merging #1122 into master will increase coverage by +0.01% as of a984439

@@            master   #1122   diff @@
======================================
  Files           77      77
  Stmts         9192    9193     +1
  Branches      1729    1729
  Methods          0       0
======================================
+ Hit           8729    8731     +2
+ Partial         91      90     -1
  Missed         372     372

Review entire Coverage Diff as of a984439

Powered by Codecov. Updated on successful CI builds.

Ich bin noch nicht richtig wach (wegen der ganzen Kommentare in unterschiedlichen Branches). Erstmal Kaffee++
Vielen Dank!


libpsl: don't depend on python when we cross compile

this is quite a big dependency that we don't want.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build pkgsStatic.curl curl

@ofborg build pkgsCross.aarch64-multiplatform.curl

This won't work, because Python's meta.platforms lists platforms Python can be built for, but it can't encode that it can't be cross compiled to those platforms. For example, Python supports being built natively on NetBSD, but not being cross compiled to it. We need a separate list of which platforms Python supports being cross compiled to.

Ok. I don't want to spend more time on fixing this. I will disable cross-compilation in the nix repository until someone else fixes this.


Issue with executing resizer.tcl

Hi,
what could be the reason  for  'error during executing openroad script /openlane/scripts/openroad/resizer.tcl'? please check the attachment for info.
openroad_issue_reproducible.zip

@binoy01
Update OpenLane tag to mpw-7a and run the flow again. Seems you're using mpw-5 version still

@binoy01
Let us know if its resolve the issue.


⚠ Bofrost.es has degraded performance

In f1e7997, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1506 ms

Resolved: Bofrost.es performance has improved in 29edbc3 after 6 minutes.