cant discover others when wake from hibernate

how to fix it?
cant discover others when a win10 host waked from hibernate, others can discover it.
if reboot or switch the lan of win10, then all gone well.
go 1.14
mac 10.15.3
win10 professional

That is strange! I'm not sure the reason why or how to fix.. Its very reproducible?

step of reproduce:

startup the program in win10 on a laptop, others can discover it, all ok before next step trigger;
hibernate the win10, wake up after 10 minutes;
the program still under running, keep broadcasting from log, but others can't discover it;
disable the wifi interface, then reenable,  can be discovered again.


Preview: UI inconsistencies for hover and selection of Multi-Tailed Arrows

Steps to Reproduce

Add Multi-Tailed Arrow to Canvas
Add arrow and element as on the screenshot below and observe:

Actual behavior
Can't hover on top and bottom tails, looks like they are under the element and the usual arrow
Expected behavior
TBD - they should be available for hover as in cases when two arrows or two elements are overlapped

Add arrow to compare hover area for spine and arrow

Actual behavior
Hover area for arrow is greater than for spine
Expected behavior
TBD - they should be the same

Add an image and put Multi-Tailed arrow at an image
Actual behavior
Issue with the small hover region when Multi-Tailed Arrow is above the image on Canvas:

Expected behavior
Hover area for Multi-Tailed arrow is the same as for usual arrow when it is on image:

Environmental Details:

Nightly environment (5057-hover-selection)
Desktop, Windows 11 Enterprise
Chrome Version 128.0.6613.84 (Official Build) (64-bit)

Additional context

Issue is found during exploratory testing of https://github.com/epam/ketcher/issues/5057

The issue is fixed and verified on nightly environment (5057-hover-selection):

Multi-Tailed arrow works correctly in case of overlapping;
Displaying of the hover are is still slightly greater than for Multi-Tailed arrow, but we confirmed that we can leave as it is;
It works correctly as for usual arrow when Multi-Tailed Arrow is on image;

Tested. Bug fixed.

Desktop:

OS: Windows 11
Browser Chrome
Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]


CI: add 3.5 build with numpy_dev installed by wheel from master, #12057

adds back some 3.5 deps previously missing in conda
closes #12057 (adds 3.5 wheel from nump)

this is adding a build to the allowed tests. But once we get a 2.7 wheel, total build time will be about the same. Of course we could only have a single numpy_dev build (e.g. 3.5 or 2.7), but ATM this is done in allowed failures (so its 'after' the other builds).


Video stream still active in SDP after downgrading from video to audio

I'm facing an issue when I want to remove the video stream from a call with sip.js 0.20.0.
I made a call with video :
session.invite({
  sessionDescriptionHandlerOptions: {
    constraints: { audio: true, video: true },
  },
  requestDelegate: {
    onAccept: () => {
      localVideoElement.srcObject = session.sessionDescriptionHandler.localMediaStream;
      localVideoElement.play();
    },
  }
});

The INVITE SDP is good with 2 groups:
a=group:BUNDLE 0 1
m=audio 63099 UDP/TLS/RTP/SAVPF ...
a=mid:0
a=sendrecv
...
m=video 49686 UDP/TLS/RTP/SAVPF ...
a=mid:1
a=sendrecv

Then, when I want to remove the video stream:
// Removing the video track
const stream = session.sessionDescriptionHandler.localMediaStream;
const track = stream.getVideoTracks()[0];
track.enabled = false;
track.stop();
stream.removeTrack(track);
localVideoElement.src = stream;

// Sending reinvite without video
session.invite({
  sessionDescriptionHandlerOptions: {
    constraints: { audio: true, video: false },
  },
  requestDelegate: {
    onAccept: () => {
      localVideoElement.srcObject = session.sessionDescriptionHandler.localMediaStream;
      localVideoElement.play();
    },
  }
});

The re-INVITE still contains 2 groups with a port > 10 and a direction sendrecv for the video group :
a=group:BUNDLE 0 1
m=audio 63099 UDP/TLS/RTP/SAVPF ...
a=mid:0
a=sendrecv
...
m=video 49686 UDP/TLS/RTP/SAVPF ...
a=mid:1
a=sendrecv

As this SDP doesn't changes from the first one, Asterisk doesn't send the INVITE back to the callee.
I expect this SDP to only contains an audio group.
Is there something I miss ?
Regards,
Emmanuel

I fixed the issue by removing the sender from the peerConnection :
const pc = session.sessionDescriptionHandler.peerConnection;
const videoSender = pc.getSenders().find(sender => sender.track.kind === 'video');
pc.removeTrack(videoSender);

Now the SDP has a recvonly direction for the video group.
Is this something that sip.js should handle ?


Applying hardcoded status checks

Description
Hardcode all possible check-success possibilities for the 2 desired rules of mergify.yml
Motivation and Context
As per https://docs.mergify.io/conditions.html#about-status-checks
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Implementation details
Validated previously with
→ curl -F<EMAIL_ADDRESS>https://gh.mergify.io/validate/

Codecov Report

Merging #19 (527edb0) into master (681df71) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files           2        2
  Lines          19       19
=======================================
  Hits           14       14
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681df71...527edb0. Read the comment docs.


[feature request] Control animation speed of hyprexpo

Hi @vaxerski,
Thanks for the great plugin!
I have a question around supporting a higher animation speed for hyprexpo; is this possible under the current configuration? I did a quick scan through the code and can't seem to figure out which animation category the movement is classified undre (from https://wiki.hyprland.org/Configuring/Animations/). As a result, I can't control the speed of the animation.
Is this currently supported?

not possible atm, it uses windowsMove
https://github.com/hyprwm/hyprland-plugins/blob/7a28245e5a8d30e520bc6ce8bc9b7ee177d9f2b6/hyprexpo/overview.cpp#L161-L163


Feauture request: ISM policy for OpenSearch

Unfortunately in OpenSearch, it is forbidden to create ILM policies. Instead, there is an ISM policy that we can create and attach.
That would be nice also to manage OpenSearch instances via eck-custom-resources.
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/ism.html

Hi @brainfair, sorry for the delayed response.
TL;DR answer: We might add support for ISM in the future, but maybe not in this project, but rather in the OpenSearch fork, with other OpenSearch relevant resources support.
Longer answer:
The OpenSearch is "officially" not supported, even though some resources work with it just fine because of its similarity with API. The original idea behind this operator was to add a missing support for other resources, that are not supported via Elastic's official ECK operator - that's why it's even part of the project name. Throughout the time, we removed this coupling to ECK, and this operator can now be used with any kind of Elasticsearch deployment. That's for the history, now the OpenSearch. The issue is, that there are multiple resources that do not work with OS correctly, namely the ILMs, Users, Roles, and maybe others too. It would make more sense to fork this operator and create an OS flavor, with full-blown support, that is unfortunately not on the roadmap at the moment, considering the limited time we have for this project.
Sorry for a bit disappointing news.

Hi! Thanks for the information, I think it can be closed then, maybe in the future if I have time I will make improvements myself.


Revert After/Wants message-ready from evmserverd

this change needs to be reverted since messaging isn't required at the moment

@miq-bot assign @agrare
@miq-bot add_label bug

@miq-bot add_label oparin/yes?

Backported to oparin in commit fe2bb3d30fe4dd01937f573443a0897c24498636.
commit fe2bb3d30fe4dd01937f573443a0897c24498636
Author: Adam Grare<EMAIL_ADDRESS>Date:   Fri Nov 4 10:30:41 2022 -0400

    Merge pull request #22215 from nasark/revert_msging_rdy_evmserverd

    Revert After/Wants message-ready from evmserverd

    (cherry picked from commit ece787c1f3544957b72caa2153fb91ee4102b5e6)


Support custom compilation options

Hi, I find it's very useful to add global variables for adding custom compilation options (e.g --std=c++17), how do you think?
If we agree it's a valid use case, I can compose a PR.

https://github.com/p00f/cphelper.nvim/blob/27f19bb5defc68200aa1894a78e814453d8136b9/doc/cphelper.txt#L74-L78
Are you thinking of something else?

sorry didn't notice this one, it's exactly what I want! Thank you


Too many events detected, lack of grouping

While running the dev server I got this log:
[2022-01-24T11:12:33Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:33Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:34Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:34Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:34Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:34Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:34Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:35Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:35Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:35Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:35Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:35Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:36Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:36Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:36Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:36Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:36Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:37Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:37Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:37Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:12:37Z INFO  xtask_wasm] Changes detected. Re-running command

When activating the trace logs I noticed this:
[2022-01-24T11:16:46Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/index

So it looks like the hidden directories are not properly ignored.

I got more logs:
[2022-01-24T11:28:51Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/objects/75/bc2fdbf6c99d0b400b31f9b40928c380008662
[2022-01-24T11:28:51Z TRACE xtask_wasm] Killing watch's command process
[2022-01-24T11:28:51Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:28:51Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/objects/5c/8b42456a5942dc06653c3b43c51066fcde1270
[2022-01-24T11:28:51Z TRACE xtask_wasm] Killing watch's command process
[2022-01-24T11:28:52Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:28:52Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/objects/5d/ae8663d25ddbddb7d1973058c4e9ab7a5ae243
[2022-01-24T11:28:52Z TRACE xtask_wasm] Killing watch's command process
[2022-01-24T11:28:52Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:28:52Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/index
[2022-01-24T11:28:52Z TRACE xtask_wasm] Killing watch's command process
[2022-01-24T11:28:52Z INFO  xtask_wasm] Changes detected. Re-running command
[2022-01-24T11:28:52Z TRACE xtask_wasm] Changes detected in /home/cecile/repos/hytune-web/.git/COMMIT_EDITMSG
[2022-01-24T11:28:52Z TRACE xtask_wasm] Killing watch's command process
[2022-01-24T11:28:52Z INFO  xtask_wasm] Changes detected. Re-running command

Clearly it's detecting changes in the .git directory.

Yeah, the is_hidden_path function check if the filename starts with ..
My bad, looking to fix


Is there a way to clear the index? (Removing all docs)

I need this for testing purposes.

There is no clear method available on index to do this. If you want a fresh index you should just create a new, empty index. Outside of testing purposes I don't really see the need for such a function.

@olivernn im in need of this functionality because we load all documents into memory so they can be search quickly, but we need a way to update the docs in memory by clearing the indexed data and reloading it.

@patrickml do you need to update all the documents at once, or individually?
You can update a single document in the index using the lunr.Index.prototype.update method, this actually just removes and then re-adds the document.
If you are doing this in bulk then it really is simpler to just create a whole new index, is there something I missing that means this approach won't work for your use case?


[Textfield - Vue] Can no longer access setPrefixText / setSuffixText functions

I have had no issues with this for months but after adding bottomsheet to my original app, I noticed this function no longer works. Can anyone help me out? This is a very critical part of the app I'm building.
PS: I do not know if this issue is Vue specific

Created a new Nativescript-Vue project and setup material-components.
Installed Textfield plugin
Here's how I call the function:

<template>
  <StackLayout>
    <MDTextField
      @loaded="loaded"
      :text="user.contact"
    />
  </StackLayout>
</template>

<script>
export default {
  methods: {
    loaded({ object }) {
      object.nativeView.setPrefixText('+63')
    }
  }
}
</script>

I just get setPrefixText is not a function but this function is accessible if I try to build in Android Studio. Material Design spec also lists this function so I guess the issue lies with a recent change in this plugin.

CLI: 6.7.4
Platform: 6.5.1
Plugins: Defaults + Material Textfield

I dont think  it has anyhthing to do bottomsheet per say.
It must be the version of android material library. You should check which one is used in one case and the other.

I've always just relied on the version the plugin shipped with in both cases. Thanks for the idea, I used nativescript's hooks to add the right library before the plugin. Had to dig to try the three most recent versions until I found the one that worked like before.

@kryoware can you please reference the version for other users?
Thanks

@farfromrefug version 1.2.0-alpha01 worked as intended for me, and did not affect the other material components. Hope it helps, cheers!

@kryoware ok that s the one i use too. Thanks


DRAFT: Added Cypress Axe.

Fixes issue #20 using cypress axe.
Signed-off-by: Donald Labaj<EMAIL_ADDRESS>

@dlabaj few outstanding questions that are blocking this being merged (post-rebase)


Monkey patch the standard dpkg Package provider

The held_apt and held_aptitude providers exist just to "remove" this line.
What we want is for Puppet to stop exposing the "held" state as one of the values that the ensure property can take. The standard behaviour for Puppet, when a held dummypkg package is pinned to version 0.0.3 in the catalog, is to always:
Notice: /Stage[main]/Main/Package[dummypkg]/ensure: ensure changed 'held' to '0.0.3'

The catalog never converges, as discussed in #3. Another PR (not from us) deals with the same subject. The worse thing about this behaviour is that services depending on dummypkg will be restarted even though, effectively, no packages were upgraded.
The issue with held_aptitude/held_apt is that you need to explicitly use them. held_apt is set as defaultfor :osfamily => :debian, but some vendor modules do this, not allowing the defaultfor to work.
With @oholiab, we tried a different approach:

Get rid of both held_apt and held_aptitude.
Monkey patch dpkg.
Add a test case for explicit uses of provider => 'apt'.

held_aptitude and help_apt are risky because you need to make sure no traces of aptitude or apt are left in your catalog.  The new approach looks safer, unless there's a way for dpkg to be loaded after the code in zz_no_hold_dpkg.rb.
Test run output (2.4MB).
/cc @hashbrowncipher

It's worth pointing out here that this circumvents the problem of vendor modules specifying dpkg-based providers and that the monkey patch is more semantically correct (as package holding is totally orthogonal to package version) than the upstream puppet provider.


[MBUILDCACHE-67] Bugfix artefact restoration error not handled properly

Description of this pull request
https://issues.apache.org/jira/projects/MBUILDCACHE/issues/MBUILDCACHE-67

Fix artefact restoration error was not executing the regular project build as expected
Fix non-lazy artefact restoration was in fact partially lazy
Added an IT test on this

Draft until PR-MBUILDCACHE-64 is merged since I want to factorize a function in the IT test (see the related todo).
MR checklist
Following this checklist to help us incorporate your
contribution quickly and easily:

[x] Make sure there is a MBUILDCACHE JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without
pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
[x] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[x] In any other case, please file an Apache Individual Contributor License Agreement.

Hello there,
A little up on this old-timer PR. If I'm correct I fixed every mandatory request.
Any other thought?


Feature/add dto layer

Overview:
This PR introduces several enhancements and corrections to the library management system, particularly focusing on the API functionalities and code maintainability. Below are the detailed changes made:
1.Added Data Transfer Object (DTO) Layer:
Implemented a DTO layer for the module whose entity is exposed in the controller. This change facilitates data encapsulation and improves the separation of concerns.
2.Corrected Borrowing API (BorrowBook API):
Resolved an issue where the BorrowBook API was returning null for both book and member records. The API is now functioning correctly and provides the expected output.
3.Updated Return Book API:
The Return Book API was previously not returning any value. This has been corrected, and the return structure now aligns with the borrowing API documentation.
4.Lombok Dependency Implementation:
Integrated Lombok to reduce boilerplate code. Getter and setter methods, as well as constructors, have been generated using Lombok annotations, enhancing code readability and maintainability.
5.Introduced ModelMapper:
Implemented ModelMapper to facilitate seamless conversion between DTO and entity objects, ensuring cleaner and more efficient data handling.

6.API Testing:
Conducted thorough testing of all APIs using Postman to ensure that all functionalities are working as expected.

Feature/add dto layer
#52


change fvar value type to double for efficiency

There's a very large (factor of around 2 at second order, more at third order) efficiency in the current implementation of fvar for our intended uses.  It currently uses the template type for both values and tangents.
template <typename T>
struct fvar {
  T val_;
  T d_;
  ...
};

This winds up propagating all kinds of derivative information to values which we never use.
New Approach
What we do use is fvar<var> and fvar<fvar<var> >.  In both of these cases, we can get away with a double value type.

[ ] Change storage type to the following
[ ] Deal with resulting test and compilation storm

struct fvar {
  double val_;
  T d_;
  ...
};

Example of Savings at Second Order
For example, multiplying two fvar instances a and b gives you value a.val_ * b.val_ and tangent a.d_ * b.val_ + a.val_ * b.d_.
var:  value) varvar; tangent) varvar, varvar, var+var
double:  value) doubledouble;  tangent) vardouble, doublevar, var+var
double * double: 0 nodes, 1 multiply
var * double: 1 node, 1 multiply (val), 1 multiply (adjoint), 1 add (adjoint)
var * var: 1 node, 1 multiply (value), 2 multiplies (adjoints), 2 adds (adjoint)
var + var: 1 node, 1 add (value) 2 adds (adjoint)
Total original: 4 nodes, 9 multiply, 9 add
Total new: 3 nodes, 5 multiply, 5 add
By removing a node, there's less pointer chasing to chain() implementations and one fewer constructor called.
As an added bonus, it'll save 25% of the memory used in a multiplication (half in an addition).

This issue was moved to stan-dev/math#61

@bob-carpenter Didn't you decide that this wouldn't work based on how we calculated the Hessian?


Jcenter is failed

implementation("de.adorsys.android:securestoragelibrary:1.2.4") Jcenter is failed. , I use this project in android application
but in jetpack actually only 0.0.2

Same issue here, did you maybe find a solution to this, @TonyLead ?

Hey, this project is deprecated and not actively maintained any more


Update install prereqs python fix

-Updated install_prereqs when using 22.04
-Added new Dockerfile for Ubuntu 22.04 used for testing
-Kept removed items commented in new dockerfile for visibility in this PR, can remove later.
Tested and ran with Navi10 and MI250 servers and make check passes

LGTM, testing ubuntu2204 dockerfile on my Navi21 system just in case

Looks to work


fix: fixed sorting of package.json with fixpack, added jsdelivr/unpkg

closes #342

once this PR is merged I can remove the comment here https://github.com/niftylettuce/frisbee#vanillajs

also I saw that you are missing a "homepage" property in package.json - you may want to add that too!

Nice thanks. I’ll release once I’m back at my laptop

ping me once you release! thanks @stefanpenner

or feel free to add me to npm and github, I can gladly help maintain this

add homepage prop: https://github.com/stefanpenner/es6-promise/pull/344
Also, fixpack is pretty cool!

or feel free to add me to npm and github, I can gladly help maintain this

Reducing buss factor is always good, do you have any specific ideas or just helping mitigate the buss factor problem that node modules often have?

released as v4.2.6 🎉

thank you 👍


Tier 3 Does not deploy policy like the mlz.bicep core.

Description
Tier 3 should deploy policy, defaulting to the policy deployed by the mlz.bicep core but as an overwritable parameter
Steps to Reproduce
deploy mlz.bicep with NIST
deployPolicy=$true `
policy="NIST"
Deploy Tier 3
Expected behavior
Tier 3 deploys the same policy as the core
Actual behavior
Tier 3 does not deploy policy
Screenshots
Additional context
Operating System:
Terraform Version:
Cloud (public, Azure Government, etc.):

This was already completed as per:
https://github.com/Azure/missionlz/pull/728
Closing out this item.


⚠ Bofrost.at has degraded performance

In 282cc52, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2251 ms

Resolved: Bofrost.at performance has improved in d106a00 after 6 minutes.


macOS w/ .NET Core 2.0 not working with Visual Studio for macOS

Create a simple MVC project (template) in VS for macOS.
If I run it from the command line dotnet run --urls "http://*:5001" voila works as expected.
If I run run from within VS for macOS, the browser sits and spins forever. I can step through the Startup class methods, but the view controllers are never loaded.
If I do
var host = new WebHostBuilder()
    .UseKestrel()
    .Configure(app =>
    {
        app.Run(async (context) => await context.Response.WriteAsync("Hi!"));
    })
    .Build();

host.Run();

It spits out Hi! as expected.
Simply cannot get an MVC project using .NET Core 2.0 working in VS for macOS.
.NET Core 1.1 worked fine.

If I run run from within VS for macOS, the browser sits and spins forever. I can step through the Startup class methods, but the view controllers are never loaded.

Do you mean the views or the controllers? Can you step into the controller?
I just tried to do this and it worked for me:

David - it won't let me step into View Controllers, doesn't hit filters, etc.
I'll resinstall in a bit and see if that fixes.

What is a View Controller?

A separate question. Intellisense does not work in the cshtml file on VS Mac. For example, if I start typing "Microsoft." within C# @{  Microsoft.  }   - don't get anything.

@davidfowl
Any - dropped break points in all of them. Video: https://www.youtube.com/watch?v=S_ENe3XIo4U&feature=youtu.be
Here is the console output. See the request but nothing is picked up
Hosting environment: Development
Content root path: /Users/harold/Projects/testproject2/testproject2
Now listening on: http://localhost:5001
Application started. Press Ctrl+C to shut down.
Loaded '/usr/local/share/dotnet/shared/Microsoft.NETCore.App/2.0.0/System.Numerics.Vectors.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/local/share/dotnet/store/x64/netcoreapp2.0/system.runtime.compilerservices.unsafe/4.4.0/lib/netstandard2.0/System.Runtime.CompilerServices.Unsafe.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:5001/
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://localhost:5001/
Loaded '/usr/local/share/dotnet/store/x64/netcoreapp2.0/microsoft.aspnetcore.http.extensions/2.0.0/lib/netstandard2.0/Microsoft.AspNetCore.Http.Extensions.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/local/share/dotnet/store/x64/netcoreapp2.0/microsoft.aspnetcore.razor/2.0.0/lib/netstandard2.0/Microsoft.AspNetCore.Razor.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/local/share/dotnet/store/x64/netcoreapp2.0/microsoft.aspnetcore.html.abstractions/2.0.0/lib/netstandard2.0/Microsoft.AspNetCore.Html.Abstractions.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.

A separate question. Intellisense does not work in the cshtml file on VS Mac. For example, if I start typing "Microsoft." within @{ Microsoft. } - don't get anything.

Razor intellisense isn't supported in VS for Mac as yet.

@h3smith I see a white screen in your repro. Show me the Startup class. Are you sure MVC is wired up? Here is what mine looks like:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;

namespace MyMvcCore20App
{
    public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddMvc();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
            }

            app.UseStaticFiles();

            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller=Home}/{action=Index}/{id?}");
            });
        }
    }
}

Startup as expected as is Program

    public class Program
    {
        public static void Main(string[] args)
        {
            BuildWebHost(args).Run();
        }

        public static IWebHost BuildWebHost(string[] args) =>
            WebHost.CreateDefaultBuilder(args)
                .UseStartup<Startup>()
                .Build();
    }

    public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        // This method gets called by the runtime. Use this method to add services to the container.
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddMvc();
        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            else
            {
                app.UseExceptionHandler("/Home/Error");
            }

            app.UseStaticFiles();

            app.UseMvc(routes =>
            {
                routes.MapRoute(
                    name: "default",
                    template: "{controller=Home}/{action=Index}/{id?}");
            });
        }
    }

@davidfowl - uninstalled VS for macOS, reinstalled Core, updated macOS and working now. Some part of that combination was being strange.
Thanks for the help and sorry to waste time.

@davidfowl - with respects to this - i get the same after stopping, building, and debugging the app over on macOS. Is this the right repo or is there a place to report (correctly) issues for VS for macOS?
The only solution when it happens is to completely reboot my Macbook.


ILogger structured logging with Application Insights not working in .Net 5 Azure Function

.Net 5 Azure Function: Custom properties of ILogger generated messages are not showing up in Application Insights
Example:
logger.LogInformation("Example {ExampleValue}", 1001);
Expected in Application Insights log:
customDimensions.prop__ExampleValue == 1001
customDimensions.prop__{OriginalFormat} == "Example {ExampleValue}"
However, the only thing that is logged is the message as string:
message == "Example 1001"
This makes structured logging impossible and logging to Application Insights useless, as no proper filtering can be applied.
Other non-working examples:
using (_logger.BeginScope("ScopeTest"))
{
     _logger.LogInformation("Scope logging test"); //Logs only the string, scope missing
}

Dictionary<string, string> properties = new Dictionary<string, string>()
{
     { "Prop1", "abc" },
     { "Prop2", "def" },
};
 _logger.LogInformation("CustomProperties", properties); //Logs only the string, dictionary content missing completely

+1 logging with ILogger currently sends the traces over grpc to the functions worker host.
I believe this somewhat relates to #410 . When activity popagation is handled correctly, it should be able to just use regular application insights logging (and dependency tracking etc) in the dotnet worker. That way, all the application insights telemetry is correctly visible in the azure portal in one operation.

@brettsam for awareness

I've opened https://github.com/Azure/azure-functions-host/issues/7452 to support this in host. Once supported, we'll work through this on the worker side.

This has been a pretty big pain point for my team after migrating to dotnet-isolated so we could use .net 5. None of our expected customDimensions have been showing up so we have switched to including the dictionary values passing into the message instead so we can at least see what is going on. This breaks all of our aggregations in application insights for alerts and reporting.
Any suggestions or alternatives for working around this issue?

This has been a pretty big pain point for my team after migrating to dotnet-isolated so we could use .net 5. None of our expected customDimensions have been showing up so we have switched to including the dictionary values passing into the message instead so we can at least see what is going on. This breaks all of our aggregations in application insights for alerts and reporting.
Any suggestions or alternatives for working around this issue?

Any news about workaround? (.NET 5 or .NET 6)

As a workaround, I thought of adding a custom logger factory that would create an ILogger that doesn't flow through the host GRPC channel and would connect directly to Insights. In theory it should work, but we would loose all console and stream logs in Azure and local dev and would be forced to rely on Insights for ANY diagnostics. If we try to keep the connection to GRPC, to also show in the stream logs, Insights would get duplicated entries with and without the structured information.
It should work, but I didn't have the time to try and test it yet.
This NEEDS to be FIXED soon. It is a very serious bug. From the looks of it, I'm worried that it might only happen for .NET 7, but that would be a serious case of not giving enough importance to very important community feedback. This specific issue is already 7 months old, and it was not the first on this problem.
If the intention really is to have only isolated process in .NET 7, as the roadmap suggests, EVERYTHING that work in process will need to work in isolated, including structured logs.
Please make it available as a fix in 6, not only in 7!

As a workaround, I thought of adding a custom logger factory to DI that would create an ILogger that doesn't flow through the host GRPC channel and would connect directly to Insights. In theory it should work, but we would loose all console and stream logs in Azure and local dev and would be forced to rely on Insights for ANY diagnostics. If we try to keep the connection to GRPC, to also show in the stream logs, Insights would get duplicated entries with and without the structured information.
It should work, but I didn't have the time to try and test it yet.
This NEEDS to be FIXED soon. It is a very serious bug. From the looks of it, I'm worried that it might only happen for .NET 7, but that would be a serious case of not giving enough importance to very important community feedback. This specific issue is already 7 months old, and it was not the first on this problem.
If the intention really is to have only isolated process in .NET 7, as the roadmap suggests, EVERYTHING that work in process will need to work in isolated, including structured logs.
Please make it available as a fix in 6, not only in 7!

Good idea, but what about the "End-to-end" functionality? Because I tested with Serilog (directly in Application Insight) and I lost this functionality.
I also agree with @kelps, this bug is very serious.

Is there any plan to fix this bug soon? We recently upgraded to .NET 5 and this caused an issue now with our structured logs in app insights.

Is there any plan to fix this bug soon? We recently upgraded to .NET 5 and this caused an issue now with our structured logs in app insights.

@bricenocar the problem only happens when running in dotnet isolated mode. If you migrated to .net5, you probably can make your functions using "int process" mode, and there structured logs work. (Unless you changed to isolated in .net5 to take advantage of some of the new features. In that case, no luck yet, except if you try something similar to what I suggested above...)

Thanks for the answer @kelps. I will try to fix it with your workaround :). Will let you know if it works.

After spending a lot of time trying to get it working with .NET 6 / isolated process Azure Functions I stumbled across this issue 😢
Any updates on when this will be looked at? Thanks

Over the weekend I tried playing with a workaround for this a little. My original idea was "bad" as I intended to replace the logger factory with one that would create the ILogger for insights without flowing through the GRPC channel.
I realized that this is not necessary. What I need to do is add an Insights log provider in the worker process and disable my log sources from going to Insights in the host process. This way, the logs will keep flowing and showing in the Log Stream.
I didn't go far with that idea for lack of time, but I plan on continuing those tests soon. I believe this workaround has a real chance of working and be quite simple to implement, once I find the proper way to register the Insights logger provider in the worker process. The configuration to disable my logs from going to Insights in the host already worked.
This will also have the extra benefit that I'll be able to set my custom logs as debug or trace when needed, since as it is now the filters in the host seem to prevent me from logging or even seeing my custom logs on any levels lower than Information, no matter what I configure.
I'll post updates here about the workaround, as soon as I try again, working or not.

Well, looks like it is working for us now. We have implemented net6 and function v4 (We were using net5 - v3). We have also added the following code in Program.cs
.ConfigureLogging((context, builder) => {        builder.AddApplicationInsights(context.Configuration["APPINSIGHTS_INSTRUMENTATIONKEY"]); }).Build();
BE SURE to use "Instrumentation key" and not the connectionstring. I have tested with connectionstring and it is not working.
When writing structured logs, we are using the ILogger from the function context:
var logger = context.GetLogger("YourClassName");
And then a BeginScope...
In application insights we see the properties now, and the pretty cool thing is that it is showing the actual property name without the prop prefix it used to show previously. Cool stuff!
Maybe Microsoft just fixed this? not sure but it is working now like a charm!
Let me know if you need more info ;)
Cheers!

@juanbriceno thanks for the update, will give it a go. What extra nuget packages need to be referenced to use the AddApplicationInsights extension method? Thanks

Oh! @WestDiscGolf that is a good one. I forgot about the packages :)  We have updated all the packages to the very latest versions.
This is the one for adding appinsights:
-Microsoft.Extensions.Logging.ApplicationInsights (2.19.0)
Let me know how it goes ;)

Thanks @juanbriceno! Will give it a go 😄

If anyone is struggling to get this working, make sure you're on a windows host and not a Linux one. I feel I've lost too many hours because I chose "linux consumption" 😞

Well, looks like it is working for us now. We have implemented net6 and function v4 (We were using net5 - v3). We have also added the following code in Program.cs
.ConfigureLogging((context, builder) => {        builder.AddApplicationInsights(context.Configuration["APPINSIGHTS_INSTRUMENTATIONKEY"]); }).Build();
BE SURE to use "Instrumentation key" and not the connectionstring. I have tested with connectionstring and it is not working.
When writing structured logs, we are using the ILogger from the function context:
var logger = context.GetLogger("YourClassName");
And then a BeginScope...
In application insights we see the properties now, and the pretty cool thing is that it is showing the actual property name without the prop prefix it used to show previously. Cool stuff!
Maybe Microsoft just fixed this? not sure but it is working now like a charm!
Let me know if you need more info ;)
Cheers!

Excellent! I'll try that tomorrow. But just fyi, this is in line with the fix I was planning, I just didn't get to the correct way to register it.
In other words, there was nothing fixed on Microsoft side yet. What you did was make  your logs be registered on Insights directly from the worker process, instead of the host process as is the default.
I only suggest you disable Function logs to Insights in the host process, to prevent duplicated logs. I'm on my phone now,  so I can't post an example of this setting, but I'll do it tomorrow when I get at the office.
I might even adopt this as my default for logging, even if this gets "fixed" in the functions sdk, just for the benefits of better control of the log levels, better naming of the custom dimension properties (without the Prop_ prefix)

Yeah, i think this way should work. I tried by clearing all logging providers first and then adding AddAppInsight line but it removed the console logger. If you check the providers within the builder property, you will see the console provider but i did not see any other. In my head, the built-in appinsight one is not being inyected in this version so it has to be done manually, which i'm fine with it cause we have kind of full control over the whole logging configuration/functionality.
Maybe Microsoft will go this way or maybe they are inyecting it in a new update.
Good work everyone and have a nice weekend!

As promissed, here is the host.json in my test project. The loglevel block inside applicationInsights is what disables the Function logs from being recorded to Insights from the host process. Since the configuration you showed above will already be sending those logs to Insights from the worker process, in theory we don't loose anything and we actually gain more control. Ignore the extensions part (it is related to service bus triggers)

  "version": "2.0",
  "logging": {
    "applicationInsights": {
      "samplingSettings": {
        "isEnabled": true,
        "excludedTypes": "Request,Trace"
      },
      "logLevel": {
        "Function": "None"
      }
    },
    "logLevel": {
      "default": "Information",
      "Function": "Information"
    }
  },
  "extensions": {
    "serviceBus": {
      "messageHandlerOptions": {
        "maxConcurrentCalls": 1
      }
    }
  }
}

@kelps No worries, totally understand, just thought I would ask 😄
Hope you have a Happy Christmas 🎄

Hi @WestDiscGolf , maybe a dumb question but i think is good to double check all configurations. It will be net6 and v4 in the azure function project and check also the azure function app configuration:
FUNCTIONS_EXTENSION_VERSION --> ~4
FUNCTIONS_WORKER_RUNTIME --> dotnet-isolated
Also make sure you are passing the APPINSIGHTS_INSTRUMENTATIONKEY instead of connectionstring (double check the value in the Azure function configuration value).
My host.json file looks like this now...
{   "version": "2.0",   "logging": {     "applicationInsights": {       "samplingSettings": {         "isEnabled": true,         "excludedTypes": "Request"       }     }   },   "functionTimeout": "00:05:00"   }

Hi @juanbriceno, no worries about validating 😄
My csproj file is:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <AzureFunctionsVersion>v4</AzureFunctionsVersion>
    <OutputType>Exe</OutputType>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" Version="2.20.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.0.13" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="1.3.0" OutputItemType="Analyzer" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.6.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.20.0" />
  </ItemGroup>
  <ItemGroup>
    <None Update="host.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
    </None>
    <None Update="local.settings.json">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <CopyToPublishDirectory>Never</CopyToPublishDirectory>
    </None>
  </ItemGroup>
</Project>

Yes, the output of those variables are when published to a windows consumption plan are:
Version: ~4

Runtime: dotnet-isolated

And yes, I'm using the APPINSIGHTS_INSTRUMENTATIONKEY. Interestingly when I output the values of those environment variables when running the functions app in Visual Studio the version value is not present but the core tools output in the console window confirm v4.

Looks good. Now when it comes to the code (structured logs) i am doing it this way...
`
[Function("PostFile")]
public async Task Run([HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = null)] HttpRequestData req, FunctionContext context)
{
var logger = context.GetLogger("PostFile");
using (logger.BeginScope("Operation {MCOMOperationTrace} processed request for {MCOMLogSource}.", "PostFile", "Archiving"))
{
// Here your logs.....
`

It's coming through fine but still getting double entries from both the function and the logger (if that makes sense) which @kelps's solution tries to get rid of but unfortunately I can't get to work. I also can't get it to log anything other than Critical, Error, Information or Warning locally so any debug level items get missed (locally and in AppInsights). Might have to call it a day and stick with in process functions for now 😢
Thanks for all your help in trying to get this working!

It's coming through fine but still getting double entries from both the function and the logger (if that makes sense) which @kelps's solution tries to get rid of but unfortunately I can't get to work. I also can't get it to log anything other than Critical, Error, Information or Warning locally so any debug level items get missed (locally and in AppInsights). Might have to call it a day and stick with in process functions for now 😢
Thanks for all your help in trying to get this working!

Ok, I was just able to test this and the structured logs did get recorded, but with some "missing" information and as you mentioned, my attempt at fixing the duplicated log to insights didn't work.
Also, as far as I can tell, the minimum log level can only be set in code. If you call SetMinimumLevel(Trace) in your program.cs, it will log traces and debugs, but when you do that, it ignores the settings in configuration. That could be the reason we can't properly configure this (the host process could be setting the configurations in code, wich overrides the settings in files and the portal)
The missing information are a few fields that are set in the logs that come from the host but not in the logs that come from the worker process: logLevel, ProcessId, HostInstanceId, cloud_RoleName, operation_Name, operation_id, operation_ParentId
There is probably a way to set this values in scopes or some other way. I didn't investigate this yet.
The bad thing about switching to in-process would be:

we loose control over the versions of some of our dependencies, when the host also has the same dependency, being limited to the version used by the host process.
no middleware support (I'm using middleware for error handling/logging) and plan on using it for other cross concerns as well, like auth.

The correct fix would be for the host process to properly support scopes flowing through the GRPC channel and also to respect the settings defined in the hosts files (log levels lower than Information and different log level by provider, for example). Another thing would be that the structured logs respected the key names we generate instead of attaching a "Prop_" prefix. If they do this to prevent name collision, they should add the prefix to their properties, not ours. We should have full control over how our logs are generated.
An alternative fix would be for the host to simply respect our settings. This way the settings above would've disabled the Function logs to Insights, allowing us to log the way we need without duplication. That could be the simpler way to fix this mess...

It's been about 2 months since my last post about this issue and I don't see any news about it being fixed or even being addressed/planned. I am about to put code in production with my workaround, even with the logs getting duplicated in order to be able to have good logs. ANY news on this would be really appreciated!

Thanks for the workaround! This at least allows structured logging, although with duplicates. Anyhow, there are still too many things not working in regards of Application Insights. The dependency map shows the Function App isolated, calls from the Function App to other web-services or Azure Storage etc. are not visible at all... And no one seems to be working on these serious bugs.
This is really frustrating. Overall the solution seem not to be enterprise ready.

Is there a plan forward with this item?
@brettsam @fabiocav it doesn’t seem to be mentioned as much as the other App Insights issues, etc. and seems to have been lost in the ether :/

Does context.Features.Get<RequestTelemetry>() work in Azure Functions v4 net6 Isolated Middleware? I tried to access it but got a null reference exception. Same for Activity.Current.AddBaggage(...).

I have no idea how I missed this entire conversation; I apologize for the delay here.
The approach we've taken is to have logging go directly to App Insights from the worker (as was proposed here). This uses the App Insights logger with very minimal changes (no "prop_" appended, for example).
Give the newer package a try and see if it works how you'd expect: https://github.com/Azure/azure-functions-dotnet-worker/pull/944#issue-1282987627https://github.com/Azure/azure-functions-dotnet-worker/pull/944#issue-1282987627.

I have no idea how I missed this entire conversation; I apologize for the delay here.
The approach we've taken is to have logging go directly to App Insights from the worker (as was proposed here). This uses the App Insights logger with very minimal changes (no "prop_" appended, for example).
Give the newer package a try and see if it works how you'd expect: #944 (comment).

We are using the new preview package in https://github.com/Energinet-DataHub/geh-charges/ configured here https://github.com/Energinet-DataHub/geh-charges/blob/main/source/GreenEnergyHub.Charges/source/GreenEnergyHub.Charges.FunctionHost/ChargesFunctionApp.cs with these packages https://github.com/Energinet-DataHub/geh-charges/blob/main/source/GreenEnergyHub.Charges/source/GreenEnergyHub.Charges.FunctionHost/GreenEnergyHub.Charges.FunctionHost.csproj
But when we use it we get some wierd extra logging messages and sometimes only those
https://github.com/Energinet-DataHub/geh-charges/issues/1882 an information message with some prefixed text and without the custom properties we have specified

Looks like this is still broken.
Probably should add this to the execution mode comparison document, so people (like me) don't waste their time upgrading to .NET 7 and realize logging, custom metrics and dashboards that rely on structured logging get hopelessly broken.
if you like some pakour, see https://github.com/Azure/azure-functions-dotnet-worker/issues/1182 for some guidance on how to get some of it to work. Though probably not for production.

The following code in .NET 8 isolated worker is not adding customDimensions. Could this issue still be open after 2+ years?
            using (logger.BeginScope(new Dictionary<string, string> {
                { "Entity", entity },
                { "CorrelationId", correlationId },
                { "Function", function },
                { "EventType", eventType.ToString() }
            }))
            {
                logger.Log(Microsoft.Extensions.Logging.LogLevel.Information, dataEventTemplate, entity, correlationId, function, eventType.ToString(), message);
            }

The following code in .NET 8 isolated worker is not adding customDimensions. Could this issue still be open after 2+ years?
            using (logger.BeginScope(new Dictionary<string, string> {
                { "Entity", entity },
                { "CorrelationId", correlationId },
                { "Function", function },
                { "EventType", eventType.ToString() }
            }))
            {
                logger.Log(Microsoft.Extensions.Logging.LogLevel.Information, dataEventTemplate, entity, correlationId, function, eventType.ToString(), message);
            }

Try Dictionary<string, object>.

Alas, it made no difference.

Alas, it made no difference.

Well that's a bummer. I have been able to make .net8 structured logging with scopes working in prior projects, but I've always used the <string, object> dictionary type as <string, string> hasn't worked in the past for me. I'd double check the installed package versions and the dependency injection setup. Double check this issue as there was an initial workaround: https://github.com/Azure/azure-functions-dotnet-worker/issues/1182

The relevant installed packages:

Microsoft.Azure.Functions.Worker.ApplicationInsights 1.1.0
Microsoft.ApplicationInsights.WorkerService 2.22.0

Injection code:
        // Add console logging
        services.AddLogging(loggingBuilder =>
        {
            loggingBuilder.AddConsole();
        });
        services.AddApplicationInsightsTelemetryWorkerService();
        services.ConfigureFunctionsApplicationInsights();

If you've been able to get structured logging with custom dimensions working in .net 8 isolated azure functions, could you perhaps provide some code snippets of your injection and logging code?

Guidance and additional information about this problem is available here
Closing this as answered.


HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

Branch-2 compatible PR, after cherry-picking and resolving conflicts

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
branch-2 passed

+1 :green_heart:
checkstyle
1m 19s
branch-2 passed

+1 :green_heart:
spotbugs
2m 14s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
checkstyle
1m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m  4s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

34m 40s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2453

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 72fdd3b09184 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 505ceacb4b

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 22s
branch-2 passed

+1 :green_heart:
checkstyle
1m 37s
branch-2 passed

+1 :green_heart:
spotbugs
2m 58s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
the patch passed

-0 :warning:
checkstyle
1m 30s
hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
15m 31s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

43m 21s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2453

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b97f83bd3d8c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f973a8087f

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
95 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
branch-2 passed

+1 :green_heart:
checkstyle
1m 11s
branch-2 passed

+1 :green_heart:
spotbugs
2m 18s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 30s
the patch passed

+1 :green_heart:
checkstyle
1m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

36m 34s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2453

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d0cb8cefb67e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f52e5c797f

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2453/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


modify architecture diagrams

Need to create multiple arch diagrams to match each example, or modify it to just explain all the pieces in a more generic way

Fixed


Builds error when using next's i18n due to lack of serverless/pages/index.html file

I'm trying to move a Next.js site (which uses next's i18n routing) over to Netlify, but sadly can't due to this error:
Error: ENOENT: no such file or directory, stat '.next/serverless/pages/index.html'

It's true that this file doesn't exist. Instead, the default homepage can be found at  '.next/serverless/pages/en/index.html' (replacing "en" with whatever default locale is set in next.config.js).
It would be great to detect if i18n is in use, and then get the homepage's file location by reading the default locale.

Same issue here

Same issue here

hey yall! @neefrehman @cantyjeffrey our i18n PR in next-on-netlify was merged and released this past sunday https://github.com/netlify/next-on-netlify/pull/75. i will go ahead and upgrade the plugin's next-on-netlify version now. admittedly, we need a better workflow for keeping the plugin up to date with next-on-netlify updates. thank you for your patience!!!

hey yall! @neefrehman @cantyjeffrey our i18n PR in next-on-netlify was merged and released this past sunday https://github.com/netlify/next-on-netlify/pull/75. i will go ahead and upgrade the plugin's next-on-netlify version now. admittedly, we need a better workflow for keeping the plugin up to date with next-on-netlify updates. thank you for your patience!!!

update: i upgraded the next-on-netlify version and re-released the plugin. i18n should work now in plugin version 1.0.4!

update: i upgraded the next-on-netlify version and re-released the plugin. i18n should work now in plugin version 1.0.4!

@lindsaylevine thanks forthe update!
I've just tried deploying a sit with the new plugin and am getting a similar error. It looks like the plugin is searching for the entry point at pages/${locale}/.html as opposed to pages/${locale}/index.html
10:52:20 AM: ────────────────────────────────────────────────────────────────
10:52:20 AM:   Plugin "@netlify/plugin-nextjs" internal error
10:52:20 AM: ────────────────────────────────────────────────────────────────
10:52:20 AM:
10:52:20 AM:   Error message
10:52:20 AM:   Error: ENOENT: no such file or directory, stat '.next/serverless/pages/en/.html'
10:52:20 AM:
10:52:20 AM:   Plugin details
10:52:20 AM:   Package:        @netlify/plugin-nextjs
10:52:20 AM:   Version:        1.0.4
10:52:20 AM:   Repository:     git+https://github.com/netlify/netlify-plugin-nextjs.git
10:52:20 AM:   npm link:       https://www.npmjs.com/package/@netlify/plugin-nextjs
10:52:20 AM:   Report issues:  https://github.com/netlify/netlify-plugin-nextjs/issues

@lindsaylevine thanks forthe update!
I've just tried deploying a sit with the new plugin and am getting a similar error. It looks like the plugin is searching for the entry point at pages/${locale}/.html as opposed to pages/${locale}/index.html
10:52:20 AM: ────────────────────────────────────────────────────────────────
10:52:20 AM:   Plugin "@netlify/plugin-nextjs" internal error
10:52:20 AM: ────────────────────────────────────────────────────────────────
10:52:20 AM:
10:52:20 AM:   Error message
10:52:20 AM:   Error: ENOENT: no such file or directory, stat '.next/serverless/pages/en/.html'
10:52:20 AM:
10:52:20 AM:   Plugin details
10:52:20 AM:   Package:        @netlify/plugin-nextjs
10:52:20 AM:   Version:        1.0.4
10:52:20 AM:   Repository:     git+https://github.com/netlify/netlify-plugin-nextjs.git
10:52:20 AM:   npm link:       https://www.npmjs.com/package/@netlify/plugin-nextjs
10:52:20 AM:   Report issues:  https://github.com/netlify/netlify-plugin-nextjs/issues

oh no what page type is your index!? @neefrehman thats so odd after my thorough testing 🤔

oh no what page type is your index!? @neefrehman thats so odd after my thorough testing 🤔

actually thats really not odd i had opened this issue for myself 😭 https://github.com/netlify/next-on-netlify/issues/122

actually thats really not odd i had opened this issue for myself 😭 https://github.com/netlify/next-on-netlify/issues/122

hah! well if it's still useful my index page is just a standard index.tsx in my pages directory

hah! well if it's still useful my index page is just a standard index.tsx in my pages directory

im able to repro, ill keep ya updated. apologies!

im able to repro, ill keep ya updated. apologies!

i believe this is the fix https://github.com/netlify/next-on-netlify/pull/131 now just need to go through the re-release of everything 😅
btw when i asked for page type (sorry that was unclear) i meant are you using getStaticProps (likely since the build is looking for html) and are you using fallback and/or revalidate

i believe this is the fix https://github.com/netlify/next-on-netlify/pull/131 now just need to go through the re-release of everything 😅
btw when i asked for page type (sorry that was unclear) i meant are you using getStaticProps (likely since the build is looking for html) and are you using fallback and/or revalidate

Ah understood! Yes it's a getStaticProps page without any revalidation or fallback :)

Ah understood! Yes it's a getStaticProps page without any revalidation or fallback :)

@neefrehman ok 1.0.5 is released now. hopefully you have a clean build and functioning i18n with this version! 🙏

@neefrehman ok 1.0.5 is released now. hopefully you have a clean build and functioning i18n with this version! 🙏

I've actually just tried a build! It's moving past the old error, but now I'm getting the below error regarding function bundling.
I guess the important piece is : Cannot find module 'critters'
I'm not sure if this is related?
11:35:56 AM: ────────────────────────────────────────────────────────────────
11:35:56 AM:   Dependencies installation error
11:35:56 AM: ────────────────────────────────────────────────────────────────
11:35:56 AM:
11:35:56 AM:   Error message
11:35:56 AM:   A Netlify Function failed to require one of its dependencies.
11:35:56 AM:   If the dependency is a Node module, please make sure it is present in the site's top-level "package.json".
  If it is a local file instead, please make sure the file exists and its filename is correctly spelled.
11:35:56 AM:
11:35:56 AM:   In file "/opt/build/repo/netlify-automatic-functions/next_index/next_index.js"
11:35:56 AM:   Cannot find module 'critters'
11:35:56 AM:   Require stack:
11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:
11:35:56 AM:   Resolved config
11:35:56 AM:   build:
11:35:56 AM:     command: npm run build
11:35:56 AM:     commandOrigin: config
11:35:56 AM:     environment:
11:35:56 AM:       - NODE_VERSION
11:35:56 AM:     publish: /opt/build/repo/out
11:35:56 AM:   plugins:
11:35:56 AM:     - inputs: {}
11:35:56 AM:       origin: config
11:35:56 AM:       package: netlify-plugin-cache-nextjs
11:35:56 AM:     - inputs: {}
11:35:56 AM:       origin: config
11:35:56 AM:       package: '@netlify/plugin-nextjs'

I've actually just tried a build! It's moving past the old error, but now I'm getting the below error regarding function bundling.
I guess the important piece is : Cannot find module 'critters'
I'm not sure if this is related?
11:35:56 AM: ────────────────────────────────────────────────────────────────
11:35:56 AM:   Dependencies installation error
11:35:56 AM: ────────────────────────────────────────────────────────────────
11:35:56 AM:
11:35:56 AM:   Error message
11:35:56 AM:   A Netlify Function failed to require one of its dependencies.
11:35:56 AM:   If the dependency is a Node module, please make sure it is present in the site's top-level "package.json".
  If it is a local file instead, please make sure the file exists and its filename is correctly spelled.
11:35:56 AM:
11:35:56 AM:   In file "/opt/build/repo/netlify-automatic-functions/next_index/next_index.js"
11:35:56 AM:   Cannot find module 'critters'
11:35:56 AM:   Require stack:
11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   - /opt/buildhome/.netlify-build-nvm/versions/node/v12.16.3/lib/node_modules/<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:   -<EMAIL_ADDRESS>11:35:56 AM:
11:35:56 AM:   Resolved config
11:35:56 AM:   build:
11:35:56 AM:     command: npm run build
11:35:56 AM:     commandOrigin: config
11:35:56 AM:     environment:
11:35:56 AM:       - NODE_VERSION
11:35:56 AM:     publish: /opt/build/repo/out
11:35:56 AM:   plugins:
11:35:56 AM:     - inputs: {}
11:35:56 AM:       origin: config
11:35:56 AM:       package: netlify-plugin-cache-nextjs
11:35:56 AM:     - inputs: {}
11:35:56 AM:       origin: config
11:35:56 AM:       package: '@netlify/plugin-nextjs'

oh dear. this is a known issue as well! see: https://twitter.com/erikras/status/1341783510055567361?s=20 and https://github.com/netlify/next-on-netlify/issues/103
temporary fix is to install critters in your project. question though before doing that - can you try adding a next.config.js (if you dont already have one) and setting the target to experimental-serverless-trace (if it isn't already set to that)?

oh dear. this is a known issue as well! see: https://twitter.com/erikras/status/1341783510055567361?s=20 and https://github.com/netlify/next-on-netlify/issues/103
temporary fix is to install critters in your project. question though before doing that - can you try adding a next.config.js (if you dont already have one) and setting the target to experimental-serverless-trace (if it isn't already set to that)?

also, best to reply on 103 if you can! regarding critters. if i18n is all good for you here, i'll close this issue :)

also, best to reply on 103 if you can! regarding critters. if i18n is all good for you here, i'll close this issue :)

@lindsaylevine sorry for opening another issue again, but I've just updated the plugin to fix the resurfaced critters issue (https://github.com/netlify/next-on-netlify/issues/157), and now and getting one similar to this again. It looks like the plugin is looking for a file like pages/{defaultLocale}/{defaultLocale}.html instead of pages/{defaultLocale}/index.html.
More info:
11:34:25 AM: ────────────────────────────────────────────────────────────────
11:34:25 AM:   Plugin "@netlify/plugin-nextjs" internal error
11:34:25 AM: ────────────────────────────────────────────────────────────────
11:34:25 AM:
11:34:25 AM:   Error message
11:34:25 AM:   Error: ENOENT: no such file or directory, stat '.next/serverless/pages/en/en.html'
11:34:25 AM:
11:34:25 AM:   Plugin details
11:34:25 AM:   Package:        @netlify/plugin-nextjs
11:34:25 AM:   Version:        1.1.0
11:34:25 AM:   Repository:     git+https://github.com/netlify/netlify-plugin-nextjs.git
11:34:25 AM:   npm link:       https://www.npmjs.com/package/@netlify/plugin-nextjs
11:34:25 AM:   Report issues:  https://github.com/netlify/netlify-plugin-nextjs/issues

@neefrehman don't be sorry at all!!! yikes, that's not good though @ bug. let me try to repro.

repro'd, stay tuned

this issue is haunting me https://github.com/netlify/next-on-netlify/issues/122

i assume you're using next 10.0.6 because something definitely changed internally :rip:

aight, i know what's going on. are you blocked by this? if so, i think the workaround is to downgrade next until i can release a fix

great! i'm not blocked, so happy to downgrade for now. it must be a big challenge to continue covering all cases

this was just released! let me know if you continue to have any issues!


Port all Network Flows samples to all supported languages

Currently samples at https://developers.google.com/optimization/flow are only available in Python and .Net

Code is on master now: https://github.com/google/or-tools/tree/master/ortools/graph/samples
Once optimization site is updated I'll close this


Looping as a datapack occurs directly after the last note is played

Describe the bug
When exporting as a datapack it will start the loop immediately after the last note is played and doesn't have the correct buffer.
To Reproduce
Steps to reproduce the behavior:

Create simple looping song. Create a silent note to loop more closely

Export as datapack
Play the datapack in game. In this example 2 ticks will be skipped.
A work around for this to have the last set the nbs scoreboard to -(speed*2), -80 for 10ticks per second. A better solution would be to have the buffer on the last note and not the beginning of the first note. But its more work to do manually.

Expected behavior
Notes should not occur 1tick after the last is played when looping. It should keep the same rhythm and have the blank space after the last note

Hi! Thanks for reporting the issue. Do you mind attaching the data pack you used so we can replicate this more easily?

test.zip
test_double.zip
It is easier to hear with the double


Disable ddtrace when using process_isolation on Windows

What does this PR do?

Disable ddtrace when using process_isolation on Windows
Motivation

The analytics does not work well on Windows when we use the process_isolation feature to run the check in a subprocess, it gets stuck: https://github.com/DataDog/integrations-core/actions/runs/5899397751/job/16001875445
The process_isolation is used as a last resort when we face issues such as memory leaks

For now I'm just disabling it to avoid issues, we will try to dig a bit more into this in the future if needed
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Windows tests that are failing are not related, the windows team is on it.


TrackerControl is invisible on Windows platform

Tested with CustomTrackerPage sample, the oxy:TrackerControl is invisible for .net 8.0 and run on Windows platform.
It is visible for .net 8.0 on Android.
It is also visible for .net 7.0 on Windows.

Tested with CustomTrackerPage sample, the oxy:TrackerControl is invisible for .net 8.0 and run on Windows platform.
It is visible for .net 8.0 on Android.

I can confirm that it's visible on Android, and I also see it on iOS (a grey box that show various values, appearing when you tap a point on the graph).
Have not tested Windows, but will try to do that soon ...

I managed to test the sample app on Windows by now, with the following results ...
Running the sample app with net7.0 target (at the tagged version 1.0.0):

Single-finger panning works fine on all examples I tried. ✔
Two-finger scrolling does not work. ⚡
On the CustomTrackerPage, I see the TrackerControl working well (by clicking on one of the graphs). ✔
On the example "Annotations -> Tool tips" in the example browser, the tool tips work well (clicking on one of the objects). ✔

Running the sample app with net8.0 target (at commit 707a12c1e724b66276cdc827c032297bfdc76d45):

Single-finger panning works fine on all examples I tried. ✔
Two-finger scrolling works as well. ✔
On the CustomTrackerPage, I see that the TrackerControl is not showing up properly (by clicking on one of the graphs). ⚡
On the example "Annotations -> Tool tips" in the example browser, the tool tips do not show up (clicking on one of the objects). ⚡

So, mixed results: scrolling only works with net8.0, while TrackerControl and tool tips only work with 7.0. Kinda strange, but confirming your observsations, @lu8848.
Actually, when looking more closely at the CustomTrackerPage with net8.0, it seems like sometimes whitish text is overlaying on the graph (which is mostly invisible on the white background, and only shows around the line of the graph). So probably the TrackerControl is shown after all, but just colored badly ...?!?

I noticed that the horizontal and vertical lines are also missing, which might be related to this issue.


#live preview of css and html is not working

atom-live server package  runs on internet but its not working propely.Like files are opening but its not giving live output as edited in the text-editor.
Please can someone explain in brief that ports are not working and css live preview is not working.
ctrl-shift-3 launch live server on port 3000.
ctrl-shift-4 launch live server on port 4000.
ctrl-shift-5 launch live server on port 5000.
ctrl-shift-8 launch live server on port 8000.
ctrl-shift-9 launch live server on port 9000.

same here, I just updated atom to 1.12.7 and started having errors with live server either project is not open or saves don't update the preview.

and or its something with atom, its occasionally not saving the files I closed and re-opened and the changes I made were lost. re-added and run live server again and its back working again.

I'm also having this issue. On save, no auto reload. Version 1.12.7.

I'm going to close this v1.x issue. Please upgrade to v2.0.0.


how to enable net.ipv4.ip_nonlocal_bind=1 in rancher loadbalancer

i have a stack with :

2 instances of my app as service
2 instances of rancher lb as loadbalancer

i tried to install a keepalived on my stack from this repo docker-keepalived to provide floating ip
i want to set net.ipv4.ip_nonlocal_bind=1 on LB with this method

On Debian, RHEL & most Linux variants simply add net.ipv4.ip_nonlocal_bind=1 to the end of the /etc/sysctl.conf file and force a reload of the file with the [sudo] sysctl -p command

but i have this msg:
sysctl: setting key " net.ipv4.ip_nonlocal_bind=1": Read-only file system.
how can i do ?
how can i launch lb in privileged mode from the rancher ui ?
Best regards
Philippe

Useful
Info

Versions
Rancher v1.6.2 Cattle: v0.181.4 UI: v1.6.5

Access
localauth admin

Orchestration
Cattle

Route
stacks.index

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Fix a bug with non-signed requests in the IdPHandler class.

If the service provider isn't signing requests, then the
_make_idp_request_url method turns the query string into a
bytestring before including it in a format string below.
This causes the resulting URL to include the literal characters
b'
preceeding the desired contents of the query string.
This commit removes the call to encode('utf-8') so the url
is generated correctly.

Thanks for this fix! I've pushed version flask-saml 0.2.1 to pypi with this fix included.

Thanks!


Safe frame: basic/display-web-interstitial-ad

Is there a way to make this work with a Safe Frame (sandboxed) option enabled for the ad?

As long as the ad is configured to render in a SafeFrame (either in the Ad Manager UI or via GPT's page/slot level settings), it should just work. I ran a quick test where I modified the sample to use GPTs page-level setting to force SafeFrame for all ads and the interstitial ad seemed to render in a sandboxed iframe as expected.
Is there some specific scenario where you're not able to get this working?

So the problem with interstitial ad and Safe frame is that by default the safe frame api will set the interstitial container css to postion:absolute.
It could look fine at first glance but if you will add more content and scroll the page - it will not work.
Is there a way to set the safeframe container position to css FIXED?

Is there a sample page where I can observe the issue you're seeing? Or can you provide more specific steps for me to reproduce it on my own?

Here is the page with interstitial banner inside a safeframe:
https://cdn.logotypemaker.com/demo/safeframe.html
The macros that I've used for Google Ad Manager creative (custom code option with out-of-page size):
<script src="https://developmentstorage.bannernow.com/adv/ckpljjraf000q5axadohakod3/embed.js?responsive=0&bnTag=%%CLICK_URL_ESC%%%%DEST_URL_ESC_ESC%%&cb=%%CACHEBUSTER%%&impressionpixel=%%VIEW_URL_ESC%%" async></script>

safeframe-example.zip
The embed.js is using safeframe api to expand/collapse safe frame.
If you will try to scroll the page - safe frame api will return 0 as expansion value and the interstitial will fail to expand.

Here is a better example:
This script should load and display google interstitial sample on page load:
<script>
    window.googletag = window.googletag || {cmd: []};

    var interstitialSlot;

    googletag.cmd.push(function() {
       googletag.pubads().setForceSafeFrame(true);

      interstitialSlot = googletag.defineOutOfPageSlot('/6355419/Travel/Europe/France/Paris', googletag.enums.OutOfPageFormat.INTERSTITIAL);
      if (interstitialSlot) {
        interstitialSlot.addService(googletag.pubads());
      }
      googletag.pubads().enableSingleRequest();
      googletag.enableServices();
      googletag.display(interstitialSlot);
    });
  </script>

And this one - a custom interstitial slot from my google ad manager:
  <script>
    window.googletag = window.googletag || {cmd: []};

    var interstitialSlot;

    googletag.cmd.push(function() {
       googletag.pubads().setForceSafeFrame(true);

      interstitialSlot = googletag.defineOutOfPageSlot('/22080696972/safe-frame-test-ad-unit', googletag.enums.OutOfPageFormat.INTERSTITIAL);
      if (interstitialSlot) {
        interstitialSlot.addService(googletag.pubads());
      }
      googletag.pubads().enableSingleRequest();
      googletag.enableServices();
      googletag.display(interstitialSlot);
    });
  </script>

Because it's an interstitial overlay format I expect that the custom ad will have css position set to FIXED

Thanks for the detailed examples. It looks like the problem you're encountering is an interaction between a custom out-of-page creative and the SafeFrame API.
Just to be clear, the sample code in this repo is for GPT-managed web interstitials. These only support specific sizes (320x480, 300x250, or 336x280) and can only be displayed between page views. As far as I can tell they work as expected with SafeFrame enabled, even when adding/removing content and scrolling the page.
I suspect it may not be possible to use SafeFrame with your completely custom interstitial implementation. However, I'm not especially knowledgable about custom creatives, so you should follow up on the Ad Manager Community forum if switching to GPT-managed interstitials isn't an option. The specialists there should be able to give you a more definitive answer.


Update to 1.14.2?

Will there be a updated version on this plugin?

There will be! Unfortunately I've been very busy recently, but I'll be re-writing the entire plugin from the ground up soon (TM)

hey egg so can you give me a estimate cause i cant wait much longer, and also in this version will all the commands work cause i need them for my admins, not trying to rush you or anything but i just need a estimate

Well, you can download the plugin now from my CI at https://jenkins.egg82.me/job/egg82/job/TrollCommandsPlusPlus/job/master/
I can't promise all the commands are there right now, or that it will work perfectly (or exactly as it did before) but it's a start.
I'll re-release TC++ on Spigot, Bukkit, etc once I have all the commands done. Until then, I'll keep adding them one-by-one to this repo (and thus my CI)

thank you so much love the kind attitude and thanks for the helping hand, was looking for this all day you just saved me lots of time

also ill keep in touch with my server, but hopefully you can add these without a problem, ill be visiting this page constently, thanks

also one more thing the preferences compensator  thing doesnt work yet, but what will it do

Thanks! I'll keep adding them as time permits.
Also, preferences compensator?

oh my bad it was from a different thing my bad


Crash on start up with magistics 0.7.6 from curseforge

As the title says http://pastebin.com/MSzjy9kW . I would love to user this mod but as soon as I toss it in my pack it crashes before minecraft can start .

This is because the Botania API cannot be found somehow. I'll have to either package it in w/ the mod or remove the functionality to fix it; that or you can install Botania.

I also had this problem but I'm glad it was resolved. Is there any documentation on the Botania requirement? I didn't see any myself when I downloaded the mod; I usually run with Botania anyhow but when error checking other mods I removed it which led me here.

Botania is not a requirement. The problem was that is was being loaded as one, but that's resolved now since I packaged Botania's API with the mod. Now you can play Magistics bare w/ Thaumcraft!


Is this code applicable to handwritten Chinese character dataset？

I use the script to generate some distorted handwritten Chinese character data sets, and then modify the size of training and original image, but the effect is not good. Does the principle of this code apply to handwritten Chinese character data sets? If so, do you need to modify some parameters?

I'm not sure how this repository works on chinese character data sets. If you have some improvements or changes you would like to make. Feel free to submit a PR.


chore(SFINT-3596): Refactor Plugins

I refactored the plugins and measurement protocol mapping.
I created a 'base' plugin that is in charge of logging the minimal data required by the Measurement Protocol.
The other plugins extend upon it, this ensures that every plugin does log the minimal data required (and also simplify the job of a plugin implementer, because he just has to focus on the data relevant to his plugin)
The measurement protocol is divided similarly, with three mapping files: one for the 'base', one for service, one for commerce, and finally, a mapper that consume the three mapping files into single functions, later used by analytics.ts
And ride-along come the deletion of the impression in the service plugin. We did not implement client-side impressions yet and the type definition and the method could lead to confusion.

Codecov Report

Merging #237 (463d674) into master (7870ba4) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   88.32%   88.22%   -0.11%
==========================================
  Files          34       37       +3
  Lines        1045     1036       -9
  Branches      140      140
==========================================
- Hits          923      914       -9
  Misses         88       88
  Partials       34       34

Impacted Files
Coverage Δ

src/client/measurementProtocolMapper.ts
100.00% <100.00%> (ø)

...ntProtocolMapping/baseMeasurementProtocolMapper.ts
100.00% <100.00%> (ø)

...otocolMapping/commerceMeasurementProtocolMapper.ts
100.00% <100.00%> (ø)

...rotocolMapping/serviceMeasurementProtocolMapper.ts
100.00% <100.00%> (ø)

src/plugins/BasePlugin.ts
100.00% <100.00%> (ø)

src/plugins/ec.ts
100.00% <100.00%> (ø)

src/plugins/svc.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7870ba4...463d674. Read the comment docs.


Copy internal leaderboard to public pages

@tschaffter Couple of things

wiki page titles can't be edited by the code yet
You will have to edit the parentId in the wiki_config.json after you make the move.

Otherwise, LGTM

@tschaffter Couple of things

wiki page titles can't be edited by the code yet
You will have to edit the parentId in the wiki_config.json after you make the move.

Otherwise, LGTM


Remove an unnecessary Cmdlet from AAD policy check 5.3 to improve performance of the provider

💡 Summary
For Rego policy check 5.3 we can replace Get-MgBetaPolicyAdminConsentRequestPolicy and use Get-MgBetaDirectorySetting instead. We already use Get-MgBetaDirectorySetting for policy 5.4 so we can remove the extra cmdlet Get-MgBetaPolicyAdminConsentRequestPolicy from the provider to make AAD run faster.
When developing the functional test cases for AAD I discovered that the Get-MgBetaDirectorySetting returns a field named EnableAdminConsentRequests that we can check to see if the admin consent workflow is enabled.
In addition to updating the Rego policy check, updating the functional test case yaml code is part of the scope of this issue.
Below I have included a draft functional test case that references the Get-MgBetaDirectorySetting / Update-MgBetaDirectorySetting cmdlets and the EnableAdminConsentRequests field.
 - PolicyId: MS.AAD.5.3v1
   TestDriver: RunScuba
   Tests:
     - TestDescription: MS.AAD.5.3v1 Compliant - Users can request admin consent to apps they are unable to consent to
       Preconditions:
         - Command: UpdateDirectorySettingByName
           Splat:
             DisplayName: Consent Policy Settings
             Updates:
               BodyParameter:
                 Values:
                   - Name: EnableAdminConsentRequests
                     Value: true
       Postconditions: []
       ExpectedResult: true

Acceptance criteria

[x] Provider code has been updated to remove the unnecessary Cmdlet
[x] Rego policy code has been updated
[x] Rego unit tests have been updated
[x] Functional test case has been updated
[ ] All code and functional test have been functionally tested against the test tenants

@tkol2022 To complete functional test as described in issue the service principal will need Directory.ReadWrite.All for MS Graph API on all test tenants. For manual testing, testers will need the MS Graph add to allow the same privileges.

Discussion with @tkol2022 resolved to have test plan use RunCached instead of RunScuba for MS.AAD.5.3v1


add Elegant examples to the repository

The repository includes several example lattice files and a few beam files. However, one cannot combine lattice files and beam files randomly and expect reasonable results.
The Elegant examples need to be included in the repository with their full context.

Is there a programmatic way to detect dependencies? If not, can you give me
a list of relationships? It should be automatic which files go with which.
We can do this easily if you give us the mapping.
Rob

The algorithm at present is to:

select a directory from the elegantExamples/ distribution
use the files in that directory

I thought about just copying all these directories over into the
.../use_case/ directory of the repo, but thought maybe it should happen
incrementally. Also, I want to create "use case" Power Point files like
what Gerard did for his use case, so it's clear to a human what the use
case is about and what the resulting images should be.
We should move from Power Point to a wiki page, of course.
To get at the dependencies in a more algorithmic and automated fashion, we
have to look at all the examples to see if patterns emerge. In some cases,
like reference to a named file, it's obvious that the named file has to be
in the same directory as the other input files, so Elegant will find it.
At the moment, RadTrack will not support many of the Elegant capabilities
expressed in these examples. We'll have to generalize the Elegant tab
accordingly. A quick fix for the completely general case of some
complicated *.ele file would be take the specified file and modify it based
on input from the Elegant tab, as opposed to having the Elegant tab create
the file from scratch.
David


Not showing app window

I downloaded the exe file and am using Windows 10.  I followed instructions to allow run and disabled the private network firewall.  I double click on file but nothing opens up.  Am I missing something?

I'm not sure why this happened, but another user had the same problem. He/she solved it by installing Microsoft Visual C++ 2015 redistributable. It shouldn't be needed, but there might be a bug in .NET Core, or your system files might be corrupt.
To check your system files, open a command prompt as Admin and run the following command: sfc /scannow
The C++ resdist can be downloaded from Microsoft's Download Center
Hope this helps!

That worked after I read his post. Working great now. Thank you for such a great piece of software.
Richard Aballay

On Nov 6, 2020, at 12:24 PM, Andreas Stenlund<EMAIL_ADDRESS>wrote:

I'm not sure why this happened, but another user had the same or a similar problem. He/she solved it by installing Microsoft Visual C++ 2015 redistributable. It shouldn't be needed, but there might be a bug in .NET Core, or your system files might be corrupt.
To check your system files, open a command prompt as Admin and run the following command: sfc /scannow
The C++ resdist can be downloaded from Microsoft's Download Center
Hope this helps!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

v0.1.11 now has the required files bundled, so there is no longer any need to install the redist from Microsoft. It turns out that the Flight Simulator SDK had this dependency.