Deliver to Storage Failing with Error Message "unable to locate apps"

New merge CI/CD build succesfully, but at the DeliverToStorage it fails with an "unable to locate apps" error.
On a previous CI/CD build on the same repo it delivered without a problem.
What we changed:
runs-on setting to "Ubuntu-Latest"
Added a BuildMode setting of production
Please find CI/CD Logs attached:
2024-05-27T09:01:37.4842270Z Current runner version: '2.316.1'
2024-05-27T09:01:37.4869149Z ##[group]Operating System
2024-05-27T09:01:37.4870064Z Ubuntu
2024-05-27T09:01:37.4870504Z 22.04.4
2024-05-27T09:01:37.4870919Z LTS
2024-05-27T09:01:37.4871444Z ##[endgroup]
2024-05-27T09:01:37.4871921Z ##[group]Runner Image
2024-05-27T09:01:37.4872594Z Image: ubuntu-22.04
2024-05-27T09:01:37.4873118Z Version: 20240516.1.0
2024-05-27T09:01:37.4874332Z Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240516.1/images/ubuntu/Ubuntu2204-Readme.md
2024-05-27T09:01:37.4876147Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240516.1
2024-05-27T09:01:37.4877198Z ##[endgroup]
2024-05-27T09:01:37.4877779Z ##[group]Runner Image Provisioner
2024-05-27T09:01:37.4878395Z 2.0.369.1
2024-05-27T09:01:37.4878847Z ##[endgroup]
2024-05-27T09:01:37.4880201Z ##[group]GITHUB_TOKEN Permissions
2024-05-27T09:01:37.4882010Z Actions: read
2024-05-27T09:01:37.4882654Z Contents: read
2024-05-27T09:01:37.4883355Z Metadata: read
2024-05-27T09:01:37.4883994Z Pages: read
2024-05-27T09:01:37.4884805Z ##[endgroup]
2024-05-27T09:01:37.4888156Z Secret source: Actions
2024-05-27T09:01:37.4888900Z Prepare workflow directory
2024-05-27T09:01:37.5880169Z Prepare all required actions
2024-05-27T09:01:37.6050386Z Getting action download info
2024-05-27T09:01:37.7646031Z Download action repository 'actions/checkout@v4' (SHA:a5ac7e51b41094c92402da3b24376905380afc29)
2024-05-27T09:01:38.0717798Z Download action repository 'actions/download-artifact@v4' (SHA:65a9edc5881444af0b9093a5e628f2fe47ea3b2e)
2024-05-27T09:01:38.2953227Z Download action repository<EMAIL_ADDRESS>(SHA:60dcf203bcbeabc2fee2f8228ac12cc3818ba9b0)
2024-05-27T09:01:38.7192885Z Complete job name: Deliver to Storage
2024-05-27T09:01:38.8143634Z ##[group]Run actions/checkout@v4
2024-05-27T09:01:38.8144364Z with:
2024-05-27T09:01:38.8144865Z   repository: redacted/redacted-dynamics-al
2024-05-27T09:01:38.8145976Z   token: ***
2024-05-27T09:01:38.8146457Z   ssh-strict: true
2024-05-27T09:01:38.8147087Z   ssh-user: git
2024-05-27T09:01:38.8147588Z   persist-credentials: true
2024-05-27T09:01:38.8148129Z   clean: true
2024-05-27T09:01:38.8148706Z   sparse-checkout-cone-mode: true
2024-05-27T09:01:38.8149312Z   fetch-depth: 1
2024-05-27T09:01:38.8149765Z   fetch-tags: false
2024-05-27T09:01:38.8150325Z   show-progress: true
2024-05-27T09:01:38.8150802Z   lfs: false
2024-05-27T09:01:38.8151334Z   submodules: false
2024-05-27T09:01:38.8151824Z   set-safe-directory: true
2024-05-27T09:01:38.8152376Z env:
2024-05-27T09:01:38.8152869Z   workflowDepth: 1
2024-05-27T09:01:38.8153343Z   ALGoOrgSettings:
2024-05-27T09:01:38.8153844Z   ALGoRepoSettings:
2024-05-27T09:01:38.8154412Z ##[endgroup]
2024-05-27T09:01:39.0753187Z Syncing repository: redacted/redacted-dynamics-al
2024-05-27T09:01:39.0756416Z ##[group]Getting Git version info
2024-05-27T09:01:39.0758122Z Working directory is '/home/runner/work/redacted-dynamics-al/redacted-dynamics-al'
2024-05-27T09:01:39.0760366Z [command]/usr/bin/git version
2024-05-27T09:01:39.0770607Z git version 2.45.1
2024-05-27T09:01:39.0773983Z ##[endgroup]
2024-05-27T09:01:39.0792958Z Temporarily overriding HOME='/home/runner/work/_temp/887b6d07-3f27-43e4-b388-c2f14acfcea4' before making global git config changes
2024-05-27T09:01:39.0795814Z Adding repository directory to the temporary git global config as a safe directory
2024-05-27T09:01:39.0799568Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/redacted-dynamics-al/redacted-dynamics-al
2024-05-27T09:01:39.0854198Z Deleting the contents of '/home/runner/work/redacted-dynamics-al/redacted-dynamics-al'
2024-05-27T09:01:39.0878189Z ##[group]Initializing the repository
2024-05-27T09:01:39.0880605Z [command]/usr/bin/git init /home/runner/work/redacted-dynamics-al/redacted-dynamics-al
2024-05-27T09:01:39.0960033Z hint: Using 'master' as the name for the initial branch. This default branch name
2024-05-27T09:01:39.0966958Z hint: is subject to change. To configure the initial branch name to use in all
2024-05-27T09:01:39.0972742Z hint: of your new repositories, which will suppress this warning, call:
2024-05-27T09:01:39.0977102Z hint:
2024-05-27T09:01:39.0981095Z hint: 	git config --global init.defaultBranch <name>
2024-05-27T09:01:39.0985236Z hint:
2024-05-27T09:01:39.0989242Z hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
2024-05-27T09:01:39.0994371Z hint: 'development'. The just-created branch can be renamed via this command:
2024-05-27T09:01:39.0999565Z hint:
2024-05-27T09:01:39.1003594Z hint: 	git branch -m <name>
2024-05-27T09:01:39.1014018Z Initialized empty Git repository in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.git/
2024-05-27T09:01:39.1028420Z [command]/usr/bin/git remote add origin https://github.com/redacted/redacted-dynamics-al
2024-05-27T09:01:39.1082477Z ##[endgroup]
2024-05-27T09:01:39.1084840Z ##[group]Disabling automatic garbage collection
2024-05-27T09:01:39.1088109Z [command]/usr/bin/git config --local gc.auto 0
2024-05-27T09:01:39.1136683Z ##[endgroup]
2024-05-27T09:01:39.1138525Z ##[group]Setting up auth
2024-05-27T09:01:39.1144246Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2024-05-27T09:01:39.1192335Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2024-05-27T09:01:39.1628016Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2024-05-27T09:01:39.1689490Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2024-05-27T09:01:39.2028460Z [command]/usr/bin/git config --local http.https://github.com/.extraheader AUTHORIZATION: basic ***
2024-05-27T09:01:39.2046398Z ##[endgroup]
2024-05-27T09:01:39.2048098Z ##[group]Fetching the repository
2024-05-27T09:01:39.2055635Z [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +1fef7a738915139df4555d711f01205197860f74:refs/remotes/origin/main
2024-05-27T09:01:39.4704414Z From https://github.com/redacted/redacted-dynamics-al
2024-05-27T09:01:39.4706921Z  * [new ref]         1fef7a738915139df4555d711f01205197860f74 -> origin/main
2024-05-27T09:01:39.4753486Z ##[endgroup]
2024-05-27T09:01:39.4926574Z ##[group]Determining the checkout info
2024-05-27T09:01:39.4928655Z ##[endgroup]
2024-05-27T09:01:39.4930544Z [command]/usr/bin/git sparse-checkout disable
2024-05-27T09:01:39.5009428Z [command]/usr/bin/git config --local --unset-all extensions.worktreeConfig
2024-05-27T09:01:39.5189639Z ##[group]Checking out the ref
2024-05-27T09:01:39.5287482Z [command]/usr/bin/git checkout --progress --force -B main refs/remotes/origin/main
2024-05-27T09:01:39.5565388Z Switched to a new branch 'main'
2024-05-27T09:01:39.5569932Z branch 'main' set up to track 'origin/main'.
2024-05-27T09:01:39.5581897Z ##[endgroup]
2024-05-27T09:01:39.5818106Z [command]/usr/bin/git log -1 --format='%H'
2024-05-27T09:01:39.5875750Z '1fef7a738915139df4555d711f01205197860f74'
2024-05-27T09:01:39.6502211Z ##[group]Run actions/download-artifact@v4
2024-05-27T09:01:39.6503509Z with:
2024-05-27T09:01:39.6504200Z   path: .artifacts
2024-05-27T09:01:39.6505210Z   merge-multiple: false
2024-05-27T09:01:39.6506184Z   repository: redacted/redacted-dynamics-al
2024-05-27T09:01:39.6507242Z   run-id:<PHONE_NUMBER>
2024-05-27T09:01:39.6508180Z env:
2024-05-27T09:01:39.6508877Z   workflowDepth: 1
2024-05-27T09:01:39.6509703Z   ALGoOrgSettings:
2024-05-27T09:01:39.6510691Z   ALGoRepoSettings:
2024-05-27T09:01:39.6511470Z ##[endgroup]
2024-05-27T09:01:40.0308850Z Found 3 artifact(s)
2024-05-27T09:01:40.0321047Z No input name or pattern filtered specified, downloading all artifacts
2024-05-27T09:01:40.0327342Z An extra directory with the artifact name will be created for each download
2024-05-27T09:01:40.0333441Z Preparing to download the following artifacts:
2024-05-27T09:01:40.0340984Z - redacted-dynamics-al-main-productionBuildOutput-<IP_ADDRESS> (ID:<PHONE_NUMBER>, Size: 796)
2024-05-27T09:01:40.0348265Z - redacted-dynamics-al-main-productionTestApps-<IP_ADDRESS> (ID:<PHONE_NUMBER>, Size: 2789)
2024-05-27T09:01:40.0355859Z - redacted-dynamics-al-main-productionApps-<IP_ADDRESS> (ID:<PHONE_NUMBER>, Size: 120306)
2024-05-27T09:01:40.0871294Z Redirecting to blob download url: https://productionresultssa5.blob.core.windows.net/actions-results/401e91bb-5fed-4c2f-a94f-8f28aca43afb/workflow-job-run-3b9b7692-f7de-59cc-0e16-bb2514b7ae4f/artifacts/c5d18490802e406ee4b14e56858ad03870ec97c15ccce7875984efca81f458d7.zip
2024-05-27T09:01:40.0895473Z Starting download of artifact to: /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.artifacts/redacted-dynamics-al-main-productionBuildOutput-<IP_ADDRESS>
2024-05-27T09:01:40.1464047Z Redirecting to blob download url: https://productionresultssa5.blob.core.windows.net/actions-results/401e91bb-5fed-4c2f-a94f-8f28aca43afb/workflow-job-run-3b9b7692-f7de-59cc-0e16-bb2514b7ae4f/artifacts/2d6926d38a6d6ad0dfabb418f38faa702620c400985d69c8c4fc1b7945a7a388.zip
2024-05-27T09:01:40.1475376Z Starting download of artifact to: /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.artifacts/redacted-dynamics-al-main-productionTestApps-<IP_ADDRESS>
2024-05-27T09:01:40.1635372Z Redirecting to blob download url: https://productionresultssa5.blob.core.windows.net/actions-results/401e91bb-5fed-4c2f-a94f-8f28aca43afb/workflow-job-run-3b9b7692-f7de-59cc-0e16-bb2514b7ae4f/artifacts/21c5f2756205c1d6aeb579150792a1e868078fea64f629d386a75445f14239ec.zip
2024-05-27T09:01:40.1645855Z Starting download of artifact to: /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.artifacts/redacted-dynamics-al-main-productionApps-<IP_ADDRESS>
2024-05-27T09:01:40.1654407Z (node:1703) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
2024-05-27T09:01:40.1659507Z (Use `node --trace-deprecation ...` to show where the warning was created)
2024-05-27T09:01:40.1777206Z Artifact download completed successfully.
2024-05-27T09:01:40.1958248Z Artifact download completed successfully.
2024-05-27T09:01:40.2159583Z Artifact download completed successfully.
2024-05-27T09:01:40.2161129Z Total of 3 artifact(s) downloaded
2024-05-27T09:01:40.2171426Z Download artifact has finished successfully
2024-05-27T09:01:40.2602358Z ##[group]Run<EMAIL_ADDRESS>2024-05-27T09:01:40.2603090Z with:
2024-05-27T09:01:40.2603609Z   shell: pwsh
2024-05-27T09:01:40.2604039Z   project: .
2024-05-27T09:01:40.2604786Z env:
2024-05-27T09:01:40.2605309Z   workflowDepth: 1
2024-05-27T09:01:40.2605778Z   ALGoOrgSettings:
2024-05-27T09:01:40.2606332Z   ALGoRepoSettings:
2024-05-27T09:01:40.2606787Z ##[endgroup]
2024-05-27T09:01:40.2895745Z ##[group]Run $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:40.2897575Z $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:40.2898655Z try {
2024-05-27T09:01:40.2899865Z   /home/runner/work/_actions/microsoft/AL-Go-Actions/v5.1/ReadSettings/ReadSettings.ps1 -project $ENV:_project -get $ENV:_get
2024-05-27T09:01:40.2901067Z }
2024-05-27T09:01:40.2901448Z catch {
2024-05-27T09:01:40.2903117Z   Write-Host "::ERROR::Unexpected error when running action. Error Message: $($_.Exception.Message.Replace("`r",'').Replace("`n",' ')), StackTrace: $($_.ScriptStackTrace.Replace("`r",'').Replace("`n",' <- '))";
2024-05-27T09:01:40.2904715Z   exit 1
2024-05-27T09:01:40.2905191Z }
2024-05-27T09:01:40.3043578Z shell: /usr/bin/pwsh -command ". '{0}'"
2024-05-27T09:01:40.3044292Z env:
2024-05-27T09:01:40.3045231Z   workflowDepth: 1
2024-05-27T09:01:40.3045899Z   ALGoOrgSettings:
2024-05-27T09:01:40.3046417Z   ALGoRepoSettings:
2024-05-27T09:01:40.3047000Z   _project: .
2024-05-27T09:01:40.3047733Z   _get:
2024-05-27T09:01:40.3048163Z ##[endgroup]
2024-05-27T09:01:42.0678043Z Applying settings from /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.github/AL-Go-Settings.json
2024-05-27T09:01:42.1706558Z Applying settings from /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/settings.json
2024-05-27T09:01:42.1737556Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.github/CICD.settings.json
2024-05-27T09:01:42.1752957Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/CICD.settings.json
2024-05-27T09:01:42.1761481Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/simonredacted.settings.json
2024-05-27T09:01:42.6018651Z SETTINGS:
2024-05-27T09:01:42.6815106Z {
2024-05-27T09:01:42.6816382Z   "appDependencyProbingPaths": [],
2024-05-27T09:01:42.6818085Z   "failOn": "error",
2024-05-27T09:01:42.6818987Z   "enableCodeAnalyzersOnTestApps": false,
2024-05-27T09:01:42.6820308Z   "githubRunner": "windows-latest",
2024-05-27T09:01:42.6821592Z   "productionModePreprocessorSymbols ": [
2024-05-27T09:01:42.6822567Z     "AppSource",
2024-05-27T09:01:42.6823050Z     "Production"
2024-05-27T09:01:42.6823585Z   ],
2024-05-27T09:01:42.6824121Z   "rulesetFile": "redacted Dynamics AL/ruleset.json",
2024-05-27T09:01:42.6824879Z   "assignPremiumPlan": false,
2024-05-27T09:01:42.6825573Z   "treatTestFailuresAsWarnings": false,
2024-05-27T09:01:42.6826283Z   "type": "AppSource App",
2024-05-27T09:01:42.6826846Z   "appRevision": 1,
2024-05-27T09:01:42.6827357Z   "environments": [],
2024-05-27T09:01:42.6828214Z   "adminCenterApiCredentialsSecretName": "adminCenterApiCredentials",
2024-05-27T09:01:42.6829219Z   "generateDependencyArtifact": false,
2024-05-27T09:01:42.6829858Z   "vsixFile": "",
2024-05-27T09:01:42.6830402Z   "installTestRunner": false,
2024-05-27T09:01:42.6831627Z   "applicationInsightsConnectionStringSecretName": "applicationInsightsConnectionString",
2024-05-27T09:01:42.6832959Z   "country": "gb",
2024-05-27T09:01:42.6833495Z   "enableTaskScheduler": false,
2024-05-27T09:01:42.6834122Z   "shell": "pwsh",
2024-05-27T09:01:42.6834561Z   "doNotSignApps": false,
2024-05-27T09:01:42.6835166Z   "templateBranch": "",
2024-05-27T09:01:42.6835798Z   "useCompilerFolder": true,
2024-05-27T09:01:42.6836463Z   "installTestFramework": false,
2024-05-27T09:01:42.6837080Z   "doNotRunBcptTests": false,
2024-05-27T09:01:42.6838315Z   "appFolders": [],
2024-05-27T09:01:42.6839422Z   "templateUrl": "https://github.com/microsoft/AL-Go-AppSource@main",
2024-05-27T09:01:42.6840522Z   "partnerTelemetryConnectionString": "",
2024-05-27T09:01:42.6841414Z   "customCodeCops": [],
2024-05-27T09:01:42.6842134Z   "versioningStrategy": 0,
2024-05-27T09:01:42.6842790Z   "keyVaultClientIdSecretName": "",
2024-05-27T09:01:42.6843618Z   "sendExtendedTelemetryToMicrosoft": false,
2024-05-27T09:01:42.6844747Z   "licenseFileUrlSecretName": "licenseFileUrl",
2024-05-27T09:01:42.6845528Z   "configPackages": [],
2024-05-27T09:01:42.6846093Z   "alDoc": {
2024-05-27T09:01:42.6846595Z     "continuousDeployment": false,
2024-05-27T09:01:42.6847255Z     "deployToGitHubPages": true,
2024-05-27T09:01:42.6847906Z     "maxReleases": 3,
2024-05-27T09:01:42.6848506Z     "groupByProject": true,
2024-05-27T09:01:42.6849144Z     "includeProjects": [],
2024-05-27T09:01:42.6849738Z     "excludeProjects": [],
2024-05-27T09:01:42.6850458Z     "header": "Documentation for {REPOSITORY} {VERSION}",
2024-05-27T09:01:42.6853747Z     "footer": "Documentation for {REPOSITORY} made with AL-Go for GitHub, ALDoc and DocFx",
2024-05-27T09:01:42.6860966Z     "defaultIndexMD": "## Reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultIndexMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}",
2024-05-27T09:01:42.6869835Z     "defaultReleaseMD": "## Release reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultReleaseMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}"
2024-05-27T09:01:42.6873978Z   },
2024-05-27T09:01:42.6874387Z   "projectName": ".",
2024-05-27T09:01:42.6874972Z   "ghTokenWorkflowSecretName": "ghTokenWorkflow",
2024-05-27T09:01:42.6875859Z   "keyVaultCodesignCertificateName": "redactedAppSourceAppCsrCert",
2024-05-27T09:01:42.6876935Z   "codeSignCertificateUrlSecretName": "codeSignCertificateUrl",
2024-05-27T09:01:42.6877800Z   "runNumberOffset": 0,
2024-05-27T09:01:42.6878399Z   "enableExternalRulesets": false,
2024-05-27T09:01:42.6879042Z   "enableCodeCop": false,
2024-05-27T09:01:42.6879968Z   "codeSignCertificatePasswordSecretName": "codeSignCertificatePassword",
2024-05-27T09:01:42.6880995Z   "deliverToAppSource": {
2024-05-27T09:01:42.6881552Z     "mainAppFolder": "",
2024-05-27T09:01:42.6882093Z     "productId": "",
2024-05-27T09:01:42.6882619Z     "includeDependencies": [],
2024-05-27T09:01:42.6883264Z     "continuousDelivery": false
2024-05-27T09:01:42.6883845Z   },
2024-05-27T09:01:42.6884286Z   "skipUpgrade": false,
2024-05-27T09:01:42.6885713Z   "installPerformanceToolkit": false,
2024-05-27T09:01:42.6886502Z   "additionalCountries": [],
2024-05-27T09:01:42.6887105Z   "doNotRunTests": false,
2024-05-27T09:01:42.6887640Z   "bcptTestFolders": [],
2024-05-27T09:01:42.6888184Z   "keyVaultCertificateUrlSecretName": "",
2024-05-27T09:01:42.6888974Z   "keyVaultCertificatePasswordSecretName": "",
2024-05-27T09:01:42.6889726Z   "memoryLimit": "",
2024-05-27T09:01:42.6890209Z   "companyName": "",
2024-05-27T09:01:42.6890764Z   "installOnlyReferencedApps": true,
2024-05-27T09:01:42.6891452Z   "appSourceCopMandatoryAffixes": [
2024-05-27T09:01:42.6892382Z     "hfx"
2024-05-27T09:01:42.6892807Z   ],
2024-05-27T09:01:42.6893358Z   "repoName": "redacted-dynamics-al",
2024-05-27T09:01:42.6893958Z   "doNotBuildTests": false,
2024-05-27T09:01:42.6894517Z   "doNotPublishApps": true,
2024-05-27T09:01:42.6895209Z   "runs-on": "Ubuntu-Latest",
2024-05-27T09:01:42.6895826Z   "unusedALGoSystemFiles": [],
2024-05-27T09:01:42.6896406Z   "installApps": [],
2024-05-27T09:01:42.6896939Z   "supportedCountries": "UK",
2024-05-27T09:01:42.6897554Z   "alwaysBuildAllProjects": false,
2024-05-27T09:01:42.6898167Z   "buildModes": [
2024-05-27T09:01:42.6898642Z     "production"
2024-05-27T09:01:42.6899110Z   ],
2024-05-27T09:01:42.6899575Z   "useProjectDependencies": false,
2024-05-27T09:01:42.6900226Z   "testFolders": [],
2024-05-27T09:01:42.6900761Z   "fullBuildPatterns": [],
2024-05-27T09:01:42.6901269Z   "projects": [],
2024-05-27T09:01:42.6901679Z   "appBuild": 35,
2024-05-27T09:01:42.6902146Z   "applicationDependency": "<IP_ADDRESS>",
2024-05-27T09:01:42.6902783Z   "cacheImageName": "my",
2024-05-27T09:01:42.6903250Z   "cacheKeepDays": 3,
2024-05-27T09:01:42.6903559Z   "testDependencies": [],
2024-05-27T09:01:42.6903895Z   "excludeEnvironments": [],
2024-05-27T09:01:42.6904321Z   "templateSha": "bf05ca89f5e08889a1d14f9a150356f141b5a632",
2024-05-27T09:01:42.6904783Z   "githubRunnerShell": "pwsh",
2024-05-27T09:01:42.6905122Z   "updateDependencies": false,
2024-05-27T09:01:42.6905487Z   "obsoleteTagMinAllowedMajorMinor": "",
2024-05-27T09:01:42.6905858Z   "artifact": "",
2024-05-27T09:01:42.6906123Z   "enableUICop": false,
2024-05-27T09:01:42.6906522Z   "installTestLibraries": false,
2024-05-27T09:01:42.6907330Z   "appDependencies": [],
2024-05-27T09:01:42.6907944Z   "keyVaultName": "redactedAppSigningHSM",
2024-05-27T09:01:42.6908608Z   "pullRequestTrigger": "pull_request_target",
2024-05-27T09:01:42.6909224Z   "repoVersion": "1.0",
2024-05-27T09:01:42.6911140Z   "microsoftTelemetryConnectionString": "InstrumentationKey=84bd9223-67d4-4378-8590-9e4a46023be2;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/",
2024-05-27T09:01:42.6912907Z   "installTestApps": []
2024-05-27T09:01:42.6913430Z }
2024-05-27T09:01:42.8222761Z GitHubRunnerJson="windows-latest"
2024-05-27T09:01:42.8230354Z GitHubRunnerShell=pwsh
2024-05-27T09:01:42.9296348Z ##[group]Run<EMAIL_ADDRESS>2024-05-27T09:01:42.9296839Z with:
2024-05-27T09:01:42.9297100Z   shell: pwsh
2024-05-27T09:01:42.9303423Z   gitHubSecrets: {
  "STORAGECONTEXT": "***",
  "AZURE_CREDENTIALS": "***",
  "PAT2": "***",
  "GHTOKENWORKFLOW": "***",
  "github_token": "***"
}
2024-05-27T09:01:42.9304219Z   getSecrets: StorageContext
2024-05-27T09:01:42.9304611Z   useGhTokenWorkflowForPush: false
2024-05-27T09:01:42.9304969Z env:
2024-05-27T09:01:42.9305213Z   workflowDepth: 1
2024-05-27T09:01:42.9305513Z   ALGoOrgSettings:
2024-05-27T09:01:42.9305814Z   ALGoRepoSettings:
2024-05-27T09:01:42.9327435Z   Settings: {"appDependencyProbingPaths":[],"failOn":"error","enableCodeAnalyzersOnTestApps":false,"githubRunner":"windows-latest","productionModePreprocessorSymbols ":["AppSource","Production"],"rulesetFile":"redacted Dynamics AL/ruleset.json","assignPremiumPlan":false,"treatTestFailuresAsWarnings":false,"type":"AppSource App","appRevision":1,"environments":[],"adminCenterApiCredentialsSecretName":"adminCenterApiCredentials","generateDependencyArtifact":false,"vsixFile":"","installTestRunner":false,"applicationInsightsConnectionStringSecretName":"applicationInsightsConnectionString","country":"gb","enableTaskScheduler":false,"shell":"pwsh","doNotSignApps":false,"templateBranch":"","useCompilerFolder":true,"installTestFramework":false,"doNotRunBcptTests":false,"appFolders":[],"templateUrl":"https://github.com/microsoft/AL-Go-AppSource@main","partnerTelemetryConnectionString":"","customCodeCops":[],"versioningStrategy":0,"keyVaultClientIdSecretName":"","sendExtendedTelemetryToMicrosoft":false,"licenseFileUrlSecretName":"licenseFileUrl","configPackages":[],"alDoc":{"continuousDeployment":false,"deployToGitHubPages":true,"maxReleases":3,"groupByProject":true,"includeProjects":[],"excludeProjects":[],"header":"Documentation for {REPOSITORY} {VERSION}","footer":"Documentation for {REPOSITORY} made with AL-Go for GitHub, ALDoc and DocFx","defaultIndexMD":"## Reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultIndexMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}","defaultReleaseMD":"## Release reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultReleaseMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}"},"projectName":".","ghTokenWorkflowSecretName":"ghTokenWorkflow","keyVaultCodesignCertificateName":"redactedAppSourceAppCsrCert","codeSignCertificateUrlSecretName":"codeSignCertificateUrl","runNumberOffset":0,"enableExternalRulesets":false,"enableCodeCop":false,"codeSignCertificatePasswordSecretName":"codeSignCertificatePassword","deliverToAppSource":{"mainAppFolder":"","productId":"","includeDependencies":[],"continuousDelivery":false},"skipUpgrade":false,"installPerformanceToolkit":false,"additionalCountries":[],"doNotRunTests":false,"bcptTestFolders":[],"keyVaultCertificateUrlSecretName":"","keyVaultCertificatePasswordSecretName":"","memoryLimit":"","companyName":"","installOnlyReferencedApps":true,"appSourceCopMandatoryAffixes":["hfx"],"repoName":"redacted-dynamics-al","doNotBuildTests":false,"doNotPublishApps":true,"runs-on":"Ubuntu-Latest","unusedALGoSystemFiles":[],"installApps":[],"supportedCountries":"UK","alwaysBuildAllProjects":false,"buildModes":["production"],"useProjectDependencies":false,"testFolders":[],"fullBuildPatterns":[],"projects":[],"appBuild":35,"applicationDependency":"<IP_ADDRESS>","cacheImageName":"my","cacheKeepDays":3,"testDependencies":[],"excludeEnvironments":[],"templateSha":"bf05ca89f5e08889a1d14f9a150356f141b5a632","githubRunnerShell":"pwsh","updateDependencies":false,"obsoleteTagMinAllowedMajorMinor":"","artifact":"","enableUICop":false,"installTestLibraries":false,"appDependencies":[],"keyVaultName":"redactedAppSigningHSM","pullRequestTrigger":"pull_request_target","repoVersion":"1.0","microsoftTelemetryConnectionString":"InstrumentationKey=84bd9223-67d4-4378-8590-9e4a46023be2;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/","installTestApps":[]}
2024-05-27T09:01:42.9348641Z ##[endgroup]
2024-05-27T09:01:42.9370023Z ##[group]Run $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:42.9371203Z $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:42.9371951Z try {
2024-05-27T09:01:42.9372644Z   /home/runner/work/_actions/microsoft/AL-Go-Actions/v5.1/ReadSecrets/ReadSecrets.ps1 -gitHubSecrets '{
2024-05-27T09:01:42.9374774Z   "STORAGECONTEXT": "***",
2024-05-27T09:01:42.9378517Z   "AZURE_CREDENTIALS": "***",
2024-05-27T09:01:42.9379069Z   "PAT2": "***",
2024-05-27T09:01:42.9379589Z   "GHTOKENWORKFLOW": "***",
2024-05-27T09:01:42.9380144Z   "github_token": "***"
2024-05-27T09:01:42.9380810Z }' -getSecrets $ENV:_getSecrets -useGhTokenWorkflowForPush $ENV:_useGhTokenWorkflowForPush
2024-05-27T09:01:42.9381480Z }
2024-05-27T09:01:42.9381742Z catch {
2024-05-27T09:01:42.9382828Z   Write-Host "::ERROR::Unexpected error when running action. Error Message: $($_.Exception.Message.Replace("`r",'').Replace("`n",' ')), StackTrace: $($_.ScriptStackTrace.Replace("`r",'').Replace("`n",' <- '))";
2024-05-27T09:01:42.9383982Z   exit 1
2024-05-27T09:01:42.9384260Z }
2024-05-27T09:01:42.9451014Z shell: /usr/bin/pwsh -command ". '{0}'"
2024-05-27T09:01:42.9451438Z env:
2024-05-27T09:01:42.9451711Z   workflowDepth: 1
2024-05-27T09:01:42.9452048Z   ALGoOrgSettings:
2024-05-27T09:01:42.9452373Z   ALGoRepoSettings:
2024-05-27T09:01:42.9475781Z   Settings: {"appDependencyProbingPaths":[],"failOn":"error","enableCodeAnalyzersOnTestApps":false,"githubRunner":"windows-latest","productionModePreprocessorSymbols ":["AppSource","Production"],"rulesetFile":"redacted Dynamics AL/ruleset.json","assignPremiumPlan":false,"treatTestFailuresAsWarnings":false,"type":"AppSource App","appRevision":1,"environments":[],"adminCenterApiCredentialsSecretName":"adminCenterApiCredentials","generateDependencyArtifact":false,"vsixFile":"","installTestRunner":false,"applicationInsightsConnectionStringSecretName":"applicationInsightsConnectionString","country":"gb","enableTaskScheduler":false,"shell":"pwsh","doNotSignApps":false,"templateBranch":"","useCompilerFolder":true,"installTestFramework":false,"doNotRunBcptTests":false,"appFolders":[],"templateUrl":"https://github.com/microsoft/AL-Go-AppSource@main","partnerTelemetryConnectionString":"","customCodeCops":[],"versioningStrategy":0,"keyVaultClientIdSecretName":"","sendExtendedTelemetryToMicrosoft":false,"licenseFileUrlSecretName":"licenseFileUrl","configPackages":[],"alDoc":{"continuousDeployment":false,"deployToGitHubPages":true,"maxReleases":3,"groupByProject":true,"includeProjects":[],"excludeProjects":[],"header":"Documentation for {REPOSITORY} {VERSION}","footer":"Documentation for {REPOSITORY} made with AL-Go for GitHub, ALDoc and DocFx","defaultIndexMD":"## Reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultIndexMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}","defaultReleaseMD":"## Release reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultReleaseMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}"},"projectName":".","ghTokenWorkflowSecretName":"ghTokenWorkflow","keyVaultCodesignCertificateName":"redactedAppSourceAppCsrCert","codeSignCertificateUrlSecretName":"codeSignCertificateUrl","runNumberOffset":0,"enableExternalRulesets":false,"enableCodeCop":false,"codeSignCertificatePasswordSecretName":"codeSignCertificatePassword","deliverToAppSource":{"mainAppFolder":"","productId":"","includeDependencies":[],"continuousDelivery":false},"skipUpgrade":false,"installPerformanceToolkit":false,"additionalCountries":[],"doNotRunTests":false,"bcptTestFolders":[],"keyVaultCertificateUrlSecretName":"","keyVaultCertificatePasswordSecretName":"","memoryLimit":"","companyName":"","installOnlyReferencedApps":true,"appSourceCopMandatoryAffixes":["hfx"],"repoName":"redacted-dynamics-al","doNotBuildTests":false,"doNotPublishApps":true,"runs-on":"Ubuntu-Latest","unusedALGoSystemFiles":[],"installApps":[],"supportedCountries":"UK","alwaysBuildAllProjects":false,"buildModes":["production"],"useProjectDependencies":false,"testFolders":[],"fullBuildPatterns":[],"projects":[],"appBuild":35,"applicationDependency":"<IP_ADDRESS>","cacheImageName":"my","cacheKeepDays":3,"testDependencies":[],"excludeEnvironments":[],"templateSha":"bf05ca89f5e08889a1d14f9a150356f141b5a632","githubRunnerShell":"pwsh","updateDependencies":false,"obsoleteTagMinAllowedMajorMinor":"","artifact":"","enableUICop":false,"installTestLibraries":false,"appDependencies":[],"keyVaultName":"redactedAppSigningHSM","pullRequestTrigger":"pull_request_target","repoVersion":"1.0","microsoftTelemetryConnectionString":"InstrumentationKey=84bd9223-67d4-4378-8590-9e4a46023be2;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/","installTestApps":[]}
2024-05-27T09:01:42.9496382Z   _getSecrets: StorageContext
2024-05-27T09:01:42.9496744Z   _useGhTokenWorkflowForPush: false
2024-05-27T09:01:42.9497107Z ##[endgroup]
2024-05-27T09:01:43.9454808Z Masking value for clientSecret
2024-05-27T09:01:44.3121101Z Trying to get the secret (StorageContext) from the github environment.
2024-05-27T09:01:44.3180709Z Masking value for StorageContext
2024-05-27T09:01:44.3218101Z Secret (StorageContext) was retrieved from the github environment.
2024-05-27T09:01:44.3266632Z Masking value for StorageContext.storageAccountKey
2024-05-27T09:01:44.3314627Z StorageContext successfully read from secret StorageContext
2024-05-27T09:01:44.4460154Z ##[group]Run<EMAIL_ADDRESS>2024-05-27T09:01:44.4461269Z with:
2024-05-27T09:01:44.4461761Z   shell: pwsh
2024-05-27T09:01:44.4462341Z   type: CD
2024-05-27T09:01:44.4462841Z   projects: ["."]
2024-05-27T09:01:44.4463387Z   deliveryTarget: Storage
2024-05-27T09:01:44.4464012Z   artifacts: .artifacts
2024-05-27T09:01:44.4464606Z   actor: simonredacted
2024-05-27T09:01:44.4465343Z   token: ***
2024-05-27T09:01:44.4465922Z   parentTelemetryScopeJson: 7b7d
2024-05-27T09:01:44.4466633Z   atypes: Apps,Dependencies,TestApps
2024-05-27T09:01:44.4467325Z   goLive: false
2024-05-27T09:01:44.4467798Z env:
2024-05-27T09:01:44.4468325Z   workflowDepth: 1
2024-05-27T09:01:44.4468858Z   ALGoOrgSettings:
2024-05-27T09:01:44.4469401Z   ALGoRepoSettings:
2024-05-27T09:01:44.4504896Z   Settings: {"appDependencyProbingPaths":[],"failOn":"error","enableCodeAnalyzersOnTestApps":false,"githubRunner":"windows-latest","productionModePreprocessorSymbols ":["AppSource","Production"],"rulesetFile":"redacted Dynamics AL/ruleset.json","assignPremiumPlan":false,"treatTestFailuresAsWarnings":false,"type":"AppSource App","appRevision":1,"environments":[],"adminCenterApiCredentialsSecretName":"adminCenterApiCredentials","generateDependencyArtifact":false,"vsixFile":"","installTestRunner":false,"applicationInsightsConnectionStringSecretName":"applicationInsightsConnectionString","country":"gb","enableTaskScheduler":false,"shell":"pwsh","doNotSignApps":false,"templateBranch":"","useCompilerFolder":true,"installTestFramework":false,"doNotRunBcptTests":false,"appFolders":[],"templateUrl":"https://github.com/microsoft/AL-Go-AppSource@main","partnerTelemetryConnectionString":"","customCodeCops":[],"versioningStrategy":0,"keyVaultClientIdSecretName":"","sendExtendedTelemetryToMicrosoft":false,"licenseFileUrlSecretName":"licenseFileUrl","configPackages":[],"alDoc":{"continuousDeployment":false,"deployToGitHubPages":true,"maxReleases":3,"groupByProject":true,"includeProjects":[],"excludeProjects":[],"header":"Documentation for {REPOSITORY} {VERSION}","footer":"Documentation for {REPOSITORY} made with AL-Go for GitHub, ALDoc and DocFx","defaultIndexMD":"## Reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultIndexMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}","defaultReleaseMD":"## Release reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultReleaseMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}"},"projectName":".","ghTokenWorkflowSecretName":"ghTokenWorkflow","keyVaultCodesignCertificateName":"redactedAppSourceAppCsrCert","codeSignCertificateUrlSecretName":"codeSignCertificateUrl","runNumberOffset":0,"enableExternalRulesets":false,"enableCodeCop":false,"codeSignCertificatePasswordSecretName":"codeSignCertificatePassword","deliverToAppSource":{"mainAppFolder":"","productId":"","includeDependencies":[],"continuousDelivery":false},"skipUpgrade":false,"installPerformanceToolkit":false,"additionalCountries":[],"doNotRunTests":false,"bcptTestFolders":[],"keyVaultCertificateUrlSecretName":"","keyVaultCertificatePasswordSecretName":"","memoryLimit":"","companyName":"","installOnlyReferencedApps":true,"appSourceCopMandatoryAffixes":["hfx"],"repoName":"redacted-dynamics-al","doNotBuildTests":false,"doNotPublishApps":true,"runs-on":"Ubuntu-Latest","unusedALGoSystemFiles":[],"installApps":[],"supportedCountries":"UK","alwaysBuildAllProjects":false,"buildModes":["production"],"useProjectDependencies":false,"testFolders":[],"fullBuildPatterns":[],"projects":[],"appBuild":35,"applicationDependency":"<IP_ADDRESS>","cacheImageName":"my","cacheKeepDays":3,"testDependencies":[],"excludeEnvironments":[],"templateSha":"bf05ca89f5e08889a1d14f9a150356f141b5a632","githubRunnerShell":"pwsh","updateDependencies":false,"obsoleteTagMinAllowedMajorMinor":"","artifact":"","enableUICop":false,"installTestLibraries":false,"appDependencies":[],"keyVaultName":"redactedAppSigningHSM","pullRequestTrigger":"pull_request_target","repoVersion":"1.0","microsoftTelemetryConnectionString":"InstrumentationKey=84bd9223-67d4-4378-8590-9e4a46023be2;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/","installTestApps":[]}
2024-05-27T09:01:44.4547109Z   Secrets: {"StorageContext":"***"}
2024-05-27T09:01:44.4547593Z ##[endgroup]
2024-05-27T09:01:44.4570847Z ##[group]Run $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:44.4571954Z $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
2024-05-27T09:01:44.4572668Z try {
2024-05-27T09:01:44.4574321Z   /home/runner/work/_actions/microsoft/AL-Go-Actions/v5.1/Deliver/Deliver.ps1 -actor $ENV:_actor -token $ENV:_token -parentTelemetryScopeJson $ENV:_parentTelemetryScopeJson -projects $ENV:_projects -deliveryTarget $ENV:_deliveryTarget -artifacts $ENV:_artifacts -type $ENV:_type -atypes $ENV:_atypes -goLive ($ENV:_goLive -eq 'true')
2024-05-27T09:01:44.4576057Z }
2024-05-27T09:01:44.4576350Z catch {
2024-05-27T09:01:44.4577430Z   Write-Host "::ERROR::Unexpected error when running action. Error Message: $($_.Exception.Message.Replace("`r",'').Replace("`n",' ')), StackTrace: $($_.ScriptStackTrace.Replace("`r",'').Replace("`n",' <- '))";
2024-05-27T09:01:44.4578553Z   exit 1
2024-05-27T09:01:44.4578863Z }
2024-05-27T09:01:44.4652613Z shell: /usr/bin/pwsh -command ". '{0}'"
2024-05-27T09:01:44.4653374Z env:
2024-05-27T09:01:44.4653865Z   workflowDepth: 1
2024-05-27T09:01:44.4654444Z   ALGoOrgSettings:
2024-05-27T09:01:44.4654982Z   ALGoRepoSettings:
2024-05-27T09:01:44.4686499Z   Settings: {"appDependencyProbingPaths":[],"failOn":"error","enableCodeAnalyzersOnTestApps":false,"githubRunner":"windows-latest","productionModePreprocessorSymbols ":["AppSource","Production"],"rulesetFile":"redacted Dynamics AL/ruleset.json","assignPremiumPlan":false,"treatTestFailuresAsWarnings":false,"type":"AppSource App","appRevision":1,"environments":[],"adminCenterApiCredentialsSecretName":"adminCenterApiCredentials","generateDependencyArtifact":false,"vsixFile":"","installTestRunner":false,"applicationInsightsConnectionStringSecretName":"applicationInsightsConnectionString","country":"gb","enableTaskScheduler":false,"shell":"pwsh","doNotSignApps":false,"templateBranch":"","useCompilerFolder":true,"installTestFramework":false,"doNotRunBcptTests":false,"appFolders":[],"templateUrl":"https://github.com/microsoft/AL-Go-AppSource@main","partnerTelemetryConnectionString":"","customCodeCops":[],"versioningStrategy":0,"keyVaultClientIdSecretName":"","sendExtendedTelemetryToMicrosoft":false,"licenseFileUrlSecretName":"licenseFileUrl","configPackages":[],"alDoc":{"continuousDeployment":false,"deployToGitHubPages":true,"maxReleases":3,"groupByProject":true,"includeProjects":[],"excludeProjects":[],"header":"Documentation for {REPOSITORY} {VERSION}","footer":"Documentation for {REPOSITORY} made with AL-Go for GitHub, ALDoc and DocFx","defaultIndexMD":"## Reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultIndexMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}","defaultReleaseMD":"## Release reference documentation\\n\\nThis is the generated reference documentation for [{REPOSITORY}](https://github.com/{REPOSITORY}).\\n\\nYou can use the navigation bar at the top and the table of contents to the left to navigate your documentation.\\n\\nYou can change this content by creating/editing the **{INDEXTEMPLATERELATIVEPATH}** file in your repository or use the alDoc:defaultReleaseMD setting in your repository settings file (.github/AL-Go-Settings.json)\\n\\n{RELEASENOTES}"},"projectName":".","ghTokenWorkflowSecretName":"ghTokenWorkflow","keyVaultCodesignCertificateName":"redactedAppSourceAppCsrCert","codeSignCertificateUrlSecretName":"codeSignCertificateUrl","runNumberOffset":0,"enableExternalRulesets":false,"enableCodeCop":false,"codeSignCertificatePasswordSecretName":"codeSignCertificatePassword","deliverToAppSource":{"mainAppFolder":"","productId":"","includeDependencies":[],"continuousDelivery":false},"skipUpgrade":false,"installPerformanceToolkit":false,"additionalCountries":[],"doNotRunTests":false,"bcptTestFolders":[],"keyVaultCertificateUrlSecretName":"","keyVaultCertificatePasswordSecretName":"","memoryLimit":"","companyName":"","installOnlyReferencedApps":true,"appSourceCopMandatoryAffixes":["hfx"],"repoName":"redacted-dynamics-al","doNotBuildTests":false,"doNotPublishApps":true,"runs-on":"Ubuntu-Latest","unusedALGoSystemFiles":[],"installApps":[],"supportedCountries":"UK","alwaysBuildAllProjects":false,"buildModes":["production"],"useProjectDependencies":false,"testFolders":[],"fullBuildPatterns":[],"projects":[],"appBuild":35,"applicationDependency":"<IP_ADDRESS>","cacheImageName":"my","cacheKeepDays":3,"testDependencies":[],"excludeEnvironments":[],"templateSha":"bf05ca89f5e08889a1d14f9a150356f141b5a632","githubRunnerShell":"pwsh","updateDependencies":false,"obsoleteTagMinAllowedMajorMinor":"","artifact":"","enableUICop":false,"installTestLibraries":false,"appDependencies":[],"keyVaultName":"redactedAppSigningHSM","pullRequestTrigger":"pull_request_target","repoVersion":"1.0","microsoftTelemetryConnectionString":"InstrumentationKey=84bd9223-67d4-4378-8590-9e4a46023be2;IngestionEndpoint=https://westeurope-1.in.applicationinsights.azure.com/","installTestApps":[]}
2024-05-27T09:01:44.4718065Z   Secrets: {"StorageContext":"***"}
2024-05-27T09:01:44.4718507Z   _actor: simonredacted
2024-05-27T09:01:44.4718943Z   _token: ***
2024-05-27T09:01:44.4719290Z   _parentTelemetryScopeJson: 7b7d
2024-05-27T09:01:44.4719718Z   _projects: ["."]
2024-05-27T09:01:44.4720064Z   _deliveryTarget: Storage
2024-05-27T09:01:44.4720447Z   _artifacts: .artifacts
2024-05-27T09:01:44.4720808Z   _type: CD
2024-05-27T09:01:44.4721144Z   _atypes: Apps,Dependencies,TestApps
2024-05-27T09:01:44.4721569Z   _goLive: false
2024-05-27T09:01:44.4721896Z ##[endgroup]
2024-05-27T09:01:45.5381051Z Downloading BcContainerHelper latest version from Blob Storage
2024-05-27T09:01:48.6758788Z Import from /home/runner/.BcContainerHelper/6.0.17/BcContainerHelper/BcContainerHelper.ps1
2024-05-27T09:01:48.7511377Z BcContainerHelper version 6.0.17
2024-05-27T09:01:52.3019403Z BC.HelperFunctions emits usage statistics telemetry to Microsoft
2024-05-27T09:01:52.3651915Z Running on Linux, PowerShell 7.4.1
2024-05-27T09:01:53.9046655Z Applying settings from /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.github/AL-Go-Settings.json
2024-05-27T09:01:53.9083353Z Applying settings from /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/settings.json
2024-05-27T09:01:53.9102331Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.github/CICD.settings.json
2024-05-27T09:01:53.9114228Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/CICD.settings.json
2024-05-27T09:01:53.9120367Z No settings found in /home/runner/work/redacted-dynamics-al/redacted-dynamics-al/.AL-Go/simonredacted.settings.json
2024-05-27T09:01:54.0373475Z Artifacts .artifacts
2024-05-27T09:01:54.0377410Z Projects:
2024-05-27T09:01:54.0413654Z .
2024-05-27T09:01:54.0450294Z ProjectName 'redacted-dynamics-al'
2024-05-27T09:01:54.0460015Z Project 'redacted-dynamics-al'
2024-05-27T09:01:54.0464598Z Artifacts:
2024-05-27T09:01:54.0487726Z - redacted-dynamics-al-main-productionApps-<IP_ADDRESS>
2024-05-27T09:01:54.0493370Z - redacted-dynamics-al-main-productionBuildOutput-<IP_ADDRESS>
2024-05-27T09:01:54.0498859Z - redacted-dynamics-al-main-productionTestApps-<IP_ADDRESS>
2024-05-27T09:01:54.1363571Z Installing and importing Az.Storage.
2024-05-27T09:02:00.4398967Z WARNING: The output of cmdlet New-AzStorageContext may compromise security by showing the following secrets: TableStorageAccount.Credentials.Key, ConnectionString. Learn more at https://go.microsoft.com/fwlink/?linkid=2258844
2024-05-27T09:02:00.4630433Z Storage Container Name is redacted-dynamics-al
2024-05-27T09:02:00.4635940Z Storage Blob Name is {version}/{project}-{type}.zip
2024-05-27T09:02:01.0226880Z WARNING: The output of cmdlet Get-AzStorageContainer may compromise security by showing the following secrets: Context.TableStorageAccount.Credentials.Key, Context.ConnectionString. Learn more at https://go.microsoft.com/fwlink/?linkid=2258844
2024-05-27T09:02:01.0246866Z Delivering to redacted-dynamics-al in redactedappsourceapps
2024-05-27T09:02:01.0273756Z Looking for: redacted-dynamics-al-main-Apps-*.*.*.*
2024-05-27T09:02:01.3396609Z AL-Go action ran: Deliver Telemetry Correlation Id: 2c3469cf-3fa1-4998-8833-e5d7e066bdd3
2024-05-27T09:02:01.3501804Z ##[error]Unexpected error when running action. Error Message: Error - unable to locate apps, StackTrace: at


Improves pagination docs

Improves pagination docs with the pagination headers and cors configuration

closed by https://github.com/SwitchDreams/rest-api-generator/pull/45


Only English in iOS iphone

using the share, showd all english, not the system language. pls fix.

The text shown on the share dialog can be changed in code. If you're using the UnityNativeSharingHelper class, you can override the variable shareDialogText with whatever text you want
https://github.com/NicholasSheehan/Unity-Native-Sharing/blob/master/Examples/UnityNativeSharingHelper.cs

Didn't mean to close 🤦, re-opening

I double-checked the iOS implementation, there is nothing that sets the language or uses English text
https://github.com/NicholasSheehan/Unity-Native-Sharing/blob/master/Plugins/iOS/UnityNative_Sharing.mm

Also, do you have a screenshot or video of this happening?

Closing due to inactivity


[ENHANCEMENT] Community Support

Community Support
We are starting to adopt this work as a starting point for our k8s infra. I'm wondering if there's anyone else in the same situation and might benefit from a slack (or similar) to discuss issues and share advice.

Hey @firegrass ,
I'm glad to see this project has been helpful for you! I created it as a booster for starting a platform. Currently, I am the sole maintainer, but I am completely open to building a community around this work.

Thanks @Smana
I'll start adding some Issues, we'll see how it goes :smile:

Great, let's do that!


Add shell commands to Bash on Ubuntu on Windows

Description
The Atom Shell commands are not available on Bash on Ubuntu on Windows 10
Steps to Reproduce

Open Bash on Ubuntu on Windows in Windows 10
Try the atom and apm commands and note the "command not found" message
Try these same commands in Command Prompt (cmd.exe) and observe intended result

Expected behavior: Expected atom command to launch editor GUI and apm command to return apm - Atom Package Manager powered by https://atom.io... or install package named in command.
Actual behavior: Bash gives: atom: command not found and apm: command not found
Versions
Atom    : 1.9.7
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0
Windows 10 Home, Version 1607, OS Build 14393.10

This is not possible as Bash on Ubuntu is completely (well, almost completely) isolated from Windows.  Items in Windows' PATH are not added to Bash's path.  In addition, the bash files that Atom for Windows ships with are designed to call their respective .cmd versions, which also isn't possible in the Linux subsystem.
You would have better luck attempting to build Atom from source and then adding the resulting apm.sh to Bash's path.  Much more work would be involved in getting Atom to show up.


Add https://github.com/cloverrose/pkgdep

https://github.com/cloverrose/pkgdep
Hi, I've followed How to add a package but notice I don't have permission.
Standard process fails, this fix on generated file is required.
diff --git a/pkgs/cloverrose/pkgdep/registry.yaml b/pkgs/cloverrose/pkgdep/registry.yaml
index 5e5c28d8f..9828d2e13 100644
--- a/pkgs/cloverrose/pkgdep/registry.yaml
+++ b/pkgs/cloverrose/pkgdep/registry.yaml
@@ -8,6 +8,9 @@ packages:
       - version_constraint: "true"
         asset: pkgdep_{{.OS}}_{{.Arch}}.{{.Format}}
         format: tar.gz
+        files:
+          - name: pkgdep
+            src: "pkgdep_{{.OS}}_{{.Arch}}/pkgdep"
         replacements:

Maybe this is helpful.

https://github.com/aquaproj/aqua-registry/issues/26113

Thank you, my issue has been resolved. Opened PR.

https://github.com/aquaproj/aqua-registry/pull/27489


Setup staging for iOS

Definitiion of done

[ ] Staging https://expo.dev accounts as a build for iOS
[ ] Integration repository is updated to have command to deploy to iOS if needed
[ ] Staging server can be used to load iOS in expo
[ ] Notion instructions are updated as needed for iPhone holders

https://www.notion.so/tonomy-foundation/Tonomy-ID-Staging-how-to-use-fa13e4a875374e5e94aec1c602d07edc

needs an iOS device to finish

https://expo.dev/register-device/d0e76fd1-2780-4eb0-b75a-9014eabb13d8

https://docs.expo.dev/submit/ios/
https://github.com/Tonomy-Foundation/Tonomy-ID-Integration/pull/102
https://appstoreconnect.apple.com/apps/1663471436/appstore


"Apply to all of my subscriptions" option for changing stream notification settings uses a loop

I just heard from a user who got rate-limited using this feature because they had more 100 subscriptions.
To reproduce:

Create + subscribe to more than 100 streams in development; I think there's a manage.py populate_db option that will do this for you.  Or skip this step and just watch  the 15 queries on the run-dev.py console that don't hit the rate limit; it's not really essential to fix it to see the ultimate failure mode.
Go to notification settings, and toggle one of the stream settings.  It'll offer to change them all.  Accept.

To fix, we should just make this operation use a single bulk query to the server.
I think the code to modify is _update_page in settings_notifications.js, though we may need to tweak the backend to support the query we want.

@zulipbot claim


Implement basic functionalities in "New task" scene

[ ] Implement close button, where when clicked, the task pop up will be closed and back to the main screen
[ ] Implement Add Task button, where when clicked, the current task saved into an object to be added to the task list
[ ] Implement toggle functionality, where the toggle buttons will be untoggled when another toggle button is clicked.

Will assign myself and get on to finishing this controller


[Ops] Set up www redirect on prod messaging server

https://messaging.connext.network works, but https://www.messaging.connext.network doesn't. This is a fairly simple QoL improvement that can stop users from getting stuck here

Closing, this is bad idea apparently


Self-contained publish failing with error NU1605: Detected package downgrade: Microsoft.NETCore.App from 2.1.2 to 2.1.0

Self-contained publish failing in .net core sdk 2.1.302 with error NU1605 : Detected package downgrade: Microsoft.NETCore.App from 2.1.2 to 2.1.0
Description
After I migrated from .netcoreapp2.0 to .netcoreapp2.1, I am getting a error NU1605: Detected package downgrade: Microsoft.NETCore.App from 2.1.2 to 2.1.0 when running dotnet publish with the -r option.
snapshot

one of my class libs csproj
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup Label="Globals">
    <SccProjectName>SAK</SccProjectName>
    <SccProvider>SAK</SccProvider>
    <SccAuxPath>SAK</SccAuxPath>
    <SccLocalPath>SAK</SccLocalPath>
  </PropertyGroup>
  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
  </PropertyGroup>
  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <DebugType>full</DebugType>
    <DebugSymbols>true</DebugSymbols>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.1.1" />
    <PackageReference Include="xunit" Version="2.4.0" />
  </ItemGroup>
  <ItemGroup>
    <ProjectReference Include="..\Rubicon.ReverseProxy\Rubicon.ReverseProxy.csproj" />
  </ItemGroup>
</Project>

main project csproj
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup Label="Globals">
    <SccProjectName>SAK</SccProjectName>
    <SccProvider>SAK</SccProvider>
    <SccAuxPath>SAK</SccAuxPath>
    <SccLocalPath>SAK</SccLocalPath>
  </PropertyGroup>

  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
    <OutputType>Exe</OutputType>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <DebugType>full</DebugType>
    <DebugSymbols>true</DebugSymbols>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.App" Version="2.1.2" />
    <PackageReference Include="Polly" Version="6.1.0" />
    <PackageReference Include="Serilog.AspNetCore" Version="2.1.1" />
    <PackageReference Include="Serilog.Sinks.Console" Version="3.1.1" />
    <PackageReference Include="Steeltoe.CloudFoundry.ConnectorCore" Version="2.0.0" />
    <PackageReference Include="Steeltoe.Management.CloudFoundryCore" Version="2.0.1" />
  </ItemGroup>
  <ItemGroup>
    <None Update="deploy.*.bat">
      <DependentUpon>deploy.bat</DependentUpon>
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </None>
    <None Update="manifest.*.yml">
      <DependentUpon>manifest.yml</DependentUpon>
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </None>
  </ItemGroup>
  <ItemGroup>
    <None Update="manifest.yml">
      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    </None>
  </ItemGroup>
  <ProjectExtensions><VisualStudio><UserProperties appsettings_1json__JSONSchema="" /></VisualStudio></ProjectExtensions>

</Project>

@weshaggard

One of the packages you are referencing is likely pulling in a lower version of a package. @DamianEdwards have you seen this?

Based on the error screenshot it looks like a couple of your test projects are directly referencing 2.1.0 of the runtime either via a direct PackageReference or via overriding the RuntimeFrameworkVersion. Can you provide a pointer to your Rubicon.ReversProxy.Tests.Common.csproj?

The weird part is that running dotnet publish without -r (i.e., to output a dll) doesn't cause any issues.
Here's the Rubicon.ReverseProxy.Tests.Common.csproj.
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup Label="Globals">
    <SccProjectName>SAK</SccProjectName>
    <SccProvider>SAK</SccProvider>
    <SccAuxPath>SAK</SccAuxPath>
    <SccLocalPath>SAK</SccLocalPath>
  </PropertyGroup>

  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
    <RuntimeIdentifier>win10-x64</RuntimeIdentifier>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <DebugType>full</DebugType>
    <DebugSymbols>true</DebugSymbols>
    <NoWarn>$(NoWarn);NU1605</NoWarn>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.0.2" />
    <PackageReference Include="xunit" Version="2.3.1" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\Rubicon.ReverseProxy\Rubicon.ReverseProxy.csproj" />
  </ItemGroup>

</Project>

Have you tried updating your reference to Microsoft.AspNetCore.TestHost to the latest version?

I have. Doesn't make a difference with regards to the NU1605 : Detected package downgrade error.
I left it as 2.0.2 in the end because the latest version of Microsoft.AspNetCore.TestHost changed its behavior somehow and it broke our tests.

In your test project, try setting
<PropertyGroup>
  <TargetLatestRuntimePatch>false</TargetLatestRuntimePatch>
</PropertyGroup>

This is likely a side-effect of NuGet using different parameters to restore than the actual build will use - the RuntimeIdentifier will not be forward across P2P references during the build but NuGet will evaluate all projects using the global property and thus the runtime roll-forward kicks in.
Also see https://github.com/dotnet/sdk/issues/1834

And btw roll-forward doesn't kick in for test projects since they are libraries by default and the test SDK changes them to <OutputType>Exe</OutputType> too late for the self-contained roll-forward IIRC.
In theory, you can also work around this by setting <OutputType>Exe</OutputType> in the test project instead of the TargetLatestRuntimePatch mentioned above.

I have the same issue.  Builds locally fine, but throws same error as above for my test project on the build server.

Adding <OutputType>Exe</OutputType> worked for me.

Adding just <OutputType>Exe</OutputType> got over the downgrade warning but publish then failed on NETSDK1061: The project was restored using Microsoft.NETCore.App version 2.1.2, but with current settings, version 2.1.0 would be used instead.
Adding <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch> fixes it fully.

Change .csproj doesn't work.
Nuget problems are persistent with any .net core 2.1 project I start.
When I use "Nuget Console" with "Update-Package -reinstall", then Project name is cleared and it displays "'default' project not found" error. :-(
My visual studio has several Nuget related errors and repair/reinstall doesn't fix anything.

Issue moved to dotnet/core-sdk #81 via ZenHub


[Feature Request] Minimum severity option

Whether it uses a number 1-5 or "Low" "Medium Low" etc, it would be useful because it would let me use a single rules file for my VSCode PMD scanning and GitHub Actions scanning - and only use severity 1 & 2 in my CI workflow.
Otherwise, I have to have two separate files, and while I don't change them much, setting properties in both across many projects is time-consuming.
Thank you!

bump

Isn't that a duplicate of #32?

@adangel Possibly. If it is, then let's update #32 to use the commonly-used term "minimum priority," which is the term in https://docs.pmd-code.org/pmd-doc-6.55.0/pmd_userdocs_cli_reference.html


Update setup-envtest dependency

Update setup-envtest to patch a vulnerability in an implicit dependency.

/retest eks-anywhere-presubmit

/test eks-anywhere-presubmit

/approve


Support external config files

I was playing with a project to generate multiple config files based on currency and strategy and I didn't want to "pollute" gekko project with custom files. What I was trying to do is feed gekko with config file and start it from a different project(location) and seems it's not supported because of this part of the code in core/util.js:
// helper functions
var util = {
  getConfig: function() {
    // cache
    if(_config)
      return _config;

    if(!program.config)
        util.die('Please specify a config file.', true);

    if(!fs.existsSync(util.dirs().gekko + program.config))
      util.die('Cannot find the specified config file.', true);

    _config = require(util.dirs().gekko + program.config);
    return _config;
  },
...

Current code supports only config files located within gekko folder!
I'd propose to support both cases so config file can be provided from within gekko project or external path.  Making this small change could make it more flexible and support cases like mine where you don't want to make changes directly in gekko project but adding features from external projects:
// helper functions
var util = {
  getConfig: function() {
    // cache
    if (_config)
      return _config;

    if (!program.config)
      util.die('Please specify a config file.', true);

    try {
      _config = require(program.config);
      return _config;
    }
    catch (e) {
      if (e instanceof Error && e.code === 'MODULE_NOT_FOUND') {
        _config = require(util.dirs().gekko + program.config);
        return _config;
      }
      else
        util.die('Cannot find the specified config file.', true);
    }
  },

So we could start gekko also like so:
node /path/to/gekko/gekko --config /path/to/config.js
I could make a PR if needed!
UPDATE: This method supports current cli method and the method I suggested. It’ll not remove current option!

Yes this is a big issue. Even though most modules inside Gekko are modular and independent of each other most files still import util which requires a config. That came out of a time when the whole codebase was very small and this was managable.
Here is an example of a huge part of the codebase that I am completely pulling out of these weird dependencies: https://github.com/askmike/gekko/pull/2118
Going forward I want to do that for a lot more modules.

Quick question: what kind of code are you looking to use outside Gekko?

As I explained in previous comment, I was building this dynamic config generator to make it easier to monitor multiple assets and currencies with multiple strategies. You may have a look at multi-gekko, that's the case I had! Initially i started as everyone, just dropping my files inside gekko folder but then I had two machines and I had to commit changes very frequently to reflect on the other one. I ignored configs folder that was being generated but I didn't like that project.json of gekko was changing, so I decided to make a small change in util.js and make external the project what's now called multi-gekko


broken on darwin & windows

If we try to use elastic-agent-system-metrics for darwin or windows we get the following errors:
process_windows.go:41:32: undefined: names
process_windows.go:42:36: undefined: names
or
process_darwin.go:67:32: undefined: names
process_darwin.go:68:36: undefined: names
This was introduced by https://github.com/elastic/elastic-agent-system-metrics/pull/103

@florianl can you please look at this since it was introduced by your PR?

Revert PR to unblock main/new PRs: https://github.com/elastic/elastic-agent-system-metrics/pull/113

Pushed a PR with a fix in https://github.com/elastic/elastic-agent-system-metrics/pull/116.

Revert of the revert with https://github.com/elastic/elastic-agent-system-metrics/pull/117

With https://github.com/elastic/elastic-agent-system-metrics/pull/116 (the fix) and https://github.com/elastic/elastic-agent-system-metrics/pull/117 (the reintroduction of the revert) merged, I'm closing this issue.


sunvox: 1.9.6c -> 2.0c

Motivation for this change
I wanted to use the latest version of SunVox. And, while I'm at it, I might as well just submit it to the repo to make it available to everyone.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 158366 run on x86_64-linux 1

1 package built:

sunvox


[DND v4.1.0] Messages for saving throws and abilitys are not working

Good day,
I know the DND update is very fresh out. But just for your information, saving throws, ability checks, concentration and death saving throws are currently not working. You get the following errors and no messages are displayed:
"Error: Error thrown in hooked function 'bound preRollAbilitySave' for hook 'dnd5e.preRollAbilitySave'. o is undefined"
"Error: Error thrown in hooked function 'bound preRollAbilityTest for hook 'dnd5e.preRollAbilityTess'. o is undefined"
"Error: Error thrown in hooked function 'bound preRollDeathSave' for hook 'dnd5e.preRollDeathSave'. o is undefined"
You also get deprecated warnings for attack and skill rolls (but messages are displayed):
"Error: The dnd5e.preRollSkill hook has been deprecated and replaced with dnd5e.preRollSkillV2."
"Error: The dnd5e.preRollAttack hook has been deprecated and replaced with dnd5e.preRollAttackV2."
"Error: The dnd5e.preRollToolCheck hook has been deprecated and replaced with dnd5e.preRollToolV2."
"Error: The dnd5e.preRollConcentration hook has been deprecated and replaced with dnd5e.preRollConcentrationV2."
best regards!

I would like to add that the coloring functionality is also not working with the new roll window using AppV2!


Enhancement of Profile Page

We need an enhancement of our profile, giving the read-only text of user details. I won't get change.  To get the design view you can get it from https://members.realdevsquad.com/bhavika-tibrewal the m-site

Are we expected to build member site profile page in RN?

Are we expected to build member site profile page in RN?

yup, it is going to be profile page of our user who has logged In , but it will look like our member's page profile.

I will work on this, please assign this to me.


a few questions about habitat-sim api

❓ Questions and Help
I have a few questions about habitat-sim that I want to clear up.

Coordinate
How does habitat-sim API define the world coordinate? I mean where is the world coordinate.

Is agent_state.position return (x,y,z) in world coordinate system?
Is agent_state.rotation return (QW,QX,QY,QZ) is rotation from camera coordinate to world coordinate?
Is rotation of agent_state.sensor_states also from the camera coordinate to world coordinate?

Intrinsic matrix
As we know Z * [u, v, 1]T = K * [X, Y, Z]T, where X, Y, Z are represented in camera coordinate. So I think the value of the instrinsic matrix should be the following:

K = [[fx, 0, cx],
         [0, fy, cy],
         [0, 0, 1]]
fx = width of image/(2* tan(hfov/2))
fy = height of image/(2* tan(vfov/2))
cx = width of image/2
cy = height of image/2

This is different with K = np.array([
[1 / np.tan(hfov / 2.), 0., 0., 0.],
[0., 1 / np.tan(hfov / 2.), 0., 0.],
[0., 0., 1, 0],
[0., 0., 0, 1]]) https://github.com/facebookresearch/habitat-sim/issues/80

Depth image extracted by the depth camera.

In the examples/tutorials/stereo_agent.py Why It took values less than 10 from the depth image and then divided by 10 to normalize?

What is the value in depth image meaning, is the depth value of each pixel in the camera coordinate? So if I want to know a depth of a pixel, I just read this pixel's value in depth image directly?

These things confuse me when I coding.

All of those things are in world coordinates.   There isn't anything that we expose that isn't in the global coordinate frame AFAIK. Note that (0, 0, 0) doesn't have a physical meaning tho (it isn't like the origin is always at the door to the house or something).
It's a matter of perspective.  Graphics and modern CV (deep learning) commonly uses u, v in [-1, 1]^2  instead of [0, width) x [0, height) as it makes it easier to write resolution agnostic code.
Depth is in meters (assuming the units of the dataset is meters).  That division by 10 is just a hack to get things into [0, 255] for visualization.

All of those things are in world coordinates.   There isn't anything that we expose that isn't in the global coordinate frame AFAIK. Note that (0, 0, 0) doesn't have a physical meaning tho (it isn't like the origin is always at the door to the house or something).
It's a matter of perspective.  Graphics and modern CV (deep learning) commonly uses u, v in [-1, 1]^2  instead of [0, width) x [0, height) as it makes it easier to write resolution agnostic code.
Depth is in meters (assuming the units of the dataset is meters).  That division by 10 is just a hack to get things into [0, 255] for visualization.

@erikwijmans I really appreciate your reply. It is very helpful. Thanks again!!

@erikwijmans I really appreciate your reply. It is very helpful. Thanks again!!

@wwtx9 -- glad this was resolved. If you have the time, consider contributing a PR with this information embedded at places where you expected to find them (new users typically have the freshest set of eyes and can identify where documentation is lacking).

@wwtx9 -- glad this was resolved. If you have the time, consider contributing a PR with this information embedded at places where you expected to find them (new users typically have the freshest set of eyes and can identify where documentation is lacking).


_loadInventory is returning "Unknown response" error when response is valid but API results in body of {success: false, error: ''}

So, _loadInventory method is checking:
if (!body || !body.rgInventory || !body.rgDescriptions || !body.rgCurrency)

and if any of those are fullfilled it is returning
return callback(new Error('Invalid Response'));

But there are (random) cases when Steam API results in {success: false, error: ''} and I would interpret it differently by inserting below code, before return line mentioned.
if(body && !body.success){
	this.emit('debug', 'loading inventory: unknown steam api error');
	return callback(new Error('Unknown Steam API error'));
}

Or even before checking if body is false.
It's my first issue on github so, please excuse me if I didn't format text correctly.
Edit: I just had another idea, that you can actually check if there is any error in body response and print it out like:
if(body && !body.success){
	if(body.error && body.error.length > 0){
		this.emit('debug', 'loading inventory: steam api error: ' + body.error);
		return callback(new Error('Steam API error: ' + body.error));
	} else {
		this.emit('debug', 'loading inventory: unknown steam api error');
		return callback(new Error('Unknown Steam API error'));
	}
}

You should read the first thread in this issues board and post this over on the official boards.

I thought it's bug/feature request and posting it here fits.

@Alex7Kom, you should also check if body.error isn't null as I did in example, because sometimes there is no error, and emiting that will probably throw.

If body itself is not null or undefined it won't throw.

@Alex7Kom I had case where body wasn't null nor undefined and also body.success wasn't true, but there was no error, so without checking if body.error is anything it threw.

@Alex7Kom Just found out when it can happen. When account has restriction due to steam guard when you try to load inventory (it requests https://steamcommunity.com/my/inventory/json/753/1/?trading=1 uri) the result is {success: false} so when you check that there is body, and it has !body.success, then when you will try to print out body.error, it will throw, because body is just {success: false} and nothing else.

Have you checked? In your case body.error will be just undefined and won't cause a reference error.
var body = { success: false };
console.log(body.error)
// undefined
console.log('loading inventory: error: ' + body.error);
// loading inventory: error: undefined

@Alex7Kom I haven't, so you're right, it should be just undefined without throwing, but I remember I had problems without checking if there is error, it looks like I was doing something else with it that caused it to throw.


bug: Complexity score doesn't appear to minimize complexity

Related to this reddit comment thread:
https://www.reddit.com/r/SatisfactoryGame/comments/r50pd4/i_made_a_shiny_new_production_calculator_geared/hmlq2kk/
Complexity metric should minimize the number of distinct input items or something similar.

Ah yes, this is something I'm still working on. The way complexity works currently is that it minimizes the total number of inputs for each recipe multiplied by the number of copies of that recipe. This doesn't produce as intuitive results as I would like though.
Unfortunately due to the technicalities of the way the solver works it's difficult to formulate optimization rules about certain types of features, including global features like "least number of overall input items" that would make the most sense to measure complexity. (For more detail, the solver formulates the problem in terms of a linear optimization problem, which has strict rules about the form of the objective function.

Further updates on this issue: I have a way to solve this issue with a better definition of complexity. However, due to the mathematics of the problem it becomes EXTREMELY slow (or inaccurate if I set a time limit) for large factories. I will continue working on this though because I really want this feature to work properly.

I'm going to go ahead and close this as resolved, as the logic I have in place now is likely the final version.


Is it possible to disable yabai in some specific desktops?

MacOS can have multiple desktops and you can swiped between them use your fingers. But for some desktops, I don't want to arrange my windows strictly. So I want to disable yabai in those desktops. Is it possible?

See https://github.com/koekeishiya/yabai/wiki/Configuration#layout

I am so sorry for my carelessness. Actually I did not know what 'space' means before.


Prebuilded dll

Hello,
I am on VS2010 Express. So Nuget and manual build is not working out of the box.
Is it possible download builded dll some where?
Could you please share it?

@SergXIIIth the README has been updated with details of how you can download the package that was published to NuGet and extract the DLL:
https://github.com/pusher-community/pusher-websocket-dotnet#direct-download


v2.2.0 release .exe being detected by Windows Defender as trojan

See attached screenshot. Previous version wasn't detected as such, but this one gets detected by Windows Defender the moment I downloaded it.

duplicate, already addressed in closed issues


Editable Gauges

Hello,
Can we have an editable version of the gauges? Like clicking on the specific value and the pointer points to that value and the value gets updated and so on. Please let me know if there is any workaround to achieve this as well.
Thanks and regards

Take a look at https://rawgit.com/Mikhus/canvas-gauges/master/examples/issue-63.html - is that what you mean?

I had seen that. But that is not what I am looking for. I was expecting a gauge where a user can click on the gauge(say at value 23), and then the value of the gauge would be set to 23. More so like an interactive gauge. Something like this: https://www.rgraph.net/demos/thermometer-adjustable.html.


feat: android e2e tests

Description

detox e2e tests are running on ubuntu-latest
had to patch react-native-quick-crypto to make it compile
updated react-native-camera-kit for the same reason - fix compile error

Type of change
Refactoring
Tests
Detox test

Had to push an update, but before that there were a series of 5 uninterrupted successful test runs
And before that around 10

It's probably because of https://github.com/synonymdev/bitkit/pull/1992, try changing it to app-x86_64-release.apk or app-x86_64-debug.apk

Is it possible only do x86_64 build for detox tests? This might speedup the build/test

yeah I think like this in detoxrc should work:
$ ./gradlew :app:assembleDebug -PreactNativeArchitectures=x86_64

Reviewed the tests and CI runs. We can definitely make some improvements such as remvoing hard-coded waits in favour of checking e.g. that backups have succeeded, but it looks stable and the time saving is not worthwhile at this time. LGTM.


Migrating from Slack (free instance) to Discord

Quoting @mairin from the #community channel in the InstructLab Slack workspace:

:wave: Have not filed an issue around this yet, but I am proposing we move (gently, in a planned & coordinated fashion) to Discord from Slack. Our Slack instance has a 30 day history timeout and Discord does not, and a lot of AI communities are centered around Discord. We had a reason to not use Discord up front (we thought our IBM friends were not able to join us there due to a corporate policy) but it turns out that isn't the case (anymore?) so there's nothing really preventing us from moving besides making sure we do so in an orderly fashion.
@RobotSail and I are leading this proposal / planning with @cybette’s support. If you have any questions / concerns / etc. please hit us up either here if you feel comfortable, or in a DM!

Previous discussion on this issue for reference: #279

For migrating in an orderly fashion - what's the plan? We have 1,000 users in the InstructLab Slack instance (can pull 28dau  stats if that helps us). How will we migrate them? Are we not concerned about losing folks in the migration?
I will note for the record that our concerns focus on losing project history. We make very little use of the project email lists. Would making better use of them for decisions made, etc., help mitigate the problem?

We have discussed that OSPO will not be able to support bridging due to legal concerns over Slack and Discord ToS. Without a bridge we would have to try and migrate all current 1000+ Slack users to Discord to maintain the community. In order to do so we'll need a phased approach. Here's my proposal, please feel free to comment:
Preparation (2 weeks)
Server Prep:

Audit Slack for list of channels, key integrations/bots, and export/backup data if possible
Create channel structure on Discord to mirror what we have on Slack, set up roles and permissions (but do not ask people to move yet!)
Configure settings to make the experiences similar to make migration easier (e.g. meeting reminders, emoji packs? 😄 )

Communications:

Nov 26: share and discuss issue during the weekly community meeting
Draft new guide for Discord (similar to the Slack guide)
Creat migration FAQ
get consensus from the Oversight committee

Initial Rollout (2 weeks)

Dec 10: if the first phase progress as planned, we can announce during the community meeting and more widely
Publish the Discord guide and migration FAQ
Provide early access to maintainers, CoC committee, oversight committee, and other key community members
Conduct training sessions if necessary (e.g. moderation)
Add a migration support channel on both Slack and Discord
Test integrations/webhooks to make sure they work as desired
In the second week start inviting active community members (@here in Slack channels)

Community transition (4 weeks)

Invite the rest of the community (@channel on Slack)
Update Slack channel topics with the news and point to Discord guide and migration FAQ
if a Slack channel has a different corresponding channel on Discord, make sure it's mentioned in the channel topic
Monitor both Discord and Slack during the transition, especially the migration support channel
Note that this will probably happen over the year-end holidays, so resources may be sparse
Provide step-by-step video guide if possible
Ping all Slack users again after the new year to catch the stragglers

Slack deprecation

Set deadline for shutting down Slack workspace
Send final reminders on all communication channels (Slack, mailing lists, social media, during meetings)
Final backup of Slack data before deleting Slack workspace

For migrating in an orderly fashion - what's the plan? We have 1,000 users in the InstructLab Slack instance (can pull 28dau stats if that helps us). How will we migrate them? Are we not concerned about losing folks in the migration?

I am concerned, and we will lose some. Hopefully with the plan I outlined above we will be able to get most people across. We also need at least 500 members on Discord before we get server insights.

Thank you for this research @cybette. Any clue how we get a backup of our Slack data? I thought this was only available to paid tier Slack users but I am also admitting my ignorance. :)

We can only export data from public channels with the Free plan, but I think that's good enough for our needs.

Thank you for the research, good to understand all of our options.

@cybette does no bridging between slack and discord as well usage of the paid slack/matrix bridge as a mediary? [i dont know if the matrix slack bridge has agreements in place]

Someone from the Maintainer team needs to own migrating the reporting of the E2E jobs.
I did the initial implementation but I'm not interested in owning these migrations, lest people decide later we want to switch platforms again.
I'll let someone with more Discord experience volunteer for this.

#409 and #410 are related to this


Spevacus: Watch sax.video

Spevacus requests the watch of the watch_keyword sax\.video. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

sax\.video has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


fix 212 fix imports for production

closes #212
This PR fixes the errors regarding failed imports of the geojsons and images (like default profile picture), fontawesome and leaflet stylesheets.
Regarding the issue of the non-persistent active storage: https://devcenter.heroku.com/articles/active-storage-on-heroku
Team Red had that issue as well, see: https://github.com/hpi-swt2/compass-portal-red/pull/230
Their solution was to add an amazon aws storage, but this doesn't really fit into this PR.

Sorry that I didn't see this before merging, but you forgot to fix the import of buildings.geojson in leafletMap.js.erb, line 64. :sweat_smile:

Thanks for pointing that out! I created a new Pull Request  (#251) for these changes.


How can I achieve a weekly increment of *_seconds_count. My project restarted several times during this period of time

Proposal
Use case. Why is this important?
“Nice to have” is not a good use case. :)
Bug Report
What did you do?
What did you expect to see?
What did you see instead? Under which circumstances?
 Note that you shouldn't assume that the result is 100% accurate.
I'm closing it for now. If you have further questions, please use our user mailing list, which you can also search.


📝 Update includes in docs/de/docs/tutorial/middleware.md

📝 Update includes for docs/de/docs/tutorial/middleware

Thank you! @paintdog :tada:


Update Issue - Automate_undefined_85021

URL tested: https://accounts.google.com/v3/signin/identifier?continue=https%3A%2F%2Fmail.google.com%2Fmail%2Fu%2F0%2F&emr=1&followup=https%3A%2F%2Fmail.google.com%2Fmail%2Fu%2F0%2F&ifkv=AeZLP99FDIrWzl33lUDDP1vvyD2p2Mt-nS8aqkCDl95us2XmPnC3phVcLLyOlu3xtHKuS6uKWf7bgg&osid=1&passive=1209600&service=mail&flowName=GlifWebSignIn&flowEntry=ServiceLogin&dsh=S-432644028%3A1735684645294387&ddm=1
Open URL on Browserstack
default description

Property
Value

Browser
Chrome 116.0

Operating System
OS X High Sierra

Resolution
1688x792

Screenshot Attached
Screenshot URL

Updated Screenshot Attached


man: better wording

This contains part of the suggestions made by @digitensions in her PR.

It’s not clear to me what hurts Travis…

This contains part of the suggestions made by @digitensions in her PR.

there may be an edit conflict at some point, which one would be better to check & merge first?

Travis apply your branch to the master before build but uses the outdated .travis.xml from your branch.
Please rebase.

there may be an edit conflict at some point, which one would be better to check & merge first?

Here should be included the obvious parts. We have to discuss dome of the other parts, because I am not sure that the proposed changes are correct.

Thanks for implementing the changes, and I am sure there will be a few errors. Pls notify if you need me to assist with adjustments etc.

On 19 Jun 2019, at 12:56, Reto Kromer<EMAIL_ADDRESS>wrote:
there may be an edit conflict at some point, which one would be better to check & merge first?
Here should be included the obvious parts. We have to discuss dome of the other parts, because I am not sure that the proposed changes are correct.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@digitensions please review changes (on the "files changed" page, click on "review changes" and select "reject" with comments if something to change or "approve" if fine).

Will do Jérôme, as soon as I can this evening. Thanks for working on it :)

On 20 Jun 2019, at 08:58, Jérôme Martinez<EMAIL_ADDRESS>wrote:
@digitensions please review changes (on the "files changed" page, click on "review changes" and select "reject" with comments if something to change or "approve" if fine).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Action to query the publishing status of app store

How can I view the release status of the app store version through Fastlane, such as being approved, approved, etc

It seems like you have not included the output of fastlane env To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

I want to know if there is an action to check the release status of the App Store


Convert Http Header to Http2 Header

Currently, we marshal http header as string. But we can marshal it as binary via HPack.

What area are you talking about?

cache

You mean HPACK String Literal Representation (nearly equal to Huffman encoding)? We obviously cannot use other representations because those require Static Table and Dynamic Table which is only meaningful until the end of a session (index number 42 can be something else on a different session).
cc @SolidWallOfCode

Yep. Dynamic Table should be special .

You would have to store the dynamic table with the cache entry and it would make cached entries more complex.  Also, you wouldn't be able to use it directly since the dynamic table for a session would be different from cache, so you would still have to translate it anyways.

@bryancall I think you pointed out the same thing as my comment?
And my understanding is that the point is Huffman encoding (not use of Dynamic Table). Is it correct, @scw00 ?

Right. Most of the headers are already indexed in static table. So only few custom headers need to be encoded as string. So static table have already had const string to convert the index to the real human readable header string.
So it would be like this.
header(index): value
static table (huffman)
:path (index 0): ....
:content-type(index 1): ...
:content-encoding(index 2): ...
dynamic table (huffman or not)
:x-ats-debug: xxxx
This format will match both h1 case and also h2/h3 case.  It will decrease header payload and increase the data payload in one fragments.

Static Table would not work actually because the headers on H2 Static Table and H3 Static Table are different.

So can we involve our own table?

Well, that is perhaps possible, but I'm not too sure if it is really effective. It would require another table lookup and decoding before sending a header.

I don't think there is a big advantage to storing Huffman encoded headers in cache


s/Repair/Rescue/g

Closes #378

Coverage remained the same at 93.759% when pulling 7c27dc10dbde044ca7770c8d66a417f546b908af on SirCmpwn:s-repair-rescue-g into 90bac4fb9551df072813ea9abd6e973e75df2a24 on linode:master.

Thanks!


⚠ Cioos Pacific ERDDAP has degraded performance

In 5edd3df, Cioos Pacific ERDDAP (https://data.cioospacific.ca/erddap/index.html) experienced degraded performance:

HTTP code: 503
Response time: 19211 ms

Resolved: Cioos Pacific ERDDAP performance has improved in ff6f911 after 7 minutes.


Add role="application" to main div (electron)

Fixes
Issue Number:

What is the current behavior?
What is the new behavior?
Other information

PR Checklist

Toggle...
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[ ] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

We're not using electron here anymore, eventually needs to be ripped out.


Allow keywords anywhere 'Name' is used.

The GraphQL specification (and reference implementation) doesn't restrict the keywords 'query' or 'fragment' as Names.  Because of ANTLRs behaviour, input with arguments, field names, or types with either of these values were being rejected, e.g:
query Something {

  search(query: "theo") {
    ...
  }

}

This patch updates the grammar and the conversion to allow these keywords.
Note that the gradle build scripts do not seem to be automatically updating the generated source code, so i manually regenerated it.

Thanks for this PR.
I have a question: Shouldn't we do this also  for mutation? I think this is "restricted" in the same way currently ...

Yeah - along with 'on', 'true', and 'false' ... although, the GraphQL grammar isn't context free - so we can't always allow a Name where it should be allowed with ANTLR (at least - my knowledge of it - i've not used it since 3.x, and it would have been very hard if not impossible in it then).
Sigh; The updated patch does the best i can without some major work on the ANTLR grammar, or hand-rolling a parser. Specifically;

'true' and 'false', and 'on' can't be used as parameter names, nor as a field name or alias.
'on', 'true', or 'false' can't be used as a fragment name.

Well great, you made me read the appendices of the spec, something I avoided until now, lol.
Yes, the spec is pretty clear in that practically anything can be a name.  Given the stated goal of keeping it simple I think they wouldn't care if keywords were used, but at the same time I'm not sure whether this was intentional or not.  I'll ask.

Also, there are a lots of line changes with either name changes or removing @NotNull.  Is it possible to create a patch that avoids this?  There is a conflict anyways.

I ran into this; I accidentally named a field called "query".  Problem was, graphiql was the thing complaining about a parse error, not graphql-java.  So unless most tools/libraries have this support, it may be premature to put this in?

Hey @zourzouvillys, thank you for this PR. Sorry it took so long to be resolved! Following up with some updates to the grammar in #243, I've incorporated your concept here in to #277. Will close this and merge that. Thanks again.


2FA

Codecov Report

Merging #8 (65dc8c2) into develop (0971c63) will decrease coverage by 6.27%.
The diff coverage is 73.83%.

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage   100.00%   93.72%   -6.28%
===========================================
  Files           33       38       +5
  Lines          340      446     +106
  Branches        37       51      +14
===========================================
+ Hits           340      418      +78
- Misses           0       27      +27
- Partials         0        1       +1

Impacted Files
Coverage Δ

src/components/ConfirmEmailBanner.jsx
100.00% <ø> (ø)

src/components/GameSwitcher.jsx
100.00% <ø> (ø)

src/components/Link.jsx
100.00% <ø> (ø)

src/components/MobileMenu.jsx
100.00% <ø> (ø)

src/components/ServicesLink.jsx
100.00% <ø> (ø)

src/pages/ConfirmPassword.jsx
6.89% <6.89%> (ø)

src/components/GlobalBanners.jsx
88.88% <88.88%> (ø)

src/components/Account2FA.jsx
100.00% <100.00%> (ø)

src/components/NavBar.jsx
100.00% <100.00%> (ø)

src/components/RecoveryCodes.jsx
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0971c63...65dc8c2. Read the comment docs.


Avoid object construct when linear search

Description
This PR resolves a todo left in FST that we construct some useless objects during linear search. This is also an effort that tries to avoid Outputs#read as we have more outputs distributed in arcs with MSB VLong format.
I'll run luceneutil soon.
See also https://github.com/apache/lucene/pull/12661

Result on wikimediumall (nothing changed obviously) :
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                         LowTerm      229.72      (4.5%)      225.59      (3.8%)   -1.8% (  -9% -    6%) 0.197
                 LowSloppyPhrase        1.61      (4.3%)        1.59      (5.7%)   -1.6% ( -11% -    8%) 0.356
                     LowSpanNear        4.16      (2.0%)        4.10      (2.9%)   -1.5% (  -6% -    3%) 0.069
                        PKLookup      101.50      (2.8%)      100.16      (2.8%)   -1.3% (  -6% -    4%) 0.155
                    HighSpanNear        6.82      (3.1%)        6.75      (3.1%)   -1.0% (  -6% -    5%) 0.347
                     AndHighHigh       18.56      (2.9%)       18.43      (2.4%)   -0.7% (  -5% -    4%) 0.432
             MedIntervalsOrdered        3.45      (6.6%)        3.43      (7.2%)   -0.6% ( -13% -   14%) 0.802
                      AndHighMed       40.23      (4.9%)       40.02      (3.9%)   -0.5% (  -8% -    8%) 0.714
                   OrHighNotHigh      154.45      (4.2%)      153.91      (4.8%)   -0.4% (  -8% -    9%) 0.814
                     MedSpanNear        1.10      (2.2%)        1.10      (2.1%)   -0.1% (  -4% -    4%) 0.908
                    OrHighNotLow      233.46      (5.4%)      233.40      (4.3%)   -0.0% (  -9% -   10%) 0.986
                      HighPhrase       38.09      (2.7%)       38.13      (4.6%)    0.1% (  -7% -    7%) 0.946
                   OrNotHighHigh      139.46      (4.7%)      139.59      (4.5%)    0.1% (  -8% -    9%) 0.950
             LowIntervalsOrdered        2.74      (4.9%)        2.75      (5.5%)    0.2% (  -9% -   11%) 0.907
                          Fuzzy2       33.67      (2.2%)       33.75      (2.2%)    0.3% (  -4% -    4%) 0.730
                HighSloppyPhrase        3.56      (4.0%)        3.58      (3.7%)    0.4% (  -7% -    8%) 0.769
                       LowPhrase       25.91      (2.4%)       26.01      (3.9%)    0.4% (  -5% -    6%) 0.694
                         Respell       27.34      (2.4%)       27.47      (2.3%)    0.5% (  -4% -    5%) 0.540
                 MedSloppyPhrase        9.25      (3.6%)        9.30      (4.0%)    0.5% (  -6% -    8%) 0.674
                       OrHighLow      187.50      (4.7%)      188.87      (2.9%)    0.7% (  -6% -    8%) 0.578
                         MedTerm      233.89      (4.3%)      235.63      (3.8%)    0.7% (  -7% -    9%) 0.581
                         Prefix3       63.58      (5.8%)       64.11      (3.7%)    0.8% (  -8% -   10%) 0.607
                       MedPhrase        9.37      (2.6%)        9.45      (4.1%)    0.9% (  -5% -    7%) 0.444
                    OrNotHighLow      231.48      (3.0%)      233.63      (4.1%)    0.9% (  -6% -    8%) 0.438
                      AndHighLow      307.03      (3.8%)      310.29      (4.0%)    1.1% (  -6% -    9%) 0.412
                          Fuzzy1       42.13      (2.7%)       42.59      (2.2%)    1.1% (  -3% -    6%) 0.174
                        Wildcard       65.44      (3.1%)       66.25      (2.1%)    1.2% (  -3% -    6%) 0.160
            HighIntervalsOrdered        0.37      (4.9%)        0.37      (4.1%)    1.6% (  -7% -   11%) 0.304
                      OrHighHigh       12.90      (4.4%)       13.10      (5.0%)    1.6% (  -7% -   11%) 0.309
                    OrHighNotMed      117.52      (4.8%)      119.46      (5.2%)    1.7% (  -7% -   12%) 0.318
                    OrNotHighMed      123.61      (6.1%)      125.82      (4.2%)    1.8% (  -7% -   12%) 0.302
                        HighTerm      217.07      (4.1%)      222.24      (3.0%)    2.4% (  -4% -    9%) 0.047
                       OrHighMed       37.00      (4.8%)       37.94      (3.9%)    2.5% (  -5% -   11%) 0.081

Nightly benchmark shows fuzzy queries are a bit happy for this change: https://home.apache.org/~mikemccand/lucenebench/2<IP_ADDRESS>.03.18.html.