Update VM creation scripts to update Linux kernel

We are adding tests that require Linux kernel 4.9+, so the VM creation scripts need to be updated.
echo 'DOCKER_OPTS="${DOCKER_OPTS} --storage-driver=overlay"' | sudo tee --append /etc/default/docker is changed to printf "{\n\t\"storage-driver\": \"overlay\"\n}" | sudo tee /etc/docker/daemon.json  because newer Docker versions use /etc/docker/daemon.json instead of /etc/default/docker to check which storage driver to use.
grpc-jenkins-linux60 was created with this script and seems to be working fine.

No significant performance differences

Known issues:
Mac - #9151
Interop - #10576


05-03: Web app Deployment: add instructions to switch project

https://rh-aiservices-bu.github.io/parasol-insurance/modules/05-03-web-app-deploy-application.html
By default, the admin view of OpenShift try to show "all projects", which results in an error message.
Add instructions for project switching.

Fiixed with #182 by switching to ArgoCD UI deployment


let foo to => 1 generates a syntax error

Same cause as #1095 most likely?

Yes, and this one ends in LET LIDENT WITH. Again, not sure of the message.

Current master has a better error message:
$ echo 'let foo = to => 1' | ./_build/install/default/bin/refmt
File "", line 1, characters 10-12:
Error: 1902: to is a reserved keyword, it cannot be used as an identifier. Try `to_` or `_to` instead


Create Posts “test”

Automatically generated by Netlify CMS

👷 Deploy Preview for transcendent-melba-6e8a8a processing.

Name
Link

🔨 Latest commit
cd81345057831b45bb4ea4ccb021f5b2825543b2

🔍 Latest deploy log
https://app.netlify.com/sites/transcendent-melba-6e8a8a/deploys/6448c90ba027e30008ff2a84


Live activity

Only works on iOS 16.2+ because of API availability.
Includes setting to turn off live activity.
Live activity is started when the app leaves the active state. Activities can be active for up to 8h. As long as app is opened at least once every 8h, live activity should work continuously.
Activity turns stale 6m after last bg reading, at which point it will no longer display BG. This is to avoid showing old data. The lock screen and expanded dynamic island view also shows timestamp of displayed BG as further ability to verify that the displayed data is current.
There have been mentions of using a shortcut + automation to automatically renew live activities in regular intervals. This could be useful to cover cases where the app is not re-opened every 8h. It might work with LiveActivityStartingIntent. But this should be left to a separate PR, if implemented at all.
Not tested over long periods of time yet.

I love it! Great idea. Fingers crossed that it won't affect battery life too much.
Some feedback:
I think the "show live activity" toggle should probably be defaulted to off.
As others noted on Discord, delta is always in mg/dL even if mmol/L is used in the app.
Also, here's a screenshot of the Dynamic Island on my iPhone 14 Pro Max where the delta is cut off. Delta was just +2


No cluster name by default in conf/configuration.yaml

In gitlab by @sylvaingaudan on Jul 25, 2017, 10:33
By default, conf/configuration.yaml should configure a default standalone elasticsearch node, not a cluster. Comment or empty default value for:
elastic-cluster: ${ARLAS_ELASTIC_CLUSTER:-elasticcluster}

In gitlab by @sfalquier on Jul 28, 2017, 10:28
added ~2377174 label

In gitlab by @sfalquier on Aug 4, 2017, 10:13
added ~2424199 and removed ~2424198 labels

In gitlab by @sfalquier on Aug 4, 2017, 10:19
mentioned in commit ca18a38ec2ed05d5bb951f62f6539dcfaa327cd1

In gitlab by @sfalquier on Aug 4, 2017, 10:21
mentioned in merge request !74

In gitlab by @sfalquier on Aug 4, 2017, 10:21
assigned to @sfalquier

In gitlab by @sylvaingaudan on Aug 4, 2017, 11:59
closed via merge request !74

In gitlab by @sylvaingaudan on Aug 4, 2017, 11:59
closed via commit 3de5ed4d401904e357c6fbc87ae8780542c8179c

In gitlab by @sylvaingaudan on Aug 8, 2017, 16:45
mentioned in commit 3de5ed4d401904e357c6fbc87ae8780542c8179c


Fix typo in javadoc

Check List:

Removes unmeaningful whitespace in javadoc.
Unit tests : NA
Javadoc with a code example (on API only) : NA

Integrated thanks @gyumin-kim!


Level 5; help with printing out each ride on a new line

Summary
I've managed to sort my list of all fare option but I am unsure on how to return each of the options on a new line.
Description:
At the moment, my output looks like the one down below. Can someone just give me a hint on how to approach the problem? Can I use System.out.printIn or is there another approach on how return each option on new lines and not as a whole list?

I used a void method and did System.out.println and it passed the test

#92 had the same issue, you might want to check it out

you are currently returning a sortedlist, which in turn is a list that is sorted using the comparator implemented
what you want is a string, and usually in .jsh files, at least I personally would run void classes because there is no need for a return. Hope this helps!

I think there is the possibility to return a single String and add newline characters (\n) to the end of each line that you want to 'print'.

for me i use void then system printline inside the while loop

the easiest way should be using a for loop to loop through and System.out.println()

I used a for loop to loop through the list and used System.out.println() for output! And for the method I used void so do not need to return anything

I passed the test cases by using a for loop to print out the sorted bookings sequentially with System.out.println().


More Cleanings

One question, how you return a view from your controller ?
it seem that normal view() helper is not going to work

Hi, you can return the view as string or you can return it as response https://laravel.com/docs/5.4/responses like
$response = \Response::make('some html');
return $response;

ok but how to use the view() helper function to render a blade file ?!

What was wrong with __construct ? was it buggy or what ?!

here is some tutorial by @ash-rain http://microweber.com/docs/guides/modules_laravel.md  on blade views, i dont use blade views so i dont know much
for __construct ... yes it was returning null instead of the $app object

thanks for the cleanings,
don't waste time to cleanup, the code needs refactor and it will be totally cleaned up some day when major refactor is done :)

I do not see what you exactly mean...
What is your plan for refactoring your code?
Do you plan to rewrite it ? or refactor the current code ?
I generally start refactoring with the most obvious and easy ones...
then venture into more grand breaking ones like restructuring the classes and etc...
These clean ups are as starting point...

ok, continue if you wish, i will merge it, but i don't know if its just waste of your time
code will be refactored and huge classes must be separated on smaller, etc
for example this huge class https://github.com/microweber/microweber/blob/1.0.5/src/Microweber/Providers/ShopManager.php
is now less huge
https://github.com/microweber/microweber/blob/1.0.9/src/Microweber/Providers/ShopManager.php
and when the code is refactored all the formating and small stuff is fixed anyway


DinD: Docker engine not starting

After starting the container, the docker engine within the container does not seem to start correctly.
docker-compose.yml:
version: '3.8'

services:
  gitea_act_runner:
    image: vegardit/gitea-act-runner:dind-rootless-latest
    privileged: true
    volumes:
      - data:/data
    environment:
      TZ: "Europe/Berlin"
      GITEA_INSTANCE_URL: [redacted]
      GITEA_RUNNER_REGISTRATION_TOKEN: [redacted]
      GITEA_RUNNER_NAME: [redacted]
volumes:
  data:

Console output:
gitea_runner-gitea_act_runner-1  |    _____ _ _                            _     _____
gitea_runner-gitea_act_runner-1  |   / ____(_) |                 /\       | |   |  __ \
gitea_runner-gitea_act_runner-1  |  | |  __ _| |_ ___  __ _     /  \   ___| |_  | |__) |   _ _ __  _ __   ___ _ __
gitea_runner-gitea_act_runner-1  |  | | |_ | | __/ _ \/ _` |   / /\ \ / __| __| |  _  / | | | '_ \| '_ \ / _ \ '__|
gitea_runner-gitea_act_runner-1  |  | |__| | | ||  __/ (_| |  / ____ \ (__| |_  | | \ \ |_| | | | | | | |  __/ |
gitea_runner-gitea_act_runner-1  |   \_____|_|\__\___|\__,_| /_/    \_\___|\__| |_|  \_\__,_|_| |_|_| |_|\___|_|
gitea_runner-gitea_act_runner-1  |
gitea_runner-gitea_act_runner-1  | GIT_REPO:    https://github.com/vegardit/docker-gitea-act-runner
gitea_runner-gitea_act_runner-1  | GIT_BRANCH:  main
gitea_runner-gitea_act_runner-1  | GIT_COMMIT:  0866e7a @ 2023-07-03 17:10:59 UTC
gitea_runner-gitea_act_runner-1  | IMAGE_BUILD: 2023-07-03T17:11:52Z
gitea_runner-gitea_act_runner-1  |
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:21 INFO [/opt/run.sh:26] Timezone is CEST +0200
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:21 INFO [/opt/run.sh:27] Hostname: 3f504d42d9a3
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:21 INFO [/opt/run.sh:28] IP Addresses:
gitea_runner-gitea_act_runner-1  |  - <IP_ADDRESS>
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:21 INFO [/opt/run.sh:62] Starting Docker engine...
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/cpuset: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/cpu: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/cpuacct: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/blkio: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/memory: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/devices: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/freezer: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/net_cls: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/perf_event: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/net_prio: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/hugetlb: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/pids: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/rdma: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | mount: /sys/fs/cgroup/misc: permission denied.
gitea_runner-gitea_act_runner-1  |        dmesg(1) may have more information after failed mount system call.
gitea_runner-gitea_act_runner-1  | Starting Docker: docker.
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:22 INFO [/opt/run.sh:67] Waiting for Docker engine to start...
gitea_runner-gitea_act_runner-1  | time="2023-07-04T21:35:23.035500635Z" level=info msg="API listen on /var/run/docker.sock"
gitea_runner-gitea_act_runner-1  | 2023-07-04 23:35:24 INFO [/opt/run.sh:67] Waiting for Docker engine to start...

The last two lines are repeated endlessly. Any ideas?

Does it only happen for the rootless image version?

Yep, the others work as expected.

I have the exact same error. However, for me it does not work with rootless nor rootful DinD image. But I have to add, that I use rootless podman and podman-compose and not docker and docker-compose on my host.

@sinitcin when using dind you cannot mount the docker socket from the host system, i.e. you need to remove this line:

- /var/run/docker.sock:/var/run/docker.sock:rw

@Miladiir the dind-rootless container tried to start docker without the rootless mode, I fixed that. please give it another try.

I used the vegardit/gitea-act-runner:dind-rootless-latest from Docker Hub. However, I still get the error.
podman log:

Output
GIT_REPO:    https://github.com/vegardit/docker-gitea-act-runner
GIT_BRANCH:  main
GIT_COMMIT:  6b01de7 @ 2023-07-23 11:41:44 UTC
IMAGE_BUILD: 2023-07-23T11:42:28Z
2023-07-23 14:26:31 INFO [/opt/run.sh:26] act_runner version v0.2.3
2023-07-23 14:26:31 INFO [/opt/run.sh:27] Timezone: CEST +0200
2023-07-23 14:26:31 INFO [/opt/run.sh:28] Hostname: 70784b3a707b
2023-07-23 14:26:31 INFO [/opt/run.sh:29] IP Addresses:

<IP_ADDRESS>
2023-07-23 14:26:31 INFO [/opt/run.sh:39] Starting Docker engine (rootless)...
2023-07-23 14:26:31 INFO [/opt/run.sh:54] Waiting for Docker engine to start...
: exit status 1
2023-07-23 14:26:33 INFO [/opt/run.sh:54] Waiting for Docker engine to start...
: exit status 1
2023-07-23 14:26:36 INFO [/opt/run.sh:54] Waiting for Docker engine to start...
: exit status 1
..........

My docker-compose.yml:

Content
version: "3.8"
services:
server:
image: gitea/gitea:1.20-rootless
user: 1001
restart: always
volumes:
- ./data/gitea/data:/var/lib/gitea:Z
- ./data/gitea/config:/etc/gitea:Z
- /usr/share/zoneinfo/Europe/Berlin:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro
ports:
- "3000:3000"
- "2222:2222"
gitea_act_runner:
image: vegardit/gitea-act-runner:dind-rootless-latest
privileged: true
volumes:
- ./data/runner/data:/data:rw,Z
environment:
TZ: "Europe/Berlin"
GITEA_INSTANCE_INSECURE: true
GITEA_INSTANCE_URL: 'http://localhost:3000'
GITEA_RUNNER_REGISTRATION_TOKEN: 'XXXXX'

@JeffersonTerrerfield I am not using podman, the image is targeting the docker runtime. However if you find anything useful to improve podman support, PRs are welcome.

Works now. Thanks


How to remove Child action cache

I've searched for this but I can't find it. See here an example:
Index action of the HomeController (homepage):
[AllowAnonymous]
public ActionResult Index()
{
   return View();
}

ChildAction of the NewsController:
[AllowAnonymous]
[ChildActionOnly]
[DonutOutputCache(Duration = 600, Location = OutputCacheLocation.Server)]
public PartialViewResult LastArticles(int numberOfArticles)
{
	return PartialView("_LastArticles", db.NewsArticles
	.Include(i => i.Tags)
	.Include(i => i.SeoTags)
	.Where(n => n.Status == PublishStatus.Published)
	.OrderByDescending(n => n.PublishDate)
	.Take(numberOfArticles)
	.ToList());
}

Index view of the HomeController:
@{ Html.RenderAction("LastArticles", "News", new { numberOfArticles = 2 }); }

To clear the cache I have an Admin area in my application with a controller and action in it to update the data stored by the child action. So when a news article is updated. The cache should get refreshed on the homepage.
In that action I have the following code:
var cacheManager = new OutputCacheManager();
cacheManager.RemoveItem("News", "LastArticles", new { area = "", numberOfArticles = 2 });
cacheManager.RemoveItem("News", "LastArticles", new { area = "" });

I tried multiple versions but without luck. Can you help me?

Finally found the solution. The area is ignored in the url for removing the child action. This is different then the default OutputCache attribute. I think this is a bug?
So the solution is:
cacheManager.RemoveItem("News", "LastArticles", new { numberOfArticles = 2 });

See for more information this StackOverlow question.

Thanks for reporting, I know exactly what happens.
When generating the cache key during action invocation, the default keybuilder only builds an area key component if the area is not null or empty.
By calling RemoveItem[s] with an area component set to empty, the area key component shouldn't be built either, otherwise no key will match for removal

Thank you for your reply.
So if I understand it right, this is by design? Does this effect other NewsControllers with Action LastArticles in other Area's?

Nope this is a bug, the area part should be ignored if empty for removal action.
Thus, the normal behaviour would be to remove the area impacted keys. This is what you are doing by calling cacheManager.RemoveItem("News", "LastArticles", new { numberOfArticles = 2 });
Generally speaking it's a bad idea to have controllers with the same name in different areas, we got problems in the past with that.
The solution we adopted was to prefix our area controllers with the area name itself, making url routing tweaks afterwards to hide the redundancy.
eg NewsController and AdminNewsController in the Admin area + route tweaks to avoid /Admin/AdminNews and have /Admin/News routes instead.

Well it's working for now with a workaround so no critical bug :).
Thanks for the feedback.


hash_equals() error since last night

hash_equals(): Expected known_string to be a string, null given. Apparently in this piece of code:
$signed = hash_equals($this->signature, $signature);
$this->signature appears to be empty
In MailgunRequest.php
Does anybody have a solution?

It appears mailgun is sending empty requests to the webhook


Update release process notes

The notes about a Liason and releasing patches in a certain week of the month are outdated, so they are removed from the DEVELOPMENT file.

Do we need the Liason's approval to this change?

@ralfhandl not if we can't even remember who the Liason was... and definitely not if it's the Linux Foundation liason/pm as we don't have one at the moment.


add new environment information

Add environment information pojo.

Build triggered. sha1 is merged.

Build finished. No test results found.

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/275/


train ocr model error on my dataset

train my dataset, why loss show inf? can anyone help me? @YCG09

我遇到了相同的问题呢。第二轮开始


chore: Improve Makefile structure, add comments, add coral web make commands

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

[ ] Add tests and docs: Please include testing and documentation for your changes

[ ] Lint and test: Run make lint and make run-tests

AI Description

This pull request introduces several changes to the Makefile, primarily focused on enhancing the testing, linting, and database management processes. The changes are organised into sections for the backend and frontend, with the backend section being newly added.
Backend

Testing & Linting: The PR adds a new section for testing and linting, including commands for running unit tests, community tests, and integration tests. It also introduces commands for type checking (typecheck), linting (lint), and linting with automatic fixes (lint-fix).
Database Management: A new test-db command is added to stop, remove, and restart the test database.
Setup: The install command is introduced for installation with the dev option.

Frontend

Coral Web: The PR adds commands for formatting (format-coral), generating clients (generate-client-coral), installing (install-coral), and building (build-coral) the Coral Web interface.
Assistants Web: The format-web and build-web commands are moved from the backend to the frontend section, ensuring a clear separation of concerns.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.96%. Comparing base (76e9270) to head (41344d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   78.96%   78.96%
=======================================
  Files         258      258
  Lines       10984    10984
=======================================
  Hits         8674     8674
  Misses       2310     2310

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Timer Feature Request

For more flexibility with timers in loops, you should make the timer.start() work once(not talking about oneshot) so the timer does not reset when timer.start() is called over and over, but allow a second function or a condition to be called that allows for this. Ex: timer.reset_and_start(), or timer.start(Bool reset)

I'm fine how it's now, sometimes abuse that exact behaviour from start on my game for reset cooldowns. If you really want to start don't reset the timer put this check before the call:
if(_timer.get_time_left() <= 0.0):
	_timer.start()

I'll try that then. Thanks lazor.


ARTEMIS-922 Addressing-related API clean-up

The failing test is also failing on master so I don't believe it is related to my change.


replace dependencies with long build times when used together (closes #3571)

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[x] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[x] I have added a convincing reason for adding this feature, if necessary

Other information
When ring, zstd, and blake3 where built at the same time, their build scripts that span cc will run concurrently (even if limited by --jobs=1). This would cause massively inflated build times for dependencies that otherwise aren't too bad to build.
The following dependency changes were made after looking into it in #3571

original
new
note

zstd
brotli
Hand-picked compression levels were picked for good time vs size ratio

blake3
none
We now vendor the blake3 reference implementation inside tauri-codegen

ring
getrandom
getrandom is also a CSPRNG that utilizes the OS's calls for secure random numbers. It is much more focused and smaller for our requirements.

That udeps failure seems to be a bug on the latest nightly. I also ran into it while comparing old build times and it ran successfully nightly-2022-03-18.

I ran a simple comparison using the API Example, without any changes.  rm -rf target && cargo +nightly-2022-03-18 build --timings (and --release for the release profile). I changed nothing else, so there is still LTO and all that stuff enabled, along with using Linux which comes with a couple long building dependencies like gio and gtk.
This was performed on a T410 (2 core 4 thread) w/ 8GiB RAM & an SSD.

profile
dev
this PR
delta

debug
7m 13.9s
6m 52.5s
-5.2%

release
10m 46.0s
9m 51.3s
-9.3%

This is a decent gain for a clean build without any real downsides IMO. I think it might have even greater effect for when stuff like LTO is disabled and possibly using the LLD linker due to it taking more of the CPU time. I don't really have the time to test all the configuration of that stuff right now however.
@JamesYeoman maybe you would like to compare this branch on your project you opened the issue with.

Documentation for all three targets is still working, nice!

Ooh, nice improvement in performance! How do I use this branch instead of the release tauri crate?

@JamesYeoman in your Cargo.toml:
[build-dependencies]
tauri-build = { git = "https://github.com/tauri-apps/tauri", branch = "feat/no-dep-c-build-script" }

[dependencies]
tauri= { git = "https://github.com/tauri-apps/tauri", branch = "feat/no-dep-c-build-script", features = ["leave this unchanged"] }

Make sure to run cargo update in your src-tauri dir after changing from/to git dependencies.

Wow, and this is with --release!

Sure, when my release config is
[profile.release]
panic = "abort"    # Strip expensive panic clean-up logic
lto = "thin"       # Enables link time optimizations
opt-level = "s"    # Optimize for binary size
strip = true       # Strips symbol information from the executable
incremental = true # Ensure incremental building in enabled for the release profile

[profile.release.package."*"]
opt-level = 0
incremental = true

then of course everything other than my binary is gonna compile quickly. But this is for baseline measurements, eliminating as much time cost as possible. The bare minimum execution, eliminating as much variability as possible.
And of course the windows crate had to be compiled from scratch for the first release mode run.

I'm really confused by that. What reason could there be for this one-off long build for the windows crate?

I have any insight about the windows crate, that does seem weird if you are removing the target/ dir. Only thoughts off the top of my head is that it's a very large crate with a lot of features and perhaps IO cache is kicking in for reading the source? Wouldn't think it would have this much of an effect though...

We should look into using windows-sys it has faster compile time and smaller size. @wravery can webview2-rs use windows-sys too?

@amrbashir https://github.com/tauri-apps/wry/pull/484

I guess it could be IO cache tbh. I've just changed my release profile to remove the [profile.release.package."*"] section that was disabling optimisations there, and updated the core release profile as follows
[profile.release]
panic = "abort"     # Strip expensive panic clean-up logic
lto = "thin"        # Enables link time optimizations
opt-level = 2     # Optimize for binary size
strip = "debuginfo"
incremental = true  # Ensure incremental building in enabled for the release profile

(this was the original release config)
[profile.release]
panic = "abort"    # Strip expensive panic clean-up logic
lto = "thin"       # Enables link time optimizations
opt-level = "s"    # Optimize for binary size
strip = true       # Strips symbol information from the executable
incremental = true # Ensure incremental building in enabled for the release profile

and then ran 2 builds. An 8 minute build followed by a 4 minute build, despite doing cargo clean in-between each.

I'll merge this one, we're making a new release tomorrow if tao+wry can be updated too. We can make further improvements on another PR.

We should look into using windows-sys it has faster compile time and smaller size.
@wravery can webview2-rs use windows-sys too?

Doing so would make a lot of callers uglier because the parameter conversions wouldn't be implemented for us. For instance, anytime we pass a &str and windows uses something like IntoParam<PWSTR> to convert to UCS-2/UTF-16 and wrap it in the PWSTR type, we'd have to do our own UTF-16 conversion, null terminate the buffer, and get a raw pointer to the buffer.
The bigger problem would be anything that uses the #[implement] macro to implement a COM interface probably wouldn't work. I don't think the code it generates is compatible with windows-sys. We'd have to hand-build v-tables and such, or use another crate that supports implementing COM interfaces, but without the interface definition which windows builds from the metadata.

The bigger problem would be anything that uses the #[implement] macro to implement a COM interface probably wouldn't work. I don't think the code it generates is compatible with windows-sys. We'd have to hand-build v-tables and such, or use another crate that supports implementing COM interfaces, but without the interface definition which windows builds from the metadata.

Is it worth opening an issue in windows-rs to request #[implement] macro that uses windows-sys types instead of windows? I can only imagine that manually implementing the COM interfaces of Webview2 is a lot of work to do.
A number of crates, has already moved to windows-sys like parking_lot. We also plan to move back to winit instead of tao and they already moved to windows-sys so we are definitely gonna end up with multiple versions of windows-sys in our build pipeline but it should be a problem since the compile time of windows-sys is fast (faster or equal to winapi crate). It would be awesome if wry could also use windows-sys.

Is it worth opening an issue in windows-rs to request #[implement] macro that uses windows-sys types instead of windows? I can only imagine that manually implementing the COM interfaces of Webview2 is a lot of work to do.

There are some COM interfaces implemented in tao and wry as well, particularly around drag-drop support. IIRC, the only interface in webview2-com that is implemented by hand is the environment options interface, almost everything else uses webview2-com-macros to generate boilerplate implementations on top of the windows-macros/windows-implement #[implement] macro for callback interfaces. So if #[implement] were supported with windows-sys (or maybe something like #[implement-sys]), it should be possible to convert everything in webview2-com.
However, post 0.30.0, the #[implement] macro depends on the implement feature in windows and the windows-bindgen crates. It adds more generated code for all of the interface implementation traits (and that's what depends on new features that are only available as of 1.61, and that's why we can't update to 0.34.0 until that version of rustc is available...). Given what I know about how #[implement] works, I suspect adding it on top of windows-sys would add enough code and slow it down almost as much as just using windows, and it would still be harder to consume without the parameter conversion helpers.
It doesn't hurt to ask, the windows crate owners know their code a lot better than I do. But I wouldn't get my hopes up too high that they'll want to invest in that if it doesn't pay off like I suspect.

There are some COM interfaces implemented in tao and wry as well, particularly around drag-drop support.

Correct. ITaskbarList, ITaskbarList2 and IDropTarget. Manually defining those is not a big deal tbh considering how small they are.

Given what I know about how #[implement] works, I suspect adding it on top of windows-sys would add enough code and slow it down almost as much as just using windows, and it would still be harder to consume without the parameter conversion helpers.
It doesn't hurt to ask, the windows crate owners know their code a lot better than I do. But I wouldn't get my hopes up too high that they'll want to invest in that if it doesn't pay off like I suspect.

Alright. As always we appreciate your help.


Converting string "false" to bool value

In BQL, string "false" is converted to bool true like JavaScript.

https://godoc.org/gopkg.in/sensorbee/sensorbee.v0/data#ToBool

I think this specification is not user-friendly when using BQL.
My idea is the following:
ToBool(value String) returns false if value is empty or "false".
How about this idea?

https://github.com/sensorbee/sensorbee/issues/84
Yes, we actually think so, too. In that case, however, I'm still not sure whether a non-empty string should be converted to true or false. We should probably follow common semantics that major databases support.

Thanks.
duplicate of #84. I close this.


Add pubsub JSON RPC methods

Please implement this pallet https://github.com/airalab/robonomics/blob/master/protocol/src/pubsub/pubsubapi.rs#L27

https://github.com/Multi-Agent-io/robonomics-interface/pull/67


Error with 'import' and 'export'

This is the error I get:
'import' and 'export' may appear only with 'sourceType: module' (1:0) SyntaxError
I am trying to use this plugin in my repo promisify-dom-selector, I am guessing the error comes with it not  liking the keywords import and export, which I don't transpile because of rollup.
Is this what it's happening?

Hm, interesting. Sorry about that.
I don't see that your repo is using this plugin? I'll try to clone your repo and install, and we'll see.

Yea, strangely fails. I found this issue https://github.com/facebook/prepack/issues/823, so please follow it and make some changes. This one too https://github.com/facebook/prepack/issues/454.
Probably one thing that you can try is to install exact 0.2.0 version of prepack in your project, so this plugin will use it instead.

Okey, seems related to #9, so i'll make that change and bump in major.

Hey thanks for the help!
Yes I was just trying that out, I know it's useless with very small libraries :)

Thanks to you too, because that made me consider the #9 is correct issue. :)


login admin panel

when entering the admin panel and typing in the menu, always ask to log in again which part should I fix?

@deriswan Maybe you have error with sessions in your browser. Try with another browser. I will wait for your answer

I downloaded the product and I tried to install it on direct hosting but still when the login is logged it can't be clicked and keeps asking for login. Please instructions to be able to fix it, thank you

@deriswan GIve me a link. If you try with another browser are you still have this problem?

kirilkirkov hie , +263 73 427 2264 can you app there


Draft migration to Nuxt 3 - not ready yet

Fixes

Fixes #[issue number] by @[issue author]
Description

This is still WIP. You can run the app locally using jf dev:only. Note: don't run jf dev because that would download the locales which have some illegal keys, i.e. {creator-name} instead of {creatorName} which are not caught and converted for some reason. These keys break the build.
It mostly works. Things that don't:
The mobile content switcher modal (the menu button) causes a warning about using runtime directives on a non-element, and is slow.
Testing does not work. The Playwright build fails with:
 ✔ Container frontend-playwright-1  Recreated                                                                                0.1s
Attaching to playwright-1
playwright-1  |
playwright-1  | ><EMAIL_ADDRESS>test:playwright:local /frontend
playwright-1  | > playwright test -c test/playwright
playwright-1  |
playwright-1  | 2023-12-21T14:41:00.164Z pw:webserver Starting WebServer process ./node_modules/.bin/npm-run-all -p -r talkback prod:playwright...
playwright-1  | 2023-12-21T14:41:00.171Z pw:webserver Process started
playwright-1  | 2023-12-21T14:41:00.171Z pw:webserver Waiting for availability...
playwright-1  | 2023-12-21T14:41:00.173Z pw:webserver Waiting 100ms
playwright-1  | 2023-12-21T14:41:00.275Z pw:webserver Waiting 250ms
playwright-1  | 2023-12-21T14:41:00.526Z pw:webserver Waiting 500ms
playwright-1  | [WebServer]
playwright-1  | ><EMAIL_ADDRESS>prod:playwright /frontend
playwright-1  | > pnpm i18n:copy-test-locales && pnpm prod
playwright-1  |
playwright-1  | [WebServer]
playwright-1  | ><EMAIL_ADDRESS>talkback /frontend
playwright-1  | > node ./test/proxy.js
playwright-1  |
playwright-1  | 2023-12-21T14:41:01.030Z pw:webserver Waiting 1000ms
playwright-1  | [WebServer]
playwright-1  | ><EMAIL_ADDRESS>i18n:copy-test-locales /frontend
playwright-1  | > cp -r test/locales/* src/locales/
playwright-1  |
playwright-1  | [WebServer]
playwright-1  | ><EMAIL_ADDRESS>prod /frontend
playwright-1  | > pnpm build:only && pnpm start
playwright-1  |
playwright-1  | [WebServer]
playwright-1  | ><EMAIL_ADDRESS>build:only /frontend
playwright-1  | > nuxt build
playwright-1  |
playwright-1  | 2023-12-21T14:41:02.032Z pw:webserver Waiting 1000ms
playwright-1  | [WebServer] Nuxt 3.8.2 with Nitro 2.8.1
playwright-1  | 2023-12-21T14:41:03.034Z pw:webserver Waiting 1000ms
playwright-1  | [WebServer]
playwright-1  |  ERROR  Cannot find module @rollup/rollup-linux-arm64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try npm i again after removing both package-lock.json and node_modules directory.
playwright-1  |
playwright-1  |   at requireWithFriendlyError (/node_modules/.pnpm/rollup@4.8.0/node_modules/rollup/dist/native.js:87:9)
playwright-1  |   at Object.<anonymous> (/node_modules/.pnpm/rollup@4.8.0/node_modules/rollup/dist/native.js:96:48)
playwright-1  |   at Module._compile (node:internal/modules/cjs/loader:1376:14)
playwright-1  |   at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
playwright-1  |   at Module.load (node:internal/modules/cjs/loader:1207:32)
playwright-1  |   at Module._load (node:internal/modules/cjs/loader:1023:12)
playwright-1  |   at cjsLoader (node:internal/modules/esm/translators:345:17)
playwright-1  |   at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:294:7)
playwright-1  |   at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
playwright-1  |   at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
playwright-1  |
playwright-1  |
playwright-1  | [WebServer]
playwright-1  |  ERROR  Cannot find module @rollup/rollup-linux-arm64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try npm i again after removing both package-lock.json and node_modules directory.

I tried to set up the nuxt/test-utils that use Vitest under the hood, but couldn't get the module mocking and wrapper components to work. There is also an error when i18n-t component is not recognized, so the tests for components that contain it (most do!) fail.
@sarayourfriend, do you have any idea on how we could fix the Playwright build?
By the way, I replaced the tsconfig.base with the tsconfig that's generated by Nuxt because it generates some paths for the #app and #imports. If we extend the base config using another tsconfig with paths property, those get overwritten.
Testing Instructions

Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

By the way, I replaced the tsconfig.base with the tsconfig that's generated by Nuxt because it generates some paths for the #app and #imports. If we extend the base config using another tsconfig with paths property, those get overwritten.

This is my least favourite decision from Nuxt 3 (along with implicit imports, which the generated tsconfig also is meant to support), but I need to look more into how people are dealing with this in a monorepo setting. It's baffling to me that this works for people, it's so much dependency on the build to generate a valid TypeScript configuration, which feels backwards to me in every single way.
I'll review this PR today and see if I can understand the issue inside the playright container. Off the top of my head, I'm wondering if I'll even run into this because I'm not running an ARM CPU. Just based on the name of the package that can't be loaded, my first hunch is that it's something related to arm64 vs amd64 Docker (but who knows!)

@obulat Have you tried this, by any chance? https://github.com/vitejs/vite/issues/15167

Okay WOW the build is SO FAST :exploding_head:

Just copying out the warnings I'm seeing locally in case they aren't known yet:
[1:23:14 pm]  WARN  Plugin /var/home/sara/projects/openverse/frontend/src/plugins/polyfills.client.ts has no default export and will be ignored at build time. Add export default defineNuxtPlugin(() => {}) to your plugin.

[1:23:14 pm]  WARN  Plugin /var/home/sara/projects/openverse/frontend/src/plugins/focus-visible.client.ts has no default export and will be ignored at build time. Add export default defineNuxtPlugin(() => {}) to your plugin.

 WARN  files in the public directory are served at the root path.                                                           1:23:15 pm
Instead of /public/svg/sprite/icons.svg, use /svg/sprite/icons.svg.

 WARN  files in the public directory are served at the root path.                                                           1:23:15 pm
Instead of /public/svg/sprite/images.svg, use /svg/sprite/images.svg.

 WARN  Assets in public directory cannot be imported from JavaScript.                                                       1:23:18 pm
If you intend to import that asset, put the file in the src directory, and use /src/svg/sprite/images.svg instead of /public/svg/sprite/images.svg.
If you intend to use the URL of that asset, use /svg/sprite/images.svg?url.

 WARN  Assets in public directory cannot be imported from JavaScript.                                                       1:23:18 pm
If you intend to import that asset, put the file in the src directory, and use /src/svg/sprite/icons.svg instead of /public/svg/sprite/icons.svg.
If you intend to use the URL of that asset, use /svg/sprite/icons.svg?url.

I get a totally different issue running Playwright locally:
^C%                                                                                ➜  openverse git:(update/nuxt3_Dec18) just p frontend test:playwright
pnpm --filter frontend run test:playwright

><EMAIL_ADDRESS>test:playwright /var/home/sara/projects/openverse/frontend
> ./bin/playwright.sh

><EMAIL_ADDRESS>i18n:get-translations /var/home/sara/projects/openverse/frontend
> node src/locales/scripts/get-translations "--en-only"

Successfully saved English translation to en.json.
Running Playwright v1.40.1 as 1000 with Playwright arguments  under package manager<EMAIL_ADDRESS>[+] Building 108.9s (10/11)                                                                                docker:default
 => [playwright internal] load build definition from Dockerfile.playwright                                                         0.0s
 => => transferring dockerfile: 437B                                                                                0.0s
 => [playwright internal] load .dockerignore                                                                                0.0s
 => => transferring context: 490B                                                                                0.0s
 => [playwright] resolve image config for docker.io/docker/dockerfile:1                                                            3.1s
 => CACHED [playwright] docker-image://docker.io/docker/dockerfile:1@sha256:ac85f380a63b13dfcefa89046420e1781752bab202122f8f50032  0.0s
 => [playwright internal] load metadata for mcr.microsoft.com/playwright:v1.40.1-jammy                                             0.7s
 => [playwright internal] load build context                                                                                0.0s
 => => transferring context: 6.18kB                                                                                0.0s
 => [playwright 1/5] FROM mcr.microsoft.com/playwright:v1.40.1-jammy@sha256:1aba528f5db4f4c130653ed1de737ddc1d276197cc4503d3bb79  59.8s
 => => resolve mcr.microsoft.com/playwright:v1.40.1-jammy@sha256:1aba528f5db4f4c130653ed1de737ddc1d276197cc4503d3bb7903a93b7fb32e  0.0s
 => => sha256:1aba528f5db4f4c130653ed1de737ddc1d276197cc4503d3bb7903a93b7fb32e 743B / 743B                                         0.0s
 => => sha256:bdcf736240e565a7596b1dfe9b10fe4c9c7644268d2fd03c26214c8d9e00a325 1.17kB / 1.17kB                                     0.0s
 => => sha256:9a9296d96520ae634880855db01708cdcf5ad6e04dac988651b452e97736ca9c 4.28kB / 4.28kB                                     0.0s
 => => sha256:43f89b94cd7df92a2f7e565b8fb1b7f502eff2cd225508cbd7ea2d36a9a3a601 30.44MB / 30.44MB                                  32.5s
 => => sha256:4f114e38a0a97bee1291a9a6795ac4ae3afb097f293624e83581cd760a78bfe6 88.67MB / 88.67MB                                  11.5s
 => => sha256:f76ba5545dab67c3f5db70de1c9e7a648ff609d0e5c66a36276036208e435142 1.80MB / 1.80MB                                     1.9s
 => => sha256:9aef38e1b9647496e0f781f1f1356433e0411f1a15cda8ada86732dcb5dfd449 576.33MB / 576.33MB                                53.6s
 => => extracting sha256:43f89b94cd7df92a2f7e565b8fb1b7f502eff2cd225508cbd7ea2d36a9a3a601                                          0.4s
 => => extracting sha256:4f114e38a0a97bee1291a9a6795ac4ae3afb097f293624e83581cd760a78bfe6                                          1.4s
 => => extracting sha256:f76ba5545dab67c3f5db70de1c9e7a648ff609d0e5c66a36276036208e435142                                          0.0s
 => => extracting sha256:9aef38e1b9647496e0f781f1f1356433e0411f1a15cda8ada86732dcb5dfd449                                          6.0s
 => [playwright 2/5] COPY package.json .                                                                                2.4s
 => [playwright 3/5] RUN npm install -g<EMAIL_ADDRESS>                                                                               1.9s
 => ERROR [playwright 4/5] RUN pnpm install                                                                                40.8s
------
 > [playwright 4/5] RUN pnpm install:
0.708 Progress: resolved 1, reused 0, downloaded 0, added 0
0.724
0.724    ╭──────────────────────────────────────────────────────────────────╮
0.724    │                                                                  │
0.724    │                Update available! 8.3.1 → 8.12.1.                 │
0.724    │   Changelog: https://github.com/pnpm/pnpm/releases/tag/v8.12.1   │
0.724    │                Run "pnpm add -g pnpm" to update.                 │
0.724    │                                                                  │
0.724    │      Follow @pnpmjs for updates: https://twitter.com/pnpmjs      │
0.724    │                                                                  │
0.724    ╰──────────────────────────────────────────────────────────────────╯
0.724
1.710 Progress: resolved 3, reused 0, downloaded 2, added 0
2.711 Progress: resolved 8, reused 0, downloaded 5, added 0
3.711 Progress: resolved 26, reused 0, downloaded 19, added 0
4.710 Progress: resolved 47, reused 0, downloaded 39, added 0
5.712 Progress: resolved 59, reused 0, downloaded 55, added 0
6.712 Progress: resolved 71, reused 0, downloaded 69, added 0
7.168  WARN  deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
7.712 Progress: resolved 103, reused 0, downloaded 98, added 0
8.713 Progress: resolved 127, reused 0, downloaded 120, added 0
9.714 Progress: resolved 142, reused 0, downloaded 137, added 0
10.71 Progress: resolved 165, reused 0, downloaded 158, added 0
11.72 Progress: resolved 182, reused 0, downloaded 171, added 0
12.72 Progress: resolved 231, reused 0, downloaded 219, added 0
13.72 Progress: resolved 267, reused 0, downloaded 251, added 0
14.72 Progress: resolved 322, reused 0, downloaded 304, added 0
15.72 Progress: resolved 339, reused 0, downloaded 319, added 0
16.72 Progress: resolved 383, reused 0, downloaded 352, added 0
17.72 Progress: resolved 415, reused 0, downloaded 390, added 0
18.72 Progress: resolved 430, reused 0, downloaded 403, added 0
19.72 Progress: resolved 491, reused 0, downloaded 458, added 0
20.72 Progress: resolved 505, reused 0, downloaded 475, added 0
21.72 Progress: resolved 538, reused 0, downloaded 500, added 0
22.72 Progress: resolved 608, reused 0, downloaded 571, added 0
23.72 Progress: resolved 632, reused 0, downloaded 592, added 0
24.72 Progress: resolved 654, reused 0, downloaded 597, added 0
25.72 Progress: resolved 693, reused 0, downloaded 620, added 0
26.72 Progress: resolved 756, reused 0, downloaded 675, added 0
27.72 Progress: resolved 814, reused 0, downloaded 730, added 0
28.72 Progress: resolved 858, reused 0, downloaded 771, added 0
29.72 Progress: resolved 914, reused 0, downloaded 827, added 0
30.72 Progress: resolved 946, reused 0, downloaded 856, added 0
31.72 Progress: resolved 1038, reused 0, downloaded 941, added 0
32.72 Progress: resolved 1101, reused 0, downloaded 1001, added 0
33.72 Progress: resolved 1130, reused 0, downloaded 1029, added 0
34.72 Progress: resolved 1214, reused 0, downloaded 1074, added 0
35.72 Progress: resolved 1294, reused 0, downloaded 1147, added 0
36.72 Progress: resolved 1333, reused 0, downloaded 1249, added 0
37.40 Packages: +1306
37.40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
37.72 Progress: resolved 1356, reused 0, downloaded 1289, added 0
37.73 Packages are cloned from the content-addressable store to the virtual store.
37.73   Content-addressable store is at: /root/.local/share/pnpm/store/v3
37.73   Virtual store is at:             node_modules/.pnpm
38.72 Progress: resolved 1356, reused 0, downloaded 1290, added 1223
39.02<EMAIL_ADDRESS>postinstall$ node -e "try{require('./postinstall')}catch(e){}"
39.03 .../@intlify/vue-i18n-bridge postinstall$ node ./scripts/postinstall.js
39.03 .../node_modules/vue-demi postinstall$ node ./scripts/postinstall.js
39.05<EMAIL_ADDRESS>postinstall: Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
39.05<EMAIL_ADDRESS>postinstall: The project needs your help! Please consider supporting core-js:
39.05<EMAIL_ADDRESS>postinstall: > https://opencollective.com/core-js
39.05<EMAIL_ADDRESS>postinstall: > https://patreon.com/zloirock
39.05<EMAIL_ADDRESS>postinstall: > https://boosty.to/zloirock
39.05<EMAIL_ADDRESS>postinstall: > bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz
39.05<EMAIL_ADDRESS>postinstall: I highly recommend reading this: https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md
39.05<EMAIL_ADDRESS>postinstall: Done
39.08 .../@intlify/vue-i18n-bridge postinstall: [vue-i18n-bridge]  start vue-i18n-bridge postinstall script
39.14 .../@intlify/vue-i18n-bridge postinstall: Done
39.14 .../node_modules/vue-demi postinstall: Done
39.31<EMAIL_ADDRESS>postinstall$ node install.js
39.31 .../@intlify/vue-router-bridge postinstall$ node ./scripts/postinstall.js
39.32<EMAIL_ADDRESS>postinstall$ node install.js
39.36<EMAIL_ADDRESS>postinstall: Done
39.37<EMAIL_ADDRESS>postinstall: Done
39.40 .../@intlify/vue-router-bridge postinstall: Done
39.76 Progress: resolved 1356, reused 0, downloaded 1290, added 1306, done
40.18
40.18 ><EMAIL_ADDRESS>postinstall /
40.18 > pnpm i18n:copy-test-locales && npx nuxi prepare
40.18
40.47
40.47 ><EMAIL_ADDRESS>i18n:copy-test-locales /
40.47 > cp -r test/locales/* src/locales/
40.47
40.47 cp: cannot stat 'test/locales/*': No such file or directory
40.48  ELIFECYCLE  Command failed with exit code 1.
40.49  ELIFECYCLE  Command failed with exit code 1.
------
failed to solve: process "/bin/sh -c pnpm install" did not complete successfully: exit code: 1
/var/home/sara/projects/openverse/frontend:

Looking into it now.

Okay, I've got playwright running locally (tests fail though). Took a lot of fiddling and debugging stuff.

ESLint configuration is fixed in the latest commit too now :slightly_smiling_face:

Closing this in lieu of #3646


French not treated as possible language for character 'â'

Hello !
Look at this example : the result should be Language.FRENCH without any doubt, but it's Language.UNKNOWN :
LanguageDetector detector = LanguageDetectorBuilder.fromLanguages(Language.ENGLISH, Language.FRENCH).build();
Language detectedLanguage = detector.detectLanguageOf("Découverte du château grâce à l'application visite virtuelle");
assertEquals(Language.FRENCH, detectedLanguage);

Expected :FRENCH
Actual   :UNKNOWN

Thank you for this report, @bdecarne. This is actually a bug in the rule-based filter engine which is supposed to classify the character â as a possible indicator for French. Unfortunately, I missed to include French as a possible language for this character. This is easy to fix and I will do that soon.

Nice ! Thank you very much !


[Bug]: When using Ray as the inference backend for Qwen2-VL, there are issues with the inference results.

Your current environment

The output of `python collect_env.py`
Your output of `python collect_env.py` here

Model Input Dumps
No response
🐛 Describe the bug
使用下面代码初始化VLLM后，推理结果出现截断或者重复的问题，模型用的是Qwen2-VL-7B-Instruct
model = LLM(
        model=generate_config.model_dir,
        dtype="auto",
        trust_remote_code=True,
        gpu_memory_utilization=generate_config.gpu_memory_utilization,
        max_num_batched_tokens=generate_config.max_num_batched_tokens,
        max_num_seqs=generate_config.max_num_seqs,
        tensor_parallel_size=generate_config.tensor_parallel_size,
        enable_prefix_caching=generate_config.enable_prefix_caching,
        max_model_len=generate_config.max_model_len,
        distributed_executor_backend="ray",
    )

当我不改变任何代码，仅注释 distributed_executor_backend="ray"后，推理结果恢复正常
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Similar to https://github.com/vllm-project/vllm/issues/10627
@ywang96 Do you think this may be related to chunked prefill?

that would be surprising. can you provide a reproducible script, with detailed environment info and input?

+1, this will need some repro script.

+1，这将需要一些复制脚本。

Sorry for the delay, I was caught up with other matters. We have identified the cause of the issue. It is because our project attempts to submit the driver worker to Ray for remote execution in the vllm source code. This allows us to enable TP>1 and DP>1 across multiple machines simultaneously. This method does not cause inference result issues on LLM, but it results in abnormal inference outcomes on multimodal models. We observed that the driver worker is mainly responsible for data distribution, sampling, and other operations, but we do not understand why there are different results on LLM and LVLM.

+1，这将需要一些复制脚本。
Sorry for the delay, I was caught up with other matters. We have identified the cause of the issue. It is because our project attempts to submit the driver worker to Ray for remote execution in the vllm source code. This allows us to enable TP>1 and DP>1 across multiple machines simultaneously. This method does not cause inference result issues on LLM, but it results in abnormal inference outcomes on multimodal models. We observed that the driver worker is mainly responsible for data distribution, sampling, and other operations, but we do not understand why there are different results on LLM and LVLM.

Thanks for the reply @my17th2 . A few clarifying questions:

our project attempts to submit the driver worker to Ray for remote execution in the vllm source code.

Did you mean your project runs vLLM driver as a Ray worker? And there are multiple such instances, each instance with TP>1? What happens if there is only one instance (i.e., one vLLM driver as Ray worker), do you still see the same problem?

Thanks for the reply @my17th2 . A few clarifying questions:

our project attempts to submit the driver worker to Ray for remote execution in the vllm source code.

Did you mean your project runs vLLM driver as a Ray worker? And there are multiple such instances, each instance with TP>1? What happens if there is only one instance (i.e., one vLLM driver as Ray worker), do you still see the same problem?

The current logic of vLLM is that within the resources allocated to each vLLM instance, the first GPU acts as a driver worker and runs locally, while the others are submitted to Ray for execution. In my project, I've also placed the driver worker on Ray, allowing for the creation of vLLM instances in a multi-machine environment. However, I'm encountering the issues I mentioned earlier. I've tried different combinations, such as single machine single GPU, multi-machine with dp=1 and tp=world_size, and multi-machine with dp>1 and tp>1, etc. In all these scenarios with qwen2vl, I'm experiencing repeated or truncated inference outputs.

Thanks for the reply @my17th2 . A few clarifying questions:

our project attempts to submit the driver worker to Ray for remote execution in the vllm source code.

Did you mean your project runs vLLM driver as a Ray worker? And there are multiple such instances, each instance with TP>1? What happens if there is only one instance (i.e., one vLLM driver as Ray worker), do you still see the same problem?

The current logic of vLLM is that within the resources allocated to each vLLM instance, the first GPU acts as a driver worker and runs locally, while the others are submitted to Ray for execution. In my project, I've also placed the driver worker on Ray, allowing for the creation of vLLM instances in a multi-machine environment. However, I'm encountering the issues I mentioned earlier. I've tried different combinations, such as single machine single GPU, multi-machine with dp=1 and tp=world_size, and multi-machine with dp>1 and tp>1, etc. In all these scenarios with qwen2vl, I'm experiencing repeated or truncated inference outputs.

Is it possible to provide a repro script so that we can debug it?


No error thrown upon fail when using schema-creation tool

I'm trying to find the reason why the command line utility vendor/bin/doctrine orm:schema-tool:drop as well as update throws an ERROR: application encountered an error and can not continue. Unable to log error.
This error message seems to be generated by this line in Tracy/Debugger due to a non-set catchable error $e (correct me if I'm wrong) and the unhelpful message is rather frustrating.
drop and update have worked like a charm before I had to reinstall my OS and there's probably just  some false assumption in my configuration of the Entity Manager (which works otherwise), but when there's no error information, the search is a mess.
Therefore: Any guesses where the interaction between doctrine and Tracy fails? Can we improve error reporting for the Command Line Tools?

No clue what tracy is nor does, but the standard CLI from doctrine has a verbosity flag that can be used via -vvv.
Closing as invalid - please report this on tracy instead.

Thanks, you sent me in the right direction! And sorry for the inconvenience.
I was under the false impression that Doctrine internally was using Tracy, since the error message was rather unique to Tracy (according to google) and, yes, I found I still had it enabled on my local server.
After running the schema tool with the verbosity flag my bug became plain obvious.

https://www.youtube.com/watch?v=4QWfrxYt9DQ


Enigma

[ENIGMA] Stubs for missed API

-1
default interface methods already throw NotYetImplementedForExchangeException
changing this behavior to returning null is way worse


chore(package): update sinon to version 2.1.0

Closes #8
https://greenkeeper.io/

Coverage remained the same at 100.0% when pulling 6aae6d55b7a0188449e03129527309f6104453c3 on greenkeeper/sinon-2.1.0 into 7254786b7daf0bfa6534ab3da367569718cad1b2 on master.


Pass IFileSystem into FileWrapper instead of FileSystem

This will allow replacement file systems to be used and is the same pattern used in all the other classes.

Good catch, thanks!

Fixed in https://www.nuget.org/packages/System.IO.Abstractions/3.0.10


Can't define 2 different example responses

Describe the bug
The API I am building can respond with plain text or json depending on a query parameter and or the content-type in the request headers. So I want swagger to show the 2 different type of responses and the look of them.
When defining 2 @Success responses only the last one will be shown in swagger when you switch between the 2 Response content types in swagger UI nothing changes and the "string" example will always show.

To Reproduce
Create an example with this as an API Controller
// @Produce  json
// @Produce  plain
// @Success 200 {object} someStruct json
// @Success 200 {string} plain string

Expected behavior
2 different example responses are visible in Swagger and will show depending on the content-type.

Maybe use a struct.

Yes that would probably solve it, but makes no sense if you think about the HTTP Spec. Both responses are 200 and just differ in the content.

It's difficult.
I think  can't it due to spec format.
      responses:
        "200":
          description: OK
          schema:
            $ref: '#/definitions/model.Account'
            type: object

@pei0804 can we get this reopened? It's not that difficult and is clearly supported by the openAPI spec: https://swagger.io/docs/specification/describing-responses/


Basic block splitting

I think it would be best to merge #21 first.
To fix #5, I had to split the basic blocks around stackmap calls (this seemed to prevent loads from being moved around).
I realized late optimizations were removing some of the br instructions generated by the splitting. This branch fixes the problem by introducing a separate pass that splits the basic blocks. This pass runs later than all other passes, so its effects won't be optimized away.

Before I look at the code, did you try using an empty volatile asm block as a compiler barrier? This is a trick I've seen used recently.

@vext01 Hah, I tried that yesterday, but for some reason I decided to create this new pass. I tried it again just now to justify my decision to implement all this, and it seems like two empty asm blocks are sufficient. I'll get rid of the useless functionality and ping you when this is ready for review.

@vext01 This should be ready for review now.

Oh, great! It worked! Reviewing shortly.

LGTM. Squash?

@vext01 Done.


The Xiaomi MI Play cost more than 1:30 to call ModifyGraphWithDelegate for face_detection_short_range.tflite

/mediapipe/calculators/tensor/inference_calcultor-gl.cc->LoadDelegate(CalculatorContext* cc)
RET_CHECK_EQ(interpreter_->ModifyGraphWithDelegate(delegate_.get()),kTfLiteOk);

OS Platform : Android 8.1.0
Mobile device: xiaomi Mi play
Soc: MTK P35
Programming Language: C++

Bazel version (if compiling from source):
Solution:FaceMesh

Hi @chenkecheng, Could you please elaborate your issue with complete details. Thanks!


Update aiocoap install script to use master branch

The dtls branch of aiocoap has been merged into master. We should update our installation scripts to use the master branch (or pip if a new release gets pushed to PyPi)

#57


cant use external file

I am getting the exception AttributeError: 'dict' object has no attribute 'startswith' despite passing a string:
file_dir = path.dirname(path.abspath(__file__))
schema_path = path.join(file_dir, "openapi.yaml")
schema = Path(schema_path)

@app.route("/ingestion-job", methods=["GET", "POST"])
@swag_from(schema, endpoint="ingestion-job", methods=["POST"], validation=True)
def ingestion_root():
    if request.method == "POST":
        manifest = request.json

...

Leads to:
[2021-05-24 09:21:50,640] [dataapi.def_controller] [DEBUG   ] Rebuilding cache from git using profile: None
[2021-05-24 09:21:50,652] [dataapi.def_controller] [DEBUG   ] Cached 1 ingestion jobs
[2021-05-24 09:21:50,895] [dataapi.app ] [ERROR   ] Exception on /ingestion-job [POST]
Traceback (most recent call last):
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flask/app.py", line 2070, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flask/app.py", line 1515, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flask/app.py", line 1513, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flask/app.py", line 1499, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flasgger/utils.py", line 266, in wrapper
    validate(
  File "/Users/tommycarpenter/Development/python-data-ingestion-api/.tox/py39/lib/python3.9/site-packages/flasgger/utils.py", line 382, in validate
    if not filepath.startswith('/'):
AttributeError: 'dict' object has no attribute 'startswith'

It is unclear why filepath would be of instance dict here

flasgger==0.9.5
Python 3.9.5
same issue with this usage:-
from flasgger import Swagger
....
swagger = Swagger(app)

specs.yaml is in local and declaration goes like this
                def get(self, x):
                """
		file: specs.yaml
		"""

Error
  File "/usr/local/lib/python3.9/site-packages/flasgger/utils.py", line 546, in load_from_file
    enc = detect_by_bom(swag_path)
  File "/usr/local/lib/python3.9/site-packages/flasgger/utils.py", line 575, in detect_by_bom
    with open(path, 'rb') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.9/site-packages/flask_restful/specs.yaml'

Same problem as reported by OP.
This a bug with flasgger if my analysis below is correct.
The problem is happening in utils.py/validate.  'filepath' is of different type depending on the KWarguments to @swag_from().  If you specify validate=True AND methods specified at all, then this will fail.  'filepath' comes in as a dict:
example:
{'put': '/u/itsme/a/b/c/web_server/swagger.yml'}

if methods kwarg is not specified, then filepath comes in as a string.
I believe @ischyron is reporting a different issue.


machinepool: Allow managing 'default' machinepool

Since we have the machinery for managing machinepools, we can scale the
cluster itself using this resource and so remove the scaling options on
'edit cluster'.

Don't we have code in OCM enforcing the minimum nodes in the default worker pool?  That will continue to be enforced even if we allow the pool to be edited, right?

@jeremyeder correct:
$ rosa edit machinepool -c vkareh-rosa default --replicas=1
E: Failed to update machine pool 'default' on cluster 'vkareh-rosa': Invalid number of compute nodes: 1. Minimal requirement is 2 compute nodes.

/retest


Option to use SQLite instead of Postgres in Prisma

Convert Enums to Strings. Instead define them manually using TS. Cast types in trpc package.
SQLite introduced recently JSONB type, so wait until Prisma will implement it https://github.com/drizzle-team/drizzle-orm/issues/1977

Regarding String -> Enum type conversion while using Prisma client https://github.com/prisma/prisma/discussions/11196


children method does not respond to empty?

children.empty?
Seems to be just the way ruby works?  perhaps there is a better way to define an enumerable?

I think there is no reason to stop us from adding empty? to React::Children

yeah I'm okay with that... but it seems odd.  Perhaps there is a different way to create an enumerable we should be using?  The reason I say that, is what else are we missing that we should be getting?

Ruby's Enumerable doesn't provide empty? method, it got something similar which is any?.


Non standard keyboard layout triggers login when toggling practice mode (rebirth)

lua/c++ detects practice using character
lua detects login using physical location DeviceButton_l
easy fix

this affects every devicebutton_ usage

#1274


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.4 to before v5.14.15",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e6d9c80b7ca1504411ad6d7acdb8683e4ae1c9cd",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0e5afdc2315b0737edcf55bede4ee1640d2d464d"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "e6d9c80b7ca1504411ad6d7acdb8683e4ae1c9cd",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "0e5afdc2315b0737edcf55bede4ee1640d2d464d",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "can: peak_pci: peak_pci_remove(): fix UAF\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.14.15 by commit 0e5afdc2315b0737edcf55bede4ee1640d2d464d, it was introduced in version v3.4 by commit e6d9c80b7ca1504411ad6d7acdb8683e4ae1c9cd. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002099


Token definitions in configuration yaml file

Hi,
More a question/discussion here, should we save the provider tokens in the config file ?
This could be a security risk if the config file is pushed to a public git repository.
Especially when we run the utility from the Git repository.

Hello @darknoon29
You don't have to store the token/secret in config file, you have two more options. You can store them as environment variable or pass it in command line as argument. See https://github.com/jasminsehic/PullRequestReleaseNotes/blob/master/docs/HELP.md for more info.

Yes i agree, maybe a warning in the documentation could be enough for the user. Lets keep the feature :-)


apple: Add VM_* constants from mach/vm_statistics.h

Closes #736.

@bors: r+

:pushpin: Commit eccc693 has been approved by alexcrichton

:hourglass: Testing commit eccc693ab3f7d05ac5e8feb15fb5da8cf25678ab with merge 2e976d7fa25565ee2453dd5e7288022106bfa226...

:broken_heart: Test failed - status-travis

@alexcrichton Any advice on what I should do about the errors that some of the constants don't exist in the version of libc that Travis is using? They exist in my laptop's copy of mach/vm_statistics.h.

Is a header missing? Or maybe Travis's version is too old? Can travis's version be newer?

My guess is that a header is missing, yeah. I'm not sure when those variables were added, but my vm_statistics.h lists the copyright as "2000-2016", so maybe if we get the 2016 version, we'd be OK. I'll look into whether that's possible with Travis.

OK, it looks like we're currently building with the Travis default of XCode 7.3 and OS X 10.11. The iOS builds, on the other hand, build with XCode 8.2 and OS X 10.12, and those tests pass. I'm going to bump the failing builds to XCode 8.3/OS X 10.12 (which is the latest stable version available) and see if that fixes it.

OK that worked.

:pushpin: Commit f8bfc6e has been approved by alexcrichton

@bors: r+

:hourglass: Testing commit f8bfc6eaa4a335e79fe9d962b9e5719b3853b2e1 with merge e102a7265104cc4ae7ddfe90f3dd4790456a5066...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e102a7265104cc4ae7ddfe90f3dd4790456a5066 to master...


Templates owned by Project Account not allowed to share templates

ISSUE TYPE

Bug Report

COMPONENT NAME

API

CLOUDSTACK VERSION

<IP_ADDRESS>
<IP_ADDRESS>

public boolean updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissionsCmd cmd) {

      <...>

        if (owner.getType() == Account.Type.PROJECT) {
            // Currently project owned templates cannot be shared outside project but is available to all users within project by default.
            throw new InvalidParameterValueException("Update template permissions is an invalid operation on template " + template.getName() +
                    ". Project owned templates cannot be shared outside template.");
        }

      <...>

SUMMARY

Templates owned by a project account are not allowed to exectute updateTemplatePermissions API.
This prevents projects from sharing templates between them selves that are in the same Domain as stated by the API docs.
It seems to indicate that only templates created by a users in the "admin" or other non-project group are allowed to mark templates shared outside of the project structure.
EXPECTED RESULTS

Allowing users in the same domain to share templates would seem to be an expected behavior.

Hi @damonb123
Could you please let me know what's role typer of the account

The account type  you created  (domain-admin , user, etc)

What is the project role type you selected , when adding account to the project

@weizhouapache @rohityadavcloud @harikrishna-patnala does it make sense to allow ROOT admin to change the owner of the templates using updateTemplate API?
Or should we allow project-owned templates to be shared outside the project?

This is by design, template registered in a project are owned by it so not accessible to others. However, like any account they should be allowed to be shared to others.

I added a simple change in #9196 . A domain admin can share with the PR at least. Normal users never own their own template in a project as it belongs to the project account. I am not sure if this is as intended, but it seems some extra work is needed.

@kiranchavala @rohityadavcloud @damonb123 , My take on this is that if the user has access to the template thay can adjust the sharing rights as well. I do not have clear yet if there should be some restrictions to what they can do, beyond what is programmatically possible at this moment. I.E. are restrictions and extra checks needed?

@damonb123 #9196 implements your request . as @vishesh92 shows in https://github.com/apache/cloudstack/pull/9196#issuecomment-2178872690 this is not much help yet for UI users but may help you if you want to share for use in the API. I will look at a furhter UI fix.

fixed in #9196


feat: change owner of event

change owner of an event

Codecov Report

Merging #268 (41d7e32) into develop (856c843) will decrease coverage by 0.26%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
- Coverage    99.06%   98.80%   -0.27%
===========================================
  Files           48       48
  Lines         2251     2259       +8
===========================================
+ Hits          2230     2232       +2
- Misses          21       27       +6

Impacted Files
Coverage Δ

app/routers/event.py
93.63% <25.00%> (-3.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c843...41d7e32. Read the comment docs.


@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I've added bot automerge as requested, but nothing actually changed.


bug: glob should fail if 0 files are returned?

If the test job fails to generate a report for some reason, and you're using a wildcard to glob for the report, this plugin will report success, even though 0 tests were reported.
I'd say it should fail if there are 0 files returned by the glob and/or 0 tests reported. I'd argue this should happen whether fail-build-on-error is set or not, but that's debatable.

Reviewed the code of the plugin and if the glob finds no artifacts the command will fail anyways.
So that leaves the other scenario: empty files or no run tests. Which means that this is a feature request for a "minimum amount of tests" to report about


Fix workdir when you call the list action twice

Hi !
First of all, great job ! This node is really useful !
I just fix a bug which occurs when you call the list action twice in a row, with 2 differents workdir , in this case the node re-use the first workdir forever.
Thanks in advance and have a great day !

Thank you!
Good catch. Same would happen with the file name. I will make changes and push to npm in a few minutes.


[LIBCLOUD-842] - Fix for AzureBlobStorage not allowing upload with 400 error (https://…

Fixes https://issues.apache.org/jira/browse/LIBCLOUD-842 AzureBlobStorage not allowing upload with 400 error
Description
Fix for AzureBlobStorage not allowing upload with 400 error (https://issues.apache.org/jira/browse/LIBCLOUD-842). The issue was created when a fix for "AWSRequestSignerAlgorithmV4" (https://github.com/apache/libcloud/commit/4bff0f076776e6d59945381c1e2969826131fc11) was added. This caused the heads "host" and "accept_encoding" to be removed from the requests to AzureBlobStorage. The Fix retains the current functionality and sets the headers on for Azure.
Status
Replace this: describe the PR status. Examples:

work done
tested using script provided on https://issues.apache.org/jira/browse/LIBCLOUD-842

Checklist (tick everything that applies)

[X] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

…issues.apache.org/jira/browse/LIBCLOUD-842). The issue was created when a fix for "AWSRequestSignerAlgorithmV4" (https://github.com/apache/libcloud/commit/4bff0f076776e6d59945381c1e2969826131fc11) was added. This caused the heads "host" and "accept_encoding" to be removed from the requests to AzureBlobStorage. The Fix retains the current functionality and sets the headers on for Azure.

thanks luke. I'm not sure why the attributes need to be declared in both the driver and the connection class?

@tonybaloney I only see two changes. One within libcloud/common/azure.py and one within libcloud/common/base.py.
The change within libcloud/common/base.py retains the existing functionality(which breaks AzureBlobStorage) and allows overriding which is set in libcloud/common/azure.py.
Please can you clarify where you are seeing any additional changes.
thanks
Luke

Hello,
Does anyone see any issues with this code?  Can someone review and merge if possible please.
thanks
Luke

no, all good. 👍

I'm having issues with the patch file. never happened before! @Kami  can you try and merge this one?
error: patch failed: libcloud/common/base.py:532
error: libcloud/common/base.py: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 Fix for AzureBlobStorage not allowing upload with 400 error (https://issues.apache.org/jira/browse/LIBCLOUD-842). The issue was created when a fix for "AWSRequestSignerAlgorithmV4" (https://github.com/apache/libcloud/commit/4bff0f076776e6d59945381c1e2969826131fc11) was added. This caused the heads "host" and "accept_encoding" to be removed from the requests to AzureBlobStorage. The Fix retains the current functionality and sets the headers on for Azure.

@tonybaloney  thanks for reviewing!

Any chance of getting this merged? We're currently running a locally hacked libcloud version to get around this problem.

nope, same merge issue. Did one of you force push a changeset or something? This is really strange.
Applying: Fix for AzureBlobStorage not allowing upload with 400 error (https://issues.apache.org/jira/browse/LIBCLOUD-842). The issue was created when a fix for "AWSRequestSignerAlgorithmV4" (https://github.com/apache/libcloud/commit/4bff0f076776e6d59945381c1e2969826131fc11) was added. This caused the heads "host" and "accept_encoding" to be removed from the requests to AzureBlobStorage. The Fix retains the current functionality and sets the headers on for Azure.
Using index info to reconstruct a base tree...
error: patch failed: libcloud/common/base.py:532
error: libcloud/common/base.py: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 Fix for AzureBlobStorage not allowing upload with 400 error (https://issues.apache.org/jira/browse/LIBCLOUD-842). The issue was created when a fix for "AWSRequestSignerAlgorithmV4" (https://github.com/apache/libcloud/commit/4bff0f076776e6d59945381c1e2969826131fc11) was added. This caused the heads "host" and "accept_encoding" to be removed from the requests to AzureBlobStorage. The Fix retains the current functionality and sets the headers on for Azure.
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@tonybaloney  Sorry for the delay. Will try and get this cleaned up and re submitted.

@tonybaloney Please can you review this.
I deleted my fork, forked from commit https://github.com/apache/libcloud/commit/6f9e428c51b53aa97ded4d1ed08fdf2d66d86aad and reapplied my fixes.
Kind regards,
Luke

@lmorfitt see the title says "	lmorfitt  wants to merge 2 commits into apache:trunk from unknown repository". that is really weird. I think GitHub has broken this PR or your original branch was deleted?
I've raised another duplicate PR to see if I can merge that one.

@lmorfitt OK I've figured it out by just cloning your fork and reading back through the log, so basically the commit ref that you created this after is part of a change that you didn't include in this. We apply patches using git am because all Apache git repo's are not hosted by GitHub, they are actually clones. Anyway. I'm assuming you don't want the Azure ARM driver that's in the git history of your trunk to be included in the PR and just the individual driver connection setting changes?

@tonybaloney Apologies for the delay getting back to you.
I'm a little confused on the process you are running with the apache repo's and github repo as a clone. So will try and explain what I did and why.
My understanding is as follows, please correct me if I am incorrect.
Originally you was unable to merge in this change due to my repo being in a mess.
I removed my messy repo, forked from the latest version at the time and re-applied my fixes, which as far as i can see are these two files. libcloud/common/azure.py libcloud/common/base.py, nothing else.
There is about 10 lines of changes in here total, some of which is Autopep8 to clean up.
Please can you clarify what you are seeing (maybe provide a diff) and I can review it.
Thank you for your assistance working through these issues,
Luke

Hello,
Any update on this please?
Since we seem to be at a standstill with this bug, I'm wondering if github is the correct way of providing a fix. If not please can you provide your prefered method and I will follow that.
thanks,
Luke

@lmorfitt I'm really sorry that we took this long to get back to you.
In April 2017 we released libcloud 2.0 that drops the dependency on httplib. We now use requests and as a result no longer set skip_host and skip_accept_encoding.
Unfortunately I don't have an Azure account so I can't check myself. Can you please tell us if that fixed your issue? Thanks!

Actually I now see that the code has been merged but the PR has not been closed. I can't do this myself. Can you please close this PR @lmorfitt? Thanks!


Bumping jgit to <IP_ADDRESS>810200350-r

Codecov Report

Merging #1179 into master will decrease coverage by 4.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
- Coverage     77.49%   73.37%   -4.13%
+ Complexity      948      125     -823
============================================
  Files           112       13      -99
  Lines          3373      462    -2911
  Branches        466       59     -407
============================================
- Hits           2614      339    -2275
+ Misses          589       95     -494
+ Partials        170       28     -142

Impacted Files
Coverage Δ
Complexity Δ

...nvironment/NativeEnvironmentRepositoryFactory.java

...rver/environment/EnvironmentNotFoundException.java

...pport/GitSkipSslValidationCredentialsProvider.java

...server/environment/VaultEnvironmentProperties.java

...nitor/GitlabPropertyPathNotificationExtractor.java

...onitor/GiteePropertyPathNotificationExtractor.java

...g/monitor/EnvironmentMonitorAutoConfiguration.java

...d/config/server/config/CompositeConfiguration.java

.../server/environment/JdbcEnvironmentRepository.java

...config/server/environment/RepositoryException.java

... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154e279...c58a2b3. Read the comment docs.


docs: add conventions to consider while development

This commits add some docs that are taken from docs that Kubernetes
upstream follows. This helps keep the spec of kedge consistent with
general conventions that community is trying to follow.
Inspired from: API Conventions

@surajssd Semaphore fails despite virtualbox being ran / correct minikube. Please ignore! It's an e2e issue.

@cdrage PTAL for review and :tada: tests pass on semaphore!

@cdrage thanks!


Add setting for custom .git path

My TypeScript app is part of a bigger git project and the .git folder is in the folder 3 levels above the folder that I want to have open in VSCode. It would be really nice to have a workspace setting that allowed me to specify a custom path to .git.

I also ran into this. The biggest issue with this is that VSCode needs the files in the workspace in order to be able to watch them.

I have added this option in v0.4.1

My TypeScript app is part of a bigger git project and the .git folder is in the folder 3 levels above the folder that I want to have open in VSCode. It would be really nice to have a workspace setting that allowed me to specify a custom path to .git.
This not work.


Track bundle sizes and include checks to prevent unexpected bundle size increases

This is on the v1.x roadmap.

Closed in #388 and #390.


How could I get the switcher and stepper's value in the example 4?

Hi~
I ask this is because of I got few cells with UITextField in it. The cell's initial value is populated with RxTableViewSectionedReloadDataSource.
I don't know how to get those changed text values except iterate all cells.
Please help. Thanks.

Don't you just subscribe to the rx values ?
For example:
textField.rx.text.skip(1).subscribe(onNext: { Your magic here }).addDisposableTo(cell.disposeBag)

In order to solve the problem of multiple invocation of the onNext block, look at: https://github.com/ReactiveX/RxSwift/issues/437

@denis631 Wow, This's very helpful. Thank you.


filters that are not active influence coloring

when we have multiple filters and some filter that occurs first is disabled, it's coloring is still used if a later filter matches

when the order is changed, it looks like this

this is still wrong since the filter matches still show

It isn't a bug, but expected behavior. Currently, we are applying colors of filters even filters aren't active.
So, I suggest creating another issue (feature request) with a description of expected behavior. I think there are should be some additional "flag" like visible/invisible to control applying of coloring.


[FLINK-4659]: Potential resource leak due to unclosed InputStream in SecurityContext#populateSystemSecurityProperties()

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[ ] General

The pull request references the related JIRA issue ([FLINK-4659]: Potential resource leak due to unclosed InputStream in SecurityContext#populateSystemSecurityProperties())

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[ ] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

The stream would still be unclosed in case of an exception, we should use a try-with-resource statement isntead.

Taking this over, fixing it, and merging it...


Library generating 256bit traceId

I deployed few services in a k8 cluster and was surprised to see that no traces were visible in jaeger. On checking app logs, I found that traceId being generated was 256 bits long like: "f397a1768f8a0e5a4955c4cdfeda67c3"
However, on an old cluster I have the same services deployed for which I am able to see traces in jaeger and which have 128 bit long trace Ids. For eg. "d64800f409abf213"
We checked all our network and infra configurations. All are the same for both services. Can a 256bit traceId be causing issue for jaeger?

cc @pavolloffay

Who is generating traceIds? The traceIds are max 128bit in jaeger.

The library itself is generating.

The library itself is generating.

I might be missing something here. What library do you mean? Jaeger java client?


termpdfpy is broken

Describe the bug
termpdfpy unable to run due to missing symbol:
$ termpdf.py test.pdf
Traceback (most recent call last):
  File "/nix/store/72fs82gv91m6d0119233lby6phms0bna-termpdf.py-2019-10-03/bin/.termpdf.py-wrapped", line 55, in <module>
    import fitz
  File "/nix/store/vys3h1vxw2ha9a7345w33q1p1rlslasv-python3.8-pymupdf-1.18.0/lib/python3.8/site-packages/fitz/__init__.py", line 3, in <module>
    from fitz.fitz import *
  File "/nix/store/vys3h1vxw2ha9a7345w33q1p1rlslasv-python3.8-pymupdf-1.18.0/lib/python3.8/site-packages/fitz/fitz.py", line 18, in <module>
    from . import _fitz
ImportError: /nix/store/vys3h1vxw2ha9a7345w33q1p1rlslasv-python3.8-pymupdf-1.18.0/lib/python3.8/site-packages/fitz/_fitz.cpython-38-x86_64-linux-gnu.so: undefined symbol: jpeg_resync_to_restart

It seems that others also faced this problem: PyMuPDF#609 but managed to fix it via running the installation script which contains a specific line patching the MuPDF source before compilation:
# replace files in mupdf source
cp ../PyMuPDF/fitz/_config.h include/mupdf/fitz/config.h

and it seems that there is no such modification here in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pymupdf/default.nix
I did not test this so I'm not sure if this is the cause of the problem, just trying to bring some relevant information.
To Reproduce
Steps to reproduce the behavior:

Install termpdfpy by nix-env -iA termpdfpy
Run it with any pdf: termpdf.py test.pdf
Check the error message

Expected behavior
Run successfully.
Additional context
Add any other context about the problem here.
Notify maintainers

@teto
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.119, NixOS, 20.09.4242.cee3ca37c68 (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.11`
 - channels(pca): `"home-manager-20.09, nixpkgs-20.09.4316.85ed11208f8, nixpkgs-unstable-21.11pre294396.3bc8e5cd23b"`
 - channels(root): `"nixos-20.09.4242.cee3ca37c68, nixpkgs-21.03pre243353.6d4b93323e7"`
 - nixpkgs: `/home/pca/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@pca006132  you seem to have a good grasp of the situation and I dont think I can fix this anytime soon so feel free to submit a patch and assign it to me.

@pca006132 you seem to have a good grasp of the situation and I dont think I can fix this anytime soon so feel free to submit a patch and assign it to me.

I tried fixing it this afternoon but I cannot fix it. Things I tried:

Patching the config.h file via adding command to postPatch: Same error message.
Adding HAVE_GLFW=no to makeFlags: Same error message.
Modifying makeFlags to flags used in the shell script mentioned above: Compilation error, cannot find some header files from third-party libraries.

No idea now.

a more minimal example:
nix-shell -p python39Packages.pymupdf --run 'python -c "import fitz"'
btw, be sure to try a more recent minor version. the current one is 1.18.14 and fixed a few bugs that might or might not be related.

Hi, I found the nixpkgs installed  .so file lost some library.
ldd result/lib/python3.9/site-packages/fitz/_fitz.cpython-39-x86_64-linux-gnu.so
        linux-vdso.so.1 (0x00007ffff597e000)
        libc.so.6 => /nix/store/cvr0kjg2q7z2wwhjblx6c73rv422k8cm-glibc-2.33-47/lib/libc.so.6 (0x00007fc9c8cf0000)
        /nix/store/j5p0j1w27aqdzncpw73k95byvhh5prw2-glibc-2.33-47/lib64/ld-linux-x86-64.so.2 (0x00007fc9cb1ed000)

Same time, I download a pymupdf package from archlinux repo found
ldd _fitz.cpython-39-x86_64-linux-gnu.so
        linux-vdso.so.1 (0x00007ffd673ea000)
        libjbig2dec.so.0 => not found
        libopenjp2.so.7 => not found
        libjpeg.so.8 => not found
        libfreetype.so.6 => not found
        libgumbo.so.1 => not found
        libpthread.so.0 => /nix/store/j5p0j1w27aqdzncpw73k95byvhh5prw2-glibc-2.33-47/lib/libpthread.so.0 (0x00007fcd96856000)
        libc.so.6 => /nix/store/j5p0j1w27aqdzncpw73k95byvhh5prw2-glibc-2.33-47/lib/libc.so.6 (0x00007fcd96691000)
        /nix/store/j5p0j1w27aqdzncpw73k95byvhh5prw2-glibc-2.33-47/lib64/ld-linux-x86-64.so.2 (0x00007fcd98ba8000)

Maybe our missing some dependencies linker.

the root reason is setup.py don't include nix support, so that swig don't add relativate libraries.

Now, this problem is solved.

I'm getting this same error in both unstable and 22.05. Are we sure this was fixed?

you would have to give better reproduction nstructions  nix run nixpkgs/nixos-unstable#termpdfpy runs fine. Have you checked nix-env -q ?


Is the hostname specified when connecting to the mail server reversible?

@felddy pointed out that it would be good to check that the hostname specified in the EHLO that is sent to the mail server be reversible when scanning from AWS Lambda.  This is the hostname specified as the local_hostname parameter in the smtplib.SMTP constructor.
Right now local_hostname is not specified, which means that the hostname is looked up locally.  AWS EC2 instances have default DNS entries of the form ec2-54-153-52-38.us-west-1.compute.amazonaws.com, and these are reversible, so this shouldn't be an issue.  It would still be good to double-check.
The easiest way to test this might be to run trustymail in AWS Lambda against @felddy's home mail server, since we know that it actively rejects connections from hosts it cannot reverse.

Now that we run the scans behind a NAT gateway, we explicitly set the local_hostname parameter to the FQDN corresponding to the EIP used by the NAT gateway.  Therefore the hostname is definitely reversible.


feat: remove web controller

Signed-off-by: Yukihiro Saito<EMAIL_ADDRESS>Description
https://github.com/orgs/autowarefoundation/discussions/3082

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukkysaito When will this PR be merged? I plan to introduce an option to not start rosbridge by default. https://github.com/autowarefoundation/autoware.universe/pull/2438

Depending on this one, I will merge it since there were no objections after a week.

@yukkysaito
Could you remove the following web_controller param from tier4/, awf/'s autoware_launch please.
https://github.com/autowarefoundation/autoware_launch/blob/ba52539bfdfca0ecf734510c95ccf12370705ec1/autoware_launch/launch/planning_simulator.launch.xml#L33


Rotate the Viewpoint around the picked point

[x] Rotate the Viewpoint around the picked point rather than around the object centers (cf. #498)
[x] Fix the broken MouseEvents.convertMouseEventPositionToScreenPosition() function.

👍

:eyes: