Persistent Notification on pausing playback

This is more of a question. Any help would be deeply appreciated.
The kotlin code is quite a bit simpler than its java equivalent for a number of reasons. One of the more interesting things that stood out to me was the notification behavior.
In the Java code, when pausing playback, the notification (and service) would be killed after a minute or so by the OS, especially on Oreo and above. This is the default behavior.
In the Kotlin version, even when pausing the playback, the notification stays intact for music to potentially resume in the future. The notification does not get killed by the OS. Also noticed that "setOngoing" is not called on the notification which relies on PlaybackState. How are we achieving this? Would it be because of the exoplayer mediasession extension?
How should be go about retaining the notification in the java version?
Thanks!

I haven't looked in awhile, so I'm going from memory/quickly looking over the code.
The service is stopped when the player is stopped/in the background because of the class DelayedStopHandler that's part of MusicService.
The notification is removed because it's asked to be removed in MusicService.onDestroy.
The notification doesn't need to have setOngoing set because when the service is in the foreground, it's ongoing by default, and cannot be swiped away. When it's paused, then it doesn't need that.
To get the notification to stick around, I'd start by trying to remove the call to mMediaNotificationManager.stopNotification(); in MusicService.onDestroy.
The complexity in the Java version is one of the reasons I decided to rewrite it completely in Kotlin, rather than porting it from the existing code or just updating parts of it. =(

I haven't looked in awhile, so I'm going from memory/quickly looking over the code.
The service is stopped when the player is stopped/in the background because of the class DelayedStopHandler that's part of MusicService.
The notification is removed because it's asked to be removed in MusicService.onDestroy.
The notification doesn't need to have setOngoing set because when the service is in the foreground, it's ongoing by default, and cannot be swiped away. When it's paused, then it doesn't need that.
To get the notification to stick around, I'd start by trying to remove the call to mMediaNotificationManager.stopNotification(); in MusicService.onDestroy.
The complexity in the Java version is one of the reasons I decided to rewrite it completely in Kotlin, rather than porting it from the existing code or just updating parts of it. =(

Hello, @nic0lette  .  I am also in such a situation: in Kotlin, the service could be kept still without being collected; however, in Java, this could not be achieved. How to make this? I tried to use Exoplayer mediasession extension, but failed.

I haven't looked in awhile, so I'm going from memory/quickly looking over the code.
The service is stopped when the player is stopped/in the background because of the class DelayedStopHandler that's part of MusicService.
The notification is removed because it's asked to be removed in MusicService.onDestroy.
The notification doesn't need to have setOngoing set because when the service is in the foreground, it's ongoing by default, and cannot be swiped away. When it's paused, then it doesn't need that.
To get the notification to stick around, I'd start by trying to remove the call to mMediaNotificationManager.stopNotification(); in MusicService.onDestroy.
The complexity in the Java version is one of the reasons I decided to rewrite it completely in Kotlin, rather than porting it from the existing code or just updating parts of it. =(

Hello, @nic0lette .  I am also in such a situation: in Kotlin, the service could be kept still without being collected; however, in Java, this could not be achieved. How to make this? I tried to use Exoplayer mediasession extension, but failed.

That is correct @nic0lette . Your suggestions don't quite seem to work for Java. As soon as you pause music, a minute after the notification is killed because the service is killed in the background. Kotlin seems to get around the issue nicely.
Wondering if you had any more thoughts. Thanks!

The way that notifications are handled has been refactored. Closing as obsolete.


Can't use multiple host-shell commands in a single source block

What did you expect to happen?
Running the following source block should execute both commands on the host
#+begin_src tmate :window kind
host-shell mkdir -p /root/go/src/k8s.io
host-shell chown -R 1000:1000 /root/go
#+end_src

What actually happened?
Only runs the first command. The following output happens with set -x
ii@heyste-humacs-0:~$ host-shell mkdir -p /root/go/src/k8s.io
+ host-shell mkdir -p /root/go/src/k8s.io
host-shell chown -R 1000:1000 /root/go
host-shell chown -R 1000:1000 /root/go

Getting the same result (2nd command fails) when trying to run a normal command in humacs


Keyboard events in the intro screen

The enter button in the intro screen should get fired if we press the enter button on our keyboard.

Fix it yourself.

Fix it yourself.

Ya😅 I was just asking if we are going to implement that or not

Fix it yourself.

Ya😅 I was just asking if we are going to implement that or not

Yes

i've dropped a pull request.


Update Email Address

My Amazon email address has changed recently, but I don't see a way to update this in the integration?

Never mind; I deleted, and re-added the integration.


Pipe answers to other questions

Start simple: with options questions. Pipe selected options of one questions to become options of another question.

Can I take this up @plutov

@anveshthakur sure, this one needs a good design so it can be scaled later.

I will come up with something first and let you know.

hi @plutov, I am thinking of something like this
- type: short-text
  label: What country you wanna travel?
  name: askCountry
- type: short-text
  label: What is the capital of ${askCountry}?

So basically -

Assign this name property to the question in YAML file and then reference it using the name property
Frontend will be responsible for inserting the answer in the template string
In that case once we get the answer for 1 question we can check which question has that name and can fetch the answer for it?

It is a very rough Idea though as of now..
let me know what do you think about it?


Add additional logging for future debugging of HA proxy mode flaky test

Signed-off-by: Ryan Bogan<EMAIL_ADDRESS>Description
The current logging is not sufficient to fix flaky test failures for testHAProxyModeConnectionWorks . The failure occurs due to the numer of connected sockets being 0.  However, the RemoteConnectionInfo containing this data is obtained through a transport request, so the cause of the sockets not connecting is unknown.  Since the error is non-reproducible, this PR adds additional logging when there are no connected sockets, printing out the cluster health at the time of failure.  If the flaky test failure occurs again, there will be more logged information that can hopefully lead to a solution.
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm not sure if this change warrants being in the CHANGELOG, since nothing was technically fixed.  Can someone advise me on where to put it in the CHANGELOG if it should be there?

Codecov Report

Merging #5667 (edd06fc) into main (f2b5044) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #5667      +/-   ##
============================================
+ Coverage     70.96%   71.08%   +0.11%
- Complexity    58550    58628      +78
============================================
  Files          4760     4760
  Lines        279515   279515
  Branches      40348    40348
============================================
+ Hits         198367   198697     +330
+ Misses        65037    64596     -441
- Partials      16111    16222     +111

Impacted Files
Coverage Δ

.../admin/cluster/reroute/ClusterRerouteResponse.java
60.00% <0.00%> (-40.00%)
:arrow_down:

...luster/routing/allocation/RoutingExplanations.java
62.06% <0.00%> (-37.94%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
56.25% <0.00%> (-35.00%)
:arrow_down:

...cluster/routing/allocation/RerouteExplanation.java
70.00% <0.00%> (-30.00%)
:arrow_down:

...rc/main/java/org/opensearch/ingest/IngestInfo.java
51.72% <0.00%> (-27.59%)
:arrow_down:

...a/org/opensearch/index/mapper/MapperException.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...nsearch/index/shard/IndexingOperationListener.java
63.93% <0.00%> (-22.96%)
:arrow_down:

...pensearch/index/mapper/MapperParsingException.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...a/org/opensearch/transport/netty4/Netty4Utils.java
42.42% <0.00%> (-21.22%)
:arrow_down:

...main/java/org/opensearch/ingest/ProcessorInfo.java
47.36% <0.00%> (-21.06%)
:arrow_down:

... and 479 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


problem with PEM file key

I created a PEM file on server ubuntu 18 with openssl 1.1.1 using this code
 $privkey = openssl_pkey_new([
            'digest_alg' => 'sha256',
            'private_key_bits' => 1024,
            'private_key_type' => OPENSSL_KEYTYPE_RSA,
        ]);
        try {
            openssl_pkey_export_to_file($privkey, 'WEB-INF/config/' . $filename);
        } catch (Exception $e) {
            echo 'Caught exception: ',  $e->getMessage(), "\n";
        }

on the same server it runs well, encoding and decoding as expected.
Then if I try the to decode using the same PEM file on different server (wich use openssl 1.1.1f)  it doesn't run saying that signature is invalid.
Doing the same using a string instead of PEM file works. I cannot understand... could it be that PEM file I created depend on specficia server?

it could be the openssl version too?

cool, thanks for the update.


[CON-423] feat: (zoho)update write input dynamically

Issue

Zoho expects a list of objects that's are to be created/updated.
Ampersand API sends a map[string]any. A single object

This PR wraps the object into a slice and sends it. Checks if the received data is not a list.
Tests:

For more context: https://linear.app/ampersand/issue/CON-420/zoho-crm-deep-connector

@jlimatampersand Addressed your review, and returned common.ErrBadRequest if the assertion of the map fails. Not so comfortable with the error type returned.  Merging so I can continue with Integration testing. Will update this if you feel the need to.


Add configuration file for fusionstage broker

Signed-off-by: leonwanghui<EMAIL_ADDRESS>This patch is proposed for contributing the configuration file of Huawei FusionStage brokers into osb-checker, personally it's quite exciting to see brokers from more and more service providers involved into this project to keep the compliance with OSB API, which would absolutely be a win-win solution for both sides.
Please feel free to ask if you have any questions.

I have a more general question... why are there any company specific config files at all in this repo?  E.g.  https://github.com/openservicebrokerapi/osb-checker/blob/master/2.13/tests/test/configs/config_azure.json
TBH I'm not that familiar with how all of this testing is done but I would have expected people to run the testing framework and provide the user/password/url/etc.. to their Broker at runtime and it would run the tests. Why are files like this needed at all? What's the point of testing against a static json response file?

@Haishi2016 could you help out with @duglin's question above?

Hi @duglin , the purpose of the config file is to provide needed information, just "user/password/url/etc..."
is not enough to finish the testing. For example, to provision a service instance, we should send a PUT
request to /v2/service_instances/:instance_id, with service_id, service_plan, organization_guid, space_guid, and parameters provided in the request body. The tester doesn't know what these fields should be, it should be provided by the author of the service broker. And then the tester will read these information from the config file, construct and send request to the service broker, observe whether the service broker behaves correctly.
I think it's OK for different company to provide the config file for their service broker, in case anyone is interested in the service broker and want to test whether the broker violates the spec.
Hi @leonwanghui , one thing I don't understand is why this config file has so many fake IDs? That's ID like acb56d7c-XXXX-XXXX-XXXX-feb140a59a66. To test one service, the real ID of the service should be provided.

@norshtein re: things like instance_id, service_plan... I would think these would be dynamically determined at runtime by looking at the catalog response or the response from a provision.

Hi @norshtein , thanks for pointing out the question. I think as what @duglin commented, we don't know the dynamic ID of service, service plan... so we just left the fake one there. IMO maybe it could make more sense if we remove these fields and fetch them through GetCatalog(). Any thoughts?

Hi @leonwanghui , what do you mean by "dynamic ID of service, service plan"? I think for any service/plan in the service broker, the ID of it should be fixed and never changed.

And GetCatalog() doesn't know the provisioning details about the service/plan, it doesn't know what provision parameters looks like, but our goal is to pass all needed information to the osb-checker and make it provisioning real service instance and test its behavior, that's something like lifecycle test.

The "dynamic" I mentioned means it differs with different service brokers. And if we pre-configure all of them in the config file, the whole file would be hard to maintain. Just my thought : )

Ideally, executing the checker is one step in CI, so when something like provisioning parameter changes, the one who modifies the code should also update the config file. This helps the broker owner make sure any change on the code will not violate the spec.


Document.annotations.in()

Right now the Document is the primary typed entity in atjson, which works fairly well in practice but is conceptually a little confusing. When we convert documents between different sources what we're really converting is the collection of annotations associated with that document. I think it would be conceptually simpler if the notion of a type or annotation schema existed primarily at the level of the annotation.
I propose adding a few types to the library:
AnnotationCollection<T extends AnnotationSchema> with public members AnnotationCollection<T>.convertTo(schema: <U extends AnnotationSchema>) : AnnotationCollection<U> and AnnotationCollection<T>.in(schema: <U extends AnnotationSchema>) : AnnotationCollection<U>

convertTo(schema: <U extends AnnotationSchema> : AnnotationCollection<U> is Document.convertTo, just scoped to work on a list of annotations instead
in(schema: <U extends AnnotationSchema>) : AnnotationCollection<U> returns a new AnnotationCollection where any unknown annotations in schema from the original collection are made known, and all other annotations are made unknown.

AnnotationSchema is the parent type of schema definitions. This would take over much of the current role occupied by Document and its subtypes. Converters would be defined between subtypes of AnnotationSchema rather than subtypes of Document. They would also  obviously 'own' the definition of their annotations, and would have a content type string for marking their annotations during de/serialization.
This proposal doesn't give the library any additional power (since a document is just a piece of un-annotated media and an AnnotationCollection, and the media portion doesn't at all complicate the associated schema) but I think it would be helpful for explaining the library and would help generally separate independent concerns within the system

If you feel comfortable, could you define a general interface for Document and Collection so there's more of a bird's eye view of what would be affected?
interface Schema {
}

export class Document<S extends Schema> {
  annotations: Collection<S>;
  new(): Document<S>;
  in<T extends Schema>(schema: T): Document<T>;
  convertTo<T extends Schema>(schema: T): Document<T>;
}

export class Collection<S extends Schema> {
  add();
  remove();
  replace();
}

// Equivalent old / new APIs
// -or-
// What old APIs would de-sugar to in terms of new APIs

I've created a working example of this in the TypeScript Playground

Ok, so I've worked through this a bit and this requires a lot of moving parts, but there's a few things that we can do in preparation to start this refactor to minimize large changes everywhere:

[ ] Use named exports for annotations
[ ] Move all utility functions out from the annotations directory to the top level.
[ ] Have an export default for the annotations directory (that's an array of the annotation definitions) and named exports for all annotations. (This is so we can import * as annotations for schemas)

Unfortunately, the rest of the changes will require some level of coordination or API changes that require different API signatures.

Also, here's a list of breaking changes that will likely be occurring in this proposal:

schema is an additional property for the constructor to a Document.
fromRaw on sources will no longer be used— schemas will be separated from the parsing. The suggestion here is to make the default export be a function that returns an instantiated Document from the source. For example, the default export of the source-html package would take an HTML string and return a Document<HTMLSchema>.
@atjson/offset-annotations will be deprecated in favor of @atjson/schema-offset.
All sources should have a named export schema that is the schema of the source.

This feature is a bit... all encompassing. It is a major improvement to the core api, but definitely touches a whole load of stuff. To make these changes reasonably reviewable, we'll need to break it up into several steps. I think it makes the most sense to merge all of these changes into a release/1.0.0 branch, since this feels like one of the last breaking changes we would make with the core api.
There's a lot of ways to approach this, but I'm going to give some suggestions on what may be the most logical approach:
Make the schema on a source match our new schema interface. This will be one of the bigger changes, and is designed to be a bit less aggressive than breaking everything.
This


Fix MSI token expires_in parsing issue.

Handles the edge case of AKS Workload Identity's expires_in expiry time response.

API change check
API changes are not detected in this pull request.


neomutt: 20200626 -> 20200814

Motivation for this change
:warning: Caution: 20200807 is only a development release and not considered stable, so please don't merge! I already had to apply a patch to fix a segfault on startup.
This is only intended to be used by power-users who want to try out the latest version. I don't consider this mergable until the 20.09 branchoff happened, after that we can discuss how to proceed with this.
ChangeLog: https://github.com/neomutt/neomutt/releases/tag/20200807, https://github.com/neomutt/neomutt/releases/tag/20200814
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

Today's release is marked as stable again and thus we could merge this PR now. Already using the new neomutt version on my machine :)

cc @flokli who also might want to take a look :)

@GrahamcOfBorg build neomutt


Add Yonsei University

Add Yonsei University

@kajing1077 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Add img2img_mask_blur option

Added because there was no option for img2img_mask_blur.
Used in inpaint.

I personally don't do much inpainting. What's the use case in having this as a tracked component for img2img?

Inpaint is used to modify part of the image.
There are many ways to use it, such as rewriting your hands.
Inpaint bugs are fixed regularly and many people use it.
Commits · AUTOMATIC1111/stable-diffusion-webui
I will use a forked and modified version, so please reject it if you don't need it.

I know what inpainting is and how it works - I just wanted to know use cases for having mask blur as a config preset option. Because mask blur seems like it's more dependent on each individual image/job you're working on, and not something for a generic config preset that you would swap to.

Blur is indeed a discrete value, but I like to use it when I want to start with a specific value and start adjusting from there.
I always set it to 0, but 0 works fine most of the time, so I wanted to use that as a preset.

If you want a value to simply always start at a specific value (like 0) you can set that in the vanilla ui-config.json file, no need for the extension for that use case.

I knew config.json but not ui-config.json.
If you can handle that, no problem.

Closing this PR because adding img2img mask blur isn't an ideal component to add as a preset.


The async style of import doesn't work in the unit testing guide

I'm able to do

pulumi.runtime.setMocks(

...

import * as infra from "./index";

...

describe(...

But if I attempt the style shown in the guide:
let infra: typeof import('../index');

before(async function() {
    // It's important to import the program _after_ the mocks are defined.
    infra = await import('../index');
})

I end up with undefined properties hanging off infra
File: docs/guides/testing/unit.md

@mikhailshilkov Do you know if something changed in Node that might cause the async style to no longer work? Is there a way to make it work or should we update the guide to simply import inline?

We changed that in https://github.com/pulumi/docs/pull/3176
I'm sure I ran it at the time of that change but I'm not sure what could change since then.
@SimenB any chance you know what's going on here?

Nothing should be undefined, sounds very odd. Without a complete reproduction it's hard to tell, though.

@leezen https://github.com/pulumi/docs/pull/3176#discussion_r587490203 could this be your problem?

@SimenB @mikhailshilkov That was indeed the problem. Attempting to get the value from w/in the describe was causing the value to be undefined. When I fully reference infra.foo... within a test, it works as expected.


allow per-command analytics suppression

allow per-command analytics suppression (work towards https://github.com/flutter/flutter/issues/3862)
fix an issue where the analytics object was constructed before flutterRoot had been set; as a result the version we were reported was wonky

The usage now looks like flutter --suppress-analytics build apk.


fix reflect-metadata version in package.json

^0.1.2 Angular seems to be very specific about the Version

Thanks for the catch!


dropbox: 9.4.49 -> 10.4.25 [master]

Motivation for this change
updates
Things done

Built on platform(s)

[x] NixOS

[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Does this fix #18601 ?


Architecture: Project Discovery

This addresses the challenge of handling source trees that contain multiple software projects.
These are notes/ideas for a potential discovery phase, which is supposed to be executed before the translation phase and meant to determine a list of projects within the given source tree to be processed by one or more translators.
The goal is to achieve a standardized way of handling source trees containing more than one software project inside.
Glossary:

project: Consists of source code + metadata defining dependencies and how to produce various artifacts (packages, dev envs, ...). A source tree can contain multiple projects.
translate: The process of parsing the metadata of a project and generating a nix derivation out of it.

A project living alongside other projects within the same source tree can have the following properties:

independent: The project can be translated independently of other projects. Example: multiple sub-directories containing their own independent lock files.
dependent: The project shares some of its metadata with other projects. Example: A rust based source tree containing multiple projects with their own Cargo.toml but only one Cargo.lock

Current situation:
Currently dream2nix contains multiple implementations for project discovery. The rust/cargo translator does it's own scanning of projects and dream2nix itself also contains a language independent project discovery mechanism. The latter is too simple and insufficient for use with rust.
My goal is to establish a new puggable discovery mechanism which is handled by the core framework instead of the individual translator.
Problems with the current situation:

Duplicated code and maintenance overhead due to multiple implementations of project discovery.
It is difficult to build a generic UI for the multi project situation, if there is no abstraction for project discovery.
With the current builtin mechanism, projects are identified via a sub-directory path and translated in complete isolation from each other. This only works for projects which are independent. Therefore it is not applicable to rust and probably others.
The project discovery and project translation is not properly separated from each other. This limits the capability of inspecting the project list before translation and decreases the potential for advanced configuration options like, for example, selecting only some projects for translation or adapting translator parameters on a per-project basis, etc....

After adding a discovery phase, the new architecture of dream2nix would be:
discovery -> translation -> dream-lock -> building
Inputs of the discovery phase:

source tree

Outputs of the discovery phase: a list of:

project name
project subsystem (eg. python, nodejs, etc.)
list of file paths of relevant metadata files
subdirectory path the project resides in (if applicable)

The outputs of the discovery phase are the inputs for the translator(s).
If several projects are found which share some metadata (like a single lock file), those can be processed by a single translator call if the translator supports this.
Other projects might require multiple translator calls in order to be processed.
Each translator could declare a multiplexing function which receives the discovered list of projects and their properties and then decides if one or more translator calls are required to process the inputs.

This is mostly implemented. Currently only the nodejs subsystem supports project discovery.
Things left to do:

[ ] Allow configuring translators/builders
[ ] Create well commented template for discoverers
[ ] Find and document mechanism to feed sub-projects as a build input to parent projects (probably via override system)


update license info for O365 ATP P2

Updated the line to mention O365 ATP P2 is included with M365 E5 Security add-on license to be more clear.  This page currently does not mention anything on the M365 E5 Security add-on license (except for the safe documents capability)
M365 E5 security should be included in O365 ATP P2.  My source for this is based on this article: https://www.microsoft.com/en-us/microsoft-365/blog/2019/01/02/introducing-new-advanced-security-and-compliance-offerings-for-microsoft-365/  which states M365 E5 Security includes O365 ATP including Threat Intelligence which is the name of O365 ATP P2 as documented here: https://docs.microsoft.com/en-us/office365/servicedescriptions/office-365-advanced-threat-protection-service-description#feature-availability-across-advanced-threat-protection-atp-plans

@yogkumgit let me know if you need anything else for review on this?

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Retain passwords in Git URLs

Fixes handling of GitHub PATs in HTTPS URLs, which were otherwise dropped.
Does not yet address SSH authentication.
Adds test coverage using a real private repository and PAT. Yes, the PAT is committed to make this test usable by anyone. It has read-only permissions to the single repository, expires Feb 1 2025, and is in an isolated organization and GitHub account.
The snapshots are sloppy due to #1714 — figure we can address that separately.
Related:

https://github.com/astral-sh/uv/issues/1514
https://github.com/astral-sh/uv/issues/1452

Interesting this works locally but not in CI. I'm not sure why it's reaching out to the credentials helper when the PAT is in the URL?
Perhaps relevant.

https://github.com/rust-lang/cargo/issues/5227

So the reason this was failing is because the PAT was being read as a username instead of a password. We'll need to figure out a long term solution for supporting authentication without passwords.
Separately, it looks like these test packages are not being installed correctly (they are missing from site-packages).


[Site] Background color change

Current State of the GetNighthawk.dev site
Currently, the hero section of the website as well as the "what is getnighthawk?" section has a grey background color.
check it out at - https://getnighthawk.dev/

Desired State of the GetNighthawk.dev site
The Figma design is a bit different for the hero section as it has a blue tone background color #C9FCF6. The "what is getnighthawk?" section is supposed to have a white background like all the other sections, instead of grey.

Figma design link - https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs?node-id=5884%3A12909

Contributor Resources

See the Contributing to getnighthawk.dev Website
See the Project Site section of GetNighthawk project doc

Can you assign this issue to me?

Sure @NikhilSharma03


Fix error chan close on channel shutdown.

If errors chan remains open after rabbimq channel shutdown, it could result in deadlock when other goroutine is trying to Close channel again.

@DmitriyMV can you please add a test? I assume by "rabbitmq channel shutdown" you mean a channel exception that causes RabbitMQ to close the channel.

Yes, sorry for the incorrect description. In my case this happened when I tried to close the Channel after acknowleding delivery from consumer with autoAck (my incorrect application logic which resulted in channel level exception). Next step is too confirm that it's a reliable way of reproducing this error and writing the proper unit test. Will do.

@DmitriyMV thank you for the update.

Sorry - my initial assumption was incorrect. The deadlock happens when you try to concurrently close channel and it's connection. You may require several attempts to reproduce it (usually 2-3 times).
The commit above fixes it.

Is there anything that stops from merging this branch?

@DmitriyMV it needs QA. Chances are it may not happen until January 3rd or so.

Merging per discussion with @streadway and @gerhard.


makeId refactoring not applied to save method

Seems as if the refactoring that was done in https://github.com/strongloop-community/loopback-connector-elastic-search/commit/25e902936a749b9eb482d28b9df31259c3a9d761#diff-a27d2580e4157c6999e9327a4a358c21L446 was not applied to ESConnector.prototype.save (marked the line in the link above).
When I try to save an existing model the esConnector.js throws the following error:
TypeError: self.makeId is not a function
transform_1 |         at ESConnector.save (/usr/local/lib/node_modules/loopback-connector-es/lib/esConnector.js:1019:35)
transform_1 |         at /usr/local/lib/node_modules/loopback-datasource-juggler/lib/dao.js:2244:25
transform_1 |         at doNotify (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:98:49)
transform_1 |         at doNotify (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:98:49)
transform_1 |         at doNotify (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:98:49)
transform_1 |         at doNotify (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:98:49)
transform_1 |         at Function.ObserverMixin._notifyBaseObservers (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:121:5)
transform_1 |         at Function.ObserverMixin.notifyObserversOf (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:96:8)
transform_1 |         at Function.ObserverMixin._notifyBaseObservers (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:119:15)
transform_1 |         at Function.ObserverMixin.notifyObserversOf (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:96:8)
transform_1 |         at Function.ObserverMixin._notifyBaseObservers (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:119:15)
transform_1 |         at Function.ObserverMixin.notifyObserversOf (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:96:8)
transform_1 |         at Function.ObserverMixin._notifyBaseObservers (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:119:15)
transform_1 |         at Function.ObserverMixin.notifyObserversOf (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/observer.js:96:8)
transform_1 |         at ModelConstructor.<anonymous> (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/dao.js:2238:17)
transform_1 |         at ModelConstructor.trigger (/usr/local/lib/node_modules/loopback-datasource-juggler/lib/hooks.js:70:12)

I will refactor and create a PR for it

@aquid has either already merged a PR or is very close to it. He is in the caught up middle of some philosophical discussion about what save should or should not do according to the folks at loopback. https://github.com/strongloop/loopback-datasource-juggler/issues/1233
You can expect a release by end of this week.

@ketansp Pull request is already merged and you will have this issue resolved once the latest version is released. As far as the save method's expected behavior discussion goes, I will update the save method functionality based on the final conclusion from the discussion. But as of now, es connector save method supports partial update.
cc @pulkitsinghal

released in v1.3.2


Allow multiple source filters per project

Coverage increased (+0.03%) to 94.332% when pulling 2e715fd9952671cfdd49e6a4d6cdfaf59c78eadb on feature/multiple-jira-filter into a833cd549f4f58e69b0028c14ccd27ddc13b6412 on master.


chore!: rename java project's usage of peerdas-kzg -> eth-kzg

Related to #54

Marking this as breaking since we have releases for the java package and we have changed the name.
Name has been changed to java-eth-kzg


.NET6 Support

Now that .NET6 is officially released, it would be great to support it.

I've just merged .NET 6 support,  the next build in the MyGet feed should have it (it will be version 0.5.53-pre)


Update go.mod

important patches

go.mod is updated every time we merge a feature, no need to make a specific pull request for that :)

we are working with very specific versions, we cannot just upgrade cosmos-SDK without adjusting to all the requirements.


get teleport target position??

hi,
how can i get teleport target position?
public void OnTeleportCompleted(TeleportEventData eventData) => position = eventData.Hotspot.Position;  ??

You may be able to go off the pointer object itself, something like public void OnTeleportCompleted(TeleportEventData eventData) => position = eventData.Pointer.Result.Details.Point;

You may be able to go off the pointer object itself, something like public void OnTeleportCompleted(TeleportEventData eventData) => position = eventData.Pointer.Result.Details.Point;

thanks for your reply :]
but is this local position or world position?

Should be in world position, as that's what we use to position the teleport cursor, but if you're seeing otherwise let me know!

@davoodkharmanzar did this answer your question? If so, may we close this issue?

Thanks!


Crash while closing editor: Resources still in use at exit / ObjectDB instances still exist

Operating system or device - Godot version:
Windows 8.1
Godot 2.1
Issue description (what happened, and what was expected):
After closing the editor, windows reports a program crash, and the console shows various error messages.

Steps to reproduce:

Open project
Close editor
Crash

Link to minimal example project (optional but very welcome):
http://www.mediafire.com/download/g08l7saby12b5q7/Breakout.zip

Thanks, it's a duplicate of #5664 and is fixed in git already.

I have the same error, i use godot 3.0.2
it started to happen to me when I was testing my project

@Osimedias the error message itself is not a problem, it usually means something about your project. The problem was the crash. But this is an old issue that was fixed a long time ago, if you are getting crashes please open a new issue.

@Osimedias is it happening on Windows or iOS?
It started happening to me in iOS, and I fixed it with https://github.com/jahd2602/godot/commit/1250c176068b45727448bcb9d9a0b52f9a392a85


6.0+ Exlusions not available

Detected XenServer Version: 6.0.2
Failed to locate Auto Exclusions file: XS602_excludes.py
Checking for presence of Parent version file: XS60_excludes.py  ...
Failed to read Auto-Exclusion List from: https://raw.githubusercontent.com/dalgibbard/citrix_xenserver_patcher/master/exclusions/XS60_excludes.py
Check the URL is available, and connectivity is OK.
Error: HTTP Error 404: Not Found
NOTE: To proceed without downloading the Auto-Excludes file (not recommended), pass the "-E" flag.

Yep, this seems expected- I've only provided exclusion files on what xenserver versions were current at the time of developing the script. I'll see what I can dig up from the XML, probably tomorrow.

It's worth pointing out that with version 6.0.x you can use the XenCenter software to do patching with a free license; assuming they haven't changed it.

Pushed auto exclusion files for v6.0 and v6.0.2.


Fixed reference in README.md

Sodium nitrate is not called Saltpeter, Potassium nitrate is.
Sodium Nitrate is far less useful for manufacturing gunpowder, and according to http://en.wikipedia.org/wiki/Caliche#Chilean_caliche, Chilean caliche also contains Potassium Nitrate (even though in far lower quantities), so that's fine.
Additionally, both Potassium and Sodium nitrate both have almost the same fertilizing properties due to both having the nitrate anion, to justify its other use.

From the Sodium nitrate (Chile saltpeter) article:

Sodium nitrate was used extensively as a fertilizer and a raw material for the manufacture of gunpowder in the late 19th century.

Closing because the primary purpose of the reference link is to justify it dropping from Sandstone.

Again, potassium nitrate also drops from sandstone, and sodium nitrate is far worse for gunpowder production than potassium nitrate is.
But hey, it's your choice, this doesn't really matter anyway.

I definitely see where you're coming from but I'm going to leave it as is.


can you make a null safety version of it?

can you make a null safety version of it?

yes, please make this null safe

Hi! Are you listening? Pls. update this repo with latest flutter SDK having null safety.


govuk_solr6: add basic handling of solr configsets and cores

https://trello.com/c/7iYmKqEe and https://trello.com/c/lkTmfhcY
Together, these should allow us to provision solr "cores" (analogous to postgres "databases") using our puppet configuration.
Unlike postgres databases, where each database is permitted to alter its own schema to its desire, solr (at least in the old fashioned way we're forced to use it with ckan) rather wants its schema to be given to it explicitly "up front". This is typically done by naming a configSet at core creation time which encompasses a number of settings for the core, including the schema. As of solr 6.x, these configSets can't be created through any management interface and have to be placed in solr's data dir directly. So the govuk_solr6::configset resource allows us to ensure this is in place by simply providing a name and a schema.xml. Included is ckan28, with the schema.xml from ckan 2.8.3.
The govuk_solr6::core resource then allows us to provision cores. This is done through solr's http interface, and uses an exec resource to create the new core, but first checking to see whether a core with this name already exists. It won't ever try to do anything else as we don't want to risk puppet screwing around with potentially important data.

Thanks man, I'll add more comments from here - didn't realize I had so much to say when I started writing this PR desc.

There is literally nobody with more context, the most I'm expecting is someone with more puppet experience than me.

I wouldn't claim to be that person - perhaps @benthorner or @cbaines ?

It's mergey time!


TakeScreenshot with solo makes the keyboard and status bar disappear

From<EMAIL_ADDRESS>on January 25, 2015 03:25:12
What steps will reproduce the problem? 1. write testcode that shows the keyboard (solo.clickOnEditText(0)) , and write
solo.takeScreenShot("stamStringName",100); 2. 3. What is the expected output?
A screenshot that contains what is currently visible on the screen
including the status bar and the kyboard
What do you see instead?
part of my app, with blank row where the status bar is supposed to be
blank square where the keyboard is supposed to be
What version of the product are you using?
Robotium Solo 5.2.1
On what operating system?
Android 4.4 Please provide any additional information below. here is my test
public void testTakeScreenShot(){
solo.assertCurrentActivity("wrong activity", ContactPickerActivity.class);
solo.sleep(15000);
    new Handler(Looper.getMainLooper()).post(new Runnable() {
        @Override
        public void run() {
            ContactAdapter adapter = ((ContactPickerActivity) getActivity()).contactsAdapter;
            ArrayList<ContactData> items = new ArrayList<ContactData>();
            items.add(new ContactData("0","יוסי","חדד ","יוסי חדד ","0501234567","",false));
            items.add(new ContactData("1","משה","מילר  ","משה מילר  ","0501234567","",true));
            items.add(new ContactData("2","יוסי","לדרמן ","יוסי לדרמן ","0541234567","",false));
            items.add(new ContactData("3","יששכר","פלדמן ","יששכר פלדמן ","0507654321","",false));
            items.add(new ContactData("4","דימה","חדד ","דימה חדד ","0501234567","",true));
            items.add(new ContactData("5","משה","חדד ","משה חדד ","0507654321","",false));
            items.add(new ContactData("6","אלי","שמש  ","אלי שמש  ","0549876543","",true));
            items.add(new ContactData("7","דוד","חדד ","דוד חדד ","0549876543","",false));
            items.add(new ContactData("8", "נחום", "ראובנוב ", "נחום ראובנוב ", "0507654321", "", true));
            adapter.clear();
            adapter.addAll(items);
            adapter. notifyDataSetChanged();

        }
    });

    solo.sleep(1000);
    solo.clickOnEditText(0);
    solo.sleep(1000);
    solo.takeScreenshot("Contacts",100);
}

here is the result : https://www.dropbox.com/s/c4mgm8tlvv6yhya/Contacts.jpg?dl=0 expected result: https://www.dropbox.com/s/qjjhnrp71c9ibju/Screenshot_2015-01-25-13-16-01.png?dl=0
Original issue: http://code.google.com/p/robotium/issues/detail?id=652

From<EMAIL_ADDRESS>on January 26, 2015 17:39:32
Robotium uses Instrumentation and due to this its locked to tha application under test. The only process its allowed to take a screenshot of is the app process.
Status: WontFix
Owner<EMAIL_ADDRESS>


Prometheus dashboard UI Bug: Shows the path to the alerting rules on top of each alerting rule

Bug Report
What did you do?
Upgraded Prometheus to v2.11.1 and I saw a strange "/etc/prometheus/prometheus.rules > [rule_name]" on top of each of the rules. Not sure if this is a bug or if this is a new feature. I have deleted the deployment and redeployed it again and I still see this. I don't remember seeing this in older version of Prometheus.
What did you expect to see?
Did not expect to see "/etc/prometheus/prometheus.rules > [rule name]" on top of each of the alerting rules.
What did you see instead? Under which circumstances?
[Alerting Rule Name]  in the status bar
Environment

System information:
Linux 3.10.0-957.21.3.el7.x86_64 x86_64

Prometheus version:
prometheus, version 2.11.1 (branch: HEAD, revision:
e5b22494857deca4b806f74f6e3a6ee30c251763)
build user:       root@d94406f2bb6f
build date:       20190710-13:51:17
go version:       go1.12.7

Yes it is the new design since 2.10.0. See https://github.com/prometheus/prometheus/pull/5448.


Can't get softDelete2 working properly!!

//NodeJS version: 10.16.3
//"feathers-hooks-common": "^5.0.1",
//stats services for which I'm trying to implement softDelete2, so that it will flag all the documents as deleted after remove request
//stats class
const { softDelete2 } = require('feathers-hooks-common');
const optionsBefore = {
deletedAt: -1,
keepOnCreate: true,
skipProbeOnGet: false,
allowIgnoreDeletedAt: true
};
const optionsAfter = {
deletedAt: 1,
skipProbeOnGet: false,
allowIgnoreDeletedAt: true
};
module.exports = {
before: {
all: [softDelete2(optionsBefore)],
find: [],
get: [],
create: [softDelete2()],
update: [],
patch: [],
remove: [softDelete2(optionsAfter)]
},
after: {
all: [softDelete2(optionsBefore)],
find: [context => {console.log(context.result);}],
get: [],
create: [],
update: [],
patch: [],
remove: []
},
error: {
all: [],
find: [],
get: [],
create: [],
update: [],
patch: [],
remove: []
}
};
I'm keep running into an error of softDelete2 is not a function.

Use the new softDelete with feathers-hooks-common version 5.0.0 or later.

Thanks so much, softDelete is working now..
is there any hooks so i can render or change the context.result.data, like sort all the data and then
change the object's structure.
after the request the object's would look like this:
{
_id: ObjectId,
latest: Boolean,
schema_version: Number,
asset_type: String,
asset_id: String,
stat: String,
value: Any,
date: Date,
created_at: Date,
updated_at: Date,
}
then with the expected hook or query we can build an object like this:
[
{
_id: '<channel_id>',
subscribers: [
{value: Number, date: Date},
// most recent 10 records
],
posts_30d: [
{value: Number, date: Date},
// most recent 10 records
]
},
]
help will be appreciated!!!

u can sort data before fetching with $sort query option. and for formatting i think u mean u want to join subscribers and post_30d data... i think you'd look into fastJoin hook

This might also work better with the new softDelete.


elm-compiler 0.16 fails to build with "Compiled JS did not match expected JS."

The elm-compiler builds on Nix have recently started failing with messages like:
    tests/test-files/good/Soundness/SpecificAnnotationInt.elm: [Failed]

Compiled JS did not match expected JS.

  If the change is intentional, rerun the tests with environment variable: ELM_WRITE_NEW_EXPECTED=1

expected: "Elm.Main = Elm.Main || {};\nElm.Main.make = function (_elm) {\n   \"use strict\";\n   _elm.Main = _elm.Main || {};\n   if (_elm.Main.values) return _elm.Main.values;\n   var _U = Elm.Native.Utils.make(_elm);\n   var _op = {};\n   var px = function (x) {    return \"test\";};\n   return _elm.Main.values = {_op: _op,px: px};\n};"

 but got: "Elm.Main = Elm.Main || {};\nElm.Main.make = function (_elm) {\n       \"use strict\";\n       _elm.Main = _elm.Main || {};\n       if (_elm.Main.values)    return _elm.Main.values;\n       var _U = Elm.Native.Utils.make(_elm);\n       var _op = {};\n       var px = function (x) { return \"test\";};\n       return _elm.Main.values = {_op: _op,px: px};\n    };"

Full build log: https://travis-ci.org/jgillich/mp/builds/116983036#L1567
As far as I can see, the only difference is some additional whitespace. We suspect some other dependency that got upgraded is causing this, does anyone have any idea which one that might be?
ref https://github.com/NixOS/nixpkgs/issues/14028

Something in http://hydra.nixos.org/api/scmdiff?uri=https%3A%2F%2Fgithub.com%2FNixOS%2Fnixpkgs.git&rev2=1a07877b5c13bcae5d57382ee64d72384e039905&rev1=fd4cdf183a98b0b7086e7fb140a04854805f2b47&branch=&type=git

cc @evancz

Found it, offending dependency is language-ecmascript. You can see from their CHANGELOG that they did pretty-printing improvements in the new release. Bounding language-ecmascript >= 0.15 && < 0.17.1 should fix this.

The test failures suggest running with an environment flag to regenerate the tests. Perhaps someone should do that.

Can confirm that the suggested fix does the trick. See https://github.com/elm-lang/elm-compiler/pull/1330.

As of commit https://github.com/elm-lang/elm-compiler/commit/684504e4744cfced1a02ca0839632610bd412637, the pretty-printing part of language-ecmascript is not used anymore at all. So this issue is obsolete and can be closed. (The compiler tests are passing as of https://github.com/elm-lang/elm-compiler/commit/cd8eb70843fdbecf9520532eeec46818da7ac618 as well.)


Add BoostFromAverage to Python model.

Summary
Add the BoostFromAverage output to the init_score on the train_set Dataset. It seems to me that they serve the same function - that is, reducing training time by allowing the model to have some previous knowledge of the data before the first boosting round. BoostingFromAverage is a simply a subset of the init_score functionality.
Motivation
This allows us to recover the mean of the target variable after training and then when saving the model. There are many instances where we may not have access to the label data (and therefore the mean) after saving a model.
This is also the equivalent to the intercept in EBMs so aids in comparisons of LightGBM and EBM. See https://github.com/microsoft/LightGBM/issues/3905#issuecomment-797136404 and EBM intercept calculations.
Finally, and maybe most importantly, this would allow a user better insights into how the model is working at each stage and would help with model interpretability #4065 and #3095.
Description
Something like, writing the results from BoostFromAverage back to the model here
https://github.com/microsoft/LightGBM/blob/d517ba12f2e7862ac533908304dddbd770655d2b/src/boosting/gbdt.cpp#L344
References

Superseded by #4313 as a more general approach.


Fix descriptions of sprite position bytes

Is it just me or are these changes wrong? For instance if a sprite is on the left edge of the screen, the OAM X position is screen position plus 8, so 0+8=8. If it was 0-8 it would be -8 which is not correct. I might be just reading something wrong though.

Depends on how you read it... "screen position plus 8" can be interpreted as "I must write the desired position plus 8", but also as "The OAM position is the on-screen position plus 8, so it's shifted downwards by 8 pixels".
Maybe more unambiguous wording is preferable, then, talking unambiguously about the coordinate offsets. By the way, do we mention the orientation of the X and Y axes? If not, this would be a good opportunity to add that.

@rondnelson99 as @ISSOtm said, it got me confused because of the interpretation I gave it. I agree we should reword it altogether with something else.

Since we agree that a clarification is in order, even though this PR doesn't solve the issue, shouldn't we at least keep it open as a reminder of the work item? Making it into a WIP should be enough to point out that the PR's contents are not to be merged as-is.

Since we agree that a clarification is in order, even though this PR doesn't solve the issue, shouldn't we at least keep it open as a reminder of the work item? Making it into a WIP should be enough to point out that the PR's contents are not to be merged as-is.

I will open an issue about this.


Back/Forward isn't handled

Detect Cloudflare 6.1 / Firefox 51.0.1 (x64)
Detect Cloudflare doesn't handle detection of page when page is changed to previous/next (same tab). User needs to reload the tab to have the detection updated.

Hi zymase, thanks for the report! You are correct, the icon is not updated correctly. Nowadays many webpages automatically reload when you navigate backward/forward in the tab, so I didn't notice this before.
I think a proper fix would require storing the (potentially large) detection history for each tab. This feels rather heavy for what I feel is little benefit. So I checked how other extensions (uBlock0 and Ghostery) behave in this case. They just reset to zero, without recalling the previous result. I will follow the same approach, and reset the detection status to neutral (grey) until the page is reloaded. Also, I'll add a note to the README pointing out this issue.

Now that you mention it ("Nowadays many webpages automatically reload when you navigate backward/forward in the tab") I've started wondering on the pertinence of the related setting I've always used in Firefox and have switched the cache check of pages from when the page is out of date (default) to every time a page is loaded and indeed icon update pseudo issue vanishes.
This problematic concerns indeed all extensions handling page related data, and they are numerous. Another Firefox add-on I use than those you mention, called CheckMyHTTPS encountered the same icon update problem and resolved it as you with coming version 7.0
For Firefox users, with your permission @traktofon , a recall of Firefox page cache update settings available in about:config,

Check cache of the pages : browser.cache.check_doc_frequency
0 : Once per session
1 : Every time a page is loaded.
2 : Never check for a new version - always load the page from cache.
3 : When the page is out of date. (Default)

So, Every time a page is loaded here it will be even if upcoming version 7.0 will handle cases (2) and (3).
Thanks!
I found the door closed so I'll close it back as i leave!


Memory management of createObjectURL

Hi,
Firstly, this repo is exactly what I was trying to solve! This is great work and I have a lot to learn from your implementation :))
I had been trying to accomplish this in OSD without forking the source, and ended up making a dirty version using deckGL's TileLayer instead. My implementation is similar, of maintaining handles to the dzi file and it's tile directory, and constructing a file handle to the requested png on demand.
Did you face any memory issues with creating several object URLs? If so, how did you tackle it?

Thanks for your kind words! I unfortunately don't have any really large DeepZoom pyramids to check with anymore, but when I was testing a few years ago, I could open hundred-gigabyte images without any particularly noticeable problems on my machine, so memory usage wasn't a very pressing concern.
I'm not too familiar with how React's component lifecycle behaves with regards to the OpenSeaDragon viewer, so it might be possible that opening images repeatedly will leak memory.


Point go package to where generated configs are

not 100% sure. This proto could be used outside the scope of the goagent (e.g. agent-manager), isn't? cc @davexroth

not 100% sure. This proto could be used outside the scope of the goagent (e.g. agent-manager), isn't? cc @davexroth

agreed, this shouldn't be coupled to the go agent.
What is the use case @rnburn ?

Replaced by #50


Request triager role for import-brain

I have read and understood the project's Code of Conduct.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the following GitHub organizations:
jshttp
pillarjs
express

Hi @import-brain I resent your invite again as well as some others as it said it wasn't accepted in the original 7 days. I'm going to close this issue for now, but if you are having an issue accepting it, please let us know.

@dougwilson Thanks for the notification! Turns out, it didn't pop up in my notifications for some reason, so I thought you guys were waiting to send invites. Weird...


Docker API does not report correct images for /containers/json endpoint

Description of problem
Docker API (v.1.18) does not report correct images for /containers/json endpoint. Instead of the actual image ID for an image not longer tagged the previous tag is reported.
docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): linux/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

docker info
Containers: 6
Images: 139
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 151
 Dirperm1 Supported: false
Execution Driver: native-0.2
Kernel Version: 3.13.0-49-generic
Operating System: Ubuntu 14.04.2 LTS
CPUs: 8
Total Memory: 31.29 GiB
Name: Ubuntu-1404-trusty-64-minimal
ID: QE6C:ZNQX:BADL:4BTY:7AK5:274U:7B7N:EUS7:FGYI:TE5Q:JPXI:FBK6
WARNING: No swap limit support

uname -a
Linux Ubuntu-1404-trusty-64-minimal 3.13.0-49-generic #83-Ubuntu SMP Fri Apr 10 20:11:33 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Environment details (AWS, VirtualBox, physical, etc.):
Bare-Metal, Ubuntu, latest lxc-docker
How reproducible
100%
Steps to Reproduce:

docker pull an image
docker run it (and give the container a name)
Update the image
docker pull the changed image
Ask the /containers/json endpoint about the container

Actual Results

The image ID for the tag has changed
The old image is shown with "Repository" <none>
The API reports the old tag for the image the container is running with

Expected Results

The image ID for the tag has changed
The old image is shown with "Repository" <none>
The API reports the image ID for the image the container is running with

Additional info
# curl <IP_ADDRESS>:21/containers/json?all=1
[{"Command":"./gobuilder","Created":1429599867,"Id":"dc520983d708749528b900118383ac20143a657a156c5efadc678892d24215e3","Image":"luzifer/gobuilder-frontend:latest","Labels":{},"Names":["/gobuild-frontend"],"Ports":[{"IP":"<IP_ADDRESS>","PrivatePort":3000,"PublicPort":1060,"Type":"tcp"}],"Status":"Up 5 hours"}]
# docker inspect gobuild-frontend | grep -i image
        "Image": "luzifer/gobuilder-frontend:latest",
    "Image": "b8e06e06802772cad27d271eac378eca042ebac6e3653bea21bd0751e1f30dfa",
# docker images
REPOSITORY                   TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
luzifer/gobuilder-frontend   latest              b96f5f028d3c        2 hours ago         592 MB
<none>                       <none>              b8e06e068027        5 days ago          591.7 MB

Until Docker 1.5.0 the expected behavior was present

+1, this bug prevents our chef cookbooks from detecting that a container should be redeployed after the image has been updated.

+1 very annoying regression

Here is a short bash example demonstrating the issue.
If I update the image of a docker container (eg. by doing "docker pull" after the container has run) the container still reports that it follows the tagged image name, while it should be displaying the internal image identifier (since the tag has moved).
# container=myapp-1
# container_image_id=`docker inspect --format '{{ .Image }}' ${container}`
# image_id=`docker inspect --format '{{ .Id }}' $(docker ps | grep ${container} | awk '{print $2}')`
# echo "Must be EQUAL ${container_image_id} AND ${image_id}"
Must be EQUAL 608e6e154266bdc6a7429f969233ea2378ac43fb88868adbbcdef1b87cb3167c AND 608e6e154266bdc6a7429f969233ea2378ac43fb88868adbbcdef1b87cb3167c
# docker tag -f 81e3cc14a804 myrepo/myapp
# container_image_id=`docker inspect --format '{{ .Image }}' ${container}`
# image_id=`docker inspect --format '{{ .Id }}' $(docker ps | grep ${container} | awk '{print $2}')`
# echo "Must be EQUAL ${container_image_id} AND ${image_id}"
Must be EQUAL 608e6e154266bdc6a7429f969233ea2378ac43fb88868adbbcdef1b87cb3167c AND 81e3cc14a804a7e424201af69faf41b39f70dec18aa9ea19334b7f3662f98601

The consequence is that my cookbook should rely on the real image ID (reported by docker inspect --format '{{ .Image }}' ${container}) and not on whatever image is listed in the output of docker ps.

Confirmed, this is because ps is using container.Config.Image instead of container.Image to ensure we get the correct tag name... unfortunately tags can be changed.

This should check if the ID for container.Config.Image matches container.Image before using it.

This looks like it was broken in #11895, with the specific change here

@relistan issue was that "docker ps" was reporting a different name than was used to create the container sometimes when there are more than 1 tag on the image.
Now it is just showing whatever was passed in when creating the image, but this gets out of date.

@relistan Original issue was IIRC that it tried to find ImageName from ImageID, but there is can be multiple tags with same id and you can see in ps that you created container with another tag, tag that you created.

Now it just shows what you write in docker run command.

For completion sake, this bug also occur on 1.5.0-dev version.
docker version
Client version: 1.5.0-dev
Client API version: 1.18
Go version (client): go1.3.3
Git commit (client): fc0329b/1.5.0
OS/Arch (client): linux/amd64
Server version: 1.5.0-dev
Server API version: 1.18
Go version (server): go1.3.3
Git commit (server): fc0329b/1.5.0
OS/Arch (server): linux/amd64

docker ps
docker ps
CONTAINER ID        IMAGE                                                                     COMMAND                CREATED             STATUS              PORTS                                                                                NAMES
4eb036e6a545        31cc81ffb6356211de6e969292abc7b5620a9cab137e46565ddc97e60412aef3:latest   "supervisord"          About an hour ago   Up 10 minutes       <IP_ADDRESS>:10200-10208->10200-10208/tcp, <IP_ADDRESS>:10211->10211/tcp                             xxxxx-service-7bd4107333e13e

@cpuguy83 Thanks! I see. :)
@LK4D4 That's really undesirable behavior because tags/image names move. It's unexpected for something to tell me it's tagged "production" when it's not running the current "production". Or "latest" when it's not the one tagged "latest".
Here's a Docker 1.5 install showing a container for which the image name and tag have moved:
$ docker ps
CONTAINER ID        IMAGE               COMMAND                CREATED             STATUS              PORTS                                   NAMES
8d826d1245c4        2485b0f89951        "nginx -g 'daemon of   9 weeks ago         Up 2 seconds        443/tcp, <IP_ADDRESS>:10234->80/tcp   serene_banach

Here's what that looks like on 1.6:
$ docker ps
CONTAINER ID        IMAGE                                                                     COMMAND                CREATED             STATUS              PORTS                                   NAMES
8d826d1245c4        2485b0f8995167b796a7ab4696e842c08bd27d58febb3ba0e935a4e2c1b2807d:latest   "nginx -g 'daemon of   9 weeks ago         Up 3 seconds        443/tcp, <IP_ADDRESS>:10234->80/tcp   serene_banach

Notice how it's doing a few wrong things. First, it's showing the whole long image ID. Second, it's showing that it has the latest tag which it does not.
Here's what the images look like on that same host:
$ docker images
REPOSITORY    TAG                 IMAGE ID            CREATED              VIRTUAL SIZE
nginx         latest              224873bdcaa1        4 weeks ago          93.44 MB
<none>        <none>              2485b0f89951        10 weeks ago         93.46 MB

Note that the latest tag is supposed to be on 224873bdcaa1 not on 2485b0f89951.
It's moderately annoying to have a different tag show up than the one I invoked it with. But it's actually a production issue for us if the tag is showing incorrectly.

I'm trying to work on this. New to the project, so didn't want to call dibs in case someone better wanted to take a look.
I think I've got a failing test case together if anyone wants to take a look at it. https://gist.github.com/thieman/331edd7e2a3c6b397663

I've got a first pass at code that seems to work. Testing some more. @thieman giving your test a whirl now.

 Think this latest test run might work, though. Care to share what you've got?

The commit linked up there is wrong, btw, it should properly be linking to this entire PR: https://github.com/docker/docker/pull/12918

I've moved my commentary to that PR.

Working from @thieman's test case on #12918 I think there are two different problems here:

I update an image tag following the steps in @thieman's test case. I end up with a container with the wrong ImageID:

$ docker tag busybox:latest busybox:TestPsImageIDAfterUpdate-original
$ docker run -d -t busybox:TestPsImageIDAfterUpdate-original /bin/sh
$ docker commit 40c4ffc128c8 busybox:TestPsImageIDAfterUpdate-updated
$ docker inspect 40c4ffc128c8 | grep -i image
        "Image": "busybox:TestPsImageIDAfterUpdate-original",
    "Image": "8c2e06607696bd4afb3d03b687e361cc43cf8ec1a4a725bc96e39f05ba97dd55",
$ docker images | grep busy
busybox                              TestPsImageIDAfterUpdate-updated    463f1c28e186        18 minutes ago      2.433 MB
busybox                              TestPsImageIDAfterUpdate-original   8c2e06607696        13 days ago        2.433 MB
busybox                              latest                              8c2e06607696        13 days ago         2.433 MB

That's bad because the Image should be 463f1c28e186 not 8c2e06607696.  I believe this is a problem with the code that commits a container and is not updating the ImageID appropriately

The issue that @didip and I were reporting (which I think is the same as @luzifer's issue) which is that when an image name/tag move due to a docker pull, you end up with the tag remaining attached rather than the bare ID like this:

Image exists as busybox
I start up a container
docker ps shows my image as busybox:latest
busybox is outdated and I do a docker pull which updates the image
docker ps shows my image ID as 2485b0f8995167b796a7ab4696e842c08bd27d58febb3ba0e935a4e2c1b2807d:latest

That image should be 2485b0f8995167b796a7ab4696e842c08bd27d58febb3ba0e935a4e2c1b2807d . This I believe is a display issue with the code I linked earlier.

 If so, should we try to get that merged, then either create a new issue or clean this one up to be explicitly about Issue 2? Having the two simultaneously being discussed in #12595 is boggling my mind.

@thieman, going to validate your code with our issue now.

Confirmed, @thieman's PR #12918 solves issue (2) above. but this code, like the code committed in #11895 changes the behavior vs 1.5.0 of images that do not have a tag. The old behavior would append :latest and that is no longer the case. @LK4D4 was the change to displaying long image ID's intentional, or is that also a bug?
@thieman I'll try to work up an integration test to validate (2) and submit a PR on yours

@relistan A note on your comment illustrating the two issues: your steps in issue 1 are not reflecting my test case. You need to overwrite the busybox:TestPsImageIDAfterUpdate-original image, but in your third line you are creating the -updated image. My step uses a tag -f to do this after using the commit to create the -updated image.
Your issue is showing that the image value in ps remains the original tag. I think this is probably fine since that original tag is still valid, and that is after all the tag with which the image is created. That's more of a design question, though.

I know I just said this was a design decision, but based on a reading of the commit documentation I do not think it makes sense for the running container's ImageID to be changed after a commit. The --change option indicates that it applies Dockerfile commands to the image that is created. These commands would cause your new image to diverge from what is actually running in your current container. As such, it would be false for the running container to then indicate that it was based off of your new image.
https://docs.docker.com/reference/commandline/cli/#commit

I am seeing this problem with docker version 1.8.1 and api version 1.20.
A first container listing after creating the container had the correct image name and tag in the "Image" property. However, in a another listing less than a second later, the "Image" property had changed to the image id and continued to be the image id in subsequent listings. For me the only workaround is to use labels to keep track of the container's image name and tag.

It seems that either I do not have rights to reopen this bug or it cannot be reopened. Should I create a new one?

@dteeter the referenced PR that closed this issue was included in docker 1.9
Please do not create a new bug, it is already fixed.

OK, thanks for the info


Feature/sms logger

Coverage decreased (-7.06%) to 39.055% when pulling 48a80dcc169aa622318ffe84a7ab9c992a98ea2b on u9520107:feature/sms-logger into 1b24a293837bc7a4c11197f5d8e14357c2657c06 on ringcentral:master.

Coverage decreased (-7.06%) to 39.055% when pulling 7d60dd283e19d2e260e31ab6d2c07505b41cc273 on u9520107:feature/sms-logger into 1b24a293837bc7a4c11197f5d8e14357c2657c06 on ringcentral:master.

Coverage decreased (-7.06%) to 39.055% when pulling 53401646ed9fb3ed8139da8da6612cbae34246d6 on u9520107:feature/sms-logger into 1b24a293837bc7a4c11197f5d8e14357c2657c06 on ringcentral:master.

Coverage decreased (-7.06%) to 39.055% when pulling 53401646ed9fb3ed8139da8da6612cbae34246d6 on u9520107:feature/sms-logger into 1b24a293837bc7a4c11197f5d8e14357c2657c06 on ringcentral:master.


Tree view scrollbar and scrolling are disabled

When the tree view is open in Atom Material theme, scrolling vertically and horizontally using mouse scroll wheel, touchpad, or keys does not work. The scrollbar is also not visible.
I believe I have verified this is an issue with Atom Material theme. Tree view scrolling works when switching to any other theme. It also works when Atom is opened in Safe Mode.
Reproduction Steps:

Open Atom tree view
Ensure Atom Material theme is enabled
Try to scroll in the tree view pane

Expected behavior:
Tree view should be, and used to be, scrollable, using mouse wheel or trackpad.
Observed behavior:
It does not react to any scroll wheel, trackpad, or keys.
Atom version: 1.17.0
OS and version: macOS 10.12.15
Installed packages:
Community Packages (26)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

I added this to my custom stylesheet and it fixes it:
.tree-view {
  overflow: scroll;
}

Not sure if this is a problem for anyone else. If it's not, I guess I can close this issue, though I'm not sure why it just started happening. It may be that an Atom update messed it up - it seems like the new Dock feature made my tree view go haywire in a few other ways as well.

Did you upgrade to Material UI 2.0?

😞  No. I was looking for an "Update" button in the Themes tab in Preferences. And I tried apm update atom-material-ui with no luck. But I just ran apm install atom-material-ui and it updated and the scroll bar works.
Feeling sheepish, but in my defense, it seems like if there are updates available for a theme, the Themes tab should show that?
Anyway, thanks.

Atom shows package updates in the status bar:

Which will take you to the Updates section in settings-view

From there you can either update all packages (including themes) or just take your picks and update them individually 😄

I swear that's where I was looking and didn't see it, but it's been a long week, so 🤷♂
Thanks!


Using 'alt' to create multiple cursors and then rapidly relasing it causes the menu bar to focus, making the multiple cursors disappear

VS Code Version: 1.26.0-insider
VS Code Commit: 023b51bcc6204cc9bb9ca7752f764a3396401ec7
OS Version: Windows 10 Home 1803

Steps to Reproduce:

Enable the new menu bar
While an editor is active, press and hold alt
Rapidly click in another place to create a second cursor
Rapidly release alt (within less than a second)
If it was fast enough, all cursors will disappear and you'll be unable to type until you refocus the editor.

This is a pretty serious issue as it's very common to be typing and quickly want to create a second cursor and continue typing; I run into this every couple of minutes.

Does this issue occur when all extensions are disabled?: Yes

This is definitely related to #54065 and #53924, however it's a different bug in that it doesn't happen every time, only when performed rapidly.

@iansan5653 Sorry about that. I will fix this shortly. Fyi, until this is fixed, if you single press alt again after you focus the menu, the editor will regain focus and your multicursor selection will return.


Error message when trying to add a device

Error login command: invalid literal for int() with base 16: '0000None00001000800000805f9b34fb'

Please verificar new versión,
I think it solves now
Thanks for you reply

Nope, still same issue, sorry.
This error originated from a custom integration.

Logger: custom_components.elkbledom.elkbledom
Source: custom_components/elkbledom/elkbledom.py:504
integration: elkbledom (documentation, issues)
First occurred: 18:41:54 (2 occurrences)
Last logged: 18:42:03

Error login command: invalid literal for int() with base 16: '0000None00001000800000805f9b34fb'

Please post led strip init debug log when connect to it thanks

https://github.com/user-attachments/assets/8f5818b4-c5c4-4b09-980a-0300020e73ec
I attached a screen recording, I hope that helps


Pub deploy does not return non-zero exit status upon error

This issue was originally filed by<EMAIL_ADDRESS>
When running pub deploy on a project, any errors should cause a non-zero exit status to be returned, rather then 0. When 0 is returned even when an error happens, build errors are hidden from build systems such as make.
A non-zero exit status from pub deploy, for example, will allow running make on a Makefile to indicate a build error. Otherwise, the build looks successful even though there is an error.

This issue has been moved to dart-lang/pub#640.


(2nd) Fix long loading from public and redirect to last accessed report

Details

Fix Sign in long loading when navigating via public room link and logging in as a new account.
Reported regressions:
https://github.com/Expensify/App/issues/50549 can't replicated even when my PR applied
https://github.com/Expensify/App/issues/50560 will need separate investigation because that issue related to withOnyx migration and not directly related to the main logic in this PR https://github.com/Expensify/App/issues/50560#issuecomment-2407800395
Fixed Issues

$ https://github.com/Expensify/App/issues/48715
$ https://github.com/Expensify/App/issues/50578
PROPOSAL: https://github.com/Expensify/App/issues/48715#issuecomment-2374180125
Tests

Open app
Log out
Go to to this link / report https://staging.new.expensify.com/r/7075912447943023
Tap sign in
Enter credentials and log in as a new Gmail account
Select any option (e.g. something else)
Tap continue
Verify that the loading has finished and is not frozen.
Verify user redirection to the opened report from the 3rd step.
[x] Verify that no errors appear in the JS console

Offline tests

Same as test
QA Steps

Same as test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/7af92ba3-bb86-47f9-a12b-46adcd39e612

Android: mWeb Chrome
https://github.com/user-attachments/assets/1e093970-2678-4526-b237-493aaee36cf5

iOS: Native
https://github.com/user-attachments/assets/d21fe08d-b052-4f60-a4a5-7113595cd09f

iOS: mWeb Safari
https://github.com/user-attachments/assets/ca1f7daf-7ab3-4d7e-9456-c98f3fd77022

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b2b2c615-f69d-443e-9660-de2cbd3a91a0

MacOS: Desktop

https://github.com/user-attachments/assets/50665939-7a0b-4852-8ec2-7291a0aec9b2

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


fixed attachment bug in 8.8 server

In the future, please remember to use the new branch naming format <mod/bug>/<spr/tor/>/


The 'code' class can overlap when on adjacent lines

Example:

Hi @joelanman, can we please close this issue and instead raise it an issue with the prototype kit.


Web Map "Operations Center- SALUTE Reports" references services/layers that do not exist

Item id:67eb8bf42ecd4bd3b20677fdc788c903 references the following services/layers that do not exist:
https://nsec.esri.com/ags/rest/services/NationalIntelligence/ObservationReports/FeatureServer/0
This service only contains a single layer "SaluteReports" layer id 1.

Based on the lack of activity on this item. I am going to delete the item at 1100 today. If you think this is in error please respond by then.

Deleted @phil7277
Back to @elinz  to verify.

Verified web map in question was deleted. Closing issue.


migrate a devon4j project to the latest version

migrate a devon4j project to the latest version
What will the user learn in your tutorial?
What should the user already know when starting the tutorial?

What is the state of this PR?


Release 0.7.3

@michaelkirk Is a minor release ok, or is the reqwest update problematic?

Good question! I'm not the best semantic versioning lawyer.
But I think one litmus test is "can running cargo update break someones build" assuming they have sane version constraints like http-range-client=0.7.2
In this case, I think yes, it could break, right?
Since we're implementing traits on reqwest, and our users might have been using reqwest directly, a patch update to http-range-client could result in them getting an incompatible version of reqwest. Right?
So I think this should be a bump to 0.8.0


installer:  create shortcuts to documentation

This could point to https://github.com/ScottKirvan/UE_QuickLaunch or https://www.scottkirvan.com/UE_QuickLaunch/, or the docs could be packaged up and installed locally.
Where should the shortcut be put?  Install dir, desktop, start menu?
Maybe it could be in the right-click menu but only visible when holding the [shift] key?

done


feat: add sync piece watchdog

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Description

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1272 (ad5fbf2) into main (0ca681c) will increase coverage by 0.26%.
The diff coverage is 40.47%.

@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
+ Coverage   45.86%   46.12%   +0.26%
==========================================
  Files         135      135
  Lines       11341    11378      +37
==========================================
+ Hits         5201     5248      +47
+ Misses       5572     5558      -14
- Partials      568      572       +4

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
46.12% <40.47%> (+0.26%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/config/peerhost.go
35.15% <ø> (ø)

client/daemon/daemon.go
6.41% <0.00%> (-0.02%)
:arrow_down:

client/daemon/peer/peertask_manager.go
23.12% <0.00%> (-0.15%)
:arrow_down:

...ent/daemon/peer/peertask_piecetask_synchronizer.go
49.12% <43.24%> (+5.30%)
:arrow_up:

client/daemon/peer/peertask_conductor.go
57.26% <100.00%> (+0.04%)
:arrow_up:

cdn/supervisor/progress/progress.go
90.62% <0.00%> (-6.25%)
:arrow_down:

client/daemon/peer/peertask_piecetask_poller.go
47.10% <0.00%> (+16.66%)
:arrow_up:


Can't build hello world example

I can't build the hello world example, here's the output when I try:
col@col-laptop-asus ~/D/hello_world> npm run build

> @ build /home/col/Downloads/hello_world
> webpack

🧐  Checking for wasm-pack...

ℹ  Installing wasm-pack

wasm-pack error: undefined
Hash: 608c1f62c380f097bb9f
Version: webpack 4.39.2
Time: 1502ms
Built at: 08/16/2019 4:04:07 PM
     Asset       Size  Chunks             Chunk Names
index.html  181 bytes          [emitted]
  index.js   4.19 KiB    main  [emitted]  main
Entrypoint main = index.js
[./index.js] 290 bytes {main} [built]

ERROR in ./index.js
Module not found: Error: Can't resolve './pkg/hello_world' in '/home/col/Downloads/hello_world'
 @ ./index.js 4:13-40
Child html-webpack-plugin for "index.html":
     1 asset
    Entrypoint undefined = index.html
    [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 472 bytes {0} [built]
    [./node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {0} [built]
        + 2 hidden modules
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! @ build: `webpack`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/col/.npm/_logs/2019-08-16T20_04_07_567Z-debug.log
col@col-laptop-asus ~/D/hello_world> ~/.cargo/bin/wasm-pack --version
wasm-pack 0.8.1
col@col-laptop-asus ~/D/hello_world> cargo --version
cargo 1.37.0 (9edd08916 2019-08-02)
col@col-laptop-asus ~/D/hello_world> npm --version
6.10.3

Running ~/.cargo/bin/wasm-pack build manually seems to make it work at least...

Thanks for the report! It looks like something may be misconfigured though? There's an ominous error that says wasm-pack error: undefined, but I think the error is probably in the local configuration of wasm-pack rather than this crate itself, so I'm going to close.

I mean, what config issue would it be? I just run npm install then npm run build. What can I do to get more verbose output?

I'm not quite sure, but this may be related to installing wasm-pack since the JS extension says it's installing wasm-pack. It would probably be best to report this issue to the JS packages you're using to manage wasm-pack

It's the hello world example in this repo. It uses @wasm-tool/wasm-pack-plugin. My understanding is that that's part of this project, right?


Remove Apple hooks

This simplifies the build.

Ugh, I'm having issues with this PR.
It works if I manually add the plugin with --link. But not on a clean install and platform add from the package.json.
That's because cordova is copying the entire third_party tree following symlinks. Besides the unnecessary copies, it breaks the ios frameworks, as they rely on symlinks.
Perhaps I can change the build to call platform add --link for the outline plugin instead of loading from the config, but it starts to be hacky again...

Deprecated by https://github.com/Jigsaw-Code/outline-client/pull/1527


How to convert from SPDX 2 to SPDX 3

@goneall
The Java tools version 2 have the capability to convert from SPDX 2 to SPDX 3.
This is documented at: https://spdx.github.io/Spdx-Java-Library/org/spdx/library/conversion/Spdx2to3Converter.html
But I would like to do it in the command line, not in a Java program.
I used to do something like:
java -jar tools-java-1.1.8-jar-with-dependencies.jar Convert hello.spdx hello.spdx.json

convert from SPDX 2 tag:value to SPDX 2 JSON.
I would have expected that
java -jar tools-java-2.0.0-Alpha-jar-with-dependencies.jar Convert hello.spdx hello.spdx.json

would convert my SPDX 2 tag:value to SPDX 3, but that still converts to  SPDX 2 JSON.
Is there a way to convert SPDX 2 to SPDX 3 on the command line?

@vargenau - you can use the file extension .jsonld.json or jsonld and it will convert it to 3.0.  Alternatively, you can add the options for the from and to file types:
java -jar tools-java-2.0.0-Alpha-jar-with-dependencies.jar Convert hello.spdx hello.spdx.json TAG JSONLD

Thank you very much @goneall for your answer.
I have created a pull request https://github.com/spdx/tools-java/pull/171 to add it to the README file.

The conversion works, but I have many warnings.
[main] WARN org.spdx.library.model.v2.SpdxElement - No creation info for document Optional[hello]
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
[main] WARN org.spdx.storage.listedlicense.SpdxListedLicenseModelStore - SPDX listed license URL was used instead of the required namespace ('https:' rather than 'http:'
sept. 30, 2024 4:11:43 PM net.jimblackler.jsonschemafriend.Schema <init>
AVERTISSEMENT: No match for #/$defs/ElementCollection
sept. 30, 2024 4:11:43 PM net.jimblackler.jsonschemafriend.Schema <init>
AVERTISSEMENT: No match for #/$defs/security_VexVulnAssessmentRelationship
sept. 30, 2024 4:11:43 PM net.jimblackler.jsonschemafriend.Schema <init>
AVERTISSEMENT: No match for #/$defs/security_VulnAssessmentRelationship
sept. 30, 2024 4:11:43 PM net.jimblackler.jsonschemafriend.Schema <init>
AVERTISSEMENT: No match for #/$defs/software_SoftwareArtifact

@vargenau - I took a look at the code and the warnings above.
The schema related warnings are due to issues with the SPDX spec generated schema file which has been resolved with 3.0.1 - as soon as I update the tools, these should go away.
I wasn't able to duplicate the other warnings - if you can attach the SPDX V2.3 file you used as input, I can take a look.

Hi @goneall
Thank you for having a look at my warnings.
Input file is here:
https://github.com/OpenChain-Project/Telco-WG/blob/main/tools/openchain_telco_sbom_validator/open-source-compliance-artifacts/openchain-telco-sbom-validator-0.1.6.spdx

@vargenau - I was able to duplicate the warnings on the 2.0.0-Alpha version.  It looks like all of these are fixed with the released 3.0.1 schema and a few related fixes.  Hope to get a new release out soon after we finalize the 3.0.1 spec release.

Thank you @goneall


Adds documentation for schedulers

Closes #128.

My attempt to reflow tweaked some of the headers but it's a no-op change. Sorry about that.

Did not know about doing markdown headers this way.

My reflow-er (I use pandoc -f markdown -t markdown --columns=80 as a shell alias) does that automatically.  The following two are equivalent in Markdown:
Foo
===

# Foo


new subscribe check does not restart sensu-api service

Description of problem

What did you do?
Adding new check:
sensu::check { 'metrics-disk-capacity.rb':
type        => 'metric',
handlers    => 'relay',
command     => 'metrics-disk-capacity.rb',
interval    => 10,
subscribers => 'default',
standalone  => false,
}

What happened?
Notice: /Stage[main]/My_sensu::Default/Sensu::Check[metrics-disk-capacity.rb]/File[/etc/sensu/conf.d/checks/metrics-disk-capacity.rb.json]/ensure: created
Notice: /Stage[main]/My_sensu::Default/Sensu::Check[metrics-disk-capacity.rb]/Sensu_check[metrics-disk-capacity.rb]/ensure: created
Info: /Stage[main]/My_sensu::Default/Sensu::Check[metrics-disk-capacity.rb]/Sensu_check[metrics-disk-capacity.rb]: Scheduling refresh of Service[sensu-client]
Info: /Stage[main]/My_sensu::Default/Sensu::Check[metrics-disk-capacity.rb]/Sensu_check[metrics-disk-capacity.rb]: Scheduling refresh of Service[sensu-server]
Notice: /Stage[main]/Sensu::Client::Service/Service[sensu-client]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Sensu::Server::Service/Service[sensu-server]: Triggered 'refresh' from 1 events

What did you expect to happen?
I expect to see new check in Uchiwa dashboard. Checks appears in Uchiwa dashborafter restarting sensu-api service.

How can someone reproduce the problem?

Add new subscribe check.
Run puppet.

Command used and debugging output

What does your puppet config look like (including any hiera config)
Is this a masterless or master based puppet setup?

Platform and version information

Your OS: Ubuntu 16.04
Your Ruby version: embedded ruby
Your version of Puppet: 4.8.1
Your version of Sensu: 0.26.5-2
Your version of this module: 2.2.0

Anything else to add that you think will be helpful?
I think sensu-api should somehow subscribe to sensu::check
https://github.com/sensu/sensu-puppet/blob/master/manifests/api/service.pp#L34-L40

@jeffmccune this is similar to the other issues regarding notification of services.

Thanks for reporting @giedriusramas
@jeffmccune fix is in release v2.20.1