setDatasource() should accept a second argument for arbitrary params to pass to getRows()

Right now, calling .setDatasource(newDatasource) will automatically execute the data source's getRows() function. It would help me very much if this method accepted a second argument, such that it can be used like this:
const ds = {
  getRows(params) {
    // params.foo is now accessible as 5
  }
};

gridOptions.api.setDatasource(ds, {foo: 5});

I also would love to have this second param very much.

isn't this unnecessary?
why not just provide the data to the datasource yourself before you pass the datasource to the grid?
function MyDatasource(foo) {
  this.foo = foo;
}

MyDatasource.prototype.getRows = function(params) {
  console.log(this.foo);
}

This is what's currently being done as an alternative to pass the second param, but since the foo is not available when DataSource being constructed, and it's quite ugly to dynamically append some random event data to the dataSource instance. Providing it as the second param will make much cleaner code.

i have added context to the datasource getRows params. so just items into the gridOptions.context object and you will be able to access now. this is in line with how other parts of the grid work.

Great! Thank you @ceolter, will wait for the next release version.


Fix import of CSS modules

Currently, during import of CSS module in source code HQ server throws error. The reason for that is using nonexistent method escapedname from Node.js core module querystring. I suppose, that expected method is escape

Thanks @underoot, I have no idea how did it get there. Seems like some unsuccessful refactoring.


Cognitive services documentation uses the old API

Please update the documentation to use new Azure.ResourceManager.CognitiveServices API.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 439b7fcb-ffb2-bc2d-d781-6f6ddf54a216
Version Independent ID: 78b05c0c-e370-b55f-3255-fa545eeceae1
Content: Create Cognitive Services resource using Azure Management client library - Azure Cognitive Services
Content Source: articles/cognitive-services/cognitive-services-apis-create-account-client-library.md
Service: cognitive-services
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@klinki
Thanks for your feedback! We will investigate and update as appropriate.

@PatrickFarley
Could you please review add comments on this, update as appropriate.

@klinki
Thank you for bringing this to our attention. I've assigned this issue to the author who will investigate and update as appropriate.

Not sure why there's a new API path. Asking gc about it

Will use the new APIs. Updates are scheduled for next sprint
#please-close


Absent GRUB_CMDLINE_LINUX_DEFAULT can result in duplicated kernel parameters.

When using grub2 the initial state in /etc/default/grub includes:
GRUB_CMDLINE_LINUX populated
GRUB_CMDLINE_LINUX_DEFAULT absent
Used:
kernel_parameter { "pci=nomsi,noaer":
    ensure   => present,
    bootmode => "normal",
}

results in GRUB_CMDLINE_LINUX_DEFAULT being copied from GRUB_CMDLINE_LINUX and then massaged by the lens.
The resultant kernel boot line includes duplicate entries. According to the grub2 manual (https://www.gnu.org/software/grub/manual/grub/grub.html):
‘GRUB_CMDLINE_LINUX_DEFAULT’
    Unless ‘GRUB_DISABLE_RECOVERY’ is set to ‘true’, two menu entries will be
    generated for each Linux kernel: one default entry and one entry for recovery
    mode. This option lists command-line arguments to add only to the default
    menu entry, after those listed in ‘GRUB_CMDLINE_LINUX’.

Desired behaviour is for GRUB_CMDLINE_LINUX_DEFAULT to not being populated from GRUB_CMDLINE_LINUX as they maybe concatenated when generating the grub.conf

@trevor-vaughan I see you code that part in https://github.com/hercules-team/augeasproviders_grub/blob/master/lib/puppet/provider/kernel_parameter/grub2.rb#L88-L108, what's your take on it?

Interesting. This may be a RHEL quirk that I ended up testing around. @sandynomad What OS are you working against?

The behaviour reported was on CentOS 7.5.

@trevor-vaughan 	were you able to reproduce?


@Encrypted Support in POJOs for Aggregation Pipeline

Hello ,
I'm using an aggregate pipeline in MongoDB and have a POJO class to represent the results. Projection involves a class with encrypted fields.
I tried using @Encrypted in the POJO class, expecting automatic decryption during aggregation, but its getting only Binary Data only.
If there's an existing solution or workaround, kindly provide guidance. Thanks!

Hi!
Thanks for the report. Some operations are not supported, since they do not go through the 'normal' spring-data save/load events.
This is one of those. There is no actual 'save' or 'load' event sent by spring-data-mongodb, however, there seems to be a way to register for conversion to cover this case too.
I'll need to take a deep dive into how to make use of the BeforeConvert/AfterConvert events in spring-data. And also add coverage for mongoTemplate.aggregate() in the test suite. If you feel like it, feel free to peek into this, or else I'll try check this out.


Light2D Error/Warning when loading light texture

Godot version:
Godot 3.1 alpha 4
OS/device including version:
Windows 10, GeForce GTX 1070
Issue description:
Light2D gives out warning when loading a light texture.
Steps to reproduce:

Start new project
Create Node2D scene
Add light2D node
Load light texture

CC @DualMatrix, looks like we forgot about comma-separated type hints in #22437.

Yup that seems to be the case, I'll see what I can do


Variable importance using extraTrees

How can I get the variable importance matrix (mean decrease in impurity GINI) for all the predictors used to train an extraTrees model. I'm looking into the R package but I didn't found any function to retrieve the variable importance matrix.

Unfortunately, it is not implemented. I think it should be straight-forward to implement but currently I am lacking time.
All contributions are welcome.


ERR_CONNECTION_RESET

Getting ERR_CONNECTION_RESET in Chrome. Error in the terminal is unsupported operand type(s) for +: ‘int’ and ‘NoneType'. Symptoms occur after clicking accept on the google oauth page. @soumyabasu , @Sumukh , any ideas why this might happen?
@colinschoen knows more details.

Is this a duplicate of #90?

Does the terminal error report a line number and file for the exception?

I'll get details on this @papajohn

@jeffreylu017 - I've seen this happen last semester without the SSL error.
My guess is that the local server is terminating or crashing (silently?) somewhere during the redirect.
The terminal error isn't too interesting - it happens anytime we don't get a token.

@papajohn  -- If this helps...

@Sumukh I have no idea if this even helps; it doesn't address the issue, but it at least stops the whining? #95

@colinschoen - can you put me in touch with the student?

Hi @soumyabasu. I will email you the students contact information. Thank you for following up.

Resolved (I hope) by #256 or other changes that have happened in the past year and a half. We'll see in the coming semester.


Vectara integration

Description
Integration of Vectara with Llama_index.
Type of Change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] Added new unit/integration tests
[X] Added new notebook (that tests end-to-end)

Suggested Checklist:

[X] I have performed a self-review of my own code
[X] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works

exciting!

@jerryjliu - for sure. Let me know your thoughts:

Vectara is not just a vector database, as you may know, so includes additional functionality out of the box.
For example when you index text, it's automatically broken down into "chunks" in the backend. So I wasn't sure how to deal with the inherent "nodes" in LI. See the current initial proposal in this where add_documents instead of the usual add(). Would love your guidance wrt if this is the best way given current design of LI.

@jerryjliu - checking in on this? Any thoughts / guidance on next steps for this PR?

Yes agree #2 is more clean. Let me look into that.

So this would be a new folder (let's say "vectara") under "llama_index/indices", similar to say "list" or "tree" that has base and retreivers like the other types of indices? Just making sure that's what you had in mind...

(Whoops, this got rather long, sorry about the wall of text LOL)
@ofermend Well actually, what I had in mind was slightly different.
So what I was originally thinking was that llama_index/storage/docstore would have a new file for vectara, to handle the add_documents feature. Then llama_index/retrievers would have a new file for retrieving from an existing vectara index. Code flow might look something like this?
documents = SimpleDirectoryReader("./data").load_data()

docstore = VectaraDocStore.add_documents(documents)

# this could take a docstore, or just parameters to connect to an existing index?
retriever = VectaraRetriever(docstore=docstore)

# use as a retriever for fetching nodes?
nodes = retriever.retrieve("query")

# use as part of a query engine for synthesizing natural language answers
query_engine = RetrieverQueryEngine(retriever)
response = query_engine.query("query")

Although thinking on it a bit, there is another option 🧠
So the thing is, we want to keep things as general as possible. For example, having an index specific to vector that doesn't act anywhere near other indexes feels a little out of place? For example, this index would not be using the storage context (docstore, vector store, or index store), which might be unexpected for users?
But on the other hand, what if there was a new category of index -- APIIndex (? that's a terrible name lol), that was something that we could extend to other services that act more like an index (vectara, marqo, and I'm sure others). This index class could then be extended for vectara then. Although, I'm still not sure if it could actually extend our BaseIndex class, or if it would have to be its own base class?

@logan-markewich - yes agreed (and thanks; this is helpful discussion as you have more expertise on the llama_index architecture and design than me).
I think what you suggest is best, and that's actually what I had in mind, I was just not aware of others that could fit this category - so generalizing makes a ton of sense.
Perhaps I can suggest "ManagedIndex" (meaning it's not stored locally and used via a managed service accessible via an API).
If we go with that:

It's similar to what I was suggesting, only instead of a new "vectara" folder for a new type of index, we generalize to "Managed" under /indices and build that initial baseline
Then vectara would be the initial ManagedIndex (or whatever we choose to call it); where would you suggest we put that specific implementation of a Managed Index?

@ofermend yea so in my mind, I thiiiink it would look something like this (undecided if the base class is actually needed or not, or if extending BaseIndex flat out could work?
llama_index/
|_ indices/
    |_ managed/
        |_ base.py -- some kind of base class to extend?
        |_ vectara/
            |_ base.py -- actual index
            |_ retriever.py -- specific retriever for vectara

With this setup, you could still do index.as_retriever() and index.as_query_engine(), as well as use the query engine/retriever in our other abstractions 👍🏻
Also very relevant, I can probably point this PR in the same direction once this is merged https://github.com/jerryjliu/llama_index/pull/7023
With more than one managed index, it makes sense to make this it's own category

Thanks. That makes sense - sorry been busy but hope to get to do this in this manner soon.

No worries, sounds good!

@logan-markewich - just submitted https://github.com/jerryjliu/llama_index/pull/7423
Please take a look and let me know if this is roughly what you had in mind for Managed Index.


[Draft] :sparkles: [#65] Add group_mapping functionality

issue: https://github.com/maykinmedia/mozilla-django-oidc-db/issues/65
TODO:

[ ] better field/widget choice?
[ ] tests

[ ] 1 group maps to 2 django groups
[ ] 2 groups map to 1 django group
[ ]

closed since we don't need this functionality


RecordSubscription action=create doesn't have unknown data fields

pb.collection("carousel").subscribe("*", (data) => {
   console.log(data.action, data.record)
})

in http response it has unknown fields but missing in data.record

I'm not sure that I understand what do you mean.
The Record model is not generated!, aka. meaning that your specific collection fields will not be part of the model TS declaration and will be a dynamic prop. The dynamic part is allowed by the [key: string]: any declaration in BaseModel.
If that's not what you mean, please elaborate and I'll investigate it.
Side-note: please also check https://github.com/pocketbase/pocketbase/discussions/3134.

If by "unknown fields" you mean custom and non-collection fields set server-side in a Go/JS app hook and enabled with record.UnknownData(true) - then No, they will not appear in the realtime event since we always create a "clean copy" of the record state before broadcasting it without expand or any other custom data (this is because we don't know if the clients have permission to view them).


Installing casks from a URL

Cookbook version
4.3.0
Chef-client version
13.6.4
Platform Details
macOS 'High Sierra' 10.13.2 (17C205)
Scenario:
Installing a cask from a URL fails
Steps to Reproduce:
Trying this fails from a Chef cookbook:
homebrew_cask 'https://raw.githubusercontent.com/caskroom/homebrew-cask/3c3268942ff163d917245fbc68d26a5bcddf91de/Casks/virtualbox.rb'
Expected Result:
It should install. The (raw) command itself works:
/usr/local/bin/brew cask install 'https://raw.githubusercontent.com/caskroom/homebrew-cask/3c3268942ff163d917245fbc68d26a5bcddf91de/Casks/virtualbox.rb'
Actual Result:
The error reported is:
================================================================================
Recipe Compile Error in /Users/paul.hanssen/.chef/state/cache/cookbooks/sf_macos/recipes/developer.rb
================================================================================

Chef::Exceptions::ValidationFailed
----------------------------------
Option name's value https://raw.githubusercontent.com/caskroom/homebrew-cask/3c3268942ff163d917245fbc68d26a5bcddf91de/Casks/virtualbox.rb does not match regular expression /^[\w\/-]+$/

I believe the error occurs in the 'cask.rb' resource i.e.
property :name, String, regex: %r{^[\w/-]+$}, name_property: true # ~FC108

Is there a particular reason not to specify the cask by name since you're just pulling that from the standard source? We use the name for idempotency checks so we can't just use the URL. We still need to know the name.

Oh I see you're installing the older version. I think what we'd have to do is something like this
homebrew_cask 'virtualbox' do
cask_def_uri 'https://raw.githubusercontent.com/caskroom/homebrew-cask/3c3268942ff163d917245fbc68d26a5bcddf91de/Casks/virtualbox.rb'
end

Thanks @tas50  ... I'll close this now.


chore(ci) limit test runs for push events

This should reduce duplicate test runs (example)

Hmm, so #5977 has been brought to my attention, and it seems that running tests on all branch activity is something we don't want to give up, so maybe this isn't that simple.
Ideally we would be able to have both: test runs on each commit/push and on each pull request update, but without running 2x the tests for the same branch+commit, but GHA doesn't make that easy.

@gszr Can you please take care of merging this one in?

@flrgh You should be good to merge this one.


Paginate chooser modal page listings like standard page listing

The standard explorer listing is paginated at 50 items to prevent particularly huge sections of the tree (e.g where a bulk import has taken place) from trying to render X-thousand results on one page.
The page chooser modal however is not paginated, but adding pagination is limited by what the pagination include can do (See https://github.com/torchbox/wagtail/issues/507) as it can't support the page_type query parameter.

A client site currently has 1916 pages under a particular section. It's taking a very long time to load. It would be good if we could address this in the near future.

A client site currently has over 100000 pages under a particular section and the page chooser doesn't load at all.


MSID: 96013 Version: 2 DOI: 10.1101/2<IP_ADDRESS>8981

MSID: 96013
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>8981
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96013
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8981

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96013v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>8981
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96013/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

error: [junk-character-presence-3] p element contains a junk character '□' which should be replaced or deleted.

Waiting for peer review update


Update Docs and Manifests for v0.20.0

Added v0.20 references to README
Update k8s manifests with v0.20.0 references

/kind documentation
/assign @damemi
/cc @ingvagabund @lixiang233
Probably should not merge until the day of the v0.20.0 release. Therefore adding a hold.
/hold.

/lgtm


pkgs: add consideration for new packages

Nixpkgs is not your personal depot. Add a light decision-making
framework to help decide what fits in the project or not.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

For Nixpkgs that had releases less stable than the average state of unstable for a few years to pretend that not having versioned releases is always a sign of instability is both disconnected from reality and hypocritical

Was the personal attack necessary? I agree that there are some cases where packaging an unreleased version makes sense, but generally speaking, it's a good signal that the project is not ready to be used. I could change the wording to leave more room for interpretation or add some explicit exceptions.

Was the personal attack necessary?

Was it really the attack? I think we should be more careful not to lose at least the implications of our own experience, as we don't always have access to interpret fully the experience of other projects.

generally speaking, it's a good signal that the project is not ready to be used

Given that the packages I trust most to keep working are often the no-versioned-releases-ever ones, if we want to ask for some property, we should start with stating the property and not just put a pretty unreliable proxy in its place.

Giving examples may be interesting, not sure how feasible this may be.

Alright, I believe I have addressed all of the points. The only remaining one is the tonality point by AndersonTorres which I don't really know how to solve.

I'm no nixpkgs contributor, but speaking from my years as Arch maintainer.
The tone is fine. Adding packages is "easy", it adds additional complexity for the distribution as a whole and removing them is "hard".
The bar to include something should always be there and people adding new packages should ask them self "is this only for me, or is this actually useful" before including new things.
If you add poorly maintained projects, someone down the line is going to be want to support newer compiler/dependency targets and be stuck on the poorly maintained project. This work requires effort that not everyone is.
Having a repository of all software in the world, with a complete dependency chain is an impossible job to maintain with an ever increasing amount of complexity.

The bar to include something should always be there and people adding new packages should ask them self "is this only for me, or is this actually useful" before including new things.

Understandable.
On the other hand, to cite a personal example, I was the only one interested in packaging yet another clunky Mplayer fork. Certainly mpv is useful for many people, indeed there are many other people that keep it along with me now. However in the start it was merely another video player, useful only for me.

This work requires effort that not everyone is capable of committing.

Then it should be about accountability. The person should be committed to keep the package first and foremost.

There is also a catch-22 if we ask packages to be popular before they can get packaged. That's why I didn't want to write those down as hard rules.
Ultimately it's a negotiation that you have to do with yourself. What matters to me is that (1) those points are considered when doing so. And (2) that they can be used in the conversation if somebody else has a different viewpoint. That more or less we have a general understanding of what is valid to package.

On the other hand, to cite a personal example, I was the only one interested in packaging yet another clunky Mplayer fork. Certainly mpv is useful for many people, indeed there are many other people that keep it along with me now. However in the start it was merely another video player, useful only for me.

This is not a big deal in the NixOS ecosystem, you can start as a NUR, have people be interested in it, promote it to nixpkgs when you figure out a lot of folks are interested in.
Sure, we suck at package discovery across the whole universe with NURs…


Skip sending vertices when they are out of the region

Inspired by https://github.com/hajimehoshi/ebiten/issues/1130. In theory, we can skip sending the vertices to GPU if they are out of the region. I'm not sure how efficiently we can do it.

Idea: Calculate a circumscribed circle of the region rectangle and a circumscribed circle of a triangle, and see whether those circles are excluded or not.

Ah, in the Pixel version, rendering onto the screen happens only when necessary, maybe?
https://github.com/jrcichra/gollercoaster/blob/62570d8957c033fe121c111bc883e7df919eb24a/game/game.go#L111-L127

Yeah and camera movement in pixel, it was easier for me to move around without redrawing.

Because of this line not taking any time: https://github.com/jrcichra/gollercoaster/blob/62570d8957c033fe121c111bc883e7df919eb24a/game/game.go#L129

Thanks!

Yeah and camera movement in pixel, it was easier for me to move around without redrawing.

Ebiten doesn't have a mode not to clear the screen at the beginning of a frame. I'll consider this.
For the camera movement, Ebiten can do a similar thing by (*GeoM).Concat. I think this is a more suitable solution for Ebiten than introducing a global matrix.

Actually I didn't realize Ebiten does this, but this is normally not needed. If you use a tile map, then this will cover the background completely. Clearing the screen at the beginning of the frame should only happen if the back ground is set to a solid color or similar.

I have a commit that adds isClearingSkipped and SetClearingSkipped. Would you like me to PR?

Yes, I appreciate it!
I prefer the name IsClearingScreenSkipped and SetClearingScreenSkipped.

At the moment this is how it's implemented.
if game, ok := c.game.(interface{ Draw(*Image) }); ok {
	if !IsClearingSkipped() {
		c.offscreen.Clear()
	}
	game.Draw(c.offscreen)
}

Is there any other clear instruction that should be skipped? I noticed that there were a couple of them in uicontext.

There is one more c.offscreen.Clear() call for Update.


Compatibility with bootstrap modal

When editing content that is inside bootstrap modal, editable plugin removes every single div that have class"modal".  Is this normal plugin behaviour or Its a bug?

https://github.com/rainlab/editable-plugin#proof-of-concept
This plugin isn't really meant for production, so probably a bug. Note that we don't actively use or maintain this plugin either


skip failing proxy test for upstream

After switching scylla address ip range to 127.0.%d. TestDiscoverViaProxy fails.
Disabled this test for upstream before it is fixed. Raised an issue for fixing: https://github.com/scylladb/gocql/issues/146

@soyacz we don't have a way to skip via the matrix code ? i.e. from command line or such ? handling it via patches gonna be painful on the long run

@soyacz we don't have a way to skip via the matrix code ? i.e. from command line or such ? handling it via patches gonna be painful on the long run

I would open an issue of having that
looks like recently go got such a feature:
https://github.com/golang/go/commit/e4a2c38af5bdae12591004c3d35762d23da7a9bd

@soyacz we don't have a way to skip via the matrix code ? i.e. from command line or such ? handling it via patches gonna be painful on the long run

I would open an issue of having that
looks like recently go got such a feature: golang/go@e4a2c38

I was looking in the past, but resigned after seeing some post it is not supported...
I just verified manually, it works. I'll change this PR with this approach.

I tested it here: https://jenkins.scylladb.com/job/scylla-staging/job/lukasz/job/gocql-driver-matrix/25/
anyway, it's merged ;)


Fix reading of NaN and Infinity

This patch fixes a bug which caused spark-redshift to throw NumberFormatException when reading NaN or Infinity from Redshift.
This patch fixes the bug by adding special-case handling of the string constants nan, inf, and -inf, which are the values sent back by Redshift during unloads. Note that we still do not support loads of NaN to Redshift since Redshift itself does not seem to support this yet (https://forums.aws.amazon.com/thread.jspa?threadID=236367).
Fixes #261.

Current coverage is 89.44% (diff: 100%)

Merging #269 into master will increase coverage by 0.09%

@@             master       #269   diff @@
==========================================
  Files            12         12
  Lines           648        654     +6
  Methods         557        526    -31
  Messages          0          0
  Branches         91        128    +37
==========================================
+ Hits            579        585     +6
  Misses           69         69
  Partials          0          0

Powered by Codecov. Last update f256b68...076d197


godot_basis_get_elements needlessly requires this pointer to be mutable

https://github.com/godotengine/godot/blob/3971bd41bb274c7f999801d74863746cd4546128/modules/gdnative/gdnative/basis.cpp#L174-L181
Noticed this when building my Rust binding, but totally forgot about it. The GDNative headers accept a mutable godot_basis* as this pointer for this function, whereas the documentation, the function's name, and its actual implementation tell that it should be const godot_basis* instead.
A small change, but a change that will make borrowck of Rust very happy. =)
Currently I am mem::transmute-ing my immutable &Basis reference into a mutable *mut godot_basis pointer, because I know that the underlying data won't be mutated. However, this is very, very bad Rust.

cc @karroffel

Oh yes, most likely an error made by spending too much time wrapping code all day, that was a horrible stage of development 😄
You're right, it should be const. I'll change it once I'm home again, until then unsafe is your friend.


Library scenarios

Got a great end to end scenario for using SharePoint libraries? We could establish some community practices and patterns.

Thanks, @tomresing. First issue! One thing this shows me is that I need to build an issue template like the other projects have.
Is this a real gap in the current documentation you'd like to fill? (Or is it an "Is this thing on???"?) If so, I can try to find someone to write something up.

 And, I agree on the template. Great idea.
Unless you know of content like this (there's a huge set of content on libraries), I think it's a real gap.
Do you agree that the perspective of SharePoint practitioners is value for real world patterns and practices like this? I feel like this is the right type of thing for this group.

The template here might work https://github.com/SharePoint/sp-dev-docs/issues/new

Just checking. Let's see if we can get some content going for this.
I just created a new issue template. Take a look and let me know what you think.

Thanks. Template looks good.

Hi @tomresing & @sympmarc, I'll try to take this one on.

Great! Assigning to you...

Hi @tomresing  & @sympmarc, where would you suggest I put my content "/docs/basics" or "/docs/making decisions"?

@nyoung30 - Those directories were my early stab at some potential groupings. Feel free to just put it into /docs if you're not sure. We're rapidly getting to a point where we'll need to think about what other buckets we need.

Hi @tomresing & @sympmarc,
I have a first draft complete of library scenarios. I am planning on additional scenarios but more work is required on my end.
I've done this work in a "bubble". Could someone review and provide feedback? Also, am I OK to "pull" my first draft into the "master"?
Sorry for all the questions. This (GitHub) is new to me.
Thanks.
Norm

Yes. Please submit a pull request.

Tom Resing

On Sep 23, 2019, at 10:54 AM, Norm Young<EMAIL_ADDRESS>wrote:

Hi @tomresing & @sympmarc,
I have a first draft complete of library scenarios. I am planning on additional scenarios but more work is required on my end.
I've done this work in a "bubble". Could someone review and provide feedback? Also, am I OK to "pull" my first draft into the "master"?
Sorry for all the questions. This (GitHub) is new to me.
Thanks.
Norm
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@nyoung30 - you can just issue a pull request. I'm the only admin at the moment, so I can review if you'd like.

@tomresing & @sympmarc - Can you please review and let me know if this is what you were looking for? I'm happy to schedule time via Teams. Thanks.

@nyoung30 - I just read through the article. I think it's really helpful. It was @tomresing's original ask, so I'll defer to him as to whether it meets his needs.

I gave it a read through and agree it provides helpful scenarios for adding document libraries to an existing site. I really didn't have anything specific in mind, other than seeding the pool of ideas for PnP usage. In general, I'd love to see more list and library scenarios added over time. For example, with the fast growth of Microsoft Teams, scenarios may be different that interacting with sites just through the web browser. Would that change what scenarios we'd recommend?

I think I'll close this one for now, since it wasn't very specific and something new was added, which was the goal. If the community needs more ideas added to the pool in the future, I could add more.

Thanks @nyoung30 and @sympmarc!

Thanks for the feedback @tomresing and @sympmarc. I know there is room for improvement in my writing style, so feedback is welcome.
I'm looking forward to contributing more!
Thanks.
Norm

I'm hoping the community becomes active here and we get into a collaborative editing mode. :)  I appreciate you jumping in!
Veronique Palmer just did a post with a cool scenario for lists. I've asked her if she'd like to contribute. These scenario-based articles will be really helpful to people, I think - especially those newer to the platform.

p.s. I tweeted out your article the other day, but couldn't find you on Twitter. Do you have a handle there?

+1 on collaborative editing mode and twitter. On collaboration, what do you two think about the byline at the bottom of this article? I'm afraid it might discourage others to come in and make edits. @nyoung30 if you don't have a twitter account yet, I'd encourage it. Great resource for writers.


Could DAG run in ubuntu system?

Dear Mr. Xie:
Could this repo run in ubuntu?
I've download your geart job DAG and run it in matlab at ubuntu. Although the Segmentation part in the demo is running smoothly, my matlab collapse every time when Detection part is run. Is this repo running only under the windows system?
Thank you for your attention.

Hi Xingyu,
I wrote this repo in Matlab at Ubuntu, so it should work under Ubuntu environment. I am less sure if it can work under Windows environment.
I have also tested the detection part on my computer today, and it runs okay. Could you please post the error message from Matlab here?

Hi @cihangxie I'm trying to reproduce your result, could you please specify the matlab version and other system specifications that you have. I was also curious why did you use the microsoft's caffe rather than the version of caffe from author of the Faster-RCNN? I see that both have roi_pooling_layers.

The matlab version is R2014b, and ubuntu is 14.04.
You can use the Faster-RCNN version caffe, or any version of caffe which contains roi_pooling_layer.

@cihangxie Great! Thanks for the info.

I ecountered the same problem as yours! And I recommend you to install caffe with roi_pooling_layer in ubuntu. The reason why matlab crash is you do not use GPU and the roi_pooling_layer have not implemented on CPU, you can check roi_pooling_layer.cpp and find that. There is not any error information in windows, but in ubuntu, and it helps me find the problem.

@EveWYT ,hi.
I configure matlab in ubuntu.But the error also occurs.

@EveWYT Okay!So upset.
The terminal output the message:
Check failed: error == cudaSuccess (2 vs. 0)  out of memory.

https://blog.csdn.net/u010167269/article/details/50703923

@EveWYT hello,Can I get your email or wechat？

@EveWYT ,hi.
I have a good news to share.
Program debugging passed,which is the CPU version on ubuntu.
Thank you very much for your help recently.


Play/Pause keyboard shortcut does not work on MacOs Mojave

First of all, awesome app and works great!
Device/OS:

MacBook Pro (Retina, 15-inch, Mid 2014)
MacOs Mojave 10.14.2

Issue
The keyboard fn shortcut for fast-forward  ▶▶ works! it moves to the next song! (this is the same keyboard key for f9 on my keyboard)
However, The play/pause ▶❙❙  shortcut does not resume/stop the current song. Is there any reason for this, or a work-arround ?  (this is the same keyboard key for f8 on my keyboard)

Unfortunately, as far as I know, this is just doomed to be flaky until Apple ever gives us an “official” way to support the play/pause key.
I suspect you may have another app open, or did at the time you started Hermes, which also wants to respond to the play/pause key. ITunes is a common culprit. I would recommend that you try to quit iTunes or other media applications before starting Hermes.

@nriley I see, thank you, I'll close this then and try to find a solution.


sklearn using sparse data representation

I know from @glouppe that "RFs in sklearn now support sparse matrices too"
https://twitter.com/glouppe/status/660012865554903040
It would be interesting to see the results with sparse for RF and for logistic regression too. We should see  lower memory footprint and perhaps faster runs. Anyone wants to help w the code (PR)?

Good guess but maybe cruel reality, sparse matrices can reduce a lot of memory using, but No significant speedup... sklearn depends on scipy, if wanna try:
in 2-rf/2.py,  using http://docs.scipy.org/doc/scipy/reference/sparse.html  instead of pandas to create the the training matrix.

Yeah, scipy's sparse is what I was thinking/hoping someone can take a look. You could try this simplified setup https://github.com/szilard/benchm-ml/tree/master/z-other-tools with the initial python code here https://github.com/szilard/benchm-ml/blob/master/z-other-tools/2.py You could time this and also sparse and submit results here/PR.


1.16.5 If I disable artifacts, then the artifacts slot gui should be hidden

dungeons_gear-1.16.5-3.2.3.jar
I've turned off artifacts in the config. If I don't want to use the artifacts in my pack, this gui should be hidden. I'm guessing that disabling the added interface gui would probably fix the other graphical issues going on as well, where the hotbar background is no longer transparent, and the ftbchunks mini map and world map are messed up.
I like this mod and want to use it in my next modpack but the gui issues are kind of big and ruin the aesthetic i'm going for.

As mentioned in the other issue, you can now remove the bar using a resourcepack.
The enableArtifactLoot only disables the dropping of artifacts from the loottables. It doesn't actively disable artifacts completely.


Merge GO:0097278 complement-dependent cytotoxicity into GO:0006956 complement activation

Hello,
GO:0097278 complement-dependent cytotoxicity
is the readout of GO:0006956 complement activation, according to the respective definition:

GO:0097278 complement-dependent cytotoxicity: Lysis of a cell resulting from triggering of the complement cascade. An example can be seen with complement activation and subsequent lysis of a bacterial cell as a result of the binding of IgM to the cell surface followed by the binding of complement proteins to that antibody.
Has about 25 EXP annotations

GO:0006956 complement activation: Any process involved in the activation of any of the steps of the complement cascade, which allows for the direct killing of microbes, the disposal of immune complexes, and the regulation of other immune processes; the initial steps of complement activation involve one of three pathways, the classical pathway, the alternative pathway, and the lectin pathway, all of which lead to the terminal complement pathway.
Has about 125 EXP annotations

@addiehl Is that OK with you ?
Thanks, Pascale

@addiehl If you have a better definition that'd be great.
Thanks, Pascale

Give me a few days, unfortunately I have some other more pressing obligations for the rest of the day.

Proposed new definition for complement-dependent cytotoxicity:
Cell killing caused by the membrane attack complex formed following complement activation.
The proposed definition matches the existing logical definition, though we could add the MAC as a participant.
existing logical definition
cell killing
and 'has part' some 'complement activation'
proposed new logical definition
cell killing
and 'has part' some 'complement activation'
and 'has participant' some 'membrane attack complex'
The original request and definition for this term came from Randi Vita of the Immune Epitope Database @rvita #9440 and thus I want to make sure these textual and logical definitions is okay by her.

I agree with Alex that those terms should definitely not be merged. We use them in the IEDB as distinct processes. I agree with the proposed definition edits by @addiehl  Thanks

Thanks for the feedback !
Is GO:0097278 complement-dependent cytotoxicity
always 'killing of other organism' ?

cell killing
and 'has part' some 'complement activation'
and 'has participant' some 'membrane attack complex'

Those are not logical definitions - they are subclasses. I am not sure they fit the 'necessary and sufficient' criteria for being logical definitions, so I will leave them as subclasses.

Is GO:0097278 complement-dependent cytotoxicity
always 'killing of other organism' ?
No, the data is complicated but it seems that the same mechanism is sometimes deployed for killing of certain types of autologous tumor cells: PMID:28920587

And aren't there some autoimmune phenomena that involve complement-dependent killing of self? But does the restriction of GO to normal processes put these cases out of scope?

Killing of tumors by the immune system is a normal, evolutionarily selected, function of the immune system.  And some auto-immune phenomena are important parts of self-regulation of the immune system.

OK thanks, I've added the reference.

Killing of tumors by the immune system is a normal, evolutionarily selected, function of the immune system.

Thank goodness.


Make build fail if credo fails

Closes #43

Nevermind. I completely misunderstood what --strict did. My bad.


When creating and editing a user, the Role field is now a text field, and I can put whatever value I want.

User > Create New User
When creating and editing a user, the Role field is now a text field, and I can put whatever value I want.
This should be a dropdown field to choose from "Admin" and "Reporter"

This may have fixed itself. After reporting this issue, I can no longer reproduce.

I do like the solution you're proposing @igor47  👍


Running on Private OpenWhisk Cluster

Hi,
Just came across with this project, nice work!
Is it possible to use pywren-ibm-cloud with my own OpenWhisk cluster? I imagine it would require some modification, but just want to make sure it is possible before I dive deep into the repo.
Thanks!

Hi,
I was able to run ./deploy_runtime in /pywren-ibm-cloud/runtime with a few tweaks:

disable ssl verification in https://github.com/pywren/pywren-ibm-cloud/blob/915ef8bd70492eea4ddc818e258682140baf4071/pywren/pywren_ibm_cloud/cf_connector.py#L88
change the timeout and memory limit for the runtime.

But I am getting error from SSL validation failure for ibm cos, when I try to run test, or trying deploy custom runtime such as ./deploy_runtime clone python/3.5-stretch like I mentioned in https://github.com/pywren/pywren-ibm-cloud/issues/63
Thanks


fix(schedules): 4th not assigned when using autofill

:tada: This PR is included in version 2.111.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Dust cost of Old Gods not available.

Seems like the Dust cost for the cards of the latest expansion pack, Old Gods is not available:
Example:
{
id: "OG_309",
texture: "HS7-082_D",
type: "MINION",
set: "OG",
mechanics: [
"BATTLECRY"
],
rarity: "LEGENDARY",
playRequirements: {
REQ_FRIENDLY_TARGET: 0,
REQ_MINION_TARGET: 0,
REQ_TARGET_WITH_DEATHRATTLE: 0,
REQ_TARGET_IF_AVAILABLE: 0
},
race: "BEAST",
flavor: "She flitters around Ahn'Qiraj dreaming of the day she will meet a sweet prince, whom she can lay thousands of eggs with.",
cost: 5,
name: "Princess Huhuran",
collectible: true,
health: 5,
playerClass: "HUNTER",
text: "Battlecry: Trigger a friendly minion's Deathrattle effect.",
artist: "Jaemin Kim",
attack: 6
},

Really appreciate your hard work, hope to see this fixed soon!
Cheers,
Dave

Thanks! Will be fixed next time I regenerate the cards.

Amazing @jleclanche !
How often do you regenerate the cards?
Thanks for the very quick fix!

@davePlug I've regenerated the cards. Thanks for your patience.


What is needed before updating Pypi version?

As mentioned in #55, this is a volunteer effort and want to thank you for the work done.  This is by far the easier to use and fully functional library for working with BLE advertisements.
Hower, the few issues I did have I later realized were fixed in newer versions and I believe are the same as #44 and #54.  While it is true that pip can install the fixes found on master using the VCS options, the instructions in the readme.md and in sphinx documentation all say to install using pip3 install bleson.  I would like to use this in a Home Assistant component implementation which prefers published libraries and cannot find any worthy substitutes for bleson.
What can I, or anyone else in the community, do to assistant in preparing the next alpha released to be published?

I did take a look a week or so ago but it was just a look, I didn’t get anything back up and running just yet.
The link to the Google group post wasn’t public, it is now.

@WayneKeenan I truly admire the effort to have full integration testing using real hardware for the three major platforms.  Although this seems like it is a Sisyphean task.  Each OS has continuous updates to tighten security, likely limiting the ability to automate running testing on physical devices.  This is in addition to continued updated to the Bluetooth spec, which has released 5.1 and 5.2 since #21 was introduced.
May people has asked only for an update to the PyPi release.  No one reasonable developer is expecting it to be completely bug free and in fact may bugs have been fixed but still linger because it is assumed that the PyPi package is the latest version.
From previous comments, you seem steadfast on requiring unit testing but would like to provide an alternative.  Why not break python-bleson into smaller, more manageable libraries?  One for parsing, which can be unit tested using Travis-CI, and one for each OS to create the hardware level socket, which can be unit tested on physical hardware.  All independent of each other If a particular OS is particularly problematic ** cough Windows cough **, it would not prevent continued use and development on OSes that are less finicky (Linux on a Raspberry Pi for example).  Would this be an adequate compromise?  If the parsing library is no longer dependent on physical hardware for CI, myself and I would assume others would be happy to write unit tests so the burden do not fall on just you.

Although this seems like it is a Sisyphean task

I like this analogy  :-)
However, I am not sure I agree that the solution is splitting up the library in to smaller libraries. I believe there are many Python Bluetooth libraries out there doing that today. Most (all?) of them also hit the problem of how can you you reasonably test them.
One advantage that Bleson has it that it has been constructed with different "providers". These are the bits that are OS specific. My suggestions is that if a "mock" provider could be created, tests could be run on a cloud CI service. This would have the advantage of being able to cover much of the testing apart from a a small piece that can only be done with real hardware.
While Wayne gets the automated testing of different hardware up and running, if there are the volunteers, release candidates could be created and the volunteers run tests on their hardware to test release candidates with the different providers.
I do not have the answer for how to create the mock provider, but that would seem to be a better avenue for the community to brainstorm IMHO.

I'm not really steadfast on getting the entire CI hardware test-rig working as a pre-requisite, I just need to spend some time to go over what was built and figure out a minimum to port to Travis as an initial step.   Getting the release/package scripts up and running (just for Linux, without HW test) 'offline' would be a good starting point for that, for sanities sake.   Sadly, I've not had the necessary focus.
A mock provider sounds like a very good idea, thanks @ukBaz

I've released v0.1.2 to PyPi.
It has had minimal testing on my Mac (unit tests) and on a Pi ZeroW (pip install and cli observer test)
Feedback welcomed.  (I do like the Sisyphean analogy too :) )
I'll close this issue and create tasks for the Travis config and a mock provider.


Improve responsive widths and columns

At smaller screen sizes, improves the home page cards to display as a single column, and makes the content column wider.

Thanks @Princesso!


"/bin/sh: l: command not found"

I have a module that runs fine with runhaskell -Wall deltacrdt.hs but ghcid -Wall deltacrdt.hs produces only a weird error message:
/bin/sh: l: command not found

Here's the file:
{-# LANGUAGE FlexibleInstances #-}
-- https://arxiv.org/pdf/1603.01529.pdf

import           Data.List       (intersect, union, (\\))
import           Data.Map        (Map, (!))
import qualified Data.Map        as Map
import           Numeric.Natural

type FileHash = String
type ObjId = String
type ReplicaId = String
type Dot = (ReplicaId, Natural)

class DotStore m where
  dots :: m -> [Dot]

newtype DotSet = DotSet [Dot]
newtype DotFun v = DotFun (Map Dot v)
newtype DotMap k v = DotMap (Map k v)

instance DotStore DotSet where
  dots (DotSet s) = s
instance Monoid v => DotStore (DotFun v) where
  dots (DotFun kv) = Map.keys kv
instance DotStore v => DotStore (DotMap k v) where
  dots (DotMap kv) = mconcat $ map dots $ Map.elems kv

newtype CausalContext = CausalContext [Dot]

ccmax :: ReplicaId -> CausalContext -> Natural
ccmax rid (CausalContext ds) = Map.findWithDefault 0 rid (Map.fromListWith max ds)

ccnext :: ReplicaId -> CausalContext -> Dot
ccnext rid cc = (rid, ccmax rid cc + 1)

newtype Causal t = Causal (t, CausalContext)
instance Semigroup (Causal DotSet) where
  Causal (DotSet s, CausalContext c) <> Causal (DotSet s', CausalContext c') = Causal (DotSet s'', CausalContext c'')
    where s'' = (s `intersect` s') `union` (s \\ c') `union` (s' \\ c)
          c'' = c `union` c'

instance Semigroup v => Semigroup (Causal (DotFun v)) where
  Causal (DotFun m, CausalContext c) <> Causal (DotFun m', CausalContext c') = Causal (DotFun m'', CausalContext c'')
    where m'' = common
          -- common = [(d, (m ! d) <> (m' ! d)) | d <- Map.keys m `intersect` Map.keys m']
          common = Map.intersectionWith (<>) m m'
          concurrent1 = Map.filter (\d -> True) m
          concurrent2 = Map.filter (\d -> True) m'

          c'' = c `union` c'

data Obj = File      { name :: String, fileHash :: FileHash }
         | Directory { name :: String, contents :: [ObjId] }
         | Tombstone

newtype Doc = Doc (Map ObjId Obj)

instance Semigroup Obj where
  Tombstone <> _ = Tombstone
  _ <> Tombstone = Tombstone

instance Semigroup Doc where
  (Doc elems1) <> (Doc elems2) = Doc $ Map.unionWith (<>) elems1 elems2

main :: IO ()
main = putStrLn "yay"

The command line flags for Ghcid aren't the same as GHC - if you want to supply -Wall to the underlying ghci process you need to pass ghcid -c "ghci -Wall deltacrdt.hs". Otherwise the flags get interpreted by ghcid, and that means your flag list is equivalent to:

ghcid --warnings --allow-eval --lint=l deltacrdt.hs

And then it fails trying to run the l linter which doesn't exist. See --help for the full ghcid options.

How does -Wall end up expanding to --lint=l?

-W is a flag which takes no arguments.
-a is a flag which takes no arguments.
-l is a flag which takes an argument, so anything that comes after it is the argument to it.

-Walmy_lint_command would have expanded to --warnings --allow-eval --lint=my_lint_command
These are the standard rules for command line programs. In the same way that -Wall is really -W=all (although GHC doesn't quite follow the rules properly)


Start Alignment Module: Add Guard Directives

The guard directive makes it easy to add a protective step on top of a llm chain.
For example:
@Guard(restrictions=['must not talk about politics or political figures'], llm=llm, retries=1)
def call_chain():
    return chain.run(adjective="political")

This use of @Guard will ask the provided llm to check if the output of chain.run violates the restriction provided. If it does, it will retry once before throwing an error.
While writing this directive I also had to write a boolean normalization function so included that as well though normalization functions to translate llm responses into json, lists, etc would be a great feature to add as well in the future.
Still need to make some additions to the docs and test on agents not just chains. Boolean normalization is fully tested.

i like how youre thinking big and makign this its own documentation section
if you are doing that, lets split out guards and normalization into their own modules (i would actually make them separate modules in the code, because i think normalization could be used in output parsing
relatedly, i would call it output_parsing rather than normalization
For the documetnation section, lets add a how to section with examples. right now the getting started ntoebook has like five examples in it, lets split those up and have those be their own examples in the documentation

happy to help with those comments later in the week!

@hwchase17 sounds great on all those! I completely agree about the normalization- I just had to add that function to make the RestrictionGuard work. I'll open up another PR just for the normalization stuff? @BenderV you already have the parser interface, right? So is the thought is we make a normalization module that is called by the parser interface?
I'll see if I can put together the example doc tomorrow!

@hwchase17 renaming the module to "Alignment" instead of "Guards"; see @pruksmhc 's comment above. I'm putting guards as a sub-section in the alignment module.

"yp_yurilee" (not sure of github @) made the very good point that moderating user input is also a great way of guarding an application. Since guards are just directives that wrap any function that outputs a string then it should be easy to apply them to user input. ofc depends on the application but something like
@RestrictionGuard(restrictions=['must not request violence'], retries=1)
def get_user_input():
   return input()

could be very useful. We should include this sort of design in the examples and elsewhere in guard docs.

@John-Church I'm yp_yurilee :) Happy to help with docs for integrating user guards. I'm also thinking through personality alignment.

Oh ok cool!! That makes sense @pruksmhc! :)
Would love the help!! I haven't written any how-to guides yet. I think one specifically for user guarding would be amazing

@John-Church I think I'm going to need permission to push to that branch to help with documentation. However, I tried restriction guard with Streamlit and it seems to work well! Could use that for the how-to on user guards.
from langchain.guards.guards import RestrictionGuard
llm = OpenAI(temperature=0)
@RestrictionGuard(restrictions=['output must not contain violence'], llm=llm, retries=0)
def return_text_input():
return st.text_input("You:", value='')

just added you, @pruksmhc !!

And yes, @pruksmhc for the user input I think having a few streamlit examples would be great! May also be good to start with just input() though for the first few since it's what everyone knows already and it can be run easily in ipynb

@hwchase17 docs are updated, the file organization you changed around looks good to me. There are a few nice to have that we haven't added yet but could in the future, like SentimentGuard, but I think it's worth shipping with the current functionality and adding on later.


Trim down interceptable repository code

Trim down interceptable repository code
Motivation
The implementation of InterceptableTransactionalRepository is similar to interceptableRepository, but it still differed in some subtle ways, like introducing intermediary structs like * finalCreateObjectInterceptor*. This PR eliminates the intermediary structs and tries to make both repository implementations more similar.
Also added some docs to some package and public structs as I thought it would be beneficial for later on.
Approach
Refactor InterceptableTransactionalRepository to be similar to interceptableRepository by removing unnecessary code.
Pull Request status
For example:

[x] Initial implementation
[x] Refactoring

Coverage increased (+0.02%) to 89.647% when pulling 9f266b255e78a04c3e4c6f255014da39c49142ef on code-refactor into 7b66160f396ac73bc12ddb75a663fc7128301cae on master.


changing tornado debian entry to not use pip

because bloom tells me :
Key 'python-tornado' resolved to '['tornado']' with installer 'pip', which does not match the default installer 'apt'.
Failed to resolve python-tornado on debian:jessie with: Error running generator: The Debian generator does not support dependencies which are installed with the 'pip' installer.

Not sure if this might surprise some users (since version on jessie will suddenly drop).
Which is why I did https://github.com/asmodehn/tornado-rosrelease

@tfoote regarding stopping thirdparty release asap, I totally agree, but I have the issue described at https://github.com/ros/rosdistro/pull/12343#issuecomment-262171114

@tfoote  Ah just saw your reply thanks !

I can't squash merge, but squashed version is here if you need it.

The squash merge comment was for @ros/rosdistro-maintainers for the 2nd review/merge.


Fix default value of lang

As per MDN:

The default value of lang is unknown

I'm pretty sure the previous value default was actually invalid.

Upon further investigation, I think MDN is in error. The "unknown" word only appears in old W3C specs, but as literal text:

The default value of this attribute is unknown

The WHATWG spec recommends the empty string as the default.

Its value must be a valid BCP 47 language tag, or the empty string. Setting the attribute to the empty string indicates that the primary language is unknown

Yeah default was carefully chosen as I think it doesn't reject. In reality I think this is somewhat undefined behavior for this element as anywhere we expect it to be used should have at minimum a lang attribute on the HTML element.

I think for lang being a HTML attribute, empty string makes most sense to me. Intl APIs like Intl.DateTimeFormat not accepting empty string is a interop issue, but it also raises the question whether a lang is equivalent to a locale or whether they are different concepts.
As far as I understand lang='' is equivalent to locales=[], both result in "current locale" behaviour.
I submitted https://github.com/mdn/content/pull/32604 to correct MDN.


Change command name to match package, add home plug

Can you please follow https://github.com/ubuntu/snappy-playpen/blob/master/CONTRIBUTING.md?


Sync icon when downloading

Description:
We don't currently show syncing status when data is being downloaded from cloud
Should we animate the icon?

Rotate antenna would be cool

Can you please add detail of when downloading you mean.
Although animations are "pretty" counters or % are much more informative.
Animations as separate processes are deceiving as they continue "spinning" without any activity actually occurring .

Thanks for your consideration

Closing as decided not to implement as animation


use reload-css

As per https://github.com/yoshuawuyts/bankai/issues/31 instead of our custom code we should be using https://github.com/Jam3/reload-css

No need; closing!


Wait for Kubernetes API to be stable after containerd restart

And don't restart containerd unless necessary.

Closing in favor of https://github.com/replicatedhq/kURL/pull/917


Inference Only

This is a great project!!! Is have any code for inference? No need training. Thanks.

A Jupyter notebook is here https://colab.research.google.com/drive/1RVvKbp5dWn46ME5dYv_OxycRh4QKWw7x

An update to the notebook would be nice, since the version it installs does not have inpainting code yet. The checkpoints aren't directly compatible, so I'm guessing this will take a while.
They're almost compatible. '.gamma' values are changed to '.g', and the noise_scheduler variables are now children of the module noise_scheduler instead of at the top level of 'model'. There are other things that are preventing loading the older checkpoints, though, and this is a big reason the major version number increased. If you skip optimizer loading and some of the other things you may be able to update the inference model at least.
After updating everything I could find, I found that "noise_scheduler.p2_loss_weight", and "net.null_text_embed" are missing.


Update size spacing pages

Feedback from third-party proofreading service for the Size and Spacing Foundations pages.

what's happening with this PR? @mikearildbrown


bugfixes

Superseded by https://github.com/input-output-hk/cardano-node/pull/1962.
@cardanians: You've been included as a co-author on that new PR.


Soak tests

 Issue by baj0
Sunday Oct 02, 2016 at 11:20 GMT
Originally opened as https://github.dev.global.tesco.org/baj0/mewbase/issues/37

Provide a soak test suite that can be run on AWS to simulate real load for extended periods of time.

This crosses over to some degree with the perf tests in https://github.com/Tesco/mewbase-perf


Add -B (boot volume ID) to knife rackspace server create

As the commit message says:

The compute1-* and memory1-* lines of servers currently cannot currently
be created by the knife rackspace server create command because those
servers must be booted from a cloud block storage (CBS) volume.

Conveniently, @smashwilson added a :boot_volume_id option to fog's
create_server call which sets up a CBS volume based on the given image
id and assigns it to the newly created server.

This commit adds a new option, -B, to the server create command that
passes through a value for :boot_volume_id.

Since this option is explicitly for preexisting boot volumes, this
commit also makes the -I flag smart enough to know whether it should
create the server passing the :image_id configuration option or whether
it should create the server passing the :boot_image_id option.

Fixes #91.

I'm particularly curious what you guys think of the flavor.disk == 0 check to determine whether the flavor is CBS-backed only. In an earlier implementation of this, I added a third flag that was --boot-image-id, but it felt like this gem should abstract away the difference if you just want to create a server from a given image.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@tdooner

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Ping. Any news on this?

It should be ready to merge. We've been using it to provision production nodes for some time now.

:+1: I'd love to see this merged.

Any update here?

It would be nice to have some specs around this. I know we don't have a lot, but it's good to start some place :)

Also some documentation would be nice also for the README.

It would be nice to have some specs around this. I know we don't have a lot, but it's good to start some place :)

As far as I can tell, the project doesn't have much in the way of specs that test each parameter. If you would be able to point me at some examples of how you'd like this parameter tested, I'd be happy to add them.
In the mean time though, no one is able to build boot-from-volume servers in our cloud using knife, so unless there's a very straightforward path, I ask that this functionality not be used as an opportunity to start holding up PRs for test refactoring (in other words, we're desperate for this feature!).

Also some documentation would be nice also for the README.

I created PR #104 that includes these commits, and adds some documentation for the README.
Thank you for your consideration!

It would be nice to have some specs around this. I know we don't have a lot, but it's good to start some place :)

As far as I can tell, the project doesn't have much in the way of specs that test each parameter. If you would be able to point me at some examples of how you'd like this parameter tested, I'd be happy to add them.

Yep, that's the problem. With something like this we need to create a mock'd out rackspace api endpoint and confirm the changes we make get the responses we want.  I don't work for rackspace; so i don't have access to something like that, and i understand reverse engineering it would be an endeavor to say the least.
On the other hand just some simple unit tests for the different methods and portions of the gem you're changing is at least a start.  I'd love to enforce the rule no new changes without a coinciding test/change in test. But I understand that's a long way off.
Just my rationality.

Hi there --

On the other hand just some simple unit tests for the different methods and portions of the gem you're changing is at least a start.

I've looked through the changes, and there really isn't any logic until the first flavor is looked up, and that requires valid API credentials or a mocked endpoint. I thought I'd test the logic added RE: boot volume IDs, but even that requires API requests to look up which flavors require one. So I'm not really sure what else to do.
But we definitely have customers all waiting on this change, and that's why I did #104 to introduce documentation. If you can't provide any specific guidance on tests you'd like to see (even just enumerating a specific example of a test we could write now based on the changes -- I don't think you'll find any), I'm not sure what else I can do to help. It feels like this is going to just be another one of the PRs on this repo that are stagnant.

Hey @martinb3 it seems there's a wire crossed somewhere.
I talked to @mattray and it seems we've lost something in how we merge PRs and push the gem for this project. Maybe we should have a sync up on this. Can ya'll drop me an email at<EMAIL_ADDRESS>so we can set up a call?
Please don't hesitate to CC other people that we should probably sync with also.
CC: @mdarby

I'm happy to help any way I can.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@matburstorm

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

I just force-pushed a new version of this PR which excludes commits from CLA-requiring authors, so this should be good to go. I'll take a quick stab at tests, but I think we could merge this and test it by trying it.

Hi guys, Is the -B (#95) implemented after all? I really need this feature in knife rackspace.
Thanks.

@catapaicu I think @tdooner and @mdarby were going to combine efforts on this functionality. Not sure what the current status is. I'll let them respond. We should be able to move on this soon.

I just rebased the commit and resolved the conflicts introduced by the rackconnect v3 changes.
I can't verify the Rackconnect v3 changes but I was able to manually verify that there are no obvious regressions via a test of knife rackspace server create.

@mdarby Are you ready for this to go in? It looks good to me.

Please make a release of this. I would like to test it with Rackspace. Will post feedback.

Sorry -- was pulled to another project and lost this thread. IIRC we should be fine; the Rackconnect V3 stuff was pretty isolated.

:+1: merging.

Will watch CI and if it passes on master after the merge, will bump the version so it releases :)

Hi guys, Getting this error when trying to create a compute1-15 server
ERROR: Fog::Compute::RackspaceV2::BadRequest: [HTTP 400 | req-16a3051b-89f2-420b-954d-4e3c93502c43] Invalid imageRef provided. -
Not sure what it means

@m89an32d7w Are you providing a boot-from-volume image ID when you invoke the command? Would you mind opening a separate issue and providing the command you're using, as well as any special knife configuration you've made in the config file? Aside from the API key and username, of course -- don't share those with us :)


Multiple instant-fields on the same crud page.

I have an orders crud where i'm generating 2 instant fields. one for DeliveryAddressCrud and one for ShippingAddressCrud. In Both these cruds i have 2 chained fields - Country and County.
The problem is, when creating a order if i choose to add an delivery address with instant field, on the second instant field (shipping address) wont trigger select2 for County.
Basically if i click on adding new crud delivery or shipping address, always in the second modal that is triggered, the select2 won't instantiate.
I have tried making api routes unique but with no luck. Maybe you give me an idea what is generating this.
Thank you for this great package and your time.

I have found the problem and it is not from instant fields. I was instantiating 2 select2_from_ajax fields with the same name.


Readme instructions

It does seems that yarn develop is not really working:
$ yarn develop
yarn run v1.12.3
error Command "develop" not found.

Can you update the README instructions?
(It would also be cool to have something published on netfly or similar, for quick, mobile reviews)

I believe the instructions work after PR #19. Closing for now, feel free to reopen if this action was done in error :)


Controller is not starting due to flag parsing issue

The controller goes in crashloop with the following error
flag provided but not defined: -logtostderr
Usage of /tmp/___go_build_main_go:
-kubeconfig string
Path to a kubeconfig. Only required if out-of-cluster.
-master string
The address of the Kubernetes API server. Overrides any value in kubeconfig. Only required if out-of-cluster.

Fixed with #91


Freestanding config.yaml checker

Write a freestanding check script for riboviz / nextflow config.yaml file, to confirm that the complete file is specified correctly. Currently this information is specified in various different parts of the python code for the config parameters needed for individual steps of the workflow, but there is not a global check. Having a single file to check these means:

nextflow configuration is checked globally before nextflow runs, instead of giving difficult-to-find errors later in the workflow.
we can automatically check config.yaml files submitted to example-datasets repo, perhaps even with continuous integratoin.

For the latter, it needs to be optional to check for the presence of input fastq files. That's because fastq files will not be uploaded to example-datasets, only the config.yaml and annotation fasta/gff files.
@mikej888 is writing a version in groovy as part of the nextflow script, and suggested porting to python for the freestanding version, if it makes sense to have two distinct implementations?

Nextflow workflow changes, see #167, means that the Nextflow workflow can do configuration validation without running the workflow. See https://github.com/riboviz/riboviz/blob/6f8cfb40e982b3f1b60eafc857e152fe1e742e96/docs/user/prep-riboviz-run-nextflow.md#validate-configuration.

Agreed to close this ticket as the functionality is provided by the Nextflow workflow.


star position is off

Many objects' positions seem to be off. For the object with objid<PHONE_NUMBER>734491542, for example, Celeste reports its ra/dec as 0.556922/0.624469, but primary finds it at 0.557017/0.624494 . (Why does it move away from the initialization? )
The Sky Server Navigation Tool suggests Primary (and Photo on the coadd catalog) are right, and that Celeste is pretty far off. (But I don't know exactly how that web tool accounts for the PSF.) @rgiordan  Do you have time to look into this? There are other problems with the scores too, and I could use help getting to the bottom of this one. Is it strange the optimizer converges here in just 2 steps?
With PR #185, these results can be recreated with two commands:
./celeste.jl --logging=DEBUG infer-object 4263 5<PHONE_NUMBER>784734491542 .

./celeste.jl --logging=DEBUG score-object 4263 5<PHONE_NUMBER>784734491542 .  /global/homes/j/jregier/coadd_catalog_from_casjobs.fit

Yes, I can try to take a look at this.  I have some 205B to do but I'll
prioritize this when it's done.
On Tue, Mar 29, 2016 at 5:45 PM, Jeffrey Regier<EMAIL_ADDRESS>wrote:

Many objects' positions seem to be off. For the object with objid
1237663784734491542, for example, Celeste reports its ra/dec as
0.556922/0.624469, but primary finds it at 0.557017/0.624494 . (Why does it
move away from the initialization? )
The Sky Server Navigation Tool
http://skyserver.sdss.org/dr12/en/tools/chart/navi.aspx suggests
Primary (and Photo on the coadd catalog) are right, and that Celeste is
pretty far off. (But I don't know exactly how that web tool accounts for
the PSF.) @rgiordan https://github.com/rgiordan Do you have time to
look into this? There are other problems with the scores too, and I could
use help getting to the bottom of this one. Is it strange the optimizer
converges here in just 2 steps?
With PR #185 https://github.com/jeff-regier/Celeste.jl/pull/185, these
results can be recreated with two commands:
./celeste.jl --logging=DEBUG infer-object 4263 5<PHONE_NUMBER>784734491542 .
./celeste.jl --logging=DEBUG score-object 4263 5<PHONE_NUMBER>784734491542 .  /global/homes/j/jregier/coadd_catalog_from_casjobs.fit
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jeff-regier/Celeste.jl/issues/186

This is a very dim object and I strongly suspect that the trim_source_tiles
function is being too conservative when it eliminates pixels.
I can think of two solutions, and we may want a combination.  One is to
make sure that at least a certain radius of pixels around the original
object are selected.  Another is to set the noise_fraction to be a function
of the brightness of the object.  The former is easier and probably better
-- let me put together a PR.
Ryan
On Tue, Mar 29, 2016 at 7:11 PM, Ryan Giordano<EMAIL_ADDRESS>wrote:

Yes, I can try to take a look at this.  I have some 205B to do but I'll
prioritize this when it's done.
On Tue, Mar 29, 2016 at 5:45 PM, Jeffrey Regier<EMAIL_ADDRESS>wrote:

Many objects' positions seem to be off. For the object with objid
1237663784734491542, for example, Celeste reports its ra/dec as
0.556922/0.624469, but primary finds it at 0.557017/0.624494 . (Why does it
move away from the initialization? )
The Sky Server Navigation Tool
http://skyserver.sdss.org/dr12/en/tools/chart/navi.aspx suggests
Primary (and Photo on the coadd catalog) are right, and that Celeste is
pretty far off. (But I don't know exactly how that web tool accounts for
the PSF.) @rgiordan https://github.com/rgiordan Do you have time to
look into this? There are other problems with the scores too, and I could
use help getting to the bottom of this one. Is it strange the optimizer
converges here in just 2 steps?
With PR #185 https://github.com/jeff-regier/Celeste.jl/pull/185, these
results can be recreated with two commands:
./celeste.jl --logging=DEBUG infer-object 4263 5<PHONE_NUMBER>784734491542 .
./celeste.jl --logging=DEBUG score-object 4263 5<PHONE_NUMBER>784734491542 .  /global/homes/j/jregier/coadd_catalog_from_casjobs.fit
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jeff-regier/Celeste.jl/issues/186

Fixed in https://github.com/jeff-regier/Celeste.jl/pull/187


Content with iframe layout messup

[x] Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
starting from http://jsfiddle.net/JNsu6/15/ .

Example http://jsfiddle.net/d8e6svf4/
When the content contains an iframe, it add's the class featherlight-iframe automatically. I understand this is usefull when your content is an iframe, but in my case not. I have textual content that includes an iframe.
The problem for me is that .featherlight-iframe .featherlight-content has a padding: 0; this messes with my layout.
Is this a bug? Should the class featherlight-iframe only be added when the full content is an iframe?
I think it's in this part: https://github.com/noelboss/featherlight/blob/0e70f2b90b2e0f1999a4c7ff22961cc0f118e69d/src/featherlight.js#L239

I have to agree that this looks like a bug. I'll change it.

Thanks for the fix. When do you release a new version so I can use this?

My laptop is out or order and I'm travelling, I'll be back next tuesday, sorry for the delay.

Released 1.7.1, thanks again for the report


:lipstick: create an empty content development html file

Description

created directory features and pages inside the source directory.
created an empty content-development.html file inside src/features/pages
Fixes #12

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Thank you for the update and correction, I will check that in the next
issues. I guess I was just confused about the issues, but in the other
issues that I have done, I have added some html basic markups.
Thank you, Regards
A.M.K
On Mon, Oct 2, 2023 at 1:10 PM Beulah Mathenge @.***>
wrote:

@.**** commented on this pull request.
I was expecting a file with the usual html markup of a head tag and empty
body. However, you want to merge an empty file and have worked on more than
one issue. Check on this next time.
—
Reply to this email directly, view it on GitHub
https://github.com/italanta/elewa-website-html/pull/17#pullrequestreview-1652461257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6EZV4Q5I2NAT7LAN4MP2ELX5KHJHANCNFSM6AAAAAA5KLC26E
.
You are receiving this because you authored the thread.Message ID:
@.***>


Aer simulators support V2

URL to the relevant documentation
https://docs.quantum.ibm.com/verify
https://docs.quantum.ibm.com/verify/simulate-with-qiskit-aer
Select all that apply

[ ] typo
[ ] code bug
[X] out-of-date content
[ ] broken link
[ ] other

Describe the fix.
As of qiskit-aer 0.14 or later, the Aer simulators do support the V2 interface.

https://docs.quantum.ibm.com/verify/simulate-with-qiskit-aer may need some rewriting because apparently, Qiskit Aer no longer supports computing an exact expectation value (I might be wrong about this).

Ah I confused this issue with https://github.com/Qiskit/documentation/issues/1025.


Fixed typo: reponse -> response

Good catch, thanks.

I have made these changes in a branch I am working on off of development - closing this PR. Thanks for the corrections!


Personal details - Extra padding above "Address line 1" field in Address page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com.
Go to Settings > Profile > Personal details.
Click Personal details.

Expected Result:
There is no extra padding above Address line 1 field, which is the similar behavior as production and also legal name page on staging.
Actual Result:
There is extra padding above Address line 1 field.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/d5c7d550-5dbe-4fa0-9c57-5ca7028fe19e
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Personal details - Extra padding above "Address line 1" field in Address page
What is the root cause of that problem?
        {/* <View style={styles.formSpaceVertical} /> */}

We add this code to AddressForm
What changes do you think we should make in order to solve the problem?
Let's remove
{/*  */}
What alternative solutions did you explore? (Optional)

@Julesssss @srikarparsi I am available to raise a quick PR for this issue

Looks like a regression of this PR https://github.com/Expensify/App/pull/28453

Gonna demoted this to NAB since it's really small. @pac-guerreiro can you work on a fix since it seems like it came from your PR?

@luacmartins yes I can!

great! thanks!

@luacmartins done! https://github.com/Expensify/App/pull/31759

Hi, @luacmartins / @srikarparsi Could you kindly add me as C+ here for payment processing?

Payment Summary

C+ @abdulrahuman5196 $500

Upworks Job

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Regression from https://github.com/Expensify/App/pull/28453

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Not required IMO since its a minor change and already found part of deployment testing.
@jliexpensify

Paid and job closed!


Automated cherry pick of #3340: huawei & qcloud & aws bugfix

Cherry pick of #3340 on release/2.11.
#3340: huawei & qcloud & aws bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@8e6fdba). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #3341   +/-   ##
==============================================
  Coverage                ?   7.14%
==============================================
  Files                   ?     476
  Lines                   ?   77242
  Branches                ?       0
==============================================
  Hits                    ?    5516
  Misses                  ?   71263
  Partials                ?     463

Flag
Coverage Δ

#aFlag
7.14% <0%> (?)

Impacted Files
Coverage Δ

pkg/multicloud/aws/eip.go
0% <0%> (ø)

pkg/compute/models/loadbalancercertificates.go
4.47% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6fdba...678abc4. Read the comment docs.

/approve
/lgtm

/cancel

/approve
/lgtm

/approve
/lgtm


The RESX files link is outdated and its content only has a VB sample (not C# or F#)

Seems the link where RESX files leads to is outdated, because its URL contains "previous-versions/" in it: https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2008/ekyft91f(v=vs.90)
Plus, that page only seems to have a VB sample. I would expect at least it to have a C# sample and default to it (F# desirable).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afe74e14-16a6-08f7-bf4d-e8e3b0d0f0c4
Version Independent ID: f466d02e-f83f-fb32-76fa-bd010366bf41
Content: Xamarin.Forms Localization - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/localization/index.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Perhaps this link/section is more useful: Resources in RESX files?
Thanks for the feedback - we will definitely update the doc.


Update tests<PHONE_NUMBER>35

Fix issue #13. Minor updates to tests_000000-000035.
- All valid Opus test vectors now have pre-skip.
- All valid Opus test vectors now have relative_offset based on the pre-skip.
- All valid Opus test  vectors now have an EDST/ELST atom.
- Minor updates to loudness calculations for other test vectors.
- Update trun version to 0 for other test vectors.
Add decoded wav files for the test_000000-000036.

Hello ~
I have found some issues about the updated mp4 files.

Issue 1, in EDST box, there are 2 sample entries:

Segment duration | Media time  | Media rate integer  | Media rate fraction
20<PHONE_NUMBER>           1                                0
1481                      312                         1                                0
In my opinion, one entry with Media time of 312 will be enough. I am not sure what's the first entry.

Issue 2, STTS box.

I think the sample delta of first entry should be 960(just check one of the TCs, test_000026) not 648.
Even the trimming start is 312, but the encoded samples are 960 from libopus.

Issue3, missed last audio frame.

In my opinion, there is 312 pending samples which is not outputted from libopus (just check one of the TCs, test_000026),
if encoder outputs the pending samples, the sample delta of last frame is 312, and trimming end is 648.

Hello ~
I have found some issues about the updated mp4 files.

Issue 1, in EDST box, there are 2 sample entries:

Segment duration | Media time | Media rate integer | Media rate fraction 20<PHONE_NUMBER> 1 0 1481 312 1 0 In my opinion, one entry with Media time of 312 will be enough. I am not sure what's the first entry.

Issue 2, STTS box.

I think the sample delta of first entry should be 960(just check one of the TCs, test_000026) not 648. Even the trimming start is 312, but the encoded samples are 960 from libopus.

Issue3, missed last audio frame.

In my opinion, there is 312 pending samples which is not outputted from libopus (just check one of the TCs, test_000026), if encoder outputs the pending samples, the sample delta of last frame is 312, and trimming end is 648.

Can you file issues for these? Thanks!

Hello ~
I have found some issues about the updated mp4 files.

Issue 1, in EDST box, there are 2 sample entries:

Segment duration | Media time | Media rate integer | Media rate fraction 20<PHONE_NUMBER> 1 0 1481 312 1 0 In my opinion, one entry with Media time of 312 will be enough. I am not sure what's the first entry.

Issue 2, STTS box.

I think the sample delta of first entry should be 960(just check one of the TCs, test_000026) not 648. Even the trimming start is 312, but the encoded samples are 960 from libopus.

Issue3, missed last audio frame.

In my opinion, there is 312 pending samples which is not outputted from libopus (just check one of the TCs, test_000026), if encoder outputs the pending samples, the sample delta of last frame is 312, and trimming end is 648.

Can you file issues for these? Thanks!

I have raised #22 , thanks


Allow custom OPENSSL_PREFIX

I have openssl installed in<EMAIL_ADDRESS>so Makefile doesn't pick it up automatically.
Let me know if I need to change anything to get this merged 🙏

Could using pkg-config have detected your custom installation?

@thenetrunna you're right. I've updated the PR - using pkg-config fixes the issue for me, no need for OPENSSL_PREFIX.
Let me know if I should open the corresponding PR in the sonic repo 🙂

Getting there, now the error is:
Building Shoggoth (flat)...
./src/openssl/openssl.c:13:10: fatal error: 'openssl/bio.h' file not found
#include <openssl/bio.h>
^~~~~~~~~~~~~~~

@astral-matrix do you have openssl installed? what does pkg-config --cflags openssl show?

try brew install openssl

Yes openssl was already installed. I'm using 3.1.4:
DJMBP14:~ dad$ pkg-config --cflags openssl
<EMAIL_ADDRESS>

I can uninstall openssl and install a known compatible version (if 3.1.4 has issues). What openssl version are you running?

I can uninstall openssl and install a known compatible version (if 3.1.4 has issues). What openssl version are you running?

I use OpenSSL 3.1.1 30 May 2023 (Library: OpenSSL 3.1.1 30 May 2023)

@astral-matrix try to build from scratch:
git clone https://github.com/samsararider/shoggoth.git shoggoth_samsara
cd shoggoth_samsara
git checkout add_openssl_prefix
make

@thenetrunna I use OpenSSL 3.1.4 24 Oct 2023 (Library: OpenSSL 3.1.4 24 Oct 2023)
uname -mprs

Darwin 23.2.0 arm64 arm

Ok I'm gonna hold off on the uninstall because I see there are packages installed with it as a dependency

@astral-matrix do you wanna try to reinstall from scratch - just to make sure you got the right branch and all the latest commits.

Thank you, can you confirm which branch version I should download?  Just need to download, thank you

‘master‘ branch of this repository

Ok, I was able to get the make command to run but needed to fix these issues below (let me know if you want me to open another issue to track):

the make command failed with error:
ld: warning: -L path '/usr/local/lib' is not a directory
ld: library not found for -lnetlibc
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [link-objects-flat] Error 1

This is because make had to download and install libnetlibc (because it isnt a default package on macOS) and put it inside "/usr/local/lib" However the /usr/local/lib directory may not exist because macOS doesn't put anything under /usr/local anymore. The "/usr/local/include commands in the make worked because the make file has  mkdir -p /usr/local/include/* commands which created the directory.
So to fix this issue in the make script, there needs to be a check for "/usr/local/lib" and if it doesn't exist it should be created before libnetlibc is installed

After fixing above, I got the error "/bin/sh: md5sum: command not found" because md5sum is not a standard package and the make command did not have logic to download and install it if needed.

To fix the md5sum error I installed it via homebrew as part of the coreutils (this is preferable than brew install md5sum because it also installs other check sum commands):
brew install coreutils
After fixing the 2 issues above the make and make install were successful. Thank you!

Thanks for the details!
Please create a new issue to track.


Allow advisors to change contact details

Coverage remained the same at 87.288% when pulling adc7736ceea71e93943e57ada57b5e6c371c8765 on allow-advisors-to-change-contact-details into 20b5a93847c7f47053c24a64d113d3700db84e30 on master.


Add rack to runtime dependency

I'm not sure the status of this repository. So if this pull request is not mergeable now, I think we keep open this pull request.
Rails/HttpStatus cop uses rack gem as an additional dependency to display more descriptive offense messages. The runtime dependencies do not include rack because RuboCop needs the gem only for the cop.
I think we can add rack to runtime dependencies after separating rubocop-rails gem.
rubocop is used without rack sometimes, but rubocop-rails gem will be used with rails gem in most cases, so the environment includes rack already.
If we add rack, installed gems does not increase.

For reference: https://github.com/rubocop-hq/rubocop/issues/5745

This looks useful to me.

I'm not sure the status of this repository.

This repository is WIP. I'm doing a hack like RuboCop::RSpec::Inject now.
https://github.com/rubocop-hq/rubocop/issues/5976#issuecomment-433828766
I think we can release after that hack (and prepare minimal document) . When releasing, I'd like report again to @toshimaru about repository name.
https://github.com/toshimaru/rubocop-rails/issues/31#issuecomment-449617550

Thank you for your merging and describing, @koic !
Feel free to tell me if the cop has any problems such as backport.


I have inserted last new parameter from google: PRIORITY

13/08/2015
priority parameter;
aviable values: normal or high
Signed-off-by: Samuel Ventimiglia<EMAIL_ADDRESS>

Thank you all

Tell me about if yes.

Unable to enable crypto on TCP connection gcm-http.googleapis.com: make sure the "sslcafile" or "sslcapath" option are properly set for the environment.
Error on my vps, so with simple parameter fix it

Tell me when i have to close pull request, please

Unfortunately this pull request is not able to be merged in it's current form.  You adjusted the formatting on the client which changes each line and does not follow the coding standard.  In addition, you added several files that are not relevant to the project (.settings folder, .project and the additions to the .gitignore).
This pull request is also missing unit tests for the added behavior and will need to be added before a merge can happen here.


Mirror a Class ,not a instance

you see,
a Class  ,has it’s properties,but，to get it’s properties,i need init a instance.
can you support Mirror a Class directly?
like this:
let mirror = Mirror(Student)
thank you!!!

Thanks for feedback I will have a look on that


Data Science with Python : Disneyland Review Analysis

Welcome to 'DSWP' Team, good to see you here
This issue will helps readers in gaining all the guidance that one needs to know about Disneyland Review Analysis. Tutorial to Disneyland Review Analysis and how it's applied using sample code.
This issue is created on contributors request through the thread.
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly if you had used datasets, include them in "DS Datasets".
Domain : Machine Learning
Mentors Assigned : Peehu Saxena / Ankit Kumar
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your open source journey ahead. 😎

Hello, I am Deepthi M with serial number:172, Batch-5. I would like to do audio on this issue.
My approach: a detailed explanation

Issue assigned to @deepthi1107 for audio contribution


Use unified-family packages for Markdown converter and Syntax highlighter

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Does not respect version ranges

{
"version": "1.0.0",
"summary": "asdfasdf,
"repository": "https://github.com/someplace",
"license": "BSD3",
"source-directories": [
"src/."


Apply SanitizeBody to all routes and fields

Is there a way to apply SanitizeBody middleware to all express routes?
I mean something like app.use(sanitizeBody(['*']).escape())?
Also, what is the correct syntax to sanitize all nested objects? I tried app.use(sanitizeBody(['*.*']).escape()) but doesn't work.

No, there's no way to do this yet. Wildcards apply the sanitizers/validators shallowly only 😐

But can I apply the sanitizeBody globally to all express routes though?

Yes, you can.

What is the correct syntax for that? Sorry may be something obvious but I am a noob.

You showed it yourself in the first post: app.use(sanitizeBody('*').escape()) 😉
Just be sure to place it before any routes and before/after other relevant middlewares.

Maybe the problem is that I am using multer, if I add the sanitizeBody after multer, it works, otherwise it does nothing.