Weather examples don't work for newly-created OpenWeatherMap accounts

See https://github.com/domoticz/domoticz/issues/5336#issuecomment-1245132310 for this problem affecting another project as well. Basically, only the following URL works for newly-created accounts:
https://api.openweathermap.org/data/2.5/weather?lat=40&lon=-115&appid=$appid

this URL differs from the URL in the tutorial in that onecall is replaced with weather. I think the URL above should work for old and new accounts alike.
But this may break again some day as well. If OpenWeatherMap fully shuts down their 2.5 API, as the onecall API requires users to follow this process (scroll to bottom of page, reply by Uwe Jacobs), which requires a credit card and a billing subscription even though you're signing up for the "free" plan. If this tutorial eventually has to go down that path (well, an alternative should be found in that case), then users should be instructed to set their billing limit to 1000 calls so that their credit card won't get charged for excess calls.
For now, swapping out onecall for weather in the URL should work, but you may want to try this on an old OpenWeatherMap account (over a year old) and a newly-created account just in case! The result of the API call is the following, so if the tutorial uses other keys not present here, the actual tutorial contents may need modification as well:
{
  "coord": {
    "lon": -115,
    "lat": 40
  },
  "weather": [
    {
      "id": 800,
      "main": "Clear",
      "description": "clear sky",
      "icon": "01d"
    }
  ],
  "base": "stations",
  "main": {
    "temp": 296.68,
    "feels_like": 295.48,
    "temp_min": 296.68,
    "temp_max": 296.68,
    "pressure": 1014,
    "humidity": 15,
    "sea_level": 1014,
    "grnd_level": 817
  },
  "visibility": 10000,
  "wind": {
    "speed": 4.37,
    "deg": 239,
    "gust": 5.02
  },
  "clouds": {
    "all": 6
  },
  "dt":<PHONE_NUMBER>,
  "sys": {
    "country": "US",
    "sunrise":<PHONE_NUMBER>,
    "sunset":<PHONE_NUMBER>
  },
  "timezone": -25200,
  "id": 5707899,
  "name": "Rock House",
  "cod": 200
}

I know I opened this awhile ago, I had occasion to revisit this and figured I'd drop another breadcrumb. In my above comment I talk about modifying a URL in the repo, specifically I'm referring to this line in checkweather.py:
https://github.com/MathWorks-Teaching-Resources/Programming-A-Starter-Project-Using-MATLAB-and-Python/blob/e2f07ee4e6c8c87a5017a132cbb5a8747193dbfa/checkweather.py#L23
where something like the following should work:
BASEURL = '
https://api.openweathermap.org/data/2.5/weather?lat={}&lon={}&exclude=minutely,daily,alerts&units={}&appid={}'

anyways, some other changes will probably be needed in the tutorial flow, but that sums it up. You won't be able to reproduce this locally if you're using an existing OpenWeatherMap account, you'll have to try to follow the tutorial flow with a brand new account to witness the breakage.

Just to follow up, I am working on this but it is a bigger fix than I hoped because the data available in the "weather" API is much less than the data that used to be available in the "onecall 2.5" API. I'm playing with various options. For anyone who wants to keep the current flow and is willing to give OpenWeather billing information, there are still 1000 free calls/day to the Onecall 3.0 API: https://api.openweathermap.org/data/3.0/onecall?lat={lat}&lon={lon}&exclude={part}&appid={API key}
The change is that to register for access requires payment information which was not the case in 2.5 unless you went over 1000 calls/day.

Ah, yeah that's understandably a bigger fix than just swapping the calls! I imagine that probably means a complete rewrite of some of the tutorial contents. It's a bummer that an API changing out from under you like that can create so much more work. Depending on the severity of the rewrite that is necessary, I wonder whether there are more stable weather data sources to base the tutorial on? It could probably be stabilized on a historical weather data source, but I understand the tutorial might end up less "awesome" if the user can't actually plot actual weather in their zip code that way.
Thanks for the heads up about the 1000 free calls per day for those brave enough to add a credit card 😅. I'll have to try that and see how many calls the tutorial consumes per run-through. Other options might be to introduce a "run once" flag into the notebooks/project, which guarantees the API will only be hit once, caching the pulled data for local use. Or to bundle an example weather dataset which ensures the example can always be run against the sample data. But of course I understand how those solutions sort of "miss the point", because the central thesis is to demonstrate how Matlab uses Python to talk to APIs.
In any case, thanks for the update!

Okay, I finally pushed my updates. Blake, if you get a chance to try them out an make sure they work for you before we close out this issue? I'm pretty hopeful I hunted down the bugs this time, though. The new version walks through building a real app to display your results, too.

Thanks for reaching out, I'm looking forward to trying it out. Wow, it's a big changeset! I appreciate the accessibility improvement of adding alt-text to images, I didn't realize you could test Matlab on GitHub Actions, that's pretty cool.
I'll try to run through the new material over the next few weeks and check in as I go along. I've been meaning to write up a quick-reference to version-controlled Matlab/Python projects for colleagues, but I'm on a new machine and I've been waiting till 2024a to reinstall Matlab and jump through the hoops.


Fix circular transpilation

Fixes #25.
This is a dirty workaround, but I have no time now to make it proper.
The proper solution, btw, would be to make Jest understand query params
in imports https://github.com/facebook/jest/pull/6282

:

👍

👍


Modify the webgl line feature shaders.

Chrome 65 and 66 when running in xvfb with openmesa do not compute atan(0, <negative>) correctly.  Also, there are occasional int() casts that round down even when they are small integers.  These changes make image comparisons more robust by working around the atan issue (this may be the issue detailed in https://chromium.googlesource.com/angle/angle/commit/da9fb09).  I have submitted a new issue to chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=841296 to track this problem.
With this commit, the baselines were regenerated with Chrome 64, and the test strictness requirements changed in PR #792 have been reverted.  There are subtly differences between Chrome 64 and 66 (font aliasing is slightly different, and I think the other changes are because the shader float precision is subtly different, though I'm not sure of that).

Curiously, atan has issues both on Google's swiftshader and on osmesa (Mesa 17.2.8).  This changes works around the problem on both of them.


Add CI support

Need some automated CI to ensure library maintains quality

This has been completed. Travis CI support has been added


fix exception when arxml contains FRESSNESS-VALUE-LENGTH with zero.

Some ARXML files (which was provided by our clients) contain FRESSNESS-VALUE-LENGTH with a value of zero.  Currently cantools cannot load such arxml files:
  File "/usr/local/lib/python3.6/site-packages/cantools-37.1.0-py3.6.egg/cantools/database/can/formats/arxml.py", line 1047, in _load_message
    sort_signals=self._sort_signals)
  File "/usr/local/lib/python3.6/site-packages/cantools-37.1.0-py3.6.egg/cantools/database/can/message.py", line 142, in __init__
    self.refresh()
  File "/usr/local/lib/python3.6/site-packages/cantools-37.1.0-py3.6.egg/cantools/database/can/message.py", line 1272, in refresh
    self._check_signal_lengths()
  File "/usr/local/lib/python3.6/site-packages/cantools-37.1.0-py3.6.egg/cantools/database/can/message.py", line 1260, in _check_signal_lengths
    self.name))
cantools.database.errors.Error: The signal ***_Freshness length 0 is not greater than 0 in message ***.

This fixed the exception.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 94.392%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
6850

Relevant Lines:
7257

💛  - Coveralls


Remove unnecessary spacing in deno-dom doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


response.clear() may result in incorrect outputSpeech type

Calling response.clear() completely resets the outputSpeech object on the json response. If one subsequently calls response.say('This was called after clear.'), the response json will look something like this
...
"outputSpeech": {
  "type": "PlainText",
  "text": "",
  "ssml": "<speak>This was called after clear.</speak>"
}
...

Perhaps when calling response.say(), the outputSpeech type should be checked or re-assigned.

Agreed. PlainText is a subset of SSML (simply wrapped in a speech tag). Perhaps .clear() should maintain that consistency and set the type to SSML instead of PlainText as .say() automatically puts all output in SSML. I'll submit a pull request.

Fixed via https://github.com/rickwargo/alexa-app/commit/3f48cd4682b7e46e958544f94ce8b982ae24fbf6.


LinkExtension.AddLink

In my oppinion LinkExtension.AddLink does not have enough flexibility. It is not possible to set custom JSON serializer options, use other methods instead of AddMvcCore like AddControllers. This may lead to braking the existing code.
The solution could be to extract parts of LinkExtension.AddLink e.g.
services.AddSingleton<IHttpContextAccessor, HttpContextAccessor>();
services.AddTransient<HateoasUriProvider<InMemoryPolicyRepository.SelfPolicy>, HateoasSelfUriProvider>();
services.AddTransient<HateoasUriProvider<InMemoryPolicyRepository.RoutePolicy>, HateoasRouteUriProvider>();
services.AddTransient<HateoasUriProvider<InMemoryPolicyRepository.CustomPolicy>, HateoasCustomUriProvider>();
services.AddTransient<HateoasUriProvider<InMemoryPolicyRepository.ExternalPolicy>, HateoasExternalUriProvider>();

services.AddTransient<IHateoasResultProvider, HateoasResultProvider>();

so that they can be executed in user code without calling services.AddMvcCore implicitly in LinkExtension.AddLink.
Other solution may be making the classes public.

Hello @adambajguz , I'm looking into a better way to have custom JSON serialization. However, I believe this issue would be related to #18 in a way, and I'll notify you once I have some update on this one. Thanks!

@adambajguz I've registered the filters using options configuration instead of AddMvcCore to avoid breaking consumers code. It will be available in the release 3.1.1.
I will close this issue but feel free to re-open it if you have any concern.


Off-canvas submenus; awesome example uncovered; Feature request

Hiya, whilst digging around the internet, I found this gem:
http://codepen.io/designsoutheast/pen/ZYERGo
It's a working example of how submenus could be implemented into Foundation 6's offcanvas-menu. It was written with 5 in mind, but, with minor adjustments, works just fine in the new framework.
You'd want to change the class "right" to "float-right" and address submenu indentation.
.off-canvas-submenu {
 padding-left:1em;
}

EDIT
 $(".off-canvas-submenu").hide();
 $(".off-canvas-submenu-call").click(function() {
   var icon = $(".off-canvas-submenu").is(':visible') ? '+' : '-';
   $(".off-canvas-submenu").slideToggle("fast")
   $(this).parent().children().find("span").text(icon)
 });

United Nations +

Flags

Book 1

Book 2

OK, I tweaked the code to match Foundation syntax.
https://codepen.io/paxperscientiam/pen/qZjqKq
EDIT: As is, this does not work with dropdown menu.

This is cool! Should be able to use the F6 accordion in off-canvas as well out of the box.

Yup, this works out-of-the-box for F6 w/ Off-canvas and Accordion.
Here's an example:
http://codepen.io/andycochran/pen/BzxvqZ
Closing.


A Few Readme Changes

Adds a build badge
Removes the text about binaries in the Releases section (IMO, that's a given)
A minor format change

@nibanks I added the note about the Releases section to the readme only after multiple people were confused about where to download binaries. Let's keep it for now?

@nibanks I added the note about the Releases section to the readme only after multiple people were confused about where to download binaries. Let's keep it for now?

You don't think people will understand now that source is checked in, and releases have the binaries?

I don't think the source of the confusion is changed by the fact that there's a build Action. The issue is basically that it's hard to find the Releases section on github. And this time it isn't just me: multiple people have come to me like "hi I saw the github repo, but where can I get a binary?"
In fact I think there's actually MORE chance for confusion now, because there are now Action artifacts with unsigned binaries that people might try using instead of the latest signed release.

I don't think the source of the confusion is changed by the fact that there's a build Action. The issue is basically that it's hard to find the Releases section on github. And this time it isn't just me: multiple people have come to me like "hi I saw the github repo, but where can I get a binary?"
In fact I think there's actually MORE chance for confusion now, because there are now Action artifacts with unsigned binaries that people might try using instead of the latest signed release.

Ok. Brought it back. I disagree, as this is the standard way all GitHub repo's operation, but so be it. I guess there are a lot of folks not familiar with GitHub.

Yeah I agree it's annoying. I feel like I may have received these questions because this particular repo may be used by a higher percentage of non-github-proficient people. Anyway thanks for putting it back.


Added configurable grab-points

Moved standard hand offset [+/- 0.03, -0.05, 0.15] from all the scenes into the hand assets.
Added grab points to the interactable demo objects.
Implemented grab-points in XRToolsPickable.
Cleanup of XRToolsPickable script and scene to remove obsolete parameters.
Modified grab cube to use precise grab.

The hand grab-points demonstrated in this pull request support showing the hand mesh in the editor:

Once hand-poses via animations is implemented, the hand-mesh should probably show the grabbed pose.

Tester this a couple of times and it is pretty robust, so far i did not encounter any issues

I have to find some time to play with this but dang mate, this looks like a really cool improvement!

Question.
Does it allow to setup more than 2 points - example, setting 2 grab points in one position but rotated differently for each hand

Yes - the left and right grab points can be configured with the rotations/translations appropriate for each hand. The hammer pickable object demonstrates this if you set both hands to show in the editor-preview.


Bracket coloring disappears when I change settings

I'm using the extension with C++, The problem also manifests in the JSON settings files. Each time I change a setting in Bracket Pair Colorizer 2, I lose bracket coloring until I restart VSC.
Before:

Change "Show Brackets in Gutter"
Then:

All brackets have turned white, and I have to restart VSC to get the colors back. It doesn't seem to matter what setting I change. Other features like brackets in the gutter, highlighting the current scope, and BracketSelection seem to still work. It makes experimenting with colors or other settings tedious beyond comprehension.
I tried disabling all other extensions, but get the same behavior.
User setting.json:
{
"terminal.integrated.shell.linux": "/bin/bash",
"git.suggestSmartCommit": false,
"arduino.enableUSBDetection": false,
"editor.matchBrackets": "never",
"bracket-pair-colorizer-2.highlightActiveScope": true,
"typescript.format.placeOpenBraceOnNewLineForFunctions": true,
"bracket-pair-colorizer-2.showBracketsInGutter": true,
}
Extensions:
Name: Arduino
Id: vsciot-vscode.vscode-arduino
Description: Arduino for Visual Studio Code
Version: 0.3.0
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.vscode-arduino
Name: Bracket Pair Colorizer 2
Id: coenraads.bracket-pair-colorizer-2
Description: A customizable extension for colorizing matching brackets
Version: 0.1.3
Publisher: CoenraadS
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=CoenraadS.bracket-pair-colorizer-2
Name: C/C++
Id: ms-vscode.cpptools
Description: C/C++ IntelliSense, debugging, and code browsing.
Version: 0.28.0
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools
Name: Cortex-Debug
Id: marus25.cortex-debug
Description: ARM Cortex-M GDB Debugger support for VSCode
Version: 0.3.6
Publisher: marus25
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=marus25.cortex-debug
Name: Remote - WSL
Id: ms-vscode-remote.remote-wsl
Description: Open any folder in the Windows Subsystem for Linux (WSL) and take advantage of Visual Studio Code's full feature set.
Version: 0.44.2
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-wsl
VSCode version info:
Version: 1.45.1 (user setup)
Commit: 5763d909d5f12fe19f215cbfdd29a91c0fa9208a
Date: 2020-05-14T08:27:35.169Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

Yep, Happens when I change any setting. Have to restart VSCode completely.

@wapenshaw  same here

@wapenshaw  same here

Hey, its still the same but instead of restarting, I just use the "Developer: reload window" option in the command palette.
Just to be clear on what I was reporting about. If I add/remove/change any entry in settings.json, the bracket colors disappear.

Same here with bracket colors disappearing. The "Developer: reload window" trick doesn't work for me.

Sometimes, even after a restart this is still not working.
Some options seems breaking it instead configuring it 😄


doc: basic java doc and java doc maven plugin added

Description
Basic Java doc added with Java doc maven plugin
It will create a javadoc.jar file with mvn install command
To verify Java doc run ./mvnw javadoc:javadoc
Java dock verification was added with compile goal, which means if there is any issue in Java doc then the code will not compile.

Hi @nitin-vavdiya, can you update the contents of the docs to some of the key components? I think we can fix the rest as we go.

Closes #19

suggestions are fixed in new commit

I have not yet completed the review.

Okay, let me know. Will fix all  suggestions in one go

@carslen do we need an IP check? The handbook defines "project content" as any kind of content. Although this is just class documentation, it probably still falls under the >1000 SLOC rule.

@carslen do we need an IP check? The handbook defines "project content" as any kind of content. Although this is just class documentation, it probably still falls under the >1000 SLOC rule.

I did not check the hole PR, but if it is only comments, then I'd approve the PR without starting a IP-Check.

@carslen do we need an IP check? The handbook defines "project content" as any kind of content. Although this is just class documentation, it probably still falls under the >1000 SLOC rule.

I did not check the hole PR, but if it is only comments, then I'd approve the PR without starting a IP-Check.

Yes, it's only Javadoc on each class. Thanks for the help :)

@nitin-vavdiya please rebase as we've merged two branches.

@nitin-vavdiya please rebase as we've merged two branches.

done

@nitin-vavdiya please change the target branch to the develop branch

@nitin-vavdiya please change the target branch to the develop branch

there is no develop branch

@nitin-vavdiya please change the target branch to the develop branch

yes this repo directly merges into main.

@nitin-vavdiya please change the target branch to the develop branch

there is no develop branch

ahhh sorry, mixed the repository. :-/

But why is then this PR adding the following files? They should be already on the main branch.

@nitin-vavdiya seems your rebase didn't work correctly. can you double check?

Please recheck old comments from Florian, as the rebase has removed some changes.

done

@florianrusch-zf please review if your requested changes have been applied.

@florianrusch-zf ping

This can be merged now, with the understanding that we'll improve as we go.

@nitin-vavdiya please apply the requested changes from @borisrizov-zf
If they got applied, we can continue with the merge.

@nitin-vavdiya please apply the requested changes from @borisrizov-zf
If they got applied, we can continue with the merge.

Yes, changes are applied

No, the changes are not applied:

https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371742216
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371742617
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371744141
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371744665

No, the changes are not applied:

https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371742216
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371742617
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371744141
https://github.com/eclipse-tractusx/SSI-agent-lib/pull/16/files/26951b5a0fe67660f5e988c2f0243e6c6e5a9eea#r1371744665

done

build pipeline is running into a timeout while trying to pull a dependency. Will retry tomorrow

I think the Fraunhofer server is down.


Update codemirror options when the options prop changes

I just coded this blind, without testing it. It might fix #12.

looks good, @steveluscher, thanks - and sorry for the delay merging!
could use a hasOwnProperty for safety but I can add that in.


Drop 1.9.3 tests from travis

@rafaelfranca can we drop 1.9.3 tests from travis?
They are failing right now, mostly because dependencies cannot be installed for 1.9.3 anymore.

Lets fix the dependecies, but 1.9.3 needs to be in the build since this gem should support it.

@rafaelfranca Same approach for coffee-rails right?

yes


Fix integer underflow caused by missing reset of countdown.

In cases where the second clause needed for a buffer shrink was not true the countdow
would not be reset. This casused a integer underflow the next time it was going to shrink.
If compiled with debug this caused a panic.

The code seems fine, but would it be possible to make a test with a dummy inflater?

Let's make a test later and catch this in for a release


GH-3088 various optimizations for sh:or

GitHub issue resolved: #3088
GitHub issue resolved: #3097
GitHub issue resolved: #3098
GitHub issue resolved: #3099
GitHub issue resolved: #3100
GitHub issue resolved: #3101
Briefly describe the changes proposed in this PR:

Implement .equals and .hashCode for all plan nodes so that we can more easily reduce duplicates. We also add some code that simplifies nested unions, which also makes it easier to deduplicate. Deduplication makes sh:or faster since we can reduce the number of plan nodes used to calculate the relevant targets for a transaction. #3088
Related to #3088 is performance or sh:or during bulk validation. The problem boils down to skipping the target extension phase by being able to detect when we are using bulk validation and retrieving all the targets directly. We introduce a new plan node to signal bulk validation and also add some support for filtering data earlier. #3098
Similar to the simplification of nested unions, we can also simplify nested Unique (distinct) plan nodes #3099
The new XSD enum support allows us to optimise the DatatypeFilter plan node #3100
The ListBindingSet mints a new hash set every time the getBindingNames method is called, this is now cached on the first call. #3097
Even with the optimisations in #3097 it was still better to be able to provide the binding names as a set, so we introduced a new binding set with this support (in the ShaclSail code base) #3101

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

This became quite big, but it was hard to separate out everything since all this work is based on performance explorations I've been doing for the ShaclSail.

I'll add the package info.
We've included performance fixes in patch releases before as long as they didn't change or add any user facing code. With the size of this I think I would normally have considered a minor release though, but I didn't feel that it justified a special 3.8 release.
Was thinking a merge commit would be nice. What do you think?

Was thinking a merge commit would be nice. What do you think?

That's fine too, but we can also use github rebase. This has no negative consequences AFAIK because the main branch is protected, so it can't introduce any inconsistencies. With an eye on possibly wanting to do cherry picking later (if we decide we do need a 3.8 release) it would be useful to have a more linear history (and yes, I've given up on trying to come with One Merge Policy to Rule Them All).


fix: add missing contexts to blueprint api methods

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix
Ensures every blueprint method has a context parameter. Some got lost during conflicts in https://github.com/nrkno/tv-automation-server-core/pull/287

Other information:

Status

[ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

This is a 'public' api, so they should be there because they are useful, not only if they are used by our current blueprint implementation.
Additionally, the only way to log from the blueprints is via the context.logWarning and similar methods, so not having them impairs debugging when writing implementations of those methods


browse table on IBISSTORE results in  Duplicate column name 'MESSAGEKEY'

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
Reporter
JJansenvr
Screenshots
SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY (SELECT 1)) AS rnum, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL, MESSAGEKEY, TYPE, SLOTID, HOST, MESSAGEID, CORRELATIONID, MESSAGEDATE, COMMENTS, LENGTH(MESSAGE) AS "LENGTH MESSAGE", EXPIRYDATE, LABEL FROM IBISSTORE) AS x WHERE x.rnum BETWEEN 1 AND 100]
nl.nn.adapterframework.core.SenderException: [nl.nn.adapterframework.jdbc.DirectQuerySender] [QuerySender] got exception executing a SELECT SQL command: (SQLSyntaxErrorException) SQLState [42S21], errorCode [1060]: Duplicate column name 'MESSAGEKEY'
Configuration
n.a.

Environment
FF! 7.8-RC3-20221027.094320: ibis4salesforce_arrear
Running on *********** using Apache Tomcat/9.0.60
Java Version: OpenJDK Runtime Environment (1.8.0_352-b08)
Heap size: 190M, total JVM memory: 813M
Free disk space: 25GB, total disk space: 30GB
Up since: 2022-11-18 16:41:54 (2d)

Additional Environment

DBMS:
com.mysql.cj.jdbc.MysqlXADataSource@305d9b5a; user<EMAIL_ADDRESS>url [jdbc:mysql://rds.app.ibis.tst.sfdc-aws-dev.aws.insim.biz/ibis4salesforce_arrear?autoReconnect=true&trustServerCertificate=true&useSSL=true&requireSSL=true&enabledTLSProtocols=TLSv1.2&pinGlobalTxToPhysicalConnection=true] product [MySQL] product version [5.5.5-10.4.26-MariaDB-log] driver [MySQL Connector/J] driver version [mysql-connector-java-8.0.21 (Revision: 33f65445a1bcc544eb0120491926484da168f199)]

ran into this issue again, FF! 7.9-20230811.190015 is this fixed somwhere or a workaround available?


feat: supports karpenter.sh/instance-price node label

Fixes #1289 and Fixes #3237
Description
Adds a new node label to all provisioned nodes with the hourly price, in USD, that was used when provisioning this node.
How was this change tested?

make test

Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I chatted with the team about adding this and there were several concerns:

This is a pricing estimate at launch which may not be correct in a lot of situations (savings plans, RIs, stale pricing data, etc).
The price can change for spot each hour
Adding this as a label may make some user want to use this in their requirements, which I don't think is a great idea. It's also not possible as a float value.

Would adding the pricing data in the Karpenter logs when the node is provisioned be enough information?

I chatted with the team about adding this and there were several concerns:

This is a pricing estimate at launch which may not be correct in a lot of situations (savings plans, RIs, stale pricing data, etc).

I agree that this doesn't take into account those pieces, but this was intended to expose some kind of pricing information to give an estimate on costs, not be a cost accounting system.

The price can change for spot each hour

I was unaware of this.

Adding this as a label may make some user want to use this in their requirements, which I don't think is a great idea. It's also not possible as a float value.

I would agree that using it in the requirements isn't a good idea.

Would adding the pricing data in the Karpenter logs when the node is provisioned be enough information?

This would be a great start, but we'd love to be able to get this in a prometheus metric so we can do some rough pod cost calculations.
Would renaming the label to instance-price-estimate reduce the concerns?
My other idea on this was to expose the pricing.Provider on demand/spot pricing as prometheus metrics instead. This way we could use promql joins from node metrics to pricing metrics as karpenter knew at the given time. This would help with issue 2 above where spot prices can change hourly, and with issue 3 where you can't use them as requirements. It would not help with issue 1, but perhaps with clever metrics names, such as including estimate it would be clear?

My other idea on this was to expose the pricing.Provider on demand/spot pricing as prometheus metrics instead. This way we could use promql joins from node metrics to pricing metrics as karpenter knew at the given time. This would help with issue 2 above where spot prices can change hourly, and with issue 3 where you can't use them as requirements. It would not help with issue 1, but perhaps with clever metrics names, such as including estimate it would be clear?

I'd prefer to go with the prometheus metric and/or including the price in the log when the instance is launched for now.   And yes, I think naming it as price-estimate is enough information. Documentation on the metrics page can also explain why it may not be accurate.

Closing in favor of https://github.com/aws/karpenter/pull/3613


Query: Include & Order By subquery generates invalid query.

Test
[Fact]
public virtual void Include_collection_order_by_collection_column()
{
	using (var context = CreateContext())
	{
		var customer
			= context.Set<Customer>()
				.Include(c => c.Orders)
				.Where(c => c.CustomerID.StartsWith("w"))
				.OrderByDescending(c => c.Orders.OrderByDescending(oo => oo.OrderDate).FirstOrDefault())
				.FirstOrDefault();

		Assert.NotNull(customer);
		Assert.NotNull(customer.Orders);
		Assert.NotEmpty(customer.Orders);
	}
}
```
Generated SQL
```SQL
SELECT [o].[OrderID], [o].[CustomerID], [o].[EmployeeID], [o].[OrderDate]
FROM [Orders] AS [o]
INNER JOIN (
    SELECT DISTINCT TOP(1) (
        SELECT TOP(1) 1
        FROM [Orders] AS [oo]
        WHERE [c].[CustomerID] = [oo].[CustomerID]
        ORDER BY [oo].[OrderDate] DESC
    ) AS [c0_0], [c].[CustomerID]
    FROM [Customers] AS [c]
    WHERE [c].[CustomerID] LIKE N'w' + N'%'
    ORDER BY (
        SELECT TOP(1) 1
        FROM [Orders] AS [oo]
        WHERE [c].[CustomerID] = [oo].[CustomerID]
        ORDER BY [oo].[OrderDate] DESC
    ) DESC, [c].[CustomerID]
) AS [c0] ON [o].[CustomerID] = [c0].[CustomerID]
ORDER BY [c0_0] DESC, [c0].[CustomerID]

Error - ORDER BY items must appear in the select list if SELECT DISTINCT is specified.
We introduce the Distinct keyword for include. Since the Order By item is subquery, even if that appears in select list too, Sql Server cannot identify them as same subquery hence throws exception.
We either need to use alias expression for such subquery or revisit usage of Distinct.

fixed via c97c523c179df16600528d67e5048899f0131c22


Scale and optimize highly active repositories

Summary
This work provides scalability improvements that reduce the chance of rate limits being triggered.
Intended Outcome
Large engineering teams with monolithic apps or with mono-repos have engineering practices that create a large number of updates, pull requests, and continuous integration runs against a single repository. At scale, these highly active repositories encounter rate limits when attempting to push and merge code.
How will it work?
This work won't create any user visible changes other than the absence of rate limit errors.

https://github.blog/2021-03-16-improving-large-monorepo-performance-on-github/


[Enhancement/功能请求] EMI extreme crafter recipe support

Checks/检查

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。

Description/描述
I noticed after migrating over from JEI to EMI, that i was unable to fill the extreme crafter via recipe autofill.

as shown in the image, apparently EMI does not support the extreme crafter. not sure if this should be reported on EMI's side instead.

Hmm, it seems after further testing it started randomly working; closing.


Slot filling using fulfillment library sample

Hi,
Could someone point me in the direction of a robust sample which shows how to use the webhook for slot filling in the fulfillment library. Am searching the forums and am mostly finding complaints or code from api.ai days.
Thanks,
Jarrod

@McGern
Here's the link for the sample. Sadly, it took too long to find out since it wasn't added in the Samples section of README of this repo.
I am creating an issue for missing samples links in README. Will update here after.

@McGern @shashaBot
Yes please see our sample on slot filling. Be sure to regularly check our main repo for updates as well.


Create component metadata for pubsub.in-memory

Create component metadata for pubsub.in-memory, like in https://github.com/dapr/components-contrib/blob/master/state/azure/cosmosdb/metadata.yaml

/assign

Closed via #2664


Add more translation

I added more translations #59

:cn: https://github.com/gbcr/clean-code-php of @gbcr
:ru: https://github.com/peter-gribanov/clean-code-php of @peter-gribanov
:brazil: https://github.com/fabioars/clean-code-php of @fabioars
:brazil: https://github.com/jeanjar/clean-code-php/tree/pt-br of @jeanjar
:thailand:  https://github.com/panuwizzle/clean-code-php of @panuwizzle

:clap: :clap: :clap:


MaximumLength WithMessage MaxLength placeholder is off by one

FV version 7.2.1
.NET version 4.6.1
I have the following rule defined:
	const string MustBeLessThan0Characters = "{PropertyName} must be less than {MaxLength} characters.";

	RuleFor(obligation => obligation.ObligationNumber)
		.NotEmpty()
		.WithMessage(FluentMessageTemplates.FieldIsRequired)
		.MaximumLength(10)
 		.WithMessage(FluentMessageTemplates.MustBeLessThan0Characters)
		.WithName("Obligation #");

Which generates the following error message:
"Obligation # must be less than 11 characters."
When modifying the MaximumLength rule value to 11, the error message changes accordingly (although still incorrect):
		.MaximumLength(11)

Error message:
"Obligation # must be less than 12 characters."

Just a note: This issue was introduced sometime after version 7.1.1. I encountered this error immediately after updating to 7.2.1.

I’m pretty sure this is the correct behaviour. I’m not in front of a computer right now but I believe MaximumLength is an inclusive check, so for MaxLength(10) “must be less than 11” is correct. I’ll confirm tomorrow.

You are correct, I think. Was the error incorrect before and has been fixed by version 7.2.1? Our unit test was coded to validate the exact message. After updating the test failed because the message now contains "11" instead of "10". I will update our test to coincide with the (what I think is) new behavior. I also confirmed by rolling back to 7.1.1 and the test again passes.

The more I think about it, the more I think the previous behavior was more desireable. The MaxLength placeholder should be replaced with the actual maximum length. The message should be worded accordingly. In this case we should have worded our error message as "... may be no longer than {MaxLength} characters."
For one, I think that a non-programmer type would find the "no more than" verbiage easier to understand than the "less than 11" phrasing. And also to supply a value to MaxLength other than the value the developer provided to MaximumLength() is somewhat unexpected, and doesn't meet the definition of Max(imum)Length. The maximum length is 10 in our case.
What do you think about this?

I do actually agree, but the problem is the other translations of the error messages.
It’s not really possible to make a change like this without re-translating everything (which I personally can’t do). I believe this is why this was done in the first place (to make the messages consistent across languages). I’ll consider it for a future release but because the scope of the change is so large and requires so many people to re-translate a single error message it might not be for a long time.

I agree that forcing untold numbers of applications to be modified due to a change like this is undesirable, but I think that's actually what has happened sometime between 7.1.1 and 7.2.1. When running against 7.1.1 the MaxLength placeholder is replaced with 10 in my example. In 7.2.1 it is replaced with 11, the value passed to MaximumLength + 1. So a change was applied after 7.1.1 is forcing retranslation of messages that had been stable up until at least 7.1.1.

but I think that's actually what has happened sometime between 7.1.1 and 7.2.1

Actually no, the problem is that the message was wrong originally.
Originally the message incorrectly said "Must be less than 10", when it should've been "Must be less than OR EQUAL to 10", so actually the original message was off by 1.

So a change was applied after 7.1.1 is forcing retranslation of messages that had been stable up until at least 7.1.1.

No. The change was made to say "Must be less than 11" as the grammar and sentence structure remains the same. No re-translation was necessary. If it had been changed to "Must be less than OR EQUAL to 10" then this is a completely different sentence and all the different translations would've needed to be modified. As you can see, there are a lot of them: https://github.com/JeremySkinner/FluentValidation/tree/master/src/FluentValidation/Resources/Languages

Although saying that, a lot of the other languages have completely different message for those validators anyway. Let me see whether I can get to this for 7.3.

And I've created this issue to track progress: https://github.com/JeremySkinner/FluentValidation/issues/642

Oh OK. The difference here between what I was saying and what you are saying is that we were using our own format string rather than the automatically generated FV message. So in our case we should have needed to update our custom format messages to accommodate the new MaxLength substitution. Though ironically our original message was incorrect before given the MaxValue and now reads correctly.
Anyway, thanks for being so responsive and generous with your time! We use FV in many projects here with a lot of success.

Ah, I see, thanks for clarifying...yes I was referring to the built-in error messages.
I'm going to get this changed back to the previous behaviour for 7.3 (but with updated translations). In the meantime, here are updated versions of the 2 validators that you can use if you like:

	public class MaximumLengthValidator : LengthValidator {
		public MaximumLengthValidator(int max)
			: base(0, max, new LanguageStringSource(nameof(MaximumLengthValidator))) {

		}

		public MaximumLengthValidator(Func<object, int> max)
			: base(obj => 0, max, new LanguageStringSource(nameof(MaximumLengthValidator))) {

		}
	}

	public class MinimumLengthValidator : LengthValidator {

		public MinimumLengthValidator(int min)
			: base(min, -1, new LanguageStringSource(nameof(MinimumLengthValidator))) {

		}

		public MinimumLengthValidator(Func<object, int> min)
			: base(min, obj => -1, new LanguageStringSource(nameof(MinimumLengthValidator))) {

		}
	}

Thank you!

I've just pushed out 7.3 which includes this update and several other fixes.


Fix metadata desynchronization

Adds a script that queries the GH repository and sets the state of
metadata database to match.
Add NixOS service.
Add integration tests that check that the write part of the script
writes correctly, and doesn't touch the database at all if an
exception occurs.

Yep. And it exists because the webhook is flaky. A number of times a PR has been merged, a notification has been sent to the webhook, but then the webhook fails to retrieve the metadata entry from GitHub (usually it seems unable to reach the github API, but the reasons have varied). This leaves the Postgres database in a different state to the repo.
This script is just a quick fix to that problem, because we don't have the time to dedicate to a proper solution.

OK fair enough.

bors r+


Cleanup, as per #1

This PR is a major cleanup (sorry!). It solves the following issues:

cargo fmt
app and host folders' copy-paste from the rustzx app removed
Requirements on SPI RAM removed
More LED boards supported

What would be the major next steps if this emulator is to work properly?

Most important is to optimize the emulator itself. I've configured it to run with 60 frames full-speed without interruption, and the result is that these 60 frames take ~ 8.5 seconds to render so we get ~ 7fps, while we should get 30-50fps to have a chance for a smooth playback (note that the SPI/display speed is not a major contributor - it is the emulator itself; even if you comment out the set_pixel code completely, it still runs with ~ 7fps)

So... either we optimize the emulator itself, or well, we stop here. :)

Thank you very much @ivmarkov . That's pretty amazing.
Please, could you provide me a hint how to build the main branch?
When I try this (build for USB OTG with S2 - compatible with S3):
cargo +esp-<IP_ADDRESS> build --target xtensa-esp32s2-espidf --release --features "esp32s3_usb_otg native"

The build fails with:
error: The `ttgo` feature can only be built for the `xtensa-esp32-espidf` target.
  --> src\display.rs:14:1
   |
14 | compile_error!("The `ttgo` feature can only be built for the `xtensa-esp32-espidf` target.");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: The `esp32s3_usb_otg` feature can only be built for the `xtensa-esp32s3-espidf` target.
  --> src\display.rs:20:1
   |
20 | / compile_error!(
21 | |     "The `esp32s3_usb_otg` feature can only be built for the `xtensa-esp32s3-espidf` target."
22 | | );
   | |__^

error[E0412]: cannot find type `Gpio23` in module `gpio`
   --> src\display.rs:120:16
    |
120 |     rst: gpio::Gpio23<gpio::Unknown>,
    |                ^^^^^^ help: a struct with a similar name exists: `Gpio13`
    |
   ::: C:\Users\JurajMichálek\.cargo\registry\src\github.com-1ecc6299db9ec823\esp-idf-hal-0.24.0\src\gpio.rs:738:5
    |
738 |     pin!(Gpio13:13, IO, RTC:13, ADC2:2, NODAC:0, TOUCH:13);
    |     ------------------------------------------------------- similarly named struct `Gpio13` defined here

error[E0412]: cannot find type `Gpio23` in module `gpio`
   --> src\display.rs:137:15
    |
137 |         gpio::Gpio23<gpio::Output>,
    |               ^^^^^^ help: a struct with a similar name exists: `Gpio13`
    |
   ::: C:\Users\JurajMichálek\.cargo\registry\src\github.com-1ecc6299db9ec823\esp-idf-hal-0.24.0\src\gpio.rs:738:5
    |
738 |     pin!(Gpio13:13, IO, RTC:13, ADC2:2, NODAC:0, TOUCH:13);
    |     ------------------------------------------------------- similarly named struct `Gpio13` defined here

warning: unused import: `thread`
 --> src\main.rs:3:11
  |
3 | use std::{thread, time::*};
  |           ^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0609]: no field `gpio23` on type `esp_idf_hal::gpio::Pins`
  --> src\display.rs:62:31
   |
62 |             $peripherals.pins.gpio23,
   |                               ^^^^^^ help: a field with a similar name exists: `gpio2`
   |
  ::: src\main.rs:35:16
   |
35 |     emulate_zx(display::create!(peripherals)?, display::color_conv)
   |                ----------------------------- in this macro invocation
   |
   = note: this error originates in the macro `display::create` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0308]: mismatched types
  --> src\display.rs:82:13
   |
82 |             $peripherals.spi2,
   |             ^^^^^^^^^^^^^^^^^ expected struct `SPI3`, found struct `SPI2`
   |
  ::: src\main.rs:35:16
   |
35 |     emulate_zx(display::create!(peripherals)?, display::color_conv)
   |                ----------------------------- in this macro invocation

Feature ttgo was in the default features. If you re-pull my main, or the PR branch, your build should work.

If it still fails, let me know, and I'll check the pin layout for your card, as I could've messed it up a bit... :)

Pin layout is OK, it should build.

Huh wait. Why are you building for the esp32s2 target? Is this card a esp32s2 one, or an esp32s3 one?

It's because USB OTG board in the preview version was shipped with S2. The mass production version is now on S3.
The HW that I had available was on S2.
Nevertheless I've grabbed S3 version which is available at espressif.com, so that we avoid this confusion.

It's because USB OTG board in the preview version was shipped with S2. The mass production version is now on S3. The HW that I had available was on S2.
Nevertheless I've grabbed S3 version which is available at espressif.com, so that we avoid this confusion.

Supporting both is not a rocket science, I pushed that.

Thank you @ivmarkov .
Is there a reason for SPI2 in display configuratio?
The build for USB OTG on S2 fails with:
error[E0308]: mismatched types
  --> src\display.rs:88:13
   |
88 |             $peripherals.spi2,
   |             ^^^^^^^^^^^^^^^^^ expected struct `SPI3`, found struct `SPI2`

After changing to SPI3 the build is passing without problem.

No, that's a bug. Changed to SPI3.

Validated with USB OTG S2 - the solution works.
@ivmarkov Thank you very much for clean up and great improvements.


[BugFix] Fix bucket shuffle join delivery sort property error

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6479
Problem Summary(Required) ：

When child has property [sort property, shuffle] and need to trans to bucket shuffle, the property of enforer should be [empty,bucket join], not [sort property, bucket shuffle]

[FE PR Coverage check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/optimizer/ChildOutputPropertyGuarantor.java
1
1
100.00%


Derive macros fail with new "explicit discriminants on enums with fields"

Rust 1.66 was just released, along with Explicit discriminants on enums with fields. The given example does not compile when adding bincode (2.0.0-rc.2) derive macros to the enum:
$ cargo -V
# cargo 1.66.0 (d65d197ad 2022-11-15)

#[derive(Decode, Encode)]
#[repr(u8)]
enum Foo {
    A(u8),
    B(i8),
    C(bool) = 42,
}

# error: Invalid rust syntax, expected ident, got Some(Punct { ch: '=', spacing: Alone, span: #0 bytes(334..335) })

Step 1 would be to implement this in virtue: issue
After that we should see how serde implements this. With normal discriminants serde does not actually respect the value. e.g.
enum Foo {
    A = 5,
    B = 3,
}

Will still be encoded as 0 and 1 (See #592 for the reason why). I suspect this new syntax will also not actually respect the values, but instead use the index.


[Traefik Plugin Catalog] Plugin Analyzer has detected a problem.

The plugin was not imported into Traefik Plugin Catalog.
Cause:
failed to run the plugin with Yaegi: failed to eval `CreateConfig` function: 1:28: undefined: traefik_add_trace_id_header_2

Traefik Plugin Analyzer will restart when you will close this issue.
If you believe there is a problem with the Analyzer or this issue is the result of a false positive, please fill an issue on piceus repository.

unable to reproduce, works with local-plugin mode. no way to run this test from dev side, closing ticket.


Eslint-like examples for dollar-variable-pattern

Provide better examples and formatting / usage instructions in the form of comment blocks like ESLint. See: https://eslint.org/docs/rules/lines-between-class-members#options
Ensure example formatting is consistent throughout README doc.

Hey all -- I was confused at the instructions for dollar-variable-pattern and saw some comments echoing my confusion, so I updated the docs.
I tried to preserve the standard stylelint docs formatting, but included examples formatted like ESLint rules examples. They contain both examples of working/breaking code and inline usage, which, I hope, will reduce confusion for other people trying to use this rule.

@SterlingVix This is great! Thanks a lot!
The updates to improve the READMEs of the rules are really important. 👍


parallel decoding ?

I modify the fairseq as a translation service, but it seems that the each request has to wait before previous request finishes even though i use concurrent programming and there are also some free gpu resources .
As i am not quiet understanding the computation logic of gpu, so i wonder if it's possible for me to make the code support parallel decoding, which can decode multi requests simultaneously. Though this can be done by start multi services on one gpu, but i would prefer parallel decoding  if it's possible.
Thanks...

Can you be more specific about the changes that you made?  Can you include a link to a branch containing your modifications?

Can you be more specific about the changes that you made? Can you include a link to a branch containing your modifications?

Hello letmatt, thanks for your reply.
I use tornado as service framework and  load the model resources in the tornado Handler init method, all the code are almost same as:
https://github.com/pytorch/fairseq/blob/4ed5abc9e355ff22a971372d365f0bc27f2d941f/interactive.py#L74-L113
Then in the post/get method, reading all the sentences to be translated and make them in one batch like:
https://github.com/pytorch/fairseq/blob/4ed5abc9e355ff22a971372d365f0bc27f2d941f/interactive.py#L117-L129
Finally, call the inference function and return all the result back:
https://github.com/pytorch/fairseq/blob/4ed5abc9e355ff22a971372d365f0bc27f2d941f/interactive.py#L130-L163
Thanks

Sorry, I'm not familiar with tornado.  Maybe they can help you?  Closing this issue for now.  Please open a new one if you have additional concerns.  Thanks!


Fix various linting issues

fixes GH-30

Linting errors noted in GH-40 have been resolved. Ignoring go module related issues for this PR, will fix separately.


Application logging base classes

As a developer
I want to have base classes for application logging
So I can have a standard model for capturing log trace information
Create logging base classes which capture standard information, such as a Event Id. This class will be the foundation of all structured logging data.

Unique GUID Event Id
Application Name
Product Name

Product and Application name have been added to the core of the serilog config as enriched properties.


Allow Number.is[Nan|Finite|Integer|SafeInteger] to take * input

Spec gives the strong impression that any type could be
expected as input for these functions
https://www.ecma-international.org/ecma-262/6.0/#sec-number.isinteger
And practically, it is useful to allow code such as:
/** @type {number|string} */
let foo;
if (Number.isInteger(foo)) {
...
}
Currently, this code must be written as:
if (typeof foo == 'number' && Number.isInteger(foo)) {
...
}
See https://chromium-review.googlesource.com/c/apps/libapps/+/1816332

I think that the general philosophy for most JS optional type systems is err on the side of having the typing make the most sense for developers, rather than allowing everything that the spec allows.
For comparison, it looks like TypeScript uses a similar typing as us, and they provide some of their rationale on their issue tracker: https://github.com/microsoft/TypeScript/issues/4002

Created internal issue http://b/141640588

i grok the "lets keep it narrow when it makes sense position" and don't disagree with that position.  i think this is a case where it doesn't make sense: the point of the Number.isInteger API is specifically to validate the input is an integer.  it isn't a matter of the type being implicitly coerced from e.g. string to number before being checked for its integerness.

OK, in that case, it's probably a bug in TypeScript's typings as well, right?

@joelhockey Is there a pull-request for TypeScript open/closed?

https://github.com/microsoft/TypeScript/pull/24436
Unfortunately the conversation has been locked for the last year.

It looks like that PR was actually merged, but then reverted shortly thereafter in https://github.com/microsoft/TypeScript/commit/2f73986b44a4ec10c7ebe7188e23863c3879d54e

I'm closing for now, but please feel free to reopen when the corresponding TypeScript PR sticks


Improved ui of 6 pages

fixes #1008
Before

After

@Its-Aman-Yadav please review this pull request and merge it
Thank you


GDB hangs if you start the stack view before the debugger

If the stack or memory view is started before the debugger has been launched and already hit a breakpoint, GDB will hang when you first step. It seems to be that GDB hangs when x/s is called on certain addresses (even without Voltron loaded). Needs further investigation.

Please, can you help me. Sorry for my bad English. I tried to install voltron.What my problem is?I'm new,sorry if I write not in that topic.
First Terminal
gdb -q first
Voltron loaded.
Reading symbols from first...(no debugging symbols found)...done.
(gdb) b main
Breakpoint 1 at 0x100000f24

Second Terminal
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 252, in run
    msg = e.message.args[1].strerror
IndexError: tuple index out of range

Error: HTTPConnectionPool(host='localhost', port=5555): Max retries exceeded wi>

Per the readme, the Voltron server isn't started until the program you're debugging ("first" in this example) is running. Run the inferior and the view should be able to connect.
(gdb) run

New problem:( Sorry if I misunderstand something here
First Term
$ sudo gdb -q ./a.out
Voltron loaded.
Reading symbols from ./a.out...
warning: dsym file UUID doesn't match the one in /Users/a1/a.out
(no debugging symbols found)...done.
(gdb) voltron init
(gdb) set disassembly-flavor intel
(gdb) b main
Breakpoint 1 at 0x100000f24
(gdb) run
Starting program: /Users/a1/a.out

Breakpoint 1, 0x0000000100000f24 in main ()
(gdb)

Second Term(voltron view stack)
Encountered an exception while running the view 'StackView':
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/main.py", line 53, in main
    inst.run()
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 239, in run
    self.render()
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/plugins/view/memory.py", line 145, in render
    super(StackView, self).render()
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/plugins/view/memory.py", line 53, in render
    api_request('targets', block=self.block))
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/core.py", line 388, in send_requests
    t.join()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 949, in join
    self.__block.wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 340, in wait
    waiter.acquire()
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 329, in sigwinch_handler
    self.do_render()
  File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 309, in do_render
    self.ft_body = self.body
AttributeError: 'StackView' object has no attribute 'body'

voltron view register is empty

Can you please enable debug logging by putting the following into ~/.voltron/config:
{"general": {"debug_logging": true}}

Then repeat the steps to reproduce the issue, and post your ~/.voltron/voltron_*.log files.
Also open a new issue, this is not relevant to this issue.

On 23 Feb 2016, at 1:08 AM, dianapinkberry<EMAIL_ADDRESS>wrote:
New problem:( Sorry if I misunderstand something here
First Term
$ sudo gdb -q ./a.out
Voltron loaded.
Reading symbols from ./a.out...
warning: dsym file UUID doesn't match the one in /Users/a1/a.out
(no debugging symbols found)...done.
(gdb) voltron init
(gdb) set disassembly-flavor intel
(gdb) b main
Breakpoint 1 at 0x100000f24
(gdb) run
Starting program: /Users/a1/a.out
Breakpoint 1, 0x0000000100000f24 in main ()
(gdb)
Second Term(voltron view stack)
Encountered an exception while running the view 'StackView':
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/main.py", line 53, in main
inst.run()
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 239, in run
self.render()
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/plugins/view/memory.py", line 145, in render
super(StackView, self).render()
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/plugins/view/memory.py", line 53, in render
api_request('targets', block=self.block))
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/core.py", line 388, in send_requests
t.join()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 949, in join
self.__block.wait()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 340, in wait
waiter.acquire()
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 329, in sigwinch_handler
self.do_render()
File "/Library/Python/2.7/site-packages/voltron-0.1-py2.7.egg/voltron/view.py", line 309, in do_render
self.ft_body = self.body
AttributeError: 'StackView' object has no attribute 'body'
voltron view register is empty
—
Reply to this email directly or view it on GitHub.

Did you found a solution yet? I got the same problem, i just delete  voltron view stack simply  in tmuxinator config file. So i have to launch tmuxinator first,and then open the stack view when the debuggee launched.

Not yet. I will investigate.

On 15 Apr 2016, at 2:59 AM, cx9527<EMAIL_ADDRESS>wrote:
Did you found a solution yet? I got the same problem, i just delete voltron view stack simply in tmuxinator config file. So i have to launch tmuxinator first,and then open the stack view when the debuggee launched.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Fixed in 430cc8a51befa186769bb6514c4089d717f74a19


Missing Textures

Using the Medieval MC Fabric 1.19.2 edition, WITH some extra mods that I've downloaded, I'm getting missing textures of the anvil -- when I play singleplayer, it's okay, but once I join my server, the anvil becomes missing textures and I am unable to place it. Following that, when I go back into my single player world, textures are missing.
below are photos and the extra mods i've downloaded.

Okay, so I did a fresh install and I think it's a problem with the mod pack potentially


Simplify OS X instructions

You no longer need to install XQuartz or export anything to build on OS X due to the updated gtk+3 homebrew formula.

Im new to gethub so I have no clue where to post messages about SOLIDOAK but I do know it will not run on for me on  OSX 10.10.3

@Rodney-Gabriel the place you posted it before was correct, not here =)

@oakes I will be sure to delete these messages. By any chance is there a fix to my dilemma as I'm just getting started haven't figured out how to use any other IDE nor do I know how to compile the repository files from scratch. Only replying here as this is the only place I saw you responded to me and not in the intended area ;)

No problem, please see my response.

Thanks for this update !


Migrate from ServiceDirectory to the API index

(I thought I'd sent this yesterday, but apparently not...)


gpt2-medium LAMA

Hi, i have just used the default params to p-tune the gpt2-medium on LAMA task and the results is as follows.
best dev_hit@1: 51.8 best test_hit@1: 44.5
For the results I got, I have some confusions...
(1) It seems that there is a gap between the dev results and the test results. Are the dev set and the test set in the same distribution? Is it possible to provide the scipts of generating the train/dev/test sets and the original dataset?
(2) The results reported in the paper is 46.5, which is close to the best test_hit@1. Are the results in the paper  based on the test set?
It will be very nice if the shell scipts is provided to reproduce the results in the paper.

hi, I also use the params to p-tune the LAMA task, meeting the same questions when using bert-base-uncased.
My best dev_hit@1: 75.1 best test_hit@1: 85.2
However, the results reported in the paper is 52.3.  Does you meet the same question? Has your question been solved?

hi, I also use the params to p-tune the LAMA task, meeting the same questions when using bert-base-uncased. My best dev_hit@1: 75.1 best test_hit@1: 85.2 However, the results reported in the paper is 52.3. Does you meet the same question? Has your question been solved?

Hi,
The problem you mentioned may be caused by runing the codes in single subdataset like P1001. I wonder author ran his codes in whole dataset and averaged all results. Maybe you can have a try and verify if I'm right.


Add a usage example to README.org

A suggestion: Near the top of README.org, add one or two simple examples of actual usage.
Such as:
In nyxt give command set-url (C-l), and then at the Open URL prompt enter:
w hash table
to search wikipedia for "hash table". "w" specifies the search engine configuration to be used.

Indeed, I should add that!


chore: get latest version from git tag

The current NPM_TOKEN & GH_TOKEN are invalid, so we can test if the process works.

checked the logs and travis does dynamic install based on platform (ci / install)
so maybe the following is fail proof:
install: NPM_TOKEN="" GH_TOKEN="" /bin/sh -c 'npm ci || npm install'

According to the documentation of Travis CI, pull requests that sent from a forked repo won't have access to the encrypted env vars. I submitted a test pull request and the NPM_TOKEN & GH_TOKEN are not logged: https://travis-ci.org/luin/ioredis/jobs/442282959#L591.

According to the documentation of Travis CI, pull requests that sent from a forked repo won't have access to the encrypted env vars. I submitted a test pull request and the NPM_TOKEN & GH_TOKEN are not logged: https://travis-ci.org/luin/ioredis/jobs/442282959#L591.

Yeah, I was thinking more in the line of malicious dependencies. Such as with the eslint not so long ago. Where a build might be triggered from a "trusted" person

That makes sense. We could just write the encrypted tokens as env vars to the deploy stage in .travis-ci.yml instead of configuring them in the dashboard of Travis CI that is visible by all the stages.

That makes sense. We could just write the encrypted tokens as env vars to the deploy stage in .travis-ci.yml instead of configuring them in the dashboard of Travis CI that is visible by all the stages.

agree, though I didn't find how to do that in travis


L900 LED strip error while setting hue values: Returned error_code: TapoError.ERR_PARAMS: Request params error

Version of the integration
3.1.2

Configuration
L900
by TP-Link
Firmware: 1.1.0
Hardware: 1.0

Repo downloaded/installed through HACS and configured via UI.
Describe the bug
Haven't used LED strip for a while (about 6 months). Before now it worked fine (no errors as far as I remember). I recently re-enabled the integration and I'm getting Failed to call service light/turn_on. Returned error_code: TapoError.ERR_PARAMS: Request params error while setting hue values for the light through default card for light entity: changing color and temperatures of the LED strip - some colors work okay, others not. I can set blue color without errors for an instance, but setting different white hues don't work. Setting state (on/off), brightness and effect of the LED strip work okay.

Debug log

Logger: homeassistant.helpers.script.websocket_api_script
Source: helpers/script.py:526
First occurred: 07:20:50 (1 occurrences)
Last logged: 07:20:50
websocket_api script: Error executing script. Unexpected error for call_service at pos 1: Returned error_code: TapoError.ERR_PARAMS: Request params error

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 526, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 763, in _async_call_service_step
    response_data = await self._async_run_long_action(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 726, in _async_run_long_action
    return await long_task
           ^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2741, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2784, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 977, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1049, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 626, in async_handle_light_on_service
    await light.async_turn_on(**filter_turn_on_params(light, params))
  File "/config/custom_components/tapo/light.py", line 127, in async_turn_on
    await self._set_state(
  File "/config/custom_components/tapo/light.py", line 174, in _set_state
    ).get_or_raise()
      ^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/plugp100/common/functional/tri.py", line 159, in get_or_raise
    raise self.value
plugp100.responses.tapo_exception.TapoException: Returned error_code: TapoError.ERR_PARAMS: Request params error

Diagnostics file: config_entry-tapo-19b0e47311008e0f2971a22b813488c7.json

I believe this is the same as: https://github.com/petretiandrea/home-assistant-tapo-p100/issues/783 https://github.com/petretiandrea/home-assistant-tapo-p100/issues/758 https://github.com/petretiandrea/home-assistant-tapo-p100/issues/736 https://github.com/petretiandrea/home-assistant-tapo-p100/issues/727

Confirming I have this issue too.

Not stale

Not stale

Not stale

Not stale

Same problem here

Hi, the error is probably happening beacuse you are trying to set a white tempeture of the led strip, but if you use other colors it works just fine. I think the only fix has to be remove the tempeture settings and the presets from the card.

Not stale


Get-VSTeamAccessControlList -IncludeExtendedInfo. Cannot convert value PSCustomObject to type Hashtable

Steps to reproduce
Get-VSTeamAccessControlList -SecurityNamespaceId "52d39943-cb85-4d7f-8fa8-c6baac873819" -IncludeExtendedInfo

Expected behavior
Extended information properties for the access control entries contained in the returned lists

Actual behavior
Exception setting "ExtendedInfo": "Cannot convert value "@{effectiveAllow=240}" to type "System.Collections.Hashtable". Error: "Cannot convert the "@{effectiveAllow=240}" value of type "System.Management.Automation.PSCustomObject" to type "System.Collections.Hashtable".""
At C:\Users\xxx\Documents\PowerShell\Modules\VSTeam\6.2.1\Classes\VSTeamAccessControlEntry.ps1:20 char:10
+          $this.ExtendedInfo = $obj.extendedInfo
+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], SetValueInvocationException
    + FullyQualifiedErrorId : ExceptionWhenSetting

Environment data

> Get-VSTeamAPIVersion
Name                           Value
----                           -----
ExtensionsManagement           3.2-preview
MemberEntitlementManagement
DistributedTask                4.0-preview
Graph
Version                        TFS2018
ServiceFabricEndpoint          3.2
Core                           3.2
Packaging
Build                          3.2
Git                            3.2
Release                        4.0-preview
Tfvc                           3.2

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.2.0
PSEdition                      Core
GitCommitId                    6.2.0
OS                             Microsoft Windows 10.0.16299
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

OK this one I can duplicate. I will see what I can do.

This feature was added by @MichelZ  Adding him just in case he has a quick fix.

Fix is being merged now.


Implement .editorconfig file formatting in same way as template generator

Need to implement command that convert
dotnet_diagnostic.CA2241.severity = warning
dotnet_diagnostic.CA2237.severity = none
dotnet_diagnostic.CA2235.severity = none

into
dotnet_diagnostic.CA2235.severity = none
dotnet_diagnostic.CA2237.severity = none
dotnet_diagnostic.CA2241.severity = warning

Expected result layout:
< values that shouldn't be formatter>
# Autoformatted values
[*.cs]
### IDE ###
# Remove this or Me qualification (IDE0003)
# Add this or Me qualification (IDE0009)
# These two rules define whether or not you prefer the use of this (C#) and Me. (Visual Basic) qualifiers.
dotnet_diagnostic.IDE0003.severity = warning

# - true - Prefer fields to be prefaced with this. in C# or Me. in Visual Basic
# - false - Prefer fields not to be prefaced with this. or Me.
# // dotnet_style_qualification_for_field = true
# this.capacity = 0;
#
# // dotnet_style_qualification_for_field = false
# capacity = 0;
dotnet_style_qualification_for_field = false

< other rules >

### CA ###
# Do not declare static members on generic types (CA1000)
# When a static member of a generic type is called, the type argument must be specified for the type.
dotnet_diagnostic.CA1000.severity = warning

Next steps:

Options for enabling/disabling IDE / CA formatting
Option for grouping CA by category

List of not parsable options:
csharp_style_pattern_matching_over_as_with_null_check = true
dotnet_code_quality.CA1062.null_check_validation_methods = ThrowIfNull
dotnet_code_quality.dispose_ownership_transfer_at_constructor = true


Throw when reading error

I see you throw a runtime exception when there is a reading error. That might not be so desirable. Is there a way better way to check the stream status after deserializaing.
e.g
float x,y,z;
in >> x >> y >> z;
if ( ! in)
// stream is in invalid state

@shaovoon  sorry for asking but for clarification, is this fixed with 1.01 release?


[test] Add test to highlight the wrongness of hasClass function

@hij1nx, please check
/cc @jesusabdullah @nhunzaker

What is this supposed to demonstrate?

Agreed. Im not sure I understand. If there is a deficiency with the hasClass function, this should be internally fixed, we dont need tests to prove that there is a flaw in the design of our program, we need tests to prove that the design of our program works. Please elaborate on this pull request.

hasClass uses indexOf to check for a class. So it gives true even if the class name is username and we are checking for name. This test is for proving that the design works in this case also. Now we have to correct the hasClass function.

this is a really simple fix. just go ahead and fix and add to this pull request. =)

cleaned up


Can’t able to attach Photos from any folder except All Media after changing the AlbumSpinner from the toolbar

**Is the bug present in the demo Chat SDK project?**Yes

**What modifications have you made to the Chat SDK?**No

**Android Version:**29(it might in all versions)

Steps taken to reproduce the problem:
Click + icon on bottom left and choose photo option
In next page shows all the images in the phone
From top toolbar choose any other folders other then All Media observe the result.

Expected result:
When selecting any options from the toolbar(AlbumSpinner) it should show the list of images inside that album

Actual result:
On selecting the Album from the AlbumSpinner it shows nothing even in All Media list of images was empty once the spinner changed

once

Comments:
Using version 5.2.7 and the issue was in latest 5.3.17 version also

I am also facing this issue never knew it existed


pdf preview doesnt work

I installed the extension on on-prem TFS2017.3 and I don't get the preview option like I get for images

This doesn't seem to work for chrome on my tfs2017.2 box but does w/ mozilla.
What browser are you using?

Google Chrome Version 66.0.3359.139 (Official Build) (64-bit)


Allow configurable docker.sock location

What would you like to be added:
Currently, eks-anywhere hardcodes the expected docker.sock location to /var/run/docker.sock. This is fine as a default, but it is not the only location that the docker socket may be present on a system. It would be preferred if eks-anywhere honored $DOCKER_HOST if set instead of only supporting /var/run/docker.sock.
Why is this needed:
Enabling this allows eks-anywhere to be flexible across different environment needs.

Thanks for the request! We'll track interest on the ticket and see about pulling this up.


TypeError: 'NoneType' object is not callable

os: ubuntu16.04
torch: 1.1.0
torchvision: 0.3.0
torchfile: 0.1.0
vgglua = torchfile.load(os.path.join(model_folder, 'vgg16.t7'))
vgg = Vgg16()
for (src, dst) in zip(vgglua.parameters()[0], vgg.parameters()):
        dst.data[:] = src

Error occured:
for (src, dst) in zip(vgglua.parameters()[0], vgg.parameters()):
TypeError: 'NoneType' object is not callable

a TypeError exception was thrown when i was loading a .t7 model.
it seems many people have the same problem.
does someone have any idea for that?

same issue

Same

Same here, did you find a soltion?

os: ubuntu16.04 torch: 1.1.0 torchvision: 0.3.0 torchfile: 0.1.0
vgglua = torchfile.load(os.path.join(model_folder, 'vgg16.t7'))
vgg = Vgg16()
for (src, dst) in zip(vgglua.parameters()[0], vgg.parameters()):
        dst.data[:] = src

Error occured:
for (src, dst) in zip(vgglua.parameters()[0], vgg.parameters()):
TypeError: 'NoneType' object is not callable

a TypeError exception was thrown when i was loading a .t7 model. it seems many people have the same problem. does someone have any idea for that?

您好，我也遇到了同样的问题，请问您是怎么解决的？
Hello, I also encountered the same problem, how did you solve it?


Add a specific tagging and processing for long commands passed throug httpd

This is a proposal to avoid the 'cascading' effect of long command name printing with httpd  UI.
Example with /vidloop command (http://<IP_ADDRESS>:8000/?/vidloop):
"Cascading" effect
/
/v
/vi
/vid
/vidl
/vidlo
/vidloo
/vidloop
Enable video-loop on ,: 352 x 288

With the proposed patch
Enable video-loop on ,: 352 x 288

Tested on Ubuntu 16.04 (Firefox) and Win10 (Firefox, Chrome)

perhaps it is better to add echo on/off mode?

Hi,
Ok, I understand the need for debugging purposes (?).
This is an idea :
http://<IP_ADDRESS>:8000/??/vidloop => echo on
http://<IP_ADDRESS>:8000/?/vidloop => echo off
What do you think about it ?
Nicolas

hi @nicotyze
many thanks for this PR. I think this solution is a bit too complex, so
I am proposing something simpler.
I have added a new function:
int ui_input_long_command(struct re_printf *pf, const struct pl *pl)
this function can be used for sending long commands, with or without
the / prefix. This command does not echo the input characters.
So what I suggest is that you in the httpd module detect the first character
of the input string. If the first char is / you can call ui_input_long_command.
otherwise call ui_input_pl which handles both short and long commands.
Alfred


Don't emit any source files found under node_modules

This fixes #6964 to suppress emit for any source files located by searching in node_modules, not just JavaScript files.

👍

Added fix for #9427, which was caused by similar changes for JavaScript. Also changed the API per @mhegazy 's suggestion.

Hmmm, must have missed a test file in a commit... all passed on my machine. Will take a look shortly.

I removed that one check causing the full path to be in the error for now. The subsequent line would be in error if the wrong file was referenced anyway, so this doesn't really lose any coverage. Hopefully the tests will be green on the CI server (eventually :weary: ) after this change.


Debug signals in ModuleConnector

Actually auto_debug_signals can not collect signals from ModuleConnector (probably because of using args/kwargs) so it has to be either investigated why auto_debug_signals can not get needed signals, or a debug_signals method should be added to ModuleConnector.

Sanity check: did you assign the ModuleConnector to some attribute on an Elaboratable?


Generators (and generator-based APIs like inlineCallbacks) don't work well with current implicit context

See #201 for example.
@jonathanj was talking about an explicit context API, where you just pass it around. That would be one solution.
Another is a decorator to be added to generators that deals with reinstating correct context.
At a minimum some documentation is probably called for.

https://github.com/altendky/st/blob/3802c170e4f0c01f2324474e2a32762a818221d3/epyqlib/twisted/cancalibrationprotocol.py#L569 another example

I've taken a stab at making something like Eliot support for Twisted's inlineCallbacks API.  This does include a generator function decorator which might be more generally useful ... or not, I'm not sure.
Anyway, here's what I have:
https://github.com/tahoe-lafs/tahoe-lafs/blob/609af9ce183e0a64a56187538e5488c3f2016cfd/src/allmydata/test/eliotutil.py#L110-L210
There are clearly some drawbacks to the implementation but perhaps these could be mitigated either by inclusion in Eliot or by the introduction of certain new helpers by Eliot.


Fax Number Visual

It was brought to our attention that in Pasco County, FL, we are providing the fax number without providing a visual cue. Is it possible to add a visual to indicate a fax number? The number has been entered in the data as a fax number.
Ex. 32416 Michigan Avenue, San Antonio, FL 33576
352-521-4319 is a fax number for the county

I'll look into adding that in. Thanks!


'Invalid column name' error when using max() in query

When using the max() function in a query, I receive the following error:
>>> cursor.execute('SELECT packages.id AS packages_id, packages.name AS packages_name,
packages.version AS packages_version, packages.enabled AS packages_enabled,
max(packages.version) AS max_1 FROM packages')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/lib/python3.5/site-packages/pyhdb/cursor.py", line 258, in execute
    self._execute_direct(statement)
  File "/lib/python3.5/site-packages/pyhdb/cursor.py", line 217, in _execute_direct
    reply = self.connection.send_request(request)
  File "/lib/python3.5/site-packages/pyhdb/connection.py", line 84, in send_request
    return self.__send_message_recv_reply(payload.getvalue())
  File "/lib/python3.5/site-packages/pyhdb/connection.py", line 124, in __send_message_recv_reply
    return ReplyMessage.unpack_reply(header, payload)
  File "/lib/python3.5/site-packages/pyhdb/protocol/message.py", line 92, in unpack_reply
    segments=tuple(ReplySegment.unpack_from(payload, expected_segments=header.num_segments)),
  File "/lib/python3.5/site-packages/pyhdb/protocol/segments.py", line 152, in unpack_from
    raise error.parts[0].errors[0]
pyhdb.exceptions.DatabaseError: invalid column name: The column 'PACKAGES.ID' is invalid in
the select list because the GROUP BY clause or an aggregation function does not contain it:
line 1 col 8 (at pos 7)

The same query works correctly without the function, as does using it without selecting any other columns. Am I doing something wrong, or is this a bug?

This is not a bug, but simply an invalid SQL query.
Aggregate functions like MAX either need a GROUP BY statement or it will just calculate the maximum of the whole table. In the latter case, however, you cannot project any other non-aggregated columns.
In your case, you have two options:

Use two queries. One to SELECT packages.id AS packages_id, packages.name AS packages_name, packages.version AS packages_version, packages.enabled AS packages_enabled and one to SELECT max(packages.version) AS max_1
If you need this to be in one query result, this might work:

SELECT
    packages.id AS packages_id,
    packages.name AS packages_name,
    packages.version AS packages_version,
    packages.enabled AS packages_enabled,
    (SELECT max(packages.version) AS max_1 FROM packages) AS max_1
FROM packages

I figured it may have been problematic to do it this way. I have fixed it by using the max query to get a value for version that is used as WHERE criteria in the 2nd query. Thanks for the response!


Webpack 3 bundle size is larger than Webpack 2.6.1

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
The build passes, but fails to concatenate, bundle size is bigger than with 2.6.1
ModuleConcatenation (inner): module is used with non-harmony imports from multi react-hot-loader/patch ./app.js
ModuleConcatenation: Cannot concat with ../node_modules/react-dom/index.js
ModuleConcatenation: Cannot concat with ../node_modules/react/react.js
ModuleConcatenation: Cannot concat with ./assets/styles/main.scss
ModuleConcatenation: Cannot concat with ../node_modules/cssrecipes-defaults/lib/box-sizing.css
ModuleConcatenation: Cannot concat with ../node_modules/cssrecipes-defaults/lib/document-remove-margin-padding.css
ModuleConcatenation: Cannot concat with ../node_modules/cssrecipes-defaults/lib/hidden.css
ModuleConcatenation: Cannot concat with ../node_modules/normalize.css/normalize.css

If the current behavior is a bug, please provide the steps to reproduce.
Tested on:
https://github.com/alexilyaev/react-es6-starter
See webpack3 branch:
alexilyaev/react-es6-starter#10
Run npm run build

What is the expected behavior?
I would expect the bundle size to at least stay the same...
And if I can figure out how to make ModuleConcatenationPlugin work, to be smaller.
Bundle size results:
Webpack 2.6.1: 268KB (67.3KB Gzip)
Webpack 3.0.0: 313KB (78.3KB Gzip)
Webpack 3.0.0: 317KB (78.6KB Gzip) (without ModuleConcatenationPlugin)
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
macOS 10.12.5
Node 6.10.3
Everything else in package.json

@alexilyaev
yes there is a bug. But apparently, the bug seems be in html plugin which has unupdated dependencies. Check this to fix your repo..

I also encountered this phenomenon, but I did not use html-webpack-plugin

That's strange, @hyy1115 Can u plz share your repo to reproduce issue.

@aseem2625 Need to create an issue, or comments on this issue behind

@hyy1115 If it's the same problem, you can comment here.
I'll try to remove html-webpack-plugin and see if it's related.

I've tried to remove html-webpack-plugin completely, go the same results:
https://github.com/alexilyaev/react-es6-starter/tree/webpack3-no-html-plugin

Do you want to request a feature or report a bug?
bug
What is the current behavior?
The compiled js files larger than webpack2.6.1。
If the current behavior is a bug, please provide the steps to reproduce.
https://github.com/hyy1115/react-redux-webpack2
npm run build-mac

Version: webpack 2.6.1
Time: 19446ms
               Asset      Size  Chunks                    Chunk Names
           vendor.js    273 kB       3  [emitted]  [big]  vendor

Now I put the webpack upgrading to 3.0.0, and add new webpack. Optimize the ModuleConcatenationPlugin (), and then execute the build
Version: webpack 3.0.0
Time: 23375ms
               Asset      Size  Chunks                    Chunk Names
           vendor.js    310 kB       3  [emitted]  [big]  vendor

What is the expected behavior?
I don't want to vendor. Js increase a few KB, and compile time should not be longer
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
mac: 10.12.5
node: 6.10.3
chrome:  59.0.3071.109

It's a bug in the ExtractTextPlugin, which is not yet webpack 3 compatible.

In my case I"m not using ExtractTextPlugin.

Did you guys use react-hot-loader3? I found sourcemapped-stacktrace.js was packed in bundle when I use webpack3.0, but webapck2.x is ok. Same config.

@SidKwok Looks like you're onto something...
The offending line:
  entry: {
    app: [
      'react-hot-loader/patch',
      './app.js'
    ]
  },

Tried putting a console.log and a throw in some files under node_modules/react-hot-loader/ but I don't see anything when running the webpack build, so not sure how to debug.

@alexilyaev You can use webpack-bundle-analyzer to see that sourcemapped-stacktrace.js was packed in bundle when using webpack 3.0
I can't really tell, but I have a strong feeling that it was something wrong with hot-reloading in webpack 3.0

I have the same issue and bigger bundle related to react-hot-loader,
So, i checked that in my webpack.prod.config.js - there is no anything related to hot loader, the only one place where it used
import { AppContainer as HotEnabler } from 'react-hot-loader'; in index.js file(root of project)
And what i could see with webpack 2.2: everything is fine, bundle size 285 kb,
With webpack 3(just changed version): 323kb,
source-map-explorer telling me that with webpack 3, i have in the bundle
react-hot-loader - 4 kb
sourcemapped-stacktrace - 20 kb
redbox-react - 10kb
and it also telling me, that i do not have such libs in prod bundle with webpack 2
Question, why after migration to webpack 3, react-hot-reload appeared in bundle? with webpack 2.x everything is fine
@SidKwok @gaearon @aseem2625

Have you guys tried 3.1.0? I think it solve the issue.

@SidKwok looks like yes, thank you
do you know what was the problem?

I can confirm 3.1.0 fixed the issue, I am now getting 264kb (66.7Gzip) compared to 268KB (67.3KB Gzip) using 2.6.1.
Now can someone explain the bailout?
ModuleConcatenation (inner): module is used with non-harmony imports from multi react-hot-loader/patch ./app.js

See the first comment.

Looks better, but I'm still confused, ModuleConcatenation is supposed to reduce your bundle size no? (there is a 50% size reduction linked in the official release blog post:  https://twitter.com/tizmagik/status/876128847682523138). Interested to hear some explanation around the bailouts, and why some people are seeing dramatic size reduction and others don't.


Unable to load library 'libSkiaSharp'.

PDFtoImage version
5.0.0
OS
Windows
OS version
Windows 11 Pro 24H2
Architecture
x64
Framework
.NET Framework
App framework
No response
Detailed bug report
Clean install of 5.0.0 with Visual Studio 2022 NuGet Package Manager.
Exception thrown when calling PDFtoImage.Conversion.ToImages( pdfData ).
DllNotFoundException: Unable to load library 'libSkiaSharp'.
at SkiaSharp.SKImageInfo..ctor(Int32 width, Int32 height, SKColorType colorType, SKAlphaType alphaType) in /_/binding/SkiaSharp/SKImageInfo.cs:line 93
at PDFtoImage.Internals.PdfDocument.RenderSubset(PdfFile file, Int32 page, Single width, Single height, PdfRotation rotate, FPDF flags, Boolean renderFormFill, SKColor backgroundColor, Nullable'1 bounds, Single originalWidth, Single originalHeight, CancellationToken cancellationToken)
at PDFtoImage.Internals.PdfDocument.Render(Int32 page, Nullable'1 requestedWidth, Nullable'1 requestedHeight, Single dpiX, Single dpiY, PdfRotation rotate, FPDF flags, Boolean renderFormFill, SKColor backgroundColor, Nullable'1 bounds, Boolean useTiling, Boolean withAspectRatio, Boolean dpiRelativeToBounds, CancellationToken cancellationToken)
at PDFtoImage.Conversion.RenderImpl(PdfDocument pdfDocument, Int32 page, FPDF renderFlags, RenderOptions options)
at PDFtoImage.Conversion.d__9.MoveNext()
at PDFtoImage.Conversion.d__8.MoveNext()
at PDFtoImage.Conversion.d__6.MoveNext()
Unable to load library 'libSkiaSharp'.
at SkiaSharp.LibraryLoader.LoadLocalLibrary[T](String libraryName) in /_ /binding/Binding.Shared/LibraryLoader.cs:line 40
at System.Lazy'1.CreateValue()
at System.Lazy'1.LazyInitValue()
at SkiaSharp.SkiaApi.sk_colortype_get_default_8888() in /_ /binding/SkiaSharp/SkiaApi.generated.cs:line 6052
at SkiaSharp.SKImageInfo..cctor() in /_ /binding/SkiaSharp/SKImageInfo.cs:line 48

Hi @ropst,
could you please give me an example solution to reproduce this issue? I've created a .NET Framework 4.8.1 console app and couldn't reproduce this Exception.
How does the bin folder look like? Is there a x64 folder containing libSkiaSharp.dll?
Might be related to this issue: #107
Greetings
David

Hi David,
I'm using .NET Framework 4.7.2. See link below for an example project including an x64 folder without libSkiaSharp.dll.
https://sqlvadycbapn2tw6sy.blob.core.windows.net/consoleapp1/ConsoleApp1.zip?sp=r&st=2024-12-10T14:07:41Z&se=2024-12-10T22:07:41Z&spr=https&sv=2022-11-02&sr=b&sig=sHtpPqReirlVUp2nF8N%2Frf9%2FNShI9XL0nFPa6EoCF7E%3D
Regards

@ropst I've create an issue in the SkiaSharp repo (https://github.com/mono/SkiaSharp/issues/3111) and a pull request (https://github.com/mono/SkiaSharp/pull/3112) to fix it. For now you will have to use above workarounds.

@sungaila Thanks David, I will use one of the workarounds.


Integrating generic_float struct for adding datatypes

A couple of things:

Move generic_float to migraphx/generic_float.hpp
Add a specialization for std::numeric_limits
Add a specialization for migraphx::is_floating_point(and remove the half one)
Add a specialization for std::common_type(and remove the half one)
Add a test/generic_float.cpp with the fp32 tests I wrote and add some tests for operator overloads

The specializations should use the template type like:
template<unsigned int E, unsigned int M, unsigned int F>
class numeric_limits<migraphx::generic_float<E, M, F>>
{
...
};

Also, we can use the fp8 template type as well to reduce the number common_type overloads:
template<unsigned int E, unsigned int M, unsigned int F, migraphx::fp8::f8_type T, bool FNUZ>
struct common_type<migraphx::generic_float<E, M, F>, migraphx::fp8::float8<T, FNUZ>> : std::common_type<float, float>
{};

template<unsigned int E, unsigned int M, unsigned int F, migraphx::fp8::f8_type T, bool FNUZ>
struct common_type<migraphx::fp8::float8<T, FNUZ>, migraphx::generic_float<E, M, F>> : std::common_type<float, float>
{};

For the fp16 tests, we want test similiar to the fp8, but instead of having an array lookup table, we would sample some values into a map and test that:
TEST_CASE(check_half_values)
{
    for(auto [x, f] : half_lut)
    {
        auto h = migraphx::bit_cast<migraphx::half>(x);
        if(std::isnan(f))
        {
            CHECK(std::isnan(h));
        }
        else if(std::isinf(f))
        {
            CHECK(std::isinf(h));
            CHECK((h < 0) == (f < 0));
            CHECK(bit_equal(x, migraphx::half(f)));
        }
        else
        {
            CHECK(migraphx::float_equal(float(h), f));
            CHECK(bit_equal(x, migraphx::half(f)));
        }
    }
}

I have a map of a thousand or so values we can use for this test. Also we will want to test the numeric limits by checking the bits match what we would expect:
TEST_CASE(check_numeric_limits)
{
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::min(), uint16_t{0x0400}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::lowest(), uint16_t{0xfbff}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::max(), uint16_t{0x7bff}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::epsilon(), uint16_t{0x1400}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::denorm_min(), uint16_t{0x0001}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::infinity(), uint16_t{0x7c00}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::quiet_NaN(), uint16_t{0x7fff}));
    CHECK(bit_equal(std::numeric_limits<migraphx::half>::signaling_NaN(), uint16_t{0x7dff}));
}

In addition, it would be good to have some tests for overflow and underflow like for std::numeric_limits<half>::max() + std::numeric_limits<float>::epsilon().

You will also need to add pragmas to bit_cast.hpp header to disable the warning for that function.

Why was this closed?

Overall this looks, we just need to fix the tidy warnings.


does the delete system32 button actually work

I am deathly curious, i have to press it, but i know i shouldnt

This here is all it does:
https://github.com/Morilli/bnk-extract-GUI/blob/7ec4555422312c20cdafda9689a9cadd4d455784/gui.c#L303-L308
https://github.com/Morilli/bnk-extract-GUI/blob/7ec4555422312c20cdafda9689a9cadd4d455784/utility.c#L385-L396


Remove usage devicePixelRatio

The pull request removes the usage of the devicePixelRatio in paint worklet. We don't need it even on high dpi devices, the size of the canvas should have included this info. This pull request would also fix a bug in Mac retina.

I had tried this change before but on ChromeOS / Linux high DPI even though it should work properly I see nothing. Perhaps the chrome bug is on non-mac platforms?

As we've discussed this is definitely the right change as PaintWorklet should have pre-scaled the canvas such that it is presenting the equivalent of CSS pixels. Since this PR didn't include rebuilding i've applied the change with rerunning the build script to make sure all of the build artifacts are correct.