Template literal as second assignment expression in ternary breaks highlighting

From @garthk on April 8, 2016 4:30

VSCode Version: Version 0.10.10 (0.10.10) or Version 0.10.14-insider (0.10.14-insider) 17fa1cbb49e3c5edd5868f304a64115fcc7c9c2c
OS Version: OS X 10.11.4 (15E65)
javascript.validate.enable set either true or false

Steps to Reproduce:

Open a new Code – Insiders window
Paste in the following JavaScript
Observe

function test1(x) {
    const defaultValue = `${x}`;
    const value = x ? x : y;
    console.log('so far, so good');
}

function test2(x) {
    const value = !x ? `${x}` : x;
    console.log('so far, so good');
}

function test3(x) {
    const value = x ? x : `${x}`; // this comment is coloured as if it's part of the template literal
    console.log('this entire line, too');
} // and this one

If I'm getting this right:

test1 shows code knows when a template literal ends, usually
test2 shows code still knows when a template literal ends if it's the first AssignmentExpression in a ternary
test3 shows code somehow misses the end of a template literal as the second AssignmentExpression in a ternary, highlighting from then on as a string

Copied from original issue: Microsoft/vscode#5090

From @garthk on April 8, 2016 4:32
I don't think this is the same as #3955, unless the fix promised there hasn't made it into Insiders yet. @aeschli?

Duplicate of https://github.com/Microsoft/TypeScript-TmLanguage/issues/81


B2B OTP replacing the the ad-hoc external sharing experience used in OD4B/SPO

Hello- Thanks for this article! I had a question on following statement, "After preview, this feature will replace the ad-hoc external sharing experience used in OneDrive and SharePoint today for all tenants."
Question -> Since the B2B OTP will replace the the ad-hoc external sharing experience used in OD4B/SPO, can you put a placeholder in this article that will link to the future guidance on how this transition will need to managed by customers. Every customer that I talk to about this starts asking about "how" the transition will occur. Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71747405-a38b-c475-7915-bb10242b689f
Version Independent ID: ccf67a68-63d7-9d04-69c7-728fabb3be24
Content: SharePoint and OneDrive integration with Azure AD B2B (Preview) - SharePoint Online
Content Source: SharePoint/SharePointOnline/sharepoint-azureb2b-integration-preview.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@MSFTRafLop can you comment?

For the most part, customers don't need to re-share content that was already shared externally. Just like when you enable the preview. The reason is that when an "old" link is clicked again then we create a B2B Invite on-demand in that moment on behalf of the user who originally created the "old" link. There are instances where this on-deman B2B Invite won't work, like if it conflicts with an AAD B2B policy or if the user who created the "old" link no longer is at the company or no longer has permission to share or create B2B invitations.

@tfurstms Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Drag and drop does not work as expected

Trying to drag and drop files fails. Particularly using the function loadDroppedFiles will seg fault while trying to free an invalid pointer to the file path:
free(): invalid pointer
Aborted (core dumped)

Or it will try to double free:
free(): double free detected in tcache 2
Aborted (core dumped)

It does that on the next frame or the frame after. I'm not sure if this is user error, because I don't know what I should or should not free manually and how. This is a basic version of what I tried:
mainloop :: AppState -> IO AppState
mainloop appState = do
  fileIsDropped <- isFileDropped
  when fileIsDropped $
    print =<< loadDroppedFiles
  endDrawing
  return appState''

main = whileWindowOpen_ mainloop =<< initApp

While working on my little applet, I found that using the foreign C functions will not crash the app and will give the correct pointer and the correct file path.
  fileIsDropped <- isFileDropped
  when fileIsDropped $ do
    filePtr <- c'loadDroppedFiles
    print filePtr
    fileData <- peek filePtr
    print fileData
    c'unloadDroppedFiles filePtr

Fixed in <IP_ADDRESS>


[Bug]: Improvement in UI of navbar section in contact page and adding functionality to icons present in the navbar.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I would like to improve the alignment of the icons in contact page as it looks cramped up. I would also like to add functionality to the icons. Additionally I would like to update the text in the footer section of the contact page.
I would like to work on this issue. Please assign me the same under gssoc label and an appropriate level.
Add Screenshots / Video Clip

What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[ ] I'm a Hacktoberfest contributor
[X] I want to work on this issue [Optional]
[X] I'm willing to provide further clarification or assistance if needed.

@akilesh26 Can you describe as to what exact functionality do you want to add?

Currently the icons present in the right hand corner of the navbar of contact page do not have any functions. I would like to add links to these icons so that they redirect to their respective page/perform their functions.

Additionally I will improve the layout of those icons to make it look better.
Also as mentioned, the text is not updated in the footer section of the contact page. I would like to update that as well.

I am waiting for your response.


Issue with k8s.io/docs/concepts/security/overview/

This is a Bug Report

Problem: 404 Error on OWASP Reference Links
The OWASP links referenced on the General Code Security Guidance Table are outdated and giving 404 errors. https://kubernetes.io/docs/concepts/security/overview/#general-code-security-guidance-table
Proposed Solution: Update links with new and correct ones:
Old -> New
https://www.owasp.org/index.php/Source_Code_Analysis_Tools -> https://owasp.org/www-community/Source_Code_Analysis_Tools
https://www.owasp.org/index.php/OWASP_Zed_Attack_Proxy_Project -> https://owasp.org/www-project-zap/
Page to Update:
https://kubernetes.io/...

/assign

/close

/close
again


[Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-06-01-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[x] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hi @amitelran,

has the new API version 2021-06-01-preview has already deployed worldwide?
except Kusto pool, are there any other changes to the existing APIs?

Hi @idear1203,
For some reason I can't reply directly on your comment.
Regarding your questions:

No, this is a new API version (for preview, not GA).
No, only changes are in Kusto Pool (kustoPool.json) and related examples.

The process of this branch is:

Auto-generation of a new API version based on an existing API version.
Copying the kustoPool.json from the 2021-04-01-preview version.
Manually adding the required capabilities to kustoPool.json + examples, each in a separate commit.

Hi @idear1203,
For some reason I can't reply directly on your comment.
Regarding your questions:

No, it hasn't been deployed worldwide.
No, only changes are in Kusto Pool (kustoPool.json) and related examples.

The process of this branch is:

Auto-generation of a new API version based on an existing API version.
Copying the kustoPool.json from the 2021-04-01-preview version.
Manually adding the required capabilities to kustoPool.json + examples, each in a separate commit.

Hi @amitelran we will have to hold on merging of this PR until the backend API deployment is done.

Hi @idear1203,
For some reason I can't reply directly on your comment.
Regarding your questions:

No, it hasn't been deployed worldwide.
No, only changes are in Kusto Pool (kustoPool.json) and related examples.

The process of this branch is:

Auto-generation of a new API version based on an existing API version.
Copying the kustoPool.json from the 2021-04-01-preview version.
Manually adding the required capabilities to kustoPool.json + examples, each in a separate commit.

Hi @amitelran we will have to hold on merging of this PR until the backend API deployment is done.

Hi @idear1203,
Can the PR be reviewed/approved in the meantime?
We expect the backend API deployment to be completed very soon.

@ruowan could you please help with a review?

Hi @amitelran, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

Hi @ruowan,
Providing business justification - this is a new API version for Synapse's KustoPool resource capabilities extension, for public preview.
The only differences are in the kustoPool.json file in the new API version.
Would appreciate a review to the PR in order to progress with the public preview schedule for Synapse<->Kusto integration.
Thanks!

Hi @idear1203,
For some reason I can't reply directly on your comment.
Regarding your questions:

No, it hasn't been deployed worldwide.
No, only changes are in Kusto Pool (kustoPool.json) and related examples.

The process of this branch is:

Auto-generation of a new API version based on an existing API version.
Copying the kustoPool.json from the 2021-04-01-preview version.
Manually adding the required capabilities to kustoPool.json + examples, each in a separate commit.

Hi @amitelran we will have to hold on merging of this PR until the backend API deployment is done.

Hi @idear1203 @ruowan,
Backend API deployment is done, and we're ready to move on.
Can please review & approve?
Thanks, much appreciated!

Hi @ruowan,
@idear1203 has approved the PR (thanks much for the swift review!).
Can you please review, and possibly approve and merge?
Would kindly appreciate, as the swagger PR is important for us to progress with the integration for public preview.
Thanks a lot.


[$250] Send invoice - Thread header in invoice workspace chat shows third line "Invoice"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New Feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Send a message.
Right click on the message > Reply in thread.
Note that the header consists of two lines.
Go to FAB > Send invoice.
Send an invoice.
In invoice workspace chat, send a message.
Right click on the message > Reply in thread.

Expected Result:
Only two lines will be shown in the thread header, which will be header and subtitle link.
Actual Result:
Three lines are shown in invoice workspace chat thread header, which are made of header, subtitle link and "Invoice" line.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/36c29af0-805f-48f5-bc15-2e7e3328c3fb
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0151a2dd35ff38b79a
Upwork Job ID:<PHONE_NUMBER>647714304
Last Price Increase: 2024-04-30

We think this bug might be related to #wave-collect - Release 1

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread header in invoice workspace chat shows third line "Invoice"
What is the root cause of that problem?
That's because we check for isChatThread after isInvoiceRoom.
https://github.com/Expensify/App/blob/a462d5854359850359f248aaec58ad4bc2c0efcd/src/libs/ReportUtils.ts#L3164-L3169
What changes do you think we should make in order to solve the problem?

We should swap positions of these two checks.
https://github.com/Expensify/App/blob/a462d5854359850359f248aaec58ad4bc2c0efcd/src/libs/ReportUtils.ts#L3164-L3169
 if (isChatThread(report)) {
        return '';
    }
    if (isInvoiceRoom(report)) {
        return Localize.translateLocal('workspace.common.invoices');
    }

What alternative solutions did you explore? (Optional)

Does not appear to be a serious deploy blocker to me and should be addressable by external contributors 👍

Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread header in invoice workspace chat shows third line "Invoice"
What is the root cause of that problem?
We never show subtitle for chat threads in app, but don't check for it here:
https://github.com/Expensify/App/blob/aee3a53099e87577639413561c0fd590ee56f1eb/src/pages/home/HeaderView.tsx#L118-L121
The issue is apparent when the order of checks in getChatRoom changed. This makes it easy to introduce regressions to header in the future as we don't have clear enough rule as what should be the order of the checks.
https://github.com/Expensify/App/blob/aee3a53099e87577639413561c0fd590ee56f1eb/src/libs/ReportUtils.ts#L3163-L3169
To make sure we don't accidently display subtitles in future (even if a subtitle is calculated) in the context of a thread, we would add sanity checks here:
https://github.com/Expensify/App/blob/aee3a53099e87577639413561c0fd590ee56f1eb/src/pages/home/HeaderView.tsx#L118-L121
This would make the display logic clear and independent of arbitrary ordered if conditions here.
What changes do you think we should make in order to solve the problem?
We would:

Keep the isChatThread as the first check in getChatRoomSubtitle :
https://github.com/Expensify/App/blob/aee3a53099e87577639413561c0fd590ee56f1eb/src/libs/ReportUtils.ts#L3163
We will add a check for !isChatThead in shouldShowSubtitle here
https://github.com/Expensify/App/blob/aee3a53099e87577639413561c0fd590ee56f1eb/src/pages/home/HeaderView.tsx#L118if(isChatThead) {
    return false
}

Result
This works perfectly:
https://github.com/Expensify/App/assets/64629613/0b31f137-2b86-4537-a0bd-9c42effed486

#vip-billpay related. cc @danielrvidal

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@cristipaval Hi, I submitted my proposal after the 'help wanted' tag was added. As far as I know, proposals submitted before the Callstack contributor's comment are considered.

NOTE: I'll be OOO 1-8th of May 🌴

Tomorrow, I'll prepare the payment summary if one isn't auto-created for this issue.

Closing - the automation is correct here. @rushatgabhane please submit the payment request. Thanks!

$250 approved for @rushatgabhane


How to specify ssh key to use when connecting to a host?

I was playing around with bladerunner and I think I ran into an issue related with having multiple ssh keys in my ~/.ssh directory.
hostname.blade.toml
[Required]
  Commands = [
    "hostname"
  ]
  Hosts = ["<IP_ADDRESS>"]

In my .ssh/config file I have the following
Host <IP_ADDRESS>
    Hostname <IP_ADDRESS>
    Port 22
    User root
    IdentityFile /home/vendion/.ssh/some_ssh_key

Trying to run my hostname command results in a panic
bladerunner run ceph-test hostname --verbose
2017/09/14 19:22:31 Starting recipe: ceph-test.hostname
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x6118d2]

goroutine 6 [running]:
github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh.(*connection).clientAuthenticate(0xc4200c2300, 0xc4200c8180, 0x0, 0xa)
	/home/vendion/gocode/src/github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh/client_auth.go:54 +0x312
github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh.(*connection).clientHandshake(0xc4200c2300, 0xc4200187c0, 0x11, 0xc4200c8180, 0x0, 0x0)
	/home/vendion/gocode/src/github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh/client.go:112 +0x2d9
github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh.NewClientConn(0x86fce0, 0xc42000e0d0, 0xc4200187c0, 0x11, 0xc4200c8000, 0x86fce0, 0xc42000e0d0, 0x0, 0x0, 0xc420030528, ...)
	/home/vendion/gocode/src/github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh/client.go:82 +0xfd
github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh.Dial(0x6fe513, 0x3, 0xc4200187c0, 0x11, 0xc4200c8000, 0xa587ebce15ee000, 0x59bb0f37, 0xc420030580)
	/home/vendion/gocode/src/github.com/deckarep/blade/vendor/golang.org/x/crypto/ssh/client.go:176 +0xb3
github.com/deckarep/blade/lib/ssh.startSSHSession(0xc4200c8000, 0xc4200187c0, 0x11, 0xc420044920, 0x1, 0x1, 0x0, 0x0)
	/home/vendion/gocode/src/github.com/deckarep/blade/lib/ssh/session.go:129 +0xe0
github.com/deckarep/blade/lib/ssh.executeSession.func1(0xc42000d300, 0xc42000d300)
	/home/vendion/gocode/src/github.com/deckarep/blade/lib/ssh/session.go:112 +0x57
github.com/deckarep/blade/vendor/github.com/cenkalti/backoff.RetryNotify(0xc42005e840, 0x86c180, 0xc42000d300, 0x70f990, 0x0, 0x663d19)
	/home/vendion/gocode/src/github.com/deckarep/blade/vendor/github.com/cenkalti/backoff/retry.go:37 +0x88
github.com/deckarep/blade/lib/ssh.executeSession(0xc4200c8000, 0xc4200187c0, 0x11, 0xc420044920, 0x1, 0x1)
	/home/vendion/gocode/src/github.com/deckarep/blade/lib/ssh/session.go:111 +0x132
github.com/deckarep/blade/lib/ssh.consumeAndLimitConcurrency.func1(0xc4200c8000, 0xc420044920, 0x1, 0x1, 0xc4200187c0, 0x11)
	/home/vendion/gocode/src/github.com/deckarep/blade/lib/ssh/utils.go:75 +0x7d
created by github.com/deckarep/blade/lib/ssh.consumeAndLimitConcurrency
	/home/vendion/gocode/src/github.com/deckarep/blade/lib/ssh/utils.go:70 +0xe3

@vendion - sorry for the way, way late response...but yes this is something that needs to be addressed and I haven't had a chance for the past 5-6 months to address it.
Good news is I'm actively working through a solution but I don't have any ETA on when it will be ready unfortunately.  I would consider this tool very early stages alpha and barely usable at this point.
Thanks!


interpolate_via_density fix & tests for density

Hi!
For some reason the previous version of interpolate_via_density was not including the end points, such that if the path was Gamma -> X -> U, the points k-points would not return such that there were segments along Gamma -> X, then X -> U (this is the way pymatgen returns in the kpoints).
I added a little test as well to make sure that the number of points along each of the segments is at least equal to the density.

Ah, this was actually intentional - basically just to avoid e.g. calculating the same k-points multiple times unecessarily.
But since you're saying this is the default in pymatgen, maybe we could make this behavior possible via a keyword argument to interpolate? I'm not completely sure what would be a good name though; maybe segmentize?
Would be good to add to both variants of interpolate, i.e. also the one that takes a fixed number of points.
Thanks for adding the test as well!

I see, make sense!
I'm working on trying to match the ref_kcoords array in this DFTK test, which was generated by pymatgen's KPathSeek class. Maybe the tag for interpolate could be for_bands and remains off by default. I'm could implement this!

Given the latest updates with DFTK, I think it might best best to close pull request for the time being.
Thanks!

Oki, sure - let me know if you want to revive it; it's fine for me to add a kwarg like this if it is helpful for your needs.


Add support for dragging of extensions on the side bar.

I have a really huge list for extensions and it would be great if I there is a functionality to arrange which extensions show up in the right sidebar and also have the ability to arrange them using dragging

Also, it'd be great if the side bar slides to the left showing the name of the extensions with a millisecond delay after one hovers on them. Similar to how facebook implements in chat bar.

At least on Windows the sidebar does show the names of the extensions when hovering (as the elements with title-attribute should) but I do agree that tooltips similar to the Facebook example would be nicer:

Not only in windows, the sidebar shows names of extensions when hovering on all platforms.
I think I'll have to elaborate what I was saying. The sidebar can have more functionality and liveliness. If you use facebook with zoom more than 100%, chat sidebar just shows the profile pic of your contacts. As soon as you hover over them, the sidebar slides to the left with names of your contacts.

There also one more related issue: If you install a lot of extensions, the sidebar gets cluttered up and new ones are added to the bottom of last extension on the sidebar. If you have extensions lined up to the bottom of the screen, adding more can make them inaccessible from sidebar. I was unable to use 'extract' extension after re-installing it. And to access it, I had to remove lots of extensions that were taking up the space on the sidebar.
The reason I suggest something like fb chat sidebar is that it solves two problems: 1. quickly showing the name of the extesion without having to wait for a second
2. Provide scrolling functionality in sidebar so as to access all the installed extensions easily.


PropTypes deprecated

Since proptypes are now moved to separate package, maybe it is a good idea to reflect changes in this package?

Plz upgrade to 2.0.0


Enable quotes on /etc/os-release

Otherwise we get failures when we source the file
Signed-off-by: Itxaka<EMAIL_ADDRESS>

nope, not right yet :/

Now its fixed!

Hmm, you're re-creating /etc/os-release here and thereby overwriting a file owned by the OS.
This is not acceptable for re-distributable images.

Hmm, you're re-creating /etc/os-release here and thereby overwriting a file owned by the OS.
This is not acceptable for re-distributable images.

Has been like this since the start, Im just fixing an issue with quotes not being in there ¯\_(ツ)_/¯

What's the purpose of Dockerfile.image ?
Even if it's just used for CI testing, it might give false test results. /etc/os-release is used by (resp. a plan executed by) e.g. rancher-system-agent

What's the purpose of Dockerfile.image ?

To build an elemental OCI image? One that can be used by the Makefile.iso to build a final iso? One that can be tested by anyone easily?

Even if it's just used for CI testing, it might give false test results. /etc/os-release is used by (resp. a plan executed by) e.g. rancher-system-agent

I know, that is why those values are in there, to be used by the system-agent? We do the same on OBS, we override those values on os-release so they can be picked by the populate-node-labels for example?
Im not sure what is your objection to this? This produces a working image and ISO from the source code in this repo. One that can be tested before changes are merged. Should we just drop this? Im not sure how are we expected to not only CI test elemental but develop it? I am using this dockerfiles to test changes to everything, from the final elemental image, to the iso generation, to the cloud-configs and even new versions of the operator, as its easily overridable.
Can you state clearly your objection to this change, which actually fixes an issue in existing code (since the beginning of elemental even)?

BTW, this does not affect anything on OBS or the official images.

BTW, this does not affect anything on OBS or the official images.

:eyes:

Can you state clearly your objection to this change, which actually fixes an issue in existing code (since the beginning of elemental even)?

/etc/os-release is part of the operating system, used as an identifier on many occasions.
While we can add to it (like adding a TIMESTAMP by the node-image Dockerfile in OBS), we must not rewrite it.

wait, so its ok if I append a NAME=whatever to the file at the end, which will overwrite the original value as it will be loaded later in the file when doing a source /etc/os-release ??
I know its an identifier, and we override that as we are constructing a derived work from the original. But Im not sure what does that has anything to do with this PR, and why we must do that, is that on the license agreement of using the dockerfile?
Would also be ok to NOT copy the file from the original source and just create one ourselves? In that case we would not be modifying anything, but creating the file from scratch?
I just dont see the reasoning, nor what it has to do with this PR, nor why it even matters lol So many workarounds around that that I cant even see how is that an issue.

@kkaempf removed all uneeded keys and avoided overwriting the file. Now we only add our extra values in there.


Salesforce rest connector doc issues

Description:
In connector overview page [1],

Page not found when you click on Salesforce Access Token Generation section
The latest salesforce connector  is 1.1.1. Not 1.0.8.

In connector example page[2],

In [3] We do not have init operation now. Instead we have to add the connection details and it would be saved as a local entry.
In [4], the default port to invoke the api in MI is 8290.

[1] https://apim.docs.wso2.com/en/latest/reference/connectors/salesforce-connectors/sf-overview/#salesforce-rest-connector
[2] https://apim.docs.wso2.com/en/latest/reference/connectors/salesforce-connectors/sf-rest-connector-example/
[3] https://apim.docs.wso2.com/en/latest/reference/connectors/salesforce-connectors/sf-rest-connector-example/#configure-a-sequence-for-the-create-operation
[4] https://apim.docs.wso2.com/en/latest/reference/connectors/salesforce-connectors/sf-rest-connector-example/#testing
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Closing as fixed.


Leaderboard Unveiling

As the last question's timer runs out, the leaderboard shines forth, showcasing the champions of the quizventure.
The leaderboard should send the data in a descending (higher to lower) order of points of the Users in that room. The data sent should include:

Points of the user for that quiz
Name of the user

After the last question in that room, send an additional event called quiz over, with the leaderboard as the data. The clients will then listen to this event, and display the leaderboard accordingly.

Claim

Claim

claim

@rnavaneeth992 assigned to you!

this issue is made of 15 points instead of 20 as the socket part is not going to be handled in this issue. it's being handled in another issue, which effectively makes this just a controller writing task.

well done, @rnavaneeth992 ! :+1:


HTTP Digest auth fails if using connect.router

connect.router modifies req.url, so when the digest auth strategy does var href=req.url and then uses href in constructing HA2 it is using a different url path than the client used, resulting auth always failing.
this is particularly the case if you do server.use('/api', connect.router(routes)); and then attempt to use digest auth in the routes.
a solution would be to use the uri component of the authorization header, which reflects what the client used.

This should now be fixed, using req.originalUrl instead.


Fix regression where single page paging API generates invalid code

Single page pageable didn't produce proper Java code and was missing a closing );.

Thanks Alan. Sorry for the bug.

<EMAIL_ADDRESS>released


Proposal: SA1027 should still reports tabs after non-whitespace with useTabs

Blocked on the acceptance of #2039, which adds the option described here.
#2034 Adds a new useTabs option which defaults to false. When this value is set to true, SA1027 (TabsMustNotBeUsed) is automatically disabled.
I propose updating the implementation when useTabs is true to only disable analysis of tabs used for indentation. In other words, tabs placed after the first non-whitespace character on a line would still be reported.
This is related to the OneTabIndent option described in #730, but not quite the same. This proposal only covers a specific case where the use of tab characters always produces strange behavior when the tab width changes.

:+1:

This proposal is no longer blocked.

Can you give an example of bad use of tabs after non-whitespace characters? Are we thinking something like:
int foo;<TAB><TAB>// my first
int barbaz;<T><TB>// my second

Where we want folks to use spaces instead of tabs?
While that may be a benefit, it's perhaps a tall order on the programmer to have their IDE tab setting be to actually insert tab characters (for the typical indentation) but avoid use of the TAB key for other indentation use. However, as you say, if the TAB size were to be changed, in my above example it could potentially make the indentation of the comments look very weird, and the space key is definitely one that programmers are comfortable with :smile:. So I guess I support.

@AArnott The IDE does not have an exact setting matching this behavior, but I believe it's acceptable for two reasons:

The use of tab within a line is relatively infrequent
The analysis is fast, and fixing all violations at once is fast. The fixer also ensures the conversion from tabs to spaces preserves the relative positioning of items within a line.

Sounds good. :+1:

:+1:


Fixing readiness probe

Why are these changes needed?

Related issue number
closes https://github.com/ray-project/kuberay/issues/1826
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ x] Manual tests
[ ] This PR is not tested :(

@kevin85421, please take a look

The readiness probe is not a bug. Please read #1806 and #1808 for more details. The flakiness is caused by the test logic. I am currently trying to fix it.


Pickling error on creating generators

Thank you for making this great tool. Currently I am trying to use your code in my own project.
I have a question regarding multiprocessing. For some reason, train and test generators do not work on Jupyter Notebook:
---------------------------------------------------------------------------
PicklingError                             Traceback (most recent call last)
<ipython-input-25-d9d404f23400> in <module>()
      3 test_datagen.set_pipeline([T.random_transform, T.random_crop, T.preprocess_input])
      4 test_generator = test_datagen.flow(X_test, y_test_cat, batch_size=64, seed=11, pool=pool)
----> 5 for x in test_generator:
      6     print (x)

/home/a161115/dev/food-101-keras/tools/image_gen_extended.pyc in next(self)
    727             index_array, current_index, current_batch_size = next(self.index_generator)
    728         # The transformation of images is not under thread lock so it can be done in parallel
--> 729         result = self.pool.map(process_image_worker, ((self.image_data_generator.process, self.X[j], self.rngs[i%self.batch_size]) for i, j in enumerate(index_array)))
    730         batch_x = np.array(result)
    731

/usr/lib/python2.7/multiprocessing/pool.pyc in map(self, func, iterable, chunksize)
    249         '''
    250         assert self._state == RUN
--> 251         return self.map_async(func, iterable, chunksize).get()
    252
    253     def imap(self, func, iterable, chunksize=1):

/usr/lib/python2.7/multiprocessing/pool.pyc in get(self, timeout)
    556             return self._value
    557         else:
--> 558             raise self._value
    559
    560     def _set(self, i, obj):

PicklingError: Can't pickle <type 'instancemethod'>: attribute lookup __builtin__.instancemethod failed

You noted that the kernel needs to be restarted everytime code is stopped manually. Is there currently a solution for this problem?

@leminhlong-pixta have you found a solution for it ?


Add support for Cocoa Beans and other random changes

I really liked the implementation of your mod and the only thing that I felt was missing is support for Cocoa Beans, so I added it!
I also changed a few other things:

remove entry point RightClickInit because it doesn't actually do anything
slightly modernize build:

use gradle java plugin's withSourcesJar()
remove deprecated jcenter()
add options.release = 16

P.S.
The true motivation behind removing RightClickInit was the logger stuff:
Instead of something like
    public static void log(Level level, String message){
        LOGGER.log(level, "["+MOD_NAME+"] " + message);
    }

a logger should be given an appropriate name like
Logger LOGGER = LogManager.getLogger("rightclickharvest");
and simply called via LOGGER.log(level, message) or, if you e.g. want to concatenate a string and print an exception:
LOGGER.log(level, message, "this is concatenated", exceptionToBePrinted);
One advantage of this is performance. In the above log method, the strings are always concatenated, even if they are never printed due to the log level, while the latter will only do this if necessary.
So how do you see the name of the logger?
That's the kinda ugly part, but I find it oh so worth it.
You need a custom log4j2.xml configuration file and need to start the game with -Dlog4j.configurationFile=log4j2.xml (when putting the file in the minecraft instance base directory, else /path/to/log4j2.xml).
Here's the default log4j2.xml file Minecraft uses (up to 1.16.5, I don't think it changed in 1.17).
There you can set exactly which data is logged in what format (and where to), e.g. if you use a pattern layout like
<PatternLayout pattern="[%d{HH:mm:ss}] [%level/%t] [%logger] %msg%n" />
it'll print something like

[16:58:15] [INFO/main] [rightclickharvest] actual message

You can enable debug logging for specific loggers by adding
<Logger name="loggername" level="debug"></Logger>
above the <Root ...> logger
It's also possible to suppress certain loggers (e.g. when they spam your server log).

Thanks, I'll merge and release this tomorrow. Only reason I had that class was because I generated the project with GeneratorFabricMod


"Incorrect" mailbox protocol in part 5

In part 5, you implement the mailbox protocol which is "documented" here. Your function mbox_call() is basically a C implementation of the algorithm described in that document:

Read the status register until the empty flag is not set
Read data from the read register
If the lower four bits do not match the channel number desired then repeat from 1
The upper 28 bits are the returned data

The relevant part of your code is:
while (1) {
    while (mmio_read(MBOX_STATUS) & MBOX_EMPTY);
    if (r == mmio_read(MBOX_READ))
        return mbox[1]==MBOX_RESPONSE;
}

However, you can see that that if statement does not quite match step (3). Instead of just checking if the channel number matches the value of the read register, we check if the whole thing matches our entire message (28 bits of address + 4 bits of channel).
What justifies this?

Hi,
Thanks for this. The response message always overwrites the request message (Ref: https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface) and so you can assume that the buffer address will be the same. Therefore it's legitimate to compare all 32 bits rather than just the 4 bit channel number. In fact, it's better because you know that the response is to your specific message.
Hope that helps!
Adam


Update SignInView.swift

Fix issue with declaration of GoogleSignInButtonViewModel variable. Switching to @StateObject from @ObservedObject allows to customize the button using constructor, otherwise - the customization doesn't work.

Can you clarify what you mean by "allows to customize the button using constructor, otherwise - the customization doesn't work?" I am not sure what you're fixing.

Can you clarify what you mean by "allows to customize the button using constructor, otherwise - the customization doesn't work?" I am not sure what you're fixing.

Hi Matt, of course! Here you go:

With the current approach this customization does NOT work:
@ObservedObject private var vm = GoogleSignInButtonViewModel(scheme: .dark, style: .wide, state: .normal)
In order to make it work (workaround), I've customized it in the init() method like this:

    init() {
        vm.style = .wide
        vm.scheme = .dark
    }

But the correct way, since the instance of the GoogleSignInButtonViewModel created in the SignInView, would be to declare it as @StateObject, then the customization work fine without init() method:
@ObservedObject private var vm = GoogleSignInButtonViewModel(scheme: .dark, style: .wide, state: .normal)

Please let me know if you have any questions, comments, or concerns.
Thank you!
Best regards,
MAKSYM OVSIANIKOV

@movsianikov I'm sorry! I still don't understand what you mean by the "customization" not working. In SignInView.swift, if you create the vm with a different scheme (e.g., .dark), then the button will be drawn with the dark blue background.
struct SignInView: View {
  @EnvironmentObject var authViewModel: AuthenticationViewModel
  @ObservedObject var vm = GoogleSignInButtonViewModel(scheme: .dark)
...

I am closing this pull request due to inactivity.


Added Docstrings to functions and libraries.

Type of change

Bug fix
Enhanced documentation

*# Changes proposed in this pull request

Project name: Calculator

Short description :

I added Docstrings to functions in the calculator. (addition, subtraction, multiplication, division, average) and to libraries(os, time).
I change variable names n1 to n_1 and n2 to n_2 to maintain the snake case notation.
Changed variable name "res" to "result" in function multiplication to avoid redefining variable issue.
Changed constant name "c" to "C".

Checklist

The code is Python 3 compatible - yes
I have added relevant comments in my file to make code understandable
I have added my project in a folder which includes all the necessary files

Resolve conflicts

Can you make its documentation or README.md file


boost: enable static libraries on Darwin

Motivation for this change
This seems to be necessary for CMake/Boost projects to build on Darwin.
My test case was solc, which currently does not build on Darwin.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Maybe solc should be fixed then?

@edolstra I'll investigate a bit more tomorrow. Someone told me that they tried multiple Nixpkgs derivations on Darwin that use CMake and Boost and all failed to compile for this reason, but I'm not sure what's going on.

Changed solc instead of boost in another merged pull request.


hack to fix zIndex of DropDownMenu inside a ToolbarGroup

https://github.com/callemall/material-ui/issues/719

@rolandpoulter Does setting the z-index of the toolbar group fix this issue?

@hai-cea yes, thank you!
Would it make sense to give toolbar groups a default z-index? This seems like it might be commonly encountered issue.

@rolandpoulter Yeh, this is a tough issue because the z-index depends on other elements in your app. For example, we don't want to have the z-index higher than an overlay or dialog window. We may need to think about a z-index scheme for the whole library?

Yeah, that should work. I'd propose dividing up UI elements into ranges. For example:

ToolbarGroups/DropDowns, and Tooltips could use 0-9, or 1 generally.
Snackbars and Dialogs could use 10-99, or 99 generally.

This would at least set a precedent that could be documented. Leaving plenty of room for customization. At least then when this kind of problem is encountered, there will be an explanation. Its hard to make it always perfect.
Its up to you, could just leave it how it is and add some extra documentation for when others run into this issue again.

Ok thanks @rolandpoulter. Are we safe to close this PR?
Also, I like your idea. Maybe you can add it to #719 as well?


One per minute cron jobs not running every minute but every 10ish minutes

Hi,
Looks like for some reasons, cron jobs that I have scheduled every minutes runs weirdly. Sometimes it runs every minutes, sometimes it stops for more than 15minutes than start again by itself.
Do you guys ever noticed that kind of bug ? Any suggestion on how to diagnosed that kind of bug ?

Hi,
I had same problem and it looks like the "poll_interval" config fixed my problem.
Thank you !


Needs climate library error message

When you run DFFS and specify a climate input file that doesn't exist in the directory, it assumes there is no climate data and doesn't generate ANY fires.  It should trigger an error.

First round QAQC a no-go:
Internal error occurred within the program: Object reference not set to an instance of an object.
Stack trace: at Landis.Library.Metadata.DataTableExtensions.SetColumns[T](DataTable tbl)
at Landis.Library.Metadata.MetadataTable`1..ctor(String filePath)
at Landis.Extension.DynamicFire.MetadataHandler.InitializeMetadata(String mapNameTemplate, String eventLogName, String summaryLogName)
at Landis.Extension.DynamicFire.PlugIn.Initialize()
at Landis.Model.InitExtensions(ExtensionMain[] extensions)
at Landis.Model.Run(String scenarioPath, IUserInterface ui)
at Landis.App.Main(String[] args)

Bruce, this message is triggered by Metadata, belongs in that issue.

Yes, thanks. Added the QAQC Metadata results to both this repo as well as the Dynamic Fuels repo because they are linked.


Zombie Process Prevention

If you start and close the mozc_tool,
there are cases where the zombie process remains,
so prevent it.
Description
If you start and close the mozc_tool,
there are cases where the zombie process remains,
so prevent it.
Modified code locations
src/base/process.cc
Confirmation of the acceptable code locations
Check https://github.com/google/mozc/blob/master/CONTRIBUTING.md and
confirm whether all modified files are acceptable for pull requests.
"Yes"

Please send to google/mozc instead. We don't touch any code other than src/unix/fcitx*

actually, I think you can do something else.
use fcitx::startProcess instead of SpawnMozcProcess. SpawnProcess itself doesn't seem to be the right place to handle zombie process.


Slow queries

Using this driver for a basic query, the results are being returned to my client much slower than doing the same query with pymongo. My best guess is that the rust driver is making a bunch of round trips to the database to retrieve the results a bit at a time, while pymongo gets everything in one shot. Again, this is just a guess. If I'm right is there a way to change the behavior. Or is it something else altogether?

Can you give an example of the query you're using? It's hard to tell what might be going on without seeing the code that's running

    let doc = doc! {
        "sensor_id" => 1
    };

    let cursor = collection.find(Some(doc.clone()), None)

    for result in cursor {
        if let Ok(item) = result {
            println!("{}", item);
        }
    }
}

That returns about 1500 records. Even if I remove the print it takes a couple seconds to loop through all of them. The find call itself is basically instantaneous.

Sample results:
{ _id: ObjectId("590a6e6d2c015b3e71f76411"), sensor_id: 1, temperature_celsius: 30, humidity: 32, datetime: "2017-05-03T16:57:33.385399" }
{ _id: ObjectId("590a6e6e2c015b3e71f76412"), sensor_id: 4, temperature_celsius: 27, humidity: 17, datetime: "2017-05-03T16:57:34.058113" }
{ _id: ObjectId("590a6e6f2c015b3e71f76413"), sensor_id: 7, temperature_celsius: 32, humidity: 15, datetime: "2017-05-03T16:57:35.220286" }
{ _id: ObjectId("590a6e732c015b3e71f76414"), sensor_id: 5, temperature_celsius: 31, humidity: 15, datetime: "2017-05-03T16:57:39.307786" }

Quick and dirty comparison with pymongo. Times in seconds.
Time to execute find:
pymongo: 0.000126
rust mongodb: 0.048850
Time to loop through results:
pymongo: 0.057684
rust mongodb:  3.587362

I think your instinct is correct; the default batch size for the Rust driver is 20 documents, whereas PyMongo doesn't seem specify one, and the server defaults to 101. This looks like it might be something we need to change, but in the meantime, can you try passing in a custom batch size?
@kyeah, any idea why we have the default batch size as 20? From looking back over the git history, I seem to be the one who introduced it (as a hardcoded value, not as a constant), but I can't find where I got that number from (maybe from seeing the shell show 20 documents by default at a time)? I think we should probably be defaulting to 0, which lets the server decide.

That seems to do the trick.
batch_size = 101 (mongodb server default):
Time to execute find:
0.069879
Time to loop through results:
0.983068
batch_size = 2000 (big enough for the entire result; maybe same behavior as pymongo?):
Time to execute find:
0.294689
Time to loop through results:
0.002365

Oh, I just read your comment more carefully. I guess the more useful test is setting batch_size to 0:
batch_size = 101 (mongodb server chooses):
Time to execute find:
0.069820
Time to loop through results:
0.299829

@saghm yep, i assume this comes from the mongoShell default. I'm +1 to using 0, which should act the same as other drivers in normal cases.

Awesome. I'll open a PR with this change sometime tonight.
@anderspitman, thanks for noticing this issue!

@anderspitman, we just released 0.2.8, which fixes the default batch size (by letting the server decide it). Feel free to try it out, and let us know if there are any issues!


Please invite me to the Recode-Hive GitHub Community Organization

Name
Anuj Saha
Discord Username (if applicable)
anujrocks0111
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


[Discussion] Skip to download pretrained_models in Docker

I made a AWS lambda using docker and I found that every time lambda is called, it downloads a folder, "pretrained_models". That process takes about 6~10 seconds and I want to reduce the time. What I did is
When I build a docker image, I put a folder "pretrained_models" together so that it does not have to download. However, it failed.
Secondly, I upload the folder "pretrained_models" to S3 bucket so that every time lambda is called, lambda loads the folder. I found that there is a hidden file in "pretrained_models" and I load it too. However, this also does not work.
I checked the directory where the folder should be located and there was no problem.
are there any things that I did not think about or solutions?
I want to get an answer of this problem.

Hi @Tringles,
We provide docker images that already embed the model:
For instance the 3.8-2stems image includes the 2 stems model, and thus does not need to download back the model at each run.
It seems that there are issues with the 4/5 stems images (do not exist for 3.8 and include an old version of spleeter for 3.6/3.7) but we'll have a look at it and try to fix asap.

@romi1502 how to set the path of the pretrained model.

@PeijiYang , you can use the MODEL_PATH environment variable to set the path of the model.

@PeijiYang , you can use the MODEL_PATH environment variable to set the path of the model.

Can't it be set in the code? only environment variable?

Can't it be set in the code? only environment variable?
No it cannot at the moment. I'm not sure why you would need to set it within the code though.

@Tringles,
we fixed the 4 and 5stems docker images that should work now, so I close the issue.


Set Matrix Zeros

Problem statement :

Given an m x n integer matrix matrix, if an element is 0, set its entire row and column to 0's.
You must do it in place.

Example 1:
Input: matrix = [[1,1,1],[1,0,1],[1,1,1]]
Output: [[1,0,1],[0,0,0],[1,0,1]]
Explanation :
from:
[[ 1 , 1 , 1],
 [ 1 , 0 , 1],
 [ 1 , 1 , 1]]

to:
[[ 1 , 0 , 1],
 [ 0 , 0 , 0],
 [ 1 , 0 , 1]]

Example 2:
Input: matrix = [[0,1,2,0],[3,4,5,2],[1,3,1,5]]
Output: [[0,0,0,0],[0,4,5,0],[0,3,1,0]]
Explanation:
from:
[[ 0 , 1 , 2 , 0 ],
 [ 3 , 4 , 5 , 2 ],
 [ 1 , 3 , 1 , 5 ]]

to:
[[ 0 , 0 , 0 , 0 ],
 [ 0 , 4 , 5 , 0 ],
 [ 0 , 3 , 1 , 0 ]]

Constraints:
m = matrix.length
n = matrix[0].length
1 <= m, n <= 200
-231 <= matrix[i][j] <= 231 - 1
This problem covers topics like Arrays, Hash Table and Matrix.

Hello @Saloni6111 ,
Could you kindly assign this task to me under Hacktoberfest.
I will complete the task and send merge request within 6 hours.

Hello @Saloni6111,
Could you kindly assign this task to me under Hacktoberfest? I look forward to completing it and submitting a merge request. Thank you!

this repo is excluded from the hactoberfest you guys still wants to contribute?

Hello @Saloni6111 , Could you kindly assign this task to me under Hacktoberfest. I will complete the task and send merge request as soon as possible.

@chaanakyaaM assigned!

merged!


Change version to 1.0.0

Coverage remained the same at 69.135% when pulling 4a11436abe67c4f35667c96cc16480cb0368f899 on jegasmlm:master into 73e275900aa1e8f8a8133cec335ff1112d6246dc on kusanagi:master.

Coverage remained the same at 69.135% when pulling a5a7ff5944acd1d6138e7df6269a9d283aab2730 on jegasmlm:master into 73e275900aa1e8f8a8133cec335ff1112d6246dc on kusanagi:master.


Unable to recover blocks after worldstate database issue

DESCRIPTION
Hello, I am having a world state database issue on version 24.5.2 in a private network with 6 nodes using QBFT and Bonsai as storage format.
Here are the logs:
{"time":"2024-07-17T21:00:14.051229504Z","stream":"stdout","_p":"F","log":"org.hyperledger.besu.ethereum.trie.MerkleTrieException: **Unable to load trie node value for hash** 0x46228703f771892700b8e0b22211b4d93644eed8c8130c9b6101e7340a420ddd location 0x","kubernetes":{"pod_name":"besu-node-validator-3-0","namespace_name":"besu","pod_id":"0b89b60d-af9b-45e1-8363-61f942bfa225","labels":{"app.kubernetes.io/component":"besu","app.kubernetes.io/managed-by":"helm","app.kubernetes.io/name":"besu-statefulset","app.kubernetes.io/namespace":"besu","app.kubernetes.io/part-of":"besu-node-validator-3","app.kubernetes.io/release":"besu-validator-3","apps.kubernetes.io/pod-index":"0","controller-revision-hash":"besu-node-validator-3-7bf6b669df","statefulset.kubernetes.io/pod-name":"besu-node-validator-3-0"},"annotations":{"prometheus.io/path":"/metrics","prometheus.io/port":"9545","prometheus.io/scrape":"true"},"host":"ip-10-0-6-15.eu-west-1.compute.internal","container_name":"besu-validator-3-besu","docker_id":"ffd5a63206a790faaf38af30b91093646e2795c10d73c82877dc3df2e5303873","container_hash":"docker.io/hyperledger/besu@sha256:db39870bfa72d4aa02f39268211d8037fda4fc81ae4cb7a06e024409fa5fb55b","container_image":"docker.io/hyperledger/besu:24.5.2"}}
VERSIONS (Add all that apply)

OpenJDK:

openjdk 21.0.2 2024-01-16
OpenJDK Runtime Environment (build 21.0.2+13-Ubuntu-123.10.1)
OpenJDK 64-Bit Server VM (build 21.0.2+13-Ubuntu-123.10.1, mixed mode, sharing)
besu/v24.5.2/linux-x86_64/openjdk-java-21

Kernel version:

5.10.216-204.855.amzn2.x86_64

SO:

PRETTY_NAME="Ubuntu 23.10"
NAME="Ubuntu"
VERSION_ID="23.10"
VERSION="23.10 (Mantic Minotaur)"
VERSION_CODENAME=mantic
ID=ubuntu
ID_LIKE=debian
HOME_URL=https://www.ubuntu.com/
SUPPORT_URL=https://help.ubuntu.com/
BUG_REPORT_URL=https://bugs.launchpad.net/ubuntu
PRIVACY_POLICY_URL=https://www.ubuntu.com/legal/terms-and-policies/privacy-policy
UBUNTU_CODENAME=mantic
LOGO=ubuntu-logo
Additionally, the node is deployed in a k8s cluster on AWS via a Docker container.
Thanks in advance.

hi there - can you provide your complete configuration?
@garyschulte this looks like a strange one "at location 0x"
@matthew1001 for visibility.

If it could provide more logs that would be helpful thanks, particular the logs leading up to when the issue began.


Fix memory leak in _SelectableTextState

This PR fixes memory leak in the _SelectableTextState, which did not dispose old _TextSpanEditingController before the creation of the new one in didUpdateWidget.
Description

Fixes https://github.com/flutter/flutter/issues/135046.

Tests

Updates selectable_text_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] All existing and new tests are passing.

cc @polina-c

@Renzo-Olivares @polina-c thanks a lot for the review!


config: Remove references to client & server.

We always use "control" and "satellite", as this is what the rest of the project uses.

Spun out of #83

This PR seems to have evaded review - are we still waiting on review for this one? Once conflicts are resolved, this looks good to me.

will rebase and land after #150


asyncio  - Task exception was never retrieved

Hi everyone,
It's me again and it seems like I'm having a much challenge in getting Rasa up and running on the GCP Compute Engine - vanilla Debian 9. This is also from fresh install of Rasa.
I was able to get rasa shell running on a localhost VM running Debian 9 as well - except that it will stop talking after saying Carry on - then i have to restart the shell again to get it up and runing
However, running rasa shell on the GCP is a different story - it kept returning below when i tried to talk to the bot ( can execute rasa shell with no issue)
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:5005 ssl:None [Connection refused]
This error is very similar to:

https://github.com/RasaHQ/rasa/issues/3606
https://github.com/RasaHQ/rasa/issues/3548

but I dont think that there has been solution at the end of the thread.
I have a feeling it might be configuration at the GCP compute engine, but not sure exactly what it is so any pointers are highly appreciated! :)
Thank you!!
Rasa version:
Rasa 1.1.8
Rasa X version (if used & relevant):
Python version:
3.7.3
Operating system (windows, osx, ...):
Debian 9
Issue:
2019-08-01 18:38:17 INFO     root  - Starting Rasa server on http://localhost:5005
Bot loaded. Type a message and press enter (use '/stop' to exit):
Your input ->  hi
2019-08-01 18:38:21 ERROR    asyncio  - Task exception was never retrieved
future: <Task finished coro=<configure_app.<locals>.run_cmdline_io() done, defined at /usr/local/lib/python3.7/site-packages/rasa/core/run.py:115> exception=ClientConnectorError(111, 'Connection refused')>
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 924, in _wrap_create_connection
    await self._loop.create_connection(*args, **kwargs))
  File "uvloop/loop.pyx", line 1904, in create_connection
  File "uvloop/loop.pyx", line 1883, in uvloop.loop.Loop.create_connection
ConnectionRefusedError: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/rasa/core/run.py", line 119, in run_cmdline_io
    server_url=constants.DEFAULT_SERVER_FORMAT.format(port)
  File "/usr/local/lib/python3.7/site-packages/rasa/core/channels/console.py", line 137, in record_messages
    async for response in bot_responses:
  File "/usr/local/lib/python3.7/site-packages/async_generator/_impl.py", line 366, in step
    return await ANextIter(self._it, start_fn, *args)
  File "/usr/local/lib/python3.7/site-packages/async_generator/_impl.py", line 205, in throw
    return self._invoke(self._it.throw, type, value, traceback)
  File "/usr/local/lib/python3.7/site-packages/async_generator/_impl.py", line 209, in _invoke
    result = fn(*args)
  File "/usr/local/lib/python3.7/site-packages/rasa/core/channels/console.py", line 100, in send_message_receive_stream
    async with session.post(url, json=payload, raise_for_status=True) as resp:
  File "/usr/local/lib/python3.7/site-packages/aiohttp/client.py", line 1005, in __aenter__
    self._resp = await self._coro
  File "/usr/local/lib/python3.7/site-packages/aiohttp/client.py", line 476, in _request
    timeout=real_timeout
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 522, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 854, in _create_connection
    req, traces, timeout)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 992, in _create_direct_connection
    raise last_exc
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 974, in _create_direct_connection
    req=req, client_error=client_error)
  File "/usr/local/lib/python3.7/site-packages/aiohttp/connector.py", line 931, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:5005 ssl:None [Connection refused]

Error (including full traceback):

Command or request that led to error:
rasa shell

Content of configuration file (config.yml) (if relevant):

Content of domain file (domain.yml) (if relevant):

Thanks for raising this issue, @MetcalfeTom will get back to you about it soon!

figured it out!
Rasa requires 2-core VM.
As soon as I tested it with 2-cores VM, it resolved the issue.
It works well with 2GB for running plain Rasa - but as per Rasa X documentation (not sure why it is on Rasa X, I suggest to also put it on Rasa documentation), best is to use minimum of 4GB.
Hope this helps other people out there! :)


Absorption coefficients not working for plotting profiles

Getting very low water contents for profiles that don't change with phase.
i.e. get same water when I call phase 'ol' and 'cpx'

There was a stray ylim change in the code


Updated AStar Pro importer

Updated AStar Pro importer to 4.1.16 version. That version (or lesser, I dont known) have graph connection changes.
Also I add BVTree stub for empty tiles: in some cases AStar Pro can export a few tiles with empty nodes (if generation bounds height equals landscape height).

Looks good. Any chance you can add a test related to the new file format similar to https://github.com/ppiastucki/recast4j/blob/master/detour-extras/src/test/java/org/recast4j/detour/extras/unity/astar/UnityAStarPathfindingImporterTest.java?

No problem.

Done.
Also I fix bug with tile width & height calculation: in nav_test map with 0.5 cell size, tile size 128, min region size 3, agent radius 1.5 and bounds ~(91;21;77) tile width/height calculation from bounds was broken. I use AStar voxels tile width/height values (of course translated to world size).

Thanks


Error

from pntl.tools import Annotator
text = "Unlike the classic PPP technique, in our new approach, the ionospheric-free linear combination is not used."
annotator = Annotator()
'srl'返回字典列表，标识句子中各种动词的语义角色。
result = []
result = annotator.get_annoations(text)['srl']
I reported an error after running this code
OSError: [WinError 123] 文件名、目录名或卷标语法不正确。: ''

I have no idea that senna could run non-english🙈 text. This error could be raised from senna directly or from you system terminal

I have no idea that senna could run non-english🙈 text. This error could be raised from senna directly or from you system terminal
I am running English text. Is senna only in win32, not win64?

Senna don't have different between Windows32 or Windows 64. Check you terminal support UTF

annotator.get_annoations("He created the robot and broke it after making it")["srl"]
Why is the output like this[{'A0': 'H e , c r e a t e d , t h e r o b o t a n d b r o k e i', 'V': 't', 'A1': 'a f t e r m a k i n g i t'}]

I count not find the root😑. But you found the issue or like to get your hands dirty please free to PR❤


All tunefiles report Quality Factor equal to 1 for all resonators.

The every tunefile and every resonator have a Quality Factor equal to 1 (indicating a no resonator and perfect transmission line).
You can see the issue with the follow code snippet.
import numpy as np
tune_path = '/mnt/so1/data/ucsd-k2so/smurf/16463/ufm_mv11/1646318795_uxm_relock/outputs/1646320098_tune.npy'
tunefile_data = np.load(tune_path, allow_pickle=True).item()
for smurf_band in sorted(list(tunefile_data.keys())):
    if 'resonances' in data_this_band.keys():
        resonator_data_this_band = data_this_band['resonances']
        available_res_indexes = sorted(resonator_data_this_band.keys())
        for res_index in available_res_indexes:
            if tunefile_data[smurf_band]['resonances'][res_index]['Q'] == 1:
                print(f'Quality Factor is 1 for (SMuRF, res_index): ({smurf_band}, {res_index})')

In the tunefile there are arrays of frequency and complex S21 from which the quality factor (and other other parameters) can be determined by model fitting. This in not a desirable situation for two reasons:

There is a standard fitting that is provided for, but not applied to, the tunefiles from sodetlib. Any project that wants to use this process than becomes dependant on sodetlib and it's requirements. This complicates installation, execution, deployment, modulability of any project that want to use this existing and maintained tool. This would get my project, DetMap, in trouble as I also resist calls to from sotodlib to integrate into that monolithic repository (put the AxisManager in into own repo and then we can talk).
Any modeling (like doing a quality factor fit) is going to be a significant slow down to the processing. For the ~2000 resonators for a single tunefile this is going to demoniate the computational time in DetMap even compared to the 'world's most complicated plots' that represent 95% of the computational time per tunefile currently.

For these reasons, I ask that this Quality factor be calculated and reported correctly with each tunefile. I also request numpy.nan and not 1 to indicate null values. Keeping track of the slang for null, None, nan is across SO data products difficult; Quality factor == 1 look like a model edge case failure and not a did-not-fit situation. I will be amending my other issue reports to reflect this new understanding.

Hi Caleb, just a few comments on this.

Tunefiles are generated by pysmurf, so we don't really have the ability to modify what's in them on creation with just sodetlib. This means that if we do add real resonator parameters to the smurf tunes and save the results, we'll still have two sets of tune files, one with resonator parameters and one without
Because resonator fitting takes a while and isn't used at all for regular smurf usage, I don't see any strong reason to put the procedure into the standardized "setup" operation, and would rather it just be run in post if/when it's actually needed.

Instead I think the resonator fit function should be run in the analysis pipeline, and the output file should be saved and written to CalDb or some other archive. Then the DetMapping repo can just take resonator-fit files as input and not worry about performing the fit itself. Maybe @kmharrington or @jseibert575  can comment on whether they agree with this.

I agree that we don't want to start editing the tune files. We've had to accept them as pysmurf gives them to us.
Side note on sotodlib dependence, the sotodlib module never imports DetMap. There is just currently 2 scripts in the site_pipeline folder that imports sotodlib and DetMap. DetMap could easily import tools from the core of sotodlib.
Does DetMap need resonator fits to make better maps? We already need to figure out how to do more the comprehensive integration for loading bias group maps into the readout/detector mapping when we're running on-the-fly in the field. We can add resonator fits to it while we're at it. The only question I have is are we calling it on the smurf server or part of the first light pipeline scripts.

I do think resonator fits will help with mapping, since it will weed out a lot of spurs that aren't real resonators, and will help us group mux-bands based on dip depth. I think it should be run as part of the first-light pipeline, since if it's run on the smurf-servers it will delay data-taking by a non-negligible amount when it doesn't really need to. I recall it taking ~20-30 minutes per tune.

30 minutes?!?! 🤯
Yeah, we can look at running them on the DAQ nodes / Analysis nodes. Can we also look at optimizing them? That seems way too long for the amount of analysis required for this.

We can try to optimize, but it is a 9-parameter fit so I'm not sure there's much we can do on our end to make that faster.

Though, one could look at how the fits compare with the initial guesses: https://github.com/simonsobs/sodetlib/blob/0e31ca2bd366423a77e9780d0d11a4decc4dc2d9/sodetlib/resonator_fitting.py#L74-L91
We can probably figure out a way to estimate Q and dip-depth without performing the full fit.


AWS manual deployment - VPC does not ask elastic IP allocation ID

Hello!
I am trying to follow the instructions for manual deployment. When trying to create a VPC with 'Single Public Subnet', it somehow does not ask to provide an allocation ID for Elastic IP. I've seen that this is possible to do when you choose 'VPC with Public and Private Subnets'. I am not an AWS expert. So wondering how to get around this problem.
I actually went ahead and followed the rest of the steps until creating a job queue. I configured AWS using metaflow configure aws and tried executing a flow. But the status never went from 'RUNNABLE' to 'STARTING'.
I would really appreciate your help in this regard. Do you think the VPC creation went wrong? Also, I have to admit that I did not configure Metadata and Scheduling so far.
Metaflow 2.2.7 executing BigSum for user:siramshettyv2
Validating your flow...
    The graph looks good!
Running pylint...
    Pylint is happy!
2021-03-18 17:02:28.442 Workflow starting (run-id<PHONE_NUMBER>328768):
2021-03-18 17:02:29.816 [1616101347328768/start/1 (pid 92816)] Task is starting.
2021-03-18 17:02:31.178 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status SUBMITTED)...
2021-03-18 17:02:35.582 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status RUNNABLE)...
2021-03-18 17:03:05.619 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status RUNNABLE)...
2021-03-18 17:03:35.777 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status RUNNABLE)...
2021-03-18 17:04:05.905 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status RUNNABLE)...
2021-03-18 17:04:36.042 [1616101347328768/start/1 (pid 92816)] [f3b8d066-4926-485e-81a3-1146cf1b0966] Task is starting (status RUNNABLE)...

^C2021-03-18 17:15:48.461 Workflow interrupted.
2021-03-18 17:15:48.461 Terminating 1 active tasks...
2021-03-18 17:15:48.689 Flushing logs...
2021-03-18 17:15:48.689 [1616101347328768/start/1 (pid 92816)]
2021-03-18 17:15:48.690 [1616101347328768/start/1 (pid 92816)] Aborted!
2021-03-18 17:15:49.035 [1616101347328768/start/1 (pid 92816)] Task failed.
2021-03-18 17:15:49.036 This failed task will not be retried.

Aborted!

Best,
Vishal

Hi Vishal,
Yes, you would need to create a VPC with public and private subnets. There is no need to create a metadata service or set up AWS Step Functions if you only intend to launch AWS Batch jobs from your laptop without any need for sharing metadata about executions with others. You can check out this tutorial for configuring your VPC. Tasks can be stuck in a RUNNABLE state for a variety of reasons - this guide can help in troubleshooting. Let us know if you are still running into issues - also quicker help might be available at chat.metaflow.org.


$index on v-repeat with orderBy

When using v-repeat, I understand you can use $index inside the loop to get the array index of the current object. If you'd use v-repeat on say, a list item, this means that the top / first
 has $index = 0, the second $index = 1, etc.
But when you use an orderBy filter on that v-repeat, there is absolutely no guarantee that the first
 has $index = 0, because $index is pointing to the index of the original array, not the re-ordered array.
What I'd like to do, is inside the v-repeat compare the currently processed object with the previously processed object, i.e.:

    <template v-repeat="objects | orderBy 'date' | filterBy search 'title'">

---

{{title}} - {{date}}

    </template>

This works great when the original array was already ordered by date, but if it was not - and let's, for the sake of the argument, assume that it wasn't - this becomes a mess. v-repeat first orders the array by date, then loops over the array in that new order, but inside each loop $index refers to the position in the unordered array.
Here's what worked for me in Angular, to illustrate how it could be handled:

{{object.title}} - {{object.date}}

Here a new, temporary array is created (orderedObjects) with the correct order and now $index points to the index in that ordered array, instead of the original one (objects).
Any way to achieve this with Vue?

You can define a filter as:
Vue.filter('as', function (list, key) {
  this[key] = list
  return list
})

<template v-repeat="objects | orderBy 'date' | filterBy search 'title' | as orderedObjects">
  ...
</template>

Ah yes, simple but effective! Thanks!

I got a list of users which are displayed with v-repeat.
HTML:

@{{ name }} | @{{ phone }}

JavaScript:
new Vue({
    el: '#vue',

    data: {
        users: [
            { name: 'Berta', phone: '555-123-4567' },
            { name: 'Delta', phone: '999-123-4567' },
            { name: 'Anton', phone: '888-123-4567' },
            { name: 'Echo', phone: '333-123-4567' },
            { name: 'Charlie', phone: '444-123-4567' }
        ]
    },

    methods: {
        onClick: function(index) {
            this.users.$remove(index);
        }
    }
});

If I just use v-repeat="users", I can access the original user with this.users[$index]. However, if I manipulate the list by ordering and/or filtering (e.g. v-repeat="users | orderBy 'name'"), $index points to the element in the ordered list.
What I'd like to do is removing an element from the original users array. As stated above this.users.$remove($index) only works on the original v-repeat, not on filtered or ordered lists.

This was done with Vue 0.* But how do you achieve this with Vue 1.0.*??
@yyx990803
Thanks in advance


[module] prohibited-words: fixed typo of log file

This commit is to fix a typo of log file name in the
prohibited words checker.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

:memo: Version: 1.20180820. Thank you for submitting PR #294. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://invain.mooo.com/.


Rename data/ directory

Now that we're publishing the package via npm, users will likely be installing it globally and the data/ directory that we generate will appear in cwd. Therefore, I think we should give the data/ directory more descriptive name. Ex: lighthouse-parade-data/
@calebeby thoughts?

Yeah, makes sense 👍


Project Security

NPM solved one problem but introduced another in the form of security vulnerabilities in dependencies and potential for introducing them.  I realize we can't be responsible for what devs might introduce into their own projects, but:
Does the Polymer project have a dedicated security team who is constantly monitoring on required dependencies, including PSK examples? If so, who is leading that?
I know if we find a potential vulnerability in a specific dependency it should  be reported there, but if we find one that just needs an update where should we be submitting security issues? Here, or elsewhere?
I've already had one corporate client inquire about this and I don't feel like I can adequately address their questions, which are quite legitimate. So any clarification would really help.
Comments?

I'm from Google's Security Engineering.  We monitor Polymer, and are happy to receive security reports via https://goo.gl/vulnz

I know if we find a potential vulnerability in a specific dependency it should be reported there

Please don't report security vulnerabilities via public issue trackers.  https://goo.gl/vulnz will receive reports and work with you to route them, and manage disclosure.
For reference, the overarching project's contribution guidelines say:

Polymer also participates in Google's Patch Rewards Program, where you can earn cold, hard cash for qualifying security patches to the Polymer library. Visit the patch rewards page to find out more.

The PRP is different from VRP (vulnerability rewards), so I don't know if Google pays for vulnerability reports for Polymer, but can find out if you're interested.

Thanks @mikesamuel. Appreciate clarification on contact point. Noted.
Closing as answered.


Support for up to 4v4

Currently the scoreboard only supports 2v2, while games usually go up to 4v4 or are often unbalanced. Making the first 2 players on each team necessary and the other 2 unnecessary would solve the issue

Potentially changing games table to:

game_id
player_id

1
1

1
2

...
...

1
n_players

Or was that another table?

Yes, game_stats records players in each game so it will scale as you've written it here.

Fixed here


3.2.0 crash

Generating empty locale.yml and this error https://pastebin.com/raw/Dwgc7xd4

Fixed by latest


eventqueue: use mutex to synchronize access to events channel

Previously, a sync.WaitGroup was used to ensure the events channel for a given
EventQueue was not closed while a call to Enqueue was in in-flight. However,
a panic could result when stopping a queue, which called Wait on said
WaitGroup, and multiple calls to Enqueue were called while said Wait was
happening:
panic: sync: WaitGroup is reused before previous Wait has returned

goroutine 55 [running]:
sync.(*WaitGroup).Wait(0xc000360120)
        /usr/local/go/src/sync/waitgroup.go:132 +0xae
github.com/cilium/cilium/pkg/eventqueue.(*EventQueue).Stop.func1()
        /go/src/github.com/cilium/cilium/pkg/eventqueue/eventqueue.go:279 +0x18a
sync.(*Once).Do(0xc000360114, 0xc0000e57b8)
        /usr/local/go/src/sync/once.go:44 +0xb3
github.com/cilium/cilium/pkg/eventqueue.(*EventQueue).Stop(0xc0003600f0)
        /go/src/github.com/cilium/cilium/pkg/eventqueue/eventqueue.go:269 +0x81

This occured because the WaitGroup is waiting while at the same time that
WaitGroup has more deltas being added to its internal counter. Replace this
WaitGroup with a mutex that is Locked when closing the events channel,
blocking out in-flight calls to Enqueue. Calls to Enqueue take an RLock so
multiple Enqueues can occur at the same time without a problem.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>Fixes: #8818
TODO: I'm unsure how to unit test this without changing the signature of the EventQueue. I'm wondering whether it would be useful to have a field that contains some tunability for how we handle events in the EventQueue? E.g., delays at different parts of the pipeline. I'm open to suggestions here.

This change is

test-me-please

Coverage increased (+0.001%) to 44.192% when pulling 7336aefad14cc46cfa743ec14efb5f755e5075c3 on pr/ianvernon/eventqueue-waitgroup-fun into 92d9bbcee544e34439a7ba8479964b8b7759a20d on master.

Nice catch


Bug fix for segfault iss #1795

This fixes a UI related segfault due to a stale observer reference in VTK. This was first found in issue #1795 where a python application segfaults if you delete and recreate the f3d engine.

I'm unsure how to generate synthetic vtkWindowEvents for testing, I guess I could make a c++ test for this?

For the test there is a thing where I believe due to memory layout issues the segfault is inconsistent. I could only get it to reliably detect the segfault by repeating the test multiple times. Currently I set that to 5 since that almost always catches the bug in my testing, but we might want to change that or install some kind of other memory validation.

not really sure why the last two tests are failing, any advice would be appreciated.

Currently I set that to 5 since that almost always catches the bug in my testing, but we might want to change that or install some kind of other memory validation.

Thats fine, memory issues are like that :)

not really sure why the last two tests are failing, any advice would be appreciated.

Not sure about the static analysis error, it seems unrelated.
About the crash with VTK 9.2.6, I can try to reproduce locally next week.

not really sure why the last two tests are failing, any advice would be appreciated.

VTK v9.2.6: Probably due to an already fixed bug in VTK, just not add the test with VTK 9.2.6 in the CMake logic
static_analysis: I dont get why this would be wrong and definitely not caused by ytour changes , is your branch based on master ?

The static analysis error is unrelated but it looks valid, the real question is why is it showing up only now?
library/src/interactor_impl.cxx:1049:66: style: Unused variable: doc [unusedVariable]
  std::vector<std::tuple<std::string, std::string, std::string>> doc;

https://github.com/f3d-app/f3d/blob/27d1e8a117b978bf830cc7d3a8601827f18309ed/library/src/interactor_impl.cxx#L1041-L1053

The static analysis error is unrelated but it looks valid, the real question is why is it showing up only now?
library/src/interactor_impl.cxx:1049:66: style: Unused variable: doc [unusedVariable]
  std::vector<std::tuple<std::string, std::string, std::string>> doc;

https://github.com/f3d-app/f3d/blob/27d1e8a117b978bf830cc7d3a8601827f18309ed/library/src/interactor_impl.cxx#L1041-L1053

Good point, moving this discussion to: https://github.com/f3d-app/f3d/pull/1848

The static analysis error is unrelated but it looks valid, the real question is why is it showing up only now?
library/src/interactor_impl.cxx:1049:66: style: Unused variable: doc [unusedVariable]
  std::vector<std::tuple<std::string, std::string, std::string>> doc;

https://github.com/f3d-app/f3d/blob/27d1e8a117b978bf830cc7d3a8601827f18309ed/library/src/interactor_impl.cxx#L1041-L1053

Good point, moving this discussion here:

(my bad, I did not intend to do that)

Anyway, static_analysis CI is fixed in master @hant-hub


Resets (bomb resets) update to current standards and clarify best practices

People do bomb resets, even as beginners. They're an absolute staple of mapping. As such, it would be best to remind them of best practices around them as part of basic mapping.
I find a lot of problematic bomb resets when reviewing verified mapper applications, and not being able to point to the wiki for it feels wrong.

Added another commit to add a checklist to the "How to Testplay" guide.


Adding Json file to read the static data.

I'm planning to add the static data in the json file.
Reason why I am planning to do:

when anyone wanted to host there personal website they just need to change that json file and portfolio is ready.
Easy to modify details in the production (Need to change the Json file and we don't need to go for re-deployment)

@bchiang7 your thoughts? I am happy to work in this enhancement

Hi @amittttt, since my site isn't meant to be a template I'm going to say no thank you!

Hi @amittttt, since my site isn't meant to be a template I'm going to say no thank you!


Add Wilhelm Scream to male scream sfx

AAAAAOAAAAA

I am pretty sure this is already in the game and just has an extremely low chance of playing.

I checked it is, it is in fact coded into the vocalcomponent itself and has a 2% of playing every time anyone screams. You should just use that file. /Audio/Voice/Human/wilhelm_scream.ogg

Huh, TIL. Well then.


The strategy of increasing alpha every epoch

Hi, I see that in your code, you increase the alpha values every epoch
if (iteration % data_len) == 0:
       current_epoch += 1
       i = 1

p = float( i + current_epoch * data_len) / max_epoch / data_len
alpha = 2. / (1. + np.exp(-10 * p)) - 1
i+=1

alpha3 = alpha
alpha4 = alpha
alpha5 = alpha

can you please share to me what strategy for increasing alpha you are using? do you base on any existing methods? Thank you very much!

Hello, thanks for your question, we used the strategy proposed by the author of "Unsupervised Domain Adaptation by Backpropagation".
Link: https://arxiv.org/pdf/1409.7495.pdf
Image:

Great! thank you!
Btw, I have starred your repo

I saw that within uda_train.py, you fixed
max_epoch = 41.27
data_len = 1502

why did you fix it? if I try to adapt your code to my own dataset, can you please share to me your experience how to tune these 2 parameters? Thank you!

max_epoch = number of iterations / min ( len(source), len(target)
In other words, to get the max number of epoch you need to divide the number of iterations (in our script is 62k) with the minimum len size between your source-target dataset (1502 in our case)
62000/1502 = 41.27

I see, thanks a lot!


feature request: emplace_or_patch

I find myself often wanting to do an emplate_or_patch operation -- if an entity has the component, patch it as normal.  But if it doesn't exist, create one with initial values and then patch it with the function. "Initial values" could be defined as brace-or-equal initializers for structs:
struct myComponent {   int thingy = 10; };
Or a default constructor for classes.

Hi, sorry for being late.
get_or_emplace was introduced for this kind of patterns. Wouldn't it work as well in your case?

I often want to update a value in a component that may not exist, so I need to do a multi-step process:
int old_val = 0; if (reg.has<Component>(ent)) {   old_val = reg.get<Component>(ent); } reg.emplace_or_replace<Component>(ent, old_val + change_val);
it looks like I can use get_or_emplace I think?  I didn't see that before.
int old_val = reg.get_or_emplace<Component>(ent, 0); reg.replace<Component>(ent, old_val + change);
If you think that's performant that would fulfill my use-case.

That's definitely the way to go. Yeah.
It's also far easier to work with and to maintain than a get_or_patch from my point of view.

I close this one as I suspect that the answer was satisfactory. 🙂
Feel free to continue the discussion here if you've any other doubt. 👍


Add EKS Best practices policies

Sample policies for https://github.com/nirmata/kyverno-aws-adapter/issues/42

Do you have test cases for these somewhere?

Do you have test cases for these somewhere?

@chipzoller  The tests for these policies will be added in https://github.com/nirmata/kyverno-policies repo