Fix claim showing incorrect parent facility

Overview
The claim facility form was correctly submitting and saving the
contributor name and contributor id; however, when serializing the data
for fetching it, we were incorrectly grabbing the user id. This caused
the form to display the incorrect contributor in the dropdown.
Claims now correctly serialize the parent_facility with the contributor
id, not the admin user id.
We have run into similar bugs many times, because in development, the
default contributor and user IDs match. This has
caused us to miss a number of bugs related to mixing up contributors
and users when working with data (because these two entities are used
somewhat interchangeably). In addition to updating the claim serialization,
the IDs of contributors and their associated users have been updated in our 'fixtures' files,
and now will no longer match after running resetdb, which will
hopefully prevent this category of bug.
Connects #1685
Demo

Testing Instructions

Checkout this branch, then checkout commit 1073cd3. Run ./scripts/resetdb.
Navigate to a claim and save a parent company using the form, then refresh the page. Note that the displayed parent company is not the one you saved.
View the same claim in the Django admin and confirm that the stored parent company is correct.
Checkout commit 4ae4282 view the same claim's claim form. Confirm that the displayed parent company is correct.
Resave with a new parent company and refresh the page and confirm that the correct parent company is saved and displayed.

Checklist

[ ] fixup! commits have been squashed
[ ] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Thank you for reviewing!


Feature Request: Import links directly from xBrowserSync JSON

Type

[x] General question or discussion
[x] Propose a brand new feature
[ ] Request modification of existing behavior or design

What is the problem that your feature request solves
I would like to be able to add the links I have bookmarked in xBrowserSync directly into ArchiveBox.
Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes

I would like to be able to:

Add links directly from the xBrowserSync json format. This would require a parser to be added.
Subscribe to my xBrowserSync "sync" (basically account), and update links as needed. This would require specifying URL and password in the configuration and/or in the CLI. This would also require adding decryption, decompression, and parsing of the json.
Filter which folders the bookmarks are added from. There are lots of bookmarks I have that have no need to be in archivebox. This is part where I am not sure if there are more changes that would be required, specifically if filtering inputted links is more global, or if it is just for this.

The json format is the same for both the backup/export from the extension, and directly from the API. From the web API, it first has to be decrypted (AES-GCM), and then decompressed (lzutf8).
I do currently have a python script for doing this, but I'm not sure what changes would need to be made to integrate with ArchiveBox. I'm new to python, so there probably lots of things that aren't ideal python practice.
https://github.com/TheCakeIsNaOH/xbs-to-archivebox
I'm definitely willing to work on developing this, I'm just checking in / looking for feedback before starting work.
Useful links:
https://api.xbrowsersync.org/
https://github.com/xbrowsersync/app/issues/105
https://gist.github.com/nero120/e878e40b14655c9526680472376b4f8c
https://github.com/b-01/lzutf8.py
What hacks or alternative solutions have you tried to solve the problem?

I currently use a python script to download, decompress, and filter my xBrowserSync bookmarks, and it outputs a list of URLs that I then manually add to ArchiveBox. See the previous section for link. I would prefer that this be built into ArchiveBox.
How badly do you want this new feature?

[ ] It's an urgent deal-breaker, I can't live without it
[ ] It's important to add it in the near-mid term future
[x] It would be nice to have eventually

[x] I'm willing to contribute dev time / money to fix this issue
[x] I like ArchiveBox so far / would recommend it to a friend
[ ] I've had a lot of difficulty getting ArchiveBox set up

Some more discussion here: https://forum.level1techs.com/t/thecakeisnaohs-devember-xbrowsersync-to-archivebox-and-misc-programming/162649/10


Use same defaults as listen command

Now you must set a queue will this command work. Use defaults from configuration like listen command.

You are right 'null' is not required thank you very much for your contribution.


System.NullReferenceException when unit testing endpoint with Mapper

I have a Unit Test that runs fine in version 4.3.1 of FastEndpoints but throws System.NullReferenceException in the latest version (5.3.1) because "Map" property is null.
Endpoint code:
public override async Task HandleAsync(GetRequest r, CancellationToken ct)
    {
        var participant = await ParticipantRepository.GetByIdAsync(r.Campaign, r.Id, ct);

        if(participant == null)
        {
            await SendNotFoundAsync(ct);
            return;
        }

        var response = Map.FromEntity(participant); // Map is null here, but only in latest version of FastEndpoints
        await SendOkAsync(response, ct);
    }

In the unit test code, I am creating the endpoint instance with the following code:
var e = Factory.Create<Get>(Mock.Of<IParticipantRepository>());
I have tested with 4.3.1 because I have a very similar api that is working fine in 4.3.1, then I decided to give it a try and it worked.
Version 5 does have some breaking changes, but it seems not related with this case.

you now have to set the mapper (Map property) before calling the handle method like this:
https://github.com/FastEndpoints/FastEndpoints/blob/60c171af30fcd357cbf06e975d7e290cb92146e3/Tests/UnitTests/FastEndpoints.UnitTests/WebTests/UnitTests.cs#L15-L27


Upgrading Async Profiler to 1.8.5

Closes #1702

[ ] I have updated CHANGELOG.asciidoc
[ ] I ran sanity tests

Codecov Report

Merging #1713 (1e4075d) into master (f16425b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1713      +/-   ##
============================================
+ Coverage     58.37%   58.38%   +0.01%
  Complexity       92       92
============================================
  Files           422      422
  Lines         18832    18832
  Branches       2609     2609
============================================
+ Hits          10994    10996       +2
+ Misses         7064     7062       -2
  Partials        774      774

Impacted Files
Coverage Δ
Complexity Δ

...ic/apm/agent/profiler/collections/LongHashSet.java
17.46% <0.00%> (+0.79%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16425b...1e4075d. Read the comment docs.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1713 opened

Start Time: 2021-03-22T08:41:56.022+0000

Duration: 52 min 2 sec

Commit: 1e4075d513d7e145fa716f10ca92e7b1128b44b8

Test stats :test_tube:

Test
Results

Failed
0

Passed
1883

Skipped
15

Total
1898

Trends :test_tube:

:green_heart: Flaky test report
Tests succeeded.

Expand to view the summary

Test stats :test_tube:

Test
Results

Failed
0

Passed
1883

Skipped
15

Total
1898


Fix race adding configuration in BuildManager

We have crash reports of a race condition in the AddNewConfiguration
method. Adding a lock to the only entry to that method currently without
a lock.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/548385

I'm very confused by the access/locking rules here. Do we need to guard all write accesses to _configCache in BuildManager? Several remain unguarded, including the BuildManager.AddNewConfiguration that's throwing in the bug, presumably because a configuration was inserted between GetMatchingConfiguration and AddNewConfiguration. I think this large lock is sufficient, since it's the public entry point I can find for AddNewConfiguration, but how will we know if it's too broad?

@rainersigwald I think the lock is not too broad. There's writes to shared state here and there all the way to the dataflow post method, which should be quick since it's async.

@dotnet-bot test this please

@dotnet-bot test OSX10.13 Build for CoreCLR please

@dotnet-bot test OSX10.13 Build for CoreCLR please


Add project Hall

This project prints the realtime counter and torque values in adc
counts. Analog sample speed is increased to 8 kHz for this project and
is used for determining torque scaling values. Transmits value as ASCII
using serial over USB.

@mickvangelderen Nothing specific, just wanted you to be aware of changes to the repository. I've also required at least one approved review before a PR can be merged on github.

@oliverlee I see. However it does not feel good to "approve" changes in a review when I've only glanced over it. If I say I reviewed something, I want to actually have thoroughly read, understood and critiqued it.

@mickvangelderen I'm in no rush to merge this so if want to review it, feel free to do so when you have time. If not, I will merge as is.


Can't see my own GPS Traces in iD on Firefox

I can't seem to see any of my own GPS Traces (both old ones and recently uploaded ones) in Firefox Quantum 60.0.2 (64-bit). The strange thing is I can see other people's GPS Traces, just not my own.
I tried the Firefox mobile browser and my GPS Traces are showing OK just not on PC. It's a little frustrating as I can't edit on mobile.
This has only started to happen recently. My GPS Traces used to display fine. I've checked the Visibility Checklist https://wiki.openstreetmap.org/wiki/Visibility_of_GPS_traces and tried uploading with different permission but they are still not showing.

Can you share a gpx trace that you'd expect to have show up?
Also, if you can open up the developer console in Firefox, it might be able to give some more information about why it won't show the trace.  (Maybe it wanted to download the trace, but refused to because of a mixed content issue - gpx is being served with http and iD served with https?)

Here's an example of a GPS trace which is uploaded OK, but when I go to the map and turn on the GPS Traces, I can't see it: https://www.openstreetmap.org/user/explorewiki/traces/2730963

Firefox Console Log when Viewing the Map:
Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively. Will-change memory consumption is too high. Budget limit is the document surface area multiplied by 3 (508896 px). Occurrences of will-change over the budget will be ignored.
Firefox Console Log when Editiing the Map:
Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively. Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive. Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive. Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.

Aren't those traces pulled in as PNG layer via https://{a,b,c}.gps-tile.openstreetmap.org? Can you see your traces on https://gps-tile.openstreetmap.org?
I don't recall what the update interval of those GPS trace tiles is, but that might be the root cause for not seeing your traces.

I can see every one else's traces on https://gps-tile.openstreetmap.org, but I still can't see my own traces.
I have given my recent traces over a week to update but I still can't see them. They used to show up within a few minutes. The thing is that I could see all my traces OK just a month ago. and now they are no longer showing for me.

Oh, I guess this is about the generated GPS traces layer - we don't control this.
There are some things you can try on #2450

Upstream issue was resolved. This should work now as expected.

Oh great thanks, I'll check it out!

I'm having this problem again, is there an issue with upstream again? I can't see my uploaded GPS traces once again.

It was fixed again today: https://github.com/openstreetmap/openstreetmap-website/issues/1980#issuecomment-419708003


After ending a turn with a weapon equipped, that same weapon does not behave properly in the hands of other worms.

Steps to Reproduce

Start a game by adding a bot
Switch turn to your own player
Equip a weapon, use it, end turn and cycle to your next worm
Equip the same weapon, and notice the weapon does not appear, but your original worm has the correct HoldPose.

Fixed in my branch


Fix audio driver wasapi audio input handling

Related to this issue: https://github.com/godotengine/godot/issues/75603

is this PR need tests before to be merge?

Unfortunately I don't think there aren't very many consistent audio contributors who run Windows so historically WASAPI driver changes have been hard to review. So yeah, it would be good if a few people could provide before and after test results in as many different configurations as possible (different mix rates at the operating system level if possible, ideally different kinds of output devices like integrated and usb sound cards). Also for my benefit since I can't test this personally it would be really wonderful there was a more detailed description of the change in the PR description, and details about why you implemented things in the way that you did. Ideally also links to documentation when relevant.
My hesitation comes mostly from the fact that there are already WASAPI driver bugs that only affect a very small percentage of users, and I don't think anybody knows what's causing them or how to fix them. I don't want to create more bugs like that.
@MJacred I saw you commented on the issue this fixes. If this issue is affecting you it might be good to take a look :)
I should also say that I'm too nervous about approving WASAPI driver changes to make a final call and I'm probably going to ask that Juan review it if people provide positive test results and I decide things make sense after cross-referencing all the changes with MSDN. I know that's going to be a lot of work but I want to be pretty sure it's ready before asking him for a review.

Its been a while since this PR was opened so I need a little time to assess everything but I`ll be checking if this is still needed/relevant/correct asf...

@ellenhp: Thanks for thinking of me! Though I only commented there because I knew that Godot 3 was affected as well due to me maintaining the Audio Issue Tracker and I'm currently not affected by this

I Relinquish control, sadly i have no idea anymore :(
Sorry

@AThousandShips is your code modification need tests?

What are you asking?

What are you asking?

Sorry, I read a bit fast the code block above, I understood you wrote this code

I made suggestions, I didn't write the original code, it's not my code


[BUILD] compare commits and contributors

:mag: Description
Issue References 🔗

This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (d3520dd) to head (0e357ee).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6780   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         687     687
  Lines       42439   42439
  Branches     5793    5793
======================================
  Misses      42439   42439

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you for raising this PR, @bowenliang123
Shall we merge this with https://github.com/apache/kyuubi/blob/master/build/release/pre_gen_release_notes.py#L211-L236

Thank you for raising this PR, @bowenliang123
Shall we merge this with https://github.com/apache/kyuubi/blob/master/build/release/pre_gen_release_notes.py#L211-L236

I didn't realize the existing script pre_gen_release_notes.py.


Bookstore style

👇 The following feature was added to the branch 👇 👇
👉  Styling for the project layout was added.
👉  Bootstrap Icon was used as a user profile

Thanks so much!!!


Add ability to show more then 250 issues per file in problems panel

VSCode currently limits 250 diagnostics per file per DiagnosticsCollection. This prevents us from showing all of the results in a file if it's greater then 250. We currently display a custom error message after 249. A couple of possible ways to go above 250(I'm in favor of the first option):

In the extensions DiagnosticsCollection Controller we could add an array of DiagnosticsCollections and once a collection hits the cap for a file, it then move to the next collection and fills it up. We could then establish our own limit that makes more sense for a sarif file's results, ex. 4 collections for total of 1000 results max.

Second option would be to keep it at 249 and let the user click the custom(250th) one we add and it will cycle through to the next set of 249 for that file. This might be difficult to communicate to the user and it might get confusing to not be able to track where you are in the rotation through the errors.

Sort and other options should work against complete set.
Let's focus on the our separate view that show all content for now.

closing this issue as we're tracking the sortable table in a different issue #28


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 16:54:29 on 2023.08.07
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 34676
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=34676

Problem has been resolved in 3m 0s at 16:57:29 on 2023.08.07
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 34676


Add test resources for global var tests

These were added from https://github.com/ballerinalang/ballerina/pull/3527. Hence closing.


[BUG] Fail to run interactive: illegal instructions

System info
Linux ip-172-31-37-103 6.5.0-1014-aws #14~22.04.1-Ubuntu SMP Thu Feb 15 15:27:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

It is so strage

Similar problem when running Interactive image on MacOS(M2);

details

The image was built on linux arm64 machine, and it seems to work fine on a linux arm64 machine Linux 5.10.134-16.3.al8.aarch64 #1 SMP Tue Mar 26 18:51:35 CST 2024 aarch64 aarch64 aarch64 GNU/Linux
MacOS: Darwin 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:23 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6020 arm64


Mac version not working with newest OS

Mac Browser Issues.pdf

Mac Browser Issues2.pdf

Seems to be an issue with newer versions of MacOS... will get it fixed ASAP

Need to bump TrackBrowser's components with newest versions.

Commited b86873eea9953903e4936cb496975fd9f53102a9 to repackage TrackBrowser with updated component versions

Uploaded a fixed version to tb-app9.1-mac.zip, closing issue


Updated Italian translations

Updated the Italian po file.

coverage: 59.81%. remained the same
when pulling 7c45f308c2cd9252f453f84d62f9d46f1d830165 on scompo:master
into b5a3e985590ed57ea73a94ef63226ca3f6914f9b on newsboat:master.

coverage: 59.81%. remained the same
when pulling 7c45f308c2cd9252f453f84d62f9d46f1d830165 on scompo:master
into b5a3e985590ed57ea73a94ef63226ca3f6914f9b on newsboat:master.


Update Linux dependencies in README.md

Test: building workerd on a fresh Ubuntu 22.04.2 desktop system

Change looks good to me, except that it converts line endings to Windows-style CRLF, resulting in a bloated diff
Nit: (Bullsey => Bullseye)

Change looks good to me, except that it converts line endings to Windows-style CRLF, resulting in a bloated diff Nit: (Bullsey => Bullseye)

Thanks Felix, fixed!


Geocoding API's response was not valid JSON

I am getting this error after upgrading to geocoder (1.1.1)
Calls like this is returning NIL. I have had others try it and it is confirmed.
Geocoder.search("<IP_ADDRESS>").first.city
NoMethodError (undefined method `city' for nil:NilClass):
At first I thought it was Yahoo freaking up so then I applied for a Bing key and that is still giving me the same issue.

I'm seeing this issue when I try to call Bing API in loop(like 180 requests for Geo in less than a minute). Do you guys have any suggestions on how to actually implement system which would call Bing Geo API quite frequently. Should I start using queue and populate these calls separately for every object. I have right now around 90k records in DB and I need to obtain geolocation for them. Any advices?


Update qemu version to latest 3.x

I had big issues getting networking to work with qemu.
In the end it worked after recompiling qemu with git checkout -f v3.1.1.
I also tested the versions v4.1.0 and v4.0.0, but those didn't compile with the riscv64-softmmu target.
Furthermore, I found that Fedora distributes pre-built disk images, which are way easier to use than compiling Linux yourself.
Should this tutorial be updated?
#QEMU still needs to be built from source though.

wget https://fedorapeople.org/groups/risc-v/disk-images/stage4-disk.img.xz
wget https://fedorapeople.org/groups/risc-v/disk-images/bbl
wget https://fedorapeople.org/groups/risc-v/disk-images/vmlinux
xz -d -k stage4-disk.img.xz

qemu-system-riscv64 -nographic -machine virt \
    -m 2G -smp 4 \
    -kernel bbl \
    -object rng-random,filename=/dev/urandom,id=rng0 \
    -device virtio-rng-device,rng=rng0 \
    -append "console=ttyS0 ro root=/dev/vda" \
    -device virtio-blk-device,drive=hd0 \
    -drive file=stage4-disk.img,format=raw,id=hd0 \
    -device virtio-net-device,netdev=usernet \
    -netdev user,id=usernet,hostfwd=tcp::10000-:22

After some digging I found newer versions and a longer installation instruction:
https://fedoraproject.org/wiki/Architectures/RISC-V/Installing
https://dl.fedoraproject.org/pub/alt/risc-v/disk-images/fedora/
(I'm posting this for completenes)

Thanks! Sorry for missing this. I ultimately included Alistair's PR which renders this obsolete. Appreciate your feedback though, hopefully the new instructions work for your use case.

Well, I've stoped playing around with RISC-V, so I won't test it, sorry.
Thanks for responding though.


[Bug] fix RayActorOptionSpec.items.spec.serveConfig.deployments.rayActorOptions.memory int32 data type

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen

Amount of serve deployment's memory expected in bytes. Data type for memory expected in int32 for RayActorOptionSpec.items.spec.serveConfig.deployments.rayActorOptions.memory (link to source code). In my case, I cannot specify amount of memory equal to 3.5Gb (logs from kuberay-operator in 3 section).
Expected behavior - kuberay-operator supports uint64 data type (or int64).
Logs from kuberay-operator:

W0628 20:13:46.926544       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.23.0/tools/cache/reflector.go:167: failed to list *v1alpha1.RayService: json: cannot unmarshal number<PHONE_NUMBER> into Go struct field RayActorOptionSpec.items.spec.serveConfig.deployments.rayActorOptions.memory of type int32
E0628 20:13:46.926578       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.23.0/tools/cache/reflector.go:167: Failed to watch *v1alpha1.RayService: failed to list *v1alpha1.RayService: json: cannot unmarshal number<PHONE_NUMBER> into Go struct field RayActorOptionSpec.items.spec.serveConfig.deployments.rayActorOptions.memory of type int32

Reproduction script
Just create random serve deployment with memory requests over than 2Gb. In my case next deployment raise error from above log.
from ray import serve

@serve.deployment(
    ray_actor_options={"memory": 3.5 * 1024 * 1024 * 1024}
)
class DummyApp:
    pass

app = DummyApp.bind()

Anything else
Thread in ray slack.
Ping: @kevin85421
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

I found something interesting: the memory field in the Ray Serve schema is specified as type float, and it is measured in bytes. Let me figure this out.
https://sourcegraph.com/github.com/ray-project/ray@ac2230f/-/blob/python/ray/serve/schema.py?L43-L49

[Update]

I found something interesting: the memory field in the Ray Serve schema is specified as type float, and it is measured in bytes.

The memory field is used to specify logical memory rather than physical memory. That is why it is of type float. It is very confusing.
I have already opened a PR #1120 to fix this issue. However, if you are comfortable with the nightly KubeRay, I will strongly recommend you use serveConfigV2 rather than serveConfig. serveConfig will be deprecated in the future.


Fixed typo on command line 93

@robmazz @AndreaBarr The PR that fixes a minor typo is available for review. Thanks.


Fix scripts for integration test

Description:
Resolves #

Codecov Report

Merging #54 (b8f2b79) into master (7e4d7d9) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   81.18%   81.35%   +0.16%
==========================================
  Files          13       13
  Lines        1185     1185
==========================================
+ Hits          962      964       +2
+ Misses        167      166       -1
+ Partials       56       55       -1

Impacted Files
Coverage Δ

pkg/controllers/machine_controller.go
74.92% <0.00%> (ø)

pkg/controllers/machinenodepool_controller.go
80.00% <0.00%> (+0.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4d7d9...b8f2b79. Read the comment docs.


Service Info does not provide a service name

In the Discovery step python support respond EntitySpec without service name

Despite answering the Entity's service_name, python does not include any service_name in ServiceInfo.


Fix logging - currently very complex and a bit of a mess

This is related to settings, see #156
To solve this, baw-workers needs a way to be run as a script, and get settings from baw-server. The current solution using settingslogic is becoming unmanageable.

This will get worse with more instances. Need better ways to manage log files.


Confusing recomandation for the max password length set to 14.

Hello,
I am confused by the statement in the article : A minimum password length greater than 14 isn't supported at this time.
According to this article https://support.microsoft.com/en-us/topic/minimum-password-length-auditing-and-enforcement-on-certain-versions-of-windows-5ef7fecf-3325-f56b-cc10-4fd565aacc59 passwords can be longer than 14 characters.
Can you please provide more info in what context a password longer than 14 characters is not supported ?
Kind regards,
Razvan

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9bcaf30b-7304-6874-ba5d-791cc4d435d2
Version Independent ID: 961def9f-094a-3d1e-82a4-bb152c2e5a1e
Content: Minimum password length - Windows Security
Content Source: windows/security/threat-protection/security-policy-settings/minimum-password-length.md
Product: windows-client
Technology: itpro-security
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

The Minimum Password Length policy defines the minimum length that the password should have, so a value of 14 means the password must be over 14 characters. A password can be over 14 characters, but the value of the "Minimum Password Length" policy cannot be over 14. Hope that helps.

Thanks for your reply. Reading again my message I realize that I was not very clear. If I want to set a minimum password length higher than 14 characters this article mentions that it is not supported however the article https://support.microsoft.com/en-us/topic/minimum-password-length-auditing-and-enforcement-on-certain-versions-of-windows-5ef7fecf-3325-f56b-cc10-4fd565aacc59 states that the update can enforce passwords which have a minimum password length higher than 14 characters. Thank you for your help.


Unknown Role WEBHCAT

Hi,
if i  want to to deploy the role WEBHCAT i get the following error:
fatal: [cm001.cdp.lan]: FAILED! => {
    "assertion": false,
    "changed": false,
    "evaluated_to": false,
    "msg": "Unknown role(s) ['WEBHCAT'] defined in configuration block for 'HIVE' in cluster 'cdpdevbase'."
}

Regards
Uli

adding webhcat to roles/deployment/repometa/templates/role_mappings/cdh7.j2 will solve the issue


Prevent client busybox container from exiting prematurely

This fixes busybox, but the documented task still doesn't work. First thing I noticed is that in the curl command is wrong: kubectl exec -it ${CLIENT} -c echo -- curl echo:80. It should be -c busybox. After changing that, however, it still doesn't work (curl returns 404)

Works for me

Thanks for verifying Frank. I opened https://github.com/istio/manager/issues/683 to track the issue of k8s service being required on the client-side to use non-FQDN.


openai, azure: update model_name in ChatResult to use name from API response

The response.get("model", self.model_name) checks if the model key exists in the response dictionary. If it does, it uses that value; otherwise, it uses self.model_name.

@efriis, please proceed with the merge if the changes are accurate and appropriate.

resolves #22516

Thanks for fixing this and merging this so quickly, this was my first issue and it was so nice to see it acted on so fast @isatyamks @ccurme


Exception: ϵͳҲָ· in install_or_update

plugins loaded
Package Control: Skipping automatic upgrade, last run at 2023-04-11 09:58:44, next run at 2023-04-11 10:58:44 or after
Unable to start subprocess for LSP-ruff
Traceback (most recent call last):
File "D:\sublime_text\Data\Installed Packages\LSP.sublime-package\plugin/core/windows.py", line 241, in start_async
plugin_class.install_or_update()
File "D:\sublime_text\Data\Packages\lsp_utils\st3\lsp_utils_client_handler\abstract_plugin.py", line 109, in install_or_update
server.install_or_update()
File "D:\sublime_text\Data\Packages\lsp_utils\st3\lsp_utils\server_pip_resource.py", line 100, in install_or_update
self.run(self.pip_binary(), 'install', '-r', dest_requirements_txt_path, '--disable-pip-version-check')
File "D:\sublime_text\Data\Packages\lsp_utils\st3\lsp_utils\server_pip_resource.py", line 35, in run
raise Exception(error)
Exception: ϵͳҲָ·

What's your LSP, ST and OS version?
Do you have Python installed?
Is the Python module venv (python3-venv in Linux repos) installed?

I use ST4 in win11
I choose python3 in msys2, and I put the PATH to the system environment variable.

What happens if you run python -m venv in a terminal?

python -m venv    : it show  venv: error: the following arguments are required: ENV_DIR
python -m venv .  : it create a environment.

Is it means that  " tools -> lsp -> Toggle Log Panel "   ?
It shows me nothing.

@rchl Do you have an idea?

@rchl Do you have an idea?

It seams the wrong with lsp. the lsp can,t find path of pip or python in the msys2 .

The lsp search "pip" in the path like "Scripts" ,but msys2 haven,t that path.
Can we set the ruff-lsp path in the config?

We can probably adjust the logic so that it works with msys2 also. Maybe instead of checking platform just check for existence of the directory.

Can we set the ruff-lsp path in the config?

I think you might be able to override command in LSP-ruff.sublime-settings but you'd be loosing the benefit of this package that automatically maintains the ruff server for you.

// Settings in here override those in "LSP-ruff/LSP-ruff.sublime-settings"
{
"command": [
"D:\UsrCmd\msys64\ucrt64\bin\ruff-lsp.exe"
],
}
I set the config like this.

No and I won't be looking into it myself.
I would suggest using native python instead of msysgit.


React18 refactor Todo

Remove ReactDOM by using modern RTL setup (see below)
Scope styles to the component better by not using named exports, but make sure they are not shared in another component as with some niche cases (see below)
Add this component to the docs, you might get lucky and its already there. There is a bunch of tools to make the gifs, i like Quicktime but a search will prob find even easier tools
make sure all possible renders / versions of this component are rendered in Storybook, some times we forget and hide great features
standardise the hell out of the names please, see here for reference https://github.com/web3ui/web3uikit/blob/master/CONTRIBUTE.md#css-naming-an-element

Test like this
import {
    render,
    screen,
    fireEvent,
    act,
    waitFor,
} from '@testing-library/react';

const copyIconTestId = 'this-component';

test('Should render the component', () => {
    render(<ThisComponent />);
    const element = screen.getByTestId(copyIconTestId);
    expect(element).not.toBeNull();

    // Verify that the `icon copy` is visible
    expect(element.textContent).toBe(`${iconTypes.copy} icon`);
});

Scope CSS like this
this is bad, intellisense is going crazy
export const ButtonStyled = styled.button`
   // CSS stuff here
`;

this is better
const ButtonStyled = styled.button`
   // CSS stuff here
`;

export default {
  ButtonStyled,
}

then import like this
import styles from './ThisComponent.styles';

const { ButtonStyled, } = styles;

need help?
check this PR i already did this for Accordion =]
https://github.com/web3ui/web3uikit/pull/356

@BillyG83
this is fixed in the todo refactor i worked on earlier this week


Logout in oblogout ask confimation

hi all,
i'm having doubts about the logout command in oblogout.
=> menu have: <Exit label="Logout" confirm="false"/> and does not ask confirmation.
=> oblogout have: jwm -exit and ask for confirmation.
image here https://forum.manjaro.org/index.php?topic=30486.msg252430#msg252430, ask for conformation!
i would like to know how to avoid confirmation.
vlw fwi, Holmes

It  works :

=> menu have:  and does not ask confirmation.
=> oblogout have: jwm -exit and ask for confirmation.>

Please write a version of JWM.

I set this in a non used menu JUST for this purpose
<RootMenu height="0" onroot="z">
        <Exit label="Logout" confirm="false" icon="system-logout.svg"/>
    </RootMenu>

This works for me.
It has worked since Joe implemented a-z menus
I didn't use it before, so I cannot tell if it worked before.
pkill -u $USER is not a really nice way to do things IMO, but it is your distro :)
If you guys want an example of a working fully functional jwmrc
You can check the ToriOS version
http://bazaar.launchpad.net/~torios-dev/torios/trunk/view/head:/etc/skel/.jwmrc
This has a full set of key bindings that are compliant with most GNU/OSX/Windows key bindings.
We also have a bunch of scripts to do a lot of the work for our users, such as icon theme generation, volume control (using amixer) we have scripts to generate menus, but we also have binary programs for the applications, and 'places' menus.  It might be good to collaborate at some point if you are interested.

hi guys, my idea is to add the jwm -exit in oblogout.  however, I would like to remove the confirmation of JWM:
**
Exit JWM
Are you sure?
OK Cancel**
how to remove the Exit in oblogout?
ps: version JWM = 2.3.4.
vlw fwi, Holmes :)

The way JWM currently works is somewhat broken.  The exit confirmation is a global setting even though it appears that it can be configured on a per-item basis in the configuration file.  To fix this, JWM should treat it as configuration for each instance of "Exit" (or "Restart") in the configuration.  Also, JWM should never show an exit confirmation when "-exit" is invoked from the command line.

This should be fixed in snapshot 1370.

thank you Joe and i hope it can be resolved in the next version!
vlw fwi, Holmes :)


remove update template action

I hadn't meant to add the potential action to main to begin with, but in trying to make the manual trigger for the github action appear on my test branch, I accidentally put the draft file on main instead. After digging into a bunch of permissions issues, from the pull_request action it seems:

These restrictions mean that during a pull_request event triggered by a forked repository, actions have no write access to GitHub resources and will fail on any attempt.
So essentially, built in limitations mean that we can't have an action triggered from a fork of a template that will open a PR to update the template.

No worries, I think i temporarily disabled the branch protection to avoid pushes directly to main when working out the tutorial reorganization. just reenabled it to be sure.


Dependency Updater

This pull request includes minor version updates for your package dependencies as well as major version updates for packages with known compatibility. Feel free to commit any additional changes to the shift-du-20190625 branch.
Before merging, you should:

Checkout the shift-du-20190625 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application

:information_source: The following Laravel packages were updated as they are known to be compatible with version 5.8.25 of the Laravel framework. Nonetheless, you should review the CHANGELOG to ensure no additional changes are needed.

[ ] laravel/horizon


882 replacement record information

https://github.com/uwlib-cams/MARC2RDA/blob/main/Working Documents/8XX.csv

https://docs.google.com/spreadsheets/d/1UP1gVndqIQwu84v04kj7pd5axErsNUwD40qSqvwisO4/edit#gid=844913138
Hello Everyone,
Here is the first pass for the spreadsheet for field code 882 - Replacement Record Information (NR). Would anyone like to review it?
Thanks.
Best,
Alice


PHP Fatal Error – yii\base\ErrorException  Call to a member function shareUrl() on string

When I try to add a share link to my post shows me the following error:
PHP Fatal Error – yii\base\ErrorException
Call to a member function shareUrl() on string
', $post->content->shareUrl(ShareLinks::SOCIAL_FACEBOOK),
        ['title' => 'Share to Facebook']) ?>

You are using it incorrect.  shareUrl  could be called only inside widgets template.
Follow usage instructions please https://github.com/iJackUA/yii2-sharelinks-widget#usage-example

Thank you,
It seems that is working now but the buttons for sharing are not showing.
Its displaying ok in chrome developer tool when I inspect the elements.

It doesn't show Icons by default, just letters like "Fb" etc. https://github.com/iJackUA/yii2-sharelinks-widget/blob/master/views/main.php#L13
You need to make a custom view with your own Icons (whatever you like).


parser,backupccl: add BACKUP INTO 'subdir' IN x

PR: https://github.com/cockroachdb/cockroach/pull/53139
From release notes:

Users can now specify which subdirectory they wish to write a BACKUP to, via BACKUP INTO 'subdir' IN x. This will write BACKUP data to x/subdir/. [#53139][#53139] {% comment %}doc{% endcomment %}

After discussing with @mwang1026, I'm holding off on this update until after the 20.2 release, when we have time to put a deprecation plan in place for BACKUP TO. For v20.2:

We'll keep BACKUP TO on the BACKUP statement page
Only surface the new INTO syntax on the CREATE SCHEDULE FOR BACKUP page
The SHOW BACKUPS page will be updated to include SHOW BACKUPS IN y for scheduled backups (this will need to be changed/expanded upon in the future).


AspNetCoreHosting example can run successfully with some small modifications

Add a static public field to Webview class
static public int Port = 0;

Assign that field in the Main() getting the port value from the launchSettings.json

        public static void Main(string[] args)
        {
            Webview.Webview.Port = 11042; // <<<

            CreateWebHostBuilder(args)
                .WithDynamicPort()
                .UseKestrel()
                .WithNoOutput()
                .Build()
                .RunWebview();
        }

Modify the internal Webview constructor passing the Url

            string sUrl = $"http://localhost:{Port}"; // content.ToUri();

            _webview = webview_alloc(
                title,
                sUrl,
                size.Width,
                size.Height,
                resizable ? 1 : 0,
                debug ? 1 : 0,
                cb);

PS. It seems that there is no way to get the "right" application url
using IServerAddressesFeature or any other trick.
If there is such a trick then I'll be happy to know.

You need to use host.Start() to start Webhost before you can use IServerAddressesFeature to get the start address


Failed to load GD scripts after saving dotnet project

Tested versions
Tested in 4.2.1 mono and v4.3-dev5 mono
System information
Godot v4.2.1.stable.mono - Windows 10.0.22000 - Vulkan (Forward+) - dedicated AMD Radeon RX 5700 (Advanced Micro Devices, Inc.; 31.0.21023.2010) - Intel(R) Core(TM) i9-9900KF CPU @ 3.60GHz (16 Threads)
Issue description
I use some plugins;
GameGui (https://github.com/brombres/Godot-GameGUI)
and
Dialogue Manager (https://github.com/nathanhoad/godot_dialogue_manager)
For some strange reason, whenever I make any changes to my code in C#, the first run of the project causes various GD scripts to fail from these 2 plugins.
Not sure what the files that fail shares.
Whenever I run the project the second time, it then runs without issues. If I build the project first and then run it, also no issue.
When I first installed GameGui there was no issue. The error suddenly started happening.
I have tried to use notepad for editing, to ensure VSCode wasn't causing the issue, but the same error happened. It seems to happen when Godot has to reload the scripts.
All the errors combined:

E 0:00:38:0338   load: Failed to load script "res://addons/dialogue_manager/test_scene.gd" with error "Parse error".   <C++ Source>   modules/gdscript/gdscript.cpp:2788 @ load()
Example of errors in the code

Steps to reproduce
I have tried to no avail to recreate the bug...
Minimal reproduction project (MRP)
I have tried to no avail to recreate the bug...

I started having the same issues when I added the Qodot plugin into my project (Godot 4.2.1 mono). Making a change in my C# code, and then running the game makes several scripts from the plugin fail to load, but running the game a 2nd time would result in no issues. I initially thought this was a problem with the plugin, but after reading your post, it's clearly something to do with the engine itself.
Since Godot was telling me it was a parse error (just like in your post), I made sure that all of the scripts were encoded in UTF-8 without BOM, but that didn't fix it. I also attempted to change the file and class names of the scripts that were causing the issues, but once again it didn't fix it.
The last thing I tried was that I went through every single script that was failing to load and removed the type hints from all of the variables and functions, which ended up making the errors show up less frequently, but they were still there.

I started having the same issues when I added the Qodot plugin into my project (Godot 4.2.1 mono). Making a change in my C# code, and then running the game makes several scripts from the plugin fail to load, but running the game a 2nd time would result in no issues. I initially thought this was a problem with the plugin, but after reading your post, it's clearly something to do with the engine itself.
Since Godot was telling me it was a parse error (just like in your post), I made sure that all of the scripts were encoded in UTF-8 without BOM, but that didn't fix it. I also attempted to change the file and class names of the scripts that were causing the issues, but once again it didn't fix it.
The last thing I tried was that I went through every single script that was failing to load and removed the type hints from all of the variables and functions, which ended up making the errors show up less frequently, but they were still there.

Yeah for sure. I am able to avoid the error by also closing and reopening the project, or by building the project in the terminal and then running it from the terminal or editor, though that causes some other errors due to manipulating the editor from an external tool.
Here's the error in action

I started having the same issues when I added the Qodot plugin into my project (Godot 4.2.1 mono). Making a change in my C# code, and then running the game makes several scripts from the plugin fail to load, but running the game a 2nd time would result in no issues. I initially thought this was a problem with the plugin, but after reading your post, it's clearly something to do with the engine itself.
Since Godot was telling me it was a parse error (just like in your post), I made sure that all of the scripts were encoded in UTF-8 without BOM, but that didn't fix it. I also attempted to change the file and class names of the scripts that were causing the issues, but once again it didn't fix it.
The last thing I tried was that I went through every single script that was failing to load and removed the type hints from all of the variables and functions, which ended up making the errors show up less frequently, but they were still there.

It seems like I found a fix, depending on your setup!
You can disable GD script warnings. If  you do so, boom no issue. Which is odd, as if I push through before, the scripts would not load correctly, but apparently, if you ignore them it all works.
So, if you work entierly in C#, you can disable the warnings, and the project no longer fails.
They can be disabled in debug/GDScript/enable. Requires advanced settings to be true.

Alas I was too quick, the bug has returned in full swing.

I am seeing the same issue on both 4.2.2 and 4.3-dev6. The first run after making changes to C# scripts, godot will raise several parse errors on the types provided by the plugins. There are no errors running the project a second time. In my project's case the plugins are Dialogic and Phantom Camera.
Adding some additional information -

The issue only seems to occur if the godot editor is open. If I close the godot editor and run through Visual Studio, there are never errors when running. (If I run through Visual Studio with the godot editor open it still fails for the first run after each build.)
The issue also affects gdextensions. I'm using a custom gdextension in my project, and any GDScript files that use or extend classes defined by my gdextension see the same sort of error:

Two "workarounds" with various degrees of around-working -

Close the godot editor and run the project through your IDE. Solid workaround when you're only changing code and don't need to edit any scenes or exported variables.
Run godot with the console .exe. The plugin and gdextension scripts still fail to load for the first run after making changes, but the errors just get spit out into the console instead of halting the game, so you can more quickly test anything that doesn't depend on them. It also makes rerunning the project after the failure much faster. Unfortunately this loses breakpoint debugging, see #84314

An MRP or clear steps to reproduce are necessary here. It'll be hard to assess the problem and fix it if we can't reproduce.


Progress indicator

This package is great but could you add a progress indicator option when loading an image?

Hi KaelTeck, thank you for your feedback.
I will definitely take it into consideration for the next release version.

Thank you very much.

Progress indicator is now available In version 1.2.0
DisposableCachedImage.network(
  ...
  progressBuilder: (context, progress) => Center(
    child: LinearProgressIndicator(value: progress),
  ),
);

Thank you so much!!!


ARROW-15435: [C++][Doc] Improve API docs coverage

Add some classes or functions that were missing.
Some parts of the public API, such as pretty-printing, are still uncovered and should be handled in individual JIRAs.

@kszucs This would be nice to have in 7.0.0 if you cut another RC.

Conflicts fixed now.


CR014: Text name appears twice in browse menu

Location
When adding a source to a sheet,
when browsing through the categories to reach a segment,
Issue
We need to click twice on the name of a text before reaching its chapters and then segments.

The second title still appears in the right side menu. It's only by clicking on it a second time that I am able to go to next level. The issue is not solved.

Not only is it not solved, it looks like a new bug has been introduced:

When I get to the verses level, I click on them, they get added to the path, and the corresponding verse doesn't show.
In the screenshot, I am expected to see verse 07 (the last in the path), but verse 1 shows in the preview.

the two times are removed, but the user still has to click two times


Add originalyear field

This is a virtual tag like 'year', and takes the first four characters
of the originaldate tag.
Closes ambientsound/pms#68

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   53.99%   53.99%
=======================================
  Files          49       49
  Lines        1702     1702
=======================================
  Hits          919      919
  Misses        761      761
  Partials       22       22

Impacted Files
Coverage Δ

options/defaults.go
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cddb5...998a261. Read the comment docs.


"Can't find variable: require"

I am trying to install this using rails-assets, a thin wrapper around bower that preps for Rails environments. What is require and why do you expect it to be defined in all scenarios?

It looks like you're using the source code, not the bundled code for production use. See this file instead: https://github.com/NextStepWebs/simplemde-markdown-editor/blob/master/dist/simplemde.min.js

Because the source code is pointed to in the bower.json


Don't send "API Invocation Failed" in the error messages.

These messages end up getting propagated to the end-user (who doesn't care that an API was invoked -- they only care about the actual error message).

I like this change. Made a minor comment about the testing approach. I'm ok to merge with or without those changes.


Contract card ui tweaks: consistent market type colors, no underline,…

… adjust font/border size

Before:

After:

(also the net effect is to make the card view less dense, which I'm not sure is the correct direction)

Agree, always green bar for % chance of YES (regardless of if that % chance is higher or lower than 50%) is clearer communication at a glance. The other changes don't seem to make much a positive difference IMO, slightly negative if anything.


Copy the wrapper and *-unwrapped idiom from upstream nixpkgs

This change also moves the isPatchedForGlobalCache property to the yarn package instead of the wrapper, and pass the value through the wrapper. This is closer to what's actually happening. It does require anyone providing a pre-built yarn binary that has been patched to wrap it in a derivation with the appropriate passthrough, which is a minor downside for an unlikely use case.

I was exploring the structure and thought this might be easier to follow. Instead of yarn itself walling the wrapper, expose the wrapper function at top-level and do all the composition at top level. This is mostly copying the binutils-unwrapped + wrapBinutilsWith + binutils pattern from upstream.

Hm, right. Now I remember. The reason I went with the awkward setup is so that users can override and put in their own patches and plugins without having to do it separately for yarn-unwrapped (patches) and for yarn (plugins). Do you think it's still better to follow the nixpkgs convention in that case?

Hm, right. Now I remember. The reason I went with the awkward setup is so that users can override and put in their own patches and plugins without having to do it separately for yarn-unwrapped (patches) and for yarn (plugins). Do you think it's still better to follow the nixpkgs convention in that case?

Are plugins and patches equally likely, enough that there's a benefit to having the special interface?
I'm probably biased by nixpkgs, but it would feel weird to apply a clang patch by passing it to the CC wrapper. We don't quite have the same difference as gcc vs clang though.  I generally favor less magic and fewer surprises. In terms of interface, both "yarn" and "yarn-bin" are wrapped yarns coming from wrapper.nix, but they have different options that can be overridden.
So I think I prefer this PR slightly just because it has a little less magic.


[BUG]: AzurePowerShell@5 does not set environment variables on Windows

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
AzurePowerShell@5
Task version
5.241.0
Issue Description
In Linux and MacOS, the following environment variables are available to scripts executed in an AzurePowerShell task:

AZURESUBSCRIPTION_SERVICE_CONNECTION_ID
AZURESUBSCRIPTION_CLIENT_ID
AZURESUBSCRIPTION_TENANT_ID

However, on a Windows agent executing the exact same script, only one variable is available:

AZURESUBSCRIPTION_SERVICE_CONNECTION_ID

I would expect to have the client and tenant id also available given that they are available in the Linux/MacOS agents.
This appears to be caused by the fact that the tasks execute differently depending on the platform and the Windows-specific code does not set those environment variables the way that the Linux/MacOS code does.
The Windows-specific code does clear the environment variables (which aren't set) at the end of execution.
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows 2022, Windows 2019
Relevant log output
Linux (expected output):
AZURESUBSCRIPTION_SERVICE_CONNECTION_ID: <redacted, valid value>
AZURESUBSCRIPTION_CLIENT_ID: <redacted, valid value>
AZURESUBSCRIPTION_TENANT_ID: <redacted, valid value>

Windows 2019 (note empty strings where valid values are expected):
AZURESUBSCRIPTION_SERVICE_CONNECTION_ID: <redacted, valid value>
AZURESUBSCRIPTION_CLIENT_ID:
AZURESUBSCRIPTION_TENANT_ID:

Windows 2022 (note empty strings where valid values are expected):
AZURESUBSCRIPTION_SERVICE_CONNECTION_ID: <redacted, valid value>
AZURESUBSCRIPTION_CLIENT_ID:
AZURESUBSCRIPTION_TENANT_ID:

### Full task logs with system.debug enabled

<details>
  <pre> [REPLACE THIS WITH YOUR INFORMATION] </pre>
</details>

### Repro steps

```yml
steps:
        - task: AzurePowerShell@5
          inputs:
            azureSubscription: !!!REPLACE WITH SERVICE CONNECTION NAME!!!
            azurePowerShellVersion: LatestVersion
            pwsh: true
            ScriptType: InlineScript
            Inline: |
              Write-Host "AZURESUBSCRIPTION_SERVICE_CONNECTION_ID: $($env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID)"
              Write-Host "AZURESUBSCRIPTION_CLIENT_ID: $($env:AZURESUBSCRIPTION_CLIENT_ID)"
              Write-Host "AZURESUBSCRIPTION_TENANT_ID: $($env:AZURESUBSCRIPTION_TENANT_ID)"
          displayName: Service connection info

This issue prevents federated auth scenarios.

Hi @danieljurek
Thanks for reporting this issue.
Our team has started investigation on this issue. Will share the latest updates here.


Problem Uncaught TypeError: Cannot read property 'appendChild' of undefined

I can't init the script, error on line 61 in vjs Background.
I put script and code at the end and header, but doesn't work.
Same error.

Hello, do you have you video element setup like the example https://github.com/matthojo/videojs-Background/blob/master/example.html#L42-L48 ?
 Moving your script tag to the end of your page, or add an onLoad handler so it fires after the page has loaded.

I have same error for change the container element i need use class

I tested various sets of template and css, the correct way is after video tag put the scripts with js.
Thanks!


feature: add parser support for bit vectors and indexed operators

I'll remove all the dbg! and print from the code, just want to make sure other things are good to go first.

can you help me fixing the 2 tests that are failing on the CI? I'm having a hard time with them 😓  @bpandreotti

As for the formatting, you can run rustfmt on the whole project with rustfmt $(find ./carcara/src -name '*.rs'), and it should fix the CI errors. Though in the future it might be useful to configure your editor to format on save.


sprint create bug

I tried creating a sprint -- and it mostly worked -- but there was an exception thrown.
rallymanager --synapse_config ~/.synapseConfig_sage_ki_service --config ~/rally_config.json create-sprint 30 A

    INFO:kirallymanager.manager:Creating a new sprint 30A
INFO:kirallymanager.manager:Created sprint project syn22000247
Downloading  [####################]100.00%   358.0bytes/358.0bytes (952.2kB/s) masterTemplate.md Done...
    INFO:kirallymanager.manager:Set sprint project wiki.
INFO:kirallymanager.manager:Created sprint project folder structure.
INFO:kirallymanager.manager:Created sprint project forum posts.
Traceback (most recent call last):
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/bin/rallymanager", line 120, in <module>
    main()
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/bin/rallymanager", line 116, in main
    args.func(args)
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/bin/rallymanager", line 26, in create_sprint
    config=config)
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/lib/python3.7/site-packages/kirallymanager/manager.py", line 492, in create_sprint
    rally_admin_sprint_table = syn.store(rally_admin_sprint_table)
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/lib/python3.7/site-packages/synapseclient/client.py", line 997, in store
    properties = self._updateEntity(properties, forceVersion, versionLabel)
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/lib/python3.7/site-packages/synapseclient/client.py", line 3370, in _updateEntity
    return self.restPUT(uri, body=json.dumps(get_properties(entity)))
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/lib/python3.7/site-packages/synapseclient/client.py", line 3490, in restPUT
    exceptions._raise_for_status(response, verbose=self.debug)
  File "/Users/psnyder/Documents/virtual_environments/synapsepythonclient1.9.4/lib/python3.7/site-packages/synapseclient/exceptions.py", line 153, in _raise_for_status
    raise SynapseHTTPError(message, response=response)
synapseclient.exceptions.SynapseHTTPError: 403 Client Error:
You do not have UPDATE permission for the requested entity.

sage-ki-service didn't have permissions to the file views. I fixed that.


Update power-bi-optimization.md

The previous wording around "Internal-hosted or External-hosted" is unclear, and not explicitly defined.  Updated for clarity (or if my interpretation was incorrect, please let me know.
Also updated wording to be the "Power BI ecosystem" to be inclusive of datamarts capabilities.

@davidiseminger

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


[workloadmeta/remote] Delete unused param from StreamEntities()

What does this PR do?
Deletes an unused parameter in the remote collector of workloadmeta.
Describe how to test/QA your changes
Skip.

/merge


[enhancement]: Include Embiggen in the Web UI, and/or a method for selective upscaling on Unified Canvas

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
<EMAIL_ADDRESS>What should this feature add?
I recently discovered InvokeAI (I was precedently using Automatic1111's Web UI), to which I fell in love (thanks for your work!). But I found that my favourite upscaling feature, using upscaling + overlapping tiles is missing from the InvokeAI Web UI (in Automatic1111 it's a script called "SD Upscale". I love this feature, because details really get filled, not just upscaled in a "soulless" way.
I saw you integrated something very similar if not identical called "Embiggen", but it's actually missing from the Web UI, it's only available via console. Are you planning on adding it on a future release?
Please preserve the possibility to choose the sampler for the embiggen process, and to set the overlapping tiles to 768x768. In this way, other than having only 4 tiles to generate and overlap, it seems to me the algorithm "has better knowledge of the general composition of the image", and strange events like faces getting cut or unwanted details which are in the prompt be generated. I may be wrong. :)
Alternatives
Alternatively, a workflow which could be even better and give more control over the process:
I can now obtain something similar using the Unified Canvas, by first generating a 512x512 image, upscaling it 2x, then moving the generation window and using the mask brush to preserve the borders. This actually work quite fine, I can choose the tiles I want to preserve. But this takes an extra step: drawing the mask on the selection border and, like in the attached image, select "Preserve masked content" (which for some reason gets reset every time I erase the mask with Shift-C). But this requires some extra steps, which are annoying :)
Can a simple way to upscale a part of the image without getting annoying seams be introduced?

Aditional Content
Thanks for your reading, and for your already excellent implementation.

Hey @Neeqstock - Glad to hear you like Invoke!
We've discussed this very thing. And I'll share how we approached this idea, which frames a lot of how we think about adding things generally
Asking ourselves what the ideal experience would be, seems like being able to visualize/manipulate the tiles with a preview of the image (upscaled from your init), and the ability to tweak prompt by tile, would be the 🔥 experience
We've got a number of things in the oven, but know that it's on the roadmap. And, if we get a few more contributors, maybe it'll be live sooner vs. later! :)

Wonderful! I totally agree being able to visualize the single tiles, select the results, and tweak the prompt for every single tile would be the 🔥 experience!
I dreamily await the next updates.
Thank you!


mx:NumberValidator is validating NumericStepper source incorrectly

Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Accounts Payable from Select in Menu
Go to Bank Reconciliation from Setups in Menu
File : com/dbz/modules/GL/dbzBankReconSetup.mxml
When i am entering 9999 into NumericStepper it turns into 100 and validation of numericStepper using mx:NumberValidator is incorrect
Flex Vs Royale Video :

Range is working now but NumericStepper is validation is not working

What value is not validating?

In dbzBankReconSetup
<mx:NumberValidator id="vldrc_ACCOUNT_START" enabled="{rc_ACCOUNT_START.enabled}" source="{rc_ACCOUNT_START}" property="value" required="true" minValue="1" maxValue="9999999" allowNegative="false"/>
source="{rc_ACCOUNT_START}"  is NumericStepper
<s:NumericStepper id="rc_ACCOUNT_START" x="153" y="35" width="100" height="22" maximum="9999999" maxChars="7" tabIndex="3" change="isModified=true"/>
On save button fn_ValidateForm is called which is validating NumericStepper values.
if(vldrc_ACCOUNT_START.enabled && vldrc_ACCOUNT_START.validate().type == ValidationResultEvent.INVALID) {
return;
}
It should not return from here because i am giving right value for NumberValidator vldrc_ACCOUNT_START so why it is returning ?
it is not returning in Flex. i am giving same values in Royale
it means the validation is not correct
Flex vs Royale Video

I cannot understand the problem from watching these videos.  What values are not validating and when?  Your description above described the code, but not the values that are causing a problem.  From watching the video, it looks like the validator is correctly saying that "0" is invalid since the minValue is set to 1 in the code you showed.
Instead of making more videos, try making a simple test case.


Release version 0.0.2

Codecov Report
Patch and project coverage have no change.

Comparison is base (4b6b9f4) 100.00% compared to head (7ddfbb4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          255       255
  Branches        55        55
=========================================
  Hits           255       255

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


don't round in fixedToFloat, unless we're dumping floats to XML

Fixes https://github.com/fonttools/fonttools/issues/737
I changed fixedToFloat to NOT do any magic, simply return value / (1 << precisionBits)
The code of the previous fixedToFloat is now called fixedToStr, but returns a string and is used in toXML methods to write fixed-point numbers as compact decimal floats.
The function actually used in toXML methods is floatToFixedToStr (that in turn uses fixedToStr), because internally table objects store these fixed-point numbers as floats, not as integers.
But I still kept fixedToStr (and strToFixed) in fixedTools module, even though they are not used directly anywhere.
There is also a corresponding strToFixedToFloat that does the reverse and it's equivalent of doing floatToFixedToFloat(float(string)). This is used in fromXML methods to ensure that the internal un-rounded float values are the same whether a table was decompiled from binary (hence used fixedToFloat) or loaded from XML.
I updated all the calling sites accordingly, including Fixed and F2Dot14 types in otConverters, fvar, avar, glyf, head, trak, TupleVariations and psCharStrings.
/cc @Lorp

Thanks for working on this!
Thiss sounds like what I remember needed to be done.  lgtm.

Looks like a very good separation of responsibility :)

Sorry it took me so long to get to it. I was actually hit by it while working on the partial instancer...


Add Namespace support

The structure of a package could be the following.
\[Package Name]
\[Package Name]\Enum
\[Package Name]\Service
\[Package Name]\Struct
(actually, prefix could be replaced by namespace support).

This is THE thing I wanted to introduce with the feature/mandevilla branch.
My first thought was to introduce a new option allowing to enable namespace and so the top level namespace(s) to use for each generated class.
But my second thought is that we should use namespace as soon as the PHP version allows it (pretty always as the project requires PHP=>5.3.3 (composer.json), am I right ?). We would then have, as you mentionned, something like this:

{PackageName}/

Enum/

ColorValues.php

namespace = {TopLevelNamespace}\{PackageName}\Enum

SizeValues.php

namespace = {TopLevelNamespace}\{PackageName}\Enum

...

Struct/

Color.php

namespace = {TopLevelNamespace}\{PackageName}\Struct

Size.php

namespace = {TopLevelNamespace}\{PackageName}\Struct

...

Service/

Get.php

namespace = {TopLevelNamespace}\{PackageName}\Service

Add.php

namespace = {TopLevelNamespace}\{PackageName}\Service

...

Nevertheless, do you agree that we would need an option to at least specify the top level namespace(s) to use to prefix the generated namespace : Enum, Struct, Service ? By default, it'll be empty.
Plus, classes can be generated using the name of the Structs/Operations. So we should also use namespace(s) in case the user wants something like this:

{PackageName}/

Add/

StructAddProduct.php

namespace = {TopLevelNamespace}\{PackageName}\Add

ServiceAdd.php

namespace = {TopLevelNamespace}\{PackageName}\Add

Get/

StructGetProduct.php

namespace = {TopLevelNamespace}\{PackageName}\Get

ServiceGet.php

namespace = {TopLevelNamespace}\{PackageName}\Get

Items/

StructProductItems.php

namespace = {TopLevelNamespace}\{PackageName}\Items

StructColorItems.php

namespace = {TopLevelNamespace}\{PackageName}\Items

...

Am I missing something? Would it be ok this way?

Doc says namespace >=5.3.0 so I agree.
Assuming people use: PSR4 and composer, I can thing about 2 cases:

the one where the package is directly a dependency (vendor/[Vendor name]/[Package name]/ with an autoload generated by composer
the one where this package is used in some place of the project (say folder /src/Interface/blah blah/[Package name]/ )

My use case is a bit of both: I am building a library (project-agnostic) with a few web services (and the boiler-plate code to go with it) with I reused as a dependency in my projects. Sometimes project need one extra-field, which impacts the WSDL, which impacts the generated package. Namespace would allow me to overwrite package.
As for the internal structure, you made the choice to generate standalone packages. As a user, I just consume this package and have no opinion regarding its internal composition.
Nevertheless, I think you should consider moving all the generic code (I think about Prefix_ WsdlClass) in different component which would be a dependency (quite easy with namespaces & composer). This would avoid having the same code duplicated as many times as there are interfaces (I have a dozain at my current project).

If I sumup well your comment:

There is no need for a top level namespace, at least the {PackageName} is sufficient
The {PackageName}WsdlClass.php, {PackageName}Autoload.php could be externalized

As you seem to use pretty well the generator:

Do you use the generated root files: Autoload, WsdlClass, ClassMap ?
If you encountered the case, do you think Array structs (ArrayOfString => {PackageName}StructArrayOfString for example) should have their own directory as Enum ? We would have:

Array/
Enum/
Service/
Struct/

If you're not using the WsdlClass, how to proceed to use you own SoapClient?

In any case, feel free to send me  your feedbacks at<EMAIL_ADDRESS>thanks

There is no need for a top level namespace, at least the {PackageName} is sufficient

Quite the opposite (but I deleted the comment while editing). I could need n top level namespace because according to PSR-4 the folder structure would match the namespace imbrication.

The {PackageName}WsdlClass.php, {PackageName}Autoload.php could be externalized

Some of it, yes I think. I know you inherit from WsdlClass almost everywhere but I didn't find the point for Enum and Struct.

Do you use the generated root files: Autoload, WsdlClass, ClassMap ?

Yes, I haven't tried to avoid them. With namespace, I would use composer classmap which I think would be better from a performance point of view. Autoload.php requires classes that I won't use in the end.

If you're not using the WsdlClass, how to proceed to use you own SoapClient?

I used NuSoap but could not deal with additionnal namespaces, I use SoapClient but attributes are painful and manual classmapping was less appealing than WsdlTophp ;-)

Indeed, you're right for the namespace!
The WsdlClass is sort of an utility class that provides useful methods, in my point of view and regarding the multi cases, to ease the access and the handling of multiple informations: XML request, headers, iterate through array of values and so on. As you proposed, we could have an external package that would be used by the generated package (using a dedicated composer.json file) that contains utility classes: SoapClient for Service classes, Structs utilities and so on.
For the Autoload, I haven't tried to see if, without having loaded the classes (mentionned by the classmap), the SoapClient populates the return object with a generated class. Have you ?

After a few test, I confirm I won't use autoload.
I add the following in composer.json
{
    "autoload": {
        "classmap": [ "Acme/Package/directory/" ]
    }
}

and execute composer dumpautoload in order to generate classmap.
require_once('../vendor/autoload.php');  replaces require_once dirname(__FILE__) . '/PrefixAutoload.php'
NB: We need to disambiguate "classmap" :

composer classmap is an array that links classes to their folder for autoloading
soap classmap is an array that links tag to classes.

When you say

For the Autoload, I haven't tried to see if, without having loaded the classes (mentionned by the classmap), the SoapClient populates the return object with a generated class. Have you ?

I still use Soap classmap from WsdlToPhp since it is the only known way to populate attributes.

If you have some time to waste, I'll be glad if you can test the feature/mandevilla branch as it now has namespace support and (non-)standalone mode.
Take a look to the README file as it has been updated,
Let me know how it works and feel free to create as much issue tickets as you need

you can use the first major release candidate from now

namespace is now handled


fix parameter missing  when plugin type is a funtion

Hello, here's a small change ...

/lib/webpack.js (now)
  if (typeof plugin === "function") {
    plugin.apply(compiler);  // missing parameter
  } else {
    plugin.apply(compiler);
  }

/lib/webpack.js (after)
  if (typeof plugin === "function") {
    plugin.apply(null, [compiler]); // yes
  } else {
    plugin.apply(compiler);
  }

/declarations/WebpackOptions.d.ts
type WebpackPluginFunction = (
	compiler: import("../lib/Compiler")
) => void;

What kind of change does this PR introduce?
a bugfix

Okay. I investigated a bit. This change is wrong. We want this to be the compiler.
plugin.call(compiler, compiler) may be better bacause it prevents confusion about apply and would work with this and arrow functions accepting the compiler as the first parameter. cc @sokra

yeah makes sense. It also seems like the typings are wrong here. It should be:
type WebpackPluginFunction = (
	this: import("../lib/Compiler")
) => void;

resp. after the change:
type WebpackPluginFunction = (
	this: import("../lib/Compiler"),
	compiler: import("../lib/Compiler")
) => void;

plugin.call(compiler, compiler)

type WebpackPluginFunction = (
	this: import("../lib/Compiler"),
	compiler: import("../lib/Compiler")
) => void;

😁 haha.. That's what I thought before.
I changed the code. This should be a more compatible solution.

declarations/WebpackOptions.d.ts need to be updated

run yarn special-lint-fix

declarations/WebpackOptions.d.ts need to be updated

run yarn special-lint-fix

Oh, I changed /declarations/WebpackOptions.d.ts directly before.
now, I changed schemas/WebpackOptions.json.
and run yarn special-lint-fix，hope this change is OK

Thanks


Issue template is missing a "Bug" option

Context
There is no option to choose "Bug" in the issue template. Only "Feature" or "General" issue.
Value and/or benefit
It would be clearer to understand how to file bugs
Anything else?
No response

There is no configuration for issue templates in this repository yet, the templates are inherited from nebari-dev (defined here). I think there may be two action items:

add bug template to nebari-dev in https://github.com/nebari-dev/.github
add dedicated templates with sections and questions which make more sense for jupyterlab-launchpad


Release v1.5

release process v1.5

The document is here.
See here for the new capabilities and changes of v1.5.

We plan to release v1.5 by the end of April 2024.
Any comments welcome!

Thank you for the pull request. I can confirm that most of the scrips in the manual_check work well. I found that these scripts in the manual_check folder are also outdated. They still refer to the AutoXS and AutoRT:

readme_sample.py
comparison/modit_comparison.py

Install problem about radis

It will be solved after the merge of https://github.com/radis/radis/pull/651 into radis/develop.

Thank all of the reviewers so much!


Not flowing smoothly

Scroll is not smoothly if  SubTitles too much

Can you please provide sample data, so I can reproduce and see what's the issue.
Thanks


Update data services to return an instance of the dataset class

Data services return instances of dataset interface instead of pandas dataset

Done by: https://github.com/cdisc-org/cdisc-rules-engine/pull/615


Replace Grunt-based build system with simple scripts

Our existing Grunt-based build system is really difficult to follow, so this PR replaces it with a simpler approach involving plain old JavaScript.
The build directory is deleted, and instead the script directory takes on an expanded role, getting its own package.json and lib directories to support an overhauled version of script/bootstrap, script/build, and script/test. Instead of relying on Grunt, we do everything via functions defined in the script/lib directory.
Build script
The basic structure of the new build script is as follows:

Copy all sources to atom/out/app
Transpile Babel, CoffeeScript, and Less files in place
Generate pre-cached metadata
At this point, out/app is a valid Electron app that doesn't require transpilation support to run.
Run electron-packager on out/app to package it into a distributable application on the current platform.
Build installer on Windows, code sign on macOS
Zip stuff up

This is all designed to run only on third-party build providers (CircleCI for macOS, Travis for Linux, and AppVeyor on Windows). We've put zero effort into making these scripts run on internal Janky boxes.
Release publishing plan
We deliberately omit the artifact uploading step, because our plan is to orchestrate release publishing outside of the build. We'll rely on the build services to store artifacts associated with all builds, and when we're ready to release we'll have a script download these artifacts from Circle, Travis, and AppVeyor and upload them to the releases API and S3. This will help to ensure that all artifacts stay in sync based on a specific commit SHA.
Tasks

[x] Build scripts working on all platforms

[x] macOS

[x] Build a complete electron app
[x] Code sign
[x] Green build on Circle
[x] Implement --install flag

[x] Windows

[x] Build a complete electron app
[x] Build an installer
[x] Delete unnecessary .nupkg delta file uploaded as artifact
[x] Code sign
[x] Green build on AppVeyor
[x] Installing won't be supported, because users can launch the generated installer.

[x] Linux

[x] Build a complete electron app
[x] Generate .deb package
[x] Generate .rpm package
[x] Green build on Travis
[x] Make Travis artifacts downloadable
[x] Installing won't be supported, because users can launch the package manager on the generated packages.

[x] Add script/lint
[x] Release publishing

[x] Visualize build status for release branch across all platforms
[x] Download and publish artifacts for a specific SHA
[x] Authenticate Atom maintainers that work for GitHub
[x] Get app running on Heroku Enterprise
[x] A pinch of styling

[x] Documentation

[x] Rewrite build instructions for macOS
[x] Rewrite build instructions for Windows
[x] Rewrite build instructions for Linux

[x] Ops

[x] Make builds a no-op on previous internal build systems.
[x] Eliminate atom-private AppVeyor build and use private env vars instead

📈 🎆 ❗


Basic check() infrastructure

Modelled based on how django staticfiles implements it
Ref #26

All comments are valid, at the same time - this is following pattern from Django core:
https://github.com/django/django/blob/4c4536f7442a3ed1218f5b1dc791295d65c24f4c/django/contrib/staticfiles/checks.py#L11


Add colorls

Hey! I'd like to know if colors qualifies to be added to this list. Thanks! 😄

Ping @k4m4, in case you haven't seen this yet. 😄

Sorry for the delay. Reviewing now. @athityakumar

Done. Thank you for your contribution. :)


bug(Calling): Sometimes calls arent working

Issue:
There is an issue with calling sometimes when they just either arent going through or the receiving user picks up but is never connected. We think this might be an issue with the relay since the console gets blown with up with an error involved with the relay (See error below)
(Though something to note Sara and I are able to make calls fine 99% of the time and this error will appear in each call so not sure how related it actually is)
Error:

(This is the console from when Sara and I do a call no issues and the relay error still appears)

Same issue here

I found the source of the problem (at least for me). the relay rejects the request if you dont have a webcam connected to the machine

I found the source of the problem (at least for me). the relay rejects the request if you dont have a webcam connected to the machine

@dillfrescott  Interesting information, could you share the logs? And how did you discover problem was webcam?

Sorry I didnt save the logs. The problem was the webcam because it said the relay was rejected without it and i plugged one in and it worked like 50% of the time


Adding multiple filters for repos seach

The website currently only allows filtering by language and tags. Adding the ability to search repositories based on text queries could greatly enhance its functionality. I'm excited to tackle this feature and improve the website's usability.

Hi, this issue has conflicts with the github API terms and policies. Closing this issue now as we have limits to send request on github API on hourly basis.


Crash when restoring bonding

Setup
Phone: iPhone Xs
iOS version: 14.1
Phone app: nRF Connect
Target: ESP32 (NINA-W106)
IDF: version 4.3
nimble-idf branch: latest nimble-1.3.0-idf branch
Description
I want to be able to bond with both Android and iPhone devices. As iPhones in particular have RPA addresses, I enabled privacy using guidelines from here.
Expected behavior
The stack should be able to resolve RPA addresses. After initially bonding the phone with the ESP32, no other pairing/bonding requests should be requested when reconnecting or during the active connection.
Problem Description
After initially bonding the iPhone with the target, the connection is stable and the bonding works. After reconnecting once or several times (the issue is not consistent), without clearing any bonding information, the board crashes and gets reset. In order to be able to reconnect again, the bonding information from the phone has to be deleted first.
Usually, after the crash, the phone manages to restore bonding, but sometimes it resets forever trying to connect. This behavior is only on the iPhone, my Android device, which uses a public address, does not trigger the crash.
I managed to reproduce the problem using the bleprph example. I have only added RPA address resolution to that example and increased the number of stored CCCD from 8 to 32. I have attached the project files:
bleprph.zip
Steps to reproduce

Connect the iPhone to the ESP32 using the nRF Connect app.
Read the encrypted characteristic so that pairing is requested.
After pairing is done, disconnect.
Try to reconnect several times until the error/crash appears.

Logs

I noticed that ble_hs_util_ensure_addr() does not always succeed in ensuring a random (1) address and sets a public one instead.

The crash description is shown below:
     I (2653) NimBLE: GAP procedure initiated: advertise;
 I (2653) NimBLE: disc_mode=2
 I (2653) NimBLE:  adv_channel_map=0 own_addr_type=1 adv_filter_policy=0 adv_itvl_min=0 adv_itvl_max=0
 I (2663) NimBLE:
 D (2673) NimBLE: ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0006 len=15
 D (2673) NimBLE: 0x06
 D (2683) NimBLE: 0x20
 D (2683) NimBLE: 0x0f
 D (2683) NimBLE: 0x30
 D (2683) NimBLE: 0x00
 D (2693) NimBLE: 0x60
 D (2693) NimBLE: 0x00
 D (2693) NimBLE: 0x00
 D (2693) NimBLE: 0x01
 D (2703) NimBLE: 0x00
 D (2703) NimBLE: 0x00
 D (2703) NimBLE: 0x00
 D (2703) NimBLE: 0x00
 D (2703) NimBLE: 0x00
 D (2713) NimBLE: 0x00
 D (2713) NimBLE: 0x00
 D (2713) NimBLE: 0x07
 D (2713) NimBLE: 0x00
 D (2723) NimBLE:

 D (2723) NimBLE: ble_hs_hci_cmd_send: ogf=0x08 ocf=0x000a len=1

 D (2733) NimBLE: 0x0a
 D (2733) NimBLE: 0x20
 D (2733) NimBLE: 0x01
 D (2733) NimBLE: 0x01
 D (2733) NimBLE:

 D (11483) NimBLE: 0x9c
 D (11483) NimBLE: 0x88
 D (11483) NimBLE: 0x77
 D (11483) NimBLE: 0x5b
 D (11493) NimBLE: 0x7e
 D (11493) NimBLE: 0x67
 D (11493) NimBLE:

 I (11503) NimBLE: connection established; status=0

 D (11513) NimBLE: Revised our id addr:

 D (11523) NimBLE: 0x9a
 D (11523) NimBLE: 0x5b
 D (11523) NimBLE: 0x47
 D (11523) NimBLE: 0xc0
 D (11533) NimBLE: 0xa7
 D (11533) NimBLE: 0x70
 D (11533) NimBLE:

 I (11543) NimBLE: handle=0 our_ota_addr_type=1 our_ota_addr=
 I (11553) NimBLE: 70:a7:c0:47:5b:9a
 I (11553) NimBLE:  our_id_addr_type=0 our_id_addr=
 I (11563) NimBLE: 7c:9e:bd:c9:68:5e
 I (11563) NimBLE:  peer_ota_addr_type=0 peer_ota_addr=
 I (11573) NimBLE: 50:7a:c5:5f:c3:38
 I (11573) NimBLE:  peer_id_addr_type=0 peer_id_addr=
 I (11583) NimBLE: 50:7a:c5:5f:c3:38
 I (11583) NimBLE:  conn_itvl=24 conn_latency=0 supervision_timeout=72 encrypted=0 authenticated=0 bonded=0

 I (11593) NimBLE:

 D (11593) NimBLE: ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0016 len=2

 D (11603) NimBLE: 0x16
 D (11603) NimBLE: 0x20
 D (11613) NimBLE: 0x02
 D (11613) NimBLE: 0x00
 D (11613) NimBLE: 0x00
 D (11613) NimBLE:

 D (13623) NimBLE: Revised our id addr:

 D (13623) NimBLE: 0x9a
 D (13623) NimBLE: 0x5b
 D (13633) NimBLE: 0x47
 D (13633) NimBLE: 0xc0
 D (13633) NimBLE: 0xa7
 D (13633) NimBLE: 0x70
 D (13643) NimBLE:

 D (13643) NimBLE: looking up our sec;
 D (13653) NimBLE: peer_addr_type=0 peer_addr=
 D (13653) NimBLE: 0x38
 D (13653) NimBLE: 0xc3
 D (13663) NimBLE: 0x5f
 D (13663) NimBLE: 0xc5
 D (13663) NimBLE: 0x7a
 D (13663) NimBLE: 0x50
 D (13673) NimBLE:
 D (13673) NimBLE: ediv=0x00 rand=0x0
 D (13673) NimBLE:

 D (13683) NimBLE: ble_hs_hci_cmd_send: ogf=0x08 ocf=0x001a len=18

 D (13693) NimBLE: 0x1a
 D (13693) NimBLE: 0x20
 D (13693) NimBLE: 0x12
 D (13703) NimBLE: 0x00
 D (13703) NimBLE: 0x00
 D (13703) NimBLE: 0x98
 D (13703) NimBLE: 0x54
 D (13713) NimBLE: 0xa7
 D (13713) NimBLE: 0xbd
 D (13713) NimBLE: 0xb8
 D (13713) NimBLE: 0xd2
 D (13723) NimBLE: 0x80
 D (13723) NimBLE: 0x1a
 D (13723) NimBLE: 0x31
 D (13723) NimBLE: 0x3e
 D (13733) NimBLE: 0x7d
 D (13733) NimBLE: 0xc7
 D (13733) NimBLE: 0x58
 D (13733) NimBLE: 0x2e
 D (13743) NimBLE: 0x8b
 D (13743) NimBLE: 0x69
 D (13743) NimBLE:

 D (13763) NimBLE: Revised our id addr:

 D (13763) NimBLE: 0x9a
 D (13763) NimBLE: 0x5b
 D (13763) NimBLE: 0x47
 D (13773) NimBLE: 0xc0
 D (13773) NimBLE: 0xa7
 D (13773) NimBLE: 0x70
 D (13783) NimBLE:

 I (13783) NimBLE: encryption change event; status=7

 D (13803) NimBLE: Revised our id addr:

 D (13813) NimBLE: 0x9a
 D (13813) NimBLE: 0x5b
 D (13813) NimBLE: 0x47
 D (13813) NimBLE: 0xc0
 D (13823) NimBLE: 0xa7
 D (13823) NimBLE: 0x70
 D (13823) NimBLE:

 I (13833) NimBLE: handle=0 our_ota_addr_type=1 our_ota_addr=
 I (13843) NimBLE: 70:a7:c0:47:5b:9a
 I (13843) NimBLE:  our_id_addr_type=0 our_id_addr=
 I (13853) NimBLE: 7c:9e:bd:c9:68:5e
 I (13853) NimBLE:  peer_ota_addr_type=0 peer_ota_addr=
 I (13863) NimBLE: 50:7a:c5:5f:c3:38
 I (13863) NimBLE:  peer_id_addr_type=0 peer_id_addr=
 I (13873) NimBLE: 50:7a:c5:5f:c3:38
 I (13873) NimBLE:  conn_itvl=24 conn_latency=0 supervision_timeout=72 encrypted=0 authenticated=0 bonded=0

 I (13883) NimBLE:

 I (13883) NimBLE: disconnect; reason=19
 I (13893) NimBLE: handle=0 our_ota_addr_type=1 our_ota_addr=
 I (13903) NimBLE: 70:a7:c0:47:5b:9a
 I (13903) NimBLE:  our_id_addr_type=0 our_id_addr=
 I (13913) NimBLE: 7c:9e:bd:c9:68:5e
 I (13913) NimBLE:  peer_ota_addr_type=0 peer_ota_addr=
 I (13923) NimBLE: 50:7a:c5:5f:c3:38
 I (13923) NimBLE:  peer_id_addr_type=0 peer_id_addr=
 I (13923) NimBLE: 50:7a:c5:5f:c3:38
 I (13933) NimBLE:  conn_itvl=24 conn_latency=0 supervision_timeout=72 encrypted=0 authenticated=0 bonded=0

 I (13943) NimBLE:

 E (13943) NimBLE: error setting advertisement data; rc=22

 E (13953) NimBLE: Resetting state; reason=19

 D (13953) NimBLE: ble_hs_hci_cmd_send: ogf=0x03 ocf=0x0003 len=0

 D (13963) NimBLE: 0x03
 D (13963) NimBLE: 0x0c
 D (13973) NimBLE: 0x00
 D (13973) NimBLE:

 Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.

 Core  0 register dump:
 PC      : 0x400e1e21  PS      : 0x00060930  A0      : 0x800e1fdd  A1      : 0x3ffca880
 0x400e1e21: ble_hs_hci_process_ack at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_hci.c:213

 A2      : 0x00000c03  A3      : 0x00000000  A4      : 0x00000000  A5      : 0x3ffca8a0
 A6      : 0x3ffc2514  A7      : 0x3ffca760  A8      : 0x800e1e1c  A9      : 0x3ffca870
 A10     : 0x00000000  A11     : 0x00000000  A12     : 0x00000010  A13     : 0x3ffca8b0
 A14     : 0x3ffb6149  A15     : 0x00000001  SAR     : 0x00000019  EXCCAUSE: 0x0000001c
 EXCVADDR: 0x00000000  LBEG    : 0x4000c46c  LEND    : 0x4000c477  LCOUNT  : 0x00000000

 Backtrace:0x400e1e1e:0x3ffca880 0x400e1fda:0x3ffca8a0 0x400dd705:0x3ffca8d0 0x400dd8c7:0x3ffca8f0 0x400da77c:0x3ffca910 0x400da7fe:0x3ffca930 0x400da80b:0x3ffca950 0x400e4246:0x3ffca970 0x400d77c6:0x3ffca990 0x40093b7d:0x3ffca9b0
 0x400e1e1e: ble_hs_hci_process_ack at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_hci.c:213

 0x400e1fda: ble_hs_hci_cmd_tx at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_hci.c:315

 0x400dd705: ble_hs_startup_reset_tx at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_startup.c:301

 0x400dd8c7: ble_hs_startup_go at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_startup.c:311

 0x400da77c: ble_hs_sync at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:345

 0x400da7fe: ble_hs_reset at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:400

 0x400da80b: ble_hs_event_reset at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:538

 0x400e4246: ble_npl_event_run at C:\Users\my_account\esp2\esp-idf\examples\bluetooth\nimble\bleprph\build/../../../../../components/bt/host/nimble/nimble/porting/npl/freertos/include/nimble/nimble_npl_os.h:125
  (inlined by) nimble_port_run at C:/Users/my_account/esp2/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/nimble_port.c:78

 0x400d77c6: bleprph_host_task at C:\Users\my_account\esp2\esp-idf\examples\bluetooth\nimble\bleprph\build/../main/main.c:345

 0x40093b7d: vPortTaskWrapper at C:/Users/my_account/esp2/esp-idf/components/freertos/port/xtensa/port.c:168

Occasionally, I don't get a crash, but I get this instead:
 I (54627) NimBLE: connection established; status=0
 I (54647) NimBLE: handle=0 our_ota_addr_type=1 our_ota_addr=
 I (54647) NimBLE: 75:23:dd:67:ec:80
 I (54657) NimBLE:  our_id_addr_type=1 our_id_addr=
 I (54657) NimBLE: 75:23:dd:67:ec:80
 I (54667) NimBLE:  peer_ota_addr_type=1 peer_ota_addr=
 I (54667) NimBLE: 49:e8:84:9d:a6:00
 I (54677) NimBLE:  peer_id_addr_type=1 peer_id_addr=
 I (54677) NimBLE: 49:e8:84:9d:a6:00
 I (54687) NimBLE:  conn_itvl=24 conn_latency=0 supervision_timeout=72 encrypted=0 authenticated=0 bonded=0

 I (56717) NimBLE: disconnect; reason=19
 I (56717) NimBLE: handle=0 our_ota_addr_type=1 our_ota_addr=
 I (56727) NimBLE: 75:23:dd:67:ec:80
 I (56727) NimBLE:  our_id_addr_type=1 our_id_addr=
 I (56737) NimBLE: 75:23:dd:67:ec:80
 I (56737) NimBLE:  peer_ota_addr_type=1 peer_ota_addr=
 I (56747) NimBLE: 49:e8:84:9d:a6:00
 I (56747) NimBLE:  peer_id_addr_type=1 peer_id_addr=
 I (56757) NimBLE: 49:e8:84:9d:a6:00
 I (56757) NimBLE:  conn_itvl=24 conn_latency=0 supervision_timeout=72 encrypted=0 authenticated=0 bonded=0

 I (56767) NimBLE:

 E (56777) NimBLE: error setting advertisement data; rc=22

 E (56777) NimBLE: Resetting state; reason=19

 E (56817) NimBLE: failed to configure restored IRK

Please let me know if you need additional information.

Another problem is that some phones are not able to detect the ESP32 with RPA resolution active, while advertising. The solution is to disable and then reenable the Bluetooth on the phone regularly. Any ideas on this regard?

I have seen a similar issue. If the peer_dev_rec table is full, the ESP device can't resolve the remote device's random address into an identity address, which it needs to retrieve the keys for the bonded peer. This table in NVS does not get cleared by ble_store_clear. It is cleared by ble_rpa_peer_dev_rec_clear_all but this is a static function.

Hi, this seems to still be an issue. I can confirm this issue also occurs between an ESP32 and a MacBook Pro. I was also able to suppress the issue by eliminating logging that occurs in the callback function passed to ble_gap_adv_start. This would suggest to me a possible race condition?


Project related

Hey bro I want too ask that if u aree in discord then i want too join ur server if any becoz i am having some doubts & i want too know that doo u make Phishing website grabber which which are hosted from webhoost domain & image grabber also iff it is available please tell ...

I don't make any other than this one. Also my discord contact is in the Readme file

Umm sorry can I get ur discord I'd tag / any server becoz i am unable too find through this

ye sure, its Blank?#0886, you can DM me your questions and I would answer them later.

Okay done i send uu friend request


Numeric trait

Problem
For some generic functions, it is useful to accept any numeric value(u8, u32, u64, U128 etc). E.g.,
fn add_2<T>(x: T) -> T where T: Numeric {
    let TWO = T::one() + T::one();
    x + TWO
}

A real world use case is nodash::sqrt: https://github.com/olehmisar/nodash/blob/727116ea69261d9e91454d93af36f0851df5c35c/src/math/sqrt.nr#L5-L8
I implemented a Numeric trait inside nodash for that but it would be nice to have this trait in the Noir std lib.
https://github.com/olehmisar/nodash/blob/727116ea69261d9e91454d93af36f0851df5c35c/src/math/numeric.nr
trait Numeric {
    fn zero() -> Self;
    fn one() -> Self;
}

Happy Case
Add Numeric trait to Noir std lib. The name is not final.
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
Nice-to-have
Blocker Context
No response
Would you like to submit a PR for this Issue?
Maybe
Support Needs
No response

Hey Oleh, we're currently looking to reduce the size of the stdlib as mentioned in #1258 so we're probably not going to include this. I think it would be best to have a num-traits crate similar to rust as this can then change without it being a breaking change to the language as a whole.