point2las: propagate SRS?

Describe the bug
point2las appears to be stripping rich projection information and replacing it with a truncated proj4 string. Is this intended?
To Reproduce
Steps to reproduce the behavior.
The resulting SRS is reported as:
"GEOGCS[\"unknown\",DATUM[\"unknown\",SPHEROID[\"unknown\",1737400,0]],PRIMEM[\"Reference meridian\",0],UNIT[\"degree\",0.0174532925199433,AUTHORITY[\"EPSG\",\"9122\"]],AXIS[\"Latitude\",NORTH],AXIS[\"Longitude\",EAST]]",

and
    "spatialreference": "GEOGCS[\"unknown\",DATUM[\"unknown\",SPHEROID[\"unknown\",1737400,0]],PRIMEM[\"Reference meridian\",0],UNIT[\"degree\",0.0174532925199433,AUTHORITY[\"EPSG\",\"9122\"]],AXIS[\"Latitude\",NORTH],AXIS[\"Longitude\",EAST]]".

Note that I tested passing the projection fully escaped (as in the command above) and with all \" escape/quotes removed. The resulting projection reported from proj info was the same.
One thing that I am concerned about opening this bug report is that the issue could be with pdal either in the write or in the info call. I figured I would start here, to confirm that the rich SRS is being written and then, as needed link this issue to a PDAL issue.
Expected behavior
I would expect the passed SRS to be present / reported in the resulting LAZ file.
Your Environment (please complete the following information):

OS: Linux
ASP Version: 1-23-24 nightly
Any other environment information that might be helpful?

Additional context
I can upload (and email a download link) as needed. The DTMs that I have are ~55MB and git caps uploads on issues at 25MB.

Oof.  PDAL should use latest PROJ9 and respect CRS definitions, but I have not tested for planetary bodies. My guess is the ASP PDAL call is responsible, maybe here: https://github.com/NeoGeographyToolkit/StereoPipeline/blob/f2bcbd219d6787961f189e9a16c5f5620c353b0d/src/asp/Tools/point2las.cc#L280
This brings up the larger issue to update ASP CRS support to PROJ9.
Just the other day, I noticed that pc_align is still relying on proj4 strings to define CRS of points in csv file.
I did a quick search and many ASP utilities currently rely on this: https://stereopipeline.readthedocs.io/en/latest/search.html?q=proj4
I think anywhere ASP currently expects proj4, we should accept any supported CRS definition (EPSG codes, WKT2, proj4, whatever...see list of options here https://proj.org/en/9.2/apps/projinfo.html) and leverage the latest PROJ9 parser.

I think anywhere ASP currently expects proj4, we should accept any supported CRS definition (EPSG codes, WKT2, proj4, whatever...see list of options here https://proj.org/en/9.2/apps/projinfo.html) and leverage the latest PROJ9 parser.

Agreed. I had (erroneously) assumed that that was the case. Basically, pass anything PROJ will ingest and then forget about it.
Ultimately, I am trying to create a huge merged point cloud using entwine and I suspect that PROJ issues exist through the entire stack. The issues that may be in ASP are just the first step of getting a large, merged point cloud in a cloud native form.

This will require some work to sort out. Is there no suitable PROJ.4 string that may be good enough?

Here is what I posted the other day to a OpenPlanetary channel. But the hope is that you don't need to deal with it. Let PROJ deal with it (which means it will require a newer version -- if that is the issue).
WKT2 and/or PROJJSON are likely the methods to use going forward.

both are very verbose (unlike the short-hand proj string).

WKT2 has good support in PROJ/GDAL/QGIS/...
WKT2 I think is used in GeoPackage
WKT2 can be used in LAZ/COPC lidar format (perhaps some limitations).
While still in the works by OGC, GeoTIFF may be updated to support a WKT2 string. This will take a longtime to take over current GeoTIFF keywords, but shows what others are thinking for pushing WKT2 forward.
WKT2 is the default for the IAU 2015 codes (if anything, these codes can be used for examples to be manually updated for custom WKT2 strings).
Our STAC metadata is using WKT2, e.g.,: DTEPD_032625_1120_041144_1120_A01
Lastly, you can see what a WKT2 string might look like by using PROJ or GDAL:
`gdalsrsinfo -o WKT2 '+proj=stere +lon_0=31.6218 +lat_0=-85.42088 +R=1737400 +units=m'

Note the many "unknown" description tags. Hence the issue with PROJ strings (and this conversion is also making a best guess for defining meter and degree lengths).

So I guess until JSON takes over the world, I would recommend using WKT2 when possible. The main complaint for WKT2 is that it has a somewhat an odd formatting method.

I'll second what Trent has posted. Ideally, this is using anything PROJ supported and data producers are using either short codes or WKT2 (or the wrapped WKT2 that is PROJJSON).
In the short term, I can think about how viable it is to debug the projection issues down stream when working with truncated proj strings. This is less of an issue when looking, for example, at orthos or intersection error images in a GIS. It becomes a bit trickier working with point cloud data that should have a proper vertical datum assigned.
All of that is to say, not a fire, but definitely something to consider, from my perspective, as important.

+1 for WKT2 as best current option.  It's cumbersome, but the only way to unambiguously define 3D CRS.  We can recommend people use WKT2 when possible, and point users to PROJ and other external doc on how to define CRS.  But we also want to support legacy CRS definitions and the familiar EPSG codes.  In practice, I think we can just replace any ASP utility options formerly requiring proj4 to be more generic srs, mirroring the GDAL syntax.
As @oleg-alexandrov mentioned, this is a larger task, requiring additional research and dev time to identify and update instances throughout the ASP/VW code base.  But it will absolutely be worth the trouble in the long run, especially now that the bulk of the implementation is done in PROJ/GDAL.
Can refer to existing implementations in GDAL and PROJ for generic parsing of user-defined SRS input.  A few examples from utilities that do this (I haven't dug into API for this functionality):

https://github.com/OSGeo/gdal/blob/a3f8f3dddfefc516c3ba86d195196d28cb673690/apps/gdalsrsinfo.cpp#L315
https://github.com/OSGeo/PROJ/blob/master/src/apps/projinfo.cpp

Beyond supporting unambiguous CRS definitions, at least on Earth, we also need to start specifying and tracking dataset epochs (e.g., stereo image acquisition date).  And assuming we have proper CRS definitions with epoch, we can then rely on PROJ to correct for plate motion when the user specifies an point2dem/point2las output CRS with a fixed epoch like NAD83(2011) and the forthcoming updated NGS datums (https://geodesy.noaa.gov/datums/newdatums/index.shtml) for the US.
Most vendor camera position metadata will use the latest ITRF realization, and most users will specify a dynamic output CRS (like "WGS84", or hopefully, a specific WGS84 realization, like "WGS84 (G2139)").  This is fine, but we need to record the epoch of the observation so that these PC/DEM products can be combined with other datasets acquired at different epochs in the same dynamic CRS (e.g., combining WV-1 DEM from 2007 with WV-3 DEM of the same site from 2024, features will have moved ~10-50 cm horizontally due to plate motion, depending on the location).  This may not sound like a big deal, but the geolocation errors introduced by ignoring these issues with current ASP CRS handling/assumptions greatly exceeds accuracy of most reference lidar and GCP datasets.
In short, we need improved CRS support anywhere we integrate external datasets in ASP (e.g., bundle_adjust, pc_align) and anywhere we export products with a CRS definition (e.g., point2dem, point2las, dem_geoid).  I think next step is to identify instances throughout the code base where this needs attention, so we can assess scope and dev time required.

I made ASP accept any string passed via --t_srs. It goes directly to GDAL. I tested with Jay's Moon string, GeoJSON, and a couple of Earth strings.  This required a big overhaul of our 10-year old projection handling logic.
This will be available in tomorrow's build.
Here is what pdal info will output:
"gtiff": "Geotiff_Information:\n   Version: 1\n   Key_Revision: 1.0\n   Tagged_Information:\n      End_Of_Tags.\n   Keyed_Information:\n      GTModelTypeGeoKey (Short,1): ModelTypeGeographic\n      GTRasterTypeGeoKey (Short,1): RasterPixelIsArea\n      GeographicTypeGeoKey (Short,1): User-Defined\n      GeogCitationGeoKey (Ascii,122): "GCS Name = Moon(2015)-Sphere/Ocentric|Datum = Moon(2015)-Sphere|Ellipsoid = Moon(2015)-Sphere|Primem = ReferenceMeridian|"\n      GeogGeodeticDatumGeoKey (Short,1): User-Defined\n      GeogAngularUnitsGeoKey (Short,1): Angular_Degree\n      GeogEllipsoidGeoKey (Short,1): User-Defined\n      GeogSemiMajorAxisGeoKey (Double,1): 1737400          \n      GeogSemiMinorAxisGeoKey (Double,1): 1737400          \n      GeogPrimeMeridianLongGeoKey (Double,1): 0                \n      End_Of_Keys.\n   End_Of_Geotiff.\n",


vscode/package.json distro property

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Latest
OS Version: Window 10

Steps to Reproduce:

Package.json/package.json) has an invalid field("distro": "51e5bb745ed01b333d96df102d750c9ec33ffe23").
Yarn package.json documentation does not include a distro field.

distro is a custom property used by our internal build scripts. Why do you think it's invalid?

I thought it was invalid because it wasn't a standard field and I didn't
see where it was used in the application by doing a search on "distro".
Which file is it used in?
On Mon, Nov 7, 2022 at 8:08 AM Martin Aeschlimann @.***>
wrote:

distro is a custom property used by our internal build scripts. Why do
you think it's invalid?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/165650#issuecomment-1305592984,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYEG2E3VDPY6HGCNGZ5MIXLWHD5OPANCNFSM6AAAAAARYOKIFQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

It's used in an internal build script. Many tools add their custom properties to package.json, there's nothing invalid about it.

If it is used for another repository then I would say that other
repositories should be forked from this repository and its customizations
should only reside there. This would keep this repository clean and
relative. Otherwise, it seems others could do the same and the codebase
would get artificially inflated.
On Mon, Nov 7, 2022 at 2:15 PM Martin Aeschlimann @.***>
wrote:

It's used in an internal build script. Many tools add their custom
properties to package.json, there's nothing invalid about it.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/165650#issuecomment-1306072710,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYEG2E335YGFM7KDYQQORSTWHFILJANCNFSM6AAAAAARYOKIFQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@aeschli is the internal build script in this repository? If so, where is the distro property used in it?

Here is where that property is used.
Yes, it's a commit id into a different (internal) repository that contains the bits that are used for the Microsoft Visual Studio Code distribution. Yes, I think there's some work ongoing to do this with a fork instead, but IMO having the extra field has not been an issue.


Change from bash to sh to execute shell commands

WaitUntilBashCommandsAreCompleted.cs: changed from /bin/bash to bin/sh - sh will point to the actual implementation of the shell ( bash, dash, etc.. ).

WaitUntilPortsAreAvailable.cs: changed from timeout 15 bash -c \"echo > /dev/tcp/localhost/8080\" to a boolean expression with some ways to try and check if the port is available (like the testcontainers-java version does): true && (cat /proc/net/tcp{{,6}} | awk '{{print $2}}' | grep -i :{port} || nc -vz -w 1 localhost {port} || /bin/bash -c '</dev/tcp/localhost/{port}');

Renamed WaitUntilBashCommandsAreCompleted.cs to WaitUntilShellCommandsAreCompleted.cs

Both are fine too me atm, whatever is easier for you :)


fix #581: set event listeners to be passive

Hi,
this PR fixes #581. All Tests pass locally and the docs seem to work still fine. Google Lighthouse does not complain about passive event listeners anymore.

Closing this because of wrong branch name,


nixos/update-users-groups.pl: print UIDs and GIDs

Motivation for this change
This makes it possible for users to take action and fixup the UIDs/GIDs
that NixOS won't touch.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Instead of showing this output from "nixos-rebuild switch":
  warning: not applying GID change of group ‘munin’
  warning: not applying UID change of user ‘ntp’

print this:
  warning: not applying GID change of group ‘munin’ (95 -> 102)
  warning: not applying UID change of user ‘ntp’ (3 -> 179)

This makes it possible for users to take action and fixup the UIDs/GIDs
that NixOS won't touch.

I'd like to backport to stable, unless someone objects (with good reasons :-)).


New Playerctl Signal Module

This is a signal module in which users can connect to signals to grab playerctl info. Currently, this is what it supports:

Song Title
Album Art (the path this module downloaded the art to)
If playing or not
Position
Song Length

This module relies on playerctl and curl. If the user has this module disabled, they won't need those programs.

[x] the actual daemon
[x] use -F (follow) to get rid of the time stuff (update when change)
[ ] documentation
[ ] examples

Using this module, one can make a widget for a playerctl app such as ncspot and not worry about the backend:

Any more ideas and feature requests are welcome!

@Nooo37 On my system $XDG_CACHE_HOME isn't set, so it defaults to $HOME/.cache/awesome. The code here should switch to the .cache folder if the XDG variable isn't set,. If yours is, can you try the script out?

Looks good and works for me with mpd except for the album art which seems to be implemented spotify-specific. There are only two little rather unrelated things: The comment at the start needs to be renewed. bling::playerctl::info is apperently bling::playerctl::position and the variable names stdout and out are also a little untelling. The folder name should maybe also be signal since except for helpers and icons the other three folders (and the two that are actually called by the user) are also in singular. Good job though

@Nooo37 Alright I'll get that done, I know the album art is spotify specific (but somehow it works for youtube thumbnails). I can implement an option or a detection to switch between the commands.


Add arithmetic functions

Most notably the ones used by an expression parser:

plus (will also concatenate strings)
minus
times
divide
div (integer division)
mod
power
negate (unary minus)

DIV is just a function, not an operator.


[FLINK-25031][runtime] Job finishes iff all job vertices finish.

What is the purpose of the change
Let the job finish iff all job vertices are finish, since execution vertices can be lazily created when using adaptive batch scheduler.
Brief change log
Job finishes iff all job vertices finish.
Verifying this change
This change can be covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

@flinkbot  run azure

I rebased to include the fix of FLINK-25150(which will fail the ci test)

Merging.


Fix template for get amd64 yq binary

Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Please fix with:
git config user.name "Your actual name"
git config user.email<EMAIL_ADDRESS>git commit -s --amend
git push origin patch-1 --force

And state how you've tested this.

How Has This Been Tested?

Can't be left blank


Fix syntax error in user-defined-functions docs (unecessarily capital…

…ized)

Why are these changes needed?
In https://microsoft.github.io/autogen/docs/topics/code-execution/user-defined-functions#provide-the-function-to-the-executor, the following code snippet (and subsequent similar ones) throws a syntax error:
code = f"""
from {LocalCommandLineCodeExecutor.FUNCTIONS_MODULE} import add_two_numbers

print(add_two_numbers(1, 2))
"""

due to FUNCTIONS_MODULE being unnecessarily capitalized.
Code being referred to: https://github.com/microsoft/autogen/blob/972b4ed024fbf5657467196832017ac9380da880/autogen/coding/local_commandline_code_executor.py#L72

Related issue number
I couldn't find any related issues.

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

I realised this a little late, but do I have to also render the changes in the website/ dir? I wasn't sure how to do that at that time :/


Envoy 1.28.5 Image building failed

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: Envoy 1.28.5 Image building failed
Description:

What issue is being seen? Describe what should be happening instead of
Unable to build envoy image because of its failing to pull the images from google

Repro steps:

Include sample requests, environment, etc. All data and inputs

#16 12.33   /envoy/WORKSPACE:13:19: in
#16 12.33   /envoy/bazel/repositories.bzl:310:32: in envoy_dependencies
#16 12.33   /envoy/bazel/repositories.bzl:1060:26: in _com_googlesource_googleurl
#16 12.33   /envoy/bazel/repositories.bzl:37:23: in external_http_archive
#16 12.33   /build/bazel_root/base/external/envoy_api/bazel/envoy_http_archive.bzl:16:17: in envoy_http_archive
#16 12.33 Repository rule http_archive defined at:
#16 12.33   /build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in
#16 12.36 WARNING: Download from https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: An error occurred during the fetch of repository 'com_googlesource_googleurl':
#16 12.36    Traceback (most recent call last):
#16 12.36 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.36 		download_info = ctx.download_and_extract(
#16 12.36 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: /envoy/WORKSPACE:13:19: fetching http_archive rule //external:com_googlesource_googleurl: Traceback (most recent call last):
#16 12.36 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.36 		download_info = ctx.download_and_extract(
#16 12.36 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: @com_googlesource_googleurl//build_config:system_icu :: Error loading option @com_googlesource_googleurl//build_config:system_icu: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.38
#16 ERROR: process "/bin/sh -c ./ci/do_ci.sh bazel.release.server_only.binary" did not complete successfully: exit code: 2

[envoy_builder 7/7] RUN ./ci/do_ci.sh bazel.release.server_only.binary:

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:

Include the config used to configure Envoy.

Logs:
#16 12.33   /envoy/WORKSPACE:13:19: in
#16 12.33   /envoy/bazel/repositories.bzl:310:32: in envoy_dependencies
#16 12.33   /envoy/bazel/repositories.bzl:1060:26: in _com_googlesource_googleurl
#16 12.33   /envoy/bazel/repositories.bzl:37:23: in external_http_archive
#16 12.33   /build/bazel_root/base/external/envoy_api/bazel/envoy_http_archive.bzl:16:17: in envoy_http_archive
#16 12.33 Repository rule http_archive defined at:
#16 12.33   /build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in
#16 12.36 WARNING: Download from https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: An error occurred during the fetch of repository 'com_googlesource_googleurl':
#16 12.36    Traceback (most recent call last):
#16 12.36 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.36 		download_info = ctx.download_and_extract(
#16 12.36 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: /envoy/WORKSPACE:13:19: fetching http_archive rule //external:com_googlesource_googleurl: Traceback (most recent call last):
#16 12.36 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.36 		download_info = ctx.download_and_extract(
#16 12.36 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.36 ERROR: @com_googlesource_googleurl//build_config:system_icu :: Error loading option @com_googlesource_googleurl//build_config:system_icu: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp10425872286601993441/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.38
#16 ERROR: process "/bin/sh -c ./ci/do_ci.sh bazel.release.server_only.binary" did not complete successfully: exit code: 2

[envoy_builder 7/7] RUN ./ci/do_ci.sh bazel.release.server_only.binary:

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

update to the latest commit on the release/v1.28 branch - that should resolve your issue/s
1.28 is about to EOL so we are unlikely to cut another release for it

Thanks @phlax
i have taken the release tag 1.28.7 still i am seeing the same issue
#16 12.54   /build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in <toplevel>
#16 12.57 WARNING: Download from https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.57 ERROR: An error occurred during the fetch of repository 'com_googlesource_googleurl':
#16 12.57    Traceback (most recent call last):
#16 12.57 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.57 		download_info = ctx.download_and_extract(
#16 12.57 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp13815936647425249279/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.57 ERROR: /envoy/WORKSPACE:13:19: fetching http_archive rule //external:com_googlesource_googleurl: Traceback (most recent call last):
#16 12.57 	File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
#16 12.57 		download_info = ctx.download_and_extract(
#16 12.57 Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp13815936647425249279/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.58 ERROR: @com_googlesource_googleurl//build_config:system_icu :: Error loading option @com_googlesource_googleurl//build_config:system_icu: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp13815936647425249279/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
#16 12.59
#16 ERROR: process "/bin/sh -c ./ci/do_ci.sh bazel.release.server_only.binary" did not complete successfully: exit code: 2

update to the latest commit on the release/v1.28 branch ...

I am trying to compile latest main and getting same error
WARNING: Download from https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
ERROR: An error occurred during the fetch of repository 'com_googlesource_googleurl':
   Traceback (most recent call last):
        File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
                download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp652063547292919850/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
ERROR: /source/WORKSPACE:13:19: fetching http_archive rule //external:com_googlesource_googleurl: Traceback (most recent call last):
        File "/build/bazel_root/base/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
                download_info = ctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp652063547292919850/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
ERROR: @com_googlesource_googleurl//build_config:system_icu :: Error loading option @com_googlesource_googleurl//build_config:system_icu: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /build/bazel_root/base/external/com_googlesource_googleurl/temp652063547292919850/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51

the solution is the same - use the latest commit from the release/v1.28 branch - there will be no further releases of that branch, but the fix is there

@phlax I am using main branch and the issue is same.
fixed it now by modifying
git diff
diff --git a/bazel/repository_locations.bzl b/bazel/repository_locations.bzl
index 8619e3376f..ad63c5a193 100644
--- a/bazel/repository_locations.bzl
+++ b/bazel/repository_locations.bzl
@@ -1208,7 +1208,7 @@ REPOSITORY_LOCATIONS_SPEC = dict(
         project_url = "https://quiche.googlesource.com/googleurl",
         # Static snapshot of https://quiche.googlesource.com/googleurl/+archive/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz
         version = "dd4080fec0b443296c0ed0036e1e776df8813aa7",
-        sha256 = "59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51",
+        sha256 = "fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325",
         urls = ["https://storage.googleapis.com/quiche-envoy-integration/{version}.tar.gz"],
         use_category = ["controlplane", "dataplane_core"],
         extensions = [],

Is there any updates on this? I have the same problem with v1.31.2. I tried with later tags but didn't work as well.
I manually downloaded this link https://quiche.googlesource.com/googleurl/+archive/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz
that get the hash fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 instead of 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51

@congrab

update to the latest commit

on whichever branch you are trying to build
we are ~imminently going to cut a set of patch releases for unrelated reasons, but all supported branches are now fixed at their latest HEAD - as is the now EOL release/v1.28 branch


Ruby, Windows, MSYS2

I'm still on the 'wait list' for Actions, so I haven't been able to look into it seriously.
To fully support Ruby on Windows, it would certainly be helpful to have the MSYS2 build system installed, along with access to the packages used to build Ruby.  Restricting Ruby to 2.4 and later, I believe all the packages are shared, with the exception of OpenSSL.
Ruby 2.4 currently uses OpenSSL 1.0.2, Ruby 2.5 and later use 1.1.1.  This is due to the std-lib version of Ruby OpenSSL being used (2.0.9 for 2.4, 2.1.2 for 2.5 and later).
Otherwise, the only package commonly used that isn't repo specific would be ragel.

Closing in favor of #30. Let me know if there's additional info that needs to be pulled out of this issue besides adding MSYS2.


MINOR: Store separate output per test case instead of suite

Currently, output captured during tests is combined for every test in the suite and stored in a single location. This makes it difficult to diagnose CI failures since that combined test output is truncated if it exceeds a certain length, which often means that output for entire test cases at a time gets completely wiped.
The change here causes output to be stored per test case (i.e., method) instead of suite (i.e., class), which should make more information available and reduce the impact of truncation. If/when it becomes possible to store complete test output for failing tests only (this is currently not feasible with the Jenkins JUnit plugin), it will also allow us to retain less test output since we'll be able to store the output of individual failed cases instead of entire suites that may only contain one or two failures.
I'm unsure if this approach works for JUnit 5 or not, so I'm opening this PR as a draft for now. If/when I've been able to validate compatibility, I'll mark it ready for review.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

#14795 :+1:


upgrade ember-cli-babel to ^7.0.0

Tests fail on this line where owner is undefined when the version fo Ember is not ancient. Will dig in


Include custom cookies in request

Hi, not sure where else to post this, but i need the ability to include a cookie when phantom js requests a file. I can see how i might do this by modifying your source code (which i'd rather not do), but i cannot work out where/how and in what format to supply cookies in the initial conversion function.
Below is the code i am using, i'd assumed i could just pass a cookies property in the options object. Tried several different formats, and tried to trace through your code but had no luck.
conversion({
url: request.post.location',
// waitForJS: true,
// waitForJSVarName: 'ready_to_print'
}, function(err, pdf) {
console.log(pdf.logs);
console.log(pdf.numberOfPages);
pdf.stream.pipe(response);
});
Tried:
cookie: [[name, value]]
cookie: [{name: name, value: value}]
cookie: ["name=value"]
None of the above worked.
I've looked at phantomjs itself which recommends using addCookie methods, but since i dont have access to the phantom objects themselves, im not sure how to go about this (again without modifying the code).
thanks!
Callem.

Hi,
you are right. This requires extending this package. Don't you want to try to implement this and send PR?

Extend the conversion function options parameter with cookies object
Iterate over the object properties in the phantomjs script and call addCookie
The unit test could simply just add cookie, write it to console.log and assert the correct value is in the output.
Update readme

The PR would be basically the same as this one - https://github.com/pofider/phantom-html-to-pdf/pull/46/files
You would probably only use object instead of array to pass cookies.
What you think?

Hi jan, ill give this a go and submit a pr if im succesful. Thanks for the
pointers!
On Mon, 20 Mar 2017 at 9:35 pm, Jan Blaha<EMAIL_ADDRESS>wrote:

Hi,
you are right. This requires extending this package. Don't you want to try
to implement this and send PR?

Extend the conversion function options parameter with cookies object
Iterate over the object properties in the phantomjs script and call
addCookie
The unit test could simply just add cookie, write it to console.log
and assert the correct value is in the output.
Update readme

The PR would be basically the same as this one -
https://github.com/pofider/phantom-html-to-pdf/pull/46/files
You would probably only use object instead of array to pass cookies.
What you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pofider/phantom-html-to-pdf/issues/54#issuecomment-287723856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlydJuXhDwIfDgljj9CJJK-1HbYZOlks5rnlaOgaJpZM4MiANg
.

Hi Jan - unfortunately we didn't end up using phantomjs at my workplace -
was consuming too much of my time for a really simple feature. So not sure
when/if i'll get a chance to add this in. I'll try but just wanted to warn
you.
Also FYI, i did give it a quick go this morning, but realized the code i
had from the npm install was different from what is in your git repo -
certain files were missing and their use had changed, e.g conversionScript
instead of serverScript - confused me a bit.
On Tue, Mar 21, 2017 at 7:47 AM, callem pittard<EMAIL_ADDRESS>wrote:

Hi jan, ill give this a go and submit a pr if im succesful. Thanks for the
pointers!
On Mon, 20 Mar 2017 at 9:35 pm, Jan Blaha<EMAIL_ADDRESS>wrote:

Hi,
you are right. This requires extending this package. Don't you want to
try to implement this and send PR?

Extend the conversion function options parameter with cookies
object
Iterate over the object properties in the phantomjs script and
call addCookie
The unit test could simply just add cookie, write it to
console.log and assert the correct value is in the output.
Update readme

The PR would be basically the same as this one -
https://github.com/pofider/phantom-html-to-pdf/pull/46/files
You would probably only use object instead of array to pass cookies.
What you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pofider/phantom-html-to-pdf/issues/54#issuecomment-287723856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlydJuXhDwIfDgljj9CJJK-1HbYZOlks5rnlaOgaJpZM4MiANg
.

Ok, sure....
The final scripts distributed to npm are created in npm prepublish or during npm tests.
=> The state of git master vs and npm latest is currently the same except some minor changes done to readme which were not released yet.

Hmm ok, i'm not super familiar with npm publishing - just did a quick check

the files in npm that were not in master were serverScript.js,
standaloneScript.js, but im going to hazard a guess that something is
generating those files when you publish ?

On Tue, Mar 21, 2017 at 9:11 PM, Jan Blaha<EMAIL_ADDRESS>wrote:

Ok, sure....
The final scripts distributed to npm are created in npm prepublish or
during npm tests.
=> The state of git master vs and npm latest is currently the same except
some minor changes done to readme which were not released yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pofider/phantom-html-to-pdf/issues/54#issuecomment-288032483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlyToXoAp2-71sir-ZsPBzsLsY_wmLks5rn6JKgaJpZM4MiANg
.

On Tue, Mar 21, 2017 at 11:04 PM, callem pittard<EMAIL_ADDRESS>wrote:

Hmm ok, i'm not super familiar with npm publishing - just did a quick
check - the files in npm that were not in master were serverScript.js,
standaloneScript.js, but im going to hazard a guess that something is
generating those files when you publish ?
On Tue, Mar 21, 2017 at 9:11 PM, Jan Blaha<EMAIL_ADDRESS>wrote:

Ok, sure....
The final scripts distributed to npm are created in npm prepublish or
during npm tests.
=> The state of git master vs and npm latest is currently the same except
some minor changes done to readme which were not released yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pofider/phantom-html-to-pdf/issues/54#issuecomment-288032483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZlyToXoAp2-71sir-ZsPBzsLsY_wmLks5rn6JKgaJpZM4MiANg
.

Released in 0.5.0, big thanks to @chips5k for contribution


[WIP] Rewrite and test Github auth logic

Summary:

Create new priority queue-based token cycling logic which correctly handles simultaneous requests using the same token
Correctly support search API rate limits, which are separate from core API rate limits (#1119)
When tokens are exhausted, return an error instead of attempting fallback to our API key
Use a static token in development, when one is configured (replacing #1118)
Split up Github auth logic into separate modules which can be tested in isolation

Todo:

[x] Test persistence
[x] Integration test?
[ ] Consolidate reserve logic, probably in Token
[ ] Incorporate recent changes to lib/github-auth.js

I'm eager to get this shipped, though I'm hesitant to do it until I get access to logs…

Since we have access to errors through Sentry, I think I will revive this and see if we can't nudge it forward.

Warnings

:warning:

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

:warning:

Found 'assert' statement added in lib/github-auth/token-provider.spec.js. Please ensure tests are written using Chai expect syntax

:warning:

Found 'assert' statement added in lib/github-auth/token-pool.spec.js. Please ensure tests are written using Chai expect syntax

:warning:

Found 'assert' statement added in lib/github-auth/github-provider.integration.js. Please ensure tests are written using Chai expect syntax

:warning:

Found 'assert' statement added in lib/github-auth/token-persistence.spec.js. Please ensure tests are written using Chai expect syntax

:warning:

Found 'assert' statement added in lib/github-auth/github-provider.spec.js. Please ensure tests are written using Chai expect syntax

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

  Generated by :no_entry_sign: dangerJS

As I keep working with this, I'm remembering how much work it was to understand the old code, to rework the code to make it testable, and to write the tests. I'm pretty happy with most of this, though I did add a checklist at the top of a few things I'd like to change.
Would someone be willing to pair with me to review, test, and merge this code? It would be great to have a second person's help.
We've merged a little bit of this work in #1736 but there quite a bit left. At this point it seems like a more manageable way forward would be through a series of small PRs, picking this in bit by bit.

After merging #1812, these could be the next steps:

Pull in the reworked initialization and persistence code
Move the token acceptor routes
Deal with the token and auth logic itself

This pull request introduces 1 alert when merging 2ffc96517246a1987353f1240f230c42494fe458 into e46a6fbde13e58562a2868381399ae23fc3f21d6 - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com

Have labeled this a blocker, as it affects the work of #1838.

This pull request introduces 1 alert when merging e334cc81958960733ccb704bcb3d35ced485e04c into a524658e74791a4fe98e4f058a3bb11ec2fa837f - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging eb372a92a360c63ff9ed611b4f732613245f9530 into a524658e74791a4fe98e4f058a3bb11ec2fa837f - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This feels like the home stretch. I updated the todos in the top comment.

This pull request introduces 3 alerts when merging 4bcc87654d64334ede17ab172fdefcdb9673aefa into a524658e74791a4fe98e4f058a3bb11ec2fa837f - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging 19f398cd74f0988aec549da0d0b73f40c937e769 into a524658e74791a4fe98e4f058a3bb11ec2fa837f - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging 375d60923fe697ea91bafe5a7fae2c3f77de79f1 into a524658e74791a4fe98e4f058a3bb11ec2fa837f - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging 7ea08cc61a60f65f0085a3ddbfe8f2945d703e61 into 59fdd8a5b0512592f142eb4a1b76dba11bd8e0c9 - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging 7ea08cc61a60f65f0085a3ddbfe8f2945d703e61 into 38ca6fc396e101594ac624577d40a803817022c3 - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 3 alerts when merging e37d076a18e190675ed7d1df6891588600644d9d into d97a5e46978f96126eb5a786bd60df78401872e9 - view on LGTM.com
new alerts:

3 for Property access on null or undefined

Comment posted by LGTM.com

This pull request introduces 1 alert when merging d6258e448555c66be149753de3fd00620345211b into d97a5e46978f96126eb5a786bd60df78401872e9 - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com


Added three Data Structure and Algorithms course in Free Courses in English

What does this PR do?
This PR will add three Data Structure and Algorithms courses in Free Courses in English under Algorithms & Data Structures section
For resources
YouTube
Why is this valuable (or not)?
Best quality courses provided by top YouTubers
How do we know it's really free?
Courses are on YouTube
For book lists, is it a book? For course lists, is it a course? etc.
These are courses for courses list
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

For youtube, we prefer "playlist" links and the name of the producer/creator. https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md#platforms-and-access-notes
no shortened links

Hi @eshellman, I have added video length for the Data Structures Course by Simplilearn, Also I have mentioned the creator and the source of the course.


Makefile color issue

on certain terminals echo doesn't print the color so the Makefile is uggly
PS : vavaas est mauvais

🤓🤓🤓
(Fixed :))


Bug: Media player entity generates error in HA

Describe the bug
The media player entity is not generated inside HA, and an error is generated
I am here posting the log from HA
2024-10-03 18:54:56.021 WARNING (SyncWorker_8) [homeassistant.helpers.frame] Detected that custom integration 'hass_agent' calls device_registry.async_update_device from a thread other than the event loop, which may cause Home Assistant to crash or data to corrupt. For more information, see https://developers.home-assistant.io/docs/asyncio_thread_safety/#device_registryasync_update_device at custom_components/hass_agent/init.py, line 29: device_registry.async_get_or_create(, please report it to the author of the 'hass_agent' custom integration
2024-10-03 18:54:56.031 ERROR (SyncWorker_8) [homeassistant.util.logging] Exception in updated when handling msg on 'hass.agent/devices/HUNKAHUNKA': '{"serial_number":[...],"device":{"identifiers":"hass.agent-HUNKAHUNKA","manufacturer":"HASS.Agent Team","model":"Microsoft Windows NT 10.0.22631.0","name":"HUNKAHUNKA","sw_version":"2.1.0"},"apis":{"notifications" :true,"media_player":true}}'
Traceback (most recent call last):
File "/config/custom_components/hass_agent/init.py", line 144, in updated
update_device_info(hass, entry, payload)
File "/config/custom_components/hass_agent/init.py", line 29, in update_device_info
device_registry.async_get_or_create(
File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 834, in async_get_or_create
device = self.async_update_device(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 1066, in async_update_device
self.hass.verify_event_loop_thread("device_registry.async_update_device")
File "/usr/src/homeassistant/homeassistant/core.py", line 462, in verify_event_loop_thread
frame.report_non_thread_safe_operation(what)
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 229, in report_non_thread_safe_operation
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 163, in report
_report_integration(what, integration_frame, level, error_if_integration)
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 201, in _report_integration
raise RuntimeError(
RuntimeError: Detected that custom integration 'hass_agent' calls device_registry.async_update_device from a thread other than the event loop, which may cause Home Assistant to crash or data to corrupt. For more information, see https://developers.home-assistant.io/docs/asyncio_thread_safety/#device_registryasync_update_device at custom_components/hass_agent/init.py, line 29: device_registry.async_get_or_create(. Please report it to the author of the 'hass_agent' custom integration.
Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[x] Problem occurs in HASS.Agent
[ ] Problem occurs in Satellite Service

Duplicate, fixed by myself following
https://github.com/LAB02-Research/HASS.Agent-Integration/issues/47#issuecomment-2090454867

Hello, yup, duplicate of https://github.com/hass-agent/HASS.Agent-Integration/issues/2 and relates to the integration rather than HASS.Agent itself.
The fix will work for now but I'd recommend switching to the forked integration https://github.com/hass-agent/HASS.Agent-Integration/issues/2


Incorrect error when interpolating an integer

What version of CUE are you using (cue version)?

$ cue version
cue version 0.3.0-alpha1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
Tried to interpolate a uint field into a string field, and got this error

#R._posstr: invalid interpolation: cannot use >=0 & int (type int) as type string:

Used the following code:

#R: {
  pos:  uint
  _posstr: "\(pos)"
  name: string
}

with cue export
What did you expect to see?
No errors whatsoever, as I have used this in versions 0.2.x without issue and the documentation
actually provides examples of this exact nature (interpolate an integer)
What did you see instead?
The error reported above
This error also appears with cue eval
Additional notes
When operating at the top level the error does not seem to appear

This error is correct, though. Can you give an example where the documentation says this is correct?
The old implementation erroneously did not always catch non-concrete values used in an interpolation, so this change in behavior is a bug fix.
This will work if the value were a concrete integer.

Sorry, I oversimplified the example.
The code below produces the error too.
Notice the error is produced with 0.3.0-alpha1. With the 0.2.2 release it works fine

#R: {
  pos:  uint
  name: "hello_\(pos)"
}

a: #R & {pos: 67}

Then I get

$ cue export testa.cue

#R.name: invalid interpolation: cannot use >=0 & int (type int) as type string:
    testa.cue:5:9

Also

$ cue eval testa.cue

#R.name: invalid interpolation: cannot use >=0 & int (type int) as type string:
    testa.cue:5:9

The error message leads one to believe it is some sort of type conversion problem, not lack of concreteness in fields, which would not cause an error with cue eval ..., and the problem can be circumvented by using the  "strconv" package.
In our current code, that we have working in 0.2.2, we use interpolations of this kind quite profusely.
If the above behavior is expected from 0.3.0-alpha1 onwards, we will need to apply the strconv fix.
However, before embarking on that boat (as we had to do to convert booleans within interpolations, by the way), I want to make sure this is the way it is supposed to work, and if so, express my opinion that it be changed, as this makes interpolation much more cumbersome (having to use conversion functions): the situation where the interpolation is expressed for non-concrete values in a spec, that get concreted later on after unification (as in my last example) is quite usual (and useful).
In the example above, field a gets its field pos with a value of 67 after unification...
What is puzzling is that it actually works when using auxiliary packages like strconv, as my next example shows:

import "strconv"

#R: {
  pos:  uint
  name: "hello_\(strconv.FormatUint(pos,10))"
}

a: #R & {pos: 67}

Then I get the expected result:

{
    "a": {
        "pos": 67,
        "name": "hello_67"
    }
}

Clearly the same concreteness/unconcreteness of the pos field exist in both examples (the one producing the error and the one producing my expected result)
What led me to believe that his was erroneous behavior is the fact that earlier on, to interpolate boolean fields I needed to convert them to strings using the strconv package, and I suspected from the error message received that I was in front of a similar situation.
In fact, I just tested the exact same example, but with field pos of type string instead of uint. Like so:

#R: {
  pos:  string
  name: "hello_\(pos)"
}

a: #R & {pos: "67"}

Then the error does not appear and we get the expected result.
This clearly indicates to me that the problem resides in some inability to convert from int to string in the interpolation (not on any concreteness issue).
By the way, the same is true for boolean conversions (as I mentioned earlier), they require using strconv.
As I said before, if this behavior follows specification I believe the specification should be changed.
If for some reason that was impossible, the documentation should clearly say that only string values can be interpolated.
In any case, the documentation should clarify which values can be auto-converted to strings in interpolation, and what kind of conversion is applied.

From the docs
For interpolation the following is given as an example (with ints):
https://cuelang.org/docs/tutorials/tour/expressions/interpolation
In this other example, strings are used instead, illustrating correct workings of interpolation after unification:
https://cuelang.org/docs/references/spec/#references

Ah, I see what you're saying now. In fact, the interpolation is probably done correctly, after unification, but the error in the definition is not properly discarded. Yes, that is a bug.

This issue has been migrated to https://github.com/cue-lang/cue/issues/487.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Add Apple Intelligence Support

Added Apple Intelligence Support

Sorry, I can't merge this PR.
As the repo name implies, the repo is only for Xcode LLM related stuff.

Saying that, I have added the information to README in case someone do not know the key for Apple Intelligence.
https://github.com/Kyle-Ye/XcodeLLMEligible/commit/bdba498da76ed9d8beb5d0acf4aa86b637142a70
Thanks for reporting it.


fix: center align top grid cell content

According to the design spec. The top grid cell content should be center aligned along the x-axis. This PR fixes that.
I have not been able to keep the content centered while scrolling. As seen in the clip below. I could not come up with a pure CSS solution for that. Otherwise the content would need to be re-rendered via React while scrolling which would be less then ideal for the performance.
DEMO:
https://github.com/qlik-oss/sn-pivot-table/assets/16608020/ba192515-a7f4-48e8-85be-cf159b2f64c4

when texts are ellipses, seems like the center alignment is not applied:

It is applied but the ellipses logic is broken. The div with the text is taking up the whole width of the cell but the text is elliped at the wrong position.
It is the same on main.

Probably we might take a look at that issue in another PR.
(the wrapper div for ellipsis should be centered as well since seems like there are some space to it's right)

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FR] Command to unfocus text

Some commands like escape and tab sometimes work, but not in all cases.
This feature would be useful in places like a browser + vimium setup where by unfocusing, you can then say 'fine' to show links rather than inserting an 'f' into the text field

Where doesn't it work? Also, do you have any suggestion for how to make it work?

Some places where escape doesn't work:

The browser address bar
IntelliJ
Slack

Tab is pretty decent but suffers from many similar issues and you risk selecting other elements which can have unforeseen expects when trying to run commands but really just entering text into them
I don't have a potential solution but I wanted to raise the issue.
Cheers,
Xavier

I'm not sure how you could make this work reliably in all contexts. Maybe we should just look at your specific suggested use case of Vimium? Maybe you just want to map a new command that presses escape and then the letter f? That might close popups or the like though.
Even for your specific case I'm not sure we can have a reliable solution without integration with the browser, or the ability to bind a specific key (e.g. F13) to swap to normal mode in Vimium.

Going to close since it seems like there's not a great solution for all cases and escape covers 80% of cases


Execution Workflow: APA-Scan

WHAT
Write execution workflow for APA-Scan. Use the provided small files for testing (running the workflow on real data is a different issue).
CHECKLIST

[ ] Use snakemake template or nextflow template to create your workflow.
[ ] Comment your code
[ ] Run individual rules/processes in either conda envs or docker/singularity containers for reproducibility
[ ] Input:  .bam or .fastq from test_data
[ ] Give feedback about the method

OUTPUTS (see specification):

[ ] Output: Adhere to output specification for Identification challenge

This BED file contains single-nucleotide position of poly(A) sites identified by the tool.
Fields:

chrom - the name of the chromosome
chromStart - the starting position of the feature in the chromosome
chromEnd - the ending position of the feature in the chromosome; as identified PAS are single-nucleotide, the ending position is the same as starting position
name - defines the name of the identified poly(A) site
score - not used, leave as "."
strand - defines the strand; either "." (=no strand) or "+" or "-".

[ ] Output: Adhere to output specification for quantification challenge

This BED file contains positions of unique poly(A) sites with TPM values for each identified site in the score column.

chrom - the name of the chromosome
chromStart - the starting position of the feature in the chromosome
chromEnd - the ending position of the feature in the chromosome; as identified PAS are single-nucleotide, the ending position is the same as starting position
name - defines the name of the identified poly(A) site
score - TPM value for the identified site
strand - defines the strand; either "." (=no strand) or "+" or "-".

[ ] Can APA-Scan do differential PAS quantification? If yes:

[ ] Output: Adhere to output specification for differential usage challenge

This TSV file contains two columns:

gene ID
significance of differential PAS usage

Column names should not be added to the file.

A LOT of work on this has been done by @SamBryce-Smith in https://github.com/iRNA-COSI/APAeval/pull/160
There were unresolved issues with the tool itself being buggy though.


TileData.get_terrain_peering_bit() returns error

Tested versions
v4.2.1.stable.official [b09f793f5]
System information
Godot v4.2.1.stable - Linux Mint 21 (Vanessa) - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3060 (nvidia; 535.161.07) - AMD Ryzen 5 2600X Six-Core Processor (12 Threads)
Issue description
My gdscript calls TileData.get_terrain_peering_bit() for all tiles in the tile atlas. The reason is to use the peering information for procedural generation.
https://docs.godotengine.org/en/stable/classes/class_tiledata.html#class-tiledata-method-get-terrain-peering-bit
The problem is that I get this error for all tiles which have no peering bits:
E 0:00:00:0861   SuperPosition.gd:116 @ print_tile_bits(): Condition "!is_valid_terrain_peering_bit(p_peering_bit)" is true. Returning: -1
  <C++-Quelle>   scene/resources/tile_set.cpp:5547 @ get_terrain_peering_bit()
  <Stacktrace>   SuperPosition.gd:116 @ print_tile_bits()
                 SuperPosition.gd:70 @ read_superposition_connectors_from_tileset()
                 World.gd:26 @ _ready()

This might be the "problem":
https://github.com/godotengine/godot/blob/master/scene/resources/2d/tile_set.cpp#L6434
solution ideas:

export a gdscript function has_terrain_peering_bit() returning information if any bits are set before asking for it
write a GdNative in my local project and direct access the native API before calling

Steps to reproduce
call get_terrain_peering_bit() on a cell with no peering bit.
Minimal reproduction project (MRP)
this test prints the error:
# works only in Tile Shape "Square"
const TERRAIN_MODE_MATCH_SIDES_DIRECTION := [
	TileSet.CellNeighbor.CELL_NEIGHBOR_TOP_SIDE, # N
	TileSet.CellNeighbor.CELL_NEIGHBOR_RIGHT_SIDE, # E
	TileSet.CellNeighbor.CELL_NEIGHBOR_BOTTOM_SIDE, # S
	TileSet.CellNeighbor.CELL_NEIGHBOR_LEFT_SIDE # W
]

func print_tile_bits(tile_set :TileSet):
	var atlas_source:TileSetAtlasSource = tile_set.get_source(tile_set.get_source_id(0))

	print("get_source_count: ", tile_set.get_source_count())

	var terrain_set = 0

	var terrain_mode := tile_set.get_terrain_set_mode(terrain_set)
	print("terrain_mode: ", terrain_mode)

	if terrain_mode == TileSet.TerrainMode.TERRAIN_MODE_MATCH_SIDES:
		for atlas_count in atlas_source.get_tiles_count():
			var tile_id = atlas_source.get_tile_id(atlas_count)
			for i in TERRAIN_MODE_MATCH_SIDES_DIRECTION.size():
				var peering_bit: int = TERRAIN_MODE_MATCH_SIDES_DIRECTION[i]
				var tile_data:TileData = atlas_source.get_tile_data(tile_id, 0)
				var terrain_bit := tile_data.get_terrain_peering_bit(peering_bit)
				#print("valid: ", tile_data.is_valid_terrain_peering_bit)
				if terrain_bit != -1:
					print("tile_id: ", tile_id)

		for tile in _data:
			var sockets: Array[int] = []
			sockets.resize(TERRAIN_MODE_MATCH_SIDES_DIRECTION.size())
			tile["sockets"] = sockets

			for i in TERRAIN_MODE_MATCH_SIDES_DIRECTION.size():
				var peering_bit: int = TERRAIN_MODE_MATCH_SIDES_DIRECTION[i]
				var tile_data:TileData = atlas_source.get_tile_data(tile.atlas, 0)
				var terrain_bit := tile_data.get_terrain_peering_bit(peering_bit)
				tile["sockets"][i] = terrain_bit
				print("SIDE terrain_bit: ", terrain_bit)

What is your tile shape? Is it isometric? Please provide an MRP to be able to test this, this is likely a configuration issue and you're not providing sufficient details

Yes, the mode only works with square, it need other directions in other modes, this should be documented more clearly, but there's no bug here

Making a PR to expose this on TileData


Layout modifier screenshot tests

Fixes #1877
This is a draft to collect feedback about the screenshot test results in View and ComposeUI.
ComposeUI

Box
⚠ There is no difference in the test results whether or not the margin is assigned. The margin is always "empty" in the screenshots.

Column & Row
✅ Screenshots recorded as expected.

View

Box, Column & Row
⚠ There is no difference, The margin is always applied in the screenshots, even when it's empty

UIView

Box
⚠ The margin is always "empty" in the screenshots.

Column & Row
⚠ The margin is always "Applied" in the screenshots.

See https://github.com/cashapp/redwood/issues/1877#issuecomment-2067501442 or File changes for a visual explanation
Is my test approach correct? If so, should we create issues for the identified findings?

[ ] CHANGELOG.md's "Unreleased" section has been updated, if applicable.

Actually the problem with Compose UI's Box and margins on children is known: #2006. It was simply an omission on the initial PR.

Updated the description with UIView findings

this broke something for me locally when i pulled main. i can't seem to undirty theses images, no matter what i do.

maybe some git-lfs or .gitignore setup i don't have. any ideas?

I tried this and it worked?
git rm --cached -r .
git reset --hard

The pointfree library has some non-determinism. I don't know why.
Explored a bit here: https://github.com/cashapp/redwood/pull/1988#issuecomment-2077838600


rollup

ENHANCEMENT:
Adding rollup ?!!

We literally just went through this with SystemJS -> Webpack, and Webpack is going to work better for the generalized case that the CLI is designed to cover.

@gelliott181 dude i know that,  there isn't better three shaking method than rollup so my issue is an enhancement or not ? please tag it as must have feature that's all?!!! by your comment I think now angular-cli do regression by passing to webpack without keep rollup !!!  is this agile method 😁?  Please apologize but stop tell me "dont have to use cli if don't like" thanks for response anyway

This isn't about tree shaking being better in Rollup than in Webpack, or any specific feature. This isn't Agile (A development process, not a build tool). I'm not saying "Don't use the CLI." I also will not be apologizing for laying out an informed and reasoned disagreement with your feature, specifically pointing out just how far the Angular-CLI team would backtrack (Again) in their progress, along with Rollup not providing features Webpack has brought to the table.
The cons outweigh the pros, and if we need tree-shaking I have a feeling the CLI team is more than capable of integrating that with Webpack. Not only that, but we have Webpack plugins already available (TS: https://github.com/blacksonic/typescript-webpack-tree-shaking, Babel: https://github.com/blacksonic/babel-webpack-tree-shaking). While they're not perfect, that's the beauty of open source: If you find it deficient, you can help to improve it yourself.
With that, my final thoughts on this: We all have things we wish would happen, but every time the needs of the many will outweigh the needs of the few in these sorts of generalized tooling projects. When your needs diverge you can either continue to work with a large group of people all fighting for their needs to be heard, or you can take a fork in the road and find a way that works for you. Nothing in my statements has said you can't integrate Rollup into the CLI and submit a PR for the CLI maintainers to approve. I simply said the development team has made their decisions and is now at a point where they're unlikely to back out as it takes an already delayed schedule and delays it further for little to no benefit for most users.

 I won't write a novel, don't want dedicate time for this. But, I'm not convicted (I know you will say you don't try to get me convicted) anyway, always think "adding rollup is must have feature". They are Google Developers, big contrubutors , webpack and ember cli tools... IMHO I expect more than that from them.  BYE (yes I know I can stop use cli lol)

I agree that unsubstantiated suggestions to replace a major component of the cli should be disregarded. However, I'm wondering about the claims that the current webpack implementation in the cli does not perform tree shaking? From a cursory glance at the aot bundles generated in - - prod mode this appears correct unfortunately...

If you run ng build --prod or ng build --prod --aot it outputs removed functions so it is doing tree shaking, if you want to compare UglifyJs with Rollup tree shaking that is another thing (Rollup may be better).
As far as i can tell CLI beta18 is performing tree shaking.

WARNING in main.641d46f2cf1bf4ab5876.bundle.js from UglifyJs
Dropping unused function scheduleMicroTask [c:/DEV/cli-tools-exp/cli-test/~/@angular/compiler/src/facade/lang.js:21,0]
Dropping unused function getTypeNameForDebugging [c:/DEV/cli-tools-exp/cli-test/~/@angular/compiler/src/facade/lang.js:28,0]
Dropping unused function isDate [c:/DEV/cli-tools-exp/cli-test/~/@angular/compiler/src/facade/lang.js:47,0]
Dropping unused function noop [c:/DEV/cli-tools-exp/cli-test/~/@angular/compiler/src/facade/lang.js:50,0]
Dropping unused function looseIdentical [c:/DEV/cli-tools-exp/cli-test/~/@angular/compiler/src/facade/lang.js:101,0]

@webmaxru dude, thanks but I know that. lol (anyway right persons know about what i'm speakin)

I don't think this is an unreasonable request, even rollup is used for benchmarking angular 2 performance with other frameworks at https://github.com/krausest/js-framework-benchmark by @robwormald. Probably Rob can put more light onto whether using webpack for treeshaking or rollout with closure compiler?

We're not looking at changing the build engine again. For the foreseeable future we'll focus of making it as good as possible using webpack.

Why closing this enhancement! Im not telling change build engine but only tree shaking method ! So maybe help webpack team to get webpack using or do better than rollup... I was thinking they are on it ! Still not understand why close enhancement request

@istiti what you're asking for would be a feature request to webpack, and such functionality is already being discussed here https://github.com/webpack/webpack/issues/2873

that I agree, maybe better write request to webpack

fans self with magazine jer-RY! jer-RY! jer-RY!

?


Swift Package Support

Can you please add swift package support?

Added
https://github.com/mrustaa/ContainerController/blob/master/Package.swift


Fixes : Timeline - Position Issue #1945

Fixes #1945
Fixes #2108
Describe the changes you have made in this PR -
Bugs
1.) The "TIMING DIAGRAM" is overlapping to one more template in the screen sizes 1143px or less.
2.) The toggling on of the navigation bar at screen sizes less than 991px, the contents of the navigation bar are hidden.
This pr fixed both of these issues.
Screenshots of the changes (If any) -

Please provide me with appropriate feedback/review so that I can continue working on this.

@pulkit-30 i didn't see your pr first as you didn't link issue with this and now as you have commented on my pr , then i saw this one .
so please make sure to link issues whenever you create any pr , so that other person can work on different one .(It is most basic rule of open source and it's easy you just have to add Fixes #issue_no )
and for this time i believe we should let maintainers decide whatever is feasible to them
Maintainers please review my pr as well https://github.com/CircuitVerse/CircuitVerse/pull/2623

Thanks for your comment.


user story 5 - As a Linguistic Data Analyst, I need access to comprehensive data on the number of people who speak various languages worldwide, sorted from greatest to smallest, along with the percentage of the world population speaking each language, to conduct in-depth linguistic analysis, identify language trends, and inform decision-making processes related to language education, cultural diversity, and international communication strategies within the organization

tasks to complete
Connect to the existing database.
Add function to retrieve data on population
Add function to retrieve data on spoken languages
Generate report

user story 5 number of people who speak Chinese.
English.
Hindi.
Spanish.
Arabic.
from greatest number to smallest, including the percentage of the world population
SELECT countrylanguage.Language,
SUM(ROUND(countrylanguage.Percentage / 100 * country.Population)) AS speakers_world_wide,
CONCAT(round((SUM(ROUND(countrylanguage.Percentage / 100 * country.Population)) / (SELECT SUM(Population) FROM country)) * 100,2), '%') AS '% of speakers world wide'
FROM countrylanguage
JOIN country ON country.Code = countrylanguage.CountryCode # joining the table country to countrylanguage
WHERE countrylanguage.Language IN ('Chinese', 'English', 'Hindi', 'Spanish', 'Arabic') #  specafiling the 5 asked for languages
GROUP BY countrylanguage.Language
ORDER BY speakers_world_wide DESC; # this is ordering the from greatest number to smallest


⚠ ClamAV has degraded performance

In 46c08ac, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: ClamAV performance has improved in 6a8c20a.


Blob api

feat: Add raw blob endpoint
Updating #4110, this PR enables fetching of raw SHA-ID'd objects via /:repo/:username/raw/blob/:sha1
It builds upon #132 (originally #121)
Signed-off-by: Berengar W. Lehr<EMAIL_ADDRESS>

Codecov Report

Merging #5334 into master will decrease coverage by 0.02%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #5334      +/-   ##
==========================================
- Coverage   37.37%   37.34%   -0.03%
==========================================
  Files         312      312
  Lines       46379    46401      +22
==========================================
- Hits        17332    17329       -3
- Misses      26567    26588      +21
- Partials     2480     2484       +4

Impacted Files
Coverage Δ

routers/repo/download.go
44.44% <0%> (-12.7%)
:arrow_down:

routers/routes/routes.go
85.47% <100%> (+0.02%)
:arrow_up:

modules/context/repo.go
59.8% <55.55%> (-0.08%)
:arrow_down:

models/repo_indexer.go
44.49% <0%> (-3.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1f1f9...5c92f12. Read the comment docs.

@HoffmannP could you add some tests?


DVC View and Plots don't load on dvc-checkpoints-mnist.

I cloned https://github.com/iterative/dvc-checkpoints-mnist. I setup the IDE workspace so the extension is active.
I haven't run any experiments:

I check out the make_checkpoint branch. The DVC view and Plots Dashboard never load.

The Experiments Table says "No Experiments to Display."
Other components do load.
DVC virtual env is loaded via MS Python extension.
$ dvc version
DVC version: 2.11.0 (pip)
---------------------------------
Platform: Python 3.9.13 on macOS-12.4-arm64-arm-64bit
Supports:
        webhdfs (fsspec = 2022.5.0),
        http (aiohttp = 3.8.1, aiohttp-retry = 2.4.6),
        https (aiohttp = 3.8.1, aiohttp-retry = 2.4.6)
Cache types: <https://error.dvc.org/no-dvc-cache>
Caches: local
Remotes: None
Workspace directory: apfs on /dev/disk3s1s1
Repo: dvc, git

p.s. the same happens in the included demo/ project if I set up the extension with "dvc.dvcPath": "demo/.env/bin/dvc" in .vscode/settings.json (no MS Python extension).

⚠ And while Experiments load, the Plots are also not loading on the official demo project:

Note that the project does have some plots:

@jorgeorpinel I can't reproduce this.
How do you setup the env?
What to you in the output channel?

yarn setup:env as explained in the contrib guide. And then set .env/bin/dvc in the Extension config. Will try avirtualenv of my own ⏳

What to you in the output channel?

[version: 0.3.5, 2022-06-20T02:40:56.064Z, pid: 57168] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - FAILED with code 1 (440ms)
ERROR: unknown Git revision 'demo'
[version: 0.3.5, 2022-06-20T02:41:06.572Z, pid: 57177] > dvc status --show-json - INITIALIZED
[version: 0.3.5, 2022-06-20T02:41:06.837Z, pid: 57177] > dvc status --show-json - COMPLETED (267ms)
[version: 0.3.5, 2022-06-20T02:41:06.838Z, pid: 57198] > dvc diff --show-json - INITIALIZED
[version: 0.3.5, 2022-06-20T02:41:07.129Z, pid: 57198] > dvc diff --show-json - COMPLETED (291ms)
[version: 0.3.5, 2022-06-20T02:46:37.790Z, pid: 57247] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - INITIALIZED
[version: 0.3.5, 2022-06-20T02:46:38.258Z, pid: 57247] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - FAILED with code 1 (588ms)
ERROR: unknown Git revision 'demo'
[version: 0.3.5, 2022-06-20T03:03:20.497Z, pid: 57253] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - INITIALIZED
[version: 0.3.5, 2022-06-20T03:03:20.964Z, pid: 57253] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - FAILED with code 1 (472ms)
ERROR: unknown Git revision 'demo'
[version: 0.3.5, 2022-06-20T03:20:35.706Z, pid: 57255] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - INITIALIZED
[version: 0.3.5, 2022-06-20T03:20:36.031Z, pid: 57255] > dvc plots diff demo workspace -o .dvc/tmp/plots --split --show-json - FAILED with code 1 (328ms)
ERROR: unknown Git revision 'demo'

Will try a venv of my own ⏳

Tried this. Didn't help (same issue).

@jorgeorpinel still can't reproduce it. The official demo project - do you open it as "vscode-dvc" or directly as "vscode-dvc/demo"?

Did you run an experiment with a name "demo", or is it a branch name? (trying to understand where does it get that demo revision name)

Hold on... I shouldn't be in that branch ⏳

Opening the demo/ folder directly works! (I had to reload the window after switching back to main). OK so this goes back to monorepo support. I'm confused as to how much of that is expected.

[ ] For now I'll update docs to indicate this current limitation... which is confusing since the Experiments Table does work (I wonder what happens if you have more than one subdir DVC project).

This issue can go back to the OP (about https://github.com/iterative/dvc-checkpoints-mnist/tree/make_checkpoint) !

Seems like there is an issue with dvc-checkpoints-mnist. I just made a fresh clone and tried to pull. Got the following results:
/dvc-checkpoints-mnist make_checkpoint ❯ dvc pull
WARNING: Output 'model.pt'(stage: 'train') is missing version info. Cache for it will not be collected. Use `dvc repro` to get your pipeline up to date.
WARNING: No file hash info found for '/dvc-checkpoints-mnist/model.pt'. It won't be created.
Everything is up to date.
/dvc-checkpoints-mnist make_checkpoint ❯ dvc repro
ERROR: failed to reproduce 'train': Checkpoint stages are not supported in 'dvc repro'. Checkpoint stages must be reproduced with 'dvc exp run'.
/dvc-checkpoints-mnist make_checkpoint ❯ dvc exp run
Running stage 'train':
> python train.py
Traceback (most recent call last):
  File "/dvc-checkpoints-mnist/train.py", line 8, in <module>
    from dvc.api import make_checkpoint
ModuleNotFoundError: No module named 'dvc'
ERROR: failed to reproduce 'train': failed to run: python train.py, exited with 1
/dvc-checkpoints-mnist make_checkpoint ❯

☝🏻 all with a brew install of DVC. I could get this working but it seems broken enough to not bother with for the purpose of testing.

p.s. the same happens in the included demo/ project if I set up the extension with "dvc.dvcPath": "demo/.env/bin/dvc" in .vscode/settings.json (no MS Python extension).

No idea what this means.

No idea what this means.

That part is resolved.


HTTP and ConnectionPool Metrics

Is your feature request related to a problem? Please describe.
Today apm-agent-java does not have the functionality to capture HTTP and JDBC Connection pool metrics for a Java Container(eg Tomcat, websphere liberty etc) and we rely on this pool stats to research any potential issues.
Describe the solution you'd like
Requesting for a feature to be added to apm-agent-java to capture http, jdbc connection pools
Enhancement request spawned off topic: https://discuss.elastic.co/t/http-and-jdbc-connectionpool-stats/177154
Thanks
Rahul

Which JDBC connection pools are you most interested in?
Probably easier to implement once we have resolved https://github.com/elastic/apm-agent-java/issues/469

Which JDBC connection pools are you most interested in?
My understanding is that you are asking for JDBC driver implementation types I am interested in. If not,  Can you elaborate more on this for me please ?

Thank You.

I'm curious which DataSource implementations you are using. Some examples are org.apache.tomcat.jdbc.pool.DataSource, com.zaxxer.hikari.HikariDataSource, com.mchange.v2.c3p0.ComboPooledDataSource and org.apache.commons.dbcp2.BasicDataSource

we use javax.sql.ConnectionPoolDataSource ,javax.sql.XADataSource, org.apache.tomcat.jdbc.pool.DataSource and future integrations would be with com.datastax.oss and some of the JDBC drivers types we use are and not limited to sqljdbc6.jar, db2jcc4.jar and jt400.jar
Please let me know if this information helps.

Hi
I'm interested too, in my case I need of metrics of Hibernate 5.4.2 JMX and metrics of Ehcache 3-JSR107 Monitoring acessible by JMX too.
Unfortunely today I need acess by JConsole or other tool, Jolokia plus Metricbeat is possible, but... ,
for my understanding is too much agents in application to get pratically the same information.

We are interested too and we are using org.apache.commons.dbcp2.BasicDataSource

This is not in the immediate roadmap. For any framework that publishes metrics to the JMX, you can use the capture_jmx_metrics option to capture those.
If you do and want to share (the config and the related dashboard or anything else you did for viewing) with other users, you are welcome to do so through our contrib repo.

has someone ever succeed in configuring it with dbcp2 ? @wolframhaussig by chance?


feat: further bbb options from #96

I implemented the bbb options from #96 into the current version 2.3. For cron I didn't found a template file or something like.
The quotes of defaults/main.yml were different so I formatted them to single quotes.
Let me know if you have further improvements for this.

@BrutalBirdie thanks for you suggestions. I will implement this tomorrow.

Could I suggest adding the options for breakout rooms as well? I don't have a 2.3 installation yet to test, but in my 2.2 installations I needed
# Default settings for breakout rooms
breakoutRoomsEnabled={true|false}
breakoutRoomsRecord={true|false}
breakoutRoomsPrivateChatEnabled={true|false}

in /usr/share/bbb-web/WEB-INF/classes/bigbluebutton.properties
If not fit for current PR i will create one myself, as soon as I have a 2.3 installation so I can perform tests.
Thanks

Could I suggest adding the options for breakout rooms as well? I don't have a 2.3 installation yet to test, but in my 2.2 installations I needed
# Default settings for breakout rooms
breakoutRoomsEnabled={true|false}
breakoutRoomsRecord={true|false}
breakoutRoomsPrivateChatEnabled={true|false}

in /usr/share/bbb-web/WEB-INF/classes/bigbluebutton.properties
If not fit for current PR i will create one myself, as soon as I have a 2.3 installation so I can perform tests.
Thanks

Yes this could fit but keep in mind we override the /usr/share/bbb-web/WEB-INF/classes/bigbluebutton.properties file with /etc/bigbluebutton/bbb-web.properties.

@BrutalBirdie now everything should be fine.
I also added your suggestions @ChrisKar96.

Some changes overlap with # 110 other missing items and will be submitted with # 110. Would be great if that were merged.

@mschwrdtnr Thank you for working on this PR.
The PR looks good to be merged. One more reviewer with write access is required to merge the PR.
Unrelated to this PR how many people has write access to this repository?

@BrutalBirdie what's the problem with this PR? Should I merge the changes with @Davka?
I would say let's merge #110 and I will pull the new state and make the changes that are necessary or overlapping.


Official 1.14 Release Docs

🛑 DO NOT MERGE 🛑 UNTIL KUBERNETES 1.14 IS RELEASED
Target Date: 2019-03-25
Release deadlines
From sig-release:

Date
Description

MAR 1
Open placeholder PRs

MAR 11
PRs ready for review

MAR 18
All PRs reviewed and ready to merge

More information
Contact: @jimangel @MAKOSCAFEE @cody-clark @jaredbhatti @npentrel @simplytunde with any question.

/hold

Release 1.14 megabranch

PR
Based on dev-1.14
Tech LGTM
Docs approved
Merged


Adds Spanish, updates pt-br, zh, id

Updates Portuguese Brazilian, Chinese Simplified and Indonesian to latest translations from Crowdin (now 100% and audited)
Adds Spanish translations from Crowdin (also 100% and audited)

@samajammin @wackerow @CarlBeek
Is this PR ready to merge, and then we cut a release?


https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket

Request type

[] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

I think I found wrong description about protocols param of new WebSocket() .
https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket  says
If you don't specify a protocol string, an empty **string** is assumed.

But whatwg Living Standard says
protocols is either a string or an array of strings.
If it is a string, it is equivalent to an array consisting of just that string;
if it is omitted, it is equivalent to the empty **array**

And actually, FIrefox seems to be implemented according to Living Standard (tested on Firefox 77.0.1).
const socket = new WebSocket(url, '');

It cause SyntaxError: An invalid or illegal string was specified
const socket = new WebSocket(url, [])

And it works well.

To avoid this problem, it should be used as array even if it is only one string inside or empty. Living Standard describes: protocols is either a string or an array of strings. If it is a string, it is equivalent to an array consisting of just that string; So you are right, string is just confusing without further explanation.
Please assign, I'll rewrite it. Thanks

Awesome, thankyou @prosovskyf - you're assigned.

@chrisdavidmills please review

@prosovskyf I've simplified your addition down to just "If it is omitted, an empty array is used by default, i.e. []." I don't think we nreally need anything else here?


Revert the removal of comments

This is due to the Marshal and Unmarshal methods
also remove double quotes from strings.
This breaks empty strings turning it into nil values.
PTAL @lorenrh
Signed-off-by: Ulysses Souza<EMAIL_ADDRESS>

LGTM but then we need another way to remove comments :'(

I guess unmarshall+marshall way to drop comments also caused https://github.com/docker/compose-cli/issues/2036

I suggest removeYamlComments is kept but implementation just drop lines starting by #. This won't remove all comments, but at least the most obvious ones where users might have documented usages with some command line examples


Use double-colon for common targets (dist-clean, clean, env).

Using a double-colon allows Makefiles using this one to add steps to these
common targets, rather than overwrite them.

I never knew that....


[Bugfix][Frontend] Fix missing /metrics endpoint

Mount does not work on router, so I'm reverting the change in #5090 so that mount is performed on the application object. Since app is no longer global, I've moved the code into a function to be called after app is constructed.
To avoid similar issues in the future, I've added some tests to check that the endpoints remain accessible.
FIX #6461

@robertgshaw2-neuralmagic can you help update the test to check #4523? Since I haven't worked with prometheus metrics before, I'm worried that I might break something with this refactor.

@robertgshaw2-neuralmagic since this PR has been merged already, you can open a new PR if you need to update the tests to be more robust.

Can we get a new docker release with this fix?

# HELP python_gc_objects_collected_total Objects collected during gc
# TYPE python_gc_objects_collected_total counter
python_gc_objects_collected_total{generation="0"} 7313.0
python_gc_objects_collected_total{generation="1"} 5988.0
python_gc_objects_collected_total{generation="2"} 45.0
# HELP python_gc_objects_uncollectable_total Uncollectable objects found during GC
# TYPE python_gc_objects_uncollectable_total counter
python_gc_objects_uncollectable_total{generation="0"} 0.0
python_gc_objects_uncollectable_total{generation="1"} 0.0
python_gc_objects_uncollectable_total{generation="2"} 0.0
# HELP python_gc_collections_total Number of times this generation was collected
# TYPE python_gc_collections_total counter
python_gc_collections_total{generation="0"} 922.0
python_gc_collections_total{generation="1"} 83.0
python_gc_collections_total{generation="2"} 6.0
# HELP python_info Python platform information
# TYPE python_info gauge
python_info{implementation="CPython",major="3",minor="10",patchlevel="14",version="3.10.14"} 1.0
# HELP process_virtual_memory_bytes Virtual memory size in bytes.
# TYPE process_virtual_memory_bytes gauge
process_virtual_memory_bytes 1.3022793728e+010
# HELP process_resident_memory_bytes Resident memory size in bytes.
# TYPE process_resident_memory_bytes gauge
process_resident_memory_bytes 7.00747776e+08
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.72291887821e+09
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 18.240000000000002
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 22.0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 1.048576e+06

@robertgshaw2-neuralmagic is this due to the

I try use main branch to build docker image,The metrics information has become completely unavailable,no longer contains any statistical information related to the model.
# HELP python_gc_objects_collected_total Objects collected during gc
# TYPE python_gc_objects_collected_total counter
python_gc_objects_collected_total{generation="0"} 7313.0
python_gc_objects_collected_total{generation="1"} 5988.0
python_gc_objects_collected_total{generation="2"} 45.0
# HELP python_gc_objects_uncollectable_total Uncollectable objects found during GC
# TYPE python_gc_objects_uncollectable_total counter
python_gc_objects_uncollectable_total{generation="0"} 0.0
python_gc_objects_uncollectable_total{generation="1"} 0.0
python_gc_objects_uncollectable_total{generation="2"} 0.0
# HELP python_gc_collections_total Number of times this generation was collected
# TYPE python_gc_collections_total counter
python_gc_collections_total{generation="0"} 922.0
python_gc_collections_total{generation="1"} 83.0
python_gc_collections_total{generation="2"} 6.0
# HELP python_info Python platform information
# TYPE python_info gauge
python_info{implementation="CPython",major="3",minor="10",patchlevel="14",version="3.10.14"} 1.0
# HELP process_virtual_memory_bytes Virtual memory size in bytes.
# TYPE process_virtual_memory_bytes gauge
process_virtual_memory_bytes 1.3022793728e+010
# HELP process_resident_memory_bytes Resident memory size in bytes.
# TYPE process_resident_memory_bytes gauge
process_resident_memory_bytes 7.00747776e+08
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.72291887821e+09
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 18.240000000000002
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 22.0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 1.048576e+06

Can you revert to the commit from this PR to ensure that the problem isn't caused by subsequent commits? (Notably #6883)

The fix https://github.com/vllm-project/vllm/pull/6463/files for the former issue https://github.com/vllm-project/vllm/issues/6461 also contained tests to ensure metrics are there. Are they not being used @DarkLight1337 ?

The test only checks that the metrics endpoint exists. It doesn't check which metrics are being exposed.

The test only checks that the metrics endpoint exists. It doesn't check which metrics are being exposed.

That might be a cool thing to test then ;-)


Failed to parse valid yaml in npm_translate_lock.bzl

I’m having an issue with moving from my POC application to our actual application. I’m getting this error while parsing the pnpm lock file:
(15:38:58) ERROR: /Users/andrew/development/work/client/.../WORKSPACE.bazel:32:19: fetching npm_translate_lock rule //external:npm: Traceback (most recent call last):
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/npm_translate_lock.bzl", line 509, column 33, in _impl
                lockfile = _process_lockfile(rctx)
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/npm_translate_lock.bzl", line 164, column 37, in _process_lockfile
                lockfile = utils.parse_pnpm_lock(rctx.read(rctx.path(rctx.attr.pnpm_lock)))
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/utils.bzl", line 49, column 23, in _parse_pnpm_lock
                return _parse_yaml(lockfile_content)
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/yaml.bzl", line 42, column 31, in parse
                _handle_PARSE_NEXT(state, input, stack, starlark)
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/yaml.bzl", line 141, column 30, in _handle_PARSE_NEXT
                _set_result_value(starlark, stack, _parse_scalar(state["buffer"]))
        File "/Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/yaml.bzl", line 346, column 24, in _set_result_value
                curr_result.append(value)
Error: 'string' value has no field or method 'append'
(15:38:58) ERROR: no such package '@npm//': 'string' value has no field or method 'append'

To debug this, I added a print statement where it was dying:
        if type(curr_result) == "dict":
            curr_result[kns_states[-1]["key"]] = value
        else:
            print("curr_result", curr_result, "value", value)
            curr_result.append(value)

This printed this right before failing:
(15:42:39) DEBUG: /Users/andrew/.cache/bazel/f26303f99f5aa5dc2ecc7fa834780eb5/external/aspect_rules_js/npm/private/yaml.bzl:346:18: curr_result |- value npm i nyc

Looks like there is a bug in the yaml parser. Here is the entry in the pnpm-lock.yaml that looks to be causing the issue:
  /istanbul/0.4.5:
    resolution: {integrity: sha512-nMtdn4hvK0HjUlzr1DrKSUY8ychprt8dzHOgY2KXsIhHu5PuQQEOTM27gV9Xblyon7aUH/TSFIjRHEODF/FRPg==}
    deprecated: |-
      This module is no longer maintained, try this instead:
        npm i nyc
      Visit https://istanbul.js.org/integrations for other alternatives.
    hasBin: true
    dependencies:
      abbrev: 1.0.9
      async: 1.5.2
      escodegen: 1.8.1
      esprima: 2.7.3
      glob: 5.0.15
      handlebars: 4.7.7
      js-yaml: 3.14.1
      mkdirp: 0.5.5
      nopt: 3.0.6
      once: 1.4.0
      resolve: 1.1.7
      supports-color: 3.2.3
      which: 1.3.1
      wordwrap: 1.0.0
    dev: true

Using rules_js:
http_archive(
    name = "aspect_rules_js",
    sha256 = "80e168f9cd62f3640de429b70b34ff817d0d94ada2abaf2cffeef46e35434e1d",
    strip_prefix = "rules_js-1.0.0-rc.1",
    url = "https://github.com/aspect-build/rules_js/archive/refs/tags/v1.0.0-rc.1.tar.gz",
)

Yup that multi-line string under deprecated is probably not handled by our parser

Yup that multi-line string under deprecated is probably not handled by our parser

Yeah this is the first multiline string case we've come across in a lockfile. I'll have a look at improving the parser.

Fixed in https://github.com/aspect-build/rules_js/commit/62f52282e3a10a400121908f35c875323808c4c1.


Remove require() of CSS and move to a separate import into code

Moving the CSS into a separate import would allow it to load properly on all versions of React.
Using REMIX - https://remix.run/

The package now works with Remix!🎉
Note
Add "@codesweetly/react-youtube-playlist" to your remix.config.js file:
/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
  ignoredRouteFiles: ["**/.*"],
+ serverDependenciesToBundle: ["@codesweetly/react-youtube-playlist"],
  serverModuleFormat: "cjs",
  future: {
    v2_dev: true,
    v2_errorBoundary: true,
    v2_headers: true,
    v2_meta: true,
    v2_normalizeFormMethod: true,
    v2_routeConvention: true,
  },
};

By so doing, Remix will transpile and include the package in the server bundle.
You can read more about the configuration option in the official doc or @dan-cooke's issue comment.