Fix ddp tests + .test()

Hello @williamFalcon! Thanks for opening this PR.

In the file tests/base/develop_pipelines.py:

Line 41:17: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Do see the Hitchhiker's guide to code style

@tgaddair hey! any chance you can look at this?

Hey @williamFalcon, what was the issue?  I see this PR has been merged.  Is there still something that needs to be fixed on the Horovod side for this?

I don't think this is Horovod's fault. Something witht the paths changed. The tests are now simply skipped, which is not good :(
I will try to fix it in #2514 wish me luck :)

perfect! @awaelchli .
@tgaddair looks like it's on our end. All good! thanks for taking a look though


Some of our production hubs occasionally die with:
Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

    at new NodeError (node:internal/errors:399:5)
    at assert (node:internal/assert:14:11)
    at internalConnectMultiple (node:net:1107:3)
    at Timeout.internalConnectMultipleTimeout (node:net:1638:3)
    at listOnTimeout (node:internal/timers:575:11)
    at process.processTimers (node:internal/timers:514:7)

Noticed on 1.5.4, running in docker. Did not happen to non-public facing hubs, and did not see this on my personal hub which is not running in docker.
How can it be reproduced? (optional)
Unclear
Additional context (optional)
Add any other context about the problem here.

This hasn't happened since last Thursday. Will keep an eye on it, and close if it doesn't reoccur.

Hasn't happened again since. Closing for now, will re-open if it reoccurs.


How do i disable properties renaming on objects that are not defined in the code?

    <script src="assets/js/three.js"></script>
    <script src="assets/js/obfuscated.js"></script>

javascript-obfuscator version: 1.12.0
settings:
		{
			compact:true,
			rotateStringArray:true,
			shuffleStringArray:true,
			stringArrayEncoding:"rc4",
			identifierNamesGenerator: "mangled",
			transformObjectKeys: true,
			splitStrings:true,
			unicodeEscapeSequence:true,
			transformObjectKeys:true,
			renameProperties: true,
			selfDefending: true
		}

Sample of code that is getting obfuscated:
		var width = window.innerWidth;
		var height = window.innerHeight;
		var aspect = width/height;
		var D = 4

		this.camera = new THREE.OrthographicCamera(-D*aspect, D*aspect, D, -D, 1, 30);
		this.camera.zoom = 1024 / height
		this.camera.updateProjectionMatrix();
		this.camera.position.set(10,10,10)
		this.camera.lookAt(0,0,0)

I am getting an error when enabling renameProperties. I know I can use reservedNames but is there a better way to do this than tracing properties one by one?

No way. reservedNames only. If it won't help - don't use renameProperties option because as described in the README.md this option will break your code in most cases


Fix Accounts and add nodeAccounts to specifically use the node accounts

Overview
TL;DR
Before, we had to always concat user accounts (accounts from contractConfig.deployement.accounts) AFTER the node account, because web3 was not liking it otherwise.
This was fixed, proabbly by the new web3 version. So we can go back to the same thing we had in 3.1.
If a user wants to have BOTH user accounts and nodeAccount, he can add it manually.
Finally, I had to fix ENS contracts, as they would bug for missing gas, nonce errors, etc. with a user account. Anyway, those were necessary fixes we would have needed as some point.
Cool Spaceship Picture

@jrainville I believe we need documentation for this as I couldn't find any mention of nodeAccount in there.

Yup, of course. Will do today.


idea: include fitness as a dimension in bc metric

this should optimize over different fitnesses and novelties

added to bc3


Using Blazor with other client-side components

I am building a Blazor component and want to use another one inside it that is not a Blazor component (let's say it's written purely in JavaScript and cannot be easily ported to Blazor for now). In the Blazor component, it is represented as a standard "div" element.
The rendering of the parent Blazor component looks like this:

...
    <input class="info" />

 <-- used for initializing the child component

When the HTML of the parent Blazor component is fully rendered on the client side, I want to initialize the child component using JavaScript - this is possible by the JS logic of the component, but how do I know (from a client-side event) that a Blazor component is fully rendered or is re-rendered?
An alternative question is how to focus the <input /> element when the Blazor component is rendered. This can be done in an async way - let's say a button with "Focus" C# method is added to the page and clicking it calls a JS function that calls the native "focus" method, but how to do that in a more "synchronous" way.

I was using the wrong life-cycle method, switching to OnAfterRender and calling the JS init logic from there yields what is expected.


[ENH] Add new query parameter that accepts a list of node URLs

Closes #27

Changes proposed in this pull request:

Validation added that node URL list is a subset of nodes known to the current (federation) API instance

Checklist

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 25 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.2%) to 94.4%

Totals

Change from base Build<PHONE_NUMBER>:
3.2%

Covered Lines:
118

Relevant Lines:
125

💛  - Coveralls

:rocket: PR was released in v0.1.0 :rocket:


New Cisco and Validated Patterns team partnership blog

Deploying Multicloud GitOps with Cisco FlashStack Data Center and Portworx Enterprise
** Reviewed-by: Paniraja Koppa<EMAIL_ADDRESS>** Reviewed-by: Andrew Beekhof<EMAIL_ADDRESS>

CISCO Blog for MCG FlashStack and Portworx
Added header for blog
Removed alias from header

This is an automated message:
You can preview this docs PR at http://398.docs-pr.validatedpatterns.io
Note that they get generated every five minutes, so please wait a bit.

/lgtm

Thanks for the update.
/lgtm

/approve


[Bug] imageTransformOutputQuality does not seem to work

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
imageTransformOutputQuality does not seem to have any effect on the uploaded file size. According to @rikschennink's comment here https://github.com/pqina/filepond/issues/121#issuecomment-421908969, it should work. But I could not figure it out. Can anyone point me to the right direction?
Here is the codesandbox I created. https://codesandbox.io/s/react-file-upload-0e0qj?file=/src/components/filepond.js
Reproduction

come https://codesandbox.io/s/react-file-upload-0e0qj?file=/src/components/filepond.js
change value of imageTransformOutputQuality={50} to anything less than 100 and assert if the file size is smaller than original file size

Environment
- Device: Macbook Pro (2021)
- OS: MacOS Monterey
- Browser: Chrome

Here is an example of what I mean,  the original file size of this image is 1.4MB and it still shows 1.4MB in the preview, is that expected? However, I can see in the console log that the blob size is much smaller.

Thanks for the confirmation @rikschennink. I think it would be a good feature to show the resized file size in this context, will it be too difficult to do?

@qjnz at the moment that would indeed be tricky to do.


Significant slowdown when I query the index with mapping

Issue description
I run the same pyspark program on two indices with the almost same amount of data:
For vertex1 17.3Gi/34.3Gi 35.6M
For other_vertex_2 19.3Gi/38.6Gi 35.6M
The first index (vertex1) does not have a mapping applied. It takes 9 mins to read.
The second index (other_vertex_2) has a mapping (see attached file) and it takes 38 mins to read.
Steps to reproduce
q_all ="""
    {"query":
        {"match_all": {}}
    }
   """

def readVerticesFromES(q, index, scrollLimit = "-1"):
    es_read_conf_vertex = {
        "es.nodes" : "myserver-04",
        "es.port" : "9200",
        "es.resource" : index,
        "es.query" : q,
        "es.scroll.limit" : scrollLimit
    }

    es_rdd_vertex = sc.newAPIHadoopRDD(
        inputFormatClass="org.elasticsearch.hadoop.mr.EsInputFormat",
        keyClass="org.apache.hadoop.io.NullWritable",
        valueClass="org.elasticsearch.hadoop.mr.LinkedMapWritable",
        conf=es_read_conf_vertex)

    return es_rdd_vertex

if __name__ == '__main__':
    pass

    sparkConf = SparkConf().setAppName("ESTest")
    sc = SparkContext(conf=sparkConf)

    log4jLogger = sc._jvm.org.apache.log4j
    log4jLogger.LogManager.getRootLogger().setLevel(log4jLogger.Level.WARN)

    log = log4jLogger.LogManager.getLogger(__name__)

    vertRDDRead = readVerticesFromES(q_all, "other_vertex_2", "-1").cache()

    log.warn("vertRDDRead: %i" % vertRDDRead.count())

    sc.stop()

Version Info
OS:         :  CentOS release 6.9 (2.6.32-642.4.2.el6.x86_64)
JVM         :  1.8.0_131 (Oracle Corporation)
Hadoop/Spark:  hadoop-2.7.3/spark-2.1.1
ES-Hadoop   :  elasticsearch-hadoop-6.0.0.BUILD-20170608.170859-24.jar
ES          :  5.3.2 build_date: "2017-04-24T16:15:59.481Z"

Attached mapping
bug.json.txt

I'm confused about what you mean by:

The first index (vertex1) does not have a mapping applied.
If an index has data in it, it should have a mapping, whether it was set by the user or not... are the mappings drastically different?

I also noticed that you are not specifying a type on your elasticsearch resource. This can lead to issues with reading data since the connector has a bug with how it processes multiple mappings and indices without types provided. Could you include the DEBUG level logs from your jobs? I'm wondering if it's discovering the mapping incorrectly and thus is just skipping parsing fields altogether or if it's some other problem.
Please note that the multiple-mapping and typeless indexing bugs have a fix in the master branch right now: 093e9881665c496c4354c8d474ac551919355166

Hi James,
How should I setup my logging levels? Should I modify my pyspark code?
Thank you,
Serge

Setting logging levels is based on how you have spark deployed. The Spark documentation goes into detail on how to provide a log4j file: http://spark.apache.org/docs/latest/running-on-yarn.html#debugging-your-application

Which one do you mean:
log4j.rootCategory=INFO, console
log4j.logger.org.apache.spark.repl.Main=WARN
or any other?

You'll want to set the levels for the org.elasticsearch.hadoop packages to TRACE

Where are they specified?
I know only
log4j.logger.org.elasticsearch.hadoop.rest.commonshttp=TRACE
What are the other ones?

Log4J should inherit the log level for all classes under the given package name. I don't think you'll need to specify anything other than that.

Please, see attached.
I included mappings created using the commands like:
curl –XGET 'localhost:9200/vertex1/_mapping' > vertex1.map
and traces created with log4j.logger.org.elasticsearch.hadoop=TRACE
serge_logs.zip

Thanks for the logs! The big thing that I've noticed is that you are not specifying any type names with your indices: When ES-Hadoop tries to discover the mappings for your index, it is only reading ONE mapping from the list of types, which could be causing inconsistent time spent serializing. Here's an example:
17/07/18 14:12:56 DEBUG EsInputFormat: Discovered mapping {convert_long_to_double=[description=TEXT, graph_uuid=KEYWORD, ingest_time=DATE, label=KEYWORD, location=GEO_POINT, provenance_uuid=KEYWORD, provider=KEYWORD, relationships=[type=KEYWORD, uuid=KEYWORD], time=[start_time=DATE, start_timestamp=DATE, stop_time=DATE, stop_timestamp=DATE], title=TEXT, type=KEYWORD, uuid=KEYWORD]} for [other_vertex_2]

Here, when reading data from other_vertex_2 index, unless the data being read matches those field names, it won't be deserialized. Notice how the only type pulled is the convert_long_to_double type. Compare with reading the vertex1 index:
17/07/18 14:05:15 DEBUG EsInputFormat: Discovered mapping {reddit_subreddit=[data=[name=TEXT], domain=KEYWORD, id=KEYWORD, ingest_time=TEXT, type=KEYWORD]} for [vertex1]

Another item that pops out to me here is that the slice logic is giving you a very large number of input splits:
17/07/18 14:05:16 INFO EsInputFormat: Created [355] splits

But inspecting the scroll responses, many of them are coming up empty. Perhaps it makes sense to increase the es.input.max.docs.per.partition to be 1,000,000 instead of 100,000. To bring down the amount of tasks that are spinning up, doing nothing and then tearing down.
Finally, I would try retesting on one of the more recent snapshots. There is a fix in master to handle the above problem of only working with one type at a time: 093e9881665c496c4354c8d474ac551919355166. Maybe this will give a more consistent reading performance when serialization is involved.

James, thank you for the analysis!
I tried to increase es.input.max.docs.per.partition, but it worked worse, so I tried to decrease it to 10,000 and it worked better. The first index scanning time increased to 11 minutes, but the second time decreased to 19 minutes (twice faster). I notice no dead Spark tasks like I saw before.
I have two questions. What do you mean by "reading ONE mapping from the list of types"? Can you explain, please? From the log I see it reads the mapping. Another question is if you can point me out on the last snapshot. I cannot find it here: https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/elasticsearch-hadoop/
Cheers!
Serge

I also tried with type "dblp_author".
The vertex1/dblp_author took me 2.3 minutes, while other_vertex_2/dblp_author took me 3.3 minutes.

@SergeVil the index.max_slices_per_scroll setting is an index level property. I would avoid increasing it above 1024, as that may have negative side effects on your Elasticsearch cluster. Instead, I would tune your es.input.max.docs.per.partition value to keep the number of tasks below that number.
When I say "reading ONE mapping from the list of types" I mean that Elasticsearch indices can have multiple types in the 5.x versions and below. Normally when you execute a search (or in ES-Hadoop's case a scrolled search) you specify the type name to execute against. If you do not specify a type name to execute against, then the search is performed against ALL data for ALL types under the given index. In ES-Hadoop, when we get in a piece of JSON to deserialize, we need to know what kind of field type that data is. At the start of the job, we try and discover the mappings for the given index and type. There was a bug previously in the connector where we would only use the first mapping returned for an index if no type was specified. Any data that did not conform to that mapping is just thrown out. There's a new commit in master that addresses this problem for 6.0 and will most likely be backported to the 5.x line.
As for the snapshots not being found, I'll see if I can dig into why they haven't been updated in a while. I am guessing that it may have to do with the last alpha release.

I changed the query as:
{
"_source": ["type", "id", "ingest_time"],
"query": {"match_all": {}}
}
to avoid the nested data structures ("data" field contains some), but got same results.

Specifying the source field filtering in that way is no longer supported as of 5.x. We made some changes that make query parsing more strict. Instead of that, I would use the new property for specifying source filtering: es.read.source.filter (as described here)

@SergeVil To be clear: The issue with multiple types relates to #938 and #850 and was solved in 093e9881665c496c4354c8d474ac551919355166

@SergeVil To address your comment about the snapshot:

Another question is if you can point me out on the last snapshot. I cannot find it here: https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/elasticsearch-hadoop/

I'm not sure why it's not displaying the artifacts, but it is indeed there. If you include 6.0.0.BUILD-SNAPSHOT as the version in your build script it should be pulled down just fine.

James,
If I query comma separated multi-type, may it help to improve the performance? (https://www.elastic.co/guide/en/elasticsearch/guide/current/multi-index-multi-type.html)
I need to query several types at once.

@SergeVil As long as you are using the snapshot that contains 093e988 in it, then it's possible that you could see a speed up by stating the types directly. If you have many types but only want to read from a subset of those, it can help with performance. The connector would ignore any data that does not belong to the types you have explicitly specified. If you are reading all the types on an index, then it might not save much time.
To elaborate why that commit is important: When the connector reads data, it discovers the mapping for the types it is about to read. This allows the connector to convert the JSON data from Elasticsearch into consistent field types in Spark. If a field is not in the discovered mapping, then the connector discards it, and it shows up as null. There was a bug in previous versions of the connector that would only read one of the mappings from the list of types you were targeting. This caused the connector to skip deserializing data from any other types.
My guess here for why you might be seeing a performance discrepancy is that one read operation is getting data from a type that matches more of the discovered fields than the other read operation. If the connector correctly discovers all mappings for each type, then it should not ignore any of the fields that it is reading from Elasticsearch. In this case, you should see more consistent read speeds between the read operations. This may not be necessarily faster, but it is a more accurate reading of the data from Elasticsearch.

I'm going to go ahead and close this for now since the conversation has seemed to die down. If anything comes up we can easily re-open this and recommence the conversation.


DS-2411: Fix memory issues by storing just a reference to ingested objects' handles

See https://jira.duraspace.org/browse/DS-2411
This PR simply refactors the existing AIP Ingest code to store a String Handle reference to all successfully ingested objects, instead of the entire DSpaceObject.
The refactor passes all AIP Integration Tests. It also seems to speed up the ingest process by as much as 10 times (previously AIP Integration Tests took around 40 seconds to complete, and they now take about 4 seconds to run the same tests)

+1, nice refactor

+1

Merging this since it has +2 votes. While it is very last minute, this issue wasn't discovered until this morning (by @mwoodiupui who was analyzing memory issues that @helix84 was having with importing a large set of AIPs).  It passes all tests.


[Feature request] Access to socket option within UDPSocket and TCPSocket

It would be nice to be able to access to setsockopt() on the socket.
For example, this is necessary for broadcasting:
@socket = Celluloid::IO::UDPSocket.new
@socket.bind(host, port)
@socket.setsockopt(Socket::SOL_SOCKET, Socket::SO_BROADCAST, true)

This doesn't work and raise an exception : NoMethodError: undefined method `setsockopt'

This monkey-patch do the trick :
module Celluloid
    module IO
        class UDPSocket
           def_delegators :@socket, :setsockopt
        end
    end
end

@nagius Here is how it's done: https://github.com/celluloid/celluloid-io/blob/master/lib/celluloid/io/udp_socket.rb#L6 . Care to pull request?

Hi,
Back from holidays, I saw that it's now working with version 0.17.3 (6bdde40fd68401fcf2d3b0b34f3a6bcf43e299ec)
Thanks !


Add summary function

Here is a sketch of what and how the existing code would have to be modified
causens <- function(...) {
  ...
  result <- list(estimated_ate = estimated_ate)
  class(result) <- "causens"

  return(result)
}

The following works via S3 dispatch
summary.causens <- function(causens_object, ...) {
  cat("Summary of Causal Effect Analysis\n")
  cat("=================================\n")
  cat(sprintf("Estimated Average Treatment Effect (ATE): %f\n", causens_object$estimated_ate))

  invisible(object)
}

Probably good to also do this with plot


Update Household Income Map-all counties

Upload median household income data for all counties in US.

done


rust 1.62.1 version update

updated version where necessary
fmt changes
clippy changes

I'm able to reproduce the false interpreter failure locally:
❯ ./examples/false-interpreter/false ./examples/false-interpreter/examples/hello.false
Hello, World!
Segmentation fault (core dumped)

❯ valgrind --leak-check=full --track-origins=yes examples/false-interpreter/false examples/false-interpreter/examples/hello.false
==11792== Memcheck, a memory error detector
==11792== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==11792== Using Valgrind-3.19.0 and LibVEX; rerun with -h for copyright info
==11792== Command: examples/false-interpreter/false examples/false-interpreter/examples/hello.false
==11792==
Hello, World!
==11792==
==11792== HEAP SUMMARY:
==11792==     in use at exit: 55 bytes in 1 blocks
==11792==   total heap usage: 68 allocs, 67 frees, 15,238 bytes allocated
==11792==
==11792== 55 bytes in 1 blocks are definitely lost in loss record 1 of 1
==11792==    at 0x484679B: malloc (in /nix/store/73if83n79h4ml8rcb473ym47zmb4vi5x-valgrind-3.19.0/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==11792==    by 0x1206D2: ??? (in /home/anton/gitrepos/roc5/roc/examples/false-interpreter/false)
==11792==    by 0x1FFEFF21D7: ???
==11792==    by 0x692D65736C61662E: ???
==11792==    by 0x746572707265746D: ???
==11792==    by 0x65736C61662F7264: ???
==11792==    by 0x656C706D617864FF: ???
==11792==    by 0x2D65736C61662F72: ???
==11792==    by 0x6572707265746E68: ???
==11792==    by 0x6D6178652F726573: ???
==11792==    by 0x6C65682F73656C6F: ???
==11792==    by 0x65736C61662E6F6B: ???
==11792==
==11792== LEAK SUMMARY:
==11792==    definitely lost: 55 bytes in 1 blocks
==11792==    indirectly lost: 0 bytes in 0 blocks
==11792==      possibly lost: 0 bytes in 0 blocks
==11792==    still reachable: 0 bytes in 0 blocks
==11792==         suppressed: 0 bytes in 0 blocks
==11792==
==11792== For lists of detected and suppressed errors, rerun with: -s
==11792== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

I'm now investigating if the leak also happens outside of nix.

The leak also happens outside of nix:
==31761== Memcheck, a memory error detector
==31761== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==31761== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==31761== Command: examples/false-interpreter/false examples/false-interpreter/examples/hello.false
==31761==
Hello, World!
==31761==
==31761== HEAP SUMMARY:
==31761==     in use at exit: 55 bytes in 1 blocks
==31761==   total heap usage: 66 allocs, 65 frees, 15,054 bytes allocated
==31761==
==31761== 55 bytes in 1 blocks are definitely lost in loss record 1 of 1
==31761==    at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==31761==    by 0x120712: ??? (in /home/anton/gitrepos/roc/examples/false-interpreter/false)
==31761==    by 0x7: ???
==31761==    by 0x36: ???
==31761==    by 0x800000007: ???
==31761==    by 0x12B156: ??? (in /home/anton/gitrepos/roc/examples/false-interpreter/false)
==31761==    by 0x37E: ???
==31761==    by 0x40004BF: ??? (in /usr/lib/x86_64-linux-gnu/ld-2.31.so)
==31761==    by 0x48B5891: ??? (in /usr/lib/x86_64-linux-gnu/libc-2.31.so)
==31761==    by 0x42A5A954: ???
==31761==    by 0x10A96A4: ???
==31761==    by 0x8FEFFF8C3: ???
==31761==
==31761== LEAK SUMMARY:
==31761==    definitely lost: 55 bytes in 1 blocks
==31761==    indirectly lost: 0 bytes in 0 blocks
==31761==      possibly lost: 0 bytes in 0 blocks
==31761==    still reachable: 0 bytes in 0 blocks
==31761==         suppressed: 0 bytes in 0 blocks
==31761==
==31761== For lists of detected and suppressed errors, rerun with: -s
==31761== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

The leak is also on main but it does appear to be a recent addition, it does not occur on c42b8ad91be2f6291bc35915b99a1af433869239. I'll bisect now to narrow it down.

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
b18af7e1f3122401d991ecabe68c887e98ec2007
0606086eb6cde4844f54797ae4509b6f7807cf39
d8a8dff70de8580ea45c52eb351c21de7fcf7d12
cefbf3aa5128b4bca8169a8faa0b6a3ab9b23d58
confirmed bad 15ef517
confirmed good 68bb03e
Tagging @ayazhafiz

Yeah, the 4 full SHA commits listed earlier fail before I can properly test them with valgrind.

Do you know what change from one of the commits below could have caused a memory leak in the false interpreter @ayazhafiz?
b18af7e1f3122401d991ecabe68c887e98ec2007
0606086eb6cde4844f54797ae4509b6f7807cf39
d8a8dff70de8580ea45c52eb351c21de7fcf7d12
cefbf3aa5128b4bca8169a8faa0b6a3ab9b23d58

It's possibly cefbf3aa5128b4bca8169a8faa0b6a3ab9b23d58 or d8a8dff70de8580ea45c52eb351c21de7fcf7d12 - though it's not clear to me why those would leak, they are safe transformations.
Could you try reverting the merge commit of #3742 and see if the memory leak still reproduces?

This is my first time reverting a merge commit so I'm not sure I selected the right parent, but going through git revert 334bc7174fb91c8ca00d9612ba92dc653bce0aa3 -m 2 still has the same leak.

Let's keep it open github-actions bot :)


Enhance Default Exceptions to include Line Number.

When a Built-in Exception is raised, the raised Exception should be modified such that it includes the line number of the Template Line violating the exception.

This Example will trigger a TypeError.
import jinja2
environment = jinja2.Environment()
jinja_template = """
    {%- for name in names %}
        ("HELLO {{name}}!")
    {%- endfor %}
"""
template = environment.from_string(jinja_template)
data = template.render(names=None)
print(data)

Ideally, if we could modify the triggered TypeError Exception to add a lineno attribute so that we can capture the lineno to better track the line number that triggered the issue.
import jinja2
environment = jinja2.Environment()
jinja_template = """
    {%- for name in names %}
        ("HELLO {{name}}!")
    {%- endfor %}
"""
try:
    template = environment.from_string(jinja_template)
    data = template.render(names=None)
except Exception as e:
    print(f"Error on Line Number: {e.lineno}")
print(data)

Happy to review a PR


DynamoDBContext SaveAsync should persist empty lists

Description
Updates DynamoDBContext so that calls to SaveAsync will persist properties which are an empty list.
Motivation and Context
Fixes #1995
Testing
No automated coverage exists for this functionality, but can test a pre-release nuget?
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the README document
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

License

[x] I confirm that this pull request can be released under the Apache 2 license

Why has this change not been reviewed. It is difficult to use the dynamodb context without having the ability to clear a list.

Thanks @peterrsongg for sharing your comment again. I'm happy to close this PR. I've also created https://github.com/awsdocs/amazon-dynamodb-developer-guide/issues/300 so the doco might get updated so people land in the pit of success 🌮

Great, thanks for creating the issue in the docs repo. Going to close this PR now!


Misleading error message in Http Client

https://github.com/Effect-TS/effect/blob/027418edaa6aa6c0ae4861b95832827b45adace4/packages/platform/src/internal/http/client.ts#L264
IIUC this error message isn't connected to "non 2xx" status codes necessarily, simply that the filterStatus predicate call returned false. As an addendum, I have always found it very unhelpful that this error message doesn't include the actual status code, so I would propose that any message which indicates that a status code check failed should include what the status code actually was.

All response errors include the actual status code in the message, see: https://github.com/Effect-TS/effect/blob/027418edaa6aa6c0ae4861b95832827b45adace4/packages/platform/src/Http/ClientError.ts#L60
Will make the error message more generic however, as yes the predicate doesn't guarantee the status is in the 2xx range.


Data missing

Hi,
I downloaded a few trajectories (~30) and I'd like to report that for the following trajectories the folder applanix only contains the files dmi.csv and imu_raw.csv.

boreas-2021-02-09-12-55
boreas-2021-03-09-14-23
boreas-2021-04-22-15-00
boreas-2021-06-29-20-43
boreas-2021-09-08-21-00
boreas-2021-09-09-15-28
boreas-2021-10-05-15-35
boreas-2021-11-06-18-55

Best, Paulo.

This is to be expected, these sequences are a part of the test set:
https://github.com/utiasASRL/pyboreas/blob/eeb2b1bb302f5386eff7198858846f6d89675fda/pyboreas/data/splits.py#L42-L56

Nice! Good to know, I am using the dataset independent of the splits provided. Thank you!


Objects cast shadows on themselves

Objects should cast shadows coming from themselves, rather than having a shadow directly cover themselves, this prevents opaque from ever being illuminated.

I figured out a solution to this. Using unclosed & culling occlusion polygons this can be solved. All it needs is a smooth walling system.
 Set the line's points in the correct order according to a cull mode and the light can enter from one side but not exit. The result?


Excluding Sensors

Hello
I'm experiencing exactly the same issue as #54 Repeated No Response
I haven't run into this issue on any non-simplisafe device.  They all update properly.
I'd actually just like to have the ability to arm/disarm without exposing the sensors to HomeKit.  Is there a way to do that?

@jparchem it would be pretty straightforward to implement a toggle like you described but there is a high chance you would still have “No Response” issues even without the sensors enabled.
In my experience these issues are often related to networking and / or a homebridge setup itself. In other words probably are not just this plugin.
Here’s a somewhat detailed write-up that might help: https://reddit.com/r/homebridge/comments/f1gmjq/things_i_did_that_eventually_worked_to_make_my/

Thanks for the help and a great plug-in.  I ended up totally rebuilding my Rasp Pi Homebridge and the issue seems to be resolved.  Probably something out-of-date.


Make GET /probot template more flexible

As is, the behavior of the GET /probot HTML template is brittle and non-flexible:
// views/probot.js
const { name, version } = require(`${process.cwd()}/package`);

module.exports.template = `
  ...
`

// index.js
const { template } = require("./views/probot");
...

// `template` is rendered on `GET /probot`

It relies on the presence of a package module in process.cwd() at import time. This reliance seems unnecessary, and is also undocumented in the README.

This require statement is not compatible with webpack, which cannot handle a dynamic import like this.

Thoughts on updating this behavior to be configurable, or swapping the require for a safer file read?

Thank you for opening the issue!
We are currently working on making Probot work better with serverless environments out of the box, see https://github.com/probot/probot/issues/1286#issuecomment-739597798
The API will look something like this
const { createLamdaMiddleware, createProbot } = require('@probot/lambda')
const myApp = require('../app')

module.export = createLamdaMiddleware(myApp, { probot: createProbot() })

Question: would you expect the returned middleware to handle the GET /probot route at all? The question is if the middleware should only care about the webhook requests from GitHub, while you can define all other routes depending on what you need for your app. Would that resolve your problem?

Hi @gr2m! Thanks for the prompt response.

would you expect the returned middleware to handle the GET /probot route at all?

This route is not really important to me or my organization, so removing it wouldn't bother me in the slightest!
However, I think the biggest problem for us was the package's internal reliance on process.cwd() and the presence of a package.json in the deployed lambda, as this didn't play well with our deployment strategies (e.g. use of webpack, not including package.json).

okay thanks for sharing these insights.
So I think the solution will be to just remove the view by default, which is the case with the new serverless APIs.
Okay to close this issue?

@gr2m My notifications are messed up -- thanks for closing, and for addressing!

@gr2m FWIW -- it looks like this issue is actually still present in the latest version of this package.


Lookahead base optimizer tracking

Description
Brief Description of the PR:
Inner optimizer is not tracked for checkpoint
Fixes # (issue)
https://github.com/tensorflow/addons/issues/2094
Type of change

[x ] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[X ] I've properly formatted my code according to the guidelines

[X ] By running Black + Flake8
[ X] By running pre-commit hooks

[X] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
Tested in https://github.com/tensorflow/addons/pull/2102
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
It still need to pass save and load_model case.

@cyberzhg
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

/cc @reedwm Can you give us a feedback here. What we need to correctly support Keras save and load_model?
Need we to introduce something like your _DelegatingTrackableMixin in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/mixed_precision/experimental/loss_scale_optimizer.py#L58?
I see that in that case in Tensorflow your are just testing checkpoint but not save and load_model.
See user proposed tests in https://github.com/tensorflow/addons/pull/2102

The purpose of _DelegatingTrackableMixin is so the checkpoint format of the LossScaleOptimizer is the same as the checkpoint format of the inner optimizer. This allows you to, e.g., save a checkpoint of float32 model with an Adam optimizer, then load the checkpoint into the equivalent mixed precision model with a LossScaleOptimizer wrapping an Adam optimizer.
I'm not very familiar with the Lookahead optimizer, but it seems this use case doesn't apply: I don't think people would want to train partially with Lookahead and partially without, and this would be hard anyway since Lookahead has an extra set of "slow weights". If I'm correct, the current approach in this PR is fine.
Note we test a SavedModel with LossScaleOptimizer here.

@reedwm Thank you for the feedback. I am going to check your SaveModel test that I missed.

@reedwm I've tried to expand your test more in the style of the user proposed one and is passing on Tensorflow: https://github.com/tensorflow/tensorflow/pull/42749
In our Lookahead case at https://github.com/tensorflow/addons/pull/2102 instead is passing only with Checkpoint, with save_weight/load_weight cases or model.save and model.load_model but in h5.
So I think that we are still missing something for the model.save in tf format.
Any hint?

Hmm I'm not sure. What is the error?
Just a guess, but maybe the issue is because you return additional weights from the weights property:
https://github.com/tensorflow/addons/blob/ef8b0c9944b363fd2a78fc4d973f5a69486b8098/tensorflow_addons/optimizers/lookahead.py#L135-L137
AFAIK, no other optimizer does this. Maybe it's causing SavedModel to be confused.
Also last time I checked, SavedModel does not save slot variables, but checkpoints do. Make sure your SavedModel test is not relying on slot variables being restored.
Also note LossScaleOptimizer used to use an approach similar to this PR. https://github.com/tensorflow/tensorflow/commit/f9e99f4dca729f6c21155641103165b6dfac4730 changed it, but before that commit SavedModel still worked, so this approach should be possible.
/CC @k-w-w any ideas what the issue could be?

As you can see we have slot in https://github.com/tensorflow/addons/blob/ef8b0c9944b363fd2a78fc4d973f5a69486b8098/tensorflow_addons/optimizers/lookahead.py#L84

I still see this @allenlavoie commit in the current master:
https://github.com/tensorflow/tensorflow/commit/147e6777068ea569cbecbd270b8b07c648bae09b
Is it the motivation of this claim?
https://github.com/tensorflow/tensorflow/blame/master/tensorflow/python/keras/engine/training.py#L1986-L1987

I don't think that's related. IIRC it was because Checkpoint(model=tf.keras.Model()).save is not compatible with Model().save_weights (since Model is the root of the save in the second case).
What's the error/issue if you try to save with SavedModel?

The optimizer or the base/inner optimizer (or both) don't seems to be in the correct state after load_model in tf format.
Instead It seems ok in h5, checkpoint or  save_weights and load_weights.

Hrm. Does tf.saved_model.save / tf.saved_model.load have the same issue? There's a bit of extra logic in Model.save/load_model that could be causing issues here.

With tf.saved_model.save is the same.

@allenlavoie What is exactly the RestoredOptimizer object?

Cause I don't understand this case https://github.com/tensorflow/tensorflow/blame/master/tensorflow/python/keras/saving/saving_utils.py#L179

RestoredOptimizer is just a container for holding the restored slot variables.  It doesn't implement any of the other Optimizer methods.
Maybe this line is the issue: https://github.com/tensorflow/tensorflow/blob/be2870d0db035d12a207039922d76ae908b1101c/tensorflow/python/keras/optimizer_v2/optimizer_v2.py#L1391
When we tell SavedModel to load something back as a Python object, it takes a Python function to set attributes with. It's calling _set_hyper and passing the inner optimizer, and maybe that's not doing anything reasonable. You could try using a more complicated setter that e.g. typechecks for OptimizerV2s and uses setattr+_track_trackable or something.

I don't find so much entries of ResotredOptimizer object in the code. Where is it created?
What is the logic of:
      if isinstance(model.optimizer, optimizer_v2.RestoredOptimizer):
        raise NotImplementedError(
            'As of now, Optimizers loaded from SavedModel cannot be saved. '
            'If you\'re calling `model.save` or `tf.keras.models.save_model`,'
            ' please set the `include_optimizer` option to `False`. For '
            '`tf.saved_model.save`, delete the optimizer from the model.')

/cc @omalleyt12 What is the use case of this condition that you have introduced?

Ok nevermind I've seen the logic of RestoredOptimizer.

I've just extracted a very small code snippet removing Lookahead wrapping.
If you see it is working with the plain optimizer=SGD but not with optimizer=adam so I suppose it is something related to slots:
import os
import numpy as np
import tensorflow as tf
import tempfile

from tensorflow_addons.optimizers import Lookahead

def _init_model(optimizer, init_w):
    model = tf.keras.models.Sequential()
    dense = tf.keras.layers.Dense(input_shape=(3,), units=1)
    model.add(dense)
    dense.set_weights([init_w, np.zeros(1,)])
   print(dense.get_weights)
    model.compile(optimizer, loss="mse")
    return model

optimizer="adam"
np.random.seed(0)
x = np.random.standard_normal((10000, 3))
w = np.random.standard_normal((3, 1))
y = np.dot(x, w) + np.random.standard_normal((10000, 1)) * 1e-4

init_w = np.random.standard_normal((3, 1))

model = _init_model(optimizer, init_w)
model.fit(x, y, epochs=2, shuffle=False)
with tempfile.TemporaryDirectory() as ckpt_dir:
    new_model = _init_model(optimizer, init_w)
    new_model.fit(x, y, epochs=1, shuffle=False)
    ckpt_path = os.path.join(ckpt_dir)
    new_model.save(ckpt_path)
    new_model = _init_model(optimizer, init_w)
    new_model = tf.keras.models.load_model(ckpt_path)
    new_model.fit(x, y, epochs=1, shuffle=False)
    assert np.allclose(model.predict(x), new_model.predict(x))

@reedwm With Adam Is also failing the tensorflow test on tour test if the change is correct: https://github.com/tensorflow/tensorflow/pull/42749.

I commented in https://github.com/tensorflow/tensorflow/pull/42749#issuecomment-683964931. Since slot variables are not restored and Adam has slot variables, the sample code you gave is expected to fail.

Ok I commented also there.

I think that this could be merged as is.
Instead we are drafting a general warning on Tensorflow at https://github.com/tensorflow/tensorflow/pull/42846 for the SavedModel case.


Setting timeout in method config.

@karthikravis

Just an initial review; still to do:

get max_stream_duration from HttpConnectionManager
test


mypy check fails in hpi config check: FileNotFoundError

Does hpi config check work in a virtual environment? I get an error when running hpi config check or checking a module, e.g. hpi doctor my.hypothesis:
» hpi config check
✅ import order: ['/Users/jussi/me/hpi/my']
✅ config file : /Users/jussi/me/hpi.config/my/config/__init__.py
✅ syntax check: /Users/jussi/me/hpi/bin/python3.9 -m compileall /Users/jhu/projects/mememo/hpi.config/my/config/__init__.py
❌ mypy check: failed
   Traceback (most recent call last):
     File<EMAIL_ADDRESS>line 197, in _run_module_as_main
...
...
   FileNotFoundError: [Errno 2] No such file or directory: '.mypy_cache/3.9/my/config/__init__.data.json'

I think this is not a mypy error because running mypy directly works:
» MYPYPATH=../hpi.config mypy --namespace-packages -p my.config
Success: no issues found in 1 source file

I suspect the issue is related to how mypy is ran using subprocess.run():
https://github.com/karlicoss/HPI/blob/master/my/core/__main__.py#L47
Maybe this method changes the current working directory unlike running mypy directly on command line?
If I patch my.core.__main__ to print the directory just before the failing run(), it points to a temp directory (I'm on a MacOS, using venv for HPI):
    print("My path", os.path.abspath(".mypy_cache"))
    # My path /private/var/folders/j0/bc42cwsn7b59s623gyrtywsw0000gn/T/hpi_temp_dir/.mypy_cache

The mentioned .../hpi_temp_dir/.mypy_cache/... exists but the erroring file __init__.data.json is not found there. Instead, such file is in the console's current working dir, under the .mypy_cache/... path.
Does hpi config check work in a virtual environment?
This issue doesn't prevent usage. Also, feel free to close this issue if you think this doesn't belong here (but maybe on https://github.com/python/mypy/issues). However, I like the HPI's idea of being able to check the configuration programmatically. It's a cool feature especially for new users trying to set up the (cool) framework.

hmm -- looks like there is code to check if we can use the current python env, so I think it was meant to work....
This may be because of the change to a temporary directory, you can see the reasoning for that here, It has been there since before click was used for it -- reasoning being to prevent accidental imports from relative files which developing since how hpi handles imports is already confusing enough
Does this work if you remove this block of code and replace it with a pass?
Also, you've probably already tried this, but does this work if you invoke with python3 -m my.core instead of hpi? Though, the virtualenv should probably be overwriting the bin directory anyways, may be a moot point.

Excellent pointers, thank you. I was going to try the code removal you referred to, but... now that I tried the erroring command in the same virtual env, it works. hpi config check-> success!
I haven't changed much in my venv or the config. I have added a custom HPI module and played with automated scripts with hpi query, and added a class core: block in the HPI config file. So... I guess the issue must have been some caching problem in mypy (the other hard thing in CS). Closing the issue.


Doubledown: In round 2, doubledown phase sometimes skips all players except for the first player if they say no

Need to reproduce. Basically Johnny had the chance to say yes or no and selected no. but it didn't get a chance for anyone else to go.

Was just testing this, unable to repro this exact issue, but I had a player asked twice in one round whether to double-down.


Issue# 2809: Throw TypeError immediately when getter/setter is not callable.

@atulkatti,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@Microsoft/chakra-developers


Setting Collation when Creating Migration Files Using Prisma

Overview
Method to set Collation when creating migration files using Prisma
Details
Migration files made with Prisma led to production issues. A year back, I migrated from TypeORM to Prisma. I made new tables using Prisma for additional features which worked fine locally. However, running prisma migrate deploy in production resulted in an error related to foreign key constraints.
Here's the error from the _prisma_migrations table:
A migration failed to apply. New migrations cannot be applied before the error is recovered from. Read more about how to resolve migration issues in a production database: https://pris.ly/d/migrate-resolve

Migration name:<PHONE_NUMBER>2944_init

Database error code: 3780

Database error:
Referencing column 'user_id' and referenced column 'id' in foreign key constraint 'user_detail_user_id_fk' are incompatible.

Please check the query number 2 from the migration file.

   0: sql_migration_connector::apply_migration::apply_script
           with migration_name="20230614082944_init"
             at migration-engine/connectors/sql-migration-connector/src/apply_migration.rs:105
   1: migration_core::commands::apply_migrations::Applying migration
           with migration_name="20230614082944_init"
             at migration-engine/core/src/commands/apply_migrations.rs:91
   2: migration_core::state::ApplyMigrations
             at migration-engine/core/src/state.rs:200

Investigating the DB, I noticed the existing tables used utf8mb4_0900_ai_ci collation, whereas Prisma's generated query set utf8mb4_unicode_ci as the default.
Example query by Prisma:
-- CreateTable
CREATE TABLE `user_details` (
    ...
) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;
...

Is utf8mb4_unicode_ci Prisma's default charset collation? If yes, why?
I modified the generated migration file to fix this issue, but it doesn't seem like the best solution. Also, I couldn't find any information regarding collation settings in the official documentation.
Any advice for future resolution?

Hey @Sangun-Kang, that is indeed the default collation Prisma uses when generating migration files - and the only way to influence that is to modify the migration files after the fact. Sorry.
We have a bunch of issue about changing that here: https://github.com/prisma/prisma/issues?q=is%3Aopen+label%3A"topic%3A+collation"+sort%3Areactions-%2B1-desc Please add a 👍 to the ones that are relevant to you. Thank you.

Thanks for your comment!!!


clarify error log for number of allowed models in a Python file

resolves #6245

Description
simple fix to update the logging when less than or more than one python models are found in a given python file
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Could you merge main into your branch? I think the test error is something that was updated in main.

Could you merge main into your branch? I think the test error is something that was updated in main.

sure thing! just did now, i think it will require another approval for the CI to run. thanks for taking a look @gshank

There's a strange error in the CI jobs now; I'm looking into it.


Enable Summarization in Ingestion Client

Purpose
Enable Summarization in Ingestion Client
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

we got a GH action to automatically build the binaries if a new version of the ingestion client was pushed (https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/master/.github/workflows/ingestion_client.yaml).
Please update the version in both templates
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/f1b5a0eae885104b74ed8d8de98e8570aab3ab8d/samples/ingestion/ingestion-client/Setup/ArmTemplateBatch.json#L230
https://github.com/Azure-Samples/cognitive-services-speech-sdk/blob/f1b5a0eae885104b74ed8d8de98e8570aab3ab8d/samples/ingestion/ingestion-client/Setup/ArmTemplateRealtime.json#L126
before merging your PR!

/AzurePipelines run

/AzurePipelines run


New version: CloudFoundry.CLI.v7 version 7.7.8

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Closes #163401
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335141
2024-07-17 07:31:35.971 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA~1\AppData\Local\Temp\WinGet\CloudFoundry.CLI.v<IP_ADDRESS>\extracted\cf.exe
2024-07-17 07:31:32.222 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA~1\AppData\Local\Temp\WinGet\CloudFoundry.CLI.v<IP_ADDRESS>\extracted\cf.exe

Automated error analysis suggests -1978335141 may mean Unable to locate nested installer. Does the RelativeFilePath have the previous version number in it?
(Automated response - build 886.)

I had added the wrong URL. Should have added the binary URL instead of the installer URL. I have fixed this in this PR and the other related PRs of this package

https://github.com/microsoft/winget-pkgs/issues/142854


Set up user monitor before GitHub access

This is changed around so that a user is set-up in the user monitor before GitHub, this is to prevent people (like myself) who add someone to GitHub and not realise 2nd line are about to be nagged.

Thanks @kevindew ⭐


It doesn't work on iOS Safari

Hello,
is jquery.dirty supposed to work on iOS Safari? In my tests, it doesn't work (the warning never appears).
The beforeunload event should work on iOS, though.
Thanks
E.

On MacOS Safari, as I wrote in another post, it seems it works but it doesn't if I leave the page to visit an "external" page (a page that does not belong to the domain of the the current form page).
I also noticed that after having warned you once, Safari stops warning you ... so if I enter a form, modify something and try to leave the form, I get the warning. If later I do the same on the same form or another form belonging to the same application (maybe it's the domain that counts) I don't get the warning.


Documentation: Update list of roles and their descriptions

https://opencolorio.readthedocs.io/en/latest/guides/authoring/config_syntax.html?highlight=roles#roles
https://opencolorio.readthedocs.io/en/latest/configurations/aces_1.0.3.html#id4

This might overlap with the ACES documentation but I would love to see as well an explanation for each role, as why a color space or an other has been chosen.  For example, "Output - sRGB" for the color_picking role. I know lots of artists have scratched their heads on this one. ;-)

Perhaps it's worth documenting (and adding Enums) for rendering, compositing_linear, aces_interchange, and cie_xyz_d65_interchange?
Regarding the reference role:
Although it's quite clear in the docs now, historically, there's been ambiguity regarding what "reference" means. When I first encountered it, the role was defined in the docs as "Colorspace used for reference imagery (e.g sRGB images from the internet)". This ambiguity led the ACES-1+ OCIO authors to select a data colorspace for the reference role "as a pass on making a decision" (see https://community.acescentral.com/t/why-utility-raw-as-reference-for-aces1-0-3-and-not-aces2065-1/1378/11); consequently, I quite often (perhaps usually) see TD-authored / edited configs pointing reference to a data space as well.
Three questions:

Is any of this worth bringing up in the documentation? I feel like DCC developers who had previously implemented OCIO, or old-school users of OCIO might find the information worthwhile; but everyone else would find it unnecessary, pedantic, and/or confusing.
Is anyone aware of DCC applications or tools that require or expect reference to point to a "reference photography" color space?
Is anyone aware of DCC applications or tools that behave differently when the reference role points to a data colorspace instead of the reference [scene-linear "connector"] color space?

Anecdotally, I've been told that switching the reference role from a data color space to the reference color space affects the behavior of the color picker in Mari (2?), but I have not confirmed this for myself.


HTML

HTML
User story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, and Javascript with associated notes listed

Added html to file


No valid key blocks found. ed25519 public key

Hi,
I built End-to-End extension on OS X 10.11.4 with Chrome with the needed tools.
I'm using it on Chrome 50.0.2661.94 (64-bit).
mypubkey.txt
But I got the issue: No valid key blocks found.

It seems to be a ed25519 public key. I followed the first part of this tutorial.
What should I do? Is this a real issue?
JsUnit Tests:
Unit Test of e2e.otr.pubkey/ [FAILED]
<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/pubkey_test.html
3 of 3 tests run in 8ms.
2 passed, 1 failed.
3 ms/test. 44 files loaded.
ERROR in testConstructor
Function passed to assertThrows caught a JsUnitException (usually from an assert or call to fail()). If this is expected, use assertThrowsJsUnitException instead.
> (unknown)
> Object.goog.testing.asserts.raiseException at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:1251:11
> assertThrows at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:285:28
> testConstructor at http://<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/pubkey_test.html:60:3
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:851:21
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> anonymous at .<anonymous> (http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:757:10)
> new goog.Promise at http://<IP_ADDRESS>:8000/javascript/closure/promise/promise.js:164:16
> goog.testing.TestCase.runTestsReturningPromise at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:755:10
> goog.testing.TestRunner.execute at http://<IP_ADDRESS>:8000/javascript/closure/testing/testrunner.js:262:19

Run individually »

Unit Test of e2e.otr.session/ [FAILED]
<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/session_test.html
3 of 3 tests run in 10ms.
1 passed, 2 failed.
3 ms/test. 91 files loaded.
ERROR in testConstructor
Function passed to assertThrows caught a JsUnitException (usually from an assert or call to fail()). If this is expected, use assertThrowsJsUnitException instead.
> (unknown)
> Object.goog.testing.asserts.raiseException at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:1251:11
> assertThrows at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:285:28
> testConstructor at http://<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/session_test.html:42:3
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:851:21
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> anonymous at .<anonymous> (http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:757:10)
> new goog.Promise at http://<IP_ADDRESS>:8000/javascript/closure/promise/promise.js:164:16
> goog.testing.TestCase.runTestsReturningPromise at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:755:10
> goog.testing.TestRunner.execute at http://<IP_ADDRESS>:8000/javascript/closure/testing/testrunner.js:262:19

ERROR in testUpdateAuthState
Function passed to assertThrows caught a JsUnitException (usually from an assert or call to fail()). If this is expected, use assertThrowsJsUnitException instead.
> (unknown)
> Object.goog.testing.asserts.raiseException at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:1251:11
> assertThrows at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:285:28
> testUpdateAuthState at http://<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/session_test.html:50:3
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:851:21
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> goog.testing.TestCase.finishTestInvocation_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:949:10
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeTearDown_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:816:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> goog.testing.TestCase.finishTestInvocation_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:949:10
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeTearDown_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:816:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:884:15
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> anonymous at .<anonymous> (http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:757:10)
> new goog.Promise at http://<IP_ADDRESS>:8000/javascript/closure/promise/promise.js:164:16
> goog.testing.TestCase.runTestsReturningPromise at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:755:10
> goog.testing.TestRunner.execute at http://<IP_ADDRESS>:8000/javascript/closure/testing/testrunner.js:262:19

Run individually »

Unit Test of e2e.otr.message.encoded/ [FAILED]
<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/message/encoded_test.html
4 of 4 tests run in 12ms.
2 passed, 2 failed.
3 ms/test. 47 files loaded.
ERROR in testConstructor
Function passed to assertThrows caught a JsUnitException (usually from an assert or call to fail()). If this is expected, use assertThrowsJsUnitException instead.
> (unknown)
> Object.goog.testing.asserts.raiseException at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:1251:11
> assertThrows at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:285:28
> testConstructor at http://<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/message/encoded_test.html:78:3
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:851:21
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> anonymous at .<anonymous> (http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:757:10)
> new goog.Promise at http://<IP_ADDRESS>:8000/javascript/closure/promise/promise.js:164:16
> goog.testing.TestCase.runTestsReturningPromise at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:755:10
> goog.testing.TestRunner.execute at http://<IP_ADDRESS>:8000/javascript/closure/testing/testrunner.js:262:19

ERROR in testPrepareSend
Function passed to assertThrows caught a JsUnitException (usually from an assert or call to fail()). If this is expected, use assertThrowsJsUnitException instead.
> (unknown)
> Object.goog.testing.asserts.raiseException at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:1251:11
> assertThrows at http://<IP_ADDRESS>:8000/javascript/closure/testing/asserts.js:285:28
> testPrepareSend at http://<IP_ADDRESS>:8000/src/javascript/crypto/e2e/otr/message/encoded_test.html:105:3
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:851:21
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> goog.testing.TestCase.finishTestInvocation_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:949:10
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeTearDown_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:816:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> goog.testing.TestCase.finishTestInvocation_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:949:10
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.safeTearDown_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:816:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:884:15
> goog.testing.TestCase.safeRunTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:801:8
> goog.testing.TestCase.invokeTestFunction_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:877:19
> goog.testing.TestCase.runNextTest_ at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:791:8
> anonymous at .<anonymous> (http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:757:10)
> new goog.Promise at http://<IP_ADDRESS>:8000/javascript/closure/promise/promise.js:164:16
> goog.testing.TestCase.runTestsReturningPromise at http://<IP_ADDRESS>:8000/javascript/closure/testing/testcase.js:755:10
> goog.testing.TestRunner.execute at http://<IP_ADDRESS>:8000/javascript/closure/testing/testrunner.js:262:19

Run individually »

I'm using jdk-8u92-macosx-x64.dmg. Should I use a previous JDK version?

hi
we havent finished implementing support for ed25519 yet. we landed some patches last week but it's not all there yet.

@sirdarckcat Ok thanks!

lets track this in https://github.com/google/end-to-end/issues/319


[Question] Browser Cookies

Does the SWB application save any cookies before or after user login?
Our legal team is considering wether we need to add a cookie notice or not. I did not see any cookies set in chrome devtools when I loaded SWB, but I wanted to double check.

Release Version installed: 5.0.0

Hi @srpiatt!
Thank you for the question! When we look in the browser, we don't see a value in the Cookies field, but there are values stored in Local Storage.  So, SWB does not have a cookie present but we still store data in the browser.
The code for login calls a method to saveIdToken, which saves the id token in local storage. Please let us know if you need any more info!
Thanks,
Mar


CI: Close PRs not against master

For https://github.com/commaai/openpilot/issues/29845

Got an example on your repo of it closing a PR?

https://github.com/maxime-desroches/openpilot/pull/17

Not automatically closed from a fork to master -> https://github.com/maxime-desroches/openpilot/pull/18
Not automatically closed from not a fork to not master -> https://github.com/maxime-desroches/openpilot/pull/19

Congrats on claiming the first bounty!


[WIP] Package restructuring

Addresses issue #135

I am not a fan of the loss of the pkg directory. The issue was saying just the cloudevents dir because it was redundent.

@n3wscott Could you clarify what the desired end state is here?

I would prefer https://github.com/cloudevents/sdk-go/pkg/cloudevents/* to be moved to https://github.com/cloudevents/sdk-go/pkg/*
I work in a lot of projects that use the pkg dir structure, and it works out really nice for libs like this. Flattening all that is in pkg into the root feels too messy because now you don't have a good place to put the cmd, hack, test and docs dirs.

@n3wscott In Go libraries, the pkg folder is intended for things that you expect others to actually import and use directly. In the case of the CloudEvents SDK, I don't think there's any intention to have developers actually use anything directly from, say, pkg/client or pkg/context. The pkg folder is still in place in this PR only because it's a WIP. The alias.go pattern is not one I've encountered and, I believe, runs counter to emergent best practices.
My intention is to flatten everything but the examples into the root folder, as is common in many widely used Go libraries, e.g.:
https://github.com/spf13/cobra
https://github.com/spf13/viper
https://github.com/sirupsen/logrus
https://github.com/steinbacher/goose
I don't mean to be brash. I'm happy to leave things the way that they are. But I do believe that the approach that you suggested is not idiomatic.

I'm going to close this, although I do think that the current project organization is not in line with Go best practices.


errors "create claimable balance/adds 7 zeros to amount

What version are you using? V2

What did you do? create claimable balance

What did you expect to see? always worked for V1, amounts was correct, if 1 then 1 if 10 then 10
What did you see instead? amount is plus 7 zeros in string, if 1 then 10000000, if 10 then 100000000...Do not know if RPC URL is correct, errors, didn't need to add RPC URL in V1, always work correctly, can not create claimable balances anymore...

I can not complete operation after submitting, errors ,errors...As said, the RPC URL is a new wild card....

@tdixon1000 Are you using this page  for claimable balances or transaction submission page?

This page? this page is where I'm posting of the new V2 is not working like V1 did or anymore....

obviously I'm at stellar lab/build transactions V2

@tdixon1000 You want to see the entered amount in the XDR instead of just the raw amount. Do I understand your request correctly?
Here's a PR that will allow you to submit transactions using Horizon (no RPC URL required). It should be merged this week.
Lab v2

Lab v1

So you're saying XDR should show plus 7 zeros?

if that is not an issue then great, but I still get error to complete anything as this URL needed for mainnet is a stumper and can only guess that is what is stopping my transaction for a claimable balance

still failed,   must be the network issue/URL
Transaction failed
Error result:
{
"message":
"Network Error",
"name":
"AxiosError",
"code":
"ERR_NETWORK",
"config":
{
15 items
"transitional":
{
3 items
"silentJSONParsing":
true,
"forcedJSONParsing":
true,
"clarifyTimeoutError":
false,
},
"adapter":
[
3 items
"xhr",
"http",
"fetch",

Re: the amount. It is correct with all those extra zeroes in XDR. We'll update it to show the actual value like in Lab v1 soon. The amount submitted is correct. Here's an example of a claimable balance I created with the amount 0.0123.
Claimable balance details

Transaction XDR

Yes, that would be helpful to be 1 to 1 on the zeros, anyone would look at that and say, huh?    As I did and thought it was a buggy thing causing issues....
I'll figure out the Horizon thing and give it a try...
On another note....I just remembered, I've always had done my work off my iPhone, I noticed I couldn't anymore with V2 as the screen interface was all unmanageable to make anything happen...what is up with that?

Ok, the Horizon switch worked, thanks !

On another note....I just remembered, I've always had done my work off my iPhone, I noticed I couldn't anymore with V2 as the screen interface was all unmanageable to make anything happen...what is up with that?

Yes, we'll make it response so that it can be used on mobile. Here's an issue for that: https://github.com/stellar/laboratory/issues/906.
Thanks for your feedback, @tdixon1000 ! Please let us know if you notice anything else.

perfect, thanks again


For p_reveal_content, gas_fee_blob_acceptable and gas_fee_l1_acceptable are hardcoded as true

similar to commit_bond, this was an adaptation for limited censorship experiment.
Should instead again be adaptable, ideally through params for sweep possibility.
All gas_fee_blob_acceptable and gas_fee_l1_acceptable should not be hardcoded, but instead draw from a param (which if not useful, we could just set extremely high)

Variables removed per #282


Uniaxial compression benchmark (#188)

New aux functions for benchmarks
Included Uniaxial compression example
Renamed bench_example to avoid ctrl + P misunderstandings when opening an example
Nodes added to the benchmark col

Codecov Report

Merging #191 (45850c0) into main (e336cb6) will decrease coverage by 0.15%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   89.88%   89.74%   -0.15%
==========================================
  Files          40       39       -1
  Lines        1058     1043      -15
==========================================
- Hits          951      936      -15
  Misses        107      107

see 13 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


'Link Shader failed' with Phaser 3.70.0 with a very small % of users

Version

Phaser Version: 3.70.0
Operating system: Windows, Linux, iOS
Browser: Chrome

Description
We've had an issue with a very small % of users that are getting the error 'Link Shader failed' on Chrome 119 and 120 on startup, Windows and Linux with Phaser 3.70.0. We can't repro locally but our stack trace comes back to compiling the PreFXPipeline shaders
    function FXPipeline (config)
    {
        //  This order is fixed to match with the FX_CONST. Do not adjust.
        config.shaders = [
            Utils.setGlowQuality(Shaders.FXGlowFrag, config.game),
            Shaders.FXShadowFrag,
            Shaders.FXPixelateFrag,
            Shaders.FXVignetteFrag,
            Shaders.FXShineFrag,
            Shaders.FXBlurLowFrag,
            Shaders.FXBlurMedFrag,
            Shaders.FXBlurHighFrag,
            Shaders.FXGradientFrag,
            Shaders.FXBloomFrag,
            Shaders.ColorMatrixFrag,
            Shaders.FXCircleFrag,
            Shaders.FXBarrelFrag,
            Shaders.FXDisplacementFrag,
            Shaders.FXWipeFrag,
            Shaders.FXBokehFrag
        ];

        PreFXPipeline.call(this, config); // This line

We are still investigating and working around this by disabling the both the pre and post pipelines via the config. Unfortunately, we can't narrow down which one of these is causing the issue.
All users reporting the issue are on different hardware/GPUs/OSs as well.
Example Test Code
We can't reproduce locally to give an example but the callstack is part of the startup of Phaser.

If you could find out what kind of device this happens on, that would be ideal - then we can check it on BrowserStack and debug from there. Feel free to comment on this issue if you can get that information, and we'll re-open it.

Hello @photonstorm and the Phaser team,
I've encountered a 'Link Shader failed' error with Phaser version 3.80.1, which is consistently happening upon startup within an Electron application (version 29.1.5). This issue impacts the Electron app on Ubuntu 22.04.4 LTS, running on a Framework Laptop. The specifications of my development environment include:
CPU: 12th Gen Intel(R) Core(TM) i5-1240P
Graphics: Intel Alder Lake-P Integrated Graphics Controller
RAM: 40GiB System Memory
The error message I'm receiving is as follows:
phaser.js:192255 Uncaught Error: Link Shader failed:
...
The Chromium version used by Electron 29.1.5 is version 122, and the integrated Node.js version is 18.19, according to Electron's release documentation.
Despite my efforts to find a workaround or solution, the error persists, blocking progress on my project. I am open to providing further details, logs, or engaging in tests that might aid in diagnosing and resolving this issue.
Your assistance and any suggestions you might have are greatly appreciated.
Thank you for your support.

Hello again @photonstorm and the Phaser community,
I wanted to provide an update on the 'Link Shader failed' error I previously reported when using Phaser v3.80.1 with Electron. After further investigation, I discovered the root cause was due to an oversight in my Electron packaging script for Ubuntu. The Electron version specified in the "package-ubuntu" script within my package.json was not updated to match the Electron version (29.1.5) I was actually using. The script erroneously specified version 25.0.1:
Incorrect version:
"package-ubuntu": "npm run build:prod && electron-packager . --overwrite --platform=linux --arch=x64 --electron-version=25.0.1 --prune=true --out=out --icon=icons/icons/png/256x256.png",
After updating the Electron version in the script to the correct version (29.1.5), the error no longer occurs:
Corrected version:
"package-ubuntu": "npm run build:prod && electron-packager . --overwrite --platform=linux --arch=x64 --electron-version=29.1.5 --prune=true --out=out --icon=icons/icons/png/256x256.png",
This adjustment resolved the 'Link Shader failed' error, and my application now starts up without any issues. I appreciate the community's willingness to help and wanted to share this resolution in case it may assist others encountering similar issues.
Thank you for your support and for the incredible work on Phaser!


Fixed "debug=true" and "vs_runtime="MTd" builds

This allows successful compilation in debug modes (for windows targets)

You don't need to reopen a new pr every time, just keep committing + pushing to an existing branch.


Crashing in iOS real device [SQLite]

I used SetConfig(SQLiteConfig.Serialized) to avoid lock in DB calls.
It worked in simulator but crashing on real device.

This is not a bug reporting list. If this is related to a specific document or sample, please provide a link to the page or the source code you're referring to, thanks.


deterministic sorting of openapi yaml?

Updating openapi maven plugin to gain access to sorting in response to repeated issues noted on Slack with yq
Related reading at https://github.com/swagger-api/swagger-core/pull/3740 but some reports of issues at https://github.com/openapi-tools/swagger-maven-plugin/issues/47
So for reviewers, check this out, run the build and see if building the yaml is deterministic.
For discussion, this will be a big one time pain to adjust to the new sort order
For example
$ mvn clean install
...
$ git diff dockstore-webservice/src/main/resources/openapi3/openapi.yaml
$ git diff dockstore-webservice/src/main/resources/openapi3/openapi.yaml | wc -l
0

Note to self: might want to follow-up with https://github.com/swagger-api/swagger-core/wiki/Swagger-2.X---Getting-started#note-jakarta-namespace-support-since-version-217

[ERROR] PGP key https://hkps.pool.sks-keyservers.net/pks/lookup?op=vindex&fingerprint=on&search=0x3E61D8C230332482009D7F0EDB901B24CAD38BC4 not found on keyserver for artifact io.swagger.core.v3:swagger-annotations:jar:2.1.7

sigh


New Game Jam Landing Page

Describe your design or art need by answering the questions below:
What are the requirements for the project?

Design for the game jam landing page
Before the game jam starts, the page will have:

Theme (or a placeholder theme before the actual theme is revealed)
Rules
Countdown to the start time

During the jam, the page will have:

Jam theme
Rules
Submission button
Countdown to the end time
Gallery of all current submissions (link to game + thumbnail + author name)

After the jam, the page will have:

First, second, and third place winners
Gallery of honorable mentions (link to game + thumbnail + author + game description)
Gallery of all games

Should be a template that we can easily apply to future game jams

Is there a deadline or date this is needed by?
No specific deadline, we wrapped up a game jam in December and we host one every 3-4 months. The next one will probably be March/April, so we'd need a design before that.
Please share any existing references, screenshots, links, etc. here that will help us better understand your requirements
Landing page: https://arcade.makecode.com/gamejam/time
Forum announcement: https://forum.makecode.com/t/announcement-makecode-arcade-may-game-jam-theme/7732
itch.io submission page: https://itch.io/jam/makecode-arcade-time-jam
Optional Additional Questions:
Who are the stakeholders that need to sign off on this design? Tag them here.
@shakao @riknoll @ElizabethRiffle
What audience is this request for?
In general our game jams attract the more advanced users on our forum, as well as sometimes classrooms and afterschool clubs.
What does success look like?
We come up with a design that requires a minimum of dev time to stand up (very little customization besides images, colors, etc) for each game jam
How will we measure if this is successful or not?
We can look at gamejam attendance (number of submissions) and forum response

Not relevant anymore.


Invalid unicode in author email field of README.rst

Python 3.4.x is unable to build / install the latest version of this library due to incompatiable unicode used in the authors name/email field.  Removal of this line or usage of conversion tools such as iconv fix the issue.

Can't reproduce here, regardless of the chosen locale. The utf-8 used in the setup.py is standard and should not be an issue on python 3.4 where source code files are considered utf-8 by default (and there's a coding statement anyway).

What error are you getting? IIRC that should be fixed by https://github.com/saghul/aiodns/commit/1b65499d2cc9d5fc3843a65fe7eb50a1175a8990, can you try latest master?

Hello,
Sorry about the missing content from the issue, my copy / paste failed yesterday.  At any rate the same issues were observed in the issue I opened yesterday on pycares.  Please see my description here:
https://github.com/saghul/pycares/issues/18
ps.
My attempts in the testing / patching of this were performed against the master copy cloned from here.
Regards,
Gary

Thank you much for the patch in version on pycares! Any chance when you have the chance you may be able to do the same with this project?
THANKS!

@zerosignal0 here you go! https://github.com/saghul/aiodns/releases/tag/aiodns-0.3.2

Thanks!
Sent from my mobile device, please excuse typos and brevity.

On Apr 19, 2015, at 11:48 PM, Saúl Ibarra Corretgé<EMAIL_ADDRESS>wrote:
@zerosignal0 here you go! https://github.com/saghul/aiodns/releases/tag/aiodns-0.3.2
—
Reply to this email directly or view it on GitHub.


Pulling the generated link from unpkg.com returns 404

I don't know why but for some strange reasons I was trying to load assets from a CDN using the cdn:true option but my generated report was trying to load the following javascript file that didn't exist on unpkg.com and it was returning 404 for a while. After I regenerated my report and hit multiple times the refresh button It got fixed.
File
<EMAIL_ADDRESS>Result
Cannot find module "/dist/app.js" in package<EMAIL_ADDRESS>

Definitely strange. Could have been a blip on unkpg.com. The URL that was generated in the report was correct. I'm going to close this as there's nothing much I can do here. Feel free to open another issues if this reoccurs.


rch prints undefined/index

Context

Node version: v8.12.0
React-component-hierarchy version: v1.1.0
Operating System and version: macOS Mojave v10.14.1

What are you trying to achieve or the steps to reproduce?
npx react-component-hierarchy -c ./index.js
What were your results?
npx: installed 14 in 4.054s
undefined/index

What did you expect?
To see my components' tree

also if I run:
npx react-component-hierarchy app.js
I've got this output:
npx: installed 14 in 2.994s
colors[(node.depth || 0)] is not a function

it looks like the issue is in the github:surreal9/pretty-tree package; if the app has got node w/ depth >= colors.length - 1 it throws the above error. so either this package uses the unforked pretty-tree or the forked version should be fixed w/ something like:
before
colors[node.depth || 0](node.label);

after
colors[node.depth % colors.length](node.label);

// cc @Surreal9

I forked this and then forked pretty-tree, made the suggested change from above, and it solved this. https://github.com/jeffymahoney/react-component-hierarchy


PackedVector4Array is missing

PackedVector4Array is missing in the cpp api.

Duplicate of https://github.com/libriscv/godot-sandbox/issues/191


platformio run failed

Hi,
I have tried compiling the latest version but looks like there is some kind of problem. I enclose the log - I will be grateful for any suggestion or solution.
`$ platformio run
Processing release (platform: espressif32; board: esp32dev; framework: arduino)
Library Manager: Installing git+https://github.com/maxgerhardt/ESPAsyncDNSServer#patch-1
git version 2.43.0.windows.1
Cloning into 'C:\Users\zakar.platformio.cache\tmp\pkg-installing-yoo54zm4'...
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (13/13), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 13 (delta 1), reused 4 (delta 0), pack-reused 0
Receiving objects: 100% (13/13), 4.68 KiB | 4.68 MiB/s, done.
Resolving deltas: 100% (1/1), done.
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing esphome/ESPAsyncWebServer-esphome @ ^3.1.0
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Resolving dependencies...
Library Manager: Installing esphome/AsyncTCP-esphome
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing khoih-prog/ESPAsync_WiFiManager @ 1.14.1
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Resolving dependencies...
Library Manager: Installing me-no-dev/AsyncTCP @ >=1.1.1
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing me-no-dev/ESP Async WebServer @ >=1.2.3
Unpacking  [####################################]  100%
Library Manager: ESP Async<EMAIL_ADDRESS>has been installed!
Library Manager: Resolving dependencies...
Library Manager: Installing khoih-prog/ESP_DoubleResetDetector @ >=1.3.2
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing miq19/eModbus @ 1.7.0
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Resolving dependencies...
Library Manager: Installing git+https://github.com/maxgerhardt/Ethernet.git
git version 2.43.0.windows.1
Cloning into 'C:\Users\zakar.platformio.cache\tmp\pkg-installing-ahem7rj7'...
remote: Enumerating objects: 47, done.
remote: Counting objects: 100% (47/47), done.
remote: Compressing objects: 100% (40/40), done.
Receiving objects: 100% (47/47), 52.69 KiB | 999.00 KiB/s, done.
Resolving deltas: 100% (4/4), done.
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing bblanchon/ArduinoJson @ ^6.21.4
Unpacking  [####################################]  100%
Library Manager<EMAIL_ADDRESS>has been installed!
Library Manager: Installing git+https://github.com/256dpi/arduino-mqtt#7afcfb1
git version 2.43.0.windows.1
Cloning into 'C:\Users\zakar.platformio.cache\tmp\pkg-installing-lr74de33'...
remote: Enumerating objects: 2831, done.
remote: Counting objects: 100% (145/145), done.
remote: Compressing objects: 100% (73/73), done.
remote: Total 2831 (delta 73), reused 119 (delta 57), pack-reused 2686Receiving objects: 100% (2831/2831)
Receiving objects: 100% (2831/2831), 475.35 KiB | 1.92 MiB/s, done.
Resolving deltas: 100% (1733/1733), done.
HEAD is now at 7afcfb1 added methods to support QoS1/2 retry logic
Library Manager<EMAIL_ADDRESS>has been installed!
Verbose mode can be enabled via -v, --verbose option
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/esp32dev.html
PLATFORM: Espressif 32 (6.0.1) > Espressif ESP32 Dev Module
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
DEBUG: Current (cmsis-dap) External (cmsis-dap, esp-bridge, esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES:

framework-arduinoespressif32 @ 2.0.6+sha.b63f947
tool-esptoolpy @ 1.40400.0 (4.4.0)
toolchain-xtensa-esp32 @ 8.4.0+2021r2-patch5
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 44 compatible libraries
Scanning dependencies...

Merged 1 ELF section
Successfully created esp32 image.
Compiling .pio\build\release\lib98a\AsyncUDP\AsyncUDP.cpp.o
Compiling .pio\build\release\libdfd\ESPAsyncDNSServer\ESPAsyncDNSServer.cpp.o
Compiling .pio\build\release\lib5d5\AsyncTCP-esphome\AsyncTCP.cpp.o
Compiling .pio\build\release\libfe4\FS\FS.cpp.o
Compiling .pio\build\release\libfe4\FS\vfs_api.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFi.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFiAP.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFiClient.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFiGeneric.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFiMulti.cpp.o
Archiving .pio\build\release\libdfd\libESPAsyncDNSServer.a
.pio/libdeps/release/AsyncTCP-esphome/src/AsyncTCP.cpp:753:2: error: #else without #if
#else
^~~~
.pio/libdeps/release/AsyncTCP-esphome/src/AsyncTCP.cpp:755:2: error: #endif without #if
#endif
^~~~~
.pio/libdeps/release/AsyncTCP-esphome/src/AsyncTCP.cpp:1020: error: unterminated #if
#if LWIP_IPV4 && LWIP_IPV6

Compiling .pio\build\release\lib1d2\WiFi\WiFiSTA.cpp.o
Compiling .pio\build\release\lib1d2\WiFi\WiFiScan.cpp.o
Archiving .pio\build\release\lib98a\libAsyncUDP.a
Compiling .pio\build\release\lib1d2\WiFi\WiFiServer.cpp.o
.pio/libdeps/release/AsyncTCP-esphome/src/AsyncTCP.cpp: In member function 'bool AsyncClient::connect(const char*, uint16_t)':
.pio/libdeps/release/AsyncTCP-esphome/src/AsyncTCP.cpp:754:39: error: 'ip_addr_t' {aka 'struct ip_addr'} has no member named 'addr'; did you mean 'u_addr'?
return connect(IPAddress(addr.addr), port);
^~~~
u_addr
*** [.pio\build\release\lib5d5\AsyncTCP-esphome\AsyncTCP.cpp.o] Error 1
src/evse.cpp: In function 'void loop()':
src/evse.cpp:4664:50: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
_LOG_A("Time not synced with NTP yet.\n");
^
============================================= [FAILED] Took 16.74 seconds =============================================`

I ran into a lot of errors to get the build running flawlessly with the lastest version of platformio. So I installed an older version that work pretty well..
cd $HOME rm -rf .platformio/ pip3 install -U https://github.com/platformio/platformio-core/archive/refs/tags/v6.1.5.zip git clone https://github.com/serkri/SmartEVSE-3.git cd SmartEVSE-3/SmartEVSE-3/ platformio run cd .pio/build/release

I ran into a lot of errors to get the build running flawlessly with the lastest version of platformio. So I installed an older version that work pretty well..
cd $HOME rm -rf .platformio/ pip3 install -U https://github.com/platformio/platformio-core/archive/refs/tags/v6.1.5.zip git clone https://github.com/serkri/SmartEVSE-3.git cd SmartEVSE-3/SmartEVSE-3/ platformio run cd .pio/build/release

Thank you for the help. I tried it but I am stuck:
$ platformio run
bash: platformio: command not found
...I am on win10 and entering the command from the Git Bash, i.e. MINGW64. Looks like the installation went OK and I think its located in
C:\Users\zakar\AppData\Roaming\Python\Python311\site-packages\platformio
I can also see the platformio.exe in
C:\Users\zakar\AppData\Roaming\Python\Python311\Scripts
Could you help please?


azure private networking

azure private networking
Add kola support for creating instances in an existing virtual network/subnet, and addressing them using private IP addresses. This assumes that we are either also located in the specified virtual network or can otherwise access it via VPN.
The --azure-use-private-ips option only makes sense when used together with the --azure-vnet-subnet-name, as otherwise kola creates the vnet and it won't be peered or have a VPN configured.
How to use
./bin/kola spawn --platform azure --verbose --azure-location <location> --azure-publisher kinvolk --azure-offer flatcar-container-linux-free  --azure-sku alpha --azure-use-private-ips=true --azure-vnet-subnet-name <vnet-name>/<subnet-name>

Testing done
Ran the command from the "how-to-use" section.

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@pothos any further suggestions before merging?

no, all good


Support gencode_primary for VEP REST

Description
Support gencode_primary flag for VEP REST
Use case
VEP and variation endpoints can now discover GENCODE Primary transcripts
Testing
Sandbox link: http://wp-np2-25.ebi.ac.uk:3000/documentation/info/vep_hgvs_get
Dependency
https://github.com/Ensembl/ensembl-vep/pull/1699
Changelog
Additional flag gencode_primary in VEP/variation endpoints

@likhitha-surapaneni  - the label "e113" suggests these changes are required for Ensembl release 113, but this PR is against main branch. May you clarify / confirm? Thanks

Thanks @sgiorgetti , I made a similar PR against release/113 as well. This PR is intended for main


Minor degenerate edge case when resuming training

If we run training resuming from epoch N and max epoch is <= N, then we don’t enter the train loop, so cur_epoch is not defined at line 409, causing an error (https://github.com/salesforce/LAVIS/blob/main/lavis/runners/runner_base.py#L409). I guess the user should not be specifying hyperparameters like this, but I thought I would flag it.

Hi @kttian, thanks for reporting.
I see your point and it is quite valid. We'll accommodate this in the next patch.


Integration not loading after HA container update

Ha container updated last night, webrtc wo t load the integration. Tries to reinstall, same error.

sam e here

+1
WebRTC doesn't work after updating to 2021.12

The same here:
Logger: homeassistant.setup
Source: custom_components/webrtc/utils.py:74
Integration: webrtc (documentation, issues)
First occurred: 10:03:01 (1 occurrences)
Last logged: 10:03:01
Error during setup of component webrtc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 229, in _async_setup_component
result = await task
File "/config/custom_components/webrtc/init.py", line 75, in async_setup
utils.register_static_path(hass.http.app, url_path, path)
File "/config/custom_components/webrtc/utils.py", line 74, in register_static_path
app'allow_cors'
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 186, in getitem
return self._state[key]
KeyError: 'allow_cors'

I've got the same issue. Waiting for a fix over here.

#156


Feat/add upload speed and progress

1.add a api to get upload speed
2.add a api to get upload progress
3.add a example file about how to use it

#66

#66 Additionally, the upload speed display unnormal because curlpp that vcpkg downloaded is out-of-dated , the latest had fixed it.

It's my first time of pulling a request to a public repo, anything I did not well, please forgive me,

Refer https://github.com/minio/minio-cpp/pull/72