add option to dump Zk ACls with zoo-info-viewer

Adds an option to print the ZooKeeper ACLs for Accumulo nodes that can be run pre-upgrade with only ZooKeeper running to check that the upgrade check will pass.  This is to help users resolve #3108 by providing tool they can use to check ZooKeeper node permissions before starting the upgrade process.  This version only provides the info and does not enforce any security posture - that could be added as a follow-on if desired.
The command format is:
 accumulo zoo-info-viewer --print-acls

The output lists if Accumulo has necessary access, if other have modify access and is others can read.  The output looks like:
-----------------------------------------------
Report Time: 2022-12-12T16:00:48.815718Z
-----------------------------------------------
ZooKeeper acls for instance ID: 6061fb02-0863-47d9-bf03-21b668520a92

CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/6061fb02-0863-47d9-bf03-21b668520a92 cdrwa:accumulo, r:anyone
CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/6061fb02-0863-47d9-bf03-21b668520a92/bulk_failed_copyq cdrwa:accumulo, r:anyone
CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/6061fb02-0863-47d9-bf03-21b668520a92/bulk_failed_copyq/locks cdrwa:accumulo, r:anyone
CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/6061fb02-0863-47d9-bf03-21b668520a92/compactors cdrwa:accumulo, r:anyone
CAN_ACCESS:ANY_CLOSED:PRIVATE /accumulo/6061fb02-0863-47d9-bf03-21b668520a92/config cdrwa:accumulo
...
CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/6061fb02-0863-47d9-bf03-21b668520a92/wals/localhost:9997[1000268a4920004]/c781ebab-2ba7-4ef4-88ea-64697479dc6e cdrwa:accumulo, r:anyone
CAN_ACCESS:ANY_UPDATE:ANY_READ /accumulo/instances cdrwa:anyone
CAN_ACCESS:ANY_CLOSED:ANY_READ /accumulo/instances/uno cdrwa:accumulo, r:anyone

I think being able to dump the ACLs is a nice feature. However, I'm not sure how useful that information is by itself. I think that the user needs to know what the expected ACLs are, which one's are not correct, and how to fix them.

I did not address what permissions are "required" for this round because I think that may be unsettled (1).  I planned on updating the upgrade section in the docs to address what to expect.
(1) By unsettled, the only hard requirement is that Accumulo has full access all of the nodes, specifically that Acuumulo session has or inherits cdrwa ZooKeeper permissions.  While it seems unwise to allow others access I was not sure if we a) explicitly stated that and then b) if we could / should enforce that for 2.1.x - for 3.x, that seems a better place to lock things down if that's how we want to go.  For 2.1.x, the we might want to make suggestions, but not sure how much further we can take it without potentially breaking user code external to Accumulo.
On the other hand, this should not be public API, so maybe its not "breaking" but just a way of saying "hey, you should not have counted on that in the first place".  The places where I could see a conflict would be if there were external utilities for things like getting FATE status or potentially FATE transaction clean-up without using an authenticated session.
Adding explicit checks to this code that prints a summary / violations should be easy, once it is decided what those checks should be.  Maybe is better as a follow-on if this code is accepted?

How about
ACCUMULO_HAS_ALL:MODIFY_PRIVATE:READ_NOT_PRIVATE /accumulo/4adfbde7-2578-4201-9f3e-d7d89cf2d69e cdrwa:accumulo, r:anyone
ACCUMULO_HAS_ALL:MODIFY_PRIVATE:READ_PRIVATE /accumulo/4adfbde7-2578-4201-9f3e-d7d89cf2d69e/tables/+rep/config cdrwa:accumulo
ACCUMULO_HAS_ALL:MODIFY_NOT_PRIVATE:READ_NOT_PRIVATE /accumulo/instances cdrwa:anyone
ACCUMULO_HAS_ALL:MODIFY_PRIVATE:READ_NOT_PRIVATE /accumulo/instances/uno cdrwa:accumulo, r:anyone

If Accumulo does not have ALL (upgrade would fail)
ERROR_ACCUMULO_REQUIRES_ALL:MODIFY_PRIVATE:READ_PRIVATE /accumulo/4adfbde7-2578-4201-9f3e-d7d89cf2d69e/tables/+rep/config r:accumulo

How about

I'm not sure the typical output, but I suspect we don't need the granularity of having READ and WRITE (MODIFY), PRIVATE and NOT_PRIVATE. It's probably enough to just note that the field is private or not, and we can get the extra granularity by looking at the enumerated permissions on the right side. Unless it's needed for the typical setup, I'd propose to keep it simpler.
As for the ERROR_ACCUMULO_REQUIRES_ALL, I think ACCUMULO_MISSING_SOME would be the grammatical and logic opposite.
In thinking about this some more, I think we care about:

What permissions does ACCUMULO have? (ACCUMULO_HAS_ALL, ACCUMULO_MISSING_SOME)
What permissions does "anyone" have?
Are there other permissions?

For simplicity, I was proposing grouping the last two cases into the simplified (PRIVATE, NOT_PRIVATE), and not worrying about the granularity of that for the left-side column.

My reasoning behind the "ERROR..." was to make it stand out and be clear that this would be an issue if not addressed and an upgrade would be attempted.
The others, I'm less sure.  Providing the actual perm string is sufficient to reason about what is going on - however, pulling out and specifically declaring if other can modify a node and which nodes are "public" vs Accumulo private seems convenient and makes grep expressions easier to construct for filtering.
With the samples generated from an uno instance, some of this may not be as obvious, but if there were other users (say to support metrics) it seems possible that providing a summary of the three states could help to quickly review the permissions

Also, I've been trying to be careful to not make a judgement with the utility - deferring to adding documentation in the user's guide as to what we would suggest as "normal" - but leaving it up to the users discretion if it should be an error - or no, that's what we want. Accumulo having ALL is the exception because that  will fail the upgrade and must be addressed.

Modified message to:
ACCUMULO_OKAY:PRIVATE /accumulo/9a44f7a5-9d5c-400b-a0a5-4fd5cc29d49a/users/root cdrwa:accumulo
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/9a44f7a5-9d5c-400b-a0a5-4fd5cc29d49a/users/root/Authorizations cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/9a44f7a5-9d5c-400b-a0a5-4fd5cc29d49a/users/root/Namespaces cdrwa:accumulo, r:anyone

The error message when Accumulo has insufficient permissions to upgrade is:
ERROR_ACCUMULO_MISSING_SOME:NOT_PRIVATE /accumulo/9a44f7a5-9d5c-400b-a0a5-4fd5cc29d49a/users/root/Namespaces r:accumulo, r:anyone

@EdColeman  - I think there is something wrong with this PR, like it was created against one branch then another branch merged in. 490 changed files seems really high and the pom versions are being updated.

I'll reset it back to 2.1 - I think I mixed work from the upgrade / replication removal and inadvertently rebased to 3.0 - I have some changes to help text and a header staged and just waiting for local testing to pass

I changed the base to main (3.0) and will back-port to 2.1 after merge

Regarding my comments above, the server treats world and anyone as "anyone".

Current output sample with d8ace68633c15
Report Time: 2023-01-18T17:44:38.23753Z
-----------------------------------------------
Output format:
ACCUMULO_PERM:OTHER_PERM path user_acls...

ZooKeeper acls for instance ID: 2a7aab5f-fca0-443d-b41e-768d3b9ca5dd

ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/bulk_failed_copyq cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/bulk_failed_copyq/locks cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/compactors cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/config cdrwa:accumulo
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/coordinators cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/coordinators/lock cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/dead cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/dead/tservers cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/fate cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/gc cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/gc/lock cdrwa:accumulo, r:anyone
...
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/wals/localhost:9997[10000ef0a060004] cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/wals/localhost:9997[10000ef0a060004]/0f162f5c-5c00-4e22-8ea9-f7f6afbd7395 cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/2a7aab5f-fca0-443d-b41e-768d3b9ca5dd/wals/localhost:9997[10000ef0a060004]/79db80af-eacb-4c7f-9cdd-130917842c8c cdrwa:accumulo, r:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/instances cdrwa:anyone
ACCUMULO_OKAY:NOT_PRIVATE /accumulo/instances/uno cdrwa:accumulo, r:anyone


[HOLD for payment 2024-08-14] Hermes Debugger on iOS doesn't work

Using iOS Hermes Debugger is currently not possible :(
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:

Build debug version of the iOS app
go to chrome://inspect

Expected Result:
Js runtimes are visible and I can start inspecting
Actual Result:
Js runtimes are not visible
Workaround:
:(
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @sakluger

This was reviewed by me and wasn't a regression so we should be all set here


WIP: Email submission loop views

What problem does the pull request solve?
Add views for email submission loop, see individual commit messages. This is not finished and not ready to commit.
Trello card:
Checklist

[ ] I've used the pull request template
[ ] I've linked this PR to the relevant issue (if mission work)
[ ] I've written unit tests for these changes (if code change)
[ ] I've updated the documentation in (If any documentation requires updating)

[ ] README.md
[ ] Elsewhere (please link)

Overridden by other PR


Add Ansible instructions to CONTRIBUTING.md

Add a section to the contributing doc for users to be able to easily use the ansible scripts from this repo.  This serves several purposes:

helps sanitize the ansible scripts
offloads some pressure from infra team with requests for rerunning ansible scripts
empowers others to be able to easily setup build/test environments (in both Adopt farm, or in their local machines and/or build farms)

A good goal to have a table containing succinct commands/steps for each platform that is supported.

I tried the instructions. They suggest running ansible-playbook -s playbooks/AdoptOpenJDK_Linux_Playbook/main.yml however AdoptOpenJDK_Linux_Playbook doesn't exist. I tried running AdoptOpenJDK_Unix_Playbook/main.yml instead, but got the following error
ERROR! no action detected in task

The error appears to have been in '/root/openjdk-infrastructure/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/main.yml': line 81, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

##############################
- name: Perform OS setup and configuration
  ^ here

I find the instructions confusing.
Step 2 suggests added ansible_connection=local to /etc/ansible/hosts
The Where can I run the playbooks? section suggests adding the following to /etc/ansible/hosts
[local]
<IP_ADDRESS>

It also mentions "Running ansible --version will display your Ansible configuration folder that contains the hosts file you can modify". This shows me the following. The first is a configuration file, not folder. The second is a folder but doesn't contain any hosts file.
ansible <IP_ADDRESS>
  config file = /root/openjdk-infrastructure/ansible/ansible.cfg
  configured module search path = plugins/library

@pshipton I'm not sure what happened to the Linux Playbooks.  IIRC @neomatrix369 put them there specifically so people could try out ansible on an Ubuntu Linux VM bought up by Vagrant if they didn't have their own host to try ansible out on.  Sadly I can't see an obvious commit message that talks about removing those (or renaming them to Unix).  So I suspect these instructions have bit rotted significantly.
Is there an ansible linter that we can run to check that syntax error?

Related: https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/532 https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/423

A lot of this has been implemented via #1184 and #1066
Does anyone feel there's any other holes in the docs specific to Ansible ?

A lot of this has been implemented via #1184 and #1066
Does anyone feel there's any other holes in the docs specific to Ansible ?

I think we can close this and open up specific doc bugs.


Implement initialization guard for computed expressions

This implements the initialization guard for all computed expressions (like multi observers etc.) as stated in the docs. T.i. we ensure that observers (et.al.) don't get called with undefineds initially, but if they did run once, they will see undefined values just like any other value.

Fixes #2158, fixes #3239, fixes #3401.

I just realized that I committed the wrong thing. The above description though is correct, and this change works and does what I say. I just wanted to implement a different logic.

Observers run with undefined in Polymer 2 as described in the upgrade guide, therefore I am closing this PR.


Always getting nil out of function call from Lua

Running into a weird issue, where I am trying to build a very simple "Lua console" that I can use to do live-debugging/updates of a much bigger project I'm working on. In the process, I created a simple Lua file filled with functions and all the functions will take an argument as a string, where I will do a getopt type function to parse it out, complete the task and return a string of results, or pass/fail, etc.
Running the Lua manually gets the results I want, but when I call it from the C++, it always returns nil. I'm assuming I'm messing something up on the stack, but I'm not sure. You can see an example of the code here: https://godbolt.org/z/a5qrxeE6h
I did create a single sol2 header since that's most likely how I will end up deploying things, but the example above doesn't do that.
Compilation details:
compiler: gcc 9.4 with C++17 w/ Visual Studio Code
OS: Ubuntu 20.04 (WSL2)
Lua 5.2/5.3
Any help would be great!

Nevermind. I forgot to add in more libraries, especially the sol::lib::string.
On that note, is there a way to blanket open all libraries, or is it strictly explicit?

Gmatch is a part of the string library. You need to open sol::lib::string in order to use it. You can also open all libraries with lua.open_libraries()
Also, vars.gmatch should be vars:gmatch as you are calling it like a method.


Chapter 4 completed

Hi, I've just completed the Chapter 4, updated README.md to include link to the .md file for chapter4.

Thanks for your awesome work on chapter 4. I have comments.

This repository is released under MIT license. I see other copyright at the end of the markdown and the livescript. I hope changing it to Copyright (c) 2020 NLP100-MATLAB does not cause issues on your side.
I see that you have used livescript2markdown to convert your livescript to a markdown file. (Thanks!) However, it seems that the format is of Qiita not of GitHub. Since the default outputformat is set to GitHub at the current version of the livescript2markdown, I assume you intentionally set it to Qiita, but GitHub version is more suitable for viewing on GitHub.


Trouble understanding visual automation element identifiers

Hi,
I'm new to rpa-python, thanks for the great package!
I was interested to try and get visual automation to work.
Based on the documentation, here's what I was under the impression could/should work:

I capture an image of a button and I save this image somwhere, "/path/to/button.png"
when I call r.click("/path/to/button.png")  then it would search the screen for something visually similar using computer vision and click it

What I did actually get to work (occasionally) that it clicked the cell in my jupyter notebook where I had written that code :smile:
So I'm a bit confused. I tried screenshots, I tried 1-1 the same image file as the one I wanted it to recognise, basic shapes like red square etc. but I never got it to click an image. So I'm wondering if my interpretation of the docs is off and I'm simply barking up the wrong tree?
The docs further say

If the image file specified does not exist, OCR will be used..

I can see how this is handy in making RPA process more robust.
However, is there really no feedback on whether the OCR fallback mechanism or visual automation was used? No matter what I put in this r.click() API might as well do OCR only. Was it doing anything at all with my image and how I would go about debugging this? By the way, this also makes it impossible to work in a Jupyter notebook since it's clicking my notebook code instead of the visual button I want to hit which is quite funny but a bit frustrating :smiley:
I'm on OSX Catalina, other functionality was working.

Hi @crea7564 you're welcome hope you enjoy using it after getting through this.
For whether OCR or image is used, if the image file you specified does not exist, then OCR will be the method. If there is really such an image file on your computer, then it will always rely on image matching. So the usage is unambiguous, depending on whether user provides a real image path and filename or some fake name to mean using OCR detection.
Not sure if there is some special monitor or screen set up you have. Try the following to see if you can isolate the root cause -

use only laptop screen and detach any external monitors
adjust your jupyter notebook window to bottom of screen
capture some image snapshot using macOS snipping tool
make sure that UI element is visible outside of the jupyter window and not blocked by it
try running r.click("/path/to/button.png") in notebook to see the result live

Main requirement is what you want to click must already be visible and remain visible on the screen. It can be a desktop app on macOS or something on the web-browser web page.
Also, try doing r.click(1,1) to see if mouse goes to top left corner. Try doing for bottom right corner for your display resolution (x,y) to confirm if is it because some issue with resolution-mapping.


[SPARK-27492][DOC][FOLLOWUP] Update resource scheduling user docs

What changes were proposed in this pull request?
Fix a config name typo from the resource scheduling user docs. In case users might get confused with the wrong config name, we'd better fix this typo.
How was this patch tested?
Document change, no need to run test.

cc @tgravescs

Test build #111854 has started for PR 26047 at commit 6d16c38.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16834/
Test PASSed.

Test build #111854 has finished for PR 26047 at commit 6d16c38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111854/
Test PASSed.

Thanks @tgravescs @dongjoon-hyun , merging to master!


Resolve merge conflicts for #434

Resolved merge conflicts, fixed lint errors, format using prettier
cc @nimo23

Hi @nimo23 Sorry for the delay, I finally merged them all (rather copy / paste) the code to resolve most of the conflicts
I would like your help in adding examples (or even updating existing documentation for)

Bar annotation,
new Cursor
Triangle annotation

Without any usage example it is unlikely anyone will discover it. Appreciate your help. thanks again for all the PRs and sorry for the delay

Hi. Thanks.

I would like your help in adding examples

I will try to help. The examples described within the PR can be used as it is.


better complete that do not rely on anything except the aci file to d…

…efine
name,version,os,arch.
This :

validate a little the aci
prevent dirty storage
fix regex version extraction that cannot work when name & version have
dashes

this PR also fix the signature target directory

LGTM


Fix gpu N/A in hardware page.

In ver.0.11.0, the GPU and GPU Mem of some nodes are N/A on hardware page.
These nodes both consist of many Nvidia 2080ti GPU.
I checked the json dict from http://x.x.x.x/prometheus/api/v1/query_range?query=avg(nvidiasmi_utilization_gpu%7Binstance%3D~%22x(%3A%5B0-x.x.x.x9%5D*)%3F%24%22%7D)&start=1554901559&end=1554905159&step=30. And, there is no data in the result.
The job_explore of these nodes report an out of range error:
Traceback (most recent call last):
  File "/job_exporter/nvidia.py", line 165, in nvidia_smi
    return parse_smi_xml_result(smi_output)
  File "/job_exporter/nvidia.py", line 134, in parse_smi_xml_result
    single = volatile.getElementsByTagName("single_bit")[0].getElementsByTagName("total")[0]
IndexError: list index out of range

In the nvidia_smi_log of 2080ti, there is no single_bit tag in it. But I find some other tags such as sram_uncorrectable:
		<ecc_errors>
			<volatile>
				<sram_correctable>N/A</sram_correctable>
				<sram_uncorrectable>N/A</sram_uncorrectable>
				<dram_correctable>N/A</dram_correctable>
				<dram_uncorrectable>N/A</dram_uncorrectable>
			</volatile>
			<aggregate>
				<sram_correctable>N/A</sram_correctable>
				<sram_uncorrectable>N/A</sram_uncorrectable>
				<dram_correctable>N/A</dram_correctable>
				<dram_uncorrectable>N/A</dram_uncorrectable>
			</aggregate>
		</ecc_errors>

After rewrite the /job_exporter/nvidia.py, all the nodes work well.

Coverage remained the same at 52.943% when pulling 6b069d0363cacea456093304e4dbc0ace9dd98f3 on GeoffreyChen777:fix-gpu-prometheus into 72db13b0f0aabc7cd5ca455eda0a4ace35d1a363 on Microsoft:master.

@GeoffreyChen777 Thank you for your contribution, I added some comments, would you help change a little bit?

@xudifsd Sure, I will change it soon.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: GeoffreyChen777 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@xudifsd Hi, I pushed the new code now.
I searched a lot of information about the ecc error in nvidia-smi -q -x report. In this doc(https://developer.download.nvidia.com/compute/DCGM/docs/nvidia-smi-367.38.pdf), Nvidia mentioned that the ECC errors are either single or double bit, where single bit errors are corrected and double bit errors are uncorrectable.
So, I summarize the value of the sram_correctable and dram_correctable tags as the single_bit error number. The double_bit error number are calculated by sram_uncorrectable and dram_uncorrectable.
BTW, I'm not a professional Nvidia driver developer. I'm not sure that's the right way to calculate it. :)

@GeoffreyChen777
Thanks for your fixing.
Seems that 2080 is not for scientific computing and have no ecc correction. That's the difference.
I check the field ecc_object is <ecc_object>3.0</ecc_object> for us  and <ecc_object>N/A</ecc_object> for you.
Maybe we should disable ecc checker for this gpus.

I think ecc_object seems also not enough, given that ecc could be manually turn off in support GPU.
My suggestion is putting this part in a try...catch... block.
@xudifsd
How about your opinion?

@mzmssg will turn off ecc make ecc_object as "N/A"? If so I think this is enough.

I have confirmed that the disabled ecc wil still has ecc_object as previous value, 3.0 in my case.
and the ecc_errors will have:
<ecc_errors>
                        <volatile>
                                <single_bit>
                                        <device_memory>N/A</device_memory>
                                        <register_file>N/A</register_file>
                                        <l1_cache>N/A</l1_cache>
                                        <l2_cache>N/A</l2_cache>
                                        <texture_memory>N/A</texture_memory>
                                        <texture_shm>N/A</texture_shm>
                                        <cbu>N/A</cbu>
                                        <total>N/A</total>
                                </single_bit>
                                <double_bit>
                                        <device_memory>N/A</device_memory>
                                        <register_file>N/A</register_file>
                                        <l1_cache>N/A</l1_cache>
                                        <l2_cache>N/A</l2_cache>
                                        <texture_memory>N/A</texture_memory>
                                        <texture_shm>N/A</texture_shm>
                                        <cbu>N/A</cbu>
                                        <total>N/A</total>
                                </double_bit>
                        </volatile>
                        <aggregate>
                                <single_bit>
                                        <device_memory>N/A</device_memory>
                                        <register_file>N/A</register_file>
                                        <l1_cache>N/A</l1_cache>
                                        <l2_cache>N/A</l2_cache>
                                        <texture_memory>N/A</texture_memory>
                                        <texture_shm>N/A</texture_shm>
                                        <cbu>N/A</cbu>
                                        <total>N/A</total>
                                </single_bit>
                                <double_bit>
                                        <device_memory>N/A</device_memory>
                                        <register_file>N/A</register_file>
                                        <l1_cache>N/A</l1_cache>
                                        <l2_cache>N/A</l2_cache>
                                        <texture_memory>N/A</texture_memory>
                                        <texture_shm>N/A</texture_shm>
                                        <cbu>N/A</cbu>
                                        <total>N/A</total>
                                </double_bit>
                        </aggregate>
                </ecc_errors>

Which will also make that logic failed.
@GeoffreyChen777 Could you wrap that logic into try..catch as @mzmssg said?
Maybe we should think about a safer way to access xml, like walk_json_field_safe.

@xudifsd ok, I will do it tonight.

Hi, @xudifsd, According to your xml output after disabling ecc, when the ecc_error is supported by the GPU but we manually disable it, there is still a single_bit tag in the xml output. So the ecc_single will be set to 0 at here:
https://github.com/Microsoft/pai/blob/dc15181edfdc7ad8377a4a292da95b877303e630/src/job-exporter/src/nvidia.py#L128
When the ecc_object is N/A which means that the GPU don't support ecc_error checking. We will skip the ecc_error checking code here:
https://github.com/Microsoft/pai/blob/dc15181edfdc7ad8377a4a292da95b877303e630/src/job-exporter/src/nvidia.py#L134
So, @mzmssg, I think we don't need to wrap that logic into try..catch block.

@GeoffreyChen777
Thanks for your diving.
Because we havn't found a detailed nvidia explaination about these fields, we can't guarantee all cases are coverd . My suggestion is for a safe purpose.

@mzmssg ok, I will wrap it by try and catch.

Thank you for your contribution.


Color Theme doesn't match app theme

@koenvo @koenvossen
I think the way to fix maybe here: https://docs.streamlit.io/library/components/components-api#working-with-themes

Can you check https://github.com/teamtv/streamlit_modal/pull/13 ?
The 'working-with-themes' page didn't work as those css variables aren't available

also ability to add bakground from url via css would be nice

@koenvo Can someone approve the PR for this? I just reviewed, all looks good to me, and I need this for an application I'm working on

lgtm. @koenvo Please merge when possible.

This has been merged.  Any feedback if it is working as expected?  Can we get a new pip package?

Looks good, thanks!

Yes. @bbaros Please go ahead and create a pypi release 👍

Let me release a new version


Ensuring support  for both emojis and the symbol "Đ" for Đogecoin😉

Now, the isValidSymbol function checks for both emojis and the symbol "Đ" for Doge. The script will now validate whether the provided symbol is a valid emoji or the specified symbol. The provided modification includes the enhanced validation for symbols, ensuring support for both emojis and the symbol "Đ." Replaced the existing isSingleEmoji function with the updated isValidSymbol and I added the isSingleEmoji function for further emoji validation. Haven't got a chance to try it out yet though.

if limit is 13J.
when I mint ，which one is correct?
(1) node dunes.js mintDune 5095510/16 13 J DU625sgfs56562556ddddddeeee
(2) node dunes.js mintDune 5095510/16 13J DU625sgfs56562556ddddddeeee
(3) node dunes.js mintDune 5095510/16 13 DU625sgfs56562556ddddddeeee

Thanks for the PR. Can you please use the same code formatting as on master so that the diff only contains your changes?

I just resynced your original Repo to my forked repo, so all changes
including all new commits from your end and also all my changes and
differences should be showing properly now. If not let me know what you
need me to do to and I'll fix it.
On Mon, Apr 15, 2024, 6:47 AM Sir Duney @.***> wrote:

Thanks for the PR. Can you please use the same code formatting as on
master so that the diff only contains your changes?
—
Reply to this email directly, view it on GitHub
https://github.com/sirduney/dunes-cli/pull/1#issuecomment-2056527400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEWWEIC5R62FBR5A6NN26Y3Y5OV2NAVCNFSM6AAAAABEDY736SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGUZDONBQGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

There's still a noticeable difference in formatting. If you can adjust it so that the code isn't reformatted, I'll be able to merge it. Alternatively, I can handle the changes manually if you prefer. Check out this line for reference.

Yea if you could handle it that would be great, I can just resync my fork
after you update so everyone has latest version.
Michael Harmon
@.***
410-702-8246
On Thu, Apr 18, 2024, 7:12 AM Sir Duney @.***> wrote:

There's still a noticeable difference in formatting. If you can adjust it
so that the code isn't reformatted, I'll be able to merge it.
Alternatively, I can handle the changes manually if you prefer. Check out this
line
https://github.com/sirduney/dunes-cli/pull/1/files#diff-14700dbd900932e53edad97e61ec2f1757de308567c8c17f52498337eb216b16L850
for reference.
—
Reply to this email directly, view it on GitHub
https://github.com/sirduney/dunes-cli/pull/1#issuecomment-2063615449,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEWWEIGKRJRTWW3AMQUS5RLY56TBDAVCNFSM6AAAAABEDY736SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGYYTKNBUHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add missing cache keys for test job.

Fixes #30

🗣 Description

Add missing cache keys for test job.
💭 Motivation and Context

🧪 Testing

📷 Screenshots (if appropriate)
🚥 Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@mcdonnnj does this look good to you?


Upgrade xml dependency to v6

Upgrade xml dependency to v6. This is required to be compatible with flutter_svg: ^1.1.6 which depends on xml: ^6
Ignore SVG files that don't have a  entry

@MarcBritton Thanks for the great improvement!


icu build failure

Host Environment

OS: Linux
Compiler:

$ cc --version
cc (GCC) 8.3.1 20190311 (Red Hat 8.3.1-3)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install icu
Failure logs
$ ./vcpkg install icu
Computing installation plan...
The following packages will be built and installed:
    icu[core]:x64-linux -> 69.1#9
Detecting compiler hash for triplet x64-linux...
Could not locate cached archive: /home/jhemann/.cache/vcpkg/archives/2c/2ce1372ede3ef960318fc1eea8b01ab71c6e02bf.zip
Starting package 1/1: icu:x64-linux
Building package icu[core]:x64-linux...
-- Using cached /home/jhemann/Documents/grammar/.vcpkg_trash/downloads/icu4c-69_1-src.tgz
-- Cleaning sources at /home/jhemann/Documents/grammar/.vcpkg_trash/buildtrees/icu/src/c-69_1-src-78c1b28057.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/jhemann/Documents/grammar/.vcpkg_trash/downloads/icu4c-69_1-src.tgz
-- Applying patch /home/jhemann/Documents/grammar/.vcpkg_trash/ports/icu/disable-escapestr-tool.patch
-- Applying patch /home/jhemann/Documents/grammar/.vcpkg_trash/ports/icu/remove-MD-from-configure.patch
-- Applying patch /home/jhemann/Documents/grammar/.vcpkg_trash/ports/icu/fix_parallel_build_on_windows.patch
-- Applying patch /home/jhemann/Documents/grammar/.vcpkg_trash/ports/icu/fix-extra.patch
-- Using source at /home/jhemann/Documents/grammar/.vcpkg_trash/buildtrees/icu/src/c-69_1-src-78c1b28057.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:146 (message):
    Command failed: /usr/bin/make V=1 -j 49 -f Makefile all
    Working Directory: /home/jhemann/Documents/grammar/.vcpkg_trash/buildtrees/icu/x64-linux-dbg
    See logs for more information:
      /home/jhemann/Documents/grammar/.vcpkg_trash/buildtrees/icu/build-x64-linux-dbg-out.log
      /home/jhemann/Documents/grammar/.vcpkg_trash/buildtrees/icu/build-x64-linux-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_make.cmake:194 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
  ports/icu/portfile.cmake:136 (vcpkg_install_make)
  scripts/ports.cmake:141 (include)

Error: Building package icu:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: icu:x64-linux
  Vcpkg version: 2021-05-05-unknownhash

Will attach files below
I run vcpkg with a local installation of git; my system's installation is out of date. I can't imagine that being relevant

build-x64-linux-dbg-out.log
build-x64-linux-dbg-err.log

gcc but not g++
clang++ -D_REENTRANT -DU_DEBUG=1 -DU_HAVE_ELF_H=1 -DU_HAVE_STRTOD_L=1 -DU_HAVE_XLOCALE_H=1 -I.././../src/c-69_1-src-78c1b28057.clean/source/common -DDEFAULT_ICU_PLUGINS="/home/jhemann/Documents/grammar/.vcpkg_trash/installed/x64-linux/debug/lib/icu"  -DU_ATTRIBUTE_DEPRECATED= -DU_COMMON_IMPLEMENTATION -fPIC -g -W -Wall -pedantic -Wpointer-arith -Wwrite-strings -Wno-long-long -std=c++11 -Qunused-arguments -Wno-parentheses-equality -Wglobal-constructors -c -o uarrsort.ao .././../src/c-69_1-src-78c1b28057.clean/source/common/uarrsort.cpp
...
.././../src/c-69_1-src-78c1b28057.clean/source/common/uarrsort.cpp:238:31: error: no member named 'max_align_t' in namespace 'std'
    icu::MaybeStackArray<std::max_align_t, sizeInMaxAlignTs(STACK_ITEM_SIZE) * 2> xw;

That was precisely it; I needed to add CXX=g++, like
CXX=g++ ./vcpkg install icu


The rm model which ppo train step3 requires ，but I can not find where to input this param in example ! pls help me out

https://github.com/hpcaitech/ColossalAI/blob/82503a96f20c2e61016af78445f9d1697ac07dd5/applications/ChatGPT/examples/train_prompts.py#L115

Hi @taishiciR you can use --pretrain <your pretrain model name/path>
https://github.com/hpcaitech/ColossalAI/tree/main/applications/ChatGPT/examples#inference-exampleafter-stage3


Add support for Llama2, Palm, Cohere, Anthropic, Replicate Models - using litellm

This PR adds support for models from all the above mentioned providers using https://github.com/BerriAI/litellm/
Here's a sample of how it's used:
from litellm import completion, acompletion

## set ENV variables
# ENV variables can be set in .env file, too. Example in .env.example
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# llama2 call
model_name = "replicate/llama-2-70b-chat:2c1608e18606fad2812020dc541930f2d0495ce32eee50074220b87300bc16e1"
response = completion(model_name, messages)

# cohere call
response = completion("command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

Thanks for the PR, I will try it first.

Hey, thanks for the PR again, and litellm is awsome, but I can't approve this PR directly, because it still need more adjustment to run azure openai successfully.

Hi @V-know wanted to follow up - what changes are required for adding azure openai ?
LiteLLM just requires the .env to include Azure settings

yes， I know, but I can't merge this PR directory now.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.


Improve the ranking/results in autocomplete.

I primarily use this plugin for the inclusion of dependencies as I'm typing, scenario: I type User then it adds the use App\User statement. The problem is, when I type user I'm overwhelmed with irrelevant functions, sometimes 100's...

The only way I can think of alleviating this would be to make this search case insensitive, and also improve the matching algorythm e.g. GuzzleHttp\Psr7\mimetype_from_extension comes up for User before the class does.... I don't actually see the point of this result coming up because if I wanted a guzzle module I'd type either Guzzle or mimetype_... not User... :/
Maybe I'm missing something here, but it seems like a definite problem.

this happens a lot to me too. Even after writing half of the path i don't get proper suggestions.
It would be great if this feature can be improved.
Also auto import of classes with a certain key shortcut could largely improve this feature.


Compiled crates are not reused across dev/release even if the configuration is the same

Steps to reproduce

Create a crate with the following Cargo.toml:[package]
name = "cargo_cache_is_frustrating"
version = "0.1.0"
edition = "2018"

[dependencies]
bitflags = "1.2"

[profile.dev]
opt-level = 3
debug = false
rpath = false
lto = false
debug-assertions = false
codegen-units = 16
panic = 'unwind'
incremental = false
overflow-checks = false

[profile.release]  # exactly the same
opt-level = 3
debug = false
rpath = false
lto = false
debug-assertions = false
codegen-units = 16
panic = 'unwind'
incremental = false
overflow-checks = false

cargo build
cargo build --release

Actual result
> cargo build
   Compiling bitflags v1.2.1
   Compiling cargo_cache_is_frustrating v0.1.0 (...\cargo_cache_is_frustrating)
    Finished dev [optimized] target(s) in 1.92s
> cargo build --release
   Compiling bitflags v1.2.1
   Compiling cargo_cache_is_frustrating v0.1.0 (...\cargo_cache_is_frustrating)
    Finished release [optimized] target(s) in 4.33s

Expected result
> cargo build
   Compiling bitflags v1.2.1
   Compiling cargo_cache_is_frustrating v0.1.0 (...\cargo_cache_is_frustrating)
    Finished dev [optimized] target(s) in 1.92s
> cargo build --release
    Finished release [optimized] target(s) in 0.00s

I checked cargo --build-plan outputs and they're identical
except they use paths in target/debug and target/release and
 {
     "invocations": [
         ...
         {
             "package_name": "bitflags",
             ...
             "env": {
                 ...
-                "PROFILE": "debug",
+                "PROFILE": "release",

Why do I care
In this case maybe I don't. It's just a small repro. However, this also happens with dependency profile overrides, and there it entirely defeats one of their main purposes.
Version info
> cargo version --verbose
cargo 1.41.0-nightly (8280633db 2019-11-11)
release: 1.41.0
commit-hash: 8280633db680dec5bfe1de25156d1a1d53e6d190
commit-date: 2019-11-11

I believe this would be fixed by https://github.com/rust-lang/cargo/pull/6668, but it's a very tricky change.

Yea, #6668 would address this. Since this is on our radar (and there is a meta tracking issue at #7150), I'm going to close this.  Thanks for the report, though!


Fix the issue that reported by http://www.html5gamedevs.com/topic/361…

…29-dracocompression-cause-error-when-importing-babylon-in-a-worker/?tab=comments#comment-208128

Good catch!


Testplan fo Altinn 2 Export Delegation Batch

Delivery
<EPIC/FEATURE/CASE>

Roadmap

Involved teams
@team-...

Due date
xx.xx.xxxx

Test period
xx.xx.xxxx - xx.xx.xxxx

Dependencies

Dependency
Owner
Status

End-to-end tests
Test Scenario : Migration of Delegations from Altinn 2 to Altinn 3
Verify that all delegations for Altinn 2 services have been successfully migrated to Altinn 3 after Delegation_batch job is ran

Preconditions

Offeredby user who has made many delegations for Altinn 2 services.
Coveredby user who has received rights for Altinn 2 services.

Testdata can be used :

Link services which can be used : Link service for authorization, Access operation Link service
offeredby user who has delegations for Altinn 2 services :<PHONE_NUMBER>8 - BABYBAG who is DAGL for org. nr. 310 987 018
Coveredby user :<PHONE_NUMBER>0 : HALV FELTSTOL

Test Steps

When migrating link services to Altinn 3 we need a batch that exports delegations to Altinn 3.
All delegations for Altinn 2 services which offeredby user has made should be visible as resource in response for API-endpoint
API-endpoints can be used : {{baseUrl}}/accessmanagement/api/v1/internal/{{party}}/rights/delegation/offered
{{baseUrl}}/accessmanagement/api/v1/internal/{{party}}/rights/delegation/received
Delegations including Altinn 2 services should be visible in response for both offered by and coveredby

Expcted Result

Delegations including Altinn 2 services should be visible in response for both offered by and coveredby

Actual Result

Non-functional tests

Performance tests: Link to runs and documentation when needed
Security tests: Link to documentation when needed

Clarifications

Question
Answer
**Date **

⚠ Out of scope

List discussed functionality out of scope or that might be relevant in a later release

:information_source: Useful links
Sketches
Architecture diagrams
Test environment
Testd data
Link to milestone

Jeg har testet den en til TT02 miljø og den fungrte som forventet. Da lukker jeg tasken.


Reconfigure release-drafter to be CalVer friendly

This should prevent release drafter from increasing the major version number and also adopt a new set of sections for changelog: Enhancements, Bugfixes, Other.
Inspired from https://github.com/microsoft/vscode-python/releases

@ssbarnea, may I know more details of this PR?
Are you trying to accomplish an automated solution to update the changelog file for every commit on main branch?


deploy: add exit when trying to flash v1.1.1 on 13th gen and above

@WiktorG351 I would appreciate some information / logs on which boards and CPUs it has been tested.

@macpijan This wasn't tested on any physical boards.
I just ran it a couple of times in a mock environment locally to make sure the syntax and behavior worked as intended.

@WiktorG351 Can you include such information in the future when submitting MRs? Including how things were mocked, what were the test scenarios and results?


lib/repository2: use new progressutil interface

This bumps github.com/coreos/pkg/progressutil to v2, fixing the races from https://github.com/coreos/pkg/pull/64.

LGTM

LGTM


Remove outdated build information for Android

Signed-off-by: Stefan Weil<EMAIL_ADDRESS>

See discussion. This pull request fixes issue #1393.


Worldgen crash Using Koresample 1.2.5 and Dendrology 1.3.0 [forge <IP_ADDRESS>2]

After wandering around a new SSP world and generating new chunks, I got this crash out of the blue. I do indeed have Ancient Trees config set to generate trees in the overworld very rarely. So rarely I've yet to encounter one. With that being said, I am unsure if this is a weird one off crash or something that would happen every time an Ancient tree generates. I am using fastcraft, which is also mentioned in the crash report. I also use many mods, so the area attempting to generate does happen to be a Biomes O Plenty biome with an Applied Energistics 2 Meteor right in the vicinity, if either of those things even make any difference. Thank you for the great mod and I apologize if this issue turns out not to be Koresample's fault.
http://pastebin.com/zPBe8j67

See MinecraftModArchive/Dendrology#30


Passport

Motivation
Description
A few sentences describing the overall goals of the pull request's commits.
Progress

[ ] Impl
[ ] Unit tests
[ ] Documentation

Additional Notes

@JameelB - Tests looks ok. Let's cherry pick them and adjust to your local changes.


Movie Ticketing System

I make movie ticketing system in C language in which I introduce the file system in which we store all the data of ticket counter and store in file system.
Its is very beneficial for ticket counter and customer.
I have attached some output of these:-

@MohitGupta121 Kindly assign this issue.


feat(method): add link and unlink http methods

Both are commonly used for REST APIs.

Thanks for the PR!
I'm not sure LINK and UNLINK are so common that they should be variants. Looking around at other HTTP libs, they don't seem to be included. The good news is that it's possible to use these with the Extension variant.

Yeah, i already did that, hyper::Method::Extension("UNLINK".to_string()) works fine, thanks :+1:
If other HTTP libs dont include them they i was probably wrong :) I came across them frequently though.
I guess we should draw the line somewhere, otherwise we would probably have to include all of https://www.iana.org/assignments/http-methods/http-methods.xhtml


Add support for Celsius_to_Fahrenheit and Fahrenheit_to_Celsius scalar functions

I totally agree (with https://github.com/sharkdp/insect/issues/68) that Celsius and Fahrenheit are problematic units to work with, and it's best not to support any arithmetic with them.
However, Celsius and Fahrenheit are among the most commonly converted units (to be frank, after moving to the US, this is the most frequent unit conversion I mentally do everyday, using the (approximate) formula c ≈ (f-30)/2)

I propose we include two functions (whose input and output are both scalar), Celsius_to_Fahrenheit and Fahrenheit_to_Celsius, which will work like the following.
>>> Celsius_to_Fahrenheit(c)
    #Alternative 1, print the value of (32 + 9*c/5)
    #Alternative 2, print the string "c°C = (32 + 9*c/5)°F"

>>> Fahrenheit_to_Celsius(f)
    #Alternative 1, print the value of 5*(f-32)/9
    #Alternative 2, print the string "f°F = 5*(f-32)/9 °C"

I totally agree (with sharkdp/insect#68) that Celsius and Fahrenheit are problematic units to work with, and it's best not to support any arithmetic with them.

Maybe we should revisit this and add (proper, limited) support for dealing with °C and °F directly.

I propose we include two functions (whose input and output are both scalar), Celsius_to_Fahrenheit and Fahrenheit_to_Celsius, which will work like the following.

Note that you can do this today. Just add the following to your init.nbt file:
fn celsius_to_fahrenheit(t_c: Scalar) -> str =
  "{t_c}°C = {32 + 9 t_c/5}°F"

fn fahrenheit_to_celsius(t_f: Scalar) -> str=
  "{t_f}°F = {5 × (t_f-32)/9}°C"

(you might want to add rounding)

Another thing we can do right now is the following:
dimension TemperatureCelsius
unit °C: TemperatureCelsius

dimension TemperatureFahrenheit
unit °F: TemperatureFahrenheit

fn to_F(temp: TemperatureCelsius) -> TemperatureFahrenheit = (32 + 9 × (temp / °C) / 5) °F
fn to_C(temp: TemperatureFahrenheit) -> TemperatureCelsius = (5 × (temp / °F - 32) / 9) °C

And then use it like so:
>>> 30°C // to_F

      = 86 °F    [TemperatureFahrenheit]

Try it here

I like this (i.e. fn celsius_to_fahrenheit approach) more than the second one.
If we add the units Celsius and Fahrenheit, then numbat will also be able to add, subtract and divide them, all of which are unphysical operations.

Note that you can do this today. Just add the following to your init.nbt file:

While I know how to do this, I am suggesting we add these functions to the default interface, so that Linux users looking for an unit converter will not have to write code to do these conversions, and we can recommend numbat to them.

@sharkdp I like your suggestion.

If we add the units Celsius and Fahrenheit, then numbat will also be able to add, subtract and divide them, all of which are unphysical operations.

That shouldn't be a problem if each has its own dimension, right? Because then you can't combine the different temperature units without explicitly converting them.

If we add the units Celsius and Fahrenheit, then numbat will also be able to add, subtract and divide them, all of which are unphysical operations.

That shouldn't be a problem if each has its own dimension, right? Because then you can't combine the different temperature units without explicitly converting them.

No, @archisman-panigrahi is right. It is still a problem. Adding two values in °C usually doesn't make any sense (unless one of them is an absolute value and the other one a relative value). It's kind of similar to DateTimes and durations.
I think we probably need to add proper support in the language for units with additive offsets. A first step would be to add support for units that you can't do anything with... except convert to and from.


added calculation features

fix 🐛: some issues with monthly pricing
feat ✨: added calculator

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

❌ ACTION
actionlint
1

1
0.05s

❌ COPYPASTE
jscpd
yes

584
21.24s

❌ GO
golangci-lint
7
0
1
0.78s

❌ GO
revive
7

1
26.81s

❌ REPOSITORY
checkov
yes

1
20.22s

✅ REPOSITORY
gitleaks
yes

no
0.87s

✅ REPOSITORY
git_diff
yes

no
0.23s

✅ REPOSITORY
grype
yes

no
12.37s

✅ REPOSITORY
secretlint
yes

no
3.79s

✅ REPOSITORY
trivy
yes

no
5.19s

✅ REPOSITORY
trivy-sbom
yes

no
1.06s

✅ REPOSITORY
trufflehog
yes

no
13.58s

❌ SPELL
cspell
10

31
4.16s

❌ SPELL
lychee
2

2
1.76s

✅ YAML
prettier
2
2
0
0.56s

✅ YAML
v8r
2

0
2.85s

✅ YAML
yamllint
2

0
0.93s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


Fixed a typo in citation page

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@mloning , just looking at this now

once I push a file, I don't get a pull request link in my command line. Not sure why this is happening

For some reason, the code-quality check is still failing. Could you try to run precommit on all changed files in this PR as described here?

This comment does not appear on git. is it resolved?
On Wed, Aug 18, 2021 at 5:54 PM Markus Löning @.***>
wrote:

For some reason, the code-quality check is still failing. Could you try to
run precommit on all changed files in this PR as described here
https://gist.github.com/mloning/6f4b8d412743968af6b2da8b4eaaf2bf?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alan-turing-institute/sktime/pull/1310#issuecomment-901313322,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU6W6BFIFBG2QQ7DB5UBNZ3T5PXUNANCNFSM5CIBKUTA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@AreloTanoh sorry, what do you mean by "the comment does not appear on git"? When you check the continuous integration checks below, you can see that the code-quality checks are failing. See if following the instructions in this post help you resolve the errors.

@AreloTanoh sorry, what do you mean by "the comment does not appear on git"? When you check the continuous integration checks below, you can see that the code-quality checks are failing. See if following the instructions in this post help you resolve the errors.

Sorry I was actually looking at the wrong PR. Sorry, still getting used to the website. Will do what you requested

@mloning seems document quality checks are good but something under the hood is still not happy. Will stand by for advice on next steps

@AreloTanoh we had some issues with the CI, should be fixed for now. I've restarted the tests and hope to merge this soon!

Now merge @AreloTanoh - sorry for the delay! 🎉


GitHub Wrapped Error

I am getting this error when I try to get my wrapped: "Something went wrong. Please try again in a couple minutes or raise an issue on GitHub. Thank you!"

Same issue for me :
HTTP 500 https://api.githubtrends.io/wrapped/agentcobra?year=2023
{"data":[],"message":"Error you are over your space quota, using 512 MB of 512 MB, full error: {'ok': 0, 'errmsg': 'you are over your space quota, using 512 MB of 512 MB', 'code': 8000, 'codeName': 'AtlasError'}","time":"PT1.722084S"}```

So sorry about that, it should be fixed now. Please try again and let me know if you run into any difficulties!


Duplicate mocks

there are identical mocks in different test files - should we move all mocks to a single file for a better overview and reusability?

Yes, I have thought about that as well. I think this makes sense. This would also make testing the mocks simpler and more compact.

Definitely, don't repeat yourself! Everything else makes maintenance harder.

I like the idea of having a separate file for the mocks, that way one can simply check in there for existing mocks and not search through a lot of separate file.

Actually I also think it's a good idea to have all of them in a seperate file, not at least for consistency. We still can  from mock import my_mock to only import whats really used in the test.
Btw. do we whant to gitignore the generated SOFA files or wouldn't be better to hardwire the data?

Actually I also think it's a good idea to have all of them in a seperate file, not at least for consistency. We still can from mock import my_mock to only import whats really used in the test.

Yes, that's what I was thinking of. The file should also have it's respective tests of course.

Btw. do we whant to gitignore the generated SOFA files or wouldn't be better to hardwire the data?

Please stick to the issue at hand. This is a separate issue; I have openend one in #41

An alternative would be to implement the mocks in a conftest.py: https://docs.pytest.org/en/stable/fixture.html#conftest-py-sharing-fixture-functions

In our current test implementations we often declare the mocks as pytest fixtures. I think it is unnecessary to do so, as our mocks do not serve the purpose of setting up services, state, or other operating environments (see https://docs.pytest.org/en/stable/fixture.html). So implementing them in conftest.py would be the wrong way. Please comment, if I'm missing something.

In our current test implementations we often declare the mocks as pytest fixtures. I think it is unnecessary to do so, as our mocks do not serve the purpose of setting up services, state, or other operating environments (see https://docs.pytest.org/en/stable/fixture.html). So implementing them in conftest.py would be the wrong way. Please comment, if I'm missing something.

It says that fixtures 'may  setup services, state, or other operating environments'  - so I assume you can also use them for other stuff...

It says that fixtures 'may  setup services, state, or other operating environments'  - so I assume you can also use them for other stuff...


UTC mode for DatePicker or default timezone option

Hello!
I have a problem with UTC dates in DatePicker component.
When I provide a date to it in UTC format it appears to work normally, however, when I set initial value to null and then user selects some date, it returns date in local timezone, but I want it to always return dates in UTC format.
Maybe you can create some configuration option like utcMode or provide an option to specify default timezone?
Thanks!

+1

@chrisirhc Can you add a comment for the Purgatory reasoning?

+1 for UTC

+1

+1

@karianna I did that because we lacked resources to look into this and also, datepicker is pending quite a bit of refactoring. I'm putting it into Backlog. This is clearly a very desirable feature.

Using 0.13.0 library:
I was able to work around this by adding a directive to my element (the datepicker popup trigger) that basically did the following:
ngModelCtrl.$formatters.push(function (value) {
    var date = new Date(value);

    if (isNaN(date)) {
        return value;  // needed for null/empty/undefined values
    }

    date.setMinutes(date.getTimezoneOffset());  // forces the "local" version of the date to match the intended UTC date

    return date;  // yes, this is a Date object being applied to the $viewValue...don't judge, it works!
});

Once I did that, the datepicker used the $viewValue (a Date object in this case) as its model, and since a decent offset had been applied the correct date was shown in my input as well as in the graphical day picker.
Caveat:  Some further conversion might be needed when consuming the timestamp provided by the datepicker, but that hasn't proven problematic in our project so far.

@bguezzie : I did something similar.
app.directive('datepickerTimezone', function () {
    return {
        restrict: 'A',
        priority: 1,
        require: 'ngModel',
        link: function (scope, element, attrs, ctrl) {
            ctrl.$formatters.push(function (value) {
                var date = new Date(Date.parse(value));
                date = new Date(date.getTime() + (60000 * date.getTimezoneOffset()));
                //if (!dateFormat || !modelValue) return "";
                //var retVal = moment(modelValue).format(dateFormat);
                return date;
            });

            ctrl.$parsers.push(function (value) {
                var date = new Date(value.getTime() - (60000 * value.getTimezoneOffset()));
                return date;
            });
        }
    };
});

This needs to be added to the Date & Time Picker ASAP. Angular 1.3.0 introduced support in date filters and ngModelOptions, but that has yet to carry over to these controls yet, which is very disappointing.

thank you @ttschupp

I add check for null value coming in, otherwise end up with a date = 1970-01-01. Tjis was not desirable in my case.
        ngModelCtrl.$formatters.push(function (value) {
            var date = new Date(value);

            if (isNaN(date) || (value == null)) {
                return value;  // needed for null/empty/undefined values
            }

            date.setMinutes(date.getTimezoneOffset());  // forces the "local" version of the date to match the intended UTC date

            return date;  // yes, this is a Date object being applied to the $viewValue...don't judge, it works!
        });

@ttschupp you saved my day, bless you.

Going to close this in favor of #4113 since they are requesting the same feature.


Email link sign-in not working for emails with uppercase letters

Email link sign-in is working when assessor email address is all lower case however if the email address has been stored in the database with uppercase characters then sign-in does not work.

Upon further investigation the sign-in is working. However the user is not able to access their assessment records. This is because their auth email address is lower case and this doesn't match their stored email address, which has upper case letters in it.

This has been fixed by amending our database security rules to convert both the auth email and the db email to lower case


[DO-NOT-MERGE] Travis Experiment

Not working in jdk 6, took longer than 50 mins to build scalatest's tests.


Fixed automatic computing of yMin and yMax when drawNullAsZero=true

(backport of #1106)
yMin was set to 0.0 for series containing at less one null value, even
if it contains negative values, hence hiding those values
yMax was not set to 0.0, even if series contains nulls and its maximum
non-null value is < 0.0
Fixes issue #1105

Hi, is someone interested in reviewing and/or merging these changes ?

Hi, is someone interested in reviewing and/or merging these changes ?

Hi, since this PR is only a backport of #1106, IMHO maybe it can be merged or rejected (anyway #1106 has been merged, therefore it will be released one day).

Yep, thanks for this one. Sorry for the delay! :cake:

np thx


code

这个参数你代码里直接是0.1，但是如果按照论文的说法，这个参数应该是1，原因是什么？

Yes, you are right, we follow RDDM to use this value, which could obtain better results. We think this is an interesting point to deep in.


Expired cert for Istio sidecar injector

What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):

Install Istio
Wait 1 year

Result:
You will be unable to deploy any new pods and will get the following error.
Internal error occurred: failed calling webhook "sidecar-injector.istio.io": Post https://istio-sidecar-injector.istio-system.svc:443/inject?timeout=30s: x509: certificate has expired or is not yet valid; Deployment does not have minimum availability.
Other details that may be helpful:

Workaround: https://istio.io/docs/ops/configuration/security/root-transition/#root-transition-procedure
We should add functionally to be able to rotate these certs through the Rancher UI.

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.7
Installation option (single install/HA): HA

gz#10056

@samkulkarni20 - can your team try to repro this on 2.6.3?


Results pane size keeps resetting to default.

Issue Type: Bug
Steps to reproduce

Click "Toggle Query Results" to show.
Adjust the size of the pane to a smaller size.
Click "Toggle Query Results" again to hide.
Click "Toggle Query Results" again to show.
Result: The results pane size is back to original size. Does not remember the initial size set.

I frequently toggle the results pane. So, I have to adjust the pane again each time. Else the viewport for the text editor is too small for working.

Azure Data Studio version: azuredatastudio 1.33.0 (6783aa6967e8c6d086b6f04e5fbf527659981389, 2021-10-26T17:28:15.782Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 5 PRO 4650U with Radeon Graphics (12 x 2096)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.33GB (4.02GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

ssmskeymap
kev
1.1.0

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.0.3

agent
Mic
0.48.0

dacpac
Mic
1.8.0

import
Mic
1.5.0

profiler
Mic
0.11.0

(1 theme extensions excluded)

Hi, @alanrenmsft, could we reopen this issue? I am still seeing this behavior in 1.38.0. I think maybe this was mischaracterized as a dupe of #17562, because the results/messages pane size will stay consistent between query executions, however, if you hide the results/messages pane as described in this repro, then the size gets reset.

any update on this being fixed? literally the only thing stopping me from moving over from ssms.

@cheenamalhotra  FYI.

any update on this being fixed? this issue is opened since 2021.


Guidelines for creating a custom backend

Hello - the Gluten architecture diagram shows that there is an easy option for developing a custom backend. Is there any documentation aka minimal working example or template available to get started quickly?
Thanks!

Gluten is designed to be extensible but we are working on making it more developer-friendly to serve requirements like yours. Current we don't have much docs but you can take backend-velox as an example. The code is mainly in folder backend-velox and cpp/velox. Also we are already planning to add an example-backend as a minimal code example for extending purposes.
And would you share more details about your initial plan if any? Like:

The data-processing library you like to integrate into Gluten
The underlying data format, and whether it is Arrow-compatible

So probably we can work closely to come up with a rough plan for the integration. Thanks!

It's possible to add a new backend just as Velox and Clickhouse but it doesn't mean it's an easy work.

Thanks a lot @zhztheplayer @FelixYBW! - I can see that it's a pretty tough task this is why I looking for a quick and dirty way of prototyping a native backend to assess potential performance gains I can get. To give you some context - I'm one of the co-authors of the SeQuiLa project where the key idea is to add custom Catalyst strategies for the most time consuming genomic operations and expose them using SQL and Dataframe APIs. And now I would like to optimize the interval join strategy even further by pushing down finding overlaps operation to the native backend and re-use some of the exisiting cache-efficient, vectorized implementations i C++. This is why I'm wondering what would be the less complex way of achieving that goal - whether to try to extend the existing Velox BHJ join operation - so the whole join operation is pushed down to the native engine or maybe just offload constructing efficient interval structure and finding overlaps operation without using Velox but just somehow exchange data within Spark operator with a native code using Arrow and and JNI?

whether to try to extend the existing Velox BHJ join operation

IIUC so BHJ is the only operation you want to use Gluten to offload to native engine? I think as of now it's feasible to get started within Velox backend and do some customized optimizations against its HashJoin implementation. The way gives you flexibility to decide whether or not to offload operations at the exit end of BHJ to native engine too. You may need that because C2R conversion is needed if only a join op is offloaded and the further ops remain in Vanilla Spark which may lead to performance drop in some cases.
And in another hand it's still very reasonable for this case to require Gluten to be more plug-able for adding a customized backend with probably only a single op to be modified (e.g. swap data into native by Arrow and do join tunning with minimized effort). I will get back to you once we had added enough extensibility enhancements against current developer API to match your requirement. For now it may require for too much work for that purpose.


lcd-position-and-scrolling: wrap behavior

It's my understanding that when the value of SCX/SCY are large so that the coordinate would exceed 256, it will wrap over to 0.

yes, you literally cant write a value bigger than 255 to an 8 bit register

The SCX/Y values define the top-left corner of the screen's view of the BG/window area. So if SCY=255 then the first line will be the bottom of the BG/window area and the remaining lines will wrap to rows 0-142, right?

yup! the background wraps around

Is this documented anywhere in the pandocs? It seems like the logical place to mention it is in the scrolling section https://gbdev.io/pandocs/Scrolling.html

Seems about right. Would you like to open a PR?

Ill open a PR soon


Tracers found in Skull Island!!

Exodus allows to analyze app permissions and trackers.
Skull Island, an app focused on security and privacy, tracks my activities within the app.
Unstoppable Wallet has 0 trackers.
Please remove the tracers or I uninstall the app and my adventure with arrr ends here.
Your app need to pass the Exodus test.
https://exodus-privacy.eu.org/en/
https://github.com/Exodus-Privacy/exodus

Usa la versione Non-google, tutte le app che viene installato da play store il pacchetto di google sono pre-inserite
https://github.com/PirateNetwork/Skull-Island/releases/download/v2.1.0/Skull-Island-v2.1.0.apk

you need to uninstall the app and install the github version, which app analyzer do you use?

That report shows that you have not updated since 2021, you're using a version that isn't even available to the public anymore, and you're wanting something removed that was removed 6 months ago.

As i said 2.0.0 its play store version thats why you see the google tracker, ask them to analyze the 2.1.0 from github

Given that you already opened https://github.com/PirateNetwork/Skull-Island/issues/48 and this is an issue with a non-relevant version, I'm closing this issue.


youth page updates

Remove Airborne event.

Add this detail for Concern Center Event:

We'll be helping out with projects like painting, cleaning, and organizing storage areas, so please wear clothes you don't mind getting dirty!

New series on Ephesians starts next week, so go ahead and change current "grab your friend..." paragraph to:

Grab your friend and meet us on Wednesdays as we begin our study on the book of Ephesians which challenges believers to live out the gospel. If the people of our city, of our schools, of our families are going to hear the gospel, it's going to be from our mouths! Encounter Ephesians, and get swept up into the story of Jesus. Join in with students your age for crazy games and encouraging Bible study!

so fast! thank you!! :)

On Nov 1, 2017, at 4:35 PM, Adam Garrett-Harris<EMAIL_ADDRESS>wrote:
Closed #138 https://github.com/Mountainview-WebDesign/lifestonechurch/issues/138 via e8fe878 https://github.com/Mountainview-WebDesign/lifestonechurch/commit/e8fe878de2353814b21867e6ed96f366d83b71cb.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Mountainview-WebDesign/lifestonechurch/issues/138#event-1321976846, or mute the thread https://github.com/notifications/unsubscribe-auth/AXfBrQnRIzhkfnrvl6NcAWn_pY7wrUvcks5syPIigaJpZM4QO6sB.

All For Jesus,
Keely Williams
Administrative Assistant
Lifestone Church Riverton
817.598.9567
lifestonechurch.net


Auto layouts for the iPad pro are working inappropriate .

For those who want the fix , please let me know. I fixed it myself for my use.

Yeah please share!

EAIntroView.m , go to method -(void)willMoveToSuperview:(UIView *)newSuperview and replace the line
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(deviceOrientationDidChange:)
name:UIDeviceOrientationDidChangeNotification
object:nil];
with
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(deviceOrientationDidChange:)
name:UIApplicationDidChangeStatusBarFrameNotification
object:nil];


fix(core): use String as key of Name

See: https://github.com/suisei-cn/stargazer-reborn/issues/46

What about removing LanguageCode from default_language? Then we may remove the whole isolanguage dependency.

Yea i thought about this. I think we should keep it. At least it can provide some checking on language code validity. After all this bug is not permanent and after it's solved we can adopt LanguageCode as key again.

LGTM.


Reduce the specific spelling updates from 3 to 2 commands

As these only update existing files, we can use the -a switch for git commit to add all changed files simultaneously to the commit. This also fixes the formatting to put each command on its own line.

Thanks! At some point I wonder if we should merge this list of stuff into modernize-spelling. But it might be tedious to go through a huge list of search and replace all at once without having a chance to stop.


Basic Media Viewer

The Media Viewer allows the viewer to view a collection of photos and/or sounds, generally associated with an observation. The user can enter the Media Viewer from the Normal Camera by tapping one of the photos taken, or from Obs Edit, by tapping a photo or a sound.
This issue addresses the basic functionality required for the Observation Loop 1 milestone, but we'll list the rest of the functionality for future reference
Functionality:

[x] View a collection of photos with the selected media item in the main view and the others visible in a carousel below it
[x] Carousel shows center-cropped thumbnails for photos; swipe left/right gestures show pan the carousel left and right
[x] Tapping on items in the carousel shows them in the main area
[x] Current item highlighted in the carousel with a differently-colored border
[x] Swipe left/right gestures in the main area should navigate to the next/previous media item
[ ] View full sized image when selected (i.e. not a scaled down version), including zoom
[ ] Delete image or sound with confirmation alert
[ ] View and edit/delete other photos attached to the observation

Design Figma file - look for the last screen in the multicapture camera section

Future functionality:

Show sounds as the selected media item in the main view and mixed in with other sounds and photos visible in the carousel below it
Carousel shows sound icon for sounds
Play a sound when in the main view
Button to crop image using react-native-image-crop-picker (or another, or custom, if preferred), which crops the image, saves it, and returns the user to the Media Viewer

Amanda's been having some trouble implementing zoom and swipe navigation in the main area, which raises this question for @abhasinat: should you be able to swipe to the prev / next photo while you are zoomed in? Supporting something like that requires complicated gesture handling that's tricky to implement, but also kind of confusing to the user (does a swipe pan the zoomed photo or does it navigate to the next photo?) Alternatively, when the photo is zoomed we could disable swipe nav, and maybe add a button to zoom all the way out to get back to swipability.

Good question. I think zooming in should disable swiping between different photos. When a photo is fully zoomed out, I think swiping between previous and next photo sounds good.


New Adapter iobroker.emporia

New adapter  iobroker.emporia
Checklist
[ ] All requirements to bring a new adapter into Stable repository are fulfilled (see https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-stable-repository)
[ ] Please add a link to Forum testing thread, if existing.
What will happen after creating this request?

We will do a short additional review of your adapter
After this we add the adapter to the stable repository

Thank you for your new adapter in ioBroker!

new name

New adapter iobroker.emporia

RE-CHECK!

Automated adapter checker
ioBroker.emporia

[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal
[ ] :heavy_exclamation_mark: [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.emporia
[ ] :heavy_exclamation_mark: [E604] No ## License found in README.md
[ ] :eyes: [W171] "common.title" is deprecated in io-package.json
[ ] :eyes: [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W202] Version of package.json (0.0.9) doesn't match latest version on NPM (0.0.5)
[ ] :eyes: [W400] Cannot find "emporia" in latest repository

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.emporia

[ ] :heavy_exclamation_mark: [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.emporia
[ ] :heavy_exclamation_mark: [E605] No actual year found in copyright. Please add "Copyright (c) 2023 Chris<EMAIL_ADDRESS>at the end of README.md
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "emporia" in latest repository

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.emporia

[ ] :heavy_exclamation_mark: [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.emporia
[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "emporia" in latest repository

Add comment "RE-CHECK!" to start check anew

Its at least unusual to add an Adapter to latest and stable at the same time. Please see README.md describing the normal sequence.
I would suggerst to remove addition to stable und create a second PR after this adapter is reviewed and added to latest and at leaset some users have tested it using latest repo.
But feel free to wait for any response from @Apollon77 - he will finally decide this topic

Adapter repo: https://github.com/Chris-656/ioBroker.emporia

First of all - THANK YOU for the time and effort you spend to maintain this adapter.
I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout
The adapter package provides wrapper routines for native setTimeout, setInterval, clearTimeout and clearInterval. Using those routines ensures that timers are cancelled on on load. Additional checks on thomse limits might be performed, too. So consider replacing native setTimeout/clearTimeout by adapter.setTimeout/adapter.clearTimeout or this.setTimeout/this.clearTimeout. The same refers to setInterval/clearInterval.

check and limit configurable timeouts / intervals
Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than 2,147,483,647 ms (about 24.8 days) result in the timeout being executed immediately. So all (user configurable) values passed to setTimeout / setInterval should be checked and limited.

check and limit intervals used to access cloud services
Limit all intervals used to access cloud services to a reasonable value. If users configure an inapprobiate access rate this could lead to suspending the service by the provider for all ioBroker users.

Please remove addition to stable repository until your adapter has passed some time at latest repository.

Thanks for reading and evalutaing this suggestions.
McM1957

See questions below in your text
regards Chris

Von: Martin M. @.>
Gesendet: Sonntag, 26. März 2023 22:16
An: ioBroker/ioBroker.repositories @.>
Cc: Besterquester @.>; State change @.>
Betreff: Re: [ioBroker/ioBroker.repositories] New Adapter iobroker.emporia (PR #2194)
First of all - THANK YOU for the time and effort you spend to maintain this adapter.
I would like to give some (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77https://github.com/Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout :Done

The adapter package provides wrapper routines for native setTimeout, setInterval, clearTimeout and clearInterval. Using those routines ensures that timers are cancelled on on load. Additional checks on thomse limits might be performed, too. So consider replacing native setTimeout/clearTimeout by adapter.setTimeout/adapter.clearTimeout or this.setTimeout/this.clearTimeout. The same refers to setInterval/clearInterval.

check and limit configurable timeouts / intervals

Node setTimeout/setInterval routines have a maximum allowed value of 2,147,483,647 ms. Using delays larger than 2,147,483,647 ms (about 24.8 days) result in the timeout being executed immediately. So all (user configurable) values passed to setTimeout / setInterval should be checked and limited.
Not clear to me. In index_m.html there is the limitation implemented

                           Is this not sufficient ?

check and limit intervals used to access cloud services

Limit all intervals used to access cloud services to a reasonable value. If users configure an inapprobiate access rate this could lead to suspending the service by the provider for all ioBroker users.
            Ok understand. Try to implement a time out for the state active

Please remove addition to stable repository until your adapter has passed some time at latest repository. Done

Thanks for reading and evalutaing this suggestions.
McM1957
regards Chris
—
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FioBroker%2FioBroker.repositories%2Fpull%2F2194%23issuecomment-1484210798&data=05|01||3377999e83d1401630f308db2e370b01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638154586157020611|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=pIlqSChhE8867oOAhUPH19klGj8D3cyBPiRLEfCZzro%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANSL57SA2ZK76JH44MWRZHDW6CW4LANCNFSM6AAAAAAWIBPSGY&data=05|01||3377999e83d1401630f308db2e370b01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638154586157020611|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=K9pH%2BaO2sSd38b7%2Fgr9xjC3aKecgZF14PHXqcTK7UDo%3D&reserved=0.
You are receiving this because you modified the open/close state.Message ID: @.***>

check and limit configurable timeouts / intervals
:
Not clear to me. In index_m.html there is the limitation implemented

OK, I did not check index_m.html. Limiting could be OK there. But users could change the value within objects too (manually). So personally I prefer to check the limits insode code too. But its your decision whether a double check is appropiate. I do not think, this would be blocking at Apollons check.

check and limit intervals used to access cloud services
        Ok understand. Try to implement a time out for the state active

No  I think my comment was misleading. I do not think that a timeout is required. The important point is to limit polls from cloud to a maximum rate. The user should not be allowed to poll i.e. every second while a poll every minute would be more than sufficient (i.e. when polling whether data od currency exchange rates, ...) As notes above you limit to 5 (seconds I assume) so this limit ist low but might be ok. The problem which should be addressed is, that we already had situations where the cloud provider access from iobroker was blocking due to inappropiate high load caused by few but much to heavy polling.
Thanks for reading and reacting on the suggestions.
McM

RE-CHECK!

Automated adapter checker
ioBroker.emporia

:thumbsup: No errors found

[ ] :eyes: [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
[ ] :eyes: [W400] Cannot find "emporia" in latest repository

Add comment "RE-CHECK!" to start check anew

Please remove node 14 from test-and-release.yml and (optionally) add node 20 to testing matrix.
Node 14 is no longer supported and tests will fail since 22.5.2023.
Thanks
McM1957

RE-CHECK!

I would like to give some additional (preliminary) feedback based on my personal oppinion. This is NOT an offical review and @Apollon77 might have several additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him (or wait for a response from him) if you cannot follow my suggestsions or before you spend major effort.

[ ] reevaluate state roles
Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.
In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.
role 'name' does not exist, please use an existing role, i.e. 'text'

[ ] adapt testing to supported node releases
As node 14 is end of life and will no longer be supported by js-controller 5.x, consider removing node 14.x tests from matrix id still present.
Tests for node 16 is mandatory unless you require node 18 and higher.
Tests for node 18 is mandatory as many users already use node 18 and node 16 will be eol and deprected Q3/2023.
Consider adding node 20 tests unless you already know incompatibilities.
So the recommended testmatrix is [16.x, 18.x, 20.x],

Thanks for reading and evaluating this suggestions.
McM1957
Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

How shall we continue?
Please let us know if you plan zu fix the noted issues in the near future - or as an alterntive - like to discuss some / all of those points.

@Chris-656
How shall we continue?
Please let us know if you plan zu fix the noted issues in the near future - or as an alterntive - like to discuss some / all of those points.
Looks like only adaption of node release (16 to 20, remove 14) was missing.
Please add any comment if you still maintain this adapter and want it listed at repositories
If we do not receive any comment until mid of November this PR might be closed.

I will di the changes today. Hopefully it works. thx

RE-CHECK!

@Chris-656
How shall we continue?
Please let us know if you plan zu fix the noted issues in the near future - or as an alterntive - like to discuss some / all of those points.
Looks like only adaption of node release (16 to 20, remove 14) was missing.
Please add any comment if you still maintain this adapter and want it listed at repositories If we do not receive any comment until mid of November this PR might be closed.

I chenged the role names and added V 20.x in the tests. How we can now proceed ?

@Chris-656
I did not detect you removal if stable as you did not comment.
I'll continuer asap
No further action required by you

RE-CHECK!

This adapter has been released to latest repository and should be visible within 24h maximum.
Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter  " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.
Note: If an other testing topic already exists, ist OK to continue using this topic too.


Feature/171 redesign memory viewing screen

Redesigned the memory viewing screen. This branch still has the old edit button that only edits text, will need to figure it out alongside the edit branch.

All checks passed, merging.


crash

UICollectionView received layout attributes for a cell with an index path that does not exist

[self.collectionView reloadData];
[self.collectionViewEPGLayout invalidateLayoutCache];


P2P topic

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Curating a new Topic page

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])

[x] My folder contains a *.png image (if applicable) and index.md

[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:
The topic is well used, 465 repos currently. I thought of this because it's linked (well, a search for the topic is) in https://github.com/blog/2396-join-github-in-support-of-the-open-internet-again
I skimmed https://tools.ietf.org/html/rfc5694 to get ideas for the descriptions. I didn't include an image since the first thing that comes to mind is still subject to copyright and not licensed as far as I know and a quick search didn't turn up a great substitute.

Thanks @mlinksva!


Initial notification is null when app launched via a notification action

Hi,
I have asked this question on stackoverflow also at: https://stackoverflow.com/questions/74470589/initial-notification-is-null-on-ios-when-app-launched-via-a-notification-action
Posting it here also in case it is a bug/new feature. When the app is not running in background and is launched via a foreground notification action, then the notification is null in the getInitialNotification  causing the app to loose the user action.

Hi, this is still an open issue and would be really helpful if somebody with native iOS experience could look into it. To reproduce the problem, simply send a remote notification with some foreground notification actions to the app when the app is not running in the background. Choose a notification which will bring the app to the foreground. Note that getInitialNotification handler received the initial notification as null. Hence, we can't process the notification action taken by the user.


$ionicHistory.clearHistory() does not work

Please see this codepen: http://codepen.io/anon/pen/myOVmy?editors=101
I've added cache: false to the  'Contact Tab' state so it's controller is executed every time.  You can see that I'm running $ionicHistory.clearHistory() within there, but when you go back to the 'Home Tab' it does not fire the console.log() inside it's controller.
Am I using this incorrectly? Or is it broken?

$ionicHistory.clearHistory() doesn't clear cached views, only the navigation history. You're probably looking for $ionicHistory.clearCache. Alternatively, you could add cache: false to your home state.

Yup, you are totally right.  First time I've used this framework so I'm not totally familiar.  Thanks!


Same kind of script for Host Monitoring Agent ?

Hi guys,
It would be good to have the same kind of script for Host Monitoring Agent : https://community.dynatrace.com/community/display/DOCDT60/Host+Monitoring+Agent
As it doesn't use the same file for configuration :(
Alex

Hi alex,
currently time is kinda short.. but i'll try to add that as next.
Patrick


feature: add global build constant values

In the same way an android application can access the:

packageName(com.example.appName)
appName(appName)
version(context.getPackageManager().getPackageInfo(context.getPackageName(),
0).versionName)

Add global values that can retrieve those informations,
this is necessary for the making of the (flutter maintained)
package_info
flutter plugin.
This will also came useful for the future hover init-plugin command,
as the default flutter create --template=plugin plugin_name creates a
template plugin that retrieve the android.os.Build.VERSION.RELEASE
constant on android.  The mapping value for go-flutter is
flutter.PlatformVersion() (go-flutter release used for the project)

Must be at least tagged into: v0.30.0, see https://github.com/go-flutter-desktop/hover/pull/27


Tokenization

Any sample code for this part here? Especially for German tokenization?

We haven't trained any German models, so you are free to use whatever tokenizer you want when preparing the corpus for pretraining.  For English, use the Moses tokenizer.

Hi!
Here is a preprocessed german text corpus based on wikipedia:
https://github.com/t-systems-on-site-services-gmbh/german-wikipedia-text-corpus
Here is the preprocessing code:
https://github.com/PhilipMay/de-wiki-text-corpus-tools/blob/master/process_wiki_files.py
Which I did in combinaton with Wikiextractor. See here:
https://eniak.de/it/training_of_german_word_embedding_for_nlp
I tested and love SoMaJo as Tokenizer on word and sentence level:
https://github.com/tsproisl/SoMaJo


Some of the links to Faker are broken.

A few of the documentation links to Faker are broken

For anyone wanting to work on this, try doing a find all search for
https://hexdocs.pm/elixir/Faker.html
I believe it should be https://hexdocs.pm/faker/readme.html

This issue should be closed.


[stable/instana-agent] Add mount "/run" for the Instana Agent

To work with ContainerD, the Instana Agent needs an additional mount at
/run. Renamed the /var/run mount and /var/log as well for
consistency.
Signed-off-by: Miel Donkers<EMAIL_ADDRESS>
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/approve

/lgtm


Building new vehicle failed [following the doc]

Hello all,
I recently tried to create my own vehicle in the simulator. I followed everything one by one, but in the end, I run the below command to test my car:
python3 manual_control.py --filter Iseauto
"Iseauto" is my vehicle name. It shows me the following error:
Traceback (most recent call last):
  File "manual_control.py", line 1325, in <module>
    main()
  File "manual_control.py", line 1317, in main
    game_loop(args)
  File "manual_control.py", line 1214, in game_loop
    world = World(sim_world, hud, args)
  File "manual_control.py", line 217, in __init__
    self.restart()
  File "manual_control.py", line 246, in restart
    blueprint = random.choice(get_actor_blueprints(self.world, self._actor_filter, self._actor_generation))
  File "/usr/lib/python3.6/random.py", line 260, in choice
    raise IndexError('Cannot choose from an empty sequence') from None
IndexError: Cannot choose from an empty sequence

I couldn't find any clue for the error. Do you have any suggestions?
It seems that it doesn't matter if I input the vehicle name wrongly in the command. it shows again the error.
CARLA version: 0.9.13
Platform/OS: Ubuntu 18.04

Hello all,
I recently tried to create my own vehicle in the simulator. I followed everything one by one, but in the end, I run the below command to test my car:
python3 manual_control.py --filter Iseauto  "Iseauto" is my vehicle name. It shows me the following error:
Traceback (most recent call last):
  File "manual_control.py", line 1325, in <module>
    main()
  File "manual_control.py", line 1317, in main
    game_loop(args)
  File "manual_control.py", line 1214, in game_loop
    world = World(sim_world, hud, args)
  File "manual_control.py", line 217, in __init__
    self.restart()
  File "manual_control.py", line 246, in restart
    blueprint = random.choice(get_actor_blueprints(self.world, self._actor_filter, self._actor_generation))
  File "/usr/lib/python3.6/random.py", line 260, in choice
    raise IndexError('Cannot choose from an empty sequence') from None
IndexError: Cannot choose from an empty sequence

I couldn't find any clue for the error. Do you have any suggestions? It seems that it doesn't matter if I input the vehicle name wrongly in the command. it shows again the error.
CARLA version: 0.9.13 Platform/OS: Ubuntu 18.04

It was my mistake, It is already mentioned that the vehicle name should be in lower case while running the command. So There is no problem anymore!