Remove common prefix from all query-names

At Khan we prefix all of our queries with the service-name, e.g. Coaches_GetAssignments, so that the names are globally unique (useful for logs).  But in the generated types, this prefix is just noise.  It would be nice to find a way to remove it; except it's a bit hard to do so in a generalizable way.
Another option would be to munge the query to add to the "real" operation name -- that is you would just write query GetAssignments and genqlient would know based on your config to send Coaches_GetAssignments.

I'm inclined to just leave it as it is now.  How bad is it to have that noise in the generated types?  The generated types are already super-long; if I want to use them in real life I make a type alias for them anyway.

Ok, if you don't feel this has been an issue in practice I'll just close it!  It doesn't cost us anything other than longer names (for both the query-function and the types).

Yeah, it's not been an issue for me.  I mean, the long names are unreadable in general, but I don't think adding the Coach_ prefix makes them worse.


Use Buffer.BlockCopy with byte[]

This change is based on changes done https://github.com/dotnet/corefx/commit/3ab3bd6efcba669bf04d42f738fe5a495ec62940. I have replaced Array.Copy wherever there is byte[]. Buffer.BlockCopy has less overhead than Array.Copy when copying byte[]s.

working with bytes are more difficult than working with indexes and may cause debugging to be more complicated, but since the data is already in bytes no issue here. Looks good to me.


Updates Gradle plugin badge version to v0.9.1.

Actually, will update all version occurrences to v0.9.1


refactor: ProgramCall.addParam to accept an object

Resolves #107

There is an open propsal to add private methods to JS.
https://github.com/tc39/proposal-private-methods
It is currently a stage 3 candidate.
In the future we could use this syntax instead of using __mehtod__ naming used here.
class ClassWithPrivateMethod {
  #privateMethod() {
    return 'hello world'
  }

  getPrivateMessage() {
      return #privateMethod()
  }
}

Need to update unit tests with this PR.

Functions who use ProgramCall internally wil need to be update to pass an object to ProgramCall.addParam.
This includes methods in the following classes:

iDataQueue
iNetwork
iObj
iProd
iUserSpace
iWork


None time_start and time_end

In the guide how_to_use_raw_APD_datatset_function.ipynb, the function
ds = cmod.generate_raw_apd_dataset(shot_number=shot_number, time_start=None, time_end=None, subtract_background=True)
is called, however, time_start and time_end cannot be None, as they are used later. Removing the arguments as in
ds = cmod.generate_raw_apd_dataset(shot_number=shot_number, subtract_background=True)
and falling to the defaults (+- np.inf) solves the issue.

Sorry, I forgot to update the notebook after I made those changes to the function.


fix: Update action url in searchsite.html and pages

name: Global search
about: This a pull request to fix enable the global search in the header
title: 'fix: Update action url in searchsite.html and pages'
labels: 'bug'
assignees: '@delisma'
What does this MR do?
The action url in the global search is set to # in the posts and to https://recherche-search.gc.ca on summary pages.In order for the search to work properly it needs to be set up to 'https://canada.ca/[lang]/sr/serb.html
Preview links
en: Blog
fr: Blogue

Did some testing for the search and it goes to right pages in both languages but doesn't populate the search page at all.


Login failed, token exchange failed

Describe the bug
After removing skodaconnect from HACS, restarting, installing v1.0.42-rc2 and restarting I'm getting this error in the log:
10:53:42 ERROR (MainThread) [skodaconnect.connection] Login failed for skoda account, Token exchange failed 10:53:42 WARNING (MainThread) [custom_components.skodaconnect] Could not login to Skoda Connect, please check your credentials and verify that the service is working
In configuration.yaml I have:
skodaconnect:   username: !secret skoda_username   password: !secret skoda_password   scan_interval:     minutes: 5
And looking for Integration gave these results:

I have checked creds and they work on skoda-connect.com
Any ideas?
Latest working release
v1.0.40-RC5
Debug logs
See above

The failure in token exchange is most often because of the servers not responding in time, high load or other issues. Try again or try later and it most often resolves itself.
If you can't find the integration inte hass gui then it might not have installed correctly.
From 1.0.41 and onwards the Python skodaconnect module version should be printed on startup as well. If that doesn't show then that's an issue as well.

Same thing happens here. It usually works with the release, but 1.0.42 rc2 always fails. I tried to repeat it number of times, always fails.
I removed the configuration in YAML and adding the integration via config flow.
It tries to connect, then after some time it displays Could not login to Skoda Connect, please check your credentials and verify that the service is working. This is the log
2021-07-10 14:43:01 INFO (MainThread) [skodaconnect.connection] Init Skoda Connect library, version 1.0.42
2021-07-10 14:43:01 DEBUG (MainThread) [skodaconnect.connection] Using service https://msg.volkswagen.de
2021-07-10 14:43:01 DEBUG (MainThread) [skodaconnect.connection] Initiating new login
2021-07-10 14:43:01 INFO (MainThread) [skodaconnect.connection] Connecting to Skoda native API
2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint
2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Found item: ('_csrf', '696dc81a-969d-4c1e-b5af-3766bf863706')
2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Found item: ('relayState', '3b45be1f62ab6fa78037e8d6b073a39af83022fe')
2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Found item: ('email'<EMAIL_ADDRESS>2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Found item: ('hmac', '3e1f06532f6fb1e2c0092c322c54f260c8903510e31c738cf7f6c37f06b41ea8')
2021-07-10 14:43:02 DEBUG (MainThread) [skodaconnect.connection] Authenticating with email and password.
2021-07-10 14:43:03 DEBUG (MainThread) [skodaconnect.connection] Parsing login response.
2021-07-10 14:43:03 DEBUG (MainThread) [skodaconnect.connection] Login successful, received authorization code.
2021-07-10 14:43:03 DEBUG (MainThread) [skodaconnect.connection] Trying to fetch user identity tokens.
2021-07-10 14:44:03 ERROR (MainThread) [skodaconnect.connection] An API error was encountered during login, try again later
2021-07-10 14:44:03 ERROR (MainThread) [custom_components.skodaconnect.config_flow] Failed to login due to error: Token exchange failed

The login procedure is basically the same since 1.0.30 somewhere. If it works in 1.0.40-RC5 but not 1.0.42-RC2 it's more probable that it's a coincidence.

I can add that there's been issues with bot the Skoda and VW app the last couple of days, not able to login etc.

I'm seeing the same issue on 1.0.40rc5..token exchange failed

Problem was caused by Skoda Connect servers being offline/unreachable
Non-issue


[WFLY-19274] When SocketsAndInterfacesTestCase searches for a non-def…

…ault NIC it should ignore those with no addresses
https://issues.redhat.com/browse/WFLY-19274
https://ci.wildfly.org/viewLog.html?buildId=440377& is a custom test run to see if this fixes the recurring failure we're seeing in that nightly job.

More information about the wildfly-bot[bot]

/retest

Thanks @yersan


CppCheck giving warning for arm_divide_q31 because of CWE 758 violation

I encountered a warning from CppCheck indicating the the following line of arm_divide_q31.c#L66 is violating CWE 758.
CppCheck message:
cppcheck version="2.5"
msg="Shifting signed 32-bit value by 31 bits is implementation-defined behaviour"
cwe="758"

This will also hold for q15 I think.
I suppose that something like (numerator < 0) ^ (denominator < 0) could fix it?

Corrected in latest commit

Very nice, thanks for the quick turnaround! I'll close this issue then.


Adding rust client information to docs

Summary
Partially addresses #324 by adding information on the Rust Client.
Release Note
None

@flavio Would you please review? CC @haydentherapper @cmurphy

@haydentherapper comments have been addressed. Thank you for the review.

Sorry for the late response. Everything LGTM. Thanks for having updated the docs to mention Rust :)


docker login on ACR doesn't work

following response:
Error response from daemon: Get https://myserver.azurecr.io/v2/: unauthorized: authentication required

does ACR no longer allow Basic Auth and it's OAuth only?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba491964-1f3c-6833-fc0b-ad57606ebced
Version Independent ID: d507f1aa-0e8e-9abc-2dd8-1b152ee530f9
Content: Quickstart - Create a private Docker registry in Azure with the Azure portal
Content Source: articles/container-registry/container-registry-get-started-portal.md
Service: container-registry
GitHub Login: @dlepow
Microsoft Alias: danlep

Thanks for the question! We are investigating and will update you shortly.

@cmeyertons can you elaborate on what steps you are taking? I followed the doc as written and I was able to login to my ACR

@cmeyertons any update on this?

@cmeyertons I will close this for now. When ready let me know and we can reopen and continue.

I'm running
docker login -u myusername -p mypassword myserver.azurecr.io

my acr is currently set up under the Basic sku:
{
    "adminUserEnabled": true,
    "creationDate": "2018-10-18T12:31:43.691012+00:00",
    "id": "/subscriptions/***/resourceGroups/***/providers/Microsoft.ContainerRegistry/registries/myserver",
    "location": "centralus",
    "loginServer": "myserver.azurecr.io",
    "name": "myserver",
    "provisioningState": "Succeeded",
    "resourceGroup": "loweco-acr",
    "sku": {
      "name": "Basic",
      "tier": "Basic"
    },
    "status": null,
    "storageAccount": null,
    "tags": {},
    "type": "Microsoft.ContainerRegistry/registries"
  }

I was trying to get my registry open in the Docker explorer in VS code and was able to get around this issue by installing the Azure Account extension

@cmeyertons thanks for the update on this. You will always need to authenticate to Azure using Azure Account commands in order to communicate with your services.
If you have additional questions just let me know.

Huh? I’m a little confused as to the reasoning behind closing this issue on the docs.
The whole point of logging this issue was to fix the docs, which state to use docker login which you confirmed doesn’t work?

@cmeyertons apologies I was not clear.
I ran through the document and was able to login to my docker without using any Add Azure account commands. That being said, I am running it in CMD and not Visual Studio code.
To run actions against Azure resources using Visual Studio code you do need to have the azure extension installed. This is not just for ACR but for anything Azure. It is the same idea as installing Azure CLI which lets you manage your resources via command line or Azure PowerShell from a PS module. Visual Studio it is own program and needs to have its dependencies installed properly.
You absolutely can run commands using Visual Studio code however for all the docs we generally stick to CMD or PowerShell for simplicity.

Thank you for clearing up! Issue is good to close now, apologies for not understanding sooner. Long day at work!

@cmeyertons no worries! I should have been more clear with my explanation :)
If you think of any other questions don't please don't hesitate to reach out

I'm still getting the error. I'm kind of new to this environment. I'm deploying a node.js app to a container. I was able to successfully build the image on my local machine. As a next step i'm trying to push the image to ACR. I'm using the following command to login "docker login --username myusername myloginserver" and when prompted for password i used the password provided in the access keys section of the ACR resource in the azure portal. In powershell (not powershell ISE) i got the following error: "Error response from daemon: Get https://xxxxxxxxxxxx.azurecr.io/v2/: unauthorized: authentication required"
In command prompt: "Error response from daemon: Get https://xxxxxxxxxxxxxxx.azureacr.io/v2/: Service Unavailable"
In VScode terminal with Azure account extension installed i got the following error "Error response from daemon: Get https://salesforceintegrationcontainer.azureacr.io/v2/: Service Unavailable"
not sure what's going wrong. Any help is greatly appreciated.


the download.sh script error:

unzip captions_train-val2014.zip -d data/
should be:
unzip ./data/captions_train-val2014.zip -d data/
not big deal, anyway

Thanks. Could you modify the script code and give a pull request?


Cannot Connect to Different SQL Instances on the Same Windows Server 2019

Azure Data Studio Version: 1.34.0
OS Version: POP OS

Steps to Reproduce:

Have an On-Prem SQL Server With Multiple Instances
Attempt to connect to instance example: Hostname\NewInstance
The Following error occurs:

Notes:
Keep in mind connecting to default instance works without issue.

Does this issue occur when all extensions are disabled?: Yes/No

Nevermind found the issue: if using AD follow this: There should be service principal names (SPNs) registered for each instance of SQL Server you're trying to connect to. For more information, see Register a Service Principal Name for Kerberos Connections. OR login using an SQL Login Account


Parallel-safe quality-control

The cause of the crash in #2683 is that reports.qc.generate_qc() was not safe to run in parallel, because it creates a single output report from all the .json files it finds in the directory it is pointed at for each subreport. The crashes we were seeing were a result of some processes trying to read half-written .json data.
I'm guessing it is meant to be used in a pipeline that runs a bunch of image processing steps and reports the results as .json, with the expectation that this is to be done interactively -- so that you would rerun a test and then reload the summary report.
This fixes it by using POSIX file locking around the entire working directory (er, well, the directory being operated on, that is).
This shouldn't slow down any actual tests that use qc, it only affects the generation of reports. But I haven't actually tested this.
I also discovered that the test runner was reusing an output directory, so once I fixed it it didn't seem fixed, because the previous 500 .json files were still there. This fixes that, introducing the small change in behaviour that the test directory is erased when finished.

To see that this fixes it, I figured out how to reproduce the crash reliably and applied that patch both to master and this branch (the indentation changed so the patch to each is different but the code is the same):

off master: https://github.com/neuropoly/spinalcordtoolbox/tree/ko/2683-repro
off this branch: https://github.com/neuropoly/spinalcordtoolbox/tree/ko/2683-parallelsafe-qc-repro

On 'master', 100% failure:
$ git branch --show-current
ko/2683-repro
$ for i in `seq 20`; do pytest unit_testing/test_qc_parallel.py | tail -n 1; done
============================== 1 failed in 4.50s ===============================
============================== 1 failed in 4.50s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.48s ===============================
============================== 1 failed in 4.59s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================
============================== 1 failed in 4.49s ===============================

(interestingly, the writes can be both too fast or too slow: too fast and they complete before the reads, which hides the bug; too slow and no files get written before the reads, so the result is just empty, which also hides the bug)
On this branch, 100% success:
$ git branch --show-current
ko/2683-parallelsafe-qc-repro
$ for i in `seq 20`; do pytest unit_testing/test_qc_parallel.py | tail -n 1; done
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.77s ===============================
============================== 1 passed in 4.77s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.77s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.77s ===============================
============================== 1 passed in 4.87s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.85s ===============================
============================== 1 passed in 4.87s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.77s ===============================
============================== 1 passed in 4.76s ===============================
============================== 1 passed in 4.77s ===============================

Questions:

I used POSIX file locking, which has its detractors. I think it's okay for this since it's only a single lock at a single place, but it might have problems on Windows (hopefully WSL implements locking right?) or if someone tries to extend this.

I used fcntl.flock() directly -- hence the try ... finally -- but there's this nice context-manager which would be better, but I was hesitant to add another dependency.

As mentioned by the detractors, there's confusingly also lockf(). Python exposes this as os.lockf() which makes me feel like they want me to prefer it -- but lockf() doesn't work on directories, I tried it; I could make it work (by using $DIRECTORY/.lock.txt) but I don't know which is better or if it matters?

(as mentioned in https://github.com/neuropoly/spinalcordtoolbox/pull/2711#issuecomment-633801204) The even deeper underlying issue is that each independent QC report run also tries to generate an overall summary, when what each should do is run in isolation then feed into an aggregation step. But this requires more extensive rewrites and some redesign, and would break interactive use if we're not careful, if that is an important feature; ultimately, the aggregation step will either have to refuse to overwrite files (forcing the user to generate an isolated path for the summary on top of isolated paths for the subreports), or implement this same locking code.

If I was designing this from scratch I would do something like:
cat jobs.csv | parallel --jobs 2 --pipe generate_qc | generate_qc_summary

In this phrasing, the bug is because generate_qc_summary is currently embedded inside of   generate_qc, so each instance is interdependent on the others.
The python equivalent is:
with multiprocessing.Pool() as pool:
    jsons = pool.map(generate_qc, jobs)

generate_qc_summary(jsons)  # this is currently named _update_html_assets()

I'm not convinced this is the only concurrency issue in this code, but it fixes the test.

This is a better fix, thanks!


Link and integration into https://starhub.mywire.org

Hi...
Just to let you know i listed you application in the project i am working on right now https://github.com/Intika-Web-Apps/Starhub-Notifier/
https://starhub.mywire.org (under apps)
I may add a direct link to the profile when a user is logged in. :)
Thanks

Nice, thanks for the heads up :)


Tests should run against all stable Ruby versions

See https://www.ruby-lang.org/en/downloads/ for listing
Currently:

2.3.1
2.2.5
2.1.0 (will reach EOL soon)

Fixed in #211


Inherit methods from base class in extended class

Hi Sam,
Thanks for building extend! It's very useful in opening up inheritance patterns with ZodClass. In testing, I've noticed that the class instance returned by extend does implement type extension/narrowing exactly as you'd expect, but it doesn't inherit class methods declared on the base class—I could very well be incorrect, but I believe because its declared as a static method and therefore doesn't have any reference to the parent class?
As an example, it would be excellent to be able to do the following:
const fooShape = {
  foo: z.string()
}

class Foo extends ZodClass(fooShape) {
  getFoo() {
    return this.foo;
  }
}

const barShape = {
  foo: z.literal('forty-two'),
  bar: z.number()
}

class Bar extends Foo.extend(barShape) {
  getBar() {
    return this.bar;
  }
}

const barSchema = {
  foo: 'forty-two',
  bar: 42,
}

const bar = Bar.parse<Bar>(barSchema);

const fortyTwo: 'forty-two' = bar.getFoo(); <— this method reference is currently lost

Does this seem feasible given how JS handles prototypal inheritance?

Ah, good catch. The method is technically there, as this works:
expect(bar.getFoo()).toEqual("forty-two")

Problem is that it's not captured in the type because the type uses the generated class and not the one you're extending.
function ZodClass(..) {
  return class { .. } // <- the type reflects this type
}

class Foo extends ZodClass(..) {} // <- it needs to be this type

This is a similar problem to why Foo.parse doesn't return an instance of Foo and you need to do Foo.parse<Foo>(). In the types, we don't know about Foo yet.
I'll play with it. Maybe I can solve that problem.

In its most basic form, TypeScript doesn't allow using this in a static context. This could be a problem.
class Foo {
  // Error: A 'this' type is available only in a non-static member of a class or interface.ts(2526)
  static getInstance(): this {}
}

class Bar extends Foo {}

Bar.getInstance() // any

Also can't make it by working around class limitation:
interface FooCtor {
  getInstance(): InstanceType<this>;
  new(): {
    onlyFoo(): void;
  };
}

declare const Foo: FooCtor;

class Bar extends Foo {
  onlyBar(): void {}
}

Bar.getInstance().onlyFoo();
// @ts-expect-error - Property 'onlyBar' does not exist on type '{ onlyFoo(): void; }'.ts(2339)
Bar.getInstance().onlyBar();

Am now thinking that placing the extends method on the generated class is wrong. Instead, we need a helper that can capture the concrete class instead of the abstract one.
E.g.
class Bar extends $(Foo).extend({..}) {}

Here, $(Foo) is operating on the type Foo which includes any methods you add. This should help us work around the problem. It also might be a better way of working in general.

Sidebar: Thinking of other utilities like:
$(Foo).pick("field1", "field2")
$(Foo).omit("field1", "field2")

Came up with a solution: https://github.com/sam-goodwin/zod-class/pull/3

Published as version 0.0.4

Ah, good catch. The method is technically there, as this works:
expect(bar.getFoo()).toEqual("forty-two")

Problem is that it's not captured in the type because the type uses the generated class and not the one you're extending.
function ZodClass(..) {
  return class { .. } // <- the type reflects this type
}

class Foo extends ZodClass(..) {} // <- it needs to be this type

This is a similar problem to why Foo.parse doesn't return an instance of Foo and you need to do Foo.parse<Foo>(). In the types, we don't know about Foo yet.
I'll play with it. Maybe I can solve that problem.

Yeah, that is what I suspected. I attempted to build an interface for an ExtendedZodClass<C extends ZodClass> that would enable returning an instance of ExtendedZodClass<this> which actually did bring back the method reference as far as the linter was concerned, but ran into hangups around the typing for ZodClass at build.

Yeah, that is what I suspected. I attempted to build an interface for an ExtendedZodClass that would enable returning an instance of ExtendedZodClass which actually did bring back the method reference as far as the linter was concerned, but ran into hangups around the typing for ZodClass at build.

I would love to see your approach!

Sure!
First, I declared a barebones interface for ExtendedZodClass:
export interface ExtendedZodClass<T extends ZodRawShape> extends ZodClass<T> {

}

Then, refactored the interface for ZodClass to reflect that change:
export interface ZodClass<T extends ZodRawShape>
  extends Omit<
    ZodObject<T>,
    "parse" | "parseAsync" | "safeParse" | "safeParseAsync" | "extend"
    > {
  extend<U extends ZodRawShape, C extends ZodClass<any>> (
    augmentation: U
  ): ExtendedZodClass<U, ZodClass<U>>;
...

I removed the static attribute from extend's declaration:
...
extend<T extends ZodRawShape, C extends this>(augmentation: T): ExtendedZodClass<C> {
  const augmented = _schema.extend(augmentation);
  // @ts-ignore
  return class extends this {
    static schema = augmented;
    constructor(value: ZodValue<ZodObject<T>>) {
      super(value);
      return Object.assign(this, augmented.parse(value) as ExtendedZodClass<C>);
    }
  };
}

This is something of a mess—I'm pretty bad at generics—but it confirmed a hunch that the static method declaration was causing the interpreter to lose track of the reference to this, as it began recognizing inherited methods and class fields. At build the TS compiler would throw a series of errors around ExtendedZodClass not satisfying the typing for ZodClass, which I wasn't able to work through.
I'm not sure if that approach would really solve the issue of the compiler not knowing about Foo at generation, so your solution is probably the better way.


Tried To Do Some Commands via the wiki and now my entire system is blank?

I was trying to follow the commands in the configuration wiki for hiding the pointer, disabling wifi power mode etc..etc..
and all of a sudden now when I reboot its just a blank screen.....when I right click I'm in something called open box. I can't get back to my desktop. I'd really rather not have to restart EVERYTHING from scratch is there any help someone out there could provide

fixed! I somehow removed everything from the autostart file when adding the in uncluttered command.

can u close this issue

yes, how do I do it? I'm new


implement zip file searching

This shouldn't throw errors in travis and is the first step in solving #743
TODO:

[x] add tests 6dfe7e6
[ ] evaluate whether the process_zip function can be moved to decompress
[x] remove decompress_zip 6bb3156
[ ] add ability to read and process vcsignore files within a zip file
[ ] test it with valgrind (not sure if I freed all buffers)

That's it just from the top of my head
At this point i'm able to compile and run ag and to search i.e. my epub lib^^

TODO:

[x] add tests
[ ] evaluate whether the process_zip function can be moved to decompress
[ ] remove decompress_zip
[ ] add ability to read and process vcsignore files within a zip file
[ ] test it with valgrind (not sure if I freed all buffers)

Changes made in 67555b4
I've made zip support completely optional and disabled by default.
Furthermore travis only checks zip builds in the zip branch

Hm, maybe I'm missing something?
I've run compiled binary
git clone https://github.com/jschpp/the_silver_searcher
cd the_silver_searcher/
./build.sh
sudo make install
zbstof@Stas-MacBook-Pro:~/Work/the_silver_searcher$ ./ag -z ZoneInfoCompiler ~/.m2/repository/joda-time/joda-time/
ERR: Zip files not yet supported: /Users/zbstof/.m2/repository/joda-time/joda-time/1.6/joda-time-1.6.jar
ERR: Zip files not yet supported: /Users/zbstof/.m2/repository/joda-time/joda-time/2.2/joda-time-2.2.jar
/Users/zbstof/.m2/repository/joda-time/joda-time/2.2/joda-time-2.2.pom
204:          <mainClass>org.joda.time.tz.ZoneInfoCompiler</mainClass>

As you see, I cannot search zip files.

@zbstof I made it optional to compile ag with zip support to compile ag with zip support run
./build.sh --enable-libzip
The reason for this change is, that to compile the zip parts at least libzip-1.0 is needed. Ubuntu ships libzip-0.10-1 in the precise release. Since travis is using precise I need to compile libzip from scratch. @ggreer pointet out that testing ag would depend on the availability of the libzip website. Since that is not really optional I made the above change in 67555b4

I'm closing this to reopen it from my zip branch


Some cleanup in the heroes realm.

Another potentially worthwhile cleanup would be to privatize more of the API.  I think only Hero and HeroController (and CreateRectTween) need to be public.  Perhaps HeroHandle, HeroParty, HeroState, Hero.of() could be private.


feat: improve dynamic link contracts' tests and add them to github workflow

Description
This PR improves dynamic link contracts' tests and adds them to github workflow.
Types of changes

[ ] Bug fix (changes which fixes an issue)
[x] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[ ] I have updated the documentation accordingly. (not needed)
[x] I have added tests to cover my changes.
[x] The PR title and commits are followed conventional commit form.

Please add the changelog about this PR if necessary.

@zemyblue

Please add the changelog about this PR if necessary.

In our repository, CHANGELOG will be edited when the version bumps. So I think it is unnecessary. Isn't it right?

@zemyblue

Please add the changelog about this PR if necessary.

In our repository, CHANGELOG will be edited when the version bumps. So I think it is unnecessary. Isn't it right?

OK


[stable/external-dns] Update externaldns chart to 0.5.0

What this PR does / why we need it:
Upgrades the version of ExternalDNS installed by the external-dns chart to v0.5.0
Special notes for your reviewer:
Added the pod permission into the RBAC authorization as per https://github.com/kubernetes-incubator/external-dns/pull/538
I updated the patch version of the chart to make the minimal required version change, if this should be considered semver-minor, I can change it to that.

/assign @prydonius

/assign @linki

/ok-to-test


test pint version

[ ] Closes #xxxx
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

Indeed is pint.


Navigation page

Basic navigation page design.

I made all necessary changes to this branch according to reviewers comments. Therefore, I am merging this branch with main and closing this issue.


Add PyChart 1.39 as pychart in the Python packages

I'm rather new to NixOS and nixpkgs but would like to add some python packages such as this one: PyChart (latest version 1.39 from http://home.gna.org/pychart/)

Description updated.

Ah, please use a sha256 has instead of md5 and squash the commits. Otherwise the PR looks fine!

Not sure why the build failed on the commit. I'd be tempted to just close this PR and create a new one to trigger a new build.
If not I can look at it later but I don't understand the error (yet). Nor what I has to do with my change of adding pychart.
I was able to nix-build -A dictdWiktionary locally.
I was not able to run ./maintainers/scripts/travis-nox-review-pr.sh build locally (I'd need to check my system configuration) nor nix-build pkgs/top-level/release.nix -A tarball (not sure if that should work but I see: /nix/store/frmyf8fdq5xhm035mr87wn6kj0c278g7-stdenv/setup: line 851: 38017 Killed                  NIXPKGS_ALLOW_BROKEN=1 nix-env -f pkgs/tr * --system --meta --xml > /dev/null)
The info from the Travis CI is:
error: while querying the derivation named ‘dict-db-wiktionary-20140118’:
while evaluating the attribute ‘args’ of the derivation ‘dict-db-wiktionary-20140118’ at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/servers/dict/dictd-wiktionary.nix":5:3:
while evaluating the attribute ‘text’ of the derivation ‘wiktionary-builder.sh’ at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/build-support/trivial-builders.nix":10:14:
cannot coerce null to a string, at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/servers/dict/dictd-wiktionary.nix":14:49

Some more details:
...
lrwxrwxrwx 1 travis travis 66 Jan 19 13:05 result -> /nix/store/0nnmyvj574dmqbw76311wqfx52zb2m82-python2.7-pychart-1.39

=== Checking tarball creation
these derivations will be built:
/nix/store/j4ld9vlnldrmwk8blw7a3snza8lpbfxb-nixpkgs-tarball-15.05pre1234.abcdef.drv
these paths will be fetched (4.00 MiB download, 16.07 MiB unpacked):
...<cut>...
building /nix/store/9yy7k0fxrqaj8bpcbzmb9a69a52qm41n-nixpkgs-tarball-15.05pre1234.abcdef
unpacking sources
unpacking source archive /nix/store/4c0bi12idc3mwmkayjsk7bbd28vn8gjs-nixpkgs
source root is nixpkgs
patching sources
autoconfPhase
No bootstrap, bootstrap.sh, configure.in or configure.ac. Assuming this is not an GNU Autotools package.
configuring
release name is nixpkgs-15.05pre1234.abcdef
building
no Makefile, doing nothing
running tests
warning: you did not specify ‘--add-root’; the result might be removed by the garbage collector
warning: you did not specify ‘--add-root’; the result might be removed by the garbage collector
checking pkgs/top-level/all-packages.nix on i686-linux
checking pkgs/top-level/all-packages.nix on x86_64-linux
checking pkgs/top-level/all-packages.nix on x86_64-darwin
error: while querying the derivation named ‘dict-db-wiktionary-20140118’:
while evaluating the attribute ‘args’ of the derivation ‘dict-db-wiktionary-20140118’ at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/servers/dict/dictd-wiktionary.nix":5:3:
while evaluating the attribute ‘text’ of the derivation ‘wiktionary-builder.sh’ at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/build-support/trivial-builders.nix":10:14:
cannot coerce null to a string, at "/tmp/nix-build-nixpkgs-tarball-15.05pre1234.abcdef.drv-0/nixpkgs/pkgs/servers/dict/dictd-wiktionary.nix":14:49
build time elapsed: 0m0.041s 0m0.041s 1m1.819s 0m2.538s
builder for ‘/nix/store/j4ld9vlnldrmwk8blw7a3snza8lpbfxb-nixpkgs-tarball-15.05pre1234.abcdef.drv’ failed with exit code 1
error: build of ‘/nix/store/j4ld9vlnldrmwk8blw7a3snza8lpbfxb-nixpkgs-tarball-15.05pre1234.abcdef.drv’ failed
The command "./maintainers/scripts/travis-nox-review-pr.sh build" exited with 100.

Done. Your build exited with 1.


"Room Occupants" count increased sometimes when a user leaves the room.

I'm not sure if this because I have a user in my user list with escape sequences in their name. (we're running mod_auth_phpbb3.lua with Prosody to allow users with spaces etc in their names to still authenticate. They are automatically escaped... so "Joey Vega" would end up as "Joey\20Vega" etc. http://prosody.im/pastebin/41b9deec-7ebc-4f7a-85c2-57bd9668c075 )
I thought this only appeared in Firefox, but I now see it in both Chrome and IE9 as well... so apparently it's not just Firefox.
http://i32.photobucket.com/albums/d12/phreadom/roomcount5.png
And right now there are 8 people in the room, but it shows 30 etc. (Chrome and IE each show 24, since I joined with those later)
What suggestions would you have for how I might track this down? I don't see anything immediately suspicious in the Firefox web console log.
I have a number of other issues to work out with the escaped username, but I haven't started tackling that yet. (for instance you can't private message them. but I'll file those in a separate issue.)

@jstressman: Could you already try the latest dev version?

I was trying to figure out how to correctly overwrite functions before I put that on the production server to test.
I suppose I could just manually make the changes as before and run with it, since I already know the xep 0106 branch works on my development server and I want to get that rolled out as well.
I'll go ahead and see if I can get this rolled out tonight and update with my findings.

If you need some more infos about the way on how to correctly overwrite functions, please don't worry about asking :) (But maybe on the mailinglist).
Would be nice to hear if it works with this fix included. But maybe we need some additional fixes.

Well, after an initial hiccup of grabbing the wrong code and wondering why it was still broken, it appears that it's working now with the actual dev code. :)
I'll keep an eye on it throughout the day, but it looks like that probably fixed it.

Great, please keep us up-to-date! :-)

Ok, final update on this... it's 14 hours later and the user count in the chat is still correct (even after heavy use), so I'd say that pretty definitively fixed it.

Good to hear!
@pstadler: I think a new release would be good. But maybe the anonymous connection needs a fix before that (see candy support #155).

@jstressman: great! :-)
@mweibel: is this a problem of Strophe?

@pstadler: Not sure yet


Ideas/discussion around source map support in Nuxt 3

Source map support seems to be an afterthought in so many JS frameworks, ranging from completely nonexistent to partially implemented. Nuxt 3 has the opportunity to set the bar high by offering world-class support for source maps. Below are some
ideas/suggestions based on my extremely frustrating experiences in the past.
First off, some commonly-seen issues with source map implementation in various frameworks:
No control over bundling in Lambda function
This is problematic because .map files* are created at the same level of the source code, and included in the Lambda ZIP bundles, which can significantly impact bundle size (and cold start times).
*Throughout this post, we'll assume code is inline in .map files.
No ability to define output path
This is an option I've yet to see in any JS framework. Since many people use third-party error reporting services like Sentry, it would be ideal if we could set a path to dump .js and .js.map files to, at which point the deployment script could upload those to whichever service the developer prefers. Folder hierarchy should, of course, be preserved.
Current workarounds for this are to write esbuild plugins, like the one I've written (below). This obviously is not great DX (developer experience). This functionality ought to be provided out of the box.

Example esbuild plugin to write source maps

/* eslint-disable @typescript-eslint/no-var-requires */
/* eslint-disable max-len */
const fs = require('fs');
const path = require('path');

const sourceMapsOutDir = './.build/sourcemaps';
const srcDir = 'src';

module.exports = [
  {
    name: 'create-sourcemaps',
    setup(build) {
      build.onEnd(({ metafile }) => {
        if (metafile.outputs) {
          const files = Object.entries(metafile.outputs);
          let sourceMapPath;
          let sourcePath;
          let partialPath;

          for (const file of files) {
            if (/\.map$/.test(file[0])) {
              sourceMapPath = file[0];
            } else {
              sourcePath = file[0];
              partialPath = path.parse(file[1].entryPoint).dir;
            }
          }

          if (
            partialPath !== srcDir &&
            !new RegExp(`^${srcDir}/`).test(partialPath)
          ) {
            return;
          }

          if (!sourceMapPath) return;

          const destDir = `${sourceMapsOutDir}/${partialPath}`;

          fs.mkdirSync(destDir, { recursive: true });
          fs.copyFileSync(
            sourceMapPath,
            `${destDir}/${path.parse(sourceMapPath).base}`
          );
          fs.copyFileSync(
            sourcePath,
            `${destDir}/${path.parse(sourcePath).base}`
          );
        }
      });
    },
  },
];

Example tree output:
.build/sourcemaps
└── src
    └── lambda
        ├── auth
        │   ├── cognito-email-sender.js
        │   └── cognito-email-sender.js.map
        ├── graphql
        │   └── data-sources
        │       ├── track.js
        │       └── track.js.map
        ├── media-processor
        │   └── functions
        │       ├── audio-proc-step-func
        │       │   ├── cleanup.js
        │       │   ├── cleanup.js.map
       (etc.)

After this build & deploy step, the source maps would be uploaded to Sentry:
$ yarn sentry-cli releases --org XX --project YY files $SENTRY_RELEASE upload-sourcemaps .build/sourcemaps

These are the two biggest shortcomings I can think of, and they should be relatively easy to solve by adding these as config options, e.g.:
// Options shown with ideal default values
export default defineNuxtConfig({
  /**
   * If false, source maps are saved to .output/sourcemaps folder. If true,
   * source maps are saved next to code and would be bundled & deployed to
   * server & client.
   */
  bundleSourceMaps: false,

  /**
   * Default is 'sourcemaps' and is relative to .output dir.
   */
  sourceMapOutputDir: 'sourcemaps',
});

Challenges
As I'm not well-versed with SSR, I'm not sure how source maps would work with server-side & client-side code.
Please let me know if I've missed anything important! It would be good to have others weigh in on this topic, too.

Would also be interested in this to get source map support in Sentry without exposing them directly with the bundle.
For reference, here is how Sentry suggests integrating with Vite:
https://docs.sentry.io/platforms/javascript/guides/vue/sourcemaps/uploading/vite/

I'm also having this issue, it seems like the source maps are uploaded but Sentry doesnt recognize the uploaded debug ids.See https://github.com/getsentry/sentry-javascript/discussions/9459#discussioncomment-7530582


"Field should have snake_case name" warnings in query! macro

Bug Description
If a table uses non-snake_case column names, rust-analyzer will scream at you in the query! macro.

It should probably be possible to generate a #[allow(non_snake_case)] somewhere in the macro.
Minimal Reproduction
A small code snippet or a link to a Github repo or Gist, with instructions on reproducing the bug.
Info

SQLx version: 0.7.3
SQLx features enabled: ["postgres", "runtime-tokio", "time", "tls-native-tls"]
Database server and version: Postgres 15.6
Operating system: Windows 11
rustc --version: rustc 1.78.0-nightly (a84bb95a1 2024-02-13)

This can be closed, it should be fixed because of #3454


makeffv1 - losslessness is not recorded in log!

You should probably add that.

uh.. this was added the whole time https://github.com/kieranjol/IFIscripts/commit/ebb02ca33945e705d7f7b2fc8a52cf335bb667bc


[ISSUE #8879] reduce seach key times in method,to import performance

Which Issue(s) This PR Fixes

Fixes #8879
Brief Description

How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.55%. Comparing base (dd62ed0) to head (50f53b1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8880      +/-   ##
=============================================
- Coverage      47.61%   47.55%   -0.07%
+ Complexity     11752    11734      -18
=============================================
  Files           1304     1304
  Lines          91043    91053      +10
  Branches       11675    11676       +1
=============================================
- Hits           43354    43300      -54
- Misses         42352    42411      +59
- Partials        5337     5342       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

If refactoring this part of the code, it might be simpler to use ConcurrentHashMap instead of HashMap.

ok, I will chage this code

   private boolean isFieldNullable(Field field) {
        return ConcurrentHashMapUtils.computeIfAbsent(NULLABLE_FIELD_CACHE, field, input -> {
            Annotation annotation = input.getAnnotation(CFNotNull.class);
            return annotation == null;
        });
    }

i think is't using HashMap ok ,it just lock in put value, but in more times  just get value


Player can't deal with the screen before impoppable and chimps mode

Hello, I wanted to let you know that I adore your bloons bot. I wanted to see if there was anyway you could implement a method that clears the menu screens that popup after the map has loaded for given modes. My current solution to this is to try and place a phantom dart monkey after the screen arrives which has caused some issues.

Thank you, glad you like it. This issue should be fixed properly. If you want to send me scripts for impoppable/chimps I'd be interested to see what you've come up with.

Sure just let me know the best way to send you the scripts is and I'll send what I came up with

Putting them here should be okay. If they are prohibitively long, you could upload a file somewhere and drop the link here.

I've made a discord server now. Feel free to join the discourse https://discord.gg/uJfudc3RfV


ScrollContainer Add a new scroll_mode to only allow scrolling in code

There has been this issue with the scroll container for as far as I can remember where you cannot hide the
scroll bars without a hacky solution and you cannot disable mouse/touch scrolling even when the scroll bars are hidden.
And while #48008 solved the first issue by allowing users to hide the scroll bars, we still cannot disable scrolling even when a scroll bar is hidden, check this example project:
scroll container.zip
As you can see, setting the vertical scroll bar to SCROLL_MODE_SHOW_NEVER doesn't prevent users from using the mouse wheel or touch on mobile to scroll anyway, this is annoying because sometimes you would want to customize scrolling by using a UI for example (like the buttons in the example project) or simply not allow scrolling at all even if items overflow..
Another practical example I ran into in the past is when I was working on a Trello like addon, where you can organize tasks and TODOs just like in Trello, all panels where parented by one scroll container and I wanted to make it so that the only way to move around is to move the mouse close to the edge of the screen as you can see:
https://user-images.githubusercontent.com/69814029/209445434-8a8d17e0-f2b9-4e81-b419-beff25dcf446.mp4
But users can just scroll with the mouse wheel anyway even though I didn't want them to, I had no control over that
So what this PR does is allow the user to completely disable scrolling even if the container has overflowing children by introducing a new scroll mode called SCROLL_MODE_MANUAL, when this mode is used in vertical or horizontal scroll, the bar will become hidden, overflowing children will be hidden (unlike SCROLL_MODE_DISABLE) and scrolling input will be ignored (unlike SCROLL_MODE_SHOW_NEVER). and this should allow the user to customize how players scroll, like the idea in the video for example.

why is git showing all my previous activities on the forked repo? weird...

@DissonantVoid you probably didn't make a branch when forking, just forked to master, and made a PR from there. Or maybe something went wrong with branches. I've been in a similar situation with another fork :)

If anything, I think this should be a separate scroll mode. A property that only works with SCROLL_MODE_SHOW_NEVER is hardly useful...
Also if you want a scrollable canvas with manual scrolling, you can just use PanelContainer inside a Control with clipping enabled and move its position. It's effectively the same.

I agree that adding a new variable for this may not be the best idea, an additional scroll mode is a better idea, something like SCROLL_MODE_SHOW_NEVER_NO_SCROLL or simply SCROLL_MODE_MANUAL
I know this can be done in other ways, it's always going to be some additional work that doesn't feel as clean nor godot-like (by godot-like I mean how godot is always simple and user friendly). like the way you suggested which requires an additional node and requires the implementation of scrolling + the tool code for editor visualization. not saying it's terribly difficult but having such functionality out of the box would come in handy!

I don't believe a new scroll mode like that makes much sense. If you only want to scroll from code, you can just as well implement your own scroll container, it's not that hard to do, and it's a perfect opportunity to use a custom container. Godot provides a way to create them for a reason, you are not expected to only ever use built-in nodes.
I think there could be a dedicated property to disable scrolling with mouse wheel / touch. That way a user could choose to do this as a granular option. What you propose here disables most of the unique functionality of the node all together. That makes the use of the node in the first place quite questionable.
We could also implement some sort of OverflowContainer that would only handle the overflow functionality, while ScrollContainer could extend that and add scrollbars and MW/touch scrolling to the mix. You'd use it to have that stripped scroll container functionality without any scrolls or scrolling input events. Though that sounds like a proposal territory at this point.

Commits needs to be squashed properly.

Check this document if you have issues with squashing:
https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

Apologies for the mess, I still don't fully understand what happened there but everything I did made even a bigger mess and it snowballed from there lol. I fixed it now, sorry..
@YuriSizov I guess you're right, a custom container can do the job.
my argument is that the fact that you cannot change the scroll behavior, like how you can't disable scrolling or change the scroll input to something else is a bit annoying to me, I think it lacks customizability in that regard. as someone who often works on ui apps I've already ran into this issue a couple of times, and maybe it's just me but I think it's more reasonable to add that option with a bit of code than to have to make a custom container that is programmatically like 90% the exact same thing as a ScrollContainer just so we can change the scroll behavior/input, besides I don't think it's uncommon to want different kinds of scrolling behaviors in different games/apps like having a menu that scrolls vertically but can't scroll horizontally until you unlock a new skill tree (something that would be ruined by users shift scrolling) or using UI buttons to auto scroll to next item on mobile (again users can just ignore that and scroll as they please) etc.. it's the lack of control that pushed me to make this PR.
So long story short I personally think, based on my experience so far that this is a much needed feature.
One last thing, I'm not very familiar with this process, how do you usually resolve things like this? where someone wants some feature/change while someone else don't. do you run a poll of something?

it's more reasonable to add that option with a bit of code than to have to make a custom container that is programmatically like 90% the exact same thing as a ScrollContainer just so we can change the scroll behavior/input

Scroll behavior and input handling is what the majority of the code is in there. If you want to completely disable that, your remaining implementation will be small. Containers have a dedicated method for positioning children as one of the main configuration tools. You would only need to add an extra offset in there, et voila, you have scrolled content.
Now, if you want to dynamically change between a locked state where users couldn't interact but the rest stays the same and an unlocked state where users can interact normally, then I can see a point of introducing some DISABLE_OVERFLOW mode to prevent scrolling but keep the overflow of content.

I'm not very familiar with this process, how do you usually resolve things like this? where someone wants some feature/change while someone else don't. do you run a poll of something?

You need to open a feature proposal when suggesting a new feature or an improvement of an existing feature. We can be lenient sometimes when a PR is directly created without a proposal, but as a general rule you always must make one. A proposal is a place where you'd argue in favor of your suggested feature, provide references to previous discussions, if there were any, to demonstrate relevance, and explain the technical side of things (it helps that you've already implemented it, but that's not a requirement, especially for more complex features). Then it's public discussion.
A highly upvoted proposal doesn't necessarily mean that the feature goes in. It's still up to maintainers to decide if it makes sense, or if there is a better way, or if it doesn't fit the design of the engine. But public opinion is taken into account.

Here's all you need to make a container with scrolling behavior:
@tool
extends Container

@onready var panel: Panel = $Panel

@export var scroll := Vector2():
	set(v):
		scroll = v
		queue_sort()

func _init() -> void:
	sort_children.connect(do_sort)

func do_sort():
	panel.position = Vector2()
	panel.size = size

	for child in panel.get_children():
		if not child is Control:
			continue

		child.position = -scroll

Example scene:
FakeScrollContainer.tscn.txt

It's not as sophisticated as ScrollContainer, but gets the job done. The Panel node is for convenience to draw stylebox and simplify the sorting behavior.


Can't reach Database from Vercel

I don't know is this a Vercel issue but when I try to connect pockethost from my vercel deployment it doesn't work, works fine on localhost. This the error I get, and admin credentials are true.
Error on signin ClientResponseError 400: Something went wrong while processing your request.
    at /var/task/.next/server/chunks/19.js:1:32488
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  url: 'https://yemek-oyla.pockethost.io/api/admins/auth-with-password',
  status: 400,
  response: {
    code: 400,
    message: 'Something went wrong while processing your request.',
    data: { identity: [Object] }
  },
  isAbort: false,
  originalError: {
    url: 'https://yemek-oyla.pockethost.io/api/admins/auth-with-password',
    status: 400,
    data: {
      code: 400,
      message: 'Something went wrong while processing your request.',
      data: [Object]
    }
  }
}

It looks like I was trying to authenticate as admin in where I shouldn't try to, it's weird that it works on local but not on vercel but it's working now and it's problably not an pockethost issue.


Update bolt_ppc64.go

Missing variable on ppc64 arch. Not sure if it should be true or false?

Fixed in #618.


test_unsendable in test_class_basics is not run

https://github.com/PyO3/pyo3/blob/3c24d27a66b9fd8fb6a3b2c7ed1e0d45eb098084/tests/test_class_basics.rs#L198-L225
it's missing #[test]. I think this is probably a mistake, since there's no comment explaining it.

It's used in the two tests directly below it, but maybe a better name / comment is a good idea.

Well. That's embarrassing!


[Task]: Fix race condition in search

Task description
If you search for 0x5f73f9666cc25bbbf553d71ff73034a61cb3f089214ff530c5b2909f35fce341ed680000 it sometimes finds a slot, when in reality is a tx

Needs a chronicle bug fix: https://github.com/iotaledger/inx-chronicle/issues/1387

fixed with chronicle PR https://github.com/iotaledger/inx-chronicle/pull/1388


descriptor_record is a list of dicts

There is no key named ["concepts"] in any dictionary within descriptor_record which is a List[dict] rather than a dict as the code seems to expect.
P.S: @cthoyt

How do I check that? All I ran is
import pyobo
df = pyobo.get_sssom_df(resource)
df.to_csv(output_file, sep="\t", index=False)

It takes a long time to run. It is currently stuck at:
INFO: [2023-07-26 14:54:44] pystow.utils - downloading with urllib from http://snomed.info/sct/900000000000207008/version/20200131 to ../.data/pyobo/raw/snomedct/2020-01-31/20200131

Do I need credentials for snomedct? I did get credentials for icd10.

There a setting for this function to turn off name lookup and make it faster

There a setting for this function to turn off name lookup and make it faster

There doesn't seem to be an if condition or a flag for processing get_name() if that is what I should be looking for:
https://github.com/pyobo/pyobo/blob/3013564266efa4c82db95791f2f0b4b6a3e41630/src/pyobo/api/xrefs.py#L104-L155

@cthoyt : I managed to get the command to run entirely. I managed to do so after adding a filter to the DataFrame in get_sssom_df()
df = df[~df["target_ns"].isin(["icd10","snomedct"])]

The reason I did so was because in the for loop, when a row in df had target_ns equal to either of these 2, the program appeared to halt. I could be totally wrong and it could be taking a long time to get the data but it seemed too long and the % bar seemed to be frozen at 0%. I created a login for ICD10 to get access to their resources via an API token.
Question:

Do I need to do the same for SNOMED-CT?
Would waiting longer (>2 hours) complete this process?

When I’m back next week I can update this function to have a flag to not look up labels

@hrshdhgd thanks for pointing this out. I was finally able to look into the data itself and it appears that the MeSH 2023 data has changed its structure. I updated your code to remain backwards compatible with 2022 and earlier data.


Update "Contributing to Monero" page

Please review and comment.

I agree about Development probably being better word here.


Using pygments as a lexer

I need to write several small, not-full-featured programming language parsers for https://github.com/nexB/scancode-toolkit
Some examples include parsing Ruby gemspac and Gemfile and similar formats.
One approach would be to use available Pygments lexers that already know how to tokenize many languages alright and then feed that to a custom grammar to recognize the parts I am interested in.
Could I feed an existing stream of Token (adapted from pygments own Token type) to use with lark?

Yes, it's possible.
See this example: https://github.com/lark-parser/lark/blob/master/examples/custom_lexer.py
However, I think lexing is almost always the easy part. The hard part is to define the grammar itself.


Ingress Controller is Intercepting Traffic

Hi, I can connect to the VPN, and then I cannot access internal services by DNS or IP address.
I did hit some IP addresses of pods and get the 'default backend' from Ingress Controller. This leads me to believe the traffic is being treated by kubernetes as external. I'm not sure what to do, but I'm assuming some configuration might be necessary to either allow VPN IP addresses, or make VPN IP addresses use internal range...
I'm using Weave for CNI networking and their default CIDR, which I used as the pod network.

Please provide some examples of what you're doing (terminal output). You should be able to connect to pods or services directly using the cluster DNS / cluster IP's. Example (for a service thats running a HTTP service on port 80):
curl -vv $service.$namespace.svc.cluster.local

I haven't tested this with weave but it should behave just like any other CNI.

On VPN Connected client
curl -v weave-scope-app.default
* Rebuilt URL to: weave-scope-app.default/
* Could not resolve host: weave-scope-app.default
* Closing connection 0
curl: (6) Could not resolve host: weave-scope-app.default

On the cluster machine using service IP
root@kube-master:/home/sam/kube-openvpn# curl weave-scope-app.svc.cluster.local
curl: (6) Could not resolve host: weave-scope-app.svc.cluster.local
root@kube-master:/home/sam/kube-openvpn# kubectl get svc
NAME              CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
heketi            <IP_ADDRESS>   <none>        8080/TCP   3d
kubernetes        <IP_ADDRESS>      <none>        443/TCP    8d
weave-scope-app   <IP_ADDRESS>    <none>        80/TCP     8d
root@kube-master:/home/sam/kube-openvpn# curl <IP_ADDRESS>
<!doctype html>

    <meta charset="utf-8">
    <title>Weave Scope</title>
    <meta name="description" content="">
    <meta name="viewport" content="width=device-width, initial-scale=1">
  <link href="style-app-973dbbbf1a30796b0126.css?dd3864be5377376667e7" rel="stylesheet">

``

Something is wrong with your (local) DNS configuration.
Can you access the kube-dns service directly?  			IN	A
;; ANSWER SECTION:
<IP_ADDRESS>.		0	IN	A	<IP_ADDRESS>
;; Query time: 0 msec
;; SERVER: <IP_ADDRESS>#53(<IP_ADDRESS>)
;; WHEN: Wed Mar 15 17:50:06 GMT 2017
;; MSG SIZE  rcvd: 55

That's not resolving the service through kube-dns but is in fact using your local resolver.

;; ->>HEADER<<- opcode: QUERY, status: REFUSED, id: 1572

It seems your kube-dns is using a different serviceip.

OK, so perhaps I need to change configuration to manual DNS, I could try adding kubernetes NS to /etc/resolvconf/resolv.conf.d/base and see what happens

There does seem to be some issues here, with the networking. Surely I should be able to access service IPs if I am local in the network.
nslookup weave-scope-app.default.svc.cluster.local <IP_ADDRESS>
;; connection timed out; no servers could be reached

I think somehow my traffic is being firewalled / blocked somewhere in the network when accessing internal IPs...
I can for example curl a mongoDB running natively inside the LAN of the kubernetes host machine
curl <IP_ADDRESS>:27017
It looks like you are trying to access MongoDB over HTTP on the native driver port.

##UPDATE
So I've tried this on my old mac, as well as my current Linux machine, and the mac is able to resolve DNS with nslookup weave-scope-app.default.svc.cluster.local <IP_ADDRESS> and I can then access the given IP address in web browser...

It looks like you're using some linux NetworkManager client that's not working? This works for me, so let me know if you need any more help / if i can add some FAQ entry regarding linux.


New async code hiding uncaught exceptions?

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.33.0.dev0
Python release (python3 --version):
Python 3.4.2
Component/platform:
discovery
Description of problem:
Discovery stopped working after the dependency update to netdisco-0.7.6 with no visible errors in any of the home-assistant logs. It starts a scan, but never returns any discovered devices.
Only when I manually ran the netdisco discovery did I see a traceback that port 1900 could not be opened (home-assistant/netdisco#64).
Expected:
To see some indication that a thread/process failed because of an uncaught exception.
Problem-relevant configuration.yaml entries and steps to reproduce:
discovery:

Run home-assistant on a system that is already using port 1900.

Traceback (if applicable):
...If only there had been one...
Additional info:

If I remember correctly discovery is running in its own thread outside the loop. Not sure why that doesn't get logged.


feat(typescript): Added typescript definition file

What:
Added Typescript definition.
Why:
We wanted to use it for snapshots with out typescript tests.

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines          92     92
  Branches       17     17
=====================================
  Hits           92     92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c251b1e...ef887f8. Read the comment docs.

ping? :)

Sorry about the lack of responses on this pr.
Looking at the current documentation this pr is not useful anymore given this is used via adding to the jest config.
The advantage of having type defs when you had to do something like follows is that without them your tests won't compile if you are using typescript with strict settings.
import {matcher, serializer} from 'jest-glamor-react'
expect.addSnapshotSerializer(serializer)
expect.extend(matcher)


Remove dead link to El Capitan and Homebrew problem

El Capitan and Homebrew problem was fixed by further OS X updates
Document was removed from Homebrew docs: https://github.com/Homebrew/homebrew/commit/dd1625af7a10588fc8679a060de0bda60985b0ab

Thanks! Merged.


Support for complex (struct) arguments

Is your proposal related to a problem?

Currently the config file only allows for the arguments to be of the following types: uuid, randomString$length, randomNumberA_B. However chain codes can also take structs as the arguments instead for using just a list of variables. I have found that using structs instead of positionall arguments is a bit more reliable way to prevent errors when passing parameters.
Describe the solution you'd like

Allow for parameters to take the shape of a yaml object using the same random types to populate the fields
Describe alternatives you've considered

I currently am using hyperledger caliper as its workflows supports arbitrary parameters types

tape uses golang language, hence is there any go library which supports arbitrary parameters types? fozz?

but how to define the structure in yaml and make golang auto generate the random value via fuzz?
or we want the value in a specific range or ... some thing to make the test meaningful?

@Nova38 , could you please try with comments at https://github.com/hyperledger/fabric-chaincode-go/issues/101#issuecomment-2003731587 ?

@Nova38 , as tape support json format of input https://github.com/Hyperledger-TWGC/tape/blob/master/pkg/infra/trafficGenerator/proposal_test.go#L47 , please help a try and feedback.

Fantastic thank you! I will try it out this week

Fantastic thank you! I will try it out this week

hi @Nova38 , any feedback or result?


Angular2 rc.6 implementation

Hi,
Is it possible to make it work with Angular2 rc.6?
Regards,

Look #26

Thank you for your reply (and your job!)


General Grievance: Watch theonepiecemangaonline.com

General Grievance requests the watch of the watch_keyword theonepiecemangaonline\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

theonepiecemangaonline\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Clarify that Deploy to OpenShift uses odo

Closes #372
Signed-off-by: David Thompson<EMAIL_ADDRESS>

Thanks for the review, Roland!


Add some chaining support to request and response

https://github.com/salvo-rs/salvo/discussions/140

Done https://github.com/salvo-rs/salvo/commit/3765c97c0cf1740c8d19962247861f989f3b01a1


Performance and api improvements for messaging

This commit converts all messages to use shallow copy semantics
for unmarshalling msgpack objects rather than deep copying each
object.

This seems like a worthwhile change to me. I noticed that you're not actually using wamp_message::release_zone() anywhere, which makes me wonder whether it would be slightly nicer to use msgpack::zone's built-in move operator instead of allocating the zone with an extra layer of pointer indirection. Either way, please have a look at my line comments. Thanks!

Thanks Jacob. I will be using release_zone when I submit a pull request for
#20 as well as #21.
On Thu, Oct 8, 2015 at 2:58 PM, Jakob Petsovits<EMAIL_ADDRESS>wrote:

This seems like a worthwhile change to me. I noticed that you're not
actually using wamp_message::release_zone() anywhere, which makes me
wonder whether it would be slightly nicer to use msgpack::zone's built-in
move operator instead of allocating the zone with an extra layer of pointer
indirection. Either way, please have a look at my line comments. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/tplgy/bonefish/pull/19#issuecomment-146654554.

Commit message: "A native transport implementation is still in progress using AutobahnCpp and should be too far behind this commit." -> "shouldn't be"?

Seems sensible in general!  Please have a look and report back!


DSL mixins/facade wrappers

Allows us to call custom DSL methods on any object we are interested in without the object knowing about DSL. Also lets us do chaining.
For example:
attributeWhenReady("targetSensor").attributeWhenReady("mySensor")
attributeWhenReady("anyBrooklynObject").config("myConfig")

Builds on https://github.com/apache/brooklyn-server/pull/482

awesome.  disregard my point on #482 about C-style non-OOP "method" calls.
i think remove DslCallable in favour of @DslAccessible, then merge that.  (can build on this on #482 so it merges all...)

Included the changes in https://github.com/apache/brooklyn-server/pull/482 - too hard to juggle two PRs.


FeatureRequest: Any plans to implement the QR Multi functions - detectAndDecodeMulti?

Expected behaviour
I'd like to be able to use the detectAndDecodeMulti function defined here https://docs.opencv.org/3.4/de/dc3/classcv_1_1QRCodeDetector.html
Actual behaviour
I don't believe this function has been exposed in the python implementation of opencv.
Steps to reproduce

example code

import cv2
def video_reader():
cam = cv2.VideoCapture(0)
detector = cv2.QRCodeDetector()
while True:
_, img = cam.read()
data, bbox, _ = detector.detectAndDecodeMulti(img)
if data:
print("QR Code detected-->", data)
cv2.imshow("img", img)
if cv2.waitKey(1) == ord("Q"):
break
cam.release()
cv2.destroyAllWindows()
video_reader()

operating system
Win10

architecture (e.g. x86)
x64

opencv-python version

opencv-python version <IP_ADDRESS>

If the function has not been exposed, please open an issue to the actual OpenCV repository: https://github.com/opencv/opencv/issues
This repository is just a build toolchain and has no control over OpenCV code level features.


Error while trying to drag object position from the menu

While trying to drag object position from the menu, as you do in your Cuis Smalltalk: Color 1 UI Part 1  ( 8:45 minute) I got an error at  the moment that I move the cursor. The cursos changes to a box with an X, as shown:

I'm using Windows 10, with locale es-MX and an updated Cuis v6 - 5588.

On 2022-12-09 02:59, Ricardo Pacheco wrote:

While trying to drag object position from the menu,

I believe the update to SignMorph in UI-DragAndDrop package fixes this.
Please retest now.
Thanks much for reporting!
-KenD

The update fixed this issue also. Thanks a lot!!

Hello Ken, sorry for asking in a closed issue. But after watching your video Color 2 UI part 2 (5:05) related to this topic, dragging objects from the menu, I see that you take the borderWith number from a Morph and although you get a red X while trying to drop the number on top of the color value, you are able to place it on top of the color  as a box with the number and leave it there for a seconds while you move the mouse and then pick it up again an you place it in the  desktop, before deleting it. In the current implementation I tested after this change, it only presents the red X but the number disappears and is not placed on top of the color. Is that the expected behavior or should I reopen this issue? I find really nice the possibility to place the number somewhere else as a LabelMorph. Could be very useful in some cases.

This is a change.  I found that only allowing drops on fields willing to accept the value (color/number/font/point/..) more consistent and, frankly, easier to implement.  I want things to be useful, but the "drop onto backdrop" did not buy me much, and where does one stop.  E.g. drop a DropColorMorph directly on some random Morph vs dropping only on Color fields in a Morph's menu.
Now a SignMorph has the same behavior as a FontMorph or a DropColorMorph with respect to Drag 'n Drop.
I did not want to torque the code for Morphs.  That is why there is a "Drop Target" available, to be an intermediary between a Morph and some tool-ish action.  If you drop a color onto a DropTarget, it asks how to treat the color.  You can change the color, borderColor, .. or pass.  No Morph code was harmed by this. ;^)
Another user interface problem I had was to make things which are different actually look different.  This is why there is a purple border around dragable color swatches and why visual properties which one can drag are purple.
HTH, -KenD

Yes, you are right. It Is  easy to forget where to stop. Since simple is beautiful, I find reasonable your decision. Thanks for your response.
Richo

Play is important.
When I get ideas, I like to try to get them ruunning in code -- so I learn with failure and gain confidence with success.
One way to learn is to imagine a different way and try to make the code do that.
I found Drag 'n Drop hard, so I try to make something helpful with this.
If you make draggable properties stick to desk top, I guarantee you will learn a lot!  :)


HADOOP-16481. ITestS3GuardDDBRootOperations.test_300_MetastorePrune needs to set region

Change-Id: I26f8e9bc441bd1cb7b0d9b37161984049df6bac4

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
140
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1544
trunk passed

+1
compile
47
trunk passed

+1
checkstyle
30
trunk passed

+1
mvnsite
53
trunk passed

+1
shadedclient
965
branch has no errors when building and testing our client artifacts.

+1
javadoc
35
trunk passed

0
spotbugs
79
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
76
hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1
mvninstall
42
the patch passed

+1
compile
43
the patch passed

+1
javac
43
the patch passed

+1
checkstyle
27
the patch passed

+1
mvnsite
43
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
987
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
88
the patch passed

_ Other Tests _

+1
unit
308
hadoop-aws in the patch passed.

+1
asflicense
37
The patch does not generate ASF License warnings.

4599

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1209

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5ada70474057 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a7371a7

Default Java
1.8.0_222

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
142
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1443
trunk passed

+1
compile
45
trunk passed

+1
checkstyle
28
trunk passed

+1
mvnsite
50
trunk passed

+1
shadedclient
894
branch has no errors when building and testing our client artifacts.

+1
javadoc
31
trunk passed

0
spotbugs
81
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
78
hadoop-tools/hadoop-aws in trunk has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1
mvninstall
39
the patch passed

+1
compile
34
the patch passed

+1
javac
34
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
41
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
847
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
78
the patch passed

_ Other Tests _

+1
unit
288
hadoop-aws in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

4211

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1209

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2efbe3f0b231 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e111789

Default Java
1.8.0_212

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/artifact/out/branch-findbugs-hadoop-tools_hadoop-aws-warnings.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/testReport/

Max. process+thread count
399 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

This is ready for review. @bgaborg -got a chance?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
103
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1238
trunk passed

+1
compile
35
trunk passed

+1
checkstyle
24
trunk passed

+1
mvnsite
34
trunk passed

+1
shadedclient
793
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
67
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
65
trunk passed

_ Patch Compile Tests _

+1
mvninstall
37
the patch passed

+1
compile
29
the patch passed

+1
javac
29
the patch passed

+1
checkstyle
20
the patch passed

+1
mvnsite
33
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
812
patch has no errors when building and testing our client artifacts.

+1
javadoc
22
the patch passed

+1
findbugs
66
the patch passed

_ Other Tests _

+1
unit
283
hadoop-aws in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3738

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1209

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 18ef35084534 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3cc0ace

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/testReport/

Max. process+thread count
342 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1257
trunk passed

+1
compile
31
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
36
trunk passed

+1
shadedclient
713
branch has no errors when building and testing our client artifacts.

+1
javadoc
23
trunk passed

0
spotbugs
62
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
58
trunk passed

_ Patch Compile Tests _

+1
mvninstall
34
the patch passed

+1
compile
26
the patch passed

+1
javac
26
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
761
patch has no errors when building and testing our client artifacts.

+1
javadoc
25
the patch passed

+1
findbugs
75
the patch passed

_ Other Tests _

+1
unit
271
hadoop-aws in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

3539

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1209

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a2a91f184f9a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1209/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thought: we could be collecting stats on observed inconsistencies
Here'd we'd count #of times retried on open/rename

+1; will commit now.

thx


TH16R2 currentTemperature and currentHumidity sonoff_local

Using local mode, I found the same issue where temperature and humidity got renamed to currentTemperature and currentHunidity for some devices.
Same fix applied to sonoff_cloud.py on commit 65f5b026d398acd6758da69a091cfe88d79fe7de (Update POW, TH attrs and Zeroconf) seems to solve the issue for sonoff_local.py.
Basically I have cloned that fix_attribs function from sonoff_cloud.py to sonoff_local.py
At sonoff_local.py I add fix_attrs definition is after "LOCAL_HEADERS" line
LOCAL_HEADERS = {'Connection': 'close'}

def fix_attrs(deviceid: str, state: dict):
......

and I have added a call to fix_attrs to function _zeroconf_handler, in the line before comment about fix issue 110
fix_attrs(deviceid, state)

# TH bug in local mode https://github.com/AlexxIT/SonoffLAN/issues/110
if state.get('temperature') == 0 and state.get('humidity') == 0:

I figured out it has been fixed since commit 8aaa186c55fa49fdf03c4dc5bcbc4f8cbb0e6f2f and it was related to issue #527
Any plans to tag a new release, so we can deploy it automatic from HACS?


Version bump for robustification

Codecov Report

Merging #712 (02f025c) into main (2ee8232) will decrease coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   89.67%   89.01%   -0.66%
==========================================
  Files         166      166
  Lines       13311    13286      -25
==========================================
- Hits        11936    11826     -110
- Misses       1375     1460      +85

see 18 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Someone on the internet is using XCB poorly

Avoid unnecessary round-trip. See https://xcb.freedesktop.org/tutorial/.

With glfw now having Vulkan support I plan on dropping the OS specific stuff anyway. It's the first time I used XCB, so please bear with me.


Update django support

We have two problems:

Some tests are failing after successfully finish.

  py38-django22-graphicsmagick: commands succeeded
  py38-django31-graphicsmagick: commands succeeded
  py38-django32-graphicsmagick: commands succeeded
  congratulations :)
Error: The operation was canceled.

There is a test failing in some envs:

 self = <tests.thumbnail_tests.test_engines.CropTestCase testMethod=test_landscape_crop>

      def test_landscape_crop(self):

          def mean_pixel(x, y):
              values = im.getpixel((x, y))
              if not isinstance(values, (tuple, list)):
                  values = [values]
              return sum(values) / len(values)

          for crop in ('center', '50% 200%', '50px 700px'):
              th = self.BACKEND.get_thumbnail(self.landscape, '100x100', crop=crop)
              engine = PILEngine()
              im = engine.get_image(th)

              self.assertEqual(mean_pixel(0, 50), 255)
  >           self.assertEqual(mean_pixel(45, 50), 255)
  E           AssertionError: 254.0 != 255

We have two problems:
1. Some tests are failing after successfully finish.

  py38-django22-graphicsmagick: commands succeeded
  py38-django31-graphicsmagick: commands succeeded
  py38-django32-graphicsmagick: commands succeeded
  congratulations :)
Error: The operation was canceled.

That's super weird and I'm not sure if that's a new behavior by GHA to cancel test runs when a lot of them fail? At least I don't see any config options in place to have this happen.

1. There is a test failing in some envs:

 self = <tests.thumbnail_tests.test_engines.CropTestCase testMethod=test_landscape_crop>

      def test_landscape_crop(self):

          def mean_pixel(x, y):
              values = im.getpixel((x, y))
              if not isinstance(values, (tuple, list)):
                  values = [values]
              return sum(values) / len(values)

          for crop in ('center', '50% 200%', '50px 700px'):
              th = self.BACKEND.get_thumbnail(self.landscape, '100x100', crop=crop)
              engine = PILEngine()
              im = engine.get_image(th)

              self.assertEqual(mean_pixel(0, 50), 255)
  >           self.assertEqual(mean_pixel(45, 50), 255)
  E           AssertionError: 254.0 != 255

I've relaxed the tests a bit in #667. Could you take a look? I'm closing this PR in favor of #667 since I couldn't push to your branch (I think).


How to acclerate adoption of PSI for Zowe distribution

Request to add PSI (newer z/OS distribution file format) to Zowe code (currently Pax and SMP/E)

I had some internal discussions about this to figure out what might be the best path forward.  The Broadcom team might have the resources and some automation in place that would enable testing of a sample Zowe PSI, to validate the concept and identify any significant obstacles.  I'll get some estimates to see if that can be done.  But ultimately, in order to support the PSI format in Zowe, we need to create some stories on our backlog to build some automation for it, and it might need to be planned for next PI.  Between now and then we can do some research and grooming to make sure we're ready.  Again, we can leverage some expertise on the Broadcom side.  I know that IBM also has some expertise in this area but possibly not as close to the Zowe team as the folks at Broadcom.

Being worked as part of this PI Planning interval - closing this item


Add error module

Closes #14

I personally think, the naming & error message can be improved a lot. @vaibhawvipul But what do you think about the direction we are heading with this PR.

I personally think, the naming & error message can be improved a lot. @vaibhawvipul But what do you think about the direction we are heading with this PR.

Looking good to me so far.


Server Side State

Will be useful in case of large state payloads.
Instead of saving state inline as html tag, store state on server side and inject state hash as html tag.
This feature will decrease amount of data, sent with SSA request and total HTML document size.
Key requirements:

Implement at least in-memory storage
Support for multiple state storages (with interface)
Component-level storage configuration (inline or server-side)

Moving to 0.3, not covered by 0.2 features focus group

I am not that familiar with kyoto yet but see interfaces used for the Actions in the demo code.
do you think a more formalised data structure for this is needed ?
Protobufs can be really nice for this where you want to define a structure.
I was thinking a simple KV structure that is tagged / nested based on a simple namespace.
SO each component has a namespace and then can put whatever it wants.
This is a decent example of the concept: https://github.com/simpleiot/simpleiot/blob/master/internal/pb/node.proto
You can use protobufs over SSE btw.  Its just a serialisation.


Add Across Protocol Bridge contract labels

reference:
https://etherscan.io/address/0x4D9079Bb4165aeb4084c526a32695dCfd2F77381
https://polygonscan.com/address/0x69B5c72837769eF1e7C164Abc6515DcFf217F920
https://arbiscan.io/address/0xB88690461dDbaB6f04Dfad7df66B7725942FEb9C

Thank you!


[#127464417] Use latest release of paas-terraform-provider-pingdom

What
We updated our fork and released new binaries.
Update the pingdom setup script to use the new release, and improve
the docs that describe the build and release process for the fork.
How to review
For some healthy CF deploy, follow the instructions in pingdom.md to set up pingdom checks.
Note the the healthcheck app is deployed in post-deploy not deploy-cf.
Confirm the check appears as expected, e.g. in the webui https://my.pingdom.com - credentials are in paas-pass.
Remove the new checks when you are finished.
Check that the documentation changes make sense.
Who can review
Anyone but @benhyland

LGTM


Any way to parse registry.dat file?

I noticed ExtractContentSample or makemsix can only extract files out, but cannot extract registries.

Oh actually it just a registry hive file...use RegLoadAppKey can load and parse them ;)


functions/helloworld/hello-http

Clean download, mvn clean package results:
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.013 s <<< FAILURE! - in functions.ExampleSystemTest
[ERROR] functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework  Time elapsed: 0.002 s  <<< ERROR!
java.lang.IllegalArgumentException: URI with undefined scheme
	at java.net.http/jdk.internal.net.http.common.Utils.newIAE(Utils.java:244)
	at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.checkURI(HttpRequestBuilderImpl.java:79)
	at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.uri(HttpRequestBuilderImpl.java:71)
	at java.net.http/jdk.internal.net.http.HttpRequestBuilderImpl.uri(HttpRequestBuilderImpl.java:43)
	at functions.ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework(ExampleSystemTest.java:44)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ExampleSystemTest.helloHttp_shouldRunWithFunctionsFramework:44 » IllegalArgument
[INFO]
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0

This is because ExampleSystemTest requires an environment variable FUNCTIONS_BASE_URL to be set. Perhaps the test should be adjusted so that it passes if the variable is not set? Or it should be set up in such a way that it doesn't run by default.

I think it's best to work by default, so you can give it a default value or
output a warning if it's not set.
On Wed, Aug 12, 2020 at 1:29 PM Éamonn McManus<EMAIL_ADDRESS>wrote:

This is because ExampleSystemTest requires an environment variable
FUNCTIONS_BASE_URL to be set. Perhaps the test should be adjusted so that
it passes if the variable is not set? Or it should be set up in such a way
that it doesn't run by default.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/java-docs-samples/issues/3511#issuecomment-673158974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIVLDQUFSWKTNPRTQWCXK3SAMQUFANCNFSM4P5JQCWA
.

--
Les Vogel
<EMAIL_ADDRESS>Staff Developer Programs Engineer
345 Spear Street, San Francisco, 94105
Mobile<PHONE_NUMBER>

Personally, I'm reluctant to have this test "silently pass" if this environment variable is missing, as that might be hard to debug on CI.
I'd be fine with skipping it outright if a certain environment variable (e.g. IS_CONFIGURED_ENV) isn't set. (It won't break CI builds if it's misconfigured, but IMO it will be easier to ID within a build log.)

@lesv ping - thoughts on this?

mvn package should just build the thing.
mvn verify should run tests.
I think you need to make these IT tests.

@lesv I think that's a separate issue? (In any case, it's addressed in #4539)
Eamonn's comment was about this test "silently" requiring FUNCTIONS_BASE_URL.
@eamonnmcmanus the PHP folks have a testing toolkit with a requireEnv function that throws an exception if an environment variable isn't set. Maybe it's worth using (and if necessary, making) such a function for Java? (Ideally, it's something we could import via a separate package.)

@lesv I think that's a separate issue? (In any case, it's addressed in #4539)
Eamonn's comment was about this test "silently" requiring FUNCTIONS_BASE_URL.
@eamonnmcmanus the PHP folks have a testing toolkit with a requireEnv function that throws an exception if an environment variable isn't set. Maybe it's worth using (and if necessary, making) such a function for Java? (Ideally, it's something we could import via a separate package.)

@ace-n I think you're suggesting a way for the meaning of the test failure to be more obvious? But Les and I are saying that unit tests should pass without special configuration.

@ace-n I think you're suggesting a way for the meaning of the test failure to be more obvious? But Les and I are saying that unit tests should pass without special configuration.

Samples in other languages use this variable.
Maybe we could "fall-back" to a default, hard-coded URL that's specific to DPE projects?
(Downside: we may get people testing their code against our projects.)

@eamonnmcmanus reviving this thread - this is not a unit test. (#4539 added the IT suffix accordingly.)
This issue is ooSLO; I'll schedule a meeting to follow up on this.

Resolution
Skip test explicitly if FUNCTIONS_BASE_URL is not set, and System.out.println something like FUNCTIONS_BASE_URL is not set, skipping ExampleSystemIT.


Spelling / conventions and grammar fixes

I've corrected some spelling, grammar & whitespace errors i noticed while in this solution.
Please take a look. Hopefully it will improve the information conveyed to the user / dev.

Thanks, merged 👊