Wishlist: breaking changes to cleanup, well, everything

dns_providers conventions and import cruft

(Since this first one has grown so in the telling, I'm going to make these one topic per message, with a brief title like the above on each one.)
The first thing I ran into was the crazy historical cruft that is sewer.__init__ and sewer.dns_providers.__init__.  All that stuff can be eliminated with trivial changes to cli (which I have to admit is my own main interest, so if you think I've missed something that affects direct API users, please point it out) and a simple if annoying change for API users.  The latter, in terms of the example code:
import sewer
dns_class = sewer.<name of class>
client = sewer.Client

changes very little
from sewer import Client  as client
import sewer.dns_providers.<name of provider>.<name of class> as dns_class

The latter could, and perhaps should, be simplified by moving to the convention of naming the provider's implementation class the same (DnsClass?) and leaving the module name as the distinguishing namespace.  So the import might change to
from sewer.dns_providers.<name of provider> import DnsClass as dns_class

Or even just
import sewer.dns_providers.<name of provider>

and use .DnsClass directly, which might lead to cleaner code if more than one DNS provider is ever used in scripting, since common code could be specialized by a function parameter rather than cut'n'paste'n'edit.

dns class interface

Basically, make the interface allow multiple challenges so that the dns driver can batch them.  The long version would be a sketch of a revised BaseDns, but let's see if I can express the ideas more briefly here.  For me, this all started with reading #91...
The obvious/minimal fix for that specific issue would be to make [create,delete]_dns_record just record the requested change in a list internal to the driver.  This would then require an added method to commit all pending updates, and this is a breaking API change.  Or better, do the batching in cli (or other script) and use a whole new dns API: [add,remove]_challenges to post pending changes in any number as is most convenient for the script, and commit_challenges to actually send them.  NB: this new interface can be trivially implemented in terms of the deprecated create and delete methods by generic implementations in common.py, which is why I prefer a whole new interface rather than changing the internal semantics of create & delete.  The change in name style was first motivated to keep them distinct, but as I thought about it I personally prefer the more semantic name challenges over record.  But I won't insist, that's a bikeshed issue.  :-)
Except for use cases where the batching is important, such as #91, the old interfaces could remain for backwards compatibility, and the new provided by code in BaseDns.

dns driver discovery (this is mostly/all about the cli.py implementation)

There are two issues I have with the way those drivers are handled.  The first topic addressed the import cruft, which is both wasteful and forces at least workarounds in every provider module to avoid having to have the union of all API interface libraries installed in order to run sewer.  The other is having to add not only a new provider module but several cut'n'paste-ish chunks of code just to get the module to be recognized (and here my focus on the cli is most apparent, perhaps).  You have to add

the module
an import in dns_providers.__init__ (actually not necessary?)
an import in sewer.__init__.py
add the module name to a manual list in cli.py
copy'n'paste'n'edit another elif case to the long list of nearly redundant code in cli.py

... I think that was all of them.
The imports are discussed in the earlier rant.  The list of names can be replaced, at the cost of requiring a traditional directories & files install rather than eggs or other oddities, by a simple listdir (filtering a few known names - init.py, common.py, ...) to make the list of valid choices, and then using import_module to actually import the chosen provider's implementation.  That would be in the generic code that takes the module name, imports it, introspects it (wait for that) and invokes it, with exception catching and reporting.  In short, a parameterized version of that many times copied'n'pasted elif code chunk...
Okay, yes, one API change here.  One parameter that's needed in that code is a list of names to be looked for in the environment, and IIRC this also needs to deal with optional ones.  The part that seems obvious here is to add a class attribute that a list of names and a required/optional flag, though in some ways it might be cleaner if it were just a list of names, and ones not found were passed as None - move the sanity/consistency checking into the provider module.  The API changes a trifle, at least formally, to require that those provider-specific parameters be defined as keyword args.  The implementation classes I've looked at all do that already, and cloudflare at least does the sanity checking of the parameters in the driver already.
Oh yes, this almost requires the change mentioned at the end of the API & cruft rant about changing the drivers to all define DnsClass instead of a hodeg-podge of unique names.  Could be worked around by binding the class as defined to the other name, eg.
class CloudFlareDns(common.BaseDns):
    ...
DnsClass = CloudFlareDns

which makes it work either way.  Probably should do it the other way around, make DnsClass the official name and CloudFlareDns for backwards compatibility.
I think/hope that wraps up the dns driver issues I wanted to talk about.  Too tired to continue now in any case.  :-/

Not too bad for such an early vision.  Some of the most important parts are already written and about ready to land in master, with a release to follow.  Another big chunk of it broke off into the provider catalog (#157, though that's had some further changes, too).  So I'm going to close this off as out of date/replaced.


Cutscene Editor and Schema

Cutscene Editor
Refactor Cinematic api endpoints
Update the list view of the cinematic editor
Use id's or slugs to get cutscenes or cinematics

@shubhi1092 Thank you so much for the feedback!


Direct association column type might be BLOB, not INTEGER

Described in https://speakerdeck.com/lvla/ormahamaripointo-star-v2-dot-5-2 (Japanese)

https://github.com/lVlA/OrmaSample/tree/master/app/src/main/java/com/lvla/android/ormaissue295


Notify when account requires entering the server password

When importing accounts we allow the user to skip entering the server password(s). But later we never notify the user that we still require them to enter the password when checking or sending mail.
Somewhat related: #2000

This was fixed by #5581


No longer query users about running curl processes

This is very minor, but I feel users shouldn't be queried about ephemeral processes like the asynchronous instances of curl spawned by Elfeed.
If the processes are old, they will probably time out and there is no harm in killing them. If they are young, then the user's plans presumably changed right after calling elfeed-update, and a query would only serve as an obstruction.
(You may also wish to call set-process-sentinel in the line after the one I added, for consistency.)

Thanks! I was unaware of this issue since 1) the only time I exit Emacs
is when I shut down my computer, and 2) I don't think I've ever exited
during feed updates.


Extracting Citation Sentences Related to Reference Using Grobid

Hi everyone,
I am using Grobid to extract citations from a document PDF. Okay, it is working well, but I want Grobid to also provide citation sentences related to the citations found.
Does anyone have a solution to help me achieve this?
Thank you.

Hello @phat-innomizetech
Use the available parameter segmentSentences when using the service. You can then extract the sentence containing the citation with your favorite XML parser.
You can choose between two sentence segmenter implementations, see https://grobid.readthedocs.io/en/latest/Configuration/#language-processing-implementation


[new design] Don't show Slack information in cards if there is none.

See the API card:

Looks fixed.


Remove GithubReleaseManger from build.cake

Expected Behavior

The release manager is removed from build.cake
Actual Behavior

Mention any other details that might be useful

Steps to reproduce the behavior

The log given by the failure.

solved in #124


Add support for compact keyboards please

I don't have a number pad on my keyboard so I can't do a single thing with this program...

people use numpads still?..

I also have the same issue, I don't have a numpad and this app won't allow for changing the keys

I also have the same issue, I don't have a numpad and this app won't allow for changing the keys

If you change the VK_ codes to different keys in RTSS_Crosshair.cpp and build the project, it should work


Add language to codesample plugin

Currently my codesample plugin has these languages: HTML/XML, JavaScript, CSS, PHP, Ruby, Python, Java, C, C# and C++.
How to edit this in settings.py? I want to add django to that list.

Add this to your TINYMCE_DEFAULT_CONFIG setting:
    'codesample_languages': [
        {'text': 'Django', 'value': 'python'},
    ],

Plugin javascript file:
https://github.com/jazzband/django-tinymce/blob/master/tinymce/static/tinymce/plugins/codesample/plugin.min.js
You will find this code snippet in that javascript file:
            n = s.getParam("codesample_languages") || [
                { text: "HTML/XML", value: "markup" },
                { text: "JavaScript", value: "javascript" },
                { text: "CSS", value: "css" },
                { text: "PHP", value: "php" },
                { text: "Ruby", value: "ruby" },
                { text: "Python", value: "python" },
                { text: "Java", value: "java" },
                { text: "C", value: "c" },
                { text: "C#", value: "csharp" },
                { text: "C++", value: "cpp" },
            ],

Use https://unminify.com/ to make the minified file easier to read.
Related Issue and possibly another method to add more languages:
https://github.com/jazzband/django-tinymce/issues/217


how do i make the expo open the simulator automatically after this  ( pic below ) ?

We're looking to keep questions on our forums and bug reports on our main Expo repo -- please choose whichever you feel is more appropriate for your issue:

Post in our community forums (log in with your Expo developer account): https://forums.expo.io/c/help
File a bug on the Expo repo: https://github.com/expo/expo/issues/new
Request a feature on Canny: https://expo.canny.io/feature-requests

Thanks for reporting the issue you found with exp!

exp start --ios


First working implementation of CacheHelper

First working implementation of CacheHelper, uses Microsoft.Extensions.Caching.Memory - https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.caching.memory.memorycache?view=aspnetcore-2.0

Closing off this branch. CacheHelper is being utilized in the read-json branch now.


No License for project.

Good point, any suggestions on which license we should use? MIT or GPL?

Personaly fond of MIT, but depends on your personal goals and views. There are many good reasons to consider a GPL license or similar.

Added MIT license.


** EXPORT FAILED ** in ios build

When I run ionic cordova build ios -- --buildFlag="-UseModernBuildSystem=0" my app archive was succeeded(** ARCHIVE SUCCEEDED **) but app export was failed showing this
** EXPORT FAILED **.
Before failing it is giving this error in log
`error: exportArchive: No profiles for 'my_app_bundle_identifier.shareextension' were found
Error Domain=IDEProfileLocatorErrorDomain Code=1 "No profiles for 'my_app_bundle_identifier.shareextension' were found" UserInfo={IDEDistributionIssueSeverity=3, NSLocalizedDescription=No profiles for 'my_app_bundle_identifier.shareextension' were found, NSLocalizedRecoverySuggestion=Xcode couldn't find any iOS App Development provisioning profiles matching 'my_app_bundle_identifier.shareextension'. Automatic signing is disabled and unable to generate a profile. To enable automatic signing, pass -allowProvisioningUpdates to xcodebuild.}`

@iamtarun1993 did you manage to solve this?
I think the same root cause is what I wrote here:
https://github.com/j3k0/cordova-plugin-openwith/issues/73

OK, I managed to solve this using a fork of cordova-ios since cordova-ios does not support more than one provisioning profile.
I sent the a PR, I hope this will be merged soon.
https://github.com/apache/cordova-ios/pull/956


AVRO-3918: Add support for UUID encoded as fixed[16]

What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Extended interop tests to verify consistent valid schema names between SDKs
Added test that validates that Java throws an AvroRuntimeException on invalid binary data
Manually verified the change by building the website and checking the new redirect

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I don't know if this is the right place, and maybe I'm doing something wrong, but when I run this it doesn't fully work for me.
When I have this record:

{
  "namespace": "com.test.avro",
  "type": "record",
  "name": "TestRecordBla",
  "fields": [
    {
      "name": "name",
      "type": "string"
    },
    {
      "name": "test",
      "type": "fixed",
      "size": 16,
      "logicalType": "uuid"
    }
  ]
}

It doesn't work for me. The only way I get it to work is:
{
  "namespace": "com.test.avro",
  "type": "record",
  "name": "TestRecordBla",
  "fields": [
    {
      "name": "name",
      "type": "string"
    },
    {
      "name": "test",
      "type": {
        "name": "name",
        "type": "fixed",
        "size": 16,
        "logicalType": "uuid"
      }
    }
  ]
}

As when your using the fixed type you also have to provide a name. As stated in the docs:

Fixed uses the type name "fixed" and supports the following attributes:
name: a string naming this fixed (required).

Am I missing something, or was this overlooked? I don't think, the name requirement makes sense in this specific case, I also don't see it come back anywhere in my code.

The second schema is the correct one. I don't think you need "name": "name", but it is not clear which docs you have read. Please provide links to the relevant document and the exception/error you get.
The best way to report issues is to create a ticket at https://issues.apache.org/jira/browse/AVRO !

I got the documentation from here.
If I run it like this:
 {
      "name": "test",
      "type": {

        "type": "fixed",
        "size": 16,
        "logicalType": "uuid"
      }
    }

I get this error:
[ERROR] Failed to execute goal org.apache.avro:avro-maven-plugin:1.12.0:schema (default) on project avroschemas: Error compiling a file in C:\Users\user\IdeaProjects\avro-schemas\src\main\resources\avro\test to C:\Users\BramSimons\IdeaProjects\avro-schemas\target\generated-sources\avro: No name in schema: {"type":"fixed","size":16,"logicalType":"uuid"} -> [Help 1]
I can make an issue on the jira page you mentioned if you'd want me to?

Actually, I was wrong.
The fixed doc states: name: a string naming this fixed (required).
So "name": "test", is the name of the field and "name": "name", is the name of the schema.
All looks good!

Hi,
As a bonus, you can also name the type "uuid", so you can use the string
"uuid" for subsequent uuid fields.
--
Oscar Westra van Holthe - Kind @.***>
Op vr 27 sep. 2024 10:45 schreef Martin Grigorov @.***>:

Actually, I was wrong.
The fixed doc states: name: a string naming this fixed (required).
So "name": "test", is the name of the field and "name": "name", is the
name of the schema.
All looks good!
—
Reply to this email directly, view it on GitHub
https://github.com/apache/avro/pull/2672#issuecomment-2378769198, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGI5UG3P6RWHV77QNBZHLTZYULKZAVCNFSM6AAAAABO6RYPHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYG43DSMJZHA
.
You are receiving this because you commented.Message ID:
@.***>


Support init-to-parent, init-to-loss, and FPU

A simpler version of #628 using a single flag.

Name was changed to value_init_penalty in https://github.com/tensorflow/minigo/pull/631


Add categorical() constructor

Useful to determine automatically whether to use a NullableCategoricalArray
or a CategoricalArray. Used in particular in DataFrames, which also implement
a categorical!() variant modifying columns.
By the way, fix missing constructors for NullableCategoricalArrays which
triggered failures in the new tests (reftype wasn't preserved when calling
constructor on a NullableCategoricalArray).
@quinnj Does that sound OK? Cf. https://github.com/JuliaStats/DataFrames.jl/pull/1008. We need to tag a release after this is merged.

Coverage decreased (-0.7%) to 83.871% when pulling 28b578564ea78b99d9b3015ddec6562dedcaf5ae on nl/categorical into 52910fea3f87805a2755fd5e8e3b9ad04cd7c183 on master.

Was there any difference between this and the soon-to-be-former pool! method in DataFrames? I think you saw there that I just deprecated pool! in favor of categorize!. I'm also personally a fan of categorize over categorical because the verb form gives it a little more punch where as categorical gives off a slightly vague connotation. That's totally personal opinion though and I'm happy going with this as well.

No, it's essentially the same as pool, but of course the ! variant only makes sense in DataFrames.
About the naming: I prefer categorical because it's closer to the name of the types, for what is essentially a fancy constructor. categorize make it sound like a more complex operation to me, like generating quantiles. Name choices are always hard... Maybe let's have a vote? :-)

No, categorical is fine by me.

Cool, see https://github.com/JuliaLang/METADATA.jl/pull/6501.


Change url_prefix to /conda-store

This is what conda-store-ui expects, which allows running conda-store-server in standalone mode without passing the config.
Fixes #646.

With this PR, it's not possible to just do python -m conda_store_server.server --standalone and use the Login button on the homepage, which is served by conda-store-ui. Tested on Windows and Linux. See the issue for details.

@nkaretnikov I'm surprised this is needed. For the typical install I would expect url_prefix to be /. The only reason /conda-store is used is since this is required for deployments with multiple services under the same domain. We can meet to talk about this if you'd like?

Discussed this offline. A better solution would be to do this on the UI side. The /conda-store prefix exists mostly for running within Nebari.


Publish on Open VSX?

hi!
I really like this extension. In my company we're moving to using Gitpod, and this project can't use the default extension registry, but uses the Open VSX one.
Could you publish the extension there, @itarato? Here are the instructions, there's a GitHub Action to help publishing it!
https://github.com/eclipse/openvsx/wiki/Publishing-Extensions#how-to-publish-an-extension
This would be really helpful, thank you!

Hi Marc
Appreciate for the details. If I'm not mistaken this might do it: https://open-vsx.org/extension/itarato/byesig - my account is not verified yet though, hope that will happen soon in their issue queue.

It looks good to me, thank you very much for taking the time! ❤
I think we can close the issue now, I'll do it myself! Thanks again!


chore!: Make file manager read-only to the compiler

Description
This is a PR that moves us towards having the compiler see the FileManager as an immutable object. How it gets populated will now be upto the caller.
One issue we have so far is that caller, can be in the wasm context or the native context, so we have file_reader being a component that we conditionally compile depending on the context.
Ideally we move to a case where both package source resolution and dependency source resolution is done beforehand, and the compiler assumes that FileManager has both the source for its current crate and all of the crates dependencies.
This separation of concerns makes it easier to incrementally compile parts of the compiler in the future. For example, if the FileManager has not changed, then we know that the compilation result should not change,and we do not need to recompile.
Further, lets say we add a pass that solely does parsing of the root files in the File Manager, If a particular parsed AST has not changed, then we do not need to parse that file again.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[ ] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

One difficulty with this PR is how to handle things in the browser context, where there are no files.
I think initially we can support the usecase of a single file in the browser, since this doesn't break existing playgrounds (This allows us to mitigate the file system issue). For node, we do have the file system and we should try to not break that workflow.

The remarkable errors are due to how we special handle the stdlib -- we may need to move this logic outside of the file manager (which makes sense since the file manager should only be concerned with files and not need to know about the stdlib

Last set of errors should be related to the file manager not having the source code for its dependencies (since the method we added only allows us to add code for the current package)

As of this commit, the native non-wasm version is passing tests. The tests in Test-ubuntu that are failing are related to compiler::wasm.

Is this PR intended for the LSP or for general cleanup? I thought it was related to wasm's filesystem oddities at first but it seems not.

Is this PR intended for the LSP or for general cleanup? I thought it was related to wasm's filesystem oddities at first but it seems not.

Its intended for the odditities related to wasm's filesystem that has sort of spread into many components including the lsp -- This now allows WASM/typescript to fill in the filesystem, however they see fit (async/sync) using the SourceMap and then the rust compiler just consumes the source map and uses it to populate the file system.
There are some general cleanup items that arise out of it, for example, it is now the compiler that "knows" about the stdlib instead of having the FileManager know about the stdlib. Another is that we no longer need the SourceResolver crate

I think this doesn't cause any major problems beyond the expected need to modify code interacting with noir_wasm. I'm good to merge this once followup issues have been made.

I think this doesn't cause any major problems beyond the expected need to modify code interacting with noir_wasm. I'm good to merge this once followup issues have been made.

@alexghr pinging you to confirm this is okay too?

I'll also quickly put together a rough PR for a different API which aligns more with what we have in nargo that we can merge in the future

(non-breaking) PR is here for a different API that is more context-centric https://github.com/noir-lang/noir/pull/3798

Yep, looks good to me! I think we just have to be aware of having to update noir-compiler in aztec-packages at the same time as the noir subrepo is updated in it.


[Home] Banners, search

An option would be to keep using the existing banner component in favour of the following two, for now.

https://github.com/artsy/eigen/issues/1439
https://github.com/artsy/eigen/issues/1447

We decided to go forward with the banner and search.

go for the gold


"Livezile", "Lăculețe" are listed in the drop-down menu

Description:
When user writes ” Livezile” and "Lăculețe" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Livezile"

Expected results
The location appears in the drop-down menu as "Sat Livezile, DÂMBOVIȚA (Glodeni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Lăculețe"

Expected results
The location appears in the drop-down menu as "Sat Lăculețe, DÂMBOVIȚA (Glodeni)".


Updated to use ReactDOM in React 0.14

React 0.14 now has ReactDOM object, and that must be used to render into the DOM.

Thanks. We had to do more.
I worked on this and add the React 0.14.x support.
See: https://github.com/kadirahq/meteor-react-layout/commit/b2b67a508d96caec13980d3236fa3a20df397287


Feature/handling errors

Description

Errors 401, 403, 404, 500 are handled in separate pages
With errors 401, 403 users are linked back to Main Page or Home Page
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

Create 401 error handling page
Create 403 error handling page
Create Container for wrapping error handling pages
Unit tests for error pages 401, 403, 404, 500

Testing

[x] Unit Tests
[x] Needs testing (start an issue or do a follow up PR about it)

If we cannot catch some errors in the front-end, we might also need to redirect from back-end e.g.

have back-end running (develop branch)
go to localhost:3000/folders/1
see a json response

What should be at step 3 is the corresponding error page as back-end checks each request user is authenticated.

Ok, it's good you pointed out that we should the top bar. I can improve the design part within this PR.
For the errors catching, I can start with a new issue to make it clear.

I also added custom colors for error pages according CSC's color theme

merging this, if anything arises we can do another PR to fix it.


[SPARK-46988][CONNECT][FOLLOWUP] Protobuf abbreviate method code clean up

What changes were proposed in this pull request?
Protobuf abbreviate method code clean up
Why are the changes needed?
code clean up, to make it more easy to reuse
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

thanks @HyukjinKwon
merged to master


Cilium can't handle pods massive creation on high scale Kubernetes cluster

Bug reports
Title
On a Kubernetes cluster with 200+ nodes, Cilium can't handle the creation of 4000+ pods.
General Information

Cilium version: v1.2.3
Kernel version: Linux 4.14.67
Orchestration system version in use: Kubernetes 1.10.7
etcd version: 3.1.11

Cluster Configuration

Instances
CPU per Instance
Memory per Instance

Masters
3
4
16GB

Nodes
200
8
15GB

How to reproduce the issue

Deploy a Kubernetes cluster with 3 master nodes and 200 worker nodes
Create 800 servers and 5200 clients making 10 requests per second each one.

Results
The following chart shows how does the cluster behave under this test scenario.

The gray line counts how many Ready nodes the cluster has. It is extremally unstable due metrics-server outages during the tests.
After reaching 3000 pods, the cluster starts to behave unexpectedly, with some pods dying, and the rate of pod creation declining until no more was created. 1500 pods were no longer created, and the cluster was practically unusable. Check this section of the chart above.

The most recurrent error was:
Warning   FailedCreatePodSandBox   kubelet, ip-172-151-106-95.ec2.internal    Failed create pod sandbox: rpc error: code = Unknown desc = NetworkPlugin cni failed to set up pod "ubuntu-curl-5b9f864c79-mtdj6_ubuntu-curl" network: add cmd: failed to assign an IP address to container

Also, we collected some resource usage metrics before metrics-server crashing. The blue, red and orange lines represent the master nodes.

CPU usage critically increased during the test, making the Kubernetes API unavailable. We believe that this behavior may be due to some misconfiguration, since performing the same test with two other CNI plugins, Calico and Amazon VPC, there was a big difference in the results.

Calico
Amazon VPC
Cilium

Masters Max CPU usage
80%
80%
93%*

Masters Max Memory usage
25%
25%
28%*

Nodes Max CPU usage
14%
35%
43%*

Nodes Max Memory usage
14%
16%
16%*

Test duration
5 min
12 min
interrupted

* reported before metrics-server breaking
Do we have to make any specific configuration for a high scale cluster to work with a big number of pods and a high load networking traffic?

@luanguimaraesla I'll write a longer response but the get things started: What PodCIDR configuration are you putting Kubernetes in? It seems that Cilium is running out of IP addresses to allocate.

Thank you for your attention. The PodCIDR is <IP_ADDRESS>/10.

@luanguimaraesla Thanks for the quick response.
We suspect that frequent Pod annotations plus the updates to the CRD that mirrors each pod as performed by Cilium are the cause for the increased CPU usage in the apiserver which causes the breakage at +3K pods. We'll confirm this theory and provide a fix.
The increased CPU usage on the worker is caused by the BPF program generation right now. Cilium 1.3 will already bring some relief and the upcoming BPF templating will remove the need to compile programs entirely when pods are bootstrapped.
@luanguimaraesla Do you have Cilium and apiserver logs by any change? We would love to dig through them to confirm the above theories.

Yes. I had to make another test to collect the logs. The files are attached.
cilium.zip

The increased CPU usage on the worker is caused by the BPF program generation right now.

We also collected some data from the moment we instantiate 200 nodes. Knowing that the use of resources would increase in the workers during the generation of the BPF program, we thought that after the stabilization of the cluster, the use of CPU would normalize, which did not happen. Take a look at the following chart.

26% of CPU usage per node with no workloads running, except by the default ones, is too high for production nodes. So, why do you think the cluster still using too many resources? Could we normalize the resource usage after BPF program generation with any configuration?
The master nodes are more critical, perhaps the high CPU usage causes Kubernetes API outages and then the Cilium bad behavior, which we can see on the following error on cilium-node.
level=info msg="Updating CRD (CustomResourceDefinition)..." name=v2.CiliumEndpoint subsys=k8s
level=error msg="Unable to update CRD" error="Operation cannot be fulfilled on customresourcedefinitions.apiextensions.k8s.io \"ciliumendpoints.cilium.io\": the object has been modified; please apply your changes to the latest version and try again" name=v2.CiliumEndpoint subsys=k8s
level=fatal msg="Unable to establish connection to Kubernetes apiserver" error="Unable to create custom resource definition: Operation cannot be fulfilled on customresourcedefinitions.apiextensions.k8s.io \"ciliumendpoints.cilium.io\": the object has been modified; please apply your changes to the latest version and try again" subsys=daemon
level=fatal msg="Agent pipe unexpectedly closed, shutting down" subsys=cilium-node-monitor

Regards

@luanguimaraesla thanks for the given zip file, 2 of the cilium issues in that file are fixed with this PR will be fixed and backported to v1.2 with this PR https://github.com/cilium/cilium/pull/5926

@luanguimaraesla Thanks for the excellent data. This is awesome. The data confirm the previous suspicion that this is not related to pod creation workload itself but to the interaction with the apiserver  with respect to the CiliumEndpoint CRD. The log indicates over 200 interactions with the apiserver per second. We'll fix this right away.

@tgraf @aanm Thank you guys for this excellent work. The --disable-endpoint-crd flag and the other fixes you quickly made resulted in a significant improvement in the results.
Now it is possible to see the CRD sync disabled.
level=warning msg="Not running controller. CEP CRD synchronization is disabled" containerID=cilium-loc controller="sync-to-k8s-ciliumendpoint (21530)" endpointID=21530 ipv4= ipv6= k8sPodName=/ policyRevision=2

This really caused an excessive load on Kubernetes API. Now we can see the CPU usage decrease after the BPF programs generation. Look at the following charts from this test.

We successfully reached almost 6500 running pods on 200 Kubernetes nodes. The temporary unavailability of the metrics-server is normal and also happened in the load-test with other technologies.

Here we can see the tendency to decrease the use of resources after creating all pods. I think it's still significantly high especially in the worker nodes, but this is a matter of future enhancements. I also collected again the cilium and apiserver logs for the comparison with the old logs.
cilium2.zip
Now, things are looking good. Thanks for all the work.

Looks like the original reporter is happy with where Cilium got to after the first few fixes, and furthermore the project https://github.com/cilium/cilium/projects/18 is tracking further scale improvements. Will close, feel free to re-open/file new aissue if you hit additional issues with Cilium scale.
Thanks.


Unable to Install Microsoft.CognitiveServices.Speech.CLI

Running the command "dotnet tool install --global Microsoft.CognitiveServices.Speech.CLI" from https://learn.microsoft.com/en-us/azure/cognitive-services/speech-service/get-started-text-to-speech?tabs=windows%2Cpowershell&pivots=programming-language-cli results in the following error:
C:\Users\[user]\AppData\Local\Temp\bfd4cc54-5d61-4c9f-953a-05f2da977b4d\restore.csproj : error NU1101: Unable to find pa
ckage microsoft.cognitiveservices.speech.cli. No packages exist with this id in source(s): C:\Program Files\dotnet\libr
ary-packs, Microsoft Visual Studio Offline Packages
The tool package could not be restored.
Tool 'microsoft.cognitiveservices.speech.cli' failed to install. This failure may have been caused by:

* You are attempting to install a preview release and did not use the --version option to specify the version.
* A package by this name was found, but it was not a .NET tool.
* The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
* You mistyped the name of the tool.

For more reasons, including package naming enforcement, visit https://aka.ms/failure-installing-tool

I am not having Internet issues and I am able to browse to https://www.nuget.org/packages/Microsoft.CognitiveServices.Speech.CLI which provides these commands:
dotnet new tool-manifest # if you are setting up this repo
dotnet tool install --local Microsoft.CognitiveServices.Speech.CLI --version 1.24.0

This results in the same error.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 91e2ab62-8804-694f-f51a-ab5cef82c2d6
Version Independent ID: 3eac47ce-d629-6a1f-914b-ce60ab13ebae
Content: Quickstart: The Speech CLI - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/spx-basics.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @eric-urban
Microsoft Alias: eur

@welbornt
Thanks for your feedback! We will investigate and update as appropriate.

@eric-urban
Could you please check and add your comments on this, update as appropriate.

@welbornt
Thank you for bringing this to our attention. I've assigned this issue to the author who will investigate and update as appropriate.

@welbornt - I was not able to repro this issue. Do you have more details about your environment or path that might help? I suggest that you also ask via Q&A.

#please-close

I hit the same problem. My workaround is to download nupkg file from https://www.nuget.org/packages/Microsoft.CognitiveServices.Speech.CLI and store it to C:\Program Files\dotnet\library-packs.

I had the same issue. As suggested by @dingmeng-xue , I downloaded the nupkg file from https://www.nuget.org/packages/Microsoft.CognitiveServices.Speech.CLI (there is a Download package link on the right side) and saved it into my C:\Users\USER_NAME\Downloads folder. Then I just called the following command:
dotnet tool install --global Microsoft.CognitiveServices.Speech.CLI --add-source C:\Users\USER_NAME\Downloads
And got:
You can invoke the tool using the following command: spx
Tool 'microsoft.cognitiveservices.speech.cli' (version '1.32.1') was successfully installed.


Documentation is confusing and could use improvement and/or restructuring

First of all, thank you for your work. I'm really glad this exists as an alternative to Bcrypt.
I've been trying to wrap my mind around the various functions and behaviors implemented by this library, and I'm having a bit of trouble. Since authentication logic is important and misunderstandings can potentially result in severe security flaws, I want to make sure I understand everything thoroughly, and that other people do, as well.
To start with an example: what is the difference between check_pass and verify_pass? The function names suggest they are identical, but based on the examples they are different. Is there a reason both of these exist, when they seem to do the same thing (albeit with different param types)? When is a good time to use one or the other? I looked at the source code -- Comeonin's check_pass calls verify_pass internally, and that returns a true or false. But Argon2's verify_pass can additionally raise an ArgumentError...
Similarly, there seems to be a lot of redundancy between add_hash and hash_pwd_salt. Again, I understand that add_hash returns a map that is meant to be used in an Ecto changeset, and it works fine for that purpose. But the way these functions are named makes the reader wonder whether add_hash uses a salt as well (I had to read the source code to verify, just for ease of mind). Maybe rename it to add_hash_salt, or even better, add_hash_salt_to_changeset, since that's what it does? (I also wish there was further standardization in function names - some functions refer to passwords as "pass" and others refer to them as "pwd" - just a thought.)
Generally, the organization of the documentation on Hex.pm is a bit confusing, and seems non-standard. Information about various functions is scattered under 'Options' and 'Examples' headers, and the 'Functions' header contains only a single function, gen_salt. This makes it challenging to understand the proper and recommended usage of each function. For example, I was trying to find the possible returns of check_pass, and after a lot of browsing around I ended up having to read the source code of Comeonin itself, despite the fact that the function is called from Argon2. I get that it's a behavior, but properly organized documentation that clearly shows param and return types would eliminate the need to read the source code. Adding hyperlinks to the relevant sections of the Comeonin docs would also help. :)
I know that the Comeonin framework has gone through multiple iterations and redesigns, so maybe things are still in flux. Once I fully grok this library and how to properly use it in a "real-life" project, I'll submit a tutorial with a reference project link so that it can be added to the docs. I just wanted to submit this piece of feedback so that you're aware of the difficulties users might be facing. Thank you.

Thanks for raising the issue.
Some of the problems with organization is that argon2_elixir use-s functions defined in Comeonin, but the function documentation cannot be accessed directly via argon2_elixir, and so I put the documentation for those functions in the module documentation.
One other problem is that these libraries are very widely used, and it is difficult to change the names of functions without causing confusion / problems for users when they update the library.
Anyway, I will have a further look at this issue in the new year and get back to you then.

One more thing: for most apps, you will just need to use the add_hash and check_pass functions, which are convenience functions. Three are examples of how to use them in the module docs, and I will look at making it clearer that those are the only functions that most users will need to use.


Significant Layout Changes Causing Crashes

I have the following component:
`        - type: scrollbox
size: { w: stretch, max_h: 210 }
content:
type: panel
elements:
            - type: panel
              visible: @showEffectList
              elements: @effects
              template:
                type: button
                  size: { w: stretch }
                  on_click: @@ e => @onClick()
                  content:
                    type: text
                      scribble: true
                      text: @trigger
            - type: panel
              visible: @showEffect
              elements:
                - type: button
                  visible: @showHideEffect
                  background: #FF0000
                  on_click: @@ e => @hideEffect()
                  content:
                    type: text
                      text: Back
                - type: advanced_text
                  text_array: @shownEffectText`

Which allows me to create the following list of buttons, which is created by the panel whose elements are @effects

When pressed it sets @showEffectList to false and sets @showEffect to true
Then I can hover over another card to set @showEffectList to true, @showEffect to false and change @effects
How I can produce is error is that

I set @effects to an array with 3 elements
Click one of the buttons which hides the 3 elements

Then if I cause the @effects array to turn into an array with 1 element which causes the crash

Found a way to reproduce it, on the example project go in order:
Hide -> One
Uploading Sandbox.zip…


(with json, for union) Error: cannot extract elements from a scalar

EdgeDB Version: 1.1
OS Version: MacOS 11.5.2 (Intel)

Steps to Reproduce:

Execute a query looking like the bulk insert (with json data) one from the docs
Get an error: Error: cannot extract elements from a scalar

You can easily reproduce it on the tutorial playground here, with this input to paste into the first field (then click run):
with
  raw_data := <json>'[{"name":"Sersi"},{"name":"Ikaris"},{"name":"Thena"}]',
for item in json_array_unpack(raw_data) union (
  insert Person { name := <str>item['name'] }
);

No issue when using this json-less input:
for hero_name in {'Cersi', 'Ikaris', 'Thena'} union (
  insert Person { name := hero_name }
);

Either the docs are not up-to-date, or there is an actual issue with json array parsing/iteration.
Thanks

Indeed, thanks!


add subresource integrity to css/js

Allow the creation of a signature for subresource integrity for the created files.
see: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity

I'm trying to work out how to make this work with webassets.
This Python code can generate the hash:
import base64
import hashlib
BUF_SIZE = 65536
def checksum(input):
    hash = hashlib.sha256()
    with open(input, 'rb') as f:
        while True:
            data = f.read(BUF_SIZE)
            if not data:
                break
            hash.update(data)
    hash = hash.digest()
    hash_base64 = base64.b64encode(hash).decode()
    return 'sha256-{}'.format(hash_base64)

To test this I use a link copied with SRI tag from cdnjs, and wget the CSS file to my working directory, then:
>>> checksum('bootstrap-grid.css')
'sha256-cCazLItaM+Zz5UEzu9HNzlgWhXlvknCzjdE45LBeTns='

The hash of this file from the cdnjs provided link tag: integrity="sha256-cCazLItaM+Zz5UEzu9HNzlgWhXlvknCzjdE45LBeTns="

This looks good, but I'm not sure how webassets integration would or should work.
It would be perfect if when I define the link tag:
{% assets "css_all" %}
<link rel="stylesheet" media='screen' href="{{ ASSET_URL }}" />
{% endassets %}

I could then reference a variable like ASSET_SNI.
But there's also the question of where I call the code to generate these hashes in the first place, and where to store them.

Presumably this should be implemented in the jinja2 extension to expose a new variable (or use the EXTRA variable documented there).

I have a POC implementation, which I will extend with unit tests. I will not write any code for django etc, only jinja2 (since it is the only one I can test).
Furthermore, I will not be able to test any versions of Python except 3.7 and 2.7.


[feature request] allow splitting diff and apply stages

Similar to terrafrom plan/apply it would be super useful if the diff and apply stages could be split into two invocations of the tool. This would allow better integration with systems where user input can't be provided via a TTY (e.g. Buildkit pipelines). Currently the only solution in these cases is to use -y, but at least initially this isn't what I'd like to do when deploying production services.

@samschlegel interesting...

This would allow better integration with systems where user input can't be provided via a TTY (e.g. Buildkit pipelines).

im assuming you are planning to do some kind of manual review in the middle step, and then approve the change to continue going thru the pipeline?
one challenge i am thinking of is if there is some kind of artifact that is propagated it cannot contain secrets information (ie cannot be just plain diff). few solutions to that: (1) propagate ref that points to something saved in the cluster, or (2) propagate some kind of checksum that is later compared to new diff and if it matches it continues.

Yes, that's the plan. One step outputs the diff and uploads the plan, and then the pipeline blocks waiting for manual review, and the step after downloads the artifacts.
If the output contains secrets, the input would also have secrets, so it doesn't seem like that should be an issue here? Terraform plans include the secrets, and we encrypt it when sharing it between steps.


Failed to automatically create a certificate for stephane-bressani.ch

Hello, i have this issue :
McMaster.AspNetCore.LetsEncrypt.Internal.AcmeCertificateLoader[0]
      Failed to automatically create a certificate for stephane-bressani.ch
Certes.AcmeRequestException: Fail to load resource from 'https://acme-v02.api.letsencrypt.org/acme/new-order'.

with Blazor, and Docker on Debian.
Yesterday it's worked fine and today i have this message
Thanks for your library ! It's work fine on asp.net core 3 with angular without docker (i never tried with docker, maybee same problem...)

I think is a bad confirguration of my docker...
i stop using docker for this site, i use a systemctl now
i have to wait some day before i can have a new certificat


Safe all affected files automatically

When running a rename and there are multiple files affected, is there a way to auto safe all of them after the rename?

You can use the post_hook option like this:
require("inc-rename").setup {
  post_hook = function()
    vim.cmd("wa")
  end
}
`


include Keymaps section in manpage or jid -h

@evandrix
I added -h option.
https://github.com/simeji/jid/pull/46

thanks.


refactor: do not log websocket data

It logs the following to the console, which is really unhelpful and bloats your logs:
2022-07-24 09:57:06.677  DEBUG [DIDComm Chat  WebSocket.<anonymous>] WebSocket message event received.
{
  data: {
    type: 'Buffer',
    data: [
      123,
      34,
      112,
      114,
      111,
      116,
      101,
      99,
      116,
      101,
      100,
      34,
      58,
      34,
      101,
      121,
      74,
      108,
      98,
      109,
      77,
      105,
      79,
      105,
      74,
      52,
      89,
      50,
      104,
      104,
      89,
      50,
      104,
      104,
      77,
      106,
      66,
      119,
      98,
      50,
      120,
      53,
      77,
      84,
      77,
      119,
      78,
      86,
      57,
      112,
      90,
      88,
      82,
      109,
      73,
      105,
      119,
      105,
      100,
      72,
      108,
      119,
      73,
      106,
      111,
      105,
      83,
      108,
      100,
      78,
      76,
      122,
      69,
      117,
      77,
      67,
      73,
      115,
      73,
      109,
      70,
      115,
      90,
      121,
      73,
      54,
      73,
      107,
      70,
      49,
      100,
      71,
      104,
      106,
      99,
      110,
      108,
      119,
      100,
      67,
      ... 745 more items
    ]
  }
}

Codecov Report

Merging #962 (736efd9) into main (04ab1cc) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   87.76%   87.76%
=======================================
  Files         475      475
  Lines       11417    11417
  Branches     1804     1804
=======================================
  Hits        10020    10020
  Misses       1393     1393
  Partials        4        4

Impacted Files
Coverage Δ

packages/core/src/transport/WsOutboundTransport.ts
11.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


Request build/docker image for arm32v7

Request build/docker image for arm32v7 - qnap/linux

I added arm-7 to release builds.  The latest one is bashhub-server_v0.2.3_linux_arm-7.tar.gz.  If you want to run it in docker it should be pretty easy to run the binary in something like arm32v7/alpine. Does that help?

Absolutely!


XA transactions fail with JMS

 Issue by orthoxerox
Wednesday Dec 05, 2018 at 12:04 GMT
Originally opened as https://github.com/ballerina-platform/ballerina-lang/issues/12517

Description:
See gist.
If I change connectionFactoryName to "ConnectionFactory", the message is still not sent, but at least I get it back in Q1 when the service is killed.
I can change acknowledgementMode to "AUTO_ACKNOWLEDGE" and the message is delivered to Q2, but I need cross-broker XA support in production.
Steps to reproduce:

Run Apache Artemis broker, create one user and anycast queues Q1 and Q2
Update user credentials in bridge.bal from the gist
Run ballerina run -e b7a.log.level=TRACE bridge.bal
Insert one message into Q1
Observe no "Message sent" trace
Kill ballerina service
Observe in Artemis console that the message is neither in Q1 nor Q2

Affected Versions:
Ballerina 0.983.0
OS, DB, other environment details and versions:

Win 10 x64
Apache ActiveMQ Artemis 2.6.2

 Comment by orthoxerox
Wednesday Dec 05, 2018 at 22:23 GMT

Update: if I wrap the body of onMessage in transaction, the send operation completes, but any unhandled exceptions still do not return the message to Q1 or broker's default DLQ.

 Comment by aashikam
Friday Dec 07, 2018 at 09:06 GMT

Currently the Ballerina JMS module doesn't support XA transactions. We have added it to our roadmap hoping to support that by Q1 next year.

 Comment by orthoxerox
Friday Dec 07, 2018 at 09:43 GMT

Ah, I see, thank you. Then this page is incorrect: https://ballerina.io/learn/by-example/xa-transactions.html

 Comment by orthoxerox
Friday Dec 07, 2018 at 14:12 GMT

One more note: your current approach to creating JMS connections cannot obtain an XA connection from IBM MQXAConnectionFactory, as it returns an MQConnection from createConnection() and returns an MQXAConnection only from createXAConnection().

 Comment by anupama-pathirage
Tuesday Dec 11, 2018 at 13:34 GMT

Created https://github.com/ballerina-platform/ballerina-lang/issues/12712 to track the documentation issue.


1903 patch release notes are missing (any language)

🛑 IMPORTANT: this page has no comment section
Would be great to have for reporting patch related issues when official reference is given
Link to article:
https://support.microsoft.com/en-us/help/4099479/windows-10-update-history
Problem:
The update history is missing 1903 18362.x patch notes as it is officially out of insider now.
I've checked de-de / en-us.

this one is fixed for en-us
https://support.microsoft.com/en-us/help/4099479/windows-10-update-history
de-de still missing 1903 history
https://support.microsoft.com/de-de/help/4099479/windows-10-update-history

@GrantMeStrength Can you please take a look at this issue?

This issue is closed. The patch notes are now listed in the update history
https://support.microsoft.com/de-de/help/4498140/windows-10-update-history
https://support.microsoft.com/en-us/help/4498140/windows-10-update-history
@GrantMeStrength @ryanmajidi


Question about calculating the position of gaussian

Thanks for sharing your great effort and work.
I have a little question here in src/model/encoder/common/gaussian_adapter.py:
# Compute Gaussian means.
origins, directions = get_world_rays(coordinates, extrinsics, intrinsics)
means = origins + directions * depths[..., None]
The directions used in the calculation here has been normalized, which will cause the calculation result to not be the correct world coordinate system.
For example, in the autonomous driving scene, the xyz of the point cloud is directly used as the gaussian position. Here, normalization and non-normalization are used.
The results are as shown in the figure below.

Depth can either be defined as distance along the ray or as Z depth (distance along the camera look vector/Z coordinate in camera space). Since depth is predicted by a neural network, the convention that's being used doesn't matter—the network will simply learn whatever convention is being used.
If you want to switch to the other convention (Z depth), you can replace this line with the following:
directions = directions / directions[..., -1:]

This will normalize by the Z coordinate instead of by ray length.

Depth can either be defined as distance along the ray or as Z depth (distance along the camera look vector/Z coordinate in camera space). Since depth is predicted by a neural network, the convention that's being used doesn't matter—the network will simply learn whatever convention is being used.
If you want to switch to the other convention (Z depth), you can replace this line with the following:
directions = directions / directions[..., -1:]

This will normalize by the Z coordinate instead of by ray length.

OK, thank you for the detailed explanation, and thank you again for your great work!


Specify TS paths directly to avoid losing declarations when building

@Ocupe any idea why api-check is complaining about so many (seemingly) new things now? Does the action fail on warnings or must there be something else going on?


Single-FOV wells vs. multi-fov wells

We're building ome-zarr reader support for multi-fov wells, where we would save each fov/site from the microscope as its own nested directory in the OME-Zarr file.
While building this and while talking to Kevin Yamauchi, some thoughts came up on pros and cons of the different strategies and I'll try to summarize them here in this high level issue, so that we can keep an overview here.

Definitions:
Single-FOV wells: Describes a way of saving image data to OME-Zarr in which data for each well (each unit of a plate) is saved in a single field of view.
Single FOV schematic adapted from OME-NGFF:
5966.zarr                 # One plate (id=5966) converted to Zarr
    ├── .zgroup
    ├── .zattrs               # Implements "plate" specification
    ├── A                     # First row of the plate
    │   ├── .zgroup
    │   │
    │   ├── 1                 # First column of row A
    │   │   ├── .zgroup
    │   │   ├── .zattrs       # Implements "well" specification
    │   │   │
    │   │   └── 0             # Single field of view of well A1
    │   │       │
    │   │       ├── .zgroup
    │   │       ├── .zattrs   # Implements "multiscales", "omero"
    │   │       ├── 0
    │   │       │   ...       # Resolution levels
    │   │       ├── n
    │   │       └── labels    # Labels (optional)
    │   ├── ...               # Columns
    │   └── 12
    ├── ...                   # Rows
    └── H

Multi-FOV wells: Describes a way of saving image data to OME-Zarr in which data for each original image acquisition region (=field of view, site) is saved to a separate folder under the well (unit of a plate) folder.
5966.zarr                 # One plate (id=5966) converted to Zarr
    ├── .zgroup
    ├── .zattrs               # Implements "plate" specification
    ├── A                     # First row of the plate
    │   ├── .zgroup
    │   │
    │   ├── 1                 # First column of row A
    │   │   ├── .zgroup
    │   │   ├── .zattrs       # Implements "well" specification
    │   │   │
    │   │   ├── 0             # First field of view of well A1
    │   │   │   │
    │   │   │   ├── .zgroup
    │   │   │   ├── .zattrs   # Implements "multiscales", "omero"
    │   │   │   ├── 0
    │   │   │   │   ...       # Resolution levels
    │   │   │   ├── n
    │   │   │   └── labels    # Labels (optional)
    │   │   ├── ...           # Multiple fields of views, saved separately
    │   │   └── m             # Last field of view (e.g. in a well with 6 rows & 7 columns, fov 41)
    │   ├── ...               # Columns
    │   └── 12
    ├── ...                   # Rows
    └── H

Benefits of using multi-FOV approach

This follows the OME-NGFF v0.4 (& v0.5-dev) standard
Makes for an easy parallelization scheme: The same way we parallelize over plates and wells, we could also parallelize over sites. Makes it easy and robust to run illumination correction per site, run image analysis per site etc.
Easily understandable on where original images go => the folder of the site
Allows a user to load a single site or a few sites (and if the metadata is parsed, those sites are placed correctly, which works in our test cases)
Easy support for search-first data: We only save the fovs & their position, the reader handles placement

Concerns with multi-FOV approach

How will read performance in the napari viewer be? Given that we have everything saved per site again, the pyramids are also built by site. That means we can't chunk pyramids across sites anymore, thus have the same amounts of files per level, with files just becoming smaller. Improving chunking was one of the things we changed in May that improved viewer performance (see here: https://github.com/fractal-analytics-platform/mwe_fractal/issues/32)
With increased pyramid files, the number of overall files also increase, thus increasing the burden on IT infrastructure if we don't use an object storage approach or Zarr zipping (see here: https://github.com/fractal-analytics-platform/mwe_fractal/issues/59)

Benefits of single-FOV approach

Already works with the current OME-Zarr napari reader plugin
"Fast" / decent visualization speeds
Single-FOV setups would be nice to display stitched data (though what would we do before stitching? Tile them next to each other and just have an image of a different size after stitching?)

Concerns with single-FOV approach

How do we handle parallelization per site? We could base it on chunk size at the lowest level (but on some level, that is something that could always be changed or that we'd want to optimize for either processing or visualization)
Parallelization: If we process in smaller chunks, but write to an AnnData object that is saved "per site" (and now there is only 1 site) => How do we handle parallel write access to that file? Or how do we work around having to write to it in parallel?
How do we handle site-wise label images if all sites are fused? Or do we process per site and then find a way to relabel once the whole well is processed? (we wouldn't want multiple objects with "label" = 1 in the same label image)
=> This opens the larger question though: How will we handle "region of interest" based computation, e.g. for an organoid that crosses site boundaries or for multiple sites that we want to stitch together and then process as one?

We will test some of the concerns regarding performance with the planned work on the ome-zarr-py plugin. Once we have a better understanding of its performance implications, we should know better how to judge the trade-offs illustrated above.

It looks like parallelization over ROIs works well (https://github.com/fractal-analytics-platform/fractal/issues/95) and the visualization scales well with this new approach.
The only downside to the multi-FOV approach seems to be handling overlap between images. We have a new issue specifically for this here, so let's close this one.


Improve F-Droid listing

I've seen this app on F-Droid, but it lacks screenshots, changelog and a translatable description there. It's pretty easy for you to add these information. Please have a look at this example or at the F-Droid docs or fastlane docs.
After you have commited these files to your repo and tagged a new version, you need to remove the Description and Summary from the metadata file in the F-Droid Data repo.

New build is up on F-Droid :) https://f-droid.org/packages/com.germainz.identiconizer/


Unable to compile using TypeScript

I'm trying to use FireSQL with code from README, but getting errors below:
> tsc

node_modules/firebase/index.d.ts:6297:36 - error TS2304: Cannot find name 'ServiceWorkerRegistration'.

6297     useServiceWorker(registration: ServiceWorkerRegistration): void;
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/firebase/index.d.ts:6414:13 - error TS2304: Cannot find name 'Blob'.

6414       data: Blob | Uint8Array | ArrayBuffer,
                 ~~~~

node_modules/firesql/utils.d.ts:1:45 - error TS7016: Could not find a declaration file for module './sql-parser'. '/Users/andrey/Documents/MyProjects/FreelanceJobs/FreelanceJobs-server/functions/node_modules/firesql/sql-parser/index.js' implicitly has an 'any' type.

1 import { SQL_Value, SQL_AggrFunction } from './sql-parser';
                                              ~~~~~~~~~~~~~~

src/repositories/upwork/upworkJobRepository.ts:4:1 - error TS6133: 'firebase' is declared but its value is never read.

4 import firebase from 'firebase/app'
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 4 errors.

The code is:
import 'firebase/firestore'
import firebase from 'firebase/app'
import { FireSQL } from 'firesql'

    const fireSQL = new FireSQL(this.getCollectionRef().firestore)
    const promise = fireSQL.query(`
  SELECT *
  FROM upworkjobs
  WHERE budget >= 500 AND budget <= 10000 AND subcategory = 'Game Development'
  ORDER BY datePosted DESC
  LIMIT 5
`)

How to fix them? I use TypeScript.

I also noticed that npm install firesql doesn't add firesql into package.json. Why is that?

having same isuss need guide asap
import { SQL_Value, SQL_AggrFunction } from './sql-parser';

@cyiboy unfortunately this repo seems dead :(

Hello @cyiboy @agordeev ! I've tried, and it works for me, edit the line in the utils.d.ts file to:
import { SQL_Value, SQL_AggrFunction } from './types/sql-parser';
I know this isn't the right way but I needed to compile :D


Ci relnotes 783xx doc 2520

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-529

Preview environment: https://ci.pr.harness.io/pr-529


Docker-compose fails with mkdir /var/druid and /var/tmp, permission denied

Affected Version
Druid version 0.21.0
Build on Ubuntu 20.04LTS
Description
After building the image as described here, I start the docker with the following command:
docker-compose -f distribution/docker/docker-compose.yml up
After a lot of initial messages both historical and router start complaining that they don't have permissions to create certain directories
router           | mkdir: can't create directory 'var/tmp': Permission denied
router           | mkdir: can't create directory 'var/druid/': Permission denied
router           | mkdir: can't create directory 'var/druid/': Permission denied
router           | mkdir: can't create directory 'var/druid/': Permission denied
router           | mkdir: can't create directory 'var/druid/': Permission denied
router           | mkdir: can't create directory 'var/druid/': Permission denied
middlemanager    | Setting druid.indexer.logs.directory=/opt/data/indexing-logs in /tmp/conf/druid/cluster/data/middleManager/runtime.properties
broker           | mkdir: can't create directory 'var/tmp': Permission denied
broker           | mkdir: can't create directory 'var/druid/': Permission denied
broker           | mkdir: can't create directory 'var/druid/': Permission denied
broker           | mkdir: can't create directory 'var/druid/': Permission denied
broker           | mkdir: can't create directory 'var/druid/': Permission denied
broker           | mkdir: can't create directory 'var/druid/': Permission denied

In the end, the following services abort with an exit code 1
historical exited with code 1
router exited with code 1
broker exited with code 1
middlemanager exited with code 1

I am new to druid and I am just following the quickguide.
Any ideas what might be the root cause ?

Me to getting the same problem

resolved by #11166
Thanks

Hi @FrankChen021 i still facing the same problem with this issue,
Using this docker compose from latest documentation page
https://github.com/apache/druid/blob/0.21.0/distribution/docker/docker-compose.yml

Hi @fiantinangon , this bug will be fixed in 0.21.1 which is being in the release process. I think the new version will be published in a couple of days.

Hi @fiantinangon , this bug will be fixed in 0.21.1 which is being in the release process. I think the new version will be published in a couple of days.

Ok @FrankChen021 thanks for the information looking forward for the new release

Is it Published? If not then, Why this issue is closed?


[Language Text] Update tests

To match recent update in service behavior
Successful live run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1921444&view=results

API change check
API changes are not detected in this pull request.


Add Localization Support

Tried to get my friends onboard MFP but they can't read English. Wish I could translate the interface to make things easier for them.
Describe the solution you'd like
Support custom language files that can be loaded inside the app.

That would be a good feature to have, but I think it would require a lot of work and a lot of redesigning of the UI since the text length would change. Since it's not something I thought of from the start it might be a bit too late to add now, it might be more of a 2.0 feature.
But I'll leave this open.


Fix example code, replace "useState" for "useRef"

Small error I noticed today in the docs: https://material-ui.com/components/menus/#simple-menu

Got confused with the naming of the variables, closing


Get rid of 'jobOwnerToken' and 'jobUid' in the code

As a continuation of the superroma/testcafe-hammerhead#65 we need to remove jobUid and jobOwnerToken from the client code and replace it with the sessionId. We need to do that for the tests and server (if we have anything there) as well.

FYI: we have jobUid just in the client-tests. We will get rid of this and close the issue after hammerhead will be published in npm


Remove hardcoded sidecar template for istioctl kube-inject

Fix issue #10380

Remove hardcoded sidecar template in kube-inject.
Modify some tests to read sidecar template from install/kubernetes/helm.
Remove some meaningless tests for injecting.

Signed-off-by: mathspanda<EMAIL_ADDRESS>

/retest

@mathspanda: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @incfly

Thanks for this work!
I'm currently out of office till 1/9. @mandarjog, @nmittler maybe you can provide some initial feedback?

/ok-to-test

@mathspanda: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
4e5c595d136203605758a897be8a0f62ab245333
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathspanda: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4e5c595d136203605758a897be8a0f62ab245333
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mathspanda: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4e5c595d136203605758a897be8a0f62ab245333
link
/test istio-integ-k8s-tests

prow/e2e-bookInfoTests-v1alpha3.sh
4e5c595d136203605758a897be8a0f62ab245333
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test e2e-bookInfoTests-envoyv2-v1alpha3


[question] generics + computed properties

Goal:
sorting T[] where T has passed in property of type number
const numericSortBy = <T, P: $Keys<T>>(prop: P, arr: T[]): T[] => {
  return arr.sort((elementA, elementB) => elementA[prop] - elementB[prop])
}

numericSortBy('order', [ { order: 1 }, { order: 5 } ])

Ive played around with various forms already, but cannot bend the flow to my will here and I guess this should be possible. Maybe somebody could help me with that.
First of all I dont understand why "Computed property/element cannot be accessed on T" - I've specified prop as $Keys<T> after all. Beside that I have not idea how to specify that T has this computed property of type number.
flow playground

Flow needs to be told that T is an object.
const numericSortBy = <T: Object, ...

@jcready Thank you! That definitely answers my first question.
Can I specify though that this property I want to sort by has a number type?

I don't believe there is a way to do that in flow.

@calebmer would it be possible? should I file a feature request for this? Would be super handy in my opinion


Filter issue final project

I've been trying to create a tab where it sorts accidents by weather condition, but nothing shows up when I render the dashboard. I'm very stuck on the filtering system: I think I've set the weather variable correctly, but this does not seem to be the case.

Turns out I mistyped a variable; sorry!


ERROR: 'SolverParameter' object has no attribute 'RMSPROP'

when I try the Getting Started,a bug shows up.
Traceback (most recent call last):   File "digits/scheduler.py", line 512, in run_task     task.run(resources)   File "digits/task.py", line 189, in run     self.before_run()   File "digits/model/tasks/caffe_train.py", line 218, in before_run     self.save_files_classification()   File "digits/model/tasks/caffe_train.py", line 597, in save_files_classification     if solver.solver_type == solver.RMSPROP: AttributeError: 'SolverParameter' object has no attribute 'RMSPROP'
system:ubuntu16.04 ;
I used the caffe which have been rewrited.
Is something wrong in caffe I used or digits?  Could someone help me?

when I delete this code:if solver.solver_type == solver.RMSPROP: AttributeError: 'SolverParameter
my train recovered.
But I want konw the real reason why this bug arised.

How you delete this code ?


leafmap.foliumap.image_overlay does not work

leafmap.foliumap.image_overlay does not work. It raises a NotImplementedError. Is there any newer version where this function has been impolemented?

This feature is for ipyleaflet only. Folium has very limited functionality. It doesn't support this. There's not much I can do


[🐛 Bug]: Your worker created multiple branches of a single stream

next-on-pages environment related information
I was sent here after the guys from Clerk checked this out, apparently this is an issue with CF/Next.
Description
This is happening when using Cloudflare Pages after logging in:
✨ Compiled Worker successfully
 ⛅ wrangler 3.28.1
-------------------
Using vars defined in .dev.vars
Your worker has access to the following bindings:
- Vars:
  - NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: "(hidden)"
  - CLERK_SECRET_KEY: "(hidden)"
⎔ Starting local server...
Parsed 1 valid header rule.
[wrangler:inf] Ready on http://localhost:8788
✘ [ERROR] INFO: Clerk: The request to / is being redirected because there is no signed-in user, and the path is not included in `ignoredRoutes` or `publicRoutes`. To prevent this behavior, choose one of:

  1. To make the route accessible to both signed in and signed out users, pass `publicRoutes: ["/"]`
  to authMiddleware
  2. To prevent Clerk authentication from running at all, pass `ignoredRoutes:
  ["/((?!api|trpc))(_next.*|.+\.[\w]+$)", "/"]` to authMiddleware
  3. Pass a custom `afterAuth` to authMiddleware, and replace Clerk's default behavior of
  redirecting unless a route is included in publicRoutes

  For additional information about middleware, please visit https://clerk.com/docs/nextjs/middleware
  (This log only appears in development mode, or if `debug: true` is passed to authMiddleware)

[wrangler:inf] GET / 307 Temporary Redirect (293ms)
[wrangler:inf] GET / 401 Unauthorized (3ms)
[wrangler:inf] GET /favicon.ico 304 Not Modified (8ms)
[wrangler:inf] GET / 200 OK (5276ms)
✘ [ERROR] Your worker created multiple branches of a single stream (for instance, by calling `response.clone()` or `request.clone()`) but did not read the body of both branches. This is wasteful, as it forces the system to buffer the entire stream of data in memory, rather than streaming it through. This may cause your worker to be unexpectedly terminated for going over the memory limit. If you only meant to copy the request or response headers and metadata (e.g. in order to be able to modify them), use the appropriate constructors instead (for instance, `new Response(response.body, response)`, `new Request(request)`, etc).

[wrangler:inf] GET /vercel.svg 304 Not Modified (6ms)
[wrangler:inf] GET /next.svg 304 Not Modified (7ms)
[wrangler:inf] GET /_next/static/chunks/983-c740277b6d3702da.js 200 OK (8ms)
[wrangler:inf] GET /_next/static/chunks/app/page-cf19a580b1879b0e.js 200 OK (6ms)

Reproduction
You can download this example project and test: https://github.com/Mecanik/clerk-nextjs-cloudflare
Pages Deployment Method
None
Pages Deployment ID
No response
Additional Information
Thanks
Would you like to help?

[ ] Would you like to help fixing this bug?

@dario-piotrowicz Where are you... :smiley:

This is a bug in wrangler, not next-on-pages:
https://github.com/cloudflare/workers-sdk/issues/3259

@Mecanik sorry I'm lately been pulled on some other projects and haven't had time to take care of issues here as much as I would like 🙇 😓
I'll try to find the time and give this a look soon 🙇
By the way, I am not completely sure why but this "error" from our runtime is actually a warning since when it happens nothing is really broken 😕 (but resources are likely being wasted), so even if you see it, everything should still work as you'd expect it to, no?

This is a bug in wrangler, not next-on-pages: cloudflare/workers-sdk#3259

The issue there is specific on when you use the functions/ directory (as the logic that takes that code and bundles it into a worker makes it so that requests get cloned more than they should).
Next-on-pages does not use the functions/ directory but uses the Pages advance mode instead, so I do not believe this to be an issue in wrangler, I think that the issue either resides in either:

next-on-pages (unlikely since we never clone requests)
clerk (a bit unlikely since they send Mecanik here....?)
Next.js (likely by exclusion?)

quick update, I've started looking into this and by debugging it seems like the error is triggered when you call clerk's currentUser, the issue however seems to come form Next.js code, specifically this
what I think it's happening (I not 100% sure yet) is that currentUser performs a fetch and Next.js eagerly clones the response so that the app can read its body as many times as it wants, thus performing this cloning even when not needed, causing the error to show up
(this is actually quite similar to what happens in wrangler with the functions/ directory! the only difference being that we do that for the request and not the response)

Ok, I think my above assessment was correct, please have a look at this repository: https://github.com/dario-piotrowicz/nextjs-cachedfetch-clone-issue-repro
It shows that the issue ultimately lies in Next.js' cachedFetch implementation.
I'll open an issue in the Next.js repo regarding this, but honestly I am not sure if they'll be interested in fixing this... we'll have to see 😓

Basically what's happening here is that Clerk is most likely fetching from the same endpoint more than once thus kicking off the cached fetch behavior offered by Next.js. This behavior however triggers the issue.
If Clerk could avoid fetching from the same endpoint more than once that would solve this issue, but I don't think they really should, as the root issue is really a Next.js one.
Needless to say, there isn't much that can be done regarding this on our side 🥲

Thanks @dario-piotrowicz . Things just get better and better...
So this issue occurs only in currentUser or every fetch they do? How does this affect the billing if you were to deploy a project like this?...

Hi @Mecanik, sorry above I was slightly mistaken, the issue is not that clerk fetches from the same endpoint but that they fetch at all! (see my revised reproduction: https://github.com/dario-piotrowicz/nextjs-cachedfetch-clone-issue-repro/commit/08261623e2046bfd0edae84be3d32406efdd4f5d)
So yeah it's fully a Next.js issue that clerk can do nothing about

So this issue occurs only in currentUser or every fetch they do?

is occurs in every single fetch that happens on the server
I just checked with the team and I am bringing the possibility to remove this warning as, I believe is unnecessary and doesn't really help much (on the contrary it creates confusions and worries), I'll keep you posted
Also I checked with the wrangler team and this, comes from the runtime as a warning not a real error: https://github.com/cloudflare/workerd/blob/5c9519e2faaeaf0f0c7ad1e184af9c29d060b459/src/workerd/api/streams/internal.c%2B%2B#L380
but it is displayed as an error by wrangler... I am yet to understand if this is intentional of it should be fixed 😕

How does this affect the billing if you were to deploy a project like this?...

I'll have to check with the team, I think that the effect on billing should be negligible at most, again since I think that this is not a real issue, but I'll try to get more infos for you 👍

Hi @Mecanik, sorry above I was slightly mistaken, the issue is not that clerk fetches from the same endpoint but that they fetch at all! (see my revised reproduction: dario-piotrowicz/nextjs-cachedfetch-clone-issue-repro@0826162)
So yeah it's fully a Next.js issue that clerk can do nothing about

So this issue occurs only in currentUser or every fetch they do?

it occurs in every single fetch that happens on the server
I just checked with the team and I am bringing the possibility to remove this warning as, I believe is unnecessary and doesn't really help much (on the contrary it creates confusions and worries), I'll keep you posted
Also I checked with the wrangler team and this, comes from the runtime as a warning not a real error: https://github.com/cloudflare/workerd/blob/5c9519e2faaeaf0f0c7ad1e184af9c29d060b459/src/workerd/api/streams/internal.c%2B%2B#L380 but it is displayed as an error by wrangler... I am yet to understand if this is intentional of it should be fixed 😕

How does this affect the billing if you were to deploy a project like this?...

I'll have to check with the team, I think that the effect on billing should be negligible at most, again since I think that this is not a real issue, but I'll try to get more infos for you 👍

Thank you for looking into this, really appreciated. I do not really understand why "caching" necessary on a fetch... but I tried export const forceCache = 'force-no-store' without success since it won't compile.
I do not have this issue with Auth0, however I am not using Auth0 because it has many limitations in terms of branding, etc; and it's quite expensive when scaling. So that's why I am here trying to use Clerk, as an alternative for registration/authentication for NextJS.
But the absolute real reason I am doing this is because I created my own user system with next-on-pages, but I have a ton of "hydration" errors (which make no sense to me). I would have preferred to use my own system, with D1, where everything is under control and works properly...
If this cannot be resolved, I will have to let both Auth0 and Clerk and go with mine. Probably going to publish the repo so others can benefit and why not contribute.
Thanks again.

I have same issue here as well, I'm also getting worker limit exceeded error after deployment and after refreshing the page for couple of times. Not sure if this is related to this worker thing

Most likely because of the bug cloning responses...

Hi @dario-piotrowicz
Do you think this is something that will be fixed any time soon? We are on paid plan on CF and this is blocking us from deploying to CF.

Hi @anonymouscatcher, I'm sorry that you're being blocked
From your comment

I have same issue here as well, I'm also getting worker limit exceeded error after deployment and after refreshing the page for couple of times. Not sure if this is related to this worker thing

It seems like you're getting a worker limit exceeded error? that is, I think, likely something unrelated, could you maybe open a new issue sharing the error message you get and as much info as you can? (and I'll look into it right away)
(Regarding the multiple branches issue, I'll try to think of a solution, but I am afraid that that is likely not achievable and that it would require a breaking change in Next.js itself 😕)


fix: support value !important;

Fix an edge case that position:sticky!important can be prefixed while position:sticky !important (a white space before !important) can not.

Pull Request Test Coverage Report for Build 1de815826e5401fdff4c05b295ea9ee686b032ce-PR-289

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 98.835%

Totals

Change from base Build c3c05cd233b50a72c146c2dbf1d5513cf61b0c94:
0.004%

Covered Lines:
270

Relevant Lines:
272

💛  - Coveralls

As always, thanks: published 4.1.1 with both of these.


Consider --config-dir to read in multiple configuration files

Is your feature request related to a problem? Please describe.
aws-iot-device-client has the flag --config-file which allows a single
monolithic configuration file.
It is possible that an installation could have any number of features,
making some of the json structures in the template irrelevant or even
trigger unnecessary behavior.
Describe the solution you'd like
Instead of pointing to a single file, point to a directory and read
any number of individual configuration files that contribute to the
overall configuration. This behavior is consistent with most
UNIX, Linux, and UNIX-like derivative systems.
Describe alternatives you've considered
JSON parsing at installation time.  It hurts.
Additional context
Please contact internal AWS if more information needed.

HI @rpcme, thank you for your inputs. We believe that providing a "config-dir" option will create potential ambiguity when accepting multiple config files as input. For example, do overlapping entries overwrite or append? do we establish order of the config files?
Instead, we currently offer a way for customers to be more specific, by using
./aws-iot-device-client --config-file you/config-file/path
See our demo documentation for more details:
./aws-iot-device-client --config-file ~/dc-configs/dc-pubsub-config.json
Please let us know if you have any more questions, or if you have a specific use case that requires the customer to point to a config directory. We will be deprioritizing this issue for now.


add free-courses-id tailwindcss and machine learning

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
Add resources
For resources
Description
course for tailwindcss and machine learning
Why is this valuable (or not)?
valuable
How do we know it's really free?
source from youtube
For book lists, is it a book? For course lists, is it a course? etc.
course
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

can also remove (YouTube)

is this include label for hacktoberfest?


⚠ Bofrost.at has degraded performance

In a7e68ca, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2648 ms

Resolved: Bofrost.at performance has improved in 373d685 after 13 minutes.


Executable JAR with banner

Coverage remained the same at 94.34% when pulling e98fb480069714e90258b18d2acbc19f04a652ac on executable-jar into bf2b44b33b46175a367e08dc4303ad35277b20a3 on develop.


Develop 48 config docs

closes #48
The updated configuration documentation can be found here
Also adds some minor code changes, including adding configuration data checks to several objects that were missing them and applying MUSICA style to a few modules that I missed earlier.

Codecov Report

Merging #124 (40a9a82) into main (ee0dc36) will increase coverage by 0.05%.
The diff coverage is 86.68%.

:exclamation: Current head 40a9a82 differs from pull request most recent head b7c0ab0. Consider uploading reports for the commit b7c0ab0 to get more accurate results

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   81.16%   81.22%   +0.05%
==========================================
  Files         100      100
  Lines        5140     5257     +117
==========================================
+ Hits         4172     4270      +98
- Misses        968      987      +19

Impacted Files
Coverage Δ

src/grid_warehouse.F90
78.72% <0.00%> (-21.28%)
:arrow_down:

src/photolysis_rates.F90
91.30% <ø> (ø)

src/profiles/surface_albedo.F90
0.00% <0.00%> (ø)

src/profile_warehouse.F90
93.61% <70.00%> (-6.39%)
:arrow_down:

src/profiles/from_csv_file.F90
89.85% <86.66%> (+1.33%)
:arrow_up:

src/grids/from_csv_file.F90
91.42% <87.50%> (+1.77%)
:arrow_up:

src/profiles/o2.F90
90.00% <88.23%> (+1.11%)
:arrow_up:

src/radiative_transfer.F90
84.48% <88.88%> (+1.79%)
:arrow_up:

src/profiles/o3.F90
91.20% <90.90%> (+0.96%)
:arrow_up:

src/profiles/air.F90
91.66% <91.42%> (+0.64%)
:arrow_up:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Look into using official Fedora packages for our Fedora CI

This could also be an additional leg - we could add Fedora Rawhide using the Fedora-built source-build-reference-packages and additional Fedora-built tooling rather than using the Microsoft Fedora docker-build-prereqs image that includes binaries that cannot ship in Fedora.

Using the N-1 versions of the SDK and SBRP from Fedora may be an option that is more easily maintainable without using their build spec.  This would validate that we can build with these without needing the Fedora infra.  The N-1 versions should be included in a text file in the source-build repo.

Source-build CI does a bootstrap build here.  Note this is only done for one version of Fedora - not every distro/version tested in CI.


Typescript types are not available in @next version

Currently, I'm using the last stable version of Excalidraw NPM package v0.17.3 in my project.
This works great, thank you for this wonderful project.
The problem happens when I try @next version of the package which seams lacks any TypeScript types which makes it unusable in TypeScript project.
Before, I could do something like this:
import {
  AppState,
  BinaryFiles,
  ExcalidrawImperativeAPI,
  ToolType
} from '@excalidraw/excalidraw/types/types';

But this is not working anymore.
I have a suspicion that the issue was introduced in the following commit: https://github.com/excalidraw/excalidraw/commit/a8064ba3eef10fa50bf5d9f402b779d54558ae76#
If yo look at package.json file changes you will see this:
Before:
"files": [
     "dist/*",
     "types/*"
   ],

After:
"files": [
     "dist/*"
   ],

Is this intentional?
How can we import types now?

Hi @alex-titarenko the path for importing types has been updated in next release. You should be able to import it from
import {
  AppState,
  BinaryFiles,
  ExcalidrawImperativeAPI,
  ToolType
} from '@excalidraw/excalidraw/dist/excalidraw/types';

Basically @excalidraw/excalidraw/types/ -> @excalidraw/excalidraw/dist/excalidraw
Here is working demo using the next version as well.
However before the final stable release, the path of importing type might change but I will try to add a script to update the paths so that upgrade is easy and smooth

Hi @alex-titarenko the path for importing types has been updated in next release. You should be able to import it from
import {
  AppState,
  BinaryFiles,
  ExcalidrawImperativeAPI,
  ToolType
} from '@excalidraw/excalidraw/dist/excalidraw/types';

Basically @excalidraw/excalidraw/types/ -> @excalidraw/excalidraw/dist/excalidraw
Here is working demo using the next version as well.
However before the final stable release, the path of importing type might change but I will try to add a script to update the paths so that upgrade is easy and smooth

Thank you for your reply, for some reasons still not working for me:

Same error when I try to compile the code

Hi @alex-titarenko the path for importing types has been updated in next release. You should be able to import it from
import {
  AppState,
  BinaryFiles,
  ExcalidrawImperativeAPI,
  ToolType
} from '@excalidraw/excalidraw/dist/excalidraw/types';

Basically @excalidraw/excalidraw/types/ -> @excalidraw/excalidraw/dist/excalidraw
Here is working demo using the next version as well.
However before the final stable release, the path of importing type might change but I will try to add a script to update the paths so that upgrade is easy and smooth

Thank you for your reply, for some reasons still not working for me:

Same error when I try to compile the code

Can you take a look at the demo shared (the types work fine as well in the example) and probably share a codesandbox example so I can take a look? Additonally if you can try using intellisense to auto import types, that would fix the issue as well.

Hi @alex-titarenko the path for importing types has been updated in next release. You should be able to import it from
import {
  AppState,
  BinaryFiles,
  ExcalidrawImperativeAPI,
  ToolType
} from '@excalidraw/excalidraw/dist/excalidraw/types';

Basically @excalidraw/excalidraw/types/ -> @excalidraw/excalidraw/dist/excalidraw
Here is working demo using the next version as well.
However before the final stable release, the path of importing type might change but I will try to add a script to update the paths so that upgrade is easy and smooth

Thank you for your reply, for some reasons still not working for me:

Same error when I try to compile the code

Can you take a look at the demo shared (the types work fine as well in the example) and probably share a codesandbox example so I can take a look? Additonally if you can try using intellisense to auto import types, that would fix the issue as well.

I see that it's working in demo but not in my case, also I checked the node_modules folder and there is no types directory at all

The issue appeared to be related to my tsconfig
I have
"moduleResolution": "bundler"

Is there any chance to make excalidraw types import compatible with this setting?
It worked before but not with the @next one. Without that setting my project would not build.

Yeah, we'll need to fix that, for sure.
Currently, the configs it works with/doesn't AFAIK are as follows:

module: "commonjs" :white_check_mark:
module: "ES***" with moduleResolution: "bundler" :x:
module: "NodeNext" :x:

Same issue for me.


\ufeff problem in every first word of a text

\ufeff is added somewhere during string processing - probably encoding is missing somewhere

@amustafali with encoding="utf-8-sig", it should not be a problem. Check and update us.

@smr3mdv I have already fixed that.


add dockerfile highlighting

Thanks for contributing! Would you mind taking a look at my comments?
Also, you need to rename the JS file from prism-docker.js to prism-dockerfile.js, since the component is dockerfile.

Thanks for the awesome feedback.  I updated the PR with all of the requested updates.  Let me know if there's anything else!

@JustinBeckwith Sorry for the delay. Your updates look good to me. You did not add the LABEL keyword though, is it intended?
@LeaVerou, if it looks good to you too, feel free to merge this. I'll run the gulp task to generate the minified file if you don't have the time to do so.

That was an oversight :) Thanks again!

Ohh exactly what I was looking for, any idea when it will be merged?
(As I'm currently using bower so its nifty if I don't have to modify files within bower components)
/BR


[WIP] Action server for JointTrajectoryController (Waiting for PR #25)

Issue  #12
Depends on PR #25

Includes functionality to cancel actions.
Feedback posts joint names and timestamps at the moment based on parameter 'action_monitor_rate'.

I know this is a WIP but please remember:

@ddengster this is currently failing to build. Please rebase on master and push again.

ok, i think this is ready for review. @bmagyar @piraka9011 @Karsten1987
Take note that the whole bunch of warnings in test_trajectory_actions is caused by realtime_tools, and a PR is already ready to be merged over there. I couldn't find a line of fail/error in the logs, I suspect the test fails because of the large number of warnings/prints? In any case I'll look into it once the realtime_tools PR is merged.
Regarding the copyright issue in tolerance.hpp, it was previously this: "Copyright (C) 2013, PAL Robotics S.L." Should I change it to "Copyright 2020 Open Source Robotics Foundation, Inc." to solve the issue?

pretty heavy PR ;-)

I had intended to make this PR short, the side effect being that it is less viable for usage. Then the earlier PR was taking a little long so I made this PR more complete and functional for use - I can pretty much use it for my own tasks now.

I've got a few inline comments, but mainly two points I'd like you to address:
* The `update()` function is massive and pretty confusing to follow.

* The `sample()` function is similarly big.

Can these two functions be somehow refactored to easily read through it?

We could always move the lambda functions away to a member class function, move JointTrajectoryPoint state variables to class headers. But this just sweeps the complexity away, and introduces more code in which you have to wonder about where it's being used or linked.
Here's a link that elaborates on this issue.
I can see a way to simplify the control flow in the update function. I'll make a change soon.
The sample function seems fine to me control-flow wise. The size of both functions is 100-150 lines long; it's not that large imho.

@Karsten1987 @ddengster there is ongoing work for ROS Noetic (maybe Melodic too) to make the joint trajectory controller friendlier for subclassing and better structure the update function.
Ref: https://github.com/ros-controls/ros_controllers/pull/454
I would lean towards letting this PR fly as long as it meets all functional requirements and adds a decent amount of testing. We should open an issue to gather the takeaway from the above PR and implement something similar here.

Alright, the tests are all passing. Please review test_trajectory_actions.cpp if you havent done so.

a first round of CI:

Linux
Linux-aarch64
macOS
Windows

@ddengster it looks like there is some missing dependency to angles.

do you have a path forward with the angle dependency for the failing build?
Other than trying all sort of changes to travis/workspace.repos and rerunning the jenkins build (which I have yet to get access to), nope.

jenkins retest this please

retest this please

retest-this-please

@ros-pull-request-builder retest this please

@Karsten1987 i've changed the <> around angles/angles.h to quotes. Try running CI again.

@ros-pull-request-builder retest this please

@ros-pull-request-builder retest this please

Linux
Linux-aarch64
macOS
Windows

@ddengster the build request builder might not work because it's not released for foxy.

Waiting on windows errors: https://github.com/ros/angles/issues/24

Devil's advocate: I wouldn't mind merging without Windows if that saves us another month of this PR dangling in the wind.

ci tests are passing now

Linux

aarchLinux

macOS

Windows
has warnings from realtime_tools, will not fix in this pr

again, review test_trajectory_actions.cpp if you havent done so

I created a bunch of follow-up tickets:
https://github.com/ros-controls/ros2_controllers/issues/38, https://github.com/ros-controls/ros2_controllers/issues/39. https://github.com/ros-controls/ros2_controllers/issues/40, https://github.com/ros-controls/ros2_controllers/issues/41, https://github.com/ros-controls/ros2_controllers/issues/42

@ddengster thanks very much for hanging in there for this loooooooooong review.
For future PR-s please make sure to submit PR-s up to 500 lines of total changes and one feature at a time to ensure we can accommodate your changes in a timely manner.
I've opened a bunch of follow-up tickets, feel free to tackle them yourself or leave it to others.

@ddengster do you mind having a look at this?

im running it and im not getting a broken test. how are you getting this timeout? are you on foxy or eloquent?