Slug endpoint instead of id

Hello Samuel,
Thank you very much for this good example, I am developing a site based on your example, but I want to make the endpoints of blog posts slug instead of id, for this, when I use the slugify library and implement it as follows, APIResponseError: path failed validation: path.page_id should be a valid uuid error is coming.
index.js

[slug].js

The remaining codes are as you did. How do I get rid of this error? Since I'm just starting out, I can't make sense of it and I couldn't find almost any resources on this subject. You are my only hope. :D

I forgot the notion page, so sorry.
notion.js

Hi! The API still expects a page id, you cannot query on the slug. In getStaticProps in [slug].js you need to figure out the page id based on the slug. You can do that by first fetching the database (const database = await getDatabase(databaseId);), and then filtering the results based on the page slug.
I did something similar in my old blogpost before the official API was out but the logic is the same:
export const getStaticProps: GetStaticProps = async context => {
    const bookRes = await fetch(https://notion-api.splitbee.io/v1/table/[NOTION_TABLE_ID])
    const bookData = await bookRes.json()

    if (!bookData) {
        return {
            notFound: true,
        }
    }

    const { slug } = context.params
    const book = bookData.find(b => slugify(b.name, { lower: true }) === slug)

    const pageRes = await fetch(`https://notion-api.splitbee.io/v1/page/${book.id}
    const pageData = await pageRes.json()

      return {
        props: {
          book,
          page: pageData,
        },
        revalidate: 1,
      }
    }

You can also take a look at this course, I haven't watched it but looks like it does the same thing but with the official API here.

Thank you for answer @samuelkraft , but when I implement this I get this error: A required parameter (slug) was not provided as a string in getStaticPaths for /blog/[slug].
This is before:

And this is after:

But when I do that, I get 404 error. I don't really catch the solution. What do you suggest I do?


Control Tower: Sender-side checks for duplicate payments #2

This PR is an extension of #1070, mostly just touching up documentation. The only thing that is new in the PR is the reordering of logic w/in handleLocalDispatch, which should result in better clean up of circuits and fwd references. This was going to be done in a separate PR, but the changes were overlapping enough that I made them here.

@vapopov rebased w/ split commits

I've also added a strict flag to the current ControlTower implementation. This is meant to be more tolerant of payments that could already have duplicate payments in flight. The stricter state machine would cause issues if enabled immediately, because there could be db's in such a state with duplicate payments. It also means that we don't need to inspect the circuit map during migration, which would require a bit of a code move to be able to parse and find the payment hashes of already in flight payments.
In the future, we can default to the stricter state machine once we are confident that old payment states have been resolved/cleanedup.

Noticed that the performance hit of doing serial state transitions caused the async_payment_benchmark to timeout. In response, three commits have been added, which:

reduces the number of db calls from 2 to 1 for each state transition
removes the ControlTower's exclusive lock, so that we can utilize bolt's Batch txns
made all handling of local response asynchronous, so that db transactions don't affect the critical path of the switch's primary event loop

Great work on this @vapopov 🎉


Having issues with maven BOM files

I’m using
implementation org.springframework.boot:spring-boot-dependencies:2.0.3.RELEASE
to import a maven bom file however when the pom file is generated for the artifact this gets included in the file:
<dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-dependencies</artifactId>
      <version>2.0.3.RELEASE</version>
      <scope>runtime</scope>
</dependency>

now if I use this dependency in a maven project it fails since it is looking for a jar artifact not a pom
, is this a bug or is expected behaviour?
I would expect that when the pom file is generated for the artifact it will create something like this:
   <dependency>
      <groupId>org.springframework.boot</groupId>
      <artifactId>spring-boot-dependencies</artifactId>
      <version>2.0.3.RELEASE</version>
      <scope>import</scope>
   </dependency>

I'm currently using Gradle 4.8

Closing as duplicate of #4543
Note that the issue will be fixed in Gradle 5.0 for the maven-publish plugin and using the new syntax for BOM consumption.


CI test automation script for KubeadmConfig commands to be mutated

What this PR does / why we need it:
This PR adds automation test script for when KubeadmConfig commands need to be changed / users should be able to update KubeadmConfig commands during the upgrade, this PR is needed to automate manual testing of the upgrade process of kcp.

/cc @Xenwar
/cc @Jaakko-Os
/cc @smoshiur1237

looks good!

@Xenwar requested changes are addressed, can you please check?


KAFKA-8499: ensure java is in PATH for ducker system tests

The openjdk docker images used include java binaries at /usr/bin. It has since been moved to /usr/local/openjdk-VERSION/bin, which will cause problems when the system tests invoke any java binary if the latest openjdk image has been pulled. The openjdk images have been updated with the same tag, so this can happen suddenly without any other code changes if the new version is pulled.
The primary symptom is that ZooKeeper will fail to start due to java not being found when running the system tests in ducker.
This PR allows PermitUserEnvironment, and sets the ducker user's .ssh/environment to include JAVA_HOME/bin in its path. We cannot set it via the ducker user's .profile as ssh commands will not use the shell.

LGTM


.setProps() doesn't trigger componentDidUpdate lifecycle method

When using shallow, the .setProps() method doesn't trigger the componentDidUpdate lifecycle method. However, .setState() does trigger it. It seems like they both should (or both shouldn't).
simple example
describe('MyComponent', () => {
  let spy;

  before(function() {
    spy = sinon.spy(MyComponent.prototype, 'componentDidUpdate');
  });

  after(function() {
    spy.restore();
  });

  // fails
  it('calls componentDidUpdate when setting props', () => {
    const wrapper = shallow(<MyComponent color="yellow" />);
    wrapper.setProps({ 'color': 'green' });
    expect(spy.calledOnce).to.be.true;
  });

  // passes
  it('calls componentDidUpdate when setting state', () => {
    const wrapper = shallow(<MyComponent color="yellow" />);
    wrapper.setState({ foo: 'bar' });
    expect(spy.calledOnce).to.be.true;
  });
});

FWIW, setProps is being deprecated.
https://github.com/facebook/react/pull/5588/files
http://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#new-deprecations-introduced-with-a-warning

@blainekasten thanks for that info. Funny - I didn't even know .setProps() existed as a real API.
The deprecation doesn't affect us in this case, since .setProps() is achieved using setState() of a parent wrapper component, anyway.

At the moment I'm doing
const prevProp = wrapper.props()
wrapper.setProps({
  current_step: 2,
})
// forces an update call to componentDidUpdate - https://github.com/airbnb/enzyme/issues/34
wrapper.instance().componentDidUpdate(prevProp)

+1, how correctly to solve the problem?)

@yzimet does this occur if you use mount as well, or is it unique to shallow?

I'm also performing similar hacks to what @CurtisHumphrey mentioned above.
I wonder what the preferred way of achieving this is, if not with setProps? I have yet to dig in too deep myself, but this is something I am definitely interested in contributing to. It looks like https://github.com/airbnb/enzyme/pull/318 is on a good track.

I have exact the same issue but with mount renderer.

#318 is now merged. Do we know if this is still a problem? Can any of the affected devs here confirm?

hi @blainekasten I'm using the latest release 2.4.1 and it still hasn't fixed the issue. I ended up having to use mount to trigger the componentDidUpdate. Would love to just use shallow instead

@bricejlin
#318 is hidden in the lifecycleExperimental  flag.
You can do with the flag for enabling all lifecycle methods in shallow.
shallow(<Foo />, { lifecycleExperimental: true })

Closing since this should be resolved by using lifecycleExperimental flag.

hi @koba04  do you know if lifecycleExperimental should works in react-native?
https://github.com/airbnb/enzyme/issues/1279

In react-native lifecycleExperimental works for componentDidMount() but not for componentDidUpdate().
"name": "enzyme",
"version": "3.1.0",

"react": "16.0.0",
"react-native": "0.47.2",

FWIW, I think @CurtisHumphrey 's approach is closest to the best approach.  Why do people find it necessary to test if React fires a lifecycle event?  If React fails to go through lifecycle events, then React has a larger issue.  Testing if react fires a lifecycle event when a prop updates is pointless. The whole point of React is to "react" to prop and state changes.  It's like testing to make sure image.onload, or window.onload fires in a browser.  If these built-in browser events fail to fire in Chrome when they are supposed to fire, then Google is out of business the next day.
I think in general, people over-test things that don't need to be tested.  I also think that people forget that your React components are 90% vanilla javascript.
You don't always need enzyme. React is just javascript.  If your ES6 class constructor looks like this...
constructor(props) {
  super(props);
  // other stuff here...
}

Then you can test if componentDidUpdate works correctly, without having to test if React fires it when it's supposed to fire it.
describe('componentDidUpdate()', () => {
  it('should do something', () => {
    const prevProps = { // define previous props };
    const prevState = { // define previous state if needed };
    const instance = new MyComponent({ // new props go here });
    instance.state = { // if you need a new set state, set it here };
    // some method called by componetDidUpdate when there is an update.
    instance.someMethod = jest.fn();
    instance.componentDidUpate(prevProps, prevState);
   // expect stuff here.
   expect(instance.someMethod).toHaveBeenCalledWith( stuff );
  })
})

This is what is called "unit testing" a class method.   Enzyme shallow() is not a unit test.  It is an integration test.  Enzyme shallow() mounts a shallow version of a component in a virtual browser.
A true unit test only focuses on a function or method.
The test above tests the inputs of the componentDidUpdate() class method, tests the expected side effects of the class method, and does all of this without redundantly testing if React works.
I like Enzyme, but it is not always the answer.

@mrbinky3000 First, you should be using testing a component the way it's used - new MyComponent is never how it's used in production, so that test is not very valuable.
As for "integration test", everything should be an integration test - if it's not one, then your test has to have knowledge about the implementation under test, which is coupling, and makes your tests more brittle.
Enzyme certainly isn't always the answer, but setting up a contrived scenario to test something in an environment in which it never runs in production gives you nothing but false confidence.

Sorry if this was off-topic.  I can discuss this further offline if you want.  I've been thinking about this for a while now and would like to know more about why you think this is bad.  But here are some things to consider.

All tests are contrived.
If you properly unit test all the class methods and/or functions for a given Component, then the sum of your units should be ok.  Garbage in garbage out, and vice versa.
You still need integration tests like shallow and mount.  For example, I still use them to test any conditional statements in a render() method.  My argument is that people need a fraction of the shallow and mount tests than they create today.

The sum of your unit tests is not equal to integration tests. You might be able to “get by” with more focused unit tests and fewer wrappers, but those aren’t better tests - those are more contrived since, unlike the wrappers, they don’t mimic production usage.

Solved it by using
wrapper.setProps({
user: {
test: {error: "test"}
}
});
    wrapper.find('.smth').simulate('click');

Works as a charm, setprops are set, you just need to call a function again that triggers the component o re-render, it will trigger the componentDidUpdate function

The latest update seems to broke this again.
node_modules/enzyme/build/ShallowWrapper.js
line 552
if (lifecycles.componentDidUpdate && typeof instance.componentDidUpdate === 'function' && (!state || (0, _Utils.shallowEqual)(state, _this3.instance().state))) {
instance.componentDidUpdate(prevProps, state, snapshot);
}
The last condition make it that only state change will trigger instance.componentUpdate,

@LiangMingChen could you file a new issue about this, and fill in the entire issue template? That would really help it get fixed quickly.

@ljharb @LiangMingChen I'm encountering that as well, was the issue created ?

Nope, please file one :-)

Nope, please file one :-)

Turns out it works sorry

Sorry to bring an old thread back up, but I'm running into a similar issue detailed here, and I can't seem to find any other solutions when searching. Here's my test:
  it('should reset gridWrapperNode scrollTop position if data has changed', () => {
    const mounted = mount(<Grid {...props} />);

    const gridNode = document.createElement('div');
    const gridWrapper = document.createElement('div');

    gridWrapper.classList.add('datagrid-grid-wrapper');
    gridNode.appendChild(gridWrapper);

    mounted.instance().gridNode = gridNode;

    gridWrapper.scrollTop = 40;
    mounted.instance().lastScrollTop = 40;

    mounted.setProps({
      ...props,
      data: [{ val: 'someNewData' }],
    });

    // mounted.instance().componentDidUpdate({});

    expect(gridWrapper.scrollTop).toEqual(0);
    expect(mounted.instance().lastScrollTop).toEqual(0);
  });

When I uncomment out // mounted.instance().componentDidUpdate({});, it works as expected, however I'm expecting the componentDidUpdate method to be called with the props changing. I checked, the props are updating as they should so I was wondering if this is a known issue or if it's something I'm doing wrong?

@Jmac1523 try adding mounted.update().

@ljharb I tried, unfortunately to no avail. Is the test less-effective or even ineffective with mounted.instance().componentDidUpdate({});?

@Jmac1523 can you file a new issue?

sure, thanks for getting back to me!

@Jmac1523 that instance call will only work on state based components. I suppose lifecycle methods only exist in those but then there is the challenge of testing the useEffect method (on update, render, etc.). IMHO there needs to be some support for this from the Enzyme team. shallow doesn't buy you much as Enzyme shallow isn't going to be tied into your lifecycle methods.

Err...I know, I never said I was using Hooks

@Jmac1523 I realize that but with so many components being developed with hooks and moving away from state based it's worth noting. If you find any leads on this let me know. I'm doing some research on a state based approach now.

@Jmac1523 and everyone else. This solution seems to work nicely for testing state-based component lifecycle methods:
  it('should call componentDidUpdate', () => {     let node = document.createElement('div');     let instance = ReactDOM.render(table, node);     const spy = jest.spyOn(Table.prototype, 'componentDidUpdate');     ReactDOM.render(modifiedTable, node);     expect(spy).toHaveBeenCalled();   })
Ultimately what I'm doing here is setting the table (JSX) on the DOM then just loading in a table with modified properties. Here's the table in Jest:
`
const justTheTable = (

{({ filter }) => {
return (
<>
Hello Spec
</>
);
}}

);
const table = (

{justTheTable}

);
`
This is hitting that component during runtime:


B-18668 Adding elevated rights supervisor choice

Summary
Adding a new Privileges section under the Create/Edit pages of Office Users in the Admin application. The Customer and Contracting Officer roles should not be allowed to have Supervisor privileges. This new privilege is not a required field.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?
How to test
Login to the Admin application
Choose to Create a new office user
You should see a new Privileges section under the Roles checkboxes. This will show a Supervisor checkbox.
Verify that if you choose the role of Customer or Contracting Officer, you should not be able to choose the Supervisor privilege choice.
Verify that if you first check Supervisor, that you cannot choose the Customer or Contracting Officer roles checkboxes.
Verify that you can create and save a new user with the Supervisor privilege.
Choose an already existing Office user, click on the user to go into the Edit screen. Verify that all the same logic from steps 3-6 applies to this page as well.
Verify that you can export the office users and see the new privileges column in the spreadsheet.
Alter some users in the spreadsheet to now have Supervisor privileges, or remove supervisor privileges from one that have it and import the changes. Verify that you see those changes in the application now for those users.

Warnings

:warning:

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.
View the frontend file org ADR for more information

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 97200d2024ad238ca135ac5cc30717c46dada4fd


Adding location to selectors

Description
This PR moves locations in filters to be inside "filters" -> "selector" and fixes #306
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[x] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
"what is outside the window"
BEFORE...
{'dialogue_type': 'GET_MEMORY',
 'filters': {'location': {'reference_object': {'filters': {'triples': [{'obj_text': [0,
                                                                                [4,
                                                                                4]],
                                                                        'pred_text': 'has_name'}]}},
                          'relative_direction': 'OUTSIDE'},
             'memory_type': 'REFERENCE_OBJECT',
             'output': {'attribute': 'NAME'}}}

AFTER...
{'dialogue_type': 'GET_MEMORY',
 'filters': {'memory_type': 'REFERENCE_OBJECT',
             'output': {'attribute': 'NAME'},
             'selector': {'location': {'reference_object': {'filters': {'triples': [{'obj_text': [0,
                                                                                [4,
                                                                                4]],
                                                                                'pred_text': 'has_name'}]}},
                                       'relative_direction': 'OUTSIDE'}}}}

Full paste here: https://www.internalfb.com/phabricator/paste/view/P392787589
Testing
Tested locally
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[x] I have added relevant collaborators to review the PR before merge.

Adding @aszlam to support the interpreter changes and @Rebecca-Qian  to support schema changes

I am not sure I understand ?
Can you point me to examples in the dataset with each key you mentioned above ?

interpreter changes are in, tests pass


allow resource path to be set in connection URI

This allows connection to a socket.io server that is using a path other than /socket.io/.

This is very useful. Some servers (like ours) don't use the default path and the library in its current state doesn't work with them,

Yes! This one should really be merged!

This fixes #191

Would be great if this could be merged!

Can this please be merged?

@myzinsky done, sorry for the delay.
As I noted in the commit message, please note that this implementation differs from the JS one, where the resource path is the namespace you want to reach:
const socket = io("https://example.com/my-namespace", {
  path: "/my-custom-path/"
});

Here, we will have:
sio::client h;
h.connect("https://example.com/my-custom-path/");
h.socket("/my-namespace")->emit("hello");


PathAccessException: Deletion failed, path = 'C:\Users\User\AppData\Local\Temp\ld_tool-1.0.0-1\app' (OS Error: The process cannot access the file because it is being used by another process. , errno = 32)

After close and open window application

Please fill the issue template by providing all the asked information.

I just wonder if there is any solution to avoid this exception. It happens when i copy build/window to another location and run it. I have to restart my pc to run it again because i can't find and kill that process.

i have same question

Please give the latest Flet version a try. If you happen to still face this problem, open a new issue with all the details.


added typeaheadOnBlur event

added documentation for typeaheadOnBlur
removed tab event key since blur event handles it
added getter to _active item

closes #1636

Codecov Report

Merging #1639 into development will increase coverage by 0.13%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1639      +/-   ##
===============================================
+ Coverage        84.84%   84.98%   +0.13%
===============================================
  Files               85       85
  Lines             2323     2324       +1
  Branches           299      298       -1
===============================================
+ Hits              1971     1975       +4
+ Misses             252      249       -3
  Partials           100      100

Impacted Files
Coverage Δ

src/typeahead/typeahead-container.component.ts
74.66% <100%> (+0.69%)
:white_check_mark:

src/typeahead/typeahead.directive.ts
76.79% <100%> (+1.52%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb4e5...4fde779. Read the comment docs.

@imribarr-compit looks good to me, but small change needed

BTW if you can add small test for this, it would be just awesome

@valorkin I've added a test for this. If you could just reply on my change request that would be great.
Thanks.

Looks good to me!


Get rid of specific types of Registries and move the driver dependencies up to the manager

This has been completed therefore I am closing this issue.


question about running in distributed training in a single node with multiple gpus

First, thanks for the great work.
When I run without distributed mode, it works fine: This means that it created "output/training/" folder and saved the training results there.
However, when I try to run in a distributed mode, it does not work in my case:

Using argument option --dist_url 'tcp://localhost:23456' or 'tcp://<IP_ADDRESS>:23456' => In this case, it does not even generate the output directory "output/training/"
Using default option --dist_url "env://", which means I did nothing but to use default config => In this case, it created an output directory correctly but training is not happening and there are some files like "events.out.tfevents.1682197067.pid.0", "opt.yaml" and "train.log". Although "opt.yaml" has information about training parameters, the size of "train.log" is 0, i.e. it contains nothing.
The thing I noticed is that in the file "opt.yaml" the value of gpu is 5, while our workstation has 10 GPUs.
What could be the problem and how could be solved?

Hello @yochju
I am not sure how it will behave with 10 GPUs. I have only tested it with 2 GPUs, but I guess you can safely run training on 4 GPUs as well. Can you try the following?
First, execute this command on the terminal:
export CUDA_VISIBLE_DEVICES=0,1,2,3
Then the following command:
python -m torch.distributed.launch --nproc_per_node=2 --use_env train.py <rest of the command>

Using 4 GPUs does not work either. I use the parameter --nproc_per_node=4 instead of 2.
Number of processes per node, workers, and world size, all should be 4 for G 4 GPUs, isn't it?
Anyway that does't count much, I attach the log file below.
===
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py:188: FutureWarning: The module torch.distributed.launch is deprecated
and will be removed in future. Use torchrun.
Note that --use_env is set by default in torchrun.
If your script expects --local_rank argument to be set, please
change it to read from os.environ['LOCAL_RANK'] instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions
FutureWarning,
WARNING:torch.distributed.run:

Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.

| distributed init (rank 2): env://
| distributed init (rank 3): env://
| distributed init (rank 1): env://
| distributed init (rank 0): env://
device cuda
Traceback (most recent call last):
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 540, in
Traceback (most recent call last):
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 540, in
main(args)
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 216, in main
main(args)
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 216, in main
OUT_DIR = set_training_dir(args['name'])
File "/home/juyongch/GPR/faster-rcnn/pyscript/utils/general.py", line 319, in set_training_dir
OUT_DIR = set_training_dir(args['name'])
File "/home/juyongch/GPR/faster-rcnn/pyscript/utils/general.py", line 319, in set_training_dir
os.makedirs('outputs/training')
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/os.py", line 223, in makedirs
os.makedirs('outputs/training')
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/os.py", line 223, in makedirs
mkdir(name, mode)
FileExistsError: [Errno 17] File exists: 'outputs/training'
mkdir(name, mode)
FileExistsError: [Errno 17] File exists: 'outputs/training'
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:209: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and may be removed in the future, please use 'weights' instead.
f"The parameter '{pretrained_param}' is deprecated since 0.13 and may be removed in the future, "
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:209: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and may be removed in the future, please use 'weights' instead.
f"The parameter '{pretrained_param}' is deprecated since 0.13 and may be removed in the future, "
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passing weights=FasterRCNN_ResNet50_FPN_Weights.COCO_V1. You can also use weights=FasterRCNN_ResNet50_FPN_Weights.DEFAULT to get the most up-to-date weights.
warnings.warn(msg)
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passing weights=FasterRCNN_ResNet50_FPN_Weights.COCO_V1. You can also use weights=FasterRCNN_ResNet50_FPN_Weights.DEFAULT to get the most up-to-date weights.
warnings.warn(msg)
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 3928580 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 3928581 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 3928578) of binary: /home/juyongch/anaconda3/envs/faster_rcnn_37/bin/python3
Traceback (most recent call last):
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 195, in
main()
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 191, in main
launch(args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 176, in launch
run(args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/run.py", line 756, in run
)(*cmd_args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 248, in launch_agent
failures=result.failures,
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
/home/juyongch/GPR/faster-rcnn/pyscript/train.py FAILED
Failures:
[1]:
time      : 2023-04-23_19:09:39
host      :
rank      : 1 (local_rank: 1)
exitcode  : 1 (pid: 3928579)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
Root Cause (first observed failure):
[0]:
time      : 2023-04-23_19:09:39
host      :
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 3928578)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

The command that you recommend seems working, it generated the output directory and training results are saved.
Previously I used the argument --nproc_per_node=10 for 10 GPUs and --nproc_per_node=4 for 4 GPUs, respectively, which didn't work.
So my question would be why --npeoc_per_node=2 is working and how is this argument --nproc_per_node related to the number of GPUs?

@yochju
Actually, by mistake I gave --nproc_per_node=2 for 4 GPUS, it should have been 2. It's interesting that it is working with --nproc_per_node=2. I will try to check this on a multi-GPU system. May take some time to debug though.

What strange is that it seems that it only works with --nproc_per_node=2 for how many CUDA_VISIBLE_DEVICES available.
FYI, I attach log below when I tried to run with --nproc_per_node=4

/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py:188: FutureWarning: The module torch.distributed.launch is deprecated
and will be removed in future. Use torchrun.
Note that --use_env is set by default in torchrun.
If your script expects --local_rank argument to be set, please
change it to read from os.environ['LOCAL_RANK'] instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions
FutureWarning,
WARNING:torch.distributed.run:

Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.

| distributed init (rank 2): env://
| distributed init (rank 3): env://
| distributed init (rank 1): env://
| distributed init (rank 0): env://
device cuda
Traceback (most recent call last):
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 540, in
Traceback (most recent call last):
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 540, in
main(args)
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 216, in main
main(args)
File "/home/juyongch/GPR/faster-rcnn/pyscript/train.py", line 216, in main
OUT_DIR = set_training_dir(args['name'])
File "/home/juyongch/GPR/faster-rcnn/pyscript/utils/general.py", line 319, in set_training_dir
OUT_DIR = set_training_dir(args['name'])
File "/home/juyongch/GPR/faster-rcnn/pyscript/utils/general.py", line 319, in set_training_dir
os.makedirs('outputs/training')
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/os.py", line 223, in makedirs
os.makedirs('outputs/training')
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/os.py", line 223, in makedirs
mkdir(name, mode)
FileExistsError: [Errno 17] File exists: 'outputs/training'
mkdir(name, mode)
FileExistsError: [Errno 17] File exists: 'outputs/training'
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:209: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and may be removed in the future, please use 'weights' instead.
f"The parameter '{pretrained_param}' is deprecated since 0.13 and may be removed in the future, "
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:209: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and may be removed in the future, please use 'weights' instead.
f"The parameter '{pretrained_param}' is deprecated since 0.13 and may be removed in the future, "
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passing weights=FasterRCNN_ResNet50_FPN_Weights.COCO_V1. You can also use weights=FasterRCNN_ResNet50_FPN_Weights.DEFAULT to get the most up-to-date weights.
warnings.warn(msg)
/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torchvision/models/_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passing weights=FasterRCNN_ResNet50_FPN_Weights.COCO_V1. You can also use weights=FasterRCNN_ResNet50_FPN_Weights.DEFAULT to get the most up-to-date weights.
warnings.warn(msg)
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 3928580 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 3928581 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 3928578) of binary: /home/juyongch/anaconda3/envs/faster_rcnn_37/bin/python3
Traceback (most recent call last):
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 195, in
main()
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 191, in main
launch(args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launch.py", line 176, in launch
run(args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/run.py", line 756, in run
)(*cmd_args)
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/home/juyongch/anaconda3/envs/faster_rcnn_37/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 248, in launch_agent
failures=result.failures,
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
= ===========================================================
/home/juyongch/GPR/faster-rcnn/pyscript/train.py FAILED
Failures:
[1]:
time      : 2023-04-23_19:09:39
host      :
rank      : 1 (local_rank: 1)
exitcode  : 1 (pid: 3928579)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

Root Cause (first observed failure):
[0]:
time      : 2023-04-23_19:09:39
host      :
rank      : 0 (local_rank: 0)
exitcode  : 1 (pid: 3928578)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
= ===========================================================

Trying to fix this.

Glad to hear that. How is it going?


Poetry run with local files breaks after 0.12.8

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS:  Any
poetry version: 0.12.8

Issue
After this commit which got released by 0.12.8, poetry run stopped working with local files.
Before I could do this
poetry run ./manage.py
....

and it would work. After a pip install -U poetry==0.12.8 this started happening
poetry run ./manage.py

[FileNotFoundError]
[Errno 2] No such file or directory: '/Users/jayson/Library/Caches/pypoetry/virtualenvs/cave-py3.6/bin/manage': '/Users/jayson/Library/Caches/pypoetry/virtualenvs/cave-py3.6/bin/manage'

run <args> (<args>)...

And this will happen both on macos and linux.
This is the exact lines that changed that made it stop working.
To test it I applied this patch on master
diff --git a/poetry/utils/env.py b/poetry/utils/env.py
index 2170b04..7175ca6 100644
--- a/poetry/utils/env.py
+++ b/poetry/utils/env.py
@@ -302,6 +302,8 @@ class Env(object):
         Return path to the given executable.
         """
         bin_path = (self._bin_dir / bin).with_suffix(".exe" if self._is_windows else "")
+        if not bin_path.exists():
+            return bin

         return str(bin_path)

And I ran poetry publish --build -n and installed the wheel with pip install to test if it worked and it seems that everything is good.

I probably got the same bug
On poetry:0.12.8:
poetry run atom ./

[FileNotFoundError]
[Errno 2] No such file or directory: '/home/topor/.cache/pypoetry/virtualenvs/spider-service-py3.6/bi
n/atom': '/home/topor/.cache/pypoetry/virtualenvs/spider-service-py3.6/bin/atom'

run <args> (<args>)...

It works ok when using poetry:0.12.7, so i downgraded for a moment

It should be fixed in the latest 0.12.9 release.


[Formatting] Relocate skip comments

Prep for autoformatting change.
This moves the script enforced skip comments from following the skip in a test, to being on the preceding line on a test. Script is being updated in a separate change. We found the formatter moved all of these to the next line, so we have moved them.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Closing as this was merged into the main format PR - which has now landed!


Fix #997, Simplify UT_InitData SB setup

Describe the contribution
Fix #997 - Removes confusing and incorrectly implemented deferred return code of -1 for CFE_SB_ReceiveBuffer from software bus setup in UT_InitData.
Testing performed
Build and run unit tests, passed
Expected behavior changes
None in the core since nothing depended on this behavior, anything that did (other apps) should do it correctly.
System(s) tested on

Hardware: cFS Dev Server
OS: Ubuntu 18.04
Versions: Bundle main + this commit

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

CCB:2021-01-27 APPROVED
Both comment and implementation were wrong.

CCB:2021-01-27 APPROVED
Both comment and implementation were wrong.


Make it possible to configure DENO_DIR in WS settings

Hi guys!
I'm working on a project written in deno. I saved it as a Workspace.
Deno has an environment variable DENO_DIR to tell where all the cache goes.
I configured DENO_DIR to be in the project's folder.
The problem is that everytime I exit my WS, the environment variables get cleaned - so next time I open the WS, DENO_DIR is set to it's default location (AppData folder in windows..).
It would be great if I can set DENO_DIR in the WS settings (just like how I set "deno.unstable": true for instance)

Please file this feature request against the Deno extension


Fix olm pod name so log to be written correctly to olm.log

The olm pod name is incorrect as "alm-operator". It should be
"olm-operator". This issue causes the olm log never being written
into olm.log after the e2e test is run.
Signed-off-by: Vu Dinh<EMAIL_ADDRESS>

/retest

/approve
/lgtm
/test e2e-aws

/test e2e-aws


Slightly better Batched K-means results on YouTube Faces

Hi,
Firstly, thanks for the detailed codebase and results.
I was trying to replicate your results using minibatched K-means on YouTubeFaces. I took the train/test split of YTB you have linked on the website.  The test split had 140629 samples and 1436 classes.
Using larger batch-size and different num-clusters (K), we can get a better performance. Also, I get somewhat lower results when using the  reported settings from your Clustering Benchmark.
Here are the clustering results with minibatched K-means with varying batch-sizes:

Method
Num clusters
batch-size
prec
rec
f-score

recreation
K=1500
100
50.51
53.11
51.77

K=1500
2000
80.04
53.17
63.90

reported (yours)
K=1500
100
76.87
51.86
61.93

@AruniRC Thanks a lot for reporting the results! I will double check the results in the benchmark.


eror on cmake . &&  make

cmake . &&  make
-- The C compiler identification is GNU 4.8.5
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- The CXX compiler identification is GNU 4.8.5
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Perl: /usr/bin/perl (found version "5.16.3")
CMake Error at CMakeLists.txt:32 (message):
Could not find Go
-- Configuring incomplete, errors occurred!
See also "/root/boringssl/CMakeFiles/CMakeOutput.log".

fixed... use
yum install go

i see this eror also
[root@sg lsquic-client]#make
Scanning dependencies of target lsquic
[  1%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_alarmset.c.o
[  2%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_conn.c.o
[  3%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_full_conn.c.o
[  4%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_chsk_stream.c.o
[  5%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_engine.c.o
[  6%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_parse_gquic_common.c.o
[  7%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_parse_gquic_le.c.o
[  8%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_parse_gquic_be.c.o
[  8%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_parse_gquic_Q041.c.o
[  9%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_packet_in.c.o
[ 10%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_packet_out.c.o
[ 11%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crypto.c.o
[ 12%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_handshake.c.o
[ 13%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_logger.c.o
[ 14%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_malo.c.o
[ 15%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_mm.c.o
[ 16%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_rechist.c.o
[ 17%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_rtt.c.o
[ 18%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_send_ctl.c.o
[ 19%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_senhist.c.o
[ 19%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_cfcw.c.o
[ 20%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_sfcw.c.o
[ 21%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_stream.c.o
[ 22%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_util.c.o
[ 23%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_cubic.c.o
[ 24%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_set.c.o
[ 25%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_headers_stream.c.o
[ 26%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_frame_reader.c.o
[ 27%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_frame_writer.c.o
[ 28%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crt_compress.c.o
[ 29%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_conn_hash.c.o
[ 30%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_eng_hist.c.o
[ 30%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_spi.c.o
[ 31%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_di_nocopy.c.o
[ 32%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_di_hash.c.o
[ 33%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_di_error.c.o
[ 34%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_global.c.o
[ 35%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_packet_common.c.o
[ 36%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_ev_log.c.o
[ 37%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_frame_common.c.o
[ 38%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_packints.c.o
[ 39%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_version.c.o
[ 40%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_pacer.c.o
[ 41%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_attq.c.o
[ 41%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_str.c.o
[ 42%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_arr.c.o
[ 43%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_hash.c.o
[ 44%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_hpack_common.c.o
[ 45%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_hpack_dec.c.o
[ 46%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_hpack_enc.c.o
[ 47%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_xxhash.c.o
[ 48%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_buf.c.o
Linking C static library liblsquic.a
[ 48%] Built target lsquic
Scanning dependencies of target http_client
[ 49%] Building C object CMakeFiles/http_client.dir/test/http_client.c.o
[ 50%] Building C object CMakeFiles/http_client.dir/test/prog.c.o
/usr/local/lib/lsquic-client/test/prog.c:11:26: fatal error: event2/event.h: No such file or directory
#include <event2/event.h>
^
compilation terminated.
make[2]: *** [CMakeFiles/http_client.dir/test/prog.c.o] Error 1
make[1]: *** [CMakeFiles/http_client.dir/all] Error 2
make: *** [all] Error 2

i am get eror also
[root@beta2 lsquic-client]# make
[  1%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crypto.c.o
/root/lsquic-client/src/liblsquic/lsquic_crypto.c:10:32: fatal error: openssl/curve25519.h: No such file or directory
#include <openssl/curve25519.h>
^
compilation terminated.
make[2]: *** [src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crypto.c.o] Error 1
make[1]: *** [src/liblsquic/CMakeFiles/lsquic.dir/all] Error 2
make: *** [all] Error 2
[root@beta2 lsquic-client]#

This is old -- closing due to inactivity.

i am get eror also
[root@beta2 lsquic-client]# make [ 1%] Building C object src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crypto.c.o /root/lsquic-client/src/liblsquic/lsquic_crypto.c:10:32: fatal error: openssl/curve25519.h: No such file or directory #include <openssl/curve25519.h> ^ compilation terminated. make[2]: *** [src/liblsquic/CMakeFiles/lsquic.dir/lsquic_crypto.c.o] Error 1 make[1]: *** [src/liblsquic/CMakeFiles/lsquic.dir/all] Error 2 make: *** [all] Error 2 [root@beta2 lsquic-client]#

Now I have the same problem, and I have checked that there is curve25519.h. What did you do to solve the problem?


Moves entity save to before review call

The reason the bug was occuring and why this change fixes it is outlined in detail here: https://github.com/DoSomething/phoenix/issues/4879#issuecomment-134745880
Fixes #4879
@angaither

@deadlybutter I'm curious why calling save on the item after the setFlaggedPromoted function doesn't allow this to work...

sure! the problem is we're calling setFlaggedPromoted, which looks at all of the reportback items to determine if it should be flagged, promoted, etc. Because this item wasn't saved yet, that function still thinks it's flagged. Because this also happens to be the reportback item with the reason, the logic ignores it thinking we're supposed to flag.
Does that make sense...?

ahhh, got it thanks @deadlybutter

@angaither good to go?

:+1:


Disallow use of async functions

Following up on https://github.com/liveblocks/liveblocks/pull/178#discussion_r864522989, this now formally disallows the use of async inside liveblocks-client, because it will inflate the bundle size (only the CommonJS output).

Now I still need to figure out why in my local setup the TypeScript language server keeps complaining about this to me. I haven't found a way to ignore this line yet.


Add a star-messages/pin messages feature

Starring messages will enable users to check out important messages with ease whenever needed. I would like to work on this issue.

Sounds like a good feature. Assigning this to you @JessicaJohnBritto! Good luck.


getSubscriptions() return empty if debug without Storekit

Please use the Discussion board if you want to get some help. Please use issues to report bugs.

Description
I implemented react-native-iap and config in Appstore Connect. I used Storekit to test it:

I created a storekit file and sync with apple developer account
My storekit can sync and get subscriptions I added in Appstore Connect
I change scheme options with storekit configuration
It works perfectly

Then I want to test with Sandbox account, so I edited scheme to none with storekit configuration. But when I debug on my phone, do not have any subscriptions fetched!
When set up in Appstore connect, I agreed with Terms but not add bank account. My question is: "Does missing adding bank account is the problem in my case?"
Expected Behavior
Can fetch subscriptions without storekit config.
Screenshots
Environment:

react-native-iap:
react-native:
Platforms (iOS, Android, emulator, simulator, device): ios 15.5, real phone

Thank you so much

EDIT: I solve it by adding bank account and taxs (status will change to active)!
Thanks


[bug?] Updating key to null doesn't update data to undefined

const { data } = useSWR(key);
console.log(data);

If I start with key as null, data is undefined as expected.
If I update key from null to a url, data is populated with data on load as expected.
However, when I then update key from a url back to null again, I still get the old data associated with the url. Is this on purpose? I'd expect data to go back to undefined.

I think it's wrong behavior
Dependent Fetching should't work like this from my point of view

Hi, are you still able to reproduce this bug? It seems to be working fine for me: https://codesandbox.io/s/swr-test-lun1r?file=/src/App.js

Hi Shu, I'm no longer able to repro on the latest version! Thank you for your response and thanks for your awesome work on this library!

I try on 0.5.5 , it doesn't work
https://codesandbox.io/s/swr-test-forked-px3cl?file=/src/App.js


[APB-2943][MP] Removing agent-client-authorisation job when migrating to new build environment

Can I be unsubscribed from the git notifications?
On Mon, Oct 8, 2018 at 9:09 AM Marianne<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/hmrc/jenkins-jobs/pull/855
Commit Summary

[APB-2943][MP] Removing agent-client-authorisation job when
migrating to new buid environment

File Changes

M jobs/ci_open_jenkins/build/agents.groovy
https://github.com/hmrc/jenkins-jobs/pull/855/files#diff-0 (4)

Patch Links:

https://github.com/hmrc/jenkins-jobs/pull/855.patch
https://github.com/hmrc/jenkins-jobs/pull/855.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hmrc/jenkins-jobs/pull/855, or mute the thread
https://github.com/notifications/unsubscribe-auth/ANhikmqm5p-GK4EdWWOefPnGO11zEu9jks5uiwhAgaJpZM4XMbjP
.


Recording on an external SSD

Overview
Implement recording on a separate SSD attached via USB.

Should be able to handle device irrespective of UUID
Should prefer external SSD without any configuration if it is attached (or maybe we add this to the CLI?).

Some instruction on automatic SSD mounting on the RPi: https://www.raspberrypi.com/documentation/computers/configuration.html#setting-up-automatic-mounting


uniq backward iteration has different elements to forward iteration

default_357-line (@FeepingCreature) reported this on 2022-10-17T10:37:48Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=23422
CC List

kroeplin.d

Description
Consider the following code:

import std;

void main() {
    auto range = [1, 2].uniq!"true";
    auto left = range.map!"[a]".joiner.array;
    auto right = range.map!"[a]".array.joiner.array;
    writefln!"left = %s, right = %s"(left, right);
    assert(left == right);
}

left = [2], right = [1]
core.exception.AssertError@onlineapp.d(8): Assertion failure

Something about the order in which joiner queries uniq makes uniq return a different "unique" element. While this is *technically* valid behavior as specified, it is very unexpected.

dlang-bot commented on 2022-10-17T12:58:43Z
@FeepingCreature created dlang/phobos pull request #8610 "Fix issue 23422: Disable uniq backwards iteration if a predicate is passed." fixing this issue:

- Fix issue 23422: Disable uniq backwards iteration if a predicate is passed.

https://github.com/dlang/phobos/pull/8610


misc: fix bugs.

This will fix a few bugs, mainly the approve not being recognized. Instead of taking the pull_number we now check if we can get the issue number, which in this case means the same thing.

/assign
/approve
/merge

/merge

/merge force


Installation requirments are not provived explicitely in readme!

I am confused whether this requires Python2 or Python3. Also, installation goes without error but the test is throwing multiple errors. So it is not clear to me if I have installed it correctly. One of the things I want to check is what versions of dependency I am using but it is not mentioned explicitly (though setup.py has some info).

Hi Mohit,
Would you mind posting the error message?
You can always run train.py and see if it works.
The dependencies should be numpy, tensorflow and dm-sonnet. Both Python 2 and Python 3 should work.

Thanks for your quick response!
It seems to me that the code is written in python 2 and I got issues on the following two lines when using python 3, which were easy fixes for python 3. I am trying to make it work on which I am getting currently blocked due to my tensorflow setup locally. Will update as I move forward.
interval-bound-propagation/blob/master/interval_bound_propagation/src/specification.py#L156-156
interval-bound-propagation/blob/master/interval_bound_propagation/src/attacks.py#L90-L90

So, with these few changes (xrange and range) and downgrading tensorflow to 1.8, both examples/train.py and tests have worked.  Thanks for your response!


Some exercises possibly teach questionable commenting practices

In some exercises, the user is encouraged to record expected outputs in comments. For example:
W1, E1
# ____: ___

W1, E3
# The program should output:
# Mean: 5.0

W1, E5
# The program should output:
# Mean: 4.0

W2, E1
# TODO: fill in the program's output
# ____: ___
# ____: ___

W3, E1
# TODO: fill in the comment with the correct number
# there are __ email addresses in the file

Though I understand this is a way to interact with the person performing these warmups, I worry that it may be indicating that these are the kinds of comments you want to write in actual source code. I think the warmups should teach users good commenting practices from the very start. These comments are potentially problematic because inputs/outputs often change in a program and writing exact values in comments means that either the programmer must be meticulous about always updating comments (which I've found to be very difficult) or the comments will fall behind the code and quickly become inaccurate/unhelpful (which is almost always what happens to me). Instead, programmers should be encouraged to write more general comments that should remain accurate as long as the logic of the code does not change.
Could there be a better way to interact/pose questions to users without using comments in this way, such as asking for parts of the expected output through a multiple choice question?

Maybe they could teach commenting practices in a future warm-up and clarify that these comments are for the user's interaction?


Update bcr_validation.py to handle overlay files

Allow using the new overlay format (https://github.com/bazelbuild/bazel-central-registry/issues/1566)
Tested with https://github.com/bazelbuild/bazel-central-registry/pull/2240
This is an alternative to https://github.com/bazelbuild/bazel-central-registry/pull/2046 (which I hadn't seen previously :see_no_evil: )

how do you handle having a module then be backwards comptable for non-overlay Bazel versions?
I thought about maybe turning the overlay's via the NGINX server as a PATCH file live?
The MODULE.bazel also doesn't have a bazel version compatability. It should be > 7.X right?

The MODULE.bazel also doesn't have a bazel version compatability. It should be > 7.X right?

Needs to be >= 7.2.1 due to https://github.com/bazelbuild/bazel/pull/22811


Add Tests for SpatialGrid.ts

This set of changes contains tests and test utility classes for testing SpatialGrid.ts. It tests all public methods.
In testing SpatialGrid.queryRadius, I stumbled upon a behavior that I believe to be a bug. Every time a point is added to the out array, an undefined is added along with it. This is due to incorrect array indexing. I took it upon myself to fix this but can undo the change if this behavior was intended. I did not see anything depending on this behavior and in fact, believe this is probably causing Cannot read property "position" of undefined errors to be thrown, though I did not test the client to see if this was true.
Tests for SpatialGrid.queryInCell are written for the current behavior of this function. However, the behavior of this function does not currently line up with the documentation. I have asked Tyler Burnett for clarification but have not heard back yet.

It looks like the failing test is actually because the method Utils.mix changed when I merged in the latest dev branch. This function is now using Math.floor which is breaking the tests with sufficiently high weights. See the below example:
const comp1 = 5;
const comp2 = 10
const weight1 = 0.9298429277561664
const weight2 = 0

const mixed = (comp1*weight1+comp2*weight2)/(weight1+weight2)
mixed
// 4.999999999999999

Math.floor(mixed)
// 4
// The test originally expected 5 within a tolerance.

The mix function is changed with Math.floor because it was used always with it so I decided to put it inside. I've seen now the tests that a weight uses Math.random() as value, this is incorrect because the weight is always called with the particle size and should be a bigger value like the default 2-3 or something like 10 or 20. The tests should multiply the Math.random with a bigger value and use Math.floor.
Something like
const weight = Math.floor(Math.random() * 10);

This should fix all the random failing.
About the spatial grid failing with the undefined value that's an issue, a check of the particle coming from spatial grid is always required, I've added all the conditions where the spatial grid is used. If you fixed that you can try remove that condition.

I made changes on dev because I needed them, this can be merged


[60mBTC bounty] Liqui implementation

Hello,
I would need full XChange implementation for Liqui, including support for a getAllDepths (or getAllOrderBooks), with its 'limit' parameter and a getAllActiveOrdersForAllCurrencyPairs implementation.
I had a very quick look at the api, and it seems pretty straightforward and standard.
Liqui API

I would like to pick this up later this week or during the weekend.

I'm already working on it although only on the weekends atm. Got the public api done, the trade api is almost done as raw services. You can check out the public api in my fork for now.

@cymp If @cerko2 needs help or if we could work something out, i would be willing to dedicate full-time to this.

Dont really need any help, got almost everything done now just finishing up the adapters for the xchange api's.

Alright, everything should be done now in #1908 including getAllDepths and getAllTickers.
For getAllActiveOrdersForAllCurrencyPairs is getActiveOrders.
The accountService methods I've left unimplemented since Liqui doesnt seem to support any of them.

I started to test the library, it seems to work globally thanks. I committed a small bug fix in #1922.
@cerko2 I think getAccountInfo() implementation is missing in the account service, yet Liqui support the wallet information with getInfo. Is there any reason why you did not implement it?

@cymp  My mistake I missed it. It's added in #1925

@cerko2 Everything I tested looks fine atm, if you like money, please give me a btc address.

@cymp Awesome, my btc address is 33Se6ELb8kPJnPLYYMVuDc1X3mRw73EYrp

60mBTC are on their way to 33Se6ELb8kPJnPLYYMVuDc1X3mRw73EYrp.

Thanks!

@cerko2 Would you have any idea about https://github.com/knowm/XChange/issues/2636 ?


Formatting file does not work (ctrl + shift + i)

Thanks for the great extension.
I am facing an issue that when opening a file with vscode-sftp , it is not possible to format the document.
On pressing (ctrl + shift + i)  , it shows an error as "There is no formatter for 'php' files installed."
Where as it works when i format the file from the local system.
What setting needs to be done to fix this ?

Same issue here with .svelte file.
@nishitgithub Did you find a solution, or workaround?


fix: 3d box game url

PR Description 📜
3D box game url was incorrect.
Fixes #4191

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[] I have added entries for my game in main README.md
[] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Fixed it...

Thank you soo much for contributing to our repository 💗

Thank you @anisharma07 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

please mark appropriate gssoc label and level

Thank you  @anisharma07 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Startup Screen

When TESSA is started with the "First Run" Workspace, the text above the file selection should not be "Older Test Sequence for this Test Machine" but "Welcome to TESSA, please choose one of the following Sample Testsequences to start working with TESSA"

Has been changed.


Override scala organization and version transitively at the Ivy level

This is a forward port of the parts of #2634 which aren't included in https://github.com/sbt/librarymanagement/pull/44. Please note that the scripted test dependency-management/scala-organization will fail until the latter is merged.

I think Travis should go green now that sbt/librarymanagement#44 has been merged ... could you rerun the build?

I published librarymanagement 0.1.0-M12 to Sonatype (https://oss.sonatype.org/content/repositories/public/org/scala-sbt/librarymanagement_2.11/0.1.0-M12/). When it syncs to Maven Central, could you bump the dependencies?

Done.

I don't think the remaining test failure is my doing ... thoughts?

Probably not.. I'm going to rerun the Travis job for the failing one.


TreeGrid v1.0.0 does not work with DataTables v.1.10.19

rows do not expand as plus/minus buttons are clicked.
I traced the code on browser debugger and I was able to fix it as below:
// Expand TreeGrid
dataTable.on('click', 'td.treegrid-control', function (e) {
if (!$(this).html()) {
return;
}
var tr = $(this).closest('tr[role="row"]');
        // record selected indexes
        var selectedIndexes = [];
        select && (selectedIndexes = dataTable.rows({selected:true}).indexes().toArray());
        var tr = $(this).closest('tr[role="row"]'); //ADD THIS LINE
        var row = dataTable.row(tr); //CHANGE THIS LINE FROM var row = dataTable.row(this); //"this" selects the cell, not the row!!!
        var index = row.index();
        var data = row.data();

FYI, since it sounds like you have a fix you could fork the repo, make a commit, and request a pull request to this repo. 👍

@atillabaspinar are you planning to make this commit?

I've fixed the problem, you can update to the latest commit.


feat(CI): Integrate coverage with Jenkins

[x] This contribution adheres to CONTRIBUTING.md.
[x] New tests have been created for any new features or regression tests for bugfixes.
[x] tox successfully runs, including unit tests and style checks (see CONTRIBUTING.md).

Coverage remained the same at 63.955% when pulling fcc93ae96410917af689f19019274a0caaeb7dd9 on epage:covj into 4d5f8831a5c5e8e177838eb5d4f1211046bccb44 on ni:master.

Coverage remained the same at 63.955% when pulling fcc93ae96410917af689f19019274a0caaeb7dd9 on epage:covj into 4d5f8831a5c5e8e177838eb5d4f1211046bccb44 on ni:master.

Coverage remained the same at 63.955% when pulling 4b12ec3f369f8a842c9d6c57290dc2b54761cb72 on epage:covj into 4d5f8831a5c5e8e177838eb5d4f1211046bccb44 on ni:master.


Few new cases in network params cli tests

Issue Number
#1328
Overview

c00d6887a85e6ef7502848bbdac485004de64d2b
Few new cases in network params cli tests

Comments

Added new cases for max epoch num, epoch num out of bound and epoch = -1
Refactored a bit for better clarity

bors r+


Add updating note in quickstart installation guide

Thank you!

new releases of MyST CLI every few weeks

🚀🚀🚀


Initial usage + architecture docs

And some improved logging messages.
Closes #3

@cal-itp/benefits-admin sorry, I've had this PR open for a while apparently. Just a little docs site configuration plus moving some usage content from the README.


Incorrect type annotation for Session.peer

The type annotation for Session.peer is currently:
self.peer: Optional[str] = None

This attribute appears to be set in connection_made() like so:
self.session.peer = transport.get_extra_info("peername")

Where transport is an instance of  asyncio.BaseTransport.
Looking at BaseTransport docs, get_extra_info("peername") calls socket.getpeername() and returns the result.
For IPv4 sockets at least, socket.getpeername() seems to return an ip-address,port tuple. So I think a more accurate annotation for Session.peer would be something like tuple[str, int] | None.

This is a little tricky than I thought :-)
aiosmtpd can listen on IPv4 address, on IPv6 address (by using aiosmtpd.controller.Controller), and to an UNIX socket (by using aiosmtpd.controller.UnixSocketController). The  type of Session.peer is different in each case:

IPv4: tuple[str, int] (hostname, port)
IPv6: tuple[str, int, int, int], (hostname, port, flowinfo, scope_id)
UNIX socket: str (not sure what it is supposed to return, in practice when testing locally with swaks as the client,  I got an empty string back)

So the combined type annotation would be something like
tuple[str, int] | tuple[str, int, int, int] | str | None

Or, in Python 3.8 compatible syntax:
Union[Tuple[str, int], Tuple[str, int, int, int], str, None]


Menu items move around if plugin doesn't output anything

I have 2 plugins loaded, one of them only actually puts something in the bar if a condition is met when it refreshes. If that condition is not met, it doesn't output anything, but it still moves around the other menu items like it's trying to load. See this GIF:

After clicking on another item, the space where the item that didn't load was gets filled back in.
Is there any way to make the plugins not touch the bar unless they are actually going to output something?

This is a known issue (see #177).


Add multiJson file support

Check comments in commits.
Sorry for the long wait. I started playing around with Go inheritance to collect JSON and YAML parser in a single abstract implementation... but that got hairy... check branch "collectYamlJson" (I'm very new to go, so thanks for giving me the possibility to work on this - that was fun... but impossible to fix without breaking the API (Go needs possiblity of editing default constructors to make it work))

I will look into marshaling correctly

Could you also resolve any issues on go report card please? https://goreportcard.com/report/github.com/MikkelHJuul/dasel
Thanks for your contribution!

@MikkelHJuul I've made the change to pretty-print the JSON

@MikkelHJuul Thank you for your contribution 🙂

@TomWright Oh I see you fixed it yourself :+1: thanks! I'm looking forward to try it out


added workflow for closing old PRs

Fixes #200
Type of change
Please give a X on it which is applicable

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

How Has This Been Tested?
It has been tested in a 'Test' repository and is working fine.
Screenshorts and Vedios:

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@hustlerZzZ Please review and merge this PR
Also, please add labels and assign me this PR
Thank you!

@hustlerZzZ Please review and merge this PR
Also, please add labels and assign me this PR
Thank you!

can you check if there is some error in the greetings

Sure, will merge it soon...


Release new images

It seems like the newest image released is 0.0.10 while the current release on github is 0.3.0
Can the images be updated?

https://github.com/zakkg3/ClusterSecret/releases/tag/v0.0.4


Add Phoenix Industries - ³Sat  from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of MoviesColin, to add Phoenix Industries - ³Sat  to CKAN.
Please direct questions about this pull request to MoviesColin.

Ref https://github.com/KSP-CKAN/NetKAN/pull/3045


Installation fails behind firewall with content blocking

Bug Report

Package version(s): 1.15 -> 1.21
Browser and OS versions: Chrome on Windows

Priorities and help requested (not applicable if asking question):
Are you willing to submit a PR to fix? (Yes, No)
Requested priority: (Normal)
Products/sites affected: Office365 CLI
Describe the issue:
When installing the Office 365 CLI from behind a firewall, in some cases, download of the tgz file is blocked.
Actual behavior:
When installing, this is the output:
npm i -g @pnp/office365-cli
npm ERR! code E403
npm ERR! 403 Forbidden: @pnp/office365-cli@latest

npm ERR!      C:\Users\anderma\AppData\Roaming\npm-cache\_logs\2019-06-04T14_55_25_392Z-debug.log

Expected behavior:
I know this is solvable by downloading the tgz file manually and installing, but it would be great if there were a more clear error an also instructions on the Getting Started page for this situation.

Thank you for reporting this issue @sympmarc. Is it the main .tgz that's failing or one of the dependencies?

It was the main tgz in this case. I expect there are lots of places where some piece that should download would be blocked. If you had instructions to install manually, it could be helpful.

Have you seen similar instructions elsewhere? Not trying to justify if we need it but looking for a good place to start. The fact that you've stumbled upon it is proof enough that we need it so now it's a matter of how rather than if. Thank you for your help 👏

Closing due to lack of response

Sorry I never followed up, @waldekmasykarz. It’s probably an unusual occurrence.

We'll keep eyes and ears open and if we come across it again, we'll see if we can address it in some way. Thanks for getting back to us @sympmarc 👍


[NormalizerFormatter] Avoid throwing an exception when the toString call fails

HI @Seldaek
This is an improvement of https://github.com/Seldaek/monolog/issues/673
When a __toString method call throws an exception (which should occurs as few as possible), the Normalizer is throwing an exception too. I believe this behavior is wrong because:

I cannot say monolog to prefer the default behavior over the __toString method
If I wouldn't have a __toString method, it would have work correctly

Also, I have the following situation when using DoctrineFixtureBundle:

I wrote a bug in my fixtures
An exception is thrown
During this process, monolog try to do some logs
For the logs, he look for FooObject::__toString() method
This method return the name of the FooObject which require a database request (because of doctrine lazy proxy)
The entity is not found in database (of course, since the fixture loading failure)
The __toString throws an exception
Monolog crash
I get the monolog failure instead of the doctrineFixture one to debug correctly my work.

As soon as I comment the toString method in my entity, I get the correct error.
Imho, if monolog cannot use the toString method, he shouldn't change the "error behavior" and fallback to jsonEncode like the tostring method doesn't exist.
WDYT ?

Friendly ping @Seldaek if you find some time to take a look :)

Thanks yeah probably makes sense to avoid failures.


Build inside docker container

Will it be possible to create a docker image with VS Community edition for building PHP extension?

So far I see, VS 2017 is permitted for containers, thus it could be used at least to build PHP 7.2. Currently, we have a centralized build bot for PECL releases, targeting all the stable branches. Many projects also use AppVeyor for QA, which supports more VS versions and allows to push artifacts.
Depending on your use case, seems you could use Docker for the builds. Fe if you only target 7.2. Otherwise, a normal VM or AppVeyor seems more promising in the practical sense.
Thanks.

From what I have read so far, it is not possible to install the full Visual Studio (Community Edition) into a docker container. But it is possible to install Build Tools. Would that suffice?

It worked with build tools in docker container.

Yes, Build Tools should be fine. Unfortunately this part is tested purely, as the most build bots, etc. have full VS installs. Nevertheless, good to hear it works :)
Thanks.


Update digest, hex, sha3 and curve25519-dalek dependencies

Also update package name in tests to make them pass.
References mobilecoinfoundation/curve25519-dalek#2
Supports mobilecoinfoundation/mobilecoin#1326

PTAL, I've updated the patched curve dep to use the MCF fork.


[FEATURE REQUEST] YNAB has removed underfunded - Add it back via extension

Is your feature request related to a problem? Please describe.
YNAB has removed underfunded - Add it back via extension.
Describe the solution you'd like
Show Underfunded in Budget view.

You're in luck, this was added in our latest release!

Yay, I see it! Thank you so much @joshmadewell!


⚠ Bofrost.at has degraded performance

In 6450269, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1461 ms

Resolved: Bofrost.at performance has improved in c6cab02.


Update wgsl compiler.

I notice that the WGSL accepted by JavaScript/Chrome (on my Macos) is different than the WGSL accepted when running wgpu-py.
In particular:

The Python version doesn't know about override. This keyword and the @id() annotation are errors.

The Python version requires stricter typing. On JS I can write: var temp = 0u; temp += 1. In Python the compiler complains about mismatched types unless I write 1u.

Is wgpu-py using a WGSL compiler from elsewhere? Can I easily update that compiler to match what's in Chrome?

Ah. Thanks for the info. At least now I understand what’s going on. I’ll close this.
I’ve been teaching myself WebGPU by taking examples from Chrome/JS and converting them to Python. I was surprised when the shaders wouldn’t compile.

Here are the docs I referred to in my previous post: https://github.com/pygfx/wgpu-py/blob/main/codegen/README.md

It's worth noting that both implementations are moving towards the same spec. At least for the C-API, but I also expect that they converge on the same wgsl spec eventually. (Though no doubt there will be edge-cases where the spec is not fully unambiguous, and the implementations will differ 🤷 )


frontend, backend option not available in 0.0.3

Hello, @Wirg
First of all, thanks for implementing this wonderful idea.
I tried to disable backend progressbar and only allow progressbar in streamlit application.
so I passed the parameter like this
for idx in stqdm(range(len(data)), backend=False, frontend=True):

However, it showed error.
TqdmKeyError: "Unknown argument(s): {'backend': False, 'frontend': True}"
My current library versions are as followed.
I installed stqdm via pip
tqdm == 4.61.1
stqdm == 0.0.3
streamlit == 0.83.0

Hello @lucaseo ,
Thanks for the issue.
I indeed never published a version of stqdm with this feature.
I just published v0.0.4 of streamlit to pypi with this functionality. Tell me if it works !
Have a nice day

Marking it has resolved.
Don't hesitate to reopen if you have any issues.


Popup Theme should follow browser style  (Auto Dark/Light Mode)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

ref. #2


Add value extractor into each indicator

I wonder if it won't complicate things.
What about instead wrapping indicator inside a ValueExtractor object which contains both the indicator and the lambda function to extract value ?
This is probably what I will do in IncTA.jl
See https://github.com/joshday/OnlineStats.jl/issues/271
Any opinion?

Value extractor is already used at plenty places and works as expected. This issue was just about adding it to the remaining indicators. I am quite happy with the current implementation, I do not see big benefit changing. But if other method suits your library better, then why not :)


todo: state normalize

https://github.com/suqi/gym-sandbox/commit/6cef940be263ce4eb2a023218460b39319890bde
now cord_list/grid3d_data are all normalized to [0,1]


"convert to shared mailbox" is NOT on page as described.

The link for "convert to shared mailbox is not under mail>more actions as stated on the page. It is not anywhere on Office 365 site. It has been there before and I am a global administrator. How is it possible that this page was updated less than 2 months ago and already it is incorrect!!!!! Microsoft documentation for Azure/O365 S U C K S!!!!!
Chris

Hello @cvanelli-ducks, and thank you for the feedback. Just to confirm, does your feedback apply to this article: https://docs.microsoft.com/en-us/microsoft-365/admin/email/convert-user-mailbox-to-shared-mailbox?

Yes, that is correct. On the page under the heading 'Use the Microsoft 365 admin center to convert a mailbox', step #4
Chris

@cvanelli-ducks Thank you for your feedback. The option to convert a shared mailbox is still available under Users-->active users-->Select the account-->Mail Tab-->Under More actions-->Convert to shared mailbox

Let us know what you see on your end.
Hope this Helps!
Thanks
Sri

Here’s what I see:
https://ducio-my.sharepoint.com/:i:/g/personal/cvanelli_ducks_org/Ec3WMzbraR9KlWjPzjM54-EBkrukqQ3GSxJgSDTCr8P0lw?e=Q0WiOi

Chris Vanelli
Sr. Systems Engineer II - NHQ
Ducks Unlimited, Inc.
One Waterfowl Way
Memphis TN 38120
mobile:<PHONE_NUMBER>
office:<PHONE_NUMBER>
www.ducks.orghttp://www.ducks.org/
From: Sriraman M S<EMAIL_ADDRESS>Sent: Tuesday, September 15, 2020 4:24 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Chris Vanelli<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] "convert to shared mailbox" is NOT on page as described. (#2833)
@cvanelli-duckshttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcvanelli-ducks&data=02|01|cvanelli%40ducks.org|54bd881c154b45aa6ae308d859bdbb17|2430c44f94924e6fa57d32257ab4c515|0|1|637358018718535485&sdata=k8%2BHxQobe9LklMoGyMuueVNuZOpOAGJ9uucqdEfGP1E%3D&reserved=0 Thank you for your feedback. The option to convert a shared mailbox is still available under Users-->active users-->Select the account-->Mail Tab-->Under More actions-->Convert to shared mailbox
[image]https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F45987684%2F93266326-83cca180-f7c7-11ea-90a4-54caf2a7dcc8.png&data=02|01|cvanelli%40ducks.org|54bd881c154b45aa6ae308d859bdbb17|2430c44f94924e6fa57d32257ab4c515|0|1|637358018718545479&sdata=B9k1D9m3UHmNEtCz6Fh6070XNRHyAVQc4ps8BkmZWeQ%3D&reserved=0
Let us know what you see on your end.
Hope this Helps!
Thanks
Sri
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F2833%23issuecomment-692987692&data=02|01|cvanelli%40ducks.org|54bd881c154b45aa6ae308d859bdbb17|2430c44f94924e6fa57d32257ab4c515|0|1|637358018718545479&sdata=Rh%2F5c4TaLegtQ7wmePjlE69FskjICjuwJVcOXBKjcZg%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALTYOEGC2FP6UGNSLNLZU2LSF7LQZANCNFSM4RL4LVJQ&data=02|01|cvanelli%40ducks.org|54bd881c154b45aa6ae308d859bdbb17|2430c44f94924e6fa57d32257ab4c515|0|1|637358018718555471&sdata=pyxWuuunaukfx1ymcgCdKjWZQE7B21%2FX%2BwrdcaDKbEw%3D&reserved=0.

@cvanelli-ducks That is strange. I checked on another M365 Tenant and see the convert to a shared mailbox option under more actions. I'd recommend you contact support via the need help option on the admin center to troubleshoot this issue as this looks like a bug on the tenant.
@yogkumgit There are no changes required on the document. This issue can be closed.
Thanks
Sri

This ticket cannot be closed. I have a ticket open with support, and we will see what they say.

So I opened a ticket as you suggested (#21910303) from the 'need help' option in the portal. Sawan was the technician. He said that your documentation is wrong. It used to be there but the portal has changed and that option is no longer available under more actions. He also checked his tenant and another, and it was NOT available.
So when can we expect the documentation to be corrected?

@cvanelli-ducks Thank you for the quick response. I'll check with the Author and/or engineering team to understand this behavior and update you as well as the document if required.
Thanks
Sri

@cvanelli-ducks Thank you for your feedback. We have made the changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2952
Thanks
Sri

How long does it take before this change is reflected in the page?

@cvanelli-ducks Once the PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2952 is merged it takes 24 to 48 hours for the changes to reflect in the live document.
Thanks
Sri

It's been a week. So, let me ask the right question. When will the PR##2952 be merged?

@cmcatee-MSFT Could you please help us merge #https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2952 ?
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @cvanelli-ducks Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

It IS helpful for me. Thank you for such an open way to correct the documentation!
Thanks
Chris


Documenation added on working of project

Documentation on the working of port scanner is added along with the screenshot of the output

@vinitshahdeo added docs.md
Please check.

@vinitshahdeo sorry for the trouble. Tried sorting out the issue.


Fixed typo: PluginSpec decorations reference should say '...this should create a...' instead of '...this should a function...'

"Be" would make more sense then "create" here. Done in attached patch.


[indicators] Update to 2.2

Describe the pull request

What does your PR fix?
Updates indicators to 2.2

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

Thanks again!


New speed limit API

just creating the issue if anyone finds out the API

It's been added to the Tasker plugin, so they must have found it. Will ping them and ask them to add it to the docs.

Hi @scottrobertson, I'm the dev of the Tasker plugin - I don't think I've received any contact from you, but I'll make a PR here!

Hey @jonahwh. I can't even remember which channel I sent it via now... But you are here now so it's all good :D


Compare with target image LSN in DeltaLayer::get_value_reconstruct_data

refer #1521

Looks good to me. Please add a comment to this new code.

Done

On second thoughts, I think it would be better to do this check in the caller, in LayeredTimeline::get_reconstruct_data. get_value_reconstruct_data takes an LSN-range as argument. If there is a cached page image at some LSN, the caller should provide that as the floor of the LSN range.

Makes sense. Should I change it, or you prefer to do it yourself?

On second thoughts, I think it would be better to do this check in the caller, in LayeredTimeline::get_reconstruct_data. get_value_reconstruct_data takes an LSN-range as argument. If there is a cached page image at some LSN, the caller should provide that as the floor of the LSN range.

Makes sense. Should I change it, or you prefer to do it yourself?

Actually it requires much more refectoring. get_value_reconstruct_data is already given LSN range. If we just update low boundary as min(layer.start, cached_image.lsn+1)  then ... inmem_layer will not work, because it can not distinguish situation when wal records a not found at and when cached image LSN equals to LSN of last WAL record.
We can pass cached image LSN as separate parameters. It  allows to move match from get_value_reconstruct_data to get_reconstruct_data.  But in principle it is just an optimization which I do not think will have any impact on performance.

Actually it requires much more refectoring. get_value_reconstruct_data is already given LSN range. If we just update low boundary as min(layer.start, cached_image.lsn+1) then ... inmem_layer will not work, because it can not distinguish situation when wal records a not found at and when cached image LSN equals to LSN of last WAL record.

Hmm, I'm not sure I understand. Why does inmem_layer.rs need to distinguish between those cases? There's a snippet of code currently in InMemoryLayer::get_value_reconstruct_data that checks for a cached page, but that should be removed as part of this refactoring.

Actually it requires much more refectoring. get_value_reconstruct_data is already given LSN range. If we just update low boundary as min(layer.start, cached_image.lsn+1) then ... inmem_layer will not work, because it can not distinguish situation when wal records a not found at and when cached image LSN equals to LSN of last WAL record.

Hmm, I'm not sure I understand. Why does inmem_layer.rs need to distinguish between those cases? There's a snippet of code currently in InMemoryLayer::get_value_reconstruct_data that checks for a cached page, but that should be removed as part of this refactoring.

Sorry, I do not understand your proposal. Actually after some thinking I do not see any advantages comparing with current fix.
So get_value_reconstruct_datais given LSN range. Low boundary is inclusive.
But we need to stop if we found record with image LSN. So this LSN is exclusive.  I do not know how to combine them rather than pass as separate parameter (i.e. cached_image_lsn: Option). But is there any advantage comparing with
match &reconstruct_state.img ? So if you do not like my fix, please propose your own.

Actually it requires much more refectoring. get_value_reconstruct_data is already given LSN range. If we just update low boundary as min(layer.start, cached_image.lsn+1) then ... inmem_layer will not work, because it can not distinguish situation when wal records a not found at and when cached image LSN equals to LSN of last WAL record.

Hmm, I'm not sure I understand. Why does inmem_layer.rs need to distinguish between those cases? There's a snippet of code currently in InMemoryLayer::get_value_reconstruct_data that checks for a cached page, but that should be removed as part of this refactoring.

Sorry, I do not understand your proposal. Actually after some thinking I do not see any advantages comparing with current fix. So get_value_reconstruct_datais given LSN range. Low boundary is inclusive. But we need to stop if we found record with image LSN. So this LSN is exclusive. I do not know how to combine them rather than pass as separate parameter (i.e. cached_image_lsn: Option). But is there any advantage comparing with match &reconstruct_state.img ? So if you do not like my fix, please propose your own.

Ok, fair enough. I wrote up what I had in mind here: https://github.com/neondatabase/neon/tree/fix-materialized-page-caching. What do you think?

Well, you patch seems to be more natural, but also more complex:
instead of checking entry_lsn in two layers, you have to calculate max in three places + add extra  check at top of loop.
The main problem is that it is not working. The patch itself is correct but the problem is most likely related with page cache eviction algorithm. It is certainly separate topic. But...
I changed page cache size to 2Gb and run pgbench -i -s 100. It produce database with size ~1.7Gb. Then I perform select sum(abalance) from pgbench_accounts.
Zero page cache hits! Then I set [age cache size to 8Gb, size of pageserver process is increased to 9GB and ...
wal_redo_time_count(delta):  148702
materialize_page_cache_hits(delta): 17481
number of pages in pgbench_accounts: 165290
query execution time: 11889,726 ms

So despite to more than enough page cache size, ratio of cache hits/misses is very small and as a result time of query execution is twice larger than with sparated caches.

Well, you patch seems to be more natural, but also more complex: instead of checking entry_lsn in two layers, you have to calculate max in three places + add extra check at top of loop.

I created a new PR https://github.com/neondatabase/neon/pull/1545 for this version.

The main problem is that it is not working. The patch itself is correct but the problem is most likely related with page cache eviction algorithm. It is certainly separate topic. But...
I changed page cache size to 2Gb and run pgbench -i -s 100. It produce database with size ~1.7Gb. Then I perform select sum(abalance) from pgbench_accounts. Zero page cache hits!

That's not very surprising. If you do a seqscan, it will blow away the cached materialized pages before they are used. Even though 2 GB would in theory be enough to hold the dataset in cache, we use the same cache for different things, not just for the materialized pages, so it's not quite large enough.
The cache replacement algorithm is surely not optimal, and we could e.g. detect a sequential scan pattern and avoid "polluting" the cache with pages that are almost certainly not going to be requested again. But at the end of the day, unless the cache is large enough to hold the whole dataset, there's no guarantee that it's useful. I'm all ears for a better cache replacement algorithm. It's tricky to measure though, because if you use the cache more aggressively for one purpose, you might speed up one scenario but slow down others. It's easy to "overfit" for a particular test scenario. I'm sure there's some obvious low-hanging fruit there, though, like putting the pages for a dropped ephemeral file to a free list that you mentioned somewhere.

https://github.com/neondatabase/neon/pull/1545 was pushed, this is obsolete, closing.
(The issue with poor cache replacement policy remains, but that's a separate issue)


Add external blogs

Unrelated request - @IgorTodorovskiIBM, could you please add an RSS feed to your site.


Add SubutaiControlCenter to the environments variable on Win10

It's a little bit uncomfortable to move into CC application folder on Windows every time when user wants to perform some commands via terminal.

it will require restart of machine, after cc installation

Done in Master.

Done in Prod.


astropy not importing in access-med-0.10

When running the following code we get an error importing astropy.
dt = datetime.datetime(2024, 1, 1, 12, 0, 0)
accessvis.update_earth_datetime(lv, when=dt, blendtex=False, sunlight=True)
lv.display((600,600))```

Astropy isn't installed correctly on conda/access-med-0.10. I don't think any changes need to be made aside from reinstalling/making a new version of the environment. I've had similar issues with conda when reinstalling/updating packages before.

Conda is using astropy 7.0.0, and strangely the environment was built before online astropy 7.0.0 was released.

You can also test by running `import astropy.time`

@rbeucher also tried to build a new env here but it failed
https://github.com/ACCESS-NRI/MED-condaenv/pull/133


Place Holder - Mod Compatibility - Devs Descussing Mod Tweaks and Issues for Fastcraft and NotEnoughIDs

I am creating this thread to network devs on the dev of personal mods and allowing each dev to work in harmony with fastcraft and notenoughids.

I partially had the same idea with #20.

https://github.com/HxCKDMS/HxCEnchants/issues/37
Does this have something to do with this?

Use @Solarstrike issue.


refs #315: Show the proper cursor after closing SystemText

This occurs when closing the SystemText component while the cursor is over a PopochiuClickable object.

Closes #315


Remove legacy Policyfiles compatibility mode for Server < 12.1

Require Chef Infra Server 12.1+ to use Policyfiles. As Lamont put it this was prototype support code that was most likely unused and is useless to continue to cart around.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Closing this out. We added the deprecation warning.


Fixed an issue that could cause a count function on partitioned tables

to cause an error if all partitions were deleted concurrently.

otherwise ack