feat: new rule enum.use.by.type

Codecov Report

Merging #169 (a945b14) into master (575a648) will increase coverage by 0.123%.
The diff coverage is 48.333%.

@@               Coverage Diff               @@
##              master      #169       +/-   ##
===============================================
+ Coverage     39.323%   39.446%   +0.123%
- Complexity      1078      1088       +10
===============================================
  Files            213       214        +1
  Lines          10396     10503      +107
  Branches        2576      2597       +21
===============================================
+ Hits            4088      4143       +55
- Misses          5475      5523       +48
- Partials         833       837        +4

Flag
Coverage Δ

unittests
39.446% <48.333%> (+0.123%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...otlin/com/itangcent/intellij/jvm/JvmClassHelper.kt
10.526% <0.000%> (-0.585%)
:arrow_down:

...main/kotlin/com/itangcent/intellij/jvm/PsiUtils.kt
27.586% <0.000%> (-7.196%)
:arrow_down:

...ngcent/intellij/jvm/kotlin/KotlinJvmClassHelper.kt
0.000% <0.000%> (ø)

...tangcent/intellij/jvm/scala/ScalaJvmClassHelper.kt
0.000% <0.000%> (ø)

...m/itangcent/intellij/psi/AbstractPsiClassHelper.kt
49.835% <6.897%> (-2.158%)
:arrow_down:

...kotlin/com/itangcent/intellij/psi/PsiClassUtils.kt
63.063% <38.462%> (ø)

...com/itangcent/intellij/jvm/ClassMateDataStorage.kt
56.098% <38.462%> (-8.188%)
:arrow_down:

...tangcent/intellij/util/AppropriateStringMatcher.kt
86.111% <86.111%> (ø)

...kotlin/com/itangcent/intellij/psi/ClassRuleKeys.kt
100.000% <100.000%> (ø)

...nt/intellij/jvm/standard/StandardJvmClassHelper.kt
73.260% <100.000%> (+1.123%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575a648...a945b14. Read the comment docs.


Associations DSLs don't respect attribute order

The association DSL correctly serializes, but doesn't follow the same ordering conventions of the other attributes DSLs (attributes, serializer_attributes, etc). This results in all association DSLs always appearing at the end of the serialized JSON.
Example
Serializer
# frozen_string_literal: true

class AlbumSerializer < BaseSerializer
  attributes :id

  has_many :songs, serializer: SongSerializer

  attributes :genres
end

Expected
{
  id: 123,
  songs: {...},
  genres: [...]
}

Actual
{
  id: 123,
  genres: [...],
  songs: {...}
}

Happy to take a stab at fixing this if you point me in the right direction. Great library :). Thanks!

Hi Lukas!
This is intentional, to simplify the implementation, as associations are stored in a separate data structure in the serializer schema.
Typically you wouldn't care about the order of a JSON structure, can you share more about your use case?

Thanks for the response. Since we're migrating over to OJ serializer we'd like to maintain the serialization order from before. While technically the order shouldn't matter, we'd like it to remain the same for our customers.
Happy to make a fork that does support association serialization order. Association DSL is not only faster but it makes the serializer more concise. Could you point me in the direction of what would need to change?

You would need to combine the _attributes and _associations structures, so that the order is preserved, changing these two loops with a single one.
To do that, you will probably need to store a type value in the options when adding attributes or associations, so that you can later differentiate it when iterating that structure.
In the future I might revisit the internals of the implementation, as serializing in the same order as attributes are defined makes sense, but for now I'd suggest forking.
Feel free to open a Discussion if you have any feedback or additional questions!

@lukasfroehlich1 This is now solved since oj_serializers-2.0.0.


Refactor SEM Specification

This is a part of #193 that mostly refactors the code for SEM specification types (RAMMatrices, ParameterTable, StenoGraph and EnsembleParameterTable):

introduces an abstract SemSpecification type, which is a parent to all the classes that specify SEM
make SEM constructors use Julia type dispatch (which constructor gets called depend on the type of the positional arguments; keyword arguments types are not used by the type-based dispatch) -- i.e. for StenoGraph-based constructor the graph kw argument made positional.
replaced no-op constructors (e.g. RAMMatrices(a::RAMMatrices) = a) with convert(RAMMatrices, a::RAMMatrices) = a -- that's how Base.convert() is designed to work in Julia.
in ParameterTable: switched from partable.variables[:observed_vars] to partable.observed_vars
renamed parameter_type to relation in the ParameterTable columns (part of #199)
renamed identifier to param in the ParameterTable columns (part of #199)
replaced identifier(), get_par_npar_identifier() methods with params() call which returns a vector of SEM parameter IDs (part of #199)
renamed n_par() into nparams() (part of #199)
added params field to ParameterTable to explicitly define the order of parameters -- simplifies the logic of SEM ensembles and checking/updating parameters
added code for checking the correctness of parameter and variables (dimension matching, uniqueness) at the time of SEM construction
param_values/lavaan_param_values() -- moved the code for extracting the parameter values from the parameter tables from tests into the SEM API.
renamed Base.sort!(::ParameterTable) to sort_vars!() as it was not clear what this function sorts

It looks like SymbolicsUtils 1.6 broke sparsehessian, so I downgraded it to 1.5.
Also, allowed StenoGraphs 0.3.

I prefer parameters. But its more like a 60/40 preference.

@Maximilian-Stefan-Ernst Thank you for the review, I'll address your comments in a next few days.
Regarding the params vs parameters. I prefer params, but I can change it to parameters if the stakeholders decide so :)
Just to summarize my approach:

the core idea is to have sort-of "Huffman coding" for the terms in the API: frequently used concepts should use shorter, unambiguous, intuitive terms ("vars", "params", "cov");
less frequently used terms, or the ones that don't have an intuitive short version, could be longer (objective, gradient, hessian); also object type names could be longer because they are less frequently used in the code.
I think it makes the code more readable -- code lines are shorter and faster to read; the urge to introduce local variables just for the sake of avoiding using full names (e.g. npar = nparameters(model)) is more subdued :)
that is in line with Julia naming conventions (struct, Dict, Ref, Val, eval, undef, Stats, sortperm, cov), there are precedents in the other popular packages, e.g. HTTP.getparam()
it has to be consistent with the other terms: if it's decided on parameters, it probably also means switching to variables, covariation etc

Docs are fixed.

W.r.t. the params vs parameters debate - let's settle on params then, I am also more like a 60/40 for parameters, but since you have a clear preference for params we can settle on it by weighted majority vote^^.
Fun fact: I tried to see what Julia Base is using; params matches 19 files, parameters 42 - so Base settled on using both^^.

@Maximilian-Stefan-Ernst Thanks for your review and fixes! -- I've squashed them into original commits to make the history cleaner.
Special thanks for settling on params -- I guess I was 80/20 for it :) But if your preference for parameters() would grow stronger, you can always change.
Let me know if anything else is left for merging this PR.
Note regarding the doc fixes and other API tweaks (e.g. params_indices()) -- as there are other potential changes from #193 (and I have other ones recently) you may want to incorporate, I think it would be better to update the documentation after all of that potential updates are reviewed. I am a bit busy with my work-related projects, but I'll try to branch the next round of updates from #193 once this PR is merged.
The next things should be more material :) (ParamsArray for RAM matrix simplification, evaluate!() interface for unified objective/gradient/hessian evaluation)

Nice, thanks again for contributing all those changes :) Before merging, there are only 2 open comments/suggestions remaining. I think we should then merge this PR and the following ones into devel - after all the changes are merged and we want to make a new release, we can then merge devel into main.

Before merging, there are only 2 open comments/suggestions remaining.

Oh, right, I overlooked those. I've incorporated the iteration cleanup; as for pretty printing tweak -- see my comment.

I've rebased the branch onto devel, the conflicts are resolved.

@Maximilian-Stefan-Ernst  I've revised your param_indices() addition.
param_indices(semobj) is a useful one-liner method, which I actually wanted to add myself.
However, I removed param_indices(semobj, params) method for 2 reasons:

it is potentially confusing that the return type of methods with the same name is different
internally, param_indices(semobj, params) constructs the parameters dictionary at each call, which may get misused in certain contexts for large models (e.g. getting parameter indices in a loop). I think it is just a tiny bit inconvenient if instead the user has to call param_indices(semobj) and then use it as a dictionary, but it is a bit less likely to be misused.

@Maximilian-Stefan-Ernst Let me know if there's anything else to tweak for this PR. Otherwise I am ready to rebase #193 once this one gets merged and extract the next round of changes :)

Sorry, just too much other stuff to do :)


Windows OpenBLAS build

Could you add it, please? It is supposed to be faster than avx2 version, right?

From the results of the tests, openblas is not faster than the avx2 version, and sometimes even slower


App is getting crashed.

Sometimes app crashes randomly.

This looks like a Sceneform bug. Please report here instead https://github.com/google-ar/sceneform-android-sdk


Problem when sitting next to functions

When annotating css on the root level which comes from a function, syntax highlighting breaks.
Without css annotation:

With css annotation the code following the template loses highlighting

I am also seeing this issue. The code still works but we lose highlighting for anything else below the variable with the css comment.


Pause if there is no Stop

This may be outside of the scope, but would it be possible that when I press the stop button and a website doesnt support the stop functionality that the pause button is pressed in place of stop but only if music is playing?
so i guess the logic would be something like this;
if (music-is-playing = false) stop does nothing, or does it's standard stop input
if (music-is-playing = true) stop button will trigger pause input
from there it can get fancy such as only do this behavior on websites that don't have stop functionality (in my experience most dont have stop) if that's something that needs to happen.
If this is possible, sweet! I'd love to see it happen! If not, drats, thanks for reading, and go ahead and close this.

I believe this issue is partially resolved by https://github.com/borismus/keysocket/pull/120
I have since switched to another media key extension, but if there is any other interest in this issue as a feature request for players not already addressed in https://github.com/borismus/keysocket/pull/120 then this issue should stay open. Being as it has been nearly 3 years with no activity on this issue it might be best to close this issue for now and have separate issues opened on a per player basis to request STOP functionality for individual sites.

The best feature request is pull request. If you interested to implement this feature, you can do it and I will merge the code. Otherwise, I'll close this issue.


Create documentation source RST

Steps to render in local development:
python3 -m venv newsapi-dev
source ./newsapi-dev/bin/activate
# [cd newsapi-python/]
python -m pip install -e .
python -m pip install -r requirements-dev.txt
cd docs/
make clean && make html
open build/html/index.html

Connecting to readthedocs.io:

https://github.com/readthedocs/readthedocs.org/blob/master/README.rst#quickstart-for-github-hosted-projects

FYI @mattlisiv , it looks like you'd need to be the one to actually add this to Read The Docs.  (From my account there, I'm only able to see repos under bsolomon1124/.)
Here's a sample from local development:

Awesome. Added! https://newsapi-python.readthedocs.io


Update android-configure.md

Added a statement that web content filtering is not available on mobile platforms

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9394

@JohanFreelancer9 Please copy review

Docs Build status updates of commit 12e8b92:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/android-configure.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 483e2ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/android-configure.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@mjcaparas Please merge this PR. Thanks

Docs Build status updates of commit 5d415dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/android-configure.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Use MAKE_ENUM_HASHABLE to hash SymbolKind

Instead of providing a specialization here, the preexisting macro can be used.

Tested with:
Apple LLVM version 9.0.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Which failed to build without a specialization here (either explicit or through the macro).

Just want to say thanks for this project! The C++ world desperately needs a FOSS intellisense solution that isn't unusably slow.


Set custom key when fetching image from URL

I think adding this possibility will be pretty helpful, because currently it always uses the url as the key.

I would like to add my +1 for this feature. My specific case is that I am fetching images from an S3 bucket, but they are all authenticated using query string parameters. So I would like to just use the image filename as the key.

As far as I can tell you will need to create your own Fetcher. I'm also realizing that it fails during disk cache operations because the key, if short enough, is the url, which has "/" in it.

@groovz I've created a custom class that accepts a custom key:
https://gist.github.com/cbess/86d5753dcb76ed75fe291f47d1a4ab5c
I hope it helps you.


Add #[ext_contract(...)] to every external trait

It would be nice to eliminate the missing docs clippy issue as well, without having to resort to #![allow(missing_docs)] for every module.

PR #38


added asset tags

Updated index.hbs to add asset tags instead of hard links so ghost doesn't throw error while uploading.

Why your pull request have your custom files (favicon, styles, etc..) ?

I did not realize that the pull request would also send commits made after the pull request was made. Ignore this one, I will make another fork and add pull request for just the asset tags.


Add January 2022 Community Spotlight Update to Cadence blog

¨

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.sharanf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

You will need to sign the Contributor License Agreement to be able to merge this change (see waiting build step).

I have done already signed the CLA. I think the issue is the that in the first commit I had a typo in my email address so it didnt recognise my github id. I've fixed the email for the other commits. When I actually click the 'details' link about the CLA and sign in with Github - it says you have already agreed the CLA. Not sure what to do to fix it.

ok i can manually merge if thats the case. thank you.

ok i can manually merge if thats the case. thank you.

@just-at-uber excellent and thanks very much! :-)


Customize EventView

Can you/anyone guide me on how to customize EventView to have images or custom layout?

I want to achieve EventView something similar to attached image.
Thank you.

Currently not supported, this feature has already been requested. Please, post your suggestion here: #175
Also, any further discussion on this topic should happen there.

Also, you could just fork the CalendarKit and implement your change directly in the EventView


local testnet example hangs on latest docker engine version

hangs on line 66
would be solved by #197

FYI, just tested this on Ruben's machine, testnet setup script works fine for him (does not hang, and starts creating blocks).
OSX version 10.13.3

@LeeSmet which docker version?
mine is Docker version 18.03.0-ce-rc4, build fbedb97

Client:
 Version:  17.12.0-ce
 API version:  1.35
 Go version:  go1.9.2
 Git commit:  c97c6d6
 Built:  Wed Dec 27 20:03:51 2017
 OS/Arch:  darwin/amd64

Server:
 Engine:
  Version:  17.12.0-ce
  API version:  1.35 (minimum version 1.12)
  Go version:  go1.9.2
  Git commit:  c97c6d6
  Built:  Wed Dec 27 20:12:29 2017
  OS/Arch:  linux/amd64
  Experimental:  true

Able to reproduce on Ruben's OSX after updating to the latest docker which was just released on mac:
Client:
 Version:  18.03.0-ce
 API version:  1.37
 Go version:  go1.9.4
 Git commit:  0520e24
 Built:  Wed Mar 21 23:06:22 2018
 OS/Arch:  darwin/amd64
 Experimental:  false
 Orchestrator:  swarm

Server:
 Engine:
  Version:  18.03.0-ce
  API version:  1.37 (minimum version 1.12)
  Go version:  go1.9.4
  Git commit:  0520e24
  Built:  Wed Mar 21 23:14:32 2018
  OS/Arch:  linux/amd64
  Experimental:  true

Also able to reproduce on my machine after updating the docker engine to version 18.03.0-ce (from 18.02)

any update on this?

Not yet

Need to revise the script and except users to use latest docker (if important).

@LeeSmet would be good you can update the entire docker stuff and also make an example of it. How much work do you estimate it is?


Cargo lock on build directory does not work on NFS

When run on a project located on a NFS mount, cargo fails to lock the build directory.
Expected behavior:
# cd /tmp
# cargo new --bin bin
     Created binary (application) `bin` project
# cd bin
# cargo run & cargo run
    Blocking waiting for file lock on build directory
   Compiling bin v0.1.0 (file:///tmp/bin)
    Finished dev [unoptimized + debuginfo] target(s) in 0.57 secs
     Running `target/debug/bin`
Hello, world!
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `target/debug/bin`
Hello, world!

Actual behavior (my /home is NFSv4 mounted, with no lock-related options on the mount):
# cd $HOME/src
# cargo new --bin bin
     Created binary (application) `bin` project
# cd bin
# cargo run & cargo run
   Compiling bin v0.1.0 (file:///home/bruce/src/bin)
   Compiling bin v0.1.0 (file:///home/bruce/src/bin)
error: failed to remove /home/bruce/src/bin/target/debug/deps/bin-291ef6a9e055a048.0.o: No such file or directory (os error 2)

error: failed to remove /home/bruce/src/bin/target/debug/deps/bin-291ef6a9e055a048.crate.metadata.o: No such file or directory (os error 2)

error: failed to remove /home/bruce/src/bin/target/debug/deps/bin-291ef6a9e055a048.crate.allocator.o: No such file or directory (os error 2)

    Finished dev [unoptimized + debuginfo] target(s) in 0.90 secs
     Running `target/debug/bin`
    Finished dev [unoptimized + debuginfo] target(s) in 0.96 secs
     Running `target/debug/bin`
Hello, world!
Hello, world!

I'm using cargo 0.22.0 (3423351a5 2017-10-06) on Gentoo Linux, kernel 4.9.52.

is... there anything we can do about this? AFAIK file locking basically doesn't work at all with NFS

NFS file locking does work. For NFS v3 Linux has claimed support since about 2.6.12 (in 2005), and NFS v4 has file locking support built into the protocol.
However, there seems to be some conflicting information if flock(2) actually works over NFS. Kernel notes say it's been working for a long time, but others report that it doesn't still. The NFS man page(5) under "Using file locks with NFS" indicates that NFS (all versions?) supports advisory locks only using lockf/fcntl, with flock being emulated by fcntl calls.
If what you need is a single lock for the whole tree, a single lock file would suffice using one of a variety of methods (mkdir is atomic; symlink to a random value and readlink to check if yours was created; create, link, and then stat original file to count links, etc). I don't know the details of how cargo uses locks to be sure what would be most appropriate.
References:
https://unix.stackexchange.com/questions/229675/nfs-file-locking-not-working-am-i-misunderstanding
https://stackoverflow.com/questions/22409780/flock-vs-lockf-on-linux
https://serverfault.com/questions/66919/file-locks-on-an-nfs
https://en.wikipedia.org/wiki/File_locking#Problems

I see now that cargo did locking, but had issues with an NFS system (#2615). The reading I have done seems to point at NFS flock hangs being a NFS configuration problem more than an application problem. If flock doesn't work across the network, it generally maps to either a no-op (BSD) or a local-only lock (old Linux, others?). Turning locks on again (by disabling the NFS check) works for me, but that's far from conclusive testing it won't hang for me (at some other point) or anybody else.
I'm not sure where to go from here. Adding the locking back for NFS seems to be a non-starter because of problems others are having. Switching to fcntl locks may be the best compromise on Linux, but has portability issues (and isn't supported by fs2). I'd be willing to do the work to make something happen, but have no idea what.
Would it make any sense to switch the locking model to having some wider scale lock (ie a secondary lock file specifically when cargo needs exclusive access) instead of locking each writable file open, or is that just crazy talk?
FTR I ran into this by using assert_cli to implement tests for a command-line program. In in turn runs the program through cargo run. Running the numerous tests in parallel works much faster than sequentially due to the overhead of running cargo for each test.

Most systems, even if they have an NFS mount, typically have something on a local filesystem. I wonder if we could perhaps detect that the current path is an NFS mount and if so switch the path to the file lock on the filesystem. For example if /home/bar/code/foo.lock is NFS, we could perhaps instead use a file lock at /tmp/$(hash("/home/bar/code/foo.lock")).lock or something like that.
That way we could ensure that Cargo on the same machine is coordinated, and we're not really trying to coordinate Cargo across machines anyway.

Trying to use a file with a predictable file name in a globally writable directory is a recipe for disaster (symlink attack, etc). It would be more appropriate would be to use a NFS safe locking technique to create a separate lock file beside the file (AKA a dot-lock file or some such).
It may be worth spending some time and building a standalone crate to do just this, ala the lockfile command from the days of procmail or dotlockfile from the current liblockfile package. I could see it being useful in other places. I should go ahead and do that, though I can't test it on much more than Linux.

This is still a problem, though obviously it doesn't affect many people.

Total Rust newb here. I think I just ran into this too trying to build a project on an NFS share. The code I'm trying to build has errors and that could be contributing as well. The error messages I get finish with
thread 'main' panicked at 'librustc/session/mod.rs:802: Trying to get session directory from IncrCompSession `NotInitialized`', librustc/session/mod.rs:1296:26
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: aborting due to 3 previous errors

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.29.1 (b801ae664 2018-09-20) running on x86_64-unknown-linux-gnu

note: compiler flags: -C debuginfo=2 -C incremental --crate-type lib

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `tower`.

To learn more, run the command again with --verbose.
hbarta@olive:/mnt/share/projects/tower$

Impact on me is minimal as it would be a simple convenience to build on laptop or desktop. I can just copy the whole directory over. (Not worth the effort at this point to upload to a remote repo.)
I can provide further information if there is any interest. Otherwise I'll just consider this a "me too" to a known issue.
I'm, running on Debian Stretch (both host and NFS server.)

@HankB FWIW that's an issue for rust-lang/rust, not Cargo (it's coming from the compiler, not Cargo)

@alexcrichton Thanks for pointing that out. It should have been obvious. I have added my comments to what seems like the same issue. (https://github.com/rust-lang/rust/issues/40830)

Hi,
here's another "me too" story.
I've been having pretty weird build issues/crashes recently, and nailed them down to being a concurrent issue with VSCode/Rust-analyser doing cargo check at the same time as I am building on the shell... and my project was on NFS (v3 to be precise).
I could workarounds all those "weird" crashes by either moving my project onto local disk or by disabling the VSCode/RA option "checkOnSave".

Hi. the "prototypical code" from above is not working anymore, libc must have changes and the field f_basetype is not there anymore.
however, it seems possible to find out whether a path is on an NFS mount with this command:
>>> stat -fc %T /my/nfs/mount
nfs

or by using the hex code:
>>> stat -fc %t /my/nfs/mount
6969

with this in mind, I updated the code above to work in that way:
use std::path::Path;

fn is_on_nfs_mount(path: &Path) -> bool {
    use std::ffi::CString;
    use std::mem;
    use std::os::unix::prelude::*;
    use libc;

    let path = match CString::new(path.as_os_str().as_bytes()) {
        Ok(path) => path,
        Err(_) => return false,
    };

    const TST_NFS_MAGIC : i64 = 0x6969;
    unsafe {
        let mut buf: libc::statfs = mem::zeroed();
        let r = libc::statfs(path.as_ptr(), &mut buf);
        buf.f_type == TST_NFS_MAGIC
    }
}

fn main() {
    let path0 = "/some/local/path";
    println!("{}: {:?}", path0, is_on_nfs_mount(&Path::new(path0)));
    let path1 = "/some/nfs/path";
    println!("{}: {:?}", path1, is_on_nfs_mount(&Path::new(path1)));
}

it would be great is a solution could be found so that people working NFS can safely use cargo without triggering this issue.


[DOKS Hardening Blueprint] Snyk workflow support for image scanning and SARIF reports, Kubescape refactoring

More fixes and enhancements for https://github.com/digitalocean/container-blueprints/issues/41.
Snyk:

Image scanning support in the GitHub workflow.
Export scan results using GitHub SARIF format.
Simplified GitHub workflow steps logic.

Kubescape:

Simplified GitHub workflow steps logic.

@bikram20 Can you review this one please ? Thanks.


Update WordCountDemo.java

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Not sure what the purpose of this PR is. Closing for now. Feel free to reopen (please add a description if you reopen it).


Unknown option --report-trx and --coverage

If you follow the documentation, it doesn't work.
To reproduce:
dotnet new console --name TUnitDocs
cd .\tunitdocs\
rm .\Program.cs

Add a new file, as per docs with
using TUnit.Core;

namespace TUnitTest;

public class MyTestClass
{
    [Test]
    public async Task MyTest()
    {
        var result = Add(1, 2);

        await Assert.That(result).IsEqualTo(3);
    }

    private int Add(int x, int y)
    {
        return x + y;
    }
}

Then try to run, as per https://thomhurst.github.io/TUnit/docs/tutorial-basics/running-your-tests, dotnet run -c Release --report-trx --coverage
This gives the error:
TUnit v<IP_ADDRESS> | 64-bit | Microsoft Windows 10.0.22631 | win-x64 | .NET 9.0.0 | Microsoft Testing Platform v1.4.3

Unknown option '--report-trx'
Unknown option '--coverage'

The fix would be to run:
dotnet add package Microsoft.Testing.Extensions.TrxReport
dotnet add package Microsoft.Testing.Extensions.CodeCoverage

Maybe it'd be better to have this "running-your-tests" page without the codecov and report, but instead add better instructions to https://thomhurst.github.io/TUnit/docs/extensions/? I can make a PR if you agree.

Sure happy for you to raise a pr


Try.isEmpty() returns false even when it's a Success with null value

It should return true to comply with:
Option.of(null).isDefined == Try.of(()->null).toOption().isDefined()
This is also broken on 1.x branch. I can prepare a patch for that as well
Also, should Try.isEmpty() check for types that have an isEmpty() (like String, List, etc.) implementation and delegate the results? Problem is that there is no common hierarchic ancestor that guarantees the presence of such method. We could just make the "best effort" with known types.

Current coverage is 94.98%

Merging #1180 into master will not affect coverage as of b1b7c20

@@            master   #1180   diff @@
======================================
  Files           78      78
  Stmts         9204    9204
  Branches      1746    1747     +1
  Methods          0       0
======================================
  Hit           8742    8742
  Partial         93      93
  Missed         369     369

Review entire Coverage Diff as of b1b7c20

Powered by Codecov. Updated on successful CI builds.

Hi Guillermo,
no. :-) That is contrary to the whole idea of the Try monad. The state of Try only depends on a success or a failure of a computation, reflected by the types Success and Failure. null has nothing to do with that state. Success(null).toOption() is Some(null), which is also allowed in Scala, see below.
But after performing some checks on the REPL If recognized that the name isEmpty might be confusing. Scala's Try does not have it.
scala> import scala.util.Try
import scala.util.Try

scala> Try(null)
res1: scala.util.Try[Null] = Success(null)

scala> Try(null).toOption
res2: Option[Null] = Some(null)

scala> Try(null).toOption.isDefined
res3: Boolean = true

scala> Try(null).isEmpty
<console>:9: error: value isEmpty is not a member of scala.util.Try[Null]
              Try(null).isEmpty
                        ^

scala> Try(null).toOption.isEmpty
res5: Boolean = false

I introduced Value.isEmpty() in Javaslang to have common property of all Value types (Lazy, Option, Future, Try, Either,... and collections) that reflects a 'negative' state, not to be confused with undefined.
Here are some example what isEmpty looks like in different type:

Option.isEmpty() == (option == Option.None.instance())
Either.isLeft() == Either.isEmpty()
Try.isFailure() == Try.isEmpty()
Collection.isEmpty() == (Collection.length() == 0)
Validation.isEmpty() == Validation.isInvalid()
Lazy.isEmpty() == false // by definition

Additionally all Values have a method Value.isDefined() == !Value.isEmpty().
Now I see, that the name isEmpty might be confusing. But I think it is correct. Lets look at the meanings:
A Value wraps an instance, the so called underlying value. The javadoc of Value.isEmpty() says:

Checks, this Value is empty, i.e. if the underlying value is absent.

If a Try computation failed, we have no resulting underlying value. We can say that the resulting Try instance is empty. Instead we have an exception.
If a Validation result is invalid, the Applicative did not apply a function to produce an underlying value, the result is empty. Instead we have errors of a different type.
 The evaluation of that value is deferred.
A collection containing no values is empty.
A Future that failed is empty because it contains no result. Instead it contains the exception that occurred.
etc.

If we want to model the empty state as property, it needs a name. It might differ from Scala, which has no common Value type but why should we not choose the name isEmpty?
Does this make sense to you?

Hi Daniel! I understand and next time I'll check Scala for reference :) I'm closing the PR.
Anyway, my problem is not with isEmpty(). My pull request modified it only because it's used by toOption().
My problem is that I have a computation that runs inside a Try which can return a null. I can't get rid of that because I'm integrating with a third party here. I want to wrap the result in an Option for further use of the result but then I may have a Some(null) which can produce runtime bugs in my app.
I know that Scala's Try(null).toOption can give a Some(null), but this is kind of wrong, isn't it? The fix is an easy one: we could make Value.toOption() to go through Option.of() factory method when it's not empty to solve the problem:
    default Option<T> toOption() {
        if (this instanceof Option) {
            return (Option<T>) this;
        } else {
            return isEmpty() ? Option.none() : Option.of(get());
        }
    }

Researching for this reply I found this thread in StackOverflow that explains why Some(null) is an acceptable value in Scala TLDR: It's just to achieve interoperability with Java (calls to methods that return null, accessors in Lists, Maps, etc.).
If this is true, we can decide to produce a None instead a Some(null) in Value.toOption() if the value is not empty.
I mean... I never ever want a Some(null) in my code.
If we don't fix this, I can't trust that the value of a Some is not null and we're back to the if (something == null) and that's a situation that I'd like to avoid (again).

Even better: We could:
    static <T> Option<T> some(T value) {
        return of(value);
    }

This would prevent a Some(null) from any source.
(Also, remove some(T value) factory)

We should not do that. I had a use case where I needed Some<Void>. null is the only instance here of Void. As long as null is part of Java, we can't completely get rid of it without breaking the logical structure or making look things artificial.
You could solve your use-case by using transform instead of toOption:
Try(...).transform(self -> self.isSuccess() ? Option.of(self.get()) : Option.empty());

or write a helper for that
Try(...).transform(FancyName::toOption);

class FancyName {
    static Function<? super Try<T>, ? extends Option<T>> toOption() {
        return it -> it.isSuccess() ? Option.of(it.get()) : Option.empty());
    }
}

Ok... That's what I'm doing right now.
I'd want to understand why you'd need a Some(null). Not trying to be rude... really :) Could you provide an example?

Yes, it is an important topic and it needs to be clarified, also in the docs.
I will provide an example later today, currently I only have a mobile phone at hand :)
The main point is that we need to preserve type-consistency. null is just a value, not more, not less. If we lift it into the context of a type (/state), conversion methods need to preserve this state.

We are not allowed to change this behavior. It wouldn't be logically (and algebraically?) correct any more. The special behavior you suggested would need to be implemented for ecery type in order to be consistent again. But that would not be natural any more. We would break the canonical way and add our own business logic (in a technical domain) because we think it does fit better for us.
I will give the example later...

These 'laws' come to my mind that should be obeyed by the toXxx conversion methods:
For all Javaslang Value type A, B, C and a ∈ A:

a.toA() == a
a.toC() equals a.toB().toC()
a equals a.toB().toA() // follows through 1) and 2)

or at least

typeOf(a.toA()) == typeOf(a)
typeOf(a.toC()) equals typeOf(a.toB().toC())

So let's imagine, we change the behavior of Try.toOption() in the way that Success(value).toOption() returns Option.of(value).
Then Try.of(() -> null).toOption() is None.
Try.of(() -> null).toEither().toOption() is Right(null).toOption(), which is Some(null).
We could now change the behavior of toOption() for every Value implementation according to your suggestion. But then we would have
// singularity in the space-time continuum :-)
Success(null).toOption().toTry() == Failure(NoSuchElementException)
This might not be, what other users expect.

Example:
In this example I assume that there exists 3rd party code that puts null into maps. Or at least it is not prohibited to do so.
What Java currently looks like:
Map<Integer, String> map = new HashMap<>();

// == false
map.containsKey(1);

// == null
map.get(1);

map.put(1, null);

// == true
map.containsKey(1);

// == null
map.get(1);

How we can do better with the use of Some(null):
Map<Integer, String> map = new HashMap<>();

// = None
safeGet(map, 1);

map.put(1, null);

// = Some(null)
safeGet(map, 1);

with
static <K, V> Option<V> safeGet(Map<K, V> map, K key) {
    return map.containsKey(key) ? Option.some(map.get(key)) : Option.none();
}

Right?
See also "Your codebase looks like this"
Another example is an early version of the new structural pattern matching. However, I changed this.

And now let's imagine we add a new Value implementation that handles specific values in a specific way (like Option handles null in a specific way).
We would have to pull that specific behavior into all conversion methods toXxx to meet our special requirements. This does not feel right.
If we act like shown in my hand-drawing, there is no room for subjective interpretation of values. It is just as it is - a value put into a context of a type.

The key to my thoughts is:
I think it we cannot assume that null stands for 'absent'  or 'undefined' in every (use-)case because Java lets room for interpretation of that value.
That is a billion dollar mistake that is irreversible.

:-))

This is the theory behind Value: Dual category theory

(I haven't read the last links yet, sorry about that)
I've prepared a test representing transformations between Option, Try and Either to reflect on what you've explained.
The test covers all possible transformations between these types according to the current implementation:

So, arrows and arrow points work as usual. Notice that None to Either gets inverted (in red) for obvious reasons.
Some things from the top of my head that I don't understand quite yet:

Sorry to throw your own quotation back at you but (I need to understand this):

I think it we cannot assume that null stands for 'absent' or 'undefined' in every (use-)case because Java lets room for interpretation of that value.

Isn't the same problem to asume that None => Failure? (There is no line between None and Failure) Why is this different?

Left.toOption() doesn't do the same as Left.left().toOption() which is weird. Is this a bug?

Try.run().toOption() gives a Some(null) which makes everything more strange

Sorry to throw your own quotation back at you but (I need to understand this):

Aaarrgh! Please, don't throw things at me. :-)

I think it we cannot assume that null stands for 'absent' or 'undefined' in every (use-)case because Java lets room for interpretation of that value.

A simple example is the only instance null of the type Void. I needed such thing as valid extension of a specific domain in pattern matching. E.g.

Pattern2<T1, T2> unapplies an object to Option<T1, T2> (None, if the pattern is not applicable)
Pattern1<T> extracts Option<T> out of an object (we don't need the wrapper Tuple1 to save an instance)
Pattern0 extracts Void out of an object (theoretically it could be also Tuple0). The singleton instance Some<Void> is obtained by Option.nothing() in Javaslang. Formally an optional instance of nothing exists.

I flatMapped over these patterns and pattern0 needed to return Some<Nothing> to make it work...

If we don't fix this, I can't trust that the value of a Some is not null and we're back to the if (something == null) and that's a situation that I'd like to avoid (again).

As long as null exists we can't even trust that the Some itself is not a null reference.
Some<T> some = null; // ooops!

Isn't the same problem to asume that None => Failure?

No, because we should not start to interpret things. The conversion needs to take place within the same space of types (the isEmpty == true space).
--
Either is a very special type. It is a disjoint union type. It consists of two Monad types, all other Values consist only of one Monad type! I just saw that my picture is terribly WRONG. The Left type is in the wrong place, sorry. Either itself is not a Monad. I recently changed it to be a right-biased Either. That means we treat a Right value as defined and a Left value as empty. But in an unbiased version both Left and Right are defined and none is empty.
This is the reason for having toLeft(R alternative) and toRight(L alternative) conversion methods. They work like in Scala (you need to scroll down to see the methods).
A second thing is, when we call left() or right() on an Either, we transform it to new types: LeftProjection and RightProjection. These act like the right-biased Either. From the viewpoint of a LeftProjection a Right is empty. From the viewpoint of a RightProjection a Left is empty.
Your questions:

left.toOption()

left is the empty state of our right-biased either, so left.toOption() is null.

left.left().toOption()

left.left() is a LeftProjection of a Left, which is defined (and not empty) in our understanding. So left.left().toOption() is Some.
Trust me, it works like in Scala. This projections are not every-man's stuff but it is correct.

On 8 Mar 2016, at 22:13, Guillermo Gutérrez wrote:

I'd want to understand why you'd need a Some(null). Not trying to be rude... really :) Could you provide an example?

When pulling values out of a database - a missing row might be a None but a row containing a null value would be Some(null) - Just like when dealing with some result sets when you group() or left outer join them you might end up with a List(1,2,3,null,4,null,6).
Double wrapping everything as List(Some(1),Some(2),Some(3),None,Some(4),None) itself kinda feels horrible and wrong. Tho in the list scenario it might be better as List(List(1),List(2),List(3),Nil,List(4),Nil) and flatten the list to drop the Nils.
It is probably rare you want Some(null) but I find sometimes it's useful to have. Esp. if what you are saying is just that "this is defined, and it is null" and you're dealing with legacy data.
--
Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt

Thanks a lot @danieldietrich. I've learned a lot these three days. You have a lot of patience :)
Thanks for the example too, @talios. In our apps we force modeling nullable properties into Options, with the convention that a null is always mapped to a None. It makes sense because when a query returns a null value, then that column is an optional value that is not present. Also it provides nice semantics when reasoning about our domain model and a nice API when working with those objects.
We don't have queries which have rows filled completely with nulls because that wouldn't make any sense in our app.
We do have some queries that aggregate values from different sources which can produce some groups of columns with null values (doing left joins that you mention) but then again, we model that as an optional property in an aggregate domain.
We try to forbid null values in our apps. We have clearly defined domain boundaries where data is produced (web port for user input, database port, filesystem port, messaging port for queues, etc.) and that let's us to have a central code realm that follows our own rules. One of those rules is to not ever have a null and have Nones instead.
Thanks to this, we can protect ourselves from my original problem of Try.of(()->null).toOptional() being a Some(null) and transform it into a None in one of those boundaries where that happens.
I guess that the bottom line for me is: does it make sense to forbid null values in your business logic? (assuming that I can control all data flow into it)
We've been making this (among other things, naturally) for almost 2 years now, in a big codebase involving domains of operational applications, management tools, data analytics and big data. It feels right and produces clean, understandable, less buggy code.
I'd be very happy to hear about any "horror story" from you :)

Thanks @talios for the example.
@ggalmazor You're welcome. It was fun to me having a birds-view on Javaslang and reconsolidate some concepts.
I think also that it is the right way to forbid null values, at least in the business domain. In low, technical layers it might help to optimize code / performance when saving additional instances. But that should be the job of library designers and this implementation detail should not leak to the outside.
@all Have a great day!


Airdrop 505 DB Error

Hello. I was a "lucky airdropee", but 3 days ago my status was changing and I got an 505 error "Error: ERROR CODE 505 - DB error in method stellar.1.local.airdropRegisterLocal at new s ". Why? And How I can contact to support team?

Related:

https://github.com/keybase/client/issues/15257#issuecomment-531395333
#19515
#19531
#19548
#19572
#19600
#19607
#19642
#19643
#19644
#19646
#19647
#19669


When encountering obstacles, the path always returns to the starting point？

Hello, I compiled and installed the package on the ros melodic version, but when I run, if there is an obstacle in the middle of the path, the path planning of the robot will return to the original position?
The dwa used by my current local algorithm should be able to bypass the obstacle and continue to track the global path when it encounters an obstacle, but it is actually not possible, as shown in the following figure:

I don't know where the problem is, I look forward to your reply

The global plan provided by the planner should be fixed, so it's most likely an issue with the configuration of DWA.

I have the same situation when I use the teb local planner.

@Starkhen Not sure I can help you with that. I don't think it's a global planner issue, but the only quick thing you can do is simply specify a global path that does not pass through obstacles. Otherwise, look try to debug the local planner and why it doesn't follow the path.

I found this issue as well using TEB. It appears that makePlan() is called when the robot reaches the obstacle in the global path, and the local planner fails to find a feasible trajectory. It's not clear to me why makePlan() is called, as I have move_base max_planning_retries set to zero. I suppose one way to fix the behavior would be to track which waypoints have been cleared, and trim the global plan before republishing, but ideally the plan would just be abandoned.


An error occurred while sending the request.

TFS Version: 16.122.27409.2
I am trying to create a docker image for a build agent for my organization.
The Dockerfile I have created is looking like this:
FROM microsoft/vsts-agent:ubuntu-16.04-tfs-2018-u1

ENV TFS_HOST <HOST>
ENV VSTS_TOKEN <PAT>
ENV VSTS_POOL <POOL>
ENV VSTS_AGENT Docker-Agent-$(hostname)

However when I run the docker container I keep getting this:
>> End User License Agreements:

Building sources from a TFVC repository requires accepting the Team Explorer Everywhere End User License Agreement. This step is not required for building sources from Git repositories.

A copy of the Team Explorer Everywhere license agreement can be found at:
  /vsts/agent/externals/tee/license.html

>> Connect:

Connecting to server ...
An error occurred while sending the request.

Is there anyway to get more verbose information about what went wrong?

For following up on this. A way to debug this scenario is to run docker cp <container_instance_id>:/vsts . which will copy the vsts directory from the crashed container into the same directory. In there you can see the _diag directory with the log file.
The problem in this case seems to be that the TFS server doesn't have a valid SSL certificate.

Thanks for following up with this, I think it will be useful for others. Copying logs out is definitely a better solution than committing the crashed container and shelling into it. There may be a way to redirect the agents logs to stdout so it will show in the docker logs, ill look into that as well and drop an update here if I find out.
Marking this as resolved for now


http_response: remove status_code and success arguments

they're derived from the HTTP status now

Thank you @hannesm :)


alter restart strategy

This PR solves the problem when the Ethereum client becomes unreachable. I didn't find any logs of restarts in Kibana though.
The restart intensity gives us roughly 1 minute for the connection to recover.
This is a temporary solution to a different problem. Processes in omg_api are all supervised on the same level and coupled to a connection that's not monitored separately.
So I would suggest a refactor and decoupling to separate hierarchies and in cases when the connection goes offline - I would suspend the API.

LGTM as a first pass. I'll let someone in Poland who knows more about Elixir than me hit the approve button :)

There's one other thing - the inits of the child processes are not clean. Meaning that they immediately call integrated services and they're not able to start if they can't connect. A more decoupled approach would be to init them in a separate self send message or handle_continue.

I can do that. But TBH, I consider branching from master a bad habit because no one deletes stale branches. So forking should be at least considered. :) I think release branches and master branches are all that we should have.
You're right, I have noticed today that application borders are somewhat unclean.
It should be a separate PR, especially because with that approach, you're loosening the supervisor. Where before it meant that the process is automatically ready when it started, this is not the case if you let it start and run setup async. So yeah, you need to add readiness.
Backoff would really be a problem to implement at the moment - because of 3. You can't backoff in the init, because that halts the supervisor.

Branch from master.


Deployment of Tendermint + BigchainDB cluster

Description

Update existing docker-containers to support tendermint integration, nginx,
mongodb, bigchaindb
Add tendermint configuration files for statefulset, pvc, pv and service.
Update some READMEs.

Issues This PR Fixes
Fixes #1953
Fixes #1955
Deployment Notes
Will be part of a separate PR, will link it.

You've addressed all the comments I made so far, but as mentioned above,
"PersistentVolumeClaims for MongoDB got stuck in a "Pending" state."
I'll see if I can figure out why.

I was looking in the tendermint-k8s-dep branch just now (i.e. the branch for this PR) and noticed that there's a mongo-pv.yaml file in k8s/mongodb/. Is that still needed?


i make readme look pro

fix gramar to

I also made French translation

i will fix later it is 2 am

read through readme it look super propro

thx i wu ill wi willl fix then you xan merge

pro pro pro

i fix go comit

pog have to read new readme tho

looking pog shall merge


BREAKING: use font Roboto bundle instead of Google Fonts

Fixes #77
I marked this as a BREAKING change because it might potentially affect various things, e.g. we need to verify how this works with bundlers, and whether it affects Flow theme integration by the fact that we are adding static resources.
When running polymer-build fonts will likely have to be added to the extraDependencies list.
I will evaluate this using the Polymer starter. Also will check how Webpack works.

This change is

Are we sure we want to bundle the fonts? I’m not convinced it’s the best option. I would’ve gone with opt-in. But I assume because it’s currently already forced, we don’t want to introduce a visually breaking change?
If we want to bundle the fonts, then let’s at least make sure to use the fonts the OS (like Android) already has, or the ones a user might have installed themselves. For example:
@font-face {
         font-family: 'Roboto';
         src: local("Roboto Thin"),
              url('fonts/roboto/Roboto-Thin.woff2') format('woff2'),
              url('fonts/roboto/Roboto-Thin.woff') format('woff');
         font-weight: 100;
         font-style: normal;
       }

More information: https://stackoverflow.com/questions/3837249/font-face-src-local-how-to-use-the-local-font-if-the-user-already-has-it
Also, we need to make sure it’s possible to opt-out of using the Roboto font, even with the Material theme. AFAIK browsers should not load any web fonts unless there’s an element on the page that has a matching computed value for font-family. But, it would also be great to be able to opt-out from downloading the large style module in the first place (5.35 KB).

I’m not convinced it’s the best option. I would’ve gone with opt-in. But I assume because it’s currently already forced, we don’t want to introduce a visually breaking change?

We can make it opt-in, sure. That sounds better to me as well, although it will most likely require us some work to update Flow integration, as I mentioned above.
For now, will remove the import from typography.html

@platosha I would like to hear your opinion regarding this change.

Actually, I feel like the CSS file would be better to use, so that we could recommend including it on the app level, or consider using various approaches to e.g. delay it etc. Trying to see how it works with the bundler now.

Confirmed to work with the Polymer CLI when placing stylesheet in the app shell:
https://github.com/vaadin/vaadin-core-elements-ux/tree/material-roboto
Note: link available to the Vaadiners only but generally related changes are these:
  "extraDependencies": [
    "bower_components/vaadin-material-styles/fonts/**/*"
  ],

and HTML in the app shell:
<link rel="stylesheet" href="../../bower_components/vaadin-material-styles/font-roboto.css">

@jouni could you take another look at this PR once you have time?
Once it is merged, we can release 2.0.0 so it could be potentially used at least with bower by overriding versions in bower.json. Major releases for the components might happen later though.


Scroll-able window? [Feature Request]

Which operating system does the issue occur on?
windows - Windows 10

What exactly do you mean? Alacritty supports scrollback.

@chrisduerr please check the image below:

Just FYI, I also tried without tmux, the scrollbar option on the right doesn't show up.
Also if you try to just scroll with the trackpad or the mouse, it doesn't scroll either.

Alacritty does not show any scrollbar. If you're running tmux, it has a separate scrollback buffer.
Please make sure that you actually have lines in the scrollback, otherwise you obviously won't be able to scroll back.

@chrisduerr thanks, just figured that out. First day with tmux.
Closing this issue down.


Need ability to change variable in debug mode

Need ability to change variable in debug mode.
See here
Environment
VS Code : 1.23.1
Python IDE Extension: 2018.4.0
OS: Windows Server 2012 RC2 (via VMWare Fusion 8.5.10 on Mac OS/X High Sierra 10.13.4)
Python 3.6 (64-bit)

It was answered for me in the Stack Overflow post. Had tried on the Tooltip and the "Watch" panel, not the "Variables" one. Typical - the one I didn't think to try! Thought Watch and Variables would both work. May be worth adding there at some point too, because you'd think it would be possible from either.

@jgfet we don't control that, so if you would like to suggest that feature I would file a feature request with VS Code itself.


Test change

This PR is to check the featureprofiles CI trigger behavior.

Pull Request Functional Test Report for #1664 / 1e20e1f5d9ab448b81319123a3af0630bfb15abf
No tests identified for validation.

/fptest all

/fptest all


Fix readium-shared-js#378

This pull request is a Finalized
Related issue(s)
https://github.com/readium/readium-shared-js/issues/378

#61 replaces this


Update scalafmt-core to 3.0.4

Updates org.scalameta:scalafmt-core from 3.0.3 to 3.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #1006 (950f870) into develop (9897091) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1006      +/-   ##
===========================================
- Coverage    89.68%   89.57%   -0.12%
===========================================
  Files          124      124
  Lines         9905     9905
  Branches       511      511
===========================================
- Hits          8883     8872      -11
- Misses        1022     1033      +11

Impacted Files
Coverage Δ

...main/scala-2.12-/com/twitter/algebird/compat.scala
66.66% <0.00%> (-16.67%)
:arrow_down:

.../main/scala/com/twitter/algebird/Successible.scala
83.33% <0.00%> (-8.34%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
94.43% <0.00%> (-1.93%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
94.24% <0.00%> (-1.33%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
80.00% <0.00%> (-0.87%)
:arrow_down:

.../main/scala/com/twitter/algebird/Approximate.scala
90.32% <0.00%> (+1.61%)
:arrow_up:

...scala/com/twitter/algebird/PredecessibleLaws.scala
85.71% <0.00%> (+14.28%)
:arrow_up:

...n/scala/com/twitter/algebird/SuccessibleLaws.scala
92.30% <0.00%> (+15.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897091...950f870. Read the comment docs.


Use GetDataReturnType in GridConfig

What issue does this pull request correspond to (if any)?
Part of #2546
What does this pull request implement?
We migrate GridConfig#getData to use GetDataReturnType. We're
following the pattern laid out in the other subclasses of Application.
What changes are made in this pull request?

Addition: Added GridConfig.GridConfigData.
Breaking: The return type of GridConfig#getData is more precise now.

Thanks for the review/merge!


New Seminar Page

located at /seminar and structured according to https://paritytech.github.io/parity/devhub-seminar
@JoshOrndorff  and @ericmorel - let me know if everything looks alright. thanks!

This is looking great @thisisvilla Here are a few things that could be touched up on the seminar page.

I would love the phrase "Substrate Seminar" to be in the big text at the top. What if we change it to "Substrate Seminar - A Collaborative Learning Group"
A link got lost under the last question. It should be, The SCL recordings are still available.

Closing in favor of https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/pull/395


Puzzle x14191

URL

[ ] Image
[ ] Type
[ ] Defaults
[ ] Connections
[ ] Description
[ ] Verify

https://www.youtube.com/watch?v=oLp_Zav56J0 1:10

Unsure what the middle cube does


fix: handle window destruction in inactive workspaces

Addresses issue #82 by modifying the window destroy handler to take a grid_id associated with the destroyed window and falling back on the active grid_id if None is passed in.

Thank you!
I don't really see where the grid_id is falling back to the active grid when passing None.
Can you please give me some pointers?

Actually I don't think we have to fall back to the active grid id, since when the grid id is None the the title is also None.
We currently have some checks that just return when no managed window is found when the winevent is not Show.

LGTM
If you are happy with the PR I will gladly merge it!

I don't really see where the grid_id is falling back to the active grid when passing None.

It's this line with the unwrap_or

grid_id.unwrap_or(*WORKSPACE_ID.lock().unwrap());

And yeah, if you're good with it, I'm good with it. Also, is "open issue & submit pull request on development branch" ok with you for small bugs/features?

grid_id.unwrap_or(*WORKSPACE_ID.lock().unwrap());

I can't find the line in the diff, but like I said I don't think it matters.

Also, is "open issue & submit pull request on development branch" ok with you for small bugs/features?

That's ok for me 👍


WASM simple PoC

What does this PR do?
As a followup to one of conversation last week, a quick and dirty PoC + some benchmarks of libdatadog compiling into wasm

Ancient stuff at this point


Add public preview sentence to meeting-avatars.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9920
GA rollout to start new month:
https://www.microsoft.com/microsoft-365/roadmap?rtc=1&searchterms=107969&filters=&searchterms=107969

@dstrome
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


When specifiying  periods are being substituted for dashes

According to the documentation the  allows periods and the process doesn't error when they are present, however when the container image is built it substitutes (Normalizes) the periods for dashes. In the container image name I would like to prefix with our Azure container registry.
Would this be possible to do? I can work around by creating another build step to tag after build, but hoping to not have to.
Thanks.

Interesting - some (many?) container engines don't allow periods at runtime in image names, so we have explicitly chosen to normalize them. We ran into this with at least one registry during initial testing, but I'm struggling to remember if it was Docker or Azure Container Registry that didn't like this. Would you mind describing your target container runtime some more?

Currently running locally with dockerd via Rancher. Local repository doesnt seem to mind the periods. The intention of the containers I'm building is to push them to Azure Container Registry and run the images in Azure Container Apps

We should adjust this and then push up a sample against baronfel/sdk-container-demo to see if or how many of the test registries we have there blow up.


fix: 避免匹配到64导致version是6

这个 PR 实现什么功能/修复什么问题:
避免匹配到64导致version是6
是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @yousong

Codecov Report

Merging #3631 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master   #3631      +/-   ##
=========================================
+ Coverage    6.96%   6.97%   +<.01%
=========================================
  Files         499     499
  Lines       83677   83680       +3
=========================================
+ Hits         5832    5836       +4
  Misses      77347   77347
+ Partials      498     497       -1

Flag
Coverage Δ

#aFlag
6.97% <50%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/util/imagetools/imagetools.go
47.5% <50%> (+3.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed050e6...8b575a6. Read the comment docs.

/approve
/lgtm


prebuilt html artifacts can help the review for each PR?

What is the pain?
During reviews, most likely at the very end of review, i want to see and check how updated html files are going to look like with incoming PR. and what i do now is to clone developer's repository and build it on my environment to see the built html files with the browser.
this happens several times for each PR, and that is kinda burden... i guess the same thing goes to all maintainers who are working on reviews.
Proposal
Can we use github artifacts to upload the html files with github workflow in every commit? so that we can see html files with incoming changes only with downloading. No need to setup environment, clone, build the incoming PR repository.
What's in it for us?
for developers, they can see the html artifacts built with proposed PR to verify.
for maintainers, it makes easier to check how the final html files look like with downloading the artifacts.
i think this could accelerate the review process for ROS 2 documentation.

Can we use github artifacts to upload the html files with github workflow in every commit? so that we can see html files with incoming changes only with downloading. No need to setup environment, clone, build the incoming PR repository.

We used to have something like this where we would build and deploy to heroku.  But it was too much work to maintain so we gave up on it.
If we can figure out how to do this with a github artifact, that would be fine with me.  I think that would probably be easier to maintain than the heroku setup.

thanks. not using any cloud services is one of the idea for maintenance, just relying on github action is fairly simple enough and i do not see any downside to add it.

This issue has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros2-documentation-https-github-com-ros2-ros2-documentation-provides-html-artifacts-via-github-action/38224/1


Add "Reviewed by me" as a top-level filter in viewlet

The list of top-level filters (waiting for my review, assigned to me, etc.) is nice,
but would like to add one more: "reviewed by me". As it stands, once I complete a review with "approved" or "request changes" it no longer appears in "waiting for my review". That makes sense, but it makes it inconvenient to return to that PR--particularly if I did a "request changes". So until the PR is closed, it should show up in a new filter "reviewed by me".

Hi, may I help on this issue?

Thanks @thomas0306! The code for that sets the query is here:
https://github.com/Microsoft/vscode-pull-request-github/blob/778be8188cbfb8e65300d7571b60eeaca700509c/src/github/githubRepository.ts#L201-L218

Done! Please let me know for any improvements required.

Thanks @thomas0306 so much for submitting a PR, I’m sorry we ended up closing it! There’s now a setting that allows configuring the categories available in the tree, more info here: https://github.com/microsoft/vscode-pull-request-github#configuring-the-extension
As an example, you could change it to something like
"githubPullRequests.queries": [
	{
		"label": "Waiting For My Review",
		"query": "is:open review-requested:${user}"
	},
	{
		"label": "Assigned To Me",
		"query": "is:open assignee:${user}"
	},
	{
		"label": "Created By Me",
		"query": "is:open author:${user}"
	},
	{
		"label": "Reviewed by me”,
		"query": "is:open reviewed-by:${user}"
	}
]

Wow! This is great @RMacfarlane ! That (a) goes well above and beyond my original request, and (b) works great!
For other readers, I would just reiterate what the VSCode settings themselves say: if you want to add to the defaults, you have to explicitly include them. @RMacfarlane has done that in the example above. The first three are the defaults; the fourth one is the custom one requested by this issue.


bubblewrap build deletes custom added sources

Describe the bug
When you add extra sources (we want to add a widget) to a Bubblewrap project the project is build normally. We know all your custom sources will be deleted when you run bubblewrap update. However... we found that after updating the version number in twa-manifest.json and running bubblewrap build, all your custom sources are also deleted.
To Reproduce
Steps to reproduce the behavior:

Add custom sources.
Update the version number in taw-manifest.json
Run bubblewrap build
See that your custom sources are deleted.

Expected behavior
I would have expected that only the version number of the build was adapted so is possible to upload a new version to the playstore.
Desktop (please complete the following information):

Version Bubblewrap 1.19.1

Additional context
We would really like it if it was easier to add custom functionality to an app created with bubblewrap.

Hey, @mmzeeman, can you add examples of the files you are adding? Are those .java files, for instance?

Basically anything under app is wiped when an update or build (when twa-manifest.json changed) is done.

That's expected for update (see warning here). I'm surprised with build, though. Can you confirm that, if you add .java files to your project, then just run build (without ever running update), this happens?

This happens when the twa-manifest.json file is changed. Bubblewrap does an update when you press Y. This is a necessary step to get a new build number so you can upload the .aab to the PlayStore for internal testing.

FYI. At the moment we ditched the Android app project in favor of an iOS app using WKWebView and a widget. We discovered it was not possible to add any cookies set by the TWA in a http request by the widget.

The behaviour for update is working as intended. What seems could be helpful is a way to only update the version in twa-manifest.json.  Since most of app is being updated manually already, with custom Java files, etc, my recommendation would be to update the version in twa-manifest.json manually too.


feat: pass elementToBeCreated to shouldForwardProp

Currently it's not possible to replicate styled-components' internal logic in shouldForwardProp, because it doesn't have all the information. It only gets the prop key, not elementToBeCreated, and so it can't properly decide in a generic manner whether to forward props.
This PR upgrades shouldForwardProp to include elementToBeCreated as a third parameter. This should be backward-compatible with existing code because it only passed two parameters previously.
This is especially for when a styled component is called with as, because that makes the decision of whether to forward props more dynamic than is currently possible to express.
This PR should probably also update some documentation somewhere. I can make an additional commit if it otherwise looks good to y'all.

Makes sense to me, can you add a changelog entry?

@probablyup I just force-pushed with the changelog entry.
I actually replaced the babel macro changelog entry which doesn't need to be duplicated between 5.2.2 and the unreleased section.


Add Swift Package Manager to Swift.gitignore

This adds lines relevant to the Swift Package Manager to Swift.gitignore - the directories Packages and .build. This is the new, official package manager for Swift code.
Matches the style used for Carthage - build directory disabled by default, checkouts directory (Packages) optionally disabled. This matches what the official examples do, although actually running swift build will leave a dirty working tree, since they haven't checked in Packages already.

Seems legit - thanks for pointing to the official examples!


[Feature Request] Tasks display task duration from start time to end time

FR description
Option for tasks to display the duration of time from start to end time.
e.g. The task block for a task from 8:00 to 10:30 has a label that says 2'30"

I'm missing this feature the most to speedup some statistics collection throughout the week, i.e. how long was I studying this week etc.
I was planning to add a checkbox in settings + tooltip text on hover for the timeblock. Adding text to the block itself sounded too complex and interruptive to me but that may be the better option.
@benjwu2 @ivan-lednev what are your opinions on hover tooltip vs. inline time?

Also what should be the duration format? Someone may want to have it like "50 minutes" or "30m" or "1hr15m" or "00:15" or "
Actually, as I'm writing it, I've understood it should be another setting after the checkbox is checked

@bogdansalyp Personally, I would prefer inline time, as I'd like to be able to see the durations of all task blocks at a glance, without having to hover over each one to see their duration.

@benjwu2, can you share a screenshot or a drawing of what you have in mind?

Hi @ivan-lednev, here's an example:


DataFrame.explode returns a PY[object] column, even if coercible to something better

To Reproduce
from daft import DataFrame

df = DataFrame.from_pydict({"a": [[1, 2, 3]]})
df = df.explode(df["a"])
df.show()

+--------------+
|            a |
|   PY[object] |
+==============+
|            1 |
+--------------+
|            2 |
+--------------+
|            3 |
+--------------+

# Same result even if the list elements are explicitly e.g. pa.int8()s
# df = DataFrame.from_pydict({"a": [pa.array(list(range(10)), type=pa.int8())]})

Expected behavior
+--------------+
|            a |
|      INTEGER |
+==============+
|            1 |
+--------------+
|            2 |
+--------------+
|            3 |
+--------------+

Thanks for raising this!
This is expected behavior since we can't currently infer any return types of operations on Py columns without some form of user input.
For example, if a user's Python list looks like this:
df = DataFrame.from_pydict({
    "a": [
        [1, 2, 3],
        ["foo", "bar", "baz"],
    ],
})

We can only deduce that the type of the "a" column is a list but at runtime when the list explodes Daft has no typing information about its contents, which could be of any type. Without knowing the contents of the data itself ahead of time, Daft cannot make any decisions about the elements' types at static time.
However, by casting the resulting exploded dataframe, the user is asserting that the data is of a given type and Daft will throw a runtime error if that assertion proves to be false.
We could perhaps include a way to cast the data from the explode method, similar to the return_type= kwarg in .apply to make this more convenient behavior

Additionally, in the second case (df = DataFrame.from_pydict({"a": [pa.array(list(range(10)), type=pa.int8())]})) Daft will have support for native nested arrow types and explodes of a list<int64> should indeed give the correct type information!
#335 tracks the issue for adding complex arrow types

Closing and converting issue to a discussion for future reference!


In DockerV2 task is it possible to get input parameters entered in Container Registry and Container repository values as output variables

Hi,
In DockerV2 task is it possible to get input parameters entered in Container Registry and Container repository values as output variables. We would like to make use of these values in another script after this task.
Thanks

You could try extracting those values from the DockerOutput though, right?
We expose a path to the docker task's output. You could read that file and extract that information from the script.
If you're pushing in your previous step, you could look for the docker push string in the output, I'm sure it'll have the container registry and repository information


master-20181214

This is a generated PR that triggers release build, and will be automatically merged
none

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

release-build
6a6062bad4cbbdc13b5de6b6be74e4071febb330
link
/test release-build

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Could not find OpenGL when building Hyprland

How to reproduce:
git clone --recursive https://github.com/hyprwm/Hyprland && cd Hyprland
make all

This gives me the following error:
CMake Error at /nix/store/7jgkzsn972y4lrblv7f5rjpm46md0v64-cmake-3.27.8/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_glx_LIBRARY
  OPENGL_INCLUDE_DIR)
Call Stack (most recent call first):
  /nix/store/7jgkzsn972y4lrblv7f5rjpm46md0v64-cmake-3.27.8/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/7jgkzsn972y4lrblv7f5rjpm46md0v64-cmake-3.27.8/share/cmake-3.27/Modules/FindOpenGL.cmake:545 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:103 (find_package)

I tried this, but still gives me the error:
nix-env -iA nixos.libGL

This is not how NixOS is meant to be used. Please study the documentation further. You might want to make an overlay for Hyprland?

@tpwrules Which part is not meant to be used? Building hyprland, or libGL? Sorry, this is my first time using NixOS.

It generally does not work to git clone and make a package on NixOS due to the filesystem structure. Looks like there are some docs about using Hyprland: https://wiki.hyprland.org/Nix/ . However, other users have been reporting acceleration issues, in particular with home-manager.


3.0.3

Description of change:
Fixes broken success callback.
Adds Verified Domains endpoint support.
Description of implementation:
Fix success callback and add tests.
Add verified domains endpoint and add tests.
Risks & Mitigation:
Add tests around all new content. This will need to be a new release.

FILE: src/Resources/VerifiedDomains.php :x:
line: 49 | message: Expected 1 newline at end of file; 0 found

The Lint Wizard redacts anything he may have said before! :sparkles::sparkles::sparkles:
Lint Wizard Approved :heavy_check_mark:

The Lint Wizard redacts anything he may have said before! :sparkles::sparkles::sparkles:
Lint Wizard Approved :heavy_check_mark:


Improve Job Failure History REST API Endpoint - Add Error Type

@yuzhu

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11242/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11243/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11244/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11254/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11255/
Test PASSed.

alluxio-bot, merge this please


Experimental pull request for review of use of ExternalContext to share network context between application and operators.

@petewarden , @advaitjain
Could you please review this experimental PR which tries to add and use Get/SetExternalContext interface to share network context from application to operators?
Note, this is a dirty implementation, only for review of flow and use of interface.
(For e.g. TfLiteExternalContext* external_contexts_[kTfLiteMaxExternalContexts] is not a private array currently).

I think this looks promising. Have you thought about the use case where one would want to send multiple TfLiteExternalContext:s (eg different ones depending on which is the recieving kernel), and how the kernels would identify which one is intended for them?

I think this looks promising. Have you thought about the use case where one would want to send multiple TfLiteExternalContext:s (eg different ones depending on which is the recieving kernel), and how the kernels would identify which one is intended for them?

For the current use case, we would need single context for the whole network. But I see your point, it would be good to have flexibility to share multiple kernel specific contexts. One quick way to do that would be to extend TfLiteExternalContextType enum to have more entries.


Running wrattler client fails

Reported by @myyong:

IMAC-ATI0062:client myong$ yarn
yarn install v1.6.0
(node:6175) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
$ dotnet restore
shasum: /Users/myong/Documents/workspace/wrattler/client/.paket/../paket-files/paket.restore.cached:
shasum: /Users/myong/Documents/workspace/wrattler/client/.paket/../paket-files/paket.restore.cached:
EXEC : error : SecureChannelFailure (The authentication or decryption has failed.) (Github - cached (temporarily ignore updates)) [/Users/myong/Documents/workspace/wrattler/client/src/wrattler.fsproj]
EXEC : error : SecureChannelFailure (The authentication or decryption has failed.) (Github - cached (temporarily ignore updates)) [/Users/myong/Documents/workspace/wrattler/client/tools/DotnetCLI.fsproj]
/Users/myong/Documents/workspace/wrattler/client/.paket/Paket.Restore.targets(74,5): error MSB3073: The command "/Library/Frameworks/Mono.framework/Commands/mono --runtime=v4.0.30319 "/Users/myong/Documents/workspace/wrattler/client/.paket/paket.exe" restore" exited with code 1. [/Users/myong/Documents/workspace/wrattler/client/src/wrattler.fsproj]
/Users/myong/Documents/workspace/wrattler/client/.paket/Paket.Restore.targets(74,5): error MSB3073: The command "/Library/Frameworks/Mono.framework/Commands/mono --runtime=v4.0.30319 "/Users/myong/Documents/workspace/wrattler/client/.paket/paket.exe" restore" exited with code 1. [/Users/myong/Documents/workspace/wrattler/client/tools/DotnetCLI.fsproj]
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Looks like possibly related to https://github.com/fsprojects/Paket/issues/3132 - @myyong Can you please add what version of mono do you have on your main machine, and perhaps try updating to see if the error goes away?

I tried this on my old Mac and it worked - my setup is:

mono --version <IP_ADDRESS>
node --version 8.11.1
dotnet --version 2.1.100

So maybe try updating everything?


Bump example on comment in this issue

This Issue can be used to test the action.
There's an action in .github/workflows/update-examples.yml reacting on every comment on this issue.
When a comment is added, diagram in examples/sequence.puml (on branch example)  is modified with the comment id as a message on the sequence diagram and an svg is generated.
Generated diagram

test comment

another test

another one

hey hey

some testing

Give me some diagrams.

hey hey, more diagrams

test

ello

Another one ?

hey hey

hey, we have a new plant version !

test

k

test

another


Add this.blur() to stop flash of keyboard on iOS

Add this.blur() to stop flash of keyboard on iOS

@MatthewKennedy the readOnly attribute should already be preventing this as mentioned here: https://amsul.ca/pickadate.js/date/#editable

Hi @amsul
I had to make a video showing the issue, let me know what you think?
https://www.youtube.com/watch?v=HHXp3-cigho&feature=youtu.be

@MatthewKennedy video not available anymore?

@amsul try now

Ah yknow what..I just checked to confirm and it seems like this is a regression in one of the newer versions of iOS. It was specifically solved in the past by adding the readonly attribute.
But, the problem with this solution is that it breaks the tabindex flow when using the picker on a laptop/desktop. We'll need to find a way to do this without affecting the other use cases 🤔


how to set  shell $PATH

my shell code:
export PATH=/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/usr/local/jdk1.8.0_201/bin:/home/swcares/.local/bin:/home/swcares/bin:/usr/local/jdk1.8.0_201/bin
hooks.yaml:

id: redeploy-screen
execute-command: "reploy-screen.sh"
command-workingrectory: "/opt/app"
pass-arguments-to-command:

source: string
name: screen-task.jar
source: string
name:  restart

and webhook response:
error in exec: "reploy-screen.sh": executable file not found in $PATH

Hi qhyuTT,
did you tried:
execute-command: "/opt/app/reploy-screen.sh"
That's the way I run my scripts over webhook.
Br,
para-do-x

Also, you seem to have a typo in command-working-directory

Also, you seem to have a typo in command-working-directory

Hi qhyuTT,
did you tried: execute-command: "/opt/app/reploy-screen.sh"
That's the way I run my scripts over webhook.
Br,
para-do-x

Hi qhyuTT,
did you tried: execute-command: "/opt/app/reploy-screen.sh"
That's the way I run my scripts over webhook.
Br,
para-do-x

yeah，change my execute-command to /opt/app/reploy-screen.sh can running shell。thank you

Also, you seem to have a typo in command-working-directory

yes，thank you，i solved my question


When OVNController is disabed, set current version images

When there is no nicMappings configured, the OVNController CR gets cleanup, because there is no need to run one on the ctlplane. In this case, ReconcileOVNController deletes the CR and returns ctrl.Result{}, nil .
status.deployedOVNVersion: on the ctlplane gets set correct to the new version, but there was no change for the images on

instance.Status.ContainerImages.OvnControllerImage
instance.Status.ContainerImages.OvnControllerOvsImage

As a result the minor update process gets stuck and never proceeds.
Jira: OSPRH-12063

/retest


Design Chart Abstraction

One of the first steps to take, together with Data Set Abstraction (#6) is to design the Chart Abstraction.
Design should include:

[x] Chart properties
[x] Conceptual description of functionality

Initial chunk of Chart properties have been established in the design document. It is now up for discussion.

Chart components should generally be responsible for the GUI, while Data Set components should be responsible for the data logic to allow decoupling of the two components.

Chart abstraction decided on. Properties will depend on future design choices and the community's needs.


pull request for e2e test at 01/18/2017 09:26:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update documentation

the documentation is lagging behind - need to go through it an make sure it's up to date for 1.5.0
January 31, 2022 Update doc for the following issues:

[x] #170
[x] #287
[x] #306
[x] #283
[x] #308
[x] #587
[x] #589
[x] #609
[x] #617
[x] #660
[x] #692
[x] #722
[x] #730
[x] #812
[x] #819
[x] #828
[x] #841
[x] #847
[x] #873
[x] #891
[x] #905
[x] #907
[x] #923
[x] #937
[x] #992
[x] #993

January 19, 2022 Update doc for the following issues:

[x] #265
[x] #266
[x] #280
[x] #283
[x] #439
[x] #444
[x] #660
[x] #692
[x] #722
[x] #770
[x] #792

January 18, 2022 Update doc for the following issues:

[x] #172
[x] #176
[x] #179
[x] #223
[x] #229
[x] #231
[x] #317
[x] #341
[x] #507
[x] #543
[x] #545
[x] #607

To add to this - many good features have been delivered by you over the last several weeks. If we wanted to share the full scope of Monokle to date with someone or point them to the documentation that would be a challenge

fantastic work @jfermi !


Let ruff fix more issues

This will now use the default of fixing everything it can safely fix:
fixable = ["ALL"]

Rather than only the isort rules: https://docs.astral.sh/ruff/rules/#isort-i
Not sure why it was set to "I".

Uh removing it or setting to "ALL" seems to break the pixi instantiation for me?

I've just added it directly in 19bb310
lockfile was outdated, then I had somewhat corrupted conda data in my own .pixi; then merge conflict, etc. etc., didn't seem worth it.
Thanks for notifying this though!


VS Code Extension (zsh: exec format error: ..../aict.solidgpt-0.0.6/server/run_api_x86)

Hi,
Having issues with the VS Code Extension. I noticed it was stuck on "Initializing Please Wait." for a long time so I looked at the Terminal output and saw it was throwing: zsh: permission denied: /home/<me>/.vscode/extensions/aict.solidgpt-0.0.6/server/run_api_x86. So I chmodded it with exec privileges but now it's throwing: zsh: exec format error: /home/<me>/.vscode/extensions/aict.solidgpt-0.0.6/server/run_api_x86. I also tried executing it using bash but doing that it throws a different error: /home/<me>/.vscode/extensions/aict.solidgpt-0.0.6/server/run_api_x86: /home/<me>/.vscode/extensions/aict.solidgpt-0.0.6/server/run_api_x86: cannot execute binary file.
Not quite sure what the issue is. Any help would be appreciated.

hi may i have your system version (windows, linux, mac arm chip, mac intel chip)


Hook for Plugins to add commands to Amagaki

Would be handy to allow plugins to add custom commands for things that are 'outside' of the normal workflow.
For a translation plugin. You would not want a separate translation request every time a site is build, but being able to manually kick off a translation request would be helpful.
Something like amagaki translate request. Would allow a plugin to process any untranslated strings into a translation request file for the user, store the information in the amagaki cache, etc.
We can use a 'namespace' like amagaki plugin so that it does not restrict the future ability for amagaki to create built-in commands that may conflict with the amagki plugin ecosystem. But it a low probably to need to conflict with a plugin so it was decided to allow plugins use any unused built-in commands. In the future if amagaki wants to expand out commands the plugins will need to update their usage to let amagaki take over the command.

After some discovery, I think we should likely abandon this feature until we have a more concrete need. It's very easy to use gulp to accomplish a very similar feature – the ability for projects to add custom commands (e.g. to transform data, perform some sort of integration, or simply to use the Amagaki object model/API to work with the website data).
Here's an example:
// gulpfile.ts
import {KintaroPlugin} from '@amagaki/amagaki-plugin-kintaro';
import {Pod} from '@amagaki/amagaki';
import gulp from 'gulp';

const pod = new Pod('.');

gulp.task('kintaro', async cb => {
  // Do stuff with Kintaro plugin and `pod` object.
  cb();
});

gulp.task('kintaro', gulp.series('kintaro'));

Then:
npx gulp kintaro

runs the kintaro gulp task, that uses the Amagaki Kintaro plugin (and API).
Gulp tasks could be written to customize things like Sheets downloads, CMS downloads, etc. and can be integrated into projects with npm tasks (or incorporated via hooks to the build or dev server lifecycles as usual).


git: Fix Error: Directory not empty

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[x] Have you built your formula locally prior to submission with brew install <formula>?

Changes
On some systems the install of the htmldocs resource would fail because of a directory removal call on a directory that was non-empty. This fixes issue #1063.

:+1: Waiting on CI.

This fixes issue #1063.

For future contributions, please use Linuxbrew/linuxbrew#1063 to differentiate upstream Homebrew issues from Linuxbrew issues.

Thanks for your contribution, Chase! I've also added a bottle for git. It's unfortunately not marked as being relocatable, so it'll only be used when Linuxbrew is installed in /home/linuxbrew/.linuxbrew. You can try brew install git --force-bottle if you want to be experimental, but it may not work.


Make a new release

We have gone for a pretty long time since the last release. The plan is to change that: https://github.com/neurobagel/planning/issues/64. But first we need a release of our current app.

[x] draft a release with basic notes
[x] make it a patch version release :shrug:

It's been a little while since the last release... And before the big work starts, it would make sense to release the current state of the app

Drafted release is here. I'll move issue to tracked until after we have addressed #835

@surchs I suggest going with a minor release as opposed to a patch.

@rmanaem the release draft is here: https://github.com/neurobagel/annotation_tool/releases the proposal is to go v0.2.0 to v0.3.0

Release will go in once

#837

is merged


[GraphRBAC] Missing fields on User

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/1716

Codecov Report

Merging #1460 into master will increase coverage by <.01%.
The diff coverage is 85.41%.

@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
+ Coverage   54.62%   54.63%   +<.01%
==========================================
  Files        3142     3145       +3
  Lines       79379    79406      +27
==========================================
+ Hits        43362    43383      +21
- Misses      36017    36023       +6

Impacted Files
Coverage Δ

...graphrbac/azure/graphrbac/models/ad_group_paged.py
80% <ø> (ø)
:arrow_up:

.../azure/graphrbac/models/service_principal_paged.py
80% <ø> (ø)
:arrow_up:

...phrbac/azure/graphrbac/models/service_principal.py
44.44% <ø> (ø)
:arrow_up:

...re/graphrbac/models/group_add_member_parameters.py
83.33% <ø> (ø)
:arrow_up:

azure-graphrbac/azure/graphrbac/__init__.py
100% <ø> (ø)
:arrow_up:

azure-graphrbac/azure/graphrbac/version.py
100% <ø> (ø)
:arrow_up:

...zure/graphrbac/models/password_credential_paged.py
80% <ø> (ø)
:arrow_up:

...re-graphrbac/azure/graphrbac/models/graph_error.py
70% <ø> (ø)
:arrow_up:

...phrbac/models/user_get_member_groups_parameters.py
83.33% <ø> (ø)
:arrow_up:

...c/azure/graphrbac/models/get_objects_parameters.py
62.5% <ø> (ø)
:arrow_up:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592f178...1480e38. Read the comment docs.


Building conductor server via docker fails

I have taken the latest main branch code and tried to build the conductor server using docker compose and getting the following error:
FAILURE: Build failed with an exception.
#11 38.84
#11 38.84 * What went wrong:
#11 38.84 A problem occurred configuring root project 'conductor'.
#11 38.84 > Could not resolve all artifacts for configuration ':classpath'.
#11 38.84    > Could not resolve com.netflix.nebula:gradle-extra-configurations-plugin:5.0.3.
#11 38.84      Required by:
#11 38.84          project :
#11 38.84       > Skipped due to earlier error
#11 38.84       > Skipped due to earlier error
#11 38.84    > Could not resolve com.diffplug.spotless:spotless-plugin-gradle:5.+.
#11 38.84      Required by:
#11 38.84          project :
#11 38.85       > Failed to list versions for com.diffplug.spotless:spotless-plugin-gradle.
#11 38.85          > Unable to load Maven meta-data from https://plugins.gradle.org/m2/com/diffplug/spotless/spotless-plugin-gradle/maven-metadata.xml.
#11 38.85             > Could not get resource 'https://plugins.gradle.org/m2/com/diffplug/spotless/spotless-plugin-gradle/maven-metadata.xml'.
#11 38.85                > Could not GET 'https://plugins.gradle.org/m2/com/diffplug/spotless/spotless-plugin-gradle/maven-metadata.xml'. Received status code 500 from server: Internal Server Error
#11 38.85    > Could not resolve gradle.plugin.com.hierynomus.gradle.plugins:license-gradle-plugin:0.15.0.
#11 38.86      Required by:
#11 38.86          project : > nebula.netflixoss:nebula.netflixoss.gradle.plugin:9.2.2 > com.netflix.nebula:gradle-netflixoss-project-plugin:9.2.2
#11 38.86       > Skipped due to earlier error
#11 38.86       > Skipped due to earlier error
#11 38.86    > Could not resolve io.github.gradle-nexus:publish-plugin:1.0.0.
#11 38.86      Required by:
#11 38.86          project : > nebula.netflixoss:nebula.netflixoss.gradle.plugin:9.2.2 > com.netflix.nebula:gradle-netflixoss-project-plugin:9.2.2 > com.netflix.nebula:nebula-oss-publishing-plugin:1.1.3
#11 38.86       > Skipped due to earlier error
#11 38.86       > Skipped due to earlier error
#11 38.86    > Could not resolve org.ajoberstar.grgit:grgit-core:4.0.2.
#11 38.86      Required by:
#11 38.86          project : > nebula.netflixoss:nebula.netflixoss.gradle.plugin:9.2.2 > com.netflix.nebula:gradle-netflixoss-project-plugin:9.2.2 > com.netflix.nebula:nebula-release-plugin:15.3.1
#11 38.86       > Skipped due to earlier error
#11 38.86       > Skipped due to earlier error
Steps to reproduce:

Pull the latest version from 'main' branch
cd to docker
run docker-compose build

Currently works.
Thanks