Add ignore check option to Check Enforcer

We had a situation this week when a new module was being added to the SDK and the developer issued a /azp run prepare-pipelines command like expected. At the same time they set auto-merge on the PR. Unfortunately Check Enforcer took the prepare-pipelines check as a check that it should consider for passing the PR so the code automatically merged.
To stop this happening again, we need to add an option to the CHECKENFORCER configuration file that allows us to list the pipelines that we ignore for the purposes of evaluating check enforcer passing.

https://github.com/Azure/azure-sdk-tools/issues/1464 I filed the same issue earlier :)

Found issues that new service module only run prepare-pipeline without triggering the corresponding generated ci pipeline. It is better to have the link-checker scan the new module before check in. If we cannot trigger the exact ci pipeline, can we have some reminder in check-enforcer to remind people to manually trigger the generated pipeline?
Example:
The release pipeline caught the broken links which checked in by initial PR here.

Snap :) I'll close this one out.


Better .gitignore files

Did some cleaning to the project and added more rules to the .gitignore files

Thanks, happily merged


ci(rust): setup mold linker for Linux runners

mold is a much faster linker compared to GNU's ld.

Not actually faster :(


Fix lifetime names

Just realised I screwed up the naming for these lifetimes, the binary diffs are only usable inside the callbacks, they don't live for the lifetime of the Diff. Luckily the lifetime inference is correct so it's just the naming that's off.
Found when I was trying to come up with some way to create a tree of iterators to use instead of this callback directly, really disappointed that libgit2 doesn't have a way to externally iterate over the diff lines as well as this callback system :cry:.

I think that 'diff here is actually correct. For example the git_diff_binary_file has a const char* pointer, but that can really only possibly be a pointer in to the git_diff it originated from, I believe, so these functions basically act as if they have a pointer over to a Diff<'repo> structure.

https://github.com/libgit2/libgit2/blob/master/src/diff_patch.c#L310-L337
The binary objects are created on the stack and the data is temporarily created for the callback call.

Whelp! Nevermind then!
Thanks :)


Make JSON schema available in field validator functions

Hey, I just made a Pull Request!

This PR augments the field parameter in custom field validator functions with
the JSON schema of the field in question. This allows for validation checks in
the form of regular expressions or the like that are included in the form's JSON
schema to be reused in the code rather than having to duplicate them.
Implements #15465.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hey @hostsamurai!
Thanks for this! We actually added this to the scaffolder/next work already but maybe the issue didn't get closed already part of #16492. You can try it out following these instructions: https://backstage.io/docs/features/software-templates/testing-scaffolder-alpha
I'm feeling that it might not be worth backporting this feature to the current running version, as that will be replaced in the upcoming releases. Can you give it a test and see if it works in the scaffolder/next branch? :pray:

@benjdlambert, no problem. I'll test this out in the scaffolder/next branch 👍


Can't build 2.3.0 on El Capitan

I am running into a build error when I want to rbenv install 2.3.0 :
~ » rbenv install 2.3.0
Downloading ruby-2.3.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.0.tar.bz2
Installing ruby-2.3.0...

BUILD FAILED (OS X 10.11.3 using ruby-build 20160111)

Inspect or clean up the working tree at /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160130145501.97544
Results logged to /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160130145501.97544.log

Last 10 log lines:
installing tcltklib libraries
compiling ifaddr.c
installing default socket libraries
compiling init.c
compiling constants.c
linking shared-object socket.bundle
linking shared-object tcltklib.bundle
installing default tcltklib libraries
linking shared-object ripper.bundle
make: *** [build-ext] Error 2

I am running :

Homebrew 0.9.5 (git revision 7ff2f; last commit 2016-01-29)
rbenv 1.0.0
ruby-build 20160111
openssl: stable 1.0.2f (bottled) [keg-only]

this is where things seem to go down in the log file:
ossl_ssl.c:95:5: error: use of undeclared identifier 'TLSv1_2_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_2_method
^
ossl_ssl.c:96:5: error: use of undeclared identifier 'TLSv1_2_server_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2_server),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_2_server_method
^
ossl_ssl.c:97:5: error: use of undeclared identifier 'TLSv1_2_client_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2_client),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_2_client_method
^
ossl_ssl.c:101:5: error: use of undeclared identifier 'TLSv1_1_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_1_method
^
installing default syslog libraries
ossl_ssl.c:102:5: error: use of undeclared identifier 'TLSv1_1_server_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1_server),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_1_server_method
^
ossl_ssl.c:103:5: error: use of undeclared identifier 'TLSv1_1_client_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1_client),
    ^
ossl_ssl.c:89:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:176:1: note: expanded from here
TLSv1_1_client_method
^
ossl_ssl.c:186:21: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:85:14) []'
    for (i = 0; i < numberof(ossl_ssl_method_tab); i++) {
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:18:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))
                                  ^~~~~
compiling option.c
ossl_ssl.c:812:18: warning: implicit declaration of function 'ssl_encode_npn_protocols' is invalid in C99 [-Wimplicit-function-declaration]
        VALUE rprotos = ssl_encode_npn_protocols(val);
                        ^
ossl_ssl.c:813:2: warning: implicit declaration of function 'SSL_CTX_set_alpn_protos' is invalid in C99 [-Wimplicit-function-declaration]
        SSL_CTX_set_alpn_protos(ctx, (const unsigned char *)StringValueCStr(rprotos), RSTRING_LENINT(rprotos));
        ^
ossl_ssl.c:817:2: warning: implicit declaration of function 'SSL_CTX_set_alpn_select_cb' is invalid in C99 [-Wimplicit-function-declaration]
        SSL_CTX_set_alpn_select_cb(ctx, ssl_alpn_select_cb, (void *) self);
        ^
ossl_ssl.c:817:34: error: use of undeclared identifier 'ssl_alpn_select_cb'
        SSL_CTX_set_alpn_select_cb(ctx, ssl_alpn_select_cb, (void *) self);
                                        ^
compiling ossl_ssl_session.c
ossl_ssl.c:1906:5: warning: implicit declaration of function 'SSL_get0_alpn_selected' is invalid in C99 [-Wimplicit-function-declaration]
    SSL_get0_alpn_selected(ssl, &out, &outlen);
    ^
ossl_ssl.c:2265:23: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:85:14) []'
    ary = rb_ary_new2(numberof(ossl_ssl_method_tab));
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:18:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))
                                  ^~~~~
ossl_ssl.c:2266:21: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:85:14) []'
    for (i = 0; i < numberof(ossl_ssl_method_tab); i++) {
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:18:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))

things I have tried so far

installing 2.3.0-dev fails the same way
un-linking/re-linking openssl did no improve it either
reinstalling openssl doesn't improve it

This possibly relates to #889 but maybe not.

Thanks for sharing all this information. I can't reproduce using the same OS X version and latest "openssl" from Homebrew.
You don't need to link openssl from Homebrew in order to ruby-build to pick it up. It will be discovered automatically, even unlinked. You should unlink it to avoid messing up compilation of unrelated software.

I unlinked and re-tried and I still get the same result:
~ » brew unlink openssl --force
Unlinking /usr/local/Cellar/openssl/1.0.2f... 0 symlinks removed
~ » rbenv install 2.3.0
Downloading ruby-2.3.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.0.tar.bz2
Installing ruby-2.3.0...

BUILD FAILED (OS X 10.11.3 using ruby-build 20160111)

Inspect or clean up the working tree at /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160130173044.22893
Results logged to /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160130173044.22893.log

Last 10 log lines:
compiling ancdata.c
linking shared-object thread.bundle
compiling raddrinfo.c
compiling ifaddr.c
installing default socket libraries
compiling init.c
compiling constants.c
linking shared-object socket.bundle
linking shared-object ripper.bundle
make: *** [build-ext] Error 2

+1
Downloading ruby-2.3.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.0.tar.bz2
Installing ruby-2.3.0...

BUILD FAILED (OS X 10.11.3 using ruby-build 20160130)

Inspect or clean up the working tree at /var/folders/_8/zzmbwnb56zz2fqz3c66j2q740000gn/T/ruby-build.20160201134237.61009
Results logged to /var/folders/_8/zzmbwnb56zz2fqz3c66j2q740000gn/T/ruby-build.20160201134237.61009.log

Last 10 log lines:
	from /private/var/folders/_8/zzmbwnb56zz2fqz3c66j2q740000gn/T/ruby-build.20160201134237.61009/ruby-2.3.0/lib/fileutils.rb:225:in `block in mkdir_p'
	from /private/var/folders/_8/zzmbwnb56zz2fqz3c66j2q740000gn/T/ruby-build.20160201134237.61009/ruby-2.3.0/lib/fileutils.rb:211:in `each'
	from /private/var/folders/_8/zzmbwnb56zz2fqz3c66j2q740000gn/T/ruby-build.20160201134237.61009/ruby-2.3.0/lib/fileutils.rb:211:in `mkdir_p'
	from ./tool/rbinstall.rb:191:in `makedirs'
	from ./tool/rbinstall.rb:304:in `prepare'
	from ./tool/rbinstall.rb:513:in `block in <main>'
	from ./tool/rbinstall.rb:801:in `block in <main>'
	from ./tool/rbinstall.rb:798:in `each'
	from ./tool/rbinstall.rb:798:in `<main>'
make: *** [do-install-all] Error 1

Fixed by exiting git sh (my shell), then running rbenv install 2.3.0

I use ZSH so I tried to run rbenv install 2.3.0 in BASH. Same thing happens:
Workspace/supporter [bd-charity-projection-lifecycle] » /bin/bash
bash-3.2$ rbenv install 2.3.0
Downloading ruby-2.3.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.3/ruby-2.3.0.tar.bz2
Installing ruby-2.3.0...

BUILD FAILED (OS X 10.11.3 using ruby-build 20160130)

Inspect or clean up the working tree at /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160202090348.33529
Results logged to /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160202090348.33529.log

Last 10 log lines:
compiling ifaddr.c
installing tcltklib libraries
installing default socket libraries
compiling init.c
compiling constants.c
linking shared-object socket.bundle
linking shared-object tcltklib.bundle
installing default tcltklib libraries
linking shared-object ripper.bundle
make: *** [build-ext] Error 2

Also, ran from user root directory. Not sure that should make a difference.

It looks like we had 2 different errors, propagating the same BUILD FAILED error message.

It is still weird that changing your shell changed the behaviour of the rbenv install command

@mislav if the recommandation from the error message is
Inspect or clean up the working tree at /var/folders/6j/9f_77hx56nb7nthgbrwywwq4t55s8w/T/ruby-build.20160130145501.97544

is there anything I should delete on my machine before re-trying? Or is it most likely a tag/flags error?

UPDATE
I tried to install 2.2.4 and it turns out this is a general failure. I can't install it.
the log indicates that it would come from ossl_ssl.c:
compiling syslog.c
compiling ossl_ssl.c
linking shared-object syslog.bundle
installing default syslog libraries
compiling raddrinfo.c
ossl_ssl.c:125:5: error: use of undeclared identifier 'TLSv1_2_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_2_method
^
ossl_ssl.c:126:5: error: use of undeclared identifier 'TLSv1_2_server_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2_server),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_2_server_method
^
ossl_ssl.c:127:5: error: use of undeclared identifier 'TLSv1_2_client_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_2_client),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_2_client_method
^
ossl_ssl.c:131:5: error: use of undeclared identifier 'TLSv1_1_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_1_method
^
ossl_ssl.c:132:5: error: use of undeclared identifier 'TLSv1_1_server_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1_server),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_1_server_method
^
ossl_ssl.c:133:5: error: use of undeclared identifier 'TLSv1_1_client_method'
    OSSL_SSL_METHOD_ENTRY(TLSv1_1_client),
    ^
ossl_ssl.c:119:69: note: expanded from macro 'OSSL_SSL_METHOD_ENTRY'
#define OSSL_SSL_METHOD_ENTRY(name) { #name, (SSL_METHOD *(*)(void))name##_method }
                                                                    ^
<scratch space>:162:1: note: expanded from here
TLSv1_1_client_method
^
ossl_ssl.c:213:21: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:115:14) []'
    for (i = 0; i < numberof(ossl_ssl_method_tab); i++) {
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:19:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))
                                  ^~~~~
ossl_ssl.c:1149:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
            if (rc = SSL_shutdown(ssl))
                ~~~^~~~~~~~~~~~~~~~~~~
ossl_ssl.c:1149:13: note: place parentheses around the assignment to silence this warning
            if (rc = SSL_shutdown(ssl))
                   ^
                (                     )
ossl_ssl.c:1149:13: note: use '==' to turn this assignment into an equality comparison
            if (rc = SSL_shutdown(ssl))
                   ^
                   ==
ossl_ssl.c:2216:23: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:115:14) []'
    ary = rb_ary_new2(numberof(ossl_ssl_method_tab));
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:19:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))
                                  ^~~~~
ossl_ssl.c:2217:21: error: invalid application of 'sizeof' to an incomplete type 'const struct (anonymous struct at ossl_ssl.c:115:14) []'
    for (i = 0; i < numberof(ossl_ssl_method_tab); i++) {
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ossl_ssl.c:19:35: note: expanded from macro 'numberof'
#define numberof(ary) (int)(sizeof(ary)/sizeof((ary)[0]))
                                  ^~~~~

So that makes me think of an incompatibility with the current openssl version.
Since I am running openssl: stable 1.0.2f (bottled) [keg-only]and the latest release of ruby-build, this does not make sense to me. Only thing I can thing of is a LDFLAGS or CPPFLAGS issue.
What do you think @mislav ?

There were definitely multiple reports of this, but I haven't been able to reproduce and don't know what's going on. On the surface it looks like Ruby might not be compatible with newer versions of OpenSSL, which in theory could definitely be true since it happened before, but in this case it doesn't seem true since I cannot reproduce on OS X with same combination of Ruby + OpenSSL versions.

@mislav I was able to install 2.1.8 with no issue. Then I tried to install 2.2.0.
So maybe it comes from ruby 2.2.X
I am going to try to downgrade openssl and see what works.

@mislav Last update: I uninstalled openssl on my mac.then I reinstalled it. then I force-linked it with brew link --overwrite openssl --force
And I could install 2.3.0
You can close the issue since you are the owner, but I can do it if you want.

Since linking openssl could have unwanted side effects, I'd call this issue hacked-around rather than closed, myself.

I just fought with this issue for the last couple of hours. In my case, although I had done a brew uninstall openssl and brew install openssl to ensure I had the latest openssl version, it turns out that I had at some point installed openssl098. So a simple brew uninstall openssl098 fixed the issue for me.

Thank you very much, @ljohnston . That worked for me too. After uninstalling openssl098, I was able to successfully reinstall Ruby 2.3 with openssl unlinked.

@ljohnston You just saved my bacon. nicely spotted. cheers

Had the same problem with two installed versions of openssl, 1.0.2g and 1.0.2j. Uninstalled all versions of openssl, re-installed the latest and installed Ruby v2.3.1 via
brew uninstall --force openssl
brew install openssl
rbenv install 2.3.1

Thank you all.

I was unable to run brew uninstall openssl098: I got 'Error: No available formula with the name "openssl098"'.
I did see it in brew list, though.
I ended up getting rid of it like this instead: mv /usr/local/Cellar/openssl098/ /tmp (Stored it in tmp just in case there would be issues.)
So far, so good.  I was on the verge of smashing it against a wall out of frustration. Moving that openssl098 folder to /tmp allowed me to install ruby 2.3.3 without the crazy openssl error that I was getting for the past two days (fortunately I didn't spend the whole time of those two days banging my head against it).
But this definitely fixed it. Thanks!

Just in case someone is having this issue and all of the above didn't help:
I discovered that I had macports installed along with homebrew. That was causing weird openssl intermingling.
I removed macports and cleaned up all its directories. After that, rbenv install 2.3.3 install successfully. Good luck!
Note: be sure you know what you're doing before removing macports. You may have some important dependencies.

moving /usr/local/Cellar/openssl098/ and /usr/local/Cellar/openssl1.1 to tmp and then reinstalling with brew install openssl worked for me!  Thanks henrik


Fragmentation & Reassembly

Need to support fragmentation and reassembly.

We need to decide on fragmentation of requests: https://github.com/ReactiveSocket/reactivesocket/issues/77
Right now the protocol only allows fragmenting responses.

REQUEST_CHANNEL can be fragmented. At least it is specified in the frame that it has an F flag. Also, the fragmenter impl should support it. Off hand, not sure about the reassembler, but it should be easy to account for.

Right, REQUEST_CHANNEL does, so it's the other 4 REQUEST types.

Ah ok. I will add that to the spec in the next couple days.

Thanks Todd

A possible implementation of response fragmentation and reassembly is in pull request https://github.com/ReactiveSocket/reactivesocket-java/pull/63


fix(typo): fix some typo

Just correct some typo.
related issue: #1053

@jscode017 Do you need help on this one? (I see that you opened and then closed the PR in rapid succession)


GitHub Enterprise Cloud to GitHub Enterprise Server migration

Repositories
https://github.com/cvega/ghec-to-ghes-migrations-via-actions1
https://github.com/cvega/ghec-to-ghes-migrations-via-actions2

Target repository visibility
Private

/run-dry-run-migration


antlr resolution added and preinstall script added

Deals with a weird bug noticed by Julian in his previous PR.

I don't think I understand what the issue here was (or what antlr is actually even needed for in our code...). Can @Dtphelan1 or @julianxcarter explain this?

I don't think I understand what the issue here was (or what antlr is actually even needed for in our code...). Can @Dtphelan1 or @julianxcarter explain this?

Yes! fhirpath is a dependency of the MEF, and fhirpath also has antlr4 as a dependency. When you run npm upgrade mcode-extraction-framework from some (but apparently not all) of the repos that rely on the MEF, antlr4 is upgraded as well from version 4.8.0 to version 4.9.0 which breaks our unit tests. This PR is meant to lock antlr4 at version 4.8.0 until we can figure out what exactly is going on with this new antlr4 version, so this issue won't pop up again if we ever need to update the MEF commit from one of our other repos that have it as a dependency. @kjmahalingam

Some more info behind the scenes:
antlr recently upgraded their version from 4.8 to 4.9. antlr is a dependency of fhirpath. fhirpath doesn't specify a locked version number for antlr in their package.json; instead, they allow any minor/patch updates from 4.7 upward (i.e. ^4.7.0)
Problem: antlr doesn't obey semantic versioning, and version 4.9 requires a new version of node while older versions did not.
To avoid upgrading issues with other packages that depend on the MEF (see Julian's comment above) we're ensuring that the version antlr we use for fhirpath resolves to 4.8.


[th2-2401] new cradle version with removed calls for store attached m…

…essages

Merge to the master branch after Cradle release

Sure


psutil error when installing dask

What happened:
Trying to install dask-complete on miniconda python3.6.11 environment. Error when installing dask mostly related to psutil compilations.

Similar issue was seen elsewhere. Link directs to the solution implemented in that case.
What you expected to happen:
Get dask installed on the miniconda env.
Minimal Complete Verifiable Example:
pip install "dask[complete]"

Anything else we need to know?:
Environment:

Dask version: N.A.
Python version: Main version 3.8.3, conda env version 3.6.11
Operating System: OS 10.15.6
Install method (conda, pip, source): pip install "dask[complete]"

Are you proposing that distributed drop psutil as a dependency? I'm not sure how feasible that is (though you're welcome to investigate).
I'd recommend using pip's --only-binary=":all:" if you don't have a C compiler in your environment, or use conda which doesn't require a compiler.

Thanks for opening an issue @pgg1610

Get dask installed on the miniconda env

Instead of using pip could you

Oops, accidentally hit the close button : )
@pgg1610 for reference you can install dask using conda with
conda install -c conda-forge dask

Thanks for getting back so quickly! I did try to install dask using conda route but there has been some issue with the conda since I run into following error:
Solving environment: failed with initial frozen solve. Retrying with flexible solve.

For now, I will try re-configuring the conda-env and try installing dask again. Quick note: I did have dask installed and working in the previous conda-env (Python 3.4) but I have been facing issues ever since I switched to a new version.


Add ICT-Scouts / Campus

@PReimers I am sorry, it is not clear from the official website, if ICT-Scouts / Campus is a university or a college. Could you please make it clearer?

Hi @philipto
It's a Highschool specified on IT education.
IT related courses are:

Development (web / native / mobile)
VR
Robotics
and more

The courses have different durations from 3 months up to 3 years.
If you want to know more, just ask :wink:

@PReimers Could you please tell me what exactly at the website says that it's a high school? Google translate can be wrong, but as far as I can understand the website (which has just very basic and little info on the organization), ICT Campus is a kind of assosiation for both employers and schools, and it does not enroll students for long courses, but rather provide space (virtual? physical? mental?) for schools and employers to meet and study (?) Which page has a description of the course(s)?

Hi @philipto

The Website tells nothing about it. We only provide basic information on the website.
If you want to know us. Visit us!
We also provide courses/training for teachers. But teachers don't get an E-Mail address/account from us.
The schedule and courses are not publicly visible. If you want to know more, contact us.

I'm closing the PR and contacting the Support because I don't think you're qualified enough.


Segmented vloads with offset vector register EMUL*NF > 8 seems ambiguous

The spec seems to be ambiguous with respect to illegal indexed segmented vector loads. In particular, consider the following sequence:
vsetvli a1, t0, e8, ta, ma
vluxseg6ei64.v v8, (x5), v16

The data vector register group EMUL is 1, while the offset vector register group has EMUL=(64/8)*1 = 8. The spec says the following about segmented vector loads:

The EMUL setting must be such that EMUL * NFIELDS ≤ 8, otherwise the instruction encoding is reserved.

Interpreting this directly, I would assume that the previous sequence of instructions is illegal, since for the offset vector register group EMUL * NFIELDS = 8 * 6 > 8. But reading a bit more into the spec, one could argue that this should be legal because we are not accessing more than one vector register group of 8 elements. In fact, the next line after the previous quote says:

The product ceil(EMUL) * NFIELDS represents the number of underlying vector registers that will be touched by a segmented load or store instruction. This constraint makes this total no larger than 1/4 of the architectural register file, and the same as for regular operations with EMUL=8.

Stating that the goal of such restriction is to avoid accessing more than one 8-register vector group, which we are not doing in my example.
This feels a bit ambiguous to the point where I'm not quite sure which of the two is the correct interpretation. Can someone confirm which of the two interpretations is the correct one? Would it be possible to add some clarification in the spec?

I agree that the wording "the EMUL setting" is confusing, because EMUL is a property of a vector operand to an instruction, and different operands can have different EMULs. Like you point out, below in section 7.3.8 it says:

The data vector register group has EEW=SEW, EMUL=LMUL, while the index vector register group has EEW encoded in the instruction with EMUL=(EEW/SEW)*LMUL.

I've always read the spec as mandating EMUL * NFIELDS <= 8 only for the "data" vector operand. But I guess you could view it as also applying to the "index" vector operand, with NFIELDS = 1.

Here is my proposal: #868

Merged, thanks for helping to improve the spec.


Server crashes on vacuous step

Booster crashes when executing a rule of the form
rule 0 => 1 ensures false

Bug report: bug-report.zip
Reproduction in pyk (with K version: v6.1.83):
$ make test-integration TEST_ARGS='-n0 -k test_execute_booster[vacuous]'

I was unable to reproduce the crash with the provided bug-report.zip. Both kore-rpc-booster and booster-dev (as of master at the time of writing) return a vacuous response with 3 ~> .K in the k cell as the final state.

OK, correction: the above (observing the segfault) was with an earlier version of booster, not with current main.
Tme current main (d153e54) follows a change to the LLVM backend, which apparently already landed in K framework, but without the companion change to booster being in K framework.
Will see that we update the K dependency ASAP and investigate how to avoid this with more tests on upgrade PRs.

https://github.com/runtimeverification/k/pull/3911 should fix this , please re-test it with an update K version and re-open if the problem persists


"empty" place in VMs list

Description of problem:
VM portal shows an empty place in vm list when having many vms. It seems no predictable after how many vms this place appears.
see screenshot
Version-Release number of selected component (if applicable):
ovirt-web-ui-1.3.5-1.el7ev.noarch
How reproducible:
100%
Steps to Reproduce:

have many vms, open vm portal

Actual results:
see how vm list is rendered
Expected results:
from time to time there's empty space instead of a vm in vm list
screenshot https://bugzilla.redhat.com/attachment.cgi?id=1392728

No matter I'm logged in bugzilla, the screenshot link shows be "Access Denied"

yeah, seems it's not working:/

Original Issue: https://github.com/oVirt/ovirt-web-ui/issues/414
Bug fix: https://github.com/oVirt/ovirt-web-ui/pull/475


[2.0.x] Debian package still contains /etc/influxdb/influxdb.conf

Steps to reproduce:
dpkg -l influxdb
ii  influxdb       2.0.2        amd64        Distributed time-series database.

dpkg -L influxdb
/usr
/usr/bin
/usr/bin/influx
/usr/bin/influxd
/usr/lib
/usr/lib/influxdb
/usr/lib/influxdb/scripts
/usr/lib/influxdb/scripts/influxdb.service
/usr/lib/influxdb/scripts/init.sh
/etc
/etc/logrotate.d
/etc/logrotate.d/influxdb
/etc/influxdb/influxdb.conf

Expected behavior:
InfluxDB 2.0 should not deploy influxdb 1.x configuration file.
Actual behavior:
InfluxDB 1.x configuration file is deployed : /etc/influxdb/influxdb.conf
It's confusing
There should be only a /etc/influxdb/config.toml file

This appears to be fixed in v2.0.3, using the influxdb2 package.


Added FAQ page

Added an FAQ page on the homepage.
Minor updates to the following Session 1 pages:
02_create_a_user_account
Workflow updates and accompanying screenshots
05_help_documentation
Renamed from 04_getting_started as it is for user FYI and does not require user action. Suggested activities are included if the user wants to maximise utility of available documentation and tutorials. I expect the Session 1 exercise will take the place of the 04_ page.
docs/_static has been updated accordingly. Screenshots have not been sorted into folders to avoid added file path complexity - let me know if that would be better.
Relevant index.rst files have been updated accordingly.

Thanks for the detailed comments Andrew! The changes have been made as you suggested.
I have left the 01_, 02_ numbering convention in for now. I think it helps keep structure between contributors and shows gaps that need to be filled. Happy to remove them at a later date if it no longer suits.


this. completion in csharp mode

Used backend: (company-ycmd :with company-yasnippet company-dabbrev-code)
Prefix: ("" . t)
Completions: none
Typing "this." gets the above.

Typing "this." gets the above.
Do you mean that, when you type this. in some context where you expect completion, you get no completions? And what do you mean by "Prefix: ("" . t)".

A few things to check:

What are the contents of your *ycmd-server* buffer?
Are you sure you're in ycmd-mode?
Are you sure you're in company-mode?
Do you have ycmd and omnisharp-server installed properly?

2017-02-14 11:21:22,161 - INFO - Received completion request
2017-02-14 11:21:22,161 - DEBUG - Using filetype completion: True
2017-02-14 11:21:22,164 - INFO - Starting new HTTP connection (1): localhost
2017-02-14 11:21:22,166 - ERROR - Exception from semantic completer (using general): Traceback (most recent call last):
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/handlers.py", line 104, in GetCompletions
    .ComputeCandidates( request_data ) )
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/completers/completer.py", line 218, in ComputeCandidates
    candidates = self._GetCandidatesFromSubclass( request_data )
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/completers/completer.py", line 234, in _GetCandidatesFromSubclass
    raw_completions = self.ComputeCandidatesInner( request_data )
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/completers/cs/cs_completer.py", line 125, in ComputeCandidatesInner
    completion_type ) ]
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/completers/cs/cs_completer.py", line 447, in _GetCompletions
    completions = self._GetResponse( '/autocomplete', parameters )
  File "/Users/jj/.emacs.d/fork/ycmd/ycmd/../ycmd/completers/cs/cs_completer.py", line 588, in _GetResponse
    response = requests.post( target, data = parameters, timeout = timeout )
  File "/Users/jj/.emacs.d/fork/ycmd/third_party/requests/requests/api.py", line 107, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/Users/jj/.emacs.d/fork/ycmd/third_party/requests/requests/api.py", line 53, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/jj/.emacs.d/fork/ycmd/third_party/requests/requests/sessions.py", line 468, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/jj/.emacs.d/fork/ycmd/third_party/requests/requests/sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "/Users/jj/.emacs.d/fork/ycmd/third_party/requests/requests/adapters.py", line 437, in send
    raise ConnectionError(e, request=request)
ConnectionError: HTTPConnectionPool(host='localhost', port=57236): Max retries exceeded with url: /autocomplete (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x104c48a90>: Failed to establish a new connection: [Errno 61] Connection refused',))

Searching Python 2.7 libraries...
 All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 2/14/2017 11:08:25 AM.
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|Any CPU".
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" (1) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (2) on node 1 (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (2) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/Microsoft.Build.Evaluation/Microsoft.Build.Evaluation.csproj" (3) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  Microsoft.Build.Evaluation -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/Microsoft.Build.Evaluation/bin/Release/Microsoft.Build.Evaluation.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/Microsoft.Build.Evaluation/Microsoft.Build.Evaluation.csproj" (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (2) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Cecil/ICSharpCode.NRefactory.Cecil.csproj" (4) on node 1 (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Cecil/ICSharpCode.NRefactory.Cecil.csproj" (4) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory/ICSharpCode.NRefactory.csproj" (5) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  ICSharpCode.NRefactory -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/bin/Release/ICSharpCode.NRefactory.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory/ICSharpCode.NRefactory.csproj" (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Cecil/ICSharpCode.NRefactory.Cecil.csproj" (4) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/cecil/Mono.Cecil.csproj" (6) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  Mono.Cecil -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/cecil/bin/net_4_0_Release/Mono.Cecil.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/cecil/Mono.Cecil.csproj" (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  ICSharpCode.NRefactory.Cecil -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Cecil/bin/Release/ICSharpCode.NRefactory.Cecil.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Cecil/ICSharpCode.NRefactory.Cecil.csproj" (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (2) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/ICSharpCode.NRefactory.CSharp.Refactoring.csproj" (7) on node 1 (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/ICSharpCode.NRefactory.CSharp.Refactoring.csproj" (7) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj" (8) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  ICSharpCode.NRefactory.CSharp -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/bin/Release/ICSharpCode.NRefactory.CSharp.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp/ICSharpCode.NRefactory.CSharp.csproj" (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/ICSharpCode.NRefactory.CSharp.Refactoring.csproj" (7) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Xml/ICSharpCode.NRefactory.Xml.csproj" (9) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  ICSharpCode.NRefactory.Xml -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/bin/Release/ICSharpCode.NRefactory.Xml.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.Xml/ICSharpCode.NRefactory.Xml.csproj" (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  ICSharpCode.NRefactory.CSharp.Refactoring -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/bin/Release/ICSharpCode.NRefactory.CSharp.Refactoring.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/ICSharpCode.NRefactory.CSharp.Refactoring.csproj" (default targets).
ResolveAssemblyReferences:
  Consider app.config remapping of assembly "System.Core, Culture=neutral, PublicKeyToken=b77a5c561934e089" from Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/2.0-api/System.Core.dll] to Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/4.0-api/System.Core.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Configuration, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/2.0-api/System.Configuration.dll] to Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/4.0-api/System.Configuration.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System.Xml, Culture=neutral, PublicKeyToken=b77a5c561934e089" from Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/2.0-api/System.Xml.dll] to Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/4.0-api/System.Xml.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "mscorlib, Culture=neutral, PublicKeyToken=b77a5c561934e089" from Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/2.0-api/mscorlib.dll] to Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/4.0-api/mscorlib.dll] to solve conflict and get rid of warning.
  Consider app.config remapping of assembly "System, Culture=neutral, PublicKeyToken=b77a5c561934e089" from Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/2.0-api/System.dll] to Version "<IP_ADDRESS>" [/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/4.0-api/System.dll] to solve conflict and get rid of warning.
/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/msbuild/14.1/bin/Microsoft.Common.CurrentVersion.targets(1844,5): warning MSB3276: Found conflicts between different versions of the same dependent assembly. Please set the "AutoGenerateBindingRedirects" property to true in the project file. For more information, see http://go.microsoft.com/fwlink/?LinkId=294190. [/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj]
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
/Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/msbuild/14.1/bin/Microsoft.CSharp.CurrentVersion.targets(146,9): warning MSB3884: Could not find rule set file "MinimumRecommendedRules.ruleset". [/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj]
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
_CopyOutOfDateSourceItemsToOutputDirectory:
Skipping target "_CopyOutOfDateSourceItemsToOutputDirectory" because all output files are up-to-date with respect to the input files.
_CopyAppConfigFile:
Skipping target "_CopyAppConfigFile" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  OmniSharp -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/bin/Release/OmniSharp.exe
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (default targets).
Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" (1) is building "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.Tests/OmniSharp.Tests.csproj" (10) on node 1 (default targets).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
_CopyOutOfDateSourceItemsToOutputDirectory:
Skipping target "_CopyOutOfDateSourceItemsToOutputDirectory" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
  OmniSharp.Tests -> /Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.Tests/bin/Release/OmniSharp.Tests.dll
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.Tests/OmniSharp.Tests.csproj" (default targets).
Done Building Project "/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" (default targets).

Build succeeded.

"/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" (default target) (1) ->
"/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (default target) (2) ->
(ResolveAssemblyReferences target) ->
  /Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/msbuild/14.1/bin/Microsoft.Common.CurrentVersion.targets(1844,5): warning MSB3276: Found conflicts between different versions of the same dependent assembly. Please set the "AutoGenerateBindingRedirects" property to true in the project file. For more information, see http://go.microsoft.com/fwlink/?LinkId=294190. [/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj]

"/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp.sln" (default target) (1) ->
"/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj" (default target) (2) ->
(ResolveCodeAnalysisRuleSet target) ->
  /Library/Frameworks/Mono.framework/Versions/4.6.2/lib/mono/msbuild/14.1/bin/Microsoft.CSharp.CurrentVersion.targets(146,9): warning MSB3884: Could not find rule set file "MinimumRecommendedRules.ruleset". [/Users/jj/.emacs.d/fork/ycmd/third_party/OmniSharpServer/OmniSharp/OmniSharp.csproj]

    2 Warning(s)
    0 Error(s)

Time Elapsed 00:00:04.60
npm WARN tern_runtime No repository field.
npm WARN tern_runtime No license field.
     And what do you mean by "Prefix: ("" . t)".

Yep, I type "this." inside a function inside a class (I'd expect it to be able to complete instance variables/properties).

A few things to check:
What are the contents of your *ycmd-server* buffer?

^
Are you sure you're in ycmd-mode?

Yeah
Are you sure you're in company-mode?
Yeah
Do you have ycmd and omnisharp-server installed properly?
Not sure.
(use-package company-ycmd
  :ensure t
  :commands (ycmd-mode)
  :init
  (defvar ycmd-path (concat (getenv "HOME") "/.emacs.d/fork/ycmd/ycmd"))
  (defun jojo/ycmd-setup-keys ()
    "Setting initial key bindings for ycmd."
    (evil-define-key 'normal ycmd-mode-map
      (kbd "gr") 'mimic-find-references
      (kbd "g.") 'ycmd-goto
      (kbd "g/") 'pop-tag-mark))
  (defun jojo/ycmd-base-setup ()
    "Base setup for ycmd."
    (require 'company-ycmd)
    (set-variable 'ycmd-server-command `("python" ,ycmd-path))
    (setq ycmd-extra-conf-handler 'ignore) ;; Only use global config
    (jojo/company-push-backend 'company-ycmd)
    (ycmd-mode 1))
  (add-hook 'csharp-mode-hook #'jojo/ycmd-base-setup))

Looking at the server log, it looks like there is a problem with the server connection to the omnisharp server.
I have no experience with csharp, but I tried out a test project from the ycmd folder (ycmd/ycmd/tests/cs/testdata/testy). After opening a file from the project I was able to get semantic completion, out of the box.
There is a similar issue in the YouCompleteMe project: https://github.com/Valloric/YouCompleteMe/issues/2530
cc @vheon

Thanks, I put a comment in that issue. Will close this one and track that one instead.


Add more developer documentation

What is the problem the feature request solves?
I would like to have more documentation around the project. I was planning of creating a sphinx documentation as a starting point since its the same used in datafusion as well (https://github.com/apache/arrow-datafusion/tree/main/docs/source). Later on I would like to expand that to how rapids provides it (https://nvidia.github.io/spark-rapids/developer-overview/) . Let me know your thoughts and if you are okay with me creating a skeleton documentation to start of first ?
Describe the potential solution
No response
Additional context
No response

I am also interested in contributing to the developer documentation as I get up to speed on this project.
I don't have a strong preference for sphinx or any other format but would be interested to see what others think.

I went ahead and created https://github.com/apache/datafusion-comet/pull/314 to set up a minimal site, using the same scripts and tools as DataFusion. It would be great to have some PRs to add content to this site.
Here are my thoughts on some good areas to contribute:

What is Comet?
How does it work?
Benchmark Results
Compatibility Guide
Configuration Guide
What is supported?

Data Types
Expressions
Operators
File Formats

Roadmap

I would like to add a section like Installation or something like that after "What is Comet?"

We should also explain how the shims work for different Spark versions


refactoring/linting/vetting/idiomatic

Mostly learning to use your lib, feel free to reject if it's not to your standard

also there didn't seem to be any tests so I ran al the programs and they all worked

Looks nice. Thanks! some tiny nits and then we can merge.
Yes, there should be (hermetic) tests...


Upgrade to use officially Node 6

I've been running the server for quite a while on Node 6.
Unless there are compelling reasons we should upgrade to the latest major version, which now is 6.

Perhaps also add a .nvmrc[0] file stating the Node.js version?
[0] https://github.com/creationix/nvm#nvmrc

Done.

Related to #73 ? You wanted some help?

#73 outlines the tasks. The main thing to do is to upgrade all SK components CI on travis to use Node 6 and make sure they pass on your own fork, then PR the changes.
Then there is the RPi installation instructions in this repo.

OpenPlotter will keep nodejs 4 LTS because is the only version supported by node-red, node-red-dashboard and node-red-freeboard. I guess it will be backward compatible, I will report if any problem is detected.

@sailoog https://github.com/node-red/node-red/blob/master/.travis.yml#L16
http://nodered.org/docs/hardware/raspberrypi#upgrading

As of version 0.14.x there is a script in the pre-installed version of Node-RED that will do a full upgrade to the latest nodejs LTS and latest release version of Node-RED.

AFAIK latest nodejs LTS is 4.
Tested node-red-dashboard and node-red-contrib-freeboard with nodejs 6 and multiple crashs.

It is 6 since last week: https://github.com/nodejs/LTS

ops you are right.
I will try to find out the node-red-dashboard and node-red-contrib-freeboard plans.
Do you think signalk-server-node could be in trouble with nodejs 4? I was using 6 but I went back to 4 when I implemented these dashboards due to crashes.

This is for keeping up with things/not falling behind and development comfort that new ES features bring.

@sailoog any updates?
BTW I recommend that Open Plotter should consider nvm https://github.com/creationix/nvm. It allows peaceful coexistence of different Node versions.

I am about to merge plugins where the changes in this branch are already merged.

ok.

Merged manually.


Add required variables for the lint CI job

These variables are necessary for golangci-lint to run correctly.
/cc @ybettan

Missing a commit message. Besides that lgtm.

/lgtm

/lgtm


"collection selector was not NavigationExpansionExpression" when joining two FromSql()s

Test FromSqlRaw_queryable_multiple_composed fails with the error "collection selector was not NavigationExpansionExpression" (check after #15752 is merged).

fixed in 7bb6d10c1e7ec8bc7c2cece56f5c61be386bcf51


What does the normalize.min.css.map do?

I know this is not an issue and I've noticed (through a DevTools console error/warning) I have to place this file in the root directory, but I'm curious what does this .map file do?

It's called source map. In devtools, you can see the full source code for the minified file when it's present.

Ah ok... that explains it :) Thanks!

If you don't mind, kindly close this issue if it's resolved.

Okay... will do!


Use FileExists instead of fs::exists for Unicode support

Our "FileExists" function will support Unicode with #3835. Make sure we use
it instead of directly calling the "std::filesystem" version which does not handle
Unicode very well out of the box. See #3835 for more detail.

@antonrohr thanks for the comments. I'm closing this in favor of https://github.com/google/orbit/pull/3847 wich adds UTF-8 support to "A" variants of Windows API and makes the std::filesystem::path work as expected with UTF-8 strings.


Fixes an 'Undefined variable: pipes' notice.

This is not a significant issue by any stretch of the imagination, but it's a quick fix and there's no reason for this notice to be there.

Good catch, thanks @BrunoDeBarros.


fix(package): update kronos-endpoint to version 2.12.0

https://greenkeeper.io/

[Current coverage][cc-pull] is 6.45%

Merging [#248][cc-pull] into [master][cc-base-branch] will decrease coverage by 51.61%

File lib/adminService.js (not in diff) was modified. more

Misses +16
Partials 0
Hits -16

@@             master      #248   diff @@
=========================================
  Files             1         1
  Lines            31        31
  Methods           7         7
  Messages          0         0
  Branches          3         3
=========================================
- Hits             18         2    -16
- Misses           13        29    +16
  Partials          0         0

Powered by Codecov. Last updated by [ae5452b...5d20236][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/compare/ae5452bb2897a3f9e69e51d8f75fb82982e048c2...5d202361d6c7157b2ab458e29ae9a217ab1a469d
[cc-pull]: https://codecov.io/gh/Kronos-Integration/kronos-service-admin/pull/248?src=pr


[partial, required]: implement falsy masks and optional/nullable/nullish flavors

Closes https://github.com/colinhacks/zod/issues/2191 and https://github.com/colinhacks/zod/issues/2190
Previously a mask allowed you to to require/partialize only certain properties while leaving the others intact. I called such old behaviour thruthy masks because you selected the properties assigning a true value to them.
I implemented the opposite, meaning that you can require/partialize all properties except certain ones. I called this new behaviour falsy masks because you select the properties assigning a false value to them.
I've made care of making everything backwards compatible, with the small exception that you can't mix true and false values in the same mask anymore (previously false values were simply ignored) because that would be ambiguous: how should it behave, like a falsy or thruthy mask? I could theoretically treat it as a truthy mask and ignore falsy values but that would be a bad behaviour in my opinion because it wouldn't be intuitive. Also the breaking change is small enough because I see no valid reason why anybody would be mixing true and false values anyway.
Since we're at it I'm also forbidding empty masks (previously {} was a valid mask) because again it's not intuitive whether you should treat it as a truthy or falsy mask (I think that particular fix ended up in the second commit, but since I'm upstreaming both of them it shouldn't matter. I can rebase it into the first one if you prefer).
The second feature I'm upstreaming are optional/nullable/nullish flavors for partial and required. That depends on the previous commit because it implements such behaviour for both truthy and falsy masks. Previously partial transformed a field of type T into T | undefined while required transformed a field of type T | undefined into T. Since along with the optional method we also have nullable and nullish methods it makes sense to have nullable and nullish flavors of partial and required as well. Naming starts to get messy though, so I've decided to not add any more methods but instead select the "flavor" via parameters. I've made sure to keep everything 100% backwards compatible so the default is still the optional flavor and the number and the position of the parameters changes depending on the overloaded function: parameters get processed and mask and type get reassembled in the function implementation so this is completely transparent to the end user.
A nullable flavor of required will strip out ZodNullable instead of ZodOptional (T | null becomes T) while the nullish flavor will
strip out both ZodNullable and ZodOptional (T | undefined | null becomes T).
Similarly a nullable flavor of partial will wrap with ZodNullable instead of ZodOptional (T becomes T | null) while the nullish flavor will wrap with both ZodNullable and ZodOptional (T becomes T | undefined | null).
While bad behaviours are already enforced via typings (not mixing falsy and truthy masks, not passing empty masks which are ambiguous and cannot be discerned to a specific mask type) I also enforce these checks via type assertions (assertMaskIsNotMixed). While special care has been taken to optimize such function, a small (IMO negligible) performance impact is inevitable. If you prefer we can get rid of it and assume all our users will use TypeScript, but in my opinion it's better to keep it. I've also been careful to compute conditions outside of for loops to achieve some small performance improvements whenever possible, so I wouldn't worry about that.
I might have been over zealous  with the tests and they are probably too much and too many, but I didn't want you to get mad about testing every single possible corner case so the more the better. Feel free to cut them down as you see fit.
I still didn't update the documentation because I was looking for some feedback first. You didn't answer to my feature requests yet so I hope this will be enough to get your attention because I'd really love to have these features merged ASAP.
I'm currently working on a zod types generator so I will hopefully be able to test this on a larger project of my own soon. Tests are probably enough to cover every possible corner case, but the more testing the better.

I've manually updated my projects' zod types to make use of the methods introduced by this PR (instead of my custom helpers) and the resulting types still match with the database schema.
By the way we will probably want to rename assertMaskIsNotMixed to assertMaskIsValid and PartialType to FilterType or something else (because it's being used by both partial and required).

This is really extremely useful, especially in cases where a backend doesn't support (or doesn't want to) serializing non-existing (null) values to undefined (missing in json). I'd love to see this merged soon, because it would allow us to get rid of some ugly code.

because it would allow us to get rid of some ugly code

I know the feeling, in fact I have more things I would love to get merged but I'm waiting for this before pouring more time into tests/etc. With this PR, the automatic zod types generator that I've just finished and the remaining features which I'm currently shipping in my own zod fork I've basically cut down several hundreds lines of code into just a few dozens, plus I've uncovered several bugs. One of these additional features is built-in support for SQL UNIONs: whenever you need to UNION two different tables everything but the intersection must be nullable and it is extremely annoying and error prone having to do so manually.

Not stale, I'm still waiting for any kind of feedback from the maintainer.

ping @colinhacks

This is great stuff! Hope this gets reviewed soon.
If it isn't, it could be solely down to that wall of text in the initial post. Headings, bullet points, and code blocks go a long way - particularly for complex issues. Would be a shame to see this go to waste.

I've had a tremendous amount of trouble deciding what to do with this. For starters, it's a really well-made PR and it implements features that I think are useful. But there are some things that are giving me pause which I'll outline below. All told though, I'm going to close this, but I really appreciate the great work here @darkbasic, and the patience from everyone on this thread.
Modes
I don't like the idea of "modes" like PartialType generally, and usually I can think of an API that avoids them. (More on that later.)
Bundle size
I was hesitant to add this in v3 because it's a lot of code for a feature that isn't widely requested. Zod 4 will be redesigned to be more tree-shakable so this becomes a little more okay, but since most users will use ZodObject, these methods will end up in their bundle, even if unused.
What is "optional" anyway?
Zod 4 will make a distinction between different types of "optional". There's the "question mark" flavor ({name?: string}) and there's the "or-undefined" flavor ({name: string | undefined }). In Zod 4 you'll be able to specify one or the other  flavor (or both) when defining object schemas. Any API that deals with partial/required needs to be able to handle that distinction. It's tricky.
Here's a rough initial proposal for the set of "partial" APIs. All of these optionally accept (truthy) masks.
const schema = z.object({ name: z.string() });

schema.partial();  // { name?: string | undefined }
schema.partial.except({ ... }) // equivalent of falsy masks

schema.allow.empty(); // { name?: string }
schema.allow.undefined(); // { name: string | undefined }
schema.allow.null(); // { name: string | null }
schema.allow.nullish(); // { name: string | null | undefined }

The proposed set of "required" APIs. All of these optionally accept (truthy) masks.
const schema = z.object({ name: z.string().optional().nullable().or(z.undefined()) });
// { name?: string | undefined | null }

schema.required();  // { name: string }
schema.required.except({ ... }) // equivalent of falsy mask

// mask supported but optional
schema.not.empty(); // { name: string | undefined }
schema.not.undefined(); // { name?: string | null }
schema.not.null(); // { name: string | undefined }
schema.not.nullish(); // { name?: string }

Optionality is complicated. Whatever ends up landing in Zod 4 will be quite a bit different from this PR. I don't feel that good about my proposal either. I'll keep this all this in mind as I rethink things for Zod 4, maybe something more elegant will materialize.
Thanks again @darkbasic! And feel free to chime in with thoughts.

Thanks for reviewing my PR, even if you didn't end up accepting my changes in the end.
Unfortunately I don't have the time right now to discuss eventual API changes, but I'd like to add my two cents about its utility.

I was hesitant to add this in v3 because it's a lot of code for a feature that isn't widely requested

I suspect that this feature is of particularly high value to library/tools developers rather than end users.
In particular as a mikro-orm collaborator I've written a typings generator that creates a zod schema from the ORM entity definitions, with the goal of generating slonik types via the ORM metadata to manually write composable SQL queries that are type safe at runtime and build time:
https://github.com/mikro-orm/mikro-orm/discussions/5102#discussioncomment-8076746
https://the-guild.dev/blog/accounts.js-1.0-rc#about-me
It relies on this feature for which I'm currently maintaining my own zod fork, which is the main reason why I haven't released it yet.
That being said, even if its main utility would probably be limited to libraries/tooling developers, I can still see 11 hearts just in this PR, which is massive wall of text that would scare 90% of the users just by the sheer size of it.


Is there an angular 2 implementation for this library ?

I would really like to use this in my angular project, is that possible ?

@felipeinfantino: there is something about using mediaelement with angular-cli, but not sure about the version
https://github.com/setrar/angular-cli-media-element

@felipeinfantino   Does it answer your original question ?

Any examples for this?


react-redux connect MapStateToProps state parameterization

#1731 improved a lot of things! But it's worth noting that the past definition of MapStateToProps was parameterized on state, which make it possible to "flow" your Redux state types into your component prop types, without the need to explicitly type the return of MapStateToProps.
Wondering if there was an explicit reason that parameterization was dropped. Is there a bug in Flow or some sort of insufficiency that's preventing it from being typed that way in the revamp?

@Ashoat  Thanks for reporting the issue! All I know is that it's been working previously, see this: https://github.com/facebook/flow/issues/5792#issuecomment-372346578 and try flow link
It's simplified version of the issue, and as you can see, 0.56 fails like it should, but more recent Flow versions does not catch the error.

Was there a reason you dropped the parameterization of state in MapStateToProps? Was that parameterization breaking anything? Naively I’m guessing adding back that type parameterization would enable the typechecker to know the shape of the state type.

@Ashoat I'm not sure if i follow. If you mean something like this, looks like it does not work.
The reason for dropping all the previous work was to be able to start from scratch. I couldn't grasp my head around the previous version and most of the tests were failing so I couldn't trust on them either.

@villesau: Sorry for the late reply here. My issue is that I am forced to type the state parameter passed to my MapStateToProps as an Object. If I try to change the type to the more specific shape of my Redux state, I get Flow errors. However, having the state typed as Object means Flow doesn't let me assume anything about its shape. So I'm forced either to make runtime assertions, or to circumvent the type system with an any-cast. This is how I am doing it:
 mapState = (objectState: Object, ownProps: OP): {
   ...SP,
   cookie: ?string,
   urlPrefix: string,
   deviceToken: ?string,
 } => {
   const state: S = (objectState: any);
   return {
     ...mapStateToProps(state, ownProps),
     cookie: state.cookie,
     urlPrefix: state.urlPrefix,
     deviceToken: state.deviceToken,
   };
 };

I think the reason the previous libdef allowed us to use to a more specific shape to type our MapStateToProps function was that its definition of MapStateToProps was parameterized on the Redux state instead of just typing it as Object. I just tried re-adding the parameterization, and it seems to have solved my issue. I'll put up a PR.


Transaction for TimeLock (or || and) HashLock: Script failed an OP_EQUALVERIFY operation

The issue
I am trying to create Transaction for TimeLock (or || and) HashLock without Signer(P2SH, P2WSH)
However when I try to broadcast the tx to _https://blockstream.info/testnet/tx/push_ it gives me this error: sendrawtransaction RPC error: {"code":-26,"message":"mandatory-script-verify-flag-failed (Script failed an OP_EQUALVERIFY operation)"}
Can you inspect what is wrong with my script?
Tx raw:
010000000168f1479d7e6b2b67fde3c227324f18d93a5b0620a11fb872863891fe4e35c0ab0000000030015103abcdef2903a4bd2db175aa204533a01d26697df306b3380e08f4fae30f488d2985e6449e9bd9bd86849ddbc688fdffffff01d40200000000000017a9145b107712b126b2bedc82ddfd6673c1f946f741d387a4bd2d00
Tx decoded:
{
    "txid": "52458ff3d982120e8067ccf7214852b6b1e51772f4f16183ca9609699f169a93",
    "hash": "52458ff3d982120e8067ccf7214852b6b1e51772f4f16183ca9609699f169a93",
    "version": 1,
    "size": 131,
    "vsize": 131,
    "weight": 524,
    "locktime": 2997668,
    "vin": [
        {
            "txid": "abc0354efe91388672b81fa120065b3ad9184f3227c2e3fd672b6b7e9d47f168",
            "vout": 0,
            "scriptSig": {
                "asm": "81 -7327147 03a4bd2db175aa204533a01d26697df306b3380e08f4fae30f488d2985e6449e9bd9bd86849ddbc688",
                "hex": "015103abcdef2903a4bd2db175aa204533a01d26697df306b3380e08f4fae30f488d2985e6449e9bd9bd86849ddbc688"
            },
            "sequence":<PHONE_NUMBER>
        }
    ],
    "vout": [
        {
            "value": 0.00000724,
            "n": 0,
            "scriptPubKey": {
                "asm": "OP_HASH160 5b107712b126b2bedc82ddfd6673c1f946f741d3 OP_EQUAL",
                "desc": "addr(39zX91yFegz6N5NfewGMua2ydWrsDHtKcb)#5p7pu9up",
                "hex": "a9145b107712b126b2bedc82ddfd6673c1f946f741d387",
                "address": "39zX91yFegz6N5NfewGMua2ydWrsDHtKcb",
                "type": "scripthash"
            }
        }
    ]
}

Script:
import * as bitcoin from 'bitcoin-sdk-js';

// initialize Bitcoin Transaction object
const tx = new bitcoin.Transaction();
const txId = "abc0354efe91388672b81fa120065b3ad9184f3227c2e3fd672b6b7e9d47f168";
const value = 1000;
const BLOCK_HEIGHT = 2997668;
const fee = 276;
// add UTXO to spend as an input
await tx.addInput({
  txHash: txId, // transaction id of utxo
  index: 0, // index of utxo in transaction
  value: value, // value of utxo(unit is satoshi)
} as bitcoin.UTXO);

// add Target output to send Bitcoin
// sends bitcoin to script with timelock + hashlock (no sig required)
await tx.addOutput({
    address: await bitcoin.address.generateScriptAddress(
        // if you only want hashlock, you can remove generateTimeLockScript
        (await bitcoin.script.generateTimeLockScript(BLOCK_HEIGHT)) +
        (await bitcoin.script.generateHashLockScript("abcdef")),
        "legacy",
        "testnet"
    ),
    value: value - fee, // value of utxo - fee
} as bitcoin.Target);

// if transaction use timelock input, must set tx locktime bigger than input timelock
await tx.setLocktime(BLOCK_HEIGHT);

// if input utxo requires to unlock hash with smart contract(p2wsh or p2sh)
await tx.unlockHashInput(
    "abcdef",
    0,
    'legacy', // default is segwit, you might use legacy if necessary
    await bitcoin.script.generateTimeLockScript(BLOCK_HEIGHT),// is timelock input? provide script
);

// You can broadcast signed tx here: https://blockstream.info/testnet/tx/push
const txToBroadcast: string = await tx.getSignedHex();
console.log(`${txToBroadcast}`);

You are trying to spend single-sig(p2pkh) utxo, but with unlockHashInput (https://blockstream.info/testnet/tx/abc0354efe91388672b81fa120065b3ad9184f3227c2e3fd672b6b7e9d47f168?expand).
The code example assumes that your input to spend is utxo which is built in a same way of output to send(below one).
javascript
// add Target output to send Bitcoin
// sends bitcoin to script with timelock + hashlock (no sig required)
await tx.addOutput({
    address: await bitcoin.address.generateScriptAddress(
        // if you only want hashlock, you can remove generateTimeLockScript
        (await bitcoin.script.generateTimeLockScript(BLOCK_HEIGHT)) +
        (await bitcoin.script.generateHashLockScript("abcdef")),
        "legacy",
        "testnet"
    ),
    value: value - fee, // value of utxo - fee
} as bitcoin.Target);

So after send to the address of above, then try unlockHashInput.

Thank you for your reply! @ChrisCho-H  I think that I started to figure it out
From what I understand, I believe I should do the following steps:
1- Send some BTC to the script address to get another another utxo
2- Spend this new utxo using unlockHashInput
I am trying to do step 1 which is sending btc to the script address first to get a new utxo
But when I try to broadcast the tx to the network, it gives me this message:

sendrawtransaction RPC error: {"code":-26,"message":"mandatory-script-verify-flag-failed (Script evaluated without error but finished with a false/empty top stack element)"}

My script:
const senderPrivKey = "6dc2d85ecdf1c1a742610e1ba4760be64daf1e225f64fa7918851978f61cad06";
const receiverPubkey = "03e5a00cdb4a5a432bde9a39d0c71bac483f9c587974474e0ce5e7c5cb0f0bdaf6";

const txId = "873019bc502f9918d0c79ef21ea832ad9b007b1b089cb8ee0fd4de556dc54a39";
const value = 1000;
const fee = 312;

const ADDRESS_TYPE = "legacy";
const NETWORK_TYPE = "testnet";

const tx = new bitcoin.Transaction();

await tx.addInput({
  txHash: txId,
  index: 0,
  value: value,
} as bitcoin.UTXO);

const script = (await bitcoin.script.generateHashLockScript("abcdef"));

const scriptAddr = await bitcoin.address.generateScriptAddress(
    script,
    ADDRESS_TYPE,
    NETWORK_TYPE
)
console.log(`scriptAddr: ${scriptAddr}`);

await tx.addOutput({
    address: scriptAddr,
    value: value - fee, // value of utxo - fee
} as bitcoin.Target);

await tx.signInput(senderPrivKey, 0, ADDRESS_TYPE);

const txToBroadcast: string = await tx.getSignedHex();
console.log(txToBroadcast);

Thank you so much for clearing up the confusion @ChrisCho-H
It worked!

Thank you so much for clearing up the confusion @ChrisCho-H
It worked!

Pleasure :)


Fix containerAction. It was not considering queryParams

While testing killContainer, ran into issue that "signal=SIGHUP" is not getting POST'ed in the URL queryParams. The below change fixes it.

Codecov Report

Merging #944 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #944   +/-   ##
=========================================
  Coverage     67.43%   67.43%
  Complexity      748      748
=========================================
  Files           170      170
  Lines          3111     3111
  Branches        348      348
=========================================
  Hits           2098     2098
  Misses          861      861
  Partials        152      152


Update our documentation regarding the configuration files

Task Description
As a follow-up to #965, we need to update our documentation. We should:

[x] Add a page called "The strongbox.yaml file" to the "User Guide" in the strongbox-docs.
[x] Add a page called "The strongbox-authorization.yaml file" to the "User Guide" in the strongbox-docs.
[x] Add a page called "The strongbox-cron-tasks.yaml file" to the "User Guide" in the strongbox-docs.
[ ] Add a page called "The strongbox-security-users.yaml file" to the "User Guide" in the strongbox-docs.
[ ] Update the Application Properties page.
[x] Update the Routing Rules page.

Task Relationships
This task is a follow-up of #965.

@carlspring what is expected to be updated in the Application Properties page?

@carlspring , @sbespalov  , @fuss86
what is to be added into the files "The strongbox.yaml file",  "The strongbox-authorization.yaml file" , "The strongbox-cron-tasks.yaml file", "The strongbox-security-users.yaml file" ?


Is there any contract for ETH?

Hello. How can I check ETH balance?

You can also view eth_balance in the JSON request like so:
https://api.tokenbalance.com/token/0xa74476443119A942dE498590Fe1f2454d7D4aC0d/0xda0aed568d9a2dbdcbafc1576fedc633d28eee9a
Output JSON
{
"token": "0xa74476443119A942dE498590Fe1f2454d7D4aC0d",
"wallet": "0xda0AEd568D9A2dbDcBAFC1576fedc633d28EEE9a",
"name": "Golem Network Token",
"symbol": "GNT",
"balance": "5401731.086778292432427406",
"eth_balance": "0.985735366999999973",
"decimals": 18,
"block": 6611832
}


Unable to create an account

I followed the set up steps and was able to see the login and signup page on localhost:4200

However, I'm getting this error when pressing "Register" on the signup page

My backend terminal looks like this after the running the last instructed command dotnet run --project LightNap.WebApi

My frontend terminal looks like this after running the last instructed command npm run start

I'm also experiencing this error, with the same error message

even after downgrading to .NET version 8.0.404 as described in Issue #24 , I get the same error message that the server wouldn't connect.

Based on the screenshots, it appears that the backend was not running. The error message "We were unable to connect to the service" is sent by the frontend when it is unable to connect to the backend. Please try running the backend in a separate terminal when running the frontend and let us know if the same issues still persist.


Successful retried payments not returning success status

Bug report
Possible issue in fixed-price-subscriptions example.
Describe the bug
When a card is declined, and the customer retries with a new card, the payment status on the invoice (returned from retry-invoice) is open, and payment status never changes to success.
To Reproduce
In React.js mode:

On the checkout, enter the payment fail test card<PHONE_NUMBER>000341
Press submit, and the error response is as declined, as expected.
Enter the test card that should succeed<PHONE_NUMBER>424242
After onSubscriptionComplete, in setAccountInformation, result.subscription.status = open

Expected behavior

On the checkout, enter the payment fail test card<PHONE_NUMBER>000341
Press submit, and the error response is as declined, as expected.
Enter the test card that should succeed<PHONE_NUMBER>424242
After onSubscriptionComplete, in setAccountInformation, result.subscription.status = success

Solution
To solve it, I have modified onSubscriptionComplete with an extra check with retrievePaymentIntent for payments that have previously failed (see below).
    async function onSubscriptionComplete(result) {

        if (result && !result.subscription) {
            //this is hit when a payment failed and is retried, so there's no subscriptionon the result
            const subscription = { id: result.invoice.subscription };
            result.subscription = subscription;
            localStorage.removeItem('latestInvoiceId');
            localStorage.removeItem('latestInvoicePaymentIntentStatus');

            let paymentIntent = result.invoice.payment_intent

           //double check if the payment has been successful
            await stripe
                .retrievePaymentIntent(paymentIntent.client_secret)
                .then((confirmationResult) => {
                    console.log(confirmationResult)
                    if (confirmationResult.error) {
                        // start code flow to handle updating the payment details
                        // Display error message in your UI.
                        // The card was declined (i.e. insufficient funds, card has expired, etc)
                        throw confirmationResult.error;
                    } else {
                        if (confirmationResult.paymentIntent.status === 'succeeded') {
                            console.log('succeeded')
                          //do something like this to update payment status, not working properly though
                           result.invoice.subscription.status = confirmationResult.paymentIntent.status
                        }
                    }
                });
        }

        setAccountInformation(result);

        // Change your UI to show a success message to your customer.
        // successful if (accountInformation.subscription.status == 'active' || accountInformation.subscription.status =='succeeded')
    }

System information

OS: [e.g. macOS]
Browser (if applies) [chrome]
Server environment [ Node]

Additional context
Overall, I'm not sure this is even an issue, and doing this extra check is necessary..it depends if open status on an invoice means the subscription has succeeded.

Hello @GraemeFulton, thank you for a great write up. The current example verifies the payment has been successful by checking if it is a retry and requires_payment_method on Line 50 here. On line 63 the result of stripe.confirmCardPayment is the updated payment intent showing success. This should avoid having to do another API call to retrieve the payment intent and can check the status === succeeded there. If this payment intent succeeds the invoice will automatically update and put the subscription in active state.

Oooh I see! Thanks a lot, it was there all along 🙈, - so I just need the check where you highlight.
I was confused because in component render line 286, it checks for account information before redirecting, which sometimes isn't 'success', and I wanted to redirect when success only. That solves it though! thank you!


Added inner and outer background

Added inner and outer background for section-row. #6 resolved

@MeenuKumari28 you have to use the word closes #<PR_number>. You wrote #<PR_number> resolved. As you see the issue #6 was not marked as closed. Please use exactly the command to automatically close the issue.


chore: Bump to Go 1.22

Pull Request Template
Description
Bump Go from 1.20 to the 1.22 version.
Fixes #49
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/recheck


Move flag.Parse in tests to TestMain

This this fixes issues with custom and testing flags in Go 1.3 and should work
in previous go versions.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #3744 into master will increase coverage by 3.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
+ Coverage   41.98%   45.39%   +3.41%
==========================================
  Files         131      118      -13
  Lines       14528    11639    -2889
==========================================
- Hits         6099     5284     -815
+ Misses       7521     5448    -2073
+ Partials      908      907       -1

Flag
Coverage Δ

#linux
45.39% <ø> (ø)
:arrow_up:

#windows
?

Impacted Files
Coverage Δ

remotes/docker/fetcher.go
42.5% <0%> (-7.5%)
:arrow_down:

remotes/docker/auth.go
63.82% <0%> (-3.97%)
:arrow_down:

remotes/docker/status.go
21.42% <0%> (-3.58%)
:arrow_down:

remotes/docker/errdesc.go
28.12% <0%> (-2.65%)
:arrow_down:

remotes/docker/errcode.go
47.61% <0%> (-1.6%)
:arrow_down:

platforms/cpuinfo.go
3.77% <0%> (-0.85%)
:arrow_down:

log/context.go
36.84% <0%> (-0.66%)
:arrow_down:

remotes/docker/handler.go
22.38% <0%> (-0.09%)
:arrow_down:

errdefs/grpc.go
77.46% <0%> (-0.04%)
:arrow_down:

remotes/docker/pusher.go
0% <0%> (ø)
:arrow_up:

... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38937f0...d5b7bf5. Read the comment docs.


Add transform variable to input:touchpad

Description
The variable is present for input:touchdevice but not for input:touchpad, would it be possible to add it? I sometimes use my laptop like a book, and using the touchpad is a real pain.
Thanks

a matrix here doesn't make sense as IIRC touchpad is reported relative by the driver. We could add a flip_y and flip_x tho


Emoji response are broken

Hello,
Random bug. I notice I cannot get emojis on newer version of llama-2-70b-chat. You can test it on replicate UI by prompting the model "send me an emoji".
Here's the previous version that works:
https://replicate.com/meta/llama-2-70b-chat/versions/2d19859030ff705a87c746f7e96eea03aefb71f166725aee39692f1476566d48
Anything after that commit (for example https://replicate.com/meta/llama-2-70b-chat/versions/2c1608e18606fad2812020dc541930f2d0495ce32eee50074220b87300bc16e1) prompting for an emoji returns blank.
You can also see the emoji does not get send on the web version of chat:
https://www.llama2.ai/

Comparing between the two commits for the working vs broken github doesn't show anything that stands out to me with my native eyes.
https://github.com/replicate/cog-llama-template/compare/f76b86fafe744ee423192fc23dafcfb88f530326..d292081429e06f34f9ea9fe84b17470828221465


Callautomation v4 api

Update callautomation to V4 api
Use V4 api swagger generation client for call automation sdk. The live tests and unit tests works.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.CallAutomation


Added stage flag for git_commit action

Sometimes new files need to be staged

Thanks for this PR @viktorasl, it looks like this could be solved by this PR too, right? https://github.com/fastlane/fastlane/pull/1101/
Do you think it makes more sense to have 2 steps, one for staging and one for committing?

What do you mean saying "two steps"? Do you mean two actions? I think it depends on needs, for me it's important to commit newly fetched files, so I just need to stage them and commit. In that particular case it's enough to have just a flag for git_commit action. But if it's more common and useful to have them as a separate actions I wouldn't mind.

I also think keeping the git_add action separate is better because it can serve more use cases. This PR is a great idea and I can see exactly how this PR makes sense in your workflow but might not be right for everyone.

I agree. Should I close PR?

Thanks!


Add missing dir to 'cd'

thx @duglin I believe this has been taken care of in https://github.com/projectatomic/skopeo/pull/121

:(

Ah if only I had read it a few minutes later  :-)  thanks


Remove local declaration and replace it with the class name

Vue Skeleton has merged a PR from @riccoarntz (https://github.com/hjeti/vue-skeleton/pull/90). This PR will apply the same updates to the seng-generator templates for this module.

Coverage decreased (-2.6%) to 88.344% when pulling 7f3d01ec9711f336498e372e2031022d8ac5ed82 on pigeonfresh:feature/remove-local-declaration into c8593a2a3e542367a6a9ebc188db9403c0117bb1 on larsvanbraam:master.


Dictionary with lazy values isNullAt out of index.

Bug description
this could be related to :
https://github.com/facebookincubator/velox/pull/6498
https://app.circleci.com/pipelines/github/facebookincubator/velox/33185/workflows/c0caf989-e528-4eb4-bbb6-32b2d7bbaa16/jobs/214392
System information
NA
Relevant logs
NA

ok so many issues :

Dictionary with nested lazy are not downsized when children are loaded this result in non copyable vectors.
SwitchExpr::evalSpecialForm reuse condition even when its not flat!, this can be problematic.
EvalSpecialFom call ensureWritableResult, the problem is that ensureWritableResult always preserve exisiting data even when not needed.

I will go with fixing (2) @krishna is working on 1

two diffs mitigate this looking int fixing the actual load vector load issue now

https://github.com/facebookincubator/velox/pull/6581
https://github.com/facebookincubator/velox/pull/6585

I landed two fixes that mitigate this and here is a third that fix the
lazy vector issue
https://github.com/facebookincubator/velox/pull/6663

Fixed by https://github.com/facebookincubator/velox/pull/6663


Why was the Untrusted Workloads removed?

This is more of a naive question than an issue.
I am following https://github.com/prabhatsharma/kubernetes-the-hard-way-aws and periodically cross referencing this tutorial when I have problems. I noticed Untrusted Workloads was removed from the Smoke Test lab when the tutorial was updated for Kubernetes 1.15.
I also noticed that the AWS tutorial has a Check images/pods/containers on worker nodes using crictl section in the Smoke Test lab, while this tutorial does not.
Can someone shed some light on why these sections are not present/were removed?

According to this pull request #400, it seems to be mainly for the convenience of maintaining this tutorial.

That's a great find, thanks @moehajj!

@moehajj is right. I need to keep this thing focused.


added event bubbling capturing and delegation concept in javascript

Hi @shruti49
I added event bubbling , capturing and delegation concept in javascript with code and explanation .
Please review this PR.


update styled-components

Deploy preview for pixelsonly-production processing.
Built with commit 99821154e01bd3d1b8166714b06b2fed406d70bc
https://app.netlify.com/sites/pixelsonly-production/deploys/5aa01d18fd0efa3a643b92cf


Official release with Xcode 12 support?

New Issue Checklist

[x ] I have read and understood the CONTRIBUTING guide
[x ] I have read the Documentation or CocoaDocs
[x ] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
iOS

Platform Version
14.0

CocoaLumberjack Version
2.3.2

Integration Method
cocoapods

Xcode Version
Xcode 12.0

Issue Description and Steps
I have seen on issue #1160 that @ffried mentioned that for Xcode 12 support you must use the master branch.
When can we expect an official tagged version of CocoaLumberjack with Xcode 12/ iOS 14 support?

@geoffclifton Thanks for reminding me!
I was a bit undecided on this, given the chaotic release of iOS 14 and Xcode 12.
But I agree that tagging a release is probably beneficial, so there's #1174 for preparing this.

3.7.0 is live! 🙂

3.7.0 is live! 🙂

Thanks.
Appreciate the quick action on this!


Increase test coverage by adding AES and CAMELLIA empty buffer tests

This PR resolves https://github.com/ARMmbed/mbedtls/issues/2014.

The fails are as follows:

IAR tests fail due to missing IAR license;
MbedOS examples fail due to "MBEDTLS_PSA_ITS_FILE_C defined, but not all prerequisites", which seems pretty unrelated, since this PR doesn't change defines;
-Hashing Nucleo test fails due to "Error: L6200E: Symbol mbedtls_ecp_tls_read_point multiply defined" and others - unrelated;
There are no fails related to added tests.

CI is acceptable as a pass, only failing due to unrelated known issues.


[OAP-1482][oap-native-sql] Columnar shuffle decimal support

What changes were proposed in this pull request?
Columnar shuffle decimal support.
How was this patch tested?
c++/Scala unit tests.

cc @zhouyuan

Resubmit https://github.com/Intel-bigdata/OAP/pull/1648


Support VTI's

See readme.

@gigatexel  you should refer to a asset from your branch. If you really want to include the image place it in the root folder. If you want you can delete the other image which is not used anymore. I think it is called cloud config.

@gigatexel you should refer to a asset from your branch. If you really want to include the image place it in the root folder. If you want you can delete the other image which is not used anymore. I think it is called cloud config.

Thanks for the suggestion. Should be fixed now.

merged manually

merged manually

is ther esomething I'm doing wrong that causes the need to merge manually?

@gigatexel no. Maybe I is because I am not a really expert in git and pull request. I do it normally like this I compare it what is different and change the things what I prefer on the fly. I could also push it first back to the pull request and then merge it but I was in a hurry yesterday because I have 3 other projects which I must work on.
And at the moment I have 2 main problems on which I work on this project. There is not much time for improvements an new features.

@gigatexel no. Maybe I is because I am not a real expert in git and pull request. I do it normally like this I compare it what is different and change the things what I prefer on the fly. I could also push it first back to the pull request and then merge it but I was in a hurry yesterday because I have 3 other projects which I must work on.
And at the moment I have 2 main problems on which I work on this project. There is not much time for improvements an new features.

I'm also not a github wizard, that's why I was asking :-)
What main problems do you have with pyLoxone? Maybe I can help/assist?


Uncaught Error: URIHandlerRegistry#handleURI asked to handle an invalid URI: atom:%20command%20no...

[Enter steps to reproduce:]

...
...

Atom: 1.28.2 x64
Electron: 2.0.5
OS: Mac OS X 10.13.6
Thrown From: Atom Core
Stack Trace
Uncaught Error: URIHandlerRegistry#handleURI asked to handle an invalid URI: atom:%20command%20not%20found
At /private/var/folders/81/5p2s32ks7ws03jgvrq4blynh0000gn/T/AppTranslocation/85C29F40-D723-47DB-93C9-2B0CAD7E727C/d/Atom.app/Contents/Resources/app/src/uri-handler-registry.js:101

Error: URIHandlerRegistry#handleURI asked to handle an invalid URI: atom:%20command%20not%20found
    at URIHandlerRegistry.handleURI (/private/var/folders/81/5p2s32ks7ws03jgvrq4blynh0000gn/T/AppTranslocation/85C29F40-D723-47DB-93C9-2B0CAD7E727C/d/Atom.app/Contents/Resources/app/src/uri-handler-registry.js:101:19)
    at AtomEnvironment.dispatchURIMessage (/private/var/folders/81/5p2s32ks7ws03jgvrq4blynh0000gn/T/AppTranslocation/85C29F40-D723-47DB-93C9-2B0CAD7E727C/d/Atom.app/Contents/Resources/app/src/atom-environment.js:1356:37)
    at EventEmitter.outerCallback (/private/var/folders/81/5p2s32ks7ws03jgvrq4blynh0000gn/T/AppTranslocation/85C29F40-D723-47DB-93C9-2B0CAD7E727C/d/Atom.app/Contents/Resources/app/src/application-delegate.js:353:53)
    at emitTwo (events.js:126:13)
    at EventEmitter.emit (events.js:214:7)

Commands

Non-Core Packages

Thanks for the report!  Can you confirm a few things for us?

what were you doing at the time of the error?
is the error is reproducible?
if reproducible, do you see the error in safe mode (atom --safe)?