nextcloud-client: segfault on startup

Describe the bug
nextcloud-client segfaults on startup for me. I bisected and the commit before 4515dfb6a23192d19b0eedd8564c888ce2474cfc (3.0.3 -> 3.1.3) works, 3.1.3 doesn't.
The logs show:
2021-02-26 15:37:01:043 [ info nextcloud.gui.application ]:	"################## Nextcloud locale:[en_US] ui_lang:[] version:[3.1.3git] os:[NixOS 21.03 (Okapi)]"
2021-02-26 15:37:01:043 [ info nextcloud.gui.application ]:	Using "en_US" translation
2021-02-26 15:37:01:043 [ info nextcloud.gui.socketapi ]:	server started, listening at  "/run/user/1000/Nextcloud/socket"
2021-02-26 15:37:01:043 [ info nextcloud.gui.folder.manager ]:	setting remote poll timer interval to 30000 msec
2021-02-26 15:37:01:081 [ info nextcloud.gui.account.manager ]:	Account for QUrl("https://cloud.eicas.nl") using auth type "webf
low"
2021-02-26 15:37:01:081 [ info nextcloud.sync.credentials.webflow ]:	Get QNAM
2021-02-26 15:37:01:082 [ debug nextcloud.gui.activity ]	[ OCC::User::setNotificationRefreshInterval ]:	Starting Notification refresh timer with  300  sec interval
2021-02-26 15:37:01:093 [ info nextcloud.gui.folder.manager ]:	Setup folders from settings file
2021-02-26 15:37:01:093 [ debug nextcloud.gui.folder ]	[ OCC::Folder::checkLocalPath ]:	Checked local path ok
2021-02-26 15:37:01:093 [ info nextcloud.sync.configfile ]:	Adding user defined ignore list to csync: "/home/aengelen/.config/Nextcloud/sync-exclude.lst"
2021-02-26 15:37:01:095 [ info nextcloud.gui.folder.manager ]:	Adding folder to Folder Map  OCC::Folder(0x55ffdbdad590) "1"
2021-02-26 15:37:01:095 [ debug nextcloud.gui.folderwatcher ]	[ OCC::FolderWatcherPrivate::slotAddFolderRecursive ]:	(+) Watcher: "/home/aengelen/Nextcloud/"
2021-02-26 15:37:01:095 [ debug nextcloud.gui.folderwatcher ]	[ OCC::FolderWatcherPrivate::slotAddFolderRecursive ]:	   `-> and 2 subdirectories
2021-02-26 15:37:01:095 [ info nextcloud.gui.folder.manager ]:	Schedule folder  "1"  to sync!
2021-02-26 15:37:01:095 [ info nextcloud.gui.folder.manager ]:	Folder is not ready to sync, not scheduled!
2021-02-26 15:37:01:095 [ info nextcloud.gui.application ]:	Sync state changed for folder  "https://cloud.eicas.nl/remote.php/webdav/" :  "Not yet Started"
2021-02-26 15:37:01:095 [ info nextcloud.sync.clientproxy ]:	Set proxy configuration to use the preferred system proxy for http tcp connections

the backtrace isn't super informative:
Thread 13 "QQmlThread" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffb67fc640 (LWP 17711)]
0x00007fffef637590 in QQmlType::QQmlType(QQmlType const&) ()
   from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
(gdb) where
#0  0x00007fffef637590 in QQmlType::QQmlType(QQmlType const&) ()
   from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#1  0x00007fffef699ded in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#2  0x00007fffef69bf74 in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#3  0x00007fffef69c319 in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#4  0x00007fffef69c319 in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#5  0x00007fffef69ce25 in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#6  0x00007fffef69869f in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#7  0x00007fffef5efef5 in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#8  0x00007fffef5f65de in ?? () from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5
#9  0x00007fffef5e5535 in QQmlDataBlob::tryDone() ()
   from /nix/store/yk618x65v4652d2mq2ssh5jxy6xc6zrf-qtdeclarative-5.15.2/lib/libQt5Qml.so.5

Possibly relevant: I see this problem both with polybar and when not running a system tray at all. The server I'm connecting to is running nextcloud <IP_ADDRESS>.

Possibly relevant: I see this problem both with polybar and when not running a system tray at all. The server I'm connecting to is running nextcloud <IP_ADDRESS>.

Also happens on latest master (6e3b3fccfcd85816ec3a78ddcd63cd6aea598865)

Oh heck, this update supposed to help with #103680 with similar problems.
Could you try to move cache?
mv .cache/Nextcloud/ .cache/Nextcloud_old

Also, if its important remove your Nextcloud instance URL from you first log.

Could you try to move cache?

After this, nextcloud initially starts, shows a 'Log in' dialog and opens a browser window to grant the client access. After successfully granting access ("you may close this window"), it does seem to briefly connect (I see some notifications pop up), it crashes again - now with a more specific error message though:
$ nextcloud
2021-02-28 10:33:58:715 [ fatal default ]:	ENFORCE: "allow_failure" in file /build/source/src/common/ownsql.cpp, line 265 with message: SQLITE Prepare error
Aborted (core dumped)

trace:
0x00007fffed30733a in raise () from /nix/store/3wa1xwnfv8ada1za1r8m4vmsiz1jifqq-glibc-2.32-35/lib/libc.so.6
(gdb) where
#0  0x00007fffed30733a in raise () from /nix/store/3wa1xwnfv8ada1za1r8m4vmsiz1jifqq-glibc-2.32-35/lib/libc.so.6
#1  0x00007fffed2f1523 in abort () from /nix/store/3wa1xwnfv8ada1za1r8m4vmsiz1jifqq-glibc-2.32-35/lib/libc.so.6
#2  0x00007fffed8b8c2f in QMessageLogger::fatal(char const*, ...) const ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#3  0x00007fffef243f3a in OCC::SqlQuery::prepare(QByteArray const&, bool) [clone .cold] ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#4  0x00007fffef25309d in OCC::SqlQuery::initOrReset(QByteArray const&, OCC::SqlDatabase&) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#5  0x00007fffef261f9d in OCC::SyncJournalDb::setFileRecord(OCC::SyncJournalFileRecord const&) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#6  0x00007fffef26297b in OCC::SyncJournalDb::setFileRecordMetadata(OCC::SyncJournalFileRecord const&) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#7  0x00007ffff7e0b2e3 in OCC::SyncEngine::treewalkFile(csync_file_stat_t*, csync_file_stat_t*, bool) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/libnextcloudsync.so.0
#8  0x00007fffef26e217 in _csync_treewalk_visitor(csync_file_stat_t*, csync_s*, std::function<int (csync_file_stat_t*, csync_file_stat_t*)> const&) () from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#9  0x00007fffef26e5c7 in csync_walk_remote_tree(csync_s*, std::function<int (csync_file_stat_t*, csync_file_stat_t*)> const&) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/nextcloud/libocsync.so.0
#10 0x00007ffff7e10d7d in OCC::SyncEngine::slotDiscoveryJobFinished(int) ()
   from /nix/store/l8s8lcwck0dvacvnjflvins2aa03jicr-nextcloud-client-3.1.3/lib/libnextcloudsync.so.0
#11 0x00007fffedb11d21 in QObject::event(QEvent*) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#12 0x00007fffee66516f in QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Widgets.so.5
#13 0x00007fffedae586a in QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#14 0x00007fffedae8371 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#15 0x00007fffedb3dc33 in ?? () from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#16 0x00007ffff7bf9a9b in g_main_context_dispatch ()
   from /nix/store/5i172qh374nls3canh28ydniqkgliv11-glib-2.66.4/lib/libglib-2.0.so.0
#17 0x00007ffff7bf9d48 in g_main_context_iterate.constprop ()
   from /nix/store/5i172qh374nls3canh28ydniqkgliv11-glib-2.66.4/lib/libglib-2.0.so.0
#18 0x00007ffff7bf9dff in g_main_context_iteration ()
   from /nix/store/5i172qh374nls3canh28ydniqkgliv11-glib-2.66.4/lib/libglib-2.0.so.0
#19 0x00007fffedb3d29f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#20 0x00007fffedae41bb in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#21 0x00007fffedaec7b0 in QCoreApplication::exec() ()
   from /nix/store/g7d3s0avrfqm8k7y1drf918ggizx1y1c-qtbase-5.15.2/lib/libQt5Core.so.5
#22 0x000055555561073b in main ()

ENFORCE: "allow_failure" in file

Just to confirm, you are using Nextcloud to sync to a Nextcloud server?
From a quick search, seems that this bug is caused by mixing OwnCloud and NextCloud clients/servers:

https://github.com/nextcloud/desktop/issues/2536
https://github.com/nextcloud/desktop/issues/1976

Just to confirm, you are using Nextcloud to sync to a Nextcloud server?

Hmm, yes - I didn't install it myself, but I'm pretty sure it's a fairly fresh install of the dockerized Nextcloud <IP_ADDRESS> server.
It seems it was renamed as the 'admin overview' shows 'My-Organization Cloud 20.0.4', but it also says "New version available: Nextcloud 20.0.8".

Just to confirm, you are using Nextcloud to sync to a Nextcloud server?

Hmm, yes - I didn't install it myself, but I'm pretty sure it's a fairly fresh install of the dockerized Nextcloud <IP_ADDRESS> server.
It seems it was renamed as the 'admin overview' shows 'My-Organization Cloud 20.0.4', but it also says "New version available: Nextcloud 20.0.8".

Well, for now I am clueless, looking for this error on the internet was the only possible cause I found. Would you happen to be able to test with another instance of nextcloud?

I have this issue. I'm trying to connect to a Nextcloud 21.0 server.

Recently switched to unstable from 20.09 and now nextcloud also segfaults on me. What info would help this investigation?

Moving the cache directory kicks off the login workflow and after granting access the client does synchronize! However, as soon as I open the "settings", it sometimes crashes (no log of such a case). Also if it does not crash it takes a bit and the following log lines seem to relate:
2021-03-15 09:00:24:511 [ info nextcloud.sync.credentials.keychainchunk ]:	Backend unavailable (yet?) Retrying in a few seconds. "Unknown error"
2021-03-15 09:00:24:987 [ warning default ]:	qrc:/qml/src/gui/tray/UserLine.qml:227:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2021-03-15 09:00:34:390 [ warning nextcloud.sync.credentials.keychainchunk ]:	Unable to read "proxy-password" chunk "0" "Unknown error"
2021-03-15 09:00:34:390 [ warning nextcloud.sync.credentials.keychainchunk ]:	ReadPasswordJob failed with "Unknown error"
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:394 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::bindValue ]:	SQL bind 1 QVariant(int, 3)
2021-03-15 09:00:34:396 [ debug nextcloud.sync.database.sql ]	[ OCC::SqlQuery::exec ]:	SQL exec "SELECT path FROM selectivesync WHERE type=?1"
2021-03-15 09:00:34:396 [ info nextcloud.gui.account.settings ]:	Account<EMAIL_ADDRESS>Client Side Encryption false
2021-03-15 09:00:34:399 [ warning default ]:	QFSFileEngine::open: No file name specified
2021-03-15 09:00:34:399 [ warning qt.svg ]:	Cannot open file '', because: No file name specified
2021-03-15 09:00:34:404 [ warning default ]:	QFSFileEngine::open: No file name specified
2021-03-15 09:00:34:404 [ warning qt.svg ]:	Cannot open file '', because: No file name specified
2021-03-15 09:00:34:408 [ info nextcloud.sync.accessmanager ]:	2 "" "https://nextcloud.ncoding.at/ocs/v1.php/cloud/user?format=json" has X-Request-ID "7e204730-0970-48bb-bea0-b45074fa8197"
2021-03-15 09:00:34:408 [ debug nextcloud.sync.cookiejar ]	[ OCC::CookieJar::cookiesForUrl ]:	QUrl("https://nextcloud.ncoding.at/ocs/v1.php/cloud/user?format=json") requests: (QNetworkCookie("oc_sessionPassphrase=2ecVoeirbuXh0euzNK0GHs3N5ydP6AfDjKCzSBQrxXUpjdhK5zVZk8btf3tjJZd2sUOmrLg4o%2B6ldu%2FQdK7pChwiy2lZZokEFlRx7JBCrY0vw9gdIP6eyfL4Xc3kpODY; secure; HttpOnly; domain=nextcloud.ncoding.at; path=/"), QNetworkCookie("__Host-nc_sameSiteCookielax=true; secure; HttpOnly; expires=Fri, 31-Dec-2100 23:59:59 GMT; domain=nextcloud.ncoding.at; path=/"), QNetworkCookie("__Host-nc_sameSiteCookiestrict=true; secure; HttpOnly; expires=Fri, 31-Dec-2100 23:59:59 GMT; domain=nextcloud.ncoding.at; path=/"), QNetworkCookie("oc9k04drwqbu=7dd92eb333dbb4ce6c3ca213ada5cea7; secure; HttpOnly; domain=nextcloud.ncoding.at; path=/"))
2021-03-15 09:00:34:409 [ info nextcloud.sync.networkjob ]:	OCC::JsonApiJob created for "https://nextcloud.ncoding.at" + "ocs/v1.php/cloud/user" "OCC::UserInfo"
2021-03-15 09:00:34:425 [ warning default ]:	qrc:/qml/src/gui/tray/UserLine.qml:227:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
2021-03-15 09:00:34:544 [ info nextcloud.sync.credentials.webflow ]:	request finished
2021-03-15 09:00:34:544 [ info nextcloud.sync.networkjob.jsonapi ]:	JsonApiJob of QUrl("https://nextcloud.ncoding.at/ocs/v1.php/cloud/user?format=json") FINISHED WITH STATUS "OK"

(You see the 10sec delay there)

After some time (or maybe only when run through systemd?) the client crashed again. Unfortunately I have no time now to debug this further and needed to revert back to 3.0.3 (the one used in release-20.09).

I reverted the package back to an old commit. But I lost the ability to store the credentials in gnome-keyring for some reason.

Honestly I have no clue as to why this erroneous behavior, for now I am about to do a PR to introduce the WrapperArgs for Qt again, which should fix #115383.
Another point is to take a look at the issues of the project on github, this describes a similar behavior: https://github.com/nextcloud/desktop/issues/3000.

Honestly I have no clue as to why this erroneous behavior, for now I am about to do a PR to introduce the WrapperArgs for Qt again, which should fix #115383.
Another point is to take a look at the issues of the project on github, this describes a similar behavior: https://github.com/nextcloud/desktop/issues/3000.

Cool, if you could link the PR in that comment or another or even tag me that'd be great. I'll test it.

Honestly I have no clue as to why this erroneous behavior, for now I am about to do a PR to introduce the WrapperArgs for Qt again, which should fix #115383.
Another point is to take a look at the issues of the project on github, this describes a similar behavior: nextcloud/desktop#3000.

Cool, if you could link the PR in that comment or another or even tag me that'd be great. I'll test it.

Here it is: #116408

@raboof, can you test whether this PR solves your problems?

I:

rm -r ~/.cache/Nextcloud
nixpksg-review pr --post-result 116408
#116408 . It opened the login page in my browser.

I:

rm -r ~/.cache/Nextcloud
nixpksg-review pr --post-result 116408
(this started nextcloud and opened the login page in the browser)
logged in in the browser
waited until the 'countdown' in the nextcloud window went all the way to 0
something I did get a notification for a recent change
but then the process still crashed with:

2021-03-16 14:27:20:144 [ fatal default ]:	ENFORCE: "allow_failure" in file /build/source/src/common/ownsql.cpp, line 265 with message: SQLITE Prepare error
Aborted (core dumped)

When I go to https://host/settings/admin/overview , the version is XXX Cloud 20.0.4 (and lists Nextcloud 20.0.8 as a possible update) - apparently the name has been customized. Perhaps the customization was done in the wrong place and that have thrown off the cli?

Maybe, if I look for it, I always get some reference about using the nextcloud client with owncloud server:

https://github.com/nextcloud/desktop/issues/2536
https://github.com/nextcloud/desktop/issues/2414 (this is more recent)

If you remove your configuration (~/.config/Nextcloud/), do you have the same stack trace?

If you remove your configuration (~/.config/Nextcloud/), do you have the same stack trace?

Hey, that made the problem go away!

I'm happy to close this, but if you want me to run any further tests I'm happy to do that as well.

Hey, Nextcloud desktop client developer here. You get
2021-03-16 14:27:20:144 [ fatal default ]:	ENFORCE: "allow_failure" in file /build/source/src/common/ownsql.cpp, line 265 with message: SQLITE Prepare error

if your sync database does not have the layout the client expects. That might happen if you downgrade. To recover from such a case you need to delete the sync db. That are the files .sync_* in the folder you want to sync. Removing the configuration should be in general not necessary.

Thanks for weighing in! I don't remember doing that, but honestly I don't remember exactly what the sequence of events was... I'll close this issue for now and pay better attention, keeping this in mind, next time!


wallet: erc20 custom token not working

https://user-images.githubusercontent.com/2914674/119046764-c6cdbd00-b9c5-11eb-894c-ca8f04f4dfca.mp4

I think that it is also need to create a test for checking "add custom tokens"


Custom Providers

Hello !
Here is my problem I have a restApi for my server and I would like luckperms can respond to a request via a provider if possible any idea ???

Your options are:

Implement a webserver within a plugin and use the LP API to read data

Information about this is available here https://github.com/lucko/LuckPerms/wiki/Developer-API

Read the database manually from a standalone app

The database schemas should be fairly self explanatory.


Fix: wmt datasets - fix CWMT zh subsets

Fix https://github.com/huggingface/datasets/issues/4575
TODO: run datasets-cli test:

[x] wmt17
[ ] wmt18
[ ] wmt19

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Robot testcase "Check maximum version" failed due to hardcoded max version "0.5.2"

Hi,
The Robot testcase "Testsuites_Management_Test_02"  under test folder which verifying the max version in configuration failed when executing aio-test-trigger due to max version check.
Root cause: the hardcoded value "0.5.2" is used in config file and Robot test for comparison.
Thank you,
Ngoan

Solved by https://github.com/test-fullautomation/robotframework-testsuitesmanagement/pull/89

Some additional hints: The test folder is an example only. I introduced this folder while implementing the test trigger. There is also an atest folder existing. Because I was not familiar with the content and also did not know about the status, I decided to make the test folder my own playground to check, if the test trigger works also for the test suites management.
But this parallel existence of two different test folders cannot not be the final solution.
I urgently suggest to merge the content into one final test folder. But this has to be done by the one who is responsible for the tests.

Hi Holger,
Thank you for your hints!
I am just getting familiar with aio-test-trigger to prepare for CT workflow by executing the default testtrigger_config.json (which point to this test folder).
I agree that the content should be merge for this repo.
I am creating the separated issue for that request.
Thank you,
Ngoan

#90 has been created for merging test folders.

maximum version is adapted; ticket can be closed

solved and already merged with #89


Runtime errors still say "$anonType$n" for anonymous types

Description:
Compilation errors now attempt printing the shape instead of the generated name for an anonymous type.
public function main() {
    record {
        boolean b;
        string s;
    } rec = {b: true, s: "hello world"};

    int i = rec; // compilation error
}

$ ballerina run xyz.bal
Compiling source
        xyz.bal
error: .::xyz.bal:7:13: incompatible types: expected 'int', found 'record {| boolean b; string s; anydata...; |}'

But for runtime errors (i.e., the string representation) we still seem to be printing $anonType$n.
For example, for
public function main() {
    any a = 1;
    var rec = <record { // panic
        boolean b;
        string s;
    }> a;
}

the panic output it
$ ballerina run xyz.bal
Compiling source
        xyz.bal
Running executables

error: {ballerina}TypeCastError message=incompatible types: 'int' cannot be cast to '$anonType$0'
        at xyz:main(xyz.bal:3)

Can we update the runtime string representation to be similar?
Affected Versions:
slp1

Related issue: https://github.com/ballerina-platform/ballerina-lang/issues/24471. We should ideally be able to use a flag to identify an anonymous type.


Feat/backstopjs visual testing

This PR resolves https://github.com/lightning-js/renderer/issues/65 excluding the animation testing aspect. The animation testing will be included in a forthcoming PR.

Getting this error when I try to run:
      COMMAND | Command "test" ended with an error after [0.016s]
      COMMAND | browserType.launch: Executable doesn't exist at /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/pw_run.sh

I tried both installing @playwright/test as a dev dependency and then running pnpm exec playwright install but still got a lot of errors:
❯ pnpm backstop

><EMAIL_ADDRESS>backstop /Users/fweind200/Repo/gh-public/l3-oss/renderer
> backstop test --config='backstop.config.cjs'

BackstopJS v6.2.2
Loading config:  /Users/fweind200/Repo/gh-public/l3-oss/renderer/backstop.config.cjs

COMMAND | Executing core for "test"
createBitmaps | Selected 13 of 13 scenarios.
Creating Browser
      COMMAND | Command "test" ended with an error after [6.202s]
      COMMAND | browserType.launch: Browser closed.
                ==================== Browser output: ====================
                <launching> /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/pw_run.sh --inspector-pipe --headless --no-startup-window --no-sandbox
                <launched> pid=48450
                [pid=48450][err] dyld[48456]: Symbol not found: _ubrk_clone
                [pid=48450][err]   Referenced from: /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/JavaScriptCore.framework/Versions/A/JavaScriptCore
                [pid=48450][err]   Expected in: /usr/lib/libicucore.A.dylib
                [pid=48450][err] /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/pw_run.sh: line 7: 48456 Abort trap: 6           DYLD_FRAMEWORK_PATH="$DYLIB_PATH" DYLD_LIBRARY_PATH="$DYLIB_PATH" "$PLAYWRIGHT" "$@"
                =========================== logs ===========================
                <launching> /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/pw_run.sh --inspector-pipe --headless --no-startup-window --no-sandbox
                <launched> pid=48450
                [pid=48450][err] dyld[48456]: Symbol not found: _ubrk_clone
                [pid=48450][err]   Referenced from: /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/JavaScriptCore.framework/Versions/A/JavaScriptCore
                [pid=48450][err]   Expected in: /usr/lib/libicucore.A.dylib
                [pid=48450][err] /Users/fweind200/Library/Caches/ms-playwright/webkit-1921/pw_run.sh: line 7: 48456 Abort trap: 6           DYLD_FRAMEWORK_PATH="$DYLIB_PATH" DYLD_LIBRARY_PATH="$DYLIB_PATH" "$PLAYWRIGHT" "$@"
                ============================================================
                    at module.exports.createPlaywrightBrowser (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/util/runPlaywright.js:43:42)
                    at /Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/util/createBitmaps.js:136:7
                    at delegateScenarios (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/util/createBitmaps.js:135:12)
                    at module.exports (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/util/createBitmaps.js:192:19)
                    at Object.execute (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/command/test.js:17:14)
                    at Object.execute (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/command/index.js:59:49)
                    at execute (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/command/index.js:109:31)
                    at module.exports (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/core/runner.js:6:10)
                    at main (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/cli/index.js:40:5)
                    at Object.<anonymous> (/Users/fweind200/Repo/gh-public/l3-oss/renderer/node_modules/.pnpm/github.com+erikhaandrikman+backstopjs@3436baf3943476ac99d38b96edfbd98b2685f522_typescript@5.2.2/node_modules/backstopjs/cli/index.js:8:1)

@frank-weindel, the tests are configured to run assuming the examples are on port 5174.
https://github.com/lightning-js/renderer/blob/22eefa92e7bd81f9ddfe9d61db85d998d41a20cb/backstop.config.cjs#L43
You can modify the port by adding the port to the test command. For example:
To create references: pnpm backstop:update 5175.
To run tests: pnpm backstop 5175
I'll make the necessary changes to the README

Can we make the command automatically launch the vite dev server? It should be one command to run the tests.


Design Resources

Hello
On Sat, Oct 17, 2020, 9:02 PM Manoj Vaithilingam<EMAIL_ADDRESS>wrote:

Closed #668
https://github.com/bradtraversy/design-resources-for-developers/issues/668
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bradtraversy/design-resources-for-developers/issues/668#event-3889384535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQXRAVWURYYTTQIRIMUF5HTSLG2IBANCNFSM4SUNYBZQ
.


Ego Car Speeding and Unsafe Lane Change

System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04): Linux Ubuntu 18.04
Apollo installed from (source or binary): Source
Apollo version (3.5, 5.0, 5.5, 6.0): 6.0

Overview
We used the replay_perception.py script to generate obstacles in the map San Mateo, and used sim control to run the ego car in dreamview.
In an attempt to reach the final destination within the duration of the scenario (30 seconds), the ego car increases its speed (52 km/hr) until it exceeds the speed limit imposed by the lane its traveling on (40 km/hr). Moreover, the ego car drives on multiple lane boundaries for more than 5 seconds. This sequence of unexpected behavior might lead to potential accidents if there were other vehicles around.
From the cyber record file, we noticed the unsafe lane change occurred after receiving a new routing response, but the ego car is already traveling on that route, so the lane change does not appear reasonable.
Supporting materials (screenshots, command lines, code/script snippets):
video
record

You could check the max speed configuration.
I thought the maximum speed is capped at 38 km/h by default configuration.

Also, could you record the whole screen of the Dreamview. The planning module appears to be quite laggy. If the lag is significant, then the vehicle won't perform well.

@ntutangyun Thanks for the feedback, I'll double check with the max speed configuration. I updated the video so the delay is included, you can check the new video through the same link. I wonder if this delay is too significant. If so, what level of delay do you find acceptable for the adc to work well? Thanks again!

Hi @EricWu416 thanks for the update. The frequency of the prediction module is about 1Hz. which is too laggy. I think the frequency should be around 10Hz for a normal operation, i.e. the lag of the essential modules should be around 0.100 second.
Also, if you take a closer look, obviously the prediction module goes offline, which brings the planning module off as well, at around 12 seconds in the video.
This is probably why the control module keeps accelerating because it no longer receives any new trajectories from the planning module.
You probably need to investigate why the prediction module hangs in this case.


ImportError

Hi,
I'm following the example to launch the GUI but I'm getting an import error:
from harvesters_gui.frontend.pyqt5 import Harvester
ImportError: cannot import name 'Harvester' from 'harvesters_gui.frontend.pyqt5' (C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\harvesters_gui\frontend\pyqt5.py)

By opening pyqt5.py i can see the Harvester class is defined so python should be able to find, but it looks like it can't. Any thoughts?
Thanks in advance.

The complete error message:
PS C:\Users\jv\source\repos\P1108_Rosalind\Rosalind\Camera> python .\harvesters.py Traceback (most recent call last):   File ".\harvesters.py", line 3, in <module>     from harvesters_gui.frontend.pyqt5 import Harvester   File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\harvesters_gui\frontend\pyqt5.py", line 39, in <module>     from harvesters.core import Harvester as HarvesterCore   File "C:\Users\jv\source\repos\P1108_Rosalind\Rosalind\Camera\harvesters.py", line 3, in <module>     from harvesters_gui.frontend.pyqt5 import Harvester ImportError: cannot import name 'Harvester' from 'harvesters_gui.frontend.pyqt5' (C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\lib\site-packages\harvesters_gui\frontend\pyqt5.py)

@jvieira88 Hi. Thank you for trying out Harvester. (1) Could you show me the content of your harvesters.py, please? By the way, it looks like you are trying to run the script with the interpreter installed in Visual Studio under the program files directory. Have you ever tried to install Python by yourself using an installer that the Python Software Foundation is distributing? I would like to konw what would happen if your script is ran with the interpreter installed by the official installer; I assume the interpreter is installed in your %APPDATA% directory. You can download an installer of Python 3.7 from the following URL:
https://www.python.org/downloads/release/python-377/
Thanks, /Kazunari.

Hi @kazunarikudo ,
Thanks for your comments, I've attached my harvesters.py as requested.
I managed to run it by starting it from the package installation directory.
cd "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\Lib\site-packages\harvesters_gui" python .\frontend\pyqt5.py
I'm ok with this workaround, it works for me.
Thanks,
Joao
harvesters.zip


Stuttering Audio on Chrome/Chromium (HTML5, Threads)

Godot version:
3.2.4 Beta 1
OS/device including version:
Windows 10 - GLES2 - Custom Build with Threads
Issue description:
Stuttering Audio with Godot 3.2.4 Beta 1 (HTML5 Build)
Unfortunately with all tests we have done so far any build exported for Web have its audios heavily stuttering.
Steps to reproduce:
I've made a simple example below for testing purposes, this example has only one audio.
Minimal reproduction project:
Source Code:
AudioTest.zip
Online access:
https://jogosdev.afinando.com.br/AudioTest/

Is it only in 3.2.4 Beta 4 or does it happen with 3.2.3 stable too?

It does happen on 3.2.3 stable too, but only with for users with low performance computers, it is a know open issue.
But with 3.2.4 Beta 1 it is happening even with computer of high performance, we don't have users testing the 3.2.4 Beta 1 yet, this performance test I'm talking about was ran on the computers of our development team. Which are high performance computers.

I can confirm the issue on Linux, with Chrome/Chromium, but it works fine with Firefox (which is I guess why I didn't spot it).
I'll update the issue, and see what I can do.

As a side note, nice issue number. :p

Unfortunately we're still having stuttering problems in low performance devices when using browsers such as G. Chrome, Edge and Opera. Firefox seems to be the only one that works flawlessly.
Here is an updated version as example.
https://jogosdev.afinando.com.br/AudioTest/

Unfortunately we're still having stuttering problems in low performance devices when using browsers such as G. Chrome, Edge and Opera. Firefox seems to be the only one that works flawlessly.
Here is an updated version as example.
https://jogosdev.afinando.com.br/AudioTest/

@probrain-dev Did you export the project with Godot 3.2.4beta4 and with threads enabled?

@probrain-dev Did you export the project with Godot 3.2.4beta4 and with threads enabled?

I Tested with Regular, Threads and GDNative, and the Output Latency with the vaues 20, 50, 60.
I used the last beta version 3.2.4 beta5.

I Tested with Regular, Threads and GDNative, and the Output Latency with the vaues 20, 50, 60.
I used the last beta version 3.2.4 beta5.

@probrain-dev Which exact device models did you encounter issues on?

@probrain-dev Which exact device models did you encounter issues on?

We tested a few different game engines, such as Cocos Creator and Defold, and didn't had audio issues on the low performance devices.
But Godots' had issues such as:
First tested device: MOTO G Play, Android 7.1.1, Google Chrome
With Threads enabled, the game doesn't even load.
I used a regular build and then the game loaded, but the audio was stuttering.
Second tested device: i3 550 2gb ram - Windows 10 (Outdated Computer), Google Chrome
The graphics and audio were stuttering.
But on Firefox everything worked fine.

We tested a few different game engines, such as Cocos Creator and Defold, and didn't had audio issues on the low performance devices.
But Godots' had issues such as:
First tested device: MOTO G Play, Android 7.1.1, Google Chrome
With Threads enabled, the game doesn't even load.
I used a regular build and then the game loaded, but the audio was stuttering.
Second tested device: i3 550 2gb ram - Windows 10 (Outdated Computer), Google Chrome
The graphics and audio were stuttering.
But on Firefox everything worked fine.

We tested at the new version 3.2.4.rc1and the problem still happen.
https://jogosdev.afinando.com.br/AudioTestRegular/
https://jogosdev.afinando.com.br/AudioTestThread/
Devices:
MOTO G Play, Android 7.1.1, Google Chrome
I3 550 2gb ram - Windows 10 (Outdated Computer), Google Chrome

We tested at the new version 3.2.4.rc1and the problem still happen.
https://jogosdev.afinando.com.br/AudioTestRegular/
https://jogosdev.afinando.com.br/AudioTestThread/
Devices:
MOTO G Play, Android 7.1.1, Google Chrome
I3 550 2gb ram - Windows 10 (Outdated Computer), Google Chrome

Have you tried increasing the Project Settings -> Application -> Audio -> output_latency.web to more than 70? This is the lowest I could go without crackling with Chrome on Android.

On a school project I'm working on in 3.2.4 rc1, enabling threads gives me stuttering audio. While a regular build does not.
For software I'm running chrome beta 89.0.4389.40 on PoP os, and my hardware is a laptop with an i7-10710U using an AMD Vega 64 graphics card in an egpu.
Here is a capture of the behavior on my machine.
In Firefox the page just shows a SharedArrayBuffer is not defined error and won't load it.
The project that gives me stuttering audio is available here and the source folder I uploaded to itch is here if that helps, but it has no debug information in it.
Here is a build with debug information, but neither that or the original project will load for me when I try to serve it locally with http-server.
This is the error log I got from Chrome, and Firefox displays the same SharedArrayBuffer is not defined error and won't load the page.
Let me know if you want the source project, or if you need more specific information about my machine.

@Nosliwnayr can you tell me what number gets displayed when you visit https://jsfiddle.net/g5609dk7/ on that machine?
The simple script there should print the AudioContext mix rate, since I have a feeling chrome does not like custom mix rates.

@vandonpeulin, that's perfect, we tested with 100 and 150 of output latency, and with 150 the stuttering was 100% gone. Thank you for the advice.
We will be waiting for the stable version so we can release a few new games using Godot's internal audio engine, so we can be sure the problem with low-performance devices is totally gone.

@Faless on Linux in either Firefox or Chrome I got 44100 on that page.
I rebooted into Windows and in Chrome beta 89.0.4389.40 I get no audio stuttering and the jsfiddle displayed 48000.
Chrome beta 89.0.4389.48 on my Pixel 4 displays the same SharedArrayBuffer is not defined when I try to run the project, and the jsfiddle displays 48000.

I have the same issue on Chrome (88.0.4324.150) the jsfiddle return 44100. Hope this (performance/stuttered) on HTML5 will be improved, that prevent to spread the engine on the web.

@fabriceci please also include OS and machine information (CPU/GPU/memory)

@Faless I restarted my computer and now it's OK on the threaded version, sorry my bad.

A lot of my old HTML5 exports are exhibiting this behaviour now when they didn't used to - perhaps a browser update has caused some instability / incompatibility?

I can confirm the issue. Made a minimal reproduction project with just an AudioStreamPlayer playing a WAV audio. Web Preview | Repo
Also I can reproduce the issue simply by playing the WAV audio file with the official Godot Web Editor (see video).
Tested with Godot 3.3 RC6 + Manjaro Linux + Chrome 89.0.4389.90. No issue with Firefox 87.0.

More HW/SW info:

System:
  Kernel: 5.11.6-1-MANJARO x86_64 bits: 64 Desktop: Cinnamon 4.8.6
  Distro: Manjaro Linux
Machine:
  Type: Desktop System
  Mobo: ASUSTeK model: ROG STRIX B550-F GAMING (WI-FI) v: Rev X.0x
CPU:
  Info: 8-Core model: AMD Ryzen 7 3700X bits: 64 type
Graphics:
  Device-1: NVIDIA TU116 [GeForce GTX 1650 SUPER] driver: nvidia v: 460.56
  Display: x11 server: X.Org 1.20.10 driver: loaded: nvidia resolution:
  1: 1920x1080~60Hz 2: 1600x900~60Hz
  OpenGL: renderer: GeForce GTX 1650 SUPER/PCIe/SSE2 v: 4.6.0 NVIDIA 460.56
Audio:
  Device-1: NVIDIA TU116 High Definition Audio driver: snd_hda_intel
  Device-2: AMD Starship/Matisse HD Audio driver: snd_hda_intel
  Device-3: RODE Microphones RODE NT-USB type: USB
  driver: hid-generic,snd-usb-audio,usbhid
  Sound Server-1: ALSA v: k5.11.6-1-MANJARO running: yes
  Sound Server-2: PulseAudio v: 14.2 running: yes

Hi,
Same issue for me when i export one my game as a HTML5 build. ( Video example : https://youtu.be/PMM2GxjyJqw )

@davcri Can you reproduce this with an HTML5 export that has threads enabled in the export preset? Make sure to host the resulting project on a server that has cross-origin isolation headers enabled so that SharedArrayBuffer is available. (The project must also be accessed via either localhost or an HTTPS host.)

@Calinou thanks for the quick answer. The reproduction project that I posted before it's already using the thread-enabled HTML5 export.
Some findings:

Issue it's still there with older Chrome version (80, 86)
Video | Issue may be related to a specific combination of Chrome + motherboard audio card + audio driver: audio it's pretty bad on the motherboard audio (Starship/Matisse HD controller which it's my daily output audio device), but it's almost okay with the headphones output (RODE-NT USB mic). However it still has some audio crackling.
Video | Single-thread export plays audio better than multi-thread export (which it's totally unexpected)
:fox_face: Just to clarify: audio on Firefox it's almost perfect (with every combination of export and audio device)

Might be an issue with sampling rate, sounds related to #46595.

Might be an issue with sampling rate, sounds related to #46595.

That's actually quite interesting, I've been suspecting issues with mismatching sample rates between godot and device for a while. It seems that most of the chrome devices on HTML5 that had problem was 48000 Hz (though changing it in Godot project settings to match it doesn't seem to consistently solve it), and on FF, I've been experiencing broken Mic support when sample rate does not match the default one (even if the chosen one is advertised as supported).
I wonder if we should default to "let device choose" since we seem to do resampling in real time anyway, and not during the import phase.

It affected me too. I had a Godot HTML build that was playing music fine until early March 2021, then suddenly started stuttering and getting delayed badly in Chrome and Edge, but not Firefox.
I don't know what's causing it, but I did find a workaround and posted a description of how I routed audio through howler.js in the spirit of FernandoValcazara's approach which completely eliminated the audio stuttering issue. The description of how I did it is at
https://3p0ch.newgrounds.com/news/post/1148893

It affected me too. I had a Godot HTML build that was playing music fine until early March 2021, then suddenly started stuttering and getting delayed badly in Chrome and Edge, but not Firefox.

So it seems a browser regression... can try which older version is the first to exhibit the bad behaviour?
That way we can report it to the chrome bug tracker: https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink>WebAudio

Could also be an OS/drivers update that causes it, since @davcri could reproduce the regression on older Chrome too: https://github.com/godotengine/godot/issues/43210#issuecomment-808764511

Yeah, I'm quite convinced we are now dealing with 2 separate issues, a chrome regression, and the good old issues on some specific hardware (e.g.: Use of AudioWorklets has glitches on some Windows systems )

So, I can't open an upstream issue until someone that was not experiencing the issue before but is experiencing it now makes a proper report with OS, hardware specs, first bogus version, last bogus version.
Any generic "Was working, now since some days it doesn't", is just noise at this point.

So, I can't open an upstream issue until someone that was not experiencing the issue before but is experiencing it now makes a proper report with OS, hardware specs, first bogus version, last bogus version.
Any generic "Was working, now since some days it doesn't", is just noise at this point.

I don't know how to rollback chromium and/or other updates to pinpoint the culprit. But if anyone does know how to, I posted a build that's completely empty except for a single player node playing a loop which reproduces the problem for me and could allow people to pinpoint it if they are also getting choppiness at https://www.newgrounds.com/portal/view/project/1594770 which might also help if more people can test it out on different systems. I have
Windows 10 Home, version 20H2, OS build 19042.867
Processor: AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx, 2.10 GHz
Installed RAM: 12.0 GB (9.92 GB usable)
First and last bogus version: TBD if there's a straightforward way to determine it

if they are also getting choppiness at https://www.newgrounds.com/portal/view/project/1594770 which might also help if more people can test it out on different systems.

Tested on Linux (Mageia 9) and I can reproduce choppy audio with Chrome 89.0.4389.90.
I tried to install older versions of Chromium using https://vikyd.github.io/download-chromium-history-version/#/ but at least the version I tried has its audio code crashing so it doesn't help :)

So I've done some testing on Windows 10 with Chrome 89.0.4389.90 on another laptop, same issue. I tried changing the audio driver sample rate for the Realtek card, but that doesn't seem to impact it (both 44100/48000 Hz and 16/24 Bits).
On Windows I managed to use the Chromium builds from https://vikyd.github.io/download-chromium-history-version/#/ but I can't seem to reproduce the issue with Chromium, only with Chrome :(
I tested the following builds:

Chromium 88.0.4324.215 (latest build in previous stable): works
Chromium 89.0.4326.0 (first build in 89.0 branch): works
Chromium 89.0.4380.6: works
Chromium 89.0.4386.4 (latest build in 89.0 branch at https://vikyd.github.io/download-chromium-history-version/#/): works
Chromium 90.0.4391.0 (first build in 90.0 branch): works
Chromium 91.0.4462.1 (dev version): works
Chrome 89.0.4389.90 (current stable): broken

Fun if the regression is proprietary-only :@

@Faless Relevant bug reports?
https://bugs.chromium.org/p/chromium/issues/detail?id=1188901
https://bugs.chromium.org/p/chromium/issues/detail?id=1187016

Yeah, I'm quite convinced we are now dealing with 2 separate issues, a chrome regression, and the good old issues on some specific hardware (e.g.: Use of AudioWorklets has glitches on some Windows systems )

Fabio is right, @davcri's issue with threaded builds is different from @3p0ch-NG's report about a Chrome 89 regression.
I've opened #47453 to keep track of the Chrome 89 regression with ScriptProcessorNode.
@davcri I suggest opening a new issue for your audio stuttering problem, which might be a manifestation of https://bugs.chromium.org/p/chromium/issues/detail?id=1188901 as Fabio pointed it out (AudioWorklet and not ScriptProcessorNode, and hardware-dependent). For the reference, I couldn't reproduce the issue with your hosted build on Chrome Stable or Canary on either Linux or Windows.
And by now this issue has been used to discussed quite a few unrelated problems so it's probably best if we close it, and focus on #47453 and a new issue for users hit by https://bugs.chromium.org/p/chromium/issues/detail?id=1188901.


GLSL: Add option to force flattening IO blocks.

It is not always desirable to use actual blocks.
A prime example in the case where EXT_shader_io_blocks is not supported
on the target implementation.
Fix #1427.

Benign failure on AppVeyor, consider it passing.


Issues with data in the college-majors repo

Hi all,
I've been working with the data in the college majors repo over the weekend: https://github.com/fivethirtyeight/data/tree/master/college-majors
I think something went wrong during the data processing, since if you compare the gender-related data in recent-grads.csv and women-stem.csv, they don't match up. recent-grads.csv also indicates that 56% of all computer science majors are female, which is way off.
I'm looking into the data right now to try to find out what happened, but I'd appreciate a second look at this data set to make sure everything is in order.
Cheers,
Randy

Hello Randy,
Thanks for correcting the data. I've checked with Ben and accepted the changes.
Best,
Dhrumil


Volume OSD keeps on showing whenever there is media change or sound plays from different tabs in the same browser

It's kind of annoying when the osd shows every time im changing videos on yt or reels on insta and it also shows up when kitty terminal makes a sound while using the arrow keys to go through the previous commands used
Hope you can fix this as i have completely switched to using the osd(s) now instead of using notify-send scripts

Have you git pulled recently? I'm trying to replicate this issue but having no luck.

Could you please git pull and verify the fix?

Works perfectly now thanks man 👍


don't enable autoconfigure if properties are not set

@yungez @xscript @aovechki

@ZhijunZhao,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #157 into master will decrease coverage by 0.36%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   71.95%   71.59%   -0.37%
==========================================
  Files          58       58
  Lines        1216     1218       +2
  Branches      117      118       +1
==========================================
- Hits          875      872       -3
- Misses        274      278       +4
- Partials       67       68       +1

Impacted Files
Coverage Δ

.../aad/AADAuthenticationFilterAutoConfiguration.java
100% <ø> (ø)
:arrow_up:

...figure/documentdb/DocumentDBAutoConfiguration.java
73.07% <ø> (-7.7%)
:arrow_down:

...utoconfigure/storage/StorageAutoConfiguration.java
100% <ø> (ø)
:arrow_up:

...figure/servicebus/ServiceBusAutoConfiguration.java
70% <ø> (ø)
:arrow_up:

.../mediaservices/MediaServicesAutoConfiguration.java
90.47% <ø> (ø)
:arrow_up:

...vault/spring/boot/KeyVaultPropertyInitializer.java
46.42% <0%> (-3.58%)
:arrow_down:

...autoconfigure/documentdb/DocumentDBProperties.java
82.35% <0%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0509d9...f5c654e. Read the comment docs.


Get rid of the file gcc_path?

Perhaps we could check if libgccjit.so is on the system and alert the user if it cannot be found.

We'll have to study the case of having multiple libgccjit, each one targeting a different architecture.

This file doesn't exist anymore since we now have the config.toml file. Closing.


Visualizations Feedback!

Below are some thoughts about the visualizations in this report and some suggestions for improvement, and notes when things are done well. You should implement these in milestone4

[x] It would really have helped if you had a caption and a figure/table number for each plot. That way you can easily reference it in your text, and it's easier for readers to find

[x] Great job formatting all y-axis labels with thousands separator

[x] You should rotate all x-axis labels so they're oriented correctly: alt.X('Var:N', axis=alt.Axis(labelAngle=0))

[x] There's a spelling mistake in Medical expenses vs BMI (underweight)

[x] You sort x-axis categorical labels in increasing order (obese should be at the end)

[x] Legend order of Smokers vs. Non Smokers should be switched so first is orange, then blue

[x] Not sure if stacked bar chart is appropriate for the Male & female expenses over BMI. Consider a grouped bar chart, you should decide if horizontal or vertical is more appropriate for your case

[x] Consider setting diagonal values on your correlation map to be 0 or nan; those are the only ones that stand out.

[x] Ideally, you only want to show half the correlation map as the other half is redundant (see example here) - let me know if you figure out how to do this in Altair

[ ] You've got overplotting happening in your goodness of fit plots - is jttering appropriate here?

[ ] Overall excellent work with your labels, titles, and plot choices! For every plot I was immediately able to understand what you were trying to convey.

Thank you very much for you feedbacks!

Thanks, Firas for such detailed visualization feedback.

For the overplotting in the goodness of fit, we feel jittering is not appropriate. This is because jittering needs at least one categoric variable (Jittering is particularly useful for small datasets with at least one discrete position. https://ggplot2.tidyverse.org/reference/position_jitter.html).
We tried to address this issue by lowering the opacity.

Thanks @sreejithmunthikodu - did you figure out what was causing your plots to look like they were discrete? I saw bands when I was talking to @sirine-chahma about it yesterday. Could you just paste the final figure here so I can have a quick look?

Hi @firasm, we used a DecisionTreeRegressor with a max_depth of 4. So I guess there are 16 leaf nodes. So any sample would end up in one of these 16 leaf nodes and the final output would be the mean value from all the samples in these leaf nodes. So even though our response is continuous, our models is capable of predicting only 16 closest values. Now I feel jitter may be used here.
Do you recommend it?
Thanks

Can you post the jitter'd and non-jittered plot here?

Hi @firasm,
Below is what I managed to get so far.

The x variable is now treated as categorical. But I lost the spacing between the values now. All are equally spaced. I tried to change the type to "Q" but still the same result.
I am sure there has to be a way to do it properly. I am searching for it online.
Below is my original plot.

Here is the code I used
`alt.Chart(res).mark_circle(size=60, color="green", opacity=0.4).encode(
alt.X("jitter:Q",
title = None,
axis=alt.Axis(values=[0], ticks=True, grid=False, labels=False),
scale=alt.Scale()),
alt.Y('y_actual', title = "Actual Medical Expense ($)"),
alt.Column(
'y_predicted:Q',
title = "Predicted Medical Expense ($)",
     header=alt.Header(
         labelAngle=-90,
         titleOrient='top',
         labelOrient='bottom',
         labelAlign='right',
         labelPadding=0,
         labelFontSize=20,
         title = "Predicted Vs Actual",
         titleFontSize=20,)
),
).transform_calculate(
jitter='sqrt(-2*log(random()))*cos(2*PI*random())/1000'
).configure_facet(
spacing=0
).configure_view(
stroke=None
).properties(
width = 40,
height = 400
).configure_axis(
labelFontSize = 20,
titleFontSize = 20
).configure_title(
fontSize = 20
).configure_legend(
titleFontSize = 20, labelFontSize = 20)`

`alt.Chart(res).mark_circle(size=60, color="green", opacity=0.4).encode(
alt.X("jitter:Q",
title = None,
axis=alt.Axis(values=[0], ticks=True, grid=False, labels=False),
scale=alt.Scale()),
alt.Y('y_actual', title = "Actual Medical Expense ($)"),
alt.Column(
'y_predicted:Q',
title = "Predicted Medical Expense ($)",
     header=alt.Header(
         labelAngle=-90,
         titleOrient='top',
         labelOrient='bottom',
         labelAlign='right',
         labelPadding=0,
         labelFontSize=20,
         title = "Predicted Vs Actual",
         titleFontSize=20,)
),
).transform_calculate(
jitter='sqrt(-2*log(random()))*cos(2*PI*random())/1000'
).configure_facet(
spacing=0
).configure_view(
stroke=None
).properties(
width = 40,
height = 400
).configure_axis(
labelFontSize = 20,
titleFontSize = 20
).configure_title(
fontSize = 20
).configure_legend(
titleFontSize = 20, labelFontSize = 20)`

alt.Chart(res).mark_circle(size=60, color="green", opacity=0.4).encode(     alt.X("jitter:Q",            title = None,           axis=alt.Axis(values=[0], ticks=True, grid=False, labels=False),           scale=alt.Scale()),              alt.Y('y_actual', title = "Actual Medical Expense ($)"),     alt.Column(         'y_predicted:Q',          title = "Predicted Medical Expense ($)",          header=alt.Header(              labelAngle=-90,              titleOrient='top',              labelOrient='bottom',              labelAlign='right',              labelPadding=0,              labelFontSize=20,              title = "Predicted Vs Actual",              titleFontSize=20,)     ),     ).transform_calculate(        jitter='sqrt(-2*log(random()))*cos(2*PI*random())/1000'     ).configure_facet(     spacing=0     ).configure_view(     stroke=None     ).properties(         width = 40,     height = 400     ).configure_axis(     labelFontSize = 20,     titleFontSize = 20     ).configure_title(     fontSize = 20     ).configure_legend(     titleFontSize = 20, labelFontSize = 20)

Here is the code I used.
alt.Chart(res).mark_circle(size=60, color="green", opacity=0.4).encode(     alt.X("jitter:Q",            title = None,           axis=alt.Axis(values=[0], ticks=True, grid=False, labels=False),           scale=alt.Scale()),              alt.Y('y_actual', title = "Actual Medical Expense ($)"),     alt.Column(         'y_predicted:Q',          title = "Predicted Medical Expense ($)",          header=alt.Header(              labelAngle=-90,              titleOrient='top',              labelOrient='bottom',              labelAlign='right',              labelPadding=0,              labelFontSize=20,              title = "Predicted Vs Actual",              titleFontSize=20,)     ),     ).transform_calculate(        jitter='sqrt(-2*log(random()))*cos(2*PI*random())/1000'     ).configure_facet(     spacing=0     ).configure_view(     stroke=None     ).properties(         width = 40,     height = 400     ).configure_axis(     labelFontSize = 20,     titleFontSize = 20     ).configure_title(     fontSize = 20     ).configure_legend(     titleFontSize = 20, labelFontSize = 20)

We addressed all the issues except one mentioned here. We could not resolve the overplotting issue in the goodness of fit plots with jittering. Because of our decision tree model, the predicted values behave like a categorical variable. However, when jittering was used, the predicted values takes equal intervals in the x-axis.
Thanks, Firas for your valuable feedback. It really helped us to improve a lot.

Sounds great, thanks for considering!

Sorry I didn't get a chance to look at this in time


[SPARK-37984][SHUFFLE] Avoid calculating all outstanding requests to improve performance.

What changes were proposed in this pull request?
Avoid calculating all outstanding requests to improve performance.
Why are the changes needed?
Follow the comment (https://github.com/apache/spark/pull/34711#pullrequestreview-835520984) ,  we can implement a "has outstanding requests" method in the response handler that doesn't even need to get a count，let's do this with PR.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist unittests.

Friendly cc @srowen @dongjoon-hyun

Does this change performance much? it's still getting the size of every collection. isEmpty might make it a little more optimal. OK either way just might not make any difference

Does this change performance much? it's still getting the size of every collection. isEmpty might make it a little more optimal. OK either way just might not make any difference

Done.

Can one of the admins verify this patch?

Are there are any other places where numOutstandingRequests is compared to 0?

No, I checked again and confirmed that the PR included all of them. @srowen

Merged to master

Thanks @srowen


[Polish] Fix typo

Coverage remained the same at 87.299% when pulling 65edf878fb8214279b8aacc9a3adf9a64f835cac on Oliverwqcwrw:master-fix-typo-12 into 8c5474b5dde0ca3aea1e4fdae7603dde81481912 on mybatis:master.


Add functionality to the parts folder in guild-mod-manager

The old way it was built, the general commands for the console were all defined in the game data. They should instead be moved over into the mod manager itself as they are not game specific

Added in #22


Update remove task to also delete the job.

Also made the upsert job log error if it failed to create the job

As discussed offline this won't work due to running in the target database.


IOptionsSnapshot cannot be used from Singletons

IOptionsSnapshot<T> cannot be used from singletons.
Issue is present in the ApiKey authentication service. I workarounded it by registering the auth service as scoped.

Ah good catch. Let's make it transient since it doesn't actually need a scope.
Fix here: https://github.com/loic-sharma/BaGet/blob/1079782ff2d9e18b8ac573ca9b4f8fef48f15e7a/src/BaGet/Extensions/ServiceCollectionExtensions.cs#L260

Don't you want to use an OptionsMonitor instead?. It gives you updates, can bed used in Singletons and so on..

Well. I'd keep all services at the highest scope possible, so Singleton preferably, then Scoped and finally Transient. This is to create as few instances of a service as possible. So if a service has nothing with a specific request to do, and has no unmanaged resources (ie. not a DB), I'd make it singleton.
And for Singletons, IOptionsMonitor is a good fit. Its Value should always be the "current" value, so you could just use it as is. Alternatively, there is an event that you can listen to that fires when the Value changes.
I also assume, for compatibility, that when the Value changes, its an entirely new object. So it should be possible to, if you need to read two properties off of a Configuration object, to copy the reference of the Value object, and then use that. It shouldn't change once it's been copied out.

Well. I'd keep all services at the highest scope possible, so Singleton preferably, then Scoped and finally Transient. This is to create as few instances of a service as possible. So if a service has nothing with a specific request to do, and has no unmanaged resources (ie. not a DB), I'd make it singleton.

The NuGet team does the exact opposite. We always use Transient, unless something has to be Scoped/Transient. This reduces the likelihood of errors at the cost of a minor performance hit. This seems to be a worthwhile trade-off: we've had issues like singletons depending on scoped objects before, but we've never had a performance issues due to overzealous dependency injection configurations.
Thanks for the info on IOptionsMonitor. The documentation on that is quite sparse 😢

I find that odd thinking. But then, it's up to a measurement to find the impact.
For now, this is a bug that prevents uploading of packages. :)


Support exported pages that end with .html

I have an application where the nextjs application I use is an exported one that outputs .html files. Following the advice on here
I have created a file that utilises the package and ran the file once the nextjs's next export command has been ran. Unfortunately, the sitemap does not generate the files with the .html extension on. This means that the sitemap is invalid since this application is being served statically
Config File
const sitemap = require('nextjs-sitemap-generator');
const fs = require('fs');
const path = require('path');

const BUILD_ID = fs.readFileSync(".next/BUILD_ID").toString();

sitemap({
  baseUrl: "https://www.example.co.uk",
  pagesDirectory: path.resolve(__dirname, '../out/'),
  targetDirectory:path.resolve(__dirname, '../out/'),
  ignoredExtensions: ["js", "map", "json", "xml", "png", "jpg", "jpeg", "svg"],
  ignoredPaths: ["[fallback]"]
});

Out Directory

posts/example-one.html
posts/example-two.html
index.html

sitemap.xml

posts/example-one
posts/example-two
index

The sitemap should add .html if the pages are exported and are being served statically

Added in #78

Added in #78


make quantization work with meta

... also fix things found by testing
Highlight: This works with a model that has parameters on meta:
    jm = thunder.jit(
        m,
        executors=(bitsandbytes_executor,),
        transforms=[
            BitsAndBytesLinearQuant4bit(),
            MaterializationTransform("cuda", init=init_from_sd),
        ],
    )

This is based on #867 and currently labeled as merging into that, so I'm labeling as draft.
I will rebase on main after #867 is merged.


Add UART3 pin header

To give some flexibility like flashing via UART and maybe serial display or whatever.
Discussed here: https://openinverter.org/forum/viewtopic.php?p=76455#p76455

Done with https://github.com/uhi22/foccci/commit/413c8ef2a10fd3ce8bdf70788c21fc362a79e89f


DBeaver can't connect to the database.

Description
Hello, I need to access a PostgreSQL database to make small changes to some records, and up until now, I had no issues with DBeaver. However, I had to reinstall it after formatting my Windows, and since then, I can no longer connect to the database.
When attempting to connect, the two errors in the screenshots below appear one after the other.
I have tried adding the JDBC Driver to the libraries section, but there has been no improvement.
Can someone help me? I have been trying to resolve this for hours and have not been successful so far.

DBeaver Version
23.3.0
Operating System
Windows 10 Pro
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

As I see from the screen you downloaded and added the driver file manually. Then you need to remove blue items from the list of libraries and try connecting again.

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.


Handle video passwords

Reference issue #1
In this very simple way it is possible to handle videos with no password along with videos that are password protected.
Anyway, it is still not possible to download two password protected video with different passwords in the same session.

Nice one! SImple and easy
I can't see an effective way to support multiple password. One solution could be to ask for each video if it needs a password, but this would make multiple downloads feature ineffective


Use const whenever possible

There are still various places in the source code where let is used to declare an identifier, where const is more appropriate.
Also, find a way to enforce this via static analysis test.

Good news: we can rely on TSLint's prefer-const rule for the check.


SDXL not working

This looks like a really cool extension- thanks! Works fine for SD1.5, but I'm trying to run it with an SDXL model and I get this error:
*** Error loading script: main.py
    Traceback (most recent call last):
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/scripts.py", line 319, in load_scripts
        script_module = script_loading.load_module(scriptfile.path)
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/script_loading.py", line 10, in load_module
        module_spec.loader.exec_module(module)
      File "<frozen importlib._bootstrap_external>", line 883, in exec_module
      File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/scripts/main.py", line 15, in <module>
        from lib.modules.token_mixer import TokenMixer
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/modules/token_mixer.py", line 15, in <module>
        from lib.data import dataStorage
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/data.py", line 768, in <module>
        dataStorage = Data() #Create data
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/data.py", line 748, in __init__
        Data.tools = Tools()
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/toolbox/tools.py", line 129, in __init__
        self.tokenizer , self.internal_embs , self.loaded_embs = self.get()
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/toolbox/tools.py", line 59, in get
        elif self.is_sdxl : internal_emb_dir = embedder.roberta.embeddings # SDXL :Check if this works
      File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1614, in __getattr__
        raise AttributeError("'{}' object has no attribute '{}'".format(
    AttributeError: 'Module' object has no attribute 'roberta'

It looks like it's line 59 of tools.py "elif self.is_sdxl : internal_emb_dir = embedder.roberta.embeddings" that's causing the issue. I poked around in sd_models_xl.py and sd_hijack.py and logged the hijack def since that's where SDXL gets its cond_stage_model from - looks like it's using the FrozenCLIPEmbedderForSDXLWithCustomWords section (line 194) and not the FrozenXLMREmbedderWithCustomWords (line 214). I'm happy to help debug but I'm not sure quite where to go from here.
EDIT: This is using Automatic1111's UI.

Hey thanks for the help! I haven't gotten to debugging with SDXL yet.
I'm still waiting for the major A1111 update that will solve the current VRAM issues when running SDXL. Last time I tried (about 2 weeks ago) I couldn't even get SDXL to run on my device.
I decided to leave it at that and make a new attempt once the ongoing compatibility issues between A1111 and SDXL had "settled down" so-to-speak.
As a consequence, the code written on line 59 and 62 are pure guesswork on my end. You can see the comment in the code below.

If you can get line 59 and 62 to work, the TokenMixer should be good-to-go with SDXL.  There shouldn't be any other compatibility issues other than what you find in "Tools.py" .
(can't make any promises for "cross_attention_mixer.py"  though as I am not the author of that code, but you can disable that module in the main.py folder should it prove to be incompatible with SDXL )
That is all the help I can provide at this moment.
Once I get SDXL to work on my own device I can debug this issue, but I can't promise the update will come in a timely manner as I am not particularly incentivized to use SDXL as long as the VRAM usage is an issue.

Fair enough! I'll see if I can get it working and if I do, I'll create a PR.

I'm not creating a PR because I haven't managed to make anything work properly yet. I got it to load by modifying the function like so:
#Fetch the internal_embedding directory
        if self.is_sdxl :
          embedder = model.cond_stage_model
        else :
          embedder = model.cond_stage_model.wrapped

        internal_emb_dir = None
        if self.is_sd1: internal_emb_dir = embedder.transformer.text_model.embeddings
        elif self.is_sdxl :
          cli_embedder = embedder.embedders[0]  # Accessing the first embedder

          if isinstance(cli_embedder, sd_hijack_clip.FrozenCLIPEmbedderForSDXLWithCustomWords):
              internal_emb_dir = cli_embedder.wrapped.transformer.text_model.embeddings # SDXL :Check if this works
        elif self.is_sd2 : internal_emb_dir = embedder.model

        internal_embs = internal_emb_dir.token_embedding.wrapped.weight # SDXL : See comment above

        ########
        if self.is_sd2 : #Fetch the tokenizer
          from modules.sd_hijack_open_clip import tokenizer as open_clip_tokenizer
          tokenizer = open_clip_tokenizer
        elif self.is_sdxl :
          cli_embedder = embedder.embedders[0]  # Accessing the first embedder

          if isinstance(cli_embedder, sd_hijack_clip.FrozenCLIPEmbedderForSDXLWithCustomWords):
              tokenizer = cli_embedder.wrapped.tokenizer # SDXL :Check if this works
        else : tokenizer = embedder.tokenizer
        #########

No idea if this is correct, but it does halfway function. However, it creates embeddings with a SD1.5 shape (768 size tensor vs the expected 2048 size tensor). They actually do work with SD1.5 models, producing distorted but still recognizable outputs.
If anyone's interested, here are my conclusions after messing about with this for a bit.

SDXL embeddings have a very different architecture to SD1.x or SD2.x embeddings. See this code from the updated modules/textual_inversion.py on the dev branch:

elif type(data) == dict and 'clip_g' in data and 'clip_l' in data:  # SDXL embedding
          vec = {k: v.detach().to(devices.device, dtype=torch.float32) for k, v in data.items()}
          shape = data['clip_g'].shape[-1] + data['clip_l'].shape[-1]
          vectors = data['clip_g'].shape[0]

My code almost works. It outputs an embedding that is interpreted by the textual_inversion code as a SDXL embedding, having the two clip models in the data. However, the shape of the tensor is off. I'm not sure if that means it's really close to being correct or if it's going to require an entirely different method.

I'll keep trying and see if I can get anything working.

Thank you for posting this. Very useful information.

@Nekos4Lyfe I'm afraid I don't see a size parameter in tools.py, unless I'm missing something.

Ah, sorry. You are correct. It's in the Data.py class. The vector size is initialized on line 783 in Data.py
I tokenize a the word "test" on line 782 and then use the dimensions of that vector to find the embedding size of the given model.
In the rest of the code (after initialization) you get vector size in each module by calling "self.data.vector.size"

Thanks! Didn't manage to make a breakthrough last night, but I got a little closer- I concatenated the tensors for both clip models, creating one tensor with 2048 dimensions, which passed the test for textual_inversion but fails on EmbeddingsWithFixes in sd_hijack. I ran a working SDXL embedding through and it turns out it isn't passing one 2048 tensors, it's sequentially passing two tensors of size 768 and then 1280. That's the size of the two embedders included in the model.
So if I'm getting this right, you have to encode the embedding with both embedders in such a way that it registers as one tensor of size 2048 for the purposes of textual_inversion and actually runs two embeddings through EmbeddingsWithFixes. Which seems... hard. Maybe I'm confused on something here though.

I'm seeing this in a correctly-formatted embedding file I downloaded from CivitAI:
{"clip_g":{"dtype":"F16","shape":[8,1280],"data_offsets":[0,20480]},"clip_l":{"dtype":"F16","shape":[8,768],"data_offsets":[20480,32768]}}

When I try to run the embedding through the Embedding Inspector tab, I get this error:
torch.Size([49408, 2048])
Traceback (most recent call last):
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/routes.py", line 422, in run_predict
    output = await app.get_blocks().process_api(
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1323, in process_api
    result = await self.call_function(
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/gradio/blocks.py", line 1051, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/modules/embedding_inspector.py", line 119, in inspect
    emb_name, emb_id, emb_vec, loaded_emb = self.data.get_embedding_info(text)
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/extensions/TokenMixer/lib/data.py", line 603, in get_embedding_info
    emb_id = '['+ loaded_emb.checksum()+']' # emb_id is string for loaded embeddings
  File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/textual_inversion/textual_inversion.py", line 84, in checksum
    self.cached_checksum = f'{const_hash(self.vec.reshape(-1) * 100) & 0xffff:04x}'
AttributeError: 'dict' object has no attribute 'reshape'

I'm guessing (my knowledge of this is somewhat limited) SDXL embeddings are a dict containing two tensors, one for the clip_l encoder and one for the clip_g encoder. In order to save an embedding, you'd need to run the process twice using the two encoders and then save the dict as a .pt file.
I'm not sure I'm up to the task of actually building this, considering you'd probably need to completely refactor the code for the whole plugin, so I might just leave it here. Hopefully it's useful if/when you build out the SDXL code.

Yes, I'd say you have done plenty. Great work! I'll move SDXL compatibility up on the agenda, but it will likely be a month or so until it is implemented.   Thanks again for all the help.

No worries! I had fun tinkering :) I'll keep an eye out for that!

Hi Man! TokenMixer is now SDXL compatible! Still lot of stuff left so I will keep this page open, but I figured I send a message to let you know

Oh awesome! Going to check it out when I get a chance :)

@Nekos4Lyfe I think it's probably because I'm on Mac, but something about the embedding I just generated ("dog horse". saved with default settings as dghs001) causes issues at generation. It throws this even if I upcast the cross-attention layer to fp32. I didn't try no-half, because it slows generation to a crawl.
7%|██▉                                         | 1/15 [00:06<01:34,  6.75s/it]
*** Error completing request                             | 0/15 [00:00<?, ?it/s]
*** Arguments: ('task(ospr2hjukd0x7z4)', 'photo of dghs001', '', [], 15, 'DPM++ 2M Karras', 1, 1, 7, 768, 512, False, 0.7, 2, 'Latent', 0, 0, 0, 'Use same checkpoint', 'Use same sampler', '', '', [], <gradio.routes.Request object at 0x2ac49f580>, 0, False, '', 0.8, -1, False, -1, 0, 0, 0, False, False, 'positive', 'comma', 0, False, False, '', 1, '', [], 0, '', [], 0, '', [], True, False, False, False, 0, False) {}
Traceback (most recent call last):
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/call_queue.py", line 57, in f
res = list(func(*args, **kwargs))
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/call_queue.py", line 36, in f
res = func(*args, **kwargs)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/txt2img.py", line 55, in txt2img
processed = processing.process_images(p)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/processing.py", line 732, in process_images
res = process_images_inner(p)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/processing.py", line 867, in process_images_inner
samples_ddim = p.sample(conditioning=p.c, unconditional_conditioning=p.uc, seeds=p.seeds, subseeds=p.subseeds, subseed_strength=p.subseed_strength, prompts=p.prompts)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/processing.py", line 1140, in sample
samples = self.sampler.sample(self, x, conditioning, unconditional_conditioning, image_conditioning=self.txt2img_image_conditioning(x))
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 235, in sample
samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args=self.sampler_extra_args, disable=False, callback=self.callback_state, **extra_params_kwargs))
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/sd_samplers_common.py", line 261, in launch_sampling
return func()
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 235, in
samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args=self.sampler_extra_args, disable=False, callback=self.callback_state, **extra_params_kwargs))
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/repositories/k-diffusion/k_diffusion/sampling.py", line 594, in sample_dpmpp_2m
denoised = model(x, sigmas[i] * s_in, **extra_args)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/sd_samplers_cfg_denoiser.py", line 201, in forward
devices.test_for_nans(x_out, "unet")
File "/Users/jackwooldridge/StableDiffusion/stable-diffusion-webui/modules/devices.py", line 136, in test_for_nans
raise NansException(message)
modules.devices.NansException: A tensor with all NaNs was produced in Unet. This could be either because there's not enough precision to represent the picture, or because your video card does not support half type. Try setting the "Upcast cross attention layer to float32" option in Settings > Stable Diffusion or using the --no-half commandline argument to fix this. Use --disable-nan-check commandline argument to disable this check.

Thanks for the info . I'll look into it
These were the settings I used for testing on A1111 today:
!python launch.py --share --opt-sub-quad-attention --disable-safe-unpickle --gradio-queue --no-half-vae

Sounds great. I tried those settings, but no luck.

@Nekos4Lyfe Got it working- I just cast everything to "mps" and float16 and then modified line 247 of data.py to read "output = torch.cat([output.to(device = "mps" , dtype = torch.float16),current.to(device = "mps" , dtype = torch.float16)], dim=0)" to resolve the issue with concatenating tensors on different devices. Not sure if that helps you when it comes to finding a universal solution, but it works as a messy local patch.

@Nekos4Lyfe Just wanted to say thanks so much for this extension! I think it's honestly a must-have for SDXL. I was able to get so many concepts that the base model struggles with to work perfectly with very little effort.

That makes me happy.  The github repo has now been updated to cast tensors to "mps" if such a device is available (i.e if the device is a MAC). Let me know if that works for you.

@Nekos4Lyfe It works (after I altered data.py to cast the tensor concatenation to cpu before running numpy), but unfortunately I'm now getting embeds that don't look like the text entered at all.

@Nekos4Lyfe Thanks! I'll see if I have time to mess around with it after work.

@Nekos4Lyfe Didn't end up having a chance to check, but just wanted to let you know you fixed the issue! :)

What? How? I guess that's good news :D!

Not sure, just pulled your latest and everything worked. I'll let you know if I see any other issues. And yeah, I've pulled it into a local branch.


[Improvement] Link two Resource Tracker

While one resource tracker might be assigned to a clip, another might be the total bullets.
Once a bullet is used from the clip, the total bullets resource tracker should be updated.

A good generic enhancement would be the ability to call an OtF or Macro when a threshold is crossed.


Handle base path

Check if it's possible to infer base path from APIGatewayProxyRequest's following fields:

resource
requestContext.resourcePath
path

If not, get it from an environment variable and document it.
Implement using these as guide:

https://github.com/apex/gateway/pull/4
https://github.com/awslabs/aws-serverless-express/issues/86
https://github.com/awslabs/aws-serverless-java-container/blob/f634f6e3f30e859687eb33814df1085a2a6e3f63/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/RequestReader.java#L89

Isn't this as easy as the following change? index.js line 21:

return url.format({ pathname: event.path, query: event.queryStringParameters })

return url.format({ pathname: event.resource, query: event.queryStringParameters })


vapor xcode failed

vapor xcode failed
Generating Xcode Project [Failed]
error: multiple products named 'Logging' in: Console, swift-log
error: multiple targets named 'Logging' in: Console, swift-log

Error: Could not generate Xcode project: error: multiple products named 'Logging' in: Console, swift-log
error: multiple targets named 'Logging' in: Console, swift-log

Package.swift
// swift-tools-version:4.0
import PackageDescription

let package = Package(
    name: "NewBox",
    products: [
        .library(name: "NewBox", targets: ["App"]),
    ],
    dependencies: [
        // 💧 A server-side Swift web framework.
         .package(url: "https://github.com/vapor/vapor.git", from: "3.0.0"),

        // mail Server
        .package(url: "https://github.com/IBM-Swift/Swift-SMTP.git", from: "5.1.0")

    ],
    targets: [
        .target(name: "App", dependencies: [ "SwiftSMTP", "Vapor"]),
        .target(name: "Run", dependencies: ["App"]),
        .testTarget(name: "AppTests", dependencies: ["App"])
    ]
)

Hi @jancywen,
There is a post on the Swift Forums within the Vapor project about this issue https://forums.swift.org/t/logging-module-name-clash-in-vapor-3/25466.
There is a description in there about why this happened and a workaround describing how to pin to Logger API version to < 1.9.0 (as it doesn't look like the PR to rename Vapor's Logging module has been merged yet).
This should address your issue!
Thanks

Thank you very much, vapor xcode success


chore(release): Merge hotfix_6.2.1@a63f4fcf into edge (merge 3)

Overview
This is the third and final PR to incrementally merge changes from the v6.2.1 hotfix into edge. It's preceded by:

#12073
#12081

Changelog
This merge has manual resolutions of some straightforward conflicts.
In source code:

api/src/opentrons/protocol_runner/protocol_runner.py

Changes in edge required dropping a check for a loadLiquid feature flag.

api/tests/opentrons/protocol_runner/smoke_tests/test_legacy_command_mapper.py

Changes in edge required adding an explicit robot_type parameter to create_simulating_runner().

app/src/organisms/Devices/HistoricalProtocolRunOverflowMenu.tsx

Import statement reordering.

In other stuff:

Removed all autogenerated CHANGELOG.md files, which no longer exist in edge.
Took the edge version of all package.json files. For Python projects, these no longer exist, and for JavaScript projects, their version is now the placeholder 0.0.0.
Took the edge version of yarn.lock.

Review requests
Make sure the file changes match your understanding of the commits that are present in this PR.
Test Plan
We should be good relying on automated tests here, as long as we're careful to make sure every CI job is passing.
Risk assessment
Low. This merge is relatively straightforward.

One additional conflict snuck into api/src/opentrons/protocol_runner/protocol_runner.py since this merge PR was opened, from #11920.
Since I'm familiar with that code, I just shoved the resolution into commit d6fe1da. API linting and tests pass locally with that resolution. Robot server integration tests also pass.


[Android] Share via email on content goes to subject area instead of email body.

on Android Share via email the content goes to subject area instead of email body. Suject should be empty and body should be content like it does for ios.

I resolved the issue in latest version. Please check it.


New package: Dian v0.1.0

Registering package: Dian
Repository: https://github.com/cuihantao/Dian.jl
Created by: @cuihantao
Version: v0.1.0
Commit: a2591010dd44cfd514af7e101ef781de4cd845d7
Git reference: HEAD

Please close this PR. Package name has been changed and a new PR is in progress.


Get this issue when using already put fake payment in log

Unhandled Promise Rejection: TypeError: a.message.forEach is not a function. (In 'a.message.forEach((function(e,n){var a=e.param,i=e.error;t.setState({errors:q({},t.state.errors,Object(o.a)({},a,i))})}))', 'a.message.forEach' is undefined)

Hello @talmax1124, can you please clarify your problem a bit for me?

https://user-images.githubusercontent.com/61528430/115335585-7ca9af80-a16b-11eb-810a-b9ee62a22c67.mov
This is what appears in console

Have you made any modifications to the code in this repository?

No, I have not

What browser is this?

Safari


Use PropTypes from prop-types in order to be ready for React 15.5+

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Coverage remained the same at 91.892% when pulling d069d482219581b3590ce965b775f5cda5ae7ca2 on cjpete:master into 1f3c8a13102f1af032f9d196ab5fcf66a9a1183f on chentsulin:master.

can this be merged plx?

\o/

released as v1.0.1 - https://github.com/chentsulin/react-redux-sweetalert/releases/tag/v1.0.1


dependabot: unignore nix

Since https://github.com/rust-vmm/vhost-device/pull/735#issuecomment-2396203227 nix updates are ignored because vhost-device-console needs to be updated to use new versions. #727 will change how we use nix, so maybe after that PR we can unignore nix again.

it looks like nix is not ignored anymore: https://github.com/rust-vmm/vhost-device/pull/769#issuecomment-2478481792

Okay, after #727 it's not a direct dependency anymore, so we can close this PR.


Fix hard-coded paths in skimmer

This PR fixes #32. Tested.

@mchiusi

It would be nice if, in the near future, we could automatically change the output file location

I definitely agree, but I don't know of any ideal way to do it. We can discuss.


Documentation builds broken

Heya, As you can see from https://readthedocs.org/projects/pytest-regressions/builds/21888409/:
WARNING: autodoc: failed to import method 'data_regression.DataRegressionFixture.check' from module 'pytest_regressions'; the following exception was raised:
No module named 'importlib.metadata'

So none of the API documentation is built.
Note, it seems you are missing a .readthedocs.yaml https://docs.readthedocs.io/en/stable/config-file/v2.html, to specify how to configure RTD

Thanks @chrisjsewell !

Cheers!


updates for latest OF & a few bug fixes

Updates
Updated all examples. Renamed testApp to ofApp. Regenerated Xcode projects.
Fixes
Fixed deprecations with latest OF.
Added an add-on_config.make with the -DNO_TIMER define needed to build the triangle lib in Visual Studio aka #49.
Added body getWorldPosition() to fix #99. Tested and works as desired.
Suggestion
Since testApp is now ofApp, the project files for the other platforms need to be regenerated as well. At this point, the ProjectGenerator is pretty reliable so I suggest we remove all the project files. People can simply generate them with the PG. This works very well for my addons since I don't have to keep the project files up to date myself.
If desired, I can do go ahead and remove them in another commit to this PR.

Pinging @kylemcdonald @NickHardeman @ilektron @danoli3

going to merge this immediately, going to wait a little longer before completely removing the project files. my feeling is that people are still learning to rely on the PG.

We will need to regenerate the VS & CB files then. I haven't had any issues yet with people using the PG, mainly since I include information on how to use it.

I tested the changes today! Looks great! Thanks @danomatika


feat: optimize vector3

Optimize the performance of the following methods for vector3:

projectOnPlaneToRef()：Change Math.pow(10, -10) to a constant
reorderInPlace()：Reduce function calls and member access
GetClipFactor()：Reduce function calls and member access

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14498/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14498/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14498/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14498/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14498/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14498/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14498/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14498/merge#BCU1XR#0


added test cases

As part of 5GFF, Rogers Communications is contributing our Test suite similar to the Device Location API PR.

Dear all,
We just integrated support for the OTPvalidationAPI in our Identity Broker and Apps.
While integrating I stumbled about a tiny issue on: https://github.com/camaraproject/OTPvalidationAPI/blob/main/documentation/API_documentation/OTP_SMS_API.md
Actually “Snippet 1. Request code” uses as URL https://sample-base-url/one-time-password-sms/v0/validate-code instead of send-code
Best Regards
Stefan Engelbert
Aloaha Software
@.***https://www.aloaha.com/
M: +356 79 567 034
T: +49 541 3859 4554
@.***
https://www.aloaha.comhttps://www.aloaha.com/
https://www.codeb.iohttps://www.codeb.io/
@.***https://play.google.com/store/apps/details?id=com.codeb.sms
CodeB SMS
@.***https://www.linkedin.com/company/codeb
@.***https://www.youtube.com/channel/UCSDcRoxoc1XBUOMhhJD2eGA
@.***https://twitter.com/aloaha
From: Nicholas Manolakos @.***
Sent: 05 July 2023 14:44
To: camaraproject/OTPvalidationAPI @.>
Cc: Subscribed @.>
Subject: [camaraproject/OTPvalidationAPI] added test cases (PR #33)

You can view, comment on, or merge this pull request online at:
https://github.com/camaraproject/OTPvalidationAPI/pull/33
Commit Summary

390383chttps://github.com/camaraproject/OTPvalidationAPI/pull/33/commits/390383c1f2e1f2db99f3dde2ffde1eee65569448 added test cases

File Changes
(1 filehttps://github.com/camaraproject/OTPvalidationAPI/pull/33/files)

A code/test-api-one-time-password.htmlhttps://github.com/camaraproject/OTPvalidationAPI/pull/33/files#diff-53ee3c15e82c6b75a0b83c6b216df6c2bb8d533917f202164f3632c386253e72 (207)

Patch Links:

https://github.com/camaraproject/OTPvalidationAPI/pull/33.patch
https://github.com/camaraproject/OTPvalidationAPI/pull/33.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/OTPvalidationAPI/pull/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4AXVJD6Q2XJWCZWJNPJSLXOVOQNANCNFSM6AAAAAAZ6425G4.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>


add protobuf-net

SteamDB app page links to a few games using this
https://steamdb.info/depot/49522/
Brief explanation of the change
added a rule for protobuf-net

looking for that lib in particular isn't useful but you can change your PR to look for every protobuf lib (Looking for protobuf shouldn't bring any false positive)

non matching tests missing


add instructions for installing plugins

Updates README with installation instructions from NeoBundle to Dein

What is the status?


[BUG] Annotated attributes not accessible from non-cdef subclass

Describe the bug
When trying to access an annotated attribute from an extension type parent class in a normal Python class, it appears the attribute is not visible.
To Reproduce
Code to reproduce the behaviour:
from cython import cclass, double

@cclass
class A:
    x: double

    def __init__(self, x: double = 0):
        self.x = x

class B(A):
    def __init__(self, x: double = 1):
        super().__init__(x=x)
        print(self.x)  # <--- AttributeError: 'B' object has no attribute 'x'

b = B()

Expected behavior
Ideally the C attribute of the parent class would still be visible to child class and Cython would replace this with C-style attribute access. Though may be misunderstanding something here
Environment (please complete the following information):

OS: macOS
Python version: 3.8.6
Cython version: 0.29.21

Additional context
NA

Playing around with this locally, it seems that casting to A resolves the issue (see patch below). Not sure if there is a better way to handle this though.
1c1
< from cython import cclass, double
---
> from cython import cast, cclass, double
15c15
<         print(self.x)  # <--- AttributeError: 'B' object has no attribute 'x'
---
>         print(cast(A, self).x)

I think this should probably be closed as "not a bug" (but I'll leave it for now) - this is just the consequence of specifying cdef attributes in a cdef class is that they become invisible from Python/untyped code (exactly the reason I thought using annotations to type module attributes might be a bad idea by default).
You can easily call B's member functions without self being a B instance so I'm not sure if that's a good assumption for Cython to make by default.