can't whitelist specific NBT

I need to be able to whitelist EntityTag.Invisible for item frames and drop anything else containing EntityTag.

Please reopen if this is still an issue. I am doing issue cleanup.


Fixing properties

Check seems to be reversed and properties need to be added into the dictionary.  Wasn't working for me until I made these changes.

Check seems to be reversed and properties need to be added into the dictionary. Wasn't working for me until I made these changes.

Thank you for your contribution. I've published the new version package.


3.x

i dont want to sound pushing ...
but do we have a timeline for this package to support filament v3 ?
or any blockage of this PR that communities can help?
Thanks for your work!

hey @chengkangzai,
currently the plugin already works in v3, the latest version that supports v3 is v3.0.0-beta3
i do have some refactor (and breaking changes) to do before i can tag v3, i don't want to tag v3 right now and break someone's app later with the BCs

Alright, I will test it out and let you know if it have any problems 🤘
Thanks again @saade 🙏

hey @chengkangzai,
currently the plugin already works in v3, the latest version that supports v3 is v3.0.0-beta3
i do have some refactor (and breaking changes) to do before i can tag v3, i don't want to tag v3 right now and break someone's app later with the BCs

Thanks, but it does not seem to work
 Problem 1
    - Root composer.json requires saade/filament-fullcalendar 3.0.0-beta3 -> satisfiable by saade/filament-fullcalendar[v3.0.0-beta3].
    - saade/filament-fullcalendar v3.0.0-beta3 requires filament/filament ^2.0 -> found filament/filament[v2.5.3, ..., v2.17.53] but it conflicts with your root composer.json require (^3.0).

Thanks, but it does not seem to work
 Problem 1
    - Root composer.json requires saade/filament-fullcalendar 3.0.0-beta3 -> satisfiable by saade/filament-fullcalendar[v3.0.0-beta3].
    - saade/filament-fullcalendar v3.0.0-beta3 requires filament/filament ^2.0 -> found filament/filament[v2.5.3, ..., v2.17.53] but it conflicts with your root composer.json require (^3.0).

Weird, i'm requiring ^3.0

@saade According to GitHub releases the 3.0.0-beta3 tag is published to composer from this commit https://github.com/saade/filament-fullcalendar/tree/7f4a801ee40eec4db2004ed913c4e8dcfc68b54f
Which is the main branch. The 3 tag should be published from the 3.x branch instead. I will install the package directly from GitHub branch, but just to let you know in future that the current tag is still pointing to the main branch where it has filament 2 support.

@saade According to GitHub releases the 3.0.0-beta3 tag is published to composer from this commit https://github.com/saade/filament-fullcalendar/tree/7f4a801ee40eec4db2004ed913c4e8dcfc68b54f
Which is the main branch. The 3 tag should be published from the 3.x branch instead. I will install the package directly from GitHub branch, but just to let you know in future that the current tag is still pointing to the main branch where it has filament 2 support.

🤦🏼 i've target the wrong branch, sorry about that v3.0.0-beta4 is out

Aite the full plugin work perfectly in my upgrade to filament v3 👍
Good job! Thanks Saade once again

I apologies, just realise there is error in browser's console log. Attached with the console log.
But the plugin still shows tho

👀 only documentation left

V3 is out! the PR was closed because of the main branch deletion


Update installer to 2020-09-03

I've filed https://github.com/msys2/msys2-autobuild/issues/16 for the python issue. It should hopefully be resolved in the next upload

Thanks! Shall I tag a new release?

Yes please :)

Awesome, thanks!


[optimization] open gcc strict-aliasing optimization

Proposed changes
use flag -fno-strict-aliasing won't generate SIMD Instructions for some vectorized case, so we need open it
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[x] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments

If we remove this flag '-fno-strict-aliasing', will forced conversion of different types of pointers produce unexpected results?

@EmmyMiao87
For example, an "unsigned int" can alias an "int", but not a "void*" or a "double".  A character type may alias any other type.
if we break this rules, gcc will generate a warning. I have fixed it.

@EmmyMiao87
For example, an "unsigned int" can alias an "int", but not a "void*" or a "double". A character type may alias any other type.
if we break this rules, gcc will generate a warning. I have fixed it.

So if there is no similar warning in the compile stage, there will be no problems in the run stage, right?

@EmmyMiao87
right


The only difference I see is that you use 3.18.1 cmake version and mine is 3.22.1. Might be older Android studio IDE.
Tell me if it helps.

 If so maybe your cache is corrupt when using older dependencies or maybe even SDK. I tested on 3 PCs that can compile it just fine. Well at least I'm glad it works now for you.

Cmake version=3.22.1
NDK Version=21.4.7075529
therefore i also delete build and cache from .android folder and many time invalidate cache and res

tart.


Add get table api

This PR:

adds a get table api
changes the route for retrieving the version to /share/{share}/schema/{schema}/table/{table}/version due to conflicts with the get table api
upgrades dependencies for use on M1 macbook pro*
test/testQuietly to integrationTest to fix tests expecting an integration test

(*) the current version of the scalapb library does not use a version of protoc that has publicly available arm64 builds and fails the local development

when do you plan to merge this?


How can we know multi GPU is working?

It is mentioned in the paper that using more GPUs accelerates the training. I have three NVIDIA K80s and using the flags
--nnodes 1 --nproc_per_node 3 -c
Binds all three GPUs and ramps them up to 98% usage, however, I cannot see any decrease in waiting time or epoch rounds and leaving it overnight, did not return any marginally better results. Am I doing anythign wrong? How can we know it is actually working? I tried to set --nnodes 3 but training never even started.

Please use --n_gpus option.
E.g. run.sh --stage 2 --n_gpus 3
https://github.com/kan-bayashi/ParallelWaveGAN/blob/d3b2b7b6b54a66a4e62b6533f8f990564258dabf/egs/ljspeech/voc1/run.sh#L121-L125

Thanks! But I am not using any recipes. So I am trying to run things like
sudo CUDA_VISIBLE_DEVICES="0,1,2" python3 parallel_wavegan/distributed/launch.py --nproc_per_node 3 -m parallel_wavegan/bin/train.py --config ../config1.yml --resume /home/georgios/s_pwgan/checkpoint-456504steps.pkl --outdir /home/georgios/s_pwgan --train-dumpdir /home/georgios/s_pwgan/wavs --dev-dumpdir /home/georgios/s_pwgan/eval
So when running nvidia-smi I can see that all thre GPUs are being used fully, but when looking at the training, it doesn't look like the waiting time it gives is decreasing, or step is faster. Is this how it should be? How do I know it is working correctly?

As I wrote in README, the batch-size will be multiplied by the number of gpus.
If you want to keep the same batch-size, please decrease the batch-size.

Excuse the noob (me), but I do not get how this works. Right, so if we keep the same batchsize (in my case it is 4), it is multiplied by 3, so that gives a batch size of 12. But if this is the culprit, then how is it that 12 fits in my GPU? Because there is no way it would fit.
I can try and decrease the batch size to 2, so then it would be 2*3=6. But would that increase performance/decrease wait times?

We use DistributedDataParallel.
https://pytorch.org/tutorials/intermediate/ddp_tutorial.html
In the case of batch_size=3 and n_gpus=4, each gpu process batch_size=3 and then summarized the loss among the GPUs, update parameters.
So if you compared with batch_size=3 and n_gpus=1, the speed of each iteration will decrease.

The advantage of multi-gpus in DataParallel is to use the large batch-size for training.
So if the required batch size is small (it can process within a single gpu), the use of multi-GPUs is not effective.

Oh wow. Thanks for the explanation.
Well I decreased the batch size to 2 (it was 4).
It seems that the waiting time is cut in half (now I get 250 hours instead of 500), but I am dubious over performance gain, since this batch size seems too small to me. So I guess, my question is what you would recommend, when I have 3 GPUS. A batch size of 4, or a batch size of 2?
Another issue I seem to be having is that the discriminator loss seems to be increasing.

Basically, I have never use multi-gpu for this training since the single gpu is enough to calculate and I do not have a lot of gpus.
And the batch-size in GAN training looks very sensitive and mysterious, the use of a large batch-size does not always give us better results.
See the comment: https://github.com/kan-bayashi/ParallelWaveGAN/issues/143#issuecomment-631297434

Thanks for all this info 😀
One more thing. Would you recommend a bigger batch_max_step and a smaller batch size, or vice versa?

I think bigger batch_max_step and a smaller batch size is better for the first trial but actually I've never investigated about that. So if you have no time to check it, it is better to follow the paper's default.

How come the LibriTTS model takes less time to converge than LJSpeech? LibriTTS mentions 7 days but LJSpeech notes 21 days.

Which config do you compare?
You should focus on the difference of the config, not dataset.

The one here and here

Discriminater is different.
See the comment in the header.

I have been trying for the last two days to finetune a vocoder to my single speaker, but I have been having no luck. The loss has just been spiking. I saw that the discriminator type is ResidualParallelWaveGANDiscriminator. What is the difference between this and the LibriTTS config, which has no mention of discriminator type?

ResidualParallelWaveGANDiscriminator is deprecated, I could not find a stable training setting (See #27 #61 #123). Please use the other settings.
I do not want to answer all of your minor questions, so at first please understand by yourself by reading the code and checking the other issues.

Ohhh, maybe that is why. Yeah I understand, sorry :)


Documentation Update: docker-compose.yaml

Fixed the URL for user management
Description
The default docker-compose points to an invalid URL for user management. After digging through your docs I found the proper URL.
Closes #<issue_number>
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[X] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

[ ] Test A
[ ] Test B

Checklist

[ ] I have merged the original branch into my forked branch
[ ] I added relevant documentation
[ ] follows the style guidelines of this project
[ ] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@ChadDa3mon awesome. Thanks for this PR! Docs are always a good place to start. Feel free to join our contributor's channel in our Slack.

@ChadDa3mon  https://join.slack.com/t/rubrixworkspace/shared_invite/zt-whigkyjn-a3IUJLD7gDbTZ0rKlvcJ5g
https://rubrixworkspace.slack.com/archives/C05BCGM277B


Export gdk::event::FromEvent

My usecase - I'm using builder's connect_signals and need to convert the glib::Values to their concrete types. For events, I can't convert from the value to the concrete event type (EventButton, EventConfigure etc.) directly - I have to first use to_value() to convert the general gdk::Event type and then use downcast() to convert to the concrete event type.
When I'm doing this manually it works well, but when I'm trying to add some mechanisms to make it more ergonomic I have a problem, because FromEvent is private and my generic functions can't use it as a trait bound.
Ideally I want to write something like this, on my custom type that contains the signal information:
pub fn param_event<E: gdk::FromEvent>(&self, index: usize) -> Result<E, crate::Error> {
    let event: gdk::Event = self.param(index)?;
    event.downcast().map_err(|err| {
        // Format a proper error
    })
}

Which will get used like this:
let event: gdk::EventButton = msg.param_event(1)?;

But I can't - because FromEvent is private - so instead my API looks like this:
let event: gdk::EventButton = msg.param::<gdk::Event>(1)?.downcast().unwrap();

Is there a reason why FromEvent is not exported? Can it be exported?

Actually, ideally the concrete event types should be FromValueOptional so that we can convert the glib::Values to them directly. I'm not familiar enough with GTK to know why/if this is supposed to be a problem.

I think this was just forgotten. Can you create a PR to export FromEvent from GDK?
But even without you should be able to call gdk::Event::downcast on  known event types or not?

Yes - downcast() on known event types works. It is only a problem when dealing with generics.

Makes sense


ADD Antora extension to parse Tekton Task yamls

This commit adds a first pass at an Antora extension that parses Tekton Task YAML to generate asciidoc documentation.

The CLI acceptance test failure isn't related to any changes in this PR.

I'm not sure why we need the internal/task_documentation/task_documentation.go since IIUC we don't need it for the rego or the acceptable bundles. Why not let the dir walking happen in the javascript? Maybe a symlink is needed so the files are visible, but it seems like less complex solution.

Ack, thanks, it makes sense. I forgot we have a similar copy mechanism for the command reference.

Ack, thanks, it makes sense. I forgot we have a similar copy mechanism for the command reference.

Just to make sure, we're on the same page here. We don't copy for the CLI reference, the Corbra structs are transformed and marshalled to YAML and then placed in dist/reference. For the Tekton task we already have YAML and all we do is to copy it over to dist/task. Having go code where a symlink would do seems over-engineered.

would

Agreed. This approach has been abandoned.

I tried a build and saw something like this in the nav:

Enterprise Contract CLI

Documentation

Reference

{{ name }}

Tasks

{{ name }}

Maybe the handlebars isn't doing what it's supposed to in that one place? I'll see if I can figure it out.

I tried a build and saw something like this in the nav:

Enterprise Contract CLI

Documentation

Reference

{{ name }}

Tasks

{{ name }}

Maybe the handlebars isn't doing what it's supposed to in that one place? I'll see if I can figure it out.

Ensure that in your hacbs-contract.github.io repo, you’ve amended your antora playbook to point to the proper branch for testing purposes.

Ensure that in your checked out hacbs-contract.github.io, you’ve amended your antora playbook to point to the proper branch for testing purposes.

Ah, thanks.


update proposal and psriopool kernel in FPGA v2 resolve#1792

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: qnqinan:x: QiQi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Added GameManager class

I'm still working on the game mechanics, but this is a good framework to start with.

I made the changes you requested. I also finished up the class and provided some example usage in main.cpp

Please see my comments. Also please edit Makefile to add GameManager.o to the relevant location (before things that depend on it) on the OBJ line. We owe it to @EliteTK to do our best to keep Makefile up-to-date.

I'll review this when I can a little later. There were merge conflicts but I resolved them for you.

Ah, there's one thing I forgot about in the review, there is no need to do a null check before a delete, delete gracefully does nothing if you call it on null. But that part of the code might end up having to change anyway.

Ok, it looks like smart pointers might be the answer. I'll look into this later.

Just fixed the scoring bug

Still getting crashing. Appears to be originating from line 32 of GameManager.cpp
Is there any particular reason you aren't using the Player1Hand and Player2Hand classes?
I think you should refactor the code to get rid of the cardfactory from your code entirely. You should probably just have two members each holding a PlayerHand object and use that.
If there is a specific reason you aren't using those classes, please let me know and maybe we can figure something out.

Also please solve your merge conflicts.
Right now, two files are conflicting: main.cpp and the project file.
The project file would be easiest to fix by undoing your changes (right click, undo changes) then adding your files to the project again and committing.
If you need help, @EliteTK or myself can try to get you through it. Merges can be tough.

Disregard the conflicts. My fault. See pull request 20. When I merge that one in I suspect your conflicts will disappear.

Stand by. I should be very close to merging in the changes @EliteTK suggested in his pull request. I suspect that will resolve your merge conflicts then if the branch works I'll merge yours too.

Merge conflicts are resolved but now you have compilation errors. Please see the below build log. Consult with @EliteTK or myself if needed.
1>------ Build started: Project: Memes With Friends, Configuration: Debug Win32 ------
1>PlayerHand.cpp
1>Player2Hand.cpp
1>Player1Hand.cpp
1>main.cpp
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\main.cpp(142): error C2664: 'bool Card::compare_to_down(Card &)': cannot convert argument 1 from 'Card *' to 'Card &'
1>GameManager.cpp
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\gamemanager.cpp(109): error C2664: 'bool Card::compare_to_left(Card &)': cannot convert argument 1 from 'Card *' to 'Card &'
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\gamemanager.cpp(116): error C2664: 'bool Card::compare_to_right(Card &)': cannot convert argument 1 from 'Card *' to 'Card &'
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\gamemanager.cpp(123): error C2664: 'bool Card::compare_to_up(Card &)': cannot convert argument 1 from 'Card *' to 'Card &'
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\gamemanager.cpp(131): error C2664: 'bool Card::compare_to_down(Card &)': cannot convert argument 1 from 'Card *' to 'Card &'
1>GameDisplay.cpp
1>CardFactory.cpp
1>Card.cpp
1>Generating Code...
1>Done building project "Memes With Friends.vcxproj" -- FAILED.
Build has been canceled.
Projects build report:
Status    | Project [Config|platform]
-----------|---------------------------------------------------------------------------------------------------
Failed    | Memes With Friends\Memes With Friends.vcxproj [Debug|Win32]
Time Elapsed 00:00:04.541

It compiles now but getting a crash on line 32 of GameManager.cpp.
This brings us to the earlier discussion. Is there a reason you aren't using the Player1Hand/Player2Hand classes? If no, then rewrite to use those. If so, please explain and replace the C array with std::vector

Just reworked the code. It compiles now, but for whatever reason, my computer can't run it.

So now it's crashing because of line 151 in main.cpp and lines 40,46,47 in GameManager.cpp
Temporarily commenting all four of those delete calls allows the program to run successfully and exit all without crashing.
I suspect the delete in main is crashing because you are not using 'new' on line 135. You don't allocate any memory so there is no reason to delete either. Add a 'new' line, remove the delete, or convert to a unique_ptr 'auto game = std::make_unique(font, &gamedisplay)' should do it.
I think the crashes in the destructor of GameManager.cpp are because you are grabbing a std::shared_ptr to various pieces and are treating them internally as raw pointers. The shared_ptr gets rid of the data before the destructor hits causing you to double delete (thus crashing).
You can fix that by treating them as std::shared_ptr then you don't need to do delete at all and don't risk losing the memory in a leak.
I also noticed two warnings you'll probably want to fix:
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\playerhand.cpp(35): warning C4018: '>=': signed/unsigned mismatch
1>d:\visual studio\memes-with-friends\memes with friends\memes with friends\playerhand.cpp(42): warning C4018: '>=': signed/unsigned mismatch
@EliteTK can probably chime in a little here but I think my analysis above is correct. I also need him to compile on Linux and verify functionality once you've made all your changes and it works for me. Let's get it working for me first then he can test.

The cause of the warnings BTW is because the vector size method returns size_t which is unsigned int. You can either cast index to (unsigned int) or, preferably, change the argument in the function signature to be: unsigned int index in both reported areas.

@dean1012 a note on size_t, size_t is its own in a sense, it shouldn't be treated as if it was unsigned int. If you intend to pass size_t around, make your function parameters size_t, not unsigned int.
I haven't looked at the code yet but I'll take a quick glance this afternoon if I find the time.

@EliteTK Thanks for clarification. I think the fix that was committed is still good enough to fix the warning though. Check it out and let us know.

Any update on this @brettschalin

Awesome! It compiles without warning or error on Windows and seems to execute with all known functions and doesn't crash during use or on exit any longer.
I'll merge this if it compiles and runs on Linux. Can you confirm it is satisfactory on Linux, @EliteTK

@dean1012 it compiles and runs.

Merging then! Thanks @brettschalin and @EliteTK


Monitor component performance and identify problem.

JobAccountant is the most expensive component. Average of 10k docs per hour. Specific issue on #4656
JobArchiver is not very slow, but sometimes it triggers a heartbeat between 30 and 60 min. We might review and try to improve it eventually.
JobStatusLite falls on the same case of JobArchiver. Deserves a code refactoring eventually (which should buy us a better job tracking as well).

duplicate


"HUEDIN" is listed in the drop-down menu

Description:
"HUEDIN" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Huedin" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oras HUEDIN, CLUJ".

@TaniaR33 if this test case is FAIL, please write a bug report to prove the error


Repo sync for protected CLA branch

The pull request is created from privateToPublic-push-CLA-reviews637608206373170426 to privateToPublic-push-CLA-reviews to fix git push error for protected CLA branch

Docs Build status updates of commit add443e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 0, Column 0: [Error-docset-not-provisioned] Cannot build docset 'E2E_RepoSync_Private_PubDev' because it isn't provisioned. Please go to Docs Portal (https://ops.microsoft.com) to provision first.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Unable to login to Netbird after initial setup - with Authentik

Describe the problem
I have the below setup:

Domain Registered with Cloudflare
Authentik is self-hosted at my home lab and accessible via Nginx Proxy Manager, which also in my home lab.
For Netbird, created a new Ubuntu VM in VPS (Oracle Cloud) and a CNAME created in Cloudflare with VMs public ip (No NPM involved)

Every is set up according to the documented instructions in Advanced Guide. But login to Netbird is stuck at loading page (after Authentication using Authentik is completed successfully).
It does feel similar to this issue but cannot say as i am not sure if the setup also exactly the same.
Page is stuck while trying to access URL https://nb.domain.com:33073/api/users and gets connection refused. But i am not sure where is that connection is getting refused from and how to fix it. I did enable all ports as mentioned in document (both TCP and UDP) in Oracle Cloud.

Below is my setup.env
NETBIRD_DASHBOARD_TAG=""
NETBIRD_SIGNAL_TAG=""
NETBIRD_MANAGEMENT_TAG=""
COTURN_TAG=""
NETBIRD_RELAY_TAG=""

NETBIRD_DOMAIN="nb.domain.com"

NETBIRD_TURN_DOMAIN=""

NETBIRD_TURN_EXTERNAL_IP="VMs Public IP"

NETBIRD_AUTH_OIDC_CONFIGURATION_ENDPOINT="https://login.domain.com/application/o/netbird-oidc/.well-known/openid-configuration"
NETBIRD_AUTH_AUDIENCE="Client ID from Provider in Authentik"
NETBIRD_AUTH_CLIENT_ID="Client ID from Provider in Authentik"
NETBIRD_AUTH_SUPPORTED_SCOPES="openid profile email offline_access api"
NETBIRD_USE_AUTH0="false"
NETBIRD_AUTH_DEVICE_AUTH_PROVIDER="none"
NETBIRD_AUTH_DEVICE_AUTH_CLIENT_ID="Client ID from Provider in Authentik"
NETBIRD_AUTH_DEVICE_AUTH_AUDIENCE=$NETBIRD_AUTH_AUDIENCE
NETBIRD_AUTH_DEVICE_AUTH_SCOPE="openid"
NETBIRD_AUTH_DEVICE_AUTH_USE_ID_TOKEN=false
NETBIRD_IDP_MGMT_EXTRA_USERNAME="Netbird"
NETBIRD_IDP_MGMT_EXTRA_PASSWORD="service account password from Authentik"
NETBIRD_AUTH_PKCE_REDIRECT_URL_PORTS="53000"
NETBIRD_MGMT_IDP="authentik"
NETBIRD_IDP_MGMT_CLIENT_ID=$NETBIRD_AUTH_CLIENT_ID
NETBIRD_IDP_MGMT_CLIENT_SECRET=""
NETBIRD_DISABLE_LETSENCRYPT=false
<EMAIL_ADDRESS>NETBIRD_DISABLE_ANONYMOUS_METRICS=false
NETBIRD_MGMT_DNS_DOMAIN=netbird.selfhosted

NETBIRD_RELAY_DOMAIN=""

NETBIRD_RELAY_PORT=""

I just installed Netbird so everything is latest.
Did any one see this issue? Is it something to do with Netbird or Oracle Cloud restricting something or something between my homelab (Authentik) and Netbird (VPS)?
Please help me to fix and move forward.

this was solved on Netbird's Slack channel.
It was related to the setting NETBIRD_LETSENCRYPT_EMAIL not being correctly configured.
Improvements in the documentation is needed, to insure users properly configure Let's Encrypt.

closing this issue

For anyone searching the info here is a link to the conversation on slack: https://netbirdio.slack.com/archives/C02KHAE8VLZ/p1726744544049569


[WIP] Exploring new CI build options for macOS x86/stripping debug info directly

[WIP]

Closing this for now, -femit-dwarf-unwind=no-compact-unwind is apparently not supported even on the macOS 13 runner.


dbg: add thread-safe identifier (WiP)

Sometimes it's useful to identify/group log messages by an thread-safe identifier.
Let's say you have a application with multiple calls, we can add a call specific ID to log messages:
DEBUG_ID(call_id);
DEBUG_WARNING("error message");
...
DEBUG_RESET_ID;

A alternative solution could be:
DEBUG_WARNING_ID(id, ...);

It would be an ID that is 1-1 related to the thread. E.g. The callid has nothing to do with a specific thread except the main thread.
Should we instead add a
DEBUG_ENABLE_TID();

The idea has nothing to do with thread id, it should only be thread-safe. If you have multiple (maybe hundreds) calls or sessions it's hard to debug since you don't know which log messages belongs together.  Since you can only guess.

Will close this in favor of this API:
int debug_id = 1234;

DEBUG_WARNING_ID("something goes wrong");

This is easier and more flexibel, since no reset id handling is needed and general messages can be combined.


Add Change Log Modal to Footer

New Behavior
Description
Added Change Log modal to Footer
Screenshots

First part of this PR: https://github.com/short-d/short/pull/533.
Adding Changelog modal to footer without adding updates service.

Hi @kapillamba4 , thank you so much for working on this cool feature! I left few comments on the PR!


Getting warning message after upgrade to RN 0.60

warn The following packages use deprecated "rnpm" config that will stop working from next release:

native-base: https://github.com/GeekyAnts/NativeBase#readme

Please notify their maintainers about it. You can find more details at https://github.com/react-native-community/cli/blob/master/docs/configuration.md#migration-guide.
Please tell me is this major issue  or we can ignore it

Warnings fixed in latest version.


Added params for robot description in launch file

Hello @fan-ziqi , thanks for contributing to the quad-sdk repo!
Could you add a description or motivation behind the parameters added in the files?
Thanks!

@fan-ziqi thanks for the comments!
Have you tried this with a different robot/platform other than spirit or a1 for the command:

This is just to see that it does in fact works with a different platform on a real experiment.
Thanks!

@selvingarciag96 You're welcome!
Yes, my original intention in modifying this code was to port it to other platforms. I added the cyberdog_description (CyberDog is a quadruped robot developed by Xiaomi.), and tested importing the robot model only in simulation environment, which was successful.
I haven't had time to debug the quad_utils/config/(robot_type).yaml file, so other functions haven't been tested yet. However, I believe that this approach will not affect the existing functionality. This approach is also used in Unitree's open source code such as https://github.com/unitreerobotics/unitree_guide/blob/bf82a8dc3dd5b626ab741b94421ec95b926cfe69/unitree_guide/launch/gazeboSim.launch#L4

@selvingarciag96 By the way, can you review PR #366? It's been a long time since anyone replied.

Hi @fan-ziqi,
Just checking in on this, whats the status of this pull request as of late?
Thanks,
David Ologan

Hi @fan-ziqi, Just checking in on this, whats the status of this pull request as of late?
Thanks, David Ologan

Hi @ologandavid, my code has been tested and is working well

Ok, sounds good, I'll go ahead and review this and add the instructions to the wiki. Thanks!
Best,
David Ologan


HSEARCH-2105 Several improvements around ES embeddable mapping

Hey @Sanne can you quickly check out this PR, specifically the last three commits of it (I based this on @gsmet's not yet merged faceting work).
It does two things:

Don't use nested mappings by default with ES for now (as discussed, we can make nested the default for index-embedded collections with more than one field and/or make it user-configurable eventually)
Ensures that for index-embedded collections those fields that belong to one collection element are mapped to the same array element in the resulting ES JSON array (again, that's not a real nested mapping with sub-docs, i.e. the index looks essentially the same as with plain HS+Lucene, but the field should be correctly correlated in the JSON array, otherwise users will hate it).

For the second issue I came up with a hack which I think is acceptable but I'd like your feedback before driving it further. The idea is to insert "marker fields" which denote the array index of the subsequent document fields. This allows to restore the properly structured JSON by examining the "flattened" document. Note that this only happens in the ES case (I service-yified this part, only ES plugs in a proper impl, whereas in plain Lucene it's no-ops).
To give an example, say I have an association from GolfPlayer to a collection of GolfCourse which is index-embedded. That's the relevant parts of the document as built for ES:
$nesting=playedCourses[0] // marker field
playedCourses.name=Purbeck
playedCourses.rating=127.3
$nesting=playedCourses[1]
playedCourses.name=Mount Maja
playedCourses.rating=111.9

The marker fields themselves won't be added to the JSON document of course, they are only info used to asemble the required structure.
It's hacky but it does the trick and IMHO is good enough for the time being. Pushing potentially wrongly structured data to ES is very bad, hence I'd go with that solution for now. In the next step we should look into abandoning using plain Lucene Documents as the actual datastructure which will make all that unneeded. Note that there are two test failures I still need to sort out.
Please let me know what you think.

as discussed, we can make nested the default for index-embedded collections with more than one field and/or make it user-configurable eventually

This reminds me of yet another problem we have with the current FieldBridge API: we don't really know how many fields are being added.

This reminds me of yet another problem we have with the current FieldBridge API: we don't really know how many fields are being added.

MetadataProvidingFieldBridge goes into this direction, i.e. telling what fields to expect? Note that for the ES schema it makes no difference whether a field is there once or n times. So I am not seeing a strong problem here right now, but I may be missing something.

Pushed an update; @Sanne, any thoughts?

something wrong here:
Tests in error:
ElasticsearchNullValueIT>SearchTestBase.setUp:46 » Annotation Use of @OneToMan...
ElasticsearchNullValueIT.deleteTestData:63->SearchTestBase.openSession:81 » IllegalState
ElasticsearchNullValueIT>SearchTestBase.setUp:46 » Annotation Use of @OneToMan...
ElasticsearchNullValueIT.deleteTestData:63->SearchTestBase.openSession:81 » IllegalState
ElasticsearchIT.testEmbeddedIndexing:207 » AssertionFailure Exception releasin...
ElasticsearchIT.deleteTestData:140->SearchTestBase.openSession:81 » IllegalState
NestedEmbeddedTest.testNestedEmbeddedIndexingWithContainedInOnCollection:105 » AssertionFailure
PrefixedEmbeddedCaseInPathTest.setUp:48->persistEntity:124 » AssertionFailure ...
PrefixedEmbeddedCaseInPathTest.setUp:48->persistEntity:124 » AssertionFailure ...
PrefixedEmbeddedCaseInPathTest.setUp:48->persistEntity:124 » AssertionFailure ...
PrefixedEmbeddedCaseInPathTest.setUp:48->persistEntity:124 » AssertionFailure ...
Tests run: 328, Failures: 0, Errors: 11, Skipped: 0
This was after a rebase. Trying again on your exact same commit...

Re-run the testsuite on your exact same commit and it passed all tests.
Checking again after rebase...

It worked fine twice after the rebase. I probably messed up the previous update, sorry..

MetadataProvidingFieldBridge goes into this direction, i.e. telling what fields to expect? Note that for the ES schema it makes no difference whether a field is there once or n times. So I am not seeing a strong problem here right now, but I may be missing something.

I didn't mean that the same field gets added twice. I mean that there are cases in which a single property contributes multiple different index fields:

https://github.com/hibernate/hibernate-search/blob/e2f3e1e98eb903e08f34339ee4408bef31d18e3a/orm/src/test/java/org/hibernate/search/test/bridge/DateSplitBridge.java#L42

So I don't see how you can plan to have ES use one kind of mapping vs the other one based on the fact if we're adding more than one field for a _ToMany IndexedEmbedded relation.

I'm trying to understand why you modelled ElasticsearchNestingContextFactoryProvider as a Service, and it using a CHM to "cache" the ContextCreationStratey. You also decided to make sure these are lazily initialized, surely as the mapping isn't complete on service start.
But rather than having a cache, shouldn't this strategy be (conceptually) a field of the DocumentBuilderIndexedEntity ?
(if that was not an -engine specific building block).
Wondering if we shouldn't have a different implementation of DocumentBuilderIndexedEntity for the Elasticsearch case.
Let's assume you made this as a temporary work around; then why bother with the pitfalls of caching? Is it a performance related thought?

I'm trying to understand why you modelled ElasticsearchNestingContextFactoryProvider as a Service, and it using a CHM to "cache" the ContextCreationStratey. You also decided to make sure these are lazily initialized, surely as the mapping isn't complete on service start.

Many good questions :)
It's a service so I can plug in the implementation which resides in the elasticsearch module. If no service implementation is present, the no-op default implementation will be used.
The implementation is lazy because I don't know before whether a given type is mapped to ES (thus requiring the specific nesting context) or not (thus allowling the no-op impl to be used). It uses the CHM to avoid doing this decision again and again.

But rather than having a cache, shouldn't this strategy be (conceptually) a field of the DocumentBuilderIndexedEntity ?
(if that was not an -engine specific building block).

Yes, having specific DocumentBuilderIndexedEntity implementations would be a better approach and the one we should pursue eventually. Then the ES backend could apply its specific DBIE implementation and we can get rid of that nesting context scheme. I only wen that route to keep changes in a digestable size and not do all at once.

Wondering if we shouldn't have a different implementation of DocumentBuilderIndexedEntity for the Elasticsearch case.

Yes, absolutely. It'd do that probably when getting rid of Document as the central "format" used internally as discussed.

Let's assume you made this as a temporary work around; then why bother with the pitfalls of caching? Is it a performance related thought?

Right, it's temporary, and yes, the caching is meant to avoid determining the type of backend repeatedly at runtime.

@Sanne Rebased to latest master. Now it's just the four actual commits :)

I mean that there are cases in which a single property contributes multiple different index fields:

Assuming DateSplitBridge would implement MetadataProvidingFieldBridge and properly announce the three fields it creates, it should be doable.

fixing a typo in a follow-up commit! tsk tsk .. :)
Thanks for the explanation, it all makes sense now.
I'm wondering if we should add a bit more context or "what the intent is" in PRs, especially when it's random progress not clearly defined in a JIRA.

I'm wondering if we should add a bit more context or "what the intent is" in PRs, especially when it's random progress not clearly defined in a JIRA.

I had hoped my explanation at the top of this PR would make the intention clear. I'll try harder next time :)

Assuming DateSplitBridge would implement MetadataProvidingFieldBridge and properly announce the three fields it creates, it should be doable.

The problem is we don't mandate to implement MetadataProvidingFieldBridge.. so what do you do when there are custom fieldbridges around which don't? Default to nesting as only safe option?
Either way, it would be "surprising behaviour" for some people.

Without this, we cannot create the proper ES index structure in such cases
anyways. So using this bridge as-is would fail at indexing time as thing
stand (I opted for "strict" index structure checking for the time being).
I think as of HSEARCH 6 we should make proper announcement of created
fields mandatory. I.e. merge MetadataProvidingFieldBridge into FB 2.0
essentially.

merged!

Jippie!


unocss transformer

https://unocss.dev/transformers/variant-group
https://unocss.dev/transformers/directives

Unknown at rule @applycss(unknownAtRules)

https://github.com/unocss/unocss/issues/4333


Outdated framework

.NET Core 3.1 was released 5 years ago (12.2019), and went out of support in December 2022. It was since been superseded by .NET 5, 6, 7, and currently .NET 8.
Using .NET Core 3.1 to develop this project, and requiring users to install an unsupported runtime seems strange. Is this very intentional, or is it a tech debt that is planned to be updated to a current framework?

I'm not the developer of course. But I do have followed the work of this project. As far as I know this is a couple of technical reasons and to still ensure the use of the app on windows 10
but the main reason the Lixote said a while ago is becase he wanted to use XAML Island and as far as i remember was only supported on .NET 3.x
and as I Was checking microsoft resources for fact checking
"Using XAML Islands in WPF and Windows Forms apps that target the .NET Framework. XAML Islands are supported only in apps that target.NET Core 3.x."
https://learn.microsoft.com/en-us/windows/apps/desktop/modernize/xaml-islands

.NET Core 3.1 was released 5 years ago (12.2019), and went out of support in December 2022. It was since been superseded by .NET 5, 6, 7, and currently .NET 8.
Using .NET Core 3.1 to develop this project, and requiring users to install an unsupported runtime seems strange. Is this very intentional, or is it a tech debt that is planned to be updated to a current framework?

This is absolutely intentional, as from my testing, xaml islands (which are only supported on .net 3.1) allow for much stabler, and less resource intensive app than new solutions from microsoft. I may consider rewriting this application later on in something newer, but i kinda do not see the point in doing so for now.


Fix wrong search of message declarations

This PR fixes work of MessageDeclarations.find(...). Before the change, formation of returned declarations was incorrect.

@armiol PTAL.

@armiol PTAL.


Create CODE_OF_CONDUCT

I was attempting to use a GitHub template for our Code of Conduct, but this attempt did not work.


No background on Tooltips

Tooltips don't appear to have any background colour so can be hard to read where they cross areas of the page with multiple colors. They should have a background like in v2.3
Original ticket: https://github.com/CachetHQ/Cachet/issues/3758

CSS for tooltips no longer gets purged from minified file. Tooltips back to the same as in v2.3.

CSS for tooltips no longer gets purged from minified file. Tooltips back to the same as in v2.3.


Bug fixig and new sample application

Fixed the addition of new objectStores. To add new objectStores, the version must be incremented by 1.
Increased the number of rows in the IterateSourceAsync method. Previously, it was fixed at 20, and if an objectStores contained more than 20 records, the application would enter an infinite loop and crash.
Improved the sample application by adding support for managing multiple objectStores.
Enhanced the UI of the sample application.

First of all, I'd like to thank you for this major effort to improve the library. I can see how much work was put into the project and I appreciate both your interest in the library and your dedication to improving it.
But I'd like to point out that the contributing guide (here) specifies that pull requests should be preceded by posting an issue. That would have helped a lot in this case. Your PR combines many unrelated concerns, and unfortunately I cannot accept it.
Please open issues for each concern you'd like to address, and we can discuss them individually. When we come to an understanding about the work that needs to be done, you can re-open a PR that addresses that issue specifically.
I'll address a few specific points here and save you some time.

I appreciate the work to improve the sample project. Adding new types of sample data and showing more capabilities is a great idea. But I do not wish to add bootstrap (or any other external library). If you'd like to submit a new PR which uses only vanilla HTML+CSS, that would be quite welcome.

I don't believe incrementing the version number programmatically in this way is a good idea. That version number should reflect a stable schema version, and enable site maintainers provide upgrade paths for users migrating from one version to another. Your change moves the responsibility and control over versioning from the application author to the library's internal logic. It might be useful for some sites to automate versioning in this way, but I would prefer to leave that decision in the hands of the library users, rather than forcing this mechanism on everyone.

The batch count of 20 was not used by mistake. The TypeScript file uses the same value; this is the count of items in each batch of results. The queryable class aborts the while loop if fewer than 20 items are read because this means that the latest batch contained fewer than the maximum possible number of items. Therefore, there is no need to make an additional JavaScript interop call to check for more.
Please open an issue describing any specific reproduction conditions for the infinite looping bug you found. When I add 21+ items in the (original) sample project, it continues to work normally. We'll troubleshoot your problem in the issue and find a resolution. Ignoring the batch count may avoid the problem you found but is not a good solution to the bug. That logic is important.


WIP: Encounters completion stats - Prenatal

#1312

First results (obviously, some of them are buggy):

Suspected rows:

Following are fixed:


refactor: update azd (wip)

Please do not merge yet.

@manekinekko I made some important changes in this project last month. You can update later. But again, please rest up ;)


Release 'Publish Build Artifacts' fails with 'Unable to find container for build'

Hi, I am trying to publish some test results from the release agent working folder using the task 'Publish Build Artifacts' that I put into my release definition, but it fails with:
[error]Unable to find container for build: 88
I think 88 is the id of the build that triggered the release.
Interestingly, I have another 'Publish Build Artifacts' in my build definition and that works just fine.
Here is the task setup from my release definition
https://cloud.githubusercontent.com/assets/19437249/15373889/9c929e84-1d3f-11e6-9799-b9ea57103b79.png
And this is all the log output of the task:
Set workingFolder to default: C:\LR\MMS\Services\Mms\TaskAgentProvisioner\Tools\agents\1.99.0\tasks\PublishBuildArtifacts\1.0.30
[debug]loading inputs and endpoints
[debug]loading ENDPOINT_AUTH_SYSTEMVSSCONNECTION
[debug]loading INPUT_ARTIFACTNAME
[debug]loading INPUT_ARTIFACTTYPE
[debug]loading INPUT_PATHTOPUBLISH
[debug]loading INPUT_TARGETPATH
[debug]loaded 5
[debug]check path : C:\LR\MMS\Services\Mms\TaskAgentProvisioner\Tools\agents\1.99.0\tasks\PublishBuildArtifacts\1.0.30\task.json
[debug]set resource file to: C:\LR\MMS\Services\Mms\TaskAgentProvisioner\Tools\agents\1.99.0\tasks\PublishBuildArtifacts\1.0.30\task.json
[debug]system.culture=en-US
[debug]PathtoPublish=C:\a\1196b1921\requirementsCoverage.html
[debug]check path : C:\a\1196b1921\requirementsCoverage.html
[debug]ArtifactName=ReqirementCoverage
[debug]ArtifactType=Container
[debug]TargetPath=\my\share\waverage.feature\waverage_plan_in_traderwebapp_2016_05_18.5
[error]Unable to find container for build: 88
Could you help me find out what the problem is?
Or in case this task is not supported in a release definition, is there a way around this? Something like using cUrl or powershell to attach the files to the release using the VSO Rest API?

I've currently the same problem :
2016-05-27T20:13:10.1347652Z ##[error]Unable to find container for build: 4234

While writing this comment, I've carefully reread our logs and I've seen something strange :
 ##[debug]TargetPath=\\my\share\waverage.feature\waverage_plan_in_traderwebapp_2016_05_18.5

And particularly \\my\share. I think with both use hosted agents for the build and private agents for the release. I guess that private agents don't upload their artifacts on VSTS but instead on a local machine, via SMB, we have to configure.
I'll try to find where we can change the target machine, and try to see if it changes something :)

I think that's a red-herring - the target path is only applicable if artifacttype is share.  if it's container, then it's uploaded to the server and that param is ignored.  If you select share in your tasks, that input will light up and you will have to change it to a valid share name.
Are you failing using this task in a release definition?

Yes, I'm failing using this task in a release definition. And it seems that @sabiori has also this problem in a release definition :

Hi, I am trying to publish some test results from the release agent

I use "Publish Artifact" in build definitions without any problem

Thanks for comfirming.  There is no release agent - just one common agent but there's build and release definitions :)
Sriram in RM should look into.  Not sure if Ashwini should also take a look since she handles test results.

Publish Build Artifacts task isn't supported within Release. Unlike Build, RM doesn't store any artifacts along with the release. RM currently can only consume artifacts produced by Build.

Doesn't it make sense

accidentally closed ...

You may use publish test results task.

I tried to use 'Publish test results', but it limits me in the types of files I can upload. My release process is generating some html files (status reports) on the target machine after deployment which I would like to attach to the artifacts of the release, just like I can do with in a Build definition.
I think if the 'Publish Build Artifacts' is not supported in a release definition, then it should not appear in the list of tasks you can drag into the definition.
Is there a VSTS REST API that I can use to upload stuff to the artefacts list of a release?

We have the same issue. In the steps of our release definition, we minimally want to attach deployment logs to the release for further troubleshooting in case of failure. I think that this is pretty basic. Jenkins has been supporting it for years, Team Build as well and VSTS build also. I don't see why it does not make sense in RM.
Before switching to RM, we also looked at the capabilities of VSTS RM by looking at the different tasks available. Now, I hear that the tasks that I see may not be available. That's very disappointing...  a basic feature is not there and we have a UI that his misleading in presenting the available capabilities.
What alternative are you proposing to manage log files generated during environment steps?

We are adding support for uploading any file as part of task execution. This will be supported as a ##vso-command that tasks can invoke (passing the path of the file to upload as parameter). This command will be available to tasks irrespective of whether they run within Build or Release. The files uploaded this way can be downloaded as part of downloading the Build or Release logs.
Build artifacts are however very specific to Build. We do not feel it to be appropriate for Release to produce artifacts. Like I said before, artifacts are consumed by a Release (they get downloaded on the agent and get deployed using tasks).
In general, we wanted all tasks that work within Build to work within Release as well. That's the reason we didn't hide certain tasks in Release. However "Publish Build Artifacts" and "Copy and Publish Build Artifacts" tasks are expected to work only within Build. These are exceptions rather than the rule. We will update these tasks to fail gracefully with appropriate message when used within Release.
Hopefully these address your concern.

Sounds good to me.
It does not matter whether it is available through the artefacts or via the log files.
All I need is easy access to these files /per release/ from the release management website.

When you are saying:

We are adding support for uploading any file as part of task execution. This will be supported as a ##vso-command that tasks can invoke (passing the path of the file to upload as parameter). This command will be available to tasks irrespective of whether they run within Build or Release.

What does a ##vso-command mean? Is it a logging command? I guess not... Will we need to create our own VSTS task to invoke the ##vso-task?
Note that our step that needs to attach some log files is a PowerShell step that invokes one of our script. Will our powershell script be able to call the ##vso-task?
Finally, do you have an ETA for this new capability?

Yes. We are adding another logging command. This can be invoked from your powershell script like any other logging command we support.
We expect this to be ready in a couple of weeks time.

We have the command available now
e.g.
##vso[task.uploadfile]c:\Logs\file.log

In case anyone wonders: to view the uploaded file, you have to click on "Download all logs as zip". The uploaded file will be part of the zip.

We also are looking for capabilities of publishing artifacts from release. The case is when we depend on multiple artifact sources, we usually want to massage the two artifact source together and then use the final artifact to deploy to clusters. Thus, we would like to be able to publish from release or otherwise we need to duplicate the massage for each environment

@jshwei - we don't support publishing artifacts into release as of now. We are considering adding this support going forward. Thanks for explaining scenario where this could be useful.


No Devices Found

The application shows no devices found, even if the ESP32 board is in SmartConfig mode and the WIFI creds are hard coded to the function

Hmm, I'm not sure what we can do to help with your issue. Could you resolve it on your own? Do you have any more data?


Add h.264 support

Encoding/decoding might run into patent licensing issues, but at a minimum we should support streaming directly from a camera that outputs h.264.

Hardware encoding and/or use of the Cisco OpenH264 binaries (https://github.com/cisco/openh264/releases ) would avoid the patent issues.


Add --dry-run and --pr-only to Open Embedded

Open Embedded is lagging behind in a few places, one of which is the --pr-only and --dry-run flags that can be passed to the ebuild generator to prevent an unexpected PR from filing.
Should just be a replication of logic.
connects to #49.

Resolved by #131


proposal: golang.org/x/sys/windows: export getProcessEntry

The getProcessEntry code is currently duplicated in https://github.com/inconshreveable/mousetrap, which is widely used in projects (commonly as dependency for spf13/cobra). Until recently, mousetrap had code for backward-compatibility with old Go versions, but now that that code was removed, it's a very small wrapper around getProcessEntry. Exporting this function allows mousetrap to not having to duplicate the code, or for projects currently depending on mousetrap to consume the golang.org/x/sys code directly (most projects would already have golang.org/x/sys as dependency in some form or another).
Looking at the history for getProcessEntry, I see that this function was originally contributed by the author of Mousetrap (as a helper for Getppid(); see https://github.com/golang/go/commit/6f6f1bd054bf8789ede8cdfeaf28fa5af88bc371 / https://codereview.appspot.com/102320044), and there have been no changes since its inception. From that perspective, I estimate it won't add additional maintenance costs to the x/sys project.

relates to https://github.com/golang/sys/pull/143 / https://go-review.googlesource.com/c/sys/+/459039
relates to https://github.com/inconshreveable/mousetrap/pull/7#discussion_r1015589919

CC @golang/windows

The current getProcessEntry function is undocumented.  Can you write an example doc comment for GetProcessEntry?  Thanks.


Tooltip Save / Save As.. / Open File etc.

A tooltip indicating the purpose each button is for would be useful.
(Having hit several times the save instead of save as not knowing what it was for)

Tooltip does show up on hover.

My bad, it does indeed...
But I have to wait for 2 seconds for the tooltip to appear, which is less intuitive than the rest of the interface :)


[stable/datadog] Allow skipping Secret creation

Allow skipping Secret creation since there are situations where one may not want create Secret automatically.
In order to determine if chart need to create DaemonSet and/or Deployment logical expression has been changed to be a logical implication, which means it doesn't create DaemonSet and/or Deployment only if secret.create is true and datedog.apiKey is missing.

/ok-to-test

@hkaj @irabinovitch @xvello This change seems good to me, what do you think?

@hkaj @irabinovitch @xvello any chance to have this reviewed?
I am preparing another PR to the chart, and this one is a kind of blocker.
Thanks!

If the chart doesn't create the secret, if should be possible to specify the name of the existing secret. This is commonly done with existingSecret. If set, use an existing secret and otherwise generate one with the standard fullname.

/assign

/hold

/assign
Hello @timurkhafizov and sorry for the delay.
I think it's indeed legit to consume an existing secret, this way, the values.yaml can be committed to git without leaking the apikey.
I agree with @unguiculus though, I'd rather have a .Values.datadog.apiKeyExistingSecret option, that will disable secret creation from .Values.datadog.apiKey and use that secret instead. WDYT?

Hey @xvello
I am fine with both options .Values.existingSecret and .Values.datadog.apiKeyExistingSecret actually. I'd prefer stick to .Values.existingSecret if that's a best practice though.
I am going to update PR this weekend as I am back from vacation.

Hey @timurkhafizov,
As we are in the process of adding two more secret-backed credentials, I think it would be better to explicitly name what secret were are configuring, to avoid confusions down the road. This is why I wanted to go with .Values.datadog.apiKeyExistingSecret, to tie it with the value it is overriding ( .Values.datadog.apiKey). Is that OK with you?

@xvello yeah, that sounds good and reasonable. I'll change .Values.existingSecret to .Values.datadog.apiKeyExistingSecret

@xvello @unguiculus I've changed the logic and value name. Could you please review the PR once again?

Thanks @timurkhafizov ,
I'll review it today.

All good for me, thanks a bunch!
/ok-to-test
/lgtm

/hold cancel
/woof


Update Tokio runtime

I think we should be brave and update Tokio, the Triagebot is still running v0.2 :-)
This patch only updates:

Tokio crate + small changes to update the code for Tokio 1.x
reqwest crate
postgres crates (for the Triagebot DB connection)

Notes on testing
I could test the build of the T-compiler and T-lang agenda, but I don't know how to test the Triagebot server
Misc
Other crates need to be upgraded  but I think a separate PR is better suited (esp. because of octocrab+hyper)
I think r? @Mark-Simulacrum might be interested in this PR? Also cc: @spastorino

hm ... tests work on my machine (:tm:) maybe try re-running the CI?

Error:
error[E0658]: `match` is not allowed in a `const fn`
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/socket2-0.4.0/src/lib.rs:156:9
    |
156 | /         match address {
157 | |             SocketAddr::V4(_) => Domain::IPV4,
158 | |             SocketAddr::V6(_) => Domain::IPV6,
159 | |         }
    | |_________^
    |
    = note: see issue #49146 <https://github.com/rust-lang/rust/issues/49146> for more information

That doesn't look like something a re-run will fix -- maybe there are newer versions available?

We use the pinned Rust version on Docker, i.e. 1.45: https://github.com/rust-lang/triagebot/blob/327d5835c1c7ddb346d5bad5aaccf00107da17ab/Dockerfile#L8
const_if_match has been stabilized since 1.46 so we should update the Docker image to it or higher.

We use the pinned Rust version on Docker, i.e. 1.45:
const_if_match has been stabilized since 1.46 so we should update the Docker image to it or higher.

ah thanks, good point. Done in https://github.com/rust-lang/triagebot/commit/9add45f2ed4fba3bcab6748e359e984e76da3727

:+1: on the idea but I guess @Mark-Simulacrum or some other maintainer that knows exactly what and how to test are better suited to merge this one.


The Ultimate Anti-Aging Workout by Bryan Johnson

Experience
Anytype.20240710.190755.63.zip
Title
Anti-Aging Workout by Bryan Johnson
Screenshots

Description
Please note that all content is the original work of Bryan Johnson! Everything Bryan does is free & shareable! I've edited for convenience.
HD files-> https://drive.google.com/file/d/1Af4WFHazjYaK02nye8soLQ-cHhrf-Dyf/view
Categories
Health & Fitness
Language
en-US
Terms

[X] I agree that this Experience is licensed under the MIT License.
[X] I have intellectual property rights and/or permission to contribute the Experience and its content.
[X] I confirm that the Experience does not contain any harmful or malicious content.

/gallery approve

Hey @fuksman thanks for approving! How long does it take to show up in the gallery? I cant see it. Best Regards

Link gives an error: anytype://main/import/?type=experience&source=https%3A%2F%2Fgithub.com%2Fanyproto%2Fgallery%2Fraw%2Fanti_aging_workout_by_bryan_johnson%2Fexperiences%2Fanti_aging_workout_by_bryan_johnson%2Ftest-manifest.json

Hello @Balcion, the experience is published.

I added a second preview picture and updated the HD files link.

I made sure the HD files link is working

/gallery approve

Hello @Balcion, can you please submit a new version of the experience by creating a new issue, instead of editing the previous one? Just check that the experience title is the same.
Thank you!

Hello @fuksman resubmitting the entire experience just to edit the description seems a bit unnecessary. Is there a way to avoid this?


[TB] Cleanup codebase and fix any remaining bugs

User story

As a SD
I want fix any remaining bugs on the TB
So that I can have a cleaned up codebase

Acceptance criteria

Everything is neat and organized in the codebase
Bugs are fixed untill the end of the project

Definition of done (DoD)

Linter & Checker were performed and passed
Code Review has been completed
Code was merged in sprint release candidate
Updates are written in issue comments
Feature builds and tests successfully
Acceptance by product owner
User Story & Acceptance Criteria fulfilled

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Cleaned up turtlebot control software and retested everything. Ready for demo day.


Add prototype for a component build system

This is a first attempt at a central top-down build.
Given a config file for a particular bundle version, it clones each repository
and builds it with a given build script.
Signed-off-by: Marc Handalian<EMAIL_ADDRESS>Description
Usage: ruby build.rb ./configs/opensearch-1.0.0.yml

Component builds:
This PR includes a standard build script for projects using ./gradlew assemble and repo specific scripts for those that don't or have slightly different needs.
This PR is to get this started, the idea is that each repo would include a copy of this script under build/build.sh that tells us how to build their component.
Currently the order of components declared in Config matters because multiple repos depend on engine & common-utils and we do not yet have 1.0 in maven central.  These will be compiled first and the OpenSearch version passed along as a param to build.sh scripts.  The intention here is that repos will not depend on any unreleased version of a dependency. If they need to depend on the bleeding edge & compile against the version of those dependencies being built in this bundle build, they can do so.
Maven dependencies:
Each script can place their dependencies in -artifacts/maven to be picked up and published on their behalf.
Issues Resolved
#133
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Let's close in favor of https://github.com/opensearch-project/opensearch-build/pull/145


Cybersecurity: 1.9.4 Setup VirtualBox and Virtual Machine on Windows.

Description
Show How to set VirtualBox and Virtual machine in windows through screen-recording and explain every step!
Note:

Submission should be in screen-recording format with an explanation.
Changes should be made inside the Cyber_Security/ directory & Cyber_Security branch.
Task will be assigned on first come first serve
Check it out Contribution Guidelines

Can I work on this? I am a participant of GWOC21.

I want to do this work

I want to do this work

Go with it!

Thank you

sir I also want to do this work

sir I also want to do this work

Sorry, @prithwishpramanik
This is only for Video format and it is assigned to Swarnali already!
If she will not able to do this task only then I can pass this task to someone else.
You can check other issues also!

sir I also want to do this work

Sorry, @prithwishpramanik
This is only for Video format and it is assigned to Swarnali already!
If she will not able to do this task only then I can pass this task to someone else.
You can check other issues also!

ok sir, will we be able to contribute to the same issue if it is in documentation format only?

sir I also want to do this work

Sorry, @prithwishpramanik
This is only for Video format and it is assigned to Swarnali already!
If she will not able to do this task only then I can pass this task to someone else.
You can check other issues also!

ok sir, will we be able to contribute to the same issue if it is in documentation format only?

Yeah, more than one contributors work on the same issue if the submission format is different! But in this case, it is only for Video.


Page should be reviewed for updates an accuracy related to rules & playbooks

Being one of the first things a customer may read about Sentinel, accuracy and terminology are important. Please review updates and accuracy. Examples:
"can't integrate workbooks with external data" - very much incorrect
"analytics to correlate alerts into incidents" - Analytic rules can group alerts but there is no true correlation. The term correlation and related statements are incorrectly used and misleading. This implies some form of logic.
"Use the built-in correlation rules" - Again, there is no such thing as a "correlation rule", this is confusing terminology.
"Microsoft Sentinel also provides machine learning rules" - There are 2 ML rules that are being deprecated. Fusion might be a good topic.
"Playbooks aren't suitable for ad-hoc or complex task chains, or for documenting and sharing evidence." - I'm not sure why not?
Overall the order and wording of this page should be revised. Would be happy to submit a draft if interested.
Thanks, Andrew

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1f4fe06e-d692-c330-a651-d51fec279a6a
Version Independent ID: ec4c836d-f1a4-e6c1-59c1-14fce62bc2ec
Content: What is Microsoft Sentinel?
Content Source: articles/sentinel/overview.md
Service: microsoft-sentinel
GitHub Login: @yelevin
Microsoft Alias: yelevin

@AndrewBlumhardt
Thanks for your feedback! We will investigate and update as appropriate.

@yelevin
Can you please check and add your comments on this doc update request as applicable.

@AndrewBlumhardt
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

#label:"backlog-item-created"

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


still using "fireadmin"?

Scott,
I see you're work revolves around similar concerns to mine (redux and firebase anyway). I imagine that you may still be using this repo but since there were no recent commits to it I thought I'd ask because I have firemodel and firemock which i'm currently developing and purely from a naming convention standpoint I'd love to have fireadmin for a private repo I'd like to OSS. That said, if you're using it I can just find another name.

@ksnyde There are still a few places where fireadmin is being used in applications that are in production. Others may still depend on it as well, not totally sure (wouldn't be that easy to find out).
Does what your developing have any similarities? Always open to pull requests and updates.

Sure that makes sense Scott. I just wanted to check. My code is similar yet different enough that it probably doesn't fit as a PR.
I must say I love your tech focus around redux and Firebase; any illusions that my brilliant ideas were somehow unique to me have been stripped in seeing some of your repos. :)
Good luck with everything.
--
Ken Snyder
On 13 Jul 2017, 20:25 -0700, Scott<EMAIL_ADDRESS>wrote:

@ksnyde There are still a few places where fireadmin is being used in applications that are in production. Others may still depend on it as well, not totally sure (wouldn't be that easy to find out).
Does what your developing have any similarities? Always open to pull requests and updates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Merge the web platform support with mainline Flutter.

To date, the Flutter web platform support has been in its own fork. While you can now build an application for the web using Flutter (see here, doing so causes the flutter tool to pull a bunch of cached artifacts that are forked, rather than directly derived from, the mainline.
This can have numerous unforeseen consequences --- impacts to network use and disk space, and because it's a fork, bugs you expect to be fixed in the mainline for a given channel may still not be fixed in the fork.
Flutter for web remains experimental at least until this is resolved, and in all likelihood longer.

/cc @jonahwilliams

Does this obviate the need to do for developers ?

flutter pub global activate webdev

@gedw99 yes, this would involving having a project import flutter and not flutter_web and using all of the existing flutter tooling.

I cloned the latest repository code, then run hello_world in example, it is blank
Is it because my flutter version is too high? Upgraded 1.8 in the last two days.

flutter doctor -v
[√] Flutter (Channel master, v1.8.1-pre.71, on Microsoft Windows [Version 10.0.18362.239], locale zh-CN)
    • Flutter version 1.8.1-pre.71 at D:\flutter
    • Framework revision b69feb5340 (5 days ago), 2019-07-11 01:56:27 -0400
    • Engine revision 49445ce494
    • Dart version 2.5.0 (build 2.5.0-dev.1.0 09fc76bc51)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at D:\Android\android-sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.0
    • ANDROID_HOME = D:\Android\android-sdk
    • Java binary at: D:\Android\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.1.3)
    • Visual Studio at D:\Program Files (x86)\Microsoft Visual Studio\Community
    • Visual Studio Community 2019 version 16.1.29009.5

[√] Android Studio (version 3.4)
    • Android Studio at D:\Android\android-studio stable
    • Flutter plugin version 36.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] Android Studio (version 3.5)
    • Android Studio at D:\Android\android-studio
    • Flutter plugin version 37.0.3
    • Dart plugin version 191.7830
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at D:\JetBrains\IntelliJ IDEA
    • Flutter plugin version 35.3.3
    • Dart plugin version 191.7221

[√] Connected device (3 available)
    • Redmi 4X • c1f5972a7d74 • android-arm64  • Android 7.1.2 (API 25)
    • Windows  • Windows      • windows-x64    • Microsoft Windows [Version 10.0.18362.239]
    • Chrome   • chrome       • web-javascript • Google Chrome 75.0.3770.142

• No issues found!

I think maybe my dart version is too high.
F:\WorkSpace\Flutter\flutter_web\examples\hello_world>webdev serve
Can't load Kernel binary: Invalid kernel binary format version.
webdev 2.0.5 doesn't support Dart 2.1.1-dev.1.0.

pubspec.yaml
environment:
  # You must be using Flutter >=1.5.0 or Dart >=2.3.0
  sdk: '>=2.3.0-dev.0.1 <3.0.0'

Hi, sorry to interrupt. I have two questions related to the new approach.
(1) I am wondering wether flutter run -d chrome will call webdev in the background or not? If it calls webdev, should I install or update the webdev program manually? OR I can remove webdev completely?
(2) What is the best practice to manage the project for both mobile and web support?
I am thinking of two ways. One way is creating three projects, one for common, one for mobile and one for web. And both mobile and web projects import the common project. Another way is only using one project and use some switch or if tests to determine which platform it's on and then execute the corresponding code. (btw I am not sure how to test the platform for web at present though. It seems TargetPlatform does not have a web value)
Thanks a lot.

@sgon00 regarding how to test the platform for web, I can provide something.
Since http is a cross-platform library in dart, supporting both web environment and native app environment, we could dig into its source code to find out how this is done.
https://github.com/dart-lang/http/blob/master/lib/src/client.dart#L14
Looking at the source code, http lib defines a browser_client.dart for browser env, and io_client.dart for native app, and combine them by conditional import using dart.library.html variable. Using this technique, you could also detect web platform.
Some more info about conditional import: https://medium.com/@dvargahali/dart-2-conditional-imports-update-16147a776aa8

This is done.


Can't parse syntax field (see thread for more details)

I'm not sure where this bug lives, exactly, but it looks like maybe :gpb is throwing up when attempting to parse this file?
https://developers.google.com/transit/gtfs-realtime/gtfs-realtime-proto
I pulled down that file, stuck it into /priv, and wrote the following module definition:
  use Protobuf, from: "priv/gtfs-realtime.proto"
end```

But when I try to compile my code, I get this error:

== Compilation error on file lib/tap/protobuf/GTFS.ex ==
** (ArgumentError) argument error
:erlang.byte_size({25, :gpb_parse, ['syntax error before: ', 'syntax']})
(elixir) lib/exception.ex:106: Exception.format_banner/3
(elixir) lib/exception.ex:141: Exception.format/3
(elixir) lib/kernel/parallel_compiler.ex:216: Kernel.ParallelCompiler.print_failure/2
(elixir) lib/kernel/parallel_compiler.ex:189: Kernel.ParallelCompiler.handle_failure/5
(elixir) lib/kernel/parallel_compiler.ex:182: Kernel.ParallelCompiler.wait_for_messages/8
(elixir) lib/kernel/parallel_compiler.ex:55: Kernel.ParallelCompiler.spawn_compilers/3
(mix) lib/mix/compilers/elixir.ex:112: Mix.Compilers.Elixir.compile_manifest/5

Frustratingly, when I call protoc on that file from the command line to generate a .desc file it works just fine - so I know it's not a malformed input.proto file.

Any idea what could be causing this?

Hi,
I saw your question on slack, seems like the line syntax = "proto2"; causes the problem. Removing that line helped me to compile the module. Not sure what the effect is of removing that line (will it be able to process / decode data), but it gives you a hint.
Hope that helps.

thanks! Can I ask how you were able to identify that line as the culprit?

was gonna try to write some failing tests but the whole thing just crashes and exists with that syntax field even in the module def so I'm gonna say that's a gpb issue...?

The syntax declaration isn't part of the proto2 spec, as far as I can tell. I think it might have been something they added to the proto3 spec.
I think it's an upstream issue, since gpb is responsible for parsing.

@mbilokonsky @koudelka  Yeah looks like it was added here. I'm not sure what the status of proto3 support is in gpb at the moment, but any issues related to the parser would have to get fixed upstream before we can support it in exprotobuf :(

:+1:  having this issue as well, even after I removed syntax, some portions of our codes contain elements that can't be parsed, e.g. extend. Hope this can be fixed soon. I'm gonna do some investigation as well.

@tommyogp Definitely hit up the gpb repo and open an issue requesting proto3 support, until it's supported upstream, there isn't much I can do on this :(

Looks like proto3 is now supported by gpb. Can we expect update of this repo as well?

The latest release contains the latest release of gpb. I'll close this for now. Please open up specific issues as needed if things are still missing.

@bitwalker How about publishing a new version? I need gpb 3.24 :)

@tony612 done :)

@bitwalker 👍  Thanks! ❤


feat: IsSingleAnnView fix, canConfirm check for the review button from the HumorInput and OffensiveInput components

What's changed:

frontend/components/layout/TheSideBar.vue: showing the annotation button in the sidebar when the project is not affective annotation
frontend/components/tasks/affectiveAnnotation/*/*.vue: added isChanged and isSubmitting flags for scales, added canConfirm flag for the HumorInput and OffensiveInput. Now the user can only confirm when they have:
--- Changed at least one of the sliders to any value. They may also confirm when they changed the slider to 0 again
--- If they have changed one of the sliders and they clicked one of the checkboxes, they can only confirm when they have filled the textbox under the checkbox, if they are present
frontend/components/tasks/sequenceLabeling/EntityEditor.vue: added the readOnly property, show the labeling menu only when its not in read only mode
frontend/components/tasks/toolbar/buttons/ButtonPagination.vue: remove the jump title
frontend/pages/projects/_id/affective-annotation/index.vue: changed the isSingleAnnView check to isAffectiveAnnotation check; canConfirm check, removed unnecessary components
frontend/pages/projects/_id/dataset/index.vue: disabled the button when the project has no items

Screenshots:

Hello, I have tested your changes and I think it's oke now XD
About the new dimension added in the gdoc I think we can just add it, probably he forgot to remind us about the changes :sweat_smile:

Hello, thank you for pointing out about the changes in the doc and also the difference in behavior. About the doc, I don't know when it was added as well, but I will add it later. As for the behavior, this PR was made before the previous PR was merged, so of course the change introduced in the previous PR (the alert)  was not integrated  :)   I will work on them later and fix the conflicts.

Hello everyone, I have added the new dimensions as well as removed the disabled property and used the alert instead. I also adjusted the alert conditions a bit XD can you check


Add Lingvo test runner to CI

Description
This PR adds a Lingvo test runner to the CI pipeline. All tests related to Lingvo, require a specific version of tensorflow (2.1.0), Lingvo (0.6.4) and Python 3.6.
Note, the new test runner will run all tensorflow2v1 flagged tests.
Fixes #707
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)

Test Configuration:

Fedora 33
Python 3.6

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks for suggesting the two changes. I fully agree with them and have applied the PR accordingly :+1:


Tested with Dune.

Voices are weird, probably a fault on my end in the SoundBlaster class when reverting the code.


Add a robots.txt to make dfoto.se a bit harder to find

Some sources:
https://support.google.com/webmasters/answer/6062608?hl=en
https://en.wikipedia.org/wiki/Robots_exclusion_standard#About_the_standard
Example of robots.txt that probably does what we want
User-agent: *
Disallow: /

Fixed in https://github.com/dtekcth/dfotose/commit/c705bf5d27728d49a6c5031df5fbdfa0413c1e85
Closing Issue


covectors and differentiable vectors

This adds differentiability to the vector abstractions in https://github.com/borglab/SwiftFusion/pull/70.
We need covectors to define pullbacks of vector space operations, so I also added covectors.

All checks failed? :-)

@dellaert Looks like a GitHub issue, I restarted the build

@dellaert Test is successful

Closing because this turned out not to be important for the initial generic factor graph work. We should revisit eventually.


WIP - Llama code interpreter and improved LLM as a judge

This is still work-in-progress, but want to push to allow other people to provide suggestions and reuse the code while we are ironing out the details.
The current implementation does not have a proper integration for llm-as-a-judge - this requires a larger refactoring which I will try to do next week.
It also breaks openmathinstruct-1 backward compatibility which is probably fine since people can always switch back to the v0.1.1 tag and we can't support that code forever as we move to the new format with llama models

Merged in igitman/refactoring branch


"Hub Operator FID is not set" via docker even already set in .env

happens the same here, does anyone have a work around?

Workaround implemented in #2129.


Add new plugin 'placeholdifier'

Fixes #462
Adds placeholdifier as a new plugin. Iterate through all the elements that are children of the <body> and then add the class 'placeholdify' to each element.
The command 'placeholdifier' would select all the elements inside the body and add 'placeholdify' to each classList creating the live wireframe effect.
Recording
https://user-images.githubusercontent.com/48612525/195524427-e634b02b-9187-4bc3-95ea-390b0155fee8.mov
Resources

https://github.com/pomber/placeholdifier
https://codepen.io/tannerdolby/pen/YzLBqyX

oh cool, this is fun! thanks for the plugin suggestion, it fits right in 🙂
there's some instructions on adding plugins here that will help you get the plugin integrated so visbug can execute it and describe it to users: https://github.com/GoogleChromeLabs/ProjectVisBug/wiki/Plugins
i went ahead and pulled your plugin, added the items into the registry, and then invoked the plugin on the test page ANDDDDD... the font files didnt load. so i peeked at the css file that was injected and the fonts aren't remotely served.. they're locally served.
@font-face {
  font-family: "Placeholdifier";
  src: url("./placeholdifier.woff2") format("woff2"),
    url("./placeholdifier.woff") format("woff");
  font-weight: normal;
  font-style: normal;
}

i'm not sure how the codepen or the plugins jsbin are working since i can't find the woff files uploaded to either of those demo environments. thoughts on this?

awesome, no problem! 😎
thanks for sharing the plugins guide, I had a look and updated things so its fully integrated now
ahh nice, ty for pulling things in and tinkering. I noticed the same behavior where the font files aren't loading after invoking the plugin on the test page when using await loadStyles(['unpkg..']) to inject the styles - its interesting the font files are locally served. Going to do some investigating and report back.
When I just throw the link into the <head> of ./app/index.html,
<link rel="stylesheet" href="https://unpkg.com/placeholdifier/placeholdifier.css" >

font files load successfully and the plugin performs as expected.
https://user-images.githubusercontent.com/48612525/195929215-c914ccba-9a4e-4ba9-8269-b8ff20fe7b39.mov
The JSBin example https://jsbin.com/tuyecacebi/edit?html,output just adds the <link> onto the page so the only difference for us here is that were using loadStyles to inject the CSS from unpkg instead of just adding it to the index.html file.

looks like the optional chaining is causing issues for the tests https://github.com/GoogleChromeLabs/ProjectVisBug/actions/runs/3253135144/jobs/5340105712
will update that right now

if this PR runs the tests, then you could just update from main when it's merged and then it should be g2g. looks like it was time to update that test runner env anyway

PR is merged. update to latest and let's hope this tests pass, then we can merge this 👍🏻

cool! Just saw that ticket for updating the test runner. I pulled on main and didn't see any diff but I should be synced with latest now. The tests didn't kick off for my latest commit , looks like it needs approval https://github.com/GoogleChromeLabs/ProjectVisBug/actions/runs/3253183510

fully up to date with the latest main 👍

poo, they failed like they didnt use the updated yaml action

i guess just drop the optional chaining so we can get this merrrrrrged?

yeah, dropping the optional chaining seems like the best move. I added a small defensive check inside the .filter() call to mimic the optional chaining just in case for some odd reason an element during the iteration is indeed undefined and/or doesn't have a tagName property.
thank you for your review on this!

great work! i'll try and kick out a release and get it uploaded today, and gauging their current approval cadence, then tomorrow it should be available

live on the demo site already tho 👍🏻

submitted for review on chrome web store 👍🏻

thank you! okay awesome, I had a look at the demo site and its working great 👍🏻
let me know if you need anything from my end in the meantime!

heck ya! thanks again for allowing the contribution, visbug is a really neat project 🚀


Always parse all dependencies, ignoring is_mlvl

I'm doing that. It's just I probably deleted too much and broke something, so I'm doing it again slowly


Run tests and linting for phone-number-privacy svc

Description
Adding a section to automate testing/linting for phone number privacy service.

You can view the new CircleCI step here:
https://app.circleci.com/pipelines/github/celo-org/celo-monorepo/16932/workflows/ee8a45dd-cab9-4f7a-81fe-41e2ec619823/jobs/178526


tests: add tests for sip keywords

Tests for https://github.com/OISF/suricata/pull/4025

Tests sip-request-line and sip-response-line currently fail.  The expected pcap file isn't found.


Add model parameters to safe parse of distribution parameters

Sympy expressions of distribution parameters may contain model parameters as free variables.
Therefore, this line:
https://github.com/gyorilab/mira/blob/e559f4664abb3f59c019d86c9f3bc112420f6cdf/mira/sources/util.py#L191-L193
should be:
            elif isinstance(param_value, str):
                processed_distr_parameters[param_key] = \
                    safe_parse_expr(param_value, local_dict=param_symbols)

This PR passes  param_symbols to the safe parse of distribution parameter expressions.  This will support the representation of multi-level models.

Thanks, not using param_symbols there was my mistake so it's great that you noticed this!


[Q] events and code files not uploaded

Hi, I'm new to wandb and is running code in ppo-implementation-details following the video tutorial Part 1 of 3 — Proximal Policy Optimization Implementation: 11 Core Implementation Details.
The related code in the ppo.py are shown as follows
    if args.track:
        import wandb
        wandb.init(
            project=args.wandb_project_name,
            entity=args.wandb_entity,
            sync_tensorboard=True,
            config=vars(args),
            name=run_name,
            monitor_gym=True,
            save_code=True,
        )

I ran python ppo.py --track --capture-video and saw the media uploaded, but found no events and code files on the wandb website console so that there is not any loss plot online.
Specifically, I got the logs
wandb: Waiting for W&B process to finish... (success).
wandb:
wandb: Synced CartPole-v1__ppo__1__1662611168: https://wandb.ai/carlos-shi/ppo-implementation-details/runs/y7wbggib
wandb: Synced 6 W&B file(s), 4 media file(s), 0 artifact file(s) and 0 other file(s)
wandb: Find logs at: .\wandb\run-20220908_122611-y7wbggib\logs

But in the tutorial video, the expected log after running the same code is  like wandb: Synced 6 W&B file(s), 4 media file(s), 0 artifact file(s) and 2 other file(s), which seems to me that the event and code files are not uploaded.
I also ran tensorboard --logdir .\runs\CartPole-v1__ppo__1__1662608133\ and checked the logs were written correctly.
I'm on PyCharm Windows 10, with Python 3.8.13 and wandb 0.13.2. Any help would be greatly appreciated.

Hi @CarlossShi thank you for reporting this and providing all these details. Can you please try running the code again by disabling cuda and also specifying the project name and entity details as follows:
python ppo.py --track --wandb-project-name ppo-implementation-details --wandb-entity carlos-shi --cuda False --total-timesteps 100000
Please let me know if that would work? if so, you can also try with cuda enabled next.

Hi, thanks for your quick response! I ran both python ppo.py --track --cuda false and python ppo.py --track --wandb-project-name ppo-implementation-details --wandb-entity carlos-shi --cuda False --total-timesteps 10000 on Windows 10 and WSL2 Ubuntu 20.04.4 LTS. I made the project public on https://wandb.ai/carlos-shi/ppo-implementation-details. The problems on Windows still exist and are summarised below.
On Windows 10

I need to repeatedly input the key in each run. It seems that the directory C:\Users\USERNAME/.netrc is not detected by wanb, which I think is a path problem on Windows that would also cause the uploading problem. I found the key problem can be manually fixed by adding a line os.environ["WANDB_API_KEY"]
There is no Run history and Run summary output on the terminal. The content of wandb-summary.json is {"_wandb": {"runtime": 8}}
I can find the local ppo.py file located in wandb\run-20220909_101714-144qbg8p\files\code\ppo.py, but have no idea why it is not uploaded. This is the only difference between local files and online files.
Events file exists in runs\CartPole-v1__ppo__1__1662608133, but is missing both locally (in wandb\run-20220909_101714-144qbg8p\files) and also online,

On WSL2 Ubuntu 20.04.4 LTS, everything goes fine except the upload of code. Specifically, I can find ppo.py locally but not online, which is the same as the situation I face on Windows.
Using WSL2 kind of resolves my problem, but I hope there are some ways I can try it on Windows.

Hi @CarlossShi thanks for the additional detailed information! For Win 10 are you running the code in cmd? have you tried with Jupyter notebook? would that work for you?
Regarding the code uploading, have you enabled from https://wandb.ai/settings the option for code saving in your personal account?

Hi @thanos-wandb, thanks for your suggestions! I have solved all my problems.

I ran the code in PyCharm terminal when I met the problem. But when I run the code in cmd with admistrators, the events file is finally uploaded as expected.
The code file is also uploaded correctly after I turn on the code saving option. Forgive my carelessness.

Hey @CarlossShi thank you for writing how this was solved, and great to hear everything now works for you! I am closing the ticket for now, but please feel free to re-open it if you have any additional questions or issues with this.


API delegering - org no not crossed out when deleting

Go to delegations overview page where org has delegated APIs
Click on Rediger tilgang ang click on Slett corresponding to org
The whole content is crossed  out, except the org no
Wondering if org no should also be the same?

@rtafj @jonkjetiloye @Albertlarsen @allinox

I'll fix this in #230

#230 er lukket så vi lukker denne også.

@anishastphen tester du denne ved anlegning?

testet ok


Unwanted positionchange through VRTK_RotateObjectControlAction

Environment

Source of VRTK: Github
Version of VRTK: release/3.3.0-alpha (e43089a4dbefba55af2716d22de31458e0b615ca)
Version of Unity3D (e.g. Unity 2017.3.0f3)
Hardware used (e.g. Vive)
SDK used (e.g. SteamVR)

Steps to reproduce

Pull latest from feature branch 3.3.0-alpha

Open Example scene 017_CameraRig_TouchpadWalking

Enable SteamVR SDK (download, enable, populate)

Select [VRTK_Scripts]>PlayArea>LeftController>TouchpadControlOptions

Disable GameObject "XAxis = Slide  -  YAxis = Slide"

Enable "XAxis = SnapRotate  -  YAxis = Slide" (or another rotate one)

Start scene, use touchpad to rotate and observe global position of [VRTK_SDKManager]>SDKSetups>SteamVR>[CameraRig]>Camera (eye)

Expected behavior
No matter where the real player stand inside of the PlayArea, a rotation should only rotate the player without changing player's global position.
Current behavior
Depending on where the real player stand inside of the PlayArea, the rotation not only rotates the player (Camera (eye)) but also changes player's global position (because [VRTK_SDKManager]>SDKSetups>SteamVR>[CameraRig] gets rotated).
I would like to fix that by reposition [VRTK_SDKManager]>SDKSetups>SteamVR>[CameraRig] accordingly.
Therefore I suggest to push to the master branch.
If you do not consider this behaviour as a bug, I suggest to implement a feature (public flag on these scripts to enable repositioning) and target the release/3.3.0-alpha branch.

I've noticed this in the current release. I believe the headset is being rotated using the playspace's centre point as a pivot.
So, if the headset is in one corner of the playspace, and snap rotate is triggered, the headset's position can be dramatically changed instantly -- in my case, this causes players to move completely through virtual walls rotating near them.
I'm using an Oculus CV1 w/ Touch Controllers, the current SteamVR Unity Plugin (1.2.3 aka 54), the current release of VRTK (3.2.0), and Unity 2017.3.0f3 Personal. Windows 10.

@LuckyJosun Use VRTK 3.3.0.

@bddckr thanks for your reply, I didn't realise. I was using the version from the asset store (listed as 3.2.1). The asset page says it is compatible with "5.5.3 or higher", but I presume that text is unchangeable. I've grabbed the current state of 3.3.0-alpha now, and will work with that going forwards, updating as necessary.
I've also checked if this issue exists in 3.3.0-alpha on my machine, it does. I've experimented with it a little more, and it looks as though the rotation pivot isn't the centre of the playspace - it's the starting position of the headset.
To reproduce, follow @RunenGamer 's steps above, but replace step 7 with:
Physically place your headset in one corner of your playspace, start scene, physically carry your headset to the opposite corner of your playspace, then the use the right touchpad/stick to rotate the player observing the global position of [VRTK_SDKManager]>SDKSetups>SteamVR>[CameraRig]>Camera (eye)
On my machine, this drastically changes the position of the player with each rotation.

Edit: It looks like the scene view isn't showing the camera move, but it is very noticeable inside the headset.
If you look at the headset's transform you can see the position change.

@thestonefox Do you want to confirm the bug or does these two observations confince you, so that I can make a PR with the fix?

feel free to make a pr

@thestonefox Thank you. I will work on it. I will make a PR by sunday or earlier.

This is fixed in current master.
@thestonefox


Repo substitution

It would be useful to have {repo} available as a substitution to enable the use of template jobs 'across' repositories.

Hello and sorry for the late reply. As of commit f199b5f6d503281601e6a9676a5dd262f8ab1d96 and version 0.15.1, the repo and repo-orig placeholders are available to the namefmt and substitute options.
Please close the issue if this functionality satisfies your use case. Thanks!


Fix version bumper

Currently, if you open a PR and another PR gets opened and merged in the meantime, it will not correctly detect that it needs to bump the version again.
This change makes it so that it always tries to bump the version number directly from current master, and then tries to commit and push the results, instead of trying to detect if the version needs to be bumped by comparing against current master.

It worked: