update whatsnext

RHTAPBUGS-303: removing the last instance of 'stonesoup' and suggesting a rewording of the 1st whats-next.
Reviews incoming. Please, don't merge.

/ok-to-test

RHTAPBUGS-303: it was decided to revisit the content later, now I should only remove stonesoup. Ready to merge.

@Hyperkid123 I merged without asking you since it was a small PR with only a couple of words changed, I bet it won't break anything. Thanks.


Rewrite chain to use flow

Description
Rewrite seq.chain in order to use flow and avoid code duplication.

Chain has been removed in #197


Less Information on How to use Config

[Enter feedback here]
I want to use ProfanityOption in speech to text but there is no code example is given only the parameter name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec25627d-5ad1-de7c-9682-fd57f5ce0243
Version Independent ID: 46120212-86f0-b744-d329-ce3c0849cbd3
Content: azure.cognitiveservices.speech.ProfanityOption enum
Content Source: docs-ref-autogen/azure-cognitiveservices-speech/azure.cognitiveservices.speech.ProfanityOption.yml
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

thanks @Srkshaikh5 for your feedback and yes, we should definitely improve the doc experience. The team working on the cognitiveservice.speech SDK should be able to help with it.

@Srkshaikh5
Similar to speechConfig in the sample code they give in their documentation, you want to first create a variable that will be used as the setting for Profanity. I created a variable and named it setProfanity.
From here you want bring up the ProfanityOption class, which is also included in the documentation. ProfanityOption has 3 functions within this class.
ProfanityOption::Masked | [0]
ProfanityOption::Raw | [2]
ProfanityOption::Removed | [1]
You now want to set your newly created variable as one of these options.
Example Code :
auto setProfanity = ProfanityOption::Raw;
Now you're almost done. What's left is to point the new setting to the configuration. How you want to do this is very similar to when you set your speech recognition language.
Example Code :
speechConfig -> SetProfanity(setProfanity);
You can think of this as changing settings in a game or a application. You go into settings and from there you have sub-menus. SetProfanity is one of these sub-menus. Within the parentheses is the new variable you created.
So all together it may look something like this :
auto setProfanity = ProfanityOption::Raw;
speechConfig -> SetProfanity(setProfanity);
I had difficulty figuring this out too. I just figured it out and wanted to share as I tried looking for the answer online and saw this thread.
Hope this helped!
Spiro-001


Wrong release notes for v2.3.1

Not a big issue, but v2.3.0 and v2.3.1 release notes are the same.
https://github.com/vue-generators/vue-form-generator/releases/tag/v2.3.0
https://github.com/vue-generators/vue-form-generator/releases/tag/v2.3.1

https://github.com/vue-generators/vue-form-generator/compare/v2.3.0...v2.3.1

Also, first line of https://github.com/vue-generators/vue-form-generator/blob/master/CHANGELOG.md should be 2.3.1

@qkdreyer thanks, we'll correct that with 2.3.2 release...

Updated release notes on GitHub to reflect correct changes


Cluster Not showing up in FailOver Cluster Manager on the Node

Hi team,
I tried deploying this quickstart with SQL 2017/2019 with launching into an existing VPC(given that VPC networking configs were perfect as expected and were automatically set up by Active Directory Domain Services on AWS quickstart using Scenario 3 with into a new VPC option)

Stack was created successfully with SQL 2017.
Stack failed with SQL 2019.

However, upon performing Post-Launch Steps:
With SQL 2017:

Running Get-ClusterGroup for the second time started showing status for "Cluster Group" as PartialOnline.
Manually, trying to connect to Cluster by using name WSFCNode1 through "Failover Clustering Manager" fails with error "AccessDenied".
Running "Validate a Configuration" wizard and loading WSFCNode1 and WSFCNode2 on WSFCNode1 itself also fails with error as "You do not have Administrator privileges for WSFCnode2.

With SQL 2019:

Stack creation failed on waiting for SSMWaitCondition resource with error message as "Received FAILURE signal with UniqueId instance_id.
Stack remained in CREATE_IN_PROGRESS for more than 2 hours.
Upon logging into the respective instance, I couldn't find any logs at following locations as well

%ProgramFiles%\Amazon\EC2ConfigService
C:\cfn\log

Ask:

Please help in troubleshooting as I don't have enough insights into what's missing.
Also, this quickstart is a hard dependency for SharePoint Server on AWS quickstart so please identify and release fix asap.

Thanks,

Hi @razhamma , I’m facing the same issue. May I know how did you fix that?

Hi @johnkennady04, have you tried this -> SQL Server with Always On Replication on the AWS Cloud
Quick Start Reference Deployment.
Looks like a new updated guide dropped just a few days ago.

Yes I tried.

Have you found the solution?
Im facing the face problem.
When I run the powershell comands I see the cluster and all the nodes up. When I ran the failover cluster manager I cant see the cluster: "an error occurred trying to display the cluster information. access denied 0x80070005"


2FA QR code not visible in email sent to new user

Maybe I'm missing something...
When I create a new certificate using MFA and generate an email to send to the new user, the QR code is not included in the email.
How does the user get the QR code to put into their authenticator app?
There is also no attachment containing the .ovpn file.  Maybe it has something to do with using Gmail?

Hey @ericraskin you are not missing, this is limitation on mailto: protocol.
In short, to automatically copy-paste QR code we have to implement own mail server which overcomplicate that project.
Similar issue #39
I just copy and paste QR code to email body.


Add support for libvirt

I much prefer libvirt vs. virtualbox. @vishnu2kmohan don't you have a branch for this kicking around somewhere?

Moved to https://dcosjira.atlassian.net/browse/DCOS-27

I know that this is closed, but @jdef there is a plugin for vagrant called 'vagrant-mutator' that might be of interest to you. This will convert virtualbox vagrant boxes to libvirt for you. You may also need to comment out part of the Vagrantfile that specifies the URL and Version forcing vagrant to use the box converted by the mutator plugin.


Question about MosMedData+

Hi,
The link you provided (http://medicalsegmentation.com/covid19) contains 100 axial CT images+9 volumes+20 volumes, but MosMedData contains 50 annotated volumes. I did not figure out why a smaller dataset (MosMedData+) includes a larger dataset (MosMedData). Can you provide any reference that describes MosMedData+ dataset and claims that it includes MosMedData?
Thanks.

Hi, MosMedData+ contains some data from the MosMedData, so we call it MosMedData+.

Hi, MosMedData+ contains some data from the MosMedData, so we call it MosMedData+.

Hi, from my understanding, there is no overlap between MosMedData and MosMedData+. Could you please elaborate which parts of MosMedData+ is from MosMedData? Thanks!

Hi, The link you provided (http://medicalsegmentation.com/covid19) contains 100 axial CT images+9 volumes+20 volumes, but MosMedData contains 50 annotated volumes. I did not figure out why a smaller dataset (MosMedData+) includes a larger dataset (MosMedData). Can you provide any reference that describes MosMedData+ dataset and claims that it includes MosMedData?
Thanks.

Hello! I am in the same trouble. Have you figured out this problem?


Add Sqlite support for the RETURNING clause

Add Sqlite support for the RETURNING clause by leveraging
the implementation for Postgres. So this change is essentially
just adjusting the build system to enable the support if a
Sqlite version which supports the RETURNING clause [1] is
complied against.
The "insert record with returning" unit tests for Postgres
couldn't be re-used because Sqlite doesn't support batch insert.
Because those tests provide value for Postgres, new versions
for Sqlite have been created which don't use batch insert.
[1] https://sqlite.org/releaselog/3_35_0.html

The tests currently pass but they never run with the returning_clauses_for_sqlite_3_35 feature enabled. What is a good test candidate to enable that feature?

The tests currently pass but they never run with the returning_clauses_for_sqlite_3_35 feature enabled. What is a good test candidate to enable that feature?

That's exactly the issue with adding more features. Theoretically that expands test matrix with an additional dimension. That would mean we need to run all tests with this feature enabled and with the feature disabled. That will not work practically.
The best workaround that I see is to use one of the rust channel, for example the beta channel and enable the flag only there.

That's exactly the issue with adding more features.

Agreed. Sqlite's commitment to backwards compatibility is a blessing and a curse at the same time. I wish they would at least define which minor versions can be treated as EOL. For example the suggested workaround above using CTE also runs into a similar issue because CTE is only available from a certain version on.

The best workaround that I see is to use one of the rust channel

Sometimes, the best solution is a pragmatic one :)

I get compilation errors when working on your branch:
$ cargo build
error[E0277]: the trait bound `ReturningClause<(columns::id, columns::name, columns::hashed_password)>: QueryFragment<Sqlite, DoesNotSupportReturningClause>` is not satisfied
  --> src/routes/auth.rs:46:14
   |
46 |             .get_result(conn)
   |              ^^^^^^^^^^ the trait `QueryFragment<Sqlite, DoesNotSupportReturningClause>` is not implemented for `ReturningClause<(columns::id, columns::name, columns::hashed_password)>`
   |
   = help: the following implementations were found:
             <ReturningClause<Expr> as QueryFragment<DB, PgLikeReturningClause>>
             <ReturningClause<Expr> as QueryFragment<DB>>
   = note: required because of the requirements on the impl of `QueryFragment<Sqlite>` for `ReturningClause<(columns::id, columns::name, columns::hashed_password)>`
   = note: 1 redundant requirement hidden
   = note: required because of the requirements on the impl of `QueryFragment<Sqlite>` for `InsertStatement<table, ValuesClause<(DefaultableColumnInsertValue<ColumnInsertValue<columns::name, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>, DefaultableColumnInsertValue<ColumnInsertValue<columns::hashed_password, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>), table>, diesel::query_builder::insert_statement::Insert, ReturningClause<(columns::id, columns::name, columns::hashed_password)>>`
   = note: required because of the requirements on the impl of `LoadQuery<'_, SqliteConnection, _>` for `InsertStatement<table, ValuesClause<(DefaultableColumnInsertValue<ColumnInsertValue<columns::name, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>, DefaultableColumnInsertValue<ColumnInsertValue<columns::hashed_password, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>), table>>`

error[E0277]: the trait bound `(i64, std::string::String, std::string::String): FromStaticSqlRow<(diesel::sql_types::Integer, diesel::sql_types::Text, diesel::sql_types::Text), Sqlite>` is not satisfied
  --> src/routes/auth.rs:46:14
   |
46 |             .get_result(conn)
   |              ^^^^^^^^^^ the trait `FromStaticSqlRow<(diesel::sql_types::Integer, diesel::sql_types::Text, diesel::sql_types::Text), Sqlite>` is not implemented for `(i64, std::string::String, std::string::String)`
   |
   = help: the following implementations were found:
             <(T1, T2, T0) as FromStaticSqlRow<(ST1, ST2, ST0), __DB>>
note: required because of the requirements on the impl of `Queryable<(diesel::sql_types::Integer, diesel::sql_types::Text, diesel::sql_types::Text), Sqlite>` for `User`
  --> src/db/auth.rs:11:10
   |
11 | #[derive(Queryable)]
   |          ^^^^^^^^^
12 | pub struct User {
   |            ^^^^
   = note: required because of the requirements on the impl of `FromSqlRow<(diesel::sql_types::Integer, diesel::sql_types::Text, diesel::sql_types::Text), Sqlite>` for `User`
   = note: required because of the requirements on the impl of `CompatibleType<User, Sqlite>` for `(diesel::sql_types::Integer, diesel::sql_types::Text, diesel::sql_types::Text)`
   = note: required because of the requirements on the impl of `LoadQuery<'_, SqliteConnection, User>` for `InsertStatement<table, ValuesClause<(DefaultableColumnInsertValue<ColumnInsertValue<columns::name, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>, DefaultableColumnInsertValue<ColumnInsertValue<columns::hashed_password, diesel::expression::bound::Bound<diesel::sql_types::Text, std::string::String>>>), table>>`
   = note: this error originates in the derive macro `Queryable` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0277`.
error: could not compile `blanch-server` due to 2 previous errors

@mainrs it's impossible to tell what your issue is when you only share the error output. You should provide a complete and preferably minimal example if you want to receive meaningful help. See here to learn more.

@toxeus The currently minimal supported sqlite version is 3.20.0. This is defined by the binary interface we use (In detail the sqlite3_prepare_v3 function). CTE's are supported since 3.8.3, so much longer. That wouldn't be a problem.
That written: I've tried the statement I've suggested above and I didn't manage to get sqlite to accept the corresponding SQL at all. It seems like you cannot have a insert statement in a CTE expression as part of the WITH clause.
That means the only option that is left is adding a feature flag for this feature.

As discussed above, I have enabled the feature on the beta channel so we have some test coverage.


hybrid interaction discovery

effectful 'addInteraction' ... methods removed
hybrid interaction implementation - underway

Codecov Report

Merging #744 (33c8078) into master (9daf336) will decrease coverage by 0.67%.
The diff coverage is 44.85%.

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   80.96%   80.28%   -0.68%
==========================================
  Files         130      130
  Lines        4533     4566      +33
  Branches      100       96       -4
==========================================
- Hits         3670     3666       -4
- Misses        863      900      +37

Impacted Files
Coverage Δ

...la/com/ing/bakery/baker/InteractionDiscovery.scala
0.00% <0.00%> (ø)

...rcontroller/controllers/ControllerOperations.scala
77.35% <0.00%> (ø)

...g/bakery/interaction/RemoteInteractionLoader.scala
0.00% <0.00%> (ø)

.../bakery/interaction/RemoteInteractionService.scala
78.57% <ø> (ø)

...runtime/akka/actor/ClusterBakerActorProvider.scala
12.19% <ø> (ø)

...r/runtime/akka/actor/LocalBakerActorProvider.scala
100.00% <ø> (ø)

...ain/scala/com/ing/baker/runtime/model/BakerF.scala
40.59% <ø> (-0.70%)
:arrow_down:

...la/com/ing/baker/runtime/model/RecipeManager.scala
92.30% <ø> (ø)

...com/ing/baker/runtime/inmemory/InMemoryBaker.scala
37.50% <50.00%> (ø)

...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala
75.75% <60.00%> (-1.45%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9daf336...33c8078. Read the comment docs.


Enable additional pylint checks

I ran pylint in its default configuration, and I noticed some additional checks that might be useful to us.  We should investigate whether turning each of these on will benefit us.  There is currently at least one example of each of the following violations in the code base.

[ ] consider-using-generator
[ ] consider-using-f-string
[ ] unidiomatic-typecheck
[ ] wrong-import-order
[ ] wrong-import-position
[ ] unnecessary-comprehension
[ ] no-else-return
[ ] arguments-renamed
[ ] consider-using-enumerate
[ ] unnecessary-lambda
[ ] consider-merging-isinstance

We'll need to disable wrong-import-order and wrong-import-position on the notebooks, as we deliberately import things right before we use them in the docs. But that will be easy because they are actually processed in a separate call to pylint:
https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/67f24cb4e8e067eebad1f351ce971df8dc115f61/tox.ini#L33


No GSO when heater on. Not haapy, Jan

Seeing consistent error in logs. Also seems to be slowing HA down when integration is installed. with scripts and automations triggering much slower across all of HA.
Any ideas on solution?

Try with 0.11.3. These issues should now be fixed


Remove Alpha Watermark

Describe the problem
All pages have a water mark, CRISIS CLEANUP (PREVIEW) - V3.0.0-ALPHA85+8ECB003, which is unnecessary now. However, we still want a way to confirm the release version.
Describe the solution

Remove the watermark completely.
Add the release ID (e.g. "8ECB003") in a place that is visible in the comments of the source code (e.g. when you View Source in the browser).

Additional context and instructions
Add any other context or screenshots about the feature request here.

How about adding the hidden comment then just hiding the watermark in production?

If we need a way to confirm the version that is live, then hiding in production won't help. But if we don't need to confirm the live version, then we should get rid of it all together.


Fix support for non-latin filenames

There is a problem with non-latin title and author. For example Cyrillic filename Название (1964) Фамилия Имя.pdf with original code become   (1964)   .pdf. Which isn't expected behavior because there is a lot of books in Russian with Russian filenames.
So this pull request fixes this issue with migrating from filter non-latin characters to filter non-alphabetic characters (in UTF sence).

Hi. Thank you for this contribution. Merging.

Great thanks!


Fix #193151. Add IFileSystemProviderWithOpenReadWriteCloseCapability to FileUserDataProvider

The only two file system providers being passed to FileUserDataProvider is either the disk one or the in memory one. The former already supports IFileSystemProviderWithOpenReadWriteCloseCapability thus in this PR we added the capability to the in memory file system provider

or when a file is changed not through an editor that has a ITextSnapshot but programmatically where the entire buffer is passed in (which I believe is most often the case with user data).

@bpasero Is it also true if programmatic save goes through ITextFileService.save ?
https://github.com/microsoft/vscode/blob/0b08c9ad9c758f24effb9d92aabba47eb58818a3/src/vs/workbench/services/textfile/common/textfiles.ts#L60

@sandy081 no. But I think a better solution is to stop overriding the file system provider and do what I had suggested in https://github.com/microsoft/vscode/issues/193151#issuecomment-1722765736

In this case, I would not suggest this change. It is important to have atomic write for user data like settings and extensions.

This is ready for review.


Can't find the right combination of devId & localKey

Hi there, when trying to find the devId/LocalKey combo, I can't seem to find exactly what's needed. Looking at the log file, I have the following

device_key --> 16 digits alphanumeric
local_code --> 16 digits alphanumeric
device_id --> 36 digits alphanumeric (including 4 dashes - )

These are the only things I can find in the logs, but no combinations of those actually result in a successful connection.
Any ideas?
To add more context, I'm using the latest version of Bluestack on Windows 10 and using the linked APK for the EUFY Home app

No need to make the same issue/comment in 3 different places. deleted 1 comment, closing this.  Will assist on https://github.com/joshstrange/eufy-robovac/issues/13


fix: add to refund_assets attr in provide liquidity

Summary of changes

Report of required housekeeping

[ ] Github issue OR spec proposal link
[ ] Wrote tests
[ ] Added a relevant changelog entry to CHANGELOG.md

(FOR ADMIN) Before merging

[ ] Added appropriate labels to PR
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
[ ] Confirm added tests are consistent with the intended behavior of changes
[ ] Ensure all tests pass

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (3eeae88) 88.29% compared to head (ac4d6b6) 88.31%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v1.2.x      #16      +/-   ##
==================================================
+ Coverage           88.29%   88.31%   +0.02%
==================================================
  Files                  14       14
  Lines                2648     2653       +5
==================================================
+ Hits                 2338     2343       +5
  Misses                310      310

Impacted Files
Coverage Δ

contracts/starfleit_pair/src/contract.rs
93.70% <100.00%> (+0.08%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PLT-5268 Always show link previews on comment threads in right-hand sidebar

Summary
Added previewCollapsed selector as connected props for rhs_thred
Removed PostBodyAdditionalContent component for searchResults.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/7542
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Has redux changes (please link)
[x] Has UI changes

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@sudheerDev looks like there's a build failure, please help take a look?

Spinmint test server created at: http://i-08a90a99a729b9196.spinmint.com:8065/pr91
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-08a90a99a729b9196

@jasonblais Ya, of course, I will have a look. Might take a day or two. One thing though what is the URL for Jenkins build Or how can I run build locally?

@sudheerDev Thanks!
Looks like the Jenkins URL is broken, I believe @crspeller is looking into it.
Not sure if this page would help run the build locally? https://docs.mattermost.com/developer/dev-setup.html

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0d89d302f462bd8f7.spinmint.com:8065/pr91
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0d89d302f462bd8f7

@sudheerDev, let us know if you need any help with the requested tweak ^

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0eb873df7595180b8.spinmint.com:8065/pr91
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0eb873df7595180b8

Spinmint test server destroyed

@sudheerDev This is now ready to merge once the PR build pass.


App crash

Game closes after start like other peoples describe it here

Hello. A logcat is required to precisely understand what causes the crash. I can look into it if you dump it here.
With that being said, I currently have 2 games live on Google Play with about 4000 active players and in both these games I use this plugin and the crashrate is non-existent (and is not caused by any of the plugins I use, but by Godot-related issues).
Try checking the following:

In your game's config.gradle (project/android/build directory), make sure that:

compileSDK is 31 (this is required for Appodeal 3.x.x SDK)
minSDK is 21 (this is the minimum for Appodeal 3.x.x SDK)
targetSDK is 30 (because Godot currently doesn't fully support Android API level above 30 out of the box)

Try rebuilding the plugin for your Godot version.
I use Godot 3.4.4 and the plugin's AAR was built with Godot 3.4.4's export template. Rebuilding is extremely easy, just grab this repository and run .\gradlew build from plugin project root directory. Make sure to provide actual Godot build template (godot-lib.release.aar) for the engine version you are using at godotappodeal\libs folder.

Let me know if this helped, I might update repository README and add a "Troubleshooting" section. But what I really advise is running a non-filtered logcat and just studying everything that it traces from your app's start to the crash.

Thank you for so detailed answer! I use Godot 3.4.4 too. My tries with sdk's versions no went me to the win.
I guess problem may be in empty AppKey (i have not it yeat) or no admob stings in AndroidManifest (can you explain how to disable admob if it is root of trooble, please?)
My apk

Hi! Yeah, from logcat it seems that Google Mobile Ads SDK causes the issue.
Try adding the following to your AndroidManifest.xml
<uses-permission android:name="com.google.android.gms.permission.AD_ID"/>
This line should be added between these comments in the XML so they won't get deleted by Godot:

Also you can disable AdMob sync in Appodeal Dashboard, but I'm not sure what it does. Having the com.google.android.gms.permission.AD_ID has become a mandatory rule by Google a few months ago, and if this permission is not declared then Android simply returns an empty string instead of the device's Advertising ID, which leads to crashes. AFAIK every other ad network (which there are a lot in Appodeal) still need this permission to operate.
In my README I describe this as optional ("...if you use AdMob, add this.."), my bad. I will fix this. In the meantime please check if it helped.
Also, even if your project is not production-ready yet, you can still register it in the Appodeal dashboard and get your App Key to test the ads. (Though you better be using setTestingEnabled(true) mode)

I have updated the README about this all.
In short words, yes - you should provide an AppKey in the Project Properties as mentioned in Readme.
Google Admob Adapter causes crashes or black screens if you don't provide a valid Google Ad APP ID for it. 2 workarounds exist for this issue, please see the updated Readme.
I have also pushed new commits that fix some potential Java-crashes related to updated Appodeal API (initialization callbacks in particular), so please make sure to download new release (rev.2) or rebuild the repo.
Please let me know if this helped. If so, I will close the issue. :D

Thank you a lot! Can I get valid test AppKey for Appodeal? (how this provide by AdMob testing App ID). I read Appodeal docs, but  can't find something like appodeal-xxxxxxxxxxxxxxxx-yyyyyyyyyy. Do I need use .setTesting(true) func before inicializaion? My project can't find singleton of Appodeal. If i provide valid AppKey Godot should succcesfull get singleton?

There is no such thing as test Appodeal key, you just add a new app into your Appodeal dashboard and the key gets generated (doesn't matter if your game is live on Google Play or not).
You can set testing as true after initialization, no problem with that. When you summon ads in testing mode, an Appodeal banner would show instead of real ads.
If your project can't find Appodeal singletone, check if you have Appodeal enabled in your Android Export settings in Godot Editor (you need to tick the checkbox there).

Very good explain and work! I escaped app crash problem! (finally set remote debugging 😄)


Add multi-host support to sharded_jit.

This is done similarly to how multi-host pmap works: for each input, each host contributes one "local" piece of a conceptual "global" array, which is further sharded across that host's local devices. Each host similarly gets a local piece of each global output array.
To support this, three new arguments are added to sharded_jit: local_in_parts, local_out_parts, and local_num_partitions. These are similar to the existing in_parts, out_parts, and num_partitions arguments (which are now implicitly assumed to be global), except they specify the partitioning local to each host. These new arguments are only needed when the local and global partitionings are different, i.e. when partitioning across multiple hosts.
Note this doesn't support multi-host partitioning when using pmap(sharded_jit). I'll add that in a subsequent change.

FYI @apaszke in case you wanna take a look


Revert s3 migration

Moving Prow logs to S3 bucket does not work with testgrid.
More details in: https://github.com/rajaskakodkar/tanzu-test-infra/pull/56

/lgtm


Unhandled 'error' event

getting the following exception randomly in Nodejs application, which terminates it
events.js:291
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:208:20)
    at TLSWrap.callbackTrampoline (internal/async_hooks.js:126:14)
Emitted 'error' event on Client instance at:
    at TLSSocket.onSocketError (/usr/src/app/node_modules/ldapjs/lib/client/client.js:966:12)
    at TLSSocket.emit (events.js:314:20)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21) {
  errno: 'ECONNRESET',
  code: 'ECONNRESET',
  syscall: 'read'

Can you please suggest what to check? I'm using ldapjs-promise wrapping around your library, but I see that it's thrown out from the middle of your code. Interesting thing that I have the whole client lifecycle managed inside try {} catch block

It looks like a connection reset error. So the server hung up on you. You have to listen for the error event on the client.

Thank you @jsumners , gonna try to add the handler to see if there is any change.

@phi1ipp  You can add a global listener, to handle such errors in your application, so that your application won't terminate.
// Global Error handlers process.on('uncaughtException', function(err) {     console.error('Uncaught Exception: ', err); }); process.on('unhandledRejection', (reason, p) => {     console.error('Unhandled Rejection: ', p, 'Reason: ', reason); });

@SkourasKonst you should not let your application continue to run if an uncaughtException or unhandledRejection is encountered. You are very likely to encounter memory leaks and other errors if you do.
Closing this as I believe it has been answered. Feel free to reopen if you are still having issues.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Fix windows build

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Thanks Isuru! 🙏
A couple jobs still failed. Though they appear to be unrelated to Windows and look to just have experienced network issues. Went ahead and restarted those failed builds

Looks like those builds are now passing
IIUC the issue before was we were not using the CDN, but will be with a future re-rendering pulling in these changes: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6024


Generate TypeConverters for types implementing specific interfaces

Generate TypeConverters for all types supported by SQLite. The example code illustrates the idea String.
Annotated class must contain fun persistTo[TYPE](): [TYPE], and its companion object must contain fun createFrom[TYPE]([TYPE]): [CLASS]:
@GenerateTypeConverter(type = PersistentType.STRING)
class Foo(/* ... */) {
    // ...

    fun persistToString(): String = // ...

    companion object {
        fun createFromString(string: String): Foo = // ...
    }
}

This kind of annotation would only increase complexity, instead of reducing it.


Update sts to 2.17.175

Updates software.amazon.awssdk:sts from 2.17.164 to 2.17.175.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk", artifactId = "sts" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "software.amazon.awssdk", artifactId = "sts" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #870.


allow imandra as a language in reason.server.languages

This PR is to ask for the imandra and imanda-reason languages to be included in the list of allowable languages for the plugin. I mentioned it first on the discord editor-support channel. I will set out why and how this would be great here. I'd be very grateful if you could have a look and let me know whether you think this is acceptable.
-- we have developed the imandra reasoning engine which analyses ocaml and reason files, and is a subset of the ocaml language itself. You can try it live by looking at the docs here:
https://docs.imandra.ai/imandra-docs/
-- we have also developed a merlin reader for imandra extension of ocaml and reason
-- your VSCode plugin works brilliantly if we activate it for imandra or imandra reason files and change the executable for merlin to be a script we provide which calls merlin with the imandra reader. We have developed a plugin of our own which adds yours as a "installation dependency" - that is we add this line to the package.json:
"extensionDependencies": [
    "freebroccolo.reasonml"
  ]

This is our repo:
https://github.com/AestheticIntegration/imandra-vscode/
what is done in our extension on activate is to redefine the environment variables in the workspace to:
{
    "reason.server.languages": [
        "ocaml",
        "reason",
        "imandra",
        "imandra-reason"
    ],
    "reason.path.ocamlmerlin": "~/.vscode/extensions/aestheticintegration.iml-vscode-0.1.1/ext-script/imandra-merlin"
}

for example. This then works fine - I execute the reload window command if the value of the reason.path.ocamlmerlin has changed then it reactivates your plugin with these settings.
The reason for the PR is that we get warnings because "imandra"  and "imandra-reason" are not permissible languages, and because the max allowable length of the array is 2.  I have changed the package.json so that "imandra" is permissible and so that the length of the array can be 4. There maybe a more principled way of allowing the array to be extended in a workspace without the warning of course.
--
Future potential related work:
I have a fork of merlin which accepts command line arguments allowing a user to specify a reader for a file suffix. I would like to add this as an environment variable here at some point so that we can choose how merlin analyses different files in a workspace - currently it is workspace global for imandra.
--
VSCode note - I am trying to work out how to change the activation order of plugins - if I could write these settings using ours first then activate yours that would be best, but the activation order is always that the installation dependency activates first - I am trying to change this.

First, thanks for the PR and sorry for not commenting on this sooner. It seems to fine to me to add more allowed languages. I'll take a look at your links and try to get this merged for the next release.
Concerning the activation order of vscode extensions, I don't think there is any way to control that, at least not any way that can be relied upon not to break going forward.

Hi @freebroccolo  - thanks a lot for the reply - it is very much appreciated, and thanks for agreeing in principle to the addition of new languages. I actually have a PR with merlin now which allows association of reader to file extension which I hope may be accepted - if so it would be amazing to consider allowing a setting e.g. reason.path.merlinargs. If it is ok  I may raise another PR here which ties in with this.


Avoid dependabot version catalog update PRs

Feature Request
Everyday we receive a PR from dependabot proposing a new version for the version-catalog, that's pretty annoying.
Which Areas Would Be Affected?
build
Why Is the Feature Desired?

Solution Proposal
Maybe putting the version as variable in gradle.properties will stop it.

another option would be to either exclude certain dependencies (i.e. the version catalog) or generally ignore -SNAPSHOT versions (check here)

Seems like the solution provided with https://github.com/eclipse-edc/Connector/pull/2435 is not working


OpenGL acceleration does not work for Intel UHD 630 + Arch linux combination

Version
Microsoft Windows [Version 10.0.22000.778]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Arch
Other Software
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.39
MSRDC version: 1.2.3213
Direct3D version: 1.601.0
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22000.778
[root@DEV-PC anupb]# ls -l /dev/dxg
crw-rw-rw- 1 root root 10, 63 Jul 12 04:14 /dev/dxg
[root@DEV-PC anupb]# ls -la /usr/lib/dri/d3d12_dri.so
-rwxr-xr-x 12 root root 25395504 Jul  3 15:37 /usr/lib/dri/d3d12_dri.so
[root@DEV-PC anupb]# glxinfo -B
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
Vendor: Mesa/X.org (0xffffffff)
Device: llvmpipe (LLVM 14.0.6, 256 bits) (0xffffffff)
Version: 22.1.3
Accelerated: no
Video memory: 7867MB
Unified memory: no
Preferred profile: core (0x1)
Max core profile version: 4.5
Max compat profile version: 4.5
Max GLES1 profile version: 1.1
Max GLES[23] profile version: 3.2
OpenGL vendor string: Mesa/X.org
OpenGL renderer string: llvmpipe (LLVM 14.0.6, 256 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 22.1.3
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL version string: 4.5 (Compatibility Profile) Mesa 22.1.3
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile
OpenGL ES profile version string: OpenGL ES 3.2 Mesa 22.1.3
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
On the same system Ubuntu 22.04 works fine.  How should i fix the issue ? I am using unmodified default Mesa 22.1.3 in arch and this should work by default but it doesn't. :-(
Repro Steps
Install Arch in WSL by following the steps mentioned at
https://github.com/nckslvrmn/arch_linux_wsl2
Expected Behavior
Accelerated OpenGL should work in any distribution under WSL as long as latest version of MESA is used.
Actual Behavior
Mesa 22.1.3 under Arch linux is using software rendering (llvmpipe)
Diagnostic Logs
No response

DxDiag report on my syste
DxDiag.txt
m

@anup-das what driver are you using?
This is with nvidia-512.96. The only package added to Arch was mesa-utils to get glxinfo:
[tux@eleven ~]$ glxinfo -B
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Microsoft Corporation (0xffffffff)
    Device: D3D12 (NVIDIA GeForce RTX 3060 Ti) (0xffffffff)
    Version: 22.1.3
    Accelerated: yes
    Video memory: 24348MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.2
    Max compat profile version: 4.2
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.1
OpenGL vendor string: Microsoft Corporation
OpenGL renderer string: D3D12 (NVIDIA GeForce RTX 3060 Ti)
OpenGL core profile version string: 4.2 (Core Profile) Mesa 22.1.3
OpenGL core profile shading language version string: 4.20
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.2 (Compatibility Profile) Mesa 22.1.3
OpenGL shading language version string: 4.20
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.1 Mesa 22.1.3
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.10

Segmentation fault

Notice the segfault at the end. This is an ongoing issue, reported many times.
ArchLinux info:
[tux@eleven ~]$ cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux-logo
IMAGE_ID=archlinux
IMAGE_VERSION=2022.07.01

and WSL2 info:
PS C:\> wsl --status
Default Distribution: Ubuntu-22.04
Default Version: 2
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.39
MSRDC version: 1.2.3213
Direct3D version: 1.601.0
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22000.778

@elsaco Thanks. The issue of not having h/w accel seems to be with Intel UHD 630 + arch combination only.  Ubuntu 22.04 LTS works just fine.
I have 2 identical systems one with NVIDIA Graphics and other with Intel Graphics. The one with NVIDIA works fine with both ubuntu and arch.  For arch, at the end i get a segfault (as you correctly indicated).

@anup-das is opengl acceleration working for you now :thinking:   if so, how did you solve it.

Looking for a resolution here as well... working fine on Ubuntu but failing on Arch


Quickfix of eslint-comments/no-unused-disable should not leave empty lines

The fix of eslint-comments/no-unused-disable should remove line enterily.

Hi @zardoy!
Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments
For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

Hi @zardoy!
Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments
For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

If this issue is resolved in your fork, I will use your fork in all projects! Will definitely check the fix. And thank you fixing btw.

@zardoy Could you please open this issue on the fork as well, so we can keep track of it there?


New PR to test SignCLA at 2019-08-06 12:16:48.461602433 -0700 PDT m=+3.845121084

Body of PR

corp-pass-fork-staging: test succeeded


Renders not having video

Describe the bug
Certain demos have an empty src="" value for the mp4 file to watch the video, examples:
https://autorender.p2sr.org/videos/9ZOfXc485Os Has a value thus you can watch,
https://autorender.p2sr.org/videos/JulXODXUD5g has no value so you cannot watch/
To Reproduce
Steps to reproduce the behavior:

above

Expected behavior
That it loads
Desktop/Smartphone Information

OS: Windows 11 Home
Browser: Firefox
Version: most recent

We missed a few renders from 2024-09-09 to 2024-09-12. Most likely related that the CDN did not warn me that I had to charge it again. It should not happen again for like year. I need to figure out how to get an alert somehow. Also I'll make sure to trigger a rerender on all those videos when I have time.

Oh alright thanks for the reply NeKz, how everything works fine

Opening this issue again because this is still not fixed.

Uploaded all 108 videos. I also made sure that my alerts are going to the correct inbox where I have notifications enabled.


container_create: fix OCI processArgs assemblement

This patch fixes the following command:
kubectl run -i --tty centos --image=centos -- sh
The command above use to fail with:
/usr/bin/sh: /usr/bin/sh: cannot execute binary file
That's because we were wrongly assembling the OCI processArgs.
Thanks @alexlarsson for spotting this.
This patch basically replicates what docker does when merging container
config and image config. It also replicates how docker sets processArgs
for the OCI runtime.
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

@sameo @mrunalp @alexlarsson PTAL

:+1: Let's also run complete e2e on this one.

:tada: everything's fine, @sameo @mrunalp PTAL

LGTM

Tested on my little bare metal k8s cluster: LGTM.

So, @sameo and me specifically meet to go through this code one more time and now it should be good to go.

LGTM

LGTM


error window cmd

idk whats happening lol

already upgraded and updated to evrything to the max updated as i could and its still not working on windows help

i had it working and then it stopped


Adding getters to the repository builder classes

I'm currently using the different repository builder classes (RepositoryBuilder, VirtualRepositoryBuilder, LocalRepositoryBuilder, etc) to implement some automation in Artifactory.
The automation consists in implementing some generic rules (Example: "All remote repos should be online") which operate on the AF repositories. When a violation to the rule is detected, the rule automatically reconfigures the repository to fix the issue (thanks to the builder class) and commits the change to AF. Rules are meant to be very simple and we want to apply lots of different rules to configure the AF server.
However, I have identified that the lack of getters on the different repository builder classes makes it difficult to implement those rules. Because the builder class doesn't allow me to read the configuration currently stored in the builder instance, it's not possible for me to apply incremental changes to the configuration of a repository.
I hope the following pseudo-code will shed some light.
// Retrieve the rules to apply to the virtual repos
def rules = getVirtualRepositoryRules() as List<VirtualRepositoryRule>

// Loop over all the virtual repos in AF
virtualRepos.each { repository ->
  // Backup the repository configuration to detect changes (not detailed)

  // Create a builder class to allow rules to reconfigure the repository (if necessary)
  VirtualRepositoryBuilder builder = artifactory.repositories().builders()
    .builderFrom(repository)
    .repositorySettings(repository.repositorySettings)
    .xraySettings(repository.xraySettings)

  // Apply all the rules to the current virtual repository
  rules.each { rule ->
    rule.apply(repository, builder)
  }

  // Build the updated configuration
  def updatedConfiguration = configuration.build()

  // Compare the initial and update configurations (not detailed)
  def changeDetected = ...

  if (changeDetected) {
    // Submit the changes to AF
    artifactory.repositories().update(updatedConfiguration)
  }
}

In the scenario above, the same builder object is passed to different rule objects and "accumulates" the changes applied by the different rules (the first rule can apply some changes, the second rule can apply other changes, etc).
This approach cannot work because the repository builder classes only offer setter methods. The lack of getter methods makes it impossible for the second rule to see the changes introduced by the first rule (they're not yet applied to the server).
I hope this makes sense.
For instance, the change would consist in adding the following getters to the class VirtualRepositoryBuilderImpl.
Collection<String> getRepositories() {
    this.repositories
}

boolean isArtifactoryRequestsCanRetrieveRemoteArtifacts() {
    this.artifactoryRequestsCanRetrieveRemoteArtifacts
}

String getDefaultDeploymentRepo() {
    this.defaultDeploymentRepo
}

I'm willing to contribute a PR if you think this request makes sense.

Sounds good @fritaly.
Please go ahead and create a pull request for this. Thanks.

Thanks @eyalbe4, I just created this PR


New visit created for each action with userid populated since 3.13

Since upgrading to 3.13 all of the sessions where a user id was set get a new visit created for each action.
I'm using the piwik_java_tracker and looking at the code it puts a new random string the the visitor id of each request. This has worked fine in the past, both when a user id was set and when one was not set.
As a workaround: explicitly setting the visitor id to a hex value derived from the user id whenever a userid is set seems to do the trick.
But ideally it should just follow the same logic as the scenario without a user id. There as well, a unique visitor id is created for each request by the piwik_java_tracker but at least the server side is able to group all actions into one session.
See also https://github.com/matomo-org/matomo/issues/15299

Hi @tolomaus Thanks for the suggestion. Maybe you are able to open a Pull request on this project? This would be very helpful and help solve this issue quickly.

Hello Matthieu,
No problem, but could you explain what should be the logic for populating the visitor id? What I described was just a workaround to avoid the spikes in "new visitors".

I confirm this problem!
Multiple unique visit for each action for same User ID
https://github.com/matomo-org/matomo/issues/15320


Add Save Snapshot option on the right click

Add this in a context menu to download a png image of the widget

Fixed


Hotfix for flaky tabular tests

hypothesis has some non-determinism and the tests are flaky due to floating point error. Use higher-precision floats to mitigate rounding error, and reducing scale of rewards that we test to further reduce rounding error. Also relax thresholds where they're overly strict.

I ran pytest --flake-finder (for 100 replicas) and all passed, so tests should have at least <1% probability of failing now.


Gradle Kotlin DSL

This adds a Gradle Kotlin DSL sample.

Hi @mwkroening,
Thank you for the PR. Unfortunately, this doesn't add much value to the documentation and we would like to stick to Groovy DSL for the meantime.


Options to allow  without property attribute

Is it possible to configure this module to allow "required" attributes to be missing?
I have some legacy code I'm testing with and would like to turn some "required" attributes off.

Not now, but soon! We're planning to add this feature in the 1.1.x release. You can check in on the progress in the milestones.

Wow excellent documentation, thanks!
You may be interested in this: https://github.com/solnetdigital/testing-html, I've used this module to allow unit testing of a project's HTML. Great fun!

Will have to update the documentation when this feature is complete. But, working off the latest master branch (unreleased on npm), you should be able to use the followingoptions to override the list of allowed tag attributes:

using 'policy': 'replace' in settings
using a global override to allow anything '_': { 'mixed': '*' } in attributes

Here is an example:
var htmlTagValidator = require('html-tag-validator'),
  sampleHtml = "" +
               "<title NotAnAttribute="notvalid">hello world</title>" +
               "
my cool page
" +
               "";

htmlTagValidator(sampleHtml, {
  'settings': {
    'policy': 'replace'
  },
  'attributes': {
    '_': {
      'mixed': '*'
    }
  }
}, function (err, ast) {
  if (err) {
    throw err;
  } else {
    console.log(ast);
  }
});

Love your work, thanks!


Update package manifest record to split tags

The PackageManifestRecord contains raw package tags as a string. Ideally these should be pre-processed into a parsed list for easier analysis. Currently you need to split tags with something like:
JverPackageManifests
| where ResultType == "Available"
| extend Tags = translate(
    "  ", " ", translate(
    ",", " ", translate(
    ";", " ", translate(
    "\t", " ", Tags))))
| mv-expand split(Tags, " ")
| where isnotempty(Tags)

Tag splitting algorithm: https://github.com/NuGet/NuGet.Jobs/blob/376ac06e6e07d4ee8d1e28f6b2346e3891487496/src/Catalog/Helpers/Utils.cs#L37-L48

I'm going close this and leave it as a query-time projection. There is no well spec'd way to parse tags so I think it's better to do it dynamically on the fly.

Currently it's bothersome to answer a question like "How many packages have the tag windowsazureofficial": your options are to do a string contains 😰 or do that query-time projection 😥.  Tags is one area where NuGet knowledge is necessary, but perhaps that could mitigated by having two fields for both the "unprocessed" tags and the "parsed but maybe wrong" tags?

Yeah, that's a great point! I think as long as the Markdown documentation clarifies the nuance of "parsed by maybe wrong", this can definitely work and add value. Thanks for pushing back 😃.


Add the initial version of the hospital back-end service

Purpose
$title.
Pending tasks - https://github.com/ballerina-guides/integration-tutorials/issues/1

How about adding logs to make a better use?

Let's do this separately. This is the first iteration to be able to continue with the tutorials.
Added a comment to track this: https://github.com/ballerina-guides/integration-tutorials/issues/1#issuecomment-1689264051


git prompt not working correctly on macOS (vanilla ZSH)

I am having issues with the git prompt. It shows the branch and tag names, but the rest of the segment doesn't show up.
For example, echo $(git stash list 2>/dev/null | wc -l) returns 2, but the prompt doesn't show any stashes...

Hm, so I can't replicate this. Using master and next, git stashes are working fine and show up in the prompt for me.
What version of P9k are you using?

Six months later and I found the culprit by accident while cleaning up my configuration files. I had a file that set some formats from before I used P9k, and that interfered with the prompt. Now it is working correctly and this issue can finally be closed.
For future reference for people with this issue, search for and files outside P9k containing zstyle ':vcs_info:*' and comment those lines out with # to see if that is your issue.


Help me change the currency only without changing language.

I have a requirement of only changing currency but keeping the language same. how can i do this ,

At the moment the currency and the language are set together via current culture. You need to separate them

Ok


use future-rs latest

Now that https://github.com/rust-lang/futures-rs/pull/2591 has been merged we can use the latest futures-rs version from git and remove the library code from our repo.
This PR is mostly just adding required traits and fixing some formatting.

Importing both futures git and futures_util 3.0 seems really wonky to me.
The reason is that futures reexports pats of futures_util.
This means we have traits from 2 versions of futures_util floating around which will cause a lot of confusion and hard to understand errors.
So I would rather we either wait for futures 4.0 or backport the push_front method to futures 3.0

Marking as a draft until a new version of futures-rs is released.


Certain elements of the UI need to react to program state dynamically

We have a policy of plain javascript for this app. The document structure has evolved organically and thus lacks some structure (divs, classes, id:s) especially in the Filter Pane, which was originally planned as a static a object. Yes, it's the range filter checkboxes (the old cave lenght filter) that cause headache now.
Addressing this issue for the rangeFilter checkboxes by removing labels and appending text nodes and divs instead, which are easier to address by getElementByWhatever() and update.

This has been achieved now.


Move eslint dependencies

This will prevent older versions of eslint being installed when depending on this package. Even though eslint is defined as an optional dependency, it is being installed by default.
Also, fixed linting errors, added bable-cli to allow transpile and added istanbul to run coverage.

Thanks


Stopflow plan should close the shutter between acquisition sequences

The plan currently:

opens the shutter
acquires n frames
waits for SEQ1.BIT_A to go high
acquires m frames
closes the shutter

It should:

open the shutter
acquire n frames
close the shutter
wait for SEQ1.BIT_A to go high
open the shutter
acquire m frames
close the shutter

Tagging @abbiemery @evalott100 @DiamondJoseph

so it's just to close-and-open the shutter more, in specific times.
attempting this now

changing the inner_stopflow_plan

Having consulted with @coretl I am no longer sure if this is needed, was hoping for input from @timsnow


docs: clean display output in notebook

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[x] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[x] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report

Merging #1795 (624168a) into master (76e7b73) will decrease coverage by 54.94%.
The diff coverage is n/a.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: Upstream 1.28.2

fixes #117

closing in favour of #119 for secrets access - commits will be preserved


Oled remains blank

This is a great project! I happened to get a T-beam and TTGO Lora32 with Oled. The T-beam is talking to the Lora32, I can see the gps on the serial monitor, but it isn't appearing on the Oled.
Is there something I should check? The Lora32 says T3_V1.6  20180606 on the PCB.

Fixed: On the V2(?) V3(?) I had to change the code to
#define OLED_SDA 21
#define OLED_SCL 22
#define OLED_RST 16

The above pin assignments worked for my TTGO Lora32 with Oled. However the text is missing every other line of pixels.
I have two identical boards and both behave the same.
My google fu is failing me but thanks for the info.


Attempted to assign to readonly property.

Version
v2.4.3
Reproduction link
https://github.com/nuxt/nuxt.js/blob/f791d786e0996e4cad2b1ddbe244a747e7e700aa/packages/vue-app/template/client.js#L81
Steps to reproduce
Throw a error while mounting Nuxt (client)
What is expected ?
To adjust the error message
What is actually happening?
A new error is thrown saying: Attempted to assign to readonly property.
Additional comments?
https://github.com/nuxt/nuxt.js/blob/f791d786e0996e4cad2b1ddbe244a747e7e700aa/packages/vue-app/template/client.js#L81

This bug report is available on Nuxt community (#c8681)

@Timkor Feel free to submit a PR that cover the expected state

This is still a problem.

The problem is that the property message of DOMException is read only. Hence it cannot be adjusted by Nuxt.


'main' referenced in package.json doesn't exist.

In package.json, the "main" file doesn't exist:
{
    ...
    "main": "ngProgress.js",
    ...
}

It should probably be:
{
    ...
    "main": "build/ngprogress.js",
    ...
}

This affects how module bundlers, i.e. webpack can parse/bundle this library.
For example, when I import this library, I must fully qualify the path of the file inside this repo:
import 'ngprogress/build/ngprogress.js';

if the "main" file were correctly referenced, I'd be able to do:
import 'ngprogress';

+1

Can you open a PR For this?  Thanks

+1

Solved by the PR


favicon.ico is saved as HTML when response is 404

This is the content of some of my favicon.ico files:

I would suggest not saving the file at all when the request returns a 404.

Hi
It downloads exactly what server returns)
From one side, it makes sense to reject everything with status code !== 200, but from another side - it makes sense to save everything server returns. In both cases we will have errors - 404 file not found in scraped site in 1st case and html instead of icon in second case.
I think about adding some customization to http response handling, so soon it will be possible to reject almost everything you don't need
Thanks for great idea!

The problem is that when I open the scraped version, it returns a 200 with an invalid favicon file.

Yes, I understand.
But it is expected behavior - for example if we want to save github's 404 page https://github.com/something-not-found

Why not save it as something like foo.ico.404.err. And log it. Then you could do something like go back to your unreachable resources and check them at a later time.  As it is now, we have no way of knowing was unreachable.   Yet again a reason of why the header data is important. I'm not suggesting that scraper saves the header, just makes it available.

From version 2.2.0 you can customize resource loading by using httpResponseHandler option and log success/failed resources using onResourceSaved/onResourceError callbacks.
It will be something like this:
scrape({
  urls: ['http://example.com/'],
  directory: '/path/to/save',
  httpResponseHandler: (response) => {
    if (response.statusCode === 404) {
        return Promise.reject(new Error('status is 404'));
    } else {
        return Promise.resolve(response.body) // here you also can return headers
    }
  },
  onResourceSaved: (resource) => {
    console.log(`Resource ${resource} was saved to fs`);
  },
  onResourceError: (resource, err) => {
    console.log(`Resource ${resource} was not saved because of ${err}`);
  }
})

Hope it helps


New version: Remeha.ServiceTool version <IP_ADDRESS>

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

The duplication of the executable is intentional, a critical bug has been found and we are rolling back to that version and want to force our auto-updater to 'downgrade'.


Return whole error object in done callback

The stack trace on render errors gets lost when you only return the error.message.. This makes it hard to debug errors that occur during rendering.
What do you think?

@jonathanewerner Thanks. Makes sense.
This fixes a potential issue as well when err is not an object but done is provided.
Thanks. 👍


master: Add data mover to e2e cherrypick of #863

Fixes #930

/test 4.10-operator-e2e-gcp

/retest

"restore phase is: WaitingForPluginOperations; expected: Completed

if further commits needed, also pin volsync subscription version channel

/retest

added notes in slack

/retest

Some were failing because volsync subscription flake

mongo flakes
/retest

volsync not installed flake
/retest

Bye bye 4.8 4.9
/override 4.8-operator-e2e-aws
/override 4.8-operator-e2e-gcp
/override 4.9-operator-e2e-aws
/override 4.9-operator-e2e-gcp

/override ci/prow/4.8-operator-e2e-aws
/override ci/prow/4.8-operator-e2e-gcp
/override ci/prow/4.9-operator-e2e-aws
/override ci/prow/4.9-operator-e2e-gcp

/cherry-pick oadp-1.2

https://github.com/openshift/release/pull/38278


Update logback-classic, logback-core to 1.2.6

Updates

ch.qos.logback:logback-classic
ch.qos.logback:logback-core

from 1.2.3 to 1.2.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback" } ]

labels: test-library-update, semver-patch

Superseded by #101.


Selection of the acceleration factor for evaluation

The accelerations argument should be parsed correctly to the build_masking_function
For now, the acc factor will be selected automatically from the cfg file and set to the first option used for validation.
Two ways to fix it:

Load it from the cfg file in a proper way and remove the argument
Parse the argument option and remove loading from the file

Thanks @wdika. Perhaps we can have a flag --use-validation-settings and if there are multiple sets just output multiple volumes? Otherwise command-line arguments are required. I think that might be a valuable solution?

I now made it possible to select the validation set, let's see how this goes. See https://github.com/directgroup/direct/commit/20ff3107c4a843fead190c075d3f9c4ad3126e6d

Will likely change this feature as the current version of DIRECT outputs the per-volume metrics of the real validation set. This would effectively make this irrelevant. Will close when the run script is removed, I want to rework the inference bit anyway.


Review patent process

This is an update and review of the task of patent and non-patent reference extraction from patent documents.

Support of Deep Learning models with adapted segmentation of input sequences for training and prediction.
Batch processing for prediction.
Include a BidLSTM_CRF_FEATURES model (improves quite significantly the extraction accuracy as compared to CRF). Note that the training also supports all BERT flavour, in particular Google BERT for Patents
Update of the mapping of US application prefix and numbers to years (for patent publication number normalization according to epodoc), up to 2021/2022.
Review XML serialization to only include in the result XML paragraphs with references. References are given for each paragraphs (rather all at the end), with position offsets referencing the paragraph (and not all the document as before). This improve readability without changing the XML parser normally for getting the references.

Related: grobid_client_python has been extended to process directories of patent files (ST36 or PDF)
TODO: proper 10-fold cross evaluation of models, automatic download of fine-tuned BERT large model fror patents

coverage: 39.709% (-0.2%) from 39.893%
when pulling 08c0405e4ddc3360a6579dcc43c81d2aa3fe9d1f on review-patent
into 4816a7a379ff87044600fab45b0b418850111921 on master.


[libgeotiff] build failure linux dynamic

Host Environment

OS: Ubuntu 20.04
Compiler: gcc v9.3.0

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libgeotiff:x64-linux-shared
Failure logs
There should be no empty directories in /home/aaron/dev/vcpkg/packages/libgeotiff_x64-linux-shared
The following empty directories were found:
/home/aaron/dev/vcpkg/packages/libgeotiff_x64-linux-shared/bin

If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")

Found 1 error(s). Please correct the portfile:
/home/aaron/dev/vcpkg/ports/libgeotiff/portfile.cmake
-- Performing post-build validation done
Error: Building package libgeotiff:x64-linux-shared failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libgeotiff:x64-linux-shared
Vcpkg version: 2020.02.04-unknownhash
Additionally, attach any relevant sections from the log files above.
Additional context
I resolved this by removing the static linkage check in the libgeotiff/portfile.cmake file in order to remove the bin directories.

@NancyLi1013 I think this issue can be closed now. I've been able to build it with x64-linux-dynamic


Added required Pod attribute homepage

Thank @asessa , I will take a look soon

@phuochau great, when this is merged I can update the readme to add the Podfile configuration.


Move widgets

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Tests pass?
✔/❌

Fixed issues
https://github.com/yiisoft/view/pull/58

Too much extra commits. I will create new PR


Clean up the logs, bump datasets and transformers

The noisiest logs were coming from an old datasets version. Bumping the datasets version ended up requiring bumping the transformers version due to a dependency quadrangle. So this PR is including the version bumps too.

[ ] Run regression tests against this PR
[x] Verify that model saving and deployment handles safetensors (turned on by default in latest transformers)
[x] Run a before and after for the logs (before: clean-logs-baseline-EJoND1, after: clean-logs-local-after-fkC5cH)

Can you also update streaming to 0.7.2?


"import lsdb" fails with a dask error

Bug report
Freshly installed LSDB fails on import:
Expand
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/lsdb/__init__.py", line 2, in <module>
    from .catalog import Catalog
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/lsdb/catalog/__init__.py", line 1, in <module>
    from .catalog import Catalog
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/lsdb/catalog/catalog.py", line 6, in <module>
    import dask.dataframe as dd
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/__init__.py", line 100, in <module>
    from dask.dataframe import backends, dispatch, rolling
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/backends.py", line 15, in <module>
    from dask.dataframe.core import DataFrame, Index, Scalar, Series, _Frame
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/core.py", line 36, in <module>
    from dask.dataframe import methods
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/methods.py", line 34, in <module>
    from dask.dataframe.utils import is_dataframe_like, is_index_like, is_series_like
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/utils.py", line 20, in <module>
    from dask.dataframe import (  # noqa: F401 register pandas extension types
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/_dtypes.py", line 9, in <module>
    from dask.dataframe.extensions import make_array_nonempty, make_scalar
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/extensions.py", line 8, in <module>
    from dask.dataframe.accessor import (
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/accessor.py", line 126, in <module>
    class DatetimeAccessor(Accessor):
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/accessor.py", line 81, in __init_subclass__
    _bind_property(cls, pd_cls, attr, min_version)
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/dataframe/accessor.py", line 35, in _bind_property
    setattr(cls, attr, property(derived_from(pd_cls, version=min_version)(func)))
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/utils.py", line 987, in wrapper
    method.__doc__ = _derived_from(
                     ^^^^^^^^^^^^^^
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/utils.py", line 940, in _derived_from
    method_args = get_named_args(method)
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/hombit/.virtualenvs/lsdb-error/lib/python3.12/site-packages/dask/utils.py", line 701, in get_named_args
    s = inspect.signature(func)
        ^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 3310, in signature
    return Signature.from_callable(obj, follow_wrapped=follow_wrapped,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 3054, in from_callable
    return _signature_from_callable(obj, sigcls=cls,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 2642, in _signature_from_callable
    call = _descriptor_get(call, obj)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 2467, in _descriptor_get
    return get(descriptor, obj, type(obj))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError

I checked it with CPython 3.11 and 3.12, and with both PyPI release and the current main branch.
Before submitting
Please check the following:

[x] I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
[x] I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
[ ] If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

I think what's going on here is a dask dataframe issue on versions of python >3.11.9.  They fix it in dask version 2024.4.1, but this is after the dask expressions update which we are working on with issue #181. So once that is merged and we unpin dask to use later dask versions this issue should be fixed.

This is the same behavior we saw with this smoke test failure.
https://github.com/astronomy-commons/lsdb/issues/270
With #288, I think we can unpin the python versions.


ModuleConcatenationPlugin does not preserve module.id

Do you want to request a feature or report a bug?
It's looking like a bug.

What is the current behavior?
I'm trying to use ModuleConcatenationPlugin. The code used by some modules is using module.id.
At runtime, all hoisted modules share the same (hoisted) module.id.
If the current behavior is a bug, please provide the steps to reproduce.
See gist: https://gist.github.com/jeremiegirault/5c20cf51d79c737a09b8d370803622d1

What is the expected behavior?
It is expected for each module to have it's unique module id after hoisting, not the shared (hoisted) module id.
If this is a feature request, what is motivation or use case for changing the behavior?
N/A
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
node: 9.8.1
webpack: ^3.8.1
os: macOS 10.13.1
Thank you and keep up the good work !

Yep, looks like a bug. Using module.id should opt-out of ModuleConcatenation to get the correct module.id.

Wouldn’t it be possible to assign a unique module id? So that modules could be concatenated correctly.
--
Jérémie Girault

Le 24 nov. 2017 à 22:40, Tobias Koppers<EMAIL_ADDRESS>a écrit :
Yep, looks like a bug. Using module.id should opt-out of ModuleConcatenation to get the correct module.id.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

done


add docs for loadBalancerSourceRange field

@bprashanth @thockin

Sorry for the late response. Notification got buried in my mail box.

PTAL

LGTM just one nit

Fixed. Merging.


HTML: Add download link for the current notebook

Ideally, this should already work with the "Source" link (but currently it doesn't).
We could also include an (optional) link above or below the first section title (like here) or at the bottom of the page (like here).

It would probably also be nice, instead of having a link to a copy of the file, to have a link to the Github/Bitbucket page of the (proper version of the) notebook.
These links might be interesting:
https://pypi.python.org/pypi/sphinxcontrib-srclinks
https://gist.github.com/MantasVaitkunas/7c16de233812adcb7028
http://mg.pov.lt/blog/sphinx-edit-on-github.html

I just asked for this on the sphinx-dev mailing list: https://groups.google.com/forum/#!topic/sphinx-dev/q8dGyV6dN4A

I've create a PR for Sphinx: https://github.com/sphinx-doc/sphinx/pull/2399

I've mentioned the option html_sourcelink_suffix in 8566fe76b993a7ef669aef02b7216f3b0cac33f8.

Just for others who arrive here, the quick solution (not yet in the docs, as far as I can tell) is to add the following to conf.py:
html_sourcelink_suffix = ''

Then if one right-clicks on the "show source" link and saves the file, it will have the correct .ipynb extension.
It would still be nice to add a more obvious link to download the notebook (in my opinion).

@ketch Thanks for mentioning that. I consider doc/conf.py part of the documentation, therefore it is documented. If you think it should also be mentioned somewhere else in the documentation, please make a PR!

It would still be nice to add a more obvious link to download the notebook (in my opinion)

Definitely!
I'm hoping for contributions!

@ketch

It would still be nice to add a more obvious link to download the notebook (in my opinion).

I've just created #150, which could be used to create an arbitrarily obvious download link.
What do you think about it?


how to Connect a JTAG adapter to the NEORV32 jtag_* interface signals.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
I constraint NEORV32 jtag_* to  FPGA JTAG pin,  but opeocd cannot check cpu:
Open On-Chip Debugger 0.11.0+dev-02556-g78231cda3 (2023-04-03-14:31)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
Info : clock speed 2000 kHz
Info : JTAG tap: neorv32.cpu tap/device found: 0x43651093 (mfg: 0x049 (Xilinx), part: 0x3651, ver: 0x4)
Error: dtmcontrol is 0. Check JTAG connectivity/board power.
Warn : target neorv32.cpu.0 examination failed
Info : starting gdb server for neorv32.cpu.0 on 3333
Info : Listening on port 3333 for gdb connections
Error: Target not examined yet

Hey @athurwo!
Could you provide some code like your pin-mapping and/or your setup's top entity?
Do you also use the JTAG reset signal? If not, this signal has to be high.
Is the on-chip debugger enabled at all (ON_CHIP_DEBUGGER_EN generic)?

hello @stnolting
yes, I had enabled ON_CHIP_DEBUGGER_EN generic  and assigned jtag reset to high.

Maybe it is just a problem with the signal connection... What kind of JTAG adapter are you using? Could you share your top-level design (just the JTAG signals / pin mapping)?

hey @stnolting
I use jtag usb cable with ftdi ft232h.
I assign fpga board gpio to neorv32 cpu jtag pin,  and connect gpio to jtag usb cable by DuPont Line.
J24, J22, J26, K30 is gpio in fpga board.
set_property PACKAGE_PIN J24 [get_ports jtag_tck_i]
set_property IOSTANDARD LVCMOS33 [get_ports jtag_tck_i]
set_property PACKAGE_PIN J22 [get_ports jtag_tdo_i]
set_property IOSTANDARD LVCMOS33 [get_ports jtag_tdo_i]
set_property PACKAGE_PIN J26 [get_ports jtag_tms_o]
set_property IOSTANDARD LVCMOS33 [get_ports jtag_tms_o]
set_property PACKAGE_PIN K30 [get_ports jtag_tdi_i]
set_property IOSTANDARD LVCMOS33 [get_ports jtag_tdi_i]

@stnolting
now the infomation is changed:
Open On-Chip Debugger 0.11.0+dev-02556-g78231cda3 (2023-04-03-14:31)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
Info : clock speed 2000 kHz
Error: JTAG scan chain interrogation failed: all zeroes
Error: Check JTAG interface, timings, target power, etc.
Error: Trying to use configured scan chain anyway...
Error: neorv32.cpu: IR capture error; saw 0x00 not 0x01
Warn : Bypassing JTAG setup events due to errors
Error: dtmcontrol is 0. Check JTAG connectivity/board power.
Warn : target neorv32.cpu.0 examination failed
Info : starting gdb server for neorv32.cpu.0 on 3333
Info : Listening on port 3333 for gdb connections
Error: Target not examined yet

Hm ok, all relevant signals are there. I think it might be a wiring problem between the FPGA pins and your JTAG adapter. Do you use a "real" adapter or just a FTDI breakout board?
This is the wiring I am using: https://stnolting.github.io/neorv32/ug/#_hardware_requirements

Hey I would like to participate in this conversation because I'm strugglung with similar problem.
I have Zedboard REV.D development board. It uses ZynQ 7 Series FPGA and has JTAG Connector with Cascaded JTAG. I want to access JTAG in PL (Programming Logic). I already created necessary IPs and connected. I can see a new JTAG connection in Vivado when I programmed the board, but I would like to access that using OpenOCD and debug with GDB. I have followed the tutorial and at the moment am able to see JTAG interfaces in OpenOCD but I'm getting similar error.
I'm using Digilent HS1 Rev.A as my JTAG Connector. I already changed ftdi pin_layout in neorv32/sw/openocd/openocd.cfg for that connector.

@stnolting
I don`t know what different between "real" adapter and FTDI breakout board.
this jtag adaper is same with digilent usb cable,  can program bitstream to fpga board.

hello, how to change pin_layout in opeocd.cfg?

This is my ftdi layout_init for pin layout. Just copy + pasted from /usr/local/share/scripts/interfaces/ftdi/digilent-hs1.cfg. It should work. Look at in file system or in OpenOCD github repo for your exact/similar adapter interface and try it that pin layout.

hello, how to change pin_layout in opeocd.cfg?

This is my ftdi layout_init for pin layout. Just copy + pasted from /usr/local/share/scripts/interfaces/ftdi/digilent-hs1.cfg. It should work. Look at in file system or in OpenOCD github repo for your exact/similar adapter interface and try it that pin layout.

my ftdi vid_pid is 0x0403 0x6014,  I don`t know which is correct:
/usr/local/share/openocd/scripts/interface/ftdi/c232hm.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/digilent-hs2-cjtag.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/digilent-hs2.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/digilent_jtag_hs3.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/digilent_jtag_smt2.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/digilent_jtag_smt2_nc.cfg:ftdi vid_pid 0x0403 0x6014
/usr/local/share/openocd/scripts/interface/ftdi/ft232h-module-swd.cfg:ftdi vid_pid 0x0403 0x6014

my ftdi vid_pid is 0x0403 0x6014, I don`t know which is correct:

most likely /usr/local/share/openocd/scripts/interface/ftdi/digilent-hs2.cfg will be the correct one. Try it out.

@stnolting do you have any idea for my problem? I tried lots of different thing but to no avail.

i had tried gpio and jtag port in fpga board  to connect to jtag cable, but don`t work.

Open On-Chip Debugger 0.11.0+dev-02556-g78231cda3 (2023-04-03-14:31)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
Info : clock speed 2000 kHz
Info : JTAG tap: neorv32.cpu tap/device found: 0x43651093 (mfg: 0x049 (Xilinx), part: 0x3651, ver: 0x4)
Error: dtmcontrol is 0. Check JTAG connectivity/board power.
Warn : target neorv32.cpu.0 examination failed
Info : starting gdb server for neorv32.cpu.0 on 3333
Info : Listening on port 3333 for gdb connections
Error: Target not examined yet

Hey @stnolting , here is more information about current implementation in IP.

IP Block Design
![bscan_jtag_ip](https://user-images.githubusercontent.com/8071263/230287286-3ec203cf-7e96-4603-9da9-35b12e3df8fd.png)

NeoRV32 Settings
![jtag_neorv32_settings](https://user-images.githubusercontent.com/8071263/230287504-3ff167b2-d27a-4232-a435-0291146fba6e.png)

Hardware Server
![hw_server_first](https://user-images.githubusercontent.com/8071263/230287549-178b2d08-d8d8-4ef0-a272-3564d2366188.png)

Thanks for the additional details!
Could you please check the synthesis report of your design? I think the "bscan_jtag_0" module uses at least one BCANE primitive, right?
From an "electrical" point of view your design is just fine. The problem here is the software part on host side. As I mentioned before, there is no option to add further devices into the FPGA's JTAG chain as this would interrupt the chain when the FPGA is not configured.
There are two options here:

use an additional/external JTAG adapter via some IO pins
use the Xilinx BSCANE primitive

The BSCANE primitive allows to "add" (in quotes!) custom JTAG modules to the JTAG chain. But they are not really inserted into the chain. Instead, a tunneling concept is used. And this is where the complicated part begins. This is similar to what @NikLeberg has implemented.
OpenOCD does support this tunneling mode and I have seen RISC-V cores being accessed via this approach. Unfortunately, this feature is not very well documented. I have experimented with that some time ago - but I failed 😅 This is by far the best documentation I have found: https://github.com/openhwgroup/core-v-mcu/issues/117#issuecomment-826280883

Could you please check the synthesis report of your design? I think the "bscan_jtag_0" module uses at least one BCANE primitive, right?

Actually 1 BSCANE2 (its Xilinx 7000 series FPGA) and BSCAN Switch.

From an "electrical" point of view your design is just fine.

Yeah and that's why I do not have any idea what can be the problem. I assume it's a problem with the OpenOCD configuration. Before I forgot I would like to add this new details here as well.
So with the same IP Design, I have synthesized and generated bitsream without a problem as always. But this time In OpenOCD side  I used scripts/boards/digilent_zedboard.cfg with dıgılent_jtag_hs3.cfg as well as tried with digilent-hs1.cfg. In this case I was able to see PL JTAG TAP and ARM DAP. The problem is I'm still unable to locate NeoRV32 JTAG.  (Today I'm not at work bceuase of holiday as you know, so I'm unable to provide screenshots)

use an additional/external JTAG adapter via some IO pins

Yeah thats the currunt implemented solution that I'm using to access NeoRV32 JTAG. I'm using PMOD Header that available in PL to access it.

use the Xilinx BSCANE primitive

You mean that I should create a VHDL file that uses BSCANE(2) and directly output JTAG connections from it. It makes sense but  aren't Debug Bridge  and BSCAN to JTAG Converter do that already? I will look into it.

Unfortunately, this feature is not very well documented. I have experimented with that some time ago - but I failed 😅

I understand you pain totally. I read 1825 page long Xilinx 7-Series documentation with UG470 beside. It's not a easy thing to achive, there should be a better solution to access over PS -> PL using Cascaded JTAG.
Thanks for the help @stnolting

I ran into the same problem as @athurwo. The problem is, that i have a Zedboard and a HS3 JTAG. The programming cable of the board and the JTAG have the same vid and pid ,thus openocd tried to connect to both and fails for the programming cable (the autotap), resulting in a similar error message as athurwo had.
A solution for this is to specify in the .cfg which adapter should be used, e.g. using:
adapter usb location [<bus>-<port>[.<port>]...]  see the openocd user documentation
You can get the used bus/port using 'lsusb -t` or using dmesg.
P.S.: Also, i wanted to say at this point that the project is very well documented, so far everything was really easy to setup/understand even as an newb. Thank you for that :)

really？thanks，I will try it.
---- Replied Message ----
| From | T.-M. @.> |
| Date | 07/04/2023 18:52 |
| To | @.> |
| Cc |<EMAIL_ADDRESS>|
| Subject | Re: [stnolting/neorv32] how to Connect a JTAG adapter to the NEORV32 jtag_* interface signals. (Issue #567) |
I ran into the same problem as @athurwo. The problem is, that i have a Zedboard and a HS3 JTAG. The programming cable of the board and the JTAG have the same vid and pid ,thus openocd tried to connect to both and fails for the programming cable (the autotap), resulting in a similar error message as athurwo had.
A solution for this is to specify in the .cfg which adapter should be used, e.g. using:
adapter usb location [-[.]...] see the openocd user documentation
You can get the used bus/port using 'lsusb -t` or using dmesg.
P.S.: Also, i wanted to say at this point that the project is very well documented, so far everything was really easy to setup/understand even as an newb. Thank you for that :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

I think this can be closed now. Feel free to open a new issue if you still have troubles with the JTAG connection.


AWS SAM does not support Description property for AWS::Serverless::Api

Description:
This is not a bug or an issue. It is more like a feature request.
I noticed while creating an API today that AWS SAM does not support a Description property for AWS::Serverless::Api resource.
Can this property be added to AWS SAM? We have many APIs created and currently, it's not easy to tell their usage. So, being able to set the Description property would be a very nice ability to have.
Expected result:
AWS::Serverless::Api has a Description property where we set a custom description:
MyApi:
    Type: AWS::Serverless::Api
    Properties:
      Name: "MyApi"
      StageName: "v1"
      Description: "This is my API"

Thank you

If somebody could point me the right direction about where to start, I'd be happy to try adding support for this myself and then submit a pull request.
I tried to look in the repo but could find a starting point(some type of function/class or file where I should start)

Is there a reason why it was not added from the start ?  CFN supports it... and it looks straightforward enough to add, what issue are we running into ?

Hi there,
Are there any updates on this feature request?
Thank you in advance!

It needs to be added here and probably some test cases:

https://github.com/aws/serverless-application-model/blob/02ec8bf95e33d8e5da536a75ad16cb9c6ff69d09/samtranslator/validator/sam_schema/schema.json
https://github.com/aws/serverless-application-model/blob/97dbedfeb2551633f32b02b14e271cc84fd3c5a1/samtranslator/model/sam_resources.py


feat: add comments in module code generation

Related issue (if exists)

#2868
Summary

🤖 Generated by Copilot at 15c7690
Add support for comments in the JavaScript plugin. Modify the stringify function in stringify.rs to pass the comments from the AST to the print function.

Walkthrough

🤖 Generated by Copilot at 15c7690

Preserve comments in AST when stringifying JavaScript code (link)

Would you mind adding an option to control this behavior? Not everyone wants comments in their outputs, also this would slow the codegen phase. You could add some tests in another dir, comments are kinds of noisy in tree shaking test.

I don't think it is a good option to mix this behavior with minifyOption, because according to your implementation, this option should control development mode code generation behavior as well. Would you mind waiting about one day or so? Maybe we could discuss where should we put the option, or we don't need a option just codegenerate the comments anyway.

Hey @IWANABETHATGUY , after discussing how this option should be designed🤔

We don't want this feature to introduce too much overhead, so let's bench it first.
!bench

!bench

please make sure to pass the CI, you could run UPDATE=1 cargo test -p rspack

!bench

this pr also includes some expected file change, and the tree-shaking/ts-target-es5's test seems has some diff problem, it's failed even though the expected file is same as actual file, and I'm very confused about this.

the tree-shaking/ts-target-es5 is strange, after run UPDATE=1 cargo test -p rspack, test can pass locally, but no files changed

Do you use Windows?

Do you use Windows
OS: macOS 13.0
CPU: (8) arm64 Apple M1 Pro

the expected file is indeed no difference to actual file
https://github.com/web-infra-dev/rspack/blob/4e25fafa1cf76492c89bacedb3efebbc79001cf8/crates/cargo-rst/src/rst.rs#L347-L363
Is this problem due to diff?

I don't think so,

It has some diff but will be replaced by git when you commit to GitHub.

I think you could add an option to control this behavior, like builtins.codeGeneration.keepComments

By default this option should be disabled, you could add extra test case to test this behavior, this will not conflict with current test case.

I think add this option in minifyOption is better, because webpack will keep comments by default, and remove comments is more like minify, and terser-webpack-plugin has similar option


Layout issues in Royale (High Priority)

Issues in top,bottom,left,right,height,width properties
Issues in Every File
Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Inventory from Select in Menu
Go to Misc-> Cities from Setups in Menu
File : com/dbz/modules/Common/dbzCitySetup.mxml
In Royale :
https://user-images.githubusercontent.com/42200979/70599750-cac1b100-1c0f-11ea-96b2-cfb1f59ac2a1.png
In Flex :

Go to Inventory from Select in Menu
Go to Documents-> Configure from Setups in Menu
File : com/dbz/modules/Common/dbzDocumentSetup.mxml
In Royale :
https://user-images.githubusercontent.com/42200979/70599755-cf866500-1c0f-11ea-81b4-6f965d905e1d.png
In Flex :

Go to Inventory from Select in Menu
Go to Freight Rate from Setups in Menu
File : com/dbz/modules/Common/dbzFreightRateSetup.mxml
In Royale :

In Flex :

There is major issues.
If there is a label and textinput in a row.
If name of Label is Hello World
in Royale it is showing only Hello and World is overlapped by textinput.
And half of the label text is cutted from bottom
In flex :
https://user-images.githubusercontent.com/42200979/70601840-d5cb1000-1c14-11ea-9aad-5824974e326f.png
https://user-images.githubusercontent.com/42200979/70601830-d06dc580-1c14-11ea-88b9-9eed0a327895.png
In Royale :

It turns out that Flex was using Arial and Royale was using Verdana so I changed the Royale emulation components to default to Arial.  That helps some, but the descenders on characters like g and y are getting cut off.  Flash and the browsers have different font rendering systems.  It appears that you can set the CSS line-height property to values like 0.9 and that will compress the vertical size of the font a bit and show descenders.  I'm not sure that Royale should default to an unusual line-height like 0.9 so I am not changing the Royale code at this time.  You can set line-height if you want in your app on the * or Spark Label CSS or turn off overflow:hidden on Spark Label and decide what looks best.  Or in some other cases change the width/height of the Label.  I don't think Royale can guarantee that if you set the dimensions of a text component to what the text measured in Flex that the browser will fit the text in those dimensions.


Crucible heat sources Manyullyn and Uranium do not work

Issue: Using a manyullyn block, or uranium block below a crucible provides a zero times multiplier.
Expected behaviour: Multiplier meets what is listed in JEI interface. 6x and 8x respectively, iirc.
Versions Tested: exnihilocreatio-1.12-0.2.2 with TConstruct-1.12.2-<IP_ADDRESS> for Manyullyn block

Could you please upload your /config/exnihilocreatio/HeatRegistry.json file to pastebin and post a link?
Do you have any other mods installed?

Thank you for reporting, I am able to duplicate it:
From the log using the minimal setup described above:
[18:32:15] [INFO] JEI: Heat Sources Loaded:             7

So it is loading the recipes.
Appears to be caused by: TileCrucibleStone.java:96 ignoring metadata:
 int heat = ExNihiloRegistryManager.HEAT_REGISTRY.getHeatAmount(new BlockInfo(stateBelow.getBlock()));

I have uploaded a fix

Thanks for the update @SirLyle, much appreciate it!


Analyzer should flag int-double type conversion

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?
bool initial = true;
int active = 5;
:
int ms = initial ? 0 : 1000;
if (active > 10)
  ms += (active/10) * 200;
What is the expected output?
no error/warning that "ms" became a double
Hint that
ms += (active~/10) * 200;
results in the correct type (int)

or better - as ms is defined as int the expected outcome is that it remains an int
so "no surprises" - i.e. the compiler does the ~/ automatically.

What do you see instead?
no warning - surprises at runtime.
What version of the product are you using?
1.9.3
On what operating system?
What browser (if applicable)?
n/a
Please provide any additional information below.

In the latest I get "A value of type 'double' can't be assigned to a variable of type 'int'. [invalid_assignment]"