Update dependency laravel/framework to 5.8.*

This PR contains the following updates:

Package
Type
Update
Change

laravel/framework (source)
require
minor
5.1.* -> 5.8.*

Release Notes

laravel/framework (laravel/framework)
v5.8.38
Compare Source
v5.8.37
Compare Source
v5.8.36
Compare Source
v5.8.35
Compare Source
Added

Added support of NOT RLIKE SQL operator (#29788)
Added hebrew letters to Str:slug language array (#29838, ba772d6)
Added support of php7.4 (#29842)

Fixed

Fixed self-referencing MorphOneOrMany existence queries (#29765)
Fixed QueueFake::size() method (#29761, ddaf6e6)

Changed

Added note that the GD extension is required for generating images (#29770, #29831)
Changed monolog/monolog version to ^1.12 (#29837)

v5.8.34
Compare Source
Fixed

Fixed MailMessage::render() if view method was used (#29698)
Fixed setting of numeric values as model attribute (#29714)
Fixed mocking of events until method in MocksApplicationServices (#29708)
Fixed: Use custom attributes in lt/lte/gt/gte rules messages (#29716)

Changed:

Changed applying of Aws Instance Profile (#29738)

v5.8.33
Compare Source
Added

Added ValidatesWhenResolvedTrait::passedValidation() callback (#29549)
Implement new types for email validation support (#29589)
Added Redis 5 support (#29606)
Added insertOrIgnore support (#29639, 46d7e96, #29645)
Allowed to override the existing Whoops handler.(#29564)

Fixed

Fixed non-displayable boolean values in validation messages (#29560)
Avoid undefined index errors when using AWS IAM (#29565)
Fixed exception message in the ProviderRepository::writeManifest() (#29568)
Fixed invalid link expiry count in ResetPassword (#29579)
Fixed command testing of output and questions expectations (#29580)
Added ignoring of classes which are not instantiable during event discovery (#29587)
Used real classname for seeders in the output (#29601)

Refactoring

Simplified isset() (#29581)

v5.8.32
Compare Source
Fixed

Fixed top level wildcard validation for distinct validator (#29499)
Fixed resolving of columns with schema references in Postgres (#29448)
Only remove the event mutex if it was created (#29526)
Fixed restoring serialized collection with deleted models (#29533, 74b62bb)

v5.8.31
Compare Source
Fixed

Fixed FatalThrowableError in updateExistingPivot() when pivot is non-existent (#29362)
Fixed worker timeout handler when there is no job processing (#29366)
Fixed assertJsonValidationErrors() with muliple messages (#29380)
Fixed UPDATE queries with alias (#29405)

Changed

Illuminate\Cache\ArrayStore::forget() returns false on missing key (#29427)
Allow chaining on QueryBuilder::dump() method (#29437)
Change visibility to public for hasPivotColumn() method (#29367)
Added line break for plain text mails (#29408)
Use date_create to prevent date validator warnings (#29342, #29389)

v5.8.30
Compare Source
Added

Added MakesHttpRequests::option() and MakesHttpRequests::optionJson() methods (#29258)
Added Blueprint::uuidMorphs() and Blueprint::nullableUuidMorphs() methods (#29289)
Added MailgunTransport::getEndpoint() and MailgunTransport::setEndpoint() methods (#29312)
Added WEBP to image validation rule (#29309)
Added TestResponse::assertSessionHasInput() method (#29327)
Added support for custom redis driver (#29275)
Added Postgres support for collation() on columns (#29213)

Fixed

Fixed collections with JsonSerializable items and mixed values (#29205)
Fixed MySQL Schema Grammar $modifiers order (#29265)
Fixed UPDATE query bindings on PostgreSQL (#29272)
Fixed default theme for Markdown mails (#29274)
Fixed UPDATE queries with alias on SQLite (#29276)
Fixed UPDATE and DELETE queries with join bindings on PostgreSQL (#29306)
Fixed support of DateTime objects and int values in orWhereDay(), orWhereMonth(), orWhereYear() methods in the Builder (#29317)
Fixed DELETE queries with joins on PostgreSQL (#29313)
Prevented a job from firing if job marked as deleted (#29204, 1003c27)
Fixed model deserializing with custom Model::newCollection() (#29196)

Reverted

Reverted: Added possibility for WithFaker::makeFaker() use local app.faker_locale config (#29250)

Changed

Allocate memory for error handling to allow handling memory exhaustion limits (#29226)
Teardown test suite after using fail() method (#29267)

v5.8.29
Compare Source
Added

Added possibility for WithFaker::makeFaker() use local app.faker_locale config (#29123)
Added ability to set theme for mail notifications (#29132)
Added runtime for each migration to output (#29149)
Added possibility for whereNull and whereNotNull to accept array columns argument (#29154)
Allowed Console\Scheduling\ManagesFrequencies::hourlyAt() to accept array of integers (#29173)

Performance

Improved eager loading performance for MorphTo relation (#29129)

Fixed

Fixed Builder::whereDay() and Builder::whereMonth() with raw expressions
Fixed DELETE queries with alias on SQLite (#29164)
Fixed queue jobs using SerializesModels losing order of passed in collections (#29136)
Fixed conditional binding for nested optional dependencies (#29180)
Fixed: validator not failing on custom rule when message is null (#29174)
Fixed DELETE query bindings (#29165)

v5.8.28
Compare Source
Added

Make TestResponse tappable (#29033)
Added Support\Collection::mergeRecursive() method (#29084)
Added Support\Collection::replace() and Support\Collection::replaceRecursive() methods (#29088)
Added Session\Store::only() method (#29107)

Fixed

Fixed cache repository setMultiple with an iterator (#29039)
Fixed cache repository getMultiple implementation (#29047)

Reverted

Reverted Fixed: app.stub for jquery components loading (#29001)

Changed

Fail job immediately after it timeouts if it wont be retried (#29024)

v5.8.27
Compare Source
Added

Let mix helper use app.mix_url config (#28952)
Added RedisManager::setDriver() method (#28985)
Added whereHasMorph() and corresponding methods to work with MorphTo relations (#28928)

Fixed

Fixed: Changing a database field to binary include collation (#28975)
Fixed app.stub for jquery components loading (#29001)
Fixed equivalent for greek letter theta in Str::ascii() (#28999)

Changed

Prevented TestResponse::dump() and TestResponse::dumpHeaders() methods from ending execution of the script (#28960)
Allowed TestResponse::dump() and TestResponse::dumpHeaders() methods chaining (#28967)
Allowed to NotificationFake accept custom channels (#28969)
Replace contents of service manifest atomically (#28973)
Pass down the serverVersion database connection option to Doctrine DBAL connection (#28964, 1b55b28)
Replace self:: with static:: in the Relation::getMorphedModel() (#28974)
Set a message for SuspiciousOperationException (#29000)
Storing Mailgun Message-ID in the headers after sending (#28994)

v5.8.26
Compare Source
v5.8.26 (2019-06-25)
Reverted

Reverted: Let mix helper use app.asset_url (#28950)

v5.8.25
Compare Source
Added

Added json option to route:list command (#28894)

Fixed

Fixed columns parameter on paginate method (#28937)
Prevent event cache from firing multiple times the same event(s) (#28904)
Fixed TestResponse::assertJsonMissingValidationErrors() on empty response (#28595, #28913)
Fixed percentage sign in filename fallback in the FilesystemAdapter::response() (#28947)

Changed

Allow TestResponse::assertViewHas() to see all data (#28893)
Let mix helper use app.asset_url (#28905)

v5.8.24
Compare Source
Added

Added possibility to assert that the session contains a given piece of data using a closure in TestResponse::assertSessionHas() (#28837)
Added TestResponse::assertUnauthorized() (#28851)
Allowed to define port in ServeCommand via SERVER_PORT env variable (#28849, 6a18e73)
Allowed console environment argument to be separated with a space (#28869)
Added @endcomponentFirst directive (#28884)
Added optional parameter $when to retry helper (85c0801)

Fixed

Fixed Builder::dump() and Builder::dd() with global scopes (#28858)

Reverted

Reverted: Automatically bind the viewAny method to the index controller action (#28865)

Changed

Handle SuspiciousOperationException in router as NotFoundHttpException (#28866)

v5.8.23
Compare Source
v5.8.23 (2019-06-14)
Fixed

Fixed strict comparison in redis configuration Parsing. (#28830)

Changed

Improved support for arrays on TestResponse::assertJsonValidationErrors() (2970dab)

v5.8.22
Compare Source
Added

Added @componentFirst directive (#28783)
Added support for typed eager loads (#28647, d72e3cd)
Added Related and Recommended to Pluralizer (#28749)
Added Str::containsAll() method (#28806)
Added: error handling for maintenance mode commands (#28765, 9e20849)
Added message value assertion to TestResponse::assertJsonValidationErrors() (#28787)
Added: Automatically bind the viewAny method to the index controller action (#28820)

Fixed

Fixed database rules with where clauses (#28748)
Fixed: MorphTo Relation ignores parent $timestamp when touching (#28670)
Fixed: Sql Server issue during dropAllTables when foreign key constraints exist (#28750, #28770)
Fixed Model::getConnectionName() when Model::cursor() used (#28804)

Changed

Made force an optional feature when using ConfirmableTrait. (#28742)
Suggest resolution when no relationship value is returned in the Model::getRelationshipFromMethod() (#28762)

v5.8.21
Compare Source
Fixed

Fixed redis cluster connection parsing (2bcb405)

v5.8.20
Compare Source
Added

Added viewAny() to dummy policy class (#28654, #28671)
Added fullpath option to make:migration command (#28669)

Performance improvement

Improve performance for Arr::collapse() (#28662, #28676)

Fixed

Fixed artisan cache:clear command with a redis cluster using the Predis library (#28706)

v5.8.19
Compare Source
Added

Added optional DYNAMODB_ENDPOINT env variable to configure endpoint for DynamoDB (#28600)
Added Illuminate\Foundation\Application::isProduction() method (#28602)
Allowed exception reporting in rescue() to be disabled (#28617)
Allowed to parse Url in Redis configuration (#28612, f4cfb32)
Allowed setting additional (sourceip and localdomain) smtp config options (#28631, 435c05b)

Fixed

Fixed Eloquent UPDATE queries with alias (#28607)
Fixed Illuminate\Cache\DynamoDbStore::forever() (#28618)
Fixed event:list command, when using a combination of manually registering events and event auto discovering (#28624)

Performance improvement

Improve performance for Arr::flatten() (#28614)

Changed

Added id to ModelNotFoundException exception in ImplicitRouteBinding (#28588)

v5.8.18
Compare Source
Added

Added html as a new valid extension for views (#28541)
Added: provide notification callback withSwiftMessage in MailMessage (#28535)

Fixed

Fixed Illuminate\Cache\FileStore::getPayload() in case of broken cache (#28536)
Fixed exception: The filename fallback must only contain ASCII characters in the Illuminate\Filesystem\FilesystemAdapter::response() (#28551)

Changed

Make Support\Testing\Fakes\MailFake::failures() returns an empty array (#28538)
Make Support\Testing\Fakes\BusFake::pipeThrough() returns $this (#28564)

Refactoring

Cleanup html (#28583)

v5.8.17
Compare Source
Added

Added Illuminate\Foundation\Testing\TestResponse::dumpHeaders() (#28450)
Added ends_with validation rule (#28455)
Added possibility to use a few columns arguments in the route:list command (#28459)
Added retryAfter in Mail\SendQueuedMailable and Notifications\SendQueuedNotifications object (#28484)
Added Illuminate\Foundation\Console\Kernel::scheduleCache() (6587e78)
Added support for multiple --path options within migrate commands (#28495)
Added Tappable trait (#28507)
Added support auto-discovery for events in a custom application directory, that sets via Illuminate\Foundation\Application::useAppPath() (#28493)
Added passing of notifiable email through reset link (#28475)
Added support flush db on clusters in PhpRedisConnection and PredisConnection (f4e8d5c)

Fixed

Fixed session resolver  in RoutingServiceProvider (without bind of session in Container) (#28438)
Fixed route:list command when routes were dynamically modified (#28460, #28463)
Fixed required validation with multiple passes() calls (#28502)
Fixed the collation bug when changing columns in a migration (#28514)
Added password to the RedisCluster only if redis >= 4.3.0 (1371940)
Used escapeshellarg on windows symlink in Filesystem::link()(44c3feb)

Changed

Reset webpack file for none preset (#28462)

v5.8.16
Compare Source
Added

Added: Migration Events (#28342)
Added ability to drop types when running the migrate:fresh command (#28382)
Added Renderable functionality to MailMessage (#28386)

Fixed

Fixed the remaining issues with registering custom Doctrine types (#28375)
Fixed fromSub() and joinSub() with table prefix in Query\Builder (#28400)
Fixed false positives for Schema::hasTable() with views (#28401)
Fixed sync results with custom Pivot model (#28416, e31d131)

Changed

Modified None And React presets with vue-template-compiler (#28389)
Changed navbar-laravel class to bg-white shadow-sm class in layouts\app.stub (#28417)
Don't execute query in Builder::findMany() when ids are empty Arrayable (#28432)
Added parameter password for RedisCluster construct function (#28434)
Pass email verification URL to callback in Auth\Notifications\VerifyEmail (#28428)
Updated RouteAction::parse() (#28397)
Updated Events\DiscoverEvents (#28421, #28426)

v5.8.15
Compare Source
Added

Added handling of database URL as database connections (#28308, 4560d28, 05b029e)

Changed:

Fix BelongsToMany read wrong parent key (#28317)
Fix make:auth not using apps configured views path (#28324, e78cf02)
Add custom message to thrown exception (#28335)
Fix recursive replacements in Str::replaceArray() (#28338)
Add the dd method to the query builder (#28357)
Improve output of "assertSessionDoesntHaveErrors" when called with no arguments (#28359)
Allow logging out other devices without setting remember me cookie (#28366)
Break out password reset credentials into a method (#28370)

v5.8.14
Compare Source
Added

Implemented Job Based Retry Delay (#28265)

Changed

Update auth stubs with @error blade directive (#28273)
Convert email data tables to layout tables (#28286)

Reverted

Partial reverted ability of register custom Doctrine DBAL, since of #28282 issue (#28301)

Refactoring

Replace code with Null Coalescing Operator (#28280, #28287)

v5.8.13
Compare Source
Added

Added @error blade directive (#28062)
Added the ability to register custom Doctrine DBAL types in the schema builder (#28214, 91a6afe)

Fixed

Fixed: Event::fake() does not replace dispatcher for guard (#28238, be89773)

Reverted

Reverted of possibility for use in / not in operators in the query builder since of issue with wherePivot() method (04a547ee)

v5.8.12
Compare Source
Added

Added Illuminate\Support\Collection::duplicates() (#28181)
Added Illuminate\Database\Eloquent\Collection::duplicates() (#28194)
Added Illuminate\View\FileViewFinder::getViews() (#28198)
Added helper methods onSuccess() \ onFailure() \ pingOnSuccess() \ pingOnFailure() \ emailOnFailure() to Illuminate\Console\Scheduling\Event (#28167)
Added SET datatype on MySQL Grammar (#28171)
Added possibility for use in / not in operators in the query builder (#28192)

Fixed

Fixed memory leak in JOIN queries (#28220)
Fixed circular dependency in Support\Testing\Fakes\QueueFake for undefined methods (#28164)
Fixed exception in lt \ lte \ gt \ gte validations with different types (#28174)
Fixed string quoting for SQL Server (#28176)
Fixed whereDay and whereMonth when passing int values (#28185)

Changed

Added autocomplete attributes to the html stubs (#28226)
Improved event:list command (#28177, cde1c5d)
Updated Illuminate\Database\Console\Factories\FactoryMakeCommand to generate more IDE friendly code (#28188)
Added missing LockProvider interface on DynamoDbStore (#28203)
Change session's user_id to unsigned big integer in the stub (#28206)

v5.8.11
Compare Source
Added

Allowed to call macros directly on Illuminate\Support\Facades\Date (#28129)
Allowed lock to be configured in local filesystems (#28124)
Added tracking of the exit code in scheduled event commands (#28140)

Fixed

Fixed of escaping single quotes in json paths in Illuminate\Database\Query\Grammars\Grammar (#28160)
Fixed event discovery with different Application Namespace (#28145)

Changed

Added view path to end of compiled blade view (in case if path is not empty) (#28117, #28141)
Added realpath to app_path during string replacement in Illuminate\Foundation\Console\Kernel::load() (82ded9a)

Refactoring

Refactoring of Illuminate\Foundation\Events\DiscoverEvents::within() (#28122, 006f999)

v5.8.10
Compare Source
Added

Added replicating model event (#28077)
Make NotificationFake macroable (#28091)

Fixed

Exclude non-existing directories from event discovery (#28098)

Changed

Sorting of events in event:list command (3437751)
Removed path hint in compiled view (33ce7bb)

v5.8.9
Compare Source
Added

Added Event Discovery (#28064, #28085)

Fixed

Fixed serializing a collection from a Resource with preserveKeys property (#27985)
Fixed: SoftDelete::runSoftDelete and SoftDelete::performDeleteOnModel with overwritten Model::setKeysForSaveQuery (#28081)

Changed

Update forever cache duration for database driver from minutes to seconds (#28048)

Refactoring:

Refactoring of Illuminate\Auth\Access\Gate::callBeforeCallbacks() (#28079)

v5.8.8
Compare Source
Added

Added Illuminate\Database\Query\Builder::forPageBeforeId() method (#28011)

Fixed

Fixed BelongsToMany::detach() with custom pivot class (#27997)
Fixed incorrect event namespace in generated listener by event:generate command (#28007)
Fixed unique validation without ignored column (#27987)

Changed

Added parameters argument to resolve helper (#28020)
Don't add the path only if path is empty in compiled view (#27976)

Refactoring

Refactoring of env() helper (#27965)

v5.8.7
Compare Source
v5.8.6
Compare Source
Fixed

Fix: Locks acquired with block() are not immediately released if the callback fails (#27957)

Changed

Allowed retrieving env variables with getenv() (#27958, c37702c)
Used stripslashes for Validation\Rules\Unique.php (#27940, 34759cc)

Refactoring

Refactoring of Illuminate\Http\Concerns::allFiles() (#27955)

v5.8.5
Compare Source
Added

Added Illuminate\Database\DatabaseManager::setReconnector() (#27845)
Added Illuminate\Auth\Access\Gate::none() (#27859)
Added OtherDeviceLogout event (#27865, 5e87f2d)
Added even and odd flags to the Loop variable in the blade (#27883)

Changed

Add replacement for lower danish æ (#27886)
Show error message from exception, if message exist for 403.blade.php and 503.blade.php error (#27893, #27902)

Fixed

Fixed seeding logic in Arr::shuffle() (#27861)
Fixed Illuminate\Database\Query\Builder::updateOrInsert() with empty $values (#27906)
Fixed Application::getNamespace() method (#27915)
Fixed of store previous url (#27935, 791992e)

Security

Changed Validation\Rules\Unique.php (da4d4a4). You can read more here

v5.8.4
Compare Source
Added

Added Illuminate\Support\Collection::join() method (#27723)
Added Illuminate\Foundation\Http\Kernel::getRouteMiddleware() method (#27852)
Added danish specific transliteration to Str class (#27857)

Fixed

Fixed JSON boolean queries (#27847)

v5.8.3
Compare Source
Added

Added Collection::countBy (#27770)
Added protected EloquentUserProvider::newModelQuery() (#27734, 9bb7685)
Added protected StartSession::saveSession() method (#27771, 76c7126)
Allow belongsToMany to take Model/Pivot class name as a second parameter (#27774)

Fixed

Fixed environment variable parsing (#27706)
Fixed guessed policy names when using Gate::forUser (#27708)
Fixed via as string in the Notification (#27710)
Fixed StartSession middleware (499e4fe)
Fixed stack channel's bug related to the level (#27726, bc884bb)
Fixed email validation for not string values (#27735)

Changed

Check if MessageBag is empty before checking keys exist in the MessageBag (#27719)

v5.8.2
Compare Source
v5.8.2 (2019-02-27)
Fixed

Fixed quoted environment variable parsing (#27691)

v5.8.1
Compare Source
v5.8.1 (2019-02-27)
Added

Added Illuminate\View\FileViewFinder::setPaths() (#27678)

Changed

Return fake objects from facades (#27680)

Reverted

reverted changes related to the Facade (63d87d7)

v5.8.0
Compare Source
Check the upgrade guide in the Official Laravel Documentation.
v5.7.29
Compare Source
v5.7.28
Compare Source
Added

Add support for Pheanstalk 4.x (#27622)
Allow configuration of token guard keys (#27585)

Changed

Update vue preset to exclude @babel/preset-react (#27645)
Reflash the session for the broadcasting auth call (#27647)
Improving readability in AuthenticateWithBasicAuth Middleware (#27661)
Use safe container getter on Pipeline (#27648)

Fixed

Fixed Postgres grammar when using union queries (#27589)
Fixed an issue when using Mail::queue to queue Mailables (#27618)
Fixed error in Foundation\Exceptions\Handler (#27632)

v5.7.27
Compare Source
v5.7.26
Compare Source
Added

Added Illuminate\Pipeline\Pipeline::thenReturn() (#27429)
Added Illuminate\Cache\TaggedCache::getTags() (#27445)
Added Illuminate\Http\ResponseTrait::getCallback() (#27464)
Added  license file to each component (9e57e8b)
Added Model::withoutEvents() method (#27419, 5c5d6b2)

Reverted

Revert of "Fixed wrong class being used when eager loading nullable MorphTo with withDefault() (#27411)"(9bbf644)

Changed

Improved error message in Illuminate\Foundation\Testing\TestResponse::assertJsonValidationErrors() (#27495, 98010da)
Illuminate\Support\Testing\Fakes\EventFake::dispatch() will return response (#27430)

v5.7.25
Compare Source
Added

Allowed specifying custom translation for date relative messages (#27341)
Add computed support to SQL Server schema grammar (#27346, 1c74d7f)
Allowed ENV to control paths of cache files for services, packages and routes (#27389)

Fixed

Fixed BelongsToMany pivot relationship child with loaded relations wakeup (#27358)
Fixed wrong class being used when eager loading nullable MorphTo with withDefault() (#27411)

Changed

Removed php_network_getaddresses: getaddrinfo failed: Name or service not known in DetectsLostConnections trait (#27418)

v5.7.24
Compare Source
Fixed

Fixed ResetPassword notification (#27351, b130771)

v5.7.23
Compare Source
Added

Added AbstractPaginator::getOptions() method (#27273)
Added Communication link failure to DetectsLostConnections trait (#27307)
Added orWhere() proxy for scopes to EloquentBuilder (#27281, 2e6fe85)
Allow the app path to be configured (#27332, d73e672)
Added config for using WhatFailureGroupHandler when StackDriver created for Logger (#27308 ,6a92651)

Fixed

Fixed QueueableCollection serialization of Eloquent Models when using Binary IDs (#27271)
Replaced newModelQuery() with newQueryWithoutRelationships() for UPDATE/DELETE queries (#27277)

Changed

Apply parameters to entire localization array (#27254)
Added line about expiring password reset in notification email (#27324, 80c5aec)
"Go Home" link will redirect to the home route on exception page (#27343)

v5.7.22
Compare Source
Fixed

Fixed TestResponse::assertJsonValidationErrors() when there are no errors (#27190)

Changed

Allowed TestResponse::assertJsonMissingValidationErrors() to be called without an argument (#27176)
Updated vue preset's vue-stubs for laravel-mix 4 compatibility (#27229)
Updated preset to use @babel/preset-react (#27235)
Used config to resolve the database value during tests. (#27240)

v5.7.21
Compare Source
Fixed

Fixed Blueprint::removeColumn() (#27115, #27122)
Fixed allowing of null broadcast connection driver (#27135)
Fixed ModelMakeCommand::handle() should always return bool value (#27156)
Fixed TestResponse::assertSessionDoesntHaveErrors() when there is no errors (#27145)
Fixed default message is localization twice in 403.blade.php error page (4a08120)

Changed

Replaced get_called_class() to static::class (#27146)
Re-throw NoMatchingExpectationException from PendingCommand (#27158)

v5.7.20
Compare Source
Added

Added chunkById support in relations (#26919)
Added Collection::whereNotBetween method (#27028)
Allowed predefined log channels to change formatter from config (#26895)
Allowed storage assertions (FilesystemAdapter::assertExists / FilesystemAdapter::assertMissing) to handle multiple files at once (#26975)
Added Adaptive Server connection failed to DetectsLostConnections trait (#27055)
Added Route::originalParameters() (#27056)
Added QueueFake::pushedJobs() (#27089, 695ffa1)

Fixed

Prevents unnecessary queries when lazy loading empty relationships (#26992)
Fixed broken Command::setHidden method (#27005)
Fixed Str::slug method (#27002)
Ignore `-

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: composer.lock
Command failed: composer update laravel/framework:5.8.38 --with-dependencies --ignore-platform-req='ext-*' --ignore-platform-req='lib-*' --no-ansi --no-interaction --no-scripts --no-autoloader --no-plugins
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires laravel/framework 5.8.* -> satisfiable by laravel/framework[v5.8.38].
    - laravel/framework v5.8.38 requires php ^7.1.3 -> your php version (8.2.12) does not satisfy that requirement.
  Problem 2
    - fzaninotto/faker is locked to version v1.9.2 and an update of this package was not requested.
    - fzaninotto/faker v1.9.2 requires php ^5.3.3 || ^7.0 -> your php version (8.2.12) does not satisfy that requirement.
  Problem 3
    - doctrine/common v2.7.3 requires php ~5.6|~7.0 -> your php version (8.2.12) does not satisfy that requirement.
    - doctrine/dbal v2.5.13 requires doctrine/common >=2.4,<2.8-dev -> satisfiable by doctrine/common[v2.7.3].
    - doctrine/dbal is locked to version v2.5.13 and an update of this package was not requested.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.


Fix Numba for LLVM 3.8

This needs https://github.com/numba/llvmlite/pull/176 first.

[Current coverage][cc-pull] is 87.36%

Merging [#1938][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master      #1938   diff @@
==========================================
  Files           299        299
  Lines         52909      52909
  Methods           0          0
  Messages          0          0
  Branches       5456       5456
==========================================
  Hits          46226      46226
  Misses         5769       5769
  Partials        914        914

Powered by Codecov. Last updated by [1061233...e4dde30][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/106123318c50c85f69279f89f790597771a745e8...e4dde30b3ecca34815f2aacbde0ba46267a3057c
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1938?src=pr


[Storage][DataLake] Address concerns about DataLakeClientOptions

https://github.com/Azure/azure-sdk-for-net/pull/8235
tg-msft 3 days ago Member
This one can't be skipped. Every ClientOptions needs to have a ServiceVersion enum and take it in the .ctor following the pattern.
@seanmcc-msft
seanmcc-msft 3 days ago •
Author Member
Why? DataLakeClientOptions extends BlobClientOptions, so it has the ServiceVersion enum and exposes its parent's constructors.
@tg-msft
tg-msft 19 hours ago Member
Yeah, I guess maybe deriving from BlobClientOptions is more of the problem here. I'm not sure we should do that, but that's a GREAT thing to discuss during the API review on Thursday. Let's go in like this for now.
@seanmcc-msft
seanmcc-msft 15 hours ago Author Member
I derived from BlobClientOptions because I don't see a reason why DataLakeClientOptions shouldn't be identical to BlobClientOptions other than the name of the class, and the namespace. Why write extra code for the same functionality?

https://github.com/Azure/azure-sdk-for-net/issues/8485


Running count metric & jump method OverflowError: cannot convert float infinity to integer

Hello @hongyeehh, I'm getting this error when running Count Metric & Jump Method:
Running count metric & jump method
Values less than or equal to 0 in data. Throwing out 0 or negative values
/usr/local/lib/python3.10/dist-packages/powerlaw.py:1965: RuntimeWarning: divide by zero encountered in scalar divide
  xmax2=xmax/xmin
Traceback (most recent call last):
  File "/odtp/odtp-workdir/mobility-metrics/mobmetric/scripts/run_metrics.py", line 84, in <module>
    powerlaw.plot_pdf(metric, label="data")
  File "/usr/local/lib/python3.10/dist-packages/powerlaw.py", line 2083, in plot_pdf
    edges, hist = pdf(data, linear_bins=linear_bins, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/powerlaw.py", line 1978, in pdf
    number_of_bins = ceil((log_max_size-log_min_size)*10)
OverflowError: cannot convert float infinity to integer
mv: cannot stat '/odtp/odtp-workdir/mobility-metrics/data/output/jump.png': No such file or directory

Here, I dropped the input files and the command I'm using:
mobility-metrics/mobmetric/scripts/run_metrics.py count jump dtepr

odtp-output.zip
odtp-input.zip
Version of the tool: https://github.com/irmlma/mobility-metrics/commit/7c1e475940ebf941b788c800685d501d18379c67

Hi @caviri, thanks for the report. I was able to reproduce and fix the error.
The problem comes from here, where the calculated metrics contains 0, and the plotting function tries to plot the 0 in log scale.
This is now fixed by only taking the values larger than xmin (default to 1) for plotting. The filter has a negligible effect on the actual results.
Please check whether the error persists with the latest commit.


154 expand mesh vocabulary

download MeSH files from official website
read qualifier MeSH files
convert to terms + qualifiers list
provide CLI to generate vocabulary list
release: v2022.3.8
closes https://github.com/galterlibrary/digitalhub-2/issues/154

@Meowcenary

On DigitalHub it uses "--" to delimit the qualifier instead of "/" , but that's no problem.

Good to know. I ended up choosing / because that's what the MeSH browser uses as the label: https://id.nlm.nih.gov/mesh/D000068098Q000941.html .


feat(bfdr): implement more fetal death cause or conditions

Fetal Death Cause or Condition Part 2
COD18a9 through COD18a14

The changes look good, just needs a rebase


Missing 256-bit vpermps ?

So, I was looking through the shuffles multiple time, and I did not find an equivalent of the _mm256_permutevar8x32_ps Intel intrinsic, which maps into the vpermps hardware instruction.
According to your naming convention, I think it should be called shuffle_av_f32_all_m256.

Not sure how I missed this one, but sure I'd take a PR for this.

Ah, after looking through the source code, it's actually there, but incorrectly named shuffle_av_i32_all_m256.
So another topic for naming convention cleanup.


Seg fault for llama.8b.fp16.mlir model

What happened?
Following mlir getting seg fault.
https://raw.githubusercontent.com/nod-ai/llm-dev/main/models/llama.8b/llama.8b.fp16.mlir
Steps to reproduce your issue
wget https://raw.githubusercontent.com/nod-ai/llm-dev/main/models/llama.8b/llama.8b.fp16.mlir
iree-compile --iree-hal-target-backends=rocm --iree-input-demote-i64-to-i32 --iree-hip-target=gfx942 llama.8b.fp16.mlir
What component(s) does this issue relate to?
Compiler
Version information
No response
Additional context
No response

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

I think this is an issue with weight parameters handling, here is a full crash dump
See this line
#20 0x00007e0514d070b9 mlir::iree_compiler::IREE::VM::ZIPArchiveWriter::flush(mlir::iree_compiler::FlatbufferBuilder&)
 /home/nmeshram/iree/compiler/src/iree/compiler/Dialect/VM/Target/Bytecode/ArchiveWriter.cpp:661:20

I have seen this when weights were not correctly ellided but in this models input IR I dont see such an issue
The provided model has these weights
  util.global private @__auto.token_embd.weight = #stream.parameter.named<"model"::"token_embd.weight"> : tensor<128256x4096xf16>
  util.global private @__auto.blk.0.attn_norm.weight = #stream.parameter.named<"model"::"blk.0.attn_norm.weight"> : tensor<4096xf32>
  util.global private @__auto.blk.0.attn_q.weight = #stream.parameter.named<"model"::"blk.0.attn_q.weight"> : tensor<4096x4096xf16>
...

which I assume will be provided at runtime but we have this crash at compile time. @benvanik @MaheshRavishankar do you see something wrong in the input mlir?

Same as the issues before - someone manually deleted resources that are required for correct processing of the IR. Is there some workflow people are now doing that involves deleting critical lines of MLIR files?

(we should have guards for not crashing and emitting an error, but emitting an error is the best we can do in these cases - so worth both having better errors and figuring out what workflow is causing this to happen as we've had multiple people doing it this week)

@pdhirajkumarprasad  this seems like a user error. Please close if this is fixed. I am taking it out of the compilation error tracking project

this issue is no more there in nightly


Sex-specific difference in phenotype of Kabuki syndrome type 2 patients:

[KMT2D](https://pubmed.ncbi.nlm.nih.gov/38373926/)
This was a small study. Test this with our relatively large cohort

Males were significantly more likely to be born prematurely, have shorter stature, and severe developmental delay/ID.
https://pubmed.ncbi.nlm.nih.gov/33674768/
-- this gene would be a good test case.

There was a difference in Severe global delay that failed to achieve statistical significance, but the software appears to be working. We will want to use the software for all cohorts in the final analysis.


gRPC Unsubscribe/Subscribe function

Extend the gRPC server and client with the commands to subscribe unsubscribe a path in the VSS tree. Therefore extending the input handling of the client the kuksa.proto file and the server implementation of the rpc methods.

#299 implements a subscirbe/unsubscribe interface on gRPC.


Feature/local cache

Implements support for a local cache as of #38 ~without--skip-local-cachefor now~.
A local cache is specified by adding the key-value pair local = /Users/blender/Desktop/rome in the [Cache] section of a Romefile.
When uploading a framework or dSYM they both are also copied to the local cache.
When downloading a framework or a dSYM the local cache is used. If the framework or dSYM does not exist in the local cache the it's fetched from remote.

Implemented --skip-local-cache CLI flag for upload/download

Now supports all paths for local cache, not only absolute paths


setEmail and logoutEmail cause entire app to freeze

Description:
Calling setEmail or logoutEmail causes the entire app to freeze in Android. Not seeing the same thing happening for iOS
Environment

react-native: 0.55.4
react-native-onesignal: 3.2.5
Tested on real Samsung Galaxy s9 and emulated Pixel 2.7
App is in beginning stages so don't have a real signed staging app to test against (not sure if that matters)

Steps to Reproduce Issue:

Login to our app - flow calls setEmail and app totally freezes
Restart the app and see it load data verifying the login function did work
Logout - flow calls logoutEmail and app totally freezes again
Restart the app and see logout was successful

Anything else:

Doing abd logcat while running the emulator shows that there is a recurring log message stating  NetRecChimeraGcmTaskService.a: Still entries pending update, scheduling new rapid_refresh_scores_task refresh. which kinda makes think that the call never completes and just hangs the app up 🤷♂

@burdell Are you getting an ANR? Can you post it please? Unfortunately I am not able to reproduce this problem.

@Nightsd01
after doing a little more digging, I think the freezing part was a weird condition of logging in and out of various devices with a few different testing logins...couldn't actually figure out the root cause of that was
After I went through and just cleared out all the test logins / devices from our OneSignal staging feed, I DID find that logging into iOS adds the device to the push notification feed, but logging into the Android app adds the device to the email notification feed. So that makes sense that I can get iOS notifications, but not Android.
We're doing push notifications in our current Ionic app by the associated user's email (not sure if that's standard practice or the reasoning behind that...I inherited this notification setup a few weeks ago). Trying to just hook up our re-written React Native app to the current OneSignal feeds
Right now I'm calling both sendTag and setEmail:
OneSignal.sendTag("email", userEmail);
OneSignal.setEmail(userEmail, () => ({}));

Not sure if this is the correct way to do this...most documentation seems to lean towards using the corresponding device id.
Any direction here? Maybe I close this and open a new issue?

@burdell I am not sure I understand what you're asking? You should be able to target push notifications with a user's email address without having to set it as a tag.

@burdell Closing issue due to no response, I assume you got it working? If not please respond and I'll be happy to reopen the issue.


MongoDB version missmatch

What happened:
Litmus dont deploy on fresh install:
Readiness seem to be broken
  Normal   Pulled            5m19s  kubelet            Successfully pulled image "litmuschaos/mongo:4.2.8" in 1.172323519s
  Normal   Created           5m19s  kubelet            Created container mongo
  Normal   Started           5m19s  kubelet            Started container mongo
  Warning  Unhealthy         5m11s  kubelet            Readiness probe failed:

litmus-server Init containers fail:
Waiting for the MongoDB to be ready...
Connection with MongoDB established
MongoDB shell version v4.0.5
connecting to: mongodb://litmusportal-mongo:27017/?gssapiServiceName=mongodb
Implicit session: session { "id" : UUID("be728ae5-f4e1-46e3-91a5-14d4cf67a81a") }
MongoDB server version: 4.2.8
WARNING: shell and server versions do not match
{ "acknowledged" : true, "matchedCount" : 0, "modifiedCount" : 0 }

What you expected to happen:
I expected the client and server in the same version
How to reproduce it (as minimally and precisely as possible):
Values -> https://github.com/Vr00mm/deploy-litmus/tree/main/values/litmus
CI/CD -> https://github.com/Vr00mm/deploy-litmus/actions/runs/1516553148
Anything else we need to know?:

@imrajdas @amityt can you PTAL?
@Vr00mm can you confirm if you're still facing this issue?

Hello,
I dont think so, it was old litmus version.
Didnt face it again.
We use 2.8 currently

Hello,
I dont think so, it was old litmus version.
Didnt face it again.
We use 2.8 currently

Awesome, closing this issue! Thanks for participating!


Ideas: Substituting events like crashed pawns, toxic fallout, and solar flares with lore-friendly options

Transport pod crashes

Unconscious NPC spawns in on the edge of the map, "So-and-so wanders into your village, wounded, exhausted and starving after being split from their group in a battle. Give him medical attention and send him home."
Or for NPCs with no faction, "after narrowly escaping a bandit ambush"

Toxic fallout

Replace with something magicky that requires you to either hole up inside, or avoid certain areas of the map. Might be difficult to implement an affliction punishment like toxic fallout's buildup and subsequent cancer risk.

Solar flares

Ithildien lamps malfunction for a day
Everybody gets sudden spooky magical weariness and cannot craft/craft slower than normal (which should be just as annoying as unpowered workbenches in vanilla)

Ancient danger

Instead of a room full of cryosleep caskets or mechanoids, just spawn dwarven stronghold walled rooms and throw in piles of treasure, good armor, and possibly dragons

Psychic events

Uhhh.. magic?

Tornados

Bring them back, they're just too infuriating not to have

Other ideas?

Mystical Shaman

Currently can't do this event when it comes up, because trade beacons are not available, but it is a useful and lore-friendly quest. I'd suggest requiring you to bring silver to an outpost of the faction that has the information or something similar.


Adds CRUD support for databrew recipe jobs and profile jobs

Adds initial support for databrew profile jobs and recipe jobs
The following new methods are supported:

create_profile_job()
create_recipe_job()
delete_job()
describe_job()
list_jobs()
update_profile_job()
update_recipe_job()

Also fixed the following:

describe_recipe() and describe_ruleset() now correctly get picked up by the scripts/implementation_coverage.py script and so appear in IMPLEMENTATION_COVERAGE.md and docs/docs/services/databrew.rst
CreateDate field now correctly returned in recipes and datasets
Fixed HTTP status code returned by databrew describe_ruleset() and delete_ruleset()

Codecov Report

Merging #5244 (0a4f6f8) into master (d03891e) will increase coverage by 0.00%.
The diff coverage is 99.39%.

@@           Coverage Diff            @@
##           master    #5244    +/-   ##
========================================
  Coverage   95.94%   95.94%
========================================
  Files         688      688
  Lines       68484    68643   +159
========================================
+ Hits        65704    65861   +157
- Misses       2780     2782     +2

Flag
Coverage Δ

servertests
36.28% <23.49%> (-0.04%)
:arrow_down:

unittests
95.88% <99.39%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/databrew/urls.py
100.00% <ø> (ø)

moto/databrew/models.py
96.81% <99.07%> (+0.99%)
:arrow_up:

moto/__init__.py
97.20% <100.00%> (ø)

moto/databrew/responses.py
99.04% <100.00%> (+0.32%)
:arrow_up:

moto/efs/models.py
91.07% <0.00%> (-0.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cee3c...0a4f6f8. Read the comment docs.


I find my plot is discontinuous

I'm using fgivenx to make plots from GetDist chains. But I find my curve is discontinuous for the part where the uncertainty region is relatively narrow.  I try to take more values for X axis, i.e.,  let
k=numpy.logspace(23,30,500)， instead of k=numpy.logspace(23,30,100)，
but it did not improve the result significantly. Could you help me and check the problem?

In addition, as you see, the fgivenx plot the entire sigma regions. Could I just
plot the 1 sigma region for my function? Thanks very much.
Below is my python code:
#######################################################################
import numpy as np
import matplotlib.pyplot as plt
from fgivenx import plot_contours, samples_from_getdist_chains

file_root = './bb/test'
samples, weights = samples_from_getdist_chains(['p1','p2','p3','p4','p5','p6','p7','p8','p9','p10'], file_root)
print(type(samples))
print(np.size(samples))
print(np.shape(samples))

z=1.0
nbin=500

def phi(z,L,theta):
    p1,p2,p3,p4,p5,p6,p7,p8,p9,p10 = theta
    rho=1.0/( ((1+p1)/(1+z))**p5 + ((1+p1)/(1+z))**p6 ) * ( ((1+p1)/(1+0.0))**p5 + ((1+p1)/(1+0.0))**p6 )
    e_z=(1+z)**p8
    L_z=10**p4*e_z
    result= 10**p7 * rho * (10**L/L_z)**(-p2)*np.exp(-(10**L/L_z)**p3)
    return result

def log10phi(z,k,theta):
    y=np.empty(nbin)
    for i in range(0,nbin):
        y[i]=np.log10(phi(z, k[i], theta) )
    return y

def PPS(k, theta):
    return log10phi(z,k,theta)

k = np.linspace(23.0, 30.0, nbin)
cbar = plot_contours(PPS, k, samples, weights=weights)
cbar = plt.colorbar(cbar,ticks=[0,1,2,3])
cbar.set_ticklabels(['',r'$1\sigma$',r'$2\sigma$',r'$3\sigma$'])
plt.ylabel(r'$\ln\left(10^{10}\mathcal{P}_\mathcal{R}\right)$')
plt.xlabel(r'$k / {\rm Mpc}^{-1}$')
plt.tight_layout()
plt.savefig('planck.png')

Hi @yuanzunli. Could you edit the above post to include a representative picture of the problem? (click the top-right menu to edit, and then drag the image file into the box, or click the bottom bar of the editor).

Hi @williamjameshandley. I have updated the issue.

@yuanzunli In this case one wouldn't expect increasing the number of samples in the x-coordinate to help matters, since the issue resides in the paucity of y-samples. If you increase the number of samples in the y direction to more than 500 do you get better results?
You will likely get better perfomance by replacing the loop over y values in log10phi with a vectorised operation, which as far as I can tell would amount to:
def log10phi(z,k,theta):
    return np.log10(phi(z, k, theta) )

I also modified your original post so that the code formatting is easier to read -- if you surround the code in triple backticks, rather than each line with single backticks then you get a nicer block formatting and syntax highlighting

@williamjameshandley I replaced the loop over y values in log10phi with your suggested operation, but the result seems to be the same as the old one.

Did you increase the number of samples in y? The equivalent code would be
cbar = plot_contours(PPS, k, samples, weights=weights, ny=1000) # Default ny is 100

I increased both the numbers of samples in x and y.
nbin=500
k = np.linspace(23.0, 30.0, nbin)
cbar = plot_contours(PPS, k, samples, weights=weights, ny=500)

Now the result seems to be nice. Thanks very much for your help @williamjameshandley

Many thanks @yuanzunli

I find there are some black lines in the  fgivenx plot, which define the different sigma regions. For my figure, the uncertainty band is narrow, and these black lines may make the figure look crowded. Could I remove these black lines？

If you pass lines=false this kwarg should be forwarded onto fgivenx.plot.plot


DPI support problematic

Just downloaded the github repo, running the test app.
My mouse click are off, I need to click outside button / text to select them!
The problem get worse towards the bottom right of the window!

Thanks for the report @superlloyd - what OS are you using and what is your current DPI scaling?

Actually, when running at 125% here, button clicks are ok, but selecting text is off. I will investigate.

Windows 10.
I set a custom DPI which I can't remember but the display panel seems to say I set it at 225% (which I doubt...) fact is I set a custom scaling one day to be as wysiwyg as possible... it was more like 114% IIRC

Nice you can experience it!
Good luck fixing it! ;)

DropDown now broken on high-dpi.

Still not fixed. ARGH.

Should hopefully be fixed now.

As they say, works on my computer! (now) :)


Bower doesn't mark project private when answered yes in bower init prompt

When bower init promps whether or not to mark a package as private and 'yes' is answered, it is still not marked private.
The printed json is the same as is written to the bower.json file.
$ bower --version
1.3.10
$ bower init
? name: bar
? version: 0.0.0
? description:
? main file:
? what types of modules does this package expose?:
? keywords:
? authors: Remco Haszing<EMAIL_ADDRESS>? license: MIT
? homepage:
? set currently installed components as dependencies?: Yes
? add commonly ignored files to ignore list?: Yes
? would you like to mark this package as private which prevents it from being accidentally published to the registry?: Yes

{
  name: 'bar',
  version: '0.0.0',
  authors: [
    'Remco Haszing<EMAIL_ADDRESS>  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

? Looks good?: (Y/n)

This issue was resolved by commit 3df6144 but then regressed in commit 45bab9f.  The problem is caused by https://github.com/mout/mout/commit/d80a75510db77fa11e0b6cc795a7d1f432892457.

+1, this is not fixed in 1.4.1 because of the regression. Please reopen.

@remcohaszing , @sheerun  I've tested it with latest version available, 1.6.5, and I wasn't able to reproduce it. It seems to be fixed and working as expected. @remcohaszing can you try it with the latest version?
Thanks!

This appears to have been fixed in 304b6393d424b8f886a599a40e8cc0c28fa2d1a8

Thanks @Parakleta ! I will close this issue since it was fixed. If this happens again, feel free to re-open it.


Remove deployment to PyPI

Previously opwen_email_server was pip-installed by the client to access
the registration script. Registration was changed to a service call so
this is no longer required -- as such, we don't have to deploy
opwen_email_server to PyPI anymore.

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   91.25%   91.25%
=======================================
  Files          20       20
  Lines         823      823
=======================================
  Hits          751      751
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc244f...465dfd7. Read the comment docs.


Sidebar responsive mobile

Fixes #548
Changes:
The sidebar/Menubar is made responsive to mobile and tablet views.

thanks this is great! I kept the inline-block layout for space purposes, but added commas to help delineate the items. hope this is ok with you.


Issues with connection to SAP HANA Cloud system

VSCode 1.54.1
SAP Hana Driver for SQLTools 0.2.1
Hana running on SAP HANA Cloud.
Nodejs v14.16.0
Hello,
thanks much for providing this tool.
We managed to connect to a HANA system running in SAP HANA Cloud and see the list of tables and views in SQLTools.
But from there it is not possible to create statements or view the data:

Right click on table name -> Describe table -> works

Right click on table name -> Show table records -> error:
[1615453788873] INFO  (ls): REQUEST RECEIVED => connection/GetChildrenForTreeItemRequest query error:invalid column name: C.CS_DATA_TYPE_NAME: line 1 col 34 (at pos 33) query error:invalid column name: C.CS_DATA_TYPE_NAME: line 1 col 34 (at pos 33) [1615453789392] INFO  (ext): EXECUTING COMMAND => sqltools.getConnections [1615453789394] INFO  (ls): REQUEST RECEIVED => connection/GetConnectionsRequest [1615453789404] INFO  (ls): REQUEST RECEIVED => connection/RunCommandRequest query error:sql syntax error: incorrect syntax near ".": line 2 col 21 (at pos 30) query error:sql syntax error: incorrect syntax near ".": line 2 col 21 (at pos 48) [1615453789457] ERROR (ext): ERROR: Execute query error Cannot read property 'total' of undefined, 'Cannot read property 'total' of undefined'   ns: "error-handler" [1615453789458] ERROR (ext): ERROR: Error while showing table records Cannot read property 'total' of undefined, {"code":-1,"data":{"driver":"SAPHana","driverOptions":{}}}   ns: "error-handler"

Right click on table name -> Generate insert query -> error:
[1615453913671] INFO  (ext): EXECUTING COMMAND => sqltools.generateInsertQuery [1615453913671] INFO  (ext): EXECUTING COMMAND => sqltools.getChildrenForTreeItem [1615453913671] INFO  (ls): REQUEST RECEIVED => connection/GetChildrenForTreeItemRequest query error:invalid column name: C.CS_DATA_TYPE_NAME: line 1 col 34 (at pos 33)

Please note we are running nodejs v14 which was not supported by @sap/hana-client for a long time. This npm module has been updated lately, so this might be a hint for you.
Thanks much, kind regards,
Timo.

Hello Timo,
I have tested the scenarios above and they all worked for me.
Try upgrading your hana-client.
npm view @sap/hana-client returns on my side<EMAIL_ADDRESS>this is the latest from two weeks ago.


Incorrect work of formatting rules with same parameters name

Is it possible to use ParameterListWrapping.indentSize and Indentation.indentSize in same time?
Current behavior is overwrite values, for instance, when Indentation.indentSize = 4 and ParameterListWrapping.indentSize = 8 then Indention overwrites and checks as indentSize = 8

I too have experienced this issue, I was banging my head against the wall trying to figure out why my Indentation.indentSize = 2 was not applied. Turns out that I had used the default for ParameterListWrapping.indentSize which I believe was 4. Changed ParameterListWrapping.indentSize to be 2 as a workaround for now.

ParameterListWrapping.indentSize and Indentation.indentSize

Both ParameterListWrapping and Indentation are wrapping KtLint rules.
Can I ask you to try to replicate the issue on KtLint stand-alone and eventually open an issue on their issue tracker?

Closed due to the issue in ktlint's repo.


please move format to the common ChatOptions.

please move format to the common ChatOptions. it's commonly used enough. maybe we'd have to adapt it to support different Strings for different models

We need to check how 'common' it truly is.

OpenAI uses “response_format” fwiw


feat: add blank lines in blockquote to adhere to MD standard

Type of changes

[x] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[ ] I accept that @willmcgugan may be pedantic in the code review.

Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Closing. Assumed stale. Feel free to reopen if it is still an issue.


Add boltons to conda-recipe

attn @tacaswell the conda recipe does not build for v0.2.0 because boltons was not included in the conda recipe

Once we agree on this conda-recipe, I can put in a PR against conda-prescriptions with the updated recipe

And this apparently needs a rebase

Ok, rebased.  I had added jinja2 to the meta.yaml in the test improvement PR


How to create attributes on element from an array using map()?

Description
I'm unable to create attributes dynamically on an element using a map().
I'm unsure if I'm fundamentally approaching this problem the wrong way with lit-html?
Steps to Reproduce

Write this code

import {html, render} from 'lit-html';
let data = ["sausages","vegetables"]
render(html`<div ${data.map(item => html`data-attr="${item}"`)}>blah blah</div>`, document.body);

See this output...

Live Reproduction Link

https://stackblitz.com/edit/lit-html-s7ajmj
Expected Results

I would expect to see this rendered:
blah blah

Actual Results
In stackblitz this is rendered
blah blah
. In my own environment it breaks with this: "TypeError: Cannot read property '2' of null"

This is not currently supported. See also #923 for a similar request (using spread, not map).

OK, thanks for clarification.

Does setting as property instead of as attribute help here?
import {html, render} from 'lit-html';
let data = ["sausages","vegetables"]
render(html`<div .data=${data}>blah blah</div>`, document.body);


PlugInstall fails

PlugInstall exits with code 127 when installing deoplete-go:
Plug 'zchee/deoplete-go', { 'do': 'make'}

If I run make in ~/.config/nvim/plugged/deoplete-go, make works.
:version
NVIM 0.1.4
Build type: RelWithDebInfo
Compilation: /home/vagrant/.linuxbrew/bin/gcc-5 -Os -w -pipe -march=core2 -Wconversion -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std
=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/bui
ld/config -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/src -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim20160428-48008-153o8w5/neovim-
0.1.4/deps-build/usr/include -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/deps-build/usr/include/luajit-2.0 -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/deps-build/usr/in
clude -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/deps-build/usr/include -I/tmp/neovim20160428-48008-
153o8w5/neovim-0.1.4/deps-build/usr/include -I/home/vagrant/.linuxbrew/include -I/tmp/neovim20160428-48008-153o8w5/neovim-0.1.4/build/src/nvim/auto -I/tmp/neovim20160428-48008-15
3o8w5/neovim-0.1.4/build/include
Compiled by vagrant@centos-7-vagrant

Optional features included (+) or not (-): +acl   +iconv    +jemalloc
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/home/vagrant/.linuxbrew/Cellar/neovim/0.1.4/share/nvim"

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[x] Linux
[ ] OS X
[ ] Windows

Vim:

[ ] Terminal Vim
[ ] GVim
[x] Neovim

Works for me.
- Post-update hook for deoplete-go ... OK

Try this:
:execute printf('!cd %s && make', g:plugs['deoplete-go'].dir)
:echo v:shell_error

What is the value of v:shell_error?

Ahh, I am using fish:
:!cd /home/vagrant/.config/nvim/plugged/deoplete-go/ && make

Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
fish: cd /home/vagrant/.config/nvim/plugged/deoplete-go/ && make
                                                          ^
shell returned 127

Sorry about that.

Any way to use bash?

Ah, okay, thanks for confirmation. I can make vim-plug temporarily change &shell to avoid the error. I'll fix it and let you know.

Great, thanks.

Please :PlugUpgrade and let me know if the issue is resolved.

Work perfectly, thanks!

No problem, thanks for the report.


Unable to train DeepSpeech from scratch on Indian Hinglish(Mixed Hindi_English) 8khz audio data.

Hi,
I want to train Hinglish(Mixed Hindi_English) 8khz conversation audio data  from scratch.
I am getting ValueError: Input signal length=0 is too small to resample from 8000->16000.
Training Command

CUDA_VISIBLE_DEVICES=0,1 python train.py

Trainig Log:
-----------  Configuration Arguments -----------
batch_size: 256
dev_manifest: data/audio_data/manifest.dev-clean
init_from_pretrained_model: None
is_local: True
learning_rate: 0.0005
max_duration: 27.0
mean_std_path: data/audio_data/mean_std.npz
min_duration: 0.0
num_conv_layers: 2
num_epoch: 200
num_iter_print: 100
num_rnn_layers: 3
num_samples: 489948
output_model_dir: checkpoint_dir
rnn_layer_size: 2048
save_epoch: 10
share_rnn_weights: False
shuffle_method: batch_shuffle_clipped
specgram_type: mfcc
test_off: False
train_manifest: data/audio_data/manifest.train-clean
use_gpu: True
use_gru: True
use_sortagrad: True
vocab_path: data/audio_data/eng_vocab.txt
W0702 16:43:10.574574  7779 device_context.cc:252] Please NOTE: device: 0, CUDA Capability: 75, Driver API Version: 10.2, Runtime API Version: 10.0
W0702 16:43:10.577214  7779 device_context.cc:260] device: 0, cuDNN Version: 7.6.
W0702 16:43:14.229719  7779 fuse_all_reduce_op_pass.cc:74] Find all_reduce operators: 38. To make the speed faster, some all_reduce ops are fused during training, after fusion, the number of all_reduce ops is 38.
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/resampy/core.py:90: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
if not np.issubdtype(x.dtype, np.float):
2020-07-02 16:43:19,910-WARNING: Your reader has raised an exception!
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/threading.py", line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 1157, in thread_main
six.reraise(*sys.exc_info())
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 1137, in thread_main
for tensors in self._tensor_reader():
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/data.py", line 200, in batch_reader
for instance in instance_reader():
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/data.py", line 279, in reader
instance["text"]),
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/data.py", line 121, in process_utterance
speech_segment, self._keep_transcription_text)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/featurizer/speech_featurizer.py", line 76, in featurize
audio_feature = self._audio_featurizer.featurize(speech_segment)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/featurizer/audio_featurizer.py", line 80, in featurize
audio_segment.resample(self._target_sample_rate)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/data_utils/audio.py", line 400, in resample
self.samples, self.sample_rate, target_sample_rate, filter=filter)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/resampy/core.py", line 102, in resample
'resample from {}->{}'.format(x.shape[axis], sr_orig, sr_new))
ValueError: Input signal length=0 is too small to resample from 8000->16000
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py:1070: UserWarning:
"The following exception is not an EOF exception.")
Traceback (most recent call last):
File "train.py", line 144, in
main()
File "train.py", line 140, in main
train()
File "train.py", line 135, in train
test_off=args.test_off)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 336, in train
return_numpy=False)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1071, in run
six.reraise(*sys.exc_info())
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1066, in run
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1167, in _run_impl
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 879, in _run_parallel
tensors = exe.run(fetch_var_names, return_merged)._move_to_list()
paddle.fluid.core_avx.EnforceNotMet:

C++ Call Stacks (More useful to developers):
0   std::string paddle::platform::GetTraceBackString<std::string const&>(std::string const&, char const*, int)
1   paddle::platform::EnforceNotMet::EnforceNotMet(std::string const&, char const*, int)
2   paddle::operators::reader::BlockingQueue<std::vector<paddle::framework::LoDTensor, std::allocatorpaddle::framework::LoDTensor > >::Receive(std::vector<paddle::framework::LoDTensor, std::allocatorpaddle::framework::LoDTensor >)
3   paddle::operators::reader::PyReader::ReadNext(std::vector<paddle::framework::LoDTensor, std::allocatorpaddle::framework::LoDTensor >)
4   std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result, std::__future_base::_Result_base::_Deleter>, unsigned long> >::_M_invoke(std::_Any_data const&)
5   std::__future_base::_State_base::_M_do_set(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>&, bool&)
6   ThreadPool::ThreadPool(unsigned long)::{lambda()#1}::operator()() const

Python Call Stacks (More useful to users):
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 2610, in append_op
attrs=kwargs.get("attrs", None))
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 1079, in _init_non_iterable
attrs={'drop_last': self._drop_last})
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 977, in init
self._init_non_iterable()
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 608, in from_generator
iterable, return_list, drop_last)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 112, in create_network
use_double_buffer=True)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 281, in train
train_reader, log_probs, ctc_loss = self.create_network()
File "train.py", line 135, in train
test_off=args.test_off)
File "train.py", line 140, in main
train()
File "train.py", line 144, in
main()

Error Message Summary:
Error: Blocking queue is killed because the data reader raises an exception
[Hint: Expected killed_ != true, but received killed_:1 == true:1.] at (/paddle/paddle/fluid/operators/reader/blocking_queue.h:141)
[operator < read > error]
Anyone can help me to resolve this issue.
Can I run 8khz audio on training from scratch?
I am able to infer an audio(8k sample_rate) using baidu_en8k model.
Thanks
Nasim

It seems like your input data shape = 0, please check it.

Thanks for the prompt reply.
Yes, I got it.
I will check.

I resolved that error.
Now I am getting this error I tried a lot but unable to resolve this.
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/resampy/core.py:90: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
if not np.issubdtype(x.dtype, np.float):
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py:1070: UserWarning: The following exception is not an EOF exception.
"The following exception is not an EOF exception.")
Traceback (most recent call last):
File "train.py", line 144, in
main()
File "train.py", line 140, in main
train()
File "train.py", line 135, in train
test_off=args.test_off)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 336, in train
return_numpy=False)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1071, in run
six.reraise(*sys.exc_info())
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1066, in run
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1167, in _run_impl
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 879, in _run_parallel
tensors = exe.run(fetch_var_names, return_merged)._move_to_list()
paddle.fluid.core_avx.EnforceNotMet:
Can you please help me to resolve this.
Thanks.

The whole error log is:
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/resampy/core.py:90: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
if not np.issubdtype(x.dtype, np.float):
/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py:1070: UserWarning: The following exception is not an EOF exception.
"The following exception is not an EOF exception.")
Traceback (most recent call last):
File "train.py", line 146, in
main()
File "train.py", line 142, in main
train()
File "train.py", line 137, in train
test_off=args.test_off)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 336, in train
return_numpy=False)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1071, in run
six.reraise(*sys.exc_info())
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1066, in run
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 1167, in _run_impl
return_merged=return_merged)
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/executor.py", line 879, in _run_parallel
tensors = exe.run(fetch_var_names, return_merged)._move_to_list()
paddle.fluid.core_avx.EnforceNotMet:

C++ Call Stacks (More useful to developers):
0   std::string paddle::platform::GetTraceBackString<std::string const&>(std::string const&, char const*, int)
1   paddle::platform::EnforceNotMet::EnforceNotMet(std::string const&, char const*, int)
2   paddle::operators::ReadOp::RunImpl(paddle::framework::Scope const&, paddle::platform::Place const&) const
3   paddle::framework::OperatorBase::Run(paddle::framework::Scope const&, paddle::platform::Place const&)
4   paddle::framework::details::ComputationOpHandle::RunImpl()
5   paddle::framework::details::FastThreadedSSAGraphExecutor::RunOpSync(paddle::framework::details::OpHandleBase*)
6   paddle::framework::details::FastThreadedSSAGraphExecutor::RunOp(paddle::framework::details::OpHandleBase*, std::shared_ptr<paddle::framework::BlockingQueue > const&, unsigned long*)
7   std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result, std::__future_base::_Result_base::_Deleter>, void> >::_M_invoke(std::_Any_data const&)
8   std::__future_base::_State_base::_M_do_set(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>&, bool&)
9   ThreadPool::ThreadPool(unsigned long)::{lambda()#1}::operator()() const

Python Call Stacks (More useful to users):
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/framework.py", line 2610, in append_op
attrs=kwargs.get("attrs", None))
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 1079, in _init_non_iterable
attrs={'drop_last': self._drop_last})
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 977, in init
self._init_non_iterable()
File "/home/ubuntu/tmp/deepspeech2-venv/local/lib/python2.7/site-packages/paddle/fluid/reader.py", line 608, in from_generator
iterable, return_list, drop_last)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 112, in create_network
use_double_buffer=True)
File "/home/ubuntu/drive_a/Paddlepaddle_DeepSpeech/DeepSpeech/model_utils/model.py", line 281, in train
train_reader, log_probs, ctc_loss = self.create_network()
File "train.py", line 137, in train
test_off=args.test_off)
File "train.py", line 142, in main
train()
File "train.py", line 146, in
main()

Error Message Summary:
InvalidArgumentError: The fed Variable audio_data should have dimensions = 3, shape = [-1, 161, -1], but received fed shape [1, 39, 208]
[Hint: Expected DimensionIsCompatibleWith(shapes[i], in_dims) == true, but received DimensionIsCompatibleWith(shapes[i], in_dims):0 != true:1.] at (/paddle/paddle/fluid/operators/reader/read_op.cc:137)
[operator < read > error]
Here I got some dimension error, while I am able to find inference on these audio data.
So if the dimension is not correct then how do I able to infer these files.

issue resolved thanks a lot.

Hi @alamnasim
I have a same error when train with mfcc.
How do you resolve it?
Thank you


[SPARK-33354][SQL] New explicit cast syntax rules in ANSI mode

What changes were proposed in this pull request?

In section 6.13 of the ANSI SQL standard, there are syntax rules for valid combinations of the source and target data types.

Comparing the ANSI CAST syntax rules with the current default behavior of Spark:

To make Spark's ANSI mode more ANSI SQL Compatible，I propose to disallow the following casting in ANSI mode:
TimeStamp <=> Boolean
Date <=> Boolean
Numeric <=> Timestamp
Numeric <=> Date
Numeric <=> Binary
String <=> Array
String <=> Map
String <=> Struct

The following castings are considered invalid in ANSI SQL standard, but they are quite straight forward. Let's Allow them for now
Numeric <=> Boolean
String <=> Binary

Why are the changes needed?

Better ANSI SQL compliance
Does this PR introduce any user-facing change?

Yes, the following castings will not be allowed in ANSI mode:
TimeStamp <=> Boolean
Date <=> Boolean
Numeric <=> Timestamp
Numeric <=> Date
Numeric <=> Binary
String <=> Array
String <=> Map
String <=> Struct

How was this patch tested?

Unit test
The ANSI Compliance doc preview:

Test build #130642 has started for PR 30260 at commit fe0fe48.

I am still adding more test case, mark it as WIP for now

Test build #130642 has finished for PR 30260 at commit fe0fe48.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130642/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35252/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35252/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35252/
Test PASSed.

Test build #130650 has started for PR 30260 at commit d514f86.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35261/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35261/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35261/
Test PASSed.

Test build #130650 has finished for PR 30260 at commit d514f86.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130650/
Test PASSed.

Thanks for the request, @gengliangwang ! I'll review this later.

Test build #130796 has started for PR 30260 at commit 18b49bf.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35405/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35405/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35405/
Test FAILed.

Test build #130796 has finished for PR 30260 at commit 18b49bf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130796/
Test PASSed.

Test build #130937 has started for PR 30260 at commit e6faf4b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35543/

Test build #130941 has started for PR 30260 at commit 33452cd.

@maropu thanks for the suggestions. I have updated the code. Please take another look.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35543/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35543/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35546/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35546/
Test PASSed.

Test build #130937 has finished for PR 30260 at commit e6faf4b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130937/
Test PASSed.

Test build #130941 has finished for PR 30260 at commit 33452cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130941/
Test PASSed.

@maropu Thanks again for the thoughtful suggestions! I have updated the code.

Test build #131003 has started for PR 30260 at commit ce0e775.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35609/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35609/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35609/
Test PASSed.

Test build #131003 has finished for PR 30260 at commit ce0e775.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131003/
Test PASSed.

kindly ping @cloud-fan

Test build #131250 has started for PR 30260 at commit 1d57a24.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35853/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35853/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35853/
Test PASSed.

Test build #131250 has finished for PR 30260 at commit 1d57a24.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class AnsiCastSuiteBase extends CastSuiteBase
class CastSuiteWithAnsiModeOn extends AnsiCastSuiteBase
class AnsiCastSuiteWithAnsiModeOn extends CastSuiteBase
class AnsiCastSuiteWithAnsiModeOff extends CastSuiteBase

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131250/
Test FAILed.

Test build #131283 has started for PR 30260 at commit 6003bef.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35888/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35888/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35888/
Test FAILed.

Test build #131283 has finished for PR 30260 at commit 6003bef.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class AnsiCastSuiteWithAnsiModeOn extends AnsiCastSuiteBase
class AnsiCastSuiteWithAnsiModeOff extends AnsiCastSuiteBase

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131283/
Test FAILed.

retest this please.

Test build #131300 has started for PR 30260 at commit 6003bef.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35902/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35902/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35902/
Test PASSed.

Test build #131300 has finished for PR 30260 at commit 6003bef.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class AnsiCastSuiteWithAnsiModeOn extends AnsiCastSuiteBase
class AnsiCastSuiteWithAnsiModeOff extends AnsiCastSuiteBase

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131300/
Test PASSed.

Thanks! Merged to master.

Thank you, @gengliangwang and all!

I just noticed that the error messages when trying to cast between timestamps and numeric types is wrong now in ANSI mode.
org.apache.spark.sql.AnalysisException: cannot resolve 'CAST(`c0` AS TIMESTAMP)' due to data type mismatch: cannot cast int to timestamp,you can enable the casting by setting spark.sql.legacy.allowCastNumericToTimestamp to true,but we strongly recommend using function TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.;;

spark.sql.legacy.allowCastNumericToTimestamp has no impact on ANSI casts after this change.  It looks like a fairly simple fix.
https://github.com/apache/spark/blob/3695e997d5d436be086235505bbb030c87ae8eef/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala#L276

@revans2 Thanks for reporting the problem. Actually, I am working on another PR to give suggestions for the disallowed ANSI cast. It will be sent out today and I will ping you in the PR.

@gengliangwang sounds good.  Thanks


Update to PostCSS 6

I would like to use postcss-nested, but it uses sixth version of postcss. Can you please update it?

@queses I've updated postcss version, please check it in the 0.1.0 release

Thank's for fast reaction and great library!


Wrong command

Example 1: Disable automatic claim for iSCSI
PS C:> Disable-MSDSMAutomaticClaimSettings -BusType "iSCSI"
should be Disable-MSDSMAutomaticClaim -BusType "iSCSI"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4cd658bd-0287-9aac-1095-7be8810ddf99
Version Independent ID: 50ba1ad1-de2b-bb8d-06b3-593ae438d347
Content: Disable-MSDSMAutomaticClaim (mpio)
Content Source: docset/windows/mpio/disable-msdsmautomaticclaim.md
Product: w10
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@grimson73  Thank you for the feedback. We have made the necessary changes to the cmdlet in the example on PR# https://github.com/MicrosoftDocs/windows-powershell-docs/pull/733 .

@coreyp-at-msft There is a proposed Pull Request regarding the issue. Please review. Thanks. #733

@kenwith There is a proposed Pull Request regarding the issue. Please review. Thanks. #733

@officedocsbot close


Missing features

Semigroup instance
union, difference, concat, intersect
group
zip? unzip?

Added Semigroup and Union as of v0.1.4.


Respect unavailable annotations when computing availability for linkage

Unavailable cases should be weakly linked against.
rdar://72151067

I am not sure that weakly linking is the right solution.
The problem is that the Payload (see test case) enum's reflection metadata references the payload's Float16 metadata. Float16 on macOS is marked as @available(macOS, unavailable).

Slava convinced me that this is not the right fix.


[ALLUXIO-2965] test fix: use AuthenticatedUserRule to simplify tests

https://alluxio.atlassian.net/browse/ALLUXIO-2965

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16146/
Test PASSed.

Merged build finished. Test PASSed.


Retrieve the thumbnail for playlists (in the same way it is already available for channels)

The thumbnails are very useful for a visual and intuitive way to identify the channel or playlist.
I was exploring how Youtube set the playlist thumbnail. Seems there are two ways:
Playlist thumbnail is the same as the thumbnail of the first video (in the playlist):
https://www.youtube.com/playlist?list=PLY-s_C0dtivEJwZbzYDXhP5-2zvUHOXbR

Playlist thumbnail is the same as the channel thumbnail:
https://www.youtube.com/playlist?list=PLB-0kvY-EINsgp4j8rU4vtbjXDgQl6uP2

For channels, Pytubefix already provides a way to retrieve the channel thumbnail using the:
from pytubefix import Channel

channel_url = 'https://www.youtube.com/channel/UCzQUP1qoWDoEbmsQxvdjxgQ'
c = Channel(channel_url)
print(c.thumbnail_url)

I would like to suggest to add to Pytubefix the possibility to retrieve the url for the playlist thumbnail.

Feature added by @felipeucelli


AWS S3 Region Security Error

When trying to authenticate with AWS S3 for Avatar and Uploads in the US East 2 Region (Ohio) we get the following security error:
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/core/handlers/base.py", line 185, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
return view_func(*args, **kwargs)
File "./zerver/lib/rest.py", line 131, in rest_dispatch
return target_function(request, **kwargs)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/utils/decorators.py", line 149, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "./zerver/decorator.py", line 605, in _wrapped_view_func
return authenticate_log_and_execute_json(request, view_func, *args, **kwargs)
File "./zerver/decorator.py", line 587, in authenticate_log_and_execute_json
return rate_limit()(view_func)(request, user_profile, *args, **kwargs)
File "./zerver/decorator.py", line 747, in wrapped_func
return func(request, *args, **kwargs)
File "./zerver/views/upload.py", line 104, in upload_file_backend
uri = upload_message_image_from_request(request, user_file, user_profile)
File "./zerver/lib/upload.py", line 559, in upload_message_image_from_request
content_type, user_file.read(), user_profile)
File "./zerver/lib/upload.py", line 538, in upload_message_file
target_realm=target_realm)
File "./zerver/lib/upload.py", line 257, in upload_message_file
file_data
File "./zerver/lib/upload.py", line 187, in upload_image_to_s3
key.set_contents_from_string(contents, headers=headers)  # type: ignore # https://github.com/python/typeshed/issues/1552
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 1438, in set_contents_from_string
encrypt_key=encrypt_key)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 1305, in set_contents_from_file
chunked_transfer=chunked_transfer, size=size)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 762, in send_file
chunked_transfer=chunked_transfer, size=size)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 963, in _send_file_internal
query_args=query_args
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/connection.py", line 671, in make_request
retry_handler=retry_handler
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/connection.py", line 1071, in make_request
retry_handler=retry_handler)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/connection.py", line 940, in _mexe
request.body, request.headers)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 896, in sender
response.status, response.reason, body)
boto.exception.S3ResponseError: S3ResponseError: 400 Bad Request

InvalidRequestThe authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.D37F11433B97B292WZ5mYxq96JZWblntymvMzXC3+4zJ0qpw/+VRaXiKoAReaa7l2FGmmBVEvwmK9UVwUtWhOhH14X4=

looks like you need to explicitly configure v4 signatures, you can do it in your ~/.aws/config

This is what i get now...
2018-05-14 17:14:25.133 ERR [] Traceback (most recent call last):
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/core/handlers/base.py", line 185, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
return view_func(*args, **kwargs)
File "./zerver/lib/rest.py", line 131, in rest_dispatch
return target_function(request, **kwargs)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/django/utils/decorators.py", line 149, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "./zerver/decorator.py", line 605, in _wrapped_view_func
return authenticate_log_and_execute_json(request, view_func, *args, **kwargs)
File "./zerver/decorator.py", line 587, in authenticate_log_and_execute_json
return rate_limit()(view_func)(request, user_profile, *args, **kwargs)
File "./zerver/decorator.py", line 747, in wrapped_func
return func(request, *args, **kwargs)
File "./zerver/views/upload.py", line 104, in upload_file_backend
uri = upload_message_image_from_request(request, user_file, user_profile)
File "./zerver/lib/upload.py", line 559, in upload_message_image_from_request
content_type, user_file.read(), user_profile)
File "./zerver/lib/upload.py", line 538, in upload_message_file
target_realm=target_realm)
File "./zerver/lib/upload.py", line 257, in upload_message_file
file_data
File "./zerver/lib/upload.py", line 187, in upload_image_to_s3
key.set_contents_from_string(contents, headers=headers) # type: ignore # https://github.com/python/typeshed/issues/1552
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 1438, in set_contents_from_string
encrypt_key=encrypt_key)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 1305, in set_contents_from_file
chunked_transfer=chunked_transfer, size=size)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 762, in send_file
chunked_transfer=chunked_transfer, size=size)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 963, in _send_file_internal
query_args=query_args
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/connection.py", line 671, in make_request
retry_handler=retry_handler
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/connection.py", line 1071, in make_request
retry_handler=retry_handler)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/connection.py", line 1030, in _mexe
raise ex
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/connection.py", line 940, in _mexe
request.body, request.headers)
File "/home/zulip/deployments/2018-05-11-16-38-38/zulip-py3-venv/lib/python3.5/site-packages/boto/s3/key.py", line 856, in sender
http_conn.send(chunk)
File "/usr/lib/python3.5/http/client.py", line 908, in send
self.sock.sendall(data)
File "/usr/lib/python3.5/ssl.py", line 891, in sendall
v = self.send(data[count:])
File "/usr/lib/python3.5/ssl.py", line 861, in send
return self._sslobj.write(data)
File "/usr/lib/python3.5/ssl.py", line 586, in write
return self._sslobj.write(data)
ConnectionResetError: [Errno 104] Connection reset by peer

actually we are getting the same error again.

We have done everything we can find to change sig version to V4 but to no avail we still have this issue. Any advice?

aws sdk/boto3 allows configuring this via a few different mechanisms, and it should be autodetecting and enabling it by region by default.
via code, It can be explicitly enabled by doing something like this, fwiw. I've only needed to do this when I'm using kms encryption for s3 which requires v4 signature regardless of region.
import boto3
from botocore.client import Config

session = boto3.Session()
config = Config(signature_version='s3v4')
s3 = session.client('s3', config=config, region_name='eu-west-3')

and it can be explicitly enabled outside of code by a deployment change by configuring the default signature method (this only affects python sdk afaics).
$ aws configure set default.s3.signature_version s3v4
$ cat ~/.aws/config
[default]
s3 =
    signature_version = s3v4

running import boto3 doesn't work for me. How do i get to:
import boto3
from botocore.client import Config
session = boto3.Session()
config = Config(signature_version='s3v4')
s3 = session.client('s3', config=config, region_name='eu-west-3')
The second option isn't working for us..

It appears Zulip is using Boto 2.4 and no matter what we do it's changing auth back to unsupported version.

I was running into the same issue for us-east-2, I switched to us-west-2 and it's working for me now. It seems some regions are forcing SIGv4 and some aren't.

I ran into this issue as well today with {{eu-central-1}} :-(

@kapilt I'd also be interested in details; we should just fix this in the Zulip 1.9.1 point release.

@pigulla and you remembered to restart the Zulip server?  That step is important for the changes to take effect.

@timabbott Yes, I did.

@timabbott Is there anything else I can do to help resolve this issue? This is the last thing that keeps us from rolling Zulip out to production :(

Hacking boto2 code (bundled in Zulip) reveals, using sigv4 requires a host parameter should be set. Digging...

Just had a look at my zproject/settings.py
# By using our own path for BOTO_CONFIG, we can cause boto to not
# process /etc/boto.cfg.
os.environ['BOTO_CONFIG'] = '/etc/zulip/boto.cfg'

Makes me wonder why  adding /etc/boto.cfg worked for me.

@pigulla regarding this:

@timabbott You might want to add to the docs that public access to the avatar bucket will not work as expected if the bucket was created with a different user (i.e., not the IAM account Zulip uses).

Hmm, I think it should be fine if you use the bucket policy we suggest in the docs; did you do so?

No, I do not have a /etc/zulip/boto.cfg

@timabbott Yes I did, and the bucket is shown as public. I've done some digging and found a blogpost or StackOverflow answer (didn't bookmark it, sorry :-/) stating that - if I remember correctly - the bucket policy only applies to objects created by the owner of the bucket.
So if I create the bucket with my IAM user, objects uploaded by Zulip (which uses a different IAM user) will not be publicly accessible. If the policy worked as one would intuitively assume, recreating the bucket as a different user but with the exact same permissions shouldn't have changed anything.
Now having said that, I'm not an S3 expert so maybe someone more knowledgable can chime in and confirm?

Hmm.  Well, maybe they've changed something, but the configuration you describe is exactly how zulipchat.com is setup (with the buckets created by a different account than the Zulip IAM user), so I'd be surprised if this doesn't work.

@timabbott I try to use docker development at local,I want to make s3 worked,but the dockerfile-dev seems not generate /etc/zulip folder, where can I set the boto config?

Just use Vagrant for local development, or contribute patches to Dockerfile-dev to support what you need; nobody in the core community uses the Dockerfile-dev setup.

I believe this was resolved by the migration to boto3.

I added file boto.cfg to /etc/zulip/, but the upload doesn't work error message The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256. Can you help pls?
[s3] use-sigv4 = True host = s3.eu-central-1.amazonaws.com


adds homersp to list of contributors in readme

@HomerSp is it ok to add you to the list of contributors?

Of course! :)