Ubiquiti AP Logs coming through with ':' after ever two characters.

Events for Ubiquiti AP's are coming through with a colon after every two characters.

Can you post an "on the wire" (including the leading  string) for one of these events?  This is best obtained with tcpdump.  Thanks!

No problem, To be specific this is an issue with the AP logs.  Below is a screenshot of how the event looks in in Splunk, how it looks in ASCII and the onthe wire log.

UnifiAP.MyBeda.com.45457 > sc4s.mybeda.com.syslog: SYSLOG, length: 273
Facility user (1), Severity info (6)
Msg: Feb 13 19:19:26 U7PG2,788a205c68ab,v<IP_ADDRESS>61: : stahtd[1989]: [STA-TRACKER].stahtd_dump_event(): {"message_type":"STA_ASSOC_TRACKER","vap":"ath2","mac":"ac:63:be:10:37:7a","event_type":"fixup","assoc_status":"0","auth_ts":"0.0","event_id":"1","dns_resp_seen":"yes"}
<14>Feb.13.19:19:26.U7PG2,788a205c68ab,v<IP_ADDRESS>61:.:.stahtd[1989]:.[STA-TRACKER].stahtd_dump_event():.{"message_type":"STA_ASSOC_TRACKER","vap":"ath2","mac":"ac:63:be:10:37:7a","event_type":"fixup","assoc_status":"0","auth_ts":"0.0","event_id":"1","dns_resp_seen":"yes"}

This message parse just fine for me:

Hmm, interesting so I disabled my TA-Ubiquiti which fixed the issue, enabled and it started happening again.  So it appears SC4S is not compatible with this TA which is required for CIM compliance.  I'm guessing this is because I'm using an all-in-one instance and the TA is applying index time extracts to the events and if this was a distributed environment it would not be an issue however nonetheless this is still a bug.
Note, there is an error in the docs at the very bottom the search provided for "validation" is for a different source type.
https://splunk-connect-for-syslog.readthedocs.io/en/master/sources/Ubiquiti/

Is it this TA?
https://splunkbase.splunk.com/app/4107/
If so, I know the author personally and we can get it sorted :-)  In general, we attempt to deliver to the TA a message that is compatible.  In this case, the parsed message in Splunk without the TA looks legitimate, so we'll need to take a look at what the TA is doing to munge that event.

Cool! Upon investigation it is just a coincidence on how SC4S delivers the message and this SED line SEDCMD-ap_mac = s/(\w{2})(?=\w+)/\1:/g in the TA's default props.conf for wireless.  I think altering the regex for compatibility with what is delivered from SC4S fixes the issue.  Guess there is just a slight difference between how the message looks in a traditional syslog monitor file and what SC4S sends to HEC.
FYI, your expert 4 part blog is what finally got me to dive deeper into sc4s.

Awesome, glad it was helpful!  So -- the TA you altered -- is it the one I referenced above?

Yes, it is the TA referenced above and below.  Thanks for the help in figuring this all out.
https://splunkbase.splunk.com/app/4107/

Working with TA author to ensure compliance with SC4S.


[Bug]In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed

Description
[What happened]
In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed
Steps to reproduce the behaviour:

Go to the application
Drag and drop the radio button widget
in the property pane
Under Option Section
Keep the label and value empty
verify the display

Expected Result:
When the user kept the label and value section blank the error message should be displayed
Actual Result: Now when the label and value placeholder is kept blank the placeholder is displayed with red outline even it display red outline  when the user is editing which wont make any difference

Important Details

Version: Cloud
OS: Windows
Browser chrome

@Nikhil-Nandagopal If no one is working on this, can you assign it for me?

@Devedunkey go for it! It's all yours. @somangshu will help you contribute 🙂

👋 @Devedunkey, Thanks for showing interest. I see you have contributed to the Appsmith repository before. In that case, I believe you already have the apt Knowledge to proceed with this.
Anyways here are some brief steps.

Appsmith client-side local setup: https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md
Our development workflow: fix/features (deployable features) -> release (staging environments) -> master (production environment)
All active contribution should be made on the release branch, hence kindly create your sub-version branch from release.
In case you have any challenges, drop a comment here or get in touch with us on our discord server.

Looking forward to having another contribution from you 😊 🚀

@momcilo-appsmith We need to update the designs for this control. If we have that, this can be easy to fix.

@somangshu Here is the updated design for this issue.
LINK

@momcilo-appsmith @vasanth-appsmith there are more challenges with this control, Ex right now the name and label are visible, So somebody who open this property pane for a new widget for the fist time, They would not know what is for what.
Another problem is technical, i.e. the interoperability between the JS mode and the UI mode is not consistent and results in data loss, For now we are planning to get rid of this control everywhere.
cc @riodeuno

Reach: 20
Impact: Low


Added unittest

Jenkins, test this please

If you want to run your build and unit tests on Jenkins, there's some setup that needs to be done there. Let me know if you want to go down that route.

@hannes-ucsc Yes that'll need to be setup. Could you point me to any documentation or resources that are needed to set this up?

No docs on this exist, sorry. But it is simple:
In the root of your repo, create a shell/python script called jenkins.sh or jenkins.py that performs the steps you want executed on continuous integration. It is important that the script fails with a non-zero exit code if the tests or any other build step fails.
The script will be sourced, so it should not have a shebang at the beginning.
You may also need a setup.py. This is standard for Python packages, and well documented.
https://setuptools.readthedocs.io/en/latest/
WRT native dependencies, I'm assuming you only need Python 2.7.x and Docker. If you need Toil outside of a container, jenkins.sh should install the required version of Toil in a virtualenv and then invoke python setup.py develop for your
Look at the toil-rnaseq, toil-scripts or toil-lib projects for inspiration. You might want to track this as an issue that you can assign to me once you have all the build infrastructure files in place.
A Makefile is recommended but not required.

@hannes-ucsc When I created this repo, I did follow the development pattern of those other projects and included a Makefile, jenkins.sh and setup.py. I'll look more carefully at how it's all setup just to be sure. And I'll add an issue to the repo.
Is there anything else that's required for Jenkins? When I commented 'Jenkins, test this please' it did not trigger Jenkins to run the tests.

I set up the build plan on Jenkins. PR builder is also set-up.
http://jenkins.cgcloud.info/job/toil-vg/
First build was failing due to a dependency problem.
http://jenkins.cgcloud.info/job/toil-vg/1/console
You may need to refer to a specific build of toil-lib:
https://pypi.python.org/pypi/toil-lib
i.e. add the .devXX signifier. If you depend on your custom branch of toil-lib, that gets a bit more complicated can also be accommodated, temporarily.


[feat] Sort SQL result tuples for fair comparison during evaluation #159

Description
This feature was created to provide a better comparison when evaluating the Bird dataset. With the use of generative models for SQL generation, the SQL clauses in the SELECT statement are not always in the same order (see issue #159)
Example
Ground Truth: SELECT price, user FROM

Prediction: SELECT user, price FROM

In the evaluation of the Bird dataset, this case is not taken into account. This improvement integrates a sorting mechanism for the tuples resulting from the SQL query execution to ensure consistent evaluation.
Changes:

Added sorting of tuples in the SQL query results for accurate comparison.
Updated evaluation logic to handle the sorted clauses.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lucaordronneau seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't read .env file after launching chatgpt-telegram

Can't read .env file after launching chatgpt-telegram
it shows this mistakу even though file is created and filled out with credentials

Also seeing this on Mac w/ latest OS.

Tried with both amd and arm exectuables.
I was able to get it working by installing GoLang, restarting my terminals, downloading the source code, and running go run main.go from the repo root.

Tried with both amd and arm executables.
I was able to get it working by installing GoLang, restarting my terminals, downloading the source code, and running go run main.go from the repo root.

Thank you, this resolved the whole issue!

PR submitted.

I was able to get it working by installing GoLang, restarting my terminals, downloading the source code, and running go run main.go from the repo root.

I am on an Intel Mac and got the same .env error. Upon installing goLang, how do I fix the following:
stat main.go: no such file or directory


saveDistaceCycling

Hi there,
i´m new with this topic..
is it possible to add a "saveDistaceCycling"-methods to the RCTAppleHealthKit+Methods_Fitness.m (*.h) script?
what do I have to consider?
thanks
Linus

i need too,
how solve this topic. oh my very2 confusing


FPS suddenly dropped everywhere

Logged in today and FPS when using 117 wont go above 20. Usually I get 200 with max settings (RTX4050 graphics card).
Graphics card is showing 100% utilization with runelite. Everything is fine with 117 toggled off, game runs smooth.
Yesterday, everything was fine. 117 was perfect as usual.
did an uninstall and reinstall of runelite, same results, no improvement.
Windows 11 home x64
64 bit runelite <IP_ADDRESS> (latest version)
jagex launcher 1.2.0

Hello! could you kindly post your log?
Also, if you could reach out on Discord it would allow everyone to provide you with faster support; if you do not have Discord feel free to continue here!
If you do; ping me when you post in Windows Support with your log and i will take a look :)

this has also happened to me after taking off the HD version to go back to vanilla client my frames dropped to 18 how do i fix? i tried uninstalling nothing fixes


[state-of-the-world reconciler] RateLimitPolicy discoverability

Move the business logic of reconciling RateLimitPolicyAffected status conditions to a workflow state-of-the-world reconcile func.

This is not addressed by #893. I've removed the link.


Inject pod namespace in tree

This should help finding data.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/lgtm

Seems to work perfectly:
https://logserver.rdoproject.org/44/344/845a64015c867dd151d10752b0f53bbf8645651b/github-check/cifmw-end-to-end-nobuild-tagged/ac36a8d/ci-framework-data/logs/edpm/pods/

/approve


Progress events

Hey.
I do heavy operation in worker method and want to notify caller about calculating progress. By using clean WebWorkers I can send postMessages with progress object.
Is there any way to send progress events from worker using Parallel?

@Sebmaster: there are pull requests https://github.com/adambom/parallel.js/pull/96 and https://github.com/adambom/parallel.js/pull/86 open about this.

Any news on this? Is this repo still maintained?

@amergin
This repo has just got some new blood and the PRs are starting to flow again


Better Fraction Support

[x] Handle Spaces
[x] Vulgar Fractions (Single Code Point)
[ ] Subscript, Superscripts, and Unicode Fractions Slash
[ ] Handle words

Should I replace the fancy unicode characters with the normals before parsing or should I handle them during parsing?

good question. i'd support your choice. they're already tagged as Value in the pos-tagger now right?
it would make sense to me that they be passed-around as unicode, and only become an integer after value.parse() runs
¯_(ツ)_/¯

They are not tagged as Value

Put them in data/number.js right?

yeah, then in ./src/lexicon.js
thanks.

How can I ensure that when parsing "1½" that "1" and "½" are parsed separately (in the to_number method)?

yeah, if tagger.js identifies them both as Value, they'll be lumped together by lumper.js.
so that to_number method will need to split them back apart, which i think you're already doing, if i'm correct.
... i guess if a fraction appears before a number, it's ½ * num, but if it appears after, it's num + ½?
i think the decimal logic in to_number is similar - eg '"two point eight nine". Dunno. it may be sensible to split-out fraction_parse, decimal_parse, etc` in to_number, to make your life more pleasant. Up to you. :bow:

"-1½" is parsing. For some reason "- 1" fails.

"- 1" working

"- 1 ½ 1/2" is -2. Should it be different?

For superscripts should 3³ be 33 or 9 or nothing?

hey @2426021684 is this ready to pull in?

Sorry I forgot about this. I still have to figure out how to get fractions recognized as values.


Add empty param name support

Test code:
import asyncio

from taskiq import InMemoryBroker

from taskiq_pipelines import EMPTY_PARAM_NAME, Pipeline, PipelineMiddleware

broker = InMemoryBroker()
broker.add_middlewares(PipelineMiddleware())

@broker.task
async def add_one(value: int) -> int:
    return value + 1

@broker.task
async def do_nothing() -> None:
    print("I'm doing nothing.")

async def main() -> None:
    # Never forget to call startup in the beginning.
    await broker.startup()

    pipe = (
        Pipeline(broker, add_one).call_next(do_nothing, param_name=EMPTY_PARAM_NAME)
    )
    task = await pipe.kiq(2)

    await asyncio.sleep(2)

if __name__ == "__main__":
    asyncio.run(main())

@cofob, thanks you very much for contribution.
I have an Idea. I guess, it would be really nice to create a separate function that sets this parameter to EMPTY_PARAM_NAME and do not expose the constant to users. You may call it call_after and just remove param_name argument.
As I see it, it would be easier since you would not need to import anything and it would be easier to maintain backward compatibility.

@s3rius added call_after. Please review.


Rewrite supported ndarray.function_name

This PR adds a new typed pass to rewrite ndarray.function_name (e.g. a.sum()) to numba_dppy.dpnp.function_name(ndarray) (e.g. numba_dppy.dpnp.sum(a)).
We need a typed pass to make sure the array is in fact an ndarray.
Test for the pass and ndarray.sum() is added.
The rewrite pass was mostly borrowed from canonicalize_array_math() defined in numba/core/ir_utils.py from Numba.

@reazulhoque Please, analyze tests fails on CI.

Tested with the following dependencies locally:

dpctl: d157ee0b1a9ba88d0f3b226bd069af2dd9a56b9a
Numba (patched): 864790061aa7548ac2b7ebcf448354def849e657
dpnp: 0.4.0

Result:
----------------------------------------------------------------------
Ran 148 tests in 101.530s
OK (skipped=2, expected failures=1)


This error everytime i request a track to the bot

ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/youtube.py", line 1005, in _decrypt_signature
video_id, player_url, s
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/youtube.py", line 919, in _extract_signature_function
errnote='Download of %s failed' % player_url)
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/common.py", line 518, in _download_webpage
res = self._download_webpage_handle(url_or_request, video_id, note, errnote, fatal, encoding=encoding, data=data, headers=headers, query=query)
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/common.py", line 425, in _download_webpage_handle
urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query)
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/extractor/common.py", line 405, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/YoutubeDL.py", line 2000, in urlopen
req = sanitized_Request(req)
File "/usr/local/lib/python3.5/dist-packages/youtube_dl/utils.py", line 518, in sanitized_Request
return compat_urllib_request.Request(sanitize_url(url), *args, **kwargs)
File "/usr/lib/python3.5/urllib/request.py", line 269, in init
self.full_url = url
File "/usr/lib/python3.5/urllib/request.py", line 295, in full_url
self._parse()
File "/usr/lib/python3.5/urllib/request.py", line 324, in _parse
raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: '/yts/jsbin/player-en_US-vflkk7pUE/base.js'
(caused by ValueError("unknown url type: '/yts/jsbin/player-en_US-vflkk7pUE/base.js'",))

Duplicate of #910


1.12.1 endless Hydrogen for jetpacks

Issue description:
when using the Jetpack and the armored Jetpack if you hold spacebar for a length of time (to use Hydrogen)
then release the spacebar and press again, then the Hydrogen fills back up again
Endless hydrogen and never need to refill
Steps to reproduce:

Make a jetpack
2.use space bar to go up for a few seconds and watch your hydrogen levels
3.release space bar and press again and the hydrogen levels are back up to full

Version (make sure you are on the latest version before reporting):
forge-1.12.1-<IP_ADDRESS>6-universal
spongeforge-1.12.1-2444-7.0.0-BETA-2537.jar
Mekanism1.12.1-<IP_ADDRESS>8
No errors show

Thanks for reporting, this is however a duplicate of #3805.


Can't resize volumes migrated after CSI migration

Hello,
I don't know if I should open an issue here or at the csi-resizer repo.
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
The binaries affected:

[ ] cinder-csi-plugin

What happened:
I tried to resize a volume created by Intree cinder plugin after migration from intree cinder plugin to CSI.
What you expected to happen:
The volume to be resized
How to reproduce it:
I created a PVC on my Kubernetes cluster using cinder intree provider. Then I migrated to CSI using the doc.
Then I tried to resize the PVC:
kubectl patch pvc mysql-pv-claim -p '{ "spec": { "resources": { "requests": { "storage": "6Gi" }}}}'
Anything else we need to know?:
When creating a volume once the migration is done I can resize volume without any problem.
The bug only applies on volumes created by cinder intree plugin.
Events on the PVC:
Normal   ExternalExpanding  15m (x22 over 87m)  volume_expand  CSI migration enabled for cinder.csi.openstack.org; waiting for external resizer to expand the pvc
Warning  ExternalExpanding  15m (x22 over 87m)  volume_expand  error getting CSI driver name for pvc default/mysql-pv-claim, with error could not find CSI Driver name for plugin cinder.csi.openstack.org

Logs of csi-resizer:
I1212 11:28:30.505522       1 controller.go:211] Started PVC processing "default/mysql-pv-claim"
I1212 11:28:30.505751       1 csi_resizer.go:127] PV pvc-a8e0d3ff-1cce-11ea-ba01-ea30067a6eb6 is not a CSI volume, skip it
I1212 11:28:30.505765       1 controller.go:269] Resizer "cinder.csi.openstack.org" doesn't support PV "pvc-a8e0d3ff-1cce-11ea-ba01-ea30067a6eb6"
I1212 11:28:30.505779       1 controller.go:245] No need to resize PV "pvc-a8e0d3ff-1cce-11ea-ba01-ea30067a6eb6"

Environment:

Kubernetes version: 1.15
Csi-resizer: 0.2.0:
Cinder-csi-plugin Sha256: a065f58ac06f7359f97f2c06b1e97d39c795447bb80e20b7f5216e66effa620e

Thank you in advance for your help

@thcdrt Looks like pvc is not being identified as migrated intree volume , Could you paste the o/p of  kubectl describe pvc and kubectl describe pv
Ideally for migrated PV this annotation volume.kubernetes.io/storage-resizer should be set to csi driver name.

Hello @ramineni , thanks for your answer.
`> kubectl describe pvc
`
`> kubectl describe pv
`
Who should set the annotation volume.kubernetes.io/storage-resizer to the PV ?
I use the 1.16 cinder-csi-plugin version. As said, resizing volumes created with CSI is working like a charm. Only migrated volumes can't be resized, so I don't think it comes from cinder-csi-plugin version.

I added manually the annotation  pv.kubernetes.io/provisioned-by, but this is still not working with the same error message.

@thcdrt yes, sorry its a PVC annotation. It should be automatically set by intree resize controller.
I see that you are getting the below error , might be reason its returning before setting the above annotation.
 Warning  ExternalExpanding  15m (x22 over 87m)  volume_expand  error getting CSI driver name for pvc default/mysql-pv-claim, with error could not find CSI Driver name for plugin cinder.csi.openstack.org
From the above error , looks like its trying to retrieve the mapping between intree to CSI , but as its already set to csi driver name 'cinder.csi.openstack.org'  so its failing .
Could you try again without manually changing anything to csi driver name in PV, that should solve the issue.

Hello @ramineni ,
I tried without modifying the annotation too, but still not working:
kubectl describe pvc
Name:          mysql-pv-claim
Namespace:     default
StorageClass:  cinder-high-speed
Status:        Bound
Volume:        pvc-feb15643-1fe4-11ea-9d70-d6335d876b32
Labels:        <none>
Annotations:   kubectl.kubernetes.io/last-applied-configuration:
                 {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"mysql-pv-claim","namespace":"default"},"spec":{"acc...
               pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: kubernetes.io/cinder
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      2Gi
Access Modes:  RWO
VolumeMode:    Filesystem
Mounted By:    mysql-7b9b7999d8-bpblt
Events:
  Type     Reason                 Age                 From                         Message
  ----     ------                 ----                ----                         -------
  Normal   ProvisioningSucceeded  12m                 persistentvolume-controller  Successfully provisioned volume pvc-feb15643-1fe4-11ea-9d70-d6335d876b32 using kubernetes.io/cinder
  Warning  ExternalExpanding      18s (x12 over 28s)  volume_expand                error getting CSI driver name for pvc default/mysql-pv-claim, with error could not find CSI Driver name for plugin cinder.csi.openstack.org
  Normal   ExternalExpanding      8s (x13 over 28s)   volume_expand                CSI migration enabled for cinder.csi.openstack.org; waiting for external resizer to expand the pvc

kubectl describe pv
Name:              pvc-feb15643-1fe4-11ea-9d70-d6335d876b32
Labels:            failure-domain.beta.kubernetes.io/region=GRA5
                   failure-domain.beta.kubernetes.io/zone=nova
Annotations:       kubernetes.io/createdby: cinder-dynamic-provisioner
                   pv.kubernetes.io/bound-by-controller: yes
                   pv.kubernetes.io/provisioned-by: kubernetes.io/cinder
Finalizers:        [kubernetes.io/pv-protection external-attacher/cinder-csi-openstack-org]
StorageClass:      cinder-high-speed
Status:            Bound
Claim:             default/mysql-pv-claim
Reclaim Policy:    Delete
Access Modes:      RWO
VolumeMode:        Filesystem
Capacity:          2Gi
Node Affinity:
  Required Terms:
    Term 0:        failure-domain.beta.kubernetes.io/region in [GRA5]
                   failure-domain.beta.kubernetes.io/zone in [nova]
Message:
Source:
    Type:       Cinder (a Persistent Disk resource in OpenStack)
    VolumeID:   b8312d18-2463-4035-9144-53ab4811546a
    FSType:
    ReadOnly:   false
    SecretRef:  nil
Events:         <none>

Indeed, I just tried to not changer the storageclass and it's now working. Thanks for the debugging ! Maybe it could be added in the migration doc !
Thomas


fix fetchAll method not exist

Thank you for mentioning, but I've already updated the README.md and removed the standard PDO-code (18a7948dad0e942a14d2611cf56329d9c185cf73) :wink:


travis: remove the ugly travis_mariadb.sh script

Travis provides MariaDB as an addon anyways.
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

Great! LGTM :+1: Thank you for this!


Merge conservation_rules and rule_priorities attributes

While investigating #272, I started to wonder why EdgeSettings and NodeSettings require conservation_rules as well as rule_priorities. Can't these two just be combined into one attribute of type dict[Rule, int]?
https://github.com/ComPWA/qrules/blob/e60ff895b4cf84be18291b6e4fe0ab516e75a493/src/qrules/solving.py#L44-L50

Aside from tests, Edge/NodeSettings is mainly used in settings.create_interaction_settings(...) but which is then heavily employed in the StateTransitionManager.  Should this be in its own branch?

Should this be in its own branch?

Yes as far as possible it is better to keep refactorings isolated and small

Some idea after discussions: we could write something like:
conservation_rules:  dict[GraphElementRule, RulePriorities]

where RulePriorities is Annotated

Rewriting get_rules_by_priority() with the new definitions of Edge|NodeSettings
causes an infinite-loop in tests/channels/test_y_to_d0_d0bar_pi0_pi0.py

Funny, seems that the rule priorities never did anything from the start 😂
https://github.com/ComPWA/qrules/blob/e60ff895b4cf84be18291b6e4fe0ab516e75a493/src/qrules/solving.py#L539-L541
The keys are x, not type(x), so it always falls back to 1


Fix custom server URL workflow

Make sure to let the user know that http is required, as well as the port

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #desktop-bugs.

I think this is more or less fixed


5.1.0添加网易云跟帖后,首页加载时cloud-tie-wrapper元素未加载导致js报错

Expected behavior (预期行为)
首页加载时，评论系统不应该加载，只有page加载时才加载评论系统
Actual behavior (实际行为)
首页加载时, 引用了云跟帖的SDK, 但是对应的wrap没有加载
Steps to reproduce the behavior (重现步骤)
NexT Information
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist
Pisces

Other Information (Like Browser, System, Screenshots)

我在_third-party/comments/index.swig中添加了判断
{% if page.comments %} ... {% endif %}
问题暂时解决

That should be a bug

@TimLuo465 don't understand u, write in English if not solved. If solved, close it please. Thank's!


overflow fixed

Initially it was overflowing

Now it is like this

In Smaller screens it looks like this
JUST HAVE TO FIX THE TABLE OVERFLOW IN SMALLER SCREENS

OK can u fix the table overflow??

OK can u fix the table overflow??

I can make it scrollable, should I do that?


Update to Diffusers 0.11

What does this PR do?

This PR integrates changes from the latest release of the Diffusers library (v0.11.1).
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update AutoRest C# version

Update AutoRest C# version to 3.0.0-beta.20220621.2

Conflict resolving at https://github.com/Azure/azure-sdk-for-net/pull/29063

Close this since the content of this PR has been merged in #29063


tags on github should include py3

the tags below the project description now only tell python2 and python27, but the ci and also the pypi metadata also includes py35/36/37.
https://github.com/liuliqiang/flask-theme
to keep it easy, the tags could just tell python2 and python3.

Yes, it's test passed in python3 now.


bad behaviour of contextmenu callback for geoJSON layer objects

Hi,
I try to give different link on a contextmenu depending of which JSON element was right clicked.
Here is a fiddle for this bug:
http://jsfiddle.net/jdembdr/y97k2n2z/embedded/result/
The same property (name 'A') appears in my callback for every element when I try to initialize a contextmenu during the onEachFeature processing of the  GeoJSON layer building step.
var controlLayer = L.control.layers();
controlLayer.addOverlay(L.geoJson(docks_json, {onEachFeature: addContextLayer}),'Docks');

function addContextLayer(feature, layer) {
    if (feature.properties && feature.properties.name) {
		var contextMenuItems = [{
        	text: 'dock name',
        	callback: function(e){alert(feature.properties.name)},
    	},];
    	this["contextmenu"]=true;
        this["contextmenuItems"]=contextMenuItems;
        this["contextmenuInheritItems"]=false;
	}
}

ie . feature.properties.name is the same for every element when callback is called.
I don't know very well JS so maybe is it just a misunderstanding of the langage, but if you could help me, It would be great !

I've already tried to make working solution proposed fot bug https://github.com/aratcliffe/Leaflet.contextmenu/issues/12.
However, I think I'm doing everything wrong.
Could you confirm me that with your API, a contextmenu can only be attached to a map, a marker or a layer and can't be different for all polygons of a GeoJSON layer ?
function addContextLayer(feature, layer) {
     if (feature.properties && feature.properties.name) {
         var marker;
         marker = new L.Marker([43.12, 5.34], {
             title: feature.properties.name,
             contextmenu: true,
             contextmenuItems: [{
                 text: 'dock ' + feature.properties.name,
                 callback: function (e) {
                     alert(feature.properties.id);
                 },
                 context:feature,

             }, {
                 separator: true,
                 index: 1
             }]
         });
         marker.addTo(layer);
     }
 }

If so, a solution would be to create a marker for each polygon and attach a contextmenu on it.
Do you agree ? Do you know an another solution ?

Hi, the context menu mixin supports showing/hiding the context menu on L.Marker and L.Path layer types. It adds a bindContextMenu() method to these types which accepts the context menu options. It's this method you need to use in the onEachFeature callback.
I was looking at your fiddle and you were attempting to set the context menu options on the L.GeoJSON layer itself, this meant that with each invocation of the callback you were simply overwriting the options and explains why you saw the same property displayed when clicking the context menu item - it was the value for the last feature the callback was invoked for.
The layer object passed to the callback refers to a L.FeatureGroup not an L.Path type, probably because your GeoJSON data contains multipolygon data, thus you need to call bindContextMenu() on each of the group's features.  The re-written callback looks like this:
function addContextLayer(feature, layer) {
    if (feature.properties && feature.properties.name) {
		var contextMenuItems = [{
        	text: 'dock name',
        	callback: function(e){alert(feature.properties.name)},
    	},];

        layer.eachLayer(function (l) {
            l.bindContextMenu({
                contextmenu: true,
                contextmenuItems: contextMenuItems
            });
        });
	}
}

Thank you !
It works perfectly, as expected. I close this issue.


Fix #313

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

81 of 81 (100.0%)  changed or added relevant lines in 24 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1098

Relevant Lines:
1098

💛  - Coveralls


use schemas for istructs

Now:

package schemas uses package istructs

Must be:

package istructs uses package schemas.

Dev branch: https://github.com/mail2nnv/voedger/tree/42-use-schemas-for-istructs


Commonmarker 1.0 switches to Rust implementation

Noticed that Commonmarker 1.0 will switch to use https://github.com/kivikakk/comrak (https://docs.rs/comrak) instead of https://github.com/github/cmark-gfm, saving some interesting links

https://github.com/gjtorikian/commonmarker/pull/194
https://github.com/gjtorikian/commonmarker/pull/185
https://github.com/gjtorikian/commonmarker/pull/209
https://github.com/gjtorikian/commonmarker#commonmarker
https://github.com/kivikakk/comrak
https://rubygems.org/gems/commonmarker/versions

Maybe there will be some new features we can make use of? Thinking of syntax highlighting
We can close this issue once we use 1.0

On the topic of Rust, there's https://github.com/gjtorikian/html-pipeline/pull/368

This completes one of the blocking items for a v3 release: migrating to Selma. Selma's process for parsing html uses lol-html, a Rust library, as its underlying mechanism. It operates purely on CSS selectors, and has a few advantages over the current Nokogiri based mechanism. Namely, in the current systen, text is parsed over multiple times. Each NodeFilter runs its set of CSS selectors synchronously. lol-html, on the other hand, parses the text once, compiles its CSS selectors, and more efficiently allows for text manipulation.


auro-input: style code not compliant with 3.7.1 lint rules

Describe the bug
The latest version of auro-input that was updated to generator version 3.7.1 is not compliant with the stylelint rules included in that version of the generator.
The changes necessary are significant and should be addressed and thoroughly vetted as a separate work item.
To Reproduce
Steps to reproduce the behavior:

Clone the repo
run npm i
Open src\styles.scss and delete all the stylelint disable comments
run npm run linters

Expected behavior
The style lint rules should pass without any disabled

I am assuming that this will be pulled into the Repo upgrade PR?

Is this commit related to this issue? https://github.com/AlaskaAirlines/auro-input/pull/49/commits/91b4591a18021036c585cd10d62e275aa7285058


[BUG] Koheesio 0.9.0 and Spark Connect: delta.connect present only on Databricks

Bug Description
When testing new version of Koheesio - https://github.com/Nike-Inc/koheesio/pull/97
And issue is observed when using DeltaTableWriter.
--> 257 raise ValueError(
    258     "Provide `merge_builder` in "
    259     "DeltaTableWriter(output_mode_params={'merge_builder': DeltaMergeBuilder()}). "
    260     "See documentation for options."
    261 )

The problem stems from the code https://github.com/Nike-Inc/koheesio/blob/6d6ccbd1167b78c16719d3df62bc03193ab0f5d2/src/koheesio/spark/writers/delta/batch.py#L251 which checks specifically for delta.tables.DeltaMergeBuilder instance.
As there is no delta.connect.tables module in open-source delta-io package releases at the moment (2024.11.11) the possible way to resolve this issue is to check for class name or fully-qualified class name without connect part instead of using ininstance check as connect classes aren't subclasses of their regular counterparts.
Expected behavior
Using DeltaMergeBuilder doesn't fail if code is executed in Spark Connect mode on Databricks and DBR 15.4+
Environment

DBR 15.4
Koheesio 0.9.0rc0
-->

Additional context
Same problem can happen with other classes from same namespaces delta.tables and delta.connect.tables in case Pydantic or other ways of type checking will check for first classes.

#100 should fix this

Validated on 0.9.0rc6, issue is no longer present.


Instructions

Hi, thanks for this project.
Maybe add some raw instructions on README how to get it up and running on some sistems (Linux, Win...)?

Good idea! I will add it in a few days.
You can download one you need and execute ./GarnetServer or .\GarnetServer.exe.


Proposal to not making this strange strange to the API

Removing the async suffix from all the async methods is a bad idea... from a Couchbase enterprise customer

@sam-fold-cko -
Thanks for the feedback! Yes, its an idea we have been throwing out there; largely because there is no synchronous API and no real reason to seperate async from sync calls. There is a ticket available for comment: https://issues.couchbase.com/browse/NCBC-1959
Thanks,
Jeff

http://review.couchbase.org/c/110848/


minor change in documentation

In 'ht.boiling_nucleic.Zuber' function, K is a user input (variable) whose default value is 0.18. Hence, the value 0.149 is changed to K in general.

minor correction in documentation

Thank you Vikram! I hope you found the library useful.

Yes, it is very useful. Thank you


Invalid value error thrown on intersection value within struct

Version
3.2.3
Expected behaviour
Should not error on intersection type as property of struct.
Actual behaviour
Invalid value error.
/Users/chris/Projects/testtest/node_modules/tcomb/lib/fail.js:2
  throw new TypeError('[tcomb] ' + message);
  ^

TypeError: [tcomb] Invalid value {
  "string": "Test"
} supplied to Struct{a: Struct{string: {String | <function1>}} & Struct{string: {String | <function1>}}}/a: Struct{string: {String | <function1>}} & Struct{string: {String | <function1>}}
    at Function.fail (/Users/chris/Projects/testtest/node_modules/tcomb/lib/fail.js:2:9)
    at assert (/Users/chris/Projects/testtest/node_modules/tcomb/lib/assert.js:14:12)
    at Intersection (/Users/chris/Projects/testtest/node_modules/tcomb/lib/intersection.js:27:7)
    at create (/Users/chris/Projects/testtest/node_modules/tcomb/lib/create.js:10:66)
    at new Struct (/Users/chris/Projects/testtest/node_modules/tcomb/lib/struct.js:82:19)
    at Object.validateStruct [as struct] (/Users/chris/Projects/testtest/node_modules/tcomb-validation/index.js:173:17)
    at recurse (/Users/chris/Projects/testtest/node_modules/tcomb-validation/index.js:71:38)
    at Function.validate (/Users/chris/Projects/testtest/node_modules/tcomb-validation/index.js:66:31)
    at Object.<anonymous> (/Users/chris/Projects/testtest/run.js:28:18)
    at Module._compile (module.js:413:34)

Steps to reproduce
Run the following code (note how the alternative commented lines work fine):
const t = require('tcomb-validation');

const Min = t.refinement(t.String, (s) => s.length > 2);
const Max = t.refinement(t.String, (s) => s.length < 5);

const TypeA = t.struct({string: Min});
const TypeB = t.struct({string: Max});

const Type = t.struct({
  test: t.intersection([TypeA, TypeB])
});

const val = {
  test: {
    string: 'Test'
  }
};

//const Type = t.intersection([TypeA, TypeB]);
//const val = {string: 'Test'};

const result = t.validate(val, Type);
console.log(result);

Stack trace and console log
Will follow up with this if required!
Thanks in advance! :)
Ps. Sorry if this is wrong repo, my guess was this is more core tcomb rather than actually validation related

Hi @chrisui,
thanks for the detailed report. This is an edge case: please note how, since structs are nominal (i.e. their is functions are implemented with instanceof) this set is empty:
t.intersection([TypeA, TypeB])

so, from a theoretical point of view, the current behavior is correct.
I suggest to use interface instead of struct:
const Min = t.refinement(t.String, (s) => s.length > 2);
const Max = t.refinement(t.String, (s) => s.length < 5);

const TypeA = t.interface({string: Min}); // <= interface
const TypeB = t.interface({string: Max}); // <= interface

const Type = t.struct({
  test: t.intersection([TypeA, TypeB])
});

const val = {
  test: {
    string: 'Test'
  }
};

const result = t.validate(val, Type);
console.log(result);

The alternative commented lines work fine because... you have actually found a bug in tcomb-validation, so this issue is in the right place :)

Gotcha! Thanks for the aid and glad to be of some help. ;)

Closing in favour of https://github.com/gcanti/tcomb-validation/issues/42


[Roadmap] Add an "about us"/"about me" to the project

Why
I want to understand more about the "why" and the creators of this project. It looks like a really awesome and significant effort, and I would like to know more about the motivations and intent behind it.
Thanks to the licence, it seems to be truly open source. I would just like to get clarification somewhere about if this is the end goal of the project.
There are many AI quickstart style repos, and it's hard to quickly differentiate which are e.g. startup/VC funded, large company backed, going to be monetised soon, etc. The website feels like a SaaS, but there's no pricing or other info that makes it seem that way.
Description
Some short "about us" or "about me" in either the website or the repo would be helpful.

It's a great request, thanks for asking @WillSmithTE - it's been mostly myself and friends on this project, and it has been developed in the true opensource fashion (sharing, open, welcoming contributions, open roadmap, participatory development, etc.).
Big-AGI introduces features ahead of time over and over, such as Beam last month, or Calls (before anyone), and a lot of other usability and UX smarts - which we care about. Over time many other projects will have them too. (try BEAM now, nobody has copied it yet to its full power!!) Btw: I have lots of AI experience as product manager in the AI space since 2018, plus AI development experience from custom models to UIs (e.g. https://www.soulreplica.com/brodown, 2020).
The roadmap is really exciting and I really wish I had more people helping!! The project did not get blessed with 'hype' status and it does not attract developers apparently 🤷 : the quality bar is HIGH (as you can see by using it), the code is broad (400+ files), and it's less fun to hack on than starting from scratch a weekend AI project. So the fun of development falls on me most of the time, and this doesn't scale as the feature surface keeps broadening.
The website follows a SaaS footprint, but there's nothing to pay 😃 - the code is truly open, and the dev model is opensource. Anyone can take it, deploy it, develop it, and I know of many internal deployments of big-AGI as it's a great project for one's/a company's internal AI needs.

Thanks so much for the detailed response, Enrico! That's exactly the kind of information I was looking for. Having only used it for a few hours, I could feel the attention to detail and UX you've paid. I'm really excited to make use of Big-AGI in both my personal and working life.

How can we attract more developers to this project?
How about posting it on ProductHunt?

How can we attract more developers to this project?
How about posting it on ProductHunt?

This is a great question, I'd love to get any idea on this. Right now the major bottleneck is exactly the speed of development, as their world map is amazing and huge.
Personally I never posted on product hunt so I don't know exactly how this is going to work or what are the best practices or how to not butcher the launch. Anyone expert?


No colors in yarn tasks output

When running Yarn tasks using this gradle plugin, I get no colors in the output. Running the same commands using Yarn directly prints colorized text.
e.g:
./gradlew yarn_list : all text is white
vs.
yarn list : text is white and gray

Any update on this yet?

I'm running into this as well. Is there a way to enable colored output?

@mroloux this plugin hasn't seen active development in a long while, there's however a maintained fork available.
But I also have a feeling that this wasn't an issue on Linux and with npm, so more information is probably required to solve this

@deepy Thanks!
I assume this is the fork you're referring to? https://github.com/node-gradle/gradle-node-plugin
Seems like it has the same issue - no colored output. Guess we'll have to live without it then ;-)

That's the one yeah, though for coloured output there might be a way to force yarn/npm to do coloured output.
You could try adding --color=full into args and see if that helps.
Something like:
tasks.named('yarn_list').configure { args += '--color=full' }

When I execute yarn run tsc (outside of Gradle), the colors are printed just fine. So it must be related to how Gradle handles the output of yarn.
I've tried add --color=full, but that doesn't seem to be a supported parameter.
Also tried --console=rich, but that didn't make a difference.
Thanks for the help!

This issue has some variations that might be worth trying https://github.com/yarnpkg/yarn/issues/5733

Yes, FORCE_COLOR=true did the trick! Thanks so much!
I also added the --pretty flag to the tsc command, to get nicely colored errors from TypeScript. And --colors to prettify Jest.
Who would have known that Yarn, tsc and Jest would behave so differently within Gradle 🤔

Most tools do when the output isn't a tty, you can simulate it by doing yarn install | cat, but I'm glad you managed to get it working :-)


Hi!

I am the server administrator. I have a question. Can I take your code for the list of players and place it on my site so that it will update itself? and how do i do that?

Sorry for the late response. As it is now there's no way to export content as a widget 😢


Publish the package to the stable channel

The stable channel in the snap store is the default channel, a channel for stable and released packages. When I feel conformable that this package works and is usable by the general public, publish it to the stable channel.

I published yesterday to the stable channel


Us022 disable enrolment status

Added tests for disabling an enrolment for a respondent
Added a wait after registering a respondent to let the case service update
Works with other PR's:
response-operations-ui
ras-backstage
ras-party
Confluence
Trello

 US022: INT Disable respondents enrolment to a survey [L]


v0.3.0-beta.2 issues: integration won't load

Hi @Snuffy2, just upgraded to beta.2 from beta.1 (that worked), and have some issues that stops integration from starting:
Logger: custom_components.opnsense.pyopnsense
Source: custom_components/opnsense/pyopnsense/__init__.py:143
integration: OPNsense
First occurred: 02:14:35 (1 occurrences)
Last logged: 02:14:35

Invalid data returned from get_config_section

Logger: custom_components.opnsense.pyopnsense
Source: custom_components/opnsense/pyopnsense/__init__.py:98
integration: OPNsense (documentation, issues)
First occurred: 02:14:33 (9 occurrences)
Last logged: 02:14:35

Error in get_services. AttributeError: 'NoneType' object has no attribute 'keys'
Error in get_carp_interfaces. RuntimeError: Caught blocking call to putrequest with args (<http.client.HTTPConnection object at 0x75b9b4c07500>, 'POST', '/xmlrpc.php') inside the event loop by custom integration 'opnsense' at custom_components/opnsense/pyopnsense/__init__.py, line 123: methods = proxy.system.listMethods(). (offender: /usr/local/lib/python3.12/xmlrpc/client.py, line 1284: connection.putrequest("POST", handler, skip_accept_encoding=True)), please create a bug report at https://github.com/travisghansen/hass-opnsense/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#putrequest
Error in get_carp_status. RuntimeError: Caught blocking call to putrequest with args (<http.client.HTTPConnection object at 0x75b99728bf20>, 'POST', '/xmlrpc.php') inside the event loop by custom integration 'opnsense' at custom_components/opnsense/pyopnsense/__init__.py, line 123: methods = proxy.system.listMethods(). (offender: /usr/local/lib/python3.12/xmlrpc/client.py, line 1284: connection.putrequest("POST", handler, skip_accept_encoding=True)), please create a bug report at https://github.com/travisghansen/hass-opnsense/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#putrequest
Error in are_notices_pending. RuntimeError: Caught blocking call to putrequest with args (<http.client.HTTPConnection object at 0x75b99754a150>, 'POST', '/xmlrpc.php') inside the event loop by custom integration 'opnsense' at custom_components/opnsense/pyopnsense/__init__.py, line 123: methods = proxy.system.listMethods(). (offender: /usr/local/lib/python3.12/xmlrpc/client.py, line 1284: connection.putrequest("POST", handler, skip_accept_encoding=True)), please create a bug report at https://github.com/travisghansen/hass-opnsense/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#putrequest
Error in get_notices. RuntimeError: Caught blocking call to putrequest with args (<http.client.HTTPConnection object at 0x75b9a0875820>, 'POST', '/xmlrpc.php') inside the event loop by custom integration 'opnsense' at custom_components/opnsense/pyopnsense/__init__.py, line 123: methods = proxy.system.listMethods(). (offender: /usr/local/lib/python3.12/xmlrpc/client.py, line 1284: connection.putrequest("POST", handler, skip_accept_encoding=True)), please create a bug report at https://github.com/travisghansen/hass-opnsense/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#putrequest

Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:361
integration: Sensor (documentation, issues)
First occurred: 02:14:35 (1 occurrences)
Last logged: 02:14:35

Error while setting up opnsense platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 361, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/config/custom_components/opnsense/sensor.py", line 361, in async_setup_entry
    cem.process_entities()
  File "/config/custom_components/opnsense/__init__.py", line 224, in process_entities
    entities = self.process_entities_callback(self.hass, self.config_entry)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/opnsense/sensor.py", line 111, in process_entities_callback
    for interface in state["carp_interfaces"]:
TypeError: 'NoneType' object is not iterable

Logger: homeassistant.components.switch
Source: helpers/entity_platform.py:361
integration: Switch (documentation, issues)
First occurred: 02:14:35 (1 occurrences)
Last logged: 02:14:35

Error while setting up opnsense platform for switch
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 361, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/config/custom_components/opnsense/switch.py", line 198, in async_setup_entry
    cem.process_entities()
  File "/config/custom_components/opnsense/__init__.py", line 224, in process_entities
    entities = self.process_entities_callback(self.hass, self.config_entry)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/opnsense/switch.py", line 40, in process_entities_callback
    if "filter" in state["config"].keys():
                   ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'keys'

Yeah, same for me. Trying to sort out what happened now.

Give v0.3.0-beta.3 a try.
PR #190 was the issue. I wrote and tested it but I tested it before I moved everything to async. It will need to be reworked.

Works! Thanks.


add  floating point example to range() documentation.

Illustrate floating point precision issue with example range and suggest using .map on integer range instead. See issue #5 .

Just noticed this pull request! Sorry for the delay, and thank you!

No problem. Glad to contribute.


Validate before deleting directories

When unpacking, we delete the target directory - this is so stale artifacts aren't overwritten.
But if they specify the wrong directory (ie, desktop), that could delete too much and cause major data loss.

See call to DeleteAllSubdirs()
https://github.com/microsoft/PowerApps-Language-Tooling/blob/58275118c9aa429e6605bf734b95926be81c4196/src/PAModel/Serializers/SourceSerializer.cs#L443


nixos/moq-relay: init moq-relay systemd service

Description of changes
Create nixos module for moq-relay. moq-relay package comes from #342437

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

pls, try to not ping 3500+ ppls this time. 💀

pls, try to not ping 3500+ ppls this time. 💀

🤷 as one of the people getting pinged, at what point do we take responsibility for the fragility of this system? do we truly expect nobody to ever make the mistake of merging off staging and accidentally creating a PR into the default base branch offered by GH (master)? 😛 I know I've been there.
thanks for the contribution  @therishidesai  :)

pls, try to not ping 3500+ ppls this time. 💀

Sorry about that

Can't you just have one PR and init the package in one commit and init the module in the other 2 commits?

Can't you just have one PR and init the package in one commit and init the module in the other 2 commits?

Was just basing this off of other packages where the package was added in an init PR and the nixos module was in another PR

Commit message should be moq-relay: init at 0.6.0. Please add some hardening to the service.

I had a separate PR to just add the moq-relay package. Is it fine that this PR has 2 commits? In the past I remember maintainers asking for single atomic commits in the PR

Please add some hardening to the service.

I'm not too familiar with the systemd hardening. Are there any services I should look at for hardening examples? What specifically makes sense for this server?

Are there any services I should look at for hardening examples?

Just grep for "hardening" in nixos/.

Are there any services I should look at for hardening examples?

Just grep for "hardening" in nixos/. Also see https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html.

Added some new hardening and cleaned up users/groups similar to other server modules in nixos.


Add legacy "e3sm_coupling" script from COMPASS

This script produces MPAS-Ocean and MPAS-Seaice initial conditions from a standalone MPAS-Ocean spin-up run.  It also produces scrip files, masks for MPAS-Ocean analysis members, masks and mapping files for MPAS-Analysis, and partition files for MPAS-Ocean.

I made a legacy directory for this stuff and any other scripts that have hard-coded paths and such that require a lot of user modification to be useful.  My hope is that we will eventually move the functionality from legacy into a set of scripts or a conda package or something like that that will be more portable and easier for new users to understand.

@jonbob, I'm mainly asking for your review to make sure you're good with the README.
@mark-petersen, I'm mainly asking for your review to give you a heads-up that I plan to move this content here and gradually drop it from COMPASS
@vanroekel, I'm mostly keeping you in the loop but please feel free to give feedback.

@xylar thanks for working on this. You put the binary .swp file in by mistake, right? Best to --amend the last commit, otherwise it just stays in the repo forever.

@mark-petersen, thanks very much for noticing the swap file.  It has been removed from the commit.

@xylar I like the structure you add here and think the README looks great.

@jonbob, could you review this when you get a chance?  Or remove yourself as a reviewer if you prefer not to.

Sorry @xylar -- this one slipped off my radar. I'll review it this morning

Thanks everyone!


allow configuration of ClipMode original drawer

Hello,
first of all thanks a lot for your Extensions, I was searching for exactly the same thing (ie drawer use like a dialog) in MudBlazor.
One of my requirement was to be able to display the drawer without hiding the AppBar. So I've made this small PR to allow access to this options of the original drawer.
Thanks!

Hi @jdevillard!
Apologies for the silence.  I had moved away from my Blazor project and so hadn't paid attention to these packages.  Let me take a look at the pull request and get back to you!


fix(ci): use npm instead of pnpm

I guess the Check will also fail as the changes are in the PR 🙈

Oh no, it did work, but here are type check errors now, that I don't see locally:
Error: src/pages/index.tsx(2,20): error TS2307: Cannot find module<EMAIL_ADDRESS>or its corresponding type declarations.
Error: src/pages/logo.tsx(2,20): error TS2307: Cannot find module<EMAIL_ADDRESS>or its corresponding type declarations.
Error: Process completed with exit code 2.


Native notifications are not working in Linux

Please include:

Operating System - Ubuntu 16.04

Maybe because of https://github.com/zulip/zulip-electron/commit/71637d8e9289ab6b9d03e6b4e3b5f595aa874724 🤔

Updated electron to the latest version and notifications seem to be working as expected 🎉  @timabbott could you please cross-test it?

✔  Working as expected.


Fabio Manual Overrides Issue

Fabio shows service in routing table even though the service is down and marked not healthy by consul
Scenario

We have a service running from 2 boxes registered with consul which does a health check and fabio shows the service in it's routing table with equal weight age. Now we have a manual override and reduced the traffic to one of the server to 35% using the following command.
route weight RFGreen /green weight .35 tags "/green2"
Now fabio shows 65% traffic to 1 server and 35% to other. Next we stop the server which is receiving 35% of the traffic and consul shows the service as not healthy but fabio still shows the route in it's routing table.
Is there a way we can have this route removed from the routing table when the service is not healthy?

That problem is related to this issue: https://github.com/fabiolb/fabio/issues/224
As soon as there is an error in the manual override (in this case the tag can't be matched anymore), the auto updating of the routing table stops.


Baseline answer is undefined

Baseline answer is undefined here
https://github.com/JHU-CLSP/turk-instructions/blob/main/src/evaluation.py#L251

We can close this issue.


IndexError: map::at when calling _triton.code_gen.add_passes_to_emit_bin

(Congratulations on the release! This looks like a very interesting package :smiley:)
Both building from source and installing the wheel on my machine, attempting to run anything always results in IndexError: map::at. When attempting to run the vector addition example, for example:
$ python vector_addition.py
/home/gmarkall/miniconda3/envs/triton-wheel/lib/python3.9/site-packages/torch/package/_mock_zipreader.py:17: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at  /pytorch/torch/csrc/utils/tensor_numpy.cpp:67.)
  _dtype_to_storage = {data_type(0).dtype: data_type for data_type in _storages}
Traceback (most recent call last):
  File "/home/gmarkall/numbadev/triton/tutorials/vector_addition.py", line 50, in <module>
    zb = add(x, y)
  File "/home/gmarkall/numbadev/triton/tutorials/vector_addition.py", line 39, in add
    _add[grid](x, y, z, N, BLOCK=1024)
  File "/home/gmarkall/miniconda3/envs/triton-wheel/lib/python3.9/site-packages/triton/code_gen.py", line 599, in __call__
    return self.kernel(*wargs, **kwargs, grid=self.grid)
  File "/home/gmarkall/miniconda3/envs/triton-wheel/lib/python3.9/site-packages/triton/code_gen.py", line 576, in __call__
    cache[key] = self._compile(
  File "/home/gmarkall/miniconda3/envs/triton-wheel/lib/python3.9/site-packages/triton/code_gen.py", line 550, in _compile
    mod, ker, shared_mem, ir_asm = _triton.code_gen.add_passes_to_emit_bin(generator.module, tt_device, num_warps, num_stages, force_nc_cache)
IndexError: map::at

Packages installed in the environment are:
$ conda list
# packages in environment at /home/gmarkall/miniconda3/envs/triton-wheel:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
_openmp_mutex             4.5                       1_gnu
ca-certificates           2021.7.5             h06a4308_1
certifi                   2021.5.30        py39h06a4308_0
ld_impl_linux-64          2.35.1               h7274673_9
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.3.0               h5101ec6_17
libgomp                   9.3.0               h5101ec6_17
libstdcxx-ng              9.3.0               hd4cf53a_17
ncurses                   6.2                  he6710b0_1
openssl                   1.1.1k               h27cfd23_0
pip                       21.1.3           py39h06a4308_0
python                    3.9.5                h12debd9_4
readline                  8.1                  h27cfd23_0
setuptools                52.0.0           py39h06a4308_0
sqlite                    3.36.0               hc218d9a_0
tk                        8.6.10               hbc83047_0
torch                     1.9.0                    pypi_0    pypi
triton                    1.0.0                    pypi_0    pypi
typing-extensions         <IP_ADDRESS>                 pypi_0    pypi
tzdata                    2021a                h52ac0ba_0
wheel                     0.36.2             pyhd3eb1b0_0
xz                        5.2.5                h7b6447c_0
zlib                      1.2.11               h7b6447c_3

I'm guessing that perhaps there's something missing / a wrong version on my system? I couldn't find an exact list of requirements - have I missed something somewhere?
Many thanks in advance for any help!

Maybe of note (or not): I do see this error mentioned in https://github.com/openai/triton/issues/99#issuecomment-846171997, but the response there seems to indicate that Triton was built against a broken commit in that instance (and it's from some time ago).

Hi!
I wonder if this could come from using an unsupported CUDA version. What Driver and CUDA version are you using?

Thanks for the quick response! I'm using CUDA 11.4 with an unreleased driver - I'll try an older toolkit and report back. Is there a list of supported toolkit and driver versions?

An update: trying with CUDA 11.2 also resulted in the same error on my system.

I think that this may come from the unreleased driver. map::at can come from anywhere, but compiling in debug mode and seeing a traceback would be helpful.
My first guess is that the driver returns an incorrect CUDA identifier (maybe 11041?), and it's not handled here https://github.com/openai/triton/blob/master/lib/driver/module.cc#L214-L223.
Triton actually does not use the CUDA SDK at all by default. But you can still use a more recent compiler than what the driver has by setting TRITON_PTXAS=/path/to/ptxas, which will override using the driver's internal JIT.

Thanks - I tried adding my driver version to vptx but to no avail - I'm trying to step through things to find out where the problematic call to map::at is, but I'm failing to correctly create a debug build - what's the correct way to do a debug build?

You can uncomment this line https://github.com/openai/triton/blob/master/python/setup.py#L81 and reinstall Triton. Then doing something likd gdb -batch -ex "run" -ex "bt" --args python 01-vector-add.py should work

It turned out that I'd somehow not been running with the version I rebuilt, and adding my driver version to vptx did indeed work! I now get:
tensor([1.3713, 1.3076, 0.4940,  ..., 1.1147, 1.1906, 1.5746], device='cuda:0')
tensor([1.3713, 1.3076, 0.4940,  ..., 1.1147, 1.1906, 1.5746], device='cuda:0')
The maximum difference between torch and triton is 0.0

So I guess the bug is that unsupported driver versions are not handled - perhaps if the driver version is greater than the last entry in vptx, it could/should default to the most recent PTX version known? (i.e. if version > 11040, then ptx = 73 at the moment).

Just pushed the fix. Thanks a lot for reporting.
While I have you, could you run pytest -vs . with your internal driver. The blocksparse matmul code generated by Triton triggers a segfault in PTXAS 11.4, and I wonder if it's been fixed in your internal version. (I contacted nvidia already about it and there should be an internal bug report)

Unfortunately:
$ pytest -vs .
==================================================================== test session starts =====================================================================
platform linux -- Python 3.9.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /home/gmarkall/miniconda3/envs/triton/bin/python
cachedir: .pytest_cache
rootdir: /home/gmarkall/numbadev/triton/triton/python
collected 1323 items

test/test_blocksparse.py::test_matmul[sdd-False-False-16-float16] Fatal Python error: Segmentation fault

Current thread 0x00007f09931da240 (most recent call first):
  File "/home/gmarkall/numbadev/triton/triton/python/triton/code_gen.py", line 550 in _compile
  File "/home/gmarkall/numbadev/triton/triton/python/triton/code_gen.py", line 576 in __call__
  File "/home/gmarkall/numbadev/triton/triton/python/triton/code_gen.py", line 599 in __call__
  File "/home/gmarkall/numbadev/triton/triton/python/triton/ops/blocksparse/matmul.py", line 311 in _sdd_matmul
  File "/home/gmarkall/numbadev/triton/triton/python/triton/ops/blocksparse/matmul.py", line 536 in forward
  File "/home/gmarkall/numbadev/triton/triton/python/triton/ops/blocksparse/matmul.py", line 659 in __call__
  File "/home/gmarkall/numbadev/triton/triton/python/test/test_blocksparse.py", line 30 in <lambda>
  File "/home/gmarkall/numbadev/triton/triton/python/triton/testing.py", line 14 in catch_oor
  File "/home/gmarkall/numbadev/triton/triton/python/test/test_blocksparse.py", line 30 in test_matmul
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/python.py", line 183 in pytest_pyfunc_call
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/python.py", line 1641 in runtest
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 162 in pytest_runtest_call
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 255 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 254 in call_runtest_hook
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 215 in call_and_report
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 126 in runtestprotocol
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/runner.py", line 109 in pytest_runtest_protocol
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/main.py", line 348 in pytest_runtestloop
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/main.py", line 323 in _main
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
  File "/home/gmarkall/miniconda3/envs/triton/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
  File "/home/gmarkall/miniconda3/envs/triton/bin/pytest", line 11 in <module>
Segmentation fault (core dumped)

Though, note that I'm not running a particularly recent build. If I move to a newer driver build I'll test again and post an update.

Ok, thanks! Let's close this issue for now. Another CUDA 11.4 issue will be created when we know more about it haha

Isn't it still a bug that you get IndexError: map::at whenever an unrecognized driver version is encountered?
I'd hope instead to get something like RuntimeError: Unsupported driver version <version> so I know what the problem is and can rectify it, or for it to just use the PTX version of the last known driver if the current driver version is higher than a supported version - what do you think?

Thanks! I've further improved error handling in #179


Change forecast labels to component accessor functions

Codecov Report

Merging #27 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   67.92%   67.93%   +<.01%
==========================================
  Files          30       30
  Lines        1347     1338       -9
==========================================
- Hits          915      909       -6
+ Misses        432      429       -3

Impacted Files
Coverage Δ

src/forecast_parser.jl
72.22% <ø> (+0.09%)
:arrow_up:

src/utils/generate_structs.jl
91.83% <ø> (ø)
:arrow_up:

src/utils/test.jl
35.71% <100%> (+4.94%)
:arrow_up:

src/system_data.jl
88.66% <100%> (ø)
:arrow_up:

src/component.jl
86.71% <100%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c5470...f490111. Read the comment docs.

@jd-lara This should now be final.


Create parser for show_cts_sxp_connections_brief

Fixes #7

@reustaquio22 can you please account for all lines. Meaning header lines and lines that look like ------- should be good to identify and remove.

I just added a function to remove empty and unwanted lines.

https://github.com/CiscoTestAutomation/genieparser/pull/188


Improved usability/implementation of the switch

I think the switch code is not so nice.
The label can not be used to add a label text ; and a switch interaction should be easily bound to a readable label...
A possible workaround would be to manually add a text next to the switch interaction item. However, clicking on this fake label will not trigger the switch without Javascript...
It therefore becomes quite tricky to use this Switch item...

We'll be re-writing it for the next version.
We added this to our "known issues" section in our planning board for the next version. A PR would be valuable to the community, otherwise It will be addressed then. You can see and vote on the proposed updates here: https://trello.com/b/QBPKlQqf/foundation-sites

Here's one way it is done: http://codepen.io/ThatRedHead/pen/qhkGg


add requirements to avoid tornado AttributeError

What this PR does / why we need it:
Add requirements to avoid tornado AttributeError
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #508
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/lgtm

/approve


Fix forked-to spacing

Does this PR close/fix an existing issue?
There is a gap between the fork button of a GitHub repository and the forked-to button added to the page from refined-github. This PR removes that gap, making it look neater.
Comparison (Images)
Before

After

Test URLs
Tested on the refined-github repository after making a fork.

Old pull request #5683

Thank you Shaun!

 Glad my first pull request was somewhat decent. Thanks @fregante!


Update Satellite Zarr reader for new format

Detailed Description
Satellite data is now stored in the zarr in unprojected format, so the original geo projection. This does make it slightly more difficult to save the OSGB coordinates in the zarr, as each pixel has a unique OSGB x and y coordinate. Currently, they are stored in the metadata field, under 'osgb_x' and 'osgb_y'. There might be a better way to store it, which we could also do, but for now, we probably need to read in the metadata of one example each for the HRV channel and all the other channels, to get the mapping from image coordinates to OSGB coordinates.
Context

Possible Implementation

Will start on this once the big redesign #307 is merged!

Whats the advantage of this?
There is something nice, about just having it in one, and perhaps the satellite xr.Dataset loading both of them? Perhaps they are singificant different to suggest they should be in a different 'DataSource'

The advantage is minimal code changes, the HRV dataset we can't add to teh non-HRV dataArray because of the different resolutions. And to cover the same area, the HRV cutout has to be 3x the size of the non-HRV image. Other than that, they would be the same, but the different size/shape of an HRV example vs non-HRV example suggests to me it might make sense to keep them as separate entries?

Yeah, I'd go with whatever is simplest to implement :)

Cool, I'll do the HRV channel as a separate data source then!

Sounds good
Although, that said, I do agree with @peterdudfield that it feels kinda weird having two SatelliteDataSources... :slightly_smiling_face:   but let's give it a go and see how it feels!


Support new python versions and upgrade pytest to 7.4.3

Please check if the PR fulfills these requirements

[X] Tests for the changes have been added

[X] Docs have been added / updated

[ ] All CI checks are green

What kind of change does this PR introduce?
Adds support for new Python versions

What is the current behavior?
Tests run only up to Python 3.9

What is the new behavior (if this is a feature change)?

Tests run up to Python 3.11
Upgrades pytest from 6.2.2 to 7.4.3 (this was necessary to prevent TypeError: required field "lineno" missing from alias errors that I was experiencing when testing with Python 3.10).

Does this PR introduce a breaking change?
No.

Other information:

We added support for Python 3.10 and removed support for 3.7 in https://github.com/Yelp/detect-secrets/pull/724. We won't be supporting Python 3.11 yet as it's still in a bugfixes status.

@lorenzodb1 You might be misinterpreting the meaning of bugfix status for Python releases. That designation is for stable, maintenance releases. It would be appropriate for detect-secrets to support those releases. 3.11 was released over a year ago.

@gpflaum good call, I'll look into it

@gpflaum https://github.com/Yelp/detect-secrets/pull/730


Use git rev-list with --count option to work around obscure Groovy bug

I was setting up an environment to build some parts of the GoCD codebase. For a while I was stuck on running any Gradle commands (e.g. just gradlew clean). For a while I was scratching my head, but finally tracked it down to an obscure Groovy bug. Process.text (also known as getText()) can deadlock on commands with long output and only on certain systems. Using --count to shorten the output of git rev-list HEAD is working on my machine.
(https://issues.apache.org/jira/browse/GROOVY-2305 describes the issue and claims it's fixed. 😕 )
This environment happens to be a Windows machine (😬) which could explain why I was lucky enough to hit this issue!

Thanks! While I'm a bit skeptical it's due to that specific ancient issue even, this is certainly a better approach regardless.
Funnily enough, GoCD itelf uses the equivalent of exec('git log --pretty=format:').text.size() which comes up with a similar number off by 1, but does have a lot smaller output due to omitting all the actual revision hashes or log entries etc
https://github.com/gocd/gocd/blob/7e9e0a026668b5aac569efc01ad536fdee78905d/build.gradle#L56-L62


Config data of the disabled module

Hello,
I have a plugins page where I list all modules. I keep data such as module name, description, author and version in config.php.
If the module is disabled, I cannot access the config data. I want to keep the information about the module in the json or config.php file. How can I access this in the most practical way.
Thank you for your suggestions
Sample configuration file:
<?php
return [
    'name'        => 'GoogleAnalytics',
    'description' => 'Google Analistik ile web sitenizdeki trafiği anlık olarak takip edin.',
    'author'      => 'Safa K.',
    'doc_url'     => null,
    'version'     => "1.2",

];

You can modify file module.json in per module,
$module = Module::find('GoogleAnalytics');
$moduleInfo = $module->get();

echo $moduleInfo->doc_url

Thank you so much. The result I needed was with this method. :)


[Question] Discord link

Hi there,
That's a great tool you have here and one I was looking for for some time now, would have probably started one myself if I didn't find it.
I wanted to join the Discord to ask a few questions in order to add some contributions, but the link in the README is expired.
Any chance you guys can provide a new one ?
Thanks !

Hey you can use the following link: https://discord.gg/WeZRdhtuf6
I also updated the readme. Thanks for pointing that out.


Relationship hash to IP Error (string indices must be integers, not str)

When trying to build a relationship between an IP address and a hash I receive
"string indices must be integers, not str"

It seems the relationship is still built

@eopdyke does this occur when building the relationship for IP to Hash? How about Hash to IP?

@alxhrck Hash to IP presents the following error:
'Query' object has no attribute 'type"
However the relationship is created and can be seen in the downloaded indicators.

Pull request #105 should fix that issue.

I found the "string indices must be integers, not str" error here as well:

Viewing Victim info: /victims/[indicator]/info (though this may be due to "Victim" not really having an Object Type when you create an indicator)

@CyberIntelJunkie I'm not able to reproduce this. Do you have any integrations enabled?

@alxhrck only integrations I have active are VT, WHOIS and ThreatCrowd. Here's how I was able to recreate the error:
New Object -> Fill out information:

Browse to Victim -> Select Victim (In this case http://<IP_ADDRESS>:5000/victims/ABC%20Corp/info) -> Error Message.
Not sure what's causing the error. Maybe it's due to selecting "Entity" during the victim creation?


parse images on each layer individually for native parser, add toggleLayer()

===:clipboard: PR Checklist :clipboard:===

[x] :pushpin: issue exists in github for these changes
[ ] :microscope: existing tests still pass
[x] :see_no_evil: code conforms to the style guide
[ ] :triangular_ruler: new tests written and passing / old tests updated with new scenario(s)
[ ] :page_facing_up: changelog entry added (or not needed)

==================

This is a very rough initial implementation to toggle layers during runtime (only for native parser, not sure yet how it would be done for JSON). Personally I only need it for the native parser.
Notable changes are each frame on each layer is parsed on their own canvas ctx in order to be drawn individually.
Linked cells need to be tested, not sure if I broke those. The integration test failed for me with minor(?) pixel diffs, so may just be from running on a macbook.

Closes #242
Changes:

@mattjennings This is an awesome idea! 🎉 100% down

I'll run the pixel tests locally to see if I get the same diff

@mattjennings I checked this locally, AFAIK it looks like a platform rendering difference. I went ahead and switched the image diff to playwright on main too.

This is a very rough initial implementation to toggle layers during runtime (only for native parser, not sure yet how it would be done for JSON). Personally I only need it for the native parser.

I'm okay with this, I don't think anything can be done with the JSON since the export is already flattened. Perhaps a warning here and a no-op?

Sorry for spamming your inbox lol, I see you have an error on JSON type, that's probably okay...

I'm poking around and I think linked cells were just broken in main prior to your change :O

@eonarheim I was working on resolving the conflicts with latest main but realized my changes actually breakingly change spritesheets, as it parses each layer+frame as an individual sprite. So .getSprite(x,y) will never return a full layer's worth of sprites.
I'm not really sure what the best solution is here. For fun, I tried making a GraphicGroup and using that as the sprite in the Spritesheet() constructor and it seemed to work but I imagine that'll cause other issues.
I wonder if we might need a concept of layering within a Spritesheet.

@eonarheim I was working on resolving the conflicts with latest main but realized my changes actually breakingly change spritesheets, as it parses each layer+frame as an individual sprite. So .getSprite(x,y) will never return a full layer's worth of sprites.
I'm not really sure what the best solution is here. For fun, I tried making a GraphicGroup and using that as the sprite in the Spritesheet() constructor and it seemed to work but I imagine that'll cause other issues.
I wonder if we might need a concept of layering within a Spritesheet.

I was noodling on this, I wonder if we flatten all the layers into 1 image for the purpose of SpriteSheet? Although that does thwart your desire to toggle layers.
Layering a sprite sheet could be interesting... I'll noodle. We could at minimum make a SpriteSheet per layer?

 The layering is really just done by spitting out a GraphicGroup as the exFrame for the animation.
1 Spritesheet per layer might make sense... then .getSprite() would take an optional layer name. But some people may not want this, so maybe you could opt-in to layering as a resource option? I feel like it's getting pretty icky any way we cut it though.


Polished Blackstone items appear only as "Polished" on signs

Block's name is too long. Will have to hardcore work around. Not a super big deal because you can just look at the full name in the scoreboard.

This is somewhat fixed. Closing for now, but will likely need to improve upon later.


A new configmap to set environmental variables in CSI driver pods

Requirements:

An user is expected to create this configmap with name ibm-spectrum-scale-csi-config manually
driver pods should be restarted whenever there is a change in the configmap data (create/update/delete)
the configmap can have multiple key value pairs in the data field specified by users. A sample key value pair: VAR_DRIVER_ENV_NAME="VALUE".
while setting the environment variables in driver pods, operator should remove the prefix "VAR_DRIVER" and set environmental variables as ENV_NAME="VALUE"

@amdabhad Is this configMap  optional for users to create? or it is a mandatory, if mandatory will add a check for it in controller else proceed.

This is an optional configmap, if present process it otherwise go ahead with other steps. The driver pods should also restart (and also reflect the environmental variables) when they are already running and the configmap is created later.


feat: remove sudo

Sudo pallet was removed from basilisk runtime.

we should shift some configuration tasks to the technical comitee majority

Which one? Most of the pallets are already configured ...TechCommitteeOrRoot.

we should shift some configuration tasks to the technical comitee majority

Which one? Most of the pallets are already configured ...TechCommitteeOrRoot.

ok, i'll review


Allow overriding data installation prefix

Allow changing the default installation directory where containerlab expects to find templates, using $CLAB_PREFIX.
Alternatively there could be a $CLAB_TEMPLATES_DIR or similar.

Hi @remram44
I wonder, what use case do you have that warrants this customization? Out of these three artifacts (cfg templates, json template path, graph source templates) which ones do you care about being at a custom path and why?

The graph templates (+static).
Having a single installation path makes it difficult to use different versions of containerlab or to run on shared machines.
The current location also doesn't match the filesystem hierarchy standard, it should be in /usr/share or /usr/local/share.
Another option would be to use the embed package so you don't have to distribute other files with the containerlab binary at all.

I think it makes sense for the static artifacts used for graphing to enjoy the embed package.
Today, for the dev purposes, or multi-user purposes where users might want to leverage different export templates, the --template flag can be used https://containerlab.dev/cmd/graph/#render-graph-using-a-custom-html-template

superseded by #2169


[Bug]: units not showing when using templates

Contact Details
No response
What happened?

start table based on template, with unit building blocks
fill cells -> no unit encoded

What did you expect?
No response
Host
Applies to All
Host Details
any
Swate version
Swate Release Version v1.0.0-beta.12 Host Browser

@HLWeil

Can you give an example template we can look at?

The sugar templates, Lukas added yesterday. RPTU PP

In general it would be nice if the values would be included. E.g. the "Plant Growth Conditions" template. Here the "Protocol Type" is already preset to "Plant Growth Protocol", but this does not make its way into the annotation table.


Dev docker

@knopki please, see our chat 🙌

Removing the METIS_RUNTIME_CONFIG part looks like regression for me. With this PR it's useless for dev server - use can set configuration options from environment variables or .env file. But this settings override is build-only.
METIS_RUNTIME_CONFIG allows you to do a runtime configuration of a production build. Thus, if you have a docker image or just index.html hosted on any server, you can change e.g. the api url without rebuilding.

Also, README.md should be updated.

METIS_RUNTIME_CONFIG allows you to do a runtime configuration of a production build. Thus, if you have a docker image or just index.html hosted on any server, you can change e.g. the api url without rebuilding.

@knopki
I understand you concern, but how often do you change environment variables on the production server?
If we inject env vars via METIS_RUNTIME_CONFIG, we are lose a validation process for env vars.

@pyoner

@knopki I understand you concern, but how often do you change environment variables on the production server?

I can't say for this project - I'm not owner of this project nor member of ops team. But in my experience in other projects - it is required very often and always pain-in-the-ass for (dev)ops. Cases:

A/B testing (ok it's rarely API/auth only)
same build for integration testing -> staging -> production environments (different urls)
classic "debug in production"
temporary deploys for every PR on services like Cloud Run where you don't know urls before deploy

However, none of this is relevant to this project 🤣
In any case, this is just my opinion. I wanted to explain the motivation for adding this feature. That's why it's a comment, not a "request for changes".

If we inject env vars via METIS_RUNTIME_CONFIG, we are lose a validation process for env vars.

Yep, that's bad.

@blokhin @knopki
this PR is not complete
I don't like injecting of the config file to the index.html file
I have an idea about env on runtime.
What if pass a .env file to the docker container, in the browser fetch this file, parse, validate and merge with compile-time env file
Or pass through the docker-compose.yaml file:
environment:
 - METIS_<ENV_NAME>

And the docker endpoint script extract all envs that start with prefix METIS_ and puts them in the .env file

@pyoner Second variant is nice. But maybe just dump to a json file, so you can skip parsing?

@pyoner But why? Library is not isomorphic (but may work, not sure), but parsing is trivial. The method simply builds a javascript object. If config is already in JavaScriptObjectNotation, then ...

@pyoner But why? Library is not isomorphic (but may work, not sure), but parsing is trivial. The method simply builds a javascript object. If config is already in JavaScriptObjectNotation, then ...

@knopki I think the library will work in the browser
Because process.env is a Record<string, string | undefined> and znv parseEnv function accepts envs in that format

@pyoner let's revive this PR. Do you use this new functionality? Does it work flawlessly for you?

@blokhin it works for me, but it is not completed, see https://github.com/basf/metis-gui/pull/120#issuecomment-1413592881

Closing, but not deleting. Hope to return to this at some point later.


Optimize Task.gather

The Task.gather implementation admits a more optimal version.

+1,especially when the size is 1 or 2.

Thanks for the suggestion @hepin1989, will do.

Already on master.


MB-1804 Containers

Description
In this branch, we create classes for the different kinds of containers in our design system and provide them with styling. Includes the following:

Container Default
Container Gray
Container Popout
Container Accent

Reviewer Notes
The spec didn't include margin or padding values. I've set them both to the USWDS token of 1 (24px) for the moment. Let me know if we want to change that.
Setup
The usual
yarn storybook

or
make storybook_docker

if that branch has been pushed to master
Code Review Verification Steps

[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

JIRA story
Abstract Sticker Sheet

Screenshots

The job that will check for this isn't required quite yet, but you will need to update the loki tests for these changes. Let me know if you need help. The docs in https://github.com/transcom/mymove/blob/master/docs/how-to/run-loki-tests-against-storybook.md should help.

Container default is not currently displaying a border; instead it should have a 1px border of $base-lighter

Container popout is displaying a 2px border ; instead it should be a 1px border of $base-light


Expand the widget definition

Expand the widget definition with attributes axRole and axPatterns to support page visualization of the laxar-developer-tools-widget.

Implemented on master (v2.3.0).


New version: AMDGPUnative v0.3.2

Registering package: AMDGPUnative
Repository: https://github.com/JuliaGPU/AMDGPUnative.jl
Created by: @jpsamaroo
Version: v0.3.2
Commit: aa57241388f57bce235ac7e008ae83b0b532513d
Reviewed by: @jpsamaroo
Reference: https://github.com/JuliaGPU/AMDGPUnative.jl/commit/aa57241388f57bce235ac7e008ae83b0b532513d#commitcomment-39556593

@jpsamaroo is it expected that this package can't be loaded?

Without Pkg.instantiate, yes, sometimes the package won't be correctly loaded because it's often depending on a specific branch of GPUCompiler.jl.

Shall we merge this anyway?  But it'd probably be better to avoid requiring Pkg.instantiate in the future :wink:

If you could this time, that would be great :)
I'm still figuring out how to best work with this new shared compiler model that JuliaGPU is using. Is it possible to make feature additions to an upstream package, depend on those feature additions in a downstream package without bumping the upstream version (since I'd very quickly end up with GPUCompiler v0.158.0), and still keep automerge happy?


Edited family home component to properly display sidebar, footer, and banner.

… banner
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Loom Video
Please paste a link here of a quick loom video walking through what you did in your PR .
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have removed unnecessary comments/console logs from my code
[ ] I have made corresponding changes to the documentation if necessary (optional)
[ ] My changes generate no new warnings
[ ] I have checked my code and corrected any misspellings
[ ] No duplicate code left within changed files
[ ] Size of pull request kept to a minimum
[ ] Pull request description clearly describes changes made & motivations for said changes

Co-authored-by: Uros Ivanovic<EMAIL_ADDRESS>

This is all good and ready, awesome changes that needed, I think the only thing you're missing is a video describing it all, other than that awesome work

Yes, that's been added now! Thanks!

Great job cleaning up unnecessary code to keep it clean. Loved that you kept the solution simple and had descriptive commits.


Is this project dead?

Hi Correl,
thanks for the nice work. I was wondering if this project is dead?
Denis

Sorry for the late response.
It essentially is, yes. My use of Kodi has declined over the years, so I no longer even use this as a quick way to peek in on my download statuses. Given the state of torrent indexers these days, the idea of maintaining a search and add feature is even less attractive than it once was.
I'm glad so many people found it useful. I fully support someone taking it over if they'd like. It was a fun project :)


null' is not a subtype of type 'string' in Post MultiPart

Hello, i want to set some fields dynamic, but i got error like this 'null is not subtype of type 'string''. How can i fix it?
Is it possible to send null data together File?

I have the same issue too and can't resolve it

Please add ? after the type like which you put after the File

If you want to send null to any field, just use "".
"username": null -> "username": "". It is working for me.
@Part(name: "username") String userName


Update messages.properties

Instances ca be scaled up or down, no only up.

"Instance Scaled" doesn't seem like a very descriptive message. SHouldn't we expand a little, like "instances scaled to requested size(s)"?

Daan,
Sure, that works for me. Or "Instance scaled to the requested offering."


Excel Model Documentation Template shows incomplete list of measure

The list of measures presented in the Excel Model Documentation Template shows an incomplete list. This only happens in case when a measure table is used.
Issue only occurs with the Excel template. The Power BI template still shows a full list of measures.

Model Documenter v2.0.0 has just been released. Please check this page to get the latest version. As of Model Documenter v2.0.0, the Excel format has been discontinued. I encourage you to start using the Power BI template format.
Also see pull request #21


[Improvement] Improve the readability of ServiceControl list/get operations

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
When the get server and list server commands are displayed, when the namespace exceeds the minimum width, it will be glued to the hostname.
kyuubi/bin/kyuubi-ctl get  server
kyuubi/bin/kyuubi-ctl list server

How should we improve?
Add a space beyond the minimum cell width in non-verbose mode.
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Related issue #1595