Destruction of worker ASG blocked by protect_from_scale_in = true

I have issues
Unable to destroy a worker ASG or the cluster because of  protect_from_scale_in = true. This of course can be changed but that is generally undesirable because one expects that if you can create it you can also destroy it without changing the configuration. :)
I'm willing to assist with work on this but figured I'd open a ticket in case someone had thoughts on how to resolve this without making a PR and without changing protect_from_scale_in to false when we want to destroy or recreate a worker ASG.
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Unable to destroy a worker ASG due to:

Error: Error draining autoscaling group: Group still has 1 instances

AWS console shows on the ASG activity history:

Could not scale to desired capacity because all remaining instances are protected from scale-in.

If this is a bug, how to reproduce? Please include a code sample if relevant.
Set protect_from_scale_in to true on this repo, create a cluster, then try to destroy it with terraform destroy.
What's the expected behavior?
Destruction without code change or updating protect_from_scale_in.
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version: commit 49b0667cd91e15f7c98dba67ad7e5aa5a6f54b5d
OS: linux
Terraform version: 0.12.24

Any other relevant info
None that I can think of at this time.

It defaults to false so I don't get the problem? If you want to destroy without issues then don't set it to true?

Thank you for considering this with me. My intent in opening this issue is not to attack but to discuss.
I suppose I missed where this behavior is documented in the module for this feature. Where may I find that? When digging into this it seems this variable is directly passed to the provider so perhaps that is where I missed the importance of checking the provider's documentation on the variables in workers_group_defaults and workers_group_defaults_defaults. Perhaps it is profitable for that connection to be noted in the README, FAQ, or comments of local.tf.
If the problem is that I opened a ticket after changing defaults then why was #812 not treated the same way?
Contributing guidelines are where? I'd rather not create problems but contribute to solutions. The readme says "Full contributing guidelines are covered here." which links to https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/CONTRIBUTING.md which is a 404 in my experience and I don't see a 'CONTRIBUTING.md' in /.

#812 was a bug in the module caused by a lack of dependency ordering. It was a simple fix.
This issue is about an AWS feature and emergent behaviour of the terraform AWS provider, not something the module can fix.
This issue has come up at least a couple times before:

#176
#288

There is an open issue against the provider: https://github.com/terraform-providers/terraform-provider-aws/issues/5278

Awesome! Closing this cause it's pointless to have a duplicate issue.
Thank you, I completely forgot to search existing issues (closed and open).

Thank you for considering this with me. My intent in opening this issue is not to attack but to discuss.

We are all here to discuss, don't worry 💛

There is an open issue against the provider: terraform-providers/terraform-provider-aws#5278

This I was not aware of. Interesting. Thanks @dpiddockcmp


Popup window not closed on reject

So not sure if this is a bug or if there is just a better way of doing what I want to achieve.
If the call to my backend which creates the payment object fails for any reason I want to show an error and cancel the payment flow, currently i'm just doing this.
paypal.request.post(CREATE_PAYMENT_URL, postData)
.then(function(data) {
if (PaymentHandler.validPayment(data)) {
resolve(data.id);
} else {
throw new Error("Payment Creation Failed");
}
}).catch(function(err) {
reject(err);
});
This works fine when logged in and using the iframe, but when using the popup window the overlay closes but the window with the spinner does not and the PayPal button is removed from from my page so the user can't try again.
Any help would be appreciated.

I'm seeing the same problem. Hoping to get a fix out today. Thanks for letting me know!

This should be resolved now. Please clear your browser cache and try once more -- and let me know if you see any further issues.


(PUP-4567) Add future parser in Rakefile

Add the future parser requirement to the Rakefile, so it doesn't have to
be specified on every specs run. This simplifies maintenance of the
Jenkins pipeline used to run specs.

+1, Tested locally and looks good!

ping @justinstoller


64 bit Raspberry Pi 5

$ sudo raspdif
W: MAIN: 64 bit support is experimental. Please report any issues.
F: Memory: Failed to map physical address 0x10 of length<PHONE_NUMBER>. Error: Invalid argument
$ uname -a
Linux raspberrypi 6.6.31+rpt-rpi-2712 #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/Linux
$ cat /etc/debian_version
12.6
Just compiled with make and no issue but it doesn't run. Any ideas?

The Pi 5 SoC has a completely different architecture than previous generations.
Currently it's incompatible with raspdif and I have not looked into that it would take to add support.

Would it work if I switched to 32 bit OS or still no?

No. This is a hardware compatibility problem, not an OS problem.


Error forcing players to spawn on login

[SEVERE] Could not pass event PLAYER_JOIN to Multiverse-Core
java.lang.NoSuchMethodError: org.bukkit.entity.Player.hasPlayedBefore()Z
at com.onarandombox.MultiverseCore.listeners.MVPlayerListener.onPlayerJoin(MVPlayerListener.java:114)
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:265)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:339)
at net.minecraft.server.ServerConfigurationManager.c(ServerConfigurationManager.java:129)
at net.minecraft.server.NetLoginHandler.b(NetLoginHandler.java:113)
at net.minecraft.server.NetLoginHandler.a(NetLoginHandler.java:39)
at net.minecraft.server.NetworkListenThread.a(SourceFile:94)
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:527)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)
I get the above error when a player logs in, they are then moved to spawn while briefly seeing their previous location. Happens every player, every login. Using the latest dev build of Multiverse-core as of right now.

And CB1597

No. Your CraftBukkit has to be outdated. Update it and this will be fixed.

It's definitely 1597..

Ok sorry you were right, I hadn't updated my test servers CB. But our live server is 1597 and that is where the problem was occurring. Disregarding the error message because there is none now that i updated to 1597 we still have the problem of players being moved to spawn everytime they login. The problem goes away if I downgrade back to the last AB of Multiverse core and comes back whenever i update to the dev build.

Well, I think that the error message is related to your problem. It tells me that a method wasn't found. But that method exists in CB since build 1597, so I can be sure that you are using an older build.

But the problem has originally occurred on our live server which is running 1597. We never had the console error on there and when it appeared on the test server i assumed it was because of the particular console our host uses not showing all of the server log.

Now I understand what you mean.
But I still need the information listed here.

Ok no problem. Sorry completely missed that.
Problem: Whenever players login they are moved from their last saved position to spawn.
Link http://pastie.org/private/pig3wa70fy9fpfqduo7l5q
Startup Log

2012-01-07 00:21:29 [INFO] Starting minecraft server version 1.0.1
2012-01-07 00:21:29 [INFO] Loading properties
2012-01-07 00:21:29 [INFO] Starting Minecraft server on <IP_ADDRESS>:25565
2012-01-07 00:21:29 [INFO] This server is running Craftbukkit version git-Bukkit-1.0.1-R1-b1597jnks (MC: 1.0.1) (Implementing API version 1.0.1-R1)
2012-01-07 00:21:30 [INFO] Starting Minequery server on <IP_ADDRESS>:25566
2012-01-07 00:21:31 [INFO] [PermissionsEx] sql backend registered!
2012-01-07 00:21:31 [INFO] [PermissionsEx] file backend registered!
2012-01-07 00:21:31 [INFO] [PermissionsEx] PermissionEx plugin initialized.
2012-01-07 00:21:31 [INFO] [PermissionsEx] p2compat backend registered!
2012-01-07 00:21:31 [INFO] [PermissionsCompat] Compatibility Layer Initalized!
2012-01-07 00:21:32 [INFO] MCBans: Starting..
2012-01-07 00:21:34 [INFO] [PermissionsEx] Initializing file backend
2012-01-07 00:21:35 [INFO] [Spout] Spout 644 has been initialized
2012-01-07 00:21:35 [INFO] [Vault][Economy] Essentials Economy found: Waiting
2012-01-07 00:21:35 [INFO] [Vault][Economy] iConomy 5 found: Waiting
2012-01-07 00:21:35 [INFO] [Vault][Permission] PermissionsEx found: Waiting
2012-01-07 00:21:35 [INFO] [Vault][Permission] SuperPermissions loaded as backup permission system.
2012-01-07 00:21:35 [INFO] [Vault][Chat] PermissionsEx found: Waiting
2012-01-07 00:21:35 [INFO] [Vault] Enabled Version 1.2.3-b000
2012-01-07 00:21:35 [INFO] Preparing level "huxston"
2012-01-07 00:21:35 [INFO] Default game type: 0
2012-01-07 00:21:35 [INFO] Preparing start region for level 0 (Seed: -1299360788)
2012-01-07 00:21:36 [INFO] Preparing spawn area: 44%
2012-01-07 00:21:37 [INFO] Preparing start region for level 1 (Seed: -6377406213107229101)
2012-01-07 00:21:37 [INFO] Preparing spawn area: 20%
2012-01-07 00:21:38 [INFO] [ FalseBook Core ] using PermissionsEx for Permissions!
2012-01-07 00:21:38 [INFO] [ FalseBook Core ] FalseBookCore v0.91alpha by GeMo enabled!
2012-01-07 00:21:38 [INFO] SimpleAnnounce version 0.5.2 enabled!
2012-01-07 00:21:39 [INFO] [iConomy] Logging is currently disabled.
2012-01-07 00:21:40 [INFO] [iConomy] v5.01 (Eruanna) loaded.
2012-01-07 00:21:40 [INFO] [iConomy] Developed by: [Nijikokun]
2012-01-07 00:21:40 [INFO] [Vault][Economy] iConomy 5 hooked.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston) Single session is enforced.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston) TNT ignition is blocked.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston) Lighters are PERMITTED.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston) Lava fire is blocked.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston) All fire spread is disabled.
2012-01-07 00:21:40 [INFO] WorldGuard: Loaded configuration for world 'huxston"
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston_the_end) Single session is enforced.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston_the_end) TNT ignition is blocked.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston_the_end) Lighters are PERMITTED.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston_the_end) Lava fire is blocked.
2012-01-07 00:21:40 [INFO] WorldGuard: (huxston_the_end) All fire spread is disabled.
2012-01-07 00:21:40 [INFO] WorldGuard: Loaded configuration for world 'huxston_the_end"
2012-01-07 00:21:40 [INFO] WorldGuard: 76 regions loaded for 'huxston'
2012-01-07 00:21:40 [INFO] WorldGuard: 2 regions loaded for 'huxston_the_end'
2012-01-07 00:21:40 [INFO] WEPIF: Updated config file
2012-01-07 00:21:40 [INFO] WEPIF: Using the Bukkit Permissions API.
2012-01-07 00:21:40 [INFO] WorldGuard: Unable to register missing event type SNOW_FORM
2012-01-07 00:21:40 [INFO] WorldGuard 5.2.2 enabled.
2012-01-07 00:21:41 [INFO] Loaded Essentials build 2.7.2 by: Zenexer, ementalo, Aelux, Brettflan, KimKandor, snowleo, ceulemans, Xeology, KHobbits
2012-01-07 00:21:41 [INFO] Essentials: Using config based permissions. Enable superperms in config.
2012-01-07 00:21:41 [INFO] [Essentials] Payment method found (iConomy version: 5)
2012-01-07 00:21:41 [INFO] [Vault][Economy] Essentials Economy hooked.
2012-01-07 00:21:41 [INFO] [RebuildPlugin] RebuildPlugin activ√©.
2012-01-07 00:21:42 [INFO] []
2012-01-07 00:21:42 [INFO] [RebuildPlugin] Loaded data.
2012-01-07 00:21:42 [INFO] Turnstile 2.1.0 is enabled!
2012-01-07 00:21:42 [INFO] [Turnstile] Successfully linked with iConomy 5!
2012-01-07 00:21:42 [INFO] MushroomJump is enabled!
2012-01-07 00:21:42 [INFO] PluginSpy version 1.1 is now running.
2012-01-07 00:21:42 [INFO] Gamemode Changer 1.1: Enabled.
2012-01-07 00:21:42 [INFO] [HeroChat] HeroChat version 4.10.3 enabled.
2012-01-07 00:21:42 [INFO] [Runecraft] Rune blacklist with 1 runes loaded.
2012-01-07 00:21:42 [INFO] [Runecraft] Loaded:
2012-01-07 00:21:42 [INFO] [Runecraft]  - 54 waypoints, 116 teleporters
2012-01-07 00:21:42 [INFO] [Runecraft]  - 0 position runes
2012-01-07 00:21:42 [INFO] [Runecraft]  - 0 rune pads
2012-01-07 00:21:42 [INFO] [Runecraft]  - 0 logic pads
2012-01-07 00:21:42 [INFO] [Runecraft]  - 2 player data sets
2012-01-07 00:21:42 [INFO] [Runecraft]  - 41 block runes
2012-01-07 00:21:42 [INFO] [Runecraft] World 'huxston': id 4
2012-01-07 00:21:42 [INFO] [Runecraft] Runecraft 2.10.1 initialized.
2012-01-07 00:21:42 [INFO] [Runecraft] World 'huxston_the_end': id 0
2012-01-07 00:21:42 [INFO] Runecraft plugin version 0.81 is enabled!
2012-01-07 00:21:42 [INFO] [mcMMO] PermissionsEx found, using PermissionsEx.
2012-01-07 00:21:42 [INFO] Loading Config File...
2012-01-07 00:21:46 [INFO] mcMMO version 1.2.07 is enabled!
2012-01-07 00:21:46 [INFO] [ FalseBook Block ] 3100 Books loaded!
2012-01-07 00:21:46 [INFO] [ FalseBook Block ] 2 Cauldrons successfully loaded.
2012-01-07 00:21:46 [INFO] [ FalseBook Block ] FalseBookBlock v0.91alpha by GeMo enabled
2012-01-07 00:21:46 [INFO] NSCommand 0.2 enabled.
2012-01-07 00:21:46 [INFO] Lockette version 1.4.4 is being enabled!  Yay!  (Core version 1.2.3)
2012-01-07 00:21:46 [INFO] Lockette: Detected craftbukkit build [1597] ok.
2012-01-07 00:21:46 [INFO] [PermissionsCompat] Compatibility layer enabled.
2012-01-07 00:21:46 [INFO] Essentials: Using Permissions 2 based permissions.
2012-01-07 00:21:46 [INFO] WEPIF: Using the Bukkit Permissions API.
2012-01-07 00:21:46 [INFO] [HeroChat] Permissions 2.7.7 found.
2012-01-07 00:21:46 [INFO] [iConomy] hooked into Permissions.
2012-01-07 00:21:46 [INFO] Lockette: Linked to Permissions plugin version 2.7.7
2012-01-07 00:21:46 [INFO] Lockette: Linked to Towny plugin version <IP_ADDRESS>
2012-01-07 00:21:46 [INFO] Lockette: Ready to protect your containers.
2012-01-07 00:21:46 [INFO] WorldEdit 5.0 enabled.
2012-01-07 00:21:46 [INFO] WEPIF: Using the Bukkit Permissions API.
2012-01-07 00:21:47 [INFO] [ConsoleName] Plugin enabled.
2012-01-07 00:21:47 [INFO] JukeboxControl has been enabled.
2012-01-07 00:21:47 [INFO] [PermissionsEx] Superperms support enabled.
2012-01-07 00:21:47 [INFO] [PermissionsEx] v1.17 enabled
2012-01-07 00:21:47 [INFO] Essentials: Using PermissionsEx based permissions.
2012-01-07 00:21:47 [INFO] WEPIF: PermissionsEx detected! Using PermissionsEx for permissions.
2012-01-07 00:21:47 [INFO] [Vault][Permission] PermissionsEx hooked.
2012-01-07 00:21:47 [INFO] [Vault][Permission] PermissionsEx_Chat hooked.
2012-01-07 00:21:47 [INFO] [Turnstile] Successfully linked with PermissionsEx!
2012-01-07 00:21:47 [INFO] DeathCube v0.60 enabled!
2012-01-07 00:21:47 [INFO] [Questioner] v0.4 - Enabled
2012-01-07 00:21:47 [INFO] [Multiverse-Core] - Version 2.2-b423 (API v10) Enabled - By Rigby, fernferret, lithium3141 and main--
2012-01-07 00:21:47 [INFO] [AllPay] - Version 3.0 - hooked into iConomy 5 for Multiverse-Core v2.2-b423
2012-01-07 00:21:47 [INFO] [Multiverse-Core] Loading World & Settings - 'huxston_the_end' - THE_END with seed: -6377406213107229101
2012-01-07 00:21:48 [INFO] [Multiverse-Core] Loading World & Settings - 'huxston' - NORMAL with seed: -1299360788
2012-01-07 00:21:49 [INFO] [Multiverse-Core] Loading World & Settings - 'nether' - NETHER with seed:<PHONE_NUMBER>938192975
2012-01-07 00:21:49 [INFO] Preparing start region for level 2 (Seed:<PHONE_NUMBER>938192975)
2012-01-07 00:21:50 [INFO] Preparing spawn area for nether, 65%
2012-01-07 00:21:50 [INFO] [Runecraft] World 'nether': id 3
2012-01-07 00:21:50 [INFO] [Multiverse-Core] Loading World & Settings - 'Carnival' - NORMAL with seed:<PHONE_NUMBER>185211589
2012-01-07 00:21:50 [INFO] Preparing start region for level 3 (Seed:<PHONE_NUMBER>185211589)
2012-01-07 00:21:51 [INFO] Preparing spawn area for Carnival, 69%
2012-01-07 00:21:51 [INFO] [Runecraft] World 'Carnival': id 1
2012-01-07 00:21:51 [INFO] WorldGuard: (Carnival) Single session is enforced.
2012-01-07 00:21:51 [INFO] WorldGuard: (Carnival) TNT ignition is blocked.
2012-01-07 00:21:51 [INFO] WorldGuard: (Carnival) Lighters are PERMITTED.
2012-01-07 00:21:51 [INFO] WorldGuard: (Carnival) Lava fire is blocked.
2012-01-07 00:21:51 [INFO] WorldGuard: (Carnival) All fire spread is disabled.
2012-01-07 00:21:51 [INFO] WorldGuard: Loaded configuration for world 'Carnival"
2012-01-07 00:21:52 [INFO] [Multiverse-Core] Loading World & Settings - 'huxston_the_end' - THE_END with seed: -6377406213107229101
2012-01-07 00:21:52 [INFO] [Multiverse-Core] 4 - World(s) loaded.
2012-01-07 00:21:52 [INFO] Ender Pearl TP blocking enabled.
2012-01-07 00:21:52 [INFO] [Modifyworld] Modifyworld enabled!
2012-01-07 00:21:52 [INFO] MCBans: Core loaded successfully!
2012-01-07 00:21:52 [INFO] MCBans: Loading language file: en-us
2012-01-07 00:21:52 [INFO] MCBans: Log file disabled!
2012-01-07 00:21:52 [INFO] MCBans: Permissions plugin found!
2012-01-07 00:21:52 [INFO] MCBans: Fetching backup.
2012-01-07 00:21:52 [INFO] MCBans: Starting MCBans online check.
2012-01-07 00:21:52 [INFO] MCBans: Connection throttling operating normally!
2012-01-07 00:21:52 [INFO] MCBans: Task ID: 18
2012-01-07 00:21:52 [INFO] MCBans: Throttle Connect Limit: 2
2012-01-07 00:21:52 [INFO] MCBans: Started and operating normally!
2012-01-07 00:21:52 [INFO] [Multiverse-Portals] - Version 2.2-b427 Enabled - By Rigby and fernferret
2012-01-07 00:21:54 [INFO] [Multiverse-Portals]  27 - Portals(s) loaded
2012-01-07 00:21:55 [INFO] [ FalseBook IC ] FalseBookIC v0.91alpha by GeMo enabled
2012-01-07 00:21:55 [INFO] [VoxelSniper] Config loaded
2012-01-07 00:21:55 [INFO] VoxelSniper version 5.019 is enabled! Snipe away.
2012-01-07 00:21:55 [INFO] FalseBookCart v0.91alpha by GeMo enabled
2012-01-07 00:21:55 [INFO] Loaded EssentialsSpawn build 2.7.2 by: essentials team
2012-01-07 00:21:55 [INFO] ====================      Towny      ========================
2012-01-07 00:21:56 [INFO] [Towny] Database: [Load] flatfile [Save] flatfile
2012-01-07 00:22:06 [INFO] [Towny] Using: PermissionsEX v1.17, iConomy v5.01, Questioner v0.4
2012-01-07 00:22:06 [INFO] [Towny] Time until a New Day: 4 hours, 37 minutes, 53 second
2012-01-07 00:22:06 [INFO] =============================================================
2012-01-07 00:22:06 [INFO] [Towny] Version: <IP_ADDRESS> - Mod Enabled
2012-01-07 00:22:06 [INFO] =============================================================
2012-01-07 00:22:06 [INFO] WorldBorder version 1.5.0 loading
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] Using square border, knockback of 3.0 blocks, and timer delay of 40.
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] Border-checking timed task started.
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] World "huxston" has border radius 6000 at X: -1489.7 Z: 228.6
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] World "Carnival" has border radius 158 at X: 94.4 Z: 248.4
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] World "nether" has border radius 1000 at X: 53.5 Z: 70.5
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] World "world" has border radius 4000 at X: -317.0 Z: -214.0
2012-01-07 00:22:06 [INFO] [WorldBorder] [CONFIG] Will use plugin for permissions: Permissions v2.7.7
2012-01-07 00:22:06 [INFO] For reference, the main world's spawn location is at X: -1490 Y: 80 Z: 227
2012-01-07 00:22:07 [INFO] [Citizens] NPC types loaded: trader, quester, guard, wizard, healer, blacksmith
2012-01-07 00:22:09 [INFO] [Citizens] Permissions system found (PermissionsEx v1.17)
2012-01-07 00:22:09 [INFO] [Citizens] version [devBuild-] loaded.
2012-01-07 00:22:09 [INFO] [Citizens] Economy plugin found (iConomy v5)
2012-01-07 00:22:09 [INFO] [ChestShop] Permissions version 2.7.7 loaded.
2012-01-07 00:22:09 [INFO] [ChestShop] Lockette version 1.4.4 loaded.
2012-01-07 00:22:09 [INFO] [ChestShop] Towny version <IP_ADDRESS> loaded.
2012-01-07 00:22:09 [INFO] [ChestShop] WorldGuard version 5.2.2 loaded.
2012-01-07 00:22:09 [INFO] [ChestShop] version 3.3 initialized!
2012-01-07 00:22:09 [INFO] [ChestShop] iConomy 5 loaded.
2012-01-07 00:22:10 [INFO] [VirtualChest] (version 5.2)
2012-01-07 00:22:10 [INFO] [VirtualChest] Chests loaded !
2012-01-07 00:22:10 [INFO] [VirtualChest] Successfully linked with PermissionsEX
2012-01-07 00:22:10 [INFO] [VirtualChest] Successfully linked with mcMMO.
2012-01-07 00:22:10 [INFO] [VANISH] Version 1.8.8 enabled.
2012-01-07 00:22:10 [INFO] [MobArena] Payment method found (iConomy version: 5)
2012-01-07 00:22:10 [INFO] [MobArena] v<IP_ADDRESS> enabled.
2012-01-07 00:22:10 [INFO] Done (3.540s)! For help, type "help" or "?"
2012-01-07 00:22:10 [INFO] [ FalseBook Block ] 0 Areas loaded.
2012-01-07 00:22:10 [INFO] [ FalseBook Block ] 0 Bridges successfully loaded.
2012-01-07 00:22:10 [INFO] [ FalseBook Block ] 0 Doors successfully loaded.
2012-01-07 00:22:10 [INFO] [ FalseBook Block ] 218 protected gateblocks successfully loaded.
2012-01-07 00:22:13 [INFO] [Citizens] Loaded 71 NPCs.
2012-01-07 00:22:13 [INFO] [Citizens] Loaded 12 quests.
2012-01-07 00:22:14 [INFO] DeathCube is UpToDate
2012-01-07 00:22:16 [INFO] [ FalseBook IC ] Loaded selftriggered ICs: 0 done
2012-01-07 00:22:16 [INFO] [ FalseBook IC ] Failed selftriggered ICs: 0 failed

Please use one of the newest Multiverse-builds located at http://ci.onarandombox.com/ and check if the issue persists.

Hmm ok seems to be fixed using the very latest builds of core and portals. Thankyou very much :D

Read #355 for details about this issue. Closing.


modify systemd filebeat service file

Currently installing filebeat 7.x onto a system with systemd the defaults interfer with filebeat.yml file
[Unit]
Description=Filebeat sends log files to Logstash or directly to Elasticsearch.
Documentation=https://www.elastic.co/products/beats/filebeat
Wants=network-online.target
After=network-online.target

[Service]

Environment="BEAT_LOG_OPTS=-e"
Environment="BEAT_CONFIG_OPTS=-c /etc/filebeat/filebeat.yml"
Environment="BEAT_PATH_OPTS=-path.home /usr/share/filebeat -path.config /etc/filebeat -path.data /var/lib/filebeat -path.logs /var/log/filebeat"
ExecStart=/usr/share/filebeat/bin/filebeat $BEAT_LOG_OPTS $BEAT_CONFIG_OPTS $BEAT_PATH_OPTS
Restart=always

[Install]
WantedBy=multi-user.target

the line
Environment="BEAT_LOG_OPTS=-e"

with -e flag defaults logging to syslog and will ignore any logging configs
example:
logging:
  level: debug
  to_syslog: false
  metrics:
    enabled: false
  to_files: true
  files:
    path: "/var/log/filebeat"
    name: filebeat
    keepfiles: '7'
    permissions: '0644'

so the question.
should this module control the filebeat systemd service file or should this be done externally?

I am currently doing get around the logging opts flag
  file_line { 'disable_filebeat_sys_logging':
    ensure            => absent,
    path              => '/lib/systemd/system/filebeat.service',
    match             => '^Environment="BEAT_LOG_OPTS=',
    match_for_absence => true,
    notify            => Class['filebeat::service'],
  }

its dirty. I think the filebeat systemd service file should be managed via this module, to be honest.

It looks like the beats project is tracking the issue too (elastic/beats#12024). In elastic/beats#12577 they suggest that this is the suggested behavior so they documented it.
Luckily elastic documents a good way to override systemd changes that we'd want to use.
Do you have any suggestions about what kind of customizations should be supported in the module vs. when someone should manage it themselves?

filebeat documentaion mentions a drop in file
running-with-systemd.html#_customize_systemd_unit_for_filebeat
maybe something like this
if $logging !=undef {
  # do systemd customization here
} else {
  # make sure default setting is used here
}

on each filebeat upgrade, the systemd file will be replaced which means we should not edit the systemd service file but
maintain a /etc/systemd/system/filebeat.service.d/logging.conf file
which would have contents
Environment="BEAT_LOG_OPTS="

then add information to the doc's wit the logging to say default on systemd systems is to log into syslog. from version 7.0+
I will test this and let you know if this works.. I can create a PR also if needed

adding the systemd config file /etc/systemd/system/filebeat.service.d/logging.conf
[Service]
Environment="BEAT_LOG_OPTS="

works.  I will see what I can do about a pr

create a pull request #223

I'm closing this since it was fixed in #223


Add BOBA_AVAX_L2 network

I have read the CLA Document and I hereby sign the CLA

recheck

We cannot find the network in https://chainlist.org/


[AMBARI-23195] Missing LdapFacade in ambari-server check-database

What changes were proposed in this pull request?
ambari-server check-database
Using python  /usr/bin/python
Checking database
ERROR: Exiting with exit code 1.
REASON: Database check failed to complete: No errors and warnings were found.
...
Caused by: com.google.inject.CreationException: Unable to create injector, see the following errors:

1) No implementation for org.apache.ambari.server.ldap.service.LdapFacade was bound.
  while locating org.apache.ambari.server.ldap.service.LdapFacade
    for field at org.apache.ambari.server.controller.internal.AmbariServerLDAPConfigurationHandler.ldapFacade(AmbariServerLDAPConfigurationHandler.java:43)
  at org.apache.ambari.server.controller.ControllerModule.bindByAnnotation(ControllerModule.java:568)

1 error
	at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:470)
	at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
	at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
	at com.google.inject.Guice.createInjector(Guice.java:99)
	at com.google.inject.Guice.createInjector(Guice.java:73)
	at com.google.inject.Guice.createInjector(Guice.java:62)
	at org.apache.ambari.server.checks.DatabaseConsistencyChecker.main(DatabaseConsistencyChecker.java:101)

This was caused by a missing LDAP module in the Guice Injector
How was this patch tested?
Manually tested:
[root@c7401 ~]# ambari-server check-database
Using python  /usr/bin/python
Checking database
No errors and warnings were found.
Ambari Server 'check-database' completed successfully.

Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1083/
Test FAILed.
Test FAILured.

The failure in Ambari Agent is unrelated.
[INFO] Ambari Server ...................................... SUCCESS [29:29 min]
[INFO] Ambari Functional Tests ............................ SUCCESS [  0.996 s]
[INFO] Ambari Agent ....................................... FAILURE [01:00 min]

Reported: https://issues.apache.org/jira/browse/AMBARI-23197


Employee Scheduling - Adding a new constraint about employee's minimum working day

Hello!
I am using constraints no_overlapping_shifts, at_least_10_hours_between_two_shifts, one_shift_per_day, tag_constraint_for_employee in your constraint.py file. In addition to these, I wanted to add the max_working _day constraint that the employee should not exceed the maximum number of days a week can work. The code is like this:
def constraint_for_employee_max_working_day_in_week(constraint_factory: ConstraintFactory):
    return constraint_factory \
        .for_each(Shift) \
             .group_by(lambda shift: shift.employee, ConstraintCollectors.count()) \
             .filter(lambda employee ,shift_count : ((shift_count > employee.max_working_day_in_week)))\
             .penalize('Constraint for employee max working day in week', HardSoftScore.ONE_HARD,
             lambda employee, shift_count: shift_count - employee.max_working_day_in_week)

This code is working correctly and I wanted to add min working day constraint too, and updated domain.py , constraint.py according to the function. It didn't work when the two were together. Although it produces results that do not meet the min_working_day constraint, it did not show in the error score. Do you have any idea why it is not working?
Any ideas on how I can add these constraints?
Thank you in advance
def constraint_for_employee_min_working_day_in_week(constraint_factory: ConstraintFactory):
    return constraint_factory \
        .for_each(Shift) \
             .group_by(lambda shift: shift.employee, ConstraintCollectors.count()) \
             .filter(lambda employee ,shift_count : ((shift_count < employee.min_working_day_in_week)))\
             .penalize('Constraint for employee min working day in week', HardSoftScore.ONE_HARD,
             lambda employee, shift_count: employee.min_working_day_in_week - shift_count)

min is an annoying one to implement, because unlike max, you also need to handle the 0 case. However, if an employee have 0 shifts, it will not appear as a group key in the group_by. This means to correctly implement min, you need two separate constraints:

One that handles when the employee has at least one shift (the one you wrote above)
One that handles when the employee has no shifts:

def constraint_for_employee_min_working_day_in_week_no_shifts(constraint_factory: ConstraintFactory):
    return constraint_factory \
        .for_each(Employee) \
             .if_not_exists(Shift, Joiners.equal(lambda employee: employee, lambda shift: shift.employee)) \
             .filter(lambda employee: ((0 < employee.min_working_day_in_week)))\
             .penalize('Constraint for employee min working day in week, no shifts', HardSoftScore.ONE_HARD,
             lambda employee: employee.min_working_day_in_week)

Hello!
Thank you so much for your reply. When I implemented the two functions as you specified, I could not understand the error score of the constraint_for_employee_min_working_day_in_week_no_shifts constraint. Normally I expect non-assignables (0 case ) to produce as errors as min_working_days . But regardless of the number of non-assigned employees, it produces a score like (number of agents * min_working_day of the employee) . For example, when I want to assign 18 agents to 27 shifts, when min_working_day is 1 and max_working_day is 2, if all other constraints are met without error, 4 agents are not assigned and it  generates -18 scores. So I thought constraint_for_employee_min_working_day_in_week constraint also generates error for unassigned workers. Do you think is it possible? Could you help me to fix this error?
When I tried to use “if_exist” function in constraint_for_employee_min_working_day_in_week, I got following error :
TypeError: Unable to cast 'org.optaplanner.constraint.streams.common.bi.DefaultBiJoiner' to java type 'org.optaplanner.core.api.score.stream.tri.TriJoiner'
Other cases I have observed are as follows:

#of employee
#of shifts
min_working_day
max_working_day
#of employees has no shift
error score

18
27
2
2
4
-36

18
27
5
7
13
-90

18
27
6
7
13
-108

Thank you in advance

@AybukeAk the TypeError is because you used a joiner the joins on a UniStream (BiJoiner) at a place that joins on a BiStream (as the groupby transformed it from a uni to a bi).
You can verify constraints using constraint verifier; see https://github.com/optapy/optapy-quickstarts/blob/stable/employee-scheduling/tests.py for examples.
When tested using constraint verifier, constraint_for_employee_min_working_day_in_week_no_shifts works as expected (only penalizes employees with no shifts).
You can use ScoreManager to explain the score of a given solution; see https://www.optapy.org/docs/latest/score-calculation/score-calculation.html#explainingTheScore .

Thank you so much for your reply. If_not_exists did not work correctly because we were using the old version of optapy. After the update, both constraints worked correctly. But now we got an error in a previously working constrait. I opened another issue regarding this:
https://github.com/optapy/optapy-quickstarts/issues/28


Added warning for slow rows.

@cerv15 - please review PR for issue #120

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (778dde8) 81.94% compared to head (02f70fc) 81.95%.

Files
Patch %
Lines

tablite/base.py
84.61%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   81.94%   81.95%   +0.01%
==========================================
  Files          27       27
  Lines        3948     3952       +4
==========================================
+ Hits         3235     3239       +4
  Misses        713      713

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Config.String() bombing

There seems to be something strange going on with revel.Config.String(str).
This is what my code looks like:
var Config *revel.MergedConfig = revel.Config
var Driver, _ = &Config.String("db.driver")
var Spec, _ = &Config.String("db.spec")

No matter how I look at it, I al always getting this strange error:
multiple-value Config.String() in single-value context
Clearly, this is wrong since MergedConfig.String(str) returns (result string, found bool). Anyone else seeing this?
For now I am hardcoding config vars while I figure this out.

You're trying to get the pointer of the result when you do &Config.String(), that's why it's saying you're trying to use a single value when multiple are returned. Instead, change it to:
driver, _ := Config.String("db.driver")
Driver = &driver

That also doesn't work. What Driver := &driver does it so assign a pointer to driver, to Driver. What I want is the value contained in the variable, not the memory reference.

The & symbol is what is assigning the memory reference, so you can remove that to get the original value:
// Assuming you've defined Driver somewhere in the file already
var Driver string

// Read the config value
var found bool
Driver, found = Config.String("db.driver")
if !found {
    panic("db.driver was not defined in the config file.")
}

fmt.Println("Read db.driver value: %s", Driver)

You don't need to do the found check if you don't want to, but it will help ensure the app doesn't try to run with an empty Driver value.

P.S. Don't put this logic inside an init() method directly, as revel may not have parsed the config file yet. Instead, set it up as follows:
import (
	"fmt"
	"github.com/revel/revel"
)
var (
	Driver string
)

func init() {
	revel.OnAppStart(func() {
		var found bool
		Driver, found = revel.Config.String("db.driver")
		if !found {
			panic("db.driver is not defined in the config section.")
		}

		fmt.Println("Using db.driver value from config: %s", Driver)
	})
}

Thanks a lot. I've got it going properly right now. I'm still getting comfortable with Go.


Proposed New Verb - “Simulate”

Summary of the new feature / enhancement
I’d like to suggest the word “Simulate” be added to the list of approved PowerShell verbs.
My Use Case: I am writing a new FTP client, and am going to create special functions to call (instead of the regular functions) when simulating file uploads. I would like to give the functions names that start with “Simulate.” For example, Simulate-SendingFile, Simulate-ChangingServerWorkingDirectory, etc.
That way, future developers could set breakpoints inside the simulated functions to, for example, examine the logic for determining the target directory on the server, updating number of bytes sent, estimated completion time, experiment with code changes, etc., all without endangering the integrity of a real upload. This would be especially valuable if a new programmer lacked a robust development environment.
Plus, anyone doing a high level review of the code could easily see all functions whose name with “Simulate” so he would know where to focus his attention when looking at protocol compliance, etc.
Another benefit is that all the “Simulate” functions could be put in their own module(s). This would avoid the overhead of importing unnecessary modules during production runs.
I'll be writing the functions regardless of whether I can name them “Simulate-xxx.” However, the names will not as helpful in describing what they actually do.
And of course,  the verb “Simulate” could have widespread use far beyond FTP. There are many software development fields which use simulations. Weather forecasting and military war gaming come to mind, as just two examples.
Proposed technical implementation details (optional)
No response

Found additional examples of where simulation is used: User Interface development & software testing.
The -WhatIf parameter is similar/related, but IMHO, not as powerful as dedicated simulation code.

The -WhatIf parameter is similar/related, but IMHO, not as powerful as dedicated simulation code.

Nothing is stopping you using a non-approved verb in your own development code.  It's only if you release a module that others you'll nagged about it.
In pester commands are mocked so they are called with the same name and that is normal way this is done for testing
Generally "dedicated simulation code" means two copies of the same code, and -whatif / shouldProcess  side steps this. I'd advise against changing your code from and from calling Verb-Noun, to calling Simulate-Verb noun.  If your really need separate code for simulation you can load the simulation version with the same name (effectively as a mock), run the original code that calls those names.

Wouldn't this use case be covered by the Test Verb? Especially if that command returns a true/false response & any errors that occurred if it's desired result isn't achieved?
The other suggestion I'd have is to have a Test Parameter on your commands and then contain the test logic in the commands themselves - keeping it all cleaner and together though that would be almost a re-write of how Should Process does this for you.

I probably didn't explain too well.
It's not a flag, to determine whether we're IN a simulation. It's an indicator to the reader that the code about to executed is simulated (i.e., has no effect on real world objects).  Hope that clarifies.

The Cyber Hymnal™ <><
http://www.hymntime.com/tch

From: Ryan Yates @.>
Sent: Sunday, June 4, 2023 8:25 AM
To: PowerShell/PowerShell @.>
Cc: Dick Adams @.>; Author @.>
Subject: Re: [PowerShell/PowerShell] Proposed New Verb - “Simulate” (Issue #19713)
Wouldn't this use case be covered by the Test Verb? Especially if that command returns a true/false response & any errors that occurred if it's desired result isn't achieved?
The other suggestion I'd have is to have a Test Parameter on your commands and then contain the test logic in the commands themselves - keeping it all cleaner and together though that would be almost a re-write of how Should Process does this for you.
—
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/PowerShell/issues/19713#issuecomment-1575569538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPYO6UOD4EK6SZ5BXKZGGTXJSEC7ANCNFSM6AAAAAAYPAUEKM.
You are receiving this because you authored the thread.Message ID: @.***>


BIND provider as target?

Hello,
I have a use case where I want to get BIND zonefiles out of my OctoDNS configuration. It looks like octodns-bind package has BIND files as a source only. I'm curious: why is that? My scenario is not something people need, or are there other reasons for that?
Any inside would help! Thank you!

I'm curious: why is that?

No specific reason afaik, just that no one who's needed it and coded it up. Probably wouldn't be too hard to update the source to a provider (read and write,) but I've never looked into it. PRs welcome and otherwise it can get put onto the never ending TODO list.
P. S. Moving this to https://github.com/octodns/octodns-bind since it's directly related to that provider.

https://github.com/octodns/octodns/issues/254
It's not the hardest thing, but it's a bit weird because there is some info you have to provide, eg NS records, SOA record things, handle serial, etc. Just never got to it.

It's not the hardest thing, but it's a bit weird because there is some info you have to provide, eg NS records, SOA record things, handle serial, etc. Just never got to it.

i actually threw together something yesterday while killing time watching stuff. it's probably 75% of the way there. will push it up when i get it completed at some point.

Amazing, @ross , thanks a lot for working on this!


Fix pull-multi-arch images for Arm

Hi,
I am Wei Chen from ARM. Currently, I am working on arm-multi-arch support for containerd.
After https://github.com/containerd/containerd/pull/1535 had been merged, the containerd
has enabled the pull multi-arch image support. But the platform.variant field of OCI for ARM
hadn't been ready at that time, so all ARM images could not pull successfully.
"docker.io/library/hello-world:latest:
resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:3644c0788e3d3823f9e97f757f01d2ddc6eb5458df9d801:
done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 5.1 s
total:  2.7 Ki (533.0 B/s)
unpacking sha256:3d3823f9e97f757f01d2ddc6eb5458df9d801...
ctr: : manifest not found: not found"
In this PR we'll detect the ARM variants from /proc/cpuinfo. Because Linux
kernel has already detected the ABI, ISA and Features for us. We don't need to
parse them from registers again.
The PR has been tested on x86 and ARM64 servers, the ctr can pull images correctly now.
I also created an issue to discuss this problem https://github.com/containerd/containerd/issues/1576
@stevvooe  @mattspencer-arm

Codecov Report

Merging #1575 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1575   +/-   ##
=======================================
  Coverage   42.36%   42.36%
=======================================
  Files          24       24
  Lines        3368     3368
=======================================
  Hits         1427     1427
  Misses       1612     1612
  Partials      329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b353d...49c2ca8. Read the comment docs.

Hi Stevvooe, Akihiro,
Because I have public holidays in the following week. So I send the v2 updates as my understanding of your comments. If I have done something wrong please let me know. I can reply the email, but the code update would be deferred.
Regards,
Wei Chen

@Weichen81 Is scanning /proc/cpuinfo the best way to detect architecture for ARM? Do you have a link to the format used so we can ensure that it works across kernel versions?

在 2017年10月3日，05:30，Stephen Day <notifications<EMAIL_ADDRESS>写道：
@stevvooe commented on this pull request.

In platforms/database.gohttps://github.com/containerd/containerd/pull/1575#discussion_r142261108:

@@ -15,7 +25,18 @@ import (
// The OS value should be normalized before calling this function.
func isKnownOS(os string) bool {
switch os {

  case "android", "darwin", "dragonfly", "freebsd", "linux", "nacl", "netbsd", "openbsd", "plan9", "solaris", "windows", "zos":

  case "android", "darwin", "dragonfly", "freebsd", "nacl", "netbsd", "openbsd", "plan9", "solaris", "windows", "zos":

          return true

  }

  return isLinuxOS(os)

I don't think this function needs to be changed.
Ok, I would revert this change in next update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/containerd/containerd/pull/1575#pullrequestreview-66598045, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYDF6x5GYny5Mx62kXJMz4vJRwoNMG2Fks5soVXzgaJpZM4PobNB.

在 2017年10月3日，05:30，Stephen Day <notifications<EMAIL_ADDRESS>写道：
@stevvooe commented on this pull request.

In platforms/database.gohttps://github.com/containerd/containerd/pull/1575#discussion_r142261201:

@@ -26,10 +47,10 @@ func isKnownOS(os string) bool {
// The arch value should be normalized before being passed to this function.
func isKnownArch(arch string) bool {
switch arch {

  case "386", "amd64", "amd64p32", "arm", "armbe", "arm64", "arm64be", "ppc64", "ppc64le", "mips", "mipsle", "mips64", "mips64le", "mips64p32", "mips64p32le", "ppc", "s390", "s390x", "sparc", "sparc64":

  case "386", "amd64", "amd64p32", "ppc64", "ppc64le", "mips", "mipsle", "mips64", "mips64le", "mips64p32", "mips64p32le", "ppc", "s390", "s390x", "sparc", "sparc64":

Don't remove arm entries here.
But, If we keep multiple points for arm arch check, if we have something update, we should modify these two points.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/containerd/containerd/pull/1575#pullrequestreview-66598142, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYDF60MvzCUQVtGTIrOo6wwjlMoYwshmks5soVYMgaJpZM4PobNB.

在 2017年10月3日，05:46，Stephen Day <notifications<EMAIL_ADDRESS>写道：
@Weichen81https://github.com/weichen81 Is scanning /proc/cpuinfo the best way to detect architecture for ARM? Do you have a link to the format used so we can ensure that it works across kernel versions?
Thanks for your reminder. I hadn’t considered enough, the Linux document only defines the cpuinfo is one of the kernel data, but hasn’t restricted the data format. Some old kernel would export “CPU architecture ” as aarch64 not v8.
How do you think about using some tool like lscpu? We can use this tool to standardize the output for different kernel versions and different distributions.
Regards,
Wei Chen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/containerd/containerd/pull/1575#issuecomment-333674563, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYDF6yMp8hUb04x1g0OvJf6dRnjF-p30ks5soVmmgaJpZM4PobNB.

My personal opinion is that reading /proc/cpuinfo probably gives us the best-case coverage for ARM variants that are viable for use with container runtimes. I'm sure we could add complexity with support for older kernels and various edge cases, but seems that for container runtime use cases on ARM, we are talking about people who will need to be on recent kernels for support of modern hardware devices/platform support, and can even run a container runtime including runc and containerd (and/or higher layer Docker, K8s, etcd components).
I think we should go forward with this, which adds no additional dependencies on host OS tooling (e.g. lscpu) and will provide us proper differentiation of the key ARM platforms in use by container community players.

I think we should go forward with this, which adds no additional dependencies on host OS tooling (e.g. lscpu) and will provide us proper differentiation of the key ARM platforms in use by container community players.

Phil, thanks. I prefer to keep reading from /proc/cpuinfo to avoid adding additional dependency.

EDIT: Forgot to clearly state that since we are only running this parser when runtime.GOARCH == {arm family} it greatly limits our need to consider any other CPU architecture/family and possible changes in the format over time, etc.

Yes, currently we don't need to consider the differences of arm,  x86, ppc and other CPU family's
output formats.

@Weichen81 Could address my review items?

@stevvooe Ah, of course! That's undisputed, I will address your comments too :)
But if possible, I still want your comment on :

// The arch value should be normalized before being passed to this function.
func isKnownArch(arch string) bool {
switch arch {
case "386", "amd64", "amd64p32", "ppc64", "ppc64le", "mips", "mipsle", "mips64", "mips64le", "mips64p32", "mips64p32le", "ppc", "s390", "s390x", "sparc", "sparc64":

Don't remove arm entries here.

But, If we keep multiple points for arm arch check, if we have something update, we should modify these two points.

@stevvooe After digging into the code, I think you're right. I should not remove the arm entries from
isKnownArch. Because we just need normalized arm entries like arm/arm64 in isArmArch. I would revert
this change.
Regards,
Wei Chen

My only concern here is we are parsing /proc/cpuinfo on any Linux OS as the code is right now. I would rather this be a "lazy" instantiation so it never runs unless needed.
Hi~I'm penny, working with wei chen in Arm.
How about we make struct armCpuVariant singleton and collaborates sync.Once and getCPUVariant() function to initialize and acquire this single instance whenever needed.

@Pennyzct Correct me if I'm wrong, but, in this case, doing an "init" time initialization will have the same effect as sync.Once. I think we'd want to use sync.Once if we wanted to defer calculation to only when it is actually used. That approach might be better, because I am not sure we want to have a side-effect fork/exec for a package that might be used widely in low-level scenarios.

@stevvooe you're right, it's simple and neat to include the initialization of armCpuVariant in the "init", and adding the arch estimation will avoid useless work in no-Arm arch.
@estesp One more, I'm still confused that for now the instantiation still concentrates in start-up phase, and doesn't fit in running when needed("lazy instantiation").

@stevvooe @estesp @AkihiroSuda
Hi Guys! Could you please to help me check the following log:

The command "if [ "$GOOS" = "linux" ]; then sudo PATH=$PATH GOPATH=$GOPATH make integration-parallel ; fi" exited with 2.

We had tested these patches internally and they worked well. I had checked my code and continuous-integration/travis-ci/pr log. I could not understand why they trigger this building error.
Regards,
Wei Chen

@Weichen81 you can ignore that error for now; there are some GC issues with snapshot removal and the parallel tests (cc: @dmcgowan)

@estesp Thanks!

If you rebase on master it should resolve the test issues now.  Thanks!

@crosbymichael I have rebased these changes, and they have passed the tests. Thank you!

@Weichen81 thanks
@estesp @stevvooe this should be good to review again.

@estesp @stevvooe
Hi Guys,
Any comment?
--
Cheers,

@estesp Thanks for your comments!
@stevvooe Do you have any comment :) ?

Just needs some style cleanups. I am okay merging this for now, but we may need some adjustments when we get a builder for ARM.

@stevvooe

Just needs some style cleanups. I am okay merging this for now, but we may need some adjustments when we get a builder for ARM.

Did you mean we will provide an image builder in containerd?

Just needs some style cleanups. I am okay merging this for now, but we may need some
adjustments when we get a builder for ARM.

Did you mean we will provide an image builder in containerd?

No. He's referring to the use of several systems for a multi-platform CI setup that is in the works, which will include CI for containerd running on ARM nodes.

@stevvooe @estesp
Hi Stephen, Phil,
While we was composing the new version. We found we had cracked the non-multi-arch image support.
So, we include 3 patches in this version to fix it.
Regards,
Wei Chen

@stevvooe @estesp
Hi Guys,
Any comment?

@stevvooe I think this is ready for final review; curious if you have any other comments/input

@estesp I don't like the introduction of MatchCompat. The whole idea is to introduce new matchers that can handle different functionality.

@stevvooe
Ok, I will remove the MatchCompat interface. But how can we handle those images without ManifestList?
The spec.Platform will be initialized very early. At that moment, we don't know whether the image has ManifestList or not. So the variant value will be forward to matcher. In this case, all images without ManifestList could not be pulled.
Except the MatchCompat, I have another option:
For example:
ctr images pull docker.io/arm64v8/alpine:latest
Above image doesn't have ManifestList. But we can parse the architecture and variant from the Image
URI "arm64, v8". But I am not sure all non-multi-arch images had followed this rule.
Regards,
Wei Chen

Previously, we thought that if we could pull the variant info from image ref, e.g. v8 from docker.io/library/arm64v8/alpine:latest. However, since image ref isn't accessible in Manifest func and this strategy only deal with images in some "special" repo(e.g. arm64v8, arm32v7,etc.), we don't think this will work out. Could you give us some advice?   @stevvooe

@Weichen81 I think this PR is not meant to provide all the functionality that we expect to be available when "multi-arch" is complete. This is why @stevvooe requested the MatchCompat not be part of this PR. Hopefully we can document the overall "vision" in an issue/proposal so everyone is on the same page, but instead of a hardcoded MatchCompat, @stevvooe has talked about an implementation that takes an architecture+variant list and scores that list against an (multi-platform) image, which is then used by the runtime to determine the best choice image to take. I think we want your basic "identification" improvements for ARM in this PR, and then use a separate PR to handle how that information is then used to do proper matching against a specific CPU type/variant, in your case.
There are not going to be any easy answers for non-multi-arch images as the information necessary to make the decision is not formalized in any image spec.

@estesp Thanks, I will remove the MatchCompat and send the updated changes ASAP.

@stevvooe @estesp I have updated the changes, please give some comments : )

Hi,
Sorry for disturbing, but any comments : )

ping @stevvooe ; with the removal of the compat matching and all other comments have been resolved, I'm comfortable with this now. I personally think we should get this in and then start to resolve how matching happens on variant or multi-value supporting architectures.

After a fix to the code here, I am okay with merging this. There is still work to be done in this area, so we may make changes, but this is limited for now.

@stevvooe Thanks, I have updated this PR to address your comment.

Hi, I stil get this issue on ARM, I just compile master this morning on raspberry pi3 arm7

Hi~ @ArchiFleKs  Could you give us the detailed error info and the image info ? 😊

@Pennyzct I think my issue might be related to this one : https://github.com/kubernetes/kubernetes/issues/63057
My log is :
mai 26 09:07:45 raiden containerd[410]: time="2018-05-26T09:07:45+02:00" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:kube-proxy-r8mtg,Uid:42c9a762-60b3-11e8-883a-0025900eb312,Namespace:kube-system,Attempt:0,} failed, error" error="failed to get sandbox image "k8s.gcr.io/pause:3.1": failed to pull image "k8s.gcr.io/pause:3.1": failed to get image information: failed to get image diffIDs: manifest sha256:f78411e19d84a252e53bff71a4407a5686c46983a2c2eeed83929b888179acea: not found"

I think I am having the same issue on a Rock64 board.  Tried upgrading to 1.1.2 from 1.1.0 - same issue although this is my first try at learning Kubernetes the very hard way.
ctr --debug images pull docker.io/arm64v8/busybox:latest bb
at the end of the output:
DEBU[0002] fetch response received                       base="https://registry-1.docker.io/v2/arm64v8/busybox" digest=sha256:cd6101adb6f7d5c6f64f1bfb40ef0a63eea38274ac16c8c04bb949769962897b mediatype="application/vnd.docker.image.rootfs.diff.tar.gzip" response.headers=map[Date:[Thu, 19 Jul 2018 02:42:41 GMT] Accept-Ranges:[bytes] Cf-Cache-Status:[HIT] Last-Modified:[Tue, 17 Jul 2018 08:42:27 GMT] Vary:[Accept-Encoding] X-Amz-Id-2:[s46bR239AoE6YaCnASjLPYc1wPnuKZdPQU2zdR5m10N7X4XbfdMs7Dbu9G1hCZK1Nhx2Pe8uDKU=] Content-Type:[application/octet-stream] Cache-Control:[public, max-age=14400] Cf-Ray:[43c9d610c9b6241a-IAD] Etag:["ee1e2543ef566531891e4234117ade24"] Expect-Ct:[max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"] Content-Length:[770638] Connection:[keep-alive] Set-Cookie:[__cfduid=dfa6ff117471d06c72227703f7f5911851531968161; expires=Fri, 19-Jul-19 02:42:41 GMT; path=/; domain=.production.cloudflare.docker.com; HttpOnly; Secure __cfduid=dfa6ff117471d06c72227703f7f5911851531968161; expires=Fri, 19-Jul-19 02:42:41 GMT; path=/; domain=.production.cloudflare.docker.com; HttpOnly; Secure] Expires:[Thu, 19 Jul 2018 06:42:41 GMT] X-Amz-Request-Id:[EAEBE7B793E45832] X-Amz-Version-Id:[qS07hFJzeGjXZx02_qOLW4I675ejnmbz] Server:[cloudflare]] size=770638 status="200 OK" url="https://registry-1.docker.io/v2/arm64v8/busybox/blobs/sha256:cd6101adb6f7d5c6f64f1bfb40ef0a63eea38274ac16c8c04bb949769962897b"
DEBU[0003] unpacking                                     image="docker.io/arm64v8/busybox:latest"
unpacking sha256:6e91cbbf76bfb7fe4edcce7b5b5a0f551e9d0b3ba01107b2faa383b33560412d...
ctr: manifest sha256:6e91cbbf76bfb7fe4edcce7b5b5a0f551e9d0b3ba01107b2faa383b33560412d: not found

root@rock64b:~# ctr version
Client:
  Version:  v1.1.2
  Revision: 468a545b9edcd5932818eb9de8e72413e616e86e

Server:
  Version:  v1.1.2
  Revision: 468a545b9edcd5932818eb9de8e72413e616e86e

I have the same with v1.2.6 installed from ubuntu repository. Actually, on an amd64 it can be reproduced, that arm/v7 image pull fails:
# ctr i pull --platform linux/arm/v7  docker.io/library/busybox:latest
docker.io/library/busybox:latest:                                                 resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:c94cf1b87ccb80f2e6414ef913c748b105060debda482058d2b8d0fce39f11b9:    done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:aba5fffb8a7a1a5376c970417b05706ff6ced29a696ee486dc14144b7221d9f1: done           |++++++++++++++++++++++++++++++++++++++|
layer-sha256:235dcb7bd32b2dd4c7bbf16e6a81ead3c8250e62255b79adee7e2011d53342ca:    done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:b85bc5e010b4dcf4c2f5b2b58fc3fff7aab24fc223cc15efa7ed2f39ec253d34:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.5 s                                                                    total:   0.0 B (0.0 B/s)
unpacking linux/arm/v7 sha256:c94cf1b87ccb80f2e6414ef913c748b105060debda482058d2b8d0fce39f11b9...
ctr: content digest sha256:76535ae6ed1a2a69f5c4fdf6d0a5b17da86f797cb7ac15c06dd74fe44e454db2: not found

@rkojedzinszky this is fixed in our latest release, 1.2.7, so there isn't much we can do about it--hopefully Ubuntu will update to 1.2.7 soonish.

Thanks @estesp . Then either I do something wrong, or some bug is still present. Even if ctr can download the image, containerd daemon cannot, emits the same error message. I do this on arm.


dbt-core incremental model with --full-refresh failing on Azure Synapse after initial creation

After successfully creating and running an incremental table model using dbt-core and the dbt-synapse adapter, if I attempt to recreate the table by using the --full-refresh command line option, I get an error:
[42S01] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]There is already an object named 'real table name here' in the database. (2714) (SQLExecDirectW)"
It appears that the expected "drop table" script component is not executing?

Hi @geoff-muldoon This issue repo is for our docs.getdbt.com site. Is there a page there you believe is leading you astray?


Guild BiS list, sorting by name/class/rank throws an error

Might be due to development version. Will test on release version.

Gives same error on release version. Might be because the guild BiS DB is empty.
Will test with guild mate imported in DB and see what happens.

Same as the other. Can't reproduce it since filters are working fine for me.

Might be an error on my end. Will test with clean DB.

No longer gives me an error. Will reopen if someone else gets the same bug


License

Hey Xinsir -
Great work again. We'll be looking at incorporating your work into Invoke's OSS studio soon. :)
Can you confirm that the code is also Apache 2, and update the GH repo with that license if so? We make all of our code Apache 2.0 so have to make sure we don't include anything in the code that wouldn't be compatible with that.
Appreciate your work - Let me know if you have any interest in the OMI or supporting your work.

OK, I will update the license soon. Any questions you can send to my email<EMAIL_ADDRESS>

LICENSE have beed updated, you can use it as you like.


Fix: no-explicit-any Rule does not check generic type (fix #26)

This change improves the existing no-explicit-any rule by adding:

Check for TSUnionTypes
Check for TSIntersectionTypes
Check for TypeReferences (Array<*>) and TSArrayType (any[])
Check for Arguments in class constructors
Check for Properties in classes, interfaces and type aliases

This also adds more tests cases

LGTM

Thanks!

I just published version 0.4.0 to npm and this PR is included in it 👍


Errors on mithril admin portal. FE

pop-up window is not closed after deleting data

fixed on dev


Consider Haml review as beta

Now that we have BETA_LANGUAGES, thanks @bernerdschaefer, we don't have to disable all rules in config to disable Haml review.
If you want Haml review you will need to enable it in .hound.yml.

:+1:

:+1:

I want to point out that HAML linter seems to be working well after the gem upgrade.


希望增加变量被停用时候推送消息

Clear and concise description of the problem
变量无效被停用时候希望能推送消息，这样我就能及时更新变量了。
Suggested solution
消息推送添加多一个变量变化状态。
Alternative
No response
Additional context
No response
Validations

[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

这个推送是脚本控制的


scoop install maven failed (3.3.3)

PS C:\Users\mathieu> scoop uninstall maven
uninstalling maven (3.3.3)
maven was uninstalled
PS C:\Users\mathieu> scoop install maven
installing maven (3.3.3)
downloading http://mirror.rackcentral.com.au/apache/maven/maven-3/3.3.3/binaries/apache-maven-3.3.3-bin.zip...Unable to
connect to the remote server

I get "404 error https://www.apache.org/dist/maven/maven-3/3.6.1/binaries/apache-maven-3.6.1-bin.zip is not valid" when trying to install maven - url is obviously wrong.

@tomahawk69 It's an upstream problem. Maven is updated to 3.6.2 and 3.6.1 is removed, but the version on homepage is still 3.6.1.

@tomahawk69 It's an upstream problem. Maven is updated to 3.6.2 and 3.6.1 is removed, but the version on homepage is still 3.6.1.

Yeah, I see, the same problem with their download page (https://maven.apache.org/download.cgi).
It's slightly confused the maven is in the list of installed application in Scoop, I supposed the download error should stop the installation, isn't?

See https://github.com/lukesampson/scoop/issues/3580 . You need to uninstall it manully before reinstall.


Visible token in wallet re-enter pin accessibility label

Build 1252. As per the screen shot there is the token {{new}} in the re-enter pin accessibility label:

Resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/998


[HAC-1854] Remove console.navigation extension

https://issues.redhat.com/browse/HAC-1854
Test:
Following the instructions from the Readme to load HAC Infra on the browser, we should still see the Workspaces menu item in the navigation menu on the left.
cc: @rhamilto

/approve


README: where to create tickets

Mention in the readme that bugs in the library twitter4s should be created under twitter4s, not here

acknowledged


Extrinsic Matrix of Lidar to Camera fusion is not constant!

As mentioned in lidar_to_camera.py, at first lidar points are converted to World frame than to Camera frame and finally to Image frame.
`            # This (4, 4) matrix transforms the points from lidar space to world space.
lidar_2_world = lidar.get_transform().get_matrix()
        # Transform the points from lidar space to world space.
        world_points = np.dot(lidar_2_world, local_lidar_points)

        # This (4, 4) matrix transforms the points from world to sensor coordinates.
        world_2_camera = np.array(camera.get_transform().get_inverse_matrix())

        # Transform the points from world space to camera space.
        sensor_points = np.dot(world_2_camera, world_points)`

Usually after the extrinsic matrix is constant because relative postion of the sensors are not changing but extrinsic matrix for projection of lidar point to camera frame ie np.dot(world_2_camera, lidar_2_world) is not constant.
Is there any way to find the extrinsic matrix for projection of lidar point to camera frame without transforming to world frame or is there any other way to find a constant extrinsic matrix?
I am asking this because I am writng a C++ ROS code for projection of lidar point cloud to image frame and I am subscribing only lidar and camera rostopics.
Thank you for your help in advance

@dupply did you get the lidar_2_cam matrix finally?

@dupply  did you find an answer

Hi, i am also curious about how to get extrinsic matrix between lidar and camera. Is there any way? Thanks a lot!


Edits invalid package name

package name was not valid, npm install wouldn't work.

Also looks fine.


add osx and test thoroughly

Comment:

[ ] add osx support
[ ] test if gui works readily

It may be that wx should be updated to jot use CDTs anymore. Though this would be the first i would see if this kind of issue with x11
https://github.com/conda-forge/wxwidgets-feedstock/blob/main/recipe/meta.yaml#L39


Constant tables / values list support

Companion ecto PR: https://github.com/elixir-ecto/ecto/pull/3929

Closed in favor of https://github.com/elixir-ecto/ecto_sql/pull/552


Null separator throws exception.

Tried to do this:
<lc:Axis MinValue="0" Labels="{Binding PrimaryAxisLabels}" Separator="{x:Null}"/>

Got a NullReferenceException.

Separators canot be null, from docs
https://github.com/beto-rodriguez/Live-Charts/wiki/0.2-Live-Charts-Basics
they are necessary for a chart, instead disable it.
<lc:Axis MinValue="0" Labels="{Binding PrimaryAxisLabels}" >
lc:Axis.Separator
<lc:Separator Enabled="False" />
lc:Axis.Separator
</lc:Axis>

The only way to disable the separator is in the code behind or by creating a new disabled separator in XAML.  There should be a way to disable in XAML without creating a new one.

I like the Separator="{x:Null}" syntax, it is intiutive, I will add this to next release, something like:
canging this line https://github.com/beto-rodriguez/Live-Charts/blob/master/Charts/Axis.cs#L68
to
private Separator _separator;

public Separator Separator
{
  get { return _separator;}
  set
  {
      if (value == null)
     {
        _separator = new Separator { Enabled = false };
        return;
     }
     _separator = value;
  }
}

I think the better solution would be to allow null in the property then check for null wherever it's used.
Reasoning:  when I set a property to be null, I expect that it's null.  Setting a property to be null, then getting a value out is a bad experience.  Consider this code:
var myObj = new MyObject { MyProp = new object() };
... // do some stuff that may change myObj.MyProp
if (myObj == null)
{
    ...
}

This is perfectly logical code, but if the setter for MyProp doesn't actually set the property to null, the contents of that if statement will never execute.

the problem is that separator does not only means that line you see, it is a important concept in a chart, the enable property is there to make it invisible, but it is a really importanto calculation to scale a chart I dont think that is possible without changing a huge part of the code

In that case, I suggest making the Axis.Separator property non-user-settable.  This would require that the user set Separator properties like this:
<lc:Axis MinValue="0" Labels="{Binding PrimaryAxisLabels}" Separator.Enabled="False"/>

See this SO answer as to why this works.
Also, you'll need to make the properties on Separator DPs.
As a final note, Enabled should be IsEnabled to follow in the pattern set forth by MS.

Okay... I'll see what alternatives there are.

Ideally, I think what you'd want is not to have a public setter on the Axis.Separator property.  But then you run into the issue of setting the separator properties in XAML.  You could create forwarding properties on Axis, but that's not very clean.
I think the best thing to do is to update the Separator properties to DPs and give them default values (the defaults you use in the Axis constructor would be fine).  This way, the defaults can be overridden in XAML either directly or via styles.

As far as the exception when the separator is null, I think it's best to throw an exception if it is required.  However, it should throw ArgumentNullException immediately rather than waiting for a dereference attempt.


Compatibility with Cisco Umbrella logs version 6

Is your feature request related to a problem? Please describe.
Cisco Umbrella data connector.
We are currently unable to switch to Umbrella Logs version 6, because the function app does not parse the new fields. it seems that the funcion app is compatible until version 4.
https://docs.umbrella.com/deployment-umbrella/docs/log-formats-and-versioning
https://github.com/Azure/Azure-Sentinel/blob/master/DataConnectors/CiscoUmbrella/ciscoUmbrellaDataConn/__init__.py

Describe the solution you'd like
I would like Cisco Umbrella data connector to parse also the following fields:
Proxy logs:
Identities, Identity Types, Request Method, Certificate Errors, Destination Lists IDs, DLP Status, File Name, Rule ID, and Ruleset ID.
Describe alternatives you've considered
Is Microsoft mantaining this data connector or should I contact Cisco to implement the feature?
Additional context
I believe this could be considered also a bug, since new Umbrella customer start with version 6 logs and are unable to use the connector.
That's just a theory, I have not tested it.

@piercosta :  We are working on upgrading the Azure Function to support version 5 and 6 log formats.
Meanwhile, if you can share some sample proxy logs from cisco(by masking any PI or security information) with us that would be helpful.
Thanks!!!

@piercosta - Can you share some sample proxy logs from cisco(by masking any PI or security information) with us that would be helpful

Hi,
sorry for the delays.I will send you some example of the logs as soon as
possible.
Thanks for your feedback.
Best Regards,
Pier
Il gio 14 ott 2021, 08:18 ashishsyal @.***> ha scritto:

@piercosta https://github.com/piercosta - Can you share some sample
proxy logs from cisco(by masking any PI or security information) with us
that would be helpful
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/Azure-Sentinel/issues/3100#issuecomment-943003272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFCGCB2HXI3ZULOGZLQHWLUGZY2PANCNFSM5EUUKF5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@piercosta, Did you get chance to test provided package? let me know if any help needed. Thanks!

Hi,
sorry but at the moment I am not able to correctly test the function, since
we don't have a test environment, only production.
Il lun 1 nov 2021, 18:20 v-maudan @.***> ha scritto:

@piercosta https://github.com/piercosta, Did you get chance to test
provided package? let me know if any help needed. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure/Azure-Sentinel/issues/3100#issuecomment-956426650,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFCGCDOL4UEGYNDECIWY53UJ3D6TANCNFSM5EUUKF5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@piercosta : We have merged the PR after getting it tested with the help of other customer... Thanks!!!


StandardTrackingWheelLocalizer

In your documentation it says to add the X and Y multipliers in the getWheelPositions(), but in your example it show it in the getWheelPositions() and the getWheelVelocities(). Which is right ?

Both getWheelPositions() and getWheelVelocities(). My apologies for the oversight. That will be resolved

Both getWheelPositions() and getWheelVelocities(). My apologies for the oversight. That will be resolved


Mobile version portifolio

Thank you!
what could be the reason to be invalid code review request?
On Sat, Jul 2, 2022 at 11:58 AM Daniel Ufeli @.***>
wrote:

@.**** requested changes on this pull request.
Hi @SurafelGetachewT https://github.com/SurafelGetachewT ,
While you made a great effort in this project, unfortunately, I cannot
proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a PR Description
Your Code Review Request will be marked as invalid in your Dashboard, so
please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
—
Reply to this email directly, view it on GitHub
https://github.com/SurafelGetachewT/My-Portfolio/pull/2#pullrequestreview-1026740704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLZDXEEWNP5763FFPRFFVLVSAAC3ANCNFSM52OXGJHQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

#Mobile Version Setup for Portfolio Project
In this project, I have made

Work section of the project based on Figma design.
About section of the project based on Figma design.
I have used CSS Grid and Flexbox
I have checked errors detected by the linter and corrected them.

Awesome, thank you so much!
On Sat, Jul 2, 2022, 1:37 PM Kalolo Chola Lemba @.***>
wrote:

@.**** approved this pull request.
STATUS: APPROVED 🟢 👏
Hello @SurafelGetachewT https://github.com/SurafelGetachewT ,
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
HIGHLIGHTS:

Your project is professional
Your repo is professional
Well structured files

Now you can merge this branch and move on 🥇
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 🤞 🍀
[image: well-1]
https://user-images.githubusercontent.com/64173189/128382030-38e7de91-f6f2-45cf-b54e-8068e0446e4c.gif
[OPTIONAL] Kindly add a screenshot to your README file showing your
webpage user Interface. You can use extentions like fireshot to capturer
the entire page.
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/SurafelGetachewT/My-Portfolio/pull/2#pullrequestreview-1026747122,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLZDXCDMQ6N452T7Q3LQOLVSALYDANCNFSM52OXGJHQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


TestWhiteListing consistent failures

https://testgrid.k8s.io/istio-postsubmits#integration-k8s-tests
It seems to fail every time.

Status update: We have this test skipped, referring to this issue. @gargnupur is there any plans on fixing this?

@howardjohn : was on vacation :(:) will take a look at this one, this week...


[fix] #2227: Implement Register and Unregister for Asset

Description of the Change

Implemented Register and Unregister instructions for Asset
Changed minting implementation to require registering the asset first
Adjusted public validators accordingly

Issue
Resolves #2227

Benefits
Consistency, no more "unsupported" Register/Unregister instructions

Possible Drawbacks
Register asset and Mint should now be considered together when implementing permission systems.

I'll approve the when all tests will pass

@Arjentix I don't think it's ready yet. Apart from there not being any consensus on #2339 , this PR as it is now introduces a loophole to mint non-mintable assets twice.

Oh, yes, haven't think about it...

Overall, I think we need to create an integration test for the double mint loophole. To me it seems that this could be fixed by pattern-matching on the initial amount, and registering the asset as Mintable::Not right after its initial registration.
So if you want to defer the minting, you can still do it, but if all you want is to create a non-mintable asset with an initial quantity, you can do that too.

Based on #2339 I removed requirement to register asset before minting and removed Mintable::Once.
I experimented with default values in asset definitions, but it ultimately resulted in convoluted API when you take NFTs into account, so I scrapped that. I still think asset registration semantics as implemented here is not ideal, so I would maybe like to try and revisit that after release.

Overall, I think we need to create an integration test for the double mint loophole. To me it seems that this could be fixed by pattern-matching on the initial amount, and registering the asset as Mintable::Not right after its initial registration.
So if you want to defer the minting, you can still do it, but if all you want is to create a non-mintable asset with an initial quantity, you can do that too.

@appetrosyan sorry, I missed your comment.
I think disallowing minting altogether and leaving registration as the only way to add non-mintable assets to accounts results in more straightforward API. Is there a particular reason you would want to support minting in this case?

I think disallowing minting altogether and leaving registration as the only way to add non-mintable assets to accounts results in more straightforward API. Is there a particular reason you would want to support minting in this case?

The APIs are comparably simple, but in different ways.
If you retained the Mintable::Once variant, you can create an asset and can defer the amount that you wanted to mint. Why is this good? Consider that we made Mint variadic: it accepts multiple (AccountId, Asset, Quantity) tuples, and so if you want to create a non-mintable asset that is split evenly between e.g. shareholders of a company, you can do that in two instructions. If we don't allow it, we increase the load on the network, because to achieve the same result the person doing it has to split the single Mint ISI into a Mint and several transfers.
Moreover, we will need to synchronise the behaviour of Mint with the implementation in Execute for Register<AssetDefinition>, so nominally you have fewer instructions but each of them is more complex.
Both approaches are valid: in the CPU world what you propose is called CISC, while my stance is closer to RISC with SIMD. I personally would prefer that we kept the API changes in this PR to a minimum, but will approve given a good justification.

Right, my stance on this was the way it was mostly because I confused AssetDefinition and Asset in regards to Mintable.
I reverted to having Mintable::Once and implemented your proposed solution for double-mint loophole:

So  if Register has value 0, creates a Mintable::Once asset, while a register with any other non-zero value necessarily a Mintable::Not variant

I have one question in regards to that - in this implementation one can register Mintable::Once asset to any number of accounts as long as Register has value 0. Are we okay with that?


[SPARK-6902] [SQL] [PYSPARK] Row should be read-only

Raise an read-only exception when user try to mutable a Row.

Merged build triggered.

Merged build started.

Test build #40082 has started for   PR 8009 at commit 05a3d36.

Merged build triggered.

Merged build started.

Test build #40086 has started for   PR 8009 at commit 8722f3f.

Test build #40082 has finished for   PR 8009 at commit 05a3d36.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #40086 has finished for   PR 8009 at commit 8722f3f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed trait LogisticRegressionTrainingSummary extends LogisticRegressionSummary
sealed trait LogisticRegressionSummary extends Serializable
case class StringTranslate(srcExpr: Expression, matchingExpr: Expression, replaceExpr: Expression)

Merged build finished. Test PASSed.

cc @JoshRosen for review

Merged into master and 1.5 branch


offset of flatlist not preserved

Hi! I'm using your framework in a project of mine, and in one of my views I am animating a horizontal flatlist on and off the screen with an appear and disappear animation of right to left.
This works as expected, except that when I actually scroll the flatlist and then go to my next screen, it seems as if your library re-renders the flatlist without taking the current scroll offset into account. This causes a glitch in the animation.
Is there anything I can do to fix this, or is this something that you want to patch?
Any help would be highly appreciated, thanks in advance

Hi, @joris1995 - Thanks for submitting the issue. If you want to have a look please go ahead and clone the project and see if you can find a fix for this. I'd be happy to patch it.

@joris1995 did you find any solution ? @chrfalch ?


Added support for XREADGROUP command

Closes #1326

coverage: 77.735% (+0.1%) from 77.6% when pulling bf75602fcd5a6bbef5bb24423c1d27d5dbe41e84 on vladvildanov:vv-1326-xreadgroup-support into 90da582efc88d5168fa126f1c3527733d81690eb on predis:v2.x.

@chayim Done!


Fold 3DTILES_implicit_tiling extension into implicit tilesets

This PR incorporates the 3DTILES_implicit_tiling extension into implicit tiles as tile.implicitTiling, such that the extension is no longer necessary. It also adds 3D Tiles 1.1 tilesets for the implicit tiling sample data, and updates the existing 1.1 tilesets for implicit tiling metadata.
cc @ptrgags for review!

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


addMultiple functionality

Added an addMultiple function to allow multiple items to be added to the queue at once.

@MauriceButler can you give an example where this is preferable to calling .add() repeatedly?

Hi @tmcw
When I already have a large array of items, rather than having to loop over them and add one by one the array can just be concatenated in.
For instance the basic example in the readme,
q.add('https://www.somewhere.com');
q.add('https://www.someplace.com');
q.add('https://www.something.com');
q.add('https://www.someother.com');

If the urls were already in an array, they could just be added in one go rather than looping or mapping over them.
var urls = [
    'https://www.somewhere.com',
    'https://www.someplace.com',
    'https://www.something.com',
    'https://www.someother.com'
];

q.addMultiple(urls);

vs
var urls = [
    'https://www.somewhere.com',
    'https://www.someplace.com',
    'https://www.something.com',
    'https://www.someother.com'
];

for (var i = 0; i < urls.length; i++) {
    q.add(urls[i]);
}

With 4 items it doesn't seem like a big deal but when dealing with large jobs of ~2k items it is just unnecessary when they can be added in one go.
When I need a queue I almost always have my items in an array already, would be nice to just add them.

You can use .forEach and .bind to do the same without the explicit for loop.
var urls = [
    'https://www.somewhere.com',
    'https://www.someplace.com',
    'https://www.something.com',
    'https://www.someother.com'
];

urls.forEach(q.add.bind(q));

Yes but the expense of the iteration is still there.
It is the iteration over the array that seems unnecessary.

Closing; would accept a PR that includes both this functionality and a benchmark that demonstrates a repeatable real performance boost.


BUild a good markdown Readme.md

Should be clear on whats done
Include screenshots of the app

Completed in #17


Allow for Store::new() to return an error

The newly introduced DiskMmapStore trait creates a file-backed mmap subject to potentially many points of failure in its new implementation. At the moment those errors will panic, they instead should be reported back to the consumer of the API.
See https://github.com/filecoin-project/merkle_light/pull/15#discussion_r285613407.

Same for DiskMmapStore::new_with_path (which in turn is used by reload_store, store_read_range and store_copy_from_slice).
See https://github.com/filecoin-project/merkle_light/pull/15#discussion_r285614056.


Tutorial improved on Readme

I've had some problems trying to get it working on Windows.
I've managed to solve it with help from @iamtrask and @emregoynugur and this is what we have learnt.

looks good!


StorIOSQLite Query builders and tests

Compile-time safe builders for StorIOSQLite queries
@nikitin-da PTAL btw you used Query builder incorrectly in integration tests! Ha!

Part of #218


add in functionality to push the entire page contents over when left slide-out comes out, currently it slides in over the main content

the resolution here is to not add this functionality, rather if the user would like to extend it to do so, that'll be up to them, but in an effort to keep this base functionality as tidy and lean as possible, we'll exclude this as an out-of-the-box feature at this time


search input added

Added the search functionality to the input.

I'm just wondering why there are file changes more than in their own branch packiyarajpatchath:country_search_option?
@aakash-sonova

I'm just wondering why there are file changes more than in their own branch packiyarajpatchath:country_search_option? @aakash-sonova

Hi @977eibrahim , Its is so because they had made changes in the build folder however not in the pre-build folder - src. So I had to make the equivalent changes to src. Because otherwise once we build, the changes will be reverted. I believe packiyarajpatchath made changes in the wrong directory by mistake.


Tiny Typo

What does this PR do?
The seed didn't run correctly because there was a typo.
INSERT INTO role_capability (role_id, cap_name) SELECT (SELECT id FROM role WHERE name = 'read-only'), 'delivery-servie-security-keys-read' WHERE EXISTS (SELECT id FROM role WHERE name = 'read-only') ON CONFLICT DO NOTHING;
ERROR:  insert or update on table "role_capability" violates foreign key constraint "fk_cap_name"
DETAIL:  Key (cap_name)=(delivery-servie-security-keys-read) is not present in table "capability".
Can't seed database w/ required data

What is the best way to verify this PR?
Run the upgrade, make sure there are no errors.
Check all that apply

[ ] This PR includes tests
[ ] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[X] This PR includes all required license headers
[X] This PR does NOT fix a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2359/
Test PASSed.

test comment


added ppt

Codrina! Grazi milli! Possibly written wrong... Thank you so much for joining us again this year!


Daily triggers are documented

Infra provide a custom function getDailyCronString() we should document that somewhere so users know the official way of enabling daily builds.
https://conjurhq.slack.com/archives/C0A2NF134/p1578925997047800
https://github.com/conjurinc/appliance/blob/master/Jenkinsfile#L11-L13

Created in the wrong repo, closing.


This project no longer works for current version of Ansible (2.3)

Please let me know if you don't plan on supporting this repository anymore.  If not, I may just fork the current version of trellis and try to port it to grav on my own.  Hopefully you are continuing to support this repo and the update is somewhat trivial for you :)
Submit a feature request or bug report

[ ] This is a feature request
[X] This is a bug report
[ ] This request isn't a duplicate of an existing issue
[ ] I've read the docs and followed them (if applicable)

Replace any X with your information.

What is the current behavior?
"vagrant up" fails due to Ansible behavior changes in 2.3.
What is the expected or desired behavior?
"vagrant up" should succeed out of the box

Bug report
(delete this section if not applicable)
Please provide steps to reproduce, including full log output:
Just run "vagrant up"
Please describe your local environment:
Ansible version: 2.3
OS: Windows 10
Vagrant version: 1.9.5
Where did the bug happen? Development or remote servers?
Development
Please provide a repository or your wordpress_sites config (if possible):
It's the default one (you may want to change this template to ask for "grav_sites" instead
Is there a related Discourse thread or were any utilized (please link them)?
No
More Information
There may be enough changes in the current version of trellis to simply fork that, remove/replace the wordpress stuff, and then commit it to this repository rather than work off of this repository.  Basically, Ansible 2.3 has a bunch of syntax changes that don't appear to work well with these playbooks.  I tried copying/pasting the trellis version of the file into this repo, but then another syntax error pops up somewhere else.  It's like playing whack-a-mole.

@wfsaxton: It might take me a while to find time to fix this. And even when I do, we'll still end up with an outdated version of trellis. I think your suggestion of starting from scratch with a current version of trellis is better.

I gave it a try and I just don't think my knowledge of ansible and trellis is up to the task.
It would be great if there was some kind of script we could create that would fork trellis and grav-ify it.  Do you remember what steps you took to do this?  Probably something like:

fork trellis
regex file names and file content wordpress ->  grav
remove unnecessary modules (ie mariadb)
perform more specific grav changes

Once I get better with grav/ansible I may dig into this further.  For now, i actually started working on someone else's basic ansible/grav work if you want to take a look: https://github.com/wfsaxton/ansible-grav


feat: colorful console log on sell coins script

Description
Adding console logs when selling coins with sell-remaining-coins.py and making them colorful.

What are you addressing in this PR

Place X in the slot...

[ ] Functionality
[x] Ease of use
[ ] Bug fix

How have you tested this PR
Running the sell-remaining-coins.py script and checking the console.
It has to be in run in prod only because actual selling only works in prod.
In your own words, please share how this makes the codebase better.
This PR doesn't really affect the codebase too much, but makes it better to know the results when selling coins using this script.

Simple and clean. Gonna merge this one.