Windows Support

This is not quite ready yet, but far enough along that I can take feedback. I can answer questions and get into more detail later, but I want to get this posted so will keep this initial post shorter.
For now, I've pulled out all PtyProcess into a separate library, https://github.com/TyPR124/ptyproc
This code could be moved back into rexpect, or added back into this repo as a separate crate. I don't feel the need to "own" the code (but am willing to) and the repo above is not a published crate as of now.
To summarize the changes to PtyProcess, besides adding Windows support, the previous unix-specifc methods have been replaced with platform-independent methods that have the same functionality as their std counterparts (see: Child). Also of note, "set_kill_timeout" has been changed to "set_drop_timeout" and exactly what this means is explained on that methods docs.
Many of the existing tests are unix-specific, but the ones that aren't are all passing as well as a couple I added specifically for Windows. I do not consider this comprehensively tested yet and would greatly appreciate any more "real world"-y tests you could put it through (specifically talking about the Linux/Mac targets as I doubt you have anything built for Windows).

thanks for posting this, I didn't have yet a look at the code, the plan is to merge it into the new exp-and-windows branch. Now I already merged @zhiburt s changes in and now it has a merge conflict. Could you resolve these conflicts, or would this be easier for @zhiburt ?
About your question about moving the pty part into a different crate. Good that you bring this up, I was thinking that maybe the reader part could live in a separate repo as well, especially since @zhiburt made it quite a bit more "general" so it also could be used for other projects.
But then again I think the repo is not big enough to justify to move it to separate repos. Also I fear that it would be "drifting apart" and making it less stable.
Also maybe you and @zhiburt would like to be contributors to this github project so you could "own" your code better, especially since I was not using Rust too much in the past 2 years.
These are loose thoughts and it's maybe a bit hard to discuss this here in a github thread, so maybe we could open a chat in Telegram or maybe you know a good way to have these discussions?

Merge conflicts are resolved.
As far as separating things into their own crates, in my mind it makes sense to separate out PtyProcess from everything else, which would make ptyproc the crate for spawning PTY-enabled processes, and rexpect the crate for matching output of PTY-enabled streams. That also allows the majority of OS-specific code to be outside of rexpect, and puts all unsafe code outside of rexpect. That said, I will accept whatever is decided.
I would be okay with helping to maintain this crate/repo either way.
There is still a good amount of cleanup I need to do, as well as some things that could be done after the merge like adding spawn_cmd and/or spawn_powershell functions (and possibly making spawn_bash work on Windows via WSL). These would all be additions rather than breaking existing stuff.
As a final note for now, the method I'm using for Windows is only supported on Windows 10 (according to Microsoft, I haven't tested it myself yet on anything other than Win10) so that may be something to consider whether it is worth adding this specifically for Windows 10 support. (And assuming that isn't a deal-breaker, I will make sure it is documented in various places).

Thanks for resolving, I've now merged it into the exp-and-windows branch.
I like your reasoning about the separate crate. Especially since a standalone PTY crate is useful for other use cases as well. I'll give myself some days to think about this but I'm not opposed to it :-)
I started looking through your code but it's a bit hard since I don't have a diff at hand. I guess it's best when I diff the old process.rs with your unix.rs, right? I'm a bit confused since e.g. I didn't find kill with a signal.
Also: I see that you removed some of the comment, e.g. in process.rs there was a lengthy example at the beginning on how to use the module. Are you planning to move this into the documentation of PtyProcess?

Unix.rs will be the closest file to what was the old process.rs, however not much of it has changed.
The function spawn_pty is about the only part that will contain code from the old process.rs.
The remaining methods on PtyProcess no longer take a signal, as that is a concept that doesn't exist in Windows. So instead I opted to use the methods found on the standard libraries Child type, but also added the "try_wait_timeout" method to help keep consistent behavior with the old process.rs.
I can add methods that take a signal parameter, but they would be behind a unix-specific trait (similar to any extension trait in std::os::unix).
And comments/documentation/examples basically all need done still, which I plan on getting done this weekend (as well as any other changes that stem from this discussion).

Are there any plans to integrate Windows support into master? I see that exp-and-windows branch falls behind.

At least I have no intention to merge the two branches at the moment. It looks like they have diverged a fair bit.
But if anyone creates a PR rebasing the important bits onto master, I'll have a go at reviewing/merging it.
Unfortunate that it was handled with a separate branch, and that a new group of maintainers was added who don't have the history.


Prefer using Tokio as the main task runtime

Most notably this:

fixes a hang in sccache_cargo integration test (https://github.com/paritytech/sccache/commit/edce5ab1a4eb5293a356f371207ea85b0730782f)
marks ClientToolchains::put_toolchain as synchronous (https://github.com/paritytech/sccache/commit/77828ad56c67a6082494b5725bd473286fbed1d1)
prunes futures::executor::ThreadPool entirely and replaces it with (blocking calls to) Tokio executor all over

I tried to put some context/rationale into corresponding commits; let me know if I should squash the last threadpool/Tokio executor commits.
This still fails the tests (but on a new one now :upside_down_face:):
thread 'test_sccache_command' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', tests/system.rs:119:9

interestingly enough, when testing locally, it seems that the new expected value seems from before https://github.com/paritytech/sccache/commit/ac6baf08142d2bf6da7d71e1af9c50a8406b6c60. Maybe that's a difference in environment? I'm on Ubuntu 20.10 with relevant gcc -v:
xanewok@faerun-dev:~$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa:hsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 10.2.0-13ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-10/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-10 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-10-JvwpWM/gcc-10-10.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-10-JvwpWM/gcc-10-10.2.0/debian/tmp-gcn/usr,hsa --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.2.0 (Ubuntu 10.2.0-13ubuntu1)

Closes #34

Hmm, I am not entirely sure this is a good idea. In my mental model we want a thread pool for some blocking tasks, which might take "long" and thus block the entire system because of blocking all execution threads - so a separate thread pool for those actually would make sense imho. But I think you are correct that the thread pool usage was bleeding into a few places where it was not needed.

In principle I agree, but in this specific case I think it's better to use a single solution rather than trying to combine two.
Most of the intermediate tasks need access to Tokio runtime anyway, because of how pervasive run_input_output helper is. This internally spawns an async-enabled child process, which must be spawned in the Tokio context. This requirement for Tokio child processes is introduced with Tokio 0.2, hence why it pops up now.
Currently, the blocking thread pool is mostly to perform disk I/O or to use blocking HTTP (for simplicity?). In the context of our usage, using Handle::spawn_blocking does not differ much from using a futures::executor::ThreadPool here. As the docs mention, the threads are spawned if necessary and the upper limit is high by default as this API is mostly designed for I/O-bound blocking operations rather than CPU-bound ones. This seem to be our use case; the few CPU-bound tasks we seem to be doing are:

BLAKE3 digest (currently we do that on a single dedicated thread from the pool and it's intertwined with disk I/O)
zstd (intertwined with disk I/O; zstd also exposes an async version we could migrate to)
bincode serde in blocking HTTP requests (if I'm not missing anything it seems the requests/responses are small enough comparing to blocking HTTP time).

The majority of other use cases is just regular std::fs disk I/O. I suspect we could adapt that to use tokio::fs instead and let the runtime schedule disk I/O accordingly (which might be even more performant depending on the backend used).
Until (if?) we use an executor-agnostic child process support, I think simplifying the implementation here gives us more than we'd get by seemingly separating concerns when using futures::executor::ThreadPool that we'd have to combine with Tokio runtime anyway.
An alternative is to create our own executor abstraction that'd wrap Tokio-enabled IO futures that we'd spawn on the separate thread pool but poll inside the Tokio context.
I propose to (in no specific order):

try to land the first two commits to work towards green CI (and possibly leave remaining work until we have green CI?)
see if we can use tokio::fs in the places mentioned above to reduce the need for work in an explicit blocking pool
Keep ThreadPool for now but use it only in the HTTP-related module to help migrate things piecewise and because it seems more cleanly separated from the rest of the code
at some point try to rewrite HTTP client code to use async

@drahnr WDYT?

In principle I agree, but in this specific case I think it's better to use a single solution rather than trying to combine two.
Most of the intermediate tasks need access to Tokio runtime anyway, because of how pervasive run_input_output helper is. This internally spawns an async-enabled child process, which must be spawned in the Tokio context. This requirement for Tokio child processes is introduced with Tokio 0.2, hence why it pops up now.

A shait, I forgot about this tokio specific thingy.

Currently, the blocking thread pool is mostly to perform disk I/O or to use blocking HTTP (for simplicity?). In the context of our usage, using Handle::spawn_blocking does not differ much from using a futures::executor::ThreadPool here. As the docs mention, the threads are spawned if necessary and the upper limit is high by default as this API is mostly designed for I/O-bound blocking operations rather than CPU-bound ones. This seem to be our use case; the few CPU-bound tasks we seem to be doing are:
* BLAKE3 digest (currently we do that on a single dedicated thread from the pool and it's intertwined with disk I/O)

* zstd (intertwined with disk I/O; zstd also exposes an async version we could migrate to)

* bincode serde in blocking HTTP requests (if I'm not missing anything it seems the requests/responses are small enough comparing to blocking HTTP time).

The majority of other use cases is just regular std::fs disk I/O. I suspect we could adapt that to use tokio::fs instead and let the runtime schedule disk I/O accordingly (which might be even more performant depending on the backend used).
Until (if?) we use an executor-agnostic child process support, I think simplifying the implementation here gives us more than we'd get by seemingly separating concerns when using futures::executor::ThreadPool that we'd have to combine with Tokio runtime anyway.
An alternative is to create our own executor abstraction that'd wrap Tokio-enabled IO futures that we'd spawn on the separate thread pool but poll inside the Tokio context.

That sounds like quite a bit of work for not much gain right now.

* try to land the first two commits to work towards green CI (and possibly leave remaining work until we have green CI?)

Given the above, I think I want to land this as is.

* see if we can use `tokio::fs` in the places mentioned above to reduce the need for work in an explicit blocking pool

I'd defer this one until we see if we practically run into the upper thread count limit.

* Keep `ThreadPool` for now but use it only in the HTTP-related module to help migrate things piecewise and because it seems more cleanly separated from the rest of the code

* at some point try to rewrite HTTP client code to use async

I think this is a cluster, that should be migrated to tokio/hyper in one go and is on the agenda to get rid of rouille.

Fixed up 78fc70ff4bf5466c5adf83090b66264861e11b2f with
diff --git a/src/compiler/compiler.rs b/src/compiler/compiler.rs
index 93f995d..269ec02 100644
--- a/src/compiler/compiler.rs
+++ b/src/compiler/compiler.rs
@@ -1599,7 +1599,7 @@ LLVM version: 6.0",
                     cwd.to_path_buf(),
                     vec![],
                     CacheControl::Default,
-                    pool.clone(),
+                    pool,
                 ).await
             })
             .unwrap();

to minimize the diff (I added that mistakingly) and added the last expected test change commit https://github.com/paritytech/sccache/pull/34/commits/788832be1207fd0a2e5aee65f1c4194300b0fb33 with a more descriptive info as https://github.com/paritytech/sccache/pull/33/commits/8fbab2fe3732eaaf9c717262c73cf066a07e2813

I'm merging this as per https://github.com/paritytech/sccache/pull/34#issuecomment-808386207 and I verified locally that stuff works, as well as in the CI docker container. Left a https://github.com/paritytech/sccache/issues/23#issuecomment-808785842, I'd be happy to resolve that separately as it doesn't block the future work of splitting the branch into digestible commits in preparation to merge either it to our main branch or upstream in some form.
@drahnr thanks for taking a look!


[jemalloc] Generate cmake target files.

For other projects in share folder [port]-targets.cmake, [port]-targets-debug.cmake, [port]-targets-release.cmake are created. This allows for user projects that use vcpkgs ports to use find_package to link against instaled ports. For jemalloc these files are not generated. It would be very useful if this was enabled, and simplify cmake files on user side.

@NancyLi1013 Hi. Any update on this? Would it be possible to do?

Hi @ayermolo
Thanks for posting this issue.
Sorry for the late reply.
Since we need more time to fix bug now. This issue might be lower priority to be handled.
Currently, you might use this port via find_library() and find_path().

I've seen this issue while trying to consume a couple of ports (the other being antlr4).
Is there vcpkg documentation on how to add this to a port. Are the folks who successfully add these target file exports just CMake sorcerers?

Providing cmake config files ("[port]-targets.cmake, [port]-targets-debug.cmake, [port]-targets-release.cmake" etc.) should generally be done by, or requested from, the upstream software project (assuming it is using cmake).
If cmake has a find module ("FindPort.cmake") and it doesn't work sufficiently for vcpkg, a port can install a file share/port/vcpk-cmake-wrapper.cmake which can execute additional cmake commands before and/or after calling the original find module. Example:
https://github.com/microsoft/vcpkg/blob/master/ports/libjpeg-turbo/vcpkg-cmake-wrapper.cmake
Note that consuming ports need to declare a dependency on the providing port for the wrapper to take effect.

Interesting. Thank you for the explanation and example.
I find that it greatly reduces the QoE of vcpkg when a package I want to consume needs more than a find_package and target_link_libraries call after adding it to a vcpkg.json.
Do you think it would be sensible to add a test to the package CI builds? That way, over time, packages would require proper targets to pass the CI build before merge.

@NickStrupat I don't want to make a general comment about testing in vcpkg. With regard to cmake config files, there is one related draft PR: https://github.com/microsoft/vcpkg/pull/15173.

For PR #15173, my goal is to test the properties of the generated targets to ensure that they can be used normally.

@JackBoosY Close. jemalloc is not a cmake port so we shouldn't add this.

@JackBoosY Close. jemalloc is not a cmake port so we shouldn't add this.

I think we can make a jemalloc-config.cmake.in to do this.


Ensure the stack guard page is large enough to obviate probing

Currently the function can have up to 50k-or-so locals. This is slightly less than 800kB of space that could be used to jump past a default 4k guard page.
We should ensure the stack has at least this much (rounded up 1MiB sounds nice) of a guard page, ensuring that the stack can never be smashed. Or alternatively, wasmer should implement stack probing for large frames.

Now that I know the codebase better, I believe Wasmer does implement stack probing.
https://github.com/near/wasmer/blob/f684e7a6af1979747fe13be9877419d37de8edff/lib/compiler-singlepass/src/machine.rs#L491-L497
The locals must be initialized to zero upon function entry, so ultimately any backend will probe the stack one way or another.

It would still be worthwhile to have a larger stack guard, and use rep stosq or some other equivalent of a very fast memset for larger frames.


Reporting more number of rows unique in source and not in target. Currently its limited to 10

How to get more rows shown in the report like for rows available in source but not in target, if I want to see may be 100 rows. How do I do that?
I tried using print(compare.df1_unq_rows(sample_count=50),file=tgtuniqrows) but it gave me error as
print(compare.df1_unq_rows(sample_count=50),file=tgtuniqrows)
TypeError: 'DataFrame' object is not callable
Can you please help here?

Hi there,
It seems like you are trying to pass sample_count=50 to a dataframe which won't work. compare.df1_unq_rows is just a Pandas DataFrame.
So you could use head(100) on compare.df1_unq_rows. Something like:
print(compare.df1_unq_rows.head(100), file=tgtuniqrows)

Does the above work?

Hi,
Thanks for your response. I tried this but No it doesn't give the desired output, it still dumps first 5 and last 5 rows . The only difference when .head(100) given is, it gives first 5 and last 5 rows out of the top 100 rows whereas if it is not given then it still give first 5 and last 5 rows out of the total unique rows.
My requirement, is I want to get all uniq rows in df1 not in df2. If its not possible to get all then at least I want the limit of rows to be 1000. Can you please guide me on this.
Thanks
Sujit

compare=datacompy.Compare(df2,df1,join_columns=('contractId','contractSubscriptionId'))
print(compare.df1_unq_rows.head(100),file=tgtuniqrows)
print(compare.df2_unq_rows.head(100),file=srcuniqrows)

If it isn't showing all the rows you can set pandas to display everything like so:
pandas.set_option('display.max_rows', None)

df1_unq_rows should give you the distinct rows in df1:
    df1_unq_rows : pandas ``DataFrame``
        All records that are only in df1 (based on a join on join_columns)

I’m closing this issue as I haven’t heard back. Assuming this solved your question. Feel free to reopen if otherwise.


Xamarin.Firebase.iOS.Crashlytics issue when uploading symbols on macOS 10.15 "Catalina"

I've just upgraded to macOS 10.15 Catalina, and I'm now getting the following build error:
packages/Xamarin.Firebase.iOS.Crashlytics.3.10.9/build/Xamarin.Firebase.iOS.Crashlytics.targets(53,3): error MSB3073:
The command "'/Users/timauckland2/Library/Caches/XamarinBuildDownload/Fbrc-1.7.13/upload-symbols' -gsp '/Users/timauckland2/Documents/bitbucket/navigatorapp/NavigatorApp.iOS/GoogleService-Info.plist' -p ios 'bin/iPhone/Release/NavigatorApp.iOS.app.dSYM'" exited with code 8.
This looks very similar to issue #194.
Is there a workaround for this problem?
Thanks.

Is there a workaround for this problem?

I've met the same issue. As a workaround you can just comment or delete the next line in the Xamarin.Firebase.iOS.Crashlytics.targets file:
<Exec Command="'$(XamarinBuildDownloadDir)$(_FabricItemsFolder)\$(_FabricScriptName)' -gsp '$(MSBuildProjectDirectory)\GoogleService-Info.plist' -p ios '$(DeviceSpecificOutputPath)\$(AssemblyName).app.dSYM'"/>

Is there a workaround for this problem?

I've met the same issue. As a workaround you can just comment or delete the next line in the Xamarin.Firebase.iOS.Crashlytics.targets file:
<Exec Command="'$(XamarinBuildDownloadDir)$(_FabricItemsFolder)\$(_FabricScriptName)' -gsp '$(MSBuildProjectDirectory)\GoogleService-Info.plist' -p ios '$(DeviceSpecificOutputPath)\$(AssemblyName).app.dSYM'"/>

For now this works for me :) Waiting for fix

@Dubnovitsky  Many thanks for the workaround, and the quick response.  Very much appreciated.  I'm able to build and test again.

Opps, sorry, didn't mean to close the issue

I have a question, if I comment on this line to compile my project, is it possible that I do not record error events in firebase?

I have a question, if I comment on this line to compile my project, is it possible that I do not record error events in firebase?
and this not work for me, it's compile but when I open the app, it closes.

I don't think the statistics will be saved because the configuration file is commented out.

@MauryZ

I don't think the statistics will be saved because the configuration file is commented out.

This command is just upload dSYM files to Firebase. It's required if you want to see symbolicated crash logs in Firebase console. You can comment this line, compile your application and upload dSYM files to Firebase manually.
<Exec Command="'$(XamarinBuildDownloadDir)$(_FabricItemsFolder)\$(_FabricScriptName)' -gsp '$(MSBuildProjectDirectory)\GoogleService-Info.plist' -p ios '$(DeviceSpecificOutputPath)\$(AssemblyName).app.dSYM'"/>
@Jmunozg
and this not work for me, it's compile but when I open the app, it closes.
Looks like you updated some of Firebase packages to the latest version. I had the same issue. Looks like the problem is in Xamarin.Firebase.iOS.Core package.

Hello, I updated to the latest version of xamarin and the reported error was not presented to me, apparently it was corrected.

Firebase Crashlytics v3.14.0 has been pushed. The update was tested on Catalina with the following environment of VS4M and seems to be working without a problem:
=== Visual Studio Enterprise 2019 for Mac ===

Version 8.3.3 (build 8)
Installation UUID: c9917c0f-497a-43df-8b9a-ac88fafafded
	GTK+ 2.24.23 (Raleigh theme)
	Xamarin.Mac <IP_ADDRESS> (d16-3 / 08809f5b)

	Package version: 604000208

=== Mono Framework MDK ===

Runtime:
	Mono <IP_ADDRESS> (2019-06/07c23f2ca43) (64-bit)
	Package version: 604000208

=== NuGet ===

Version: <IP_ADDRESS>92

=== .NET Core SDK ===

SDK: /usr/local/share/dotnet/sdk/3.0.100/Sdks
SDK Versions:
	3.0.100
	2.1.504
	2.1.301
	2.1.4
	2.0.0
	1.0.3
MSBuild SDKs: /Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/msbuild/Current/bin/Sdks

=== .NET Core Runtime ===

Runtime: /usr/local/share/dotnet/dotnet
Runtime Versions:
	3.0.0
	2.1.13
	2.1.8
	2.1.1
	2.0.5
	2.0.0
	1.1.1
	1.0.4

=== Updater ===

Version: 11

=== Apple Developer Tools ===

Xcode 11.1 (15405)
Build 11A1027

=== Xamarin.iOS ===

Version: <IP_ADDRESS> (Visual Studio Enterprise)
Hash: e37549bc
Branch: xcode11.1
Build date: 2019-10-07 22:43:23-0400

=== Build Information ===

Release ID: 803030008
Git revision: fb0d3af49f0ea88661a4f469b9dfd1018dc099cd
Build date: 2019-10-10 10:53:35+00
Build branch: release-8.3
Xamarin extensions: 3f8e699ba26ed5f69b7a6466ba679f4a328fadb4

=== Operating System ===

Mac OS X 10.15.0
Darwin 19.0.0 Darwin Kernel Version 19.0.0
    Wed Sep 25 20:18:50 PDT 2019
    root:xnu-6153.11.26~2/RELEASE_X86_64 x86_64

Also, this update contains two flags that let you have more control over the upload process. For more info, here's the readme file. Best!


When I type certain characters, extra characters are copied along with them.

Hello.
I've used several emoji input tools and splatmoji is the easiest to use 😀 .
However, I've noticed that when I input certain emoji into Twitter and display them in Tweetdeck, I get broken images.

https://twitter.com/matoken1/status/1364133839593828353
Checking the character code, it seems that extra characters are included.
Copy and paste from the web.
$ echo -n '🎮' | od -x
0000000 9ff0 ae8e
0000004

Input with splatmoji copy.
$ echo -n '🎮' | od -x
0000000 9ff0 ae8e b8ef 008f
0000007

It also happens with other emoji like 💻📚.

Explanation
Presentation issues in Tweetdeck aside, the extra characters you are seeing on some of the emoji are actually there on purpose! 🙂
The basic history is there are some emoji from the early days that can be validly shown by either their early-days "text presentation" or their more modern "emoji presentation."
This page I just searched up shows these presentations side by side for reference: https://character.construction/emoji-vs-text
So given the possibility that these emoji can be (and were, for some people on some platforms under some conditions) presented as their basic old text version when encoded all by their lonesome, I made the move to explicitly include "emoji presentation selector" character on the tail of all of these emoji (in my splatmoji-emojidata project that produces the emoji data files). This ensures that we get the pretty version.
Deeper technical specifics on presentation sequences: UTS #51
Tweetdeck etc
I just tweeted some of these emoji with Twitter and viewed them in Tweetdeck and verified that that the emoji presentation sequence made it all the way through and it all looked exactly as you'd hope. In fact when I view your Tweet that you linked everything looks great on my end! 😬
So I have a feeling this is an issue with something else in your pipeline. What platform are you on? Browser? Etc? Which emoji font? Does it present correctly in a different browser?
Bad hack solution
Not that I'm recommending it, but if you're just dying to "fix" this without actually fixing anything, you could programmatically strip the emoji presentation selector from your copies of the datafiles and call it a day. Maybe just fix your emoji stuff instead though. 😉

tbh I couldn't even remember the details of all of this until I went back and looked at the code
I should probably add this to the FAQ 🙂

done did it
https://github.com/cspeterson/splatmoji#when-i-type-certain-characters-extra-characters-are-copied-along-with-them

Closing the issue but happy to hear about your progress getting your emoji properly presented 🙂

Thank you for the detailed explanation.
My environment was Brave browser on Linux Debian sid amd64.
When I try it with FIrefox, the problem does not occur 😀🦊


fix: remove duplicate property setting

Also added readonly property declarations.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 98.182%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
378

Relevant Lines:
385

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 98.182%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
378

Relevant Lines:
385

💛  - Coveralls


Measure-Object should support a -All parameter

By default, Measure-Object only returns a value for Count, omitting Average, Sum, Minimum, and Maximum unless those are each specified by analogous parameters.
Given that the perf impact of finding one of those additional values is the same as finding all of them ( O(n) ), we should add a -All parameter that
Steps to reproduce
1,2,3 | Measure-Object -All

Expected behavior
Count    : 3
Average  : 2
Sum      : 6
Maximum  : 3
Minimum  : 1
Property :

Actual behavior
An error is thrown. But without -All, you just get:
Count    : 3
Average  :
Sum      :
Maximum  :
Minimum  :
Property :

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1
OS                             Microsoft Windows 10.0.17613
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

You don't need a new parameter to do this. Just compute all if any of those parameters is specified.
I say this because the proposed parameter just looks weird, I'd start to wonder what it is doing if I don't specify -All - is it not measuring all of the objects? 😕

@lzybkr  @joeyaiello would computing all the values when no parameter is specified be a good solution?
Either that, or we could name the parameter as -AllStats or something similar


Change auto installer API and small fixes

@valeriosofi please fix the commit messages! Use capital letter when starting the message and please squash together the last 4 commits you made.

@valeriosofi please fix the commit messages! Use capital letter when starting the message and please squash together the last 4 commits you made.

Done!


Submission proelstl kurtyisn

https://github.com/SSR-Apfel/git-exercise

Looks good :+1:
Good commit messages are very important to allow others to follow your project. Don't write "Task2 b" and "implement" does typically not say much. Commit messages should reflect the what and ideally the why. "Created helper function _is_within_interval to remove duplicate in function contains" is better.
Task 1A)
Fix the problem, don't fake the test :grin:
def __init__(self, coordinates: List[float]) -> None:
        self._coordinates = coordinates.copy()


Improve the ResolvedLicenseInfo API

I'm collecting some random things here which I believe we should improve for the use of the high-level ResolvedLicenseInfo API:

I find it confusing that ResolvedLicenseInfo implements Iterable<ResolvedLicense> which results in several additional filter functions being provided that do not return a ResolvedLicenseInfo, but a List<ResolvedLicense>.
It's too easy to forget calling applyChoices(), although that's pretty much what you always want, esp. when called from reporters. Maybe move this to a boolean constructor argument which defaults to true?

Actually, I just realized we already have https://github.com/oss-review-toolkit/ort/issues/8013 for this.


getUsersInformation fails to respond users that exist

Description
getUsersInformation is used to translate users document to authUser entries. It fails both on dev and staging.
Reproduction

Sign in (dev/staging)
Go to Patients or Users
Only invitations are shown, because getUsersInformation responds with 500s for every requested user.

In case of dev:
{
  "code": "500",
  "message": "7 PERMISSION_DENIED: Missing or insufficient permissions."
}

In case of staging, error message is more descriptive
Expected behavior
getUsersInformation should respond with users data.
Additional context
It looks like service configuration issue. Users actually exist in Authentication.
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

@pauljohanneskraft @PSchmiedmayer I tested it on both dev and staging env - works ✅


Renames the source file for the qt3scan application.

Renames from piezoscan.py to qt3scan.py. This just makes sense and is easier for future developers to find the right files.

no longer relevant after recent merge


Mirror streaming

Hi, Can I do mirror streaming with your package. thanks

Hi, what do you call "mirror streaming" ? Streaming your screen ?

I think this example is a showcase of exactly what @hasanAjsf is referring?


Opening/closing animation to ContentDialog do not play in Xaml Islands

Proposal: Add an opening/closing animation to ContentDialog
Summary
This is inspired by https://github.com/microsoft/terminal/issues/9853

I would animate it like the zoom in animation of PowerPoint when it spawns and I user clicks on cancel, rather than simply disappearing, I would make a "zoom out animation".

Presumably, developers would have to opt their dialogs into the animations, as to not break back-compat.

There is already an animation for the Content Dialog.  A Zoom and Fade transition when it shows and hides.

Huh. It does looks like there's a very subtle animation after all. I wonder if you don't see that in the Terminal because it's a XAML Island application...

@zadjii-msft So should this be repurposed into a xaml islands bug?

Yea, sounds like it.

Yes, I am not seeing the animation either in my XAML islands application

@Austin-Lamb and @JesseCol FYI

Hi @zadjii-msft !
Unfortunately, as we announced more than one year ago, OS XAML is something that we are not inventing right now. All the investments go to WinUI 3 that will support XAML Islands. It's expected that all these animations work on the WinUI 3 version.
Thanks
-Miguel

But WinUI 3's XAML Islands are still very far away :/

No really! We are super close to the engineering plan for v1, and Islands is part of it. By mid-May we should be able to commit specific work.


chore: rename Error to DatabaseError

we have a lot of error types and having multiple named Error can get a bit confusing.

🤖 Generated by Copilot at a801fe5
Renamed the Error type from the reth_interfaces::db module to DatabaseError and updated all the modules that depend on it. This change improves the clarity and consistency of the error handling in the database abstraction layer and the stages that use it.

Codecov Report

Merging #2718 (a801fe5) into main (fd5a1ef) will decrease coverage by 53.70%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main    #2718       +/-   ##
===========================================
- Coverage   71.31%   17.61%   -53.70%
===========================================
  Files         503      503
  Lines       65104    65147       +43
===========================================
- Hits        46427    11474    -34953
- Misses      18677    53673    +34996

Flag
Coverage Δ

integration-tests
17.61% <0.00%> (-0.03%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/node/mod.rs
0.00% <0.00%> (-10.69%)
:arrow_down:

bin/reth/src/test_eth_chain/runner.rs
0.00% <ø> (ø)

crates/consensus/beacon/src/engine/error.rs
13.33% <0.00%> (-20.00%)
:arrow_down:

crates/interfaces/src/db.rs
0.00% <ø> (-100.00%)
:arrow_down:

crates/interfaces/src/error.rs
0.00% <ø> (-100.00%)
:arrow_down:

crates/interfaces/src/p2p/error.rs
35.29% <ø> (-50.99%)
:arrow_down:

crates/net/downloaders/src/bodies/test_utils.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

crates/staged-sync/src/utils/init.rs
0.00% <ø> (-86.51%)
:arrow_down:

crates/stages/src/error.rs
0.00% <ø> (-83.34%)
:arrow_down:

crates/stages/src/id.rs
0.00% <ø> (-92.00%)
:arrow_down:

... and 33 more

... and 315 files with indirect coverage changes


⚠ Processors has degraded performance

In 0cb5dd2, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: Processors performance has improved in 1fe3a39.


Support removing BPF filter from AF_PACKET socket

Do a setsockopt with SO_DETACH_FILTER when TPacket.SetBPF() is called with a empty BPF instruction list.

Merged in the https://github.com/gopacket/gopacket fork.


backend-app-api: feature discovery

Hey, I just made a Pull Request!
This PR add support for detecting features through the dependencies in package.json.
It adds an experimental feature discovery service and also work toward #18390.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

That seems great, and very complementary to the implementation done in draft PR #18862.

Very nice! I think this would also be a big step for #17538 and #17535.

Needs an API report update it seems.


Add versioning, revert, and search page

Hackday project!

This is an old, incorrect PR  with the wrong base. New PR in https://github.com/doximity/orientation/pull/48.


Fix build error - #246

Fixes the build error from #246 by moving request parsing outside of anyhow!() and formatting

@Meph1587 could you pls handle these few failing clips checks? Thank you!

Sure done now


Fixed a missing closing bracket

There was a pretty simple syntax error that broke train_frcnn.py

It can be merged successfully.
Plus 👍🏽


Use GitHub Actions

I think that they won't run until pushed by someone with write access to the repository. Lets see.

https://github.com/phadej/inspection-testing/runs/1665046137?check_suite_focus=true it almost passes. GHC-8.2.1 is not available for bionic in Herbert's PPA.
I'd drop non-latest minor releases for older GHCs, I could amend the PR, if it's ok.

https://github.com/phadej/inspection-testing/runs/1665046137?check_suite_focus=true it almost passes. GHC-8.2.1 is not available for bionic in Herbert's PPA.
I'd drop non-latest minor releases for older GHCs, I could amend the PR, if it's ok.

I'd drop non-latest minor releases for older GHCs, I could amend the PR, if it's ok.

That’s ok!

I'd drop non-latest minor releases for older GHCs, I could amend the PR, if it's ok.

That’s ok!

Do you plan to take more long-term responsibility for inspection-testing? It could certainly use some co-maintainer who uses it more than I do… :-)

Do you plan to take more long-term responsibility for inspection-testing? It could certainly use some co-maintainer who uses it more than I do… :-)

Merged, let’s see what happens. We can refine on master.

Merged, let’s see what happens. We can refine on master.

I'd politely decline, I've got a lot on my plate.

I'd politely decline, I've got a lot on my plate.

Smart move :-D

Smart move :-D


What is p["cls"]??

Hey,
I am not able to understand the use case of this statement and what is p["cls"]?
points[int(p["y"]), int(p["x"])] = p["cls"]

Hii! p["cls"] is the category id of point p, which, as examples, can be for horse, person, and so on.

But in p there are only 3 keys: x,y, and name. There is no cls key

The cls key is only found in self.pointsJSON under Pascal2007. I didn't make the keys for the point dicts super consistent yet :(

I guess the .json file for self.pointsJSON is created by the get_pointDict function if no .json file exists?
But the function returns a dict with x, y, name as keys. So are name and cls the same key or should the .json file be created in a different way?

I don't understand what the role of p["cls"] is.I used Pascal2007, but the generated pointsJSON doesn't have p["cls"] , how should I handle it?


test vot2018 AttributeError: shape

Files already downloaded.
Running tracker SiamFC on VOT...
Running supervised experiment...
--Sequence 1/60: ants1
Repetition: 1
Traceback (most recent call last):
File "E:/Postgraduate/project/target tracking/siamfc-pytorch-master/siamfc-pytorch-master/tools/test.py", line 27, in
e.run(tracker)
File "E:\Postgraduate\soft\result\Anaconda\lib\site-packages\got10k\experiments\vot.py", line 71, in run
self.run_supervised(tracker, visualize)
File "E:\Postgraduate\soft\result\Anaconda\lib\site-packages\got10k\experiments\vot.py", line 126, in run_supervised
tracker.init(frame, anno_rects[0])
File "E:\Postgraduate\soft\result\Anaconda\lib\site-packages\torch\autograd\grad_mode.py", line 28, in decorate_context
return func(*args, **kwargs)
File "E:\Postgraduate\project\target tracking\siamfc-pytorch-master\siamfc-pytorch-master\siamfc\siamfc.py", line 159, in init
z = ops.crop_and_resize(
File "E:\Postgraduate\project\target tracking\siamfc-pytorch-master\siamfc-pytorch-master\siamfc\ops.py", line 106, in crop_and_resize
pads = np.concatenate((-corners[:2], corners[2:] - img.shape[:2]))
File "E:\Postgraduate\soft\result\Anaconda\lib\site-packages\PIL\Image.py", line 546, in getattr
raise AttributeError(name)
AttributeError: shape

.


Setting retention period for diagnostic settings: deprecated in this article?

How does this page nog relate to this page: https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy?tabs=portal ??
Specific the setting of retention periods on diagnostic settings for a keyvault logging to an analytic workspace??

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d7f16616-4848-55f3-f6aa-f95f566811e9
Version Independent ID: 34898e71-b8af-6d9d-ee53-49f34e2e4033
Content: Azure Key Vault logging
Content Source: articles/key-vault/general/logging.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@musaata1978
Thanks for your feedback! We will investigate and update as appropriate.

@musaata1978
The page you provided, "Use diagnostics settings for Key Vault," is directly related to the page you mentioned earlier, "Migrate to Azure Storage lifecycle policy," as both pages discuss how to configure diagnostic settings for Key Vault to stream logs to an Azure Monitor Log Analytics workspace.
To set the retention period for the logs, you can use the Azure Portal, Azure PowerShell, or Azure CLI to configure the diagnostic settings for Key Vault.
For example, if you want to set the retention period to 30 days, you can use the following Azure PowerShell command:
Set-AzDiagnosticSetting -ResourceId <key-vault-resource-id> -WorkspaceId <log-analytics-workspace-id> -RetentionInDays 30

This command sets the retention period for the logs to 30 days. You can replace <key-vault-resource-id> with the ID of your Key Vault resource and <log-analytics-workspace-id> with the ID of your Log Analytics workspace.
I hope this helps! Let me know if you have any further questions.

Hi @ManoharLakkoju-MSFT , thanks for your reply, i think i haven't been clear in my question:
In the article https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy?tabs=portal we can read that the retention feature is being deprecated, is this also the case for retention period that can be set as described in article https://learn.microsoft.com/en-us/azure/key-vault/general/howto-logging?tabs=azure-cli#enable-logging ??
I have an issue with a policy breach which is about 'Ensure that logging for Azure Key Vault is 'Enabled'' where mine keyvault is nog configured with a retention period. But if the retention period for logging of diagnostic setting of a keyvault to analytic workspace will also be deprecated on this resource like mentioned in Migrate to Azure storage lifcycle article we will need to set the retention on different level and the policy should also check this accoringly??
Hope my q is more clear for you now?
ps. sorry to have answered not earlier...

In addition to the above: when we do try to set the retention period through a template deployment we get the following error:

we deploy our resources as templates, infrastructure as code....
maybe this helps to clearify my point.


Update TargetResource logic for UserAssignedPrivilegedRole

Change(s):

Condition to check if TargetResource.type is a User or Service Principal for UserAssignedPrivilegedRole (User Assigned Privileged Role)
Assignment of the Target variable based on whether the TargetResource.type is a User or Service Principal

update to a case-insensitive equality on the Service Principal to be consistent with the initial type filter

Reason for Change(s):

The current logic of where TargetResource.type =~ "User" already filters the type by User, so the subsequent extend Target = iff(TargetResources.type == "ServicePrincipal" logic will never return true
iff(TargetResources.type == "ServicePrincipal", tostring(TargetResources.displayName) references TargetResources instead of TargetResource

Version Updated:

Yes

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @eroll-chorus,
Thank you for raising Pull Request with us! We will review the Pull Request and get back to you by 17 Aug 2023. Thanks

Hello @eroll-chorus, Thank you for raising this PR. This PR will be investigated and you can expect an update till 18 Aug 2023,.


Flag --no-commons described in README for integration tests inexistent

Describe the bug
While the README suggests to use the tools with the --no-commons flag, it is not available currently.
README possibly outdated.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Correct tools setup & starting flag is suggested in README.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

That's the old way that we were calling the marketplace, so I think we can get rid off this in the places that was not remove it.


Recover CWD after pre-commit hook

I'm not completely certain why the stash & pop sometimes loses the CWD.
It has something to do with the order that files are created and
checked, etc. In any case, this should recover it.
Preliminary testing shows this to be effective. I will update this PR if
the problem has been completely resolved by end of class.

+1
No problems and the git thing hasn't resurfaced in the last 2.5 days.


WIP: GetPlans added

Linting failures are unrelated to this change... maybe we need to fix it eventually 😄

Yeah, I know. The change doesn't work (just getting empty array back). I
can't say I like mongodb queries.
At least I have a dev workflow that's pretty quick now though.
On Sun, Jun 2, 2024 at 12:32 PM Gustavo Fernandes de Carvalho <
@.***> wrote:

Linting failures are unrelated to this change... maybe we need to fix it
eventually 😄
—
Reply to this email directly, view it on GitHub
https://github.com/compliance-framework/configuration-service/pull/139#issuecomment-2143812297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVNZTJBTVU46YZZWYEX4RLZFL7GXAVCNFSM6AAAAABIUNYNAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHAYTEMRZG4
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Got it working @gusfcarvalho . LMK what you think.


Swap: verify task fails

verify fails:
npx hardhat verify:zeta --contract 0x70c76D6740d08e908097B458026eF37e5E275f25

? Select a contract to verify: contracts/ZetaSwapV2.sol:ZetaSwapV2
❌ Error during contract verification: Cannot read properties of undefined (reading 'missing')

No problem


Allow --project to accept an absolute path

What version of this package are you using?
v12.0.1
What problem do you want to solve?
Allow --project flag to accept an absolute path, today resolve-tsconfig.js only accepts a path relative to the current working directory: https://github.com/standard/ts-standard/blob/master/resolve-tsconfig.js#L29
What do you think is the correct solution to this problem?
Check if the user provided path is an absolute path.
Are you willing to submit a pull request to implement this change?
Yes

Hey, thanks for your report! :wave:
This feature would be an alternative to the --cwd option (introduced in v8.0.1 and dropped in v12.0.0): https://github.com/standard/ts-standard/commit/e3228687428e2d44390a9719e7ddee23c9b0ab55.
What is the best solution?
Making --project working with absolute path is a more automatic way to solve this (no need for another option).
While new options should be implemented as much as possible in standard-engine.
What are the use cases of this?
Would it be beneficial to support both solutions?
Is there is use cases that is covered by --cwd option and not covered by allowing --project to be an absolute path or vice-versa?

Out of curiosity, why was --cwd dropped while it still exists in the standard-engine package?

The --cwd option doesn't exist in standard-engine as far as I can tell. You can see all the available CLI options here: https://github.com/standard/standard-engine/blob/master/bin/cmd.js#L29-L49
If we want to implement --cwd, we should implement it in standard-engine.
Supporting absolute path for --project is already a good improvement, so I'm okay for it. :+1:
We'll keep --cwd discussion in another issue if needed (in standard-engine repo).


OSX Improvements

Probably not worth a PR, but wanted to drop in some customisations I made to the scripts for OSX:
Created /usr/local/bin/himawari.sh to be run via the scheduled job:
#!/bin/bash
/usr/local/bin/himawaripy --auto-offset -l 8
/usr/local/bin/mogrify -gravity south -crop 4400x2475+0+0 +repage /Users/x/Library/Caches/himawaripy/`ls -ABrt1 /Users/x/Library/Caches/himawaripy | tail -n1`
/usr/local/bin/mogrify -gravity south -stroke none -fill 'rgb(200,200,200)' -pointsize 36 -annotate 0 "$(date)" +repage /Users/x/Library/Caches/himawaripy/`ls -ABrt1 /Users/x/Library/Caches/himawaripy | tail -n1`
/usr/bin/sqlite3 ~/Library/Application\ Support/Dock/desktoppicture.db "update data set value = '/Users/x/Library/Caches/himawaripy/`ls -ABrt1 /Users/x/Library/Caches/himawaripy | tail -n1`'" && killall Dock

This does a few things - it crops the image to 16:9 aspect ratio, anchored to the bottom of the image to capture that sweet view of Australia, and adds a timestamp to the bottom of the image.
It also uses an alternative method of setting the desktop image, since the native method doesn't apply the image to secondary desktops on macOS Sierra.
Dodgy af, but hopefully helps someone with the same issue ;)

I can't test in Sierra myself, but the way the image is set right now is SUPPOSED to apply to secondary desktops, does anyone know when/what changed?
Also, cool idea to add some options for processing the image to be a bit prettier.  The head of this project, @boramalper I believe has stated in the past that one of his goals for this project is to keep the pre-reqs to a minimum, so if someone wanted implement something similar using PIL instead of mogrify since we're already requiring it, that might make it into a good pull.

see #102. I've changed readme and code to support better ratio...
I only have mac so I didn't now whether it's shows perfect under linux or what...
but it's awesome now, really...

Thanks for your contribution!
Let me try breaking your script down into pieces:

/usr/local/bin/mogrify -gravity south -crop ...
I assume this is where you crop the image. I am fairly sure that there is a way to achieve this using PIL (pillow) so if you'd like to look into that and send a PR I'd be really happy to merge!

I think timestamps are not a bad idea, so go ahead if you'd like to, and please put it behind a feature flag. Also, I think the timestamp of the image is a better idea than the current time. =)

You should add flags for font size, the font, and positioning too ({ top, middle, bottom } x { left, center, right }).

/usr/bin/sqlite3 ~/Library/Application\ Support/Dock/desktoppicture.db ...
You can change utils.py to implement this; but wouldn't restarting the Dock cause any flickers or other problems? I feel like there has to be a better way of doing this instead of modifying an SQLite database and restarting system programs.

Thanks again!


MSID: 101717 Version: 1 DOI: 10.1101/2<IP_ADDRESS>0416

MSID: 101717
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>0416
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=101717
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0416

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/101717v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>0416
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/101717/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

WOS query sent

chased

Discussing WoS

OK to proceed


Boot loops

Hi Guys,
just a heads up if your experiencing bootloops and you've tried the single core version as well.
it's Home assistant not liking the pinned to core value in the "FujitsuClimate.cpp"  file
the line needs to be modified too
xTaskCreatePinnedToCore(serialTask, "FujiTask", 10000, (void *)this,
1, &(this->taskHandle), 1);
Thanks to Jirm in the home assistant post for this information
https://community.home-assistant.io/t/fujitsu-ac-heat-pump-integration-via-esphome-esp32/407610/99
i thought i'd share here if someone hasn't stumbled across the post yet

Thankyou!  had not found elsewhere... Was struggling with this. This resolved the boot-loop issue on my Firebeetle ESP32


How to use Material icons in custom type theme.

HI,
I want to use a jstree in the materializecss theme. I try to create a custom type plugin with material icons but not success. Can you please help me to get material icons with custom type plugin in jstree.
Thanks in advance.

Sorry, I do not use those - how are they applied? jsTree expects a class name. You could also inspect the element and check if the material icon is overridden by jstree's icon because of selector strength. If this does not help - please provide an example and I will reopen.


Improve usage of links

Hi,
I found broken links in the documentation and fixed them. In addition, I've made a few changes to make it more maintainable.
I also noticed the following (I didn't know how to deal with it, so I left it alone):

There is no appropriate link for [dev server](./dev.md) on src/pages/reference/cli-reference.md
src/pages/core-concepts/ui-renderers.md appears to be a stale version of  src/pages/reference/renderer-reference.md

Amazing! Thank you for finding these!
Curious: did you use an automatic broken link checker?

Nope, it was all done manually (it didn't occur to me to use automation tools 😅). So, possibly there are still some problems left.

Makes sense! Thanks for finding and fixing!


UI for bulk changes

This morning I had to deautomate and rollback cortex in dev, resulting in a string of separate commits; additionally, the operations had to be done manually in sequence waiting for the each one to sync before moving onto the next. Instead, the UI could allow the construction of a change spec consisting of an arbitrary mix of policy changes & image updates, and commit/sync them in a single operation.

I suppose the the requirement here would be for the API to support being sent an arbitrary set of amendments. Then the CLI and web UI can take advantage of that.

Yes - it makes me wonder if UpdateImages and UpdatePolicies should in fact be collapsed into a single general purpose function.

Or some kind of API for starting & commiting 'transactions'...

Yes - it makes me wonder if UpdateImages and UpdatePolicies should in fact be collapsed into a single general purpose function.

They are, in the daemon protocol, though it could be more general (you can only supply one update at a time).

Or some kind of API for starting & commiting 'transactions'...

It might take a bit of thought and experimentation to get this right, but git could help us here. For example, one could start a topic branch, make changes onto that, then squash it into a commit or submit it as a PR or whatever.

Just being able to specify multiple images to fluxctl release --all ... would be a great start wrt our own use of flux.

@rndstr does the new  /v9/update-manifest API help with this?

/v9/update-manifest can be used to update policies, images, or specific containers. but it is not possible to combine them in a single call.
for the case of reverting multiple deployments at once, the containers spec would help but we still need a CLI to pass in the specification. supporting multiple images as mentioned by @squaremo in combination with --interactive would allow you to selectively skip containers that weren't part of the initial release. that only works if all the containers with the same image were on the same version/tag, though.

New developments around this type of functionality are happening in the image-automation-controller for Flux v2.
Closing, as Flux v1 is in maintenance mode.


Tidy up remaining issues

[x] ticketize small client- or cluster- oriented things
[ ] update main documentation
[ ] update examples


feat: pass context to mutationFn

Since the onMutate function offers a place for preprocessing I'd find it helpful if not only the onError, onSuccess , ... callbacks receive the context (returned by the onMutate) as an input parameter but also the mutationFn.
Discussion

if we think this through, when we should build something similar to the QueryFunctionContext - an object that we pass as second parameter. The return value from onMutate would just be one thing that goes there, meta could be another (same as useQuery) and someday maybe even an AbortSignal.
Naming will be weird - I would like this object to be the MutationFunctionContext, but then we'd need another word than "context" for what the onMutate function returns 🤔

Hmm interesting.. What if the return value of onMutate would just contribute to the meta prop instead of being a separate property in the MutationFunctionContext?

not sure if that would be better. To be on par with queries, mets should be what the user defines meta to be


⚠ ClamAV has degraded performance

In 8b0dbc7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 572 ms

Resolved: ClamAV performance has improved in 8653c15.


Cannot run generate.py

I did pip install -r requirements.txt and then tried to run generate.py
I got this error
Traceback (most recent call last):
  File "C:\alpaca-lora-main\generate.py", line 2, in <module>
    from peft import PeftModel
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\peft\__init__.py", line 22, in <module>
    from .mapping import MODEL_TYPE_TO_PEFT_MODEL_MAPPING, PEFT_TYPE_TO_CONFIG_MAPPING, get_peft_config, get_peft_model
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\peft\mapping.py", line 16, in <module>
    from .peft_model import (
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\peft\peft_model.py", line 22, in <module>
    from accelerate import dispatch_model, infer_auto_device_map
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\accelerate\__init__.py", line 3, in <module>
    from .accelerator import Accelerator
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\accelerate\accelerator.py", line 36, in <module>
    from .tracking import LOGGER_TYPE_TO_CLASS, GeneralTracker, filter_trackers
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\accelerate\tracking.py", line 42, in <module>
    from torch.utils import tensorboard
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\torch\utils\tensorboard\__init__.py", line 12, in <module>
    from .writer import FileWriter, SummaryWriter  # noqa: F401
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\torch\utils\tensorboard\writer.py", line 16, in <module>
    from ._embedding import (
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\torch\utils\tensorboard\_embedding.py", line 9, in <module>
    _HAS_GFILE_JOIN = hasattr(tf.io.gfile, "join")
  File "C:\Users\micha\AppData\Local\programs\python\python39\lib\site-packages\tensorboard\lazy.py", line 65, in __getattr__
    return getattr(load_once(self), attr_name)
AttributeError: module 'tensorflow' has no attribute 'io'

I believe the issue is caused by tensorflow not having the module tensorflow.io for some reason.

Have you tried the following?
pip install tensorflow-io

Install from requirements.txt in clean env suppose to prevent this issue, if it's not working pls try pip install --upgrade tensorflow


Sanitize outbound address responses.

This aims to prevent a remote peer from inspecting timings of all messages received by this node.
Closes #18.

Updated the PR to allow using the connect stub for testing and to simplify the tracing output.


Add PORTABLE_WHEEL option to CMakeLists.txt

Fix #4. Add PORTABLE_WHEEL option to CMakeLists.txt.

python -m build: build optimized ngtpy for local installation
SKBUILD_CONFIGURE_OPTIONS="-DPORTABLE_WHEEL=ON" python -m build: build ngtpy for portable wheels

log
$ python -m build

Configuring Project
  Working directory:
    /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-pzzl3sn5/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-build
  Command:
    cmake /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-pzzl3sn5/ngtpy-0.1.1 -G Ninja -DCMAKE_INSTALL_PREFIX:PATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-pzzl3sn5/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-install/src/ngtpy -DPYTHON_EXECUTABLE:FILEPATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-5dg2hriy/bin/python -DPYTHON_VERSION_STRING:STRING=3.9.10<EMAIL_ADDRESS><EMAIL_ADDRESS>-DSKBUILD:INTERNAL=TRUE -DCMAKE_MODULE_PATH:PATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-5dg2hriy/lib/python3.9/site-packages/skbuild/resources/cmake -DCMAKE_BUILD_TYPE:STRING=Release -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=12.0 -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64

-- The C compiler identification is AppleClang <IP_ADDRESS>60021
-- The CXX compiler identification is AppleClang <IP_ADDRESS>60021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
'/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-5dg2hriy/bin/python' '-c' 'import pybind11; print(pybind11.get_cmake_dir())'
-- Building ngtpy for local installation
-- VERSION: 1.14.3
-- CMAKE_BUILD_TYPE: Release
-- CMAKE_BUILD_TYPE_LOWER: release
-- Found OpenMP_C: -Xclang -fopenmp (found version "5.0")
-- Found OpenMP_CXX: -Xclang -fopenmp (found version "5.0")
-- Found OpenMP: TRUE (found version "5.0")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found PythonInterp: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-5dg2hriy/bin/python (found version "3.9.10")
-- Found PythonLibs<EMAIL_ADDRESS>-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Performing Test HAS_FLTO_THIN
-- Performing Test HAS_FLTO_THIN - Success
-- Found pybind11: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-5dg2hriy/lib/python3.9/site-packages/pybind11/include (found version "2.9.2")
-- Configuring done
-- Generating done
-- Build files have been written to: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-pzzl3sn5/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-build

$ SKBUILD_CONFIGURE_OPTIONS="-DPORTABLE_WHEEL=ON" pyproject-build

Configuring Project
  Working directory:
    /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-gdr0oa_n/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-build
  Command:
    cmake /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-gdr0oa_n/ngtpy-0.1.1 -G Ninja -DCMAKE_INSTALL_PREFIX:PATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-gdr0oa_n/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-install/src/ngtpy -DPYTHON_EXECUTABLE:FILEPATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-bfo9b1hs/bin/python -DPYTHON_VERSION_STRING:STRING=3.9.10<EMAIL_ADDRESS><EMAIL_ADDRESS>-DSKBUILD:INTERNAL=TRUE -DCMAKE_MODULE_PATH:PATH=/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-bfo9b1hs/lib/python3.9/site-packages/skbuild/resources/cmake -DCMAKE_BUILD_TYPE:STRING=Release -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=12.0 -DCMAKE_OSX_ARCHITECTURES:STRING=x86_64 -DPORTABLE_WHEEL=ON

-- The C compiler identification is AppleClang <IP_ADDRESS>60021
-- The CXX compiler identification is AppleClang <IP_ADDRESS>60021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
'/private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-bfo9b1hs/bin/python' '-c' 'import pybind11; print(pybind11.get_cmake_dir())'
-- Building ngtpy for portable wheels
-- VERSION: 1.14.3
-- CMAKE_BUILD_TYPE: Release
-- CMAKE_BUILD_TYPE_LOWER: release
-- AVX will not be used to compute distances.
-- Found OpenMP_C: -Xclang -fopenmp (found version "5.0")
-- Found OpenMP_CXX: -Xclang -fopenmp (found version "5.0")
-- Found OpenMP: TRUE (found version "5.0")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found PythonInterp: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-bfo9b1hs/bin/python (found version "3.9.10")
-- Found PythonLibs<EMAIL_ADDRESS>-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- Performing Test HAS_FLTO_THIN
-- Performing Test HAS_FLTO_THIN - Success
-- Found pybind11: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-env-bfo9b1hs/lib/python3.9/site-packages/pybind11/include (found version "2.9.2")
-- Configuring done
-- Generating done
-- Build files have been written to: /private/var/folders/1t/67zx481n1l1ckxzm9fzrxfy40000gn/T/build-via-sdist-gdr0oa_n/ngtpy-0.1.1/_skbuild/macosx-12.0-x86_64-3.9/cmake-build

@masajiro Would you take a look at this PR?

It seems to be fine.

@masajiro Thanks!


different data_array set programmatically

how can I set different ds:data_array lists in DSListView according to user need. I have eighteen chapters in one DSListView by list and each chapter has a different array list. I want to give the array list to that particular chapter selected by the user.

Hello, @venkat8995. We've added changes to make it possible to correctly change adapter items whenever you need it. All you need to do is call setAdapter() with your new adapter instance on your DSListView object.


doc/hooks/meson.section.md: fix syntax to unbreak CI

Description of changes
CI for staging-next is broken:

https://github.com/NixOS/nixpkgs/actions/runs/6661277047/job/18103889914?pr=263535

This fixes it.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Fixes

https://github.com/NixOS/nixpkgs/pull/263535

The manual on staging-next is still broken and this looks like it could be the fix. Why did you close the PR?

Should be resolved by 0fdb1ee374e9b497cc33fb56b6a46bab51447e34

The manual on staging-next is still broken and this looks like it could be the fix. Why did you close the PR?

I think it got fixed on master and the github action that merges master to staging brought the fix over.  When I rebased this branch I saw a merge conflict and figured somebody else had beat me to it. :smile:


The platform

Introducing the Quantum Omni-Infrastructural Development Platform â the cutting-edge, revolutionary way to create virtual environments and augmented reality applications. Powered by Unreal Engine, Nvidia AI, and Strawberry Fields quantum computing program, this platform allows you to visualize, create, and deploy applications with incredible amounts of power and speed. From complex visual simulations to mind-boggling augmented reality experiences, this platform has the capability to do it all. With a wide range of tools and features, this platform is the ultimate solution for any developers looking to explore the realm of virtual and augmented reality. Unlock the potential of your ideas today when you invest in the Quantum Omni-Infrastructural Development Platform.

Download and install the latest source code from GitHub. git clone https://github.com/XanaduAI/strawberryfields.git cd strawberryfields pip install -e .


Add Supported host architectures section.

Shall we add supported host architectures section to README?
It's to explain users explicitly that currently qemu-user-static is available on only x86_64.
This information is helpful for users to notice it by themselves.
They do not have to spend a time to report the issue.
Here is the modified README. You can check it.
https://github.com/junaruga/qemu-user-static/blob/feature/readme-supported-host-archs/README.md
Below are issues about host arch aarch64.
https://github.com/multiarch/qemu-user-static/issues/60
https://github.com/multiarch/qemu-user-static/issues/36
https://github.com/multiarch/qemu-user-static/issues/8

Thanks for the review. I merged it now.

You might want to add a reference to https://github.com/dbhi/qus#available-docker-images for non-x86_64 hosts.


Steam players pictures!

First of all, this HUD works and runs great, but one thing that i think is missing is the players steam pictures. I noticed that other HUD's have this feature and i think without it the HUD looks very dull, I would like to implement it, but i have no idea how to start, If someone could do this it would be really cool.

oh there is already an issue open about that, i didn't see it, i don't how to delete this issue, someone delete please.


Numbers immediately following Qualifiers fail to parse the relaxed semver parser

These versions are rather common, e.g.:

https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api/5.11.0-M2
https://mvnrepository.com/artifact/org.clojure/clojure/1.12.0-alpha12
https://mvnrepository.com/artifact/jakarta.servlet/jakarta.servlet-api/6.1.0-M2
https://mvnrepository.com/artifact/jakarta.ws.rs/jakarta.ws.rs-api/4.0.0-M2
https://mvnrepository.com/artifact/org.jetbrains.kotlin/kotlin-stdlib/2.0.0-RC3
https://mvnrepository.com/artifact/org.mozilla/rhino/1.7.14-RC1
https://mvnrepository.com/artifact/org.beanshell/bsh/2.0b5
and much more

Ok this is a bug.
But this is not a valid version for the relaxed parser  https://mvnrepository.com/artifact/org.beanshell/bsh/2.0b5.
It lacks for major.minor.patch structure, And it lacks also a . or a - for the qualifier.


About yolox_head 'gt_bboxes_ignore'

Prerequisite

[X] I have searched the existing and past issues but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

💬 Describe the reimplementation questions
when I read yolox_head code I see "gt_bboxes_ignore" but in this code I don't find how I can use it,it only a parameter in this code，but I want know how to use "gt_bboxes_ignore" in yolox_head ,thakns!
Environment
python=3.8
Expected results
No response
Additional information
No response

YOLOX uses SimOTA assigner which does not process the gt_bboxes_ignore. If you want to use it, you need to modify the assigner.


DOC-6940: Document the MOLT Verify tool

DOC-6940 Docs for Migration Verification Tool
@taroface do we know where this doc should be in the sidebar nav? (I remember a discussion about creating a new section for migration tools)

@Amruta-Ranade, this will belong under "Migration Tools" after #17320 is merged. For now, I'd place it directly under "Use the Schema Conversion Tool".


Fixed px-tooltip text overflow the container on IE11

Pull Request
Hi,
Thanks for helping us improve the Predix UI platform by submitting a Pull Request.
To help us merge your Pull Request as fast as possible, please fill out the following sections:

A description of the changes proposed in the pull request:  Fixed px-tooltip text overflow the container on IE11. overflow-wrap is not supported on IE 11, replaced this with word-wrap which works on both IE11 and chrome

A reference to a related issue (if applicable):

@mentions of the person or team responsible for reviewing proposed changes: Avid Analysis

working tests:

The tests need to be functional and/or unit tests, written for the wct framework, and placed in the test folder, following our testing guidelines.

Hi,
Can you resubmit this following the template provided when you create a new PR. We can't accept a PR that we don't know why you submitted it.
Thanks.

Also the tests are failing, we can't merge a PR in this state. Thanks.

After discussion and code review this looks ok. Thanks for the PR!
Next time try to fill out the template a bit more, it helps for other people on our team to review a PR or for anyone else referring to it in the future (this is all public)
For future references:
This PR changes overflow-wrap to word-wrap since IE doesn't support overflow-wrap: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap

Available in v1.2.1


[reconciler] Performance Overhaul

Related: https://github.com/coinbase/rosetta-sdk-go/tree/patrick/priority-lock
Changes

[x] explicitly set errgroup limit with runtime.NumCPU
[ ] update tests

[ ] fix failing test where context.Canceled returned instead of reconciliation fails

[x] make queue changes async

Pull Request Test Coverage Report for Build 12719

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 78.135%

Totals

Change from base Build 12702:
0.002%

Covered Lines:
7858

Relevant Lines:
10057

💛  - Coveralls

we are able to sync our node now with official SDK, I will retest again with these changes but so far so good, memory being held in check as well. (We have increased ours due to the database change size issue but can play around there once these changes are in)


Use jQuery.map utility as we can deal with objects instead of arrays only

Sure thing, can you add a small unit test that shows the functionality? Thanks!

To be honest, i never used unit tests.
This is a good time to start probably, but i need your help :)
I think I have to implement a new unit test file for ajax, right ?

No problem :)
Yeah, I'd advice to take one of the other test files as a starting point. The README contains instructions on how to run tests (note you can use --test=... to run a specific test as well).
I think the one tricky thing about writing AJAX tests is that you don't want to do actual AJAX requests, so I guess you should use the transport option to fake the replies from a REST service.
If you have any more questions, just let me know. Cheers!

Thank you for your message. I'll try it with probably some mistakes...

It was hard to understand how to deal with Ajax call. But an interesting first approach to unit testing.
A lot of things learned. Impatient to get your feedback.
Note : probably not DRY ^^

Well, these are great tests actually! A bit of repetition in test cases is not unexpected, to be honest, so I wouldn't worry too much about that.
The comment about "launch array" I guess shouldn't be in all the cases. As for code style I prefer not to use spaces inside braces (like you do inside the test.equal() calls). But these are my only nitpicks :)
Do you want to fix those? Otherwise it's good enough to merge already.
Great job, thanks!

Done ! Thank you for your advices. It helps me to have a new point of view in my coding style (by the way, i never use spaces inside braces habitually).
Now i love unit testing !!

Great to hear :) Cheers!

Cheers!


Benchmark framework: ModelJoin solution

Hi, we're currently trying to understand the benchmark framework. In particular, since we want to submit an Eclipse-based solution, we try to understand how the benchmarking of the ModelJoin solution (where everything is put in a Jar file) works.
We're currently stuck with the following question: How is the solution invoked from the benchmark framework? We think that somewhere there needs to be a mapping from views to specific classes/methods from the Jar file. However, the solution.ini only mentions the views, but no specific classes or methods.

[run]
OutageDetection=java -Xmx8G -jar solution.jar -view OutageDetection
OutagePrevention=java -Xmx8G -jar solution.jar -view OutagePrevention

Hi,
the benchmark framework executes whatever is contained in the run section of the solution.ini for the respective task. That way, you could execute both tasks in entirely different executables, if you wish. The ModelJoin solution uses the same executable, namely an executable Jar file and passes the task as a parameter.
All the other execution parameters such as the change sequence that is to be run, the run index, etc. are passed through environment variables. You can simply copy the code from the ModelJoin solution to fetch them:
Map<String, String> env = System.getenv();
String changeSet = env.get("ChangeSet");
String changePath = env.get("ChangePath");
String runIndex = env.get("RunIndex");
int sequenceLength = Integer.parseInt(env.get("Sequences"));

Ah, indeed. I now see that the Jar is in fact executable (initially, I couldn't find the MainClass entry because I was looking at the wrong Manifest.MF file), and the main class contains the logic for dealing with the "view" parameter.
Thanks for the fast and helpful reply.


Add ACME IBM Softlayer DNS01 provider

What this PR does / why we need it:
Add ACME IBM Softlayer DNS01 provider
Special notes for your reviewer:
Release note:
Add IBM Softlayer dns provider

/assign @munnerz

@munnerz Can you please take a look?

/assign @joshvanl

At this point, due to our inability to test all DNS01 providers that we currently have in our codebase, we are requiring all new DNS01 implementations to be implemented as external DNS01 webhooks, following the example here: https://github.com/jetstack/cert-manager-webhook-example/
We are currently not accepting new DNS01 providers into the core codebase as we don't have a good way to test them reliably - we've not determined an exact process for 'upstreaming' these DNS01 providers into the core codebase yet, but if a provider demonstrates it passes tests, and we are able to find a way to run these tests in our own environment, we'd definitely like to explore defining this process 😄
Hope that makes sense, and hopefully it'll allow for you to develop on your own provider with more confidence (as you can actually configure some end-to-end tests!)

Thanks you for the information. Would it be sufficient to mock the HTTP requests? For example with: https://github.com/jarcoal/httpmock

@munnerz @JoshVanL I've added mocks for the IBM Api.

@munnerz @JoshVanL After the third merge conflict please give me a sign if there is a chance to get this in the Master? Otherwise, I'm building a webhook.

Create webhook solver: https://github.com/cgroschupp/cert-manager-webhook-softlayer


Update add inverted index tmp dir support

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Feature / Issue: Text on Boolean buttons

The text on a boolean button widget does not change sizes based on the available area like the headings or data on numeric or text widgets.
Also the ability to set the color to differentiate buttons from each other. Possibly from a limited palate that would show what it would be like in both day and night mode.

text size fixed and color added. Will be part of next release. Thanks for the feedback


Force event send after fatal error with curl_method async

This is to address #391: when using the 'curl_method' => 'async' option, in the case of a fatal error the event is not sent to Sentry, at least in PHP < 7.
For starter, it adds a regression test that checks the order of method calls of ErrorHandler::handleFatal() and Raven_CurlHandler::join().

Ok I think I've found the issue! Basically we were triggering the autoloader manually inside the ErrorHandler::handleException() here:
https://github.com/getsentry/sentry-php/pull/575/commits/1a2022ba226da1bf5315607118d4887ee396a4c0#diff-11a1d8314f22caf150ad02a00b294b58L636
The issue (present only in PHP > 7) is that that function is called also during fatal error handling, during which the autoloader doesn't work anymore; this halted the script completely, without invoking the CurlHandler's shutdown function.

Thanks! I forgot to remove a constant that I used in one of the previous attempts, I'll merge anyway!


Remove invalid redirest from firebase.json

I believe the redirect in firebase.json is a carry over from vitepress-docs and can be removed.
{
  "hosting": {
    "redirects": [
      {
        "source": "/dapis",
        "destination": "/dapis/reference/understand/",
        "type": 301
      }
    ],
    "public": "docs/.vitepress/dist",
    "ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
  }
}

Yes agreed


Update README.md

Browser javascript is not node.js, it is just simply js. node.js is serverside javascript, which you run like a python script.

You can certainly tell I wrote this at 1AM by this 😆


Add Glossary to UG

Codecov Report

Merging #295 (c3bb48e) into master (cc0816e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #295   +/-   ##
=========================================
  Coverage     72.41%   72.41%
  Complexity      863      863
=========================================
  Files           131      131
  Lines          2915     2915
  Branches        383      383
=========================================
  Hits           2111     2111
  Misses          666      666
  Partials        138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0816e...c3bb48e. Read the comment docs.


keep protected field in transactions

Keep the protected field in the transactions. This field might be important for signing transactions with the right signing hash.

Is this field the same field as "v" for the transaction signing?
In this case we should maybe add that to the transaction field and omit the "protected" field. CC'ing this issue:
https://github.com/ethereum/execution-spec-tests/issues/168


One msalInstance for multiple MsalProvider components

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.17.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.0.2
Description
Hi,
I'm trying to create several custom elements that make use of the react-msal library to authenticate user.
The use case for this is that I have a static website, which will implement these elements to allow for a nice user experience.
Currently, I have two elements, one element is a simple login/logoff button and the actual SPA that implements some functionality, such as retrieving information from an API that requires an access token. An important note is that the SPA element requires the user to be logged in before being able to render it, if the user is not logged in this component wil also automatically redirect the user to log in.
At the moment, I'm initialising the MsalInstance in the register function, which is then passed as a prop to both elements so both can render the MsalProvider and pass down the required functionality. Everything seems to work unless when the user navigates to the SPA page, without actually being logged in. This causes a redirect flow, which then infinitely loops when the user is redirected back to the SPA page.
Is there a way for me to have two components make use of an MsalProvider while both being able to access the msalInstance?
MSAL Configuration
export const msalConfiguration = (clientId: string): Configuration => ({
  auth: {
    clientId,
    authority: '<my-authority>',
    navigateToLoginRequestUrl: true,
    postLogoutRedirectUri: '/',
    knownAuthorities: ['<my-known-authority>'],
  },
  cache: {
    cacheLocation: 'sessionStorage',
    storeAuthStateInCookie: false,
  },
});

Relevant Code Snippets
register.ts:

let msalInstance: IPublicClientApplication;

const registerCustomElements = (clientId: string) => {
  msalInstance = new PublicClientApplication(msalConfiguration(clientId));

  register('authentication', () => import(`./customElements/Authentication`), msalInstance);
  register('spa', () => import(`./customElements/spa`), msalInstance);
}

Authentication.tsx
interface Props {
  msalInstance: IPublicClientApplication;
}

const Authentication = ({ msalInstance }: Props) => {
  return (
    <MsalProvider instance={msalInstance}>
      <AuthenticationButton />
    </MsalProvider>
  );
};

SPA.tsx
interface Props {
  msalInstance: IPublicClientApplication;
}

const ProfileWrapper = ({ msalInstance }: Props) => {
  return (
    <MsalProvider instance={msalInstance}>
      <SPA />
    </MsalProvider>
  );
};

Identity Provider
Azure B2C Basic Policy
Source
External (Customer)

@LukasCornille Using multiple instances of the MsalProvider component is not a recommended pattern. You should instead render a single MsalProvider component at the top level (or as high up as you can) and then conditionally render your other components underneath. msal-react provides components to help you do this. For example to achieve the scenario you've listed above you can use the MsalAuthenticationTemplate component which will only render children if a user is signed in and auto-invoke sign in if a user is not signed in. That would look something like this:
const ProfileWrapper = () => {
  return (
      <MsalAuthenticationTemplate interactionType={InteractionType.Redirect}>
          <SPA />
      </ MsalAuthenticationTemplate>
  );
};

ReactDOM.render(
    <React.StrictMode>
        <MsalProvider instance={msalInstance}>
          <AuthenticationButton />
          <ProfileWrapper />
        </MsalProvider>
    </React.StrictMode>,
    document.getElementById('root')
);

I've resolved this issue by using the JS library over the React library. As I stated I'm using a static element with multiple custom elements in which React components live. The solution provided by @tnorling therefore does not work, by using the JS library I was able to handle the redirect promise before registering the custom elements and therefore only initialise the library once.


How to scroll based on property of wrapped component

I'm trying to reason my way around getting an element to 'scroll' when a property changes. I have  this.props.active, and when this changes to true, the element should scroll.
I had anticipated doing something like:
componentDidUpdate() {
  if (this.props.active) {
    ReactDOM.findDOMNode(this).velocity('scroll', {duration: 500, offset: '54px'});
    // This works --> ReactDOM.findDOMNode(this).scrollIntoView({behavior: 'smooth'});
  }
}

But I haven't managed to get velocity to work in that context (window is not defined).
scrollIntoView works, but we can do much better/nicer/better supported things with velocity.
Is there a way to solve this scenario using velocity-react?

I haven't tried it, but it's likely to work, since velocity-react just calls Velocity on child DOM nodes.
You may or may not want runOnMount to be true, depending upon how you want the “animation” to be triggered.

I still couldn't see a way to trigger the animation based on a property with VelocityComponent.
So I required the shim: const velocity = require('velocity-react/lib/velocity-animate-shim');
and did exactly as I outlined above.

You'll want to add a ref to the component so you can access it, and call runAnimation on it when you want it to fire off.


Option to delete old track names before labeling

Mostly for label_mode: add an option that will erase old track names before input.
Should be possible by just entering labelling mode and pressing Playmode (250 times?)

Initial implementation in https://github.com/fijam/gmdrec/commit/420d1b6186ba2f56307e41a15973503e4557c0dc
Selecting 'ERASE' in label_mode will delete 128 characters of an old track name. This takes about 8 seconds and should be enough for most cases (famous last words).


api details for face-recognition.js

Hi Vincent ,
Facing issue during running some of the sample code in the page https://github.com/justadudewhohacks/face-recognition.js .
api details for accessing imageWindow object is not clear to me .
here addOverlay method is taking rectangle  object . however its type is not known .
I believe these are js api are wrapper over dlib library .
Please correct me in case my understanding of this infrastructure is wrong .
const win = new fr.ImageWindow()
// display image
win.setImage(image)
// drawing the rectangle into the displayed image
win.addOverlay(rectangle)
// pause program until key pressed
fr.hitEnterToContinue()

Closing, if there are still questions remaining, feel free to reopen.


Compiling on Void Linux - fatal error: td/telegram/td_api.h

Is there an installation instruction for Void?
How to reproduce it:

Install dependencies (is there maybe something missing here?):
xbps-install -Su  go ccache cmake gperf help2man libmagick-devel readline-devel sqlite-devel file-devel
git clone https://github.com/d99kris/nchat && cd nchat
mkdir -p build && cd build && cmake .. && make -s

[ 91%] Building CXX object lib/tgchat/CMakeFiles/tgchat.dir/src/tgchat.cpp.o
In file included from /home/jo/Downloads/nchat-3.67/nchat-3.67/lib/tgchat/src/tgchat.cpp:20:
/home/jo/Downloads/nchat-3.67/nchat-3.67/lib/tgchat/ext/td/td/telegram/Client.h:11:10: fatal error: td/telegram/td_api.h: No such file or directory
   11 | #include "td/telegram/td_api.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [lib/tgchat/CMakeFiles/tgchat.dir/build.make:76: lib/tgchat/CMakeFiles/tgchat.dir/src/tgchat.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:412: lib/tgchat/CMakeFiles/tgchat.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Environment:

Version: nchat-3.67
OS / distro: Void Linux

Hi @johnwuelk - I'll see if I can try building on Void Linux. Meanwhile, could you share if you're using musl or glibc installation of Void? Also knowing the amount of RAM on the system and whether it's 64-bit could be useful. Finally if you could share the compiler version c++ --version and also the full output when building (might need to save in a txt file and drag into the comment field to attach), it would be very helpful. Thanks!
The list of dependencies looks ok, I think only base-devel is missing (and possibly git if downloading via git).

Hi @johnwuelk - I finally got a chance to take a closer look at this and to try Void. It appears openssl-devel is missing. If the build still fails after installing openssl-devel, could you please provide the full output from the build command, for example:
./make.sh build >> log.txt 2>&1

I'll add documentation for Void dependencies in the README, and also support for Void in the ./make.sh deps command for installing dependencies.

The README and make.sh script have been updated in above commit. Feel free to re-open this issue if you're still facing issues building nchat on Void.


Add basic CI (build + tests) for PR on master.

Replaced by a more advanced way with composite action #7


slot names - no underscores?

It appears that underscores are not permitted in slot names. Is that correct? If so, it would be helpful to note that somewhere in the docs. Thanks!

Great spot! @blawqchain - just publishing a fix now

many thanks for the super fast fix

@blawqchain You're ever so welcome 😄


provide current-time value

Provide a current-time value in the nuvlabox-status to allow clock skew to be detected. Remove the update of the next-heartbeat field as this is now handled by the server.

@cjdcordeiro Code moved.  Take a look at the changes.

y already approved