Rendering tweaks

I was getting "pb_push_to: begin-end block musn't exceed 128 dwords" log spam when I enabled logging. I was sending way more than 128  DWORDs which seemed to work okay so not sure why the limit but I meet it now mostly anyway
Also I think I have fixed the random flickering by waiting on the vblank event instead of manual frame timing.
pkbit now uses two buffers instead of 3 (saves ~3.5MB of RAM in 720p)

Also I think I have fixed the random flickering by waiting on the vblank event instead of manual frame timing.

Setting the cap to 60, the flickering I reported no longer happens. Thanks!


fix: Embed errors in the AST instead of raising

Made some changes to the code so the errors are being embedded in the AST instead of raising
fixes #48

Thanks @Dezzy12 for the contribution!
Unfortunately, as you can see, the CI is red: it means that something is wrong with the code. In this case, the CI says that OCaml cannot build the project with your modifications: see the reported error
But before sending changes for a PR, you should first try to build locally: you will get the errors more quickly!
In any case, it seems that there are several things that you need to achieve before fixing the issue.

First, you should try to "use" ppx_deriving_yaml. For instance, try to run the examples in your local OCaml installation.
Then, try to have an example of a situation where an error is triggered.
Decide how the reporting of error should be changed. For this, you should understand several concepts: the AST, how PPX work, the different ways of reporting errors... I gave you many resources to read! When it is clear, to to write me what are the changes to make before actually making them.

I think trying to send a PR to ppx_deriving_yaml before those points would be a bit premature! Don't try to rush too much ;)
For any help about the goal above, contact me directly!

Okay thanks for the tips


Add the tag to the article preview

This is some ground work for issue #3, including the tag makes the article previews look more complete. The CSS was already there. Now it's a matter of adding a link to a tags page where you can see everything with the same tag.

@Putnam14 Thank you!!! 🎉


Add STAC data model

The main challenge in this part of the project was adapting the relatively unstructured STAC model to a structured schema.
Instead of imposing a rigid structure on the STAC data model, a framework to safely extend it is introduced. The result is a (hopefully) compliant and flexible library.
The top-level STAC models implemented here are very sparse. They capture the necessary structure and relationships of the data model, though. This is intentional. The full data model is added onto it in the extensions folder.

Rather than rebasing our current database schema onto a new database schema optimized for STAC workloads, we plan to implement schema crosswalks between our current database schema and the domain objects defined in the STAC specification. These schema crosswalks will likely be defined in serializers scoped to produce fixed views of our data that are STAC compliant.


Dragging Nodes offscreen causes an error

When dragging a node off to the right of the canvas, an error occurs and the user has to reset their node selection.

This was the same issue I reported in #135 that's been incorrectly closed now though.

Any updates on this one ? Error still persists, even in the demo samples. It is kinda blocker for me, because we have global error handler on page, and this exception triggers our code.
If it cannot be fixed, could it at least be changed to warning or console log instead of throw .. ?

Hello, do we have any update/ workaround/fix regarding this issue? In my project when I move a node outside of the div wrapper's height, I have the following errors:


New classes were added: LocationAddressAndGeoForUpdateDto, OpeningHoursDto, OpeningHoursDtoMapper, PlaceUpdateDto, PlaceUpdateDtoMapper. /place/about/{placeId} end-point was implemented.

By mistake to dev_java21 branch


Single tuple trailing comma

Tuple with a single value needs a trailing comma.

Actually, this enum variant can hold a single value that is not inside a tuple. I'll make the required modifications.


Why is file upload so incredibly slow?

I am uploading files that are about 300-400kb in size.  The average upload time for a single file is 30 seconds which is unacceptable.  How can I improve this?  I'm suing the following code from your example to upload and have a fast stable wifi connection.
let dataString = "My Data"
let data = dataString.data(using: .utf8)!
let storageOperation = Amplify.Storage.uploadData(key: "ExampleKey", data: data)
let progressSink = storageOperation.progressPublisher.sink { progress in print("Progress: \(progress)") }
let resultSink = storageOperation.resultPublisher.sink {
    if case let .failure(storageError) = $0 {
        print("Failed: \(storageError.errorDescription). \(storageError.recoverySuggestion)")
    }
}
receiveValue: { data in
    print("Completed: \(data)")
}

Are you seeing 30 seconds for all file uploads or just the first try? The first try might include different api calls to fetch AWS credentials which might take a few seconds more. The subsequent upload calls should be faster.

I'm seeing a very long period for the first try and then somewhat long periods for subsequent uploads.  Even not being the first upload the time it takes is really unacceptable.  The same data count size to lambda or api upload is much much faster.

Not sure how these upload times to S3 are acceptable.  Files just 2-3 MB take over 30 seconds.  Unacceptable.

@alionthego When this is happening can you count up the number of active threads?
We have been working on some performance improvements and one was just merged which could help with your issue. If other work is in progress and it is causing threads to be blocked it could explain why this operation is delayed. See the issues mentioned at the bottom of the PR below. This update will be included in the next release.
#3872

@alionthego we've released the performance improvements of #3872 with Amplify v1.18.1.
Let us know if it helps with your issue.

I am using latest sdk and the s3 file upload is still unacceptably slow.  it takes about 30 seconds to upload 400 kb.

same issue, upload is slow

I am seeing the same issue :-|

Same issue. Upload is slow. !
Actual Example (~1mb file took ~39seconds):
func uploadData(data: Data, key: String) {
    let startDate = Date()
    print(data) // 991691 bytes

    let options = StorageUploadDataRequest.Options(accessLevel: .private)

    Amplify.Storage.uploadData(key: key, data: data, options: options) { result in
        let endDate = Date().timeIntervalSince(startDate)
        print("!@", endDate) // 38.75
    }
}

@atierian Hey! thanks for reverting.
We are using Amplify via SPM, and the version we are at is 1.25.0.
As for the amplifyconfiguration.json, the region is us-west-2 but we would be located us-east.
I first did doubt the region but our Android counterpart team is using the same us-west-2 but not facing any upload speed issues.

@atierian I am facing the same issue as well. I am using the latest Amplify version 1.27.1 for iOS but it still takes 2-3 minutes in uploading a small file. The S3 bucket is currently in us-east-1 region.

Thanks for letting us know.
Slow uploads / transfers is actively being investigated. We'll follow up on this issue with any updates.

I am facing same issue, any solution is there?

@alionthego @anuragsingla123 @dhaval-dobariya @sagarjoshi @staticVoidMan I'm picking up this investigation but haven't been able to reproduce this on my end (including using Apple's Network Link Conditioner). Would you please contact me directly to see if we can have a call to diagnose? Thanks.

Try a request from a different region.  Such as servers in Virginia and client in Hong Kong

Just writing to update you all on progress: I do see very slow upload times (about 2 minutes for a 1.1MB file) being in Texas and uploading to AWS regions such as Mumbai. I'm taking a deeper dive to figure out if there is a root cause (in the library or SDK) apart from the physical distance.

Hi, I am facing the same issue. I am using Amplify 1.28.3 version.
11 MB video file is taking 6 -7 minutes to upload.
But in AWS SDK video upload was working fine with AWSS3TransferUtility class.
Code:
let fileNameKey = "testing_upload_video_3.mov"
let filePath = Bundle.main.url(forResource: "testing_upload_video_2", withExtension: "MOV")
    guard let filename = filePath
    else { return }

    let storageOperation = Amplify.Storage.uploadFile(
        key: fileNameKey,
        local: filename,
        progressListener: { progress in
            print("Progress: \(progress)")
        }, resultListener: { event in
            switch event {
            case let .success(data):
                print("Completed: \(data)")
            case let .failure(storageError):
                print("Failed: \(storageError.errorDescription). \(storageError.recoverySuggestion)")
            }
        }
    )

Thank you for your patience, I've submitted the pull request above which the team will discuss.

is there any solutions for this problem , upload time is incredibly slow for me as well , 3 MB file size takes more then 8 to 9  minutes time for upload. 😔😔

is there any solutions for this problem , upload time is incredibly slow for me as well , 3 MB file size takes more then 8 to 9 minutes time for upload. 😔😔   + 1

We have a use case with large, 50-100MB uploads which can take between 0:00:15 and 1:55:00 on gigabit connections. Even worse, we get no status back as far as the progress in fractionCompleted reliably. It can take 5-10 minutes before the user gets notification at all of any progress, forcing us to fake a 1% increment of progress to keep the user on the page.
Therefore we see two core issues with Amplify swift:

Extremely unreliable upload speeds with the same file on the same internet connection on the same device in the same hour
The above would be less painful if we had reliable progress updates, but we see unusable upload progress for consumers

At this point, we may be forced to consider alternative storage solutions that are responsive and attentive to known issues that have been stagnating for 5 months.
Code:
    static func uploadPreSignedFile(key: String, fileUrl: URL) -> StorageUploadFileTask {         let key = "uploads/\(key).zip"         return Amplify.Storage.uploadFile(key: key, local: fileUrl, options: .init(             contentType: "application/zip"         ))     }
       let uploadTask = StorageHelper.uploadPreSignedFile(key: key, fileUrl: fileUrl)
`                for await progress in await uploadTask.progress {
self.viewProgress = .uploadS3(progress.fractionCompleted)
self.regions[index].progress = self.viewProgress?.getProgress()
                // fraction of upload as we scale upload to progress bar from 10 to 99%
                if progress.fractionCompleted >= 1.0 {
                    let value = try await uploadTask.value
                    logger.info("Upload complete, value: \(value)")
                    fileUrl.stopAccessingSecurityScopedResource()
                    self.onUploadComplete(key: scanKey, path: value, index: index)
                }
            }`

Hi, we have work in progress to make this better but it has taken longer than I anticipated. However, here is a workaround you can use to speed things up:

Download PresignedUrlGenerator somewhere into your application/library. This performs the subset of the work used by Amplify in order to prepare for upload.
Use by entering something like the example below:

let generator = PresignedUrlGenerator(
    region: "us-east-1",
    bucket: mys3BucketName
)
let url = try await generator.presignedURL(
    for: myKey,
    accessLevel: .private
)
var request = URLRequest(url: url)
request.httpMethod = "PUT"
let task = session.uploadTask(with: request,
                              fromFile: fileURL)
task.delegate = self
task.resume()

You are likely using amplifyconfig.json in your application, and if that is the case, you should be able to get the relevant region and bucket by doing something like the following:

Download AmplifyConfig somewhere into your application/library.
Read your amplifyconfig.json file with something like:

let amplifyConfig = try AmplifyConfig.load(from: .main)
let generator = PresignedUrlGenerator(
    region: amplifyConfig.storage.plugins.awsS3StoragePlugin.region,
    bucket: amplifyConfig.storage.plugins.awsS3StoragePlugin.bucket
)

Thank you @jcjimenez - do you know if this supports multipart POST uploads? Would it work for 50-100MB uploads?

@zachrattner the provided PresignedUrlGenerator  only supports the PutObject API, but it should be more than enough for 50-100MB uploads as the API supports up to 5 GB.

@zachrattner I hope this workaround did the trick! For reference, it is subject to the limits posted here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/upload-objects.html

@jcjimenez thank you for the code, it worked for @zachrattner and i in that we now see quicker and more reliable responses regarding progress.

@atierian  Hi there, are you guys just fixing upload speeds or also looking at download speeds?  I'm using the amplify-swift version 2.0.0.  I have a client app in Tokyo and server US-EAST-1.  a file of 300mb will take over one hour to download from s3 bucket using:
let downloadTask = Amplify.Storage.downloadFile(             key: "myKey",             local: downloadToFileName,             options: nil   )


StackNavigator,  TabNavigator and DrawerNavigator integration issue

I need to use DrawerNavigator , TabNavigator and StackNavigator together, any one have a simple demo show how to use these three navigators together? Thanks a lot.

Currently I'm using all of these in my project.
I have top Drawer that overflows header, The drawer menu items are Tabs, wrapped by StackNavigator (since I need header to be displayed over tabbars), and I also have some screens that are outside Drawer.
...
import Icon from "react-native-vector-icons/MaterialIcons";

const defaultHeaderConfig = {
    style: ...,
    visible: true
};

const headerWithDrawerButton = ({ state, setParams, navigate }) => ({
    ...defaultHeaderConfig,
    left: <TouchableOpacity onPress={ () => { navigate('DrawerOpen'); } }>
                <Icon name="menu" size={24} />
            </TouchableOpacity>
    }
);

const Router = StackNavigator({
    Drawer: {
        screen: DrawerNavigator({
            DrawerMenu1: {
                screen: StackNavigator({
                    Tabs: {
                        screen: TabNavigator({
                            Tab1: { screen: TabOneComponent, navigationOptions: { title: "tab1Title" } },
                            Tab2: { screen: TabTwoComponent, navigationOptions: { title: "tab2Title" } }
                        }),
                        navigationOptions: {
                            title: "Drawer menu item title",
                            header: headerWithDrawerButton
                        }
                    }
                })
            },
            DrawerMenu2: ...
        }), navigationOptions: {
                header: {
                    visible: false
                }
    }},
    //all screens that shouldn't be inside Drawer
    Details: { screen: OfferDetails, navigationOptions: { title: "Details" } },
    Checkout: { screen: Checkout, navigationOptions: { title: "Checkout" } },
    Success: { screen: OrderSuccess, navigationOptions: { title: "Success" } },
    SearchResults: { screen: SearchResults, navigationOptions: { title: ({ state }) => `Search results for: ${state.params.searchQuery}` } }
}, {
    navigationOptions: {
        header: defaultHeaderConfig
    }
});

https://github.com/rafaelmmathias/RNExperimental
You can clone this and see it work

@Gvade thanks for the code, in my case what I am trying to is - I have Dashboard screen(it have 3 tabs) in my main StackNavigator, I want my drawer to be available at Dashboard screen without navigating to a new scene, in my drawer there are many screens like Profile, About us, help etc.I don't want to keep my dashboard as a Screen in drawer , so can you please guide me how should I approach this,
here is the code of my main stackNavigator
const routesConfig = {
  //Splash:{screen:SplashScreen},
  Landing:{screen:LandingScreen},
  Login: { screen: Login },
  SignUp: { screen: SignUp },
  ForgotPassword: { screen: ForgotPassword },
  Dashboard:{screen:Dashboard},
  UserProfile:{screen:UserProfile}, //I will move this to the drawer
  Drawer: {
    name: 'Drawer Example',
    description: 'Android-style drawer navigation',
    screen: Drawer,
  },
};
export const AppNavigator = StackNavigator(routesConfig);

For reference, please take a look at NavigationPlayground. Feel free to create a new issue when there's a bit more specific question we can help.

Adding links for convenience:
https://github.com/react-navigation/react-navigation/tree/master/examples/NavigationPlayground
https://expo.io/@react-navigation/NavigationPlayground


Adding ansible tags option through cmdline

This PR is able to:

Add Tag support to ansible-runner calls through cmdline

@miq-bot assign @agrare


Changes to how to call starsolo

whitelist call
experiment with no filter output but this seems to mess things up

I am guessing you removed the filtered outputs because you want to filter those yourself but could you leave the h5 matrix raw? It is created very efficiently so it saves us an extra script.
Another thing to consider is that if we don't get the filtered alignments we lose the genes quantification right? I would love to get everything we need out of starsolo if possible. If not, so be it.

There is no h5 matrix created by star solo.
No, filtered vs raw is just like cell ranger’s definition of filtered. We
can load barcodes, genes, matrix into Seurat with one command and do our
own filtering (best to use the atac to filter the rna and maybe some
filters on nUMI and nGene)
On Fri, Aug 12, 2022 at 10:15 PM Eugenio Mattei @.***>
wrote:

I am guessing you removed the filtered outputs because you want to filter
those yourself but could you leave the h5 matrix raw? It is created very
efficiently so it saves us an extra script.
Another thing to consider is that if we don't get the filtered alignments
we lose the genes quantification right? I would love to get everything we
need out of starsolo if possible. If not, so be it.
—
Reply to this email directly, view it on GitHub
https://github.com/broadinstitute/epi-SHARE-seq-pipeline/pull/36#issuecomment-1213479569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK2EW32S24PEWXKZ2NM6Z3VY2WFNANCNFSM56MWMAEQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Neva Cherniavsky Durand, Ph.D. | she, her, hers
Senior Scientist |  Gene Regulation Observatory
Broad Institute of MIT and Harvard


Potential memory leak - Arc Rotate camera after attachControl

The ArcRotateCamerta stays in memory after disposing (and gc-ing) the scene and the engine, but only when attaching the camera.
The following code disposes all objects correctly:
            const camera = new BABYLON.ArcRotateCamera("camera1", 0, 0, 0, new BABYLON.Vector3(0, 5, -10), window.scene);
            camera.setTarget(BABYLON.Vector3.Zero());

The following keeps the camera in memory:
            const camera = new BABYLON.ArcRotateCamera("camera1", 0, 0, 0, new BABYLON.Vector3(0, 5, -10), window.scene);
            camera.setTarget(BABYLON.Vector3.Zero());
            camera.attachControl(true);

In this case it is hard to know what references the camera outside of the scene context.

waouh..this one will be a bit more tricky then :)

I will see how we can simplify finding this out. One way would probably be to list the objects that were added using Object.prototype. Theoretically it should be an empty list, but because sometimes we have static objects (on the BABYLON namespace) it might be an acceptable increase. I'll see how we can improve on that.

Found it!

can't wait to see what caused that...


Improve initial rendering in web version

Because of server-side rendering and layout responsivity handled by js we cannot set layout value of LayoutContextProvider inside constructor.
Because different initial layout size value on server and front-end will cause nextjs content mismatch error during initial render.
Value is currently set inside componentDidMount of LayoutContextProvider. Which solves the issue but there is still ugly layout reshuffle during initial render which should be removed.

Maybe we could show some loader/spinner until the dimensions have been calculated?

@tbergq As I think about it, spinner as in other cases should be ok. It will definitely improve experience.
I've been also thinking about using user-agent info on server to set correct initial layout value. But this will probably work only for mobile, where phones can be detected quite accurately. But it will still be inaccurate for desktop, where browser window size can be totally random.

Also, right now, bear in mind we are doing server-side rendering at build time, which I guess is more called pre-rendering. We are just serving static files. So loader sounds good to me.


Bench

About the PR

Just steel bench, nothing more. Good for maps and corridors.

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: SonicHDC

add: Added steel bench!

Please don't style these after the old chair sprites. Both the palette and design of them was very ill-fitting for the game as a whole, these probably won't be much different.
Also these need screenshots of the object being used ingame, just an image of the raw sprite won't show how it fits in with the environment.

In the future, please refrain from creating a PR via uploading files to the github website.
Follow our instructions here for how to set up git and make a pull request properly.

No merge?


Add functionality for tagging

Added some functionality for tags.
Able to filter the Persons in the address book according to what they are tagged by.
Example usage :
tag criminal friends
Expected result :
will display the list of persons tagged either criminal, or friends, or both.

Good job, well done!!


feat: parse dotnet metadata tables

You might want to use this project as a reference -
https://github.com/microsoft/go-winmd


Referencing AsyncAPI specs to reuse messages and schemas generates Java classes with incorrect names

Describe the bug
When generating Java code from an AsyncAPI spec which references another one for reuse, schemas from the referenced AsyncAPI spec are named AnonymousSchema<#>.java instead of using the schema name.
Java classes are generated correctly for schema's in the main AsyncAPI spec.
How to Reproduce
Ensure that you have 2 AsyncAPI specs of which one references the other to reuse a message.
asyncapi.yaml
channels:
  user.update:
    publish:
      summary: User is updated
      message:
        $ref: '<url-or-path-to-other-asyncapi-yaml>l#/components/messages/user'

other-asyncapi.yaml
components:
    messages:
        user:
            contentType: 'application/json'
        payload:
            $ref: '#/components/schemas/User'

  schemas:
      User:
          type: object
          properties:
              [...]

Execute ag asyncapi.yaml @asyncapi/java-spring-template
Expected behavior
A Java class is generated for schema User called User.java.

In theory now that I think about it, it might actually be related to the parser more so, as this template just uses what is determined by the parser:
https://github.com/asyncapi/java-spring-template/blob/9fccfdee2bbc20f7452e5f2f5fabe1fa6e3a2e30/template/src/main/java/com/asyncapi/model/%24%24objectSchema%24%24.java#L17

Oh, it actually is a parser bug:
take these files:
#asyncapi.yml
asyncapi: 2.0.0
info:
  title: My API
  version: '1.0.0'
channels:
  mychannel:
    publish:
      message:
        $ref: 'refed.yml#/components/messages/testMessage'

#refed.yml
components:
  messages:
    testMessage:
      payload:
        $ref: '#/components/schemas/testSchema'
  schemas:
    testSchema:
      type: object
      properties:
        name:
          type: string

and you get this:
{
    "asyncapi": "2.0.0",
    "info": {
        "title": "My API",
        "version": "1.0.0"
    },
    "channels": {
        "mychannel": {
            "publish": {
                "message": {
                    "payload": {
                        "type": "object",
                        "properties": {
                            "name": {
                                "type": "string",
                                "x-parser-schema-id": "<anonymous-schema-2>"
                            }
                        },
                        "x-parser-schema-id": "<anonymous-schema-1>"
                    },
                    "x-parser-original-schema-format": "application/vnd.aai.asyncapi;version=2.0.0",
                    "x-parser-original-payload": {
                        "type": "object",
                        "properties": {
                            "name": {
                                "type": "string"
                            }
                        }
                    },
                    "schemaFormat": "application/vnd.aai.asyncapi;version=2.0.0",
                    "x-parser-message-parsed": true,
                    "x-parser-message-name": "<anonymous-message-1>"
                }
            }
        }
    },
    "x-parser-spec-parsed": true
}

so of course result.channel('mychannel').publish().message().payload().uid() returns <anonymous-schema-1> instead of testSchema
btw I wish to one day do something like result.getSchemaId(messageId) or at least result.getSchema(messageId).uid() instead of result.channel('mychannel').publish().message().payload().uid() 😄 (intent-driven API fan here)


Upgrading to<EMAIL_ADDRESS>cause crash

Error: HTTP.methods not implemented on client-side
at Object.HTTP.methods (.meteor/local/build/programs/server/packages/cfs_http-methods.js:688:9)
W20160406-15:04:26.035(2)? (STDERR)     at [object Object]._.extend._registerHTTPMethod (.meteor/local/build/programs/server/packages/tap_i18n.js:3099:17)
W20160406-15:04:26.036(2)? (STDERR)     at TAPi18n (.meteor/local/build/programs/server/packages/tap_i18n.js:2880:24)
W20160406-15:04:26.036(2)? (STDERR)     at .meteor/local/build/programs/server/boot.js:249:5

+1

Omg, I banged my head all the afternoon thinking it came from my side.

If anyone finds a work-around, please post it here. This broke all our tests and we're pretty much blocked :(

So, I've done some research and the problem seems to be that the tap-i18n-compiler imports cfs_http-methods/http.methods.client.api.js as a server file, even though it is obviously not.
The only thing that client file does is to overwrite the HTTP.methods() function to print out an error: https://github.com/CollectionFS/Meteor-http-methods/blob/master/http.methods.client.api.js
So, to temporarily fix our Circle CI tests until tap-i18n fixes their issue, we forked cfs:http-methods and kicked out the client file. Voila, green tests again.

Great, the same minute I finished my hacky fix, cfs:http-methods bumped their version number and that magically fixed it...
https://github.com/CollectionFS/Meteor-http-methods/commits/master

Is this issue still open after 5 years?


Make various test CA certs RFC 5280 compliant w.r.t. X.509 extensions

This is a spin-off of #13658 to reduce the size of that PR.

[x] tests are added or updated

This pull request is ready to merge

This pull request is ready to merge

Merged - thanks @t8m

Merged - thanks @t8m


add deleteUrl for sharex

https://github.com/WeebDev/lolisafe/issues/123
It's really hacky and I don't like it. I'm not sure if ShareX supports just setting off a DELETE request instead of opening the URL in the browser, but that would definitely be a prettier solution.

If this is going to be added, the bit that generates ShareX config in home.js should also have the delete URL format thing.
Also I think I saw a feature request for ShareX to allow POST request for deletion URL of custom hosts, but the dev wasn't interested.

This is way too hacky for me to feel comfortable adding it. Hopefully ShareX implements a better way, but for now i'm holding this one off

@BobbyWibowo I added the new parameter
@Pitu Yeah I understand, it's here if people really want it, I don't use ShareX myself.

Implemented in dev branch


deptha-ros: 2.5.1-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository deptha-ros to 2.5.1-1:

upstream repository: https://github.com/luxonis/depthai-ros.git
release repository: https://github.com/luxonis/depthai-ros-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.1
previous version for package: null

depthai-ros
* Fix Build farm issues

depthai_bridge
* Fix Build farm issues

depthai_examples
* Fix Build farm issues

depthai_ros_msgs
* Fix Build farm issues

This needs a rebase to go in next to depthai which was inserted in the same spot.


horizontal scroll don't work

We have page with horizontal and vertical scroll, but this library don't support horizontal direction

https://github.com/valmisson/svelte-scrolling/pull/16


Add support for pub(crate).

Coverage remained the same at 87.566% when pulling 70d40b4c4c79d531f5b2fba78659e5564530aa73 on ProgVal:pub-crate into 64af2d1cac7298b511eb671163dcdbb2ad197d17 on Geal:master.

sorry, I did not look far enough in the PR and merged this one instead c7a79a9


Add stream method

Resolves #1

Nice, thanks!
Could you slightly reword the README to actually say that .stream is the recommended option?
For example because it's guaranteed to cleanup things even on errors

Have switched the example given in the README to use StreamApp and Limiter.stream

Ok that should be the example working now, should really set up tut to catch this stuff!

Thanks a lot :)


Failed building wheel for box2d-py [solved]

I'm on MacOS with Anaconda
Initially had error Failed building wheel for box2d-py
Solution was to brew install swig

@dingran, could you give more specific information about your system and Python environment?
@pzhokhov, who maintains Gym; any idea what happened?

@jachiam This happened with me too on MacBook Air 2015 model running MacOS Sierra with Python version 3.6 in Anaconda.

This is what I got.
Running setup.py install for box2d-py ... error
    Complete output from command /Users/ankitkrsingh/miniconda3/envs/spinningup/bin/python -u -c "import setuptools, tokenize;__file__='/private/tmp/pip-install-j5kexno9/box2d-py/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/tmp/pip-record-mamy1ivh/install-record.txt --single-version-externally-managed --compile:
    Using setuptools (version 40.5.0).
    running install
    running build
    running build_py
    creating build
    creating build/lib.macosx-10.7-x86_64-3.6
    creating build/lib.macosx-10.7-x86_64-3.6/Box2D
    copying library/Box2D/__init__.py -> build/lib.macosx-10.7-x86_64-3.6/Box2D
    copying library/Box2D/Box2D.py -> build/lib.macosx-10.7-x86_64-3.6/Box2D
    creating build/lib.macosx-10.7-x86_64-3.6/Box2D/b2
    copying library/Box2D/b2/__init__.py -> build/lib.macosx-10.7-x86_64-3.6/Box2D/b2
    running build_ext
    building 'Box2D._Box2D' extension
    swigging Box2D/Box2D.i to Box2D/Box2D_wrap.cpp
    swig -python -c++ -IBox2D -small -O -includeall -ignoremissing -w201 -globals b2Globals -outdir library/Box2D -keyword -w511 -D_SWIG_KWARGS -o Box2D/Box2D_wrap.cpp Box2D/Box2D.i
    unable to execute 'swig': No such file or directory
    error: command 'swig' failed with exit status 1
  ----------------------------------------
Command "/Users/ankitkrsingh/miniconda3/envs/spinningup/bin/python -u -c "import setuptools, tokenize;__file__='/private/tmp/pip-install-j5kexno9/box2d-py/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/tmp/pip-record-mamy1ivh/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /private/tmp/pip-install-j5kexno9/box2d-py/

Since this is solved I'm going to close it for now.
As for diagnosing what happened: when pip installing, pip first tries a wheel if one is available and compatible with your system, and if that fails, it tries to build from source. In order to install Box2d from source, you need to have swig installed. So for whatever reason (don't know why) your systems were incompatible with the pre-built wheel, defaulted to building Box2d from source, and then failed when they couldn't find swig---but installing swig fixed that!
Glad this worked out.

@jachiam I think your analysis is correct. As for why the binary wheel was not found - looks like we have box2d-py wheels build for osx 10.13 (which means that they should work with osx versions 10.13+); and sierra is 10.12. I'll look into releasing binary versions of box2d-py for older version of osx.

on Windows conda: conda install -c anaconda swig

on Windows conda: conda install -c anaconda swig

I tried installing swig from anaconda, but the issue persists. It seems like the installation process did not find the swig after all, even though the anaconda is reporting functioning and configured correctly.

This post solved it for me.

error: command 'swig' failed: No such file or directory
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for box2d-py
  error: subprocess-exited-with-error

  × Running setup.py install for box2d-py did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Using setuptools (version 61.2.0).
      running install
      /Users/nishantbhansali/opt/miniconda3/envs/lightning-bolts-dev/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      running build
      running build_py
      creating build
      creating build/lib.macosx-10.9-x86_64-3.9
      creating build/lib.macosx-10.9-x86_64-3.9/Box2D
      copying library/Box2D/Box2D.py -> build/lib.macosx-10.9-x86_64-3.9/Box2D
      copying library/Box2D/__init__.py -> build/lib.macosx-10.9-x86_64-3.9/Box2D
      creating build/lib.macosx-10.9-x86_64-3.9/Box2D/b2
      copying library/Box2D/b2/__init__.py -> build/lib.macosx-10.9-x86_64-3.9/Box2D/b2
      running build_ext
      building 'Box2D._Box2D' extension
      swigging Box2D/Box2D.i to Box2D/Box2D_wrap.cpp
      swig -python -c++ -IBox2D -small -O -includeall -ignoremissing -w201 -globals b2Globals -outdir library/Box2D -keyword -w511 -D_SWIG_KWARGS -o Box2D/Box2D_wrap.cpp Box2D/Box2D.i
      error: command 'swig' failed: No such file or directory
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> box2d-py

This was my error message - brew install swig solved this too

On windows execute the command:
pip install swig
Then try the previous commands you were trying to install. In my case, it was pip install gym[box2d]. This worked for me:
Successfully built box2d-py
Installing collected packages: box2d-py
Successfully installed box2d-py-2.3.5

installation still failed on windows too

I have the same error on Win 11. I installed swig this way: pip install swig.
The errors:
swig.exe -python -c++ -IBox2D -small -O -includeall -ignoremissing -w201 -globals b2Globals -outdir library\Box2D -keyword -w511 -D_SWIG_KWARGS -o Box2D\Box2D_wrap.cpp Box2D\Box2D.i
Traceback (most recent call last):
File "C:\Users\paolo\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users\paolo\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Users\paolo\AppData\Local\Programs\Python\Python310\Scripts\swig.exe_main.py", line 4, in
ModuleNotFoundError: No module named 'swig'
error: command 'C:\Users\paolo\AppData\Local\Programs\Python\Python310\Scripts\swig.exe' failed with exit code 1

I am facing similar problem on my Windows11. Anyone found the solution?

similar issue to paolo

pip install swig doesn't fix the problem on Windows.
I installed SWIG with Chocolatey: choco install swig -y,
then ran: pip install "gymnasium[box2d]", and it worked.


allow us to hide route that are displayed on psd/platform gates

like maybe u shift-right click with brush on psd/gates then u get a gui allow u to choose what lines to be displayed and what not (routes and desnation) to so for example u have normal TSL on a platform and another special line you can choose to only display TSL on psds but the special line still works
i think its better to make a post here idk if u will miss any on discord and i dont want to brother u by pinging lol

Don't think this is necessary now that displaying branch routes have been implemented. Thanks for your suggestion!


run ptipython in bash give error: No module named terminal.embed

I install with
pip install ptpython

the ptpython works ok, but when I try to run ptipython, it give the follow errors.
Traceback (most recent call last):
  File "/usr/local/bin/ptipython", line 9, in <module>
    load_entry_point('ptpython==0.5', 'console_scripts', 'ptipython')()
  File "/usr/local/lib/python2.7/dist-packages/ptpython/entry_points/run_ptipython.py", line 35, in run
    from ptpython.ipython import embed
  File "/usr/local/lib/python2.7/dist-packages/ptpython/ipython.py", line 25, in <module>
    from IPython.terminal.embed import InteractiveShellEmbed as _InteractiveShellEmbed
ImportError: No module named terminal.embed

I have tried to install terminal but it still not work.

I guess you have an older version of IPython. Could you try running:
pip install -U IPython

yes, it work ok now, thanks.


Chunks Only Save to Disk When Paused

Chunks are only saved when the server is paused. This means that closing the game will throw away a majority of the chunks, and starting another world will make the game run out of memory. Saving chunks while the server is running will lessen the backlog of chunks to save after each run.
Line like these appear every second while the server is paused or closed:
19:26:40.320 INFO  File IO Thread cubicchunks.server.CubeIO: Wrote 24 columns (0 remaining) (19k) and 250 cubes (13463 remaining) (50k) in 978 ms
However, on large render distances these get out of hand.

Chunks are saved while the server is running, it just doesn't happen as frequently since the server is  usually overloaded doing other stuff.

Alright yeah! That's the sorta thing I was interpreting... I was noticing this most when falling, for example. Anyway, yeah I figured I should report it! ;)

Saving doesn't actually take that long if you run Minecraft on an SSD. I don't even have a spinning disc hard drive anymore, so this is probably running WAAAAY longer for you than it is for me. All the same, we're working on performance improvements.


Visually group teams in players table

It can be difficult to identify teams at a glance with the table format, would be good to have at least a mode that groups players by  team.

Added in #227


Add list with required files for components

When working with bootstrap.css all you gotta do is, basically, copy-and-pate or use some snippet tool. There is no worry about "what components/utilities should I import in order to this component to work" appropriately.
With that in mind, as opposed to let every single developer figure it out, would be a real time saving (especially for newbies) if there were two lists, in every component documentation: required and suggested files.
As an example for navbars, we would have something like this:
If you're building Bootstrap with Sass, you will need these files:

- @import "~/node_modules/bootstrap/scss/navbar";
- @import "~/node_modules/bootstrap/scss/nav";
- @import "~/node_modules/bootstrap/scss/transitions".

This kind of summary already exists for required JS files, as this documentation section shows. Although, it could mixed with the above list, so to avoid users needing to get back there.
If you're building Bootstrap with Sass, you will need these files:

- @import "~/node_modules/bootstrap/scss/navbar";
- @import "~/node_modules/bootstrap/scss/nav";
- @import "~/node_modules/bootstrap/scss/transitions".

And if you're also building JS files, these components requires:

- <script src='~/node_modules/jquery/dist/jquery.slim.js'></script>
- <script src='~/node_modules/bootstrap/js/dist/util.js'></script>
- <script src='~/node_modules/bootstrap/js/dist/collapse.js'></script>

PS: JS file imports needs to be in the given order.

I just noticed that, something similar already happens, though it is not as efficient as the above idea.
With the idea stated in this issue, the " How it works" section would be way clear.

I have just gone through setting up individual JS and SCSS files for the first time and have to agree. It would save a lot of investigation and testing by improving the documentation. It is not entirely clear; what the order should be, what is required, what is optional, what depends on what, or the purpose of each file. I envisage a cheat sheet of sorts could fully cover this.

Closed as a duplicate of #23813.


Added shader_basic_pbr example to website

Added shader_basic_pbr example
c3 language binding  icon

@devdad thank you very much for adding it!


Work around for local gardener-operator kind setup on MacBooks: Use alternative IP address

How to categorize this PR?

/area dev-productivity
/kind discussion
What this PR does / why we need it:
On some corporate MacBooks the Alternative way to set up Garden and Seed leveraging gardener-operator is not working with the local IP <IP_ADDRESS>.
The Skaffold command skaffold run ... -f=skaffold-operator-garden.yaml ... fails with
Deploy Failed. Could not connect to cluster due to "https://api.virtual-garden.local.gardener.cloud/version": EOF. Check your connection for the cluster.

It turned out that it works when using an IP address from the docker network kind <IP_ADDRESS>/16.
So this PR suggests to use the IP address 172.18.255.x instead of 127.0.0.x if x > 1 as a work around.
Using an IP address from the upper end of the IP range of the docker network should be save for typical usage.
There is still no resolution in sight with the interference between Docker Desktop and corporate network extension patches even after involving IT support.
/hold First want to check if all tests are working with the alternative IP address as expected.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Replaces #9987
Release note:

The IPv4 addresses for local Gardener setup leveraging gardener-operator and for end-to-end tests have been changed from `127.0.0.x` to `172.18.255.x` to resolve an issue on MacBooks with corporate network extensions.

The file `/etc/hosts` has to been updated when the local Gardener setup is used leveraging gardener-operator or for running end-to-end tests. Please see [Deploying Gardener Locally#Accessing the Shoot Cluster] (https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md#accessing-the-shoot-cluster) for more details.

/cc @oliver-goetz
/assign

/retest

Before unholding this PR, we could adjust the remote local setup configuration here: https://github.com/gardener/gardener/blob/cabc3184402c7205cc3bdeae52541da6af7e8cc2/docs/deployment/content/remote-local-setup.yaml#L54
I'll test it locally.

we could adjust the remote local setup configuration here...

Maybe we could include this commit in this PR:
https://github.com/istvanballok/gardener/commit/eac4c8a4af2e9ba10250d65bc340a6064cd4499b
Otherwise this modified operator setup works fine in the "remote local setup" as well.

/remove-lifecycle stale

/retest

How about <IP_ADDRESS>, shouldn't we replace this with <IP_ADDRESS>?

How about <IP_ADDRESS>, shouldn't we replace this with <IP_ADDRESS>?

Why to change something that is working? All developers would have to update their local /etc/hosts for no good reason.

For consistency reason, because I like consistency 🙂
Changing /etc/hosts takes only a minute or so.

/retest

/retest

/unhold

awesome 🚀
/lgtm

/test pull-gardener-e2e-kind-migration-ha-single-zone

/retest

Can you please add a release note, motivating the change and as an action item for developers to change their /etc/hosts?

Done. Additionally, the already existing check for matching entries in the /etc/hosts will stop the kind-xxx-up task with an error message anyway.

Additionally, the already existing check for matching entries in the /etc/hosts will stop the kind-xxx-up task with an error message anyway.

Only for running e2e test, doesn't it? It didn't fail for me when running make kind-up && make gardener-up.

Additionally, the already existing check for matching entries in the /etc/hosts will stop the kind-xxx-up task with an error message anyway.

Only for running e2e test, doesn't it? It didn't fail for me when running make kind-up && make gardener-up.

It should also fail for make kind-operator-up


请问在动画的时候能获取到每笔画结束的回调嘛？

Currently you'll need to manually animate each stroke individually if you want a callback on each individual stroke. For example, you could do something like:
await writer.animateStroke(0);
// do something after stroke 0
await writer.animateStroke(1);
// do something after stroke 1
await writer.animateStroke(2);
// etc...

I think it's a good feature request though, it shouldn't be hard to add that feature in the future

For the record, here's the English translation of the title of this issue (as of the time of this writing):

请问在动画的时候能获取到每笔画结束的回调嘛？

Can I get a callback at the end of each stroke during the animation?


Remove badges from README.md

:tada: This PR is included in version 4.0.27 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Function 3 - Slicing - Celeste Zhao

Write function definition with function and argument names without code for slicing an image.

PR requested approved!


Log creation macro.

I thought the log creation would be less confusing with a macro. It was confusing because we had to define a specific variable which we then never referenced. It was also a common name likely to cause conflicts. This way still has its own problems of course...
What do you think?

I thought the log creation would be less confusing with a macro. It was confusing because we had to define a specific variable which we then never referenced. It was also a common name likely to cause conflicts. This way still has its own problems of course...
What do you think?

I agree that if we're hiding the LOGGER variable usage in the FF_ERROR(etc), it's confusing to define it. This way it's explicit that it's used for the purpose of FF_(...).


Visibility of the DISPLAY_DEVICE::DeviceID members

Is there a specific reason why the getter for DeviceID and DeviceKey was removed from the DISPLAY_DEVICE struct?
Seems like it happened here: https://github.com/rodrigocfd/winsafe/commit/806c57509e1d747e8a7e36b1ec22917616669332#diff-61500d78eb074804b61d228b17c595974dd7cd10099a3cf8874919aee6239750R427

Hmm, looks like a mistake.


ev_search only seems to show ~183 tickets. Asking for more breaks it

ev_search -d -u nate --days<PHONE_NUMBER> | grep CLOSURE_CODE | uniq -c
183 HELP_CLOSURE_CODE: Successful
ev_search -d -u ssgev --days<PHONE_NUMBER> --max 100000000 | grep CLOSURE_CODE | uniq -c
matthews@chmgt:~>

Fixed in f7cff9be01f45cdb6d6c113e2a1d971ccab49b30


Android support ?

whould be gr8 if we could acces bat links from android.

@NicTanghe there are a couple of dat/hypercore-protocol mobile (Android/iOS) projects. Here's a few:

Bunsen Browser (old dat:// only)
Gateway Browser (hyper://-enabled)


Problem using useField with Material-ui select component

Working with useForm and useField and the Material-ui select component i've noticed a bad behaviour caused by the onBlur function.
When I click the select to select a value, the focus pass to the custom dropdown select menu from the real select.
This cause a form rerender (the field's isTouched prop change value) which can cause performance problem with big select components.
Is there any way to avoid this behaviour ?

Hey all, I'm closing this issue as it appears to be related to a version of the old non-current @tanstack/react-form and friend APIs. We're looking to 1.x soon enough, and I want to more easily filter down to more recent issues.
Thanks for being early adopters of our tooling! We know that it can lead to issues like this being unresolved sometimes, but we're working hard on the new iteration of Form.
Maybe take a look and let us know what you think?
https://tanstack.com/form
Best,

Corbin


Add automation to setup lens model

Codecov Report
Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6b9489a). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

dolphin/processor/files.py
66.66%
5 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage        ?   99.04%
=======================================
  Files           ?        8
  Lines           ?     1048
  Branches        ?        0
=======================================
  Hits            ?     1038
  Misses          ?       10
  Partials        ?        0

Files with missing lines
Coverage Δ

dolphin/processor/data.py
100.00% <100.00%> (ø)

dolphin/processor/files.py
96.42% <66.66%> (ø)

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


DS-3551 db connections reduction

Pull request for
https://jira.duraspace.org/browse/DS-3551

I've updated the javadocs + call to "getColumnNames(null, table))".
Currently added an additional "ContextAware" DisseminationCrosswalk implementation.
Subclasses of this need to make sure they :

Use a context if one is provided (Instead of creating a new one)
Handle the end of the context appropriately (Don't try to call complete on a context that isn't newly created-> Avoiding invalid Contexts later on)

I've also noticed that the failing tests have been present from before my commits.

@jonas-atmire : it looks like the latest dspace-5_x branch is passing its tests (see https://travis-ci.org/DSpace/DSpace/branches). So, perhaps try and rebase your PR on the latest code to get rid of these test failures?

@tdonohue The dspace-5_X branch is failing for me locally though, using the same parameters as used for the Travis build.
It seems to me the failing tests, and tests in error are the same as before the rebase.
Am I missing something? (For example one of the tests in error is "Bitstreamtest.testInError" which complains about "ConstitutionofIreland.pdf" not being found etc)

@jonas-atmire : Unfortunately, I'm not sure what is going on here. But, Travis CI seems to have major issues with this PR branch. It shows a massive number of SQL errors when running the Unit Tests, which you can see here: https://travis-ci.org/DSpace/DSpace/builds/226765047#L6118   My guess was that you branch may be outdated, but I'm not exactly sure what is going on.  Currently, the latest version of the dspace-5_x branch builds/tests fine in Travis CI, see here: https://travis-ci.org/DSpace/DSpace/branches   So, something is different between this PR's branch and the latest code on dspace-5_x which seems to be causing Travis to complain.
The code here looks reasonable, but I haven't had time to run tests locally myself (perhaps someone else will have time).  We won't be able to merge this though until Travis CI also shows no test failures.

@tdonohue The build is now passing.
Since some methods had altered in the DatabaseManager, they weren't properly mocked anymore.
Fixed this by updated the "MockDatabaseManager" to also mock the "process" method that contains a passed Context.

The failed testing I encountered previously was my own fault and nothing to do with this PR or the test instructions given. Thanks @jonas-atmire for following up and for this very useful PR


Link to branch links to current repository and not deploy-repository

When the action creates the comment on the PR, the link provided to the preview-branch does not point to the deploy-repository but the repository that the PR was made on.

Fixed in v1.4.5


Minor improvements in the portfolio

Things added/changed:

Minor improvements in the portfolio

All the changes are shown in the Git diff. If you have any questions about them, please let me know below. 🙂

Thankyou for your contributions <3 @Panquesito7


Automatically populate PropertySource with instance metadata when running within an EC2-based environment

:loudspeaker: Type of change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description
A new package added to the autoconfigure project (with test classes) to populate a PropertySource whenever IMDS is present, which occurs on EC2, ElasticBeanstalk, ECS, EKS, etc.  Auto configuration silently ignores the absence of IMDS.  A starter pom is added, docs are updated.
:bulb: Motivation and Context
Issue addressed is:  https://github.com/awspring/spring-cloud-aws/issues/954
There are various times when an application needs to know its IP address, availability zone, region, mac address, etc.  All this is available via IMDS.  This feature simply adds these properties to the Environment when available.
:green_heart: How did you test it?
Three new classes, three new JUnit tests.  Plus I created a sample application using the libraries for a sanity test.
:pencil: Checklist

[ x] I reviewed submitted code
[x ] I added tests to verify changes
[x ] I updated reference documentation to reflect the change
[ x] All tests passing
[x ] No breaking changes

:crystal_ball: Next steps
Others may wish to expand this to retrieve dynamic data, user data, set a common prefix, etc.  May want to use a ConfigProperties only to cause the one and only property to be documented.

Thanks @kennyk65 for a PR! We need an integration test for that. Until Localstack supports metadata endpoint (https://github.com/localstack/localstack/issues/8911) we would need to mock it - ideally with WireMock, to make sure whole flow works as expected.

Thanks @kennyk65 once again and apologies it took so long.

Thanks!  Let me know if I can help out with anything else.


First steps toward Windows :restart

For now, I figured out how to import the Win32 API functions we need and ported getppid.
But I'm not sure how to best invoke the cloned messenger. We need to tell it that it is the clone, which we could either do by giving it a command-line argument or by sending it a special message to stdin. I'm personally leaning toward the command-line method because it might be easier to implement, but I'm not sure.

The cloned messenger just needs to kill Firefox, wait a short while and start it again, right? So can't we just send it a message to do that? I suppose that is a special message in some sense.
You can use gen_message.py to generate messages in the right format.

The cloned messenger just needs to kill Firefox, wait a short while and start it again, right? So can't we just send it a message to do that? I suppose that is a special message in some sense.
You can use gen_message.py to generate messages in the right format.

Now I'm a bit confused here. Currently, :restart calls :qall once it hears back from the messenger. But that would cause you to lose your tabs, so was that just a contingency to get Firefox to exit anyway in case the messenger or the restart script didn't manage to kill it for some reason?

Now I'm a bit confused here. Currently, :restart calls :qall once it hears back from the messenger.  If you close them all quickly enough Firefox restores them when you start it again (provided you have "use my tabs from last time" enabled in about:preferences).
Yes it's mad but I asked nicely for a browser.quit command and Mozilla said no (see the "upstream bugs" issue).
PGP - 2BB8 C36B B504 BFF3 - https://keybase.io/bovine3dom/key.asc
On 24 January 2021 15:22:24 CET, Rummskartoffel<EMAIL_ADDRESS>wrote:

Now I'm a bit confused here. Currently, :restart calls :qall once
it hears back from the messenger. But that would cause you to lose your
tabs, so was that just a contingency to get Firefox to exit anyway in
case the messenger or the restart script didn't manage to kill it for
some reason?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tridactyl/native_messenger/pull/19#issuecomment-766356081

qall doesn't necessarily kill all your tabs. If you close them all quickly enough Firefox restores them when you start it again (provided you have "use my tabs from last time" enabled in about:preferences).
Yes it's mad but I asked nicely for a browser.quit command and Mozilla said no (see the "upstream bugs" issue).
PGP - 2BB8 C36B B504 BFF3 - https://keybase.io/bovine3dom/key.asc
On 24 January 2021 15:22:24 CET, Rummskartoffel<EMAIL_ADDRESS>wrote:

Now I'm a bit confused here. Currently, :restart calls :qall once
it hears back from the messenger. But that would cause you to lose your
tabs, so was that just a contingency to get Firefox to exit anyway in
case the messenger or the restart script didn't manage to kill it for
some reason?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/tridactyl/native_messenger/pull/19#issuecomment-766356081

I wasn't even consciously aware that option existed. Still, just killing Firefox is probably easier (and prevents a theoretical race condition where Firefox has already exited and its PID been reassigned before the cloned messenger obtains a handle).
I'll just have to decide whether to go the nice way by sending WM_CLOSE or to just terminate it in cold blood. The latter would probably be easier, but it would also nigh-guarantee that your tabs will be restored – because it'd make Firefox think it crashed, after which it tries to resume the previous session –, which some users might not want.

I wasn't even consciously aware that option existed. Still, just killing Firefox is probably easier (and prevents a theoretical race condition where Firefox has already exited and its PID been reassigned before the cloned messenger obtains a handle).
I'll just have to decide whether to go the nice way by sending WM_CLOSE or to just terminate it in cold blood. The latter would probably be easier, but it would also nigh-guarantee that your tabs will be restored – because it'd make Firefox think it crashed, after which it tries to resume the previous session –, which some users might not want.

I wasn't even consciously aware that option existed.

Huh, I thought it was the default. How else do people collect hundreds of tabs?
I think the kinder kill option is better.

I wasn't even consciously aware that option existed.

Huh, I thought it was the default. How else do people collect hundreds of tabs?
I think the kinder kill option is better.

After further consideration, I think I'd really prefer calling the clone using the command line, because sending it a message to stdin would entail having to deal with this mess and getting it ported to Nim.
Of course, Nim has better ways of writing to a child's stdin than that, but those would require using Nim's own procs to create that child in the first place. That isn't an option, because we need to use the low-level Windows API to get out of the parent messenger's job. I might yet decide to bite the bullet, but it might be a while before I get the motivation to.

After further consideration, I think I'd really prefer calling the clone using the command line, because sending it a message to stdin would entail having to deal with this mess and getting it ported to Nim.
Of course, Nim has better ways of writing to a child's stdin than that, but those would require using Nim's own procs to create that child in the first place. That isn't an option, because we need to use the low-level Windows API to get out of the parent messenger's job. I might yet decide to bite the bullet, but it might be a while before I get the motivation to.

Argument is fine by me : )

Argument is fine by me : )

@bovine3dom @Rummskartoffel
Have a look at my comments in the Python messenger around win_firefox_restart for this -- sending a SIGKILL/SIGHUP or similar to the Firefox process will kill the whole process tree with all the child processes which includes the native_messsenger. So, the main native_messenger process itself falls short in restarting Firefox.
To get around this, we need a datached process that is not killed when Firefox exits, and can restart Firefox after it gracefully exited. The Python messenger achieved this bying Window's native task scheduler. See stuffs around win_firefox_restart.ps1 in the Python messenger.
Hope this helps. Thanks.

@gsbabil, I am aware of that behaviour. The documentation states that it can be circumvented by using the CREATE_BREAKAWAY_FROM_JOB flag to create the process in question, so that's what I'll try to do.

@Rummskartoffel
CREATE_BREAKAWAY_FROM_JOB seems quite useful -- I don't remember having used or seen this bit of Mozilla documentation when we were  doing the win_firefox_restart thing in Python.

On Windows, the browser puts the native application's process into a Job object, and kills the job. If the native application launches any additional processes and wants them to remain open after the native application itself is killed, then the native application must launch the additional process with the CREATE_BREAKAWAY_FROM_JOB flag.

One immediate note that comes to mind is I hope the CREATE_BREAKAWAY_FROM_JOB allows the new process to survive after both native_main.exe and firefox.exe exited. From the documentation above, it seems that they are only talking about the native_main.exe exit scenario. I hope this is not the case.
SysInternals Tool-set has this utility called Process Explorer that is quite handy to check system's process tree almost in real-time, specially when you are invoking native_main.exe and forcing firefox.exe to restart.
Hope this helps. Thank you.

@bovine3dom @Rummskartoffel

You can use gen_message.py to generate messages in the right format.

To test win_firefox_restart, you'd want to run the following on shell to test new native_main.exe functionality:
$ ./gen_native_message.py
[+] Usage: gen_native_message.py cmd [command] | native_main.py

   - Note: Use '..' as key-value separator
   - Example: gen_native_message.py cmd..win_restart_firefox profiledir..auto browser..firefox | native_main.py

@bovine3dom @Rummskartoffel

qall doesn't necessarily kill all your tabs. If you close them all quickly enough Firefox restores them when you start it again (provided you have "use my tabs from last time" enabled in about:preferences).

Yes it's mad but I asked nicely for a browser.quit command and Mozilla said no (see the "upstream bugs" issue).

Asking Firefox to exit gracefully is definitely the best thing to do in the restart scenarios. At the very least, it will ensure that the users don't lose their tabs, browsing history etc.

Sending WM_CLOSE to the right Firefox window handle might be sufficient for this. But whether native_main.exe or other child processes survive after firefox.exe exits is really the key question. As added above, I certainly hope CREATE_BREAKAWAY_FROM_JOB is sufficient to keep native_main.exe or another child process alive since it'll lead to a cleaner implementation avoiding all the hacks.

Other than about:preferences as @bovine3dom mentioned, if you enable "Restore previous session" option in the Firefox's Preferences > General section, it'll also do the same -- restore everything after a graceful browser restart.

I'm relatively close to a working version now, but the code's gonna need a bunch of clean-up and better documentation to make it at all understandable or maintainable, I think. Since it doesn't yet work, I'm not going to mark it as such, but I think now the existing code is ready for review.

We've got a working version (at least on my machine 😉)!
I've noticed something strange while looking at the code for the old messenger: it has a special case for profiledir: "auto", but that value never gets passed to the messenger.


update argument display

Resolves #167

Only display args on the transaction details page
why?

@icerove deleting a legal test is not a solution!

BTW, I never delete your existing test, just delete one new test I write but find out there is some issue with it and not good to hold. Since you asked to fix and add, I change it back


Investigate using a "virtual" (@)@unique as workaround on No-identifier-tables

We do not support No-identifier-tables (no PK, no UNIQUE) right now and thus have to comment them out in the schema for now.
One of the suggestions we could give users to fix or workaround this limitation (next to adding a PK column or UNIQUE constraint manually), would be to add a virtual @unique to one field or an @@unique to a combination of fields in the model.

Does that actually help the Query Engine to be able to read data from these tables?
What about writing or updating?
What happens if there are actually 2 rows with the same content, thus failing this virtual constraint?
What about relations from these tables?
What about relations to these tables? (should not be possible/happen)

If this works, we have to reopen/recreate https://github.com/prisma/prisma2/issues/1588

The reflection around this has evolved a lot since @@ignore in introspection/migrate. Tables without identifiers are now fully supported in introspect/migrate. And these tables still couldn't be handled by the Client. So this issue can be moved over to the client side.

Not a big user problem any more, so we are not interested in this workaround any more and might just fix this underlying limitation one day - maybe.


Upgrade depenency 4.7.4

Upgrades openfire dependency from 4.2.3 to 4.7.4
Cleans up some SOPs replaces them with improved trace level logs.

Fixes #9

Thanks @krisiye!


fix(schemas): Fix gitlab_sync type mismatch

fixes #372
Signed-off-by: Matheus Horstmann <>

Thanks a lot for addressing this too! I'll release a new version right away


Miners Stopped Adding In panel

Hello my miners just stopped adding themselves in the panel but they are coming up in my pools. woke up today and they had stopped updating. but the miners that were there are still there. Am using the same .exe miner as before.

And the web panel URL has not been changed in any of the configurations? And are you sure that your webserver/webhost is not blocking the connections?

No changes happened.
Maybe if the webserver is blocking the connection.
On Thu, Jun 29, 2023, 10:43 PM Unam Sanctam @.***>
wrote:

And the web panel URL has not been changed in any of the configurations?
And are you sure that your webserver/webhost is not blocking the
connections?
—
Reply to this email directly, view it on GitHub
https://github.com/UnamSanctam/UnamWebPanel/issues/271#issuecomment-1613702063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQXCLEJRUH42VUB2UX3DWHDXNXLHBANCNFSM6AAAAAAZY574FQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello with the local host will it be able to show miners not on my machine?


KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I copied what was done in previous releases. I'm unsure if any APIs have changed or what to really look for.
@mjsax @vvcephei Can you take a look?

@mjsax I also noticed https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java#L180
This was not updated for 3.4, does this need updating too?

Good catch, @mimaison .
It looks like we could keep adding "upgrade from" versions on each release, but unless there's a compatibility issue, we don't need to. If you look at git blame, you can see that, in the past, we didn't add those cases one at a time, but in chunks when we had a compatibility problem to manage.

Thanks for confirming @vvcephei -- as a matter of fact, we released KP-914 with 3.5, so it seems to be an issue. Let me do a PR to address this and also add a test to get a guard in place.

Are there compatibility issues with 3.4 or 3.5?

With KIP-904 we changes some serialization format inside an internal repartition topic (cf https://cwiki.apache.org/confluence/display/KAFKA/KIP-904%3A+Kafka+Streams+-+Guarantee+subtractor+is+called+before+adder+if+key+has+not+changed)
To upgrade KS correctly, you need to do two rolling bounces (first one with upgrade.from = 3.4 -- or whatever version you are using), and second one with the config set back to null.
Thus, it seems, while the upgrade path for KP-904 itself works, the AssignorConfiguration you mentioned would not recognize 3.4.0 an thus crash Kafka Streams.
We did not get to finish the system test for this upgrade (it's a WIP PR), that I assume would have caught this issue...

I just uploaded the artifact for 3.5.1 to the S3 bucket we use for system tests -- can we add 3.5.1 in this PR right away (or even wait for 3.5.2 -- we might need a hotfix for this upgrade issue...?)

can we add 3.5.1 in this PR right away
I have added system tests to use 3.5.1 in https://github.com/apache/kafka/pull/14069

System tests look better with https://github.com/apache/kafka/pull/14103. In addition to a few flaky tests, I got 3 failures:
1.
    Module: kafkatest.tests.streams.streams_broker_bounce_test     Class:  StreamsBrokerBounceTest     Method: test_broker_type_bounce     Arguments:     {       "broker_type": "controller",       "failure_mode": "hard_shutdown",       "metadata_quorum": "ZK",       "num_threads": 1,       "sleep_time_secs": 120     }
2.
    Module: kafkatest.tests.streams.streams_broker_bounce_test     Class:  StreamsBrokerBounceTest     Method: test_broker_type_bounce     Arguments:     {       "broker_type": "leader",       "failure_mode": "hard_shutdown",       "metadata_quorum": "ZK",       "num_threads": 1,       "sleep_time_secs": 120     }
3.
    Module: kafkatest.tests.streams.streams_upgrade_test     Class:  StreamsUpgradeTest     Method: test_rolling_upgrade_with_2_bounces     Arguments:     {       "from_version": "3.5.0",       "to_version": "3.6.0-SNAPSHOT"     }
I still need to look at the logs of all failures but at first sight 1. and 2. don't seem directly related.

This depends on https://github.com/apache/kafka/pull/14103 so we need to get that merged first

@mimaison Merged the hotfix PR.

I rebased on top of trunk and reran the system tests in our CI. Many of the Streams upgrade system tests are flaky but I've seen all of them pass at least once apart from kafkatest.tests.streams.streams_upgrade_test.test_rolling_upgrade_with_2_bounces_from_version=3_5_1_to_version=3_6_0-SNAPSHOT. This one consistently failed across ~10 runs.
From my limited Streams understanding I don't see any obvious issues in the logs. @mjsax can you take a look and see if it's just really flaky or if there's a real issue. Is is passing in your CI?  I've uploaded the logs from the last run to my Apache home directory: https://home.apache.org/~mimaison/streams-upgrade-failure.zip

We also observed failing tests -- it's on our TODO list but might take some time until we get to it :( -- I'll keep you posted.

@mjsax These missing tests are starting to pile up. We're already missing them for 3.4 and 3.5, and 3.6 will be out shortly. If we were to break compatibility in Streams how would we notice it if we don't have these tests? Actually do we know whether the failures are caused by the tests or by issues in Streams? Figuring this out seems relatively high priority for me.

I identified one fundamental problem in 3.3 release -- a bug was introduced that fundamentally breaks KS systems tests using that version. This PR (https://github.com/apache/kafka/commit/fa0324485b1e76388bb15ea98170cfb9202aab1f) changes ProcessorParameter and allows this.processorSupplier to be null what breaks toString() method on the same class.
It was fixed via https://github.com/apache/kafka/commit/0de037423bef416abd654bd8b90b642d56eb33ea but it's only included in 3.4.1 release -- while it was backported to 3.3 branch, too, we never did a bug fix release afterwards and thus the system test that pull release binaries only cannot pickup the cherry-pick.

Another issue just introduced in trunk -> https://github.com/apache/kafka/pull/14490

Thanks @mjsax for following up. So what's the path forward? Are we able to merge this or do we need to release new bugfix versions for 3.3 and 3.4 (and 3.5?)?

I just opened a PR to fix trunk -- if this PR is merged, I can cherry-pick it to older branches, and you can rebase this PR so we can verify everything is in order and we can merge this one.
https://github.com/apache/kafka/pull/14539

while it was backported to 3.3 branch, too, we never did a bug fix release afterwards and thus the system test that pull release binaries only cannot pickup the cherry-pick

I could not reproduce the issue any longer and did more digging -- it think I hit this issue previously because we did not bump the Dockerfile to use the latest bug fix versions. Looking into the fix for this, it's actually shipped with 3.3.2 release, so I think we are fine.

I rebased this PR on trunk

https://github.com/apache/kafka/pull/14539 is not merged yet... So that's expected I guess. -- We actually also just found another bug that was fixed in the meantime: https://github.com/apache/kafka/pull/14555
Let's see if we can push 14539 over the finish line first... Will ping here again after that's done; sorry that it take so long, but we are on it. Promised.

Summary about your test results:

streams_upgrade_test expected to still fail because 14539 was not merged yet
streams_cooperative_rebalance_upgrade_test -- seems to be flaky -- after re-running them multiple times, I got each one to pass at least once locally (we should still try to stabilize this test, but I don't think it's a broker to move forward with this PR)
streams_broker_down_resilience_test -- this test was broken by a recent commit (https://github.com/apache/kafka/commit/fcac880fd54efbec3fe385000cf990a19972dafa) which changes a log message the test expects -- I'll add a fix to 14539 for it
streams_broker_compatibility_test -- all test passed locally on the first run; not sure -- if we indeed see issues on Jenkins we need to figure out why it's flaky

Updated https://github.com/apache/kafka/pull/14539 and re-triggered a system test run. Let's hope for the best :)

Merged the other PR. Btw: should we split this PR into two, one to add 3.4 and one to add 3.5? So it's easier to cherry-pick? (Adding 3.5 should only go into 3.6 branch, but adding 3.4 should got into 3.6 and 3.5 branches.)

@mjsax Good call, I've split this PR in 2:

3.4: https://github.com/apache/kafka/pull/14601
3.5: https://github.com/apache/kafka/pull/14602

Closing this PR


Fix: change type of attribute public to bool

https://github.com/goharbor/terraform-provider-harbor/issues/392

Hi @niklasbeinghaus ,
it's done like that because the harbor api :

if you need it as boolean, it will need a more rework
can you tell me what is your usecase ?


UWP ShortcutGenericAnalysis cause This object cannot be invoked because it was metadata-enabled for browsing only:

adding ShortcutGenericAnalysis  property in csproj while using automapper to map a struct type cause MissingRuntimeArtifactException.
Steps to reproduce
1- clone the reproducing solution : https://github.com/TheFo2sh/UwpDotNativeIssues
2- run using release 64 bit configuration
Expected result
project run successfully
Actual result
System.Reflection.MissingRuntimeArtifactException: 'This object cannot be invoked because it was metadata-enabled for browsing only: 'System.Func<Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext,Optional.Option<TestAutomapper.OB>>.Invoke(Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext)' For more information, please visit  http://go.microsoft.com/fwlink/?LinkID=616867'
More Info
if you remove ShortcutGenericAnalysis  from the csproj , the project build and run correctly. In a lot of cases using ShortcutGenericAnalysis  is mandatory to get the build done as without i get compiler craches.

any updates regarding this issue ?

Hi,
I have the same problem, in your sample you have missing ClassLibrary3 source.
You have fix the problem?

The bigger question now is whether any UWP related questions get any attention ever?  Microsoft needs to clarify it's position on UWP.  It's starting to look like UWP is dead within the company and so it's now ok to let questions like this languish.  Doesn't look good.

I also cannot compile my project and am considering using  ShortcutGenericAnalysis - however this issue makes me question if it is safe to use. How can I test my app to go sure there won't be any runtime errors? Are there any other drawbacks using it?

System.Reflection.MissingRuntimeArtifactException: 'This object cannot be invoked because it was metadata-enabled for browsing only: 'System.Func<Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext,Optional.Option<TestAutomapper.OB>>.Invoke(Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext)' For more information, please visit http://go.microsoft.com/fwlink/?LinkID=616867'

The ShortcutGenericAnalysis option shortcuts analysis of generics that might result in the compiler missing some dynamic patterns.
The exception message has this URL in it: http://go.microsoft.com/fwlink/?LinkID=616867. Does the URL not help?
Based on the URL, I think you need to add following fragment to your RD.XML to help where the analysis failed:
<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
  <Application>
    <Type Name="System.Func{Optional.Option{TestAutomapper.OA},Optional.Option{TestAutomapper.OB},AutoMapper.ResolutionContext,Optional.Option{TestAutomapper.OB}}" Dynamic="Required All" />
  </Application>
</Directives>

System.Reflection.MissingRuntimeArtifactException: 'This object cannot be invoked because it was metadata-enabled for browsing only: 'System.Func<Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext,Optional.Option<TestAutomapper.OB>>.Invoke(Optional.Option<TestAutomapper.OA>,Optional.Option<TestAutomapper.OB>,AutoMapper.ResolutionContext)' For more information, please visit http://go.microsoft.com/fwlink/?LinkID=616867'

The ShortcutGenericAnalysis option shortcuts analysis of generics that might result in the compiler missing some dynamic patterns.
The exception message has this URL in it: http://go.microsoft.com/fwlink/?LinkID=616867. Does the URL not help?
Based on the URL, I think you need to add following fragment to your RD.XML to help where the analysis failed:
<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
  <Application>
    <Type Name="System.Func{Optional.Option{TestAutomapper.OA},Optional.Option{TestAutomapper.OB},AutoMapper.ResolutionContext,Optional.Option{TestAutomapper.OB}}" Dynamic="Required All" />
  </Application>
</Directives>


New term requests: fluorescence microscopy and confocal fluorescence microscopy

Pascale mentioned that I can close the ticket as ECO:0000007 immunofluorescence evidence is the term that she is looking for. She will not need the requested terms.


smartStep isn't found unless also tagged

If you invoke behat with --tags=tagyouwantrun, and the Scenario tagged with @tagyouwanttorun calls a @smartStep scenario as a step, it won't work unless the scenario is also tagged with @tagyouwanttorun.  It will fail and claim it's an undefined step.

Of course, it's a tag like others. If you want's to use tag filters and smartstep in a same time.... Don't use smartstep. Or add smartStep to your filter.


PostgresSubscribableChannel - traceId and spanId are not added to log

I have an application that uses PostgresSubscribableChannel to receive notifications from postgresql.
When a new message is received it contains traceId and spanId in message.getHeaders(), but are not visible in log message. What am I missing in my configuration?
Versions I am working with:

spring-boot:3.2.2
micrometer-tracing-bridge-brave:jar:1.2.2
spring-integration-jdbc:jar:6.2.1
micrometer-tracing:jar:1.2.2
micrometer-tracing-bridge-brave:jar:1.2.2
micrometer-observation:jar:1.12.2

Configuration
    @Bean
    public JdbcChannelMessageStore messageStore(DataSource dataSource) {
        var messageStore = new JdbcChannelMessageStore(dataSource);
        messageStore.setChannelMessageStoreQueryProvider(new PostgresChannelMessageStoreQueryProvider());
        return messageStore;
    }

    @Bean
    public MessageChannel messageChannel(JdbcChannelMessageStore messageStore, ObservationRegistry observationRegistry) {
        var queueChannel = MessageChannels.queue(messageStore, "group-id")
                                          .getObject();
        queueChannel.registerObservationRegistry(observationRegistry);
        return queueChannel;
    }

    @Bean
    public PostgresChannelMessageTableSubscriber subscriber(DataSourceProperties dsp) {
        return new PostgresChannelMessageTableSubscriber(() -> DriverManager.getConnection(dsp.determineUrl(), dsp.determineUsername(), dsp.determinePassword())
                                                                            .unwrap(PgConnection.class));
    }

    @Bean
    public PostgresSubscribableChannel subscriptionChannel(PostgresChannelMessageTableSubscriber subscriber,
                                                           JdbcChannelMessageStore messageStore,
                                                           PlatformTransactionManager transactionManager,
                                                           ObservationRegistry observationRegistry) {
        var postgresSubscribableChannel = new PostgresSubscribableChannel(messageStore, "group-id", subscriber);
        postgresSubscribableChannel.setTransactionManager(transactionManager);
        postgresSubscribableChannel.registerObservationRegistry(observationRegistry);
        return postgresSubscribableChannel;
    }

Message listener
    @Bean
    IntegrationFlow streamOutboxMessage(MessageChannel subscriptionChannel, ObjectMapper objectMapper) {
        return IntegrationFlow
                .from(subscriptionChannel)
                .handle(message -> {
                    //traceId and spanId is not added to this log
                    log.info("Event received: {}", message.getPayload());
                    processMessage(message);
                })
                .get();
    }

This might be caused by the instrumentation in Spring Integration. Could you please open an issue against that repo?
They might need a minimal reproducer too to troubleshoot this.
Also, please check what happens if here:
.handle(message -> {
    //traceId and spanId is not added to this log
    log.info("Event received: {}", message.getPayload());
    processMessage(message);
})

You try to get the current observation from the ObservationRegistry.

/cc @artembilan

Let’s see if setDispatcherExecutor() on that channel wrapped with instrumentation helps somehow! On the other hand you can use a channel interceptor: https://docs.spring.io/spring-integration/reference/metrics.html#observation-propagation

Well, after looking into the code this morning, I realize that ContextExecutorService won't help.
And even ObservationPropagationChannelInterceptor won't work on that channel. The MessageWithThreadState is not Serializable to make it to be stored into DB when we send a message to this channel.
Since you say that traceId and spanId are present in the headers I suggest to enable observation on that handle():
                .handle(message -> {
                    //traceId and spanId is not added to this log
                    log.info("Event received: {}", message.getPayload());
                    processMessage(message);
                }, e -> e.id("myHandler"))

@EnableIntegrationManagement(observationPatterns = "myHandler")

This way an observation is going to be restored from those headers before your code is called.
Please, raise an issue in https://github.com/spring-projects/spring-integration, so we will look into a proper propagation via that (and similar persistent) message channel.
Thanks

Apparently the problem is not so simple, so created a respective issue for propagation revisiting: https://github.com/spring-projects/spring-integration/issues/9001.
For now it should work as:

Enable observation on the subscriptionChannel
Enable observation on the handle()

So, apparently there is some race condition with Java DSL and management configurer bean post-processor (I'll investigate that separately).
And here is a working sample, but based on the messaging annotations instead: https://github.com/artembilan/sandbox/tree/master/postgres-channel-observation.
It sounds like we just need to mention in Spring Integration docs how to propagate an observation (tracing, essentially) over this kind of persistent channel.
And also that the mentioned ObservationPropagationChannelInterceptor is not suited for persistent channels, because an Observation is not Serializable.
On the other hand it might be deprecated altogether since sender observation is closed when the send() operation is done.
Therefore we need a new observation on the receiving side, which is done by the mentioned enabled observation on the channel subscriber.

OK. Figured out what is going on with Java DSL.
The .handle((m) -> ) produces a MessageHandler which is not a MessageHandlerSupport with an IntegrationManagement marker, but used as is for future subscription.
Therefore we cannot apply enableObservation on it.
How to mitigate that, I'll think over weekend...
I know: this feels like issue hijacking, but I wanted to close all the gaps before we move on 😄

@artembilan thank you for solving this issue and sending a working example.
I tested it in my app. After sending the message to the messageChannel it was stored to postgres then the new handler was notified about the message. It works as expected the traceId and spanId are propagated and restored in log.
Thanks :)👍


Question: Is there an alternative for Ibinder in NET5/NET6 Isolated-process

At the moment we are still using some processes that are required to run in In-process mode because they rely on the IBinder interface. As it seems that this is not supported. Is there an alternative for this?

Not yet.
Can you share more information about your scenario? We're actively working on binding improvements and it would be good to track additional details here.
Thanks!

hi,  I would like to use Signal R binding information
public SignalRConnectionInfo Negotiate([HttpTrigger(AuthorizationLevel.Anonymous)] HttpRequestData req,
                                               [SignalRConnectionInfoInput(HubName = "Hub", UserId = "{query.userid}")]
                                               SignalRConnectionInfo signalRConnectionInfo)
        {

            _logger.LogInformation("Executing negotation.");
            return signalRConnectionInfo;
        }

i would like to force the user id from my own function without using any parameters like this
            var connectionInfo = await binder.BindAsync<SignalRConnectionInfo>(new SignalRConnectionInfoAttribute             {                 HubName = _hubName,                 UserId  = GetMyUserName(CertificateByteArray,             });

There won't be support for IBinder with the isolated worker. The guidance here is to use the service SDKs instead.
@Y-Sindo recently updated the SignalR samples and might be able to help answer any further questions.


feat!: deploy autobuild and flag persistence

:gift: Add autobuild to deploy
:gift: Add --remote flag as distinct from --build
:gift: Adds git-x flag persistence
:gift: Command help update and expansion
:gift: Improved tests and bug fixes to namespace
:broom: Test update to use client API
:broom: General test case cleanup

* Updates the `deploy` command with the `--build` logic from the `build` command which now supports `--build=auto`
* Adds a flag `--remote` to indicate if a deployment is to be triggered on-cluster
* Git flags for on-cluster builds persist by default

Fixes #1075  - Primary discussion of UX changes
Fixes #1115
Fixes #857
Fixes #1229
/kind enhancement

/hold for commentary

Would be much better to actually split it into multiple smaller ones. And I know it is sometimes hard to achieve :)

Yes, this was one of those situations where I pull on a string and the whole sweater unravels.  I can take the time to split out some of the sub-goals which ended up being done here for more isolated introspection.

@lance also linter is complaining.

/override lint

/override style / Lint

@lance also linter is complaining.

Frustrating because this is not as easy to rectify as the previous issue with the conflict. This file actually should not even be in the PR.

@lance also linter is complaining.

Frustrating because this is not as easy to rectify as the previous issue with the conflict. This file actually should not even be in the PR.

Thanks for noticing.  That must have been remoed after this PR was first started, and it snuck back in during a rebase!
I made a few minor wording changes, help text tweaks etc... and removed that file.

@lance also linter is complaining.

Frustrating because this is not as easy to rectify as the previous issue with the conflict. This file actually should not even be in the PR.

Thanks for noticing.  Perhaps commands.txt has since been removed after this PR was first started, and it sneaked back in during a rebase.
I made a few minor wording changes, help text tweaks etc... and removed that file.

Awesome thanks @lkingland - truly appreciate you checking in on this while on your lengthy travels! We should be able to land this PR tomorrow. 🙏💪

/lgtm
Let's do this!

For some reason this PR is stuck in "Checking for Ability to merge automatially"
I first tried pushing a minor commit to restart the process (clearing the /lgtm status of course) to no avail.
I have now contacted GitHub support via ticket.  I don't expect a timely response, however, because I had no choice but to choose the option "Issue is transient, happening only once"
GitHub's official status shows no outages nor degredation.  I am now in a "wait-and-see" holding pattern..

/unhold

/shrug

/lgtm , I've just reviewed it too.. it is a pretty large PR but I think it is good to merge.. I am not sure what are the changes that we were waiting for this to be mergable

/retest

🥂


Fixed up for python 3.6

What
Patched for python 3.6

Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Can you add a new entry to the changelog, please?


Fix issue 7551 - Regex parsing bug for right bracket in character class

LGTM

Auto-merge toggled on


Datacapture, add label, leading icon and helper text to the textfields in sdc widgets.

Is your feature request related to a problem? Please describe.
As per new ux/ui guideline mentioned in the figma, it is expected to show label, leading icon and helper text to the text field in sdc widgets.
Textfields are used in sdc widgets such as QuestionnaireItemEditTextViewHolderFactory QuestionnaireItemDropDownViewHolderFactory QuestionnaireItemDatePickerViewHolderFactory  QuestionnaireItemDateTimePickerViewHolderFactory QuestionnaireItemDateTimePickerViewHolderFactory open choice type,
Action items :

Add helper text, label, leading icons to the questionnaire item in the questionnaire json.
Update textfields for label, helper text and icons

We can refer below screenshots.

25506fe9.png">

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

Thanks for detailed description, Can you assign it to me?

@Manikant25 thanks for showing interest, let me connect you with @jingtang10

This is just master ticket to track below tickets.
#1239, #1226, #1225, #1224, #1223, #1115

Closing this issue as referenced pr are merged.