[BUG] stop using mergeAndSetValidity for any nested type

Describe the bug
I filed this as a bug, but it really might just be a task.
There are multiple places where we are using mergeAndSetValidity on potentially nested types.
$ find . -type f -iname \*.scala | xargs grep mergeAndSetValidity
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/complexTypeExtractors.scala:            val hasValidEntryCV = hasNegativeIndicesCV.mergeAndSetValidity(BinaryOp.BITWISE_AND,
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/mathExpressions.scala:            zero.mergeAndSetValidity(BinaryOp.BITWISE_AND, lhs)
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/mathExpressions.scala:        repVal.mergeAndSetValidity(BinaryOp.BITWISE_AND, lhs)
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala:            val hasValidEntryCV = indices.mergeAndSetValidity(BinaryOp.BITWISE_AND,
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala:      list.mergeAndSetValidity(BinaryOp.BITWISE_AND, rhs.getBase)
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala:            equals.mergeAndSetValidity(BinaryOp.BITWISE_AND, equals, step)
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/collectionOperations.scala:        ret.mergeAndSetValidity(BinaryOp.BITWISE_AND, size)
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala:        withResource(strs.mergeAndSetValidity(BinaryOp.BITWISE_AND, strs, ends)) { rets =>
./sql-plugin/src/main/scala/org/apache/spark/sql/rapids/HashFunctions.scala:        fullResult.mergeAndSetValidity(BinaryOp.BITWISE_AND, normalized)
./sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:        _.mergeAndSetValidity(BinaryOp.BITWISE_AND, input)
./sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:              spaceCol.mergeAndSetValidity(BinaryOp.BITWISE_AND, strValue)
./sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:        _.mergeAndSetValidity(BinaryOp.BITWISE_AND, input)
./sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:              columns += spaceColumn.mergeAndSetValidity(BinaryOp.BITWISE_AND, nonFirstColumnView)
./sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:          _.mergeAndSetValidity(BinaryOp.BITWISE_AND, input) // original whole row is null

This operation will overwrite the null mask on a column.
https://github.com/rapidsai/cudf/blob/d24bf11838863739da014d828156e8bf638430ff/java/src/main/native/src/ColumnViewJni.cpp#L1762
This is not safe for any nested type, including strings.  CUDF does not want to support inputs for LISTS or STRINGS where the value is NULL, but the offsets are not empty.  Calling mergeAndSetValidity does not guarantee this and can cause some very subtile bugs in the future with CUDF.
We really should change the API in CUDF to throw an exception if we try to do this on anything that is not a fixed width type. We should also switch all of the code to that calls this to do the right thing in these case. That does not typically mean calling into a ColumnView or other similar API and trying to do something similar manually. If we want to do this correctly we need to do an ifElse call or something similar. It should not be too bad because that API already makes a copy of the input, so it may not actually be any slower.

Do you want to fix mergeAndSetValidity and continue using it? The line in https://github.com/rapidsai/cudf/blob/d24bf11838863739da014d828156e8bf638430ff/java/src/main/native/src/ColumnViewJni.cpp#L1762 just sets the null mask but keep the offsets intact. We can just call purge_nonempty_nulls to make the column clean.

Tried to search for set_null_mask in ColumnViewJni.cpp and found several other instances. So we may want to do a more extensive fix for all the callers to set_null_mask in JNI.

Do you want to fix mergeAndSetValidity and continue using it, instead of "stop using" it? The line in https://github.com/rapidsai/cudf/blob/d24bf11838863739da014d828156e8bf638430ff/java/src/main/native/src/ColumnViewJni.cpp#L1762 (+L1767) just sets the null mask but keep the offsets intact. We can just call purge_nonempty_nulls to make the output column clean (i.e., empty out the offsets).

How we do it is not that important. It would be nice to be able to think about performance too. The code as it is written right now makes a copy of the input column and sets the null mask on it. If we were to call purge_nonemtpy_nulls it is likely to make another copy.  If we optimized the first part to just make a column_view that would be fine.
Yes generally we have a lot of places where we might be doing really bad things and we need to actually start putting in place checks to detect these and avoid them before they happen. Because purge_nonempoty_nulls is not free it would be nice to find these and avoid them.

In C++, we allow potential pass-through for APIs like this (set null mask). That means we only make a copy if we have to (i.e., when we have to call purge_nonempoty_nulls with input lists/strings). Otherwise, just set null mask to the input column_view and return. We can optimize this mergeAndSetValidity in a similar way.

This is fixed because mergeAndSetValidity now purges non-empty nulls and also doesn't trample on already null values.  This was fixed in https://github.com/rapidsai/cudf/pull/13335.


Add support for jit.si video meetings

I guess the title says it all. It's in the form of https://meet.jit.si/meetingname

Is it ok to piggyback bluejeans links on this ticket as well?
e.g., https://bluejeans.com/#######


debug heat sources outdoors

i think that's the problem
https://github.com/D3c3453d/StardewSurvivalProject/pull/2/files#diff-e2aeba4ee7a13642c04ffed451b73bf536227f53ad88c436375cf8f5f1a7829eR202
https://github.com/D3c3453d/StardewSurvivalProject/pull/2/files#diff-e2aeba4ee7a13642c04ffed451b73bf536227f53ad88c436375cf8f5f1a7829eR207


added options for postcss-import

So I can do this
https://github.com/des-des/tachyons-webpack-boilerplate/blob/master/lib/build.js#L14
ie
tachyonsBuildCss(input, {
  atImport: {
    path: [
      path.join('node_modules', 'tachyons', 'src'),
      path.join(__dirname, 'app', 'css')
    ]
  },
  from: srcPath,
  to: destPath,
  minify: true,
  plugins: []
}).then(result => {
  fs.writeFileSync(destPath, result.css)
})

Giving the user control over to paths that postcss-import uses allows me to easily / elegantly extend tachyons
like this: https://github.com/des-des/tachyons-webpack-boilerplate/tree/master/app/css

I can add a test case if you like, it tested it locally with on the project linked and it is doing what I want it to.

@johnotander ping

Thanks!

Published to npm as<EMAIL_ADDRESS>


Implement range adaptor

Range adaptor implementation would allow to use hashing as follows:
std::string src = "abc", res = src | hashed<sha2<256>>;

Done with 72527b2.


Running Future-returning tests sequentially

This is from the https://groups.google.com/forum/#!topic/scalatest-users/dZWxEzJkyVM forum thread (that contains more details, especially @bvenners comments on how this might be implemented), but adding here as an issue for better tracking.

I have tests of the following form (ran from both Scala JVM and Scala.js):
class MyTest extends AsyncFunSuite {
  def setup() : Future[Unit] = {
    // reset the remote test database to a known state
  }

  test("test1") {
    setup().map { _ =>
      // test code that returns a future
    }
  }

  test("test2") {
    setup().map { _ =>
      // test code that returns a future
    }
  }
}

I will like scalatest to execute tests serially i.e. logical equivalent of:
test("test1").andThen {
  // record success/failure of test1 and ...
  test("test2").andThen {
    // record success/failure of test2 and ...
    ...
  }
}

This way while test1 is running, test2 doesn't end up resetting the database.

Hi Ramnivas,
At long last I have a release for you to try. Thanks for your patience. It was quite a lot of work to get to this point, but in 3.0.0-SNAP6 we by default don't start an async test until the previous async test has completed. If you want async tests to run in parallel, you'll need to mix in ParallelTestExecution. I'll post a bit more detail about the latest changes on scalatest-users. Please give 3.0.0-SNAP6 a try and let us know if it works for your use case.
Thanks.
Bill

Hi @bvenners,
Thanks.
I could try AsyncFunSuite in a JVM project. It is working fine, except IntelliJ seems to not like tests that complete their Future in a delayed manner. Tests pass or fail randomly during each run (for me a delay of < 50ms makes it randomly fail, whereas anything above that makes it always fail). For example in the snippet below, while the testsuite passes fine from SBT, IntelliJ gives up while attempting to run the "this fails" test (no report, no failure or success). Probably an IntelliJ issue, but just wanted to let you know in case something has changed between what IntelliJ expects and Scalatest provides. Note that the second test ("this succeeds") always succeeds in IntelliJ (i.e. even though the test takes time, the future returned by the test has been already completed).
import org.scalatest._
import scala.concurrent.{ExecutionContext, Future}

class AsyncTest extends AsyncFunSuite {
  override implicit val executionContext: ExecutionContext = ExecutionContext.Implicits.global

  def setup(): Future[Unit] = {
    Thread.sleep(1000)
    Future.successful(())
  }

  test("this fails") {
    for {
      _ <- setup()
    } yield assert(true)
  }

  test("this succeeds") {
    Thread.sleep(1000)
    Future(assert(true))
  }

}

Hi Ramnivas,
Thanks for trying it. I'll experiment with IntelliJ and let you know what I
find.
Bill
On Tue, Oct 13, 2015 at 2:07 PM, Ramnivas Laddad<EMAIL_ADDRESS>wrote:

Hi @bvenners https://github.com/bvenners,
Thanks.
I could try AsyncFunSuite in a JVM project. It is working fine, except
IntelliJ seems to not like tests that complete their Future in a delayed
manner. Tests pass or fail randomly during each run (for me a delay of <
50ms makes it randomly fail, whereas anything above that makes it always
fail). For example in the snippet below, while the testsuite passes fine
from SBT, IntelliJ gives up while attempting to run the "this fails" test
(no report, no failure or success). Probably an IntelliJ issue, but just
wanted to let you know in case something has changed between what IntelliJ
expects and Scalatest provides. Note that the second test ("this succeeds")
always succeeds in IntelliJ (i.e. even though the test takes time, the
future returned by the test has been already completed).
import org.scalatest._import scala.concurrent.{ExecutionContext, Future}
class AsyncTest extends AsyncFunSuite {
override implicit val executionContext: ExecutionContext = ExecutionContext.Implicits.global
def setup(): Future[Unit] = {
Thread.sleep(1000)
Future.successful(())
}
test("this fails") {
for {
_ <- setup()
} yield assert(true)
}
test("this succeeds") {
Thread.sleep(1000)
Future(assert(true))
}
}
—
Reply to this email directly or view it on GitHub
https://github.com/scalatest/scalatest/issues/712#issuecomment-147854277
.

--
Bill Venners
Artima, Inc.
http://www.artima.com

PR submitted to fix this:
https://github.com/scalatest/scalatest/pull/740

Hi Ramnivas,
I merged in this PR and released a 3.0.0-SNAP7. I tried both M10 and SNAP7
with your test class with IntelliJ. SNAP7 always works for me. M10 never
works for me. So I think it should be fixed in SNAP7. Please give that a
try if you get a chance.
We are going to do an M11 that goes back to Unit for traditional styles and
gets rid of Safety and Compatibility. So that's coming, and it will have
this fix in it.
Thanks for trying it out.
Bill
On Tue, Oct 20, 2015 at 4:35 AM, Chua Chee Seng<EMAIL_ADDRESS>wrote:

PR submitted to fix this:
#740 https://github.com/scalatest/scalatest/pull/740
—
Reply to this email directly or view it on GitHub
https://github.com/scalatest/scalatest/issues/712#issuecomment-149420727
.

--
Bill Venners
Artima, Inc.
http://www.artima.com

Hi Bill and @cheeseng,
Cool! I just tried SNAP7 and it works for me.
Thanks for fixing this issue so quickly.
-Ramnivas

Hi Ramnivas,
No problem. I want to get 3.0 out the door. But I must take back my
previous note about what M11 will look like. Something didn't work out so
back to the drawing board. Been quite a battle with a bloat monster that
wants to move in.
Bill
On Tue, Oct 20, 2015 at 6:43 PM, Ramnivas Laddad<EMAIL_ADDRESS>wrote:

Hi Bill and @cheeseng https://github.com/cheeseng,
Cool! I just tried SNAP7 and it works for me.
Thanks for fixing this issue so quickly.
-Ramnivas
—
Reply to this email directly or view it on GitHub
https://github.com/scalatest/scalatest/issues/712#issuecomment-149644019
.

--
Bill Venners
Artima, Inc.
http://www.artima.com


Typo

Hey @Jhnbrn90
just noticed a typo ("Vuespress" instead of "VuePress") in the README.
Cheers,
Peter

Thanks! 👍🙂

No worries :+1:


lsass failure after reboot

Version: 8.6.427.243473
OS/Distro: Ubuntu 16.04.4 LTS (GNU/Linux 4.4.0-128-generic x86_64)
Issue/Impact:
I found that some Ubuntu servers fail to authenticate domain users after reboot.
The error messages range from:

LW_ERROR_PASSWORD_MISMATCH,
User is not in RequireMembership group
to
error: PAM: User not known to the underlying authentication module for illegal user

Output of get-status is as usual. Enum-users is also working.
How I fix this:

kdestroy krb5cc_ files, delete ad-cache, restart lwsmd.
Sometimes, I have to rejoin the server to the domain.
Other times, completely remove and reinstall pbis-open, rejoin to the domain.

Observation: as root user, run the command "service lwsmd stop", occasionally, the service doesn't stop at all. There is no error message or return errors. Only by using /opt/pbis/bin/lwsm stop [service] then /opt/pbis/bin/lwsm shutdown, that the entire process would shutdown cleanly.
Assumption: pbis-open fails to stop cleanly when the user reboots the server. The process later comes back in a bad state.
How to reproduce: Unsure. This is happening on some servers but not others even in the same environment.
If you'd like to see certain log files, try certain things, etc, please let me know and I can gather them next time this happens.

This sounds like there is an issue with the computer object in AD or the timeskew is getting too far apart. Next time this happens confirm that the ubuntu machine and DC times match up. I would also confirm that there are no replication issues between DC's within the domain.
Is LW_ERROR_PASSWORD_MISMATCH occurring on user login or a domainjoin-cli query?

no response closure


Cannot ignore file in Knip analysis

I have a file which makes Knip to fail. I want to ignore that file. So I did:
{
	"$schema": "./node_modules/knip/schema.json",
	"ignore": ["./bin/sudo-cli.js"]
}

The file is indeed ./bin/sudo-cli.js. And error is:
Unresolved imports (1)
../dist/index.cjs  bin/sudo-cli.js

So I cannot ignore that error.
Reproduce
Clone this project: https://github.com/tal-rofe/sudo-cli/tree/use-spawn
Checkout to use-spawn branch. Run pnpm i, then run pnpm knip. You also need to add "ignore": ["./bin/sudo-cli.js"] to knip.json file to reproduce.

:rocket: This issue has been resolved in v2.19.5. See Release 2.19.5 for release notes.

Now unresolved imports that are in .gitignore should be ignored by default.
By the way, you can now remove cz-vinyl from the list of ignored dependencies. And commitlint is an alias of @commitlint/cli so you could use them consistently and remove another from that list :)


When registering a host, the name is not being set properly

Version - master 2/3
Steps:

Create a host
Edit the host

Results:  The name you gave to the host is not being saved as name.
Expected:  Should be saved as name.

The name that is displayed for a host is now the first that is set of: name, hostname, (id).  (Hostname comes from the host OS and is generally always set).  The rancher/agent keeps hostname up to date with the current value from the host, and the name field allows the user to override what is displayed with their own value.
When you use docker-machine (AWS, DigitalOcean, etc, anything but Custom) the computer's hostname is set to the name you provided.  This gets picked up when the host registers with Rancher and filled in as the hostname.  So there is no need to fill in the user override value on a new host.
There does need to be better explanation of this on the host edit screen though, I changed it to:

Version - master UI 2/4
Verified fixed

I recently re-created my environment from scratch with the latest rancher. Previous versions had hosts start out showing their hostname. With the current version, hosts started out named '1h1', '1h2', etc. I'm unclear if this was the intended outcome of this issue.

@DanielDent What version of Rancher are you using? This was fixed in v0.59.0.

This was a fresh install on v0.59.0.

@DanielDent How are you adding your hosts?

Using the command provided on the 'add host' screen for a 'Custom Host'. That command is executed on a fresh Debian Jessie machine w/ Docker & other things preconfigured.
I'm not 100% sure, but I believe that in the version I was using before, the hostnames did get autodetected properly. While I know there was a bug fix, from my perspective there appears to be a regression.

Same problam here with rancher v0.59.0 and  v0.59.1

I have not been able to reproduce on v0.59.1 or v0.59.0. I'm using the custom host command on a fresh machine as well. This was fixed specifically in between v0.56.1 and v0.59.0, so I don't think there is a regression.


About Sakundi Text for readme

About text in English and Spanish
Sakundi intends to provide security and privacy services for Blockchain networks and their different stakeholders. We plan to start by providing security monitoring solutions to identify relevant incidents using Artificial Intelligence approaches. By alerting the users or stopping the detected attacks, we aim to reduce the risk of critical incidents and increase the security of Blockchain networks, Dapps, and their used computing infrastructure. In future work, we would explore other services, such as automated smart contract audits.

website: https://sakundi.io ?
social media accounts:

@kuronosec  Please provide a logo for this page

Sakundi is a blockchain-based security solution that utilizes the power of artificial intelligence and automation. We offer Software-as-a-Service solutions to automatically monitor, detect, and visualize security incidents in Blockchain networks, decentralized applications (D-apps), and infrastructure. In addition, Sakundi's mission is to ensure the security of blockchains by developing solutions that are supported by scientific research and can be easily deployed via plug-and-play services. Our team is made up of specialists from all around the world that are expert in the fields of cybersecurity, blockchain, Fintech, and DeFi ecosystems.
Website: https://sakundi.io/
Linkedin: https://www.linkedin.com/company/sakundi/

@kuronosec Could you please review the about Sakundi text


Add Selection Sort Algorithm in Javascript

🚀 Feature
Selection sort is a basic sorting algorithm
Have you read the Contributing Guidelines on Pull Requests?
YES
Motivation
Selection sort is one of the basic algorithms. As javascript is one of the most popular languages this algorithm should be implemented in this language.
Pitch
After it is implemented it can be used as a reference to learn this algorithm. Having a fair bit of experience in algorithms I can implement this in javascript.

can you assign me this as I can implement this in javascript.

I would like to implement the selection sort algorithm in C++ and C. Could you assign it to me?

I would like to implement the above question in Python, I will write neat and clean  commented code
please assign me this issue under GSSoC 2021

I would like to implement the above problem in Java under GSSoC 2021. I would add comments at regular intervals and write clean code. Please assign this issue to me.


fix(proofs): await shouldAutoRespond to correctly handle the check

We did not await the shouldAutoRespondTo... and if we then check if the value is truthy, it is because it is a Promise and not the contained value of boolean.
Abstracting the async function call to a variable above makes an IDE error on the if statement is it will always be truthy if not-awaited.
@TimoGlastra Would it make sense to add a rule that you must mark void/await for async calls? that would've probably avoided this, quite big, bug.
closes #1095

@TimoGlastra Would it be possible to get this in 0.3.0? I assume if it goes to main now it will be in 0.3.0, right?

@TimoGlastra Would it be possible to get this in 0.3.0? I assume if it goes to main now it will be in 0.3.0, right?

We are working on 0.3.0.alpha.xxx, so every commit will be included to the 0.3.0 release. A new PR will be created later on (I think Timo created the current release PR just to help me on the migration guide, as it generates the changelog).

@TimoGlastra Would it make sense to add a rule that you must mark void/await for async calls? that would've probably avoided this, quite big, bug.

Yes I think we should add no-floating-promises and no-misused-promises

Codecov Report

Merging #1116 (3841a15) into main (03cdf39) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   88.28%   88.16%   -0.13%
==========================================
  Files         705      705
  Lines       16399    16405       +6
  Branches     2657     2657
==========================================
- Hits        14478    14463      -15
- Misses       1914     1935      +21
  Partials        7        7

Impacted Files
Coverage Δ

...les/credentials/protocol/v1/V1CredentialService.ts
93.43% <ø> (ø)

...ore/src/modules/proofs/ProofResponseCoordinator.ts
100.00% <100.00%> (ø)

...oofs/protocol/v1/handlers/V1PresentationHandler.ts
96.15% <100.00%> (+0.15%)
:arrow_up:

...otocol/v1/handlers/V1ProposePresentationHandler.ts
85.00% <100.00%> (+0.38%)
:arrow_up:

...otocol/v1/handlers/V1RequestPresentationHandler.ts
88.37% <100.00%> (+0.27%)
:arrow_up:

...oofs/protocol/v2/handlers/V2PresentationHandler.ts
96.15% <100.00%> (+0.15%)
:arrow_up:

...otocol/v2/handlers/V2ProposePresentationHandler.ts
81.81% <100.00%> (+0.56%)
:arrow_up:

...otocol/v2/handlers/V2RequestPresentationHandler.ts
97.05% <100.00%> (+0.08%)
:arrow_up:

...e/src/modules/proofs/protocol/v1/V1ProofService.ts
74.87% <0.00%> (-5.39%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Apparently the tests were written for the incorrect way of doing autoAccept. Will fix this ASAP tomorrow.

Sorry that it took so long, the bug was a bit bigger than just a missing "await". Our deep equality check did not work, and I had to change it. (also added some more tests to be sure).


[SYSTEMML-901] Improve unavailable MLContext message

Add option to suppress MLContextException stacktrace.

If an MLContext hasn't been created and it is required, here is an example of the new behavior:
scala> val LinRegCg = LinRegCgDML.in("X", X).in("y", y).out("beta_out")
No MLContext object is currently active. Have you created one? Hint: in Scala, 'val ml = new MLContext(sc)'

Stacktrace is suppressed in this situation since it is irrelevant for the user.

LGTM.

Thank you @dusenberrymw. I will merge.


[feat] flightplans: New RPC methods

Proposal to create and rename RPC for Avian Flight Plans:

call_function -> call_flightplan
list_flightplans_functions (open for suggestion)
create_flightplan

list_flightplans_functions will not be added.


[question] Picking Video Files

Hey there,
thanks for that awesome plugin! I know it's called image picker, but is there any future support for additionally picking video files planned?

Hi @RyamBaCo,
Thank you for your interest in nativescirpt-imagepicker.
Regards to your question, at the moment there is no plans to provide such a functionality for the plugin.
In case you need such a functionality, you could create your own plugin, which provides functionality to pick video for both Android and iOS, More info about, how to create a plugin, could be found in the below-attached links.
http://docs.nativescript.org/plugins/plugins
http://developer.telerik.com/featured/creating-nativescript-plugins-in-typescript/
http://developer.telerik.com/featured/write-nativescript-plugins-theyre-easier-cordova-plugins/
http://www.nativescriptsnacks.com/videos/2016/09/12/plugin-seed.html
Furthermore, for Android, you could review nativescript-file-picker and its demo here.
Regards,
@tsonevn


given date format, add posssiblity to change choose date format

make possible to choose the right date format by adding attribute date-format in html input

I'm not sure what you want to achieve. The date input control should return a RFC 3339 full date:
full-date = date-fullyear "-" date-month "-" date-mday
If you want to control how it is displayed in your browser, you can't. It depends on your browser and its locale it is set too.
If you want to have a custom date input, you should use something like this:
<input type="text" name="some_date" value="10/02/2016" data-validators="date{format:m/d/Y}" />

But you might get into trouble with that. In the US the month is first and in the Netherlands the day is first: 12/31/2016 vs 12/31/2016
Also you might want to add .idea to your global .gitignore.


feat: added module optional

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Bubble Sort

Added bubble sort algorithm in Java

@thisarathushan1 Please update your repo, then create a pull request.


Kanban Board Setup

In the Issue, we set up our project's kanban board and shared the tasks.
We are a 3 member team and the tasks are shared as follows:

@mmsesay as Team Member 1
@see-why as Team Member 2
@HENRYKC24 as Team Member 3

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it 🚀 :
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Use auth tokens for downloading omnisharp builds from GitHub

@jrieken Please review.
Our CI builds are failing because Travis constantly hits download count limits when fetching stuff from GitHub. It's possible to use an auth token to mitigate this. We are already using one everywhere else in our build. This enables the same for the OmniSharp bits.

Hi @joaomoreno, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Joao Moreno). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


iOS calls error callback but the parameter is empty

Hi,
I'm new to mobile dev and iOS dev in particular. I have set up iOS provision and certificates as per tutorials I found. When I build and run the app on ios device the I can't get on the registration event and error callback is triggered, but the error object passed on the function is empty, which is not very helpful. Just wondering how I can further debug on this on ios. I am under impression that something went wrong with my certificates and provisions, but not really sure of this as I cannot see any error message returned by the api.
Hope you can help me.
Thanks in advance

@kevinmirafuentes You created and added the Apple Push Notification service SSL for project?

@jlamim Are your perhaps referring to the certificates created for push notifications? I basically did the instructions for setting up the ios app from this link http://docs.ionic.io/docs/push-ios-setup
Then, I archive the app and install on device. My expectations are either I get registrationId or an error response, which would have been a good start. Unfortunately, the error callback is triggered and response is just empty object. Would have been nice if it could return some info, like invalid certificate, permission errors, etc.

@kevinmirafuentes if the device fails to register then I get a NSError object from the OS. Then I end up sending the message contained in the NSError to the "error" method. If there is no message from OS then there is nothing I can send ya.
Have you tried running in Xcode if there are more error messages?


inject-core: Cross-build for Scala 2.13

Depends on #529
Problem
inject-core is not cross-built for Scala 2.13.
Solution
Update inject-core module to cross-build for Scala 2.13 using new SBT
settings. Adds in shim for old code no longer supported by Scalaguice to generate TypeLiterals from Manifests; it was simpler to do this than change the context bound everywhere (which led to a host of other compatibility issues).
Result
inject-core is cross-built for Scala 2.13.

Note: we'll have to replace all of the uses of Scalaguice's typeLiteral as a part of this... but that might be less invasive to do this to keep existing behavior than changing the type signature of things like MessageBodyManager or DefaultMessageBodyReader (which could prove to be impossible anyway because eventually the impls of those things drill down to the Jackson Scala module, which still requires Manifests).

@yufangong we will probably have another issue with dependencies here, since this PR had to bump nscala-time

@yufangong if it's not too much trouble, I think it will be easier to go one by one - that way it'll be simpler for me incorporate any feedback into the correct commit without having to do some more complicated git to amend changes into a commit for a particular module that may be further up the chain.

Or another idea.... if you want to make the merging / rebasing process simpler, we could do the reviews on each individual PR, mark the PR that we want to merge (that contains multiple commits) and once all of the PRs are approved and ready, I can rebase up the chain and you can just merge the final PR with N commits. Let me know which you think works best.

this is merged at https://github.com/twitter/finatra/commit/abb72f491b9fbe1b09e892dd322e5029c28f18b4. Thanks!!!

@yufangong if it's not too much trouble, I think it will be easier to go one by one - that way it'll be simpler for me incorporate any feedback into the correct commit without having to do some more complicated git to amend changes into a commit for a particular module that may be further up the chain.

It's not, one by one works for me. We can also work on this incrementally, as the next level in the dependency graph is utils. ports, modules based on https://github.com/twitter/finatra/issues/522, if this is still accurate, we can start to rebase and merge in these three, I've left some comments on the three PRs. Thanks!


Initial web controller integration

Initial Web based MiniPupper Teleop integration.
Closes #26
@mangdangroboticsclub @Tiryoh feel free to review

Sorry for the late feedback.
You did a lot of work and the code is awesome.
However, if we merge this, there will be a lot of unnecessary code for users who want to simply use the ROS package, and the usability as a teaching material will be not good.
Furthermore, it seems that you are trying to do something different, such as reading the servo's initial angle from the xml file, not from EEPROM.
So I will not merge your PR, please maintain it by yourself, many thanks for your awesome work.


run ionic cordova run android went wrong

ionic version 3.2.0  run ionic cordova run android
Short description of the problem:

cordova run android
Error: Unexpected end
Line: 0
Column: 0
Char:

[ERROR] Cordova encountered an error.
You may get more insight by running the Cordova command above directly.
[ERROR] An error occurred while running cordova run android (exit code 1).
There has no other error message.
Post the output of ionic info below please
global packages:
@ionic/cli-utils : 1.2.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.2.0

local packages:
@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.1.2
@ionic/cli-plugin-ionic-angular : 1.1.2
Ionic Framework                 : ionic-angular 3.2.1

System:
Node       : v6.10.3
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

I'm guessing some config file is empty. Running cordova run android as recommended in the error message would confirm that it's the Cordova CLI that has the issue, not the Ionic CLI. Try deleting your platforms/ directory and running it again.


Request: verify bridged token source on bscscan

Hello,  I'd like to know if it's technically possible to verify the source of the assets bridged towards the Binance Smart Chain.
For example: https://bscscan.com/token/0x33acdf0fe57c531095f6bf5a992bf5aa81c94acf#readContract
This step is necessary to gain users trust in the bridged assets. On the same topic, I noticed that the name of the assets is for example: btp-0x1.icon-sICX. Will the assets bridged from icon-bridge and BTP share the same contract?
Thanks and congratulations on this release!

Hi @Lucas-L, we cannot say for certain whether or not icon-bridge and BTP will share the same contract because BTP is still under development. It's possible that BTP will require a new contract, but we will try to avoid that unless necessary.
We will look into verifying source assets. Thank you for bringing this to our attention.


Refactor 21 lines occurring 3 times in process.go

I've selected for refactoring 21 lines of code which are duplicated in 1 file(s) (1, 2, 3).  Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍
Here's the gist of this guideline:

Definition 📖
Do not copy code.
Why❓
When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
How 🔧
Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲  next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! :shipit: :sparkles: :100:

What I am thinking is to extract a function and put the logic that is duplicate.

@utkarshmani1997, @ashishranjan738 -- I'd like to take this up as part of Hacktoberfest

@utkarshmani1997, I'd like to take this up as part of hacktoberfest

yeah @NaveenBellary please go ahead


Hi

Hi my bro how to use in library for java?

What do you mean?

What do you mean?

I want to use your library in my program, I need its methods

Please be more specific. Closing for now, feel free to reopen with more information.


test(linter/unicorn): add fixer tests for no-null

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5175
#5174
#5173  👈
#5172
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


TODO(statuscol_gitsigns): Use extmarks instead of signs

Apparently, gitsigns defaulted using extmarks instead of vimfn marks. ive did some stuff and made gitsigns use vimfn marks as a tmp fix but id like to get the default behavior so ill go fix it later kthxbye

yeah, finished


Cannot tag files bigger than 2gb

I'm using your script to manually tag old movies in mp4 format.  When they are bigger than 2gb the tagger seems to fail every time.  Al the movies smaller than 2gb also fails.
I've converted the same mkvs to mp4 using manual.py to see if it was something I did wrong with my conversion, but the files still fail that are bigger than 2gb.
Is it a setting I need to change or is there a file size limitation to tagging mp4 files?

As of commit 8375e799c53cfa9a0d87d62cccf747072875ee97 a workaround for this issue has been found and tagging should work on 32 bit systems regardless of file size


Image layout queries and initialization

Vulkan allows to specify the initial layout on image creation, which we don't have. There is also vkGetImageSubresourceLayout that we need to provide. It appears to be blocking the tests:
"dEQP-VK.draw.simple_draw.*

Should be reopened. Not fixed

Vulkan allows to specify the initial layout on image creation, which we don't have.

That I figured we don't actually need just yet. Vulkan only allows PREINITIALIZED and UNINITIALIZED layouts there anyway, which are of limited use for us.

vkGetImageSubresourceLayout

This has been done and tested by CTS.

Okee


Fixing readFile, adding _iterateBuffer

Fixing readFile to write directly to our buffer. _iterateBuffer currently reads through our buffer and shifts the bits. It will later be adapted to use the rotors.
ignore the like 20 pushes, I did an oopsie and committed the entire debug folder and was struggling to undo that

I totally didnt also do this locally and then see this pull request yup im a good programmer for sure


Migrate android views to devicelab.

Migrate android view out of recipes.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hi Reid, as part of simplifying testing we are deprecating https://cs.opensource.google/flutter/recipes/+/main:recipes/flutter/android_views.py and migrating the test to a regular devicelab test using the new emulator context. Please take a look at this pr.
Also this is how the generic recipe with this test looks like: https://chromium-swarm.appspot.com/task?id=675600a99df8c110


Thrift filter closes downstream connections if problem with an upstream endpoint.

Title: Thrift filter closes downstream connections if problem with an upstream endpoint.
Description:
This is the simplified version of our envoy configuration:

Listener with thirft filter

Routing: match aaa -> cluster1
Routing: match bbb -> cluster2

Cluster1 and Cluster2 have some endpoints defined by ip address.
The envoy and the endpoints are in the same kubernetes cluster.
From envoy point of view we have mixed incoming traffic targeted to both clusters.
If under traffic one endpoint becomes dead (I restart the related process on the endpoint) in cluster2 for example, the envoy closes all downstream connections on this listener.
Is this bug or feature? Is there any way to change this behavior through configuration?
Because of this, we experience lost messages targeted to cluster1 as well, however no any problem with that cluster.
Even if we try to check the connection state on socket level before sending message to envoy, or set TCP_NODELAY on the socket.
This is just one scenario. We are using XDS to dynamically configure the filter routing and the clusters. Similar issue happens in the following cases:

If because of any reason the cluster2 becomes empty.
Additionally in this case every new re-connection attempt to listener will be closed very quickly, so the lost messages targeted to cluster1 will be continouos.

If endpoints in the cluster remain the same just reordered.

We are using 1.11.2 but we tested 15.0 as well with same result.
Here is a log snippet when downstream connection happens.
C129084 is the original downstream connection.
C129088 is the killed endpoint.

[2020-08-12 19:08:44.652][1694][debug][connection] [source/common/network/connection_impl.cc:520] [C129088] remote close
[2020-08-12 19:08:44.652][1694][debug][connection] [source/common/network/connection_impl.cc:190] [C129088] closing socket: 0
[2020-08-12 19:08:44.652][1694][debug][pool] [source/common/tcp/conn_pool.cc:123] [C129088] client disconnected
[2020-08-12 19:08:44.653][1694][debug][pool] [source/common/tcp/conn_pool.cc:236] [C129088] connection destroyed
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:367] thrift: 530 bytes available
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:388] thrift: framed transport started
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:422] thrift: protocol binary, state MessageBegin, 526 bytes available
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/router/router_impl.cc:225] [C129084][S16864315381519780579] cluster 'cluster2' match for method 'bbb'
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/router/router_impl.cc:258] [C129084][S16864315381519780579] router decoding request
[2020-08-12 19:08:44.797][1694][debug][pool] [source/common/tcp/conn_pool.cc:82] creating a new connection
[2020-08-12 19:08:44.797][1694][debug][pool] [source/common/tcp/conn_pool.cc:362] [C129097] connecting
[2020-08-12 19:08:44.797][1694][debug][connection] [source/common/network/connection_impl.cc:704] [C129097] connecting to <IP_ADDRESS>:50003
[2020-08-12 19:08:44.797][1694][debug][connection] [source/common/network/connection_impl.cc:713] [C129097] connection in progress
[2020-08-12 19:08:44.797][1694][debug][pool] [source/common/tcp/conn_pool.cc:108] queueing request due to no available connections
[2020-08-12 19:08:44.797][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:430] thrift: wait for continuation
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:561] [C129097] delayed connection error: 111
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:190] [C129097] closing socket: 0
[2020-08-12 19:08:44.798][1694][debug][pool] [source/common/tcp/conn_pool.cc:123] [C129097] client disconnected
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:101] [C129084] closing data_to_write=0 type=1
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:190] [C129084] closing socket: 1
[2020-08-12 19:08:44.798][1694][debug][thrift] [source/extensions/filters/network/thrift_proxy/conn_manager.cc:141] [C129084] local close with active request
[2020-08-12 19:08:44.798][1694][debug][main] [source/server/connection_handler_impl.cc:80] [C129084] adding to cleanup list
[2020-08-12 19:08:44.798][1694][debug][pool] [source/common/tcp/conn_pool.cc:236] [C129097] connection destroyed
[2020-08-12 19:08:45.298][1703][debug][main] [source/server/connection_handler_impl.cc:280] [C129098] new connection
[2020-08-12 19:08:45.298][1703][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:367] thrift: 530 bytes available
[2020-08-12 19:08:45.298][1703][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:388] thrift: framed transport started
[2020-08-12 19:08:45.298][1703][debug][thrift] [source/extensions/filters/network/thrift_proxy/decoder.cc:422] thrift: protocol binary, state MessageBegin, 526 bytes available

cc @zuercher @rgs1

@tkovacs-2 what's the ip of the endpoint that you killed in this example? It shouldn't be the one returning the connection refused error (error code 111) since that should be an endpoint in the other cluster right?
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:561] [C129097] delayed connection error: 111
[2020-08-12 19:08:44.798][1694][debug][connection] [source/common/network/connection_impl.cc:190] [C129097] closing socket: 0

@rgs1 The ip of the restarted endpoint was the <IP_ADDRESS> since other endpoints were continuously up and ready in both clusters.
The connection refused seems reasonable since there was a short delay while the process supervisor started the process again after kill.

@rgs1 Is there any update about this issue?
Could you give me some hints about how the relevant classes and functions are working in case if I would try to understand the relevant code and do a fix. Thanks.


storage_min_left_capacity_bytes default value has integer overflow

Proposed changes
Issue Number: close #19915
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.9 seconds
stream load tsv:          443 seconds loaded<PHONE_NUMBER>9 Bytes, about 161 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.7 seconds inserted 10000000 Rows, about 127K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230522164415_clickbench_pr_148544.html

run p0


KYLIN-3818 After Cube disabled, auto-merge cube job still running

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@68bffc1). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #495   +/-   ##
=========================================
  Coverage          ?   24.47%
  Complexity        ?     4964
=========================================
  Files             ?     1144
  Lines             ?    69449
  Branches          ?     9904
=========================================
  Hits              ?    16996
  Misses            ?    50733
  Partials          ?     1720

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/apache/kylin/rest/service/CubeService.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bffc1...df06ce9. Read the comment docs.

Pull Request Test Coverage Report for Build 4195

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 4187:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


Usability with zoom

For some reasons, it's not a good option to turn off the user scalable property. So, it's interesting turn on this property in your meta viewport. In addition, the maximum scale property attribute is less than '5'. Change this too.
Disabled people will be grateful with you!

Maybe my recommendation was not helpful. I'll close this issue.


README is misleading?

The README states

NOTE:
If you wish to use Nexus 3, nexus_work_dir_manage need to be set to false because this module support only Nexus 3 installation

I think this no longer applies. nexus_work_dir_manage must be set to true otherwise the etc directory does not get created and the work dir uid/gid is not set correctly. Or am I missing something?

Thanks for this, I was wondering why the ownership of the work directory wasn't set properly. It does indeed seem that for 3.1+ nexus_work_dir_manage must be set to true.


Timber::get_posts($arg) with search

I am pretty sure the search term was working but now it's not returning anything.
$args = array(
'post_type'         => 'event',
's'                      => 'search term',
);
$posts = Timber::get_posts($args);
I can filter by the category and meta_query but as soon as I add the 's' in the query it doesn't return anything.

It was working. I am using the Relevanssi plugin so it was conflicting


standardize meaning of terminal phases for backups/restores

Breaking this sub-issue out from #286
Today, backups and restores terminate with one of the following phases:

FailedValidation - the item's spec was invalid (restore of a nonexistent backup, etc.)
Completed

for backups, this means there were no errors
for restores, this means there were no fatal errors (e.g. failure to download the backup tarball), but there may have been 1+ errors restoring individual items

Failed

for backups, this means one or more errors were encountered. It's possible that there's still a restorable tarball in object storage (e.g. if the error was just a single item failing to back up).
for restores, this means there was a fatal error, e.g. unable to download the backup tarball

There are a couple of problems with the above:

the meaning of Completed vs. Failed is inconsistent between backups and restores
there's no distinct phase to report a partial failure (i.e. most items backed up/restored successfully, but 1+ individual items did not)

I'm proposing the following changes for v1.0:

Completed means "no errors" for both backups and restores
Failed means "fatal error encountered" for both backups and restores -- e.g. failure to upload/download tarball
CompletedWithErrors / PartiallyFailed (new phase) means "some errors encountered backing up/restoring individual items" for both backups and restores

Possible future work:

FailedValidation goes away, is combined with Failed
eliminate phases and replace with conditions?

Closed by #1386 #1389


external PostCommitHook implementation

Intro
This PR introduces a new optional configuration spark.databricks.delta.properties.defaults.postCommitHookClass that specifies the class name of a custom PostCommitHook.
This class must extend org.apache.spark.sql.delta.hooks.PostCommitHook. This feature allows users to execute their own logic after each transaction commit.
For example,
There is no direct way, if a user wants to register delta table partitions to glue catalog, so it can be further used in Athena or Presto.
Using this hook implementation, he/she can extract partitions from committedActions and via alter table add partition statement it can be registered to catalog.
Usage
The user creates their custom hooks by extending PostCommitHook:
package org.apache.spark.sql.delta

import org.apache.spark.sql.SparkSession
import org.apache.spark.sql.delta.actions.Action
import org.apache.spark.sql.delta.hooks.PostCommitHook

class ExternalPostCommitHook extends PostCommitHook {
  /** A user friendly name for the hook for error reporting purposes. */
  override val name: String = "ExternalPostCommitHook"

  /** Executes the hook. */
  override def run(
    spark: SparkSession,
    txn: OptimisticTransactionImpl,
    committedActions: Seq[Action]): Unit = {

    // Create a Delta table and call the scala api for generating manifest files
    spark.sql(s"GENERATE symlink_ForMat_Manifest FOR TABLE delta.`${txn.deltaLog.dataPath}`")
  }
}

They can then use their ExternalPostCommitHook in their application by setting the config:
spark.conf.set("spark.databricks.delta.properties.defaults.postCommitHookClass", "org.apache.spark.sql.delta.ExternalPostCommitHook")
Testing
This PR includes a unit test that generates the manifest file using the hook.

Build failed with No space left on device and also don't have permission to rerun.
@jaceklaskowski, need your help

@jaceklaskowski, need your help

Sorry. I'm in the same boat as you = no permission to rerun.
/cc @tdas @brkyvz @zsxwing

@skp33 I just re-ran the tests.

@skp33 could you please close the issue? We can reevaluate this if we ever decide to open up PostCommitHook for external use.

Hi, just vote for this feature,  it would be quite helpful for user to do incremental delta partition maintain in Glue.

Thanks for the feedback. I created a new ticket for the redesign of PostCommitHook API #799. Closing this.


How to detect landmarks without face detection?

MediaPipe Solution (you are using)
No response
Programming language
No response
Are you willing to contribute it
None
Describe the feature and the current behaviour/state
I encounter difficulties in obtaining landmark results while using infrared images.

Will this change the current API? How?
No response
Who will benefit with this feature?
No response
Please specify the use cases for this feature
landmark detection task without face detection

Any Other info
No response

@Stephenzza,
Could you please elaborate your query with more details. Thank you!


flags croatia

In UI Docs, under "Flags", instead of Croatia you have Serbia and Serbian flag.

Thanks for the find

The flags for Serbia and Croatia appear to match wikipedia's flags.

Countries are listed in alphabetical order. You have Costa Rica then Serbia(it should be Croatia) then Cuba..
http://semantic-ui.com/elements/flag.html


Add Logger

Add proper logging in all the Endpoints using pino-logger

Hi @uzair-ali10, can I work on this issue?

Yea sure go ahead!!


Split integration tests

Summary
Split integration tests into different jobs to overcome timeout errors. ( I am not sure why connection times out and having separate jobs seems to help for now).
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.3%) to 29.629%

Totals

Change from base Build<PHONE_NUMBER>:
-3.3%

Covered Lines:
1621

Relevant Lines:
5471

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.3%) to 29.629%

Totals

Change from base Build<PHONE_NUMBER>:
-3.3%

Covered Lines:
1621

Relevant Lines:
5471

💛  - Coveralls


os-postfix in 20.7.1 breaks smtpd_sasl_auth

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
[x] The title contains the plugin to which this issue belongs
Describe the bug
os-postfix in 20.7.1 does not know smtpd_sasl_auth_enable anymore:
postconf: warning: /usr/local/etc/postfix/main.cf: unused parameter: smtpd_sasl_auth_enabled=yes
opnsense-revert -r 20.7 os-postfix reverts to working smtpd sasl auth
working: os-postfix-1.14_1
broken: os-postfix-1.15

You mean this change? oO
https://github.com/opnsense/plugins/commit/629e73451e335d

So weird. I cannot reproduce this error. I have been upgrading/reverting os-postfix several times.
It happened initially on both nodes on the upgrade from 20.7 to 20.7.1.

I guess it was something that only happened during the initial update in regard to the used libraries.


Easey-CAMPD-UI Dependabot Alerts (To be Addressed after ECMPS Beta Development Work is complete)

[ ] Critical: Prototype pollution in webpack loader-utils -> Cannot be fixed without upgrading react

[ ] Critical:xmldom allows multiple root nodes in a DOM -> Will attempt to force upgrade to 7.6

[ ] Critical: Withdrawn: Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom -> Will attempt to force upgrade to 7.6

[ ] High: minimatch ReDoS vulnerability

[ ] loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) via url variable - > Cannot be fixed without upgrading to react

[ ] loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) - Cannot be fixed without upgrading to React

The issues noted above have been addressed with the REACT upgrade. Will log a seperate ticket for the new depenadabot issues


Rewrite NicknamePokemon for new Inventory sysem + a lot of new keys for 'nickname_template' option

Short Description:

Rewrited NicknamePokemon task to use new Inventory sysem
Added a lot of new keys for the 'nickname_template' option
Added new class PokemonInfo for instances of the static information loaded from pokemon.json
Inventory API for pokemons improved + added capture_rate and flee_rate fields
Added type information (weaknesses & resistances)

New classes:  Type, Types
Usage of new classes everywhere in the Inventory

All covered with tests, documentation & comments

More information:
New parameter "good_attack_threshold"
Threshold for perfection of the attack in it's type (0.0-1.0, default: 0.7) after which attack will be treated as good (strong). So attack with 1.0 perfection is the strongest in it's type (Fire, Normal, etc..) - inflicts maximum damage per second.
Used for {fast_attack_char}, {charged_attack_char}, {attack_code} template keys.
Supported pattern keys:

Key
Info

{name}
Pokemon name     (e.g. Articuno)

{id}
Pokemon ID/Number (1-151)

{cp}
Combat Points    (10-4145)

Individial Values (IV)

{iv_attack}
Individial Attack (0-15) of the current specific pokemon

{iv_defense}
Individial Defense (0-15) of the current specific pokemon

{iv_stamina}
Individial Stamina (0-15) of the current specific pokemon

{iv_ads}
Joined IV values (e.g. 4/12/9)

{iv_sum}
Sum of the Individial Values (0-45)

Basic Values of the pokemon (identical for all of one kind)

{base_attack}
Basic Attack (40-284) of the current pokemon kind

{base_defense}
Basic Defense (54-242) of the current pokemon kind

{base_stamina}
Basic Stamina (20-500) of the current pokemon kind

{base_ads}
Joined Basic Values (e.g. 125/93/314)

Final Values of the pokemon (Base Values + Individial Values)

{attack}
Basic Attack + Individial Attack

{defense}
Basic Defense + Individial Defense

{stamina}
Basic Stamina + Individial Stamina

{sum_ads}
Joined Final Values (e.g. 129/97/321)

Individial Values perfection percent

{iv_pct}
IV perfection (in 000-100 format - 3 chars)

{iv_pct2}
IV perfection (in 00-99 format - 2 chars). So 99 is best (it's a 100% perfection)

{iv_pct1}
IV perfection (in 0-9 format - 1 char)

IV CP perfection - kind of IV perfection percent but calculated using weight of each IV in its contribution to CP of the best evolution of current pokemon. It tends to be more accurate than simple IV perfection.

{ivcp_pct}
IV CP perfection (in 000-100 format - 3 chars)

{ivcp_pct2}
IV CP perfection (in 00-99 format - 2 chars). So 99 is best (it's a 100% perfection)

{ivcp_pct1}
IV CP perfection (in 0-9 format - 1 char)

Moveset perfection percents for attack and for defense. Calculated for current pokemon only, not between all pokemons. So perfect moveset can be weak if pokemon is weak (e.g. Caterpie)

{attack_pct}
Moveset perfection for attack (in 000-100 format - 3 chars)

{attack_pct2}
Moveset perfection for attack (in 00-99 format - 2 chars)

{attack_pct1}
Moveset perfection for attack (in 0-9 format - 1 char)

{defense_pct}
Moveset perfection for defense (in 000-100 format - 3 chars)

{defense_pct2}
Moveset perfection for defense (in 00-99 format - 2 chars)

{defense_pct1}
Moveset perfection for defense (in 0-9 format - 1 char)

Character codes for fast/charged attack types. If attack is good character is uppecased, otherwise lowercased.Use 'good_attack_threshold' option for customization. It's an effective way to represent type with one character. If first char of the type name is unique - it's used, in other case suitable substitute used. Type codes:   Bug: 'B'   Dark: 'K'   Dragon: 'D'   Electric: 'E'   Fairy: 'Y'   Fighting: 'T'   Fire: 'F'   Flying: 'L'   Ghost: 'H'   Grass: 'A'   Ground: 'G'   Ice: 'I'   Normal: 'N'   Poison: 'P'   Psychic: 'C'   Rock: 'R'   Steel: 'S'   Water: 'W'

{fast_attack_char}
One character code for fast attack type (e.g. 'F' for good Fire or 's' for bad Steel attack)

{charged_attack_char}
One character code for charged attack type (e.g. 'n' for bad Normal or 'I' for good Ice attack)

{attack_code}
Joined 2 character code for both attacks (e.g. 'Lh' for pokemon with strong Flying and weak Ghost attacks)

Special case: pokemon object You can access any available pokemon info via it.Examples:   '{pokemon.ivcp:.2%}'             ->  '47.00%'   '{pokemon.fast_attack}'          ->  'Wing Attack'   '{pokemon.fast_attack.type}'     ->  'Flying'   '{pokemon.fast_attack.dps:.2f}'  ->  '10.91'   '{pokemon.fast_attack.dps:.0f}'  ->  '11'   '{pokemon.charged_attack}'       ->  'Ominous Wind'

{pokemon}
Pokemon instance (see inventory.py for class sources)

## Examples:
"nickname_template": "{ivcp_pct}-{iv_pct}-{iv_ads}"
Golbat with Individial Values (attack: 9, defense: 4 and stamina: 8 will be named '48-46-9/4/8'
"nickname_template": "{attack_code}{attack_pct1}{defense_pct1}{ivcp_pct1}{name}"
Same Golbat (with attacks Wing Attack & Ominous Wind) will have nickname **'Lh474Golbat'** <br> See /tests/nickname_test.py` for more examples.

@TheSavior please look at this PR :)

:+1:
Looks self contained. Low risk
On another note, perhaps the inventory should be changed into a folder (package) with each of those classes in their own file. The inventory file is pretty intense right now.

@TheSavior Thank you!


2024-10-18_01-35-23_master-next_aws-cli-v2

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10041-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10041-to-kirkstone-next
git switch --create backport-10041-to-kirkstone-next
git cherry-pick -x 9329f83c59b19b393723ea45187e74bb121d774d

Successfully created backport PR for scarthgap-next:

#10045

Successfully created backport PR for styhead-next:

#10046


Helm Registry Adapter

Describe what this PR does and why we need it:
Adds a Helm Registry Adapter without vendoring helm.

Will create another PR for just the documentation piece. Probably need to have registry configuration documentation in the bundle-lib also.


Support PG ranges

The SQL type should be Range<ST: CanAppearInRange>. We should provide an impl to/from SQL for (Bound<T>, Bound<T>) where T: FromSql<ST, Pg>. Bound is currently unstable, so we'll need to stick this behind the unstable feature. It appears to be on track for stabilization soon though, so I don't think we need to support any stable types.
For this to work with codegen we'll also need the following:
pub type Int4range = Range<Int4>;
pub type Int8range = Range<Int8>;
pub type Numrange = Range<Numeric>;
pub type Tsrange = Range<Timestamp>;
pub type Tstzrange = Range<Timestamptz>;
pub type Daterange = Range<Date>;

The impls for serialization/deserialization look pretty straightforward. Format appears to be a one byte set of flags (inclusive vs exclusive, whether start or end are unbounded), 4 byte length for upper value followed by data if present, 4 byte length for lower value followed by data if present.

I wouldn't quite call this easy for newcomers, but it is at least fairly isolated.

I'm working on that now, I just have some questions:

How do we treat infinity ?
OIDs ? Apparently each range has a different OID and arrays of ranges too. Should I request a metadata thing in the CanAppearInRange trait ?

Fixed by #1021


Provide SORT BY functionality for facet-based query refinement

Provide sort by function as shown in the following image

long name (a-z)
2 short name(a-z)
grid spatial resolution
satellite spatial resolution
start date
stop date

@lewismc Could you please check above description to confirm it meets the requirement? Thanks

It sounds good to me.

@quintinali I saw your note on the PR that this requires metadata to be re-indexed. You mean running mudrod-engine with the -m flag correct?
I am now getting this error locally when running a search:
Caused by: java.lang.IllegalArgumentException: Fielddata is disabled on text fields by default. Set fielddata=true on [Dataset-ShortName] in order to load fielddata in memory by uninverting the inverted index. Note that this can however use significant memory.

@fgreg  with -m flag,  just data in the metadata type are deleted.  The metadata mapping file is not changed. I deleted the "mudrod" index and reingested metadata. But weblog procss result will also be deleted during this process.
https://www.elastic.co/guide/en/elasticsearch/reference/5.0/indices-delete-mapping.html

@quintinali What are the consequences of deleting the weblog process result?
I'm trying to avoid having to do a full re-ingestion. So I delete mudrod index then run mudrod-engine with -m? is that right?

@fgreg

delete mudrod index
run mudrod-engine -m to ingest metadata
comment out "wd.preprocess();" in startLogIngest() function  in MudrodEngine.java
run mudrod-engine -l to process web logs
remove comment to wd.preprocess().

Through above steps, you can avoid a full re-ingestion. It is a little complicated since we don't have a flag just processing the weblogs.

@quintinali We have 8 months of logs now, so I would have to do this for all 8 months?
I can't comment out code in the production deployment.

@fgreg monthly logs are stored in different indexes rather than the "mudrod" index. For example, podaaclog201611.w5.gz log is stored in "podaaclog201611.w5.gz". Deleting "mudrod" index will only delete log processing results not the original logs.
I think we have two choices.
(1) add a separated command to process web logs. Processing logs ( calculate user history and click stream data) is much quicker than preprocessing logs ( ingest log and construct sessions). It will not take long to process 8 months of logs.
(2) add a custom function to update metadata mapping(I am not sure whether it works for Elasticsearch 5.0).
https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-put-mapping.html#updating-field-mappings
https://www.elastic.co/guide/en/elasticsearch/reference/5.0/indices-delete-mapping.html
Which one do you prefer to? Should we try solution 2 at first?

@quintinali What is it we're trying to change exactly? If I query my local index:
http://<IP_ADDRESS>:9200/mudrod/_mapping/RawMetadata
I see:
"RawMetadata": {
  "dynamic_templates": [
    {
      "strings": {
        "match_mapping_type": "string",
        "mapping": {
          "analyzer": "english",
          "fielddata": true,
          "fields": {
            "raw": {
              "type": "string",
              "index": "not_analyzed"
            }
          },
        "type": "text"
        }
      }
    }

Isn't the "fielddata": true, what we're looking for? What else needs to get updated?

@quintinali So what I have right now should work? Is my error related to something introduced by @lewismc ?

@fgreg I don't think so. Could you please check the mapping of Dataset-ShortName field in RawMetadata? I think it is not updated.

@quintinali Correct, "Dataset-Shortname" does not show "fielddata": true. Right now it is:
"Dataset-ShortName": {
  "type": "text",
  "analyzer": "english"
},

What should it be?

Form my side, the mapping is:
"Dataset-ShortName": {
"type": "text",
"analyzer": "english",
"fielddata": true
}

@fgreg  I'm very sorry. What I just posted is wrong. The mapping is as following:
"Dataset-ShortName": {
"type": "text",
"fields": {
"raw": {
"type": "keyword"
}
},
"analyzer": "english",
"fielddata": true
},

I was able to update the mapping directly using a PUT request and it seems to work now:
curl 'http://<IP_ADDRESS>:9200/mudrod/_mapping/RawMetadata?update_all_types' -X PUT -H 'Pragma: no-cache' -H 'Origin: http://<IP_ADDRESS>:9100' -H 'Accept-Encoding: gzip, deflate, sdch, br' -H 'Accept-Language: en-US,en;q=0.8' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36' -H 'Content-Type: application/x-www-form-urlencoded' -H 'Accept: application/json, text/javascript, */*; q=0.01' -H 'Cache-Control: no-cache' -H 'Referer: http://<IP_ADDRESS>:9100/' -H 'Connection: keep-alive' --data '{"properties":{"Dataset-ShortName":{"type":"text","fielddata":true,"analyzer":"english","fields":{"raw":{"type":"string","index":"not_analyzed"}}}}}' --compressed

Do I need to do this to all fields that have only "type": "text" and "analyzer": "english" currently? Or is updating the Dataset-ShortName good enough?

@fgreg
(1) "fielddata": true is used to enable sort function for a field. Thus this mapping should be added to all fields related to "sort by function" shown in https://github.com/mudrod/mudrod/pull/204/files#diff-9589b36f921018b8701d9c6841682406R118
(2) "fields": {"raw": {"type": "keyword"}} is used to enable sort by A-Z function on  Dataset-ShortName and  Dataset-LongName fields.
(3) To simplify the template, I added these two mapping two most fields. You can decide by yourself, but only updating Dataset-ShortName is not enough.

@quintinali The other sort-by properties are all either long or float type and do not support fielddata = true.
I think the only mappings that need to be updated are Dataset-ShortName and Dataset-LongName
I ran these two commands to update the mappings in my index. This should be reproducible in UAT and PROD:
curl 'http://<IP_ADDRESS>:9200/mudrod/_mapping/RawMetadata?update_all_types' -X PUT -H 'Content-Type: application/json' -H 'Accept: application/json, text/javascript, */*; q=0.01' --data '{"properties":{"Dataset-ShortName":{"type":"text","fielddata":true,"analyzer":"english","fields":{"raw":{"type":"keyword","index":"not_analyzed"}}}}}' --compressed
curl 'http://<IP_ADDRESS>:9200/mudrod/_mapping/RawMetadata?update_all_types' -X PUT -H 'Content-Type: application/json' -H 'Accept: application/json, text/javascript, */*; q=0.01' --data '{"properties":{"Dataset-LongName":{"type":"text","fielddata":true,"analyzer":"english","fields":{"raw":{"type":"keyword","index":"not_analyzed"}}}}}' --compressed

@fgreg Thanks for providing the solution for updating metadata mapping. Please let me know if any other problem.


Update documentation and dependencies

Minor (mostly stylistic) updates to documentation and also updating the npm packages.

LGTM, but needs prettier to be run

The reason is updating prettier to v2.3.0, which brought some changes. I wonder how codebases are impacted by such changes. Keeping packages up-to-date seems like a logical thing to do, but should you reformat your codebase when a major change happens. This change affected just one file here, but in app/ directory of hpc_service, there are 94 files that need change! I didn't know that when I proposed updating dependencies in https://github.com/UN-OCHA/hpc_service/pull/2233.
What is your opinion on how our codebase should response to changes like this? Should we stop updating, should we revert in hpc_service or should we keep our codebase at the bleeding edge? Or something else? :)

We definitely want to keep them up to date, but we will also face this issue whenever we change configuration options in prettier without reformatting everything, so it is something we should be able to handle.
For the most part, the workflow should probably be that we make sure that formatting changes are done in separate commits, but we don't want to have to have massive formatting PRs all the time as that leads to too many conflicts.

We definitely want to keep them up to date, but we will also face this issue whenever we change configuration options in prettier without reformatting everything, so it is something we should be able to handle.
For the most part, the workflow should probably be that we make sure that formatting changes are done in separate commits, but we don't want to have to have massive formatting PRs all the time as that leads to too many conflicts.

As things stand now, changes in prettier are more likely to occur than changes in our configuration. I wasn't following their work over the years, so I don't know how often this happens, but from their release notes it looks like v2.3.0 resolved some long standing problems. I would prefer that they changed major version every time they release versions which "break" previous behavior and cause such formatting changes. This is more a question directed towards prettier maintainers, but I'm sure they already discussed this :smile:
As for us, I think it's much more convenient that we apply changes in a single PR, which should not even need much of a review in my opinion, since CI checks for prettier formatting and making changes using prettier CLI tool with a --write flag should do the trick. It's much more convenient to reformat codebase in a single PR, and then rebase all other PRs to include the changes which they would be doing anyway (in a separate commit). We had one incident months ago, which was caused by a mistake during rebase, but I wouldn't necessarily blame formatting changes for that.
Edit: Changes in prettier can happen even in patch version updates. From their docs page:

Install an exact version of Prettier locally in your project. This makes sure that everyone in the project gets the exact same version of Prettier. Even a patch release of Prettier can result in slightly different formatting, so you wouldn’t want different team members using different versions and formatting each other’s changes back and forth.


[Custom app]: Add/Save button is grey when input valid version and leave focus in the text box

EPAM AI DIAL chat version
0.18.0
How to reproduce
Steps:

Open 'Add application' form
input all required fields except Version
input valid value in 'Version' field
Hover on 'Add' button -> button is grey and tooltip displayed'Fill in all required fields or correct values' -> bug
Click on 'Add' button -> button becomes blue -> bug
another click on 'Add' button -> Form was closed, app was saved

Actual result
Button 'Add'( or 'Save') not become enabled when input correct Version value
Expected result
if all required fields are filled correctly and user input valid value for Version field, then button 'Add' (or Save) should become enabled
Confidential information

[X] I confirm that do not share any confidential information

verified on staging successfully


Combine notebooks working with backends and compiler

See the new tutorials here:
https://github.com/jaygambetta/qiskit-tutorial/pull/10
Remove appendix/advanced_qiskit/compiling_and_running.ipynb - @jaygambetta was going to combine this with reference/tools/working_with_backends.ipynb
Description

Your Environment

Tutorial branch (stable/master):
QISKit SDK version:
Python version:

This has been done in pr #118 but i still want to redo that section after qiskit version 0.5


sfDecorator asking for new/isolated scope

<form
    class="demeter-schema-form"
  	name="UserImpersonationForm"
  	sf-schema="schema"
  	sf-form="form"
    sf-decorator="everline-schema-form-decorator"
  	sf-model="model"></form>
</div>

Then I get the error...
Error: [$compile:multidir] Multiple directives [sfDecorator, sfSchema] asking for new/isolated scope on:

Ah, that was unfortunate. sf-decorator is a bit broken currently.
A workaround could be to only load your decorator, that way it should default to use it without having to using the sf-decorator directive.

At https://github.com/Textalk/angular-schema-form/blob/development/src/services/decorators.js#L396 the default decorator is named 'sfDecorator'. Unfortunately, this is also the name of the attribute that determines which decorator to use for a form. Is there any good reason why not to change the name to 'sfDefaultDecorator' to prevent further scope conflicts?

Hi @nikolassv,
we'll it'll be a lot easier to just change the name of the attribute to something else since then you don't need to update the templates. So I changed it to sf-use-decorator see 446d8465dbe47cc9bce18686064bcc8ec33a1130
There is still #29 to fix as well though.


Multiple Column Layout for Categories

Hi, I'm new to Serenity. So far love it.
Is there a way to change the layout of a form, so I can put the categories' div side by side. Say, in Northwind, I want Shipping category and Ship To category side by side.
Also, I wanto to assign css class to category. How can I do that?
Thanks

You need to do it with CSS. It is not possible to assign CSS class to category. You may do it in dialog, using jQuery and index.

Do it in dialog, using jQuery and index: May I trouble you with some sample code?
Css class for category: May I request the feature? Some overload in CategoryAttribute: Category("categoryname", "cssClass"). I think that would be useful for others too
Thanks

this.form.SomeCategory.element.closest('.category').addClass('something')
I don't think it's a priority.


Missing files for RAK18000_Stereo

###Summary
Under Load Examples on:
https://github.com/RAKWireless/WisBlock/tree/master/quickstart/RAK4630
There is a reference to RAK18000_Stereo. Clicking on this link produces a 404 or otherwise missing files.
You can see there is no RAK18000_Stereo folder at:
https://github.com/RAKWireless/WisBlock/tree/master/examples/RAK4630/IO
Defining Done

[ ] Add missing files

Fixed with commit #cc0c5f

Thank you for reporting the problem.


Custom Post Types

Do custom post types receive a "content" field automatically?

for post_types the content is the description added on post_type form.

Do I have to do <%= f.textarea :description %> in the admin?

The description can be edited in admin->settings->post type.
Screenshot:

I'm not talking about that. I'm talking about when creating a new instance of a certain post type

mmm I am sorry, in which section you are trying to do that?

I'm just wondering if a custom post type created from a plugin gets a field for content like it does in Wordpress.
I am ok with adding my own field and using tinymce.


added two more FAQ proposed by azure support team

Hi @SunBuild, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (sumuth). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Thanks for your contributions to Azure docs


Dependency on lodash.findindex causes deep file tree and long paths that breaks Windows

Would you accept a pull request to update the dependency to the full lodash module?
It would help a lot of us Windows devs who would like to use this module (and other packages that depend on it, like gulp).
Here's a discussion of the issue - https://github.com/joyent/node/issues/6960. The custom lodash builds are particularly painful...
Cheers,
Caley

Just a heads up. lodash v3 has significantly reduced the dep graphs of its modularized packages:
<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ ├──<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    ├──<EMAIL_ADDRESS>    ├──<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>


Add condition is for non VPC ES to allow anonymous access from whitelisted IP ranges without requests signing

what

Allow IP-based Policy which allows for access without request signing

why

As keycloak-gatekeeper should have direct access to Kibana

references

https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-ac.html#es-ac-types-ip
https://aws.amazon.com/premiumsupport/knowledge-center/anonymous-not-authorized-elasticsearch/

/test all


[Feature][Spark] Suggest support spark 3.1.2 in seatunnel

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Suggest support spark 3.1.2 in seatunnel.
Usage Scenario
No response
Related issues
#1542
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

let we discuss on #875


Error on PHP statements without a closing semicolon (Anticipated PHP compilation error)

Blade supports PHP code without a closing semicolon:
@php $counter = 1 @endphp

The validator returns this error:
Anticipated PHP compilation error: [syntax error, unexpected end of file]
See also:
https://github.com/laravel/framework/blob/0ec445970da249578296796ee0aeefc03813bc23/src/Illuminate/View/Compilers/Concerns/CompilesRawPhp.php#L16

Currently working as intended. The linked line refers to the compilation behavior of
@php ($counter = 1)

The following will also produce the same resulting PHP:
<?php

use Illuminate\Support\Facades\Blade;

$result = Blade::compileString('@php $counter = 1 @endphp');

Example of behavior parity:
https://github.com/laravel/framework/blob/0ec445970da249578296796ee0aeefc03813bc23/tests/View/Blade/BladeVerbatimTest.php#L82

nvm (shouldn't review when so tired) - spotted the issue

Corrected in 1.0.3 🙂

Nice! I've found another case that leads to a false positive:
@php
    if ($someVar) {
        echo 'Yes';
    } else {
        echo 'No';
    }
@endphp

Nice! I've found another case that leads to a false positive:
@php
    if ($someVar) {
        echo 'Yes';
    } else {
        echo 'No';
    }
@endphp

Is this triggering the Anticipated PHP compilation error: [syntax error, unexpected end of file] for you in 1.0.3? If so, are there any other @php directives in the template?
I'm have trouble reproducing on the latest version with that template by itself. Thanks!


@Vignesh025 Assign this to me under gssoc 2024 ext and hacktoberfest i will work on this issue.

We can filter based on cost like this much min to this much max and like location like it is mountain, park, lake or so, type of activity we can do there like hicking, fishing, boating, swimming and so other options can be there

Hey @tarunkumar2005, we already have filters for cost and reviews, and we don't require filters for other things at the moment.


Add EventLog endpoint to Traffic Monitor 2.0

Done https://github.com/Comcast/traffic_control/blob/master/traffic_monitor/experimental/traffic_monitor/http_server/http_server.go#L37


Add internal components like Tab, TableCell etc.. to show on the search options

@ShimiSun Looks like all that would need to be done to get more components to show up in the search results would be to add them to the object in https://github.com/grommet/grommet-site/blob/master/src/structure.js.
The only problem with this is that the same object is used to populate /components which requires a file for each component in this directory: https://github.com/grommet/grommet-site/tree/master/src/screens
Those items are then used to populate the screen by being pulled in here: https://github.com/grommet/grommet-site/blob/master/src/screens/Components/index.js
Since the docs for all these components appear to all be complete in the main repo, the task would be more about moving items around, but would still be a pretty substantial change. If this were to go through, there would need to be a decision made about how these internal components would be structured in structure.js to make sure they show up in the correct headings and then mockups for the icons to display these components on the /components route.
Let me know if you want any help on this, I'm happy to do some work and open a PR for it.


Replace app-2.5.2.js with unminified JS

From https://www.reddit.com/r/selfhosted/comments/wzkbkr/comment/im5am8d
Any code (even if its ugly) is better than the minified version

This will increase the file size, maybe we can add 2.5.1-unminified.js or something like that? But anyone can do this online or use any CLI tools.

Also read this https://github.com/openspeedtest/Speed-Test/issues/26#issuecomment-1229545094


Needed Support to obtain Max Pooling Layer Indices and Unpooling Layer

using Latest ARM Compute Library 18.05
ARM_NEON (ARM Cortex v7)
Working on Raspberry Pi3 -- Arch Linux
I couldn't find any method to obtain Max Pooling Layer Indices. Could you provide me a method to obtain Max Pooling Layer Indices ?
Is there any Implementation of Unpooling Layer in ARM Compute Library?

Hi @BhaskarsarmaP ,
Could you please provide us with more information about these layers and examples of networks that are using them ?
Thanks

I also need unpooling layer. Segmentation neural networks are using them, for example SegNet: http://mi.eng.cam.ac.uk/projects/segnet/ or UNet: https://arxiv.org/pdf/1505.04597.pdf. What is your estimation when that layer could be implemented?

Thanks for the information, we'll try to fit it in the November release if we can.


Contributor level access can connect through explorer to service bus

I am trying to connect as contributer level access to service bus, but getting timeout exception.
Do i need to change anything here in appsetting ?
<add key="subscriptionId" value="XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" />
<add key="certificateThumbprint" value="XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" />
See the attached image.

By contributor access, do you mean you have Contributor access on the Service Bus namespace? Currently there is not support for authentication through Azure AD, but hopefully we can add that in the future.
Right now there is only support for connecting using SAS keys.

Closing due to no response.

Closing due to no response.


Debugger - ValueError: source code string cannot contain null bytes

Environment data

VS Code version: 1.33.0
Extension version (available under the Extensions sidebar): 2019.3.6352
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda):  3.7.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Expected behaviour
Debug python code
Actual behaviour
Error.
Steps to reproduce:

Create a simple python file, such as:

print('hello')

Start debugger

Logs
Traceback (most recent call last):
File ".vscode\extensions\ms-python.python-2019.3.6352\pythonFiles\ptvsd_launcher.py", line 21, in
import ptvsd
File ".vscode\extensions\ms-python.python-2019.3.6352\pythonFiles\lib\python\ptvsd_init_.py", line 13, in
from ._vendored import force_pydevd
ValueError: source code string cannot contain null bytes

https://github.com/Microsoft/ptvsd/issues/1323#issuecomment-481058988 solved this issue.

I also see this in one setup.py file, the comment above doesn' t work for me.

This should be fixed upstream, if you still can repro this, please file an issue here: https://github.com/microsoft/ptvsd/issues/new/choose


Indexer makes one fetch for full block range

The block range im concerned about gathering events for is ~600K wide.
the resulting rpc call is for eth_getLogs for the full range, which always will time out for my use case. Can we configure step size somehow?
The example where the end block is only 100 blocks ahead works perfectly
name: kamicsv
project_type: rust
networks:
- name: yominet
  chain_id:<PHONE_NUMBER>
  rpc: https://yominet.rpc.caldera.xyz/http
storage:
  csv:
    enabled: true
    path: ./generated_csv
contracts:
- name: World
  details:
  - network: yominet
    address: 0x441e13a25caecad50028e7623a39b91a507bca02
    start_block: '1077466'
    # end_block: '1077566'
    # end_block: '1650276'
  abi: ./abis/World.abi.json
  include_events:
  - ComponentValueSet

20 July - 14:33:20.921676 TRACE rpc{method="eth_getLogs" params="[{\"fromBlock\":\"0x10713e\",\"toBlock\":\"0x193348\",\"address\":\"0x441e13a25caecad50028e7623a39b91a507bca02\",\"topics\":[\"0x6ac31c38682e0128240cf68316d7ae751020d8f74c614e2a30278afcec8a6073\"]}]"}: take? ("https", yominet.rpc.caldera.xyz): expiration = Some(90s)

Hey so to note mostly all the main RPC providers bring back a response if range to large and then from there you can index the most optimal amount of logs each time
code: https://github.com/joshstevens19/rindexer/blob/master/core/src/indexer/fetch_logs.rs#L503
info: https://rindexer.xyz/docs/references/rpc-node-providers#rpc-node-providers
I was going to add a max_block_size but i didn't in the end, the RPC provider your using does do the above? scanning blocks by blocks is slower then doing what the above RPC providers do. I can for sure add this on the contract > details level so you can config max_block_size per contract or would you expect it on the network level where you config the rpc node?

I feel the best place here is to add it on the network level as it tends to be network RPC globally these limits

unfortunately this rpc provider is the only one available for the network and doesnt provide an optimal range. The RPC docs say that only 1000 events can be returned, and any over that then responds with an error.
So generally I've been indexing 20 blocks per request...😭 It's slow but it's consistent.

I feel the best place here is to add it on the network level as it tends to be network RPC globally these limits

yes i agree

ha ha makes sense!
i need to add this anyway for something else I'm doing for rindexer so il switch to do this tonight for us, i think its small thing as we have all the code anyway just on the Option need to pick it from the manifest yaml and expose a field to define it

awesome!

https://github.com/joshstevens19/rindexer/commit/8ff14c102962606da4318eebb2faf7f9fbdb34c2
https://rindexer.xyz/docs/start-building/yaml-config/networks#max_block_range
will deploy in next 1 hour

https://github.com/joshstevens19/rindexer/pull/59

rindexerup - version 0.2.0 👍

this works perfectly. and dang is it fast! about 3x faster than my crappy python indexer. just switched over! ty

That’s what we like the hear! 🔥


Consider making traces directly implement the (read only) assignment interface

@alex-lew suggested that it not be necessary to have separate get_assignment step to go from an execution trace to something that exposes an assignment.
The current behavior is:
assignment = get_assignment(trace)
slope_value = assignment[:slope]

The proposed behavior is:
slope_value = trace[:slope]

However, having a separate data type that does not expose the trace API can result in clearer information hiding; this is similar to wrapping a mutable data type in an immutable value that doesn't expose any mutation methods.

I think we should keep get_assignment. We can keep the Assignment
abstract type (which is useful for readability of type signatures, and for
code reuse), and keep get_assignment, while still having the concise
syntactic indexing style for reading values from traces.
On Nov 18, 2018 5:26 PM, "Feras Saad"<EMAIL_ADDRESS>wrote:
If the syntax trace[:slope] might lead to confusion about the Trace vs
Assignment data point one possibility to reduce verbosity might be
slope_value = get_assignment(trace, :slope)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/probcomp/Gen/issues/29#issuecomment-439731596, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABihtMHr7h52mAgD3vwfrnWyZxGNvHb5ks5uwd6jgaJpZM4YoKtE
.


[now dev] Assertion failed Windows pipe

Getting the following error while attempting to run now dev on a simple static build:
Assertion failed: handle->pipe.conn.remaining_ipc_rawdata_bytes >= bytes, file c:\pkg-fetch\precompile\node\deps\uv\src\win\pipe.c, line 1666

Windows 10
Node v10.6.0
Now 15.8.5

Thanks for reporting this. Does now@canary work? We've removed the entire installation mechanism with binaries that we had before in favor of a regular npm package.

@leo I'm upgrading my Node now to see if that changes anything. If not, I'll try canary. Is that just a npm install now@canary -g to get up on it?

@szul Correct, npm install now@canary -g.

@leo The upgrade to Node v10.16.0 seems to have resolved this.


Add a license

Can you add a license to this repository?

MIT license has been set up.

@atamazian
Please comment on Disscussion for a summary, as exchanges on github may fall under the category of private sharing.

Done


Mobile view is messed up

steps to reproduce

go to http://blog.originate.com/git-town
make the browser window really narrow

expected: I see a nicely formatted web site in mobile view
actual: the web site's layout is garbled, some elements are not visible at all

Closing as the website looks pretty nice on mobile. Thanks @redouglas.


update vendor for mips64 and mips64el

Signed-off-by: wanghuaiqing<EMAIL_ADDRESS>

@ tonistiigi PTAL

@tonistiigi
If I do not add estargz, the following error will occur.
Please check it.
[root@whq binfmt]# go run cmd/binfmt/config.go cmd/binfmt/main.go
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/gopath/pkg/mod/cache/vcs/0c47353239954145e83a4629fd4c83b84eb1e06381df0c483f130ea80d8e0232: exit status 128:
	error: RPC failed; result=18, HTTP code = 200
	fatal: The remote end hung up unexpectedly
	fatal: 过早的文件结束符（EOF）
	fatal: index-pack failed

@tonistiigi I have added mips64le to image tonistiigi/binfmt, please review it.
https://github.com/tonistiigi/binfmt/pull/21

@ktock fyi ^

Currently, we have two go.mod in one repo so replace directive is needed if the project has a dependency to github.com/containerd/stargz-snapshotter on go.mod level, even if it doesn't actually use codes from that repo.
We start to track this issue on https://github.com/containerd/stargz-snapshotter/issues/259.
At this moment, please add the replace directive and we'll remove this once that issue is solved.


Refresh bug

Steps:
upload archive,
go to all grades,
refresh

Additional information: this bug happened when the server was under high load and a write  operation to the database (that was taking too long) was interrupted. This left the database locked for any operations, reads or writes, and the server could no longer be used.
A quick solution was to replace the database with a new one:
mv vmchecker.db vmchecker-locked.db
echo ".dump" | sqlite3 vmchecker-locked.db | sqlite3 vmchecker.db

After this the service recovered.


libwinpthread-1.dll mangling

We recently had to add --no-mangle "libwinpthread-1.dll" in one of our private repositories because we were seeing:

RuntimeError: Unable to rename the dependencies of libgcc_s_seh-1.dll because this DLL has trailing data. If this DLL was created with MinGW, run the strip utility. Otherwise, include {'libwinpthread-1.dll'} in the --no-mangle flag. In addition, if you believe that delvewheel should avoid name-mangling a specific DLL by default, open an issue at https://github.com/adang1345/delvewheel/issues and include this error message.

I have no idea why this happened - the only change in our build was the cibuildwheel version (1.10 -> 2.3.0), which also changed the pip version (21.1 -> 21.3). Earlier today, everything was fine with cibuildwheel 1.10 / pip 21.1, but again, I don't see the connection as these bumps wouldn't change any DLL version. Both are using delvewheel 0.0.15.
I see that psycopg2 also encountered the same issue.
https://github.com/psycopg/psycopg/commit/6c3cc44bc359be522575801556d133271f1d88e8
Maybe you want to add libwinpthread-1.dll to the default "no-mangle" list.

Evidently, something changed with libgcc_s_seh-1.dll. Maybe MinGW was updated on the build machine. I'll add libwinpthread-1.dll to the default no-mangle list.