python312Packages.exceptiongroup: refactor

Diff: https://github.com/agronholm/exceptiongroup/compare/1.2.0...1.2.1
Changelog: https://github.com/agronholm/exceptiongroup/blob/1.2.1/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@fabaff Could you rebase this?

Partially done in https://github.com/NixOS/nixpkgs/commit/e8059fc26ad23146540a2d5796ce8dd5114ab618.

@ofborg build python312Packages.exceptiongroup python311Packages.exceptiongroup python312Packages.cachetools


Issue296 replace spring

@Mwoodin12 did you intend to create this? This pull request seems to be merging two stale branches which have nothing to do with each other.


Address review comments for Communication & CosmosDB

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.CosmosDB


Tictactoe

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes:  #542

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

https://deploy-preview-568--amazing-js-projects.netlify.app/tic-tac-toe with 2 player/

Done With it.

cross is fixed but circle still isn't in center

Done !!

https://github.com/angle943/tic-tac-toe


Set power limit over web page

Hi @hirbelo ,
thanks for the contribution and nice idea for the placement of reaching the change overlay screen. I will check that for the next dev snapshot ...
BR


Outdated WalletLink Code --> Needs to be updated to Coinbase Wallet SDK

Hi,
I work on the DevRel team at Coinbase and am submitting this issue to inform you that the WalletLink SDK has been deprecated in favor of our new Coinbase Wallet SDK. You can find more on that and how to upgrade to the latest version here.
Please let me know if you have any questions!
Thanks,
Trevor

@TrevvvD thanks for letting us know! I will swap it out then

Done https://github.com/snapshot-labs/lock/pull/49


[WFRP4e Core] Quarterstaff typo in Hedge Witch & Witch Career descriptions

In the Hedge Witch and Witch Career descriptions, they both gain "Quartersta?", instead of "Quarterstaff".From: The First#7330foundry: 10.285wfrp4e: 6.1.2

Also similar issue with the last level of Envoy. It has "staff" as trapping. Same typo.


unable to read node_info.json

When I run core diag, I run into the following command
parser warnings
---------------
* unable to read 'node_info.json'

I am running cassandra 3.0.15 and I am manually running collect_node_diag.sh on each node. I have looked in the script but I can't seem to find where it is getting created. Is this DSE related?

The node_info.json is generated by the opscenter diag tarball and can be used to find the read ahead for the cassandra drives. If the node_info.json is not present the read ahead is not guessed or attempted then.
Since that is only one diagnostic signal among many that is a safe to ignore warning in that case

Thank you for the explanation.


Match all entries that contain given string by default in instance filter builder

Closes 459
Modified instance filter builder to automatically append % to both sides of the value, to match all entries that contain given string by default.

After some discussions decided that we cannot correctly handle all possible cases when converting PresentationInstanceFilter <-> GenericInstanceFilter. It's better to leave escaping/adding wildcard characters at output generation step. However, we should add note to GenericInstanceFilterRuleOperator and PropertyFilterRuleOperator types that like operator should be handled as contains.


L2TP/IPsec from IPv6 clients

Prerequisites

[ Y ] Can you reproduce?
[ Y ] Are you running the latest version of SoftEtherVPN?

SoftEther version: 5.01.9670
Component: Server
Operating system: Linux(OpenWrt)
Architecture: X86_64
Processor: Intel(R) Pentium(R) CPU N3710
Description
Sorry for my English. I compiled SoftEther VPN server 5.01.9670 from OpenWrt packages feed and installed it on my router. It runs OK, but when I tried to connect to my router through L2TP/IPsec from my office (I used IPv6 to connect), it failed to connect. I used to have a stable version of v4.29-9680-rtm before. With the same configuration (I tried exactly the same vpn_server.config file, and also from a fresh reconfiguration), L2TP/IPsec from IPv6 clients worked without any flaws. What I found was that "netstat -lnp" showed the 5.01.9670 versions listened to udp port 1701, 4500 and 500, but only IPv4 of them. The v4.29-9680-rtm listened to further more, including udp :::1701, :::4500 and :::500, raw protocol 50 and 52 for both IPv4 and IPv6. I think that may be the problem.
Expected behavior:
The server listens to udp 1701, 4500, 500 and raw protocol 50, 52 for both IPv4 and IPv6. Thus we can make L2TP/IPsec connections from IPv6 clients.
Actual behavior:
I can't connect L2TP/IPsec VPN from IPv6 clients.
Steps to reproduce

Install 5.01.9670 version of server and run. Try to connect L2TP/IPsec VPN from IPv6 clients and use "netstat -lnp" to find out what ports is it listening to.
Install v4.29-9680-rtm version of server and run. Try to connect L2TP/IPsec VPN from IPv6 clients and use "netstat -lnp" to find out what ports is it listening to.

nice report, btw

@Andy2244 , can you have a look, please ?

mhh if your openwrt version was compiled with ipv6 (default) support, than ipv6 "should" work.
I personally only use the softether protocol via ipv4, so have not personally tested the other permutations, so i rely on user feedback for those.
@chipitsine Is there a specific build option for ipv6, i should check, be aware of?


Resizing Image With InfoOptions not work

I have to tried this way to cache and download image with InfoOptions but it's not work well like when I'm using
thumbnailImageView.kf_setImageWithURL(<#T##URL: NSURL?##NSURL?#>, placeholderImage: <#T##Image?#>, optionsInfo: <#T##KingfisherOptionsInfo?#>)
InfoOptions parameter passing not working at least with Transaction Option. When I scrolling my tableview cell, look like image replacing not exactly.
I provide my code below. Please help me. Thank.
`
let imageManager = KingfisherManager.sharedManager
let keyForCaching = NSURL(string: thumbnailImage)?.absoluteString
        let infoOptions : KingfisherOptionsInfo = [.Transition(.Fade(2.0)),
                                                   .ForceTransition]

        imageManager.cache.retrieveImageForKey(keyForCaching!, options: infoOptions, completionHandler: { (imageCached, _) in
            if let image = imageCached {
                self.thumbnailImageView.image = image
            }else{
                self.imageManager.downloader.downloadImageWithURL(NSURL(string: thumbnailImage)!, options: infoOptions, progressBlock: nil, completionHandler: { (image, error, imageURL, originalData) in

                    let scaleImage = image?.imageAspectScaledToFillSize(CGSize(width: 375, height: 185))

                    self.imageManager.cache.storeImage(scaleImage!, forKey: keyForCaching!)

                    self.thumbnailImageView.image = scaleImage

                })
            }
        })

`

The transition option only works when you use the image extension methods of Kingfisher. Instead of checking the cache of manager, just use the imageView.kf_setImage methods will apply the transition effect.
I could understand that you need to cache the resized images before storing it. It is a feature in plan and will be implemented soon. Currently, you might do the transition yourself if you are using the imageView setter method directly.
Ref: #320

Thank for quick reply. I have 1 more question.
Do you mean only transition option work with image extension methods of Kingfisher or any others options like BackgroundDecode or CacheMemoryOnly have same ?

All options work with image extensions. But usually the default values are good enough (except for the transition style), so there is no need to set them explicitly unless you really need.


⚠ Bofrost.de has degraded performance

In 8151590, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1384 ms

Resolved: Bofrost.de performance has improved in b1f8707 after 7 minutes.


Separate Blazor package from shared project

Separate Blazor package from shared project.
The template must be updated to reflect this change.
Typically there is no problem with the current implementation, but if we don't change this logic, the ElectronNET version of the app will have the application packaged twice: One from the real linked assemblies, and the other one from the zip package embedded in the shared project, but not used as there is no usage of WASM implementation in this scenario.
Instead we must

[x] Add BlazorMobile.Sample.AppPackage project, that will embed the Zip ressource
[x] Remove the embedded Package from shared project and add it in AppPackage the same way instead
[x] Reference AppPackage project on BlazorMobile.Sample.Android/iOS/UWP
[x] Register AppStreamResolver from Android/iOS/UWP projects

This way we will never register directly the requested Blazor app from the shared project, and so avoiding to increase project size on non-BlazorMobile platforms like ElectronNET.

Done


Remove class and move it to style.css.

@jmervine: we need to update the SRI hash for style.css. How do you generate them? With integrity.js? Because I'm getting tons of changes in hashes locally.

Oh, also, maybe we should automate our assets SRI hash generation to save us some time in the future.

@XhmikosR scripts/integrity.js does that for all assets (Bootstrap, etc.) and updates config.json,  it wouldn't be that hard to expand it. We should also probably add a make task for it. Adding an issue to do so.

Weird, because I get tons of changes when I run it. Can you run it and compare the changes?

In the mean time, can you run scripts/sri.js on this file and update the config?

Wait for CI to finish, and check the deployment just to be safe.
I still believe we should check the hash stuff because I see a lot of differences even when I change everything to use LF.

Fair, most of the SRI's are being tested, I believe, but perhaps not style.css, that said, it should change with an change to the file.

I think we are all set.


Allow amount to be set by the calling function as it is valid to pass…

… a greater amount as part of the initial payment express transaction

Good idea, thanks.


Improvements slow OpenLibrary API calls

Background
The frontend directly calls the OpenLibrary API to fetch books information (title, description, isbn,  cover image, etc) and is fully responsible for powering the frontend search in which we can search books by title or isbn.
Our backend does not talk to OpenLibrary, all is handled by the frontend that then sends the information to the backend for saving books in the users library. The backend only saves the most necessary information, so we do not for example save cover images.
The problem
The OpenLibrary API is slow and this hinders us from fetching the information in a quick enough manner that does not impact user experience. Searching is exceptionally slow and even getting a cover image can take long enough for it to timeout and in the end not get any image at all.
This is okay for now, it works and as it is a free service the performance is nothing to complain about.
Proposed solution
OpenLibrary is open data and does provide us with data dumps that can be downloaded and handled locally. There has been previous work  done to take the data dumps and importing it into a database that can be more easily searchable.
Doing something similar to this as well as serving all the image covers should give us more control and shorten the distance to the data.
We need to be able to do free-text search for titles as well as search by ISBN (we have thus far only focused on ISBN-13). And be able to retrieve different cover image sizes by ISBN.
Some disadvantages to this solution is that OpenLibrary has millions of books in there database and the dumps are around 40 GB in size (excluding all cover images). We will have to develop a pipeline for creating the local database based on data from new dumps that gets released regularly, and ingestion will probably take a long time.
More research on this topic need to be done.

I spent some time looking into this and fixing the search experience was surprisingly easy. Work is being done in a separate repo as we don't have to create something that can only be used with this project. We might also want the user to select which search API to use when installing the service..
The cover images are an entirely different beast to handle, it looks to be around 1.2TB of images and that is a lot more than what a regular person wants to handle for this kind of service.
https://github.com/mozzo1000/openlibrary-local-db
https://fosstodon.org/@mozzo/112808589345794906
This issue will remain open even though most work is being done in a separate repo at the moment.


making the subnet slicing for netmask_length dynamic based on the top_cidr

Hello @drewmullen  I have another random question.
How I make the subnet slicing value for netmask_length dynamic based on the top_cidr
For example
module "basic" {
  # source  = "aws-ia/ipam/aws"
  source = "../.."

  top_cidr = ["<IP_ADDRESS>/8"]
  top_name = "basic ipam"

  pool_configurations = {
    corporate-us-west-2 = {
      description = "2nd level, locale us-west-2 pool"
      cidr        = ["<IP_ADDRESS>/16", "<IP_ADDRESS>/16"]

      sub_pools = {

        sandbox = {
          name                 = "mysandbox"
          netmask_length = ### need a dynamic slicing value here ###
          ram_share_principals = var.sandbox_ou_arn
          allocation_resource_tags = {
            env = "sandbox"
          }
        }
        dev = {
          netmask_length = 20

          sub_pools = {
            team_a = {
             netmask_length = ### need a dynamic slicing value here ###
              ram_share_principals = var.prod_account # prod account
              locale               = "us-west-2"
            }

            team_b = {
              netmask_length = ### need a dynamic slicing value here ###
              ram_share_principals = var.prod_account # prod account
            }
          }
        }
        prod = {
          netmask_length = ### need a dynamic slicing value here ###
          locale = "us-west-2"

          sub_pools = {
            team_a = {
              netmask_length = ### need a dynamic slicing value here ###
              ram_share_principals = var.prod_account # prod account
            }

            team_b = {
              netmask_length = ### need a dynamic slicing value here ###
              ram_share_principals = var.prod_account # prod account
            }
          }
        }
      }
    }
    us-east-1 = {
      netmask_length = ### need a dynamic slicing value here ###
      locale = "us-east-1"

      sub_pools = {

        team_a = {
          netmask_length = ### need a dynamic slicing value here ###
          ram_share_principals = var.prod_ou_arn
        }

        team_b = {
          netmask_length = ### need a dynamic slicing value here ###
          ram_share_principals = var.prod_ou_arn
        }
      }
    }
  }
}

I don't want to hardcode each values of the netmask_length
Thanks in advance

Hi @ukohae, thank you for opening this issue.
You must pass either a Cidr or netmask value to each pool. If you want to further abstract the nested pools you'd have to use the aws_ipam_* resources natively

Thanks for the information. One more final question @drewmullen
I noticed in the cidr we have two values.
I have a scenario in my environment where we have a list of cidrs i.e cidr =[ cidr1, cidr2]
in a situation where I am given the following,
cidr =[<IP_ADDRESS>/13,  <IP_ADDRESS>/14]
Route Summary: <IP_ADDRESS>/13 + <IP_ADDRESS>/14
and
cidr =[ <IP_ADDRESS>/14, <IP_ADDRESS>/14]
Route Summary: <IP_ADDRESS>/14 + <IP_ADDRESS>/14
what are netmask_length

You can only pass a single netmask length to that parameter. Most people specify the full cidrs so they have more control


Debugger not showing breakpoint highlight

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T13:56:35.908Z)
OS Version: Darwin x64 16.4.0
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.6.1

Go
lukehoban
0.6.55

debugger-for-chrome
msjsdiag
2.6.0

vetur
octref
0.5.1

java
redhat
0.0.11

vscode-icons
robertohuertasm
7.3.0

language-stylus
sysoev
1.6.0

vim
vscodevim
0.6.3

Steps to Reproduce:

For this project: https://github.com/octref/vscode-electron-debug/tree/master/electron-quick-start

Add two lines here to debug:

Debugger is stopping on the breakpoints, but nothing is being shown.
I'm positive this is a regression. Previously it worked fine.
@weinand

dup of https://github.com/Microsoft/vscode/issues/22466

Dup of itself?

@octref sorry, I've fixed the link.


Can't run the binary release on Amazon Linux 2

The binary release gets the following error when you run on Amazon Linux 2:
/lib64/libm.so.6: version 'GLIBC_2.29' not found
I believe this is resolved by using cargo dist which it looks like you've already set up but haven't made a release since you did that. Any chance you could do a release and see if that resolves the problem?

Sorry for the late reply. Please try the newly released 0.1.9

And please re-open the issue if it doesn't work on 0.1.9

FYI @akesson, this still doesn't work due to cargo-dist not supporting this like I thought it did. I'm falling back on building as part of my deployment for now. Unfortunately, it adds about 7 minutes to a 10-minute deployment which isn't ideal.
I've opened axodotdev/cargo-dist#264 so we'll see if there's any interest in adding support over there.
Thanks a lot for being a bit more pro-active in doing releases and looking at PRs lately. It's much appreciated.

Other way to accomplish the portability would be to build static binaries with musl. This is also not yet supported by cargo-dist though


 What's wrong with my initial code?

I was making a few changes:

Change contrast from 0-1 to 0-100 like the other effects
Automatically reapply settings when entering fullscreen so "is canvas clear" can be removed
Make blocks and effects consistent with Scratch (lowercase text and menus)

Other formatting changes were coincidental in those efforts.

In particular this is a candidate for possibly being listed in the editor's extension library, so I'm setting the bar a bit higher


Padding with 0 in mel2samp is harmful

This code in mel2samp.py pads the small audio with zeros, causing loss instability:
        # Take segment
        if audio.size(0) >= self.segment_length:
            max_audio_start = audio.size(0) - self.segment_length
            audio_start = random.randint(0, max_audio_start)
            audio = audio[audio_start:audio_start+self.segment_length]
        else:
            audio = torch.nn.functional.pad(audio, (0, self.segment_length - audio.size(0)), 'constant').data

it is not relevant for the default setup, since ljspeech samples are longer than 1 second and the segment_length is less than 1 second, but in different datsets it might cause serious issues. Its better to skip such audio files probably or pad with silent white noise instead.

why?

Closing due to inactivity.

@nshmyrev did you confirm that not padding with zeros fixes the issue?

Yes

great, thank you!


Documentation link is broken

The link to docs at Imperial gets redirected to a generic URL.

Thanks - should be fixed, and added link to VM download


Add docker group instructions and certs info to description

This PR

adds additional info to the description. This info was already available in the README but not in the description.
removes the line about docker.compose from the readme (there seems to be an alias in place)
fixes some linter errors in the readme

Note: my previous changes to the description did not propagate to the store page. This is probably because the description in the store was manually changed. You might need to run snapcraft upload-metadata explicitly before the metadata in the store will be changed.

Seems generally sane to me!  Thank you.

Note: my previous changes to the description did not propagate to the store page. This is probably because the description in the store was manually changed. You might need to run snapcraft upload-metadata explicitly before the metadata in the store will be changed.

This is where things get dicey for me -- I don't actually use snapcraft locally for anything except performing test builds.  The builds on https://snapcraft.io/docker get built by the (semi-new?) post-commit automation there.  Also, I don't know whether a build with your changes has actually propagated to the stable channel, so perhaps that's why the description hasn't auto-updated?  I would've expected the snapcraft.io auto-builds feature to be more intelligent about this, is there perhaps a way to "reset" the metadata and request that it be regenerated from the snap metadata instead?

Also, I don't know whether a build with your changes has actually propagated to the stable channel, so perhaps that's why the description hasn't auto-updated?

In the past, updates to the edge channel also change the stable snap metadata in the store in the past. I filed an issue for this, but the devs decided this was expected behavior.

is there perhaps a way to "reset" the metadata and request that it be regenerated from the snap metadata instead?

As far as I know, the only way to reset the metadata is to force-update the metadata using the snapcraft tool. Once you update it from the store GUI, it won't get automatically updated anymore until you force-update it using the cli.

Also, I don't know whether a build with your changes has actually propagated to the stable channel, so perhaps that's why the description hasn't auto-updated?

In the past, updates to the edge channel also change the stable snap metadata in the store in the past. I filed an issue for this, but the devs decided this was expected behavior.

is there perhaps a way to "reset" the metadata and request that it be regenerated from the snap metadata instead?

As far as I know, the only way to reset the metadata is to force-update the metadata using the snapcraft tool. Once you update it from the store GUI, it won't get automatically updated anymore until you force-update it using the cli.

Also, I don't know whether a build with your changes has actually propagated to the stable channel, so perhaps that's why the description hasn't auto-updated?

In the past, updates to the edge channel also change the stable snap metadata in the store in the past. I filed an issue for this, but the devs decided this was expected behavior.

is there perhaps a way to "reset" the metadata and request that it be regenerated from the snap metadata instead?

As far as I know, the only way to reset the metadata is to force-update the metadata using the snapcraft tool. Once you update it from the store GUI, it won't get automatically updated anymore until you force-update it using the cli.

Ah, fair enough, I suppose (seems like somewhere the "Builds" feature could be improved :sweat_smile:).
I'll see what I can do with the local client to get the current merged changes up so it can hopefully auto-sync when we get these changes in. :+1:

... I think I managed to Do The Thing: https://snapcraft.io/docker :innocent:
(Gonna merge this now)

Doh, builds are failing thanks to what I hacked around in #23 ...
(underlying fix in https://github.com/snapcore/snapcraft/pull/3429 is not in a release yet :weary:)

perhaps is reason enough to upgrade to base: core18 or core20 :open_mouth:  ? https://github.com/docker-snap/docker-snap/issues/15

I'm not running snap, lxd, or multipass locally (and none of them work super great inside a Docker container), and my dev environment is a VM that doesn't do nested VMs, so the workflow changes required for that are kind of a large hurdle for me (and the biggest reason that's not resolved beyond the issues listed in #15 like what to do about i386). :confused:

In case it helps; if you're using base: core18, you can direct snapcraft to use an LXD container instead of a VM by using snapcraft --use-lxd. This is useful in VM's.
More info: https://snapcraft.io/docs/build-on-lxd


[CPDLP-3003] Review migrator performance

Context
Ticket: CPDLP-3003
Currently the migrator completes all table migrations however whilst looking at the performance on the CPU usage is quite high.
Changes proposed in this pull request
Review/improve migrator performance.

Had to close the other PR as the review app in there was failing to be created. Opening another PR seems to have fixed the issue.

discussed in person with @leandroalemao: some migrators are dependant on each other while some are not. We would like to differentiate those as we cannot run them all in parallel right now. Since we don't have capacity to focus on this we can close this for now and I'll move the ticket to the backlog to revisit again later when we do. Thanks @leandroalemao :)


question

will the mod be updated to 1.19 or 1.19.1?

I'm not too sure yet. 1.19 changed how the game's text works in a way that broke the mod, and I have yet to figure out a solution that wouldn't break compatibility with earlier versions of Minecraft.

The answer is now yes. I have since added 1.19+ support in the v2 branch.


removed one stale line from console.log docstring

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
removed one stale line from console.log docstring

Thanks, fixed in master.


Automatically scan our code base for security vulnerabilities

Implement a code scanner that can run as a GitHub Action. Whomever picks up this ticket should propose a solution.

Look at GitHub security scanner that was recently released.

This is completed through the merged #1674 but there is also #1753 which would make this even more robust

It ink this can be closed


Update lib.rs

I appreciate that you’re cleaning up code, but this code is really meant to be fast. I’m not really interested in having “cleaner” code: I care more about performance.
Could you provide some form of benchmark to prove that your suggestions are faster?

I have done some benchmark here:
https://github.com/lengyijun/simple_comparision_with_for_and_iterator
I hope it's helpful

Thanks for your patience @lengyijun, released!


UReplicator installation

We found this project very useful for our use-case. We got through the example 2, with 2 Kafka Clusters [Kafka1 and Kafka2]. But when trying to move the clusters across different servers, we are stuck due to lack of understanding of the right configurations.
When we tried to move the Source Kafka Cluster to a different server, we got the error : "Leader for the Topic[topic_name] is not found". We are not sure if we have configured the system correctly.
Request to help us proceed here, as we see the UReplicator to be more stable than Apache Mirror Maker and would like to make use of the same in our project.
Thanks.

Can you paste details of your configuration ?

I started zookeeper as  ./bin/grid start zookeeper
I started kafka2 as        ./bin/grid start kafka2
I modified the SrcKafkaZkPath in uReplicator-Controller/src/main/java/com/uber/stream/kafka/mirrormaker/controller/ControllerStarter.java as
conf.setSrcKafkaZkPath("<IP_ADDRESS>:2181");  where my source cluster (3 nodes cluster. This is one of the zookeeper ip) is running.
And the config/topicmapping.properties test2 test2 instead of "dummyTopic dummyTopic1"
And also config/consumer.properties      zookeeper.connect=<IP_ADDRESS>:2181
and started running the scripts
./uReplicator-Distribution/target/uReplicator-Distribution-pkg/bin/start-controller-example1.sh
./uReplicator-Distribution/target/uReplicator-Distribution-pkg/bin/start-worker-example1.sh
After i added the topic using
curl -X POST -d '{"topic":"test2", "numPartitions":"1"}' http://localhost:9000/topics
The error I am getting in the worker is
kafka.consumer.ConsumerTimeoutException
at kafka.consumer.ConsumerIterator.makeNext(ConsumerIterator.scala:69)
at kafka.consumer.ConsumerIterator.makeNext(ConsumerIterator.scala:33)
at kafka.utils.IteratorTemplate.maybeComputeNext(IteratorTemplate.scala:66)
at kafka.utils.IteratorTemplate.hasNext(IteratorTemplate.scala:58)
at kafka.mirrormaker.MirrorMakerWorker$MirrorMakerThread.run(MirrorMakerWorker.scala:281)
And the topic is not replicating into destination kafka. Any more configuarations i need to change here?? What I am missing???

Does zookeeper path need root node?
e.g. conf.setSrcKafkaZkPath("<IP_ADDRESS>:2181/cluster1");
config/consumer.properties zookeeper.connect=<IP_ADDRESS>:2181/custer1

@RiseEarly @ravi45722 is the source kafka cluster on other hosts your own cluster? what version is that?

I think this could be because of a version mismatch between workers and the
Kafka brokers. Do you mind summarizing the exact version of all these
components:

kafka-client version in uReplicator
Kafka broker version (Source)
Kafka broker version (Destination)

On Thu, Jan 5, 2017 at 2:22 AM, RiseEarly<EMAIL_ADDRESS>wrote:

@xhl1988 https://github.com/xhl1988 : Source kafka cluster was on the
other hosts. We resolved this problem as there was a broker
in-compatibility : 0.9 consumers to 0.8 brokers.
But still we had another problem of zkClient incompatibility, which was
resolved post taking all the pull requests from this repository.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/uber/uReplicator/issues/15#issuecomment-270611281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAsb1wbTukZ8Lnx7iWEeW0xCujI75qHqks5rPMRNgaJpZM4LW16k
.

By replacing the "org.jacoco" version from "0.7.6-SNAPSHOT" to
"<IP_ADDRESS>602180812"
we resolved the zkclient incompatibility
Now we are using

<IP_ADDRESS> kafka in both source & dest clusters
3.4.6 zookeeper in both source & dest clusters
2.10.5 scala in both source & dest clusters


Port EditorData.xml

This file was used in the C++ version of NF to preserve data such as object descriptions and names across map import & export. These aren't typically stored in zone objects. You technically could store them directly in the zone files, the game should ignore properties it doesn't recognize. This is avoided for now avoid accidentally breaking the zone files.
The current approach is just to fill an xml file with this data and toss it in the root of the map vpp. The game ignores it and NF can get the object descriptions, names, and whatever else we might want to store in there through multiple imports and exports.
For now just port that behavior exactly. Eventually we might want to use the same format as the ProjectDB so we can store arbitrary data in the file and not need to write xml serialization code every time.

bon worked really well for serializing project data. Should use that instead of xml.


Change default meta-schema

As for now, default validation meta-schema is v4 or (if corresponding option is true) v5-proposal. How to change this behaviour and set my custom meta-schema as default? V4 defines shemas like {} as valid, what is unacceptable (in my case) for top-level schemas.

One approach is to create your own meta-schema (that would have minProperties: 1, I guess), add it to ajv (with addMetaSchema) and to use its id as $schema property in your schemas. See validateSchema reference.
I am not sure why do you need it though. Are your schemas supplied at run time? You can simply run additional validation on them with some simple schema if that's the case.

I am not sure why do you need it though. Are your schemas supplied at run time?
Yep, all of the schemas (except of core) stored externally, and it can change at runtime -- that's why I need extra logic to validate them.

One approach is to create your own meta-schema (that would have minProperties: 1, I guess), add it to ajv (with addMetaSchema) and to use its id as $schema property in your schemas. See validateSchema reference.
Schemas without $schema will fallback to the default v4/v5 schema.

Yes, they will fallback. Rightly so :)
In any case, I think the better approach is to impose any additional requirements via some additional schema (or even without schema) than to modify meta-schema. For example, you can validate all your external schemas with {minProperties: 1, additionalProperties: false}. The advantage is that the internal schemas will still be able to be empty (and it's a very useful thing in some cases...).
If you really must change the default meta-schema nobody can stop you from using the option meta: false, then adding your own meta-schema with the same ID as the default one has, using addMetaSchema(schema, id, false) (the last false will prevent it from being validated regardless the lack of the option that prevents schema validation - there will be nothing to validate it against yet). I don't like it though as you could guess :). I think the first approach is cleaner.

The problem is that I have A LOT of extra-logic for my external schemas (like root-only keywords, required properties, blacklisted properties for internal schemas) :C

If you really must change the default meta-schema nobody can stop you from using the option meta: false, then adding your own meta-schema with the same ID as the default one has, using addMetaSchema(schema, id, false) (the last false will prevent it from being validated regardless the lack of the option that prevents schema validation - there will be nothing to validate it against yet). I don't like it though as you could guess :). I think the first approach is cleaner.

That's what I do right now, but it's hacky and weird, and it means I use internal API, which one can be broken without updation major version.
Is any plans to add an explicit way to set the default meta-schema?

I will make this api public, it's just changing readme... It can be useful in some cases.
I don't like the idea of making such an option though. I will think about it.

I can now see several other use cases for it. So I think it can be done.
I think that this default meta-schema should be passed in meta option as an object (but v4 meta-schema and v5 meta-schema (in case v5 option is true) still should be added) . So it can't be changed within ajv instance.
The following has to be done:

[ ] draft 4 meta schema should still be added if option meta is schema
[ ] v5 meta schema should still be added if option meta is schema and option v5 is true
[ ] this meta schema must have a unique ID (different from draft 4 / v5 meta-schemas id), ajv should throw an exception otherwise
[ ] this default meta-schema will be validated against draft 4 or v5 meta-schema?
[ ] update readme
[ ] test(s) in options.spec.js: correct meta-schemas are used for the instances with/without v5 depending on the $schema keyword absent or present

@trikadin if you still need this feature and have time to do it I would really appreciate it.


Fixes #2239 Update build dependencies.

Fixes #2239 Update build dependencies.
Also simplifies nuget package management so we shouldn't have to clean up so often.

Will I still need to delete the packages folder when switching between 2015 and 2017?  I was confused when I was getting newtonsoft json dll load errors in unit tests, then realized that the last time I had fetched packages was using the "other" version of VS, so I was building against the wrong newtonsoft.  Not a problem when running the product as VS redirects to the correct newtonsoft, but the unit tests don't do that.

You can install into packages.14.0 and packages.15.0 and those directories will be preferred by the build files.

👍


[5.7][CSSimplify] Don't attempt to synthesize ~= for optional base types

Cherry-pick of https://github.com/apple/swift/pull/58531

EnumElement patterns with optional base type do member lookup
on both optional type and its wrapped type but do not synthesize
~= operator call.
Resolves: rdar://92327807
(cherry picked from commit f0ba1a859a99e5c5443878e218324fc555bdb9a1)

@swift-ci please test


erro in generateCountMatrix

Hi Aeron Group,
I was using Aeron to detect fusion transcrits in Nanopore transcriptome data, after the graph building, I ran  the command "snakemake --cores 10 all ", but encountered some difficulties beblow, in generateCountMatrix,
rule generateCountMatrix:
input: output/matrix_CPD1906270733_transcripts_Genome_all.txt
output: output/CountMatrix_CPD1906270733_transcripts_Genome.txt
jobid: 7
benchmark: benchmark/generateCount_CPD1906270733_transcripts_Genome.txt
wildcards: reads=CPD1906270733, transcripts=transcripts, graph=Genome
Traceback (most recent call last):
File "/share/apps/biosoft/fushion/Aeron/AeronScripts/ThreePrime.py", line 24, in
if(float(ent[-2])>0.2):
ValueError: could not convert string to float: 'ENST00000391753.6'
First, I opened the file "output/matrix_CPD1906270733_transcripts_Genome_all.txt", its format was as follows:
408:1122|554f1097-d17d-4c0d-9fd9-c6bd9fe9ede1   ENST00000391753.6       0.949153
408:1122|554f1097-d17d-4c0d-9fd9-c6bd9fe9ede1   ENST00000302907.9       0.983051
408:1122|554f1097-d17d-4c0d-9fd9-c6bd9fe9ede1   ENST00000610644.4       0.960452
there were three columns, first column was Nanopore reads, second was Ensemble transcripts ID, and was the third an indentity score? It's just my guess.
and then I opened the scripts "ThreePrime.py",
for line in m:
ent=line.rstrip().split("\t")
if(float(ent[-2])>0.2):
if(ent[0] != nam):
max=0
mt[ent[0]]=""
if(float(ent[-2])>max):
mt[ent[0]]=[]
tran=ent[1].split(".")[0]
mt[ent[0]] = tran
mt1[ent[0]] = float(ent[-1])
nam=ent[0]
max=float(ent[-2])
elif(float(ent[-1])==max):
tran=ent[1].split(".")[0]
if(float(ent[-1])<float(mt1[ent[0]])):
mt[ent[0]] = tran
mt1[ent[0]] = float(ent[-1])
else:
tmp="Hello"
My question was why using [-2] and [-1] in the scripsts, and whether the file "output/matrix_CPD1906270733_transcripts_Genome_all.txt" was correct ?
Please help me solve this problem, thanks.

Dear user,
I apologise for the late reply. It seems that you are using an older version of the pipeline. We restructured certain programs. Can you please let me know when did you last pull the changes
regards
Dilip A Durai

Dear user,
I apologise for the late reply. It seems that you are using an older version of the pipeline. We restructured certain programs. Can you please let me know when did you last pull the changes
regards
Dilip A Durai

Hi,
I am running into the same error after pulling changes on 28th Feb.
Regards,
Areeba.


Support promise-like results for the onBeforeSend callback

dx-sample.zip
Currently onBeforeSend operates synchronously. It would be useful to make it asynchronous
to support access token that may come from a web service.
let ds = createStore({
    onBeforeSend: async (method, ajaxOptions) => {
          let token = await getAuthToken();
           ajaxOptions.headers = {
                   'Authorization': token
          };
     },
})

Related SC tickets:
T875384

Related: #425


added browse in dde

Signed-off-by: Aditya Chatterjee<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Codecov Report

Merging #5343 (6bed587) into master (41daef0) will decrease coverage by 4.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5343      +/-   ##
==========================================
- Coverage   17.35%   13.16%   -4.20%
==========================================
  Files         107      107
  Lines        9864     9882      +18
==========================================
- Hits         1712     1301     -411
- Misses       7731     8304     +573
+ Partials      421      277     -144

Flag
Coverage Δ

gointegrationtests
?

unittests
13.16% <ø> (+0.12%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-58.95%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.88% <0.00%> (-55.19%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.14% <0.00%> (-55.18%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.92% <0.00%> (-48.08%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.15% <0.00%> (-44.61%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.26% <0.00%> (-36.96%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.03% <0.00%> (-23.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/dashboard.go
1.70% <0.00%> (-9.41%)
:arrow_down:

mesheryctl/pkg/utils/healthcheck.go
8.82% <0.00%> (-4.42%)
:arrow_down:

mesheryctl/internal/cli/root/perf/result.go
72.72% <0.00%> (+1.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3282b...6bed587. Read the comment docs.


In html5 mode $urlRouterProvider.rule() is ignored unless at least one ui-sref appears

I prefer to use ... rather than ..., so that I can mix state changes with real page (re)loads.
I then use $urlRouterProvider.rule(function($injector, $location) {...}) to check the current $location.path() and depending on that URL, make a state transition or load a different page.
This works fine so far, but only if there is at least one ui-sref directive in my HTML, say

. This is somehow weird, because that directive is not good for anything.
Does adding that dummy directive to my HTML code, trigger some kind of initialization code during HTML compilation?

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


[stable/nginx-ingress]: Allow custom HTTP/HTTPS ports to be specified

What this PR does / why we need it:
This allows specifying an arbitrary list of ports/protocols for the ingress to listen on.
Which issue this PR fixes

Fixes #12653 -- I think. It was not designed specifically as a fix for that issue but it does seem to address it.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign
Thanks for the PR. What is the use case here? Would https://github.com/helm/charts/pull/13096 address it?

@ChiefAlexander I've recently ran into a similar issue that this PR resolves,
In the current helm template you can't really assign your own port mappings to the loadbalancer service.
In the current template you can add ports via the tcp/udp values however it doesn't let you specify the port targets so if you add 8080 for example it can only point to 8080 and you can't change it.
This PR allows you to specify all the values for the port mappings.

That makes sense, thanks for the explanation. This PR needs to have its conflicts fixed and the version updated before we can merge it in.
/ok-to-test


Update tor version to <IP_ADDRESS>

In the new version of the tor project, anti DOS protection has been implemented see: https://community.torproject.org/onion-services/advanced/dos/
This is an essential feature
Great project thanks for keeping it going

Thanks for your contribution @MaticPoh!

Hi @MaticPoh, I've noticed some issues with the PR:

tor-<IP_ADDRESS> is not available in Alpine 3.17.3. This makes the quick build fail; so we need to bump Alpine version too.
pow is not enabled when building from source; as per the Tor docs, we need to add --enable-gpl to the configure script.

I got it fixed already; will update this PR when my local multi-arch build finishes (this takes some time)

Hi @MaticPoh, I don't have edit permissions on your branch so I cannot update this PR myself. I've pushed my changes to https://github.com/bugfest/tor-docker/tree/pr6; would you please rebase/update this PR with my pr6 branch commits?
Thanks!

I merged it with your branch and gave it permission to edit

Thanks @MaticPoh, PR merged 🎉 !

Build is underway https://github.com/bugfest/tor-docker/actions/runs/6723583571


No Actions specify more than one object, but "capabilities" in authorization field is plural.

A capability designates the object and the permission being authorized on that object.  The method in the descriptor field specifies a single operation, and all allowed Actions take a single argument.  Hence, there should be only one capability in the authorization field.
The kid field allows for only a single key, but it should be possible to issue each capability to a different key.  As long as only one capability can be specified, a single key suffices.
Also, since the capability necessarily designates the object, it can be used in place of the objectId in the descriptor.  Each capability should authorize a single permission, so the capability can also be used instead of the method field in the descriptor field.

@alanhkarp Actions were taken out of the DWN spec. Motion to close this now given the lack of relevancy with the current spec.

Sounds reasonable.


ci: update CI process

Apologies for the delay in getting this in, I got busy. This is the PR we discussed
over reddit.
This makes changes to CI and testing for this repo.

Moves to using Nox to test on multiple python version (3.7, 3.8. 3.9. 3.10). This is configured via noxfile.py
Adds pre-commit hooks (.pre-commit-config.yaml) to do linting and testing of code at commit time
Uses pytest-cov to gather coverage info for the repo and upload it to codecov.io
Adds flake8 linting
Adds bandit security scanning
Adds safety dependency scanning
Adds dependabot dependency updates and alerts and a GHA workflow to automatically merge dependabot PRs that pass CI.
Adds a GHA workflow to manage releases using release-please and conventional commits (release-please.yml)
Adds a GHA workflow to upload releases to pypi automatically (release.yml)
Adds a GHA workflow to manage repo settings (repo-manager.yml)
Documents how to use some of these new features in CONTRIBUTING.rst and other docs.\

I know this is a ton of change, so I'm happy to discuss it/demo more or make changes as
you'd like.
From your side, the only thing you'll have to do is setup the secrets mentioned in
.github/README.md on the repo and all the CI should work as expected
The biggest changes for you in doing development would be:

you need python 3.7, 3.8, 3.9, and 3.10 available for testing with nox. I suggest pyenv
You can still run tests with pytest, but if you want to run the full test suite locally, you can run nox

After merging this PR, I'd suggest creating a new virtualenv using pyenv and setting up all the requirements from scratch

The result of the GHA runs can be seen in my fork here https://github.com/andrewthetechie/ducks/actions/runs/3116871819

This looks amazing! Thank you for tackling all this, it's a huge peace of mind to know ducks will actually work in the various python versions especially. And a clean CI is a wonderful thing. PyPI automation's fantastic too. Got the PyPI token in already, will add the GitHub one next.
The only part I'm wary on is the repo settings manager. It's a cool project, but I'm not sure it fits here. Changing repo settings is pretty powerful; if it ever went wrong, it could potentially break things in a way I wouldn't be able to fix. How do you feel about taking that out? I'm good with merging everything else.

You're welcome, glad to help.
I've pushed a commit removing repo-manager

All right, both tokens are in and the merge is complete. :tada:


rpm: remove needless hidden file

It fixes W: hidden-file-or-dir

changed to keep .* and source code.


Reloadable Events

Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:
Added ./base/Event.js structure.
Added new reloadEvent function to ./index.js.
Added new loadModule and unloadModule functions to ./index.js
Removed loadCommand and unloadCommand functions from ./index.js
Removed getSlashCommands and getCommands functions from ./index.js
Modified ./index.js to include new event loader.
Modified ./events/error.js to include new Event structure.
Modified ./commands/system/reload.js to support the new loadModule and unloadModule functions.
Modified ./events/interactionCreate.js to include new Event structure.
Modified ./events/ready.js to include new Event structure.
Moved ./events/guildCreate.js to ./events/guild/guildCreate.js and modified it to include new Event structure.
Moved ./events/guildCreate.js to ./events/guild/guildDelete.js and modified it to include new Event structure.
Moved ./events/guildMemberAdd.js to ./events/guild/guildMemberAdd.js and modified it to include new Event structure.
Moved ./events/messageCreate.js to ./events/message/messageCreate.js and modified it to include new Event structure.
Semantic versioning classification:

[x] This PR changes the framework's interface (methods or parameters added)

[x] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to README, etc.

Until a solution has been reached regarding the ever increasing complexity of guidebot (both class and non-class) I'm going to close this PR, feel free to continue working on it until we reach a decision.


AddAsync not saved related entities

The problem that I am seeing is that AddAsync is not saving related records.  I have a One To Many relationship or RouteBatches to RoutePaths.  If I AddAsync, the related records do not get saved.  If I change it to Add then it does.  I am still calling SaveChangesAsync.
Further technical details
EF Core version: v1.1.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system:
IDE: Visual Studio 2015

Dupe of #7298.


Add not supported feature to teams-for-vdi.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9498.
@pavelgogit, could you review it? Thanks.

Learn Build status updates of commit c4fb10f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/teams-for-vdi.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dstrome
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


why there is always error "ValueError: Input Pipeline definition must have a class property."

here is my config.yml
model: BasicSeq2Seq
model_params:
bridge.class: seq2seq.models.bridges.InitialStateBridge
embedding.dim: 1024
encoder.class: seq2seq.encoders.UnidirectionalRNNEncoder
encoder.params:
rnn_cell:
cell_class: BasicLSTMCell
cell_params:
num_units: 512
dropout_input_keep_prob: 0.8
dropout_output_keep_prob: 1.0
num_layers: 1
decoder.class: seq2seq.decoders.BasicDecoder
decoder.params:
rnn_cell:
cell_class: BasicLSTMCell
cell_params:
num_units: 512
dropout_input_keep_prob: 0.8
dropout_output_keep_prob: 1.0
num_layers: 1
optimizer.name: Adam
optimizer.learning_rate: 0.0001
source.max_seq_len: 83
source.reverse: false
target.max_seq_len: 95
vocab_source: ./data/vocab_post_50000
vocab_target: ./data/vocab_comt_50000
input_pipeline_train:
class: ParallelTextInputPipeline
params:
source_files: ['./data/post_50000']
target_files: ['./data/comt_50000']
batch_size: 64
train_steps: 1000
output_dir: ./model/50000
when I use the command below to run the model and there is always an error: "ValueError: Input Pipeline definition must have a class property"
python3 -m bin.train --config_paths="./myconfig/config_50000.yml,./myconfig/train_seq2seq.yml"

I think the problem here is that you are not passing the input_pipeline_dev argument, which is required. Ideally you should always have a validation set ;)
It's probably a good idea to throw a better error message and to make the development data optional. Will do that.
Thanks for reporting.

Unfortunately the Tensorflow Experiment class does not allow you to disable evaluation, so you need to pass an input_pipeline_dev. I at least updated the code to throw a better error message though.

Thanks for your kindly reply! @dennybritz

Same problem. Thank you.

@dennybritz  i am having the same problem but i am using both dev data as well as train set.
config.yml
`model: AttentionSeq2seq
model params:
vocab_source: ${HOME}/nil/beam/seq2seq/tmp/vocab.50k.bpe.32000.en
vocab_target: ${HOME}/nil/beam/seq2seq/tmp/vocab.50k.bpe.32000.hi
input_pipeline_train:
input_pipeline_train:
class: ParallelTextInputPipeline
params:
- source_files: ${HOME}/nil/beam/seq2seq/tmp/test.bpe.32000.en
- target_files: ${HOME}/nil/beam/seq2seq/tmp/test.bpe.32000.hi
input_pipeline_dev:
class: ParallelTextInputPipeline
params:
- source_files: ${HOME}/nil/beam/seq2seq/tmp/IITB.en-hi.bpe.32000.en
- target_files: ${HOME}/nil/beam/seq2seq/tmp/IITB.en-hi.bpe.32000.hi
train_steps: ${HOME}/nil/beam/seq2seq/tmp/train
output_dir: ${HOME}/nil/beam/seq2seq/tmp/model
'
beam.yml
model: AttentionSeq2Seq
model_params:
attention.class: seq2seq.decoders.attention.AttentionLayerBahdanau
attention.params:
num_units: 512
bridge.class: seq2seq.models.bridges.ZeroBridge
embedding.dim: 512
encoder.class: seq2seq.encoders.BidirectionalRNNEncoder
encoder.params:
rnn_cell:
cell_class: GRUCell
cell_params:
num_units: 512
dropout_input_keep_prob: 0.8
dropout_output_keep_prob: 1.0
num_layers: 2
decoder.class: seq2seq.decoders.BeamSearchDecoder
decoder.params:
rnn_cell:
cell_class: GRUCell
cell_params:
num_units: 512
dropout_input_keep_prob: 0.8
dropout_output_keep_prob: 1.0
num_layers: 2
optimizer.name: Adam
optimizer.params:
epsilon: 0.0000008
optimizer.learning_rate: 0.0001
source.max_seq_len: 50
source.reverse: false
target.max_seq_len: 50
training the set: python -m bin.train  --config_paths="./example_configs/beam.yml,example_configs/train_seq2seq.yml,./config.yml"


aws-cloudfront needs love

We should redesign the API for the aws-cloudfront construct library. There's a lot we can do in order to make it friendlier, less error-prone and less flat and declarative. At the moment, it's basically "leaking" the low level API provided by CloudFormation.
Furthermore, it would be awesome if one could use Assets to point to a local directory that includes the web distribution content and have the toolkit do the work of uploading it to S3 and all that.

At a minimum I would recommend making the Cloudfront construct aware of other constructs such as:

elb.LoadBalancer
elbv2.ApplicationLoadBalancer
elbv2.NetworkLoadBalancer
apiGateway.LambdaRestApi
ecs.LoadBalancedFargateService (add the LB created by this construct)
ecs.LoadBalancedEc2Service (add the LB created by this construct)
ecs.FargateService and ecs.Ec2Service (lookup the attached LB)
s3.Bucket

CloudFront construct should be aware of how to get the domain name / address and potentially even the port from each construct and auto configure the origin details
I imagine an interface like:
const dist = new cloudfront.CloudFrontWebDistribution(this, 'WebsiteDistribution');

const ecsOrigin = dist.addOrigin(this, {
   target: myEcsServiceConstruct,
   port: 3000
});

const apiOrigin = dist.addOrigin(this, {
   target: myApiGatewayConstruct
});

dist.addBehavior(this, {
   path: '*',
   origin: ecsOrigin
   default: true
});

dist.addBehavior(this, {
   path: 'api*',
   origin: apiOrigin
   default: true
});

Hi @eladb, @PaulMaddox, @mindstorms6, @nathanpeck
I'm trying to add policy statements to my bucket, but it fails with the message Invalid principal in policy.
Any hint on how to reference the OID arn correctly?
    const originAccessIdentity = new cloudfront.CfnCloudFrontOriginAccessIdentity(
      this,
      'PublicSiteOAI',
      {
        cloudFrontOriginAccessIdentityConfig: {
          comment: 'OAI for adac-public-site-bucket'
        }
      }
    );

    const bucket = new s3.Bucket(this, 'Bucket', {
      blockPublicAccess: s3.BlockPublicAccess.BlockAll,
      bucketName: 'public-site-bucket'
    });

    const distribution = new cloudfront.CloudFrontWebDistribution(
      this,
      'Cloudfront',
      {
        comment: 'Public Site Cloudfront',
        originConfigs: [
          {
            behaviors: [{ isDefaultBehavior: true }],
            s3OriginSource: {
              originAccessIdentity,
              s3BucketSource: bucket
            }
          }
        ]
      }
    );

    const listBucketPolicy = new iam.PolicyStatement()
      .addAction('s3:ListBucket')
      .allow()
      .addResource(`arn:aws:s3:::${distribution.domainName}`)
      .addAwsPrincipal(originAccessIdentity.cloudFrontOriginAccessIdentityId);
    listBucketPolicy.sid = 'bucket_policy_site_root';
    bucket.addToResourcePolicy(listBucketPolicy);

    const getObjectPolicy = new iam.PolicyStatement()
      .addAction('s3:GetObject')
      .allow()
      .addResource(`arn:aws:s3:::${distribution.domainName}/*`)
      .addAwsPrincipal(originAccessIdentity.cloudFrontOriginAccessIdentityId);
    getObjectPolicy.sid = 'bucket_policy_site_all';
    bucket.addToResourcePolicy(getObjectPolicy);


fix(personality): Fix types for personality constants

First of all, thanks for these bindings!
I noticed this while working on some higher-level (nix) bindings for personality(2): these constants are passed to personality(2), which takes a c_ulong. Thus, these should also be c_ulongs, rather than c_int.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

You're right, sorry for the trouble!
I'd follow this but it's a breaking change, let's make some period before changing actually:

Add a deprecation notice like #[deprecated(note = "This type is defined as c_int by mistake. We will change it to c_ulong in the future release")] so that the users know it.
After some releases, change the type.

cc @nbaksalyar as you introduced these consts.

No worries! On closer inspection, it might actually be reasonable: personality(2) takes a c_ulong but returns a c_int. Moreover the return value of personality(2) (when it isn't an error) is specified to be the previous persona, meaning that all personality values need to fit into c_int and that it's an equally valid type choice.
I'm interested in hearing what @nbaksalyar thinks, but I'd personally be okay with the current signatures in light of the above 🙂

I'm gonna go ahead and close this, since I've convinced myself that the current types are correct.


Use docker caches to speed up multiarch builds

This imports a build cache from the docker registry when building images for release. After the build, it tries to export a build cache for each platform to the registry.
TL;DR: no cache or update sqlite3 (1:08:29), update src only (36:16), update dependency (46:25)
The build will try to cache from the registry first. If that fails, it will build from the local build cache and takeover at the step that the previous build failed. If that fails, the image will be built from scratch with no cache. This way a valid build will always be built.
I separated the cache export to its own step because the connection to the registry fails intermittently. I also allowed the cache export to fail without cancelling the whole workflow. The caches have to be separated by platform because the manifest list for build caches doesn't work with multiple platforms.
The Dockerfile now has an optional stage dedicated to building sqlite3. Architectures other than amd64 must compile it from source which takes ~20 minutes for the arm platforms. Since the sqlite3 version will change much less frequently than the rest of the dependencies, the sqlite3-builder stage will be built only when the version changes. By default, the docker build will not use sqlite3-builder. You must set the build argument CACHE=cache to enable it. You can also set the version of sqlite3 installed with SQLITE3_VERSION. It is highly recommended to enable BuildKit when building.
For example:
DOCKER_BUILDKIT=1 docker build .

or, to use the sqlite3 builder with the version taken from package.json:
DOCKER_BUILDKIT=1 docker build --build-arg CACHE=cache --build-arg SQLITE3_VERSION=$(cat package.json | jq -r '.dependencies.sqlite3') .

This really complicates the whole build-step and I definitely need some more time in order to completely understand what is going on.
Another solution might be building and publishing the binaries once with https://github.com/mapbox/node-pre-gyp and store them on GitHub Releases, given that we could adjust https://github.com/mapbox/node-sqlite3/blob/master/package.json#L10-L19? (npm install with --ignore-scripts, run patch-package for adjusting the package.json of sqlite3 and then running the sqlite3 build script manually?
https://github.com/mapbox/node-pre-gyp#1-add-new-entries-to-your-packagejson

Another solution might be building and publishing the binaries once with https://github.com/mapbox/node-pre-gyp and store them on GitHub Releases, given that we could adjust https://github.com/mapbox/node-sqlite3/blob/master/package.json#L10-L19? (npm install with --ignore-scripts, run patch-package for adjusting the package.json of sqlite3 and then running the sqlite3 build script manually?
https://github.com/mapbox/node-pre-gyp#1-add-new-entries-to-your-packagejson

I considered building base images in docker with sqlite3 compiled on them, but it seemed more complicated in the moment, especially when trying to detect when a new version needed to be compiled.
I like the idea of storing the binaries themselves. I think defining a job at the very beginning to build new binaries based on the version in package.json would be easier. If you could show me an example of how to compile our own version of sqlite3 and use it on our project, then I can fit it into our workflow.

I'm going to close this in favor of #430. We can address the sqlite3 binary packages in a future PR.


Kirby KQL

Can't for the life of me seem to be able to get this to work over KQL. Any ideas how? I can see you've contemplated KQL in your code. I've added your methods to config KQL allowed. Everything works fine on the Kirby frontend.
Have tried a bunch of options, including among others:
async function getBluryPlaceholder(uuid) {
  const query = {
    query: `file('${uuid}').placeholderUri`
  };
  let data = await fetchKirbyQuery(query);

  return data;
}

and
async function getBluryPlaceholder(uuid) {
  const query = {
    query: `site.file('${uuid}').placeholderUri`
  };
  let data = await fetchKirbyQuery(query);

  return data;
}

FYI fetchKirbyQuery() is:
export async function fetchKirbyQuery(query) {
  const api = process.env.API_KQL;
  const user = process.env.KIRBY_USER;
  const password = process.env.KIRBY_PASSWORD;

  // Encode username and password for Basic Auth
  const base64Credentials = Buffer.from(`${user}:${password}`).toString(
    'base64'
  );
  const headers = {
    Authorization: `Basic ${base64Credentials}`,
    'Content-Type': 'application/json',
    Accept: 'application/json'
  };

  let response;
  try {
    response = await fetch(api, {
      method: 'POST',
      body: JSON.stringify(query),
      headers,
      // cache: 'force-cache',
      next: { revalidate: 10 }
    });

    if (!response.ok) {
      const errorText = await response.text(); // Get response text for detailed error
      console.error('HTTP error response text:', errorText); // Log the detailed error
      throw new Error(
        `HTTP error! status: ${response.status}, message: ${errorText}`
      );
    }

    const json = await response.json();

    // Assuming the structure of the JSON response is as described in the Axios version comment
    const result = json.result;

    return result;
  } catch (error) {
    console.error('fetchKirbyQuery error:', error); // Improved error logging
    throw error; // Re-throw the error after logging it
  }
}

My guess is that your query is incorrect. You need to use the select field to query model values. It should be something as follows:
const query = {
  query: "site.images.first",
  select: {
    url: true,
    hash: "file.placeholderUri",
  }
}

By the way, to save you from writing a lot of custom KQL fetching logic, you could use Nuxt KQL if you use a frontend meta-framework.

Thanks for quick response!
Weird – your query works but if I find the image by it's uuid it doesn't work:
Doesn't Work (only if "hash: 'file.placeholderUri'" used)
async function getData(uuid) {
  const query = {
    query: `file('${uuid}')`,
    select: {
      url: true,
      alt: true,
      width: true,
      height: true,
      hash: 'file.placeholderUri'
    }
  };
  let data = await fetchKirbyQuery(query);

  return data;
}

Weirdly returns this: Error: HTTP error! status: 500, message: {"status":"error","message":"imagecreatefromstring(): No JPEG support in this PHP build","code":2,"key":null,"details":[]}
Works
async function getBluryPlaceholder(uuid) {
  const query = {
    query: 'site.images.first'

  };
  let data = await fetchKirbyQuery(query);

  return data;
}

I would use Nuxt KQL but am on Next.js!

No JPEG support in this PHP build

Seems like a PHP extension is missing. The origin of the issue on your PHP setup, not the plugin's side. 🙂


FYI - schema.rdfs.org publishes schemas in JSON format

http://schema.rdfs.org/
http://schema.rdfs.org/all.json

The page is sadly not maintained anymore. If needed we scrape Schema.org every day and offer a download possibility at:
http://schema.link.fish
http://schema.link.fish/downloads/all.json
http://schema.link.fish/downloads/all.json.gz (same but gzip)

@janober neat! Do you use this library to do the scraping?

No have to confess I did use the one of http://schema.rdfs.org/:
https://github.com/mhausenblas/schema-org-rdf/tree/master/scrapers
They were the first I found some time ago. This library I just found today.
Does this library still work or did it also break with the changes to the schema.org website?

Might have broken, but I know that @rektide is currently using it.

@janober cool to know about http://schema.link.fish/downloads/all.json !
Without any official json sources for schema.org do you intend to keep this one around as the best alternative?

Yes that is the idea. I need the data and so would have to parse it regularly anyway so it is there to stay.

@janober That's good to know thanks.
Any reason why datatypes isn't avail on the file?

@gebrits Sorry there was something wrong in the parse script. Did fix it and now also the datatypes are back.

cheers @janober :+1:

hi @janober Sorry to bother but supertypes-property seems to be broken on a couple of instances.
More specifically any subtype of CreativeWork seems to have a supertypes = [] , while they should list  supertypes = ["CreativeWork"] instead.

Ah yes thanks, you are right. The new page-structure is really not great for extracting information. However I made some changes and all the ones I checked seem now to be fine.
Please tell me if you find any other issues.

Are you using the released schema.org version (at http://schema.org) or some develop-branch?
I'm asking because the latest json misses a couple of properties which are avail on the released schema.org. This is not exhaustive (since I'm only checking for the ones we're using), but at least these properties are missing:
branchCode,containedInPlace,containsPlace,screenCount,iataCode,icaoCode,character,commentCount,hasPart,license,countryOfOrigin,composer,iswcCode,lyricist,recordedAs,isrcCode,recordingOf,catalogNumber,creditedTo,recordLabel,releaseOf,containsSeason,dissolutionDate,parentOrganization,sport,athlete,coach

Ehm, all of them can be found under "properties" (at least the first few and the last one, the other ones I did not check because I also expect them to be there)

Hmm sorry about that. Sublime apparently choked on the file. All good now

No problem, great to hear ;-)

@jaygray0919 Saw in the other thread that you were wondering how the file gets generated.
The original scrape-script can be found here:
https://github.com/mhausenblas/schema-org-rdf
sadly did it not work anymore because the website changed. So all I did is to fix it. The fixed version can be found in my fork here:
https://github.com/janober/schema-org-rdf
That script got originally used by this website: http://schema.rdfs.org
However they stopped supporting it and for that reason is file they offer for download very old. So because we need the data for our site link.fish anyway I simply decided to take over for schema.rdfs.org and offer the scraped schema.org data for download.
Everything is also described on: http://schema.link.fish

Apologies for being pedantic but, do either of the mentioned JSON extracts conform to JSON-Schema (http://json-schema.org)?


refactor: unwanted internal server errors

Checklist

[x] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[x] I have added tests to cover my changes.
[x] I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

closes #3240
Screenshots (if appropriate):

This change is

@istae @vladopajic @mrekucci  ci errs unrelated to pr


We need a suffix utility function for this

tbh, I can't recall what gave birth to this usse.


http mutation filter: fix possbile illegal memory access when the req…

…uest is reset before request headers are completely received
Commit Message: http mutation filter: fix possbile illegal memory access when the request is reset before request headers are completely received
Additional Description:
See comments in the code.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.

cc @botengyao

/retest


feat: functional battle components

User description

adds fix for overflows when starting a battle
Adds possibility to attack an army when on the same hex

PR Type
Enhancement, Bug fix

Description

Added battle_start system call in createSystemCalls.ts.
Created useBattles hook to fetch battle entities.
Adjusted troop count calculations and added overflow handling in ArmyManagementCard.tsx.
Added attackable condition check and integrated AttackOrPillageLabel component in Army.tsx.
Created AttackOrPillageLabel component for attack actions.
Handled undefined entityId in StaminaResource.tsx.
Updated contract class hashes and changed data types for troop attributes in manifest files.
Adjusted health and strength calculations and data types in combat.cairo.
Changed data types for troop attributes in config.cairo.
Adjusted percentage calculation functions and data types in math.cairo.

Changes walkthrough 📝
Relevant filesEnhancement
10 files

createSystemCalls.tsAdd battle start system call and fix formatting.

client/src/dojo/createSystemCalls.ts

Added battle_start system call.
Fixed formatting issues.

+14/-8

useBattles.tsxCreate useBattles hook for fetching battle entities.

client/src/hooks/helpers/useBattles.tsx

Created useBattles hook to fetch battle entities.

+23/-0

Army.tsxAdd attackable condition and integrate AttackOrPillageLabel.

client/src/ui/components/worldmap/armies/Army.tsx
Added attackable condition check.  Integrated AttackOrPillageLabel component.

+17/-1

AttackOrPillageLabel.tsxCreate AttackOrPillageLabel component for attack actions.

client/src/ui/components/worldmap/armies/AttackOrPillageLabel.tsx

Created AttackOrPillageLabel component for attack actions.

+32/-0

global.tsAdd U32_MAX constant.

sdk/packages/eternum/src/constants/global.ts

Added U32_MAX constant.

+2/-0

manifest.jsonUpdate contract class hashes and troop attribute types.

contracts/manifests/dev/manifest.json
Updated contract class hashes.  Changed data types for troop attributes.

+30/-270

manifest.tomlUpdate contract class hashes and troop attribute types.

contracts/manifests/dev/manifest.toml
Updated contract class hashes.  Changed data types for troop attributes.

+14/-36

combat.cairoAdjust health and strength calculations and data types.

contracts/src/models/combat.cairo
Adjusted health and strength calculations.  Changed data types for troop attributes.

+38/-29

config.cairoChange data types for troop attributes.

contracts/src/models/config.cairo

Changed data types for troop attributes.

+8/-8

math.cairoAdjust percentage calculation functions and data types.

contracts/src/utils/math.cairo
Adjusted percentage calculation functions.  Changed data types for percentage values.

+7/-7

Bug fix
2 files

ArmyManagementCard.tsxAdjust troop count calculations and handle overflow.

client/src/ui/components/military/ArmyManagementCard.tsx
Adjusted troop count calculations.  Added overflow handling for troop counts.

+5/-6

StaminaResource.tsxHandle undefined entityId in StaminaResource.

client/src/ui/elements/StaminaResource.tsx

Handled undefined entityId in StaminaResource.

+4/-4

Formatting
1 files

BaseThreeTooltip.tsxFix formatting in BaseThreeTooltip component.

client/src/ui/elements/BaseThreeTooltip.tsx

Fixed formatting issue.

+1/-1

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Still todo:

[ ] battle_claim structure after winning battle. This will claim the structure
[ ] battle_pillage pillages the spoils of a battle
[ ] battle_leave allows an army to leave the battle
[ ] Reinforcements modal. This should allow users to add their armies to the battle this will use battle_join


Octal Literral error

throw new Error(Parse failure: ${err.message}\nAt file: ${url}\nContents of line ${line}: ${code.split('\n')[line - 1]});
^
Error: Parse failure: Octal literal in strict mode (3:13)
This part is for Docker

~/Dev/whatsapp-chatgpt3  on main !2 ?1  docker-compose up                              ok  took 48s
[+] Running 15/1
✔ whatsapp-chatgpt 14 layers [⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿⣿]      0B/0B      Pulled                          139.5s
[+] Building 0.0s (0/0)
[+] Running 2/2
✔ Network whatsapp-chatgpt3_default               Create...                                     0.1s
✔ Container whatsapp-chatgpt3-whatsapp-chatgpt-1  Created                                       0.2s
Attaching to whatsapp-chatgpt3-whatsapp-chatgpt-1
whatsapp-chatgpt3-whatsapp-chatgpt-1  |
whatsapp-chatgpt3-whatsapp-chatgpt-1  | ><EMAIL_ADDRESS>start
whatsapp-chatgpt3-whatsapp-chatgpt-1  | > npx vite-node src/index.ts
whatsapp-chatgpt3-whatsapp-chatgpt-1  |
whatsapp-chatgpt3-whatsapp-chatgpt-1  | file:///app/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:53776
whatsapp-chatgpt3-whatsapp-chatgpt-1  |         throw new Error(Parse failure: ${err.message}\nAt file: ${url}\nContents of line ${line}: ${code.split('\n')[line - 1]});
whatsapp-chatgpt3-whatsapp-chatgpt-1  |               ^
whatsapp-chatgpt3-whatsapp-chatgpt-1  |
whatsapp-chatgpt3-whatsapp-chatgpt-1  | Error: Parse failure: Octal literal in strict mode (3:13)
whatsapp-chatgpt3-whatsapp-chatgpt-1  | At file: /app/node_modules/qrcode-terminal/lib/main.js
whatsapp-chatgpt3-whatsapp-chatgpt-1  | Contents of line 3:     black = "\033[40m  \033[0m",
whatsapp-chatgpt3-whatsapp-chatgpt-1  |     at ssrTransformScript (file:///app/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:53776:15)

I have tested on Node, 16,18, and 19
Also, used with docker. Got same response
MacOS

Sorry for the inconvenience!
If problem is persist in this repo. Please check this link given below

Which link please


LOL it does not work...

when i have already putted in the url and the webhook it does not grab any thing and ya the webhook works

brain issue


feat: handle notification for progress report

For example, when doing renaming...

You already done the work, but there is already a spec for reporting progress.
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workDoneProgress
Pyright should probably follow the spec, instead of creating a custom report notification.

You could probably use ActivityIndicator for now and then switch to common API once something is added to lsp_utils.

I don't like ActivityIndicator from sublime_lib because it creates a thread... For such short activities, we shouldn't use threads :-)

I have probably around 10 unused threads on my machine. What else should I use them for if not for activity indicators? ;)
It would be better if it used sublime's async thread though.

Yes. That's an entire program stack, thread local variables, and a file descriptor allocated just to see a moving = sign.


tmt clean (virtual)guests doesn't work well with --workdir-root cli opt

If users specify a  workdir-root different from  TMT_WORKDIR_ROOT  ,clean guests will fail,
that's because virtual plugin doesn't accept and apply cli_opts
dev) lnie@fedora:~/tmt$ echo $TMT_WORKDIR_ROOT
/var/tmp/tmt
(dev) lnie@fedora:~/tmt$  tmt clean guests -vvdd --workdir-root /var/tmp/test
clean
guests
Using tree '/home/lnie/tmt'.
Workdir '/var/tmp/test/run-001' already exists.
Read file '/var/tmp/test/run-001/run.yaml'.
Workdir '/var/tmp/test/run-001/plans/testcloud' already exists.
Create the data directory '/var/tmp/test/run-001/plans/testcloud/data'.
Create the environment file '/var/tmp/test/run-001/plans/testcloud/data/variables.env'.
Workdir '/var/tmp/test/run-001/plans/testcloud/discover' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/discover/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.discover.shell' already imported.
status: done
Read file '/var/tmp/test/run-001/plans/testcloud/discover/tests.yaml'.
Workdir '/var/tmp/test/run-001/plans/testcloud/provision' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/provision/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.provision.testcloud' already imported.
status: done
Read file '/var/tmp/test/run-001/plans/testcloud/provision/guests.yaml'.
Module 'tmt.steps.provision.testcloud' already imported.
Workdir '/var/tmp/test/run-001/plans/testcloud/prepare' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/prepare/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.prepare.install' already imported.
Module 'tmt.steps.prepare.shell' already imported.
status: todo
Workdir '/var/tmp/test/run-001/plans/testcloud/execute' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/execute/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.execute.internal' already imported.
status: todo
Read file '/var/tmp/test/run-001/plans/testcloud/execute/results.yaml'.
Workdir '/var/tmp/test/run-001/plans/testcloud/report' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/report/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.report.display' already imported.
status: todo
Workdir '/var/tmp/test/run-001/plans/testcloud/finish' already exists.
Read file '/var/tmp/test/run-001/plans/testcloud/finish/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.finish.shell' already imported.
status: todo
Read file '/var/tmp/test/run-001/plans/testcloud/provision/step.yaml'.
Successfully loaded step data.
Module 'tmt.steps.provision.testcloud' already imported.
Read file '/var/tmp/test/run-001/plans/testcloud/provision/guests.yaml'.
Module 'tmt.steps.provision.testcloud' already imported.
Step is done, not touching its data.
Using the 'ProvisionTestcloud' plugin for the 'virtual' method.
step is done, not overwriting plugin data
Waking up testcloud instance 'tmt-001-uduSmlAv'.
testcloud version: 0.9.12
Provision wake up complete (already done before).
Stopping guests in run '/var/tmp/test/run-001' plan '/plans/testcloud'.
finish
workdir: /var/tmp/test/run-001/plans/testcloud/finish
        Stopping testcloud instance 'tmt-001-uduSmlAv'.
        guest: stopped
        Removing testcloud instance 'tmt-001-uduSmlAv'.

warn: Could not stop guest in run '/var/tmp/test/run-001': Failed to remove testcloud instance: [Errno 2] No such file or directory: '/var/tmp/tmt/testcloud/instances/tmt-001-uduSmlAv'.

testcloud plugin should probably follow the suite and start using effective_workdir_root()... Or, better, it shouldn't touch WORKDIR_ROOT, and it should be told what the workdir root is. Otherwise, we would need a global name for the current workdir root, resolved and set by the current command. But shared global state is a PITA in general, so I'd like to avoid that. I wonder whether we could replace tmt.steps.testcloud.TESTCLOUD_DATA with something like self.plan.workdir.parent or something like that, i.e. derive it from the plan and run itself - they should already be aware of their workdir and its root.

Or, better, it shouldn't touch WORKDIR_ROOT, and it should be told what
the workdir root is.

Nope, we need pass workdir-root to ProvisionPlugin which will affect other plugins than testcloud. Here is the merge request:#2838 for this issue^^

I disagree, that's exactly what we should not do. By the time testcloud is running, the workdir root has been already established. All inputs we taken, considered, and tmt decided which path is a workdir root. Passing workdir-root to testcloud implies all this work would be replicated there once again. Instead, what testcloud and any plugin ever interested in workdir root should do is to reach out to a place where this workdir root path would be saved. We don't have one right now, but apparently, we should add one, because re-running all the guessing in various plugins is just asking for trouble - you need to propagate all the relevant inputs to all plugins, you need to have the right code, and so on. All that when the workdir root is already known... Something took all the inputs, decided what the workdir root is, and used it to create self.workdir.
So you have two issues for the price of one:

clean not honoring --workdir-root,
the actual workdir root is not saved anywhere - we have get_effective_workdir_root() which is called two times, but the result is not saved. If any part of code needs workdir root, it needs to compute it once more.

So to me, adding this computation to testcloud would not be a good solution, it spreads the guessing to plugins, leaks command option to plugins, we want the workdir root to be saved somewhere instead, once and for all code to read. testcloud needs not to worry about --workdir-root and other inputs - the workdir root is already known, let's materialize it somewhere, and use it. My proposal would therefore to be to 1. add workdir_root where workdir is initialized, and use it in testcloud plugin to construct paths, and 2. fix clean to actually honor --workdir-root as needed, by passing the option to where the workdir root is being established.

Here is the first merge request:https://github.com/teemtee/tmt/pull/2850 ^^


refactor: use scalable project structure

Use https://github.com/bot-base/telegram-bot-template as bot structure on future major refactor

Currently, for such non-trivial project, there are no need for complex structure. Current project structure is well defined and can be changed later when it's needed


fix(tangle-dapp): Payouts reward calculation & Readme updates

Summary of changes

Updates Readme of Tangle dApp, Hubble Stats & ZK Explorer.
Fixes nominator payouts reward calculation.
Fixes actual staked percentage.

Proposed area of change

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)

Closes #2264

Screenshots

Some CI are failing here @devpavan04


Mast: Watch apnews.com/d20c6545ce7a7616279a82f48204a913

Mast requests the watch of the watch_keyword apnews\.com\/d20c6545ce7a7616279a82f48204a913. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

apnews\.com\/d20c6545ce7a7616279a82f48204a913 has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Rejected by Makyen in Charcoal HQ. Reason: 'We decided to use a different format for these. See chat.'


More descriptive error message when KDIFF is not found

When you try to generate code second time, sergen tries to run KDIFF3 to merge changes. It should give a more descriptive message. Maybe also an option to skip merge operation altogether.

Resolved with 835d6e888ddef34a4b4c0aa05f351e8728c176e6


F-Droid Build Issue

Currently the fdroid build is failing as its looking for the tag 'v1.4.17' and the most recent release has the tag '1.4.17' (without the leading v).
This can be seen here https://f-droid.org/wiki/page/org.fitchfamily.android.gsmlocation/lastbuild_63
I've been awaiting the new build as I have the new style opencellid API key and the current build on fdroid is still 1.4.14.
Would you be able to delete the tag and make a new one with the style fdroid is looking for?

I think I've got it tagged correctly now.

Looks good to me.  Thank you!


Tests: test properly the HMAC

fixes #7
As long as the quote of Jesus (see apdu_hmac.c#L22) is not known, we can only use the hash provided.
We cannot rely on the Pytezos sign function, as it signs the hash of the message and not the message itself.

[x] test available for ED25519
[ ] test available for SECP256K1
[ ] test available for SECP256R1
[x] test available for BIP32_ED25519

I managed to get the tests to work, but by changing the sign function. This is most probably not the right way to do it.


Improve search for common words such as make

Introduce your stance
Package search should be accessible to beginners.
Describe the issue
I've answered a beginner question, and they couldn't find gnumake.

Did you try search.nixos.org/packages?
@ RobertHensing Yes . I've writing make. The only result was ekam

It seems that they were puzzled by the cluttered list of results that comes up for make.
I propose three solutions:

Return a compact list of package names when the number of results is >1
Index the names of binaries, and assign a lot of weight to those keywords. This will probably make gnumake float to the top, and make some commands easier to find (e.g. host, mv, initdb)
Create a list of hardcoded first results to always include at the top. (might not be as easy to implement and requires more manual work. more of a last resort)

Page links
make
https://search.nixos.org/packages?channel=22.11&from=0&size=50&sort=relevance&type=packages&query=make
initdb (postgresql)
https://search.nixos.org/packages?channel=22.11&from=0&size=50&sort=relevance&type=packages&query=initdb
Additional context
Add any other context about the problem here.

[ ] I already created a Pull Request

I like idea 2. We could use nix-index for this:

after running nix-env, generate the file database with nix-index (takes about 5 minutes so this would ~double the nixpkgs import time)

note: would be nice to abort the import early in CI if the index for this revision already exists, so that we don't do ~3*10 minutes of useless computation every hour.

extract a hashmap from attribute names to commands from nix-locate --at-root --no-group --top-level /bin/ --type x --type s and merge this information into NixpkgsEntry.Derivation
use this to populate a package_commands field in the ElasticSearch backend
tell the frontend about it

Also we really need to stop exposing the reversed fields to the search, or at least give them a very low weight. I still don't know why we need them.

:+1: to use nix-index, but does nix-index works with other flakes? can we improve nix-index to also work with other flakes?

Also we really need to stop exposing the reversed fields to the search, or at least give them a very low weight. I still don't know why we need them.

This was used before the wildcard field was used (2 versions of elasticsearch back).

No, it won't work with flakes. nix-index queries Hydra for file listings from built derivations, so unless we set up a build farm for the flakes we index, won't happen (and that sounds like a bad idea).

This was used before the wildcard field was used (2 versions of elasticsearch back).

So I guess we can remove it now? (That doesn't really tell me why it was needed)

Done in https://github.com/NixOS/nixos-search/pull/610. No need to run nix-index ourselves, we can just use the channel's programs.sqlite file (which happens to be generated using nix-index since very recently but this is completely irrelevant).


[Bug] InfoWindow automatically closes when the map moves.

Description
On version 1.4.2, the InfoWindow automatically closes when the map is moved. Which is particularly annoying because when an InfoWindow is not entirely in the viewport, the map is automatically moved in order to fully show the infowindow, which means that the InfoWindow is opened then instantly closed.
Looking at it, I can see that the onClose event is triggered whenever the map is being moved.
I don't know if this is relevant, but I'm using the infowindow on an advancermarker and there are also clusters on the map.
On version 1.1.3, everything works fine. When opening the InfoWindow, it stays open. When moving the map, it stays open.
Steps to Reproduce
First case:

Add an InfoWindow to an AdvancerMarker like described in the docs https://visgl.github.io/react-google-maps/docs/api-reference/components/info-window#infowindow-attached-to-marker
Click on the InfoWindow
Move the map, the window is closed.

Second case:

Add an InfoWindow to an AdvancerMarker like described in the docs https://visgl.github.io/react-google-maps/docs/api-reference/components/info-window#infowindow-attached-to-marker
Move the map so that the marker is in a corner and there won't be enough space to display the infowindow
Click on the marker
The infowindow opens then closes instantly after map re-centering

Environment

Library version<EMAIL_ADDRESS>"1.4.2"
Google maps version: weekly
Browser and Version: Chrome latest
OS: windows 11

Logs
No response

Hi @Bcavez, thanks for taking the time to report the issue! It looks like a bug indeed. At first glance it seems that this effect (https://github.com/visgl/react-google-maps/blob/main/src/components/info-window.tsx#L175-L235) is triggered more often than it should and thus calling infowindow.close() which then triggers the onClose event. The fix should not be pretty straight forward. Maybe even just replacing useEffect with useDeepCompareEffect


Does clearBeforeRender have a Performance impact?

Hey,
Can anybody help me understand if there is a performance benefit to enabling/disabling clearBeforeRender on WebGL.
I've done some testing that would suggest a small performance boost by disabling it (on mobile devices), but it's within a margin of error so want to understand more.
Thanks,
Lewis

It might have a small benefit, but it would be negligible. The reason to change this option wouldn't be performance, but instead would be if you actually didn't want to clear the buffer before rendering.

Perfect. Thankyou for confirming 👍


Update example to reflect radius instead of accuracy

https://github.com/camaraproject/DeviceLocation/blame/f2d4115530e618c45ca8ea32fa1bcbf5c07e0fa3/code/API_definitions/location-verification.yaml#L208
Update example to reflect radius instead of accuracy

Fixed. Thanks!


fix: upgrade dependencies

:tada: This PR is included in version 6.4.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Group Layer support to arc_open()

Is your feature request related to a problem? Please describe.
arc_open() returns a NULL value when supplied with a Group Layer URL instead of returning a valid object or returning an error. fetch_layer_metadata() already works with Group Layer URLs so it shouldn't take too many changes to get this working. I expect this issue is also somewhat related to #57.
Here is a reprex showing the issue:
library(arcgislayers)
library(arcgisutils)

url <- "https://geodata.baltimorecity.gov/egis/rest/services/CitiMap/DOT_Layers/MapServer/0"

layer <- arc_open(url)

str(layer)
#>  NULL

layer_meta <- fetch_layer_metadata(httr2::request(url), token = NULL)

str(layer_meta$type)
#>  chr "Group Layer"

Created on 2023-12-12 with reprex v2.0.2
Describe the solution you'd like
arc_open() should just work with Group Layers without a hiccup. arc_select() should support selection of a layer from within the group. If the get_layer() helper function is required, this workflow should be documented within arc_select(). arc_read() (if it is added as planned) should support the selection of a layer from a group by name similar to the sheet parameter in googlesheets4::read_sheet() or openxlsx2::read_xlsx().
Additional context
For context, based on the URL handling code from {esri2sf}, there are 6 main types of services (this may not be comprehensive):

"MapServer",
"FeatureServer",
"GPServer",
"GeocodeServer",
"GeometryServer",
"ImageServer"

Feature Layers and Group Layers are two of twelve different layer types documented in this page on ArcGIS Pro (unsure if they all have web service equivalents or not).
I'd like to see Group Layers supported added in a way that provides a template for layer handling across the full range of layer types in the future.

Good catch! We can add the known classes that you've described. But I am sure there are more! They don't match up identically with Pro either 🙃