Updates/michael levan

Work in progress updates to helm chart

@AdminTurnedDevOps The change to use ReadWriteOne by default was good, thank you. That value will have to be the default for all PersistentVolumeClaims though, as now there is a mix of ReadWriteOne and ReadWriteMany values. We'll also need to have this option exposed as a value, as a fixed string of ReadWriteOne means HA clusters won't work as they all need to write to the same disk.

@AdminTurnedDevOps WRT the value names, Helm has a style guide at https://helm.sh/docs/chart_best_practices/values/#naming-conventions that provides guidance on the format. They recommend camelcase like adminUsername, so we should stick with that.

@AdminTurnedDevOps I think the issue with the values coming through as nil is that the values.yaml file is not in the same directory as the Chart.yaml file. It appears your refactoring moved Chart.yaml into the octopusdeploy directory, which made that directory the helm template directory. The values.yaml file in the project root directory is not referenced by default.

@AdminTurnedDevOps WRT to storageClassName attribute, the original logic was this:
  {{- if (eq "-" (.Values.octopus.storageClassName | toString)) }}
  storageClassName: ""
  {{- else if .Values.octopus.storageClassName }}
  storageClassName: "{{ .Values.octopus.storageClassName }}"
  {{- end }}

This says:

If .Values.octopus.storageClassName value is a dash, add the storageClassName attribute as an empty string.
If .Values.octopus.storageClassName is tuthy (i.e. a non empty string), add the storageClassName attribute as an the value of .Values.octopus.storageClassName.
If neother 1 nor 2 are true, do not add the storageClassName attribute.

This means that if the value of .Values.octopus.storageClassName is an empty string, the storageClassName is not added to the resulting yaml at all. This gives us the 3 options of empty string, value, or no storageClassName attribute at all.

@AdminTurnedDevOps The change to use ReadWriteOne by default was good, thank you. That value will have to be the default for all PersistentVolumeClaims though, as now there is a mix of ReadWriteOne and ReadWriteMany values. We'll also need to have this option exposed as a value, as a fixed string of ReadWriteOne means HA clusters won't work as they all need to write to the same disk.

Ah yep, that was my bad. Completely forgot about the other 2 resources.

@AdminTurnedDevOps WRT the value names, Helm has a style guide at https://helm.sh/docs/chart_best_practices/values/#naming-conventions that provides guidance on the format. They recommend camelcase like adminUsername, so we should stick with that.

Perfect, makes sense. I just changed them.

@AdminTurnedDevOps I think the issue with the values coming through as nil is that the values.yaml file is not in the same directory as the Chart.yaml file. It appears your refactoring moved Chart.yaml into the octopusdeploy directory, which made that directory the helm template directory. The values.yaml file in the project root directory is not referenced by default.

It appeared to be a combination of things. The first was as you said and the second was indent errors in the values.yaml


Make a utility file for BL/Spherical coordinate conversion

🐞 Problem
The title is self-explanatory.
💡 Possible solutions

Direct conversion formulas can be written
or, In order to make coder's life easy, conversions can be done using Cartesian in between. That is Spherical->Cartesian->Boyer Lindqiuist and vice versa.
Code it in the lines of utils/coord_transforms.py and
utils/bl_coord_transforms.py

📋  Steps to solve the problem

Comment below about what you've started working on.
Add, commit, push your changes
Submit a pull request and add this in comments - Addresses #118>
Ask for a review in comments section of pull request
Celebrate your contribution to this project 🎉

This issue is on hold until #121 is fixed.

Closed in #176


Images in p3 colorspace do not show up in the PiP window

FYI, we just discovered that images in P3 colorspace don't work for some reason.

SRGB Colorspace
rafi-head-rgb.pdf
P3 Colorspace
rafi-head.pdf

For anybody stumbling across this discussion, Jordi and I have identified the issue and raised it as FB10531954 and FB10531882 on Apple's feedback tracker.
The bug appears to be within the ImageRenderer which we utilise to convert the SwiftUI view to an image. Given this is new in iOS 16, I hope this will be fixed in an upcoming beta and will keep an eye on this.
In the meanwhile we have identified two possible workarounds:

Use a supported colour space/file format (PNG using RGB colour space appears to work fine)
Wrap your images in UIImage first before passing to SwiftUI: Image(uiImage: UIImage(named: "XX")!)


Falling back to default token if app token not available in build workflow

#4133  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


[docs] Demo SearchIcons crashes

[ ] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://mui.com/components/material-icons/?query=remove
??
demo SearchIcons crashes

Your Environment

Tech
Version

MUI
v5.2.5

netlify deploy
https://61c098e520eae9000736c0df--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36

Duplicate of #30304


License ?

Hello, under what license is this project released under ? Thank-you.

added license file


chore: update dependencies to remove vulnerabilities

Back to you @yokuze

I merged this, but @yokuze feel free to comment if you see anything else that needs to be addressed in a subsequent PR.

Published in +<EMAIL_ADDRESS>CC @yokuze @jimjenkins5


Collaboration instruction likely unclear.

Hi,
I did made some changes during the review stage on the newsletter, that were saved, as I could still see them across days when revisiting the page.
Though they seem to not have made it to the final version.
Mainly a description on the image, plus a few link.
also there is now this "Newsletter Jupyter ........... June15th" header which was not there before, is not the right resolution and is duplicate content for the header.
So did I miss something ?

@katiewhite360 @Ruv7 This caused me a bit of confusion as well.
Take a look at the shared draft and private notes feature. This may be preferable to allowing individual reviewers to edit directly. https://help.medium.com/hc/en-us/articles/215274128-Collaboration-tools

@Carreau your revisions were all valid - I moved the image description into the paragraph below because that image became the issue header (which isn't formatted with a caption). The reason for duplicating the header is so that the issue number and date show up in the thumbnail/preview version.
@willingc I don't think those capabilities work with the letter format, but I will double check. Sharing and editing would definitely be nice.


[main] Temporarily make SymCrypt exclusivearch x86_64

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

SymCrypt is currently failing ARM builds because Cmake cannot find clang. Mitigating by adding an ExclusiveArch.
Change Log

SymCrypt.spec: ExclusiveArch x86

Does this affect the toolchain?

NO
Associated issues

#xxxx

SymCrypt was introduced here: https://github.com/microsoft/CBL-Mariner/pull/2035


RegexNotFoundError: Unable to extract Initial JS player signature function name

bash Output:
youtube-dl --verbose http://youtu.be/SqJGR7-1QlI
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://youtu.be/SqJGR7-1QlI']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.05
[debug] Python version 2.7.8 - Linux-3.16.0-30-generic-x86_64-with-Ubuntu-14.10-utopic
[debug] Proxy map: {}
[youtube] Setting language
[youtube] SqJGR7-1QlI: Downloading webpage
[youtube] SqJGR7-1QlI: Downloading video info webpage
[youtube] SqJGR7-1QlI: Extracting video information
[youtube] SqJGR7-1QlI: Encrypted signatures detected.
[youtube] {22} signature length 40.41, html5 player en_US-vflZvrDTQ
[youtube] SqJGR7-1QlI: Downloading js player vflZvrDTQ
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 383, in _extract_signature_function
res = self._parse_sig_js(code)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 454, in _parse_sig_js
u'Initial JS player signature function name')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 391, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract Initial JS player signature function name; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 383, in _extract_signature_function
res = self._parse_sig_js(code)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 454, in _parse_sig_js
u'Initial JS player signature function name')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 391, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract Initial JS player signature function name; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 516, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 170, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 860, in _real_extract
encrypted_sig, video_id, player_url, age_gate)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 489, in _decrypt_signature
u'Signature extraction failed: ' + tb, cause=e)
ExtractorError: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 383, in _extract_signature_function
res = self._parse_sig_js(code)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 454, in _parse_sig_js
u'Initial JS player signature function name')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 391, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract Initial JS player signature function name; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

I can use the same version of YTD on other hardware that has the same OS(Ubuntu/Gnome 14.10) with no issues. I have updated with apt and have purged and re-installed from default repo and still crashes.

You are using an outdated version of youtube-dl. YouTube changed their playlist interface in October 2014 (and if memory serves 2<IP_ADDRESS> is also important in between). See our FAQ for options to update despite outdated versions in the Ubuntu repositories.


Improve config file handling

In case the startup configuration file cannot be read/parsed, print out an error and return without panicing as this is a handled error
Write more clear error message for most common failure: file not found (and wrong file type)
Write message to log
Slightly rephrase description of "--startup-config" option

Definition of Done
The PR shall be merged only if all of following items were checked. In case an item is not applicable as described, please provide a short explanation right after the item in question. Separate the explanation by a semicolon and write it as bold text like ; requirements are handled in issue #xyz:

[x] documentation of all modules /*/doc/swdesign is up-to-date
[x] requirements are up-to-date and requirements for new features have been added and mapped to source and test
[x] conform to unit verification strategy

Can be closed in favor of https://github.com/eclipse-ankaios/ankaios/issues/9.

As agreed, the proposed improvements here will be done with the changes for #9 in a more generic way that can be reused throughout the entire codebase.
@flba-eb, thank you very much for opening the PR and the ideas!


#17605  should not be closed!

VSCode Version:
OS Version:

Steps to Reproduce:

Open multiple vscode projects
There is no list with the open windows in the 'window' menu.It says only 'bring all to front'.

The answer from egamma is not correct,there is no list with open windows in the doc menu,it shows only a list of previous opened projects,not the current open projects.

Instead of creating a duplicate Issue, you should write comments on existing Issues.
Duplicate of #17605

@stefanaerts thanks for the additional feedback, as suggested by @mrmlnc let continue the discussion in #17605


Question and concern

When I played this w/ Brutal Doom, it shows the blood and death animations, any way to disable that ?
and you can add an option to Disable the Enemies on UC Minimap pls ?
Also, I have Textured Display enabled, but on the UC Minimap it's not

When I played this w/ Brutal Doom, it shows the blood and death animations, any way to disable that ?

Disable "Draw Projectiles". Brutal Doom's Blood actors have Projectile flag(s).

and you can add an option to Disable the Enemies on UC Minimap pls ?

This can be achieve by disabling the Radar in the Options menu. (Or you can set the Range to 0)

Also, I have Textured Display enabled, but on the UC Minimap it's not

I'm not quite sure that it's possible to replicate this behavior currently.

When I played this w/ Brutal Doom, it shows the blood and death animations, any way to disable that ?

Disable "Draw Projectiles". Brutal Doom's Blood actors have Projectile flag(s).

and you can add an option to Disable the Enemies on UC Minimap pls ?

This can be achieve by disabling the Radar in the Options menu. (Or you can set the Range to 0)

Also, I have Textured Display enabled, but on the UC Minimap it's not

I'm not quite sure that it's possible to replicate this behavior currently.


lib/preexec: delete wrong negation

Delete wrong negation after calling _bash-it-array-contains-element.
This is a bug introduced by commit ae8c9c08a3c3f298409ed9efb755eeffe0d2afb2,
which prevent all themes that uses PROMPT_COMMAND from properly working.
Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[ ] I have added tests to cover my changes, and all the new and existing tests pass.

Sorry I have just noticed it is a duplicate of #2066.


Removing a child from a TabBarView doesn't properly update the TabBarView Fixed

This PR fixes #89367. Line 1362 in _TabBarViewState.didUpdateWidget is never called when we remove a child from children list.
https://github.com/flutter/flutter/blob/81142c1f9a18df456b3b147a45cd5971e58014ec/packages/flutter/lib/src/material/tabs.dart#L1356-L1363
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

@danagbemava-nc
I think that on updating children or TabController we should call _updateChildren. We can call the _updateChildren after line 1360 in _TabBarViewState.didUpdateWidget. One more thing that we have to do is update the _currentIndex and animate the page view to updated _currentIndex. Should I update the _currentIndex in  _TabBarViewState.didUpdateWidget ?
Can you please guide me on how should I proceed? Calling _warpToCurrentIndex on TabController update is failing following assertion.
https://github.com/flutter/flutter/blob/81142c1f9a18df456b3b147a45cd5971e58014ec/packages/flutter/lib/src/material/tabs.dart#L1404

@varunkamanibosc I'm going to close this PR since it looks like you are still working on it; please don't hesitate to open a new PR when you are ready for code review! Thanks!


refactor: Add some const-correctness

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?

/area API-version
/area build
/area CI
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-bpf
/area libscap-engine-gvisor
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-savefile
/area libscap
/area libpman
/area libsinsp
/area tests
/area proposals

Does this PR require a change in the driver versions?
no
What this PR does / why we need it:
This PR adds const a number of class member functions, when applicable, to allow to use them on const objects. Functions of classes that call these functions on their data members are prevented from declaring their functions const, even they are logically so, because of the missing const.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: federico-sysdig
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Could we get a rebase, thanks!

Could we get a rebase, thanks!

@incertum Sure. Done.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: federico-sysdig, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: dd1bbaee73014bcd5526ea87cbe16dd41b413376

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, federico-sysdig, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[fix]: [SRM-15255]: Removing enabled scope from terraform

Describe your changes
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck

@deepak-harness Even though it was an optional field. Work with PM to communicate this with the customer.

@deepak-harness Please ask someone from SRM team to review this as well.


Use iterator to control the concurrency and replace Promise.all

https://stackoverflow.com/a/51020535/1123955

My answer on StackOverflow:

https://stackoverflow.com/a/69985103/1123955

Published at<EMAIL_ADDRESS>


Add :goots-angel:

if goots is inherently for good, is this necessary?  a for effort on the pair tho.


trainning from scratch

hi
I the paper wroten that you trained the transform net from the model that has been pre-trained with weakalign.
I the repo "https://github.com/ignacio-rocco/weakalign.git" the architecture is different than yours. (two stages vs. one stage)
so how did you did it ?

Hi, in our paper, we used only the affine transformations from weakalign. Please see this function https://github.com/aosokin/os2d/blob/96c488b3979c505b92245ccdab941fb01fdf99de/os2d/modeling/model.py#L389
on how we loaded their weights into our model.
Best,
Anton

why didn't you tried to use thin-plate spline (TPS) transformation that refines the alignment?

We tried after the paper but could not get significant improvements. The TPS model was designed with two stages requiring image resampling between them. This was too slow when put into OS2D. We made it work with some workarounds but could not get stable improvements over the linear model, and it was still very slow.


Return Amount<ERC20> instead of Erc20Amount and ModuleFeeAmount in apollo cache

Closing this in favour of revisited version (see thread).


Fix ReqMgrAux update wmagent config method

Fixes #9469
Status
ready
Description
getWMAgentConfig method is actually used in multiple places, including a few components. So it might be easier and cleaner to just deal with that list within the updateRecords in place method.
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

patch applied to vocms0257 to let it go. I'll get back to it tonight and apply it to all the other agents.

test this please


Consider using a license compatible with GPLv2

Hi,
I would love to use this library but the current license is show stopper for me since I need to integrate it with an application under GPLv2.
Is it possible for you to re-license  or double license the library with something that does not have the same restrictions?

Done in https://github.com/delight-im/PHP-Cookie/commit/a746f4096885b6715a640a2122b1c21324624f8f
Thank you very much for pointing this out!
Hope this helps!


Integration tests create a bunch of gists

Not sure if this is a bug or not, but one of the integration tests seems to be creating a gist every time it's run... I ended up with 30~40 gists on my account without even realising it while working on #139 and #142 which was... annoying.

ahah just noticed it too, we'll have to remove those.

Agreed

solved in #151 :+1:


Cache values for a short time

Problem
My application is getting more than 1000 requests per second when I use Pennant, it runs a query per request which makes my DB load increase.
Proposal
WDYT if we cache the value for 1 minute by default (can be configured in the config file) to not DDoS the database with many queries.
AFAIK Configcat is also doing similar and caching the values for a minute.

Hi @saeedvaziry,
To reduce DB load make sure you are are eager loading your features. This will ensure that you only have one database query per request: https://laravel.com/docs/10.x/pennant#eager-loading
If you need caching I'd recommend implementing a "Cache Decorator" driver that simply wraps the existing drivers.
We may look at adding something like this as a first party solution in the future, but we aren't looking at adding this right now.


Stable release

Does this repo have all of your enviro weather updates?
I was looking at the enviro repo but there are a lot of pull requests still waiting to be merged. And last update was 7months ago .
Thanks
J

Hi @JohnRSim
This forked repo houses all the branches I have used to make the PRs against the Pimoroni repo. It also has some extra branches I am using to develop my own fork of the code:

sj-enviro: All the branches that are for PRs to the Pimoroni repo and potentially any extra dev I have done and tested, the releases in this repo are against this branch and are the nearest thing to stable given I am only testing on my own board.
sj-develop: My development branch where individual features have been merged and I am testing on my board ahead of merging into sj-enviro if I don't see any issues
sj-develop-multicore: A branch including all my experimental features for using multicore to run continuous polls at around 4hz for more accurate recording. This is currently sitting alongside the enviro code, but is likely to completely replace it and will get its own repo once this has settled down a bit.

If you want to try out one or more of the features I have outstanding PRs for, then I recommend using the code from the latest release in this repo i.e. sj-enviro branch code. Feel free to raise an issue if you experience any problems with that code, I make no promises, but it should work and I'll do my best to look into it if it doesn't.

Advice on various branch content in this repo provided.


Error building DependencyGraph: TypeError: Cannot read property 'root' of null

My setup:
natal: 0.1.11
OSX: El Capitan 10.11.1 (15B42)
nodejs: v4.2.2
Created the project with:
natal init rn --interface om-next
Console log:
Looking for JS files in
/Users/alanm/projects/coopsource/rn/native
[5:28:20 PM]  Building Dependency Graph
[5:28:20 PM]  Crawling File System
[5:28:20 PM]  Loading bundles layout
[5:28:20 PM]    Loading bundles layout (0ms)
React packager ready.
Error building DepdendencyGraph:
TypeError: Cannot read property 'root' of null
at /Users/alanm/projects/coopsource/rn/native/node_modules/react-native/packager/react-packager/src/DependencyResolver/crawlers/index.js:16:84
at tryCallOne (/Users/alanm/projects/coopsource/rn/native/node_modules/react-native/node_modules/promise/lib/core.js:37:12)
at /Users/alanm/projects/coopsource/rn/native/node_modules/react-native/node_modules/promise/lib/core.js:103:15
at flush (/Users/alanm/projects/coopsource/rn/native/node_modules/react-native/node_modules/promise/node_modules/asap/raw.js:50:29)
at doNTCallback0 (node.js:419:9)
at process._tickCallback (node.js:348:13)
Process terminated. Press  to close the window

I have the same issue.
Natal : 0.1.12
Xcode: 7.1.1
Node: v5.0.0

Upgrading watchman to 4.1 resolved the issue for me. I found the solution here

Great - thanks. Will give it a try. Closing this issue.

I reload my watchman but still not


Fix comment syntax in tasks/release.sh

Oops, I was drafting a release and had already fixed it in https://github.com/facebookincubator/create-react-app/commit/fedc539246a155f11db8a1b64f6928914672d9db!

great! thank you


change master election to leader election

I have been meaning to do this for a while now. This small person provided the gentle reminder: https://twitter.com/mranney/status/591807926123175936 :+1:

Love this. :+1:

+1
openldap went from master/slave for replication to provider/consumer.
I think for election process, leader is spot on.

@jtimberman @miah thank you for the feedback! Going to merge this, it will be in the next release \o/


Did you consider other storage service?

Such as S3 and CloudFront

The current list came from customer request, but to include a new one we just need: (1) authorization, (2) list of files by "folder" and (3) endpoints to create folder, upload and download.
Will keep those in mind for future improvement


Major Update: refactor chart loading and rendering

Created new services for charts:  'chartRendering', 'chartOptions', 'chartTools', 'chartOptions', 'dataProcessing', and a 'utilService'.

Current coverage is 36.48% (diff: 10.00%)

Merging #222 into d3 will decrease coverage by 0.01%

@@                 d3       #222   diff @@
==========================================
  Files           260        260
  Lines         14162      14169     +7
  Methods           0          0
  Messages          0          0
  Branches       2378       2379     +1
==========================================
+ Hits           5169       5170     +1
- Misses         8271       8277     +6
  Partials        722        722

Powered by Codecov. Last update d04d26c...f02c1c1


Remove a reference to the open Arrow file when deleting a TF dataset created with to_tf_dataset

This comment explains the issue. This PR fixes that with a weakref callback, and additionally:

renames TensorflowDatasetMixIn to TensorflowDatasetMixin for consistency
correctly indents TensorflowDatasetMixin's docstring
replaces tf.data.AUTOTUNE with tf.data.experimental.AUTOTUNE (we support TF>=2.2 according to the setup.py and AUTOTUNE has been moved to the experimental part of tf.data in 1.X if I'm not mistaken)

Fixes #2934

@lhoestq The test passes even without the try/except block!


[BEAM-2135] Move hdfs to hadoop-file-system

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @davorbonaci @tgroh

R: @dhalperi

Looks good to me.

retest this please

Coverage remained the same at 69.842% when pulling 73ca609d1bb7e6c385e3f2505d1fd443bdc759fd on lukecwik:move_hdfs into 19105d9be1580f79287c24678e2b6194bc9c704b on apache:master.


Upgrade to Apache Karaf Minho 0.1 (release)

I have submitted Apache Karaf Minho 0.1 release to vote this morning. I will update to this version in OSC (instead of using SNAPSHOT).

Apache Karaf Minho 0.1 release is done, the artifacts will be on Maven Central soon. I'm creating the corresponding OSC PR.


Problem about the text-to-video retrieval zeroshot evaluation?

Dear author,
I tried to use the released checkpoints (model_base_retrieval_coco.pth and model_large_retrieval_coco.pth) to test on the msrvtt retrieval dataset, but I got R1 35.8 and 39.74, respectively.
How could I get the 43.3 presented in your arXiv paper? Thanks!
Yours,
Sincerely

Hi,
The reported result in the paper is for text-to-video retrieval, whereas my evaluation code will output results for both video-to-text and text-to-video. Is it possible that your R1 is for video-to-text?

Thanks for your reply!
My R1 is for video-to-text, you are right! I learn a lot from your works: ALBEF and BLIP, and I am looking forward to your code on videoQA. Thanks a lot again!
Yours,
Sincerely


fix: 🐛 Added support for cancel record icon and cancel voice recording.

Description

Add support to cancel voice recording.
Add field to set icon for cancel voice record.

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have followed the Contributor Guide when preparing my PR.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

Related Issues

Closes #137

add video or image please.


Specifying highlight.js theme?

Hi there! Just stumbled across this and I really dig what mdpdf can do so far.
Is there a way to modify the default highlight.js styles?
I've played around with manually overriding CSS (aka, .markdown-body .highlight pre) which works fine, but I'd love to be able to switch hljs themes without manual CSS.
I didn't see anything in the documentation though I do see some closed issues around highlighting, but nothing regarding switching styles.

We don't have anything for this right now but I'd be open to a pull request if you want to add it. Mdpdf is about customisation so if we can find a tidy way to include further customisation then that would be neat, but as you said you could include a full override of the styles in a custom css file. This would make your css file quite large but it does mean it's possible.
If you have a proposal, feel free to add it to this issue or submit a pull request and I'd be really happy to look it over. It's worth me mentioning though that I probably don't have time to implement a proposal myself right now, so if this is something you'd really value then a PR might be the best way to go 😄

That makes sense.
I ended up wanting to go with a theme from PrismJS, so what I'm doing is preprocessing code blocks myself as <pre />s and applying the appropriate prism class name, and including the stylesheet in the css file.
Works for my use case, so I'm going to close this issue.


FCMTokenRefreshed with no listeners registered warning appears on launch of iOS app

On the launch of the iOS app in debug mode, the below warning message appears:
"Sending 'FCMTokenRefreshed' with no listeners registered".
I am receiving push notificaitons with out any issue.

"Sending 'FCMTokenRefreshed' with no listeners registered". could happen if the event triggers before JS is bootstrapped,
do you call "getFCMToken" when app starts and sync it to server?

Any update on this??
 Please any help

Add function to listen FCMTokenRefreshed event
FCM.on("FCMTokenRefreshed", token => {
        //update token to server
})


325 attachment pages

PR #325 Adds Appellate Attachment Page parsing.

This PR was essentially finished imho, but I made a final doctoring tweak and updated
typing and python3 decode encode issue from before the py3 upgrade.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mlissner I think we had so many ready to bump over the line and this one seems somewhat important.
Tests still pass and its been rebased.  Looking forward to your thoughts on this one.

@albertisfu can you take a look at this and see what it takes to get it over the line, assuming we didn't build appellate attachment page parsing somewhere else, since this PR was forgotten?

Yes, of course, I'll check this. Yeah, I checked and we don't have appellate attachment page built somewhere else.

I've checked this and completed the requested changes above.
Added some new tests from other districts, it just needed some tweaks to work in ca5 attachment pages since it contains an extra column with checkboxes.
I also did some tests using this parser to merge appellate attachment pages in CL in order to confirm the JSON structure is correct, some questions came up:

Since appellate attachment pages don't have document numbers, I think the right way to assign the main document number to each recap document attachment is to get it from the main recap document, assuming that some courts use numbers and others the pacer_doc_id as numbers,  does it seems good to you?

In order to identify the main recap document when merging attachments we use the main document pacer_doc_id, unlike district attachment pages where the pacer_doc_id can be found outside the attachment table. For appellate attachments, the main document is included within the same attachment table and sometimes it's not in the first row.
But now we identify the main pacer_doc_id assuming that it's the number with the lower value, I checked some appellate dockets and their attachments pages, and seems that this is true.
Here's an example:

In this example, the docket entry has the pacer_doc_id:<PHONE_NUMBER>40
In the attachment page, attachment 2 is the one with the lower pacer_doc_id<PHONE_NUMBER>40 so this would be the main document.
So that the logic to select the main pacer_doc_id based on the lower value in this example works and a couple more that I checked.
Do you know if it might exist an exception where the main pacer_doc_id is not the one with the lower value?

Merging this example in a test in CL, it looks like this:

I think we need to do some changes to how the main document and attachments are shown in CL for appellate since now the Main Document is a copy of Attachment 2.
So following the assumption that the main document is the one with the lower pacer_doc_id in appellate attachments pages, for this example, it should be shown like this?

Using the Attachment 2 as the Main document and renumbering the attachments?
Let me know what do you think.

And in that case, there's no main document for the row. This aligns with how the appellate website shows it too, and if you look at the top of your screenshot of the attachment page, it says, "3 documents are attached to this filing."

Perfect, yeah this seems like the right approach, so yes when the appellate docket entry has multiple documents (attachments) we won't show the "Main document" row and only show the attachments rows as on PACER.
So in this scenario, when the appellate docket is uploaded and the docket entries are added. For each document entry, a "main" RECAPDocument is created containing the pacer_doc_id for the "main" document (that we'll use when an attachment page is uploaded to identify the docket entry and merge attachments), so in case the appellate docket entry has attachments we'll only hide the "Main document" row in the frontend but it always exists an empty RECAPDocument for that "main document" in DB.

But then I got lost, because they...do seem to have numbers? Or is there an example of a court that doesn't do them on the attachment pages that you can share? Maybe as a link so I can look too?

Yes, appellate attachment pages have numbers but they are the Attachment number, I was referring to the Document number that every RECAPDocument has, which in an attachment is the Document number from the main RECAPDocument/Entry Number.

So this Document number is the one that I think can be copied from the main RECAPDocument or set it as blank?
Thanks for your comments!

I've submitted a PR in CL where this new parser is used: https://github.com/freelawproject/courtlistener/pull/2413
No more changes were needed here, so once this is merged, I can add a version bump and update the CL PR.


Get wrong value in Chrome when zoomed

Thanks for great job.
I'm using your slider for audio player. There is value error in Chrome when zoomed and offset more then 0 on the x-axis. It's important in mobile devices.

hi @voxtobox
can you give me some details or change a little bit the following fiddle http://jsfiddle.net/darul75/b09m7183/
I understand it is important and would like help you then

Hm, It works correct in fiddle but not in your demo site http://darul75.github.io/angular-awesome-slider/ .

demo has not been refactored and use an old version, which version are use using just to know

v2.3.8

This is video which show problem http://monosnap.com/file/1B8Ala0YB5p9rtzol4h1FjGhmq5OO6

OMG, so nice bug :) but how do you do to zoom just by clicking, I do not know this feature, is it natively supported by css3 or something like that

hmm ok, I have to activate touch sensor in inspector..

It`s simple zoom in browser. Like shift + '+' on Chrome :)

ok

I have problem to reproduce it, trying but not so easy, even with demo website, can you try update fiddle or anything I could use.

I have made a small change, can you try this one https://raw.githubusercontent.com/darul75/angular-awesome-slider/master/dist/angular-awesome-slider.min.js

here my test, does it work or still buggy
http://jsfiddle.net/darul75/ucwsaamn/
https://jsfiddle.net/darul75/ucwsaamn/embedded/result/

In fiddle works well but not in my site.
I noticed another difference: when I zooming with shift + '+'  it works well rather with finger on touch pad not. And well in iOS and not on Android.
Issue apper only in Chrome in Desktop and Android.
I`ll try to build fiddle later.
Again thanks for your work.

I look on my side too, and try to reproduce it clearly,
is behaviour only for 'click'/touch' events on slider bar or also when moving by dragging some slider pointers or both move/click/touch events have problems

click : ok ?
drag, move pointer : ok ?

a good test case is welcome sure, but I know it is quite tricky to make it ;)


New UI for Folder Auth plugin

A new React-based UI for the folder auth plugin.
Links

https://github.com/jenkinsci/folder-auth-plugin/pull/58

Thanks for your contribution!
@all-contributors please add @sladyn98 for code

Of, sorry 🤦 . Sladyn posted a blog anyway, so I will keep that

@all-contributors please add @AbhyudayaSharma for code


Exclude TeamCity success status

SolutionCop writes teamcity success status after tests passing, so this result is presented forever, even after unit tests execution. TeamCity builds overview does not show tests counts for now, only solution cop statuses.
I'd like to disable (or optionally disable) solution cop TeamCity success status (and keep logging, failed statuses, etc.)

Decided to use new command line property suppress-success-status-message.

Since version 0.7.0 success builds are reported with progressMessage rather then buildStatus, and command line property now obsolere.


DMA mode takes up 60k of ram just for a single 300 led strip!!!!!

Hi, this library is absolutely perfect for me. I've been experiencing many issues with glitching when using BLE and driving LEDs at the same time. However, when I define FULL_DMA_BUFFER, 60kB of ram is consumed and I am already running low on ram on this project :(
Is this caused by a bug? I understand that we need 3x the bytes of the led strip data, but in my case this would be less than 1kB

Hello sorry for the late reply
the FULL_DMA is indeed memory hungry.
THe DMA size should be nb_of_leds_per_strip38*2 hence in your case 14k  this is strangethat you have 60k can you share your code ?
I will have a closer look at it maybe I have a mistep somewhere

I2S1 support to 8 pins. so if we need up to 8 parallel data and we use I2S 1 instead 0 then we can use save 50% memory.
DMA size should be nb_of_leds_per_strip x 3 x 8  x 3
pls guide me how to use I2S 1 in this driver?
thanks

For existing 16 bit width driver (I2S 0) with FULL_DMA, what is the maximum limit of nb_of_leds_per_strip?
Can I go for 1024 or 2048 Leds per strip?
Thanks & regards

Hello if you’re using full dma buffer it will depend of your memory.

HelloIt’s not responsible of the i2s used. I need a change of code to not use 16 but 8 buffer size. I can make it a choice. YvesOn 2 Jul 2023, at 07:51, Jagadish Paul @.***> wrote:
I2S1 support to 8 pins. so if we need up to 8 parallel data and we use I2S 1 instead 0 then we can use save 50% memory.
DMA size should be nb_of_leds_per_strip x 3 x 8  x 3
pls guide me how to use I2S 1 in this driver?
thanks
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Sorry for not to understand your reply correctly.

Did you mean that it is not possible to use I2S 1 instead I2s 0. if so then can you explain the reason? As per my knowledge I2S 1 has a offset of pin from I2S 0. Other things almost same.
Are you going to change you code in such a manner that with I2S 0 & within 8 strip you will manage the code it use 8 bit buffer instead of 16 bit?
Thnaks

ill depend of your memor

I want to know value of nb_of_leds_per_strip for existin memory of ESP32.

If you use full dma I think around 2200leds per strip

Can I ask you what you are trying to achieve?

If you do this you will to have enough ram for much of the rest.
Can I suggest 2 things ?

use the Virtual driver to use more pins and have a better refresh rate because now you're refresh rate is 16fps !! without counting the time to transpose the entire screen.
do not use full dma buffer in your case
if you're afraid that you will have interrupt issues look at this https://youtu.be/sYtVOU8Hpss
If I may ask what will this will be used for ?

Thanks for you reply.
I will try as you suggested.
Sir one question I have.
Can you explain please how frame rate increase in virtual driver rather
than direct parallel driver?
As I understand in both the cases matrix transpose is done.
Thanks and regards
On Tue, 4 Jul, 2023, 12:06 pm hpwit, @.***> wrote:

If you do this you will to have enough ram for much of the rest.
Can I suggest 2 things ?

use the Virtual driver to use more pins and have a better refresh
rate because now you're refresh rate is 16fps !! without counting the time
to transpose the entire screen.
do not use full dma buffer in your case
if you're afraid that you will have interrupt issues look at this
https://youtu.be/sYtVOU8Hpss
If I may ask what will this will be used for ?

—
Reply to this email directly, view it on GitHub
https://github.com/hpwit/I2SClocklessLedDriver/issues/11#issuecomment-1619592139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5AG62N2CAYP654EPXLITXOO2XTANCNFSM6AAAAAAR55M56Y
.
You are receiving this because you commented.Message ID:
@.***>

Hello
The frame rate increases because you can have more parallel pins. I a nutshell the virtual driver allows you to drive 8 strips individually per pin of the esp32 using a shift register.
Hence you can drive your 16k less over 32 strips of 512 leds. Using 6 pins of the esp32 (4 data 1 latch 1data) Hence the fps will be 65 instead of 16.

Ok, thanks for the clarification.
On Wed, 5 Jul, 2023, 10:23 am hpwit, @.***> wrote:

Hello
The frame rate increases because you can have more parallel pins. I a
nutshell the virtual driver allows you to drive 8 strips individually per
pin of the esp32 using a shift register.
Hence you can drive your 16k less over 32 strips of 512 leds. Using 6 pins
of the esp32 (4 data 1 latch 1data) Hence the fps will be 65 instead of 16.
—
Reply to this email directly, view it on GitHub
https://github.com/hpwit/I2SClocklessLedDriver/issues/11#issuecomment-1621023981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5AG3HKF6IJ7LY2VKOAULXOTXNFANCNFSM6AAAAAAR55M56Y
.
You are receiving this because you commented.Message ID:
@.***>


Can you add search user with name?

Hey this repo is really good but I need to search users with usernames. Can you help about it ?

@wixvii You want to search for users with some given 'string'? And for example export it?


Failure to find SIP on macOS

When testing ROS 2 Galactic (actually rolling since we haven't forked yet) on macOS Mojave, packages downstream of python_qt_binding fail to find SIP like this:
Starting >>> qt_gui_cpp
--- stderr: qt_gui_cpp
CMake Warning at /Users/william/ros2_rolling/install/python_qt_binding/share/python_qt_binding/cmake/sip_helper.cmake:27 (message):
  SIP binding generator NOT available.
Call Stack (most recent call first):
  src/qt_gui_cpp_sip/CMakeLists.txt:56 (include)

CMake Error at src/CMakeLists.txt:10 (message):
  No Python binding generator found.

---
Failed   <<< qt_gui_cpp [2.72s, exited with code 1]

This is the version of SIP that is installed by default (as of writing) on a fresh macOS machine:
macos-10:ros2_rolling william$ brew info sip
sip: stable 6.0.3 (bottled), HEAD
Tool to create Python bindings for C and C++ libraries
https://www.riverbankcomputing.com/software/sip/intro
/usr/local/Cellar/sip/6.0.3_1 (708 files, 10.7MB) *
  Poured from bottle on 2021-04-14 at 16:26:19
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/sip.rb
License: GPL-2.0-only or GPL-3.0-only
==> Dependencies
Required<EMAIL_ADDRESS>✔
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 31,588 (30 days), 79,774 (90 days), 258,068 (365 days)
install-on-request: 7,641 (30 days), 12,754 (90 days), 32,176 (365 days)
build-error: 0 (30 days)
macos-10:ros2_rolling william$ brew search sip
==> Formulae
baresip    libexosip  libosip    sip ✔      sipcalc    sipp       sipsak     sofia-sip
==> Casks
homebrew/cask/sip

I'm not sure if it is because we just need something like https://github.com/ros-visualization/python_qt_binding/pull/94 to be merged, or if SIP>=6 is supposed to be used with Qt 6 (we're still using Qt 5 as qt@5 on macOS, but there's no equivalent for sip that I can find in homebrew).

Hi. I just found this out as well. The problem is that sipconfig was removed after SIP 4. So the
COMMAND ${PYTHON_EXECUTABLE} -c "import sipconfig; print(sipconfig.Configuration().sip_bin)"

in /python_qt_binding/cmake/sip_helper.cmake fails. However, PyQt and all bindings are already installed when I install it via brew and sip also works. To make rolling build, I removed the error in ros-visualization/qt_gui_core/qt_gui_cpp/src/CMakeLists.txt:
message(STATUS "Python binding generators: ${qt_gui_cpp_BINDINGS}")
if(NOT qt_gui_cpp_BINDINGS)
  # message(FATAL_ERROR "No Python binding generator found.")
endif()

After that everything is building and my code works as well as qt-applications (both cpp and py qt-applications). I compiled it on Big Sur.
Is it necessary to actually generate the bindings when building ROS? If it is necessary, the code needs to be migrated to use the newer versions of SIP, i think.

Is it necessary to actually generate the bindings when building ROS? If it is necessary, the code needs to be migrated to use the newer versions of SIP, i think.

It's a good question.  Most of the RQt tools are written in Python already, so they don't really need the SIP stuff.  A quick look around seems to say that we don't actually use the C++ rqt stuff (at least, none of the package.xml files depend on it).
So one way out of this may be to just remove the qt_gui_cpp stuff completely.

Hey everyone, according to Riverbank Computing version 4 is unsupported, however they provide tar and zip files with version 4.19.25. I've attempted to install ROS Galactic on Big Sur and have been unsuccessful in getting qt_gui_cpp to install for another reason:
CMake Error at /usr/local/Cellar/cmake/3.19.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS)
  (Required is at least version "3.9")
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.19.4/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.19.4/share/cmake/Modules/FindPythonLibs.cmake:310 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  src/qt_gui_cpp/CMakeLists.txt:2 (find_package)

If I come up for a solution to this other python problem then I think maybe we'll need to wrap versions of SIP and other Qt versions within the osrf brew tap.

I think that either the possibility for c++ plugins in rqt is removed or that the code is updated to SIP 6. Maybe as @clalancette suggested, this is not really used and could be removed. There have always been a lot of issues with this on mac.

I just came across this problem.
In my case I'm using Linux, but I'm installing Python packages via pip rather than via apt-get in order to use them in a virtual environment.
Running apt-get install python3-sip installs version 4.19.7 (which includes sipconfig) on the other hand pip3 install sip installs version 6 which does not include sipconfig.
Similarly it looks like sipconfig is not present also in older versions distributed by pip, e.g. I got same error also using pip3 install sip==4.19.7.
Following @clalancette suggestion, I resolved the problem by simply ignoring the qt_gui_cpp and rqt_gui_cpp packages during the build.

@alsora Can you please elaborate on how to ignore those packages?

@omerts
Just add a file named COLCON_IGNORE into the qt_gui_cpp and rqt_gui_cpp folders...
Or just remove them alltogether from your workspace

colcon build --symlink-install --packages-ignore qt_gui_cpp rqt_gui_cpp

A quick look around seems to say that we don't actually use the SIP rqt stuff

The Python bindings are still used in a few of the rqt plugins. The pyside / shiboken bindings do work on macOS, and if the sip bindings are excluded then python_qt_binding and its dependent packages will build and run.
I've made a couple of non-portable patches to illustrate the changes. brew installs pyside@2 and qt@5 as keg only and I've hardcoded the paths to these in find_package to get up and running.

python_qt_binding https://github.com/ros-visualization/python_qt_binding/commit/79d60de8aadeb44a16274fcc9ed049e89d61ffbe
qt_gui_core https://github.com/ros-visualization/qt_gui_core/commit/162600b7c91c4b7ef979f6d23c97bc05e07d0c61

Ensure pyside@2 is in the PYTHONPATH before running rqt:
export<EMAIL_ADDRESS>
Here is ROS2 Humble running rqt on macOS Monterey (intel MacPro).

@srmainwaring If you find a way to clean up those patches, we'd be happy to review them.
Additionally, @ipa-cmh has started working in this area to try to rectify all of the different ways we use Python with Qt.  See https://github.com/ros-visualization/python_qt_binding/pull/115 , https://github.com/ros2/rviz/pull/889 , and https://github.com/ros-visualization/python_qt_binding/issues/114 .

@clalancette I've cleaned up the patches and submitted these PRs:

https://github.com/ros-visualization/python_qt_binding/pull/118
https://github.com/ros-visualization/qt_gui_core/pull/268

There is an ugly macOS specific work-around for the shiboken generator's include dependency on some Qt components. Depending on the plans / timelines you mention above to streamline the approaches to use Qt Python this may or may not be acceptable as an interim measure.

I'm also running into this on Ubuntu 23.04 (Lunar). Yes, I know it's not a supported distro, but I thought I could at least make people aware.
Temporary solution:
 colcon build --packages-skip qt_gui_cpp --packages-skip-by-dep qt_gui_cpp
Looks like QT5 is going EOL soon anyways.

Any progress on this (for macOS)?

I'm trying to install ROS2 on macOS and having an issue with colcon build command. I just couldn't get away with an error in building rviz_rendering.
I would really appreciate any advice/thoughts! The error is as below.
Q_DECLARE_TYPEINFO_BODY(QFlags<T>, Q_PRIMITIVE_TYPE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/include/QtCore/qtypeinfo.h:154:84: note: expanded from macro 'Q_DECLARE_TYPEINFO_BODY'
        isComplex = (((FLAGS) & Q_PRIMITIVE_TYPE) == 0) && !std::is_trivial_v<TYPE>, \
                                                            ~~~~~~~~~~~~~~~~~~~~~~~^
/opt/homebrew/include/QtCore/qtypeinfo.h:169:1: error: no template named 'is_pointer_v' in namespace 'std'; did you mean 'is_pointer'?
Q_DECLARE_TYPEINFO_BODY(QFlags<T>, Q_PRIMITIVE_TYPE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/include/QtCore/qtypeinfo.h:156:26: note: expanded from macro 'Q_DECLARE_TYPEINFO_BODY'
        isPointer = std::is_pointer_v< TYPE >, \
                    ~~~~~^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/__type_traits/is_pointer.h:25:29: note: 'is_pointer' declared here
struct _LIBCPP_TEMPLATE_VIS is_pointer : _BoolConstant<__is_pointer(_Tp)> { };
                            ^
In file included from /Users/ellieko/ros2_iron/build/rviz_rendering/include/rviz_rendering/moc_render_window.cpp:10:
In file included from /Users/ellieko/ros2_iron/build/rviz_rendering/include/rviz_rendering/../../../../src/ros2/rviz/rviz_rendering/include/rviz_rendering/render_window.hpp:36:
In file included from /opt/homebrew/opt/qt@5/lib/QtCore.framework/Headers/QObject:1:
In file included from /opt/homebrew/opt/qt@5/lib/QtCore.framework/Headers/qobject.h:46:
In file included from /opt/homebrew/include/QtCore/qobjectdefs.h:12:
In file included from /opt/homebrew/include/QtCore/qnamespace.h:12:
In file included from /opt/homebrew/include/QtCore/qglobal.h:46:
/opt/homebrew/include/QtCore/qtypeinfo.h:169:1: error: expected '(' for function-style cast or type construction
Q_DECLARE_TYPEINFO_BODY(QFlags<T>, Q_PRIMITIVE_TYPE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/include/QtCore/qtypeinfo.h:156:46: note: expanded from macro 'Q_DECLARE_TYPEINFO_BODY'
        isPointer = std::is_pointer_v< TYPE >, \
                    ~~~~~~~~~~~~~~~~~~~~~~~~~^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [CMakeFiles/rviz_rendering.dir/include/rviz_rendering/moc_render_window.cpp.o] Error 1
make[1]: *** [CMakeFiles/rviz_rendering.dir/all] Error 2
make: *** [all] Error 2
make: INTERNAL: Exiting with 10 jobserver tokens available; should be 8!
---
Failed   <<< rviz_rendering [2.76s, exited with code 2]
Aborted  <<< test_launch_testing [1.80s]
Aborted  <<< rosidl_generator_dds_idl [1.34s]
Aborted  <<< rcutils [4.79s]

Summary: 128 packages finished [27.9s]
  1 package failed: rviz_rendering
  3 packages aborted: rcutils rosidl_generator_dds_idl test_launch_testing
  38 packages had stderr output: ament_clang_format ament_clang_tidy ament_copyright ament_cppcheck ament_cpplint ament_flake8 ament_index_python ament_lint ament_lint_cmake ament_mypy ament_package ament_pclint ament_pep257 ament_pycodestyle ament_pyflakes ament_uncrustify ament_xmllint cyclonedds domain_coordinator iceoryx_binding_c iceoryx_hoofs launch launch_pytest launch_testing launch_testing_ament_cmake launch_xml launch_yaml osrf_pycommon python_orocos_kdl_vendor rcutils resource_retriever rosidl_cli rosidl_pycommon rpyutils rviz_rendering tracetools_read tracetools_trace urdfdom
  226 packages not processed
[28.181s] ERROR:colcon.colcon_notification.desktop_notification.terminal_notifier:Could not find the colcon-terminal-notifier.app in the install prefix '/opt/homebrew'


[sw] Enable clippy::undocumented_unsafe_blocks lint

This lint requires a // SAFETY: ... comment above unsafe { ... } blocks which explain why the unsafe code is safe.
See https://rust-lang.github.io/rust-clippy/master/index.html#/undocumented_unsafe_blocks for more details.
Most of our code is already clean for this lint, but I've added two commits which fix or add these annotations.
The status.rs file just needed the comments to match the format clippy expects.
The xmodem.rs test file needed SAFETY comments writing which hopefully I've gotten right.

Do you know why are there so many unsafe blocks in xmodem.rs?

It's directly testing C code by replacing a couple of functions using #[no_mangle] and calling others directly through FFI. All FFI is unsafe, but it's also turning dyn Uart trait objects into pointers and back again when they go into and out of C.

CI failures unrelated.


[vip-split] [Split Expense] Cleanup all instances of "request" and "send money" in App

Part of the Add Split expense to global create project, design doc.
Please, implement following sections of the design doc:

Cleanup all instances of "request" and "send money" in NewDot

This project is handled by our experienced C+: @shubham1206agra and @getusha. Please, refrain from posting proposals

@mountiny Are we handling payments separately for this project or here? To see if we can close this one since it's already on prod

Closing!


"Acceptance Specs" vs "Request Specs"

I typically use Request Specs to test my controllers. Are the "Acceptance Specs" provided by this library intended/suggested to be a replacement for "Request Specs", or an addition to them? Perhaps something has been written on the topic already and I missed it?
Thanks!

I have previously used RAD for the full testing of my controllers but at this point I'd say go for only what you want to have documented. For instance just the happy path, and write a guide on types of errors the API in general will return and expand that with specific description on each endpoint if there are extra errors that might come back.

That's very helpful, thank you!


License

We should choose a license, shouldn't we?
http://choosealicense.com/

I agree. I don't know if we are using any GPL libraries - if we are, we should consider if we have to use GPL V3 or if we may use the Apache License.

Xposed bridge is Apache v2, does it mean we need to use it, too?
https://github.com/rovo89/XposedBridge/blob/master/NOTICE.txt

Not likely - it's more an issue you would see with GPL licenced libraries. I say let's go with Apache v2. I wonder if there are any tools that are helpful in inserting the licence in all the relevant files...

IMHO there's no need to insert the license in all relevant files, just add LICENSE.md to the root of the project...
For more information see:
https://github.com/blog/1964-open-source-license-usage-on-github-com
https://help.github.com/articles/open-source-licensing/

@elsesiy Thanks for your input, I completely agree. @LucasR93, you would probably be the right person to do that.

done, thanks @elsesiy and @sirlatrom


Research integration with DSC

We should research integration between the PI Security Audit Tools and DSC with PowerShell.  For progressive customers using the latest technology, this would allow them to integrate the tools into their normal workflow.
Since each audit check returns a result ($true or $false), we should be able to leverage the validation functions and Ensure $true when we evaluate the configuration via Test-DscConfiguration without changing the validations themselves.  While research should be done to evaluate all options, leveraging the capability to author Custom Dsc Resources could be the path of least resistance.  For example, a DSC Resource could be generated for each role.

There is the potential to dramatically accelerate the development of this tool and focus almost exclusively on the logic relevant to PI by leveraging DSCEA
The DSC Environment Analyzer Page has a wealth of information about the tool, including examples.  The tool is open source GitHub Repo and available for download packaged as a PowerShell Module from the
PSGallery.  The introductory TechNet blog post is a decent primer with examples of usage and reporting.  What really pushes this over the cliff into "must do" territory is the conversion tool to convert GPO and SCM baselines into DSC GitHub Repo.  Microsoft security baselines can be converted into a format for DSC and our PI configuration can be included in the same format.  This is huge, because we can rely on Microsoft as the experts on the platform to cover all platform related issues in their baselines and we can focus on our application specific guidance without requiring our users to run two separate tools.

#279 added the PISecurityDSC Module with proof of concept resources for configuring PI security a la DSC.  As such this effort is past the research phase. Future items should be addressed with GitHub issues along with other changes.


bad result on DTU

Hi,
thanks for open-souring this great work!
I ran the dtu validation script on the preprocessed DTU data from MVSNet, since you have not provided one. But the result is quite bad. I think there is something wrong with data, probably the camera parameters. Do you have any idea about that? Or could you release your pre-processed DTU dataset?
thank you in advance!

do you mean depth map evaluation by val.py or point cloud evaluation by test.py?
if it's depth map evaluation, the data from MVSNet is scaled and cropped beforehand. So you need to put --resize 640,512. To double check, you can plot the images (maybe just one channel because the images are normalized) after obtaining the data from data loader and see the cam center in intrinsic mat is roughly w/2 and h/2
if it's point cloud evaluation on test set, the data from MVSNet should be fine

thanks for the reply!
I meant the depth map evaluation.
Yes, your "dtu_val.py" has already resize the shape to 640,512. And the rectified images in the dataset has the same shape. However, in the camera files, the intrinsics seems wrong.
For instance, in "dtu/Cameras/train/00000000_cam.txt":
intrinsic
361.54125 0.0 82.900625
0.0 360.3975 66.383875
0.0 0.0 1.0
I am wondering if the intrinsics in camera files are already downscale with a factor of 4 already?
BTW, the naming convention in the "dtu_o_val.json" is not compatible with the official DTU dataset, which requires some minor modifications.

it seems that this cam file follows the size of depth map (1/4) instead of image. you may need to first upscale the cams 4x.

 Upscaling the cams 4x solves this issue!


Add provider-specific edit user permissions flow to provider_interface

Context
TBD
Changes proposed in this pull request

Guidance to review
TBD
Link to Trello card
https://trello.com/c/GU90aVjA
Things to check

[ ] This code doesn't rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

I get a 400 if I try to remove all permissions:

Adam confirmed that "View applications" should only appear when there are no permissions assigned and that the wording should be The user will only be able to view applications

...and on the edit screens in the same sitch will read ‘The user can only view application’

I get a 400 if I try to remove all permissions:

Of course, no permissions leads to no :provider_interface_provider_user_permissions_form params, which is required. I've fixed this by adding a hidden field :-\ Any better ideas?


no such option: --jarpath

following the README to specify a custom jar path on installation I get a 'no such option: --jarpath' error.
the command i used:
pip install iplantuml --jarpath /usr/local/bin/plantuml.jar

I'll take a look tomorrow morning. Thanks for the report!

See the latest readme for proper instructions.


Change esprima link in dependency

To fix this issue (in CodeCombat):
https://github.com/codecombat/codecombat/issues/2853

I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)

One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error :

This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.

Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.


[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] Send Money - Arrow is missing on date and merchant field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: no ( send money just implemented)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697005474290679
Action Performed:

Click on FAB and select send money
Enter amount and select user
Click on show more

Expected Result:
It should show arrow icon beside date and merchant
Actual Result:
It does not show arrow icon
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/32d484dc-d269-4160-abad-874f496c7d6e

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017f1148f05a8f4e87
Upwork Job ID:<PHONE_NUMBER>336138240
Last Price Increase: 2023-10-11

Taking this internally

@alexpensify only $50 needed for @gadhiyamanan for reportinga

No need for the checklist, deploy blocker was clear
https://github.com/Expensify/App/issues/29330#issuecomment-1763366152

No need for the checklist, deploy blocker was clear
https://github.com/Expensify/App/issues/29330#issuecomment-1763366152

@alexpensify only need to pay $50 to @gadhiyamanan

Here is the payment summary:

External issue reporter @gadhiyamanan $50
Contributor that fixed the issue N/A
Contributor+ that helped on the issue and/or PR N/A

Upwork Job: https://www.upwork.com/jobs/~017f1148f05a8f4e87
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: Payment was confirmed here https://github.com/Expensify/App/issues/29330#issuecomment-1775385575

@gadhiyamanan - please accept in Upwork and I can complete the process. Thanks!

@alexpensify offer accepted, thanks!

All set and paid in Upwork!


Docs.MS Release Updates for Azure.Communication.Common

Update docs metadata and targeting for release of Azure.Communication.Common

Docs Build status updates of commit 09ff024:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/communication.common-readme-pre.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add java.io.ObjectStreamClass leak cleanup

Class java.io.ObjectStreamClass has internal caches located in java.io.ObjectStreamClass$Caches, implemented as ConcurrentHashMap containing SoftReference values.
This cache is populated any time Serialization is used within the JVM.

Fixed by #126


DIA-3614: Replace Artifactory with Harbor

Type of Change

[ ] Bugfix
[x] Enhancement / new feature
[ ] Refactoring
[ ] Documentation

Description
Replace Artifactory with Harbor
Checklist

[ ] Add relevant labels (for example type of change or patch/minor/major)
[ ] Make sure not to introduce some mistakes
[ ] Update documentation
[ ] Review the Contributing Guideline and sign CLA
[ ] Reference relevant issue(s) and close them after merging

Please don't release this change yet and let's sync before


[WIP] [INFINITY-706] Add ZK lock to prevent multiple running schedulers

cc @nickbp for review
blocked on https://github.com/dcos/shakedown/pull/101

retest this please

cc @nickbp ready for re-review

@nickbp ready for re review


Correlate flows with CiliumNetworkPolicies

Using GetRealizedPolicyRuleLabelsForKey, lookup policy labels for a flow using the: direction, endpointIP, remoteIdentity, protocool and destination port. After getting the labels, reconstruct the policy name and namespace using the well-known policy labels.
Relates to https://github.com/cilium/hubble/issues/1100
Closes https://github.com/cilium/cilium/issues/26438.
Reviewers note: The protobuf field numbers may look arbitrary, however, this is a port of a feature we maintained internally, so for compatibility, it would be ideal to reuse the existing protobuf field names and numbers.
Correlate flows with CiliumNetworkPolicies

/test

/test


wait-for-bootstrap: use either node-0 or node-1 to help with deadlocks.

So, after the structural changes to values files just merged in, I've restructured this to use $NODES rather than $CHAIN_NAME. It's still filtering for the configured bootstrap hosts without making assumptions.

I've made this address #161 as a drive-by.

Make new PR.


KBFS Keybase.dmg REALLY doesn't do anything

Downloaded the file after being invited to the KBFS trial.
Moved it to my Applications folder. It still looks like Keybase.dmg.
Double-click, I get an error message. "Can't open image. Keybase.dmg Image not recognised."
Same if I double-click where the file is downloaded. DMG isn't recognised as an install image. Can't be mounted.
Tried downloading a few times, using different browsers, but getting the same (not working) result.
Updated homebrew version, but that doesn't include KBFS.
Eventually I figured out a way to get around this.
I used Extractor to unpack the DMG and then I could add Keybase to my apps and it seems to work fine now.

Thanks for the report, this is fixed now.

Oops, yeah, our build script had a bug yesterday where it was copying over the zip to the dmg path... which is why you were able to extract it... The zip and dmg both contain the same Keybase.app so you should be ok.


Logger calls will execute functions even though the LOG_LEVEL is masked

Here's an example:
#if LOG_LEVEL >= LOG_LEVEL_DBG
static char *sprint_token(const u8_t *token, u8_t tkl)
{
...
}
#endif

Then later I have code which looks like:
LOG_DBG("observer '%s' removed", sprint_token(token, tkl));

When DBG is =n, I see the following warnings:
zephyr/subsys/net/lib/lwm2m_sock/lwm2m_engine.c:550:3: warning: implicit declaration of function 'sprint_token'; did you mean 'sprintf'? [-Wimplicit-function-declaration]
   sprint_token(token, tkl), lwm2m_sprint_ip_addr(addr));
   ^

The behavior has changed here from SYS_LOG where SYS_LOG_DBG ends up as a no-op.

thats a "feature", we are using IS_ENABLED AFAIK.
just remove the #if LOG_LEVEL >= LOG_LEVEL_DBG around sprint_token.
We already found countless log statements that never worked because they were ifdefed like that or were never evaluated.

Won't a needless call to sprint_token will be made if logging is enabled?  This doesn't seem like good behavior.

The compiler should optimize away the sprint_token() so there should be no issue here. Closing this atm, re-open if you think this is incorrect.

I'll just submit the compile warning fix for LwM2M as was discussed.


Switch to clang-format 5.0

We should update clang-format 5.0 if only for the ReflownComments option: Comment reflow support added. Overly long comment lines will now be reflown with the rest of the paragraph instead of just broken. Option ReflowComments added and enabled by default. Right now, when the comment is too long, clang-format breaks the comment but sometimes create sth like this:
// Such a great comment! I
// know.
// This is unbelievable!

Sure, why not. Just need to add llvm-5 to Spack.

-1 for Spack
We are using the LLVM PPA in our Dockerfile.  See here.

Regardless, Bruno correctly flagged this as Low Priority.  This is something we want to do eventually but we should not waste any time on it for now and focus on meeting our milestones ;)


Large screen device

This PR does the following:
. made changes in the header section for the large-screen device
. made changes in the home section for large-screen device
. made changes in the services section for the large-screen device.
. made changes in the portfolio section for the large-screen device.
. add the swiper feature to the portfolio section for the large-screen device
. made changes in the contact section for the large-screen device

I removed all the comments as mentioned in the preview


Return error from Uploader::put on checksum mismatch

Description of change
This changes the way MP treats SSE settings checksum mismatch in case when it occurred before the start of the request. Previously MP paniced, the new behaviour is to return an error.
Relevant issues: https://github.com/awslabs/mountpoint-s3/issues/534
Does this change impact existing behavior?
No, SSE-KMS is behind a feature flag.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Seems like we can probably write a unit test for this case now? We could add a #[cfg(test)] method to fs::ServerSideEncryption that corrupts the checksum, and then put a unit test in upload.rs that calls that method at the right time (might need Arc::get_mut for that) to inject the corruption.
(With a little refactoring we could probably also do the same for the complete case? But that might be harder).


.babelrc doesn't have present-env keys double quoted

Yeah! Noticed this too recently, was surprised it still works. Is this handled with the Storybook v4 updates you were working on?

@joshblack I was gonna leave it for someone for Hacktoberfest but I think most folks are prob done by now.


Can this be used for centos 7 ? Thanks

I'm not sure. I've set dnf for the package manager modules, that isn't supported on 7.
You could try it changing dnf to yum.
I see mongodb itself supports rhel 7 still, so you can fiddle around w version numbers as well.


use packr for config.yaml

Had to move config.yaml to a separate directory, as packr needs a directory as input, and every file in that directory ends up in the binary (so root directory is a bad idea).

Fixes #94 and #93


Update tool_brush.gd add min brush size

Fixes strange brush behavior when drawing from a graphics tablet when the pressure on the stylus is low enough that the actual brush size is less than 1 pixel
We're talking about this strange brush behavior:

Adds a new setting for the brush and eraser tools:

Known "bugs":
"Min Size" - not limited by the maximum threshold equal to "Size"
It follows from this that if “Min Size” is greater than “Size”, then “Min Size” will have priority.

LGTM! But please clean up temporary stuff. There's also other brush-like tools.
Do you think it's worth changing this to make width go from minsize at minimum pressure to size at maximum, linearly via lerp(min, max, pressure), instead of all pressure levels below minimum giving the minimum width?

LGTM! There's also other brush-like tools, I'll edit this after merge.
Do you think it's worth changing this to make width go from minsize at minimum pressure to size at maximum, linearly via lerp(min, max, pressure), instead of all pressure levels below minimum giving the minimum width? This could also "fix" the unconstrained minsize issue.

Sounds like a good idea.  To be honest my implementation is a bit rough

I was offered a replacement
var radius = max((brushsize * 0.5) * (pressure if pen_flags[0] else 1.0),(brushminsize * 0.5))
on
var radius = remap(((brushsize * 0.5) * (pressure if pen_flags[0] else 1.0)), 0.0, (brushsize * 0.5), (brushminsize * 0.5), (brushsize * 0.5))
In the paint function
This should solve the unused push in my previous implementation.

Look overengineered, but good. Thank you!

Interesting behaviour:


[BEAM-6247] Remove deprecated module “hadoop-input-format”

This module hadoop-input-format was deprecated in Beam 2.10 (3 releases ago), so now it's time to remove it completely to avoid additional support and Jenkins resources consuming.  All Hadoop Input/Output Format functionality is implemented in hadoop-format which should be used instead.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Java HadoopFormatIO Performance Test

Probably worth updating too website/src/documentation/io/built-in-hadoop.md

Run Java HadoopFormatIO Performance Test

@iemejia

Probably worth updating too website/src/documentation/io/built-in-hadoop.md
I wanted to update it once we will release it without this deprecated module to avoid a confusion.

Run Java HadoopFormatIO Performance Test


Colab Directory Path Issue with image to 3d.

FileNotFoundError                         Traceback (most recent call last)
 in <cell line: 4>()
2 guidance_scale = 3.0
3
----> 4 image = load_image("example_data/corgi.png")
5
6 latents = sample_latents(
2 frames
/usr/local/lib/python3.10/dist-packages/blobfile/_context.py in BlobFile(self, path, mode, streaming, buffer_size, cache_dir, file_size, version)
919                 raise Error("Cannot specify cache_dir for streaming files")
920             if _is_local_path(path):
--> 921                 f = io.FileIO(path, mode=mode)
922                 if "r" in mode:
923                     f = io.BufferedReader(f, buffer_size=buffer_size)
FileNotFoundError: [Errno 2] No such file or directory: 'example_data/corgi.png'

You need to upload an image and add it's path there.

Clone the directory or get the images from https://github.com/openai/shap-e/tree/main/shap_e/examples/example_data

Nice.  Thanks.


Cannot read property 'original' of undefined

点击鼠标右键的时候，生成菜单错误
When clicking the right mouse button, a menu error is generated

我使用的是 vue-cli3，配置如下
I am using vue-cli3, the configuration is as follows

It seems your monaco-editor had some errors. You can remove monaco-editor-esm-webpack-plugin and test the contextMenu

I have same issue.
contexstMenu work nice without monaco-editor-esm-webpack-plugin

I have same issue.
contexstMenu work nice without monaco-editor-esm-webpack-plugin
EDIT
Finally, I'v omitted rules in webpack conf :
rules: [
  {
    test: /\.js/,
    enforce: 'pre',
    include: /[\\\/]monaco-editor[\\\/]esm/,
    use: MonacoWebpackPlugin.loader,
  },
],
plugins: [
  new MonacoWebpackPlugin({
    /**options*/
  }),
],

All working nice now.

Is there a complete configuration code?

I have same issue.
contexstMenu work nice without monaco-editor-esm-webpack-plugin
EDIT
Finally, I'v omitted rules in webpack conf :
rules: [
  {
    test: /\.js/,
    enforce: 'pre',
    include: /[\\\/]monaco-editor[\\\/]esm/,
    use: MonacoWebpackPlugin.loader,
  },
],
plugins: [
  new MonacoWebpackPlugin({
    /**options*/
  }),
],

All working nice now.

好样的，我用React+craco，用你的方法也可以了
Great, I am using React+craco, and it works in your way

@yinyoude 你是怎么解决的？我去掉了webpack rules一样报这个错误

@byte-voyager @yar2001
Hi, Why omit rules?


Idea: Exclusion performance

Hi again :)
I 'm finding out performance improvements.
in my case, there are many excluded folders. I'm excluded foldes including past year's photos yet synchronized.
I think that "exclude" method can be improved replacing:
https://github.com/oPromessa/flickr-uploader/blob/956175ec01de5dcf898215b94993be6902eab098/uploadr.py#L1444
by
`
.....
os.walk(FILES_DIR, followlinks=True):
            # We want to exclude folders, It's a waste of time to check every time files included in a  exclued folder
            if os.path.basename(os.path.normpath(dirpath)).encode('utf-8') in EXCLUDED_FOLDERS:
                dirnames[:] = []
                filenames[:] = []
                logging.warning('Folder {!s} ignored.'
                    .format(os.path.basename(os.path.normpath(dirpath)).encode('utf-8')))

            for f in filenames:
                filePath = os.path.join(dirpath, f)
                #if self.isFileIgnored(filePath):
                #    logging.debug('File {!s} in EXCLUDED_FOLDERS:'
                #                .format(filePath.encode('utf-8')))
                #    continue

`
Inspired by: http://cyluun.github.io/blog/manipulating-python-oswalk
I hope that will be useful .
With the last version and my fix, the performance is fantastic !!.

Thanks. Performance of V2.6.7 is much better but, yes, when you have a large number or sizeable EXCLUDED_FOLDERS, I agree it can still waste some time going thru them. Will take a look at this code!

Thanks. Available on V2.7.0


Bug, when click on btn - form run submit

I use whis module in form html element.
When btn select clicked - form submitted.
It's quick fix: set button type="button"

Hello, @amcdnl, is there a reason, why PR for this issue isn't merged yet?

Duplicate of #503.


H7100 Oscillate Feature

What issue do you have? Please be as thorough and explicit as possible.
H7100 tower fan speed control is available. Oscillate switch does not function or indicate oscillate status. Can begin oscillation occasionally from off, but switch does not show oscillation status or ability to end oscillation. Switch will “engage” in HomeKit then immediately disengage.
Details of your setup.

(1) Homebridge UI-X

Which version of Homebridge/HOOBS do you have?

1.6.1

Which platform do you run Homebridge/HOOBS on (e.g. Raspberry Pi/Windows/HOOBS Box)?

Raspberry pi node.HS 18.16.0

Which version of this plugin (homebridge-govee) do you have? Has the issue started since upgrading from a previous version?
Most recent stable 9.0.2

Which Govee devices do you have that are causing issues? Please include product models if applicable.

H7100 42” tower fan

Please paste any relevant logs below.

ls] current speed [44%].
{6/8/2023,
3:16:35 PM (Goveel (Chilly Ball
ls] current speed [55%].
[6/8/2023, 3:16:46 PM] [Govee] [Chilly Bal ls] current state [offl.
[6/8/2023, 3:17:04 PM] [Govee] [Chilly Bal ls] current speed [3381.
[6/8/2023, 3:17:04 PM] [Govee] [Chilly Bal ls] current state [on].
[6/8/2023, 3:17:04 PM] [Govee] [Chilly Bal ls] current speed [55%].
[6/8/2023, 3:17:06 PM] [Govee] [Chilly Bal ls1 current swing [onl.
[6/8/2023, 3:17:06 PM] [Govee] [Chilly Bal ls] current swing [off].
[6/8/2023, 3:17:54 PM] [Govee] [Chilly Bal ls] current speed [3381.
[6/8/2023, 3:17:56 PM] [Govee] [Chilly Bal ls] current swing [on].
[6/8/2023, 3:17:56 PM] [Govee] [Chilly Bal
1s] current swing [off]
[6/8/2023, 3:18:01 PM] [Govee] [Chilly Bal ls] current swing [on].
[6/8/2023, 3:18:01 PM] [Govee] [Chilly Bal ls] current swing [off].
[6/8/2023, 3:18:06 PM] [Govee] [Chilly Bal ls] current swing [on].
[6/8/2023, 3:18:06 PM] [Govee] [Chilly Bal ls] current swing [off].
[6/8/2023, 3:18:12 PM] [Govee] [Chilly Bal ls] current swing [on].
[6/8/2023, 3:18:12 PM] [Govee] [Chilly Bal ls] current swing [off].
[6/8/2023, 3:18:13 PM] [Govee] [Chilly Bal ls] current swing [on].
[6/8/2023, 3:18:21 PM] [Govee] [Chilly Bal
Is1 current swing [off].
[6/8/2023, 3:18:30 PM] [Govee] [Chilly Bal
Is] current state [off].

I have observed the same behavior with my H7100 fan. The oscillate feature will toggle off immediately and not affect the fan's oscillation


Add locale to getOptions method in MenuLinkable

Helps when trying to get only specific locale pages in combination with your pages tool.
If you can find a better way to pass through the locale - please do, mine looks kind of dirty and not right - but the functionality should be there.

Forgot to run 'npm run prod' before getting this pull request through.

Hey! Thanks for the PR, it does make sense. I'm currently on a vacation and will look over it and merge it on sunday or monday.

I could not think of a better way either. Thank you!


document cannot be downloaded because file name includes blanks

Downloading a document retrieved by calling envelopes_api.get_document() fails if the file name contains blanks.

I apologize for the extreme delay in answering your question. We have reorganized our staff to help prevent these delays in the future.
I just tried your question with the Python code example launcher, and it worked fine to download documents with a space in the file name.
I suggest that you try the code example launcher yourself, then use its code as a model.
Also, the best place to ask these types of software questions about the DocuSign APIs and SDKs is stackoverflow with the docusignapi tag.
Thanks,
Larry


UIImagePickerController & Promise

UIViewController+Promise.swift, line 78 has the private method:
imagePicker<T>(UIImagePickerController, Bool, ()->(), (NSDictionary)->T) -> Promise<T?>
What is its purpose? As far as I can tell, it's never called?

I'm trying to call the method on line 90:
promiseViewController(vc: UIImagePickerController, animated: Bool = false, completion:()->() = {}) -> Promise<UIImage?>
But even when I explicitly cast the vc arg as a UIImagePickerController, the compiler chooses the method on line 68 instead:
public func promiseViewController<T>(nc: UINavigationController, animated: Bool = false, completion:(Void)->() = {}) -> Promise<T>
It works if I assign to a var like this:
let p: Promise<UIImage?> = promiseViewController...
Is there a better way to call the method and get the correct, overloaded version?

Thank you very much for this framework!

yes I think this needs deletion
yes, this is a bug in the compiler. UIImagePickerController inherits nav controller and this seems to confuse it. I did find a work around for this personally, but can't recall what I did. I'll try to remember.

Thank you @mxcl

Yeah, pretty sure my workaround was your workaround. Hopefully this will be fixed with Swift 1.2.


Testnet pairing

Hello,
When I set up my own btcpayserver I could pair, but when I run it on testnet (I created a store on testnet.demo.btcpayserver.org/) I get 400 Client Error: Bad Request for url: https://testnet.demo.btcpayserver.org/tokens
The error is on create_client
BTCPayClient.create_client(
                    host=settings.BTCPAY_SERVER,
                    code=settings.BTCPAY_SERVER_TOKEN)

Any ideas why? Is the server up to date?

If you're able to pair to your own server, than that would mean there isn't an issue with Python library itself. I presume the demo server doesn't allow pairing.


Bot accounts require clearer definition

The TOC has been making room for working groups to add bot accounts in #375, #378, and other PRs, but we haven't clearly defined what constitutes a bot account and how they should be managed. Since these bot accounts have broad write permissions to repos within a working group area or within the entire working group, they are effectively approvers by proxy within the working group. Working groups and their areas also often use them to generate or to transfer release artifacts, so they present an attractive target for supply-chain attacks. Consequently, their definition and access should be handled with an appropriate degree of care.
The TOC and the working groups should agree on guidelines for:

What kinds of accounts should and should not be used as bot accounts
Which WG members should and should not have access to credentials for the bot account based on its scope in the WG
Where credentials for the bot account should be stored to promote inclusive and transparent management within the working group
What the process for adding and removing bot accounts should be
Whether bot accounts should use 2-factor auth, if possible within the constraints of automation or WG/area joint management

@cloudfoundry/wg-leads: the TOC would like to hear from you and your groups' approvers about what you're currently doing with bot accounts, so we can agree on some common guidelines for them as above. Thanks!

We use them in CI to:

clone repositories;
call the GitHub API for a variety of reasons:

poll for new PRs;
apply a special label to PRs that we identify as coming from approvers (this allows us to test PRs in CI safely);
poll for new releases of dependencies;
create new releases of our own;
set commit statuses.

FYI, Cryogenics is using bots just as @gcapizzi described in the comment above.

Thanks, @gcapizzi and @dlresende ! We'd also like to hear more about how you're administering the bot accounts and how you think the WG or area should manage credentials and authentication for them, in the interest of setting guidelines for WGs as outlined above.

Same for the ARD WG, we have a few bots for cloning repos, pulling PRs and creating new releases.

This is still revenant and the TOC plans to look into this.


Transfer the llvm npm name

I can't help but notice you stopped working on this project.
I also noticed that it is out of date, and that it has been forked under llvm-x on npm. Those that forked it added a mere two commits on top of your work, the most significant (although not that significant) being https://github.com/guangwong/node-llvm-x/commit/72d727024be41bb7e20241120086f2a6e058feb5.
Would you consider either pulling this commit and submitting a new version, or transfering the llvm name to them?

I found @guangwong released his package as https://www.npmjs.com/package/llvm-x ... sounds strange.


It would be good to have a commissioning example.

Not sure where this goes - but in the total system level documentation these things are missing:
a) How to use the Thread Commissioning app to configure the border router it self.
b) How to "de-commission" the Border Router - sort of "factory reset" back to not-commissioned state.
c) starting with the commissioned border router, but it is a singleton. Example should show how to configure a CLI device to act as joiner, and then commission that CLI device with the Commissioning app.
As a general outline:
Step 1 - Create a network using the CLI example.
Step 2 - Using the BR-WEB-SERVICE - Join that network.
Step 3 - Use the Openthread Commissioning Application to find the border router.
Step 4 - Select and tap on the OpenThread Border Router
Step 5 - The Commissioning App requests a pass phrase
What needs to be documented is: Where/how is this pass phrase created.
Same would apply to a CLI device that you want to "join/commission"

@DuaneEllis-TI
Seems like the only thing here that's missing from https://openthread.io/guides/border_router/ is
b) How to "de-commission" the Border Router - sort of "factory reset" back to not-commissioned state.
Can you check the updated docs and confirm?

Closing stale issue.