The command creating the cluster never ends when we run: "idpbuilder create --package-dir ./pkg/controllers/custompackage/test/resources/customPackages/testDir"

What is your environment, configuration, and command?
The command creating the cluster never ends when we run the command idpbuilder create --package-dir ./pkg/controllers/custompackage/test/resources/customPackages/testDir and to exit it is needed to use ctrl-c. Is it a normal behaviour ?
1.7023726693576362e+09  INFO    controller.localbuild   Gitea is ready! {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": ""}
1.702372669357645e+09   INFO    controller.localbuild   installing bootstrap apps to ArgoCD     {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": ""}
1.702372669357651e+09   INFO    controller.localbuild   Ensuring embedded ArgoCD Application    {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": "", "name": "argocd"}
1.702372669377444e+09   INFO    controller.localbuild   Ensuring embedded ArgoCD Application    {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": "", "name": "nginx"}
1.702372669386388e+09   INFO    controller.localbuild   Ensuring embedded ArgoCD Application    {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": "", "name": "gitea"}
1.702372669392459e+09   INFO    controller.localbuild   Ensuring embedded ArgoCD Application    {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": "", "name": "backstage"}
1.702372669397901e+09   INFO    controller.localbuild   Ensuring embedded ArgoCD Application    {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": "", "name": "crossplane"}
1.702372669404875e+09   INFO    controller.localbuild   Checking if we should shutdown  {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "Localbuild", "name": "localdev", "namespace": ""}
1.7023726800948448e+09  INFO    controller.custompackage        reconciling custom package      {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "CustomPackage", "name": "app-my-app", "namespace": "idpbuilder-localdev", "name": "app-my-app", "namespace": "idpbuilder-localdev"}
1.702372680108734e+09   DEBUG   events  Normal  {"object": {"kind":"CustomPackage","namespace":"idpbuilder-localdev","name":"app-my-app","uid":"29ce4a22-129b-45fc-8d9a-17606da9a02d","apiVersion":"idpbuilder.cnoe.io/v1alpha1","resourceVersion":"1092"}, "reason": "reconcile success", "message": "Successfully reconciled"}
1.7023726846419258e+09  INFO    controller.gitrepository        reconciling GitRepository       {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "GitRepository", "name": "my-app-busybox", "namespace": "idpbuilder-localdev", "name": "my-app-busybox", "namespace": "idpbuilder-localdev"}
1.7023726846420748e+09  INFO    controller.gitrepository        reconciling     {"reconciler group": "idpbuilder.cnoe.io", "reconciler kind": "GitRepository", "name": "my-app-busybox", "namespace": "idpbuilder-localdev", "name": "my-app-busybox", "dir": {"path":"/Users/cmoullia/code/cnoe/fork-idpbuilder/pkg/controllers/custompackage/test/resources/customPackages/testDir/busybox","type":"local"}}
1.7023726847186098e+09  DEBUG   events  Normal  {"object": {"kind":"GitRepository","namespace":"idpbuilder-localdev","name":"my-app-busybox","uid":"6ee1c23a-2c21-4eb3-9f18-a67871329279","apiVersion":"idpbuilder.cnoe.io/v1alpha1","resourceVersion":"1114"}, "reason": "reconcile success", "message": "Successfully reconciled"}

What did you do and What did you see instead?
git clone the project
make
./idpbuilder create --package-dir ./pkg/controllers/custompackage/test/resources/customPackages/testDir
Additional Information. Logs.
N/A

This is an intended bahaviour introduced with the custom package flag. Reasoning being that when you specify a directory,  I wanted the controller to continuously sync the contents of the directory to the git repository. But I do see use cases where this may not be the desirable behaviour. Perhaps we should consider adding an additional flag that controls if the CLI should exit regarldess of other flags.

Reasoning being that when you specify a directory, I wanted the controller to continuously sync the contents of the directory to the git repository

This is not a bad practice that the controller waits but then we should add a message like `Controller is currently deploying ArgoCD resources. To exit please do: ctrl-c"
Remark: As ArgoCD will deploy the resources, then that should be great if the controller could every 5-10s shows the status of the sync. If we do that then the users will be aware about what it happens: good or bad and will be very happy to use idpbuilder ;-)
@nabuskey

I think this goes back to a question of like "What mode do you want to run it in?". In my head there's a couple modes that are possible for right now:

Reconcile for life mode - Where CNOE CLI always is running and never stops until exits and while validate any changes made are reconciled with what is actually deploy.
Get me up - Where CNOE CLI runs just to get everything into a desired state and exits once done. This would make it so any changes to directory done locally would not be reflected unless command was rerun.

I do wonder if eventually instead of needing CNOE CLI to run forever if we made it so custom package additions/removals updated the KIND Config to mount the directory https://kind.sigs.k8s.io/docs/user/configuration/#extra-mounts and had CNOE run as an operator if we could get away with CNOE being able to reconcile local changes that way....

To avoid to develop a too complex client (aka idpbuilder), we should keep the design of the solution as smart as possible. As the purpose of the tool (until now) and command idpbuilder create is to create a kind cluster and install ingress + gitea + argocd then the process should exit when they are healthy.
As the parameter --package-dir allows to pass Applications CR to ArgoCD, then this is the job of ArgoCD to sync the resources and by consequence, the user should then look using argoCD CLI or UI if the additional packages have been well deployed.
Nevertheless, end of the process to install/sync the core components resources, then a more human readable message should be displayed and explaining to the user what they should do. I'm much more in favour to exit like it happens when you use: kind, minikube even if pods are not yet running.

yeah +1 from me on @cmoulliard 's suggestion.
the goal of the idpbuilder CLI should be to bootstrap. it shouldn't break the promise of regular GitOps best practices. That is to say, git should continue to be the source of truth.
Right now, it appears that for custom packages, the source of truth becomes the local directory, and this breaks the GitOps contract.
I very much like the idea for the idpbuilder to just bootstrap the behavior and exit. if you need to make changes to your local directory stuff, OR to add new local custom packages, you run the idpBuilder cli again with updated list of package directories, etc. for existing packaegs, a re-run could override the content of the correspnding GitRepos and that is ok, since it was asked to.

I do wonder if eventually instead of needing CNOE CLI to run forever if we made it so custom package additions/removals updated the KIND Config to mount the directory https://kind.sigs.k8s.io/docs/user/configuration/#extra-mounts and had CNOE run as an operator if we could get away with CNOE being able to reconcile local changes that way....

This was what I thought of before as well, but I was not sure of implications associated with this. What happens if we want to run multiple instances?  Are there performance implications when multiple deeply nested and subnested directories are mounted? Do they work for non-docker providers? I didn't have answers for them. So I went with the simplest solution BUT we can definitely re-visit.

I very much like the idea for the idpbuilder to just bootstrap the behavior and exit. if you need to make changes to your local directory stuff, OR to add new local custom packages, you run the idpBuilder cli again with updated list of package directories, etc. for existing packaegs, a re-run could override the content of the correspnding GitRepos and that is ok, since it was asked to.

Yeah I am inclined to revert it so that the default behaviour of CLI  is to exit as soon as bootstrapping finishes. We can provide an optional flag to not exit.

Yeah I am inclined to revert it so that the default behaviour of CLI is to exit as soon as bootstrapping finishes. We can provide an optional flag to not exit.

+1

I think this is not a bad thing for local development purposes. I personally hate having to push every single change to a repo when trying to get things working. But I agree otherwise, the core purpose of idpbuilder should be to bootstrap a ready to use cluster with whatever you want.

The compromise could be to push to the Gitea server the ArgoCD CR and resources (= what is defined under a package-dir). As the purpose of IDPBuilder is also to provision the cluster with packages A, B, C needed for backstage components X, Y, Z , then it will be needed that the users know how to describe what their IDP should be (= package A, B, C etc) and how to provision the cluster using our idpbuilder ...

I think this is not a bad thing for local development purposes. I personally hate having to push every single change to a repo when trying to get things working. But I agree otherwise, the core purpose of idpbuilder should be to bootstrap a ready to use cluster with whatever you want.

What if we had a second command that could be run that could sync to gitea. I think that separating out that functionality would be appropriate. We could even have a flag that would output the gitea git remote urls for the packages on stdout so that they could be automatically passed in to a script designed to automatically sync commits from local working copies to remotes. There are possibly hundreds of these out on the internet: https://github.com/GitJournal/git-auto-sync
for example:
idpbuilder create --package-dir ./pkg/controllers/custompackage/test/resources/customPackages/testDir --output-git-remote-urls | git-auto-sync ./pkg/controllers/custompackage/test/resources/customPackages/testDir

+1 on @nabuskey 's suggestion about separating this out into its own issue. I created #123 to track this.


Update postgresql.md

From https://www.postgresql.org/support/versioning/

@anayrat thank you for the first PR and the support of the project. I have verified your changes on the website and everything is correct.
@rodo thank you for the review


[Bug]: ModuleNotFoundError: No module named 'towhee'

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
After the installation of towhee is completed, it cannot be imported, nor can it be reinstalled
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93):
- OS(Ubuntu or CentOS):
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

@aiot-tech
could you run "pip show towhee"?

pip show towhee
The output is as follows:

Name: towhee
Version: 0.7.2
Summary: Towhee is a framework that helps you encode your unstructured data into embeddings.
Home-page: https://github.com/towhee-io/towhee
Author: Towhee Team
Author-email<EMAIL_ADDRESS>License: http://www.apache.org/licenses/LICENSE-2.0
Location: /root/miniconda3/lib/python3.9/site-packages
Requires: numpy, tqdm, requests, tabulate, ruamel.yaml
Required-by:

@aiot-tech
Now the latest is 0.7.3, could you please run "pip uninstall towhee" then "pip install towhee" and check whether it is 0.7.3 now.
And maybe you need pay attention which python env you are using if you have several python versions in your system.
maybe "python3 -m pip install towhee" could make sure you have the same python version when you running "import towhee" in python3 terminal.

 Thx a lot:)


mergeConfigs removes default Uno preset

UnoCSS version
0.52.7
Describe the bug
Trying to merge 2 configs. Currently if no preset explicitly specified, the presets array will be empty.
// uno.config.ts
import baseConfig from './base/uno.config';
import commerceConfig from './commerce/uno.config';

export default mergeConfigs([baseConfig, commerceConfig]);

Reproduction
https://stackblitz.com/edit/github-mxkbee-stgpe9?file=uno.config.ts
System Info

Operating System: Linux
Node Version:     v16.14.2
Nuxt Version:     3.5.2
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      extends
Runtime Modules:  -
Build Modules:    -

Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

No, UnoCSS is an atomization engine, its ability to work depends on your configuration.

By the way, thats just thoughts, having presetUno() explicitly is also fine :)

makes sense to not generate field if it is not present in any of the configs

I agree with this. Only return real data and not empty arrays because an empty array is not the same as undefined. In this case the empty array is a signal to override the default preset.
@enkot this shouldn't be too hard. Want to try a PR?

Also thinking about merging transformers by name, but it is not clear what to do in this case:
mergeConfigs([
  {
    transformers: [
      {
        name: 'foo',
        async transform() {},
      },
      {
        name: 'bar',
        async transform() {},
      },
    ],
  },
  {
    transformers: [
      {
        name: 'bar',
        async transform() {},
      },
      {
        name: 'foo',
        async transform() {},
      },
    ],
  },
])

and if it makes sense at all 🤔


[FEATURE] create login page

Initial

Validation

Updated Design Spec
Initial

Validation

I would like to work on this too.

This is far from being done, but I followed a tutorial, and got this far. Any thoughts/next steps?

@Devtinator have you started any changes? @Abhispy007 are you able to self assign this if you are taking this on? Yes, please make a branch and we can review the changes you have. Then we can make it look like the designs as well and then merge.

So sorry, I haven't been able to working on it yet, I'm having issues starting the app locally on my PC, still trying to figure that out.

@JMStudiosJoe created a branch called create-login-page. I also created a draft pull request as well. I'm not sure if I was supposed to do that, feel free to delete the pull request if it's not needed for now.


add check if Node has Pods or not before deleting scheduled Pods on Node

What type of PR is this?
/kind bug

What this PR does / why we need it:
add check if Node has Pods or not before deleting scheduled Pods on Node
Which issue(s) this PR fixes:

Fixes #145
Special notes for your reviewer:
/label tide/merge-method-squash

I ran in my local and verified that no error is raised if click the delete button for Node that isn't scheduled Pod.
Thank you👌
/lgtm


Upgrading OpenCFP to Silex 2.x

This PR upgrades OpenCFP to work with Silex 2, per a twitter discussion I had with Chris a few months ago.
Numerous changes were made to accommodate the changes in Silex 2 and Pimple 3, such as updating method signatures to reference Pimple 3's Container when appropriate. Also, as Silex 2 services are "shared" by default, several service definitions were able to be simplified.
The tests pass for me, but this change is rather substantial, so I don't know how much trust can be placed on that.
I debated whether I should open the PR at all - until finally deciding that my progress needs feedback before I can spend more time on it.
Important Note:
The original ConfigServiceProvider dependency does not support Silex 2, so I modified composer.json to use a different source (my own fork).
Additionally, due to the way the container freezes services once instantiated, several places in the tests needed to be updated to "unset" the service before overriding it with a new object.

Hey @beryllium!
First, thanks a ton for all this work. We really appreciate it!
I intend to merge this, but need a little time to look at it with a closer eye. Passing tests are awesome, but as I'm sure you've noticed, there are plenty of tests that do weird things with the container and mocks.
In the meantime, some thoughts:
ConfigServiceProvider
I've been eye-ing Silex 2.0 and the issue it would cause for the ConfigServiceProvider for a while. Namely that the service provider repository looks unmaintained. That said, it's definitely a problem that once-solved, shouldn't need maintenance. My concern is that there are PRs/issues from 2 years ago on this topic with little sign of attention. I will reach out to Igor and see if he's interested in transferring maintenance responsibilities. If so, we can move the project here or wherever it makes sense. Alternatively, if we don't hear back, we have options:

This might be an opportunity to kill a dependency and just pull in the code required to do this. It's not much if we don't need formats other than YAML.
We could continue as-is and rely on your fork. I don't like this option (not because of the work) but because it complicates Composer dependencies. I'd rather see Silex-2.x compatible code go somewhere authoritative, if we don't bring it in. Perfectly fine relying on a fork for now though.

Remaining Tasks
You mentioned spending more time on this. What do you have in mind that needs addressing? If it's longer-running, I'd like to move this PR to another branch and work on getting everything straight there. That way, we can review smaller focused work rather than big-bang merge. It's also an opportunity to enumerate things that need to get done so that I can help you with it. That said, after I give this a closer look, I'd like to merge it somewhere rather than continuing to grow it.
Thanks again. Really awesome stuff.

I'm right there with you on the fork approach being non-ideal. That was one of the main reasons I held off submitting the PR. If it could go pure YAML, that would certainly simplify things - and eliminating code is generally a good thing. :)
As for spending more time on it - partly I am worried that the changes to the framework & components might have caused unexpected side effects that might not be surfaced from casual testing. It might help for someone with more experience than myself at OpenCFP administration  to take a look to make sure the switch hasn't borked it up.
On the flip side, I suppose the move-fast-and-break-things ethos might apply here, but I'd suggest making some kind of "stable" release prior to that.

@beryllium This works for me. I've exercised every feature (lightly) in addition to having tests pass, as expected. I am changing the PR target to opencfp:silex-2.x to do some follow-up work on config and I'll plan on tagging you when I open the silex-2.x -> master PR. If you have any other stuff to send for this, send it to that branch and we'll get it in.


Fixed #28241 -- Added dotted path support to module_has_submodule

Ticket 28241
Enables module_has_submodule and autodiscover_modules to accept dotted paths.
Replaces #8611 which included support for python 2 (and therefore Django 1.8 to 1.11)
Note: I included an empty init.py in the dummy module I added for tests even if unnecessary in python 3 as there are still init.py files everywhere.

Is a test for the AttributeError case missing? I removed it and don't see any test failures.

Good catch, test added


Reset CMAKE_REQUIRED_FLAGS

Reset CMAKE_REQUIRED_FLAGS after each check to avoid the following
checks being influenced by the previous results.
Change-Id: I2e34f6127ef1c617f4eea363a2cb80bc49b3bcab
Signed-off-by: Richael Zhuang<EMAIL_ADDRESS>

Resetting CMAKE_REQUIRED_FLAG before it is unconditionally set is overkill... It should be only reset if we can't guarantee the contents are unconditionally overwritten.

@mtl1979 I don't see any negative sides to doing this. It helps us avoid future oversights causing strange regressions and keeps the Cmake code easy to read. Resetting the variable does not cost much cpu-time and is only a single line of code.

@Dead2 It doesn't remove the possibility that someone makes a patch that adds code to wrong side of the reset command... It doesn't actually make the code easier to read, it makes it more confusing for anyone who actually can use cmake properly.


dropbox: 3.12.6 -> 3.14.5 (release 15.09)

Also updates qt5 dependency to qt55, as per release notes: https://www.dropboxforum.com/hc/en-us/community/posts/205672126-Release-Candidate-3-14-5

Thanks! dropbox dying on every update is maddening.

Well, older releases sometimes still work for a while, but then stop working at some point and just show the update message. Better to keep ahead with the updates.


Bump to version 1.4 and update history section in README.md

What has been done?

Reference Releases page under History in README.md
Bump package.json version to 1.4

LGTM 😄

LGTM ;)

@thabemmz You can tag and write release information under Draft a new release at release page. If all goes well it will be automatically pushed to npm.


App version is "undefined"

Should get the version from package.json instead of APP_VERSION environment variable.

Still broken for linux-server


Add L2Boost algorithm

Please merge my great new code contribution.

Hey Bernhard, please don't change anything!


:sparkles: Add a space-framework.md file

This file should eventually become the design doc of the space-framework. For now it contains the text from the google doc maintaining the design doc.

Summary
Related issue(s)
Fixes #

I am not quite sure I understand the purpose of this document now.  At the moment it points to the design document and has a copy of a subset of that document?  I am not sure I understand the point of having a copy of a subset.  Is this something that will change very shortly, or are we talking about a long-term evolution?  When there are two copies of text this creates the problems of keeping them identical and which one do I review and where to readers go and why.

The existing document describes the space framework and that is great; we also need documents that address bigger pictures.  We need something that has the abstraction layer, space provider(s), provider adapter(s), kube-bind, and multi-cluster configuration management.  We need a document that outlines an incremental development plan, in more precision and detail than I currently see in #840 .  Or perhaps the issue is that I expect different substance.  I think we need a plan that has modest sized steps that can be merged into the main branch while maintaining the fact that said branch works for our current use cases.  This will involve first generalizations rather than "instead of" changes; old functionality can only start to be removed after we are satisfied with the new functionality.

The title of the linked Google doc looks mangled; it currently reads "cluster providerThe".

I think we need a high-level picture of how the software components relate, such as https://docs.google.com/drawings/d/1U5nwzHeSdpEufzOPmYX_8cIvNOUzRa3oOFuKqNS4smM .  That shows two things we might aim for.  The current reality is different, that needs to get the same sort of drawing.

Please also consider #931

@ezrasilvera to converge

Replaced with #1251


Feature: better CI support

Users can run PipeRider through the CI process, so users can get reports instantly when code/schema changes, pipelines are executed, or perform data quality checks periodically.

Users can use PipeRider to generate report files, but it was hard before to get the latest report files from the command line interface and perform follow-up actions in the CI automation process.
By implementing this feature, users can use PipeRider to:

get the location of output files of reports or comparisons
compare the most recent two reports easily

So users can upload the generated reports to AWS S3, send notifications to Slack, and perform other actions by using tools through the CI process.
Feature Design
Requirement

Users can get the location of output files of reports or comparisons.
Users can compare the most recent two reports without providing any input. (It is more convenient, and users don’t need to know how PipeRider works internally)
We can track if a report is generated by CI.

Non-goals

upload files for users. They should be able to upload via the tools they use.
send notifications for users. They should be able to send notifications via webhook or other tools.

Use Cases

Users can get reports instantly when code/schema changed, pipeline executed, or perform data quality check periodically.
Users can collect all reports in one place.
Data consumers can check the reports without running PipeRider or gaining data access.

User Journeys

User can use piperider generate-report -o $PATH to get the location of output.
User can use piperider compare-reports --last to generate a comparison report with the most recent two reports.

Milestones

[x] Users can get the location of output files of reports or comparisons.
[x] Users can compare the most recent two reports without providing any input.
[x] Track if a report is generated by CI.

https://github.com/InfuseAI/piperider/pull/324

https://github.com/InfuseAI/piperider/pull/314

https://github.com/InfuseAI/piperider/pull/310

released in https://github.com/InfuseAI/piperider/releases/tag/v0.5.0


Any other link for model download?

Hi,
I live outside China and I am not able to properly download the model weights from pan.baidu.com
is there any other links that I can use? If it's no trouble to you, could you upload it in this repo?
Thank you

Maybe you can try this:   https://github.com/Kyle-Kyle/baidudl with RPC download.
It is very fast.

@Perseus14 Here you go.
https://drive.google.com/drive/folders/1vlA6FjvicTt5GKvAfmycP5AlYxm4i9ze


Deprecate prisma-cli package on npm

The prisma-cli package can be confusing on the npm, it should either serve as a bridge like babel-bridge.0 or be retracted altogether.

This is done https://www.npmjs.com/package/prisma-cli


[Fix] DateInput: isTouchDevice should only be determined in componentDidMount

Fixes #335.

Coverage decreased (-0.1%) to 86.703% when pulling aebef0f68f11a429a8c721a112e5c6af04a08d3f on fix_dateinput_server_render into d58f6a90b2c88209db07e4b75a2831cd339fd1bb on master.

Coverage remained the same at 86.839% when pulling 18a439ee696613a196f8840c7ca95645b5f76542 on fix_dateinput_server_render into d58f6a90b2c88209db07e4b75a2831cd339fd1bb on master.

Coverage remained the same at 86.839% when pulling d978e54469f7e3484d4c01e1456817b3c8d7736a on fix_dateinput_server_render into 333bbe5b29ba1d8659e57b1bfea527ebc47baf1d on master.


Explore error cases caused by case changes when parsing schema

I don't know any exact cases, this ticket is about finding the different permutations.
When writing a module, you can use different cases for a name which then may get conflated as we standardise those names in the ftl schema.
I don't think we would error in schema parsing, so we'd end up with weird results...
eg:
type UserId string
type UserID int

var someDID = ftl.Secret...
var someDid = ftl.Secret...

I think this is related to #1482, in that we would disallow UserID and SomeDID.

Duplicate of #1482


Updated to reflect the new electron 1.1.0 changes

Not sure what the v8 version is so I couldn't add that

@amilajack this is updated automatically via the script/versions script which runs when we publish a new docs version.
I've done that in #279, thanks for bringing this up though.


Remove duplicate logging value

This is an exact copy of the config just above -- no real changes here
Fixes https://github.com/istio/istio/issues/13646

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
c003c608fbcc163a18ffcc1472da2ddbf00aa8b4
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
c003c608fbcc163a18ffcc1472da2ddbf00aa8b4
link
/test istio_auth_sds_e2e

prow/istio-integ-k8s-tests.sh
c003c608fbcc163a18ffcc1472da2ddbf00aa8b4
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Doesn't matter now, all work is on istio/installer

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Centralised struct to compute stack constraint flags

This PR introduces a struct in the AIR crate where all the individual stack constraint flags are computed to reduce multiplication and subtraction operation cost as suggested by @bobbinth in this PR.

@bobbinth- Thanks for the review!

It's now taking 181 Field multiplications which is a ~3x improvement over the case when there's no centralized struct for the operation bit calculation.
The benchmark on my machine with AMD Ryzen 5 3550H running Manjaro Linux is as follows:
time:   [411.59 ns 432.92 ns 456.21 ns]

Found 30 outliers among 100 measurements (30.00%)
19 (19.00%) low severe
7 (7.00%) high mild
4 (4.00%) high severe


Relative call ruined my CTF

Why is that callq PC relative? Capstone used to work, why did BAP break it?
But seriously, things like this are why the current QIRA is unusable, and I'm still stuck on 1.0

Yeah, Capstone would always display jumps as absolute whereas now BAP gives us the call as PC relative. We're aware of the issue and will fix it. We might have to do some string hacks because that's just the disassembly string. We do handle this in static itself, it's just not correct on the frontend.

you can thank @acama for this zweet bug ;-)

BAP from today has a native x86 family lifter. My next release will be about bap+qira, I'm going to add bap as static backend, since now it is quite good at cfg reconstruction and function finding (not only starts – both ends). Also, BAP now has an integration with IDA, so it can provide FLIRT info for QIRA.

your welcome :)

Tim fixed this. I'll be doing war games over spring break with QIRA so hopefully I can pick up on more usability issues. Sorry for the sad CTF experience!


Vendoring with large dependencies

We currently use Johnny Deps (jd) for dependency management. The general setup is that I have all of our dependencies in my GOPATH and they're all checked out to specific revisions. Therefore, there is a single copy of all of my dependencies. I can still get reproducible builds by checking out an older revision of my project and having jd checkout the proper revisions of the dependencies.
We have many repositories, and quite a few are referenced by multiple projects. What's a good way to vendor these dependencies using gb? I feel like using submodules would result in multiple copies of the same dependencies, which are probably also on the same revisions.

I recommend using git submodules, they come at no cost to the repo size as they are effectively the git version of a symlink.

Opps, I didn't mean to close this.

This looks like what I need: Git: Possible to use same submodule working copy by multiple projects?

Closing as answered.


Updated API doc for pull request #861

https://github.com/arnesson/cordova-plugin-firebase/pull/861
I've updated the API doc accordingly

@manuelsc thanks for the updates. I'll get a new version published in the next day or so.


Consider renaming module

When exporting with swift evolution support, the interface files generated are corrupted because the module name "Introspect" collides with the enum named "Introspect" resulting in errors:

Failed to build module 'Introspect' from its module interface; it may have been damaged or it may have triggered a bug in the Swift compiler when it was produced

'IntrospectionUIView' is not a member type of 'Introspect'

etc.
Maybe changing the module name to IntrospectKit? Or removing the enum altogether?

if you rename it, i recommend SwiftUIIntrospection instead of IntrospectKit, as it’s more specific and would go well in hand with Apple’s DispatchIntrospection.

Thanks for letting us know @mourke, and thank you for the naming tip @freyaalminde. SwiftUIIntrospection sounds like a winner.
I'll make a PR soon to vend the library by this new name while retaining the old name as well for current users, as I wouldn't want anyone's imports to break due to this drastic change. Then for 1.0 we'll remove the vended "Introspect" products altogether.

Update: the new module was released a few weeks ago and is now named SwiftUIIntrospect.


Can't load "content_scripts/content-0.js" ,Because it's not UTF-8 encoded

Create a project via :
 npx extension create my-extension --template=vue-typescript

and run npm run start

hi @John-Chan thanks for reporting.
Could you try running the React-TypeScript template to see if thee bug happens as well? I'm looking to know if the issue is template-specific.
npx extension create my-extension --template=vue-typescript

The React-TypeScript template cannot run due to icon path issues( #87), and it's uncertain whether there is an issue with UTF-8 encoding.
npx extension create my-extension-react --template=react-typescript

我猜测是<EMAIL_ADDRESS>中的 output.cssHeadDataCompression 选项在 production 环境启用导致的 content-0.js 包含了一个无法识别的字符，我尝试关闭 output.cssHeadDataCompression 选项可以避免这个问题，我也在<EMAIL_ADDRESS>中发现了一项变更，最新的版本将不会出现无法识别的字符。
https://github.com/webpack/webpack/blob/34e2561addb0f65a7a6fb0ce7ae1aea4cd1d599f/lib/css/CssLoadingRuntimeModule.js#L227

@OSpoon thanks for investigating! Did updating webpack solved the issue? I'm not able to reproduce

@cezaraugusto, I reproduced this issue using the code of the main branch. For this inssus, I tried two solutions:

To disable the output.cssHeadDataCompression option.

Upgrade webpack to the latest version.

thanks @OSpoon, PR opened to bump webpack

@John-Chan could you please try again? I just released v1.8.0 which should fix it.
npx<EMAIL_ADDRESS>start my-extension --template=vue-typescript

Also please note that start will bundle your extension in production mode without live-reload support. For development you want to run the dev command.
Let me know if that works for you so we can close this one. Thanks!

Compared to before, vue templates no longer pop up utf8 encoding errors, but the project still can't start successfully because of the icon path problem. Maybe we need to wait for the icon path issue to be resolved and try again.

@John-Chan @OSpoon happy to share that this bug is finally fixed.
# Ensure you run @latest as npx cache system can trick you are not
npx extension@latest create my-extension --template=vue-typescript

If I'm wrong, let me know!

The ICON path issue still exists, manually copying the file to the dist/chrome/icons path works. So the utf8 encoding issue should be fixed.

hi @cezaraugusto, webpack-run-edge-extension, webpack-run-chrome-extension and webpack-browser-extension-manifest were last updated 12 days ago, Do you need to release the latest version?

@OSpoon just bumped all three versions but can't repro the bug yet. do you?

@cezaraugusto, I don't see the new version of webpack-browser-extension-manifest

Oops my bad, released now

@cezaraugusto Regarding the problem of the path in the win environment, I have verified it, and please @John-chan can try again in his free time, thank you very much ~

@cezaraugusto Regarding the problem of the path in the win environment, I have verified it, and please @John-Chan can try again in his free time, thank you very much ~

Great! It's works

thanks for confirming @John-Chan! feel free to report anything else you find weird.
@OSpoon thanks for digging into it! 💯
Closing as fixed 🎉


cannot configure starting directory in GUI when its default value is set to null

Windows Terminal version (or Windows build number)
10.0.19042.928 1.7.1033.0
Other Software
No response
Steps to reproduce
First, Set
    "profiles":
    {
        "defaults":
        {
            "startingDirectory": null
        },
...

This makes the default starting directory to the parent process, which is my expected behaviour.
After that, however, the starting directory for individual shell cannot be configured in the GUI. The Browse button is grayed out. See the screenshot:

Expected Behavior
The starting directory should be configurable in the GUI.
Actual Behavior
See Steps to reproduce.

Does #8904 covers this?

Hopefully it does. I will wait for the it to be resolved.

Yea, it sounds like #8904 will take care of this
/dup #8904

However, what we have today in 1.7 is broken and needs to be fixed.
I'm going to use this bug to track fixing it for servicing, as I am not going to backport a design change :smile:


Lag metric anomally

After the cluster configuration changed, lag metrics continuously increased.

This behavior causes false alerting behaviour! We need to debug and solve it asap!

At first glance, it seems it is related to cluster change but unfortunately, it's not. We saw same behaviour 🤔 We are looking to understand why

Fixed via this commit by Eray arslan <3


Simplify checks for defined properties since Jinja2 can be configured to avoid that issue

Currently there are a lot of excessive conditions when testing for defined properties in component macros. These checks were added so that the component macros would work in Jinja2 (as well as Nunjucks):
{% if foo is defined and foo.bar is defined and foo.bar.baz %}

It seems that Jinja2 can be configured to operate in a similar way to how Nunjucks operates (see https://jinja.palletsprojects.com/en/3.0.x/api/#jinja2.Undefined).
These checks can now be simplified:
{% if foo.bar.baz %}

Before merging these improvements into main it is important to test against a Jinja2 project.

Relates to https://github.com/ONSdigital/eq-questionnaire-runner/pull/909


Aliased commands should not shadow build in commands

Looks like currently an alias can shadow a built in command (relevant code). Is this the expected behavior? Git for example forbids this:

To avoid confusion and troubles with script usage, aliases that hide existing Git commands are ignored

https://www.kernel.org/pub/software/scm/git/docs/git-config.html

cc @sbeckeriv

My only thoughts were around sub-commands. I have an alias that is fast-build on a project and another contributor installs the sub-command fast-build  the project should consistently run. It looks like we can use list_commands to get a list of installed commands and  throw an error or warning. Sounds like if want to mimic git cargo should throw an error and have the user clean up their file.
Going back to my example an error would not allow you to use an alias in a project and a sub-command in another. I think that can be sorted out by people talking vs cargo supporting that configuration.

Ah yeah it was definitely intended that default subcommands wouldn't be allowed to get aliased!


add unit test for rbac shadow policy metric collection

Signed-off-by: Quanjie Lin<EMAIL_ADDRESS>Description:
add unit test and debug logs for rbac shadow policy metric collection
Risk Level:
LOW

/cc @lizan

Please update the title and description, it is more than adding unit test :)

@rodaine could you pls help to take a look at this PR ? thanks !

@quanjielin can you change the commit description to cover what the actual bug that was fixed is? It's helpful for posterity to be able to get an idea of what the contribution of the PR is.

thanks @htuch , added description for the bug that's fixed in this PR.


Chat: show loading animation when waiting for first token

Adds the loading animation when the chat model response is about to streaming:

(animation is working similar to Figma).

Looks and works great! 👏🏽
I think there's too little contrast between the colors and the background, but I wouldn't mind it until we have a newer design.


Theme two, text placement

Theme 2 currently places any text before its associated image, except for the first (masthead) image. This means (I think) that there is no way to place any text at the very end of the page (in other words, no way to have the page end with text, instead of ending with an image.)
I created my own version of theme 2, and changed its post-template.html file to place the "post" div after the "image" div.
That solves the issue with not being able to put text at the very end of the page, but now there's no way to have the page start with text (except for the masthead text.)
Would it be useful to allow the name of the text file to include something that indicates whether the text goes before or after the associated image?

so I think this should be a part of the theme rather than a specific flag in the script. I pushed a change to make this available by default. eg:
---
class: textafter
---
text stuff blah blah

Thanks, that worked.


Is it possible to implement conversions between different address types?

how to get reward address with base address? and get base address with reward address.

An address is composed of two parts, payment and staking. Either part is optional. You can create both payment and staking address from an address that contains both parts. Example:
>>> addr = Address.from_primitive("addr1q83ncas2uglxfkeawss86t5dhp8u32n6v90004wetfqn3lc78dd3kxwnk28zpwzyz6hkrflh9f7hqp79sf8lhvrsxlnqp06agx")
>>> Address(staking_part=addr.staking_part)
stake1uy0rkkcmr8fm9r3qhpzpdtmp5lmj5ltsqlzcynlmkpcr0essu3tsj
>>> Address(payment_part=addr.payment_part)
addr1v83ncas2uglxfkeawss86t5dhp8u32n6v90004wetfqn3lca9vcu3

This page also provides some useful information about Cardano address.


Unhandled puppet type with awesome_print

/Users/cosman/nwops/example42/puppet-tp/.bundle/gems/puppet-debugger-0.8.1/lib/awesome_print/ext/awesome_puppet.rb:35:in awesome_puppet_type': undefined method to_hash' for #Puppet::Pops::Types::PResourceType:0x007fe2e42fbec0 (NoMethodError)
Did you mean?  to_s
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatter.rb:26:in format' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:115:in unnested'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:74:in awesome' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:91:in pre_ruby19_syntax'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:51:in block (2 levels) in printable_hash' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/indentator.rb:13:in indent'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:63:in increase_indentation' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/base_formatter.rb:113:in indented'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:47:in block in printable_hash' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:46:in map!'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:46:in printable_hash' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:35:in multiline_hash'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatters/hash_formatter.rb:18:in format' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatter.rb:79:in awesome_hash'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/formatter.rb:26:in format' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:115:in unnested'
from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:74:in awesome' 	from /Users/cosman/nwops/example42/puppet-tp/.bundle/gems/awesome_print-1.8.0/lib/awesome_print/core_ext/kernel.rb:10:in ai'

It appears the to_hash method on puppet types was removed in puppet


Tests/l2k small fixes

fix up the tests a little bit, make them run on my linux machine locally and make us actually test pytorch

@vanpelt I skip the test_categorical because the test was failing, but I have no idea how it ever passed.  What are you doing with the "Discrete Model" - calling .entropy() at the end seems really weird.


Expose 'func (Time) Add' function in template engine

Hi,
In our use-case, we're generating Kibana URLs that include timestamps for dashboard time-window display.
Currently, I can put either fixed <time>-ago notation (4h-ago) or absolute time (from t1 to t2).
A relevant time-frame can be injected to the generated URL by taking the alert timestamp and subtracting  a duration using time.Add(<negative_duration>). the resulting Dashboard URL will always display a time-window like 1 hour before the alert until 'now'.
Thanks,
Yarden

The time add function is exposed based on the alert property. What we would need to expose is actually time duration. You can use this ugliness as a workaround:
{{($.Last.Time.Add -1.8e12).Format "2006-01-02T15:04:05Z" }}'
Here is a complete URL for reference:
{{ $ip.ip }}
The bad thing is using the numerical constant. But this will likely let you get the job done. Note that my example is $.Last.Time because I'm inside a nested block and need to access the parent scope. You can probably just do .Last.Time

I forgot about this ticket, what I ended up doing (which (IMHO) is better) is:
$kibana_parameters = ?_g=(time:(from:'AAAA:00:00.000Z',mode:absolute,to:now))

And in the template rendering:
View Dashboard

The .Alert.Vars.url is a concatenation of several parts of our full Kibana URL.
This truncates the minutes from the hour and lets the user view a (slightly) bigger picture.
Thanks,
Yarden


opentrack: Update to 2022.3.2 & fix autoupdate

[X] I have read the Contributing Guide.

/verify


Protocol improvements for ChunkedEntities

References https://github.com/endpoints4s/endpoints4s/issues/953.

@julienrf What do you think about these changes? Obviously documentation needs to be updated, I will work on it once we finalize the implementation.

I agree about naming: "framing" sounds better to me.
Regarding modules, let me look at the interpreters to get a wider view.

Ah, we also need to relax the compatibility intention of the algebra modules (the versionPolicyIntention key in the root build.sbt file) to be Compatibility.BinaryCompatible. It might not be enough to fix all the compatibility issues, but let’s see what its outcome is.

Please let me know if there are some specific parts you would like me to review… Or if the whole PR is ready to review?

Since we agreed on most of the implementation, I was mainly expecting comments in regards to documentation and some minor implementation improvements, so thank you for providing that!

I have noticed a few places where we could improve even more the documentation. Also, it would be good to add a section about framing here: https://endpoints4s.github.io/algebras/chunked-entities.html

Should we alter the existing documentation for ChunkedJsonEntities or just add an additional section for Framing? I feel that with it being so critical for browser clients we should alter the existing docs, describing what problem does it solve, maybe mentioning the deprecation of methods without framing specified. Not sure how to best approach this. Any suggestions @julienrf?

@ptrdom Yes, I think it is a good idea to alter the existing docs to explain the problem you solved. I don’t think we should mention the deprecated method, though (but we will mention that deprecation in the release notes). How does that sound?

That makes a lot of sense, I will do that, thanks!


[Splittermond] Small typing and UTF8 errors fixed with npc action

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Some action textes had UTF8 issues, they were fixed
I fixed a specific text that could be interpreted as LGBT-unfriendly

Character Sheet Info Roll20 Internal Use only.


Changed TextResponse for HtmlResponse

Issue: https://github.com/scrapy-plugins/scrapy-zyte-api/issues/67

HI @kmike  being that HtmlResponse is basically equal to TextResponse, wouldn't it be a proper fix?

hey! I was also thinking they’re equal, but as it turns out, it behaves differently e.g. in scrapy’s open_in_browser. It should be rare though that there is any practical difference, but there could be code which works in a different way, depending on the response type.


make Nullifier experimental

moves Nullifier under the Experimental namespace in light of https://github.com/o1-labs/o1js/issues/1174 until 1) Poseidon is confirmed to be secure or 2) we have a secure alternative

Closing, see comments on #1147


[NoQA] Add unit tests for search query parsing

Details

Create tests to check SearchParser returns expected output
Fixed Issues

$ https://github.com/Expensify/App/issues/48291
PROPOSAL: https://github.com/Expensify/App/issues/48291#issuecomment-2318776603
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above

[x] I wrote clear testing steps that cover the changes made in this PR

- [x] I added steps for local testing in the Tests section
- [x] I added steps for the expected offline behavior in the Offline steps section
- [x] I added steps for Staging and/or Production testing in the QA steps section
- [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms

[x] I ran the tests on all platforms & verified they passed on:

- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

[x] I followed proper code patterns (see Reviewing the code)

- [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- [x] I verified that comments were added to code that is not self explanatory
- [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- [x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[x] I followed the guidelines as stated in the Review Guidelines

[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] I verified that if a function's arguments changed that all usages have also been updated correctly

[x] If any new file was added I verified that:

- [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

- [x] A similar style doesn't already exist
- [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

- [x] I verified that all the inputs inside a form are aligned with each other.
- [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Below test cases from this doc fail for the current SearchParser:
Test Case 6 (first one)
Query String:  amount>200 expenseType:cash,card description:"Las Vegas party" date:2024-06-01 category:travel,hotel,"meal & entertainment"
Here, the expected result for card filter is card = cash,card but the parser returns card = cash OR Card = card. Similar thing happens for category. Not sure about if this requires updating test case or updating parser because comma separated values might be being handled outside the parser as well
Test Case 8
Query String:  amount>200 las vegas category:"Hotel : Marriott" date:2024-01-01,2024-02-01 merchant:"Expensify, Inc." tag:hotel,travel,"meals & entertainment"
The main issue is that for merchant filter the expected result is merchant = Expensify, Inc but the parser returns merchant = Expensify OR merchant = Inc.. This is a parser issue.
tags filter also has issue but it is same as last one

Please rerun the "Verify signed commits" workflow, the commit was signed but added the public key to Github after the workflow failed

Below test cases from this doc fail for the current SearchParser:
Test Case 6 (first one)
Query String: amount>200 expenseType:cash,card description:"Las Vegas party" date:2024-06-01 category:travel,hotel,"meal & entertainment"
Here, the expected result for card filter is card = cash,card but the parser returns card = cash OR Card = card. Similar thing happens for category. Not sure about if this requires updating test case or updating parser because comma separated values might be being handled outside the parser as well
Test Case 8
Query String: amount>200 las vegas category:"Hotel : Marriott" date:2024-01-01,2024-02-01 merchant:"Expensify, Inc." tag:hotel,travel,"meals & entertainment"
The main issue is that for merchant filter the expected result is merchant = Expensify, Inc but the parser returns merchant = Expensify OR merchant = Inc.. This is a parser issue. tags filter also has issue but it is same as last one

These are fixed by this PR so we may need to merge that first

Currently the ❌ Jest Unit Tests are failing, therefore I'll wait for the mentioned PR to merge first and once all tests pass here, then I will be able to complete the PR Reviewer Checklist.

@jaydamani @ikevin127 let's update the expected values to the current one in App. We can update the expected values if/when we change the parser grammar.

@ikevin127 @luacmartins, All tests are passing now so, this is ready for review.

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.30-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This PR was deployed to production yesterday


Logging not working

After introducing nubia, the logging does not work. Nubia writes to another log file 🚶

Fixed


Add support for id attributes in dialog actions (https://github.com/c…

…allemall/material-ui/issues/1600).

What about using a more generic option: passing all the unused properies of actionJSON to the FlatButton?

With https://github.com/callemall/material-ui/pull/2483, you can now pass the id property directly to the FlatButton component.


Bump dependencies

Bump dependencies to fix saml sso across wso2 products.

Bump dependencies for https://github.com/wso2/product-is/issues/6691


New kernel IO features support

Bump base packages
Enable liburing support in QEMU

@rvs: This one is intended to be the next step for block IO backends, supporting next-kernel features


Relax behavior of some HINTs when MXLEN > XLEN

Resolves #1487

Thanks for doing this!

@cyyself no, thank you: this is a special case we failed to properly document.


Include optional parameters in the response when validating  the self-contained access token

Hi All,
According to spec [1], the following are optional parameters to be included in the validation response
"sub", "aud","iss", "jti"
The requirement is when we Invoking the token introspection endpoint to validate the self-contained access token
We need to add those above optional attributes to be included in the validation response.
[1] https://tools.ietf.org/html/rfc7662#section-2.2

Hi All,
This was added to the product with the improvement: https://github.com/wso2-support/identity-inbound-auth-oauth/commit/2c3f5159b9b1284cce389ce9d06d2fc3d420feec
Ref: https://github.com/wso2/product-apim/issues/11894


Make the icon blue when "on"

Were you thinking of something like this?

If so, I have it working on my branch here: feat-stateful-icon/index.js#L7 Would you mind sharing the vector asset for the icon and the preferred shade of blue – and I'll use that to generate the on icon. Thanks!

That is exactly it!
I suppose whatever the blue is in the grid to make it all connected.
As far as the icon, I don't have anything sophisticated yet so it's only the ⊞ character that I took a screenshot of 😊 😺 . So, if you want to raise this up a level and move the things to svg that'd be way rad. Otherwise, we can keep rocking my hacky solution.

Noticed an issue with "on state" – this is probably down to lack of my knowledge of the Chrome API.

The icon has global state. It's not tied to specific tabs. So, if you toggle it on and go to another tab it will still be in "on" state. We could attach listeners for tab events, maintain a map of active tabs and then based on that we can toggle the icon state every time the user switches tabs or opens/closes them. However, that feels like a very heavy handed approach for a tool that is otherwise quite light. Your call.
I did however, convert the icon to SVG so, I can at least submit a PR for that.

Hm, nice catch.
I really like the icon color toggling since it provides additional feedback for the toggled state. I wonder if we could slightly simplify a listener that checks for the existence of the <style id="tachyons-x-ray"> element?
I think as a start we can merge this in as is with the slight issue (IMO it's still an improvement).


I'm not sure how you've built your dynamic schema, but when using ITypeModule you have the TypesChanged event that you can trigger to reload the schema.

I'm not sure how you've built your dynamic schema, but when using ITypeModule you have the TypesChanged event that you can trigger to reload the schema.
Currently there is no documentation on this, but you can read this blog post entry as a primer and look at this example.
Originally posted by @tobias-tengler in https://github.com/ChilliCream/hotchocolate/discussions/4902#discussioncomment-2451067

This very actual problem for me to. I don't undestend how ITypeModule can help me. We tried use ITypeModule but it not resolve our task. On example i has classes:

Query - code for all my resolvers
Mutation - code for all my mutations
MyDbContext - EF db context
Models classes from DB
Input and Output classes for my mutations
All classes generates dynamicaly and compile as "in memory" assembly.
And the end i'm  call hotchocolate methods (AddQueryType and AddMutation) for my generated classes with reflection. This work fine.
I want after change structure my DB and regeneration my assemble simple reloading "Query" class and "Mutation" class in runtime. How i can do it?
Can you help me do it?

https://hotchocolategraphql.slack.com/archives/C01QQ4JKYUV/p1646768716848369
This slack thread might help.


T-rex runner game

Project title
T-rex runner game
Project Description
adding T-rex runner game
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript

this game already exists in the repo so closing my issue


Fix some minor issues

This PR fixes several issues:

If the minDate / maxDate provided to the input element was not a valid moment object, the validation function would throw an exception.

Now, it returns that any value is valid if minDate / maxDate are not moments (ie, validation is disabled).

The date-range directive did not watch for data changes originating from outside the directive. This has been resolved.

Any changes to the start / end values will cause an update of the inner picker max/min dates.
This should fix #197

The demo page did not specify a timezone for the date-range directive. This directive therefore used local dates.

Can you please change the bower and project version in bower.json and package.json? change it to 2.0.1, this will enable bower users to update their code :). many thanks for your contribution!


backtracking required because of match. Performance may be degraded

Hi
I ran into a problem when using mapping from this repository.
Airflow is installed as a service. the following settings
[metrics]
statsd_on = True
statsd_host = localhost
statsd_port = 9125
statsd_prefix = airflow
are made in the config file.
Docker container with statsd_exporter is running on the same server:
docker run --name statsd-exporter
-d --rm
-p 9102:9102
-p 9125:9125
-p 9125:9125/udp
-v $PWD/statsd_mapping_v2.yaml:/tmp/statsd_mapping_v2.yaml
prom/statsd-exporter --statsd.mapping-config=/tmp/statsd_mapping_v2.yaml
statsd_mapping_v2.yaml content copied from this repository.
but there are no additional parameters from the mapping file in the metrics output.
Instead, the container logs have this
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.ti_failures
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.ti_successes
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.zombies_killed
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler_heartbeat
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.sla_email_notification_failure
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagbag_size
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.processes
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.critical_section_busy
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag.callback_exceptions
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.celery.task_timeout_error
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.import_errors
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.total_parse_time
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.processor_timeouts
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.executor.open_slots
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.executor.queued_tasks
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.executor.running_tasks
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.smart_sensor_operator.poked_tasks
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.smart_sensor_operator.poked_success
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.smart_sensor_operator.poked_exception
ts=2023-10-25T11:21:46.788Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.smart_sensor_operator.exception_failures
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.smart_sensor_operator.infra_failures
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.critical_section_duration
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.tasks.killed_externally
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.tasks.running
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.tasks.starving
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.orphaned_tasks.cleared
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.scheduler.orphaned_tasks.adopted
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.last_runtime.*
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.pool.open_slots.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.pool.queued_slots.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.pool.running_slots.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.pool.starving_tasks.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagrun.dependency-check.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.last_duration.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagrun.schedule_delay.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagrun..first_task_scheduling_delay
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.ti.start..*
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag_processing.last_run.seconds_ago.
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dag...duration
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagrun.duration.success.*
ts=2023-10-25T11:21:46.789Z caller=fsm.go:314 level=warn msg="backtracking required because of match. Performance may be degraded" match=.dagrun.duration.failed.
ts=2023-10-25T11:21:46.789Z caller=main.go:350 level=info msg="Accepting StatsD Traffic" udp=:9125 tcp=:9125 unixgram=
ts=2023-10-25T11:21:46.789Z caller=main.go:351 level=info msg="Accepting Prometheus Requests" addr=:9102
Can you tell me how to fix this?

How to fix this? This is just a warning, and it's only a problem if your statsd exporter is using too much CPU?  Is it?  These regex seem to perform fine for me


postinstall script 'typings install' fails.

After cloning the project, npm install fails:
sh: typings: command not found npm ERR! Darwin 14.5.0 npm ERR! argv "node" "/usr/local/bin/npm" "install" npm ERR! node v0.12.7 npm ERR! npm  v2.11.3 npm ERR! file sh npm ERR! code ELIFECYCLE npm ERR! errno ENOENT npm ERR! syscall spawn npm ERR<EMAIL_ADDRESS>postinstall: typings install npm ERR! spawn ENOENT npm ERR!  npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'typings install'.

You'll need to install Typings as global first.
npm install typings -g
Sorry about that, it should probably be documented or automatically installed when you first run npm install.
Let me know how it goes.

Thanks for the hint, after installing typings, i get another error:
/angular2-seed-project/gulpfile.js:102 	var result = gulp.src(['typings/main.d.ts', ...filesGlob]) 	                                            ^ SyntaxError: Unexpected token .     at exports.runInThisContext (vm.js:73:16)     at Module._compile (module.js:443:25)     at Object.Module._extensions..js (module.js:478:10)     at Module.load (module.js:355:32)     at Function.Module._load (module.js:310:12)     at Module.require (module.js:365:17)     at require (module.js:384:17)     at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:116:3)     at Liftoff.<anonymous> (/usr/local/lib/node_modules/gulp/node_modules/liftoff/index.js:192:16)     at module.exports (/usr/local/lib/node_modules/gulp/node_modules/liftoff/node_modules/flagged-respawn/index.js:17:3)

That's because of ES6 - You'll need NodeJS 5.x for that. Or you can use .concat() instead.

Perfect. Thanks! What about the pull request. Should we change something?

All good mate.
Regards the PR, I'll need to speak to the guys at Typings because ideally the package should be installed globally - so I'm thinking we'll need to set a hook script in the package.json.
For example:
"scripts": {
  "preinstall": "npm i typings -g"
}

@pas2al Any thoughts? Let me know if you're happy to send a PR with the script above. Cheers.

I am going to test it later and send you a new pr ;-)

Sounds like a plan - thanks for contributing :-)

Fixed at #55.

What if installing typings globally is not an option? There is no file/script/executable called 'typings' in the distribution.

What if installing typings globally is not an option?

You don't have to install typings globally. But that'd be the same as saying you don't want to install npm globally.
In theory you could still download or get the definition files d.ts from somewhere else - perhaps manually?

I installed the TypeScript compiler locally  and added the directory to tsc to my PATH. Thanks for pointing out I can do things manually. Can you tell me how to run typings when it is not installed globally?

Typings is a definition manager for TypeScript. If you don't have it installed then you need to get the definition files manually. Imagine for example, if you didn't have npm and you wanted to install a package - let's say jQuery - you'd have to go get it from somewhere else on the internet.
For more info I'd recommend TypeScript and Typings official documentation.

I would argue that installing Typings globally is not ideal. What if you have multiple projects, and one requires a certain version of Typings, while another project requires a different version?
When you install it locally to the project, it creates a binary in node_modules/.bin/typings. Then you can create an NPM script with the same name (i.e. "scripts": { "typings": "typings" }) and change your postinstall script to npm run typings install.
This way, Typings is installed locally instead of globally (reducing the chance of conflicts between projects) and this project is set up correctly with just the npm install command.

+1

Installing globally is unnecessary, as any modules that define executable scripts will be added to path for that command. So @HillTravis is correct, but his suggestion can be simplified even more.
You don't need to create the "typings":"typings" script and call npm run typings install. All you need is typings listed under devDependencies and then "postinstall": "typings install" under scripts.

@JimmyBoh Thanks! I didn't realize it was added to the path. However, if I wanted to run typings install alone from the command line, would I still need "typings":"typings" to avoid having to type ./node_modules/.bin/typings, or is there some other trickery of which I'm unaware?

All executable scripts will be added to path when used via an npm script, but otherwise you must install it globally to use it globally. It's somewhat unfortunate to have to type the path like that, but it's far easier on the contributors who don't need to mess with it at all, and much safer when it comes to breaking version changes (I'm looking at you typings@1.0).


Install proceeds with missing PHP modules

The installer reports success with cURL and GD not installed. Are those not essential? Also, the warning icons for missing modules in the lower left panel are not obvious enough.
Tested on PHP 7.1.0RC5

Thanks for the report. The installer now requires curl (#490). GD is still optional.


fix(release-notes): update release notes for 2019.11 release

PatternFly-Next preview: https://patternfly-next-pr-2522.surge.sh

:tada: This PR is included in version 2.46.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


C# SDK change with Routing Properties

Routing Properties changes for C# SDK
Swagger Spec https://github.com/Azure/azure-rest-api-specs/pull/1174

This checklist is used to make sure that common guidelines for a pull request are followed.

[ Y] I have read the contribution guidelines.
[ Y] The pull request does not introduce breaking changes.

General Guidelines

[ Y] Title of the pull request is clear and informative.
[ Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ Y] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[Y ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[Y ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[Y ] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ssankar1984,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci add to whitelist

@azuresdkci test this please

Swagger PR here - https://github.com/Azure/azure-rest-api-specs/pull/1200


not found and method not allowed

can you add the ability to set these?

Hey!
That is a feature I really liked to have as well. Unfortunately, these two are hard coded into the standard library.
 I will try creating a PR to make these two dynamic. With any luck, we may have this feature in future Go releases. That's a long shot though.

theres a few routers you might be able to get an idea from that do this.
https://github.com/yousuf64/shift
https://github.com/uptrace/bunrouter
https://github.com/razonyang/fastrouter
https://github.com/nbari/violetear

I appreciate your suggestion, although all of these packages are implementing the routing themselves. Grape, on the other hand, relies on the standard library for the routing. Hence, some features depend on the flexibility of stdlib's APIs.


Can't get Embla Carousel working in a Modal (Here I use Rodal as Modal)

When I use embla in my page it run successfully. But when I put it in a modal it can't run the slider. Then I can't slide the item. Here is some image.

<Rodal
visible={state.visible}
onClose={() => modaleToggler('hide')}
width={950}
height={580}
customMaskStyles={{ background: '#0000009c' }}
enterAnimation="zoom"
leaveAnimation="slideDown"
>
{name}

{details}

In Carousel Component I write this code-
function Carousels({ works }) {
const [emblaRef] = useEmblaCarousel({ skipSnaps: false, draggable: true });
return (

            {works &&
                works.map((work, i) => (

{work.name}

                ))
            }

)

}
export default Carousels;

Hi @siamahnaf198,
Thank you for your question. I'm not sure what you're suggesting? Embla has been around for some years now and it wouldn't make any sense at all if it couldn't run in a modal. I've used it in modals a lot. I think you might not be doing it right. When you open the modal the size of the modal probably changes, so you need to tell that to Embla by re-initializing it.
Try running embla.reInit() when the modal is opened.
David

Can you sent example code?
My Code is
import { useEffect } from 'react';
import { useEmblaCarousel } from 'embla-carousel/react';
function Carousels({ works, visible }) {
const [emblaRef, embla] = useEmblaCarousel({ skipSnaps: false, draggable: true });
useEffect(() => {
    if (embla && visible) embla.reInit();
}, [embla, visible])
return (
    <div ref={emblaRef} className={`embla ${visible ? 'active' : ''}`}>

            {works &&
                works.map((work, i) => (

{work.name}

                ))
            }

)

}
export default Carousels;
Here visible return true when modal is open and return false when modal is close?
Please help me to solve it.

Hi @siamahnaf198,
Please create a CodeSandbox that clearly demonstrates the issue and I’ll look into it when possible.
David

Hi @davidcetinkaya
I create this code sendBox- https://codesandbox.io/s/heuristic-brattain-0yjb9?file=/pages/index.js
Carousel runs when I open inspect element. But when I reload or load the page it can't run. Please check the code and solve the problem.
Thank you David :)

Hi @siamahnaf198,
The CodeSandbox doesn't work. Please fix the following error with the CodeSandbox and I'll look into it after that:

David

I didn't see any error.

Please visit the link again- https://codesandbox.io/s/heuristic-brattain-0yjb9?file=/pages/index.js

@siamahnaf198 the issue happens when I clone your sandbox. Try cloning the sandbox and maybe you should see the error.

Sorry!
At first thank you David for Spending time with me.
Secondly I am new in CodeSandBox. If you can do that without cloning it or see the issue in output by clicking open modal button. It will very helpful for me.
Actually I use embla carousel almost all my project when I start react and next js. But in my current project, I want to put embla carousel in a modal. Here I see that it not working. I try it for 7 days, But I fail.
Embal carousel is very light weight carousel. That's why I choose this carousel very much. If you can solve the problem it will be very helpful for me otherwise I have to tell my client to change project design.

Hello @davidcetinkaya
I solve the error issue. Now you can clone it and Check Casrousel issue. Please help me to solve not running Embla carousel in modal.
New CodeSandBox link - https://codesandbox.io/s/reverent-pine-vl5mh

Here you go @siamahnaf198, here's a working CodeSandbox. The issue was that you're trying to initialise Embla before the modal is visible and has any width and height dimensions that's readable. Embla can't pick up a width and height of it's container when these dimensions doesn't exist.
So the solution is really simple, we just pass the emblaRef to the carousel when the modal is in a visible state, otherwise we pass null:

  ...content

;

David

Wow:) It's working.
Thank you very much David. I never forgive you.
On Tue, Aug 24, 2021 at 4:47 PM David @.***> wrote:

Closed #210 https://github.com/davidcetinkaya/embla-carousel/issues/210.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/davidcetinkaya/embla-carousel/issues/210#event-5199838787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASVPESXDYS3BYP53DIS4M4DT6N2DLANCNFSM5CUM3MDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Fix bug reporting incorrectly length compile queue

Description
Fix bug that causes the /serverstatus endpoint to report an incorrect length of the compiler queue.
Self Check:

[ ] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Pull request rejected by merge tool. Failed to parse change entry file: Change entry /tmp/tmp4bi2mped/changelogs/unreleased/fix-task-queue-calculation.yml does not match pydantic schema: 1 validation error for ChangeEntry
issue-repo
Can't set issue-repo without setting issue-nr (type=value_error)

Processing this pull request

Merged into branches master in 88e1ca4b609298d536db3e19052f203ca328ed60

Processing #5818.

Processing #5819.


Set UTF-8 encoding to string from configuration file

Fluentd assumes configuration file encoding is UTF-8.
Fix #1590

Thanks!


Design: Signature component

Summary: Design of the Signature component.
Design on component branch and push to main Figma file when approved.
Acceptance Criteria:

[x] Component Kickoff
[x] Sync with Dev and Design
[x] Research and consulting other design libraries
[x] WCAG Goal can be completed using a screen reader.
[x] WCAG Visual elements observe color contrast requirements.
[x] WCAG Manual accessibility testing meets WCAG 2.1 AA requirements.
[x] Provides equal service in French and English.
[x] Sync with Dev and Design
[x] Comparison with official policy, documented reasons for deviation if any
[x] Design review
[x] Policy index is updated accordingly
[x] Policy review
[x] Design - Different screen sizes
[x] Design - Short content / long content (text overflow etc.)
[x] Design - Error state (if applicable)
[x] Design - Empty state (if applicable)
[x] Component anatomy
[x] Write draft of design guidance
[x] Handoff from draft dev guidance to documentation author/lead
[x] Update Figma version

Content
https://docs.google.com/document/d/1M_wtvVaaYjE175OY18hi0hVRriHynm9p-gR5wrBY8sg/edit

component anatomy
https://www.figma.com/file/mh2maMG2NBtk41k1O1UGHV/Canadian-Digital-Service
---GC-Design-System?type=design&node-id=1862-5581&mode=design&t=RuxakLTwSZ41AqZJ-0


ID of Record is returned instead of Record

Environment
Python version: 3.6.6
NetBox version: 2.5.10
PynetBox version: 4.0.6
Steps to reproduce :
Python 3.6.6 (default, Aug 13 2018, 18:24:23)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-28)] on linux
Type "help", "copyright", "credits" or "license" for more information.

import pynetbox
api = pynetbox.api(
...     'http://YYYYYYYY',
...     token='XXXXXXXXX',
... )
ic=api.dcim.interface_connections.all()[0]
str(ic)
'xe-0/1/6'
i=ic.interface_a
i.name
'xe-0/1/6'
i.id
1500
i.url
'http://XXX/api/dcim/interfaces/1500/'
i.cable
7990
type(i.cable)
<class 'int'>
intf=api.dcim.interfaces.get(1500)
intf.name
'xe-0/1/6'
intf.id
1500
intf.url
intf.cable
type(intf.cable)
<class 'pynetbox.core.response.Record'>
intf.cable.id
7990

Expected Behavior
type(i.cable) returns <class 'pynetbox.core.response.Record'>
Observed Behavior
type(i.cable) returns <class 'int'> (i.e. i.cable is the ID of cable)

Unfortunately this is due to the API only returning an int here instead of a nested response. You can get around it by loading its value into api.dcim.cables.get(id). It's not exactly as simple as adding it to the model to get the desired behavior either since Record is expecting a dict, but may be open to a PR for if there's enough desire for it.

You are correct. Thank you.
You can see that in :
http://XXX/api/dcim/interface-connections/


[VMware VCenter] ...

Extension
https://www.raycast.com/massimiliano_pasquini/vmware-vcenter
Description
Current State
Only one VCenter can be added.
Feature
It would be great if multiple VCenters (with differing credentials) could be added.
Possibly have the listed resources/assets in the menus reflect what VCenter they are pulled from with a tag/friendlyname or the hostname.
Who will benefit from this feature?
Anyone that either:

IT service providers that manage multiple standalone VCenters
Anyone working with fully split Prod/Test VCenter environments
Manages a VCenter at work and in a homelab

Anything else?
No response

Hi @TheUdK,
this could be done by moving vCenter credential from Preferences to the LocalStorage. LocalStorage is encrypted and shared only between command of the same extension so is not a problem for security. Saving credential on LocalStorage remove the limitation or saving only a fixed amount of credential.
In the next weeks I will work to implement this requested feature.

Hi @TheUdK,
I have finished to implement the requested feature. Before releasing it I appreciate if you can test it providing me some feedback. You can clone the latest version from MassimilianoPasquini97/raycast_vmware_vcenter repository.

Hi @MassimilianoPasquini97,
Sorry for the late feedback.
Seems to work great. Added three different VCenters. Will test further during the next couple of days. What would be nice is to be able to select to show all configured VCenters in one view and have it display the source VCenter in a slightly greyed out text behind the asset/hostname/datastore ect.

Hi @TheUdK,
i have committed a new update on MassimilianoPasquini97/raycast_vmware_vcenter repository implementing this features:

Selecting 'All' view objects from all vCenter Server.
Added AccessoryList on Items for showing Os Icon and vCenter Server Name if viewing all vCenter Server with 'All'.
VM can be filtered by Os Name or IP.
Implemented a cache system for improve performance.
On 'Virtual Machine' Command now CMD+R refresh information of selected
item.
On 'Virtual Machine' Command  added 'Open RDP' SubCommand for opening an RDP connection with the vm. Microsoft RDP Software is required.

I appreciate if you can test it providing me some feedback.

Hi @MassimilianoPasquini97
Looks nice. Thanks for your work.
Some issues i have found.

When having "All" selected and trying to"Edit Server" i get an error - guess that case should be handled.
The OsTextMetadata is out of date (VmGuestOS Data Structure

Thanks you @TheUdK  for your help on testing all these new features. I have totally forgot to disable 'Edit Server' and 'Delete Server' when 'All' is selected, now I have fixed it. I have also updated VmGuestOS.
I think now all features are mature enough  to be published. Here the pull request

Looks like something broke in with the commit d132bb551c13744e0fd439ea8ab822eb758cca48
Using the previous commit and building locally works fine for me.
Using either your main branch,  d132bb551c13744e0fd439ea8ab822eb758cca48 or raycast store i get the error.
Error: missing expected parameter key: value
VCenter Version
{'summary': 'Patch for VMware vCenter Server 8.0', 'install_time': '2023-11-03T15:07:42.946Z', 'product': 'VMware vCenter Server', 'build': '22617221', 'releasedate': 'October 24, 2023', 'type': 'vCenter Server with an embedded Platform Services Controller', 'version': '<IP_ADDRESS>00'}
To reproduce error

Uninstall any version of the extension from raycast ui
Install from store or run npm clean-install && npm run dev on main branch
Add new connection
Receive Error: missing expected parameter key: value

Working

Uninstall any version of the extension from raycast ui
git checkout 608f26774dab1779348d9ba26f6aafc6d296b514
npm clean-install && npm run dev
Works as expected

I think there might be an issue with generating the connection object in the later commits. Possibly an issue on my end though as im not very versed with TypeScript/raycast extentions.

Also none of the vm power interactions seem to work (atleast on the commit 608f26774dab1779348d9ba26f6aafc6d296b514)

You could use this endpoint to generate a ticket for the VMware Remote Console. This would authenticate it directly instead of asking for credentials.

Also your function to open the web ui directly to a vm object tries to use the VMs UUID instead of the VCenter instance UUID. I am not sure how to get the VCenter uuid using the /api endpoint but you can see it using the MoRef endpoint at https://[vcenter]/mob/?moid=ServiceInstance&doPath=content.about

Hi @TheUdK,
thanks for your help, I have fixed all the errors and implemented console tickets on https://github.com/raycast/extensions/pull/10787

Everything seems to work now.
There is still an issue with the Open on vCenter Web. You are using the instance_uuid of the VM instead of the instance_uuid of the vCenter with ${vm.vm_info.identity?.instance_uuid}/summary.
To generate the direct link to the VM you need the url format
https://{vcenterFQDN}/ui/app/vm;nav=v/urn:vmomi:VirtualMachine:{vmMORefID }:{vCenterMORefID}/summary
you are using:
https://{vcenterFQDN}/ui/app/vm;nav=v/urn:vmomi:VirtualMachine:{vmMORefID }:{vmInstanceUUID}/summary
Example using PowerCLI:
Wrong values to use
(get-vm -name $vms).extensiondata.config.InstanceUUID
5031f478-a46d-27f6-843f-5ea12fc14773
5031f43a-0cfb-f571-f769-5af1f1f5d723

Correct value to use - same for all vms
$global:defaultviserver.InstanceUuid
0f4bf16e-1f72-4072-accf-bc88b3c62265

or
https://{vcenterFQDN}/mob/?moid=ServiceInstance&doPath=content.about
This endpoint might help but im not sure.