[Bug]: Dynamic ESS charges from grid instead of PV only

Contact Details
<EMAIL_ADDRESS>VRM portal ID
dca6329bad96
Country / region
Germany (de)
B max
15.5152
TB max
4.2
FB max
3.36
TG max
15
FG max
28.5
Battery costs
0.04
Buy price
0.359
Sell price
p*0.97
feed-in possible
yes
feed-in control
yes
Version
0.1.6
What happened?
Charge / Discharge control produces additional cost when based on SoC targets only.
Given a DESS plan based on SoCs it can not adapt in the morning and evening hours properly to varying energy solar production.
See attached screenshot how the DESS continues to charge the battery (default grid set point is 0 to avoid grid consumption due to higher prices).

DESS schedule

Additionally, there is no adjustment when the predicted SoC consumption per hour deviates. For instance over night there seems to be a little bit higher consumption then predicted, but the DESS schedule forces a const lower discharge instead of switching to controlling via grid set point 0.
Without DESS grid consumption can be really minimised

When using DESS often in the morning there is an additional load due to the sharp rises of production. Maybe there should be an additional backoff battery reserve definition to deal with variances in the prediction.

VenuOS is running on version 3.20~2.
Relevant log output
No response
Screenshots
![DESCRIPTION](LINK.png)

This seems to be a duplicate of https://github.com/victronenergy/dynamic-ess/issues/79

It looks like you have the minsoc set to zero. Can you try increasing that to 10%?

Hi
your Sell Price
p*0.97
ist correct?
Normally for newer system it is less then 10 cent in Germany.

For sell price my understand was that p expresses the current EPEX spot price. The 0.97 should translate into a 3% fee subtracted from the spot price.
Added now 10% MinSoC in ESS settings and will monitor the system. Consumption data should be available for almost half a year in VRM. @dirkjanfaber which data needs to be built-up?

Sell Price is the price you get. Einspeisevergütung.
Or do you do sell direct? "Direkt Vermarktung" like Jörg from meintechblog.de

Sell Price is either a constant value like 0.0671 like the EEG-Einspeisevergütung or a variable sell price as for my case with Marktprämien Direktvermarktung often linked to EPEX Spot price p

We keep the battery stable and not the grid: in our internal testing keeping the battery usage stable (basically the same as the plan) has been a lot more cost-effective than otherwise, because of the battery costs that pile up.
In order to forecast consumption well, it needs 28 days of consumption data. Solar forecasting should be correctly functioning within a day after setting the location.
Closing this issue now as I believe the original "bug" has been explained by the way the system works.

Hi @dirkjanfaber
thank you for taking care of the issue,
I would like to add also a note to it as I see some issue regarding planing the consuption as well, seen here Dynamic ESS - d41243d31a1a (CZ)
As there is a battery cost setting, I would expect that it should react on that and if battery cost is set to 0 or close to 0 like 0.001, there should be no cost to "pile up".
So hold grid to defined setpoint "0" or "-10" would make sence or?
I have seen that is buying some energy from grid never less there is enought battery (> SOC lim ) and not use it and the consuption is fully from grid. As the energy forecast was not accurate and it stick to the plan anyway.
DESS not allow to the grid as spot <0

Selling anyway !!!

ESS set manually to not allow to sell.

Is there any way to change the behavior to ignore SOC value and stop selling?
Is there any way to stop charging from the grid if price is higher that sell in next few hours as the plan for consuption is not possible to guess for longer period.
Is there any way to stop charging from the grid if solar forecast is higher then expected consuption?
Thank you


capture example does not compile

go run _examples/capture/capture.go
# command-line-arguments
_examples/capture/capture.go:25:14: deviceConfig.Format undefined (type malgo.DeviceConfig has no field or method Format)
_examples/capture/capture.go:26:14: deviceConfig.Channels undefined (type malgo.DeviceConfig has no field or method Channels)
_examples/capture/capture.go:34:60: deviceConfig.Format undefined (type malgo.DeviceConfig has no field or method Format)
_examples/capture/capture.go:36:43: deviceConfig.Channels undefined (type malgo.DeviceConfig has no field or method Channels)
_examples/capture/capture.go:47:3: unknown field 'Recv' in struct literal of type malgo.DeviceCallbacks
_examples/capture/capture.go:49:33: too many arguments in call to malgo.InitDevice
	have (malgo.Context, malgo.DeviceType, nil, malgo.DeviceConfig, malgo.DeviceCallbacks)
	want (malgo.Context, malgo.DeviceConfig, malgo.DeviceCallbacks)
_examples/capture/capture.go:67:45: deviceConfig.Channels undefined (type malgo.DeviceConfig has no field or method Channels)
_examples/capture/capture.go:76:38: deviceConfig.Channels undefined (type malgo.DeviceConfig has no field or method Channels)
_examples/capture/capture.go:81:3: unknown field 'Send' in struct literal of type malgo.DeviceCallbacks
_examples/capture/capture.go:84:32: too many arguments in call to malgo.InitDevice
	have (malgo.Context, malgo.DeviceType, nil, malgo.DeviceConfig, malgo.DeviceCallbacks)
	want (malgo.Context, malgo.DeviceConfig, malgo.DeviceCallbacks)
_examples/capture/capture.go:84:32: too many errors

Do you want to try these changes.
// This example simply captures data from your default microphone until you press Enter, after which it plays back the captured audio.
package main
import (
"fmt"
"os"
"github.com/gen2brain/malgo"

)
func main() {
ctx, err := malgo.InitContext(nil, malgo.ContextConfig{}, func(message string) {
fmt.Printf("LOG <%v>\n", message)
})
if err != nil {
fmt.Println(err)
os.Exit(1)
}
defer func() {
_ = ctx.Uninit()
ctx.Free()
}()
deviceConfig := malgo.DefaultDeviceConfig()
deviceConfig.DeviceType = 3
deviceConfig.Capture.Format = malgo.FormatS16
deviceConfig.Capture.Channels = 1
deviceConfig.Playback.Format = malgo.FormatS16
deviceConfig.Playback.Channels = 1
deviceConfig.SampleRate = 8000
deviceConfig.Alsa.NoMMap = 1

var playbackSampleCount uint32
var capturedSampleCount uint32
pCapturedSamples := make([]byte, 0)

sizeInBytes := uint32(malgo.SampleSizeInBytes(deviceConfig.Capture.Format))
onRecvFrames := func(pSample2, pSample []byte, framecount uint32) {

	sampleCount := framecount * deviceConfig.Capture.Channels * sizeInBytes

	newCapturedSampleCount := capturedSampleCount + sampleCount

	pCapturedSamples = append(pCapturedSamples, pSample...)

	capturedSampleCount = newCapturedSampleCount

}

fmt.Println("Recording...")
captureCallbacks := malgo.DeviceCallbacks{
	Data: onRecvFrames,
}
device, err := malgo.InitDevice(ctx.Context, deviceConfig, captureCallbacks)
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

err = device.Start()
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

fmt.Println("Press Enter to stop recording...")
fmt.Scanln()

device.Uninit()

onSendFrames := func(pSample, nil []byte, framecount uint32) {
	samplesToRead := framecount * deviceConfig.Playback.Channels * sizeInBytes
	if samplesToRead > capturedSampleCount-playbackSampleCount {
		samplesToRead = capturedSampleCount - playbackSampleCount
	}

	copy(pSample, pCapturedSamples[playbackSampleCount:playbackSampleCount+samplesToRead])

	playbackSampleCount += samplesToRead

	if playbackSampleCount == uint32(len(pCapturedSamples)) {
		playbackSampleCount = 0
	}
}

fmt.Println("Playing...")
playbackCallbacks := malgo.DeviceCallbacks{
	Data: onSendFrames,
}

device, err = malgo.InitDevice(ctx.Context, deviceConfig, playbackCallbacks)
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

err = device.Start()
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

fmt.Println("Press Enter to quit...")
fmt.Scanln()

device.Uninit()

}

Thank you (Хвала ?).
At least it compile, i test it later when i have mic ...
may be s/deviceConfig.DeviceType = 3/deviceConfig.DeviceType = malgo.Duplex/ ?

Yes, it works,
can i afford to recommend some style ?
s/
nSendFrames := func(pSample, nil []byte, framecount uint32) {
/
nSendFrames := func(pSample, _ []byte, framecount uint32) {
/

s/
onRecvFrames := func(pSample2, pSample []byte, framecount uint32) {
/
onRecvFrames := func(_, pSample []byte, framecount uint32) {
/

Appreciate the feedback. I did remember to remove the pSample2 before
posting the pull request, but I never though to use _ for nil. Thanks for
the tip.
On Tue, 8 Oct 2019 at 07:49, Jamil Djadala<EMAIL_ADDRESS>wrote:

Yes, it works,
can i afford to recommend some style ?
s/
nSendFrames := func(pSample, nil []byte, framecount uint32) {
/
nSendFrames := func(pSample, _ []byte, framecount uint32) {
/
s/
onRecvFrames := func(pSample2, pSample []byte, framecount uint32) {
/
onRecvFrames := func(_, pSample []byte, framecount uint32) {
/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gen2brain/malgo/issues/12?email_source=notifications&email_token=AEC3XN2VVNSAGH3QI3LR773QNQUPRA5CNFSM4I56EMN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEATBMYQ#issuecomment-539367010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEC3XN4DDYBODZUYC4OUKZLQNQUPRANCNFSM4I56EMNQ
.

actually nil here is variable name:
https://play.golang.org/p/yGW0r-fc3_K

Oh yes, so it is.
I tried 'true', 'error', '5' also. Good clarification of the language.
As expected 5 is 5, but the reserved keywords of true/nil/error will become variable name, and true will no longer mean true.

This should be fixed currently.


[TASK]: Save simulation metadata along with the output csv when saving the dataset

There are 2 parts to this:
Part 1:
When we save the dataset for a simulation, we want to know (and save) all the input metadata for the simulation that resulted in that dataset. I.e. provenance.
Ask: Save this input metadata or verify whether this is something that already exists or not
Part 2: In the simulation drilldown, the dataset table column names match the parameter/state variable names in the model. e.g.

However, once this dataset is saved, there seems to be _param and _sol suffixes being added to the column names (presumably in the data service backend).

This could lead to confusion to users about the connection between the dataset tables they see (e.g. maybe they won't recognize that it's the same dataset).
Ask: investigate the cause of the suffixes and remove them when showing the dataset table to the user.

CC: @liunelson


Fix URL for entry within annotation

This ensures the URL has the correct path to fetch the entry directly.
Fixes #280
Signed-off-by: Bob Callaway<EMAIL_ADDRESS>

/ok-to-test

/lgtm


BUG - brainrender does not initialise due to lack of vedo.closePlotter in vedo==2021.0.5

With the new version of vedo 2021.0.5, closePlotter seems to have been removed (commit), so brainrender and brainrender-gui crash with:
    from vedo import Plotter, closePlotter
ImportError: cannot import name 'closePlotter' from 'vedo' (/home/adam/miniconda3/envs/brainrender/lib/python3.7/site-packages/vedo/__init__.py)

yep, you should use
plt.close()

Thanks guys, I'm about to publish a new version with a fix.
@marcomusy  I'm having a problem with multiple semi-transparent meshesh, if I set useDepthPeeling=False meshes that are behind get rendered on top of those on front (e.g. the pink area should be behind all others):

but if i set useDepthPeeling=True then only the meshes' outlines get rendered:

Other settings like useSSAO and useFXAA don't seem to have a noticeable impact.
Any idea what could be the cause of the problem?

Hi @FedeClaudi that looks scary... can you confirm that the problem is not there with the same vtk version in vedo version 2021.0.3? you can use vedo --info

there's still weird transparency issues (the red area is behind the green, also the black outlines becomes green for the red area when its behind the green one):

with the depth peeling I still get everything transparent.
The transparency issue is there also using vedo's examples (cartoony.py):

with useDepthPeeling =True:

Changing python and vtk version did not help either.

That's strange I cannot reproduce the issue on my ubuntu:

I wonder if that's due to the mac graphic card.
Playing various combinations with this:
from vedo import *

settings.useDepthPeeling = True
settings.multiSamples = 8

plt = Plotter()
man = Mesh(dataurl+'man.vtk'  ).lighting('off').c('pink'  ).alpha(1.0)
ted = Mesh(dataurl+'teddy.vtk').lighting('off').c('sienna').alpha(0.5)
ted.scale(0.4).rotateZ(-45).pos(-1,-1,-1)

plt.show(ted, man,
         ted.silhouette(),
         man.silhouette(featureAngle=40).lineWidth(3).color('dr'),
)

seems to give the expected result.. Try set multisamples to 0.

Settings multisamples=0 gets rid of the disappearing meshes with useDepthPeeling and improves the transparency issues, but it doesn't fix everything.
When there's only two semi-transparent meshes overlapping it gets it right:

but with 3 it messes up:

Also with only two meshes it works ok if I'm close enough with the camera, if I zoom out it's as if it wasn't using depth peeling:

On windows using multiSamples=8 works fine:

but if I set useDepthPeeling=False I get the transparent meshes

this transparency thing makes me want to cry..... maybe in the first case you mentioned increasing maxNumberOfPeels=12 helps?
Unfortunately the combination of these settings can be tricky in VTK depending on the actual machine, I tried to find a compromise  in the defaults  - but apparently it's not good enough.

Looks good, thanks @FedeClaudi

Hi,
is there any temporary fix to the original crash issue? Else, can you point to a previous version that is functional?
Thank you

hi, have you tried to upgrade brianrender? It should work no
pip install -U brainrender

Thank you @FedeClaudi!
I had originally reverted to this version because version <IP_ADDRESS> had not originally worked, which I now realize is because it did not automatically install PySide 2 and its dependencies (see issue #138 )
All seems to be in working order now!


Add LocalSvg/WithLocalSvg types

Summary
Adds missing types for LocalSvg and WithLocalSvg

Must be merged.
@brentvatne can you do it?

This seems to be an easy merge, and we're waiting for it ;)


Separate Combos on ZMK

Combos are valid across all layers so showing it multiple times is not necessary. Also, it covers the keys if someone uses combos extensively. I think having a separate draw for combo only would be a better approach

I don't intend to change the default behavior since I think the diagram should reflect the true behavior, i.e. that combos can be triggered on all layers by default. However there are a few options to draw combos separately:

Use --keys-only or --combos-only options in the command line to draw layers without combos, then layers with only combos. You can combine the latter with --select-layers to only draw combos for one of the layers.
Use separate_combo_diagrams draw config option, which draws all of them like below. This option ignores the layer filter completely.

Use zmk_combos parse config to override the layers property for each combo

Thank you @caksoylar. Do you have an example on how to add these flags into the Github actions config? Here is my current config
https://github.com/t18n/zmk-config-corne/blob/main/.github/workflows/draw-keymaps.yml

Doing 2. or 3. is simple: Just add a config file (see https://github.com/t18n/zmk-config-corne/blob/main/.github/workflows/draw-keymaps.yml#L18 on where to put it in the repo) and add the options I mentioned. E.g. for option 2 the minimum content you need is
draw_config:
  separate_combo_diagrams: true

Approach 1. is more complicated since it involves calling keymap draw multiple times with different arguments. While you can pass command line arguments using this option https://github.com/t18n/zmk-config-corne/blob/main/.github/workflows/draw-keymaps.yml#L21 it will still call the command once. You'd need to modify the reusable workflow file at https://github.com/caksoylar/keymap-drawer/blob/main/.github/workflows/draw-zmk.yml or incorporate a modified version into your file above to do that.

@caksoylar I probably have done it wrong but when I added the configuration https://github.com/t18n/zmk-config-corne/blob/main/keymap_drawer.config.yaml, the generated SVG is empty

I'll close the issue, but please let me know if you have any issues implementing the suggestions above.


Gradient menu background

Hi,
thanks for your work.
I'm trying to use a gradient for the menu (from left to right). I've put everything transparent and then added a gradient sublayer, but it doesn't show.
pagingViewController.backgroundColor = UIColor.clear pagingViewController.menuBackgroundColor = UIColor.clear pagingViewController.collectionView.backgroundColor = UIColor.clear pagingViewController.view.backgroundColor = UIColor.clear
let gradientLayer = CAGradientLayer() gradientLayer.frame = pagingViewController.view.bounds gradientLayer.colors = [UIColor.blue, UIColor.green] gradientLayer.startPoint = CGPoint(x: 0.0, y: 0.5) gradientLayer.endPoint = CGPoint(x: 1.0, y: 0.5) pagingViewController.view.layer.addSublayer(gradientLayer)
Can you please help me?
Thanks!

Hi @Silvia4! There a couple of issues with your implementation:

You need to use .cgColor in gradientLayer.colors. E.g: [UIColor.blue.cgColor, UIColor.green.cgColor]
You probably want to add the layer pagingViewController.collectionView instead of the entire paging view. You should also do .insertSublayer(gradientLayer, at: 0) instead to insert the view at the bottom of the view hierarchy.
You need to set the frame of the layer when the frame of the collection view is not zero. E.g. viewDidLayoutSubviews or viewWillAppear.

That should do it 🙂


Useless Lines in Example

https://github.com/discordjs/voice/blob/bddd03525a8414d902b67da9e201d23ac8da65b9/examples/music-bot/src/music/subscription.ts#L55-L57
This lines are useless because:
https://github.com/discordjs/voice/blob/bddd03525a8414d902b67da9e201d23ac8da65b9/src/VoiceConnection.ts#L495-L497

Thanks for pointing this out!
Feel free to make a PR to resolve this, otherwise I'll be able to fix it later today.

1 hour I tried to make a pull request. Do it yourself.


[WIP] compiletest directive handling rework project goal for 2025H1

WIP: need to ask Zalathar and Trevor if they're interested in becoming co-owners and ask compiler and bootstrap for vibe check.

Rendered.


routing: local balance check before path finding

Fixes #1680

Todo: add test

two of the async benchmarks failed, perhaps an indicator that this introduces a performance regression?

two of the async benchmarks failed, perhaps an indicator that this introduces a performance regression?

Manually checked the timing of a queryroutes call on testnet, didn't see a difference with master. Restarted itests

Yes, does seem to be failing consistently. Will check it out.

Turned out to be a deadlock with getting the source node. Fixed now


Crosby LAN

There are 3 entries in the Gazetteer for Crosby in LAN. They geolocate to the same place.
Please combine them into one entry and move the search records with them.
The links to oficial source dont seem to work either.
Geoff

Done


take only works the first time on SSR

Hi,
We recently upgraded our universal app to use 1.0.5 and discovered something strange. While the client side app is working perfectly, the SSR side only executes the first render. After lots of debugging, it is clear that the watch function simply does not pick up the redux action.
export function * watchFetchArticle () {
  while(true) {
    console.log('********* Waiting for FETCH_ARTICLE')
    const data = yield take(FETCH_ARTICLE)
    console.log('********* FETCH_ARTICLE', data)
    yield fork(fetchArticleSaga, data)
    console.log('********* Done FETCH_ARTICLE')
  }
}

After the first render we get both logs, but on the second render only the ********* Waiting for FETCH_ARTICLE.
Anyone dealt with this or something similar?

You'd have to share a repro case - without that I can't really tell what might be wrong.

@ion-willo Hello, Did you find any solutions for this problem ? I have the same behavior
Thanks

@hanouman please share a repro case so I could take a look at it.

I have the same behavior in next.js. I upgrade redux-saga from v0.16.0 -> v1.1.1.
The repo is here next-antd-scaffold_saga-error
/**
 * userList saga
 */
export function* fetchUserList() {
  while (true) {
    yield take(FETCH_USER_LIST);
    try {
      console.log('run here');
      const res = yield fetch(api.getUserList);
      const data = yield res.json();
      yield put(fetchUserListSuccess(data));
    } catch (e) {
      yield put(fetchUserListFail());
    }
  }
}

client side it works

but refresh page,it not work in server.

the console not print.

The problem is solved. The saga middleware should is created everytime.
// before
const sagaMiddleware = createSagaMiddleware();
function configureStore (initialState) {
  const store = createStore(
    rootReducer,
    initialState,
    bindMiddleware([sagaMiddleware])
  );
  ...
}

// after
function configureStore (initialState) {
  const sagaMiddleware = createSagaMiddleware(); // create saga middle in here
  const store = createStore(
    rootReducer,
    initialState,
    bindMiddleware([sagaMiddleware])
  );
  ....
}

Ah, thank you!
On Fri, 1 Nov 2019 at 10:41, luffyZh<EMAIL_ADDRESS>wrote:

The problem is solved. The saga middleware should is created everytime.
// before
const sagaMiddleware = createSagaMiddleware();
function configureStore (initialState) {
const store = createStore(
rootReducer,
initialState,
bindMiddleware([sagaMiddleware])
);
...
}
// after
function configureStore (initialState) {
const sagaMiddleware = createSagaMiddleware(); // create saga middle in here
const store = createStore(
rootReducer,
initialState,
bindMiddleware([sagaMiddleware])
);
....
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redux-saga/redux-saga/issues/1928?email_source=notifications&email_token=AIVZJBIEIW5EOU7YEOIGAWLQRPTTFA5CNFSM4IWWI772YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2KSQQ#issuecomment-548710722,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIVZJBK2ZLHE3BU4RTHUVMTQRPTTFANCNFSM4IWWI77Q
.

--
Willo van der Merwe
Principal Consultant
Tel: +27 (0) 21 658 4100 <++27216584100> | Cell: +27 (0) 83 445 4798
<++27834454798>
4 Greenwich Grove, Station Rd, Rondebosch, 7700
www.saratoga.co.za | Confidentiality notice
http://www.saratoga.co.za/confidentiality-notice/

Seems like the issue got solved so I'm going to close this.


Use ClassValue for caching instead of a ConcurrentHashMap

ClassValue is a thread-safe, classloader loading/unloading safe way since it does not hold a strong reference to a class.

Codecov Report

Merging #14 (40bcfe3) into master (e899239) will not change coverage.
The diff coverage is 100.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e899239...40bcfe3. Read the comment docs.


YARN-9646 Use localhost when testing with the mini yarn cluster

When testing
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell#testDSShellWithoutDomain
at home
The following error happened:
org.apache.hadoop.yarn.exceptions.YarnRuntimeException: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [ruyang-mn3.linkedin.biz:0] java.net.BindException: Can't assign requested address; For more details see:  http://wiki.apache.org/hadoop/BindException
at org.apache.hadoop.yarn.server.MiniYARNCluster.startResourceManager(MiniYARNCluster.java:327)
...
Caused by: java.net.BindException: Can't assign requested address
at sun.nio.ch.Net.bind0(Native Method)
It's because the test uses
InetAddress.getLocalHost().getHostName();
to get the host name and tries to bind to it.
The machine is issued at work. At home, the FQDN of the hostname is either not resolvable or the cached ip address is not reachable. Even on VPN, somehow the same error happened from time to time. The exact cause of that behavior on VPN is unknown yet.
It makes WFH more difficult.
The test will be simpler and more reliable if it simply uses "localhost".
===
The comment in
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell#checkHostname
* NetUtils.getHostname() returns a string in the form "hostname/ip".
* Sometimes the hostname we get is the FQDN and sometimes the short name. In
* addition, on machines with multiple network interfaces, it runs any one of
* the ips.
suggests some complexities involved with this method of calling InetAddress.getLocalHost()
===
This test specifically checks for hostname patterns. Not sure why.
This change will remove the check, which simplifies the test quite a bit.
Testing:
The failed test succeeds and all the distributed shell tests and mini cluster tests succeed

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
42
Maven dependency ordering for branch

+1
mvninstall
1074
trunk passed

+1
compile
584
trunk passed

+1
checkstyle
75
trunk passed

+1
mvnsite
83
trunk passed

+1
shadedclient
862
branch has no errors when building and testing our client artifacts.

+1
javadoc
63
trunk passed

0
spotbugs
49
Used deprecated FindBugs config; considering switching to SpotBugs.

0
findbugs
38
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
49
the patch passed

+1
compile
544
the patch passed

+1
javac
544
the patch passed

-0
checkstyle
69
hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 95 unchanged - 3 fixed = 101 total (was 98)

+1
mvnsite
62
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
694
patch has no errors when building and testing our client artifacts.

+1
javadoc
56
the patch passed

0
findbugs
29
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has no data from findbugs

_ Other Tests _

+1
unit
193
hadoop-yarn-server-tests in the patch passed.

-1
unit
1247
hadoop-yarn-applications-distributedshell in the patch failed.

+1
asflicense
50
The patch does not generate ASF License warnings.

6010

Reason
Tests

Failed junit tests
hadoop.yarn.applications.distributedshell.TestDistributedShell

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1020

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1f1bbfb457e7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 062eb60

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/testReport/

Max. process+thread count
650 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: hadoop-yarn-project/hadoop-yarn

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Jenkin's test failure doesn't seem to be caused by my change.
My local run of the same test succeeded. I ran it before I submitted this PR and after I saw this error report.
https://builds.apache.org/job/hadoop-multibranch/job/PR-1020/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-applications-distributedshell.txt
[ERROR] Tests run: 31, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1,033.703 s <<< FAILURE! - in org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell
[ERROR] testDSShellWithoutDomainV2DefaultFlow(org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell)  Time elapsed: 72.148 s  <<< ERROR!
java.io.IOException: Unable to delete directory /tmp/junit6475398092292452499/junit6001466067676332915/entities/yarn_cluster/jenkins/DistributedShell/1/1561575691010/application_1561575687435_0001/YARN_CONTAINER.
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1581)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2372)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1679)
at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1575)
at org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.checkTimelineV2(TestDistributedShell.java:629)
at org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testDSShell(TestDistributedShell.java:461)
at org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testDSShellWithoutDomainV2DefaultFlow(TestDistributedShell.java:328)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

Fixed see
https://issues.apache.org/jira/browse/YARN-9646


Double ALT (rolling) glitches out

If you play in the editor with 2 clients and you roll you get stuck in a glitching effect, for the other player it looks normal, but after that he sees you in crouched position (and you are still glitching)

Create session and connect to it if you testing... you fool :D


Code Coverage Badge & Changes

Current Implementation

There's no code coverage badge for the main branch and also no way to see the difference on pull requests.
Suggested Enhancement

Add a coverage badge to the README and setup a service to automatically post coverage changes to PRs.
Expected Benefits

Long term improved code coverage and therefore also increased trust from our users (which is important for this app to become a success).

I could fix this myself if I had access to the organization (currently I can't add any GitHub Apps like Codacy, CodeCov or CodeClimate).

Hi @Jeehut , thanks for the pointer. We'll find a solution for that to add code coverage information to the repo.

@ChristianKienle I don't know what happened, but I just checked the README.md on the development branch and there's still no code coverage badge anywhere to be seen. Could you please reopen this and check what happened?

Hi @Jeehut , yes there was a problem with the PR and we had to revert. I'll reopen the ticket until the badge appears.


[Snyk] Security upgrade ch.qos.logback:logback-classic from 1.4.5 to 1.4.14

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Uncontrolled Resource Consumption ('Resource Exhaustion') SNYK-JAVA-CHQOSLOGBACK-6097492
ch.qos.logback:logback-classic:  1.4.5 -> 1.4.14
No
No Known Exploit

641/1000  Why? Recently disclosed, Has a fix available, CVSS 7.1
Uncontrolled Resource Consumption ('Resource Exhaustion') SNYK-JAVA-CHQOSLOGBACK-6097493
ch.qos.logback:logback-classic:  1.4.5 -> 1.4.14
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Uncontrolled Resource Consumption ('Resource Exhaustion')

pull request has been replaced by PR #21


Demo: Conway's Game of Life

https://github.com/DusterTheFirst/pico-dvi-rs/assets/14093962/034cc8e3-f921-4a4c-b996-243741049858

https://github.com/DusterTheFirst/pico-dvi-rs/assets/14093962/58ac4770-cf64-4036-8723-471ff1d88a3a

I can confirm this works on my Adafruit board (after applying my local patch to change the pinout).


Update CMDev map

About the PR
Changes tiles, airlocks, tables and some chairs with lockers to the CM14 ones.
Media

(screenshots cuz MapRender borked)

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

it looks like i accidentally deleted decharger.

no i didnt.


Fix LR schedule handling for low-bit optimizers

Fixes #730
Tested with ViT-Base (~100M) params. Excellent speed up :smile:. The "before" is much slower than my previously reported numbers (3-4%) is probably because I use a much smaller model -> allocating CUDA LR tensor is much more evident.

Marking this as draft right now because I want to consolidate Adam and AdamW into a single file. It's becoming a bit troublesome to make the same edits in both files whenever I need to change anything :sweat_smile:.
cc @janeyx99 @msaroufim

copy paste is mostly fine here to me (unless it really bothers you) even pytorch core has lots of copy paste between adam and adamw

@janeyx99 Since CPU scalar Tensor works with n-D CUDA Tensor, should step be on CPU also? I was following PyTorch core
https://github.com/pytorch/pytorch/blob/058302494cdf65fc59a1784fb9cea6c61e2be3f7/torch/optim/adamw.py#L99-L104
But incrementing step on CPU is definitely faster than doing it on CUDA?
@msaroufim It's just annoying when I make changes to the wrong file and need to be careful with the name - copy paste but still need to replace adam with adamw or vice versa :sweat_smile:

(I will update the benchmarks number in README. don't merge yet)


fix: restore original ansible vault code

A quick & dirty "backport" of the original ansible vault code which got lost when PR #142 was merged. Fixes #171.

@jeinwag one mistake that I observed is that you forgot to run npm install and include changes made to the package lock. Due to this the lockfile is missing the newly added deps.

@ssbarnea it's not asking for the password, but for the vault identity to use to encrypt the file. I added a fix to display an error message if there are no identities defined.

@webknjaz Thanks for the feedback, I believe I applied all your suggestions and removed all the synchronous calls except one call to fs.existsSync.

@jeinwag thanks for updating the PR with the requested changes! I've performed the second round of review. Please, take a look.
@ansible/devtools folks, may I ask you all to participate in getting this PR to the finish line? It's rather good but needs more eyes on it. TIA!

@ssbarnea I noticed an issued with error handling when there are no ansible-vault identities configured. Now the extension should display an error message, stating that it can't de- or encrypt files without an identity.

@FlorianLaunay ah dang, I think I messed up the executable path setting during the rebase of my changes, I had it in there before :-(
Added it again, but please, feel free to help. This feature really is a must-have for us.

@ssbarnea  I believe c02411e5ad7d39cc7d57ba19ec8bed633953d046 broke the pre-commit hooks. npm install --production removes @commitlint/config-conventional from node_modules, which then causes commitlint to fail.

@ssbarnea I sent you a message on matrix. I fixed some issues with package.json.


[ACR] Support Overriding Task parameters, support for ContinuationToken [NEW preview API VERSION]

Introduces the API version 2019-06-01-preview for ACR Tasks.

OverrideTaskStepProperties for a TaskRunRequest - You can now override some properties when you created the Task. But you can now also override them.
updateTriggerToken, updateTriggerEndpoint, updateTriggerPayloadType properties for Break-the-loop
taskName -> taskId as a required property for Task run.
Adds arm64 and 386 to list of supported platforms.

Diff against previous swagger
You can diff it against stable/2019-04-01 swagger.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

@tjprescott is there any issue going on with azure-sdk-for-python and azure-sdk-for-ruby right now? Locally, I was able to create the SDK for python without any issues.
// cc: @jaysterp @northtyphoon

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Automation for azure-sdk-for-net
A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/6345
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/6345/commits/95b3ba544acb36d09f3f2d6f41d11579bbe7e2fe

Automation for azure-sdk-for-java

@shahzzzam can you includeTriggerMetadata in your examples so we can see the expected response?

@AutorestCI regenerate azure-sdk-for-go

Encountered a Subprocess error
Command: ['/usr/local/bin/autorest', '/tmp/tmp5ljsczuk/rest/specification/containerregistry/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp5ljsczuk/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=<EMAIL_ADDRESS>'--use-onever', '--verbose']
Finished with return code 1
and output:
AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4302)
   Including configuration file 'file:///tmp/tmp5ljsczuk/rest/specification/containerregistry/resource-manager/readme.go.md'
   Loading AutoRest extension<EMAIL_ADDRESS>(~2.1.133->2.1.133)
   Loading AutoRest extension<EMAIL_ADDRESS>(2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-06"} .
   Including configuration file 'file:///tmp/tmp5ljsczuk/rest/specification/containerregistry/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-2019-05"} .
   Including configuration file 'file:///tmp/tmp5ljsczuk/rest/specification/containerregistry/resource-manager/readme.go.md'
Failure during batch task - {"tag":"package-2019-05"} -- Error: [Exception] No input files provided.

Use --help to get help information..
[Exception] No input files provided.

Use --help to get help information.

@jaysterp  when u have time, can u help me figure out why ModelValidations are failing for this..

@jaysterp @northtyphoon please review.

@kpajdzik  can you please review again?

@kpajdzik what are the breaking changes you refer to?

@kpajdzik @RyanBensonMSFT @sanjaiganesh can you please merge this if there are no issues. My team has approved the changes. There are no breaking changes. So if @kpajdzik could elaborate on that. Thanks.

@kpajdzik @RyanBensonMSFT @sanjaiganesh can you please merge this if there are no issues. My team has approved the changes. Thanks.

I was comparing with https://github.com/Azure/azure-rest-api-specs/blob/master/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json this spec. Is that the latest version?

@kpajdzik no, the previous version is:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2019-04-01/containerregistry_build.json
Let me know :)

@kpajdzik no, the previous version is:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2019-04-01/containerregistry_build.json
Let me know :)

My bad. The only breaking change is property change in TaskRunRequest.
Have you seen those kind if errors in ModelValidation?

 error :
operationId: Tasks_Update
scenario: Tasks_Update_WithMSICustomCredentials
source: request
responseCode: ALL
severity: 0
code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
details:
  code: READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST
  params:
    - properties
    - Docker
  message: 'ReadOnly property `"properties": "Docker"`, cannot be sent in the request.'
  path: properties/step/type
  title: '#/definitions/TaskStepUpdateParameters/properties/type'
  description: The type of the step.
  jsonPath: $.properties.step.type
  position:
    line: 1766
    column: 17
  url: >-
    specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json
  directives: {}

@kpajdzik Thanks. Fixed it. Let me know. The other ModelValidation issue seems to be a problem from rest-api-specs side. See https://github.com/Azure/azure-rest-api-specs/pull/6221

@kpajdzik Thanks. Fixed it. Let me know. The other ModelValidation issue seems to be a problem from rest-api-specs side. See #6221
If it looks okay, can you merge it? Or @ someone from ARM who can? Thanks in advance

I'll merge it as soon as ARM team approves it. @RyanBensonMSFT, any updates here?

@RyanBensonMSFT did you get a chance to review this? We kind of want to get this out in the next AZ CLI release (with new Python SDK). Thanks!

@kpajdzik anyone else you know that can approve this? it's been two days.

@KrisBash, can this be reassigned to someone else from ARM team?

@kpajdzik - I will review this from ARM side shortly.

Looks good. Signing off from ARM side.

@kpajdzik Hi Kamil, Can you please merge it?

@kpajdzik Hi Kamil, Can you please merge it?

What about OBJECT_ADDITIONAL_PROPERTIES errors in Model Validation?

@kpajdzik yup please refer to this: https://github.com/Azure/azure-rest-api-specs/pull/6221

@amarzavery I think the only errors remaining are now OBJECT_ADDITIONAL_PROPERTIES. Let me know if something needs to be changed.

@amarzavery, Can you admin-merge if everything looks alright to you?


Resource Properties with JSON as primitive type still accept strings

Getting this working requires conversion from JSON to PSObject via ConvertFrom-JSON or initial build of policy as a PSObject or Hashtable directly:
$assumeRolePolicyDoc_ddbRole = '{
    "Version":"2012-10-17",
    "Statement":[{
        "Effect": "Allow",
        "Principal": {
            "Service": "iot.amazonaws.com"
        },
        "Action": "sts:AssumeRole"
    }]
}' | ConvertFrom-JSON
$pol = Add-VSIAMRolePolicy -PolicyDocument $assumeRolePolicyDoc_ddbRole -PolicyName ddbRole

PS > $pol.PolicyDocument

Version    Statement
-------    ---------
2012-10-17 {@{Effect=Allow; Principal=; Action=sts:AssumeRole}}

Not working when passing a JSON string in as the policy document (which is accepted as the generated function's parameter allows String, Hashtable or PSObject):
$assumeRolePolicyDoc_ddbRole = '{
    "Version":"2012-10-17",
    "Statement":[{
        "Effect": "Allow",
        "Principal": {
            "Service": "iot.amazonaws.com"
        },
        "Action": "sts:AssumeRole"
    }]
}'
$pol = Add-VSIAMRolePolicy -PolicyDocument $assumeRolePolicyDoc_ddbRole -PolicyName ddbRole

PS > $pol.PolicyDocument
{
    "Version":"2012-10-17",
    "Statement":[{
        "Effect": "Allow",
        "Principal": {
            "Service": "iot.amazonaws.com"
        },
        "Action": "sts:AssumeRole"
    }]
}

Looking into adding in logic for CloudFormation resource properties where the primitive type is JSON like the PolicyDocument type expects here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-policy.html
Issue stemmed from comments on issue #28

Thanks Nate.

@RegEM hey man! FYI, this is fixed as of v2.3.2! You should get the same behavior whether you pass a JSON string or a hashtable or a PSObject now. Deployment should be out shortly!

In action:
[I ♥ Code]> $assumeRolePolicyDoc_ddbRole = '{
    "Version":"2012-10-17",
    "Statement":[{
        "Effect": "Allow",
        "Principal": {
            "Service": "iot.amazonaws.com"
        },
        "Action": "sts:AssumeRole"
    }]
}'
$pol = Add-VSIAMRolePolicy -PolicyDocument $assumeRolePolicyDoc_ddbRole -PolicyName ddbRole -Verbose
$pol.PolicyDocument

Version    Statement
-------    ---------
2012-10-17 {@{Effect=Allow; Principal=; Action=sts:AssumeRole}}

Awesome. I figured you must have worked thru it.
Thanks sir.


Reduce memory consumption

Creating chains of settings was consuming an exponential amount of memory. This did not scale when used with builds with dozens of modules.
By using dynamic settings, the chain of dependencies is not kept, resulting in less memory consumption.

Oh that's a nice bug!
Have you tried with join rather than foldLeft?
Something like this maybe (I didn't try to compile it):
      val modules: Seq[Setting[(String, String)]]] = allProjectRefs.map { case (projectRef, _) =>
          Def.setting {
            val projectOrganization       = (projectRef / organization).value
            val projectName               = (projectRef / moduleName).value
            val projectVersion            = (projectRef / version).value
            val projectCrossVersion       = (projectRef / crossVersion).value
            val projectScalaVersion       = (projectRef / scalaVersion).value
            val projectScalaBinaryVersion = (projectRef / scalaBinaryVersion).value
            if (versionRegex.findFirstMatchIn(projectVersion).isDefined) {
              val nameWithBinarySuffix =
                CrossVersion(projectCrossVersion, projectScalaVersion, projectScalaBinaryVersion)
                  .fold(projectName)(_(projectName))
              Some(projectOrganization -> nameWithBinarySuffix)
            } else {
              // Don’t include the module if its version does not match the regex
              None
            }
          }
        }
    modules.join.map(_.flatten.toSet)

Interesting, I didn’t know about join. Your code does not compile, but I could use Def.uniform instead (which is a generalization of join, AFAIU), and it works fine. Are there any benefits of doing that instead of what I have in the PR?

It feels more idiomatic to me. At least you don't need those settingDyn that are hard to understand and that could be removed by mistake.


Incorporate license-required notification text

I am not all that familiar with the requirements of the Apache 2.0 license (the one used by the main ICA-AROMA repo), but we can modify and redistribute the code, with some caveats. We need to incorporate information about the changes we have made into the source code and retain the original license. I'm a little fuzzy on the specific details, but we should review the license to figure out what exactly we need to do.

@oesteban thanks for outlining the changes we need to make and steps we can take.
One thing I want to note is that I think the features and classifier are both very fragile. I am not sure that any changes that make sense conceptually, but don't produce the exact same results, will produce "valid" results. I could be wrong, but I got this impression the last time I tried refactoring AROMA.

One thing I want to note is that I think the features and classifier are both very fragile.

Yes, I would agree with this.

I am not sure that any changes that make sense conceptually, but don't produce the exact same results, will produce "valid" results. I could be wrong, but I got this impression the last time I tried refactoring AROMA.

You mean, for instance, by working on native space?


GPU memory and speed

i'm training two models use different resolution and input_size ,  and set the same batch_size 16 in same machine and environment；
one is 1k resolution and 1k input_size;
another is  320x320 resolution and 320x320 input_size;
but the training speed are both slow, and occupied  the same GPU memory(dont set -o args);
when training 320x320 input_size, and setting more batch_size=32 , appear OOM,
cause by apex?

The current preprocess is quite heavy. We have optimized it with 2x faster training. It will be updated within 2 days. You may also see this repo and this commit for a preview (model weights are not updated now).

@ruinmessi
ok, thanks a lot, will pull it


PSR-1679 | [Accessibility] Issue: Date fields validation

Issue:

Date fields validation

Dev Tasks:

[x] Only show the priority error
[x] Make sure unit tests pass
[x] Make sure build is green

This PR closed. Instead of this PR, we worked on https://github.com/hmrc/pension-scheme-return-frontend/pull/1016 and merged it.


support terraform 0.12.1 and mailgun-go 3.5.0

these changes appear to be all that is needed to allow this plugin to work with latest terraform and mailgun-go

Thanks! Just as a reminder to myself, it looks like this should be backwards compatible with terraform 0.11:
https://www.terraform.io/docs/extend/terraform-0.12-compatibility.html

As a result, most of the work to support Terraform 0.12 comes just from upgrading to the latest Terraform SDK, which features support for both the old and new provider protocols.


warn when using callbacks outside of MIP

Ref https://github.com/JuliaOpt/JuMP.jl/issues/779
I'm thinking this should be a warning at the solver level instead of at the JuMP level, since Gurobi is the one silently ignoring the callbacks.
CC @leethargo @fserra

That makes sense. The actual reason seems to be that the solvers don't consider the root node to be :MIPNode iff all variables are continuous. I believe that XPress shares this behavior.

Does the info callback get called if Gurobi is solving an LP? Should we only warn for lazy callbacks since they are intended to affect the solution process?

In a quick test with cbgetobj, the info callback has the same behavior as a lazy constraint and is only called in the presence of integer variables.

Thanks for checking. The message here seems to be accurate then.


Add codecov to CI/CD and update coverage in README.md

Replace the current tool (basic calculator) with codecov in github actions workflow and show coverage in README.md.
Suggested Gh Action to use: https://github.com/codecov/codecov-action
If you'd like to work on this, please comment "picking this up" below, and I'll assign the issue to you.
Please take a look at our CONTRIBUTING.md before you start working on this.

picking this up

@JoseAngel1196 Thanks for picking this up.

Gonna work on this tomorrow, will let you know if I have any Qs!

Hey @adarsh-a-tw for some reason I can't push PRs on this repository. Getting this error message:
ERROR: Permission to gopher-utils/go-collections.git denied to JoseAngel1196.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@JoseAngel1196 Please create a fork and work on it.

Hey @adarsh-a-tw can you pls approve the workflow so i can test it? https://github.com/gopher-utils/go-collections/pull/31

Hey @adarsh-a-tw can you pls approve the workflow so i can test it? #31

Done!


add missing protocols

36144
37795
39595

36144 was #mybad as I missed the initial import.
33795 and 39595 were between two other unchanged files and presumed unchanged as well. Upstream repo confirmed.
3318, 33353, and 33684 were flat out missing. Upstream repo added them.


pkg/_macros/test/executor/executor_test is failing

The tests
pkg/_macros/test/executor/executor_test RuntimeError (expected Pass)

are failing on configurations
unittest-asserts-release-win-arm64
unittest-asserts-release-win-x64

//cc @jakemac53

@devoncarew I think the prompting around area-test might need to be made more explicit that it should prefer the affected functional area, or otherwise weighted down.

around area-test might need to be made more explicit that it should prefer the affected functional area, or otherwise weighted down

I agree with that (and thanks for the feedback on the meta / triaging bot issue). Here, is it area-vm tests that are failing? We don't have a specific area for macros.; we're using area-language for non-implementation discussion issues.
We could improve the prompt for these 'test' cases. We're also not using the tuned model yet, just explicit directions in a prompt; switching to the tuned model should also improve accuracy here.

The area should be area-pkg afaik (the tests in question are in pkg/_macros).

@a-siva do you have a failure you can link me? I did recently land a fix for this test, and I am not sure how to validate if it was the same error or something different etc.

Here is the first time the failure showed up https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8745393569549264161/+/u/test_results/new_test_failures__logs_
(I believe it was a Timeout initially and then turned into a RuntimeError later).

The area should be area-pkg afaik (the tests in question are in pkg/_macros).

Yes, but area-pkg is not a great area- itself. It's not triaged - there's no team that does secondary triage on it or ultimately has responsibility for items in that area.

Here is the first time the failure showed up https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8745393569549264161/+/u/test_results/new_test_failures__logs_ (I believe it was a Timeout initially and then turned into a RuntimeError later).

That link doesn't work for me?

Ok yeah looking at the log, that is the one that should be fixed. Is this still failing?

It was failing on the windows bots until I created this issue and approved the failure

Moved this to the "no milestone/release" bucket. It isn't directly tied to any release and I haven't discovered any reasonable way to try and investigate the failure. I intend to just leave this as open tech debt for some time. There are no actual affected users, just a failing test in an environment that I can't reproduce.

 Is that not the case? If you chimed in here, is that because you were blocked or otherwise affected by the failure?

Yes, the test failure causes friction as it turns the bot on go/darto dart waterfall red

If the test is doomed to flaky failures such that test deflaker can't handle it, it could be marked as Skip in the status file or even deleted altogether.

It is only doing this on windows (that I have seen) - we do want the coverage on other platforms. So possibly marking it as skipped on windows is best?

Yeah, something like the following should do that
diff --git a/pkg/pkg.status b/pkg/pkg.status
index f129396f35c..daf26bf3345 100644
--- a/pkg/pkg.status
+++ b/pkg/pkg.status
@@ -243,6 +243,7 @@ vm_snapshot_analysis/test/*: SkipByDesign # Only meant to run on vm
 [ $system == windows ]
 front_end/test/fasta/bootstrap_test: Skip # Issue 31902
 front_end/test/incremental_dart2js_load_from_dill_test: Pass, Slow
+_macros/test/executor/executor_test: Skip # dartbug.com/56002

https://dart-review.googlesource.com/c/sdk/+/379240


Facet lists not expanding properly when user clicks on "more"

When user clicks on "more" to expand facet list, nothing happens

Fixed!


shared:use frame motion library to handle animations [Cu-1hwu210]

shared:use frame motion library to handle animations [Cu-1hwu210]
closes #186

Task linked: CU-1hwu210 Use Frame Motion library to handle animations


Release Collections Editor bulk editing update

Let's (finally) release our Collections Editor update adding several UI enhancements as well as the ability to set tags for topic nodes.
Phabricator tasks:

https://phabricator.endlessm.com/T34712
https://phabricator.endlessm.com/T34512
https://phabricator.endlessm.com/T34349
https://phabricator.endlessm.com/T34514
https://phabricator.endlessm.com/T34350

To do:

[x] Release v1.4.0 on PyPi
[x] flathub/org.learningequality.Kolibri.Plugin.kolibri-dynamic-collections-plugin#5

Everything is done here. Archiving.


Title: Unable to Import framework Module

Description:
While attempting to execute scripts within the project, I encountered an import error indicating that the framework could not be imported as a known file or library. I have checked the project dependencies and installation steps but am still unable to resolve the issue.
Steps to Reproduce:
I have ensured that all necessary dependencies are installed.
I have tried running the scripts in different Python environments, but the problem persists.
I have checked the project's requirements.txt file and confirmed that there is no dependency listed for framework.
Expected Behavior:
The project should be able to import the framework module and execute related functionalities.
Actual Behavior:
Python throws a ModuleNotFoundError when I attempt to import framework.
I have reviewed the project documentation and README file but found no guide on installing or importing the framework module.
If framework is an internal module, I have tried to locate it under the project's root directory but could not find the corresponding file.
Request for Help:
I need assistance resolving the import issue with the framework module. If it's an external dependency, please provide installation instructions; if it's an internal module, guide me on how to import it correctly.

@leezythu @fansunqi

I meet the same issues, maybe someone can fix it


[Bilibili] unable to download 720p/1080p video

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I'm running yt-dlp version 2023.10.13 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
china
Provide a description that is worded well enough to be understood
without login , I couldn't extract format higher than 480p. , but yt-dlp seems like unsupported for the Bilibili.
I have read and use #5655  #7581 , but it didn't work
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp --cookies-from-browser chrome -uv 'https://www.bilibili.com/video/BV1Vh411K7zU/?spm_id_from=333.337.search-card.all.click&vd_source=b7396982c4fba92ecba055fe83ae5ab9' -uv
Type account password and press [Return]:
[Cookies] Extracting cookies from chrome
[Cookies] Extracted 566 cookies from chrome
WARNING: [BiliBili] Login with password is not supported for this website. Use --cookies-from-browser or --cookies for the authentication. See  https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp  for how to manually pass cookies
[BiliBili] Extracting URL: https://www.bilibili.com/video/BV1Vh411K7zU/?spm_id_from=333.337.search-card.all.click&vd_source=...a92ecba055fe83ae5ab9
[BiliBili] 1Vh411K7zU: Downloading webpage
[BiliBili] BV1Vh411K7zU: Extracting videos in anthology
[BiliBili] Format(s) 1080P 高清, 720P 高清, 1080P 60帧 are missing; you have to login or become premium member to download them. Use --cookies-from-browser or --cookies for the authentication. See  https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp  for how to manually pass cookies
[BiliBili] 230014388: Extracting chapters
[info] BV1Vh411K7zU: Downloading 1 format(s): 6+2
[download] 【LOL热知识】S6的IMAY队员现在怎么样了？ [BV1Vh411K7zU].mp4 has already been downloaded

哔哩哔哩未登录限制了360-480P

没法登录啊，还是我的指令输错了，不是 yt-dlp-u吗

哔哩哔哩未登录限制了360-480P

没法登录啊，还是我的指令输错了，不是 yt-dlp-u吗

please share a new log with -vU, not -vu
are you sure the cookies are from a browser that is logged in to a premium account?

please share a new log with -vU, not -vu
are you sure the cookies are from a browser that is logged in to a premium account?

I check the Google cookies and relogin the website , finally it works.
Thanks so much!

#7581

你可以试试这个  https://github.com/nilaoda/BBDown
这个直接不登陆也可以使用


Fixed bug: Reset() clears steering buffer

The steering buffer wasn't being reset in the reset method.
I also added the kwargs for num_beams and fov in the RaceCar class which weren't being used.

Looks good, thanks for the catch!


cast sig-event produced incorrect signature value

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
cast 0.2.0 (57180fc 2023-11-09T01:50:26.035417000Z)
What command(s) is the bug in?
cast se
Operating System
macOS (Apple Silicon)
Describe the bug
Command:
cast sig-event "event MinterAdded(address indexed _minter)"

What it produced:
"MinterAdded(address)"

Expected output:
0x6ae172837ea30b801fbfcdd4108aa1d5bf8ff775444fd70256b44e6bf3dfc3f6

I think it would be calling selector() instead of signature()


Feature: Leave Group or Project

What does this PR do and why?
Describe in detail what your merge request does and why.
This PR adds functionality for a member to be able to leave a group or project on their own without needing an owner or maintainer to remove them.
Resolves #95 and #96
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Logged in as user that is removing themselves from the group:

Removing a member that is not the current logged in user

How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.

Login as<EMAIL_ADDRESS>Go the the Bacillus group and view it's members
Click the ellipsis for the<EMAIL_ADDRESS>user and you should see a link Leave group
In the confirmation you should see Are you sure you want to remove yourself from the group?
Try step 3 for another user in the listing and you should see a link Remove member
In the confirmation you should see Are you sure you want to remove this member from the group?
Try out the same steps but for a project. Projects from the seed data only have user6 through user8 as members so you will need to log in as one of those users.

PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

[X] I have evaluated the PR acceptance checklist for this PR.

I think this is great, thanks Deep.  I personally like the browser alert confirmation message, but not sure if @ericenns would prefer a modal.  I think we should come to a consensus on this, and implement going forward.  The other thing I have been noticing is sometimes we are using and flash alert (top right of screen) and sometimes we just use an on page alert banner, again, let's just come to a consensus  on where and when to use those and we can add that to the UI docs to keep things standardized.

So I logged in as user1 and removed myself from a group I owned.   This works, but leave the page in a confusing state:

I think it would be better if the user remove itself from a group / project that they are redirected to the dashboard page.  Thoughts?


Complete split_param for non-utf8

Here an initial attempt, not using windows I do not have a good way to test it though...

Yeah, pretty much what I had in mind. I'm going to merge this tomorrow morning and will try add a few tests as well.
Are you interested in more self contained bits?

Sure, I should have still some spare time :)

Thank you for your contribution, I'll deal with the tests and explanations for the next standalone bit.

Okay, next bit is slightly less self contained, but there are tests already in place :)
Parsing options is easy if user types all the right things - often they don't. We want to produce helpful error messages - suggest typos, tell that certain things can't be used together, etc.
Part I'm explaining now deals specifically with things that user passed and we don't know how to parse. Currently parser tries to parse as much as possible, if detects unparsed items - prepares to call ExplainUnparsed here https://github.com/pacak/bpaf/blob/cf2547b1cddfde433a170e82708bffc84deba063/bpaf_core/src/executor.rs#L717-L719
It gets

a list of missing items, if available
an argument we couldn't parse
some items we managed to parse successfully

https://github.com/pacak/bpaf/blob/cf2547b1cddfde433a170e82708bffc84deba063/bpaf_core/src/visitor/explain_unparsed.rs
It then gets called as a visitor on the parser that fails to collect info about the parser - I implemented the bit that looks for conflicting items so hopefully it is easy enough to understand.
With all the information collected it should try to improve the error message - right now there's just one attempt - is_in_conflict, but there can be more - I made a list below
There's a bunch of tests in bpaf_core/tests/error.rs - most of them are failing right now.
Error it produces should probably be a custom Message - to make it easier to mess with exact error rendering later. Error::parse_fail I'm using right now is just a placeholder.
https://github.com/pacak/bpaf/blob/cf2547b1cddfde433a170e82708bffc84deba063/bpaf_core/src/error.rs#L97
Messages missing are probably already exists in a commented out version.
Performance wise - this runs when there are problems and users will have to read the error later so allocations are not a problem.
I left some comments and code is hopefully not super confusing, but feel free to ask anything :)


router: scoped rds (2d): integrate SRDS API into HttpConnectionManager

Integrate the Scoped Route Discovery Service (SRDS) API into the HttpConnectionManager.
NOTES:

This is the last PR in the chain originating from parent https://github.com/envoyproxy/envoy/pull/5839.
The scoped routing logic which can be configured through this API has not yet been implemented; it will be done in follow up PRs.

Risk Level: Low (API is not yet fully implemented and should not be enabled)
Testing: Integration tests added.
Docs Changes: N/A

Please merge master to pick up https://github.com/envoyproxy/envoy/pull/7090

/retest

Is there any way to retest just the envoy-macos CI run? It appears to have flaked but /retest did not kick off a rerun.

/azp run
@AndresGuedez ^^ like so

/azp run

Thanks for the reviews throughout this whole PR chain!


Assets cache invalidation

Problem
Browser can cache assets and users may not receive updates.
Solution

Bundle assets with content hash at file name. (https://webpack.js.org/guides/caching/);
Generate a manifest file for bundled assets;
Use manifest to resolve assets name;

In development mode, the manifest file is read always, while in production mode, the manifest is read once.

@alesshh As far the code seems to make sense, I'm not familiar with this solution :cold_sweat: , is there a way that we can test it locally? What result do we expect?

@alesshh As far the code seems to make sense, I'm not familiar with this solution 😰 , is there a way that we can test it locally? What result do we expect?

@lccezinha
Now, assets in the view has a fingerprint / content hash. When something is modified at frontend, a new manifest is generated and the webserver must update the hash to file.
In development mode, everything must be working was before, live reloading included.

@alesshh Locally everything seems ok, working fine. :ship:


Gemini

"Gemini is an advanced Python-based voice assistant designed for seamless interaction and real-time information retrieval. Leveraging voice recognition and a text-to-speech system, Gemini provides users with Wikipedia summaries, weather updates, news headlines, and music control. The assistant features modular, extendable architecture and integrates a Gemini AI backend to ensure accurate and responsive results. With an interactive, web-based UI/UX, Gemini delivers a smooth, customizable user experience, encompassing capabilities like app management, joke-telling, and dynamic responses for an all-encompassing virtual assistant solution."

Yes
But , what's the issue here ?


Backend: Check if trigrams provides a better search experience

ILIKE matching is error prone, but as our product names are rather lengthy the SIMILARITY function that is provided by the pg_trgm extension does not yield us too many results for short strings. We'll revisit this at a later stage to see if it is feasible.
I have opened a branch with an example, see: feat/improved-search


docs(i8n-id): Add Indonesian translation for rootDirs.md to skipLibCh…

Overview
This is a part of #938
Changes
Provides Indonesia translation for:

[x] rootDirs.md
[x] skipDefaultLibCheck.md
[x] skipLibCheck.md

LGTM


introduce Table View

I'm a bit confuse about the absence of "table view" in sqlectron..
probably due to his age :)
here is my "mock-up" take on the table view:
the idea is to have at least 2 tabs, one with datas the other with structures and other infos....
later we can add relations, indexes, or other info in tabs...
what do you think about this...
these are only the first thoughts

(of course this is the version with both tabs clicked)

This feature would aggregate a lot to the app. Although it is something usually I don't really use in a SQL client. Because of that I'm not interesting im coding it my self. But I would gladly accept a PR 😄
As I said I have not used so much this kind of feature in other SLQ clients. So I have some questions:

Does the "Info" tab show the information about the columns such as: name, type, if is NULLABLE and etc? I'm asking that because that is what I have seen in other SQL clients. But looking your prototype looks like is listing the table data (all the rows).
Could we have 3 tabs instead of only 2? I guess splitting the 2 boxes of the first tab in different tabs would give a better look. Although if the second box in the first tab is always small than makes sense keep them together.

yeah here is an updated version ...
i understand that it wasn't really a priority ... but i wanted to know what the team think about it ...
For the first question, i was thinking about the sql description of the create table with nullable, with default, ...
And for the 3rd tab, yeah i think it's a good idea... not sure yet wat we can / can't put in it ... but
i was wondering if we couldn't also add a "Query" tab which will give the current Query + data view...

Let me se if I have understood:

Tab 1 - Structure: Show the SQL script of the table structure.
Tab 2 - Content: Show the table data. With a WHERE filter?
Tab 3 - Info: Show information about the table. Such as the size, number of rows, and etc.

If the Tab 2 really shows the table data I think that is not gonna work for large tables. Otherwise we would need paginate the result to not causa a memory leak. But I prefer keep it simple and do not have this tab. Because is possible to use "select rows (with limit)" to achieve almost the same thing.

@maxcnunes
my idea wat to give content tab when you double click on the table in the sidebar...
un filtered but limited to 1000 records or so...
then you have the choice to filter using the where field (sort of search)  or to create your own query as now... with select rows (with limit).
but i understand that it might not be the point of the tool

If we are ever going to have DB statistics (like allocation on disk, pages and stuff) I think better feature would be to make it visualized. Pure data in text form can be retrieved through SQL anyways (and is available in every SQL editor). On the other hand, for example, showing disk allocation per table as tree map graph would make much more sense for the end user :)
But as someone said earlier... this is currently low priority I guess.

@BornaP yeah why not tree map ...  i was also thinking about table relationships with other table (using the PR about relationships)

Well, that is a lot of stuff 😄  Maybe starting with a single tab (the one that is more useful for you) I guess would be better.

@eMerzh As Max said, one thing at the time. Start with a single feature you find most useful :)

yeah i know... this was more about the "big plan" ... seeing if we somewhat agree on the feature..
i'm interested in developping it, but not sure i have the time :)
i'll start small :p

I love this. I used to use Sequel Pro a lot when I was a heavy Mac+MySQL user, and their table-information and data display panes are very useful.


Button “join” to join the lobby only clickable if lobby name and password are correct

https://github.com/sopra-fs24-group-20/sopra-fs24-group-20-client/commit/aa5619a04fc168c1284a6e4c698d1f711d63b242


Hover point in image graph

Is it possible to have hovering of point data in snapshot graph that we are getting from aws ec2 instance.

Hi, the image retrieved from the GetMetricWidgetImage API is a flat png of the chart itself. It doesn't have any interactivity or meta data.


Preview limitation

The image has obsolete text "potentially exceeding the preview limitation"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 243164d1-7d2a-4afe-af6d-546154047972
Version Independent ID: c0f8b768-6da9-7e20-9d4b-6499a374a18c
Content: Streaming ingestion throughput limitations- Azure Time Series Insights Gen2
Content Source: articles/time-series-insights/concepts-streaming-ingress-throughput-limits.md
Service: time-series-insights
GitHub Login: @lyrana
Microsoft Alias: lyhughes

@algattik Thank you for the feedback.
This is being assigned to the content author to evaluate and update the documentation as appropriate.

Thanks Alex

PR merged, #please-close


Feature/editorial authors

This PR:

Adds a Wagtail Person snippet and configures it to be add-able via StreamField
Adds the authors and date to the templates for editorial pages (both editorial proper and index)
Add a link to authors with urls associated with them on the editorial page, but not on the editorial index page and order them.
Does not address styling issues.

Codecov Report

Merging #190 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    99.02%   99.03%   +0.01%
===========================================
  Files           77       78       +1
  Lines         3583     3621      +38
===========================================
+ Hits          3548     3586      +38
  Misses          35       35

Impacted Files
Coverage Δ

...pa/editorial/migrations/0005_add_person_snippet.py
100% <100%> (ø)

ppa/editorial/models.py
96.49% <100%> (+0.49%)
:arrow_up:

ppa/editorial/tests.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e0b7a...146f9c5. Read the comment docs.


⚠ ClamAV has degraded performance

In 3608d50, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 62 ms

Resolved: ClamAV performance has improved in d6a3926.


Feedback for: docker-hub/webhooks.md

File: docker-hub/webhooks.md
it doesn't seem to be explaning how i can the webhook?

Insufficient repro provided; also Docker Hub's autobuild functionality has been replaced by Docker Cloud


TextInput looses focus (controlled components)

Expected behavior
After keypress focus should remaining on <input> element
Current behavior
After keypress <input> looses focus
Possible solution
Add key property to each element
Steps to reproduce (for bugs)

Create element <TextInput value={...} onChange={...}>
It's important to create controlled one with value and onChange provided

ControlledTextInput.js

onChange (value) {
  setState({ value })
}

...

<TextInput
  key='text-input'
  value={this.state.value}
  onChange={e => this.onChange(e.target.value)}
/>

Context
Controlled Text Input
Version
0.21.0
Environment

Thanks for the bug report, Alex. We've addressed this in v0.22.


Only use test configurations when not deploying to QA or Live.

This change only copies the test env_file and cookies file into place if we're not deploying to QA or Live.

Looks good to me!