CFP: HTTP request and response size in HTTP L7 flows/metrics

Cilium Feature Proposal
Is your feature request related to a problem?
No
Describe the feature you'd like
Same idea as https://github.com/cilium/cilium/issues/21252 but for HTTP.
Knowing how big a request or response is can be very useful when debugging issues with web services. A large request could cause a service to timeout, and a large response could cause a client to timeout, or simply increase the tail latency of the service when looking at request durations.
(Optional) Describe your proposed solution
Add the request/response size fields to the L7 HTTP protobufs and configure cilium proxy (envoy) to send this information back to cilium/hubble so it can be associated with the Flow.
Once this information is in the flow, I can easily make a PR to add metrics for this. The metrics would be a histogram or summary so we can track the distribution of the request/response sizes.

Would value of the content-length header be enough? If so we might already have it in the logged headers. This is bit harder for chunked encoding and if you'd want the size of the headers to be included. Currently we emit access logs when headers have been processed, streaming the body right after.

@jrajahalme I thought of that, but it can be incorrect. A client can send a large body and set the Content-Length of the request to a small value, similarly a server can do the same but for a response. Most well behaved clients and servers shouldn't do this, but it's possible, and can lead to misleading data if dealing with less-trusted clients, or poorly implemented clients/servers.

OK, so the request here is to actually count the bytes of the payload and delay access logging until the payload is done and report the actual payload length with the log record? What if the payload is streamed and it never ends?

The stated main benefit is debugging, and for that IMO the value of content length header is likely enough. I would start with that and do more only if/when evidence for the need to dig deeper surfaces.

@jrajahalme I think the problem is that the request/response flow model is mis-aligned with how requests actually work. In Istio/Envoy they have metrics for TCP natively, and I believe it's just incrementing a counter each time a packet flows through envoy. In cilium + envoy, we're sending request/response access logs and calculating metrics based on that, but that doesn't work as well for streaming use-cases. Perhaps we should have a new access log type for in-progress (streaming) requests.

Not stale. As an aside, I think this would be important to have to be comparable to other service meshes which offer this as a metric already.


test: replace the zebra with a simple gene image

The zebra image has embedded css with size-dependent media-queries and is therefore not ideal to test other functionality like layouts. The idea of this PR is to remove complexity in the existing tests so that complex changes (like #284) can be done more easily.
I therefore replaced the zebra image with a more simple image (Image-License is CC0 1.0: https://svgsilh.com/image/718905.html) and updated the expected test-images.
Tests with styled SVG (like the zebra) will be part of another pull-request.

For what is worth, I reported the issue on svgo: https://github.com/svg/svgo/issues/1359

@XhmikosR This is a tough one, and I had discussions with @mojoaxel about it earlier. I'd be interested in your opinion. To give you a short intro:
As you will know, SVGs may contain CSS including media queries. The media queries may respond to the current screen size, making the the SVG a "responsive SVG". Under certain conditions (= screen size) a certain set of CSS rules should apply, others shouldn't apply. The Zebra image is such an SVG, basically only switching colors between screen sizes. And as I said, under certain conditions (which are clearly controlled by the test case) a certain visual output should be generated. Of course it's not svg-sprite's job to implement the SVG responsiveness — this has to be done by the browser rendering the SVG. BUT svg-sprite has to make sure it doesn't destroy that functionality while adding the shape to a sprite, hence I think it's relevant for testing.
Alex introduced Puppeteer which kinda had a problem with the Zebra (iirc), rendering false results. I understand it's a difficult situation, but I'm not sure whether simply removing / replacing the Zebra can be considered a "solution". I still think it's important to ensure that svg-sprite is not the cause problems. What do you think?

@jkphl there's also #322. While I agree that we should test this case too, it shouldn't block us.
That being said, in #284 tests mostly pass without removing the file. The are some failures but I'm not sure if it's due to some async issues or the outdated puppeteer version. We should discuss these there.
Let's put this on hold for now until we make the move to puppeteer.

@jkphl actually this would sort of fix the result test images in #403. The upstream issue is still not fixed.


Selecting an option without explicit value fails

Describe the bug
Selecting an option without explicit value fails
To Reproduce
Given a select with options that don't have value set:
<select>
 <option>Option 1</option>
 <option>Option 2</option>
</select>

Run in a test:
*** Settings ***
Library           Browser

*** Keywords ***
Select Option 2
  New Page  ${theUrl}
  #decrease timeout for faster execution
  Set Browser Timeout  100ms
  Select Options By  select  text  Option 2

When the test is run, the correct option is selected, but then an error is generated:
[ FAIL ] TimeoutError: locator.elementHandle: Timeout 100ms exceeded.
=========================== logs ===========================
waiting for selector "select >> option[value="Option 2"]"
============================================================

Expected behavior
No errors
Screenshots
Not necessary, I assume
Desktop (please complete the following information):

OS: Windows
Browser: chrome, firefox
Version: robotframework-browser 11.4.0

Additional context
I think the problem is this code that assumes all options have a value:
https://github.com/MarketSquare/robotframework-browser/blob/427e5050bbcf77e9d026cf313219c917b14e6440/node/playwright-wrapper/interaction.ts#L41
Workaround: use Run Keyword And Expect Error
  Run Keyword And Expect Error  *locator.elementHandle*option[value*
  ...  Select Options By  select  text  Option 2

@allcontributors please add @laurihelkkula for bugs.

This is actually duplicate of #1622 Therefore closing.


Is CairoMakie still works to plot 3D?

Hi all, I want to know how to plot this (get the code from an old thread and want to test it).
I read that CairoMakie is deprecated, I want to try to plot function in 3-D f(x,y) = cos(x)*cos(y)*sqrt(x^2 + y^2), if Cairo is unable then how to plot this with GLMakie?
using CairoMakie

f(x,y) = cos(x)*cos(y)*sqrt(x^2 + y^2)

x = range(-5, length = 100, stop = 5)
y = range(-5, length = 100, stop = 5)
z = f.(x, y')

surface(x, y, z) works in CairoMakie


Zipkin tracer always sets http schema for the http.url

https://github.com/envoyproxy/envoy/blob/22495511076a0904d5465413e706d73d82fe79f6/test/common/tracing/http_tracer_impl_test.cc#L239
For https urls, envoy reports 'http'.
While it pretty minor, it could be misleading

@objectiser @rshriram ^

Not sure I see the issue - this is just a test which happens to use the http protocol value. The protocol used in the path_prefix matches the x-forwarded-proto header used in the test.
The protocol used in building the actual http.url tag is obtained from the request headers, so could be https.
Do you have a reproducer demonstrating that this is not actually working as expected?

Ah thanks @objectiser. Sorry did not look at this in detail.

Closing as answered. Please reopen if it looks like there is an issue here.


Couldn't authenticate with the credentials provided error

Simple question I know but I am trying to connect to my Azure subscription (MSDN if that makes a difference). But getting "We couldn't authenticate with the credentials provided".
The Tenant name I am using is xxxxxxx.onmicrosoft.com, is that correct?  I'm am trying to authenticate using my windows credentials, which is my Hotmail account.  But doesn't seem to want to let me connect, or if I choose alternate credentials and enter my Hotmail account details.

Sorry sorted the access issue, used the organisation sign in option, normally you can't use that with Hotmail accounts


Add token-level write rule validity checking logic

Change summary:

Add token-level validity checking logic for write rules using a javascript tokenization library (spree)
(Notably only top-level tokens (e.g. auth, newData not auth.addr nor newData.proposer) are checked)
Add tools/tokenizeRule.js util tool for rule tokenization
Directory name change: diff-json -> json-diff

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/614

Comments addressed. PTAL @liayoo

Thanks for the review. Passed all tests and now being merged..


Eliminate redundant work in type inference

With this PR we eliminate redundant work in type inference. Previously, we would explore instantiations of the same generic type up to five levels deep in type inference (which mirrored what we do in relationship checking to detect infinitely recursive types). We now explore just one level as no further inferences will be made beyond that anyway.
This PR doesn't include a regression test as the original issue only reproduces with the fp-ts library. However, I have manually verified that the out of memory issue is fixed and the compile time for the repro is less than 1s. Also, I have verified there are no changes in the real world code suites.
Fixes #15443.

will it be part of 2.3.3 ?

will it be part of 2.3.3 ?

no. this is TS 2.4 bound.

I'm using Version 2.4.0-dev.20170519 and I've found that the project I shared above no longer has this issue, however I have a separate project that doesn't compile due to this memory issue.
Has anyone else found the same? Will require some work to share a test case.

Was the other project compiling on 2.3?

@mhegazy Here is the other project that runs out of memory when compiling on 2.4.0-dev.20170519 and 2.3.
https://github.com/OliverJAsh/ts-2.4-memory-issue/compare/2.4.0-dev.20170519


GitTopApi not working

The gitTopApi function isn't working and the repo service was dependent upon it. I was going to use the repo service to get the top language for the user. Fortunately, there was a comment telling me that the gitTopApi "No works!", but I'd like to know why so I can figure out how and where to make the next services that are dependent upon getting the users' repos.

gitTopApi should be working now, I believe I updated the url, but if not you need to add 'https://crossorigin.me/' to the front of the git-awards api url.
git-awards api has CORS enabled, so using crossorigin.me allows you to make the calls.
an example of using crossorigin.me :
$http.get("https://crossorigin.me/http://git-awards.com/api/v0/users?city=los+angeles&language=shell").then(function(){
//Stuff to do after returned promise
});

Awesome. Thanks for the update!
On Mon, May 22, 2017 at 2:01 PM, Brett Reinhard<EMAIL_ADDRESS>wrote:

gitTopApi should be working now, I believe I updated the url, but if not
you need to add 'https://crossorigin.me/' to the front of the git-awards
api url.
git-awards api has CORS enabled, so using crossorigin.me allows you to
make the calls.
an example of using crossorigin.me :
$http.get("https://crossorigin.me/http://git-awards.com/api/v0/users?city=los+angeles&language=shell").then(function(){
//Stuff to do after returned promise
});
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MarioEsparza/GitNear/issues/4#issuecomment-303218919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMNhH44hnBsWW61XWAaWFfdVmgj7oDTOks5r8febgaJpZM4Ni2iV
.

No problem!

@robertisandor
app.factory('topLocationService', ['$http','$q', function ($http,$q) {
    return {
        getUsers: function (location, language) {
            console.log("Service Location: ", location, "FilterBy: ", language)
            var apiPath = 'https://crossorigin.me/http://git-awards.com/api/v0/users?city=' + location + '&language=' + language;

            return $http.get(apiPath)
                      .then(function (result) {
                          return result.data;
                      }, function (error) {
                          return error;
                      });
        }
    }
}]);

Here is a sample for how to use it in the home controller
var getData = topLocationService.getUsers(locationToken, languageToken);
        getData.then(function (response) {
            console.log(response);
            //console.log(response);
            $scope.returnData = response;
            resultLength = $scope.returnData.total_count;
            //console.log("GitHub # of Users: ", $scope.returnData.total_count);
            console.log("These are the Top users");
            console.table($scope.returnData.users);
});


Can I choose to generate OpenAPI 3.0 files instead of 2.0 ?

I've succesfully generated the swagger files from my server but they are all in version 2.0. I could convert them one by one using the Swagger Editor but I was wondering if I can do it directly from th codegen.
Thanks!

Hi Luis, have you tried using the OpenApiVersion setting?  It should be availabe in the UI as OpenApiVersion and is available in the CLI as part of language-options, e.g.:
fhir-codegen --fhir-server-url http://example.org/fhir --language OpenApi --language-options OpenApi|OpenApiVersion=3


Unable to obtain data by used Binance Websocket

wss://fstream.binance.com
setup the path /ws/bnbusdt@aggTrade
always show loading but no data

Hi, instead of split, you can use like wss://fstream.binance.com/ws/bnbusdt@aggTrade as whole URL.
this is working


Documentation of Private Filesystem and Other Cleanups

Summary

This PR adds and updates existing documentation, doc tests and makes other API clean ups.

[x] Add doc tests
[x] Fix API snags like Rng/RngCore diffs
[x] Update README
[x] Update logo

Test plan (required)

Testing the Rust core.
cargo test -p wnfs --release

Testing the wasm bindings.
cd crates/wasm

yarn playwright test

Closing issues

Codecov Report

Merging #68 (10b3702) into main (07d026c) will decrease coverage by 0.20%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   77.51%   77.31%   -0.21%
==========================================
  Files          26       24       -2
  Lines        1419     1424       +5
==========================================
+ Hits         1100     1101       +1
- Misses        319      323       +4

Impacted Files
Coverage Δ

crates/fs/common/blockstore.rs
72.22% <0.00%> (ø)

crates/fs/examples/private.rs
0.00% <0.00%> (ø)

crates/fs/private/namefilter/bloomfilter.rs
67.44% <0.00%> (-8.88%)
:arrow_down:

crates/fs/private/namefilter/namefilter.rs
100.00% <ø> (ø)

crates/fs/public/directory.rs
78.90% <ø> (ø)

crates/fs/public/node.rs
57.74% <0.00%> (ø)

crates/fs/private/key.rs
54.16% <14.28%> (-14.26%)
:arrow_down:

crates/fs/common/utils.rs
69.23% <75.00%> (+2.56%)
:arrow_up:

crates/fs/private/forest.rs
77.77% <75.00%> (ø)

crates/fs/private/directory.rs
81.49% <100.00%> (ø)

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

minor: @appcypher maybe we should make patch just informational vs threshold for project (related to codecov)

@zeeshanlakhani If I understand you correctly, you are suggesting removing the threshold for now?

@appcypher yep, just for patch (not project)


preserve comma in cell value

Is there a way to preserve the comma in the cell value? I have a port column that contain multiple ports separated by a comma; e.g. 80,443 becomes 80443.

Number format with style
On Sep 6, 2017 12:08 PM, "riv3n"<EMAIL_ADDRESS>wrote:

Is there a way to preserve the comma in the cell value? I have a port
column that contain multiple ports separated by a comma; e.g. 80,443
becomes 80443.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dtjohnson/xlsx-populate/issues/81, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7q0ZRWwhRWd6ysI1xhg83sPwySV-7Aks5sfu2TgaJpZM4PO1fg
.

Thank for replying. I tried applying the style to the whole column, but it appears to be unchanged:
 ws.column("D").style("numberFormat", "#,###");     ws._rows.forEach(row => {       let server = new Object();       server['host'] = row._cells[1].value().trim();       server['IPorMask'] = row._cells[2].value().trim();       server['protocol'] = row._cells[3].value().trim();       server['ports'] = row._cells[4].value();

Thank you for replying. I tried applying the style to the whole column, but it appears to be unchanged: https://gist.github.com/riv3n/e923104e2eec0aa325a6fcad7b14b549

hmm.. then i suppose just try to  apply it to each cell first to make sure that its working.. i did test that #,### would do what you wanted. and it does.. at least on LibraOffice

Looks like you're parsing data from the workbook. What seems to be going on
is that the source data in the workbook is stored as a number, not a
string. The comma you see is just Excel formatting. All that gets stored in
the workbook is the raw number and a format code. Can you change the source
workbook to use a string value?
On Sep 6, 2017 3:41 PM, "Alan"<EMAIL_ADDRESS>wrote:

hmm.. then i suppose just try to apply it to each cell first to make sure
that its working.. i did test that #,### would do what you wanted. and it
does.. at least on LibraOffice
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dtjohnson/xlsx-populate/issues/81#issuecomment-327591813,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANWkxv2PNRsrn-LRwp5ELwAJL9Y68E5ks5sfvVXgaJpZM4PO1fg
.

Thank you. I changed the source data to a string.


Add EasyEDA for drawing electric circuits and pcbs

Please support OS software and suggest KiCad EDA instead! http://kicad-pcb.org/
Both OSH Park and Aisler support upload of KiCad files directly instead of gerber files.

Thanks, we have KiCAD listed already: https://moorepants.github.io/eme185/pages/technical-resources-and-tips.html but I can add the link you shared.

Good to know @stephf0716 is an OSS supporter :smile:


HLAE

csgo wont run, your update 2 days ago worked well but today new update came.

yeah! Here I am have error appcrash in  AfxHookSource.dll.
please FIX.


Add 4-bit conv kernel support

Add 4-bit conv kernel support
Manually added files in tensorflow/lite/micro/*
BUG=b/248328557

Does this PR correspond to http://cl/480909268? If so, happy to approve as-is and address comments in follow-up PR.

Let's update the PR description to reflect that it is the open source equivalent of and already reviewed and approved http://cl/480909268

Does this PR correspond to http://cl/480909268? If so, happy to approve as-is and address comments in follow-up PR.

Let's update the PR description to reflect that it is the open source equivalent of and already reviewed and approved http://cl/480909268

It's the equivalent. Sure.


Example 2 is incorrect

Example 2 is titled "Register a remote DNS server to a directory application partition using FQDN"
This command adds the local DNS server to a directory application partition named "hr.dept.contoso.com"
The correct command would be:
Register-DnsServerDirectoryPartition -ComputerName  "DNS01.dept.contoso.com" -Name "hr.dept.contoso.com"
The description below would then be:
This command adds the remote DNS server, DNS01.dept.contoso.com, to the directory application partition named hr.dept.contoso.com.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 905ebaa7-30d0-3cdf-2e25-599655aa0995
Version Independent ID: 34c37722-6df1-9e69-6cfe-38c97d9ec876
Content: Register-DnsServerDirectoryPartition (DnsServer)
Content Source: docset/winserver2022-ps/dnsserver/Register-DnsServerDirectoryPartition.md
Product: w10
Technology: windows
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Revert "Add external links to the 'docs' directory"

Reverts iWebster28/continuous-integration-circle#5

Unused


feat: Deprecate transfer and asset modules

Follows on from #287.
Changed:

Up to date documentation for rekeyAccount, AlgorandClient, asset, dispenser client, indexer, testing, transfer
Collapsed the second object in algorand.send.type(params, executeOptions) to combine into params and make it easier to use based on devrel feedback
Order of algorand.account.rekeyed() parameters to be rekeyed(sender, signer) since it conceptually makes more sense (the sender is rekeyed so should come first)
All microAlgo return values from algorand.account.getInformation() now return an AlgoAmount, renamed amount to balance and round to validAsAtRound (which is now a bigint for broader consistency)
Return value of algorand.send.assetCreate now includes { assetId: bigint }

Added:

AssetManager class and algorand.asset.getById()
indexer export off of @algorandfoundation/algokit-utils as the future home of all indexer methods
Added algorand.client.getTestNetDispenserFromEnvironment
Added algorand.account.assetBulkOptIn
Added algorand.account.assetBulkOptOut
Added algorand.account.ensureFunded
Added algorand.account.ensureFundedFromEnvironment
Added algorand.account.ensureFundedFromTestNetDispenserApi
Added algorand.account.rekeyAccount
Added algorand.send/transaction.assetOptOut

Deprecated:

algokit.createAsset
algokit.assetOptIn
algokit.assetOptOut
algokit.assetBulkOptIn
algokit.assetBulkOptOut
algokit.ensureFunded
algokit.transferAsset
algokit.rekeyAccount
algokit.transferAlgos

Haven't done a proper review yet, but not sure how I feel about algorand.send/transaction.rekey. On one hand it's nice to have such an important operation be so explicit. On the other hand, I'm worried it might give developers the incorrect impression that a rekey is a special transaction type.

No different to opt-in/opt-out imo

Also allows for a really explicit approach to such a dangerous but useful operation with a minimal set of parameters with intellisense  we could illustrate in the method description that rekey can also be added to any other transaction by setting the optional rekeyTo value?

No different to opt-in/opt-out imo

To me the main difference is that there are no negative consequences of a developer thinking optin/out is a seperate tx type. With rekeys, however, if a developer thinks that rekey is a special transaction type and reads code somewhere with a payment transaction or appl, they might be oblivious to the fact that it's rekeying an account.
Essentially I'm nervous it might "train" developers to look for .rekey calls rather than rekeyTo fields

Another option is to add it to account manager as a method.

Another option is to add it to account manager as a method.

Yeah I like that. Makes it more clear that it's abstraction and not a transaction type

Cool, done.
Funnily enough it was how I originally wrote it, but then I decided to make it a composer thing so you could get the transaction separate to sending it. I think that's a minor benefit though.

small nit: I would change rekeyAccount to rekeyAddress. In general as we start to get HD wallet support we should try to avoid using "account" to refer to a single address.

why we decided to support a union of string | TransactionSignerAccount for address fields?

It was so that you could pass in the result of something like const alice = algorand.account.random() in i.e. you can pass in alice and not have to do alice.addr i.e. algorand.send.payment({from: alice, to: bob}) reads much nicer than algorand.send.payment({from: alice.addr, to: bob.addr})
We could remove that and just stick with string of course if we felt it was too confusing...

Also, I see a lot of changes to the formatting of how we saw "Algos". Personally I think non-plural ALGO is the most common. Ie. "I have 10 ALGO" vs "I have 10 Algos"

It's a tough one because I see it written in different ways everywhere, it's wildly inconsistent. I'm not opposed to just using ALGO though, more than happy with that?

Should the bulk functions go in the AssetManager?

I thought about that. Maybe that makes sense? I put in account because it was being done in the context of an account, but AccountManager is a really big class now and you could argue either way, so maybe AssetManager is better?

It was so that you could pass in the result of something like const alice = algorand.account.random()

This begs the question... why not just have .random return a string? Returning an object with the signer makes sense when we are concerned about legacy interop, but now that we're deprecating legacy utils functions maybe it just makes more sense to return a string? I suppose the question really is where do we expect developers to use the signer function manually rather than using it implicitly through the AlgorandClient

It's a tough one because I see it written in different ways everywhere, it's wildly inconsistent. I'm not opposed to just using ALGO though, more than happy with that?

Yeah I don't have a strong opinion on it but consistency is nice at least within the libs we control. Perhaps we can just do a quick poll in slack to see what everyone prefers and just stick with that everywhere.

I thought about that. Maybe that makes sense? I put in account because it was being done in the context of an account, but AccountManager is a really big class now and you could argue either way, so maybe AssetManager is better?

Yeah I can see the argument either way. I personally leans towards AssetManager but have no objections for AccountManager. Although since AccountManager is already a big class and these are relatively uncommon functions to use, it might make more sense to put under AssetManager just for that reason.

I like the simplicity of returning a string, but it feels very wrong from an object oriented / code semantics perspective. ‘String’ is too generic a type for something that important and it would make it much harder to detect when you’re passing the wrong thing in the wrong place maybe?
agree on the other too. Did you want to raise the poll for algos?

I like the simplicity of returning a string, but it feels very wrong from an object oriented / code semantics perspective. ‘String’ is too generic a type for something that important and it would make it much harder to detect when you’re passing the wrong thing in the wrong place maybe?

I agree but also think that's just the nature of nominal type systems. I'm not convinced it's worth creating an object just for this purpose.

agree on the other two. Did you want to raise the poll for algos?

Just posted in slack 👍

Regardless of whether we decide to do string or not, it makes sense to decouple that from this PR since it's a much wider / bigger / unrelated change.
I also didn't change rekeyAccount to rekeyAddress because there are many other things that tie account = single address, that's a broader change that will somehow need to be incorporated into the Algorand ecosystem with thought to avoid confusion.
Otherwise incorporated all the other feedback.


Development: Add documentation for bonus, publishing example solutions, plagiarism checks for exams and special grades

Checklist
General

[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Documentation for bonus, publishing example solutions, plagiarism checks for exams and special grades features are currently missing.
Description

Add the missing documentation and update the grading key screenshots to reflect the latest UI improvements.
Steps for Testing

Proof read content added to docs (https://artemis-platform--6087.org.readthedocs.build/en/6087/)
Proof read content added to README.md

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

@b-fein Thanks, I fixed the warnings in https://github.com/ls1intum/Artemis/pull/6087/commits/d382d58a98790ecfc0964407172e02ebb8002271


Reduce activity in disabled colours in dark mode

Suggestions have been made. A review will be taken when we color all the new components in 2.0. The new tasks will be added and we will take a review on them then.


Fruther customization of deployment+daemonset via helm chart

Describe the solution you'd like
It would be very useful to add further daemonset/deployment options to the spec via the helm chart.
Options that I would like to see

NodeSelector/Affinity
ResourceQuotas
Enabling Metrics(For the DS)

Describe alternatives you've considered
You can currently deploy with tridentctl + custom yaml, but then we don't get the numerous benefits of the operator and a helm chart.

At least for NodeSelector/Affinity (as well as tolerations) this is solved by 84cdd03e54af27c08354cd4cf0bb91e3d3cf7a2e
Therefore should be part of the upcoming 22.01 release.

Those seem to effect the operator deployment. I need to be able to configure the trident-csi(deployment/daemonset) the operator deploys.

To elaborate I would like the same ability as with imagePullSecrets for the above mentioned configurations

https://github.com/NetApp/trident/blob/master/helm/trident-operator/values.yaml#L29
https://github.com/NetApp/trident/blob/master/cli/k8s_client/yaml_factory.go#L844

Sorry, my bad. Yes, the above was for the operator. Noticed a further commit, that addresses it for the daemonset: e167c7e92e143e4bb4a8373ff0dc9f41c374cd42
For NodeSelector and Tolerations.

Awesome that looks perfect!


Fix ExpansionTile double tap to collapse/expanded and expanded/collapsed states semantics announcements

fixes https://github.com/flutter/flutter/issues/120650

code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              ExpansionTile(
                title: Text('Flutter Forward'),
                children: <Widget>[
                  FlutterLogo(size: 100),
                ],
              ),
              SizedBox(height: 20),
              ExpansionTile(
                initiallyExpanded: true,
                title: Text('Flutter Forward'),
                children: <Widget>[
                  FlutterLogo(size: 100),
                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Demo
https://user-images.githubusercontent.com/48603081/219380650-58381edd-178a-4c31-9c02-14b4d68cfd21.mp4
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai
Updated the PR for the onTapHint label, however for iOS, there is no hint for the list tile or related widgets such as the expansion tile so I want to fix the list tile and other widgets together in a separate PR.


Retry downloading gems consistently across all versions of RubyGems

What was the end-user problem that led to this PR?
Gem::RemoteFetcher::FetchError failures were not being retried when downloading gems. Retrying downloading of gems for network blips is very ideal and helpful in CI environment.
What was your diagnosis of the problem?

The retry logic that existed (using Bundler::Retry) for Bundler::RubygemsIntegration#download_gem was not getting called, becase Bundler.rubygems defaulted to a sub class of Bundler::RubygemsIntegration::MoreFuture, which inherited from Bundler::RubygemsIntegration::Future and #download_gem in there didn't perform download with retry logic.
Sending Gem::RemoteFetcher::FetchError as an argument to Bundler::Retry meant, Bundler::Retry would fail first thing, if exception being raised was the one being supplied. The intent is to retry when downloading fails.

Example of how sub classing issue looked like:
class RubygemsIntegration
  def download_gem
    "I retry when downloading"
  end
end

class Future < RubygemsIntegration
  def download_gem
    "I don't retry when downloading"
  end
end

class MoreFuture < Future
  # no download_gem
end

mf = MoreFuture.new #=> Bundler.rubygems where RubyGem version is > 2.1.0
mf.download_gem
 => "I don't retry when downloading"

Example of Bundler::Retry
Bundler::Retry.new("download gem from", StandardError).attempts do
  puts "I will only print once, whereas I should print 4 times"
  raise StandardError.new("FooBar")
end

What is your fix for the problem, implemented in this PR?
I added the retry logic for to Bundler::RubygemsIntegration::Future#download_gem and removed Gem::RemoteFetcher::FetchError as an argument for failed exceptions.
Why did you choose this fix out of the possible options?
I chose this fix because this fix fulfills the expected behavior(https://github.com/bundler/bundler/issues/4846). Also added specs that makes sure retry logic is intact, which otherwise would have failed without the current logic in place.

cc @segiddins || @indirect (as you have context on the original issue) 🙂

Awesome, thanks!
@bundlerbot r+

🙌 @segiddins
Do you think there is a possibility of releasing a PATH/MINOR version involving this change? 🙂

Why not! I can do this in a 1.15.4 tomorrow since I'm sure it'll cherry pick cleanly

❤


Making transformation an optional parameter in FasterRCNN

Hello,
🚀 Feature
I think it would be more generic to have transform(https://github.com/pytorch/vision/blob/3d65fc6723f1e0709916f24d819d6e17a925b394/torchvision/models/detection/faster_rcnn.py#L231) as a function that can be modified by users rather than a default one.
Motivation
I am applying transformations separately as a part of data augmentation, which includes cropping and resizing. Hence I would prefer to not do the twice while retraining FasterRCNN.
Pitch
I would like to have a fixed size input to be fed into the network for variable-sized images. At present, I do this by resizing the images separately as a part of DataLoader and adjust the parameters of GeneralizedRCNNTransform accordingly.
Alternatives
My present way of using FasterRCNN is an alternative. Since my set of transformations are pre-defined, I have to apply hacks such as setting mean to 0., std to 1. and altering min and max sizes to my default value(this would mean that scale=1 and interpolation would return the same image.
Additional context
While the input to the network is fixed size, I apply many other augmentations such as mirror, random cropping etc, inspired by SSD based networks. Hence I would prefer to do all augmentation in a separate place once instead of twice.
Thank you!
Edit : If you think this would be a meaningful change, I will be happy to send a Pull Request.

Furthermore, this transformation class does not handle cases when targets are empty, leading to this error.
loss_dict = model(images, targets)
  File "/home/envs/tf13/lib/python3.7/site-packages/torch/nn/modules/module.py", line 547, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/envs/tf13/lib/python3.7/site-packages/torchvision/models/detection/generalized_rcnn.py", line 47, in forward
    images, targets = self.transform(images, targets)
  File "/home/envs/tf13/lib/python3.7/site-packages/torch/nn/modules/module.py", line 547, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/envs/tf13/lib/python3.7/site-packages/torchvision/models/detection/transform.py", line 41, in forward
    image, target = self.resize(image, target)
  File "/home/envs/tf13/lib/python3.7/site-packages/torchvision/models/detection/transform.py", line 76, in resize
    bbox = resize_boxes(bbox, (h, w), image.shape[-2:])
  File "/home/envs/tf13/lib/python3.7/site-packages/torchvision/models/detection/transform.py", line 137, in resize_boxes
    xmin, ymin, xmax, ymax = boxes.unbind(1)
IndexError: Dimension out of range (expected to be in range of [-1, 0], but got 1)

Hi,
Thanks for opening the PR!
Exposing a transform argument to FasterRCNN is a tempting idea, and I think it could be done.
But it means that it would be conflicting with the following arguments https://github.com/pytorch/vision/blob/3e69462ff5549b2f3a9347859f7c4aba1a8c34ac/torchvision/models/detection/faster_rcnn.py#L145-L146
I think it could be fine if we do proper error checking. This means we would need to change the default values to be None, and then do
if transform is not None:
    if min_size is not None:
        raise ValueError(...)
    if max_size is not None:
        raise ValueError(...)
else:
    transform = ...

That being said, after the model is instantiated, it is fairly easy to change the transform by doing something like
model = fasterrcnn_resnet50_rpn()
model.transform = MyTransform()

but I'm not against exposing this to the user.

About the error message, I believe this is an issue with the targets being passed to the model, and we have added some informative error message in https://github.com/pytorch/vision/pull/2207
Let us know if this isn't the case, IIRC we are still missing error checks for masks and keypoints

Hi Francisco,
Thank you for your response. Why would we need the min_size, max_size, image_mean, image_std param separately? Could this not be integrated with GeneralizedRCNNTransform ? My idea is the user passing something like,
frcnn = FasterRCNN(backbone, transform=GeneralizedRCNNTransform(min_size, max_size, image_mean, image_std))

@Sentient07 we already support passing min_size etc to the model. So what should we do if the user specifies the model as follows:
model fasterrcnn_resnet50_fpn(transform=MyTransform(), min_size=500)

as you can see, now min_size is unused by the model, and this can lead to subtle errors on the user side because they will change min_size but won't see any difference in predictions (because the predictions are always rescaled back to the original image size)

Hi @fmassa ,
I don't understand your question,

So what should we do if the user specifies the model as follows:
model fasterrcnn_resnet50_fpn(transform=MyTransform(), min_size=500)

If they want to specify min_size, shouldn't it go inside MyTransform() which would take care of their expectations?. Since min_size, max_size, image_mean, image_std parameters aren't used outside of GeneralizedRCNNTransform , I think we can safely remove them. If the users want a custom  min_size, max_size, image_mean, image_std parametrisation, they can pass transform=GeneralizedRCNNTransform(**custom_vals) . I will send a PR soon to elaborate what I mean.
Thanks!

@Sentient07 I've answered in the PR, let me know what you think

I wonder if it's still interesting to someone, I can try to give it a try, should I open new PR or continue Custom transform support #2288?

I believe yes, FASTER-RCNN's job should only be learning and inference, while resizing and others should be other object's responsibilit, I'm having a hard time training and inferencing since with the current implementation everything feels so flimsy and what if I want to inference diference sized images?  https://discuss.pytorch.org/t/faster-rcnn-image-size-and-weird-transform-behaviour/121414

ok, so I will try to fix it. For now I am using messy but working workaround (@qornifmlx, maybe this will help you):
                       rpn_anchor_generator=anchor_generator,
                       box_roi_pool=roi_pooler,
                       box_head=box_head,
                       box_predictor=box_predictor,
                       image_mean=(0,),
                       image_std=(1,),
                       max_size=1000,
                       min_size=220)

    # calculate mean and std from data

    transform = T.Normalize(image_mean=(mean,), image_std=(std,))
    model.transform = transform```
Normalize was just ripped from `torchvision/models/detection/transform` from GeneralizedRCNNTransform class
But I guess, that you are already using some kind of preprocessing


Set repo's website

Best to point this to our documentation: http://drone-python.readthedocs.org/

Done!


Supernode should add clear process

Why
dfclient will clear repo data after 3 mins, howerver supernode hasn't clear process . It extremely easy cause disk overflow.
could be

Regular cleaning
Must have rules : clear long-term non-access images except access frequently images
New pull disk overflow error, clear forcibly

We are doing it in the pr #779. Welcome to have a review.


refactor: Start moving NS related logic to own module

Moving a single function initially for PoC and to keep changes small.

Similarly to a module for dealing with NS mod related stuff, we also want one for dealing with Northstar itself. ^^


Update after the rename of a repo

Update after the rename of the fabric8-tenant-che-migration repo to che-tenant-maintainer

Can one of the admins verify this patch?

please do not merge these PRs where content is bein renamed or deleted, it causes duplicate jobs on ci.centos.org


HBASE-28217 PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.


Low GPU utilization ratio

For Windows and 2060,  GPU utilization is very low when it do inference.

Can you provide the utilization ratio for the card? And what is the performance for other gpu device in
your environment?


(PUP-10598) Update expectation when puppet agent fails

Prior to PUP-10598, puppet would ignore the pluginsync errors due to the
non-existent environment on the server and would fail when trying to request a
catalog.
As of PUP-10598, puppet will fail on the first pluginsync error, so the error
message is different. The overall behavior is similar though. The cached catalog
is ignored since puppet agent --test implies --no-usecacheonfailure.

I tested this with:
$ bx rake ci:test:aio TESTS=tests/environment/environment_scenario-bad.rb SHA=fe17a67beea14a6c8a901931e62e99ad73d10d33 TEST_TARGET=redhat7-64a OPTIONS='--preserve-hosts=always'

And then added the agent role to the puppetserver node and re-ran the test:
$ bx beaker exec tests/environment/environment_scenario-bad.rb

And both passed.

windows/ruby 2.7 failure is related to https://tickets.puppetlabs.com/browse/PUP-10689


Change strategy when system_attributes is unknown

In Update(), create prototype system_attributes (with empty tags) when system_attributes has been omitted.

This is probably referring to the apstra_datacenter_device_allocation resource


Same table names in different postgres schemas

Hi, is there a way to force the schema name to be included on the go code generated with the tables command?
Right now we're running it for each distinct schema and outputting to and appropriate subpackage, but it'd be easier if we could run it once only and have the types named as, for example, type SCHEMA_TABLE struct ...
Thanks!

I could make it so that type TABLE struct is generated by default, but the moment there are any duplicate table names it will generate type SCHEMA_TABLE struct instead. Does that work for you?

Thank you for the quick reply!
That works and solves our problem.  It'd be great if we could also have all the tables with the SCHEMA_TABLE name using some flag, but not a big deal if not.
Thanks.

It'd be great if we could also have all the tables with the SCHEMA_TABLE name using some flag

Yeah I think I'll do it after all, so users have the option of generating type SCHEMA_TABLE struct or type TABLE struct. The automatic type SCHEMA_TABLE struct behaviour will still be there because it's almost always an error if there are two generated table structs with the same name. The new flag to include the schema in the generated struct name would be called -schema-qualified-structs.

The automatic type SCHEMA_TABLE struct behaviour will still be there because it's almost always an error if there are two generated table structs with the same name

Actually maybe not, I'll just add the flag option first and if someone wants the automatic schema qualified names behaviour in the future I'll add it back in.

I've committed it, update to v0.4.4 to get the changes.

v0.4.4 has a bug, I forgot to set the sq struct tag for schema qualified tables. This means when sqddl parses those table structs, the table name would accidentally include the schema SCHEMA_TABLE instead of just TABLE. You should update to v0.4.5 instead 👍


added a file through local parse dashboard but not able to fetch file from Parse Dashboard

uploaded a file from "http://<IP_ADDRESS>:4040/apps/" (local parse dashboard) and url path created = "http://<IP_ADDRESS>:1337/parse/files/C1VnZXIeJNdNJ9O2XEUtwLTsliB5n9JJJogJaqhD/37a35b2aedaf7ef6d8a311a4d493df80_Another Fashionista.jpg"
but when
fetch file from "dashboard.parse.com"
url = "http://files.parse.com/e778c7af-d0d7-49f9-87a2-9ffa8f020891/37a35b2aedaf7ef6d8a311a4d493df80_Another Fashionista.jpg"
"This XML file does not appear to have any style information associated with it. The document tree is shown below.

AccessDenied
Access Denied
A8E05071BC963484

UaqYAae2OGOcN07RriU/MlW9otrjPDrXVs0g5lYSUBSQRdOp+9XAexQw7p891NNnXJK/zHIMkFg=

"

Facing the same issue. Is there a solution or workaround for this?

Any solutions on file migration here?

I'm facing the same issue as well. Please provide any workaround.


[TEST] - Add new load/save tests

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/trans/steps/rssoutput/RssOutputMeta.java
engine/src/org/pentaho/di/trans/steps/script/ScriptAddClasses.java
engine/src/org/pentaho/di/trans/steps/script/ScriptValuesScript.java
engine/test-src/org/pentaho/di/trans/steps/nullif/NullIfMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/prioritizestreams/PrioritizeStreamsMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/replacestring/ReplaceStringMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/rest/RestIT.java
engine/test-src/org/pentaho/di/trans/steps/rest/RestMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/rowgenerator/RowGeneratorMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/rssinput/RssInputMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/rssoutput/RssOutputMetaTest.java
engine/test-src/org/pentaho/di/trans/steps/script/ScriptMetaTest.java
Unit test coverage change:
org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change : -1.64%
Complexity Change : -.69%
Instruction Change : -2.43%
Line Change : -3.70%

org.pentaho.di.trans.steps.ifnull.IfNullMeta:

Branch Change : -2.38%
Complexity Change : -1.64%
Instruction Change : -.17%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta:

Instruction Change :  + .06%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

Instruction Change : -.07%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta:

Branch Change :  + 36.84%
Complexity Change :  + 48.48%
Instruction Change :  + 62.28%
Line Change :  + 55.36%
Method Change :  + 59.57%

org.pentaho.di.trans.steps.rssinput.RssInputField:

Branch Change :  + 31.82%
Complexity Change :  + 53.85%
Instruction Change :  + 83.09%
Line Change :  + 75.71%
Method Change :  + 74.42%

org.pentaho.di.trans.steps.rssinput.RssInputMeta:

Branch Change :  + 47.50%
Complexity Change :  + 67.86%
Instruction Change :  + 72.52%
Line Change :  + 68.10%
Method Change :  + 80.56%

org.pentaho.di.trans.steps.rssoutput.RssOutputMeta:

Branch Change :  + 38.71%
Complexity Change :  + 80.15%
Instruction Change :  + 80.21%
Line Change :  + 76.84%
Method Change :  + 93.00%

org.pentaho.di.trans.steps.script.ScriptMeta:

Branch Change :  + 11.64%
Complexity Change :  + 27.68%
Instruction Change :  + 30.38%
Line Change :  + 28.31%
Method Change :  + 62.16%

org.pentaho.di.trans.steps.script.ScriptValuesScript:

Complexity Change :  + 16.01%
Instruction Change :  + 23.56%
Line Change :  + 10.46%
Method Change :  + 23.48%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Instruction Change :  + .18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta:

Branch Change : -3.33%
Complexity Change : -1.85%
Instruction Change : -.28%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta:

Branch Change :  + .53%

License header violations:

Couldn't find acceptable license on engine/test-src/org/pentaho/di/trans/steps/rssoutput/RssOutputMetaTest.java


Connection Failed: Server is not wrapping data

I re-compiled this program with protobuf 2.5 version.
when I use hdfs3 with libhdfs3 I found the error.
[root@datanode-2 ~]# python
Python 2.7.13 |Anaconda custom (64-bit)| (default, Dec 20 2016, 23:09:15)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
Anaconda is brought to you by Continuum Analytics.
Please check out: http://continuum.io/thanks and https://anaconda.org
>>> import ctypes as ct
>>> ct.cdll.LoadLibrary('libhdfs3.so')
<CDLL 'libhdfs3.so', handle 1e1d270 at 7f9c1c76ce90>
>>> from hdfs3 import HDFileSystem
>>> client = HDFileSystem(host='namenode-1',port=9000,ticket_cache='/tmp/krb5cc_0')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/gavial-anaconda2/lib/python2.7/site-packages/hdfs3/core.py", line 75, in __init__
    self.connect()
  File "/usr/local/gavial-anaconda2/lib/python2.7/site-packages/hdfs3/core.py", line 136, in connect
    raise ConnectionError('Connection Failed: {}'.format(msg))
hdfs3.compatibility.ConnectionError: Connection Failed: Server is not wrapping data

I don't know why!
[root@datanode-2 ~]# protoc --version
libprotoc 2.5.0
[root@datanode-2 ~]# /usr/local/gavial-anaconda2/bin/conda list|grep proto
libprotobuf               2.5.0                         0
protobuf                  3.3.2                    py27_0    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
xorg-kbproto              1.0.7                         1    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
xorg-renderproto          0.11.1                        1    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
xorg-xextproto            7.3.0                         1    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
xorg-xproto               7.0.31                        6    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
[root@datanode-2 ~]# /usr/local/gavial-anaconda2/bin/conda list|grep hdfs
hdfs3                     0.2.0                    py27_1    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
libhdfs3                  2.3                           0    https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge
python-hdfs               2.0.16                   py27_0    conda-forge

I replace the compiled package libhdfs3.so.2.2.31 to anaconda2/lib/libhdfs3.so.2.2.31
when I compile the program with other version protobuf, I get another error:
[root@datanode-3 ~]# python
Python 2.7.14 |Anaconda custom (64-bit)| (default, Oct 27 2017, 18:21:12)
[GCC 7.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import ctypes as ct
>>> ct.cdll.LoadLibrary('libhdfs3.so')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/gavial-anaconda2/lib/python2.7/ctypes/__init__.py", line 444, in LoadLibrary
    return self._dlltype(name)
  File "/usr/local/gavial-anaconda2/lib/python2.7/ctypes/__init__.py", line 366, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: libprotobuf.so.15: cannot open shared object file: No such file or directory

I don't know which protobuf version is right.

Any particular reason for compiling this yourself? Most people use the conda package.
Btw: this repo has become a little neglected, you might consider using pyarrow's hdfs interface instead.

I had install hdfs3 and libhdfs3 by conda, but the libhdfs3 installed by conda not support the acl auth.
so I compile it by myself.
Thanks for pyarrow,I will have a try!

pyarrow works good！ Thanks a lot.


BREAKING: Add Footer implementation

https://phabricator.wikimedia.org/T217352
To test locally with a local instance of restbase running, use:
pagelib.c1.PageMods.addFooter(
    document,
    'Knight Lore',  // articleTitle
    [pagelib.c1.Footer.MenuItemType.languages, pagelib.c1.Footer.MenuItemType.lastEdited, pagelib.c1.Footer.MenuItemType.pageIssues, pagelib.c1.Footer.MenuItemType.disambiguation, pagelib.c1.Footer.MenuItemType.talkPage],  // menuItems
    {
        'readMoreHeading': 'Read more',
        'menuDisambiguationTitle': 'Similar pages',
        'menuLanguagesTitle': 'Available in 9 other languages',
        'menuHeading': 'About this article',
        'menuLastEditedSubtitle': 'Full edit history',
        'menuLastEditedTitle': 'Edited today',
        'licenseString': 'Content is available under $1 unless otherwise noted.',
        'menuTalkPageTitle': 'View talk page',
        'menuPageIssuesTitle': 'Page issues',
        'viewInBrowserString': 'View article in browser',
        'licenseSubstitutionString': 'CC BY-SA 3.0',
        'menuCoordinateTitle': 'View on a map'
     }, // localizedStrings
     3,  // readMoreItemCount
     'http://localhost:7231/en.wikipedia.org/v1' // baseUrl for getting ReadMore items
)

And then to add a bookmark icon and text to a single Read more item:
pagelib.c1.PageMods.updateReadMoreSaveButtonForTitle(document, 'Mire Mare', 'Saved for later', true)

Other notes:
This isn't intended to keep working as it did when bundled with the iOS app. The iOS app can stay on an older version of page library and the newer changes should be solely for mobile-html.

Other notes:
This isn't intended to keep working as it did when bundled with the iOS app. The iOS app can stay on an older version of page library and the newer changes should be solely for mobile-html.

@joewalsh What's the main reason to break backwards compatibility for the footer transform?

@joewalsh What's the main reason to break backwards compatibility for the footer transform?
@berndsi it's not worth investing effort in making the footer transform backwards compatible when it'd only be used for a short while before the iOS app upgrades to mobile-html. It's easier to have a clean break and implement it solely in the best way for mobile-html.

I can't officially approve because it was originally my PR, but looks good to me 👍

I can't officially approve because it was originally my PR, but looks good to me

LGTM to me too.

@joewalsh Thank you for fixing the docs.

rebased

rebased again. There were some conflicts that needed to be resolved first.


Move Static Website to Webserver VM

Moving the static website from the blob storage to an Ubuntu VM running apache is a foundational step to showcase how to implement security features into this solution. We will be able to demonstrate how to:

Restrict traffic to the Logic App to only the Webserver IP Address
Restrict traffic to the Logic App from only the Webserver Service Principal

The deployment will be handled through an ARM template to its own resource group.

Closed with PR #20
Web Front end is now deployed to Ubuntu server.


HMS-3157 test: delete domain

This change add a smoke test for checking the delete domain operation of the API.
Depends on: #60

Content cherry-picker on #42 ; closing.


Cannot Import TypeScript Module In Test File

Link to bug demonstration repository.
https://github.com/dawsonc623/nyc-bug-demo
Expected Behavior
Running yarn test should yield passing tests with 100% coverage.
Observed Behavior
Running yarn test fails with the following errors and reports 0% Statement and Line coverage (Branch and Funcs are at 100% presumably because there are none in the file).
TSError: ⨯ Unable to compile TypeScript:
src/app/foo.ts(1,212): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
src/app/foo.ts(1,656): error TS2339: Property 'hash' does not exist on type '{ path: string; statementMap: { "0": { start: { line: number; column: number; }; end: { line: number; column: number; }; }; }; fnMap: {}; branchMap: {}; s: { "0": number; }; f: {}; b: {}; _coverageSchema: string; }'.

There is also a massive stack trace, but it does not seem particularly useful to post the whole thing here.
Forensic Information
Operating System: Ubuntu 18.04.2 LTS on Windows 10 via the Windows Subsystem for Linux
Environment Information: https://gist.github.com/dawsonc623/5d175ea45c6c5fb5359dc11bfeb05df3

try using ts-node/register/transpile-only
from docs https://istanbul.js.org/docs/tutorials/typescript/
--require ts-node/register # replace with ts-node/register/transpile-only if you have custom types

@ljsustainas That works, but it seems to disable type-checking when running the tests. Is there not a "best of both worlds" solution? Either way, thanks for the response!

ts-node is complaining about two specific statements.

var global new Function("return this")();
coverageData.hash = hash;

Running TS_NODE_IGNORE_DIAGNOSTICS=2339,2351 npm t worked for me without switching to transpile-only.  Note this disabled two entire classes of diagnostics so it's not perfect.
We could deal with the TS2339 issue by adding hash to the original declaration of coverageData instead of setting it later.  I created istanbuljs/istanbuljs#336 to deal with this issue, just be aware it will take some time before we can make this change.
I have no solution to the new Function error.  We need a way to find the global context.
The only other thing I can suggest for now is to have your test run twice.  First run without nyc using full ts-node/register, then run with nyc and ts-node/register/transpile-only.

@coreyfarrell Thanks for digging into this deeper. I will set up my tooling to run the tests twice as you suggest. While not completely solved, it is nice to know the root causes were found.

@dawsonc623 istanbuljs/istanbuljs#352 will address the error related to setting coverageData.hash.  Once that is merged / released it will be possible to use TS_NODE_IGNORE_DIAGNOSTICS=2351 npm t which would ignore the single issue type.  I have opened TypeStrong/ts-node#813 to see if they can help with the error 2351.

@dawsonc623 I was actually able to fix both issues you reported here<EMAIL_ADDRESS>has been released to npm to allow easier testing.  Please note that additional breaking changes will occur before 14.0.0 final is released.  I'm closing this issue, you can monitor release progress at #1051.

@coreyfarrell Fantastic news! Thanks for tackling this.


Remove server

This example is very convoluted. I think we can just remove the server to simplify it.

@jenniferabowd In removing the server, will we just be hard-coding those values from into the template itself?
If that's all, please assign me to this, and I'll take care of that. Otherwise, would you mind clarifying the work required here? Thanks!

Yeah, I’m good with them being hardcoded! Thank you so much for your help!

@jenniferabowd Sure thing! I'll get on these in the next day or two. Flying tomorrow 🛩

Safe travels!

Hi, I wanted to check-in on this. If you don't think you are going to get to it, I can unassign you. Also, no rush if you are working on it or got busy with travel!

@jenniferabowd Hey! Yeah, I did get pretty busy with my travels, and I'm not sure when I'll have time next week to circle back to this.
I did make some major headway, so what may be best is if I open a draft PR with the changes I've made so far, so someone can pick up where I left off. Hopefully shouldn't be too much more work involved.

Oh awesome! That's a great idea! Thanks for helping out with this!

@jenniferabowd If you wouldn't mind leaving this assigned to me, I should be able to dive in more next week. Looks like webpack 5 was a pit of a dependency here, so IK just went ahead and did that upgrade, but because the two branches are intertwined/stacked, we'll need to push both simultaneously.

Cool! I think what would be most helpful is having one folder for Webpack 2 and another folder for Webpack 5. I believe the solutions for those versions of Webpack is pretty different, so I figured having both in this repo would be helpful. Thank you so much for all of your help on this!

@jenniferabowd Looks like that should be possible using version aliasing, mentioned here.
Considering the lift that was involved in upgrading webpack 2 → 5, I can only imagine this might be a pretty sizable lift too, so it might help to merge everything open now first and then go back and re-add examples for webpack v2.

@jenniferabowd If you haven't already seen my comment re the intended merge order, please read that first, here.
Could you also please assign me to all those tickets before merging to ensure I'm attributed to their merge?

Sure! Let me review this code. Would you be okay if I go into your PR and do what I meant with the 2 webpack versions? What I had in mind shouldn't take too long.

@jenniferabowd Of course! Make any changes as you see fit


OTP Configuration

Can you review and merge it boss

Ok sir, I will. Hope I've merged successfully now?

Thank @Sodeeqishola5 for the job well-done can you work on the SMS Template and the Set OTP Crendential page

I've completed OTP credentials but SMS Template remain router and small UI amendment

Thank @Sodeeqishola5 for the job well-done can you work on the SMS Template and the Set OTP Crendential page

I've completed OTP credentials but SMS Template remain router and small UI amendment

so when are you finishing it?

Thank @Sodeeqishola5 for the job well-done can you work on the SMS Template and the Set OTP Crendential page

I've completed OTP credentials but SMS Template remain router and small UI amendment

so when are you finishing it?

Before Monday by God grace


Adding unit and integration tests for slp.ts/lookupToken()

Pull Request Test Coverage Report for Build 2665

0 of 0   changed or added relevant lines in 0 files are covered.
291 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 63.068%

Files with Coverage Reduction
New Missed Lines
%

dist/routes/v2/slp.js
291
33.9%

Totals

Change from base Build 2657:
0.4%

Covered Lines:
2236

Relevant Lines:
3374

💛  - Coveralls


Jumping to the top of github

As of now when we press the icon , It will open the Github page in the new tab
But when we are inside Github , It will be nice if it works like jumping to the top of the page
I have to scroll to the top in the Trending ,Explore pages etc.

Pages where it will be useful
https://github.com/trending
https://github.com/explore

“Back to top” buttons should not be provided by each website. Find a way to do on any website, for example by pressing the Home key on windows or CMD->up on Mac.


[ci] release

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

0502327 Thanks @JosefJezek! - Add Czech language support

size-limit report 📦

Path
Size

/index.html
13.17 KB (+0.01% 🔺)

/_astro/*.js
16.22 KB (0%)

/_astro/*.css
8.46 KB (0%)


Change app symlinks to point to Contents

I'm expecting this to be a little controversial. I'm not 100% convinced it's a great idea myself, but boy, do I want a solution to the below problem.
Problem: When adding a symlinked application to the Dock, OS X appears to follow the symlink and actually add the target application bundle to the com.apple.dock.plist, not the source link. As a consequence, when brew-cask upgrades the application to a new version, the Dock icon still launches the old version (or fails if the old version isn't on the system anymore).
Solution: This commit changes the behavior of app linking to create an AppName.app folder containing an AppName.app/Contents symlink, instead of an AppName.app symlink. This gets the Dock to consistently point to the link-containing AppName.app, even when the Contents symlink within is upgraded by brew-cask.
I wrote this with the intent of being backwards-compatible; in particular, installing over either an AppName.app link or an AppName.app/Contents link is allowed, while an AppName.app containing a non-symlink Contents will (still) not be clobbered.

Pinging @phinze @ndr-qef @radeksimko.

I would say this is very counter-intuitive. Also,

I wrote this with the intent of being backwards-compatible;

While this might be backwards-compatible with brew-cask's native functionalities, it's certainly possible to break external commands and user scripts. For instance, I have a script that swaps apps with links to meet sandboxing requirements (i.e., some apps have to live under /Applications, e.g., browsers with the 1Password extension), which would certainly break if this change is (silently) introduced.

Agreed. Our installation should be as close to normal as possible, and this is yet a new point of breakage. Since tere were no further comments, I’ll go agead an close it.

Does nobody else experience this issue with the Dock? Because in my experience the ‘normal’ thing is that you can install an application and drag it onto the Dock and then upgrade it in place and the Dock icon will refer to the upgraded version. Casks break this, and I find that pretty counterintuitive.
I don't mean to be argumentative; I was just hoping for a little more of a conversation about pros and cons before being closed. If there's a better way to solve this problem that would help the community, I'd like to work on it. If there's a reason why this isn't a problem for the community or shouldn't be solved in this way, I'd like to understand that. Help me work towards the greater good here.
@zmwangx, I don't use 1Password; what specifically is the requirement that your script addresses? I think under some conditions OS X considers the app to live wherever the .app bundle folder lives, so is it possible that with this patch, a brew cask install --appdir=/Applications google-chrome would be sufficiently ‘under /Applications’ for this purpose, so that the script isn't necessary?

Does nobody else experience this issue with the Dock? (…) If there's a reason why this isn't a problem for the community

First time I remember seeing anyone with the issue.

I don't use 1Password; what specifically is the requirement that your script addresses?

See this caveat.

As a consequence, when brew-cask upgrades the application to a new version

Homebrew-cask does not upgrade to new versions. The feature isn’t done. What you mean is “when you force install a new version”, which is a very different problem. Your use case is clear, but the solution is bad as it introduces a system that will be highly unexpected. Even linking as it is done now already introduces a slew of problems, I can already imagine the ones this solution will bring.
If the problem happens when updating, then it should be fixed on updates. What you’ve done here is not a fix but a workaround with unforeseen disadvantages to fix (what will be) an uncommon action (forcing installation) that serves only to fix errors itself.

Homebrew-cask does not upgrade to new versions. The feature isn’t done.

Heh. That's frustrating, but a fair response. Thanks for explaining.
I suppose then that the remainder of my input is that I'd like this issue to be covered by the upgrade feature when it is done—applications should be installed such that upgrades don't break the Dock. Does this PR capture that, or should I enter a new issue or add a comment to an existing one or something?

Many things need to be done before upgrade is done. That is discussion for later on, but the request is understandable, and we should take it into account.

@rhendric

so is it possible that with this patch, a brew cask install --appdir=/Applications google-chrome would be sufficiently ‘under /Applications’ for this purpose, so that the script isn't necessary?

Maybe, not sure. But I'd say that's equally bad from a security point of view, and certainly shouldn't be relied upon.
Anyway, I was just providing one example of why this change might break brew's external commands and user scripts. The detail doesn't really matter.
@vitorgalvao

Your use case is clear, but the solution is bad as it introduces a system that will be highly unexpected.

Spot on, that's the biggest problem with this patch.

First time I remember seeing anyone with the issue.

I'll throw in my two cents here. I have also experienced the issue mentioned above, however since we don't officially support updating, I don't believe it should be expected of us to fix this issue right now. I'm not knowledgeable enough here to weigh in on the pros and cons of this particular solution but this problem definitely needs to be considered for cask upgrade.
I have two potential alternate solutions I should mention, but like I said earlier, I don't know very much about this kind of stuff:

Modify the com.apple.dock.plist. The primary issue with this is that it would only solve the issue for the current user because you wouldn't have access to the Library folders of the other users.
Add the symlink to the dock. This is the simplest and best solution for now in my mind. If you drag the app symlink to the dock, it follows it to the actually application location as stated above. If you repeat this action however, it appears that you end up with one icon for the actual application and one to the symlink. You can then just remove the non-symlink icon. I haven't tested whether this will solve this issue, but I don't see any reason why it wouldn't work.

If you’re suggesting homebrew-cask adds the symlink to the dock, no way.  Not every user keeps every app in the dock (I keep almost none), and some apps don’t even make sense in the dock, most of the time. If I install an app automatically via the command-line, but then have to remove its icon manually from the dock, that is a crappy experience.

@scribblemaniac, that symlink workaround sounds excellent but I can't get it to work for me. Is there some additional trick to it? When I drag the symlink over the second time, I don't get a second icon. I tried it both with the application running and not.
@vitorgalvao, yeah, that sounds horribly Windows-esque but I think a saner thing would be only to update existing entries in the plist for the app being upgraded, and do nothing if none are found.

I partially agree with @vitorgalvao here, but I can totally see the dock icons being issues between "upgrades" and something that needs to be addressed when implementing the actual upgrade functionality.
I think if user adds app into the dock and that app is being managed by homebrew-cask, we could try and update the location during upgrade.

(For the record, I tried modifying com.apple.dock.plist before I discovered the Contents-symlink hack, but my original efforts ended up moving the icon in the Dock after it was updated. Probably there's a way to work around that and/or I was just doing something dumb, but it's a thing to watch out for if attempted—I'd be pretty unhappy about a Dock that rearranged itself on a hypothetical brew cask upgrade.)

If you’re suggesting homebrew-cask adds the symlink to the dock, no way.

Woah easy there! I'm sorry that I did not make myself clearer, but I was only suggested that it modify existing dock items for apps that are managed by cask. I agree that adding dock items on install is a terrible idea.
@rhendric Hmm strange, it worked right away for me. What mac version do you have? Sadly I am away from my main computer this weekend so I won't be able to test this workaround anymore until late tomorrow or Monday. I'll let you know at that time if I've come up with anything else that may need to be done.

Woah easy there!

I’m not sure how seriously you took my comment, but just to make sure and stop this from escalating unnecessarily, I want to make clear I was kidding. I mean, yes, I do think adding to the dock automatically is a bad idea, but “[g]et off my dock, whoever you are” was totally in jest, in a “get off my lawn” “old man yells at cloud” kind of way.

No worries, I got understood where you were going with your comment.

Okay everyone, I've had a chance to investigate a little further. I was partially mistaken earlier with my dragging to dock technique. It turns out that this only works for aliases and not symlinks. This got me thinking that we should maybe switch from symlinks to aliases. There was a brief discussion about adding an alias command at #5101 however I don't see anything in it that would discourage switching from symlinks to aliases for installation-time linking. Can I hear some thoughts on this idea?
Also I made a quick and dirty hack to the source to use aliases rather than symlinks for installation. The result can be found at scribblemaniac:alias. I have tested this when the alias is added to the dock and this does indeed fix the issue with reinstalls (or eventually upgrades) that the OP is pointing out.

@scribblemaniac Is there a way to create aliases without AppleScript? AppleScript is an abomination (I haven't looked at JXA), and osascript was broken big time in the first three releases of Yosemite — I'm not sure they won't mess it up again. I don't know about others, but I'm much more comfortable with standard Unix technologies + manipulating plists with defaults if that's necessary.

A standard unix technology will definitely not exist for aliases since they are a mac specific features. I would also prefer not to use applescript myself, however this is the only way that I've found to do it. Feel free to do some more looking and if you find something I can definitely update it. Anyway it would not be the first time that hombrew-cask uses applescript; sometimes it's the only reasonable option.

By standard Unix technology I mean symlinks...

Anyway it would not be the first time that hombrew-cask uses applescript;

Interesting, I wasn't aware of that.

Yup, it's used in quite a few places, actually:
$ git grep osascript
developer/bin/list_running_app_ids:  out, err, status = Open3.capture3('/usr/bin/osascript', '-e', 'tell application "System Events" to get (name, bundle identifier, unix id) of every process')
developer/bin/list_running_app_ids:  %r{^osascript$}.match(app_name)   # this script itself
lib/hbc/artifact/uninstall_base.rb:        num_running = @command.run!('/usr/bin/osascript', :args => ['-e', %Q{tell application "System Events" to count processes whose bundle identifier is "#{id}"}], :sudo => true).stdout.to_i
lib/hbc/artifact/uninstall_base.rb:          @command.run!('/usr/bin/osascript', :args => ['-e', %Q{tell application id "#{id}" to quit}], :sudo => true)
lib/hbc/artifact/uninstall_base.rb:        pid_string = @command.run!('/usr/bin/osascript', :args => ['-e', %Q{tell application "System Events" to get the unix id of every process whose bundle identifier is "#{id}"}], :sudo => true).stdout
test/cask/artifact/uninstall_test.rb:      Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application "System Events" to count processes whose bundle identifier is "my.fancy.package.app"'], '1')
test/cask/artifact/uninstall_test.rb:      Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application id "my.fancy.package.app" to quit'])
test/cask/artifact/zap_test.rb:      Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application "System Events" to count processes whose bundle identifier is "my.fancy.package.app"'], '1')
test/cask/artifact/zap_test.rb:      Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application id "my.fancy.package.app" to quit'])
test/cask/cli/zap_test.rb:  #   Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application "System Events" to count processes whose bundle identifier is "my.fancy.package.app"'], '1')
test/cask/cli/zap_test.rb:  #   Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application id "my.fancy.package.app" to quit'])
test/cask/cli/zap_test.rb:  #   Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application "System Events" to count processes whose bundle identifier is "my.fancy.package.app.from.uninstall"'], '1')
test/cask/cli/zap_test.rb:  #   Hbc::FakeSystemCommand.stubs_command(['/usr/bin/sudo', '-E', '--', '/usr/bin/osascript', '-e', 'tell application id "my.fancy.package.app.from.uninstall" to quit'])

Yeah I found those after learning the fact, but really I would just count the one occurrence (or three if you prefer) under lib.

There was a brief discussion about adding an alias command at #5101

That issue bas nothing to do with the subject at end. It is akin to a user-facing way of using a custom :target on the fly. It does not pertain to the type of link applications use.

That issue has nothing to do with the subject at hand, though.

Ah okay, I naturally assumed an alias command would make aliases. Silly me!


AgentEval Offline Integration

Why are these changes needed?

Related issue number

See issue #2162
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.31%. Comparing base (ded2d61) to head (5a3969a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
- Coverage   33.33%   33.31%   -0.03%
==========================================
  Files          83       83
  Lines        8636     8636
  Branches     1835     1835
==========================================
- Hits         2879     2877       -2
- Misses       5516     5517       +1
- Partials      241      242       +1

Flag
Coverage Δ

unittests
33.31% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@qingyun-wu , do you mind taking a look at this PR while Chi is out?

Could you add a test to cover the newly added code? Depending on whether the test requires openai, you can add it to contrib-tests.yml or contrib-openai.yml. It takes some learning to understand how to write the tests. Please check other contrib tests and how they are added to these workflows.

Closing in order to make a new PR from agenteval_integration into main


options dont seem to work

Do you have a solid example of setting options, for example zipCode in VueJS?

ping

Figured it out....

...
  product: {
      name: 'something',
      description: 'something',
      amount: 10000,
      allowRememberMe: false,
      shippingAddress: true,
      zipCode: true
  },

NOTE:  YOU DO NOT NEED TO PASS THESE EXTRA FIELDS IN OPTIONS


native port: Mirror the zephyr thread name onto native threads

When debugging native applications it is useful to know which thread is being debugged. Currently, all thread names are being displayed as "zephyr", making this hard.
The changes in this PR changes this to display the zephyr thread names, given that CONFIG_THREAD_NAME is enabled.
To avoid adding posix-specific code in the kernel, this is handled by adding a new optional arch API to the kernel interface.
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/52223.

What do we do about the _GNU_SOURCE that the CI does not like?

Nothing. When it is time to merge an admin bypasses the check.

kernel/arch change, reassigning to kernel maintainers.

Rebased to resolve conflicts

@andyross @peter-mitsis could you take a look?


[Task]: Instrumentation for Entity Refactor based on AST

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
For every refactor that happens, capture the following data :

Application ID
User ID
What is the type of entity that is being refactored - plugin, query, JS Object etc.
How many matching references were found with that name
How many references did we end up renaming from 4
Was the renaming successful or not

Ref Slack: https://theappsmith.slack.com/archives/C0423TJFUJK/p1665742898881359


member type aliases unavailable at runtime

This:
class Foo<T>() {
    shared alias U => T;
}

void fun<T>() {}

shared void run() {
    fun<Foo<String>.U>();
}

results in:
$ ceylon compile-js && ceylon run-js simple
Note: Created module simple/1.0.0

/private/tmp/simple/modules/simple/1.0.0/simple-1.0.0.js:21
foo$.U$Foo=function(){var foo$=this,$2=foo$.$$targs$$.T$Foo;$2.$crtmm$=functio
                                                     ^
TypeError: Cannot read property 'T$Foo' of undefined
    at $init$Foo.foo$.U$Foo (/private/tmp/simple/modules/simple/1.0.0/simple-1.0.0.js:21:54)
    at run (/private/tmp/simple/modules/simple/1.0.0/simple-1.0.0.js:31:29)
    at [eval]:1:282
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:456:26)
    at evalScript (node.js:536:25)
    at startup (node.js:80:7)
    at node.js:906:3

BTW - I think I have some really cool higher order generics code that would work if just this one issue were fixed!

Foo.U only works on instances of Foo, not on the type directly, because it requires the instance's type arguments.

According to 3.2.10 in the spec, isn't all of this supposed to be resolved at compile time?
Although, I guess it's not clear to me whether making the original example work would be enough to also make higher order generics with type aliases for type lambdas work.
For reference, the use case is exactly the toString call at line 100 https://github.com/ceylon/ceylon-spec/blob/master/test/main/functor/functors.ceylon#L100, which is parameterized like:
toString<String, MapFunctor<Integer,String>.Mapish>(MapFunctor(map));

@jvasileff Well this is a pretty interesting one which I had forgotten was even possible.
The typechecker definitely knows how to handle it, and clearly sees that the type Foot<String>.U is exactly the type String. But it doesn't do that replacement automatically.
What I'm thinking is that @chochos just needs to explicitly call resolveAliases() somewhere, to replace the alias at compile time.

OK I'll look into it

Cool, so this works for me now.
But the type lambda use case still fails. Should I create an issue for that? (Not sure if you guys are looking for bug reports on experimental features...)

@jvasileff I figure we may as well start collecting the bugs as issues, though they aren't a priority for 1.2, of course.


[Nightly] support notification and merge with master

Coverage increased (+0.03%) to 57.166% when pulling a498ad4fc9a4f127305e07afe13d1a8b02b106e4 on wy65701436:drone-test into 20dcbf3fd2c2949f4eabd527f53cc3707c3e5027 on vmware:drone.

Coverage increased (+0.03%) to 57.166% when pulling e3dcd6199e0bc15a90fcc70bdc8cf7c1a7ee494f on wy65701436:drone-test into 20dcbf3fd2c2949f4eabd527f53cc3707c3e5027 on vmware:drone.

Coverage increased (+0.03%) to 57.166% when pulling 2060d51a432cd473844067ef3151b5ce193c7f7a on wy65701436:drone-test into 20dcbf3fd2c2949f4eabd527f53cc3707c3e5027 on vmware:drone.


⚠ Bofrost.ch has degraded performance

In 563b2d4, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 11223 ms

Resolved: Bofrost.ch performance has improved in a4a6100 after 6 minutes.


theres nothing in my output

{'output': ''}

What's your input? and the model you are running?

i tried an model of the mistral finetuned on a dataset, but its the same weights, i think

its my model:  Guilherme34/Samantha-v2

and that is my inference code: import requests
response = requests.post(
"https://d032-34-87-126-184.ngrok-free.app/generate",
json={
"messages": [{"role": "user", "content": "What are things I should be cautious about when I visit this place? "}],
"images": ["https://github.com/sshh12/multi_token/raw/main/.demo/llava-view.jpg"],
},
)
result = response.json()
print(result)

Ah did you train it using the scripts in this repo? It looks like you potentially used something different https://huggingface.co/Guilherme34/Samantha-v2/tree/main
If this is just a text model, you'd need to finetune it first on image data to be able to use it multimodal.

oh okay, sorry for that lol, thank you

Haha np


⚠ Samsung has degraded performance

In 86faf68, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2271 ms

Resolved: Samsung performance has improved in 1df7133.


Uncaught TypeError: vue__WEBPACK_IMPORTED_MODULE_0___default.a.extend is not a function

Describe the bug
I tried the current main and encounter a bug while in dev mode.

This only occurs when using vite after commit https://github.com/vitejs/vite/commit/05fd1e26be1c64c665b5c01161f2e789c1deb6aa and seems not to affect preview/build mode
Reproduction
Create a repo with vue-2 + vuetify and use yarn link "vite" with commit 05fd1e2 and the one before
=> https://github.com/Shinigami92/vite-reproduce-3309
System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: Linux 5.10 Arch Linux
    CPU: (28) x64 Intel(R) Core(TM) i9-10940X CPU @ 3.30GHz
    Memory: 48.31 GB / 62.49 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 15.6.0 - ~/.nvm/versions/node/v15.6.0/bin/node
    Yarn: 1.22.10 - /usr/bin/yarn
    npm: 7.4.0 - ~/.nvm/versions/node/v15.6.0/bin/npm
  npmPackages:
    vite: ~2.3.0 => 2.3.0

Used package manager: yarn
Logs

Uncaught TypeError: vue__WEBPACK_IMPORTED_MODULE_0___default.a.extend is not a function
    at Module../src/mixins/themeable/index.ts (index.ts:11)
    at __webpack_require__ (bootstrap:19)
    at Module../src/components/VApp/VApp.ts (index.ts:4)
    at __webpack_require__ (bootstrap:19)
    at Module../src/components/VApp/index.ts (index.ts:1)
    at __webpack_require__ (bootstrap:19)
    at Module../src/components/index.ts (index.ts:1)
    at __webpack_require__ (bootstrap:19)
    at Module../src/index.ts (framework.ts:17)
    at __webpack_require__ (bootstrap:19)

Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

@patak-js @nihalgonsalves
@johnleider @KaelWD
I am happy to report that Vuetify is working again with Vite v2.3.7
I sadly don't know which version fixed this issue, but I assume it had something todo with one of the esbuild updates 🤷
I also don't need any workarounds for resolving components or so
just a normal Vuetify configuration + import { createVuePlugin } from 'vite-plugin-vue2'; 👍
import Vue from 'vue';
import Vuetify from 'vuetify';
import 'vuetify/dist/vuetify.min.css';

Vue.use(Vuetify);

export default new Vuetify({
  theme: {
    themes: {
      light: {
        // ...
      },
      dark: {
        // ...
      }
    },
    options: {
      customProperties: true
    }
  }
});


implement rename folder

Hi There,
is there any example how to implement a rename on a tree?
I mean, I have a tree with a dropmenu that has an option of "Rename"
when I click the "Rename" the item is ready for typing.
How do I implement the text change?

Try using:
Keyboard.Type("YourNewNameText");
Wait.UntilInputIsProcessed();
Keyboard.Type(VirtualKeyShort.RETURN);


Need to Add Two of My Own Albums!

In order to continue to contribute to our project I'd like to add some of my musical opinions as well! :)

Merged into main in another issue? It appears that the constant issues I was having was not properly pushing my data, but nonetheless it finally made it through? Again not understood why these issues persisted completely through development.


Update repository permissions and log message when service name is not set

Several things that I think need to be updated before we can sign off on #248

PS. Next time it would be easier if it would be as two separate PRs 😉

PS. Next time it would be easier if it would be as two separate PRs 😉

Come on, this PR changed 12 LOC in total.

PS. Next time it would be easier if it would be as two separate PRs 😉

Come on, this PR changed 12 LOC in total.

Easier to create CHANGELOG.md based on PRs 😉


Update ad-fs-tshoot-logging.md

@reikor0x : Thanks for your contribution! The author(s) have been notified to review your proposed change.


TelemetryChannel found a telemetry item without an InstrumentationKey

We keep seeing above error in our application insights traces - We have set the instrumentation key - in fact it logs valid traces most of the time - but we also see this error intermittently
TelemetryChannel found a telemetry item without an InstrumentationKey. This is a required field and must be set in either your config file or at application startup.
below is a code snippet that
TelemetryConfiguration.Active.InstrumentationKey = instrumentationKeyValue;
TelemetryConfiguration.Active.TelemetryInitializers.Add(new ABCTelemetryInitializer(cloudRoleName, cloudRoleInstance));
services.AddApplicationInsightsTelemetry();
we are using Microsoft.ApplicationInsights.AspNetCore Version=2.14.0

The snippet uses TelemetryConfig.Active which is not supported for Asp.net core.
https://docs.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core#configure-the-application-insights-sdk
Follow the instructions from here to configure ikey and initializers correctly. If you have issues after following this doc, please share a small minimal repro where you see this behavior.


Improve bug reporting

Use github forms to improve the overall bug reporting process.
Pros:

have a more clear structure for the reporter
fields can be marked as required
makes reporting process more clear

Issue forms are available in beta for public repositories on GitHub.com
Learn more:

https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

Sorry when I referenced the wrong branch. I picked master as it was suggested here
https://github.com/iotaledger/iota-area-codes/blob/master/.github/CONTRIBUTING.md

@Tobivaria Hmm that's a different repo entirely... 😅 but the one for Firefly also says master. Has been changed.

Hmmm, dunno how I ended up with that link^^. But thanks for changing


Envoy 1.21, error after success handshake for TLS: envoy ->(TLS)->kafka

Title: Envoy 1.21, error after success handshake for TLS: envoy ->(TLS)->kafka
Description:

I trying to make a chain java_client->(TCP)->envoy->(TLS)->kafka. After success handshake (see "[2022-02-16 18:51:31,158]...SSL handshake completed successfully" in kafka_log.txt ) I got error (see "[2022-02-16 18:51:31,407] ...Failed authentication" in kafka_log.txt ). java_client sever IP <IP_ADDRESS>, envoy server IP - <IP_ADDRESS>, kafka server IP <IP_ADDRESS>

envoy_log.txt - degug log from envoy
java_client_log.txt - trace log from java_client
kafka_log.txt - debug log from kafka
envoy_conf.txt - envoy static configuration

cc @adamkotwasinski

@KBaichoo @maksimaz
Not a bug.
We can see the communication happening ok on metadata step (when the traffic goes client -> envoy -> kafka):
2022-02-16 18:51:31.360 DEBUG 269369 --- [ad | producer-1] org.apache.kafka.clients.NetworkClient   : [Producer clientId=producer-1] Sending metadata request MetadataRequestData(topics=[MetadataRequestTopic(topicId=AAAAAAAAAAAAAAAAAAAAAA, name='IN')], allowAutoTopicCreation=true, includeClusterAuthorizedOperations=false, includeTopicAuthorizedOperations=false) to node <IP_ADDRESS>:3333 (id: -1 rack: null)
2022-02-16 18:51:31.373 DEBUG 269369 --- [ad | producer-1] org.apache.kafka.clients.NetworkClient   : [Producer clientId=producer-1] Received METADATA response from node -1 for request with header RequestHeader(apiKey=METADATA, apiVersion=9, clientId=producer-1, correlationId=1): MetadataResponseData(throttleTimeMs=0, brokers=[MetadataResponseBroker(nodeId=0, host='<IP_ADDRESS>', port=9093, rack=null)], clusterId='08uBODJUSXishLhNxIKx2A', controllerId=0, topics=[MetadataResponseTopic(errorCode=0, name='IN', topicId=AAAAAAAAAAAAAAAAAAAAAA, isInternal=false, partitions=[MetadataResponsePartition(errorCode=0, partitionIndex=0, leaderId=0, leaderEpoch=0, replicaNodes=[0], isrNodes=[0], offlineReplicas=[])], topicAuthorizedOperations=-2147483648)], clusterAuthorizedOperations=-2147483648)

but later (as Kafka does) the traffic does goes client -> Kafka, what correlates with timestamps:
client:
2022-02-16 18:51:31.395 DEBUG 269369 --- [ad | producer-1] org.apache.kafka.clients.NetworkClient   : [Producer clientId=producer-1] Initiating connection to node <IP_ADDRESS>:9093 (id: 0 rack: null) using address /<IP_ADDRESS>

and on kafka server:
[2022-02-16 18:51:31,407] INFO [SocketServer brokerId=0] Failed authentication with /<IP_ADDRESS> (SSL handshake failed) (org.apache.kafka.common.network.Selector)

Kafka server should use Envoy's port to advertise itself - even if we don't any Kafka-specific filters. Otherwise the follow-up traffic will go directly.

It it really work.


[SPARK-18022][SQL] java.lang.NullPointerException instead of real exception when saving DF to MySQL

What changes were proposed in this pull request?
On null next exception in JDBC, don't init it as cause or suppressed
How was this patch tested?
Existing tests

Test build #67381 has started for PR 15599 at commit 231223f.

Test build #67381 has finished for PR 15599 at commit 231223f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67381/
Test PASSed.

If we do not have a test case, could you post the exception before the fix and the exception output after the fix? Thanks!

I can try this fix on Monday.

I think we don't know exactly what the real exception is. The NPE occurs while handling the exception.

@maver1ck @gatorsmile are you OK with this change, at least? I feel like I'm missing the additional change you have in mind. I think the purpose here is just to avoid the NPE during exception handling.

@maver1ck Could you please try to run the fix? Thank you!

Merged to master, and to 2.0 as a small clear fix. If there is a follow-on problem involving whatever exception this suppressed, I think that's separate.

@uzadude sir I am getting same error in spark-sql 2.3.1 version
https://stackoverflow.com/questions/53011256/how-to-solve-this-error-org-apache-spark-sql-catalyst-errors-packagetreenodeexc/53030016?noredirect=1#comment92965464_53030016
https://gist.github.com/shatestest/86ae9559c6114999e13a6eec3c80ec2b#file-driver-scala
is there anything wrong am doing here ...

@uzadude sir I am getting same error in spark-sql 2.3.1 version
I don't think you meant to approach me..

@shatestest Your problem is different from the issue this PR tries to resolve. If you can provide a test case to reproduce it, feel free to open a JIRA