Link to SPRegionalSettings.TimeZones are dead

The link in section about TimeZoneID seems dead... Should redirect to https://docs.microsoft.com/en-us/dotnet/api/microsoft.sharepoint.spregionalsettings.timezones

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5af79bd0-1525-b5d8-b65a-05f9b5a13267
Version Independent ID: 1b98f96f-942b-679d-b43f-1dc74da1e547
Content: New-SPOSite (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/New-SPOSite.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

Thanks @jesper-ego for noticing and reporting. A fix is on the way.

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @jesper-ego Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


[BUG] fp_quantizer is not correctly built when non-jit installation

Describe the bug
fp_quantizer is not correctly built when non-jit installation.
To Reproduce
Steps to reproduce the behavior:
DS_BUILD_FP_QUANTIZER=1 pip install deepspeed

install will succeed but
from deepspeed.ops.fp_quantizer import FP_Quantize
FP_Quantize()

will raise ImportError: dynamic module does not define module export function (PyInit_fp_quantizer_op)
Expected behavior
Renaming csrc/fp_quantizer/quantize.cu may solve the issue.
This restriction seems to be cause of the bug.

Note that setuptools cannot handle files with the same name but different extensions
https://pytorch.org/tutorials/advanced/cpp_extension.html

Thanks for pointing this out @twaka - we will take a look

Can you try #5577?


An injector with a binding created with 'toImplementation' returns a different instance?

EXPECTED:
class Foo {}

class FooImpl implements Foo {}

class Module {
  bind(Foo, toImplementation: FooImpl);
  bind(FooImpl);
}

expect(injector.get(Foo) == injector.get(FooImpl));

ACTUAL:
The instance of FooImpl returned is different!

@vsavkin will take a look and explain how thing will work in 2.0

@matanlurey Yes, you should use toInstanceOf.
In Angular 2.0, you will use:
[FooImpl, bind(Foo).toBinding(FooImpl)]


Project Status

I'm interested in developing this project further. Are you still receiving pull requests?

We haven't gotten a pull request in a long time, but if you'd like to create one, I will take a look at it.


XML encoder implementation

Codecov Report

Merging #120 into master will decrease coverage by 0.88%.
The diff coverage is 74.06%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   86.28%   85.39%   -0.89%
==========================================
  Files          85       94       +9
  Lines        4957     5205     +248
==========================================
+ Hits         4277     4445     +168
- Misses        413      467      +54
- Partials      267      293      +26

Impacted Files
Coverage Δ

pkg/codec/json/object.go
83.09% <ø> (+0.69%)
:arrow_up:

pkg/codec/www-form-urlencoded/errors.go
100.00% <ø> (ø)

pkg/codec/www-form-urlencoded/types.go
100.00% <ø> (ø)

pkg/codec/xml/xml.go
48.27% <48.27%> (ø)

pkg/codec/xml/object.go
55.83% <55.83%> (ø)

pkg/codec/xml/decode.go
77.77% <77.77%> (ø)

pkg/codec/json/array.go
81.48% <81.48%> (ø)

pkg/codec/xml/array.go
86.66% <86.66%> (ø)

pkg/codec/xml/encode.go
94.28% <94.28%> (ø)

pkg/codec/www-form-urlencoded/form.go
92.06% <100.00%> (ø)

... and 12 more


Document StorageArray utility

We may document the API or deprecate it if the native implementation comes first.

The StorageArray utils was removed in favor of the native Vec implementation.


Path mutations on symlinks have unexpected effects

I was trying to set permissions on a directory, and found the following had no effect:
  - path: /var/run/
    uid: 65532
    gid: 65532
    type: directory
    permissions: 0o755
    recursive: true

But this did work:
  - path: /var/run
    uid: 65532
    gid: 65532
    type: directory
    permissions: 0o755
    recursive: true

The reason turned out to be that /var/run is a symlink to /run, so the correct thing to do is to apply the mutation to /run. This isn't clear to the user however, so either an error/warning should be given, or the mutation applied to the source of the symlink.

The nginx image doesn't suffer from this any more for some reason. Will leave open as it's probably still a problem in general.


Use events to deliver critical logs

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The controller's log is not exposed to customers since it runs in control plane. Instead of exposing it's logs to all customers' CW, the controller can also leverage events to share critical logs.
Describe the solution you'd like
A clear and concise description of what you want to happen.
The controller should use events to deliver important logs, such as

pod IP/interface provisioning failure
node interface provisioning failure
IP starving in assigned subnet
security group association events
and more...
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

We should add supports for this gradually. Adding them based on priority. It is ok to release supports in several versions.

The events for unsupported EC2 instance has been merged and will be released with v1.1.6 (#218 )


[PE-D][Tester E] Include hyperlinks to other sections within document

For example, in 1.2.1 Filter and Lookup are in blue, so I would expect them to take me to the relevant command within the document. It would be good if you could implement that, because as a user I would assume that blue text is a hyperlink.

Labels: severity.Low type.DocumentationBug
original: willowisp01/ped#1

is this a duplicate of #124 ?


Golem id issue

http://pastebin.com/cFfx0j7n
Please fix your mod draco, I don't like people coming to me claiming this is caused by my mod when clearly this is on your side somehow :p I have no idea why this happens, because I looked at your code and things shouldn't conflict, but they clearly seem to for some reason.

The only way the conflict happens is when we BOTH use registerGlobalEntityID() and that somehow either between changing what mods are installed, or something else, both mods try to use ID 3.
https://github.com/sor1n/Jewelrycraft/blob/1.7.10/src/main/java/darkknight/jewelrycraft/entities/EntityList.java#L20-21
I haven't been maintaining the code here for a long, long time.  Yes, it needs to be fixed here.  But at least my mod gets an ID that is free and saves it to the config file, which the user can adjust if there's a problem.
Both of us should be using registerModEntity(), but as I said, I haven't been maintaining this code for a long while now.

Alright. Well I will make sure to use just that for my next update so this conflict doesn't happen in the future.

I'd rather keep it as an ID that has a vanilla spawn egg (the registerGlobalEntityID() ), so that way it can be easily used in dispensers (perhaps for future traps?).
There is only one mob in this mod, so if there is a confict, it's pretty easy to change the ID in the config file.

Well lucky you >_> Yet again I am the one that has to change stuff it appears :/ this way people will at least crawl to you for conflicts :p I really am not in the mood to tell people to change the id in the proper config.

With 1.8, registerGlobalEntityID doesn't exist any more anyway.


Wallet client doesn't detect address re-use

If you send twice to an address generated by the wallet client, the wallet client will only peg-in the first one

We'd need to spec out the expected behavior:

We cannot keep watching all addresses we ever generated, so there has to be some time limit (it can be generous)
During that time limit we should process any peg-ins we detect
With some effort we could implement a command that rescans a particular address or all addresses ever generated
Another approach would be letting users designate certain addresses as "forever addresses" and accept the small performance hit for permanently watching a very limited set of addresses

This should be fixed via wallet client module refactor that was part of 0.4


Clarify, document, and implement Incomming Connection flow

it looks like the RequestToParent::IncomingConnection message published by ghost_transport_memory is being handled by gateway_transport, not by network_transport..   And handle_incoming_connection in network_layer.rs is never being called.  Are we missing a bubble up?

[ ] incomming connection flow documentd
[ ] impelmented and tested for in-memory
[ ] impelmented and tests for wss

deferred because it's not worth with the hacks for MirrorDHT


fix(): a11y visual fixes layout

Description

Increase contrast on flexbox demo layout

Test Steps

[ ] npm run a11y
[ ] Expect errors (Steven is working on these code errrors)
[ ] Verify no contrast related errors (ctrl + f > search contrast) except those already resolved in previous PRs (i.e. theme accent color contrast, top nav contrast, higlight contrast)
[ ] npm run serve
[ ] Verify design matches screenshots below

General Tests for Every PR

[ ] npm run serve:prod still works.
[ ] npm run tslint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build:lib still works.

Screenshots or link to StackBlitz/Plunker

With our new design system we will be adding a high-contrast theme to address accessibility.  Closing these for now.


Updated LastUpgradeCheck to Xcode 8

That way we're not asked to migrate again when opening the project, with suggestions like this:

LGTM 👍 Thanks @NachoSoto! I forgot to do this in #162. 😅


Add detect() method for the lines-between-rulesets.js

To reproduce:
Put mystyle.css into the project root directory.
mystyle.css.txt
Run:
csscomb -d mystyle.css
Observe:

Apply the current PR changes, run the command again and observe:

Hi! Thanks for this.
Would you can refresh the PR?


Parsing fails in presence of significant space pattern match as a non-last parameter

scalameta 4.8.7 can't parse the following valid Scala code:
val component =
  List(1,2,3)
    .map: (props) =>
      TableOptions(
        getRowId = (row, _, _) =>
          row.value match
            case Left(HeaderRow(rowId, _)) => rowId
            case Right(stepRow)            => stepRow.step.rowId,
        onColumnSizingChange = dynTable.onColumnSizingChangeHandler
      )

It fails on line 3 with ; expected but => found.
However, it works fine if the last parameter (onColumnSizingChange) is moved above getRowId, or if braces are added to the pattern match.
In other words, both of these work:
val component =
  List(1,2,3)
    .map: (props) =>
      TableOptions(
        onColumnSizingChange = dynTable.onColumnSizingChangeHandler,
        getRowId = (row, _, _) =>
          row.value match
            case Left(HeaderRow(rowId, _)) => rowId
            case Right(stepRow)            => stepRow.step.rowId
      )

val component =
  List(1,2,3)
    .map: (props) =>
      TableOptions(
        getRowId = (row, _, _) =>
          row.value match {
            case Left(HeaderRow(rowId, _)) => rowId
            case Right(stepRow)            => stepRow.step.rowId
          },
        onColumnSizingChange = dynTable.onColumnSizingChangeHandler
      )

(Thanks @keynmol for helping isolate the issue).

@rpiaggio the current version is 4.9.2: https://github.com/scalameta/scalameta/releases
could you please verify to make sure this problem hasn't still been fixed?

Hi @kitbellew !
I tried it on https://astexplorer.net/, which has 4.8.7.
It's still happening with scalafix 0.12.0, so it's still happens with scalameta 4.9.1. How can I test with 4.9.2?

Confirmed on 4.9.2: https://scastie.scala-lang.org/ffq28TY2TMqJEaZTERJTVA

Thank you!


Add tools to update device firmware

I noticed that in the current version of Chimera OS is no method present to update device firmware. Therefore I added "gnome-firmware" to the manifest of ChimeraOS. This tool should allow every user from the desktop session to easily and safely update their device firmware. If you do not wan't to include a GUI tool please at least include the underlying "fwupd" tool instad of "gnome-firmware".

If we include fwupd I think Gnome Software can handle firmware updates? If so, we wouldn't need to include a separate tool just for that.

Literally as I typed my previous comment, Gnome Software on my desktop popped up with a firmware update notification.

Then it's perfect to just include fwupd. Shall I adjust the PR or do you want to?

@alkazar done :)

LGTM


Add node .12 and io.js to the CIs

.12 is stable and there is a reports of unstable iojs being more stable then .12.
Yeah, travis and appveyor does support them.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8533011-add-node-12-and-io-js-to-the-cis?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

We can also allow failures if needed
environment:
  matrix:
  - nodejs_version: "0.10"
  - nodejs_version: "0.11"
  allow_failures:
  - nodejs_version: "0.12"
  # io.js
  - nodejs_version: "1.0"

Not sure we need allow_failures or .11 - if something fail and we support it then it shouldn't fail :)

haha yeah ok

io.js

nodejs_version: "1.0"

This option will blow Travis if Node.js reaches 1.0...

Travis uses nvm internally, all is fine here ;-)


Git Pull on Stack Deploy fails with valid URL

Bug description
VSTS Git URLs look like this:
<EMAIL_ADDRESS>
where repo is the name of the repository. The bug is that portainer fails to pull a valid repo with the following error message:
Deployment error
unexpected client error: unexpected requesting<EMAIL_ADDRESS>status code: 400

Expected behavior
The same as git clone, which doesn't fail:
$ git clone<EMAIL_ADDRESS>Cloning into 'azure'...

Clones the repo just fine.
Technical details:

Portainer version: 1.17.1
Docker version (managed by Portainer): 18.03ce
Platform (windows/linux): linux
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): stack
Browser: Chrome

Portainer send an invalid git request to the server (it appends git-upload-pack the the URL). This causes a GitProtocolException, with the following error message:
TF401041: The Git protocol sent is not as expected (Unable to read the 4-byte length header of the message.).

This is likely a pretty major bug (missing multi_ack support) in go-git that has been unfixed for quite a while: https://github.com/src-d/go-git/issues/335#issuecomment-293629072
This is a real deal-breaker for us.

Out of curiosity, are bug fixed prioritized for businesses with a support subscription?

Yes indeed.
For businesses with a support subscription, there is a SLA for big fixes.
Rgds,
Neil Cresswell
On 25/05/2018, at 8:18 PM, turbo <notifications<EMAIL_ADDRESS>wrote:
Out of curiosity, are bug fixed prioritized for businesses with a support subscription?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1926-23issuecomment-2D391978566&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=pULOtN9BDE3N1F34nnD5un-JoAktLjGMVTQQR19OCXQ&s=JCIGqwaON-yHBXMt9LRKIo8YvBk-d116MOEI0UI1nOc&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlTQSBzWICIhONgm6w4QT2q3l59qiks5t175OgaJpZM4UJ7nX&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=pULOtN9BDE3N1F34nnD5un-JoAktLjGMVTQQR19OCXQ&s=p0Z4XUED6gmbyUjM0oZ5jIKF3Mme06dHOFYGumXzUKc&e=.

@turbo FYI I have implemented alternative method for VSTS users: https://marketplace.visualstudio.com/items?itemName=OlliJanatuinen.portainer-deploy

@olljanat I saw that, but we don't use any Windows agents. Since there is a discussion about pulling from git in #1752, I'd prefer a first-party solution.

I work for a Microsoft oriented company which is trying to adopt Docker.
For us the ability to clone from VSTS would make the adoption much user friendlier.
In this thread someone described that the issue is already resolved in Go-Git a while ago.
Is resolving this issue not as easy as using a later version of Go-Git?

Hi @GrumpyMeow
Based on https://github.com/portainer/portainer/issues/1926#issuecomment-391256007

This is likely a pretty major bug (missing multi_ack support) in go-git that has been unfixed for quite a while: src-d/go-git#335 (comment)

It has not been resolved, unfortunately no activity on go-git for this one. One solution here would be to use another library than go-git  as our git service implementation.

@turbo / @GrumpyMeow It is nice to see that more VSTS users are joining to Portainer users. But in same time it feels that you are are thinking this bit weird way.
On fully adopted implementation VSTS is much more than just Git repository, it also owns whole CI/CD pipeline(s), test automation, all approval chains, work item management, etc.
That why IMO VSTS must push services to Portainer rather than Portainer would pull them.
But I created another feature request about it to #2448 so please share your though about it on there.

@turbo OK. I understand that this one is bug from users point of view but from code point of view issue is that any of authentication methods which are supported by VSTS have not been implemented to libraries which Portainer currently uses so it is bit more tricky to fix than normal bug fixes.
But as VSTS also supports connecting Git repos with SSH , I understood from your comment that options works for you I think that best options would be then finalize PR #2294 and add comment to documentation that with VSTS you need use SSH authentication.
Works for you?

Yes, SSH would be the preferred way to connect to Azure DevOps for us.

I have found that calling
$ git commit -m "Init"
and afterwards
git push -u origin --all
works ok

@filipvaleriu sorry but I did not understood that how that is related to this issue which talks about git pull issue (not push)?

Yes, i see now, you are corect about that.
Still i ended up on this forum post, after i was stuck in that same error message for not beeing able to make an initial push for my newly created local git repository; after reading the post and finding also somewhere else some clues, not seeing anymore that was about pull instead of push, i thought might be helpfull for others to see a solution.

@GrumpyMeow OK. Would #1752 work for your use cases?
We have about 90% ready solution for it on #2294 which just would need to be finalized.
Then what comes to CI/CD into real production envs please comment about it to #2448

This issue has been marked as stale as it has not had recent activity, it will be closed if no further activity occurs in the next 7 days. If you are able to reproduce this issue on the latest version of Portainer, feel free to leave a comment and we can pick up this issue again.

Since no further activity has appeared on this issue I will close it for now. If you are able to reproduce this issue on the latest version of Portainer, feel free to leave a comment and we can pick up this issue again.

@deviantony Hey Tony. Sorry to dig this out from the dead. I've been affected by the impossibility to deploy a stack from VSTS as well. Considering that the underlying issue in is still not resolved in the go-git package and it's been 3 years since that issue was created. Wouldn't it be possible to use the git executable instead?

@mateuszdrab yeah that could be an approach, I'm always reluctant to use binaries against libraries for the following main reasons:

Multi-platform setup requirements
Error/standard output handling of a binary

That underlying issue in the go-git library seems to be a major one, as such I would not see any problem switching to the usage of the binary (it's just about implementing the GitService interface inside the exec package).
If we start relaying on more git features in Portainer, I can see this as a direction where we would want to go. In the meantime, any contribution to the discussion/implementation of using the git binary is welcome.
cc @ncresswell

Also re-opening this issue.

Since the opening of this issue, VSTS became Azure DevOps. So to test this I went and set up an Azure repo and tried to deploy a stack from it, but I keep getting {"message":"Unable to clone git repository","details":"authentication required"}.
@mateuszdrab is this the error you are receiving or am I doing something wrong?
FYI I created git credentials including a PAT using the Azure repo GUI and have entered this in Portainer. My HTTPS clone url is<EMAIL_ADDRESS>where **** is the name of my Azure organization.

@deviantony have you reproduced?

I did not reproduce as I do not have any VSTS related environment. Re-opening for the binary usage consideration.

@itsconquest I think you neeed to take out the credentials from the URL and put it in the authentication section within portainer. Then you should see error 400 - the issue I'm experiencing also.

Ah yes it seems that I can indeed reproduce this including the appending of /git-upload-pack to the url, thanks for the tip!

Closed via https://github.com/portainer/portainer/pull/5070


Replace Token UI with Inline Card

[x] implement warning icon in inline card component
[x] copy status as tooltip
[x] make copy optional

* token amount *

token with warning

copy confirmation

I noticed when currencies are overed, some extra background appears


Add WhitespaceCount primitive

We can add a primitive to determine how many whitespace characters there are.
This primitive should take NaturalLanguage as a input
There should be unit tests for the primitive

One thing I would be curious is if we can vectorize this primitive.


[release-v3.27] Auto pick #8585: Fix windows cni-plugin tests

Cherry pick of #8585 on release-v3.27.
#8585: Fix windows cni-plugin tests
Original PR Body below
Replace broken apt repos with new ones per https://kubernetes.io/blog/2023/08/15/pkgs-k8s-io-introduction/
Bump k8s version to 1.28.7
Remove docker runs as it is deprecated on k8s v1.24+
Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

ping @coutinhop


Don't generate has/clear for repeated extensions.

@tbkka you good dropping these and telling folks to just act on the lists instead?

Yes, I'm in favor of dropping generated code that didn't need to be there in the first place.


跑 yolox_hand的时候出现以下错误ValueError: unknown url type: 'pai_easycv-0.11.6-py3-none-any.whl.metadata'

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched the tutorial on modelscope  doc-site
I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.
ValueError: unknown url type: 'pai_easycv-0.11.6-py3-none-any.whl.metadata'
To Reproduce

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Your Environments (required)

OS: uname -a
CPU: lscpu
Commit id (e.g. a3ffc7d8)
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Please @ corresponding people according to your problem:
Model related: @wenmengzhou @tastelikefeet
Model hub related: @liuyhwangyh
Dataset releated: @wangxingjun778
Finetune related: @tastelikefeet  @Jintao-Huang
Pipeline related: @Firmament-cyou @wenmengzhou
Contribute your model: @zzclynn

按照以下教程跑出现的问题https://www.modelscope.cn/models/iic/cv_yolox-pai_hand-detection/summary

按照以下教程跑出现的问题https://www.modelscope.cn/models/iic/cv_yolox-pai_hand-detection/summary

请问您是自己搭环境还是用的官方镜像？

按照以下教程跑出现的问题https://www.modelscope.cn/models/iic/cv_yolox-pai_hand-detection/summary

请问您是自己搭环境还是用的官方镜像？

自己搭建的环境

The same question. It is still unsolved.

Related problems:
https://developer.aliyun.com/ask/546681
https://developer.aliyun.com/ask/573118


Fail to alter the nuxt config via module

Environment

Operating System: Linux
Node Version:     v18.20.3
Nuxt Version:     3.12.2
CLI Version:      3.12.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, ssr
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-drjvtt
Describe the bug
I'm trying to alter config following https://nuxt.com/docs/guide/going-further/modules#altering-nuxt-configuration
// app/modules/hello/index.ts
import { defineNuxtModule } from '@nuxt/kit';

export default defineNuxtModule({
  setup(options, nuxt) {
    nuxt.options.experimental.componentIslands = true;
  },
});

But the following warning still appears and the server component fails to mount:
WARN  Using server components with ssr: false is not supported with auto-detected component islands. If you need to use server component MyComponent, set experimental.componentIslands to true.

Additional context
No response
Logs
No response

@kingyue737 You also need to set experimental.componentIslands to true in nuxt.config.ts
export default defineNuxtConfig({
 // ...
 experimental: {
    componentIslands: true
  }
 // ...
})

@s-en-o please read my issue carefully, I want to alter config via Nuxt module, not via nuxt.config.ts

@kingyue737 I see. Is there any specific reason why the ssr was set to false in your case?

@s-en-o Im working on a module. I want to guarantee that users can still use the module out of box even if they set ssr:false on their side.


2.7.0 issue: path name is id instead of the file path

plugin version : 2.7.0
vite version: 2.9.1

first console get the warning message:
[WebServer] [plugin:vite:istanbul] context method getFileName() is not supported in serve mode. This plugin is likely not vite-compatible.
when you open the generated json file, it looks like:

 "1649799163381.js": {
        "path": "1649799163381.js",
        "statementMap": {
            "0": {
                "start": {
                    "line": 1,
                    "column": 19
                },
                "end": {
                    "line": 1,
                    "column": 82
                }
            },
            "1": {
                "start": {
                    "line": 7,
                    "column": 0
                },
                "end": {
                    "line": 17,
                    "column": 43
                }
            }
        },
        "fnMap": {},
        "branchMap": {},
        "s": {
            "0": 1,
            "1": 1
        },
        "f": {},
        "b": {},
        "inputSourceMap": {
            "version": 3,
            "mappings": ";AAAA;AACA;AACA;AACA;;AAEAA,SAASC,OACP,wBAAC,MAAM,YAAP;AAAA,YACE,wBAAC,KAAD;AAAA;AAAA;AAAA;AAAA;AADF;AAAA;AAAA;AAAA;AAAA,UAGAC,SAASC,eAAe,MAAxB,CAJF",
            "names": [
                "ReactDOM",
                "render",
                "document",
                "getElementById"
            ],
            "sources": [
                "/Users/s5474013/github/playwright-test-coverage/src/index.tsx"
            ],
            "file": "/Users/s5474013/github/playwright-test-coverage/src/index.tsx"
        },
        "_coverageSchema": "1a1c01bbd47fc00a2c39e90264f33305004495a9",
        "hash": "6165b6380d2c81cf1ff3baff8f189b45479f31c9"
    }

please run the code in this repo for verification:
https://github.com/stevez/playwright-test-coverage/tree/integrate-vite-plugin-istanbul
branch: integrate-vite-plugin-istanbul
the json files are in the .nyc_output

the issue might related to this line:
https://github.com/iFaxity/vite-plugin-istanbul/blob/main/src/index.ts#L126
It might not be compatible with vite 2.9.1

Hi, this was problem was introduced by #27 and a fix is now available as version 2.7.1

yes it works


HDFS-16526. Addendum Add metrics for slow DataNode

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
shadedclient
60m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
shadedclient
26m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

91m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4191/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4191

Optional Tests
dupname asflicense mvnsite codespell markdownlint

uname
Linux 59571311ac07 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 492c1b20da45c8c530c04600be46667b4ef86629

Max. process+thread count
544 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4191/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @ayushtkn


Eigenmode calculation with AMR [ex13p-amr-dev]

This is a test of a simple AMR loop for a Maxwell-type eigenmode calculation.  Primarily I need this to test an AMR algorithm for a more complicated eigenmode calculation but I thought it might be a useful example to add to MFEM.
It should be noted that this example differs from ex13p in one important way; this example does not support 2D meshes.  This is because the error estimation scheme fails in 2D.  The root cause of this failure is not entirely clear to me but the fix probably involves using different spaces for the smooth and discontinuous fluxes as well as generalizing the CurlCurlIntegrator::ComputeElementFlux method.

@mlstowell -- please take a look and let us know if you want to keep/update this PR


Add button to save connection.

Hi @Bajdzis,
Is there something I can do to add a persistent connection. The connection information is lost every time I restart the computer.
Thanks

@minatverma
You can save connection from command :)
https://github.com/Bajdzis/vscode-database/blob/master/doc/save-connection.md


Do not transpile async functions

Thanks for providing react-form@4 :heart:.
I'm working with front-end requirements that would allow me to use async functions out of the box. Unfortunately I still need to bundle the regenerator runtime in order to use<EMAIL_ADDRESS>This leads me to the question if you could drop transpilation of async functions.
At this point, all browsers except for IE 11 (dead) support async functions, cf. caniuse.
Using babel@7 people that still need to support IE 11 or other (older) browsers could transpile async via overrides.

I literally just ran into this same issue when compiling a Gatsby site after adding react-form:

  555 |   _asyncToGenerator(
  556 |   /*#__PURE__*/
> 557 |   regeneratorRuntime.mark(function _callee() {
      | ^
  558 |     var e,
  559 |         needsResubmit,
  560 |         fieldValidationPromises,

  WebpackError: ReferenceError: regeneratorRuntime is not defined

  - index.es.js:557 useForm
    node_modules/react-form/dist/index.es.js:557:1

Love the library, but this sneaky third party dep is causing some pain.

Yeah, let's do it. One of you wanna submit a PR for that?


Influence of object colour on depth accuracy

Hi,
I have a question regarding the accuracy of the Azure Kinect:
I compared the height of lego bricks with different colours and noticed a significant difference there.
The height of the bricks from the desk surface should be approx. 16mm, but the measured depth is wrong with red and black bricks.
For black bricks, the distance is about right, if the brick is in the center of the depth map. With higher distance from the center, the Kinect measures the brick thinner (I only measure the difference between desk depth and brick depth), up to 10mm error before the depth on the black brick becomes invalid (which is expected, because of the low reflectivity of the black).
For red bricks, the error is about 10mm (height ~6mm measured) and remains approximately the same regardless of its position in the depth map.
Other colours I tested, were close to the correct value (white, yellow, blue, grey); grey and blue gave me the best results.
Since the only variable I changed is the colour (same material, same environment), the error somehow has to be correlated to the colour.
Although the error is within the specification of the systematic error, I wonder what the reason could be for that behaviour. According to my (admittedly limited) understanding of time-of-flight sensors I would expect the depth to be more noisy instead of an offset, if a colour reflects less IR light back to the sensor.
I appreciate any ideas or links that could help me to understand the problem.

@Daniel4144 you may want to refer to this explanation which mention red lego brick https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1341#issuecomment-687933620

Thank you @guanming001, I did not expect the same material to have completely different properties for IR light depending on the color.
Since the difference is impossible to correct without prior knowledge of the material, a confidence map as requested in https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1408 would be great.

Hello, one of our team members looked into a similar issue in the past. This is the summary - The issue you notice is due to Subsurface scattering. Certain colors of Lego block (such as red) are translucent in IR light, which means that there isn’t really a clearly defined surface in the IR for the time-of-flight measurement to range to. The measured path length is substantially further than the physical surface of the object. It’s not inter-object Multi Path Interference that is the primary problem, although the specularity of the blocks can be a problem. Human skin suffers from a similar IR translucency problem, although it is typically less obvious.


adding flag to install packages at runtime

we need aws-cli installed for the helm provider
opting to do this rather than building new images for different versions of the terraform image

Can we update the docs to add the new flag? And maybe the tests 😄


Fixing typo in package name

One character was missing from the package name, which I imagine most people copy and paste without paying close attention.

I totally missed that!
Thanks for the catch.


fix(types): get event listeners needs to be embedded during the build…

Related to #205

@microsoft-github-policy-service agree


Fix code quality issues

Hi :wave:
This pull request fixes some of the code quality issues raised by DeepSource on my fork of this repository.
I have already fixed some issues using DeepSource's Autofix.
Take a quick look at all the issues caught by DeepSource for this repository here
Summary of fixes

Format code with prettier
Added .deepsource.toml

You can also have a look at the configuration file I used for DeepSource Analysis.
Using DeepSource to continuously analyze your repository

Merge this PR. I have included a .deepsource.toml in this PR, which you can use to configure your analysis settings.
Install DeepSource on your repository here.
Activate analysis here.

hey thanks a ton, but these just seem like formatting issues, going to keep it as-is

Hey :wave:  @wesbos Did you check DeepSource?
Integrating DeepSource on your repository will automate code reviews.
I'd suggest you try it since DeepSource is and will always be free for Open Source projects.

thanks - will check out deep source for sure! This repo needs to stay simple though

thanks - will check out deep source for sure! This repo needs to stay simple though

Thanks @wesbos :sparkling_heart:
If you have any questions regarding DeepSource I'll be happy to answer.


Exports and object-curly-spacing

Hi,
With the following code:
export x from 'x';

And "object-curly-spacing": [2, "never"], I get the following error:
There should be no space after 'export' (object-curly-spacing)
There should be no space before 'from' (object-curly-spacing)

I guess it's because ESLint doesn't support the export syntax without braces, but I'm not sure where to fix this. I did fix it on ESLint side but I'm not sure what to do with this, since this syntax is not supported by the default ESLint parser...
Any idea? Do you think I should open an issue and a PR on ESLint with this fix?
I'm interested in @nzakas opinion on this too.

Can you confirm whether or not you get this error on default ESLint please.
On Sat, Aug 15, 2015 at 6:38 AM, Valérian Galliat
<EMAIL_ADDRESS>wrote:

Hi,
With the following code:
export x from 'x';

And "object-curly-spacing": [2, "never"], I get the following error:
There should be no space after 'export' (object-curly-spacing)
There should be no space before 'from' (object-curly-spacing)

I've looked a bit into the code but I can't get why export and from are interpreted as object braces...
Reply to this email directly or view it on GitHub:
https://github.com/babel/babel-eslint/issues/167

Looks like Illegal export declaration on default - so if the syntax should be supported as a part of es2015 then you should report it to espree and make a PR to ESLint, otherwise you should use your own plugin rule / send a PR to https://github.com/babel/eslint-plugin-babel?

Actually looking at it now - eslint-plugin-babel already has that change - closing in favor of using that.

babel/object-curly-spacing: doesn't complain about export x from "mod"; or export * as x from "mod";

Oh, I didn't know about eslint-plugin-babel, awesome, thank you!


Added htmlbars as an alias for Handlebars

See tildeio/htmlbars for reference.

:+1: thans @jayphelps. It'll be another couple of weeks before this is live on Github.


Net5.0 support

ServiceModel.Grpc.AspNetCore
wait for Grpc.AspNetCore.Server 2.32.0 release, Grpc.AspNetCore.Server 2.32.0-pre1
ServiceModel.Grpc.DesignTime

CodeGeneration.Roslyn net5.0
roslyn source generators

ServiceModel.Grpc.AspNetCore net5.0 released in version 1.1.4

ServiceModel.Grpc.DesignTime base on roslyn source generators released in version 1.1.6


[Bug report] CI: Doris container startup failed

Version
main branch
Describe what's wrong
Sometimes, CI failed due to  Doris container initialization Error
Error message and/or stacktrace

CatalogDorisIT > initializationError FAILED
    org.testcontainers.containers.ContainerLaunchException: Container startup failed for image datastrato/gravitino-ci-doris:0.1.3
        at app//org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:361)
        at app//org.testcontainers.containers.GenericContainer.start(GenericContainer.java:334)
        at app//com.datastrato.gravitino.integration.test.container.BaseContainer.start(BaseContainer.java:132)
        at app//com.datastrato.gravitino.integration.test.container.DorisContainer.start(DorisContainer.java:63)
        at app//com.datastrato.gravitino.integration.test.container.ContainerSuite.startDorisContainer(ContainerSuite.java:177)
        at app//com.datastrato.gravitino.catalog.doris.integration.test.CatalogDorisIT.startup(CatalogDorisIT.java:86)

        Caused by:
        org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
            at app//org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
            at app//org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
            ... 5 more

            Caused by:
            org.testcontainers.containers.ContainerLaunchException: Could not create/start container
                at app//org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:565)
                at app//org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:356)
                at app//org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
                ... 6 more

                Caused by:
                org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (localhost ports: [32794, 32795] should be listening)
                    at app//org.testcontainers.containers.wait.strategy.HostPortWaitStrategy.waitUntilReady(HostPortWaitStrategy.java:112)
                    at app//org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
                    at app//org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:978)
                    at app//org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:502)
                    ... 8 more

How to reproduce
Trigger a integration test workflow
Additional context
No response

@danhuawang Do you mean Integration test in Github workflow? can you provide the link?
As I know, there is a known issue on #3392

@danhuawang Do you mean Integration test in Github workflow? can you provide the link?
As I know, there is a known issue on #3392

@zhoukangcn  Yes, it failed in Integration test in Github workflow. Here is the link  https://github.com/datastrato/gravitino/actions/runs/9372776274/job/25805009153
https://github.com/datastrato/gravitino/actions/runs/9332535696/job/25688511786

This issue is fixed by #3806, we could close it. @danhuawang


make expression better.

Thanks! The contents of these translations are valuable but some expression are not very smooth in my humble opinion, Can I take part in checking it then? I hope it will be better.

Thank you for your contribution. This repo has been idle for a long time. This book is very valuable, I hope more people can join it.


docs: 📚 syn-radio-group docs tokens

✅ Checklist

[ ] I have tested my changes manually.
[ ] I have added automatic tests for my changes (unit- and visual regression tests).
[ ] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[ ] I have made sure to follow the projects coding and contribution guides.
[ ] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

this should be fine now :) please check again


bug - error when clicking on a user button to see profile

likely caused by a merge error

I can do this task

@jkoren No worries! I'll take a look


Add optional LOS guidance

More info: https://github.com/UBCSailbot/local-pathfinding/issues/163

Tried to push/pull and merge but for some reason the diff isn't showing up right.

Starting new PR shows the right diff though ...


MQTT 2.0 has broken docker compose

I tried to deploy the docker-compose configuration, and ran into an issue where MQTT was refusing to connection from all servers. Due the the below breaking change:
https://github.com/eclipse/mosquitto/issues/2040
I was able fix this by fixing the MQTT docker container to 1.6 via:
 mosquitto:
    image: eclipse-mosquitto:1.6
    ports:
      - 1883:1883

Possible duplicate of #39

I believe @GinterP fixed this in https://github.com/brocaar/chirpstack-docker/pull/40?


Cannot type anywhere while webview is opened

I'm using GHPR which opens webviews for PRs
Sometimes, when switching windows, focusing out, sleeping the laptop (I don't know exactly which steps), when I return to a window which has a webview opened, I cannot type anywhere until I close the webview.
I'm raising this in case you know of any code done by the webview implementation which would "steal" inputs. The keydown events make it to main window, but text is never produced.

Version: 1.81.0-insider
Commit: c85bf61a82b0c39886b032d2634108782a55c637
Date: 2023-07-19T05:51:08.739Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Webviews should not be able to steel input if another part of the editor is focused. When a webview is focused, then the webview gets the keyboard events and has to dispatch these events back to VS Code for them to be handled. Again though it should only be possible for that to kick in when the webview is focused (we just use the normal keyboard event apis)
Let me know if you are still seeing this. Haven't seen other reports


What the probabilities are saved?

Hi, I set the output_prob as 'True' but couldn't find out where they are saved.
Also, just to make sure that "dropout" is supported right? since the documentation says that if dropout is supported the default value will be 0.5 but it is actually 1.
Thanks!

Thanks @YilinLiu97 the default value is now updated and the probabilities are written to the save_seg_dir folder as multi-channel volumes.


[ZEPPELIN-3422] Add JMX Support

What is this PR for?
I've revised JMX features to what Jetty suggests. It actually provides more metrics by default.
What type of PR is it?
[Improvement]
Todos

[x] - Add Jetty's jmx feature

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3422

How should this be tested?

CI should be passed

Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? Yes
Does this needs documentation? Yes, ZEPPELIN_JMX_PORT became mandatory option to enable JMX feature. I've updated conf/zeppelin-env.sh.template

Ready to review

CI passed. https://travis-ci.org/jongyoul/zeppelin/builds/472518267 Will merge it

CI passed. https://travis-ci.org/jongyoul/zeppelin/builds/472562609 Will merge it


Add navigation interaction to the nav bar for desktop

Parent ticket #87

There seems to be a problem with hoover effect for "dashboard" on the nav bar for several of the pages.


Feature/stereotyped mappings

Add stereotype on datasource to enable using Mappings for different purposes besides MDDE modeling. For example when there is horizontal and vertical lineage defined in the model

@willem-xbreeze I had a look at the changes, which seem ok this way.
I only thought you probably wanted to force the stereotype. Because things like model checks, form, etc. in the BaseClassifierMapping and BaseStructuralFeatureMapping metaclass (https://github.com/CrossBreezeNL/PowerDesigner-MDDE-Extension/tree/main/decomposed/extensions/MDDE_LDM/Profile/BaseClassifierMapping & https://github.com/CrossBreezeNL/PowerDesigner-MDDE-Extension/tree/feature/stereotyped_mappings/decomposed/extensions/MDDE_LDM/Profile/BaseStructuralFeatureMapping) should all also be moved into a Criterea on the DataSource stereotype. Right?
Otherwise all behavior modelling on the BaseClassifierMapping and BaseStructuralFeatureMapping will be applied to all mappings. Based on your story on being able to use mappings for different purposed won't work I think.

@willem-xbreeze I had a look at the changes, which seem ok this way.
I only thought you probably wanted to force the stereotype. Because things like model checks, form, etc. in the BaseClassifierMapping and BaseStructuralFeatureMapping metaclass (https://github.com/CrossBreezeNL/PowerDesigner-MDDE-Extension/tree/main/decomposed/extensions/MDDE_LDM/Profile/BaseClassifierMapping & https://github.com/CrossBreezeNL/PowerDesigner-MDDE-Extension/tree/feature/stereotyped_mappings/decomposed/extensions/MDDE_LDM/Profile/BaseStructuralFeatureMapping) should all also be moved into a Criterea on the DataSource stereotype. Right?
Otherwise all behavior modelling on the BaseClassifierMapping and BaseStructuralFeatureMapping will be applied to all mappings. Based on your story on being able to use mappings for different purposed won't work I think.

Latest checkin made the following changes:

Moved all MDDE content in the extension under BaseClassifierMapping and BaseStructuralFeatureMapping to a new criterion. Note: This gives a lot of changes in Git which are only relocations of existing items in the extension
Changed the initialize event handler under BaseStructuralFeatureMapping (since event handlers cannot be moved under criterion) so it only runs on appropriate attribute mappings
Made the export of mappings conditional, the MDDE XML export only includes MDDE mappings
Added an example model with business concepts and a local extension in the ExampleDWH model to illustrate how this can work with an additional form for "business concept mappings"

The changes look fine, what I am missing is a change in the add new mapping method, where you would set the stereotype of the new data source to mdde_DataSource. Or how is this taken care of for new users of the extension that the stereotype is set on creation of the first mapping?

The criterion allows datasource stereotype to be empty. But i have added a check now in the new mapping method to make sure that the datasource has a valid stereotype, either empty or mdde_datasource. See commit https://github.com/CrossBreezeNL/PowerDesigner-MDDE-Extension/pull/14/commits/5a269365f8d102aa46f54b66b6be73c27b70a535


Work with local repos (no clone)

Enhancement suggestion:
I would like Hound to work with repos that are already on my server, without cloning them first. This is for an in-house repo hosting server, for example.

:+1:

This should already work - either using the file:// protocol as the URL in config.json, or if you want Hound to manage the repos and keep them updated you can just change the dbpath in config.json to point to the parent folder of your existing repos. As long as the repo names in the config match the folders on disk, Hound should work without issue.
If you are trying this and having problems, feel free to open another issue with specifics. Thanks!


Migrate TSB Sandbox to use embedded Postgres and Elasticsearch

Migrate TSB Sandbox to use embedded Postgres and Elasticsearch

resolved


Heroku

Add in guides/Cloud_development

I am claiming this issue. I will write a starter guide on heroku.

Assigned to @thisisabdus . But please complete the minor edit of your earlier PR first.

Thank you.

I am interested to collab in this issue.

@varshika15 drop me a message on slack. My display name is 'Abdus'.

Time limit exceeded! Issue up for grabs!

Assigned to @Pallavi024


Units vs quantities (vs CPM "property")

Currently we only specified units for parameters. However, quantities are the bigger concept behind them. For example, "Area" is a quantity with a standard/canonical unit of "m^2", and the unit of measurement may be "mm^2". It seems to me that this is pretty similar to the "property" in the complex properties model, which for example is "Temperature". They also have a canonical unit field now. What are the cases where "property" != "quantity"?

Just found this comment in http://sweet.jpl.nasa.gov/2.3/propQuantity.owl:

Quantitative properties are Quantities

So I guess "property" is indeed the right abstract term to cover both quantities and other things. I was just wondering because the qudt ontology just has units and quantities, so that means it is focused on quantitative properties only.
What is an example of a property that is not a quantity? Is that anthing which is not a number? Like landcover categories?

From the http://sweet.jpl.nasa.gov/2.3/propTemperature.owl ontology:
  <owl:Class rdf:about="#ElectronTemperature">
    <rdfs:subClassOf rdf:resource="#Temperature"/>
    <rdfs:subClassOf>
      <owl:Restriction>
        <owl:allValuesFrom rdf:resource="∂#Electron"/>
        <owl:onProperty rdf:resource="&crela;#hasSubstance"/>
      </owl:Restriction>
    </rdfs:subClassOf>
  </owl:Class>

I'm not sure what I should make of this. It seems that here a property is actually what a complex property is in CPM, while the most base property is what corresponds to CPM's "property", but in fact it is just a subclass relation.
So, given that, if "temperature" is a property, and is also a complex property, what would the "property" of CPM then be? In the ontology above, the superclass of Temperature is ThermodynamicQuantity. Should that go there? It seems a bit arbitrary to do it like that. Or is CPM in fact a limited model that may not always work?

I would say "temperature" is the property, it is not - in and of itself - a complex property. It can fill in the property / quantity portion of the model, but "temperature" has no matrix etc...
I'm not quite sure what they're trying to say with "ElectronTemperature" in SWEET.
Is it that the matrix of the temperature measurements described is "electrons" (as opposed to "water" or "atmosphere") or is it that there is a resticiton on the "Temperature" measurement in a matrix of, for example, "water" so that only the "electrons" have their temperatures measured?
e.g.
<http://example.org/#ElectronTemperature> a cpm:ObservableProperty;
    cpm:property <sweet:Temperature>;
    cpm:matrix <sweet:Electron>

or
<http://example.org/#ElectronTemperature> a cpm:ObservableProperty;
    cpm:property <sweet:Temperature>;
    cpm:restriction <sweet:Electron>
    cpm:matrix <http://example.org/#Water>

They also have a canonical unit field now.

Not quite yet - see https://github.com/adamml/opm-owl/issues/1
I'm still waiting for details on a CF namespace as I really think that would be the best place to serve the canonincalUnit predicate from.

You said temperature is not a complex property. In fact, sweet says temperate "measureOf" Heat. Where heat is defined in sweet as ThermodynamicQuantity. Wouldn't that qualify as a property for temperature?
We can probably find many more examples like that. The real question therefore is (I think): What exactly is a complex property and what not? I'd like to have a clear definition you can look up somewhere. Also, a definition of what exactly the "property" field should be. Whether that's a kind of parent property of the complex property or something else.

I'm going to wave a big flag saying "Rabbit hole!!" This is certainly interesting and of wider importance but I don't think it's our job to fix it. I had a look into units and quantities etc a while ago (there was a Java library that handled this kind of thing nicely) but came to the conclusion that a generic solution would be pretty tough to implement. Apart from anything else, most people just don't publish this level of information with their data, so we're unlikely to be able to improve this with CoverageJSON. I think we should see if a "winner" emerges from the ontologies out there.
And, for CoverageJSON v1 at least, I think we are fine with:

observedProperty (URL to external definition outside our control)
description (explanation of property in natural language, could be used instead of, or as well as, the observedProperty, or could duplicate the definition for convenience
unit (The actual unit used)
Perhaps canonicalUnit too, although I'm not sure how we would actually use that.

I think it's actually more important for us (practically speaking) to figure out how we're going to serialise the unit string. UCUM? UDUNITS? We need this in order to do unit conversions accurately.

Closing this for now. Unit formats are done in the linked issue. Further CPM related discussion should happen in the https://github.com/adamml/opm-owl issues.


WIP - Introduce baggage-only textmap format (for tchannel)

Coverage increased (+0.04%) to 73.959% when pulling 30840232f26a75680fb6229eaf67f1a1b067a598 on baggage-only-text-map-format into 9e26371cd7770f1aada92b6db787977d972d3183 on master.

Coverage increased (+0.04%) to 73.959% when pulling 30840232f26a75680fb6229eaf67f1a1b067a598 on baggage-only-text-map-format into 9e26371cd7770f1aada92b6db787977d972d3183 on master.

Not needed anymore


xonotic: fix xonotic not finding libcurl at runtime

Motivation for this change
Xonotic needs to be able to find libcurl at runtime so that it can download game maps.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

thanks!


OOB Presentation Request

replaced by https://github.com/hyperledger-labs/business-partner-agent/issues/798


Timestamp rounds up to nearest second, MediaStatusBar momentarily reads :60

You can reproduce this bug simply by playing a track in the live style guide. When the playback time is between 59.5 and 60, the timestamp in the MediaStatusBar displays :60

The problem lies in the convertToTime function, which rounds up to the nearest second. It should instead round down, so that the number displayed represents elapsed seconds.

between 0 and 1 second past the minute, it should show :00
between 59 and 60 seconds past the minute, it should show :59

@abrahamian I checked a few random players online (Vimeo, YouTube, Bandcamp) and indeed it seems that behavior is standard. Thanks for flagging this problem! I'd be happy to take a pull request if you'd like to work on it.

Ah, just realized you already left one! Thanks! :)


General enhancements for ease of use

[ ] PG_CONF reloaded in every reboot
[ ] Data folder permission fix in every reboot
[ ] BREAKING CHANGE Use the same names in environment variables as the official postgres image.
[ ] Default log only by stdout (I don't know what the current behaviour is)
[ ] Ability to create additional databases and users by environment variables
[ ] Auto-generate random password if one is not defined for the primary user. Perhaps an environment variable asking if you want to generate randomly or, if you do not define environment variable is created automatically (in this case would be necessary to see how we contemplate those cases in which the user does not want to define a password)
[ ] Be able to specify a path to deposit sql files and preload them when the database is first started.

Default log only by stdout (I don't know what the current behaviour is)

Take into account that postgres has a log configuration which logs all SQL queries (log_statement = 'all'), which I think is enabled by default.
This setting should be disabled by default, specially in production environments. It may be useful tough to in development environments.

Add unaccent library from the contrib directory in order to be able to load as extension

tablefunc in order to pivot tables quickly.

Default log only by stdout (I don't know what the current behaviour is)

Take into account that postgres has a log configuration which logs all SQL queries (log_statement = 'all'), which I think is enabled by default.
This setting should be disabled by default, specially in production environments. It may be useful tough to in development environments.

Maybe we could change log_statement default value to ddl in our Docker image.

Regarding to compile contrib extensions in default image I have some doubts. An alternative could be to document in main README how to add a contrib extension to your project Dockerfile extending from image. What do you think about it?

It would be nice also to have a vim installed and delightful to have a minimal .vimrc (https://gist.github.com/vehrka/71b289bfe79854da0d92e8480bd42f15)

It would be nice also to have a vim installed and delightful to have a minimal .vimrc (https://gist.github.com/vehrka/71b289bfe79854da0d92e8480bd42f15)

I think is better if the people install Vim (or his choice text editor) in a custom or project derived image so we can maintain base image (this image) thinner.

It would be nice also to have a vim installed and delightful to have a minimal .vimrc (https://gist.github.com/vehrka/71b289bfe79854da0d92e8480bd42f15)

I think is better if the people install Vim (or his choice text editor) in a custom or project derived image so we can maintain base image (this image) thinner.

(edited my original coment)
Except when you deploy behind a firewalled environment and you cannot install anything.
In the image there is NO editor at all, nothing not even nano ...

I agree with @cayetanobv, I think that it is not typical for docker images to have more than needed to run the target application/service in a context-less environment. This kind of software must be included in derived images.


Remove Enterprise E3 requirement

Hello, the ASR feature does not require an activated 'Windows 10 Enterprise E3' subscription, as is implied in the text.
Windows 10 Enterprise that is activated on-prem will not show the E3 marker in the OS. However, the feature still works.
For this reason, the technical requirement of E3 is misleading. Please remove that wording?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9de2e9a-c4c1-3763-6160-9427556291f1
Version Independent ID: 74160e2f-0f99-a37f-7123-81a31a6fab61
Content: Use attack surface reduction rules to prevent malware infection
Content Source: windows/security/threat-protection/windows-defender-exploit-guard/attack-surface-reduction-exploit-guard.md
Product: w10
Technology: windows
GitHub Login: @andreabichsel
Microsoft Alias: v-anbic

@officedocsbot assign @mypil

@SwiftOnSecurity - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@SwiftOnSecurity : Maybe I am interpreting the section incorrectly, but the way I read it, it looks to me as if it means that you need a higher Windows 10 version than Windows 10 Pro. I don't see any mention of "activated" or "active subscription", which makes me think that it should be enough to have the E3 or E5 OS version installed without the product key or license being activated.
How would you rephrase it to clarify (in documentation wording) that you can't use this feature on Windows 10 Pro, so you need a higher version to use the features?

@SwiftOnSecurity Thanks for the feedback. Does this explanation from by our engineering team make more sense? It's published at https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-exploit-guard/attack-surface-reduction-exploit-guard.
To use attack surface reduction rules, you need a Windows 10 Enterprise E3 license or higher. A Windows E5 license gives you the advanced management capabilities to power them. These include monitoring, analytics, and workflows available in Windows Defender Advanced Threat Protection, as well as reporting and configuration capabilities in the M365 Security Center. These advanced capabilities aren't available with an E3 license, but you can use attack surface reduction rule events in Event Viewer to help facilitate deployment.
@MaratMussabekov I'll reply to the pull request.

@Justinha - We would like to follow up. Do you have any updates on this? Thank you.

@mypil I think we have this covered by the text I quoted in my last reply. If @SwiftOnSecurity feels otherwise we can try to clarify it further.

@SwiftOnSecurity - From our understanding, the issue has been resolved. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


Fix full ProxyCommand display missing

The argument "-p" not display the proxy command.

Fix display full proxy command and aliases compatibilty.

Thanks!


How to remove the html-webpack-plugin

hello there, i want my project build result is a js entry file instead of a html entry.
it seems that i need to remove the html-webpack-plugin which is added by default, so... is there any way to remove the plugin in craco config?

i think this pr will resolve my question https://github.com/gsoft-inc/craco/pull/224

i think this pr will resolve my question https://github.com/gsoft-inc/craco/pull/224

Hi @changhui3067 , you might want to take a look at the new craco version! https://github.com/gsoft-inc/craco/releases/tag/v6.1.0

Hi @changhui3067 , you might want to take a look at the new craco version! https://github.com/gsoft-inc/craco/releases/tag/v6.1.0


Prevent long titles in step nav wrapping buttons

Before:

After:

Trello card

Maybe a rebase will help get rid of that failure and we can merge it after.

Shouldn't it be fine to just run it again? (I cannot do that right now as I'm working from home.)

The main reason for a narrower table is because there are not many columns. Bootstrap always stretches the table to full width and when there are titles that are not that long, it can cause issues with screen magnifier users because they could miss that there is anything on the right-hand side.
It generally makes sense to keep an action as close to their "label" as possible. I guess it depends on how often we'll have long vs short titles. But so far it looks like short titles rule.

👍
On 28 March 2018 at 11:33, Anika Henke<EMAIL_ADDRESS>wrote:

The main reason for a narrower table is because there are not many
columns. Bootstrap always stretches the table to full width and when there
are titles that are not that long, it can cause issues with screen
magnifier users because they could miss that there is anything on the
right-hand side.
It generally makes sense to keep an action as close to their "label" as
possible. I guess it depends on how often we'll have long vs short titles.
But so far it looks like short titles rule.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/alphagov/collections-publisher/pull/365#issuecomment-376840224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvLrTxOjmAFVwEmelExu-neSWYRdhYMks5ti2cOgaJpZM4S8ufw
.


Update developer guide with the new create-eth workflow

Updating the workflow to backmerge scaffold-eth/scaffold-eth-2:main branch into scaffold-eth/create-eth:main branch.
Based on #12 guidelines
Closes #6

Thanks a lot for your review @technophile-04 and @carletex !! ♥
Just pushed the review tweaks and changed the "RFC-extensions" reference to "core-extensions" 🙌


Add support for Intel XPU evaluation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.arda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Setup performance testing - Tom/2807

Measuring time to render performance_noteboook as well as some rendering stats for section showing/hiding like:

dropped frame count
layout time
mean frame time

to run the tests just run ./test/perftest
This is not a part of our build. They take a while to run and it would slow down the build too much.

looks great.  please document perftest in README

Excellent, I'll update drool to the new version. Thanks!


No best type found for implicitly-typed array

Hi,
After including the SQL Server package, every time it is used the code [Index(IsUnique = true)], it generates the error: No best type found for implicitly-typed array.
Bellow is a screenshot from Visual Studio, showing the error:

Attached is a simple new project, from scratch, to show the error.
Thank you in advance.
WebApplication6.zip

A simple work around is to use new string []{}

Hi all, sorry too late!
I started investigating this issue right now, and I succeeded reproduce this problem.
I'm going to fix this issue.

I fixed this issue and published v.3.2.1 of Toolbelt.EntityFrameworkCore.IndexAttribute.SqlServer.

https://www.nuget.org/packages/Toolbelt.EntityFrameworkCore.IndexAttribute.SqlServer/3.2.1

Please try it out, and if it is still buggy, please send me a reply.

Thank you very much!


TableNameResolver does not work with @DynamoDBIndexHashKey

Expected Behavior
TableNameResolver should be called for every query
Actual Behavior
TableNameResolver is not called for secondary indexes
Steps to Reproduce the Problem

Create a GSI
Add @DynamoDBIndexHashKey in entity class
Add table name resolver and add some prefix
Run the query table name resolver wont be called

Specifications
implementation("com.amazonaws:aws-java-sdk-dynamodb:1.11.914")
implementation("com.amazonaws:aws-java-sdk-sts:1.11.914")
implementation("com.github.derjust:spring-data-dynamodb:5.1.0")

ref： https://github.com/derjust/spring-data-dynamodb/issues/263#issuecomment-720422228
@EnableDynamoDBRepositories(dynamoDBMapperConfigRef = "dynamoDBMapperConfig")

Above workaround works for me.

I'm trying to prefix the GSI name with env.name so that the GSI name is built dynamically, like separate names for the different environments - dev-{gsi-name}, qa-{gsi-name}. The DynamoDBMapperConfig it appears is capable only of overriding the table name (annotated by @DynamoDBTable), but the same does not work for the GSI. I've tried @EnableDynamoDBRepositories(dynamoDBMapperConfigRef = "dynamoDBMapperConfig") this but this also does not work re: overriding the GSI name.
Any suggestions on how we could possibly accomplish this ?
I'm using: implementation 'com.github.derjust:spring-data-dynamodb:5.1.0'
@derjust


feat(layers): add a basic minitrace layer

It simply works and needs to consider how to properly reflect the parent-child relationship of the call.

Fix #691

It seems to be working fine now.

Also, cc @andylokandy to give us some advice

now, we use enter_on_poll to trace async function

Nice!


correcting readme

Coverage remained the same at 96.324% when pulling 5b7016699fd3458b4aa7ad91daa81ba5834bf291 on readme into 2146d765ec31c51ac05ea5f9b7ec51a73d8572cf on master.

Coverage remained the same at 96.324% when pulling 24b7faa213c02245ee89064d9de0fe875d1ddabe on readme into 2146d765ec31c51ac05ea5f9b7ec51a73d8572cf on master.


Support filenames with spaces

Currently breaks when a filename has spaces in it. Haven't checked if there are other edge cases with weird file names.

Added url decoding, should be fixed now


FEAT: Disable detokenization for tokens created with Core Registry in the Climate Wallet

We should essentially check CADT org store for metadata, if assetID returns no metadata for detokenization TAIL, then hide detokenization button.
Will need to regression test that this new feature does not break existing tokens that can be detokenized.


[ClangImporter] Record C declarations found in @interfaces.

(including both classes and categories, and also @protocol declarations)
This is a hack in that we use two different mechanisms for importing
bridging header decls now: the manual output of ParseTopLevelDecl, and
the callbacks of a clang::ASTConsumer. We should probably unify these,
but that's a bigger change that isn't as obviously safe.
Also note that we probably aren't getting this right for things included
with -include, which we already don't have a good model for.
This adds test cases for both the module and bridging header cases,
although the former worked correctly already.
rdar://problem/24806068

@swift-ci please test


session cookies are still valid after logout

After logout from superset, session cookies continues to be valid.
User can still login using those cookies if he has session cookie saved.
They should be invalidated after logout.
How to reproduce the bug

Login into superset.
Copy the session cookies (with the help of browser extension).
Logout from superset.
Import session cookies into second browser.
Hit superset login url in second browser.
You will be logged in automatically.

Same can be done in single browser.
Expected results
User should not be able to login, cookies should be invalidated after logout.
Actual results
User is able to login, cookies continues to be valid even after logout.
Environment
(please complete the following information):

browser type and version : chrome  114.0.5735.199 ,  Firefox : 115.0.2
superset version: 2.0.1
python version: 3.9.16
browser extension : Cookie-Editor

How do I invalidate cookies after logout ??

I am also facing this issue though I am using keycloak as my OIDC.

Is this still an issue in 3.1/4.0? I would assume so, but this risks being closed as stale/obsolete if we can't determine that. CC @craig-rueda in case he has any ideas how to directly answer/resolve this.

i have the same error with AUTH_OID any news?

Hi All, i am facing this same issue. I have tried these and it still doesn't work. The app is unable to modify or delete the cookie.
Manually expiring the cookie or deleting the cookie in browser prevents this.
I have trying to code the app to delete or modify the cookie.
Anybody have any advice for me?
...
oidc.logout()
super(AuthOIDCView, self).logout()
...
response = make_response(redirect(oidc.client_secrets.get('issuer') +
                                          '/protocol/openid-connect/logout?post_logout_redirect_uri='+
                                          quote(redirect_url)+f"&client_id={client_id}&id_token_hint={id_token}"))
response.set_cookie('oidc_id_token',value='',max_age=0,expires=0, path='/',domain=request.host,secure=False, httponly=False, samesite=None)
response.delete_cookie('oidc_id_token',path='/',domain=request.host)
return response

@rusackas Yes, same issues on 3.1.3 version

To fully invalidate sessions on logout use this: https://superset.apache.org/docs/security/#switching-to-server-side-sessions

To fully invalidate sessions on logout use this: https://superset.apache.org/docs/security/#switching-to-server-side-sessions

Hi @dpgaspar I set the configuration as follows:
but nothing changes:
AUTH_TYPE = AUTH_OID
curr  =  os.path.abspath(os.getcwd())
OIDC_CLIENT_SECRETS =  curr + '/docker/pythonpath_dev/client_secret.json'
OIDC_ID_TOKEN_COOKIE_SECURE = True
OIDC_OPENID_REALM: 'stest'
AUTH_USER_REGISTRATION = True
AUTH_USER_REGISTRATION_ROLE = 'Public'
OIDC_INTROSPECTION_AUTH_METHOD: 'client_secret_post'
CUSTOM_SECURITY_MANAGER = OIDCSecurityManager
OIDC_TOKEN_TYPE_HINT = 'access_token'
OIDC_SCOPES = ["openid","userinfo"]

SESSION_SERVER_SIDE = True
SESSION_TYPE = 'redis'
SESSION_REDIS = redis.from_url('redis://superset-redis-prod-01:6379')
SESSION_USE_SIGNER = True
SESSION_COOKIE_SECURE = True
SESSION_COOKIE_HTTPONLY = True
SESSION_COOKIE_SAMESITE = "Lax"
SECRET_KEY = os.getenv('SUPERSET_SECRET_KEY', 'Tv********************************************************Rr')
def encode_data(data):
    return data.encode('utf-8') if isinstance(data, str) else data
def decode_data(data):
    return data.decode('utf-8') if isinstance(data, bytes) else data

and in my keycloack_security_manager.py file I modified the logout section like this:
from:
@expose('/logout/', methods=['GET', 'POST'])
    def logout(self):
        oidc = self.appbuilder.sm.oid

        oidc.logout()
        super(AuthOIDCView, self).logout()
        redirect_url = request.url_root.strip('/') + self.appbuilder.get_url_for_login

        return redirect(
            oidc.client_secrets.get('issuer') + '/protocol/openid-connect/logout?redirect_uri=' + quote(redirect_url))

to:
    @expose('/logout/')
    def logout(self):
        oidc = self.appbuilder.sm.oid

        # Invalidare la sessione di Superset
        oidc.logout()

        # Invalidate the session in the current application
        super(AuthOIDCView, self).logout()

        # Create a response object
        redirect_url = 'https://bi.company.it/login'
        full_redirect_url = oidc.client_secrets.get('issuer') + '/protocol/openid-connect/logout?redirect_uri=' + quote(redirect_url)
        resp = make_response(redirect(full_redirect_url))
        resp.set_cookie('session', '', expires=0, secure=True, httponly=True, samesite='Lax')

        return resp

But nothing has changed.
By leaving the original logout function, I was being redirected back to the initial dashboard.
putting it like this instead, I get redirected to the keycloack that does the logout and shows me the screen to log in again, but if in the address bar I remove bi.company.co.uk/login and put bi.company.co.uk I still get redirected to the dashboard without login.
so it logs out the session on keycloack but it doesn't superset.

I've found that once moving to a server side session the session still isn't being fully deleted, when I do session.clear() afterwards it cleans up properly and therefore logs out properly, but I wonder if there's a better way of doing that.

Any solution? I am struggling to fix this issue.

I've found that once moving to a server side session the session still isn't being fully deleted, but when I do session.clear() afterwards it cleans up properly and therefore logs out properly, but I wonder if there's a better way of doing that.

Can you point us to where and how you integrated that part?
Thank you

If your talking about the session.clear() part it's just after the logout call for me.
oidc.logout()
super(AuthOIDCView, self).logout()
session.clear()

I'm no expert here, but I think @Nboaram is right... I assume you're using a custom security manager, like in the docs:
https://superset.apache.org/docs/configuration/configuring-superset/#keycloak-specific-configuration-using-flask-oidc
If so, indeed you can just call session.clear().
I'm not sure, but if this is standard practice, it might be nice to add it to the docs. I don't deal with custom security managers since I happen to work for Preset, and this is all a solved problem. Let us know if you see that part of the logic flow in your fork, and do our best to help.


[BUG] unable to redeem pending reward. Got an error message

Describe the bug
When I tried to redeem my pending reward, I got an error message and the reward wasn't redeemable
To Reproduce
Steps to reproduce the behavior:

Launch the app
Click on menu by the top left side and click profile
Click on wallet. If you have any pending reward, click on it to redeem.
See error

Expected behavior
When I clicked on the pending reward yo redeem it, I expected it to be redeemed successfully.
Screenshots or Video
https://youtu.be/Eg4-vMOyiRw
Smartphone (please complete the following information):

Device: [Techno spark k7]
OS: [Android 7.0]
Version [ new version]

updated few hours ago today 6/6/2019

@cckole it is fixed, can you check. If you still see this error, you can reopen to issue


Extra lines in mesh viewer?

It looks like there is an extra line drawn for each submesh that isn't part of the original submesh:
e.g. black line here:

yellow line here:

Gmsh output for same mesh doesn't appear to have these extra lines:

Not reproducible anymore. It was fixed in a previous version.

Resolved by #964


Electron updates

Description of changes

https://github.com/electron/electron/releases/tag/v27.3.11
https://github.com/electron/electron/releases/tag/v28.3.1
Fixes CVE-2024-1580
Fixes CVE-2024-3157
Fixes CVE-2024-3515
Fixes CVE-2024-3516
Fixes CVE-2024-3517

This is the last release of Electron 27 before reaching end-of-life.
Adding Electron 30 will be done in a separate PR.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 304890 run on x86_64-linux 1

16 packages built:

bitwarden-desktop
blockbench
deltachat-desktop
electron_27
electron_27-bin
electron_28
electron_28-bin
feishin
logseq
mattermost-desktop
micropad
morgen
obsidian
pocket-casts
webtorrent_desktop
whalebird


Committee nominations (2020): deputy chair missing from description list

Page(s) where issue occurs
https://www.tdwg.org/news/2020/call-for-nominations/
Issue description
Deputy chair is open for nominations but is not described in the "Offices open for election" listing further down the page

Good point!
I'll fix it ASAP

The page has been updated now.
Thanks for pointing it out!


fe-react fails to export test reports

Describe the bug
Jenkins build fails to export test reports

closed by #365


fix duplicating parameters in update

Closes #225

can you please be more precise? I do not really understand the problem you are trying to fix neither from PR nor from issue. What exactly was failing?
Moreover I have problem naming attribute differently in resource and in proxy:
rl = client.create_rule(value='a')
print(rl.rule_value)      # I know rl.value will also work, but that is rather a undocumented featue

update method already have value parameter inside: _update(self, resource_type, value, base_path=None, **attrs):
and we try change also value param inside resource, so this cause duplicating error


.env NODE_PATH is not working in v1.0.0

Description
I have NODE_PATH=src in .env, it did work great in v0.9.5. After yarn upgrade react-scripts it doesn't work now. And I didn't see any related guide in the v1.0.0 changelog.
(referenced from https://github.com/facebookincubator/create-react-app/issues/2188)
I've also tried in a fresh new project and it doesn't work.
Expected behavior
Should be able to import 'foo/bar' which foo is a folder located in src
Actual behavior
Module not found: Can't resolve 'foo/bar' in '/Users/some/path/src'
Environment
Run these commands in the project folder and fill in their results:

npm ls react-scripts (if you haven’t ejected):
v1.0.0
node -v:
v7.1.0
npm -v:
v3.10.9

Then, specify:

Operating system:
macOS Sierra
Browser and version:
Chrome 58

Reproducible Demo
https://github.com/CodinCat/cra-env-issue
This is a fresh new project. See /src/index.js:5

Didn't knew you could add that to .env, I'm using it as custom npm script and it still works fine after updating to 1.0.0:
"scripts": {
  ...
  "dev": "cross-env NODE_PATH=./src npm run start"
}

I've got a problem with paths in tests by the way but I don't know if that's related to NODE_PATH or to the updated version of jest, I will report as soon as I could find where exactly the problem is.

This is a real deal-breaker on upgrades to apps that use this form of importing. Changing an entire app to use relative paths will be tiresome. I tried @ingro's suggestion but that didn't work for me; still getting module not found errors.

Interesting. Anyone looked yet into why this happens?

Same for me. Have NODE_PATH=./ in .env and imports like src/components not working anymore.

Thanks for confirming. Would be good if somebody could take a peek in the source into why. I'd expect it to work.

Seems unrelated to ModuleScopePlugin. Will investigate more.

As stated above I have only problems with tests, moving the __tests__ folder from the root to src (since now only tests inside src will run) returns me this weird error (my tests also uses NODE_PATH):

 FAIL  src\__tests__\modules\stats\stats.test.js
  ● Test suite failed to run

    Cannot find module 'package.json'

      at Function.Module._resolveFilename (module.js:470:15)
      at Function.Module._load (module.js:418:25)
      at Module.require (module.js:498:17)
      at require (internal/module.js:20:19)

If I change imports in tests to be relative the error disappear.

Can you show the test code? Does it import package.json?

Looks like .env isn't being loaded at all, not that this feature doesn't work.

I could've messed it up when refactoring something although I'd expect our E2E tests to catch that.

I don't believe any of our e2e tests use the .env file, only the feature itself.

Sure @gaearon , no package.json imported:
// __tests__/modules/statistiche/statistiche.test.js
import { actions } from 'modules/statistiche/actions/statistiche';

describe('Statistiche actions', () => {
    it('refreshAll action', () => {
        expect(actions.refreshAll()).toMatchSnapshot();
    });

    ...
});

@ingro We'd need a separate reproducing project to look into this. Not clear why.
@Timer I think I might know why it happens. env.js currently depends on paths.js which reads NODE_PATH before env.js could set it. 😄

Thanks @gaearon I'll try to create a repo to show the problem in the afternoon

I agree with @gaearon, that's the reason. First we include paths.js where nodePaths is initialized and then read .env files.

@gaearon this is karma for #2034 😆

Lol. I guess we should just duplicate that resolving code in env.js. Since the normal "path resolving" can't apply until we know NODE_PATH.

@ingro BTW I fixed my tests with cross-env so it looks like that now cross-env NODE_PATH=./ react-scripts test --env=jsdom. Ugly hack, but works for now. Waiting for fix :)

in webpack config:
const getClientEnvironment = require('./env');
const paths = require('./paths');

the problem that paths.js will be cached when you include it in the second time. As solution we can remove cache like this:
delete require.cache[require.resolve('./paths')];
const paths = require('./paths');

at least works for me.

Thanks for the suggestion @RIP21 but still not working for me, I was already running tests like this:
"scripts": {
   "test:cra": "react-scripts test --env=jsdom",
   "test": "cross-env NODE_PATH=./src npm run test:cra"
}

@gaearon I created a repo to reproduce the problem with tests. The tests are very silly but are there just to prove the point, the same test with relative paths will run while the other won't.

The issue with Jest is unrelated, and caused by a different change in it.
I know the cause and will try to fix it today. The repro case by @ingro was very helpful.

Would you consider adding Webpack alias? I really think that NODE_PATH is just some kind of escape hatch to get rid of relative paths. It would be really more convenient If we can have an alias.
I think the idea in Vue webpack template is great:
(https://github.com/vuejs-templates/webpack/blob/master/template/build/webpack.base.conf.js)
alias: {
  '@': resolve('src')
}

so you can
import Hello from '@/components/Hello'

and it's totally optional for users. Anyone who prefer relative paths can simply keep using them and ignore the alias. Of course it doesn't need to be @, this can be discussed.

No, we don't plan to support non-standard extensions to Node resolution algorithm. This breaks every single tool that can operate on your projects. NODE_PATH is hacky but it embraces the fact that you are in fact doing something hacky 😉 . A better solution it to use symlinks in node_modules, but it has its own set of issues and incompatibilities. However, generally it works better than special configuration and conventions for every single tool.

Okay, the fix for Jest is here: https://github.com/facebook/jest/pull/3616.
I’ll see if there’s any way to get in a bandaid fix in this repo until Jest fix gets into a release.

<EMAIL_ADDRESS>should be out with a fix.
Can you please verify it helps?

Thanks @gaearon , now my tests are running again :D

Looks like it still not working. In the https://github.com/CodinCat/cra-env-issue exist one App.test.js that testing only App.js, not index.js that contains issue. I have forked this repo into https://github.com/eddig/cra-env-issue.git, update react-scripts to 1.0.2 and fixed the foo/bar component requiring. Now error appears in App.js.
I think the problem with NODE_PATH appears because dotenv not override existing environment variables, that is already set (in my environment it is  /usr/lib/nodejs:/usr/lib/node_modules:/usr/share/javascript).

@EddiG,
I found this: https://github.com/motdotla/dotenv#what-happens-to-environment-variables-that-were-already-set, so dotenv variables are skipped in your case.
I'd like to ask @gaearon
should we override environment variables that were already set?

Please don't override already set variables. We set these on our Jenkins jobs and allow for each job to set up its own environment whilst keeping a .env file in the repo for development.

@will-stone, I agree but it can be an option for file .env.override

I think in this case the best way to do it is to put cross-env NODE_PATH=src before the scripts. As I said before this is a bit hacky anyway.

I still have this problem, what could it be?

@FezVrasta do you use react-app-rewired?
If so, it's not a problem of CRA.

yeah probably it's it

I never got cross-env working, nor any combination of using NODE_PATH. Instead, I put a package.json instead of my src folder that had the contents { "name": "src" }.  Interesting hack tho :D
Dunno, since NODE_PATH=./src in cross-env or .env works for me just fine.