Update README.md

Missing comma

Coverage remained the same at 96.891% when pulling<PHONE_NUMBER>aad108a3eda2a0f436aebc2217adb4 on liondancer:patch-2 into 86fe45c4ce59c39946468b79b4e4b73dc7094197 on summernote:master.

@liondancer Thanks!


Typescript declarations & generate instructions

Sorts out issue #1

I just need to run some more tests before this is ready


Class ModuloShardingTableAlgorithm & ModuloShardingDatabaseAlgorithm missing in V4.0.0-RC1

Bug Report
For English only, other languages will not accept.
Before report a bug, make sure you have:

Searched open and closed GitHub issues.
Read documentation: ShardingSphere Doc.

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot reproduce it on current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Which version of ShardingSphere did you use?
V4.0.0-RC1
Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
Expected behavior
Java config example compile success.
Actual behavior
Java config example compile success due to these two file missing, ModuloShardingTableAlgorithm and ModuloShardingDatabaseAlgorithm.
Reason analyze (If you can)
In this java config example page
, you take this code fragment below for example:
DataSource getDataSource() throws SQLException {
        ShardingRuleConfiguration shardingRuleConfig = new ShardingRuleConfiguration();
        shardingRuleConfig.getTableRuleConfigs().add(getOrderTableRuleConfiguration());
        shardingRuleConfig.getTableRuleConfigs().add(getOrderItemTableRuleConfiguration());
        shardingRuleConfig.getBindingTableGroups().add("t_order, t_order_item");
        shardingRuleConfig.getBroadcastTables().add("t_config");
        shardingRuleConfig.setDefaultDatabaseShardingStrategyConfig(new StandardShardingStrategyConfiguration("user_id", new ModuloShardingDatabaseAlgorithm()));
        shardingRuleConfig.setDefaultTableShardingStrategyConfig(new StandardShardingStrategyConfiguration("order_id", new ModuloShardingTableAlgorithm()));
        shardingRuleConfig.setMasterSlaveRuleConfigs(getMasterSlaveRuleConfigurations());
        return ShardingDataSourceFactory.createDataSource(createDataSourceMap(), shardingRuleConfig, new HashMap<String, Object>(), new Properties());
    }

but these two classes do not exist in the jar file. Maybe just moving these two files from legacy version can solve this issue.
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
Example codes for reproduce this issue (such as a github link).

Hi @komawei ,
Sorry for late reply, the ModuloShardingTableAlgorithm and ModuloShardingDatabaseAlgorithm is an example custom sharding algorithm in apache/incubator-shardingsphere-example
And in 4.0.X example project, they have been subdivided into precise and range.
I suggest you clone example project and try to run example first.

Hi @komawei ,
Sorry for late reply, the ModuloShardingTableAlgorithm and ModuloShardingDatabaseAlgorithm is an example custom sharding algorithm in apache/incubator-shardingsphere-example
And in 4.0.X example project, they have been subdivided into precise and range.
I suggest you clone example project and try to run example first.

Hi, I've customized my own sharding algorithm. What I want to point out are the errors on the example page. Maybe it's easier and more friendly to somone who begins to learn sharding-sphere.

Thanks for your correction and advice, we will update document soon.


Ability to let the liveshare (opened trough VSCode remote) running even if the host left

This feature request is a following of my feedback on the issue #74.
Currently, if the host leave the liveshare opened trough VSCode Remote the session ends and guest(s) get(s) disconnected from it.
My feature request is to have an ability to leave the liveshare running even if the host is not present/left so that guest can join whenever they want to contribute to the shared code.

This is definitely something we plan to address, since enabling async collaboration from remote environments is a really compelling scenario.

So long as you can indicated the remote environment is meant to be operated this way.
As someone working off their local PC, I would expect my session to end when the host leaves for security reasons.

@lostintangent any update of this? Maybe some CLI like visual studio online?

Yea some kinda command like code /project share read-only terminal read-only server 80

This is going to require work on the VS Code remote/Codespaces side, and isn't actionable by Live Share. Therefore, I'm going to close this issue for now and we'll track this work in the VS Code/Codespaces backlog.


Lightbox support for images and videos

I would hope for lightbox support for the images and videos in the generated document.
For example, if you click on the image or the video, it will pop up in fullscreen or a wider size so that it can be easily viewed.

Thanks, this is a good idea

hello
I would offer that
https://github.com/lucaorio/obsidian-image-gallery
is a great solution in general for adding images - from the notes folder
and it seems to work as is out of the box
when exporting to a web site
-->> except for the Lightbox function
not sure why it does not.. as it is a pure CSS Lightbox
it would seem that the "onclick" is not getting passed to the CSS code?
it would be great if the webpage-export worked with this plug in
thanks
WH


Refactor usage of Facade aliases, Facades and Helper functions

What do you guys think about refactoring the code base by replacing Facade aliases with Facade FQCN? It's really hard to track those definitions (even if you are using smart IDEs like PHPStorm).
Meaning:
use Event; should be rewritten to use Illuminate\Support\Facades\Event;
Since this package represents a core system, I think everything should be defined explicitly and usage of Facades and helper functions is generally, in my opinion, the way to go with concrete implementations (derived applications) and not something to be used in a source system. A source system should be as precise and as tightly coupled as possible. So another proposition from me:
File::makeDirectory($twillCustomBlocksPath) should be rewritten to  $this->fileSystem->makeDirectory($twillCustomBlocksPath) and paying attention to proper injection of $this->fileSystem through a constructor.
Another one:
collect(...) should be rewritten to new Collection(...), same goes for config(...) => $this->configRepository->get(...) // $this->config->get(...), etc.
This way we can achieve having a more stable, cleaner and performant code. This way we would also have real dependency injections.
Any thoughts?

These things depend on the project. In a small Laravel project, these generally increases the development time while not providing many advantages. But as you have said

Since this package represents a core system

, it's better to replace facades with dependency injection and get rid of global helpers. Here is a quote from When to Use Facades (Laravel Docs)

When building a third-party package that interacts with Laravel, it's better to inject Laravel contracts instead of using facades. Since packages are built outside of Laravel itself, you will not have access to Laravel's facade testing helpers.

If we are not going to replace, I think we need to replace the facade aliases with facade FQCNs at least. So I agree with you.

@stevanpavlovic @yusufkandemir
Great suggestions, and I'm with you on that.
Please feel free to create new PR if find anywhere could be improved!

@yusufkandemir that's exactly what I wanted to achieve! Thanks for a more detailed explanation!
@yanhao-li thanks for your support!

So we could split this enhancement into several smaller tasks in order to maintain stability and have a better control over what is changed over the time:

Replace all imports of alias facade class names with Facade FQCNs (for example use Event; should be rewritten to use Illuminate\Support\Facades\Event;)
Implement injection of Laravel contracts instead of using facades
Replace helper functions usages with actual service methods' calls in the all places where it's possible (for example, it could be possible to do this in some actual class and it could not be possible in the config files)

What do you guys think? @yanhao-li @yusufkandemir

Hey @stevanpavlovic ,
Thanks for splitting the task into small steps, it makes the goal much more clear.
As the requirement is lucid and doesn't need much insights on Twill's codebase. I have labeled this issue with good first issue, so anyone who are interested in and want to dive deep into the codebase, could help to contribute!

There are some places which need a further refactoring because there are impossible to implement DI completely. Those places are helper functions (example: s3Endpoint), models and traits. I would propose the refactoring of those functionalities by putting them in some better organized service classes. I would postpone this refactoring for the moment when we have some tests and typehinted methods and classes, so I consider this one as done.
Feel free to ask any questions, add comments or request changes.

Merged and available in 1.2.2, thank you for your hard work on this @stevanpavlovic!
As discussed, I refactored some of the changes that would have warranted a breaking change release, especially the constructors of Twill's main classes: ModuleController and ModuleRepository. Even for a breaking release, I wouldn't want to have Twill users forced to inject so many Laravel core dependencies in their own controllers and repositories, so we should discuss another approach to improving this, and plan ahead for a major release in the long term if we want to propose core API changes.
Thanks again, that's an amazing start to improve Twill's codebase overall quality!


URL parameters to preload matrices

Hi, I would love to be able to embed matrixmultiplication.xyz in an iframe or be able to pass around a link to the web app with parameters in order to pre-loaded the matrices, and then let the user play with the interactive UI.
Maybe an autoplay parameter would be cool too.
Would this be an interesting feature to you?
If yes, how do I get started with the codebase (and Cycle.js) in order to catch URL parameters, validate the inputs, and then pre-load the two matrices?
I'm completely new to Cycle.js but I find it interesting so it might be a good occasion to give it a try.
Thanks!

this would be awesome. doesn't look so straightforward unfortunately.

this would be awesome. doesn't look so straightforward unfortunately.

Why wouldnt it be straight forward? youre looking at the rendered html, not the actual javascript (typescript) variables that control the site. Personally, i dont understand the entire code since ive never used cycle js, but i know enough that this should be possible. Gotta watch out for XSS vulnerabilities tho, but not like thats a problem since this doesnt involve signing in or similar


Commenting igakit to support python3.12

In this PR we comment all the imports to igakit -- and all the dependent psydac functions, which essentially concern nurbs.
This quick fix is to allow users to install and run the library with python3.12 (see psydac issues 406 and 53 )
In a further PR we should re-implement the functions needed to support nurbs.

You don't have to comment all parts that uses igakit, you only need to comment the tests that uses it, i.e. `psydac/cad/tests/test_geometry.py

> igakit
What do you mean ? We cannot install igakit anymore, so how can we have a running code with some parts still using igakit ?


tiny mode is actually larger than one would expect

It turns out that we're worse than -ldflags='-w -s' at reducing binary size:
$ go build -o normal
$ go build -o normal_stripped -ldflags='-w -s'
$ garble -tiny build -o tiny
$ du -b normal normal_stripped tiny
6675742	normal
4722688	normal_stripped
4759552	tiny

My initial thought was that we could blame all identifiers being 9 characters, but it appears not. If I change the code to use 5 characters instead of 9, the difference is just ~4KiB over the total of ~40KiB.
$ du -b normal_stripped tiny tiny-shorter-names
4722688	normal_stripped
4759552	tiny
4755456	tiny-shorter-names

Undoing that change above, and removing the call to addRuntimeAPI, and we get better numbers:
$ du -b normal_stripped tiny tiny-3
4722688	normal_stripped
4759552	tiny
4706304	tiny-no-runtime-api

I think the runtime API should be added with -tiny, but be a no-op, and -tiny should otherwise trim anything not strictly necessary from the runtime package. This includes all those prints that can be disabled with the added API, I think.
I realise we're talking about very small differences, though. 50KiB of binary probably doesn't matter to the vast majority of people, especially when most Go binaries are over a dozen megabytes. Still, I think -tiny should gradually become more aggressive, and this could be the first step.

How can we be worse than -ldflags='-w -s', I thought we also pass those flags to the compiler/linker?

The existing benchmark should gain a "binary size" metric, and we should include a variant with -tiny.

 This makes binaries 7-9% smaller in my testing.

Also @mvdan you're proposing that the runtime print removal only be applied if -tiny is passed?

Yep. Otherwise the added runtime API wouldn't make sense, and we would always get rid of panic messages etc.


Mark Text field for translation in SubmitView.tsx

This small PR marks the Text field placeholder text in the report dialog for translation.

Is it even necessary to have placeholder text there, given that there's already a prompt Optionally provide additional information below: ?

Uhhh yeah that shouldn't say "Text field." Agree that, not sure it needs a placeholder.


unifiedfontobject.com -> unifiedfontobject.org

The former is a domain redirect to a slightly sketchy general fonts site

Good catch!


fix: only check for missing keys that are valid LR keys

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.789%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3896

Relevant Lines:
19005

💛  - Coveralls


Add ability to fill working directory in grammars.coffee

This adds a new field to grammars.coffee - workingDirectory.
If this is specified it forwards to childprocess.spawn as cwd.
@rgbkrk please review.
It should help @Luthaf with #744

Thanks as always @nixel2007!


Add lunr.js options when building the index

It’d be handy if you could pass in lunr.js options when you build the index. For example, if you wanted to add a new pipeline function, or if you didn't want any of the default pipeline functions that come with calling lunr().

The build is failing, but it's not due to anything you did. I'll fix it and then we'll see if it passes.
This sounds like a totally reasonable option. Thanks for the PR!

See #44. I'm closing old PRs; please reopen if you have time to address concerns.


[MIST-533] Create separate MISTMaster

This PR Address #533 via

Creating a separate MISTMaster for managing REEF Tasks.
Define necessary protocols for avro rpc.

Closes #533

Because this PR cannot actually run queries on distributed setting, I will reopen it with the fully implemented one.


Feature-Request: Support WasmServices via WasmPlugin

Describe the feature request
The current Wasm-Plugin WASM plugin can be used as type http-filter or network-filter. To build more advanced plugins it can be veriy helpful to also have support for Wasm Service. This can be used to do some shared work like caching or call-outs to external services in a single thread instead of having to replicate/re-do the work in every http/network filter. So basically the feature request is to also support the type WasmService via kind: WasmPlugin.
Describe alternatives you've considered
It seems that this can already be done using a EnvoyFilter that merges to the BOOTSTRAP config (example) but this seems way more verbose and leads to an additional configuration with another pattern. Also the envoy-filter approach does not support getting the code from OCI, as there is no loader for EnvoyFilter.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
I don't know
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
For further reference, an example of what I'm trying to build can be found here: https://github.com/ReToCode/envoy-request-buffer. On istio, the current code uses a second WASM module (which is a singleton WasmService in the raw envoy variant). In istio the shared service is loaded multiple times (and thus calls the control-plane more often than necessary) and has to provide an unnecessary HttpContext to avoid startup errors in istio.

It seems that this can already be done using a EnvoyFilter that merges to the BOOTSTRAP

I think this's removed, you can achieve this with https://github.com/zirain/istio/blob/b6fc1fb732a5541624869141abb3ae3443044300/samples/custom-bootstrap

I think this's removed, you can achieve this with

Ah ok, then I've seen outdated examples for that. Still, would be great to do it with a WasmModule. This also looks a bit hacky, especially if you target gateways which might have been auto-deployed (like GW-API Gateways with auto-provisioning).

I really don't think WasmPlugin is a good idea, because it's design for dynamic filters. Besides custom boostrap, another option is MeshConfig, but I'm not sure it's worth it.
@howardjohn @kyessenov @costinm WDYT?

Yes, Istio APIs do not cover bootstrap modifications well since they are not dynamic. There are other ad-hoc ways, which solve the need.

Yes, Istio APIs do not cover bootstrap modifications well since they are not dynamic. There are other ad-hoc ways, which solve the need.

@kyessenov what's the recommended way to load singleton WASM in Istio? Custom bootstraps are fairly painful and don't support OCI


Builder Behavior Change in v9.1 [CpSat, Windows, Java]

OR-Tools
Version: v9.1 (vs v9.0)
Language: Java
Solver
CpSat
Operating system and version
Win 10
Steps to reproduce

Run BuilderIssueTest.zip on v9.1 and v9.0.

What did you expect to see
Same results from both versions.
What did you see instead?
v9.0:
Interval start idx = 0
Interval size idx = 1
Interval end idx = 2
v9.1:
Interval start idx = 0
Interval size idx = 0
Interval end idx = 0
About our project
We are using
callback.solutionIntegerValue(intervalVar.getBuilder().getStart()) and
callback.solutionIntegerValue(intervalVar.getBuilder().getEnd())
to get the results. Is this change of behavior a bug to be fixed or should we use auxiliary maps/lists to get the values from?

yes. We convert all intervals to the new format. See the proto for details:
https://github.com/google/or-tools/blob/8b607171852ba1eb53646d24c229f866b3634199/ortools/sat/cp_model.proto#L119
I missed the GetStart(). I will remove it in the next release. I did rename it to getStartExpr() on the C++ API.

Actually, you are calling the proto API. Please use the getStartView() to get a LinearExpressionProto().
As a general rule, you should not depend too much on how the model is stored. This is subject to change.

Ok, thanks for swift response. Have a nice weekend.


Print friendly

The PDFs are currently available as Google docs but these will get outdated as pull requests come in. So, it looks like:

A script should be available in the repo to generate the PDFs (using pandoc?)
The generated PDFs should have links to them on the website
Ideally, the PDFs should be generated after each pull request

See #319 - the .odt documents was created using pandoc, although I did reformat the .odt to incorporate other sections and tidy up, including a TOC, before producing the .pdf
Feedback welcome please

Following on from a move of various topics within the headings, I've produced an .odt & .pdf version of each of the topics now within the beginners guide, in all of the languages, and created links for downloading them. The .odt was produced using pandoc, and only briefly edited (remove some surplus headings for other chapters) before producing the .pdf
My thought is, provide each individually, and the 'trainer' or whoever has the need can amalgamate the .odt document using whichever sections they feel are relevant, and format it as they wish. Adding a TOC and re-sizing the images to suit their needs as they go.
It's not perfect, but I think it is deliverable by me at the moment.
I'll work on the other sections as the need arises - if you need one, let me know & I'll produce it.

is there anyway to have the LearnOSM logo appear in the print view? I briefly took a look at this but couldn't figure out how to do this yet. I see the print.css file

Hi @d3netxer I've started putting the logo manually into the .odt when I produce or update a document. As you've rightly realised there are a lot that don't have the logo in them. If you fancied adding a few & updating them, that would be great, otherwise they wait for me to get the time to do them.

I haven't looked at your .odt workflow, but in this thread I'm referring to when someone clicks print in their browser, not the PDFs that are linked to on individual pages.

Closing. It would be good if some clever person could automate this. In the meantime I'm using pandoc and manually tidying the result.


HTTP/2 to support asynchronous SETTINGS ACK

Motivation:
The HTTP/2 codec will synchronously respond to a SETTINGS frame with a SETTINGS
ACK before the application sees the SETTINGS frame. The application may need to
adjust its state depending upon what is in the SETTINGS frame before applying
the remote settings and responding with an ACK (e.g. to adjust for max
concurrent streams). In order to accomplish this the HTTP/2 codec should allow
for the application to opt-in to sending the SETTINGS ACK.
Modifications:

DefaultHttp2ConnectionDecoder should support a mode where SETTINGS frames can
be queued instead of immediately applying and ACKing.
DefaultHttp2ConnectionEncoder should attempt to poll from the queue (if it
exists) to apply the earliest received but not yet ACKed SETTINGS frame.
AbstractHttp2ConnectionHandlerBuilder (and sub classes) should support a new
option to enable the application to opt-in to managing SETTINGS ACK.

Result:
HTTP/2 allows for asynchronous SETTINGS ACK managed by the application.

still LGTM

build failure attributed to https://github.com/netty/netty/pull/9075

test this please

thanks for review @ejona86! agreed we should do this differently in 5.0 but lets accept the pain for 4.1.

@Scottmitch can you open an issue for 5 so we do not forget ?

I will just cherry-pick it into master as well for now to keep the code-base as similar as possible and we can revisit when we tackle http2 for Netty 5.

Ok done ... also cherry-picked ec62af01c7af372d853bd1a2d2d981a897263b6d


add everything search engine wrapper

add everything search engine wrapper

Add it to the bottom please.

OK~
I've moved it to bottom already


Gradle plugin: proposal for github page improvements

disable packages, since this repo is not going to use GitHub packages ATM

Add repository description and labels for better searching \ indexing

@slandelle @Isammoc WDYT ?

Done. Thanks!


Odd Openstack Access Behavior

Hey folks,
I'm working on getting Security Monkey working with Openstack and I'm trying to tune the permissions with the team that supports our Openstack environment.  They would like to use an existing readonly role, rather than create a new one, and it looks like the permissions are equivalent to those specified in the iam_openstack.md doc.  This existing readonly role enables visibility to all of the assets via CLI and Horizon.  However, Security Monkey is only getting a subset of the security groups.  The main question that I have is why there might be a discrepancy between what's visible in CLI/Horizon versus Security Monkey?
Thanks for the help!

Hi @badllama. What version of OpenStack are you running? Are you just seeing subset of security groups from the same tenant? Do you have multiple regions in your setup?

We're on Pike and it's just one region for the purposes of your question.  In a single tenant, if I see 10 security groups in Horizon, SM only sees 4.  It's the same account for both access methods, so by definition, it'd be the same role.

I'll look around at what might be problem or where to check for debug. Can you try, in your config.py to set SECURITYGROUP_INSTANCE_DETAIL = NONE, to isolate some issue capturing instance details, then restart the SM services?

Looks like that made it worse, now it can't 'see' any security groups.  Lots of 'Problem connecting...' messages.

Odd, that just limits the code that gets run, nothing additional. I should have mentioned that SECURITYGROUP_INSTANCE_DETAIL = FULL is the default, so make sure you are updating that entry vs adding another (look for SECURITYGROUP_INSTANCE_DETAIL).

Ok, nope, I did something silly.  I flipped that to 'NONE' and now it can pull all of the Security Groups.  What is that actually limiting?

It will not try to associate security group assignment to instances, https://github.com/Netflix-Skunkworks/cloudaux/blob/master/cloudaux/orchestration/openstack/security_group.py#L16.
Can you try to set SECURITYGROUP_INSTANCE_DETAIL = SUMMARY?

SUMMARY results in the same behavior as FULL, which is to say that I have problems connecting again.  Is there a specific permission that enables that access?  It seems like it may be associated with the nova IAM policy as opposed to the neutron policy, given that it's trying to access information about compute nodes.

Oh good call, yes, its calling the compute service for instance details. See bottom of https://github.com/Netflix/security_monkey/blob/develop/docs/iam_openstack.md for os_compute_api:servers:show policy note.

I am assuming you already checked the /var/log/security_monkey logs, there is an exception table in the db, I need to go back and remember how you query it.
I use a more permissive account as we do some inline mitigation for issues, so have not used a more restrictive user outside of writing up the instructions. Perhaps with "os_compute_api:servers:show:host_status"?

Yeah, the security_monkey log just shows "Skipping () due to a region-level exception "Problem Connecting to openstack_securitygroup//None:\n'NoneType' object is not iterable"  Perhaps that's more helpful to you than it is to me?
I can try the host_status perm.

It is helpful, let me run this down.

Thanks for all the help @mstair, it's much appreciated.

You mind adding os_compute_api:os-security-groups to your nova policy for your read-only account and trying FULL again? I don't readily have access to a setup where I can modify OS project policies.

That did it, looks like everything is working just fine now.  Thanks again!

Great, I'll update docs!


Change link in paragraph for shopify locale

PR Checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

For now, no need of paragraph translation for in-tag content


Use tail-recursive version of List.take at large n

This is a follow up to #659. We are looking for a way of implementing List.take that doesn't run the risk of a stack overflow and has good performance over as wide a domain as possible. My previous PR failed the second criterion, but after taking a look at this post, I think I have found something that has acceptable performance.
Would love to get some feedback on this!
The Fast Way
takeFast is similar to the current version of take with a bit of loop unrolling. This means that we don't do quite as much recursion, so it can handle larger values of n without crashing. It is also slightly faster than the current implementation.
I expected that unrolling the loop 4 times would have raised the limit on n by a factor of 4, but this turned out to be wrong. In Node, it's only a factor of about 2.6.
If we unroll the loop further, we can speed up the function and raise the limit on n, but these effects drop off pretty quickly.
The Tail-Recursive Way
takeTailRec implements take so that the recursive calls can be optimized. The good news is we no longer have to worry about stack overflows. The bad news is we need to reverse the list before returning it.
Experimentally, the execution time for takeTailRec is about 1.5 times that of takeFast.
Switching between them
The new version of List.take in this PR uses takeFast for small n and switches to takeTailRec when n > 5000. This switch point is somewhat arbitrary. Obviously we want to use the faster implementation as much as we can, but different platforms have different stack sizes, so it's not clear exactly where the danger line is. Firefox started having issues with takeFast around n > 7000. Chrome and IE were better. If we want to test on other platforms, I can share the code for my (very primitive) test harness.
Methodology
These implementations of take were tested by repeatedly running take n [1..10000] for different values of n. Testing was done in Node, Firefox, and Chromium (on Linux Mint) and IE (on Windows 7). I would be happy to provide the raw data and the source code for the test harness.

This is really exciting! It looks like this implementation falls back on the slow/reliable version based on the initial input, whereas the approach Yaron suggested in his post only fell back on the other method after getting N deep. It seems like that'd mean the beginning of long takes would be faster. Did you try an implementation like that?

Two other thoughts:

I have a theory on why unrolling to 4x does not increase stack depth by 4x. The stack is a fixed size. Allocating a stack frame takes space, independent of the particulars of the function. So I guess we save on the fixed costs of allocating a stack frame, but the body of that stack frame is longer than before. And maybe that fixed cost is so high, that jamming more in the function body ultimately takes a bit less space. Otherwise, I'm not sure! :)

I am curious if this approach would give us a faster map implementation as well. It'd be great to move more (all?) of List out of JS, and perhaps it'd be faster in the typical cases anyway. In other words, if you are interested in looking into this approach on other functions, I think there's a chance it would work really well!

Okay, sorry for being disorganized. Here are the two crucial questions.
First, what is the impact of falling back to takeTailRec only after you have recursed through takeFast as far as possible?
If it works well, I think that's the way to go.
Second, what is the impact of doing some unrolling in takeTailRec?
I notice it does not do that at the moment. I assume unrolling makes the compiled code larger, so at some point, it becomes undesirable. Unclear how that tradeoff would play out, so I think it should be outside the scope of this PR. I just wanted to bring it up as soon as possible.

I hadn't tried switching implementations mid-stream the way Yaron does. But I'm looking at that now and it does look like an improvement. As you'd expect, the execution time drifts slowly from the takeFast curve to the takeTailRec curve. I will update the PR.
Unrolling takeTailRec gave a slight improvement in performance (about 10% faster for n=5000). This is a much weaker effect than it has on takeFast (about 75% faster at n=5000).

About switching midway, great, glad it works!
That's really interesting on takeTailRec. Perhaps because it gets compiled to a while loop, the cost of looping back is not really that high relative to everything else, whereas with a function call, the book keeping around that dominates the costs so much that avoiding it is a big deal. Given the numbers, unrolling or not both seem fine to me, so I'll leave it up to your discretion.

Implementation has been updated. I left takeTailRec as is.
I'd be happy to take a look at the other List functions, but I am not I will have much time to contribute in the near future.

Alright, looks good to me. Thanks for working on this and sharing your findings. I learned some cool stuff about JavaScript :)

Glad I was able to help!

Was the choice of 1000 as the limit completely arbitrary?

Not completely. See the comments in original post about setting the limit at 5000. With the changes that happened after that, I needed to lower the limit further.
If the limit is too high, the stack may overflow. The exact size of the stack depends on the platform. It's probably safe to raise the limit a little bit, but since I could not test the code on every platform, I thought it better to err on the conservative side.


yotta (0.15.2) build / target throws fatal error on Fedora 22

yotta build
info: get versions for x86-linux-native
Fatal Exception, yotta=unknown
Traceback (most recent call last):
  File "/usr/bin/yotta", line 4, in <module>
    yotta.main()
  File "/usr/lib/python2.7/site-packages/yotta/main.py", line 44, in wrapped
    return fn(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/yotta/main.py", line 221, in main
    status = args.command(args, following_args)
  File "/usr/lib/python2.7/site-packages/yotta/build.py", line 46, in execCommand
    status = installAndBuild(args, following_args)
  File "/usr/lib/python2.7/site-packages/yotta/build.py", line 70, in installAndBuild
    target, errors = c.satisfyTarget(args.target, additional_config=args.config)
  File "/usr/lib/python2.7/site-packages/yotta/lib/component.py", line 677, in satisfyTarget
    shrinkwrap = self.getShrinkwrap()
  File "/usr/lib/python2.7/site-packages/yotta/lib/target.py", line 156, in getDerivedTarget
    inherit_shrinkwrap = shrinkwrap
  File "/usr/lib/python2.7/site-packages/yotta/lib/access.py", line 385, in satisfyVersion
    name, version_required, working_directory, type=type, inherit_shrinkwrap = inherit_shrinkwrap
  File "/usr/lib/python2.7/site-packages/yotta/lib/access.py", line 314, in satisfyVersionByInstalling
    v = latestSuitableVersion(name, version_required, _registryNamespaceForType(type))
  File "/usr/lib/python2.7/site-packages/yotta/lib/access.py", line 107, in latestSuitableVersion
    vers = remote_component.availableVersions()
  File "/usr/lib/python2.7/site-packages/yotta/lib/registry_access.py", line 485, in availableVersions
    return _listVersions(self.namespace, self.name)
  File "/usr/lib/python2.7/site-packages/yotta/lib/registry_access.py", line 100, in wrapped
    return fn(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/yotta/lib/registry_access.py", line 232, in _listVersions
    request_headers = _headersForRegistry(registry)
  File "/usr/lib/python2.7/site-packages/yotta/lib/registry_access.py", line 414, in _headersForRegistry
    'X-Yotta-Client-Version': _getYottaVersion(),
  File "/usr/lib/python2.7/site-packages/yotta/lib/registry_access.py", line 397, in _getYottaVersion
    _yotta_version = pkg_resources.require("yotta")[0].version
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 918, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 813, in resolve
    new_requirements = dist.requires(req.extras)[::-1]
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2558, in requires
    "%s has no such extra feature %r" % (self, ext)
pkg_resources.UnknownExtra: requests 2.6.2 has no such extra feature 'security'

I have checked,

system time got using python is in sync with UTC.
pip installation  "sudo pip install pyasn1 --upgrade" reports already up-to-date.

Thanks

Your version of the requests package is too old. Run pip install -U requests first.

@autopulated  Thanks for reply.Pip says its upto date.
pip install -U requests
Requirement already up-to-date: requests in /usr/lib/python2.7/site-packages

ah I misread the version in your error message – you do have >=2.4.1, but still only version 2.6.2 (the latest is 2.9.1).
So possibly this is another setuptools issue – It's worth trying installing the latest version of that (pip install -U setuptools), and also updating to the latest yotta, which doesn't use pgk_resources any more when running commands (pip install -U yotta).

@autopulated Updated pip using
dnf install python3-pip
pip install -U setuptools
Collecting setuptools
Using cached setuptools-20.7.0-py2.py3-none-any.whl
Installing collected packages: setuptools
Found existing installation: setuptools 12.0.3
Uninstalling setuptools-12.0.3:
Successfully uninstalled setuptools-12.0.3
Successfully installed setuptools-20.7.0
Got a different Error installing yotta,
pip install -U yotta
Collecting yotta
Downloading yotta-0.16.3.tar.gz (128kB)
100% |████████████████████████████████| 133kB 202kB/s
Requirement already up-to-date: semantic-version<3,>=2.3.1 in /usr/lib/python3.4/site-packages (from yotta)
Requirement already up-to-date: requests[security]<3,>=2.4.3 in /usr/lib/python3.4/site-packages (from yotta)
Requirement already up-to-date: certifi>=2016.2.28 in /usr/lib/python3.4/site-packages (from yotta)
Collecting PyGithub<2,>=1.25 (from yotta)
Using cached PyGithub-1.26.0.tar.gz
Requirement already up-to-date: colorama<0.4,>=0.3 in /usr/lib/python3.4/site-packages (from yotta)
Requirement already up-to-date: hgapi<2,>=1.7 in /usr/lib/python3.4/site-packages (from yotta)
Collecting Jinja2<3,>=2.7.0 (from yotta)
Using cached Jinja2-2.8-py2.py3-none-any.whl
Collecting cryptography>=0.8 (from yotta)
Using cached cryptography-1.3.1.tar.gz
Collecting PyJWT<2.0,>=1.0 (from yotta)
Using cached PyJWT-1.4.0-py2.py3-none-any.whl
Collecting pathlib<1.1,>=1.0.1 (from yotta)
Using cached pathlib-1.0.1.tar.gz
Collecting jsonschema<3.0,>=2.4.0 (from yotta)
Using cached jsonschema-2.5.1-py2.py3-none-any.whl
Collecting argcomplete<2.0,>=0.8.0 (from yotta)
Using cached argcomplete-1.1.1-py2.py3-none-any.whl
Collecting mbed-test-wrapper<2.0.0,>=0.0.3 (from yotta)
Using cached mbed_test_wrapper-1.0.0.tar.gz
Collecting valinor<1.0,>=0.0.0 (from yotta)
Using cached valinor-0.0.15.tar.gz
Collecting intelhex<3.0,>=2.0 (from yotta)
Using cached intelhex-2.1-py2.py3-none-any.whl
Collecting jsonpointer<2.0,>=1.9 (from yotta)
Using cached jsonpointer-1.10.tar.gz
Requirement already up-to-date: pyasn1 in /usr/lib/python3.4/site-packages (from requests[security]<3,>=2.4.3->yotta)
Collecting ndg-httpsclient (from requests[security]<3,>=2.4.3->yotta)
Using cached ndg_httpsclient-0.4.0.tar.gz
Collecting pyOpenSSL>=0.13 (from requests[security]<3,>=2.4.3->yotta)
Using cached pyOpenSSL-16.0.0-py2.py3-none-any.whl
Requirement already up-to-date: MarkupSafe in /usr/lib/python3.4/site-packages (from Jinja2<3,>=2.7.0->yotta)
Requirement already up-to-date: idna>=2.0 in /usr/lib/python3.4/site-packages (from cryptography>=0.8->yotta)
Collecting six>=1.4.1 (from cryptography>=0.8->yotta)
Using cached six-1.10.0-py2.py3-none-any.whl
Requirement already up-to-date: setuptools>=11.3 in /usr/lib/python3.4/site-packages (from cryptography>=0.8->yotta)
Collecting cffi>=1.4.1 (from cryptography>=0.8->yotta)
Using cached cffi-1.5.2.tar.gz
Requirement already up-to-date: pyyaml<4,>=3 in /usr/lib/python3.4/site-packages (from valinor<1.0,>=0.0.0->yotta)
Collecting pyOCD<1.0,>=0.3 (from valinor<1.0,>=0.0.0->yotta)
Using cached pyOCD-0.7.0.zip
Collecting project-generator<0.9.0,>=0.8.0 (from valinor<1.0,>=0.0.0->yotta)
Using cached project_generator-0.8.14.zip
Collecting pyelftools==0.23 (from valinor<1.0,>=0.0.0->yotta)
Using cached pyelftools-0.23.tar.gz
Requirement already up-to-date: pycparser in /usr/lib/python3.4/site-packages (from cffi>=1.4.1->cryptography>=0.8->yotta)
Collecting enum34 (from pyOCD<1.0,>=0.3->valinor<1.0,>=0.0.0->yotta)
Using cached enum34-1.1.3-py2.py3-none-any.whl
Collecting pyusb>=1.0.0b2 (from pyOCD<1.0,>=0.3->valinor<1.0,>=0.0.0->yotta)
Using cached pyusb-1.0.0rc1.tar.gz
Collecting argparse (from project-generator<0.9.0,>=0.8.0->valinor<1.0,>=0.0.0->yotta)
Using cached argparse-1.4.0-py2.py3-none-any.whl
Collecting xmltodict (from project-generator<0.9.0,>=0.8.0->valinor<1.0,>=0.0.0->yotta)
Using cached xmltodict-0.10.1.tar.gz
Collecting project-generator-definitions<0.3.0,>=0.2.2 (from project-generator<0.9.0,>=0.8.0->valinor<1.0,>=0.0.0->yotta)
Using cached project_generator_definitions-0.2.12.zip
Installing collected packages: PyGithub, Jinja2, six, cffi, cryptography, PyJWT, pathlib, jsonschema, argcomplete, mbed-test-wrapper, intelhex, enum34, pyusb, pyOCD, argparse, xmltodict, project-generator-definitions, project-generator, pyelftools, valinor, jsonpointer, yotta, pyOpenSSL, ndg-httpsclient
Found existing installation: PyGithub 1.25.2
Uninstalling PyGithub-1.25.2:
Successfully uninstalled PyGithub-1.25.2
Running setup.py install for PyGithub ... done
Found existing installation: Jinja2 2.7.3
Uninstalling Jinja2-2.7.3:
Successfully uninstalled Jinja2-2.7.3
Found existing installation: six 1.9.0
Uninstalling six-1.9.0:
Successfully uninstalled six-1.9.0
Running setup.py install for cffi ... error
Complete output from command /bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-build-la32wpnl/cffi/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-ce2zv5c3-record/install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_py
creating build
creating build/lib.linux-i686-3.4
creating build/lib.linux-i686-3.4/cffi
copying cffi/recompiler.py -> build/lib.linux-i686-3.4/cffi
copying cffi/verifier.py -> build/lib.linux-i686-3.4/cffi
copying cffi/cffi_opcode.py -> build/lib.linux-i686-3.4/cffi
copying cffi/setuptools_ext.py -> build/lib.linux-i686-3.4/cffi
copying cffi/init.py -> build/lib.linux-i686-3.4/cffi
copying cffi/lock.py -> build/lib.linux-i686-3.4/cffi
copying cffi/api.py -> build/lib.linux-i686-3.4/cffi
copying cffi/gc_weakref.py -> build/lib.linux-i686-3.4/cffi
copying cffi/vengine_gen.py -> build/lib.linux-i686-3.4/cffi
copying cffi/ffiplatform.py -> build/lib.linux-i686-3.4/cffi
copying cffi/cparser.py -> build/lib.linux-i686-3.4/cffi
copying cffi/backend_ctypes.py -> build/lib.linux-i686-3.4/cffi
copying cffi/commontypes.py -> build/lib.linux-i686-3.4/cffi
copying cffi/model.py -> build/lib.linux-i686-3.4/cffi
copying cffi/vengine_cpy.py -> build/lib.linux-i686-3.4/cffi
copying cffi/_cffi_include.h -> build/lib.linux-i686-3.4/cffi
copying cffi/parse_c_type.h -> build/lib.linux-i686-3.4/cffi
copying cffi/_embedding.h -> build/lib.linux-i686-3.4/cffi
running build_ext
building '_cffi_backend' extension
creating build/temp.linux-i686-3.4
creating build/temp.linux-i686-3.4/c
gcc -pthread -Wno-unused-result -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DUSE__THREAD -I/usr/include/python3.4m -c c/_cffi_backend.c -o build/temp.linux-i686-3.4/c/_cffi_backend.o
c/_cffi_backend.c:2:20: fatal error: Python.h: No such file or directory
compilation terminated.
error: command 'gcc' failed with exit status 1
----------------------------------------

Command "/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-build-la32wpnl/cffi/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-ce2zv5c3-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-la32wpnl/cffi/

How to remove the existing yotta (0.15.2),
pip uninstall yotta
Cannot uninstall requirement yotta, not installed
But yotta command exists.

which yotta will tell you where the yotta that's being run is:
It's possible that you have two separate python installations – python 2, and python 3. I'm not sure how Fedora handles this, but you might have separate pip2 and pip3 commands for installing/uninstalling programs for each of them.
The installation is failing because binaries aren't available for your platform, and you're missing the python development headers needed to install the cffi module. I think def install python3-devel should install them.

Thanks it worked!!!
pip2 uninstall yotta   removed existing yotta
Installed development headers and yotta using,
def install python3-devel
pip install -U yotta


Remove distributeSurplus's indirect dependency on W.ProtocolParameters

[x] Take a FeePerByte instead of FeePolicy in distributeSurplus
[x] Add function feePerByte :: RecentEra era -> PParam era -> FeePerByte

Comments

I left distributeSurplus where it is for now. We could move it to some Write.Tx.{Fees,Size,Balance,} module later.

Issue Number
ADP-2459

bors r+


Implement SE Account updating

Once the Settlement RFC is finalized, update the Connector's AccountSettings object and Admin API controller to allow updates from the Connector Account to percolate to the settlement engine account, if necessary.
Currently, updating a Connector account doesn't do anything with the SE, so the SettlementEngineClient.updateAccount method is likely not necessary. Ditto for the client's delete account.
However, we should rethink this just to be safe, once the Spec has been finalized.

Superseded by #220


Question/request feature: retrieve the storage slot layout of a contract

I know that OZ computes and uses the storage layout of a contract for checking compatibility between upgrades
Is it possible to access this layout inside a script? ( other than deploy an actual proxy and check the .openzeppelin folder)?

Can you describe your use case?
Typically the storage layout is available from the solc output (if requested from the input settings), although we do additional processing to extract layout when it isn't available, such as for namespaced storage when using ERC-7201.
In Hardhat, after you compile, you can find a cache folder with a validations.json which includes the complete storage layouts that were computed for each contract.  Is that data format suitable for you, if we make that available from a script?

Hey! thank you so much.
Actually that validations.json is what is was searching for hehe ^^
Actually if that would be available it would help a little, but having it there for me it's ok ^^
I will report what i think it's an small issue:
I think the errors shown when  unsafeAllowRenames: false, are not correct.
I think i verify it manually, checking the validations.json and also testing in solidity (checking in assembly the storage slots), and everything seems coherent but the errors shown.
In the following repo and branch: https://github.com/0xPolygonHermez/zkevm-contracts/tree/6048728b72b9d3425157b22bce26c5ed8ac49c5e
Currently i'm doing an Upgrade test from a previous to a new system, and i use the upgradeProxy function.
Since the contract it's pretty different i want to rename some variables as _legacy${nameOfVariable} but as a double check i test the   unsafeAllowRenames: false, just to see what errors pop up ( because what should not happen is that i mess up the storage layout for sure):
https://github.com/0xPolygonHermez/zkevm-contracts/blob/6048728b72b9d3425157b22bce26c5ed8ac49c5e/test/contractsv2/PolygonRollupManagerUpgrade.ts#L222
If the flag   unsafeAllowRenames: true,, the test goes though and everything looks fine
If the flag   unsafeAllowRenames: false, there are expected Replaced errors, but also seems that somehow it calculates something wrong. For instance: Inserted _legacyOwner, (which should be only renames), and some replaced variables seems to have an "incorrect" offset, for example multiplierBatchFee it's replaced by _legacyMultiplierBatchFee, but in the error shows:
contracts/v2/lib/LegacyZKEVMStateVariables.sol:43: Replaced `multiplierBatchFee` with `_legacyVerifyBatchTimeTarget` of incompatible type

Finally i try to actually add variables with the  unsafeAllowRenames: true, and it does show a correct error. So my guess is that, everything it's fine except the error displayed when unsafeAllowRenames : false
Hope it helps:
To reproduce the error:
Go this repo in this branch:
https://github.com/0xPolygonHermez/zkevm-contracts/blob/6048728b72b9d3425157b22bce26c5ed8ac49c5e/test/contractsv2/PolygonRollupManagerUpgrade.ts#L222
npm i
npx hardhat test/contractsv2/PolygonRollupManagerUpgrade.ts
You can edit the flag here: https://github.com/0xPolygonHermez/zkevm-contracts/blob/6048728b72b9d3425157b22bce26c5ed8ac49c5e/test/contractsv2/PolygonRollupManagerUpgrade.ts#L222
Node version: v18.16.1
Npm version: 9.5.1

About validations.json, that file isn't exposed as part of our public API though, and it's possible that the format can change in the future.  It gets regenerated when you recompile contracts in Hardhat and gets deleted if you run npx hardhat clean.  Is that ok for your use case?
In your test, it looks like you are upgrading from PolygonZkEVMV2Existent to PolygonRollupManagerMock.  Those storage layouts are definitely NOT compatible!
Your usage of unsafeAllowRenames: true does not look safe.  That flag should only be used as a last resort.  If you have specific variables that you want to rename, you should annotate them in the new implementation using /// @custom:oz-renamed-from x.  See https://docs.openzeppelin.com/upgrades-plugins/1.x/faq#how-to-rename

Hey! actually in the mail i can see the historic ^^ And  https://docs.openzeppelin.com/upgrades-plugins/1.x/faq#how-to-rename this was super helpful!!! didn't know about it :D Now i feel it safer,  i wanted to make sure that i count everything right ^^
https://github.com/0xPolygonHermez/zkevm-contracts/tree/162394ddc6d75eb31496823a49b259a0ed61a908
In this commit it works with unsafeAllowRenames: false, ^^
Still think that there are some bug when displaying the errors in unsafeAllowRenames, it seems that it detects everything right but somehow displays something wrong if it finds errors
Anyway this was actually super helpfull, thank you so much ^^

Hi, I wanted to clarify my comment.
About validations.json, that file isn't exposed as part of our public API though, and it's possible that the format can change in the future.  It gets regenerated when you recompile contracts in Hardhat and gets deleted if you run npx hardhat clean.  Is that ok for your use case?
I would suggest not using unsafeAllowRenames: true except as a last resort, since it does not let you granularly specify what are the renamed variables (it can be used, but would not allow you to specify a 1-to-1 rename of each variable).  If you have specific variables that you want to rename, you can annotate them in the new implementation using /// @custom:oz-renamed-from x instead.  See https://docs.openzeppelin.com/upgrades-plugins/1.x/faq#how-to-rename
I don't see any issues with the storage layouts between your contracts.  For storage layout validations, the comparison is using levenshtein distances to find the closest matches.    Allowing variable renames would avoid this.

About the file, yes! it is ok! :D
About  unsafeAllowRenames totally! ^^  didn't know about the annotation thing hehe ^^
About the storage layout errors, i guess it makes sense, its surprising some results of it. Since the storage slot and offset are deterministic, the algorithm could know if a variable was either inserted, or replaced by one or more variables. Also true that might not be worth to edit this if it's over complicated since it accomplish the goal which is telling the user that something it's wrong and where ^^

One counter-example is if a variable is inserted at the beginning of storage layout, then the other variables are shifted and in different slots.  If we assume the slots and offsets to be the same, then the approach that you suggested might say that all variables were renamed, when ideally it should say a variable was inserted.  Neither of these is incorrect though.

might not be worth to edit this if it's over complicated since it accomplish the goal which is telling the user that something it's wrong and where

Yes, I agree. I don't think that this can be improved much without affecting the error message for other scenarios.
Closing this since there is a way to achieve what you originally asked, but feel free to continue the discussion if needed.

One counter-example is if a variable is inserted at the beginning of storage layout, then the other variables are shifted and in different slots. If we assume the slots and offsets to be the same, then the approach that you suggested might say that all variables were renamed, when ideally it should say a variable was inserted. Neither of these is incorrect though.

From my point of view, it actually would mean that you change all the variables, because practically, all variables will change his values. I understand that's opinionated tho.
Thank you so much for your responses ^^


How could I use Liveshare in complete LAN

I have two computers which are in the same LAN. But all of them are not allowed to connect to WAN. So how could I use Liveshare? How could I create a link which belongs to LAN but not WAN or Does Liveshare support complete LAN? I know it can switch to Direct mode to share through LAN, but my problem is that I cannot build or join a session in a complete LAN environment. If this is not supported, please consider it because sometimes some important code is not allowed to be accessable through WAN. Liveshare is an excellent and more convenient to collaborate than using Git or SVN. I think many people like me are looking forward to the full support of LAN. Thanks!

Adding @lostintangent .

Closing as a duplicate of #338.


Update CF CLI version

We need to update the CF CLI version due to changes in commands in CF 9.x series. I have updated the tests and also changed the base container to a Xenial container.

This needs log cache version 2.1 as well in order to get envelope-class
I've added a couple of suggestions through the UI but I can't suggest on the actual install-plugin line of code.

Merge as done as pair


Build warning

Package 'Microsoft.Bot.Connector.Teams 0.9.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'

You're probably getting this warning if you're using a higher version of Visual Studio, like Visual Studio 2019. Regardless of this warning, you should be able to build the solution without any problems.


CTCP-229: post-discussion changes

In line 410 it's referred to as "Positive Acknowledge" in line 238 but in the diagram cancel_pre-lodge_dec.svg, it's called IE928 Positive Acknowledgement.
Same in correct_pre-lodge_dec_prior_pres_goods.svg.
And standard_departure.svg
And trans_pres_notif_valid.svg.
Also, unload_remarks_reject.svg still has an instance of IE025 Goods Released instead of Release.


网页端一打开网址输入密码就会报错

显示 /internal servererror
the server encounter an 。。。。。ouerloaded

显示 /internal servererror the server encounter an 。。。。。ouerloaded

控制台看下出错的日志

可能没安装PyJWT包

同问，楼主搞定了吗？

我也是一登陆就提示错误信息：
The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.

可能没安装PyJWT包
显示已经安装了的

还是原来的报错

你要看后台报的什么错才能知道是什么问题

我是登陆后提示这个错误，不知道楼主是不是：
[2023-03-29 18:51:09,828] ERROR in app: Exception on /login [POST]
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2073, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1518, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1516, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1502, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/http/http_channel.py", line 50, in login
response.set_cookie(key='Authorization', value=token)
File "/usr/local/lib/python3.6/site-packages/werkzeug/sansio/response.py", line 245, in set_cookie
samesite=samesite,
File "/usr/local/lib/python3.6/site-packages/werkzeug/http.py", line 1296, in dump_cookie
value = _to_bytes(value, charset)
File "/usr/local/lib/python3.6/site-packages/werkzeug/_internal.py", line 108, in _to_bytes
raise TypeError("Expected bytes")
TypeError: Expected bytes
<IP_ADDRESS> - - [29/Mar/2023 18:51:09] "POST /login HTTP/1.1" 500 -

是的
| |
g.
|
|
@.***
|
---- 回复的原邮件 ----
| 发件人 | @.> |
| 日期 | 2023年03月30日 08:56 |
| 收件人 | @.> |
| 抄送至 |<EMAIL_ADDRESS>|
| 主题 | Re: [zhayujie/bot-on-anything] 网页端一打开网址输入密码就会报错 (Issue #217) |
我是登陆后提示这个错误，不知道楼主是不是：
[2023-03-29 18:51:09,828] ERROR in app: Exception on /login [POST]
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2073, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1518, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1516, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1502, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/http/http_channel.py", line 50, in login
response.set_cookie(key='Authorization', value=token)
File "/usr/local/lib/python3.6/site-packages/werkzeug/sansio/response.py", line 245, in set_cookie
samesite=samesite,
File "/usr/local/lib/python3.6/site-packages/werkzeug/http.py", line 1296, in dump_cookie
value = _to_bytes(value, charset)
File "/usr/local/lib/python3.6/site-packages/werkzeug/_internal.py", line 108, in _to_bytes
raise TypeError("Expected bytes")
TypeError: Expected bytes
<IP_ADDRESS> - - [29/Mar/2023 18:51:09] "POST /login HTTP/1.1" 500 -
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

我是登陆后提示这个错误，不知道楼主是不是： [2023-03-29 18:51:09,828] ERROR in app: Exception on /login [POST] Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2073, in wsgi_app response = self.full_dispatch_request() File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1518, in full_dispatch_request rv = self.handle_user_exception(e) File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1516, in full_dispatch_request rv = self.dispatch_request() File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1502, in dispatch_request return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/http/http_channel.py", line 50, in login response.set_cookie(key='Authorization', value=token) File "/usr/local/lib/python3.6/site-packages/werkzeug/sansio/response.py", line 245, in set_cookie samesite=samesite, File "/usr/local/lib/python3.6/site-packages/werkzeug/http.py", line 1296, in dump_cookie value = _to_bytes(value, charset) File "/usr/local/lib/python3.6/site-packages/werkzeug/_internal.py", line 108, in _to_bytes raise TypeError("Expected bytes") TypeError: Expected bytes <IP_ADDRESS> - - [29/Mar/2023 18:51:09] "POST /login HTTP/1.1" 500 -

报这个错一般都是没装PyJWT包

解决了谢谢，楼主 执行 pip3 install Pyjwt 即可！但又出现了  网络故障，对话未送达
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2073, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1518, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1516, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1502, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/http/http_channel.py", line 28, in chat
reply_text = HttpChannel().handle(data=data)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/http/http_channel.py", line 65, in handle
return super().build_reply_content(data["msg"], context)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/channel/channel.py", line 31, in build_reply_content
return Bridge().fetch_reply_content(query, context)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/bridge/bridge.py", line 9, in fetch_reply_content
return model_factory.create_bot(config.conf().get("model").get("type")).reply(query, context)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/model/openai/chatgpt_model.py", line 36, in reply
reply_content = self.reply_text(new_query, from_user_id, 0)
File "/home/tools/chat3.5/bot-on-anything-1.0.0/model/openai/chatgpt_model.py", line 74, in reply_text
except openai.error.Timeout as e:
AttributeError: module 'openai.error' has no attribute 'Timeout'
<IP_ADDRESS> - - [30/Mar/2023 10:43:25] "POST /chat HTTP/1.1" 500 -

我的也是这样，有解决方案吗大佬们


Get days, time, building, etc. of courses

Hi Wang, I was using your webreg_scraper and I found that it was not collecting the days, start time, end time and some other attributes in the output file. I would like to get them in the result, how can I do so? I tried to go through the code but I know nothing about Rust. It seems like the webweg wrapper is imported somehow into this repo and its functions(SearchRequestBuilder) are used to get those data. Could you guide me through this?
Thank you

Ops, I mean to post this in the webreg_scraper repo.


CVE-2017-15133: A denial of service flaw was found in miekg-dns before 1.0.4

What did you do?
FYI: I've just tested the Go dependency vulnerability scanner nancy on the alertmanager master branch and it found one issue.
I did not look too close into this issue myself and don't know if it really is important. I just wanted to let you know.
What did you expect to see?
No known vulnerabilities.
What did you see instead? Under which circumstances?
$ ./nancy ~/src/github.com/prometheus/alertmanager/go.sum
2019/02/04 13:52:50 Replaying from value pointer: {Fid:0 Len:42 Offset:31640}
2019/02/04 13:52:50 Iterating file id: 0
2019/02/04 13:52:50 Iteration took: 18.957µs
[...]
[1/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[2/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[3/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[4/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[5/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[6/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[7/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[8/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[9/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[10/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[11/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[12/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[13/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[14/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[15/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[16/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[17/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[18/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[19/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[20/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[21/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[22/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[23/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[24/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[25/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[26/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[27/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[28/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[29/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[30/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[31/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[32/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[33/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[34/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[35/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[36/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[37/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[38/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[39/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[40/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[41/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[42/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[43/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[44/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[45/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[46/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[47/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[48/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[49/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[50/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
------------------------------------------------------------
[51/87]<EMAIL_ADDRESS>[Vulnerable]    1 known vulnerabilities affecting installed version

[CVE-2017-15133]  Uncontrolled Resource Consumption ("Resource Exhaustion")
A denial of service flaw was found in miekg-dns before 1.0.4. A remote attacker could use carefully timed TCP packets to block the DNS server from accepting new connections.

ID: 550f10f6-8f30-4b62-984b-b384d0fd5735
Details: https://ossindex.sonatype.org/vuln/550f10f6-8f30-4b62-984b-b384d0fd5735
[52/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[53/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[54/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[55/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[56/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[57/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[58/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[59/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[60/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[61/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[62/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[63/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[64/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[65/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[66/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[67/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[68/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[69/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[70/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[71/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[72/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[73/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[74/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[75/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[76/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[77/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[78/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[79/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[80/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[81/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[82/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[83/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[84/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[85/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[86/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...
[87/87]<EMAIL_ADDRESS>  No known vulnerabilities against package/version...

Audited dependencies: 87, Vulnerable: 1

Alertmanager version:

$ git describe --tag
v0.16.0-alpha.0-36-g5c5ff9e

Given that Alertmanager uses the given library as a client (memberlist), not a server, I don't think this attack applies to us.
I will look into updating this dependency anyways.
Thanks for reporting the issue. For future security vulnerabilities please do not report them publicly, but instead please reach out to the maintainer of the project directly. This gives us more time to mitigate the problem.

Closed by #1738


Fix parent setter's invalidation never occurring

Fixes https://github.com/ppy/osu-framework/pull/1816
Parent already performs an Invalidate() upon being set, but wouldn't do anything because Drawables aren't usually not loaded by that point.

This seems to have broken game window resizing.


Query components in app params

Moved the querytype to be in app_params rather than just appended to the name

Could you give the thumbs up on this one by testing queries? ("/files", "/prefix/genomics")

Could you give the thumbs up on this one by testing queries? ("/files", "/prefix/genomics")

Addressed in most recent commit.
Screenshot of testing


Devise implementation

Devise is implemented for log in, sign-up, and logout.  Mailers are set up in development mode but commented out.  I suggest we come back later and open the ability to reset password, as it will just be a matter of some uncommenting.  The registrations controller is currently only manually tested and taking too much time, so will be revisited after more research.

:shipit:


feat(product, cart, category): clean up magento models/factories/queries

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
A lot of the magento product models (and consequently the queries and factories) aren't strongly typed all the time, or just aren't in sync. There's also a product query fragment in cart.
What is the new behavior?
Moved the product fragment into the product package. Fixed up and neatened up the product models for magento.
Does this PR introduce a breaking change?
[x] Yes
[ ] No

I addressed the breaking change in this PR.

This PR lgtm.


ORC-1116: [C++] Fix csv-import tool when exporting long bytes

What changes were proposed in this pull request?
Let each string type columns use its own databuffer before writing data into orc file, so that when one column is calling buffer.resize(), the invalidated buffer.data() is not affecting other columns which points to it.
Why are the changes needed?
When using the csv-import tool to export a orc file with schema like "struct<a:string,b:binary>", if the data in column "b" has very long bytes (over 4MB), the process could segmentation fault or the exported data in column "a" could become empty string.
Following the code in CSVFileImport.cc, when writing a orc file, all string type columns is using one databuffer inside function fillStringValues(). If a data length is larger than the buffer, the buffer will be resized. The resize() operation will cause all previous result of buffer.data() become invalid.
In this case, when field "a" finished writing data into buffer, field "b" begin writing will resize the buffer, invalidate previous buffer.data(), so field "a"'s stringBatch is not refering to a valid buffer.data() any more.
A workaround could use different databuffers for each string type column, however requires allocating 4MB memory each. Alternatively using one same databuffer, but let all previous stringBatch re-points to databuffer's new address, after a resize() operation happens.
How was this patch tested?
Prepare a csv file with two columns, while the second column has data larger than 4MB, like:
str1,longbinaryabcd..........
Run following command which finished successfully:
$ csv-import "struct<a:string,b:binary>" Testbinary.csv /tmp/test.orc
Run the following command shows data correctly:
$ orc-contents /tmp/test.orc --columns=0
{"a": "str1"}

cc @wgtmac , @guiyanakuang , @stiga-huang too

PR

Yes, however it may take some time, as I am new to github..

Could you add a test coverage at TestCSVFileImport.cc, @KyleGrains?
Yes, however it may take some time, as I am new to github..

@KyleGrains  I added you to the Apache ORC contributor group and assigned ORC-1116 to you.
Welcome to the Apache ORC community again.

@KyleGrains I added you to the Apache ORC contributor group and assigned ORC-1116 to you. Welcome to the Apache ORC community again.

Thanks, do I need to click any button on the issue page?

No need from your side, @KyleGrains . :)


ROS2 support

I would like to know whether there is any plan to port this package to ROS2

I would really want this package to be on ROS2. It would be a big help.


Update voice and shard examples

Please describe the changes this PR makes and why it should be merged:
Update examples so that users are not mistaken for old versions of the library.
Extended PR of #1382
Semantic versioning classification:

[ ] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[x] This PR only includes non-code changes, like changes to documentation, README, etc.

@bdistin updated format.
Waiting on travis to approve


how launch the chat?

Hi
I installed it on Windows.
Now how do I launch the chat?

Try like this.
https://impsbl.hatenablog.jp/entry/GPTonWindowsPCwith8GB-RAM_alpaca.cpp_en


change location of moquette.conf in embedded mode

Is it possible to store the moquette.conf in another location than "config/moquette.conf"?
I'm using this example: EmbeddedLauncher.java

Moquette in its release package uses that file path (it's hardcoded) but
for embedded moquette you could give a look at subsclasses of IConfig
(ClasspathConfig, MemoryConfig and FilesystemConfig)
Andrea
On Thu, Oct 20, 2016 at 1:50 PM, Manu Miu<EMAIL_ADDRESS>wrote:

Is it possible to store the moquette.conf in another location than
"config/moquette.conf"?
I'm using this example: EmbeddedLauncher.java
https://github.com/andsel/moquette/blob/5efad350d8c73071823e839daf56667d5847f935/embedding_moquette/src/main/java/io/moquette/testembedded/EmbeddedLauncher.java
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andsel/moquette/issues/223, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_Y0fmUxPO025xmGqnHjaamqvH8ihTqks5q11WZgaJpZM4KcCL8
.

Thanks! I'll try that.


[CLI]: generate infra diagram in pipeline

Description
This pull request updates the pipeline by adding a new step that generates the infrastructure and stores it as an artifact.
Related

https://github.com/mbc-net/mbc-cqrs-serverless/discussions/44

Thank you!


Missing funds & New Transactions after upgrade

Upgraded to v1.3, had problems so downgraded to V1.2
Synced up, zero funds and now noticed 3 different TX's. The odd part is, the TX's are right about the same times that i booted up v1.3 (two last night), then booted up v1.2 (today)
I've been trying to make sense of this, but can't at the moment. To me, it looks like the funds were stolen, but the timing is way too close to the times i made installation. No easy way that I know of to see if those receiving addresses are mine.
Am i missing something here?
Note: The img downloads were from the releases page, direct download, no torrent.

I also tried recovering funds from seed on both the pi and lnd wallet desktop. Shows the same TX's
Here are the transaction is you want to dig in
Funding
Dest Addresses
:
35JaP8txyaYmmQQ2uCJbfHsSBhuDuniG5j
bc1qyf4qvq9l4ghxyrm60rcrmggh8nphtfkmaxxnxt
Time Stamp
:
Apr/27/19 01:52:45
Num Confirmations
:
34,854
Block Hash
:
00000000000000000020d07dc30765aff541b320d91fe878383972c6caf6039a
Block Height
:
573,433
Tx Hash
:
19aef94b4a101ba2c73f806e968c0d5e633e0aa58e8e92b4e99a26757067d4fe
Amount
:
353,039

Transactions yesterday
Dest Addresses
:
bc1qcuman5kplk6epk9h57z58xpw9aeuavqxyl0durjck8fztwhznxeqhjm4aw
bc1qydlufmzfcfmrweaqyhnfeuva0wm6yqapf76pn4
Time Stamp
:
Dec/14/19 12:08:42
Num Confirmations
:
165
Total Fees
:
2,866
Block Hash
:
00000000000000000003d058cd9ab54c7711f00739ed8f29cedebdef84ce24d8
Block Height
:
608,122
Tx Hash
:
00aba01cc0d5d1b695ad0495ccbfa82b957fccb392ff7a207e8f8ca53d287c0c
Amount
:
-48333

Dest Addresses
:
bc1q7na6kzwj73x52dg88n90jfkyt0vsm8jux2mwll
bc1qn03fnexjrsc0maxa0f5trwzxnvjyu6p9wwlwy23fd5qml9u3mqjq9k4q7u
Time Stamp
:
Dec/14/19 12:08:42
Num Confirmations
:
165
Total Fees
:
1,981
Block Hash
:
00000000000000000003d058cd9ab54c7711f00739ed8f29cedebdef84ce24d8
Block Height
:
608,122
Tx Hash
:
a14e529fbdc93728f9dea8023bdf0898097a10e8586a8c420bcd6a2bfad69bc0
Amount
:
-77759

Transaction today
INFO
close
Dest Addresses
:
bc1qny392lp5hcqzsp4rdag0xdzt53p9cuduwxmkxh
bc1qr76a62zpaqx9lch3l3442redsxs9x432e9f3ye8r6pt04rktmxtqk6sa5g
Time Stamp
:
Dec/15/19 14:44:31
Num Confirmations
:
33
Total Fees
:
2,932
Block Hash
:
000000000000000000072b1305588ccf14d99e9143298a2a7a85e61edaf01328
Block Height
:
608,254
Tx Hash
:
2bf93840a10d9b7f9eb4630633dd9cb41227196bd30d06f69c2b0fdf22d1c3b4
Amount
:
-100206 ```

Your channels have been force closed from the Static Channel Backups and funds will become available in the onchain part of you LND wallet after the locktime expires.
It is a day by deafult, so funds can be already there, but can be longer.
Check again.

Oh. That's awesome. I was hoping that was the case. Thanks for the help!

Funds still have not returned, but this may be from the pending channels. Closing for now. Thanks for the help


Data Faker for Testing

need to be able to generate some data in the test db that would represent a known state. like filling the wemo logs with on states for the past 5 minutes and off states for the 10 minutes before that. so i can have a test for the functions that try to see if a light has been on for 5 minutes.

it works


test: Always run saucelabs tests locally

I think this is a simpler approach for #619. Always run the sauce labs
tests locally. If users lack the right sauce labs credentials, they’ll
get an error and hopefully set up zuul correctly before sending a PR.

Tests all pass. Merging!


[auth][android] resolve signOut return undefined #174

Hi @NathanWalker @triniwiz
this is a PR in case you agree about #174.

@NathanWalker
This is a little issue with logout can you verify and if ok push please.
Thanks

The native signOut return type on android is void, adding async in front of it won't cast it to boolean. I think the best solution would be to add a return true after calling the native method.

Currently it is return true but it doesn’t work

So we can register the plugin him self and resolve the promise!
according to the docs signOut has a completion handler.

@mukaschultze I updated the code since android return void in order to capture the real signOut event.
@NathanWalker @triniwiz What do you think about this way ?
async signOut(): Promise<boolean> {
		return new Promise((resolve, reject) => {
        this.native?.signOut();
        let timeout = setTimeout(() => {
            reject(false);
        }, 3000);
        this.addAuthStateChangeListener((user) => {
            clearTimeout(timeout);
            console.log("User signed out", user);
            if(user) {
                reject(false);
            }
            resolve(true);
        });
     })
}

@NathanWalker, @triniwiz .. any news aboutt this PR !

Sorry didn’t get time to review it but I’ll get to it soon
Sent from Yahoo Mail for iPhone
On Wednesday, March 8, 2023, 8:29 PM, kefahB @.***> wrote:
@NathanWalker, @triniwiz .. any news aboutt this PR !
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


feat: add admin actions for restore and hard_delete

This PR adds model admin actions for restoring and hard deleting objects.
Closes #31

Thank you!
It will be included in v1.0.13


Anonymous Javascript function in table event does not trigger handler in the backend

I'm trying to add interactivity to a table such that when a click is made on a row, the row id and its content are stored in two variables idand rowcontent. I have two handlers attached to each of the variables to display their contents when they change. When I select a row, the variable rowcontentis updated in the front end but its value is not propagated to the back. This is the event handler definition
     table(:data, var"v-on:row-click"="function(event,row) {id=row.__id;rowcontent=row}")

However, if I do rowcontent = String(row) then it works.
Moreover, I have two buttons to clear the selection. One clears the variables directly, whereas the other uses an anonymous function. Both buttons work so the issue seems not to be in the use of an anonymous function.
Perhaps it's that assigning one variable to the other like rowcontent=rowdoes not trigger the handler in table event functions?
Here's the MWE code:
using GenieFramework
using DataFrames
@genietools

@app begin
    @in id = 0
    @in rowcontent = ""
    @in placeholder = "placeholder"
    @out data = DataTable(DataFrame(a = rand(5) , b = rand(5)))
    @onchange id begin
        @show id
    end
    @onchange rowcontent begin
        @show rowcontent
    end
end

function ui()
    [
     p("Row: {{id}}, {{rowcontent}}")
     table(:data, var"v-on:row-click"="function(event,row) {id=row.__id;rowcontent=row}")
    btn("Remove selection",@click("id=0; rowcontent=placeholder"))
    btn("Anonymous remove selection",@click("function() {id=0; rowcontent=placeholder}"))
   ]
end
@page("/", ui)
up()

It does trigger the backend, but it fails assigning the value to rowcontent, because rowcontent is initialised to be of type String, but rowcontent on the client side is an object.
Whenever you are not sure what will be transmitted by the program, you can initialise the app variable of type Any.
@app begin
    @in id = 0
    @in rowcontent::Any = ""
    <...>
end

Then click the row and you will find that rowcontent is of type Dict{String, Any} and you can chose this type for initialisation.
You could, of course, also initalise rowcontent as  row = Dict{Symbol, Any}(), and everything will work out as well.

@PGimenez coudl you verify and close?
Otherwise please comment


UnboundLocalError in duplicate image segregation

Traceback (most recent call last):
File "/home/bob/PycharmProjects/duplicateFileFinder/main/main.py", line 646, in
fileSearcher.search()
File "/home/bob/PycharmProjects/duplicateFileFinder/main/main.py", line 518, in search
self.markAlreadyProcessedFile(folderOrdinal, fileOrdinal)
UnboundLocalError: local variable 'fileOrdinal' referenced before assignment

It was an indentation bug. Fixed it. Thank you very much, rbunn80110, for reporting this :-)


Adding BufferLevel test to SapiEmitter

Emitter Tests is just separated to run SapiEmitter specific test

This adding covers flush test

current, master

↓↓↓

this PR

Merged to develop for release with 1.5.0; thanks @sasezaki


Add latency constrained training for MoChA

Add implementations of https://arxiv.org/abs/2004.05009

Minimum latency training
Delay constrained training

Codecov Report

Merging #148 into master will decrease coverage by 0.16%.
The diff coverage is 27.20%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   39.31%   39.14%   -0.17%
==========================================
  Files          84       85       +1
  Lines       10086    10147      +61
  Branches     2114     2130      +16
==========================================
+ Hits         3965     3972       +7
- Misses       5921     5977      +56
+ Partials      200      198       -2

Impacted Files
Coverage Δ

neural_sp/bin/args_asr.py
0.00% <0.00%> (ø)

neural_sp/bin/asr/train.py
0.00% <ø> (ø)

neural_sp/datasets/alignment.py
0.00% <0.00%> (ø)

neural_sp/datasets/asr.py
0.00% <0.00%> (ø)

neural_sp/models/modules/attention.py
94.11% <0.00%> (ø)

neural_sp/models/modules/gmm_attention.py
96.15% <ø> (ø)

neural_sp/models/modules/multihead_attention.py
96.20% <ø> (ø)

neural_sp/models/seq2seq/decoders/build.py
0.00% <ø> (ø)

neural_sp/models/seq2seq/speech2text.py
0.00% <0.00%> (ø)

neural_sp/models/seq2seq/decoders/las.py
51.91% <44.18%> (+0.84%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826f049...83a25f5. Read the comment docs.


Calendar customisation

How can we switch between day/week/month in run time?  I checked the switcherView but I want to switch the modes upon custom events other than switcherView. Is this possible? Probably I will create my own switcherview and need to send the action to the calendar to switch the modes.

How can we add an event to the calendar. Customise the month/week/day cells with custom events? Is this feature available?

I didn't understand what exactly did you mean?
Yes, it's will available in future updates


common: introduce RemoveEmptyLines()

Couple of places uses the same functionality which removes empty lines from
a multiline string. This patch introduces RemoveEmptyLines() function to
achive this functionality in one place and get rid from code duplication.
Not sure that common/common.go is the best place for this although.

ok to test

force pushed

Thanks, LGTM


Add one example of T265 FE and Pose streams

This example is to demo T265 FE Left/Right streams and pose stream.

@freemanlo , thanks for the contribution.
Please update the examples list for the PR - https://github.com/IntelRealSense/librealsense/tree/master/wrappers/python/examples#list-of-examples

@freemanlo, you should make it clear in a comment that using the syncronous pipeline API will limit your pose frequency from 200Hz to 30Hz.


[Bug] ccandlestickLayout.ts display error.

Version
laster version
Link to Minimal Reproduction
No response
Steps to Reproduce
example:
https://echarts.apache.org/examples/zh/editor.html?c=candlestick-large
Current Behavior
browser this example and wheel mouse:
https://echarts.apache.org/examples/zh/editor.html?c=candlestick-large
some candlestick display is shift.
Expected Behavior
display is middle.
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
candlestickLayout.ts
subPixelOptimize cause display shift.
        function addBodyEnd(ends: number[][], point: number[], start: number) {
          ....
            point1[cDimIdx] = subPixelOptimize(
                point1[cDimIdx] + candleWidth / 2, 1, false
            );
            point2[cDimIdx] = subPixelOptimize(
                point2[cDimIdx] - candleWidth / 2, 1, true
            );

....
}
---> modify code as:
point1[cDimIdx] = subPixelOptimize(
point1[cDimIdx] , 1, false
) +  candleWidth / 2 ;
point2[cDimIdx] = subPixelOptimize(
point2[cDimIdx] , 1, true
) -  candleWidth / 2 ;
This code is work.

Not sure how to reproduce the problem. The link doesn't seem to match your screenshot.

Hi, how can we give the width of the candle dynamically based on the zoom?


Update Linux section Proton compatibility part

Proton-7.2-GE-2 was also reported to work by two players.
https://discord.com/channels/920776187884732556/972909610140839956/994824247123902518

Superseded by #308


Fix decimal value argument in GraphQL

I want to merge this change because resolve #3428

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] Database migration files are up to date.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] GraphQL schema and type definitions are up to date.
[x] Changes are mentioned in the changelog.

We could also add a test for both cases:

passing decimal directly to query
passing it through variables


Topic 1: Team view
Some questions that came up around Teams during our kick off call:

How might we use login to separate public and authenticated content?
How can non-admins contribute team content?
How do core assets interact with team assets? (Is core Carbon a default and I’m adding the other things… or do the other things live separately)

Morgana is specifically interested in creating/curating a team, selecting assets and any type of content, contribution model and how might a team admin approve/review new content contributed by team members.
Topic 2: IA issues
Morgana has some research-backed concerns (that Tracey and I share) about the current platfrom IA. Her team just conducted a thorough research with Cloud PAL users (dev and designers) about the current PAL experience. Jumping between asset usage documentations quickly (be it to answer question, understand differences between similar assets, or discovery) is a must, (Shaun Lynch brought this up in our user testing as well). The current Carbon next experience doesn’t support that type of usage as well as what we have today.
Deliverables
These are subject to change/refinement:

[ ] High level, very low fidelity wires of UXA flows
[ ] Supporting written proposal
[ ] Knowledge transfer — identify another Cloud PAL team member to support this work after Morgana's transition

(Comment is WIP)
Topic 2: IA Issue
The problem

Topic 1: Teams
🗓 Update Friday September 08 2022
📹 Playback recording

User flow
An IBM creator is able to find the guidelinesn and tools they are required to use in order to create the user experience for IBM clients.
An IBM creator is able to confidently find and join the correct system to do their work
An IBM creator is able to know what has changed, added or removed from the systems they joined so that they are sure to use the latest best practices  and assets in their user experiences

Admin flow
An IBM local system admin is able to curate, ensure quality, and freshnesss of their content so that their users always have the latest content available to do their work
An IBM local system admin is able to  review, accept, reject and request changes to updates proposed by the community so that the local system is always evolving


luci-mod-system: add support for additional filesystem

The filesystem option doesn't include additional filesystem included with /etc/filesystems, this is usefull if someone have ntfs-3g installed and wants to force use the external utility to mount partition instead of the default present in the kernel (if it's supported)
@jow-
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

@jow- done

@jow- can this be merged?

Please indent using tabs, then it should be fine

@jow- sorry for the mess now should be good

Yep, thanks :)


ci: allowlist dependabot[bot] for CLA and COC

Similar to https://github.com/splunk/addonfactory-ucc-generator/blob/137d9734649111068e13a2eafbb0a164d287af8a/.github/workflows/agreements.yaml

:tada: This PR is included in version 1.91.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Consider dropping Data.Has

I keep running into issues arising from Has, and especially its interplay with the concrete HasFoo class idiom. Today this culminated in encountering a runtime loop on code that shouldn't even typecheck (trivial reproduction here). This has thoroughly convinced me that @snoyberg chose the more stable path with RIO, and I've now fallen back to exclusively using HasFoo (with the exception of one instance Has ModHttpClient AppEnv since that's required to use the API).

HTTPClient does not import Data.Has and uses HasHttpManager in MonadHTTP, so you can use Network.HTTP.Client.TLS.newTlsManager directly instead of newHttpClient.
I've extracted Has stuff into a separate module.
If all these HasFoo classes already had instances for tuples, I guess we wouldn't actually need Has…

If all these HasFoo classes already had instances for tuples

Good point. And generating those is arguably within the scope of RIO #113. I'll try to take another whack at that soon.


the register does not create any Username but login ask for Username

🐞 Bug Report
Describe the bug
if no user name is created then how will some one use while login
Steps to Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '...'
Scroll down to '...'
See error

Expected behavior
should allow creating username
Actual behavior

Screenshots or Video

Environment
Please provide the following details:

OS: Windows
Browser/Software: microsoft edge
Version: e.g., 22.0

Logs & Error Messages

just few line of changes do it  annd it will be good if you can addd some animation or other things


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   83.33%   83.33%
=======================================
  Files           1        1
  Lines           6        6
=======================================
  Hits            5        5
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e7dc...107311c. Read the comment docs.

Coverage remained the same at 83.333% when pulling 107311c2973b63929a23008b6cdb4d5d75b88c47 on template-sync-1 into 3e0e7dced9059afd88602a12745589bc212a557c on master.

:tada: This PR is included in version 1.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: