Improve discoverability of the Python Test Log output channel

Issue Type: Bug
If you have a syntax error in your tests, the Testing panel does not tell you, it just has the unhelpful message "Test discovery failed". Running pytest --collect-only in the terminal gave me the error message I needed to fix things.
VS Code version: Code 1.66.0 (e18005f0f1b33c29e81d732535d8c0e47cafb0b5, 2022-03-30T05:50:14.623Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Remote OS version: Linux x64 4.18.0-348.12.2.el8_5.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.90GB (4.63GB free)

Process Argv
--crash-reporter-id 41701ddd-325b-4adf-9898-82e11f28942a

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: pc-dev03

OS
Linux x64 4.18.0-348.12.2.el8_5.x86_64

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4200)

Memory (System)
62.84GB (22.90GB free)

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

jupyter-keymap
ms-
1.0.0

remote-ssh
ms-
0.78.0

remote-ssh-edit
ms-
0.80.0

gitlens
eam
12.0.5

vscode-edit-csv
jan
0.6.8

vsc-python-indent
Kev
1.15.0

restructuredtext
lex
184.0.0

python
ms-
2022.4.1

vscode-pylance
ms-
2022.4.0

jupyter
ms-
2022.3.1000901801

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

vscode-yaml
red
1.6.0

shellcheck
tim
0.19.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30466689
pynewfile477:30463512

Hi @jontwo,
By testing panel do you mean the Python Test Log output panel?

I mean Testing panel as in the panel that appears in the left sidebar when you click on the conical flask icon.

Or it's below Extensions on the View menu. The Python Test Log does show the syntax error, but I had no idea it existed. Perhaps it could be easier to find?

There's only limited text real estate in the testing panel, since it's meant to show you your test tree, and quick actions for each test node. The Python Test Log would be your best bet to see the details of your test run, which is also mentioned in the docs.
We could probably improve the discoverability of that output channel, an option could be to automatically open it when running tests. Updating this issue to be a feature request instead.
We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there are enough upvotes then we will consider this feature request in our future planning. If there are unfortunately not enough upvotes then we will close this issue.

Thank you for submitting your feature request and everyone who considered it! Unfortunately this issue did not receive enough votes over the allotted time, and so we are closing the issue.


small debug string creation fix

Discovered in the course of diagnosing issues with the OneTouch driver errors (not) surfacing.
Borked the commit message, should say: properly provide debug info for jellyfish messages with only a reason instead of a message.
Ping @jh-bate for a quick review.

LGTM - thanks for the comments


chore(Accordion): add example of expanded exclusive accordion

An accordion that has only one panel open at any time.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


How to close ion-select automatically?

My ionic version is..
Cordova CLI: 7.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 7
Node Version: v6.10.0
Xcode version: Not installed
I am using Ion-select for loading some data,by default its taking Alert controller.
Can any one tell me how to close Ion-select like radio list automatically.

Please fill the issue template
This is a support request. You will find more help in the forum

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


module not found: Can't resolve 'crypto'

Describe the bug
use bearer plugin causes an error module not found: Can't resolve 'crypto'
To Reproduce
Steps to reproduce the behavior:
Using the bearer plugin causes an error
import { betterAuth } from 'better-auth'
import { drizzleAdapter } from 'better-auth/adapters/drizzle'
import { bearer } from 'better-auth/plugins'

import { db } from '@acme/db/client' // your drizzle instance

import { env } from '../env'

export const auth = betterAuth({
  database: drizzleAdapter(db, {
    provider: 'sqlite',
  }),
  socialProviders: {
    github: {
      clientId: env.GITHUB_CLIENT_ID,
      clientSecret: env.GITHUB_CLIENT_SECRET,
    },
  },
  plugins: [bearer()],
})

Expected behavior
no error
Screenshots

Did you mean './crypto'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules, /home/goodcheng/.volta/tools/shared, /home/goodcheng/Development/SelfCode/collectionbox/apps/web).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
../../packages/auth/src/auth.ts
../../packages/auth/src/index.ts
./src/app/api/auth/[...all]/route.ts
../../node_modules/next/dist/build/webpack/loaders/next-edge-app-route-loader/index.js?absolutePagePath=%2Fhome%2Fgoodcheng%2FDevelopment%2FSelfCode%2Fcollectionbox%2Fapps%2Fweb%2Fsrc%2Fapp%2Fapi%2Fauth%2F%5B...all%5D%2Froute.ts&page=%2Fapi%2Fauth%2F%5B...all%5D%2Froute&appDirLoader=bmV4dC1hcHAtbG9hZGVyP25hbWU9YXBwJTJGYXBpJTJGYXV0aCUyRiU1Qi4uLmFsbCU1RCUyRnJvdXRlJnBhZ2U9JTJGYXBpJTJGYXV0aCUyRiU1Qi4uLmFsbCU1RCUyRnJvdXRlJmFwcFBhdGhzPSZwYWdlUGF0aD1wcml2YXRlLW5leHQtYXBwLWRpciUyRmFwaSUyRmF1dGglMkYlNUIuLi5hbGwlNUQlMkZyb3V0ZS50cyZhcHBEaXI9JTJGaG9tZSUyRmdvb2RjaGVuZyUyRkRldmVsb3BtZW50JTJGU2VsZkNvZGUlMkZjb2xsZWN0aW9uYm94JTJGYXBwcyUyRndlYiUyRnNyYyUyRmFwcCZwYWdlRXh0ZW5zaW9ucz10c3gmcGFnZUV4dGVuc2lvbnM9dHMmcGFnZUV4dGVuc2lvbnM9anN4JnBhZ2VFeHRlbnNpb25zPWpzJnJvb3REaXI9JTJGaG9tZSUyRmdvb2RjaGVuZyUyRkRldmVsb3BtZW50JTJGU2VsZkNvZGUlMkZjb2xsZWN0aW9uYm94JTJGYXBwcyUyRndlYiZpc0Rldj10cnVlJnRzY29uZmlnUGF0aD10c2NvbmZpZy5qc29uJmJhc2VQYXRoPSZhc3NldFByZWZpeD0mbmV4dENvbmZpZ091dHB1dD0mcHJlZmVycmVkUmVnaW9uPSZtaWRkbGV3YXJlQ29uZmlnPWUzMCUzRCE%3D&nextConfigOutput=&preferredRegion=&middlewareConfig=e30%3D!

Desktop (please complete the following information):
"better-auth": "0.5.3-beta.1"
Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

You need to remove the export runtime = "edge"  from your API auth route [...all]/route.ts cause better Auth is not yet supported on the edge
That is why you are getting the crypto is not found on the edge cause edge doesn't support crypto or fs
So remove the export runtime = "edge"  from the API route

I use cloudflare d1 database and I want to deploy it to the cloudflare, if I remove the export const runtime = "edge", it will not work.

maybe can use the web api like the next-auth https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API

using cloudflare worker deploy can solve this problem, but it builds large 1MB files, not good for free plan

this should be resolved by #456


Add support for WINSOCK

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (b458b9e) 96.25% compared to head (ad5f8dc) 96.25%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   96.25%   96.25%
=======================================
  Files          24       24
  Lines         507      508    +1
=======================================
+ Hits          488      489    +1
  Misses         19       19

Files Changed
Coverage Δ

src/client/client.cc
100.00% <ø> (ø)

src/net/endpoint.h
100.00% <ø> (ø)

src/net/socket.h
100.00% <ø> (ø)

src/net/socket_unix.cc
81.15% <ø> (ø)

src/http/response_parser.cc
96.55% <100.00%> (+0.04%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


VM Service getIsolate() does not return when using --pause_isolates_on_start with macro experiment

I'm using SDK version as of 0da8f7a7b48 and the observable_main example from https://github.com/dart-lang/language/tree/main/working/macros/example (at https://github.com/dart-lang/language/commit/b1e958447c811df00e521dfcf47d71005674cb06).
I modified the script to run in a loop:
Future<void> main() async {
  while (true) {
    var jack = ObservableUser(age: 10, name: 'jack');
    jack.age = 12;
    jack.name = 'john';
    await Future.delayed(const Duration(seconds: 10));
  }
}

If I run the application with:
C:\Dev\Tools\Dart\Nightly\bin\dart.exe --enable-experiment=macros --observe=0 .\bin\observable_main.dart

Everything works fine. I can click the DevTools link, open DevTools, and see the isolates:

However, if I add the --pause_isolates_on_start flag then DevTools no longer starts up, it just shows a spinner:

Terminating the app shows that getIsolate() was pending when the app shut down:

Trying to use the VS Code debugger shows the same thing - during startup the debug adapter calls getIsolates() and that request never appears to complete (although as far as I can tell, there is no error or crash, it just never returns).
dart info output:
General info

Dart 3.4.0-edge.0da8f7a7b480210811514b33067a90485135f580 (main) (Thu Jan 25 11:07:28 2024 +0000) on "windows_x64"
on windows / "Windows 10 Pro" 10.0 (Build 22621)
locale is en-GB

Project info

sdk constraint: '>=3.3.0-0 <4.0.0'
dependencies:
dev_dependencies: _fe_analyzer_shared, args, benchmark_harness, checks, dart_style, frontend_server, test

cc @bkonyi is this something you could help looking into?

Sure, I'll take a look.

Looking at Observatory, it looks like we're spawning two isolates:

One for dart-kernel-blob://blob1
One for bin/observable_main.dart

I'm guessing the isolate for bin/observable_main.dart relies on some result from dart-kernel-blob://blob1 before it can actually start running. Where is dart-kernel-blob://blob1 started? It probably should be marked as a system isolate so it can't be paused on start or exit.

dart-kernel-blob://blob1 is likely an isolate for running a macro. It probably runs before main is compiled.

dart-kernel-blob://blob1 is likely an isolate for running a macro. It probably runs before main is compiled.

Yeah, the main isolate is blocked on a compilation request. Where is the macro isolate being spawned? The CFE? If so, we should consider making isolates spawned from system isolates inherit the system isolate property.

@bkonyi This isolate is created here:
https://github.com/dart-lang/sdk/blob/43fb59f4dc1991863982d5805d2551ed9fb3a28d/pkg/_fe_analyzer_shared/lib/src/macros/executor/isolated_executor.dart#L51
This code is called from CFE (kernel isolate in case of standalone VM).
Do we have a Dart API to mark isolate as "system"?  If not, maybe inheriting "system" property makes sense when an isolate is spawned.

Updating this line to api_flags.is_system_isolate = parent_isolate_->is_system_isolate() resolves the issue:
https://github.com/dart-lang/sdk/blob/43fb59f4dc1991863982d5805d2551ed9fb3a28d/runtime/lib/isolate.cc#L598
However, there may be situations in dartdev (which runs in a system isolate) where we don't want this property to be inherited. @a-siva is working on changes to make dartdev an AOT snapshot, which currently involves starting isolates using spawnUri from the dartdev isolate. Inheriting the system isolate property is probably fine for most cases where we do this (e.g., starting dart2js or the analysis server), but we wouldn't want to mark an isolate running user code as a system isolate (e.g., dart run foo.aot).

Do we need to add an API to specify that it is a system isolate then?

Note also that we eventually want to allow debugging of macros at compile time, which sounds like it would interact with this in interesting ways.

Yes, this is exactly why I brought it up. It is possible we need another category of isolate for these? With its own flag for whether they start paused or not?

Do we need to add an API to specify that it is a system isolate then?

We might. It's something I had decided against doing when I added system isolates since there's not many reasons for the average developer to mark an isolate as a system isolate.

Note also that we eventually want to allow debugging of macros at compile time, which sounds like it would interact with this in interesting ways.

This could be problematic. If we don't mark these isolates as system isolates, we'll end up pausing execution each time we execute a macro. If a user is using lots of macros, this will make the debugging experience really annoying. At the very least, we'd need to provide a way to differentiate between isolates running macro code and regular isolates so we can provide options to not pause macro isolates on start.
Also, there's talks on the VM team about potentially moving the CFE out of the VM into a separate process, which would also have an impact on debuggability of macro generation.
I think that, at least for now, we should not support debugging macro generation and just mark these isolates as system isolates with the fix I proposed above to unblock regular debugging workflows. This is something we'll need to figure out before we ship macros to general users, but is probably isn't critical for shipping JsonSerializable.

I think that, at least for now, we should not support debugging macro generation and just mark these isolates as system isolates with the fix I proposed above to unblock regular debugging workflows

I think this is fine for now for sure, as long as we aren't painting ourselves into a corner that we can't get back out of later on 👍

@jakemac53 we have a plan of pulling the kernel isolate out of the VM and running a frontend server for compilation. This model of running macro generation using isolates and debugging it along with the user code may not work in that scenario. Do you think this will be an issue ?

I do think that the ability to debug macros running inside the compiler itself would be a very useful and appreciated feature for macro authors. But, I wouldn't want to compromise the experience for all developers in the name of that either.
Another possible option here, is we could require some special setup in order for it to work? Maybe you can't debug macros when running through dart run, but you can through dart compile, etc.

Another possible option here, is we could require some special setup in order for it to work? Maybe you can't debug macros when running through dart run, but you can through dart compile, etc.

We would have to account for the flutter developer scenario too, in that case the front end is already out of process and we probably have to wire up a way for debugging macros in that process.

So unfortunately I don't think we'll just be able to inherit the system isolate property when spawning isolates since there's situations where system isolates expect their children to not be system isolates (see this example added in this CL). This behavior is used by the google3 test configuration rules to hide the main isolate which isn't running user code.
We're going to need to figure out another solution to avoid these having this macro compilation isolates constantly blocking execution of the user program when --pause-isolates-on-start or --pause-isolates-on-exit are provided, but maybe it's sufficient to work around this in DevTools for now so it's at least usable. Until then, you'll have to use Observatory to resume at least the initial macro isolate so the main isolate can become runnable.

Until then, you'll have to use Observatory to resume at least the initial macro isolate so the main isolate can become runnable.

Note that there can be any number of these isolates so you probably would want to generally handle resuming anything that looks like a macro isolate.

Until then, you'll have to use Observatory to resume at least the initial macro isolate so the main isolate can become runnable.

Note that there can be any number of these isolates so you probably would want to generally handle resuming anything that looks like a macro isolate.

Sure, and this should be possible. I think that the DevTools bug that's preventing anything from even loading is only visible if the main isolate is blocked on macro compilation requests. Assuming the main isolate is able to start executing, I think DevTools should work for resuming  any subsequent macro compilation isolates. If hundreds of macro compilation isolates are running before the main isolate is able to start executing, this is going to be painful regardless of which tool you're using.

FWIW, I only used DevTools here as an example for simplicity.. the place I really hit this was VS Code - we fetch all isolates as part of connecting the debugger (so if you press F5 to try and run any app with macros, it just hangs launching).
I can manually resume things for now to allow me to do some more testing/dev on the debugger, but we'll need a better fix before we expect others might be trying to run code using Macros through VS Code.

If hundreds of macro compilation isolates ...

I hope not 🤣 (actually, I think the CFE does do a pretty good job of grouping macros into a small # of isolates, as long as they don't depend on each other).

If hundreds of macro compilation isolates ...

I hope not 🤣 (actually, I think the CFE does do a pretty good job of grouping macros into a small # of isolates, as long as they don't depend on each other).

I'd really hope not too! 🤣

Another possible option here, is we could require some special setup in order for it to work? Maybe you can't debug macros when running through dart run, but you can through dart compile, etc.

I was thinking the same thing. I think it's safe to assume most users won't be writing their own macros, so I don't think there's much benefit in supporting debugging macro code generation for general programs. Ideally macro authors would debug their macros in an environment with relatively simple, self-contained code samples. Otherwise, we'd have to provide a way to only debug macro code generation for macros specified by the developer to avoid noise from processing unrelated macros.
Anyway, back to the actual issue. We're going to want to figure out this issue sooner than later since it's going to block debugging workflows in any standalone Dart project using the JIT (I don't think this is going to impact Flutter or the standalone Dart AOT runtime since we won't be spawning macro compilation isolates in-process). This may not be a problem in the long run if we end up moving the kernel service out of process for the JIT VM, but I assume that won't happen until after macros have already shipped.
Some options I can think of off the top of my head:

We inherit the system isolate flag when spawning isolates from a system isolate, but check for the --mark-main-isolate-as-system-isolate flag and add a special case when spawning isolates from the main isolate so that the system isolate property is not inherited.
We only inherit the system isolate flag for isolates spawned from the kernel isolate.
We provide a way to specify whether or not an isolate spawned from dart:isolate should be a system isolate. I'd like to avoid exposing this concept of system isolates to the average developer unless we absolutely have to.
We provide pauseIsolateOnStart, pauseIsolateOnExit, and pauseIsolateOnUnhandledException through the dart:isolate APIs that allow for overriding the global VM settings for pause behavior for the spawned isolate. This might actually be a nice API to have in general if users are only interested in pausing individual isolates on start / exit / unhandled exception.

The first two options are kind of hacky but are simple, won't require any API changes, and can easily be reverted when we get a better idea about what the macro code generation debugging story is going to look like. The last option may be a generally useful feature, but will take some time to properly implement, so I'm thinking we should move forward with one of the hackier approaches. Any thoughts?

(I don't think this is going to impact Flutter or the standalone Dart AOT runtime since we won't be spawning macro compilation isolates in-process)

Just to confirm, this is because it does compilation outside of the flutter tool itself? So, presumably when debugging a flutter app some flag is passed to the VM at some point, but that VM was actually spawned with precompiled kernel code, so no macros are running?

(I don't think this is going to impact Flutter or the standalone Dart AOT runtime since we won't be spawning macro compilation isolates in-process)

Just to confirm, this is because it does compilation outside of the flutter tool itself? So, presumably when debugging a flutter app some flag is passed to the VM at some point, but that VM was actually spawned with precompiled kernel code, so no macros are running?

Yes, because compilation won't be happening directly within the running Flutter app. This means that the --pause-isolates-on-start and related flags won't result in the macro isolates being paused on start, blocking execution in the main process.


Dataset tutorial improvements

[x] 6_PWA_nonlinear_capex: unit cost gets higher for larger capacities - doesn't make sense

updated in https://zen-garden.readthedocs.io/en/latest/files/input_handling.html#piece-wise-affine-input-data, check if that works in the code as well

Changed data in dataset examples and adjusted how the nonlinear_capex.csv file should be set up.


Docker install dependencies issue with glibc in Centos 7.3

The issue seems to be strange when the server is updated to latest centos version
Below is the error:

sh -c 'sleep 3; yum -y -q install docker-engine'
Error: Package: glibc-2.17-106.el7_2.4.i686
Requires: glibc-common = 2.17-106.el7_2.4
Installed: glibc-common-2.17-157.el7_3.1.x86_64
glibc-common = 2.17-157.el7_3.1
Available: glibc-common-2.17-105.el7.x86_64
glibc-common = 2.17-105.el7
Available: glibc-common-2.17-106.el7_2.1.x86_64
glibc-common = 2.17-106.el7_2.1
Available: glibc-common-2.17-106.el7_2.4.x86_64
glibc-common = 2.17-106.el7_2.4
Error: Package: policycoreutils-python-2.2.5-20.el7.x86_64
Requires: policycoreutils = 2.2.5-20.el7
Installed: policycoreutils-2.5-9.el7.x86_64
policycoreutils = 2.5-9.el7
Available: policycoreutils-2.2.5-20.el7.x86_64
policycoreutils = 2.2.5-20.el7
You could try using --skip-broken to work around the problem
You could try running: rpm -Va --nofiles --nodigest

glibc package exist on the server is shown below:
glibc-2.17-157.el7_3.1.x86_64
glibc-common-2.17-157.el7_3.1.x86_64
Please suggest on fixing the issue.
Thanks

I'm not able to reproduce this; I tried installing docker on a 7.2 host, then updating (yum update) to 7.3. Also tried creating a new 7.2 host, then updating (yum update) and then installing docker, both worked for me.
Could it be that the update from 7.2 to 7.3 was interrupted (outstanding transactions)? Did you reboot the host after upgrading?
During the update process, I see that both glibc and glibc-common are updated;
  Updating   : glibc-common-2.17-157.el7_3.1.x86_64                                                                                8/349
  Updating   : glibc-2.17-157.el7_3.1.x86_64                                                                                9/349

@runcom @andrewhsu any other suggestions?

Just to check; which repository are you installing from? What does; cat /etc/yum.repos.d/docker* show? And yum list docker-engine ?

Find the repo details below and yum list
[dockerrepo]
name=Docker Repository
baseurl=https://yum.dockerproject.org/repo/main/centos/$releasever/
enabled=1
gpgcheck=1
gpgkey=https://yum.dockerproject.org/gpg
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
Available Packages
docker-engine.x86_64                                                           1.12.6-1.el7.centos                                                            dockerrepo
Kernel version is : 3.10.0-514.2.2.el7.x86_64
There is no interruption or outstanding transaction and rebooted the host after upgrade as well.

does yum update glibc update the package? Or is something blocking it from being updated?

No, There is no package available for update or there is no blocker or outstanding transaction in yum.
Loading mirror speeds from cached hostfile
No packages marked for update

I have the exact same problem when trying to install gcc :

glibc 2.17-106 is required
glibc 2.17-157 is installed
The reason is:
the version 2.17-157 was installed by then "FROM centos:7" of the Dockerfile that as Centos version 7 points to version 7.3.1611 (that is correct)
the version 2.17-106 is the version available on a local mirror at my company that has a deprecated version (http:///centos/7.2.1511/updates/x86_64/Packages/)
I warned my administrator that the local mirrors are not beeing updated.
Conclusion: one of your yum repository is probably not pointing to the Centos version 7.3.1611 as it should be.

I mean: http:///mycompany/7.2.1511/updates/x86_64/Packages/
(text has been modified after post)

I agree with @jlerny, and highly suspect this is something in your setup. Since we're not able to reproduce, I'm going ahead and close this issue, but feel free to continue the conversation.


[DEV] Allow developers to have a local/modify opensearch.yml or ENV

Is your feature request related to a problem? Please describe.
I was trying to figure out how to expose <IP_ADDRESS> from my EC2 test instance on which I do development. What worked was to run ./gradlew -Dtests.opensearch.http.host=<IP_ADDRESS> run.
Describe the solution you'd like
I'd like to be able to do any (combination) of these:
a) modify distribution/src/config/opensearch.yml or another yml and have it get picked up by ./gradlew run
b) use an equivalent of dotenv to permanently override settings, e.g. OPENSEARCH_HTTP_HOST=<IP_ADDRESS> ./gradlew run which would allow one to create .env and run dotenv ./gradlew run
c) some other set it and forget it mechanism
Describe alternatives you've considered
Run ./gradlew assemble to build the ZIP for the distribution. Extract the zip and edit config/opensearch.yml. But this is more time consuming.
Additional context

Hey @sejli
I would like to give this issue a shot, please could you assign this to me?

Hello @dblock,
I'm seeking further context to effectively address the issue at hand.
File Reference:
I'm currently working within the file:
buildSrc/src/main/java/org/opensearch/gradle/testclusters/RunTask.java

Within this file, I encountered the map additionalSettings which appears to capture all properties prefixed with "tests.opensearch.*" from System.getProperties(). Could you clarify where System.getProperties() is referencing?
YML Configuration:
Do I need to ensure compatibility for the key-value pair: http.host: <IP_ADDRESS> within the YML?
If I create something like
ymlSettings.forEach(node::setting);

within the RunTask.java file, will it automatically bind the aforementioned key-value pair?
Clarification:
For point (b) above, is the expected command to be:
OPENSEARCH_HTTP_HOST=<IP_ADDRESS> ./gradlew run

Additional context on this would be greatly appreciated.
Thank you for your guidance.
Warm regards,
Kohinoor Chatterjee

Could you clarify where System.getProperties() is referencing?
will it automatically bind the aforementioned key-value pair?

I don't know the answer to these two. Try it out!

For point (b) above, is the expected command to be ...

Yes, that's the same as mentioned in b), or am I not seeing a difference?
Stepping back, the goal is that I can override and save settings somewhere and get them picked up by ./gradlew run, other than having to specify -Dtests.....

Thanks for the response @dblock
My approach to implement the above requirement:

Ingest flags from .env file which would contain flags like:

OPENSEARCH_HTTP_HOST=<IP_ADDRESS>
SOME_OTHER_FLAG=VALUE

Create a way to pass the flags to gradle

I would appreciate your insights on this approach. Additionally, if you have any alternative solutions or recommendations, I would be keen to consider them.
Thank you for your guidance.

For 1 if you supported getting those from the environment, then you could use an existing tool like dotenv which is the standard in many languages. So no need to explicitly read a file.
For 2 I don't have any better ideas than (1)!


Compilation creates lots of warnings

So, compiling a project seems to generate lots and lots of hxcpp warnings.. any idea whats going on here?
Even so, the project complies and runs ok - but it would definitly be nice to remove or at least supress these?
(I've attached a file with the warnings)
warnings.txt

Yes, this is normal, you can see my comments about it here: https://github.com/RobertBorghese/Haxe-UnrealEngine5/issues/3#issuecomment-1264933322
As mentioned there, unfortunately all of the warnings come from hxcpp, a required library for compiling Haxe/C++ output, but one that does not have many errors enabled in its compilation environment.
It’s possible to suppress these errors, but it’d be kind of a hassle, so haven’t gotten around to it yet. Afaik, Unreal doesn’t provide any system for suppressing any warnings/errors, just a select handful of ones. So the only solution is to clutter up the output files with tons of C++ suppress macro things.
As this project is still in early development, they’ll be left on for testing purposes for the time being, but open to changing this in future.

Ah, yes. Sorry, i didnt see your earlier comment about this. Will leave this issue open still for now, in case others have the same question!


about setBotUpdatesStatus

document says Informs the server about the number of pending bot updates if they haven't been processed for a long time
What does it do? Can I receive Updates again the next time TDLib start?

No, it just informs the server. It has no other effect.


Date validation

Hi there
Tanks for amazing library
Is there any way to check date is valid or not?

Hi,
thank you
[https://github.com/fingerpich/jalali-moment/issues/25](the same issue has added before)


CeTZ v0.2.0 not found on OS X but available on Windows

Description
When opening the web app with an OS X device, the CeTZ package doesn't recognise the version 0.2.0, although when opening the exact same project on a Windows device, the package loads perfectly, with no issues at all. This is pretty bad when working on a project from two different places.

Reproduction URL
https://typst.app/project/pJ2SGRvgn2XXZ76Q8WCuXJ
Operating system
Web app, Windows, macOS
Typst version

[X] I am using the latest version of Typst

I think this might be better suited to https://github.com/typst/webapp-issues .
With that said, I wonder if this is a caching issue... Could you try reloading with Shift + F5?


Why not just use Tracker?

It seems to me like wrapping a reactive variable in a Tracker.autorun accomplishes the exact same thing as an event emitter but with more declarative syntax as opposed to imperative syntax... Just curious when you'd want to use an event emitter as opposed to a reactive variable?

Tracker is for tracking variables, eventemitter is emitting event specific data.
Question is: why not use obsevable streams?
I dont think theres yet "one ring to rule em all"

observable streams?!

https://www.youtube.com/watch?v=XRYN2xt11Ek

Whoa! That is a very good point! Observables looks awesome!
The question for me now is where does this fit in to meteor? I could see this being a very useful way of dealing with events. Something like this:
streams = (events) ->
  for e in events
    t = Template.instance()
    t[e] = (elem) ->
      @elem = t.find(elem)
      Rx.Observable.fromEvent(@elem, e)

Template.main.created = ->
  streams('mousedown', 'mouseup', 'mousemove')

Template.main.rendered = ->
  t = @
  t.mousedown('.image')
    .map((down) -> t.mousemove.takeUntil(t.mouseUp))
    .concatAll()
    .forEach((pos) -> @elem.position = pos)

It would be really cool if meteor had something like Template.eventStreams for all this stuff. I'm still not entirely sure how all this works though. Do you have to manually turn every event into a stream or does it automatically do that for you? For example, he just calls elmt.mouseDowns and document.mouseMoves without defining those streams....
I'm trying to think of when or where you'd use this for a collection. The Mongo cursor with reactive session variables seems to take care of search pretty easily, but then again, I think observable streams would be better if helpers can accept them because you don't have to wire in event listeners and session variables.
The meteor way:
Session.set('search', '')

Template.main.events
  'keyup input':(e,t) -> Session.set('search', e.target.value)

Template.main.helpers
  results: -> Items.find({name:Session.get('search')})

The observable way:
Template.main.helpers
  results: ->
    t = Template.instance()
    t.keyPresses.throttle(250)
      .map((key) -> Items.find({name:t.find('input')))
      .concatAll()

This is pretty messy and probably incorrect, but I think theres something to this... Thanks for sharing that video. Very cool stuff.

+1 on the video, well worth the watch.
I'm also quite new to these concepts here, but isn't the combination of Tracker, reactive vars, and pub/sub (?) implementing an observer pattern? The upcoming changes to Blaze formalises instance reactive variables to manage state outside of the Session object, and template level subscriptions, so it seems that creating a reactive var for keyPresses in Template.main.created with jQuery selectors updating it would achieve what you have outlined in 'The observable way' right?
https://medium.com/@stubailo/upcoming-features-in-meteor-blaze-b537cf9c09e9

Thanks for the article. I like those updates, but I'm ready for those already and more!
It is my understanding that you're entirely right -- Tracker and Observable Streams are the exact same underlying concept implemented slightly differently. Tracker maintains a graph of function dependency relationships using autorun while observable streams manage these dependencies by treating reactive variables as async-arrays.
Tracker is amazing and transparent. But I think there are certain things that observables seem to do better. Making a dom element draggable or typeahead are perfect examples. A common pattern in meteor is to have a helper that depends on a reactive variable and an event to update that variable. I think this pattern can be consolidated into a single helper with an observable stream.
For a simple template, the reactive variable pattern is simple and awesome. But given a complicated template, we can offload the internal state into a very functional observable stream pattern.

Just to ensure we are comparing with the upcoming version of Blaze, you will be able to access the local template state directly in the template without the need for a helper
Template.calendar.onCreated(function () {
    // Declare some temporary state
    this.vars.setDefault("selectedDay", new Date());
    this.vars.setDefault("viewStyle", “month”);
});
// No need to define helpers, just use
// {{Template.vars.selectedDay}}

I'm probably not seeing this properly, but where would you map an interaction event to a stream if it's not the responsibility out of the template events map?

Check out this nightmare for an example of how big a hassle it is to manage event state for swiping.
The typeahead is an interesting scenario as well. The current way of doing it is like this:
Session.set('search', '')

Template.main.events
  'keyup input':(e,t) -> Session.set('search', e.target.value)

Template.main.helpers
  results: -> Items.find({name:Session.get('search')})

With Template.vars we can eliminate the first line, but its the same idea. We have a helper and an event.
The observable way looks something like this:
Template.main.helpers
  results: ->
    input = t.find('input')
    input.keyPresses.throttle(250)
      .map((key) -> Items.find({name:input.value).fetch())
      .concatAll()

Now that doesnt look like a big difference, but the tiny amounts of state you need to keep track of can pile up as you can see in my "nightmare" link. Suppose you have a more complicated template with many helpers and many events and many Template.vars. If you see a helper that depends on some Template.var, its a pain to look around at which events alter that Template.var. In the observable example, everything is right there and you don't have to go searching for all the pieces.
My point here is just that there are certain things that would be much easier with observables as opposed to Template.vars and vice-versa. These are just two examples where I think observable streams are better.

@raix thanks for showing me that video!
https://github.com/ccorcos/meteor-tracker-streams

@ccorcos no problem, nice work :)

Thanks @ccorcos. Your package will be a big help in understanding the difference now.

@rhyslbw I hope you like it :)


Update cyberghost to <IP_ADDRESS>

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as f42bfe24fe86f06c3467f82af454702d8f275fbd. Your contribution is still credited to you.


Add --ignore-certificate-errors to default chromeFlags

While trying to run against servers with self signed certificates I noticed that the lighthouse didn't return any values. Adding --ignore-certificate-errors to the default chrome flags worked for me.

I've just run into this problem myself while running Lighthouse against our app running on a local environment. I'm going to work on this and raise a PR.

Merged this going out in next release.

I actually looked into this in the afternoon and evening and don't have a working solution.
The --ignore-certificate-errors flag that you added will not fix this problem as it doesn't alter the way Devtool Protocol clients, like Lighthouse, see the security state of the website.
I believe it can be done low level by setting Security.setOverrideCertificateErrors({ override: true }); but only from within the Lighthouse client, not as a Chrome flag. That's my understanding.
See https://github.com/GoogleChrome/lighthouse/issues/7292 and https://github.com/GoogleChrome/lighthouse/issues/6655 for more detail.

Ok thanks for looking into it.

I raised a PR in the main repository for being able to pass in an additional start script that can import certificates into the container's certificate store as a workaround here.

Cool I guess this is fixed then.


add coherent error api

fixes https://github.com/edgedb/edgedb-go/issues/24

all errors returned from edgedb unwrap to edgedb.Error
all error messages returned from edgedb start with edgedb:
the only errors from other libraries that are wrapped are errors from the stdlib net package.
errors from the edgedb server can be unwrapped using errors.As(). Any error type in the returned error's hierarchy will match.
error values like edgedb.ErrZeroResults can be checked with errors.Is() or simple equality.

Why do you add edgedb: to error messages?

go does not keep stack trace info for errors and it doesn't print the error's type.  The only thing you get when an error is printed is the string returned from Error(). It is customary to prefix error messages with more context as they are passed up the stack.

I'm in doubt of whether having special-case singleton errors is a good thing. Or is it better to use As for all errors. Because remembering which one is which is tiring.

The convention is to suffix type names with Error and prefix value names with Err. This makes it easy to know how to use the name. I'm comfortable removing most of the constants in favor of flexibility in the future. The only one that I think makes the API more ergonomic is ErrZeroResults which will be used very frequently.
err := pool.QueryOne(ctx, query, &result)
if err == edgedb.ErrZeroResults {
    // handle no result
}

If a type were used for the zero results case this common scenario becomes more verbose.
err := pool.QueryOne(ctx, query, &result)
var zeroResults &edgedb.ZeroResultsError
if errors.As(err, &zeroResults) {
    // handle no result
}

pgx has a similar no results singleton.

The only one that I think makes the API more ergonomic is ErrZeroResults which will be used very frequently.

Yes. This one sounds good to me.

I think all newError invocations except for creating constants, should return more specific error.

I was not sure where I should use types from errors.txt and where I should use more generic errors. edgedb-python uses RuntimeError and ValueError in several places where these types are more appropriate than the types from errors.txt. Since I always wanted edgedb.Error in the returned error's unwrap chain I just used that directly.
Using AuthenticationError seems reasonable. I'll change that and have a look at the other places edgedb.Error is returned to see if I can come up with more specific errors. Part of the ambiguity for me is that the only documentation I could find for error type meanings is their name.

I would expect all of the errors to be derived from edgedb.Error. For python and JS we're probably have exception for thinks that are kinda "assertion failures" or python language errors. I.e. where arguments types are wrong, we don't want to wrap TypeError. Other are probably mistakes. I.e. currently we raise protocol errors as RuntimeError which is obviously a mistake.
But I would say base error should never be used. There is always something better. For IO errors it should be some subclass of ClientError. There is also kinda generic InterfaceError which captures any interface misuses (like commiting non-started transaction or similar). And so on.  @1st1, what do you think?
If you can't name some specific error type, maybe we need to create one.

It looks like I should either return errors from the context package directly or wrap them. Previously I was returning a new error instead of wrapping. I'm not sure what edgedb error type would be used to wrap context.Context errors. Should I make singleton values in the edgedb client that wrap each of these? This doesn't seem obviously useful to me. Why would edgedb.ErrContextCanceled be better than context.Canceled for instance?
I think I'm leaning towards returning the plane error from the context package instead of wrapping it.
err := pool.QueryOne(ctx, query, &result)
if err == context.Canceled {
    // do something special if another part of your app canceled the context early
}

Although it might be better to wrap it with an opaque type to force callers to use errors.Is(). This would allow wrapping these errors in the future with a new type without breaking the API.
err := pool.QueryOne(ctx, query, &result)
if errors.Is(err, context.Canceled) {
    // ....
}

Why do you add edgedb: to error messages?

go does not keep stack trace info for errors and it doesn't print the error's type. The only thing you get when an error is printed is the string returned from Error(). It is customary to prefix error messages with more context as they are passed up the stack.

I'd then prefix it with the entire type + the name of the error, as in
edgedb.UnknownLinkError: lorem ipsum ...

But I would say base error should never be used. There is always something better. For IO errors it should be some subclass of ClientError. There is also kinda generic InterfaceError which captures any interface misuses (like commiting non-started transaction or similar). And so on. @1st1, what do you think?

Yeah, I agree. In general we should prefer returning our error types, unless there are commonly known and checked standard Go errors in some particular cases (like timeout, maybe?)

The convention is to suffix type names with Error and prefix value names with Err. This makes it easy to know how to use the name. I'm comfortable removing most of the constants in favor of flexibility in the future. The only one that I think makes the API more ergonomic is ErrZeroResults which will be used very frequently.

So can we use if errors.Is(err, edgedb.ZeroResultsError) in this case?

It looks like I should either return errors from the context package directly or wrap them. Previously I was returning a new error instead of wrapping. I'm not sure what edgedb error type would be used to wrap context.Context errors. Should I make singleton values in the edgedb client that wrap each of these? This doesn't seem obviously useful to me. Why would edgedb.ErrContextCanceled be better than context.Canceled for instance?
Although it might be better to wrap it with an opaque type to force callers to use errors.Is(). This would allow wrapping these errors in the future with a new type without breaking the API.

Ilike the idea of wrapping and using errors.Is

Why do you add edgedb: to error messages?

go does not keep stack trace info for errors and it doesn't print the error's type. The only thing you get when an error is printed is the string returned from Error(). It is customary to prefix error messages with more context as they are passed up the stack.

I'd then prefix it with the entire type + the name of the error, as in
edgedb.UnknownLinkError: lorem ipsum ...

But I would say base error should never be used. There is always something better. For IO errors it should be some subclass of ClientError. There is also kinda generic InterfaceError which captures any interface misuses (like commiting non-started transaction or similar). And so on. @1st1, what do you think?

Yeah, I agree. In general we should prefer returning our error types, unless there are commonly known and checked standard Go errors in some particular cases (like timeout, maybe?)

The convention is to suffix type names with Error and prefix value names with Err. This makes it easy to know how to use the name. I'm comfortable removing most of the constants in favor of flexibility in the future. The only one that I think makes the API more ergonomic is ErrZeroResults which will be used very frequently.

So can we use if errors.Is(err, edgedb.ZeroResultsError) in this case?

It looks like I should either return errors from the context package directly or wrap them. Previously I was returning a new error instead of wrapping. I'm not sure what edgedb error type would be used to wrap context.Context errors. Should I make singleton values in the edgedb client that wrap each of these? This doesn't seem obviously useful to me. Why would edgedb.ErrContextCanceled be better than context.Canceled for instance?
Although it might be better to wrap it with an opaque type to force callers to use errors.Is(). This would allow wrapping these errors in the future with a new type without breaking the API.

Ilike the idea of wrapping and using errors.Is

Also, how other Golang DB clients approach errors?

Also, how other Golang DB clients approach errors?

Also, how other Golang DB clients approach errors API design?

It is common to return an unexported type that only has an Error() method and doesn't wrap anything for "you're doing wrong" errors. Things like you passed the wrong number of arguments for this query. These types of errors indicate broken code.
It is also normal to use exported error values to indicate simple errors that are commonly handled programmatically.
When there is a lot of detailed information associated with an error it might have a lot of fields or methods. example
It is very abnormal to use errors.As() the way that isinstance() is used in python. The original inspiration for the new error functions in go 1.13 came from go's most popular error library which called the Unwrap() method Cause(). The way that I have used the error hierarchy in errors.txt is to wrap each of the error codes ancestors in the returned error value so that you can use errors.As() sort of like isinstance() in python. I'm not sure this behavior is intuitive in go. I haven't seen this hierarchical model anywhere else.

Also, how other Golang DB clients approach errors API design?

It is common to return an unexported type that only has an Error() method and doesn't wrap anything for "you're doing wrong" errors. Things like you passed the wrong number of arguments for this query. These types of errors indicate broken code.
It is also normal to use exported error values to indicate simple errors that are commonly handled programmatically.
When there is a lot of detailed information associated with an error it might have a lot of fields or methods. example
It is very abnormal to use errors.As() the way that isinstance() is used in python. The original inspiration for the new error functions in go 1.13 came from go's most popular error library which called the Unwrap() method Cause(). The way that I have used the error hierarchy in errors.txt is to wrap each of the error codes ancestors in the returned error value so that you can use errors.As() sort of like isinstance() in python. I'm not sure this behavior is intuitive in go. I haven't seen this hierarchical model anywhere else.

So can we use if errors.Is(err, edgedb.ZeroResultsError) in this case?

I'm not sure what you're asking here. There is no edgedb.ZeroResultsError type. If this was a typo and you meant errors.Is(err, edgedb.ErrZeroResults) then yes.

So can we use if errors.Is(err, edgedb.ZeroResultsError) in this case?

I'm not sure what you're asking here. There is no edgedb.ZeroResultsError type. If this was a typo and you meant errors.Is(err, edgedb.ErrZeroResults) then yes.

It is very abnormal to use errors.As() the way that isinstance() is used in python. <...>

What about errors.Is?

It is very abnormal to use errors.As() the way that isinstance() is used in python. <...>

What about errors.Is?

@1st1 and I talked more about how this should work. We decided that:

instead of representing the error tree with concrete types it should be be represented with interfaces this makes it so that the returned error is not required to be a chain of errors.
I'm going to remove all sentinel error values for now. ErrNoData can be added in the future if it becomes a felt need.
in the future adding Get(string) interface{} method to errors in the future could solve for arbitrary user defined error sub-classes.
in the future adding a more concise API than errors.As() that doesn't require creating a new variable might be interesting. We'll wait to see if there is a felt need.

@1st1 and I talked more about how this should work. We decided that:

instead of representing the error tree with concrete types it should be be represented with interfaces this makes it so that the returned error is not required to be a chain of errors.
I'm going to remove all sentinel error values for now. ErrNoData can be added in the future if it becomes a felt need.
in the future adding Get(string) interface{} method to errors in the future could solve for arbitrary user defined error sub-classes.
in the future adding a more concise API than errors.As() that doesn't require creating a new variable might be interesting. We'll wait to see if there is a felt need.

I'd then prefix it with the entire type + the name of the error

I added this :heavy_check_mark:

I'd then prefix it with the entire type + the name of the error

I added this :heavy_check_mark:

I'm pretty sure that simple 1-1 chaining of errors should be sufficient (like cause/context in Python).

Are there any examples where simple chaining isn't enough?
Also I'd squash everything into one commit before merging.

I'm pretty sure that simple 1-1 chaining of errors should be sufficient (like cause/context in Python).

Are there any examples where simple chaining isn't enough?
Also I'd squash everything into one commit before merging.

I'm pretty sure that simple 1-1 chaining of errors should be sufficient (like cause/context in Python).

Error chaining in go only allows adding to the head of the chain. you can't add anything to the tail and the chain can't fork. See (2) here https://github.com/edgedb/edgedb-go/pull/51#discussion_r553625348

I'm pretty sure that simple 1-1 chaining of errors should be sufficient (like cause/context in Python).

Error chaining in go only allows adding to the head of the chain. you can't add anything to the tail and the chain can't fork. See (2) here https://github.com/edgedb/edgedb-go/pull/51#discussion_r553625348

Error chaining in go only allows adding to the head of the chain. you can't add anything to the tail and the chain can't fork. See (2) here #51 (comment)

Sure. That's all we need. If the server sends you a QueryError, and while processing it you need to generate SomethingError, just wrap the former error object into the latter error object.

Error chaining in go only allows adding to the head of the chain. you can't add anything to the tail and the chain can't fork. See (2) here #51 (comment)

Sure. That's all we need. If the server sends you a QueryError, and while processing it you need to generate SomethingError, just wrap the former error object into the latter error object.

Frederick, should we merge this?

Frederick, should we merge this?

I think so.

I think so.


Optimize bundle size

Tabster keeps growing with new features. It is time to spend some time going through the code and seeing if something can be optimized in the bundle size regard.

Probably won't help the bundle size since it's tree-shaken but perhaps this is a good time to move the shadow DOM implementation to @fluentui-contrib/pierce-dom?

Yeah, need to find a moment for that too.


Dolphin models doesn't run

import lmql
import torch

@lmql.query(
    model=lmql.model(
        "local:cognitivecomputations/dolphin-2.6-mixtral-8x7b",
        trust_remote_code=True,
        device_map=0,
        do_sample=True,
        temperature=1e-3,
        torch_dtype=torch.bfloat16,
        load_in_8bit=True
    )
)
def prompt():
    '''lmql
    argmax
        "What is the capital of France? [RESPONSE]"
    where
        len(TOKENS(RESPONSE)) < 20
    '''

if __name__ == '__main__':
    print(prompt())

This returns:

while the NousResearch/Nous-Hermes-2-Yi-34B returns the following error:

My setup is:

on H100

This sounds like a CUDA issue. Can you verify that generation works with standard transformers?

Closing this due to inactivity. Please feel free to follow up, if the issue persists.


[Event Request] Report 699 "Calculate Plan - Req. Wksh." - Event Extensions for OnItemOnAfterGetRecordOnBeforeCommitand OnBeforeCheckVendorBlocked #15999

Please add var to Item for getting the filters of Item.
report 699 "Calculate Plan - Req. Wksh."
{
[..]
    [IntegrationEvent(false, false)]
    //*********************************************************************************************
    //-local procedure OnItemOnAfterGetRecordOnBeforeCommit(var ReqLine: Record "Requisition Line"; Item: Record Item; CurrTemplateName: Code[10]; CurrWorksheetName: Code[10]; FromDate: Date)
    local procedure OnItemOnAfterGetRecordOnBeforeCommit(var ReqLine: Record "Requisition Line"; var Item: Record Item; CurrTemplateName: Code[10]; CurrWorksheetName: Code[10]; FromDate: Date)
    //*********************************************************************************************
    begin
    end;
[..]
}

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


As a user I would like Ability to deploy workloads outside of the local kubernetes cluster to use cloud native runtime for my services.

Our use case is to use KLT to deploy services/containers into cloud native runtimes like GCP cloud run or AWS lambda or other infrastructure items that live outside of k8s including database migrations, infrastructure configuration (IAC/terraform), etc.
This is currently theoretically possible with KeptnV1 as the Job Executor Service can execute anything for the deployment.
Also with KeptnV1 we can define an arbitrary sequence of events for a service deployment which could include running terraform, database migrations, deployments, tests, etc.

Hey @scheuk, thanks for the suggestion. In our backlog, we have #614 to provide the capabilities of the Job Executor Service directly in KLT.
For your second point, we want to support users only when manifests hit the Kubernetes cluster, i.e., we can help you with db migration before the deployments, deployments, tests etc.
I can recommend the use of Tekton or Argo to orchestrate workflows that do some work, i.e., terraform, before your manifests hit your cluster.

Yeah that makes sense.
I see that the workflow/shipyard component is gone with KLT and a generic workflow engine would work.
However it would be nice to use the SLI/SLO checking and test execution workflows in KLT against service deployments that are external to the cluster. Ie serverless/cloudrun deployments.

Keptn V1 is still available

Hey @scheuk :)
With the Container Runtime support, you can now do the same things you could do with JES: https://lifecycle.keptn.sh/docs/migrate/strategy/#integrations-and-services-in-jes
I am closing the issue but feel free to re-open it if you have further feedback/questions :)


bug: strange codes when using emoji

Did you check docs and existing issues?

[X] I have read all the vscode-neovim docs
[X] I have searched the existing issues of vscode-neovim
[X] I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable)

Neovim version (nvim -v)
0.9.4
Operating system/version
macOS 14
Describe the bug
https://github.com/vscode-neovim/vscode-neovim/assets/28700378/dc36f133-0f3c-4617-a641-84e52c68f106
Steps To Reproduce
Paste the following into a markdown file, and press o at the first line.
 🏁                🏃🏾♀                                    🏃🏿♀
 🏁                🏃🏽♀                            🏃🏿♂
 🏁                🏃🏼♂                                                         🏃🏾♂
 🏁                🏃🏻♀              🏃🏽♂
 🏁                🏃🏽♂                     🏃🏻♂

Expected Behavior
No strange code.

Upstream issue: https://github.com/neovim/neovim/issues/7151.


Modernize qlpacks

Description
This PR updates the qlpacks and related files to use CodeQL packaging to declare and resolve dependencies. Neither the codeql_modules submodule nor the codeql_home/codeql-stdlib checkout of github/codeql are required anymore. The necessary dependencies can be installed by running python3 scripts/install-packs.py. This need only be run when we update to a new standard library version, but it doesn't hurt to run it after every pull.
None of the codeql commands we run should require --search-path or --additional-packs any longer. References within our repo are resolved automatically because all of our packs are in the same "CodeQL Workspace" (defined by our .codeqlmanifest.json file. References to the standard library are resolved from the package download cache.
Details:

Adds codeql/ scope to all pack names, which is necessary to publish packs to the pack registry. Note that we don't actually publish to the package registry yet.
Uses dependencies: map instead of libraryPathDependencies: list. The '*' version indicates that any version will do, which is correct for the referenced packs that are found in the local workspace, rather than downloaded from the registry.
Folds the .codeqlmanifest.json in the cpp directory into the root .codeqlmanifest.json. All pack references should resolve automatically now, without a need for --search-path. Moreover, the manifest indicates which packs are local to the workspace and do not need to be downloaded from the registry.
Adds .codeql directories to .gitignore. .codeql is where the output of building a query or library pack is placed.
Removes --search-path and --additional-packs from all of our CI workflows.
Adds a new composite Action to install the standard library dependencies.
Adds a new workflow to validate that the actual standard library dependencies specified in the various qlpack.yml files match the versions in the github/codeql commit specified in supported_codeql_configs.json. The script used by this workflow will also be used, in a future PR, in the workflow to update to a new toolset version.
Updates the developer handbook with the necessary information.

Change request type

[x] Release or process automation (GitHub workflows, internal scripts)
[x] Internal documentation
[ ] External documentation
[ ] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[x] No rules added
[ ] Queries have been added for the following rules:

rule number here

[ ] Queries have been modified for the following rules:

rule number here

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[x] Yes
[ ] No

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[x] Have all the relevant rule package description files been checked in?
[x] Have you verified that the metadata properties of each new query is set appropriately?
[x] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[x] Are the alert messages properly formatted and consistent with the style guide?
[x] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[x] Does the query have an appropriate level of in-query comments/documentation?
[x] Have you considered/identified possible edge cases?
[x] Does the query not reinvent features in the standard library?
[x] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Release test ✅ after removing the codeql-workspace.yml file and defaultSuiteFile property https://github.com/github/codeql-coding-standards-release-engineering/actions/runs/4124784509

Sweet @mbaluda -- so this requires no changes to the release process then? Just as a note, we should not merge this until #171 is merged to make sure you are compatible with the latest matrix testing work.

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

/test-performance

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

/test-performance

/test-performance

/test-performance

/test-performance

/test-performance

/test-performance

/test-performance

/test-performance

/test-performance

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

/test-performance

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

/test-performance

/test-performance

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

/test-performance

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

/test-performance

🏁 Beep Boop! ** Performance testing complete! See below for performance of the last 3 runs vs your PR.

 Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo.


error

cve-2023-20198.py -m exploit -s https -t [REDACTED]
/cve-2023-20198-main/cve-2023-20198.py:91: SyntaxWarning: "is" with a literal. Did you mean "=="?
if args.mode is "check":
/cve-2023-20198-main/cve-2023-20198.py:98: SyntaxWarning: "is" with a literal. Did you mean "=="?
if args.mode is "exploit":
Traceback (most recent call last):
File "/cve-2023-20198-main/cve-2023-20198.py", line 84, in
args.print_help()
AttributeError: 'Namespace' object has no attribute 'print_help'

Thx for the testing. Pls, see the last push - the issue is solved.
Additionally, an IP/file logic flaw was found and is corrected.


yapb-4.5.1121 - Crash

The server ran for three days without crashing, but on the fourth day, I was asked to add some bots. As soon as I added the first one, the server crashed. Can anyone tell me why this happened? Can I fix this issue myself, or should I rather use the stable version?
Thank you for your help; I’m very grateful for the work you do.
Crash LOG:
https://fileport.io/4XduLvUnczHQ

Revert to previous version please. Binaries are available here: https://github.com/yapb/yapb/actions/runs/11542608527

jeefo Сегодня обновил 4.5.1121 на 4.5.1126 и сервер начал падать каждые 5-10 минут. Откатил обратно на 4.5.1121.

@snaike00 посмотри пожалуйста: https://share.s3.rwsh.ru/2024/yapb.so

должно быть прфикшено в последнем билде: https://github.com/yapb/yapb/releases/tag/continuous


Enforce Newline Between Method/Function Declarations

Expected Rule behavior

Ensure newline between function declarations (with closing braces '}')
Example
When a class defines two or more methods/functions there is currently no rule enforcing a newline to exist between them. For example this is currently valid:
class Thing {
    fun doStuff() {
        // Do
    }
    fun doMoreStuff() {
        // Do
    }
    fun doYetAgainMoreStuff() {
        // Do
    }
}

Note: the lack of spaces between method definitions.
This does not collide with IntelliJ default code formatting either. In fact, when running "Reformat Code" in IntelliJ (without custom rules), it auto-adds the newlines like so:
class Thing {
    fun doStuff() {
        // Do
    }

    fun doMoreStuff() {
        // Do
    }

    fun doYetAgainMoreStuff() {
        // Do
    }
}

Additional information

I cannot seem to find a "best practice" anywhere in regards to Android or Kotlin formatting. In some examples containing multiple function definitions there seems to be a newline separating function definitions. Not the best example, but one nonetheless: https://kotlinlang.org/docs/coding-conventions.html#names-for-test-methods

Please let me know if I am missing anything on this post - it's my first to this repo!
I also tried to do a search for something similar before posting, let me know if I might have missed something!

In latest, 0.50.0 release a new experimental rule was introduced to enforce this. See https://pinterest.github.io/ktlint/0.50.0/rules/experimental/#blank-line-before-declarations.
It is indeed not explicitly documented in the style guides but it is widely adopted practice.

Ah this is awesome! I am so sorry I missed it, I looked everywhere for key words like "function definition" "closed braces" etc. etc. and couldn't find anything!
This is great, I enabled this rule and it enforced exactly what I am requesting. Going to close this issue!


Happymh嗨皮 problem

https://github.com/keiyoushi/extensions-source/issues/121#issue-2075128512 "Idiot bot closed my issue, but it should not have closed it's special one."

The bot may be dumb, but it was correct in closing your previous issue. We cannot help if Cloudflare passes in WebView, but does not pass in extension, that is still a Cloudflare issue.
Do not try to circumvent the bot by creating an issue not following any of the listed templates.


Option for justified text

First, thanks for your work. Would it be possible to add the option to make the text justified? it would also be interesting to be able to change the font and background for better reading.

There have been added already!


added sch.uk

Please only add sch.uk not every university in the pull request - we have to check the committed files before merging


update nuclear migration during mating to "congression"

abnormal nuclear migration during mating (FYPO:0003062)
update nuclear migration during mating to "congression"
to make it clearer from the term name

Changed primary name, added existing as exact synonym


Run Test button doesn't work.

Challenge Create a Set of Radio Buttons has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
</form>

<input type="radio" name="indoor-outdoor">Indoor

This was reported earlier and others are discussing possible workarounds until it get fixed down in this ticket:
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/10678

@kilmet please confirm - are you still experiencing this issue?

This issue has now been fixed. If you notice this problem again, please reopen it with an explanation of the problem. Thanks for reporting this.


Pdf feature test

Codecov Report
Base: 56.75% // Head: 60.69% // Increases project coverage by +3.94% :tada:

Coverage data is based on head (e534d05) compared to base (14734ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
+ Coverage     56.75%   60.69%   +3.94%
- Complexity      574      599      +25
============================================
  Files           110      110
  Lines          2333     2333
  Branches        270      270
============================================
+ Hits           1324     1416      +92
+ Misses          924      833      -91
+ Partials         85       84       -1

Impacted Files
Coverage Δ

src/main/java/seedu/waddle/logic/PdfFiller.java
71.23% <ø> (+71.23%)
:arrow_up:

...n/java/seedu/waddle/model/itinerary/Itinerary.java
61.04% <0.00%> (+2.32%)
:arrow_up:

...ain/java/seedu/waddle/storage/JsonAdaptedItem.java
56.81% <0.00%> (+6.81%)
:arrow_up:

...ava/seedu/waddle/storage/JsonAdaptedItinerary.java
91.02% <0.00%> (+10.25%)
:arrow_up:

...ava/seedu/waddle/logic/commands/SelectCommand.java
90.00% <0.00%> (+90.00%)
:arrow_up:

src/main/java/seedu/waddle/logic/PdfFieldInfo.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[JENKINS-59402] JobDsl should respect Job post-construction initialization

(copy from https://github.com/jenkinsci/job-dsl-plugin/pull/1203, but with a proper branch name)
Hello!
This is a fix for issue https://issues.jenkins-ci.org/browse/JENKINS-59402
Problem:
If we run the creation of job via jobDsl pipeline step (https://jenkins.io/doc/pipeline/steps/job-dsl/) with any parameters, we are getting a folder on our filesystem without "legacyIds" file in builds directory.
examples are in the bottom of this post.
The problem is that if there is no legacyIds file in builds directory, after restarting of jenkins server, we are facing long migrations for all jobs created after the previous reboot
If you have spawned hundreds of jobs between reboots, the migration process could take hours of downtime
Examples:
job created via jobDsl:
[root@server]# ls -lah builds/jobDsl_job
total 2.5K
drwxr-xr-x 1 centos centos 808K Sep 12 07:23 .
drwxr-xr-x 1 centos centos 3.1G Sep 12 07:21 ..
drwxr-xr-x 1 centos centos 808K Sep 12 07:23 1
lrwxrwxrwx 1 centos centos    2 Sep 12 07:19 lastFailedBuild -> -1
lrwxrwxrwx 1 centos centos    1 Sep 12 07:23 lastStableBuild -> 1
lrwxrwxrwx 1 centos centos    1 Sep 12 07:23 lastSuccessfulBuild -> 1
lrwxrwxrwx 1 centos centos    2 Sep 12 07:19 lastUnstableBuild -> -1
lrwxrwxrwx 1 centos centos    2 Sep 12 07:19 lastUnsuccessfulBuild -> -1

job created via manual creation:
[root@server]# ls -lah builds/manual_job
total 0
drwxr-xr-x 1 centos centos    0 Sep 12 07:21 .
drwxr-xr-x 1 centos centos 3.1G Sep 12 07:21 ..
-rw-r--r-- 1 centos centos    0 Sep 12 07:21 legacyIds

This should probably fixed in Jenkins core, see my comment on the JIRA issue:
https://issues.jenkins-ci.org/browse/JENKINS-59402

Closing, as this should be fixed in Jenkins core per https://github.com/jenkinsci/job-dsl-plugin/pull/1204#issuecomment-595834343.


Appstudio update test-component-pac-alhh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-alhh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
37 seconds
sast-snyk-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
10 seconds
inspect-image

✅ Succeeded
11 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
29 seconds
sbom-json-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
11 seconds
show-summary

Pipelines as Code CI/test-component-pac-alhh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
37 seconds
sast-snyk-check

✅ Succeeded
11 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
29 seconds
sbom-json-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
10 seconds
inspect-image

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
11 seconds
show-summary

Pipelines as Code CI/test-component-pac-alhh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
14 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
9 seconds
inspect-image

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
48 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


[WIP] Use predicate to filter reconciles

Don't enqueue a reconcile if the ResourceVersion hasn't changed
Remove lock and resourceVersion cache that was attempting to dedupe
the hard way
Reduce watch scope from cluster to namespace for Deployments and
RootSync Secrets
Add RootSync watch for managed ClusterRoleBindings (shared), to
ensure that changes to the crb are reverted without needing to update
another watched object.
Add RootSync ownership for managed ServiceAccounts, to ensure that
changes to the sa are reverted without needing to update another
watched object.

/test all

LGTM but someone else should take a look

/hold
It occurs to me that this might not do what I expected.
The reason I initially added the dedupping was because the Reconcile was causing RSync status updates to happen using the same initial generation. They weren't always duplicate updates, because some other robject might have changed, but the GET at the beginning of the Reconcile was returning an RSync with a generation we'd already seen. My assumption was that this was due to the reconciler-manager using the controller-manager's caching client. Apparently the caching client doesn't invalidate the cache on writes, only on watch updates. So if another watched object (like the Deployment) triggered a reconcile, the client cache might still give you the same RSync it had cached, not the new one from the previous reconcile.
But the predicate in this PR doesn't check the RSync in the cache. It only checks that the object that triggered the watch event has changed (old RV != new RV). This may not actually do what the existing deduping code was doing, because the existing code was always deduping the RSync, not the watched object that triggered the reconcile.
So we probably do want this predicate added, but we probably don't want to remove the other dedupping code.
So I'm gonna put this on hold for now. I'll probably need to add tests to confirm it actually does what I expected.

Obsolete


No Docker image for <IP_ADDRESS>

Latest tag in https://hub.docker.com/r/kafkamanager/kafka-manager/tags is <IP_ADDRESS>
<IP_ADDRESS> release is not pushed to Docker Hub

@lazystone, you can create your own image as well,
Example: https://github.com/116davinder/kafka-cluster-ansible/blob/master/docker/cmak/Dockerfile
Note:*
all values can be overridden by environment variables.

This one is maintained and provides the latest version
https://hub.docker.com/r/hlebalbau/kafka-manager

I use this one https://hub.docker.com/r/iunera/cmak

I use this one https://hub.docker.com/r/iunera/cmak

Thanks to all for published links but purpose of it to have official image updated.

Thanks to all for published links but purpose of it to have official image updated.

@mcjyang , is there any chance that you can push the latest images to docker hub?
I would love to have it there


Add a certificate rotation command

Add a certificate rotation command
This builds on top of https://github.com/kinvolk/lokomotive/pull/1201.
It checks off the todo items and moves it into a separate command as well as add support for certificate rotation of etcd on all platforms.
Currently it will not rotate the private keys as that will cause some issues with the trust chain. It also doesn't properly set CA lengths which will allow for better rotation of the leaf certificates.
TODO

[ ] Add documentation on how to use it and how to check your certificates
[ ] Add documentation on disaster recovery of all expired certificates(other PR?)
[ ] Think about tests

How to use

Install a cluster and set certs_validity_period_hours = 1
Test if everything works
Set certs_validity_period_hours = <something bigger>
Run lokoctl cluster certificate rotate
Check the ca inside the cluster and kubectl for validity
Let it run for an hour, if everything still works it means all certs are rotated

Testing done

Tested on bare metal VMs
TODO: AWS
TODO: Equinix Metal
TODO: Tinkerbell

I addressed all comments apart from a few that have to do with commits, will do those once I have e2e added to finalise the PR.
Further reviews welcome!

Something that is not yet clear to me (maybe it is because I haven't finished reviewing) but won't components using service accounts need to be restarted too? What happens to the running components if we rotate the cluster CA? Do they fail immediately? Also, not sure what happens with components using service accounts in other rotation cases (like not CAs, etc.)

Since service account tokens are volatile I do not think this is an issue in most cases as they apps that use them should be designed to pick up changes. To be sure i did an experiment with cert-manager and rotated the CA (validity 1hour to 1000hours) then watched it's behavior. It had some watchers close due to the api server going down but as it is designed to do it picks them up again and after the 1 hour passed the controller still works. The Kubernetes controller runtime has picked up the new CA certificate.

It seems we do need the join in the end?


[Script]: Amazon Product Scrapper

Aim
Using Beautiful soup library ,Scrape the details of product page of amazon productts
Details
Return the details of the product.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@avinashkranjan please assign me the issue


STYLE: Remove obsolete FixedArray::operator[] workaround for Visual C++

FixedArray::operator[] had many redundant extra overloads that
appeared necessary for an old version of Visual C++. This workaround was
already in the original commit by Brad King (@bradking), 19 January 2001,
"Initial checkin of new array class.", SHA-1: 486c7d0a0484db67a24f4c0253f7d0ce5feaad11

Please rebase to re-trigger the CI.


suggestion: allow a purely functional solution

Challenge Stand in Line has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
// Pure approach
// const nextInLine = (arr, item) => arr.concat(item).shift()

// Non-pure approach (mutates arr)
function nextInLine(arr, item) {
  // Your code here
  arr.push(item);

  return arr.shift();
}

// Test Setup
var testArr = [1,2,3,4,5];

// Display Code
console.log("Before: " + JSON.stringify(testArr));
console.log(nextInLine(testArr, 6)); // Modify this line to test
console.log("After: " + JSON.stringify(testArr));

The problem:
This test assertion is expecting our method to mutate the original data set, something that is a terrible habit to teach newcomers about.
After nextInLine(testArr, 10), testArr[4] should be 10
My pure function that simple get's the next in line does it's job as a pure function. TL;DR don't write a function that mutates data passed in. This is a dangerous habit for new programmers to think is okay and normal.

Tbh it is imperative they new-comers do learn that arrays have a tendency to be muted by what should be pure functions.
Making immutable functions with arrays is of course a good thing, but cutting out the exercises show-casing Array mutability will set people up for failure.

good point


Use block instead of delegate for showCurrentLocation.

Closing old issues, since they might not be relevant.


Add DBSRESTFormatter

This is going to fail our checks because we now make every new file contain (at the beginning)
from __future__ import (division, print_function)

even though this module will probably never print or divide anything. :-)

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/596/ for details

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/597/ for details

Summary of pylint changes for pull request 6261:
src/python/WMCore/WebTools/DBSRESTFormatter.py fails the pylint check. Report follows:

Line 13 in DBSRESTFormatter E0602 Undefined variable 'self'
Line 13 in DBSRESTFormatter E0602 Undefined variable 'config'
Line 14 in DBSRESTFormatter.init W0231 init method from base class 'RESTFormatter' is not called
plus 8 comments on code style

Imports for Python3 compatability missing in new files. Please fix this:

New file src/python/WMCore/WebTools/DBSRESTFormatter.py does not use python 3 print function. Please add from __future__ import print_function.

New file src/python/WMCore/WebTools/DBSRESTFormatter.py does not use python 3 division. Please add from __future__ import division.

No changes to unit tests for pull request 6261

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/600/ for details

@yuyiguo, Hi Yuyi, you said this is needed urgently, right? Could you update your patch with what Eric pointed out

move  following line inside the init.

RESTFormatter.__init__(self, config)

add future import at the very top of the module. ( This should be imported first than any other import)

from __future__ import (division, print_function)

Then, I will create the new tag with this.
Thanks

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/607/ for details

Indentation is correct. I though it was wrong at the beginning too. That was because the display. If you click on  view code https://github.com/yuyiguo/WMCore/blob/master/src/python/WMCore/WebTools/DBSRESTFormatter.py
It is correctly indented.

Very odd. Are you sure that line 15 is not spaced with two tabs instead of 8 spaces? That could do this to diff. And spacing with tabs is evil. :-)

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/608/ for details

No pylint warnings for pull request 6261:

No changes to unit tests for pull request 6261

No pylint warnings for pull request 6261:

No changes to unit tests for pull request 6261

@ticoann Thanks Seangchan for committing and tagging.
@ericvaandering, You are right, Eric. I like using tab with vi when coding python. This code was copied and edited from the original RESTFormatter.java . So mixed. :-(
The tools used to migrate to python 2.7/3 will fix these tab and space mixing?  If not, we are going to have a lot of manual work to do. python3 does not like to mix tab and space at what level, file level or package level?  I corrected the code with 4 space and pushed it to github,  but github indicated that everything was already updated. So github would not consider this was a change and update the repository?

Doesn't vi have a way to use the tab key but it actually inserts spaces? This is the way I've used every editor for many years.
I assume it will be on the file level that you may not mix.

This is what I used, but still there is mixing the two ...


Your research has made a significant contribution.

Hello author, you designed an efficient hybrid encoder and selected IoU-aware query selection. In which file is the program reflected? Is it based on other similar work? In addition, what do you think are the shortcomings of RT-DETR, and what improvements and innovations can be made based on your work. I look forward to your reply. Your research has made a significant contribution.

https://github.com/lyuwenyu/RT-DETR/blob/main/rtdetr_pytorch/src/zoo/rtdetr/rtdetr_criterion.py


Remove API input in popup

Initially, we had an API input in the popup for the user to add their key. Now that we have the options page that allows the user to save it, we don't need to include it.
What we could have instead, is a link to the options page.
For this issue, remove the input and associated button with the API. Add a link to the options page with the message "If you haven't already, add and save your API key here."

@BekahHW can I be assigned this as well?

@arndom absolutely!


Issue when autoloading env var with equals sign (=) in its value in a virtual env

Type: Bug

Behaviour
Expected vs. Actual
Expected: If I have an environment variable with an equals sign (=) character in its value and a virtual environment is active, I expect its value to not change when loaded by the vscode terminal
Actual: When the .env file is loaded, for each variable that has an equals sign (=) in its value, the value is "cropped" right before the first instance of the equals sign.
For example a connection string variable for azure cosmos would be something like:
COSMOS_NOSQL_URL="AccountEndpoint=https://localhost:8081/;AccountKey=......
After the autoloading, if I run echo $COSMOS_NOSQL_URL the returned value is only AccountEndpoint
Steps to reproduce:

Create a project with a .env file in its root directory with a variable with an equals sign (=) somewhere in its value
Create a virtual environment for the new project and open it on vscode
Make sure the config python.envFile is set to ${workspaceFolder}/.env
Open a new terminar in vscode and run echo $<your variable name> and observe the output

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.12.1
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Pyenv
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

testing
• unittestEnabled: true

Extension version: 2024.2.1
VS Code version: Code 1.87.0 (019f4d1419fbc8219a181fab7892ebccf7ee29a2, 2024-02-27T23:42:16.599Z)
OS version: Linux x64 6.5.0-21-generic
Modes:

Screenshots

Closing as duplicate of https://github.com/microsoft/vscode/issues/197603, we encourage you interact with that issue to raise priority.


pre-load docker images

How would you be able to pre-load with docker images?
I notice that if i included my docker pull commands at the end of common/docker.sh that when the artifacts are finished, the docker images are not on the server. But in the output logs they clearly show them being pulled from the docker repositories.
Where would we be able to place the code to have these images be persistent?
thanks.

@eli007 hi there! Apologies for the delay in getting back to you, and apologies for troubles!
Would you like the Docker images to be added to an EC2 (AMI) image or to a Vagrant box?
I believe, that the reason why the images are not included in the final product, is to do with the clean-up process. The images which are being saved are most likely also being clean-up (an effort to minimise the size of the image).
I will have a look how to ensure that you can persist the images, and I will report back to you.

Hi @eli007s,
I am going to close this issue for now, as it's has been a very long time since it was opened. I hope you've been able to solve all the problems with the Docker images being deleted (should this not be the case, then feel free to re-open this issue again).
All the best,
Krzysztof


Bluetooth Require paired after disconnected work with iphone

I am test the zephyr\samples\bluetooth\peripheral_hids project, we don't need input passkey while paired, so remove the function bt_conn_auth_cb_register(&auth_cb_display). It's work fine with android.
But, the iphone will require paired while reconnecting after disconnected.

Can you provide more information such as the board / platform that this was tested on?

Closed due to inactivity


Generated class diagram

We could add to the README or CONTRIBUTIONS, sometimes it's easier to understand the codebase when you have a diagram.
https://pub.dev/packages/lakos does that well, generating either an HTML, png, etc...
This could be updated via CI when PR gets merged.

Ideally, we'd do that thru CI so we can keep the file up to date every time that main gets merged.


Assign before return statement is not needed

Description
Assign before return statement is not needed
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)

/override "Red Hat Konflux / ols-e2e-tests-rosa / lightspeed-service"
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.02%. Comparing base (f6dcc5d) to head (e682416).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
- Coverage   94.02%   94.02%   -0.01%
==========================================
  Files          58       58
  Lines        2479     2477       -2
==========================================
- Hits         2331     2329       -2
  Misses        148      148

Files
Coverage Δ

ols/src/cache/in_memory_cache.py
97.77% <100.00%> (-0.05%)
:arrow_down:

ols/src/cache/postgres_cache.py
95.12% <100.00%> (-0.06%)
:arrow_down:

/lgtm

/approve


CI: Vagrant: pin rockylinux/8 to v5.0.0

v7.0.0 does not boot. v6.0.0 was not released.

Run sudo add-apt-repository ppa:criu/ppa
Cannot add PPA: 'ppa:~criu/ubuntu/ppa'.
ERROR: '~criu' user or team does not exist.
Error: Process completed with exit code 1.

hmm

Because https://launchpad.net/ is down


In SVG renderer, fill action doesn't end the path properly

In class SVGGraphics, funciton fill calls function endPath at the end.In endPath, it sets current.path to null, but keeps current.element.However, fill only uses current.element to judge whether the path exists and perform the fill action.That means, the next fill action will also be effective,which is not allowed.

Sorry, but the SVG back-end is no longer maintained/supported; please note https://github.com/mozilla/pdf.js/blob/a575aa13b9e4ce7e671be7794e7a7296406a3087/src/display/svg.js#L468-L472


Make Delay_between_shot per weapon not globally

Description
i have a problem i made 2 thing gun and medkit
i put delay_between_shot to medkit 120 ticks
after i shot a gun i cant use medkit because they link delay_between_shot
unlink crackshot after i shot a gun i can use medkit and after 120 ticks i can use medkit again
In CS that is slot based I need to those options work per weapon title instead of globally
Thank you
Configuration
Mechanics:
  Only_player:  true

PLS

So I was already coding this, but realized I should probably make this work a bit differently:

per weapon group
per weapon

Basically allowing all delays to work for specific weapon groups OR only for the weapon being used