Any issues migrating from ASM cluster config to ARM cluster config?

We built many azure SAP clusters based on the ASM/Classic design document a few years ago. We will soon use MS' migration scripts to migrate our ASM systems to ARM. Will the current classic/asm configuration still work after the migration?
The current ASM config uses two additional IPs per cluster: a virtual cluster ip and another ip that matches the ip of the load balancer (and has a probe port of 59999). Not sure if the ARM design above still uses those virtual IPs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d8da06a-43ad-9b28-a88e-a9da515db7d3
Version Independent ID: 2054515f-d7cd-63e2-e6e8-5cbf2e39e0dc
Content: Azure Virtual Machines high availability for SAP NetWeaver | Microsoft Docs
Content Source: articles/virtual-machines/workloads/sap/high-availability-guide.md
Service: virtual-machines-windows
GitHub Login: @goraco
Microsoft Alias: goraco

Thanks for the feedback! We are currently investigating and will update you shortly.

@badbob001 Without knowing your exact environment details it is difficult to say if your exact configuration in ASM will be the same when you migrate to ARM. That being said, the load balancing capabilities of an ARM load balancer have the same attributes you are using now in ASM but with additional features and ease of use.
I would suggest you take a look at the following docs to see if they help answer some of your questions:
ASM to ARM Migration
Azure Load Balancer Overview
In addition, if you prefer to open a support ticket our Support Engineering teams are well versed in assisting customers move from ASM to ARM and would be able to look at the specifics of your environment and confirm which resources will move successfully and which will not.
I will close out this issue however if you feel more assistance or information is needed please let me know and we can reopen it.


Internal argument not respected in filter creation post request

Expected Behaviour
Creating filters using the api and getting a 200 response with the filter ID in the response along with all the other metadata. Added 'internal = false' argument to the api call and expected to see the filter in the UI.
Actual Behaviour
I have not seen the filter showing in the UI after refreshing the UI several times in the last 15 minutes.
Request
{"name":"Another home page segment to try","description":"It's still me trying this as a test with using the API","definition":{"container":{"func":"container","context":"visits","pred":{"func":"container","context":"visits","pred":{"func":"streq","str":"home","val":{"func":"attr","name":"variables/web.webPageDetails.name"}}}},"func":"segment","version":[1,0,0]},"dataId":"dv_605cde46e803452631e98829","internal":false}
Response

Hey @parrish488! thanks for the response.  This was so long ago that I forgot to follow up. Yes, it is in the "show all" section of the Components >> Filters section.


Tomato Shibby VPN Client Setup

I have a router setup with Tomato Shibby and I would like to set it up to be able to connect to my Pivpn as a client. In order to accomplish that I need the following keys:
Certificate Authority
Client Certificate
Client Key
If I edit the ovpn file I can see what I believe maybe those keys but I am not sure, can anyone tell me if those keys are in the file and which ones would tie to the proper keys listed above?
Thank you

Copy the content between<ca></ca> tag to a file named ca.crt
Copy the content between <cert></cert> tag to a file named client.crt
Copy the content between <key></key> tag to a file named client.key
You should also copy the content of <tls-auth></tls-auth> (or <tls-crypt></tls-crypt>) to a file named ta.key
Remove the tags and the content from the original file.

Thank you, got it going with your help. It connects but doesn't seem to route through the VPN. When I query the local pc's ip address using whats my ip it still shows the local ip address not the connected VPN's ip address. Can you give me some guidance?

Post the server log (omit the client ip): cat /var/log/openvpn.log

Username/Password Authentication: Checked or Unchecked (Checked)
Username: xxxxxx
Password: xxxxxxxxxxx
User Authen Only: Checked or Unchecked (Checked)
I'm not sure if usernmane password authentication should be enabled or not (the above) because we don't login with username but only with a certificate and a password (if you generated a certificate with a password). So you should try several combination of those, or create a configuration without password.
Extra HMAC authorization tls-auth (Enabled)
Compression: Disabled, None, Enabled, Adaptive (Enabled)
tls-auth is enabled in the conf, same with compression. However your router doesn't seem to support tls-crypt so if it doesn't connect you could also try uninstalling pivpn and reinstalling without 2.4 features.
We should be able to tell more with the server logs, however you forgot to post them.

Sorry, send wrong file, here is the server log
openvpn.log

As i expected the router doesn’t connect because the pi doesn’t find the hmac header, enable those option and try again:

Extra HMAC authorization tls-auth (Enabled)
Compression: Disabled, None, Enabled, Adaptive (Enabled)

You uploaded the file "Router VPN Client Settings.txt" where you showed me the settings you applied on your router. The above two are the ones you should change (from disabled to enabled).

Extra HMAC authorization (tls-auth) choices are "Bi-directional or Incoming (0) or Outgoing (1)"
Compression choices are "Disabled or None or Enabled or Adaptive"
So I have set Compression to "Enabled"  and tried each of the HMAC authorization settings and results were all the same, connected but still no change in my client ip address.

Here is a copy of the PiVPN log file after I made the changes to the client and used each of the each of the HMAC settings.
openvpn.log

Thats weird, with hmac set to outgoing (1) on the router it should work. It’s a bit hard at this point, considering that the router should automatically pick up the settings from the config file. Perhaps you could post the client config (without the certificates, ecc.) and some screenshot of the router vpn settings.

Here are shots of the router settings and a copy of the client config. Thanks again for all this help.
client config.txt
VPN1.pdf
VPN2.pdf
VPN3.pdf
VPN4.pdf
VPN5.pdf

Your VPN is not actually running because your raspberry pi expects a valid hmac, and your router is missing it because you forgot to fill the content of tls-auth In the Static Key form of the Keys subsection.
In the Advanced subsection enable Redirect internet traffic and set Accept DNS configuration to Exclusive.
If still doesn’t work, post the server log again.

Made the changes but still no luck, I can connect with my PC using OpenVPN Gui through the same router without a problem. Here is the latest server log, note the last connection was using my PC not the router.
Thanks again.
PiVPN Server Log.txt

Closing this, old topic, and seems to be unrelated with PiVPN at all.


[#29772][Go SDK] Add EventTime Timer tests.

Add event time timer validation tests.
Execute both with bounded, and unbounded modes incase runners execute them differently (namely dataflow).
Fix bug in handling MapWindows, which couldn't map from Global Windows to GlobalWindows properly due to a quirk in the SDK's Window Coder + KV handling.
Pre-Work for #29772

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Currently triggering all the post commits, so I can properly add filtering for failures.

Yeah, just Dataflow appears to support timers. The others fail in various ways.

R: @damondouglas

Friendly ping for a review here.

Great question! Fixing that is out of scope for this PR.
integration.go does not start runners. The Go SDK has never auto-started runners, largely due to that being an undocumented expectation that has never been fulfilled.
The lack of runner lead to deadline failure, and then retuning a nil Pipeline results. The test in particular doesn't fail out when there are nil PipelineResults though, so the metrics check then fails. This could be fixed by not returning a nil pipeline results in such cases in the default runner lib, or by making the test check if a nil was returned.

Updated PTAL!

Dataflow continues to pass, removing trigger files and merging.


always use the internal md5c.c

always use the internal md5c.c

remove references to openssl
simplify builds/configs

lib: do not create a separate md5 static lib

simplify cmake stuff even more
Technically, the 2nd commit belongs to another PR, but it's already done

This looks like a newer md5.c/.h ... smaller, doesn't have global.h (PROTO_LIST, POINTER)
https://github.com/yingshirun/Android-NDK-MD5/tree/master/app/src/main/jni
It could replace the current file,

I adapted the md5.c from the android ndk and unsurprisingly all the checks pass.
There is absolutely no reason to use the openssl libs, cabextract uses its internal md5.c (taken from GNU Libc), which is more complex and has big endian/little endian stuff and 100 #ifdefs, this one is better.
For md5, sha1, sha256, crc32, there are very small libs and single header files, there is no reason to complicate the build, the more static a build is, the more targets will compile out of the box.
I think the static md5 might add 5kb to the lib, that's nothing.
I was also testing with a static miniz (zlib drop-in replacement), and libunshield basically becomes smaller.

Sounds good @wdlkmpx ! But will this work on ARM if it does not have specific big/small endian code?

The problem with the internal MD5 is the licensing I believe. I don't think it is MIT-compatible.

I'm sure it works in the raspis, I had raspi 1, but it died. But I'm sure it works. I'm sure some other app with this md5.c is running on a raspi right now.
This project is not GPL, MIT is a permissive license, it accepts everything.
The problem is GPL, and the other problem is Debian. They forked cdrtools because it was CDDL (free opensource software), their fork (cdrkit) is buggy as hell while cdrtools is the best cd/dvd/bd burning tool for linux.

Not only RPi, the Mac M1 too

By the way, the AppVeyor builds say they succeed even when they are broken (like all the time)

I read a bit, and basically all machines running Windows & Linux are little endian. That's about 99% of users of this app.
But IBM mainframes, HPUX and big server stuff are big endian. So basically big endian IS outside the realms of normality.
Maybe there will be problems with "Macintosh" or something.
Probably this md5.c is only optimized for little endian machines, this is pure speculation, it might work in both big/little endian machines.
I found this, the same md5.c file, but modified to use little/big endian stuff:
http://www.efgh.com/software/md5.htm
It renames MD5_CTX to MD5 and who knows what else, those changes should be reverted.
Also, the code ithat ncludes md5.h must define LITTLE_ENDIAN, something like this:
https://github.com/dvidelabs/flatcc/blob/master/include/flatcc/portable/pendian_detect.h

I think the current md5.c is somewhat "safe".  think it works in both LE/BE
  Decode (x, block, 64);

....
static void Decode (UINT4 *output, unsigned char *input, unsigned int len)
{
  unsigned int i, j;

  for (i = 0, j = 0; j < len; i++, j += 4)
 output[i] = ((UINT4)input[j]) | (((UINT4)input[j+1]) << 8) |
   (((UINT4)input[j+2]) << 16) | (((UINT4)input[j+3]) << 24);
}

vs LE/BE md5.c
  #ifdef LITTLE_ENDIAN
    memcpy(x, block, 64);
  #else
  {
    unsigned int i, j;
    for (i = j = 0; i < 16; i++, j+= 4)
    {
      x[i] = (UINT4) block[j] | (UINT4) block[j+1] << 8 |
        (UINT4) block[j+2] << 16 | (UINT4) block[j+3] << 24;
    }
  }
  #endif

LE/BE md5.c: https://github.com/wdlkmpx/unshield/commit/43f9130956aa5aacab91aada74b157208094ff30
triggers one CodeQL warning in CPP mode.
But I believe the Android NDK version is the one to use, I guess it has been audited and simplified a bit and I believe it is endian-independent code.
It's pretty generic code that compiles and works everywhere.
The musl md5 implemention also seems to be endian-independent
http://git.musl-libc.org/cgit/musl/tree/src/crypt/crypt_md5.c
No #ifdefs, I guess the musl md5.c is another good candidate, musl compiles and runs in all kinds of processor architectures.

This looks like the perfect version, a drop-in replacement and PUBLIC DOMAIN:
https://openwall.info/wiki/people/solar/software/public-domain-source-code/md5
https://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/md5.c?rev=1.15;content-type=text%2Fplain

I decided to use OpenWall's md5.c. I ran all the tests in test/v0 and I see no warnings, exit code 0.
I extracted a couple InstallShield cab files from some old printer drivers, I see no issues. How to test this reliably...
That's all on my side. Expecting the right people to test this PR, we will have to wait a few years. People usually only test code that is already merged.
But here is the snapshot:
unshield-md5.zip
Tested OpenSSL-compatible md5 versions that work OOTB, just replace md5.c/.h:
unshield_md5_android_ndk.zip
unshield_md5_OpenWall.zip
unshield_md5_orig.zip
unshield_md5_rsa_endian.zip
The AppVeyor build fails due to unresolved symbols, I think I have an answer to that, compiling zlib support directly into libunshield.

What if someone is linking libunshield from another application? Won't this cause a name clash if they also link with another MD5 library?

I don't think so, I'm not really sure how the whole thing works, but there are scopes... for example including headers with function definitions (not only declarations) will compile the same code for each .c file that includes it. creating duplicate binary stuff.
A good example should be trying to integrate libunshield into cabextract.
But renaming the shared declarations between the md5/file.c (MD5_Init to _MD5_Init)  should prevent any possible issue, it's also possible to rename all the md5 functions. I can do that if you want.
There are 4 possible variants, so it's possible to try other variant and see if it's more suitable.
I take full responsibility for this and will make the requested changes to prevent issues and can also revert de the whole thing in a matter of minutes.


feat(ui): Display listening endpoint count in table

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #7363   👈

This comment was auto-generated by Graphite.


Reinitialising EmissionsTracker for smaller loops

CodeCarbon version: 2.2.2
Python version: 3.10
Operating System: Linux

Description
I am trying to track emissions of a lot of fairly small loops, and I'm noticing that by initialising the EmissionsTracker at the beginning of every loop is causing significant overhead. I might've missed it in the documentation but is there a way to retain the same EmissionsTracker but effectively "reset" it so it bypasses all of the initialisation/connection with pynvml etc.? I guess a workaround could be that I just initialise a bunch of them before my loop but I don't think this is cutting down on any time.
Currently I'm just using it like
for loop:
    emissions = EmissionsTracker()
    emissions.start()
    # do something
    emissions.stop()

Hello,
You could try:
emissions = EmissionsTracker()
emissions.start()
for loop:
    emissions.flush()
    # do something
emissions.stop()

We will release a new version this week that implement task monitoring, you can read the doc here : https://github.com/mlco2/codecarbon/pull/355/files#diff-cd895c905cf221ed0a1139844e15165861387c12e2f02753776bbe833f1aae14R45
Did you think it will work for you ?

As I understand it, flush just computes the current emissions at a particular time, is that correct?
If so, I could just subtract the previous emissions at each iteration by using flush?

flush will compute the emission since the last call of flush, or start if no flush has been made. So to have the entire emissions you have to sum up all the flush results.

Got it, thanks, this is ideal!

Apologies for the comment spam but I had to clarify something in models I have already trained. When I first used CodeCarbon, I was looking for a way to report the total energy consumed at every epoch, which I achieved via the following approach:
class Emissions(EmissionsTracker):
    def __init__(self):
        super().__init__()

    def get_emissions_data(self):
        _ = self.flush()
        emissions_data = self._prepare_emissions_data()

        if not emissions_data.emissions:
            raise Exception("No emissions data found.")

        return {
            "cpu_power": emissions_data.cpu_power / 1000,
            "gpu_power": emissions_data.gpu_power / 1000,
            "ram_power": emissions_data.ram_power / 1000,
            "cpu_energy_consumed": self._total_cpu_energy.kWh,
            "gpu_energy_consumed": self._total_gpu_energy.kWh,
            "ram_energy_consumed": self._total_ram_energy.kWh,
            "total_energy_consumed": self._total_energy.kWh,
            "co2_emissions": emissions_data.emissions,
        }

My graph outputs show an exponential increase in energy consumed until the end of the runs, I assume that ._prepare_emissions_data() provides a total from the very start of training, and the flush here doesn't affect the emissions tracking?
GPU energy consumed for runs for reference:

My bad, looking at the code  flush is more a checkpoint: it does not reset the data, it only store them to avoid loosing them if there is a crash and to give a view when training for a very long time.
I now remember that we made it for the training of Bloom .
If you update to 2.3.0 you could use task :
class Emissions(EmissionsTracker):
    def __init__(self):
        super().__init__()
        super().start_task()

    def get_emissions_data(self):
        emissions_data = self.stop_task()
        if not emissions_data.emissions:
            raise Exception("No emissions data found.")
        self.start_task()
        return {
            "cpu_power": emissions_data.cpu_power / 1000,
            "gpu_power": emissions_data.gpu_power / 1000,
            "ram_power": emissions_data.ram_power / 1000,
            "cpu_energy_consumed": self._total_cpu_energy.kWh,
            "gpu_energy_consumed": self._total_gpu_energy.kWh,
            "ram_energy_consumed": self._total_ram_energy.kWh,
            "total_energy_consumed": self._total_energy.kWh,
            "co2_emissions": emissions_data.emissions,
        }

Let me know if it works.

I've tried using delta, and here are my outputs:
Initiating Emissions outside of loop and using delta:

domain
cpu_energy_consumed
gpu_energy_consumed
total_energy_consumed
co2_emissions

0
business_finance
0.000211548
4.01752e-05
0.000495608
0.000133709

1
computers_internet
0.000412762
7.88342e-05
0.000969199
0.000127769

2
education_reference
0.000613303
0.00011636
0.00143555
0.000125814

3
entertainment_music
0.000829148
0.000148572
0.00187608
0.000118851

4
family_relationships
0.00104987
0.000190075
0.00239169
0.000139104

5
health
0.00124759
0.000227837
0.00285672
0.000125459

6
politics_government
0.00144783
0.000261735
0.0032953
0.000118322

7
science_mathematics
0.00165944
0.000301949
0.00379161
0.000133897

8
society_culture
0.00188305
0.000342077
0.00430129
0.000137505

9
sports
0.00211313
0.000380974
0.00480787
0.00013667

Initiating a new Emissions object at the beginning of each loop iteration:

domain
cpu_energy_consumed
gpu_energy_consumed
total_energy_consumed
co2_emissions

0
business_finance
0.000196129
3.81157e-05
0.000464391
0.000125287

1
computers_internet
0.000198403
3.80815e-05
0.000467412
0.000126102

2
education_reference
0.00021492
4.25208e-05
0.000513729
0.000138598

3
entertainment_music
0.000202835
3.92338e-05
0.000478709
0.000129149

4
family_relationships
0.000193552
3.74038e-05
0.000456428
0.000123138

5
health
0.000207246
4.04279e-05
0.000492394
0.000132841

6
politics_government
0.000218375
4.21931e-05
0.000516227
0.000139271

7
science_mathematics
0.000196969
3.78047e-05
0.000464599
0.000125343

8
society_culture
0.000194441
3.77904e-05
0.00046263
0.000124812

9
sports
0.000195935
3.75336e-05
0.000462923
0.000124891

As you can see, the latter is much more consistent (all the same dataset sizes, slight deviations in document length).
I upgraded my codecarbon version to 2.3.0 and tried the code you posted but I get the following error:
AttributeError: 'NoneType' object has no attribute 'cancel'
This also happens when I just initialise a standard EmissionsTracker object as per the official docs.

Hello,
Thanks for finding this bug : a workaround is to call super().start() or emissions.start_task() before start().
I will fix this in the next release.
Here is the working example : https://github.com/mlco2/codecarbon/blob/master/examples/task_inference.py

Great, this works. Thanks!


Extensions status button not clickable on Edge

Expected Behavior
Clicking the extension status button on the microbit extension should bring up the connection window
Actual Behavior
It doesn't.  Nothing happens.  No errors appear in the console
Steps to Reproduce
Add the microbit extension to a project
Connect to a microbit
Go to the project
Click the extension status button
Note: Nothing happens
Operating System and Browser
Edge on Windows

@ericrosenbaum This feels like it should be on the critical path for August given the amount of usage we are seeing on Edge.


Typescript Not Identified.. Giving unexpected errors

I liked brackets very much and seriously want to start using it. But this!! :(
Its giving unexpected errors in typescript.
These are the extensions i have installed and the errors (unwanted errors) that i am getting.
Please help me to configure typescript if possible!
There are some other typescript plugins which are not available for my version(latest) of brackets..

That's something wrong with the extension not the code editor itself... I'm not sure if there is a separate issue section, but I'm just clarifying to make sure you know that.

Thanks Colin..
But it would be nice if i could get some solution.. :(

@akashs25 @ColinRioux try out https://github.com/zaggino/brackets-typescript


Make sure downloaded DLLs are executable

To make use of dynamic linking under Windows, the user must have execution permissions on the DLL file. For default installations, these are not usually restricted -- all files are "executable" from a permissions viewpoint, but only files with the proper extension are actually executed.
Since I'm using the same partition as both my Windows and Linux home folder, I set it up in a way so that newly created files do not have the executable permission set (otherwise, file managers on linux give me a "do you want to open or execute this file?" prompt every time i try to open something). This also affects the files that WinRPM downloads. For packages that use WinRPM as a BinDeps backend, this causes the issatisfied check to fail, since the call to dlopen_e meant to check for the library's existence fails (prompting me to dig through the code of all these packages for two days when I'm just installing julia for the first time ;-)).
I recognize that this is only a problem for specific odd setups as mine, but the Windows analogue of a simple chmod +x would suffice to be on the safe side here.

Would you try to prepare a pull request to do that, with a comment in the code explaining the specific case where this is needed?

I can try. As I said, I have never worked with julia before, but then again, it should be rather straightforward.

... or so I thought. As laid out in JuliaLang/julia#7574, the standard library permissions functions (including stat and chmod) don't make too much sense on Windows right now, and I couldn't find any Julia package to deal with ACLs. It would probably need some C hacking to do this, but, that's probably not worth it. So a proper solution would have to wait for some such package to be written.
Since this issue is unlikely to affect a significant number of people, it's fine with me if you want to close it.


[BugFix] Init OlapTable AtomicLong variables after deserialized from gson

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19274
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_fe_unittest

run starrocks_be_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 6 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
6
6
100.00%
[]


HARP-9037 Refactored DataSource zoom level limits

Added minDataLevel, maxDataLevel, minDisplayLevel, maxDisplayLevel.
Deprecated minZoomLevel, maxZoomLevel.

Signed-off-by: Marcel Pursche<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1375 into master will increase coverage by 0.06%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage   54.79%   54.85%   +0.06%
==========================================
  Files         265      265
  Lines       23593    23627      +34
  Branches     5275     5285      +10
==========================================
+ Hits        12927    12961      +34
  Misses      10666    10666

Impacted Files
Coverage Δ

@here/harp-omv-datasource/lib/OmvDataSource.ts
40.67% <ø> (+4.85%)
:arrow_up:

@here/harp-mapview/lib/VisibleTileSet.ts
73.36% <ø> (ø)
:arrow_up:

...e/harp-webtile-datasource/lib/WebTileDataSource.ts
46.01% <100%> (ø)
:arrow_up:

@here/harp-mapview/lib/PolarTileDataSource.ts
96.47% <100%> (+0.08%)
:arrow_up:

@here/harp-mapview/lib/BackgroundDataSource.ts
97.61% <100%> (ø)
:arrow_up:

@here/harp-mapview-decoder/lib/TileDataSource.ts
62.5% <100%> (ø)
:arrow_up:

@here/harp-mapview/lib/DataSource.ts
84.16% <76.92%> (-2.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693e1c7...7d521b3. Read the comment docs.


[AVCaptureSession stopRunning] stopRunning may not be called between calls to beginConfiguration and commitConfiguration

偶现报这个错误怎么解决。就是开启相机权限后  再打开相机扫码容易出现

同样报这个错，改也改不动，用不下去了


autocomplete: Implement new design for @-mention autocomplete items

Hello everyone,
This PR implements the updated design for the @-mention autocomplete items as detailed in this Figma File
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3859-3131&m=dev
I added new contextMenuItemLabel and contextMenuItemMeta color variables to the designVariables class from the design.
I also had to manually set the line height to match the design exactly.
As Greg described here, the autocomplete item only shows the user's real email address when the user has allowed their email to be visible, if not it doesn't show anything. I used the _getDisplayEmailFor() method from the profile page to get the user's real email. I am not sure if it is a good idea to have a copy of the same method here, maybe we should find a way to not have multiple copies of the same method.

I updated autocomplete tests to also check if the email(metaData) is also shown as the updated design now shows extra metadata.
I attempted to add another test to verify if the email is not shown when the user's emailAddressVisibility != emailAddressVisibility.everyone, while doing so I learned a bit more about how the app manages users and data, but to be honest I couldn't get it to work properly, and I did not want to massively change up the current test file. Still trying to wrap my head around that.
This also leads me to a bug I think, which I discovered in the example_data.dart initialSnapshot method where some of the arguments from the intialSnapshot method aren't being passed down to the method, I think someone missed that when setting up the method.
Please review when you can, thank you
Fixes: #913

This also leads me to a bug I think, which I discovered in the example_data.dart initialSnapshot method where some of the arguments from the intialSnapshot method aren't being passed down to the method, I think someone missed that when setting up the method.

Sure, this would be good to fix — please go ahead and add a commit with that fix if you think you already see how to do it, or start a thread in #mobile-team and we can discuss in more detail.

Okay, thank you for the review, I will make the changes.
For the changes such as the bug and the refactor of the email logic, should I add those into this PR, or should it be in a different PR?

If it's needed for the other work you're doing in this PR, then a commit in this PR is a good way to do it.
If it's not related to what's in this PR, then a separate PR is best.

If it's needed for the other work you're doing in this PR, then a commit in this PR is a good way to do it.
If it's not related to what's in this PR, then a separate PR is best.

Okay

Our designer doesn't want the "ink splash" effect on buttons. We should remove the InkWell widget and implement the on-pressed appearance specified here:

About the splash, I kept the inkwell widget, because a gesture detector doesn't show splashes, but I removed the sparkle effect, and left just the color change on tap. I also added a border radius in the splash as shown on the design, it's a bit difficult to see here but it is there. Would this work according to the design?
https://github.com/user-attachments/assets/9c190f0c-c373-4cbb-85f9-7def3b56611a

I also did the updates for the case where the user has a really long name or email.
Before

After

Would this work according to the design?

If your code causes any noticeable differences from the design, please identify them and say why you think they are OK. This will shorten the path to deciding if the code will work. :)
It looks like you haven't pushed your latest revision to GitHub. When it's ready for another review, please do that, and comment saying that it's ready for review.

It looks like you haven't pushed your latest revision to GitHub. When it's ready for another review, please do that, and comment saying that it's ready for review.

No, I haven't yet.
That is because I have been facing some problems with the ComposeAutocomplete  test, I found that changing the dimensions of the avatar widget from 32 to 36 causes the test to fail. Not only that I found that there was a threshold of sizes for which the test passed, 32 -33 are good, and from 34 upward the test fails.
And I have looked at the test, and tried to do some searching as to why it might be failing, and I haven't succeeded. I did not see any obvious place where the avatar widget size was checked in the test. I also thought it might be because of an outdated golden test snapshot, but I could not find any references to a snapshot file. So I have been confused and stumped.
I was just about to comment on that, wondering if anyone can help point me in the right direction.

If you push the code here, and then start a conversation in #mobile-dev-help with the test failure you're seeing, that will probably be the most efficient way to get help investigating it.

If you push the code here, and then start a conversation in #mobile-dev-help with the test failure you're seeing, that will probably be the most efficient way to get help investigating it.

Okay, I will do that

It looks like you haven't pushed your latest revision to GitHub. When it's ready for another review, please do that, and comment saying that it's ready for review.

I have pushed my changes, please review

I noticed that some other tests failed on the pipeline, some database tests to be specific.
❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: non-migration tests create account (failed)
  Invalid argument(s): Failed to load dynamic library 'libsqlite3.so': libsqlite3.so: cannot open shared object file: No such file or directory
  dart:ffi                                                        new DynamicLibrary.open
  package:sqlite3/src/ffi/load_library.dart 52:27                 _defaultOpen
  package:sqlite3/src/ffi/load_library.dart 127:12                OpenDynamicLibrary.openSqlite
  package:sqlite3/src/ffi/api.dart 13:39                          sqlite3
  package:drift/native.dart 313:12                                _NativeDelegate.openDatabase
  package:drift/src/sqlite3/database.dart 79:19                   Sqlite3Delegate.open
  package:drift/src/runtime/executor/helpers/engines.dart 431:22  DelegatedDatabase.ensureOpen.<fn>
❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: non-migration tests create account with same realm and userId  (failed)
❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: non-migration tests create account with same realm and email (failed)
❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: migrations upgrade to v2, empty (failed)
❌ /home/runner/work/zulip-flutter/zulip-flutter/test/model/database_test.dart: migrations upgrade to v2, with data (failed)

These tests didn't fail before, and they also passed locally.
I think it is related to the migration to Ubuntu 24.04 which apparently seems to have been causing a lot of issues and is now being rolled back.
https://github.com/actions/runner-images/issues/10636

Thanks for pointing out those unrelated test failures. I've run CI again and those failures are gone; see https://github.com/zulip/zulip-flutter/pull/999#issuecomment-2417351945
Some failures remain and are related to the changes in this PR; I see a discussion in #mobile-dev-help about that.

If you push the code here, and then start a conversation in #mobile-dev-help with the test failure you're seeing, that will probably be the most efficient way to get help investigating it.

Thanks for starting that conversation. Here's a link, so people reading this will know the conversation is happening and where to find it: https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/ComposeAutocomplete.20test.20failure.20help/near/1963058

If it's needed for the other work you're doing in this PR, then a commit in this PR is a good way to do it.
If it's not related to what's in this PR, then a separate PR is best.

Hello
I have created a PR for this bug, please review when you can.
https://github.com/zulip/zulip-flutter/pull/1011

#1011

Thanks; I'll add this to my review queue. 🙂
I see Greg has replied in that discussion about the test failures. Please comment here when those failures are resolved and this PR is ready for another review. 🙂

It's puzzling that GitHub didn't run the CI checks on the latest revision.
It's not because the commits are the same; they're different. Even though the last commit has the same changes in it as the last commit of the previous revision, it's still a different commit as far as Git is concerned because it has a different history. You can see here:

fombalang force-pushed the autocomplete-results-list branch from e107e03 to 5b85e89 1 hour ago

that the latest revision's tip commit is 5b85e89 and the revision before that was e107e03.
Anyway, we can run the tests locally, and as long as they pass when run locally then that confirms that they pass.

I tried the "dismiss review" button on Chris's previous "request changes" review, just in case that was related to why CI wasn't running. Doesn't seem like it had an effect — still not running.
I don't even have a button to tell checks to run. Instead the "Checks" tab just looks like this:

Workflow runs completed with no jobs

It's as if there weren't any files under .github/workflows/ at all. But in reality there is; your branch doesn't touch that directory, so it has the same workflow file in it as it has in main.
:shrug: We'll just rely on running checks locally, then. If this odd GitHub behavior starts happening repeatedly, we'll have to investigate further.

that the latest revision's tip commit is 5b85e89 and the revision before that was e107e03.

Okay, I see. which means it should have triggered again.

🤷 We'll just rely on running checks locally, then. If this odd GitHub behavior starts happening repeatedly, we'll have to investigate further.

Okay then.
Everything passes locally on my end.

The GitHub UI is showing that there are some rebase conflicts:

Could you please resolve those and comment here when that's done? If you need help, please ask in #git help in the development community.

development community

I can just resolve using the GitHub UI right? or would that add an unwanted commit?

Thanks! A few small comments from a light review, but more substantively:
The first commit—
autocomplete: Implement new design for @-mention autocomplete items

—doesn't pass tools/check. Please fix the branch so that all commits pass all tests.

Okay.
I am confused though, the check runs against the latest commit, right?
How do I then ensure this commit would pass the check independently?
Also, I squashed the fix that I did for the test into this commit.

I have made the changes, please review them when available.

How do I then ensure this commit would pass the check independently?

By running tools/check at that commit. 🙂 See the README on tests: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#tests

I have made the latest changes. Please review when you can.

Thanks, this is getting closer!
In #995 (comment), by "prep" commit I meant a commit that comes before the commit that needs it, to prepare for it. 🙂 In the branch as it is now, the helper function gets rewritten one way, but then that way is thrown out and replaced with the one we want. Instead of changing it twice, we should just change it once. That change should happen in a commit that comes before the commit that redesigns the UI, since that's the commit that needs the change.

Oh, I see now.
Also, do I have to include "prep" in the commit message?

No, we don't have a rule about that. :)

I have made the updates and fixed the conflicts and reordered the prep commit.
Also added a fix for the contextMenuItemText color variables as an NFC commit. I am a bit confused if a change like this would be considered an NFC commit? 🤔

tools/check fails at this commit:
autocomplete_test [nfc]: Rename findNetworkImage to findAvatarImage

It looks like that commit is doing more than it says in the commit message. It's also changing some tests so that they expect an email address to appear in an autocomplete item. That's something we want to do, but not at this commit, before the app code has actually been changed to show the email address. We should add that expectation in the same commit that satisfies it:
autocomplete: Implement new design for @-mention autocomplete items

Also added a fix for the contextMenuItemText color variables as an NFC commit. I am a bit confused if a change like this would be considered an NFC commit? 🤔

Thank you!
Looks like it does make a functional change, although a small one. The lerp method is used to fade the colors smoothly over 200 milliseconds when transitioning between light mode and dark mode. So I imagine the bug you've fixed here could be reproduced on main this way:

Open the app on Android
In system settings, switch to light mode and schedule the app to switch to dark mode a minute or so after the current time (or vice versa)
Open the message list
Long-press a message to bring up the action sheet
While watching the text in the action sheet, wait for the scheduled switch from light to dark (or vice versa) that you set up in step 2
Notice that the text's color goes in the wrong direction over the 200ms animation, then suddenly snaps to the correct color when the animation is finished

I haven't tried this myself. This is quite a small bug, but one we're glad to fix! No need to spend time reproducing it; all you need to do is change your commit message to remove [nfc]. 🙂

That's something we want to do, but not at this commit, before the app code has actually been changed to show the email address. We should add that expectation in the same commit that satisfies it:

Yeah. I think during my rebase I must have messed it up somehow, when I was reordering the commit structure.

I have updated the commits, removed the NFC label from the color fix, and adjusted the other commits.
I ran tools check on each commit using
git checkout <commit-hash> -- . && tools/check && git checkout -- .
Not sure if this is the right command to use, but all the commits passed.

The command I use, from a feature branch that tracks main, is:
git rebase -i --exec 'tools/check --diff @~'

Are you familiar with interactive rebase? This sets up an interactive rebase with an "exec" step that runs the command tools/check --diff @~ at each commit. (The --diff @~ part makes tools/check run only on files that differ from the previous commit.)

The command I use, from a feature branch that tracks main, is:
git rebase -i --exec 'tools/check --diff @~'

Are you familiar with interactive rebase? This sets up an interactive rebase with an "exec" step that runs the command tools/check --diff @~ at each commit. (The --diff @~ part makes tools/check run only on files that differ from the previous commit.)

Okay, I will try this and see.
Yes, I am familiar with interactive rebase, although I am mainly used to working in the Android Studio UI and not the terminal.

Thanks! LGTM except for one tiny nit below, and I'll mark this for Greg's review.

Alright, great!
Thank you very much for your help reviewing!

Generally this all looks good. Various small comments below.

Alright, thank you for the corrections. I will implement these changes.

This should also get tests. No need to check things like that the font size or the colors etc. match the design — that sort of test wouldn't really add value beyond duplicating what's in the implementation. But there is a bit of logic here that would be good to test:

Yeah, I originally intended to add some test cases similar to the ones you describe, which is what initially led me to find the small bug with the emailAdressVisbility. But, I couldn't figure out exactly how the account stores work to properly override the emailAdressVisbility and create the test cases. But I will get back to it and see how to add the test cases.

Cool, sounds good.

But, I couldn't figure out exactly how the account stores work to properly override the emailAdressVisbility and create the test cases. But I will get back to it and see how to add the test cases.

Yeah, if you browse through the other tests in test/widgets/, you'll see examples of using that eg.initialSnapshot function you sent a fix for, and that should help you get going. If you have questions after giving that another try, please go ahead and ask in #mobile-dev-help on chat.zulip.org.

I've just merged #1069, which touched some of this same code. @fombalang when you push your next revision, don't worry about rebasing it forward past those changes — just push it without rebasing, and I can take care of rebasing it on top of those changes and resolving the conflicts.
(Ordinarily we expect contributors to handle resolving rebase conflicts; it's an important Git skill. But these conflicts are unusually complex, and have more to do with my #1069 than with your PR or with the routine need for resolving conflicts.)
If you use git rebase -i for revising your branch (which you probably will want to do), you can say git rebase -i --keep-base to tell it not to rebase forward, and to instead focus on what rebase -i specifically is good at.
Separately, even if you're still working on the tests, I'd encourage you to go ahead and push the revision you have that addresses all the other review comments. That way I can re-review those changes while you're still working on the tests.

Separately, even if you're still working on the tests, I'd encourage you to go ahead and push the revision you have that addresses all the other review comments. That way I can re-review those changes while you're still working on the tests.

Okay, understood. Yes, I am still working on the test. but the other changes were done. I will push the updates then.
I was holding off on pushing because I thought the test should be included in the main commit according to the commit guides. Would it be okay if I add the tests as a separate commit later? I already started facing some challenges rebasing my changes as main started to diverge more and more.

I have sent the latest updates. Please review when you can.

I have added a commit for the delivery email visibility test case.
Do you think I should squash it into the main autocomplete commit, or is it fine as is?

Thanks for the revision!
I haven't yet reviewed the new changes, but first I've gone ahead and rebased them onto main, like I offered above; and I've pushed the result back to the PR branch.
So from here you should be able to rebase atop #1087 as discussed in chat today, or atop future other changes merged to main. I don't expect to have other changes landing in the near future that would have complex conflicts like the kind #1069 caused.

Also just added one more commit on top, to update the style for emoji autocomplete to match what this PR does for @-mention autocomplete. We'll leave that commit in the PR branch, and can merge it along with the rest of the PR when ready. (@chrisbobbe PTAL too since that's new material.)

Thanks @chrisbobbe for the review! Pushed a revision adding a comment with a digest of that subthread.
@fombalang For the next step, please go ahead and revise the PR based on the feedback above at https://github.com/zulip/zulip-flutter/pull/995#pullrequestreview-2463104713 .

Thanks @chrisbobbe for the review! Pushed a revision adding a comment with a digest of that subthread.
@fombalang For the next step, please go ahead and revise the PR based on the feedback above at #995 (review) .

Alright, will do so.
Apologies for the delay with the revisions, I will be sending them soon.


chore: change tags to karpenter.azure.com_cluster

Description
If you run make az-resc is does not show all resources created by Karpenter as the resk var only show resources with the label karpenter.sh_nodepool. But as you can see on #67  Ghost Nics for example do not have the labels karpenter.sh_nodepool but they do have the labels karpenter.azure.com_cluster. So this PR changes the label used by the resk call.
It seems also that NICs never get the tag karpenter.sh_nodepool assigned.
make az-resc
az resource list --tag=karpenter.sh_nodepool --query "[?resourceGroup=='MC_rg-karpenter-pwe-tmp1_aks-karpenter-pwe-tmp1_northeurope']" -o tsv | wc -l
1

vs
make az-resc
az resource list --tag=karpenter.azure.com_cluster --query "[?resourceGroup=='MC_rg-karpenter-pwe-tmp1_aks-karpenter-pwe-tmp1_northeurope']" -o tsv | wc -l
38

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

NONE

It seems also that NICs never get the tag karpenter.sh_nodepool assigned.

That's what needs to be fixed, I think, instead of listing by karpenter.azure.com_cluster tag. It would be better not to rely on the latter; we should consider retiring it altogether.

Closing in favor of properly tagging network interfaces, #75


All the players get redirected to the lobby and all the players that haven’t left should be able to play again from the lobby.

duplicate


Expose response stats in Pinot java client's BrokerReponse

Currently, response stats like numDocsScanned, totalDocs, and timeUsedMs are returned in the JSON response body but they're not exposed to the client in https://github.com/apache/incubator-pinot/blob/master/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java
Exposing the response stats would allow the client application to log the stats for slow queries and make the debugging easy instead of trying to reproduce the slow queries again.
I will raise a PR for this unless people have any comments.
cc @kishoreg

@buchireddy  can we close this?

Yes. The PR is merged.


[WIP]Refactoring available_images method for miq_ae_orchestrations

Purpose or Intent
Refactoring the available_images method for the miq_ae_orchestration based on the issue bellow.
Links [Optional]
https://github.com/ManageIQ/manageiq/issues/12038

@miq-bot add_labels automate, enhancement

@miq-bot add_label refactoring

@pkomanek
Can we add namespaces like we did for the other refactoring

@miq-bot add_label wip

@miq-bot remove_label wip


Store starting node number and total number of nodes in session data

This task only took me about 15 minutes because I was already calculating and using this information in a different way. I just needed to find where I was already doing that and store it as well.


Android Inference AAR Release Builds

Android Release request
You currently have nightly Android builds.  Is it possible to also have a Jenkins job that publishes stable release (and maybe RC) builds for Android?
Or alternatively, can you publish release and RC builds of your Android Inference AAR out somewhere they can be pulled as dependencies by Gradle (Maven Central or wherever other Android dependencies are stored)?

@yifeif what do you think?

We've actually just published an initial aar yesterday: https://bintray.com/google/tensorflow/tensorflow-aar/1.2.0-preview#files
We'll be updating the Gradle code in the Android demo soon to show how to use it.
Plans going forward are to update this on every point release as part of the release process.

Great news, thank you!

One more question, do you guys plan on making this available in jcenter?  It doesn't appear to be there as I would expect to see it in the org.tensorflow group on jcenter (and its not currently there).

Yes, we're currently in the process of doing so, will update here with final details when available.

The AAR is live! See this comment for instructions on using.

the AAR doesn't seem to exist online can anybody send it to me please


Add possibility to select datetime type for generators

Currently only 'OffsetDateTime' used for model\client generators. It leads to conflicts if server or other client code uses Instant as a datetime type.
Suggestion:
Add --type-options parameter for generator, with instant_datetime_type possible value.
If this parameter exist - use Instant as a datetime type, otherwise use OffsetDateTime by default

Added PR, any thoughts? https://github.com/cjbooms/fabrikt/pull/177

Closed in #178


Misc fixes

Issue #, if available:
#170
#166
Description of changes:
This PR modifies the sample apps to accept repeat=true&slow=true to simulate latency in the apps.
This also is a hot-fix for an issue in the CI/CD module related to a previous PR to fix a typo in the role name.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rnzsgh I found two showstoppers and one non-showstopper:
Showstoppers
https://github.com/aws-samples/eks-workshop/issues/178
https://github.com/aws-samples/eks-workshop/issues/177
Non Showstoppers
https://github.com/aws-samples/eks-workshop/issues/176


Help with install of mongodb chart. How do I setup the volume that is needed

This is a request for help.
Version of Helm and Kubernetes:
[root@togo ~]# kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:37:52Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

[root@togo ~]# helm version
Client: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}

Which chart:
stable/mongodb
What happened:
The persistent volume cannot connect to a volume. Indeed there is no volume as seen below.
There are no instructions  on the chart page that would describe how to create a volume for this chart.
[root@togo ~]# kubectl get pv,pvc,pods,deployments --all-namespaces
NAMESPACE   NAME                                           STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
default     persistentvolumeclaim/factual-poodle-mongodb   Pending                                                     55m

NAMESPACE     NAME                                               READY   STATUS    RESTARTS   AGE
default       pod/factual-poodle-mongodb-69c57d868f-gtb87        0/1     Pending   0          55m
kube-system   pod/coredns-86c58d9df4-jjgpn                       1/1     Running   0          17h
kube-system   pod/coredns-86c58d9df4-n6lcv                       1/1     Running   0          17h
kube-system   pod/etcd-togo.corp.sensis.com                      1/1     Running   0          17h
kube-system   pod/kube-apiserver-togo.corp.sensis.com            1/1     Running   0          17h
kube-system   pod/kube-controller-manager-togo.corp.sensis.com   1/1     Running   0          17h
kube-system   pod/kube-flannel-ds-amd64-fxpv9                    1/1     Running   0          17h
kube-system   pod/kube-flannel-ds-amd64-n6zk9                    1/1     Running   0          16h
kube-system   pod/kube-flannel-ds-amd64-shqnr                    1/1     Running   0          16h
kube-system   pod/kube-proxy-h9jpr                               1/1     Running   0          16h
kube-system   pod/kube-proxy-vzdpl                               1/1     Running   0          17h
kube-system   pod/kube-proxy-xn5dv                               1/1     Running   0          16h
kube-system   pod/kube-scheduler-togo.corp.sensis.com            1/1     Running   0          17h
kube-system   pod/tiller-deploy-5b7c66d59c-k9xkv                 1/1     Running   0          17h

NAMESPACE     NAME                                           READY   UP-TO-DATE   AVAILABLE   AGE
default       deployment.extensions/factual-poodle-mongodb   0/1     1            0           55m
kube-system   deployment.extensions/coredns                  2/2     2            2           17h
kube-system   deployment.extensions/tiller-deploy            1/1     1            1           17h

The PVC description shows the failure
[root@togo ~]# kubectl describe pvc factual-poodle-mongodb
Name:          factual-poodle-mongodb
Namespace:     default
StorageClass:
Status:        Pending
Volume:
Labels:        app=mongodb
               chart=mongodb-5.13.1
               heritage=Tiller
               release=factual-poodle
Annotations:   <none>
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Filesystem
Events:
  Type       Reason         Age                    From                         Message
  ----       ------         ----                   ----                         -------
  Normal     FailedBinding  2m36s (x223 over 57m)  persistentvolume-controller  no persistent volumes available for this claim and no storage class is set
Mounted By:  factual-poodle-mongodb-69c57d868f-gtb87

What you expected to happen:
I thought that this would also create the volume.  How do I create the volume that is needed by this chart? The chart documentation does not describe this.
How to reproduce it (as minimally and precisely as possible):
 helm install stable/mongodb
Anything else we need to know:

Looks like my issue is that by default this chart assumes dynamic provisioning. I'm trying to take this one step at a time. I'd like to modify the values.yaml to use a simple local-storage provisioner, or perhaps a simple nfs provisioner.. Can someone provide guidance on how to do this?

Hi @davesargrad
What kind of K8s cluster are you using? Most K8s distributions have a Local Provisioner configured by default.
To install a NFS provisioner, you can follow these steps:

Ensure your cluster has NFS packages installed: sudo apt-get install nfs-common
Install NFS provider:

$ helm install --name nfs-server-provisioner stable/nfs-server-provisioner --set persistence.enabled=true,persistence.size=5Gi

Once the NFS provide is running, install Odoo chart using the right storageClass:

$ helm install --name mongodb stable/mongodb --set persistence.storageClass=nfs --set persistence.accessMode=ReadWriteMany --set persistence.size=2Gi

Please note I decided to give 5Gi to the NFS Provisioner and 2Gi to MondoDB. You can modify these values according to your needs

Hi @juan131
Thanks very much for taking the time to help me with this. I will try your suggestions today.
Relative to your question:
"What kind of K8s cluster are you using? "
How do I answer this? I am a relative K8s newbie. I've successfully setup a master with 5 worker nodes. I have also successfully setup my first application. I dont believe that I have a storage provisioner by default. Is there a way to check this?
I am working on centos 7, rather than ubuntu. What is the alternative to the apt-get command you suggest above? Also will the helm charts that you recommend work on centos?

Hi @juan131 .
I'm just getting back to this. So I've tried to do what you suggest
Specifically:
helm install --name nfs-server-provisioner stable/nfs-server-provisioner --set persistence.enabled=true,persistence.size=5Gi

and
helm install --name mongodb stable/mongodb --set persistence.storageClass=nfs --set persistence.accessMode=ReadWriteMany --set persistence.size=2Gi

Note that the pods fail to schedule as seen below:
[root@togo dsargrad]# kubectl get pods --all-namespaces
NAMESPACE     NAME                                                   READY   STATUS    RESTARTS   AGE
default       mongodb-c45fd69c4-fsshb                                0/1     Pending   0          21m
default       nfs-server-provisioner-0                               0/1     Pending   0          24m
kube-system   coredns-86c58d9df4-lnxfr                               1/1     Running   0          167m
kube-system   coredns-86c58d9df4-zv7wm                               1/1     Running   0          167m
kube-system   dashboard-demo-kubernetes-dashboard-69cc4bf4fb-b95bt   1/1     Running   0          49m
kube-system   etcd-togo.corp.sensis.com                              1/1     Running   0          166m
kube-system   kube-apiserver-togo.corp.sensis.com                    1/1     Running   0          166m
kube-system   kube-controller-manager-togo.corp.sensis.com           1/1     Running   0          166m
kube-system   kube-flannel-ds-amd64-bjlhg                            1/1     Running   0          162m
kube-system   kube-flannel-ds-amd64-hg5n5                            1/1     Running   0          126m
kube-system   kube-flannel-ds-amd64-j6xcf                            1/1     Running   0          167m
kube-system   kube-flannel-ds-amd64-jfb6n                            1/1     Running   0          75m
kube-system   kube-flannel-ds-amd64-r7crj                            1/1     Running   0          75m
kube-system   kube-flannel-ds-amd64-wdvm8                            1/1     Running   0          75m
kube-system   kube-proxy-4zk9r                                       1/1     Running   0          75m
kube-system   kube-proxy-cl929                                       1/1     Running   0          75m
kube-system   kube-proxy-dk9xx                                       1/1     Running   0          167m
kube-system   kube-proxy-tbxnl                                       1/1     Running   0          75m
kube-system   kube-proxy-vfwhp                                       1/1     Running   0          126m
kube-system   kube-proxy-xwmzw                                       1/1     Running   0          162m
kube-system   kube-scheduler-togo.corp.sensis.com                    1/1     Running   0          166m
kube-system   tiller-deploy-5b7c66d59c-bkht9                         1/1     Running   0          50m

The claims
[root@togo dsargrad]# kubectl get pvc,pv
NAME                                                  STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/data-nfs-server-provisioner-0   Pending                                                     24m
persistentvolumeclaim/mongodb                         Pending                                      nfs            21m

The provisioner pod
[root@togo dsargrad]# kubectl describe pod nfs-server-provisioner-0
Name:               nfs-server-provisioner-0
Namespace:          default
Priority:           0
PriorityClassName:  <none>
Node:               <none>
Labels:             app=nfs-server-provisioner
                    chart=nfs-server-provisioner-0.2.1
                    controller-revision-hash=nfs-server-provisioner-69bc6f77dd
                    heritage=Tiller
                    release=nfs-server-provisioner
                    statefulset.kubernetes.io/pod-name=nfs-server-provisioner-0
Annotations:        <none>
Status:             Pending
IP:
Controlled By:      StatefulSet/nfs-server-provisioner
Containers:
  nfs-server-provisioner:
    Image:       quay.io/kubernetes_incubator/nfs-provisioner:v1.0.9
    Ports:       2049/TCP, 20048/TCP, 111/TCP, 111/UDP
    Host Ports:  0/TCP, 0/TCP, 0/TCP, 0/UDP
    Args:
      -provisioner=cluster.local/nfs-server-provisioner
    Environment:
      POD_IP:          (v1:status.podIP)
      SERVICE_NAME:   nfs-server-provisioner
      POD_NAMESPACE:  default (v1:metadata.namespace)
    Mounts:
      /export from data (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from nfs-server-provisioner-token-rchlk (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  data:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  data-nfs-server-provisioner-0
    ReadOnly:   false
  nfs-server-provisioner-token-rchlk:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  nfs-server-provisioner-token-rchlk
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason            Age                From               Message
  ----     ------            ----               ----               -------
  Warning  FailedScheduling  4s (x36 over 25m)  default-scheduler  pod has unbound immediate PersistentVolumeClaims (repeated 5 times)

What am I still missing?

Relative to your question:
"What kind of K8s cluster are you using? "
How do I answer this? I am a relative K8s newbie.

Are you using Minikube or a K8s cluster offered by a CloudProvider (e.g. GKE, Openshift, AKS or EKS)? Or did you create your own K8s cluster on bare metal?

I am working on centos 7, rather than ubuntu. What is the alternative to the apt-get command you suggest above? Also will the helm charts that you recommend work on centos?

Try with: yum install nfs-utils

Also will the helm charts that you recommend work on centos?

Yes, they should work on CentOS or any other Linux distro.

What am I still missing?

As you can check the status for the PVCs is "pending". It means the cluster could not provision a RWX PV for MongoDB nor a RWO PV for NFS Server Provisioner.
It meas your cluster can't provision those resources. For instance, on Minikube you can check what add-ons you have installed using the command below:
$ minikube addons list
- addon-manager: enabled
- dashboard: enabled
- default-storageclass: enabled
- efk: disabled
- freshpod: disabled
- gvisor: disabled
- heapster: disabled
- ingress: enabled
- logviewer: disabled
- metrics-server: disabled
- nvidia-driver-installer: disabled
- nvidia-gpu-device-plugin: disabled
- registry: disabled
- registry-creds: disabled
- storage-provisioner: enabled
- storage-provisioner-gluster: disabled

You should have the storage-provisioner add-on enabled.


Add locale for DateTimeFormatter

Codecov Report
Patch coverage: 50.00% and project coverage change: -1.68% :warning:

Comparison is base (2aac09a) 73.22% compared to head (7dda497) 71.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1897      +/-   ##
============================================
- Coverage     73.22%   71.54%   -1.68%
+ Complexity    21539    20822     -717
============================================
  Files           646      634      -12
  Lines         87425    86678     -747
  Branches      19092    18888     -204
============================================
- Hits          64019    62017    -2002
- Misses        15487    16703    +1216
- Partials       7919     7958      +39

Files Changed
Coverage Δ

...ain/java/com/alibaba/fastjson2/util/DateUtils.java
77.77% <50.00%> (-6.72%)
:arrow_down:

... and 83 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixing Tests 1

Fixed framework/DataObjects.dataObject_metadata
Fixed framework/DataObjects.load_csv
Fixed framework/DataObjects.load_csv_history
Fixed framework.testGridWithConstants
Fixed framework/PostProcessors/RavenOutputPostProcessor.dynamic
Fixed framework/PostProcessors/RavenOutputPostProcessor.invalidXMLtag
Fixed framework/PostProcessors/RavenOutputPostProcessor.static
Fixed framework/Optimizers.Infinite
Fixed framework/ErrorChecks.badHistory
Fixed framework/ErrorChecks.badPointSet
Also fixes some XSD validation, also generally fixes "constant" variables.

Currently running tests on Falcon.  Will post results as they show up, although they should be the same as the qsub tests.

Okay this is ready now.    I fixed more files than it says pass additionally.  Investigating perpetually....


Not all events are being indexed

I could be doing something wrong, but it appears that not all the events are being indexed. In the origin-box setup, only 1 listing and 2 purchases are indexed (regardless of how many new listings you create).
The listing endpoint is http://localhost:5000/api/listing
The purchase endpoint is http://localhost:5000/api/purchase
That's where you can see the indexed events.
In the demo dapp (http://localhost:3000), you can see the actual listings/purchases.

On the box I'm currently running, I see for listings:
{   "num_results": 5,    "objects": [     {       "contract_address": "0x2C8afBb062e16F0C5cFecAe5c032314A6038c611",        "created_at": null,        "expired": null,        "expires_at": null,        "ipfs_data": {         "category": "Vacation Rentals",          "description": "Built on the slopes of Hualalai Mountain in Kailua, Hawaii, the Mamalahoa Estate knows how to make a first impression. You enter the property through a grove of citrus and macadamia trees. A floating walkway takes you across a koi pond, surrounded by lush greenery and a waterfall. Once inside, the 5,391-square-foot home is comprised of a master and two guest suites, each with a private staircase leading down to the garden courtyard. A chef's kitchen with koa cabinetry looks onto a double-height living area. Flanked by sliding doors, the room opens to a veranda that overlooks two swimming pools and the Kona coastline. Consisting of 90 acres, the grounds also feature a driving range, tennis court, bocce courts, and a three-car garage.",          "location": "Kailua, Hawaii, US",          "name": "MAMALAHOA ESTATE",          "price": 8.5       },        "ipfs_hash": "QmZtQDL4UjQWryQLjsS5JUsbdbn2B27Tmvz2gvLkw7wmmb",        "owner_address": "0xf17f52151EbEF6C7334FAD080c5704D77216b732",        "price": "8.50",        "registry_id": null,        "units": 1     },      {       "contract_address": "0x4E205e04A1A8f230702fe51f3AfdCC38aafB0f3C",        "created_at": null,        "expired": null,        "expires_at": null,        "ipfs_data": {         "category": "Music",          "datetime": "2018-05-26T19:00:00.000Z",          "description": "Taylor Swift's Reputation Stadium Tour is the fifth world concert tour by American singer-songwriter Taylor Swift, in support of her sixth studio album, Reputation.",          "location": "Sports Authority Field at Mile High, Denver, CO, USA",          "name": "Taylor Swift's Reputation Tour",          "price": 0.3       },        "ipfs_hash": "QmfXRgtSbrGggApvaFCa88ofeNQP79G18DpWaSW1Wya1u8",        "owner_address": "0x627306090abaB3A6e1400e9345bC60c78a8BEf57",        "price": "0.30",        "registry_id": null,        "units": 23     },      {       "contract_address": "0x5677DB552d5Fd9911a5560CB0Bd40Be90a70EFf2",        "created_at": null,        "expired": null,        "expires_at": null,        "ipfs_data": {         "category": "Vacation Rentals",          "description": "Due to multiple limitations, the Zinc House goes against tradition to capture the best views of the sea. The contemporary structure is comprised of four interlocking volumes. A white wing houses the garage, leading to a two-story zinc entrance hall. From here, the home flips the conventional layout, putting bedrooms on the ground floor and the main living area above in a timber-clad box. Flanked by glazed panels, the kitchen and living room can overlook the garden in the rear and the coast ahead.",          "location": "-8.640509, 179.073778",          "name": "Zinc House",          "price": 3.999       },        "ipfs_hash": "QmTfozaMrUBZdYBzPgxuSC15zBRgLCEfQmWFZwmDHYGY1e",        "owner_address": "0xf17f52151EbEF6C7334FAD080c5704D77216b732",        "price": "3.00",        "registry_id": null,        "units": 1     },      {       "contract_address": "0x9390BCAc10a3FE3B85947A5780d68a2c805dEA64",        "created_at": null,        "expired": null,        "expires_at": null,        "ipfs_data": {         "category": "Cars & Trucks",          "description": "Introduced in 1971, the International Scout II rode on a stretched-wheelbase version of the rugged Scout chassis as a competitor to trucks like the larger Chevrolet Blazer. The highly customizable Scout was popular for work and racing, taking home a class win in the 1977 Baja 1000. This restored beautifully restored 1977 Scout II's customizations run more than skin deep, with a 6.0-liter GM engine and transmission to go along with the wheels and suspension lift.",          "location": "Los Angeles, CA, USA",          "name": "1977 INTERNATIONAL SCOUT II",          "price": 0.6       },        "ipfs_hash": "QmZD8wZWEqzKwvEtGWXzCb3MuXvmxLdCxXGHMRocQFnpoy",        "owner_address": "0x627306090abaB3A6e1400e9345bC60c78a8BEf57",        "price": "0.60",        "registry_id": null,        "units": 1     },      {       "contract_address": "0xABEBF5e71a6Cd15136c56141dE7d495757cC21e3",        "created_at": null,        "expired": null,        "expires_at": null,        "ipfs_data": {         "category": "Vacation Rentals",          "description": "Overlooking Lake Llanquihue, Casa Wulf is inspired by the terrain. The home sits on a steep slope. This lead to its three-story design, creating a natural balcony facing the water. Among the levels, the main living area is at the center, with the bedrooms above and a basement workshop below. Each floor was constructed using a different system, resulting in a range of facades. Their orientation takes advantage of the incoming sunlight and while also exposing the interiors to the surrounding landscape.",          "location": "-41.010387, -72.763702",          "name": "Casa Wolf",          "price": 1.5       },        "ipfs_hash": "QmVYeipL2JWFkpWsGqNNXDFUVAmPWEEK8u3Q45CZ1YrZPf",        "owner_address": "0x627306090abaB3A6e1400e9345bC60c78a8BEf57",        "price": "1.50",        "registry_id": null,        "units": 1     }   ],    "page": 1,    "total_pages": 1 }
and purchases:
{   "num_results": 3,    "objects": [     {       "buyer_address": "0x821aEa9a577a9b44299B9c15c88cf3087F3b5544",        "buyer_timeout": "2018-07-10T18:28:58+00:00",        "contract_address": "0x10A5C71EAF20dcFfD20C3fafb34183f57bEB2EB8",        "created_at": "2018-06-19T18:28:58+00:00",        "listing_address": "0x4E205e04A1A8f230702fe51f3AfdCC38aafB0f3C",        "stage": "3"     },      {       "buyer_address": "0xC5fdf4076b8F3A5357c5E395ab970B5B54098Fef",        "buyer_timeout": "2018-07-10T18:28:58+00:00",        "contract_address": "0x125068bdf1807019822eF4095AB6F83A222B3cCE",        "created_at": "2018-06-19T18:28:57+00:00",        "listing_address": "0x4E205e04A1A8f230702fe51f3AfdCC38aafB0f3C",        "stage": "2"     },      {       "buyer_address": "0xC5fdf4076b8F3A5357c5E395ab970B5B54098Fef",        "buyer_timeout": "1970-01-01T00:00:00+00:00",        "contract_address": "0xCa163A64f8c3d8A6c15A46f95DA492476Ef3E613",        "created_at": "2018-06-19T18:28:57+00:00",        "listing_address": "0x4E205e04A1A8f230702fe51f3AfdCC38aafB0f3C",        "stage": "1"     }   ],    "page": 1,    "total_pages": 1 }
What happens if you do the following:

stop origin-js and the worker process: pm2 stop origin-js pm2 stop celery
reset the blockchain data: pm2 start origin-js
tail the logs, wait for origin-js to complete startup: pm2 logs origin-js
run the worker pm2 start celery, wait for a run to complete (> 10 seconds)

Also, something of a nitpick, though if following REST conventions should the endpoints for retrieving all items be /listings and purchases?

@ambertch Tried your steps, same result. I'll keep looking into it.
Agree on the nitpick. I created an issue for it. https://github.com/OriginProtocol/bridge-server/issues/91

@ambertch Tried again today and was able to get everything working. I think it had something to do with contract ABIs getting out of sync during development. Thanks for your help!


Fix fix /rest/v1/query_profile action.

Proposed changes
PR15898 add jobId column, so /rest/v1/query_profile action should modify the href field.
The result is as follows:

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.74 seconds
load time: 501 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116142847_clickbench_pr_81295.html


Formulas suddenly get mangled (on save?)

In the same sheet as bug #9, formulas get mangled either on exit (when I click on another obsidian tab), or on re-entry (when I click on the spreadsheet tab again). Specifically, the multiply sign '*' gets replaced by an underscore sign '_' in a number of cells, causing the formula to fail of course.

fix 1.2.1


[Framework] Support for Android Fullscreen Modes

This adds support for varying Android fullscreen modes, which affect the visibility of system ui overlays like the status and bottom navigation bars.

lean back - a fullscreen mode that brings system overlays into view by tapping anywhere on the screen

this tap is not received by the application

immersive - a fullscreen mode that brings system overlays into view by swiping at the edge of the screen

this swipe is not received by the framework

immersive sticky - a fullscreen mode that brings system overlays into view by swiping at the edge of the screen

this swipe is received by the framework

edge to edge - this makes the application take up the fullscreen, with the overlays hovering on top

For the first three modes, there is also a new callback exposed so developers can be notified when the system overlays change, and what state they are in.
Finally, this change also updates the SystemChromeStyle, adding the ability to override the translucent scrim that is automatically added in Android to ensure proper contrast with system overlays.
Engine side: https://github.com/flutter/engine/pull/25785
Related Issues:

Fixes https://github.com/flutter/flutter/issues/35748
https://github.com/flutter/flutter/issues/39061 will need follow up to implement
Fixes https://github.com/flutter/flutter/issues/40974
Fixes https://github.com/flutter/flutter/issues/44033
Fixes https://github.com/flutter/flutter/issues/63761
Fixes https://github.com/flutter/flutter/issues/69999

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Any update on this PR?

Any update on this PR?

Yes! Thanks @Kotlinovsky! I've been away for a bit, but expect to push updates by tomorrow. :D

Any updates with this PR?

Engine changes have landed, just waiting on the engine roll and this should be good to go! :)

Waiting a bit further for the engine change to roll to dev, there are some affected customers internally that are affected by the lower level java changes. Working on migrating them now.

Update: Still waiting on the roll. 🙂  🤞

https://github.com/flutter/engine/pull/27018 is the updated engine change

Updates?

The cirrus customer shard here is experiencing merge conflicts, which is odd. I am going to revert the dart fixes (which are causing the conflicts) and see if it resolves the failure. I can add them back after or in a follow up change.

That did not seem to make a difference, putting them back.

Hallelujah. Holy **** I have been waiting so long for this to be fixed. Thank you. Phew.

What flutter version we could expect for this fix to be shipped?

Thank you!
Equally important: Since this issue has been around for ages, and many people have done workarounds, would be great if there's documentation explaining the canonical way of handling this. Not to mention, in Android, users can change the navigation mode to "classic" or "gesture" anytime.


Despite it's given an InlineConfig object, a secondary build script (with Vite build API JS ) still uses vite.config.js

Describe the bug
On top of a primary build using vite.config.js (for multiple pages app) I execute a secondary build script (a build.mjs file) to get several JS files from another source directory into same output dist folder.
With Vite v3.1.2 (and prior) I do not have an issue and output js files are written to dist next to files coming from a previous step as expected.
However after I updated to v3.1.3 today,  erroneous output files are written on top of previous ones.
As if Js files of secondary source folder are matched to each  input of rollupOptions in defineConfig argument of vite.config.js.
I've prepared an example project with two NPM scripts.
You can see the problem running

npm run build: only runs on src folder and then
npm run two-builds that executes a custom build script on a secondary source folder after previous default.

Reproduction
https://github.com/bogacg/vite-3-1-3-js-build-api-bug
System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
    Memory: 8.47 GB / 15.92 GB
  Binaries:
    Node: 18.8.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.18.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.42)
    Internet Explorer: 11.0.19041.1566

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This behavior was using a bug (#9086).
To stop reading config file automatically for build(), you'll need to set configFile: false.
https://vitejs.dev/guide/api-javascript.html#inlineconfig
  await build({
    build: {
      outDir: "./dist",
      lib: {
        ...lib,
        formats: ["es"],
      },
      emptyOutDir: false
    },
    configFile: false
  });


Add a nearby restaurant section

Add a section which shows the nearby restaurants based on the location selected in the map.

@Devansu-Yadav , @Swatishree-Mahapatra and I would like to work on this issue

Add a section which shows the nearby restaurants based on the location selected in the map.

It'll also show restaurants based on the current user's location.


Error: [ng-repeat:dupes] Duplicates in a repeater are not allowed issue

I'm using ng-repeat="product in products" to loop the list returned from Web API.
Even I added track by product.prod_Id, it still shows the following error message, in database, the type of prod_id field is a uniqueidentifier and I'm pretty sure that there is no duplicate records inside the list.
Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: product in products track by product.prod_Id, Duplicate key: b4a200c8-c472-4fda-8780-0002b0056fde
I have tried track by $index, it works. However, I just have 20 records in my list, but the interface showing 40 records and 20 records are duplicated from other 20 records.
Please fix in the next release, thanks for all of your effort.

@luck02 qq


[Test]: How do I get test cases for pass?

Is there any way to get test cases for passes? Like "insert-detensorize-transform" pass.

Let me make sure I understand your need correctly.
The pass "insert-detensorize-transform" insert a transform op, structure.detensorize, but not perform the detensorize transformation  yet.
The performing transform op will happen at "transform-dialect-interpreter".
does your question refer to a test for a) performing detensorize transformation or b) just inserting transform op?

https://github.com/bytedance/byteir/pull/86
You can find the test in this PR.


Create file of CP plugin that can be uploaded to Marketplace

Create a lplug4 file of CP plugin that can be uploaded to Marketplace. Include a default profile with pre-assigned actions to be used in FCP app. The default profile is to be delivered still.
(Let's see a LINK to the CP plugin as minimum viable solution. Pauli would be ok with that solution, but from user's point of view, let's make it as straight forward as possible:
Ideally, users can simply click the Install button in Marketplace and can start using the plugin when installation has finished.)

I'm going to close this for now as I believe the general consensus is that we'll just keep the Loupedeck Plugin embedded within the CommandPost application. Feel free to re-open if you disagree.


Support multiple videos in timeline

A video editor must support multiple videos on its timeline in order to be usable.  Videos must be visually distinct and have some indicator of their source information

May be added in 20e0d08


Unrecognized self-referencing @scope/package

Bug Report

🔎 Search Terms

self-referencing
self-referencing package
node12
module resolution

🕗 Version & Regression Information
TypeScript 4.5 Beta and TypeScript Nightly
🙁 Actual behavior
Given the next package.json:
{
    "name": "@scope/package",
    ...
}

And the following tsconfig.json:
{
    "module": "node12",
    ...
}

The following code does not compile:
import * as src from "@scope/package"

The obtained error is Cannot find module '@scope/package' or its corresponding type declarations.
🙂 Expected behavior
TSC currently compile self-referencing package that has unscoped names. TSC should also compile self-referencing scoped packages such as @scope/package.

do you have exports in package.json as required by Node.js?
https://nodejs.org/api/packages.html#packages_self_referencing_a_package_using_its_name

@IllusionMH Yes. I updated the issue to highlight this. Thanks.

Also just checking that your ... in tsconfig.json does not include moduleResolution (which is implied by module but can be overridden).

@andrewbranch
Yes this field is not present.


Chat Engines do not provide source nodes

The response from a chat engine provides no way to trace back to the source nodes used.
Can we add a hook to provide a way to cite sources?
It looks like some chat engines provide source, and others do not.
Chat engines that currently do not provide sources:

streamChat in ContextChatEngine: https://github.com/run-llama/LlamaIndexTS/blob/85da7985388d92cb71f60f34e7d205fa142a58e3/packages/core/src/ChatEngine.ts#L333
both chat and streamChat of HistoryChatEngine: https://github.com/run-llama/LlamaIndexTS/blob/85da7985388d92cb71f60f34e7d205fa142a58e3/packages/core/src/ChatEngine.ts#L430 and https://github.com/run-llama/LlamaIndexTS/blob/85da7985388d92cb71f60f34e7d205fa142a58e3/packages/core/src/ChatEngine.ts#L404

Fixed in<EMAIL_ADDRESS>


Implement runtime version checks in set_code

Check that the new runtime code given to set_code fullfills some
requirements:

spec_name matches
spec_version does not decreases
impl_version does not decreases
Either spec_version and impl_version increase

So we can't brick the chain by supplying the empty code block anymore?

looks like a promising direction.


Get the mesh of DQ blending skinning

I have implemented the dqbs in my own project. And I want to get the mesh of human model of dqbs in obj format. However, I found i get the obj model of lbs. How can i get the mesh of dqbs? Thank you.

The skinned vertex positions are passed to a vertex shader through textures:
https://github.com/ConstantineRudenko/DQ-skinning-for-Unity/blob/d519c5e7bbbbaad38064cb6fdd3224c30a03d922/Code/DQ skinning/DualQuaternionSkinner.cs#L144-L157
If you want to extract skinned vertex positions, you need to read them manually from these textures. The packing format is in the comment above. Here is how the shader extracts the vertex positions:
https://github.com/ConstantineRudenko/DQ-skinning-for-Unity/blob/d519c5e7bbbbaad38064cb6fdd3224c30a03d922/Code/DQ skinning/Shaders/Material/HackedStandard/HackedStandard.shader#L153-L169


Add hjson support for user configs

Also added tests to verify DeepSpeed configs are properly loaded from dict, json, and hjson formats.
@stas00 @jeffra

whoohoo! Finally this is happening!
Thank you so much, Michael and the team!


Create Transformation task for Treatment_summary

As a developer, I want to have a Luigi task that transforms the data/metadata given by providers into a suitable format for the entity Treatment_summary.
Design
Database Schema

Create entry in scripts/init.sql for the creation of the table, pk and fks.
Create entry in etl/workflow/transformer.py with the class TransformModel.
Create entry in etl/jobs/transformation/spark_transformation_job.py
Create job etl/jobs/transformation/treatment_summary_transformer_job.py
Create entry in luigi.cfg
Create entry in etl/workflow/loader.py

Acceptance Criteria

[ ] Table model was created according with the designed database schema
[ ] The transformation task can be executed and it finishes correctly
[ ] Data in the Treatment_summary table is the expected one for the provider(s)

this is no longer relevant. Closing.


Stm32

Hello, I want to send battery info to my autopilot orange cube from my stm32f405 based board. So far I was able to send data(bytes) to cube with can communication on Arduino IDE. I want to switch to UAVCAN but I dont know how. Can you help me please?

UAVCAN no longer exists, the project is now called Cyphal. Start here:

https://opencyphal.org/guide
https://github.com/OpenCyphal/demos


Gulp stdout full stacktrace

I have a Ubuntu 12.04 server running Node 6.2, and, whenever I run gulp, I get a crazy stacktrace piped into stdout. e.g.:
vx:whatisjasongoldstein$ gulp help
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x28d7857d <JS Object>#0#
    1: .node [module.js:568] [pc=0x3ddf0383] (this=0x372a7e2d <an Object with deprecated map 0x4f80bddd>#1#,module=0x522db8a1 <a Module with map 0x4f80c0c9>#2#,filename=0x522db835 <String[95]: /home/jason/sites/whatisjasongoldstein/node_modules/node-sass/vendor/linux-ia32-48/binding.node>)
    2: load [module.js:458] [pc=0x3dd288fa] (this=0x522db8a1 <a Module with map 0x4f80c0c9>#2#,filename=0x522db835 <String[95]: /home/jason/sites/whatisjasongoldstein/node_modules/node-sass/vendor/linux-ia32-48/binding.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:417] [pc=0x3dd2857a] (this=0x28d080c9 <undefined>,module=0x522db8a1 <a Module with map 0x4f80c0c9>#2#,filename=0x522db835 <String[95]: /home/jason/sites/whatisjasongoldstein/node_modules/node-sass/vendor/linux-ia32-48/binding.node>)
    4: _load [module.js:409] [pc=0x3dd25216] (this=0x372a7e6d <JS Function Module (SharedFunctionInfo 0x3721c37d)>#3#,request=0x522daf35 <String[95]: /home/jason/sites/whatisjasongoldstein/node_modules/node-sass/vendor/linux-ia32-48/binding.node>,parent=0x522a3629 <a Module with map 0x4f80c0c9>#4#,isMain=0x28d08161 <false>)

This goes on for another several thousand lines of noise.
My tasks work just fine, they just pipe madness into stdout.
Any idea why or what I can do to prevent this?

(And it does not happen with regular node scripts, which is why I think it could be a gulp issue.)

Native module, not gulp. You need to recompile them when you upgrade node...


add browser image with node 14.7 and chrome 84

 node version:    v14.7.0
 npm version:     6.14.4
 yarn version:    1.22.4
 debian version:  10.3
 Chrome version:  Google Chrome 84.0.4147.105
 git version:     git version 2.20.1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If wanted, I can also push an image with firefox, but don't have any sample project to test it.


Links not opening in new tab as it mentioned

In the https://docs.mattermost.com/ page, we can a menu item for Develop with Mattermost with a open in new tab icon at the end. The expected behaviour is, it should open in a new tab when we click the link.
Reproduce

Go to Mattermost Docs page
Click the Develop with Mattermost menu at  left sidebar menu (5th menu)

Expected Behaviour
It should open the link in a new tab
Current Behaviour
It is opening in the current tab
@cwarnermm @lindy65

Thanks for logging this issue, @devharipragaz007!
We're running a Mattermost Docathon, and if you're interested in participating, this issue would count as participation. You're most welcome to join us on the Mattermost Community Server to learn more.

@cwarnermm I would like to work on this. Feel free to assign this to me. Thanks.

Thank you so much, @Rutam21! Really appreciate your help with this!


NAND support for Variscite var-som-solo

And now, NAND on imx6ul-var-dart is validated.

I also cleaned up and tested in all configurations, the loading of the splash bitmap from the active root filesystem.


Wire up "Download data" button for VMware providers to MA payload API

We need to sync with Peter about how to connect to his endpoint for collecting the Migration Analytics payload for VMware providers, which will be connected to our "Download data" button on that page.

API support is implemented in https://github.com/konveyor/virt-operator/pull/26.
The new API URL for the payload service will be available as inventoryPayloadApi in virtMeta.json.
The request will need to be of the form /api/v1/extract?providers=test1,test2 where test1 and test2 are provider names. Unclear if we also need to pass namespaces in the request, sorting that out with Peter and Jeff now.
To make the payload request, we can either make a hyperlink to the API URL and let the browser natively handle it as a file download (might hang depending on how long it takes to bundle and whether the API streams the response) or we can do what we did in IMS (use an AJAX fetch to load the whole response into memory, then write it to a file with the JS FileWriter API). We should try both and see what works best.

For reference, this is how saving the file worked in the CloudForms implementation (we can probably do something better, though): https://github.com/RedHatCloudForms/cfme-migration_analytics/blob/14f92e54defc495f4adce1f729ca719cd90cf136/app/javascript/react/screens/App/Analytics/redux/analyticsActions.js#L80-L97


Should val be added to the training when submitted on the official website?

Hello, do you need to add the val dataset to the training to submit your results on the KITTI official website? I did so, but the accuracy decreased by 3 percentage points. Can you tell me the reason for this?

The data distribution of val and test split of KITTI dataset is a bit different. Training with the full 7k training data doesn't necessarily mean a good results.

Thank you very much for your reply.
Does PV-RCNN use all data (train + val) as training data?

No. PointRCNN / PartA2 used 50% train+val set for evaluating on test split, and PV-RCNN used 80% train+val set for evaluating on test split.

No. PointRCNN / PartA2 used 50% train+val set for evaluating on test split, and PV-RCNN used 80% train+val set for evaluating on test split.

Your reply has helped me a lot. But I'm a little confused. Does PV-RCNN use (80%train+100%val) or (80%train+20%val)?

By the way, when I train the model, should I use the gt database of train split+val split or just the gt database, of train split or build the gt-base? based on the percentage of each split, such as (50%train+50%val)? How did you do it?

Generally I only used the train gt database. However, for submitting to test server, of course you could use train+val gt database.

Thx


Add routine to relabel qubit IDs of a PauliSum

I also fixed a failing test in quantum_die.py

cool. we're getting ready to cut 2.0.0, so this will go in after

can you merge master and address the flake8 issues?


strictExportDeclareModifiers gives incorrect error message

See DefinitelyTyped/DefinitelyTyped#32884 for the correct repro. It says that declare is redundant in
declare namespace X {
}
export { X };

but it should actually say that export is the correct keyword. The error doesn't happen with export = X because there is a special exemption.

Probably a duplicate of #184