[BUG] Deno validator

Which module is this from?

datalad
What is the issue?

Deno validator warning and errors
What was your expected behavior?

Full pass with no errors
How can we reproduce this?

Code: https://github.com/bids-standard/bids-validator/issues/2129
Any additional context?

[ ] 1 TODO ISSUEJSON sidecar

	[WARNING] JSON_KEY_RECOMMENDED A JSON file is missing a key listed as recommended.
		DatasetType
		/dataset_description.json

		GeneratedBy
		/dataset_description.json

		SourceDatasets
		/dataset_description.json

	Please visit https://neurostars.org/search?q=JSON_KEY_RECOMMENDED for existing conversations about this issue.

[ ] 2 Potentially false alarm? https://github.com/bids-standard/bids-validator/issues/2128

	[WARNING] SIDECAR_KEY_RECOMMENDED A data file's JSON sidecar is missing a key listed as recommended.
	Please visit https://neurostars.org/search?q=SIDECAR_KEY_RECOMMENDED for existing conversations about this issue.

[ ] 3 TODO HED tag in task-alignvideo. Unit and HED tag

	[WARNING] HED_WARNING The validation on this HED string returned a warning.
		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv - WARNING: [UNITS_MISSING] No unit specified. Using "m" as the default - "X-position/45.62". TSV line: 11. (For more information on this HED warning, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#units-missing.)
		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv - WARNING: [UNITS_MISSING] No unit specified. Using "m" as the default - "X-position/35.0". TSV line: 12. (For more information on this HED warning, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#units-missing.)

		75994 more files with the same issue

	Please visit https://neurostars.org/search?q=HED_WARNING for existing conversations about this issue.

[ ] 4 TODOAdd column descriptor in metadata .json to match events.tsv
- [ ] task-shortvideo
- [ ] task-fractional

	[WARNING] TSV_ADDITIONAL_COLUMNS_UNDEFINED A TSV file has extra columns which are not defined in its associated JSON sidecar
		response_label
		/sub-0001/ses-03/func/sub-0001_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv
		/sub-0133/ses-03/func/sub-0133_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv

		97 more files with the same issue

		subtask_type
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		199 more files with the same issue

		event_type
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		196 more files with the same issue

		value
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractionaltomsaxe_acq-mb8_run-01_events.tsv

		101 more files with the same issue

		response_accuracy
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		196 more files with the same issue

		question
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		47 more files with the same issue

		participant_response
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		46 more files with the same issue

		normative_response
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		46 more files with the same issue

		button_press
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		98 more files with the same issue

		cue_location
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

		target_location
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

		trial_index
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_ADDITIONAL_COLUMNS_UNDEFINED for existing conversations about this issue.

[ ] 5 TODO task-fractional onset order sort

	[WARNING] EVENT_ONSET_ORDER The onset column in events.tsv files should be sorted.

		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		97 more files with the same issue

	Please visit https://neurostars.org/search?q=EVENT_ONSET_ORDER for existing conversations about this issue.

[ ] 6 Need specific files since these seem to be less systematic. N = 66 files

	[WARNING] SUSPICIOUSLY_SHORT_EVENT_DESIGN The onset of the last event is less than half the total duration of the corresponding scan.
This design is suspiciously short.

		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz
		/sub-0003/ses-01/func/sub-0003_ses-01_task-social_acq-mb8_run-01_bold.nii.gz

		66 more files with the same issue

	Please visit https://neurostars.org/search?q=SUSPICIOUSLY_SHORT_EVENT_DESIGN for existing conversations about this issue.

[ ] 7 SUSPICIOUSLY_LONG_EVENT_DESIGN The onset of the last event is after the total duration of the corresponding scan. Get actual list N = 12

	[WARNING] SUSPICIOUSLY_LONG_EVENT_DESIGN The onset of the last event is after the total duration of the corresponding scan.
This design is suspiciously long.

		/sub-0004/ses-02/func/sub-0004_ses-02_task-faces_acq-mb8_run-01_bold.nii.gz
		/sub-0005/ses-04/func/sub-0005_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz

		12 more files with the same issue

	Please visit https://neurostars.org/search?q=SUSPICIOUSLY_LONG_EVENT_DESIGN for existing conversations about this issue.

[x] 8 TODO sub-0009 task-narratives, no events data, just func. How to fix?

	[WARNING] TSV_VALUE_INCORRECT_TYPE_NONREQUIRED A value in a column did match the acceptable type for that column headers specified format.
		response_time
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

		stim_file
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_VALUE_INCORRECT_TYPE_NONREQUIRED for existing conversations about this issue.

[ ] 9 TODO task-fractional. Either name the task differently or temporarily remove the files

	[ERROR] HED_ERROR The validation on this HED string returned an error.
		/task-fractionalmemory_events.json - TypeError: Cannot convert undefined or null to object
		/task-fractionaltomsaxe_events.json - ERROR: [PLACEHOLDER_INVALID] HED value string "Property/Data-property/Data-marker/Temporal-marker/Onset" is missing a required placeholder. Sidecar key: "onset". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#placeholder-invalid.)

		11251 more files with the same issue

	Please visit https://neurostars.org/search?q=HED_ERROR for existing conversations about this issue.

[x] 10 DONE

	[ERROR] NOT_INCLUDED Files with such naming scheme are not part of BIDS specification. This error is most commonly caused by typos in file names that make them not BIDS compatible. Please consult the specification and make sure your files are named correctly. If this is not a file naming issue (for example when including files not yet covered by the BIDS specification) you should include a ".bidsignore" file in your dataset (see https://github.com/bids-standard/bids-validator#bidsignore for details). Please note that derived (processed) data should be placed in /derivatives folder and source data (such as DICOMS or behavioural logs in proprietary formats) should be placed in the /sourcedata folder.
		/code/spacetop-prep/.github/ISSUE_TEMPLATE/
		/code/spacetop-prep/spacetop_prep/

		1 more files with the same issue

	Please visit https://neurostars.org/search?q=NOT_INCLUDED for existing conversations about this issue.

[ ] 11 TODO update Intended for. Need to run populate_indended_for

	[ERROR] INTENDED_FOR 'IntendedFor' field needs to point to an existing file.
Files must be subject-relative paths or BIDS URIs.

		/sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-ap_run-01_epi.nii.gz
		/sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-pa_run-01_epi.nii.gz

		192 more files with the same issue

	Please visit https://neurostars.org/search?q=INTENDED_FOR for existing conversations about this issue.

[x] NOT this issue TODO only the first trial has the task-alignvideo folder declared. Fix
[ ]

	[ERROR] STIMULUS_FILE_MISSING A stimulus file was declared but not found in the dataset.

		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv
		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-02_events.tsv

		175 more files with the same issue

	Please visit https://neurostars.org/search?q=STIMULUS_FILE_MISSING for existing conversations about this issue.

[ ] 13 Not sure. Is it because it has 219 trials?

	[ERROR] HED_INTERNAL_ERROR An internal error occurred during HED validation.
		/sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-01_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)
		/sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-02_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)

		314 more files with the same issue

	Please visit https://neurostars.org/search?q=HED_INTERNAL_ERROR for existing conversations about this issue.

[x] 14 IGNORE

	[ERROR] TSV_VALUE_INCORRECT_TYPE A value in a column did match the acceptable type for that column headers specified format.
		onset
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

		duration
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_VALUE_INCORRECT_TYPE for existing conversations about this issue.

[x] 15 IGNORE

	[ERROR] EMPTY_FILE Empty files not allowed.
		/sourcedata/d_beh/

	Please visit https://neurostars.org/search?q=EMPTY_FILE for existing conversations about this issue.

[ ] 16 delete

	[ERROR] SIDECAR_WITHOUT_DATAFILE A json sidecar file was found without a corresponding data file
		/task-fractionalmemory_events.json

	Please visit https://neurostars.org/search?q=SIDECAR_WITHOUT_DATAFILE for existing conversations about this issue.

      Summary:                           Available Tasks:        Available Modalities:
      26363 Files, 2.22 TB               alignvideo              MRI
      117 - Subjects 4 - Sessions        faces
                                         fractional
                                         narratives
                                         shortvideo
                                         social

If you have any questions, please post on https://neurostars.org/tags/bids.

[ ] TODO ISSUE 111.1 JSON sidecar

	[WARNING] JSON_KEY_RECOMMENDED A JSON file is missing a key listed as recommended.
		DatasetType
		/dataset_description.json

		GeneratedBy
		/dataset_description.json

		SourceDatasets
		/dataset_description.json

	Please visit https://neurostars.org/search?q=JSON_KEY_RECOMMENDED for existing conversations about this issue.

	[WARNING] SIDECAR_KEY_RECOMMENDED A data file's JSON sidecar is missing a key listed as recommended.

	Please visit https://neurostars.org/search?q=SIDECAR_KEY_RECOMMENDED for existing conversations about this issue.

[ ] TODO HED tag in task-alignvideo. Unit and HED tag
[WARNING] HED_WARNING The validation on this HED string returned a warning.
/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv - WARNING: [UNITS_MISSING] No unit specified. Using "m" as the default - "X-position/45.62". TSV line: 11. (For more information on this HED warning, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#units-missing.)
/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv - WARNING: [UNITS_MISSING] No unit specified. Using "m" as the default - "X-position/35.0". TSV line: 12. (For more information on this HED warning, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#units-missing.)
  75994 more files with the same issue

Please visit https://neurostars.org/search?q=HED_WARNING for existing conversations about this issue.

[ ] TODOAdd column descriptor in task-shortvideo metadata .json
- [ ] task-shortvideo
- [ ] task-fractional

	[WARNING] TSV_ADDITIONAL_COLUMNS_UNDEFINED A TSV file has extra columns which are not defined in its associated JSON sidecar
		response_label
		/sub-0001/ses-03/func/sub-0001_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv
		/sub-0133/ses-03/func/sub-0133_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv

		97 more files with the same issue

		subtask_type
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		199 more files with the same issue

		event_type
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		196 more files with the same issue

		value
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractionaltomsaxe_acq-mb8_run-01_events.tsv

		101 more files with the same issue

		response_accuracy
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		196 more files with the same issue

		question
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		47 more files with the same issue

		participant_response
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		46 more files with the same issue

		normative_response
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		46 more files with the same issue

		button_press
		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		98 more files with the same issue

		cue_location
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

		target_location
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

		trial_index
		/sub-0003/ses-04/func/sub-0003_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0009/ses-04/func/sub-0009_ses-04_task-fractional_acq-mb8_run-01_events.tsv

		46 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_ADDITIONAL_COLUMNS_UNDEFINED for existing conversations about this issue.

[ ] TODO task-fractional onset order sort

	[WARNING] EVENT_ONSET_ORDER The onset column in events.tsv files should be sorted.

		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-01_events.tsv
		/sub-0001/ses-04/func/sub-0001_ses-04_task-fractional_acq-mb8_run-02_events.tsv

		97 more files with the same issue

	Please visit https://neurostars.org/search?q=EVENT_ONSET_ORDER for existing conversations about this issue.

[ ] Need specific files since these seem to be less systematic. N = 66 files

	[WARNING] SUSPICIOUSLY_SHORT_EVENT_DESIGN The onset of the last event is less than half the total duration of the corresponding scan.
This design is suspiciously short.

		/sub-0133/ses-04/func/sub-0133_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz
		/sub-0003/ses-01/func/sub-0003_ses-01_task-social_acq-mb8_run-01_bold.nii.gz

		66 more files with the same issue

	Please visit https://neurostars.org/search?q=SUSPICIOUSLY_SHORT_EVENT_DESIGN for existing conversations about this issue.

[ ] SUSPICIOUSLY_LONG_EVENT_DESIGN The onset of the last event is after the total duration of the corresponding scan. Get actual list N = 12

	[WARNING] SUSPICIOUSLY_LONG_EVENT_DESIGN The onset of the last event is after the total duration of the corresponding scan.
This design is suspiciously long.

		/sub-0004/ses-02/func/sub-0004_ses-02_task-faces_acq-mb8_run-01_bold.nii.gz
		/sub-0005/ses-04/func/sub-0005_ses-04_task-fractional_acq-mb8_run-01_bold.nii.gz

		12 more files with the same issue

	Please visit https://neurostars.org/search?q=SUSPICIOUSLY_LONG_EVENT_DESIGN for existing conversations about this issue.

[ ] TODO sub-0009 task-narratives, no events data, just func. How to fix?

	[WARNING] TSV_VALUE_INCORRECT_TYPE_NONREQUIRED A value in a column did match the acceptable type for that column headers specified format.
		response_time
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

		stim_file
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_VALUE_INCORRECT_TYPE_NONREQUIRED for existing conversations about this issue.

[ ] TODO task-fractional. Either name the task differently or temporarily remove the files

	[ERROR] HED_ERROR The validation on this HED string returned an error.
		/task-fractionalmemory_events.json - TypeError: Cannot convert undefined or null to object
		/task-fractionaltomsaxe_events.json - ERROR: [PLACEHOLDER_INVALID] HED value string "Property/Data-property/Data-marker/Temporal-marker/Onset" is missing a required placeholder. Sidecar key: "onset". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#placeholder-invalid.)

		11251 more files with the same issue

	Please visit https://neurostars.org/search?q=HED_ERROR for existing conversations about this issue.

[x] DONE

	[ERROR] NOT_INCLUDED Files with such naming scheme are not part of BIDS specification. This error is most commonly caused by typos in file names that make them not BIDS compatible. Please consult the specification and make sure your files are named correctly. If this is not a file naming issue (for example when including files not yet covered by the BIDS specification) you should include a ".bidsignore" file in your dataset (see https://github.com/bids-standard/bids-validator#bidsignore for details). Please note that derived (processed) data should be placed in /derivatives folder and source data (such as DICOMS or behavioural logs in proprietary formats) should be placed in the /sourcedata folder.
		/code/spacetop-prep/.github/ISSUE_TEMPLATE/
		/code/spacetop-prep/spacetop_prep/

		1 more files with the same issue

	Please visit https://neurostars.org/search?q=NOT_INCLUDED for existing conversations about this issue.

[ ] TODO update Intended for. Need to run populate_indended_for

	[ERROR] INTENDED_FOR 'IntendedFor' field needs to point to an existing file.
Files must be subject-relative paths or BIDS URIs.

		/sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-ap_run-01_epi.nii.gz
		/sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-pa_run-01_epi.nii.gz

		192 more files with the same issue

	Please visit https://neurostars.org/search?q=INTENDED_FOR for existing conversations about this issue.

[ ] TODO only the first trial has the task-alignvideo folder declared. Fix

	[ERROR] STIMULUS_FILE_MISSING A stimulus file was declared but not found in the dataset.

		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-01_events.tsv
		/sub-0001/ses-01/func/sub-0001_ses-01_task-alignvideo_acq-mb8_run-02_events.tsv

		175 more files with the same issue

	Please visit https://neurostars.org/search?q=STIMULUS_FILE_MISSING for existing conversations about this issue.

[ ] Not sure. Is it because it has 219 trials?

	[ERROR] HED_INTERNAL_ERROR An internal error occurred during HED validation.
		/sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-01_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)
		/sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-02_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)

		314 more files with the same issue

	Please visit https://neurostars.org/search?q=HED_INTERNAL_ERROR for existing conversations about this issue.

[ ]  IGNORE

	[ERROR] TSV_VALUE_INCORRECT_TYPE A value in a column did match the acceptable type for that column headers specified format.
		onset
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

		duration
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-01_events.tsv - '"n/a"'
		/sub-0009/ses-02/func/sub-0009_ses-02_task-narratives_acq-mb8_run-02_events.tsv - '"n/a"'

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=TSV_VALUE_INCORRECT_TYPE for existing conversations about this issue.

[ ] IGNORE

	[ERROR] EMPTY_FILE Empty files not allowed.
		/sourcedata/d_beh/

	Please visit https://neurostars.org/search?q=EMPTY_FILE for existing conversations about this issue.

	[ERROR] SIDECAR_WITHOUT_DATAFILE A json sidecar file was found without a corresponding data file
		/task-fractionalmemory_events.json

	Please visit https://neurostars.org/search?q=SIDECAR_WITHOUT_DATAFILE for existing conversations about this issue.

      Summary:                           Available Tasks:        Available Modalities:
      26363 Files, 2.22 TB               alignvideo              MRI
      117 - Subjects 4 - Sessions        faces
                                         fractional
                                         narratives
                                         shortvideo
                                         social

If you have any questions, please post on https://neurostars.org/tags/bids.

@jungheejung I looked into this issue and now I do not think this warning could be elegantly avoided. HED expects a tag that takes values to have a specified unit followed it (https://hed-specification.readthedocs.io/en/latest/03_HED_formats.html#tags-that-take-values; please also see examples in the 3.2.2 section right above it). In our experiments the rating values are either without units (a relative number between 0 and 100) or in the unit of pixels, while pixel is not in the list of allowed units in HED (https://hed-specification.readthedocs.io/en/latest/Appendix_A.html#a-1-1-unit-classes-and-units). I will suggest that we ignore this warning for now.

Awesome, appreciate you taking a look into this HED warning @Zizhuang-Miao . In that case, we'll ignore for now.

re 6 -- you say

Some runs are indeed shorter than expected, due to partial data collection (e.g. participant had issue with trackball, scanner failure etc)

but it seems not "scanner failure" since it is events file shorter than data file so data collection was fine.
Overall, after you handle it (what about the other 60 ?) -- could be added to ignored I guess

[ ] Error 1

        [ERROR] HED_ERROR The validation on this HED string returned an error.
                /task-social_events.json - ERROR: [TAG_EXTENSION_INVALID] "Data-property" appears as "Property/Data-property" and cannot be used as an extension.
Indices ([object Object], ). (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#tag-extension-invalid
.)
                /task-social_events.json - ERROR: [TAG_EXTENSION_INVALID] "Data-property" appears as "Property/Data-property" and cannot be used as an extension.
Indices ([object Object], ). (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#tag-extension-invalid
.)

                9269 more files with the same issue

        Please visit https://neurostars.org/search?q=HED_ERROR for existing conversations about this issue.

[ ] ERROR 2

        [ERROR] NOT_INCLUDED Files with such naming scheme are not part of BIDS specification. This error is most commonly caused by typos in file names that make them not BIDS compatible. Please consult the specification and make sure your files are named correctly. If this is not a file naming issue (for example when including files not yet covered by the BIDS specification) you should include a ".bidsignore" file in your dataset (see https://github.com/bids-standard/bids-validator#bidsignore for details). Please note that derived (processed) data should be placed in /derivatives folder and source data (such as DICOMS or behavioural logs in proprietary formats) should be placed in the /sourcedata folder.
                /code/spacetop-prep/.github/ISSUE_TEMPLATE/
                /code/spacetop-prep/spacetop_prep/

                1 more files with the same issue

        Please visit https://neurostars.org/search?q=NOT_INCLUDED for existing conversations about this issue.

[ ] ERROR 3

        [ERROR] INTENDED_FOR 'IntendedFor' field needs to point to an existing file.
Files must be subject-relative paths or BIDS URIs.

                /sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-ap_run-01_epi.nii.gz
                /sub-0001/ses-01/fmap/sub-0001_ses-01_acq-mb8_dir-pa_run-01_epi.nii.gz

                188 more files with the same issue
        Please visit https://neurostars.org/search?q=INTENDED_FOR for existing conversations about this issue.

[ ] ERROR 4

        [ERROR] HED_INTERNAL_ERROR An internal error occurred during HED validation.
                /sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-01_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)
                /sub-0001/ses-02/func/sub-0001_ses-02_task-faces_acq-mb8_run-02_events.tsv - ERROR: [GENERIC_ERROR] Internal error - message: "Attempting to access the onset of a TSV row without one.". (For more information on this HED error, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#generic-error.)

                318 more files with the same issue

        Please visit https://neurostars.org/search?q=HED_INTERNAL_ERROR for existing conversations about this issue.

[x] ERROR 5

        [ERROR] STIMULUS_FILE_MISSING A stimulus file was declared but not found in the dataset.

                /sub-0001/ses-03/func/sub-0001_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv
                /sub-0133/ses-03/func/sub-0133_ses-03_task-shortvideo_acq-mb8_run-01_events.tsv

                121 more files with the same issue

        Please visit https://neurostars.org/search?q=STIMULUS_FILE_MISSING for existing conversations about this issue.

SOLUTION: git grep -l task-shortvideos/ | xargs sed -i -e 's,task-shortvideos/,task-shortvideo/,g'

[ ] ERROR 6

        [ERROR] EMPTY_FILE Empty files not allowed.
                /sourcedata/d_beh/

        Please visit https://neurostars.org/search?q=EMPTY_FILE for existing conversations about this issue.


az network application-gateway auth-cert show : clarification on certificate format

Is your feature request related to a problem? Please describe.
The authorization certificates of an application gateway can be found as follows:
az network application-gateway auth-cert show -g test-rg --gateway-name test-aag --name test.com --query data
Note: Argument values have been redacted to hide sensitive information
However, the certificate data is displayed in raw format. After trying around different options, I found that the certificate shown is base64 encoded CER certificate which was uploaded. To retrieve information from the certificate (like expiry date), the data needs to be base64 decoded first and then queried with openssl to retrieve the expiration date.
Example:
$ az network application-gateway auth-cert show -g test-rg --gateway-name test-aag --name test.com --query data -o tsv | base64 --decode | openssl x509 -enddate -noout
notAfter=Jul 30 12:00:00 2020 GMT
Describe the solution you'd like
It would be a good idea to add this as an example in the help message and documentation. It would be pretty helpful as without this information, it takes some effort to get the correct format and information. Please review this and provide guidance.

add to S174

@haroldrandom : Did you get a chance to check this. Would it be a good idea to add an example to the help and documentation explaining the returning certificate type. If yes, I can help submit a PR for it.

@haroldrandom : Did you get a chance to check this. Would it be a good idea to add an example to the help and documentation explaining the returning certificate type. If yes, I can help submit a PR for it.

Yes. please :) . Appreciated in ahead for helping us to improve this, Thanks!

@haroldrandom : Here is the PR to add the example to the help and documentation: https://github.com/Azure/azure-cli/pull/14856


[Backport 2.6] Remediate CVE-2022-1471 via snakeyaml bump

Description
Update snakeyaml version from 1.33 to 2.0 to patch CVE-2022-1471.
Issues Resolved
#6938
Check List

[ ] ~New functionality includes testing.~

[ ] ~All tests pass~

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hi @reta, I do not believe there are any active plans for 2.6.1 as a patch release. That being said, I think we generally act under the policy of always backporting from main to the 2.x, 2.latest, 1.x, 1.3 lines. So in this case, I was hoping to backport CVE fixes to 2.6 to be in compliance with this practice. Thank you for checking in.

Codecov Report

Merging #6939 (a93243b) into 2.6 (5bbb99a) will increase coverage by 0.34%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.6    #6939      +/-   ##
============================================
+ Coverage     70.38%   70.73%   +0.34%
+ Complexity    59204    58755     -449
============================================
  Files          4796     4728      -68
  Lines        284124   281197    -2927
  Branches      41299    40641     -658
============================================
- Hits         199980   198900    -1080
+ Misses        67414    65955    -1459
+ Partials      16730    16342     -388

Impacted Files
Coverage Δ

...a/org/opensearch/extensions/ExtensionsManager.java
47.01% <ø> (-0.07%)
:arrow_down:

... and 1099 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlfeng When is a release going to be cut for this?  Or when is a new image going to be pushed?  Looking to get this pushed through my security teams asap so we can deploy.

@tlfeng When is a release going to be cut for this? Or when is a new image going to be pushed? Looking to get this pushed through my security teams asap so we can deploy.

@tanner-bragg we have a release plan for 2.7 on April 18th which will take care of the CVE.

@tlfeng When is a release going to be cut for this? Or when is a new image going to be pushed? Looking to get this pushed through my security teams asap so we can deploy.

@tanner-bragg we have a release planned for 2.7 on April 18th which will take care of the CVE.

I saw the 2.7 release slipped a week.  Is this release going to land today?  We're still waiting for this CVE patch to hit production so we can use the database :(

@tanner-bragg it's not, if you haven't joined the public slack yet there's a discussion about it here and https://opensearch.org/releases.html will get updated shortly AFAIK @krisfreedain

@tanner-bragg you can also track the status of 2.7.0 using this GitHub issue

yes, we're working to have a definitive date by this evening. In the meantime, we've also published the list of PRs the team is working there here: https://forum.opensearch.org/t/opensearch-2-7-0-delayed/13847/2

@krisfreedain Good deal.  If May continues to slip, can you please consider a 2.6.1 release (if feasible) to patch the snakeyaml CVE out of the 2.6 release?  Are the helm charts tracking the 2.7 release for the same time line?

We will be updating helm-charts to use 2.7.0 version once it’s out. @zelinh @peterzhuamazon @prudhvigodithi

@tanner-bragg snakeyaml's version is being bumped in 2.7.0. The only exception that you might see is as it is a transient dependency via detekt in our observability plugin here, that is only a build time dependency and does not make it into the released artifacts. Hope that helps!


chore: mount networks dir from repo

Issue being fixed or feature implemented

I was making frequent mistakes keeping synchronisation between dual copies of the network configs between this repo and dash-network-configs. Mounting the devnet directory was another solution, but this meant I had to constantly create and destroy symlinks, and each time my .env file went missing.
What was done?

This change allows me to mount the entire repo to the directory, keeping only one canonical copy of the network configs for all devnets.
How Has This Been Tested?

Running the tool with the new symlink works.
Breaking Changes

None
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

Agreed to change scripts to look for configs in PWD and introduce an option to specify path if we want to look at the different directory.

Made unnecessary by modifying dash-network-configs instead


Fix move function body out of the widgets

It would be much better if there would be a function (void doSomething() { ... }) instead of leaving a function logic inside of a widget
// Instead of:

TextButton(
    child: const Text("Click Me"),
    onPressed: () { ... },
)

// Do:

// somewhere in the widget scope..
void doSomething() { ... }

// Widget body
TextButton(
    child: const Text("Click Me"),
    onPressed: doSomething,
)

Yeah good idea

Hey, @KalleHallden Can I take up this issue if it's up for grabs?
It would help me understand the codebase better for future contributions.

@ShivamMenda yes absolutely! Thank you

@KalleHallden I'll look into it thanks! While Creating the PR I'll also mention the file names and functions I changed so that it'll be easy to check and keep track.


Integrate Flutter with Webpack

Some tools allow you to create different plugins or extensions that contain UI written in HTML. However, many of these tools have restrictions like only allowing a single HTML file.
For example, if you want to create a Figma plugin, all your JS, HTML and CSS needs to be in a single file or accessible via a network call. This isn't a big issue for developers because of tools like Webpack, where you can specify an entry point and it loads all the dependencies into a single file.
It would be great if we could specify a dart file as the entry point for Webpack, which would then spit out a single HTML build asset. This way you can create UIs for plugins and extensions with Flutter. An example might be having a Figma plugin that gives you a catalog of the Flutter widgets available in the design system, or allowing you to preview your Figma design in an embedded Flutter app.

CC @yjbanov @ditman – interesting to ponder. Especially with element embedding, we have a chance to at least make it easy to package a flutter "widget"? "element"? "component"? that's easy to integrate somewhere else.

I'm not sure how far we can go with supporting bespoke technical constraints of environments like Figma. We want to take advantage of things modern browsers provide. Can you bundle wasm into HTML? Fonts? Would it mean that we can't defer load anything? How do we test it? Lots of interesting questions to ponder.
However, making it easy to embed Flutter into an existing page is something we can optimize for.

I'm working on a proposal for this. Part of the integration with webpack (or any bundler, really), is probably to make flutter.js play ball with ESModules, so people can import from it, in a way that webpack understands.
A bigger issue I see is integrating the flutter build process in a way that feels natural to webpack users. I guess we could have a flutter directory somewhere, and have a bundler plugin that knows how to call flutter build, then move our output around (or making flutter build have a configurable output location, most likely), but I don't know if that'd be enough to make the integration easy.

I've written a small doc to address how Flutter Web could integrate (a little bit better) with modern packers and ES Modules.

https://flutter.dev/go/web-declarative-bootstrap

I'm not sure if all the parts are in pieces, but we definitely need to some more work in the engine to make it a reality!

The Angular demo looks like an starting point for this, at least flutter.js got minified and handled by angular as if it were any other 3p script (main.dart.js is another story :))

https://github.com/flutter/samples/blob/main/web_embedding/ng-flutter/angular.json#L38

Looking forward to having this feature, as we need to integrate multiple Flutter apps as a separate micro-frontend. The problem with my PoC is that assets of Flutter apps get loaded from the host domain, even though I am able to load flutter.js and main.dart.js from CDN.

The problem with my PoC is that assets of Flutter apps get loaded from the host domain, even though I am able to load flutter.js and main.dart.js from CDN.

@jehuamanna maybe the assetBase init option can help? docs.

This worked.

The problem is that assetBase only seem to work for your own assets, but not for thid party dependencies. For example ... "wakelock_plus". I found out that loading the required "no_sleep.js" ignored the assetBase, so this resulted in a 404.

I'd say that's a bug in wakelock_plus, because I think they should be using the getAssetUrl API to fetch the assets, but they seem to be hard-coding URLs:
https://github.com/fluttercommunity/wakelock_plus/blob/91c531e1253e798ccb3a18497ce71e4b80065120/wakelock_plus/lib/src/web_impl/import_js_library.dart#L17-L27
(There might be a bug in the getAssetUrl method too, so let's not discard that!).
In any case @Blutchie, please start by creating a bug in wakelock_plus, and have them create one in flutter in case we need to fix our API!

The problem is that assetBase only seem to work for your own assets, but not for thid party dependencies. For example ... "wakelock_plus". I found out that loading the required "no_sleep.js" ignored the assetBase, so this resulted in a 404.

I'd say that's a bug in wakelock_plus, because I think they should be using the getAssetUrl API to fetch the assets, but they seem to be hard-coding URLs:
https://github.com/fluttercommunity/wakelock_plus/blob/91c531e1253e798ccb3a18497ce71e4b80065120/wakelock_plus/lib/src/web_impl/import_js_library.dart#L17-L27
(There might be a bug in the getAssetUrl method too, so let's not discard that!).
In any case @Blutchie, please start by creating a bug in wakelock_plus, and have them create one in flutter in case we need to fix our API!

Great find @ditman! When I was trying to solve this issue, I made a --profile build to analyze the main.dart.js, and this shared link contains exactly the function names that I fixed locally. I assumed those functions were part of Flutter, but they are from wakelock_plus. I will report the bug there!

The problem is that assetBase only seem to work for your own assets, but not for thid party dependencies. For example ... "wakelock_plus". I found out that loading the required "no_sleep.js" ignored the assetBase, so this resulted in a 404.

I'd say that's a bug in wakelock_plus, because I think they should be using the getAssetUrl API to fetch the assets, but they seem to be hard-coding URLs:
https://github.com/fluttercommunity/wakelock_plus/blob/91c531e1253e798ccb3a18497ce71e4b80065120/wakelock_plus/lib/src/web_impl/import_js_library.dart#L17-L27
(There might be a bug in the getAssetUrl method too, so let's not discard that!).
In any case @Blutchie, please start by creating a bug in wakelock_plus, and have them create one in flutter in case we need to fix our API!

Hi @ditman, I currently maintain wakelock_plus. Just curious where the change needs to be in the method in question:
String _libraryUrl(String url, String pluginName) {
  if (url.startsWith('./')) {
    url = url.replaceFirst('./', '');
    return './assets/packages/$pluginName/$url';
  }
  if (url.startsWith('assets/')) {
    return './assets/packages/$pluginName/$url';
  } else {
    return url;
  }
}

Should it merely swap out the hard-coded parts, assets/packages, with getAssetUrl?
String _libraryUrl(String url, String pluginName) {
  if (url.startsWith('./')) {
    url = url.replaceFirst('./', '');
    return getAssetUrl("$pluginName/$url");
  }
  if (url.startsWith('assets/')) {
    return getAssetUrl("$pluginName/$url");
  } else {
    return url;
  }
}

@ditman and @Blutchie, looks like I got it to work using getAssetUrl:
String _libraryUrl(String url, String pluginName) {
  if (url.startsWith('./')) {
    url = url.replaceFirst('./', '');
    return ui_web.assetManager.getAssetUrl('packages/$pluginName/$url');
  }
  if (url.startsWith('assets/')) {
    return ui_web.assetManager.getAssetUrl('packages/$pluginName/$url');
  } else {
    return url;
  }
}

I'll start creating a PR and release for this.

@diegotori thanks for taking care of this! Remember to try your changes in a target app outside of your repo to see if assets/$pluginName/$url is enough to locate assets from separate packages!

@diegotori thanks for taking care of this! Remember to try your changes in a target app outside of your repo to see if assets/$pluginName/$url is enough to locate assets from separate packages!

I'm trying to think of another package that uses this, which I maintain. chewie comes to mind, but so far, after setting breakpoints in wakelock_plus's example app, it did resolve the asset paths properly based on how the web app is built.
Nevertheless, debugging a web-based Flutter Integration Test from Android Studio, let alone debugging it in the IDE, is next to impossible, so it's rather difficult for me to verify that the changes work. Not to mention that I can't think of any way to automate this via Github Action.
wakelock_plus is a continuation of the original wakelock package, and as such, it was a near 1:1 port of what existed there nearly nine months ago. As a result, whatever web based bugs existed there and in this package, are now starting to bubble up.
If there was a way to automate Web based integration testing, with the ability to step through the code in Android Studio, that would help give me certainty in my changes.

@diegotori We have several examples of web integration tests in the flutter/plugins repo (almost all _web packages there have integration tests inside their example directory), that you may be able to use. We can discuss in a wakelock_plus issue if you want, to keep this one related to webpack :)


URL sitemap error message

Hi,
I've placed a URL sitemap of my website and getting this error message. How can I fix it? Any idea?

Thanks in advance.

@ViktorHolas is that an error you get when trying to create a project from the URL of your sitemap? Could you share that URL to us?

@wetneb yes, the URL is http://dumazahrada.eu/sitemap_index.xml

@ViktorHolas Which version of OpenRefine and which operating system are you using? It works fine for me.

@wetneb Im using version 2.7 on Windows, but now I tried it on my OSX and works fine.

Great! Then most likely the problem is independent from OpenRefine itself.

No problem on my Windows 10 installation (Open Refine 2.7)


Settings UI: Workspace has a lowercase w?

Not sure why it's lowercase and user is upper?

Lol, did you do something weird? Not sure how that's possible

Not that I'm aware of, happens in remotes as well:

Version: 1.44.0-insider (user setup)
Commit: d7d1147d6b764a48b789000c03088ee9afabcd8a
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

I tried on Windows too and don't see it. Could you set a breakpoint at this line in preferencesWidgets.ts and see if something crazy happens? Is the correct localized string retrieved and set as the action label?
this.workspaceSettings = new Action('workspaceSettings', localize('workspaceSettings', "Workspace"), '.settings-tab', false, () => ...
Or we can have a call and I can debug a bit

Was going to respond to this but I guess I forgot to hit the comment button. Pretty sure this is happening because of the en-GB language pack I'm using. Hit a similar issue in open recent.


Investigate how to release packages whose source contains ipynb files

Ideally these will not require the ipynb package at all at runtime. We could do some amount of pre-processing to make sure we ship .py files rather than .ipynb files, and dependency on IPython itself will depend on #6.
This totally requires us to have a solid documented understanding of how relative imports work (see #4)

If we really get this going we could maybe go all meta and write ipynb in ipynb :D

So there are various ways to do that:

have the "setup.py" to build a py-version of all the notebooks.
I'm going to assume that users won't modify an installed package :-)
Then it will require ipynb as install time. Though "show source" might be wrong-ish.

Require ipynb, an one .py files that "register" this particular packages as a prefix for which the import hook should work.

Yeah, I prefer 1 far more than 2. I suppose we just need a way to do pre-processing of files?

Yeah, I prefer 1 far more than 2. I suppose we just need a way to do pre-processing of files?

Should not be too hard.

This is done now, we have a setup_packages() implementation.


Add Support for SVD Decomposition

It would be great to have SVD factorization added to the list of supported operations.

Just a bump here. Having SVD support would be great.


Broken Links

According to travis ci the following links seem to be broken:

[L304] 521 http://jonathan.bergknoff.com/journal/building-good-docker-images
[L304] 521 http://jonathan.bergknoff.com/journal/building-better-docker-images

Solved, the problem was caused by a outage of the referenced servers


Add ChuteSafetyIndicator.netkan

Copy paste of KerbalStuffBot PR with avc line added.
Closes #1951

Passes local, passes Jenkins. Merging.


Remove neg overload as taco upstream fixed this

Ref: https://github.com/tensor-compiler/taco/pull/350


"fields" doesn't work as expected for "location"

What is happening:
If you don't specify "longitude" and "latitude" in "fields", "location" is not created, even if you requested it in "fields".
Why is it happening:
"location" is constructed from "longitude" and "latitude" property of the event.
Expected behaviour:
Construct "location" regardless whether "longitude" and/or "latitude" are specified in "fields".

Agreed on the behavior being a bug.

Fixed by #20/#22, thank you! :)


Elemental Barrage rebalance

Is your feature request related to a problem? Please describe.
Elemental Barrage seems to get really broken when paired with geniekind or magus, as you get a lot of d6 dices by using different elemental damages on the same round, which activates elemental barrage more than once.
Describe the solution you'd like
Maybe a homebrew solution to it like limiting it to activate one or two times at most would make it balanced.
Describe alternatives you've considered
Something like needing to do the other elemental damages on the next turn could also ease the problem, but this solution seems too harsh.

I think the best balance fix is to make it work as designed and only trigger off spells and spell like abilities  and not weapon attacks.
This would be a tad finicky for effects like Geniekind and Firebrand that are weapon attack damage boosts implemented as extra hits but those need to be converted to not be extra hits anyway to keep them from proccing Bane enchants and Mark of the Sun.

There is an experimental change that will be shipping in 1.11.0
In concept it is sort of a caster hybridized leading strike.

Every time you deal elemental damage to a creature with a spell, you apply an elemental mark to it. If during the next three rounds the marked target takes elemental damage from any source with a different element, the target is dealt additional Divine damage. The damage is 1d6 per mythic rank of your character.

at least Geniekind should be fixed, as apparently you can stack it, leading to 30d6 damage per attack if all four types are used (with elemental barrage).
With two weapons/monk that's like 8*30d6
The effect should not stack with itself, I guess. So that's a fix.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_dae4b0ee-7a63-47d2-80c4-63c2ffe46372/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_dae4b0ee-7a63-47d2-80c4-63c2ffe46372.git

Docs Build status updates of commit 615b928:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_main_2022-05-30-04-18-36 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Make SideCondition.assumeDefined total

Fixes #2561

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

I think this will achieve what we want, for refactoring assumeDefined:

data Partial a = Bottom | Defined a

instance Semigroup a => Semigroup (Partial a) where
    (<>) Bottom _ = Bottom
    (<>) _ Bottom = Bottom
    (<>) (Defined a) (Defined b) = Defined (a <> b)

instance Monoid a => Monoid (Partial a) where
    mempty = Defined mempty


Connected Texture missing

like this

Hi! Thank you for bringing this issue to my attention! The issue has been fixed in the latest version of the mod!
Check it out at:
CurseForge: https://www.curseforge.com/minecraft/mc-mods/createutilities
Modrinth: https://modrinth.com/mod/create-utilities


PRIMARY KEY only for table, FOREIGN TABLE not support it

hello @lfittl, why you not accept my pull request?

@ermolaev Sorry, been very busy. Thanks for your contribution!
It seems that this wouldn't work if the id column was not listed first in the table - is there a way we can implement this where it allows other columns to be listed in between?

Yes you are right!
I fixed it.

@ermolaev Sorry for not getting back about this - could you re-base this PR?

@ermolaev Your changes look good, could you rebase on top of current master?

@ermolaev @olleolleolle Hello. It's been a long time, but I'm wondering if there's still interest in getting this functionality into the gem?
If so, please confirm that. If you could expand on the use case a bit, and ideally include some sample schema that shows a positive and negative example, possibly as documentation, that would help understand the purpose and how to verify this functionality while avoiding a regression.
If there's no response here after a month, then we'll likely close this out. Thanks.


[Bug]: Resuming tasks lead to incorrect examples to label

Need to investigate more

Depracating create_task, will remove it in a future release


perl: substitute /bin/pwd with host pwd

Motivation for this change
/bin/pwd is replaced during the build with nix's version.
it was incorrectly set to the build-time pwd, this would set it to the host's pwd
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This definitely looks like a good fix but I'm not 100% sure if it's safe to merge; maybe it had something to do with perl being a bootstrapping dependency? @edolstra introduced this quirk so perhaps he should take a look.

btw: should I be putting PRs into staging?

Master is fine for most things; staging is for changes that are going to require massive rebuilds, as it gives hydra a chance to catch up before things hit the nixos channels.  Perl may actually be one of those things :-P
btw, here is a comment I found about the $pwd thing in git blame history:
    # There's an annoying bug on sandboxed Darwin in Perl's Cwd.pm where it looks for pwd
    # in /bin/pwd and /usr/bin/pwd and then falls back on just "pwd" if it can't get them
    # while at the same time erasing the PATH environment variable so it unconditionally
    # fails. The code in question is guarded by a check for Mac OS, but the patch below
    # doesn't have any runtime effect on other platforms.
    postPatch = optional stdenv.isDarwin ''
      pwd="$(type -P pwd)"
      substituteInPlace dist/PathTools/Cwd.pm \
        --replace "/bin/pwd" "$pwd"
    '';

yeah, :( the motivation here is to not bring along build-time dependencies when cross compiling

I'm not sure why ofborg isn't building, it's building on my machine...  will investigate more

greping for type -P  reveals 62 more cases like this on

@GrahamcOfBorg eval
@GrahamcOfBorg build perl gitFull

@illegalprime This change appears to break evaluation on darwin: https://github.com/NixOS/nixpkgs/pull/58979/checks?check_run_id=135801652

See https://github.com/NixOS/nixpkgs/pull/65761 for my PR that fixes the Darwin issue and another accidental reference.

closing in favor of #65761


Updated bar examples to be carbon-centric

Summary

Closes #165
Deployment Link

https://terra-graphs-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon

Closing this PR in favor of #195 which addresses the failing Travis build.


Filtering lesson - highlight in the materials that they need to be on a login node prior to srun

Highlight they need to be on a login node prior to running the 'srun' command. Some people were already in an interactive session

“srun for an interactive session should always be run from the login node”

added a note


fix bug with uncorrect context in local server. Add scanning availabl…

…e port to use in local server

LGTM


Implement -execdir for safety and security

The popular BSD and GNU implementations of findutils implement an -execdir flag on find, which provides more accurate exit code information (-exec implicitly drops failing codes on the floor).
https://www.gnu.org/software/findutils/manual/html_mono/find.html#Conclusion
Can toybox find please implement this flag, too?
Some larger operating systems like Alpine Linux default their find implementation to toybox's, with deleterious results unless the GNU findutils package is installed, overriding the default.

We have execdir already. Are you saying it doesn't work?
When did Alpine Linux start defaulting to toybox find? I thought they used busybox?

Oh, good to hear!
I can't remember whether Alpine uses toybox or busybox. Maybe the solution
for Alpine is as simple as updating the version they consume.
On Tue, Jan 16, 2024, 2:39 PM Rob Landley @.***> wrote:

We have execdir already. Are you saying it doesn't work?
When did Alpine Linux start defaulting to toybox find? I thought they used
busybox?
—
Reply to this email directly, view it on GitHub
https://github.com/landley/toybox/issues/476#issuecomment-1894477336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABJRFUZTH7C3FDMEH4B63YO3QPVAVCNFSM6AAAAABB4EEPFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGQ3TOMZTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Cleanup UI

[ ] remove the atty crate in favour of IsTerminal
[ ] standardize on the indicatif/dialoguer UI crates

[ ] remove home-rolled prompt_confirm function

Also, as far as I remember, we re-implemented it here for this reason: https://github.com/console-rs/dialoguer/issues/170
But it would be nice not to use such workarounds.

Originally posted by @LesnyRumcajs in https://github.com/ChainSafe/forest/pull/2893#discussion_r1217710558

[ ] rationalize our progress bars and color story

[ ] log to stderr, not stdout

It's likely that a lot of our atty checks have subtle/edge bugs. E.g https://github.com/ChainSafe/forest/blob/1af4fde3cb1ef3e24a3ff9d7082d171d4c8b1892/forest/daemon/src/daemon.rs#L505
Checks that stdin is a tty, but the confirm is actually rendered on stdout


prototyping new chart

First pass at adding the ability to deploy the single rbacdefinition with the chart.  By default it is set to not create the definition, so existing deployments of rbacmanager will not be affected.

Only minor problem this introduces is a 🐔 🥚 problem that helm hasn't solved yet. If we start with a fresh k8s install, you can't both create the CRD and use the CRD in the same helm command. Probably something we can doc around, but the 1-step workaround is to have the rbacdef resource created as a post-install hook which feels bit jank

Tested using the values in my cluster.  Deploys just fine and works as intended.

A post-install hook will be an issue though, because it will not update on subsequent runs

Maybe a post-upgrade hook?  Not sure if that would require you to install twice on first run though....

I know Istio had the 🐔 🥚  problem with their chart but they have worked around it. I haven't figured it out how yet but : https://github.com/istio/istio/tree/master/install/kubernetes/helm

I believe you are right.  Do we think that is the best way to do this?

The best way would be to have helm respect ordering or requirements and retries... but other than that, subcharts seems reasonable.

Okay, now I have no clue how that istio chart works.  I re-wrote everything into sub-charts, and added a requirements file with the ordering (like the istio chart does), and it still gives an error.

This works.  I will just have to add a note in the docs that says the first time you deploy this you have to disable the rbac-definition chart.  It's annoying, but it will only have to be done once.  @ejether @coreypobrien let me know what you think.
Otherwise, we should be able to merge this and not have it affect any existing installs since it default disables the rbac-definition chart.

Looks like the CRD is created here in a preinstall hook and a custom image.
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/mixer/templates/create-custom-resources-job.yaml

Added the notes about the rbac-definition addition to the README.  This will work for now until we have time to implement a better method.


C2D: Storage expiry

All compute engines have compute environments, and each compute environment specifies how long the output produced by a job is held by the node, before being deleted.
When a job expiry is overdue, the node will delete all storage used by that job, and also delete the job record from the database
Task:

create a cron that deletes all storage used by expired jobs and deletes the record from db,

Thinks to consider:  we have common and most likely specific tasks per each compute engine, so split code in both C2DEngines class and each compute engine class

inlcuded on PR https://github.com/oceanprotocol/ocean-node/pull/705


CC0 License

https://github.com/electron/electron-quick-start
https://github.com/electron/electron-quick-start/blob/master/LICENSE.md

Markdown:
[<img width="32" height="32" align="right" src="http://mirrors.creativecommons.org/presskit/icons/zero.png" title="CC0 1.0 Universal (CC0 1.0)" target="_blank">](https://creativecommons.org/publicdomain/zero/1.0/)

To the extent possible under law, [@mhulse](https://github.com/mhulse) has waived all copyright and related or neighboring rights to this work.

Rendered:

To the extent possible under law, @mhulse has waived all copyright and related or neighboring rights to this work.

Looks like Electron has a license in the repo (vs. linking off to one):
https://github.com/electron/electron-quick-start/blob/master/LICENSE.md


✅ Deploy Preview for hot-sauced-ui ready!

✅ Deploy Preview for hot-sauced-ui ready!

Name
Link

🔨 Latest commit
d60a3ce6e361f139357b9660ed9881efc722e9e8

🔍 Latest deploy log
https://app.netlify.com/sites/hot-sauced-ui/deploys/62e2c03bfe7cbd0008c93a23

😎 Deploy Preview
https://deploy-preview-252--hot-sauced-ui.netlify.app/

📱 Preview on mobile
 Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
Originally posted by @netlify[bot] in https://github.com/open-sauced/hot/issues/252#issuecomment-1197468849

hot repos stay upvoted when the app is loaded
signing in and signing back out has no effect on whether they are voted or not

#252

:tada: This issue has been resolved in version 2.15.1 :tada:
The release is available on:

GitHub release
ghcr.io container (@latest dist-tag)

Your semantic-release bot :package::rocket:


raft: use a singleton global rand

rand.NewSource creates a 4872 byte object. With a small number of raft
groups in a process this isn't a problem. With 10k raft groups we'd use
46MB for these random sources. The only usage is in
raft.resetRandomizedElectionTimeout which isn't performance critical.
Fixes #6347.

lgtm


Memory usage with high # of predicates

Possible area of enhancement regarding memory usage when a high number of predicates is specified.
I remember when I profiled, the memory peaked during the creation of the predicate columns.
@Jwoo5 could you please help confirm if this is the case for your dataset/tasks as well? I just used mprof to run a script with the extraction code and looked at the memory plots.
Tagging @mmcdermott

Yes, the memory peaked when creating the predicate columns.
It would be great if we can expand the predicates grammar to support "any of codes" operation without creating intermediate predicate columns to realize the final expression (e.g., or(...))

Ok, this is great information. We can pretty easily support this.

So I think that #90 will likely solve this, so we will relegate active analysis of this to there. In the end, we may also need to invest in specific, easy to use profiling scripts as well to better understand the computational performance, but hopefully #90 will eliminate this issue and we'll be good to go.

Can we check if #90 actually solved this? @justin13601 or @Jwoo5


Removing use of hard-coded number of nodes in base graph

Hey Jacob,
Just a small PR to make the code usable on a base graph with not 9 nodes.
Amazing work on the repo, super clear and easy to use!

Thank you for contributing!


Document how to reuse LLM (without having it restart on every run)

So that llama_model_loader: loaded meta data with 20 key-value pairs and 291 tensors from .models/mistral-7b-instruct-v0.1.Q4_K_M.gguf... is only shown once
from funcchain import chain, settings
from funcchain.model.defaults import ChatLlamaCpp, get_gguf_model
from pydantic import BaseModel

model = "Mistral-7B-Instruct-v0.1-GGUF"
model_file = "mistral-7b-instruct-v0.1.Q4_K_M.gguf"

settings.llm = ChatLlamaCpp(
    model_path=get_gguf_model(model, "Q4_K_M", settings).as_posix(),
)

class Translated(BaseModel):

    chinese: str
    english: str
    french: str

def hello(text: str) -> Translated:
    """
    Translate text into three languages.
    """
    return chain()

hello("Hello!")
hello("one")
hello("two")

I was doing this, expecting it to work (and it did), but it was deceitfully using <class 'langchain_openai.chat_models.base.ChatOpenAI'>!
from funcchain import chain, settings
from funcchain.model.defaults import ChatLlamaCpp, get_gguf_model
from langchain_community.llms import LlamaCpp
from pydantic import BaseModel

from langchain_community.llms.llamacpp import LlamaCpp
from huggingface_hub import hf_hub_download

model = "TheBloke/Mistral-7B-Instruct-v0.1-GGUF"
model_file = "mistral-7b-instruct-v0.1.Q4_K_M.gguf"

model_path = hf_hub_download(model, model_file)
llm = LlamaCpp(model_path=model_path)
llm.client.verbose = False
settings.llm = llm

class Translated(BaseModel):

    chinese: str
    english: str
    french: str

def hello(text: str) -> Translated:
    """
    Translate text into three languages.
    """
    return chain()

hello("Hello!")


Project Submission: Skunk and Natchez

Project Name
Skunk and Natchez
Project Short Description
Skunk is a library for working with Postgres databases built on the Typelevel stack. Natchez provides a cats-effect based abstraction layer for distributed tracing.
Project Type
In accordance with the Typelevel Charter, I am proposing the project be a:

[x] Organization Project
[ ] Affiliate Project

Project Management
Typelevel projects are required to have an appropriate Code of Conduct. The Scala Code of Conduct is a good option, but not specifically required. Before submitting a project for inclusion, please ensure that a pointer to its Code of Conduct is clearly linked from its README, CODE_OF_CONDUCT.md, or website.

[x] This project's Code of Conduct can be found at https://github.com/typelevel/.github/blob/main/CODE_OF_CONDUCT.md

Similarly, Typelevel projects must have an appropriate license, as specified in the Typelevel Charter. Please make sure that the project's license is on the approved list.

[x] This project's license can be found at https://github.com/typelevel/skunk/blob/main/LICENSE and https://github.com/typelevel/natchez/blob/main/LICENSE

Additional Notes
I've been maintaining these projects for a few quarters now. Rob recently transferred these to the Typelevel organization in order to allow more control of repository settings, etc. I should have opened a ticket first. If these aren't accepted as org projects, I'll transfer them to a new organization.

@typelevel/steering: please vote with reaction on the issue. 👍 for yes, 👎 for no, 👀 to abstain.
Voting is open three business days (through Thursday, April 20) and until quorum (7) is reached.

Quorum (needs 7, got 7) is reached, and vote is affirmed (needs 3/4, got 100%).  The usual tasks are tracked in #95 and #96.


Change training stage from ResultStage to ShuffleMapStage

The training step runs in barrier model and is ResultStage, which means when one of the training task failed the training stage failed, and the whole application failed becuase no retry for ResultStage.
When there are many training tasks, it's easy that one task will fail due to cluster node issue, so the application may has a high failure rate.
In this PR, we add a repartition step to make the training stage as ShuffleMapStage, so that when the training stage failed, the stage can retry and the whole spark application won't fail.

To fix https://github.com/dmlc/xgboost/issues/8336

@jinmfeng001, Per my understanding, the xgboost training is deterministic, @trivialfis please correct me. if the first training fails, the retry, I guess, may still fail (the only difference I can think of is the training task may be distributed to different workers).
BTW, have you seen the retry can really help the xgboost training?

Indeed, there can be many reasons for failure and xgboost doesn't do well on large shared clusters due to the lack of a failure recovery mechanism.
@wbo4958 Please help review the PR. In addition, is there a way to test?

Indeed, there can be many reasons for failure and xgboost doesn't do well on large shared clusters due to the lack of a failure recovery mechanism.
@wbo4958 Please help review the PR. In addition, is there a way to test?

In our situation, we changed it to ShuffleMapStage, and we don't see much application failures now.
It's a good question how to test this change. I don't there's any thing we can do to fail a task. Do you guys know?

@jinmfeng001 would you like to provide the whole log with the retry working?

We're focusing on resolving the failure cuased by hardware failure on one node(In a big cluster, it's common one node may fail due to some hardware issue). So if the task is reassigned to another node it may succeed.
In our situation, this help to remove the failure rate for the whol training applciation.

@jinmfeng001 Thx for your explanation, just give me some time to learn it.

@jinmfeng001 Thx for your PR, I spent some time learning the spark's retry mechanism. You're right, the spark won't retry the failed barrier ResultStage.
I don't know if this PR will introduce the performance issue since another shuffle stage will involve the disk write/read. I will do some test. Thx for your time.

I ran the mortgage test with xgboost-spark-gpu on the spark standalone cluster with 1 worker and spark-rapids enabled. Here is the result

1st
2nd
3rd

W/O PR
89.379
89.126
89.367

W/ PR
90.173
89.224
89.131

Seems this PR doesn't introduce much extra overhead.

LGTM


Update README.md

Added a gif banner and moved the text to the left.

But there is also a possibility of choosing just the same banner but in jpeg format.


Fix crash when no auth header is specified

NoMethodError: undefined method `start_with?' for nil:NilClass
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/token_validator.rb:49:in `valid_header?'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/token_validator.rb:13:in `valid?'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:40:in `verify'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:11:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:4:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/tempfile_reaper.rb:15:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/lint.rb:49:in `_call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/lint.rb:37:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/show_exceptions.rb:23:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/common_logger.rb:33:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/chunked.rb:54:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/content_length.rb:15:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/handler/webrick.rb:86:in `service'
        /usr/lib/ruby/2.4.0/webrick/httpserver.rb:140:in `service'
        /usr/lib/ruby/2.4.0/webrick/httpserver.rb:96:in `run'
        /usr/lib/ruby/2.4.0/webrick/server.rb:290:in `block in start_thread'NoMethodError: undefined method `start_with?' for nil:NilClass
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/token_validator.rb:49:in `valid_header?'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/token_validator.rb:13:in `valid?'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:40:in `verify'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:11:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/bot_framework-0.1.0beta/lib/bot_framework/server.rb:4:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/tempfile_reaper.rb:15:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/lint.rb:49:in `_call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/lint.rb:37:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/show_exceptions.rb:23:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/common_logger.rb:33:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/chunked.rb:54:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/content_length.rb:15:in `call'
        /usr/lib/ruby/gems/2.4.0/gems/rack-2.0.1/lib/rack/handler/webrick.rb:86:in `service'
        /usr/lib/ruby/2.4.0/webrick/httpserver.rb:140:in `service'
        /usr/lib/ruby/2.4.0/webrick/httpserver.rb:96:in `run'
        /usr/lib/ruby/2.4.0/webrick/server.rb:290:in `block in start_thread'

Thanks, but when you got this error? auth will be there always, right ?

auth will be there always, right ?

Nope, any client which can connect to this endpoint can send any data to it, including not sending auth header. You want to just ignore such clients.
I encountered this when connected to it with Microsoft Bot Framework Channel Emulator and didn't specified app-id/secret

Got it, thanks :+1:


Suggestion to use Hash#slice in the Raindrops mentoring notes

In one of the sessions I mentored a student came up using Hash#slice in her solution to Raindrops. (In the end she removed that call while making other changes, though.)
Over in the Slack track @F3PiX suggested (https://exercism-team.slack.com/archives/CARVB5V0R/p1560869977017500) to open this issue to discuss whether this solution should be incorporated in the mentoring notes.
A solution using Hash#slice could look like this:
class Raindrops
  SOUNDS = {
    3 => "Pling",
    5 => "Plang",
    7 => "Plong"
  }

  def self.convert(num)
    string = SOUNDS.slice(*sound_factors(num)).inject('') { |str, sound| str + sound[1] }

    string.empty? ? num.to_s : string
  end

  def self.sound_factors(num)
    SOUNDS.keys.select { |n| num % n == 0 }
  end
end

Come to think of it for a while now, I prefer the solution using Hash#select:
SOUNDS.select { |key, _| (num % key).zero? }

I would change sound_factors(number) to factors because that is the collection you would get back.  And I prefer number to num always.  English and Acronyms and all that... full words are easier to look up.
sound vs string since writing to the problem being solved, versus to writing to the programming domain.
And SOUNDS as a name only describes half of the Hash object, where RULES may describe the idea being held, while FACTOR_TO_SOUND may have it's benefits as well.
Also, there is some discussion that should probably come up with the public method being introduced... we need convert on the class or module, as enforced by the tests, and that is the only public interfaced prescribed.

I suggest #values_at rather than slice and then it is possible to use join instead of inject.

there is some discussion that should probably come up with the public method being introduced

Agreed.  With a local variable instead:
class Raindrops
  FACTOR_TO_SOUND = {
    3 => 'Pling',
    5 => 'Plang',
    7 => 'Plong'
  }

  def self.convert(number)
    factors = FACTOR_TO_SOUND.keys.select { |n| (number % n).zero? }
    sounds = FACTOR_TO_SOUND.values_at(*factors).join

    sounds.empty? ? number.to_s : sounds
  end
end

Not sure this is any better than the last example already listed in the mentor notes?

I am not a fan of needing to use the hash twice, in the full class write up example above.  I think it focuses on the wrong thing as far as the solution goes.  The focus is probably best when building a string more directly.
The same is true for the original post, where the Hash is relied on more than once.

If there is more to be discussed here I would recommend opening a PR on the mentor notes for the exercise.
I'm going to go ahead and close this issue.


Add deleted_at to User and CaseWorker

This PR sets up the framework for soft delete of caseworkers and users.
It adds a 'deleted_at' field to CaseWorker and User models, and sets the
default scope to exclude any records where deleted at is not null.  Also
adds an including_deleted scope which returns all records.
This has no effect on the current deletion process as that hasn't yet been
changed to use the deleted_at fields.

Consider using an explicit scope/class method rather than defualt_scope, in my experience this causes a mess of problems. See http://weblog.jamisbuck.org/2015/9/19/default-scopes-anti-pattern.html

I recommend making the relevant implementation changes in this PR as well so we can see the full effect of the changes on the codebase.

Looks like the migration hasn't run on CI 😢


Black screen when use umu-launcher

umu-launcher is a Unified Linux Wine Game Launcher
I duplicated the image/steam directory from the gow project and modified the Dockerfile to install umu-launcher. Then, in startup.sh, I changed the startup command from steam to umu-run to run the game directly. However, after starting, I can only hear the sound while the screen remains black.
I compared the command lines of the running processes when starting through Steam and through umu, and the compatibility layer parts are identical. I specifically designated the compatibility layer from the Steam directory for umu to use. Therefore, I believe the issue is not with the compatibility layer.
startup.sh:
#!/bin/bash
set -e

source /opt/gow/bash-lib/utils.sh

gow_log "Starting Steam with DISPLAY=${DISPLAY}"

export GAMEID=umu-dauntless
export PROTONPATH="/home/retro/.steam/debian-installation/steamapps/common/Proton - Experimental"

if [ -n "$RUN_GAMESCOPE" ]; then
  GAMESCOPE_WIDTH=${GAMESCOPE_WIDTH:-1920}
  GAMESCOPE_HEIGHT=${GAMESCOPE_HEIGHT:-1080}
  GAMESCOPE_REFRESH=${GAMESCOPE_REFRESH:-60}
  GAMESCOPE_MODE=${GAMESCOPE_MODE:-"-b"}

  /usr/games/gamescope -e ${GAMESCOPE_MODE} -R $socket -T $stats -W "${GAMESCOPE_WIDTH}" -H "${GAMESCOPE_HEIGHT}" -r "${GAMESCOPE_REFRESH}" -- umu-run "${EXE_PATH}"  "-opengl -SkipBuildPatchPrereq"
else
  exec umu-run "${EXE_PATH}" "-opengl -SkipBuildPatchPrereq"
fi

Dockerfile:
......

RUN <<_INSTALL_UMU
set -e
apt-get update
apt install -y --no-install-recommends git  build-essential scdoc
git clone https://github.com/Open-Wine-Components/umu-launcher
cd umu-launcher
./configure.sh --prefix=/usr
make -j
make install
cd ..
rm -rf umu-launcher
_INSTALL_UMU
......

Here is the log of container:
[2024-06-06 13:34:01]
[2024-06-06 13:34:01] [ /etc/cont-init.d/10-setup_user.sh: executing... ]
[2024-06-06 13:34:01] **** Configure default user ****
[2024-06-06 13:34:01] Setting default user uid=1000(retro) gid=1000(retro)
userdel: ubuntu mail spool (/var/mail/ubuntu) not found
useradd: warning: the home directory /home/retro already exists.
useradd: Not copying any file from skel directory into it.
[2024-06-06 13:34:01] Setting umask to 000
[2024-06-06 13:34:01] Ensure retro home directory is writable
[2024-06-06 13:34:01] Ensure XDG_RUNTIME_DIR is writable
[2024-06-06 13:34:01] DONE
[2024-06-06 13:34:01]
[2024-06-06 13:34:01] [ /etc/cont-init.d/15-setup_devices.sh: executing... ]
[2024-06-06 13:34:01] **** Configure devices ****
[2024-06-06 13:34:01] Exec device groups
[2024-06-06 13:34:02] Adding user 'retro' to groups: video,root
[2024-06-06 13:34:02] DONE
[2024-06-06 13:34:02]
[2024-06-06 13:34:02] [ /etc/cont-init.d/30-nvidia.sh: executing... ]
[2024-06-06 13:34:02] Nvidia driver detected
[2024-06-06 13:34:02] [nvidia] Add Vulkan ICD
[2024-06-06 13:34:02] [nvidia] Add EGL external platform
[2024-06-06 13:34:02] [nvidia] Add egl-vendor
[2024-06-06 13:34:02] [nvidia] Add gbm backend
[2024-06-06 13:34:02]
[2024-06-06 13:34:02]
[2024-06-06 13:34:02] [ /etc/cont-init.d/init-gamescope.sh: executing... ]
[2024-06-06 13:34:02] **** Setting up Gamescope ****
[2024-06-06 13:34:02]
[2024-06-06 13:34:02] [ /etc/cont-init.d/system-services.sh: executing... ]
*** DBus started ***
*** Bluez started ***
bluetoothd[153]: Bluetooth daemon 5.72
bluetoothd[153]: src/adapter.c:adapter_init() Failed to access management interface
bluetoothd[153]: src/main.c:main() Adapter handling initialization failed
*** NetworkManager started ***
[2024-06-06 13:34:02] Launching the container's startup script as user 'retro'
[2024-06-06 13:34:02] Starting Steam with DISPLAY=
Claimed global gamescope stats session at "/tmp/sockets/gamescope-stats"
No CAP_SYS_NICE, falling back to regular-priority compute and threads.
Performance will be affected.
wlserver: [backend/headless/backend.c:68] Creating headless backend
Couldn't open plugin directory: No such file or directory
No plugins found, falling back on no decorations
vulkan: physical device 10de:2684 compute queue doesn't support presenting on our surface, using graphics queue
vulkan: selecting physical device 'NVIDIA GeForce RTX 4090': queue family 0
vulkan: physical device supports DRM format modifiers
vulkan: vkGetPhysicalDeviceFormatProperties2 returned zero modifiers for DRM format 0x38344241 (VkResult: 0)
vulkan: vkGetPhysicalDeviceFormatProperties2 returned zero modifiers for DRM format 0x38344258 (VkResult: 0)
vulkan: supported DRM formats for sampling usage:
vulkan:   AR24 (0x34325241)
vulkan:   XR24 (0x34325258)
vulkan:   AB24 (0x34324241)
vulkan:   XB24 (0x34324258)
vulkan:   NV12 (0x3231564E)
vulkan:   AB4H (0x48344241)
vulkan:   XB4H (0x48344258)
vulkan:   AB30 (0x30334241)
vulkan:   XB30 (0x30334258)
vulkan:   AR30 (0x30335241)
vulkan:   XR30 (0x30335258)
wlserver: Running compositor on wayland display 'gamescope-0'
wlserver: [backend/headless/backend.c:16] Starting headless backend
wlserver: [xwayland/sockets.c:118] Created /tmp/.X11-unix ourselves -- other users will be unable to create X11 UNIX sockets of their own
wlserver: [xwayland/server.c:108] Starting Xwayland on :0
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Warning:          Could not resolve keysym XF86CameraAccessEnable
> Warning:          Could not resolve keysym XF86CameraAccessDisable
> Warning:          Could not resolve keysym XF86CameraAccessToggle
> Warning:          Could not resolve keysym XF86NextElement
> Warning:          Could not resolve keysym XF86PreviousElement
> Warning:          Could not resolve keysym XF86AutopilotEngageToggle
> Warning:          Could not resolve keysym XF86MarkWaypoint
> Warning:          Could not resolve keysym XF86Sos
> Warning:          Could not resolve keysym XF86NavChart
> Warning:          Could not resolve keysym XF86FishingChart
> Warning:          Could not resolve keysym XF86SingleRangeRadar
> Warning:          Could not resolve keysym XF86DualRangeRadar
> Warning:          Could not resolve keysym XF86RadarOverlay
> Warning:          Could not resolve keysym XF86TraditionalSonar
> Warning:          Could not resolve keysym XF86ClearvuSonar
> Warning:          Could not resolve keysym XF86SidevuSonar
> Warning:          Could not resolve keysym XF86NavInfo
Errors from xkbcomp are not fatal to the X server
wlserver: [types/wlr_compositor.c:681] New wlr_surface 0x557f58200560 (res 0x557f58683070)
wlserver: [xwayland/server.c:273] Xserver is ready
xwm: Failed to load host cursor. Falling back to left_ptr.
wlserver: [types/wlr_compositor.c:681] New wlr_surface 0x557f5867c410 (res 0x557f58685a00)
[2024-06-06 13:34:02.836] [info] [config.cpp:123] parsing config: '/tmp/mangohud.eyD0inWO'
[2024-06-06 13:34:02.864] [error] [loader_nvctrl.cpp:39] Failed to open 64bit libXNVCtrl.so.0: libXNVCtrl.so.0: cannot open shared object file: No such file or directory
[2024-06-06 13:34:02.864] [error] [nvctrl.cpp:45] XNVCtrl loader failed to load
[2024-06-06 13:34:02.864] [info] [overlay.cpp:808] Uploading is disabled (permit_upload = 0)
xwm: Rejecting WM_CHANGE_STATE to ICONIC for window 0x400007
steamrt3 is up to date
x86_64-linux-gnu-capsule-capture-libs: warning: Dependencies of libnvidia-pkcs11.so.550.90.07 not found, ignoring: Missing dependencies: Could not find "libcrypto.so.1.1" in LD_LIBRARY_PATH "", ld.so.cache, DT_RUNPATH or fallback /lib:/usr/lib
x86_64-linux-gnu-capsule-capture-libs: warning: we are assuming "_el_fn_sh_complete" to be private, but it's just a guess
i386-linux-gnu-capsule-capture-libs: warning: we are assuming "_el_fn_sh_complete" to be private, but it's just a guess
pressure-vessel-wrap[248]: N: Not replacing "/etc/vulkan/explicit_layer.d" with tmpfs: Path "/etc" is reserved by the container framework
pressure-vessel-wrap[248]: N: Not replacing "/etc/vulkan/implicit_layer.d" with tmpfs: Path "/etc" is reserved by the container framework
setlocale "en_US.UTF-8": No such file or directory
pressure-vessel-locale-gen: Missing locale en_US.UTF-8
pressure-vessel-locale-gen: Generating locale en_US.UTF-8...
pressure-vessel-locale-gen: Generated locale en_US.UTF-8 successfully
pressure-vessel-adverb[315]: W: Container startup will be faster if missing locales are created at OS level
wlserver: [types/wlr_compositor.c:681] New wlr_surface 0x557f58656ee0 (res 0x557f58686170)
wlserver: [types/wlr_compositor.c:681] New wlr_surface 0x557f58657240 (res 0x557f586864d0)
wlserver: [types/wlr_compositor.c:681] New wlr_surface 0x557f586a7af0 (res 0x557f58684b60)
xwm: Unhandled NET_WM_STATE property change: _KDE_NET_WM_STATE_SKIP_SWITCHER
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_ABOVE
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_VERT
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_HORZ
xwm: Unhandled NET_WM_STATE property change: _KDE_NET_WM_STATE_SKIP_SWITCHER
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_ABOVE
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_VERT
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_HORZ
xwm: Unhandled NET_WM_STATE property change: _KDE_NET_WM_STATE_SKIP_SWITCHER
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_ABOVE
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_VERT
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_HORZ
xwm: Unhandled NET_WM_STATE property change: _KDE_NET_WM_STATE_SKIP_SWITCHER
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_ABOVE
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_VERT
xwm: Unhandled NET_WM_STATE property change: _NET_WM_STATE_MAXIMIZED_HORZ

Docker top:
/bin/bash /opt/gow/startup-app.sh
dbus-daemon --system --fork --nosyslog
NetworkManager
/usr/games/gamescope -e -b -R /tmp/sockets/gamescope.NFjMUaQ/startup.socket -T /tmp/sockets/gamescope.NFjMUaQ/stats.pipe -W 1280 -H 720 -r 60
Xwayland :0 -rootless -core -terminate -listenfd 57 -listenfd 58 -displayfd 62 -noTouchPointerEmulation
/usr/bin/ibus-daemon -d -r --panel=disable --emoji-extension=disable
mangoapp
dbus-run-session -- umu-run /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
dbus-daemon --nofork --print-address 4 --session
sh /usr/bin/umu-run /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
python3 /usr/share/umu/umu_run.py /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
/usr/libexec/ibus-memconf
/home/retro/.local/share/umu/pressure-vessel/libexec/steam-runtime-tools-0/srt-bwrap --args 21 /usr/lib/pressure-vessel/from-host/bin/pressure-vessel-adverb --generate-locales --fd 13 --regenerate-ld.so-cache /var/pressure-vessel/ldso --add-ld.so-path /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu --add-ld.so-path /usr/lib/pressure-vessel/overrides/lib/i386-linux-gnu --set-ld-library-path /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/aliases:/usr/lib/pressure-vessel/overrides/lib/i386-linux-gnu/aliases --overrides-path /usr/lib/pressure-vessel/overrides --exit-with-parent --subreaper --assign-fd=1=3 --assign-fd=2=4 --shell=none --terminal=none -- /home/retro/.local/share/umu/pressure-vessel/bin/steam-runtime-launcher-interface-0 container-runtime /home/retro/.steam/debian-installation/steamapps/common/Proton - Experimental/proton waitforexitandrun /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
/usr/lib/pressure-vessel/from-host/bin/pressure-vessel-adverb --generate-locales --fd 13 --regenerate-ld.so-cache /var/pressure-vessel/ldso --add-ld.so-path /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu --add-ld.so-path /usr/lib/pressure-vessel/overrides/lib/i386-linux-gnu --set-ld-library-path /usr/lib/pressure-vessel/overrides/lib/x86_64-linux-gnu/aliases:/usr/lib/pressure-vessel/overrides/lib/i386-linux-gnu/aliases --overrides-path /usr/lib/pressure-vessel/overrides --exit-with-parent --subreaper --assign-fd=1=3 --assign-fd=2=4 --shell=none --terminal=none -- /home/retro/.local/share/umu/pressure-vessel/bin/steam-runtime-launcher-interface-0 container-runtime /home/retro/.steam/debian-installation/steamapps/common/Proton - Experimental/proton waitforexitandrun /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
python3 /home/retro/.steam/debian-installation/steamapps/common/Proton - Experimental/proton waitforexitandrun /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
c:\windows\system32\steam.exe /opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
/home/retro/.steam/debian-installation/steamapps/common/Proton - Experimental/files/bin/wineserver
C:\windows\system32\services.exe
C:\windows\system32\winedevice.exe
C:\windows\system32\winedevice.exe
C:\windows\system32\plugplay.exe
C:\windows\system32\svchost.exe -k LocalServiceNetworkRestricted
C:\windows\system32\explorer.exe /desktop
C:\windows\system32\rpcss.exe
C:\windows\system32\tabtip.exe
Z:\opt\games\Brotato v<IP_ADDRESS>\Brotato.exe

printenv:
NEEDRESTART_SUSPEND=1
PUID=1000
GAMESCOPE_HEIGHT=720
HOSTNAME=4e682a941653
UMASK=000
PWD=/home/retro
TZ=Europe/London
PULSE_SOURCE=virtual_sink_2188150276858045429.monitor
GAMESCOPE_VERSION=3.12.5
PULSE_SINK=virtual_sink_2188150276858045429
HOME=/home/retro
UNAME=retro
PGID=1000
WAYLAND_DISPLAY=wayland-1
GAMESCOPE_WIDTH=1280
RUN_GAMESCOPE=true
TERM=xterm
GOW_REQUIRED_DEVICES=/dev/input/* /dev/dri/* /dev/nvidia*
BUILD_ARCHITECTURE=amd64
DEB_BUILD_OPTIONS=noddebs
SHLVL=1
PROTON_LOG=1
XDG_RUNTIME_DIR=/tmp/sockets
EXE_PATH=/opt/games/Brotato v<IP_ADDRESS>/Brotato.exe
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
GAMESCOPE_REFRESH=60
PULSE_SERVER=/tmp/sockets/pulse-socket
DEBIAN_FRONTEND=noninteractive
_=/usr/bin/env

Comparing the startup logs of the Steam container, I found that DRM render log is missing:
CDesktopCapturePipeWire: Opening DRM render node /dev/dri/renderD128

Alright, I have resolved the issue. It was because gamescope should not have the -e parameter, which is intended for Steam. Everything works fine after removing it.


feat(batch): revisit the micro benchmark

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?

Summarize your change (mandatory)
Previously, there are lots of duplicate code in batch benchmark. This pr try to refactor part of the benchmark code and add benchmark for Expand executor. Besides, this pr also fix a small bug of benchmark of HashAgg.

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
close #5066

Introducing expand and refactoring join do not seem to be related? It might be better to create separated PRs so that some uncontroversial parts can be merged sooner, and discussion can be focused on the remaining parts.

Yes, I will separate it into 2 prs.


popup doesn't open on Mac OSX webview

Description
Please provide a short description of the issue here, along with:

The paypal.version from your browser console

^4.0.133
Steps to reproduce
We have a unique situation to use PayPal on a Webview of Mac OSX. However, the popup doesn't open.
The same page works on ISO Webview.
Any thought?
Affected browsers

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge
[ ] IE
[ ] Chrome Mobile/Tablet
[ ] Safari Mobile/Tablet
[X] Web View / Safari ViewController
[ ] Other

Can you share the user-agent for the webview?

The Useragent format is like
ApplePhotosExtension v{APP_VERSION} MacOS {OS_VERSION}

Here's a user agent for a WKWebView in Mac OS X
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/604.3.4 (KHTML, like Gecko)
I noticed in src/lib/device.js it's not doing a test for Macintosh in isWebView()
export function isWebView() : boolean {
    let userAgent = getUserAgent();
    return (/(iPhone|iPod|iPad).*AppleWebKit(?!.*Safari)/i).test(userAgent) ||
        (/\bwv\b/).test(userAgent) ||
    (/Android.*Version\/(\d)\.(\d)/i).test(userAgent);
}

Thanks! Added detection for webviews on Macintosh for the next release.

This has now been released. @maxisam / @abezydar can you let me know if you still see any issues here?

@bluepnume sure, I'll let you know probably next week. Thx!

It works. Thanks!

Awesome, thanks for verifying!


Updated dates to reflect 2023 schedule.

Updated schedule dates for HackIllinois 2023.
Description
Changed dates to the 24th, 25th, and 26th

Todos

Screenshots

##TODO

change defaults in HITimeDataSource, line 20
use/replace this HIHomeViewController, line 248
update this HIBannerViewController, line 32


Add more models

Is your feature request related to a problem? Please describe.
I miss the known type safety by missing models for SearchParameters and SearchResponse, a map is always not as easy to use and more error prone than a model.
Describe the solution you'd like
Add the models for SearchParameters and SearchResponse.

Hi @guenth39
Thank you for creating this issue. I've had this on my TODO list for a while now, just haven't gotten around to implement it due to time limitations.
I can definitely guide you if you feel like contributing to the project.

These model definitions are available as part of the open api spec and that can be used to generate the models.