Mentions not recognized inside italic, bold, strikethrough, or link

We fail to recognize any of these mentions:
*italic @**mention** italic*
**bold @**mention** bold**
~~strikethrough @**mention** strikethrough~~
[link @**mention** link](link)

https://zulip.readthedocs.io/en/latest/subsystems/markdown.html is relevant background for how this works.
This is likely a somewhat subtle issue involving order-of-operations in the markdown processor.

@sohamsshah Are you still working on this? I'll like to give this a try.

@zulipbot claim

@zulipbot claim

@zulipbot abort

Taking this issue :)

I am working on this issue. @zulipbot claim

I am working on this issue. @zulipbot claim

@andersk It appears to be fixed. Here are my observations from dev server:

Source for the above message

Is this same as what is expected for tmentioning in these cases

@andersk It appears to be fixed. Here are my observations from dev server:

Source for the above message

Is this same as what is expected for tmentioning in these cases

Update: Everything is working fine except for strikethrough, i.e. strikethrough is not properly applied over the mentions. Following is how it is rendered:
strikethrough @mention strikethrough
HTML content:
strikethrough @mention strikethrough

This can be possibly related to the issue: https://github.com/zulip/zulip/issues/15015, since HTML tag:  appears, but visually there is no - over the text.
Possibly this has something to do with the CSS part.


Change the legend for the piecharts

Black = Non-redeemable
Yellow = Backers can RageQuit
Blue = Builders can RageQuit
Also... the math seems wrong... this might need to be corrected so the math matches the legend as well :-D

@GriffGreen can you explain the math error?

The non-redeemable % changes... that doesnt make any sense...


WINDOWS_CPU_TIME_TOTAL to return IIS Worker Process App Pool Name

Proposal
Windows Exporter
It's very useful because currently, you can only return the PID or W3WP as a label which makes it hard to find out easily what the IIS App Pool is called because these will recycle and a new PID is created.
Therefore if we had a label for the App Pool name then we can quickly see that it is a problem with a certain website or API.

Thanks for your suggestion! We appreciate your input on this matter. However, please note that this issue tracker is specifically for Prometheus. Since you are suggesting an enhancement to the Windows Exporter, we kindly recommend you to open a new issue on their issue tracker.
https://github.com/prometheus-community/windows_exporter


Include Android's CHRE as a module

Origin
AOSP: https://android.googlesource.com/platform/system/chre/+/HEAD/
Purpose
CHRE is Android's EC event loop and management of peripheral information. It allows separation of the frameworks from the feature work (the consumers of the raw data). Having this as a module would allow Zephyr apps to write and include nanoapps compatible with CHRE to consume the raw peripheral data. This would avoid a lot of boiler plate code needed to communicate with these peripherals.
Mode of integration
This should be a module name chre
Pull Request
#37257, this was experimentally done as a subsystem for a single CHRE source file (to see what it would take to build it) at https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2991393
Description
CHRE provides a platform independent solution for handling and managing peripherals. Currently, Android devices are required to implement the PAL (platform abstraction layer) APIs in order to get CHRE up and running. At which point their existing nanoapps (which can be seen as features consuming the data from the peripherals) can be used. Note that nanoapps can be loaded statically OR dynamically in CHRE. Having CHRE available in Zephyr as a module would enable us to implement these frameworks such as the sensor framework using devicetree; at which point, consumers of the data would be able to avoid a lot of the boilerplate and complexity of the work. For the initial work, we'd like to focus on the sensor framework and some of these benefits  include:

Having to manage multiple requests at different data rates.
Managing timestamp spreading when sensor FIFO is used.
Handling sensor orientation

On top of these benefits, we'd be able to supply the Zephyr source tree with common nanoapps that consume data from these frameworks. Again, in the case of sensors these might include:

Impact detection.
Online (live) calibration
On body detection
Lid angle calculation

CHRE is a well established framework for managing peripheral data. If integrated well, it could drastically reduce the friction of using these peripherals.
See Issue #36963
Dependencies
None
Revision
b1574433c580e7f7f8c0e8adc39055f63a2d8238
License
Apache-2.0

Ping, any thoughts on this?

@yperess Thanks for the presentation at the TSC 18/Aug/21 ... if you can post a link to the presentation here it would help evaluate this.

I like this. It is essentially a standardization and platform abstraction for all the embedded event subscribers and receivers I have needed to write throughout the years.

I look forward to seeing some data regarding codesize and resource usage.
I'd like to learn more about the sensorhub concept

CHRE-on-Zephyr TSC.pdf

You can find this following the link at the top of the issue, but some documentation on CHRE for the curious: https://android.googlesource.com/platform/system/chre/+/HEAD/README.md

I like this. It is essentially a standardization and platform abstraction for all the embedded event subscribers and receivers I have needed to write throughout the years.

I look forward to seeing some data regarding codesize and resource usage.
I'd like to learn more about the sensorhub concept

I spent some time gathering initial statistics:

When building the core CHRE we're adding ~1600 lines of code to the build.
The core sensor framework (reusable part) we're adding another ~1500 lines of code + whatever code we write to implement the PAL (this is hard to estimate).
The core audio framework is ~500 lines + the code to implement the PAL
The core GNSS framework is ~750 lines + the code to implement the PAL
The core WiFi framework is ~750 lines + the code to implement the PAL
The core WWAN framework is ~100 lines + the code to implement the PAL

I think that the key thing to keep in mind is that what we're trying to do is make things simple for the app developer. The developer should be using this if they need the features. In this case (when the feature is required) under the current model, the developer would need to implement those features themselves, this is what we're trying to solve.
As per code size, we (the Zephyr community) would obviously do our best to keep the footprint small. This is the benefit to having this all in a common location, any improvement goes out to everyone.
This would look roughly like:
CONFIG_CHRE=y
CONFIG_SENSOR_FRAMEWORK=y
CONFIG_SENSOR_FRAMEWORK_TIMESTAMP_SPREADING=y
CONFIG_SENSOR_FRAMEWORK_<feature_name>=y

I would argue that most apps can afford this size cost and the rare instances that can't will likely want to implement everything themselves anyway and use the raw drivers directly. Those developers might benefit from being able to see how Zephyr implements various features.

Personally I've got no issue with resource consumption and it's optional regardless.
Most devs would end up recreating it in application specific form otherwise. As mentioned on the call I have had need for something standardized like this for years and think it could provide immense value.

What's the process on this? Is there a vote to make CHRE an official module?

Ping, is there anything else that should be discussed? It seems like there are no objections to this work.

Can we create the fork?

Hi @yperess, I'm interested in CHRE on Zephyr.   How did the presentation go?  I read the TSC minutes and see TSC label removed but not sure about the current situation.
I don't see Zephyr in the CHRE repo yet.  Are you planning to merge zephyr port to the upstream? or

Can we create the fork?

Are you planning to fork the upstream?

@yashi I believe that the next step is that an admin from Zephyr needs to fork https://android.googlesource.com/platform/system/chre/+/refs/heads/master into https://github.com/zephyrproject-rtos/chre.
We then create a zephyr branch and add the zephyr/module.yml file and merge the appropriate changes into Zephyr to build it.
So really we're just waiting on the fork to be able to do any actual work.

@yperess, Sorry for my ignorant but does the upstream already have working Zephyr port?  I checked the repo but did't see it.  I mean, if the upstream already have working Zephyr port, we don't need to fork it under Zephyr project (I know we have many cloned repos under).  We can create a PR with glue code (if needed) and a change to west.yml.  I'm not a member of TSC so ...
If there already is working code, can I try it here on my board?

@yperess, Sorry for my ignorant but does the upstream already have working Zephyr port?  I checked the repo but did't see it.  I mean, if the upstream already have working Zephyr port, we don't need to fork it under Zephyr project (I know we have many cloned repos under).  We can create a PR with glue code (if needed) and a change to west.yml.  I'm not a member of TSC so ...
Yes, I suppose we could simply add it directly as a new remote.
If there already is working code, can I try it here on my board?
I'll try to put something together over the next 2 days.

Seems I can't just pull it in, I've tried adding it as a module directly to west.yaml and while the sync happens correctly it seems that without a zephyr branch and a zephyr/module.yaml file I'm not able to enable the config. See https://github.com/zephyrproject-rtos/nanopb/blob/zephyr/zephyr/module.yml as an example for another module.
So I think we really need an admin to create https://github.com/zephyrproject-rtos/chre/

@galak What's the process to formally create a module repo under zephyrproject-rtos?

@yperess, what's your plan? Do you plan to merge everything Zephyr needs, including zephyr/module.yaml, to the CHRE upstream, or you are planning to merge glue code to Zephyr?  Either way, we can create a CHRE repo under your github account and work on it.

If former, when it's ready, we can ask the CHRE upstream to merge.  For Zephyr, we just need a PR with a west.yaml change.
If latter, create Zephyr repo along with CHRE under your account, work on it both.  And ask both upstream for merge.

@yperess, what's your plan? Do you plan to merge everything Zephyr needs, including zephyr/module.yaml, to the CHRE upstream, or you are planning to merge glue code to Zephyr?  Either way, we can create a CHRE repo under your github account and work on it.

If the former, when it's ready, we can ask the CHRE upstream to merge.  For Zephyr, we just need a PR with a west.yaml change.

Yes, this one 😁
I just had a chat with someone on the CHRE team and they're happy to include the module file. I'll be sending a change tonight to AOSP. I'll be sending a corresponding PR to zephyr tomorrow.

Ping, this seems to have been approved at the TSC meeting way way back. I'm getting some bandwidth to finish it up. Can we please get the fork done? @nashif would you be able to help get the fork created or @ mention someone else that can? I heard from my org that Intel is very interested in using this so it might become a bit of a higher priority.

done https://github.com/zephyrproject-rtos/chre


VIM-2799: Add Matchit support for cshtml files

This enables HTML jumps in Razor templates to fix VIM-2799. I confirmed this works in the latest version of Rider.

Looks good for me, thank you!


Workspace - When deleting a workspace offline. the layout breaks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Access staging.new.expensify.com
Sign into a valid account that is ready for Error tests
Turn off internet connection
Delete a workspace while offline

Expected Result:
User expects the layout to continue even when offline
Actual Result:
Layout breaks
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/runs/view/14829&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Attaching TR picture to reproduce the issue

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Can confirm, I reproduced on staging web, but not on prod.

I looked at the PRs in https://github.com/Expensify/App/issues/17546, nothing stands out. I am going to use git bisect to find the offending PR, unless someone chimes in here: https://expensify.slack.com/archives/C01GTK53T8Q/p1681836208585709

For some reason I cannot assign @akinwale

I think he has to comment on the issue to assign him first. @mountiny - I'd propose a straight revert, thoughts?

@akinwale is looking into this, can you comment here please? Confirming if straight revert fixes this. There might be some other considerations.

revert Pr is in review.

fixed in staging

From what I found, there was an issue with defaultProps being disregarded (or discarded?) when the MenuItem is wrapped by a HOC.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.1-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17618

If no regressions arise, payment will be issued on 2023-04-26. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.2-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/17618

If no regressions arise, payment will be issued on 2023-04-27. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty


Make some private Slider members protected

What does the pull request do?
If developer wants to override default MoveToPoint and MoveToNextTick they have no choice but copy paste existing code.
This PR makes some of the most important methods protected virtual.

After thinking twice, these members are too specific to current implementation and might be changed in the future.


Optifine incompatibility during render regions feature[1.16.1]

Whenever you place 2 slabs onto each other (doesn't matter if they are same or different) there appears an OpenGL error. It happens only when you have RENDER REGIONS: ON with Optifine. Well what I've experienced so far, when you have a big build filled with slabs, it breaks some of the chunks entirely and "removes" blocks from another. You can see this on the screenshots below. When you place random 2 slabs somewhere in nature, error still appears, but there is no graphical bug. Tried in fresh new world, happens, too.
Versions:
Minecraft 1.16.1
OptiFine 1.16.1 HD U G2
Forge 32.0.105 (I guess this is not relevant since it happens on older versions, too)
DoubleSlabs 1.16-3.3.3
Debug log is full of:
[06Srp2020 10:22:43.669] [Render thread/ERROR] [net.optifine.shaders.SMCLog/]: [Shaders] OpenGL error: 1281 (Invalid value), program: gbuffers_textured_lit (none), at: pre-useProgram
[06Srp2020 10:22:43.672] [Render thread/ERROR] [net.optifine.shaders.SMCLog/]: [Shaders] OpenGL error: 1281 (Invalid value), program: gbuffers_water (none), at: pre-useProgram
[06Srp2020 10:22:43.673] [Render thread/ERROR] [net.optifine.shaders.SMCLog/]: [Shaders] OpenGL error: 1281 (Invalid value), program: gbuffers_textured_lit (none), at: pre-useProgram
[06Srp2020 10:22:43.677] [Render thread/ERROR] [net.optifine.shaders.SMCLog/]: [Shaders] OpenGL error: 1281 (Invalid value), program: gbuffers_water (none), at: pre-useProgram
It keeps repeating until you move to a location where no double slabs are placed or you disable render regions feature
On the screenshots below, you can see what happens when I slightly move a mouse:

It would be nice to have this bug fixed since I think a lot of people use Optifine and Double Slabs and render distance feature rids of the annoying vanilla rendering and gives you so much FPS boost. If you need more information, I'll try to answer as soon as possible.
Thank you in advance for solving.
Wolf

Hi there! Apologies for the extremely delayed response.. I have some great news! This is finally fixed!!! For now it is only for 1.16 but I will be backporting to older versions as soon as I can :)


Update sbt-ci-release to 1.5.12

About this PR
📦 Updates com.github.sbt:sbt-ci-release from 1.5.10 to 1.5.12
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-ci-release" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.sbt", artifactId = "sbt-ci-release" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #448.

Superseded by #450.


Update storage tests

Codecov Report

Merging #2556 into master will increase coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
+ Coverage   72.13%   72.19%   +0.06%
==========================================
  Files         362      362
  Lines       19776    19772       -4
  Branches     2920     2918       -2
==========================================
+ Hits        14266    14275       +9
+ Misses       4589     4580       -9
+ Partials      921      917       -4

Impacted Files
Coverage Δ

...rc/azure-cli-testsdk/azure/cli/testsdk/checkers.py
78.57% <ø> (+9.82%)
:arrow_up:

src/azure-cli-testsdk/azure/cli/testsdk/base.py
57.03% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/_output.py
61.4% <0%> (-1.17%)
:arrow_down:

...li-core/azure/cli/core/test_utils/vcr_test_base.py
73.68% <0%> (-0.62%)
:arrow_down:

...torage/azure/cli/command_modules/storage/custom.py
86.89% <0%> (+0.87%)
:arrow_up:

...c/azure-cli-testsdk/azure/cli/testsdk/preparers.py
69.3% <0%> (+1.98%)
:arrow_up:

...cli-core/azure/cli/core/commands/client_factory.py
86.11% <0%> (+2.77%)
:arrow_up:

...rofile/azure/cli/command_modules/profile/custom.py
25.75% <0%> (+3.03%)
:arrow_up:

...rage/azure/cli/command_modules/storage/_factory.py
97.5% <0%> (+12.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232beb7...5780de0. Read the comment docs.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
patch
8.15.15 -> 8.15.16

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.19.7 -> 1.19.8

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.15.16
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/secrets-manager/ibm to v1.19.7 (#803) (028ed4d)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.19.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.15.7 (#258) (af11cdb)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.15.8 :tada:
The release is available on:

GitHub release
v1.15.8

Your semantic-release bot :package::rocket:


Stats on dashboard and status page don't match up

Numbers are slightly different, possibly related to published count from response_sets and certificates

The sum of [raw, pilot, standard, exemplar] certificate counts is slightly less (starting in november by 1, and then 2 in december) than the total count in /status.csv&type=published

@sumikasan and @pkqk to have a timeboxed discussion on how to count things.

https://github.com/theodi/open-data-certificate/issues/1092

@Floppy hey, do you want to look into which page calculates the stats wrong? Pls reopen in odi shared if so.


RSS Feed feature

Hi, I request add a feature about RSS Feed.
I always using Feedly for checking trend news.
If this site output several RSS (new repos/ranking/trend feed etc) weekly, it will be awesome!
thanks.

Hello @tomothumb ,
Thank you for the suggestion!
First, since the pages are automatically built every day, I think we could implement a daily RSS feed about the overall rankings, do you think it would be useful ?

umm,
Almost of days, feed shows rankings same as yesterday's one. isn't it?
It seems that a daily feed with ranking is too enough information in my case.
What do you think?
I only want to check the trend actually, like this page.
http://bestof.js.org/projects/trending/this-week
I have no idea what is the best one.

Hello @tomothumb
I am doing tests right now, trying to create a "Weekly trends" RSS feed.
So I created this RSS feed:
http://bestofjs.surge.sh/rss/weekly-trends.xml
<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0">
  <channel>
    <title>Best of JavaScript - Weekly trends</title>
    <link>http://bestof.js.org/projects/trending/this-week</link>
    <pubDate>Sat Jun 17 2017 22:11:58 GMT+0900 (JST)</pubDate>
    <lastBuildDate>Sat Jun 17 2017 22:11:58 GMT+0900 (JST)</lastBuildDate>
    <item>
      <title>gun [+164 stars this week]</title>
      <author>amark</author>
      <description>A realtime, decentralized, offline-first, graph database engine.</description>
      <link>http://gun.js.org/</link>
      <pubDate>2017-06-15T21:22:13.000Z</pubDate>
      <image>https://avatars.githubusercontent.com/u/433412?v=3&s=200</image>
    </item>
    <item>
      <title>Feather [+135 stars this week]</title>
      <author>colebemis</author>
      <description>Simply beautiful open source icons</description>
      <link>https://feathericons.com</link>
      <pubDate>2017-06-14T22:33:43.000Z</pubDate>
      <image>https://avatars.githubusercontent.com/u/4608155?v=3&s=200</image>
    </item>

Then, I registered to feedly.com and I subscribed to the feed, pasting the XML url.

But I don't understand the result: https://feedly.com/i/subscription/feed/http://bestofjs.surge.sh/rss/weekly-trends.xml
For example Prettier project is number 1 but it's on the XML feed.
Do you understand what's wrong?
Can you do some tests too?
Do you use feedly.com, or something else?
Thank you for your help!

Great Job!
I subscribed!
I think Feedly show 5 feeds ordered by  of each feed. Don't you think so?

Hey guys!
I too love RSS feeds and use a custom homepage via Netvibes to get most of my news.  I added the RSS feed linked to from the site, but it hasn't been updated since June 29th.  Is it still working?
https://bestof.js.org/rss/weekly-trends.xml

Hello @soluml ,
Thank you for your comment, I'm sorry but the weekly RSS feature was put on hold but I'm going to work on it to deliver as soon as possible since there are at least 2 people waiting for it!

Yea it's looking good, Netvibes is able to pull it in just fine now.  Thanks for the quick turnaround!

@soluml Thank you for having checked, any feedback about the application is always welcome.
I will confirm next Monday that the feed is correctly updated automatically, stay tuned!

@soluml FYI I have just added a link named "Weekly feed" to the bottom of the pages.
Let me know if if it's OK.

Stay tuned, we will see in less than 24 hours if the automatic weekly update works 😄 ...

Hello Benjamin @soluml,
Thank you for your patience.
As expected, the weekly feed has been updated automatically this morning, could you check if it's OK?
@tomothumb Sorry it took me a lot of time to time to implement the feature!

@michaelrambeau
Awesome and thank you update it!
Very useful. I continue to subscribe.
I have a question.
What is difference between"2d" and "5d" on this screenshot?
Is this day generated date of feed?
I don't know why only 2feeds generated 2days ago.
I will report how does it updated next week.

Hello @tomothumb ,
* d is the the number of days between the last commit, at the time of the feed publication, and today.
It's a bit difficult to explain because it seems Feedly displays on the same page results from this week and results from the previous week.
For example:

deeplearn.js project was in the feed last week but not this week. 5d means 5 days between the last commit when the feed was published and today.
React was on both feeds, but the your screenshot displays results from the previous week.

Hello @tomothumb and @soluml
Before closing the issue, can we consider that the RSS weekly feed feature is OK?
Is there anything you want me to update in the XML file that is generated every week?
https://bestof.js.org/rss/weekly-trends.xml
Thank you!

It's working for me, feel free to close.

This screenshot is newest one.
It works properly weekly.

Please close it.

Hello @tomothumb @soluml
I updated the RSS feed URL: http://weekly.bestofjs.org/rss/trends.xml
The feed is now generated from the weekly newsletter website: http://weekly.bestofjs.org/
Could please update your RSS readers and let me know if it works?
Thank you!

Working for me.

great!

Thank you very much @soluml @tomothumb


chore(deps): update common-dev-assets digest to 3bb2653

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
484ef79 -> 3bb2653

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

:tada: This PR is included in version 2.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue in getting list of roles assigned to Service principal in Java

I have an App1 (MultiTenant) which is in HomeTenant1 and has Clientid1.
This App1 is registered as Service Principal in Tenant2.
This App1 was then assigned few roles in Tenant2 on Subscription level scope. Ex. say Contributor role on Subs2 of Tenant2.
I want to determine through Java SDK how to get list of roles assigned to this SP on Tenant2.

This is possible to do via az cli az role assignment list --all --assignee
But we want to get this via Java SDK. Following is the code snipped which we tried.
import com.azure.core.credential.TokenCredential;
import com.azure.core.http.rest.PagedIterable;
import com.azure.core.management.AzureEnvironment;
import com.azure.core.management.profile.AzureProfile;
import com.azure.identity.ClientSecretCredentialBuilder;
import com.azure.resourcemanager.AzureResourceManager;
import com.azure.resourcemanager.authorization.models.RoleAssignment;
import com.azure.resourcemanager.authorization.models.RoleDefinition;

public class AzureRoles {
private final  static String TENANT_ID = "redacted";
private final static String HOME_TENANT_ID = "redacted";
private final static String CLIENT_ID = "redacted";
private final static String SUBSCRIPTIONID = "redacted";
private final static String CLIENT_SECRET =  "redacted";

public static void main(String []args) throws Exception {
    try {
        AzureProfile profile = new AzureProfile(TENANT_ID, SUBSCRIPTIONID, AzureEnvironment.AZURE);
        TokenCredential clientSecretCredential = new ClientSecretCredentialBuilder()
                .clientId(CLIENT_ID)
                .clientSecret(CLIENT_SECRET)
                .tenantId(TENANT_ID)
                .authorityHost(profile.getEnvironment().getActiveDirectoryEndpoint())
                .build();
        System.out.println(clientSecretCredential);

        System.out.println(profile);
        AzureResourceManager azureResourceManager = AzureResourceManager
                .authenticate(clientSecretCredential, profile)
                .withSubscription(SUBSCRIPTIONID) ;
        System.out.println(azureResourceManager);
        PagedIterable<RoleAssignment> items =azureResourceManager.accessManagement().roleAssignments()
                .listByServicePrincipal("redacted");

        for (RoleAssignment item:items) {
            RoleDefinition role = azureResourceManager.accessManagement().roleDefinitions().getById(item.roleDefinitionId());
            System.out.println(role.roleName());
        }
    } catch (Exception e) {
        System.out.println(e.getMessage());
        e.printStackTrace();
    }

 }
}

Error message
com.azure.identity.ClientSecretCredential@5223e5ee
com.azure.core.management.profile.AzureProfile@bef2d72
null
java.lang.NullPointerException
at java.util.Objects.requireNonNull(Objects.java:203)
at com.azure.core.http.policy.BearerTokenAuthenticationPolicy.<init>(BearerTokenAuthenticationPolicy.java:36)
at com.azure.core.management.http.policy.ArmChallengeAuthenticationPolicy.<init>(ArmChallengeAuthenticationPolicy.java:47)
at com.azure.resourcemanager.resources.fluentcore.policy.AuthenticationPolicy.<init>(AuthenticationPolicy.java:28)
at com.azure.resourcemanager.resources.fluentcore.utils.HttpPipelineProvider.buildHttpPipeline(HttpPipelineProvider.java:74)
at com.azure.resourcemanager.resources.fluentcore.utils.HttpPipelineProvider.buildHttpPipeline(HttpPipelineProvider.java:45)
at com.azure.resourcemanager.AzureResourceManager.authenticate(AzureResourceManager.java:163)
at AzureRoles.main(AzureRoles.java:32)

We also posted on StackOverflow but no responses there. Thanks for the help.

@nikunj-badjatya
There appears something inconsistent in your code or runtime.
From the stack:
at java.util.Objects.requireNonNull(Objects.java:203)
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core/src/main/java/com/azure/core/http/policy/BearerTokenAuthenticationPolicy.java#L36
credential is null, hence the exception.
However
at com.azure.resourcemanager.resources.fluentcore.utils.HttpPipelineProvider.buildHttpPipeline(HttpPipelineProvider.java:74)
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/utils/HttpPipelineProvider.java#L73-L75
credential is not null as it is guarded by if.
Would you take a look on your dependencies (ref https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/resourcemanager#dependency-management), and make sure your azure-core is latest (1.17.0 or above), as well as azure-core-management (1.3.0 or above)?

Thank you @weidongxu-microsoft
That was indeed the issue. It also required to use the jackson databind lib >=  2.12.1.


Error: Cannot find module 'lodash' at Function.Module._resolveFilename

When calling puphpeteer by running the default example, a mighty error shows up. It wraps a js error: "Error: Cannot find module 'lodash' at Function.Module._resolveFilename".
To solve it run "npm install" in both "\vendor\nesk\rialto" and "\vendor\nesk\puphpeteer"
windows server 2016 standard
puphpeteer 1.3.0
node 10.10
php 7.2.8
npm

You probably didn't run npm install @nesk/puphpeteer in your project directory, this is a requirement.


[testtools] Move TestConfig defaults to standalone configurable global wrapper

It's kinda annoying to repeat TestConfig setup through several tests, so I think it might be a good idea to move those values to global wrapper.

Thanks!


nsqd go test fails: undefined: nsq.DeferredPublish

dieter@dieter-m6800 cd $GOPATH/src/github.com/bitly/nsq/nsqd
dieter@dieter-m6800 nsqd git show
commit fd6260466583555ba8e9a4884a7f39cabb36f893
Merge: df41bf9 e188f40
Author: Matt Reiferson<EMAIL_ADDRESS>Date:   Fri Jul 31 13:46:41 2015 -0700

    Merge pull request #612 from jehiah/nsqadmin_response_612

    nsqadmin: format responses

dieter@dieter-m6800 nsqd git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean
dieter@dieter-m6800 nsqd go test
# github.com/bitly/nsq/nsqd
./protocol_v2_test.go:572: undefined: nsq.DeferredPublish
./protocol_v2_test.go:588: undefined: nsq.DeferredPublish
FAIL	github.com/bitly/nsq/nsqd [build failed]

just me?
all looks good on travis:
https://travis-ci.org/bitly/nsq/builds

my mistake. had to run:
go get -u github.com/bitly/go-nsq


Fix evaluate passing data code snippet

I add 'args' key to message variable because it didn't work. There was missing part.

@snowron thanks for the contrib. This repo requires that the commits be signed. Please see details here: https://github.com/getgauge/taiko/pull/1955/checks?check_run_id=2194211090

Tried twice to pass the tests but 'FTs - NodeJS 14 & ubuntu-latest' always break the pipeline. Unfortunately dependency bot has same problem.


fix(#65850): Handle rejected echo modules

Description
When loading the modules, we were using Promise.all to resolve the module promises. This meant that if one module was rejected due to an error, all of them would be rejected.
To properly handle rejected modules, we switch to using Promise.allSettled so we can filter out the resolved modules.
Remarks
A module might be rejected due to, e.g., a fileUri which is not approved by our CORS policy. This is a safe guard so the rejected module does not affect the rest of the app. The rejected module will still show up as a blank page, but the other modules will not be affected.
How to test
The test branch should be running with this version of base. The camera module will be blank, and there will be an error in the console saying that the module could not load. The rest of the app should work fine.
PS:
Made the mistake of calling a function twice in the test branch version. So if you see a doubled amount of certain messages in the console, then that's the reason 😅

Nice to see what caused the bug. 👏


Vsock locking fixes

Various issues found by running hvgostress from https://github.com/rneugeba/virtsock and from investigations of https://github.com/docker/for-mac/issues/825 (although sadly even these do not fix that issue).

I have to admit that I don't understand the intricacies of the code, but:

your detailed descriptions seem to match the patches
I trust you ran the stress test program and it passes with the fixes

Based on this, LGTM


Some active solenoids have repeated on status events

Haven't seen this and wouldn't have much impact.


No info about setup wizard in help

The setup command does not appear when running gopass -h
Related: #390

So far this is intended. There are already way too many subcommands cluttering the help output and this one is usually not required.
If there is specific reason for this command to show up in the help output we can remove the hidden flag.

Can/should it only be run once? I thought "Join a team" could be possible multiple times.

Right now it's designed to be run only once. Of course one might want to use it to join multiple teams, but these use-cases haven't been implemented, yet. I'd like to get there at some point and then it would definitely make sense to expose it as a subcommand, but for now it might be too confusing.

OK, please close at will.


runWhenRecordStable

I'm a bit confused in regards to runWhenRecordStable. What is it for? Why does it live in the record handler when it is only used by the rule application?

Use to only allow permission handler to run once the record transitions are queued. This is to allow permissions to always be run against the latest record value rather than an outdated one.


[showif],[playashowif]... not work Class inheritance

me again 2!
Unity2022.3.16
public class TestBase : MonoBehaviour
{
    public bool haveInfo;
    [PlayaShowIf(nameof(haveInfo))]public string infoTextureName;

    public bool isInt;
    [ShowIf(nameof(isInt))] public int intA;
}
public class Test : TestBase
{
    [Space(20)]
    public bool isString;
    [ShowIf("isString")]
    public string strA;

    public bool haveInfo2;
    [PlayaShowIf(nameof(haveInfo2))] public string infoTextureName2;
}

Hi, please upgrade to "2.2.0" to see if it's fixed.


How to continue training using my voice from already pre-trained checkpoint?

I understood:
python train.py -c configs/vocos.yaml --trainer.resume_from_checkpoint last.ckpt


Call to undefined method upsert()

Receiving on Laravel  ^7.0
Call to undefined method Illuminate\Database\Query\Builder::upsert()

I believe the issue is related to another package we are using: https://github.com/michaeldyrynda/laravel-efficient-uuid
In Staudenmeir\LaravelUpsert\Connectors\ConnectionFactory::createConnection() the custom connection is never used

These packages do indeed interfere with each other.
Are you using upsert() on an Eloquent model? If so, you can add the HasUpsertQueries trait to the model: https://github.com/staudenmeir/laravel-upsert#eloquent

Perfect, I will inject the Builder via my service's constructor...! Thank you.


C_CPP : Valid Brackets using Stack in C++

Description
This documentation will explain whether the expression have Valid Brackets or Not using Stack in C++
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


How to get @rid in javascript function

running code in studio functions
var db = orient.getDatabase();
// create department
var dep_name = "some name";
var cmd = "insert into departments (name) values ('"+dep_name+"')";
var result_dep = db.command(cmd);
 // how to get '@rid'

want to create an edge
// create edge
var cmd = "create edge dep_person from ("+result_dep +") to ("+result_person+")";
var dep_person_edge = db.command(cmd);

its not working

Try this:
var rid = result_dep.getRecord().field('@rid');
You can also get other properties in this way, just replace the '@rid' with another property name.


[WIP] Refactor the client options into its own Configuration class

Q
A

Branch?
2.0

Bug fix?
no

New feature?
yes

BC breaks?
yes

Deprecations?
no

Tests pass?
no

License
MIT

Continuing the refactoring of the client class this PR extracts the configuration options into its own class, as seen in other common libraries and in the Sentry Ruby SDK itself. This is a work in progress and there is still a lot to do before this can even be considered for review, but I want to show the current progress so far on the subject because it may impact other feature requests that needs to add options to the client

Okay. If you want to refactor entire project just do all properties protected and we can close PR #457

just do all properties protected

It's not so easy, this is why this PR requires time to get it working. Having all public means that even a single change break everything else that depends on it. Also, #457 is still valid, it's just that if this PR gets merged you won't have to work on the variables related to the configuration of the client

This PR and #457 are conflicting

It's conflicting only about the variables of the options, everything else is ok

@ste93cry if you will do "sending_allowed" (#458) please add it to method "capture" and remove a predicate from "send"
Just as I desribed in https://github.com/getsentry/sentry-php/pull/458#issuecomment-302398846

I do agree with the approach of this PR. Having a dedicated, immutable object for the config that can be passed around without having to worry about side effects is the best approach.

Oh, lord. This class is immutable. And how I supposed to change a behaviour after creating Raven Client?
And do not tell me this is not necessary. A instance can do install. And after that I must be able to change any settings (message limit, release, tags, global tags, error_types...) of some instance which waits for some events (i.e. shutdown). Maybe I will want to set new filters for incoming events (i.e. exceptions)

Why should you change those stuff inside the same request? What scenario do you imagine where such this should be needed?
Anyhow, you can always re-set the whole object if you want. Immutability is in place just to prevent that, if you reuse the same config in two places, you can inadvertently make modifications in two places with one change.

Why should you change those stuff inside the same request?

There is no "request". There is only code flow. Do not forget PHP can do a job for hours.
I may want to add some tags or another after some specific events. And then I may want to change release or environment. There is so many scenarios.
Ideal library should be as flexible as it can.

Understood. I still believe that an object is the way to go: it makes more explicit what options are supported, and it make code less error prone.

Oh, lord. This class is immutable

This class was never meant to be immutable. Setters were missing just because code was not ready yet and I had to fix a huge amount of unit tests before thinking to add setters methods to change the options on-the-fly. If you had read the description you would have seen that it was written that the job is not over...

Ok so my mistake, I thought it was immutable. Then I think we should all agree.
The only thing that I would suggest would be to clone the object on assignation, to avoid errors like the one that I suggested before:

... if you reuse the same config in two places, you can inadvertently make modifications in two places with one change.

Please don't forget to edit README

I was thinking about a potential issue with the options related to the DSN. Currently, the following options are exposed to be configured by the user (it's the same in the Ruby SDK):

server
scheme
host
path
port
project_id
project_root
secret_key
public_key

Let's suppose that the user provides the server option. In this case, all other options (if not configured individually) will be overridden with values extracted from the first one and this is fine. However, what should happen when those options are specified by the user? The problem arises here: the server option won't be in sync anymore with the other options creating confusion and possible problems when the user retrieves the configuration and expects the options to all represent the same DSN while instead it's a mess. When creating a project in Sentry the user is always provided a full DSN string, not the single parts that compose it. My proposal is to remove all options except the first one from being configurable. You can still get the values through getters, but you won't be able anymore to edit them. The only way to change them is to specify a different DSN. This way there will be only one source of truth for the options related to the server endpoint. @dcramer What do you think about this?

We could do one of this set ([server] and [scheme, host, path,..]) virtual. And one of them will be made from another. So they always will be consistent

We could do one of this set ([server] and [scheme, host, path,..]) virtual. And one of them will be made from another

I honestly don't understand what you mean... By the way, the DSN has all the information to configure the port, host, etc so I don't see any good reason to expose setters for options except the DSN string itself

We could do one of this set ([server] and [scheme, host, path,..]) virtual. And one of them will be made from another

I honestly don't understand what you mean... By the way, the DSN has all the information to configure the port, host, etc so I don't see any good reason to expose setters for options except the DSN string itself...

Agreed: we don't need setters for the individual bits. You should just bind a DSN/rebind the whole DSN upon chaneg.

Does it make sense to keep getters for the individual parts of the DSN? I can't find any good reason for them too

Yes. I think we can safely remove getters and setters for parts of DSN. Only getter/setter for DSN itself is important

If splitted parts of DSN are not needed even for Curl calls, I agree too.

Anyone knows what the site option does? I can't find its corresponding option in the Ruby SDK

@nokitakaze its deprecated/legacy

https://github.com/getsentry/sentry-php/blob/master/lib/Raven/Client.php#L77
Is this legacy? Should we delete ie or replace by some new field?

@nokitakaze we haven't removed it from SDKs, but most wont send it if its not configured

@ste93cry how much time are you planning to spent until this PR will work?

I'm currently working on a prototype of the client builder class, so that users don't have to instantiate the client by themselves. At the moment it will be pretty useless apart from the ability to set the configuration options, but the idea is in the future to add methods to set the factories for the various things like the serializer, the processors, etc as discussed elsewhere. I plan to get it working for the end of the week, as I'm currently very busy with my work

I've added a ClientBuilder class to ease the construction of a client. It's pretty empty right now, but it's the base for new features as said above. All it does right now is to just forward existing methods calls to the underlying configuration object. Since the site option is deprecated, I removed it from the list of options and it's not sent anymore to Sentry. A few remaining questions:

There is a message_limit option that was added in #182, but its doc says that it's not guaranteed that length of whole message will be restricted by this value. Does it makes sense then to let's it be configurable?
After rebasing on top of 2.0 branch, I noticed that in the composer.json the minimum-stability is now set to dev: this way all dependencies are installed from the dev branch and this is dangerous to say the least
As I'm now using the composer/ca-bundle package to find where the cacert.pem file is located should we remove it from the data folder?. Using directly the fallback file from ca-bundle means that we don't have to keep it up to date anymore as it won't be our problem.

should we remove it from the data folder?

Yes

Good job on the Client builder.
I am against the "minimum-stability": "dev" too.

I am against the "minimum-stability": "dev" too

Add this patch and combine/squize the PR
From 901f86c03202148a2f5fb584e0716a1a1112d890 Mon Sep 17 00:00:00 2001
From: Nokita Kaze<EMAIL_ADDRESS>Date: Mon, 5 Jun 2017 20:19:02 +0300
Subject: [PATCH] Change dependency

---
 composer.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/composer.json b/composer.json
index 4ae3944..095c024 100644
--- a/composer.json
+++ b/composer.json
@@ -12,6 +12,7 @@
         }
     ],
     "minimum-stability": "dev",
+    "prefer-stable": true,
     "require-dev": {
         "friendsofphp/php-cs-fixer": "~2.1",
         "phpunit/phpunit": "^4.8 || ^5.0",
--
2.7.1.windows.2

We're a bit off-topic... Anyway, using "prefer-stable": true should indeed work, but I still don't understand why there is the minimum-stability set to dev. There is no need to do that, if you have a library that doesn't have a stable tag then use as constraint library@dev

Can we please go ahead with this? It's a huge blocker for everything else (starting with #472 #473 ).

I said my word

So you are opposing this whole PR just because we are requiring the config in the constructor?
It only makes sense, the client cannot work without it and it's a failsafe to avoid initialized clients with messed up options.

I like this approach moving the configuration options to it's own class.
IMO this adds clarity when you see some configuration value retrieved you know where it's coming from instead of the old way where it was retrieved from a client accessor directly, made it less opaque it is a configurable value.

Okay, go to h..l
I said again that @dcramer said "arrays is fine here" https://github.com/getsentry/sentry-php/pull/462#discussion_r117855927

@nokitakaze I don't like playing babysitter, but we're either going to be friendly here or I'm going to start removing people from the project.

@dcramer Before merging I would like to know your opinion on this point:

There is a message_limit option that was added in #182, but its doc says that it's not guaranteed that length of whole message will be restricted by this value. Does it makes sense then to let it be configurable?

From what I can see from other SDKs there doesn't seem to be such an option

@ste93cry I dont think we need to provide it. The server enforces restrictions, and at some point we're going to build a simply proxy for people concerned about doing it client side.


array.view with no arguments

Numpy arrays allow a call to .view() with no arguments passed. This constructs a new numpy array that is backed by the same data, ie the same memory as the original array and is useful when you need to just locally change the metadata, like the shape.
Dask requires the first argument, dtype, breaking some otherwise agnostic code.
In the MVE, the numpy part works, the dask part shows the breakage.
import dask.array as da
import numpy as np

n = np.array([1, 2, 3])
v = n.view()
v[1] = 10
print(n)

d = da.from_array(n)
dv = d.view()
dv[2] = 20
print(d)

Would you consider changing dask to also accept calls without arguments?

Yep, that seems reasonable.

@zklaus are you interested in submitting a PR? (no obligation though)

Sorry, too swamped at the moment and on the brink of my summer vacation.
I did have a quick look, but there are too many things confusing me at the moment, both in the original numpy implementation and in the view handling of dask. For example it seems that
dask_array[:] is not giving a view, but the original array, in contrast to numpy?
If this is still open at the end of September, I might have another look.

A fix for this issue went in as of #5736.
In [15]: import numpy as np

In [16]: import dask.array as da

In [17]: n = np.array([1, 2, 3])

In [18]: d = da.from_array(n)

In [19]: dv = d.view()

Is it ok to close this?

Thanks for following up on this issue @andersy005! Closing


[Select] Update Select style

https://www.radix-ui.com/docs/primitives/components/select :tada:

@seedy Study value of integrating radix-ui 's component shortly


Version.hpp Shouldn't Define MAT* and PAL* Namespace Macros

Problem
Version.hpp does two things right now:

#define the MAT* and PAL* Namespace macros.
Initialize the Version constant value and generated strings.

As a result of 1 above, Version.hpp is #included in nearly - if not all - files in the SDK. This means that any change to Version.hpp will invalidate any previous builds of anything which includes it. This can be frustrating for developers, as Version.hpp will be updated on their local device every day as part of running the build scripts, or can be updated by git pulling in an updated copy of Version.hpp as part of a release. Thus leaving work one night and starting again the next morning may force a complete rebuild of the SDK, where only a couple files may have changed.
Proposed Solution
Move #defines for the MAT* and PAL* Namespace macros to another file (possibly CTMacros.h, possibly a new file). This will allow faster incremental builds for developers, as Version.hpp updates will only require rebuilds of files which use the Version constant or strings (rather than the entire SDK).

Resoved with PR 779


Download tracker deletes volumes and does not upgrade new chapters

What happened ?
Hi, currently I have an issue with the 3.0 test version, where when using download tracker, it always deletes the first two already downloaded volumes, and then redownloads them again. The rest of the volumes are skipped, however it did not download the latest chapter to update the latest volume. It seems to do it with several (all?) mangas, always deleting the first two volumes.
The latest stable version (v2.10.3) works as intended, but there I guess I couldn't use my own volume names when downloading.
What did you expect to happen ?
Skip all the previous volumes, since nothing has changed in them, and download the latest chapter when it was added to the latest volume.
OS version
Windows 11
App version
It says the following, but I downloaded it from here: https://github.com/mansuf/mangadex-downloader/actions/runs/8036099722
mangadex-downloader v2.10.3 (https://github.com/mansuf/mangadex-downloader)
Python: 3.10.11
arch: x64
bundled executable: yes
Installation origin
Github releases
Installation origin (other sources)
https://github.com/mansuf/mangadex-downloader/actions/runs/8036099722
Reproducible command
mangadex-dl https://mangadex.org/title/e1e38166-20e4-4468-9370-187f985c550e/mato-seihei-no-slave --language "en" --use-volume-cover --volume-cover-language "ja" --no-group-name --delay-requests 0.2 --save-as cbz-volume --path "Y:/Unsorted_Mangadex_E/{manga.title}" --filename-volume "{manga.title} Vol. {volume}{file_ext}"
Additional context
No response

Note: This patch contain migrations for download tracker, your download tracker database will be migrated to a new version. So i suggest you to backup downloaded manga before testing it.
This has been fixed in commit c08f95c in v3.0.0 branch. You can try install the patched version from here in "artifacts" section when the status is success.
If you have any problem related to this issue, please let me know 👍.


dotnet core sdk 2.1.300 not support

it's newer than 2.1.300 preview2

Thanks for reporting this. We are looking into it

please update to 0.25.0, it should be fine - dotnet tool update dotnet-script -g

@filipw still has problem:
The error means "Can't find out 'dotnet-script' command's executable file"

this looks like an issue with dotnet SDK itself, maybe it didn't generate the launch exe correctly.
try going to C:\Users\{user}\.dotnet\tools and delete dotnet-script.exe and dotnet-script.startupconfig.json from there, and then to C:\Users\{user}\.dotnet\tools\.store and delete dotnet-script folder.
Then run fresh install again using dotnet tool install dotnet-script -g, this should hopefully fix it.

@filipw I tried above steps except delete xxx.json, because this file is not exists, even I find it use a tool called "everything", actually, these steps same with "dotnet tool uninstall -g dotnet-script", and the problem still exists. I agree it's maybe a issue of dotnet SDK, I'll try go to their repository post issue. Thank you.

does it work with other tools? could you try i.e. dotnet tool install dotnet-serve -g? and then run dotnet serve.
I'd expect that to fail in your case too then

@filipw same issue

yeah then definitely something is wrong with the .NET SDK here. could be (just wild guess) an issue with localization?
I saw you opened an issue here https://github.com/dotnet/cli/issues/9396 - thanks 👍
Will follow this too, I'm also interested in understanding what is going on here

@filipw Thank you for add issue reference. I hope it's a generic problem, not only me : (

@filipw That issue is solved, I think the reason is Envionment variables too much. Anyway, use your tool already help me run the csx, Great, Thanks for your creation.

great 👍


chaining promises

Hello Max,
I run into this problem yesterday
I wrote this code to chain a few promises based on some conditions
var promise = Promise(0).asVoid()

if (condition1) {
  promise = promise.then { return otherPromise() }
}

if (condition2) {
  promise = promise.then { return otherPromise() }
}

if (condition3) {
  promise = promise.then { return otherPromise() }
}

// finally
promise.then { () -> Void in
  println("all done")
}

For some reason it was not working and I refactored it into this which works as expected
firstly {
  return condition1
    ? return Promise(0).asVoid()
    : return otherPromise()
}.then {
  return condition2
    ? return Promise(0).asVoid()
    : return otherPromise()
}.then {
  return condition3
    ? return Promise(0).asVoid()
    : return otherPromise()
}.then {
   println("all done")
}

Do you see any reason why the first snippet of code is not working? Let me know if its sounds like a bug I could add a test case to make sure things works as expected

First example is fine. What didn't work?

Yes thats what I thought too, but It didn't go through all the promises even though the condition flags where set to true,  instead it when straight to the last one

I have tests that prove what you have written works. Can you provide a test case that demonstrates it not working?

I made this test case:
https://github.com/mxcl/TestCase-223
Here's the example output:

The test case was made with Xcode 7, but could be adapted to Xcode 6.

Thks Max i will try to reproduce the test case and see why it was not working for me
Sent from my iPhone

On Jul 18, 2015, at 9:30 AM, Max Howell<EMAIL_ADDRESS>wrote:
I made this test case:
https://github.com/mxcl/TestCase-223
Here's the example output:
The test case was made with Xcode 7, but could be adapted to Xcode 6.
—
Reply to this email directly or view it on GitHub.

THks for the test case, Couldnt reproduce the bug, closing for now I let you know if I find anything

It may have been you forgot to return in a then, for a Void promise returning nothing would fulfill one variant of then, and in that case the Promise would not chain.


add: logging for debugging

If anyone has any ideas as to where else to add logs please let me know, this is temporary logging so i'd appreciate seeing more than less.

Ran this locally and I see the logs, not much use locally as I want to use them to correlate to 404's !

I think the most important log we're missing here is one when the router returns a 404, that's the bug we're chasing we should capture that data point.


Update to mui-v5 (material-ui v5)

I opted to updating the existing starters instead of adding new mui folders.
I'm amenable to renaming the material-ui starters to mui or creating a new folder if we need to maintain backward compatibility for material-ui v4 users for a bit.
Also happy to split this up to 3 PRs for the material-ui-adapter, starter/material-ui, starter/example, if that's necessary.
Since this definitely became a pretty big PR.
Resolves #168

Thanks for this! Just got back from vacation, will review as soon as I can :)

has this merged yet?

I caught this PR up to some important changes that landed in master, reviewing now.

I checked it out, fixed the build, and ran the example.

I see some small styling issues like the caps, but it works!

Great, let me know if there's anything you'd like me to address. I'm a little busy today but likely can respond from Monday onwards.

Thanks @chrisirhc. I merged in the latest master. If you're able to fix any styling issues, I can merge this next week.

Fixed the text appearing in uppercase.
Here's a new screenshot:

I'm looking into one other remaining styling issue that I found, that the menu doesn't overlap with the button:

If you see any other styling issues, let me know.

I uploaded the current version at https://chrisirhc.github.io/wallet-adapter/example/ for easy checking/testing.

Fixed the anchor issue and uploaded a new version to https://chrisirhc.github.io/wallet-adapter/example/

Looks great!


Update changed test to focus on changes introduced in current PR

The previous diff was a comparison against master. If master had
changed since the current PR was created the changed charts would
be re-tested. This could create a problem when helm was upgraded
and lint changed causing previously passing charts to fail. Since
they were not associated with the current PR it was an outlier
problem for the PR author.
The new diff does a comparison to the merge-base which ties to look
for changes introduced by the current pull request.

/cc @unguiculus @prydonius @viglesiasce

Note, this is the same diff currently in use by the circleci scripts.

Thanks for fixing this. LGTM

+100 thanks @mattfarina

/lgtm


Cursor of TextField doesn't move

When I set maxlines null and make a line break,the cursor doesn't move when I press a space at the end of the first line although it is exactly inputed.
I am sure the space was inputed because I can move the cursor after it by clicking.
This is an example program:
import 'package:flutter/material.dart';
void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key}) : super(key: key);
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            TextField (
              maxLines: null,
            )
          ],
        ),
      ),
    );
  }
}

This is my flutter doctor -v:
[√] Flutter (Channel master, v1.16.2-pre.21, on Microsoft Windows [Version
    10.0.18363.720], locale zh-CN)
    • Flutter version 1.16.2-pre.21 at E:\flutter
    • Framework revision bee45a646f (29 hours ago), 2020-03-19 21:26:01 -0400
    • Engine revision 046a4a6c2b
    • Dart version 2.8.0 (build 2.8.0-dev.16.0 5b21a43c55)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\Dorbmon\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling      support)
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

Hi @Dorbmon
I'm not sure it the situation I'm experiencing reflect the issue you are describing
is this code sample representative?
Thank you

Hi @Dorbmon
I'm not sure it the situation I'm experiencing reflect the issue you are describing
is this code sample representative?
Thank you

I tried just now,.I can make it apear on the android instead of Web.
I think it is a Android platform bug.
Thank you.

See https://github.com/flutter/flutter/issues/50033

@jason-simmons Thanks.I think it is the same problem.

@jason-simmons Thanks.I think it is the same problem.


Feat: Alignment  of header properly

Describe the feature
I think the header content is not properly aligned
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Describe the feature
I think the header content is not properly aligned
Add ScreenShots

Record

[x]  I agree to follow this project's Code of Conduct
[x]  I'm a GSSOC'24 contributor
[x]  I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


fix broken dependency on Debian Buster

The package liboauth2_1.4.1-1.bionic+1_amd64.deb has pinned on old package - libhiredis0.13 (>= 0.13.1).
I have already libhiredis0.14 installed on Debian Buster, but it's required only libhiredis0.13.

you cannot install an Ubuntu Bionic package on a Debian Buster system


Update to latest vscodetestcover

Just a minor change to get rid of an unneeded option - the package was generating its own json report but that's unnecessary since there's already a json reporter built in.
Also using published npm package instead of pulling directly from github.

Coverage decreased (-0.04%) to 34.207% when pulling 12712cf1dfc13a52db8f9ebd7f68ac73b2a40cf7 on chgagnon/updateVscodetestcover into 453f7fa5a4c6e2a855714ae7e52004e0f7c0dc01 on master.


inference output value check

Hello
I have a question.
Questions arose while using segnet-camera.py
The network uses the basic network, fcn-resnet18-cityscapes.
The output value of the classes in question, i.e. wonder what percentage of the basis there is in judging an object as a car.
I also wonder how you can know these output values.
Thank you

Hi @jh1113 , the confidence values aren't exposed via an API.   I'm not sure if softmax layer is applied in the FCN networks or not.
Here is the code where the argmax is picked:
https://github.com/dusty-nv/jetson-inference/blob/4e6b7ff37935a9bc64271119f42cd25366ce8c79/c/segNet.cpp#L763


feat: Add support for Shortuct (previously Clubhouse)

Please remember the Contributing Guidelines :heart:
:star2: What does this PR do?

Clubhouse have changed their name to Shortcut, and their domain to shortcut.com. This PR uses the old integration to add support for this new domain, skins the button to better match the website theme, and adds the ability to pulls the story id from the card.

:bug: Recommendations for testing
I have tested this on both Firefox and Chrome. The button is accessible on a card in Shortcut.

:memo: Links to relevant issues or information

Clubhouse's name is now Shortcut

Can I request this for review somehow? Our team used to use the clubhouse integration, but I have to pass around a dev build of the extension to be able to use it with shortcut and reload it every time the browser closes

I don't see the button on individual Shortcut story pages?

I don't see the Start Timer button on individual Shortcut story pages?

It's showing up for me. Have you enabled the integration in your Toggl extension options in Chrome? I don't believe it's on by default.

Hope this helps! :)

@MarkBennett - Yup I've got it enabled.  I've also tried disabling all other extensions.  I've also tried Firefox.  Maybe something with the specific Shortcut board I'm using?  If anyone needs logs, lmk and I can supply.

I am seeing the same problem as @darrenaalfonso. No Toggl button to be seen anywhere in the Shortcut UI. Enabling/disabling the integration or even the whole plugin does not help. Neither to browser restarts.

Could there be another extension interferring? I just tried again and it's working for me still. Sorry I can't be more helpful! 😛


    remove redundant (duplicate) code example

New updates on head repo.
https://github.com/vuejs/docs/commit/5c4c07601191b66bc4b8421fcf67836caf471467

resolved 923ca98b3d88de770ff2df10a516078545568a33


[20.09] python3Packages.requests-aws4auth: fix build

(cherry picked from commit 5f0f2b85cb86770d362f57bc6ac048ba04cbaf7d)

Motivation for this change
ZHF: #97479
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 98221 1

4 packages built:

elasticsearch-curator
python27Packages.requests-aws4auth
python37Packages.requests-aws4auth
python38Packages.requests-aws4auth


Using Proxies List

Hi, some websites cannot be crawled because are blocking the access, how can I implant a proxy to be used with the crawler?
Thank you

Addressed here: https://github.com/brendonboshell/supercrawler/issues/13#issuecomment-350482016


Update Laravel to 5.1.11

This will allow use of the authorization features.

Done in a82478c33fd98c4541e37d615147ffbf9d5f96a3


feat: add oracle and serverless

Please read the Contributions Guide before making Pull Requests.

Please check https://github.com/antfu/case-police/blob/main/CONTRIBUTING.md#dictionary-guidelines
Do you have a case that those two words might be misspelled?


os.system error on NET CORE

The code:
import os
os.system("dir")

Error got:
System.TypeLoadException: Could not load type 'System.Runtime.CompilerServices.Closure' from assembly 'System.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.

Does the StdLib doesn't adapt to net core yes?

Are you using some compiled (with the .NET Framework) Python code? This will not work with .NET Core. Unfortunately there is no way to compile Python code into a DLL with .NET Core.

I try to compile Python code into a Dll with .NET Core, got error:
System.NotSupportedException: Specified method is not supported.
   at Microsoft.Scripting.SavableScriptCode.CompileForSave(TypeGen typeGen)
   at Microsoft.Scripting.SavableScriptCode.SaveToAssembly(String assemblyName, IDictionary`2 assemblyAttributes, SavableScriptCode[] codes)

Can we implement the CompileForSave method by ourself?

Right now it uses AssemblyBuilder.Save which isn't available on .NET Core, so probably not easily...

Duplicate of https://github.com/IronLanguages/ironpython2/issues/351


feat: add easing types for setang tas tool

Adds three additional easing types when interpolating to the desired angle using setang TAS automation tool: sine/sin, cubic and exponential/exp. A type should be given as a fourth parameter to setang. By default, it's still using linear interpolation, meaning this change should be backwards-compatible and doesn't require new script version.
All interpolation type went through very basic tests (me running a single setang for each type), but it would be nice for someone to make some further testing:

verify if previously made TAS scripts still function properly
attempt to interrupt setang with another setang
check what happens if you pass through the portal while setang is in use and if the behaviour is consistent with previous version

i cant be fucked to read this imma trust you
don't break the tools


Files in /usr/local/go are processed

I'm not (yet) sure why, but some linters generate a report from /usr/local/go.
mark@Dymek:$ gometalinter -j4 --vendor --deadline=30s -t . | grep '^/'
/usr/local/go/src/os/user/lookup.go:9:9:warning: undeclared name: current (unconvert)
/usr/local/go/src/os/user/lookup.go:15:9:warning: undeclared name: lookup (unconvert)
/usr/local/go/src/os/user/lookup.go:21:9:warning: undeclared name: lookupId (unconvert)
/usr/local/go/src/net/lookup_unix.go:55:24:warning: undeclared name: cgoLookupHost (unconvert)
/usr/local/go/src/net/lookup_unix.go:67:24:warning: undeclared name: cgoLookupIP (unconvert)
/usr/local/go/src/net/lookup_unix.go:78:23:warning: undeclared name: cgoLookupPort (unconvert)
/usr/local/go/src/net/lookup_unix.go:87:24:warning: undeclared name: cgoLookupCNAME (unconvert)
/usr/local/go/src/net/lookup_unix.go:154:23:warning: undeclared name: cgoLookupPTR (unconvert)
/usr/local/go/src/crypto/x509/root.go:15:10:warning: undeclared name: initSystemRoots (unconvert)
/usr/local/go/src/os/user/lookup.go:9:9:warning: unused global variable undeclared name: current (varcheck)
/usr/local/go/src/os/user/lookup.go:15:9:warning: unused global variable undeclared name: lookup (varcheck)
/usr/local/go/src/os/user/lookup.go:21:9:warning: unused global variable undeclared name: lookupId (varcheck)
/usr/local/go/src/net/lookup_unix.go:55:24:warning: unused global variable undeclared name: cgoLookupHost (varcheck)
/usr/local/go/src/net/lookup_unix.go:67:24:warning: unused global variable undeclared name: cgoLookupIP (varcheck)
/usr/local/go/src/net/lookup_unix.go:78:23:warning: unused global variable undeclared name: cgoLookupPort (varcheck)
/usr/local/go/src/net/lookup_unix.go:87:24:warning: unused global variable undeclared name: cgoLookupCNAME (varcheck)
/usr/local/go/src/net/lookup_unix.go:154:23:warning: unused global variable undeclared name: cgoLookupPTR (varcheck)
/usr/local/go/src/crypto/x509/root.go:15:10:warning: unused global variable undeclared name: initSystemRoots (varcheck)
/usr/local/go/src/os/user/lookup.go:9:9:warning: unused struct field undeclared name: current (structcheck)
/usr/local/go/src/os/user/lookup.go:15:9:warning: unused struct field undeclared name: lookup (structcheck)
/usr/local/go/src/os/user/lookup.go:21:9:warning: unused struct field undeclared name: lookupId (structcheck)
/usr/local/go/src/net/lookup_unix.go:55:24:warning: unused struct field undeclared name: cgoLookupHost (structcheck)
/usr/local/go/src/net/lookup_unix.go:67:24:warning: unused struct field undeclared name: cgoLookupIP (structcheck)
/usr/local/go/src/net/lookup_unix.go:78:23:warning: unused struct field undeclared name: cgoLookupPort (structcheck)
/usr/local/go/src/net/lookup_unix.go:87:24:warning: unused struct field undeclared name: cgoLookupCNAME (structcheck)
/usr/local/go/src/net/lookup_unix.go:154:23:warning: unused struct field undeclared name: cgoLookupPTR (structcheck)
/usr/local/go/src/crypto/x509/root.go:15:10:warning: unused struct field undeclared name: initSystemRoots (structcheck)
/usr/local/go/src/os/user/lookup.go:9:9:warning: undeclared name: current (aligncheck)
/usr/local/go/src/os/user/lookup.go:15:9:warning: undeclared name: lookup (aligncheck)
/usr/local/go/src/os/user/lookup.go:21:9:warning: undeclared name: lookupId (aligncheck)
/usr/local/go/src/net/lookup_unix.go:55:24:warning: undeclared name: cgoLookupHost (aligncheck)
/usr/local/go/src/net/lookup_unix.go:67:24:warning: undeclared name: cgoLookupIP (aligncheck)
/usr/local/go/src/net/lookup_unix.go:78:23:warning: undeclared name: cgoLookupPort (aligncheck)
/usr/local/go/src/net/lookup_unix.go:87:24:warning: undeclared name: cgoLookupCNAME (aligncheck)
/usr/local/go/src/net/lookup_unix.go:154:23:warning: undeclared name: cgoLookupPTR (aligncheck)
/usr/local/go/src/crypto/x509/root.go:15:10:warning: undeclared name: initSystemRoots (aligncheck)

I'm on go version go1.6.2 darwin/amd64
mark@Dymek:$ set | grep ^GO
GOBIN=/Users/mark/Development/GO/bin
GOPATH=/Users/mark/Development/GO
GOROOT=/usr/local/go

/usr/local/go is a symlink, not sure if that's significant.
I've just ran gometalinter -fui with the assumption that all linters are up-to-date.

Can you walk through the steps in the contributing file? If it's a problem with a linter you should report it to that linter.

Hi,
I did but I kinda figured that if 4 linters produced the same behaviour that it wasn't related to those linters specifically. I also checked the two repositories and noone else filed a related bug, which struck me as weird. I can't be the only one with this problem...
But based on your reply I'm guessing I was wrong in that assumption!

@Dynom did you ever found out what the real cause was?

No I haven't found the root cause @bkleef. If you have the same issues and updating cgo/clang doesn't solve it than good luck!

@Dynom I fixed it by moving /usr/local/go/bin/go to /usr/local/bin/go by ln -s /usr/local/go/bin/go /usr/local/bin/go and updated PATH from /go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin to /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin.

I encounter the same problem, and tried the solutions suggested above, but it did not work.
I have to rely on the exclude option, --exclude=/go/src/ should solve it

I occasionally see the same issue.  Using exclude as well. Not sure how to reproduce.

I'm having the same issue.
I'm running gometalinter.v1 with path "." and it complains about errors in /usr/local/go/src/os/*

@rayzyar if you use the exclude option it still checks the files but ignores the output. So it takes more time than required which is far from perfect.

This only occurs on Alpine based official Golang Docker images (golang:alpine) and not on (golang:latest) which is Debian based.
Reproduce by:
go get -u github.com/alecthomas/gometalinter
go gometalinter --install --debug
gometalinter --vendored-linters --vendor --disable-all -E vetshadow -E varcheck -E errcheck -E dupl -E ineffassign -E unconvert -E gosimple -E staticcheck -E gofmt -E unused --deadline=300s ./...

As already mentioned one fix is to install gcc and the stdin (should be musl-dev on alpine).
Another option is to set CGO_ENABLED=0

I suspect there is a race condition involved. I see this output sporadically. Without knowing the inner workings, perhaps the linting sometimes starts before the C compiler finishes. Or there might be problems with gometalinter running multiple linters concurrently, and having more than one of them try to invoke the compiler.
Another possibility could be the compiler failing somehow (perhaps running out of memory).
Will try the CGO_ENABLED=0 workaround.

I've been getting this in circleci. It's intermittent and re-running usually fixes it so signs do point to a race condition. I've been using circleci/golang:1.8. Here's the errors from different failed builds.
gometalinter --disable gotype --disable gotypex --disable=gocyclo --disable golint --enable=megacheck --enable=unparam --linter='gas:gas -exclude=G104 -fmt=csv:^(?P<path>.*?\.go),(?P<line>\d+),(?P<message>[^,]+,[^,]+,[^,]+)' --deadline=300s --vendor -t --line-length=120 --skip server/static ./...
../../../../../usr/local/go/src/net/lookup_unix.go:54:24:warning: unused struct field undeclared name: cgoLookupHost (structcheck)
../../../../../usr/local/go/src/net/lookup_unix.go:69:24:warning: unused struct field undeclared name: cgoLookupIP (structcheck)
../../../../../usr/local/go/src/net/lookup_unix.go:81:23:warning: unused struct field undeclared name: cgoLookupPort (structcheck)
../../../../../usr/local/go/src/net/lookup_unix.go:97:24:warning: unused struct field undeclared name: cgoLookupCNAME (structcheck)
../../../../../usr/local/go/src/net/lookup_unix.go:164:23:warning: unused struct field undeclared name: cgoLookupPTR (structcheck)

gometalinter --disable gotype --disable gotypex --disable=gocyclo --disable golint --enable=megacheck --enable=unparam --deadline=300s --vendor -t --line-length=120 $(find . -type f -name '*.go' ! -path "./vendor/*" ! -path "./server/static/bindata_assetfs.go" ! -path "**/mocks/*" | xargs -I '{}' dirname '{}' | sort -u)
../../../../../usr/local/go/src/net/lookup_unix.go:54:24:warning: undeclared name: cgoLookupHost (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:69:24:warning: undeclared name: cgoLookupIP (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:81:23:warning: undeclared name: cgoLookupPort (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:97:24:warning: undeclared name: cgoLookupCNAME (interfacer)
../../../../../usr/local/go/src/net/lookup_unix.go:164:23:warning: undeclared name: cgoLookupPTR (interfacer)

gometalinter --disable gotype --disable gotypex --disable=gocyclo --disable golint --enable=megacheck --enable=unparam --deadline=300s --vendor -t --line-length=120 $(find . -type f -name '*.go' ! -path "./vendor/*" ! -path "./server/static/bindata_assetfs.go" ! -path "**/mocks/*" | xargs -I '{}' dirname '{}' | sort -u)
../../../../../usr/local/go/src/mime/multipart/formdata.go:9:2:warning: could not import errors (readdirent: bad address) (maligned)
../../../../../usr/local/go/src/mime/multipart/writer.go:10:2:warning: could not import errors (readdirent: bad address) (maligned)
../../../../../usr/local/go/src/mime/multipart/formdata.go:61:17:warning: undeclared name: errors (maligned)
../../../../../usr/local/go/src/mime/multipart/writer.go:183:13:warning: undeclared name: errors (maligned)
../../../../../usr/local/go/src/mime/multipart/writer.go:47:10:warning: undeclared name: errors (maligned)
../../../../../usr/local/go/src/mime/multipart/writer.go:51:10:warning: undeclared name: errors (maligned)
../../../../../usr/local/go/src/mime/multipart/writer.go:61:10:warning: undeclared name: errors (maligned)

Are you seeing this with v1 or master ?

I am seeing it with a build that was made from master. If I remember correctly, I had some performance problems with v1 that caused me to switch to master.

I'm on master too

Reproduced with go 1.9.2 and gometalinter 2.0.2, Used workaround of --exclude=/go/src/ which resolved it.

FWIW, I can reproduce this consistently on my Mac by setting PATH to not include Go itself. This spews lots of errors for $GOROOT/src/... in addition to the current dir's package:
$ PATH=/usr/bin:/bin:/usr/sbin:/sbin /Users/alex/.go/bin/gometalinter

But this works:
$ PATH=/usr/bin:/bin:/usr/sbin:/sbin CGO_ENABLED=0 /Users/alex/.go/bin/gometalinter

In my case, I install Go via Homebrew, and I have only one Go version installed, which lives in /usr/local/local/Cellar/go/1.9.2.

I started getting these errors yesterday as well (latest master). But they are not reproducible and only appear sometimes.
The CGO_ENABLED=0 workaround seems to work.

I came across these errors today.
In my case it was caused by custom installation by brew install go
according to Installing to a custom location go expects default to be at /usr/local/go but brew install at /usr/local/Cellar/go/1.10.1/libexec
It only works with  `export GOROOT=/path/to/custom/go

I've faced same error on go 1.11 and gometelinter 0.2.1
I think the root cause of this problem is gometelinter set the $GOROOT environment variable when it is not set.
(It was introduced at 0725fc6d)
For example, give $GOROOT to gotype, it reports same errors.
when  no $GOROOT given,  the gotype report nothing.
run gotype via gometelinter:
$ gometalinter --disable-all -d --enable=gotype

DEBUG: [Sep 25 08:52:43.534] GOPATH="/home/ozaki/dev/go"
DEBUG: [Sep 25 08:52:43.534] GOBIN=""
DEBUG: [Sep 25 08:52:43.534] GOROOT="/usr/lib/go-1.11"
DEBUG: [Sep 25 08:52:43.539] [gotype.1]: executing /home/ozaki/dev/go/bin/gotype -e .
DEBUG: [Sep 25 08:52:43.969] [gotype.1]: warning: /home/ozaki/dev/go/bin/gotype returned exit status 2: main.go:4:2: could not import encoding/csv (type-checking package "encoding/csv" failed (/usr/lib/go-1.11/src/encoding/csv/reader.go:55:2: could not import bufio (type-checking package "bufio" failed (/usr/lib/go-1.11/src/bufio/bufio.go:11:2: could not import bytes (type-checking package "bytes" failed (/usr/lib/go-1.11/src/bytes/buffer.go:11:2: could not import io (type-checking package "io" failed (/usr/lib/go-1.11/src/io/pipe.go:12:2: could not import sync (type-checking package "sync" failed (/usr/lib/go-1.11/src/sync/pool.go:9:2: could not import runtime (type-checking package "runtime" failed (/usr/lib/go-1.11/src/runtime/alg.go:8:2: could not import internal/cpu (type-checking package "internal/cpu" failed (/usr/lib/go-1.11/src/internal/cpu/cpu_x86.go:9:7: CacheLinePadSize redeclared in this block))))))))))))))

run gotype directly without GOROOT,  it's no errors reported.
...
$ /home/ozaki/dev/go/bin/gotype -e -v .
main.go
207.729659ms (1 files, 50 lines, 240 lines/s)

After Go 1.10, the `$GOROOT` should not be set.
[You don’t need to set GOROOT, really \| Dave Cheney](https://dave.cheney.net/2013/06/14/you-dont-need-to-set-goroot-really)

Seeing this after upgrading to Go 1.12, not sure why. Disabling CGO did not seem to help. Still investigating what caused it.

Try switching to golangci-lint instead. The Gometalinter project is (nearing) EOL.


Turn off update node labels

We no longer need this as it will be supported within aks instead. Dropping this to remove the kubectl calls on startup.

are we doing the labelling explicitly on RP side? How do we ensure the node-image-version label version is updated in a node image upgrade event?

Let's chat before merging this. I'm curious about the design change

@xuto2 I'd be happy to discuss the change in design. This change is partially a result of an ICM. We are planning to merge this in before the cutoff this Wednesday, so we can roll this out as soon as possible.


Support scaffolding Grafana packages

CLI should be able to pack Grafana packages. Contents include

dashboards
data sources
services (TBD)

Implemented in #392


.pem file is not accepted in ssl.config.options for ca

**Node version12.11.1:
Sails version (0.12.14):

I have configured SSL like this in config/env/production.js
 ssl: {
    ca: require('fs').readFileSync(require('path').resolve(__dirname,'/ssl-keys-dir/chain.pem')),
    key: require('fs').readFileSync(require('path').resolve(__dirname,'/ssl-keys-dir/chain.pem/privkey.pem')),
    cert: require('fs').readFileSync(require('path').resolve(__dirname,'/ssl-keys-dir/chain.pem/cert.pem'))
  }

This does not work, and the application throws following error
TypeError [ERR_INVALID_ARG_TYPE]: The "options.ca" property must be one of type string, Buffer, TypedArray, or DataView. Received type number
    at validateKeyOrCertOption (_tls_common.js:80:11)
    at Object.createSecureContext (_tls_common.js:110:9)
    at Server.setSecureContext (_tls_wrap.js:1152:27)
    at Server (_tls_wrap.js:1030:8)
    at new Server (https.js:65:14)
    at createServer (https.js:89:10)
    at _afterLoadingSessionHookIfApplicable (/root/project_root/node_modules/sails/lib/hooks/http/initialize.js:87:35)
    at /root/project_root/node_modules/sails/lib/hooks/http/initialize.js:31:18
    at /root/project_root/node_modules/sails/lib/app/private/after.js:91:14
    at /root/project_root/node_modules/sails/node_modules/async/lib/async.js:721:13
    at /root/project_root/node_modules/sails/node_modules/async/lib/async.js:52:16
    at async.forEachOf.async.eachOf (/root/project_root/node_modules/sails/node_modules/async/lib/async.js:236:30)
    at _parallel (/root/project_root/node_modules/sails/node_modules/async/lib/async.js:712:9)
    at Object.async.parallel (/root/project_root/node_modules/sails/node_modules/async/lib/async.js:726:9)
    at Sails.emitter.after (/root/project_root/node_modules/sails/lib/app/private/after.js:89:11)
    at _waitForSessionHookIfApplicable (/root/project_root/node_modules/sails/lib/hooks/http/initialize.js:30:15)
    at Hook.initialize (/root/project_root/node_modules/sails/lib/hooks/http/initialize.js:42:7)
    at Hook.wrapper [as initialize] (/root/project_root/node_modules/@sailshq/lodash/lib/index.js:3282:19)
    at /root/project_root/node_modules/sails/lib/hooks/index.js:88:16
    at /root/project_root/node_modules/sails/node_modules/async/lib/async.js:52:16
    at /root/project_root/node_modules/sails/node_modules/async/lib/async.js:548:17
    at /root/project_root/node_modules/sails/node_modules/async/lib/async.js:542:17

The valid .pem file is present at the provided directory. (It does not throw error for the key and cert)
(it works without putting any CA value, but in that case the API does not provide valid https response)
I have generated these certificates using let'sencrypt's certbot

As I read from the nodejs documentation, the ca value is optional.
https://nodejs.org/api/tls.html#tls_tls_createsecurecontext_options
In my case, I have removed that value, and it is working fine.

@vishwajeetv Yes ca is an optional override, glad you got it working!


Segment display

Fixes #13

Pull Request Test Coverage Report for Build 687

828 of 872 (94.95%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 90.008%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

draw/segdisp/segment/segment.go
216
218
99.08%

widgets/segmentdisplay/segment_area.go
57
59
96.61%

draw/segdisp/sixteen/attributes.go
157
163
96.32%

widgets/text/text.go
16
22
72.73%

draw/segdisp/sixteen/sixteen.go
148
158
93.67%

widgets/segmentdisplay/segmentdisplay.go
126
144
87.5%

Totals

Change from base Build 676:
0.9%

Covered Lines:
4774

Relevant Lines:
5304

💛  - Coveralls


Fix compatibility with latest Puppeteer version

Summary

Puppeteer recently changed the naming of their classes in https://github.com/puppeteer/puppeteer/pull/10903, which caused the case-sensitive class name checks in expect-puppeteer to fail.
Fixes #565
Test plan

@gregberge Prettier issues are now addressed

Will take care of it soon.

@swissspidy tests are all broken

I can confirm this fixed my issue. Thank you!


During code review of pull request some lines of code were not visible.

Command attempted:
git push --force was the last command executed.
What happened:
When I am reviewing the code on github for a pull request i was not able to see complete changes done in commit for which pull request is generated . But i can see the changes if i checkout the branch of the pull request freshly from remote.
This is some serious issue as i could have missed the changes which were required to get reviewed. It can be seen that git is not showing the code between line number 33231 to 33282 as attached in the screenshot.
More info:
Ubuntu 16.0.4 LTS.

Hi, I believe this is a question about GitHub.com, the website. This issue tracker is for a command-line utility called hub, not the website itself. For reporting bugs and requesting features for GitHub the website, please go to https://github.com/contact or visit https://github.community. Thank you!

ok thank you for your answer.


Type conficts between $t and useSeoMeta()

Is your feature request related to a problem? Please describe it.
In nuxt
useSeoMeta({
    // error: Type 'unknown' is not assignable to type 'Title | undefined'
    title: t('title')
})

I am ok with type cast, but this is kind of unacceptable
Am I missing something from the documentation?
useSeoMeta({
    title: t('title', { name: t('name') as string }) as string,
    description: t('description') as string,
    ogTitle: t('ogTitle') as string,
    ogDescription: t('ogDescription') as string,
    ogImage: 'http://example.com/example.png',
    ogUrl: 'http://example.com/',
    twitterTitle: t('twitterTitle') as string,
    twitterDescription: t('twitterDescription') as string,
    twitterImage: 'http://example.com/example.png',
    twitterCard: 'app'
})

Describe the solution you'd like
[suggested] add a new function that wraps useSeoMeta with intl abilities
Describe alternatives you've considered
[breaking change] rewrite and then mark the return type of t() or $t() as string | undefined, or something like that.
(I know this is terrible)
Additional context
None

I can simply add a TypeScript function (ts) that returns a string.

Added $ts


Support stackexchange sites other than stackoverflow.

Support stackexchange sites
Fixes #90

I think all the major sites are included 🤔 .


Add case wasi and case win32 to the Triple.OS enum

This brings Triple.OS closer to what's available in Swift Driver and SwiftPM.

@swift-ci test

@swift-ci test


feat: add modal to show descriptions of subcategories

Fixes Issue
Resolves #972
Changes proposed

Instead of making the field optional in IData, I have created a new interface.
I have thoroughly checked and organized everything in a clean structure.
I have placed CategoryDescriptions.ts in the TopBar components.

I just realized that this work is worth two Level 3 PRs, LOL.

@rupali-codes
Could you please review the code and merge the PRs? It becomes challenging when there are multiple PRs, so merging them after reviewing would be greatly appreciated.
Screenshots

Large Screen

Small Screen

Note to reviewers
If you would like to know something, please feel free to ask.
@CBID2
Do you happen to know who the mentor of LinksHub is, and if they are currently active?

@CBID2
Please let @rupali-codes review these types of PRs too before merging the PR because she can mention or improve the approach of these specific technical codes. I am just suggesting it for code improvement. I hope you understand.

@CBID2
Please let @rupali-codes review these types of PRs too before merging the PR because she can mention or improve the approach of these specific technical codes. I am just suggesting it for code improvement. I hope you understand.
Hi @Anmol-Baranwal. Sure will, I guess using the General feature would be best.

@CBID2 @rupali-codes
Please add the level3 label to the issue. The label is necessary for the accurate final leaderboard.

@CBID2 @rupali-codes
Please add the level3, gssoc23 label to the issue. The label is necessary for the accurate final leaderboard.

Done


[FEAT] Add /forget, /update commands

🚀 Feature Request
The /remember command was recently added to the iPhone app and I’m not sure which others. I would like each use of /remember to generate a new sequential integer in its output, e.g.

> turn the sky blue
The clouds part and the sky is now a beautiful blue color.
>/remember The Sky Is Blue.
... Added new memory # 42: ”The Sky Is Blue.”

so that that integer could later be used to remove the added item from the story context.

> turn the sky red
The sky just turned an angry shade of red.
>  /forget 42
... forgot “The Sky Is Blue”
> /remember The Sky Is Red.
> ...

It would also be useful to be able to replace (forget old value, remember new value) a context item by specifying its number:

> /update 42 The Sky Is Plaid.

Even better would be a sidebar with all the remembered items and an X button to remove them at any point.

context control center! :+1:

I just saw the browser version does have this. You can just edit the context. So I guess this just needs to be applied to Android / iPhone in some way.

It looks as though it's possible to edit the context on iPhone as well now, and I assume that it will be possible on Android as well, so I'm closing this bug.


Add type_name to queries where known

Currently using the same collection for everything to bypass mongo only enforcing uniqueness at the collection level. This means most object-specific indexes are partial with at least model.type_name as a filter, but this means imprecise queries don't hit the index.
Add type_name to queries wherever possible and consider this in load tests (issue only becomes visible with a large database)

Simpler solution: Filtered the indexes by the indexed values existing


startScan returns the same device over and over

Is this the way it works? In the comments it says that it calls the callback when a new device is detected. When I run startScan, it keeps returning the same device until I call stopScan.

You are correct; the comment is misleading.
The scanCallback is called each time an advertisement is recieved. Most BLE devices send advertisements roughly once per second.

Thanks for the response!


Pull Request for Issue #13

These are some good resources for biology icons,
https://www.flaticon.com/free-icons/biology
https://www.biorender.com/library
Also some good general Bio-Informatics resources,
https://bioinformatics.sph.harvard.edu/
https://guides.lib.berkeley.edu/
for more resources you can follow this article:-
https://medium.com/@hamza_33678/the-top-10-resources-to-learn-bioinformatics-ccd030a3908

Issue 13 of newspaper. #37

Thank you for the suggestions, @Oswatik.

I don't think we need the extra exclamation mark, closing pull request.
Also BioRender is not free in the sense used for open source software, and while they have some excellent imagery I don't think the OBF should be promoting them over something with a license allowing reuse (e.g. CC0).