._transform is not a function and Error: Bower components directory does not exist at C:\marklogic-samplestack\browser\bower_components

this is what I run.
abcd@INNASPC6786 MINGW64  /c/marklogic-samplestack
$ gulp run
C:\marklogic-samplestack\shared\js\options.js:238
module.exports = _.transform(
^
TypeError: _.transform is not a function
at Object. (C:\marklogic-samplestack\shared\js\options.js:238:20)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (C:\marklogic-samplestack\shared\js\dev-tasks\context.js:35:15)
at Module._compile (module.js:570:32)
abcd@INNASPC6786 MINGW64 /c/marklogic-samplestack
$ gulp run
[09:19:58] Using gulpfile C:\marklogic-samplestack\gulpfile.js
[09:19:58] Starting 'clean'...
[09:19:58] Finished 'clean' after 2.05 ms
[09:19:58] Starting 'bower-files'...
[09:19:58] 'bower-files' errored after 493 μs
[09:19:58] Error: Bower components directory does not exist at C:\marklogic-samplestack\browser\bower_components
at module.exports (C:\marklogic-samplestack\node_modules\main-bower-files\lib\index.js:54:15)
at bowerBuildStream (C:\marklogic-samplestack\shared\js\dev-tasks\tasks\bower-files.js:32:5)
at Gulp.func (C:\marklogic-samplestack\shared\js\dev-tasks\tasks\bower-files.js:64:8)
at module.exports (C:\marklogic-samplestack\node_modules\orchestrator\lib\runTask.js:34:7)
at Gulp.Orchestrator._runTask (C:\marklogic-samplestack\node_modules\orchestrator\index.js:273:3)
at Gulp.Orchestrator._runStep (C:\marklogic-samplestack\node_modules\orchestrator\index.js:214:10)
at C:\marklogic-samplestack\node_modules\orchestrator\index.js:279:18
at finish (C:\marklogic-samplestack\node_modules\orchestrator\lib\runTask.js:21:8)
at cb (C:\marklogic-samplestack\node_modules\orchestrator\lib\runTask.js:29:3)
at next (C:\marklogic-samplestack\node_modules\rimraf\rimraf.js:70:7)

Thanks for logging. If you're a registered customer you can also log in through the support portal so we can assign a support engineer. Otherwise can you tell me more about your environment? What version of MarkLogic are you using? In the meantime it would also help to know if you are blocked on figuring out how something specific works since it appears you are working on a POC.

I am using marklogic 9 version
and Node v6.11.0 for deploying this application

Samplestack was released a couple of years ago and has only been tested to work with MarkLogic version 8, available here, and Node v0.10. For now I'd recommend exploring the code in the repository as a sample and not trying to run it on your system. If you have specific questions on why a particular design choice was made or how an API works feel free to post it in here.

as per your recommendation now I am using node v0.10 and marklogic 8 version but it showing following  error
Code-Machine MINGW64 /c/marklogic-samplestack/browser
$ gulp run
[21:16:44] Working directory changed to C:\marklogic-samplestack
[21:16:46] Using gulpfile C:\marklogic-samplestack\gulpfile.js
[21:16:46] Starting 'clean'...
[21:16:46] Finished 'clean' after 14 ms
[21:16:46] Starting 'bower-files'...
[21:16:46] Finished 'bower-files' after 81 ms
[21:16:46] Starting 'build'...
[21:16:47] 'build' errored after 623 ms
[21:16:47] Error in plugin 'gulp-jshint'
Message:
Invalid reporter
[21:16:47] processing files
[21:16:47] saw 221 files

can you try this
sudo chown -R $(whoami) ~/.npm npm cache clean

I just tried with master branch with node v0.10.33 and worked fine for me.
Based on the initial error message, it appears that you may not have installed bower packages. Please make sure to install under marklogic-samplestack/browser and not in app root.
From the second error, I'm suspecting it may have to do with gulp version installed globally which may not be compatible with build code (I could be completely wrong).  Try using local gulp instead of globally install version
From app root, you can reference local gulp like so, ./node_modules/gulp/bin/gulp.js run.
Let me know how it goes.

I have done all the steps you guys(popzip   ,  csreddy ) suggested but still facing the same issue.

can you try the suggestion made on this issue https://github.com/codepunkt/gulp-jscs-stylish/issues/7#issuecomment-104151410 ?


Passthrough API is just black

I tried recompiling the latest version with Passthrough permission enabled, but the viewport background is still black. I tried every method of troubleshooting available, but nothing seems to suggest anything's wrong. I hope someone here can help.
So far the main issues we're getting as feedback:

You need to use the latest 3.x release, there are new export options that enable pass through, I think 3.4.1 RC includes it but not 100% sure
You must enable pass through from the start, it is not a feature that can be toggled on and off (yet)
You must use the main viewport for rendering XR content

Also if the whole screen stays black, that usually suggest the initialisation on the Godot side isn't being run.
I've also heard some people having issues with a Quest 2 but since I only have a Quest 1 to test, I don't know if there is a real issue here or if they are missing a step. @m4gr3d you have a Quest 2 on which you test right?
For me the demo project in the repository works right off the bat when pass through is enabled on the first person controller.

I was also using the demo first-person controller, but the viewport background stayed black. Can you elaborate on export options? I'm using v3.4.stable.official [206ba70f4] and didn't see any options related to Passthrough API in the export dialog.

@BastiaanOlij I've tried your steps on my Quest2 in 3.4.1 RC2, both in my own project and demo. When turning on passthrough, the background remains black. But I found that I got an error : "Invalid call. Nonexistent function 'start_passthrough' in base 'Node (OpenXRConfig.gdns)'." Does that means I got a bad version of the addon? I didn't build this module by myself, but downloaded it from the release page.
So I don't know whether it's my own problem or the addon's, hope that would help you.

Very strange, I need to find some time to test it properly, maybe something to mangled when merging stuff though at face value it seems to all be in place: https://github.com/GodotVR/godot_openxr/blob/master/src/gdclasses/OpenXRConfig.cpp#L61

Switching to 1.1.1 pre-release version fixes everything, now it works totally fine, thank you for your work here.

3.4.1 RC2 added the Passthrough API export option and it worked! Thanks for your help!


Update distribution to work with harbor v2.5.1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I thought the 2.5.1 change already merged, but it has a broken presubmit. I guess not a big deal since old Harbor won't use this anyway


Added support for loading keypair as file used in authentication in direct mode

There is a need to have ability to load existing keypair file used for authentication with P2P nodes which only allow known PeerIds to connect (https://docs.rs/libp2p/latest/libp2p/allow_block_list/index.html#structs).
Proposed change adds additional parameter in "direct" mode to load keypair from given file path.
This only applies to direct mode connecting to a given node which requires authentication with "whitelisted" PeerId.
Currently it only supports base58 encoded files.
Example:
libp2p-lookup direct --address /dns/node-1/tcp/55123 --keypair-path ~/path/to/key.base58

There is a need to have ability to load existing keypair file used for authentication with P2P nodes which only allow known PeerIds to connect (https://docs.rs/libp2p/latest/libp2p/allow_block_list/index.html#structs).

//CC @thomaseizinger since you might be excited to see your work being used here.

Great to see libp2p-lookup used more widely and contributions flowing back. Thank you!
Overall I am in favor of this patch. I just have a couple of suggestions.

Thanks @mxinden your suggestions make sense, will get them ready.


Implement/Fix editing a state or option that comes from a file/code

Need to discuss how to present it to user

fixed


#1845 [YSQL] Propagate cert_dir_name master flag to yb-admin in yb-ctl script

In case of starting new cluster with TLS by using command like:
./bin/yb-ctl start --master_flags "use_node_to_node_encryption=true,allow_insecure_connections=false,certs_dir=<cert_dir>" --tserver_flags "use_client_to_server_encryption=true,use_node_to_node_encryption=true,allow_insecure_connections=false,certs_dir=<cert_dir>"

yb-admin will try to access master and it should use encrypted connection if insecure connections are disallowed. For this purpose certs_dir argument should be forwarded to yb-admin

It's failing some tests @d-uspenskiy : https://travis-ci.org/yugabyte/yugabyte-installation/builds/594801164?utm_source=github_status&utm_medium=notification


Add TURBINE/REPI with EPI-based tools

This PR adds the following features:

initialize_3D_TURBINE function to create a TURBINE trajectory requested in issues #50, that consists in EPI shots rotated into a cylinder,
initialize_3D_REPI function to create a REPI trajectory requested in issues #49, that can be either radial or spiral EPI-like shots interlaced between blades rather than stacked independently
epify function used to combine shots into a single multi-echo readout train, similar to EPI shots
prewind and rewind to create the positioning & spoiling gradients before and after the readouts, and therefore obtain the full gradient sequence rather than just the one played during the readouts.

The different functions & features are illustrated below, with the TURBINE & REPI trajectories (up) and the epify/prewind/rewind tools applied to different trajectories (down)

This looks very promising ! I will let you add documentation before reviewing.
Some thoughts/Questions:

Maybe a un-epify method could be added as well if it make sense ? (you have an EPI trajectory with the gradients turns, and you want to only preserve the straight lines for the reconstruction )
Does the original REPI / TURBINE support GRAPPA acceleration ? do we want to add this to MRI-NUFFT ?

This looks very promising ! I will let you add documentation before reviewing.
Some thoughts/Questions:

Maybe a un-epify method could be added as well if it make sense ? (you have an EPI trajectory with the gradients turns, and you want to only preserve the straight lines for the reconstruction )

Yes that make sense, I will add that too

Does the original REPI / TURBINE support GRAPPA acceleration ? do we want to add this to MRI-NUFFT ?

Didn't read about it, but it is quite certain they can. I would suggest to have it made through another function/tool rather than keep stacking arguments on REPI/TURBINE functions, and add an example where we make them GRAPPA-compatible. It requires to add an option to not epify automatically the REPI & TURBINE functions, but I was planning to propose that anyway.

@Daval-G thank you for this work. I was curious if you had something more to be done here? If not, I can handle the linting issue.

@Daval-G thank you for this work. I was curious if you had something more to be done here? If not, I can handle the linting issue.

The examples are still missing, that's what I am currently working on

@paquiteau good to go ?

There is still the question of the in-plane acceleration, but I plan to do that in another PR


[MXNET-368] Fix mxnet::Context hash for 32 bit architectures, where size_t is 32 …

…bit.
Description
Fix mxnet::Context hash for 32 bit architectures, where size_t is 32 bit.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@piiswrong can we merge this for the moment being?


DHCD addresses not found in MAR

Some of the addresses in the DHCD quickbase database that are being ingested into Housing Insights are not found in the Master Address Repository; typically this is because of an invalid address.
Solution steps:

Ask DHCD to update the data in their database with the correct address
If this can't happen, or if it doesn't resolve the problem, identify a mapping to a correct address string and put this in an 'exceptions' handler part of the code during the quick address cleanup.

Addresses:
(Note - these have been pre-precessed by our code to split up different addresses so will be slightly different in the DHCD database)

Addresses
Mar_ids
Notes

'1649 WEST STREET SE', '1641 WEST STREET   SE', '1643 WEST STREET SE', '1645 WEST STREET SE', '1647 WEST STREET SE',   '2312 GREEN STREET SE', '2304 GREEN STREET SE', '2306 GREEN STREET SE', '2308   GREEN STREET SE', '2310 GREEN STREET SE'
None, None, None, None, None, '148158', '150350', '48988', '148157',   '48744'
Is this supposed to be W St SE?

'7th R', 'Rhode Island NW'
None, None
This was written as an intersection

'28th Place SE'
None
No street number

'2300 30th Place NE'
None

'HAYES STREET & ANACOSTIA AVENUE   NORTH EAST'
None
Intersection - need street address

'8TH & "H" STREET NE'
None
Intersection - need street address

'10th Street & Rhode Island Avenue   NE'
None
Intersection - need street address

'Central Place NE'
None
No street number

'2519, 2521, 2552, 2554, AND 2548   UNIVERSITY PLACE2639 CONNECTICUT AVE NW #113'
None
mashed up addresses

'Robinson Place SE'
None
No street number

'1715 1/2 7TH ST NW'
None

'1715 1/2 7TH ST NW'
None

@ChrisDickersinProkopp Thanks for the info - sounds like these are more complicated than I thought it would be for these cases.
The biggest way this is used currently is de-duplication of projects that are already in the PresCat for whatever reason. If we can use the table of every address/SSL that would definitely be an improvement. It would be good to get more info on where to access that data table.
For now let's mostly save this response for a more comprehensive review of the matching. A few quick notes though:

If it's a new development and doesn't have an address, we can use the intersection address as is. Would be great to get it updated when it does come through, though, so we can take advantage of the extra data that comes with matching w/ the mar id

It probably makes sense to add a 'won't fix' flag to anything that we think is too much effort to fix. Will think about where best to put this.

We also have a one-to-many project to address table, so the cleanest way is to get the list of all the addresses that ended up being created. But might be worth discussing if this is feasible.

We opted not to use the intersection-based MAR address lookup because it returned too many false positives. If there was a mistyped address or other error, it would say it was close enough and return a (wrong) MAR ID anyways. Using just the street address version was safer. If there are many cases that need intersections, we would need to add code in our side that could correctly identify an intersection-style address and only send those ones to the intersection-based MAR lookup.


Fixup hack to get glib-networking-native to build

I think this already got merged in as part of Anton's PR #136. It's identical as far as I can tell.

Good spot


handle sass import in webpack loader

Feature request

What is the expected behavior?
I want to handle sass import file in the webpack loader.
Just like this:
// style.scss
@import './theme.scss';
p {
   color: white;
}

I want webpack loader can handle 'theme.scss'
What is motivation or use case for adding/changing the behavior?
I want to handle sass file before sass-loader compiled.

Just write loader and put it after sass-loader:
{
  loader: 'sass-loader'
},
{
  loader: 'my-loader'
}

Please read https://webpack.js.org/concepts/loaders/

Just write loader and put it after sass-loader:
{
  loader: 'sass-loader'
},
{
  loader: 'my-loader'
}

Please read https://webpack.js.org/concepts/loaders/

I have try in this way. But loader can only handle "style.scss", can't get "./theme.scss".


transfers addition issue

I am able to submit a transfer without the second account selected, when I comeback to the home then I see an error in the last transactions section.
https://user-images.githubusercontent.com/24766687/235300185-12ce5734-b874-4760-983d-081e6256ff2f.mov
(From a comment of @theperu on #85)

@lucaantonelli seems that a fix for this has been recently merged on #101.
I just wanted to let you know. You decide whether to continue working on it, or go further.


tekton-ci: re-link quay-push-konflux-ci secret

This reverts commit 668f83cf37a1981abd302d00d21fb021d48c2122.
Adam made manual changes to the secret values to namespace them for the two quay.io orgs. We think it is safe to reintroduce this change now.

/lgtm

/approve

@gbenhaim can you approve this please ?

@ralphbean can we get this merged please ?

Looks like you already got this in in aeabac350. Dropping this one.


Add a Trascript download option

Is your feature request related to a problem? Please describe.
In the MVA Dashboad the "User" can download a "Transcript" for the "Accomplishments" done in the training
Describe the solution you'd like
Add a "Download Transcript" function to Download a PDF file with the list of all the couses completed.
Additional context

@shamnadhoh is this related to any functionality on docs.microsoft.com?


magnum-cluster-api-image-builder creates ubuntu 2204 images with broken networking

magnum-cluster-api-image-builder pulls the latest daily build of the ubuntu service live-cd installer iso, and passes this to image-builder as "iso_url".
The daily build ubuntu ISO has the subiquity installer run from a snap, revision 5741 corresponding to subiquity 24.04.1.
curl -H 'Snap-Device-Series: 16' http://api.snapcraft.io/v2/snaps/info/subiquity | jq .
{
  "channel-map": [
    {
      "channel": {
        "architecture": "amd64",
        "name": "stable",
        "released-at": "2024-04-25T14:19:35.106214+00:00",
        "risk": "stable",
        "track": "latest"
      },
      "created-at": "2024-04-17T14:39:49.085646+00:00",
      "download": {
        "deltas": [],
        "sha3-384": "859092c0d2e92279e23827f920421fa730a2ab4dd4435e26710a27612032d41be01d7f1729222df94e7532d9d43836da",
        "size": 21020672,
        "url": "https://api.snapcraft.io/api/v1/snaps/download/ba2aj8guta0zSRlT3QM5aJNAUXPlBtf9_5741.snap"
      },
      "revision": 5741,
      "type": "app",
      "version": "24.04.1"
    },

The release-day ISO for ubuntu 22.04.4 contains revision 5495 of the subiquity snap.
Subiquity has changed the name of the files it drops during installation for network configuration https://github.com/canonical/subiquity/commit/2af582984c47ebe0a8d3bbc2733e0767d04cda0f
image-builder only accounts for the previous behaviour of subiquity https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/ansible/roles/sysprep/tasks/debian.yml
The result is a file is left in /etc/cloud/cloud.cfg.d/90-installer-network.cfg
ubuntu@capi-image-build:~$ sudo cat /mnt/etc/cloud/cloud.cfg.d/90-installer-network.cfg
# This is the network config written by 'subiquity'
network:
  ethernets:
    ens4:
      dhcp4: true
  version: 2

End result is the configuration for (the non-existent) ens4 interface is read by cloud-init when the magnum instance boots, and the IP previously acquired by DHCP from neutron is removed from the interface by cloud-init
May 28 09:03:53 localhost.local cloud-init[524]: [CLOUDINIT]2024-05-28 09:03:53,168 - subp.py[DEBUG]: Running command ['ip', '-4', 'route', 'del', '<IP_ADDRESS>/0', 'via', '<IP_ADDRESS>', 'dev', 'enp3s0'] with allowed return codes [0] (shell=False, capture=True)
May 28 09:03:53 localhost.local cloud-init[524]: [CLOUDINIT]2024-05-28 09:03:53,170 - subp.py[DEBUG]: Running command ['ip', '-4', 'route', 'del', '<IP_ADDRESS>/32', 'via', '<IP_ADDRESS>', 'dev', 'enp3s0'] with allowed return codes [0] (shell=False, capture=True)
May 28 09:03:53 localhost.local cloud-init[524]: [CLOUDINIT]2024-05-28 09:03:53,171 - subp.py[DEBUG]: Running command ['ip', '-family', 'inet', 'link', 'set', 'dev', 'enp3s0', 'down'] with allowed return codes [0] (shell=False, capture=True)
May 28 09:03:53 localhost.local cloud-init[524]: [CLOUDINIT]2024-05-28 09:03:53,173 - subp.py[DEBUG]: Running command ['ip', '-family', 'inet', 'addr', 'del', '<IP_ADDRESS>/24', 'dev', 'enp3s0'] with allowed return codes [0] (shell=False, capture=True)

The magnum instance networking is now broken.

dang, I was bit by this for a while, I was hoping that we can speed up the deploy by reducing the apt upgrade time... but it seems that this has somehow rolled out another issue.

Fixed by https://github.com/kubernetes-sigs/image-builder/pull/1480


change!(updater): disable zip feature by default

As we made a new option in tauri CLI in https://github.com/tauri-apps/tauri/pull/9883, I think we should remove zip from updater plugin's default features, and make people opt-in instead of opt-out

should probably be part of tauri migrate now that you mention it.

Made a PR

This should wait until v3, just to give users (who wouldn't necessarily use tauri migrate) an easier upgrade.

I don't think this makes a huge difference as we have made this into a plugin, the user either has to use our cli's migrate or go and look up the updater plugin's docs/readme, and this is just an extra line (the user needs to learn what v1 compatible updater is anyway)

In the other hand, for people coming from v2 or started using v2 updaters, they'll need to do no default features which really isn't that great

That could be argued both ways.
In fact, I think it is better to opt-out of zip instead of opt-in as it allows more flexibility in terms of supporting more features and easier upgrade for current users. I am fine with making this opt-in in v3, because by then "easier upgrade for current users" won't factor in as much.

Alright, the zip crate without any compression enabled shouldn't be too big, I don't quite like it but I don't think I want to fight for it either, closing it for now and we can reopen it on v3


fix(core): set empty array as defaultValue when fieldArray is set.

fix #761
What kind of change does this PR introduce? Bug fix

This change is

Codecov Report

Merging #762 into master will increase coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
+ Coverage   94.07%   94.45%   +0.37%
==========================================
  Files          18       18
  Lines         793      793
  Branches      227      227
==========================================
+ Hits          746      749       +3
+ Misses         47       44       -3

Impacted Files
Coverage Δ

src/core/src/services/formly.form.builder.ts
96.19% <100%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29fd3f...8945c21. Read the comment docs.


Failed to load monster outside an encounter

Tried to load violet fungus for a random encounter and it didn't work, with no output. Soooooo yeah, let's figure out WTF happened and fix it so that it doesn't happen again.

There were two problems, both data-driven:

Filename was violet_fungi.toml, monster name was violet_fungus -- so couldn't look up the thing correctly.

The violet fungus had "challenge" instead of "cr" so that blew up once I fixed the first issue.


Fix Server logo avatar

https://github.com/LTSENG01/Discord-RoleBot/blob/774a53f24f416ae0a2f71c3473fbda11c60ea0a4/static/main.js#L16

New image: a_6d9390fadb6bc1fa5a59ede9cdfe26b6

Maybe also have the placeholder show up if it can't load the server image from Discord

Your suggested comment worked.
So it's displaying the image now but could you clarify what's the placeholder you're referring to ?


Possible to restart failed builds?

Something like one in three builds fail for me, with no apparent connection to the changes in my pull requests. I typically amend and force-push to restart the build and then it usually passes. This of course works, but is a bit annoying. Is it possible to restart a build without having to push changes?

It's not possible to automatically restart, but I restart them when I see a random failure. One of our test Roslyn versions can throw exceptions unexpectedly and cause random failures, and it wasn't fixed until much later so we can't update without hurting our test coverage. I do have a sneaky way to fix it though that I found fairly recently...
https://github.com/dotnet/winforms/pull/8981

My idea was to allow contributors to manually trigger a restart somehow. I think I have seen projects where it was possible to just write something "magic" as a comment which then triggered a new build?
But if your yml fix helps then that would be welcome also.


OCPVE-610: Basic driver implementation with identity and node services

The goal of this is to get the bare minimum for a running csi driver. We are doing so by starting up a grpc server and running the identity and node services to handle the grpc requests for identification and registration

/assign @jakobmoellerdev @qJkee

/cc @suleymanakbas91


Fix estimates overwrites bug

Fixes a bug in the estimates loader that causes overwrites for a quarter to overwrite any other overwrites for a quarter that started on the same day. I.e., if 2 sids have quarters that start on the same day, the second sid's quarter overwrite will replace the first sid's quarter overwrite rather than appending the second overwrite to a list.

Coverage decreased (-0.04%) to 86.765% when pulling e4d1647c384df4b415c89afade3ed7b3773cc735 on fix_estimates_overwrites_bug into 78de3187531c52685ef100229f3e6e01a5cf133f on master.

Coverage increased (+0.003%) to 86.809% when pulling e4d1647c384df4b415c89afade3ed7b3773cc735 on fix_estimates_overwrites_bug into 78de3187531c52685ef100229f3e6e01a5cf133f on master.

Coverage increased (+0.003%) to 86.875% when pulling 4efe99017a37ea072cd22fa50ec03029842cb430 on fix_estimates_overwrites_bug into 00a053cc38a0e88e18c85bdefe648960f748092f on master.

Coverage increased (+0.003%) to 86.875% when pulling 4efe99017a37ea072cd22fa50ec03029842cb430 on fix_estimates_overwrites_bug into 00a053cc38a0e88e18c85bdefe648960f748092f on master.


Usage of Scaffold-DbContext -Schemas and -Tables parameters could be clearer

I understood from the documentation that -Schemas to be used to indicate which schemas to include and -Tables to be those tables to be scaffolded within those schemas. What I got was scaffolding for ALL tables in the named schemas AND the table(s) named. To get desired result, -Schemas parameter omitted and table names qualified with schema name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22803277-a2a7-0adf-acfc-35ed8e4238c8
Version Independent ID: 19869482-5737-adff-3f7f-60b4217b977d
Content: EF Core tools reference (Package Manager Console) - EF Core
Content Source: entity-framework/core/miscellaneous/cli/powershell.md
Product: entity-framework
GitHub Login: @bricelam
Microsoft Alias: bricelam

That did the trick. Thank you for posting this.


RabbitMQ: Adding lock between declare, qos, and bind commands

Description
RabbitMQ: Adding lock between declare, qos, and bind commands per https://github.com/streadway/amqp/issues/170
Issue reference
Part of #954
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

This is superseded by https://github.com/dapr/components-contrib/pull/1278, right? Can it be closed?


Rework almost all callbacks

Almost all callbacks, whose name matches On*Fn pattern, reworked, except for those that were skipped with a comment why (check commits "Skip <callback_name>").
Callback representation reverted to Box::new(|| async {}) because of webrtc_ice::agent::agent_vnet_test::on_connected() that returns boxed closure (we can't return non boxed closure).

@KillingSpark, @MarinPostma, @pascualex, and @jeremy-prater please also weigh in about this change. Does it help the ergonomics do you think?

Can you talk a bit more about the examples that can't be reworkeed, it would also be good to remove the commented out code.

I will remove unnecessary comments before the merge into the master.

Aight, let's merge to unblock you for now.

This looks promising! what's the rational for dynamic dispatch over static dispatch?

Static dispatch infects everything and makes the code super unergonomic. All of these callbacks are called fairly infrequently so the cost of dynamic dispatch is negligible

Thanks :+1:


Inference on custom dataset does not give proper 3d bboxes

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Precisely speaking, what I want to do is to lift the 2D bounding boxes to 3D bounding boxes without 3D proposals. Is this not possible for EgoNet?

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Precisely speaking, what I want to do is to lift the 2D bounding boxes to 3D bounding boxes without 3D proposals. Is this not possible for EgoNet?

If you are not able to prepare 3D proposals. You can still lift 2D predictions to a 3D bounding box by:

Run EgoNet and get 2D part coordinates and orientation predictions.
Assume a default 3D box dimensions, and solve a PnP problem to estimate translation that minimizes re-projection errors. You can refer to the paper "3d bounding box estimation using deep learning and geometry" for details on how this can be done.
Of course, this would not result in accurate translation estimation compared to an existing 3D proposal.

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Precisely speaking, what I want to do is to lift the 2D bounding boxes to 3D bounding boxes without 3D proposals. Is this not possible for EgoNet?

If you are not able to prepare 3D proposals. You can still lift 2D predictions to a 3D bounding box by:

Run EgoNet and get 2D part coordinates, 3D dimension and orientation predictions.
Solve a PnP problem to estimate translation that minimizes re-projection errors. You can refer to the paper "3d bounding box estimation using deep learning and geometry" for details on how this can be done.
Of course, this would not result in accurate translation estimation compared to an existing 3D proposal.

So, you are suggesting that EgoNet alone cannot estimate 3D bounding boxes from 2D predictions?

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Precisely speaking, what I want to do is to lift the 2D bounding boxes to 3D bounding boxes without 3D proposals. Is this not possible for EgoNet?

If you are not able to prepare 3D proposals. You can still lift 2D predictions to a 3D bounding box by:

Run EgoNet and get 2D part coordinates, 3D dimension and orientation predictions.
Solve a PnP problem to estimate translation that minimizes re-projection errors. You can refer to the paper "3d bounding box estimation using deep learning and geometry" for details on how this can be done.
Of course, this would not result in accurate translation estimation compared to an existing 3D proposal.

So, you are suggesting that EgoNet alone cannot estimate 3D bounding boxes from 2D predictions?

My answer is EgoNet can estimate 3D bounding boxes from 2D predictions. The above two steps already describe what to do in this case. It seems you are not capable of understanding the two steps I mentioned. Step two is contained in some legacy code which you may refer to:
https://github.com/Nicholasli1995/EgoNet/issues/9#issuecomment-947270894
This is not an issue and you can ask further questions in the discussion part of this repo.

Hi! I am trying to use the EgoNet on a custom dataset (such as Waymo Dataset) and generate 3D bboxes from the 2D predictions generated by 2D bbox detectors such as Faster R-CNN.
A sample of KITTI predictions where 2D bboxes are output but 3D bboxes are not yet output are as follows:
Car -1 -1 0.0 158.0 386.0 220.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95
Car -1 -1 0.0 565.0 386.0 720.0 438.0 0.0 0.0 0.0 -1.0 -1.0 -1.0 0.0 0.95

However, when I set these 2D predictions as additional input for predicting bboxes using EgoNet, the 3D bboxes are not properly output at all and are just a bunch of zeros and minus-ones.
What should I do?

Hi, EgoNet only updates orientation and does not modify or add 3D location/dimension information. Using 2D boxes as proposals by default only updates orientations. You can use 3D box proposals as inputs instead.

Then, what should I do if I want to generate 3D bounding boxes from 2D bounding boxes and orientation information? Are any options to config files to do so?

If you mean you want to visualize the 3D boxes in this case, you can draw the 3D boxes with default sizes and the predicted orientation.

Precisely speaking, what I want to do is to lift the 2D bounding boxes to 3D bounding boxes without 3D proposals. Is this not possible for EgoNet?

If you are not able to prepare 3D proposals. You can still lift 2D predictions to a 3D bounding box by:

Run EgoNet and get 2D part coordinates, 3D dimension and orientation predictions.
Solve a PnP problem to estimate translation that minimizes re-projection errors. You can refer to the paper "3d bounding box estimation using deep learning and geometry" for details on how this can be done.
Of course, this would not result in accurate translation estimation compared to an existing 3D proposal.

So, you are suggesting that EgoNet alone cannot estimate 3D bounding boxes from 2D predictions?

My answer is EgoNet can estimate 3D bounding boxes from 2D predictions. The above two steps already describe what to do in this case. It seems you are not capable of understanding the two steps I mentioned. Step two is contained in some legacy code which you may refer to: #9 (comment)
This is not an issue and you can ask further questions in the discussion part of this repo.

Alright. Thanks. Sorry if I dragged this issue too long.

This may be a stupid question, but can we feed in results of the pnp algorithm back into Egonet itself to obtain a refined 3D box prediction?
So if our input is a 2D image and bounding box, Egonet gives us the orientation and dimensions only as it is 2D. We then solve the PnP algorithm to get a 3D bounding box estimate, and then feed that back into Egonet to refine this prediction.

This may be a stupid question, but can we feed in results of the pnp algorithm back into Egonet itself to obtain a refined 3D box prediction? So if our input is a 2D image and bounding box, Egonet gives us the orientation and dimensions only as it is 2D. We then solve the PnP algorithm to get a 3D bounding box estimate, and then feed that back into Egonet to refine this prediction.

Yes. You can treat the results of the pnp algorithm as another input 3D box proposal, compute a 2D RoI from it and feed that to Ego-Net. The orientation predictions may fluctuate a bit but not too much if the 2D RoI inputs are similar.

Thanks. So just to confirm that after the pnp algorithm we do not use original 2D ROI, but compute this from the 3D ROI produced by pnp?

Thanks. So just to confirm that after the pnp algorithm we do not use original 2D ROI, but compute this from the 3D ROI produced by pnp?

Yes, During training the 2D RoIs are computed from ground truth 3D boxes.


ec probe not working

using an ezo usb board for ph, and another ezo usb board for ec, my rpi3 running hassio  shows both sensors in hardware but only “unknown” for ezo_conductivity.   not sure how to troubleshoot this but the usb ezo and ec probe work fine with windows.

I havent EC board, so I cant figure how this card is identified. Sensor module try to discover based on this:
        ezos = {"ph": ['ph', 'pH', 'mdi:alpha-h-circle'],
               "orp": ['orp', 'mV', 'mdi:alpha-r-circle'],
               "or": ['orp', 'mV', 'mdi:alpha-r-circle'],
               "do": ['dissolved_oxygen','mV', 'mdi:alpha-x-circle'],
               "d.o.": ['dissolved_oxygen','mV', 'mdi:alpha-x-circle'],
               "ec": ['conductivity', "EC", 'mdi:alpha-c-circle']}

that I found on the EZO instructions.
But I have seen that there are changes in the identification (i.e. D.O. or do). Maybe with 'ec' happens the same...
Please could you try changing sensor.py code with:
               "e.c.": ['conductivity', "EC", 'mdi:alpha-c-circle']}

I meant to update my comment.     Unless the EC probe is configured to only give back a numeric value, around line 110 of the sensor.py file, there is no error handling for any comma delimited data.   The EC probe gives multiple options for output, and the user must have the EC probe setup right to make the code not error out.    Thank you again for your work.
       r = self._read()             #self._state = float(r) + self._offset             self._state = (r)


DRAFT: Rework Pagination

Add helpers for cursor and offset pagination
Remove the need of fetching total count in cursor based pagination
Add extension method for IEnumerable for offset and cursor based pagination
(4. adds a interface test that i forgot to stash :D )

BREAKING CHANGE
This breaks out pagination provider interfaces.
That's why we should target 12.
With this PR you can easily do offset or cursor pagination with any datasource you want to have.

Remove
                new OffsetPagingArguments(skip, take ?? 0),

from
                EnumerableOffsetPagingExtensions.cs


[BUG] thrust system_error

Describe the bug
There was a recent failure in a test run that all we got back was
terminate called after throwing an instance of 'thrust::system::system_error'
  what():  parallel_for failed: cudaErrorIllegalAddress: an illegal memory access was encountered

I don't know if it is reproducible or not, but at a minimum we probably want to have the JNI CUDF layer handle thrust::system::system_error exceptions so we can get more information back about what API was being called, etc at the time.

We think this is fixed by https://github.com/rapidsai/cudf/pull/6710


pycoin won't import

I see the egg in my site packages.
And if I run pip list...
pycoin (0.1.0)
is listed but on the shell or in a script I get the follow kind of message....

import pycoin
Traceback (most recent call last):
File "<pyshell#0>", line 1, in
import pycoin
ImportError: No module named 'pycoin'

Any pointers on what else to check?

Pycoin is the name of the library, not the name of the importable package. Try import bitcoin, that should work.


Fix Flaky-test: [LoadBalancerTest].[testBrokerRanking]

Fix #11149 .
Fix LOAD_REPORT_UPDATE_MIMIMUM_INTERVAL -> LOAD_REPORT_UPDATE_MINIMUM_INTERVAL.
Fix getDynamicConfigurationDouble and getDynamicConfigurationBoolean with no defaultValue.

ping @codelipenghui

cc @gaoran10..

great to see the test fixed.
thank you !
I am concerned with the change about dynamic configuration.
do we need that change in order to make the test less flaky ?
otherwise I believe it is better to split the patch into two parts

Thanks, I will split the patch, update later.


On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app -> Login in account
Click on FAB button -> Click on Assign task option
Enter title & description
Which will navigate to Confirm task page here notice the green Confirm Task button is vertically off compare to rest of the app

Expected Result:
Green submit button of Confirm Task Should have same vertically spacing as other pages
Actual Result:
Green submit button of Confirm Task is aligned towards bottom doesn't match with other screen
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683697149428889
View all open jobs on GitHub

Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page
What is the root cause of that problem?
On confirm task page Confirm task button rendered via this code.
https://github.com/Expensify/App/blob/9fcbeba4f0adce3b2e71a895cf0bb57576725412/src/pages/tasks/NewTaskPage.js#L197-L204
That button is wrapped within Screenwrapper as shown below
https://github.com/Expensify/App/blob/9fcbeba4f0adce3b2e71a895cf0bb57576725412/src/pages/tasks/NewTaskPage.js#L153
We can see it consist includeSafeAreaPaddingBottom={false} So it will not show padding at bottom for that button.
What changes do you think we should make in order to solve the problem?
We have to set includeSafeAreaPaddingBottom={true} at line 153, it will solve the issue as shown in result video.
What alternative solutions did you explore? (Optional)
None

Results
Before
https://github.com/Expensify/App/assets/7823358/65f1f0bd-3476-435c-b45b-18c5ad16e8c1
After
https://github.com/Expensify/App/assets/7823358/78f68fa3-131c-490b-924e-6df134295203

@kavimuru I'm not seeing Tasks on my end. Is there a beta I need to be added to, in order to access them? Keep in mind I'm not an Engineer so I don't have a DEV environment.

Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page
What is the root cause of that problem?
On confirm task page Confirm task button rendered via this code.
https://github.com/Expensify/App/blob/9fcbeba4f0adce3b2e71a895cf0bb57576725412/src/pages/tasks/NewTaskPage.js#L197-L204
This button is wrapped within Screenwrapper as shown below
https://github.com/Expensify/App/blob/9fcbeba4f0adce3b2e71a895cf0bb57576725412/src/pages/tasks/NewTaskPage.js#L153
For other pages like NewTaskDetailsPage.js there is a Form component included on the page, so it will apply safeAreaPaddingBottomStyle via Form component  so we can keep includeSafeAreaPaddingBottom as false.
But for NewTaskPage.js page there is no Form component, so FormAlertWithSubmitButton does not have safe area bottom padding applied anyhow.  This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to pass includeSafeAreaPaddingBottom as true at line 153 as shown below.
<ScreenWrapper includeSafeAreaPaddingBottom>

it will solve the issue as shown in result video.
What alternative solutions did you explore? (Optional)
None

Results
Before
https://github.com/Expensify/App/assets/7823358/65f1f0bd-3476-435c-b45b-18c5ad16e8c1
After
https://github.com/Expensify/App/assets/7823358/78f68fa3-131c-490b-924e-6df134295203

Chatted to Jack, who's leading up the tasks project/implementation. He said this is fine to go to External.

Apologies, I misunderstood Jack (he meant it can go to external but we have a Task beta) - I added myself to the beta to test this, and it looks like this isn't an issue in v1.3.12-1 anymore:

Video proof:
https://github.com/Expensify/App/assets/30815269/03174b48-e321-400b-a9d7-84fdf3e57dc8

@jliexpensify This issue still exist in in v1.3.12-1. It can be reproducible in Native iOS only as shown in video.
https://github.com/Expensify/App/assets/7823358/4b22b7cd-6177-47fa-97f2-a0eeb540c8b6

Thanks @PrashantMangukiya , have edited the GH issue to reflect your findings.

Thanks, sounds good to me

@sobitneupane @flodnv Thanks. I will prepare and submit PR within two hours asap.

@sobitneupane @flodnv PR is ready for review.

Hired @PrashantMangukiya , @sobitneupane and @dhairyasenjaliya

PR merged

Paying today - @sobitneupane can you please complete the checklist? Thanks!

Everyone is paid and job is closed.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/17322

[x]  [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/17322#issuecomment-1569476960

[x]  [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1685507445902049

Regression Test Proposal

Click FAB > Assign Task
Enter Task title and description and click Next button (at bottom)
It will navigate to Confirm task screen.
Verify that "Confirm task" button has bottom margin similar to previous page button.

Do we agree 👍 or 👎

👎 because we could write a hundred tests like this.
I think instead we need a new QA guideline if it does not yet exist, something like "ensure alignment of UI items is consistent throughout the app".

@sobitneupane if you agree with Florent, do you have a new Regression Test Proposal? Thanks!

@jliexpensify we need a new QA guideline

@flodnv sorry, I misunderstood! I'm not familiar with QA Guidelines: I searched in SO but couldn't find anything.
Do I need to arrange anything for this QA guideline? (maybe adding it to this doc? - https://docs.google.com/document/d/1UaWlcieiwLnsKfeKw7iwLF7vgYRmdw_-K8OcY5aPBRU/edit)

I think this is a discussion we need to have with our QA team members

Ok great, thanks for the guidance Flo - posted here: https://expensify.slack.com/archives/C9YU7BX5M/p1686016991001429

Closing this out now, lets convene on that thread for discussion!


Sharding support

Adds sharding support.
This system has many drawbacks, as all modules are created for every single shard. This also brings up the question of when will the configuration system be added, as the amount of shards depends on the environment variables.

I'll do this later


Embed badges

https://www.npmjs.com/package/minio
in JS QS guide similar to how we show in github readme
Ported from docs.minio.io

fixed


ControlState precedence issue with button states

Duplicate Check

[x] I have searched the opened issues and there are no duplicates

Describe the bug
When defining both HOVERED and PRESSED states for a button property using ControlStateValue, the PRESSED state is ignored if HOVERED is present. This appears to be due to a lack of state precedence handling, where the HOVERED state always takes precedence over PRESSED since the button is technically still being hovered while pressed.
Code sample
Code
import flet as ft

def main(page: ft.Page):
    page.horizontal_alignment = ft.CrossAxisAlignment.CENTER
    page.vertical_alignment = ft.MainAxisAlignment.CENTER
    button = ft.TextButton(
        "Test Button",
        style=ft.ButtonStyle(
            bgcolor={
                ft.ControlState.DEFAULT: ft.colors.with_opacity(0.786, "ffffff"),
                ft.ControlState.HOVERED: ft.colors.GREEN,
                ft.ControlState.PRESSED: ft.colors.BLUE,
            }
        ),
    )
    page.add(button)

ft.app(target=main)

When clicking the button:

On hover: Changes to HOVERED color
On press: Stays at HOVERED color instead of changing to PRESSED color
On release while still hovering: Stays at HOVERED color
On mouse leave: Returns to DEFAULT color

To reproduce

run the repro code

Expected behavior
The button states should follow a clear precedence order with predictable transitions between states:
State Precedence (highest to lowest):

DISABLED/ERROR (if present)
PRESSED
HOVERED
DEFAULT

Screenshots / Videos

Captures
controlstate

Operating System
Windows
Operating system details
windows 11
Flet version
0.24.1
Regression
I'm not sure / I don't know
Suggestions
in the _wrap_attr_dict method of the Control class, since this is where Flet handles the ControlState dictionary conversion, we can process the state precedence:
class Control:
  # ... etc

  def _wrap_attr_dict(self, value: Optional[Union[Dict, Any]]) -> Optional[Dict]:
      if value is None or isinstance(value, Dict):
          # If it's already a dictionary (state values), process for precedence
          if isinstance(value, Dict):
              return self._process_state_dict(value)
          return value
      return {ControlState.DEFAULT: value}

  def _process_state_dict(self, state_dict: Dict) -> Dict:
      """
      Process a state dictionary to ensure proper state precedence.
      Called internally by _wrap_attr_dict.
      """
      # If there's only one state, no need for precedence handling
      if len(state_dict) <= 1:
          return state_dict

      # Get the current active states
      active_states = set()
      if self.disabled:
          active_states.add(ControlState.DISABLED)
      if self._get_attr("error", data_type="bool", def_value=False):
          active_states.add(ControlState.ERROR)
      if self._get_attr("pressed", data_type="bool", def_value=False):
          active_states.add(ControlState.PRESSED)
      if self._get_attr("hovered", data_type="bool", def_value=False):
          active_states.add(ControlState.HOVERED)

      # Return value based on priority
      for state in [
          ControlState.DISABLED,
          ControlState.ERROR,
          ControlState.PRESSED,
          ControlState.HOVERED,
          ControlState.DEFAULT
      ]:
          if state in active_states and state in state_dict:
              return {ControlState.DEFAULT: state_dict[state]}

      # Fallback to original default or first available value
      return {ControlState.DEFAULT: state_dict.get(
          ControlState.DEFAULT,
          next(iter(state_dict.values()))
      )}

Logs
Logs

Additional details
No response

In the upcoming v0.25.2 release, the order one provides will be the order used. This allows flexibility and eases customisation to better suit needs. (Only the position of the "default" state doesn't matter - it has the least priority amongst all and hence can be placed anywhere in the dictionary.)
So, to solve your issue with the code you provided, simple have the "pressed state" come before the "hovered" state in your dictionary.

Give the the latest pre-release a try: pip install 'flet[all]' --pre

Thanks! it works as expected now!


Incorrect active window reported in waybar (wlr/taskbar)

Hyprland Version
 System/Version info
Hyprland, built from branch main at commit 1d40af64d352bd5a87c7d53a52707fc5cfc6940e dirty (text-input-v3: move to new impl).
Date: Fri Apr 26 03:57:44 2024
Tag: v0.39.1-83-g1d40af64, commits: 4543

flags: (if any)

System Information:
System name: Linux
Node name: SoulHarsh007
Release: 6.8.7-2-cachyos-echo
Version: #1 SMP PREEMPT_DYNAMIC Fri, 19 Apr 2024 17:29:46 +0000

GPU information:
10:00.0 VGA compatible controller [0300]: NVIDIA Corporation GK208B [GeForce GT 730] [10de:1287] (rev a1) (prog-if 00 [VGA controller])
30:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Cezanne [Radeon Vega Series / Radeon Vega Mobile Series] [1002:1638] (rev c8) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Bug or Regression?
Regression
Description
It seems like incorrect active window is reported to waybar, I am using wlr/taskbar module from waybar: https://github.com/Alexays/Waybar/wiki/Module:-Taskbar and I highlight the active window using a box shadow, with newer versions of Hyprland, it seems to highlight all of my windows as "active", while with version 0.39.1 it seems to be working as expected.
Works fine with:
Hyprland, built from branch  at commit fe7b748eb668136dd0558b7c8279bfcd7ab4d759  (props: bump version to 0.39.1).
Date: Tue Apr 16 16:01:03 2024
Tag: v0.39.1, commits: 4460

How to reproduce

Install waybar.
Configure wlr/taskbar (I can provide a sample config if required).
Configure box shadow for active windows.
You see all windows highlighted as active (See screenshots for reference).

Crash reports, logs, images, videos
With Hyprland v0.39.1:

With Hyprland v0.39.1-83-g1d40af64:

+1

can I get your waybar config?

Yep, you can get a copy from here: https://git.soulharsh007.dev/soulharsh007/dots

thanks :)


KG-OBO download links are broken

This is likely due to something I changed, but the links to KG-OBO graphs are broken. This is due to the filename changing - in the json definitions ensmallen uses, they look like:
https://kg-hub.berkeleybop.io/kg-obo/bfo/2019-08-26/bfo.tar.gz
but the graph files are currently at something more like:
https://kg-hub.berkeleybop.io/kg-obo/bfo/2019-08-26/bfo_kgx_tsv.tar.gz

Closing this issue as the aforementioned errors are fixed.


In Step 3, gcc is failing

In Step 3 of https://github.com/sudoplatform-labs/ffi-tutorials/blob/main/Quick_FFI_Intro/readme.md#building-the-sample-from-github, the gcc command is failing...

gcc ../test_app/main.c -L target/debug -lcountchars

PS C:\web7sandbox\repos\ffi-tutorials\Quick_FFI_Intro\countchars> gcc ../test_app/main.c -L target/debug -lcountchars
Warning: corrupt .drectve at end of def file
C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/13.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: target/debug/countchars.lib(std-391022a4250a8b9a.std.feb3b897-cgu.0.rcgu.o):std.feb3b897-cgu.0:(.text[_ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17h9a05b46b13703ddaE]+0x39): undefined reference to `__imp_WSAStartup'
...

I think is has something to do with in compatible DLL/library formats?

https://github.com/sudoplatform-labs/ffi-tutorials/issues/9 doesn't fix https://github.com/sudoplatform-labs/ffi-tutorials/issues/8 but it is a great workaround if you have Visual Studio 2022 installed.
Closing https://github.com/sudoplatform-labs/ffi-tutorials/issues/8.

https://github.com/sudoplatform-labs/ffi-tutorials/issues/9 doesn't fix https://github.com/sudoplatform-labs/ffi-tutorials/issues/8 but it is a great workaround if you have Visual Studio 2022 installed.
Closing https://github.com/sudoplatform-labs/ffi-tutorials/issues/8.

https://github.com/sudoplatform-labs/ffi-tutorials/issues/9 doesn't fix https://github.com/sudoplatform-labs/ffi-tutorials/issues/8 but it is a great workaround if you have Visual Studio 2022 installed.
Closing https://github.com/sudoplatform-labs/ffi-tutorials/issues/8.


Upgrade to yarn V3

Which issue(s) this PR fixes #1588

@MohammadiIram I checked where the yarn cache problem came and I summarized the findings in the following pull request: #1926
Thanks for the help with this issue, unfortunately, this spiraled into a few hidden challenges that weren't considered at the beginning while writing this task.

Okay, no problem. If you need any help in the future, I'll be happy to help you.

@MohammadiIram I checked where the yarn cache problem came and I summarized the findings in the following pull request: #1926
Thanks for the help with this issue, unfortunately, this spiraled into a few hidden challenges that weren't considered at the beginning while writing this task.

Okay, no problem. If you need any help in the future, I'll be happy to help you.

On the contrary, thanks to you @MohammadiIram for taking care of this :bow:, I'm sorry that this situation had hidden challenges :face_exhaling:
If you want to work on something else, we have a few issues that might be of interest. That being said, feel free to check any issue that sounds interesting to you, even if the topic is not clear enough, we would be happy to improve the definition.
Since I'm not sure about which area will be more fun for you, I'll just drop some ideas and please feel free to check them out at your own pace or request clarifications if needed:

https://github.com/KaotoIO/kaoto-ui/pull/1926 Checking this might be interesting for seeing where are the challenges that I mentioned before.
Good first issues: Here we have what are supposed to be small issues but with good value.

https://github.com/KaotoIO/kaoto-ui/issues/1484 could be interesting if you wanna do something around the UI - config area
https://github.com/KaotoIO/kaoto-ui/issues/1232 is more focused on Typescript and might be a little bit bigger in scope :smiley:

https://github.com/KaotoIO/kaoto-ui/issues/1377 is focused on enabling the linter to check on CI, that said, if there's a pull request that has a different style it should notify it and stop the build.
https://github.com/KaotoIO/kaoto-ui/issues/1429 is focused on providing a focus trap to the mini-catalog, so the user can navigate using the keyboard arrows

Closing it in favor https://github.com/KaotoIO/kaoto-ui/pull/1926. Once again thanks @MohammadiIram for the valuable help :muscle:


[9.x] Add Model::withoutTimestamps(...)

Re-submission of #44005 as static methods.
API now matching the static nature of withoutTouching, but hopefully with a simpler implementation than previous attempts at this functionality.
$user = User::first();

// `updated_at` is not changed...

User::withoutTimestamps(
    fn () => $user->update(['reserved_at' => now()])
);

I suspect this implementation will not work as expected with nested calls to withoutTimestamps(). E.g.:
User::withoutTimestamps(function () use ($user) {

    User::withoutTimestamps(
        fn () => $user->update(['reserved_at' => now()])
    );

    $user->update([...]); // <-- Will update timestamps
});

You can imagine one would call withoutTimestamps() e.g. in a controller and then deeper somewhere in a model, in different contexts, which would lead to this situation. I think it should be fixed to be able to cope with this situation.

I did not intend for it to be used this way. Would recommend not nesting calls to this or the other methods that work this way.

Yeah, I've run into this before. Disabling timestamps is a tricky beast and heavily dependent on the use case.

I had my own implementation of withoutTimestamps on trait that was working differently.
The withoutTimestamps was a non static method that I was able to use on the existing model I am using or on an Eloquent Builder instance
On a single model
$model
    ->withoutTimestamps()
    ->update([
           'included' => true
      ]);

Updating all models by using a relationship
$tasks
            ->subTasks()
            ->tap(function (Builder $query) {
                $query->getModel()->withoutTimestamps();
            })
            ->update([
                'included' => false,
            ]);

Wouldn't both example be possible like this?
Model::withoutTimestamps(fn () => $model->update([ 'included' => true ]));

SubTask::withoutTimestamps(fn () => $task->subTasks()->update([ 'included' => false ]));

See @dennisprudlo suggestion above, and also see the previous PR where the method was not static for future discussion: https://github.com/laravel/framework/pull/44005


feat: improve message when have invalid function to the build

:tada: This PR is included in version 2.6.0-stage.16 :tada:
The release is available on:

npm package (@stage dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


expand groupby() parameter

In some business scenarios, the columns we aggregate are not fixed and unknown. We need to perform dynamic aggregation based on business configuration information, so we need to pass in dynamic columns,I looked at the source code and found that when multiple columns are passed in, it is also converted to Seq, so I expanded the parameters of groupBy() to support passing in Seq.

Your IDE seems to have reformatted Dataset.scala such that several hundred lines appear changed. It would be difficult to tell what your change is. Also, your Dataset.scala no longer follows Spark coding style. See https://spark.apache.org/contributing.html "Code style guide".
See https://spark.apache.org/contributing.html, "Pull request" for guidelines on making the pull request (and also on how to get the test workflow to run on your PR).

Your IDE seems to have reformatted Dataset.scala such that several hundred lines appear changed. It would be difficult to tell what your change is. Also, your Dataset.scala no longer follows Spark coding style. See https://spark.apache.org/contributing.html "Code style guide".
Edit: Probably best to re-apply your change to Dataset.scala without the reformatting.
See https://spark.apache.org/contributing.html, "Pull request" for guidelines on making the pull request (and also on how to get the test workflow to run on your PR).

ok


Fixing issue with RDD.reduceByKey (not working at all)

hey @wdm0006 . I find this lib very useful. I was about to start writing something like this by myself. Thanks a lot for putting this together.
I will try to contribute during some free "cycles".


Add Azure AD authentication

Authentication with Microsoft AzureAD SSO (see zulip/zulip#10618)
Fixes: #3225

@sschritt the PR looks good. Would you resolve the merge conflicts?
I think we want to merge it ASAP as discussed here https://chat.zulip.org/#narrow/stream/48-mobile/topic/Azure.20SSO
We don't currently have a server with that authentication set up to test on but I have high confidence the code is correct and should work.
We can merge it as-is.

@gnprice I did add a P1 to make the PR more visible.
It is solving a problem a customer is encountering.

@borisyankov I just went and did the rebase -- the conflicts were straightforward to resolve. Also squashed the name change into the main commit.

Two things that need to be fixed:

A test is broken.
The AuthenticationMethods type should be updated to include the new case we're acting on.

Those should be easy, so I'll just fix them and merge.

Merged! @sschritt , please try it out and confirm everything works for you.

Just to clarify, this has not been promulgated to the Google Play Store yet, right?


Farm Management: Users should be able to move farms to another 3bot

Farmers might want to move the farm managemnt of a particular farm to another 3bot. would be great to have this feature.

This is already supported by the explorer API. Farmer can change the owner of a farm.
Not sure the farm management dashboard allows it though.

https://github.com/threefoldtech/js-sdk/pull/484


Chore / naming: use signer for single credentials and wallet for credential stores

Right now we use signer and wallet rather interchangeably. Once this is clarified in Alloy (see: https://github.com/alloy-rs/alloy/issues/575) this should be downstreamed here.
Blocked until: https://github.com/alloy-rs/examples/pull/107 is merged

No longer blocked, examples and upstream were merged.


Adds navigation buttons, for convenience

What does this PR do?

Adds 'Back' button on posts#show view.
Adds 'Edit' and 'Delete' buttons on posts#show

@hslzr Looks good, thank you for the improvements!

Glad to help!


Can't get ReactPlayer to work with redirect urls

I'm not sure how to get ReactPlayer to load a url like https://domain.com/redirects/files/20.
Right now it returns a video tag in FilePlayer but no src is being set. Any ideas how to config this?

This is something I've been thinking about recently, especially with the demand for supporting blob URLs and RTSP URLs. I wonder if ReactPlayer should fall back to FilePlayer if a url is provided that no other player can play. Or perhaps a more explicit solution would be a forcePlayer prop to override the type of player to use, regardless of URL, like so:
import ReactPlayer, { FilePlayer } from 'react-player'

return (
  <ReactPlayer
    url='https://domain.com/redirects/files/20'
    playing={true}
    forcePlayer={FilePlayer}
  />
)

Hmm, would it make more sense to just have ReactPlayer default to FilePlayer and not render any of the other player components unless their config is passed in? Otherwise, I think the idea you suggested is good.

Can we get some implementation of this ASAP? Later on it'd possible to decide which method is more convenient!
Thanks making this component btw :grin:

I've pushed a possible fix to the fileplayer-default branch, if travis build passes I'll merge it in and publish a new version. Probably should be a minor version update as we lose the static canPlay method (now that any URL can technically be "played").

Fixed in 0.8.0

Bringing up, ReactPlayer doesn't seem to follow redirects, for example:
Livestream redirect
https://lb.ims-cdn.net/redirect/live/live_ims_27863_01?type=m3u8
tested with
"react-player": "^2.13.0",
also tested in demo page here:
https://cookpete.com/react-player/


scheduler: add mockCluster to ease scheduler testing

This pr resolves issue issue 752
1 add mockCluster in schedulers , and implements basic interface in schedule.Cluster.
2 move balance_test.go into schedulers
3 remove balance.go in server for duplicate code of schedulers/util.go
On the other hand, this pr imports some new bad smell code:
1 mockCluster has some duplicate code of clusterInfo in server/cache.go, due to dependency problem.
2 coordinator_test.go also some duplicate code of mockCluster, this is a remaining problem after we move balance_test.go out of server.
I plan to propose a new pr to resolve these two problems after this pr is merged

@disksing @nolouch We need to discuss about how we deal with clusterInfo in cache.go, as @nolouch proposed in his comment.
As I mentioned in pr description,  now mockCluster has many duplicate code as clusterInfo, so we should extract clusterInfo along into a separate package; but as clusterInfo depends on many data structure in server package ( struct in replication.go etc.) , these module also has to be moved into separate package like core. This change is somewhat big...
According to these problems , I have some proposals we can discuss so we can proceed for further refactor:
1  move clusterInfo into "schedules" package, or into a new package like "cluster".
2 resolve all the dependency problems caused by the movement of clusterInfo in 1.
3  whether 1 and 2  should be done in  a new pr after this pr is merged, or do it just in this pr.
As 1 and 2 caused many changes, what I prefer is open a new pr to do this, and I need your suggestion.

How about extract a cluster struct in core or scheduler contains following four fields:
stores          *core.StoresInfo
regions         *core.RegionsInfo
writeStatistics cache.Cache
readStatistics  cache.Cache

Then embed it into clusterInfo and mockClusterInfo.
@qqsun8819

Any update @qqsun8819

@siddontang I'm working on it , plan to complete it this weekend according to @disksing 's suggestion

@disksing @nolouch @siddontang PR is updated according to review comments, PTAL if you have time

LGTM.

/run-all-tests


Typescript does not support proper Touch constructor

Typescript does not support the valid Touch constructor
TypeScript Version:  2.3.1
Code
const a = new Touch({
  identifier: 2,
  target: document.body
})

Expected behavior:
It should not error because this is the valid constructor for Touch.
Actual behavior:
Errors since the constructor for Touch does not accept any parameters.

declare var Touch: {
prototype: Touch;
new(touchInit: {
target: HTMLElement,
identifier: number,
clientX?: number,
clientY?: number,
screenY?: number,
screenX?: number,
pageY?: number,
pageX?: number,
radiusX?: number,
radiusY?: number,
rotationAngle?: number,
force?: number
}): Touch;
}

Check it https://github.com/Microsoft/TypeScript/blob/master/lib/lib.dom.d.ts#L11773
declare var Touch: {
    prototype: Touch;
    new(): Touch;
}

There is now parameters in constructor function

@olegdunkan I'm sorry, I don't understand you. new(): Touch is not valid as you cannot do new Touch() to create a new one you need and instantiation object with properties target and identifier

@dblVs you wrote
declare var Touch: {
    prototype: Touch;
    new(touchInit: {
       target: HTMLElement,
       identifier: number,
       clientX?: number,
       clientY?: number,
       screenY?: number,
       screenX?: number,
       pageY?: number,
       pageX?: number,
       radiusX?: number,
       radiusY?: number,
       rotationAngle?: number,
       force?: number
     }): Touch;
}

It has got me confused because it doesn't match what I see in current lib.dom.d.ts.
You are right it have to be implemented. Sorry.

@olegdunkan ok, I edited to be more clear

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@dblVs 👍 ,
have you fix the issue? i want creat a touchevent , but the property is read-only,

@mhegazy
i want to creat a touchEvent , but the constructor need a parametertouch.
const touchEvent = new TouchEvent("touchstart", {
touches: [touch],
targetTouches: [touch],
changedTouches: [touch]
});
.but the constructor of Touch do not need any parameter .
let touch = new Touch();
but   i   need  pageX and pageY  ,

@VarLong I guess I'll add it soon. I didn't do anything on it, but I will these days when i get time.

Has been fixed by https://github.com/Microsoft/TSJS-lib-generator/pull/415

I see that this has been fixed in #24850, but my project is stuck on a 2.x version of TypeScript. How can I use new Touch({...}) without an error?

Just looking at old issues; this has been fixed in lib for a good while.


[Bug] GPU OOM

Describe the Bug
I'm using viewer with local mode to view a MR series.
After switch to MPR mode, the screen was flashing and become a black screen. There was this log in console
WebGL: CONTEXT_LOST_WEBGL: loseContext: context lost

Steps to Reproduce

Download this series: https://drive.google.com/file/d/16HItlHayUtlYWapwNMmyDeyLbJXb8TTJ/view?usp=sharing
Open viewer with local mode: https://viewer-dev.ohif.org/local
Upload dicom files
Select MPR layout Axial Primary

The current behavior

Black screen
Black viewport
GPU OOM

The expected behavior

3 viewports MPR show up with no black screen and black viewport

OS
Window 11 Home
Node version
22.11.0
Browser
Chrome Version 131.0.6778.86 (Official Build) (64-bit)

It works fine when i try it local drag and drop, and the file size is unlikely to cause oom.
https://viewer-dev.ohif.org/localbasic

I'm trying drag and drop dicom images instead of select folder
Pls look at this error message
GPU memory increase from 1.5GB to max

After flash black

That is weird, what is the spec of your system?

I'm using ASUS Zenbook 14 Flip OLED UP3404VA-KN038W (13th Gen Intel Core i5, Iris Xe Graphics)
16GB Ram 8GB GPU

Can you try this trick https://github.com/OHIF/Viewers/issues/3207

WOW. It works in my side

Yes, it's the Intel Xe series. It's frustrating, but try updating your libraries and PC; it might fix the issue. We should report it to them.

Thank you so much!


Improve handling of form character check.

If a period is in a form it is an error. If any of the other non approved characters are in a form it is a warning.

@drivenflywheel
I made a few changes. I remember we had a discussion about this approach but do not recall what you wanted me to change.

I have lost track of this and not sure where we left off. I do not think there is any more work for me to do.

Closing this due to inactivity. If this form check is still wanted then this PR can be reopened or a new solution can be submitted.


cert-manager-cainjector Panic

Stackdriver logging gives me this cainjector error every day or so (cert-manager v0.13.0)
panic: close of closed channel

goroutine 32 [running]:
main.InjectorControllerOptions.RunInjectorController.func2(0xc000080780, 0x0, 0x0, 0x1, 0x7ffc2f5ebb68, 0xb, 0x180bde0, 0xc00000e020, 0x180bde0, 0xc00000e028, ...)
    cmd/cainjector/start.go:102 +0xb8
created by main.InjectorControllerOptions.RunInjectorController
    cmd/cainjector/start.go:99 +0x11a

Full logs from Stackdriver
[
 {
   "textPayload": "panic: close of closed channel\n\ngoroutine 32 [running]:\nmain.InjectorControllerOptions.RunInjectorController.func2(0xc000080780, 0x0, 0x0, 0x1, 0x7ffc2f5ebb68, 0xb, 0x180bde0, 0xc00000e020, 0x180bde0, 0xc00000e028, ...)\n\tcmd/cainjector/start.go:102 +0xb8\ncreated by main.InjectorControllerOptions.RunInjectorController\n\tcmd/cainjector/start.go:99 +0x11a\n",
   "insertId": "bkzxp7xsfjb6azob8",
   "resource": {
     "type": "k8s_container",
     "labels": {
       "location": "europe-west2",
       "project_id": "sbs-internal",
       "cluster_name": "london",
       "pod_name": "cert-manager-cainjector-67ff67fd45-xpfxh",
       "container_name": "cert-manager",
       "namespace_name": "cert-manager"
     }
   },
   "timestamp": "2020-02-03T08:49:43.203572539Z",
   "severity": "ERROR",
   "labels": {
     "k8s-pod/app_kubernetes_io/name": "cainjector",
     "k8s-pod/app": "cainjector",
     "k8s-pod/app_kubernetes_io/instance": "cert-manager",
     "k8s-pod/app_kubernetes_io/managed-by": "Tiller",
     "k8s-pod/pod-template-hash": "67ff67fd45",
     "k8s-pod/helm_sh/chart": "cert-manager-v0.13.0"
   },
   "logName": "projects/sbs-internal/logs/stderr",
   "receiveTimestamp": "2020-02-03T08:49:55.700722687Z"
 }
]

Can you share the full stacktrace output from the stackdriver log? It looks like this is truncated in the Stackdriver UI.
/kind bug
/area cainjector

Also encounter this. Seems to occur whenever the cainjector is migrated to a new node.
Unfortunately my stacktrace doesn't give much more information:
panic: close of closed channel
goroutine 49 [running]: main.InjectorControllerOptions.RunInjectorController.func1(0xc000336240, 0x0, 0x0, 0x1, 0x7ffdaae47b6d, 0xb, 0x180bde0, 0xc0000c4008, 0x180bde0, 0xc0000c4010, ...) 	cmd/cainjector/start.go:98 +0xb8 created by main.InjectorControllerOptions.RunInjectorController 	cmd/cainjector/start.go:95 +0xaa
Environment details:

Kubernetes version (e.g. v1.10.2): 1.15.8
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): GKE
cert-manager version (e.g. v0.4.0): 0.13.1
Install method (e.g. helm or static manifests): Static manifest

/priority backlog
/remote-triage needs-information
/area cainjector

/remove-triage needs-information

Just to confirm I am still seeing this. Just upgraded to 0.15.1 and got the error again (presumably as the old container was shut down)

I saw this too with Helm chart v0.13.0. I should probably upgrade when I have time 👍

This panic happens in cert-manager v0.13.0 through v0.16.1. It was fixed in v1.0.0 (8b7552cec19c4e95ae7818315bb108d13d12527b)
The panic was due to a race condition in the cainjector when two close statements would race with each other when the cainjector is stopping.
Since the panic was resolved in cert-manager v1.0.0, I will close this issue.


Embedded ansible Awx is broken with latest docker image

Hello Team,
Since latest build of awx on docker, integration is broken with MIQ.
It seems to be related to this commit : https://github.com/ansible/awx/commit/2b6cf971573185a46950c5a8fa3f9de14ede38ae#diff-0733e8e96294f6558655f0208e6d1d65
Container Logs report the following :

docker logs awx_web
2019-03-28 18:08:52,734 INFO success: daphne entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
Traceback (most recent call last):
File "/var/lib/awx/venv/awx/bin/daphne", line 11, in
sys.exit(CommandLineInterface.entrypoint())
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/daphne/cli.py", line 144, in entrypoint
cls().run(sys.argv[1:])
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/daphne/cli.py", line 174, in run
channel_layer = importlib.import_module(module_path)
File "/usr/lib64/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/awx/asgi.py", line 9, in
prepare_env() # NOQA
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/awx/init.py", line 89, in prepare_env
if not settings.DEBUG: # pragma: no cover
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/django/conf/init.py", line 56, in getattr
self._setup(name)
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/django/conf/init.py", line 41, in _setup
self._wrapped = Settings(settings_module)
File "/var/lib/awx/venv/awx/lib64/python3.6/site-packages/django/conf/init.py", line 129, in init
raise ImproperlyConfigured("The SECRET_KEY setting must not be empty.")
django.core.exceptions.ImproperlyConfigured: The SECRET_KEY setting must not be empty.

Workaround (to be tested) :
force awx version to 3.0.1 in settings.yml ( web_image_tag & task_image_tag)

I confirmed this issue from a fresh hammer-4 MIQ vmware appliance.
[root@hammer-4 log]# tail -5  evm.log  |grep Ansible
[----] I, [2019-04-11T06:59:58.885392 #6819:47fd948]  INFO -- : MIQ(DockerEmbeddedAnsible#start) Waiting for Ansible container to respond
[----] I, [2019-04-11T07:00:00.184599 #6819:47fd948]  INFO -- : MIQ(DockerEmbeddedAnsible#start) Waiting for Ansible container to respond
[----] I, [2019-04-11T07:00:01.477407 #6819:47fd948]  INFO -- : MIQ(DockerEmbeddedAnsible#start) Waiting for Ansible container to respond
[----] I, [2019-04-11T07:00:02.755445 #6819:47fd948]  INFO -- : MIQ(DockerEmbeddedAnsible#start) Waiting for Ansible container to respond
[----] I, [2019-04-11T07:00:04.127815 #6819:47fd948]  INFO -- : MIQ(DockerEmbeddedAnsible#start) Waiting for Ansible container to respond
[root@hammer-4 log]#

containers looks fine.

[root@hammer-4 log]# docker ps -a
CONTAINER ID        IMAGE                     COMMAND                  CREATED              STATUS              PORTS                                NAMES
7e499ad22df7        ansible/awx_task:latest   "/tini -- /bin/sh ..."   About a minute ago   Up About a minute   8052/tcp                             awx_task
a3f833bf4a8f        ansible/awx_web:latest    "/tini -- /bin/sh ..."   About a minute ago   Up About a minute   <IP_ADDRESS>:54321->8052/tcp              awx_web
bff383a0b5ac        memcached:alpine          "docker-entrypoint..."   About a minute ago   Up About a minute   11211/tcp                            memcached
0207ac1e4a1a        rabbitmq:3                "docker-entrypoint..."   About a minute ago   Up About a minute   4369/tcp, 5671-5672/tcp, 25672/tcp   rabbitmq
[root@hammer-4 log]#

Same problem with hammer-5.20190424144425_1d4816f. SECRET_KEY not found

@carbonin ?

Workaround (to be tested) :
force awx version to 3.0.1 in settings.yml ( web_image_tag & task_image_tag)

@carbonin I wonder if we should just hardcode this value, particularly for hammer.

Yeah, I think that's a safe change. Maybe make that to master and we can curate upgrades of the image a bit more closely.

do you think is it possible to have more advanced configuration option in manageiq UI ? For example, to set docker image for "pré-installed/running" 4.0 version of awx ? Or because I have my personnalized AWX images with pwsh and some others ansible plugins installed.

@nORKy54 All of the images and tags are fully configurable in the advanced settings screen. The defaults can be seen here https://github.com/ManageIQ/manageiq/blob/master/config/settings.yml#L135-L143

We're in the process of re-working how we implement the embedded ansible feature. Can you please re-test this on the Ivanchuk Beta and see if that resolves your issue?

@nikobo is it possible to retest with Ivanchuk release?

Closing this as embedded ansible has been re-implemented to remove the dependency on the awx images as of the ivanchuk release.


fix: Removed duplicate GenerateThumbnailsHandler service registration

1. Why is this change necessary?
The same service is also registered in the media service XML file:
https://github.com/shopware/platform/blob/ca23dd84c17881159206ef33207405f8db5fe8c7/src/Core/Content/DependencyInjection/media.xml#L53-L58
2. What does this change do, exactly?
Remove the duplication.
3. Describe each step to reproduce the issue or behaviour.
-
4. Please link to the relevant issues (if any).
-
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

🤖 Generated by Copilot at b3e4595
This pull request removes a duplicate service registration of the GenerateThumbnailsHandler class that caused a cache error. It also adds a changelog entry for the fix.

🤖 Generated by Copilot at b3e4595

Remove duplicate service registration of GenerateThumbnailsHandler class (link)
Add changelog entry for the pull request (link)

Thanks for your contribution, your PR got merged! :tada: :blue_heart:


email_change_current and email_change_new do not work as expected in  supabase-js gotrue library.

Bug report
Describe the bug
Check this comment I created here on the gotrue pull 560
I have highlighted the issue I bumped into while using supabse-js to generate email_change_newandemal_change_current`links.

Hello folks is this change supported in the Supbase client libraries:
I am using Supabase in a project I am working on, I am getting weird errors when I try to generate the link using this API route what could be the problem?
import supabaseServer from '../../lib/supabaseServer';

const handler = async (req, res) => {
	const resData = await supabaseServer.auth.api.generateLink(
		'email_change_current',
<EMAIL_ADDRESS>	);
	console.log(resData);
	return res.status(200).send({
		message: 'It was successful'
	});
};

export default handler;

When I hit the above API route I get the following errors based on the email provided, both registered(current) and unregisted(new_email).

When I pass the second argument to the  generateLink function as my new email, I get the following error

  {
    "code": 404,
    "msg": "User not found"
  }

When I pass the second argument to the generateLink function as my current email: I get the following error

{
 "code": 422,
 "msg": "The new email address provided is invalid"
}

Seeing the above errors made me look at the<EMAIL_ADDRESS>and found the generateLink method which does not provide a way to provide the new_email  as an argument or an option. Which is the cause of the two weird errors seen above.
async generateLink(
    type:
      | 'signup'
      | 'magiclink'
      | 'recovery'
      | 'invite'
      | 'email_change_current'
      | 'email_change_new',
    email: string,
    options: {
      password?: string
      data?: object
      redirectTo?: string
    } = {}
  ): Promise<{ data: Session | User | null; error: ApiError | null }> {
    try {
      const data: any = await post(
        this.fetch,
        `${this.url}/admin/generate_link`,
        {
          type,
          email,
          password: options.password,
          data: options.data,
          redirect_to: options.redirectTo,
        },
        { headers: this.headers }
      )
      return { data, error: null }
    } catch (e) {
      return { data: null, error: e as ApiError }
    }
  }

Having the above I tested the following code on the same API route and it worked seamlessly. Take note the example given above in the What is new behavior cURL example is incomplete as it does not provide an apikey in the header for the request to work successfully.
Below is the same using Axios library,
import axios from 'axios';

//the request options
const  options = {
  method: 'POST',
  url: 'https://<project>.supabase.co/auth/v1/admin/generate_link',
  headers: {
    apikey: '<service_role_key_goes_here>',
    Authorization: 'Bearer <service_role_key_goes_here>',
  },
  data: {
    type: 'email_change_new', //or 'email_change_current' for the second link to be returned
    new_email<EMAIL_ADDRESS>    email<EMAIL_ADDRESS>  }
};

axios.request(options).then(function (response) {
  console.log(response.data);
}).catch(function (error) {
  console.error(error);
});

I think the major problem is with the @supabase-js library which does not provide the mechanism to provide the second email. If the above info is not clear please let me know. Thanks in advance.

To Reproduce
I have highlighted all the steps in that comment.

Hey @404Xavier, this issue is fixed in the rc branch (supabase-js v2). Thanks for taking the time to highlight the issue, we'll make the corresponding fix to v1 for backward compatibility.


Android support

Hello @EddyVerbruggen ! First, thanks for all the amazing plugins that you have been developing.
I wondering if this plugin will have support to android ? I really need this feature :/

Hi! And thanks :)
I'm not planning on adding Android support, but I'm open to any contributions if somebody wants to have a go at it.

@EddyVerbruggen cool ! unfortunately i don't have to much knowledge on mobile (and web hehe) development, otherwise i would gladly help :/


auditlog: add documentation (ru,en)

For both russian and english versions:

split info about schema operation audit into a separate article
add article about DML operation audit
add article about client connection audit
update general audit logging info

And:

make russian and english versions more consistent with each other

KIKIMR-18688
KIKIMR-18697
YDBDOCS-222
Changelog category

Documentation

@ijon, do you intend to finish this PR based on review comments? It also needs to be merged with main as there are some conflicts.

@ijon, do you intend to finish this PR based on review comments?

Of course I do.

@ijon ping

@ijon this has conflicts that need to be resolved

@ijon ping